How to use root correctly?

Thanks for building this and sharing it!
My directory structure looks like this
My-Component/
    dist/
    lib/
    some-other-stuff/
    tsconfig.json

My vitejs build options are
 build: {
    lib: {
      entry: path.resolve(__dirname, 'lib/index.ts'),
      name: 'my-component',
      fileName: (format) => `my-component.${format}.js`,
    }
  },

If I use the plugin with the default options, vite-plugin-dts creates the files:
dist/
    lib/
        <stuff>.d.ts

That's good. But what I want to achieve is
dist/
    typings/
        <stuff>.d.ts

So I tried this
dts({
      root: 'lib',
      outputDir: 'dist/typings',
      tsConfigFilePath: '../tsconfig.json',
    }),

This runs without any errors:
[vite:dts] Start generate declaration files...
[vite:dts] Declaration files built in 5776ms.

However, now my dist directory does contain any output from the plugin. Setting logDiagnostics:true does not cause the plugin to tell me what it is doing or where it is putting the files.
So my question is, how do I set the options so that I can get the output structure I need?
Thanks!

root option is using for monorepo in some cases, not necessary to change it usually.
Is your vite.config.ts in 'lib' dir ?
(it would be better for vite.config.ts and tsconfig.json in the same dir, defaults in root)
Normally you set outputDir: 'dist/typings', you will get like following paths after building:
{root}/dist/typings/lib/<stuff>.d.ts
And the type entry is the file with the same name as lib.entry: {root}/dist/typings/lib/index.d.ts
You can set "types": "dist/typings/lib/index.d.ts" in package.json to make it effective.
It's helpful that you can provide a reproductive repo.

Same issue here. I am using Vite in a Node.js script, so here is no vite.config.ts in the library repo.
The actual output is:
dist
├── index.cjs.js
├── index.esm.js
├── index.umd.js
├── src
|   ├── Button.d.ts
|   └── index.d.ts
└── style.css

The dist/src folder is not necessary.
Expected output should be:
dist
├── index.cjs.js
├── index.esm.js
├── Button.d.ts
├── index.d.ts
├── index.umd.js
└── style.css

Currently you can use entryRoot option to specify a entry root, the output relative paths will be calculated according to it, and it will be auto calculated as the smallest public path of all files if it is not set.
expect(
  queryPublicPath(['E:\\project\\src\\lib\\a.d.ts', 'E:\\project\\src\\lib\\b.d.ts'])
).toBe('E:\\project\\src\\lib')

// outputs: 'dist/a.d.ts' and 'dist/b.d.ts'


Update rope.py

Renamed the function to apply_rotary_positional_embedding to make it more descriptive and follow PEP 8 naming conventions. Used more descriptive variable names, such as cos_embeddings and sin_embeddings, to improve code readability. Added a return type hint to indicate that the function returns a tuple of two tensors.
Summary

Testing Done

Hardware Type:
[ ] run make test to ensure correctness
[ ] run make checkstyle to ensure code style
[ ] run make test-convergence to ensure convergence

@Yash-2707 please
run make test to ensure correctness
run make checkstyle to ensure code style
run make test-convergence to ensure convergence


updated metrics and service monitoring logic generated by operator-sd…

Updated metrics and monitoring logic generated by operator-sdk v15+ version.

Do I need to update the operator-sdk for this?

Not required it is available in 0.15.1 as well.

After I apply these I see an error during make build:
build github.com/operator-framework/operator-sdk/pkg/kube-metrics: cannot load github.com/operator-framework/operator-sdk/pkg/kube-metrics: open /home/shawkins/workspaces/teiidsb/teiid-operator/vendor/github.com/operator-framework/operator-sdk/pkg/kube-metrics: no such file or directory
I had to run $go mod vendor
That makes quite a few updates under vendor and a change to go.sum.  @rareddy do you want that all checked in as well?

I will fix this as part of this issue. Give me few minutes

Ok, done. You can update now. Thanks

The next issue is that the operator pod log is filled with errors.  At a rate of 2 per second we see:
E0402 18:19:13.457042       1 reflector.go:123] github.com/operator-framework/operator-sdk/pkg/kube-metrics/store.go:65: Failed to list *unstructured.Unstructured: pods "proxy" not found
E0402 18:19:13.610239       1 reflector.go:123] github.com/operator-framework/operator-sdk/pkg/kube-metrics/store.go:65: Failed to list *unstructured.Unstructured: deploymentconfigs.apps.openshift.io "log" not found
E0402 18:19:14.461453       1 reflector.go:123] github.com/operator-framework/operator-sdk/pkg/kube-metrics/store.go:65: Failed to list *unstructured.Unstructured: pods "proxy" not found
E0402 18:19:14.625670       1 reflector.go:123] github.com/operator-framework/operator-sdk/pkg/kube-metrics/store.go:65: Failed to list *unstructured.Unstructured: deploymentconfigs.apps.openshift.io "log" not found

This seems to be more problematic, I fixed all but one error, I am looking for a solution. Meanwhile, if you want you can just install the OPerator from Operator hub and use that

@akoserwal I updated many permissions but I am still seeing
Failed to watch *unstructured.Unstructured: the server does not allow this method on the requested resource
Failed to list *unstructured.Unstructured: the server could not find the requested resource

do you know what permission this needs, btw my operator is not a cluster-wide operator, it is namespace operator.

@rareddy: This might be the case: https://github.com/operator-framework/operator-sdk/blob/master/doc/user-guide.md#default-metrics-exported-with-3rd-party-resource


[Bug]: Decryption Error

Client version
1.6.0
Node version
command not found error in console
Operating System type
Other
Operating system version
Hass 10.3 Core 2023.7.3
Describe the bug
Since today after the update i get the followinf error:
2023-08-02 05:35:00.493  INFO  Eufy Security server listening on host <IP_ADDRESS>, port 3000
2023-08-02 05:35:00.646  ERROR Data decryption error, invalidating session data and reconnecting...
Error  error:06065064:digital envelope routines:EVP_DecryptFinal_ex:bad decrypt
details:
{
library: 'digital envelope routines',
function: 'EVP_DecryptFinal_ex',
reason: 'bad decrypt',
code: 'ERR_OSSL_EVP_BAD_DECRYPT'
}
To reproduce
Direkt in the log at start the error occurs.
Screenshots & Logfiles
No response
Additional context
No response

This is happening one time only right?

right

the new version from yesterday it works again. Better than bevor.

solved


Windows 10 - "Virus scan failed" or "Virus detected"

Experienced:
I attempted to download the mtuner64.msi with Chrome Version 60.0.3112.90 (Official Build) (64-bit) on Windows 10 with windows defender installed.
Chrome/Windows/Defender blocked the download with the following error message.

"Virus scan failed" or "Virus detected"

Expected
The install file not to detect the install files as a virus.

msi file isn't signed and neither is the MTuner exectuble, since certificates are not cheap, this will likely remain so.

The virus detection is unrelated to executable signature. What is more, windows defender is not the only one which detects a virus, as can be seen here: https://www.virustotal.com/fr/file/8aa7617ea2e830aa5f5b4ab0f951e1bf0b905d55f95da429114861b154133f92/analysis/1504519168/
The virus seems to be located in MTuner.cab->MtunerCmdl
Please reopen this issue

I have both Windows defender and Avast running and can't reproduce this or detect a virus.
In any case, I'll recompile MTunerCmd to double check and possibly re-upload files - if I find anything suspicious.

Ok, this is getting weird... office computer does 'detect a virus' with defender.
But, downloading MSI through FTP and installing it gives me the same dir structure as ZIP file, as it should. Here's the weird part - binary compare of those files confirms that all files are identical between MSI and ZIP archives. However, nothing is reported for the ZIP file or it's contents when decompressed.
I will remove MSI file for the moment as I don't have time to look into this right now.

I was able to track this down to retail configuration of MTuner.com vs release/debug configurations.
Compiling in retail triggers false positives by several anti viruses - not really sure why.
I'll upload the "clean" releases later today.

Update: turns out command line programs that have no user input or no output tend to trigger this with anti-viruses.  I modified the behavior and it seems to be 'ok' now.
Still need to wait for the new release to finally close this...

New release is up, scanned with defender, downloaded fine, etc.
I've scanned unpacked files as well, just to be sure, came out clean.
VirusTotal report is here:
https://www.virustotal.com/#/file/b2787447ea4eed8e7b6ec51f93990c51085efc3b66353bf6b6732480d9309d41/detection


Couple of updates

add getFWHM method for ROOT histoes utils
Add a custom functor for the average computation over a vector. The default one is the vector value, so back compatibility is there.

Nice additions!
For the FWHM, can you change the naming of the function to follow the camel convention? Also can you add a more explicit name to show that it's related to histograms? For example you could go with getHistogramFwhm().
The camel convention makes accronyms look a bit weard, but it stays lisible when we chain with another trailing word

Hey! No problem, done!

Cool thank you! :)

Is it ready to merge? 😛

Is it ready to merge? 😛

Hope so :)


Find Normal and Trace of a matrix using array

Related Issue

Mention issue for which this pull request is a part of (please mention issue number # )
#527

Proposed Changes
I have added trace and normal of matrix
Additional Info

properties of trace matrix
--> tr(A + B) = tr(A) +tr(B)
--> tr(cA) = ctr(A)  ** c represents scalars
--> tr(A) = tr(A^T)  ** T means transpose of matrix

Checklist

[x] ✅ My code follows the code style of this project.
[x] 📝 My change requires a change to the README.
[x] 🎀 I have updated the README accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[x] ✨ I have added tests to cover my changes.
[x] 🚩 All new and existing tests passed.
[x] 🌟 ed the repo

The trace of a matrix A, defined by tr(A), is the sum of the diagonal elements of a matrix. Trace of a matrix is only possible for square matrix .
The normal of matrix is the sum of all the elements of a matrix and then the square root of sum.

I have taken two examples look at the output screenshot to understand

I have  used code blocks to implement this code .

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots
| Screenshot #1      | Screenshot #2  |
#1
output when we use 3X3 matrix
#2
output when we use 2X2 matrix

Change your C++ file directory from [A-Array/TwoD Array/TraceAndNormal.cpp] to [A-Array/TraceAndNormal.cpp]

sir I have made the changes pls review it

Ma'am I have made the changes, pls review it.

@all-contributors please add @aparnamittal code ,


SimplePool publish callbacks broken

I think one of the latest releases broke pub callbacks (?). Have not found time to debug yet, but pub.on('ok', cb) is no longer being fired for me. Can anyone reproduce?

@Egge7 I'm having same problem too.

It is an issue for me too

Fixed in v1.8.2.


⚠ Adacta-fintech.com has degraded performance

In 82aa044, Adacta-fintech.com (https://www.adacta-fintech.com) experienced degraded performance:

HTTP code: 200
Response time: 1547 ms

Resolved: Adacta-fintech.com performance has improved in f6bf2e2 after 7 minutes.


Can't Import Tensor Flow in Annaconda Python 3.6

I just installed CUDA 9.2 and CUDANN and Tensor Flow on Windows 10.  I'm using Anaconda 3.6 Python.
Here is a trace that I get when I try to import tensor flow.  It's telling me it can't load a dll but its is not telling me which one.  Can you help.
Here is a directory listing of the CUDA dlls in my path and the trace.

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "C:\Program Files\Anaconda3\lib\site-packages\tensorflow_init_.py", line 24, in
from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-import
File "C:\Program Files\Anaconda3\lib\site-packages\tensorflow\python_init_.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "C:\Program Files\Anaconda3\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 74, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "C:\Program Files\Anaconda3\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Program Files\Anaconda3\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 18, in
pywrap_tensorflow_internal = swig_import_helper()
File "C:\Program Files\Anaconda3\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 17, in swig_import_helper
return importlib.import_module(mname)
File "C:\Program Files\Anaconda3\lib\importlib_init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
ImportError: DLL load failed: The specified module could not be found.
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/install_sources#common_installation_problems
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.

File "C:\Program Files\Anaconda3\lib\importlib_init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
ImportError: DLL load failed: The specified module could not be found
maybe you can just add print(name[leval:]) in importlib_init.py to locate which dll load failed.

Nagging Assignee @shivaniag: It has been 17 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Thank you for getting back to me. I found that the problem was caused by the fact that I installed the latest version of the CUDA library. I downgraded to one version earlier and everything worked.
RegardsCraig
Sent from Yahoo Mail for iPhone
On Sunday, July 29, 2018, 5:25 PM, Gunhan Gulsoy<EMAIL_ADDRESS>wrote:
What is your CPU model? I suspect this may be a duplicate of #19584
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for the response.
Closing this issue then.


[Android & Sched] - small fixes and updates

For the Android app, it seems better to let Sched's default alarm settings handle things like vibration, auto-snooze, and repeat for GB alarms.
As for Sched, if a nonexistent js file is specified in an alarm's js field, the watch will be stuck on a screen which says "Loading..." until auto-snooze kicks in, and then repeats 10 mins later (or however long your AS is set to). Sched will now check to see if the js file exists - if not, it will default to sched.js. It seems to handle alarms with no js field just fine as well.

Thanks! Please can you bump the version numbers in metadata?

Thanks!


Auditing support for admin activities

It would be useful to track changes made by admin users to WSFS members.

The Django admin interface has built in auditing for admin actions.


Timeout while connecting shop to WP plugin

Problem:
While connecting epages-online-shop plugin to Wordpress site, (sometimes) slowly responding REST API connection times out, and throws an "http_request_failed" error. Default timeout length for wp_remote_get function is 5 seconds, which is too low.
https://github.com/ePages-de/ePages-wordpress-plugin/blob/master/functions/options_page.php#L19
WP version: 4.6.1-sv_SE
epages-online-shop: 5.0.10
Solution:
Increase wp_remote_get timeout length to e.g. 15 seconds
https://codex.wordpress.org/Function_Reference/wp_remote_get
static $epages_api_http_options = array(
  "headers" => array(
    "Accept"        => "application/vnd.epages.v1+json"
  ),
  "user-agent" => "epages-WP",
  "timeout" => "15"
);

Logs:
PHP message: [EPAGES] Trying to validate shop URL: https://secure.vilkasgroup.com/rs/shops/mikko01/
PHP message: [EPAGES] WP_Error Object
(
    [errors] => Array
        (
            [http_request_failed] => Array
                (
                    [0] => Operation timed out after 5000 milliseconds with 0 bytes received
                )

        )

    [error_data] => Array
        (
        )

)

Fixed on 44fa9d51c99fb4b23d6ed3d4702d5d4a2e0656f2. Thanks a lot @pitkane!
It'll be live in a couple of days.


Re-implement script loading

There's no way for the messages to be processed right now.  Just need to re-implement.

Done


New Group Mogilevich

http://dkgn45pinr7nwvdaehemcrpgcjqf4fooit3c4gjw6dhzrp443ctvnoad.onion

Thanks
I've just add this new gang with a parser. RSS will be update in the next minutes.


API Client Generation - Strange naming of folder inside of client folder

This isn't necessarily a bug, just a behavior I can't quite understand and I find it annoying.
Here is the command I am running: swagger generate client -f "swagger.json" -A "docreq" -c "docrequesterclient" -m "docrequestermodels"
And the swagger.json file has this info:
"info": {
"description": "****",
"title": "Swagger docrequester API",
"contact": {},
"version": "1.0"
}
I find that the docrequesterclient folder contains a folder named "doc_requester" which includes the functions to call the API. But why is it named "doc_requester" ??? I never specified this spelling with the "_" in the command or in the swagger documentation. What kind of strange parsing is going on here?

do you have a tag or something on your operations?

I've done a find all for that tag and nothing. Maybe I will check again...

I have tags that are pascal case like this:
"tags": [
                    "DocRequester"
                ],

Okay, I took out tags and that fixed it. That's what it was. Would be good to document this more specifically I don't think it's documented a lot. I now use the -a CLI param to specify the name of the operations package so I would recommend that to future people having trouble with this. You may also have to delete the tags.


Stable release timeline

Hi Team, Is there any timeline or ETA for the stable version of botostubs ?

+1 on this issue, also for Boto3.
Thanks,

shameless plug: I have an open-source project under the same name which does what you want; predictable releases, comprehensive feature coverage, support for resources, waiters, etc.
https://github.com/jeshan/botostubs

@jeshan maybe join forces with https://pypi.org/project/boto3-stubs ?

@reegnz heh. Maybe someday when I have time :)
One of my users told me that depending on mypy may be an issue (I have zero experience with mypy) and requires less code change. Is that accurate? What's your experience like?


Spelling fixes

Obviously not a high priority, but some fixes for spelling errors and double words in comments.

Thank you!


Old scope.setVar() is still being used for some of the sentences

I think it may be less robust than .getField() and .setField(). It may not handle fields that have show if field properties. I'm considering repurposing it. Maybe it can use .getField() etc. to get, set, and return whether the field was disabled, enabled, or non-existant (true, false, null or something).

We can just make a call to scope.setFields() now with artificial data, as with the I set the var __ to __ Step.


oidc-sso anonymous user enabling optional

Please use the form below, leaving the prefilled data to help us. Thank you.
Page link: oidc-sso
Document link: oidc.md
My Issue/Suggestion
Hey there!
Why is the enabling of anonymous users part of the OIDC documentation [0]? As for me the OIDC module works just fine without enabling it and it moreof seems like a security issue for me. In my opinion this step should at least be marked as optional. Or is there something I'm missing out on?
[0] https://docs.mendix.com/appstore/modules/oidc/#42-allowing-anonymous-users

Hi,
Thank you for bringing this to our attention. I have been in contact with the developers and they have explained why anonymous users are required and have identified that a piece of configuration was left out of the documentation.
I've updated the documentation to add the missing configuration and explain why anonymous users are required. Please see the Pull Request https://github.com/mendix/docs/pull/5750 for details of the changes.
In summary, my understanding is that the anonymous user access is used in two circumstances:

When there are multiple IdPs configured, to allow the end user to choose which IdP to use.
When the end user signs out, to show them a page where they can choose to sign back in again if required.

Without this access, the OIDC module will still work to log users in, but you may want to test these specific scenarios and ensure that your app behaves as you want it.
I offered your suggestion of making the step optional, but the developers felt that this would affect how the module is supposed to work.
Thanks you for raising this issue and helping us identify some missing documentation.
Yours
Mark van Ments.


Video Recordings Just Show Blank Screen or Don't Play At All

We are using grid extras on 2 Windows Server 2012R2 machines. One machine is a hub and node and the second machine is just a node. Both are virtual machines. I have configured the hub/node machine with essentially just the default settings.
I have looked at other video issues and saw one issue that said video fails to record when hub/node are on same machine which may be occurring here, but the videos from the machine that is just the node also do not display anything. It appears that some of the videos recorded something as I can see the selenium calls being made, but the screen is just black.
Any suggestions? Please let me know what other info is needed and I will provide.

Ignore this issue, we were passing some incorrect desired capabilities in that seem to have caused the problem


Set node config action to append if it's not defined

Description

@joepavitt I did couple of testings on my local instance but I couldn't recreate it

https://github.com/user-attachments/assets/24531451-eb61-4391-ab8b-6c1fd012f93c

But when I did the same on the dashboard demos instance I could recreate the scenario https://dashboard-demos-dev.flowfuse.cloud/dashboard/table-1

Assuming the root cause is with setting the default in ui_table.js I'm creating this PR and keeping as draft until I get this confirmed with @joepavitt
Related Issue(s)
https://github.com/FlowFuse/node-red-dashboard/issues/1407
Checklist

[x] I have read the contribution guidelines
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

[ ] Upgrade instructions
[ ] Configuration details
[ ] Concepts

[ ] Changes flowforge.yml?

[ ] Issue/PR raised on FlowFuse/helm to update ConfigMap Template
[ ] Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

[ ] Includes a DB migration? -> add the area:migration label

Code changes looked fine, but all table-based tests are failing

Code changes looked fine, but all table-based tests are failing

This has happened due to default action method "append". This is fixed with https://github.com/FlowFuse/node-red-dashboard/pull/1408/commits/63bea01c9487e418bda21612884b64ce8ee274b1
Ready for review


Remove bundle install as prereq for release workflow

I am trying to remove a circular dependency of isodoc on isodoc-i18n:
isodoc depends on mn-requirements
mn-requirements depends on isodoc-i18n
isodoc depends on isodoc-i18n
mn-requirements depends on isodoc (development only)
I am removing the dependency of isodoc on isodoc-i18n tomorrow, and I'm trying to release mn-requirements today; but bundle install + the development dependency on mn-requirements are preventing me from running release.
I understand that we are releasing bundle install from all release tasks, in order to deal with this kind of circularity?

@opoudjis this is our current release workflow https://github.com/metanorma/ci/blob/main/.github/workflows/rubygems-release.yml
I easily can remove bundler-cache: true from it and it will be applied to most our repos
The question is will bundle exec rake release command work without prior bundle install?
Or should we install rake with gem install rake?

Done
Per discussion with @opoudjis rake is a preinstalled gem so it safe to remove bundle install


Check early stopping value under evaluation mode

Currently, the early stopping criteria was evaluated on the validation set (as desired) but on training mode. This is not an appropriate mode for evaluating validation score and also has undesirable side effect of allowing some values such as BathNorm stats to be learned partially on the validation set. This was fixed by ensuring that the validation objective is evaluated on evaluation mode of the model (i.e. after calling model.eval()). The model's training status is immediately restored to it's previous value following the evaluation of the objective.

Made modification based on our discussion. Now early_stopping accepts switch_mode keyword argument to control whether it will apply model.eval() prior to objective evaluation.


adapter.notifyItemChanged(pos, item) not working

I'm trying to update views but only parent items got updates. Children stay not updated. Example:
if I have Parent with one child. Then I have add one more child and update parent by running notifyItemChanged(parentPosition, parentObject). I saw the same list.
modifyItem() not working too.
How to fix this?

You can use Epoxy


Homebrew support

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
This PR provides automated update for yt-dlp Homebrew formulae, and guide for installation in README.
For users using macOS, please try running brew install yt-dlp/taps/yt-dlp and let me know if it works. Thanks
edit: got report that installation on macOS was successful. thanks @gaato
@pukkandan Can you please create a new PAT and add it to secrets as GH_TOKEN? it is required to update homebrew-taps repository.
This PR is in draft state until PAT is ready.

@pukkandan ready for merge, script is working locally

It might be better to maintain the homebrew-core index instead.
Right now it can be installed via brew install yt-dlp.

@chenrui333 The .tar.gz file in Releases has a problem that it doesn't contain source code. So one in core does not work.
And also, homebrew-core requires PR to be merged, which cannot be automated. This PR is to aimed to automate version update for formulae.

You can send pull request to update homebrew formula automatically with GitHub Action, please check out https://github.com/dawidd6/action-homebrew-bump-formula and https://github.com/mislav/bump-homebrew-formula-action.

You can send pull request to update homebrew formula automatically with GitHub Action, please check out dawidd6/action-homebrew-bump-formula and mislav/bump-homebrew-formula-action.

PRs for this is welcome as well


Linux  freezes when using the VSCode

Guys, I notice that, every single time that I'm using the Visual Studio code on my Linux machine, it just freezes the whole system, not even the mouse I was able to access. This problem have been happening frequently and I took a time to figure it out that was happening just when I was using the VS code or when I left the VS Code opened.  I went into internet and I found lot of people complaining about the same problem

I've noticed that happens when I run out of memory, so keep an eye on your resources would be my suggestion. Did I mention I'm ordering a laptop with more memory? :)

I have 16GB  of memory and I was not running anything together, just the chrome and a jupyter with just one notebook opened :-(
On Saturday, August 17, 2019, 12:10:23 AM GMT-3, Brian Wells<EMAIL_ADDRESS>wrote:
I've noticed that happens when I run out of memory, so keep an eye on your resources would be my suggestion. Did I mention I'm ordering a laptop with more memory? :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I have 16 gig too, and Chrome/Docker/VSCode eat away at it, especially over a period of days if I don't reboot. Not saying this has to be your problem, but that's been my experience, and when it runs out of swap drive and ram... you can't even move your mouse hardly.

I kept the htop running and the average memory consume was 5 GB. I will keep a track on it
Thank you Brian
On Saturday, August 17, 2019, 12:19:50 AM GMT-3, Brian Wells<EMAIL_ADDRESS>wrote:
I have 16 gig too, and Chrome/Docker/VSCode eat away at it, especially over a period of days if I don't reboot. Not saying this has to be your problem, but that's been my experience, and when it runs out of swap drive and ram... you can't even move your mouse hardly.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Please follow this guide to report more details
https://github.com/microsoft/vscode/wiki/Performance-Issues
Thanks

Thank you,
I will do that
Cheers
On Monday, August 19, 2019, 05:23:12 AM GMT-3, Isidor Nikolic<EMAIL_ADDRESS>wrote:
Please follow this guide to report more details
https://github.com/microsoft/vscode/wiki/Performance-Issues
Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks!


new cop | helper method uniqueness

Problem encountered
By default, Rails automatically loads the helpers into the controllers/views. If there is a clash in the method names, the last load overrides all previous ones.
On a large code base, this can happen relatively easily and the debug to find the root cause can be painfull.
Proposed solution
I would like to write a Cop, which checks that a method defined in one helper is not already defined in one of the other helpers.

I can push a PR. But I have some questions:

Is it technically feasible, with current tooling, to look in multiple files?
Any feedback on possible performance problems?
It might break the cache system, right?

Any comments on this subject are welcome.

Since RuboCop operates per file, I don't think this would be possible.
One approach that might help is to set config.action_controller.include_all_helpers to false:
https://api.rubyonrails.org/classes/ActionController/Helpers.html

Thanks @andyw8 for your feedback.
Yeah, it's on my list of options. But I wish I had the best of both worlds. To have a check and stay on the default rails configuration.


Better handling of "server doesn't answer".

I just artHashed a 2.8 gig movie in 17 seconds, which isn't bad, but I have a fast disk, and that was one file - if it were an older disk and a lot of small files, it'd be awful.

We could either wait and retry, or emit a state file that they could reuse later...

Currently there is no progress bar nor other feedback on hashing progress. Not sure I would expect a state file but it's nice to know if a process succeeds or fails and to get an idea of how things are progressing

Interesting issue, and it's a good one!
Perhaps even file another issue.
On Wed, Jul 11, 2018 at 6:54 AM, Benton C Bainbridge <
<EMAIL_ADDRESS>wrote:

Currently there is no progress bar nor other feedback on hashing progress.
Not sure I would expect a state file but it's nice to know if a process
succeeds or fails and to get an idea of how things are progressing
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/arthash/arthash/issues/9#issuecomment-404044781, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPdskF1eKntz1OYiiNHWZ-Pz-MwxEL0ks5uFYUNgaJpZM4VJJko
.

--
/t
https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com


trying to fix headless display on travis

The travis docs appear out date, but this issue suggests these changes might be the best fix:
https://github.com/travis-ci/docs-travis-ci-com/issues/354

huzzah! :champagne:


Enabling gRPC traces needs two env vars to be set

Two environment variables (GRPC_TRACE and GRPC_VERBOSITY) need to be set to see traces.
 We need to make GRPC_TRACE easier to use.

Trace allows users to toggle which systems to examine, and verbosity sets the level. How do you see these being merged into one?
I understand the problem that this can be complex for someone starting out with gRPC, but once it is understood, the granularity of configuration should allow quicker debugging.
 I.e. maximum log dumping. That way if we want logs from a user, they only have to set one env var.

I don't have any hard opinions on this, but it could be as simple as printing a warning if GRPC_TRACE is set and GRPC_VERBOSITY is not set.
Can there be traces of different verbosities or all traces are at the debug level?

The core supports DEBUG, INFO, and ERROR, with all being used just about equally (444, 518, 470 respectively)

It doesn't look like there are any plans to do anything about this.


Update korean web-frame.md according to the change of web-frame.md

[ci skip]

They have already been updated by #3946, but still thanks for this!

Oh, sorry! I will check PRs more carefully next time. Thanks.


Failed to load the ever-notedown package

I tried to install this ever-notedown with using Atom UI but apm error occured.
Then I downloaded the ever-notedown from the author's repository as a zip file.
I expanded the zip file and put the ever-notedown-master folder into ~/.atom/packages/ directory after renaming it ever-notedown.
Then I started the Atom but the ever-notedown didn't work.
What should I do to use it?
Atom Version: 1.1.0
System: Mac OS X 10.10.5
Thrown From: ever-notedown package, v0.2.12
Stack Trace
Failed to load the ever-notedown package
At Cannot find module 'pathwatcher'

Error: Cannot find module 'pathwatcher'
  at Module._resolveFilename (module.js:334:15)
  at Function.Module._resolveFilename (/Applications/Atom.app/Contents/Resources/app.asar/src/module-cache.js:383:52)
  at Function.Module._load (module.js:284:25)
  at Module.require (module.js:363:17)
  at require (module.js:382:17)
  at Object.<anonymous> (/Users/myUSERNAME/.atom/packages/ever-notedown/lib/ever-notedown.coffee:28:21)
  at Object.<anonymous> (/Users/myUSERNAME/.atom/packages/ever-notedown/lib/ever-notedown.coffee:25:1)
  at Module._compile (module.js:428:26)
  at Object.defineProperty.value [as .coffee] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:169:21)
  at Module.load (module.js:353:32)
  at Function.Module._load (module.js:308:12)
  at Module.require (module.js:363:17)
  at require (module.js:382:17)
  at Package.module.exports.Package.requireMainModule (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:725:34)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:176:28
  at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:153:15)
  at Package.module.exports.Package.load (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:167:12)
  at PackageManager.module.exports.PackageManager.loadPackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:396:14)
  at PackageManager.module.exports.PackageManager.loadPackages (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:363:14)
  at Atom.module.exports.Atom.startEditorWindow (/Applications/Atom.app/Contents/Resources/app.asar/src/atom.js:622:21)
  at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-bootstrap.js:12:8)
  at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-bootstrap.js:23:4)
  at Module._compile (module.js:428:26)
  at Object.defineProperty.value [as .js] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:169:21)
  at Module.load (module.js:353:32)
  at Function.Module._load (module.js:308:12)
  at Module.require (module.js:363:17)
  at require (module.js:382:17)
  at setupWindow (file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.js:79:25)
  at window.onload (file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.js:35:9)

Commands

Config
{
  "core": {
    "audioBeep": false,
    "disabledPackages": [
      "autocomplete-plus-python-jedi"
    ],
    "themes": [
      "one-light-ui",
      "solarized-light-syntax"
    ],
    "destroyEmptyPanes": false
  }
}

Installed Packages
# User
AtomicChar, v0.3.9
autocomplete-paths, v1.0.2
autocomplete-python, v0.10.3
ever-notedown, v0.2.12
file-icons, v1.6.11
haskell-ghc-mod, v1.1.2
haskell-pointfree, v0.1.2
ide-haskell-cabal, v1.0.0
japanese-menu, v1.5.0
japanese-wrap, v0.2.10
language-haskell, v1.5.0
language-latex, v0.6.1
language-matlab, v0.1.1
latex, v0.28.2
latexer, v0.2.7
minimap, v4.16.0
minimap-autohide, v0.10.1
minimap-hide, v0.3.0
project-manager, v2.6.5
script-runner, v1.8.4
symbols-tree-view, v0.10.1
vim-mode, v0.63.0

# Dev
No dev packages

Sorry for the delay in replying. Are you still having problems installing this package using the Atom UI?
Downloading and unzipping the repository doesn't quite equate to "installing"... You probably need to

cd ~/.atom/packages/ever-notedown/
apm install

Alternatively, you can try running apm install ever-notedown in command line, which should be equivalent to installing the package in the Atom UI.
P.S. Have you taken a look at the package documentation by any chance? The installation section, in particular, as there are a few things that you'll need to do before installing -- nothing too complicated, just creating a dedicated directory/git repo, really.

Thank you for your answer. I still have a problem with it.
I tried apm install but some npm error and gyp error have occurred.
The error message said
npm ERR!  Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR!  This is most likely a problem with the runas package,
npm ERR!  not with npm itself.
npm ERR!  Tell the author that this fails on your system:
npm ERR!      node-gyp rebuild
npm ERR!  You can get their info via:
npm ERR!      npm owner ls runas
npm ERR!  There is likely additional logging output above.

so i will try to manage this problem first.
Thanks a lot.

Have you updated the repo (git pull or re-download the repo) before running apm install? There were recent updates made to the package intended to resolve the npm error specifically. You might also want to do an apm clean before apm install.

@cs150bf Would love to get this working, as on now,
User@UserUser ~/.atom/packages/ever-notedown $ apm-beta install                [2.2.2]
Installing modules ✗

<EMAIL_ADDRESS>install /Users/moses/.atom/packages/ever-notedown/node_modules/git-utils
node-gyp rebuild

npm WARN deprecated<EMAIL_ADDRESS>the module is now available as 'css-select'
npm WARN deprecated<EMAIL_ADDRESS>the module is now available as 'css-what'
make: *** No rule to make target ../../../../../../../../Applications/Atom', needed by Makefile'.  Stop.
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Applications/Atom Beta.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/lib/build.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Darwin 14.5.0
gyp ERR! command "node" "/Applications/Atom Beta.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/moses/.atom/packages/ever-notedown/node_modules/git-utils
gyp ERR! node -v v0.10.40
gyp ERR! node-gyp -v v2.0.2
gyp ERR! not ok
npm ERR! Darwin 14.5.0
npm ERR! argv "/Applications/Atom Beta.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom Beta.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/User/.atom/.apm/.apmrc" "--userconfig" "/Users/User/.atom/.apmrc" "install" "--target=0.34.5" "--arch=x64"
npm ERR! node v0.10.40
npm ERR! npm  v2.13.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the git-utils package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls git-utils
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/User/.atom/packages/ever-notedown/npm-debug.log
User@UserUser ~/.atom/packages/ever-notedown $
Ever-notedown is great work, wish I could contribute but way behind on the learning curve.
Best,

@7Moses Just to make sure, have you tried running apm clean in the directory before the install?

Thank you for replying. Yes, I ran apm clean, followed by apm install,
Best,

@cs150bf,
With ever-notedown 0.2.18, I am getting the alert: Some installed packages could not be loaded because they contain native modules that were compiled for an earlier version of Atom.
I am using 1.6.0-beta8,
Best,

@7Moses I'm sorry to hear that... What about apm rebuild? Or if that fails, could you please try first enter the directory ever-notedown/node_modules and run npm uninstall git-utils, and then cd .. and run apm install again?

@cs150bf,
Thanks for replying. Used the sequence you described still getting:
"This is most likely a problem with the git-utils package,"
I also tried here, https://github.com/nodejs/node-gyp/wiki/Updating-npm's-bundled-node-gyp, got the error<EMAIL_ADDRESS>invalid; will continue reading,
The sequence:
moses@MosesMoses ~/.atom/packages/ever-notedown $ cd /Users/moses/.atom/packages/ever-notedown/node_modules
moses@MosesMoses ~/.atom/packages/ever-notedown/node_modules $ npm uninstall git-utils

<EMAIL_ADDRESS>node_modules/git-utils
<EMAIL_ADDRESS>node_modules/nan
moses@MosesMoses ~/.atom/packages/ever-notedown/node_modules $ cd ..              [2.2.2]
moses@MosesMoses ~/.atom/packages/ever-notedown $ apm-beta install                [2.2.2]
Installing modules ✗

<EMAIL_ADDRESS>install /Users/moses/.atom/packages/ever-notedown/node_modules/git-utils
node-gyp rebuild

make: *** No rule to make target ../../../../../../../../Applications/Atom', needed by Makefile'.  Stop.
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Applications/Atom Beta.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/lib/build.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Darwin 14.5.0
gyp ERR! command "node" "/Applications/Atom Beta.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/moses/.atom/packages/ever-notedown/node_modules/git-utils
gyp ERR! node -v v0.10.40
gyp ERR! node-gyp -v v2.0.2
gyp ERR! not ok
npm ERR! Darwin 14.5.0
npm ERR! argv "/Applications/Atom Beta.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom Beta.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/moses/.atom/.apm/.apmrc" "--userconfig" "/Users/moses/.atom/.apmrc" "install" "--target=0.34.5" "--arch=x64"
npm ERR! node v0.10.40
npm ERR! npm  v2.13.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the git-utils package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls git-utils
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/moses/.atom/packages/ever-notedown/npm-debug.log
moses@MosesMoses ~/.atom/packages/ever-notedown $

@cs150bf,
I should have mentioned this, https://github.com/atom/git-utils/issues/69, "Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild" is also being reported by others,
Best,

I Updated to the latest atom-beta, and then did this, https://github.com/cs150bf/ever-notedown/issues/54, Works like a charm,
Thanks,
Best,

@cs150bf,
Thanks for the hard work on developing this Atom Package! In my experience as a relatively inexperienced developer, I found that simply installing/updating the Xcode Command Line Tools was sufficient to eliminate all npm and node-gyp rebuild type errors from my install.
It may help you to minimize questions from n00bs like myself if you comment the Atom Package version number and reference it directly in the repository README.md file near the top under an "Install" heading.
Regards,


[bug] set_icon_as_template not updating tray icon

Describe the bug
I have an application that uses system tray icon as template, if this user receives a notification I want to disable icon-as-template to get attention of user.
I call this command but it does not update tray icon.
#[tauri::command]
pub fn set_icon_template(is_template: bool, app: AppHandle) {
    app.tray_handle().set_icon_as_template(is_template).unwrap();
}

For a workaround I currently do this.
#[tauri::command]
pub fn set_icon_template(is_template: bool, app: AppHandle) {
    app.tray_handle().set_icon_as_template(is_template).unwrap();
    app.tray_handle()
        .set_icon(tauri::Icon::Raw(
            include_bytes!("../icons/tray/icon.png").to_vec(),
        ))
        .unwrap();
}

Reproduction
by default in tauri.conf.json set iconAsTemplate: true, and then try to update it from commands.
Expected behavior
It should update tray icon.
Platform and versions
Environment
› OS: Mac OS 13.1.0 X64
› Node.js: 16.18.1
› npm: 8.19.2
› pnpm: 7.18.2
› yarn: 1.22.18
› rustup: 1.25.1
› rustc: 1.67.0
› cargo: 1.67.0
› Rust toolchain: stable-aarch64-apple-darwin
Packages
› @tauri-apps/cli [NPM]: 1.2.3
› @tauri-apps/api [NPM]: 1.2.0
› tauri [RUST]: 1.2.4,
› tauri-build [RUST]: 1.2.1,
› tao [RUST]: 0.15.8,
› wry [RUST]: 0.23.4,
App
› build-type: bundle
› CSP: unset
› distDir: ../dist
› devPath: http://localhost:1420/
› framework: Vue.js
› bundler: Vite
App directory structure
├─ dist
├─ images
├─ node_modules
├─ public
├─ .github
├─ src-tauri
├─ .git
├─ .vscode
└─ src
Stack trace
No response
Additional context
No response

this is the intended behavior actually, it is a bit of a weird design choice but we are stuck with it for v1, we will improve this in v2.


Complex modification: Problem with using capslock_key to trigger ESC, hold-down HJKL movement and capslock. Misconfig or CAPS_LOCK bug?

Hi All, I hope someone can help me with this modification. It's hard to tell if there is a bug or just a misconfiguration.  Request: Can someone please take a look at this problem and recommend a fix or solution that might get this KE mod working. Thanks in advance
What I am trying to do is create a super capslock modifier (as has been done before) but with a few extra features.
The outcomes I want are:

A quick tap of CAPS_LOCK sends ESCAPE for vim
A hold and release of CAPS_LOCK sets Capslock On, a short hold and release turns capslock off
A hold-down of CAPS_LOCK + HJKL gives vim style movement navigation in any app (left down up right) and upon release goes back to current capslock setting. Additional key modifiers ( Shift, Alt, and Ctrl) should just create usual (selection, by word, by line) movements.

I have used flag variables [0 or 1] to try track key state as well as using KE events:

caps_lock_pressed to track state of CAPS_LOCK pressed and released
caps_lock_set to track what should be the state of the capslock key.
You should be able to use the event viewer to track these variables to follow behaviour

Problem:
Everything seems to work pretty well except for outcome 3 above.  That is, when I am in capslock mode  and try to use the CAPS_LOCK held-down + HJKL keys to navigate, it prints letters instead of giving movement.
Ideally if you can test my code, and modify and repost that would be awesome. Otherwise if you're a guru and can see my error just by looking and advise, that works for me too. I am happy to post the final working solution for others. Thanks
Heres my setup:
System:
Macbook Pro 2019
MacOS: 10.14.5 Mojave
Karibiner Elements: 12.6.0
Code I am using:
{
  "title": "TEST - capslock super key modifier",
  "rules": [
     {
          "description": "TEST - capslock and escape, integrated trigger",
          "manipulators": [
            {
              "type": "basic",
              "from": {
                "key_code": "caps_lock"
              },
              "parameters": {
                  "basic.to_delayed_action_delay_milliseconds": 250,
                  "basic.to_if_alone_timeout_milliseconds": 250,
                  "basic.to_if_held_down_threshold_milliseconds": 250
              },
              "to_if_alone": [
                {
                  "set_variable": {
                    "name": "caps_lock_set",
                    "value": 0
                  }
                },
                {
                  "set_variable": {
                    "name": "caps_lock_pressed",
                    "value": 1
                  }
                },
                {
                  "key_code": "escape"
                }
              ],
              "to_if_held_down": [
                {
                  "set_variable": {
                    "name": "caps_lock_set",
                    "value": 1
                  }
                },
                {
                  "key_code": "caps_lock"
                 }
              ],
              "to": [
                {
                  "set_variable": {
                    "name": "caps_lock_set",
                    "value": 0
                  }
                },
                {
                  "set_variable": {
                    "name": "caps_lock_pressed",
                    "value": 1
                  }
                }
              ],
              "to_after_key_up": [
                {
                  "set_variable": {
                    "name": "caps_lock_pressed",
                    "value": 0
                  }
                }
              ]
            }
          ]
        },
        {
          "description": "TEST - CAPSLOCK Variable + h/j/k/l to Arrows",
          "manipulators": [
            {
              "type": "basic",
              "from": {
                "key_code": "h",
                "modifiers": {
                  "optional": [
                    "any"
                  ]
                }
              },
              "to": [
                {
                  "key_code": "left_arrow"
                }
              ],
              "conditions": [
                {
                  "type": "variable_if",
                  "name": "caps_lock_pressed",
                  "value": 1
                }
              ],
              "to_after_key_up": [
                {
                  "set_variable": {
                    "name": "caps_modifier_used",
                    "value": 1
                  }
                }
              ]
            },
            {
              "type": "basic",
              "from": {
                "key_code": "j",
                "modifiers": {
                  "optional": [
                    "any"
                  ]
                }
              },
              "to": [
                {
                  "key_code": "down_arrow"
                }
              ],
              "conditions": [
                {
                  "type": "variable_if",
                  "name": "caps_lock_pressed",
                  "value": 1
                }
              ]
            },
            {
              "type": "basic",
              "from": {
                "key_code": "k",
                "modifiers": {
                  "optional": [
                    "any"
                  ]
                }
              },
              "to": [
                {
                  "key_code": "up_arrow"
                }
              ],
              "conditions": [
                {
                  "type": "variable_if",
                  "name": "caps_lock_pressed",
                  "value": 1
                }
              ]
            },
            {
              "type": "basic",
              "from": {
                "key_code": "l",
                "modifiers": {
                  "optional": [
                    "any"
                  ]
                }
              },
              "to": [
                {
                  "key_code": "right_arrow"
                }
              ],
              "conditions": [
                {
                  "type": "variable_if",
                  "name": "caps_lock_pressed",
                  "value": 1
                }
              ]
            }
          ]
        }
    ]
}

Is your code taking into account the fact that the letter codes may be outputting uppercase if the short hold and release was trigger before the press and hold?
The other thing I wonder is if while it is monitoring for the release event for the hold and release to enter CAPS mode, if maybe it isn't evaluating the other rules that come after?

@kadlugan Have you had any luck with this? I'm running into the same issue.


Thanks for this.

I just got my panels turned on today. I currently have a rasberry pi running influxdb and grafana getting data from my hubitat. I would love to get this going to and gatter data directly from the PVS. Any way to contact you if I get stuck?

Sure thing! You can reach me at gledesma (at) gmail (dot) com. :)
Let me know if you run into any issues — I've only tested this with my setup (PVS6 + SPR-E320-327-E-AC panels + Enphase IQ7XS-96-ACM-U integrated micro inverters).

Works perfectly on a PVS5 and a stock raspberry pi 3B+ between SunPower LAN 1 and WiFi.  Sending direct to a remote InfluxDB server through Prometheus-pushgateway and Prometheus.  27 SunPower 350 panels with micro-inverters. Easy peasy.
However, I can't access the pi through a VPN because it defaults to the pi ethernet port (eth0) and wlan0 doesn't see it.  I know there is a way to change the priority on ifconfig but I have to dig into that.  I have the same issue on another pi on the same net.  Can't ping or connect via ssh, VPN, VNC from outside the local WiFi network when eth0 and wlan0 are both connected.  Just FYI for others who might set this up.  Works perfectly for the purpose intended though.
Nice piece of work for a handful of likely users.  Thanks.
Kevin


Add common contribution guidelines to docs

Summary
Right now each qiskit element has a local copy of a contributing file
which dictate the contribution guidelines for the project. However,
since qiskit is made up of multiple elements lots of project policy
pieces are more or less the same. Although, often the guidelines get out
of sync as things get added or removed from these common pieces.
This commit copies sections from qiskit-terra's CONTRIBUTING.md file
that should apply to all elements into the contributing guide. Terra's
CONTRIBUTING.md file is typically the leader where new policies and
guidelines are adopted which then get ported to other elements. We can
then update each elements CONTRIBUTING file to remove this duplicated
material and just refer to the hosted copy with a direct link.
Details and comments

Per request of @SooluThomas I did a readthrough (https://github.com/mtreinish/qiskit/pull/4)


Release 0.2

@ots22 I just made a release and called it 0.1.3 but I realise could have called it 0.2 🤣

Perhaps this would be a good chance for someone other than me to test whether they can do it, by following these instructions: https://scivision.readthedocs.io/en/latest/maintainers.html

No problem, having a recent release as a starting point is useful anyway.  I was hoping to use this issue to gather any final things we want to include.

This seems to have been closed automatically but looks like we're still on 0.1.3 on PyPI

yeah, haven't got the automated release working nicely yet - see #86


Remove special "KeyError" and return undefined from stores for missing key

Adapted from: https://github.com/gzuidhof/zarr.js/issues/69
A KeyError is a built in python error that's thrown when a key is missing from a MutableMapping. In JavaScript, the equivalent behavior is to just return undefined when a key is missing. Making this change would remove a lot of the try/catch blocks from the core implementation and instead we would just call:
// Store returns 'undefined' instead of throwing custom error if chunk is missing.
// Otherwise the store can throw any other error and it will propagate up.
const chunk = await this.store.get(ckey);
if (!chunk) {
  /* create the missing chunk */
} else {
  /* decode the chunk */
}

This means that custom store implementations don't need to have zarrita as a dependency, and instead can explicitly return undefined when a key is missing.

After experimenting with this for a bit, I'm not sure what the "right" approach is here. We would need to be careful in handling  the store internally (and this could bite us), but custom store implementations would be much more simple:
1.) return bytes if key in store.
2.) return undefined if not in store.


Revert "nixos: rename system.{stateVersion,defaultChannel} -> system.nixos.\1"

This reverts commit 095fe5b43def40279a243e663c662b02caac5318.
Pointless renames considered harmful. All they do is force people to spend extra work updating their configs for no benefit, and hinder the ability to switch between unstable and stable versions of NixOS.
Like, what was the value of having the "nixos." there? I mean, by definition anything in a NixOS module has something to do with NixOS...

Could have mentioned me here... Seriously, can we get the mention bot back? This is not the first time something I find useful is reverted and I get "notified" only by a broken evaluation after a rebase.
Motivation behind 095fe5b43def40279a243e663c662b02caac5318:

system namespace is overloaded, I think having those under nixos makes the manual easier to read;
while defaultChannel is IMO kinda okay on the top level semantically, stateVersion IMO is not: stateVersion is a very nixos-specific thing; slnos, for instance, does monoidal services and they have their own monoidal way to do versioning; when using nixos modules in slnos it makes sense to clearly separate those;
note however, that the only use of defaultChannel in nixos tree (in shells.nix) is nixos-specific too (neither slnos, nor nixops, strictly speaking, use nixos-rebuild);

hence that patch.
I'd liked this to go even further: system.copySystemConfiguration to be moved under system.nixos too, system.nixos to become simply nixos and system.autoUpdate to become service.nixosAutoUpdate or something, this way system namespace would've become, literally, "a namespace for very low-level system things", not a mashup it is now.
But if you're like "meh, who cares about composing nixos with obscure projects and keeping the option namespaces structured", then fine, I can just revert the revert in SLNOS =/, but I think that at the very least 095fe5b43def40279a243e663c662b02caac5318 was not "a useless rename".

Making names more intuitive helps newcomers to learn, understand and also memorize NixOS and Nixpkgs easier.
That's an important value proposition for such changes.
Attributes shouldn't be just removed or repurposed, of course.
The should still work, just deprecate them.
Deprecated code then can be removed from time to time (eg. with every or every other stable release).

Well, yes, but every change comes with a price and risks paid by current users.  In this case I'm not convinced the improvement is significant enough, though I would probably choose to put these two together with the other system.nixos.* options if the options were new.

I'm annoyed that I have to change my stuff twice, because somebody didn't want to change his once. I can't be the only one. I'd also like to see better justification for reverting something that's been in place almost 4 months.
Next time, can we put in the deprecation warning + aliases, then schedule the actual deprecation as part of the 18.09 release? That way, you all have a solid 6 months to quarrel about it, without catching innocent bystanders in the crossfire.

@vcunat
By that logic nothing should be changed unless it has some deep technical reason. Personally, I think order > chaos, nixpkgs has enough of chaos already, since option naming influences documentation directly I think saner option names are a must.
@dezgeg

through the RFC process

Yay! RFC Bingo!
Let me remind you that there's not a single one accepted technical RFC, and RFC's get less reviewers on average than similarly long-standing PRs.
If you search stalled and closed PRs with "RFC" text in them you'll find that there's like a whole lot of very cool ones. (I often feel that I just need to bite the bullet and cleanup and publish SLNOS branch that adopts them, but then I get lazy.)

... reverts seem to be the only counter to this current trend where anybody can break existing stuff ...

Right. But does that actually happen? Do those people really break stuff intentionally? Did the PR in question break anything? I don't think so.

Regardless of ones opinion of the revert, this was merged far too quickly.

Maybe we can keep both, without deprecations, just like do with users.users and users.extraUsers? This will please both @oxij (for order > chaos) and @dezgeg (doesn't require action just for sake of action)
I'm more in favor of keeping NixOS "experimental" in option naming. Let the option namings evolve.


Protocols edit

translated files on protocol (Ehereum-FTM) to Turkish

3 file seem to have issue.I checked nothing seemed wrong but length of sentences,Turkish translated version is much longer than english


docs: "jump to" menu hides information

just a small annoyance in the docs: if you jump to a specific property or method, the "jump to" menu hides the name of the very thing you were looking for, at the top of the screen :)

also, bulleted items are being rendered over the "jump to" box for some reason

Closing as I fixed this a while ago, but forgot about this issue.


fix serializer regression for Akka.Persistence.MongoDb v1.3.12

close #57

Adding a spec to verify this

Hi @Aaronontheweb, this doesn't fix the issue I'm afraid. It's line 299 of MongoDbJournal.cs that is causing the problem. It's already dealt with in MongoDbSnapshotStore.cs by checking for null or empty so the same could be applied to this file also?

Yep that's right. Thanks

Cool, what version number will we go with now? 1.3.13?

Added regression spec - verified failure before my fix and success after


Upgrade wechaty-puppet-padchat stable version

wechaty-puppet-padchat minor version 0.17 has been published for a while, and some fixes are pushed into this version. v0.18.1 just got published, which we think should be a stable version for people to use. So please update the wechaty-puppet-padchat version in puppet-config to v0.18.1

Merged.

Closed :)


Add humaneval+ evaluation task

This PR addresses #186 to include HumanEval+ in bigcode-evaluation-harness.
The dataset is available at https://huggingface.co/datasets/evalplus/humanevalplus

Thanks for the prompt code review! The comments shall be addressed. :D

I also did a test using starcoderbase-1b and can get 11.5 pass@1 which is very close to what I previously got using EvalPlus :).


Tentative fix for CASSANDRA-11676

Tentative fix for CASSANDRA-11676 and removed known failures for CASSANDRA-11675. See discussion on the 11676 ticket for more details.

We already have some tooling for this. I'll close this and make a PR for your review.


[FR]: 'configure' command generates Kotlin rules

What is the current behavior?
Users have to write BUILD files by hand containing kt_jvm_library and other Kotlin rules
Describe the feature

[x] understand the Kotlin grammar and generate BUILD files with srcs and first-party deps
[x] study https://github.com/bazel-contrib/rules_jvm/tree/main/java/gazelle#gazelle-java-extension and mimic their method for determining deps on third-party maven packages
[ ] Add test cases for various use cases

Thanks for starting this!
Note that I get parse errors for relatively basic Kotlin files when using aspect configure:
xxx/ch/nexiot/gh/commander/api/commands/FirmwareVersion.kt parse error(s):
     8: 	val versionString get() = "$major.$minor.$patch"

Context:
package ch.nexiot.gh.commander.api.commands

class FirmwareVersion(
        val major: Int,
        val minor: Int,
        val patch: Int,
) {
        val versionString get() = "$major.$minor.$patch"
}

.bazeliskrc
.bazeliskrc
BAZELISK_BASE_URL=https://github.com/aspect-build/aspect-cli/releases/download
USE_BAZEL_VERSION=aspect/5.5.4

.bazelversion 6.3.0
.aspect/cli/config.yaml
configure:
  languages:
    javascript: false
    go: false
    kotlin: true
    protobuf: true

@kolloch despite that scary "parse error", we've seen that the BUILD files are actually updated in the desired way. Did aspect configure make BUILD file edits in your case?

Did aspect configure make BUILD file edits in your case?

Possible, I don't remember. I should try again.
I think you do not resolve dependencies yet?
My dabbling with this was mostly whether it makes sense to integrate my work with that. I solid parser does not make a big difference, since it will still not allow this solution to be perfect in detecting dependencies. But for now, it doesn't seem solid. Maybe that's easy to change! That would be awesome.
For now, it would be easier for me to continue with a solution that I understand.

FYI @kolloch https://github.com/aspect-build/aspect-cli/pull/501 has the feature adding maven support, basically just supporting the existing rules_jvm gazelle maven config within kotlin. Once that PR is merged let me know if you get a chance to check it out.

The MVP for this is done, we can open more issues for more changes


Question: Support for JavaScript in html files?

Is it possible to use Flow for JavaScript in html files ?
I'm using Polymer to building Web Components and it would be nice if I can check the JavaScript in the html files.

Linked to https://github.com/facebook/flow/issues/2691

Duplicate of https://github.com/facebook/flow/issues/2218


WildCam Darien Map part 5: Camera Viewer

PR Overview

This PR adds the "Camera Viewer" functionality to the map.
This means that a user can click on a Map Marker on the Map to view the camera trap photos from that specific camera.

The Camera Viewer has a very basic pagination system. (Paging? Pagination?)

Dev Notes

Blurgh, we have a thumbnail generating system... but it only works if the photos are hosted on zooniverse.org, I think. I've built the thumbnailing functionality in, but it doesn't work with WildCam Darien's photos so... that Camera Viewer is blasting users with 6 hi-res images from the Darien National Park, scaled to tiny sizes. BLURGH, I say.
I'm not sure if there's a Grommet/React ready pagination system we want to use - I saw the ToDo in the Classroom components but I'm unaware of a specific solution that we're aiming towards. Let me know if/when we do - I'll replace the current paging system the Camera Viewer uses, which is functional but fairly adhoc.
The getActiveCamera Action, unfortunately, breaks the "Map Explorer should be project agnostic; mapConfig should be project specific" pattern I've been holding on to for the past few updates.
A part of me tells me I'm being rather clumsy with the styling (see anything to do with colours or .grommetux-... overrides in map-explorer.styl) and am fighting unnecessarily with the Grommet framework, but another part of me thinks special overrides are necessary given the conflict between Grommet's generalised, spacious component designs and the Map Explorer's ridiculous explosion of data in a limited amount of screen real estate.

Status
Ready for review!
NOTE: I may need to self-merge this before too long, as the next branch (WildCam Darien Map part 6: Translations) is contingent on all other parts being merged/finalised, and Part 6 itself is going to be a doozy. If I do prematurely merge this branch, please comment anyway - I'll put in minor fixes/suggestions as Part 6 and/or major fixes/suggestions to all the previous Map Explorer stuff in a PR after that.

👍 Thanks for the quick review, Sarah! I'll get an update out in the next few hours.

PR Update

CameraViewer's Grommet Layer code/style has been standardised; no more 'Done' button to close the page, just a the regular Close button seen in other parts of the EAPIFE.
CameraViewer component has its functionality broken into CameraViewerMetadata, CameraViewerData, CameraViewerPaging.

Paging code has been improved, although there's still room for more improvements, I think.
NOTE: The CameraViewerPaging is NOT the suggested '(Really) Generalised Paging for the EAPIFE' component that @srallen suggested; if I'm building a (really) generalised component that's going to be used in, e.g. the ClassroomManager, I want to approach it in its own PR and with some Design to back me up. I'd be happy to see the code reused though!

The CameraViewerData now uses the ZRC Thumbnail component, but there are some caveats there.

WildCam Darien photos will cause 415 errors during thumbnailing attempts, so the Thumbnail compo will fall back to the original high-res images anyhoos. Still, the ZRC Thumbnail component is the right way to go forward.
By default all Thumbnail items will have alt=""; there's room for improvement here as each photo can have a pretty descriptive alt text. This should be marked for a future feature upgrade.

Status
Ready for review!

Thanks @srallen ! Give me a minute to rebase PR #40  to the new master.


Fig1

I added the PCA R2X for the flattened data here and now it creates the PCA with 6 components.

Agreed!
We still want the reduction plot though, right?
I was struggling with the way that perform_PCA() flattens the data in tensorpack. I could not make it flatten the data in the form of 42 x 498 that we wanted.
Would it be possible to add an argument to that function to directly giving it the flattened data, and it is not given, it goes through what it already is doing?

Yes re the reduction plot.
Why can't you get tensorpack to do it that way? This is something tensorpack is supposed to be able to do; if it's not working, ask for it to be fixed on #tensors.


Fix indentation in Interval docs

Coverage remained the same at 70.048% when pulling 5c4f8ff3253663de091da47609e8e377909ad582 on wojtekmach:patch-1 into f73b44c3d8f5d9065c5ed05cb839916dbf67ac21 on bitwalker:master.

I ended up reworking this module and it's docs, so I'm going to close this, but thanks for opening the PR!


Wrap querySelector and querySelectorAll in a try/catch block

I didn't want to create a PR if this was out of scope for the library.
I am simply wondering would it be better to wrap querySelector and querySelectorAll in a try/catch block and return an empty array just like sizzle/jQuery does?

I don't think that we want to make everything a collection. Bliss' purpose is to make using native JavaScript easier, and native JavaScript doesn't return everything as a collection. Make sense?

Yup.  I just didn't know if you were trying to be a little like jQuery. But thanks for answering =)

Not really. If something in jQ is a good idea and needed commonly enough we might consider it, but similarity for the sake of similarity is not a design goal. :)


Cannot serialize subclasses of Dictionary

Hello, If one has a subclass of Dictionary, the serialization does not work. In this example I take Coypu.
Let's take the following code:
p := Performance uniqueInstance.

If we serialize the object p we get an empty Dictionary {} and not a Performance object.
Stash new serialize: p "{}"

Hello i added Dicitonary serialization in PR #15 .
In order to use Stash with the Performance object, you need to add a new method in performance (instance side):
asStashConstructor

	^ self className , ' uniqueInstance'

Your example will give:
p := Performance uniqueInstance.
Stash new serialize: p. "Performance uniqueInstance"

Other example:
p := Performance uniqueInstance.
	p at: #kick put: 16 downbeats.
	p at: #snare put: 16 upbeats.
	p at: #ch put: 16 quavers.
	p at: #oh put: 16 semiquavers.
Stash new serialize: p.

Will give the following source code:
Performance uniqueInstance
   at: #oh put: SequencerMono new;
   at: #kick put: SequencerMono new;
   at: #ch put: SequencerMono new;
   at: #snare put: SequencerMono new;
   yourself

In order to serialize the different elements of Sequence Mono, you need to create methods with a <stashAccessors> pragma.
The methods must return a collection of either:

symbol: when the method to access a subparameter is the same to set it (example size and size:)
an association of symbol: when the method  to access a subparameter are different (example addChildren: -> allChildren)
an association of blocks where the first block take one argument (the object that is serializing) and return a symbol coresponding to the mutator, and a second block that take one argument (the object tht is serializing) and return the targeted object.

For example in Sequencer (instance side):
serializationOfSequencer

	<stashAccessors>
	| accessors |
	accessors := OrderedCollection new.
	accessors addAll:
		{ #seqKey. #notes. #durations. #noteIndex. #gates.
		#midiChannel. #visualGroup. #cycleDurations. #seqChords. #soundPattern.
		#samplesIndex. #dirtMessage. #orbit. #isPoly. #phaustGateDestination.
		#phaustNoteDestination. #kymaMessage. #transportStep }.
	^ accessors

Thanks Yann for the fast feedback and PR. I will try what you suggested later this week and come back to you


Additional options for webhook_configs

Can we have some additional options for the webhook_configs? And just post them with json?
For example I'd like to pass phone numbers and chat IDs, some tag configuration (like display only these tags in sms), etc.

You're asking for a fully general JSON->JSON templating system.
We suggest doing the logic you need in what's receiving the webhook, as it's not practical for us to offer the full range of functionality that users would be looking for here. You receive all the same data that the templates do.

But how can I use the same webhook with different options? Posting json read from yaml seem to be simple. You can set options for all the receivers except the webhook one.

Have different receivers for your different webhook endpoints. All receivers have the options they need, in the case of the webhook that's only the URL to send to (we'll likely add the various http auth options at some point).

So you suggest encoding those options to the URL? That looks like a dirty workaround for me but I can definitely do this in ansible.
Why don't you like the idea of passing extra options?

OK, I have an sms receiver. I have 10 groups of users, so you suggest me starting 10 receivers with different options, right?

Yes, or do the logic inside your custom code.
Allowing extra options is effectively asking for us to provide a Turing Complete JSON transformation language, combined with the Go templating language. That is well outside the scope of the Prometheus project, one custom Turing Complete language is quite enough.

@brian-brazil thank you, I'll close this for now and will get back to this when I'll start to implement SMS alerts.

I want to connect alertmanager directly with a third party webhook.
And instead of having to develop, run and manage a server just for translating between the default alertmanager JSON output and the expected JSON input from the third party, the option to template the actual alertmanger JSON object myself would do the job.
This is the request the third party expects:
curl -i -X POST -H "X-Version: 1" -H "Content-Type: application/json"
-H "Authorization: bearer {{ apikey }} "
-H "Accept: application/json"
-d '{"text":"{{ message }}","to":["{{ receiver }}"]}'
-s {{ webhook.url }}
So, if it would be possible for me to supply my own headers and my own payload to the webhook-url everything would be good!

I think just setting some headers for api tokens would be a nice addition.


[BUG]: [ANCHOR: BE PYTHON] Fix "Send Invites" Button Failure in Members Page

Description
The "Send Invites" button fails to send invites, preventing users from inviting new members.
Acceptance Criteria

The "Send Invites" button should send invites successfully.
The backend should process and handle requests correctly.

Purpose
Requirem#ents

Review the backend logic that handles invite requests.
Ensure that the frontend is correctly sending the request.
Test for successful invite sending.

Expected Outcome

Users should be able to send invites without encountering any errors.
The backend should correctly handle the request and process the invite.

Pls assign issue to me


Add dist folder with minified version for every release tag

https://github.com/bower/bower/issues/368

I believe adding this is as simple as using the "files" property in the package.json.

{
  "name": "sanitize-html",
"files": ["dist"... ]
...
}

Resolved in 1.16.3 I believe, if not feel free to PR whatever minor changes are needed.


Fix text-related typos/mistakes and improve consistency

Some minor text-related fixes.

Thank you for the improvements.


Error handling of std::string::resize()

Beast/v70
Was looking at test coverage to find untested parts to increase coverage.
So i discovered this:
            try
            {
                body_.resize(len + n);
            }
            catch(std::length_error const&)
            {
                ec = error::buffer_overflow;
                return;
            }
            ec.assign(0, ec.category());

There you catch std::length_error only.
What about the exceptions thrown by corresponding Allocator?
e.g. std::bad_alloc
http://en.cppreference.com/w/cpp/string/basic_string/resize

They are not caught!

Is this good or bad?

I think its bad, what do you propose for the fix? What exceptions should it catch, and what errors should it map them to?

I would suggest catching std::exception and always mapping to error::buffer_overflow.

I'm okay with that, would you like to submit a pull request? mutable_body needs it too (I think)

Yes mutable_body has code duplicated from string_body, since Reader and Writer are exactly the same... So they should use the same Reader/Writer in future?!
I can do the fixes and making a pull request.
What about this:
            if(content_length)
            {
                if(*content_length > (std::numeric_limits<std::size_t>::max)())
                {
                    ec = make_error_code(errc::not_enough_memory);
                    return;
                }
                ec.assign(0, ec.category());
                body_.reserve(static_cast<std::size_t>(*content_length));
            }
            else
            {
                ec.assign(0, ec.category());
            }

There is no try/catch at all.

So they should use the same Reader/Writer in future?!

If you mean that string_body should include the header file for mutable_body or vice versa, no, because library code cannot use code from example/. It has to be duplicated. I think that's okay.

There is no try/catch at all.

Looks like another area that needs try and catch

By the way, these are the kinds of bugs we like, easy to fix and doesn't change any public interfaces. As long as there is no major design problem with interfaces, then we're in good shape - things like this can be cleaned up over time (not saying we shouldn't fix it now but this is not as severe as an interface design flaw).

So you create a new branch first?

Yeah just make a new branch in your fork, based off v70 and place the commit which edits both classes (don't forget the CHANGELOG.md)

v70 is master now, isn't it?

Yeah it merged, I just updated the docs. No worries! Maybe its time to create a develop branch.. heh

Yes, we need a develop branch because I am not supposed to make changes to master during the formal review. I will create it now.

So i should wait for develop branch to base on it?

So i should wait for develop branch to base on it?

No, because the develop branch will be identical to master right now. Just make a new branch in your fork, based on master (which is v70).

Is it okay if all problems with length are mapped to
ec = error::buffer_overflow;
?

        template<bool isRequest, class Fields>
        explicit
        writer(message<isRequest, string_body, Fields>& m,
            boost::optional<std::uint64_t> content_length,
                error_code& ec)
            : body_(m.body)
        {
            if(content_length)
            {
                if(*content_length > (std::numeric_limits<
                        std::size_t>::max)())
                {
                    ec = error::buffer_overflow;
                    return;
                }
                try
                {
                    body_.reserve(static_cast<
                        std::size_t>(*content_length));
                }
                catch(std::exception const&)
                {
                    ec = error::buffer_overflow;
                    return;
                }
            }
            ec.assign(0, ec.category());
        }

I can't think of anything wrong with that. Its better than not catching the exception. And we can always change the error later if we want something better.

Is "Fix buffer overflow handling for string_body" as commit message okay?

Yes that's great

okay. would like to try again. bugfix based on which branch?

develop

Version 71:

--------------------------------------------------------------------------------

Version 70:
...

"Version 71"? I'm asking because there is a v71 branch...

Its fine, when your pull request passes tests I will just cherry-pick your commit into the v71 branch.


bugfix: ensure double clicking the Save button don't lose attachments

Checklist

[x] the [contributor license agreement][] is signed
[x] commit message follows [commit guidelines][]
[ ] tests are included
[x] screenshots are included showing significant UI changes
[ ] documentation is changed or added

Description of change
When editing an Item, repeatedly submitting a Legacy Content request in a very short period can result in attachments missing or the whole UI broken. Actually, where this bug can happen is not limited to Contribution. For example, double clicking the Edit this version button in Resource Summary page can break the UI as well.
To fix this, I added a new flag in LegacyContent.tsx to stop redundant submissions.
https://user-images.githubusercontent.com/47203811/147991371-ffe23149-a2ef-432e-b721-98dececea707.mp4

Now only one GHA build failed on ItemApiEditTest which is flaky test so it's ready for review.


Less change of TypeInitializationException

Discussion:

hide exceptions on config errors and load an empty log config?
protect LogManager.GetCurrentClassLogger (try-catch)
move initial value of field LogManager.factory to static ctor and try-catch

I don't see these much nowadays, so closing this one


Final Presentation

@iamAdarshAnand
@sandeepkumar-v01
@jeshtha2003
@ManideepVerse
Prepare presentation on the project

Presentation video is created and it is reviewed by mentor.


Fixed usage of the LocalizedInput component with a "value" prop provided

Summary
This PR fixes my previous merged commit https://github.com/mattermost/mattermost-webapp/pull/2362. The commit caused that it isn't possible to type any character into the LocalizedInput whenever a value prop was provided to the component, like in login_controller.jsx:
<LocalizedInput
    id='loginPassword'
    type='password'
    className='form-control'
    ref='password'
    name='password'
    value={this.state.password}
    onChange={this.handlePasswordChange}
    placeholder={{id: 'login.password', defaultMessage: 'Password'}}
    spellCheck='false'
/>

This issue makes that isn't event possible to log to the app in using a password.
I resolved that by including the value prop in the shouldComponentUpdate function of the LocalizedInput and it now works correctly, but maybe there are better solutions.
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

Thanks @kosgrz for the quick fix! 👍

Thanks @kosgrz!

By the way, I believe HH is off today so I went ahead and approved/merged this PR.


runtime: TestNetpollDeadlock timeout on freebsd-amd64-race

greplogs -l -e 'FAIL: TestNetpollDeadlock .*(?:\n\s.*)*SIGQUIT' --since=2022-06-01
2022-08-18T17:26:17-07cf24b/freebsd-amd64-race
--- FAIL: TestNetpollDeadlock (60.04s)
    testenv.go:468: [/tmp/workdir/tmp/go-build2829729280/testprognet.exe NetpollDeadlock] exit status: exit status 2
    crash_test.go:463: output does not start with "done\n":
        dialing
        SIGQUIT: quit
        PC=0x46403e m=0 sigcode=65537
…

CC @golang/runtime @golang/freebsd
See previously #42500, #35353, #22403, #22280, #22019.

The expectation is that the connection will be refused immediately. It seems that it is instead hanging (probably to time out with a longer period than our test timeout?).

It's probably hanging because some other test on the machine has actually opened that hard-coded port. 😅
(It's a bad test — you can't just go around opening arbitrary ports on a heavily-loaded machine and assuming their behavior!)

In particular: if something actually opened port 14356 and started listening on it, and filled up the kernel accept buffer without closing the listener (if freebsd even buffers accept operations?), then it is possible for a Dial of that port to hang indefinitely.
(And if the port was opened by another test process, the spurious connection may well mess with the behavior of that test too.)


Add total runoff output field in NoahMP401

Added new total runoff option into NoahMP401 LSM in LIS, which
combines surface and baseflow runoff fluxes.
Expand this output option to include different units and
user options.
Add to your model output table as:
qtot: 1 mm - 0 0 0 1 0 1 # total discharge to stream
This addresses GitHub issue #1092 .

Description
Replace this text with a concise description of what was changed and why.

Testcase

This new option associated with a NoahMP401 MODEL_OUTPUT_LIST.tble file has been tested with:
qtot:         1  kg/m2s  OUT  1 0 0 1 235 10000   # Total runoff (mm/s)
Please let me know if you need anything else for testing prior to merging.

Hi @bmcandr
Based on the committed code, I wouldn't expect it to work.  I feel that the units of "kg/m2s" and "kg/m2" are appropriate
for the Noah-MP-4.0.1 LSM.  The units of "mm" are appropriate for the AWRAL model, which is why all three units are in
the code: lis/core/LIS_histDataMod.F90
I will let @karsenau confirm, but I believe the entry in the first comment was a typo, rather than something that needs
changing in the code.
For consistency with other runoff variable names, I would prefer that "qtot" be replaced with "Qtot" on Lines 5533
and 5535:
https://github.com/NASA-LIS/LISF/blob/master/lis/core/LIS_histDataMod.F90#L5533-L5535
AWRAL users will need to change their MODEL OUTPUT TBL - and we should change the "qtot" entry here as well:
https://github.com/NASA-LIS/LISF/blob/master/lis/configs/MODEL_OUTPUT_LIST.TBL.adoc
Just a suggestion, and no worries if others think we shouldn't bother.

Thanks @dmocko!
I also thought about requesting the qtot -> Qtot change, but wasn't sure whether that would affect current uses of qtot. Looks like the model output table for the AWRAL testcase would need to be updated if this change is made, for example.

@karsenau and @dmocko, I made the change to capitalize Qtot and updated the other files accordingly. You can view the changes in my commit here. Let me know if I missed anything.
Edit: should the description in MODEL_OUTPUT_LIST.TBL.adoc be "total runoff" or "total discharge to stream"?

We checked with @agetiran, and he thinks they are the same thing, just named differently.  Perhaps add it as:
"total runoff or discharge to stream"?

Thanks @karsenau! Just made the change. I think we're good to merge now.


Question about storing timestamp (Instant) on Postgres.

Hello guys. I have the following problem or do not understand what is happening here. I use Spring 2.7.5 with KTORM 3.5.0 as ORM framework with hikariCP as pool.
My Postgres 14.5 database table has the following properties:
create table if not exists FOO(
...
    created_at                      timestamp default now(),
    updated_at                      timestamp,
...

postgres=> SHOW time zone;
 TimeZone
----------
 GMT
(1 row)

The connection is established by hikari:
 val config = HikariConfig()
        config.driverClassName = "org.postgresql.Driver"
        config.jdbcUrl = "jdbc:postgresql://localhost:4000/postgres"
        ...
        config.validate()

The column binding declared by the KTORM interface binding is:
val createdAt = timestamp("created_at").bindTo { it.createdAt }

For the sake of testing, I save the time as follows:
entity.createdAt = Instant.parse("1999-12-31T23:00:00Z")

While the entity is written to the database, this log with statement is shown. The value passed matches the value parsed in the code snippet above.✅
[DEBUG] SQL: insert into FOO (..., created_at, updated_at, ...) values (?, ?, ?, ..)
[DEBUG] Parameters: [..., 1999-12-31T23:00:00Z(timestamp), null(timestamp) ...

🚨 when I query the data via SQL postgres=> SELECT * FROM FOO;. Just to make sure that pgAdmin or IntelliJ DataGrip don't have any time conversation on my local system (UTC+1), I have connected into the respective Docker container via terminal and executed the SQL query directly using psql console. Also pgAdmin or Datagrip return me the value 2000-01-01 00:00:00. ❌
postgres=> SELECT * FROM FOO;
 ... | created_at          |            | ...
 ... | 2000-01-01 00:00:00 |            | ...

What totally confuses me is that as soon as I load the entity from the database using KTORM, the time is correct?✅
[DEBUG] SQL: select ....
[DEBUG] Results: 1
Foo{..., createdAt=1999-12-31T23:00:00Z ...

action
time value
assert

parsed in code
1999-12-31T23:00:00Z
✅

sent to postgres by KTORM
1999-12-31T23:00:00Z
✅

persisted in postgres
2000-01-01 00:00:00
❌

returned by KTORM after query from postgres
1999-12-31T23:00:00Z
✅

Can someone be so kind and explain to me why the database keeps the value of 1999-12-31T23:00:00Z in local time UST+1 (2000-01-01 00:00:00). However, as soon as I query the entity using KTORM in spring, I get the correct time displayed (1999-12-31T23:00:00Z)?

What do I have to do so that the value in the database matches the value in the code? I explicitly do not want to save the time zone. I want to parse a UTC value, save it as UTC and have it returned as a UTC value.

Timestamp is just a long number of millis starts from 1970-01-01 00:00 UTC+0. Displaying the same timesamp in different time zone will get different results. java.time.Instant displays it in UTC+0, while your psql console displays it in your local time zone (UTC+1), but whatever it's displayed, it is always the same instant value.
If you want psql console display timestamps in UTC+0, you can try to change it's default time zone, see https://stackoverflow.com/questions/6663765/postgres-default-timezone

I think I've found the issue, code in postgresql driver 42.2.5, PgPreparedStatement, line 1349, using the system default time zone to format timestamps to strings before sending them to the database.
But it seems a JDBC's documented feature instead of a bug, there is a stackoverflow link for the same problem https://stackoverflow.com/questions/14070572/is-java-sql-timestamp-timezone-specific/14070771#14070771
Anyway, it's always a good practice to make you application and database server in the same time zone.


fix: bug 1654 text variation prebuild conflict

:tada: This PR is included in version 0.324.22 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ci: run screenshotter in container

Run screenshotters in a separate container: this would enable to run screenshotters (relatively) safely on PRs from forks, eliminating the need for the dispatcher and manual approval (test screenshots label)

Use selenium-proxy to hide Browserstack credentials
Only restore cache to prevent cache poisoning
Stop processing workflow commands when printing logs

Codecov Report

Merging #2644 (3618df4) into master (9d975ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2644   +/-   ##
=======================================
  Coverage   93.85%   93.85%
=======================================
  Files          86       86
  Lines        6172     6172
  Branches     1264     1264
=======================================
  Hits         5793     5793
  Misses        348      348
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d975ce...3618df4. Read the comment docs.

@ylemkimon this is awesome!  I'll make some time to review this in the next week or so.

It would be nice to see this in action before merging it.
https://github.com/ylemkimon/KaTeX/actions/runs/364429953

Thanks for posting a link to the test run.  I see it runs in the fork which makes sense.

@ylemkimon it looks like the new screenshot workflow is failing when it runs in KaTeX/KaTeX.  It looks like I have to allow the ylemkimon/cache-restore@v2 action you created.  I'm going to give that a try and see if that fixes things.

https://github.com/KaTeX/KaTeX/pull/2644/checks?sha=ff4ccdf555ba73007ea458ba24cedc2252337d4b shows the "screenshot" check as failed.  I changed the action settings to allow the cache-restore action and triggered a build but then the "screenshot" check didn't show up at all: https://github.com/KaTeX/KaTeX/pull/2644/checks?sha=8d1c3443840c523d4087556f3a5251f8e912cd5a. 😞

I see, the check is showing up in the Actions tab for repo: https://github.com/KaTeX/KaTeX/actions/runs/431515837.

I don't see it showing up as a status check in the "Branch protection rule" under "Settings" for the repo.

I guess the PR should be merged to see this in action.

https://github.com/KaTeX/KaTeX/actions/runs/431611148

I guess the PR should be merged to see this in action.

I updated #2396 and the checks are showing up now in that PR. 🎉