[SPARK-24395][SQL] IN operator should return NULL when comparing struct with NULL fields

What changes were proposed in this pull request?
Spark's IN operator behaves different from other RDBMS (Oracle, Postgres) when structs containing NULL fields are involved. In this case, Spark returns false, while other RDBMS return NULL. This is critical especially when there are NOT IN filters, as Spark doesn't filter rows containing NULLs in that scenario (instead other RDBMS do).
The PR proposes to change Spark's IN operator behavior in order to align with the behavior of other RDBMS and introduces a flag which can be used by users to switch back to the previous behavior.
In particular, the proposed change affects only the IN operator when the values are structs (ie. every value is a list of more than one element) and NULL are involved. The proposed behavior can be summarized as follows:

If the value before IN contains a NULL element, IN evaluates to null;
If the list of values contains a values with a NULL element, then: If the list contains also the value looked for, true is returned; otherwise, null is returned

Please notice that Hive and Presto, instead, behave as Spark before this change for this specific scenario. But they don't support IN with subqueries returning more than one value. So before this change Spark is anyway the only system where the IN operator behaves incoherently between IN + subquery and IN + literals.
Summarizing:

Spark is the only framework which behaves differently with the same data when IN contains literals and subquery;
Hive and Presto behave as Spark before the PR when literals are involved (but Presto throws exception when null is present in both sides...);
Oracle, Postgres behaves like Spark after the PR;
Hive and Presto don't support In with subqueries containing more than 1 output field.

The PR introduces also a the config flag spark.sql.legacy.inOperator.falseForNullField which can be used to turn on/off the new behavior.
How was this patch tested?
added UTs

cc @cloud-fan @hvanhovell  @juliuszsompolski

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1920/
Test PASSed.

Test build #94382 has started for PR 22029 at commit 54ee21a.

Is there a clear definition for the expected behavior? I tried postgre before, it returns null for things like (x, y) = (a, null), but throws analysis error for things like (x, (y, z)) = (a, (null, b))

@cloud-fan I agree with you that struct comparison behavior is questionable. But the IN (and NOT IN) behavior is coherent among Postgres, Oracle (and different from the current Spark behavior). This is the reason why I decided to propose to change only the behavior of the IN operator without changing the behavior of the struct comparison itself, which would be a much bigger change.
Anyway, answering to your question, since this PR relates only to IN/NOT IN, yes, there is a clear definition for the expected behavior in the other RDBMS.
PS please also notice that Spark currently has a different behavior for select 1 from (select 1) a where (1, 2) not in ((1, null)) and select 1 from (select 1) a where (1, 2) not in (select (1, null)); while all other RDBMS behave in the same way in the two cases.

yes, there is a clear definition for the expected behavior in the other RDBMS.

Can you put the general definition of the IN behavior (without subquery) in the PR description? The PR titile only specified the behavior for a specific case, not a general definition. e.g. nested fields are not mentioned.

Test build #94418 has started for PR 22029 at commit 5974aea.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1939/
Test PASSed.

Can you put the general definition of the IN behavior (without subquery) in the PR description?

Sure, I am changing it. Let me know if the description I am writing is clear/complete enough. Thanks.

nested fields are not mentioned.

They are not mentioned as in other RDBMS are not really possible. Neither Postgres nor Oracle allow that. So I haven't changed their handling as - I think - the expected behavior in that case is questionable. I think in general, IN using literal and IN using subqueries should return the same result if they are provided with the same data (as it happens in the RDBMS). So that case is handled as before the PR since the comparison of structs has not been changed here.

@cloud-fan I updated the description. Let me know if now it is clear enough. Thanks.

can we also update the classdoc of In?

Test build #94418 has finished for PR 22029 at commit 5974aea.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94418/
Test PASSed.

Merged build finished. Test PASSed.

BTW it will be great if this behavior is defined by the SQL standard. And we should also check the big data SQL systems like Hive and Presto. In general we should be careful for uncertain behaviors like this. That said, I feel returing false is not that wrong to me without considering other systems.
also cc @gatorsmile

Presto and Hive work in different ways.
Hive
Hive behaves as Spark before the PR, but Hive doesn't support IN with subqueries where the subquery outputs more than one field. So in Hive there is not the incoherence which is present in Spark (ie. with the same data IN with literals returns a different result than IN with subquery).
Presto
Presto, instead, behaves as Spark before the PR, but when there is a null both in the value and in the list of literal, it throws an exception and it behaves in the same way also when IN is used with subqueries.

Thank you for pinging me, @cloud-fan . For me, new way suggested in this PR looks reasonable. Also, this PR is configurable. We may be able to start to provide this as a non-default way in Spark 2.4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1988/
Test PASSed.

Test build #94480 has started for PR 22029 at commit 9b28842.

@mgaido91 do you mean the current behavior is same with Hive and Presto?

@cloud-fan if we consider only the expression IN with literals, yes, the behavior is very similar, with the following difference: Presto throws exception when null is present on both sides.
But what I'd really like to highlight is that there is a huge difference: both Hive and Presto (as well as the RDBMs are coherent in their behavior between IN with literals and IN with subquery). Actually, Hive doesn't support subqueries with more than one output field; Presto instead behaves in the same way in the case with literals and subqueries, which means it behaves like Spark before this PR with literals, but different from Spark when subqueries are involved.

Test build #94480 has finished for PR 22029 at commit 9b28842.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94480/
Test PASSed.

Merged build finished. Test PASSed.

Test build #94482 has finished for PR 22029 at commit 655eaa4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94482/
Test PASSed.

@cloud-fan @gatorsmile any thoughts on this?

kindly ping @cloud-fan @gatorsmile

kindly ping @cloud-fan @gatorsmile

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3084/
Test PASSed.

Test build #96035 has started for PR 22029 at commit 062c9fd.

Test build #96035 has finished for PR 22029 at commit 062c9fd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96035/
Test PASSed.

@cloud-fan @dongjoon-hyun @gatorsmile anymore comments on this?

Test build #97110 has started for PR 22029 at commit cf6b3b0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3793/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3794/
Test PASSed.

Test build #97110 has finished for PR 22029 at commit cf6b3b0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97110/
Test FAILed.

@mgaido91 . The failure is relevant to this PR. Could you take a look?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3817/
Test PASSed.

Test build #97150 has started for PR 22029 at commit 59ff46b.

Test build #97150 has finished for PR 22029 at commit 59ff46b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97150/
Test PASSed.

@mgaido91, mind if I ask add few notes about https://github.com/apache/spark/pull/22029#issuecomment-411473227? For instance, which DBMS follows the current change. And sounds the previous behaviour is closer to Hive but Hive's behaviour is not quite coherent?
It sounds reasonable to me.

Thanks for you comment @HyukjinKwon. Yes sure, I'll update the PR description, thanks.
Yes, the previous behavior is the same as Hive behavior. What I wanted to highlight there, though, is that every system (Hive included somehow) has the same behavior when IN is used, regardless whether IN is followed by a query or a sequence of literals. This is, IMHO, extremely important. As a end user, if I have a query which involves a IN with a complex subquery and I am testing/debugging it, I can put the output I expect from it as literals in order to check where is my problem (ie. in the subquery or not), so it is critical that the behavior in these 2 cases is the same, otherwise I - as a end user - would be very confused about what is going on. Basically, I mean that running:
select a, b, c from t1 where (a, b, c) in (select 1, null, "abc");

and
select a, b, c from t1 where (a, b, c) in ((1, null, "abc"));

should return the same result (which is not true before the PR in Spark, while for all other systems is).
Please notice that this PR focuses only in the case when the literal is a struct of more than one fields.
In the case of Hive, it has the same behavior as Spark before this PR, but Hive doesn't allow having subqueries which return more than one field. So, in the example above, the first query would throw an analysis exception, which is a limitation in Hive, but at least doesn't confuse the user with different behaviors.
Hope this answers your question. Please let me know if additional details are required. Thanks.

It looks to me that this is another instance of special handling (a, b, ..), like https://github.com/apache/spark/pull/21403
(a, b) in (struct_col1, struct_col2, ...) is different from input_struct_col in (struct_col1, struct_col2, ...), right?

It looks to me that this is another instance of special handling (a, b, ..), like #21403

Yes, we might say so. The problem is specific to how = is implemented for struct when one or more of their fields are null: we return false instead of null. But other DBs are not consistent on struct equality comparison (most of them don't allow such a comparison either), so it is hard to argue that we should change that behavior.

(a, b) in (struct_col1, struct_col2, ...) is different from input_struct_col in (struct_col1, struct_col2, ...), right?

So yes, that would be different when there are nulls as one would evaluate to false, the other to null.

Do you know how other databases behave for (a, b) in (struct_col1, struct_col2, ...) and input_struct_col in (struct_col1, struct_col2, ...)? Since (a, b) may be treated specially, we need to look at the behaviors carefully.

Yes, I summarized earlier the behavior for (a, b) in (struct_col1, struct_col2, ...). You can also check the PR description in "Summarizing:".
Instead, input_struct_col in (struct_col1, struct_col2, ...) has not really wide support:

Postgres fails:

mgaido=# select 1 from (select (1, 'a') as c1) t1 where c1 in ((1, 'b'), (2, 'a'));
ERROR:  could not identify an equality operator for type unknown

Oracle does the same.
Hive behaves like Spark now (before and after the PR) for this case.

Sorry, I'll clarify:

Oracle doesn't support input_struct_col in (struct_col1, struct_col2, ...) (same as Postgres);
Hive returns false in that case.

So, the goal here is to make the behavior consistent between multi-column IN-subquery and multi-column normal IN for Spark.
That said, I feel it's reasonable to change the behavior of (a, b) in (struct_col1, struct_col2, ...) to return null if a field is null, but it seems pretty weird to also apply this behavior to input_struct_col in (struct_col1, struct_col2, ...). It's OK to treat the (...) syntax specially, but it's strange to treat struct type different.

Yes, I see your point. Unfortunately, the only way to address it is to introduce a new wrapper as it was done previously in #21403 in order to be able to differentiate the cases. We can do that, despite it seems a bit of overkill only for this. WDYT?

I don't have a strong opinion. cc @gatorsmile @hvanhovell @juliuszsompolski

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4199/
Test PASSed.

Test build #97712 has started for PR 22029 at commit 59ff46b.

Test build #97733 has started for PR 22029 at commit 59ff46b.

Test build #97733 has finished for PR 22029 at commit 59ff46b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #97712 has finished for PR 22029 at commit 59ff46b.

This patch fails due to an unknown error code, -9.
This patch does not merge cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97712/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97733/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4294/
Test PASSed.

Test build #97800 has finished for PR 22029 at commit 59ff46b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97800/
Test FAILed.

Test build #98027 has finished for PR 22029 at commit 321b9a8.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class InBase extends Predicate
case class InSubquery(values: Seq[Expression], query: ListQuery)
case class In(values: Seq[Expression], list: Seq[Expression]) extends InBase

Test build #98084 has started for PR 22029 at commit 1933e9d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4531/
Test PASSed.

Test build #98084 has finished for PR 22029 at commit 1933e9d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait InBase extends Predicate
case class InSet(values: Seq[Expression], hset: Set[Any]) extends InBase

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98084/
Test FAILed.

Test build #98089 has started for PR 22029 at commit 809e80c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4534/
Test PASSed.

anymore comments on this @cloud-fan ? Thanks.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4666/
Test PASSed.

Test build #98318 has started for PR 22029 at commit 389e6de.

Test build #98318 has finished for PR 22029 at commit 389e6de.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98318/
Test PASSed.

Do you know how Presto supports multi-value in subquery? By reading the PR description, it seems impossible if Preso treats (a, b) as a struct value. How Preso distinguish (a, b) IN (select x,y ...) and struct_col IN (select x,y ...)?

@cloud-fan Presto doesn't have structs. Presto has ROW. (a, b) IN (select x, y ...) is a valid mutli-value subquery in Presto, while for a struct (ie. a row) the valid syntax is row_col IN (select ROW(x,y) ...). So (a, b) is never considered a struct value in Presto. Did this answer?

which Presto version did you test? I tried 0.203 and it fails
presto:default> select * from t2 where (1, 2) in (select x, y from t);
Query 20181101_085707_00012_n644a failed: line 1:31: Multiple columns returned by subquery are not yet supported. Found 2

@cloud-fan sorry, I mistyped. I meant (a, b) IN (select (x, y) ...) is a valid subquery, but probably my understanding that it was a multivalued subquery is wrong, as I realize now that (x, y) returns Presto's equivalent of a struct. So I have to update the PR description that Presto behaves as Hive, ie. it doesn't support multivalue subqueries. Sorry for the confusion, I am updating the PR description.

@cloud-fan yes, but the behavior of EQUAL is not so consistent among the different DBs. In Hive EQUAL on struct behaves like Spark as of now, in Presto throws exception if there is a null, Postgres is different and it is as you mentioned. So I am not sure we have strong reasons to update how EQUAL works for struct. That doesn't seem to be handled consistently in other DBs. That's why I proposed this change, in order to handle IN consistently without modifying EQUAL for structs.

If we want to follow PostgreSQL/Oracle for the IN behavior, why don't we follow the EQUAL behavior as well?

Oracle doesn't support EQUAL between structs: (1, 'a') = (1, 'b') doesn't work on Oracle. Postgres is the only one returning NULL in the case (1, 'a') = (1, null).
My main reason here is to make IN working in the same way (assuming that the same data is involved) both when literals and when subqueries are involved: this is my goal. One of the main reasons is that often users who want to debug queries try to put the expected output in the subquery in the IN expression so having a different behavior may be deceived and anyway a user would be at least surprised by this behavior.

If we decide to follow PostgreSQL about the EQUAL behavior eventually, then it will be much easier to fix the IN behavior, right?

I think so, in that case we wouldn't need to distinguish between a struct and a mutli-value IN.

@cloud-fan do you think we can go ahead with this or change EQUAL behavior for structs? thanks.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12991/
Test PASSed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13186/
Test PASSed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15750/
Test PASSed.


Shift O is a shortcut

Typing Shift + O causes a dialog to open that says, "There is no application set to open the URL .... Search the App Store for an application that can open this document, or choose an existing application on your computer."
I'm using the latest version of El Capitan on my Macbook (10.11.12).

Cannot replicate on Yosemite (or Windows 10 for that matter) myself.

This should be unrelated to Brackets. Is this still reproable?

It happens on my work computer, but not my personal one (both Macs). Can't figure out why this is happening.

Does this happen only with brackets?

Does this happen only with brackets?

Yes

can you try debug>reload without extensions and see the behavior.

Yep, that fixed the problem! Thank you!!!

IT might be some extensions that caused it.
Try uninstalling some extensions to narrow down which one is causing the problem
Closing as extension problem.


Rotating Image in viewMode: 1 is causing image to change zoom

Steps to reproduce:

Go to Demo url of the tool.
Select view mode 1.
Rotate image 90 degrees by clicking on rotate 45 button twice.
Observe that zoom level of the image changes.
Rotate image -90 degrees by clicking on rotate -45 button twice again to get original image on canvas back.
Observe that original image is zoomed in and does not remain same.

Once you rotate the image, the size of the image enlarged to fit the crop box.

yes but doesn't it make more sense to make smaller selection instead?

You can adjust zoom through mouse wheel rotation or through touchpad two
finger motion. If not try making box smaller and try to adjust zoom again.
On 10-Dec-2015 2:17 am, "makc"<EMAIL_ADDRESS>wrote:

yes but doesn't it make more sense to make smaller selection instead?
—
Reply to this email directly or view it on GitHub
https://github.com/fengyuanchen/cropper/issues/537#issuecomment-163387370
.

This is not a bug. If you call the $().cropper('rotate', 180) directly, you will find it works as what you expect.


Set maximum video length

How can I set maximum duration of video for single video and single audio merge?

Use the duration parameter in the setup(withImages) function.

@tgeorgieva  I have give static value to duration like this:
//original
duration = max(_duration, Double(CMTime(seconds: minSingleVideoDuration, preferredTimescale: 1).seconds))
// static value
duration = 5

but still video generated by audio length.

In the mergeAudio(withVideoURL) there is another duration parameter which gets incremented with the audio length when it's being added to the generated video.
Keep in mind, setting the max length of a video like that doesn't mean the audio will get faster or the frame duration shorter, just means it'll cut off at the time the video stops. You can try doing that, changing the frame time but the audio manipulation will be tricky.

I have also tried to set duration in mergeAudio(withVideoURL):
        duration = duration + audioAsset.duration
        duration = CMTime(seconds: Double(5), preferredTimescale: 1)

but still video length is equal to audio length.


Remove inline JS and CSS

In order to comply with stricter content-security-policies, move the JS and CSS to their own files. Still WIP
Progress

[x] Javascript

[x] Bricklayer in blog.html.twig
[x] Singlepage in modular.html.twig
[x] Full testing

[ ] Inline CSS

[ ] Hero partial (background-image)
[ ] Checkbox form field
[ ] Full testing

Which content-security-policies do you refer to?

For example, in Apache2, we can set Header set Content-Security-Policy "default-src 'self'; script-src 'self' 'unpkg.com'; img-src *; style-src 'self'"
This ensures that the only sources of JS and CSS can be loaded from only the main server (self) and the JS can be additionally loaded from unpkg.com. However, this prevents inline style and JS from working unless if you use unsafe-inline. It looks like this: Header set Content-Security-Policy "default-src 'self'; script-src 'self' 'unsafe-inline'; img-src *; style-src 'self' 'unsafe-inline'". Using the unsafe-inline directive is, as you can tell, unsafe and more or less makes using CSP useless.

It appears as if the no inline JS is working fine (running on my website). The CSS seems difficult because it contains some Twig.

I don't have time to continue working on this PR. I've forked this theme and am making all of my changes there. https://github.com/9p4/grav-theme-ersei


ACL module

Can you indicate some ACL package that fits well with your module?

Any ACL package you want.


RedisTokenStore not serialize the Principal when serialize Authentication

Hi, @efenderbosch
When I'm using RedisTokenStore, the token get generated, but when I use the token to access the resource, I got the Exception "Principal must not be null".
With further investigation I found that the principal did not get serialized.
Before serialization the principal have values

After desrialize the principal field became null

I don't understand why JdkSerializationStrategy() have problem serializing my principal.
Any advice would be appreciated.

I think I may found the cause of my problem:
UsernamePasswordAuthenticationToken has
serialVersionUID = SpringSecurityCoreVersion.SERIAL_VERSION_UID
So, UsernamePasswordAuthenticationToken is treated as AbstractAuthenticationToken when serializing.
Any suggestions what I should do, if I want to serialize my principal in the RedisTokenStore?

My customUserDetails has two fields not implementing the Serializable.
So, the serialization has no problem.
But when using RedisTokenStore, I noticed that TokenConvert not get called.
Is this mean TokenConverter is for JWT only? or I just did something wrong?
`    @Override
public void configure(AuthorizationServerEndpointsConfigurer endpoints) throws Exception {
endpoints.tokenStore(tokenStore())
.accessTokenConverter(tokenConverter())
.reuseRefreshTokens(false)
.exceptionTranslator(creamsExceptionTranslator())
.authenticationManager(authenticationManager)
.userDetailsService(creamsUserDetailsService)
.setClientDetailsService(clientDetailsService);
}
@Bean
public AccessTokenConverter tokenConverter(){
    DefaultAccessTokenConverter defaultAccessTokenConverter = new DefaultAccessTokenConverter();
    defaultAccessTokenConverter.setUserTokenConverter(new CustomUserAuthenticationConverter());
    return defaultAccessTokenConverter;
}`


Collection Relations

Are relations a collection (but not the documents in the collection on its own have) supposed to simply go into the meta tag? If so, could we make this part of the spec?

No, can a collection have relations. ie, here's a collection of post, can it have a "next" relationship to another collection of posts, even thought the posts on its own would not have such a relation, or do we need an intermediate "page" resource? How does this work for embedded collections?

I believe this is irrelevant now with the latest version of the spec.


Is there a way to use --export with "git tfs branch --init"?

I'm having issues with --branches=all correctly dumping out my repository.  Since I only need 3 of the branches though, I'm hoping I can work around it.  I'm able to dump out my main branch via clone with --export to keep work item details, but I can't figure out how to tell the git tfs branch --init commands to add the other two branches to keep work item details as well.  Am I missing something?

If you originally used --export when you cloned, then you don't need to use the same option during a git-tfs branch --init because if you look in your git-tfs git repository's .config file, you'll see the following entries:
[git-tfs]
        export-metadatas = true

So you should be good to go!


mount error(115) on "nanobox run"

While trying to nanobox run I get the following error:
λ nanobox version
Nanobox version 2.0.2 ()
λ nanobox run
Preparing environment :
  * Mounting codebase

MBrodala's password is required to mount a Windows share. (must be your Windows Live password if linked)
Password:

  ! Mounting codebase

Error   : mount: output: mount error(115): Operation now in progress
Refer to the mount.cifs(8) manual page (e.g. man mount.cifs)
mount: mounting //<IP_ADDRESS>/nanobox-d5cbe4585cc247d7c24ecf7cc4048e62 on /share/d5cbe4585cc247d7c24ecf7cc4048e62/code failed: Operation now in progress
exit status 32
 err:exit status 1
Context : failed to init docker client -> failed to setup env mounts -> failed to mount the code share on the provider

Enter to continue:

Any idea what could be wrong?

tagging @lyondhill

More details from the ~/.nanobox/nanobox.log:
2017-02-15 16:35:17 INFO  adding share in netfs for C:/Users/mbrodala/project
2017-02-15 16:35:17 INFO  adding mount in for netfs C:/Users/mbrodala/project -> /share/d5cbe4585cc247d7c24ecf7cc4048e62/code
2017-02-15 16:35:47 ERROR mount: output: mount error(115): Operation now in progress
Refer to the mount.cifs(8) manual page (e.g. man mount.cifs)
mount: mounting //<IP_ADDRESS>/nanobox-d5cbe4585cc247d7c24ecf7cc4048e62 on /share/d5cbe4585cc247d7c24ecf7cc4048e62/code failed: Operation now in progress
exit status 32
 err:exit status 1
2017-02-15 16:35:47 ERROR goroutine 1 [running]:
runtime/debug.Stack(0xc04221e140, 0x133, 0x0)
  /home/travis/.gimme/versions/go1.7.3.linux.amd64/src/runtime/debug/stack.go:24 +0x80
github.com/nanobox-io/nanobox/util.Err.log(0xc04221e140, 0x133, 0xcfb978, 0x0, 0x0)
  /home/travis/gopath/src/github.com/nanobox-io/nanobox/util/error.go:51 +0xd1
github.com/nanobox-io/nanobox/util.ErrorQuiet(0xca9080, 0xc0421c8f00, 0x2e, 0x2e)
  /home/travis/gopath/src/github.com/nanobox-io/nanobox/util/error.go:86 +0x219
github.com/nanobox-io/nanobox/util.Error(0xca9080, 0xc0421c8f00, 0xc0421c8f00, 0xc0423fd8e0)
  /home/travis/gopath/src/github.com/nanobox-io/nanobox/util/error.go:96 +0x5d
github.com/nanobox-io/nanobox/util.ErrorAppend(0xca9080, 0xc0421c8f00, 0xa1df3d, 0x2e, 0x0, 0x0, 0x0, 0x18, 0x0)
  /home/travis/gopath/src/github.com/nanobox-io/nanobox/util/error.go:119 +0x380
github.com/nanobox-io/nanobox/processors/env.Mount(0xc042098370, 0x0, 0x0)
  /home/travis/gopath/src/github.com/nanobox-io/nanobox/processors/env/mount.go:42 +0x2c9
github.com/nanobox-io/nanobox/processors/env.Setup(0xc042098370, 0x0, 0x0)
  /home/travis/gopath/src/github.com/nanobox-io/nanobox/processors/env/setup.go:37 +0x365
github.com/nanobox-io/nanobox/processors.Build(0xc042098370, 0x0, 0x0)
  /home/travis/gopath/src/github.com/nanobox-io/nanobox/processors/build.go:20 +0x6d
github.com/nanobox-io/nanobox/commands.buildFn(0xcd5a00, 0xc042279e70, 0x1, 0x1)
  /home/travis/gopath/src/github.com/nanobox-io/nanobox/commands/build.go:40 +0x4e
github.com/nanobox-io/nanobox/commands/steps.Run.func1(0xcd5a00, 0xc042279e70, 0x1, 0x1)
  /home/travis/gopath/src/github.com/nanobox-io/nanobox/commands/steps/run.go:20 +0x143
github.com/nanobox-io/nanobox/vendor/github.com/spf13/cobra.(*Command).execute(0xcd5a00, 0xc042279e40, 0x1, 0x1, 0xcd5a00, 0xc042279e40)
  /home/travis/gopath/src/github.com/nanobox-io/nanobox/vendor/github.com/spf13/cobra/command.go:561 +0x444
github.com/nanobox-io/nanobox/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xcd2e00, 0x0, 0x0, 0x1)
  /home/travis/gopath/src/github.com/nanobox-io/nanobox/vendor/github.com/spf13/cobra/command.go:656 +0x3df
github.com/nanobox-io/nanobox/vendor/github.com/spf13/cobra.(*Command).Execute(0xcd2e00, 0xa57b70, 0xc04224f300)
  /home/travis/gopath/src/github.com/nanobox-io/nanobox/vendor/github.com/spf13/cobra/command.go:615 +0x32
main.main()
  /home/travis/gopath/src/github.com/nanobox-io/nanobox/main.go:104 +0x253

2017-02-15 16:35:47 INFO  notifying bugsnag: mount: output: mount error(115): Operation now in progress
Refer to the mount.cifs(8) manual page (e.g. man mount.cifs)
mount: mounting //<IP_ADDRESS>/nanobox-d5cbe4585cc247d7c24ecf7cc4048e62 on /share/d5cbe4585cc247d7c24ecf7cc4048e62/code failed: Operation now in progress
exit status 32
 err:exit status 1
2017-02-15 16:37:23 *LOG* Closing log now

Can you have a closer look at this? NB is currently unusable for me due to this.

hello mbrodala I have been looking into mouting issues and have not been able to reproduce the issue your having. It would appear there is something getting in the way of the mounting. Is there a time we can work through the issue in real time (slack) that would work for you?

This may be related to #365 but I'm investigating it right now. If I have the following in my boxfile.yml, I get the error above:
data.chrome:
  image: selenium/standalone-chrome

It's weird, I cannot reproduce the issue anymore using version 2.0.2 (e89afaff3cf8a7621eba73c1ddc5b525).
I thought that the issue would show up if I have that component in my boxfile.yml on the first start but even that did work now.
So for now this is fixed for me.

@mbrodala we had another user who ran into this issue. After some digging we found that his firewall was stopping the vm from comunicating with his windows machine. If you run into it again lets have a look at your firewall.

Thanks for the pointer. I'll let you know when it shows up again.

Sorry to necro, but I found my solution here -https://github.com/nanobox-io/nanobox/issues/462


Explorer - Transcoder View (transactions)

Issue #13 defines a view for transcoder data. This should be actionable to let users actually bond and elect transcoders.

Show token balance and bonding status for the user's web3 enabled account (Metamask, Parity, web3 to local node, etc).
Add a bond button that lets them specify how much LPT they'd like to bond.
Add a button next to each transcoder that allows them to delegate towards that transcoder.

These steps could potentially be combined into one step. Purely show them who they're delegating to, and if they choose to delegate button there's a request that asks them how much total LPT they'd like to deposit/bond/delegate in total. This could generate all the necessary transactions under the hood.

The first pass implementation has been deployed to https://explorer.livepeer.org :shipit:


JDeodorant added to ProductHunt

I apologize for using this channel to contact you. I'm passionate about code refactoring and I've found your tool after a lot of research. It's a very interesting tool but it's not well advertised, I've invested some minutes to list it into one of the most famous directories, hope this helps.
https://www.producthunt.com/posts/jdeodorant

Hi @slim16165
Thank you for advertising JDeodorant.
The project was active between 2007-2019, but is no longer maintained, as our current research focuses on refactoring mining.
You might find interesting the RefactoringMiner project.


Memory leak when unable to terminate FMU

When using the library, I am encountering a memory leak in the situation where the program exits when the FMU is not in a state where terminate is allowed to be called. For example, if an exception is thrown after enter_initialization_mode() is called, but before exit_initialization_mode() is called. I looked at the destructor in the fmu_instance_base class, and it is calling terminate(), which attempts to terminate the FMU and free the resources:
    bool terminate(bool freeInstance)
    {
        if (!this->terminated_) {
            this->terminated_ = true;
            if (!library_->terminate(c_)) {
                return false;
            }
            this->free_instance();
        }
        return true;
    }

However, if the library fails to terminate the FMU, the function returns early with false, and the free_instance() function is never called. This corresponds to fmi2FreeInstance, which should be callable even when the FMU is not terminated. It could be changed to something like the following.
    bool terminate(bool freeInstance)
    {
        if (!this->terminated_) {
            this->terminated_ = library_->terminate(c_);
        }
        this->free_instance();
        return this->terminated_;
    }

Or the call to free_instance can be removed from terminate and simply called from the destructor like:
    ~fmu_instance_base()
    {
        terminate();
        free_instance();
    }

I'll see if I can look into this not to long into the future. I notice that bool freeInstance is not actually used, so the code path needs some cleanup regardless.


Make icons for all the classes listed on Materials page

Description
Make icons for each class listed on the materials page so that they are consistent across the page.
Ask
Create .png files that are 512x512 pixels with a navy blue icon that represents that class.
To Do

[ ] Make the icons
[ ] Load them into images/materials so that they are accesable by all.
[ ] Include source file in .ai or .pdf format

Additional Info
Example HTML icon

I've started on this as apart of #193

:+1: nice!

Yes!

Wait...are we missing a few here? I'll leave for post-launch if more time is needed. We do have place-holders on the site for nwo

@Cara-Jo You can email the files when you have them ready, and I'll drop them in via the admin. Thanks!

Will do @Roenok. Sorry @kstack7 I didn't upload them with the PR.

No big! Easy fix, @Cara-Jo :)

Hi! Is this issue still open?

We currently have icons for everything (thanks @Cara-Jo), so closing this old issue.


chore: test ci2

Checklist

[ ] JIRA - <link>
[ ] Proper tests implemented
[ ] Screenshots added.

Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes

Used for testing Smoke tests CI job


implement codescene.io badge

add the badge to the readme, very useful tool 👍

not so important anymore, code-climate does a really good job


Bugfix: change default git user to 1010:1010 and make git user more configurable

Bugfix for: https://github.com/go-gitea/gitea/issues/23632
There are several issues with the hardcoded values in the existing Dockerfiles (1000:1000).
This change adds GIT_GID and GIT_UID env vars to the Dockerfile. This allows the builder to optionally set custom user and group IDs for the git user.
If no values are supplied, then it will default to a new UID and GID of "1010" - which will avoid any conflicts with the default user(1000:1000) on some systems.
I also made amendments to the docker installation documentation(.en and .cn) to reflect the changes.

Thank you for your PR. I'm worried that this might be a breaking change for users who have their files already owned by the current IDs. Are you able to suggest a path forward to ensure that existing users won't need to run manual tasks prior to upgrading?

Thank you for your PR. I'm worried that this might be a breaking change for users who have their files already owned by the current IDs. Are you able to suggest a path forward to ensure that existing users won't need to run manual tasks prior to upgrading?

Perhaps docker-setup.sh can perform an ownership check of Gitea's data files. If ownership is incorrect, fail in a similar way as when the RUN_USER check fails, with a description of how to fix the issue. Alternatively it might be possible to ship a setuid root binary that resets ownership automatically, but that should probably be included in the image for only a limited number of releases.
Unfortunately this is not an easy fix. Bullets have to be bitten, or the Docker image will remain fundamentally flawed.
I'm not sure 1010:1010 is a great choice either. Generate a random number between 5000 and 20000, and use that. The idea is to pick a UID and GID that is unlikely to clash with an existing user account on the host server. Every Linux distro I know of allocates UIDs and GIDs starting from 1000.

I don't think this is a good solution, I don't see how clash with host UID/gid affects anything, containers are namespaced and UID does not really affect much, as for risk host user accessing volume data, this should really be controlled by parent directory rights to prevent that

I agree. The point of containers is to isolate processes and users and this is why sub UIDs exist.
Yes there is a way to map a host user to a guest user but that is usually to hack around another wider system configuration shortcoming.
Moving gitea uid from 1000 to 1010 doesn't solve this system problem, just moves it.
THUS the question has to be asked... Why is --user used to launch the container to then be hit with this uid clash.
NOTE making the uid/gid configurable isn't a bad thing but also neither is the assumption that a container dedicated to an isolated process wouldn't be the only user and thus starting at 1000, as per convention, is valid

@lafriks @eeyrjmr While Docker does support namespaced UIDs and sub UIDs, it is not enabled by default. UID x in a container is the same UID x in the host. Anyway, enabling user namespaces would only complicate matters in this case.
The issue here is a combination of SSH pass-through and IsRunUserMatchCurrentUser/mustCurrentRunUserMatch.
It is desirable to pass SSH connections through from the host to the container using a simple process execution in the container environment. For that to work, Gitea in the container needs to be running on a UID that the host is able to allocate to a dedicated SSH user account. If Gitea is running on UID 1000, that's very likely to clash with a pre-existing user account on the host.
Considering how the container needs to interact with the host in this case, it is reasonable to allocate a unique UID to the container, just like daemons running in the host are commonly allocated unique UIDs as well.
That said, half of the problem is Gitea's IsRunUserMatchCurrentUser function. It is easy to run a Docker image on a UID different from what was declared in the Dockerfile, but this function causes Gitea to fail at startup if the UID doesn't match the RUN_USER /etc/passwd entry that's baked into the Docker image. I see this function is bypassed if the internal SSH server is enabled, so I gather this function exists only as some kind of safety net to catch common errors in setup.
If the default UID must remain 1000, the questions to ask then are:

Why does Gitea need IsRunUserMatchCurrentUser?  I don't think it needs to, so there should be a configuration option to bypass this function, irrespective of the internal SSH server state, and arguably it should default to enabled in the rootless Docker image.
Following on, why does the rootless Docker image then need passwd and group entries? I think they become superfluous if IsRunUserMatchCurrentUser is bypassed.


metricbeat: publish k8s metrics to ELK

Continue #275
Tasks:

Deploy metric beat on k8s
Publish k8s system monitor data to ELK

Docs:

https://www.elastic.co/guide/en/beats/metricbeat/current/running-on-kubernetes.html

https://github.com/elastic/examples/blob/master/Machine Learning/Getting Started Examples/server_metrics/kibana-dashboard.json


Add example for how to check if a widget is not in the document

expect(document).to_not have_widget(:foo)

Addressed with https://github.com/mojotech/dill/pull/110


NIFI-10629 Fixed Flaky Test failing with NonDex

Summary
NIFI-10629
Tests in the testBulletinEntity() under TestJsonEntitySerializer express non-deterministic behavior when comparing two JSON strings. The fix is adding the readTree() from the Object Mapper class that treats the JSON object as a JsonNode to ensure deterministic behavior.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[x] JDK 8
[ ] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

Thanks for the contribution @priyanka-28.
The test is not unstable in normal execution, and this change alters the purpose of the unit test, which is to compare the serialization output with an expected string. This change parses both the expected string and the output string to a JsonNode for comparison.
Unless there is an alternative improvement that preserves the serialized string comparison, this change cannot go forward.

Thank you for your response. I have updated the PR with new changes.


TiRemoteBlockInputStream(ExchangeReceiver): different types: expected Nullable(Int64), got Int64

Use test;
create table t (id int, d double, nd double not null);
Alter table t set tiflash replica 1;
insert into t values (0,0,0),(1,1,1),(2,null,2);
create table tt like t;
alter table tt set tiflash replica 1;
insert into tt  select * from t;
insert into tt  select * from t;
insert into tt  select * from t;
insert into tt  select * from t;

Select DD,NDD,IDD from tt join
(
(select d as DD, nd as NDD, id as IDD from t) union all
(select d as DD, 0 as NDD, id as IDD from t) union all
(select d as DD, nd as NDD, 0 as IDD from t)
) u on tt.id = u.IDD;

mysql> desc Select DD,NDD,IDD from tt join  ( (select d as DD, nd as NDD, id as IDD from t) union all (select d as DD, 0 as NDD, id as IDD from t) union all (select d as DD, nd as NDD, 0 as IDD from t)  ) u on tt.id = u.IDD;
+--------------------------------------------+---------+--------------+---------------+-------------------------------------------------------------------------------------------------+
| id                                         | estRows | task         | access object | operator info                                                                                |
+--------------------------------------------+---------+--------------+---------------+-------------------------------------------------------------------------------------------------+
| TableReader_65                             | 16.12   | root         |               | data:ExchangeSender_64                                                                          |
| └─ExchangeSender_64                        | 16.12   | cop[tiflash] |               | ExchangeType: PassThrough                                                                       |
|   └─Projection_17                          | 16.12   | cop[tiflash] |               | Column#19, Column#20, Column#21                                                                 |
|     └─HashJoin_63                          | 16.12   | cop[tiflash] |               | inner join, equal:[eq(fzh.tt.id, Column#21)]                                                    |
|       ├─ExchangeReceiver_33(Build)         | 7.80    | cop[tiflash] |               |                                                                                |
|       │ └─ExchangeSender_32                | 7.80    | cop[tiflash] |               | ExchangeType: Broadcast                                                                         |
|       │   └─Union_23                       | 7.80    | cop[tiflash] |               |                                                                                |
|       │     ├─Projection_24                | 2.40    | cop[tiflash] |               | fzh.t.d, cast(fzh.t.nd, double BINARY)->Column#20, cast(fzh.t.id, bigint(11) BINARY)->Column#21 |
|       │     │ └─Selection_26               | 2.40    | cop[tiflash] |               | not(isnull(cast(fzh.t.id, bigint(11) BINARY)))                                                  |
|       │     │   └─TableFullScan_25         | 3.00    | cop[tiflash] | table:t       | keep order:false                                                                                |
|       │     ├─Projection_27                | 2.40    | cop[tiflash] |               | fzh.t.d, 0->Column#20, cast(fzh.t.id, bigint(11) BINARY)->Column#21                             |
|       │     │ └─Selection_29               | 2.40    | cop[tiflash] |               | not(isnull(cast(fzh.t.id, bigint(11) BINARY)))                                                  |
|       │     │   └─TableFullScan_28         | 3.00    | cop[tiflash] | table:t       | keep order:false                                                                                |
|       │     └─Projection_30                | 3.00    | cop[tiflash] |               | fzh.t.d, cast(fzh.t.nd, double BINARY)->Column#20, 0->Column#21                                 |
|       │       └─TableFullScan_31           | 3.00    | cop[tiflash] | table:t       | keep order:false                                                                                |
|       └─Selection_22(Probe)                | 11.99   | cop[tiflash] |               | not(isnull(fzh.tt.id))                                                                          |
|         └─TableFullScan_21                 | 12.00   | cop[tiflash] | table:tt      | keep order:false                                                                                |
+--------------------------------------------+---------+--------------+---------------+-------------------------------------------------------------------------------------------------+
17 rows in set (0.00 sec)

mysql> Select DD,NDD,IDD from tt join  ( (select d as DD, nd as NDD, id as IDD from t) union all (select d as DD, 0 as NDD, id as IDD from t) union all (select d as DD, nd as NDD, 0 as IDD from t)  ) u on tt.id = u.IDD;
ERROR 1105 (HY000): other error for mpp stream: DB::Exception: Block schema mismatch in TiRemoteBlockInputStream(ExchangeReceiver): different types: expected Nullable(Int64), got Int64
mysql>

update


refactor: popup replace modal

Description
Please provide a brief summary of the changes. If it is related to an issue, please bring the issue number, like fixes #${number}.
Package

[ ] tuya-panel-animation-sdk
[ ] tuya-panel-api
[ ] tuya-panel-electrician-sdk
[ ] tuya-panel-ipc-sdk
[ ] tuya-panel-lamp-sdk
[ ] tuya-panel-lock-sdk
[ ] tuya-panel-robot-sdk

Type of change
Please select the relevant option.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

从 master 合并到自己的分支不需要提 pr


Add animation for detail panel entry/exit

@oze4: this PR tries to resolve #252
Here is a first working draft that seems to add the desired behavior. I have also added a new usecase to the demo app that handles multiple detail panels.
Here is a demo of the new feature:

Do let me know what could be improved or requires attention.
This is my first contribution here, so apologies if I haven't followed some specific guidelines.

p.s. Note that the changes could have been even more minimal if only entry animation was required. This would have sufficed:
{
    <Collapse in={Boolean(props.data.tableData && props.data.tableData.showDetailPanel)} timeout="auto" unmountOnExit>
                 {typeof props.data.tableData.showDetailPanel === 'function' ? props.data.tableData.showDetailPanel(props.data) : null}
    </Collapse>
}

But to have animation on exit as well, it was necessary to handle 'function' and 'object' as separate cases. Collapse itself handles hide/show of its children, and so the rendering of the child elements shouldn't be controlled directly via state parameters but rather via parameter in of Collapse. It is therefore required to have the loop rendering each detail panel, when multiple exists.
The good part is that Collapse doesn't simply "hide" the display of its children, but also ensures it isn't rendered in the DOM until required. This helps avoid unnecessary pre-load of detail panel content.

@appukuttan-shailesh thanks for this, by the way! Your help/time/contribution is greatly appreciated, my friend!

I think the animation should be the default. But it is actually quite tricky because we don't know the size of what is rendered and it might change during renders.
Also the logic currently of passing the detail panel function into the table data is quite weird and blocks this. Because we cannot render an exit animation because it's just gone on close. So I like this but it's not as straight forward as it seems.

Works for me (I agree btw) just wanted your opinion! Thank you.

@Domino987 if we get a bunch of issues on this, we can revert these changes so we can figure out a better way.

Yes but I think this looks good. We will see :)

Yea I like it how it is. Almost like separation of concerns (or functions). Just easier to read like it is imo.

Thanks @oze4  and @Domino987 ! Happy to see this accepted and included in the package.
I had wondered if to add another paramter to allow turning this animation on/off. But decided to keep changes minimal, unless requested explictly. I too felt it would be nice to keep the animation as the default behavior, and so went with it. Curious to see if any other aspect got affected unknowingly.
Thanks for making the 3.0.17 release quickly!


website unorganized and clumsy

What happened?
The parent website that hosts all the games is not well organized, some of the cards are so huge that they cover the entire screen. The Screenshot of this bug is provided below. Please review it.
How can we reproduce this bug?
Screenshots
bug

bug

expected

Please assign this issue to me under GSSOC'24.
Desktop Information (Optional)
No response
Urgency (Optional)
High priority

@Dhruv-Gaba This is the old UI, will be updating the new UI soon.


cli::cluster_query: Remove allow(clippy::arithmetic_side_effects)

This is a big one.
For this one, I did spend some time assessing the impact of the saturated math.
In particular, slot mathematics seems to be less "noisy" when done using i64 rather than u64.
I assume that it is unrealistic to expect slot numbers to exceed i64::MAX.
Using saturating math for stats seems to be the right trade-off.
But if someone what to do a quick check of all the other cases, I'll be glad to correct any shortcomings you might uncover.

Codecov Report
Attention: Patch coverage is 0% with 94 lines in your changes are missing coverage. Please review.

Project coverage is 82.1%. Comparing base (57f92b7) to head (52f33df).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1167     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%
=========================================
  Files         886      886
  Lines      236394   236405     +11
=========================================
- Hits       194205   194185     -20
- Misses      42189    42220     +31

Thanks for the explanations and the work!

Thanks a lot for your reviews!
I have a bunch more of similar PRs.
Hope I would not get you too discouraged by these rather minor, but numerous changes %)
Your reviews have been super helpful.


Feature: Call

Please add a Call function that allows to set a call channel and call another server by id to create a chat between two server.
To start a call use one command and then in the channel of the other server a message will get posted that there is an ongoing call with accept and reject (reactions or command). If accepted all messages from both channels will transferred (using webhook or bot message) To end call just add an end command.

Hi Johannes,
That's an good idea tbh.
We will look into it and maybe implement it!
We will close this issue and reopen it for Updates.
Tayron


Mobile View Portfolio Website

Created mobile view portfolio using HTML and CSS. I also used linters to check my code and CSS

working on Portfolio mobile view website page. Made use of HTML&CSS and linters.

Thank you so much for the project review and feedback. I will work on the
professional coding practices you highlighted. kind regards
On Fri, Aug 19, 2022 at 10:24 PM Toma John Musa @.***>
wrote:

@.**** approved this pull request.
Hi @tonnymuchui https://github.com/tonnymuchui,
Your project is complete! There is nothing else to say other than... it's
time to merge it [image: :shipit:]
Congratulations! 🎉
Highlights

ALl linters passed
Correct use of Github flow

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this
PR. However, I strongly recommend you to take them into account as they can
make your code better. Some of them were simply missed by the previous
reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In index.html
https://github.com/tonnymuchui/Portfolio/pull/1#discussion_r950498909:

+

Portfolio

+
+

   My Logo

☰

I'm Tonny Glad to see you

[Optional] Please note that it is best practice and a convention to
use indentation of 2 spaces in all your documents. You can check here
https://github.com/microverseinc/curriculum-html-css/blob/main/articles/html_css_best_practices.md
for more details.
[Optional] It's better to follow commit message standards by making
them capitalized and in the imperative form (Example: 'Modify readme file'
instead of 'modified readme'). This way, your commit history will be more
readable and more professional ✨

In css/styles.css
https://github.com/tonnymuchui/Portfolio/pull/1#discussion_r950501344:

font-family: 'Poppins', sans-serif !important;

font-style: normal;

font-weight: 700;

font-size: 40px;

display: flex;

align-items: center;

color: #172b4d;

flex: none;

order: 0;

flex-grow: 0;

+}

+.content-text {

width: 300px;

height: 100px;

font-family: 'Poppins', sans-serif !important;

font-style: normal;

[Optional] Please note that it is best practice not to repeat multiple
!important properties in your CSS. Check here
https://github.com/microverseinc/curriculum-html-css/blob/main/articles/html_css_best_practices.md
for more details.
[Optional] Consider creating a class for the font family and assigning
the class to the HTML elements that requires it rather than repeatedly
using the class. This is best practice for DRY
https://en.wikipedia.org/wiki/Don't_repeat_yourself code.

—
Reply to this email directly, view it on GitHub
https://github.com/tonnymuchui/Portfolio/pull/1#pullrequestreview-1079269416,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJVSLTNG5G6DPFYGPPAA46TVZ7NOHANCNFSM566BSTOQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Various problem with the space elevator.

Minecraft Version:

1.12.2

Forge Version:

1.12.2-<IP_ADDRESS>64

Advanced Rocketry Version:

1.2.6-7 alpha

LibVulpes Version:

0.2.7-19 alpha

Explain issue in detail:

Texture problem on the block of the space elevator when the structure is finalized.
https://image.ibb.co/gCsyfR/2017_12_14_20_14_06.png

The elevator becomes invisible if a block is present in the center of the elevator structure.
I add that the grass of the mod Better Foliage passes through the texture of the structure.
https://image.ibb.co/cy0Un6/2017_12_14_20_14_31.png
https://image.ibb.co/cARr0R/2017_12_14_20_14_41.png

No collision on the roof of the lift cabin.
https://image.ibb.co/i1DbZm/2017_12_14_20_15_48.png

The elevator hides the texts that appear on the screen.
https://image.ibb.co/j8nW0R/2017_12_14_20_13_53.png

The energy column disappears when the player looks up from a certain height.
https://image.ibb.co/jKNyfR/2017_12_14_20_17_15.png
https://image.ibb.co/ee1fum/2017_12_14_20_17_17.png

And more:
after some use elevator just begin to kill player (when start - shaking screen and when enter into space station dimension - kill by "hit the ground")
Every time.

The first issue is a and issue with the model, will get around to fixing that eventually, though it's not a high prority since it's a render only bug.
The second issue is a duplicate of #938 and should be fixed with the space elevator in the next build
I'll look into seeing if i can add collision to the roof, though as it appears now it looks like enities can only have a single box for collision without some pretty deep edits to MC.  I was experimenting with it with rockets a while back, though implementation is rather difficult(couldn't figure out a way without messing around with the coremod mod) and the functionallity appears to break between MC versions.
The elevator hiding text looks like some kind of render order failure, though I wonder if the text also renders behind things like chests too.
The energy column disappearing unfortunatly is another thing that requires coremod modification since MC wont render chunks (or the entities in them) if you're too high up.  But since you're normally not that high up other than in a rocket or in a capsule, I don't think it's worth fixing due to the amount of effort involved.
@nonenothing can this be reliably replicated?  How many uses are required for this issue to occur?

How many uses are required for this issue to occur?
Not many - maybe 10 or so.
Here it is (mods, conf and saved world), see by yourself:
https://nofile.io/f/f8vN8DsECAo/minecraft.zip

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.


Update current-federal.csv

Hi @ian1193. We don't accept accept pull requests on current-full or current-federal.


setTextAppearance() deprecated API 23

Resolve #193

This was fixed by just using the setTextAppearance(context, textAppearance) version for all.


add: saurabh29r

Description
[Hi Please add my PR]
Changes Proposed
[Hi I have added my profile Saurabh29r. also add the label of hacktoberfest]
Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@saurabh29r Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!


sequence_entropy is tested using a dummy test

in test-scoring.coffee, test "sequence entropy", the test compares 2 exact same calls
t.equal scoring.sequence_entropy(match), scoring.sequence_entropy(match), msg

although it should test the result against the value in the array
t.equal scoring.sequence_entropy(match), entropy, msg

To note that this test is failing then

Thanks for catching, pushed a fix!


dependency on OptionalTypes makes pod install fail

I think that this pod relies on version 1.0.3 of OptionalTypes, which does not exists.
pod install
...
...
Installing OptionalTypes (1.0.3)
[!] Error installing OptionalTypes
[!] /usr/bin/git clone https://github.com/DragonCherry/OptionalTypes.git /var/folders/hg/bg6jpcrj6v521b55ygvb0hgh0000gn/T/d20170707-19716-howoxc --template= --single-branch --depth 1 --branch 1.0.3

I think you have to 'pod repo update' before 'pod update'. It should have install 1.0.4 version of OptionalTypes, not 1.0.3 which is not exists as the log says.


gdb: gdb runtime-gdb.py is broken

Reported by developer on IRC

lucky(~/src) % gdb ./addr
GNU gdb (GDB) 7.5
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>;
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-unknown-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>;...
Reading symbols from /home/dfc/src/addr...done.
(gdb) b main.main
Breakpoint 1 at 0x400c00: file /home/dfc/src/addr.go, line 9.
(gdb) r
Starting program: /home/dfc/src/addr
[New LWP 3980]
[Switching to LWP 3980]

Breakpoint 1, main.main () at /home/dfc/src/addr.go:9
9       func main() {
(gdb) goroutines
Undefined command: "goroutines".  Try "help".

What is the expected output? What do you see instead?

gdb integration should work

Please use labels and text to provide additional information.

Does anyone know what's currently going on with this?
I'm still experiencing this problem, and was wondering if I'm the only one and/or if there are any work arounds.
Alternatively, is there anything I can do to help?

Also, when I try to manually load it I get an error.
Loading Go Runtime support.
Traceback (most recent call last):
File "/usr/local/Cellar/go/1.4/libexec/src/runtime/runtime-gdb.py", line 27, in
goobjfile = gdb.current_objfile() or gdb.objfiles()[0]
IndexError: list index out of range


feat: price-feeder: telemetry additions

Description

Adds some measurements for Websocket reconnection attempts & candle / ticker messages being received
closes: #637

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added appropriate labels to the PR
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

@adamewozniak
The telemetry is going to increase the count when peggo uses the price-feeder?
If so, do you think we should differentiate the usage with an key?

What do you think about adding telemetry to subscribedPairs like:
       ....
       	p.setSubscribedPairs(cps...)
	telemetry.IncrCounter(
		float32(len(cps)),
		"websocket",
		"subscribe",
		"currency_pairs",
		"provider",
		config.ProviderBinance,
	)

@adamewozniak
The telemetry is going to increase the count when peggo uses the price-feeder? If so, do you think we should differentiate the usage with an key?

iirc it would only count if telemetry were enabled (e.g. if you called telemetry.New), so I don't really think we need a price.feeder key to differentiate, I don't think peggo has its own telemetry


standalone/io/directory_list_sync_test flaky fails on iso-stress buildbot

from builder logs

------------------------------------------------------------
[/b/s/w/ir/cache/builder/sdk/runtime/tests/concurrency/../../../tests/standalone_2/io/directory_list_sync_test.dart] error: [FileSystemException: Directory listing failed, path = './a' (OS Error: No such file or directory, errno = 2), #0      _Directory._fillWithDirectoryListing (dart:io-patch/directory_patch.dart:37:68)
#1      _Directory.listSync (dart:io/directory_impl.dart:243:5)
#2      testList (file:///b/s/w/ir/cache/builder/sdk/tests/standalone_2/io/directory_list_sync_test.dart:16:19)
#3      main (file:///b/s/w/ir/cache/builder/sdk/tests/standalone_2/io/directory_list_sync_test.dart:32:3)
#4      wrapper3165.<anonymous closure> (file:///b/s/w/ir/cache/builder/sdk/runtime/tests/concurrency/generated_stress_test.dart:41310:13)
#5      _rootRun (dart:async/zone.dart:1428:13)
#6      _CustomZone.run (dart:async/zone.dart:1328:19)
#7      _runZoned (dart:async/zone.dart:1863:10)
#8      runZoned (dart:async/zone.dart:1785:10)
#9      wrapper3165 (file:///b/s/w/ir/cache/builder/sdk/runtime/tests/concurrency/generated_stress_test.dart:41309:11)
#10     _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:286:17)
#11     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)
]
------------------------------------------------------------
-> Setting exitCode to 255```

the test will fail if there is a process that creates/deletes "a" folder in checked out sdk directory.
Would be nice to figure out who/what test does that.

file_fuzz_test is the test which created a file.

This failure still appears on iso-stress-linux bot:
Spawning tests in isolates resulted in the following errors:
------------------------------------------------------------
[/b/s/w/ir/cache/builder/sdk/runtime/tests/concurrency/../../../tests/standalone_2/io/directory_list_sync_test.dart] error: [FileSystemException: Directory listing failed, path = './a' (OS Error: No such file or directory, errno = 2), #0      _Directory._fillWithDirectoryListing (dart:io-patch/directory_patch.dart:37:68)
#1      _Directory.listSync (dart:io/directory_impl.dart:243:5)
#2      testList (file:///b/s/w/ir/cache/builder/sdk/tests/standalone_2/io/directory_list_sync_test.dart:16:19)
#3      main (file:///b/s/w/ir/cache/builder/sdk/tests/standalone_2/io/directory_list_sync_test.dart:32:3)
#4      wrapper3164.<anonymous closure> (file:///b/s/w/ir/cache/builder/sdk/runtime/tests/concurrency/generated_stress_test.dart:41297:13)
#5      _rootRun (dart:async/zone.dart:1428:13)
#6      _CustomZone.run (dart:async/zone.dart:1328:19)
#7      _runZoned (dart:async/zone.dart:1863:10)
#8      runZoned (dart:async/zone.dart:1785:10)
#9      wrapper3164 (file:///b/s/w/ir/cache/builder/sdk/runtime/tests/concurrency/generated_stress_test.dart:41296:11)
#10     _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:286:17)
#11     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)
]
------------------------------------------------------------
-> Setting exitCode to 255

Full log:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8839708239583306096/+/u/Run_Isolate_Stress_Tests_shard_2/task_stdout_stderr:_Run_Isolate_Stress_Tests_shard_2

Looks like we have same problem with tests/standalone[_2]/io/directory_fuzz_test.dart.


Try to migrate the github pages to markdown back again

We ave also HTMl here, which seems a little too much overhead and boilerplate code.
I think formerly it was based on markdown, but I think the markdown is gone.
We should migrate it back, so we can easily change the docs without the cumbersome HTML.
With Markdown we can focus on the content alone without its styling.

Migrated and part of v1.1.0


Normalize number of trailing newlines in markdown to 2

For output to look uniform with formatters like bat

Nice, thank you!


Eliminate the need for a format file

Currently luatex is invoked with a custom format ufy.fmt(source). This custom format is just a stripped version of the Plain TeX format file.
It is possible to eliminate the need for a format file, and just invoking the luatex binary with the --ini option. This has additional benefits of eliminating the need to install a TEXMF tree just to run LuaTeX.
Right now, invoking luatex with --ini is giving some really weird output. Refer to speedata Publisher code where this technique is used to get more insights.

This is partially done in e061918c8e4aaea3d63ee592c7348fd3ae65ac17
We no longer need a TEXMF tree around, because we disable the kpse initialization. We can load the format file from wherever we want.
Getting rid of the format file is much more difficult. The current format file (adapted from the Plain TeX format) does a lot of other things like setting up the proper metrics, page outputting etc. It will take a while before all that functionality can be replicated in Lua.

There is one more problem with the format file. It needs to be regenerated if we are using a different LuaTeX version.

This is almost done in 3b7e98f379556c74c80078091aba77a90b5ef88e. We still require a minimal format file to directly invoke the Lua file instead of having a TeX file wrapper around it.
Create #12 to tackle the problem of regenerating format file for newer versions of LuaTeX.


Wrong item icon: Dignified skull

A minor bug here: Dignified Skull has grey skull icon, while in the game it's red, like other drops from Tetsucabra.

This has been resolved and will be in the next database update. Thanks for your input!


ADD terminal (first draft)

cool!
A few comments about the ui (but that could be done in a subsequent PR)

we should use the same rendering as for the chrome devtool console
the horizontal drag bar is too large (that because of the collapse button). an idea: setting the bar height as minimun as possible and put the collapse button in the upper-right corner of the console.
when resizing, the drag bar takes the entire browser width...


Improve entity component cache speed

Store ID inside of render component to speed up memory access.

Improved inside mesh system. 825d4661c374a9bf8be51f9b841bc23e7281f0d9


Carrier Assets

Need to reprogram the scripts to supply the intended helicopters for the mission

Did you see I already did this and closed it straight away?


Words wrap by space

Hi myliang,
First of all, I would like to thank you for this project. It is really helpful and a great contribution.
There is an issue regarding the words wrap function. When you wrap words, the words are wrapped by the length of its cell at the moment no matter in the middle of the word. However, it would be great if texts could be wrapped in a way that every word is not separated as an example below:
example sentence "X Spread Sheet is great":
Currently:
X Spread She
et is great
What I would like to have:
X Spread
Sheet is great
Are there any ways to deal with this issue?
Thank you for your time!
Best regards
Naoto

you can read the method of text in draw.js


Suppress Spinner Text For Valid JSON output

When adding --json for JSON formatted output, the akamai.StartSpinner() outputs text that is not valid JSON.
This greatly diminishes the ability for other scripts and programs to leverage native JSON output without first storing it as a flat file with --output or having some additional parsing.
Example:
» akamai dns list-recordsets FQDN_TLD --json
Retrieving Recordsets List ... [OK]
Assembling Recordsets List ... [OK]

{
  "Recordsets": [
    {
      "name": "FQDN_TLD",
      "type": "A",
      "ttl": 600,
      "rdata": [
        "<IP_ADDRESS>"
      ]
    }
  ]
}

It would be nice to have a global flag or config option to supress the functions defined in: https://github.com/akamai/cli-common-golang/blob/master/spinner.go

I am happy to help make this change and work with Contributors on the implementation details.
I am also unsure if this would fit in with the main CLI, the shared common lib, or within this DNS package.

+1, please.
Generating json output and then having non-json output interspersed means I can't actually post-process the json data.
Maybe this sort of message should go to stderr, not stdout.


Run GitHub actions CI build on OSX

Could you please assign me those GitHub Actions issues? Just to be sure there won't be two of us working on the same thing. :-)

Sure thing!


feat: allow importing structures from a .csv files as admin (not manager)

:tada: This PR is included in version 1.59.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


editor issue in admin panel

hi. i'm using typemill for a small internal wiki.
i realized that there is an issue with the editor in the admin panel.
i wrote an article and saved it.

after a few changes in this article i can't see the editor in admin panel referred to this article.

but the tab with the meta-data correctly available.

if i'm opening the developer tools from chromium i get some errors:
vue.min.js?20201130:6 ReferenceError: ct is not defined     at wn.eval (eval at Ya (vue.min.js?20201130:6), <anonymous>:3:471)     at wn.e._render (vue.min.js?20201130:6)     at wn.r (vue.min.js?20201130:6)     at fn.get (vue.min.js?20201130:6)     at new fn (vue.min.js?20201130:6)     at vue.min.js?20201130:6     at wn.$mount (vue.min.js?20201130:6)     at wn.$mount (vue.min.js?20201130:6)     at wn.t._init (vue.min.js?20201130:6)     at new wn (vue.min.js?20201130:6) Ue @ vue.min.js?20201130:6 vue-blox.js?20201130:1924
Uncaught TypeError: Cannot read property 'parentNode' of null     at vue-blox.js?20201130:1924     at XMLHttpRequest.httpRequest.onreadystatechange (author.js?20201130:66) 6vue.min.js?20201130:6
ReferenceError: ct is not defined     at wn.eval (eval at Ya (vue.min.js?20201130:6), <anonymous>:3:471)     at wn.e._render (vue.min.js?20201130:6)     at wn.r (vue.min.js?20201130:6)     at fn.get (vue.min.js?20201130:6)     at fn.run (vue.min.js?20201130:6)     at un (vue.min.js?20201130:6)     at Array.<anonymous> (vue.min.js?20201130:6)     at qe (vue.min.js?20201130:6) Ue @ vue.min.js?20201130:6
DevTools failed to load SourceMap: Could not load content for http://<IP_ADDRESS>/wiki/system/author/js/vuedraggable.umd.min.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
DevTools failed to load SourceMap: Could not load content for http://<IP_ADDRESS>/wiki/system/author/js/axios.min.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
but the problem is, not all articles are effected, only this one.
is there a way to fix this error?

thank you for reporting and pretty strange bug, especially if it only happens on that page. The error message complaints about
var initialcontent = document.getElementById("initial-content");
initialcontent.parentNode.removeChild(initialcontent);

The element "initial-content" is part of the twig-template, so I don't see any reason why it does not find it here. I have to reproduce it somehow to fix, so can you send me the content file for that page? Do you use any plugin or any additional code on that page?
Thank you

Hi.
Sorry for the delay.
I'm using the following plugins: ebooks, highlight, search and thesarus.
The error is still there when all plugins are disabled.
Here's the content of the file:

discard-trim

if the proxmox host is installed on solid state storage make sure to enable 'trim / discard' service.

systemctl enable --now fstrim.timer

this will enable the discard service and also starts the service immediately.
when vm's are installed on a solid state storage enable also the fstrim.timer service.

systemctl enable --now fstrim.timer

to trim all containers use the following dirty one liner in the shell of the host.

pct list | awk '/^[0-9]/ {print $1}' | while read ct; do pct fstrim ${ct}; done

sorry for the late answer, I just had the time to test it and I get the same error.
The problem is that the syntax ${ ... } is defined as the delimiter for the vue-app, because the default vue delimiters clash with the twig-syntax (see https://vuejs.org/v2/api/#delimiters). I don*t have a quick solution for it right now and can't offer a solution with version 1.4.3 because it will be published tomorrow. But I will think about a solution for the 1.4.4 release.

sorry for the late answer, I just had the time to test it and I get the same error.
The problem is that the syntax ${ ... } is defined as the delimiter for the vue-app, because the default vue delimiters clash with the twig-syntax (see https://vuejs.org/v2/api/#delimiters). I don*t have a quick solution for it right now and can't offer a solution with version 1.4.3 because it will be published tomorrow. But I will think about a solution for the 1.4.4 release.

Hi.
Are there any news about the bug in typemill?
It would be nice if you have a solution...

I did not had the time to find a fix for this, but will look into this issue for the next release.
Just for me as a reminder:

https://github.com/vuejs/vue/issues/4223
https://vuejs.org/v2/api/#v-pre

fixed it for release 1.4.6 (simple v-pre tag on the initially loaded content). I will publish the release end of May latest.

If that bug is critical for your work, then you can fix it directly in your code or use the develop branch that I just updated. I do not know when I find the time to finish the next release. The fix is pretty trivial, just a v-pre tag in one template, it prevents vue from rendering the initial content: https://github.com/typemill/typemill/blob/develop/system/author/editor/editor-blox.twig
<div id="initial-content" v-pre>

published today with 1.4.6

Thanks. Works fine and for now inside the package.


ci: test

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.523%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
1246

Relevant Lines:
1539

💛  - Coveralls


Docker installation / Docker with nginx as a reverse proxy

Would be nice to have the Docker installation as a method in the Docs or do you don't want this @Unknwon ?
I will start writing this in the next days (English and German version) if someone did it not faster than me and if you think that would be useful ;)
Suggested topics:

[ ]  Docker pull / run / portforwarding as described [here] (https://github.com/gogits/gogs/tree/master/docker)
[ ] getting a TLS-certificate via Let's Encrypt
[ ] Setting up nginx as a reverse proxy to deliver the gogs installation with the TLS cert.

Just saw that there are enought tutorials / descriptions linked in the offical gogs repo.
Maybe linking in the docs is enough. Just closed this.


Update maintainers and trainees

List accurate as of Oct 2024

I think I have (it is in the MAINTAINERS file) but it does not appear in the generated page. Don't know why...

I think I have (it is in the MAINTAINERS file) but it does not appear in the generated page. Don't know why...

Yes, I don't see Marc in the all contributors list, seems like we never added him in the first place. Happy to request all contributor bot to add Marc and then Manually generate teams again.

Here - https://github.com/pybamm-team/PyBaMM/pull/4505, feel free to press the button.

It said it still needed a review. Can you approve again, @arjxn-py? Feel free to merge afterwards, I need to go now.


Add release plan date? at least indication (In github)

Hi would it be an option to add a planned release date for the upcoming releases?
(helps us plan a little)

Hi Sean,
This is not always possible. I updated it now because we are going to do the release end of the week.
Regards,
Rik
Adyen


Xamarin.Auth is made for PCL not .NET and throws errors

Is there going to be an update to Xamarin.Auth and Xamarin.Auth.XamarinForms that includes more support for .NET standard 2.0? The dependencies that are included in these do not use package references and the standard Xamarin.Forms project does not create a packages.config.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aa8bb9e0-5898-0d11-0213-fd4d8c8d0297
Version Independent ID: 2f46e1f7-164f-2f32-70c0-f28919d16c5c
Content: Authenticating Users with an Identity Provider - Xamarin
Content Source: docs/xamarin-forms/data-cloud/authentication/oauth.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

I'm in the process of updating our Azure Active Directory B2C authentication sample and docs. This is not exactly what you're looking for but may be helpful, or even an effective alternative as it allows using third-party identity providers. It uses a shared .NET Standard library and the Microsoft Authentication Library (MSAL) Nuget package.
When I finish the doc updates it should offer a better end-to-end explanation. For now, the updated sample project is on a branch here:
https://github.com/xamarin/xamarin-forms-samples/tree/jusjohns-auth-b2c-overhaul/WebServices/AzureADB2CAuth

Thanks for the question @rdurrance.
The AD B2C changes mentioned above are now published (along with updated sample).
For questions specific to the Xamarin.Auth implementation, visit the open source GitHub page where you can see the current work in progress.


[question] Example with using builder explicitly

Hey,
I am looking for an example where we have used the builder explicitly to create the JWT token.  I tried with
auto builder = jwt::create();

but I am getting templating issues. Do you have any example?
Thanks

https://github.com/Thalhammer/jwt-cpp/blob/master/example/rsa-create.cpp
Contains an example on how to use the builder. Or do you mean storing the builder and building in multiple steps ?

Yes, I want to create the token in multiple steps using a builder.

I believe it should be jwt::builder<jwt::picojson_traits> local_build;
We had similar question about the verifier https://github.com/Thalhammer/jwt-cpp/issues/130.
If we did not understand your question, please provide a small code sample + the build logs so we can help resolve the compilation issues.

For my reference this line does the magic
https://github.com/Thalhammer/jwt-cpp/blob/55aaf31ad852e0b4666b2daf6b8b9e2e68b6c04a/include/jwt-cpp/jwt.h#L3598

Closing this question as "resolved" if you still have problem feel free to reopen the issue.

Hey - can you please provide an example again how to use the builder explicitly as you did in the example you provided above. With the recent changes, I am getting an error about adding the default_clock and can't get it to work.

https://github.com/Thalhammer/jwt-cpp/blob/364a5572f4b46bb9f4304cb1c92acec8ddb2c620/include/jwt-cpp/traits/kazuho-picojson/defaults.h#L27
There a defaults provide as reference. Hopefully that helps


Fixed compiler issues on Windows

Still does not fix the usage of audio on Windows, just
handles the compilation.
Fixes #140.

Not that much to review. It fixes compilation issues on Windows.
It may expose some runtime issues, but that's OK -- this is only intended to fix the compilation issues.
Ready to merge when you want to @paked.


Root schema is missing items field

I recently was playing with some jsonschema using the latest ansible.json file and noticed that validation wasn't occuring properly. Inspecting the schema I noticed the lack of root items. I believe this PR was improperly made https://github.com/ansible/schemas/pull/230 and should be reverted.
I've added a few pics of some testing I did in https://www.jsonschemavalidator.net/
Test with old schema

Test with new schema

Not having items is perfectly valid and current version of the schema does pass  https://www.jsonschemavalidator.net/ tests. In fact we do have two schema validators as part of our CI integration so I think that the chance of merging a broken schema is quite low.

Okay. Thanks @ssbarnea for looking at it. I'll just maintain a fork for my purposes.


Create uk_ua.json

Hi there!
Lootr has recently moved to CrowdIn for translations: https://crowdin.com/project/lootr
If you have an active CrowdIn account and you wish credit, please feel free to contribute there. Otherwise, I will include your suggestions if there is no response to this after a few weeks.


Worker pods run in privileged mode

What happened?:
Worker pods run with privileged: true
What you expected to happen?:
Worker pods do not run in privileged mode. This is not suitable for our shared tenant cluster.
Anything else we need to know?:
Workers require privileged mode because they run syscall.Mount, which requires privilege.
I don't know if other areas require privilege. This usage looks like it could be replaced by a symbolic link.
This is related to #2813 .
Environment?:

Pachyderm CLI version (use pachctl version):
COMPONENT           VERSION
pachctl             1.7.3
pachd               1.7.3

@jdoliner didn't we removed the need for privileged here: https://github.com/pachyderm/pachyderm/pull/2887?
I guess not for worker pods?

@jkinkead this unfortunately isn't easily replaced with a symlink. That's actually how the behavior used to be implemented, but we found that with some container images the symlink would silently fail and show up as an empty directory. Switching was the only way we could find to implement it that worked with all containers.
@JoeyZwicker yeah, that was only for pachd.

Did you figure out a set of conditions under which symlinks would fail?
Would it make sense to make this a pipeline option (noprivileged flag or similar)?

Any update on this?

Small update on this, I think we have found a path forward on this that will allow us to use symlinks. I'm not sure if we'll be able to land the fix before the 1.8 release but it should come out in a 1.8.x release or 1.9 at the latest.
Thanks for bearing with us.

Pachyderm workers have checked their privilege.


Covers npm linked modules.

If I use npm link and then run a test suite using NYC, the linked module ends up generating coverage info. I'm guessing because there is no node_modules folder in the parent path for linked modules (at least when using nvm).

Could maybe exclude paths that go above the current directory?

I've noticed this too. I npm link a lot and it really makes for a noisy coverage output.

#160 should resolve this.

@jamestalmage @sindresorhus give this a shot:
npm i nyc@next
If it does the trick I'll publish 5.6.0 to latest sometime tomorrow.


Options can sometimes be booleans

Browserify allows some options, like noParse to be booleans. This patch makes sure that if you pass a boolean option, it isn't wrapped in an array (which would make no sense anyway).
Fixes #69

Would you like to be added as a collaborator on this project, to help review and merge pull requests?

Sure. Happy to help.

Cool, you're added.  Please follow these rules:

never commit directly to master unless you're only editing documentation, or you're in the process of cutting a new release.
never merge your own pull request unless it's had no comments from any collaborators for at least 24 hours.
If you cut a new release, make sure you update History.md and follow semver when updating the version number.

If you let me know your npm username I'll add you as an owner so you can release new versions :)


Id selector not working when combined with a tag selector

I've been trying to get the following unit test code to work:
const component = React.createElement(MyComponent, { });
const wrapper = shallow(component);
expect(wrapper.find('input#myid').length).to.equal(1);

But the find method is not finding anything. It is able to find the input box just fine with input as the selector and with #myid as the selector, but not when I specify both.
I'm using Enzyme v2.2.0.

FWIW, using id's is an anti-pattern in react since it breaks re-usability with w3c DOM validation.
That said, this does appear to a be a bug.
cc @lelandrichardson

Thanks @blainekasten.

The fix is merged two months ago, can it be closed?

@havenchyk yupp, thanks!

@Aweary this caused a regression. It broke attribute selectors with values containing #, ex a[href='/page#anchor']`.


Add architecture to manifest.json

Describe your changes
Update of build.sh to add architecture to manifest.json before ACAP build.
ACAP Portal requires  architecture to be listed to do signing.
Checklist before requesting a review

[X] I have performed a self-review of my own code
[X] I have verified that the code builds perfectly fine on my local system
[ ] I have added tests that prove my fix is effective or that my feature works
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have verified that my code follows the style already available in the repository
[ ] I have made corresponding changes to the documentation

architecture is added during build as expected - no need to add explicitly


DSA_Array

This contains information regarding the array.

kiNDLY MERGE THEM!
https://github.com/rahulatrkm/ds_and_algo/pull/88
On Mon, Oct 17, 2022 at 6:47 AM Rahul @.***> wrote:

Merged #73 https://github.com/rahulatrkm/ds_and_algo/pull/73 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/rahulatrkm/ds_and_algo/pull/73#event-7597413067, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AXOHT4MELBIDNCWASBI5YADWDSSKVANCNFSM6AAAAAARGIWMTE
.
You are receiving this because you authored the thread.Message ID:
@.***>


docs: added .gitignore of .idea/ directories

Insignificant change to additionally ignore IntelliJ/Webstorm project information.
Does not change anything functionally in any code, just nicer for people like me
who develop JavaScript in WebStorm.

:tada: This PR is included in version 0.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Uncomplete Developer Guide Update

Uncomplete due to time constraints

This should be for v1.2 but it gives me Travis line ending errors so I will not merge this.
It would be great if this could still be marked for v1.2 though @lestertj
As I'll explain in our tutorial, my laptop is currently being repaired and so I can't make the necessary line ending correction on this computer since it does not have Intellij.


Release testing: ponyc installation fails  for "from source" on Bionic

Running the following command:
sudo apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys "E04F0923 B3B48BDA"

Gets the following output:
gpg: "E04F0923 B3B48BDA" not a key ID: skipping

Which then causes the ponyc install to fail.
Release issue: #2359

tested and confirmed to now work


Add ts support in amagaki projects

support correct ts loading
minimization on npm run build
support for live reloading

Is this ready to go? If so I think it will fix https://github.com/blinkkcode/amagaki-starter/issues/2

Hey Jeremy, - It's working but the live reload is delayed by about one or two seconds (minor issue).

Pulled this in from your work on another project; closing this PR


Up the amount of training worker threads with Rdf2Vec

I'm trying to index my KG with about 2M triples using https://github.com/epoz/shmarql that uses fizzysearch.rdf2vec. It isn't very fast though and CPU utilization is about 10%.
Upping the amount of training workers, e.g. with multiprocessing.cpu_count() might help. That would, on my machine, bring the workers up from four to fourteen. As an alternative solution, it appears not to be possible to (easily) use the GPU with Word2Vec.
I'm unsure how to time any performance gain, but at least the test suite results don't change.

Wow, that is an elegant improvement.
I was not aware that was an option in gensim Word2Vec.
There is also still a big gap in doing the random walks, they are also still single-threeded. Is on my todo list to fix that too.
But fab to see this on the training side too.


feat: yield notifications for consumption

Allow composing notification UI in consuming application.
{{#notification-container as |container|}}
  {{#each container.notifications as |notification|}}
    {{notification.message}}
  {{/each}}
{{/notification-container}}

This will help somewhat with #43.
We should look to improve the API of the component class to expose the properties passed when calling the service.
{
  autoClear: false
  clearDuration:2800
  cssClasses:"profile-saved-success-notification"
  htmlContent:false
  message:"Notification message"
  onClick:undefined
  type: "success"
}


Update license for 2019

Minor change that updates the license to 2019.

closing, as by the time I got round to this PR, it was hilariously out of date 😅
thanks for the contribution regardless @lare96


⚠ Bofrost.be has degraded performance

In 95e1ef2, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1070 ms

Resolved: Bofrost.be performance has improved in 4f9d936.


data-bind:list not working with bindData

It's possible to use bindList when explicitly binding a list, but an empty list is bound when the data object contains iterable data of the matching key to the data-bind:list bind key.

Before closing, it would be good to link the unit test here, as this latest merge is becoming a bit confusing :S


security -change availability of assigned land

Added give  land access to security when tap the toggle button and delete assigned security