cannot rename TAP device to outline-tap0, and need for administrator permissions

I failed to install Outline Client on every version after 1.1.2, when it began to use TAP device instead of a global proxy in Windows 10. The reason seemed to be simple: the installer cannot rename the install TAP device ("Ethernet 5, 6, 7...") to "outline-tap0", due to a duplicated name existed on my PC or network. This issue caused an error message in installation saying that the TAP device cannot be installed on my PC, as long time ago it failed to install or rename with non-lartin names.
The problem is that there was not a TAP device with this name. I've tried out every method I can find on Internet, here or at other place. I've checked the registry with "outline-tap0" and the GUIDs to find out any possible conflicting names, but there was none. Manually editing and running add_tap_device.bat managed to create TAP devices with any name ("outline-tap1,2,3...") but still failed to create, rename or configure an existing "ouline-tap0" device. Same error as the netsh set interface name cmd ran.
Funny thing is that, I managed to "rename" the wrongly installed TAP device in registry key \HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Network{4D36E972-E325-11CE-BFC1-08002BE10318}[InstalledNetAdapterGUID]\name to "outline-tap0", so that the device was displayed as "outline-tap0" in Control Panel (ncpa.cpl), but only displayed---when checking NetConnnectionID by netsh interface show interface, the ID was still "Ethernet x", not "outline-tap0". Looks like the name was a ghost in my PC.
Things went wired when I found that, desipte the name was only displayed as "outline-tap0", this TAP device actually could work normally. Igoring the error message in installation, and running the client, it told that it needed administrator permissions to run (sure thing I ran it with admin permission), and the status showed that the client did not connect to the server. However, I could use it by setting the proxy server to <IP_ADDRESS>:1081 in Chrome, which was the listening address:port for the client before 1.1.2 version. It worked pretty well. During its try to connect, I noticed that the TAP device status changed (from "net cable unplugged" to "identifying"), but I didnt even configure its gateway/dns/subnet mask (the key values were all lack in regirstry, neither did I use netsh to set them). However, if I click the connect again, the connection lost, and the device status dropped to cable unplugged again. Also, the client could not exit normally, but continuously try to connect. I had to kill its process each time.
I even tried to build the client from source could myself. The electron.exe told me that the failed permission request happend when it tried to (re)install the route table.
In summary I guess there were 2 bugs here: a ghost name "outline-tap0" in my PC, and a failed admin permission request. As I read out the issues here without finding a similar one, and old version 1.1.2 client is still working fine, I don't quite expect a quick fix on these bug. Somehow they could just be the problems somewhere in my PC, because the new client can install and work normally in my testing VMware virtual win10 system, with same COMODO anti-virus software. But I am still looking forward to a possible fix, or maybe an alternative option in the client to change its corresponding TAP device name something else than "outline-tap0" so that it could run normally. I still worrying about the algorithm evolution of shadowsocks or the change of server protocol so that ver. 1.1.2 will no longer available in future.

I am having exactly the same issue. It seems like i also have a ghost "outline-tap0" but i am not able to find and delete it. Even though i found the GUID for outline-tap0 in regedit and deleted it there it still says that i can not rename existing taps with default naming to "outline-tap0" because it aldready exists.

I am having exactly the same issue. It seems like i also have a ghost "outline-tap0" but i am not able to find and delete it. Even though i found the GUID for outline-tap0 in regedit and deleted it there it still says that i can not rename existing taps with default naming to "outline-tap0" because it aldready exists.

Kind of comfort to know I'm not the only one to suffer from this lol.  I've been using ver 1.1.2 till now for a passable solution. Actually ver 1.1.2 provides an unexpected advantage that I can manually shut down system proxy in Windows, so that only in chromium browsers with switchyomega extension the traffic goes through outline client, and Windows system updates and other apps go bypass.
Yet, I found encryption algorithm of ver 1.1.2 may have been identified by GFW. Connection to a specific DigitalOcean server will be interfered as long as I go YTB and see some sensitive information. I have to destroy the original droplet and create a new one to reconnect (to change the server ip address).
My best guess is that, though GFW cannot actually know what the encrypted data is in your traffic, machine learning algorithm may make it possible to detect that the data is going to the forbidden websites.
I am really bothered because without compatibility to update Outline client, I cannot utilize novel encryption to avoid GFW detection. But to be honest I like the proxy method provided by 1.1.2, rather than a global VPN-like tap device adapter.

Same issue

Closing as duplicate feature request of #1007


0.26 regression: touch events are lost when the component under the finger goes away

I have an app I'm working on that involves dragging UI components around, and when I upgraded to React Native 0.26.3 and React 15.0.2, dragging stopped working.
The interesting thing about my app is that the component directly under the finger is removed from the view hierarchy while dragging. (In its place, I draw a similar-looking component elsewhere in the view hierarchy that follows the finger.) But I'm handling all touch events through a top-level component that is mounted for the duration of the gesture, so I would expect to receive all touch events.
I think I tracked the problem down to this commit (although I'm not sure about the implications of just reverting it): https://github.com/facebook/react/commit/69b6869a3e6861b325ca2e9bb2d938cb81c7a090
Here's a small sample app demonstrating the problem on both Android and iOS:
https://github.com/alangpierce/DragBugDemo/blob/master/app.js
Here's the correct behavior on React Native 0.25.1 and React 0.14.5 (at least, I think it's correct):

And here's the incorrect behavior on React Native 0.26.3 and React 15.0.2:

I intentionally give the dragging and notdragging components different keys so that the notdragging component is removed from the view hierarchy while dragging. In the 0.26.3 version, all touch events after the first are lost for gestures that start with the finger over the notdragging component (even though that component doesn't handle any touch events itself).

same issue :cry:
I downgraded RN version to 0.25.1 too.

@sebmarkbage sounds like that commit introduced a regression and we want to continue to send touch events to JS even if the original target component was unmounted.

Ah yes. Known issue. It's not actually that commit. That commit just fixed an error firing when this happens. The original commit causing this regression is much more significant and is important memory usage and architectural wins. We can't revert that one.
We probably should've published this more visible in open source. Sorry about that. :(
I believe that the semantics that we discussed is that we don't actually want to keep firing touchmove events in that case. That's also consistent with iOS. However, we do want to keep firing responder events which seems to be the issue here. If the current responder is removed from the tree, it should release to the nearest parent responder that accepts it. I forget what the proposed implementation details were.
@spicyj Do we have a GitHub issue tracking the bigger issue or just internally? We should at least document proposed solution or just fix it.

At the very least we should let the ResponderEventPlugin handle events in the bail out case somehow:
https://github.com/facebook/react/blob/master/src/renderers/native/ReactNativeEventEmitter.js#L127
We won't know what the target is though. So that will have to be null.
The second issue is doing something when the target of a touch gets removed to hand over the current responder before it is too late. We had a clever idea but I don't seem to find the notes right now.

I don't think we have any GitHub issue tracking it. The notes I have internally are:

Currently if you touch down on a node, then remove that node, the touch is lost and there's no way to receive touchmove events for it. Instead, the responder should transfer upwards (when there's a willing recipient ancestor) when the inner view is removed.
On web with mouse events, the mousemove event is always sent to the element under the cursor's current position so this isn't an issue.
On web with touch events, the touchmove event gets sent to the detached node but does not bubble through the document (and currently, React DOM doesn't see the event at all). Andy M says this seems like a bad idea.
On iOS, touch events disappear when a view is removed (even if your touchesBegan:/touchesMoved: handlers are on an outer view) – but when using a gesture recognizer on the outer view, the movements continue to be delivered.

I think this should be possible if we always store the parent path of the current responder.

I’m encountering a similar issue as @alangpierce. I have a view (a “card”) that is openable onPress, and draggable onLongPress. To drag the card component I create a clone of it that I render in an absolutely positioned view that follows the finger. This clone dragging is working as expected, the problem being that the user has to stop his original touch (the long press) and touch again to move the cloned card. My actual use case is described in more details in http://stackoverflow.com/questions/38198690/react-native-change-responder-dynamically.
So basically I’m looking for a way to transfer the responder from the original card to the newly created clone in the absolute positioned view. Since onResponderMove events aren’t called anymore on the clone, I have no point of entry to initiate the responder transfer.
The idea to transfer the responder when the original view is destroyed could fix the problem, but its assuming that we only want to transfer the responder when the original view is destroyed. In my case I could keep the original card in the view while still wanting to transfer responder to some other dragging view after a long press.
I’m not sure what additional API is needed to solve this use case, one possibility would be to have an imperative method terminateResponder, that I would in my example call after a long press. The new responder would then be delegated to a view accepting it with onStartShouldSetResponder basically creating a new touch event even if the user finger hasn’t move away from the screen. This terminateResponder method could also be called when the view is destroyed.
Another possibility would be to have an API to request responder responsibility outside of the existing on{Start,Move}ShouldSetResponder callbacks. In my example it would be used when the cloned card is rendered to indicates that it now wants to be the one handling touch events. Either way I think there need to be an imperative API to initiate the transfer on some event.

To be clear, in the example I linked, and in the app I'm working on, the responder (the node that returned true to onStartShouldSetResponder) is mounted for the duration of the gesture, but the touch events are still lost. The problem happens when the node under the finger at the start of the gesture (which doesn't interact with the responder system at all, at least not in application code) is removed. (I'm not sure if the term "responder" used in a few places above is the application-level responder or something implementation-specific that could be different.)
In my case, I don't need an API to transfer the responder to another node. I've already structured my code so there is a top-level responder controlling everything, and I just want it to keep getting events.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/026-regression-touch-events-are-lost-when-the-component-under-the-finger-goes-away
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.

I faced with this problem and tried on RN 0.43.0 and above.
And after overall trying - Good news, It works on RN 0.44.0


Npm task argument is wrong

In the npm (in docs) documentation it describes the argument customRegistries which should be customRegistry as shown in the  YAML snippet section.
I'm only using it as a custom command so I can't speak for the other use cases but I assume it's also wrong there.
The customFeed argument should probably also be described when customRegistry is set to useFeed. I discovered it need to use the format project/feed when the artifact feed is scoped to your project.

@kitzin Thanks for your feedback! I'm updating the task shortly.


CI: Add a test job for Cygwin

I'm not a Cygwin developer, but since the MSYS2 patches are touching Cygwin code paths this could be helpful in preventing regressions in that area.
Example run on my fork: https://github.com/lazka/distutils/runs/4569103775?check_suite_focus=true

This looks great. I wanted to take the opportunity here to notice that there was some redundancy across the two identified test modules and to consolidate that behavior, so I've done that in 1d98a15. It's entirely an iteration on your work and not a criticism.

A bit of context: I'm not quite sure why the test try to set root uid/gid... maybe just because they are available and not the current user? I tried something similar by using the "Adminstrator" account and "Administrators" group on Windows first, which Windows is supposed to have by default, bot for some reason the GHA image is missing the former.

Thanks!


deepin.dde-daemon: do not create /usr/share/uadp

fix: https://github.com/NixOS/nixpkgs/issues/314108
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg test deepin

@ofborg test deepin


ESLint server shut down itself

I started getting this error today out of the blue.
"ESLint server shut down itself. See 'ESLint' output channel for details."
attached is my config: (Haven't touched it since I installed the extention... I actually just found where it was)
eslintrc.txt
Any ideas what may be causing this?

One of the plugins calls process.exit() which make the ESLint process exit. If you can provide me with the repository that shows the behavior I can look which plugin causes this.

I also encountered the same problem, according to my test, every time I use import to select the path will cause Eslint sever shut down.
plugin list : https://gist.github.com/qzdFront/9bfa512e331bf1e31494f10a1a567dc1

@qzdFront can you provide me with a GitHub repository I can clone that repros what you are seeing.

Sorry, can't give you the repo, since it's private. This is the output the console is trhowing:
[Info  - 11:29:27 AM] ESLint server stopped. [Info  - 11:29:27 AM] ESLint server running in node v10.2.0 [Info  - 11:29:27 AM] ESLint server is running. [Info  - 11:29:28 AM] ESLint library loaded from: /Users/gonxas/Projects/iOS/DigitalClipboard/DC/node_modules/eslint/lib/api.js cosmiconfig requires at least version 4 of Node, please upgrade [Error - 11:29:29 AM] Server process exited with code undefined. This usually indicates a misconfigured ESLint setup. [Error - 11:29:30 AM] Connection to server got closed. Server will not be restarted. [Info  - 11:29:30 AM] ESLint server stopped.
Attached my configuration file
versions:
`pc33:DC gonxas$ node -v
v9.11.1
pc33:DC gonxas$ npm -v
5.6.0
eslintrc.zip
`

@gonxas thanks. Unfortunatelly the eslintrc file doesn't provide enough information to understand what is happening.
Can you run eslint from a terminal and see if there is any additional information written to the console?

Hey @dbaeumer. Sorry for the delay, I've been on vacations.
Can you tell me how to run eslint from a terminal please? I've been only using it on Visual Studio Code
Thanks

@gonxas with ESLint both the npm eslint package and all plugins must either be install all globally or all locally. You can't mix the installation scope.

@dbaeumer shouldn't those lines have installed everything globaly?

@dbaeumer I just saw a found log of messages on Visual Studio Code:

[Info  - 10:35:36 AM] ESLint server stopped.
[Info  - 10:35:36 AM] ESLint server running in node v10.2.0
[Info  - 10:35:36 AM] ESLint server is running.
[Info  - 10:35:39 AM] ESLint library loaded from: /Users/gonxas/Projects/iOS/DigitalClipboard/DC/node_modules/eslint/lib/api.js
cosmiconfig requires at least version 4 of Node, please upgrade
[Error - 10:35:42 AM] Server process exited with code undefined. This usually indicates a misconfigured ESLint setup.
[Error - 10:35:43 AM] Connection to server got closed. Server will not be restarted.
[Info  - 10:35:43 AM] ESLint server stopped.

does this gives a bit more of information?

npm i -g eslint installs eslint globally, whereas npm i eslint-plugin-prettier@latest --save-dev installs the plugin locally.
The server shuts down because of this
/Users/gonxas/Projects/iOS/DigitalClipboard/DC/node_modules/eslint/lib/api.js
cosmiconfig requires at least version 4 of Node, please upgrade

Do you have eslint.runtime configured ?

I'm not sure... Searching I found and follow this: https://github.com/runtimejs/eslint-config-runtime
I added edited this line in the config file I uploaded earlier:
"extends": ["eslint:recommended", "plugin:react/recommended", "runtime"],
but nothing happened.

hey @dbaeumer any ideas what may be happening here?

No, since I can't reproduce this (at least not exactly what you are seeing). What happens if you execute eslint directly from the terminal?


Renamed --ponythreads to ponymaxthreads, fixes #3318

I think fixes #3318
But this also means specifying --ponythreads would be silently ignored:
./helloworld --ponythreads=1
Hello, world.
$ ./helloworld --ponythreads=0
Hello, world.
$ ./helloworld --ponymaxthreads=1
Hello, world.
$ ./helloworld --ponymaxthreads=0
--ponymaxthreads can't be less than 1

Should we alias the two? Forbid --ponythreads as an option? Maybe make sure the --pony* "namespace" only contains "known" options? … thinking out loud

If we go for the "namespace concept" should it be more "explicit", e.g. XML like --pony:maxthreads or something? (still thinking out loud)

@alexsnaps re: namespacing. that needs an RFC.

--ponythreads shouldn't be aliased. it dies with this change.

I think it might make sense… But could also be a drastic approach to simply "aliasing" or slowly deprecating; e.g. alias first, then print something to stderr, err out and finally go back to this behavior… I'll think it over and might indeed open an RFC. Will refresh my mind again on how other runtime do it…

We are pre-1.0. Deprecating isn't needed.

--ponythreads shouldn't be aliased. it dies with this change.

If we're all good with this… sure. Don't get me wrong, I'm not against merging it this way (if this PR is all good with reviewers), just thought I'd explicitly mention it

We are pre-1.0. Deprecating isn't needed.

Makes sense!

In any case, this will require https://github.com/ponylang/ponylang-website changes again too.

@alexsnaps yup. website will need to be updated. good catch. i had forgotten about that, because i am the great forgetter today.

Thanks @alexsnaps. Can you add release notes to the release issue?

Can you add release notes to the release issue?

Adding them now… will also open a PR against the website repo. Probably only later today (🤞) tho.


Add purl information to SPDX reports when available

A purl is a URL string used to identify and locate a software package in a mostly universal and uniform way across programing languages, package managers, packaging conventions, tools, APIs and databases.
Tern's SPDX documents are more consumable and interoperable with other tooling if purls are available for the packages.
SPDX supports the inclusion of purls as a PACKAGE-MANAGER category of ExternalReference for a package. See https://spdx.github.io/spdx-spec/v2.3/package-information/#721-external-reference-field and https://spdx.github.io/spdx-spec/v2.3/external-repository-identifiers/#f35-purl.

I'd like to work on this.


Please  support  plugin ansiColor

Plugin Name
ansiColor
Plugin Url
https://plugins.jenkins.io/ansicolor/
Reasons support
Provide terminal display in different colors. In the face of log troubleshooting, it is very helpful

/retitle Request to support Jenkins ANSI Color Plugin

I guess you try to check the log output from Jenkins. But We don't intend to let users use Jenkins console directly. Jenkins is just a backend of the CI engine.
If you wish have a better color scheme of the Pipeline log output. Please file an issue in project kubesphere/console.
Any way. Thanks for reaching to us.
/close


update record on zenodo.org

just noticed (while checking on something else) that there was no repo dump of Somesy to Zenodo since v0.3.1 in January. Since two more releases and its v0.4.1 maybe you could update the record at some point.
Low priority, just noticed and had to write down somewhere...

I logged in to Zenodo and reactivated somesy integration. Including version 0.4.2, releases are automatically uploaded to zenodo again.

@hofmannv i checked it with new v0.4.3, it is uploaded, so i am closing this issue


Dutch localization

Category
[x] Enhancement
[ ] Bug
[ ] Question
Add Dutch localization labels

This is now available in version 1.10.0.


Branching iModels with the transformation API doc article

Branching iModels with the transformation API doc article
added a code conflict to existing branch iModel synchronization test to encode how it is handled
minor fix an improperly cased bwc svg image reference which breaks doc generation on linux

@williamkbentley when I run the documentation generation locally, I can't search for my newly added article, is there something I'm missing? Or is indexing the site not how I expect it or not generated in the simple build step I'm using?

Though, I haven't tested the references (not sure what's the procedure for that, probably to build the docs locally?).

@abruzas the iTwin.js Docs above succeeding means no (internal) links are broken. To build it anyway, you can do the following:
npx -p @bentley/bemetalsmith-cli buildDocSite core --noBuild

and wait a long time :). Also that package is private so you'll need an authorized .npmrc
Since search won't work for this page yet, I recommend going to the iModel Transform ETL page which has a link to one. I'll edit this message to have the URL here when I have it handy

@MichaelBelousov does this PR potentially address #2349?

@MichaelBelousov does this PR potentially address #2349?

Yes it does.

Please consider moving your example code to example-code-snippets to ensure it compiles now and in the future.

@pmconne I have created some code snippets in a new test file with the transformer package's tests:
https://github.com/iTwin/itwinjs-core/blob/faad9e7a624f5ce3f161d9188c3826e28a44b72f/core/transformer/src/test/standalone/IModelBranchingOperations.test.ts


How to deal with "Evaluation timed out" problem?

If my source too big, how can I still show the ANTLR4 Parse Tree Visualizer?

   at Microsoft.VisualStudio.DebuggerVisualizers.Impl.VisualizerObjectProvider.TransferDataToDebuggeeSideVisualizer(Stream outgoingData)
   at Microsoft.VisualStudio.DebuggerVisualizers.Impl.VisualizerObjectProvider.Microsoft.VisualStudio.DebuggerVisualizers.IVisualizerObjectProvider.TransferObject(Object outgoingObject)
   at Periscope.VisualizerWindowBase`2.initialize(IVisualizerObjectProvider objectProvider, TConfig config, ConfigDiffStates configDiffState)
   at Periscope.VisualizerWindowBase`2.Initialize(IVisualizerObjectProvider objectProvider, TConfig config)
   at Periscope.VisualizerBase`2.Show(IDialogVisualizerService windowService, IVisualizerObjectProvider objectProvider)
   at ClrCustomVisualizerVSHost.ClrCustomVisualizerVSHostHelper.DisplayValue(IntPtr hWnd, SuccessEvaluationResultProxy evaluationResult, Int32 selectedIndex, DkmApiVersion protocolVersion)

As a temporary workaround, you can increase the timeout length; see https://stackoverflow.com/q/787334/111794.
AFAICT with a large tree, the visualizer processes the entire tree, even when the user can only see a fraction of the tree at once. The solution would be to only process part of the tree, and be able to request other parts on demand.

The configuration may be stored in a different place in VS 2019 -- https://stackoverflow.com/questions/41119996/where-does-visual-studio-2017-store-its-config?noredirect=1&lq=1 .

[VS2019] In my case I have a fairly sample grammar and I've seen the error the first time I've tried visualizer on an string. And the error persisted until I restarted VS. Now it works fine.

@MihaMarkic Do you think you could attach the grammar and string to this issue?
@doggy8088 I assume this isn't what you're seeing; you're seeing the same error multiple times, even after having restarted VS. Could you attach a grammar and sample string?

@zspitz My original grammar quality is pretty low. After rewriting my grammar, all performance issue has been resolved.

@zspitz It was really a simple one taken from tutorial, I think. It most probably isn't important in this case. I've overwritten it since I posted. But if I see the same error again, I'll post the grammar here.

@doggy8088 @MihaMarkic Thanks to you both for reporting and interacting on this issue.  But I'm going to hold off on this for now, because fixing it is a significant architectural change.


MAINT: Silence Test noise from scipy.constants

The temperature conversion functions have been superseded
by convert_temperature. This leads to some noisy DeprecationWarnings
when running the test suite. This silences them.

@@            master   #6084   diff @@
======================================
  Files          238     238
  Stmts        43863   43863
  Branches      8218    8218
  Methods          0       0
======================================
- Hit          34293   34289     -4
+ Partial       2603    2602     -1
- Missed        6967    6972     +5

Review entire Coverage Diff as of 8dae855

Powered by Codecov. Updated on successful CI builds.

Ok so it turns out that the depricated decorator doesn't do what I think it does. i.e. it doesn't actually run the test.
I'll close this for now.


TNT-32994 - fix personalization response fragment handling

Edge personalization feature response was handled incorrectly by personalization component.
Description
Personlization component was expecting an array of fragments while edge would return an object with decisions, components and rules for different types like page, views, etc.
Related Issue
NONE
Motivation and Context
Bug fix
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All tests pass and I've made any necessary test changes.
[x] I have run the Sandbox successfully.

@jonsnyder agreed, I just wanted to have a fix for current implementation, once we have getPayLoadsByType I'll adjust the code in a future PR.
Thanks!


Memory leaks

I run for a month, I find it memory is 4.9 G, hope the author can help to look at, thank you!

Which backend do you use?
On Sat, Apr 1, 2017, 03:21 huwenzheng<EMAIL_ADDRESS>wrote:

I run for a month, I find it memory is 4.9 G, hope the author can help to
look at, thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kelseyhightower/confd/issues/550, or mute the thread
https://github.com/notifications/unsubscribe-auth/AQFc8zOiFCEMqz6w13XjBUR8_igTMOToks5rraaagaJpZM4MwTeB
.

zookeeper   watch model

Hmm. How did you measured confds memory usage? Top is not reporting the
accurate memory usage of your application for example.
On Sat, Apr 1, 2017, 08:47 huwenzheng<EMAIL_ADDRESS>wrote:
zookeeper watch model
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kelseyhightower/confd/issues/550#issuecomment-290900652,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQFc8-T0o_1hnJZBsgTgrDooVFABrv2mks5rrfLpgaJpZM4MwTeB
.

"top | grep confd"  the confd memory is 4.9G  。when i restart it , it ok

and sometimes the cpu is very hight  (300% ~ 500%), i don't fond sleep function in "for" loop
and not have runtime.GC()  function.

There maybe some problems in the implementations:
https://github.com/kelseyhightower/confd/blob/master/backends/zookeeper/client.go#L99
This may lead to a goroutine leak: when multiple keys are changed in a WaitPrefix call, more than one goroutines may try to write to the response channel, but the calling routine only receives one of them, leaving others to be blocked indefinitely.
Another problem may be
https://github.com/kelseyhightower/confd/blob/93c8904baa404add44565be4e42716eb391f83f9/backends/zookeeper/client.go#L86
Watches are set for every key in every loop, but most of them are not triggered. This may leave a lot of channels open.
And there are also other problems like changes are missing. I don't know how to fix all of these...

We have an intensive CPU usage too using confd with ZooKeeper. More or less 5 processes are using near 100% of CPU until we restart the service.
Version:
confd 0.16.0 (Git SHA: 7217b0c, Go Version: go1.12)


Giving name to anonymous functions

Context: https://github.com/babel/babel/issues/11362
As currently spec'd, Logical Assignment does not assign a name to anonymous functions. Consider:
let foo;
foo ?? = function() {};
console.log(foo.name);

This currently should log undefined. But I think it'd be totally reasonable for this to log foo instead.
Babel hits this issue with its transform:
// Transformed Output
let foo;
foo ?? (foo = function() {});
console.log(foo.name);

That (foo = function() {}) will assign foo as the name for the anonymous function. We can work around this by using an IIFE to indirect. But I don't think the name hurts here.

This only makes sense of you think of the rewrite of a ??= b as a ?? (a = b) instead of a = a ?? b. I think most people will think of it as the latter. My understanding is that they're equivalent (for any a that participates in FNI, ignoring with). Because of this, I think we could have a valid argument both for and against FNI.

Makes absolute sense to have function name here, but as @shapesecurity mentioned most of us would interpret a ??= b as a = a ?? b unless otherwise mentioned or people understand that this behavior is for anonymous functions.

ftr you don't need an IIFE to work around it, you can do (0,function () {})

I could go either way on this, but I have a slight preference for it not using the name.
In the same way that
let x = false || function() { };
let y = true && function() { };
let z = null ?? function() { };

don't assign the name, I don't think this should either.  I feel like the only time we should use the variable name for the function name is if it's completely straightforward (e.g. let foo = function() { };).

Ugh I guess we really shouldn't ignore the existence of with...
Given this observable equivalence for get/set invocations:
let a = true;
with ({
  get a() { console.log('get a'); return a; },
  set a(x) { console.log('set a'); a = x; },
}) {
  // this line
  a ||= function(){};
  // is observably equivalent to this line:
  a || (a = function(){});
  // not equivalent to this line (the setter is invoked):
  a = a || function(){};
}

then I'd expect their handling of FNI should be the same.
let a = false, b = false;
with ({
  get a() { console.log('get a'); return a; },
  set a(x) { console.log('set a'); a = x; },
  get b() { console.log('get b'); return b; },
  set b(x) { console.log('set b'); b = x; },
}) {
  a ||= function(){};
  b || (b = function(){});
}
assert.eq(a.name, 'a');
assert.eq(b.name, 'b');

I don't see why the same sequence of get/set invocations should have any impact whether or not the function gets an inferred name. a || ((a) = function(){}); triggers the same proxy traps, but doesn't assign a function name.

@anba My thinking is that users will think of the syntax introduced in this proposal as simple sugar for one of a = a || b or a || (a = b) (for simple LHSs). When choosing between which of those two they might think of, we would want to take into account the semantic parity. Taking that into account, the most similar desugaring is a || (a = b), so we should match that with FNI as well.

if the left side is an identifier and the right side is an anonymous function, the function should have the name, regardless of what the operator is.


Allow for direct linking and virtual tables in relational-to-db mapping

[ ] Allow to mark a TableMap as a direct n-to-1 link and validate that assumption while parsing
[ ] Further allow TableMaps to resolve to virtual tables, if they only have one data point
[ ] Make sure to_graph() can handle direct links and virtual tables

Maybe first implement #12


Prepare 0.5 Release

This issue will result in the 0.5 release when merged. This is the first release since the project was moved from the nunit organization to my personal account.

Turns out that the chocolatey package failed automated validation and I didn't notice. I modified just that package and re-submitted it.


iOS 9 supporting issues

Hi, it seems epoxy-iOS require the target os version of iOS 13+, is it possible to run epoxy in legacy os like iOS9+?

It is currently not possible to build Epoxy to target an OS as old as iOS 9 and is not something that would warrant the effort to support. Looking at Apple's own statistics shows that supporting something older than 13 would only be a small percentage of users and devices.
If you need Epoxy to support iOS 9, I would encourage you to fork the project. Once you do that and update the minimum target version, you will encounter errors where the APIs are newer than iOS 9 and will need to provide workarounds or delete those features.


[UI] Create a flyer that showcases Meshery's stats.

Current Behavior
We need a flyer that showcases Meshery's stats and invites others to contribute to the project.
Desired Behavior
Create a flyer that showcases Meshery's stats and which invites others to contribute to the project.

Contributor Guides and Resources

🎨 Wireframes and designs for Meshery Site in Figma
🖥 Contributing to Meshery Website
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@leecalcote @ritiksaxena124
Thoughts or any Feedbacks?
I feel there are some adjustments needed....

cool @Savio629
let's get others feedback too : add this as an agenda item in the meeting minutes // @ritiksaxena124

Hey @Savio629 you are doing a great job, it looks really cool 🔥. I have put some suggestions on the flyer Figma file you can check them else GREAT JOB!!

Redesigned by @ritiksaxena124


Extra weight when initial letter is changed

One of the most glaring problems with our present spellers is that the suggestions get the same weight independently of where in the input string changes are made to produce the suggestions. This is contrary to what we know about the distribution of spelling errors, and cause a lot of noisy suggestions.
Errors are typically made in the middle of the words, not the beginning or end, so that the distribution of spelling errors' positions looks a lot like a gauss curve.
We are not able to build error models where the weights for one and the same edit changes depending on the position of the edit. A crude solution that would fix the most glaring errors would be a mechanically added weight to edits that are made to the first letter of the word. At best the initial letter weight would be configurable, for easy adjustments to the rest of the weighting scheme. The default could be 10.

Added in most recent commit.


Restrict visibility of generic attachments

Jira ticket
Only users belonging to a team that has permissions on the investigation will be able to view the details of the investigation generic attachments when visiting the investigation supporting information tab.
Other users will be aware of the attachment existence but won't be able to view the preview, title or description from them.
An user not belonging to any of the teams with access to the investigation will see:

While an user with access will see

(don't mind the preview format showing different extensions, they're different docs):

@slorek fixed! And was even worse as we already had a policy for this.

looks good however seems we are not adding restriction for jpg files(in images tab) which are attached as generic attachment. Also will be good to add a test for same.

looks good however seems we are not adding restriction for jpg files(in images tab) which are attached as generic attachment. Also will be good to add a test for same.

ignore this comment as its allowed in story criteria :) , looks all good to me!


Adding isort

As suggested in #110, this PR adds isort in pre-commit and the quality workflow, and runs it on all the existing files.
Since black and isort's defaults disagree, I added configuration to make isort follow the black conventions.

I think you might have accidentally raised the PR against your fork instead of the upstream


Xmltodict upgrade

matching xmltodict version requirements with ayx-python-sdk

This will strictly work for 3.8 python right?


406 Not Acceptable with GET frames

Expected Behavior
Get frames API works with OHIF viewer.
Actual Behavior
API: http://localhost:44301/api/studies/xxx/series/yyy/instances/zzz/frames/1
Status code: 406 Not Acceptable
Steps to Reproduce the Problem

I'm using dcm4che to sent my dicom file, seem be like ok

C:\Users\ngota\OneDrive\Documents\dcm4che-5.29.2\bin>stowrs --url http://localhost:44301/api/studies C:\Users\ngota\OneDrive\Documents\DICOM_FILES\dicom_viewer_0003\0003.DCM
Scanning files to send
..
..
Connected to http://localhost:44301/api/studies in 6ms
23:19:07.946 INFO  - > POST http://localhost:44301/api/studies
23:19:07.948 INFO  - > Accept : application/dicom+xml
23:19:07.948 INFO  - > Content-Type : multipart/related; type="application/dicom"; boundary=myboundary
23:19:08.215 INFO  - < HTTP/1.1 Response: 200 OK
23:19:08.215 INFO  - < Server : Microsoft-IIS/10.0
23:19:08.216 INFO  - < Cache-Control : no-cache
23:19:08.216 INFO  - < X-AspNet-Version : 4.0.30319
23:19:08.216 INFO  - < X-SourceFiles : =?UTF-8?B?QzpcVXNlcnNcbmdvdGFcT25lRHJpdmVcRG9jdW1lbnRzXFBBQ1NcRElDT01jbG91ZFxESUNPTWNsb3VkLldhZG8uV2ViQXBpXGFwaVxzdHVkaWVz?=
23:19:08.216 INFO  - < Expires : -1
23:19:08.216 INFO  - < Pragma : no-cache
23:19:08.216 INFO  - < Content-Length : 1213
23:19:08.216 INFO  - < Date : Fri, 17 Mar 2023 16:19:08 GMT
23:19:08.216 INFO  - < X-Powered-By : ASP.NET
23:19:08.216 INFO  - < Content-Type : application/dicom+xml; charset=utf-8
23:19:08.216 INFO  - < Response Content:
23:19:08.217 DEBUG - <?xml version="1.0" encoding="utf-8"?>
<NativeDicomModel>
  <DicomAttribute keyword="TransferSyntaxUID" tag="00020010" vr="UI">
    <Value number="1">1.2.840.10<IP_ADDRESS></Value>
  </DicomAttribute>
  <DicomAttribute keyword="ReferencedSOPSequence" tag="00081199" vr="SQ">
    <Item number="1">
      <DicomAttribute keyword="SOPClassUID" tag="00080016" vr="UI">
        <Value number="1">1.2.840.10<IP_ADDRESS>.<IP_ADDRESS></Value>
      </DicomAttribute>
      <DicomAttribute keyword="SOPInstanceUID" tag="00080018" vr="UI">
        <Value number="1"><IP_ADDRESS>.1<IP_ADDRESS>.284980.19951129.170916.9</Value>
      </DicomAttribute>
      <DicomAttribute keyword="RetrieveURI" tag="0040E010" vr="UR">
        <Value number="1">http://localhost:44301/wadouri?RequestType=wado&studyUID=<IP_ADDRESS>.1<IP_ADDRESS>.4975316777216.19951114.94101.16&seriesUID=<IP_ADDRESS>.1<IP_ADDRESS>.4975316777216.19951114.94101.17&objectUID=<IP_ADDRESS>.1<IP_ADDRESS>.284980.19951129.170916.9&&contentType=application/dicom</Value>
      </DicomAttribute>
    </Item>
  </DicomAttribute>
  <DicomAttribute keyword="RetrieveURI" tag="0040E010" vr="UR">
    <Value number="1"></Value>
  </DicomAttribute>
</NativeDicomModel>
Sent 1 objects (=0.551MB) in 0.273s (=2.018MB/s) in this http request and TCP connection

DICOMcloud log is ok

 Application Insights Telemetry (unconfigured): {"name":"Microsoft.ApplicationInsights.Dev.Request","time":"2023-03-17T16:19:07.9594295Z","tags":{"ai.cloud.roleInstance":"DESKTOP-ODVQOLT","ai.operation.id":"44dc5b7e73d60b439844f5f8e6e80f42","ai.operation.name":"POST /api/studies","ai.location.ip":"<IP_ADDRESS>","ai.internal.sdkVersion":"web:2.8.1-19196","ai.internal.nodeName":"DESKTOP-ODVQOLT"},"data":{"baseType":"RequestData","baseData":{"ver":2,"id":"|44dc5b7e73d60b439844f5f8e6e80f42.fe9f39a6_","name":"POST /api/studies","duration":"00:00:00.2587413","success":true,"responseCode":"200","url":"http://localhost:44301/api/studies","properties":{"DeveloperMode":"true","_MS.ProcessedByMetricExtractors":"(Name:'Requests', Ver:'1.1')"}}}}

Study store in my local DB

Get studies, series, metadata is ok. But get frames have problem.

Client viewer: OHIF

I have try to resolve but not work. Any one have idea or solution? Thank for review.

This is because the accept header has the 'type' sub-media without quotes ""
OHIF now has a flag to fix this issue. You can test this by updating your Postman accept header to be:
multipart/related; type="application-octet-stream"; transfer-syntax=*
A new version of DICOMcloud in .net core will be rolled out soon which will support both format with and without ""
https://github.com/DICOMcloud/DICOMcloud/tree/aspnet-core


connect to FMACM

The documentation does not provide a clear connection between this code and FMACM. Need to make it must clearer.

Looks like this was completed a while ago by updated the README. Closing.


Add concept of shuffled order to the Player interface (to allow setting and predicting this order when making changes)

Media3 Version
Media3 1.0.0
Devices that reproduce the issue
All
Devices that do not reproduce the issue
--
Reproducible in the demo app?
Yes
Reproduction steps
In https://github.com/androidx/media/issues/273#issuecomment-1472952138 Marc suggested to use controller?.currentTimeline?.getFirstWindowIndex() to get the windowIndex where playback should start.
Unfortunately, the underlying shuffledWindowIndices will be in regular sequential order after adding new items, and are only later being shuffled in ExoPlayerImpl.java#L2266.
This means that after enabling shufflePlayback and adding new items it is currently impossible to directly seek to the first item in the shuffled list (without resorting to some hack and waiting until the order is shuffled)
Expected result

Actual result

Media

Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

More information:
Directly after calling .addMediaItems() a Timeline change event is emitted. When I listen to this event and query the firstWindowIndex it is still 0.
One second later, another Timeline change event is emitted. Only during this second later event the playlist has been shuffled and the firstWindowIndex is actually some real value:
2023-04-15 15:05:48.442  7261-7261  MediaPlayerController   org.moire.ultrasonic.debug2          W  (shuffle) Adding media items
2023-04-15 15:05:48.455  7261-7261  MediaPlaye...$listeners org.moire.ultrasonic.debug2          W  On timeline changed. First shuffle play at index: 0
2023-04-15 15:05:49.287  7261-7261  MediaPlaye...$listeners org.moire.ultrasonic.debug2          W  On timeline changed. First shuffle play at index: 2

The underlying reason for this is that there is no good concept of PlaybackOrder/ShuffleOrder in the Player interface that would allow a MediaController to set or predict the order.
I will turn this into a feature request to add such a concept to the Player interface, which should include the fix to the problem you are describing here.

Thanks, that sounds like a good plan.

Could you provide an approximate timeline for when we can expect this feature request to be implemented?
In the meantime, do you guys have any workarounds for using moveMediaItem and addMediaItem when shuffled mode is enabled?
I'm rewriting SimpleMusicPlayer here which supports reordering items in the queue and has a play next option as well. I can query the current timeline to get the shuffled indices but I can't figure out how to deterministically add or move a media item at a given index while shuffle mode is enabled.

@tzugen thanks, I'll take a look at it.

Hi, are there any updates on this?


Respect comparator in items sketch

comparator handed over to items sketch is not used when sorting, making exception "Values must be unique, monotonically increasing and not NaN."

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

signed CLA

Thanks for finding this.  We will look closely at your proposed solution. :)

Thank you very much for finding this.  We decided to fix it a little differently, which doesn't impact performance, as well as made sure we had tests that covered both cases.


[bug] Testing and mocking docs are wrong

Describe the bug
The docs in https://dynaconf.readthedocs.io/en/latest/guides/testing.html explain how to test with dynaconf. The point is that if you follow the explanation, you will see AttributeError: 'DynaconfDict' object has no attribute 'current_env'
To Reproduce
Just try to follow the steps in https://dynaconf.readthedocs.io/en/latest/guides/testing.html
Expected behavior
The code don't fail and the mock can be used.
Debug output

 Debug Output
Traceback (most recent call last):
  File "lalala.py", line 5, in <module>
    toml_loader.load(mocked_settings, filename="test_conf.toml", env="testing")
  File "/home/angel/.virtualenvs/navi-Pag0EvBg/lib/python3.6/site-packages/dynaconf/loaders/toml_loader.py", line 38, in load
    loader.load(filename=filename, key=key, silent=silent)
  File "/home/angel/.virtualenvs/navi-Pag0EvBg/lib/python3.6/site-packages/dynaconf/loaders/base.py", line 69, in load
    env_list = build_env_list(self.obj, self.env)
  File "/home/angel/.virtualenvs/navi-Pag0EvBg/lib/python3.6/site-packages/dynaconf/utils/__init__.py", line 220, in build_env_list
    if obj.current_env and obj.current_env not in env_list:
AttributeError: 'DynaconfDict' object has no attribute 'current_env'

Environment (please complete the following information):

OS: Ubuntu 18.04
Dynaconf Version 2.2

We need to add a current_env property here
https://github.com/rochacbruno/dynaconf/blob/6bd9d8b88803690117e5cb5b14388da8b8011d91/dynaconf/utils/__init__.py#L52-L72

def __init__(self, *args, **kwargs):
        self._loaded_files = []
+       self.current_env = kwargs.get('env', 'development')
        super(DynaconfDict, self).__init__(*args, **kwargs)

I will work on this.

@rochacbruno Your suggestion results in another error. Any other ideas? I'm trying to figure out.
Traceback (most recent call last):
File "/home/hilam/other-projects/dynaconf/dynaconf/loaders/base.py", line 69, in load
env_list = build_env_list(self.obj, self.env)
File "/home/hilam/other-projects/dynaconf/dynaconf/utils/init.py", line 232, in build_env_list
return [env.lower() for env in env_list]
File "/home/hilam/other-projects/dynaconf/dynaconf/utils/init.py", line 232, in
return [env.lower() for env in env_list]
AttributeError: 'NoneType' object has no attribute 'lower'

@hilam maybe
self.current_env = kwargs.get('env') or 'development'

We have the same issue here with additional accessors as as_dict or as_int here:
AttributeError: 'DynaconfDict' object has no attribute 'as_int'

I think it is time to reimplement the DynaconfDict in a way that it inherits from Settings and overrides some methods to avoid unwanted loads under testing environment.

During my attempts to solve it, I tried to inherit from Settings or LazySettings, but it didn't work. Mysterious import errors. As you know the code better, @rochacbruno  you may be able to find the solution. I could not.

have the same issue. How I can help with it?

This is a pending issue, we still need a way to have DynaconfDict to be an instance of  Dynaconf class or a subclass of it.
Probably we can deprecate the DynaconfDict (alias it to a new  class)

Nice insight!
@rochacbruno So actually there's no way to mock settings?
I was digging in the tests but didn't find anything to load a json or a dict and being able to mock tests.
Thanks!

@mazzi In fact, MonkeyPatching Dynaconf settings in Pytest doesn't work, unfortunately. Setting values don't change that way.

@mazzi In fact, MonkeyPatching Dynaconf settings in Pytest doesn't work, unfortunately. Setting values don't change that way.

I think the easiest way is to dump a settings file to a temporary location and load it. Something like:
@pytest.fixture
def mock_settings_path(tmpdir):
    settings_path = tmpdir.mkdir("test_package").join("settings.py")
    settings_path.write(
        textwrap.dedent(
            f"""
                SETTING_ONE = True
            """
        )
    )
    return str(settings_path)

And you can use the fixture as follows:
def test_settings_file(mock_settings_path):
    settings = LazySettings(settings_file=mock_settings_path)
    assert SETTING_ONE == True

The beauty of this approach is that you can actually add a Mock to your mock settings file, e.g.
# in your test module
MOCK_SETTING_TWO = MagicMock()

# in your mock settings file
f"""
from {__name__} import MOCK_SETTING_TWO
SETTING_TWO = MOCK_SETTING_TWO
"""

I haven't had a closer look to the code to see the inner workings of this, but initializing and mocking the object like this:
from unittest.mock import patch

from dynaconf import Dynaconf

from my_module impoprt function_name

@patch("config.settings", Dynaconf(log_level="DEBUG"))
def test_patch(self):
    assert function_name() == "DEBUG"

Gives the expected result when trying to access the object like settings.log_level or settings["log_level"]


feat(mongo): Update mongo driver to v3

Ephemeral mongo won't work with the v3 driver and mongo2go fails.
Replaced with Testcontainers.MongoDb
Removed unused usings
Dropped netstandard 2.0 as mongo 3.0 removed target; it does support net472 but would require library to be built on windows agent
Update actions versions

Tests pass bar the MongoWatcherFacts; literally no idea what that's supposed to be testing.
Watching the mongo db the data written in the test is committed.

I'd say this is a breaking change as Mongo v3 drops support for netstandard2.0
They have kept net472 but that would probably require some fettling with the github actions. For now I've simply set the target for either
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netstandard2.1;net6.0;net8.0</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">net472;netstandard2.1;net6.0;net8.0</TargetFrameworks>

Thanks! I will take a look.
MongoJobWatcher observes the changeStream, when jobs are enqueued. It requires replica sets. Im guessing the test container is a single node.

Hello,
waiting for this PR :)
Thanks in advance,
Adrien

I merged it to master branch. I will release, when I got the last test running using testcontainers.
Thanks!!

Hi,
Appears there is one test which did not passed. The build wasn't complete so.
Could you take a look if you have the time?
Thanks a lot in advance,
@

Released v1.11.0 Thanks @ChrisMcKee!


Release 0.5.1

### v0.5.1

* Add 2017 to the license copyright. #65
* Update versioneer to 0.18. #66
* Cleanup MANIFEST.in whitespace. #67
* Add conda-forge badge. #68
* Recut with cookiecutter. #69
* Update copyright years in docs. #70

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Merging without Travis.


relationals: Fix vector component accessor selection

It seems the intent was to use .xyzw vector component accessors in
the kernel whenever vecSize is 2, 3, or 4.  The condition was wrong
(i.e., always true for any value of vecSize), causing it to always
create a kernel with numeric (.s0123...) vector component accessors.
The restriction on the use of .xyzw for 8 and 16-component vectors
has been lifted a while ago (see
https://github.com/KhronosGroup/OpenCL-Docs/issues/549) so we do not
need this check at all.
Also, fix the vecSize argument of two calls of get_order_string
when getting the order string for the "in" kernel argument.  Pass
inVecSize in these cases, not outVecSize.
Signed-off-by: Sven van Haastregt<EMAIL_ADDRESS>

Should this condition be removed entirely?
https://github.com/KhronosGroup/OpenCL-Docs/issues/549

Should this condition be removed entirely?
KhronosGroup/OpenCL-Docs#549

Nice catch, I think we can.  I'll update the patch to remove the if altogether.

I'll update the patch to remove the if altogether.

Done.  I then noticed that the vecSize arguments were wrong in some cases, so have fixed that in the same commit.

Qualcomm would like more time to review this.

Has two approvals and another thumbs up, merging.


feat: use prisma neasted create when creating a user and key

Prisma supports neasted creates for relations, see https://www.prisma.io/docs/concepts/components/prisma-schema/relations#create-a-record-and-nested-records. This let's it optimize the creation depending on what the database supports.
Currently untested, how do I run the test suite?

This let's it optimize the creation depending on what the database supports.

Do you know where I can read more about this? It's a pretty basic transaction. Unless Prisma is making it more complex than is has to, I don't see how this is better than the current approach?

I don't have a reference, but you can set log: ['query'] if you are interested in the exact queries that prisma generates (https://www.prisma.io/docs/concepts/components/prisma-client/working-with-prismaclient/logging). In general, I trust the guys at prisma to optimize things if possible.
Also a clear advantage is that prisma takes care that the key is bound to the correct user (which would be one step towards allowing db-created ids).

You can run pnpm test to run the tests btw.

I had some issues with dependencies not being built etc, so I added a bit of a build setup. Hope that's okay for you.
Tests are passing, so this should be good to go.

Do you see any differences in the SQL queries used?

Not much for the default sql provider used in the tests (is it mysql?). There is are two linked inserts plus one select for the id - I guess in the old code there would be two such selects, but I didn't double check). But, for example, mongodb has an api for embedded docs so I assume this is used.

But, for example, mongodb has an api for embedded docs so I assume this is used.

I have really limited knowledge on MongoDB and Prisma, but should the data be stored as embedded documents? My understanding is that you can't directly find an embedded doc with an id, and you need to find the parent doc first. I don't really see any benefit changing the code?

There is not a huge benefit...prisma just provides a convenient api to store nested data, so why not use it and maybe profit from some underlying optimization (or just from the fact that prisma has way more unit tests covering various aspects).
The main advantage comes from the fact that you don't have to specify a userid for the key...which will be handy for a proper fix for https://github.com/lucia-auth/lucia/issues/1161 (I really like to have control over my userids, sorry ;-) )

I really like to have control over my userids

I mean you know that you can override the default id generation, right? Allowing default database values is another issue, and I think it's best to figure that out first before making any PRs.

Very welcoming atmosphere here...
I thought it would be easier to propose smaller changes in each PR, but well, here you go: https://github.com/tobiasdiez/lucia/commit/8b6c5a476faf8eefbfe08d12925c0c07f68f900b (there are still a few minor ts errors to sort out, but the prisma adapter tests are working with db-generated user ids)
(I cannot reopen this PR...)

No, at least right now, since it'll be a breaking change.

I've actually implemented it in such a way that its not a breaking change (or at least I don't see what it would break).

You have to update UserSchema.id type to accept undefined, and I don't think really see a reason to support auto generated ids in the first place

You have to update UserSchema.id type to accept undefined

Not really, I would change the input type of the user creation function, not its output.

input type of the user creation function

So UserSchema?

Currently yes, but I think it makes sense to allow users specify their own "CreateUser" type, for example if you have a "dateCreated" in the user that is automatically handled by the db, you don't need to specify it upon creation but you will always have it when querying the user. So very similar to how prisma has also a different type for the create methods.
(In my opinion, one of the strengths of lucia is that it allows you to adapt it quite easily to your needs, so having good support for extending the user type seems quite important to me.)


Upgrade cross dataset duplicator with a fix to the url

@padms - is there anything I should test for this?


[ZEPPELIN-2921] does not work conda environment in python interpreter

What is this PR for?
Fixed a problem where conda's library was not installed and reflected properly due to changed python interpreter execution  flow and structures.
ORIGINAL : https://github.com/apache/zeppelin/pull/2574
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2921
How should this be tested?
Please run the following command line for each paragraph.
If the module such as scipy is normally imported, it is a success.
%python.conda create --name Hello6 python=2.7
%python.conda activate Hello6
%python.conda install seaborn pandas numpy scipy matplotlib
%python
import scipy as sp
import seaborn as sns

%python.conda deactivate
Screenshots (if appropriate)
Before

After

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

@1ambda @zjffdu @felixcheung
Sorry.
I divided the existing PR by the minimum function.
Can you review this PR again?
Thank you for your help :)

The problem of CI is irrelevant to this pr.
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 12.462 sec <<< FAILURE! - in org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest
testStartStop(org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest)  Time elapsed: 10.043 sec  <<< FAILURE!
java.lang.AssertionError: expected:<true> but was:<false>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest.testStartStop(RemoteInterpreterServerTest.java:62)

Thanks @cloverhearts , Is it possible to add unit test for PythonCondaInterpreter ? Regarding the CI failure, I know this failure and will fix it in another PR

@zjffdu Sure, Thank you :)

Tested locally and works well. @cloverhearts Can we fix conda list command as well? it will need exactly the same code with conda install.
LGTM except for it.

@1ambda okay :)

fixed test case and conda list feature

Checked that conda list works beautifully. But I am getting this ipython related message when activate a new env. Can we remove this message which is not related to conda at all.

@1ambda This is due to IPythonInterpreter, could create a ticket ? I will fix it in another PR.

@zjffdu I created one. Thanks.

https://issues.apache.org/jira/browse/ZEPPELIN-2923

LGTM.

If there are no comments anymore, I will merge to master on this pr.

LGTM, just one concern about PythonCondaInterpreterTest.java. It is using mock which may not found potential bugs. I think we can do unit without mock. But anyway this could be done in a following up ticket.

@zjffdu Thank you a lot :)


R50 train parameter

Is the R50 result displayed on the page consistent with the training parameters of the mxnet version? I see that the training scale is 840 * 840 in R50‘s  config.

Same question. And the initial learning rate in the paper is 1e-2, while 1e-3 in this repo here. Have you checked if we can enlarge the lr while reducing the training epochs?

@dianxin556  have you ever tried one 640x640 trained model? My device is not allowed to train 24 images for 840x840 :(

Hi, I've trained one 640x640 baseline, the result is
==================== Results ====================
Easy   Val AP: 0.9270121584603086
Medium Val AP: 0.9234432537094537
Hard   Val AP: 0.884572269484029

can you share your training config parameters?


Support for VT-52 and other type of terminal and screen sizes.

Hi Udo.
Is it planned to have support for other type of terminal and screen sizes, like VT-52, etc.?
For example, my real CP/M computer is an Amstrad PCW with a VT-52 like 32x90 screen and I was wondering if I could port S in a "standard way" having in mind other "official" ports or not.
The obvious path to achieve this is to modify the file screen.c in a compatible way, but maybe we could think in a configuration file or something like that.
Thanks.

Hi Miguel,
during the 80's we ported UNIX termcap to CP/M and using it for software that came from UNIX. Problem with this was that even a small termcap library needs ca. 5KB memory, which will reduce the edit buffer for s even more. So I would suggest to add VT52 and ADM3A terminals to screen.c with apropriate #ifdef's, then one can compile it with -DANSI, -DVT52 ... for the needed terminal.

Hi Udo.
Ok, I will follow that path and pull a request asap.
Thanks.


HP ILO new log type identification

SC4S is not able to understand the format in which the message has program type other #ILO4 , if program is iLO5 it will not understand it , it will be identified as dellemc sourcetype.

:tada: This issue has been resolved in version 2.47.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update Backpacks.cs

Adding translation in portuguese brazil

Sorry for the delayed reply.
I'm not open to adding translations to Backpacks at this time.
Please send PRs to the main repo, not the fork.


[IOTDB-5681] Fix the creation of system database used by IoTDB Internal Reporter

Fix the creation of system database used by IoTDB Internal Reporter


Map handoffs and checkpoints for genome scale runs of image analysis workflow

(Moved here from https://github.com/broadinstitute/pooled-cell-painting-analysis/issues/83)
Right now, the workflow has several stages and/or proposed stages

CellPainting illumination correction calculation
CellPainting illumination correction
CellPainting segmentation pipeline (see #81)
CellPainting stitching and splitting into tiles
Barcode calling illumination correction calculation
Barcode illumination correction application (see #82) and alignment.
Barcode color compensation and barcode calling "sanity check".
Barcode stitching and rescaling and splitting into tiles
Final profiling + barcoding pipeline

This creates 2 pre-setup steps, and at least 6 handoffs.  Right now, each one is manual, with manual quality checks at each.  For each one, we need to a) decide how we're going to do file handling and b) decide if and how we will determine success (quantitative cutoff? How/where do we check it? Manual visual inspection of something? Same thing) or if we think it can just proceed with something like an Amazon Lambda trigger.

[x] Pre-1-2

[x] Pre-5-6

[x] 1 to 2

[x] 2 to 3

[x] 2 to 4

[x] 3 to 9 - MANUAL

[x] 4 to 9 - MANUAL

[x] 5 to 6

[x] 6 to 7

[ ] 7 to 8

[x] 8 to 9 - MANUAL

OPTIONAL BUT REALLY NICE

[ ] Post 7 (maybe to feed 8)
[ ] 9 - setup and run
[ ] 9- cleanup

Misc notes

For pre 1-2 and pre 5-6, trigger by upload of pipeline
No check needed between 1 and 2 or between 5 and 6, ok to set auto-triggers
2 to 3 - in the illum correction application pipeline, which will be grouped by ~Plate~ EDITED 2020-05-18, Plate and Well, have it also calculate thresholds of cell segmentation stain and export that as a CSV. Then write a lambda function that (best case scenario) edits pipeline file with (50th? 75th? percentile) new threshold max to run a segmentation check pipeline, which runs on every 10th image and checks segmentation with and without a max (worst case scenario) emails you to run that pipeline. No auto-feed 3 to 9, should be manually checked.  Ideally, triggered by either creation of the post-2 summary CSV OR a new pipeline being uploaded - CONFIRMED 2020-05-18
2 to 4 - automatic, triggered by lambda (specifically post-2 summary CSV).
4 to 9- should save 10x downsampled thing. No auto-trigger of 9, needs to be manually checked.
5 to 6  because of all the alignments is SLOW; it need to be batched as small as is practical, but while we are still using one file per well, batching to single files is less-than-ideal because loading of all files for a well takes 15-25 minutes for the first site from a well, and mere seconds for the one after that.
6 to 7 should be triggered either by 6 completing OR upload of a new pipeline, ideally - DONE June 11th
7 to 8- in an ideal world, auto trigger if % perfect greater than threshold value (70%?); if not doable, auto-trigger stitching then human does manual check for any plates that may need to be adjusted.
8 to 9- should save 10x downsampled thing. No auto-trigger of 9, needs to be manually checked.

Right now, uploading the pipeline for step 2-3 causes an infinite recursion loop; should fix that.

Right now, uploading pipeline 7 triggers a new run, but we probably don't want to just go ahead and do that on initial uploading


README formatting improvements

Some of the markdown syntax was a little off, making it render oddly on GitHub.

LGTM!

This has already been addressed in caxlsx: https://github.com/caxlsx/caxlsx/blob/master/README.md


[Fabric Bot] Update Form Recognizer Contacts

Summary
The focus of these changes is to update the bot rules to mirror the CODEOWNERS changes made in #28300.

/check-enforcer override


Map helper revamp

still need to add integration for auto submitted mice... please don't delete branch yet


fix: default event tracking options

Apply change of https://github.com/amplitude/amplitude-browser-sdk-gtm-template/pull/23

This PR depends on wrong branch. Reopen a PR https://github.com/amplitude/amplitude-browser-sdk-gtm-template/pull/27


Algorithm implementation

Implement xxHash algorithm for determine key position in page and page position in node.

Resolved #12


up-4ever.net website not bypass

Domain
https://www.up-4ever.net/
Link
https://www.up-4ever.net/yux5f8pjpmtt
Version
0.2279-Mv3
What browsers are you seeing the problem on?
Microsoft Edge
What OS are you seeing the problem on?
Windows
Anything else?

it not bypass countdown

Oh...


[AVM Module Issue]:  Please Update virtual-machine module nic-configuration.bicep for new public IP module 0.4.1

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Feature Request
Module Name
avm/res/compute/virtual-machine
(Optional) Module Version
0.4.2
Description
Hi,
Public IP Address AVM module has been recently updated to allow DDoS IP Protection, this now means that ddosProtectionPlan is not a required parameter. New version is 0.4.1 nic-configuration.bicep is using 0.4.0. This was implemented as part of the following pull request.
https://github.com/Azure/bicep-registry-modules/pull/2006

(Optional) Correlation Id
No response

@darrenFrowen thank you. I will investigate

Thank youOn 4 Jun 2024, at 15:46, Rainer Halanek @.***> wrote:
@darrenFrowen thank you. I will investigate
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@rahalan any update on this one please?

Hi @rahalan,
I can clearly see that the module for the public IP address is now at 0.4.1 as follows.
module networkInterface_publicIPAddresses 'br/public:avm/res/network/public-ip-address:0.4.1'
which should support the following configuration without specifying the DDoS Plan ID.
            ddosSettings: {
              protectionMode: 'Enabled'
            }

However when i execute the deployment it fails with the following error.
Deployment template validation failed: 'The provided value
| for the template parameter 'ddosSettings' is not valid. A non-null value for the property 'ddosProtectionPlan' must be provided.


go file writing(os.OpenFile) mess with old content after os.Rename

What version of Go are you using (go version)?
go version go1.10.3 darwin/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
macOS amd64
What did you do?
// backup old dir
if _, err = os.Stat(configDir); err == nil {
  err = os.Rename(configDir, configDir+string(time.Now().Format(time.RFC3339)))
  if err != nil {
    log.Fatalf("Failed to rename old config file %v.\n", configDir)
  }
  _ = os.Remove(configDir)
}
f, err := os.OpenFile(configDir, os.O_RDWR|os.O_CREATE, 0664)
checkError(err)
defer f.Close()
// write file content with f.WriteString

What did you expect to see?
I expect no old file content in it
What did you see instead?
new content messing with old content in the file

The line

was added to try to get rid of the issue, but it does not help.

Thank you for your error report. Can you please show us a complete runnable program which demonstrates the issue

It's a small package  envconf
Here's the code to reproduce the issue:
package main

import (
  "github.com/devfans/envconf"
)

func main() {
  url := ""
  conf := envconf.NewConfig("~/.ssh/store")
  conf.Put("store", "etcd")
	conf.Section = "etcd"
	if url == "" {
		url = conf.Get("ETCD_URL", "url")
	}

  conf.Put("url", url)
  conf.Save()
}

After run it twice, you will see some messing content in the file: .ssh/store

Seems the issue is not related with go. It's the logic in my codes. I found the reason. Thanks through!


Add "Clear" net message.

https://github.com/hunterdyar/Clayze-Server/commit/99201be90a6118a20b2cd31bd9c56288da5970e1


Support Packed Audio

As discussed with @mat-hek, before merging this one we should consider
removing the ID3 parsing code and instead use a library, as there is
code duplication between here and the mp3 decoder.
Right now tests are passing, but

only ID3v4 tags are supported
only PRIV frames are actually parsed, the rest is skipped (which might be fine)

Hi @dmorn, any update on this?

@dmorn got it, but is that something you still need?

Hi @mat-hek, right now no! Thanks!

... we're very close though


Link protection: message polish

Refs: https://github.com/microsoft/vscode/issues/79465
The current wording for the link protection dialog is.
Do you want ${product_name} to open the external website? \n ${website_name}
I think it might be nicer to just say:
Do you want ${product_name} to open ${website_name}?
Everything is in one line.
Let me know what you think

Agree. Let's close as designed.
Thanks


Readme updation by adding different open-source programs this project is part of like swoc

Let me know if this needs to be done

Also please add a "swoc" tag to it as it is participating under swoc

Also please add a "swoc" tag to it as it is participating under swoc

@Sloth-Panda Yes, you can work on this if you want.

@Sloth-Panda Yes, you can work on this if you want.


No module named 'Scapy'

Checklist for submitting an issue to KickThemOut:

[x ] I have carefully read the README file and haven't managed to resolve my issue.

[x ] I have searched the issues of this repo and believe that this is not a duplicate.

[x ] I am running the latest version of KickThemOut.

OS name & version: Kali Linux 32 Bit ver. 2018.1

Python version: Python 3.6.5 (default, Apr 12 2018, 22:07:01) | Python 2.7.14+ (default, Apr  2 2018, 04:16:25)

Scapy version: scapy-python3 (0.23) | scapy (2.4.0)

Nmap version: Nmap 7.70

Link of Gist: https://gist.github.com/arayaa/295b4b7149d1f2abb1c2f05bb63e657d

Description:
root@arayaa:~/Desktop/kickthemout-master# pip3 install -r requirements.txt
Requirement already satisfied: scapy-python3 in /usr/local/lib/python3.6/dist-packages (from -r requirements.txt (line 1))
Requirement already satisfied: python-nmap in /usr/local/lib/python3.6/dist-packages (from -r requirements.txt (line 2))
Requirement already satisfied: netifaces in /usr/local/lib/python3.6/dist-packages (from -r requirements.txt (line 3))
root@arayaa:~/Desktop/kickthemout-master# python3 kickthemout.py

ERROR: Requirements have not been satisfied properly. Please look at the README file for configuration instructions.
If you still cannot resolve this error, please submit an issue here:
_https://github.com/k4m4/kickthemout/issues_
Details: No module named 'scapy'

Hi there. Can you try upgrading to the latest version of pip3 and then re-installing all dependencies? Please post your steps in the process. Thanks.

All of that is the latest ver.
root@arayaa:~/Desktop/kickthemout-master# pip3 -V
Pip 10.0.0 from /usr/local/lib/python3.6/dist-packages/pip (python 3.6)
root@arayaa:~/Desktop/kickthemout-master# pip3 install -r requirements.txt
Requirement already satisfied: scapy-python3 in /usr/local/lib/python3.6/dist-packages (from -r requirements.txt (line 1)) (0.23)
Requirement already satisfied: python-nmap in /usr/local/lib/python3.6/dist-packages (from -r requirements.txt (line 2)) (0.6.1)
Requirement already satisfied: netifaces in /usr/local/lib/python3.6/dist-packages (from -r requirements.txt (line 3)) (0.10.6)
root@arayaa:~/Desktop/kickthemout-master# python3 kickthemout.py
ERROR: Requirements have not been satisfied properly. Please look at the README file for configuration instructions.
If you still cannot resolve this error, please submit an issue here:
https://github.com/k4m4/kickthemout/issues
Details: No module named 'scapy'

Are you using sudo?

yes

I tried with sudo, and it still No module named 'scapy'

Could you share the exact results of sudo python3 kickthemout.py? Also, please uninstall all dependencies, re-install them following the exact process in the readme file and share the result of each command here. Thanks!

arayaa
my i help you sir installation?

i have the same problem.
No module named scapy.
everything is installed correctly then why it is happening?

iqbalnur2 Yes,plz

@Malik20019 yeah, i dont know why, i cant find any reason for that prob

@k4m4
root@arayaa:~Desktop/kickthemout-master# sudo python3 kickthemout.py
ERROR: Requirements have not been satisfied properly. Please look at the README file for configuration instructions.
If you still cannot resolve this error, please submit an issue here:
https://github.com/k4m4/kickthemout/issues
Details: No module named 'scapy'

All requirements have been satisfied according to README file.
But still the same problem

And they still not give us a way to solve, just repeat: read readme carefully, are u insta it correctly,..  Blabla...

Hey again guys; I am unable to reproduce this. Can anyone send me a walkthrough of their installation process (i.e. all commands run and --> their responses <--), please? You're not really giving us anything to work with here... Thanks.

@k4m4 here, https://youtu.be/PDfL6ZIKmRo , plz help me

hey when i put ' sudo apt-get -y install python3-pip' in I get:
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package python3-pip
No idea if the last line means anything but nothing changes when putting in the other commands :/

You can try
$ sudo apt-get install python3-setuptools
$ sudo easy_install3 pip

Thanks for the reply, but it still comes up with some kind of error:
Package python3-setuptools is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
E: Package 'python3-setuptools' has no installation candidate
And for the second command it says command not found :/

Have you tried updating your system before running the suggested commands?

Oh yeah, i made a new vm with the updated iso and it worked :P for some reason it doesnt scan all devices on the network though all i get are short ips and 'no vendor' results. Is there any way to fix this?
<IP_ADDRESS>		No vendor (_gateway)
<IP_ADDRESS>		No vendor (N/A)

Hi again @deserboi. Have you configured your VM network settings correctly? Are you using a bridged connection?

Yeah sorry i plugged in a ethernet cable to the laptop and changed the network settings. It works now, thanks a lot! :))

Glad it worked.


Add node_modules to bundle derivation so that esbuild can load npm packages

Basically extending the changes in #38 to work for bundle.
According to https://nodejs.org/api/modules.html#loading-from-the-global-folders, manipulating NODE_PATH is no longer recommended because global systems can interact in unexpected ways.  However, I tried both copying and symlinking node_modules into the working directory, but esbuild was not able to locate the packages either case.  However, if you think NODE_PATH is not ok to use, I can look into this more.

@mstksg Thank you for this PR. I'm really sorry for not getting around to looking at this until now.
I think this looks good.
I've also run into issues due to resolution of paths through symlinks confuses node and purescript because purescript assumes all packages will be able to reference each other with paths like "../other-package/src/index.js".
I think NODE_PATH is a good solution to tackle this in the immediate term but I'd like something a bit more robust in the future, I just don't know what that would be at the moment.

thanks! happy to help and no worries, i was working fine with a fork in the mean time.


Requests are IP based and not hostname based

Hi,
Not sure if this is a problem with boom or Go but I've noticed on two separate runs that the requests use the ip of the target in both the URL requested and the Host header.
Version
/# go version
go1.2 darwin/amd64
Built using go get.
Found the problem with Wireshark
So using boom to test
http://test.com/test
Would result in the requests looking something like
Host: ip.of.test.com
http://ip.of.host.com/test

:+1: Would love to see correct https support.

Any viable fix on this issue?
Example from readme isn't working.
mbp:~ evrial$ boom -n 1000 -c 100 https://google.com -allow-insecure
1000 / 1000 Boooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo! 100.00 %

Error distribution:
  [1000]	Get https://<IP_ADDRESS>: x509: cannot validate certificate for <IP_ADDRESS> because it doesn't contain any IP SANs


Fix indexation perfomances on mounted disk

We were creating all of our tempfiles in data.ms directory, but when the database directory is stored in a mounted disk, tempfiles I/O throughput decreases, impacting the indexation time.
Now, only the persisting tempfiles will be created in the database directory. Other tempfiles will stay in the default tmpdir.

Many, the hero of the mounted disk 🦸


Odoo compatibility fixes

Hi @gjvoosten ,
Thanks for your contribution.
You were right the new API appeared in the v8. From this release both API were available but the xmlrpc/2 is available from v8. I'm gonna test this on various install soon and merge your job once tested.
regards

Indeed @flotho, some of the lines in the API that test for v7 are redundant, as the XML-RPC interface that is called is not even there in v7. ;-)


add 3d patch embedding layer for video task

Codecov Report

Merging #808 (4fa71af) into main (c998703) will decrease coverage by 0.05%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   70.80%   70.74%   -0.06%
==========================================
  Files         169      170       +1
  Lines        7723     7750      +27
  Branches     1267     1273       +6
==========================================
+ Hits         5468     5483      +15
- Misses       1880     1887       +7
- Partials      375      380       +5

Impacted Files
Coverage Δ

towhee/models/layers/patch_embed3d.py
55.55% <55.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c998703...4fa71af. Read the comment docs.

/approve


Back to Top for Developer Guide

Coverage remained the same at 92.254% when pulling e8cf7a9d65b16534d84b6bf538ad0306b9517411 on chernghann:DeveloperGuide into 6d9d2e9160cb27a28072be956c66c57513d53e4e on CS2103AUG2017-T15-B3:master.


Load Custom Font

Hi @saadqbal,
Thanks for this awesome library. Is there a way to load custom fonts (like non-google fonts)
Thank in Advance
Karthick Kumar

Hi @karthickvkumar
The library only support google fonts at the moment. I have plans to add support for custom fonts but that likely to happen in the recent future. I am fully consumed by projects.
Please do me know if you want work on it.

@saadqbal  sorry for late reply, Yes I would like to work on it! but i struggling with the concept.
Thanks in Advance!


fix: timber charts manifest

Modification
Bugfixes
Reduce chart name
Chart new names (do i need to rename the folder actually 🤔 )

fluentd
observation-svc

Fluentd

Add namespace namespace: {{ .Release.Namespace }} to components for consistency
Refactor charts/timber-fluentd/templates/_helpers.tpl, removed selector variables, and use merlin's helpers.tpl as reference.
Bugfix selector fullname to name in statefulset.yaml and service.yaml

Observation service

Rename timber-observation-service to observation-svc to trim number of char
Set default fluentd nameOverride to from timber-observation-service-fluentd to obs-fluentd
Fix wrong variable and added condition for null check on fluentd.gcpServiceAccount in deployment.yml

Checklist

[x] Chart version bumped
[x] README.md updated

Chart new names (do i need to rename the folder actually 🤔 )
I think it's better to rename the folder too for consistency


Support chainable proxies for automatic stdlib upgrades

The current unstructured-storage proxy implementation does not support chaining two or more proxies, since they compete with the same storage space for the implementation slot. This could be fixed by using a different slot for every proxy, though this may require changes on how proxies are deployed.
The use case for this is to support automatic upgrades on stdlib contracts, by creating a proxy linked not to the logic contract deployed by the library provider, but to a proxy of it, which is also managed by the library provider. This allows the proxy owner to upgrade his instance to a different implementation, but also allows the library provider to centrally upgrade all its clients.
Another use case is to atomically update multiple proxies in an application with a single transaction. Should an app rely on a large number of instances of the same contract, all proxies could be upgraded simultaneously if they delegate to another proxy. Note that, in this case, the proxy instances can be constant proxies, as upgradeability is managed on the second-level proxy.
These use cases were brought up by the Chicago Decentralized Software Group and by @shrugs respectively.

Agree for simultaneous upgrades, though it doesn't cut it for automatic lib upgrades, where we'd need to allow both proxies to be upgradeable. That said, we could use different approaches for both use cases, as gas cost is greatly reduced in your scenario @shrugs.

Closing in favor of #1324


unused parameter warning

In the redisvAppendCommand method in the hiredis.c file, two parameters, format and ap, are not used, resulting in a compilation error.
detail:
hiredis.c: In function ‘redisvAppendCommand’:
hiredis.c:1128:54: error: unused parameter ‘format’ [-Werror=unused-parameter]
int redisvAppendCommand(redisContext *c, const char *format, va_list ap) {
                                                        ^
hiredis.c:1128:70: error: unused parameter ‘ap’ [-Werror=unused-parameter]
 int redisvAppendCommand(redisContext *c, const char *format, va_list ap) {
                                                                       ^
cc1: all warnings being treated as errors
make: *** [hiredis.o] Error 1

I'm confused by this.  We are using those args in redisvAppendCommand.
https://github.com/redis/hiredis/blob/19cfd60d92da1fdb958568cdd7d36264ab14e666/hiredis.c#L1139
But if you can provide a docker image that replicates this error I'm happy to resolve it.

I'm confused by this. We are using those args in redisvAppendCommand.
https://github.com/redis/hiredis/blob/19cfd60d92da1fdb958568cdd7d36264ab14e666/hiredis.c#L1139
But if you can provide a docker image that replicates this error I'm happy to resolve it.

It might be an issue with missing local code. Thank you for your explanation.


CI: add trigger for IQE pipelines

This modifies the Jenkinsfile used for release to also send a POST
requested to a webhook url which will then trigger test pipelines in IQE
Jenkins.
That Jenkinsfile is quite stable and will probably not see any more changes as the frontend deployement is moving away from it. For now if we want to trigger IQE test pipelines after a deploy of new frontend this is the way to do it.

Sorry if this is a naive question, but could you explain how the IQE test pipeline fits in? What tests does it run, and is this going to be used for things like auto promotion or something like that? I'm sure I have read this at some point, but might also be good to document / explain for outsiders to understand.

That Jenkinsfile is quite stable and will probably not see any more changes as the frontend deployement is moving away from it. For now if we want to trigger IQE test pipelines after a deploy of new frontend this is the way to do it.

I didn't understand this, could you explain a bit more? Are you saying that the Jenkinsfile is being deprecated in favour of the web hook to the IQE test pipeline?

Sorry if this is a naive question, but could you explain how the IQE test pipeline fits in? What tests does it run, and is this going to be used for things like auto promotion or something like that? I'm sure I have read this at some point, but might also be good to document / explain for outsiders to understand.

The IQE pipeline runs just basic sanity checks and one e2e scenario against console.redhat.com The test suite lives in here:
https://gitlab.cee.redhat.com/insights-qe/iqe-image-builder-backend-plugin & https://gitlab.cee.redhat.com/insights-qe/iqe-image-builder-frontend-plugin and it's run in IQE Jenkins currently twice a day. I want to run the tests as soon as deployment of new app on console.redhat.com happens. It's not going to be used for any promotions AFAIK.

That Jenkinsfile is quite stable and will probably not see any more changes as the frontend deployement is moving away from it. For now if we want to trigger IQE test pipelines after a deploy of new frontend this is the way to do it.

I didn't understand this, could you explain a bit more? Are you saying that the Jenkinsfile is being deprecated in favour of the web hook to the IQE test pipeline?

Yeah my understanding is that the whole Jenkins is currently legacy and it's going to be replaced by new frontend-deploy container run in app-sre environment. And no it's not being deprecated now by this, I just don't have any other way to put in the curl command, this was suggested to me if I want to do it. All the frontend apps share the same Jenkinsfile and it hasn't been changed for months so it should be fine to have our own. Alternatively I can just modify it with sed after it's downloaded from the common repo, but I figured it's going to be easier like this.
I also plan to add some conditions for branches, right now I want to test it for stage only.

Thanks @jrusz !
What happens to the IQE results? Where are they reported? Even if no auto promotion is planned, is it a possibility?

Thanks @jrusz !
What happens to the IQE results? Where are they reported? Even if no auto promotion is planned, is it a possibility?

They are reported to #osbuild-image-builder-service channel on Slack. The auto promotion is certainly a possibility in app-sre environments, but first Insights QE teams would have to finish their migrations I think, there are already attempts to run the tests there in containers but there are still some issues AFAIK. I didn't look into this much deeper because we decided we don't want to move the current IQE pipelines from their environment where we know they're working and doing what we need :)

@Gundersanne could you please review?


Template tests failing due to compiler error MVC1001

Templates for 2.2 do not compile anymore.
Pages\Error.cshtml.cs(17,10): error MVC1001: 'ResponseCacheAttribute' cannot be applied to Razor Page handler methods. It may be applied either to the Razor Page model or applied globally. [C:\b\w\33bdfc1cae7b2a38\modules\Templating\test\Templates.Test\bin\Release\netcoreapp2.2\TestTemplates\AspNet.Template.036266b6962741fdbcb9c610de3c49f1\AspNet.Template.036266b6962741fdbcb9c610de3c49f1.csproj]

http://aspnetci/viewLog.html?buildId=481546&tab=buildResultsDiv&buildTypeId=Lite_UniverseTest
Caused by changes added in https://github.com/aspnet/Mvc/issues/7684 (@kichalla / @pranavkm )

Should be fixed with https://github.com/aspnet/templating/commit/e403187be35a25560692aaa7ded495e26bb3ad90


Fix color space mix-up

This resolves issue #4 (and also fixes a typo in the documentation).

Coverage remained the same at 100.0% when pulling 5bd662217d4121337d3f33451a24d8aabd0b6986 on TFiFiE:master into 0c418239e881bc1effa2e2f777d6a7c4029f485a on njsmith:master.

Well, this is mortifying. Thanks!


Ctrl-Fine adjust mode hides mouse but still activates tooltips

When using DA with Ardour, ctrl fine adjust mode hides the mouse cursor - however if a user moves the 'hidden' mouse pointer over a tooltip enabled area in the UI of the DAW the tooltip becomes active.

In this example I am adjusting the HPF cutoff in fine mode, the cursor is hidden but still activating the tool-tip for Ardours Virtual MIDI Keyboard Velocity dropdown.

A bug to report to JUCE upstream


Update of unit tests (including update regarding issue #19)

Hello,
here is a pull request regarding fesapi unit tests.
Regards,
Mathieu
What does this implement/fix? Explain your changes.

update catch.hpp from v1.5.6 to v2.0.1
update some include directives and namespaces (some classes have moved from resqml2 to common)
also update some gSOAP constant names used within unit tests.

Does this close any currently open issues?
Rigorously speaking, this commit does not close issue #19 since some unit tests still fail ("Ijk to unstructured grid" and ""Export and import grid connection set on partial grid"). Nevertheless, here is a major improvement regarding this issue since other ones succeed right now.
Where has this been tested?
Yes. Windows 10 64bits.
Platform: Visual Studio 2015 Community

Hi Mathieu,
Thanks for the PR.
I just reported the AppVeyor bug about noexcept and VS2013  to catch : https://github.com/catchorg/Catch2/issues/1123
If you want, you can revert changes on catch.hpp. We'll upgrade it later since there is no critical bug with the current version. The main benefit to upgrade it was to have less Codacy error which is not really the case anyhow.
Regards


docker-swarm 1.0 supports the images automatically sync to a different host it when you start the container?

as title, thanks!

@swan-go can you clarify your scenario?

ping @swan-go could you provide more information? Otherwise we'll have to close this issue, because it's not clear to use what your request is.


Simplified double string parsing

Replaced code in toDouble used to parse string with conversion via Double(). Changed double test case for string "+42.3" to accept and parse rather than reject.

👍 Thanks!


Regulation of calcium-independent cell-cell adhesion

Hi,
Could I please request the regulation terms
(positive/negative), for the existing GO term 'calcium-
independent cell-cell adhesion' (GO:0016338).
cheers,
Emily
(P78423 +ve regulation term; replace GO:0016338)
Reported by: edimmer
Original Ticket: "geneontology/ontology-requests/1751":https://sourceforge.net/p/geneontology/ontology-requests/1751

thanks www.movied.org


I want the old behaviour for full screen

Hi @sarbagyastha , I just noticed that the behaviour when the player becomes full screen has been changed sine the recent update. However I actually had better experience with the old behaviour. I want the player go landscape and also I don't want it to navigate to new widget by creating one because it removes all my UI until it pops back again. I wonder if you made a way to keep using the player as old version? (but I only want it for full screen, I like newer version for everything else)
Thanks !!

@Jay-Jeong1988 Sorry for late response. Version 5 might address this.


Add onStart and onStop to OnProgressChangeListener

I would like to use listener for onStopTrackingTouch() like SeekBar.OnSeekBarChangeListener.

Thanks!
Merged