SUMO-227719: added documentation for first set of webhook apps

Purpose of this pull request
This pull request (PR) ...
Issue number:

Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions and updating sections
[ ] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1205335280391015

@kimsauce, should we go ahead and publish this PR?


chore: Skip VALIDATE_LINKS at step level

Part of https://github.com/w3c/spec-prod/issues/5

Thanks @nschonni! This will clear the way for https://github.com/w3c/spec-prod/issues/5.


Sort plugin names in description

Plugin names in node description aren't sorted right now, this is a short change that sorts them and makes the output stable.
cc @stevvooe
Signed-off-by: Nishant Totla<EMAIL_ADDRESS>

[Current coverage][cc-pull] is 55.30%

Merging [#1172][cc-pull] into [master][cc-base-branch] will increase coverage by 0.02%

@@             master      #1172   diff @@
==========================================
  Files            77         77
  Lines         12100      12101     +1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6689       6692     +3
- Misses         4497       4498     +1
+ Partials        914        911     -3

[][cc-pull]

Powered by Codecov. Last updated by [86f2114...fa8c88e][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/swarmkit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/swarmkit/compare/86f21144f1aab43d7d79b4e28b50da03f4a26da7...fa8c88ef2cc1b497e3df44129dd0faf692f5f3ca?src=pr
[cc-pull]: https://codecov.io/gh/docker/swarmkit/pull/1172?src=pr

LGTM

@nishanttotla This has a few problems.
I also think we need to merge #1074 first.

@stevvooe good point, let me review #1074 again.

@nishanttotla #1074 has been merged. You'll have to rebase and sort pluginsField before setting it.

@stevvooe @dperny updated to sort by PluginDescription. PTAL.

LGTM after formatting nits.

@stevvooe addressed your comments.


[Access Request] page 976 "Time Sheet Archive Subform"

🕮 Describe the request
Could you please change the access scope of the following variable to protected?
protected var
    TimeSheetHeaderArchive: Record "Time Sheet Header Archive";

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 12340.


[DEV-2459] add transaction uid

Release Checklist
Pre-Release

[ ] Check migrations

No database related infos (sqldb-xxx)
Impact on GS (new/removed columns)

[ ] Check for linter errors (in PR)
[ ] Test basic user operations (on DFX services)

Login/logout
Buy/sell payment request
KYC page

Post-Release

Test basic user operations
Monitor application insights log

Add migration
Synchronize after merge


CodeBlockIterator does not extend iterator/iterable

Describe the bug
CodeBlockIterator cannot be used in for each loops as it does not properly implement Iterable

Why does this throw that exception but not the more commonly used iterators such as InstructionIterator?

Why does this throw that exception but not the more commonly used iterators such as InstructionIterator?

It is a good question.   Someone years ago thought it was more convenient to add the CancelledException to this interface.  The issue is that is presupposes the user of a TaskMonitor, which is not used in the interface.  This is a bit odd.   My personal feeling is that it was a mistake to add this exception to this interface.    However, it does not seem worth removing it at this point.
I have an addition coming to the interface that will allow it to implement the Iterable interface and thus be used in foreach loops.

Oh, you're going to take advantage of Iterator<T> iterator() and return one that doesn't throw aren't you? If so that's a pretty clever solution.

Why does this throw that exception but not the more commonly used iterators such as InstructionIterator?

The reason for CancelledException is the potential for long running computations for each step of the iterator.   The block determinations are not done up-front and are done as needed.  A TaskMonitor is supplied during the instantiation of the iterator from a block model providing a means of cancellation should a call to hasNext() run on for too long.  The exception allows for a distinction to be made between a successful completion of the iteration versus one that has failed to complete because it was cancelled.


When table cells are editable tab key does not move to next cell

This is the bug introduced by moving from version 6.8.6 to 6.9.0.
Describe the bug
When you have editable table, you want your TAB key to move your cursor to the next editable cell. This was behaving correctly up to 6.9.0. With 6.9.0 this was broken and now tab blurs away from the table (or something) instead of going to the next editable cell. This is bug in all following v6 versions.
To Reproduce
Steps to reproduce the behavior:

Go to https://codesandbox.io/s/react-table-editable-content-denb1
Click on an editable cell.
Press TAB key.
The cursor will not move to the next cell.

Expected behavior
Change dependency on 6.8.6 and try the same thing.
Desktop (please complete the following information):

OS: [Ubuntu 18]
Browser [Chrome]

Try the latest version of v6 6.10.1

This functionality is now working either on version 7.5.0

not working for me

@tannerlinsley Also not working here


Suppressor check for ARCCW not universal (multiplayer issue maybe)

The buff check for ARCCW silencers doesn't seem to work in multiplayer, reverb still plays as normal as if it wasn't silenced. Tested with Urban Coalition weapons if that's of any importance. Will attach a video later today.

Update: Found that Line 89 calls for the buff with weapon:GetBuff_Override instead of
wep:GetBuff_Override according to the ArcCW github page

Update: Found that Line 89 calls for the buff with weapon:GetBuff_Override instead of wep:GetBuff_Override according to the ArcCW github page

The "weapon" and "wep" variables hold the same weapon object.

Update: Found that Line 89 calls for the buff with weapon:GetBuff_Override instead of wep:GetBuff_Override according to the ArcCW github page

The "weapon" and "wep" variables hold the same weapon object.

My apologies. Also, I should have put in that it seems in game the suppressor check only works clientsided for the shooter(?) and other players will still hear the non-suppressed reverb.

This also applies to NPCs firing a suppressed ARCCW weapon.

https://github.com/modusmogulus/GmodDynamicWeaponReverb/assets/140112866/b28cd5d2-fafc-4fae-a052-9e6affe085e1


Add UNB & University of Toronto To Associate Members

Add UNB & University of Toronto To Associate Members, includes addition of logos.

@mgielda  the github action seems to have run 😄   but it looks like the preview link 404s 😦

@tgorochowik Thanks for the explanation! No need to do anything, I can be patient ;-)

@tgorochowik this OK to merge?

@bensternthal technically it works and renders correctly :) However I should not be the one to merge this as I am not fully up to date when it comes to members lists etc. Assuming you are now maintaining this, feel free to merge! Otherwise we probably need an ack from Michael or Rob?


Great Lakes Seaway Trail shield

The Great Lakes Seaway Trail is sort of the Lake Ontario equivalent of the Great Lakes Circle Tours. As a followup to #569, we should also add a shield for this route. The routes doesn't seem to appear in the data because there's no network tag.
https://en.wikipedia.org/wiki/Great_Lakes_Seaway_Trail
https://wiki.openstreetmap.org/wiki/Great_Lakes/Circle_Tour
https://www.openstreetmap.org/relation/13063934
I created a shield, but I'm now realizing there's a new sign. Not sure which design we should use.

Old
New

Ah, I like your take on the old shield, but I guess we should find out which shield is actually more prevalent in the wild these days. Sometimes it can take a while for new shield designs to get installed. For the new shield, it might be possible to omit a text legend, relying on the sweeping S curve to be recognizable.

The routes doesn't seem to appear in the data because there's no network tag.

Changeset 132,661,739 tags the relation as network=US:GLST.

Here's a design for the new shield.

No longer blocked:


ZoomIt [Request]: Stay in "type" mode when doing a left click :)

ZoomIt is fast. Pure love :). Here is a suggestion to make it faster
Scenario
User enters "type" mode and starts typing. Then the user wants to type somewhere else.
Problem
There is no official function that allows the user to reposition the cursor without leaving the "type" mode.
Workaround
Using the scroll wheel will release the cursor but ZoomIt will stay in "type" mode.
Suggestion
When in "type" mode

left click will release cursor but stay in type mode
right click will exit type mode

Type mode is intended as each block being a different "action" within ZoomIt. This new behavior would make things more complicated. Noted, but no promises!


How to get the product reviews and attributes like size, weight, color ?

Hi,
I want to get the product attributes like size, weight, color..... and also the reviews posted for the product.
How can i get that ?

I believe it's already inside the app in product data. Please clarify your question?

But the product data returns values in numbers and attribute codes

You can fetch attribute details by code with https://devdocs.magento.com/swagger/#/catalogProductAttributeRepositoryV1/catalogProductAttributeRepositoryV1GetGet

Thanks will try this!


iaf rl crash

https://mclo.gs/9LK7oti

Ice and Fire RLCraft Edition is extremely outdated and will not be supported by Just Enough Magiculture. Use either the original Ice and Fire: Dragons or Ice and Fire: RotN Edition.

Ice and Fire RLCraft Edition is extremely outdated and will not be supported by Just Enough Magiculture. Use either the original Ice and Fire: Dragons or Ice and Fire: RotN Edition.

rl version September 30, recently updated.
Just no Dragonsteel content.

Ice and Fire RLCraft Edition is extremely outdated and will not be supported by Just Enough Magiculture. Use either the original Ice and Fire: Dragons or Ice and Fire: RotN Edition.

Although I think that after the rl version update, there should be all the content, just no Dragonsteel.
If you think it's outdated, forget it.


Installing with deno add jsr:@nostr/tools returns an error

I just tried installing with deno 2.1.1 using the command
deno add jsr:@nostr/tools
But at the end of the installation I get the error:
Add jsr<EMAIL_ADDRESS>Warning The following packages contained npm lifecycle scripts (preinstall/install/postinstall) that were not executed:
┠─<EMAIL_ADDRESS>┠─<EMAIL_ADDRESS>┠─<EMAIL_ADDRESS>┃
┠─ This may cause the packages to not work correctly.
┠─ Lifecycle scripts are only supported when using a `node_modules` directory.
┠─ Enable it in your deno config file:
┖─ "nodeModulesDir": "auto"
error: Could not find dist-tag 'v0.1.0' for npm package 'nostr-wasm'.
    at https://jsr.io/@nostr/tools/2.10.3/wasm.ts:2:36

Note the error
error: Could not find dist-tag 'v0.1.0' for npm package 'nostr-wasm'.
    at https://jsr.io/@nostr/tools/2.10.3/wasm.ts:2:36

Weird is that though there is this error, somehow I can run the lib with no problems

Install it with npm:nostr-tools. The jsr build is broken.

Wouldnt it make sense to remove the instruciton on readme file
npx jsr add @nostr/tools
And also to clarify this on issue #376?
I got the idea of using JSR from there

It is not broken anymore. I have installed it with jsr add @nostr/tools many times, never encountering this error.
But I understand it now. The nostr-wasm version has a wrong v prefix and npm "fixes" that when downloading, but deno doesn't. Postel's law attacks again in all its stupidity. I'll fix this.


Inconsistencies in quadrat name

I notice issues in the quadrat names:
Quadrat 0101 has 3 different ways:

"01-01" (for one tag, 199999, in stem table- Was that tag a test tag @jess-shue? Note that it does not exist in the tree table)
101 in tree table
"0101"in stem table

This is only an issue because of this 199999 tag and if that was a test tag, that should resolve this issue.
If 19999 is not a test tag, then:

how come there is no 199999 in the tree table?
is there an easy way to make the quadrat names more consistent? Because we want only numbers, we may have to give up the leading zero.

(also I noticed that lx and ly are not getting populated for new stems withing a tree. is that normal? no worries if yes).

(I meant

101 in tree table
"0101"in stem table
and edited comment above)

@ValentineHerr

lx, ly will not be populated via the app.
I know of this problem with leading zero's and am trying to correct. This is an issue when adding data to Esri.
That was a test tree you may delete it
It seems that the recruits are all being added to the stem table and not the tree table. I'm not sure why this is happening. I have a new view almost ready. If my testing resolves this issue I'll swap it out (after discussing timing with David). However, I'm not sure this will alleviate the problem.

I think this is fixed now.
Unfortunately, that means that now a lot more quadrats are flagged on the map (the quadrat names of the shapefile were not matching with the quadrat names in the error file until now - for the ones with leading zeroes only).
So, the map does not look as good... But there is the same amount (or same type) of errors as discussed before.
Closing this issue


can not get correct params type when using Parameters to overloaded function

Bug Report
🔎 Search Terms

overloaded funciton
type
Parameters

⏯ Playground Link
https://www.typescriptlang.org/play?#code/LAKAlgdgLgpgTgMwIYGMYAIBiF0G9TroAUMAbjNAFzoDOUckA5gDToAOScSAtjQPzUkEAJ4BKaqQD2YACYFiZClBrUA2nQYQW6IcL4BdVfvHops0AF9QoKMLYZsABU48a6ALzpnXbjFhwaAB5sAD5QAHpwwkIAPT4gA
💻 Code

interface Fn {
  (event: string, params?: any): void
  (events: [string, any?][]): void
}

type FnParams = Parameters<Fn>
//    ^?

🙁 Actual behavior
only get last case's type.
🙂 Expected behavior
get all cases's type

Duplicate of https://github.com/microsoft/TypeScript/issues/43731.
This is a known (and documented) design limitation:
https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#inferring-within-conditional-types

When inferring from a type with multiple call signatures (such as the type of an overloaded function), inferences are made from the last signature (which, presumably, is the most permissive catch-all case). It is not possible to perform overload resolution based on a list of argument types.


Releases/0.11.x

This PR fixes #650 which can be nasty for users migrating from 0.10.x
It also disables cancelling an order, which is not eligible for cancellation.

Just one question: What about shops that already have migration 0007_notification applied? Is there anything we need to consider in that area to ensure data consistency?
Other than that, looks good to me.


Added possibility to restore a database backup.

Added possibility to restore a database backup and achieve the persistence of the restored database between restarts of the container and also in case the container was killed and recreated from scratch.

@Koubek,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@Koubek, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

Sorry for the delayed response @Koubek! We are currently working on a couple of bug fixes and we will merge this as soon we make sure everything works.
Thanks again!
Perry (MSFT)

@perrysk-msft Any news on this? I would like to see if this feature could be included (even in a different form, my one is just a proposal).
We usually receive backups of the databases from our customers, even we use as a starting point our internal backups. So it would be nice to have this possibility to restore the database but once restored use the restored version (attach the database) to continue working on the stuff that has been already modified.
In the standard container I need another instance to restore the database, prepare my files and then I can attach them to the container. So I would like to skip the intermediate step.
I would add this feature directly to another image we use (MS Dynamics NAV) but MS decided to switch from developer edition to the express and many times we have databases larger than 10 GBs. So I would need to create docker compose and host the database on the standard MSSQL image (container).
Thanks...
Jakub

It would be really cool to also have this be implemented for the Linux container option. If its just powershell scripts, perhaps they can be written as bash scripts for that usecase.

It would be really cool to also have this be implemented for the Linux container option. If its just powershell scripts, perhaps they can be written as bash scripts for that usecase.

I would also find this very useful. Right now the backup restore process is manual and cumbersome

This is only implemented for the express image. I think this should be implemented for developer image as well.

Maybe we will get a reply to "MS is being focused just on Linux support now and Windows containers here are pretty much dead" here: https://github.com/Microsoft/mssql-docker/issues/337

@perrysk-msft Did you have any plan to merge this PR as you say in 2017?


Add support for deploying rukpak on OperatorHub.io

Goal: enable users to deploy the rukpak stack on https://operatorhub.io/.
AC:

Follow the onboarding instructions detailed in https://operatorhub.io/contribute

This seems like a solid 0.5 candidate.
cc @joelanford @perdasilva

Discussed this a bit with @kevinrizza, it was not entirely clear whether this would be a big benefit.

Downstream users of rukpak on openshift would probably see it be installed via CVO manifests
Upstream users could install it the way they do currently, by applying the raw manifests

There is some potential gain in discoverability for the project if its on operatorhub, but its not super clear if its worth the effort.
Also, if any code in the project has to change to fit OLM's packaging model, then it would probably be a reason not to integrate it with OLM.  Not code to create the OLM bundle itself, but code around the API design and other conventions of rukpak.

A discussion in the rukpak grooming session resulted in us deciding to close this due to a lack of perceived value.


Get rid of all of the <DOCKER-EE-URL> references and just use an exported environment variable

File: engine/installation/linux/docker-ee/ubuntu.md, CC @mstanleyjones
This was done for RHEL but not Ubuntu
https://github.com/docker/docker.github.io/issues/4654

I did this and didn't remember that this issue was here to tag it! 🎉


etcdmain: invalid config errors don't respect --log-output flag value

Bug reporting
Noticed this when trying to use rkt to run etcd. Since rkt's default stage 1 sets up a systemd environment, etcd logs to journald. If I run it correctly using --log-output I get output, but if I provide invalid configuration, no output:
$ sudo rkt run coreos.com/etcd:v3.1.0 -- --listen-client-urls=http://<IP_ADDRESS>:2379 --log-output=stderr
stage1: warning: no volume specified for mount point "data-dir", implicitly creating an "empty" volume. This volume will be removed when the pod is garbage-collected.
stage1: warning: no volume specified for mount point "data-dir", implicitly creating an "empty" volume. This volume will be removed when the pod is garbage-collected.
$ echo $?
1

If I run this outside of rkt, I get this
$ etcd --listen-client-urls=http://<IP_ADDRESS>:2379 --log-output=stderr
2017-01-30 11:14:58.670515 E | etcdmain: error verifying flags, --advertise-client-urls is required when --listen-client-urls is set explicitly. See 'etcd --help'.
2017-01-30 11:14:58.670557 E | etcdmain: When listening on specific address(es), this etcd process must advertise accessible url(s) to each connected client.

It looks like etcd doesn't try to setup logging if a configuration is invalid[0]. On rkt this means invalid command line flags get sent to journald even though I specified "stderr".
cc @heyitsanthony
[0] https://github.com/coreos/etcd/blob/v3.1.0/etcdmain/etcd.go#L66-L75

@ericchiang I am not sure about this. I wont expect --log-output to be respected if a flag is invalid.  I do not think it worth the effort.
We can always log command line parsing error to stderr though, no matter what is specified in --log-output.
What do you think? @heyitsanthony

@xiang90 it's probably worth figuring out why rkt goes mute at some point; so long as the wrong arguments go in, it's silent

@ericchiang What's your rkt version?
/rkt version
rkt Version: 1.23.0
appc Version: 0.8.9
Go Version: go1.7.3
Go OS/Arch: linux/amd64
Features: -TPM +SDJOURNAL

For me, stderr outputs the expected errors?
sudo /rkt \
      run \
      --stage1-name coreos.com/rkt/stage1-fly:1.23.0 \
      --volume etcd-data-dir,kind=host,source=/var/lib/etcd \
      --mount volume=etcd-data-dir,target=/var/lib/etcd \
      quay.io/coreos/etcd:v3.1.0 -- \
      --listen-client-urls=http://<IP_ADDRESS>:2379 \
      --log-output=stderr

2017-01-31 19:20:32.053641 E | etcdmain: error verifying flags, --advertise-client-urls is required when --listen-client-urls is set explicitly. See 'etcd --help'.
2017-01-31 19:20:32.053673 E | etcdmain: When listening on specific address(es), this etcd process must advertise accessible url(s) to each connected client.

Old version. I guess rkt started defaulting to either disabling journald or printing the journald output?
$ rkt version
rkt Version: 1.19.0
appc Version: 0.8.8
Go Version: go1.7.3
Go OS/Arch: linux/amd64
Features: -TPM +SDJOURNAL

Closing since the rkt issue seems to have been fixed. However we still see a lot of funny-ness with etcd's journald integrations (e.g. https://github.com/coreos/bugs/issues/373). I know that's been discussed to death however, so I'll not rehash that issue here.


[IOTS-194] Failed Administrator login attempt WARN message gets printed for non admin user logins

Following warning gets printed when login into devicemgt with non admin users. to reproduce 1. signup and login to /devicemgt with a new user. TID: [-1234] [] [2016-06-01 11:37:17,860] WARN  {org.wso2.carbon.core.services.util.CarbonAuthenticationUtil} - Failed Administrator login attempt 'deviceadmin4[-1234]' at [2016-06-01 11:37:17,860+0000] {org.wso2.carbon.core.services.util.CarbonAuthenticationUtil}Reference: https://wso2.org/jira/browse/IOTS-194

Tested on the 3.1.0 cluster hence closing


mfa trusted poc on gauth

Issue
See also: https://groups.google.com/a/apereo.org/forum/?utm_medium=email&utm_source=footer#!topic/cas-user/1tQbjF8NEtI
When using JSON or in-memory storage, the mfaTrustEngine bean doesn't become available until after MFA provider configuration has completed, and thus trusted device registration never works.
I have the sense that the @RefreshScope decorator on the default mfaTrustEngine should be triggering an update in the MFA provider, but I don't know Spring well enough to prototype on that; input appreciated. As such, this PR is a POC demonstrating that requiring mfa-gauth configuration to occur after MultifactorAuthnTrustConfiguration allows trusted device registration to work as expected with a JSON backend.
Changes Applied

Added cas-server-support-trusted-mfa as dependency on gauth to allow access to package org.apereo.cas.trusted.config
Import MultifactorAuthnTrustConfiguration and flag gauth configuration with @AutoConfigureAfter(MultifactorAuthnTrustConfiguration

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks very much for the diagnosis and for following up with pull request. Nicely done.

Added cas-server-support-trusted-mfa as dependency on gauth to allow access to package org.apereo.cas.trusted.config

Unfortunately, while I understand the need for compile-time access, this change seems to force trusted-mfa functionality for the GAuth module, even if one has no need for that feature. This is expected to be pulled in. I have not tested this to be sure, but I am almost certain this is the case.

Import MultifactorAuthnTrustConfiguration and flag gauth configuration with @AutoConfigureAfter(MultifactorAuthnTrustConfiguration

Based on your description, I imagine any number of other MFA modules that have support for trusted-mfa are also affected by this, and so they need to also be fixed. Adding a dependency to each and every one of those, and fixing the auto-configuration order does not only scale, but it's nightmarish to maintain.
I like this solution much better:

...[modules] are either split: JSON/in-memory trusted device support out into another module that loads in the same way as the other backend modules, or use one of the existing modules. This is definitely a very confusing bug for people who are just trying to test things, though, so I don't like the latter.

It's not so bad. The change basically

says, all you have to do to test trusted-mfa functionality with JSON is to use:

implementation "org.apereo.cas:cas-server-support-trusted-mfa-json:${project.'cas.version'}"

instead of:
implementation "org.apereo.cas:cas-server-support-trusted-mfa:${project.'cas.version'}"

The adopter should never have to worry about org.apereo.cas:cas-server-support-trusted-mfa, and should not have to even care that if exists. This will be made purely into an internal module.

If nothing is defined, we shall use the in-memory functionality, which should be the default case without any changes any way.

I agree that JSON trusted device storage should probably be broken out into its own module for clarity. However, that would still leave memory storage totally nonfunctional. Of course, pulling in MFA trusted devices as a dependency for every MFA provider is out of the question, and I can see the scope creep inherent in managing autoconfiguration order manually.
Luckily, there is another way: @ConditionalOnClass(name = "org.apereo.cas.trusted.config.MultifactorAuthnTrustConfiguration"). On the whole this simply takes the place of the prior @ConditionalOnBean and allows us to ignore the order issue.
Do you foresee any issues with this approach? It does mean that the MFA trust configuration for the provider will almost certainly fire before mfaTrustEngine has been instantiated, but that doesn't seem to matter for the webflow configuration portion, from what I can see from testing anyway.

Pre-emptively patched the other MFA providers in case this is an acceptable solution.

I appreciate the effort. I am generally not a fan of referring to components by their fully-qualified name as a String. It makes it difficult to refactor and move around stuff in the future, and such things generally do not end up in semantic search results in development environments. That said, this is a perfectly adequate approach for now and there is precedence for using this strategy in the codebase already for similar things. So, I think what you have here is a good solution. I will run some tests to validate the setup in the patch, and then we should be good to merge. I will let you know as soon as possible, and certainly before the coming weekend.
Thanks again.

Thank you, and thank you also for your continuous efforts on this project.
I'm planning on doing some preliminary development work in the MFA area in the near future, so I'm happy to have a pass at factoring out the JSON storage into a separate module. Having that working would certainly make this patch less relevant.

I had a look at this, and I think I have found a small improvement to your proposal that is more type-safe and possibly easier to maintain.
Your original solution to do this, is fine:
@ConditionalOnClass(value = MultifactorAuthnTrustConfiguration.class)

Then, to the build file of module using that change, you want to add:
compileOnly project(":support:cas-server-support-trusted-mfa")

instead of:
implementation project(":support:cas-server-support-trusted-mfa")

This will allow the us to keep track of the configuration class in a type-safe way, and track the module that owns it via the build and dependency management. Both of these things are favorable to a conditional based on a String or class-name.
Apologies for not having suggested this originally. Please review and apply, and we should be good to merge.
Thanks again.

This is definitely the best option so far, so I'm just glad it's come up. Cheers!


Autonomous updates from Tuesday 11/21/23 team meeting

LEFT & MIDDLE auto working for blue back
Vision working more reliably

@gwarby  this Pull Request includes the merges of the other 2 pull requests.  We can close those PRs without merging, as merging this PR will get all of the history & content onto main.
Also, I don't currently have write access to this repo in order to make commits and help with the merges.


Updated slime storage capacity text in guidebook

Guidebook currently says 2x2 for slime internal storage, it is now 2x3

I assume that now that it's merged it's also to late to fix this since it's no longer a thing?


Add implementation of NicConfigurationTemplate reconciler

This reconciler is getting a list of NicDevice matching the selectors and applies the template spec to them

@almaslennikov  can you rebase this one ?

@almaslennikov can you rebase this one ?

done

please add controller test to cover the added logic.

By a freaky accident with rebasing, the utests disappeared. git reflog to the rescue, however, and now they're back!

Closed by mistake, reopened #12


Not Detecting TableViews

I have added Hyperion and mentioned three plugins to the app and I can see all the three plugins when i shake the phone , I am able to measure and inspect everything outside of UItableview like Navigation bar etc but I am not able to inspect anything inside UITableView, on which ever row I clicks is shows attributes for table view instead of cells. Is there any setting required to make table view work

Hey Ajay, welcome and thanks for submitting an issue. TableViews should work correctly, which leads me to believe we might have a bug in our view selection logic. If you press and hold on the TableViewCell  while in the measurements tool or attributes inspector, after about 2 seconds a popover should appear with a list of views that are underneath your finger. Can you tell me if the tableviewcells or any of it’s sub views show up in that list? Also, if you can provide me with a project where you can reproduce this issue, I would be happy to take a look!

It is showing like this not the actual measurements

I cannot share the project because it is an enterprise application

It looks like a view of type _UINavigationControllerPaletteClippingView is blocking your ViewController. I did some research and this looks like an iOS 11 specific view.  Until I can get a fix out my current recommendation is to use that menu to select views (if you tap on a cell, it will select the view associated with it). I am projecting to have a fix out this weekend. Thanks for reporting this!
More Info Here:
http://developer.limneos.net/?ios=11.0&framework=UIKit.framework&header=_UINavigationControllerPaletteClippingView.h

@ajaybeniwal Can you tell me what iOS version you are running and whether it is an issue on simulator and device? I'm trying to pinpoint why this would be happening.


Add compress message option for users

Describe the pull request
I was getting tired of the responses from bots taking so much space in the chat rooms. So I decided that I wanted to add an option to YaTA which allowed the user to compress messages from certain users. If the user wants to see the full message they can click the compressed message and the message is expanded to its original size.
To activate the compression press the hamburger menu and click enable message compression. If the feature is active for the selected user the button disable message compression will be shown instead.
Why
Because I felt like adding this feature to YaTA. Trying to improve perfection :angel:
How
Some new actions have been added which change the state of the message. A new message property has been added to see if this message currently is compressed. Some changes were made to the database to keep track of which user ids the message needs to be compressed by default.
Also a big shoutout to RomaniaHate on Twitch for helping me with the React/Redux stuff.
Screenshots

Possible future improvements

Specify if the user should be globally compressed across all channels or just for this channel
Option to see the message on hover without having to expand the message
Make a special menu where the user selection for this system can be easily set

Thanks for the PR 😄
On top of the code review, here are my more general comments:
1. Decompress
Not sure if it's just me or not, but decompress feels weird. When quickly googling for it, found this website mentioning decompress is to relieve the pressure or compression on something and uncompress is to restore a compressed file to its normal size.
Kinda feels like we should go for uncompress. I didn't point out all the occurrences in the code review (around 16 occurrences).
2. Mechanism
I don't feel like all messages should be compressed even if the user is someone in the "compressed list".

For example, in this screenshot, only the second message which spans over 2 lines should be compressed.
Regarding the compression itself, I don't feel like all the content of the message should be replaced with dots. We should only do an ellipsis on the cutting point using the … character (or maybe find another more visual way to indicate the message is compressed, not sure).
In the previous screenshot, if we go with only the … character and an ellipsis, the second message should then be:

This is a second test message for nDoorn93 pull…

An interesting issue with this approach tho is how to handle properly the responsiveness when someone is for example resizing its window involving messages that should (or are) compressed.
3. Cursor
When having your cursor on a compressed message, we should use a different type of cursor to indicate the click action to uncompress the message (totally missed that before checking the code).
We should also add a tooltip (an alt may be enough tho) with something like Click to uncompress - followed either by a preview of the compressed message or the entire message maybe.
4. Settings
This feature needs its own settings otherwise you can't use it (add/remove people) without a message from said users.
Altho, the current UI for the settings is totally full and we have no room to add a new settings page. I've started a redesign of the settings which should add more room for various settings sections. When I have the time to finish this, we should update this PR to use it and add proper settings dedicated to this feature.
(blocked until new settings UI is finished)
5. Context menu
I feel like the context menu entry should be between <Menu.Item icon="envelope" text="Whisper" onClick={this.onClickWhisper} /> and <Menu.Divider /> as its related to the user.
Regarding the name of the menu entries, feels a bit long, what about Compress messages and Uncompress messages?
6. Instant feedback
Enabling compression on a message doesn't compress the previous messages so there is no feedback to the action. We should compress previous messages from the user.
Same goes for uncompressing of course.
7. Linting
As mentioned in the code review, looks like there is something wrong with Prettier & the linting process in this PR, I'll fix this so we can later update this PR and re-run the linting process on it.

Thank you for the very clear explanation of what can be improved for this PR. Once I have some time I will start on processing your requests and will update the PR accordingly.
Feature design
This feature was based on my own design meaning that there was no input from other designers perspective on how the feature should work. So thank you for describing your design wishes. Maybe an setting would be nice on how the message should be compressed, a couple of options would be to compress the full message which is the current implementation. A second option would be your requested implementation where you can see the first part of the message until a new line is hit and if new ideas arise for new options those ideas can be added to this list as well.
Settings menu
My thought was also to put this in the settings menu but since the settings menu was full I instead put the option to toggle the compress/uncompress feature in the message itself. I did see this as a point for improvement which I totally agree with you on that.
Until the new settings menu is in place I will probably leave the option in the message menu or might show a modal for setting up the compress configuration for that specific user.

Maybe an setting would be nice on how the message should be compressed, a couple of options would be to compress the full message which is the current implementation. A second option would be your requested implementation where you can see the first part of the message until a new line is hit and if new ideas arise for new options those ideas can be added to this list as well.

That's also a possibility if you're up for it altho I think the default option should be the one I mentioned.

My thought was also to put this in the settings menu but since the settings menu was full I instead put the option to toggle the compress/uncompress feature in the message itself.

The menu addition is great, we do that already for things that have their own settings section, but it's only a bonus as it requires a message to use it.

Until the new settings menu is in place I will probably leave the option in the message menu

Definitely leave it, it's neat 👍

might show a modal for setting up the compress configuration for that specific user.

Don't bother creating a custom thing, we'll add once the settings when there is more room in the settings modal and ship it properly.
I should have more time this time of the year to work on this project so the new UI for the settings shouldn't take long to finish.

The master branch has been updated and now contains a fix that should highlight the linting issues in the PR that I mentioned in the code review which were not failing earlier.

The master branch has also been updated to contain a new UI for the settings as discussed earlier. There is an empty slot for the new panel needed for this PR and will also make it easier in the future to add more panels.

Not sure yet where the new panel section will fit, its title & icon but that's something we can tweak later on, even after this PR is merged.

Just saw that GitHub auto-closed this PR when I renamed the master branch to main, which is weird as they're supposed to re-target any open pull requests ^^
Feel free to re-open if you ever come back to this.


Can't save navigation link changes

Issue Summary
Can't save navigation changes. Ghost api settings returns 404. "Problem finding setting: cover_image"
  ERROR [2017-04-26 14:39:38] "PUT /ghost/api/v0.1/settings/" 404 59ms   NAME: NotFoundError   MESSAGE: Problem finding setting: cover_image
Steps to Reproduce

Go to Design tag
Make changes or add navigation tabs
Save changes
Error message shown "Problem finding setting: cover_image"

Technical details:

Ghost Version: 1.0.0-alpha20
Node Version: 7.9.0
Browser/OS:  Chrome 57 / macOS 10.12.4
Database: development (sqlite)

Hey @gomesphoto 😎
Thanks for testing the alpha version 👋
1.0.0-alpha.20 contains breaking database changes. We have renamed a couple of schema properties. If you reset your database, it should work again. If you have any further questions, come say hello on slack.


Use trusted.gpg.d instead of apt-key

Problem description
One of the steps at https://docs.docker.com/engine/install/ubuntu/#install-using-the-repository is to add Docker’s official GPG key like this:
$ curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo apt-key add -

However, the last part generates the following warning (at least on Ubuntu 20.10):

Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).

Maybe it is time to use trusted.gpg.d as suggested by the warning?

Same here

I'm experiencing the same issue, with the additional problem that when I try to manually add the gpg file to /etc/apt/trusted.gpg.d/docker.gpg and then run sudo apt update I get this error:
The key(s) in the keyring /etc/apt/trusted.gpg.d/docker.gpg are ignored as the file has an unsupported filetype.

...with of course loads of other errors from not having a valid key.

This worked for me
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo apt-key --keyring /etc/apt/trusted.gpg.d/docker-apt-key.gpg add
Also, if you are using groovy , you should try focal instead.

Hi @devs-saifur-rahman, thanks for this tip. I was stuck in the same point and it helped me to progress with the install. This may be a good update to be done in the docs.

apt-key is deprecated and will not be available after Debian 11 / Ubuntu 22.04
Although adding keys directly to /etc/apt/trusted.gpg.d/ is suggested by apt-key deprecation message, as per Debian Wiki GPG keys for third party repositories should be added to /usr/share/keyrings and referenced with the signed-by option in the source.list.d entry.
ADD A KEY
# Adding an ASCII Armored key (.asc key)
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | \
gpg --dearmor | \
sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > \
/dev/null

# Or if you prefer a one-liner
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | gpg --dearmor | sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > /dev/null

# Breakdown of each part
#
# curl             downloads the key
# gpg --dearmor    creates a binary .gpg because /usr/share/keyrings cannot take .asc keys
# sudo tee         because we get permission denied if we try redirect the output of a sudo command
# /dev/null        we don't need to see the dearmored keyring on the console

ADD REPOSITORY AS A SOURCE IN /etc/apt/sources.list.d/
#
echo \
"deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | \
sudo tee /etc/apt/sources.list.d/docker-ce.list > \
/dev/null

# Of if you prefer a one-liner
echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker-ce.list > /dev/null

With the above in place, you're ready for the transition away from apt-key to whatever will come next, with the added bonus of Debian's security best practices. :)

@denis-roy, are these commands same for Debian distribution as well..? [just by replacing ubuntu => debian]
Facing the same issue, while trying to install docker
sorry if it sounds too stupid, I'm new to Docker.

apt-key is deprecated and will not be available after Debian 11 / Ubuntu 22.04
Although adding keys directly to /etc/apt/trusted.gpg.d/ is suggested by apt-key deprecation message, as per Debian Wiki GPG keys for third party repositories should be added to /usr/share/keyrings and referenced with the signed-by option in the source.list.d entry.
ADD A KEY
# Adding an ASCII Armored key (.asc key)
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | \
gpg --dearmor | \
sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > \
/dev/null

# Or if you prefer a one-liner
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | gpg --dearmor | sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > /dev/null

# Breakdown of each part
#
# curl             downloads the key
# gpg --dearmor    creates a binary .gpg because /usr/share/keyrings cannot take .asc keys
# sudo tee         because we get permission denied if we try redirect the output of a sudo command
# /dev/null        we don't need to see the dearmored keyring on the console

ADD REPOSITORY AS A SOURCE IN /etc/apt/sources.list.d/
echo \
"deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | \
sudo tee /etc/apt/sources.list.d/docker-ce.list > \
/dev/null

# Of if you prefer a one-liner
echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker-ce.list > /dev/null

With the above in place, you're ready for the transition away from apt-key to whatever will come next, with the added bonus of Debian's security best practices. :)

@denis-roy, are these commands same for Debian distribution as well..? [just by replacing ubuntu => debian]
Facing the same issue, while trying to install docker
sorry if it sounds too stupid, I'm new to Docker.

apt-key is deprecated and will not be available after Debian 11 / Ubuntu 22.04
Although adding keys directly to /etc/apt/trusted.gpg.d/ is suggested by apt-key deprecation message, as per Debian Wiki GPG keys for third party repositories should be added to /usr/share/keyrings and referenced with the signed-by option in the source.list.d entry.
ADD A KEY
# Adding an ASCII Armored key (.asc key)
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | \
gpg --dearmor | \
sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > \
/dev/null

# Or if you prefer a one-liner
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | gpg --dearmor | sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > /dev/null

# Breakdown of each part
#
# curl             downloads the key
# gpg --dearmor    creates a binary .gpg because /usr/share/keyrings cannot take .asc keys
# sudo tee         because we get permission denied if we try redirect the output of a sudo command
# /dev/null        we don't need to see the dearmored keyring on the console

ADD REPOSITORY AS A SOURCE IN /etc/apt/sources.list.d/
echo \
"deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | \
sudo tee /etc/apt/sources.list.d/docker-ce.list > \
/dev/null

# Of if you prefer a one-liner
echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker-ce.list > /dev/null

With the above in place, you're ready for the transition away from apt-key to whatever will come next, with the added bonus of Debian's security best practices. :)

@vieee, the procedure is the same for Debian 9 (Stretch) / Ubuntu 16.04 (Xenial) onward. For more information, refer to PR #11990
Here are the commands you need to execute to install Docker on Debian.
:warning: Make sure you copy paste the commands, we are all prone to typos! :)
INSTALLING DEPENDENCIES
sudo apt-get install apt-transport-https ca-certificates curl gnupg-agent

ADDING THE KEY
curl -fsSL https://download.docker.com/linux/debian/gpg | gpg --dearmor \
| sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > /dev/null

ADDING THE REPOSITORY
echo \
"deb [arch=amd64 signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] \
https://download.docker.com/linux/debian $(lsb_release -cs) stable" \
| sudo tee /etc/apt/sources.list.d/docker-ce.list > /dev/null

UPDATING APT & INSTALLING DOCKER
sudo apt-get update
sudo apt-get install docker-ce docker-ce-cli containerd.io

@vieee, the procedure is the same for Debian 9 (Stretch) / Ubuntu 16.04 (Xenial) onward. For more information, refer to PR #11990
Here are the commands you need to execute to install Docker on Debian.
:warning: Make sure you copy paste the commands, we are all prone to typos! :)
INSTALLING DEPENDENCIES
sudo apt-get install apt-transport-https ca-certificates curl gnupg-agent

ADDING THE KEY
curl -fsSL https://download.docker.com/linux/debian/gpg | gpg --dearmor \
| sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > /dev/null

ADDING THE REPOSITORY
echo \
"deb [arch=amd64 signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] \
https://download.docker.com/linux/debian $(lsb_release -cs) stable" \
| sudo tee /etc/apt/sources.list.d/docker-ce.list > /dev/null

UPDATING APT & INSTALLING DOCKER
sudo apt-get update
sudo apt-get install docker-ce docker-ce-cli containerd.io

What group of fools decided to deprecate something without first having a replacement or even a suggested replacement, or EVEN DOCUMENTING THIS HORSESHIT????

What group of fools decided to deprecate something without first having a replacement or even a suggested replacement, or EVEN DOCUMENTING THIS HORSESHIT????

@AkashicSeer, deprecated means you can still use the tool but its usage is discouraged. The way Debian has decided to deal with third-party keys and repositories is well documented in their Wiki.
The apt-key tool will only disappear in a version due to be released somewhere around April 2022. When this time comes, nothing is stopping you to stick with the previous OS version for as long as you wish and carry on using apt-key for as long as you wish.
Simply put: There is plenty of time to comply.
The group of fools you are referring to is a large body of able open source developers who work mostly without pay to provide the world with a free operating system that anybody, and that includes you, is at complete liberty to use... Or not.
If you feel you can contribute ideas or code towards a better way to manage third-keys and repository, as we say in the open source word: Pull Requests are welcome

@AkashicSeer, deprecated means you can still use the tool but its usage is discouraged. The way Debian has decided to deal with third-party keys and repositories is well documented in their Wiki.
The apt-key tool will only disappear in a version due to be released somewhere around April 2022. When this time comes, nothing is stopping you to stick with the previous OS version for as long as you wish and carry on using apt-key for as long as you wish.
Simply put: There is plenty of time to comply.
The group of fools you are referring to is a large body of able open source developers who work mostly without pay to provide the world with a free operating system that anybody, and that includes you, is at complete liberty to use... Or not.
If you feel you can contribute ideas or code towards a better way to manage third-keys and repository, as we say in the open source word: Pull Requests are welcome

To install Docker for Kali run the following:
curl -fsSL https://download.docker.com/linux/debian/gpg | gpg --dearmor | sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > /dev/null
then:

echo 'deb [arch=amd64] https://download.docker.com/linux/debian buster stable' | sudo tee /etc/apt/sources.list.d/docker.list

sudo apt-get update

sudo apt-get install docker-ce

To install Docker for Kali run the following:
curl -fsSL https://download.docker.com/linux/debian/gpg | gpg --dearmor | sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > /dev/null
then:

echo 'deb [arch=amd64] https://download.docker.com/linux/debian buster stable' | sudo tee /etc/apt/sources.list.d/docker.list

sudo apt-get update

sudo apt-get install docker-ce

@Pema-Sereka, hardcoding amd64 and buster might work for you but will fail for those who try to install Docker on a  x68 or armel/armhf distribution of Kali
Evaluating $(dpkg --print-architecture) and $(lsb_release -cs) in the following command ensures a wider coverage :)
echo \
"deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] \
https://download.docker.com/linux/debian $(lsb_release -cs) stable" \
| sudo tee /etc/apt/sources.list.d/docker-ce.list > /dev/null

@Pema-Sereka, hardcoding amd64 and buster might work for you but will fail for those who try to install Docker on a  x68 or armel/armhf distribution of Kali
Evaluating $(dpkg --print-architecture) and $(lsb_release -cs) in the following command ensures a wider coverage :)
echo \
"deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] \
https://download.docker.com/linux/debian $(lsb_release -cs) stable" \
| sudo tee /etc/apt/sources.list.d/docker-ce.list > /dev/null

@denis-roy,
Yeah, sure. I had tried all but failed but when I hard coded for Kali debian 2020.1 amd64 it worked. I just was offering a solution to the reported error which was similar to what I had.

@denis-roy,
Yeah, sure. I had tried all but failed but when I hard coded for Kali debian 2020.1 amd64 it worked. I just was offering a solution to the reported error which was similar to what I had.

@denis-roy Apparently the dependency of GnuPG (gnupg-agent) is unnecessary. You can do this:
curl -fsSL https://download.docker.com/linux/debian/gpg \
| sudo tee /usr/share/keyrings/docker-ce-archive-keyring.asc > /dev/null

Note the file extension .asc for ASCII-format (“armored” in GnuPG term) key file. Of course the source.list should be updated correspondingly. This is tested on Debian Buster; didn’t test on Ubuntu though.

curl -fsSL https://download.docker.com/linux/ubuntu/gpg | gpg --dearmor | sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > /dev/null

If you're killing the output to stdout that tee generates, then you shouldn't be using tee at all. Also, for user installed packages (not distribution controlled packages), you shouldn't be using /usr/share/.... You should either be using /etc/... or /usr/local/....
Something like:
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor > /etc/apt/trusted.gpg.d/docker-ce-archive-keyring.gpg

should do the trick. Fewer fork/execs, fewer redirections, less entropy consumed in the system overall, removed a call for a program that you're "neutering" etc. One should always strive to consume fewer computing resources and this "ancient art" should never be disregarded, despite computers being "fast enough".

With the above in place, you're ready for the transition away from apt-key to whatever will come next, with the added bonus of Debian's security best practices. :)

Not so fast to claim "best practices" (especially grabbing stuff automatically from a site and feeding it blindly through a program). But I won't elaborate anymore on this to avoid well-known discussions.
Regards, Rogério Brito.
P.S.: I'm very partial to using sudo and/or installing stuff with curl/wget etc. and/or not using the trust chain that the distributions give you (putting my Debian maintainer hat on), but those are issues that only the end user knows how to balance.

If you're killing the output to stdout that tee generates, then you shouldn't be using tee at all. Also, for user installed packages (not distribution controlled packages), you shouldn't be using /usr/share/.... You should either be using /etc/... or /usr/local/....
Something like:
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor > /etc/apt/trusted.gpg.d/docker-ce-archive-keyring.gpg

should do the trick. Fewer fork/execs, fewer redirections, less entropy consumed in the system overall, removed a call for a program that you're "neutering" etc. One should always strive to consume fewer computing resources and this "ancient art" should never be disregarded, despite computers being "fast enough".

That's unlikely to work, because sudo has no effect on redirections. The redirection happens in the current shell before sudo is invoked. It will only "work" if the current user already has the right permissions to write to the file. If you need sudo for it, you have to use tee.
$ echo 'whatever' >> root_only/file -ash: can't create root_only/file: Permission denied $ sudo echo 'whatever' >> root_only/file -ash: can't create root_only/file: Permission denied

I think the correct way is:
$ sudo touch /etc/apt/trusted.gpg.d/docker.gpg
$ curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --no-default-keyring --keyring /etc/apt/trusted.gpg.d/docker.gpg --import -

I think it's worth mentioning that expecting users to rely on google searches and trawl through convoluted github issues just to perform a default install of your product is a comically large lapse of security.

@denis-roy
Copying and pasting your instructions in Ubuntu 20.10 gave me the following output:
➜  ~ curl -fsSL https://download.docker.com/linux/debian/gpg | gpg --dearmor \
| sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > /dev/null

➜  ~ echo \
"deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] \
https://download.docker.com/linux/debian $(lsb_release -cs) stable" \
| sudo tee /etc/apt/sources.list.d/docker-ce.list > /dev/null
➜  ~ sudo apt-get update
Hit:1 http://us.archive.ubuntu.com/ubuntu groovy InRelease
Hit:2 https://deb.nodesource.com/node_15.x groovy InRelease
Hit:3 http://us.archive.ubuntu.com/ubuntu groovy-updates InRelease
Ign:4 https://download.docker.com/linux/debian groovy InRelease
Hit:5 http://security.ubuntu.com/ubuntu groovy-security InRelease
Ign:6 http://ppa.launchpad.net/gnome-terminator/ppa/ubuntu groovy InRelease
Hit:7 http://us.archive.ubuntu.com/ubuntu groovy-backports InRelease
Hit:8 https://download.sublimetext.com apt/stable/ InRelease
Err:9 https://download.docker.com/linux/debian groovy Release
  404  Not Found [IP: <IP_ADDRESS> 443]
Err:10 http://ppa.launchpad.net/gnome-terminator/ppa/ubuntu groovy Release
  404  Not Found [IP: <IP_ADDRESS> 80]
Hit:11 http://dl.google.com/linux/chrome/deb stable InRelease
Reading package lists... Done
E: The repository 'https://download.docker.com/linux/debian groovy Release' does not have a Release file.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
E: The repository 'http://ppa.launchpad.net/gnome-terminator/ppa/ubuntu groovy Release' does not have a Release file.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
➜  ~ sudo apt-get install docker-ce docker-ce-cli containerd.io
Reading package lists... Done
Building dependency tree
Reading state information... Done
Package docker-ce is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'docker-ce' has no installation candidate
E: Unable to locate package docker-ce-cli
E: Unable to locate package containerd.io
E: Couldn't find any package by glob 'containerd.io'
E: Couldn't find any package by regex 'containerd.io'
➜  ~

As stated earlier, the proposal comes from the Debian Wiki, not from me :)
@FranklinYu - They go with binary signatures (.gpg) instead of ASCII Armored ones (.asc) to avoid some error vectors and to maintain interoperability with SecureAPT which requires .gpg sigs
@jinliming2 - There are plenty of acceptable ways to deal with this, I just chose the most standard, Debian-compliant way I could find
For further discussions, visit PR #11990

@denis-roy
Cutting and pasting your instructions above fail with the same error on Ubuntu 20.10 and a brand new install of Ubuntu 20.04 LTS. Here is my output from 20.04:
jon@Ubuntu-Fossa:~/Desktop$ sudo apt-get install apt-transport-https ca-certificates curl gnupg-agent
Reading package lists... Done
Building dependency tree
Reading state information... Done
ca-certificates is already the newest version (20210119~20.04.1).
curl is already the newest version (7.68.0-1ubuntu2.4).
apt-transport-https is already the newest version (2.0.4).
gnupg-agent is already the newest version (2.2.19-3ubuntu2.1).
0 upgraded, 0 newly installed, 0 to remove and 7 not upgraded.
jon@Ubuntu-Fossa:~/Desktop$ curl -fsSL https://download.docker.com/linux/debian/gpg | gpg --dearmor | sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > /dev/null
jon@Ubuntu-Fossa:~/Desktop$ echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] https://download.docker.com/linux/debian $(lsb_release -cs) stable"| sudo tee /etc/apt/sources.list.d/docker-ce.list > /dev/null
jon@Ubuntu-Fossa:~/Desktop$ sudo apt-get update
Hit:1 http://dl.google.com/linux/chrome/deb stable InRelease
Hit:2 http://us.archive.ubuntu.com/ubuntu focal InRelease
Hit:3 http://us.archive.ubuntu.com/ubuntu focal-updates InRelease
Ign:4 https://download.docker.com/linux/debian focal InRelease
Hit:5 http://us.archive.ubuntu.com/ubuntu focal-backports InRelease
Get:6 http://security.ubuntu.com/ubuntu focal-security InRelease [109 kB]
Hit:7 https://download.sublimetext.com apt/stable/ InRelease
Err:8 https://download.docker.com/linux/debian focal Release
  404  Not Found [IP: <IP_ADDRESS> 443]
Reading package lists... Done
E: The repository 'https://download.docker.com/linux/debian focal Release' does not have a Release file.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
jon@Ubuntu-Fossa:~/Desktop$ sudo apt-get install docker-ce docker-ce-cli containerd.io
Reading package lists... Done
Building dependency tree
Reading state information... Done
Package docker-ce is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'docker-ce' has no installation candidate
E: Unable to locate package docker-ce-cli
E: Unable to locate package containerd.io
E: Couldn't find any package by glob 'containerd.io'
E: Couldn't find any package by regex 'containerd.io'

@Jon-Biz From the look of it, you are trying to follow Debian's installation procedure on Ubuntu.
E: The repository 'https://download.docker.com/linux/debian focal Release' does not have a Release file.

There is no release of Debian named focal. Debian release names (buster, sid, etc) and Ubuntu release names (groovy, focal, etc) don't mix :)
Following the installation procedure for Ubuntu will undoublty yield the desired results:
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | gpg --dearmor -o /usr/share/keyrings/docker-ce-archive-keyring.gpg

echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker-ce.list > /dev/null

or you could very well just edit the source directly:
nano /etc/apt/sources.list.d/docker-ce.list

to replace debian by ubuntu, save, close and then run apt update again

Thank you for your reply. I have resolved my problems.
Fwiw, attempting to add the docker-ce-archive-keyring.gpg to my keyrings directory failed with a 'Permission denied' error. I was able to resolve this by sudo ing gpg:
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /usr/share/keyrings/docker-ce-archive-keyring.gpg

They go with binary signatures (.gpg) instead of ASCII Armored ones (.asc) to avoid some error vectors and to maintain interoperability with SecureAPT which requires .gpg sigs

@denis-roy Would you mind sharing more about this? The only place I found about the requirement is a very brief note at DebianRepository/UseThirdParty; I can’t find the relevant description at the SecureApt page.
By the way, I tried the armored file on my virtual machine (Debian Buster), and APT didn’t complain. Is SecureApt opt-in?

@FranklinYu, unfortunately I estimate my understanding to be limited to a little more than what is mentioned in that DebianRepository/UseThirdParty Wiki and wouldn't want to mislead you. You might want to open a discussion or take part in an already open one on that specific Debian Wiki though :)

@vieee, the procedure is the same for Debian 9 (Stretch) / Ubuntu 16.04 (Xenial) onward. For more information, refer to PR #11990
Here are the commands you need to execute to install Docker on Debian
Make sure you copy paste the commands, we are all prone to typos! :)
INSTALLING DEPENDENCIES
sudo apt-get install apt-transport-https ca-certificates curl gnupg-agent

ADDING THE KEY
curl -fsSL https://download.docker.com/linux/debian/gpg | gpg --dearmor \
| sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > /dev/null

ADDING THE REPOSITORY
echo \
"deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-ce-archive-keyring.gpg] \
https://download.docker.com/linux/debian $(lsb_release -cs) stable" \
| sudo tee /etc/apt/sources.list.d/docker-ce.list > /dev/null

UPDATING APT & INSTALLING DOCKER
sudo apt-get update
sudo apt-get install docker-ce docker-ce-cli containerd.io

──(root💀localhost)-[~]
└─# sudo apt-get update
sudo apt-get install docker-ce docker-ce-cli containerd.io
E: Conflicting values set for option Signed-By regarding source https://download.docker.com/linux/debian/ kali-rolling: /usr/share/keyrings/docker-ce-archive-keyring.gpg !=
E: The list of sources could not be read.
E: Conflicting values set for option Signed-By regarding source https://download.docker.com/linux/debian/ kali-rolling: /usr/share/keyrings/docker-ce-archive-keyring.gpg !=
E: The list of sources could not be read.
E: Conflicting values set for option Signed-By regarding source https://download.docker.com/linux/debian/ kali-rolling: /usr/share/keyrings/docker-ce-archive-keyring.gpg !=
E: The list of sources could not be read.

──(rootskulllocalhost)-[~]
└─# sudo apt-get update
sudo apt-get install docker-ce docker-ce-cli containerd.io
E: Conflicting values set for option Signed-By regarding source https://download.docker.com/linux/debian/ kali-rolling: /usr/share/keyrings/docker-ce-archive-keyring.gpg !=
E: The list of sources could not be read.
E: Conflicting values set for option Signed-By regarding source https://download.docker.com/linux/debian/ kali-rolling: /usr/share/keyrings/docker-ce-archive-keyring.gpg !=
E: The list of sources could not be read.
E: Conflicting values set for option Signed-By regarding source https://download.docker.com/linux/debian/ kali-rolling: /usr/share/keyrings/docker-ce-archive-keyring.gpg !=
E: The list of sources could not be read.

@cm038, kali-rolling is not a valid debian release name ;)
Kali's rolling release is most likely based on Debian Testing which release names are buster or bullseye

──(rootskulllocalhost)-[~]
└─# sudo apt-get update
sudo apt-get install docker-ce docker-ce-cli containerd.io
E: Conflicting values set for option Signed-By regarding source https://download.docker.com/linux/debian/ kali-rolling: /usr/share/keyrings/docker-ce-archive-keyring.gpg !=
E: The list of sources could not be read.
E: Conflicting values set for option Signed-By regarding source https://download.docker.com/linux/debian/ kali-rolling: /usr/share/keyrings/docker-ce-archive-keyring.gpg !=
E: The list of sources could not be read.
E: Conflicting values set for option Signed-By regarding source https://download.docker.com/linux/debian/ kali-rolling: /usr/share/keyrings/docker-ce-archive-keyring.gpg !=
E: The list of sources could not be read.

@cm038, kali-rolling is not a valid debian release name ;)
Kali's rolling release is most likely based on Debian Testing which release names are buster or bullseye

Thanks for your comment. There is an error somewhere but unfortunately I cannot get it resolved. I am using termux on android 11 and when entering apt-get update i get the following errors;
─(root💀localhost)-[~]
└─# apt-get update                                                                      Hit:1 https://download.docker.com/linux/ubuntu xenial InRelease
Ign:2 https://download.docker.com/linux/ubuntu kali-rolling InRelease
Ign:3 https://download.docker.com/linux/debian kali-rolling InRelease
Hit:4 https://download.docker.com/linux/ubuntu bionic InRelease
Hit:5 https://download.docker.com/linux/ubuntu artful InRelease
Hit:6 https://download.docker.com/linux/debian buster InRelease
Err:7 https://download.docker.com/linux/ubuntu kali-rolling Release
404  Not Found [IP: <IP_ADDRESS> 443]
Err:9 https://download.docker.com/linux/debian kali-rolling Release
404  Not Found [IP: <IP_ADDRESS> 443]
Hit:8 https://ftp2.nluug.nl/os/Linux/distr/kali kali-rolling InRelease
Reading package lists... Done
E: The repository 'https://download.docker.com/linux/ubuntu kali-rolling Release' does not have a Release file.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
E: The repository 'https://download.docker.com/linux/debian kali-rolling Release' does not have a Release file.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
W: Target Packages (stable/binary-all/Packages) is configured multiple times in /etc/apt/sources.list:4 and /etc/apt/sources.list.d/docker-ce.list:1
W: Target Translations (stable/i18n/Translation-en_US) is configured multiple times in /etc/apt/sources.list:4 and /etc/apt/sources.list.d/docker-ce.list:1
W: Target Translations (stable/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list:4 and /etc/apt/sources.list.d/docker-ce.list:1

@cm038, the first troubleshooting step would be to validate if Docker on Android is a supported setup? :thinking:

This work for me, thnxs amigo:
To install Docker for Kali 2020.1 debian amd64 run the following:

curl -fsSL https://download.docker.com/linux/debian/gpg | gpg
--dearmor | sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg
> /dev/null"

To install Docker for Kali 2020.1 debian amd64 run the following:
curl -fsSL https://download.docker.com/linux/debian/gpg | gpg --dearmor | sudo tee /usr/share/keyrings/docker-ce-archive-keyring.gpg > /dev/null
then:
echo 'deb [arch=amd64] https://download.docker.com/linux/debian buster stable' | sudo tee /etc/apt/sources.list.d/docker.list
sudo apt-get update
sudo apt-get install docker-ce
It worked for me by Hard coding.

@AkashicSeer, please remain civil.
Deprecated means you can still use the tool but its usage is discouraged. The way Debian has decided to deal with third-party keys and repositories is well documented in their Wiki.
The apt-key tool will only disappear in an OS version due to be released somewhere in 2022. When this time comes, nobody is forcing you to upgrade to this version of the OS if you want to carry on using apt-key for as long as you wish.
Simply put: Nobody is forcing you to change and if you want to change, there is plenty of time to comply.
Hint: You might want to change. The proposed way is much more secure: It assign a specific key to a specific repository as opposed to now where any package is checked against any key in your keyring.
The group of fools you are referring to is a large body of able open source developers who work mostly without pay to provide the world with a free operating system that anybody, and that includes you, is at complete liberty to use... Or not.
If you feel you can contribute ideas or code towards a better way to manage third-keys and repository, as we say in the open source world: Pull Requests are welcome.

Dennis, can you share the wiki link because I'm not getting that specific page. I do see https://wiki.debian.org/ but more details would be welcome.

Hello Friends, i have Ubuntu 21.04, i want download katoolin3
When running
sudo ./install.sh;
there is a warning raised that the apt-key command is depreciated.
Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
Executing: /tmp/apt-key-gpghome.LfGGzVtUjS/gpg.1.sh -qq --keyserver pool.sks-keyservers.net --recv-keys ED444FF07D8D0BF6
can anyone help me please

Hello Friends, i have Ubuntu 21.04, i want download katoolin3
When running
sudo ./install.sh;
there is a warning raised that the apt-key command is depreciated.
Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
Executing: /tmp/apt-key-gpghome.LfGGzVtUjS/gpg.1.sh -qq --keyserver pool.sks-keyservers.net --recv-keys ED444FF07D8D0BF6
can anyone help me please

That sounds like an issue to raise on the github page for katoolin3, especially since pool.sks-keyservers.net has essentially been disabled/useless for a few months now.

That sounds like an issue to raise on the github page for katoolin3, especially since pool.sks-keyservers.net has essentially been disabled/useless for a few months now.

Yes, this doesn't look related to Docker in any way.
For katoolin3, it looks like there's a PR opened here; https://github.com/LionSec/katoolin/pull/299, but I don't see activity on the repository for the last couple of years, so maybe the projects is no longer maintained (I found a fork that was slightly more up-to-date, but that's been archived as well https://github.com/s-h-3-l-l/katoolin3).


filius: init at 2.5.1

Description of changes
Description of changes
Adding new package Filius https://www.lernsoftware-filius.de/
Filius is a Computer Network Simulator written in Java and distributed as .jar file.
With the software tool Filius, you can design computer networks yourself, simulate the exchange of messages in them and thus explore their structure and functionality experimentally. The target group are learners at secondary level in general education schools. Filius enables learning activities that are designed to support discovery-based learning in particular.
@auroraanna Unfortunately I got the other pull request messed up.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

 Not sure about the license files.

good point, it's way better for maintaining. it just kinda bugs me that there's some files that are unnescessary. let's see if other reviewers think it's fine?

i checked that the .desktop entry and the icons work, but the gui colors are broken when you have a dark theme:

can we force light theme? i'd be better than terrible color contrast.

@auroraanna - so we leave it as it is? Is this PR ready to proceed? At the moment I use
nix run github:nixos/nixpkgs/pull/326102/head#filius --extra-experimental-features "nix-command flakes"

which is sort of ok, but of course would be better to have it in the standard packages.

you can also nix profile install .#filius on your branch. but yeah, we should get this merged.

can we force light theme? it'd be better than terrible color contrast.

GTK_THEME=Adwaita:light filius works but not sure if you can have a GTK installation without Adwaita.

i'd be good if upstream would solve it but i doubt it will happen. Adwaita is a GTK+ theme and filius only seems to be using GTK, not QT.

GTK is not exclusively a GNOME thing. You can use GTK apps on KDE Plasma too, i am using Sway ftr.

i think the only problem i'm having now is that one of Filius's consoles, the line for entering commands has terrible contrast:

i don't think we can fix this though

I think we should merge it for now and try to contact the developer.

I can't detect any changes with those java options.

it is unfortunate that we have to set Dawt.useSystemAAFontSettings. depending on what monitor you have, you might want to configure it differently.

yes i am for merging now.

Is it intentional that the email address you use for Git commits isn't associated with your GitHub account? See Setting your commit email address if you want to use GitHub's noreply email address.

Since https://github.com/NixOS/nixpkgs/pull/316431 was merged, the maintainer commit should be removed from this PR.

currently failing to package this to build from source: https://gitlab.com/filius1/filius/-/issues/103

oh, i think last time i tried to package it from source, buildMavenPackage didn't exist yet. if i find time, i can try that…


"yesterday" bug with colloquial when difference between two dates > 24 but < 48 hours

#397  still doesn't work :( sorry, probably my explanations were bad. Please take a look at this example
let to = Date()
let from = Date(timeIntervalSince1970: to.timeIntervalSince1970 - 47 * 60 * 60)

let fromDate = DateInRegion(absoluteDate: from, in: nil)
let toDate = DateInRegion(absoluteDate: to, in: fromDate.region)
let formatter = DateInRegionFormatter()
formatter.localization = Localization(locale: fromDate.region.locale)
formatter.imminentInterval = 1
let col = try! formatter.colloquial(from: fromDate, to: toDate).colloquial

print("col = \(col)")

from = 2017-04-01 15:07:52 UTC
to = 2017-04-03 14:07:52 UTC
shows

yesterday

so basically if difference between two dates more(!) than 24 hours, but less than 48 hours, and its not two consecutive days it still shows "yesterday"
P.S. sorry i don't know how to change status on issue #397 so i created this one

Thank you, just closed for 4.1.1


Bump istio to 1.4.0

Istio 1.4 fixed some bugs, and it's necessary to upgrade.

@jasonliu747 Thank you for the PR. Can you split this into 2 commits? 1 commit which is a copy of folder v0.1.1 to v0.1.2. And the second commit of all the changes applied to make 1.4.0 accessible.
This really helps in our review process for helm chart changes.
Thanks!

@deniseschannon absolutely! For your convenience, I'll close this PR, and open another with split commits. #131


Lambda env vars inconsistent with dev and deploy

When you use dev mode, you get SST_APP and SST_STAGE as env var in lambda. Using deploy, the lambda function gets SST_RESOURCE_App with the object keys name and stage.
Is it possible to have the same definition keys for these vars?

While prod does lack the SST_STAGE variable, the SST_Resource_App variable is still in dev mode.
So I just get the stage from that variable but you can get the app name too.
const env: { name: string; stage: string } = JSON.parse(
	process.env.SST_RESOURCE_App as string
)

if (env.stage === "prod") {

}

Yes, you're right, SST_Resource_App is in dev too, but what would be the consensus then?

Doesn't make sense too me have duplicated data in the env vars
For me, is easier to have this in two vars instead of parsing the SST_Resource_App.

Is there a reason why you are using process.env instead of  import { Resource } from 'sst'

There's not a reason I think I just didn't realise that you could access it Resource as well. Or maybe I was getting some weird type errors.

Is there a reason why you are using process.env instead of import { Resource } from 'sst'

+1
I don't remember seeing in the docs that you can access from the sst Resource.App, but it's there now and it's great!
https://sst.dev/docs/reference/sdk/#defaults, thanks!
However, I still think the variable names should be unified :)

Yeah we recommend not relying on those environment variables. Treat them as something SST uses internally.
Closing for now.


Which .py include RIFE-Large?

Hi, I am so exciting about your work!
I want to know where is the RIFE-Large(2T2R)?
Thanks!

Hi, I add the .py in https://github.com/hzwer/arXiv2021-RIFE/blob/main/model/IFNet_2R.py.
And in https://github.com/hzwer/arXiv2021-RIFE/blob/f8f415bd8e9a2808378038b7d53f6d518fc29501/model/RIFE.py#L56, we can set TTA=True to get 2T evaluation.

Hi, I try 2 method to deal with the final upsample.1. TransposedConv->Conv2d 2. adjust the scale of bilinear upsample. They have similar effect.
RIFE is still in the development stage, I am not sure about the final implementation; but I try to keep the RIFE-baseline unchanged.

Thanks your reply!
Does 2T participate in training? I don't see the 2T operation on the image when loading the data.
:)

@silenye No, 2T is just a test-time augmentation trick.

@hzwer  Where can I download RIFE-Large checkpoint so I can evaluate it？

@chen-san
https://github.com/hzwer/arXiv2021-RIFE/tree/cd5366db61ae8cec1497be0f2d6167117968ab5a
There is a previous RIFE-Large model, it should produce 36.21dB on Vimeo90K benchmark.
For current version, I do not organize the relevant code and weights, because it may change at any time. Sorry for that.


fix #14604 CompareValidator compareAttribute does not work if `compar…

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
#14604

Merged. Thank you!


Issue with Google Secrets Manager while using Workload Identity

Issue Description:
External Secrets fail to fetch secrets from google secrets manager randomly. Please help on resolving this issue.
What I did,
Create k8s SA and Google Service Account with access to retrieve secrets.
export NAMESPACE=default
export CLUSTER_NAME=gcp-cluster
export PROJECT_ID=my-project
export SECRETS_MANAGER_PROJECT_ID=my-project
gcloud services enable secretmanager.googleapis.com --project $SECRETS_MANAGER_PROJECT_ID
kubectl create serviceaccount k8s-secret-manager -n $NAMESPACE
kubectl annotate sa k8s-secret-manager<EMAIL_ADDRESS>gcloud iam service-accounts create $CLUSTER_NAME-secret-manager --project $SECRETS_MANAGER_PROJECT_ID
gcloud iam service-accounts add-iam-policy-binding \
  --role roles/iam.workloadIdentityUser \
  --member "serviceAccount:$PROJECT_ID.svc.id.goog[$NAMESPACE/k8s-secret-manager]" \
<EMAIL_ADDRESS>\
  --project $SECRETS_MANAGER_PROJECT_ID
gcloud projects add-iam-policy-binding $SECRETS_MANAGER_PROJECT_ID \
  --role roles/secretmanager.secretAccessor \
  --member<EMAIL_ADDRESS>\
  --project $SECRETS_MANAGER_PROJECT_ID

I verified access to secrets manager as,
kubectl run --rm -it  --generator=run-pod/v1  --image google/cloud-sdk:slim  --serviceaccount k8s-secret-manager --namespace default  workload-identity-test
root@workload-identity-test:/# gcloud secrets versions access latest --secret="cp-dev-blip-secrets"
{
  "MYSQL_DB": "blip",
  "MYSQL_USERNAME": "root"
}

But, when I use the same service account for external secrets, it fails. I installed it via helm chart as,
helm install external-secrets external-secrets/kubernetes-external-secrets --set serviceAccount.create=False --set serviceAccount.name=k8s-secret-manager

Error I can see from logs on pod,
kubectl logs -f external-secrets-kubernetes-external-secrets-86d596767b-xc2g7

{"level":30,"time":1609251781470,"pid":18,"hostname":"external-secrets-kubernetes-external-secrets-86d596767b-xc2g7","msg":"upserting secret dev1/cp-secret-tls"}
{"level":30,"time":1609251781490,"pid":18,"hostname":"external-secrets-kubernetes-external-secrets-86d596767b-xc2g7","msg":"stopping poller for dev1/cp-secret-tls"}
{"level":30,"time":1609251781490,"pid":18,"hostname":"external-secrets-kubernetes-external-secrets-86d596767b-xc2g7","msg":"starting poller for dev1/cp-secret-tls"}
{"level":30,"time":1609251783114,"pid":18,"hostname":"external-secrets-kubernetes-external-secrets-86d596767b-xc2g7","msg":"running poll on the secret dev1/cp-automation-monitoring-secrets"}
{"level":30,"time":1609251783115,"pid":18,"hostname":"external-secrets-kubernetes-external-secrets-86d596767b-xc2g7","msg":"running poll on the secret dev1/amagicred"}
{"level":30,"time":1609251783116,"pid":18,"hostname":"external-secrets-kubernetes-external-secrets-86d596767b-xc2g7","msg":"running poll on the secret dev1/cp-automation-blip-secrets"}
{"level":30,"time":1609251783124,"pid":18,"hostname":"external-secrets-kubernetes-external-secrets-86d596767b-xc2g7","msg":"fetching secret property cp-docker-secrets with role: pods role in region undefined"}
{"level":30,"time":1609251783127,"pid":18,"hostname":"external-secrets-kubernetes-external-secrets-86d596767b-xc2g7","msg":"fetching secret property cp-dev-monitoring-secrets with role: pods role in region undefined"}
{"level":30,"time":1609251783127,"pid":18,"hostname":"external-secrets-kubernetes-external-secrets-86d596767b-xc2g7","msg":"fetching secret property cp-dev-blip-secrets with role: pods role in region undefined"}
{"level":50,"time":1609251783129,"pid":18,"hostname":"external-secrets-kubernetes-external-secrets-86d596767b-xc2g7","message":"Missing credentials in config","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Could not load credentials from any providers","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Missing credentials in config","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Could not load credentials from any providers","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Missing credentials in config","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Could not load credentials from any providers","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"EC2 Metadata roleName request returned error","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z"}}}}}},"stack":"CredentialsError: Missing credentials in config\n    at IncomingMessage.<anonymous> (/app/node_modules/aws-sdk/lib/util.js:895:34)\n    at IncomingMessage.emit (events.js:327:22)\n    at IncomingMessage.EventEmitter.emit (domain.js:483:12)\n    at endReadableNT (_stream_readable.js:1220:12)\n    at processTicksAndRejections (internal/process/task_queues.js:84:21)","type":"Error","msg":"failure while polling the secret dev1/amagicred"}
{"level":50,"time":1609251783130,"pid":18,"hostname":"external-secrets-kubernetes-external-secrets-86d596767b-xc2g7","message":"Missing credentials in config","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Could not load credentials from any providers","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Missing credentials in config","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Could not load credentials from any providers","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Missing credentials in config","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Could not load credentials from any providers","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"EC2 Metadata roleName request returned error","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z"}}}}}},"stack":"CredentialsError: Missing credentials in config\n    at IncomingMessage.<anonymous> (/app/node_modules/aws-sdk/lib/util.js:895:34)\n    at IncomingMessage.emit (events.js:327:22)\n    at IncomingMessage.EventEmitter.emit (domain.js:483:12)\n    at endReadableNT (_stream_readable.js:1220:12)\n    at processTicksAndRejections (internal/process/task_queues.js:84:21)","type":"Error","msg":"failure while polling the secret dev1/cp-automation-monitoring-secrets"}
{"level":50,"time":1609251783130,"pid":18,"hostname":"external-secrets-kubernetes-external-secrets-86d596767b-xc2g7","message":"Missing credentials in config","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Could not load credentials from any providers","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Missing credentials in config","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Could not load credentials from any providers","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Missing credentials in config","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"Could not load credentials from any providers","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z","code":"CredentialsError","originalError":{"message":"EC2 Metadata roleName request returned error","statusCode":404,"retryable":false,"time":"2020-12-29T14:23:03.129Z"}}}}}},"stack":"CredentialsError: Missing credentials in config\n    at IncomingMessage.<anonymous> (/app/node_modules/aws-sdk/lib/util.js:895:34)\n    at IncomingMessage.emit (events.js:327:22)\n    at IncomingMessage.EventEmitter.emit (domain.js:483:12)\n    at endReadableNT (_stream_readable.js:1220:12)\n    at processTicksAndRejections (internal/process/task_queues.js:84:21)","type":"Error","msg":"failure while polling the secret dev1/cp-automation-blip-secrets"}

I verified that the token of serviceAccount token mounted at /var/run/secrets/kubernetes.io/serviceaccount/token on both the pods (workload-identity-test, external-secrets-kubernetes-external-secrets-86d596767b-xc2g7) are same
$ kubectl describe po/external-secrets-kubernetes-external-secrets-86d596767b-xc2g7
.......
Volumes:
  k8s-secret-manager-token-wb25f:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  k8s-secret-manager-token-wb25f
    Optional:    false
QoS Class:       Burstable
.......

Please note that same process worked for me earlier, but not sure why it suddenly stops working.

Hi all,
Sorry my bad backendType I specified in my secret was incorrect.
Closing this issue.

Hi all,
Sorry my bad backendType I specified in my secret was incorrect.
Closing this issue.


use namespace as chart name so it is unique

so that if non cluster wide is used, we have a unique chart name for each.
rework of https://github.com/istio/istio/pull/5280

@linsun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
c144eeb9634461e7a6130031a3e8379e2556e155
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
c144eeb9634461e7a6130031a3e8379e2556e155
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
c144eeb9634461e7a6130031a3e8379e2556e155
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
c144eeb9634461e7a6130031a3e8379e2556e155
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
49cd13f2eac1e739d43d4e86245a94616837f025
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
49cd13f2eac1e739d43d4e86245a94616837f025
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
49cd13f2eac1e739d43d4e86245a94616837f025
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@linsun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
49cd13f2eac1e739d43d4e86245a94616837f025
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3bbe6c4dd0e252930abc5d4c698db450d2d7d43c
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3bbe6c4dd0e252930abc5d4c698db450d2d7d43c
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
3bbe6c4dd0e252930abc5d4c698db450d2d7d43c
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3bbe6c4dd0e252930abc5d4c698db450d2d7d43c
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
3bbe6c4dd0e252930abc5d4c698db450d2d7d43c
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
3bbe6c4dd0e252930abc5d4c698db450d2d7d43c
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linsun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3bbe6c4dd0e252930abc5d4c698db450d2d7d43c
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
3bbe6c4dd0e252930abc5d4c698db450d2d7d43c
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
3bbe6c4dd0e252930abc5d4c698db450d2d7d43c
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
3bbe6c4dd0e252930abc5d4c698db450d2d7d43c
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfo

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hklai
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Ensure that the gotoblas lookup table is always initialized.

It is possible to build a program that calls a non-GEMM OpenBLAS routine from
a static initializer. Since the order of initialization is undefined, and even
less defined when using attribute((constructor)) in one TU and a C++ static
initializer in another TU, it can happen (and does, unfortunately) that
gotoblas_init is not called before the first BLAS routine. This results in a
segfault when trying to index into the gotoblas table.
The solution I've put here is indirection: rather than directly using the table
use an inlined function to first check if it's been initialized. Since it will
only not have been done once, the branch prediction should keep things fast.

Looks like the definition of LIKELY_ONE in memory.c needs to be done unconditionally (the failing CI tasks are those that do not have DYNAMIC_ARCH set)...

Oh, and please mention issue 1652 in your comment so that it gets linked to the PR and vice versa.

I've removed LIKELY_ONE. It seems like it's more trouble than it's worth:
https://godbolt.org/g/5G9PZ6
It's generating more instructions, and not seeming to do anything particularly intelligent about the branch.

@martin-frbg or @fenrus75 any thoughts here?

No time to look at this right now, and frankly I am hoping for some less invasive feature to put into 0.3.2 and release that first, so that people have a somewhat usable release to work with again.

No worries, I might want to find a simpler way to do this, anyway.  Let's hold off this commit.

Maybe this should be somewhere in the wiki... do other compilers guarantee the order of constructors across translation units, or is this perhaps even a c-something standards issue ?

No, the order of static initializers across translation units is expressly unspecified, and it is undefined behavior to depend on any given order. Even with a given compiler the order may vary from one build to the next.
The only way to ensure that some variable of static storage duration is never accessed before it is initialized, is not to expose it outside the single translation unit where it is initialized. (Unfortunately that would prevent inlining calls to get_gotoblas() without link-time optimization, which may be unacceptable.)