Using 1.16.0, the ACME issuer using HTTP-01 solver with Gateway API is broken

Describe the bug:
Issuing a new certificate fails on error waiting for authorization and unexpected non-ACME API error.
controller logs:
I1005 19:55:21.630885       1 conditions.go:203] Setting lastTransitionTime for Certificate "<DOMAIN>-tls" condition "Ready" to 2024-10-05 19:55:21.630871806 +0000 UTC m=+276.682156984
I1005 19:55:21.631690       1 trigger_controller.go:223] "Certificate must be re-issued" logger="cert-manager.controller" key="gateway/<DOMAIN>-tls" reason="DoesNotExist" message="Issuing certificate as Secret does not exist"
I1005 19:55:21.636969       1 conditions.go:203] Setting lastTransitionTime for Certificate "<DOMAIN>-tls" condition "Issuing" to 2024-10-05 19:55:21.636948435 +0000 UTC m=+276.688233644
I1005 19:55:21.657677       1 controller.go:152] "re-queuing item due to optimistic locking on resource" logger="cert-manager.controller" error="Operation cannot be fulfilled on certificates.cert-manager.io \"<DOMAIN>-tls\": the object has been modified; please apply your changes to the latest version and try again"
I1005 19:55:21.657748       1 trigger_controller.go:223] "Certificate must be re-issued" logger="cert-manager.controller" key="gateway/<DOMAIN>-tls" reason="DoesNotExist" message="Issuing certificate as Secret does not exist"
I1005 19:55:21.657774       1 conditions.go:203] Setting lastTransitionTime for Certificate "<DOMAIN>-tls" condition "Issuing" to 2024-10-05 19:55:21.657766356 +0000 UTC m=+276.709051535
I1005 19:55:22.310137       1 conditions.go:263] Setting lastTransitionTime for CertificateRequest "<DOMAIN>-tls-1" condition "Approved" to 2024-10-05 19:55:22.310126399 +0000 UTC m=+277.361411567
I1005 19:55:22.334507       1 conditions.go:263] Setting lastTransitionTime for CertificateRequest "<DOMAIN>-tls-1" condition "Ready" to 2024-10-05 19:55:22.334488823 +0000 UTC m=+277.385774012
W1005 19:55:23.364319       1 warnings.go:70] metadata.finalizers: "finalizer.acme.cert-manager.io": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers
I1005 19:55:23.573713       1 pod.go:71] "creating HTTP01 challenge solver pod" logger="cert-manager.controller.http01.ensurePod" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01"
I1005 19:55:23.636553       1 httproute.go:67] "getting httpRoutes for challenge" logger="cert-manager.controller.http01.getGatewayHTTPRoute" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" name="<DOMAIN>-tls-1-2127692413-1871217317" namespace="gateway"
I1005 19:55:23.636622       1 httproute.go:47] "creating HTTPRoute for challenge" logger="cert-manager.controller.http01.ensureGatewayHTTPRoute" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" name="<DOMAIN>-tls-1-2127692413-1871217317" namespace="gateway"
I1005 19:55:23.652780       1 pod.go:59] "found one existing HTTP01 solver pod" logger="cert-manager.controller.http01.selfCheck.http01.ensurePod" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" related_resource_name="cm-acme-http-solver-88cmh" related_resource_namespace="gateway" related_resource_kind="" related_resource_version=""
I1005 19:55:23.652854       1 service.go:45] "found one existing HTTP01 solver Service for challenge resource" logger="cert-manager.controller.http01.selfCheck.http01.ensureService" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" related_resource_name="cm-acme-http-solver-gfhk7" related_resource_namespace="gateway" related_resource_kind="" related_resource_version=""
I1005 19:55:23.652889       1 httproute.go:67] "getting httpRoutes for challenge" logger="cert-manager.controller.http01.selfCheck.http01.getGatewayHTTPRoute" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" name="<DOMAIN>-tls-1-2127692413-1871217317" namespace="gateway"
I1005 19:55:23.652934       1 httproute.go:55] "Found existing HTTPRoute for challenge" logger="cert-manager.controller.http01.selfCheck.http01.ensureGatewayHTTPRoute" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" name="<DOMAIN>-tls-1-2127692413-1871217317" namespace="gateway"
E1005 19:55:23.719614       1 sync.go:208] "propagation check failed" err="wrong status code '404', expected '200'" logger="cert-manager.controller" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01"
I1005 19:55:23.737737       1 pod.go:59] "found one existing HTTP01 solver pod" logger="cert-manager.controller.http01.selfCheck.http01.ensurePod" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" related_resource_name="cm-acme-http-solver-88cmh" related_resource_namespace="gateway" related_resource_kind="" related_resource_version=""
I1005 19:55:23.737816       1 service.go:45] "found one existing HTTP01 solver Service for challenge resource" logger="cert-manager.controller.http01.selfCheck.http01.ensureService" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" related_resource_name="cm-acme-http-solver-gfhk7" related_resource_namespace="gateway" related_resource_kind="" related_resource_version=""
I1005 19:55:23.737856       1 httproute.go:67] "getting httpRoutes for challenge" logger="cert-manager.controller.http01.selfCheck.http01.getGatewayHTTPRoute" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" name="<DOMAIN>-tls-1-2127692413-1871217317" namespace="gateway"
I1005 19:55:23.738070       1 httproute.go:55] "Found existing HTTPRoute for challenge" logger="cert-manager.controller.http01.selfCheck.http01.ensureGatewayHTTPRoute" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" name="<DOMAIN>-tls-1-2127692413-1871217317" namespace="gateway"
E1005 19:55:23.760244       1 sync.go:208] "propagation check failed" err="wrong status code '503', expected '200'" logger="cert-manager.controller" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01"
I1005 19:55:23.773927       1 pod.go:59] "found one existing HTTP01 solver pod" logger="cert-manager.controller.http01.selfCheck.http01.ensurePod" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" related_resource_name="cm-acme-http-solver-88cmh" related_resource_namespace="gateway" related_resource_kind="" related_resource_version=""
I1005 19:55:23.774259       1 service.go:45] "found one existing HTTP01 solver Service for challenge resource" logger="cert-manager.controller.http01.selfCheck.http01.ensureService" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" related_resource_name="cm-acme-http-solver-gfhk7" related_resource_namespace="gateway" related_resource_kind="" related_resource_version=""
I1005 19:55:23.774420       1 httproute.go:67] "getting httpRoutes for challenge" logger="cert-manager.controller.http01.selfCheck.http01.getGatewayHTTPRoute" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" name="<DOMAIN>-tls-1-2127692413-1871217317" namespace="gateway"
I1005 19:55:23.774576       1 httproute.go:55] "Found existing HTTPRoute for challenge" logger="cert-manager.controller.http01.selfCheck.http01.ensureGatewayHTTPRoute" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" name="<DOMAIN>-tls-1-2127692413-1871217317" namespace="gateway"
E1005 19:55:23.791886       1 sync.go:208] "propagation check failed" err="wrong status code '503', expected '200'" logger="cert-manager.controller" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01"
I1005 19:55:33.721279       1 pod.go:59] "found one existing HTTP01 solver pod" logger="cert-manager.controller.http01.selfCheck.http01.ensurePod" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" related_resource_name="cm-acme-http-solver-88cmh" related_resource_namespace="gateway" related_resource_kind="" related_resource_version=""
I1005 19:55:33.721950       1 service.go:45] "found one existing HTTP01 solver Service for challenge resource" logger="cert-manager.controller.http01.selfCheck.http01.ensureService" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" related_resource_name="cm-acme-http-solver-gfhk7" related_resource_namespace="gateway" related_resource_kind="" related_resource_version=""
I1005 19:55:33.722048       1 httproute.go:67] "getting httpRoutes for challenge" logger="cert-manager.controller.http01.selfCheck.http01.getGatewayHTTPRoute" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" name="<DOMAIN>-tls-1-2127692413-1871217317" namespace="gateway"
I1005 19:55:33.722158       1 httproute.go:55] "Found existing HTTPRoute for challenge" logger="cert-manager.controller.http01.selfCheck.http01.ensureGatewayHTTPRoute" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01" name="<DOMAIN>-tls-1-2127692413-1871217317" namespace="gateway"
E1005 19:56:01.969322       1 sync.go:403] "error waiting for authorization" err="context deadline exceeded" logger="cert-manager.controller.acceptChallenge" resource_name="<DOMAIN>-tls-1-2127692413-1871217317" resource_namespace="gateway" resource_kind="Challenge" resource_version="v1" dnsName="<DOMAIN>" type="HTTP-01"
E1005 19:56:01.969387       1 sync.go:240] "unexpected non-ACME API error" err="context deadline exceeded"
E1005 19:56:01.979482       1 controller.go:157] "re-queuing item due to error processing" err="context deadline exceeded" logger="cert-manager.controller"

cert resources:

apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  creationTimestamp: "2024-10-05T19:55:21Z"
  generation: 1
  name: <DOMAIN>-tls
  namespace: gateway
  ownerReferences:
  - apiVersion: gateway.networking.k8s.io/v1
    blockOwnerDeletion: true
    controller: true
    kind: Gateway
    name: main-gw
    uid: f294ac2e-0067-4041-8182-02a7e6a6a79e
  resourceVersion: "107070782"
  uid: d3a5eb42-25a3-4b9b-ba6b-130d90e96f32
spec:
  dnsNames:
  - <DOMAIN>
  issuerRef:
    group: cert-manager.io
    kind: Issuer
    name: letsencrypt
  secretName: <DOMAIN>-tls
  usages:
  - digital signature
  - key encipherment
status:
  conditions:
  - lastTransitionTime: "2024-10-05T19:55:21Z"
    message: Issuing certificate as Secret does not exist
    observedGeneration: 1
    reason: DoesNotExist
    status: "False"
    type: Ready
  - lastTransitionTime: "2024-10-05T20:11:55Z"
    message: 'The certificate request has failed to complete and will be retried:
      Failed to wait for order resource "<DOMAIN>-tls-1-2127692413" to become ready:
      order is in "invalid" state: '
    observedGeneration: 1
    reason: Failed
    status: "False"
    type: Issuing
  failedIssuanceAttempts: 1
  lastFailureTime: "2024-10-05T20:11:55Z"

  apiVersion: cert-manager.io/v1
kind: CertificateRequest
metadata:
  annotations:
    cert-manager.io/certificate-name: <DOMAIN>-tls
    cert-manager.io/certificate-revision: "1"
    cert-manager.io/private-key-secret-name: <DOMAIN>-tls-59vtw
  creationTimestamp: "2024-10-05T19:55:22Z"
  generation: 1
  name: <DOMAIN>-tls-1
  namespace: gateway
  ownerReferences:
  - apiVersion: cert-manager.io/v1
    blockOwnerDeletion: true
    controller: true
    kind: Certificate
    name: <DOMAIN>-tls
    uid: d3a5eb42-25a3-4b9b-ba6b-130d90e96f32
  resourceVersion: "107070778"
  uid: 7e70e4a5-4421-449a-bf0d-092d33bdcef1
spec:
  extra:
    authentication.kubernetes.io/credential-id:
    - JTI=bb18205d-<>-<>-<>-4efb1dbbe544
    authentication.kubernetes.io/node-name:
    - node1
    authentication.kubernetes.io/node-uid:
    - 6e297928-<>-<>-<>-8e4d5507a8dc
    authentication.kubernetes.io/pod-name:
    - cert-manager-855d849766-n9xhx
    authentication.kubernetes.io/pod-uid:
    - 80bac62a-<>-<>-<>-2a7923de992c
  groups:
  - system:serviceaccounts
  - system:serviceaccounts:cert-manager
  - system:authenticated
  issuerRef:
    group: cert-manager.io
    kind: Issuer
    name: letsencrypt
  request: LS0tL<>LQo=
  uid: 8aa51f82-<>-<>-<>-096272e1bc08
  usages:
  - digital signature
  - key encipherment
  username: system:serviceaccount:cert-manager:cert-manager
status:
  conditions:
  - lastTransitionTime: "2024-10-05T19:55:22Z"
    message: Certificate request has been approved by cert-manager.io
    reason: cert-manager.io
    status: "True"
    type: Approved
  - lastTransitionTime: "2024-10-05T19:55:22Z"
    message: 'Failed to wait for order resource "<DOMAIN>-tls-1-2127692413" to become
      ready: order is in "invalid" state: '
    reason: Failed
    status: "False"
    type: Ready
  failureTime: "2024-10-05T20:11:55Z"

Increasing verbosity level does not help to troubleshoot the problem.
Expected behaviour:
Issue certificate by ACME issuer.
Steps to reproduce the bug:
helm values:
config:
  apiVersion: controller.config.cert-manager.io/v1alpha1
  enableGatewayAPI: true
  kind: ControllerConfiguration
crds:
  enabled: true

Issuer:
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
  name: letsencrypt
  namespace: gateway
spec:
  acme:
    server: https://acme-staging-v02.api.letsencrypt.org/directory
    privateKeySecretRef:
      name: letsencrypt-issuer-account-key
    solvers:
      - http01:
          gatewayHTTPRoute:
            parentRefs:
              - name: main-gw
                namespace: gateway
                kind: Gateway

Gateway:
apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  name: main-gw
  namespace: gateway
  annotations:
    cert-manager.io/issuer: letsencrypt
spec:
  gatewayClassName: cilium
  listeners:
  - name: https
    hostname: <DOMAIN>
    port: 443
    protocol: HTTPS
    allowedRoutes:
      namespaces:
        from: All
    tls:
      mode: Terminate
      certificateRefs:
        - name: <DOMAIN>-tls
  - name: http
    hostname: <DOMAIN>
    protocol: HTTP
    port: 80
    allowedRoutes:
        namespaces:
          from: All

If cert-manager is downgraded to 1.15.3, certificate is issued fined as expected.
Anything else we need to know?:
Environment details::

Kubernetes version: v1.30.4
Cloud-provider/provisioner: N/A
cert-manager version: 1.16.0
Install method: e.g. helm/static manifests HELM
Cilium 1.16.2
GatewayAPI 1.1

/kind bug

related: https://github.com/cert-manager/cert-manager/pull/7202

Hey, I'm struggling trying to reproduce this. Can you help us with some instructions on how to reproduce the environment? Thanks.
One thing we could try doing first is to look at the changes that took place in the HTTP-01 Gateway API solver.
# Gateway API certificate shim:
git diff v1.15.3..v1.16.0 pkg/controller/certificate-shim/gateways
# Gateway API HTTP-01 solver:
git diff v1.15.3..v1.16.0 pkg/issuer/acme/http

I've noticed three new tests since 1.15.3:

should use labels, annotations and spec fields from template when using gateway-api
security context should be configurable using gateway-api

Could you share the solver pod's spec?
/help

@maelvls
I upgraded CM back to 1.16.0 by helm upgrade cert-manager jetstack/cert-manager --namespace cert-manager -f values.yaml --version v1.16.0
values:
config:
  apiVersion: controller.config.cert-manager.io/v1alpha1
  enableGatewayAPI: true
  kind: ControllerConfiguration
crds:
  enabled: true

As I did not find way to revoke cert, and cmctl renew <cert> -n gateway did not trigger re-issue. I edited hostname in gateway to get a new cert.
here you are:
apiVersion: v1
kind: Pod
metadata:
  annotations:
    cluster-autoscaler.kubernetes.io/safe-to-evict: "true"
    sidecar.istio.io/inject: "false"
  creationTimestamp: "2024-10-14T17:56:44Z"
  generateName: cm-acme-http-solver-
  labels:
    acme.cert-manager.io/http-domain: "500237468"
    acme.cert-manager.io/http-token: "1011224200"
    acme.cert-manager.io/http01-solver: "true"
  name: cm-acme-http-solver-jt2v9
  namespace: gateway
  ownerReferences:
  - apiVersion: acme.cert-manager.io/v1
    blockOwnerDeletion: true
    controller: true
    kind: Challenge
    name: <DOMAIN>-tls-3-3735734311-936855731
    uid: 735a8387-f463-4767-b98c-fb2657d4f38f
  resourceVersion: "109464785"
  uid: 9a1b9daa-0d01-45ea-b0f1-17c49696c82e
spec:
  automountServiceAccountToken: false
  containers:
  - args:
    - --listen-port=8089
    - --domain=cm.<DOMAIN>
    - --token=qt5~~~XrZ4
    - --key=qt5~~~3UU0
    image: quay.io/jetstack/cert-manager-acmesolver:v1.16.0
    imagePullPolicy: IfNotPresent
    name: acmesolver
    ports:
    - containerPort: 8089
      name: http
      protocol: TCP
    resources:
      limits:
        cpu: 100m
        memory: 64Mi
      requests:
        cpu: 10m
        memory: 64Mi
    securityContext:
      allowPrivilegeEscalation: false
      capabilities:
        drop:
        - ALL
      readOnlyRootFilesystem: true
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
  dnsPolicy: ClusterFirst
  enableServiceLinks: false
  nodeName: node1
  nodeSelector:
    kubernetes.io/os: linux
  preemptionPolicy: PreemptLowerPriority
  priority: 0
  restartPolicy: OnFailure
  schedulerName: default-scheduler
  securityContext:
    runAsNonRoot: true
    seccompProfile:
      type: RuntimeDefault
  serviceAccount: default
  serviceAccountName: default
  terminationGracePeriodSeconds: 30
  tolerations:
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
    tolerationSeconds: 300
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
    tolerationSeconds: 300
status:
  conditions:
  - lastProbeTime: null
    lastTransitionTime: "2024-10-14T17:56:46Z"
    status: "True"
    type: PodReadyToStartContainers
  - lastProbeTime: null
    lastTransitionTime: "2024-10-14T17:56:44Z"
    status: "True"
    type: Initialized
  - lastProbeTime: null
    lastTransitionTime: "2024-10-14T17:56:46Z"
    status: "True"
    type: Ready
  - lastProbeTime: null
    lastTransitionTime: "2024-10-14T17:56:46Z"
    status: "True"
    type: ContainersReady
  - lastProbeTime: null
    lastTransitionTime: "2024-10-14T17:56:44Z"
    status: "True"
    type: PodScheduled
  containerStatuses:
  - containerID: containerd://7dd0078c52674db76503bc775a2a6d54b5335ba6def52e819dadf3d880cf2671
    image: quay.io/jetstack/cert-manager-acmesolver:v1.16.0
    imageID: quay.io/jetstack/cert-manager-acmesolver@sha256:a4b65f0a5b8f31ae6731e415492c68663b4ae2292674e8747037b2d18b1fa51e
    lastState: {}
    name: acmesolver
    ready: true
    restartCount: 0
    started: true
    state:
      running:
        startedAt: "2024-10-14T17:56:45Z"
  hostIP: <IP_ADDRESS>
  hostIPs:
  - ip: <IP_ADDRESS>
  phase: Running
  podIP: <IP_ADDRESS>
  podIPs:
  - ip: <IP_ADDRESS>
  qosClass: Burstable
  startTime: "2024-10-14T17:56:44Z"

Here is a log from pod (note, log is from another pod, as pod is terminated after a while):
k -n gateway logs pods/cm-acme-http-solver-wwrz8  -f
I1014 18:10:45.414467       1 solver.go:51] "starting listener" logger="cert-manager.acmesolver" expected_domain="cm.<DOMAIN>" expected_token="lm1~~~~jA3I" expected_key="lm1~~~~jA3I.nx~~~_nL0w9h5a3UU0" listen_port=8089
I1014 18:10:54.027560       1 solver.go:76] "validating request" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I"
I1014 18:10:54.027651       1 solver.go:84] "comparing host" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I" expected_host="cm.<DOMAIN>"
I1014 18:10:54.027735       1 solver.go:91] "comparing token" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I" expected_token="lm1~~~~jA3I"
I1014 18:10:54.027796       1 solver.go:99] "got successful challenge request, writing key" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I"
I1014 18:10:56.045215       1 solver.go:76] "validating request" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I"
I1014 18:10:56.045456       1 solver.go:84] "comparing host" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I" expected_host="cm.<DOMAIN>"
I1014 18:10:56.045531       1 solver.go:91] "comparing token" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I" expected_token="lm1~~~~jA3I"
I1014 18:10:56.045635       1 solver.go:99] "got successful challenge request, writing key" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I"
I1014 18:10:58.061012       1 solver.go:76] "validating request" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I"
I1014 18:10:58.061245       1 solver.go:84] "comparing host" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I" expected_host="cm.<DOMAIN>"
I1014 18:10:58.061378       1 solver.go:91] "comparing token" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I" expected_token="lm1~~~~jA3I"
I1014 18:10:58.061466       1 solver.go:99] "got successful challenge request, writing key" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I"
I1014 18:11:00.083397       1 solver.go:76] "validating request" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I"
I1014 18:11:00.083682       1 solver.go:84] "comparing host" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I" expected_host="cm.<DOMAIN>"
I1014 18:11:00.083754       1 solver.go:91] "comparing token" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I" expected_token="lm1~~~~jA3I"
I1014 18:11:00.083827       1 solver.go:99] "got successful challenge request, writing key" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I"
I1014 18:11:02.098502       1 solver.go:76] "validating request" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I"
I1014 18:11:02.098598       1 solver.go:84] "comparing host" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I" expected_host="cm.<DOMAIN>"
I1014 18:11:02.098702       1 solver.go:91] "comparing token" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I" expected_token="lm1~~~~jA3I"
I1014 18:11:02.098769       1 solver.go:99] "got successful challenge request, writing key" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I"
I1014 18:11:12.754206       1 solver.go:76] "validating request" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I"
I1014 18:11:12.754243       1 solver.go:84] "comparing host" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I" expected_host="cm.<DOMAIN>"
I1014 18:11:12.754265       1 solver.go:91] "comparing token" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I" expected_token="lm1~~~~jA3I"
I1014 18:11:12.754285       1 solver.go:99] "got successful challenge request, writing key" logger="cert-manager.acmesolver" host="cm.<DOMAIN>" path="/.well-known/acme-challenge/lm1~~~~jA3I" base_path="/.well-known/acme-challenge" token="lm1~~~~jA3I"
E1014 18:11:22.348267       1 main.go:42] "error executing command" err="http: Server closed" logger="cert-manager"

Should you need anything else, just let me know.

noticed a similar behaviour in 1.16.1 where I got the following
Status:
  Presented:   false
  Processing:  false
  Reason:      unexpected non-ACME API error: context deadline exceeded
  State:       errored
Events:
  Type    Reason     Age    From                     Message
  ----    ------     ----   ----                     -------
  Normal  Started    2m18s  cert-manager-challenges  Challenge scheduled for processing
  Normal  Presented  2m18s  cert-manager-challenges  Presented challenge using HTTP-01 challenge mechanism

noticed the issue as certificate expiration notification appeared on a certificate that should have been renewed 2 days before but wasn't. I tried to run cmctl renew and that gave the error above.
Only thing that fixed it was reverting to 1.15.3

I have a same problem, reverting to 1.15.3

I experienced the same problem on Kubernetes 1.31 without the Gateway API. Downgrading cert manager to 1.15.3 resolved the issue.

same on K3s with Kubernetes v1.31.2+k3s1

Reverting to 1.15.3 resovled the issue on my k3s cluster

We hit this error several times per day. Roughly 10 out of 3k certificates I would guess. We will try the downgrade.

Ran into the same problem with an ingress. With 1.16.x there seems to be a timeout when the cm* ingress is ready and cert manager launched the probe. The pod was ready within seconds, however, it took around 10 seconds until the ingress-nginx actually connected to the pod (Pod IP address visible in list).
This only happened for one certificate out of 60 for me.
Downgrading cert-manager to 1.15.3 works as a workaround.


chore: home playlist now fixed size

Codecov Report

Merging #139 into development will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #139      +/-   ##
===============================================
+ Coverage        97.12%   97.13%   +0.01%
===============================================
  Files               53       53
  Lines              278      279       +1
  Branches            25       25
===============================================
+ Hits               270      271       +1
  Misses               8        8

Impacted Files
Coverage Δ

src/components/Panel/index.tsx
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99836e0...20c4a2b. Read the comment docs.


Adds word break to name and filename class.

Old one

New One

Items List

Very clever! I never would have thought of that.


[spaceship] update_availability using Deprecated API

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
I tried running the command below on the Spaceship playground. The Spaceship tunes_client uses deprecated ASC API which does not exist anymore.
Command executed
app = Spaceship::ConnectAPI.get_app(app_id: <app-id>).first
availability = Spaceship::Tunes::Availability.from_territories(["US"])
Spaceship::AppVersion.client.update_availability!(app.id, availability)

Complete output when running fastlane, including the stack trace and command used
Spaceship::UnexpectedResponse: <?xml version="1.0" encoding="UTF-8"?>
<String>There is no route for the path 'apps/<app-id>/pricing/intervals'.</String>

from /Users/<username>/.gem/gems/fastlane-2.221.1/spaceship/lib/spaceship/client.rb:793:in `parse_response'

Ohk i want to know more

Feel free to check out https://github.com/fastlane/fastlane/pull/22243/files as a first pointer. Always appreciating pull requests that add this functionality.


Cant create user/login

I get this error
Fatal error: Uncaught Error: Call to undefined method mysqli_stmt::get_result() in /home/currpuhm/public_html/lab/lib/functions.php:103 Stack trace: #0 /home/currpuhm/public_html/lab/index.php(35<EMAIL_ADDRESS>'Password') #1 {main} thrown in /home/currpuhm/public_html/lab/lib/functions.php on line 103

Hi, you need to enable mysqlnd on your server.
Try:
apt-get install php-mysqlnd
or one of the other options in the link below:
https://stackoverflow.com/questions/7250356/how-to-install-mysqli

execute phpinf (); and see if mysqlnd is active.
which hosting you this? and shared?

it is active, shared hosting.
On 19 February 2018 at 15:53, marcosmaia<EMAIL_ADDRESS>wrote:

execute phpinf (); and see if mysqlnd is active.
which hosting you this? and shared?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/foraern/ethos-panel/issues/3#issuecomment-366732929,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ai8AxV5hcPVUOj1S_H_eYcWxGJXYLllaks5tWZkFgaJpZM4SKrUh
.

Try this:
php 7:
sudo apt-get install php7.0-mysqli
php 5:
sudo apt-get install php5-mysqli

mysqlnd is also active? see has this as in the image below

localhost is working
mine is also shared and did not work due to mysqlnd
ask for it changes to PDO. more so if other users request most of the shared hosting does not have mysqlnd compiled

I'll start converting to PDO today or tomorrow...should be simple enough since it's all in prepared statements already, the major change is in the connection.

@foraern
Try this:
php 7:
sudo apt-get install php7.0-mysqli
php 5:
sudo apt-get install php5-mysqli
Extensions

https://www.screencast.com/t/bDvaoo0maQ

is this correct? they seemed to fix it however they broke my main domain

@DamianMachola I think you have something else going on there...none of the styles are loading...

@DamianMachola
copy assets to root of public_thml

this is what it should look like:
https://imgur.com/a/NVgCh
https://imgur.com/a/Bl4xN

@DamianMachola
Redirect your domain to / lab or install at the root or try copy assets to root of public_thml

@marcosmaia
I just moved assets to default dir and it works like a charm. What would I need to need to edit to change the default dir in the script, since its redirecting me to main site when i press dashboard and log out

you need to change the html templates, they all have links to "/", and the same in the main php files (in root directory), anywhere you see header('location: /') to point to the folder you use.
May be easier just to create a new virtualhost and point it to the folder and use the folder as the root folder for that virtualhost.


Improve S3 documentation, testing and support

Improvements to S3 Documentation

Create a new document quickstart_paths.md that give a summary of the legal path formats used by netcdf-c. This includes both file paths and URL paths.
Modify nczarr.md to remove most of the S3 related text.
Move the S3 text from nczarr.md to a new document cloud.md.
Add some S3-related text to the byterange.md document.

Hopefully, this will make it easier for users to find the information they want.
Rebuild NCZarr Testing
In order to avoid problems with running make check in parallel, two changes were made:

The nczarr_test test system was rebuilt. Now, for each test.
any generated files are kept in a test-specific directory, isolated
from all other test executions.
Similarly, since the S3 test bucket is shared, any generated S3 objects
are isolated using a test-specific key path.

Other S3 Related Changes

Add code to ensure that files created on S3 are reclaimed at end of testing.
Used the bash "trap" command to ensure S3 cleanup even if the test fails.
Cleanup the S3 related configure.ac flag set since S3 is used in several places. So now one should use the option --enable-s3 instead of --enable-nczarr-s3, although the latter is still kept as a deprecated alias for the former.
Cleanup S3 portion of libnetcdf.settings.in and netcdf_meta.h.in and test_common.in.
Merge partial S3 support into dhttp.c.
Change the region defaulting mechanism to be as follows: if default is a defined profile, use that, otherwise use a fake profile no. The no profile used to be called none. It can only be used for non-authenticating requests.
Create an experimental s3 access library especially for use with Windows. It is enabled by using the options --enable-s3-internal (automake) or -DENABLE_S3_INTERNAL=ON (CMake). Also add a unit-test for it.
Move some definitions from ncrc.h to ncs3sdk.h

Other Changes

Provide a default implementation of strlcpy and move this and similar defaults into dmissing.c.

Addendum [5/9/23]
It turns out that attempting to test S3 using a github action secret is a very complex process. So, this was disabled for github actions. However, a new run_tests_s3.yml action file was added that will eventually encapsulate S3 testing.

I have fixed the S3 testing in github actions. I have isolated the S3 testing to a new action file
name run_tests_s3.yml.
It should serve as the basis for the final fixes for doing manual invocation of S3 testing for github actions.

Thanks @DennisHeimbigner working through the rest of the review now.


multi: Add gRPC price server option

Adds ability to set a gRPC endpoint to hit for dynamic resource prices of a service. The backend service must then implement the gRPC service that will supply the prices for the various resources.
This is a quick POC. I wrote a very simple service here to test and demonstrate this change.

Thanks for the review @guggero  😊  Cool, I will update as you have suggested and open a PR to the main repo 👍

Out of curiosity: What are the main factors that in your use case determine the price? Is it really just the path itself? Or also a time based component?

The factor is the path (could be time too). But im thinking of the cases where new resources are constantly added and where each of those resources will have a different price (and some may even be free). My specific use case is a blog website where I want to add new blogs (with incrementing IDs) and want to be able to set and change the price of the blogs without needing to configure aperture for each individual one.

gonna close this and open to upstream repo


Remove empty spaces

Files:

Chapter5/001_basic_parallelism/002.py
Chapter5/001_basic_parallelism/003.py
Chapter5/001_basic_parallelism/004.py
Chapter5/001_basic_parallelism/005.py
Chapter8/api/app.py
Chapter8/flask_basics.py

contains empty spaces, which can be removed.

Hi @pnijhara
Since the book is still under production, these are not the final files. There may be changes and updates to the code depending on the testing done by the technical editor. We'll make sure to check on this issue and resolve it while testing.
Thanks for the heads-up!


Question on dropping function

Hi, I have one question on function dropping in layers.py.
I don't understand why learned group convolution still needs the shuffling operation?
        weight = weight.view(d_out, self.groups, self.in_channels)
        weight = weight.transpose(0, 1).contiguous()
        weight = weight.view(self.out_channels, self.in_channels)

https://github.com/ShichenLiu/CondenseNet/blob/master/layers.py#L78
I notice there is a shuffle operation mentioned in 4.1's first graph:
"we permute the output channels of the first 1x1_conv learned group convolution layer,
such that the features generated by each of its groups are evenly used by all the groups of
the subsequent 3x3 group convolutional layer"
However, this operation aims to shuffle feature maps, not convolutional kernels.
Can you explain a little bit?
Thanks in advance

Hi,
During testing, we explicit shuffle the feature channels. However, during training, we implicitly shuffle the feature channels by choosing to drop certain kernels. These are equivalent mathematically.

@ShichenLiu Thanks for your reply, however, I still cannot understand theses two parameters in layers.py ? Can you explain a little bit?

What the difference between _stage and stage? In other words, what is the function
self._reach_stage() check for?
https://github.com/ShichenLiu/CondenseNet/blob/master/layers.py#L111-L112
In dropping function, what does the parameter _count record?
https://github.com/ShichenLiu/CondenseNet/blob/master/layers.py#L89

@ShichenLiu


Missing CelebA checkpoint

Hi there,
many thanks for making your code publicly available! I wanted to try out the model for CelebAHQ restoration, but ran into the issue that the checkpoint URL you have in your code is unavailable (Access Denied). The URL in question: https://image-editing-test-12345.s3-us-west-2.amazonaws.com/checkpoints/celeba_hq.ckpt
It would be great if you could provide an updated URL for a checkpoint :) Cheers!

The CelebA-HQ checkpoint was taken from SDEdit. If there is an access denied issues, please contact the original authors of SDEdit.


Hide environmant variable value in log message

Walter interpolates environment variables and shows them in log message when environment variables are shown in commands.
But environment variables may have secret information like API keys, secret keys and so on. So this behavior is not desirable.

Thank you for valuable comment! I will fix this problem.

Fixed with #87


Remove support for netcoreapp2.1 and add support for net6.0

Solves #192 and adds support for net6.0

Help wanted with following problem: https://github.com/rr-wfm/MSBuild.Sdk.SqlProj/issues/192#issuecomment-921158637

@jmezach The build pipeline does not yet support net6.0 sdk

@AroglDarthu We can fix the pipeline by modifying the workflow. We should probably remove .NET Core 2.1 there as well and add .NET 6. Be aware that there are a couple of places where we install .NET SDK's in there.
Really appreciate you helping us out with this!

Cool. Never looked at github workflows before. I'll do some reading on it in the weekend ;-)

Looks like this is finally working, so I think it will be a good idea to merge to master and ship a preview release for folks that are on .NET 6 already while we wait for a stable version of DACFX before we ship a stable version. @ErikEJ @jeffrosenberg Perhaps you guys can give this a review. Thanks to @AroglDarthu for his initial work on this.


Alias for identity

identity gets typed a lot, and I already have a keyboard macro \id → identity for it.
Thinking if it should be aliased to something like I, as it used to be in ramda.

I makes sense to me.

shift+i is two keys, and id also is two keys.

I settled on id because
$ ... | R I

looks funny


~twitch command issue [BUG?]

So, I got this bot from here
And I tried the twitch command, and this is what I get from it.
Tried HappyStick's Stream
Then my friend tried numbers after the name
Then I tried numbers IN the name...
Update:
So I tried the command again and it somehow worked
Then I use the ~rms command to remove it from the channel to put it into the new one, and now...
I get this...

Not a bug, just a lot of people using that feature, and response can be wrong. Just try again. Sometimes it will work, sometimes not. Waiting on Twitch to fix it, tbh.

Ok, it has nothing to do with numbers in the name. I tested all of the examples you provided and they all work. The reason it sometimes doesn't work is, as mirai pointed out, we might be being ratelimited by twitch because we are sending thousands of requests per second when checking are streams live.
Just try at some other time and it will work.


Added user info to db error

Added getUserInfo function in User.coffee to which  returns information of current user.

Nice work–thanks @amankr! This fixes #1953.


Improve VS Code plugin debugger experience

Problem definition
Need to refactor VS Code plugin debugging feature UI, so that it can gives a better experience by giving a detail view of the authentication flow. And change the views dynamically. Further we can improve the UI design a bit that can give a VS Code UI feeling.
And as a part of this improvements Templated resource definitions are introduced in the latest products. Most of the latest flow depends on this templates to initiate. There are efforts to improve the plugins to plugins for each template definition thus plugin UI need to be improved to accommodate them.
Preferred Solution
Revamp the UI to support templates in UI.
Tasks

[ ] Identify the templates definitions
[ ] Revamp the plugin UI

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Deduplicate table population

The table is currently populated in two places with different methods:

by PHP in index.php
by jquery in includes/uploader.js

Since they both do the same thing, only one should be necessary.

Yes, as long as only one is capable to keep the table (and chart) alive during app navigation and page refresh.


Outline constraints for interface from distribution to core

Signed-off-by: Stephen J Day<EMAIL_ADDRESS>cc @icecrime @jfrazelle @shykes @ncdc @vbatts @dmp42 @dmcgowan @jlhawn

LGTM

LGTM

LGTM


T1.4b Past Event Members Assembly

http://iati.surge.sh/page-templates/04-1b-past-events-single
Variation of past event for the members assembly, spawned from this card: https://trello.com/c/MVuM8dYB
Will have same model as event single template
From Trello card: https://trello.com/c/8DiXe676/99-t14b-past-event-members-assembly

Now implemented. Closing issue.


Add Arctic wallet into the list of desktop wallets

We are the arctic team, and we built a desktop wallet, that supports BCH for hold, send, receive, exchange between 100 other currencies, and buy it to your wallet.

How can we close pull request to add our project on the webpage?

We'll need someone well-known in the community to be able to vouch that your wallet is legit, and that they have personally used it at least for some minimal functions to be able to say that.
While @melroy89 have approved the PR, I have not verified if he's able to say that yet.

Indeed according to https://arcticwallet.io/assets bch is supported. And allow you to use exchange and bank card purchase as well as fix rate swap.

@melroy89 that is not good enough. Have you personally used it? Can you offer your experience doing that?

Ow sorry. No, I didn't.


Error: [remix] dest already exists.

Reproduction
Using this template 👉 https://github.com/kiliman/remix-vite-template that doesn't differ very much from the official one 👉 https://github.com/remix-run/remix/tree/main/templates/vite-express
It gives the following error when running remix vite:build:

This only happens to me after upgrading to 2.7.0 of Remix
System Info
System:
    OS: macOS 14.3.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 104.86 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
    bun: 1.0.28 - /opt/homebrew/bin/bun
  Browsers:
    Chrome: 121.0.6167.184
    Safari: 17.3.1

Used Package Manager
npm
Expected Behavior
Build normally like the previous version (2.6.0)
Actual Behavior
Breaking the builds

Same error from this issue reported too 👉 https://github.com/remix-run/remix/issues/8814 I'm using CSS URLs too

Closed my issue as a dupe.
For reference, this broke in<EMAIL_ADDRESS>and carried through to 2.7.0 stable (it was fine in @remix-run/dev@2.7.0-pre.1).

Can confirm that I am experiencing the same issue but my build fails with different fatal error when I try to remove ?url.
vite v5.1.3 building for production...
✓ 95 modules transformed.
x Build failed in 392ms
Error [RollupError]: "default" is not exported by "app/tailwind.css", imported by "app/root.tsx".
file: /Users/pavelsevcik/WebstormProjects/samourai-fees/app/root.tsx:7:7
5: import robotoFlex from "@fontsource-variable/roboto-flex/index.css?url";
6:
7: import styles from "./tailwind.css";

Thanks for raising this. I've found the problem, I should have a fix ready soon.

@pajasevi Your issue is expected when removing ?url from the CSS import since Vite won't provide a default export anymore.

@markdalgleish this issue also occurs if you add extra entry points that are css files to the vite pipeline via plugins:
e.g.:
function extraEntryPoints(): PluginOption {
  return {
    name: "extra-entry-points",
    apply: "build",
    config(config, { command }) {
      if (command !== "build") {
        return;
      }

      return {
        build: {
          rollupOptions: {
            input: ["app/entry.inter.css"],
          },
        },
      };
    },
  };
}

@robertjpayne Ah, that's interesting. If the build passes, how would that extra CSS file be part of your Remix app?

@markdalgleish it just gets processed as it's own entry point so it gets put into the assets folder and added to the vite manifest. It was working in 2.6.0 and earlier.

This just bit me too. Excited about the vite support!

Yeah, I'm experiencing same issue. It happens with any css file that is imported using Links if using ?url which is required for Vite.
import anything from "./anyfile.css?url";

export const links: LinksFunction = () => [
    { rel: "stylesheet", href: anything }
];

@robertjpayne Thanks for sharing that repro. I've just confirmed that the PR fixing this issue also fixes your issue: https://github.com/remix-run/remix/pull/8829

H! Please don't mind me cause I am new to this, but how do you find out that the error causes by the css import with url?

@Lenghak Because if you remove the ?url the error goes away :). It takes a bit of trial and error but basically I'll have a hypothesis for what might be causing the issue. If it isn't the issue, I'll keep trying different possibilities trying to isolate the problem further.

Right, sir. So it does require some experiences in order to come up with some hypothesizes or even have a sense to suspect where the error could be. I, personally, wouldn't think that the it comes from the CSS cause the error shows entirely different message. Thank you for your explanation sir, I really appreciate it.

This is fixed by https://github.com/remix-run/remix/pull/8829, it'll be out in the next patch release.

@danestves @robertjpayne Can you please confirm that v2.7.2 fixes your issue?

@markdalgleish It fixed it, thank you. ❤

I can confirm this is fixed for me as well. Thank you guys.

Fixed thanks!

works up until 2.9.1, seems to be back with 2.9.2


FIX: bring tests in line with config

This fixes most of the tests, bar the pdf export. I'll merge this, and iterate in main.


Add auto merge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/pyperclip-feedstock#13.


Enabled the email alert

Type of change
Note: Fill x in []

[ ] bug
[ ] enhancement
[x] documentation
[ ] dependencies

Description

Enabled the email alert in Eyal account.
Removed the POC folder

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma, I think u should create a dedicate folder for Eyal and not mix it with Haim, WDYT ?

@athiruma, I think u should create a dedicate folder for Eyal and not mix it with Haim, WDYT ?

I created a qe folder and added Eyal account.


Undefined index: mail_template

Hi,
After the latest update I am receiving this error when submitting forms.
I have not check the 'Send Auto-Response' option in my component and it is giving an alert message with this error when submitting the form.
I then added the default mail template for the auto-response but it's still giving the same error. How can I fix this?
Thanks for your kind assistance.

I've updated from the git repo, so after doing artisan october:up it's all working fine now.

"Undefined index: mail_template" on line 15 of \testsite\plugins\martin\forms\classes\SendMail.php"

Fixed.
Thanks.-


fix/test: Fix handling of invalid requests, increase test coverage

Previously the Connaisseur logger may have failed to properly log invalid requests. Increase test coverage for flask server. Prevent some tests from leaking environment variables beyond their scope.

Codecov Report

Merging #63 (0c5d8af) into master (59a7e60) will increase coverage by 2.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   93.15%   95.91%   +2.75%
==========================================
  Files          14       14
  Lines         628      636       +8
==========================================
+ Hits          585      610      +25
+ Misses         43       26      -17

Impacted Files
Coverage Δ

connaisseur/flask_server.py
93.87% <100.00%> (+22.44%)
:arrow_up:

connaisseur/mutate.py
100.00% <100.00%> (+5.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59a7e60...0c5d8af. Read the comment docs.


adapter-node assets throw 404 in NGINX reverse proxy

Describe the bug
Deploying a node server behind a reverse proxy doesn't show assets on client side. I don't know if I'm missing a file or if my DevDependencies / Dependencies section in my package.json are wrong.
Reproduction
1- Build production and get production dependencies with npm run build && npm ci --prod.
2- Upload the following files / folders to production server:

build/
node_modules
package.json
static/

2.1- (Experiment) Get anxious and upload the whole project directory except src/ and dotfiles like .git or .github
3- Use the following reverse proxy configuration:
	location / {
        	proxy_http_version 1.1;
        	proxy_set_header Upgrade $http_upgrade;
        	proxy_set_header Connection "upgrade";
        	proxy_set_header Host $host;
        	proxy_set_header X-Real-IP $remote_addr;
        	proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        	proxy_set_header X-Forwarded-Proto $scheme;
    		proxy_set_header X-NginX-Proxy true;

        	proxy_pass http://localhost:3000;
	}

4- Enter your site URL:

Logs
No npm logs other than 404 logs similar to the client-side ones.

System Info
## Development Machine
  System:
    OS: Linux 6.0 Debian GNU/Linux bookworm/sid
    CPU: (4) x64 Intel(R) Core(TM) i7-7600U CPU @ 2.80GHz
    Memory: 10.03 GB / 15.39 GB
    Container: Yes
    Shell: 5.2.2 - /bin/bash
  Binaries:
    Node: 18.12.1 - /usr/bin/node
    npm: 9.2.0 - /usr/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Firefox: 102.6.0esr
  npmPackages:
    @sveltejs/adapter-auto: ^1.0.0 => 1.0.0
    @sveltejs/adapter-node: ^1.0.0 => 1.0.0
    @sveltejs/kit: ^1.0.0 => 1.0.1
    svelte: ^3.54.0 => 3.55.0
    vite: ^4.0.0 => 4.0.3

## Test Server (Similar to prod)
  System:
    OS: Linux 5.10 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
    CPU: (1) x64 AMD EPYC 7601 32-Core Processor
    Memory: 676.98 MB / 976.59 MB
    Container: Yes
    Shell: 5.1.4 - /bin/bash
  Binaries:
    Node: 18.12.1 - /usr/bin/node
    npm: 8.19.2 - /usr/bin/npm

Severity
annoyance
Additional Information
Is there special documentation to be followed when deploying a site and needing the static files? Am I deploying something the wrong way?

I noticed something else:
By leaving the environment variable HOST in <IP_ADDRESS> the site is accessible with the server IP + port and assets do load there.
I tried changing it to other values but nothing works. Here are the values I tried:

<IP_ADDRESS>
localhost
server-ip
domain.name
https://domain.name

The other variables like ORIGIN , PROTOCOL_HEADER and HOST_HEADER are set as well but nothing seems to work so far.

Working on fixing it. Would rather keep the solution to myself rather than documenting a baboon-ishly written adapter with a horrible deployment process...


Https Everywhere

There are a lot of http: links in the Abseil files.. shouldn't these be https:?

This is low priority but would be nice for a good first issue.  We want to make sure all the links can actually support https.

Hello @JonathanDCohen,
I am new to open source and would like to contribute to the project by making minor fixes. I have gone through the codebase. Can you help me with how to begin with this issue?

@SuchismitaDhal This issue is about as straightforward as it gets. Find all the non-HTTPS links in the codebase. Check to see if the site supports HTTPS, and if it does, replace the HTTP link with an HTTPS link.


rust-psp linking with rust-lld failed

Version of embedded-graphics in use (if applicable): 0.7.1
Target: PSP
If using real hardware: rust-psp

https://github.com/overdrivenpotato/rust-psp
Description of the problem/feature request/other
I try to update the version of embedded-graphics in the rust-psp crate. But I cannot compile the example. If there is now .draw call in the code it compiles otherwise not. Check https://github.com/overdrivenpotato/rust-psp/issues/102
Test case (if applicable)

Clone https://github.com/FloVanGH/rust-psp
Check the readme for the setup
Navigate to examples/embedded-graphics and run cargo psp.

Try to enable the fixed_point feature and check #616 for a related discussion.

Worked thank you :-)


Finalise Matching service

This PR sets up the entire frontend related to the matching service(Landing Page -> Topic Selection -> Loading Page ->(ToDo) Collaboration Page)
Setting up instructions remain identical to the previous PRs:
In the ROOT directory run

docker compose build --no-cache
docker compose up

then cd into frontend and run:

npm start

First quick manual testing. Here Reporting issues that may require more attention.
As a Single User it seems ok. Matching queue when no match after 30s indeed shows no match and allows for exit back to question selection page. Question Page works as expected with a Good Search function. Loading Page and animation does not seem to have issues.
However, when I log in to 2 users, unexpected behaviour:
App Behaviour Issues (High Priority)
Issue 1
Context: I log in as user1 first, go to Landing Page, THEN immediately open another tab, log in as user2. Apparently the tab on user1 will now be user2 upon refresh.
Potential solution: Use cookies or session ID to differentiate between users or browser tabs. React Redux may be used too, along with the specific user tokens
Issue 2
Context: I log in as user1 first, go to Landing Page, go to Question Page, then I select a topic and difficulty. WIthin the 30s timeout, Immediately open another tab, log in as user2, enter Landing Page, go to Question Page, select the same question topic (and difficulty).
Expected behaviour: Both users should be notified that a match has been found.
Actual Behaviour: The first tab with user1 has been overriden to user2 (related to Issue 1). Only this tab shows the Successful match found. The second tab with user2 remains at loading page, and after 30s, timeout happens.
More UI/UX Concerns (Moderate Priority)
Issue 3
There is no 'log out' button anywhere. Minimally put at Landing Page so that users can log in into another account
Issue 4
When selecting difficulty, the pop up is black backgorund, and the Rectangle boxes containing "Easy" "Medium" and "Hard" are also black (Before hovering). It is low contrast. I think minimally provide a border for the main pop up container and make it slightly wider using padding (In my 16-inch laptop it seems pretty squeezed)
Issue 5
There are no back buttons. Back buttons will be useful at Question Page (For going back to Landing Page).
For Loading Page, there is a cancel button which is good. But on hover, there is an insignificant color change. Consider color swap the button for greater contrast to signal to users that they are hovering on the Cancel button.
Less Significant Issues (Lower Priority)
Issue 6
Inconsistent naming of page URL address. If a page URL contains the substring "Page", then all other pages should also have. Currently there are loading, topics, LandingPg` (Abbreviation). Consider using one consistent style. Examples:

camelCase: landingPage, topicsPage loadingPage (Or simply landing, topics, loading to simplify naming)
PascalCase: LandingPage, TopicsPage, LoadingPage (Or simply Landing, Topics, Loading)
kebab-case: landing-page, topics-page, loading-page
snake_case: landing_page, topics_page, loading_page

Alright, thanks for the detailed analysis and feedback @freddychenyouren2 aka bossman.

Issue 1
Context: I log in as user1 first, go to Landing Page, THEN immediately open another tab, log in as user2. Apparently the tab on user1 will now be user2 upon refresh. Potential solution: Use cookies or session ID to differentiate between users or browser tabs. React Redux may be used too, along with the specific user tokens
Issue 2
Context: I log in as user1 first, go to Landing Page, go to Question Page, then I select a topic and difficulty. WIthin the 30s timeout, Immediately open another tab, log in as user2, enter Landing Page, go to Question Page, select the same question topic (and difficulty). Expected behaviour: Both users should be notified that a match has been found. Actual Behaviour: The first tab with user1 has been overriden to user2 (related to Issue 1). Only this tab shows the Successful match found. The second tab with user2 remains at loading page, and after 30s, timeout happens.

I believe that this issue can be addressed by making requests to the server from two seperate ports. Also agree, if we want to make independent requests from the same PORT, we can potentially integrate cookies or host the matching service server on GCP.
Also have tried to rectify issues 4-6 in the recent commits under this PR.
Would request @WinstonLeonard for help in setting up the logout button for addressing Issue 3

IMPORTANT
There is an issue on receiving the successful match feedback for BOTH users. This occurs when two unique users are trying to match and they are supposedly matched together successfuly. On backend matching-service, the POST \match appears to be working properly.
Expected behaviour: BOTH users should see Matched Successfully message.
Actual behaviour: Frequently, ONLY the first user that does POST will see the Matched Successfully message, and the other user is left hanging on the loadingPage, eventually leading to timeout.
Steps to reproduce:

Open two browser tabs
Log in to TWO Unique accounts (Here refered as user1 and user2)
For both users, navigate to topic selection page by clicking "Start a session" button
Select the same topics
Select any difficulty for both user1 and user2
Observe that the first user to wait the loadingPage will see Matched Successfully message, while the other user does not. This means that if we click the difficulty for user1 first then user2, only user1 gets to see Matched Successfully message. SImialrly, if we click the difficulty for user2 first then user1, only user2 gets to see Matched Successfully message.


Develop Data Needed DN_0057_4625_account_failed_to_log_on

Develop Data Needed DN_0057_4625_account_failed_to_log_on (Event ID 4625) using this template and related Logging Polic (if there is any) using this template.

DN_0057_4625_account_failed_to_logon created. Related LP_0004_windows_audit_logon.yml already in place.


[CELEBORN-355][BUILD][FOLLOWUP] Create shaded module for Celeborn common

What changes were proposed in this pull request?
Create shaded module for Celeborn common
Why are the changes needed?
Solve the jar package conflict problem when Gluten depends on Celeborn

cc @pan3793

Could you please elaborate more about "how do the Gluten use Celeborn"? Currently, Celeborn does not deploy the artifacts to Maven Central in the release process, should we do it in the future?

But celeborn-client-spark-3-shaded_2.12 should contain anything of celeborn-common-shaded_2.12, right?

We can consider shading common. and then when new components are introduced, new components do not need shades when relying on common.

It's not easy in Maven.

Let Celeborn's other modules depend on common-shaded does not look promising IMO, I suggest you do PoC before moving forward.

Let Celeborn's other modules depend on common-shaded does not look promising IMO, I suggest you do PoC before moving forward.

OK


navigation  next not work

navigation previous and next not working when click it will reload the page

jupp, same problem

Same problemt - I guess there's no support for this plugin

As it's the first time this kind of bug is reported, please consider adding more details of your settings and how to reproduce the problem

Right now when I click on next or previous it reloads the entire page.
Clicking on the numbers and first and last page is OK. Clicking on Previous and Next Reloads entire page.
I placed a break point on the on the NEXT click event and It looks like its skipping that function when I click on Next or previous. But it does hit the breakpoint when the page is first loaded.
This function does not fire on click.
$(elSelector + ' .easyPaginateNav a.next', plugin).on('click', function (e) {                     e.preventDefault();                     page = plugin.settings.currentPage < plugin.settings.pages ? parseInt(plugin.settings.currentPage) + 1 : plugin.settings.pages;                     displayPage(page);                 });

I used the JS file from your demo page and it works.

I was experiencing that problem as well. I went in and on lines 96 and 102 and I removed ", plugin" from both lines. That seems to have fixed the problem I was experiencing. Let me know if this change fixes it for anyone else.

Fixed with version 1.2 (and current master)


This introduces a script to install the prerequisites on minikube

This uses fairly recent versions of the prereqs, listed at the top of
hack/minikube.sh. I tested with minikube 1.13.1 and kubectl
1.19.2. Here's my minikube config:

cpus: 4
disk-size: 50g
kubernetes-version: v1.19.0
memory: 10240
vm-driver: kvm2

There's also a handy Knative Serving smoke test: hack/hello.sh
The files in deploy/69-temp/ include the following fix and can be
removed when the commented curl calls in minikube.sh are restored
after 0.18.1 is released:
https://github.com/knative/eventing-contrib/pull/1630
The missing K_SINK env var errors in the endpoint logs appear to be a
red herring. I successfully invoked the http-endpoint, but still need
to figure out mqtt, as I couldn't get past a connection refused
error.

This isn't fully-baked yet. It shows what I changed to get minikube working, but in doing so, I broke openshift, e.g. I just deleted the Route resources beneath deploy/, so we could probably reorganize things to support both. Suggestions welcome!


Adds ChangeControllerServlet and GetSessionServlet

Summary
Adds both ChangeControllerServlet and GetSessionServlet and includes their respective tests. ChangeControllerServlet updates the current session with the new controller of the name passed in in the request. GetSessionServlet retrieves the current session from the datastore and adds the ListOfAttendees to the JSON.

I think the session javascript class would have to change somehow, I printed what the JSON looked like on the java side:
{"sessionId":"EEEEE7","screenNameOfController":{"value":"Jessica"},"ipOfVM":{"value":"<IP_ADDRESS>"},"listOfAttendees":"[{\"sessionId\":\"EEEEE7\",\"screenName\":\"Jessica\",\"timeLastPolled\":\"Aug 3, 2020, 8:55:42 PM\"}]"},
I am not sure if the escape characters go away once the response is converted to a json in the Javascript.


[QUIZ-602] Copy quiz results and send email UI

Adds copy quiz results functionality
https://github.com/Constructor-io/constructorio-ui-quizzes/assets/7874219/cb492d59-3954-44c4-ba36-8c743e03a465

@mocca102 I wasn't able to pass onEmailResults callback to storybook and e2e tests though unfortunately. Will need some time to look into it but was wondering if you know what the issue is right away 🙂

@mocca102 I wasn't able to pass onEmailResults callback to storybook and e2e tests though unfortunately. Will need some time to look into it but was wondering if you know what the issue is right away 🙂

Oh nvm 👍 figured it out here: 4e8c041e63ee0b808f2d79b504b85cadb02b1ecb

Are we going to add the handling of the loading of the copied url and rendering the results in a separate PR? @lws803

Are we going to add the handling of the loading of the copied url and rendering the results in a separate PR? @lws803

Yes there will be a separate PR for that 😄 https://github.com/Constructor-io/constructorio-ui-quizzes/pull/146

Thanks for making the changes!


DOC: update configuration tutorial

updates the "how to configure MNE-Python" tutorial (and moves it into the "intro tutorials" section instead of "misc").

Travis error is a line-too-long PEP error (I consider it a false alarm: it's a URL target in an rST block).
LTGM alerts can also be ignored: redefining the same variable 3 times in a row sometimes makes sense in a tutorial.
here's the circle rendering: https://13195-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/intro/plot_configuration.html

Ready for review, but please DO NOT MERGE YET as this PR has exposed a limitation in Sphinx-Gallery --- we want to be able to actually display warnings sometimes, but SG makes this impossible: either a warning is filtered and not shown, or it is shown and therefore breaks the tutorial build.  Either @larsoner or I should have a SG fix in place within a week or so.

merged after circle green, since last commit only changed .circleci/config.yaml


Get currently playing file fragment path?

Question or request really, can you get the currently played path?
I can see the list of fragments being downloaded in the chrome network debugging but was wondering if the play itself can give me what's currently being played?
Thanks

Hi @daniel-loader, if you are using the HLS playback (w/ hls.js) you can implement a floader, using the hlsjsConfig playback option, and get the path of each fragment loaded.
E.g.:
options.playback.hlsjsConfig = {
    fLoader: yourFloaderImplementation
}

To know about the hls.js loader details, check: https://github.com/video-dev/hls.js/blob/master/docs/API.md#loader
This help you?

Possibly, was looking for something that could just display a variable of the HLS fragment currently being played in the player. I'll have to have a read.

@daniel-loader if you need any help please update here, closing the issue.


error C2220 when build host engine on Windows10

ref to: https://chromium.googlesource.com/external/github.com/flutter/flutter/+/refs/tags/v0.2.3/CONTRIBUTING.md
send commands:
python .\flutter\tools\gn --unoptimized
python .\flutter\tools\gn --unoptimized --android
ninja -C .\out\host_debug_unopt -j 8
ninja -C .\out\android_debug_unopt -j 8

When send ninja -C .\out\host_debug_unopt -j 8,  throw the exception:
[Error infos]:
e:\engine\src\third_party\icu\source\common\unicode\stringoptions.h: error C2220: 警告被视为错误 - 没有生成“object”文件
e:\engine\src\third_party\icu\source\common\unicode\stringoptions.h: warning C4819: 该文件包含不能在当前代码页(936)中表示的字符。请将该文件保存为 Unicode 格式以防止数据丢失

how to fix it easier?

Hi @luori-mvp77
can you please double check your steps with the docs
thank you

Hi @luori-mvp77
can you please double check your steps with the docs
thank you

I check this docs before and also do that as it , i want tell you i can compile dart-sdk and android_debug_unopt version success, but i occurd this exception on host_debug_unpot compile.
So i need more infos to help reslove this issue,  can you enter more in this issue.
thanks.

save file format as uf8-bom .

Hi @luori-mvp77
It seems you are asking for assistance on personal code. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


scaling/limits/performance

what are the practical or theoretical limits of orbit-db (or ipfs)?
how many keys can one put in the kv store?
how many values can a key have?
does having either many keys and/or values have impact on

read speed?
write speed?
memory

does a node need the full db to read/write?

Moving this to the Field Manual to go into more details


Add cinder flexvolume test example

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #131
Special notes for your reviewer:
Release note:

/ok-to-test

/test cloud-provider-openstack-acceptance-test-lb-octavia

/test cloud-provider-openstack-acceptance-test-lb-octavia

/test cloud-provider-openstack-acceptance-test-lb-octavia

/approve
/lgtm

/test cloud-provider-openstack-acceptance-test-keystone-authentication-authorization

/lgtm


Drop support for Java 8?

Java 8 is no longer receiving public updates. Our last few artefacts don’t work in Java 8 and there is no obvious way to ensure backward compatibility going forward.

Oracle will not provide public updates anymore, however, there are some other distributions of jdk8 such as Amazon's Corretto that have a longer support window.
For my uses, I can cope with jdk8 support being dropped, but it would be more convenient if it was still supported. At my company the transition to jdk11 will take quite a while.

I'm using Java 8 so I would be disappointed by dropping support for Java 8, because I won't be able to use the library any more without forking it.
On the other hand there some new and relevant intrinsic functions like Arrays.mismatch in Java 11. What about a Java 11 branch that can be released from, which could become master at some point in the future, but in the mean time enables usage of new language features?

Looking at the list of "used by" in https://github.com/RoaringBitmap/RoaringBitmap/blob/RoaringBitmap-0.7.26/README.md , it looks like some of them are may be stuck in the past for an unknown time.
Spark looks like it is trying to be java 11 compatible for 3.0.0 ?https://issues.apache.org/jira/browse/SPARK-24421
Hadoop (Hive by proxy?) is not that close to java 11 support https://cwiki.apache.org/confluence/display/HADOOP/Hadoop+and+Java+9%2C+10%2C+11
Druid probably won't upgrade until Hadoop works: https://github.com/apache/incubator-druid/issues/5589
And there are others as well. Is this ticket about the source code or the generated bytecode?

On the other hand there some new and relevant intrinsic functions like Arrays.mismatch in Java 11. What about a Java 11 branch that can be released from, which could become master at some point in the future, but in the mean time enables usage of new language features?

If it is only a change to the internals and not the public api, then a multi-release jar would probably be a better option. That way there is one artifact and the most optimal version can be used based on the JDK the user is running.

There is no support for this idea. Closing.

@brharrington I haven’t experience of multi release jars - is there anything to watch out for? There are four or five places the vectorised mismatch intrinsic would be relevant in this library- it might be worth the bother.


Add an X parameter to the Likelihood.

Add an X parameter to the Likelihood class methods.
This will make it easy/possibly to write heteroskedastic likelihoods.
I plan to do more with heteroskedastic likelihoods in downstream PRs, but I want to get the "controversial" part of it out of the way first.
Basically this is the controversial part, because this is a breaking change.
To guesstimate the scale of the breakage, consider our notebooks. We have 35 notebooks doing all kinds of advanced stuff. A single one of those breaks.

In principle, I am happy with this proposal. The only thing is that sometimes the order of input args seems inconsistent. It would be good to know why that is the case.

Basically, our quadrature code operates over the first argument, so a couple of places I have had to change parameter order to have F as the first argument.


(cue.opt).required = true is ignored in encoding/protobuf

What version of CUE are you using (cue version)?

$ cue version
cue version v0.1.1 darwin/amd64

Does this issue reproduce with the latest release?
yes.
What did you do?

I'm using (cue.opt).required = true in my .proto.
message FooBar {
  string id = 1 [
    (cue.opt).required = true
  ];
}

but its ignored in encoding/protobuf. I got id?: string @protobuf(1) in .cue file.
What did you expect to see?
id: string @protobuf(1) . just without ?
What did you see instead?
id?: string @protobuf(1)

https://github.com/cuelang/cue/blob/bcc19cee6187fb3f09248d3dd04439fe5eb80834/encoding/protobuf/parse.go#L759
case "(cue_opt).required": 🤔
case "(cue.opt).required": 👍

This issue has been migrated to https://github.com/cue-lang/cue/issues/351.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


Remove /static/js/anchor-4.1.1-min.js

Description: The following PR completes #22040 and serves as my first contribution to an open source project. 🎉  I removed anchor-4.1.1-min.js from /static/js/anchor-4.1.1-min.js, not /scripts/js/anchor-4.1.1-min.js as no such file exists in /scripts. Then, I removed the corresponding call in /layouts/partial/head.html.
Help Needed: I was not able to preview my changes locally. After installing Hugo, I ran into a "socket too many files open" error. I learned how to check and change maxfiles and maxfileperproc (using this site: https://krypted.com/mac-os-x/maximum-files-in-mac-os-x/) but I felt uncomfortable making a permanent change without fully understanding what the side-effects would be (if there are any at all). If you could please suggest how I may go about solving this error, I would appreciate it, as I feel I'll run into it again. Thank you.

CLA is signed
For your review: /assign @jimangel

/assign
Hi @sabazubair! Thanks for taking this on!
I've raised your concern re: the build error you encountered locally on the #sig-docs channel in the Kubernetes slack workspace. I encountered a similar issue (and set the maxfiles higher – it's nbd), but you're the only other person I've seen who's had the same problem.
I'll review this change for you, since I created the issue!
PS: Saba is the name of one of my best friends ❤

Thanks @celestehorgan ☺

/lgtm
I tested this by:

Navigating to a docs content page, i.e. https://deploy-preview-22311--kubernetes-io-master-staging.netlify.app/docs/concepts/overview/what-is-kubernetes/#why-you-need-kubernetes-and-what-can-it-do, and noting that both the side nav links work and that anchor links are added beside every header.
Navigating to a blog post page, i.e. https://deploy-preview-22311--kubernetes-io-master-staging.netlify.app/blog/2020/06/working-with-terraform-and-kubernetes/#terraform-kustomize-provider, and noting that both the side nav links work and that anchor links are added beside every header.
Checking all top level pages: Training, Parnters, Community, Case Studies Home and noting that anchor links were not generated on headers for these pages.
Checking individual case study pages, i.e. https://deploy-preview-22311--kubernetes-io-master-staging.netlify.app/case-studies/spotify/, and noting that anchor links were not generated on headers for these pages
Checking a translation for all items listed in 1-4.
Searching the repo for the string anchor-4.1.1-min.js (and finding nothing)

May I suggest @sftim or @onlydole do a second review and double-check?

By the way @sabazubair, could you try building this again locally and then copy-pasting the error log either here or in the #sig-docs channel?

Hey @celestehorgan. Thanks for your help so far. Here's the error I get when I run hugo server --buildFuture: ERROR 2020/07/10 15:20:12 Error: listen tcp <IP_ADDRESS>:1313: socket: too many open files. You mentioned changing maxfile limit is fine. Should I go ahead with that and try again? I require some guidance here though, for example: What limit would be acceptable?

/approve

/check-cla

@sabazubair could you leave a comment on this PR with the words "I signed it"? This will retrigger the CLA check and allow us to merge the PR.
/check-cla is apparently not working.. 🤔

I signed it.

I'm also going to fix the PR title
/retitle Remove /static/js/anchor-4.1.1-min.js

/check-cla

Hey @sabazubair,
Could you follow the instructions here when you have a moment? It looks like your commit isn't linked to an email address, which is why the CLA check is failing.
(Don't despair! Everyone's first commit to a big open source project is a bit rough.)

Hey @celestehorgan. Sorry about that. I've followed the link as best as I can (Github's UI has changed). It should work now. I would re-trigger /check-cla for you, but I'm unsure if I have that privilege (guess I'll find out shortly). Fingers crossed!

@celestehorgan I ran git log on my branch and understand why the cla check is failing. I made the commit using my (former) work email. Fixing now. In case someone is running into the same issue, you can pass this along:  https://stackoverflow.com/questions/26004587/git-commits-are-not-getting-linked-with-my-github-account

@celestehorgan I ran git log on my branch, as suggested here, and know why the CLA check is failing. I recently changed my github email from my work to my personal email address. I have navigated back into my branch and changed the git config but when I refresh here, I don't see that change being reflected. Any ideas? Going to keep trying. Thanks for your help so far!

@celestehorgan I contacted Github and they advised me to re-add my work email. I did. It should be good now. Thanks for your help & encouragement. (Alternatively, I could've re-written the repo history but they did not recommend that.)

/area web-development


A different layout for a different page?

Is your feature request related to a problem? Please describe.
I'm not sure if this was implemented already in Quartz, but it'd be nice if it is possible to choose a different page layout for a different page. For example:

/index.md has no sidebars.
/release-notes/*.md has the sidebar for release notes.
/docs/*.md has the sidebar for the documentation pages (with custom ordering)

Describe the solution you'd like
Quartz could allow a user to expose a function that maps a page, its type (list vs. content) and its metadata (frontmatter?) into a PageLayout in quartz.layout.ts. For example:
export const getPageLayout: PageLayoutFunction = (path, type, frontmatter, ...) -> {
    if (type == PageType.LIST) {
        return listPageLayout;
    }

    if (path.startsWith("/news/") {
        return newsLayout;
    }

    return defaultContentPageLayout;
}

getPageLayout and other properties (defaultContentPageLayout and defaultListPageLayout) could be mutually exclusive, such as emitting a warning message when both are exported.
Additional context
I'm exploring the idea of using Quartz for generating a web site for an open source project - https://armeria.dev As you see, the homepage has no sidebars and each section has slightly different layouts from each other.

You can do this from within the components themselves as they are passed on the file data. You could, for example, hide a certain component on a certain page by doing an early return with null if the slug matches some path
e.g https://github.com/jackyzha0/jackyzha0.github.io/blob/db58591f9291df6f789e80294a343c5ffd424918/quartz/components/Breadcrumbs.tsx#L62-65

I see. So I insert all components in the layout and enable/disable them conditionally, right? Makes sense. Thanks for the reply.


Bump version to 1.7.1

(mostly to deliver https://github.com/grpc/grpc/pull/13169).

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Superseded by https://github.com/grpc/grpc/pull/13168


Use latest charts-build-scripts, add rebase script, rebase Project Monitoring, and add e2e workflows to verify with docs

Issue:

Problem

Solution

Testing

Versioning
For Community Members or Maintainers Making Changes
Please checkmark one of the boxes below to indicate you have following the versioning guidelines for rancher-project-monitoring:

If you are introducing a change to packages/rancher-project-monitoring or packages/rancher-project-grafana:

[ ] Increment the patch version in the version of packages/rancher-project-monitoring/charts/Chart.yaml by 1

[ ] I am not introducing a change to package/rancher-project-monitoring

Note: We do not use RC versions for rancher-project-monitoring since it is hidden anyways and not intended for standalone use

Please checkmark one of the boxes below to indicate that you have followed the versioning guidelines for prometheus-federator:

If you are introducing a change to main.go or packages/rancher-project-monitoring (including a change introduced in the above step):

[ ] If packages/prometheus-federator/charts/Chart.yaml has a version that is a -rc version, increment the -rc version in this file by one (i.e. 0.1.2-rc1 -> 0.1.2-rc2). Modify the appVersion to match this new version. Modify the helmProjectOperator.image.tag in packages/prometheus-federator/charts/values.yaml to match this appVersion.
[ ] If packages/prometheus-federator/charts/Chart.yaml has a version that is not a -rc version, increment the patch version in this file by 1 and add -rc1 (i.e. 0.1.1 -> 0.1.2-rc1). Modify the appVersion to match this new version. Modify the helmProjectOperator.image.tag in packages/prometheus-federator/charts/values.yaml to match this appVersion.

If you are only introducing a change to packages/prometheus-federator:

[ ] If packages/prometheus-federator/charts/Chart.yaml has a version that is a -rc version, increment the -rc version in this file by one (i.e. 0.1.2-rc1 -> 0.1.2-rc2). Do not modify the appVersion or the helmProjectOperator.image.tag in packages/prometheus-federator/charts/values.yaml.
[ ] If packages/prometheus-federator/charts/Chart.yaml has a version that is not a -rc version, increment the patch version by 1 in this file and add -rc1 (i.e. 0.1.1 -> 0.1.2-rc1). Do not modify the appVersion or the helmProjectOperator.image.tag in packages/prometheus-federator/charts/values.yaml.

For Maintainers Releasing The Chart On QA Validation
Please checkmark both of the boxes below to indicate that you have followed the versioning guidelines for prometheus-federator:

[ ] The -rc tag has been removed from the version in packages/prometheus-federator/charts/Chart.yaml
[ ] The -rc tag has been removed from the helmProjectOperator.image.tag in packages/prometheus-federator/charts/values.yaml

Engineering Testing
Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Addressed with https://github.com/rancher/prometheus-federator/pull/28, https://github.com/rancher/prometheus-federator/pull/30, and https://github.com/rancher/prometheus-federator/pull/32; the PR was split up as much as possible to assist with the review process.