Delay section display until ACH state has loaded

Details

Delays rendering the third section on the Workspace Reimburse Expenses page until the necessary data has loaded. This prevents a brief flash of different copy during loading
Fixed Issues
$ https://github.com/Expensify/App/issues/9057
Tests

Add a VBA to a workspace
Go to Settings > Reimburse expenses
Refresh the page
Verify the 3rd section heading is "Fast reimbursements = happy members!", and it does not flash a different heading prior to fully loading

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[ ] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps
Same as those listed under Tests

[ ] Verify that no errors appear in the JS console

Screenshots

Web

I couldn't test this on web locally due to CORS errors while using the Staging API.
Mobile Web

Same as above.
Desktop

https://user-images.githubusercontent.com/7277067/169904574-a58b04b9-0ba3-4d01-b96a-24d5c2eb5a57.mov
iOS

https://user-images.githubusercontent.com/7277067/169907291-72f66a95-343b-4488-bedf-eb249fd4d531.mp4
Android

I used the staging API because I needed to set up a VBA for the workspace as a prereq of testing. I followed this SO to do so. If you have other suggestions to get it working I'm all ears 😄 I just wasn't sure the ROI was there given that this change is so minor.

🚀 Deployed to staging by @luacmartins in version: 1.1.66-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Thanks for the response. That makes sense and I agree that the true fix would likely be to ensure the hasVBA value is persisted to Onyx immediately after a card is added (or something similar).

🚀 Deployed to production by @chiragsalian in version: 1.1.66-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Unify development, running and testing management

I'd add Makefile for this purpose. E.g. https://github.com/webknjaz/webchallenge-ato-children/blob/master/Makefile
This will help us unify commands regardless of whether we build front-end, static or run server.

@anxolerd Dropped it to master. Plz test.


EventHub: added new Kafka property in 2017 API version

Description
2017 API Version : added new Boolean property KafkaEnabled to enable Kafka for the Event Hub namepsace
Swagger PR: https://github.com/Azure/azure-rest-api-specs/pull/4321

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] Please add REST spec PR link to the SDK PR
[X] I have read the contribution guidelines.
[X] The pull request does not introduce breaking changes.

General Guidelines

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[X] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[X] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[X] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[X] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Closing this per offline conversations


Imports still pointing to "github.com/xingzhou/go_service_broker/*"

Need to change all imports to this new repo location

@maximilien @shalako I have submitted a patch to change the imports.

OK cool. Closing.


question about updater

Hi, just wondering is it OK to chain RemoveXXX && AddXXX together ? e.g.
    client.SomeTable.
        UpdateOneID(id).
        RemoveSomeEdges(...).
        AddSomeEdges(...)
        Save(ctx)

Hey @Jack-Ji! Yes, just created a PR (https://github.com/facebook/ent/pull/738) to show that it's possible.
Closing.

Nice, thanks for quick update!


Using s3 bucket works but when I switch to local model I get an error

Error: Error when checking : expected input_1 to have shape [null,299,299,3] but got array with shape [1,224,224,3].
    at new t (tf-layers.esm.js?271e:17)
    at checkInputData (tf-layers.esm.js?271e:17)
    at t.predict (tf-layers.esm.js?271e:17)
    at eval (index.js?9368:92)
    at eval (tf-core.esm.js?45ef:17)
    at t.scopedRun (tf-core.esm.js?45ef:17)
    at t.tidy (tf-core.esm.js?45ef:17)
    at Module.je (tf-core.esm.js?45ef:17)
    at NSFWJS.eval (index.js?9368:91)
    at step (index.js?9368:33)

<template>

    <img ref="img"<EMAIL_ADDRESS>

</template>

I see the issue.  You're using the larger model, right?
The larger model takes slightly larger images (299 pixels), so you can tell it you're using the more advanced model like so: const model = nsfwjs.load('/path/to/different/model/', {size: 299})
The 299 tells it to expect 299x299 tensors on the model.  Having 2 models with different sizes is the issue.  I have a note in the docs, but it's easy to miss.
I hope this fixes it!

It fixed the problem.
Thanks.


Confusing istiod.istio-system port name

Using master.
The docs at https://preliminary.istio.io/docs/ops/deployment/requirements/#ports-used-by-istio say
15010 | GRPC | Istiod | XDS and CA services (plaintext)
15012 | GRPC | Istiod | XDS and CA services (TLS)

yet kubectl -n istio-system get svc istiod -o jsonpath="{.spec.ports}" shows port 15012 has the name https-dns.  I don't think DNS is in the picture here.

Its a DNS based cert instead of SPIFFE. Agreed it should jst be called https though or something

we used to have https-spiffe I think so it made more sense then


BitcoinExchangeFH and ZeroMQ connection issues

Compiling and installation of both BitcoinExchangeFH and ZeroGQ is a smith process. However I have issues with connection to ZeroMQ. Linking of the Python binding seems to work.
From the README.md it looks like ZeroMQ should be running as a free standing server
(bitcoinexchangefh -zmq -zmqdest "tcp://localhost:6001" -instmts subscription.ini)

With the above options I got this stack backtrace:
Zmq client is connecting to tcp://localhost:6001
Traceback (most recent call last):
  File "/usr/bin/bitcoinexchangefh", line 9, in <module>
    load_entry_point('BitcoinExchangeFH==0.1.3rc3', 'console_scripts', 'bitcoinexchangefh')()
  File "/usr/lib/python3.4/site-packages/befh/bitcoinexchangefh.py", line 93, in main
    db_client.connect(addr=args.zmqdest)
  File "/usr/lib/python3.4/site-packages/befh/zmq_client.py", line 28, in connect
    self.conn.bind(addr)
  File "zmq/backend/cython/socket.pyx", line 495, in zmq.backend.cython.socket.Socket.bind (zmq/backend/cython/socket.c:5653)
    # sockopts will still raise just the same, but it will be libzmq doing
  File "zmq/backend/cython/checkrc.pxd", line 25, in zmq.backend.cython.checkrc._check_rc (zmq/backend/cython/socket.c:10014)
    raise ZMQError(errno)
zmq.error.ZMQError: No such device

The documentation seems to lack some information on this part.
I hope for some information that shed some light upon this.
Runnung the nodejs client/server combo works without a hitch.
I am not a Pythom programmer, BTW
Thanks!

Could you try replacing "localhost" with "<IP_ADDRESS>":
bitcoinexchangefh -zmq -zmqdest "tcp://<IP_ADDRESS>:6001" -instmts subscription.ini

This is the output I get:
Zmq client is connecting to tcp://<IP_ADDRESS>:6001

2017-07-20 03:09:37,204 - INFO
[[main]]
Subscription file = subscription.ini

2017-07-20 03:09:37,205 - INFO
[[main]]
Exchange/Instrument/InstrumentCode:

Then the program exits without further notice.
This command gives the same result:
bitcoinexchangefh -zmq -zmqdest "tcp://<IP_ADDRESS>:6001" -csv -csvpath data/ -instmts subscription.ini

One question: Is this supposed to act as both a server and client?
In case the program is supposed run in the background, I checked with netstat:
netstat -na | grep 'LISTEN '

gives no sign of port 6001
Thank you!

Thanks for your input @tuxitor and @LeonidShamis.
Yes I think the documentation states incorrectly on the zmq-tcp destination for localhost. "localhost", instead of "<IP_ADDRESS>", never works as the documentation specifies

An interface may be specified by either of the following:
The wild-card *, meaning all available interfaces.
The primary IPv4 address assigned to the interface, in its numeric representation.
The interface name as defined by the operating system.

For the second question, could you run it again with the following command (subscriptions.ini instead of subscription.ini)
bitcoinexchangefh -zmq -zmqdest "tcp://<IP_ADDRESS>:6001" -csv -csvpath data/ -instmts subscriptions.ini

I think the output message is opaque to tell the subscription file path is invalid. I will resolve it in the next release.
In your case, the application acts as a server at port 6001.

After nearly giving up when going to bed 3:30 AM, I was not sure I would continue next morning.
It was a relief get the message next morning and see it working!
One change I would like to see though, is to get the timestamp in milliseconds since epoch. What about a configurable format? I would also like to see more options for db and messaging (deepstream, redis, ...)
Thanks a lot!

Thanks for your suggestion.
The timestamp format has been tracked under #64.
Meanwhile, I am also looking for more ideas on which db/messaging system users are actively working/using. Open for further ideas. :)


can not load the url Image

Describe the bug
A clear and concise description of what the bug is.
can not load the Image
To Reproduce
Steps to reproduce the behavior if possible, or a link to a reproduction repo:
just use like this ,but  in iphone real machine , it dose not show.  and in IOS Emulator and android work well
<FastImage         style={{width: ux(180),height:ux(180)}}         source={{uri: "https://cloudflare-ipfs.com/ipfs/QmcFkLf1qk1QdrJJzqQxP2qRL45V8XomzGcZVdGXNyvxfj"}}       />
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Dependency versions

React Native version: 0.63.0
React version:16.13.1
React Native Fast Image version:8.3.2

Note: if these are not the latest versions of each I recommend updating as extra effort will not be taken to be backwards compatible, and updating might resolving your issue.
IOS Emulator and Android Real machine can show well . but in iOS Real machine  , it can not showed . can you help me ?
https://cloudflare-ipfs.com/ipfs/QmcFkLf1qk1QdrJJzqQxP2qRL45V8XomzGcZVdGXNyvxfj

+1 Also experiencing the same

did you figure whats the issue?


move caClient to separated pkg

https://github.com/istio/istio/issues/5903
code that communicates with CA will be in this pkg.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: diemtvu
Assign the PR to them by writing /assign @diemtvu in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @wattli @justinburke

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: quanjielin, wattli
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [wattli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


lora to original flux lora

Is there a script available for converting diffusers loras or kohya loras to original loras based on Black Forest Labs? Thanks!

I found the script in networks/convert_flux_lora.py.!!


Link to gh-pages.

Coverage remained the same at 76.389% when pulling 0b9b69074355c1321b6dab7ef8202880d851ba08 on feature/gh-pages into df2727f7fcded53128856cc9237d628aa0133b91 on develop.


Example

i need an example of chat and notification with gos , some one ?

Are you still in need?

I dont know how to make a notification sistem with database , so you have an example ?
Obtener Outlook para Androidhttps://aka.ms/ghei36
On Thu, Sep 15, 2016 at 8:35 AM -0600, "Ashura" <notifications<EMAIL_ADDRESS>wrote:
Are you still in need?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/GeniusesOfSymfony/WebSocketBundle/issues/157#issuecomment-247346499, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJvrjU5V04Crk6Ou3iZyRL6UbvbUitguks5qqVfBgaJpZM4Itwoi.

Do you mean push notifications or notifications on a website?

I mean push notifications and ... show to users.
Obtener Outlook para Androidhttps://aka.ms/ghei36
On Thu, Sep 15, 2016 at 11:31 PM -0600, "Ashura" <notifications<EMAIL_ADDRESS>wrote:
Do you mean push notifications or notifications on a website?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/GeniusesOfSymfony/WebSocketBundle/issues/157#issuecomment-247521533, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJvrjT4_-gnQCtYBmLx8IDBr3crLRdCmks5qqim7gaJpZM4Itwoi.

How are your Symfony and PHP skills? I only see some rather empty repositories on your account.

80% of skills in each one i have no repos in this accoun only in the work account
Obtener Outlook para Androidhttps://aka.ms/ghei36
On Thu, Sep 15, 2016 at 11:39 PM -0600, "Ashura" <notifications<EMAIL_ADDRESS>wrote:
How are your Symfony and PHP skills? I only see some rather empty repositories on your account.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/GeniusesOfSymfony/WebSocketBundle/issues/157#issuecomment-247522340, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJvrjS6xWaBnYoHKmlWCzmcmuKnCFd1fks5qqiubgaJpZM4Itwoi.

Do have the WebSocketsBundle installed and the client configured?

Yeah i have both configured my question is how to use the topic
Obtener Outlook para Androidhttps://aka.ms/ghei36
On Fri, Sep 16, 2016 at 1:20 AM -0600, "Ashura" <notifications<EMAIL_ADDRESS>wrote:
Do have the WebSocketsBundle installed and the client configured?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/GeniusesOfSymfony/WebSocketBundle/issues/157#issuecomment-247534770, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJvrjYDZ4gscCE6JuZXUav4eUPUlRyH5ks5qqkMfgaJpZM4Itwoi.

I made an eventlistener with this:
    /**
     * ObservationListener constructor.
     *
     * @param PusherInterface $pusher
     * @param CommandsHandler $handler
     * @param EntityManager   $em
     */
    public function __construct(PusherInterface $pusher, CommandsHandler $handler, EntityManager $em)
    {
        $this->pusher  = $pusher;
        $this->handler = $handler;
        $this->em      = $em;
    }

And this will send it then:
    /**
     * @param CommandEvent $event
     */
    public function onCommandEvent(CommandEvent $event)
    {
        /** @var Zulu $zulu */
        $zulu = $this->em->getRepository('AppBundle:User')->getLockedZulu($event->getUser()->getUsername());
        $this->pusher->push([
            'action' => 'moveMouse',
            'data'   => [
                'id'      => $event->getUser()->getId(),
                'command' => $event->getCommand(),
                'status'  => "You shouldn't care'"
            ]
        ], 'command_topic'
        );
    }

If you want more you have to show me what you programmed.

Is this ok for you?

I think this issue can be closed.


README.md: change 'peddle' to 'pedal'

Pedal is the act of using bicycle pedals. Peddle means to travel around selling something. I think you meant the former.
BTW, thanks for the great guide!

Thanks Erick for the kind words and the help!


GPU Clocks issue

The gpu clock setting(s) is not working correctly. The clocks kinda go to your chosen value but do not stay there. Video showing issue attached, it is easier to show than to explain.
Video of the issue
Asus ROG ally Z1E

Fixed 2.0.8


[CircleGraph] Introduce formatted view.js

This will introduce view.js with format applied

added '// eslint-disable-next-line' for variables don't follow camelCase
changed '==' to '===' and '!=' to '!=='
use tab size 4 to follow original source
'clang-format off' for better readable codes

ONE-vscode-DCO-1.0-Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

For #520
Our modification will be applied to this view.js and external/view.js will be left as-is for reference.

Out of curious, can we just use external/view.js?

Out of curiosity, can we just use external/view.js?

we need some modification; revise menu, provide multiple-selection to the node and maybe more.

@hyunsik-yoon , I added a small change to match clang-format set. PTAL again.


Manual Launch

I'm using x86 injector version to load a 32bit dll into AAPG games that is 32 bit too.
But when i select manual lauch it never fing AAGame.exe but i run the game.
This is the debug log:
2015-09-04 18:46:08 NORMAL     Started on Windows <IP_ADDRESS>40 x64. Driver status: 0xC0000033
2015-09-04 18:46:56 CRITICAL   Injection initiated. Mode: 1, process type: 2, pid: 0, mmap flags: 0x4, erasePE: 0, unlink: 0, thread hijack: 0, init routine: '', init arg: ''
2015-09-04 18:46:56 NORMAL     Waiting on process D:\Programmi (x86)\Steam\steamapps\common\America's Army\AAPG\Binaries\Win32\AAGame.exe
2015-09-04 18:48:48 WARNING    Process wait canceled by user
I cancel the process after i saw that it not get it after 30sec of AAGame.exe running
This is the config file
XenosConfig
Hack.dll
4
D:\Programmi (x86)\Steam\steamapps\common\America ' s Army\AAPG\Binaries\Win32\AAGame.exe
0
0
0
1
0
2
1
5000
0

XenosConfig
i saw now that there 's a problem getting right path of it because of ' ( America's Army in debug but America ' s in config file )
Could be that?
Another thing, i select manual map injection type and select erasePE but in config file remain erasePE always 0 is it right?
Regards

Yes, most likely the path is the problem. You can use NTFS directory junction as a workaround till I fix this. Issue with a config could be a bug, I'll take a look.

The path is irrelevant. All that matters is process name, "AAGame.exe" in your case. Maybe injector fails to strip process name properly from full path, but I failed to reproduce it. ErasePE is irrelevant for manual map injection methods. There is separate flag in 'manualMapFlags' config entry for this.

Got the same property with ShooterGame.exe.
i select the exe from path click inject.
Popup open saing waiting for ShooterGame.exe.
i lauch ShooterGame.exe but it never find it.
Thank for resporse on erasepe flag.


[Question] Cannot applyMiddleware redux-thunk, action undefined

Hello, I'm trying to apply redux-thunk to react-chrome-redux but I'm getting these errors when trying to dispatch an 'asynchronous' action:
Error from popup.js:

Error from event.js (background process)

When I step through after the action gets invoked, action is undefined in createStore:

I've been trying to debug this for a while, any help would be nice!
// Code inside React Component to test
  componentDidMount() {
    const { actions } = this.props;
    actions.asyncCount();
  }

// actions.js
export function asyncCount () {
  return function (dispatch) {
    setTimeout(function() {
      dispatch({type: "ADD_COUNT"})
    }, 1000)
  }
}

// event.js

import {createStore, applyMiddleware} from 'redux';
import thunk from 'redux-thunk';
import rootReducer from './reducers';

import {wrapStore} from 'react-chrome-redux';
const store = createStore(rootReducer, applyMiddleware(thunk));

wrapStore(store, {
  portName: 'DRAG_NOTE'
});

It's difficult to pinpoint the issue without access to the full source code. Would it be possible to provide access?
Some possible issues:

The portName 'DRAG_NOTE' is not used to create a proxy store in the popup component. Refer to https://github.com/AgrimPrasad/mozilla-observatory-extensions/blob/master/src/components/popup/index.jsx
The redux version (or the version of some other dependency) is not up to date. The syntax const store = createStore(rootReducer, applyMiddleware(thunk)); requires<EMAIL_ADDRESS>

Hey @AgrimPrasad ,
Thanks for the response.
I've invited you to the repo I'm working on. Would you mind having a look if you have a chance?
I would really appreciate it!
I think that the proxyStore works as normal non-async actions work (and increase the "counter").

@AgrimPrasad, I've updated redux to 3.6 and redux-thunk to 2.2.0, and still no dice :/

Let me know if you need another pair of eyes here @AgrimPrasad!

Hey guys, I only took a brief look at the code this morning, and I suspect
that it may have something to do with actions vs aliases. I'm a bit busy
until tomorrow evening, so I would recommend Terence to let Vinay take a
look in the meantime.
On Sat, Mar 18, 2017 at 11:20 AM, Vinay<EMAIL_ADDRESS>wrote:

Let me know if you need another pair of eyes here @AgrimPrasad
https://github.com/AgrimPrasad!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tshaddix/react-chrome-redux/issues/70#issuecomment-287512816,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGF0x8JPVzEhUGrP0gUNxvYzkOUUbWq6ks5rm02VgaJpZM4MgzVz
.

Hi @vhmth , I've invited you to my test repo! Any help is much appreciated!
And thanks @AgrimPrasad for the help so far!

I may have run in to this same issue, it appears you cannot dispatch async actions (thunks) from a content script to the background page, which makes sense as it relies on the messaging framework which means that the messages passed have to be serializable to json.
What you'd need to do is intercept the action with an alias and then dispatch the async action on the background page itself.

@TerencedzLi left a video for ya - only showed the event.js and popup index.js scripts - so no worries I haven't exposed all your code! I noticed that the code was taken from the examples repo @tshaddix set up, so I figured the codebase structure wouldn't give much away of what you're working on either. Let me know if you want me to take this video down though!
https://www.useloom.com/share/7edf09825bf14e8f9b4c93fdc201290d
Here's a link to aliases in the README.
@tshaddix I think we discussed potentially allowing other middleware to be applied to the proxy stores. I don't remember if this is currently possible.

@vhmth Nope, no worries there. Thanks for taking a look at it and providing a solution!
I've been trying to use aliases for a while, and this might be outside the scope of this repo, but do you have suggestions on how to debug the flow of an action being called in a content-script, and then allowing the background to break in devtools in the alias? I'm just trying to see if it works, but I'm having trouble setting up a proper dev/ debugging environment.
i.e Calling an action in content-script -> sending action to alias in background.js -> break/debug in aliases.js (where aliases are kept).

https://www.useloom.com/share/d84d7a5633fa49778b432f17c6477f16

I'm pretty stuck here too. S'far as I can tell I'm doing everything as per the README dictates, and it seems like my alias is indeed dispatched, but in the background.js inspector I get the dirty:
AUTHING IN ALIAS
Error: Actions must be plain objects. Use custom middleware for async actions.

//background.js
import { alias, wrapStore} from 'react-chrome-redux';
import { createStore, applyMiddleware } from 'redux';
import reduxThunk from 'redux-thunk';
import reducers from '../reducers';
import { authenticateUser } from '../actions';

//aliases
const aliases = {
  'authenticate-user-alias': () => {
    authenticateUser();
    console.log('AUTHING IN ALIAS'); //<----Makes it to here
  }
};

//Set up store
const store = createStore(reducers,
  applyMiddleware(
    reduxThunk,
    alias(aliases)
  )
)

wrapStore(store, {portName: 'APP'}); // make sure portName matches

// popup.js
import React from 'react';
import {render} from 'react-dom';
import {Provider} from 'react-redux';
import {Store} from 'react-chrome-redux';

import SignIn from './auth/signin.js';

const store = new Store({
  portName: 'APP' // communication port name
});

store.ready().then(() => {
  render(
    <Provider store={store}>
      <SignIn />
    </Provider>
    , document.getElementById('app'));
});

// ./auth/signin.js
import React, { Component } from 'react';
import { connect } from 'react-redux';
class SignIn extends Component {

    constructor(props) {
        super(props);
    }

    login() {
        this.props.authenticateUserAlias();
    }

    render() {
        return (

                <button label='Log In' onClick={this.login.bind(this)}/>

        );
    }

}

const mapStateToProps = state => ({
    global: state.global,
})

const mapDispatchToProps = dispatch => ({
    authenticateUserAlias() {
      dispatch({ type: 'authenticate-user-alias' });
    }
})

export default connect(
  mapStateToProps,
  mapDispatchToProps
)(SignIn)

I'm inclined to believe it's either something wrong in the mapDispatchToProps in my signin component. or me not fully understanding how applyMiddleware works.

It looks like your Middleware is applied in the wrong order. Load aliases
first, then thunk and see if that works
On Mar 29, 2017 10:52 PM, "Henry Goddard"<EMAIL_ADDRESS>wrote:
I'm pretty stuck here too. S'far as I can tell I'm doing everything as per
the README dictates, and it seems like my alias is indeed dispatched, but
in the background.js inspector I get the dirty:
AUTHING IN ALIASError: Actions must be plain objects. Use custom
middleware for async actions.
//background.jsimport { alias, wrapStore} from
'react-chrome-redux';import { createStore, applyMiddleware } from
'redux';import reduxThunk from 'redux-thunk';import reducers from
'../reducers';import { authenticateUser } from '../actions';
//aliasesconst aliases = {
'authenticate-user-alias': () => {
authenticateUser();
console.log('AUTHING IN ALIAS'); //<----Makes it to here
}
};
//Set up storeconst store = createStore(reducers,
applyMiddleware(
reduxThunk,
alias(aliases)
)
)
wrapStore(store, {portName: 'APP'}); // make sure portName matches
// popup.jsimport React from 'react';import {render} from
'react-dom';import {Provider} from 'react-redux';import {Store} from
'react-chrome-redux';
import SignIn from './auth/signin.js';
const store = new Store({
portName: 'APP' // communication port name
});
store.ready().then(() => {
render(

, document.getElementById('app'));
});
// ./auth/signin.jsimport React, { Component } from 'react';import {
connect } from 'react-redux';class SignIn extends Component {
constructor(props) {
    super(props);
}

login() {
    this.props.authenticateUserAlias();
}

render() {
    return (

            <button label='Log In' onClick={this.login.bind(this)}/>

    );
}

}
const mapStateToProps = state => ({
global: state.global,
})
const mapDispatchToProps = dispatch => ({
authenticateUserAlias() {
dispatch({ type: 'authenticate-user-alias' });
}
})
export default connect(
mapStateToProps,
mapDispatchToProps
)(SignIn)
I'm inclined to believe it's either something wrong in the
mapDispatchToProps in my signin component. or me not fully understanding
how applyMiddleware works.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tshaddix/react-chrome-redux/issues/70#issuecomment-290295084,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHDuEA6_IBNnZBtzjBK05eVMqxnNc4w6ks5rqybigaJpZM4MgzVz
.

@CrustyJew I've tried that and unfortunately it doesn't seem to make a difference. Thanks though!

Hmm well it still should be in that order technically. But if it's still
not working, it may be what your auth action is doing inside your alias. If
it is an async action, you need to change your alias to accept an argument
of "dispatch" so thunk will pick it up. You can check out the dev branch of
my repo called "snoonotes" to see some working example code
On Mar 29, 2017 11:07 PM, "Henry Goddard"<EMAIL_ADDRESS>wrote:
@CrustyJew https://github.com/CrustyJew I've tried that and unfortunately
it doesn't seem to make a difference. Thanks though!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tshaddix/react-chrome-redux/issues/70#issuecomment-290296789,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHDuECsmn7a1T52heJTFiihxjSRQtYQvks5rqyppgaJpZM4MgzVz
.

So I've actually tried simply doing a console.log and no actions at and it still tosses that middleware error.

Hey @godd9170 ,
I was so annoyed with those messages too. Not sure which babel preset you're using or if that even matters, but I noticed I wasn't getting the default module from thunk unless I did:
import * as thunk from 'redux-thunk';
and then in the applyMiddleware(aliases(yourAliases), thunk.default)
And what do you mean by

doing a console.log and no actions at and

Hey @TerencedzLi,
I tried your suggestion, and I'm still getting the same errors.
As for my statement doing a console.log and no actions at and I mean just doing this in the aliases:
//aliases
const aliases = {
  'authenticate-user-alias': () => {
    //authenticateUser();
    console.log('AUTHING IN ALIAS'); //<----Makes it to here
  }
};

Couple things to try, first off, this works for me:
[REDIRECT_SUCCESS]: (req)=>{
return (dispatch)=>{
userManager.signinRedirectCallback(req.payload).then((user)=>{
let state = store.getState();
chrome.tabs.update(state.user.last_tab_id, {active:true},()=>{
chrome.tabs.remove(req._sender.tab.id);
});
dispatch(userFound(user));
dispatch(getModSubs());
},(err)=>{console.warn(err)});
}
}

So, first, for your alias function, add a param for the action, and then
second, try returning either another action object, or an async fynction
for thunk
On Mar 29, 2017 11:22 PM, "Henry Goddard"<EMAIL_ADDRESS>wrote:
Hey @TerencedzLi https://github.com/TerencedzLi,
I tried your suggestion, and I'm still getting the same errors.
As for my statement doing a console.log and no actions at and I mean just
doing this in the aliases:
//aliasesconst aliases = {
'authenticate-user-alias': () =>
{
//authenticateUser();
console.log('AUTHING IN ALIAS'); //<----Makes it to here

}
};
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tshaddix/react-chrome-redux/issues/70#issuecomment-290298618,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHDuEMjABgkGpWLy7-IrHO-eLpr4RDkvks5rqy4bgaJpZM4MgzVz
.

@CrustyJew  what's [REDIRECT_SUCCESS]: ? Are you saying do something like:
//aliases
const aliases = {
  'authenticate-user-alias': (req) => {
    return (dispatch) => {
      authenticateUser();
      console.log('AUTHING IN ALIAS'); //<----Makes it to here
    }
  }
};

Exactly. Then try returning an action object next too and comment out the
auth method you have there
On Mar 29, 2017 11:46 PM, "Henry Goddard"<EMAIL_ADDRESS>wrote:

@CrustyJew https://github.com/CrustyJew what's [REDIRECT_SUCCESS]: ?
Are you saying do something like:
//aliasesconst aliases = {
'authenticate-user-alias': (req) => {
return (dispatch) => {
authenticateUser();
console.log('AUTHING IN ALIAS'); //<----Makes it to here
}
}
};
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tshaddix/react-chrome-redux/issues/70#issuecomment-290301201,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHDuEIu8XoagYlm6LhrdSSYGoimklwOOks5rqzOGgaJpZM4MgzVz
.

The [REDIRECT_SUCCESS] part is just the string constant I'm using for the
alias name.
Holy christ i just saw gmail is mangling these responses to github.  I'll
have to edit those tomorrow....

I've tried both and can't seem to get either to work. By action object do you just mean a good old fashioned synchronous action like:
export const setToken = (token) => ({ type: types.SET_TOKEN, token })

Yeah have your alias return {type:"someaction"}

This is what my working alias ended up looking like
//aliases
const aliases = {
  'authenticate-user-alias': authenticateUser
};

Damn ECMAscript throws me off yet again. One day I'll understand it.
Thanks @CrustyJew and @TerencedzLi

@TerencedzLi Has your issue been resolved?

Yup!

@TerencedzLi Nice!

👋🏾  y'all. Been super busy so just catching up on this now (yikes). @TerencedzLi you should be able to do:
import thunk from 'redux-thunk';

// ... some more imports and other stuff

const middleware = [
  alias(aliases),
  thunk,
  logger
];

const store = createStore(reducer, applyMiddleware(...middleware));

@vhmth
I'm following the same but thunk-action goes into infinite loop.
It's printing In thunk in console on every 5 sec
export function fetchOpenTabs() {

    return dispatch => {

        setTimeout(()=>{
            console.log("In thunk");
            console.log(new Date());
            dispatch({
		type : 'GET_ALL_OPEN_TABS',
		data : []
	    })
        }, 5000)
    }
}

const aliases = {

    'GET_ALL_OPEN_TABS' : () => {
       return fetchOpenTabs()
     }
};
let middleware = [
  alias(aliases),
  thunk,
  logger]

let store = createStore(rootReducer, applyMiddleware(...middleware))

export default store;

OUTPUT

Am I doing wrong anything? @TerencedzLi @vhmth

Okay I found the issue,
I have the same ALIAS name and ACTION name. That's why it went to the infinite loop.
now I change the name like
Alias:  alias@GET_ALL_OPEN_TABS
Action: GET_ALL_OPEN_TABS

Strange. I really feel like there should be a better way to revamp aliases, but I still can't for the life of me wrangle my head around it. I suppose it would help to write down all the pitfalls right now and then see if I can figure out a solution that tries to address all or most of them.

@Nishchit14 ah this makes sense. When you're using an alias, it's really just re-injecting the new action into the pipeline. When you do this, the middleware will actually run again on this new action. Since it has the same name, it will alias it again and forever the loop will go. I never did discover why this happens with redux middleware logic but it is definitely a known issue.


Allow load_best_model_at_end to be configured for early stopping on custom evaluation datasets

Description
This change adds an additional clause when configuring the trainer to allow load_best_model_at_end to be set when using custom evaluation datasets (i.e. test_datasets is populated and val_set_size is to zero).
Motivation and Context
When using a custom test dataset for evaluation was unable to set early_stopping_patience as load_best_model_at_end was never set on the training configuration. This change allows the early stopping callback to be configured in the trainer successful.
How has this been tested?
I have been using this successfully for various training runs for models.

Hey! Please let us know if you need help running lint. You can find a short guide on how to set it up here: https://github.com/OpenAccess-AI-Collective/axolotl?tab=readme-ov-file#contributing-

@winglian @NanoCode012 apologies for not installing the hooks and noticing the lint issue. Hopefully this is good now. Thanks for all you do with Axolotl, it is a really great project


*: Granular react-router imports (from react-router/lib/${class})

As documented here.  This only cuts ~10 kB from our compiled bundle (4042769 -> 4032506 bytes, so about 0.2%), but it's a straightforward enough change that I'll make it anyway ;).
What we really want to trim our bundle size down is dynamic routing, so we can get a homepage up quickly and save the heavy graph deps for later (removing the DepGraph import from App.js gets the main JS bundle down to 296kB, over a 10x reduction from the current 4MB).  But I haven't had time to figure that out yet.

👍


Update DropDown Docs for disabling hover

I added the data-disable-hover attribute to my dropdown, which works as explained. However there are no instructions in the docs as to how to trigger an open event on the dropdown.
Could those methods please be added to the documentation?
On a side note, and I apologize for the whining nature of my comments to follow, can the full list of methods and options available for a component be added to every page of the docs? I find that I have to delve into source more often than not in order to understand how to use this framework. To me, the point of choosing a front end framework is so I don't have to spend time on these things and can instead focus on business logic. It's frustrating to have to spend time making things work as expected when the information isn't readily available in the docs.

I follow here also... Sometimes a lot of time is wasted to search through the code file... Maybe juste a list of all the methods would be great! :)

Dropdown does not use data-disable-hover. Do you mean Tooltips?

@andycochran it might be a reference to the Dropdown Menu, which does use data-disable-hover

You should set data-click-open="true". Without this you can just use focus and space key or return key to open it.
https://codepen.io/DanielRuf/pen/OvPYoZ

@JeremyEnglert should we mention this in the docs that one of both is at least neededto get a working dropdown menu?

@ncoden how should we further progress with this?


Roll Flutter Engine from 356d51d46736 to 52621de86f54 (1 revision)

https://github.com/flutter/engine/compare/356d51d46736...52621de86f54
2024-08-19<EMAIL_ADDRESS>Roll Skia from 3896447e3531 to e49cd5f3cffb (1 revision) (flutter/engine#54612)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Use shell.nix as well for stack.

Does a full stack build of the project work in this shell? (takes a while to test -- stack wants to download and build 106 dependencies first). Because I notice that the shell doesn't have PKG_CONFIG_PATH for example.
If it works then it's quite clever and lets there be only one stack shell (so the non-haskell dependencies need not be repeated).
However I'm worried that using a wrapped ghc with stack will cause possible future problems. Also it relies on Cabal being somewhere within the project's dependencies, which is true for this project, but not others.

Cabal is pulled from adding hackage-db to shellFor.packages. Which is hack.
stack test does work, for me it compile 115 dependencies, a bit less than with the buildStackProject shell.
But let's postponed this until we have a less hacky solution.


fix(ci): Run CI on pull_request and merge_group triggers

Overview
Adds extra triggers to the fpvm-tests and rust-ci workflows that trigger jobs on PR creation / re-opening as well as when a PR is added to the merge queue.
This should fix CI for external contributors, cc @merklefruit

#186  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on  Graphite


Obsoletion request: GO:1902621   actomyosin contractile ring disassembly/GO:1990274  mitotic actomyosin contractile ring disassembly

Please provide as much information as you can:

GO term ID and Label
GO:1902621  actomyosin contractile ring disassembly
GO:1990274  mitotic actomyosin contractile ring disassembly
GO:0120151   positive regulation of mitotic actomyosin contractile ring disassembly
GO:0120150  regulation of mitotic actomyosin contractile ring disassembly

Reason for deprecation Put an x in the appropriate box:

[x] The reason for obsoletion is that the data from the paper for which the term was requested can be accurately described using 👍
[ ] GO:0000916   actomyosin contractile ring contraction
[ ] GO:1902404    mitotic actomyosin contractile ring contraction
[ ] GO:1903471    regulation of mitotic actomyosin contractile ring contraction
[ ] GO:1903473  positive regulation of mitotic actomyosin contractile ring contraction

"Replace by" term (ID and label)
If all annotations can safely be moved to that term

Are there annotations to this term?

How many EXP: 6
PomBase 4
SGD 2

Are there mappings and cross references to this term? (InterPro, Keywords; check QuickGO cross-references section)

No

Is this term in a subset? (check the AmiGO page for that term)

No

Any other information

Checklist for ontology editor
Check term usage and metadata in Protégé

[x] check term usage in the ontology
[x] check internal mappings: RHEA, EC, MetaCyc
[x] check subset usage
[ ] check taxon constraints

Check annotations
Annotation review ticket
https://github.com/geneontology/go-annotation/issues/4915

[x] find external mappings (via IEAS), include in obsoletion notice

Notification

[x] create obsoletion announcement
[x] announce to GO friends<EMAIL_ADDRESS>[ ] paste the text in the ontology ticket

I asked some experts and they don't see any difference between constriction and disassembly. The ring disassembles as it constricts

proceed to obsoletion, annotations will be remapped.
remove taxon constraint
GO:0000916 | actomyosin contractile ring contraction | Only in Taxon | 2759 | Eukaryota
(@pgaudet  will I be able to do this? before xmas  we were told to wait for taxon constraints until some change was implemented, otherwise I could go ahead with this)

I think you can go ahead and remove the taxon constraint - right @balhoff ?

Yes, go ahead, it's no problem.

Thanks!


perf: remove update every tick for hero clean up - [merged]

Merges clean -> staging

mentioned in commit 5d33d2d0cf27f020dae72f56064c38c2019133aa


ffmpeg: misc cleanups

Motivation for this change
There are 5 versions of ffmpeg included in nixpkgs, 2 of which are not supported upstream as I understand it. This attempts to switch packages to a more up to date version where possible. As a result ffmpeg_1 can be dropped; ffmpeg_0 still remains :/ with a single reverse dependency gst-ffmpeg. The packages depending on gst-ffmpeg are:

miro - depends on other deps marked as insecure already - webkitgtk24x-gtk2 - so perhaps could be dropped?
gnash - as per https://github.com/NixOS/nixpkgs/pull/26620 gstreamer support is not enabled by default and some parts of it don't work well? Could the gstreamer support be removed here?
transcribe - I think it should be possible to update the package and switch to new gstreamer and drop the gst-ffmpeg dependency
tor-browser-bundle{-bin} - don't know what to do with those..

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

I verified things build on x86_64-linux but not tested much beyond that.

Related issues: https://github.com/NixOS/nixpkgs/issues/22372, https://github.com/NixOS/nixpkgs/issues/15930

:+1: for dropping Miro, for https://github.com/NixOS/nixpkgs/issues/39975

cc @rnhmjoj regarding gnash

I doubt that the tor-browser still uses gst-ffmpeg, because it is based on firefox. cc @joachifm

@Mic92 Yeah, I believe it should be safe to remove as gstreamer support seems to be gone (only looked into it today). I started working on a change that removes gstreamer dependencies from firefox and tor-browser expressions (FF doesn't use gst-ffmpeg but refers to some other legacy gstreamer packages).

@pbogdan What is the status of this? What kind of testing did you do?


Weird Layout Update Behaviour (@layout-update is firing when resizing)

Browser: Chrome
Vue version: 2.6.12
vue-grid-layout version: 2.3.12
@layout-updated event is getting fired more than once after I resize a layout item.
I'm using a json object for each grid item like this:
layout = [     {          i: 0,          x: 0,          y: 0,          w: 4,          h: 12 ,          data: [],          chartOptions: {              // etc.           }     } ]
All the props are same with what library sample said. I keep "apexCharts" properties inside layout item too and I have 10 layout item. When I do resize or drag it's really swelling, delaying. @layout-updated event is getting fired a couple of times when I do resizing. What can cause this situation? Using charts with it? Need some suggestions, thanks in advance.

Additionally: I created a test project here https://codepen.io/itstark/pen/WNoyvLo
@layout-update  works fine, I mean it's getting fired after drag or resize operation finished.
When I update the key of <grid-layout>  @layout-update is not firing but in my case it's firing.

Update
I found what caused this problem.
When I add :responsive property as true to <grid-layout>  it fires @layout-update event even when I do resize.
When I remove the property then it behaves normal.


STORM-3013: Keep KafkaConsumer open when storm-kafka-client spout is …

…deactivated, in order to keep metrics working
See https://issues.apache.org/jira/browse/STORM-3013
The changes here are to fix a crash that occur if the spout is deactivated and Storm asks for metrics. The KafkaConsumer is closed when the spout deactivates, and the metrics provider tries to use the consumer to generate a few metrics.
The suggested fix is to not close the KafkaConsumer when deactivating the spout. There's no real reason to do it as far as I can tell, and having to replace the consumer makes the spout a bit more complex than it would otherwise be.

@srdo
The patch wasn't applied to 1.x-branch cleanly. Could you please raise a PR for 1.x-branch as well? Thanks in advance!


DS4 connects to PS4 instead of flashing. How can I disconnect and make the DS4 flash?

Hold Share and PS button together until it starts to flash.


[WIP] JUnit tests for BPMN4TOSCA2BPEL

Added new Junit Tests.

Hey @senle,
I think you should remove my commits from the PR, because they are not a part of your work.

Please rebase the commits to one, and remove the  commits from axfrank from the PR

I removed my old files, fixed the merge conflicts (mostly caused by moving from tabs to spaces) and merged with the current master.
Please do a git rebase.

<EMAIL_ADDRESS><EMAIL_ADDRESS>Please sign the ECA and fix the merge conflicts.

I commented on each thing, I found. It would be nice to document the tests using markdown.
In the case of multiple authors, plese add Also-by: Some Bodyelse<EMAIL_ADDRESS>for each additional author (instead of multiple Signed-off-by: ...). For more information, see https://www.eclipse.org/projects/handbook/#resources-commit.

Current status
The pull request did not pass Eclipse validation.
The following users have invalid Signed-off-by footers. Please use the Signed-Off-By (git commit -s) mechanism to confirm the origin of the submission. The identity in the Signed-off-By must match the Author or the Committer.
<EMAIL_ADDRESS>

The follow-up of this PR is https://github.com/eclipse/winery/pull/88


IOS - Login- App is crashed when log out from one account and log in with different one

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app
Log in with any account<PHONE_NUMBER>/Feya86Katya)
Send the message to account<EMAIL_ADDRESS>Log out
Log in with account<EMAIL_ADDRESS>
Expected Result:
No crash when log in with account
Actual Result:
App is crashed when log out from one account and log in with different one
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] iOS

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/208794678-35e03a08-4267-4045-9d2f-f061efea5a59.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Fixed with https://github.com/Expensify/App/pull/13758


feat: d2l-filter-overflow-group component

Initial work to add new d2l-filter-overflow-group component. This branches off of the branch that adds OverflowGroupMixin but doesn't particularly utilize it at this point. That will be done in a follow up PR. This is just to get the basics in like initial component structure and tests.
My plan was to merge this into main after the OverflowGroupMixin PR gets merged in, then hook up the overflow group functionality in a follow up PR.

This has become a bit of a mess. Will re-open a fresh PR.


multiple namespaces support

trace checksum table for different namespaces.
test case: 2 namespaces in 2 controllers.

fixed. Now scripts can create as many qpairs as possible, only if:

NVMe device supports, and
enough memory in host PC.


Server Push is not working with CDN

Hello,
Server push is working only for the primary domain. When I activate cdn.example.com for serving static resources, below code doesn't push. Instead, it still relies on the main domain.
define('CLOUDFLARE_HTTP2_SERVER_PUSH_ACTIVE', true);
Is there any way update host name at HTTP header?
Thanks & Regards,
Gulshan

HTTP Server Push is written to work as generally as possible. There are lots of unsupported edge cases.
The header is set here in the code. You might want to dig in the code.


Migration to CoP shared workflow

Migration to CoP shared workflow

you might want to update the docs on supporting s390x. Other that that LGTM.

@raffaelespazzoli updated supported arch types


Deprecate existing icon components 🗑

Summary

Deprecate existing icon components using util-deprecate and point to which font-awesome icons to use instead.
Story
ZDS-11

:tada: This PR is included in version 3.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ERROR: readlink /var/lib/docker/overlay2: invalid argument

New installation appeared to go well, then error message:
I would greatfully appreciate any ideas how to resolve
ERROR: readlink /var/lib/docker/overlay2: invalid argument
Traceback (most recent call last):
File "./ambar.py", line 300, in
start(configuration)
File "./ambar.py", line 241, in start
runShellCommandStrict('docker-compose -f {0}/docker-compose.yml -p ambar up -d'.format(PATH))
File "./ambar.py", line 63, in runShellCommandStrict
subprocess.check_call(command, shell = True)
File "/usr/lib/python3.5/subprocess.py", line 581, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'docker-compose -f /home/d/docker-compose.yml -p ambar up -d' returned non-zero exit status 1

reinstalled on laptop running ubuntu 16.04 arm64 desktop and also ubuntu 16.04 arm64 server with same results, so consistently incompetent. please help.

When I wrote my previous comment, I had not tried access localhost:80
I have no tried localhost:80 and been presented with 'Apache2 Ubuntu Default Page'.
Still no sign of an 'ambar' page

please, run docker vesion and docker-compose version

The same issue with docker swarm, some services do not start with this error:
Used images:
mesosphere/mesos-master:1.4.0
mesosphere/mesos-slave:1.4.0

@vvsh I'm curious why you use these images?

No answer from Issue Opener


Pull Target Levels from Vanilla Goals for Skill Calculator

This is not related to a problem, per se, but rather a QoL-type issue. The current way the Skill Calculator works is a bit agitating (at least to me). You can click off of a skill and upon clicking back on it the target level gets wiped.
I feel as though it would be much more elegant to utilize the vanilla XP goals, similar to how the XP tracker works, to either extrapolate the target level or the target xp. Then, if the user wishes to see intermediate or post-goal levels, they can change the target level/xp.
Perhaps instead of making this the default, though I don't see why anyone wouldn't want this, an option could be added in Configuration->Skill Calculator to where you can add a clickbox to pull from vanilla goals instead of wiping each time or at least to remember the last input target level/xp. Doesn't have to be in config, but just a thought.

Since this hasn't gotten any attention and there has been a similar post (see issue #10445), I decided to go in and make the changes myself.  The only file changed is runelite-client/src/main/java/net.runelite.client/plugins/skillcalculator/SkillCalculator.java.
The changes can be found on my forked version
Changes made:

Added imports for Skill and VarPlayer.
Changed the following two lines of code
targetLevel = currentLevel + 1; targetXP = Experience.getLevelForXp(targetLevel);
to
VarPlayer endGoal = endGoalVarpForSkill(calculatorType.getSkill()); targetXP = endGoal != null ? client.getVar(endGoal) : -1; targetLevel = enforceSkillBounds(Experience.getLevelForXp(targetXP));
Added the private static method endGoalVarpForSkill method from the XpTrackerPlugin.java file.

One thing to note is that I did not do any testing on this, specifically of concern would be the targetXP = endGoal ? ... line since it would potentially set targetXP to -1, although I am almost certain that would get caught in the enforceSkillBounds call.
All changes are currently live on my fork, but if someone can walk me through creating a pull request here then I can get that done.


'file' objects don't seem to have proxyURL's

My client can upload "any" file now, creating objects of type 'file'. The resulting object has a link to the file in the 'fileUrl' property. But, unlike the 'stream' property of audio or video objects, this property is not a map with 'url' and optional 'pump_io':'proxyURL'.
Instead, the 'fileUrl' property is just a string, with the link to the file in the originating server. It would be good to have proxyURL's for it, as it's already done for 'image', 'audio' and 'video'. Otherwise, the attachment can't be downloaded by the addressees unless they're on the same server as the sender, or the post is completely public.
This is partially related to #873.

We're releasing 1.0.0 tomorrow and this isn't in it. Pushing to 1.1


Gravity Forms entry export doesn't upload to stateless

Related https://github.com/udx/wp-stateless/issues/408
When you use the Gravity Forms entry export UI the generated .csv file does not upload to the stateless bucket. This means that you often get failures if you're using WP Stateless in a kubernetes environment as the generated .csv file is not present on the pod when WordPress tries to download it.

Thank you for reporting.
Moved to appropriate repository at https://github.com/udx/wp-stateless-gravity-forms-addon/issues/2


"Continue onto" --> "Continue to stay on"

Issue
Closes #41 -- rephrases instruction from "continue onto" to "continue to stay on" when continuing. Note that I added a special condition for exits.
Tasklist

[x] update language in en.json
[ ] Add changelog entry
[ ] Test with osrm-frontend (?)
[ ] Review by @willwhite and/or @bsudekum and/or @1ec5? (not sure who to tag here)

@mcwhittemore Per https://github.com/Project-OSRM/osrm-text-instructions/issues/41#issuecomment-319566754 + the OSRM docs, "Continue" means "Turn in direction of modifier to stay on the same road." With that in mind, consider these scenarios:

You are driving on Main Street. In order to stay on Main Street, you need to turn left. Prior to this PR, you would get: "Continue left onto Main Street." But you're already on Main Street. With this PR, you would get: "Continue left to stay on Main Street." It sounds like you're asking if we can drop "to stay", which leaves: "Continue left on Main Street." This sounds confusing to me -- it's ambiguous about whether you're staying on the same street or turning onto a new street.

The one place this doesn't make sense is when taking a highway exit. Per the tests, going from a ramp onto a road is considered a continue maneuver, but you are actually going from one path (the ramp) to another (the road). In that case, instead of hearing "Continue straight to stay on Main Street" (because you're not yet on Main Street when you get to that maneuver) you will hear "Continue straight onto Main Street" which makes more sense.


feat: using pino as debug logger

Coverage decreased (-98.4%) to 0.0% when pulling f0d1f0e60720b97348fabbf4424a4d0fa1e556f3 on pino into 4d0abf9d3278442314f1e3eec586bf37940bbbe5 on main.

coveralls seems flakey

That is strange.
This is the screenshot I shared days ago:

Other CLI tools under nodeshift organization are not using pino due to the custom generated output.
And as we still having issues with that then maybe it is good to not merge.

I forgot to mention another thing, we have no gains in terms of performance in CLI tools like nodeshift , npcheck, and license-reporter for example.
And just to send content to stdout we don't really need to be in a JSON format.
I'm going to close this PR :+1:


Make CLI able to replace an entire branch

Description & Motivation
I have a yaml file config.yaml of the form
model:
     model_param1: val1
data:
      class_path: class1
      init_args:
            arg1 : val1

and another config file data.yaml of the form
data:
      class_path: class2
      init_args:
            arg2 : val2

When I use PyTorch lightning CLI to load the configs via python train.py --config config.yaml --config data.yaml, it keeps the args1 entry. It looks like it's not possible to remove it.
It would be great to have the option to remove an entire branch and have it reset by a new config.
cc: @mauvilsa
Pitch
No response
Alternatives
No response
Additional context
No response
cc @borda

I think there is a need to clarify a bit exactly what is the proposal. Let me describe the current behavior. When class_path is changed, the existing init_args are kept if the new class also has that parameter, otherwise it is removed. An example is the following:
# main.py

from lightning.pytorch.cli import LightningCLI
from lightning.pytorch.demos.boring_classes import BoringDataModule, BoringModel

class DataModuleA(BoringDataModule):
    def __init__(self, param: int = 1, paramA: str = "-"):
        self.param = param
        self.paramA = paramA

class DataModuleB(BoringDataModule):
    def __init__(self, param: int = 2, paramB: float = 5.6):
        self.param = param
        self.paramB = paramB

cli = LightningCLI(
    BoringModel,
    BoringDataModule,
    subclass_mode_data=True,
    run=False,
)

# configA.yaml

data:
  class_path: DataModuleA
  init_args:
    param: 3
    paramA: value

# configB.yaml

data:
  class_path: DataModuleB
  init_args:
    paramB: 7.8

The output when running the tool is currently as follows:
$ python main.py --config=configA.yaml --config=configB.yaml --print_config
...
data:
  class_path: __main__.DataModuleB
  init_args:
    param: 3
    paramB: 7.8

paramA was removed because DataModuleB does not define that parameter, and param was kept because both subclasses define it.
@rob-hen, so the proposal is to have a way to remove parameters like param that are defined in both classes? How would this be done? e.g., a special command line argument like
python main.py --config=configA.yaml --data={} --config=configB.yaml --print_config

I had an error while creating the yaml file. In fact, the functionality you describe is solving the issue.


cannot find ntpsapi.h file in the Microsoft Windows SDK

Cannot find ntpsapi.h file in the Microsoft Windows SDK (22000)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 542fe7f0-0b5d-3567-7a8f-68fba68573f8
Version Independent ID: f2074fa7-134c-d9a3-79aa-21d726b28199
Content: Debugging a Stack Overflow - Windows drivers
Content Source: windows-driver-docs-pr/debugger/debugging-a-stack-overflow.md
Product: windows-hardware
Technology: debugger
GitHub Login: @DOMARS
Microsoft Alias: domars

@guliteb - Thanks for pointing out that the thread environment block is no longer shipping in ntpsapi.h. I struggled to locate an existing public structure for the current version of Windows. So I updated this example walk through to use the dt command to display the TEB structure. If you are working on a system where symbols are not available, you would need to first display the thread environment block information on a system  where symbols are available and use that on the system without symbols. As complex as Windows has become, it can be very difficult to walk raw memory with out symbols in a reasonable amount of time. It is a bit tangential to the primary goals of this stack overflow topic, but I also added information on the related K/ETHREAD structures. For further on details on TEB, refer to chapter 4 - "Threads" in the seventh edition of Windows Internals. Good luck with your debugging work and thanks again for filing this issue.


a response from the anti-collusion infrastructure RFP.

Project Abstract

This application is a response from the anti-collusion infrastructure RFP.

Decentralized decision-making aims to be a  ACI(anti-collusion infrastructure) implementation for the Polkadot ecosystem.

In certain situations where collective decision-making is required, it is a basic requirement to design a mechanism that effectively prevents any on-chain collusion, but, as explained in the RFP, existing voting systems, such as on-chain secondary funds, are likely to pass Collusion and bribery were exploited (see Vitalico's post on collusion).This proposal is intended to serve as a proof of concept that can help enable true anti-collusion infrastructure in the Substrate ecosystem.

This is a regular pallet that can be incorporated into any substrate-based blockchain.

Our team's goal is to develop a super fair governance chain, and realize that all applications on the chain meet the requirements of decentralized decision-making (i.e. DDapp), and a basic property of decentralized decision-making is anti-collusion and avoid bribery.

Grant level

[x] Level 2:  Up to $30,000, 3 approvals

Application Checklist

[x] The application template has been copied and aptly renamed (project_name.md).
[x] I have read the application guidelines.
[x] Payment details have been provided (Polkadot AssetHub (USDC & DOT) address in the application and bank details via email, if applicable).
[x] I understand that an agreed upon percentage of each milestone will be paid in vested DOT, to the Polkadot address listed in the application.
[x] I am aware that, in order to receive a grant, I (and the entity I represent) have to successfully complete a KYC/KYB check.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
[ ] I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

I have read and hereby sign the Contributor License Agreement.

Hey @iunknow588 ,
thanks for your application! Could you please change your PR so that you try to add your application into the applications directory instead of docs? That would be great. I'd also appreciate it if you could fix the formatting of the checkmarks in the PR description. :)

Hey @iunknow588 , thanks for your application! Could you please change your PR so that you try to add your application into the applications directory instead of docs? That would be great. I'd also appreciate it if you could fix the formatting of the checkmarks in the PR description. :)

Thank you for pointing out this issue. I have corrected the mistake.

Hey @iunknow588 ,
I'm sorry for the long delay, but I'm still in touch with the owner of the RFP to verify that it is up to date and that we are still taking applications for this. I will have an update for you on monday as the latest.

Hey @iunknow588,
turns out the RFP is still valid and we are looking for teams to implement this. I'm happy to let this application go into the review stage. I'll share it with the committee so that you will hopefully get some reviews shortly. I would like to let you know that while we want to have the RFP implemented, ideally the grantee would also be eager to build a business on top of the developed tech. I'd also like to know how the chain you are trying to build will contribute to the Polkadot ecosystem as a whole. Will it be a solo- or parachain?

嘿@iunknow588， 很抱歉这么久才回复，但我仍与 RFP 的所有者保持联系，以确认它是最新的，并且我们仍在接受申请。我将在周一为您提供最新消息。

Thank you very much for your patience and thoroughness. I'm very happy that we can discuss this RFP together.

Hey @iunknow588, turns out the RFP is still valid and we are looking for teams to implement this. I'm happy to let this application go into the review stage. I'll share it with the committee so that you will hopefully get some reviews shortly. I would like to let you know that while we want to have the RFP implemented, ideally the grantee would also be eager to build a business on top of the developed tech. I'd also like to know how the chain you are trying to build will contribute to the Polkadot ecosystem as a whole. Will it be a solo- or parachain?

Thank you very much for your excellent work and patience!
Our goal for the super fair Chain is to develop various applications, including NFT co-creation and NFT third-party guarantor transactions. Ideally, based on the minimal anti-collusion mechanism currently built and future expansions, other developers can build decentralized decision-making applications (ddApps) in various fields. Correspondingly, these applications will all have anti-collusion and anti-bribery features.
We hope the chain can work as a parachain, but the compatibility of the consensus mechanism needs to be addressed.
Therefore, if there is an opportunity in the future to solve the compatibility issue of the consensus mechanism, it will be a parachain. If not found, it will run as an independent chain first.

Hey @iunknow588 ,
I hope you are doing well. Do you have any updates to share with us?

left a few comments. It also looks like you are missing the mandatory docker de

Thank you so much for your concern. I will make revisions to the paper this weekend and send you a copy when I am done.. Many thanks.

left a few comments. It also looks like you are missing the mandatory docker de

Thank you so much for your concern. I will make revisions to the paper this weekend and send you a copy when I am done.. Many thanks.

great, looking forward to it.

Hey @iunknow588 , I hope you are doing well. Do you have any updates to share with us?

Thank you for your attention. In order to fit in to the humanities' approach, the article structure has been modified, and there are still specific areas that require improvement.Nevertheless, the fundamental framework is essentially as follows. I send a draft to the email address specified above.
The article's content is broader than the scope of this discussion, as it primarily focuses on decentralized decisions on general issues. Criticism and corrections are welcome.

Thanks @iunknow588 for your thorough answers. Could you also take a look at the pallets written by Infimum and briefly compare your approach to their MACI circuits?

Thank you for your attention.
In my opinion, the differences between MACI circuits and decentralized decision-making are as follows:
MACI circuits believe that collusioners need to provide evidence to each other to demonstrate that they have fulfilled the terms of the conspiracy.
Therefore, if the platform allows collusioners to be unable to provide evidence to prove their performance to each other, then the collusioners lose their basis for survival.
Decentralized decision-making systems believe that if a decision mechanism allows colluders to obtain excess profits, it indicates that there is a problem with the decision mechanism itself. Therefore, it is necessary to modify the decision-making mechanism to ensure that every honest person can receive their rightful benefits.
The advantages of MACI circuits:
There is no need to change the existing decision-making mechanism; only the voting system requires cryptographic processing.
The disadvantage of MACI circuits: They are not binding for collisions that do not require evidence.
At the same time, it cannot prevent conspirators from using non-private information to indirectly prove that they voted according to the collusion agreement.
Advantages of decentralized decision-making systems:
Achieving neutrality in collective decision-making. Ensure the compatibility of collective decisions with the preferences of all members.
Disadvantages of decentralized decision-making systems:
For specific problem areas, new decision-making models need to be developed.
Additionally, the differences between the two are also reflected in the handling of preference information:
The former believes that individual preferences are private information that needs to be protected but does not care about the authenticity of the preference information itself.
The latter believes that personal preferences need to be made public because only publicly disclosed preferences can be verified by the public, thereby determining whether a collective decision is fair to everyone. In other words, collective decisions are made based on publicly disclosed preferences and satisfy all the publicly disclosed preferences.


feat: add unit tests around schema evolution

Description:
Add unit tests to confirm that any schema updates are backward and forward compatible with stored versions. Also adds a management command to generate and store the current Avro schema for each signal.
Manual testing:
Test 1: Add required field "thing" to CourseEnrollmentData
FAILED openedx_events/event_bus/avro/tests/test_avro.py::TestAvro::test_evolution_is_backward_compatible - fastavro._read_common.SchemaResolutionError: No default value for thing
Test 2: Remove required field "creation_date" from CourseEnrollmentData
FAILED openedx_events/event_bus/avro/tests/test_avro.py::TestAvro::test_evolution_is_forward_compatible - fastavro._read_common.SchemaResolutionError: No default value for creation_date
Test 3: Change type of user_data from UserData to str in CourseEnrollmentData
FAILED openedx_events/event_bus/avro/tests/test_avro.py::TestAvro::test_evolution_is_backward_compatible - fastavro._read_common.SchemaResolutionError: Schema mismatch: {'type': 'record', 'name': 'org.openedx.learning.course.enrollment.created.v1.UserData', 'fields': [{'name': 'id', 'ty...
FAILED openedx_events/event_bus/avro/tests/test_avro.py::TestAvro::test_evolution_is_forward_compatible - fastavro._read_common.SchemaResolutionError: Schema mismatch: string is not {'type': 'record', 'name': 'org.openedx.learning.course.enrollment.created.v1.UserData', 'fields': [{'na...
Test 4: Add optional field thing to CourseEnrollmentData
All tests pass
Test 4: Remove optional field created_by from CourseEnrollmentData
All tests pass
ISSUE: https://github.com/edx/edx-arch-experiments/issues/271
Reviewers:

[ ] tag reviewer
[ ] tag reviewer

Merge checklist:

[ ] All reviewers approved
[ ] CI build is green
[ ] Version bumped
[ ] Changelog record added
[ ] Documentation updated (not only docstrings)
[ ] Commits are squashed

Post merge:

[ ] Create a tag
[ ] Check new version is pushed to PyPI after tag-triggered build is
finished.
[ ] Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

I wonder if we need a doc that explains the process for updating a schema, even if it is just what we know today? Could be docstring, as long as someone would know where to look, so we might just have a README.rst that points to the right docstring.

I would put that in a separate documentation-only PR. Among other things, there will probably be some debate on where to put it.

* Can you do a couple of manual tests and list what you tested? E.g. making an incompatible change to the signal before and after updating the schemas. Making a compatible change, etc.

Done

* Also, I wonder if the management command should do some of this testing and complain if you are trying to make an incompatible change, unless you provide some "force" argument, in case you are first working on the event. Or I guess you could just delete the schema.

I thought we didn't really want people overwriting existing schemas regardless of whether or not the change is compatible, so we're always testing against the original version of the schema.

Thoughts to be discussed.

I thought we didn't really want people overwriting existing schemas regardless of whether or not the change is compatible, so we're always testing against the original version of the schema. That's also why we always have an "are you sure" prompt when overwriting.

Sounds reasonable. I made other PR comments to see if we could add this context to your code comments, but otherwise consider this thread resolved. Thanks.


Fixes isomorphic-fetch low vulnerability

I have a merge conflict here - going to abandon PR and fix it


How to use this in Expo?

Hi there I dont know how active ppl are in here and I dont know why the datetimepicker is given to the community but I have a Question.
How do I implement this module inside an Expo app? I have a different datetimepicker that works in expo because it doesnt have to change android files. And obviously you have to change some Android files to use this one.
Do I really need to eject just to use this package?

It's incompatible. Use this https://github.com/mmazzarolo/react-native-modal-datetime-picker

Maybe the readme should be updated to state that there is no expo support yet. I just installed and setup with an expo app only to find that it doesn't work at all. Looks like a nice component though, I'll have to try with the react-native-modal-datetime-picker instead for now.

I also think this should be stated in the README

I understood this to be now usable in Expo now that SDK36 is out: https://expo.canny.io/feature-requests/p/add-react-native-datetimepicker-module-to-expo
The example in the readme seems to work except the dark mode issues with this package. I'm probably going to stick with react-native-modal-datetime-picker until dark mode works here. In SDK36 you get warnings that DateTimePickerIOS/Android is deprecated though. No perfect options.

expo has added it in sdk 36. have loook here in the expo docu.


Changing language around Web UI

Changing language around some features
We are at the stage where we need to rework language around some features provided by IPFS Companion. Current labels describe what happens at the technical level and don't tell much about the purpose unless user is already familiar with low level details of our stack.

Motivation
"Web UI" doesn't have meaning for IPFS users, only for core developers.
We should change the way we point users at it in IPFS Companion.
Current state is "Open Web UI" everywhere:

Prior art: IPFS Desktop
Does not use "Web UI" anywhere,   but links to  specific screens within Web UI (Status, Files etc)

cc @ericronne @hacdias @autonome

I agree with you @lidel. Saying "Web UI" to users doesn't mean anything and we should change the 'Open Web UI' text on IPFS Companion. I see two alternatives here:

Use a Desktop-like approach: by this I mean to have multiple links to different sections (Files, Settings, Peers). However, having either 'Settings' or 'Status' could be confusing because they could be mistaken with the extension's settings.
Change the expression 'Web UI': 'Open Node Management', 'Open Node Info', 'Open Dashboard'... Perhaps the latter would fit best. Still, I'm not sure if we should call Web UI such a "technical" term.

I like the first approach, as it's centered around what the user wants to do. In Lisbon we identified the core use-cases - things people want to do:

Publish: adding/pinning files and dirs from your local filesystem to your repo
Saving: downloading or syncing from web/ipfs/other to your local repo
Viewing: viewing/reading what's in your repo
Sharing: get reference to what's in your repo, to give to others

Additionally there are technical or administrator use-cases, eg what would go in "Settings" typically, but in our case would also include "Peers" and things like that.

Waking this one up with a update. We've done a good job about referring to which specific parts of Web UI the user is going to rather than just "Web UI" -- but there are still three locations where we are actually referring to Web UI as a whole and will need to settle on a naming convention.

In the main menu (technically this could say "Open Status" since it goes to the status page, but that's not the best prompt ... we're really inviting the user into all of Web UI with this option)

In prefs here:

In prefs here:

We've talked elsewhere about perhaps adopting "IPFS Dashboard" as a replacement for "IPFS Desktop", which opens the door to perhaps calling Web UI "IPFS Web Dashboard" or "IPFS Browser Dashboard" as a differentiator.

FYI there were prior attempts to rename WebUI:

https://github.com/ipfs/ipfs-gui/issues/5
https://github.com/ipfs-shipyard/ipfs-webui/issues/612#issuecomment-353508706 (concerns about "Dashboard")

I hoped to avoid the renaming rabbit hole and just make the name disappear (at least in the browser action menu) by providing links to specific screens: just like we did in the new Welcome page:

Doing it in current menu will be tricky (limited vertical space), but perhaps we could remove
Open Web UI menu item and use those freed up pixels for a row buttons below PEERS?

Update: I think we're OK to close this issue. In the latest Companion release, "Web UI" has been replaced either by more explicit language ("Go To My Node ..." etc) or by links directly to screens (status/files/peers), with one exception, in the prefs:

While the header uses "Web UI", the text clarifies that we're talking about the status, files and peers screens, and specifies that these are coming from webui.ipfs.io: so in this case "Web UI" is actually an accurate description rather than a product shorthand.


Components Sidebar performance issues

Binaries with lots of functions/symbols cause hangs with the new Components/Symbols sidebar. This is the primary issue that prevents this view from being enabled by default

Fixed in 3.6.4660-dev.


Mocking Looker's API

As I was writing the code to mock the Looker API, I had two thoughts:

it is likely to add a lot of code to the Fonz codebase,
it is probably useful for other things we work on as a separate service. (I could have really used it for lookeraccess.

I think we should leave it in Fonz for the moment as we flesh out the structure of the mock, but wanted to create an issue to start discussing whether we should ultimately split it into a different service that we simply import here for testing.

Also, I tried to figure out if there's a way to auto-generate a mock with swagger-stub but I couldn't figure it out...

I think this is generally a good idea, but let's not rely on mocking too much.
I found this at the bottom of Looker's API Versioning page.

In all cases, the best practice is to have unit tests that exercise your application code, including calls to the Looker API (not mocked calls).

Since we'll be using a ton of beta endpoints and since Looker seems to be doing a lot of active development on the API, we'll need to make sure we're repeatedly checking our assumptions about how the API works.
Agree with you: let's leave it here for now and consider splitting it out once we've demonstrated the value and have more coverage.

Oh, interesting. I, for probably incorrect reasons, was under the impression that you should be able to test your software on a self-contained basis.
Should we re-work the tests to actually take info from a Looker instance? How do we ensure that the data from the instance stays static?

You're totally right, we should still be mocking and testing everything with assumptions of how we think the API is responding. I didn't mean to suggest we should stop work on that front.
In addition, we should have some speedy tests that we run to confirm the endpoints we use are responding according to our assumptions. These could be a part of our CI pipeline, or something we run occasionally manually. We should also sign up for anything Looker publishes related to development of their API so we're aware.


fix ghost logic, add defaults and type conversion

I'm not quite sure how we want to handle the types of XML attributes.

When we read the XML attributes all come in as strings.
The attributes with get/set methods are typed, so it seems like we should be converting the attributes to the proper type at some point in the initialization?
But setxmlparam takes a value that is a string. I guess we could add a type conversion there too? Not sure what the best way to handle it is

So I guess the question is when do we convert? During initialization and setxmlparam, or in get/set methods and anytime we directly access attributes like in rendering

Good question. It relates to the broader question of state management. One question I've been thinking about is: Should we preserve the XML nodes (specifically their attributes) that have Maki objects for them? One option would be to keep the XML node as the source of truth. The Maki object mutates/reads from the node. Another option would be to use the node to initialize the Maki object and thenceforth use the Maki object exclusively. I would imagine XML attributes becoming private properties on the Maki object.
If we follow this second approach (and at this point I kinda think we should) we would do the type coercion in initialization/setxmlparam.

Yea, we are kinda halfway there to option 2. We just leave the attributes inside the attributes object and stick that on the Maki Object instead of lifting them up to be class props. Hopefully the right pattern emerges as we add more :D


删除某一行数据后，数据表中的最后一行数据会移动到删除这一行上来

Goals
删除某一行数据后，数据表中的最后一行数据会移动到删除这一行上来了。同时监听到了chang.insertion的新增数据通知。
Code Sample
1:生成一些数据
[[RLMRealm defaultRealm] transactionWithBlock:^{
for (int i = 0; i < [self randomString].count ; i++) {
        Model *model = [[Model alloc] initWithValue:@[
                                                      [NSString stringWithFormat:@"%d",i],
                                                      @(YES),
                                                      [NSString stringWithFormat:@"%d条数据",i],
                                                      [NSDate date]
                                                      ]];
        [Model createInDefaultRealmWithValue:model];
    }
}];

2:删除中间的某一行数据
RLMRealm *realm = [RLMRealm defaultRealm];
[realm beginWriteTransaction];
RLMResults<Model *> *results = [Model allObjects];
[realm deleteObject:results[20]];
[realm commitWriteTransaction];
3:查看数据表会发现，表中最后一行数据被移动上来了。使用监听时同时出现了删除和新增数据的通知
Realm version: 1.0.1
Xcode version: 7.3。1
iOS/OSX version: 9.3
Dependency manager + version: ?

Hi there @oldpotter! Sorry for the reply in English; I cannot speak Chinese unfortunately.
From what I can gather, you're having trouble with the Realm change notifications not reporting the insertion/deletions that you were expecting. Is that correct?
Are you able to post more of your code here? Thanks a lot!

I'm a developer from China. I translated issue from @oldpotter. Hoping this helps. ^_^
Description
When you delete a record, the last line will move to the deleted location, and will receive chang.insertion notification.
Code Sample
Step1: Create some data.
[[RLMRealm defaultRealm] transactionWithBlock:^{
for (int i = 0; i < [self randomString].count ; i++) {
        Model *model = [[Model alloc] initWithValue:@[
                                                      [NSString stringWithFormat:@"%d",i],
                                                      @(YES),
                                                      [NSString stringWithFormat:@"No.%d",i],
                                                      [NSDate date]
                                                      ]];
        [Model createInDefaultRealmWithValue:model];
    }
}];

Step2: Delete a record.
RLMRealm *realm = [RLMRealm defaultRealm];
[realm beginWriteTransaction];
RLMResults *results = [Model allObjects];
[realm deleteObject:results[20]];
[realm commitWriteTransaction];

**Step3: Check Realm Browser and you will find the last record has been moved to the location which stored the deleted one's. At the same time, you can receive the delete and add notifications.
Environment
Realm version: 1.0.1
Xcode version: 7.3.1
iOS/OSX version: 9.3
Dependency manager + version: ?

Hi all, this is actually the intended behavior. To make efficient use of space and other general performance implications, RLMResults aren't guaranteed to preserve their sort order after deletions.
See our docs on Queries->Sorting:

Note that the order of Results is only guaranteed to stay consistent when the query is sorted. For performance reasons, insertion order is not guaranteed to be preserved. If you need to maintain order of insertion, some solutions are proposed here.


add New resource "Slim coder.com" for the course" Mern Stack."

add New resource "Slim coder.com" for the course" Mern Stack."

@all-contributors add @ayeshabaloch123 for content.


[WIP] Add Style/EmptyLineAfterMagicComment cop

Depends on bbatsov/ruby-style-guide#616

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[ ] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

Looks like this touches more tests than I thought. Work in progress....

Should this be configurable so that the user can choose whether they want to enforce having an empty line or not having an empty line?
I don't think that I saw a test that includes a magic comment and documentation comment. Should the following code register an offense?
# frozen_string_literal: true
# Class documentation
class Foo
end

I don't think that I saw a test that includes a magic comment and documentation comment. Should the following code register an offense?
# frozen_string_literal: true
# Class documentation
class Foo
end

IMHO, it should. To me, the lack of spacing would indicate that both comment lines pertain to Foo, which is not the case, here.

@bbatsov build is passing finally minus this weird jruby bug that is plaguing every build.

@drenmi and @rrosenblum I think I addressed your concerns


change kubeflow.io to kubeflow.org

This change is

/cc @jlewi

Coverage decreased (-4.4%) to 24.186% when pulling 6b5f6e080015b532c71f0eb4fa490adae8c37df7 on Jimexist:io-org into a4b8031f12b5badcf035d595f89fc8650da6d69f on kubeflow:master.

/lgtm


[Feature Request] Add Aptos icons

Background
https://aptosfoundation.org/
Proposal
Additional context

Named <AptCircleColorful /> already exists 🤣


Create NgModule for importing spinner component to multiple modules of the same project

Please provive a NgSpinKitModule to be able to import a component in multiple module of the same project.
Otherwise, I get the following error : "RotatingPlaneComponent is part of the declarations of 2 modules:..."
It is linked to this issue : https://github.com/angular/angular/issues/10646

@julienboulay Could you create PR?

@mrzepinski here is the new PR : https://github.com/WoltersKluwerPL/ng-spin-kit/pull/31
Thanks in advanced

@julienboulay Thanks :)
Version 3.0.0 is available - https://github.com/WoltersKluwerPL/ng-spin-kit/releases/tag/3.0.0


Add Npub check query & Npub mutation

I'd still prefer if we consolidated the Nostr types under the domain folder, rather than scattering npub1{string} around the codebase.....

Makes sense i intended to it last time but somehow slipped through, made the changes