Allow configuring workspace type via flag

Fixes #984
I opted to log an error and continue with no build system set if the selected workspace type fails to create. A reasonable alternative might be to fall back to default selection logic, but this might make it harder to tell if something is wrong.

Thank you for the quick review @ahoppen! I've made local changes per your inline suggestions. I'm slightly unclear on the correct path to supporting per-workspace configuration. I've added the relevant config to WorkspaceFolder, which I believe is created by the VSCode extension here: https://github.com/swift-server/vscode-swift/blob/4822e95cde97928a176f05a08e4e7ff581297ee7/src/sourcekit-lsp/LanguageClientManager.ts#L430C94-L430C94 . I don't see any existing way for user-configuration to be specified on a per-workspace basis in the extension, but it's very possible I've overlooked something. Am I on the right track here?

Thanks for the quick review! I've made local changes per your inline suggestions. To support per-workspace configuration, am I correct in understanding this would be a configuration setting in the Swift VSCode extension? (Most likely extending this interface https://github.com/swift-server/vscode-swift/blob/4822e95cde97928a176f05a08e4e7ff581297ee7/src/configuration.ts#L45 )

To support per-workspace configuration, am I correct in understanding this would be a configuration setting in the Swift VSCode extension?

The goal here is to expose these configuration options from sourcekit-lsp. Adding configuration to the VS Code Swift extension would be a second step. AFAIK the VS Code Swift extension doesn’t have the capability to set any of the workspace-specific parameter offered by https://github.com/apple/sourcekit-lsp/pull/974 yet but it’s something that we want to add in the future. And since the release cycles of sourcekit-lsp are longer than those of the VS Code extension (since it’s tied to the Swift releases), it’s good to design for these configuration options.

@swift-ci Please test

Okay, I think I fixed the tests. I'm developing on Windows with limited testing support, but I was able to get things set up in Windows subsystem for Linux so that I could compile the tests. Thanks for your patience 🙏

@swift-ci Please test

@swift-ci Please test Windows

@swift-ci Please test Windows

@swift-ci Please test

@swift-ci Please test Windows


Upgrading from Flyway 3.2 to 4.2 fails on multiple nodes

What version of Flyway are you using?
4.2
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Java API
What database are you using (type & version)?
Oracle 11.2
What operating system are you using?
Ubuntu
What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
We upgraded our Flyway dependency from 3.2 to 4.2. On the initial deployment, the server nodes tried to simultaneous upgrade the meta table to the new format.
What did you expect to see?
A upgrade to the new format without fail.
What did you see instead?
Node 1:
2017-05-16 09:16:32,370 DEBUG org.flywaydb.core.internal.dbsupport.Table - Locking table "..."."schema_version"...
2017-05-16 09:16:32,372 DEBUG org.flywaydb.core.internal.dbsupport.Table - Lock acquired for table "..."."schema_version"
2017-05-16 09:16:32,372 INFO  org.flywaydb.core.internal.metadatatable.MetaDataTableImpl - Upgrading metadata table "..."."schema_version" to the Flyway 4.0 format ...
2017-05-16 09:16:32,373 DEBUG org.flywaydb.core.internal.dbsupport.SqlScript - Found statement at line 17: DROP INDEX "..."."schema_version_vr_idx"
2017-05-16 09:16:32,374 DEBUG org.flywaydb.core.internal.dbsupport.SqlScript - Found statement at line 18: DROP INDEX "..."."schema_version_ir_idx"
2017-05-16 09:16:32,374 DEBUG org.flywaydb.core.internal.dbsupport.SqlScript - Found statement at line 19: ALTER TABLE "..."."schema_version" DROP COLUMN "version_rank"
2017-05-16 09:16:32,374 DEBUG org.flywaydb.core.internal.dbsupport.SqlScript - Found statement at line 20: ALTER TABLE "..."."schema_version" DROP PRIMARY KEY DROP INDEX
2017-05-16 09:16:32,374 DEBUG org.flywaydb.core.internal.dbsupport.SqlScript - Found statement at line 21: ALTER TABLE "..."."schema_version" MODIFY "version" NULL
2017-05-16 09:16:32,374 DEBUG org.flywaydb.core.internal.dbsupport.SqlScript - Found statement at line 22: ALTER TABLE "..."."schema_version" ADD CONSTRAINT "schema_version_pk" PRIMARY KEY ("installed_rank")
2017-05-16 09:16:32,374 DEBUG org.flywaydb.core.internal.dbsupport.SqlScript - Found statement at line 23: UPDATE "..."."schema_version" SET "type"='BASELINE' WHERE "type"='INIT'
2017-05-16 09:16:32,375 DEBUG org.flywaydb.core.internal.dbsupport.SqlScript - Executing SQL: DROP INDEX "..."."schema_version_vr_idx"
2017-05-16 09:16:32,490 DEBUG org.flywaydb.core.internal.dbsupport.JdbcTemplate - Update Count: 0
2017-05-16 09:16:32,490 DEBUG org.flywaydb.core.internal.dbsupport.SqlScript - Executing SQL: DROP INDEX "..."."schema_version_ir_idx"

Node 2:
2017-05-16 09:16:32,498
org.flywaydb.core.internal.dbsupport.FlywaySqlScriptException:
Script failed
-------------
SQL State  : 72000
Error Code : 1418
Message    : ORA-01418: specified index does not exist
Line       : 17
Statement  : DROP INDEX "..."."schema_version_vr_idx"

    at org.flywaydb.core.internal.dbsupport.SqlScript.execute(SqlScript.java:145) ~[flyway-core-4.2.0.jar:na]
    at org.flywaydb.core.internal.metadatatable.MetaDataTableImpl$1$1.call(MetaDataTableImpl.java:112) ~[flyway-core-4.2.0.jar:na]
    at org.flywaydb.core.internal.dbsupport.DbSupport$1.call(DbSupport.java:223) ~[flyway-core-4.2.0.jar:na]
    at org.flywaydb.core.internal.util.jdbc.TransactionTemplate.execute(TransactionTemplate.java:75) ~[flyway-core-4.2.0.jar:na]
    at org.flywaydb.core.internal.dbsupport.DbSupport.lock(DbSupport.java:219) ~[flyway-core-4.2.0.jar:na]
    at org.flywaydb.core.internal.metadatatable.MetaDataTableImpl.lock(MetaDataTableImpl.java:174) ~[flyway-core-4.2.0.jar:na]
    at org.flywaydb.core.internal.metadatatable.MetaDataTableImpl$1.call(MetaDataTableImpl.java:99) ~[flyway-core-4.2.0.jar:na]
    at org.flywaydb.core.internal.metadatatable.MetaDataTableImpl$1.call(MetaDataTableImpl.java:96) ~[flyway-core-4.2.0.jar:na]
    at org.flywaydb.core.internal.util.jdbc.TransactionTemplate.execute(TransactionTemplate.java:75) ~[flyway-core-4.2.0.jar:na]
    at org.flywaydb.core.internal.metadatatable.MetaDataTableImpl.upgradeIfNecessary(MetaDataTableImpl.java:96) ~[flyway-core-4.2.0.jar:na]
    at org.flywaydb.core.Flyway.execute(Flyway.java:1459) ~[flyway-core-4.2.0.jar:na]
    at org.flywaydb.core.Flyway.migrate(Flyway.java:971) ~[flyway-core-4.2.0.jar:na]

Thanks. This is definitely an issue for database that don't support DDL transactions as the explicit commits release our locks.
Workaround for now: do the Flyway major upgrade on one node first.

This is what we thought, too.

@axelfontaine any update here? I still have an error ERROR: index "schema_version_vr_idx" does not exist with PostgreSql and Flyway version 4.2.0

We will not be making further fixes in this direction. Stick to the workaround and you should be fine.


refactor(components): alert dialog variants fix #1115

I don't think variants work for the alert dialog action buttons.
So, I made these changes.
I had the same problem as of #1115
Ran pnpm build:registry
Usage:
<AlertDialogAction variant="destructive">Delete</AlertDialogAction>

Changes in the component:
const AlertDialogAction = React.forwardRef<
	React.ElementRef<typeof AlertDialogPrimitive.Action>,
- React.ComponentPropsWithoutRef<typeof AlertDialogPrimitive.Action>
+	{ variant?: VariantProps<typeof buttonVariants>['variant'] } & React.ComponentPropsWithoutRef<typeof AlertDialogPrimitive.Action>
>(({ className, ...props }, ref) => (
	<AlertDialogPrimitive.Action
		ref={ref}
-		className={cn(buttonVariants(), className)}
+		className={cn(buttonVariants(), props.variant && buttonVariants({ variant: props.variant }), className)}
		{...props}
	/>
));

fix #1115

I just made this same change manually to my own local version, any reason it hasn't been merged yet?


Ensure that test suite coverage is deterministically ordered

Related to https://github.com/squaresLab/Darjeeling/issues/135 and https://github.com/squaresLab/Darjeeling/issues/136


Call initMeshHandlers before initMeshConfiguration

There's a small window where the MeshConfig could be modified after initMeshConfiguration is called but before initMeshHandlers is called. This PR prevents that data race by making sure initMeshHandlers is called first.
If anyone has tips on how to test this, let me know
Fixes #45739

@keithmattix: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

release-notes_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

release-notes_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test release-notes

unit-tests_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest-required

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

unit-tests_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests

release-notes_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests

release-notes_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test release-notes

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test release-notes

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test release-notes

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test release-notes

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test release-notes

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-multicluster

integ-telemetry-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test release-notes

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-multicluster

integ-telemetry-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-mc

integ-telemetry_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest-required

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-multicluster

integ-telemetry-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-mc

integ-telemetry_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-multicluster

integ-telemetry-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-mc

integ-telemetry_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

unit-tests_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-multicluster

integ-telemetry-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-mc

integ-telemetry_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

unit-tests_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-multicluster

integ-telemetry-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-mc

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

unit-tests_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-mc

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

unit-tests_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry

integ-pilot-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-mc

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

unit-tests_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry

integ-pilot-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

unit-tests_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry

integ-pilot-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

unit-tests_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry

integ-pilot-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-mc

integ-security-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

unit-tests_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry

integ-pilot-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-mc

integ-security-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-security-istiodremote

integ-security_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests-arm64

unit-tests_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry

integ-pilot-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-mc_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-telemetry-mc

integ-security-istiodremote_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-security-istiodremote

integ-security_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-security

integ-security-multicluster_istio
2988227f2dcfe80cd653a8b7f0ed6869f685ca89
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Yeah apparently so; will close this for now


Changelog?

Hi there,
thanks a lot for Poison!
It'd be great to have a CHANGELOG though, so especially that with a new major version like now one could check out the changes and see what, if anything was breaking :)
Thanks + cheers,
Tobi

Seconding this. As a library author with packages that depend on Poison I honestly don't know what constraint to put. Everything seems to work at all the versions, but "~> 1" seems a bit promiscuous.

I really wish a changelog would be implemented, or at least a guide on what's changed between 2.x and 3.x 😞

Poison really miss changelog :( I can't just upgrade to 4.0 cause I am not sure what things were really changed

https://github.com/devinus/poison/compare/3.1.0...master
Doesn't seem too dangerous.

Everyone should just move to Jason at this point really.

I think the only hold back at this point is that the new phoenix version with jason still isn't out although it's been on master for ~7 months I think

any chance we can get a changelog?  no idea what is in 5.0 but that s very difficult to want to upgrade in the wild

Please add a changelog to allow the users of this library to reason about major versions, and what kind of breaking changes it may introduce. Or create releases for your tags, e.g. https://github.com/elixir-tesla/tesla/releases/tag/v1.5.0

I think this project is dead because no MR have been merged since 2021 and many other MR waiting or bugs since then that are not being looked at . @devinus  any chance  you could share ownership or add more people. I am sure some of us would love to contribute but someone needs the keys


refactor(2671): Moved retry logic from infer_type_name to wizard

/claim #2671
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #2671
Build & Testing:

[ ] I ran cargo test successfully.
[ ] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

[ ] I have added relevant unit & integration tests.
[ ] I have updated the documentation accordingly.
[ ] I have performed a self-review of my code.
[ ] PR follows the naming convention of <type>(<optional scope>): <title>

Unnecessary files have been deleted. Please revert.

closing in favour of https://github.com/tailcallhq/tailcall/pull/2673

@harshtech123 I think you are going mostly in the right direction but end up pushing changes with unnecessary file updates. Please feel free to create a new PR that's cleaner.

@tusharmath i have created a new pr , kindly check that one
#2680


Installation instruction requires to add deprecated libraries form iOS

Library libstdc++.tbd is deprecated, and Xcode 10 (iOS 12) does not contain it, but one step in documentation requires to link it during installation. Any workaround for that step for iOS 12?

I found this https://stackoverflow.com/a/50734510/6261302.
The Library should get update using libc++.

A PR fining this would be most welcome.

Fixed in https://github.com/oney/react-native-webrtc/pull/547


Mention SimPEG collaboration in docs

Mention SimPEG collaboration to build Choclo in the docs and in the README.md.
Relevant issues/PRs:
The motivation to build Choclo raised after @santisoler started collaborating
in SimPEG. The goal is to have a shared engine for running the gravity and
magnetic forward models. Choclo is being included in SimPEG's gravity and
magnetic simulations (see https://github.com/simpeg/simpeg/pull/1285 and
https://github.com/simpeg/simpeg/pull/1321).

@lheagy would you like to take a look at this. Feel free to suggest changes and thanks for the support!

Thanks so much @santisoler!! It is so cool to celebrate a concrete tie point between these two communities. One small possible addition: if you think it is appropriate to add a link to SimPEG in the nav under community, that would be awesome too.

Great idea @santisoler! I agree with @lheagy's suggestion.


Being able to create extractors and transformations CDF groups from cli

A feature request here:
We would like to be able to create the extractors and transformations CDF groups with the CLI.
Either set it up automatically or add it as a choice within the config.

@CogJoel : PR #9 is on it's way

@CogJoel : PR #9 is merged and live in @main

a new parameter was added to the deploy command
=> --with-special-groups=[yes|no]

pls let me know if the issue can be closed

the release is tagged now as v1.2.1 too:

/releases/tag/v1.2.1
which allows tagging this exact version in gh-action workflows:

- uses<EMAIL_ADDRESS>

I understand exactly where in gh-action to add
--with-special-groups=yes

jobs:
deploy:
name: Deploy Bootstrap Pipelines
environment: dev
runs-on: ubuntu-latest
# environment variables
env:
CDF_PROJECT: yourcdfproject
CDF_CLUSTER: bluefield
IDP_TENANT: abcde-12345
CDF_HOST: https://bluefield.cognitedata.com/
- name: Deploy bootstrap
uses: cognitedata/inso-expipes-cli@main
env:
BOOTSTRAP_IDP_CLIENT_ID: ${{ secrets.CLIENT_ID }}
BOOTSTRAP_IDP_CLIENT_SECRET: ${{ secrets.CLIENT_SECRET }}
BOOTSTRAP_CDF_HOST: ${{ env.CDF_HOST }}
BOOTSTRAP_CDF_PROJECT: ${{ env.CDF_PROJECT }}
BOOTSTRAP_IDP_TOKEN_URL: https://login.microsoftonline.com/${{ env.IDP_TENANT }}/oauth2/v2.0/token
BOOTSTRAP_IDP_SCOPES: ${{ env.CDF_HOST }}.default
# additional parameters for running the action
with:
config_file: ./configs/test-bootstrap-deploy-example.yml
Where and how I add this? --with-special-groups=yes

hi @CogJoel
        with:
          config_file: ./config/test-bootstrap-deploy-example.yml
          # deploy with special groups and aad_mappings
          with_special_groups: "yes"

is the way you add the new parameter to the gh-action with block
And that's a typo from you side?
 uses: cognitedata/inso-expipes-cli@main

should be either:
uses: cognitedata/inso-bootstrap-cli@main

or tagged to a release
uses<EMAIL_ADDRESS>

Perfect I will try that, no typo from my side I just copied the example in the readMe, feel free to change that.

Hi @CogJoel

README with the gh-action example fixed and
added usage of with_special_groups there too

Hmm Im getting an error that the action can't find the config file
config_file: ./configs/config_lyse/create.yml
Error:
FileNotFoundError: [Errno 2] No such file or directory: './configs/config_lyse/create.yml'
Incorrect file path, error message:  [Errno 2] No such file or directory: './configs/config_lyse/create.yml'

Works well :)! Maybe mention that you need to checkout repo content in git action section in readMe aswell.
this is how I made it run:
jobs:
deploy-auth-config-dev:
environment: dev
runs-on: ubuntu-latest
steps:
- name: checkout repo content
uses: actions/checkout@main
  - name: Deploy bootstrap
    uses<EMAIL_ADDRESS>    env:
    ....


Add support for mutually recursive processes.

The MovingArms and ReadWriteAdvanced models contain mutually recursive processes that are not supported by the new compiler.

Closed in https://github.com/TorXakis/TorXakis/commit/276b802ed1b4026d6e3a199804433ea8c1f12067


API View: Allow comment collapsing

Allow users to collapse comments (collapse all, expand all, or individual comment blocks), so that viewing an API can be read contiguously.

Done!


Fix TestCmdAddExcludePodWithIstioInitContainer unit test

Set correct namespace in mock so that istio-init check is exercised
Issue: https://github.com/istio/istio/issues/18021

@abhide: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_cni
a590f85c2552d78ce8a218f968edb33d76666e27
link
/test lint_cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Remove SimplePreAuthenticatorInterface?

Thanks for merging https://github.com/auth0/jwt-auth-bundle/pull/75!
Looking at the logs, I still get the following deprecation message:
The "Auth0\JWTAuthBundle\Security\JWTAuthenticator" class implements "Symfony\Component\Security\Http\Authentication\SimplePreAuthenticatorInterface" that is deprecated since Symfony 4.2, use Guard instead.
Since Guard is supported since SF 2.8, and the current latest supported  release is 3.4.31, is it possible to remove the SimplePreAuth implementation alltogether?

@darthf1 - Is that something you can do in your app or does it have to be removed from the library itself?
I'm fine with deprecating it now but it will need to be a major release to remove it completely.

I think this can be closed as i have no issues with SF 5.0

@darthf1 could you please share your solution? the JWTAuthenticator provided by the bundle is not supported by Symfony 5 because of this SimplePreAuthenticatorInterface. I'm trying to implement this bundle on a Symfony 5 project because the composer.json allows it but I think is not really ready for that version.

@gigo6000 I have "auth0/jwt-auth-bundle": "3.3.1", in my composer.json without any issues related to the SimplePreAuthenticatorInterface.

@darthf1 that's weird, I guess you're using a different authenticator, could you share your security.yml firewall config?

I realize there's actually a guard authenticator included in the bundle: https://github.com/auth0/jwt-auth-bundle/blob/master/src/Security/Guard/JwtGuardAuthenticator.php, and the service id is jwt_auth.security.guard.jwt_guard_authenticator, so the jwt_auth.jwt_authenticator should only be used for older Symfony versions.

@gigo6000 thanks so much for your message. I wish that would be written in the doc for this package (which is missing)


Function can't be found by double method names in a class

After the Update to 4.0.4 we have the bug that sometimes a function can't be found and therefore also our KStream is not working.
After a long investigation I found the problem in the KafkaStreamsFunctionBeanPostProcessor in the method extractResolvableTypes.
In this method the bean will be loaded by the function name and with the bean the runtime tries to find the method reference of this function.
Unfortunately the static method KafkaStreamsBinderUtils.findMethodWithName will be used to find this method, which just check the method name, but not the incoming parameter or the return type:
https://github.com/spring-cloud/spring-cloud-stream/blame/4c876b1a7f8222112b253e6f9f51a626201202bc/binders/kafka-binder/spring-cloud-stream-binder-kafka-streams/src/main/java/org/springframework/cloud/stream/binder/kafka/streams/function/KafkaStreamsFunctionBeanPostProcessor.java#L181
That means when you have multiple methods in your class with the same name (e.g. a method with KStream and a method with String as return), you can got the wrong method back, because it's just a check on method name and the check if the return type is correct will fail:
https://github.com/spring-cloud/spring-cloud-stream/blame/4c876b1a7f8222112b253e6f9f51a626201202bc/binders/kafka-binder/spring-cloud-stream-binder-kafka-streams/src/main/java/org/springframework/cloud/stream/binder/kafka/streams/function/KafkaStreamsFunctionBeanPostProcessor.java#L196
A workaround is simple, don't use method names twice but this can't be the general solution.
In my opinion the stream in the method KafkaStreamsBinderUtils.findMethodWithName should extends by filtering the return type of the method. So that only methods with KStream, KTable or GlobalKTable will be returned.

@j-ferreira Kafka-related binders have been moved to the core Spring Cloud Stream repository for a while now. Please see the announcements in the README. I will move this issue to the core repository. In the future, any new issues need to be filed in the core repo. Thanks!


Change organization name to ballerinax

Description:
We need to change the organization name of this connector to ballerinax

Already Fixed.


feat: undo and redo on page operations

Great fixups, thanks! From my point of view, you can squash, approve, and merge.


[Feature] optionally set truncated = True at the end of rollouts

@vmoens I would raise a warning in collectors when set_truncated=True but reset_at_each_iter=False.

@vmoens I would raise a warning in collectors when set_truncated=True but reset_at_each_iter=False, or even raise an error.

Can you elaborate? To me it's ok to have set_truncated=True when you don't reset. You will have trajectories that are slices of real ones (start of the batch isn't start of the episode) but at least you can delimitate what comes from where if you do a reshape(-1) or this sort of things, allowing you to feed that to GAE or other modules without worrying about one trajectory polluting another.

TLDR: my bad, I guess this is a valid thing to do, but if you have something that computes the episodic return out of that, it needs to be adjusted.
Okay, I see. I didn't have that use case in mind. I had the opposite assumptions:

When truncated happens in the middle of the rollout, it is set and a value estimator (GAE) will know to bootstrap and not sum over the next rewards. This is not an issue here.

When a rollout stops in the middle of a trajectory and you feed the trajectory to a GAE, it will bootstrap at the end because terminated is not set (truncated is not needed it already knows there are no more samples sum over)

2b. when you decide to rollout twice because for some reason your algorithm told you you need more data, you can concatenate the rollouts and the GAE will make use of more samples.
I thought you would never want to bootstrap (set truncated) when the next data coming can still be used to compute a value estimate (no reset) but I guess that's wrong. You can just want to compute your values on a fixed number of rollout steps.
I can think of another issue though. If you have something that computes the episodic return on the trajectories it will have the wrong signal.


[Bug Report] el-select will show value not label after deleting an item if don't use reserve-keyword

Element UI version
2.11.1
OS/Browsers version
Chrome / 75
Vue version
2.5.2
Reproduction Link
https://codepen.io/bitjjj/pen/qejpyx
Steps to reproduce

select some items
delete an item

What is Expected?
select should still show item's label not value
What is actually happening?
select show item's value after deleting an item

I also encountered, the original selection data will be cleared


Mapviz plug-in for calling the marti_nav_msgs::PlanRoute service (Jade)

Should be up to date now.


Fix minor typos in README

This update corrects spelling on a few typos in the README.

Thanks for the PR :D


Crash with decreasing SaveAt ts

Specifying SaveAt(ts) which are not monotonic w.r.t. t0 and t1 causes a crash rather than a Python exception. I attach a repro in a colab and below, in case you prefer it this way.
import jax
import jax.numpy as jnp
import diffrax as dfx

def f(t, y, args):
    return jnp.ones_like(y)

saveat = dfx.SaveAt(
    t0=False,
    t1=True,
    ts=jnp.linspace(0, 1, 10),
    steps=False,
    dense=False,
    solver_state=False,
    controller_state=False,
    made_jump=False,
)

sol = dfx.diffeqsolve(
    dfx.ODETerm(f),
    dfx.Dopri5(),
    t0=1.,
    t1=0.,
    dt0=-0.1,
    y0=jnp.zeros(3),
    saveat=saveat,
)

jatentaki@tuna Programs % python diffrax-bug.py
/opt/homebrew/Caskroom/miniforge/base/lib/python3.9/site-packages/jax/_src/lib/__init__.py:33: UserWarning: JAX on Mac ARM machines is experimental and minimally tested. Please see https://github.com/google/jax/issues/5501 in the event of problems.
  warnings.warn("JAX on Mac ARM machines is experimental and minimally tested. "
WARNING:absl:No GPU/TPU found, falling back to CPU. (Set TF_CPP_MIN_LOG_LEVEL=0 and rerun for more info.)
ERROR:absl:Outside call <jax.experimental.host_callback._CallbackWrapper object at 0x138f5c130> threw exception saveat.ts must be increasing or decreasing..
libc++abi: terminating with uncaught exception of type pybind11::error_already_set: ValueError: saveat.ts must be increasing or decreasing.

At:
  /opt/homebrew/Caskroom/miniforge/base/lib/python3.9/site-packages/diffrax/misc/errors.py(35): raises
  /opt/homebrew/Caskroom/miniforge/base/lib/python3.9/site-packages/jax/experimental/host_callback.py(721): __call__
  /opt/homebrew/Caskroom/miniforge/base/lib/python3.9/site-packages/jax/experimental/host_callback.py(1224): _outside_call_run_callback
  /opt/homebrew/Caskroom/miniforge/base/lib/python3.9/site-packages/jax/experimental/host_callback.py(1088): wrapped_callback
  /opt/homebrew/Caskroom/miniforge/base/lib/python3.9/site-packages/jax/_src/dispatch.py(558): _execute_compiled
  /opt/homebrew/Caskroom/miniforge/base/lib/python3.9/site-packages/jax/_src/dispatch.py(152): _xla_call_impl
  /opt/homebrew/Caskroom/miniforge/base/lib/python3.9/site-packages/jax/core.py(660): process_call
  /opt/homebrew/Caskroom/miniforge/base/lib/python3.9/site-packages/jax/core.py(1787): call_bind
  /opt/homebrew/Caskroom/miniforge/base/lib/python3.9/site-packages/jax/core.py(1771): bind
  /opt/homebrew/Caskroom/miniforge/base/lib/python3.9/site-packages/jax/_src/api.py(466): cache_miss
  /opt/homebrew/Caskroom/miniforge/base/lib/python3.9/site-packages/jax/_src/traceback_util.py(162): reraise_with_filtered_traceback
  /opt/homebrew/Caskroom/miniforge/base/lib/python3.9/site-packages/equinox/jit.py(116): fun_wrapper
  /Users/jatentaki/Programs/diffrax-bug.py(19): <module>

zsh: abort      python diffrax-bug.py

Right. So this is actually a known limitation of JAX.
JAX's model of computation -- XLA -- has no real way to raise exceptions. We do the closest thing we can, which is jax.experimental.host_callback.call that calls a Python function that immediately raises. Depending on your operating system and backend (CPU,GPU,TPU), then this will either raise a Python exception gracefully, print the error and try to continue a meaningless computation, or abort (as you've seen).
As far as I can tell this is as good as it gets. It's basically the price we pay for the speed of jax.jit.
If you or anyone else ever figures out a neater way or more reliable of doing things then that'd be great. (I'm aware of jax.experimental.checkify but I think that has a number of fundamental limitations that make it basically unsuitable.)

True, I knew of the limitations of jax but didn't connect the dots with this issue. Thanks for your explanation


better resetting error messaging

Description of changes
fix proposition for #917

@CakeCrusher are you able to make the suggested changes? Happy to do so if not!

Hi @HammadB ,
The NPM client package was causing the issues and as far as I know you cannot configure the allow_reset setting on it like you can on the PyPI package. Nonetheless, I made the update.

Why would you configure the allow_reset on the NPM client? It would be configured on the server

@HammadB ohhh, I just assumed that was how it worked since you can do this on the python client
client = chromadb.Client(settings=Settings(allow_reset=True))

fixed.


unable to fetch alerts from github

Hey there,
Having a lot of issues with fetching the alerts from my repo. (in Github Cloud Enterprise)
the error i keep getting:
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://api.github.com/repos/<org-name>/<repo-name>/secret-scanning/alerts?per_page=100

i tried running curl locally with GITHUB_TOKEN exported and it worked.
here's the action.yml (tried a few variants)
jobs:
  jira-sync:
    name: Jira Sync
    runs-on: ubuntu-latest
    permissions:
      actions: read
      contents: read
      security-events: write
#    needs: [ analyze ]
    steps:
      - name: Sync alerts to Jira issues
#        env:
#          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        uses: github/ghas-jira-integration@v1
        with:
          jira_url: 'http://<org>.atlassian.net'
          jira_token: ${{ secrets.JIRA_TOKEN }}
          jira_user: 'myuser'
          jira_project: 'myproject'
          jira_labels: 'code-scanning'
          sync_direction: 'gh2jira'

the issue was resolved by adding
        with:
          github_token: ${{ secrets.ACTION_GITHUB_TOKEN }}

the issue was resolved by adding
        with:
          github_token: ${{ secrets.ACTION_GITHUB_TOKEN }}


Fix code scanning alert - Unvalidated dynamic method call

Tracking issue for:

[ ] https://github.com/US-EPA-CAMD/easey-ecmps-ui/security/code-scanning/152

Max D. will investigate to see if this is an issue.

I've investigated this issue and determined that it is not an issue. User-controlled parameters are indirectly responsible for indexing into the array of functions, which will, at worst, result in a value of undefined. The following line protects against a type error by exiting early in the case of undefined.


Conditional v Optional

We have used the word "optional" in a few places. Question was raised as to whether or not "conditional" is a better term. Revisit and check what is the best one to use.

Craig/Erin: Optional and Conditional are distinct concepts and as such should not be used interchangeably. Conditional is rules based; if a condition is or is not met, that determines whether the action is done. Optional is more of a decision/judgement based action, which carries more subjectivity as to whether the action is done or not. A conditional scenario would require additional model elements to identify the conditions/rules under which a particular action is done. Another point to note is that within the context of a protocol, there would be more conditional activities vs optional. Our recommendation is that activities may be either conditional or optional and that, for completeness, both of these would be required to be in the model. But we shouldn't necessarily replace what has already been added. Consider the additional of model elements associated with 'Conditional' activities. Also confirm with the SMEs whether they actually intended for these model elements to be the conditional ones all along? We suspect that there are way less 'optional' activities than 'conditional' activities in the context of clinical research activities and as such the conditional activities are more important to model at this point.
We do consider that both are useful so think it is okay to keep both in the model.

Review with team. I think we may want to review changes made to Activity and Procedure

So, then...are procedures and activities both optional and conditional or just ... conditional?


Configure subversion config for shared repositories

resolution_fixed   |    by<EMAIL_ADDRESS>
Follow instructions at https://code.metoffice.gov.uk/trac/home/wiki/FAQ#HowshouldSubversionbeconfigured

Issue migrated from trac:153 at 2024-01-31 17:39:29 +1100

<EMAIL_ADDRESS>changed status from new to accepted

<EMAIL_ADDRESS>changed status from accepted to closed

<EMAIL_ADDRESS>changed owner from `` to saw562

<EMAIL_ADDRESS>changed resolution from `` to fixed


This gradle version is not applicable.

This gradle version is not applicable. Please submit issues in https://github.com/CodingGay/BlackObfuscator-ASPlugin
dependencies {
classpath 'com.android.tools.build:gradle:7.0.4'
classpath "com.github.CodingGay:BlackObfuscator-ASPlugin:3.2"

Please clean and rebuild and provide a complete build log.


Drop redundant assignments

These assignments are redundant because of pass-by-value in C.
Test Plan:
CI must pass.

Could you explain more in your perspective?
It's a safety for the structure. it prevents to access the member of the structure after freeing.

The variable what you assign NULL is the copy of the pointer. It cannot prevent the member of the structure to be accessed safely "outside" the function after freed. The pointer to the pointer should be passed to achieve your goal.
// In the function
(gdb) p req
$2 = (find_transactions_req_t *) 0x0

// Outside the function
(gdb) p find_tran
$3 = (find_transactions_req_t *) 0x55555556be70

You're right, thanks.


Stop business in Russia

While Ukraine is under missile attacks GitHub could be used by Russians to develop apps and platforms aiming to destabilize Ukrainian web resources.
Please, prevent these actions and don't stay on the same side with invaders! All information about war can be found at:  https://war.ukraine.ua/
We urge you to close GitHub for Russia and its developers! We value your support and we are in need for your actions!

While Ukraine is under missile attacks GitHub could be used by Russians to develop apps and platforms aiming to destabilize Ukrainian web resources.
Please, prevent these actions and don't stay on the same side with invaders! All information about war can be found at:  https://war.ukraine.ua/
We urge you to close GitHub for Russia and its developers! We value your support and we are in need for your actions!


Try to open process with PROCESS_TERMINATE flag.

If it fails, open it with normal flags. Allows to open a process given a pid and kill it.

Thanks, Ignacio - this is a useful addition.
While thinking about a new release, anything else useful you can think of?
steve d.

Well, not much at the moment. I'm using winapi to spawn and kill processes only, so my use case is very limited. Didn't try the other stuff so I don't have anything to add there.
Maybe, having more control of the process creation options? Like the ability to specify if the process will inherit handles or not, if it will have a console or not, etc.

More control could be useful, if it doesn't complicate the usual simple case. Controlling the console creation is easy, but specifying handle inheritance implies we have some way of setting those handles usefully.


Jupyter notebook can't render displacy

Issue Type: Bug
DisplaCy (from the spaCy module) supports rendering in Jupyter notebooks, but the notebook features in VS Code's Python extension fail to render these outputs.
Extension version: 2020.4.76186
VS Code version: Code 1.44.2 (ff915844119ce9485abfe8aa9076ec76b5300ddd, 2020-04-16T17:07:18.473Z)
OS version: Darwin x64 19.4.0

Thank you for your feedback @pbadeer. Could you please share the notebook that uses DisplaCy and has the issue? It doesn't have to be your actual work, just a notebook that showcases the issue.

Any example you can find, here's the one in the docs.
import spacy
from spacy import displacy

text = "When Sebastian Thrun started working on self-driving cars at Google in 2007, few people outside of the company took him seriously."

nlp = spacy.load("en_core_web_sm")
doc = nlp(text)
displacy.serve(doc, style="ent")

Thanks @pbadeer, that's very helpful. I'm having trouble working with spacy on its own. We'll discuss this bug on our next triage.

@pbadeer you should use render with param jupyter = True besides serve
import spacy
from spacy import displacy

text = "When Sebastian Thrun started working on self-driving cars at Google in 2007, few people outside of the company took him seriously."

nlp = spacy.load("en_core_web_sm")
doc = nlp(text)
displacy.render(doc, style="ent", jupyter = True)

Looks like a workaround/fix has been provided.


js to perl 6 nutshell example doesn't match rakudo

The problem
Currently the JS to Perl 6 nutshell contains an example that doesn't match the rakudo implementation.
my \hash = {};
my %hash := hash;
say hash === %hash; #False

The current Rakudo implementation (MoarVM version 2018.10) instead say True
Suggestions
Fix the doc, or fix the implementation.

The implementation is correct; it's just aliasing the same Hash object.

And the '1' === 1 example?
Rakudo says False
Juan Julián Merelo Guervós<EMAIL_ADDRESS>于2019年3月14日周四 下午10:58写道：

Closed #2672 via eb00a74.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

This has been fixed, or is no longer there. I'll include it, just in case it was simply deleted.


queries with file.cday don't refresh on date rollover

What happened?
I have the query below in my dashboard, to list the files that were created today.
Two issues:

When I leave Obsidian open overnight, in the morning the query still shows yesterday's results
When I make a dummy edit to the query, it updates in live preview mode. However, switching to read mode, the query still shows yesterday's results

DQL
list
from "journal work" or "zettelkasten work" or "journal home/diary"
where file.cday = date(today)
sort file.name desc

JS
No response
Dataview Version
0.4.26
Obsidian Version
0.14.9
OS
Windows

Yes, the refresh command in 5.38 does not work, just checked it this morning....

I know too little of the plugin's structure to suggest anything so let's wait for blacksmithgu.

There is a surprisingly complicated reason for why the "Refresh" command does not work (that boils down to dates being resolved at query parse time rather than evaluation time); the fix is relatively easy, however, so I'll include this in the next release.

Any updates on this easy fix? The latest releases still seem to have this problem... Thanks!

Same happens, when you change a file's creation date via touch. Dataview seems not to update the cdays in its index.


azure-http-specs, move pageable scenario to azure folder

All changed packages have been documented.

:white_check_mark: @azure-tools/azure-http-specs

Show changes
@azure-tools/azure-http-specs - feature ✏

Move payload/pageable test scenario to azure folder

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


Make use of custom selectors for hover and active states

alex, major refactor going on right now, will revisit this after


salvage expedition anti troll is broken

Description
nearly always it will say not all salvagers on shuttle even if they are
it counts unidentified humans i think
Reproduction

go expedition
see unidentified human
complete it duh
repro????

Ugh guess I need to track who shows up there if humanoidappearance isn't enough.

no it is enough i fixed it
even if you summon a reinforcement on an expedition, so long as he doesnt die, he is included in leave no dwarf behind


#212 add cargo format and clippy checks to ci

Closes #212.
Motivation
The code takes a cue from bpfman GH action to add clippy and fmt checks in our ci build steps.
The make commands I wrote search for Cargo.toml as targets to run clippy and format against. They should automatically extend to new rust components if we add them to the lib.
Notes

I did have to make some changes to code in dataplane/ebf to make clippy happy. I followed the recommended changes verbatim, so please take a look at these to make sure I didn't blindly follow clippy's advice and do something stupid.
I couldn't get nektos/act to play nice with rust so I didn't test ci.yaml locally. I may have to use this PR as my test environment. :(

/check-cla

/cc @astoycos

/ok-to-test

FYSA: I might need to move the rust ci steps into their own action given that Docker build skips by default and that's where they're currently located.

FYSA: I might need to move the rust ci steps into their own action given that Docker build skips by default and that's where they're currently located.

Feel free to, in bpfman we have separate build-go and build-rust flows.

I also don't think it'd be the worst thing to have a deidcated build workflow that happens irerespective of the container image build pipeline

FYSA: I might need to move the rust ci steps into their own action given that Docker build skips by default and that's where they're currently located.

Feel free to, in bpfman we have separate build-go and build-rust flows.

Makes sense.

I also don't think it'd be the worst thing to have a dedicated build workflow that happens irrespective of the container image build pipeline that runs on every PR so that we can catch build errors early

Agreed --- I'll take a stab at that and more these rust checks into the rust build flow.

@astoycos
I'm running into an annoying tautology with the linting and build CI action.
Problem
Clippy fails if you do not build the dataplane first because it's missing a dependency from cargo xtask build-ebpf. Clippy also fails if you run cargo xtask build-ebpf first.
Why? As a side effect, it appears to auto-generate/modify formatting of dataplane/api-server/src/backend.rs in a way that makes clippy throw.
Solution
I see 2 possible fixes:

Run make fix.format.rust between the build and clippy steps.
Get rid of the cargo xtask build-ebpf side-effects.

The former defeats the purpose of a check in the first place since it would mask any other clippy violations introduced by the PR as well. The latter is the correct approach but bit beyond my current understanding of the codebase.
Thoughts?

Pinging @astoycos @shaneutt @aryan9600. Would someone mind triggering the workflows?

Pinging @astoycos @shaneutt @aryan9600. Would someone mind triggering the workflows?

Thanks Shane.
Hmm...integration tests now fail. It seems like maybe the controller isn't getting a response from the dataplane. My code changes shouldn't have impacted functionality. Will test locally.
Would a more experienced rustacean mind browsing the few changes I made. Maybe there's a red flag I'm unaware of. Thanks!

Looks like the failure was a flake (passed after re-run)

Cool.
Best
Evan Jones
Website: www.ea-jones.com
On Thu, Apr 4, 2024 at 9:42 AM Andrew Stoycos @.***>
wrote:

Looks like the failure was a flake (passed after re-run)
—
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/blixt/pull/217#issuecomment-2037260994,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ2T6APLKIHSVXEJSHZDZRTY3VKETAVCNFSM6AAAAABFNWFFLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZXGI3DAOJZGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

cherry picking is fine.
Best
Evan Jones
Website: www.ea-jones.com
On Thu, Apr 4, 2024 at 1:04 PM Andrew Stoycos @.***>
wrote:

@.**** commented on this pull request.
In .github/workflows/build.yaml
https://github.com/kubernetes-sigs/blixt/pull/217#discussion_r1552095551
:

 run: |

   make build

name: Build UDP Test Server

 working-directory: ./tools/udp-test-server

 run: |

   make build

Clippy fails if you do not build the dataplane first because it's missing a dependency

from cargo xtask build-ebpf. Clippy also fails if you run cargo xtask build-ebpf first.

Why? As a side effect, it auto-generates dataplane/api-server/src/backend.rs with formatting

that makes clippy throw. There's no easy way to fix this side-effect. Therefore, we need to

go in and surgically auto-format the file before we try to run clippy.

This is super ugly, but it works barring a more formal solution.

name: Fix backends.rs formatting

@EandrewJones https://github.com/EandrewJones Do you mind
cherry-picking 84e2a14
https://github.com/kubernetes-sigs/blixt/commit/84e2a14de3f00eb482812564a436cfb0e4f58729
and then removing this bit?
We shouldn't be rebuilding our rust bindings on every build.... since
really the api-server crate is just a lib it doesn't/shouldn't be executing
anything unless the proto file changes
If cherry-picking is annoying I can open a PR just lmk!
—
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/blixt/pull/217#discussion_r1552095551,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ2T6AIJUFYVZH7XP2MXULDY3WB2LAVCNFSM6AAAAABFNWFFLGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBQGYZDENZXHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

All issues addressed.

/lgtm
/approve

/lgtm /approve

Sorry. The bot complained about my commit message so I revised it to remove the problematic keywords.

No worries
/lgtm
/approve


Scroll Position Fix Issue😢

Describe the bug
There is an issue when navigating pages within the React App. In the iPhone Layout, the method to adjust the scroll position does not work properly and always behaves according to the existing scroll position.
I have tried both window.scrollTo(0, 0) and React Router's scrollRestoration methods.
library version
1.1.1
Operating System Version
window 11
Browser
Chrome

@Legitgoons
Thank you for your interest in our library!
This issue seems to be caused by the iPhone layout not remembering the scroll position. I think I can solve the problem by storing the path and scroll information in sessionStorage. What do you think?

@BangDori
Storing the path and scroll information in sessionStorage is a good idea.
However, if we can figure out why the scroll position is not being remembered in the first place, we might be able to come up with a better solution. I'm curious to know what you think is causing this issue.

My guess is that the browser remembers the scroll position relative to the viewport, so it doesn't remember the scroll position inside the iPhone layout.
Can you set the viewport based on the iPhone layout?


PLEASE add filter to context-menu

VSCode is too open to user and developer to Customize User Interface .
but It will be a disaster if there is no limit and feasible specification..
like #104738
and also. the context-menu is also a "phenomenon" as same as to  action-icon

extension add to much menu items to context-menu which is Weak relationship with current context beacuse of the vscode and vsocde's none-project-concept.
as the picture, i think the temporary solution is add  a filter to context-menu for faster positioning in so many items.
just like

We will make custom menus configurable. Closing as duplicate of that.
In the meantime uninstall some of those extensinos


Error when adding rules.neon

When I add this:
includes:
    - app/vendor/phpstan/phpstan-doctrine/rules.neon
    - app/vendor/phpstan/phpstan-doctrine/extension.neon

to my phpstan.neon, I get this:
Service of type PHPStan\Rules\Doctrine\ORM\EntityColumnRule: Unable to pass specified arguments to __construct().
But if I remove rules.neon, there's no error. Why would it be?
I have this:
        "phpstan/phpstan": "^0.12.98",
        "phpstan/phpstan-doctrine": "^0.12.44"

in my composer.json

Hi, this can only happen if there multiple phpstan-doctrine versions at play. You're probably combining installing PHPStan locally in your project but probably running it from global Composer installation, or something like that.
You should install PHPStan in your project and run it from the same project.

Hi, thanks! It was exactly that. I removed global version of phpstan-doctrine and the error was gone. But now I got another error:
Service '0305': Class or interface 'PHPStan\Type\Doctrine\DescriptorRegistry' not found.

There's still something weird about your installation...

Hm, using local phpstan instead of global fixed this latter issue. I had both global and local installed because I couldn't get VSCode phpstan extension to work with local version (I have custom app structure which doesn't seem to work with that extension).

Issue was duplicate installation (both local and global). Closing this.


What is the scale for 3D handlandmark outputs?

I have a few questions regarding the 3d tflite model outputs.
In the blog you explain that

we take Z-value from image depth map, if it exists per corresponding coordinate

The output of the 3d tflite model looks as follows
Pk = (uk,vk,zkr)
where k is a specific landmark and zkr is the root-relative depth
The [u,v] values look identical to the outputs from the 2d tflite model. My questions are regarding the z or depth coordinate

What is the scale of the z coordinate i.e. is it centimeters, inches?
What did the ground-truth value for the z coordinate look like?
When stated that you take the z-value from a depth map does that mean that the training data consisted of rgb-d images that were manually annotated along with the synthetically generated data?
Would it be reasonable to say that the z predicted by the network for a specific landmark corresponds to the depth of that landmark relative to the root (wrist) landmark? i.e.  Zrk = Zk  - Zroot where Zk is the actual depth value of the kth landmark and  Zroot is the actual depth value of the root (wrist) landmark and Zrk is what is predicted by the 3d tflite network?
Lastly is the depth value zkr scale normalized? i.e. given P, P_hat is the scale normalized version where P_hat = C/s * P where s is the scale (Euclidian distance between a chosen joint and its parent) and C is a constant distance between specific pair of keypoints?

Thanks for all the great work you guys are doing, looking forward to your response!

If there's anything I can do to get this question answered please let me know! If there's too many questions you may not answer that's fine too. If I could just know the scale of the root-relative z predictions (inches, millimeters, ..?) that would be the most helpful. I appreciate any response

Hi
Some of the answers can be found in
https://github.com/google/mediapipe/issues/64
https://github.com/google/mediapipe/issues/99
I believe the z-coordinate is normalized relative to the wrist (close or far), and doesn't really have an absolute scale.

Gotcha, so I don't actually need to know what the absolute scale is but rather the relative scale. So since it's root-relative I understand that the z-coordinates don't give me what the distance from the camera to the keypoint is, but I'm assuming that there is still a relative (normalized) scale that says what the distance is from the root (wrist) to the key point. For the training data there had to be SOME sort of scale or else it would be just arbitrary distances? If I could know what the relative (normalized) scale is then it would allow me to recover the absolute 3D coordinates using the camera intrinsics. Thank you again for the help

@fanzhanggoogle Any comments on @pablovela5620 comment?

@mcclanahoochie
It's obvious that he z-coordinate is normalized relative to the wrist.
And it doesn't really have an absolute scale.
What is the unit value of  the z-coordinate?
Or there is no unit at all?

I have a few questions regarding the 3d tflite model outputs.
In the blog you explain that

we take Z-value from image depth map, if it exists per corresponding coordinate

The output of the 3d tflite model looks as follows
Pk = (uk,vk,zkr)
where k is a specific landmark and zkr is the root-relative depth
The [u,v] values look identical to the outputs from the 2d tflite model. My questions are regarding the z or depth coordinate
* What is the scale of the z coordinate i.e. is it centimeters, inches?

* What did the ground-truth value for the z coordinate look like?

* When stated that you take the z-value from a depth map does that mean that the training data consisted of rgb-d images that were manually annotated along with the synthetically generated data?

* Would it be reasonable to say that the z predicted by the network for a specific landmark corresponds to the depth of that landmark relative to the root (wrist) landmark? i.e.  Zrk = Zk  - Zroot where Zk is the actual depth value of the kth landmark and  Zroot is the actual depth value of the root (wrist) landmark and Zrk is what is predicted by the 3d tflite network?

* Lastly is the depth value zkr scale normalized? i.e. given P, P_hat is the scale normalized version where P_hat = C/s * P where s is the scale (Euclidian distance between a chosen joint and its parent) and C is a constant distance between specific pair of keypoints?

Thanks for all the great work you guys are doing, looking forward to your response!

Does someone have further answer to this comment?

I am also wondering about this. Did you get any further answers?

Any update on this? I am trying to understand how to get 3d coordinate from the hand landmarks, especially the z value is unclear to me.

I have a few questions regarding the 3d tflite model outputs.
In the blog you explain that

we take Z-value from image depth map, if it exists per corresponding coordinate

The output of the 3d tflite model looks as follows
Pk = (uk,vk,zkr)
where k is a specific landmark and zkr is the root-relative depth
The [u,v] values look identical to the outputs from the 2d tflite model. My questions are regarding the z or depth coordinate

What is the scale of the z coordinate i.e. is it centimeters, inches?
What did the ground-truth value for the z coordinate look like?
When stated that you take the z-value from a depth map does that mean that the training data consisted of rgb-d images that were manually annotated along with the synthetically generated data?
Would it be reasonable to say that the z predicted by the network for a specific landmark corresponds to the depth of that landmark relative to the root (wrist) landmark? i.e.  Zrk = Zk  - Zroot where Zk is the actual depth value of the kth landmark and  Zroot is the actual depth value of the root (wrist) landmark and Zrk is what is predicted by the 3d tflite network?
Lastly is the depth value zkr scale normalized? i.e. given P, P_hat is the scale normalized version where P_hat = C/s * P where s is the scale (Euclidian distance between a chosen joint and its parent) and C is a constant distance between specific pair of keypoints?

Thanks for all the great work you guys are doing, looking forward to your response!

Any further answer to this comment? I am also wondering how to use the z-value.

please see https://github.com/google/mediapipe/issues/742#issuecomment-639104199

It is clear in the current docs now that Z is more or less the same scale as X. maybe it is scaled to the scale of X post-prediction by the pipeline. Haven't verified yet.

It is clear in the current docs now that Z is more or less the same scale as X. maybe it is scaled to the scale of X post-prediction by the pipeline. Haven't verified yet.


Change LTC to GRLC

This will allow accurate fiat balances to be displayed.

Those exchanges don't have Garlicoin, so this won't work. The other exchanges are disabled by virtue of not being included in currencies.json, and CoinMarketCap already works.


As an LA I want to know which scheme's milestone I am changing

As an LA I want to know which scheme's milestone I am changing so that I do not inadvertently update the wrong one.

Authority feedback:

Would be useful to have the name of the scheme on all the sub pages e.g. change milestone dates, so that CAs know which scheme we are updating
When you are on the 'Change Milestone Dates' page you cannot see what scheme you are editing - would be useful to have the name of the scheme at the top of the page for reference

Could use a question caption to show the scheme name:


Program stuck in "LFS_ASSERT(err <= 0);"

Hi,
i am trying to run littlefs filesystem with FreeRtos in a pic32mz chip.
I am debugging the code and i verify that program not return from this assert "LFS_ASSERT(err <= 0);".
err = 1.
Function on lfs.c file:
static int lfs_bd_erase(lfs_t *lfs, lfs_block_t block)
{
    LFS_ASSERT(block < lfs->cfg->block_count);
    int err = lfs->cfg->erase(lfs->cfg, block);
    LFS_ASSERT(err <= 0);
    return err;
}

Some suggestion on what can cause this "error" ?
Notes:
PIC32MZ2048EFM144 chip.
DM320007-C development board.
SST26 sqi flash memory.
Thank's.

Some suggestion ?
Maybe media not attached / working ?

The "erase" function is something platform dependent. You must implement it in a way that returns something valid as a lfs_error (enum defined in lfs.h). Your implementation is returning "1", a positive value.
My suggestion is that you modify it to return one of these 3:
LFS_ERR_OK          = 0,    // No error
LFS_ERR_IO          = -5,   // Error during device operation
LFS_ERR_CORRUPT     = -84,  // Corrupted

Hi @alexandrehagihara ,
I am using microchip mplab code configurator( MCC ) to generate the code for a pic32mz chip.
https://github.com/MicrochipTech/littlefs
https://github.com/littlefs-project/littlefs/issues/789

@alexandrehagihara is correct that this is a mistake in a level lower than littlefs. If the prog function returns "bytes written", there's a risk it expects littlefs to handle partial writes, which littlefs does not.
On the bright side, the reason this assert was added was to catch this exact mistake. So this is a good sign it's working (though it could have a comment).
Thanks @baldhead69 for opening an issue, but this is the wrong place for both this and #789. This project isn't owned or managed by Microchip, and we don't know much about what MCC is doing.
You can either contact Microchip's support, MCC's documentation may indicate where to go, or try to modify the generated code to work with littlefs.

Thank's @geky
I understand.
I would just like suggestions on what could be causing this type of problem.
Media(sst26 flash memory in this case) not attached, or without fisical commmunication maybe.
What else could cause this kind of problem ?
Any suggestion ?
Thank's.

Without more information we don't know, littlefs doesn't expect a positive number here. We just know the layer below isn't implemented to work with littlefs in this situation.


Add support for global "after connection opened" hook

Problem

I'd like to be able to set the Postgres search_path (i.e. schema) whenever a connection is opened in order to facilitate single database multi-tenancy using Postgres schemas.
Suggested solution

Add a hook that will be call a user-specified callback after a connection is opened for a client. The connection should be passed to the callback function as a parameter. The function should return a promise that blocks further queries until resolved.
Something along the lines of:
client.onConnection((connection) => {
  return connection.execute(...)
})

Alternatives

I've also looked into using https://github.com/Errorname/prisma-multi-tenant/ along with schema=abc in the connection urls, but unfortunately that causes multiple connection pools to be opened against the single database which isn't ideal.
Another option would be to add support for setting the schema globally for a query and all nested queries so that table names are generated with query prefixes (i.e. SELECT * FROM abc.posts). This could probably play nicely with the current middleware API.
Additional context

Making use of PostgreSQL schemas for tenancy would be really excellent.


Formatter: Doesn't format module docstrings

The formatter doesn't format the module's docstring.
See this example taken from the bokeh project playground
The code block of the module level docstring doesn't get formatted, but gets formatted just fine if it is a function-level docstring
""" Represent granular events that can be used to trigger callbacks.

Bokeh documents and applications are capable of supporting various kinds of
interactions. These are often associated with events, such as mouse or touch
events, interactive downsampling mode activation, widget or tool events, and
others. The classes in this module represent these different events, so that
callbacks can be attached and executed when they occur.

It is possible to respond to events with ``CustomJS`` callbacks, which will
function with or without a Bokeh server. This can be accomplished by passing
and event class, and a ``CustomJS`` model to the
:func:`~bokeh.model.Model.js_on_event` method. When the ``CustomJS`` is
executed in the browser, its ``cb_obj`` argument will contain the concrete
event object that triggered the callback.

.. code-block:: python

    from bokeh.events import ButtonClick
    from bokeh.models import Button, CustomJS

    button = Button(                 )

    button.js_on_event(ButtonClick, CustomJS(

        code='console.log("JS:Click")'))

Alternatively it is possible to trigger Python code to run when events
happen, in the context of a Bokeh application running on a Bokeh server.
This can accomplished by passing an event class, and a callback function
to the the :func:`~bokeh.model.Model.on_event` method. The callback should
accept a single argument ``event``, which will be passed the concrete
event object that triggered the callback.

.. code-block:: python

    from bokeh.events import ButtonClick
    from bokeh.models import Button

    button = Button()

    def callback(event         ):
        print('Python:Click')

    button.on_event(ButtonClick, callback)

.. note ::
    There is no throttling of events. Some events such as ``MouseMove``
    may trigger at a very high rate.

"""

def function():
    """ Represent granular events that can be used to trigger callbacks.

Bokeh documents and applications are capable of supporting various kinds of
interactions. These are often associated with events, such as mouse or touch
events, interactive downsampling mode activation, widget or tool events, and
others. The classes in this module represent these different events, so that
callbacks can be attached and executed when they occur.

It is possible to respond to events with ``CustomJS`` callbacks, which will
function with or without a Bokeh server. This can be accomplished by passing
and event class, and a ``CustomJS`` model to the
:func:`~bokeh.model.Model.js_on_event` method. When the ``CustomJS`` is
executed in the browser, its ``cb_obj`` argument will contain the concrete
event object that triggered the callback.

.. code-block:: python

    from bokeh.events import ButtonClick
    from bokeh.models import Button, CustomJS

    button = Button(                 )

    button.js_on_event(ButtonClick, CustomJS(

        code='console.log("JS:Click")'))

Alternatively it is possible to trigger Python code to run when events
happen, in the context of a Bokeh application running on a Bokeh server.
This can accomplished by passing an event class, and a callback function
to the the :func:`~bokeh.model.Model.on_event` method. The callback should
accept a single argument ``event``, which will be passed the concrete
event object that triggered the callback.

.. code-block:: python

    from bokeh.events import ButtonClick
    from bokeh.models import Button

    button = Button()

    def callback(event         ):
        print('Python:Click')

    button.on_event(ButtonClick, callback)

.. note ::
    There is no throttling of events. Some events such as ``MouseMove``
    may trigger at a very high rate.

"""

I'll try to tackle this. Just writing to avoid double work. 😃

@Glyphack awesome! The formatting of statements happens in suite.rs. There's already logic to format class and function docstrings, but it doesn't yet kick in at the top level. Let me know if you want more pointers.

I found that the stringaLiteralKind is not set correctly. I'm planning to add a function to see if a node is first statement and then set the doc string kind for string literal. Will open the pr shortly. Thanks for your help.

There's already logic in suite.rs that tests if it's the first statement. I'm not at my computer so sharing the source is a bit difficult but search for the place where we identify docstrings for classes and functions


I don't understand how to work with 0.3.0

v0.2.0 was easy: just add this to project/whatever.sbt:
resolvers += Resolver.url("bintray-sbt-plugin-releases", url("http://dl.bintray.com/content/sbt/sbt-plugin-releases"))(Resolver.ivyStylePatterns)
addSbtPlugin("me.lessis" % "bintray-sbt" % "0.2.0")

Then build.sbt can contain bintray-specific stuff, such as:
import bintray.BintrayKeys._

With 0.3.0 the above import fails.I tried commenting out the resolver, but no joy. What is the secret to getting v0.3.0 to work with Scala 2.11.7 and SBT 0.13.8?

As per readme, you only need to add addSbtPlugin("me.lessis" % "bintray-sbt" % "0.3.0") to your project/plugins.sbt file and sbt autoplugin magic will add all required settings. Then do sbt publish to publish.

That is not my experience, as mentioned.

You do not need to add the import statement explicitly, because keys that are defined in autoImport are imported automatically in .sbt files

Omitting the import yields:
/home/mslinn/work/experiments/play/PFView/build.sbt:32: error: not found: value bintrayPublishSettings

You do not need to use bintrayPublishSettings as well. Adding addSbtPlugin("me.lessis" % "bintray-sbt" % "0.3.0") is the only required change to your project to use this plugin, if you are fine with the default settings. And that is a good starting point in any case.

Let's close. This concerns a migration that happened a long while ago.


Make postprocess interface consistent with V2 protocol

What this PR does / why we need it:
This change makes the postprocess receive and allows it to return an InferResponse when the protocol is V2. This enables postprocess code to be agnostic to the transport mechanism (gRPC/HTTP). This is consistent with how preprocess functions.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2721
Type of changes
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Release note:
postprocess method receives an `InferResponse` and can return an `InferResponse` when the protocol is `V2`

The e2e tests will not pass as they are running against Docker images that do not have the updated version of KServe installed.

/lgtm
/approve


Incorrect -t -e values can lead to core dump

okay
$ ./kanzi -c -t empty -e tpaqx -i in -f -v 0
Could not create the compressor: Unknown transform type: 'EMPTY'
$ ./kanzi -c -t none -e tpaqx -i in -f -v 0
not okay
$ ./kanzi -c -t '' -e tpaqx -i in -f -v 0
terminate called after throwing an instance of 'std::out_of_range'
what():  basic_string::substr: __pos (which is 1) > this->size() (which is 0)
Aborted (core dumped)
$ ./kanzi -c -t none -e '' -i in -f -v 0
terminate called after throwing an instance of 'std::out_of_range'
what():  basic_string::substr: __pos (which is 1) > this->size() (which is 0)
Aborted (core dumped)

Good catch. Should be easy to fix.

Commit [8aed7a11]


[Bug Report]: Test-NamePrefixAvailability not compatible with new dependencies approach

Describe the bug
The script Test-NamePrefixAvailability relies on the original JSON-Parameter files to find all names that must be unique and hence validated.
As we moved away from the JSON-Parameter files in favor of Bicep-Template files, we should also update this logic or remove its reference from the wiki as it will produce misleading results.
To reproduce
Run the Test-NamePrefixAvailability function with for example a used storage account name.
Code snippet
No response
Relevant log output
No response

1.) add a note in utility docs
2.) fix it