chore(deps): :arrow_up: update dependency aws-sdk to v2.1417.0

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

aws-sdk
2.1416.0 -> 2.1417.0

Release Notes

aws/aws-sdk-js (aws-sdk)
v2.1417.0
Compare Source

feature: ES: Regex Validation on the ElasticSearch Engine Version attribute
feature: LexModelsV2: This release adds support for Lex Developers to view analytics for their bots.
feature: M2: Allows UpdateEnvironment to update the environment to 0 host capacity. New GetSignedBluinsightsUrl API
feature: Snowball: Adds support for RACK_5U_C. This is the first AWS Snow Family device designed to meet U.S. Military Ruggedization Standards (MIL-STD-810H) with 208 vCPU device in a portable, compact 5U, half-rack width form-factor.

v2.1416.0
Compare Source

feature: DocDB: Added major version upgrade option in ModifyDBCluster API
feature: EC2: Add Nitro TPM support on DescribeInstanceTypes
feature: Glue: Adding new supported permission type flags to get-unfiltered endpoints that callers may pass to indicate support for enforcing Lake Formation fine-grained access control on nested column attributes.
feature: IVS: This release provides the flexibility to configure what renditions or thumbnail qualities to record when creating recording configuration.
feature: LakeFormation: Adds supports for ReadOnlyAdmins and AllowFullTableExternalDataAccess. Adds NESTED_PERMISSION and NESTED_CELL_PERMISSION to SUPPORTED_PERMISSION_TYPES enum. Adds CREATE_LF_TAG on catalog resource and ALTER, DROP, and GRANT_WITH_LF_TAG_EXPRESSION on LF Tag resource.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular-devkit/build-angular
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS><17.0.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/jest-preset-angular
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!   2 more (@nx/angular, @storybook/angular)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@angular/compiler
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular/localize
npm ERR!     peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@angular-devkit/build-angular
npm ERR!       dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-07-21T19_03_37_484Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-07-21T19_03_37_484Z-debug-0.log

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular/animations
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>|| ^17.0.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular/material
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   2 more (@angular/platform-browser, @ngneat/spectator)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@angular/core
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular/animations
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-08-12T22_42_38_863Z-eresolve-report.txt

npm ERR!


Issue 88 upgrade to spark 2.4.7

[Issue-88] Upgrade Spark 2.4 connector to Spark 2.4.7
[Issue-86] Update to Scala 2.12 in spark 2.4 connector

#86 #88


Update govuk frontend to 3.3.0

This updates the govuk-frontend library from version 2.13.0 to 3.3.0.  This mainly means that the colours have changed.
The page weight of the compiled CSS has also been reduced.
Review app: https://psd-pr-65-web.london.cloudapps.digital/

Many thanks for doing this work @frankieroberto!
I've had a good look through the app and there are a few snags - some likely because it highlights gaps in our codebase.

Missing underline on skip link in header.

Footer text now using two colours - should all be dark I think.

Force underlines on footer links (override design system).

Focussed hover for white buttons isn’t nice (could consider a separate issue as our existing hover for them isn’t good).

 I suspect if we updated our autocompletes this might fix this issue. They're not using full design system styles.

Hover state of delete buttons - should get darker (design system has introduced delete buttons since we made ours).

Need better focus state for autocomplete clear button (suggest thick yellow background, black border bottom)

Keycloak styles will also need updating (different app though)

@edwardhorsford so the "Missing underline on skip link in header" is a bug within the govuk-frontend code itself, specifically when "global styles" are enabled.
Has been reported to the Design System team here: https://github.com/alphagov/govuk-frontend/issues/1641

[x] Missing underline on skip link in header.
Bug with design system - reported to them. In the short term I suggest leaving as is

[x] Footer text now using two colours - should all be dark I think.

[x] Force underlines on footer links (override design system).
Design system team have an update coming that resolves this.

[x] Hover state of delete buttons - should get darker (design system has introduced delete buttons since we made ours).
Swapped to using govuk-button--warning

[ ] Need better focus state for autocomplete clear button (suggest thick yellow background, black border bottom)

Will raise as separate bug

[ ] Focussed hover for white buttons isn’t nice (could consider a separate issue as our existing hover for them isn’t good).

Will fix in separate PR

[ ] Focus State slightly broken on autocomplete inputs - no thick black border. I suspect if we updated our autocompletes this might fix this issue. They're not using full design system styles.

Will raise as separate bug

[ ] Keycloak styles will also need updating (different app though)

Will raise as separate story


Regenerate SDK

#50  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shreyav and the rest of your teammates on  Graphite

Merge activity

Jul 1, 5:19 PM EDT: @shreyav merged this pull request with Graphite.


feat: Allow configurable cookie SameSite header

Changes proposed in this pull request
Added a new ENV flag (INTERACTION_COOKIE_SAME_SITE) that is unset by default and allows the ASE to set it to lax, strict, or none if they want.

Context
Added mainly for control over this value in auth.rafiki.money, in order to be able to have payments work in an iframe, needed in WM Tools

Yes, you are correct strict would not work, because that implies same domain (and yes, portnumbers are not considered different domains).
But it's upto the ASE to set this value, and since the possible values include strict as well as a boolean value of 'true' that also is interpreted as strict I don't think we can disallow these (or maybe we can restrict the values to 'lax', 'none' & undefined ... not sure if the session property will allow it)
on another note, I see from your screenshot that Secure is not set ... is that because you were testing on http not https, or do we have to set that implicitly also ?

on another note, I see from your screenshot that Secure is not set ... is that because you were testing on http not https, or do we have to set that implicitly also ?

Yeah, I am testing on http. I suppose you're anticipating problems with setting SameSite to None, since it must have the secure flag. If you look at the cookie on testnet its secure, so I think we're good there and we dont need to explicitly set it.

But it's upto the ASE to set this value, and since the possible values include strict as well as a boolean value of 'true' that also is interpreted as strict I don't think we can disallow these (or maybe we can restrict the values to 'lax', 'none' & undefined ... not sure if the session property will allow it)

I changed the type to export type SameSiteCookieProp = 'lax' | 'none' | undefined and not getting any ts errors since its a subset of the valid arg type... I think it makes sense to disallow strict since we know it wont work. This set of valid values goes beyond our little env var parsing pattern a bit... I think something like this would work:
function envEnum<T extends string>(
  name: string,
  allowedValues: T[],
  defaultValue: T | undefined
): T | undefined {
  const envValue = process.env[name]
  if (envValue && allowedValues.includes(envValue as T)) {
    return envValue as T
  }
  return defaultValue
}

  interactionCookieSameSite: envEnum(
    'INTERACTION_COOKIE_SAME_SITE',
    ['lax', 'none'],
    undefined
  ),

I guess this presumes we don't want to error if they set an invalid value...

I updated the code based on the recommendation; went with the envEnum, seems much cleaner to me than the inline solution


add variables for icons and navigation labels

create a firmer definition between icons and secondary icons and assign icons in the app accordingly
add variables for nav icons and nav labels to make theming a little more fun

color-nav-label is a semantic label like color-sidebar-background, i think it is okay since these are specific to the UI and not part of a broader pattern (yet).

Looks good. For future (and refactoring existing if you want), name partials like "maincontent" should be simplified to "main" or "content" depending on what makes sense given sibling names in the ontology. Together they are redundant. Similarly, "bottomsection" should probably be simplified to "bottom" since ultimately all elements are "sections".

Also, what I said about reversing name parts applies to the whole name. By using "color-background-sidebar" instead of "color-sidebar-background", sorting by name gives a useful scannable taxonomy. While there can be exceptions to create a taxonomy that indexes more easily for a functional group, and sidebar could be one of them, consistent repeating patterns like secondaries should definitely follow this lexicographical ordering, for example "color-secondary-icon" should probably be "color-icon-secondary" etc.

We also want to make names short because they are frequently combined. So while with "color-icon-secondary" might imply we should be using "color-icon-primary", I do prefer the brevity of what we have now with just "color-icon". As a suggestion, though I don't feel strongly, I'm curious how "2nd" feels instead of "secondary" as a shorter form. I previously suggested "alt", which could work in some cases, but usually secondary is part of a scale not a swappable "alternative". Though it could also be interpreted as "alternating".

@progrium - i can adjust names so it's type-noun-adjective/descriptor.
i'd like to leave secondary for now, i think it has the clearest meaning and i'd rather optimize for that rather than character length, since it's not something people will be editing super often.

👍


Can't modify playlist (change order, delete items)

Hi!
Unless I'm missing something, I can't change the playlist once it's been populated.
Especially, if you start playing a song from search results, songs might be added to the playlist that you don't actually want to listen ton but there is no way to delete them.
Thanks!

This is by design. I found the playlist/queue concept of the other players very confusing, so I tried to automatically manage the queue behind the scenes.
In case of search results, this doesn't work very nice. Room for improvement indeed.

Hi again, I was giving moped another spin today and came back to this issue. I'm trying to understand how you envision moped being used.
Here's my use case: I start playing an album and decide that I'd like to hear another one after this one, so I want to enqueue it. However, if I click on the first song of album #2, it just plays that instead, and I can't chose to add the album as a whole.
So, this might be by design, but in my case it means I can only listen to one album at a time using moped, and then I have to go play album 2 once I've finished listening to album 1. Essentially, that sort of brings us back to having to get up to go put CD #2 in the CD player once CD #1 has reached its end 😉
Am I missing something?

No, you're not missing something. This is by design.

One album at a time? Ok then, moped is not for me.
We can close this issue I think, thanks for answering.

Yes, one album at a time unfortunately.


What process are you following to allow PR's to Wiki?

We have been wanting to allow edit's to our wiki for Chocolatey, but we also want to "moderate" the submissions via pull requests.  Having hunted around a bit, we hadn't found an "easy" way to do this, but it looks like you guys have.
Would it be possible for  you to explain what you did to set this up so that this GitHub repo updates the wiki on the TypeScript GitHub Site.  What process are you following?
Thanks in advance!

We just have a new repo TypeScript-wiki that is identical to TypeScript.wiki (the wiki for our repo). Locally we have a wiki git clone that has two remotes pointing to the two repos, every time we have a new change to the TypeScript-Wiki @DanielRosenwasser merges the other repo in and pushes to the two remotes.
I would not call that a good solution though :) ideally github should allow PRs to the wiki. but until this happens, we are getting by.

Basically, when you create a GitHub wiki, a new git repo is set up, with ".wiki" appended to the base repo name. For instance, I believe ours was reachable at https://GitHub.com/Microsoft/TypeScript.wiki.git
You can clone the repo and then push to a new remote (in our case it was https://GitHub.com/Microsoft/TypeScript-wiki.git). I set up that remote as origin  and the original as actualwiki.
I'm on my phone so if any of this sounds wrong or vague, feel free to point it out and I'll try to clarify.

Thanks for all the information @mhegazy and @DanielRosenwasser.  This definitely sounds like a workable solution to the problem.  I totally agree that this is something that @github need to make easier.
@ferventcoder what are your thoughts?  I really like the idea of being able to accept changes to the documentation for Chocolatey, but also allow us to keep a check on what changes are being submitted.

Yep, we knew about the wiki repo, we just didn't think about pushing it to another source that would be PR-able.

https://github.com/chocolatey/choco-wiki

Noice one!
Thanks again for your help guys!


Implement get all ancestor of the thread

Details

Implement get all ancestor of the thread
Fixed Issues

$ https://github.com/Expensify/App/issues/32618
PROPOSAL: https://github.com/Expensify/App/issues/32618#issuecomment-1880462702
Tests

Open any report
Send a message
Reply in the thread of this message
Report steps 2-3 serval times
Verify that in each thread, all ancestors of this thread are displayed
Click on any ancestor action, and verify that we go to the current thread of this action

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Open any report
Send a message
Reply in the thread of this message
Report steps 2-3 serval times
Verify that in each thread, all ancestors of this thread are displayed
Click on any ancestor action, and verify that we go to the current thread of this action
Test these step above with an account that has many reports and report actions.
Verify that all ancestor actions are displayed as well.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/129500732/116ddad1-400e-4ddb-a05f-843d88bb7028

Android: mWeb Chrome
https://github.com/Expensify/App/assets/129500732/4d4ca28a-cfaf-4691-a725-def5d0a58812

iOS: Native

iOS: mWeb Safari
https://github.com/Expensify/App/assets/129500732/2a728101-e881-4794-b3ab-2fd6b593483f

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/129500732/4edcf645-7892-48f2-a951-843273959f73

MacOS: Desktop
https://github.com/Expensify/App/assets/129500732/bb6547b9-e3a0-41b3-9224-5fd387ac94c6

I can't mark unread the parent ancestor on a one-level thread

https://github.com/Expensify/App/assets/25520267/dcf0f223-1ca2-4b5e-80ad-8dd0a7187407

The marker position seems wrong. The marker should be on the top of the report action.

https://github.com/Expensify/App/assets/25520267/d293258d-ac90-4112-8341-0b936058fa95

@dukenv0307 Friendly bump on to update using memo and also fixed the conflicts. Thanks!

@dukenv0307 You're right! My bad; I should have paid more attention to which parent action and the report. I'll finish the testing and recording then!

@dukenv0307 Could you check the failing performance test?

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@mollfpr I am re-requesting a review from you because I caught a few things. Please re-review and re-test after the changes have been made.

I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

Let's pay special attention to this step here. It should always be done. But I am worried about these changes causing a performance regression and they are also consistently failing the Reassure tests.

Let's pay special attention to this step here. It should always be done. But I am worried about these changes causing a performance regression and they are also consistently failing the Reassure tests.

Yup, I'll the test I did was using an HT account.

We have failing lint and ts checks on ReportPreview, but we don't have any changes on that component. We have 1 lint error on the ReportUtils.

@mollfpr can you run through and address all of @dukenv0307's replies to my comments and tag me when this PR is in a better state? Thanks!

Thanks for the changes @dukenv0307. Went through and resolved a bunch of comments. I believe most of my remaining comments are minor. But we're still failing the "Reassure Performance Tests". I'll try to re-run them now.

@dukenv0307 We need to merge main here to fix the failing Reassure Performance Tests / perf-tests action.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

This PR is failing because of issue https://github.com/Expensify/App/issues/35914
The issue is reproducible in: Android, IOS
https://github.com/Expensify/App/assets/78819774/ad4c82e9-bf99-4bfd-aa00-e31c07c491c9

This PR is failing because of issue #35914

Just noting that the linked issue was demoted from being a blocker, so I'm not going to hold the release on this

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


feat(vite-plugin-angular): add ability to export from .ng files

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/analogjs/analog/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Which package are you modifying?

[x] vite-plugin-angular
[ ] vite-plugin-nitro
[ ] astro-angular
[ ] create-analog
[ ] router
[ ] platform
[ ] content
[ ] nx-plugin
[ ] trpc

What is the current behavior?
.ng format does not support defining a routeMeta
What is the new behavior?
This allows adding a route configuration to defineMetadata e.g:
  defineMetadata({
    route: {
      title: 'My page',
    },
  });

Happy to modify how this is supplied - this seemed the most natural to me (I have also extended the window type to include the RouteMeta type for route).
I assumed we didn't want to export the routeMeta in .ng files. Another option I considered was having a separate defineRouteMetadata
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
[optional] What gif best describes this PR or how it makes you feel?

Thanks! @allcontributors add @joshuamorony for code


Cosmos DB - MongoDB API samples

Description
Refactor Cosmos DB Powershell samples to use the new Az.CosmosDB mgmt cmdlets instead of New-AzResource/Set-AzResource + property object approach.
This PR is for the MongoDB API cmdlet samples.
Checklist

[X] This pull request was tested on both of:

[X] PowerShell 5.1 (Windows)
[X] PowerShell 6.x (Latest PowerShell)

[X] Scripts do not contain static passwords or other secret tokens.
[X] All Azure resource identifiers which must be universally unique are guaranteed to be so.

Testing information
Windows 10 1909 | 5.1 | 3.6.1
Windows 10 1909 | 6.2.4 | 3.6.1
Windows 10 1909 | 7.0.0 | 3.6.1
Windows 10 1909 -> WSL (Ubuntu 18.04) | 7.0.0 | 3.6.1

#sign-off


FloatingView not showing Android 4

Hi, first of all, thank you!
I have a problem, i just realized that the floatingview i implemented on my app isn't showing on android 4 devices. And, searching for the problem, I tried the sample you gave us on an android 4 device and it isn't showing too.
I saw another closed issue where it was supposely working on android 4. Is there a workaround that i need to  implement for this?

This library works correctly on Android 4.1.1 Emulator.
1.Did you try it?
mFloatingViewManager.setDisplayMode(FloatingViewManager.DISPLAY_MODE_SHOW_ALWAYS);
2.Did you declare the service in AndroidManifest.xml?
3.What's device name and Android Version?

The first option solved the issue, thanks!


Zero length default value to allow command success.

If you are looking for a key and want to have a zero length string returned you can't. The supplied default is not checked to see if it is exactly None. I have a use case where I want to populate a variable in a bash script and check if it is zero length the tool currently generates a non zero exit code. If you try and do this with the default flag you get a non zero error code when you specify --default "".
Current release
toml get --toml-path pyproject.toml version
error: key 'version' not found
toml get --toml-path pyproject.toml version --default ""
error: key 'version' not found

This pull request
toml get --toml-path pyproject.toml version
error: key 'version' not found
toml get --toml-path pyproject.toml version --default ""

this would be equivalent to
version = ""

Thanks for the PR


Error Action Pt2 :)

Sorry for the late reply - long weekend. :)
I have tried doing all of those before I opened the issue.  Let me add some more context to see if I can clarify the question:
I have a Jenkins job that kicks Invoke-Build.  In the build script it queries another system (that I don't control).  If the system can't find the items, rather than return null it throws an error of No Items Found.  I have attempted to do the following:

Change the Error Action Preference before running the command.
Try Catch Blocks
Trap the Error
Use the Commandlet -ErrorAction property

In each case it still sees the error and stops the script reporting there was an error in the build task.
    task traperroraction {
        $olderrorpref = $ErrorActionPreference
        $ErrorActionPrefrence = "Ignore"
        try{
            $updatestatus = -ErrorAction Ignore
        }
        catch{
            $updatestatus = $Null
        }
        $ErrorActionPrefrence = $olderrorpref
    }

Maybe the issue is Jenkins, but it appears to be Invoke-Build:
<task stack trace>
Build FAILED. 7 tasks, 1 errors, 0 warnings 00:00:29.1796869
You cannot call a method on a null-valued expression.

I cannot help without more details. Some thoughts:
(1) In your code there is a typo in the variable name $ErrorActionPrefrence.
If this is copied/pasted from your real code then this may be the reason.
Replace Prefrence with Preference.
(2) What is the full error message? It should normally point to the place of failure.
Try also to examine all errors in the global $Error. It may contain some hints
not shown in the "final" error message that technically stops the build.
(3) "You cannot call a method on a null-valued expression." - I have no idea where
it comes from. The provided code does not have any method calls. Examine your
code for potential $null values (including typos in variable names).

Hmm...  Let me dig a little more and see what I can find.  I wish I could share the raw code, but that is the bulk of the code in question (outside the actual command). The main point is that setting either -ErrorAction parameter or $ErrorActionPrefrence should do the trick for Invoke-Build, correct?

The main point is that setting either -ErrorAction parameter or $ErrorActionPrefrence should do the trick for Invoke-Build, correct?

I afraid, no.
Does your scenario work outside Invoke-Build?

It does if I use "SilentlyContinue" and not Ignore...

Ok, this can close.  Turns out that it was working correctly, and the try/catch or erroraction was working.  There was an error later on, but the logging in Jenkins made it confusing as to where the error was...  Sorry for the hassle. :)

@lanrongwen No problem at all. You may let the Jenkins team know about the confusing error if it can be improved.


Books cloud

[Node.js & express Books example] Docker build + ability to connect to remote IBM i servers with user-provided credentials

@ThePrez please take a look


Bug:  CLI: Exception view shows full path

Like the debug toolbar, the exception view in the cli should also replace the APP & SYSTEM paths.
This

makes them easier to read
saver to share

CodeIgniter 4 version
4.0.4

Please use the develop branch. The CLI error_exception file is updated already.

See #3367

Sorry, didn't see that.


Add dc and up as aliases for delete-cache and update.

Saves milliseconds of my life and it could save milliseconds of yours too! Also consistent with eopkg, fwiw.

Yes please!!


Remove Converger from diego docs

Convergence is now taken care of by the BBS via its convergence
sub-process
[#123284391]

Thanks, @luan !


TypeError: string indices must be integers

C:\Users\1\Desktop\kucoin\src>python3 bot-kucoin.py
Traceback (most recent call last):
File "C:\Users\1\Desktop\kucoin\src\bot-kucoin.py", line 45, in
config['api_key'] = api_keys['api_key']
TypeError: string indices must be integers
C:\Users\1\Desktop\kucoin\src>

If I'm not wrong then you have placed your API key with quote marks on. Remove them.

If not, please post the error.
I won't be able to guess what's wrong without looking :P

C:\Users\1\Desktop\simple-pump-and-dump-bot-master\node_wip>node bot.js
node:internal/process/esm_loader:74
internalBinding('errors').triggerUncaughtException(
^
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'inquirer' imported from C:\Users\1\Desktop\simple-pump-and-dump-bot-master\node_wip\src\prompts.js
←[90m    at new NodeError (node:internal/errors:363:5)←[39m
←[90m    at packageResolve (node:internal/modules/esm/resolve:698:9)←[39m
←[90m    at moduleResolve (node:internal/modules/esm/resolve:739:18)←[39m
←[90m    at Loader.defaultResolve [as _resolve] (node:internal/modules/esm/resolve:853:11)←[39m
←[90m    at Loader.resolve (node:internal/modules/esm/loader:89:40)←[39m
←[90m    at Loader.getModuleJob (node:internal/modules/esm/loader:242:28)←[39m
←[90m    at ModuleWrap. (node:internal/modules/esm/module_job:73:40)←[39m
←[90m    at link (node:internal/modules/esm/module_job:72:36)←[39m {
code: ←[32m'ERR_MODULE_NOT_FOUND'←[39m
}
C:\Users\1\Desktop\simple-pump-and-dump-bot-master\node_wip>

You just need to install node _modules. Go to src folder and in command line type "npm install" and execute. That should install dependencies and all the necessary packages.
I would advise you to learn some of the basics so you don’t feel dependent upon others.

One more tip if you look over the error it says “module not found”. You can quickly google how to install specific module on the directory.
[ERR_MODULE_NOT_FOUND]: Cannot find package 'inquirer'
For example, this above error is about “inquirer” so to install this specific package it would be “npm i inquirer”
Navigate to the node_wip in terminal and execute “npm i inquirer”

Its not working i cant install iohook..

Iohook is not used in the program at the moment. You should be able to exclude this without any issues.

Can we speak ? Some how ? i still have problem

Sir can you upload the builded folder without secrets? I cant fix this thing

C:\Users\1\Desktop\simple-pump-and-dump-bot-master\node_wip>node bot.js
node:internal/process/esm_loader:74
internalBinding('errors').triggerUncaughtException(
^
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'inquirer' imported from C:\Users\1\Desktop\simple-pump-and-dump-bot-master\node_wip\src\prompts.js
←[90m    at new NodeError (node:internal/errors:329:5)←[39m
←[90m    at packageResolve (node:internal/modules/esm/resolve:714:9)←[39m
←[90m    at moduleResolve (node:internal/modules/esm/resolve:755:18)←[39m
←[90m    at Loader.defaultResolve [as _resolve] (node:internal/modules/esm/resolve:869:11)←[39m
←[90m    at Loader.resolve (node:internal/modules/esm/loader:88:40)←[39m
←[90m    at Loader.getModuleJob (node:internal/modules/esm/loader:241:28)←[39m
←[90m    at ModuleWrap. (node:internal/modules/esm/module_job:57:40)←[39m
←[90m    at link (node:internal/modules/esm/module_job:56:36)←[39m {
code: ←[32m'ERR_MODULE_NOT_FOUND'←[39m
}
C:\Users\1\Desktop\simple-pump-and-dump-bot-master\node_wip>npm install inquirer
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade to @mapbox/node-pre-gyp: the non-scoped node-pre-gyp package is deprecated and only the @mapbox scoped package will recieve updates in the future
npm ERR! code 1
npm ERR! path C:\Users\1\Desktop\simple-pump-and-dump-bot-master\node_wip\node_modules\iohook
npm ERR! command failed
npm ERR! command C:\Windows\system32\cmd.exe /d /s /c node install.js
npm ERR! Downloading prebuild for platform: iohook-v0.9.1-node-v88-win32-x64
Downloading prebuild.tar.gz
npm ERR! Error: GET https://github.com/wilix-team/iohook/releases/download/v0.9.1/iohook-v0.9.1-node-v88-win32-x64.tar.gz returned 404
npm ERR! Prebuild for current platform (iohook-v0.9.1-node-v88-win32-x64) not found!
npm ERR! Try to build for your platform manually:
npm ERR! # cd node_modules/iohook;
npm ERR! # npm run build
npm ERR!
npm ERR! C:\Users\1\Desktop\simple-pump-and-dump-bot-master\node_wip\node_modules\iohook\install.js:16
npm ERR!   throw err;
npm ERR!   ^
npm ERR!
npm ERR! [Error: ENOENT: no such file or directory, open 'C:\Users\1\AppData\Local\Temp\prebuild.tar.gz'] {
npm ERR!   errno: -4058,
npm ERR!   code: 'ENOENT',
npm ERR!   syscall: 'open',
npm ERR!   path: 'C:\Users\1\AppData\Local\Temp\prebuild.tar.gz'
npm ERR! }
npm ERR!      C:\Users\1\AppData\Local\npm-cache_logs\2021-05-25T22_16_19_350Z-debug.log
C:\Users\1\Desktop\simple-pump-and-dump-bot-master\node_wip>

Iohook is not used in the program at the moment. You should be able to exclude this without any issues.

Bro ita not working always asking for that iohook even if i try to install the missing module.. Ill brake my pc

You can close the thread, but when you close can you give best settings for max profit ?

I don't think there is any best setting. Pumps are risky. Just to play it safe, start from 0.5 or 1. See if you hit those targets then adject the margin accordingly.

I don't think there is any best setting. Pumps are risky. Just to play it safe, start from 0.5 or 1. See if you hit those targets then adject the margin accordingly.

Well i adjusted settings to purche 0.75 or 75% of the money for 50% profit and profit margin of 2

The odds of selling a pump at peak are very low. Usually one or two hit it. Not everyone so don't have unreal expectations. Play safe or you could a lot.


As an employee, I want to know the population distribution within each country, including the total population, the population of people living in cities, and the population of people not living in cities.

For the population reports, the following information is requested:
The name of the continent/region/country.
The total population of the continent/region/country.
The total population of the continent/region/country living in cities (including a %).
The total population of the continent/region/country not living in cities (including a %).


Samsung Smartthings Outlet support

So i'm trying to follow the docs on how to add support for this plug, and have got to the stage where I can see data in the log.

Feb 17 21:17:10 raspz2m npm[3792]: #033[34m  zigbee2mqtt:debug#033[39m 2/17/2019, 9:17:10 PM Received zigbee message of type 'attReport' with data '{"cid":"genOnOff","data":{"onOff":1}}' of device 'outlet' (0x286d970001051d63)
Feb 17 21:17:10 raspz2m npm[3792]: #033[33m  zigbee2mqtt:warn#033[39m 2/17/2019, 9:17:10 PM No converter available for 'IM6001-OTP05' with cid 'genOnOff', type 'attReport' and data '{"cid":"genOnOff","data":{"onOff":1}}'
Feb 17 21:17:10 raspz2m npm[3792]: #033[33m  zigbee2mqtt:warn#033[39m 2/17/2019, 9:17:10 PM Please see: https://www.zigbee2mqtt.io/how_tos/how_to_support_new_devices.html.
Feb 17 21:17:10 raspz2m npm[3792]: #033[34m  zigbee2mqtt:debug#033[39m 2/17/2019, 9:17:10 PM Received zigbee message of type 'devChange' with data '{"cid":"genOnOff","data":{"onOff":1}}' of device 'outlet' (0x286d970001051d63)
Feb 17 21:17:10 raspz2m npm[3792]: #033[33m  zigbee2mqtt:warn#033[39m 2/17/2019, 9:17:10 PM No converter available for 'IM6001-OTP05' with cid 'genOnOff', type 'devChange' and data '{"cid":"genOnOff","data":{"onOff":1}}'
Feb 17 21:17:10 raspz2m npm[3792]: #033[33m  zigbee2mqtt:warn#033[39m 2/17/2019, 9:17:10 PM Please see: https://www.zigbee2mqtt.io/how_tos/how_to_support_new_devices.html.
Feb 17 21:17:12 raspz2m npm[3792]: #033[34m  zigbee2mqtt:debug#033[39m 2/17/2019, 9:17:12 PM Received zigbee message of type 'attReport' with data '{"cid":"genOnOff","data":{"onOff":0}}' of device 'outlet' (0x286d970001051d63)
Feb 17 21:17:12 raspz2m npm[3792]: #033[33m  zigbee2mqtt:warn#033[39m 2/17/2019, 9:17:12 PM No converter available for 'IM6001-OTP05' with cid 'genOnOff', type 'attReport' and data '{"cid":"genOnOff","data":{"onOff":0}}'
Feb 17 21:17:12 raspz2m npm[3792]: #033[33m  zigbee2mqtt:warn#033[39m 2/17/2019, 9:17:12 PM Please see: https://www.zigbee2mqtt.io/how_tos/how_to_support_new_devices.html.
Feb 17 21:17:13 raspz2m npm[3792]: #033[34m  zigbee2mqtt:debug#033[39m 2/17/2019, 9:17:13 PM Received zigbee message of type 'devChange' with data '{"cid":"genOnOff","data":{"onOff":0}}' of device 'outlet' (0x286d970001051d63)
Feb 17 21:17:13 raspz2m npm[3792]: #033[33m  zigbee2mqtt:warn#033[39m 2/17/2019, 9:17:13 PM No converter available for 'IM6001-OTP05' with cid 'genOnOff', type 'devChange' and data '{"cid":"genOnOff","data":{"onOff":0}}'
Feb 17 21:17:13 raspz2m npm[3792]: #033[33m  zigbee2mqtt:warn#033[39m 2/17/2019, 9:17:13 PM Please see: https://www.zigbee2mqtt.io/how_tos/how_to_support_new_devices.html.

I added this to the devices.js file:
{
    zigbeeModel: ['outlet'],
    model: 'IM6001-OTP05',
    vendor: 'Samsung',
    description: 'Smartthings Outlet',
    supports: 'on/off',
    fromZigbee: [],
    toZigbee: [],
    configure: (ieeeAddr, shepherd, coordinator, callback) => {
            const device = shepherd.find(ieeeAddr, 1);
            const cfg = {direction: 0, attrId: 0, dataType: 16, minRepIntval: 0, maxRepIntval: 1000, repChange: 0};
                        const actions = [
                                                (cb) => device.bind('genOnOff', coordinator, cb),
                                                (cb) => device.foundation('genOnOff', 'configReport', [cfg], foundationCfg,     cb),
                                            ];

                execute(device, actions, callback);
    },
},

but now stuck on what to add to toZigbee.js to control the device... status updates I think I figured out!

Well, solved my own question: please check and see if i did this right (sorry, didn't do in git forked  yet, please add from here if you are willing).
devices.js
// smartthings
{
    zigbeeModel: ['outlet'],
    model: 'IM6001-OTP05',
    vendor: 'Samsung',
    description: 'Smartthings Outlet',
    supports: 'on/off',
    fromZigbee: [fz.samsung_outlet, fz.samsung_outlet_report],
    toZigbee: [tz.samsung_on_off],
    configure: (ieeeAddr, shepherd, coordinator, callback) => {
            const device = shepherd.find(ieeeAddr, 1);
            const cfg = {direction: 0, attrId: 0, dataType: 16, minRepIntval: 0, maxRepIntval: 1000, repChange: 0};
                        const actions = [
                                                (cb) => device.bind('genOnOff', coordinator, cb),
                                                (cb) => device.foundation('genOnOff', 'configReport', [cfg], foundationCfg, cb),
                                            ];

                execute(device, actions, callback);
    },
},

fromZigbee.js
samsung_outlet: {
            cid: 'genOnOff',
            type: 'devChange',
            convert: (model, msg, publish, options) => {
                    //console.log(msg.data);
                    return {state: msg.data.data.onOff === 1 ? 'ON' : 'OFF'};
            },
    },
    samsung_outlet_report: {
            cid: 'genOnOff',
            type: 'attReport',
            convert: (model, msg, publish, options) => {
                    return;
            },
    },

toZigbee.js
samsung_on_off: {
key: ['state'],
convert: (key, value, message, type, postfix) => {
    const cid = 'genOnOff';
    const attrId = 'onOff';

    let state = value.toLowerCase();
    if (state === 'on' ) {
            state = 1;
    } else if ( state === 'off' ) {
            state = 0;
    } else {
            return;
    }

    if (type === 'set') {
        if (typeof value !== 'string') {
            return;
        }

        return {
            cid: cid,
            cmd: state,
            cmdType: 'functional',
            zclData: {
            },
            cfg: cfg.default,
        };
    } else if (type === 'get') {
        return {
            cid: cid,
            cmd: 'read',
            cmdType: 'foundation',
            zclData: [{attrId: zclId.attr(cid, attrId).value}],
            cfg: cfg.default,
            };
        }
    },
},

So "get" doesn't do anything... not sure why, but do i care?

added pull request on cleaned up code and fork. https://github.com/Koenkk/zigbee-shepherd-converters/pull/286

An issue I found... seems as though the plug doesn't act as a router, even though its labeled as one in the logs and on the admin.  If i fetch a network map it shows as offline

@marc-gist that online/offline state is not accurate, if you can control the device, you can ignore this.


Soundtrack and animation not in sync when using autostart (for heavy scenes)

Godot version
v4.1.1.stable.mono.official [bd6af8e0e]
System information
Godot v4.1.1.stable.mono - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2070 Super (NVIDIA; <IP_ADDRESS>54) - Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 Threads)
Issue description
when using the autostart feature with a heavy scene, the audio is out of sync with the animation.
when calling play from a script, sync works well in the same scene.
Steps to reproduce
open project in synctest.zip and run project.
Note:

The drums at 0s and at 16s are out of sync (using autostart)
The drums at 32s and at 52s, sync works as expected (because script plays animation at 20s)

Minimal reproduction project
SyncTest.zip

This is not really a bug, but a limitation of the AnimationPlayer's autoplay on load: https://docs.godotengine.org/en/stable/classes/class_animationplayer.html#class-animationplayer-property-autoplay.
It's triggered when the scene is loaded. This does not mean the scene is rendered. See also my comment here: https://github.com/godotengine/godot/issues/81549#issuecomment-1871398751
In your case, this will do the trick: first, deactivate the autoplay on load for your track "new_animation". And in a script attached e.g. to your scene root node, have this code:
func _ready():
	RenderingServer.connect("frame_post_draw", play_music)

func play_music():
	RenderingServer.disconnect("frame_post_draw", play_music)
	$AnimationPlayer.play("new_animation")


Support v2 agents

It looks like there are some new settings for veeam.ini as part of the v2 agents that will need to be incorporated into veeam.ini.epp

Testing of an updated template against nodes that had their agent deployed from the Veeam console showed some fairly major issues including changing values added to the config by the deployment. The result of this discovery is that I am starting on a different approach that is more compatible with agents being deployed via the Veeam console.

I've got a function type and provider working and am now working to adapt the rest of the code to support it.

#8 will resolve this.

#8 has been merged and published to the Puppet Forge. This was a major improvement to how the module works, thank you for the effort!


Can not use put/delete methods in web browser ，is that any solution?

Can not use put/delete methods in web browser ，is that any solution?

Resolved, needs to activate SSL and use HTTPS


Temporarily replace blue with magenta

This is a temporary PR, being done as part of the testing for https://github.com/Expensify/Expensify.cash/pull/2978. In the testing plan here, this is "PR A".
Please note that this PR will be reverted soon after it's merged.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


GDPR support

Allow devs to opt-in / opt-out an end user from tracking.

you just love to see this


Recording rules in rules page don't look good with dark theme

It seems like the recording rule panel doesn't have the necessary styling applied to it in the dark mode:

Hello, I would like to work on this. Can you assign it to me?

Hello, I like to contribute to this issue.

Hi @GiedriusS! There was no updates more than month, so I would like to make tiny contribution by this one

Hello, sorry I wasn't able to get a hold of this in the past month. I'll unassign myself, please feel free to contribute to this.

Go for it @Laconty 👍

Is this Issue finished? I see the merge in the PR, maybe is better close the Issue

You're right @solrac97gr!  https://github.com/thanos-io/thanos/pull/5151 resolved it, let's close this, thanks!


ARC-0001: Renaming signTxn to signTxns

Following comment
https://github.com/algorandfoundation/ARCs/issues/1#issuecomment-895374290
from @DanBurton
This PR is to be dicussed.
signTxns is indeed more logical.
signTxn can still exist and be mapped to signTxns for backward
compatibility.
So I don't think this should create too many issues
but please raise your voice if it does.

Awesome!


Handle special term semester data

Special term semesters are represented by integers 3 (special term 1) and 4 (special term 4).
Right now, it is just displayed as Semester 3 and Semester 4, would be good to add a special label for it!

Close in #77


Resolve additional (shared) DLL paths automatically

Issue:
The future version should automatically try to resolve the additional runtime/shared paths/frameworks required by the plugins:

Relates to #21 where we had to manually add additional runtime path:
PluginLoadContextOptions.Defaults.AdditionalRuntimePaths.Add(Path.GetDirectoryName(typeof(Button).Assembly.Location));

The AspNetCore-library also has this:
        var aspNetCoreLocation = Path.GetDirectoryName(aspNetCoreControllerAssemblyLocation);
        PluginLoadContextOptions.Defaults.AdditionalRuntimePaths.Add(aspNetCoreLocation);

Without these, the plugins can't load all the required DLLs.
Possible solution:
It might be possible to use MetadataReference to get the references. For example:
var assemblyRef = MetadataReference.CreateFromFile(assemblyPath);
var references = assembly.GetReferencedAssemblies();

This must be done recursively to find all the referenced assemblies and their locations. This info is then added to PathAssemblyResolver in FolderPluginCatalog.

The pull request takes care of adding the shared frameworks used by host application into to the assembly resolver.
This should remove the need of having to define AdditionalRuntimePaths in many situations. If your host app is WinForms and your plugin uses WinForm dlls, AdditionalRuntimePaths isn't needed any more.
But, in situations where the plugin is using shared framework (Desktop / ASP.NET Core) and your host application isn't, AdditionalRuntimePaths is still needed. This can happen for example if your Console App points to a folder where DLL's require references to Microsoft.WindowsDesktop.App (C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App\3.1.5).


inside range but skip

the range to buy was under 2500 but the AB ignored them
[21:45:51] | (70-ok)  | Weydandt        | 1800   | 1900   | 58 Minutes      | skip >>>
[21:45:51] | (73-ok)  | Karaman         | 1900   | 2000   | 58 Minutes      | skip >>>

The tool will skip , if it already tried to buy the card and failed


Operator logs sensitive information on info level

The operator allows reading various configuration items via ResourceRef which is great. However, upon retrieving the configs from the Stack CR it logs all values on info causing secrets leakage.
Expected behavior

If these configs need to be logged at all, either mask these values before doing so or increase logging verbosity to debug.
Current behavior

Secrets leak on info. Also the operator default manifests set the level to debug, see https://github.com/pulumi/pulumi-kubernetes-operator/blob/master/deploy/yaml/operator.yaml#L23
Steps to reproduce

Deploy operator
Deploy stack

apiVersion: pulumi.com/v1alpha1
kind: Stack
metadata:
  name: stack
  namespace: pulumi-operator
spec:
  commit: xzy
  envRefs:
    PULUMI_ACCESS_TOKEN:
      filesystem:
        path: /path/to/pulumi_api_token
      type: FS
...

Observe log emitting all stack properties on info.

While debug does print all stack properties, in this case I would expect the path to be printed but not the secret content itself? That said, we should reduce verbosity by default. See #138.


movies (only) being renamed by Deluge as None-None

@sarethan and I have had many movies download recently and get renamed as None-None-{quality}. we need to identify which part of the config is producing the faulty entries and add in some kind of error handling. possibly:
if $x AND $y !="None"
title = $x-$y-$quality
Else
do not rename at all and place in default secrets.dir.dmc
it wouldnt be such an issue if the problematic entries came one at a time; then manual corrections could be made.
currently, on my system at least, multiple movies are being renamed to None-None-quality concurrently. the result is numerous movies all pointing to the same corrupted movie file. since Deluge runs the completed task the directory gets scanned as each one finishes and so some of them show up in Plex as if they downloaded properly, but when someone attempts to view the movie it errors out as an invalid media type

it would appear that this was a problem with Flexget not with our specific config. reference Flexget Issue 697 for more info.
if you are experiencing this issue please update Flexget to v1.2.441 with command:
sudo pip install --upgrade flexget


challenge tracker bug ?

everytime you open the challenge tracker it goes back a version to where Liberty Falls won't show,Then you gotta close out the app again & restart it to get it to show (V3?)I do get all of my challenge progress back though.

Yes this is the legacy version of the app, it should open in a new tab, but apologies for the confusion. We've got some changes in the development branch coming tonight that clear this up by removing the link to the challenge tracker and legacy app and moving it to the settings menu for now. The challenge tracker is also being reworked in the future.

Actually ill leave this open till we push tonight.


package org.apache.flink.shaded.guava version conflict in flink 1.14

Describe the bug(Please use English)
same with #841
flink-cdc-connectors (master branch which resolve #746 ) use<EMAIL_ADDRESS>https://github.com/ververica/flink-cdc-connectors/blob/473e36b9cd00b46a62f4bcd6fd5f6a2f8aeaab2c/pom.xml#L127-L132
however, flink 1.14 use<EMAIL_ADDRESS>(actually flink use the latest version)
https://github.com/apache/flink/blob/5c3bca55682d7f10be0e2ab399d8a03d10d0f5fb/flink-streaming-java/pom.xml#L65-L68
		<dependency>
			<groupId>org.apache.flink</groupId>
			<artifactId>flink-shaded-guava</artifactId>
		</dependency>

Environment :

Flink version :  1.14
Flink CDC version: master branch
Database and version: postgres 11.8

To Reproduce
Steps to reproduce the behavior:

Thes test data :
The test code :
The error :

Additional Description
java.lang.ClassNotFoundException: org.apache.flink.shaded.guava18.com.google.common.util.concurrent.ThreadFactoryBuilder error occured because of this confliction.

Now I know that sql jar include all dependencies required and non-sql jar doese not.
So I decide to use sql jar at present.

For future readers:
Got the same exception using com.ververica:flink-connector-mongodb-cdc
I wasn't sure what the sql jar is, but com.ververica:flink-sql-connector-mongodb-cdc fixed it.
(I'm not sure if this has any other consequences, though)

Now I know that sql jar include all dependencies required and non-sql jar doese not.
So I decide to use sql jar at present.

Can you please paste your maven dependency which fixed the issue?

Can you please paste your maven dependency which fixed the issue? l meet you


Marathon conf permissions

This recursively sets /etc/marathon/conf permissions to 700.
I had to add some reverts to this, because I based this branch on a different pull request instead of master :frowning:

This breaks a few Distributive health checks for marathon that check the existence of several configuration files under that directory. We should modify them and merge a new version of distributive-rpm at the same time as this PR.

My concern is that apps in '/etc/marathon` contain sensitive information. Maybe we should move the apps to a separate directory and make it 700.

IIRC, you were talking about having that separate dir for apps be /etc/marathon/apps? Do we need to make /etc/marathon mode 700, and then /etc/marathon/apps be something like 744?

/etc/marathon/apps, /etc/marathon/store, /etc/marathon/conf should be 700, since there are credentials in some of the files.

I've added the mode change to /etc/marathon/store, and added an entry for /etc/marathon/apps. Is there anything in the marathon role that should be migrated to the apps directory, or is that all user configured?

take a look at the jobs.yml file in the marathon role. we probably want to move the marathon-consul and mesos-consul json files into the /etc/marathon/apps directory

I am seeing the broken distributive checks:
time="2015-11-17T16:32:24Z" level=warning msg="Check(s) failed, printing checklist report" checklist="marathon health check" report="↴\nTotal: 16\nPassed: 10\nFailed: 6\nInsufficient permissions to read: /etc/marathon/conf/\nInsufficient permissions to read: /etc/marathon/conf/zk\nInsufficient permissions to read: /etc/marathon/conf/http_port\nInsufficient permissions to read: /etc/marathon/conf/event_subscriber\nInsufficient permissions to read: /etc/marathon/conf/hostname\nInsufficient permissions to read: /etc/marathon/marathon.nginx"

What user is being used for the checks? The permissions for the conf dir is 700

Just a note: none of these files are executable, so this should probably 600 instead of 700, as well.

@BrianHicks How does this look?

@sehqlr looks good WRT the permission, thanks.

we still need a solution for the failing distributive checks

Right. We were talking about that on Slack, but I don't think we came to a decision about what to do one way or another

@sehqlr One solution is just to remove them from distributive-rpm and make a new release.

do we need to push this to the next release?

If we can't get this resolved fist thing in the morning, it will have to go to 0.6.

This will be ready once we have a new distributive-rpm release after merging https://github.com/CiscoCloud/distributive-rpm/pull/27.

Merge order note: we need to either apply only one of this and #955, or apply this one first.

Second merge order note: this has to be after #959.

#955 got merged, @sehqlr could you check if this is still relevant?

@sehqlr @BrianHicks @siddharthist so what's the plan for this one? merge #959, rebase this to be compatible with the changes in #955, and then merge?

I will check to see if this is still relevant, first.

It's obsoleted by #955, as far as I can tell. We don't need to change permissions on the folder because it doesn't exist anymore.

But the files containing sensitive information just moved to /etc/marathon so that directory should have the more restrictive permissions, right?

That's a good point. Yes, it should.

On Jan 20, 2016, at 6:22 AM, Ryan Eschinger<EMAIL_ADDRESS>wrote:
But the files containing sensitive information just moved to /etc/marathon so that directory should have the more restrictive permissions, right?
—
Reply to this email directly or view it on GitHub.

While the change in #1034 is good, it doesn't actually address the entire problem in this issue. There are still files in /etc/marathon/* that contain sensitive information (tokens/secrets). I created a new issue to track this: #1047


Localtunnel not establishing connection

Hello,
I've been recently playing around with hoaxshell and trying to make its connection go through localtunnel, instead of running it on a local network. I managed to make it work with Ngok, but this has a limit of 20 connections per minute, which is easily achieved by running a few commands. With localtunnel, no errors arise when running the payload in PowerShell, but no connection is found, nothing happens.  This happened both connected to the same local network and two separate ones.
Here are the commands I ran on Linux:
cd hoaxshell/
sudo python3 hoaxshell.py -lt
On windows powershell:
powershell -e JABzAD0AJwBlAGEAcwB [...] fQA=
Am I doing this correctly?

@juicyhacker this happens for me some 30 sec after terminating the session, but never before that

@Skylark055 yeah that's normal because you close the server, mine is when executing the payload as "victim".

@Skylark055 yeah that's normal because you close the server, mine is when executing the payload as "victim".

Exactly, weird it does that for you immediately. Strange also that mine seemingly has a connection without a shell

@Skylark055 yeah that's normal because you close the server, mine is when executing the payload as "victim".

Exactly, weird it does that for you immediately. Strange also that mine seemingly has a connection without a shell

@Skylark055 The network I was on was refusing connection with LocalTunnel, now on my own network I am having the same issue as you.

@Skylark055 yeah that's normal because you close the server, mine is when executing the payload as "victim".

Exactly, weird it does that for you immediately. Strange also that mine seemingly has a connection without a shell

@Skylark055 The network I was on was refusing connection with LocalTunnel, now on my own network I am having the same issue as you.

That makes sense. Also @davidcenoura Ngrok works fine! It's just rate limited to 20 connections per minute due to it being a free plan, which is only resolved by paying for their services. There is nothing wrong with it, only localtunnel is broken right now for us.

@Skylark055 @juicyhacker please, update hoaxshell and try localtunnel again. Let me know if the issue is resolved.

@Skylark055  my payload generates fine when trying the ngrok option but when executing it on windows powershell I get the Invalid web request error

@Skylark055 @juicyhacker please, update hoaxshell and try localtunnel again. Let me know if the issue is resolved.

Hey, The update fixed one thing: The reverse shell now can be established! As seen with the screenshot attached though, it only executes one command until it breaks. It ended up killing my internet on my windows machine, in effect terminating the shell.
Here are some screenshots:


Section tag is so commonly used. It will be very convenient to add them to the default block render map.

<section> tag is so commonly used. It will be very convenient to add them to the default block render map.expect so！

Thanks for pointing this out @lisun0459, semantic tags like <section> and <article> are way more common nowadays than when the project was started. I'd be curious to see what is the distribution of tags supported by custom block render maps out in the wild.
This looks like a very good first issue for a community member who would like to contribute a code change to Draft.js! I'm more than happy to assist being the point of contact and doing a code review.

These appear to be missing from the documentation at https://draftjs.org/docs/advanced-topics-custom-block-render-map?


Added config.production.json for easy installation to heroku (or any other).

For newbie staticman users it was quite a hassle to setup staticman with heroku. It wouldn't work just out of the box. It took me about an hour to understand why this was not working.
This PR will help users to get started with Staticman + Heroku (or any other) pretty easily. Just setup your site and add environment variables to heroku app settings and Done! :sparkle:

This caused me headaches when I started working with Staticman, too. I did exactly what you did. However, I came to realize that the config.production.json file is not needed when running in Heroku, especially for the purpose of simply pointing at the environmental variables. The convict documentation speaks to this. In Heroku, I have multiple Staticman apps, one each for dev, staging, and production. I do not source/provide a config.[env].json file for any of them.
I do, however, maintain a config.development.json file for local development (because I find it easier to maintain/adjust those settings locally via a file instead of via environmental variables). But, I do not source it.

@jamesmortensen Correct, a config.production.json file should not be needed in Heroku. Of course, this assumes that you have set the environment variables either via the GUI or command line.


feat: changes for ics

Description
This PR is part of an effort to support sdk 47 and ibc7 without forks.  We
would love review and feedback, but it shouldn't be considered for merging
at this time.
It relates to this PR on ICS:
https://github.com/cosmos/interchain-security/pull/817
Commit Message / Changelog Entry
pending. We don't even know if this should be merged, and the pr is being
made so that we can get advice.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Thanks, @faddat. Could you please give us some more context/information of why this change would be needed?
If I look at https://github.com/cosmos/interchain-security/pull/817 and I see the item Switch to forked vesion for ibc-go to bypass the passing of pointer to empty struct in IBCKeeper.NewKeeper, does this mean that for ICS they need to be able to set a pointer to empty struct for the staking keeper? It sounds a bit strange to me that they would want that, so could you elaborate why that is needed?

I cannot, sorry.  @vuong177 can.  This needs to be linked to this:
https://github.com/cosmos/interchain-security/issues/852
and
https://github.com/cosmos/cosmos-sdk/pull/15917

hey yeah it weird please see the code lines in the link https://github.com/cosmos/interchain-security/blob/main/app/consumer/app.go#L317-L342. So we need the consumerkeeper to act as stakingkeeper in the consumer chain to pass in the IBCKeeper, while the consumerkeeper also need to pass in some properties of the IBCKeeper in order to do that IBCkeeper need to be initialize first. so to make this work they will pass the pointer to a empty struct first (consumerkeeper) then assign the value to where the pointer is pointed to. This use to work for ibc-go v4 since IBCKeeper only check for empty struct for stakingkeeper so in order for ics to work with ibc-go v7 we need to let the pointer to empty struct go throu

@crodriguezvega would this be better if it targeted main?
Also do you happen to see another way around it?
thank you.

@sontrinh16 I am going to make a pr that targets main, I think that the ibc-go team is preparing v8.0.0 right now.  I'll also leave this one open. @crodriguezvega thanks very much for your review.

Thanks for the explanations and the extra context, @sontrinh16 and @faddat. I see in the interchain-security repo that an alternative approach is being followed for the upgrade to SDK 0.47 and ibc-go v7. Does that mean that we could close this PR?

Thanks for the explanations and the extra context, @sontrinh16 and @faddat. I see in the interchain-security repo that an alternative approach is being followed for the upgrade to SDK 0.47 and ibc-go v7. Does that mean that we could close this PR?

yes i think we can closed this one

yes i think we can close this one

Thank you for the quick reply, @sontrinh16!


Check if wazuh ports is open before to install the agent

What?
Check if wazuh ports 1515 and 1514 is open before to installing the agent.
Why?
Those ports are necessary to register and communicate to Wazuh server, so if any is inaccessible the agent doesn't register and reinstalling the agent will be necessary.
How?
Create a ansible target to verify if the ports is open.

@mmsilveira, you have added a new check scenario. In this way you need to check the tests already created in the molecule, and also create a new test for this scenario. As this role is open, we have to guarantee the tests to maintain the quality.

@mmsilveira, you have added a new check scenario. In this way you need to check the tests already created in the molecule, and also create a new test for this scenario. As this role is open, we have to guarantee the tests to maintain the quality.

I have created a new test scenario to check wazuh open ports and changed the other tests to keep working.
@vitor-tyburski and @marcelokkruger Can you check this MR again please?

Perfect man!


UpdateQueryEmitter - trigger via annotation on Event Handler

The code I call in an eventhandler to emit a queryUpdateEvent seems pretty generic. So instead of doing
@EventHandler
fun on(e: SomeEvent) {
     // update the projection

     queryUpdateEmitter.emit(
        SomeQuery::class.java,
        { query ->  query.id == e.id},
        SomeResult(id, projection.getValue(i)))
}

I wonder if it is possible to do
@EventHandler(queryUpdate="#someSpelCodeToFilterAndTriggerTheUpdate")
fun on(e: SomeEvent) {
...

or
@EventHandler
@QueryUpdate(queryType=SomeQuery, resultFactory=SomeResult::new, queryFilter="#spelToFilter")
fun on(e: SomeEvent) {
...

to achieve the same result. Imho this depends on a clever way to link Event, QueryType and ResponseType and some "spel-magic" for the call. BeanPostProcessors are already there.

While it's an interesting idea, the added complexity of adding a SPEL just to be able to declare updates is not worth the limited benefit one would get. The expressiveness of a SPEL is always limited compared to "plain java". Instead, we should consider API improvements (by overloading methods on the UpdateEmitter, for example).

Ok, understood.


[Feature] show all content when sidebar is open

When sidebar is open either push or uncover, application content is translated and it overflow its container,will be nice to have the ability to show all content when sidebar remains open.
Expected Result

Actual Result

Can you create a JSFiddle  to replicate the issue?

in the official documentation
https://semantic-ui.com/modules/sidebar.html#starting-visible
example en jsfiddle
https://jsfiddle.net/p9p911t1/

Just ran into this bug, any chance to get this fixed (or a workaround?)
I really like SemanticUI, but I also need a sidebar that doesn't push the content off the view.

By the way, I think this closely related (or a duplicate) of #6376

Hey guys, is there any update about this ?
I'm using SUIR but I couldn't find any issues about it in SUIR issues, therefore I came here.
Is it fixed for the Semantic UI ?

If we are showing sidebar; we need to push the main container to right, otherwise it will overlap with the sidebar. @hammy2899 Confirm if I'm wrong.
Or do we need to add variation for the sidebar, e.g.

Overlay + Push the content
Just overlay the content

Currently, we have only first variation.


Objects created via PhysicsServer3D/RenderingServer disappear shortly after they are created.

Godot version
v4.2.dev2.mono.official [da81ca62a]
System information
Godot v4.2.dev2.mono - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Laptop GPU (NVIDIA; <IP_ADDRESS>40) - AMD Ryzen 7 5800H with Radeon Graphics (16 Threads)
Issue description
When rigidbodies and meshes are spawned by PhysicsServer3D/RenderingServer, they will disappear shortly thereafter. The higher the object count, the sooner they will be wiped. Expected behavior would be that they do not disappear before they are freed by the user.
Steps to reproduce
// Use this as an autoload script or attach it to Node3D
using Godot;

public partial class Balls : Node3D
{
    int ballCount = 1000;

    Rid[] body;
    Rid[] shape;
    Rid[] instance;
    Rid[] mesh;

    Transform3D transform;

    public override void _EnterTree()
    {
        Camera3D camera = new();
        DirectionalLight3D light = new();

        AddChild(camera);
        AddChild(light);

        camera.GlobalPosition = Vector3.Back * 50;
    }

    public override void _Ready()
    {
        body     = new Rid[ballCount];
        shape    = new Rid[ballCount];
        instance = new Rid[ballCount];
        mesh     = new Rid[ballCount];

        for (int i = 0; i < ballCount; i++)
        {
            transform = new Transform3D(Basis.Identity, Vector3.Up * i);

            body[i]     = PhysicsServer3D.BodyCreate();
            shape[i]    = PhysicsServer3D.SphereShapeCreate();
            instance[i] = RenderingServer.InstanceCreate();
            mesh[i]     = new SphereMesh().GetRid();

            PhysicsServer3D.BodySetSpace(body[i], GetWorld3D().Space);
            PhysicsServer3D.BodyAddShape(body[i], shape[i]);
            PhysicsServer3D.BodySetState(body[i], PhysicsServer3D.BodyState.Transform, transform);

            RenderingServer.InstanceSetScenario(instance[i], GetWorld3D().Scenario);
            RenderingServer.InstanceSetBase(instance[i], mesh[i]);
            RenderingServer.InstanceSetTransform(instance[i], transform);
        }
    }

    public override void _PhysicsProcess(double delta)
    {
        for (int i = 0; i < ballCount; i++)
        {
            transform = (Transform3D)PhysicsServer3D.BodyGetState(body[i], PhysicsServer3D.BodyState.Transform);
            RenderingServer.InstanceSetTransform(instance[i], transform);
        }
    }
}

Minimal reproduction project
N/A

Does this happen only with C#? If not please provide GDScript code
Also please provide an MRP for this issue to make it easier to test, add GDScript code to it if it doesn't just happen in C#

I found the problem, and I think it wasn't a bug after all. I had declared and created the SphereMesh in the _Ready() function, which means that after the _Ready() finishes, the SphereMesh goes out of scope and is garbage collected. It worked fine after I declared the SphereMesh outside of the _Ready() function. I think this is intended behavior in C#.
It also worked when I tried to use RenderingServer.MakeSphereMesh(latitudes, longitudes, radius) instead of new SphereMesh().GetRid(); in _Ready().
But just in case I'm missing something, here is the MRP with both C# and GDScript versions available. Although I'm still pretty sure it was just my mistake and not an actual bug.
MRP.zip


Missing link to download ARM64 macOS binaries for Kong Mesh 1.8.0

Where is the problem?
https://docs.konghq.com/mesh/1.8.x/installation/macos/
What happened?
I went to the page to download ARM64 macOS binaries for my M1-based Mac. Unfortunately, the manual download link only points to the AMD64 binaries, and there is no link for the ARM64 binaries.
What did you expect to happen?
The page should have provided download links for both Intel (AMD64) and Apple Silicon (ARM64) binaries for Kong Mesh.
Code of Conduct and Community Expectations

[X] I agree to follow this project's Code of Conduct
[X] I agree to abide by the Community Expectations

This is the link provided on the download page:
https://download.konghq.com/mesh-alpine/kong-mesh-1.8.0-darwin-amd64.tar.gz
What's needed is to add this link:
https://download.konghq.com/mesh-alpine/kong-mesh-1.8.0-darwin-arm64.tar.gz


Updating vulnerable dependencies according to assessment report : http://localhost:8081/assessments/assessment/66a1095121270677f00d5e3e

Summary Report

Scenario
Upgrades
Critical
High
Medium
Low

Full Upgrade
0
0
0
0
0

Full Upgrade
0
0
0
0
0

Vulnerability Upgrade Report

CVE
Target Dependency
Parent Dependency
Project Dependency
Upgraded Dependency
Remediation Status
Description

x:crypto:v0.23.0
github.com:tektoncd:
github.com:tektoncd:

❌
No available versions available for upgrade.

jackc:pgx:v5.4.3

❌
Unable to find the dependency in dependency tree.


Analytics of deployments

We should start collecting analytics on where/how Heroic is deployed. This would need to be optional and very obvious to users when its enabled so they can easily opt-out. We'll also need to be very careful to only collect anonymous, high-level stats and nothing uniquely identifiable.
As part of this, we'll need somewhere to send the analytics to that's internet-reachable.

We should have a page in the docs detailing exactly what we collect. Homebrew has a great example of this.
I think Google Analytics is a reasonably low-friction place to send the usage reports.


OSSM-3937 Remove the 2.1 SMCP option from the 2.4 SM drop-down in OS UI

@mayleighnmyers You need to run make gen and then commit the changes.


ResourceExhaustedError (out of memory) when training a Saved Model

System information

OS Platform and Distribution: Linux Ubuntu 18.04.4 64-bit
TensorFlow installed from: pip
TensorFlow version: 2.3.0-rc2 and 2.4.0-dev20200727
Python version: 3.7.6
CUDA/cuDNN version: CUDA 10.1, cuDNN <IP_ADDRESS>
GPU model and memory: RTX 2060 Super (8 GB)

Describe the current behavior
When building a model with a pretrained Xception net as base, than saving it in the Saved Model format, loading and running fit(), ResourceExhaustedError (out of memory) occurs.
Describe the expected behavior
When training the model with the same dataset, but without saving or if the Keras H5 format is used, everything is alright, so it looks like there is actually enough GPU memory and the loaded Saved Model should also train without errors. I've also tried replacing Xception with InceptionV3 and this removes the error.
Standalone code to reproduce the issue
https://github.com/OlegPonomaryov/xception-saved-model-bug-demo/blob/master/model.ipynb

@OlegPonomaryov
I am unable to access the link shared for the code, please provide with simple stand alone code for us to replicate the issue or if possible share a colab gist with the error faced.

@Saduf2019
Sorry, I've made the repository private by mistake, please, try the link again, now it works.

@OlegPonomaryov
I ran the code shared and do not face any error as in the repository, please find the gist here

@Saduf2019
Thank you for the response.

I ran the code shared and do not face any error as in the repository, please find the gist here

Were you using GPU or CPU for training? 26s/step when training looks more like a CPU performance, however, I think, a GPU is needed to reproduce this issue. Maybe the issue is even more specific, like occurring only on GPUs with the same memory amount as mine or maybe even of the same series. I understand, that this, unfortunately, makes the issue much harder to reproduce.

Please try limiting GPU memory growth and check if you are still facing the same issue.

Thank you, I've tried setting memory_limit=4096, and there is still this error with the loaded Saved Model, but everything is OK with the other models. This is quiet interesting, because while the other models can work even with 4 GB of GPU memory, the loaded Saved Model throws ResourceExhaustedError even with all 8 GB available.

Below are few issues with same error:
link link1 link2

These and other discussions of similar issues I've stumbled upon suggest to reduce either a model or an input size. However, in my case exactly the same models work well with exactly the same input data, but only the loaded Saved Model causes OOM. This makes me think, that there might be some bug with memory allocation specific for the loaded Saved Model.

Hi @OlegPonomaryov, I have tried the code you shared in colab on the GPU runtime, and I'm not seeing an issue (to reproduce this, you can use the gist provided by @Saduf2019 but change the runtime type to GPU). I've also run this in GCP with a K80 and still do not see the error.
Strangely the error message in your notebook seems to be referencing TF1 report_tensor_allocations_upon_oom. But that being said did you try and follow what was suggested in the error message?
As a first experiment, since you have the saved model, can you try (in a new notebook environment) just loading the model and training? Do you still see the error in that case?

Hi @nikitamaia, sorry for late reply. Thank you for hints, I've tried just loading the Saved Model  and have encountered the same error. When loading just Keras H5 model, everything is still alright.
As for report_tensor_allocations_upon_oom, I haven't found a way to set RunOptions for tf.keras models. However, I've tried profiling memory usage with Tensorboard (using tensorboard-plugin-profile).
Here is a branch, that contains the notebook modified to just load the Saved Model and to collect Tensorboard logs when running fit() (logs are also there).
Here is a similar branch but with the Keras H5 model.
Unfortunately, sharing the profile plugin logs through tensorboard.dev currently is not supported, so I guess the only way to view them is to download them and open in your local instance of Tensorboard. Alternatively, here are screenshots of memory profiling tabs both for the Saved Model and Keras H5 model.
I notice differences in Peak Heap Usage and Peak Memory Usage, but I don't see any operations in the Memory Breakdown Table that consume too much memory. However, I have zero experience with Tensorboard profiling, so might just be missing some obvious things.

Thanks for sharing these screenshots. I also ran some experiments using the colab GPU runtime, which is a T4 with ~15GB. I ran for 3 epochs and noticed the peak memory usage for the H5 model was about the same as what you saw (~3.6GB) but close to 10GB for the savedmodel, which probably explains why you're getting the resource exhausted error on an 8GB device.
Can you run some similar experiments for InceptionV3 since you said that worked for you? I'm curious what the difference will be between H5 and savedmodel peak memory usage, since the almost 3x difference for Xception does seem awfully high.

@nikitamaia So I've tested this with 3 other models (including InceptionV3). In all 3 cases there was no OOM error, so Tensorboard was able to log peak memory usage through all training process. Here are the results:
InceptionV3
Saved Model
Peak Heap Usage 5.13 GiBs
Peak Memory Usage 5.13 GiBs
Keras H5
Peak Heap Usage 2.63 GiBs
Peak Memory Usage 2.63 GiBs
MobileNetV2
Saved Model
Peak Heap Usage 4.41 GiBs
Peak Memory Usage 4.41 GiBs
Keras H5
Peak Heap Usage 2.11 GiBs
Peak Memory Usage 2.11 GiBs
ResNet50V2
Saved Model
Peak Heap Usage 6.62 GiBs
Peak Memory Usage 6.62 GiBs
Keras H5
Peak Heap Usage 3.62 GiBs
Peak Memory Usage 3.62 GiBs
In all experiments a model loaded from tjhe Keras H5 used approximately 2 times less GPU memory than a model loaded from the Saved Model. So it looks like a performance issue with the Saved Model in general rather then with the Xception model (of course if there is no mistake in my code that I've missed).

A little bit more experiments.
I've tried replacing .fit(dataset, epochs=1) with .predict(dataset)
in both notebooks.
Everything runs OK, Peak Heap Usage and Peak Memory Usage are 3.62 GiBs for the Saved Model and 3.63 GiBs for the Keras H5. So the problem seemd to be specifically with the predict() method.
I've tried replacing
with tf.profiler.experimental.Profile(SAVED_MODEL_PROFILING_LOG):
saved_model.fit(dataset, epochs=1)
with
saved_model_copy = tf.keras.models.Sequential(saved_model.layers)
saved_model_copy.compile(loss="categorical_crossentropy")
with tf.profiler.experimental.Profile(SAVED_MODEL_PROFILING_LOG):
saved_model_copy.fit(dataset, epochs=1)
Everything runs OK, Peak Heap Usage and Peak Memory Usage are 3.62 GiBs

A little bit more experiments. I\ve tried replacing .fit(dataset, epochs=1) with .predict(dataset) in both "Saved Model only" and "Keras H5 only" notebooks. Everything runs OK, Peak Heap Usage and Peak Memory Usage are 3.62 GiBs for the Saved Model and 3.63 GiBs for the Keras H5. So the problem seems to be specifically with the fit() method.
I've also tried to make a "copy" of the loaded Saved Model by replacing
with tf.profiler.experimental.Profile(SAVED_MODEL_PROFILING_LOG):
    saved_model.fit(dataset, epochs=1)

with
saved_model_copy = tf.keras.models.Sequential(saved_model.layers)
saved_model_copy.compile(loss="categorical_crossentropy")
with tf.profiler.experimental.Profile(SAVED_MODEL_PROFILING_LOG):
    saved_model_copy.fit(dataset, epochs=1)

in the "Saved Model only" notebook.
I've actually done it already in the initial notebook, just wanted to check memory usage with Tensorboard. Everything also runs OK, Peak Heap Usage and Peak Memory Usage are 3.62 GiBs.

And another update, I've also tried the VGG16 and here are the results:
Saved Model
Peak Heap Usage: 0.20 GiBs
Peak Memory Usage: 5.83 GiBs
Keras H5
Peak Heap Usage: 5.22 GiBs
Peak Memory Usage: 5.22 GiBs
So in contrast to other models, in this case Peak Memory Usage of the Saved Model is just a little bit higher compared to the Keras H5. The Saved Model also has an oddly low  Peak Heap Usage, but this happens sometimes, I think it's caused by some Tensorboard behavior rather than by the model itself.

I have tried to limit the GPU memory to 4096 and run the Xception model and I did not get any ResourceExhaustedErrror please find the Tensorflow 2.7 gist here. Thanks!


Issues with some pools and ids across boundries

Hello,
I'm developing a simple game engine with a visual editor using Entt as it's ecs. The idea is to have the user create and register custom components and systems in a separate project, compile it as dll and then dynamically load it in the editor so that the user can add custom components to the entities and test the systems.
I've already read "Push EnTT across boundaries" and implemented the systems to share the meta context and id creation between main code and dll (the last one taken directly from the test suite "registry_plugin") but I've come across some issues.
I've noticed that the custom type_seq generator doesn't get called for two types of components, IdComponent and NameComponent, causing a conflict when I try to add another one(for example, every time a new entity gets created I add an IdComponent, NameComponent and TransformComponent, causing a conflict because the first two call the default generator getting ids 0 and 1 and the last one calls the custom generator getting id 0). At first I fixed it with a quick hack, adding +2 to every id created by the custom generator, but then I noticed a bigger problem.
Essentially, everything is fine from the editor side, but when I try to get IdComponents or NameComponents from the dll (for example with a view) it acts as if the respective pools are empty.
I've tried to understand what's going on, but I wasn't able to come up with anything.

Any updates? Have you tried the dll branch?

Hi,
sorry for the lack of feedback, I've been pretty busy this week.
I've tried the dll branch and it worked flawlessly out of the box just as you sad.

No worries at all. I was just curious to know if it worked since I'm about to merge it with master. Thanks for the feedback!


swift

Swift is pretty tightly coupled to Mac os x. It is possible to download older versions of XCode, and XCode command line utilities, but these are incredibly large files.


Fix flaky test testParamsByNameUnmatchedMessage

PR Overview
The PR proposes a fix for the following tests -
net.ttddyy.dsproxy.asserts.hamcrest.ParameterHolderAssertionsTest#testParamsByNameUnmatchedMessage

Build Project

To build the project :

mvn clean install

To run the test :

mvn -pl . test

To run the nondex tool on this test :

mvn -pl .  edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=<path.to.test#testName>

Problem
This flakiness was identified by the nondex tool created by the researchers of UIUC. The above eight tests fail when run on the nondex tool.
This test uses a map with keys foo and bar and is being asserted that the order must be with keys bar and foo. Simply changing the order of insertion of the map values will not solve this since the map still does not maintain order of insertion and there are possibilities this can fail again in the same way
https://github.com/ttddyy/datasource-assert/blob/2cf1ad31948e4e18b60483b67417ab68e61ffc10/src/test/java/net/ttddyy/dsproxy/asserts/hamcrest/ParameterHolderAssertionsTest.java#L113-L126
Fix:
The proposed fix is to use a LinkedHashMap instead of a map since it will maintain the order of insertion

LGTM. I believe if there's no module, passing -pl . is unnecessary.