Data Flash values after erase is "undefined" - Would LittleFS work?

I would like to know if LittleFS is designed based on the assumption that, the values of flash after erase, are '0xFF'?
I am using a family of Renesas family MCU where the values of data flash after erase is 'undefined'
Would LittleFS work on this type of MCU?

LittleFS doesn't assume 0xFF actually, so it should work.
To be exact, LittleFS requires only that subsequent reads after an erase returns the same value, or consistently returns LFS_ERR_CORRUPT.
Usually when flash devices say the value after an erase is undefined, it's because they include some extra error-correction that becomes invalid after an erase. But as long as it consistently reports invalid, we can use that to detect if the block has been erased.
But I would also double check the datasheet to see if they define "undefined". In theory a new storage type could put the storage into a truly unstable state on erase, but if that's the case I'm not sure it's even theoretically possible to log when power-loss is involved...
Worst case, erased-state in LittleFS is checked with a checksum before use, so if the erased-state is truly unstable it just means LittleFS will erase much more often. Though depending on the underlying storage this could be impractically slow.


Typhon Storyteller

Description
In testing this mod, especially with a lot of mods active, typhon are rather rare. Since the mimic event currently only adds one mimic, if that mimic dies, well, it'll be a while before the next one. It'd be helpful to have a storyteller that can ensure mimics are on the map. To make gameplay interesting, an empathy stat should be tracked for other events.
Empathy
Thanks to a discussion somewhere over here
arendjvr2000

Probably something with the storyteller developing empathy. Could make a unique mechanic

4Jan

imagine a storyteller that awards empathy, so doing charity stuff, not doing warcrimes etc lmaoo
I'd say the benefits of being non empathetic should be the loot of frequent raids/raid events like enemy reinforcements. Whilst being empathetic increases good events like factions giving gifts with high quality or even higher likelyhood of them helping out during events.
Also it would be a good chance to play with the faction relation decay and how being unempatheic would increase how much goodwill is lost while empathetic would decrease how much is lost

Implementation

Empathy should be a custom stat that's tracked and shown in the history log graph.

Could bug UdderlyEvelyn to see how RebeccaRealistic adds the "Considered Wealth" to that.

Should be pushed up or down by in-game actions.
Ruthlessly killing pawns? It goes down!
Gave money to the beggars? It goes up!

Art Needed
Will need a large portrait art for the storyteller, as well as a small cropped one for the list view.

Concept

🔜


Write mongodb migration script

I have added few new indexes https://github.com/Rulexec/shieldy/blob/b8672b545ea28df062497234b97b59878c5bcb5c/src/database/mongo/database.ts#L88
But not cannot run bot in production, since database has duplicates that violate this indexes.
I need to write script that will fix database before update.

Done, actually https://github.com/Rulexec/shieldy/blob/8c1c19b663639f92839d5783abeb92b35cfac581/src/database/mongo/migrations/ver-1.ts


jobs/list limit to match api documentation [FEATURE]

Description
Unless I'm misunderstanding, I believe the limit for WorkspaceClient().jobs.list(limit=x) should be 100, according to the cli documentation. Right now, I'm getting an error that the limit can be no more than 25.
Reproduction
from databricks.sdk import WorkspaceClient
w = WorkspaceClient(host='', token='')
for job in w.jobs.list(limit=99):
print(job)
Expected behavior
This should print out the job objects. Currently it only works for 25 items or less.
Proposed Solution
Increase limit of the number of objects returned
Additional Context
Add any other context, references or screenshots about the feature request here.

I believe this limit is in the process of being updated. Let me confirm with the Jobs team.

@benjaminhuus32 do you happen to have a specific error message?


Add WebTransport support

It would be useful to support WebTransport now that it is getting released in Chrome 97.
After looking into it, some additional work seems to be required to enable this support.
The Session Establishment section of the draft defines some required settings for the settings frame. I've been experimenting a bit but I'm still stuck with a net::ERR_METHOD_NOT_SUPPORTED and an unsuccessful handshake.
I'm not sure if after achieving a successful handshake there will be additional work required to support this protocol.
I'm using aioquic as a reference, since that is the library that Chrome is using to support their example WebTransport server.
It looks like Neqo has also added WebTransport support.

Hi @Pascualex,
I wanted to come up with an exhaustive list of what's missing in this crate to support WebTransport. But with the holidays I actually don't have much time for this. So here are some points I found, which will make the WebTransport implementation a non-trivial work:

Custom Settings, namely for SETTINGS_ENABLE_WEBTRANSPORT.
CONNECT method has to be implemented.
Bidirectionnal stream from server
Custom stream types
Custom frame types
Custom Error codes
HTTP Datagrams

Neqo seems to implement directly web-transport into their http3 crate, but as h3 goal is to be highly reusable for a variety of use cases, we might want to implement some of these features in a separate crate and offer an extensibility methods within h3. (I assume the main goal of Neqo is to offer the http3 in Firefox only).
We could also implement WebTransport with feature-gated code within h3. But the extensibility seems a rather future-proof approach for other public or vendor protocol extensions.
Nevertheless, I think we'll concentrate on this starting at v0.2 the soonest. If your keen to help us you are more than welcome! :)

Hi @stammw,
Thanks for looking into it. I agree that this should not be part of the core of H3 and that it makes sense to delay this until the core is released.
To be honest with you what I know of these protocols is mostly from a user perspective, but if there is something I can help with I'll gladly do it.

Hi @Pascualex,
I wanted to come up with an exhaustive list of what's missing in this crate to support WebTransport. But with the holidays I actually don't have much time for this. So here are some points I found, which will make the WebTransport implementation a non-trivial work:

Custom Settings, namely for SETTINGS_ENABLE_WEBTRANSPORT.
CONNECT method has to be implemented.
Bidirectionnal stream from server
Custom stream types
Custom frame types
Custom Error codes
HTTP Datagrams

Neqo seems to implement directly web-transport into their http3 crate, but as h3 goal is to be highly reusable for a variety of use cases, we might want to implement some of these features in a separate crate and offer an extensibility methods within h3. (I assume the main goal of Neqo is to offer the http3 in Firefox only).
We could also implement WebTransport with feature-gated code within h3. But the extensibility seems a rather future-proof approach for other public or vendor protocol extensions.
Nevertheless, I think we'll concentrate on this starting at v0.2 the soonest. If your keen to help us you are more than welcome! :)

Hi,
Any update about these features?

Hi friends:
I will take on the job of building a POC.
I already added webtransport support to web apps written in rust via wasm-bindgen: https://github.com/rustwasm/wasm-bindgen/pull/3344
Reddit demanded it: https://www.reddit.com/r/rust/comments/11rfes0/comment/jc8kyax/?utm_source=share&utm_medium=web2x&context=3

I am happy to inform that we have a working prototype, I estimate that it will take us 1 week to polish it.
https://user-images.githubusercontent.com/1176339/229327157-2f785f85-1fc3-4d7a-ad68-36a6054f5b7d.mov

It is an exciting feature, I can see why you'd want to use it. But, please don't ask in a status-tracking issue for status updates. We keep the issue updated with the latest already, and asking can cause stress on contributors as if they somehow aren't working fast enough in their volunteer time.

It has been 2 weeks, what is the progress

Hey @aMySour thanks for caring!
If you checkout the PR and run the sample webtransport echo server, you should be able to see the datagrams API at work, @ten3roberts and I are trying to get this done for the community as fast as possible and also trying to build something clean enough so that we do not create a bunch of tech debt.
The main challenge is that h3 is designed to abstract the quic connection as much as possible, and webtransport works by interacting directly with it.
I am confident that we will have good news soon!!

Well put.
What we have:

Session negotiation
Single Session establishing through connect
Incoming uni streams
Incoming bi streams (send/recv)
Reading datagrams
Sending datagrams
Buffer according to spec

The implementation has low overhead as it essential targets the quic streams almost directly.
For example, when a bistream is received it can be either an HTTP request, or a special frame indicating it is a Webtransport stream.
This "frame" has no length, so when it is received the framed decoder (which is still needed in case it is a "normal" frame stream) is unwrapped, and the rest of the data is read streaming.
The difficulties have been in adapting the internal traits to work with this low level use, as well as changing the direct plumbing now when more types can be received.

Feedback welcome in this discussion about where the code should live: https://github.com/hyperium/h3/discussions/189


Add custom support for custom login pages

Would be nice to have a login page separate from auth0 and cognito to make styling easier and being in control of the cookies.

This will be handled in another repo


Fix install/uninstall output table

Current output

There is no issue. I was calling "wrong" the iasql method, doing SELECT iasql_install('aws_acm_import'); instead of SELECT * FROM iasql_install('aws_acm_import');


Update documentation or KB article "GitHub Repository Best Practices"

Description
Write up  "Best Practices" documentation regarding managing GitHub repositories for cloud.gov Pages users to follow/reference. Identify standards regarding security and repo management.
Acceptance Criteria

[x] Put together a rough draft
[x] Submit for team review
[ ] Make any revisions if necessary
[ ] upload to cg-site as either documentation or stand alone article
[ ] Discuss if this could be incorporated as onboarding material

Doc WIP

PR https://github.com/cloud-gov/cg-site/pull/2493


Refactoring Smoke Tests

Description
Document Smoke Tests
Goals
Currently, there is no good way to manage smoke tests. They are all added to the same file. The project should define all smoke tests in separate files for every extension. Update GHA to include the merging of all of these files and then running the CI for smoke test.

Project
WarpSQL
Organization Name:
Samagra | Transforming Governance
Mentor(s)
@ChakshuGautam
Tech Skills Needed
GitHub Action Scripts, Yaml
Complexity
Low
Category
CI/CD
Sub Category
API
Domain
Education

@ChakshuGautam , I would like to contribute this , please assign me this.


Document 2D rotation

This is an easy warm-up before tackling the 3D rotations.

Closed because subsumed by #58


Fix the packages to a version we know works forever until we need to update.

As the title says...

pytorch_lightning has removed the support to _TORCH_GREATER_EQUAL_2_0, see this pull request. This raised a issue in HyPER.onnx. @diegobaronm suggests updating environment file with fixed version, preventing similar issues from happening.


icon attribute position is incorrect on non bordered auro-input

Describe the bug

Icon type icons appearing on the left of the input have incorrect positioning on non-bordered auro-inputs.
To Reproduce
Steps to reproduce the behavior:

Go to https://auro.alaskaair.com/components/auro/input
Scroll down to second Credit Card example
See error

Expected behavior

Positioning of icon should be even with the input text.
Screenshots

Error:

Expected:

@leeejune please provide @jordanjones243 design instructions as to the placement of the icon for the non-bordered input with no value.

@leeejune please reassign this issue back to @jordanjones243 once completed with the design work.

This ticket is not actively being worked on. Fixing the position is an easy fix, but was coupled in a repo that also had the goal of fixing the sizing of label and input text under all input scenarios. After further discussion, we decided we were going to head towards a re-design of auro-input and to put these fixes on hold for the time being.

Adding the BLOCKED label as this work will be predicated on decisions made with the following issue

https://github.com/AlaskaAirlines/auro-input/issues/205

Seeing that this issue is blocked and knowing what is live in production, I am wondering if we can make a simple change that would remove any weird issues.
What if we just made the spacing above the label consistent with the bordered version? @leeejune

@blackfalcon If we were to make that change, what would happen to the input text that appears once the user clicks into the input field? Also, the right spacing of the icon in the screenshot seems to be off–don't know if that's just temporary.

There was work done in the past that normalized much of the input layout. As a result, the icon is now floating. See the screen shot from Auro below.

The fix I am requesting is what is shown in the screen shot in the previous comment. The request does not move the icon, but locates the label to the same place as with the bordered version and the animation works the same way.

I understand, but I meant what it would look like if it is filled as shown in the screenshot. I will explore spacing options and reply again.

@june is reaching out to the rest of the design team for feedback on a proposed direction.

Designers confirmed of the change in padding. What are the next steps @blackfalcon?

Current screenshot from localhost of this branch.


Python client for OrientDB 3.x

pyorient does not work with OrientDB 3.x
Are there plans to either update pyorient to support version 3.x or release another python client that supports version 3.x?

Hi @Froskekongen.  I've published several suggested work arounds in the Pyorient issues and have asked the author to update the driver to make it work with OrientDB 3.x.
I'll likely just update the code myself this week so you can use the Pyorient driver.

@OrientDBColin: That's great! Is there a place to follow progress on this?

I second this request!

@OrientDBColin
Hi.
Any update on this?

Hi @OrientDBColin, I was just wondering if there is update on this?
I'm looking to port a project to OrientDB and this is the only blocker.

I suggest you guys to try out Orient DB REST. It's the simplest way when
you scale to distributed DB when you have millions of nodes you don't have
to change any line of your backend code
On Wed, Dec 5, 2018, 4:31 AM Ben T<EMAIL_ADDRESS>wrote:

Hi @OrientDBColin https://github.com/OrientDBColin, I was just
wondering if there is update on this?
I'm looking to port a project to OrientDB and this is the only blocker.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/orientechnologies/orientdb/issues/8470#issuecomment-444292635,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABOgiGRZcpfOr6KSfdwiF2CYsEbpRATWks5u1v65gaJpZM4V_tPh
.

Do you mean writing a REST-based interface, or is there another library I've missed with my Google-fu? My backup plan is to use requests or similar, but figured that someone had wrapped REST into Python already. The code I have to move is Python-based already, so that's non-negotiable.

Ah, I get what you mean. I was just hoping someone had wrapped the commands I need into an API. I guess I was hoping someone had done the lifting for me.

I had created a custom OGM in my Django project for Orient DB REST L.
I can give you tips to build one.
Create empty python classes named Node and Relationship. Extend your model
classes from there. (You don't have to specify the data type while creating
the models. Just use var)
Now write a separate code to create the vertices and edges using the sub
classes of Node and Relationship. You just have to use the class name here.
You don't need the properties at this point. This will migrate your DB.
Similarly for building queries, you can create helper functions which
returns the request json, from the class and a dictionary as parameters.
Here you can make use of the properties in a class and the dictionary to
create the json.
On Thu, Dec 6, 2018, 2:36 PM Ben T<EMAIL_ADDRESS>wrote:

Ah, I get what you mean. I was just hoping someone had wrapped the
commands I need into an API. I guess I was hoping someone had done the
lifting for me.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/orientechnologies/orientdb/issues/8470#issuecomment-444800163,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABOgiK6fNKn8lTFeyDD1H5AnVtVQhIPeks5u2N4jgaJpZM4V_tPh
.

Build pyorient from source they had made some configuration file changes. Due to this you will able to connect python and orientdb successfully.


HIVE-28591: Fix partition column names evaluation in Vectorizer#validateInputFormatAndSchemaEvolution

What changes were proposed in this pull request?

Bug-Fix
Why are the changes needed?

Disabled vectorization:
enabledConditionsNotMet: Could not enable vectorization due to partition column names size 1 is greater than the number of table column names size 0 IS false
Does this PR introduce any user-facing change?

No
Is the change a dependency upgrade?

No
How was this patch tested?

qtests

LGTM


Cant Share  attachments between 40-49 mb - reported by @Tushu17

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to chat
Select Actions -> Add attachment
Add an around 45 mb video/file (file in tread)

Expected Result:
Attachment should be sent as it's under 50mb limit
Actual Result:
Attachment kept loading until you refresh the page, attachment disappears after refreshing.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.43-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/159107214-02f94865-2271-4e74-953e-4740843171d3.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644521208448039
View all open jobs on GitHub

Well... that is a weird one, nice catch @Tushu17
I was able to reproduce, got this is logs

The pdf file @Tushu17 was using is here in slack
If/when we fix this, it'd be great to know why it's happening and to make sure we fix it for all file sizes.

Marking this issue as internal, because the logs show that there's a size issue on backend:
2022-03-22T20:13:58.941746+00:00 expensidev2004 php-fpm: QHP2Bx /api.php<EMAIL_ADDRESS>!ecash! ?report? [info] Benchmark started:PDFBoxAPI - SPost2
2022-03-22T20:13:58.952725+00:00 expensidev2004 nginx: 2022/03/22 20:13:58 [error] 164010#164010: *2365 client intended to send too large body: 66021374 bytes, client: <IP_ADDRESS>, server: pdfs.expensify.com.dev, request: "POST /api.php HTTP/1.0", host: "pdfs.expensify.com.dev"

I'm going to send this issue to the pool, I have my plate full atm. But I think we should check why the file size increases in the backend to 66 mb when the original attachment size is 46 mb.

Posted in #engineering here to see if we can find a volunteer.

But I think we should check why the file size increases in the backend to 66 mb when the original attachment size is 46 mb.

Ah man this has been an issue for a while - IIRC if you copied and pasted the image it would increase in size.  When we send an image to the PDF box we try to generate a thumbnail and convert it into a PDF so that could also be the case.
An easy workaround could be to increase the allowed file size in php.ini https://github.com/Expensify/Web-Expensify/blob/5f23cbb798713a7689c8ca55f2db87aa02178ae4/lib/ReportUtils.php#L289-L293.  https://github.com/Expensify/Web-Expensify/blob/5f23cbb798713a7689c8ca55f2db87aa02178ae4/_tools/ci/php.ini#L133-L135

Related - https://github.com/Expensify/App/issues/4356

Re-applying the Engineering label to trigger re-assignment. @Justicea83 if you don't have time to take this, feel free to un-assign like normal btw. I was just seeing if this approach may find someone who's interested

After more thought, this is technically a regression I think (it worked in the past, and then stopped working) -- and thus, it deserves an RCA.

Posted in #contributor-plus looking for a volunteer to run a git bisect, and maybe discover the offending PR.

cc @kidroca is going to help out here!

Yep, I'll investigate and report here

This seems to be a backend issue, there's no PR on App that caused a regressions
When we upload an attachment of 44.2MB we get the following error from the backend:
Resonse:
{
  "code": 666,
  "jsonCode": 402,
  "type": "Expensify\\Libs\\Error\\ExpError",
  "UUID": "73A165DF-42F6-4F7C-8D83-8F3C16E1F87D",
  "message": "No content to add",
  "title": "Empty comment",
  "data": [],
  "htmlMessage": "",
  "requestID": "70a5539d290f8ef2-SJC"
}

Request:
fetch("https://www.expensify.com/api?command=Report_AddComment", {
  "headers": {
    "accept": "*/*",
    "accept-language": "en-US,en;q=0.9,bg;q=0.8,es;q=0.7",
    "content-type": "multipart/form-data; boundary=----WebKitFormBoundaryL2OgtVBMCAESAP6t",
    "sec-ch-ua": "\" Not A;Brand\";v=\"99\", \"Chromium\";v=\"101\", \"Google Chrome\";v=\"101\"",
    "sec-ch-ua-mobile": "?0",
    "sec-ch-ua-platform": "\"Windows\"",
    "sec-fetch-dest": "empty",
    "sec-fetch-mode": "cors",
    "sec-fetch-site": "same-site"
  },
  "referrer": "https://new.expensify.com/",
  "referrerPolicy": "origin-when-cross-origin",
  "body": "------WebKitFormBoundaryL2OgtVBMCAESAP6t\r\nContent-Disposition: form-data; name=\"reportID\"\r\n\r\n71955477\r\n------WebKitFormBoundaryL2OgtVBMCAESAP6t\r\nContent-Disposition: form-data; name=\"file\"; filename=\"Random.pdf\"\r\nContent-Type: application/pdf\r\n\r\n\r\n------WebKitFormBoundaryL2OgtVBMCAESAP6t\r\nContent-Disposition: form-data; name=\"reportComment\"\r\n\r\n\r\n------WebKitFormBoundaryL2OgtVBMCAESAP6t\r\nContent-Disposition: form-data; name=\"clientID\"\r\n\r\n1652381284753850\r\n------WebKitFormBoundaryL2OgtVBMCAESAP6t\r\nContent-Disposition: form-data; name=\"persist\"\r\n\r\ntrue\r\n------WebKitFormBoundaryL2OgtVBMCAESAP6t\r\nContent-Disposition: form-data; name=\"shouldRetry\"\r\n\r\ntrue\r\n------WebKitFormBoundaryL2OgtVBMCAESAP6t\r\nContent-Disposition: form-data; name=\"canCancel\"\r\n\r\ntrue\r\n------WebKitFormBoundaryL2OgtVBMCAESAP6t\r\nContent-Disposition: form-data; name=\"appversion\"\r\n\r\n1.1.56-0\r\n------WebKitFormBoundaryL2OgtVBMCAESAP6t\r\nContent-Disposition: form-data; name=\"authToken\"\r\n\r\n1E349C0FEFDF6C4C91482C9B6840427E034357E0D9C4D93EC8AE8472532D67EF8EA84CD9C80D4AC19EAB14598338F45A3024CD65E54D325510B4F95E5174ABFD58BC86274D1DF0EA10A3046DCC430611D878D02FC291D62B6F226A367FDA1FA68749D6A22B6E57607690479BC44829B02AA85DA77FF9D291F27E57E9193F114E79E7B2A71D76FCE12CA780028B8E64F0967F5596EA44902853A862B634F75DA84810314FDF805CE0CE8BA7AE8E9F9F73CCAD50CDDC329DD394DBCCE7D324529AD0A03D5120CD62FDC4A92228288EBA88A65681DB1E69AB66AB784CEA6A1837A46CF75832FE061498BBC322123A265E87DC4BF8F1E59BF83DA99018B4792D9489242990E84F22A7182BEED6772914E78AD2540E429E2454A7E8EC35679435B6ADA873BF74EE85E9B165F9CD969A5EE3D6F287BA9B6AD643BB2CAB7DE7ED4CA989A6266E0B28577974D06FD237CE722611\r\n------WebKitFormBoundaryL2OgtVBMCAESAP6t\r\nContent-Disposition: form-data; name=\"referer\"\r\n\r\necash\r\n------WebKitFormBoundaryL2OgtVBMCAESAP6t\r\nContent-Disposition: form-data; name=\"api_setCookie\"\r\n\r\nfalse\r\n------WebKitFormBoundaryL2OgtVBMCAESAP6t\r\nContent-Disposition: form-data<EMAIL_ADDRESS>  "method": "POST",
  "mode": "cors",
  "credentials": "omit"
});

The following error is printed in App:
Report.js:594 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'sequenceNumber')
    at NS (Report.js:594:47)
    at Report.js:1188:13

Because the response does not include a report action, and we assume it has:
https://github.com/Expensify/App/blob/a2f8cf96d095ded70a15d04ee69bd37be2638c14/src/libs/actions/Report.js#L1190

This seems to be a backend issue, there's no PR on App that caused a regressions

Thank you, that's great to confirm.

@kidroca do you want to fix it?

Ohhh thanks for the input @thienlnam, that's super helpful.

Feel free to log your time for working on this as you typically do!

@thienlnam

@kidroca Did you use the PDF attachment from here? #8235 (comment). Just want to double check to recreate the issue

Yes, I used the same attachment and web

Looks like this is an issue with our PDF Box
[OOPS!] API Threw: PDFBoxAPI::uploadReceipt failed, unknown error ExpException - c0e4174b41f1d1c5dfb38c7d40bd4823 ~~ exceptionMessage: 'PDFBoxAPI::uploadReceipt failed, unknown error' exceptionFile: '/vagrant/Web-Expensify/lib/ReceiptAPI.php' exceptionLine: '251' exceptionCode: '0'

It's not throwing due to size so it doesn't seem to necessarily be do to the size limitation, will have to look into it more

Just back from OOO, added a PR for better logging

<3
On Thu, May 26, 2022 at 2:54 PM Jack Nam @.***> wrote:

Just back from OOO, added a PR for better logging
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/8235#issuecomment-1138905735,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADEYK4EFLJPTNS6KVJMBLHTVL7CFRANCNFSM5RDPS5JA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Michael Haxhiu

Haven't been able to work on this much, busy with the api refactors

Overdue but I think we still want to do this.

Un-assigning @thienlnam so this goes back to the pool. With puneet's latest proposal, this is a good one to assign to an engineer for bugzero

FYI this is on my radar as part of Image-related feature request and improvements

held on #10894

@michaelhaxhiu Snaggin' from you cuz I got the tracking issue assigned to me
[Tracking] [Polish] Image-related feature request and improvements #10894

Taking this off hold per https://github.com/Expensify/App/issues/10894#issuecomment-1297788096
It's Internal gonna see if any snags soon then promote if not.

Thanks @mallenexpensify - ya I can pick it up in a bit if nobody else has, but hopefully we get some help :D

Gonna sent to Demo team since reproducible steps in the OP are clear.  I just tested on desktop (v1.2.22-3) and the bug persists . The file to use is in the Slack thread here

@mountiny For the new BZ process, we're planning to send a lot more issues with reproducible steps to the demo team.  Let me know if there's any additional details you'd like for these types of issues. Or.. any other feedback for when we do

@Beamanator any special tips for this one? why is it specifically just that range of filesize 😄 ?

Hi @mountiny, I think this https://github.com/Expensify/App/issues/8235#issuecomment-1087941503 can be the cause, but not sure if the size should be updated in Web-E. Probably we'd need to update something in nginx?

The maximum allowed file size (post_max_size) on the web server is 25MB: https://github.com/Expensify/Salt/blob/837bd4503f510aeeb001cd60057938cdb72cbc0c/shared_pkgs/php/files/php8_ini_files/cgi/www.php.ini#L127
I would be surprised if we can upload any file larger than that. We have to set a limit, I don't think we want someone to upload a 4TB file...? What should the limit be? How do we decide about that? Let's not update the limit to 50MB only to file a new "bug" next week that we can't upload a 55MB file...

Thank you!
I agree with the limit. I think we should make sure a user friendly error is shown to the user if they got over the limit then, this should be handled optimistically in the NewDot in my opinion as we would not change the limits frequently so it would be fine having them defined in servers AND in the App.
I think 25MB is a reasonable limit. Going forward we might want to reconsider how we would support larger files, especially I can imagine videos for DMs or some zipped files as is a usecase in Slack.

IMO,

I think we should make sure a user friendly error is shown to the user if they got over the limit then, this should be handled optimistically in the NewDot in my opinion as we would not change the limits frequently so it would be fine having them defined in servers AND in the App.

This is the bug to fix (if it exists)

If we want to mimic Slack, their limit is 1GB btw.

, and this is a feature request (not part of this issue, nor a bug)

I have just tried to send you, Flo, a 40MB file and I am stuck with Uploading attachment.... Given we know there is a hard limit of 25MB in the server, we should check for the size of attachment in NewDot before processing it. I assume the size of the POST might be slightly larger than of the file so we might have to check for something like 24.9MB in App to make sure we don't post something successfully in front-end which fails in the back end.
If this sounds good, I believe nothing stops this issue to be External.

Proposal
We can decrease MAX_SIZE to 26214400
https://github.com/Expensify/App/blob/7ffe2c009fcfb347fe4988ca4e07e38ef707d4ed/src/CONST.js#L16-L19
We also need to change error message to Attachment size is larger than 25 MB limit.
https://github.com/Expensify/App/blob/3cd723233aeeb4826226e7ea883def1d9cf09abe/src/languages/en.js#L122

@Tushu17 I like your proposal, we just need to update that value. Can you please raise a PR and test all platforms, especially native mobile?

assume the size of the POST might be slightly larger than of the file so we might have to check for something like 24.9MB in App to make sure we don't post something successfully in front-end which fails in the back end.

Yeah but I would go with 24MB to be on the safe side.

Yeah but I would go with 24MB to be on the safe side.

I agree cc @Tushu17

Yeah but I would go with 24MB to be on the safe side.

@mountiny Okay, I'll set MAX_SIZE to 25165824 and error msg to Attachment size is larger than 24 MB limit.

@Tushu17 yes please 🙇

This one is due for payment tomorrow. I'm stepping into this issue late for Matt. @mountiny @Santhosh-Sellavel @Tushu17 can you help with sharing any insight on these two items of the checklist?

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

Am I right in thinking the title of this issue is outdated based on where we landed here? We didn't increase the file size limit to 40-49mb, but rather we decreased it to 24MB because the maximum file size the server allows is 25 MB?
In terms of where the bug came from then, was it this PR that set the limit to 50 MB incorrectly instead of <25 MB?
I wonder if a code comment would be helpful here to prevent that from happening again? I.e
// 25 MB is the maximum the server allows so we don't exceed that file size limit

@trjExpensify That is correct, it must have been this PR https://github.com/Expensify/App/pull/10118/files.
It is hard to check though since this limit is set on servers not even in API so that is why this was missed.
I agree a comment would be handy but also I think anyone who wants to raise the limit should be wondering why the limit is set to what it it.

As in, that explains why it was likely done incorrectly, but nevertheless it's the "offending" PR?

It is technically, yes.

That is correct, it must have been this PR #10118 (files).

Hm? This PR did not introduce the 50MB...

:ohnothing:

This is the PR which introduced it https://github.com/Expensify/App/pull/4269/files, back in bronze age I believe, judging based off the number of annual rings.

Cool, taken care of all the items on the checklist including paying everyone out. Discussion posted here. Will reopen if something comes of that. Thanks everyone! 🎉

@Santhosh-Sellavel reminded me that this PR was raised after Nov 4th and was merged on Nov 7th, so we owe @Tushu17 & @Santhosh-Sellavel a $125 bonus each. Offers have been sent here: https://www.upwork.com/jobs/~010f6b384191b40d0c

Nice work on getting this one finalized everyone!

Cool, done!


fix(export): export link problem

👀 PR includes

✨ Feature

[ ] New feature

🎨 Enhance

[ ] Code style optimization
[ ] Refactoring
[ ] Change the UI
[ ] Improve the performance
[ ] Type optimization

🐛 Bugfix

[x] Solve the issue and close #875

🔧 Chore

[ ] Test case
[ ] Docs / demos update
[ ] CI / workflow
[ ] Release version
[ ] Other ()

📝 Description
去掉组件内的a标签
🖼 Screenshot

Before
After

❌
✅

🔗 Related issue link

🔍 Self Check before Merge

[ ] Add or update relevant Docs.
[ ] Add or update relevant Demos.
[ ] Add or update relevant TypeScript definitions.

按理说 转  Blob 的时候加了 中文编码 不应该有乱码了吧


[DNM] xc7 re-work

This PR is to make xc7 subtree more generic and allow the presence of other device families.
The idea is to have an "umbrella" directory, namely xilinx, to hold the various device families (e.g. xc7, spartan, etc).
Given that most of the code in the xc7 tree (utils, cmake files, etc.) could potentially be shared among the various families, it should reside in a common directory in the xilinx tree.
This has multiple benefits:

generalize scripts and utilities;
avoid copy pasting existing code for future families support;
start a clean-up process of possible unused code.

We need to wait for https://github.com/SymbiFlow/symbiflow-arch-defs/pull/1252 to be merged before proceeding with this PR, as the two PRs will conflict and make install has higher priority than this one.


The workspace virtual environment watcher does not notice re-created files.

(see #5499)
This is a bit of an edge case; it only happens on linux (and mac?) and only when users do something unlikely.  It will probably require fixes in upstream VS Code.
We have a watcher set up to be notified when a "python" (or "python.exe") file is created under the workspace.  (see src/client/interpreter/locators/services/workspaceVirtualEnvWatcherService.ts)  This watcher is not getting triggered if the file in question was deleted and then re-created.  See #5499 of an example.

Closing because it's too edgy 👩🎤


Console Exceptions and Arguments

I using gremlin console and had trouble debugging my script because a File Not Found exception in my script was being caught here:
https://github.com/tinkerpop/gremlin/blob/master/gremlin-groovy/src/main/java/com/tinkerpop/gremlin/groovy/console/Console.java#L91-L93
Would it be appropriate to put a separate try catch block around the execution of the lines - ideally returning line number etc?

Hi @dstuebe - I don't believe you will see any more releases of Gremlin 2.x.  Please see all our fresh new development on Apache TinkerPop 3.x: http://tinkerpop.apache.org/
If you need that patched it is best you manged it yourself at this point i think.  Thanks.

Well - same issue still applies in TP3
https://github.com/apache/incubator-tinkerpop/blob/master/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/Console.groovy#L290
Sorry I was sloppy and did not check where I was opening the issue.
The following code:
println 'here'
s = new File('foobarbaz').text
println 'not here'

Will produce:
$ bin/gremlin.sh scripts/io_error.groovy
         \,,,/
         (o o)
-----oOOo-(3)-oOOo-----
plugin activated: aurelius.titan
plugin activated: tinkerpop.server
plugin activated: tinkerpop.utilities
plugin activated: tinkerpop.hadoop
plugin activated: tinkerpop.tinkergraph
here
==>null
Gremlin initialization file not found at [scripts/io_error.groovy].
$

When the file foobarbaz does not exist.
This is very misleading as it appears that the error is in reading the script not the script itself.
Not setup to report issues on the new Jira project - would you care to report this for me @spmallette ?

Thanks for reporting this.....
https://issues.apache.org/jira/browse/TINKERPOP-1055


IATP: policy evaluation functions

WHAT
Implements a set of new policy evaluation functions for CX credentials
WHY
iatp integration

Implemented here
https://github.com/eclipse-tractusx/tractusx-edc/pull/1075


backend for removing user from group

Mobile friendliness could use some work, otherwise great job!

That's next on my todo list


Update circe-core, circe-generic, ... to 0.14.4

Updates

io.circe:circe-core
io.circe:circe-generic
io.circe:circe-jawn
io.circe:circe-literal
io.circe:circe-parser
io.circe:circe-pointer

from 0.14.1 to 0.14.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.circe" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.circe" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:1

Codecov Report
Base: 76.39% // Head: 76.39% // No change to project coverage :thumbsup:

Coverage data is based on head (835cff6) compared to base (0fd5b9c).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   76.39%   76.39%
=======================================
  Files          17       17
  Lines         572      572
  Branches       29       29
=======================================
  Hits          437      437
  Misses        135      135

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Superseded by #134.


Test set analysis

Pull Request
Description
This PR includes analysis of the test set. The data has been analyzed on a Jupyter Notebook, and a summary of the findings have also been added to a README.md
How Has This Been Tested?
Tested locally, Jupyter Notebook providing plots, on which the analysis has been based on
Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

Thanks @bikramb98 for this, could you remove the jupyter notebook checkpoints.
Thank you for doing this work

@peterdudfield You are welcome, hope it is useful analysis! I've deleted the jupyter notebook checkpoints.

And the metadata.csv, is that what is on huggingface? If so I reckon we should not add it here? What do you think?

@peterdudfield Yes the metadata.csv is on HF, but I couldn't download it through the command at the bottom of the dataset page. When I tried dataset = load_dataset("openclimatefix/uk_pv"), I got an error saying ValueError: unrecognized engine h5netcdf must be one of: ['scipy', 'store']. Any idea why this could be happening? If I can get the dataset to download & load (rather than saving the metadata.csv manually, which I did), I can modify the notebook to load that metadata from HF rather than the CSV file.

I think you need to install https://pypi.org/project/h5netcdf/
And the csv you should be able to read with pandas. I think you need to login with the hugging face cli though

@peterdudfield I am logged in to HF through the CLI, and also have the h5netcdf installed, and got the error I mentioned yesterday. I am trying to find a solution, but it could also be a problem with the hf dataset itself? If I can't load the dataset after some more debugging, I can either:

Remove the analysis which uses the metadata
Make it clear on the notebook that the metadata lives in HF, and can be downloaded from there, and still do the analysis on it.
Which one would you prefer?

@peterdudfield I've removed the metadata.csv from the branch and now downloading it from HF. I got around the issue I was having by using hf_hub_download instead of load_dataset

@all-contributors please add @bikramb98  for code


Fix -debug-info-store-invocation logic on Darwin

Fixes DebugInfo/compiler-flags-macosx.swift
With these updates, swift-driver should now match the behavior of the integrated driver and clang by passing -debug-info-store-invocation only when it's passed to the driver or RC_DEBUG_OPTIONS is set.

@swift-ci test


put "WebID Profile Document" in a few more places

I think all comments have been addressed...
@csarven @bblfish — Please re-review toward merging soon.

Ok, looks like Sarven is ok with these changes. It also looks ok to me.


Is there a way to fire this manually for a running instance instead of stop/starting it?

This would be really useful to manually add to existing EC2 instances with less disruption.

Yeah I wonder if we could use a put/remove tag event in addition to the instance starting/stopping.
I may take some time in the next week or so to implement this.

Not exactly for put/remove tag but this should be able to pick up any new instances you want to hook up

i set it up using put tags events using the following schema:
          "source": [
            "aws.tag"
          ],
          "detail-type": [
            "Tag Change on Resource"
          ],
          "detail": {
            "changed-tag-keys": [
              "Create_Auto_Alarms"
            ],
            "service": [
              "ec2"
            ],
            "resource-type": [
              "instance"
            ]
          }
        }```

@eschu21 Hi, did this solution work for you, could you perhaps ellaborate on the steps you did to configure this?


feat(iceberg): bump iceberg-rust

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Bump iceberg-rust to latest version and cherry-pick a decimal fix. https://github.com/apache/iceberg-rust/pull/665

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxhZs It seems iceberg-rust has some breaking change that will cause position delete can't work. Please take a look together.


introduce VRAM calculator for a "tool" to optimize avatar's texture size for less advanced users

Is your feature request related to a problem? Please describe.
I think a lot of people are unaware how much VRAM their models take and less advanced users don't even know such thing exists in the first place nor how to "fix" it.
Describe the solution you'd like
Having some UI in place to show them how much VRAM their avatar takes and a tool to reduce the VRAM size easily for less advanced users would be a nice addition in my opinion. The tool could be something as simple as reducing all the texture sizes to 1-2k that are above 10 MB in the project and are used by the avatar's materials. Could alse be done automatically if you have such option checked/set when avatar is built for example, like most of the other scripts in this repo.
Describe alternatives you've considered
The alternative I use right now is VRCAvatarTools VRAM calculator and I have to manually click on each texture in the drop down so it's not really lazy optimization. Plus I think such UI might be too confusing for less advanced user.

Additional context
I am welcome to any type of feedback to this feature request and I would like some more ideas to be built upon this one, since I don't think my solution would be the best. I am mostly aiming it more towards less advanced users, because this Tool is to be used with Creator Companion. Feel free to correct me or disagree with me in the replies.

This idea has been converted into my own project, also VRChat has added texture memory avatar rating as of VRChat 2023.1.2.


EPIC: M3DB initial content

[x] M3 overview #77
[ ] M3 getting started #86
[ ] M3 connecting article #95
[ ] M3 migrating article #104

Open questions:

what connect examples do we use?
can we reuse the service setup from https://github.com/aiven/devportal/pull/140 for getting started?
there seem to be no existing m3 migration info. How could we put it together?

There are some code/connecting examples added (mostly taken from the aiven-examples repo)
I don't think we can re-use the service setup since the postgresql screenshots are a bit different and M3 has all the different connection types so it would be worth connecting things.
Migration information isn't something we already have (this is true for most of the projects) so one of us will need to create a sample project on InfluxDB (for example) and then migrate it to Aiven for M3 and document that process.


Restaurant demo replay appears broken.

To repro:

Find restaurants, watch logging for PersistentArc, note when we write a step.
Choose 'Make a reservation', watch logging again, note that when we write the second step (rev 2) we still have an array of Steps of size 1. It appears that we lose the first step, and it's overwritten with the second step.

Believe this is fixed.


Fix running on "My Mac (Desinged for iPad)"

See https://github.com/rust-windowing/winit/issues/2262

Fixed. See https://github.com/rust-windowing/winit/issues/2262


Repro for a problem with empty if is_root defz.bzl

This is a repro for a problem discussed on slack here https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1674863755778939
Repro
> cd e2e/vendored_tarfile
> bazelisk build @npm//...
> cat $(bazelisk info output_base)/external/npm/defs.bzl | grep -C 5 'if is_root'

Result: defs.bzl contains invalid starlark
        new_link_targets, new_scope_targets = link_fn(name)
        link_targets.extend(new_link_targets)
        for _scope, _targets in new_scope_targets.items():
            scope_targets[_scope] = scope_targets[_scope] + _targets if _scope in scope_targets else _targets

    if is_root:
    if link:

    if is_root:
        _npm_package_store(
            name = ".aspect_rules_js/{}/pyright@0.0.0".format(name),
            src = "//pyright-1.1.291.tgz:pyright-1.1.291.tgz",
            package = "pyright",
            version = "0.0.0",

Concreatly the
    if is_root:
    if link:

block has empty bodies for if statemenets.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

While this case could possibly have a better error the cause was a bad lockfile so closing this.


after() sees wrong response-code for missing routes.

Try this:

    public static void main(String[] args) {
        get("/hello", (req, res) -> "Hello World");
        after((request, response) -> {
            System.out.println("Status: " + response.status());
        });
    }

In a browser hit, say, "/hello2"

Note that it is 200 in the console but 404 in the browser.

It could be that there's something that happens after after() that's not open to participation :-( or a bug.

This is because filters registered through after(x) are called before httpResponse.setStatus(HttpServletResponse.SC_NOT_FOUND) is called in MatcherFilter.java

Was this fixed in #546 @ph-hs ?

Yes it was. Using afterAfter will give you 404.


Question - BMS copybook generation when compiling a program

Hi,
BMS copybook are not stored in a PDS in our mainframe environment. We need the BMS copybook to be generated by DBB when compiling a program using this copybook.
Is it possible to upgrade ZappBuild so that DBB generates BMS copybook when a program calls a BMS copybook ?
thanks

@Ludo-cats
There is an indirect/loose dependency maintained between BMS maps and the programs using the map (the copybook). It is explained at: https://www.ibm.com/docs/en/dbb/2.0?topic=apis-dependency-impact-resolution#indirect-build-dependencies
So, actually, the implementation of impact analysis is going the opposite direction:
In case of modifying the MortgageApplication sample source MortgageApplication/bms/epsmlis.bms producing the copybook, zAppBuild and DBB will identify the program MortgageApplication/cobol/epsmlist.cbl referencing the generated copybook as a dependent file.
It is similar like main modules with static calls to the sub modules, we don't automatically rebuild all the sub modules. We currently have a PR out to do an expanded analysis  and optionally allow customers to automatically add the sub modules to the build list.
I feel you are asking for a similar capability for BMS. Here is my question/assumption: I assume you don't want the new executable for the assembled map in your package, but are primarily interested in the latest version of the copybook, is that correct?
Generated outputs could be added back to the Git repository and be put under version control.
Looking forward to hear about your thoughts on this.

@Ludo-cats I am moving this now to the discussions. Can you please get back to my comments?


Update ERC-7578: Move to Review

Move to Review

Hey @SamWilsn!
Thanks for your feedback - it was very valuable and we've tried to cover all points as follows:

Moved all definitions to the specification section;
Updated the rationale to be less restrictive and define the externally visible behaviour;
Removed the setProperties definition to improve the standard's interoperability;

Let me know what you think!


Non-polymorphic embedded hasMany works with AMS

It seems that at the moment there is only test coverage for embedded, polymorphic hasMany relationships - but not for non-polymorphic ones.
Non-polymorphic embedded hasMany works for rest and json serializer, but it doesn't with the ActiveModelSerializer.
The fix basically includes 3 changes in the codebase, which hopefully are comprehensible. I will add some comments for further explanation.
Happy to update this PR, split it up so it only contains the fix (and add test coverage in a separate PR). Also, let me know if there is something I've missed, but testing wise the fixes seem not to influence other parts, even though the 3 changes look more substantial...

neat o .. nice PR

Uff, that was quick. Thanks a bunch!! 🚀

new patch version arriving soon

https://github.com/danielspaniel/ember-data-factory-guy/releases/tag/v3.0.1


[Bug] The exporter is not working

I'm using a custom build of https://github.com/matusnovak/prometheus-smartctl with the changes from several issues/prs opened in that project.
I just tested your fork as a drop-in replacement but it didn't work. Maybe you can apply similar patches and I will test it again.

Original code => https://github.com/matusnovak/prometheus-smartctl/blob/master/smartprom.py
My changes => smartprom.py.txt
Log traces when I run your Docker image => _smartctl-exporter_logs.txt

Hi @ngosang
why exactly do you think that the exporter is not working?
Can you please provide more details?
What d you expect to happen? What did happen / did not happen?
Do you see metrics described here?
https://github.com/PhilipMay/smart-prom-next#available-metrics
The _smartctl-exporter_logs.txt you linked contains "warnings":
Calling ['smartctl', '--xall', '--json', '/dev/sda'] resturned non zero returncode! returncode: 4 stderr: 'not set'
Calling ['smartctl', '--xall', '--json', '/dev/sdb'] resturned non zero returncode! returncode: 4 stderr: 'not set'
Calling ['smartctl', '--xall', '--json', '/dev/sdc'] resturned non zero returncode! returncode: 4 stderr: 'not set'
Calling ['smartctl', '--xall', '--json', '/dev/sda'] resturned non zero returncode! returncode: 4 stderr: 'not set'
Calling ['smartctl', '--xall', '--json', '/dev/sdb'] resturned non zero returncode! returncode: 4 stderr: 'not set'
Calling ['smartctl', '--xall', '--json', '/dev/sdc'] resturned non zero returncode! returncode: 4 stderr: 'not set'

But they are ok. smartctl can return a non 0 exit code and still work. From the output I can see this in the log:
    "argv": [
      "smartctl",
      "--xall",
      "--json",
      "/dev/sda"
    ],
    "messages": [
      {
        "string": "Warning: This result is based on an Attribute check.",
        "severity": "warning"
      }
    ],
    "exit_status": 4
  },

That is not an error.

Exit status 4 means bit 2 is set which means:
"     Some SMART or other ATA command to the disk failed, or there was a checksum error in a SMART data structure (see '-b' option above)."
See "EXIT STATUS" from here: https://www.smartmontools.org/browser/trunk/smartmontools/smartctl.8.in
Is it possible that you did not set "    privileged: true"?

But in the json file from the logs I can see all relevant info that is needed. So smart-prom-next should be able to crape what it gets.
Even if non zero is returned.

You are right, the exporter is working and I can see the metrics. You can close this issue.
As I said in https://github.com/matusnovak/prometheus-smartctl/issues/19#issuecomment-1197347681, I'm not going to use this exporter for now but I can give you some advice:

The exporter should be silent by default (only error traces). You can make log level configurable but at the default INFO level should be quite. I have a centralized log solution and I prefer to not have to filter traces.
There are too many metrics, maybe add some Env Vars to make them optional?
The CPU usage is greater than https://github.com/matusnovak/prometheus-smartctl/ Maybe you can improve that or make refresh interval configurable.

Many thanks @ngosang for retesting and your comments.

There are too many metrics, maybe add some Env Vars to make them optional?

Can you tell me which metrics would you make optional? Which do you think are "too many"?

The CPU usage is greater than https://github.com/matusnovak/prometheus-smartctl/ Maybe you can improve that or make refresh interval configurable.

My refresh interval default is at 60s. The one of matusnovak/prometheus-smartctl is at 20s. Do you have an idea why my CPU time is so much higher?

the refresh interval is configurable with SMART_INFO_READ_INTERVAL_SECONDS. see here: https://github.com/PhilipMay/smart-prom-next#configuration-options--environment-variables

My refresh interval default is at 60s. The one of matusnovak/prometheus-smartctl is at 20s. Do you have an idea why my CPU time is so much higher?

I'm using 600 in my fork.

I'm using 600 in my fork.

That might be the explanation...

closing since this is no bug


run scripts async

the <script async> tag is neat, if we have it in the <head> element we can remove the nanomount code from choo (which would be greattt)

ref https://github.com/sethvincent/create-html/issues/4

Yay, create-html has been updated to allow for a scriptAsync: true option

done!


Remove recursive/ignore option from ipfs.addFromFs and accept globs?

It seems weird that we accept globs for the ignore option but not for the path parameter?
ipfs.addFromFs('/path/to/dir', {
  recursive: true,
  ignore: ['*.js', '*.css']
})

We could accept globs there and then remove the recursive option.
ipfs.addFromFs('/path/to/dir/**', {
  ignore: ['*.js', '*.css']
})

Going further you can also specify ignores in the path glob so we can retire the ignore option too:
ipfs.addFromFs('/path/to/dir/**/!(*.js|*.css)')

In the positive matching case this would also let the user specify the files they want, instead of having to specify a base dir, a recursive flag and then ignore patterns for all the files they don't want:
ipfs.addFromFs('/path/to/dir/**/{*.js,*.css}')

Perhaps we could pass the options object through to minimatch for really advanced usage - so you can match hidden files and so on?

+1 yes please! This would simplify the API and our code


ext_authz test flake on windows

https://dev.azure.com/cncf/envoy/_build/results?buildId=49984&view=logs&jobId=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=168f295b-0553-5364-35f7-923225ecd8b3
https://dev.azure.com/cncf/envoy/_build/results?buildId=49872&view=logs&jobId=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=168f295b-0553-5364-35f7-923225ecd8b3
[ RUN      ] IpVersions/ExtAuthzLocalReplyIntegrationTest.DeniedHeaderTest/IPv4
test/extensions/filters/http/ext_authz/ext_authz_integration_test.cc(682): error: Expected equality of these values:
  "401"
    Which is: 00007FF634CA275C
  response->headers().Status()->value().getStringView()
    Which is: "403"
Stack trace:
  00007FF634B9AC06: (unknown)
  00007FF634BB09F4: (unknown)
  00007FF634BB1423: (unknown)
  00007FF634B9ADBC: (unknown)
... Google Test internal frames ...

test/extensions/filters/http/ext_authz/ext_authz_integration_test.cc(692): error: Value of: TestUtility::jsonStringEqual(response->body(), expected_body)
  Actual: false
Expected: true
Stack trace:
  00007FF634B9AC06: (unknown)
  00007FF634BB09F4: (unknown)
  00007FF634BB1423: (unknown)
  00007FF634B9ADBC: (unknown)
... Google Test internal frames ...

[  FAILED  ] IpVersions/ExtAuthzLocalReplyIntegrationTest.DeniedHeaderTest/IPv4, where GetParam() = 4-byte object <00-00 00-00> (400 ms)
[ RUN      ] IpVersions/ExtAuthzLocalReplyIntegrationTest.DeniedHeaderTest/IPv6
test/extensions/filters/http/ext_authz/ext_authz_integration_test.cc(682): error: Expected equality of these values:
  "401"
    Which is: 00007FF634CA275C
  response->headers().Status()->value().getStringView()
    Which is: "403"
Stack trace:
  00007FF634B9AC06: (unknown)
  00007FF634BB09F4: (unknown)
  00007FF634BB1423: (unknown)
  00007FF634B9ADBC: (unknown)
... Google Test internal frames ...

test/extensions/filters/http/ext_authz/ext_authz_integration_test.cc(692): error: Value of: TestUtility::jsonStringEqual(response->body(), expected_body)
  Actual: false
Expected: true
Stack trace:
  00007FF634B9AC06: (unknown)
  00007FF634BB09F4: (unknown)
  00007FF634BB1423: (unknown)
  00007FF634B9ADBC: (unknown)
... Google Test internal frames ...

Seems to happen intermittently on Windows only.
fyi @envoyproxy/windows-dev

/assign @sunjayBhatia

Passed 100/100 runs locally on my workstation, trying to repro in RBE

Ran the test overnight against RBE, passed 2600/2600 times

Able to repro, looks like we're getting an upstream timeout flake:
[2020-09-01 15:18:28.922][3176][debug][connection] [source/common/network/connection_impl.cc:765] [C2] connection in progress
[2020-09-01 15:18:29.284][3176][trace][http] [source/common/http/filter_manager.cc:440] [C1][S12664742747321092839] decode headers called: filter=0x25675b810a0 status=4
[2020-09-01 15:18:29.284][3176][trace][http] [source/common/http/http1/codec_impl_legacy.cc:563] [C1] parsed 49 bytes
[2020-09-01 15:18:29.284][3176][trace][connection] [source/common/network/connection_impl.cc:499] [C1] socket event: 2
[2020-09-01 15:18:29.284][3176][trace][connection] [source/common/network/connection_impl.cc:600] [C1] write ready
[2020-09-01 15:18:29.284][3176][trace][connection] [source/common/network/connection_impl.cc:499] [C2] socket event: 2
[2020-09-01 15:18:29.284][3176][trace][connection] [source/common/network/connection_impl.cc:600] [C2] write ready
[2020-09-01 15:18:29.284][3176][debug][connection] [source/common/network/connection_impl.cc:609] [C2] connected
[2020-09-01 15:18:29.284][3176][debug][client] [source/common/http/codec_client.cc:77] [C2] connected
[2020-09-01 15:18:29.284][3176][debug][pool] [source/common/conn_pool/conn_pool_base.cc:184] [C2] attaching to next stream
[2020-09-01 15:18:29.284][3176][debug][pool] [source/common/conn_pool/conn_pool_base.cc:108] [C2] creating stream
[2020-09-01 15:18:29.284][3176][debug][router] [source/common/router/upstream_request.cc:357] [C0][S14900965347508181339] pool ready
[2020-09-01 15:18:29.284][3176][trace][connection] [source/common/network/connection_impl.cc:420] [C2] writing 138 bytes, end_stream false
[2020-09-01 15:18:29.284][3176][trace][connection] [source/common/network/connection_impl.cc:600] [C2] write ready
[2020-09-01 15:18:29.284][3176][trace][connection] [source/common/network/raw_buffer_socket.cc:68] [C2] write returns: 138
[2020-09-01 15:18:29.284][3176][debug][router] [source/common/router/router.cc:791] [C0][S14900965347508181339] upstream timeout
[2020-09-01 15:18:29.284][3176][debug][router] [source/common/router/upstream_request.cc:299] [C0][S14900965347508181339] resetting pool request
[2020-09-01 15:18:29.284][3176][debug][client] [source/common/http/codec_client.cc:119] [C2] request reset
[2020-09-01 15:18:29.284][3176][trace][main] [source/common/event/dispatcher_impl.cc:170] item added to deferred deletion list (size=1)
[2020-09-01 15:18:29.284][3176][debug][connection] [source/common/network/connection_impl.cc:105] [C2] closing data_to_write=0 type=1
[2020-09-01 15:18:29.284][3176][debug][connection] [source/common/network/connection_impl.cc:201] [C2] closing socket: 1
[2020-09-01 15:18:29.284][3176][debug][client] [source/common/http/codec_client.cc:96] [C2] disconnect. resetting 0 pending requests
[2020-09-01 15:18:29.284][3176][debug][pool] [source/common/conn_pool/conn_pool_base.cc:293] [C2] client disconnected, failure reason:
[2020-09-01 15:18:29.284][3176][trace][main] [source/common/event/dispatcher_impl.cc:170] item added to deferred deletion list (size=2)
[2020-09-01 15:18:29.284][3176][debug][http] [source/common/http/async_client_impl.cc:99] async http request response headers (end_stream=false):
':status', '504'
'content-length', '24'
'content-type', 'text/plain'

[2020-09-01 15:18:29.284][3176][trace][http] [source/common/http/async_client_impl.cc:116] async http request response data (length=24 end_stream=true)
[2020-09-01 15:18:29.284][3176][trace][filter] [source/extensions/filters/http/ext_authz/ext_authz.cc:272] [C1][S12664742747321092839] ext_authz filter rejected the request with an error. Response status code: 403
[2020-09-01 15:18:29.285][3176][debug][http] [source/common/http/filter_manager.cc:773] [C1][S12664742747321092839] Sending local reply with details ext_authz_error
[2020-09-01 15:18:29.285][3176][debug][http] [source/common/http/conn_manager_impl.cc:1314] [C1][S12664742747321092839] encoding headers via codec (end_stream=false):
':status', '403'
'content-length', '26'
'content-type', 'application/json'
'date', 'Tue, 01 Sep 2020 15:18:28 GMT'
'server', 'envoy'

[2020-09-01 15:18:29.285][3176][trace][connection] [source/common/network/connection_impl.cc:420] [C1] writing 130 bytes, end_stream false
[2020-09-01 15:18:29.285][3176][trace][http] [source/common/http/conn_manager_impl.cc:1323] [C1][S12664742747321092839] encoding data via codec (size=26 end_stream=true)
[2020-09-01 15:18:29.285][3176][trace][connection] [source/common/network/connection_impl.cc:420] [C1] writing 26 bytes, end_stream false
[2020-09-01 15:18:29.285][3176][trace][connection] [source/common/network/connection_impl.cc:308] [C1] readDisable: disable=false disable_count=1 state=0 buffer_length=0
[2020-09-01 15:18:29.285][3176][trace][main] [source/common/event/dispatcher_impl.cc:170] item added to deferred deletion list (size=3)
[2020-09-01 15:18:29.285][3176][trace][main] [source/common/event/dispatcher_impl.cc:170] item added to deferred deletion list (size=4)
[2020-09-01 15:18:29.285][3176][trace][main] [source/common/event/dispatcher_impl.cc:78] clearing deferred deletion list (size=4)
[2020-09-01 15:18:29.285][3176][debug][pool] [source/common/conn_pool/conn_pool_base.cc:133] [C2] destroying stream: 0 remaining
[2020-09-01 15:18:29.285][3176][trace][connection] [source/common/network/connection_impl.cc:499] [C1] socket event: 2
[2020-09-01 15:18:29.285][3176][trace][connection] [source/common/network/connection_impl.cc:600] [C1] write ready
[2020-09-01 15:18:29.285][3176][trace][connection] [source/common/network/raw_buffer_socket.cc:68] [C1] write returns: 156
[2020-09-01 15:18:29.285][3176][trace][connection] [source/common/network/connection_impl.cc:499] [C1] socket event: 2
[2020-09-01 15:18:29.285][3176][trace][connection] [source/common/network/connection_impl.cc:600] [C1] write ready
[2020-09-01 15:18:29.285][3176][trace][connection] [source/common/network/connection_impl.cc:499] [C1] socket event: 2
[2020-09-01 15:18:29.285][3176][trace][connection] [source/common/network/connection_impl.cc:600] [C1] write ready

flake is much more repro-able running just the IpVersions/ExtAuthzLocalReplyIntegrationTest.DeniedHeaderTest/IPv4 (or IPv6 version) alone

bumping the ext authz http service timeout to 0.5s the test succeeds 100/100 runs, whereas with 0.25s we get 88/100
https://github.com/envoyproxy/envoy/blob/9af9afff54e30cab45ad7a80565ed9e300cda019/test/extensions/filters/http/ext_authz/ext_authz_integration_test.cc#L632
Not sure I'm reading the logs right but it also may be that the http service timeout isn't being fully respected in real wall clock time, trying to verify if that is actually true/the correct time system is injected etc.

Maybe a meta-point around this issue, where do we get the timeouts for http services from? Seems like they are arbitrary

The "default config" has a 300s timeout: https://github.com/envoyproxy/envoy/blob/9af9afff54e30cab45ad7a80565ed9e300cda019/test/extensions/filters/http/ext_authz/ext_authz_integration_test.cc#L497

@sunjayBhatia I did a similar fix elsewhere. Please just bump the service time to something very long (like 300s). This will either timeout in an obvious way or force sim time.

Yes I did the fix above but I guess I didn't fix all cases.

@mattklein123 sweet, PR is here https://github.com/envoyproxy/envoy/pull/12929 thanks for the context, will make sure to take this into account for future flakes


clangrt builtins lib not found

Do users need to install additional library for building rocblas with DPC++ ?
-- CMAKE_BUILD_TYPE: None, set to Release by default
-- C compiler: icx was not found in PATH, using clang instead
-- The CXX compiler identification is Clang 17.0.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /path/to/dpcpp/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- TARGET_DOMAINS: blas
-- Looking for dpc++
-- Performing Test is_dpcpp
-- Performing Test is_dpcpp - Success
-- Performing Test HIP_CLANG_SUPPORTS_PARALLEL_JOBS
-- Performing Test HIP_CLANG_SUPPORTS_PARALLEL_JOBS - Failed
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- hip::amdhip64 is SHARED_LIBRARY
CMake Error at /opt/rocm/hip/lib/cmake/hip/hip-config.cmake:331 (message):
clangrt builtins lib not found
Call Stack (most recent call first):
/usr/share/cmake-3.22/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
/opt/rocm/lib/cmake/rocblas/rocblas-config.cmake:90 (find_dependency)
cmake/FindrocBLAS.cmake:36 (find_package)
src/blas/backends/rocblas/CMakeLists.txt:24 (find_package)

What was the resolution to this? I've encountered the same issue.

I think this issue is normally encountered when using clang++ instead of icpx. I'm not sure what the fix is if you need clang++.

I think this issue is normally encountered when using clang++ instead of icpx. I'm not sure what the fix is if you need clang++.

OK guess it is my job to find out then

The additional steps required when using open source intel/llvm are:
After configuring as normal, e.g.
python configure.py --hip

go to the generated build folder and adjust your CMakeCache.txt:

set LLVM_BUILD_EXTERNAL_COMPILER_RT:BOOL=ON

//Build compiler-rt as an external project.
LLVM_BUILD_EXTERNAL_COMPILER_RT:BOOL=ON

add compiler-rt to LLVM_ENABLE_PROJECTS:STRING e.g. :

LLVM_ENABLE_PROJECTS:STRING=...;libclc;compiler-rt

Then build intel/llvm as normal. then when building oneMKL compiler-rt should be found.

A fix that worked for me was either:

export LIBRARY_PATH=/path/to/rocm-$rocm-version$/llvm/lib/clang/$clang-version$/lib/linux/:$LIBRARY_PATH
or
directly modifying the CLANGRT_BUILTINS variable in your CmakeCache.txt file to point to the libclang_rt.builtins-x86_64.a file on your machine e.g.
CLANGRT_BUILTINS:FILEPATH=/path/to/rocm-$rocm-version$/llvm/lib/clang/$clang-version$/lib/linux/libclang_rt.builtins-x86_64.a

Let me know if either of these work for you. Thanks.

A fix that worked for me was either:
* `export LIBRARY_PATH=/path/to/rocm-$rocm-version$/llvm/lib/clang/$clang-version$/lib/linux/:$LIBRARY_PATH`
  or

* directly modifying the `CLANGRT_BUILTINS` variable in your `CmakeCache.txt` file to point to the `libclang_rt.builtins-x86_64.a` file on your machine e.g.
  `CLANGRT_BUILTINS:FILEPATH=/path/to/rocm-$rocm-version$/llvm/lib/clang/$clang-version$/lib/linux/libclang_rt.builtins-x86_64.a`

Let me know if either of these work for you. Thanks.

@muhammad-tanvir-1211 Neither of the above steps worked resulting in the error. Where as explicitly building the compiler-rt external component worked though.
make[2]: *** No rule to make target '/lustre/orion/gen243/scratch/abagusetty/llvm/build/install/lib/clang/18/lib/linux/libclang_rt.builtins-x86_64.a', needed by 'lib/libonemkl_rng_rocrand.so.0'.  Stop.

 I tried to build LLVM on ORNL Crusher but either I had the wrong banch or the wrong C++ compiler or something, but I gave up after a couple of hours.
I did get Muhammad's CLANGRT_BUILTINS (to the oneMKL CMakeCache.txt  file) hack to work.
I also had to build lapack from https://github.com/Reference-LAPACK/lapack using FC=gfortran in order to get MKL to build, even though the documentation suggests you need it only if you want to test. It's tricky to get lapack to build on Cray system, definitely can't use their wrappers. Fortunately the performance didn't matter.

Thank you for your solutions to the issue!


[exercise] Add automation that allows us to force breach of SLO

📝 Description
In order to exercise and experience an SLO being breached, we should have automation (or a trigger of some sort) that allows us to force errors that will cause an SLO to go red.
✅ A/Cs

[ ] Based off of the example SLI and SLO that we have created, create a piece of automation that will cause the metrics collected to not match what we're scraping.
[ ] Facilitator has documentation for how to trigger this automation to inject errors

This depends on SLOs being available within Pet Battle (so we have something to track and/or break-fix).


Use publishDir to save final output files instead of manual copyTo

Attempt to use publishDir instead of manual copyTo command.
Can't get the test profile to run locally at the moment so this is blind. Needs testing to confirm that it works.

ok, well the tests are passing now. Can't check if the output file is actually saved or not though (and would also be good to check without cleaning and decoy. And finally good to check that the output file that is saved is actually the right one 😅


move bitmap to bitmap.go and remove unless files

Please provide Issues links to:

Issues: #

Provide test code:

Description

add color and mouse pos picker cmd support
remove unless files and move windows cdeps to win
move bitmap to bitmap.go and move ocr to img.go
Update README.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[subset] Recalculate OS/2.xAvgCharWidth

Coverage decreased (-0.02%) to 71.133% when pulling efb32d5402a637fb36505a54f99657a0983713b9 on khaledhosny:subset-xAvgCharWidth into 10aaac53f2c644ed487d19162464c103d35a9529 on behdad:master.

It looks good to me. I wonder if a method like that could be placed in the OS/2 table class itself, so it is available not just for the subsetter.
@behdad @justvanrossum

Hope does this differ from what Felipe did for fontbakery?

@davelab6 could you maybe put a link to Felipe's patch so we can compare?

I don’t mind even if we changed FontTools to just recalculate xAvgCharWidth when it compiles the font, I can’t think of any reason why one one need a different value than what would be calculated here.

OK, I think this patch is a good idea but the code is a bit too simple. Please see https://github.com/googlefonts/fontbakery/commit/c70df187719ca8984b79b536d3e0f4867ac286eb by @felipesanches and https://github.com/googlefonts/fontbakery/issues/781#issuecomment-208589366 for an explanation from @jtanx

Do we really need different handling of OS/2 < 3 versions? What is xAvgCharWidth used for anyway?

Spec is spec ;)

Is it? I just checked both Firefox and Chrome and they don’t seem to interpret the value differently for different to OS/2 table versions. Not to mention that the old none-sense in the spec was removed back in 2002, if people are so inclined we can change the value only for fonts with version OS/2 >= 3 and leave fonts with old table version alone in their misery.

the weighting factors in the os2ver2 spec are just provided as an "example", and they are accompanied by a warning "when comparing fonts that use different frequency of use values for font mapping".
The simpler, unweighted algorithm proposed by Khaled should work fine for practical purposes. I think it's fine to merge it as is for the subsetter. We can maybe add it later to the OS/2 module after we figure out how to pass such options to TTFont without overloading its constructor with additional kwargs.

I added a --recalc-average-width command line option. It's on by default, but you can turn it off by passing --no-recalc-average-width.
Thanks Khaled.

I added a --recalc-average-width command line option. It's on by default

Can you please make it off by default?  That's subsetter's current defaults: fastest.  Note that recalc-bounding-box etc are also off by default.
I'm also not sure how useful this is in the subsetter.  Khaled, why do you need this?

I don’t have an actual need for this, I was just checking why fontbakery is complaining about the value in my fonts, and as it happens I’m using the subsetter to drop Latin characters I don’t need (easier than having to parse and subset feature files).

This comment https://github.com/adobe-fonts/source-han-sans/issues/154#issuecomment-233897031 might be relevant

It is a known bug in GDI, when PANOSE's proportion set to monospaced, it will ignore the entire hmtx and force use OS/2.xAvgCharWidth, at least for TTF.


fix(validator-types): type Alignment with Web Standards

Close https://github.com/honojs/hono/issues/3119
The author should do the following, if applicable

[x] Add tests
[x] Run tests
[x] bun run format:fix && bun run lint:fix to format the code
[ ] Add TSDoc/JSDoc to document the code

Check the issue for more information on this issue.
This change brings the types more in line with web standards.

Hey @EdamAme-x
Thank you for the PR. I've left the comment.

@yusukebe I just ready now

@EdamAme-x Thanks. Merging now.


Saving configuration options and various markets/languages

The issue seems related to "market" dropdown which prevents parameters' values being saved correctly.
How to reproduce:

Enter all required parameters
Save changes
Open "KlarnaPayments", navigate to parameters tab, all values are gone.

Workaround

Enter all required parameters, then navigate to market tab, and select one market
Save changes
Open "KlarnaPayments", navigate to parameters tab, this time you'll be able to see market dropdown is set with selected value set from last step, but all other mandatory values are gone. Re-enter them again, and save changes, this time other mandatory values will be persisted.

P.s I'm not sure whats the real value of market dropdown under parameters tab as market is part part of payment plugin and can be configured via market tab.
Let me know if you need any further information.
_Originally posted by @javafun

Hi, we saw the same issue for one of our markets where it refused to save, but when looking in the DB it looks like it actualy did save.
We had changed the default landuage for the market from swedish to english, and it was then we couldn't save the configurment for that market. We changed it back to default language swedish, and it started working again. Really weird.

Closing since version 4.0.0 and later has the configuration in appsettings.json instead of CM.


Possible typo in variables declaration in bash

Command mentioned here if execute on bash shell results to error
eg.
under "Create service principal for Azure authentication" section
$groupId=$(az group show \
  --name my-rg \
  --query id --output tsv)

Errror:
bash: =/subscriptions/xx-xxxxxx-xx/resourceGroups/my-rg: No such file or directory
The variable name should be "groupID" not "$groupID".
Same goes for:
"Update service principal for registry authentication" section
$registryId=$(az acr show \
  --name my-reg \
  --query id --output tsv)

Worked following way
groupId=$(az group show \
  --name my-rg \
  --query id --output tsv)

registryId=$(az acr show \
  --name my-reg \
  --query id --output tsv)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c5d2898-9714-9b98-f065-66a59889f909
Version Independent ID: 6a7e0145-9e57-b2e6-04f6-9aeda314bad7
Content: Deploy container instance by GitHub action - Azure Container Instances
Content Source: articles/container-instances/container-instances-github-action.md
Service: container-instances
GitHub Login: @macolso
Microsoft Alias: macolso

@xenea
Thanks for reaching out. We'll investigate and update this document as appropriate.

@xenea
I have raised a PR for this that will take a couple of days to go live. Thank you for helping us improve Microsoft Docs. We will resolve this issue now, meanwhile if you have any queries, feel free to tag me in your comments and we will continue the conversation from here.


Nothing in the Wiki about logging out

My apologies about this, especially in Issue #122, for I am very new to Hypr.
I'm making my configuration use the same hotkeys and keychords as i3 (my main WM), but I don't see anything in the documentation about logging out of Hypr. I'm still learning, so please bear with me on that.
Is there a command one could give to Hypr to log out of it? If not, is it possible for this to happen in the future?

killall Xorg?

I'll take a look once I have time.

where?

In my hypr.conf file, I went ahead and added bind=SUPERSHIFT,Q,exec,echo {PASSWORD} | sudo -S killall Xorg. Otherwise, if you're talking about something else (or somewhere else), let me know.

I meant where do you want it put in the wiki

I'd say probably under Configuring Hypr would be the best bet. The specific subsection, that I leave to you.

already there tho reading it

Huh, maybe clarify that underneath it as a backup for if it doesn't work.

added


CLOUD-42557 remove openstack4j from core and add credential handling …

@keyki and @doktoric please check
CLOUD-42557 remove openstack4j from core and add credential handling to SPI

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1686/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1687/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1689/

 merge yet

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1695/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1696/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1702/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1704/


why get nan while QAT

Describe the issue:
When I quantify the resnet18 in QAT method, the loss will explode. This will happen no matter how many nodes are quantified.
The code is there:
config_list = [{         'quant_types': ['weight', 'input'],         'quant_bits': {'weight': 8, 'input': 8,},             'op_names': op_dict['conv2d']         }, {             'quant_types': ['output'],             'quant_bits': {'output': 8, },             'op_names': op_dict['relu']         }, {             'quant_types': ['output', 'weight', 'input'],             'quant_bits': {'output': 8, 'weight': 8, 'input': 8},             'op_names': op_dict['fc'],         }] dummy_input = torch.randn(3,3,32,32).to(device) quantizer = QAT_Quantizer(model, config_list, optimizer, dummy_input=dummy_input) quantizer.compress()
Environment:

NNI version:2.5
Training service (local|remote|pai|aml|etc):
Client OS:
Server OS (for remote mode only):
Python version:
PyTorch/TensorFlow version:
Is conda/virtualenv/venv used?:
Is running in Docker?:

Configuration:

Experiment config (remember to remove secrets!):
Search space:

Log message:

nnimanager.log:
dispatcher.log:
nnictl stdout and stderr:

How to reproduce it?:

Hello @2730gf , have you trained the model after quantizer.compress(), do you mean the test loss is nan? QAT is a quantization-aware training process, here is an example for using QAT https://github.com/microsoft/nni/blob/master/examples/model_compress/quantization/QAT_torch_quantizer.py
The training after quantizer.compress() is necessary. If you have already trained the model after compress(), but the train/test loss is also nan, please tell us.

Hello, I have used quantizer.compress(). And the difinition of resnet18 if from https://github.com/microsoft/nni/blob/master/examples/model_compress/models/cifar10/resnet.py.
After importing a trained model weight. The test loss is nan. Later in the training process, loss gradually becomes nan.
By the way, is also a bug in https://github.com/microsoft/nni/blob/12b5dbe2938847a2b1e6e8bcb9f972237af433b6/examples/model_compress/end2end_compression.py#L201. When converting to TensorRT engine, both "weight" and "input" are required.

Hello, I have used quantizer.compress(). And the difinition of resnet18 if from https://github.com/microsoft/nni/blob/master/examples/model_compress/models/cifar10/resnet.py. After importing a trained model weight. The test loss is nan. Later in the training process, loss gradually becomes nan. By the way, is also a bug in
https://github.com/microsoft/nni/blob/12b5dbe2938847a2b1e6e8bcb9f972237af433b6/examples/model_compress/end2end_compression.py#L201
. When converting to TensorRT engine, both "weight" and "input" are required.

In the process of training, loss will become nan after one or two epochs.

Hello, I have used quantizer.compress(). And the difinition of resnet18 if from https://github.com/microsoft/nni/blob/master/examples/model_compress/models/cifar10/resnet.py. After importing a trained model weight. The test loss is nan. Later in the training process, loss gradually becomes nan. By the way, is also a bug in
https://github.com/microsoft/nni/blob/12b5dbe2938847a2b1e6e8bcb9f972237af433b6/examples/model_compress/end2end_compression.py#L201
. When converting to TensorRT engine, both "weight" and "input" are required.

The code is here. https://github.com/2730gf/nni-validation/blob/main/nni_qat_practice.py
s there anything else I need to provide?

Hello, I have used quantizer.compress(). And the difinition of resnet18 if from https://github.com/microsoft/nni/blob/master/examples/model_compress/models/cifar10/resnet.py. After importing a trained model weight. The test loss is nan. Later in the training process, loss gradually becomes nan. By the way, is also a bug in
https://github.com/microsoft/nni/blob/12b5dbe2938847a2b1e6e8bcb9f972237af433b6/examples/model_compress/end2end_compression.py#L201
. When converting to TensorRT engine, both "weight" and "input" are required.

Thank you, yes, this is a bug, I will fix it.
And I tried your code, it seems to work well, the only difference is I change the config_list to
        config_list = [{
            'quant_types': ['weight', 'input'],
            'quant_bits': {'weight': 8, 'input': 8,},
            'op_types': ['Conv2d']
        }, {
            'quant_types': ['output', 'weight', 'input'],
            'quant_bits': {'output': 8, 'weight': 8, 'input': 8},
            'op_types': ['Linear']
        }]

because I don't know get_op_names() and no ReLu module in ResNet18. So I think maybe this is where cause problem.

I did it again as you did, and the result was the same, very weird, let me check again.

Could it be a problem with model weights? I pushed the model weight again, and now you can directly reproduce my operation with python nni_qat_practice.py .

Could it be a problem with model weights? I pushed the model weight again, and now you can directly reproduce my operation with python nni_qat_practice.py .

I tried with your pre-trained model, because you use a pre-trained model, better set quant_start_step and don't quantize the last layer right now.
        config_list = [{
            'quant_types': ['weight', 'input'],
            'quant_bits': {'weight': 8, 'input': 8,},
            'quant_start_step': 100,
            'op_types': ['Conv2d']}]

Because the quantizer will patch the optimizer, so I don't use a lr_scheduler, but maybe it is not the reason.
And make sure to load the model state dict before initializing the optimizer.

Could it be a problem with model weights? I pushed the model weight again, and now you can directly reproduce my operation with python nni_qat_practice.py .

I tried with your model, because you use a pre-trained model, better set quant_start_step and don't quantize the last layer right now.
        config_list = [{
            'quant_types': ['weight', 'input'],
            'quant_bits': {'weight': 8, 'input': 8,},
            'quant_start_step': 100,
            'op_types': ['Conv2d']}]

Because the quantizer will patch the optimizer, so I don't use a lr_scheduler, but maybe it is not the reason.
And make sure to load the model state dict before initializing the optimizer.
After 10 epochs of training with lr=0.001, the final acc is 90.55%, and I think it can do better with a better hyperparameter, you can have a try.

@2730gf -
Please press F12 to open browser console and check the error message.
@yzj19870824 - are you still bother by the problem? any feedback about the above suggestion.
We are closing out of date issues, let us know if this is still a problem on your side, thanks.

Closing the issue as overdue as it has no responds for a while, feel free to reopen if you are still seeing the problem on your side.


Classification performance of provided BiT checkpoint is unexpected

Hi,
I sincerely appreciate your public code. I can reproduce your OOD detection scores by using the provided BiT checkpoint. But I found that the classification performance of this checkpoint is quite strange (about 0.1 on ImageNet val).
For your information, I also validate other models on the ImageNet-1k validation set. E.g., if I utilize the pretrained ResNet-50 (from torchvision), the performance is in the regular range (about 80% ACC).
Could you please check your provided ckt? Thank you so much.

Hi,
Thanks for being interested in our work! I guess the label number you are using is different from the model? Can you try the ground-truth label in this codebase: https://github.com/deeplearning-wisc/large_scale_ood/blob/master/data_lists/imagenet2012_val_list.txt?
The model we used in our paper is slightly different from the original BiT checkpoint. Even though GradNorm doesn't require any extra training, for easy comparison to all baselines, we reused a model in our previous paper, with some slight fine-tuning from BiT, as you can see in the other codebase.

Thanks! It solves the problem. After using the provided image labels, the model works well.


feat: Implement full-text search

Enhanced the search functionality to index and search full text content within the docs pages.
This includes:

Indexing all text content, including paragraphs, code blocks, and lists.
Searching across both titles and content with appropriate weighting.
Improving search result relevance by considering context and prioritizing title matches.

This seems to successfully search the full text of each page, however, the displayed search results are not very informative.
I had envisioned something closer to what is implemented in the vuepress docs portal, which shows both the page name and section name where the search result is found, and if it is a result from the full text, the surrounding text is also displayed in the search result so users have more context when selecting a result.
https://github.com/ar-io/docs/blob/main/docs/src/.vuepress/theme/components/SearchModal.vue

Enhanced Search with Full-Text Content and Improved Result Display
Changes

Implemented full-text search across all document content, not just headers
Added preview text to search results showing the matching content in context
Improved the result display to show complete hierarchy (section/page/subsection)
Added content type indicators to differentiate between text and code blocks
Improved search result relevance by properly weighting different content types

Technical Details

Modified the MDX processor to capture and index all content types
Enhanced the search index configuration to store additional context
Added proper type definitions for improved result format

Screenshots


Removing a constraint fails in Marathon web UI

Removing a constraint fails. Currently I have a constraint "hostname:UNIQUE" and when clear the text box and click on "Change and deploy configuration", it says:
Comma-separated list of valid constraints. Valid constraint format is "field:operator[:value]".
Constraint definition must be an array of strings in format: <key>, <operator>[, value]

Version of Marathon is 0.15.2.

Hi @akunaatrium !
I can reproduce this in 0.15.*, thanx for reporting this.
Anyway I can't reproduce this in the current master, seems there are some changes at the service layer side, so is fixed for the upcoming 0.16 .

We ran into a similar issue with a GROUPBY constraint.  Removing it from the UI fails.  To work around it we just set the constraint to hostname:LIKE:.* so that it doesn't really constrain the tasks, but marathon is happy that it has a constraint.

I'm not 100% positive, but think I see this happenning with removing cmd, too.

This issue seem to be also blocking terraform marathon provider from removing constraints. It's possible to change, but removal fails.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-1722. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-1722. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Remove 5.x references from documentation

On netty.io I can see that there is a user guide for version 5.x but I don't see any branch for this version in this git repository. Which branch contains code for 5.x version?

https://github.com/netty/netty/issues/4893

Thanks @bk1te.
We should clean up the docs and remove references to 5.x

@trustin should I take care to update the site ?

@normanmaurer Yes, please. Good time to test whether the fix I pushed works for you.

How about the milestone of 5.0.0 ?

@hepin1989 Removed 5.0.0.Final, closed 5.0.0.Alpha3, removed milestone from unresolved 5.0 issues.

@trustin  When the next version of 5.0.0 will be released? Thanks.

@tiecai nothing planed yet as we not even working on 5.0 atm. Please use 4.0 or 4.1

@normanmaurer  Understand. Thank you!

was done


chore: Remove serde from noirc_frontend

Description

Problem*

Resolves
Summary*

Follow on to #2373 that removes the serde from the frontend. The project continues to compile, so I don't think serde was required here.
Documentation

[ ] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

This doesn't actually depend on #2373, right? Could we rebase this onto master?

Could we rebase this onto master?

I can try, but I forget if there were other uses of derive(serde) in my other changes.


Moment creates invalid dates when using locale formatted string

JSFiddle
Formatting a moment based on its locale and creating a moment object from the formatted one results in an invalid moment.
I would have expected locale formats to be taken into account when creating the moment. Is my assumption wrong?
Similar, perhaps related, to #3487?
console.log( (new Date()).toString())
console.log((new Date()).toLocaleString())
console.log( (new Date()).getTimezoneOffset())
console.log( navigator.userAgent)
console.log(moment.version)

Outputs

Mon Dec 19 2016 22:26:20 GMT+0000 (GMT Standard Time)
19/12/2016, 22:26:20
0
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36
2.17.1

Moment does't know how to parse arbitrarily formatted strings. This should work though:
 var m = moment(formatted, "L");

Why is using a format from a locale (which is set and expected to be used globally) considered arbitrary formatting?

First because it's not going to speculatively parse "L", "LL", "LLL", "LLLL", "l", "ll", "lll", "llll", "LT", and "LTS" just in case that's what you happened to pass. Second, it would be pretty weird for the formats of accepted to be contingent on some global state; that's a recipe for confusion.

Thank you for the information. Keep up the good work!


issues in decoding base 64 html body

Hy!
I am not sure this is the issue in the library or in my code.
I am able to get the HTML body of the email replied to without any issues. But when my HTML body content type is base 64 encoded then I am facing issues. I am not sure why this is happening. I am using SendGrid API for the inbound parser. SendGrid sents me HTML body but now they are sending base 64 encoded HTML content-type-transfer.
I read zbateson documentation and I found that whether your content-transfer-type is base64 encoded or decoded it will give you the HTML content.
Can please anyone help.
Thank You

Hi @Hazii-197 --
Are you facing an issue with mail-mime-parser?  Most of your posting seems to be about SendGrid.  Documentation for this library is on the front page readme and on https://mail-mime-parser.org

Yes, mail-mime-parser will automatically handle encoding (transfer encodings and charsets) when reading parts if that's the question also :)

Thanks for your reply. I am in discussion with SendGrid customer support and they said they have no control. the email that replied is sent to the webhook URL they didn't make any modifications to the email. :(

I'm also seeing this issue.
Automatic Base64 decoding works if there is no Content-Type header present. As soon as you add a Content-Type: text/html; charset=utf-8, getTextContent() starts returning null as the body when Content-Transfer-Encoding: base64 is also present.

Hi @ilmiont --
Could you provide a more concrete example?  We have a test case for a text/plain that's base64 encoded here:
https://raw.githubusercontent.com/zbateson/mail-mime-parser/master/tests/_data/emails/m0003.txt
This passes fine.  I think the original issue in this ticket was something else, and what you're describing may be something different too, so if you could provide an example of it happening (maybe rewrite m0003.txt to where it fails?) that would be helpful.

Hi @zbateson
Thanks. I agree that m0003.txt parses OK as-is.
If you modify line 7 to Content-Type: text/html, parsing breaks. This actually seems to happen whenever Content-Transfer-Encoding is set - this isn't limited to Base64, as I've seen the same behaviour with quoted-printable messages too.
Modified email: m0003_1.txt
Package version in composer.lock is 1.3.2.
Repro code
use ZBateson\MailMimeParser\Message;

$message = Message::from(file_get_contents((__DIR__ . "/m0003_1.txt")));
$content = $message -> getTextContent();

// $content is NULL

Aah, yeah that makes sense sorry.
The correct method you're looking for in that situation is $message->getHtmlContent() (the message could have two alternative parts, one text, one html, just one text or just one html.

Hmm yes, but getTextContent() works to extract the plain text part from a text/html email, if there's no Content-Transfer-Encoding header. I'll add more examples tomorrow.

Please reopen if there's an issue.