Vertical bracket pair guides are invisible on non-indented lines. They can't draw in the gutter I guess.

edit from @hediet, details from this comment:

Anyway, I figured out the problem, bizarrely. Changing the font family or the zoom level somehow breaks rendering of the line. Look at the settings:

window.zoomLevel deleted:

Restoring window.zoomLevel and deleting editor.fontFamily instead:

So apparently we are looking at a layout bug. Maybe due to window scaling factor + subpixel rounding issues, that seems plausible.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.63.0 (user setup)
OS Version: Windows_NT x64 10.0.19042

Steps to Reproduce:

Follow the steps outlined in the change log to enable bracket pair guides.
Open a file with brackets and multiple lines between them. A vs code settings file (settings.json) is a good example since you'll need to open it to set these settings anyway.
Make sure the brackets are not indented at all. Like, no control characters before the bracket. If both brackets are the first character on the line, their vertical bracket pair guide is invisible.
In settings.json it's easy to see, as the settings are all in a single object. There is no vertical bracket pair guide visible. But if you just hit Ctrl+A and Tab, suddenly the bracket pair guide is visible.

I did read the changelog for the Oct and Nov updates, and the whole blog post on the new bracket pair colorizer feature. I searched vigorously for a setting I might have missed, so I don't think one exists. I believe it's worth adding one. Well personally I think showing guides for all lines should be the default behavior, but maybe that's more controversial than I think. I can understand how it might seem superfluous or even annoying if you're dealing with a large file where everything or almost everything is wrapped in a single bracket pair, like an HTML file (although I think bracket pair guides don't even show for HTML tags by default).
I believe the inconsistency looks a little sloppy, like it might be an accident (not saying it is, but I usually try to avoid the appearance of unintended behavior). Functionally it's not a huge deal, but sometimes it makes a difference. For me, if I'm working with javascript modules, often there are gonna be a lot of top-level functions, objects, classes, etc. For procedural style modules, sometimes it's a very big file and even though there is a great number of top-level blocks, many are still long enough that the contents can't all fit in the viewport at once. I use 4 spaces for tabs for this exact purpose, but tab size 2 is the norm in most projects I work on or with. So the bracket pair guides are helpful to me for just being able to see at a glance whether I'm still looking at a single block.
I heard about the bracket pair guide feature a little late, from reading this article, which makes the new feature seem like a complete substitute for similar extensions. Before this feature was added to VS Code, I was using this extension. It included a setting bracket-pair-colorizer-2.showBracketsInGutter which does what you'd expect. So I'm inclined to continue using that extension, even though it's much slower and has visual bugs.

/assign @hediet

I tried Bracket Pair Colorizer 2 but I didn't see how it works differently from the native implementation. Can you include a screenshot?

Yes, a screenshot of the current behavior and the desired expected behavior would be nice.

Are you sure this is an error? Indent guide in the far left margin works for me:

No, like the title and the body of the post both say, I'm talking about the vertical line. The horizontal line works perfectly fine for me. You have to switch a preference, editor.guides.bracketPairsHorizontal. Read the articles I linked.

Anyway, I figured out the problem, bizarrely. Changing the font family or the zoom level somehow breaks rendering of the line. Look at the settings:

window.zoomLevel deleted:

Restoring window.zoomLevel and deleting editor.fontFamily instead:

So apparently we are looking at a layout bug. Maybe due to window scaling factor + subpixel rounding issues, that seems plausible.

For what it's worth, for window.zoomLevel the minimum value that results in the vertical line being visible on the gutter (as desired) appears to be an irrational number. I'm not gonna spend eternity on trial & error for this but I went down to 8 decimal places: "window.zoomLevel": 1.03200074
Which makes me even more suspicious this has something to do with subpixel rounding.

By the way, as for your complaint about step #3, I am really not sure what you mean. That is the whole point. I'm saying to get rid of any characters on the line preceding the brackets, so that the bracket guide will be drawn on the very first column. That's the goal. I described it in two ways to increase the chances of people understanding what I'm talking about. I'm not saying either/or, I'm saying "Make sure the brackets are not indented at all. In other words, no control characters should exist before the bracket."
I guess the reason you didn't reproduce this is because it doesn't happen with the default window.zoomLevel.

I'm using the active setting for editor.guides.bracketPairsHorizontal and yet a bracket pair on the same line does not yield a horizontal bar. Can you reproduce that?

Yeah I do see what you're talking about. Separate issue but yeah I agree that's a deviation from BPC2. I assume someone just decided bracket pair guides aren't necessary when everything is on a single line. I guess whoever made that decision hasn't spent much time reverse engineering minified code. Or maybe it's a performance thing.

I guess whoever made that decision hasn't spent much time reverse engineering minified code.

I recommend using a formatter that can generate a source map for that.

@hediet Is there an issue up on this missing horizontal indent guide somewhere else, you mean?

@silkfire #136475

I guess whoever made that decision hasn't spent much time reverse engineering minified code.

I recommend using a formatter that can generate a source map for that. But this does not have much to do with this issue, so lets discuss this in the existing issue for this feature request.

 But I actually agree that it makes more sense for wrapped lines, or at least lines that are long enough to horizontally overflow the editor if wrapping is disabled. That would be good.
To clarify, I don't think this is just a zoom issue. Because I was able to get the line to appear by either 1) changing the zoom value to something else, or 2) changing the font family. Font faces affect the size of the gutter, presumably because the gutter flexes with the width of the line numbers. So if I pick a font face with different 0-9 glyph bounds, it's gonna change the gutter bounds. Likewise, I guess glyph bounds could affect the column width in which the line is displayed. But either way I think it has to do with subpixel rounding because as I increase or decrease the zoom value or font size, it alternates between showing the line and not showing the line. Which is just like other subpixel rounding issues.
As an example, if I set window scaling to 150% and make a box in HTML with a 1px outline, the 4 edges will usually not all be rendered with the same ultimate width. The 1.5px width for a given edge will be rounded up to 2px or down to 1px depending on where the edge is in the layout. There's a blog post about how Firefox circumvents this in its border property that I found really useful in understanding why this happens. Basically with the box example, if I'm getting 2px on the top edge, I can increase the box height by 0.5px and when it reflows it'll render at 1px. Then if I increase by another 0.5px it'll go back to 2px, and so on.
So I think what I was seeing when experimenting with different window.zoomLevel values is analogous to that. The irrational numbers that were working for me weren't meaningful, they were just changing the layout ever so slightly so that it moves over by half a pixel and rounds up to 1px instead of rounding down to 0px. If something (idk what) was a little different, I think instead of sometimes rendering and sometimes not at all, it would sometimes render normally and sometimes render at double width. The actual implementation is way outside my realm of understanding but I guess it could do something like what Firefox does with border rounding to achieve a consistent width.

Turn of this in vs code settings

Set active in this vs code settings.

That's just the setting to enable bracket pair guides. This bug is about bracket pair guides on unindented columns being clipped by the gutter at certain zoom/font size factors. I speculated that it's a subpixel scaling issue.

/duplicate #139067


start of the pubsub proposal

This is part of #247 and is addressing #249
You can see the rendered version of the file: here.
Signed-off-by: danbugs<EMAIL_ADDRESS>

The concluded interface (i.e., from wasi-messaging) very closely resembles the already existing one — w/ the only differences being:
(1) the change from payload to event, and
(2) creation of the channel type to unify the mq, and pubsub capabilities.
... so I'm closing this issue, and will get to work on the implementation.


Not recognising card.io in project

General information

SDK - 5.4.1
iOS 10 / Xcode 8.2.1

Issue description
It's probably user error but I've followed the steps to include this project and it doesn't seem to load in. I've tried to add the CardIOPaymentViewControllerDelegate but it doesn't recognise it.
I have import cardio.h inside the bridging header and the pod files exist.

Solved by recreating the bridging header again 👍


Delete function missing

Hello, I'd like to delete some specific words I never use in my native language and furthermore personnalize the emojis available on the dictionnary, however I couldn't find such an option in the settings. There's only "Delete unselected" or "Delete all", which isn't what I wish for. I looked up the guide, there's apparently an export and delete function that does not appear in my settings. Is there something I'm missing?
Thank you for your time.

The new stuff is available in v29.0. If you are using the Github version, install it from the link. Otherwise, you will have to wait for about a week until it appear in F-droid.
Have in mind you can only delete the words you have added with the Add function. It is not possible to delete factory words.
Also, if you think there are misspelled, wrong or otherwise unusable words, you are welcome to report them. I don't speak all the supported languages and even if I did, it would have been impossible for me to verify every single word in every language. User contributions are most helpful in this regard.

This new version indeed add the delete and export functions and it also seems to have fixed the unusable words I had, however I am not able to register special characters anymore, so I can not add personnalized emojis to the dictionnary like before

I am not able to register special characters anymore, so I can not add personnalized emojis to the dictionnary like before

Do you mean all special characters or some specific emoji? Adding words is restricted to actual words consisting of letters and emoji. However, detecting emoji is a bit difficult and I might have missed something. This is why I am asking for an example.
Or do you mean you can not add words at all? Of so, please check #456. You may be experiencing the same problem.

I can add words but not special characters. For exemple, if I try to add ":/" or a more detailed emoji like "＼(★^∀^★)／", it won't detecte it as an actual word. If I try to add ":DDD", it will only add "DDD" to the dictionnary. If I am not mistaken, the older versions of the programm could detect special characters.

Oh, I am not even sure what "＼(★^∀^★)／" is and I didn't know this is considered an emoji. And yes, special characters are restricted for security reasons. It might have been possible to add just anything in early versions of TT9, but not anymore.
I may consider a new category of added words, for example, "special chars" or something, where one could add emoji like the ones you mention, as well as email and other non-word words.
But anyway, this is the fourth topic we are discussing here and it has nothing to do with the title. There is nothing to do regarding the original questions, so I am considering the issue done.
If you would like to request a new feature, like adding those special char emoji, please create a new issue, just for that. Let's keep the board organized.


vsphere: provision a vm from a template already installed?

I can easily create a template within vsphere, but it doesn't seem to be anyway to easily use libretto to provision it. it be nice if I could skip the ovf local file and just specify the template on the server.

i.e. I'd expect to be able to do something like this written in python
https://gist.github.com/snobear/8788977

This is what libretto does now to provision a vm.

Generates a template name, (vm.Template + "-" + selected_datastore_name)
checks if the vm with the template name exists or not
if No, creates the VM with template name and mark it as template
if yes, skips the template vm creation
Clones the template VM to create the vm specified in the vm.Name and powers it on

Currently it doesn't add the ram, no of cpus, other vm configs to the clone vm configuration.
To make things work in libretto the below changes will be required.

Addition of two more configurations to cisp = types.VirtualMachineCloneSpec which is being used while cloning the vm

VirtualMachineConfigSpec which will have ram, cpu and other information
CustomizationSpec which will have the IP details

	cisp := types.VirtualMachineCloneSpec{ 		Location: relocateSpec, 		Template: false, 		PowerOn:  false, 	}

Generating the template name imposes a restriction on the name of the template.
If it is not a use case, can we use vm.Template instead of generating the template name ?

So perhaps the correct way to go about this is

make a PR that enables using a precreated template instead of using an OVF file to upload and create it.  This wouldn't remove the current functionality, but would only work for one or the other (i.e. if both fields are specified, it would return an error)

another PR that provides more flexibility in terms of the configspec / customationspec.

thoughts?

In looking at the code closer, it seems that it can really already handle case 1.  If SkipExisting == true, then the OvfPath variable doesn't matter.  Either it will fail the template doesn't exist and when it tries to upload the ovf specified it will find its not valid or it will exist and the OvfPath will be ignored.

Yes that is correct, if skipExisting is true then it uses the existing template. Only that the template name is generated from vm.Template and datastore name. So if the template vm is created via some other way (not libretto), then it should have the name of the datastore in the end to make it work here in libretto.
var createTemplateName = func(t string, ds string) string { 	return fmt.Sprintf("%s-%s", t, ds) } . . . template := createTemplateName(vm.Template, d)
d is datastore.


Releasing rain 0.0.2

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   76.47%   76.47%
=======================================
  Files          11       11
  Lines          85       85
=======================================
  Hits           65       65
  Misses         20       20

Impacted Files
Coverage Δ

rain/version.py
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18ffba7...6b66196. Read the comment docs.


Rework "hello" samples to separate starter and worker processes

Is your feature request related to a problem? Please describe.
Initially we hoped the browse-ability of having several files right next to each other like normal Python scripts showing how things are done would be worth not doing the best practice of separating starters and workers (and just adding a comment to explain).
Describe the solution you'd like
Probably need a folder per sample with separate files for starter, worker, and maybe workflows, and maybe activities. Don't need to keep under "hello" and don't have to keep separate (e.g. can combine signals and queries).

I'm -1 on this -- IMO the simple structure is very valuable -- it makes it easy to understand what's going on and makes it clear that Temporal need not be complex or cumbersome.


Firebase CORS on website

Hello,
I'm using this plugin in my ionic capacitor/angular project, everything is setup properly, the firebase analytics is working on iOS and Android. However I keep getting CORS error in my website (screenshot below)

my code:
constructor(private appInsightsService: AppInsightsService, private fb: Facebook, private router: Router) {
    this.initFb();
    this.router.events.pipe(filter((e: RouterEvent) => e instanceof NavigationEnd)).subscribe((e: RouterEvent) => {
      this.setScreenName(e.url);
    });
  }

async initFb() {
    if (environment.production) {
      if ((await Device.getInfo()).platform == 'web') {
        FirebaseAnalytics.initializeFirebase(environment.firebaseConfig);
      }
    }
  }

logEvent(name: string) {
    FirebaseAnalytics.logEvent({
      name,
    });
  }

setScreenName(screenName) {
    if (environment.production) {
      FirebaseAnalytics.setScreenName({
        screenName,
      });
    }
  }

Any ideas what i'm missing?

Apparently this has been fixed in firebasejs v9.8.2: https://github.com/firebase/firebase-js-sdk/issues/5020#issuecomment-1148546819
I guess updating the versions here would fix the problem:
https://github.com/capacitor-community/firebase-analytics/blob/0e30af2cc8d290eb019162a02e41eb32f7d020f1/src/web.ts#L20-L29


Packages with hyphens don't work

I have a package abc-xyz, but this tool strips off the trailing -xyz and only creates an folder & entry for abc.
https://github.com/colinhoglund/piprepo/blob/master/piprepo/utils.py#L7
I wonder why you do the extra .split('-')[0] when PEP503 doesn't have that?
https://www.python.org/dev/peps/pep-0503/#normalized-names
My requirements.txt has:
--extra-index-url http://localhost:8080/simple
abc-xyz==1.0.0
And if I do python -m SimpleHTTPServer 8080, I can see that when I try to do a pip install -r requirements.txt it tries to "GET /abc-xyz/" but gives a 404 since only /abc/ exists.

This is a bug.
I made the incorrect assumption that I could use - as a separator between project name and version in downloaded packages, and therefore was getting the project name by using .split('-')[0] on file names. I would appear I need to be a bit more deliberate about determining the project name.

@mbjorge Thanks for pointing this out. I have created a PR that should address the issue. Would you mind giving it another try when you get a chance?

Worked like a charm, thanks for the quick fix :)
(and I learned I can install packages diretly from github, so that was neat: pip install --upgrade https://github.com/colinhoglund/piprepo/tarball/fix_project_naming)

Great, thanks again. I'll merge it and ship it to PyPI.


panel:close bug

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: 1.5.2

Platform and Target: intel xdk : cordova

Live Link or JSFiddle/Codepen: https://codepen.io/anon/pen/ZLWePg

What you did
i added those lines
$$('.panel-right').on('panel:close', function () {
myApp.alert('Left panel is closing!');
});
Expected Behavior
i should have an alert when the panel is closed
Actual Behavior
i have not recieve any alert

is no one here to answer ?

I'll try soon. please check 1 hour later.

just write 'closed' for 'panel:close',
i think panel:close is action, 'panel:closed' is event. 'closed' is fits better.

@bigbossmaher i see you use 1.4.2 in your codepen. Such event supported since v1.5.0


Added jitpack tag to readme

Changes proposed in this pull request:

Add jitpack info to readme

@gnosis/mobile-devs

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #12   +/-   ##
=========================================
  Coverage     66.15%   66.15%
  Complexity      142      142
=========================================
  Files            48       48
  Lines          1052     1052
  Branches        185      185
=========================================
  Hits            696      696
  Misses          268      268
  Partials         88       88

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 960ebae...22d0eaf. Read the comment docs.


Request to review and include in "Student Works" section

@simoninithomas ,
Have tried training a Decision Transformer using trading data. FinRL packages and decision transformer related tutorial from Hugging Face were of great help in the process.
Request to please check if this could be included in "Student Works" section.
Have a great day !!

Hi, LGTM I'm adding it to the examples I'm just checking that the preview is correct.
Have a nice day,

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@simoninithomas  ,
Thanks for taking time to review. Checked PR live and image source link had an issue. Have made changes to fix that.
Please check and let me know for any further changes.

@ra9hur  it LGTM now we can merge it


Dependencies not installed alongside depthai

Built and installed following instructions from the readme:
$ sudo apt install libusb-1.0-0-dev libopencv-dev
$ git clone git@github.com:luxonis/depthai-core
$ cd depthai-core
$ git submodule update --init --recursive
$ cmake -S. -Bbuild -D'CMAKE_INSTALL_PREFIX=/usr/local'
$ cmake --build build --parallel 30
$ sudo cmake --build build --target install

Attempt to compile anything which includes depthai/depthai.hpp such as:
// test.cpp
#include <depthai/depthai.hpp>

int main() {
  return 0;
}

And the result is missing headers for nop.
$ g++ test.cpp
In file included from /usr/local/include/depthai-shared/common/Point3f.hpp:7,
                 from /usr/local/include/depthai-shared/common/Extrinsics.hpp:6,
                 from /usr/local/include/depthai-shared/common/CameraInfo.hpp:4,
                 from /usr/local/include/depthai-shared/common/EepromData.hpp:7,
                 from /usr/local/include/depthai/device/CalibrationHandler.hpp:6,
                 from /usr/local/include/depthai/depthai.hpp:9,
                 from test.cpp:2:
/usr/local/include/depthai-shared/utility/Serialization.hpp:9:10: fatal error: nop/serializer.h: No such file or directory
    9 | #include <nop/serializer.h>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.

These deps are clearly cached somewhere by cmake as the library built fine. Could they also be installed alongside depthai?

Sorry about the delay.  Asking.

@NatalieWolfe do you consume the library with CMake afterwards or just point the include path to the installation directory (or leave it as is as that is the default)?
We don't install the rest of the dependencies to  the same installation directory, but to [prefix]/lib/cmake/depthai/dependencies/... (along some other paths) which you should point to manually if not using CMake based build system to consume depthai. Refer to: https://github.com/luxonis/depthai-core#non-cmake-integration-visual-studio-xcode-codeblocks- for more details

My project is using Bazel as its build system. Typically, CMake projects are trivial to integrate into a Bazel project as there is a build rule specifically for CMake. I have not encountered Hunter before, and it does not behave well with Bazel so I opted to try a system install of depthai instead.
After adding build rules for the various things under /usr/local/lib/cmake/depthai/dependencies and /usr/local/include/depthai-shared/3rdparty I have it building now. Apologies for missing that in the instructions and thank you for your help.
Now to figure out why my desktop wont detect the camera but my laptop does...

You may also consume DepthAI project after its installed (or only just build) if Bazel supports CMake.
But not as adding it to the build system itself and building it, but just "find_package" consuming it (if Bazel supports that CMake part).
Glad to hear you got it working:)
(Note - check if udev rules are installed if perhaps your desktop is Linux and laptop Windows/macOS)

Bazel knows how to configure, build, and extract artifacts from projects with CMake, but it doesn't support CMake's packaging system. Bazel tries to treat it as a fancy Makefile.
The udev rules were indeed what I was missing. Both machines are linux, but I had played with the python demo on the laptop and that instructs you to add the rules if they're missing. Up and running now, thank you!

@cyberbeat
nop/serializer.h is available under: lib/cmake/depthai/dependencies/include/. You must link to this target (with CMake, lib/cmake/depthai/dependencies/lib/cmake/libnop/libnopConfig.cmake) or if you are specifying include flags, add: -I lib/cmake/depthai/dependencies/include as well.
The 3rdparty folder, is a subset of shared external dependencies. Those are a bit misplaced and should preferably be in either private dependency or external.
BUILD_SHARED_LIBS is standard CMake variable: https://cmake.org/cmake/help/v3.0/variable/BUILD_SHARED_LIBS.html, which is why it isn't explicitly documented again.

@themarpe
this seems more like an ugly workaround than a solution? Or at least it should be documented? Please notice that the nop/serializer.h is included from the
#include <depthai/depthai.hpp>
header. It should really "just work" if I have in CMakeLists.txt:
find_package(depthai CONFIG REQUIRED)
...
...
target_link_libraries(myproject PRIVATE ${DEPTHAI_SHARED_LIBS})

Perhaps you could set some include dir variable in your cmake files, which you could document, like
INCLUDE_DIRECTORIES(${DEPTHAI_INCLUDE_DIR})
like it is does in some other projects?

About the BUILD_SHARED_LIBS: the cmake documentation says, that you should explicit set this variable as an option:
https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html
If present and true, this will cause all libraries to be built shared unless the library was explicitly added as a static library. This variable is often added to projects as an [option()](https://cmake.org/cmake/help/latest/command/option.html#command:option) so that each user of a project can decide if they want to build the project using shared or static libraries.

@cyberbeat
libnop is included as part of depthaiDependencies.cmake as well as specified as PUBLIC linking.
This should indeed work out of the box.
Do you mind posting an MRE where this happens? I haven't stumbled across this yet.
Which CMake version are you on?

About the BUILD_SHARED_LIBS: the cmake documentation says, that you should explicit set this variable as an option

It doesn't say you should but you may - but I agree, its nice having that as option so it shows up in eg ccmake et al.
Do you mind opening a PR against develop with this added?

Sorry, my cmake file was wrong, so first problem seems solved. The second one is a one liner, for example
option(BUILD_SHARED_LIBS "Build shared libs" OFF)
or
option(BUILD_SHARED_LIBS "Build shared libs" ON)


When serialize interface to *interface there is a panic

When serialize interface to *interface there is a panic
type StructWithInterface struct {
	SomeAbstract interface{}
}

type StructWithInterfacePtr struct {
	SomeAbstract *interface{}
}

i have created the PR https://github.com/firmanmm/go-mirror/pull/3


How to add title below each image child?

Hi, @szugyi
I'm glad after zooming child views when rotate successfully. And now, I want to add a title or a textview below each image child. I tried to make a customview extending RelativeLayout (contains an imageview and a textview) but the height and width childs are not fill. Do you have any ideas for me?
Thank you very much.

Sorry for the late reply,
Try to use TextViews, as childs in the CircleLayout. Set the image you want for each TextView using the drawableTop attribute of the TextViews. I think it should work that way.


FAQ Improvements

Improvements to our FAQ's based on AI feedback

Group chats
Smart contract wallets

@jhaaaa thanks for the suggestions! all approved.


Skip group functionality when passing --help to a subcommand

If a group performs some preprocessing before invoking a subcommand, is it possible to skip this if the --help option is passed to that subcommand?
In click 5.1, the following would, when called with python script.py subcmd --help, print the subcmd help without printing the "Perform preprocessing" string.
def detect_subsequent_help(ctx):
    try:
        return any(helpname in ctx.args for helpname in ctx.help_option_names)
    except:
        return False

@click.group()
@click.pass_context
def cli(ctx):
    if not detect_subsequent_help(ctx):
        click.echo('Perform preprocessing')

@cli.command()
def subcmd():
    click.echo('Perform subcommand functionality')

Is there a way to achieve the same outcome in click 6.7?
#473 suggests it is not possible, but I ask anyway in case the --help opiton is a special case. Alternatively, is it possible to view callbacks from the Context object, such as through MultiCommand.get_command() and Context.invoked_subcommand?
#108 suggests decorators as a solution, but I'm still struggling to detect the --help option on a subcommand before invoking the decorator for that subcommand.
My attempt is here:
class HelpFinder(object):
    def init(self):
        self.help = False
        self.help_command_name = None
        self.ctx = None
pass_help = click.make_pass_decorator(HelpFinder, ensure=True)
def help_option(f):
    def callback(ctx, param, value):
        help_finder = ctx.ensure_object(HelpFinder)
        if value:
            help_finder.help = value
            help_finder.help_command_name = ctx.command.name
            help_finder.ctx = ctx
        return value
    return click.option('--help/--no-help',
                        expose_value=False,
                        help='Eager option to stop command execution and print help',
                        callback=callback)(f)
def real_help_option(f):
    f = help_option(f)
    return f
@click.group(add_help_option=False)
@real_help_option
@pass_help
def cli(help):
    if not help.help:
        click.echo('Perform preprocessing')
    elif help.help_command_name == 'cli':
        click.echo(help.ctx.get_help())
@cli.command(add_help_option=False)
@real_help_option
@pass_help
def subcmd(help):
    if not help.help:
        click.echo('Perform subcommand functionality')
    elif help.help_command_name == 'subcmd':
        click.echo(help.ctx.get_help())

It's not currently possible to use backticks for proper code formatting inside a <details> code block: https://github.com/dear-github/dear-github/issues/166#issuecomment-326108215.
The second code block is properly reproduced here:
class HelpFinder(object):
    def __init__(self):
        self.help = False
        self.help_command_name = None
        self.ctx = None

pass_help = click.make_pass_decorator(HelpFinder, ensure=True)

def help_option(f):
    def callback(ctx, param, value):
        help_finder = ctx.ensure_object(HelpFinder)
        if value:
            help_finder.help = value
            help_finder.help_command_name = ctx.command.name
            help_finder.ctx = ctx
        return value
    return click.option('--help/--no-help',
                        expose_value=False,
                        help='Eager option to stop command execution and print help',
                        callback=callback)(f)

def real_help_option(f):
    f = help_option(f)
    return f

@click.group(add_help_option=False)
@click.pass_context
def cli(help):
    if not help.help:
        click.echo('Perform preprocessing')
    elif help.help_command_name == 'cli':
        click.echo(help.ctx.get_help())

@cli.command(add_help_option=False)
@real_help_option
@pass_help
def subcmd(help):
    if not help.help:
        click.echo('Perform subcommand functionality')
    elif help.help_command_name == 'subcmd':
        click.echo(help.ctx.get_help())

thanks. i am working on your issue now.

i agree with the docs. It does not appear to be possible.

sorry :disappointed:


CMS-Pages in Backend do not load if many products are assigned to custom product template

PHP Version
8.0
Shopware Version
<IP_ADDRESS>
Expected behaviour

Actual behaviour
We have about 9.000 products spread over two sales channels. Each of these products is assigned to a custom product template, which has been copied from the default product template.
When opening the cms pages section in backend, it loads a long time and retrieves about a 100MB data in the request to load the cms pages. Sometimes this request fails completely.
If think this behaviour is similar to: #2016
How to reproduce

Hey @ttheuerkauf
I'm faced this issue too and managed to fix it. Now I'm trying to fix cms page detail performance issue.
I can send you the patch file with cms page listing performance issue fix.

Hi @yourborjia,
we also have a performance problem on the cms detail page, seems to be the same reason. Are you going to create a pull request here to fix both errors?
In this case we can wait until it is released officially :-).
Thank you very much and best regards!

@ttheuerkauf here is PR.

OK, thank you very much! :-)

It would be better to define the default Listing/Product CMS pages in the Sales Channel Config, so an association would not be necessary.

Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know.
Thank you again for your valuable feedback.


Add setting to regulate Kafka committing policy

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):

Improvement

Short description (up to few sentences):
The new setting kafka_commit_every_batch allows to set commit mode: after every batch of messages is handled, or after the whole block is written to the storage. It's a trade-off between losing some messages or reading them twice in some extreme situations.

Fixes #5100

Isn't it better to change to zero by default?

Isn't it better to change to zero by default?

I will try and check how it correlates with skip_broken_messages feature.


Code | Pyramid Pattern 1

@aryashah2k  Can you please assign me all the issues for pyramid pattern(from 1 - 93, excluding those which are already been assigned) ??

Okay sure, but please be sure if you will be able to do all. Also you can make PRs for 10, 20, 30 and 40 patterns for corresponding SWOC Scores mentioned by me in the swoc channel for patternhouse

Okay sure, but please be sure if you will be able to do all. Also you can make PRs for 10, 20, 30 and 40 patterns for corresponding SWOC Scores mentioned by me in the swoc channel for patternhouse

How much time will I get to finish all these issues?? Can you please provide a deadline time.

SWOC says that not more than one week after assigning of issues. If 7 days pass I have to reassign to someone else. Do read the guidelines documents for participants sent by SWOC on the discord channel


Random Crash in X509_NAME_cmp OpenSSL version 1.1.1

Hello All,
We are facing a random crash in X509_NAME_cmp function in "openssl/crypto/x509/x509_cmp.c" file.
The OpenSSL version is 1.1.1g now (This crash came after migrating from 1.0.2 to 1.1.1).
It is our custom build for ARM architecture.
Here is the gdb output for this crash(captured from OpenSSL version 1.1.1g). We have checked also 1.1.1k and the crash still there.
(gdb) bt
#0  0x000e09a8 in X509_NAME_cmp ()
#1  0x000e16bc in x509_object_cmp ()
#2  0x000ad50c in OBJ_bsearch_ex_ ()
#3  0x000dc9c4 in internal_find ()
#4  0x000e1f54 in x509_object_idx_cnt ()
#5  0x000e201c in X509_OBJECT_retrieve_by_subject ()
#6  0x000e1b18 in X509_STORE_CTX_get_by_subject ()
#7  0x0000a098 in X509_STORE_get_crl ()
#8  0x0000a274 in verify_callback ()
#9  0x000e5fd4 in internal_verify ()
#10 0x000e3bf4 in verify_chain ()
#11 0x000e3dbc in X509_verify_cert ()
#12 0x000221b8 in ssl_verify_cert_chain ()
#13 0x00040530 in tls_process_server_certificate ()
#14 0x0003d320 in read_state_machine ()
#15 0x0003cf70 in state_machine ()
#16 0x0002b0ac in SSL_do_handshake ()
#17 0x0000adf0 in fd_ready_for_connect ()
#18 0x00014b44 in event_process_active ()
#19 0x00014c04 in eloop_event_loop ()
#20 0x00008548 in main ()
Could you please help us to understand what is the problem or give some hint on how to proceed with this?
We found an old discussion about a similar issue here: https://mta.openssl.org/pipermail/openssl-dev/2016-February/005213.html

Your func verify_callback is implemented by yourself, it is hook byvoid SSL_CTX_set_verify(SSL_CTX *ctx, int mode,                         int (*cb) (int, X509_STORE_CTX *)). It may has  a problem. How does it work?

Is this still valid with current release of openssl-1.1.1? Would you be able to build it with debug information to produce better stack trace?


Problems with setup.py compiled by pb_lib

Hello, when I installed the pb_lib compilation, I reported an error that the cuda version of 11.7 was detected, but the requirement was 10.2. May I ask how it was compiled on the 3090 graphics card

Hi, thanks for your attention. Could you provide the screenshot of that error and the version of nvcc, cudatoolkit and pytorch? By the way, this kind of problem is mostly caused by version compatibility. You can try to install a 10.0 cuda and modify the setup file, or increase the versions of cudatoolkit and pytorch.

Thank you for your answer. I understand the situation. But my server does compile with cuda version of 11.7, my nvcc is 11.7, and pytorch will report errors regardless of 1.10.0 or later. Below is a screenshot of my error. Please also understand that there is no way to execute the compiled code of 10.2.

Hi, it seems that your Pytorch version does not match. Please check the detail version of your Pytorch by the following command.
conda activate pbnet
conda list -e | grep pytorch
The detailed version of Pytorch should be the following pic:

You can use the following command to change the pytorch to 11.X cuda:
conda install -c pytorch pytorch=1.9.0 cudatoolkit=11.1

It seems that there is something wrong with my server:
Either conda install -c pytorch pytorch=1.9.0 cudatoolkit=11.1 or conda install -c pytorch pytorch=1.10.0 cudatoolkit=11.3
Will report an error saying that the appropriate packages cannot be found

Thanks to the author, this has been successfully resolved, the cause seems to be the -c conda-forge upgrade after the incompatibility caused by the removal, can successfully install torch=1.9.0 and compile.
Thanks again for your guidance. I have also studied in this direction for some time and made some small achievements. map has reached 55.4 network, but it is not completely open source
If you don't mind, I would like to take the liberty of adding your contact information, if you don't think it's any trouble. The following is my E-mail address<EMAIL_ADDRESS>


Deprecated

sprint 3 build 1.3.0-16022 (release cd0a6aae5)
Deprecated: Do not use $().on/off() on Brackets modules and model objects. Call on()/off() directly on the object without a $() wrapper.
at new jQuery.fn.init (/brackets.js:479:36)
at n (file:///C:/Program%20Files/Brackets/www/thirdparty/thirdparty.min.js:559:405)
at toggle (file:///C:/Users/admin/AppData/Roaming/Brackets/extensions/user/brackets-beautify/main.js:285:9)
at Object. (file:///C:/Users/admin/AppData/Roaming/Brackets/extensions/user/brackets-beautify/main.js:309:5)
/LiveDevelopment/MultiBrowserImpl/transports/NodeSocketTransport.js:87 NodeSocketTransport - start
/utils/DeprecationWarning.js:90 Deprecated: Do not use $().on/off() on Brackets modules and model objects. Call on()/off() directly on the object without a $() wrapper.
at new jQuery.fn.init (/brackets.js:479:36)
at n (file:///C:/Program%20Files/Brackets/www/thirdparty/thirdparty.min.js:559:405)
at file:///C:/Users/admin/AppData/Roaming/Brackets/extensions/user/brackets-beautify/main.js:317:9
at _callHandler (/utils/AppInit.js:93:13)
at Object._dispatchReady (/utils/AppInit.js:113:13)
at Object.eval (/brackets.js:291:33)
at j (file:///C:/Program%20Files/Brackets/www/thirdparty/thirdparty.min.js:559:26911)
at Object.k.add [as done] (file:///C:/Program%20Files/Brackets/www/thirdparty/thirdparty.min.js:559:27220)
at Object.d.always (file:///C:/Program%20Files/Brackets/www/thirdparty/thirdparty.min.js:559:28096)
/utils/DeprecationWarning.js:90 Deprecated: Do not use $().on/off() on Brackets modules and model objects. Call on()/off() directly on the object without a $() wrapper.
at new jQuery.fn.init (/brackets.js:479:36)
at n (file:///C:/Program%20Files/Brackets/www/thirdparty/thirdparty.min.js:559:405)
at file:///C:/Users/admin/AppData/Roaming/Brackets/extensions/user/brackets-beautify/main.js:323:9
at _callHandler (/utils/AppInit.js:93:13)
at Object._dispatchReady (/utils/AppInit.js:113:13)
at Object.eval (/brackets.js:291:33)
at j (file:///C:/Program%20Files/Brackets/www/thirdparty/thirdparty.min.js:559:26911)
at Object.k.add [as done] (file:///C:/Program%20Files/Brackets/www/thirdparty/thirdparty.min.js:559:27220)
at Object.d.always (file:///C:/Program%20Files/Brackets/www/thirdparty/thirdparty.min.js:559:28096)

Still showing up in Brackets 1.3

I have fixed the deprecation notices for this extension.  It will still show up but I believe it's internal code.  Thanks!


feature/improve_circle_dashboard

Improved circle dashboard #236

@kristysnet we realized the footer may disappear at the very bottom when there are many tasks, so we moved the "Get help" link into the top right user dropdown.
Unfortunately there also was a clash with CSS changes I did on "my" branch, since I extracted a collection_dashboard.scss to layout the circle, project and working group dashboard with one set of CSS rules. I'll do a write up how I imagine the CSS files could be organized/structured, and would be very happy to discuss this with you. If we have a shared understanding of what goes where we'll have much less conflicts even when working on separate branches.


[ZEPPELIN-2365] button to create note into folder

What is this PR for?
Added button to create new note into folder (home page)
What type of PR is it?
Feature
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2365
Screenshots (if appropriate)

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

Thanks for improvement @tinkoff-dwh!
Let me test and I'll give you feedback!

Cool feature! LGTM 👍

@tinkoff-dwh, Before testing, could you rebase for resolving conflicts, too? :slightly_smiling_face:

Thanks @tinkoff-dwh for quick resolving!
Let me check again if CI become green.

Tested and it's work well, LGTM!

Thanks for the new feature. LGTM and merge to master if no further discussions.


Blaze Integration

Hi, any plans to support having Blaze template side by side with Svelte? This is for projects that initially started with Blaze and is incrementally migrating to Svelte. Thanks!

Nevermind, I found out the problem, it was a config in package.json.

Nevermind, I found out the problem, it was a config in package.json.


Added python VisionBuf class

NOTE: This can't be merged until openpilot cereal is updated to latest master


fix: modules module path

This PR updates the module path used to access modules when displaying a toast message. I noticed that I received the following error message after performing actions that should have displayed a toast (ex. removing an artist from My Collection):

PR Checklist

[ ] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Updated the module path for navigation modules to be able to view toast messages

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Dev changes (Updated the module path for navigation modules to be able to view toast messages - iskounen)

  Generated by :no_entry_sign: dangerJS against 4f725f55f43a0abb7570bd8b7484b68770fd1520


GC on ARM64 based "kind of unix" system

I am sorry to bother again. After fixing some more minor issues and brush up my ARM64 assembler knowledge I was finally able to run a simple hello world on my ARM64 system without crashing. Doing things like writing to the log (the system doesn't have a text based console at all), Thread.Sleep, Environment.TickCount, printing the command line arguments etc works fine. But than I made the "mistake" to trigger the GC.
To make a long story short after some more debugging I noticed that the unwind of the stack does not work. The reason was pretty obvious. Libunwind doesn't have any information about the function were the stack walk should be started. I am aware that there are some parts missing for ARM64 targets that I need to fill but there is one question I was not able to answer so far. Does the GC only need unwind information for the managed code part? Or do I need to provide information for the C/C++ parts and even the dynamic libs of the OS? I am aware that libunwind can fetch these information by it's own. Unfortunately the function that it uses for this is not supported by the OS my system is using.  I may be able to get the unwind sections from the runtime C/C++ code.

Does the GC only need unwind information for the managed code part?

Correct.

Unfortunately the function that it uses for this is not supported by the OS my system is using

We have a local copy of libunwind under https://github.com/dotnet/corert/tree/master/src/Native/libunwind. You should be able to modify as necessary to work for you OS.

Unfortunately the function that it uses for this is not supported by the OS my system is using

We have a local copy of libunwind under https://github.com/dotnet/corert/tree/master/src/Native/libunwind. You should be able to modify as necessary to work for your OS.

I have seen it when I setup the project to compile the runtime. The issue is somewhat more complicated. There is no API call at all to get the eh_frame or eh_frame_hdr section for a loaded module. There are only some limited functions that can be used to generate a human readable callstack but only for diagnostic. I am aware that one of these many limitations might be stopping me in the end to get it fully working. But these limitations are one of the main reasons why I am even trying as there is no way at all to get any JIT based implementation running. Independent of my success I think that at least some parts of my work should be usable for other ARM64 system and can be pushed back after some cleanup.

Might be worth looking into how C++ unwinds the stack on your OS (if there's a C++ compiler). The mechanism used for unwinding C++ exceptions might be usable for the GC and .NET exception handling too.

Might be worth looking into how C++ unwinds the stack on your OS (if there's a C++ compiler). The mechanism used for unwinding C++ exceptions might be usable for the GC and .NET exception handling too.

Yes, there is a C++ compiler. The toolchain is LLVM based and the executable files are ELF with eh_frame and eh_frame_hdr sections. I assume the even use the LLVM unwind to handle the c++ exceptions. Based on everything I can see there is nothing special here. The eh_frames just contains regular CFI data and the libunwind that is part of corert can parse them. The stack itself seems pretty much build up in the same way as ryujit does it. I can see functions from the ilcompiler and the c compiler there and jump to any of them. breakpoints and line stepping are working, too. The only thing that doesn't work right now are inspecting of variables. But as Debug.WriteLine is working I can somewhat handle this until I find a better solution.
The primary issue is that there is just no way to get the eh_frame data of the system modules and only an indirect to get it for your own executable. But based on jkotas I just need the unwind information for the managed code that is generated by the ilcompiler.
And the issue with that is that ryujit so far doesn't generate CFI frame information for ARM64. So this would be the starting point for me to get the CG working.

Looks like it's working now. Thanks for the help.


Reduce the batch-size of the org-id-populator job

Secure Coding Practices Checklist Link

https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

[ ] Input Validation
[ ] Output Encoding
[ ] Authentication and Password Management
[ ] Session Management
[ ] Access Control
[ ] Cryptographic Practices
[ ] Error Handling and Logging
[ ] Data Protection
[ ] Communication Security
[ ] System Configuration
[ ] Database Security
[ ] File Management
[ ] Memory Management
[ ] General Coding Practices

Codecov Report

Merging #251 (ceea59f) into master (209c0c9) will increase coverage by 23.73%.
The diff coverage is 69.21%.

@@             Coverage Diff             @@
##           master     #251       +/-   ##
===========================================
+ Coverage   50.14%   73.87%   +23.73%
===========================================
  Files          13       25       +12
  Lines         357      731      +374
===========================================
+ Hits          179      540      +361
- Misses        178      191       +13

Impacted Files
Coverage Δ

clean_expired_records.py
0.00% <0.00%> (ø)

historical_system_profiles/mgmt_views/v0.py
100.00% <ø> (ø)

kafka_listener.py
0.00% <0.00%> (ø)

standalone_flask_server.py
0.00% <ø> (ø)

wsgi.py
0.00% <ø> (ø)

..._system_profiles/notification_service_interface.py
35.00% <35.00%> (ø)

...ical_system_profiles/baseline_service_interface.py
39.13% <39.13%> (ø)

historical_system_profiles/archiver.py
55.05% <54.41%> (+55.05%)
:arrow_up:

...torical_system_profiles/drift_service_interface.py
66.66% <66.66%> (ø)

historical_system_profiles/probes.py
66.66% <66.66%> (ø)

... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This was recommended by the DevProd team in slack to see if this helps the org-id-populator job timing out.


One-Click Inventory

Hello,
I would like to introduce One Click Inventory, a system I developed, in hopes of reaching a broader audience and fostering more technical contributions. I kindly request that this project be added to the repository.
One Click Inventory has received 1109 likes on Booth and is widely used among Korean VRChat users. It is a modular avatar-based inventory system that, while similar to Modular Avatar and VRCFury, is specifically optimized for common inventory use cases in VRChat. This optimization allows users to set it up more intuitively through a user-friendly UI.
Features of One Click Inventory:

Automatic Generation of Object Toggles (bool) and Switching (int) Animations

Parameter Compression:
While an integer parameter (int) in VRChat typically uses 8 bits, supporting up to 256 states, this is often excessive for scenarios like an inventory with only three outfits. To address this, integer parameters are converted into multiple boolean (bool) parameters through encoding and decoding. This approach allows finer control over the parameter usage, such as using only 2 bits to represent up to 4 states, which is sufficient for selecting among three outfits. This plugin was inspired by.

Menu Creation:
Seamlessly integrates with Modular Avatar to support the creation of more complex menus.

Icon Generation:
Automatically captures menu icons.

Advanced Features:
Includes options for modifying blendshapes, changing materials, and toggling additional objects on or off.

I look forward to your consideration and hope this tool can be beneficial to the community. Thank you!

Hello, first of all thank you so much for your submission. This is very well written and that's very nice to read.
I did take some time to read about the project because i never really interacted with people from the Korean community of vrc.
I gave a try to your project and it feels really promising and to be an easy way to setup outfits and covers a lot of use cases for avatar inventories.
As your project is still in version v0.2.36 , i won't be able to add it to the main list but will definitely add to the Upcoming list.
Thank you again for your work for the community and for your submission. Glad to know another great project making use of NDMF. ✨


fix warnings within sos

The previous patch has been merged, so you should create PR from the master now.


OpenSCAD syntax

Please include OpenSCAD syntax.
https://github.com/sirtaj/vim-openscad
https://github.com/openscad/openscad/
https://www.openscad.org/
https://github.com/sirtaj/vim-openscad/issues/8

Please ask each author to send the files to Bram.
Explicit permission from each author is required.

you don't need to open an issue here about including new runtime files. Rather always approach the runtime file maintainers directly.


ci: New linter actions

.github/workflows/all_packages.yml now commits any changes to melos format / generate / fix directly without failing
Removed .github/workflows/check-uncomitted-changes.yml since its task is now included in all_packages.yml workflow
Introduced new .github/workflows/linter.yml workflow that appends newlines to files for POSIX compliance and directly commits any changes
Small other action related changes

Find a workaround so that github action commits trigger other actions
https://github.com/orgs/community/discussions/25702


Recording periods that are longer than TTL show as avaiable

This might be back end related but I am creating this ticket to at least track the issue.
On the manager I notice there are recording periods showing up as available even though the stream periods are passed the TTL length.
For example in the image below the stream has a TTL set to 1 hour but the long periods still show available. This is best able to been seen in the fox tenancy. All the stream there have a TTL of 1 hour.

It looks like the metadata for edge write token recordings changed. I updated the app to use

RECORDING/sources/trimmed instead of RECORDING/sources/video_trimmed
RECORDING/sources/video/parts instead of RECORDING/sources/video

Relates to https://github.com/eluv-io/elv-live-stream/commit/0ccb64d327e142c8c71cdff865739f402fe62555
Deployed to demo and prod-dev.

Its working better now but I see one issue, the case for "Partially Available" is not working.
In the example stream below, it has a TTL of 1 hour and I was expecting to see the current running period of 12 hours to show as partially available

Relates to https://github.com/eluv-io/elv-live-stream/commit/f28f9e7b3271aa7a9f5c20edd721391730a5920f
Deployed to demo and prod-dev.

Verified that the listing is looking correct now with regard to available, partially available, and not available.


feat(gerrit-urlreader): support fetching content for a commit SHA hash

Hey, I just made a Pull Request!
A follow up to #25202 that brings support to the GerritUrlReader to get content referenced by a full
SHA hash. The intended use cases is auxiliary helpers to support users creating/updating catalog files.
One example is API validation as stated in #25733.
:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[X] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Yes, I agree about deprecating those functions. No point in having those around since they are not use any more.

Not stale!

Not stale bump!

@Rugvip Could you take a look?

not stale bump

not stale!


Test launch service

Triggered pipeline to build and deploy your code. You can track progres here

Your app is deployed at launch-144.centralus.azurecontainer.io


libpg_query: also build shared library

Description of changes

I'm working in an environment (Common Lisp) where I need to be able to load and interact with libpg_query dynamically, but the existing derivation only calls the make target that builds the static lib. This commit enables and installs the shared library.
Works for me on Darwin, but unsure if any further steps are idiomatic or needed, e.g. patchelf on Linux, please advise if so.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Also enabled tests for a little extra peace of mind.

Any feedback, @marsam? Also happy to add myself as a maintainer for this in future, if it would help.

Awesome, thanks @marsam, much appreciated


Changed ThreadPoolExecutor setCorePoolSize implementation on Java  10+

On OpenJdk 11 the implementation of ThreadPoolExecutor's setCorePoolSize was changed and contains an additional constraints comparing the maxPoolSize and corePoolSize values.
If maxPoolSize is not changed but corePoolSize is given as a higher number of default maxPoolSize it throws IllegalArgumentException.
This causes issue here:
https://github.com/Netflix/Hystrix/blob/master/hystrix-core/src/main/java/com/netflix/hystrix/HystrixThreadPool.java#L230-L231

Looks like it's Java 9+.
From the Java 8 API docs for ThreadPoolExecutor#setCorePoolSize:

Throws:
IllegalArgumentException - if corePoolSize < 0

From the Java 9 API docs for ThreadPoolExecutor#setCorePoolSize:

Throws:
IllegalArgumentException - if corePoolSize < 0 or corePoolSize is greater than the maximum pool size

Here's a minimal example - it can be triggered if the core size is changed through Archaius:
@Test
void simplestTest() throws Exception {
    var command = new HystrixCommand<>(HystrixCommand.Setter
            .withGroupKey(HystrixCommandGroupKey.Factory.asKey("Group"))
            .andCommandKey(HystrixCommandKey.Factory.asKey("Command"))) {
        @Override
        protected String run() throws Exception {
            return null;
        }
    };
    // ConfigurationManager is from Archaius
    ConfigurationManager.getConfigInstance().setProperty("hystrix.threadpool.Group.coreSize", 11);
    command.execute();
}

This exception is thrown when the command is executed:
com.netflix.hystrix.exception.HystrixRuntimeException: Command failed while executing.
...
Caused by: java.lang.IllegalArgumentException
	at java.base/java.util.concurrent.ThreadPoolExecutor.setCorePoolSize(ThreadPoolExecutor.java:1535)
	at com.netflix.hystrix.HystrixThreadPool$HystrixThreadPoolDefault.touchConfig(HystrixThreadPool.java:230)
	at com.netflix.hystrix.HystrixThreadPool$HystrixThreadPoolDefault.getScheduler(HystrixThreadPool.java:205)

The Hystrix documentation here: https://github.com/Netflix/Hystrix/wiki/Configuration#maximumSize
it says you can't modify the maximumSize hystrix property if you don't set the allowMaximumSizeToDivergeFromCoreSize to true.
setting this property to true you are able to have different values for the core pool size and the maximum pool size.

The issue appears also when you set the coresize greater then the default maximum size, because of a failed implementation of the  HystrixThreadPool class. The error is, because firstly the core size is set and after this the maximus size of the threadpool. At the moment when the core size is set and it is bigger then the default size (10) the IllegalArgumentException is thrown.

I meet this issue also,but how can I replay this issue,no one would write 'ConfigurationManager.getConfigInstance().setProperty("hystrix.threadpool.Group.coreSize", 11);' such code in application


Stuck at Loading

Hi i build the project an it runs without errors but after puting the web files in xampp the page hangs at loading

you should atleast provide all logs you could fetch.
what does your web development console say while loading?

not enough info / a lot has changed since this issue was created. Re-open if the issue is still present


Application Name Internationalization And Warning About Naming

I think it is necessary to support the internationalization of single flavor application names. But I didn't find where to fill in. In addition, if there is an underscore in the file name, there will be a warning in Android Studio. If it is changed to an underscore, there will be no warning.
Thank you for your attention to these words.

In addition to some file naming, there are warnings for the naming of attributes or enumerations

Hello @LinHaoLove , can you please elaborate on your concerns about internationalization?

It's a pleasure to hear from you。
Let me give you an example：
flavorizer1: 苹果、Apple，and so on.
flavorizer2: 香蕉、Banana, and so on.
When I switch between different flavorizers, I want to display the corresponding internationalization name.Not a fixed name.
If there are different flavorizers, different startup interfaces can be set. That's better.
I'm sorry I'm not good at English.
------------------ 原始邮件 ------------------
发件人:                                                                                "AngeloAvv/flutter_flavorizr"                                                                                @.>;
发送时间: 2022年4月3日(星期天) 凌晨1:05
@.>;
<EMAIL_ADDRESS>主题: Re: [AngeloAvv/flutter_flavorizr] Application Name Internationalization And Warning About Naming (Issue #85)
Hello @LinHaoLove , can you please elaborate on your concerns about internationalization?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@LinHaoLove after you ran the flavorizr, you can customize the app_name directly in strings.xml according to the destination language for Android and using a custom .plist file for iOS.

Thank you for your reply.
I fully understand what you're saying, but that's not what I want.
My company has changed the requirements, so it no longer needs such a mechanism.
Have a nice day.


Npe pen

Make SmartKey signer use the java Signature version of update.
Tested and working :success
This should make things work the way they were in regards to the Pen class.

Codecov Report

Merging #69 (3768648) into main (163dc4c) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main      #69      +/-   ##
============================================
- Coverage     11.80%   11.65%   -0.15%
  Complexity       35       35
============================================
  Files            65       65
  Lines          3355     3398      +43
  Branches        358      360       +2
============================================
  Hits            396      396
- Misses         2903     2946      +43
  Partials         56       56

Impacted Files
Coverage Δ

...provenance/engine/service/ProvenanceGrpcService.kt
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 163dc4c...3768648. Read the comment docs.

The other way works as well, but doesn't handles these NPE edge cases and is less abstractive.
You are probably asking why didn't we do this earlier? I would say a long weekend and a refreshed mind contributed. 😅


Password provided via CLI is logged in plain text

Description
When calling dbeaver-cli.exe with the -con argument, the password in the connection string gets logged in its entirety in plaintext in the log file.
I am looking at the log file: %APPDATA%\DBeaverData\workspace6\.metadata\.log  (yes, that's .log. For some reason it doesn't have a filename, only the .log extension)
DBeaver Version
Community Edition <IP_ADDRESS>407211303
Operating System
Windows Server 2019 (1809, 17763.6054)
Database and driver
MySQL
Steps to reproduce

Call DBeaver CLI:  "C:\Program Files\DBeaver\dbeaver-cli.exe" -data "%APPDATA%\DBeaverData\workspace6" -nosplash -con "name=Test|driver=mysql|host=TEST|database=TEST|user=TEST|password=NAUGHTY|savePassword=true|connect=false|create=true|save=true"
Inspect the log file at %APPDATA%\DBeaverData\workspace6.metadata.log
Search for the word NAUGHTY

Additional context
No response

This issue was reported in 2019 (#3788) and closed due to inactivity.  I don't think it should be closed as it's a significant security concern.

Agree with you.
Actually, it was not about inactivity.
Ideally, the issue should then have been reopened at the moment the user did not confirming that it had been fixed.

see https://github.com/dbeaver/dbeaver/issues/3788#issuecomment-2294995335

Thank you @Matvey16 and @serge-rider and anyone else involved with this that I missed!


Clicked dom element in select2-selecting

Would like to recommend including a reference to the element that received the click event if possible:
http://jsfiddle.net/q4rgE/2/
Use case for this would be something where you have some sort of preview popup for each item, and thus if the href or icon were clicked, you would preventDefault and then trigger some javascript to display that preview(in boostrap modal for example).  Problem is I can't determine what element was clicked and thus can't conditionally do preventDefault.

This is possible to do by overriding the resultsAdapter with a decorator. Right now we might be passing it in for select2:selecting through the originalEvent attribute, which is a different way to get the DOM element (but not as consistent).

Why I can't do this
$('.city').select2({
}).on("click",'select2-drop#btn_add', function(e) {
console.log(e);
var test = $(this)
console.log(test);
});
$(".select2-drop").append('');


WIP: Add Netflix vmaf to ffmpeg running on ubuntu1804.

So far ubuntu1804 is the only one I was able to get working with VMAF 1.5.2. I plan to try to do the others but wanted some feedback on the current direction I took so far.

@jrottenberg Hi. Why would build alpine311_3.3.9 succeed but build alpine311_3.4.8 fail? Locally they both failure for for me since they missing are dependencies.
Even adding the dependencies locally they still cannot be found. Does it make sense to manually download them in the alpine 3.11 Docker template? I don't have much experience with apk so perhaps something is missing in the apk command?
v3.11.6-215-g0999d9b171 [http://dl-cdn.alpinelinux.org/alpine/v3.11/main]
v3.11.6-212-g3a84324cad [http://dl-cdn.alpinelinux.org/alpine/v3.11/community]
OK: 11273 distinct packages available
fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/community/x86_64/APKINDEX.tar.gz
ERROR: unsatisfiable constraints:
  ninja-build (missing):
    required by: world[ninja-build]
  python3-pip (missing):
    required by: world[python3-pip]
  python3-setuptools (missing):
    required by: world[python3-setuptools]
  python3-wheel (missing):
    required by: world[python3-wheel]
The command '/bin/sh -c buildDeps="autoconf                    automake                    bash                    binutils                    bzip2                    cmake                    curl                    coreutils                    diffutils                    file                    g++                    gcc                    gperf                    libtool                    make                    python                    openssl-dev                    tar                    yasm                    nasm                    zlib-dev                    expat-dev                    python3                    python3-dev                    python3-pip                    python3-setuptools                    python3-wheel                    ninja-build" &&         apk update &&         apk add --no-cache --update ${buildDeps}' returned a non-zero code: 4

fixed by https://github.com/jrottenberg/ffmpeg/pull/289


GUID_NEQ_ZERO Add support for Guid != 0 in if statements

At the very least SMSG_MESSAGECHAT for TBC seems to require this.
https://github.com/mangosone/server/blob/90a968a0af6042df2a653cf5ddf7c27f0bd664f9/src/game/WorldHandlers/Chat.cpp#L3910

Less general version of https://github.com/gtker/wow_messages/issues/58.


Divide refactor work

Each team member should be given a roughly equally challenging part to refactor into tests. Print statements are probably the hardest to refactor into tests.
Each directory should have precisely one assignee, one issue per directory (subdirs are also dirs!).

I did a simple count of the number of places where I could find viable testing data. For example, a print statement was only counted if it used a constant value. Based on what I found, I suggest the following division of directories:

sorts
Maths, maths, dynamic_programming
data_structures/*, strings
Graph, graphs, other, arithmetic_analysis
ciphers, searches

These are the ones that I think will require the most amount of work. I also found potential test cases in the following directories, but I think they should be divided among us based on who has time left:

analysis/compression_analysis
binary_tree
boolean_algebra
hashes
machine_learning
matrix
networking_flow

The remaining directories contained no tests or anything that could be converted to a test that I was able to find.

boolean_algebra contains only one module, quine_mc_cluskey, and AFICT it is not reasonably tested. I think we skip that one too.


Re-structure the package

Issue
All decorators are implemented in __init__.py. This will be bad for maintainability once the file gets bigger.
Mitigation
We should probably split the decorators into different python files (potentially following the structure from the documentation?) and import those inside __init__.py

Solved


Not so much an issue as a suggestion

I wanted to recommend Metasrc.com as another source. I tried to just modify a duplicate championgg.py file to have the metasrc info in it but after running with that added, it would just automatically delete anything from metasrc ;-;

I'll take a look at it!


More robust handling of Cron job startup

If the cron job fails, it will leave the temp file open.  We need to check for actively running cron jobs before starting instead.

Fixed:
*/10 * * * * [[ ps -ef | grep run_dirwatch2 | wc -l | xargs == 1 ]] && /global/project/projectdirs/metatlas/run_dirwatch2.sh >& /global/project/projectdirs/metatlas/dirwatch2.log


Anti-aliasing

Hi,
thank you again for your great work!
Since when I started using the lib, I noticed it applies anti-aliasing when rendering fonts, which is great for the vast majority of the cases.
In my case, dealing with lo-res screens (CGA CRT) too, I would appreciate also the possibility of disabling anti-aliasing at config level, just like you do for stroked or blurry, so to better match the capabilities of those devices.
I don't know the internals of the lib so maybe this is not even possible, but I'm wondering: what about adding a FontSystem property to switch anti-aliasing on/off?

The only way to disable antialiasing is to use StaticSpriteFont and to load fonts from AngelCode BMFont files.
See this for more details: https://github.com/rds1983/FontStashSharp/releases/tag/<IP_ADDRESS>

The only way to disable antialiasing is to use StaticSpriteFont and to load fonts from AngelCode BMFont files.
See this for more details: https://github.com/rds1983/FontStashSharp/releases/tag/<IP_ADDRESS>

As for DynamicSpriteFont, it uses stb_truetype internally to rasterize glyphs. I couldn't figure out how to turn the antialiasing off there.

As for DynamicSpriteFont, it uses stb_truetype internally to rasterize glyphs. I couldn't figure out how to turn the antialiasing off there.


[Multifile] Static bases not generated if they're not used

If I have:
A.dll:
class Foo
{
    public static int X;
}

B.exe
class Program
{
    static int Main()
    {
        return Foo.X;
    }
}

The result won't link because we didn't generate the static base for Foo in A.obj (since it's never used in A.dll), and when compiling B.exe, we thought we can just use a symbol reference to reach it.
This is a problem for all three kinds of static bases we have.

Simon fixed this with #2586.


Added package update_nimble_version

https://github.com/philolo1/update_nimble_version gives me 404 :/

@narimiran sorry, i did not make it public. It should now be accessible.


Specify default values

Fixes #46.

@ukhryab, probably the reason is that the 0 0 7 * * * schedule is used by default?=)

@eugulixes yes, and I wonder how can I test it quickly since 0 0 7 * * * stands for 7:00 ))

@ukhryab, I've just done it, simply commiting and pushing 15 * * * * *.


7tv emotes don't work

7tv emotes don't work and it makes the chat unreadable.. a lot of channels use it nowadays

Duplicate: https://github.com/tmarenko/twitch_chat_antiban/issues/7
Though I wonder if it's possible to make own IRC client for chat instead of using 3rd party tools.
Will leave this issue open for now.

Yo I was kinda searching for a solution and I think I found one. You could try using jChat instead of Nightdev/KapChat.

Unfortunately, jChat provides very (IMO) limited options to customize its appearance.
The fonts and their sizes, in particular, do not look that great. Additionally, it is impossible to inject custom CSS styles into an iframe due to the cross-domain policy.
However, jChat has shown me that it is possible to create a custom chat reader through IRC, so I am now considering that option.

I made an update in https://github.com/tmarenko/twitch_chat_antiban/tree/irc-chat
Now the chat is completely reworked and support 7TV/BTTV/FFZ
For now you can install it either by cloning source code or just drag&drop this archive into Chrome extension tab.
If you could test and report any bugs that would be grateful
@robmonte @sangakuu @zett121

So far no issues for me, works great and loads all emotes

@zett121 this one is be fine, forgot to remove Firefox manifest from archive. Extension should work anyway even with this error

can confirm works good even with the error. great job

Merged https://github.com/tmarenko/twitch_chat_antiban/pull/10 and released


Rename Document

Description
Rename Document to Our Team and add members of Catalyst.
take style reference from https://smvduclub.github.io/main_page/
Mocks

Acceptance Criteria
Update [Required]

[x] [add members of Catalyst]
[x] [connect with Our team button]

Definition of Done

[x] All of the required items are completed.
[x] Approval by 1 mentor.

i will take this up

do we have to make different page or include it in the same?

Read issue description carefully 😉


Prep for Release of v1.1.8

Tracking issue for the May 2024 release of wlbot.

v1.1.8 has been published to npm: https://www.npmjs.com/package/wlbot/v/1.1.8

v1.1.8 release has been created in GitHub: https://github.com/mike-weiner/wlbot/releases/tag/v1.1.8


FileConventions: fix wrapLatestCommitMsg on Win OS

Fixes https://github.com/nblockchain/conventions/issues/123

@knocte I tried it, but nothing changed.

Please try again, I overlooked something.

Please try again, I overlooked something.

script is working now. 👍

During the test, i found a bug:
Steps to reproduce:
1.
git commit -m "foo: testing
>
> This is a so long long long long long long long long long long long long long long long long long commmit" --allow-empty

dotnet fsi .\scripts\wrapLatestCommitMsg.fsx

Your info is terribly confusing; first you say it works and later you report a bug? are you saying it works generally but not for this specific case? FFS please try to think of what people might think when reading your messages.

Your info is terribly confusing; first you say it works and later you report a bug? are you saying it works generally but not for this specific case? FFS please try to think of what people might think when reading your messages.

it works. but the bug I reported occurs when a commit is empty.

That's more clear, please open a bug about that.


Download unsupported URL - Video that will be removed soon

Checklist

[x] I'm reporting a new site support request
[x] I've verified that I'm running youtube-dl version 2020.07.28
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that none of provided URLs violate any copyrights
[x] I've searched the bugtracker for similar site support requests including closed ones

URLs

Single video: https://nextlevelweek.com/episodios/discovery/1/edicao/2?wvideo=vfynv3lv09

Description

Im trying to download this video, using windows, when I open the python console and type
youtube-dl https://nextlevelweek.com/episodios/discovery/1/edicao/2?wvideo=vfynv3lv09 -f -mp4
I receive the message below
[generic] 2?wvideo=vfynv3lv09: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 2?wvideo=vfynv3lv09: Downloading webpage
[generic] 2?wvideo=vfynv3lv09: Extracting information
ERROR: Unsupported URL: https://nextlevelweek.com/episodios/discovery/1/edicao/2?wvideo=vfynv3lv09
This video will be online for one week only, I would like to download it, can someone help me?
My verbose debug
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://nextlevelweek.com/episodios/discovery/1/edicao/2?wvideo=vfynv3lv09', '--verbose']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2020.07.28
[debug] Python version 3.8.5 (CPython) - Windows-10-10.0.18362-SP0
[debug] exe versions: none
[debug] Proxy map: {}
[generic] 2?wvideo=vfynv3lv09: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 2?wvideo=vfynv3lv09: Downloading webpage
[generic] 2?wvideo=vfynv3lv09: Extracting information
ERROR: Unsupported URL: https://nextlevelweek.com/episodios/discovery/1/edicao/2?wvideo=vfynv3lv09

Someone told me to get the m3u8 link and download manually on youtube-dl.
Worked pretty well.


Error AndroidRuntime Caused by: java.lang.ClassNotFoundException: org.java_websocket.client.WebSocketClient

i Export aar to Unity，Unity Report
Error AndroidRuntime Caused by: java.lang.ClassNotFoundException: org.java_websocket.client.WebSocketClient
how to fix it?

The message just means that Java-WebSocket library was not found. I'm not familiar with AAR but I guess you need some way to include all libraries into it. I see there are some plugins which does this: https://plugins.gradle.org/plugin/com.cpdroid.fat-aar but unfortunately it is outdated. I found multiple questions on stackoverflow but looks like there is no official solution for this, people either use the plugin or copy files manually.
Anyway, I'm closing this issue because it is a general Java question, not related to this library.


cli: ineligible text inside comments

I'm using catppuccin-macchiato.yaml theme.
The terminal is alacritty. I've noticed that some text in the console is too dark. This occurs for commented text and some other tools like hx --health (in the lsp column paths to /nix/store are unreadable):

Inline comments also are indistinguishable from background (the actual command is echo "hello" # asdfasdfasdf)

Related: https://github.com/danth/stylix/issues/249

How does this look without the transparent background?

Removing transparency does not seem to make a huge difference. The text still has very poor contrast with a dark background.
Seems like this is a problem with alacritty specifically. With wezterm colors seem much more reasonable.
Alacritty:

Wezterm:

I think the issue is with the upstream base16-alacritty template:
Generated alacritty theme has really badly misconfigured highlight colors:
[colors.bright]
black = '0x494d64'
red = '0xf5a97f'
green = '0x1e2030'
yellow = '0x363a4f'
blue = '0x5b6078'
magenta = '0xf4dbd6'
cyan = '0xf0c6c6'
white = '0xb7bdf8'

The supposedly green color is actually 0x1e2030, which is dark blue...
base16-alacritty repo seems quite a bit borked and does not conform to base16/stylix guidelines.


fix(server-renderer): respect the mixed render function in ssr

close: #3004

see comments in code for more details


"The property 'application' cannot be found on this object" error in Compile-AppInNavContainer

Hi,
have it this bug:
When I use the new property "applicationInsightsKey" in the app.json, the compilation ends with the error
The property 'application' cannot be found on this object ....

which originates on line 184 of the Compile-AppInNavContainer:
if (([bool]($appJsonObject.PSobject.Properties.name -match "application")) -and $appJsonObject.application)
    {
        $dependencies += @{"publisher" = "Microsoft"; "name" = "Application"; "version" = $appJsonObject.application }
    }

It is because the -match "application" match this line too... I recommend to use -eq instead -match if the property name should be exactly "application".

Shipped in <IP_ADDRESS>


Disabling filter in Project settings crashes Godot

Operating system or device - Godot version:
Godot 2.1.2 Linux 64 bit (from Steam)
Issue description:
Disabling filter option in project settings crashes Godot when checkbox on left side is disabled
Steps to reproduce:

go to Projects Settings > General > Image Loader
click on checkbox on right side of filter

Workaround

turn on left checkbox

Duplicate of #7696, fixed in 2.1.3.


[WIP]New topology query protocol implementation

Changes.

Adopt new query protocol, https://github.com/apache/skywalking-query-protocol/pull/12
Fix the https://github.com/apache/skywalking/issues/2534

Coverage decreased (-0.02%) to 16.404% when pulling a3d5c1e41044fd325ea197d22d981eef89bdd749 on new-topo into 20611a3fe30580c00dcb27767bbb1f3556420a57 on master.

Coverage decreased (-0.02%) to 16.404% when pulling a3d5c1e41044fd325ea197d22d981eef89bdd749 on new-topo into 20611a3fe30580c00dcb27767bbb1f3556420a57 on master.

I am using this graphQL query the topology
{
  getGlobalTopology(duration:{step:MINUTE, start: "2019-05-13 2100", end: "2019-05-13 2130"}){
    nodes{
      id
      type
      isReal
      name
    },
    calls{
      id
      detectPoints
      source
      target
      sourceComponents
      targetComponents
    }
  }
}

The new topology result is
{
  "data": {
    "getGlobalTopology": {
      "nodes": [
        {
          "id": "1",
          "type": "USER",
          "isReal": false,
          "name": "User"
        },
        {
          "id": "2",
          "type": "Tomcat",
          "isReal": true,
          "name": "dubbox-consumer"
        },
        {
          "id": "3",
          "type": "Dubbo",
          "isReal": true,
          "name": "dubbox-provider"
        },
        {
          "id": "4",
          "type": "rocketMQ-consumer",
          "isReal": true,
          "name": "rocket-mq-consumer"
        },
        {
          "id": "6",
          "type": "MongoDB",
          "isReal": false,
          "name": "localhost:27017"
        },
        {
          "id": "7",
          "type": "RocketMQ",
          "isReal": false,
          "name": "RocketMQAddress:2000"
        }
      ],
      "calls": [
        {
          "id": "2_3",
          "detectPoints": [
            "CLIENT",
            "SERVER"
          ],
          "source": "2",
          "target": "3",
          "sourceComponents": [
            "Dubbo"
          ],
          "targetComponents": [
            "Dubbo"
          ]
        },
        {
          "id": "3_6",
          "detectPoints": [
            "CLIENT"
          ],
          "source": "3",
          "target": "6",
          "sourceComponents": [
            "mongodb-driver"
          ],
          "targetComponents": []
        },
        {
          "id": "3_7",
          "detectPoints": [
            "CLIENT"
          ],
          "source": "3",
          "target": "7",
          "sourceComponents": [
            "rocketMQ-producer"
          ],
          "targetComponents": []
        },
        {
          "id": "1_2",
          "detectPoints": [
            "SERVER"
          ],
          "source": "1",
          "target": "2",
          "sourceComponents": [],
          "targetComponents": [
            "Tomcat"
          ]
        },
        {
          "id": "7_4",
          "detectPoints": [
            "SERVER"
          ],
          "source": "7",
          "target": "4",
          "sourceComponents": [],
          "targetComponents": [
            "rocketMQ-consumer"
          ]
        }
      ]
    }
  }
}

The Endpoint Dependency Query
{
  getEndpointTopology(duration:{step:MINUTE, start: "2019-05-13 2100", end: "2019-05-13 2130"},
  endpointId: 5){
    nodes{
      id
      type
      isReal
      name
    },
    calls{
      id
      detectPoints
      source
      target
      sourceComponents
      targetComponents
    }
  }
}

The result is
{
  "data": {
    "getEndpointTopology": {
      "nodes": [
        {
          "id": "1",
          "type": "",
          "isReal": true,
          "name": "User"
        },
        {
          "id": "5",
          "type": "",
          "isReal": true,
          "name": "/dubbox-case/case/dubbox-rest"
        },
        {
          "id": "4",
          "type": "",
          "isReal": true,
          "name": "org.skywaking.apm.testcase.dubbo.services.GreetServiceImpl.doBusiness()"
        }
      ],
      "calls": [
        {
          "id": "1_5",
          "detectPoints": [
            "SERVER"
          ],
          "source": "1",
          "target": "5",
          "sourceComponents": [],
          "targetComponents": []
        },
        {
          "id": "5_4",
          "detectPoints": [
            "SERVER"
          ],
          "source": "5",
          "target": "4",
          "sourceComponents": [],
          "targetComponents": []
        }
      ]
    }
  }
}

@peng-yongsheng The backend change is ready for your review.

New topology verified locally.


Upgrade maven to 3.6.3

For some reason, 3.6.2. is deleted in the repository bumping to 3.6.3 instead..
Fix for: https://github.com/actions/virtual-environments/issues/166

Fixed with #172


Binary XML file: Error inflating class fragment

Unable to inflate my layout when i use this fragment that holds a set of emojis.
Both EmojiFragment and EmojiGridFragment are unable to be inflated in my layout.

Post your xml

just passing by and saw this - you get that error if you don't implement the click interfaces like the sample code.  This is the error at the top of the stack trace when the info at the bottom shows the real problem. Also extend FragmentActivity instead of Activity - i got this error and that fixes it. hope this helps, nice library.

I am using this in a Fragment not even in an Activity

I'll try to reproduce the error, and paste my xml and error generated later for better assistance.

same problem here, when using in fragment


refactor: interfaces, make 'createTransaction' less error-prone

Bundle all function's outputs inside the util::Result returned object.
Removals:

The input-output 'change_pos' ref arg from createTransaction, which has been a source of bugs in the past.
The 'fee' ref arg from createTransaction, which is currently only set when the transaction creation process succeeds.
The currently unreachable AmountWithFeeExceedsBalance error (more info about its re-introduction at https://github.com/bitcoin/bitcoin/pull/25269).

Additionally, this PR moves the CreatedTransactionResult struct into its own file. This change is made to avoid further expanding the GUI dependencies on wallet.h. Structurally, the GUI should only access the model/interfaces and never the wallet directly.

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews
See the guideline for information on the review process.
A summary of reviews will appear here.

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.
Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
Leave a comment here, if you need help tracking down a confusing failure.
Debug: https://github.com/bitcoin-core/gui/runs/22979285609

🐙 This pull request conflicts with the target branch and needs rebase.

While introducing a new wallet/util_spend.h header, it seems reasonable to address all related IWYU warnings, no?

cc @achow101 @ryanofsky

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.
Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
Leave a comment here, if you need help tracking down a confusing failure.
Debug: https://github.com/bitcoin-core/gui/runs/25073685372

nit: on 2nd. commit (https://github.com/bitcoin-core/gui/commit/95aaaa4f023c6a6b629c36cfb9d8abd4bab1cb66), you forgot to remove the change from the makefile as it's not longer needed.

Removed. Thanks.

CI failure is unrelated.

I just noticed https://github.com/bitcoin/bitcoin/pull/25269, which I hadn't seen when I posted my comment above. It looks like that PR was closed for inactivity but it does look like a good approach that solves the issue I didn't like in my comment (though maybe it is still a slight regression because it doesn't include the amount of the fee in the error message). I wonder if you'd consider reopening that PR and maybe including the changes in this PR or basing this PR on that one?
Or if you no longer think that PR is worth pursuing, I think you could separate the cleanups here from the issue that PR was trying to address by leaving the CAmount& fee output parameter and GUI code intact here, but still doing the other cleanups.

Concept ACK.

Additionally, this PR moves the CreatedTransactionResult struct into its own file.

This part of the PR description seems no longer relevant.

Thanks for the review ryanofsky!

I just noticed bitcoin/bitcoin#25269, which I hadn't seen when I posted my comment above. It looks like that PR was closed for inactivity but it does look like a good approach that solves the issue I didn't like in my comment. (Though maybe that PR is still a slight regression because it doesn't include the amount of the fee in the error message.) I wonder if you'd consider reopening that PR and maybe including the changes in this PR there, or basing this PR on that one?

Yeah sure, I closed it for lack of movement after 6 months. I just reopen it, reworking part of it, and rebased this one on top. I think it make sense to re-introduce the functionality there and cleanup the GUI code here.

I agree on focusing this PR on the code cleanup only.

Drafted until https://github.com/bitcoin/bitcoin/pull/25269 gets merged. This is a continuation of that work.

Concept ACK


7z support

compress-tools claims to support 7z files, but somethings seems to be going wrong there because my tests (on WSL) don't work, and it's not useable on Windows anywany.
Using the cxx crate, we may be able to either:

build our own wrapper around the most basic libarchive functions (ew, but necessary for linux, as demonstrated in the next point)
include the 7zip DLL and a wrapper around it, which gives us fantastically improved archive capabilities, but only on windows.

Wouldn't this allow you to replace custom format handling with just one implementation?
https://crates.io/crates/compress-tools

Another option:
Use the XADMaster Obj-C library built for 'The Unarchiver' :

https://github.com/incbee/Unarchiver/tree/bleeding-edge/XADMaster
https://github.com/incbee/Unarchiver/tree/bleeding-edge/UniversalDetector

And a crate for Obj-C bindings:

https://crates.io/crates/fruity (maintained, no examples)
https://crates.io/crates/objc (popular, more mature?,  cryptic mention of alternate runtimes for cross-platform, unsafe code required)
bindgen can maybe be mentioned here too?

Poor-mans solution is a solution as well. Require the user to provide 7z executable (autodetect and call as external program).


[WIP] API-1835: migrate the installer controller to SSA

proof pr at https://github.com/openshift/cluster-kube-apiserver-operator/pull/1756

/retest


user object in jade templates

It's not an issue, but would really love to see some information on how does user object gets into jade templates from controller without passing it as an object?
I see those lines in app.js:
app.use(function(req, res, next) {
  res.locals.user = req.user;

  next();
});

but how do we get req.user ? where does it come from?
PS. Please join Gitter

Hackaton use passport.js to authenticate users, and by default the object that passport return is req.user (you can change this sending a option to passport);
(Look this link) [http://toon.io/understanding-passportjs-authentication-flow/]

thank you very much for pointing me to the right direction.
@PgPedroGabriel

Yeah as @PgPedroGabriel mentioned it is provided by the Pasport middleware when you initialize it.
app.use(passport.initialize());
app.use(passport.session());


feat: update nuget and npm packages

:tada: This PR is included in version 2.16.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Text transfomation]

Description of the requested feature
I have searched the docs, but didn't found any property that can  uppercase text . Please let me know if i am mistaken, and close this issue.  I tried to do it with css, but failed.
Proposed configuration syntax
:text-transform "Capitalize/uppercase/lowercase"
Additional context
No response

The label widget has a markup property that allows you to use pango markup, which should allow you to uppercase your string.


server panic when use invalid ext name

using a nes game with zip format may cause server panic.
log here: https://pastebin.com/h5J1xxzW
by the way, is it possible to store different game with different folder like retropie?

By design, each emulator has a predefined list of ROM file extensions and these file extensions can be used with more than one emulator. So when you are trying to open zip, it opens with MAME (FBneo) core (see the config file).
Other Libretro frontends read ROMs with the help of special ROM-list files which is quite tricky to implement.
I think it won't read subfolders therefore you can store games only in one folder (assets/games), and when it reads the folder, any ROMs with exact same filenames will be skipped.

Other Libretro frontend use a config file to definite which folder should be used for emulator to load their roms, by the way, gamelist.xml is optional, they will read roms in folder when there is no gamelist.xml in folder by scanning files too.
Additionally, reading an abnormal file will cause the server panic is not a good design.

Other Libretro frontend use a config file to definite which folder should be used for emulator to load their roms

That's actually an interesting approach. Maybe I'll implement it later.

Additionally, reading an abnormal file will cause the server panic is not a good design.

I agree but all the crashes are expected to be handled with Docker / k8s resilience features.


Revert "chore: start the experiment with modulepreload on qwik.dev"

Reverts QwikDev/qwik#6862
cc @maiieul I revert it as requested

thanks 😅


dolbyHdrDarkAmazon

I added picture mode dolbyHdrDarkAmazon
From that point the bride errors out.  It errors at such a rate and apparently looping so rapidly that HOOBS cannot respond
To recover I must refresh HOOBS and restore to a point where that setting was not set
If this causes an exception it should not bring down the service,

Where did you add this picture mode?
Please post the homebridge debug log so at least i have an idea about exception you speak. I need some more info from you in order to identify and fix the issue...


extend the plotting function to multiple files

Major demand for plotting would be to compare the values of a same metric from different trainings, instead of different metrics from a same training.
Therefore I extended this file's function to enable plotting multiple columns from multiple trainings.

Pull request information

Status: ? (ready to merge / in development)
Kind of changes: ? (bug fix / new feature / documentation...)
Related PR or issue: ? (optional)

Description

? (general description)

Pull Request Test Coverage Report for Build 5489

21 of 21 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 89.702%

Totals

Change from base Build 5448:
0.009%

Covered Lines:
9277

Relevant Lines:
10342

💛  - Coveralls