Added Super Linter

Adding Linting to the Project
This PR is focused on adding the following languages checks

yaml
Rust
Markdown

How it does this is up to discussion, currently investigating https://github.com/super-linter/super-linter/tree/v7.2.0.
Linting is currently set to be triggered on pull requests

[ ] Add Some form of Text Linting (TextLint)
[ ] Ensure All Markdown Files are being scanned
[ ] Get Linter Auto PR Fixes operational

After some googling and issues with getting the fix_LANGUAGE_x in the SuperLinter configuration to work. Ive shifted my attention over to MegaLinter which may be better maintained. It also has rust support with the most up to date Rust version alongside some other improvements.

Closing PR to reopen. To continue testing workflow


GeoJSON default SRID not set

It seems that the SRID of a geometry parsed from geojson is not set to the default of 4326, as defined by the spec. I've run into this issue because I am parsing a geojson object and performing a query with it using the great geo_postgis lib. However, when the database's column SRID is 4326, I get an error that it cannot compare the two geometries because the SRIDs are different (the parsed geojson geometry has an SRID of 0).
As a temporary solution, I changed the SRID of the column to 0 in the database, which is clearly not ideal.
I'm more than happy to write up a merge request for this issue, if this should be the desired behavior. Just point me in the right direction!
EDIT: add versions
➜ elixir --version
Erlang/OTP 22 [erts-10.7.1] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1] [hipe] [dtrace]

Elixir 1.10.2 (compiled with Erlang/OTP 22)

  defp deps do
    [
      {:ecto_sql, "~> 3.1"},
      {:postgrex, ">= 0.0.0"},
      {:jason, "~> 1.0"},
      ...
      {:geo_postgis, "~>3.3.0"}
    ]
  end

I solved this by setting the srid manually after decoding:
Map.put(Geo.JSON.decode!(item, :srid, 4326)


Updating FakeTLS ClientHello to match modern desktop/android clients

Description
Currently the FakeTLS implementation in gotd/td is adequate and works with mtproto proxies. But the code that generates the ClientHello is missing a lot from the Desktop and Android implementations, and seems out of date. Since this is essentially an obfuscation and censorship evasion scheme, it seems appropriate to follow the other clients in their implementation.
Given that the code is mostly a translation of the C++ code, updating it following the same scheme isn't difficult and I have partially done it locally.
Would the project be open to me contributing this?

This would be great.

How to implement Android？


add ownerRefence to generated config maps

Issues

Changelog

[ ] List your changes here
[ ] Make a changie entry

Tophatting

Codecov Report
Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 5.01%. Comparing base (23d538c) to head (f915a3a).
Report is 58 commits behind head on main.

Files with missing lines
Patch %
Lines

src/pkg/k8s.go
0.00%
7 Missing :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #227      +/-   ##
========================================
- Coverage   8.99%   5.01%   -3.99%
========================================
  Files         16      23       +7
  Lines        756    1576     +820
========================================
+ Hits          68      79      +11
- Misses       688    1497     +809

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Implement log roration of compacted logs

The implementation will be simple for now, the removal of all previous compaction logs. (See dfa945d50fd5a6de9b6d344e27a48760d5ff7c76)


Does nodegit support custom backends?

I want to create an in-memory backend, I know that libgit2 supports such custom bakends. If it does, I can't find info anywhere.
Thanks in advance.

Not currently, no. Those parts of libgit2 would have to be compiled in, which they are currently not. I haven't looked at the system in a while, but IIRC it's a different compile for each one, rather than just rolling them all in and choosing at runtime, which makes things much trickier. I could be mistaken though.

For reference, libgit2's custom backends are hosted at libgit2/libgit2-backends.

This would be a really interesting feature to have :)


OpenIdConnect API docs are missing for ASP.NET Core 3.1

Issue moved from MicrosoftDocs/feedback#3402

Please respond to @ryanhofdotgov.

From @ryanhofdotgov on Wednesday, January 20, 2021 6:52:55 PM
Describe the bug
The Microsoft.AspNetCore.Authentication.OpenIdConnect namespace is missing from the ASP.NET Core 3.1 documentation, as viewed in the .NET API browser.
To Reproduce
Steps to reproduce the behavior:

Go to https://docs.microsoft.com/en-us/dotnet/api/?view=aspnetcore-3.1
Search for OpenIdConnectHandler (an example of one specific class in the namespace)
Result is error message: No results

Expected behavior
I would expect similar search results/corresponding documentation that I see when changing the ASP.NET version to other versions. When making the same search query for OpenIdConnectHandler while specifying 3.0, I get this page. Similarly, when I specify ASP.NET Core 5.0, I get this page, respectively.
For ASP.NET 3.1, I've verified that the corresponding source code for OpenIdConnectHandler exists.
Desktop:

OS: macOS Mojave
Browser: Chrome
Version: 87

Issue moved from MicrosoftDocs/feedback#3402

Please respond to @welcome[bot].

From @welcome[bot] on Wednesday, January 20, 2021 6:52:57 PM
Thank you for creating the issue! One of our team members will get back to you shortly with additional information. If this is a product issue, please close this and contact the particular product's support instead (see https://support.microsoft.com/allproducts for the list of support websites).

Issue moved from MicrosoftDocs/feedback#3402

Please respond to @gewarren.

From @gewarren on Saturday, February 13, 2021 1:35:26 AM
@jamesnk What is your take on this?

Seems like a bug. OpenIdConnectHandler is available for .NET 5 and .NET Core 3, but not .NET Core 3.1. It should be.

@v-alje Is this something you can fix?

This has been fixed with https://github.com/dotnet/AspNetApiDocs/pull/207


Please, make a project version without cocoa pods

macOS Catalina future users will be very grateful if you remove cocoa pods from the project... ;)

Btw, very interesting project! Thanks for your efforts!

Hello,
Do you mean that you want me to make a sample project without cocoa pods?
Thanks,
Jack

Well, only if you want to do it, yes!


Made playground its own page

Very small change to make the playground its own page, different to being part of the documentation. (I think this will become increasingly useful as functionality is added)
This allows it to be much larger on the page.

Alternative names, not using Playground for the label or the route name:

Try (source)
Repl

(btw, I did something in netlify such that the next push will trigger a deploy preview, should be deploy-preview-223--squiggle-documentation.netlify.app but a bot will comment as much on github when the push happens).

@quinn-dougherty - Fair points. That said, I think these ideas should be for future refactoring, instead of this PR.
Also, my guess is that the order of the header doesn't matter much at this point, but I agree with the main point, I think.


fix: adjust filter query for log_metric_filter_organization

I just noticed that the query is missing the brackets and thus triggering even though the rule has been setup correctly

@misraved will this PR get considered for an upcoming release?

@rajlearner17 ping just to avoid this is getting lost ;)

@ecktom Yes, it is going to be a part of this release

@ecktom thanks for bringing this out, while we getting ready to release, we figured out this. Sorry for that, I could not follow back on it.  Assuring that we are looking this to get in next week's release along with some additional changes planned.


Epic: Deploy NeonVM and autoscaling in all regions

Motivation
We need to prepare our production environment to enable autoscaling for the whole user base.
Tasks

[x] Deploy NeonVM in us-west-2
[x] Deploy Autoscaling in us-west-2
[ ] Enable Autoscaling for users in us-west-2
[x] Deploy NeonVM in us-east-1
[x] Deploy Autoscaling in us-east-1
[ ] Enable autoscaling for users in us-east-1

Deployed the components to us-east-1 and us-west-2, not yet enabled for users so I added those bullet points.
ref https://neondb.slack.com/archives/C03F5SM1N02/p1689919510993619


The option setting 'android.enableR8=true' is deprecated.

Hi,
I am using versions geolocator: ^8.2.1.
Now when I open the Android module of the flutter project in Android studio, I get this error:
Gradle project sync failed. Basic functionality (e.g. editing, debugging) will not work properly
In the window on the bottom I get this:
The option setting 'android.enableR8=true' is deprecated.
It will be removed in version 5.0 of the Android Gradle plugin.
You will no longer be able to disable R8
Affected Modules: geolocator_android
Now, in my gradle.properties I removed the line 'android.enableR8=true'. but it doesn't help, because the error is coming from this module.
What can I do?
Thanks

Hi @bermanapps,
I have just released an update of the geolocator_android plugin that should resolve this issue. Please make sure you run flutter pub upgrade to get the latest version of the geolocator and its dependencies.


wd_demo: improved messages in console

Pull request
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Please ensure you have read and noticed the checklist below.
Checklist
Put an x in the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!
This is simply a reminder of what we are going to look for before merging your code.

[x] I have read and noticed the CODE OF CONDUCT document
[x] I have read and noticed the CONTRIBUTING document
[ ] I have added necessary documentation or screenshots (if appropriate)

Types of changes
Please check x the type of change your PR introduces:

[ ] Bugfix (change which fixes an issue)
[x] Feature (change which adds functionality)
[x] Code style update (formatting, renaming)
[ ] Refactoring (functional, structural)
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?
wd_demo.au3 messages in console were distinguishable from wd_core.au3 and wd_helper.au3 only by color
What is the new behavior?
currently wd_demo.au3 messages in console are prefixed with wd_demo.au3:
This helps to distinguish demo messages from UDF messages
Additional context
Add any other context about the problem here.
System under test
Please complete the following information.

OS: [e.g. Windows 10]
OS Arch.: [e.g. X64]
Browser [e.g. firefox]
Browser version [e.g. 96.0.3]

I don't see why this change is needed since (as you've already pointed out) you can identify the wd_demo "messages" by color. Technically, you could also use RegEx to locate the lines beginning with the character set [^+-!].
P.S. I see that we are using all four of these prefixes (^, +, -, and !). Is that needed / desirable?

It helps me a lot in understanding what I see in the logs.
This is something like contextuall reading.
In this way I have better focus on messages wd_demo.au3.
I can easily distinguish them from UDF messages.
The same way it should help new commers to easier understand how the code works.

Ok, but I don't see how adding "wd_demo.au3" improves the readability of the log. Personally, I would think adding "ConsoleWrite('@@ Debug(' & @ScriptLineNumber & ') : " would be much more beneficial so that they can see which line generated the message and quickly jump to it.

Personally, I would think adding "ConsoleWrite('@@ Debug(' & @ScriptLineNumber & ') : " would be much more beneficial so that they can see which line generated the message and quickly jump to it.

Thanks.
Take a look on: F4 Feature

Take a look on: F4 Feature

It isn't clear exactly what you wanted me to see. From what I can see, you can't use the prefixes in combination with @ to get the line jump feature.

Fine. However, some of your changes seem inconsistent. For example --
ConsoleWrite("> wd_demo.au3: _WD_Startup" & @CRLF)
vs
ConsoleWrite("wd_demo.au3: (" & @ScriptLineNumber & ") : URL=" & _WD_Action($sSession, 'url') & @CRLF)
Shouldn't these be formatted in a similar fashion?

the first are from main fucntions
the other from the Demos

🤷♂


deployments to jitpack aren't monitored

The instructions to use flagsmith give wrong information, indicating that it should work to use the current release version in a maven depenencty string.
Instead, the last few versions have failed packaging over on jitpack.
https://jitpack.io/com/github/Flagsmith/flagsmith-kotlin-android-client/v1.7.0/build.log
> Task :FlagsmithClient:bundleReleaseTestFixturesAar
> Task :FlagsmithClient:generateMetadataFileForReleasePublication
> Task :FlagsmithClient:publishReleasePublicationToMavenLocal
> Task :FlagsmithClient:publishToMavenLocal

BUILD SUCCESSFUL in 57s
62 actionable tasks: 60 executed, 2 up-to-date
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Dhttps.protocols=TLSv1.2
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Dhttps.protocols=TLSv1.2

Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Dhttps.protocols=TLSv1.2

Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Dhttps.protocols=TLSv1.2

Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Dhttps.protocols=TLSv1.2
Archive: Flagsmith:FlagsmithClient:1.7.0
Publication: com.flagsmith:flagsmith-kotlin-android-client:1.7.0
Build tool exit code: 0
Looking for artifacts...
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Dhttps.protocols=TLSv1.2
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Dhttps.protocols=TLSv1.2
Looking for pom.xml in build directory and ~/.m2
Found artifact: com.flagsmith:flagsmith-kotlin-android-client:1.7.0
Found artifact: Flagsmith:FlagsmithClient:1.7.0
Found artifact: com.flagsmith:flagsmith-kotlin-android-client:1.7.0
ERROR: Time-out getting container status
Error building

This is a specific problem, but the larger problem is that the results aren't monitored or are not cared about.

Hi @chadmiller , thanks for raising this, and apologies for the lack of monitoring here. We're in the process of moving everything across from jitpack to maven so it seems this build failures have slipped through. We'll take a look as soon as we can.

@chadmiller as of version 1.7.1, all builds will be published to maven central and this should be the location used by customers from then on. We will be removing support for jitpack in the near future. Can you confirm if you're having issues using maven central and if so, please provide details?

As mentioned above, we are no longer actively maintaining support for jitpack, all builds should now be obtained from maven central. See here for details. The documentation at docs.flagsmith.com/clients/client-side/android/ has also been updated.
If you have any further questions or comments, please let me know @chadmiller . Thanks again for raising the issue.


News160: update MuSig2 description

As with the other rare occasions where we've made a significant post-publication edit, I'll add a Corrections section to next week's newsletter linking back here.

Concept ACK. The relevant discussion is here: https://gnusha.org/secp256k1/2021-08-04.log
Sorry I didn't catch this in review. Maybe we could have asked a libsecp expert for a quick review since this stuff is still moving quite quickly.

Maybe we could have asked a libsecp expert for a quick review since this stuff is still moving quite quickly.

Agree, that was my fault for not doing so.

Agree, that was my fault for not doing so.

Nope. I could easily have suggested that during review.

This looks ready to merge to me. Thanks for the review, @jonasnick!


Added support to preserve important comments marked with <!--! ... -->

Fixes https://github.com/Polymer/polymer-bundler/issues/545
[x] CHANGELOG.md has been updated

LGTM

To the reviewer: desire to include <!--! stems from the forms usage in html minifiers for comment preservation plus the form has no side-effects like <!--# directives, so is an inert option for users wishing to preserve some comments.

kthx :)

Not even a quick workaround, just for the time being???

@andreabioli what are you asking about?

Sorry, wrong thread... I wanted to ask this question in this one, https://github.com/Polymer/polymer-cli/issues/779, but I jumped here... :-(
What can I do, now? May I move my request?
Sorry again...

@andreabioli No worries, I figured you accidentally posted in the wrong thread. Just post it over there :smile:


Fixes related to recent changes in SelectGameScreen

Contains
Quick fix for issue #3378.
And small improvement - skip showing SelectGame screen when no saved games are present by pressing ESC key on CreateGame screen.
How to test
[issue #3378]:

Run a headless server
Run the game normally as a client
Connect to the server and leave again

Expected: Log should be clear
[issue with ESC]:

Remove saved games if exist
Open Single player
Press Back button and/or key ESC -> result should be the same.

Hooray Jenkins reported success with all tests good!


Set docker_uid to root if TEST_INSTALL=yes

This conditional existed in the original PR but for some reason was removed.

This change is

Do we need this for any of the existing builds?  And if we do, can we get the same coverage from the ci/kokoro/readme and/or the ci/kokoro/install builds?

Do we need this for any of the existing builds?

Not sure, I was doing it to be consistent. Based on your other comment it may be better to go for the non-root approach.


feature: deobfuscating track names

Context
For various reasons, apps may choose to obfuscate the names of trace events, and thus need to be deobfuscated to be readable by a human.
Currently perfetto allows for deobfuscating slice names in traces by appending a packet with SliceNameTranslationTable: https://perfetto.dev/docs/reference/trace-packet-proto#TranslationTable
This allows deobfuscating slice names. However, some tracks, particularly async tracks, inherit their default track name from the slice names. This causes obfuscated names to appear in tracks with no way to remove them.
Proposal
I propose we extend the TranslationTable proto linked above to have a new field that allows for deobfuscation of track names as well. I think we should also limit this to deobfuscating the names of async tracks only to avoid potential false positive matches against thread names.

The proposal seems intuitively reasonable but there are a lot of subtle points to take into account:

The idea to only address non-thread tracks makes sense but there are a lot of track types in trace processor apart from just thread/process async tracks: see https://cs.android.com/android/platform/superproject/main/+/main:external/perfetto/src/trace_processor/importers/common/track_tracker.h
Which one of these types should we address? Just process? Process and global? Everything?
Should we only handle only events coming from TrackEvent or from all sources? For SliceTracker, we actually map all event sources but this might not be appropriate for tracks.
Or should we scrap all the above and maybe reuse the slice deobfuscation logic for tracks as well when we use the slice name as the track name? That would simplify things a lot and remove edge cases but may not be flexible enough for what you want.

Note also that that you should prepend the translation packet not append it: appending will work until you collect long (write_into_file) traces at which point it will subtly break in the current implementation :)

cc-ing @aMayzner to keep her in the loop on this too.

The idea to only address non-thread tracks makes sense but there are a lot of track types in trace processor apart from just thread/process async tracks. Which one of these types should we address? Just process? Process and global? Everything?

Thanks for pointing out the various track types. for context, i was hoping to cover at least the following cases:

track_event begin/end Tracing SDK apis.
ATRACE_ASYNC_*  (Track name is implicitly specified through slice name)
ATRACE_ASYNC_FOR_TRACK_* (Track name is EXPLICITLY specified through the API)

I think those will all show up as process_tracks, i think translating those should be sufficient. AFIK it is not possible for ATrace to emit global tracks, but i'm unclear if that is possible to do via the Tracing SDK or not.

Should we only handle only events coming from TrackEvent or from all sources? For SliceTracker, we actually map all event sources but this might not be appropriate for tracks.

Mentioned above, but i think the same logic makes sense to apply for other data sources like atrace as well.

Or should we scrap all the above and maybe reuse the slice deobfuscation logic for tracks as well when we use the slice name as the track name? That would simplify things a lot and remove edge cases but may not be flexible enough for what you want.

I think this still might be good behavior to have and would help many, bot not all cases. There are several cases this won't work fully, where the track is given a name explicitly that is obfuscated either through TrackDescriptor name or via ATRACE_AYNC_FOR_TRACK APIs.
I can see both explicit and implicit track renaming able to coexist though without causing issues.

Note also that that you should prepend the translation packet not append it: appending will work until you collect long (write_into_file) traces at which point it will subtly break in the current implementation :)

Thanks! good to know. I'll keep that in mind :)

I think those will all show up as process_tracks

Yup you're correct, those are all process tracks

i'm unclear if that is possible to do via the Tracing SDK or not.

AFAIK (unless I'm misremembering) yes it's possible.

I think this still might be good behavior to have and would help many, bot not all cases.

Ack makes sense.
Given you only care about process scoped tracks for now, I'd restrict any changes to just process scoped tracks. I'd suggest doing the following:

Add a new "ProcessTrackNameDeobfuscation" packet which looks very similar to the current SliceName deobfucation packet
Change TrackTracker's logic to use this for all Process scoped tracks (note that counter tracks would also probably be changed)
Change TrackEventTracker::GetDescriptorTrackImpl which, for complicated reasons, does not set the track name until a bit later

Are you planning on sending a patch to support this? :)

Sounds good, and sure, I can spend some time working on a patch for this.

submitted https://android-review.googlesource.com/c/platform/external/perfetto/+/3079666 to address this


double quotes followed by punctuation

When double quotes are followed by a punctuation mark (e.g. comma or period), they are rendered as opening, instead of closing, double quotes.

This can be fixed in quotes.js. I'll look into it later.

i'd like to help but it looks a bit overwhelming...
On Tue, Aug 18, 2015 at 11:58 PM, David Merfield<EMAIL_ADDRESS>wrote:

This can be fixed in quotes.js
https://github.com/davidmerfield/Typeset/blob/master/src/quotes.js#L14.
I'll look into it later.
—
Reply to this email directly or view it on GitHub
https://github.com/davidmerfield/Typeset/issues/10#issuecomment-132348647
.


Fix error from not being able to find IP on Virtualbox start

Depends on: https://github.com/docker/machine/pull/1347
Closes: https://github.com/docker/machine/issues/1346
I'm still seeing occasional "exit 1" errors on stop (not sure why; might be a different issue), but this fixes up the IP address not found issue and cleans up a tiny bit of code duplication in host.go.  This PR makes VBox wait for an IP to be grabbed from DHCP before returning from Start (should fix some issues KM is seeing around not being able to find IP address)
cc @ehazlett @jeffdm

Rebased after merge of the panic fix!

LGTM


chore(master): release 1.2.59

:robot: I have created a release beep boop
1.2.59 (2023-09-12)
Miscellaneous

deps: update dependency phpunit/phpunit to v10.3.4 (06981ad)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/php-cs-fixer-config/releases/tag/v1.2.59 :sunflower:


docker container not running after created

hello,
I used your docker container and getting this error in logs:
RTNETLINK answers: Operation not permitted
Cannot find device "qemubr1"
KVM not available, running in emulation mode. This will be slow.
udhcpd: started, v1.36.1
udhcpd: max_leases=235 is too big, setting to 1
udhcpd: can't open '/var/lib/udhcpd/udhcpd.leases': No such file or directory
udhcpd: ioctl 0x8933 failed: No such device
qemu-system-x86_64: -nic tap,id=qemu1,mac=54:05:AB:CD:12:31,script=/routeros/qemu-ifup,downscript=/routeros/qemu-ifdown: could not open /dev/net/tun: No such file or directory
how to fix this issue?
thanks.

Hi!

KVM not available

Mean KVM disabled in BIOS

Got the same problem here. And I have checked BIOS and there is no KVM options there. If you mean the virtualization option, then it is already enabled. Do I need to install some packages in my host OS? I am using EndeavourOS.

Sorry, I found the problem. Turns out I have not installed qemu in my host OS. This is what I did :

Install qemu

yay -S extra/qemu-base

Create docker-compose.yml file

routeros-latest:
    image: evilfreelancer/docker-routeros:latest
    restart: unless-stopped
    cap_add:
      - NET_ADMIN
    devices:
      - /dev/net/tun
      - /dev/kvm
    ports:
      - "22222:22"
      - "22223:23"
      - "7777:80"
      - "8728:8728"
      - "8729:8729"
      - "28728:8728"
      - "28729:8729"

Run docker-compose

docker-compose up

Try to access localhost:7777 from browser


Feature Idea: Pick2 Pick3 -- deeper nested picking!

https://gist.github.com/staltz/368866ea6b8a167fbdac58cddf79c1bf
Basically: Pick<> only unpacks one level. It'd be nice to be able to pick deeper into nested objects!

This looks useful, want to submit a PR?

Implemented in #16


Critical Crash on Payment Success Handling in Google Pay Flutter Plugin Affecting 350+ Users

Crash on Payment Success Handling in Google Pay Flutter Plugin
Description:
We have encountered a critical issue in the Google Pay Flutter plugin that is causing crashes during the payment success handling process. This issue has been reported by multiple clients and is currently affecting over 350 users.
Stack Trace:
io.flutter.plugins.pay_android.GooglePayHandler.handlePaymentSuccess (GooglePayHandler.java:6)
io.flutter.plugins.pay_android.GooglePayHandler.onActivityResult (GooglePayHandler.java:6)
io.flutter.embedding.engine.FlutterEngineConnectionRegistry$FlutterEngineActivityPluginBinding.onActivityResult (FlutterEngineConnectionRegistry.java:25)
io.flutter.embedding.engine.FlutterEngineConnectionRegistry.onActivityResult (FlutterEngineConnectionRegistry.java:13)
io.flutter.embedding.android.FlutterActivityAndFragmentDelegate.m (FlutterActivityAndFragmentDelegate.java:16)
io.flutter.embedding.android.FlutterFragment.onActivityResult (FlutterFragment.java:10)
io.flutter.embedding.android.FlutterFragmentActivity.onActivityResult (FlutterFragmentActivity.java:5)

Impact:

Affected Users: 350+
Severity: High – This crash is significantly impacting the user experience and potentially leading to loss of transactions.

Request for Update:
Is there any progress or update on this issue? Given the severity and impact on our users, a prompt resolution or workaround would be greatly appreciated.
Additional Information:
If any further details or logs are needed, please let us know. We're eager to collaborate to resolve this issue as quickly as possible.

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

This PR should fix: https://github.com/google-pay/flutter-plugin/pull/276#pullrequestreview-2281010300

@ViniciusDeep has this fix been pushed at all?
I see there were some fixes in the android package but have these been filtered through to this package?
I ask as I am getting fatal crashes on receiving a payment result from Google Pay.

Hi @SamuelMTDavies, the update is available in beta. Check out version 3.0.0-beta.2. Feel free to share insights about your experience with it.

@JIUgia - I have upgraded and its not crashing on Android but i may have found a bug. I will post it here and if deemed necessary i will put it n a separate issue.
This function I took from the advanced example:
void _showPaymentSelectorForProvider(PayProvider provider) async {
    try {
      debugPrint('Starting payment selector...');
      final result = await _payClient.showPaymentSelector(provider, [
        PaymentItem(
          label: 'into your ---- wallet',
          amount: validAmount,
          status: PaymentItemStatus.final_price,
        )
      ]);
      debugPrint('Payment selector result: $result');

      // The error might occur here
      context.read<PaymentsBloc>().add(GooglePayResponseSelected());
    } catch (error) {
      debugPrint("Caught an error: ${error.toString()}");
ScaffoldMessenger.of(context).showSnackBar(
        SnackBar(
          contentType: ContentType.failure,
          message: 'There was a problem setting up your payment.',
        ),
      );
    }
  }

This try block errors and the SnackBar is shown before the payment selector appears. The payment selector appears and I can get the result.
The error logs:
I/flutter (20680): Starting payment selector...
E/FrameEvents(20680): updateAcquireFence: Did not find frame.
I/flutter (20680): Payment selector result: {}
I/flutter (20680): Caught an error: type 'Null' is not a subtype of type 'String'

I assume this is to do with the _googlePayResultSubscription Stream receiving Null before the paymentSelector is shown? I haven't had any chance to look into this mechanism and I don't have much android specific knowledge.
// A method to listen to events coming from the event channel on Android
  void _startListeningForPaymentResults() {
    _googlePayResultSubscription = eventChannel
        .receiveBroadcastStream()
        .map((result) => result.toString())
        .listen(debugPrint, onError: (error) => debugPrint(error.toString()));
  }

I would like to know if this code smell is right and we can account for it in the next beta version? Do you want me to open this in a separate issue?

Hi @SamuelMTDavies, the error happens exactly at the line you are pointing out, very likely  triggered by the logic called by Provider when you receiving a result. That logic is surely expecting a populated object and encountering an empty JSON string, such that when you look for certain properties in there, a null result is returned, hence the exception.
Note that for platforms that use asynchronous means to return the result, calling showPaymentSelector only returns an empty string if the subscription got created without errors. In other words, you won't get a Google Pay result. The readme has a detailed excerpt on the topic in the Advanced section.
I've also added a few extra lines in the advanced.dart example to make this a little more explicit.
Let me know if that works for you.

@JlUgia Just for my own clarity.
This code always returns null if the payment selector is successfully shown?
final result = await _payClient.showPaymentSelector(provider, [
        PaymentItem(
          label: 'into your ---- wallet',
          amount: validAmount,
          status: PaymentItemStatus.final_price,
        )
      ]);
      ```

  and that any result from the payment selector will be received here:

// A method to listen to events coming from the event channel on Android
void _startListeningForPaymentResults() {
_googlePayResultSubscription = eventChannel
.receiveBroadcastStream()
.map((result) => result.toString())
.listen(debugPrint, onError: (error) => debugPrint(error.toString()));
}

I can follow this logic but would suggest that the advanced example is updated to make this clearer and stop it from trying to Cast Null.

Hi @SamuelMTDavies, that's exactly right. Any platform that uses asynchronous mechanisms to return a result will see showPaymentSelector returning null.
I think that the null casting was never part of the advanced.dart example. It looks like that was only present in your code. In any case, we've updated the advanced sample to make it more obvious.
There are other options to handle this, which I'll note here for potential future use based on feedback from you and other developers:

Solution
Pros
Cons

Use a stream to receive payment information only on platforms that need it (current solution)
Same API signature
The same call returns different values depending on whether the platform issues payment results synchronously or asynchronously

Use a stream to receive payment information on all platforms
Same API signature and behavior
Unnecessary complexity on platforms that can't respond synchronously

Introduce separate API/methods to handle different platforms based on their synchronicity requirements
Integrating each platform separately is more straightforward
Having shared logic across platform becomes more challenging

Update the showPaymentSelector method to return a composite object that has information about what happened during the call (eg.: a stream was started, a result is returned)
Keeps APIs consistent across platform and reduces confusion
Breaking change

I've got it working in the test environments but it does seem a little temperamental. It's a pain having to test on real iOS devices and that the results come in two places depending on the device but it will have to do.
Does the bool the canUserPay function returns change based on the Payment Configuration? I'm trying to understand why a Google Pay button shows up on a device with testing config and then doesn't show on the same device with production config.

The temprementality is whether the Google Pay or Apple Pay button shows or not. I am testing across the simulator, emulator, real iPhone and android devices.
Sometimes it works fine on the emulator then wont show on the real device. I have an android device that had the full flow working in the test environment and then when we tried to test a production setup the button wouldn't show.
We only removed the "environment": "TEST" from the configuration string. I am beginning to wonder if the string implementation of the config is too prone to formatting issues as I can see no other reason for the button to not show when removing a single line of config only.
As for your question on implementation i personally would lean towards the first or last option. The first option feels disconnected from the package to me having the traditional _onButtonPressed, _onResultReceived, _onError is clear and clean, similarly if you can subscribe to a single stream and understand the errors that can be thrown and why thats equally workable.

It's also odd to pass the Google Configuration the the Pay client instance and then provide the configuration a second time on the RawGoogleButton - which one is used? Its easy for people to update one and not the other, which could be easily missed.


Stable Release

Describe the feature you'd like
when will a stable version would be released?
Describe the benefits this feature would bring to BookStack users
I've just read a forum thread in softaculous forum
in which someone suggest adding BookStack to softaculous list of one click installation apps
but Softaculous Team refused to add BookStack because of unavailability of a stable version (only beta versions exist)

Thanks for the request @Haboubi92,
I would likely not look to change the stability of the project itself, since I'm happy with the stability we are able to offer. That said, This is primarily about dropping the beta status from releases. I've opened #2570 as a starting point for discussions to eventually achieve this. Since #2570 would cover the core request here I'm going to close this off.

@ssddanbrown thanks ♥


Qcow2 preallocation features

Author Name: Bastien Cadiot (Bastien Cadiot)
Original Redmine Issue: 2767, https://dev.opennebula.org/issues/2767
Original Date: 2014-02-28

Hello,
Recently we set up a new OpenNebula environnement for the need of system architects.
We use this platform as a mirror of the production (only physical platform) for testing configurations, kickstart, etc...
But physical drives have a lot of space avalaible contrary to vm. For this reason we use qcow preallocation metadata, to allow storage overallocation.
To integrate this into opennebula we change the way the driver works, but this broke the creation of other image type.
Currently the way OpenNebula create image isn't compatible with preallocation because it use "dd" or a pipe with "cat".  For example :
Datastore/fs/mkfs :

Original : exec_and_log "$DD if=/dev/zero of=$DST bs=1 count=1 seek=${SIZE}M"
Qcow Preallocation : exec_and_log "/usr/bin/qemu-img create -f qcow2 -o preallocation=metadata $DST ${SIZE}M"

Datastore/fs/cp

Original : COPY_COMMAND="$UTILS_PATH/downloader.sh $DOWNLOADER_ARGS"
COPY_COMMAND="/bin/cp --sparse=always $SRC $DST"

Currently this works, but we have to be sure that when creating a image, qcow2 type is used, otherwise the vm won't start.
It would be great to upgrade the fs driver to allow qcow preallocation (and probably some transfer driver to manage the volatile mkimage or cloning).

Original Redmine Comment
Author Name: Bastien Cadiot (Bastien Cadiot)
Original Date: 2014-03-10T12:00:44Z

Hi Ruben,
I'm reading the docs and qcow2 driver code, but I'm always thinking that OpenNebula isn't designed for the moment to allow sparse in storage.
Qcow2 tm drivers allow to create qcow2 images but without any specific options. For example (CLONE_CMD="cd $DST_DIR; $QEMU_IMG create -b $SRC_PATH -f qcow2 $DST_PATH"), this do not allow to add "-o preallocation" feature.
In the same way QCOW2 fstype, and qcow2 TM clone has a strange behaviour. The driver create the image with a DD, then qemu-img replace this file...
Example Datastore/fs/mkfs :
exec_and_log "$DD if=/dev/zero of=$DST bs=1 count=1 seek=${SIZE}M" \
    "Could not create image $DST"
exec_and_log "$MKFS_CMD" \
    "Unable to create filesystem $FSTYPE in $DST"

I still don't know what is the best way to achieve this. Patch current ds driver (fs) and tm driver (qcow2) to allow preallocation feature, or create a new DS driver based on the FS one ?

Original Redmine Comment
Author Name: Ruben S. Montero (@rsmontero)
Original Date: 2014-03-10T10:51:32Z

I think this is already covered:

When creating a datablock, simply use FSTYPE=qcow2, either for datastore images http://docs.opennebula.org/stable/user/references/img_template.html or for volatile disks http://docs.opennebula.org/stable/user/references/template.html#volatile-disks with FORMAT

To clone using qcow features, just configure your datastore to use the qcow2 drivers http://docs.opennebula.org/stable/administration/storage/fs_ds.html#using-the-qcow2-transfer-driver

Original Redmine Comment
Author Name: Ruben S. Montero (@rsmontero)
Original Date: 2014-03-10T12:10:05Z

You are right , for some reason I over-read the preallocation part, and just though the issue was tu use qcow specific actions :(
Maybe we can add a QEMU_OPTIONS variable to scripts_common.sh and then use it for QEMU_IMG. Another alternative would be to apply this just to the fs drivers, like we did for ceph (e.g. take a look to ceph/ceph.conf, we have  QEMU_IMG_CONVERT_ARGS there)
Moving this issue to our backlog to implement it in future releases. In the meantime just be careful when upgrading to preserve your modifications (we are also looking to the best way to keep driver modifications...)
Thanks Ruben

https://github.com/OpenNebula/one/blob/63eb2447db602a964029441a6b77ad7735a953d2/src/tm_mad/tmrc#L27


Add more complete installation instructions

Proposing more complete installation docs, suggesting pip install for
the stable releases and python setup.py install for installation from
sources.
For people that don't have pip, we point them to the Python installation in the hitchhiker's guide, that has nice instructions for having the basics (setuptools, pip and virtualenv): http://docs.python-guide.org/en/latest/starting/installation/

Quick preview:

This is great, @eliasdorneles.

glad you liked it. :)


jspm 0.17 beta upgrade

I'm doing some testing with Aurelia and the jspm 0.17 beta.  It all works if I add .js extensions to all <require from="... elements, all moduleid props in route configs, and to the module id in the aurelia-app attribute.  Alternatively, it works if I add defaultJSExtensions: true to the config but @guybedford says that is deprecated, and every time I use the jspm cli the attribute is removed.  Here's what he said about it:  :point_up: April 1, 2016 1:17 PM
Another option that works is monkey patching the ViewEngine:
import {ViewEngine} from 'aurelia-templating';
ViewEngine.prototype.standardImportViewModelResource = ViewEngine.prototype.importViewModelResource;
ViewEngine.prototype.importViewModelResource = function(moduleImport, moduleMember) {
  return this.standardImportViewModelResource(moduleImport + '.js', moduleMember);
};

What's the recommended approach?

The way to avoid manually adding extensions, is to use package configuration defaultExtension. Any code that is defined to be contained within a package boundary will get default js extensions.
It sounds like this is something where Aurelia should provide some guidance on the upgrade path. Just let me know if you have any further questions at all here.

Current skelly is mostly jspm v0.16 style app. It does not use the package configuration  feature of latest SystemJS. Another thing to consider is that we now have to deal with two config files: jspm.config.js and browser.config.js instead of single config.js that we currently have.
Besides updating skelly to the latest version of jspm I think we need to update individual dependencies(bootstrapper, router, framework etc) too. All of our modules are using defaultJSExtenstions

If/when aurelia moves to jspm 0.17 it sounds to be quite a bit of work. Judging by the timescales and push to get aurelia 1.0 released I guess this won't make it?

Aurelia should already support jspm 17. It's just that the skeletons have not been updated yet. We would like to get that done, but doubt it will happen for release. In general, we would like people to use the CLI for getting started anyways going forward.

Does this mean this issue will not be moving forward? I've read elsewhere that aurelia-bundler was not working as expected when they upgraded to 0.17 beta

We are working on it now.
On Sep 30, 2016 4:21 AM, "Andrew Camilleri"<EMAIL_ADDRESS>wrote:

Does this mean this issue will not be moving forward? I've read elsewhere
that aurelia-bundler was not working as expected when they upgraded to 0.17
beta
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aurelia/skeleton-navigation/issues/387#issuecomment-250720717,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIBnYMOZsqbL9ZwAp8HiJdrXNQpgg1xks5qvPCjgaJpZM4H-dDg
.

@Kukks  We are tracking bundler related issue for this here. https://github.com/aurelia/bundler/issues/129

Any updates for this request?

We've been working on testing Aurelia with the systemjs 0.20.0 release candidate.
The upcoming release will be compatible with rc 7.
https://gist.run/?id=6f80961a136bef7dbb5f3672d0600108

closing: https://github.com/aurelia/loader-default/pull/38


evaluateOnNewDocument is broken on firefox

Steps to reproduce
Tell us about your environment:

Puppeteer version: 5.0.0 (and 3.3.0)
Platform / OS version: MacOS 10.15.5
Node.js version: v12.14.0

What steps will reproduce the problem?

Run this code

const puppeteer = require('puppeteer');

(async () => {
  const browser = await puppeteer.launch({
    product: 'firefox',
  });
  const page = await browser.newPage();
  await page.evaluateOnNewDocument(() => {
    window.addEventListener('DOMContentLoaded', () => console.log('Loaded!'));
  });
  page.on('console', (msg) => console.log(msg.text()));
  await page.goto('http://example.com');

  await browser.close();
})();

What is the expected result?
Print Loaded!on console.
What happens instead?
It doesn’t print Loaded!
Note:
It works on chrome.

Here is my console outputs when running with dumpio: true:
*** You are running in headless mode.
DevTools listening on ws://localhost:59266/devtools/browser/803e566d-14bb-074a-92df-37b0f55a82fa
[GFX1-]: Receive IPC close with reason=AbnormalShutdown
Exiting due to channel error.
[GFX1-]: Receive IPC close with reason=AbnormalShutdown
[GFX1-]: Receive IPC close with reason=AbnormalShutdown
Exiting due to channel error.
Exiting due to channel error.

@mjzffr @whimboo might be one for you :)

The corresponding protocol-level work in Firefox is tracked at https://bugzilla.mozilla.org/show_bug.cgi?id=1601695

@jackfranklin @mathiasbynens It would be helpful to have issue labels to distinguish client versus server browser-specific issues, e.g. firefox-client for an issue at the Puppeteer level, e.g. with launch/install and just firefox for protocol implementation such as this issue.

@mjzffr Thank you for the tracking link.
If I understand correctly, it is not a bug, it is just not implemented yet!
Since all this ticket dependencies are resolved, Do you know when to expect an implementation? and if there is a temporary workaround/hack?

@elharrak-bouygues That's right, Firefox support is still experimental. I'm not aware of a specific timeline, but this part of the protocol has a higher priority than other features.

i hop this get high priority

It's broken in Firefox Nightly r94.0a1 which is used by puppeteer 10.4.0 too.

Sorry but we don't have the bandwidth to actually implemement this requested feature in Firefox. As such closing the issue.
Note that we also track in on our side via https://bugzilla.mozilla.org/show_bug.cgi?id=1601695.


internal: remove SyntaxRewriter

bors r+
🤖

bors r+

bors is not feeling great apparently :(
Merging manually

Looks like its not bors that's feeling unwell but github actions?


download function in openmim.commands.download module cannot find config file

Hello @zhouzaida, @ZwwWayne  ,
steps to reproduce:

install mmdet, mmcv-full and mim via pip:

pip install -U mmdet mmcv-full mim==0.1.2

or install mmdet via mim:

mim install mmdet

then call download function from mim:

from openmim.commands.download import download

download(package="mmdet", configs=['cascade_mask_rcnn_r50_fpn_1x_coco'])

error:
Exception has occurred: ValueError       (note: full exception trace is shown but execution is paused at: _run_module_as_main)
lib/python3.8/site-packages/mmdet/configs/cascade_rcnn/cascade_mask_rcnn_r50_fpn_1x_coco.py is not found.
  File "xxx.py", line 79, in download
    raise ValueError(highlighted_error(f"{config_path} is not found."))

reason:
this line creates a config path:
config_path = resource_filename(module_name, config_path)

directing to:
"lib/python3.8/site-packages/mmdet/configs/cascade_rcnn/cascade_mask_rcnn_r50_fpn_1x_coco.py"

but mmdet package doesn't include configs directory in the package so this is a bug that should be fixed.
solution:
add an argument local to download function and when local=False, download config files from mmdetection repo instead of searching in local mmdet package directory.

In fact, the config directory is copied from codebase directory to package directory by mim, so if we install codebase by pip, the config will be not found. Please refer to https://github.com/open-mmlab/mim/blob/main/mim/commands/install.py#L400

@zhouzaida install_from_wheel does not handle config directory issue: https://github.com/open-mmlab/mim/blob/1bb17cd47d5573f963542395d0f18c82b6d67710/mim/commands/install.py#L543
and mim install mmdet calls install_from_wheel function: https://github.com/open-mmlab/mim/blob/1bb17cd47d5573f963542395d0f18c82b6d67710/mim/commands/install.py#L217

if we install an openmmlab codebase (exclude mmcv), it will firstly clone the codebase from GitHub and install it. install_from_wheel just handles other packages.

The install command of mim will be refactored in the future version


Support new command: terminate

support new command: terminate

add unit test case

All tests passed in local environment, is any advice about the failure of travis-ci ?
➜  flink-deployer git:(feature-terminate) ✗ sh test-with-coverage.sh
ok      flink-deployer/cmd/cli  1.026s  coverage: 61.2% of statements
ok      flink-deployer/cmd/cli/flink    1.058s  coverage: 83.6% of statements
ok      flink-deployer/cmd/cli/operations       2.266s  coverage: 82.8% of statements

Isn't this a duplicate of the Cancel feature? Cancel also does a PATCH to jobs/%v although admittedly, your implementation does also support specifying the mode. Do you mind merging your terminate method with the already available Cancel method? I'm not sure about the travis build, I'll dig into this later on

In fact, there is a little difference between Cancel and Terminate,  Terminate did not use retryablehttp to build the request, because retryablehttp will retry automatically when response status code is 500 and can not get the response body which includes error info about the failure()..
But when flink job is not stoppable and terminated with mode stop,  the status code is 500 with a json error info  body.
{
"errors": ["the flink job is not stoppable"]
}

Thus I am not sure whether the implement of Terminate can replace Cancel now,  I am planning to give another pr later to combine Cancel with Terminate when the difference is handle appropriately. Is that OK?

I see, so the difference is mostly on our side since the Flink API will already do retrying for us. However, that only counts if our request actually made it to the flink cluster. If a networking error occurs during request time, we would still need retryablehttp to retry it for us. I think we can use CheckRetry with retryablehttp to exclude that specific 500 error from retrying. This would solve all cases right?
Besides that, I noticed that you're not using c.newRequest(..) to do the call, which indeed skips using retryablehttp but also skips adding the authentication headers that were added in version 1.1.
All by all, it'd be great to have only 1 CLI command that handled this logic in a proper way instead of merging this Terminate functionality which is similar to Cancel but skips authentication added in 1.1
Let me know what you think

Yes, you are right, I will try CheckRetry and left only 1 CLI command, but I prefer to rename Cancel to 'Terminate',  to keep the same with flink rest api,  do you agree ?

Agreed. Changing it to terminate to support both cancel and stop makes the most sense. Looking forward to reviewing it again.

Should I open a new pr for clean commit history,  or just use the current pr, which is better? @mrooding

whatever you choose. I'm fine with both. If you do keep this one, please update the title of the PR.

Codecov Report

Merging #36 into master will decrease coverage by 2.25%.
The diff coverage is 37.31%.

@@            Coverage Diff            @@
##           master     #36      +/-   ##
=========================================
- Coverage   55.05%   52.8%   -2.26%
=========================================
  Files          12      13       +1
  Lines         514     570      +56
=========================================
+ Hits          283     301      +18
- Misses        186     219      +33
- Partials       45      50       +5

Impacted Files
Coverage Δ

cmd/cli/flink/client.go
81.81% <ø> (ø)
:arrow_up:

cmd/cli/operations/terminate_job.go
0% <0%> (ø)

cmd/cli/operations/update_job.go
85% <100%> (ø)
:arrow_up:

cmd/cli/main.go
28.04% <32.25%> (+0.6%)
:arrow_up:

cmd/cli/flink/terminate.go
50% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a9c82...32c57f1. Read the comment docs.

Close current pr for clean commit history,  new pr is #37


Firmware representation

Be able to collect and represent ECU and other CU firmware version state on the vehicle. Similarly represent for a given vehicle architecture the available, latest version of firmware for its components. Comparison could take place either in-vehicle or cloud side.
Consider commercial fleet use cases - timing of OTA based on operational demands. Fleet operators may want to defer, need to represent approval and potentially timing.
Severity of security update[s] need to be conveyable, exposed to fleet operators as part of their consideration.

Is Uptane getting traction in HD trucks? How widely is it adopted by passenger vehicles?
Please provide links to prominent OTA efforts so we can evaluate the data needs for their processes, what we can collect.
eSync alliance, Uptane, SAE

Business Process Model and Notation (BPMN)
ISO 19510

Unified Diagnostic Services provides an interface for flashing ECUs in a vehicle.


Variable Experience Rollout [Part 0]

Motivation and Context
These are changes I made that either import QOL and/or are needed for Variable Experience Rollout (the new training system I've been working on).
In an effort to break up merging that code, I am sending in these changes first.
Summary of changes:

Improved logging from PPO. I've added things like grad norm, fraction clipped, predicted value, etc. These metrics are really useful for debugging.
Preemptable evaluation
Build the RNN packed sequence info during batching. This stops a pipeline bubble.
Always use the batching cache and make that a singleton. No reason to not use it.
Some additional helper functions in TensorDict. Most of those changes are a refactor to better support typing.
Evaluate episodes multiple times.
A gather_objects function that performs torch.distributed.gather but on arbitrary python objects.
A pretty big change to how the RNN seq info is built that I encourage you to ignore and just trust the unit test :)

How Has This Been Tested

Types of changes

New feature (non-breaking change which adds functionality)

@erikwijmans There are protocols available from typing_extensions, I would add them back.

A pretty big change to how the RNN seq info is built that I encourage you to ignore and just trust the unit test :)

Such a programmer flex :-).

@erikwijmans Since this PR and the subsequent PRs change so much of the training code, have you done an end-to-end test that the old code paths still work as expected? For example, does a Pick policy trained with DD-PPO work exactly the same as before?

None of this should impact any existing policies as this is almost entirely additive and the things that aren't are simple refactors, but checking is a good idea. I can check with a PointNav model. Do you have a pick model that I could test with?

I mean training a policy from scratch, not evaluating. I agree the changes are additive, but it does touch a lot of training code. Yes, I think it would be great if you could train a PointNav and Pick policy from scratch. Base command to train Pick policy:
python habitat_baselines/run.py --exp-config habitat_baselines/config/rearrange/ddppo_pick.yaml --run-type train

Seems to be the same within variation due to non-deterministic inference/training.

(Blue is this PR, orange is current main).


evidently.model_profile.Profile.calculate not populating default float values for 'confidence' or 'drift_share'

Hi, when running through the mlflow integration tutorial, the Profile.calculate function fails with TypeError exceptions, stating that mathematical operations are not supported between floats and NoneTypes.
The point where this is  failing is in the dataset_drift_evaluation function when comparing the calculated drift statistics with the default thresholds, as shown in the attached traceback screenshot:

If I explicitly specify:
column_mapping['drift_conf_level'] = 0.95
column_mapping['drift_features_share'] = 0.5
then everything works as expected.
(evidently version ==  0.1.23.dev0)

Hi @Jay-Down! We just recently implemented the Dataset Drift calculation using column mapping https://docs.evidentlyai.com/reports/data-drift#1-data-drift-summary. So there is no need to write a custom function anymore! We will update this example shortly. Stay tuned!

Hi @Jay-Down ,
Thank you a lot for reporting this!
Just made a fix, should be working now without explicit specification of the drift_conf_level and  drift_features_share in the column_mapping or config (for CLI running).


Setting container as Init breaks container list

To reproduce:

Go to Cluster Explorer -> Deployments -> Create
Select Add Container from Container menu (creates container-1)
Set container-1 as Init Container
Click Remove Container button (container-1 is still present in the list)
Click Remove Container button (container list disappears)

Works as expected in 2.5.8-rc17


notifications fail on utf8 chars fix

hey I noticed if utf-8 char appears in diff, the diff file presents it, but notification won't send. did some test to approve that this is the situation, minor fix - ignoring utf characters in notification service.
think it will help with bug #1044

thanks, I added a watch for that pokemon site on my dev site, and i'll wait to see how it looks with this change

what filter are you using? this change made no difference for me
the problem is in the xpath filter handling i believe

what filter are you using? this change made no difference for me
the problem is in the xpath filter handling i believe

I wasn't sure if it will help to this filter, Ill look at it specifically but, check your notifications - if there is difference in sites which includes utf-8 chars, the notifications handler crash.

@dgtlmoon Ill add demonstration test to this branch, but you can see it by adding "after-3.txt" with "אב" to the unit-test and check with test_notification_diff.py


VK API workflow fix if error happens on vk-side

Sometime vk_api function returns None (when vk.com is down for example) but user_data expects dict and fails.

Thanks!


docs(toh-6): copyedits

Remove statement that doesn't apply: "We recommend registering app-wide services in the root
AppModule providers" - but that isn't being done.
Adding parentheses after method names; a few were missed in the previous pass.
debounce() --> debounceTime()
Remove obsolete Dart prose.
Fix heading indentation.
Added missing closing </span>.
Fix misnamed Jade variables.

cc @kapunahelewong

Thank you @chalin!!

@wardbell - I agree with the goal of removing all blocks and variables, but this PR is only meant to "fix" a few issues. I'd rather the full cleanup be tackled in a follow-up PR.


PHOENIX-6342 RoundRobinResultIterator doesn't close itself when resul…

…t size = fetchsize-1

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
15m 51s
master passed

+0
hbaserecompile
22m 16s
HBase recompiled.

+1 :green_heart:
compile
1m  3s
master passed

+1 :green_heart:
checkstyle
0m 34s
master passed

+1 :green_heart:
javadoc
0m 51s
master passed

+0 :ok:
spotbugs
3m  2s
phoenix-core in master has 955 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
8m 21s
the patch passed

+0
hbaserecompile
17m 47s
HBase recompiled.

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
checkstyle
0m 35s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 51s
the patch passed

+1 :green_heart:
spotbugs
3m  9s
the patch passed

_ Other Tests _

-1 :x:
unit
111m 12s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 44s
The patch does not generate ASF License warnings.

163m 55s

Reason
Tests

Failed junit tests
phoenix.end2end.PermissionNSEnabledIT

phoenix.end2end.PermissionsCacheIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1114/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1114

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 9ea94fa310ed 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / ba47233

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1114/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1114/1/testReport/

Max. process+thread count
12456 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1114/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
15m 51s
master passed

+0
hbaserecompile
22m 16s
HBase recompiled.

+1 :green_heart:
compile
1m  3s
master passed

+1 :green_heart:
checkstyle
0m 34s
master passed

+1 :green_heart:
javadoc
0m 51s
master passed

+0 :ok:
spotbugs
3m  2s
phoenix-core in master has 955 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
8m 21s
the patch passed

+0
hbaserecompile
17m 47s
HBase recompiled.

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
checkstyle
0m 35s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 51s
the patch passed

+1 :green_heart:
spotbugs
3m  9s
the patch passed

_ Other Tests _

-1 :x:
unit
111m 12s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 44s
The patch does not generate ASF License warnings.

163m 55s

Reason
Tests

Failed junit tests
phoenix.end2end.PermissionNSEnabledIT

phoenix.end2end.PermissionsCacheIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1114/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1114

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 9ea94fa310ed 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / ba47233

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1114/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1114/1/testReport/

Max. process+thread count
12456 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1114/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Latest version isn't avalable on npm

Please publish the latest version on npm. On npm i just can install 0.4 now.

Version 0.5.1 published to NPM. Thanks for reminding it.


originalAppVersion returns build number on iOS and major and minor version number on macOS

Expected Behavior
The value should be consistent on both platforms.
Steps to Reproduce (for bugs)
let receipt = try InAppReceipt.localReceipt()
let originalBuildVersion = receipt.originalAppVersion // Returns "28" on iOS and "1.28" in native macOS app

Hello @DePasqualeOrg, thank you for bringing this up. Unfortunately, it's a feature, not a bug.
According to the documentation:

Original Application Version
The version of the app that was originally purchased.
ASN.1 Field Type 19
ASN.1 Field Value UTF8STRING
JSON Field Name original_application_version
JSON Field Value string
This corresponds to the value of CFBundleVersion (in iOS) or CFBundleShortVersionString (in macOS) in the Info.plist file when the purchase was originally made.
In the sandbox environment, the value of this field is always “1.0”.

Please let me know if you have any further questions. Thank you!


KAFKA-3290: fix race condition with worker task shutdown and mock validation

Ping @gwenshap @ewencp
I still haven't been able to reproduce the failure, but it seems possible for the mock validation to execute before the shutdown hook is called in WorkerTask. It's possible because we count down the shutdown latch prior to calling onShutdown(). So the fix is to call onShutdown() first, which actually seems more correct anyway.

LGTM

Not closing the JIRA, just in case....


Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed

Thanks for sharing your scripts and gradio client app.
Unfortunately, I am unable to use the molmo model via the gradio app on my server (Ubuntu 22.04 with 2x RTX A5000 48 GB VRAM) - the error  trace is below.
I wonder whether you have any suggestions as to what I could get it running :)
I followed exactly your instructions in the README, the only point is that I have CUDA Version: 12.2 and not 12.1 or 12.4 so I used 12.1 pytorch libraries.

Hi, try activating the environment through the terminal and enter the following commands:
Activate the environment:
.\venv-ui\Scripts\activate
Set the following environment variables:
set CUDA_LAUNCH_BLOCKING=1
SET TORCH_USE_CUDA_DSA=1
After that, try running the script again.

Thanks a lot for your quick feedback!
Here is the output I get after following your instructions:
$ python clean-ui.py
2024-10-01 22:08:54.936544: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
Select a model to load:
1. Llama-3.2-11B-Vision-Instruct-bnb-4bit
2. Molmo-7B-D-bnb-4bit
Enter the number of the model you want to use: 1
config.json: 100%|██████████████████████████████████████████████████████████████████| 5.64k/5.64k [00:00<00:00, 22.3MB/s]
Unused kwargs: ['_load_in_4bit', '_load_in_8bit', 'quant_method']. These kwargs are not used in <class 'transformers.utils.quantization_config.BitsAndBytesConfig'>.
model.safetensors.index.json: 100%|███████████████████████████████████████████████████| 385k/385k [00:00<00:00, 16.5MB/s]
model-00001-of-00002.safetensors: 100%|█████████████████████████████████████████████| 5.00G/5.00G [01:07<00:00, 74.6MB/s]
model-00002-of-00002.safetensors: 100%|█████████████████████████████████████████████| 2.18G/2.18G [00:30<00:00, 71.5MB/s]
Downloading shards: 100%|██████████████████████████████████████████████████████████████████| 2/2 [01:38<00:00, 49.02s/it]
The model weights are not tied. Please use the `tie_weights` method before using the `infer_auto_device` function.
Loading checkpoint shards: 100%|███████████████████████████████████████████████████████████| 2/2 [00:01<00:00,  1.24it/s]
generation_config.json: 100%|███████████████████████████████████████████████████████████| 210/210 [00:00<00:00, 1.39MB/s]
preprocessor_config.json: 100%|█████████████████████████████████████████████████████████| 477/477 [00:00<00:00, 4.12MB/s]
tokenizer_config.json: 100%|████████████████████████████████████████████████████████| 55.9k/55.9k [00:00<00:00, 10.4MB/s]
tokenizer.json: 100%|███████████████████████████████████████████████████████████████| 17.2M/17.2M [00:00<00:00, 82.5MB/s]
special_tokens_map.json: 100%|██████████████████████████████████████████████████████████| 454/454 [00:00<00:00, 4.33MB/s]
chat_template.json: 100%|███████████████████████████████████████████████████████████████| 558/558 [00:00<00:00, 11.9MB/s]
Running on local URL:  http://<IP_ADDRESS>:7860

To create a public link, set `share=True` in `launch()`.
Traceback (most recent call last):
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/queueing.py", line 536, in process_events
    response = await route_utils.call_process_api(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/route_utils.py", line 322, in call_process_api
    output = await app.get_blocks().process_api(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/blocks.py", line 1935, in process_api
    result = await self.call_function(
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/blocks.py", line 1520, in call_function
    prediction = await anyio.to_thread.run_sync(  # type: ignore
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/anyio/to_thread.py", line 56, in run_sync
    return await get_async_backend().run_sync_in_worker_thread(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 2405, in run_sync_in_worker_thread
    return await future
           ^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 914, in run
    result = context.run(func, *args)
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/utils.py", line 826, in wrapper
    response = f(*args, **kwargs)
               ^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/clean-ui.py", line 56, in describe_image
    output = model.generate(
             ^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/transformers/generation/utils.py", line 2048, in generate
    result = self._sample(
             ^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/transformers/generation/utils.py", line 3008, in _sample
    outputs = self(**model_inputs, return_dict=True)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/accelerate/hooks.py", line 170, in new_forward
    output = module._old_forward(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/transformers/models/mllama/modeling_mllama.py", line 2188, in forward
    outputs = self.language_model(
              ^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/transformers/models/mllama/modeling_mllama.py", line 1929, in forward
    outputs = self.model(
              ^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/transformers/models/mllama/modeling_mllama.py", line 1729, in forward
    layer_outputs = decoder_layer(
                    ^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/accelerate/hooks.py", line 170, in new_forward
    output = module._old_forward(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/transformers/models/mllama/modeling_mllama.py", line 1006, in forward
    hidden_states, attn_weights, past_key_value = self.cross_attn(
                                                  ^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/accelerate/hooks.py", line 170, in new_forward
    output = module._old_forward(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/transformers/models/mllama/modeling_mllama.py", line 630, in forward
    raise ValueError(
ValueError: Cross attention layer can't find neither `cross_attn_states` nor cached values for key/values!

Are you encountering the same error with the Molmo model as shown in the screenshot?
It seems that the required parameters were not set through the environment variables. To resolve this, you need to adjust the script as follows:
First, add the following code:
import os
os.environ['CUDA_LAUNCH_BLOCKING'] = "1"
import torch

Make sure that the os.environ['CUDA_LAUNCH_BLOCKING'] line comes before the torch import.
After all imports, include this line:
os.environ['TORCH_USE_CUDA_DSA'] = "1"

Are you encountering the same error with the Molmo model as shown in the screenshot?
Yes

Thanks again for your quick reply and suggestions.
I added the os.environ assignments as you suggested to the python file.
The values can be confirmed in the printout during the execution of the script.
However, the results for molmo-7b are again not successful "RuntimeError: probability tensor contains either inf, nan or element < 0". See further below for details.
Not sure if its helpful to resolve this, but our server has CUDA version 12.2 but I am using pytorch 12.1 - though my understanding is this should not be an issue.

GPU
Name
Persistence-M
Bus-Id
Disp.A
Volatile Uncorr. ECC
Fan
Temp
Perf
Pwr:Usage/Cap
Memory-Usage
GPU-Util
Compute M.
MIG M.

0
NVIDIA RTX A5000
On
00000000:01:00.0
Off
Off
30%
39C
P8
23W / 230W
12MiB / 24564MiB
0%
Default
N/A

1
NVIDIA RTX A5000
On
00000000:61:00.0
Off
Off
30%
35C
P8
16W / 230W
84MiB / 24564MiB
0%
Default
N/A

Regarding this being due to insufficient GPU VRAM, I suppose this seems unlikely on paper because I am able to do inference without trouble using the following models on the same system via ollama.  According to https://huggingface.co/spaces/hf-accelerate/model-memory-usage, the molmo-7b 4-bit should only need maximum 7-10 GB VRAM....

llama3.1:70b (30 GB VRAM)

Model
  	arch            	llama
  	parameters      	70.6B
  	quantization    	Q4_0
  	context length  	131072
  	embedding length	8192

qwen2.5:72b-instruct (47 GB VRAM)

 Model
 	arch            	qwen2
 	parameters      	72.7B
 	quantization    	Q4_K_M
 	context length  	32768
 	embedding length	8192

$ python clean-ui.py
2024-10-01 23:58:16.277979: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
Select a model to load:
1. Llama-3.2-11B-Vision-Instruct-bnb-4bit
2. Molmo-7B-D-bnb-4bit
PYTORCH_USE_CUDA_DSA: 1
CUDA_LAUNC_BLOCKING: 1
Enter the number of the model you want to use: 1
Unused kwargs: ['_load_in_4bit', '_load_in_8bit', 'quant_method']. These kwargs are not used in <class 'transformers.utils.quantization_config.BitsAndBytesConfig'>.
The model weights are not tied. Please use the `tie_weights` method before using the `infer_auto_device` function.
Loading checkpoint shards: 100%|███████████████████████████████████████████████████████████| 2/2 [00:01<00:00,  1.24it/s]
Running on local URL:  http://<IP_ADDRESS>:7860

To create a public link, set `share=True` in `launch()`.
Traceback (most recent call last):
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/queueing.py", line 536, in process_events
    response = await route_utils.call_process_api(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/route_utils.py", line 322, in call_process_api
    output = await app.get_blocks().process_api(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/blocks.py", line 1935, in process_api
    result = await self.call_function(
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/blocks.py", line 1520, in call_function
    prediction = await anyio.to_thread.run_sync(  # type: ignore
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/anyio/to_thread.py", line 56, in run_sync
    return await get_async_backend().run_sync_in_worker_thread(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 2405, in run_sync_in_worker_thread
    return await future
           ^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 914, in run
    result = context.run(func, *args)
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/utils.py", line 826, in wrapper
    response = f(*args, **kwargs)
               ^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/clean-ui.py", line 62, in describe_image
    output = model.generate(
             ^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/transformers/generation/utils.py", line 2048, in generate
    result = self._sample(
             ^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/transformers/generation/utils.py", line 3044, in _sample
    next_tokens = torch.multinomial(probs, num_samples=1).squeeze(1)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: probability tensor contains either `inf`, `nan` or element < 0

If there were no dependency conflict messages during package installation from the requirements.txt, everything should function properly. The key is ensuring that Torch is installed and compiled with CUDA (cuDNN).
Simply installing CUDA separately along with Torch won’t work correctly.
You can check by running the command pip list to see if Torch is installed with or without cuDNN.
Just don't forget to activate the environment .\venv-ui\Scripts\activate

Thanks again for the quick feedback.
Actually, I am not sure that the problem is simply not having Torch properly compiled with CUDA or unavailable cuDNN.
I now checked carefully how CUDA and cuDNN are installed on Ubuntu 22.04 as well the output of torch in the python 3.11 runtime.
Here is how I checked:
import torch

print('CUDA available', torch.cuda.is_available())
print('CUDA version', torch.version.cuda)
print('cuDNN enabled', torch.backends.cudnn.enabled)
print('cuDNN version', torch.backends.cudnn.version())
print('Torch version', torch.__version__)

n_cuda_devices = torch.cuda.device_count()
print('CUDA devices', n_cuda_devices)

for i in range(n_cuda_devices):
  print(f'Device {i} name:', torch.cuda.get_device_name(i))

print('Generate a tensor filled with random numbers using CUDA')
if torch.cuda.is_available():
    x = torch.randn(3, 3)
    x = x.to('cuda')
    print(x)

# Results on 02.10.2024 11:42
# CUDA available True
# CUDA version 12.1
# cuDNN enabled True
# cuDNN version 90100
# Torch version 2.4.1+cu121
# CUDA devices 2
# Device 0 name: NVIDIA RTX A5000
# Device 1 name: NVIDIA RTX A5000
# Generate a tensor filled with random numbers using CUDA
# tensor([[-0.4473, -0.1843,  0.7862],
#         [ 0.8512, -0.5436,  0.8666],
#         [-1.5343, -0.1995,  0.7313]], device='cuda:0')

Some references:
https://medium.com/@yulin_li/commands-for-the-cross-validation-of-pytorch-and-cuda-installation-235c8003b446
https://medium.com/repro-repo/build-pytorch-from-source-with-cuda-12-2-1-with-ubuntu-22-04-b5b384b47ac

I tried your suggestion to run unsloth/Llama-3.2-11B-Vision-Instruct.
Unfortunately, this also throws an error and I see active switching between the RTX A5000 GPUs :(
Again, could you tell me what GPU and VRAM are you using to run such a model?
To create a public link, set `share=True` in `launch()`.
Traceback (most recent call last):
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/queueing.py", line 536, in process_events
    response = await route_utils.call_process_api(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/route_utils.py", line 322, in call_process_api
    output = await app.get_blocks().process_api(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/blocks.py", line 1935, in process_api
    result = await self.call_function(
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/blocks.py", line 1520, in call_function
    prediction = await anyio.to_thread.run_sync(  # type: ignore
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/anyio/to_thread.py", line 56, in run_sync
    return await get_async_backend().run_sync_in_worker_thread(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 2405, in run_sync_in_worker_thread
    return await future
           ^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 914, in run
    result = context.run(func, *args)
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/gradio/utils.py", line 826, in wrapper
    response = f(*args, **kwargs)
               ^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/clean-ui.py", line 63, in describe_image
    output = model.generate(
             ^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/transformers/generation/utils.py", line 2048, in generate
    result = self._sample(
             ^^^^^^^^^^^^^
  File "/home/maximiliano/Documents/development/model_tools/clean-ui/venv-ui/lib/python3.11/site-packages/transformers/generation/utils.py", line 3044, in _sample
    next_tokens = torch.multinomial(probs, num_samples=1).squeeze(1)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: probability tensor contains either `inf`, `nan` or element < 0

I'm using a GeForce RTX 3060 12GB to run Llama-3.2-11B-Vision-bnb-4bit and Molmo-7B-D-bnb-4bit

Thanks for the info. I suppose this rules out insufficient GPU VRAM resources on my side.
Maybe I will need to try to disable one of the GPUs to avoid memory distribution between two RTX A5000s...


Add support for transposing slash chords

Currently when I try to transpose a slash chord i.e. D/F# it wont transpose the F# bass note

Hi, thanks for reporting!
I do fear that might not be properly handled :confused:
I'll try to take a look at it once I Find a free while.

Ok, I believe this should be fixed now.
Could you @joshfermin please verify? :pray:

@FUSAKLA that works great! thank you

Great! Thanks for confirmation :)


Copy and Pasting text in different font unit than default unit issues

Jodit Version:  3.4.xxxxx
Browser:  Chrome/Safari/Firefox/Edge
OS:  Windows/Mac
Is React App:  True
Code
Copy and pasting text in font unit pt
Text Here
shows error in font size display.

// A *self-contained* demonstration of the problem follows...

Expected behavior:
Should be converting that unit to the default unit.
Actual behavior:
It is just adding the unit at the end of the string.

Hi there, is there any updates on this issue? 😄 ty


Doesn't support products image?

I tried with products but no output text? Tried with https://images-na.ssl-images-amazon.com/images/I/912GfsQPJ6L.SL1500.jpg
Doesn't support products image?

In tesseract text are expected to be in darker shade like black. But your text are in white may be that's why it didn't work.


Safari Support?

Is it not supported by Safar?

What issues are you having.  I am using it on Safari now.

Closing this issue due to inactivity. See #815 for more information.
Please create a new issue is this still occurs with the current version of the component.


[analyze] [CTU] Add support for pch paramteres of clang-extdef-mapping

This patch is about supporting https://reviews.llvm.org/D128704 from Clang.
When doing CTU analysis setup we parse the .cpp to get an .ast and then
we run clang-extdef-mapping on the .cpp file later. This is
sub-optimal since we have to re-parse the file again.
With this patch we can now run clang-extdef-mapping directly on
the .ast file. That saves some time.

The overall CSA runtime (with the default profile) improved roughly with 1-2 % in case of C++, and with 0-1% in case of C.

Technically it looks good to me, though, it's not clear why relative/absolute paths matter. Maybe it would be worth for a comment about its reasons.

Thanks for the review!  Relative/absolute paths matter because the "on-demand" and the "pch" based CTU uses the paths differently. This is documented in ctu_manager.py at the function func_map_list_src_to_ast:
    """ Turns textual function map list with source files into a
    mapping from mangled names to mapped paths, which can be absolute paths to
    the original source files if ctu_on_demand is True, or relative path
    segments to AST-dump files that reside in CTU-DIR directory otherwise. """

Ping

Ping @Szelethus

This patch is about supporting https://reviews.llvm.org/D128704 from Clang.
When doing CTU analysis setup we parse the .cpp to get an .ast and then we run clang-extdef-mapping on the .cpp file later. This is sub-optimal since we have to re-parse the file again.
With this patch we can now run clang-extdef-mapping directly on the .ast file. That saves some time.

This patch is about supporting https://reviews.llvm.org/D128704 from Clang.
When doing CTU analysis setup we parse the .cpp to get an .ast and then
we run clang-extdef-mapping on the .cpp file later. This is
sub-optimal since we have to re-parse the file again.
With this patch we can now run clang-extdef-mapping directly on
the .ast file. That saves some time.

This absolutely cannot go in without a proper PR description and commit message. Please make the review, and the subsequent archeology easier.
Does this have a corresponding LLVM commit and/or phabricator revision? Is there an issue or something for this? Why do we need this? Whats to gain?

This patch is about supporting https://reviews.llvm.org/D128704 from Clang.
When doing CTU analysis setup we parse the .cpp to get an .ast and then
we run clang-extdef-mapping on the .cpp file later. This is
sub-optimal since we have to re-parse the file again.
With this patch we can now run clang-extdef-mapping directly on
the .ast file. That saves some time.


Merge all folders into _database folder

For simplicity sake, and since we are already differentiating initiatives with kind. We should merge the folders of

groups
incubators
labs
networks
projects
startups

:grin: now the initiatives are in their corresponding subfolder inside _database


UX - transport to branch

discussion from #2572
Transport to branch:
I can transport a task, but I can only enter a request ID, not a task ID. Then I have to find the task manually.

Could the initial branch commit message be taken from the request/task longtext?

@sbcgua
Transport to branch
Cool. +1
But 2 comments:
What if there are more than one transports ?
What if certain repo/system does not use transport management e.g. for some developments I just put everything in one transport and never release

What if there are more than one transports ?
Not sure I understand, but these seem to be unique:

They have the system ID at the start and are generated in increasing order, request and tasks combined.
What if certain repo/system does not use transport management e.g. for some developments I just put everything in one transport and never release
I guess you have no use for transport to branch then, or?

transports: well, I'm not using this feature to be honest. At least yet. So would vote that it is not the obligatory way, there should be an option to turn it on/off for a certain repo imho.

My additional notes: Transport to branch does not seem to be used much, but I had a very good use case last week where I had to find a method deleted in an older release as well as look for usages.
I don't know of a good way of doing this with SAP transports as you can only easily compare one object at a time.
I can however make branches from these transports and compare across branches. I even did this across two packages by making the same transport branches in both. Then use vscode to add multiple folders into your workspace and search.

Closing in fav of related issues:

https://github.com/abapGit/abapGit/pull/5916
https://github.com/abapGit/abapGit/issues/5672
https://github.com/abapGit/abapGit/issues/5673


Adds support for json offer and answer then also in json

OctoPrint's webrtc implementation sends offer sdp and expects answer in json format. I added support for recognizing such requests by Content-Type and handling them.

Thanks!

Please let me know when there will be a release with go2rtc support


Allow library to be used with importmaps for browsers without bundlers

Hello.
etebase-js at this point exposes an ES module entrypoint, but that isn't enough for use with import maps. If I understood correctly, the import maps get hung up on the crypto import of lib-sodium. I'm not sure how to fix this, but I believe it has something to do with export maps which explicitly state entyrpoints for submodules.
Thanks
https://github.com/WICG/import-maps
https://docs.skypack.dev/package-authors/package-checks#export-map

libsodium is wasm, maybe that's the problem?

I believe wasm works with export maps, but the more I'm playing with it, it seems to be an upstream problem with the libsodium.js dependency.

I think we are very straightforward in what we do here. I mean, a lot of JS code, but it's just JS + wasm from sodium.


Update ror2 to 0.4.0

adds explore mode as options and changes some other settings to make more simple and add more variety

A few things that I think I'd change would be:

Change explore chance to be a little bit higher. 75 to 25 or 100 to 25.
Have Chest per stage be random-range-high to prevent getting a really bad roll and getting the minimum amount a chests per stage. Maybe something along the lines of 5-15.
I would rather have final stage death always be false but this is for beginners so idk. Id at least make the weights even.
Maybe change item_pickup_step: random-range-0-3 to item_pickup_step: random-range-low-0-3

My knowledge is minimal, but from what I can tell these changes seem fine. Will let this simmer to see if there are any other comments/suggestions


feat: route Google requests through nginx tunnel

Let's make this work in staging by adding the var in the deployment config 👍


Add .pmtignore

Have we thought about adding this file? Seems useful.
http://rnelson0.com/2015/11/15/exclude-files-from-a-puppet-module-release/

iirc, we just added the necessary ignores to .gitignore

PMT doesn't use the same format, I've filed a bug for it. I believe it's
okay if the git ignore statement does not have a leading slash.
On Tuesday, December 22, 2015, Igor Galić<EMAIL_ADDRESS>wrote:

iirc, we just added the necessary ignores to .gitignore
—
Reply to this email directly or view it on GitHub
https://github.com/puppet-community/modulesync_config/issues/49#issuecomment-166619779
.

--
Rob Nelson
<EMAIL_ADDRESS>

which we do not.