Updates per comments.

Coverage remained the same at 55.179% when pulling 0c0db587ecf87ac6d711b4a985fc50650bc9632a on wknet123:master-ui-aot into 785432c520ec9b1e76e1e6d39c74930aed35606f on vmware:master-ui-aot.


[RFC][python] deprecate advanced args of train() and cv()  functions and sklearn wrapper

Proposing this PR to include in #4310

I also think this release could be a good opportunity for maintainers to think carefully about what breaking changes might be made (in addition to #3234) in a 4.0.0 release, and to add deprecation warnings for them in the 3.3.0 release.

Encourage users to use callbacks. With removed in 4.0.0 release advanced arguments codebase will become a little bit clearer, confusing cases when both callback and corresponding advanced argument are used will be eliminated, there will be no need to expose new callbacks or new arguments of existing callbacks (#2526) via new arguments of high-level functions/classes making signature of functions incredibly difficult to understand especially for newcomers.

I'm supportive of this idea, but could preserve the current behavior where .best_iteration_ and .best_score_ are None if early stopping is not used?
Having those now be 0 is a breaking change and I think we should only make that breaking change in 4.0.0. There could be user code out there that is using _best_iteration_ is None as a way to detect whether not early stopping was used.

@jameslamb

could we preserve the current behavior

Sure, will revert some lines of code.

@jameslamb

could we preserve the current behavior

Addressed in 07046ecafff4f949d96883a2088487c269e27ac5.

or :obj:None

in best_score_'s docstring was just a mistake. It's always a dict, possibly an empty one.
Also, fixed a bug when best_iteration_ was not set if early stopping was specified via keyword arguments or a callback, which is now a recommended way of specifying early stop.
In addition, fixed a bug when best_iteration_ and evals_result_ were preserved (not updated) after a previous call to fit() method. This happens when the first call was with early_stopping_rounds=xx and the seconnd one without early_stopping_rounds=None.
I can extract bug fixes into separate PRs to make this one easier to review if needed.


Remove SSM agent DaemonSet from cluster

Description of changes:
Upgraded the node AMIs to the latest version, which has SSM agent running by default. Removed the hacky SSM agent installer DaemonSet from the test cluster configuration.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RedbackThomson in which of the commits did you update the node AMIs to the latest version?

@RedbackThomson in which of the commits did you update the node AMIs to the latest version?

Did it through the console so I didn't have to redeploy the autoscaling group. Last time I did that, it messed up the AZs and I couldn't reattach the PV. The CDK doesn't specify the AMI for the nodegroups, so if we do need to deploy from CDK again it will be the most recent, anyway.

/lgtm


[Support] cannot use pivpn add

Hey hi everyone
When I finish download pivpn on raspberry pi4 today and try to start using it. I find out that it cannot run normally (or that's my fault).
When I try to use the command 'pivpn add' it just return this
pi@raspberrypi:~ $ pivpn add
::: To pass off to the pivpn command for each protocol
:::
::: Usage: pivpn wg   [option]
::: Usage: pivpn ovpn  [option]
:::
:::  -h,  help             Show this help dialog
:::  -u,  uninstall        Uninstall pivpn from your system!
:::  -bk, backup           Backup VPN configs and user profiles
i cannot really understand what happen and my english is not good at all. i think it is not a normal output. i search i on google but still cannot find one who met this problem
here are some setting and hope those data can help to  solve the problem
model: raspberry raspberry pi 4 model b
operating system:  raspberry pi os (called raspbian before)
using utp in pivpn
change the port before
ufw (firewall) is on
I have tried to re-downloading it for several times
that all
thx

Hi, pivpn add returns that output because you installed both wireguard and openvpn. To control wireguard use pivpn wg something, for example pivpn wg add. To control openvpn use pivpn ovpn something.

ohhhhhhhhhhhhhhhhhh
thank you so much

No problem, close the issue if you solved.


chore: bdd-sbhg-1585521708 to 0.0.1

chore: Promote bdd-sbhg-1585521708 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


NullReference when Stylus Widget installed

I've recently noticed a huge number of crashes in an application, reported by different users which have some kind of stylus or touch input, just after they installed the windows update KB4058258.
Reading the .NET 4.7.2 early access release notes, I noticed a lot of improvements on behavior of stylus and touch devices that would seem to solve the problem, but even after installing it, the problem remains.
bug seems related to:
https://github.com/Microsoft/dotnet/blob/master/releases/net471/KnownIssues/481090-WPF Touch generates NullReferenceException in ProcessInputReport.md
.NET 4.7.2 release notes:
https://github.com/Microsoft/dotnet-framework-early-access/blob/master/release-notes/build-3052/dotnet-build-3052-changes.md
more info:
https://developercommunity.visualstudio.com/content/problem/205823/exception-after-kb4058258-with-wacom-tablets-1.html
My question is if this bug will really be addressed in the final version of 4.7.2 or if there is any way of working it around.
Thanks in advance.

This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this still an issue, please reach out to us on Dev Community. For all other issues, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275

This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this still an issue, please reach out to us on Dev Community. For all other issues, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275


search small errors

-doesnt work on id
-doesnt show all records(2 in this case) when seach 'dead'
-doesnt show result unless user selects one of the seach options
-' Error displaying data: ORA-02391: exceeded simultaneous SESSIONS_PER_USER limit ' got this error

Not supposed to work on id
Not sure why this is, will look into it
Also intended
Happens on all the pages if you spam too much, couldn't figure out why yet.


Repeatedly prompted for my PBI AAD password; after 3rd time, PBI exits!

[Enter feedback here]
In latest version (published yesterday, 2024-03-04), I'm repeatedly prompted for my password; after 3rd time, PBI exits!  In several of the prior versions of PBI DT, it also repeatedly prompted for credentials, but eventually they "worked" and I could get going with working in PBI.  But this version completely exits.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e2102c86-5037-0609-9dd3-a1487732df3f
Version Independent ID: 73cfef71-a511-5ba2-b7b1-fa02a58a9e15
Content: Get Power BI Desktop - Power BI
Content Source: powerbi-docs/fundamentals/desktop-get-the-desktop.md
Service: powerbi
Sub-service: pbi-fundamentals
GitHub Login: @davidiseminger
Microsoft Alias: davidi

FYI - I put in a Support ticket with MS.  They said others have reported the same issue, and they're hopeful that the next interim release, likely due later in March, will address the problem.


manage local params that are not synchronized on the repository

For exemple defaut loaded map at lauch, or window's resolution.
It would allow any contributor to have it's own params.

sounds possilbe, see here: http://wiki.jmonkeyengine.org/doku.php/jme3:intermediate:appsettings

fixed now.


Buggy out transition in routes on switching

When switching the routes then it normally switches to the desired route with an element which has an transition (in & out).
When I switch the route again, from the route which contains an element with the transition, then the element inside the route with the transition starts the out transition and because of that the route renders back in so both routes are shown for a while and then both disappear.
Maybe it might be that the route with the element is an instance that doesn't get destroyed because of the ongoing out transition.
Reproduction:
Add at least two routes in the config and inside one of them create an element that has a transition (in & out - out has the actually "bug"). Now routing from the route without any transition to the route with an element that has the transition. This works just fine but now when routing back from the route that has the element with the transition... here you go.
Live example that works exactly the same as the router:
https://svelte.dev/repl/a5122281148c4c458f40e317fc4be11e?version=3.12.1

As of the release v3.0.0 this bug has been resolved by a workaround. 🎉
See the section "Route Transition" of the documentation (Documentation of v3.0.0)


Auto-update functionality

Is your feature request related to a problem? Please describe.
It's required to take extra actions to update application to the latest available version (check GitHub Releases page, download new binary and replace old one).
Describe the solution you'd like
Automated way to detect and notify about available update, new binaries download and replacement of old files, launch updated app.
Describe alternatives you've considered

Omaha ( https://github.com/google/omaha )
Custom implementation to check new GitHub Releases availability

Closed due to complete rewrite as part of bringing the project back to life, please create a new issue if still relevant. Thank you!


Make the curl response and status code available from the thrown Exception in SwordAppClient->deposit()

Exception: Error parsing error document (String could not be parsed as XML) in SWORDAPPClient->deposit() (line 135 of /Applications/MAMP/bco-dmo.org/www.bco-dmo.org/drupal/docroot/sites/all/libraries/swordapp-php-library/swordappclient.php).

I'll fork and submit a pull request


Solver architecture and generalized-alpha solver implementation

Addresses #22.
This PR needs a lot of development work before it will be ready for review, however, wanted to open a draft PR just to facilitate conversation around the solver design and get some early feedback.
Things to look for:

Using Eigen3 as an external dependency to get a linear algebra library. This is what I am considering for the proof-of-concept study and will likely be replaced later on.
Initial design of solver architecture.

TODO:

Add unit tests
Add private methods in GeneralizedAlpha class to create the ResidualVector and the IterationMatrix.

In terms of your solver code, perhaps it is too early to be thinking about base-classes and inheritance design. Just start with the minimum needed to pass your first unit-test.
If you have thoughts about abstract solver classes and high-level design, express those in tests, and then that will drive you to create the needed code. The key to test-driven-development is picking/designing the right tests.


timetrap: add shell completions

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 252783 run on x86_64-linux 1

2 packages marked as broken and skipped:

linuxKernel.packages.hardkernel_4_14.prl-tools
linuxPackages_hardkernel_latest.prl-tools

3 packages failed to build:

linuxPackages_latest.prl-tools (linuxKernel.packages.linux_6_5.prl-tools)
linuxPackages_latest-libre.prl-tools (linuxKernel.packages.linux_latest_libre.prl-tools)
linuxPackages_testing_bcachefs.prl-tools (linuxKernel.packages.linux_testing_bcachefs.prl-tools)

20 packages built:

linuxKernel.packages.linux_4_14.prl-tools
linuxPackages_4_14_hardened.prl-tools (linuxKernel.packages.linux_4_14_hardened.prl-tools)
linuxKernel.packages.linux_4_19.prl-tools
linuxPackages_4_19_hardened.prl-tools (linuxKernel.packages.linux_4_19_hardened.prl-tools)
linuxKernel.packages.linux_5_10.prl-tools
linuxPackages_5_10_hardened.prl-tools (linuxKernel.packages.linux_5_10_hardened.prl-tools)
linuxKernel.packages.linux_5_15.prl-tools
linuxPackages_5_15_hardened.prl-tools (linuxKernel.packages.linux_5_15_hardened.prl-tools)
linuxKernel.packages.linux_5_4.prl-tools
linuxPackages_5_4_hardened.prl-tools (linuxKernel.packages.linux_5_4_hardened.prl-tools)
linuxPackages.prl-tools (linuxKernel.packages.linux_6_1.prl-tools)
linuxPackages_hardened.prl-tools (linuxPackages_6_1_hardened.prl-tools)
linuxKernel.packages.linux_6_4.prl-tools
linuxPackages_6_4_hardened.prl-tools (linuxKernel.packages.linux_6_4_hardened.prl-tools)
linuxPackages-libre.prl-tools (linuxKernel.packages.linux_libre.prl-tools)
linuxPackages_lqx.prl-tools (linuxKernel.packages.linux_lqx.prl-tools)
linuxPackages_xanmod.prl-tools (linuxKernel.packages.linux_xanmod.prl-tools)
linuxPackages_xanmod_latest.prl-tools (linuxKernel.packages.linux_xanmod_latest.prl-tools ,linuxPackages_xanmod_stable.prl-tools)
linuxPackages_zen.prl-tools (linuxKernel.packages.linux_zen.prl-tools)
timetrap

Any idea why nixpkgs-review pr thinks it has to build all that linux* stuff?

Timetrap is a dependency of prl-tools which is inside the linux directory. Not sure why are there so many rebuilds though

CCing maintainers of prl-tools: @catap @wegank.
This dependency was added in f41fc22 (#179582), but it seems pretty implausible to me.  I did:
nix-build -A pkgs.linuxKernel.packageAliases.linux_default.prl-tools
and then neither grep -r timetrap result/ nor grep -rE 't($|[^a-z])' result/ turns up anything that looks like an actual attempt to execute the timetrap or t commands provided by the timetrap package.

@jerith666 the issue that prl-tools is provided as binary files which has hardcoded shell scripts. I did my best to reverse enginere it and to find some setup which works...
So, if you may avoid to touch it, I'll be very appricieted :) it was quite a challenge last time, and you may see that before I did it nix has lack of updated for years.

@jerith666 the issue that prl-tools is provided as binary files which has hardcoded shell scripts. I did my best to reverse enginere it and to find some setup which works...
So, if you may avoid to touch it, I'll be very appricieted :) it was quite a challenge last time, and you may see that before I did it nix has lack of updated for years.

I can certainly appreciate that.  And I'm unable to test locally as I don't have a Parallels license or any Mac hardware.
I'm just not sure what Parallels Tools for Linux guests could possibly want with this obscure ruby time tracker!  :)
Ideally we would sever this dependency:
diff --git a/pkgs/os-specific/linux/prl-tools/default.nix b/pkgs/os-specific/linux/prl-tools/default.nix
index 7e5fca7a354b..b1dd9025a9c2 100644
--- a/pkgs/os-specific/linux/prl-tools/default.nix
+++ b/pkgs/os-specific/linux/prl-tools/default.nix
@@ -16,7 +16,6 @@
 , cups
 , gawk
 , netcat
-, timetrap
 , util-linux
 }:

@@ -30,7 +29,6 @@ let
     "${cups}/sbin"
     "${gawk}/bin"
     "${netcat}/bin"
-    "${timetrap}/bin"
     "${util-linux}/bin"
   ];
 in

At any rate, I can report that linuxPackages_latest.prl-tools and linuxPackages_latest-libre.prl-tools build cleanly for me at the tip of this PR's branch, while linuxPackages_testing_bcachefs.prl-tools fails in the same way at the tip of this PR's branch and its parent.  So I don't think anything that's happening here is making the situation any better or worse.


[Fix] body all passthrough

What this PR does:
Fix body _all match.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #59 (32bb9a0) into develop (1775274) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop      #59      +/-   ##
===========================================
- Coverage    43.71%   43.64%   -0.08%
===========================================
  Files           28       28
  Lines         1217     1219       +2
===========================================
  Hits           532      532
- Misses         613      614       +1
- Partials        72       73       +1

Impacted Files
Coverage Δ

pkg/client/mapper.go
78.94% <0.00%> (-9.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1775274...32bb9a0. Read the comment docs.


Large graphics memory leak per new Activity

Regular apps are not affected since the VR apps get killed after undocking. In special circumstances where in the same process many VR activities get created and destroyed, a large graphics memory leak (EGL mtrack) has been observed with the Oculus backend. If a frame is ever submitted to vrapi_SubmitFrame then 12-13MBs of graphics memory are leaked per VR activity instance. May have some link to https://github.com/Samsung/GearVRf/issues/1094.

From the looks of it fixed by https://github.com/Samsung/GearVRf/pull/1186

Addressed by https://github.com/Samsung/GearVRf/pull/1186


[4.0] Add a size heuristic to the Space Engine

• Explanation: Type checking switch statements looking for exhaustive patterns is a potentially factorial process.  Introduce a reasonable size limit to fall back to a linear-time heuristic instead of the full check.
• Scope of Issue:  A large enough switch over a large enough enum case can cause the compiler to hang for hours computing a fixit.
• Origination: Noticed by Harlan Haskins while TableGen’ing a very very large enum and a similarly enormous switch statement .
• Risk: Low.
• Reviewed By: Xi Ge, Joe Groff
• Testing: New regression tests added, confirmed locally that the patch resolves Harlan’s original issue.
• Directions for QE: (Optional) Verify with the test case in the patch.
• Radar URL: rdar://32480026

@swift-ci please test

@swift-ci please test source compatibility

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 69dd65161aea859f6fb1cf9c6f5450dfd52d1ab1
Test requested by - @CodaFi

@swift-ci please test

@swift-ci please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 69dd65161aea859f6fb1cf9c6f5450dfd52d1ab1
Test requested by - @CodaFi

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 69dd65161aea859f6fb1cf9c6f5450dfd52d1ab1
Test requested by - @CodaFi

@swift-ci please test source compatibility

@swift-ci please test source compatibility


Make Configuration subclass for chromatography and split current ChromatographicSeparationProcess class

This PR addresses https://github.com/microbiomedata/nmdc-schema/issues/1920.
Similar to the challenges laid out in PR #130; LC- and GC-based omics workflows need more information regarding the chromatography aspect of the DataGeneration.
As currently modeled, each MassSpectrometry instance is connected to a FluidHandling instance through the eluent_introduction slot.  For GC- and LC-based omics (metabolomics, lipidomics, and proteomics), the eluent_introduction slot corresponds to a ChromatographicSeparationProcess instance, which does not adequately model the ChromatographicSeparation processes (column specifications, gradient information, flow rate) for metabolomics/lipidomics metadata-informed workflow execution.
Similar to the MassSpectrometryConfiguration class, we propose to have a  configuration class that houses the LC or GC configuration information which would 1) greatly reduce repeating data on ChromatographicSeparationProcess instances and 2) allow for workflows to be configured based on ChromatographicConfiguration instance and 3) allow users to query samples that were run with similar configurations for downstream comparisons.
An issue comes up because the current ChromatographicSeparationProcess class is currently set up to model both the LC/GC introduction aspect of a MassSpectrometry instance and solid phase extractions (see https://github.com/microbiomedata/berkeley-schema-fy24/blob/main/src/data/valid/ChromatographicSeparationProcess-SPE.yaml).  Solid phase extractions (SPEs) are sample preparative steps and should not be associated with a Configuration as they are not controlled by a programmable and shared method file.  Furthermore, the  ChromatographicSeparationProcess class sits under the FluidHandling class, which is defined as "the process that defines how a processed sample is introduced into the mass spectrometer", which is not applicable to the solid phase extractions currently modeled by ChromatographicSeparationProcess.
Thus, we propose to split the currently modeled ChromatographicSeparationProcess class into two classes: SolidPhaseExtraction (with parent Extraction class, but otherwise unchanged from current ChromatographicSeparationProcess) and ChromatographicIntroductionProcess (with parent FluidHandling class and associated ChromatographicIntroductionConfiguration class).  This results in a more accurate modeling for solid phase extractions (they are extractions, nothing to do with a mass spectrometer), enables unambiguous use of a Configuration class specifically for the ChromatographicIntroductionProcess, and yields sufficient information regarding the LC/GC introduction for workflows to parameterize accordingly.
Current class structure:

Proposed class structure:

Follow ups after discussion with @turbomam:

[ ] Remove subclass of SPE and move SPE-specific slots to capture information on existing Extraction class with new extraction_category slot and associated Enum?  Follow up with @aclum, @anastasiyaprymolenna, and @corilo to check if this is adequate modeling for SPE for NOM.
[ ] Remove FluidHandling and subclasses, modify existing slot eluent_introduction on MassSpectrometry to house an Enum to capture which type (direct infusion, LC, or GC), make two has_configuration slots (one for MS and one for Chromat configs).  Add rule that if GC,  needs a has_calibration.  Follow up with @corilo and @SamuelPurvine  to check if this if this is adequate modeling for the MS-based DataGeneration classes.


do not fail when changeset is empty

when there are no changes to submit we shouldn't fail.

@ideahitme can we merge this?

@linki thanks 👍


Video working with Chinese service Tudou

I've been having issues getting this to work with the Chinese version of YouTube: Tudou. Any chance of this being integrated?

We're not planning on the time to integrate this as none of us use the service and also can't read Chinese text! If you feel take the time to implement it for yourself, feel free to submit a pull request and we'll see if we can get it merged into the codebase.


Handle the case when local cookiecutter template isn't in the correct branch

When briefcase runs cookiecutter it tells it to check out the branch that corresponds to the Python major.minor version being used.
However, cookiecutter does not do that when given the directory path to the git repo, so briefcase should checkout the right branch when deciding to reuse the local template.
I think it makes sense to do git checkout BRANCH_NAME inside of the git_pull() method, just before doing the pull.

Btw, it seems that the problem of not ensuring it's in the right branch is what was causing errors like:
cookiecutter.exceptions.RepositoryNotFound: A valid repository for "/home/elias/.cookiecutters/Python-Android-template" could not be found in the following locations:
/home/elias/.cookiecutters/Python-Android-template

Which happens because the master branch of the templates isn't a valid template (doesn't have a cookiecutter.json file).

I think this makes a lot of sense and would be especially useful when testing briefcase builds against multiple python versions.
My only suggestion is ensuring that git checkout BRANCH_NAME is not done when --template is set at run time for using custom / testing templates. I don't think you were suggesting this at all, I'm just using this setting at the moment so thought of it.

Hm right, that makes sense. :+1:

I'm pretty sure updating self.git_pull or adding the checkout in the place you linked to (reuse the local template) would only operated on the default template anyway, any provided on command line wouldn't be touched


Keras SVHN dataset

Many recent paper works on SVHN data set. Can you please make an automatic script for SVHN dataset like MNIST dataset you did ?

I want to work with SVHN dataset. Is there any keras script for this dataset?
Thanks!


CLI v7.1.0 "env" command panics if a variable contains values in "{{ }}"

[X] I reviewed open and closed github issues that may be related to my problem.
[X] I tried updating to the latest version of the CF CLI to see if it fixed my problem.
[X] I attempted to run the command with CF_TRACE=1 to help debug the issue.
[X] I am reporting a bug that others will be able to reproduce.

Describe the bug and the command you saw an issue with
We've run cf7 env <appname> and the command paniced with:
		Something unexpected happened. This is a bug in cf.

		Please re-run the command that caused this exception with the environment
		variable CF_TRACE set to true.

		Also, please update to the latest cli and try the command again:
		https://code.cloudfoundry.org/cli/releases

		Please create an issue at: https://code.cloudfoundry.org/cli/issues

		Include the below information when creating the issue:

		Command
		cf env service-broker-blue

		CLI Version
		7.1.0+4c3168f9a.2020-09-09

		Error
		template: Display Text:1: function "app_router_url" not defined

		Stack Trace
			goroutine 1 [running]:
	code.cloudfoundry.org/cli/util/panichandler.HandlePanic()
		/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/util/panichandler/handler.go:19 +0x81
	panic(0xfeec80, 0xc0005b8840)
		/usr/local/go/src/runtime/panic.go:679 +0x1b2
	text/template.Must(...)
		/usr/local/go/src/text/template/helper.go:23
	code.cloudfoundry.org/cli/util/ui.generateTranslationFunc.func1(0xc000568000, 0x6143, 0xc0005b87d0, 0x1, 0x1, 0x4d7ab1, 0x1bf9e40)
		/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/util/ui/i18n.go:119 +0x40a
	code.cloudfoundry.org/cli/util/ui.(*UI).TranslateText(...)
		/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/util/ui/ui.go:308
	code.cloudfoundry.org/cli/util/ui.(*UI).DisplayText(0xc0000e5810, 0xc000568000, 0x6143, 0x0, 0x0, 0x0)
		/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/util/ui/ui.go:246 +0x124
	code.cloudfoundry.org/cli/command/v7.EnvCommand.displayEnvGroup(0x13b0300, 0xc0000e5810, 0x13b9a40, 0xc00001c300, 0x1393360, 0xc0003b2d40, 0x13bd660, 0xc00083f680, 0xc00003d8c0, 0xc00052aa80, ...)
		/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/command/v7/env_command.go:97 +0x175
	code.cloudfoundry.org/cli/command/v7.EnvCommand.Execute(0x13b0300, 0xc0000e5810, 0x13b9a40, 0xc00001c300, 0x1393360, 0xc0003b2d40, 0x13bd660, 0xc00083f680, 0xc00003d8c0, 0xc00052aa80, ...)
		/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/command/v7/env_command.go:68 +0x6bf
	code.cloudfoundry.org/cli/util/command_parser.(*CommandParser).executionWrapper(0xc00017b840, 0x7f93acaf8340, 0x1c23b18, 0xc00019d380, 0x0, 0x2, 0x0, 0x0)
		/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/util/command_parser/command_parser.go:93 +0x270
	code.cloudfoundry.org/cli/vendor/github.com/jessevdk/go-flags.(*Parser).ParseArgs(0xc000164af0, 0xc00003a040, 0x2, 0x2, 0x0, 0x0, 0x0, 0x0, 0x0)
		/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/vendor/github.com/jessevdk/go-flags/parser.go:331 +0x89c
	code.cloudfoundry.org/cli/util/command_parser.(*CommandParser).parse(0xc00017b840, 0xc00003a040, 0x2, 0x2, 0x100e680, 0x1c21340, 0xc000000120, 0xed, 0xc000527e70)
		/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/util/command_parser/command_parser.go:221 +0xe0
	code.cloudfoundry.org/cli/util/command_parser.(*CommandParser).ParseCommandFromArgs(...)
		/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/util/command_parser/command_parser.go:57
	main.main()
		/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/main.go:40 +0x19e

Calling cf6 env <appname> worked. The problematic environment variable seems to be this one:
SERVICEBROKER_CATALOG: {"services":
(... huge json ...)
 "endPointAddress": "{{app_router_url}}/SampleServices/ESPM.svc/v2"}

The app_router_url is interpreted as function call by the GoLang template package. As it is nowhere defined, this call panics: https://github.com/cloudfoundry/cli/blob/b823ae53f394acf64ad7fb09f550c508a3c46e0a/util/ui/i18n.go#L119
What happened
(see description)
Expected behavior
We expected the application's environment variables to be printed.
Exact Steps To Reproduce
With CF CLI v7.1.0,

Push a test app
cf set-env testapp ENV_VAR "{'{{key}}': 'value'}"
cf env testapp

Provide more context
Platform:
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.5 LTS
Release:	18.04
Codename:	bionic

CF CLI versions:
cf7 version 7.1.0+4c3168f9a.2020-09-09 (doesn't work)
cf6 version 6.53.0+8e2b70a4a.2020-10-01 (works)
capi-release: 1.98.0
Notes regarding V6 and V7 CLI support:

V6:

Minimum supported version of CF Deployment: v7.0.0 (CAPI Release: 1.74.0 (APIs 2.128.0 and 3.63.0))
Maximum supported version of CF Deployment: v13.4.0 (CAPI Release: 1.94.0 (APIs 2.149.0 and 3.84.0))

V7:

Minimum supported version of CF Deployment: v13.5.0 (CAPI Release: 1.95.0 (APIs 2.150.0 and 3.85.0))

Hello,
I can reproduce this issue in the CLI version: 7.2.0+be4a5ce2b.2020-12-10
Is there any workaround? Of course besides changing the brackets?
I wonder why values of environment variables are treated as templates at the cf env command at all?
Obviously, the cf push, cf set-env commands are NOT treating it as templates...

Same issue occurs with CLI v8.0.0 + with the following env variable:
...
  env:
    SOME-ENV: "{{\"my-json\":\"value\"}}"

Is this issue is going to be addressed? It happens also in our scenario see here: https://github.com/cloudfoundry/cli/issues/2381 in version 8.5.0.
Is there a roadmap when it will be fixed?

This issue has been fixed by the PR. So closing it.


test: Add TypeScript consumer test

Fixes #N/A
Description

Adds a TypeScript consumer test to make sure different versions of TypeScript compile properly against our types.
Specific Changes

Adds consumer test runner which manages the different typescript versions and runs the compilation
Adds consumer test file which touches all the publicly exported types (it doesn't catch unexported types - we need api-extractor or something equivalent to chase that problem)
Adds test:consumer to package.json

Testing

It is a test! Yay!!!

/azp run


fix: scroll in settings menu popup

closes https://github.com/leather-wallet/extension/issues/5298
This PR fixes the case where the popup is larger in height than the viewport making some options inaccessible. Setting the max-height of it to the radix-dropdown-menu-content-available-height CSS variable and setting overflow-y to scroll fixes the issue.

Summary by CodeRabbit

New Features

Enhanced dropdown menu in settings with maximum height and vertical scrolling for improved user experience.

Thanks @jeeanribeiro , I will test this. Can you please rebase onto the dev branch?
Then I'll be able to get it merged quickly once tested.
Thanks so much for the contributions, you're on a roll! 🎉

Thanks @jeeanribeiro , I will test this. Can you please rebase onto the dev branch?
Then I'll be able to get it merged quickly once tested.
Thanks so much for the contributions, you're on a roll! 🎉

Rebased it :)

Thanks @jeeanribeiro , your contribution is appreciated. I have merged your work in https://github.com/leather-wallet/extension/pull/5428


remove self-provided dependencies from the runtime dependency set

Although apk can handle self-dependencies just fine, it warns about them when using "apk dot".
Noticed while debugging a dependency issue in Wolfi.

Nah, if we make it an error, the automatic dependency scanning will become a lot more complex.  Best to just silently drop the duplicate entries, which matches what abuild does.


[Question] Dropdown multiple selection and searchable

Hello,
I'm currently playing with flutter and building a mobile app. I'm looking on how to create a dropdown with multiple select options that also allows to search the values.
(The result expected is like the Autocomplete Multiple Values of Material UI component)

I couldn't find something related and I was wondering if there is a way to achieve this or should I take a different approach?
Thank you in advance.

Hi @marimeli
you may want to look into the DropdownButton  and TextEditingController classes.
Please see https://flutter.dev/community for resources for asking questions like this,
you may also get some help if you post it on Stack Overflow.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you


Taproot P2TR address

Part of Taproot project https://github.com/orgs/rust-bitcoin/projects/3 and epic #503. Based on #562

One thing to keep in mind here: you need the new bech32 version for the Display implementation for version>0 segwit addresses. So this is blocked on rust-bitcoin/rust-bech32#48.

@apoelstra what do you  think on refactoring Address type given the opportunity by Taproot to do a API breaking change? Why not make it Copy and instead of WitnessProgramm provide explicit variants for WPubkeyHash, WScriptHash and Taproot with fixed-length arrays? witness_program() can be a method returning &[u8] then. Each new witness version will probably require address change anyway (like taproot), so we are not creating more problems for the future by doing that.

I've opened rust-bitcoin/rust-bech32#50 to add Bech32m support to the bech32 library.

Each new witness version will probably require address change anyway (like taproot)

Ideally that would not be the case. Bech32m was only necessary due to a bug in bech32. BIP173 also states

Version 0 witness addresses are always 42 or 62 characters, but implementations MUST allow the use of any version.

Which seems to indicate that we'd still need a "unknown" variant.

Here is my take on implementation for Bech32m checksums, based on BIP-0350 and bech32 0.8.0.

Thank you, @clarkmoody, your changes are merged

Which seems to indicate that we'd still need an "unknown" variant.

@sgeisler not necessary. We are talking about addresses, not descriptors; and not each script can be represented by an address (payload). I think it's absolutely fine not to support future unknown address formats and not provide a full witness program for them: ppl needing this will be able to use a special descriptor. In return, we will have a copy'able type like
#[derive(Copy, Clone, Ord, PartialOrd, Eq, PartialEq, Debug)]
pub enum AddressPayload {
    PubkeyHash(PubkeyHash),
    ScriptHash(ScriptHash),
    WPubkeyHash(WPubkeyHash),
    WScriptHash(WScriptHash),
    Taproot(bip340::PublicKey),
}

and unability to parse the address will be denoted by Option::None, as it is happens today for custom script pubkeys.

Imo "[…] but implementations MUST allow the use of any version." is intended to provide forwards compatibility. We don't need to understand a witness script to send money to it and future users shouldn't have to upgrade to send money to version >=2 witness addresses. That upgrading is necessary for sending funds to Taproot addresses is a very unfortunate mishap and not the norm.

However you are sending funds to a scriptPubkey, not the address. So Bech32m have not broken the funds which were stent to witness v1 outputs, and not supporting parsing of an address does not implies preventing users from sending funds wherever they want to. Anyway, it's not that important so I'm fine if it is not needed in the library.

We absolutely should support versions >1. The whole point of bech32(m) is that you can support future versions.
Users send money to addresses, not scriptPubKeys.

The main bitcoin repo has an enum variant for unknown witness version that it uses when classifying outputs.
enum class TxoutType {
    NONSTANDARD,
    // 'standard' transaction types:
    PUBKEY,
    PUBKEYHASH,
    SCRIPTHASH,
    MULTISIG,
    NULL_DATA, //!< unspendable OP_RETURN script that carries data
    WITNESS_V0_SCRIPTHASH,
    WITNESS_V0_KEYHASH,
    WITNESS_V1_TAPROOT,
    WITNESS_UNKNOWN, //!< Only for Witness versions not already defined above
};

it seems that this version does support segwit versions > 1, right?

in which sense? We have enum values for all allowed versions >1

in which sense?

That we can a) parse and format and b) send transactions to addresses of unknown witness version.

We have enum values for all allowed versions >1

Yes, this makes it possible.

@dr-orlovsky if your concern is waiting for 2 reviewer ACKs again, we can also create a follow-up PR with the changes.

Thanks @sanket1729, I will add commits to this PR. Just need more time to finish other stuff before switching to this one

@sanket1729 addressed all of your suggestions in the new commit, aside from the first one (for which I gave rationale why I think the current code is better).
@stevenroose, @sgeisler now this will be pending your re-ACK

utACK 7c32c7f - is there a reason we're holding off of merging?

@stevenroose we are mainly constrained by 0.26.1 release since this PR is a breaking one and must be merged after it.
Otherwise, I will be happy to address all nits, aside from the fact that this will cancel three existing ACKs :( Not sure what would be the best thing to do

Addressed all nits with a separate commit 6155699b82101ef50be29d5ef65641166852663c, will ask everybody to re-ACK

Since you changed the other occurrences of ver I assume you want to fix these too @dr-orlovsky, so I'll wait with another review. Hopefully it will be the final one then :laughing:

I would not say that I see any good rationale  behind this bikeshedding, but I will change the names, ok

I would not say that I see any good rationale behind this bikeshedding, but I will change the names, ok

Me neither, I just wanted to avoid getting my review invalidated again xD

Converting to draft since pending merge of #617 (basing on it and requiring rebase once it will got merged)

Ok, merged #617, so this can be un-drafted.

@apoelstra rebased, updated, addressed comments & ready for review

@sgeisler thank you for the review! We have two ACKs from maintainers and one ACK from community, so I will merge it for now. But anyway lets finish the discussion of your nits in the comments and I will do another PR addressing them

Ok, we have version conflicts so re-review will be required anyway. I will address your nits with it - we just need to arrive to some end result with them

Rebased. @sgeisler I see your point with the UnsupportedWitnessVersion error, however since it requires more discussion and not a part of Taproot-specific update, I propose to leave it for a separate PR. It seems it is directly related to https://github.com/rust-bitcoin/rust-bitcoin/issues/648 discussion and we have to decide there on the overall API for Address type guarantees

@Kixunil my point is that solving this issue will require more discussion and must involve many more changes from other PRs and issues (like #648, #642, #643, #646). The primary focus of this PR is to enable P2TR addresses at the current master, and we've being discussing and working on this trivial think already for 8 months having more than a hundred comments.
So while I am definitely up for a much better API for addresses, it is more generic that just support for P2TR proposed in this PR, and will require (potentially many) month(s) of discussion – so I propose to finally merge this one and move forward, unlocking a way for Taproot-supporting release.

@dr-orlovsky Either I misclicked or GitHub have screwed up my comment, it was referencing line https://github.com/rust-bitcoin/rust-bitcoin/pull/563/files#diff-c55d0186f3d5990b5e223c1a8aa1bbe60988201c452dd13b3324e892bc33119eR88
I believe the documentation should say "but such address, while parsed, may return errors from some methods". (Parsing == converting string to internal representation)
This is unrelated to future designs as the documentation should reflect the state of things in code as written right now.

@Kixunil updated both error docs and display with the most verbose form I was able to compose. Pls review

I mean, I specifically have issue with the word "parsing", which means converting string to internal representation. The literal parse() method is implemented on &str via FromStr but that impl does not return FutureWitnessVersion. There's no other parsing method. All other methods do various other processing, not parsing. So the way the doc is written implies that such error is returned from from_str/parse which is not the case. It's the other way around - parsing does not return that variant, but other methods do.

@apoelstra, I have removed both controversial commits and made this PR to be only about P2TR address support. So now:

no From<WitnessVersion> for bech32::u5
address_type reverted to return Option and not Result, as was before

The support of future Witness versions is independent from P2TR addresses and will be addressed in a separate PR(s), together with the rest of required address refactoring (#648, #642, #643, #646...).

@Kixunil eaiting for you approval to merge this. I have removed all controversial part which was not directly related to P2TR address


_CastError (Null check operator used on a null value) in registerBackgroundMessageHandler could be improved

Bug report
Describe the bug
In File firebase_messaging_platform_interface-2.0.0\lib\src\method_channel\method_channel_messaging.dart
in function registerBackgroundMessageHandler
bgHandle and userHandle are assigned using
final CallbackHandle bgHandle = PluginUtilities.getCallbackHandle(
_firebaseMessagingCallbackDispatcher)!;
final CallbackHandle userHandle =
PluginUtilities.getCallbackHandle(handler)!;
But PluginUtilities.getCallbackHandle can return null, which will then result in an exception:
Exception has occurred.
_CastError (Null check operator used on a null value)
Steps to reproduce
Steps to reproduce the behavior:

Clone this repository
Run the app
See error

Expected behavior
No Exception should occur.

Additional context
Add any other context about the problem here.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
PS C:\Development\github\hecklatcipsoft\firebase_exception_minimal> flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.0.2, on Microsoft Windows [Version 10.0.19041.804], locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.1.0)
[✓] VS Code (version 1.54.3)
[✓] Connected device (3 available)

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
PS C:\Development\github\hecklatcipsoft\firebase_exception_minimal> flutter pub deps -- --style=compact
Dart SDK 2.12.1
Flutter SDK 2.0.2
firebase_exception_minimal 1.0.0+1

dependencies:
- cupertino_icons 1.0.2
- firebase_core 1.0.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_messaging 9.0.0 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- async 2.5.0 [collection]
- boolean_selector 2.1.0 [source_span string_scanner]
- characters 1.1.0
- charcode 1.2.0
- clock 1.1.0
- collection 1.15.0
- fake_async 1.2.0 [clock collection]
- firebase_core_platform_interface 4.0.0 [flutter meta plugin_platform_interface]
- firebase_core_web 1.0.1 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_messaging_platform_interface 2.0.0 [firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 1.0.1 [firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- js 0.6.3
- matcher 0.12.10 [stack_trace]
- meta 1.3.0
- path 1.8.0
- plugin_platform_interface 2.0.0 [meta]
- sky_engine 0.0.99
- source_span 1.8.0 [charcode collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- term_glyph 1.2.0
- test_api 0.2.19 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0 [collection]
- vector_math 2.1.0

Hi @hecklatcipsoft
The callback handle cannot be null, otherwise, the method can't be registered for the background messaging handler.
You need to provide a top-level function that is not anonymous.
void _bootStrapFirebase() async {
  await Firebase.initializeApp();
  FirebaseMessaging.onBackgroundMessage(onBackgroundMessageHandler);
}

Future<void> onBackgroundMessageHandler(RemoteMessage message) async {
  print("Handling a background message ${message.data}");
  //You need to do everything in here
  //If you need to do anything with firebase you also need to call
  //await Firebase.initializeApp();
}

Thank you

Hi @markusaksli-nc,
Thanks for your answer, I didn't read the comment that clearly states that it has to be a top level function.
However you still might want to update the comment because there also isn't an ArgumentError we could handle to deal with a problem.
The async registration just fails and the log is lost in the debug console.
Changing registerBackgroundMessageHandler to not be async might help mitigate the problem because then at least some exception hits the consumer.
@override
  void registerBackgroundMessageHandler(BackgroundMessageHandler handler) {
    if (defaultTargetPlatform != TargetPlatform.android) {
      return;
    }

    if (!_bgHandlerInitialized) {
      _bgHandlerInitialized = true;
      final CallbackHandle bgHandle = PluginUtilities.getCallbackHandle(
          _firebaseMessagingCallbackDispatcher)!;
      final CallbackHandle userHandle =
          PluginUtilities.getCallbackHandle(handler)!;

      channel.invokeMapMethod('Messaging#startBackgroundIsolate', {
        'pluginCallbackHandle': bgHandle.toRawHandle(),
        'userCallbackHandle': userHandle.toRawHandle(),
      });
    }
  }

I'm pretty sure you cannot delegate synchronous calls in MethodChannels in Flutter right now so I'm not sure that would be possible. Though maybe there could be better feedback here.

I can agree that this message is very confusing.
Providing an async named method that is not top-level function just results in a (Null check operator used on a null value) error that doesn't help much.
Also, the whole concept is a bit unclear. This callback is needed to be able to show local notifications somehow. It's not possible to pass any custom arguments into the callback, how are we supposed to show custom notifications?

We have spent much time trying to upgrade our packages to the latest version after upgrading flutter to V2.0.0.
This issue really affects our upgrades,
Is there any workaround to solve this issue? 😟

@JabalSoft There is no issue. Everything works if you provide a top level named function as a callback because flutter_messaging users isolate internally.
The issue I see is that if you use some other dependency to show notification, you need to find a way to use it from a top level function somehow

I will try to "flutter clean" and try again

@JabalSoft There is no issue. Everything works if you provide a top-level named function as a callback because flutter_messaging users isolate internally.
The issue I see is that if you use some other dependency to show notification, you need to find a way to use it from a top-level function somehow

Your comment relay helps us, we convert our anonymous function to class function but not top-level (outside class).
After we put our function outside our class OR make it static the issue solved.
Maybe coloring the lines of the instructions on the documentation page with yellow or red is a good idea 😅.
Thanks.

@AAverin What do you mean by the local notifications bit? That is what onMessage is for. The background message handler is meant for handling data-only messages that can be used for various functional purposes (such as phone auth code auto-retrieval in firebase_auth).

I think we should improve the internal typing here so it does throw a cast error at least


Missing word in introduction

There is a word missing in the sentence: "While such individual events are infrequent, at cloud scale, they every week if not every day."
This should read: "While such individual events are infrequent, at cloud scale, they occur every week if not every day."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 15036ef6-9c0b-044e-d600-b9f90f039720
Version Independent ID: 6fe5cd14-a1ad-e183-a048-d72686abb969
Content: High availability - Azure SQL Database service | Microsoft Docs
Content Source: articles/sql-database/sql-database-high-availability.md
Service: sql-database
GitHub Login: @anosov1960
Microsoft Alias: sashan

@rabryst
Thanks for the feedback! We are currently investigating and will update you shortly.

This edit has been implemented and merged. All checks passed.

Trying this again, as my edit did not seem to stick.


V2.0 aid

Codecov Report

Merging #329 into v2.0 will increase coverage by 0.76%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##             v2.0     #329      +/-   ##
==========================================
+ Coverage   86.93%   87.69%   +0.76%
==========================================
  Files          30       30
  Lines        1125     1219      +94
==========================================
+ Hits          978     1069      +91
- Misses        147      150       +3

Impacted Files
Coverage Δ

konfera/urls.py
100% <100%> (ø)
:arrow_up:

konfera/tests/test_views.py
100% <100%> (ø)
:arrow_up:

konfera/serializers.py
100% <100%> (ø)
:arrow_up:

konfera/admin.py
81.69% <100%> (ø)
:arrow_up:

konfera/validators.py
83.33% <100%> (+11.9%)
:arrow_up:

konfera/views.py
100% <100%> (ø)
:arrow_up:

konfera/models/ticket.py
93.33% <75%> (-1.31%)
:arrow_down:

konfera/models/ticket_type.py
94.87% <76.92%> (-2.15%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800f41d...ef71cac. Read the comment docs.

tests are failing please fix them

Unitests are (were always) OK, codecov is failing as it doesnt have version compare agains (not sure why).


[question] CSS Style bindings security

What security considerations have been made when it comes to allowing bindings in css?
Will there be any default binding encoding, just like we know it from using ${foo} in html?
Is the developer expected to only bind trusted data?
Is it only allowed to bind property values that will be escaped (difficult to get right)?
There are so many ways of doing attacks through css, so I'm interested in knowing your considerations when it comes to preventing attacks such as Cross Site Scripting.
My suggestion would be to only ever bind trusted data.

It's definitely up to the developer what they bind. The style engine uses the same binding engine and parser as the rest of Aurelia. The string interpolation logic is just re-used straight from the binding library.


Dashboard should show world map with claim bubbles

[x] claim should fire the gtm tag dataLayer.push({event:'claim-geo',claimValue:})
this is already configured in GTM
[x] env variable with embed url
[x] embed datastudio
<iframe width="800" height="450" src="https://datastudio.google.com/embed/reporting/1ALW5HR6lmRdLWdkZj6F1mhdN6xfZ6pRy/page/mlwTB" frameborder="0" style="border:0" allowfullscreen></iframe>
set correct width/height
[x] embed url for dev/staging env
https://datastudio.google.com/embed/reporting/1BI7io5MQdlY-pgRtIwahM35XCEvTTWAu/page/mlwTB
[x] verify looks ok on mobile devices

@sirpy Change so bubble will be per country.

The link to the GoodDashboard PR - https://github.com/GoodDollar/GoodDashboard/pull/26

@yaroslav-fedyshyn-nordwhale bubbles aren't displayed on the map
Checked on DEV V0.24.1-3
Desktop: Windows 10 // Google Chrome  83.0.4103.106

@AnastasiiaOdnoshevna that's ok, we are playing with the look and feel.
we need to verify that map details change as people claim. try claiming from another country, or just claim and verify that the value on hover grows

@sirpy I claimed from Canada (before the claim's history of Canada was empty) and after just one claims the 100 claims are displayed

@yaroslav-fedyshyn-nordwhale I claimed from Germania (before the claim's history of Germania was empty) and after just one claims the 1 claims is displayed as it required
Checked on DEV V0.24.1-5
Desktop: Windows 10 // Google Chrome  83.0.4103.116


Fix broken links in README

Coverage remained the same at 100.0% when pulling 913a6a4a22d914c8ec8a738da898f4b80b537430 on readme-broken-config-links into 457bafc027565332e44dec19a545cc8506853579 on master.

Looks good to me.

Coverage remained the same at 100.0% when pulling 1fefc512128eb231a478a68a89d2a00fac49d729 on readme-broken-config-links into b817cc9c99f1913bdef77a5f807054ea1e887af2 on master.


Fixes MacOS linker issue with release build

[approve autest]

[approve ci autest]

[approve ci autest]

[approve ci autest]

[approve ci autest]

I don't think we need this for 8.0.0, at least not unless we also back port the commit that breaks things (I think it's 15fe1ae42917be156dece87dfa3c5f983d9a3c75)

[approve ci autest]


Added comments, little bugfixes

added comments
clicking on the icon now opens the selectBox
clicking on the map with open selectBox closes SelectBox
removed unused Leaflet.StyleForms

👍 Thanks!


migrate: to angular v17

awesome, thanks for taking care. There is a build error. You will need to update nodejs in .github/workflows/pull_request.yml:
Node.js version v16.20.2 detected.
The Angular CLI requires a minimum Node.js version of v18.13.

Please update your Node.js version or visit https://nodejs.org/ for additional instructions.

Error: Process completed with exit code 3.

thanks for contributing

No problem, thanks for the fast review. 🚀


Adding the ability to have notes show under the quests

I DM an in person game so my players never see the quest stuff. It would be useful to be able to click an assigned quest requirement and it would expand to show details/notes about that quest, then click and it would collapse again.

Flow:
When you click the first quest requirement it would expand to show the details, then when you click it again it would collapse. Same with each quest.

Hi @MaineKnight...
I'm prefacing this comment as I was the past developer / maintainer of FQL up to this most recent release 0.8.0, but can provide a response. Any future enhancements will be directed by Forien the original developer of FQL moving forward.
It's certainly great that you find FQL useful for in-person games, however it's challenging to provide a more streamlined user experience (UX) in this case as it is not the main use case / environment of Foundry. While there are no metrics for those that use Foundry / FQL solely for in-person games the percentage is assumed to be rather low if barely registering.
Normally, when FQL is used in a VTT context any extra notes on the quest that a GM might want to notate goes under the GM Notes tab / editor. You are using the main description area that is intended to be publicly viewable in a VTT context for this purpose which is fine, but is not something that can be normally linked to objectives. There are general challenges as well since that field is a rich text editor (RTE) field, so coordinating linking between the RTE and objectives stored in a quest is not something that can be prioritized.
FQL does have a public API that could use a bit better documentation. It's entirely possible to create an additional module that provides a better workflow for in-person games, but still leverages FQL for the main quest management / tracking. This is beyond the scope of FQL itself though.
My guess is that while acknowledged that this enhancement request will not be fulfilled with anything actionable on the FQL side of things.

Hi,
Thanks for the message back. It was a feature I had seen in another quest module and found worked well. So thought I would suggest it here as I find this layout a little more usable.


speed up services rendering by recycling pages

After a cluster's services page has been initially rendered, this speeds up subsequent visits to that page by re-using the original, already-rendered page (and avoids redundant AWS API requests).
While PR #126 helped reduce the initial service page rendering to 4-5 seconds in clusters hosting 400-500 services, this reduces subsequent service page rendering to < 1 second.
As a tradeoff, service page data is no longer guaranteed to be fresh with each page render, though <ctrl+r> continues to reload the data.

Hi, I chose to use -stale-data option is indicate not fetching new data in every move and published v1.0.22 😃


[9.x] Get the validated data Except keys from the request

Sometimes we want to validate the inputs and make sure that are correct, but when retrieve data in the controller $request->validated()  all keys will return!
so I added function will filter keys with values and with be applicable with one key or array of keys $request->validatedExcept(['keys'])
-> now, the validated keys will return except keys I passed to the function

Hello @BNhashem16
I think you can use exclude or exclude_if instead.
https://laravel.com/docs/9.x/validation#rule-exclude

Hello @habibalkhabbaz
can you read my description again, please?
this functions you mentioned is not related to my function!
please check the files I changed, and you will understand my idea :)

It is exactly what you need.

exclude

The field under validation will be excluded from the request data returned by the validate and validated methods.

// Retrieve a portion of the validated input data...
$request->safe()->except();

https://laravel.com/docs/9.x/validation#creating-form-requests


Are we still using textDescription, or can it be deleted?

Are we still using textDescription, or can it be deleted?  I'm seeing numerous instances in our common code repos.  It was going to be used for accessibility, but now perhaps there is a different way of doing it?  If @jonathanolson and @aaronsamuel137 don't have plans to use textDescription as part of the current accessibility work, then it should be deleted.

Not currently using it, but it's likely we'll need something very similar and may end up using the current implementation.

This is quite old and doesn't exist anymore, closing.


Fix "set default thumbnail" and "fix dates" in MOMultiImageUploader

As reported by @JoeCohen.
I don't have energy to write new system tests for this tonight, so i will push this out and hope it at least improves the situation.

coverage: 94.276%. remained the same when pulling cfcaeff03cca2629ba9d5ab3da9a7929bbfc3e63 on nimmo-multi-image-uploader-nojquery into 269f4295a6dd9c554e942d9a1a699a66bfcd17a4 on main.


JSX/TSX split self-closing tags

Hi!
I'd love to be able to "split" a self-closing tag into a start and end tag:

gS

  foobar

gJ

Do you feel like this would be in scope of this plugin?

Yes, that definitely seems like a good fit. I've pushed a branch called self-closing-tags that you could try out, see if it works for you. There's a few gotchas.
First off, for the second example, joining to a self-closing tag only works with an empty tag, so the particular example wouldn't work, but this should:

gJ

Second, I've only implemented this for JSX and TSX. In plain HTML, as far as I know, not every tag can be self-closing, and the ones that are can't be expanded.
This might, however, be a bit of a problem in terms of filetypes. I don't use a lot of react, but I experimented a bit with some tutorials and it seems the recommended file extension they use is just .js. But this ends up setting the filetype in my Vim to javascript, and I need to set javascriptreact to get this functionality. I'm not sure what the solution is here, apart from using a .jsx file. You could put the following in ~/.vim/ftplugin/javascript.vim:
runtime ftplugin/jsx/splitjoin.vim

This will set the applied callbacks to the jsx ones, and not the javascript ones. I wonder if it makes sense to provide a setting to just use the jsx callbacks for all javascript files. It shouldn't be a practical issue, but the imprecision annoys me.
The other thing to note is that, for a self-closing tag, there's already a different kind of split activated -- splitting attributes. So, right now, this is the flow of splitting:
let button = <Button foo="bar" bar="baz" />;
// splits to:
let button = <Button
  foo="bar"
  bar="baz" />;
// splits further to:
let button = <Button
  foo="bar"
  bar="baz">
</Button>;

// joins to:
let button = <Button foo="bar" bar="baz">
</Button>;
// joins further to:
let button = <Button foo="bar" bar="baz" />;

You can get whatever form you need with partial splitting and joining, so I think this should be okay. It's a question of priority, and I don't feel it's clear which should expand first -- the attributes on new lines or the closing tag -- depends on whether you want to add more attributes or add children to the node.
What do you think? Could you try that branch out and see how it feels, look for any issues?

Oh wow that was fast 👏!

In plain HTML, as far as I know, not every tag can be self-closing, and the ones that are can't be expanded.

Correct! There's only a handful of void elements

But this ends up setting the filetype in my Vim to javascript, and I need to set javascriptreact to get this functionality. I'm not sure what the solution is here, apart from using a .jsx file.

I believe it's standard to just target the javascriptreact and typescriptreact filetypes for JSX-specific plugins.

The other thing to note is that, for a self-closing tag, there's already a different kind of split activated -- splitting attributes. So, right now, this is the flow of splitting:

Makes sense! However it is a bit annoying to me because in every JS/TS project we use Prettier to automatically format the code so this plugin sometimes does unnecessary things. Would be nice to disable attr splitting - can I control this via autocmd + overriding b:splitjoin_{split,join}_callbacks perhaps?

What do you think? Could you try that branch out and see how it feels, look for any issues?

It's working pretty good! I'm having some issues joining tags where the end tag is on the same line: https://asciinema.org/a/6NYPHn4U681s8mKJ3KVX4Eqib.

diff --git a/ftplugin/tsx/splitjoin.vim b/ftplugin/tsx/splitjoin.vim
index 4ae2957..6b2bbbb 100644
--- a/ftplugin/tsx/splitjoin.vim
+++ b/ftplugin/tsx/splitjoin.vim
@@ -6,12 +6,13 @@ let b:splitjoin_split_callbacks = [
       \ 'sj#js#SplitArray',
       \ 'sj#js#SplitFunction',
       \ 'sj#js#SplitOneLineIf',
-      \ 'sj#js#SplitArgs'
+      \ 'sj#js#SplitArgs',
+      \ 'sj#jsx#SplitSelfClosingTag'
       \ ]

 let b:splitjoin_join_callbacks = [
       \ 'sj#html#JoinAttributes',
-      \ 'sj#html#JoinTags',
+      \ 'sj#jsx#JoinHtmlTag',
       \ 'sj#js#JoinFatArrowFunction',
       \ 'sj#js#JoinArray',
       \ 'sj#js#JoinArgs',

I believe it's standard to just target the javascriptreact and typescriptreact filetypes for JSX-specific plugins.

Yes, I happily agree :)

It's working pretty good! I'm having some issues joining tags where the end tag is on the same line: https://asciinema.org/a/6NYPHn4U681s8mKJ3KVX4Eqib.

Usually, joining only works for multiline code, but I can see how your case makes sense. I've applied a fix, so this should work now.

Would be nice to disable attr splitting - can I control this via autocmd + overriding b:splitjoin_{split,join}_callbacks perhaps?

Yes, and I realize this is a bit inconvenient. What you could always do is define your own list of callbacks in your own ftplugin files.  But I realize this is inconvenient, especially given you'd need to do it for both JSX and TSX. It also means if I make changes to the callbacks or reorder them, your copy could break (has happened before internally).
So, I've created the disabled_split_callbacks and disabled_join_callbacks settings -- you can find explanations in the help files in the branch. Let me know what you think.

So, I've created the disabled_split_callbacks and disabled_join_callbacks settings -- you can find explanations in the help files in the branch. Let me know what you think.

It's.. perfect!

Excellent :). I've merged the branch to master, so I'll consider this issue closed for now. If you encounter any problems with it, feel free to reopen or create a new issue.


How to display heads-up notifications in Android?

In iOS, displayNotifications displays a heads-up, banner notification, in addition to it appearing in the Notification Center.
In Android, the notification appears in the Notification Shade but doesn't appear over the foregrounded app as a heads-up notification, even though Android 5+ supports it.
How do I do this in notifee? Not sure if I missed something super obvious.
Thanks!

You will need a high priority Android channel and notification for it to display in heads up mode; https://notifee.app/react-native/docs/android/appearance#setting-importance-level

Thank you, that's very useful.

It seems i have the same problem, even with AndroidImage.HIGH added in both channel and display notification, its only showing up in the Notification shade , i have permissions given too, it worked with react-native-push-notifications, doesn't seems to work with Notifee

@ChathuZenith with importance you must also provide id as important also. For reference you can check below:
const channelId = await notifee.createChannel({
id: 'important',//change this to important as well
name: 'Default Channel',
importance: AndroidImportance.HIGH,
});

don't forget to add this line  in AndroidManifest.xml
    <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>

@ChathuZenith with importance you must also provide id as important also. For reference you can check below: const channelId = await notifee.createChannel({ id: 'important',//change this to important as well name: 'Default Channel', importance: AndroidImportance.HIGH, });

I this the id is not relevant.
Maybe it fixed the issue on your side, because the old channel was stuck without the high importance configuration.
But once you changed its name, a new channel was created with the correct importance configuration.


Support for page partials / nesting

If I have a sidebar at the root level with global navigation and another sidebar in a subdirectory, rather than merely overwriting it I would like to have one shown after the other.  This would allow me to persist global navigation and add directory/section specific items above or below that without duplicating the content.
Another example use case would be if I made a page that had an important message that I wanted included on several pages, rather than having to link out to it anywhere that I wanted to display that snippet, I could just include that page within the current page.  Having the ability to use pages like includes would be handy to keep from having to duplicate content anywhere that it needed to be displayed and also to avoid an extra click through to get at the information.
If it was too difficult to make any page able to be included in another, maybe a specific format (similar to _Sidebar and _Footer) to identify a partial or perhaps placing the pages in a specific _partials directory.

+1 on that one


ERA5 and WRFout extraction

HI,
I am facing two issues.

I am trying to extraxt ERA5 receive following comments, can you please check time index?
All times inside era_ERA5 are as follows:
fatal:Number of elements of dimension (0) of argument (0) is (12) in function (addfile), expected (1) elements
fatal:["Execute.c":8637]:Execute: Error occurred at or near line 8 in file modules_era/timestep_era.ncl

Specify the time range (first and last time indexes) to be plotted:
First time index (press Enter for index 1): 00:00:00
Last time index (press Enter for the last index): 23:59:59
Extracting data by bilinear interpolatoin
PostWRF: Extracting variables ...
fatal:Number of elements of dimension (0) of argument (0) is (12) in function (addfile), expected (1) elements
fatal:["Execute.c":8637]:Execute: Error occurred at or near line 11 in file extract_era.ncl
PostWRF: Extracting variables finished.

I am trying to extract now monthly wrf out. although the variable is in file it is giving following error.
Bilinear Inerpolation ...

Range of Domain Latitudes (south-north): 13.63 to 31.25
Range of Domain Longitudes (west-east) : 60.44 to 91.28
_get_wrf_var: Error: Variable 'T2' does not exist on the requested file(s).
Make sure you have a proper WRF output file that contains the
required variables for the diagnostic you want, or the
variable you want. Use 'ncl_filedump' to look at the file.

What is the ERA5 file format? Is should be NetCDF.

2. I am trying to extract now monthly wrf out. although the variable is in file it is giving following error.
Bilinear Inerpolation ...

It seems you modified your original wrfout to make monthly output, and this can be problematic. PostWRF is better to be run on original wrfouts.

ERA5 file format is NetCDF.
2.I have averaged out the original Wrfout because there are more than 300
original files.Then what could be the solution?

On Tue, Nov 15, 2022 at 5:25 PM Amirhossein Nikfal @.***>
wrote:

What is the ERA5 file format? Is should be NetCDF.

I am trying to extract now monthly wrf out. although the variable is in
file it is giving following error.
Bilinear Inerpolation ...

It seems you modified your original wrfout to make monthly output, and
this can be problematic. PostWRF is better to be run on original wrfouts.
—
Reply to this email directly, view it on GitHub
https://github.com/anikfal/PostWRF/issues/12#issuecomment-1315558144,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AONKPU2MI7QMR774GZHAWEDWIO2QFANCNFSM6AAAAAASBBNGZA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Dr. Suvarna Tikle
Postdoctoral researcher
Environmental Modeling Division
Max Planck Institute for Meteorology
Bundesstr. 53
D-20146 Hamburg
@.***
+91<PHONE_NUMBER>

Time indexes must be in integers (1, 2, 3, ...). Before that, they must be printed by PostWRF.

How did you average it out?

How to print or check time index of wrfout? But the time index error is for ERA5 data not wrfout.
By using bash script.

How to print or check time index of wrfout? But the time index error is for ERA5 data not wrfout.

After setting namelist.wrf like this (for era5 data):
WRF_Extract_ON_OFF               = 0
ERA5_Extract_ON_OFF              = 1

Variable_names                   = d2m
Location_names                   = Ashgabat, Mashhad, Tashkent
Location_latitudes               = 38.27, 36.70, 40.91
Location_longitudes              = 59.70, 59.47, 70.17

+Vertical_profile_plot_on_off    = 0
+Vprofile_X_axis_decimals       = 3

Please link or copy your ERA5 NetCDF files in the PostWRF directory. Now you can run postwrf.sh:
There are multiple NetCDF (ERA5) files in the current directory:

   1) era5_file2.nc
   2) era5_file.nc

Enter the number of the favored file: 2

era5_file.nc has been selected

Extracting data ...

All times inside era_era5 are as follows:
   1)<PHONE_NUMBER>
   2)<PHONE_NUMBER>
   3)<PHONE_NUMBER>
   4)<PHONE_NUMBER>
   5)<PHONE_NUMBER>
   6)<PHONE_NUMBER>
   7)<PHONE_NUMBER>
   8)<PHONE_NUMBER>
   9)<PHONE_NUMBER>
  10)<PHONE_NUMBER>
  11)<PHONE_NUMBER>
  12)<PHONE_NUMBER>
  13)<PHONE_NUMBER>
  14)<PHONE_NUMBER>
  15)<PHONE_NUMBER>
  16)<PHONE_NUMBER>
Specify the time range (first and last time indexes) to be plotted:
First time index (press Enter for index 1): 2
Last time index (press Enter for the last index): 5

For ERA5: Following error
PostWRF: Extracting variables ...
fatal:Number of elements of dimension (0) of argument (0) is (12) in function (addfile), expected (1) elements
fatal:["Execute.c":8637]:Execute: Error occurred at or near line 11 in file extract_era.ncl

Please send me your ERA5 file, as well as your namelist.wrf.

namelist.txt
Ps renamed to  to a txt for uploaded it

Thanks. I have used python and resolved issue. Sorry forgot to post here.


Finalize release notes for v1.6.0 final

As the title says

@rhatdan @TomSweeneyRedHat @giuseppe @baude PTAL

/hold

/lgtm

/hold cancel


[BUG]: issue - Import of V2.0 of Core Components failed

Describe the bug
An Import of V2.0 of the Core components failed -
Unconfirmed 76047.txt
Component (please tell us which flow or app you are experiencing issues with):

Solution Core
Version 2.0
Solution

To Reproduce
Steps to reproduce the behavior:
Download V2.0 of Core Components
Navigate to Solutions on Make.PowerApps.com
Select Solutions
Select Import
Navigate to downloaded solution and press OK
Expected behavior
I expected the Solution to Import
Screenshots
See above output
Additional context
Add any other context about the problem here.

v1.98 was already Installed

I retried and got this - Solution "Center of Excellence - Core Components" failed to import: ImportAsHolding Exception during StageAndUpgrade

Hello. This import from 1.98 is working for most people so you likely hit a product issue.
Note also that the first text you shared references the audit logs solution in it, not sure why.
Please also tell us, are you using the modern import and leaving it as Upgrade as shown here?

Hi Jenefer
As a result of the previous issue, I decided to install v2.0 of the core components.
THis is when I hit the current issue.
Regards
Nigel

Oh i see. So the text document is your notes.
Can you please let us know if you are following the path shown in the image for upgrade?

Hi Jenefer

Regards
Nigel

Thanks. You seem to have hit a product issue then. I suggest you try again in a little while, sometimes there are service issues when you attempt to upgrade. And if that doesnt work you will have to contact support.

Hi Jenefer
I have tried three or four times and all fail.  I can import other solutions so I suspect it is not a product issue, but the way the CoE solution has been built.
Regards
Nigel

Other users have upgraded successfully. If you share the full error you received I may see something else, but with the information above I cannot help further I'm afraid.

Hi Jenefer
The full error text is in the file Unconfirmed 76047.txt at the start of this thread.
Regards
Nigel

per your notes that has several steps in it yes? since there are notes about audit logs involved?

Please share just the error download from the failure to upgrade. and if I can see something there to help I will try.

Hi Jenefer
There is nothing there about audit logs - @.***D72D53.0EEA2380]
Regards
Nigel
From: Jenefer Monroe @.>
Sent: 09 April 2021 15:12
To: microsoft/powerapps-tools @.>
Cc: Nigel Price @.>; Author @.>
Subject: Re: [microsoft/powerapps-tools] [BUG]: issue - Import of V2.0 of Core Components failed (#911)
per your notes that has several steps in it yes? since there are notes about audit logs involved?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/powerapps-tools/issues/911#issuecomment-816711384, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACAXJUF7E4X4YE43BSH3YU3TH4DJ7ANCNFSM42USKHOA.

perhaps you shared the wrong file accidently.

 Not sure but I'm afraid I cannot assist here further.
If others see the same issue as you we may be able to see a pattern and help.
You will need to try to reach out to support.


Call http api in https

getCompanyByUniformNumbers(url) {
return ajax({
  url: `${process.env.VUE_APP_API_GCIS}/od/data/api/5F64D864-61CB-4D0D-8AD9-492047CC1EA6?${url}`,
  method: 'GET',
  responseType: 'json',
  crossDomain: true
})
  .pipe(catchError((error) => {
    console.log('error: ', error);
    throw error;
  }));

}
i get
Mixed Content: The page at 'https://myurl' was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://data.gcis.nat.gov.tw/od/data/api/5F64D864-61CB-4D0D-8AD9-492047CC1EA6?$format=json&$filter=Business_Accounting_NO eq 20828393'. This request has been blocked; the content must be served over HTTPS.
what should i do?

I'm not sure if I understood q correctly, but mixed content request is blocked by browser and rx doesn't play anything afaik. Is there specific rx side issue you'd like to raise here?


Added source map to dist folder

Fixed the error due to the lack of the source maps when debugging the code within the browser.

I signed it!


[prometheus-cpp] Update to version 0.12.2

Update prometheus-cpp to 0.12.2. Locally tested all the features on macOS.

Thanks for the update!


[Dashboard] Remove unnecessary requests in pages. Fix not close button in invite users modal.

This PR includes:

Fix for: Invite User menu missing go back icon #14739
Delegate requests to Home Page instead of doing it in list components to avoid unnecessary requests.

Working fine!!


Fix TS H264 key frame detection

When playing H264 video from a TS container, it seems the BUFFER_FLAG_KEY_FRAME in addition to being set on the actual IDR frames, is also wrongly set on each frame immediately preceding the IDR one.
In more detail the root cause seems to be the following. In streams with AUD, the consume at the beginning of the PES, on the AUD NAL, calls endNAlUnit() on the previous NAL (NAL_UNIT_TYPE_NON_IDR) and since randomAccessIndicator is set, this causes treatIFrameAsKeyframe to be true and so sampleIsKeyframe to be set while still on the previous sample (outputSample has not been called yet). The following NAL unit (SPS) causes endNAlUnit() to be called on the SampleReader for the AUD NAL which calls outputSample on the previous sample with sampleIsKeyframe wrongly set.
The proposed solution, with this PR, is to pass the randomAccessIndicator parameter in SampleReader in the startNalUnit() instead of the endNalUnit() and have it as a class variable in the SampleReader. With this change the randomAccessIndicator would only depend on the PES the current NAL belongs to and the issue described above would be resolved.

@dsparano. Thanks for reporting this issue and proposing a fix! Do you have a small ts sample that you can add in a unit test like those in the TsExtractorTests that exposes this issue and provides testing support for your change?

This pr has bug
The url can't play
http://altitcon2.3cx.hk:9991/stream/channel/b7992c06aba8ebfc87e21cda43d287d1

@microkatz I just committed the added unit test, and not sure how this PR ended up closed (!) could you re-open it?
@FongMi the url above doesn't seem to point to anything useful, if you can fix the url I'm happy to debug

@dsparano. Unfortunately I cannot reopen the pull-request. The button is not available to click. Perhaps create a new pull request?

Looks like github doesn't like a force push, even a non history rewriting one :( which is what sourcetree did for me, anyway opening another one...

@FongMi http://altitcon2.3cx.hk:9991/stream/channel/b7992c06aba8ebfc87e21cda43d287d1 seems to be playing fine for me on this branch

@dsparano Sorry, I will test again with pull/864


Adding response.close() for non API-key translator

@edisugi1996 Thanks for the PR. Did you test if this actually solves the issue or at least improves the performance?


goverlay: 0.6.4 → 0.7

Motivation for this change
Update to the latest version: https://github.com/benjamimgois/goverlay/releases/tag/0.7
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 148094 run on x86_64-linux 1

1 package built:

goverlay


[Existing API Name] : PokeApi

Brief Description 🤓
API for getting pokemon data based on the pokedex reference. Pokemon is a popular anime / manga / video games that tells stories about human and creatures called Pokemon
Provide reference!
https://pokeapi.co/docs/v2
Select the open source program you are contributing to
hacktoberfest-23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINES of this project.

Greetings @fandok🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇.  Use command /gdsc to self assign the issue.  This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣

/gdsc

Hi I already submitted my PR, please help review. thank you

Hi @dishamodi0910 is there any updates for this PR review?

Hey @fandok ! I wanted to inform you that we have closed issue.Thank you for your understanding, and we look forward to your continued engagement with our repository🤗.
In case of any issues, you can contact us on Discord.
Thank you! ❣
Happy Coding! ✨
Will See you soon❣


Mailcode command placeholders recognized as prices

When using the library in conjunction with Mailcode, some variable commands can be falsely recognized as prices.
The following text:
This will cost {showvar: $CONTRACT_AMOUNT} EUR per month.

Is converted to the following by the currency parser:
This will cost<PHONE_NUMBER>001999 EUR per month.

This is caused by the Mailcode safeguard parser replacing commands with numeric placeholders.
The easiest fix would be to teach the currency parser to recognize Mailcode placeholders.

A dependency to Mailcode has been added, and a check for placeholders added, which can be enabled with the expectMailcode() method. More information in the readme.


adding session info and removing author description

hmmm spelling errors in About.Rmd shouldn't be causing spellcheck to fail anymore


Distance marks

From @Rungee on June 8, 2015 6:37
Would be such feature interesting and helpful?

Copied from original issue: GIScience/openrouteservice#147

Will be added with update to Leaflet/OL3


remove mdivide_left_spd and mdivide_right_spd

These are not exposed to the users.
These functions are not used anywhere.
@bgoodri, @mbrubake: any good reason to keep these around? It looks like everything else uses the tri versions.

Closing this issue. We want to do #227 instead.


AttributeError: 'numpy.ndarray' object has no attribute 'to'

Is there anything keypoint needs to modify for ava data set? Why does the following error occur?

This error is self descriptive. The keypoints should be inside a pytorch tensor to support the method to


Shorten Nightly Product Test Aliases

💡 Summary
What is the work, as a high-level summary?  Shorten the alias names used for the Nightly Product Tests.
Motivation and context
This would be useful because the current alias names tend to be truncated by GitHub Actions making it challenging to know which test has passed or failed.  See here for an example.
This is part of an epic.
Implementation notes
Please provide details for implementation, such as:

Update the aliases
Update the dev secret
Test
Update the prod secret
Merge
Update the Slack canvas

Acceptance criteria
How do we know when this work is done?

[ ] We can look at the action results and see the corresponding alias.

The alias names have all been abbreviated and our now completely visible in the Actions "workflow" page.  This issue is complete except for final details.

This is finished and closed.


🪄 Add more class support to directives

This PR should increase the number of directives that support class and identifier in rendering. I doubt I've got them all, but I created a test case from the directives list: https://mystmd.org/guide/directives
Details
:::{aside} An Optional Title
:class: red

This is an aside. It is not entirely relevant to the main article.
:::

:::{tip}
:class: red
Try changing `tip` to `warning`!
:::

:::{bibliography}
:class: red

:::

:::{blockquote}
:name: quote
:class: red

Hello

-- world
:::

:::{code} python
:class: red

x + y
:::

:::{div}
:class: red

div
:::

:::{dropdown}
:class: red

dropdown
:::

:::{embed} #quote
:class: red

:::

:::{figure} https://picsum.photos/512
:class: red

:::

:::{glossary}
:class: red

Foo
: Bar

:::

:::{iframe} https://google.com
:class: red
:::

:::{include} test.md
:class: red

:::

:::{mermaid}
:class: red

graph LR;
dot --> dash;
:::

```{myst}
:class: red

Try this!
```

```{table}
:class: red

| Month    | Savings |
| -------- | ------- |
| January  | $250    |
| February | $80     |
| March    | $420    |

```

Could someone clarify whether we expect AST nodes to always have html_id, or whether the current fallback pattern
node.html_id || node.identifier is expected? I mentioned this somewhere else (probably Discord), but I don't think we touched upon it.

If there is an identifier, there should be an html_id always. If there isn't that is a bug. Those in the theme and there for legacy likely., or if we need the node to be identified, prefer the I'd and fall back to the key in the order: html_id, identifier, key.


Support for JSON-Fields

Issue Type

[x] Feature Request
[ ] Bugfix/Errors
[ ] Questions
[ ] Other

Description
As of version 9.4 (I think) postgresql supports the JSON-Type.
Currently if I query a row with this type the output only displays [object Object].
Since showing the whole JSON within a table gets unreadable very fast, I suggest the JSON content should at least be available through copy&paste (just like one can copy longer texts from the output even though it's truncated). Also showing a truncated version of the content (just like long texts) could be beneficial.

Fixed. WIll be release soon.


Last Heartbeat - Alarm status is not displayed in Homekit using Homekit Bridge.

Last Heartbeat - not added to Homekit using Homekit bridge.
Hi, First of all many thanks for your exceptional work! This plugin is really awesome but is there any solution to add Last Heartbeat sensor to Homekit? maybe as occupancy motion sensor? Homekit Bridge export only leak/gas and security status to homekit. Last Heartbeat is not displayed. Maybe there are something wrong with sensor settings or something wrong from the homekit side?

not sure what happens with that, but someone just added a power sensor (binary) to this integration, so you might be able to leverage that, warning: it has state unknown until the power actually goes off (and it falls back to battery), check it out!

not sure what happens with that, but someone just added a power sensor (binary) to this integration, so you might be able to leverage that, warning: it has state unknown until the power actually goes off (and it falls back to battery), check it out!

Fixed. Please close the issue. Thanks


[Android Doc Builds]: Fails to missing compiler

Crate name
catgirl-engine
Build failure link
https://docs.rs/crate/catgirl-engine/0.12.17/builds/1160654/aarch64-linux-android.txt
Additional details
Android docs fail to build due to missing compiler. This affects catgirl-engine, catgirl-engine-utils, catgirl-engine-server, catgirl-engine-client for aarch64-linux-android, armv7-linux-androideabi, i686-linux-android, and x86_64-linux-android

I don't know much a out this specific target platform.
We're using cross compilation to build most platforms, if the needed compiler has a ubuntu package, you can add it to our build environment.
With C/C++ dependencies a way often used is to use conditional compilation to not compile the dependency for docs, of course this only works if the public interface of your library doesn't depend on the C/C++ code.

Thanks! It does need a C compiler to build the android builds. Specifically the Android NDK. I'll have to find out if there's an Ubuntu package for it. I'm not sure how to build it without the C Compiler as the C Compiler is automatically invoked for me

@lexi-the-cute any update here? Can we close this issue?

yee

i gave up on it for now, so ill close the issue

ok, I understand, feel free to ping us again if we can help


Project Owner permission error when viewing Grafana dashboards via proxy

Cluster Setup

Kubernetes version: v1.20.15
Type of Cluster: RKE1
Installation option (Helm Chart):

global:
 cattle:
   clusterId: c-kpg24
   clusterName: t21
   rkePathPrefix: ""
   rkeWindowsPathPrefix: ""
   systemDefaultRegistry: mtr.devops.telekom.de
   systemProjectId: p-6gndd
   url: https://*****.de
 systemDefaultRegistry: mtr.devops.telekom.de
helmProjectOperator:
 projectReleaseNamespaces:
   labelValue: cattle-monitoring
 releaseRoleBindings:
   clusterRoleRefs:
     admin: admin
     edit: edit
     view: view

Describe the bug
If a project owner activates Project Monitoring (monitoring v2), and they are not a Cluster Owner, they get the following error, when viewing a Grafana Dashboard (via the proxy URL):
Error services "http:cattle-project-p-t9zwm-monitoring-grafana:80" is forbidden: User "u-umctamlw5n" cannot create resource "services/proxy" in API group "" in the namespace "cattle-project-p-t9zwm-monitoring"

The role cattle-project-p-t9zwm-mon-admin is missing this Permission as well:
rules:
  - apiGroups:
  - ""
resourceNames:
  - http:cattle-project-p-t9zwm-mon-prometheus:9090
  - https:cattle-project-p-t9zwm-mon-prometheus:9090
  - http:cattle-project-p-t9zwm-mon-alertmanager:9093
  - https:cattle-project-p-t9zwm-mon-alertmanager:9093
  - http:cattle-project-p-t9zwm-monitoring-grafana:80
  - https:cattle-project-p-t9zwm-monitoring-grafana:80
resources:
  - services/proxy
verbs:
  - get

A Cluster Owner doesn't get the error mentioned, I guess some other role allows them to create the services/proxy resource.
To Reproduce

Install prometheus operator
Activate Project Monitoring with standard values
Visit the grafana dashboard, wait a few secs.

Result
The error message appears in grafana. The function of the prometheus stack doesn't seem affected by this.
Expected Result
No error regarding proxy connections should appear.
Screenshots
https://imgur.com/FbAfUuz
Additional context
None

#45 should fix this, if the cattle-project-p-*****-mon-admin Role is the only one being bound to monitoring users (that was the only one that I could find bound to my project owner).


No stories were found.

Using storybook 6.3.7 which is completely functional. Added Story Explorer addon and it can't find any stories in the panel no matter how many path variations I try. The Open Storybook Config and Open Storybook in browser both work (if I set storyExplorer.server.internal.enabled to false and launch manually). What is this extension doing different from storybook's story locator?
I have multiple sub-storybook configurations and the issue persists no matter which one I point storyExplorer.storybookConfigDir to.

That seems fine to me. Replicating your setup as best I can, I see the story show up as expected:

Wonder if maybe there's something more going on in your main.js that can't be read for some reason. That file is actually evaluated (i.e., using require), so it's conceivable something could not be working there when the extension tries to read it that works when it's read by storybook.

I've added a couple things to make this type of thing easier to diagnose. There's now a storyExplorer.logLevel setting that you can use to enable more verbose logging via the output panel. I've also added specific handling for when we run into a problem parsing main.js so the message in the stories panel should be more direct (if that is, in fact, the cause).
If you're still having this problem, feel free to bump up the log level (e.g., warn or above will capture any issues parsing main.js) and post the output here.


Rename solver.Installable to solver.Variable.

As part of preparing the resolution component (and subcomponents) for
use as a library, this clarifies the purpose of the Variable type: a
variable in a constraint satisfaction problem. The original name,
Installable, unnecessarily ties it to the resolver package's operator
installability use case. The solver package finds solutions to
constraint satisfaction problems in general.

/cc @timflannagan

Thanks - I think this is a step in the right direction, as variables like BundleInstallable didn't make much intuitive sense to me while reading these packages throughout the codebase. The only other thing I'd like to see is better godoc comments any user-facing type/interface/etc. that would make traversing this package a bit easier, and could help us work towards making the responsibilities of each level of abstraction here a bit more clear.

/lgtm


Add the (now required) SSI exe and version arguments to the LanguageServer

The Julia language server now requires 10 arguments, with the last two being the Julia exe and version number used to run the SSI on.
This PR is a quick fix which just uses the same Julia binary.
It looks like this is the default for the Symbol Server, so hopefully it is not an issue.
This fix gets the server back up and running on my machine.
Cheers!

Hi! I just want to mention that Julia LSP is broken without this PR and works perfectly after applying this patch.

Probably for this to be merged you also have to fix the windows version in julia-lsp.cmd.

Thanks @lassepe, I have made the same fix to julia-lsp.cmd.
Similar to julia-lsp, it just uses the same Julia binaries and gets the version by running julia --version and picking up the correct version number.
This gets it working again on my Windows machine :)

I've re-released v1.83.2, so you'll need to reinstall julia-lsp manually (this repo tracks version numbers from upstream so we can't really cut a new release version without complications)