[TW#12146] ADC2 driver (IDFGH-845)

     The ADC driver API currently only supports ADC1 channels，but if I want to use ADC2 channels , how should I do?

@FFtust
recommend you this steps:
first, download the technical reference for esp32
study the register and compare the thing with adc1.
then check the header for adc
right, you see, there is just in time only support adc1
then look up in the c file for , where adc is at home
and right again, you see, that adc1 is only supported just in time.
if you can not wait for official support adc2 then you must do this steps:

look up which pins are have ad2 supported function

add in adc header file your enum for this as adc2 type pins , example for new adc2_channel_t

add in adc header file 3 (api) function declaration

esp_err_t adc2_config_width(adc_bits_width_t width_bit);
esp_err_t adc2_config_channel_atten(adc2_channel_t channel, adc_atten_t atten);
int adc2_get_voltage(adc2_channel_t channel);

add in rtc_module.c the definition for this, a good example are the adc1 function'see

...
it looks like this then
everything too much trouble?,  then here you are welcome to test this repo
btw, pullrequest is done.
https://github.com/espressif/esp-idf/pull/466
hope this helps
best wishes
rudi ;-)

Well done, just need it.

For me adc2 works fine until I enable wifi. adc2 stops working then. Same issue when using the esp32-arduino libraries. Could this be the reason why adc2 isn't available in esp-idf?

Exactly! WiFi driver uses some of the ADC2 circuitry. So the code in the PR can indeed be used when WiFi/BT are disabled, otherwise controlling ADC2 from software may interfere with WiFi.
Supporting simultaneous WiFi and ADC2 operation is not something we have plans to support, for now. We will however add an ADC2 driver which may be used if WiFi is not in use.

Quoting @20leunam: "Then we will chop off the antenna, and plug an external bluetooth module to TX/RX!" :)
I agree it is a pity to discard so many analog pins. This will limit many applications of ESP32.
Do you think it may at least be possible to live-disable WiFi momentarily, in order to measure ADC2, and re-enable wireless it afterwards? Or is the adc2 locked at boot time?

Yes, this should be possible. We'll need to make sure that WiFi/PHY initialization code resets all the ADC2 registers into the expected state during initialization (this may not be the case now), but aside from that, disabling WiFi (using esp_wifi_stop/esp_wifi_deinit) to do the measurement should be possible.

Would like to do that very much, too.
Only we unfortunately do not know what exactly is done under the api commands,   esp_wifi_stop/esp_wifi_deinit Since they are packed in the lib.
So sometimes we can only wait or do it ourselves.
or pack third party code now in libs too :)
honest: libs are bad if src is not available and counterproductive
It is my personal opinion

I agree it is a pity to discard so many analog pins. This will limit many applications of ESP32.

Yes possibly down to two if you use pre amp and 32khz. Would be nice to have even low rate async adc2 read possible in cooperation with the WiFi driver.

I am trying to read from ADC2 after enabling and disabling wifi. So far I've tested multiple combinations of esp_wifi_stop, esp_wifi_deinit, esp_phy_rf_deinit to disable the wifi driver.
The test set up is a pull down resistor in ADC GPIO26, which properly reads as "0" until wifi is started.
Since @igrr mentioned restoring back ADC registers to default state, I've also force re-run the ADC initialization routines in Arduino-ESP32, after wifi had been disabled.
This did not help: reading back from ADC2 pins always returns 4095. Maybe I'm missing other ADC registers?
Using rtc_gpio_init had no effect either.
I've run out of ideas. Please let me know if you think of other ways to achieve this. I'd be happy to test them!

I'm making a connected sensor that uses most of the ADC pins, and for the moment my approach is going to consist in:

Read from the ADC.
Then turn wifi ON to send the values.
Finally self-restart the board, with wifi disabled (restoring the possibility to read from ADC2).
This is very ugly. So I am hoping it will be possible to achieve it in a clean way at some point :)

Can we have a clarification about ADC2, please?
Is it a matter of an hardware limitation and WiFi cannot work together with ADC2, or simply there's no support for ADC2 right now?
Can we expect to have ADC2 available in the future or it's simply impossible?

ADC2 can be used together with WiFi on a time sharing basis. I.e. WiFi stack uses ADC2 for its own purposes, but also allows the application to poll ADC2 using some API. Such scheme is not implemented yet, and will not be part of the upcoming release.

What about using esp_wifi_stop/esp_wifi_deinit to do the measurement, do you advise to wait until the proper driver is ready?

Hello,
i would like to know if the same limitation is valid for BT too or just WiFi. I'm asking this because of a similar issue

Fyi, we're a bit hesitant to make ADC2 available because it is also used for pretty important control loops inside the WiFi (and maybe BT, I don't remember) drivers. We want to make sure there's no chance of these and the user ADC calls to interfere with each other.

Hello,
@igrr  could you specify which ADC2 channels are used by WiFi. On our custom board, we met with a problem of establishing a connection with AP (APs scan is working fine). At the same time, we are using pins with ADC2 func for other purposes like uart, digital out and in. We tried wifi example on our board (is not working) and Esp Wroom (is working). I know there might be several other reasons, but it helps cut off ADC2 related suspicions. Thanks in advance!

None of the ADC2 channels connected to external pads are used by WiFi driver. There is a mux which is used to connect other internal signals to ADC2 input. Digital pins connected to ADC2 pins should not have any effect on WiFi.

"Such scheme is not implemented yet, and will not be part of the upcoming release."
So igrr, any hope it will be implemented any time soon. It's really, really important for us. Thanks

Hi, i want to use the adc1 and adc2 channels from esp32 integrated with the bluetooth, i'm using the spp_counter from bluekitchen as a base code, this is the repo with the code:
https://github.com/Yuggo1/ESP_Gloves
The code to support the adc2 i've got from here ESP32DE/esp-idf@f467f68
and it works when using it without the bluetooth, but i'm getting the same problem from this issue using the bluetooth, does anyone know if ADC2 conflicts with bluetooth using spp?
 Are there further changes to use adc2 in connection with wifi?

Doesn't seem like what would expected from coexistence

That's not coexistence with WiFi yet. This just allows using ADC2 when WiFi
is disabled, and prevents collisions between app and wifi driver if someone
tries to use ADC2 with WiFi enabled. Full coexistence is still being
developed.
On Tue, Oct 31, 2017, 13:02 negativekelvin<EMAIL_ADDRESS>wrote:

Doesn't seem like what would expected from coexistence
https://github.com/espressif/esp32-wifi-lib/commit/a3c8f349fe3c9e5be6cf74b813a1dc505fe38dc1
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/espressif/esp-idf/issues/461#issuecomment-340660751,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEJceqRvm-6F2GNP5ZVjY3hPUdcE6JhDks5sxqndgaJpZM4Mpx1H
.

Is there another issue I can watch to get notified on coexistence?
Couldn't find one.

Let's keep this one open until coexistence with WiFi is available.

Thanks a lot @igrr

I know it's annoying, but: Is there a time-estimate on when coexistence will be available?
Are we talking about weeks or months?
Thanks!

I'm finding my use limited by this issue too. I wasn't using WiFi for my project but BLE, and apparently it runs into the same problem.

Anything new here? Would be a nice christmas present ;)

Hi! I've just got stuck with exactly the same problem with BLE. I have 16 ADCs running from ADC1 and ADC2 banks. They all work as expected till the moment when I initialize BLE - then suddenly all 10 ADCs from bank ADC2 stop working but ADCs from 1st bank work as usual. It is crucial to me to have 16 ADCs and BLE to function alltogether. Is there any chance to get them work simultaniously?

Anything new on this topic?

Hi, I have a problem like this one...
When I power up my module i receive valid data from ADC2.
After data was received I start wifi and send them via wifi and going to deep sleep.
After waking up I read permanently 4095 till I trigger an reset...
ULP is also working
PS. Before going to deep sleep I call esp_wifi_stop();

@liuzfesp Hi, would you help share if any updates? Thanks.

In order to fix https://github.com/espressif/arduino-esp32/issues/102#issuecomment-881694700 we would just need a method that allows to reset the ADC2 without having to reset the whole board. Any chance to achieve this, or is it a silicon bug?

The Issue ** still exist until 2021 ** more than 4 year..
today i implemented suggestion from https://github.com/espressif/arduino-esp32/issues/102#issuecomment-611307887  but still did not worked
`
#include <WiFi.h>
#include "soc/sens_reg.h" // needed for manipulating ADC2 control register
uint64_t reg_b; // Used to store ADC2 control register
#define PIN 27 // Substitute xx with your ADC2 Pin number
int value;
int adc2[]={25,26,27,14,12,13,15,2,4};
const char* ssid     = "private";
const char* password = "private";
void setup() {
// Save ADC2 control register value : Do this before begin Wifi/Bluetooth
reg_b = READ_PERI_REG(SENS_SAR_READ_CTRL2_REG);
//Wifi.Begin(); // or similar wifi init function or Bluetooth begin()
WiFi.begin(ssid, password);
while (WiFi.status() != WL_CONNECTED) {
delay(500);
Serial.print(".");
}
Serial.println("");
Serial.println("WiFi connected");
Serial.println("IP address: ");
Serial.println(WiFi.localIP());

}
void loop() {
for(int i=0;i<8;i++)
{
WRITE_PERI_REG(SENS_SAR_READ_CTRL2_REG, reg_b);
SET_PERI_REG_MASK(SENS_SAR_READ_CTRL2_REG, SENS_SAR2_DATA_INV);
value = analogRead(adc2[i]);
Serial.print(adc2[i]);
Serial.print("=");
Serial.print(value);
Serial.print(",");
}
Serial.println("");
delay(500);
}
`


versions: Update CLH to version v0.10.0

We got a new release of cloud-hypervisor earlier today. The latest
release v0.10.0 contains the following updates: 1) virtio-block
Support for Multiple Descriptors; 2) Memory Zones; 3) Seccomp Sandbox
Improvements; 4) Preliminary KVM HyperV Emulation Control; 5) various
bug fixes and refactoring.
Fixes: #2973
Signed-off-by: Bo Chen<EMAIL_ADDRESS>

/test-clh

/test-ubuntu

Failures on  jenkins-ci-podman-clh-fedora-31 and jenkins-metrics-ubuntu-18-04 are known issues. Also, my take for the decreasing on the code coverage is a result of the new client package of CLH HTTP API.

Do this need to be ported to 2.0?

Yes, I will do that fair soon (afer landing this PR and the fix on the CLH CI in kata 2.0 https://github.com/kata-containers/kata-containers/pull/762). Note that we just updated the CLH version to v0.10.0 for kata 2.0 in PR https://github.com/kata-containers/kata-containers/pull/766, but we will need to upgrade the CLH client pkg to make sure the APIs in kata is consistent with the latest CLH API.

The forward-port PR in kata 2.0 is https://github.com/kata-containers/kata-containers/pull/790, and the issue is https://github.com/kata-containers/kata-containers/issues/789.
When the above PR is merged, do I need to do anything else here given the label needs-forward-port? What's the advised practice to track the forward-porting?  Thanks @jodh-intel

@likebreath - although I've raised https://github.com/kata-containers/community/pull/178, that doesn't yet include the process for tracking the ports. I'm currently working on that but the spoiler is - we'll need to add a "magic comment" to the original PR to "find" the ports I'm afraid. GitHub just doesn't provide the sorts of features that a complex project like ours requires ;(

/test-metrics

/test-ubuntu-qemu-metrics

@likebreath - I'm removing the needs-forward-port label since fwics 2.x is using a newer version than 0.10.0 anyway.


upload jar before killing existing topology

if we kill the topology before uploading the jar, the topology stays disabled until the upload is complete. on a slow network, this can lead to the topology being disabled for an unacceptably long time during the deployment. additionally, if the upload fails and deployment crashes, this change will ensure that it did not have a destructive effect on the existing topology.

Thanks for the great simpler PR.


Compiling issue on my fork

So, I manage a slightly modified fork of MacVim, which includes a custom icon and a couple other small tweaks.
I have been pretty diligent about merging in both changes from mainline vim and the MacVim specific stuff from this repo. However, recently I found I can no longer compile MacVim as a get a fairly strange error. Hoping this isn't a rabbit hole of a problem, but wanted to get a quick gut check if there's a quick and easy solution to my particular compiling problem.
The last few lines of compiling output where it errors out:
gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MACVIM -Wall -Wno-unknown-pragmas -pipe  -DMACOS_X_UNIX  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1        version.c -o objects/version.o
 env LD_RUN_PATH=/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE gcc   -L. -L/usr/local/lib -L/Users/amadeus/.rvm/usr/lib  -L. -L/usr/local/lib -L/Users/amadeus/.rvm/usr/lib   -L/usr/local/lib 	-o Vim objects/buffer.o objects/blowfish.o objects/charset.o objects/crypt.o objects/crypt_zip.o objects/diff.o objects/digraph.o objects/edit.o objects/eval.o objects/ex_cmds.o objects/ex_cmds2.o objects/ex_docmd.o objects/ex_eval.o objects/ex_getln.o objects/fileio.o objects/fold.o objects/getchar.o objects/hardcopy.o objects/hashtab.o  objects/if_cscope.o objects/if_xcmdsrv.o objects/mark.o objects/memline.o objects/menu.o objects/message.o objects/misc1.o objects/misc2.o objects/move.o objects/mbyte.o objects/normal.o objects/ops.o objects/option.o objects/os_unix.o objects/pathdef.o objects/popupmnu.o objects/quickfix.o objects/regexp.o objects/screen.o objects/search.o objects/sha256.o objects/spell.o objects/syntax.o  objects/tag.o objects/term.o objects/ui.o objects/undo.o objects/version.o objects/window.o objects/gui.o objects/gui_beval.o objects/pty.o objects/gui_macvim.o objects/MMBackend.o objects/MacVim.o objects/if_lua.o  objects/if_perl.o objects/if_perlsfio.o objects/if_python.o   objects/if_ruby.o objects/os_macosx.o objects/os_mac_conv.o  objects/netbeans.o  objects/main.o objects/memfile.o -framework Cocoa -framework Carbon       -lm -lncurses  -liconv -framework Cocoa  -pagezero_size 10000 -image_base 100000000 -L/usr/local/Cellar/lua/5.1.5/lib -lluajit-5.1 -fstack-protector  -L/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE -lperl -F/usr/local/Cellar/python/2.7.10/Frameworks -framework Python   -lruby-static -lpthread -ldl -lobjc -L/Users/amadeus/.rvm/rubies/ruby-1.9.3-p385/lib
Undefined symbols for architecture x86_64:
  "_server_waiting", referenced from:
      _mch_inchar in os_unix.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [Vim] Error 1
make: *** [first] Error 2

I've pushed a branch where the errors are occuring - https://github.com/amadeus/macvim/tree/macvim-updates-take-three, in case that's helpful.

I already responded it in vim_dev mailing list. https://groups.google.com/d/msg/vim_dev/B5fGebEL9_c/bVDc9lt0AAAJ
As I said in the mail, it was already solved in this repository.

If you looked at the branch I linked, I've cherry-picked in all the changes from this branch. Also, this is a slightly different error than the one in the MacVim thread.


[Ionic v4] Hammer disappeared

Ionic Info
@ionic/angular: "4.0.0-beta.0"
Describe the Bug
There used to be Hammer in package 'ionic-angular/gestures/hammer'. It disappeared.
Expected solution
Put it back or provide guidance about how to migrate in the breaking changes list (should we simply import it ourselves? or should we rely on something else?)

Just saw the following warning msg in my console, don't know exactly why/where etc. but it's probably related to this

core.js:3129 The "swipe" event cannot be bound because Hammer.JS is not loaded and no custom loader has been specified.

So I just gonna let that here because I spent at least 10 hours on the following problem till I figured a solution thx à la v3
I was facing the following problem: Some ion-list and ion-scroll weren't scrollable only on iOS. After a lot of time I finally figured out that these elements were freezing because they weren't contained in an element where I use the (swipe) event
Why it's related to this event? I include hammers in my app because it isn't provided anymore in v4. Turns out in v3, hammerjs was not only provided but was also configured in ionic to handle that problem (reference: https://github.com/angular/angular/issues/10541 and code: https://github.com/ionic-team/ionic/commit/174efc196d7f234e64b1cedc05b49065dd0d2be5#diff-2b61e9589c57aeb2cfa7206751477cfe)
Anyhow to solve this in v4, create a provider like:
 import {Injectable} from '@angular/core';
 import {HammerGestureConfig} from '@angular/platform-browser';

 /**
  * @hidden
  * This class overrides the default Angular gesture config.
  */
 @Injectable()
 export class IonicGestureConfig extends HammerGestureConfig {
     buildHammer(element: HTMLElement) {
         const mc = new (<any> window).Hammer(element);

         for (const eventName in this.overrides) {
             mc.get(eventName).set(this.overrides[eventName]);
         }

         return mc;
     }

 }

and inject it in your app.module.ts
 providers: [
    {provide: HAMMER_GESTURE_CONFIG, useClass: IonicGestureConfig}
 ]

enjoy scroll and swipe on iOS ;)

thanks @peterpeterparker
Ionic team, any confirmation of that?

@peterpeterparker Would you please share a whole code example on using gestures with Ionic/Angular in v4 ? In v3 I was using the Gesture class provided by ionic-angular with three Hammer recognizers. Now I am lost: I can't find any information in the migration guide and I'm scratching my head...

@ptitjes désolé for my late answer, unfortunately I don't use Gesture therefore can't share any code :(

@peterpeterparker Thanks anyway. I finally used Hammer by including it in my main.ts. It seems to add all the events to every elements. I don't know whether this is efficient but that seems to work anyway !

@ptitjes cool 👍
just in case, if you notice that some ion-list or div which would not be scrollable anymore on iOS because you added hammerjs, the tricks above should solves it

@peterpeterparker Yes, thank you ! I integrated it in my code :) (I had not envision the migration to v4 would be so painful... :/)

I must say it's pretty painful indeed; after 48 hours working on migrating my app, I've abandoned; too many APIs missing, too many breaking changes not documented (and too many bugs, but that's understandable for a beta).
on this particular topic, I'd still appreciate a confirmation of the Ionic team about the right way to go. My fear indeed is that, by adding Hammer to the project, every event is captured twice, with a negative impact on performance

Inspired by this solution (https://github.com/angular/material2/issues/2357), it also works in Ionic4 to just include <script src="https://cdnjs.cloudflare.com/ajax/libs/hammer.js/2.0.8/hammer.js"></script> into index.html.
Cannot address @cvaliere 's point with performance issues, but it at least does not feel worse for my app.

@gklasen I would discourage the use of any external JS script in an Ionic application

1st, it's a mobile app, not a website => it's supposed to work offline
2nd, external scripts are loaded asynchronously; while it's not loaded, anything you do with Hammer won't work

if you want to use hammer in your mobile app, add hammer in your node_modules, as any library you use

So do the ionic core team have something to say about this? What path should we follow?
Thanks guys

@giacomocerquone, I don't know what the official stance is on the matter. However, here is how I managed to handle gestures cleanly with @ionic/angular.
You can import hammerjs in your project and use it directly.
import Hammer from 'hammerjs';

@Component({
  // ...
})
export class MyComponentUsingGestures implements OnInit, OnDestroy {

  constructor(private elementRef: ElementRef) {}

  ngOnInit() {
    let element = this.elementRef.nativeElement;
    this._hammer = new Hammer.Manager(element, {
      recognizers: [
        [Hammer.Pan, { direction: Hammer.DIRECTION_VERTICAL }],
        [Hammer.Press],
        [Hammer.Tap],
      ],
    });

    this._hammer.on('pan', this.pan);
    this._hammer.on('press', this.press);
    this._hammer.on('pressup', this.pressup);
    this._hammer.on('tap', this.tap);
  }

  ngOnDestroy() {
    if (this._hammer) {
      this._hammer.off('pan', this.pan);
      this._hammer.off('press', this.press);
      this._hammer.off('pressup', this.pressup);
      this._hammer.off('tap', this.tap);

      this._hammer.destroy();
      this._hammer = null;
    }
  }

  // ...
}

One important thing to notice is that you have to register a custom HammerGestureConfig, as explained by @peterpeterparker in the comment above so that it plays well with Ionic.

Yeah yeah i did the same thing, the point is that without that fix posted above, my app seems to go well with an ion list for example, I couldn't try it on an iPhone though... so I should put it just to stay safe? It feels a little bit wrong

Also I don't use nativelwment that is kinda wrong but viewchild on the div i want to control with hammer, could be that?

I've just got the same warning re. lack of hammerjs when setting a press handler. It seems strange that the framework code knows what it wants, but searching the framework's website shows no related results outside the forum, where there seems to be no official word.

I could make hammer.js work - and also ionic with material.angular.io (in the bottom)
Hammer + ionic:
npm install --save hammerjs
npm install --save @types/hammerjs

package.json
make sure in dependencies there is this line
"hammerjs": "^2.0.8",

tsconfig.json - added types as seen below

"compilerOptions": {
...
...
"types": [
"hammerjs"
]
}

in app.component.ts
import 'hammerjs';
(only there)

in html file

in .ts file
Sample code from hammerjs site works
let element2 = document.getElementById('myElement');
let hamming = new Hammer(element2);
hamming.on("panleft panright tap press pressup", function(ev) {
element2.textContent = ev.type +" gesture detected.";
console.log(ev.type +" gesture detected.");
});
Hammer+ionic+material:
to make material hammer work with ionic
in app.module
import { HAMMER_GESTURE_CONFIG } from '@angular/platform-browser';
import { GestureConfig } from '@angular/material';
providers: [
{ provide: HAMMER_GESTURE_CONFIG, useClass: GestureConfig },
]
and voila, your material slider works.

They introduced also a new GestureController and Gesture in https://github.com/ionic-team/ionic/tree/master/core/src/utils/gesture
Did someone try to get work this in your app? I thinks they intend to export this and we can use a new type of GestureController to do anything we wan't to do.

@mburger81 I may be wrong, but I believe none of that is publicly exported.

Yes but until now there is a breaking change on all hammerjs wrapped events in ionic3, which I think should not be for the final Release.
Also there is an open issue from Mike which should be a remeber to export anything
Also I read many time ago they are happy with the new gesture controller and they would write a post about it.

Any news on this topic ?
I am able to listen to event by importing hammerjs the following way, but impossible to stop the propagation of the event.. any ideas ?
import Hammer from 'hammerjs';

 let element = this.elementRef.nativeElement;
 var hammertime = new Hammer(element);
 hammertime.domEvents = true;
 hammertime.on("press", (e) => {
            e.srcEvent.stopPropagation();
            e.srcEvent.preventDefault();
            e.srcEvent.stopImmediatePropagation();
            // e.gesture.stopPropagation();  // do not exist anymore
            // e.gesture.preventDefault(); // do not exist anymore
});


Scalariform reformats code such that line length is way too long

The results of formatting with Scalariform result in line lengths too long to pass scalastyle checks.  Either the formatting needs to be more intelligent, or if the reformatted line is longer than some reasonable value, then the code is left unchanged to avoid breaking automated scalastyle checkers.
Example:
class CompanyAdapterImpl extends Loggable with ConnectivityAdapter {
this: CompanyAccessor
  with PartnerServiceEnvironmentSettingsComponent
  with DomainActivityAccessor
  with DomainSaleAccessor
  with DomainSupplierConnectivityAccessor
  with DomainDirectConnectAccessor =>

is reformatted to
class CompanyAdapterImpl extends Loggable with ConnectivityAdapter {
this: CompanyAccessor with PartnerServiceEnvironmentSettingsComponent with DomainActivityAccessor with DomainSaleAccessor with DomainSupplierConnectivityAccessor with DomainDirectConnectAccessor =>

This issue was moved to scala-ide/scalariform#157


docs(tutorial/7 - Routing

@eemmosi thnx for this PR. Could you please sign the CLA so we can merge it?

Hi, I already signed the CLA.

OK, thnx, merging.


Add 'T: Send' for 'impl Send for Bucket2'

Closes #2
Thank you for reviewing this PR :crab:

Thanks for the contribution!


[enhancement] Is it possible to not render a gene in the lab block when it is not present in the config file?

Is it possible to not render a gene in the lab block when it is not present in the config file?
Now it is a bit confusing maybe which genes are editable, especially for kids.

The easiest way would be to just use gene numbers which follow each other, like if you have 3 genes, the genes are 0, 1 and 2, not 1, 4 and 7 for example.


Redundant return

Breaking change

Proposed change

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[ ] Local tests pass. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the development checklist
[ ] The code has been formatted using Black (black --fast homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

[ ] No score or internal
[ ] 🥈 Silver
[ ] 🥇 Gold
[ ] 🏆 Platinum

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

Motivate:
What is the issue/code smell?
Redundant Return
Why is this issue/ code smell relevant?
The function will return anyway and without the need for an explicit return statement, a return statement without any values is necessary and the functionality of the code is not affected by removing this statement.
How is the issue resolved?
This can be resolved by removing the return statement at the necessary place.

Ok motivation and explanation. PR has however several issues:

both return and continue (in loops) statements are removed.
PR contains unrelated changes (string literals are replaced by variables)
Many code style violations but also a change that introduces a syntax error (from an unrelated refactoring)


Double injection

Some pages triggers double (or even triple) injection under some circumstances.
Looking through the issues this specific issue concerns at least Youtube (https://github.com/david-sabata/Chrome-Last.fm-Scrobbler/issues/262), Soundcloud (https://github.com/david-sabata/Chrome-Last.fm-Scrobbler/issues/286#issuecomment-36185247), Pitchfork (https://github.com/david-sabata/Chrome-Last.fm-Scrobbler/issues/337), Google Music (https://github.com/david-sabata/Chrome-Last.fm-Scrobbler/issues/286) and Pandora (https://github.com/david-sabata/Chrome-Last.fm-Scrobbler/issues/278).
I'm not sure what causes the problem but I know Soundcloud triggers DOM ready twice (and probably "unload" too) and the mechanism provided (https://github.com/david-sabata/Chrome-Last.fm-Scrobbler/issues/278#issuecomment-33730917) to detect whether the content script is loaded is not able to respond quickly enough.
When loading a new tab with a soundcloud page the script seems to work fine, but when you hit reload the console of the background script looks like this:

This is tested with version 1.33 and clearly indicates that the content script is loaded twice - due to missing response from the "ping" message.
I hope @david-sabata have some ideas concerning this issue. In any way I'd love to get some ideas on the table. :-)

We could probably close this now. It's almost 3 years old.

We could probably close this now. It's almost 3 years old.

Is this issue resolved? I didn't notice multiple injection, except the case I described in #1175.


Grid Component: How to Invoke DataProvider from my own method?

I'm filling the Grid with Time Sheet records from back-end API based on specified Date Range, for example June 1, 2023 to June 15, 2023 . Note: I set AllowPaging="false". Based on my own observation, DataProvider method is being invoked on initial loading of Grid. Let's say I want to get again another set of Time Sheet records with different date range for example June 16, 2023 to June 29, 2023, how can I invoke the Data Provider method from my own Search Button during onclick event? Note: I also set AllowFiltering="false".

Thanks @gvreddy04 .


Missing pkg-config

reported by @drosofff in https://github.com/galaxyproject/tools-iuc/issues/407#issuecomment-158272388

Added via PR #6.


Add smc.py script to enable radios

Add a basic SMC client and a script in experiments/ using it to enable
the radios. Running this before booting Linux will make the network
controller devices show up in lspci, even if Linux lacks an SMC driver.
Signed-off-by: Alyssa Rosenzweig<EMAIL_ADDRESS>

The use case is to investigate the Wi-Fi situation without sorting out SMC GPIO on the Linux side and wiring that into the PCIe probe path and ... doing that properly is nontrivial, and doing it with hacks would muck up the kernel tree too much. So just add a script to do it in m1n1 for now.


Change lookup init to use static arrays

When investigating performance/crashing issues with En-ROADS on iPad, I discovered that a large part of the memory pressure is coming from the way the lookup initialization code gets compiled down to wasm.
The current approach passes a list of (x,y) pairs as varargs to __new_lookup, which then copies them into a freshly malloc'd array in the Lookup.  Something about the way Emscripten handles the varargs seems to cause higher memory usage when the module is loaded and also increases the on-disk size of the wasm file.
An example init line currently looks like this:
__lookup1 = __new_lookup(111, 1990.0, 7.53332, 1991.0, 7.7605, 1993.0, 8.15487, ..., 2100.0, 0.550535);

Some rough baseline performance stats from my ancient (2013) iPad Air:
wasm on disk size: 1084036 bytes
init time: 28267 ms
memory use after init: 45 MB (JS) / 253 MB (page)
memory use after running model: 45 MB (JS) / 450 MB (page)

(The memory usage stats here and below are fuzzy, representing the rough max values reported using Safari developer tools.)
I tried a couple alternatives:

Make __new_lookup take an explicit double *, then pass a literal array, for example:

__lookup1 = __new_lookup(111, (double[]){ 1990.0, 7.53332, 1991.0, 7.7605, 1993.0, 8.15487, ..., 2100.0, 0.550535 });

This made a big improvement:
wasm on disk size: 775426 bytes
init time: 4469 ms
memory use after init: 81 MB (JS) / 124 MB (page)

Make __new_lookup take an explicit double *, then pass a static array declared earlier, for example:

const double __lookup1_data[222] = { 1990.0, 7.53332, 1991.0, 7.7605, 1993.0, 8.15487, ..., 2100.0, 0.550535 };
...
__lookup1 = __new_lookup(111, /*copy=*/false, __lookup1_data);

This made another big dent:
wasm on disk size: 773968 bytes
init time: 4046 ms
memory use after init: 64 MB (JS) / 103 MB (page)

Here are some performance stats for this change.  Additional improvements will come in #19.
Performance
MacBook Pro (2019) | 2.4 GHz 8-core i9, 32 GB RAM, macOS 10.15

Issue
C run (ms)
Wasm run (ms)
Wasm init (ms)
JS mem (MB)
Page mem (MB)

baseline
45.8
87.5
38.0
94
685

SDE 18
46.0
85.6
18.0
39
672

iPhone 8 | A11, iOS 13

Issue
C run (ms)
Wasm run (ms)
Wasm init (ms)
JS mem (MB)
Page mem (MB)

baseline
39.9
187.0
165.0
39
645

SDE 18
40.3
219.0
86.0
38
724

iPad Air (2013) | A7, iOS 12

Issue
C run (ms)
Wasm run (ms)
Wasm init (ms)
JS mem (MB)
Page mem (MB)

baseline
151.0
1372.2
30146.0
77
331

SDE 18
166.0
1408.0
4416.0
42
395

Size

Issue
Wasm size (bytes)

baseline
1,084,036

SDE 18
773,968

Merged to develop in 3c6c0a4.


grid containers may need a clearfix

When implementing the task-list pattern I needed to use govuk-clearfix to stop the page from collapsing:

grid-row has a clearfix https://github.com/alphagov/govuk-frontend/blob/master/src/helpers/_grid.scss#L50
you just used the wrong class :) grid-grid-row

Thanks Jani


Update Herbalist Dedication batch size to match PC2

Changed Herbalist Dedication batch size to 1 in order to better match PC2 while we wait for the Alchemist UI update

Hi, can you explain the rationale behind this change?

Alright, we figured it out, had to actually go read the new crafting rules :D  Thanks for making your first contribution!

Sorry for the confusion, this was my first Pull Request. I'll try to explain better in the future


How to load large embedding efficiently?

Describe the Question
I tried to load 840B+300d GloVe using mz.embedding.load_from_file. However, it utilizes more than 60+ GB memory, which looks abnormal.
from pathlib import Path
import matchzoo as mz

_glove_6B_embedding_url = "http://nlp.stanford.edu/data/glove.6B.zip"
_glove_840B_embedding_url = "http://nlp.stanford.edu/data/glove.840B.300d.zip"

def load_glove_embedding(dimension: int = 50, size="6B") -> mz.embedding.Embedding:
    """
    Return the pretrained glove embedding.

    :param dimension: the size of embedding dimension, the value can only be
        50, 100, or 300.
    :return: The :class:`mz.embedding.Embedding` object.
    """
    file_name = 'glove.{}.{}d.txt'.format(size, dimension)
    file_path = (Path(mz.USER_DATA_DIR) / 'glove').joinpath(file_name)

    if not file_path.exists():
        if size=="6B":
            url = _glove_6B_embedding_url
        elif size == "840B":
            url = _glove_840B_embedding_url
        else:
            raise ValueError("Incorrect Size for GloVe: %d" % size)

        mz.utils.get_file('glove_embedding',
                                        url,
                                        extract=True,
                                        cache_dir=mz.USER_DATA_DIR,
                                        cache_subdir='glove')

    return mz.embedding.load_from_file(file_path=str(file_path), mode='glove')

embedding = load_glove_embedding(300, "840B")

Describe your attempts
The TF version matchzoo uses pandas to read the GloVe file, and requires much less memory.

Thanks for your feedback. We will fix it soon.


Fix local connector filter

This added filter on properties for local connector.
Resolve  #22

Let me just fix tests. :)


feature: support port reuse mode

support port reuse mode
Resolves: #5

The commit message is not correct


Add support for 3rd party menu

Hello, please add 3rd party menu support for bots selection csdm weapons, because i have selected csdm mode and they not choosing weapons still play with knifes, also jason mode disabled

Hi. I didn't quite understand what did you want. What mod do you use, other plugins, what is expected behaviour, what is not.
As for mods, Vanilla CSDM working fine with bots. I don't know what mod do you use. But before you're ask, i will not add dedicated support for any third party mods other than Alliedmods CSDM. Bot (not only yapb) support should be added by their authors.

I am not using any mod, it's simple settings for deatmatch in regamedll and 3rd party weapon menu plugin that's all and bots are not selecting weapons from that menu

I am not using any mod, it's simple settings for deatmatch in regamedll and 3rd party weapon menu plugin that's all and bots are not selecting weapons from that menu

you should add support for boys for that third-party  weapon menu plugin


Update Jackson to 2.12.5

Signed-off-by: Andriy Redko<EMAIL_ADDRESS>Description
Although there are no CVEs reported against 2.11.4, the 2.11.x release branch is not actively maintained anymore (the last release was in December, 2020). As per [1], 2.12.x should be backward compatible with 2.11.x, with no breaking changes expected.
[1] https://github.com/FasterXML/jackson/wiki/Jackson-Releases#general
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

start gradle check

Thanks @nknize !

Thank you @saratvemulapalli !

@dblock @nknize any concerns you have guys? Thank you!

Let’s back port it to 1.x?

@dblock sure, will do it shortly, thank you!


Feature/reward bet bonus

Description

Type of change
Please check the options that are relevant. This PR introduces

[ ] Patch: Bug fix (non-breaking change which fixes an existing issue)
[ ] Minor: New feature (non-breaking change which adds new functionality)
[ ] Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Features Description

[ ] NA

Test Cases

[ ] NA

Documentation

Checklist:

[ ] I have added change type (major|minor|patch) in the PR
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Codecov Report
Attention: Patch coverage is 5.59126% with 1469 lines in your changes are missing coverage. Please review.

Project coverage is 11.43%. Comparing base (925e726) to head (70b9687).
Report is 19 commits behind head on feature/upgrade-go.

Files
Patch %
Lines

x/reward/types/promoter.pb.go
0.79%
623 Missing :warning:

x/reward/types/tx.pb.go
0.75%
264 Missing :warning:

x/reward/types/ticket.pb.go
0.75%
262 Missing :warning:

x/reward/types/genesis.pb.go
0.00%
76 Missing :warning:

x/reward/types/query.pb.go
0.00%
70 Missing :warning:

x/reward/types/reward_bet_bonus.go
0.00%
44 Missing :warning:

x/reward/types/query.pb.gw.go
0.00%
24 Missing :warning:

x/reward/types/campaign.pb.go
0.00%
23 Missing :warning:

x/reward/types/messages_promoter.go
29.62%
19 Missing :warning:

x/reward/types/campaign.go
0.00%
13 Missing :warning:

... and 10 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/upgrade-go     #361      +/-   ##
======================================================
- Coverage               11.73%   11.43%   -0.30%
======================================================
  Files                     351      357       +6
  Lines                   45066    47089    +2023
======================================================
+ Hits                     5287     5384      +97
- Misses                  39298    41217    +1919
- Partials                  481      488       +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[fatal][tid:main] Unable to execute JS call: __fbBatchedBridge is undefined

Whenever I try to create a offline bundle with the directions given I get the error:
[fatal][tid:main] Unable to execute JS call: __fbBatchedBridge is undefined
I tried different solutions using https://github.com/facebook/react-native/issues/5770 but currently I'm stuck.
I don't know if this is related to the starter kit or not, so any tips/hints/pointers to rule out the starter kit and the way it packages would be helpful.

@E-P1983 Thanks for the report and sorry for your troubles. I was able to replicate with kit version v2.29.0 and also tried a few of the suggestions in the linked open issue, including:

Hacking the react-native.xcode.sh bash script
Setting the Scheme to Release mode

Unfortunately, I was not able to get past the error and can't afford much time right now to address it. Because this kit was developed before RN had as much tooling baked into the core the plates shifting underneath have caused similar types of issues in the past.
Until this is fixed my suggestion would be to use the react-native-cli to init a new project and see if you can reproduce the issue. That'll help identify if it's a kit issue or RN. I'll keep this issue open until we can learn more. Thanks for your help.

Here's what finally worked for me.
I saw a suggestion to reinstall watchman. I had installed that with brew, so I did "brew reinstall watchman"
When that completed, I restarted the computer.
After that, things worked!
I don't know if that will fix it for everyone, but its worth a shot.

Thanks for the update, @egauci. Glad you got it working! There's no doubt this will come in handy for someone. :) Cheers


Added Egg Dropping Problem

Added the C++ code for egg dropping problem
Issue no. - #339 resolved

This issue is not assigned to you!


Lint against imported lowercase components

If you import something lowercase from a package and then use it in JSX we can be confident you didn't mean a web component.
We should warn in this case. This should probably be a rule in eslint-plugin-react.

I'd love to take a stab at this. @gaearon do you know if it's easy to get eslint-plugin-react maintainers to accept new rules into the repo?
Also by 'something lowercase' do you mean completely lowercase or starting with a lowercase letter? React docs are a little bit unclear in this, saying you can start the tag with a capital letter to indicate a React component, but on the other hand use 'lower-case tag names' for DOM elements. It's not clear how camelCase would be treated for instance.

Actually, does this help? https://github.com/yannickcr/eslint-plugin-react/blob/master/lib/rules/jsx-pascal-case.js

Hmm, not sure. Here’s what prompted me to create this issue. The code looks like this:
import React, { Component } from 'react';
import './App.css';

class App extends Component {
  render() {
    return <lol />;
  }
}

class lol extends Component {
  render() {
    return
lol
;
  }
}

export default App;

That rule doesn’t catch it.

To be clear, <lol /> is valid React. It means “use a Web Component called lol”. But this is a super rare use case, and 99% times people don’t mean to use Web Components; they expect their classes to work.
What I propose: if lol exists in the scope, it is very likely the user didn’t mean a web component, and meant lol React component instead. We should warn in this case.

Also by 'something lowercase' do you mean completely lowercase or starting with a lowercase letter?

Anything starting with a lowercase letter. So camelCase will also work super confusingly.

https://github.com/yannickcr/eslint-plugin-react/issues/726

Beware, there are components like "i" that are likely going to be in scope

Oh, good catch. This rule should have a good HTML tag whitelist I think, then it would be relatively safe.

Updated the proposal.

I think HTML tag whitelist it a way to solve it. But takes some regex in webpack plugin is a good solution?

Pretty sure we want to solve it in the linter, not as a webpack plugin.

Custom elements must contain a hyphen - in the name so <lol /> is invalid*  both in React and Web Components world.
[*] inherits from HTMLUnknownElement

ha. Obviously I didn't read yannickcr/eslint-plugin-react#726 – sorry about that :)

Closing as I don't feel strongly about this.

I know this issue is closed, but I'm running into errors when I import a React component that starts with an underscore.
Shouldn't that be allowed syntax as React component?


Efficientnet_v2 features name

Hi all,
I was going through efficientnet_v2 model available in keras, but I'm unable to identify the features {P3, P4, P5, P6, P7}.

Hi @anshkumar,
import tensorflow as tf
IMG_SHAPE = (224, 224, 3)
inp = tf.keras.layers.Input(shape=IMG_SHAPE)
base = tf.keras.applications.efficientnet_v2.EfficientNetV2L(input_shape=IMG_SHAPE,weights='imagenet',include_top=False)
x = base(inp)
x = tf.keras.layers.GlobalAveragePooling2D()(x)
x = tf.keras.layers.Dense(1,activation='sigmoid')(x)
model = tf.keras.Model(inputs=inp,outputs=x)
opt = tf.keras.optimizers.Adam(learning_rate=0.001)
print(model.summary())

Output
Model: "model_1"
_________________________________________________________________
 Layer (type)                Output Shape              Param #
=================================================================
 input_5 (InputLayer)        [(None, 224, 224, 3)]     0

 efficientnetv2-l (Functiona  (None, 7, 7, 1280)       117746848
 l)

 global_average_pooling2d_1   (None, 1280)             0
 (GlobalAveragePooling2D)

 dense_1 (Dense)             (None, 1)                 1281

=================================================================
Total params: 117,748,129
Trainable params: 117,235,553
Non-trainable params: 512,576
_________________________________________________________________
None

@gadagashwini I want the name of tensors which represents features P3, P4,P5 etc. Like in Resnet50 they are ['conv3_block4_out', 'conv4_block6_out', 'conv5_block3_out'].

@anshkumar Linking this discussion thread . Can you please close this issue as it is already being discussed. Thanks!


feat: update to eye v3.7.0

feat: update to eye v3.7.0

:tada: This PR is included in version 4.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v4.7.0

Your semantic-release bot :package::rocket:


I see the fitnets for reference

Did you use the fitnets for kd the model?
Fitnets: Hints for thin deep nets

Did you use the fitnets for kd the model?
Fitnets: Hints for thin deep nets

I cited Fitnets in my report because it was a related, but my exploration (and this repo) was mainly focused on deep-shallow knowledge distillation characteristics, and the actual implementation of KD function generally followed Hinton's classical paper on KD. Hope this clarifies things for you :)

Did you use the fitnets for kd the model?
Fitnets: Hints for thin deep nets

Can you find a fitnet implementation?


Add topics to GitHub

See https://github.com/blog/2309-introducing-topics.
Looks like only the owner can do that
It should have Rust and formater/fmt or something like those

Added rust, rustfmt, formatter and codeformatter.

perfekt!
thanks :heart:


Null and singletons cause inconsistencies

Compiler version
3.1.1, 3.1.2
Example 1:
Transitivity of subtyping is violated:
val fredToFredOrWilma: "Fred" <:< ("Fred" | "Wilma") = summon

val nullToFred: Null <:< "Fred" = summon

val nullToFredOrWilma: Null <:< ("Fred" | "Wilma") = summon // errors

Output
no implicit argument of type T was found for parameter x of method summon in object Predef

where:    T is a type variable with constraint <: Null <:< (("Fred" : String) | ("Wilma" : String))

Expectation
Either:

nullToFred fails
<:< is transitive and Null <:< "Fred" <:< ("Fred" | "Wilma")

Example 2:
scala> val x: "Fred" = null
val x: "Fred" = null
scala> x
val res1: String = Fred // notice this is not `null`!

Expectation
Either:

null is not assignable to a "Fred"
x reports a value of null

Example 3:
Null is accepted for variable .types but not object .types (which are both nullable in the JVM):
scala> val foo: Int = 1
val foo: Int = 1

scala> val fooNull: foo.type = null
-- [E007] Type Mismatch Error: -------------------------------------------------
1 |val fooNull: foo.type = null
  |                        ^^^^
  |                        Found:    Null
  |                        Required: (foo : Int)

longer explanation available when compiling with `-explain`
1 error found

scala> val bar: String = "bar"
val bar: String = bar

scala> val barNull: bar.type = null
val barNull: bar.type = null

scala> object baz
// defined object baz

scala> val bazNull: baz.type = null
-- [E007] Type Mismatch Error: -------------------------------------------------
1 |val bazNull: baz.type = null
  |                        ^^^^
  |                        Found:    Null
  |                        Required: baz.type

longer explanation available when compiling with `-explain`
1 error found

Expectation
Either:

null should not be accepted as an inhabitant of bar.type
null should be accepted as an inhabitant of baz.type

Example 4:
Unions of two singletons don't accept null, but not a union of a singleton and a non-nullable:
scala> val f: "Foo" = null
val f: "Foo" = null

scala> val g: ("Foo" | 1) = null
-- [E007] Type Mismatch Error: -------------------------------------------------
1 |val g: ("Foo" | 1) = null
  |                     ^^^^
  |                     Found:    Null
  |                     Required: ("Foo" : String) | (1 : Int)

longer explanation available when compiling with `-explain`
1 error found

scala> val h: ("Foo" | Int) = null
val h: "Foo" | Int = null

scala> val i: ("Foo" | "Bar") = null
-- [E007] Type Mismatch Error: -------------------------------------------------
1 |val i: ("Foo" | "Bar") = null
  |                         ^^^^
  |                         Found:    Null
  |                         Required: ("Foo" : String) | ("Bar" : String)

longer explanation available when compiling with `-explain`
1 error found

Expectation
Either:

The declarations for f and h are invalid
The declarations for g and i are valid

If Scala 2 behaviors are wanted to be kept, then the proper path is taking the (2.) options.
However, if (2.) is taken, it means that any AnyRef & Singleton will actually have two values, not one.

I just want to add another inconsistency related to the conversion from null to a string singleton type:
scala> def f(a: "A"): a.type = a
def f(a: "A"): a.type

scala> f(null)
java.lang.ClassCastException: class java.lang.String cannot be cast to class scala.runtime.Null$ (java.lang.String is in module java.base of loader 'bootstrap'; scala.runtime.Null$ is in unnamed module of loader java.net.URLClassLoader @3c1e23ff)
  ... 31 elided

To me it seems that (null: "A") should simply not be valid to make string singleton types consistent with all other singleton types.

I checked that with -Yexplicit-nulls, options (1.) are taken in all the examples.
Perhaps we could take options (2.) always without -Yexplicit-nulls for compatibility with Scala 2, and require -Yexplicit-nulls for options (1.) (i.e. for null-correctness).

Related discussion in https://github.com/lampepfl/dotty/issues/3958

As of 3.5.2:

option (1) is taken in Example 1: Null <:< "Fred" does not hold
option (1) is taken in Example 2: null: "Fred" is invalid
option (2) is taken in Example 3: null: someString.type and null: SomeObject.type both hold
option (1) is taken in Example 4: null: "Foo and null: ("Foo" | Int) are both invalid

All of these are consistent individually now, but Example 3 is inconsistent with the others.

x.type is null able by (broken) spec.
The spec and the behavior were adjusted under explicit nulls.


[10x] Remove return on void callback

Just a minor fix:
Facade::clearResolvedInstances() is a void function, so it does not make sense to returns it's value 😀.

Facade::clearResolvedInstances():

It's fine.


chore: prep for move to procore-oss github organization

[x] Set default/lowest version to node 18 LTS ends in a year
[x] setup .github folder (actions, dependabot.yaml, ISSUE_TEMPLATES, PULL_REQUEST_TEMPLATE.md, CODEOWNERS)
[x] remove circleci, replace with github actions
[x] setup required files (README.md, SECURITY.md, CODE_OF_CONDUCT.md, LICENSE.md, CONTRIBUTING.md)
[x] update npm information
[x] verify no procore specific stuff present
[x] README markdown linting fixes

Plan:

merge this PR once approved
I put in CSEIN ticket to move repo to github.com/procore-oss organization
I setup new NPM_TOKEN and prep release
increase version and do release to procore/js-sdk npm package


⚠ LabBricks has degraded performance

In ecfbc47, LabBricks (https://labbricks.com) experienced degraded performance:

HTTP code: 523
Response time: 3189 ms

Resolved: LabBricks performance has improved in 4fc8bd7 after 33 minutes.


Export the mode using tf.saved_model and deploy it to production environment

Sorry to bother.
When I'm trying to export the model using tf.saved_model to deploy it to a production environment (tf serving in docker), there are some problems.
The exported graph format requires pure inputs and outputs signature, but in our model,the agent needs to interact with an environment. But all of the codes are written in numpy rather than tensorflow except the agent.py. So if I export the agent only(maybe failed), how the agent interacts with the environment?
My idea: rewrite the environment in TF... but this is going to be a lot of work.
Thanks in advance.

Already done! And I've upgraded the VPG to PPO!


How to fix an error which is Emulator: glTexImage2D: got err pre :( 0x501 internal 0x1908 format 0x1908 type 0x140? I'm trying OCR in Flutter

Steps to Reproduce

Run flutter create bug.
All done!
[√] Flutter: is fully installed. (Channel stable, 1.22.6, on Microsoft Windows [Version 10.0.18363.1316], locale en-US)
[!] Android toolchain - develop for Android devices: is partially installed; more components are available. (Android SDK
version 30.0.2)
[√] Android Studio: is fully installed. (version 4.0)
[!] VS Code: is partially installed; more components are available. (version 1.50.1)
[√] Connected device: is fully installed. (1 available)

Run "flutter doctor" for information about installing additional components.
In order to run your application, type:
$ cd bug
$ flutter run
Your application code is in bug\lib\main.dart.

Update the files as follows: ...

...
I'm trying OCR in Flutter. But I always get an error which is "Emulator: glTexImage2D: got err pre :( 0x501 internal 0x1908 format 0x1908 type 0x140."
It opens the camera when I run a code, but It doesn't scan characters.

Expected results:
Scan characters and output characters.
Actual results:
It opens the camera when I run a code, but It doesn't scan characters.

Logs

[ +119 ms] executing: [C:\src\flutter_windows_1.20.3-stable\flutter/] git -c log.showSignature=false log -n 1
--pretty=format:%H
[  +82 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +1 ms] 9b2d32b605630f28625709ebd9d78ab3016b2bf6
[   +1 ms] executing: [C:\src\flutter_windows_1.20.3-stable\flutter/] git tag --points-at HEAD
[  +69 ms] Exit code 0 from: git tag --points-at HEAD
[   +1 ms] 1.22.6
[  +10 ms] executing: [C:\src\flutter_windows_1.20.3-stable\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +56 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[   +1 ms] origin/stable
[   +4 ms] executing: [C:\src\flutter_windows_1.20.3-stable\flutter/] git ls-remote --get-url origin
[  +57 ms] Exit code 0 from: git ls-remote --get-url origin
[   +1 ms] https://github.com/flutter/flutter.git
[ +100 ms] executing: [C:\src\flutter_windows_1.20.3-stable\flutter/] git rev-parse --abbrev-ref HEAD
[  +56 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[   +2 ms] stable
[  +66 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +4 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +22 ms] executing: C:\Users\sakai017\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l
[  +58 ms] List of devices attached
emulator-5554          device product:sdk_gphone_x86 model:Android_SDK_built_for_x86 device:generic_x86
transport_id:1
[   +9 ms] C:\Users\sakai017\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell getprop
[  +58 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[   +5 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +32 ms] "flutter run" took 226ms.
[  +20 ms] Error: No pubspec.yaml file found.
This command should be run from the root of your Flutter project.
Do not run this command from the root of your git clone of Flutter.
[   +5 ms]
#0      FlutterCommand.validateCommand (package:flutter_tools/src/runner/flutter_command.dart:1074:11)
#1      RunCommand.validateCommand (package:flutter_tools/src/commands/run.dart:348:19)
#2      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:933:11)

#3      FlutterCommand.run. (package:flutter_tools/src/runner/flutter_command.dart:836:33)
#4      FlutterCommand.run. (package:flutter_tools/src/runner/flutter_command.dart)
#5      AppContext.run. (package:flutter_tools/src/base/context.dart:150:29)
#6      _rootRun (dart:async/zone.dart:1190:13)
#7      _CustomZone.run (dart:async/zone.dart:1093:19)
#8      _runZoned (dart:async/zone.dart:1630:10)
#9      runZoned (dart:async/zone.dart:1550:10)
#10     AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#11     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:825:20)
#12     CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#13     FlutterCommandRunner.runCommand.
(package:flutter_tools/src/runner/flutter_command_runner.dart:335:21)
#14     _rootRunUnary (dart:async/zone.dart:1198:47)
#15     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#16     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#17     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#18     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#19     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#20     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#21     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)
#22     FlutterVersion.checkFlutterVersionFreshness (package:flutter_tools/src/version.dart)
#23     _rootRunUnary (dart:async/zone.dart:1198:47)
#24     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#25     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#26     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#27     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#28     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#29     Future._asyncCompleteWithValue. (dart:async/future_impl.dart:567:7)
#30     _rootRun (dart:async/zone.dart:1190:13)
#31     _CustomZone.run (dart:async/zone.dart:1093:19)
#32     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
#33     _CustomZone.bindCallbackGuarded. (dart:async/zone.dart:1037:23)
#34     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#35     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#36     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#37     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)
[ +238 ms] ensureAnalyticsSent: 233ms
[   +3 ms] Running shutdown hooks
[   +1 ms] Shutdown hooks complete
[   +2 ms] exiting with code 1

info - The value of the field '_widgetOptions' isn't used - AndroidStudioProjects\meal_flutter_app\lib\calendarDraft.dart:13:15 - unused_field
info - The value of the field '_counter' isn't used - AndroidStudioProjects\meal_flutter_app\lib\calendarDraft.dart:31:7 - unused_field
warning - The parameter 'onPressed' is required - AndroidStudioProjects\meal_flutter_app\lib\calendarDraft.dart:50:11 - missing_required_param
info - 'title' is deprecated and shouldn't be used. Use "label" instead, as it allows for an improved text-scaling experience. This feature was deprecated after v1.19.0.
- AndroidStudioProjects\meal_flutter_app\lib\calendarDraft.dart:97:15 - deprecated_member_use
info - 'title' is deprecated and shouldn't be used. Use "label" instead, as it allows for an improved text-scaling experience. This feature was deprecated after v1.19.0.
- AndroidStudioProjects\meal_flutter_app\lib\calendarDraft.dart:100:15 - deprecated_member_use
info - 'title' is deprecated and shouldn't be used. Use "label" instead, as it allows for an improved text-scaling experience. This feature was deprecated after v1.19.0.
- AndroidStudioProjects\meal_flutter_app\lib\calendarDraft.dart:103:15 - deprecated_member_use
info - Unused import: 'package:table_calendar/table_calendar.dart' - AndroidStudioProjects\meal_flutter_app\lib\mealPlan.dart:2:8 - unused_import
info - Unused import: 'package:meal_flutter_app/shopping.dart' - AndroidStudioProjects\meal_flutter_app\lib\mealPlan.dart:3:8 - unused_import
info - Name types using UpperCamelCase - AndroidStudioProjects\meal_flutter_app\lib\mealPlan.dart:5:7 - camel_case_types
info - 'title' is deprecated and shouldn't be used. Use "label" instead, as it allows for an improved text-scaling experience. This feature was deprecated after v1.19.0.
- AndroidStudioProjects\meal_flutter_app\lib\nav.dart:44:15 - deprecated_member_use
info - 'title' is deprecated and shouldn't be used. Use "label" instead, as it allows for an improved text-scaling experience. This feature was deprecated after v1.19.0.
- AndroidStudioProjects\meal_flutter_app\lib\nav.dart:47:15 - deprecated_member_use
info - 'title' is deprecated and shouldn't be used. Use "label" instead, as it allows for an improved text-scaling experience. This feature was deprecated after v1.19.0.
- AndroidStudioProjects\meal_flutter_app\lib\nav.dart:50:15 - deprecated_member_use
info - 'title' is deprecated and shouldn't be used. Use "label" instead, as it allows for an improved text-scaling experience. This feature was deprecated after v1.19.0.
- AndroidStudioProjects\meal_flutter_app\lib\nav.dart:53:15 - deprecated_member_use
info - 'title' is deprecated and shouldn't be used. Use "label" instead, as it allows for an improved text-scaling experience. This feature was deprecated after v1.19.0.
- AndroidStudioProjects\meal_flutter_app\lib\navBackup.dart:38:15 - deprecated_member_use
info - 'title' is deprecated and shouldn't be used. Use "label" instead, as it allows for an improved text-scaling experience. This feature was deprecated after v1.19.0.
- AndroidStudioProjects\meal_flutter_app\lib\navBackup.dart:41:15 - deprecated_member_use
info - 'title' is deprecated and shouldn't be used. Use "label" instead, as it allows for an improved text-scaling experience. This feature was deprecated after v1.19.0.
- AndroidStudioProjects\meal_flutter_app\lib\navBackup.dart:44:15 - deprecated_member_use
info - Unused import: 'package:meal_flutter_app/nav.dart' - AndroidStudioProjects\meal_flutter_app\lib\recipeBackup.dart:2:8 - unused_import
info - Name types using UpperCamelCase - AndroidStudioProjects\meal_flutter_app\lib\recipeBackup.dart:16:7 - camel_case_types
info - Name types using UpperCamelCase - AndroidStudioProjects\meal_flutter_app\lib\recipeBackup.dart:21:7 - camel_case_types
info - Unused import: 'package:meal_flutter_app/nav.dart' - AndroidStudioProjects\meal_flutter_app\lib\recipes.dart:2:8 - unused_import
info - Name types using UpperCamelCase - AndroidStudioProjects\meal_flutter_app\lib\recipes.dart:17:7 - camel_case_types
info - Name types using UpperCamelCase - AndroidStudioProjects\meal_flutter_app\lib\recipes.dart:22:7 - camel_case_types
info - Unused import: 'package:meal_flutter_app/nav.dart' - AndroidStudioProjects\meal_flutter_app\lib\shopping.dart:2:8 - unused_import
info - This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: Shopping.listTiles -
AndroidStudioProjects\meal_flutter_app\lib\shopping.dart:4:7 - must_be_immutable
info - Unused import: 'package:meal_flutter_app/nav.dart' - AndroidStudioProjects\meal_flutter_app\lib\shoppingBackup.dart:2:8 - unused_import
info - This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: Shopping.listTiles -
AndroidStudioProjects\meal_flutter_app\lib\shoppingBackup.dart:4:7 - must_be_immutable
info - Unused import: 'package:flutter/rendering.dart' - AndroidStudioProjects\meal_flutter_app\lib\store.dart:2:8 - unused_import
info - Unused import: 'package:meal_flutter_app/nav.dart' - AndroidStudioProjects\meal_flutter_app\lib\stors.dart:3:8 - unused_import
info - Unused import: 'package:meal_flutter_app/nav.dart' - AndroidStudioProjects\meal_flutter_app\lib\storsBackup.dart:2:8 - unused_import
info - Unused import: 'package:meal_flutter_app/nav.dart' - AndroidStudioProjects\meal_flutter_app\lib\storsDraft.dart:2:8 - unused_import
info - Unused import: 'dart:async' - AndroidStudioProjects\meal_flutter_app\lib\storsDraft.dart:3:8 - unused_import
31 issues found. (ran in 56.7s)

[√] Flutter (Channel stable, 1.22.6, on Microsoft Windows [Version 10.0.18363.1316], locale en-US)
• Flutter version 1.22.6 at C:\src\flutter_windows_1.20.3-stable\flutter
• Framework revision 9b2d32b605 (3 weeks ago), 2021-01-22 14:36:39 -0800
• Engine revision 2f0af37152
• Dart version 2.10.5
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at C:\Users\sakai017\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.2
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[√] Android Studio (version 4.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 50.0.1
• Dart plugin version 193.7547
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[!] VS Code (version 1.50.1)
• VS Code at C:\Users\sakai017\AppData\Local\Programs\Microsoft VS Code
X Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[√] Connected device (1 available)
• Android SDK built for x86 (mobile) • emulator-5554 • android-x86 • Android 8.1.0 (API 27) (emulator)
! Doctor found issues in 2 categories.

Hi @RenaSki
Can you please provide your flutter run --verbose (make sure you run this inside of your project directory) and a minimal complete reproducible code sample that does not uses any third-party plugin/package?
Thank you

Hi @RenaSki
Can you please provide your flutter run --verbose (make sure you run this inside of your project directory) and a minimal complete reproducible code sample that does not uses any third-party plugin/package?
Thank you

Hello pedromassangocode,
Can you please provide your flutter run --verbose (make sure you run this inside of your project directory) :
The result of 'flutter run --verbose' below⬇
[ +183 ms] executing: [C:\src\flutter_windows_1.20.3-stable\flutter/] git -c log.showSignature=false log -n 1
--pretty=format:%H
[ +138 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +1 ms] 9b2d32b605630f28625709ebd9d78ab3016b2bf6
[   +1 ms] executing: [C:\src\flutter_windows_1.20.3-stable\flutter/] git tag --points-at HEAD
[ +135 ms] Exit code 0 from: git tag --points-at HEAD
[   +1 ms] 1.22.6
[  +19 ms] executing: [C:\src\flutter_windows_1.20.3-stable\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[ +103 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[   +1 ms] origin/stable
[   +1 ms] executing: [C:\src\flutter_windows_1.20.3-stable\flutter/] git ls-remote --get-url origin
[  +90 ms] Exit code 0 from: git ls-remote --get-url origin
[   +1 ms] https://github.com/flutter/flutter.git
[ +137 ms] executing: [C:\src\flutter_windows_1.20.3-stable\flutter/] git rev-parse --abbrev-ref HEAD
[  +97 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[   +1 ms] stable
[ +120 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +5 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[   +3 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[   +8 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[   +5 ms] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[  +10 ms] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +41 ms] executing: C:\Users\sakai017\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l
[ +109 ms] List of devices attached
[  +11 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[   +1 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[   +3 ms] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +5 ms] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[   +3 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[   +6 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[   +4 ms] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[   +5 ms] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[   +9 ms] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[   +3 ms] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[   +7 ms] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[  +26 ms] "flutter run" took 332ms.
[  +24 ms] Error: No pubspec.yaml file found.
This command should be run from the root of your Flutter project.
Do not run this command from the root of your git clone of Flutter.
[   +8 ms]
#0      FlutterCommand.validateCommand (package:flutter_tools/src/runner/flutter_command.dart:1074:11)
#1      RunCommand.validateCommand (package:flutter_tools/src/commands/run.dart:348:19)
#2      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:933:11)

#3      FlutterCommand.run. (package:flutter_tools/src/runner/flutter_command.dart:836:33)

#4      FlutterCommand.run. (package:flutter_tools/src/runner/flutter_command.dart)
#5      AppContext.run. (package:flutter_tools/src/base/context.dart:150:29)
#6      _rootRun (dart:async/zone.dart:1190:13)
#7      _CustomZone.run (dart:async/zone.dart:1093:19)
#8      _runZoned (dart:async/zone.dart:1630:10)
#9      runZoned (dart:async/zone.dart:1550:10)
#10     AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#11     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:825:20)
#12     CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#13     FlutterCommandRunner.runCommand.
(package:flutter_tools/src/runner/flutter_command_runner.dart:335:21)
#14     _rootRunUnary (dart:async/zone.dart:1198:47)
#15     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#16     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#17     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#18     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#19     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#20     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#21     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)
#22     FlutterVersion.checkFlutterVersionFreshness (package:flutter_tools/src/version.dart)
#23     _rootRunUnary (dart:async/zone.dart:1198:47)
#24     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#25     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#26     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#27     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#28     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#29     Future._asyncCompleteWithValue. (dart:async/future_impl.dart:567:7)
#30     _rootRun (dart:async/zone.dart:1190:13)
#31     _CustomZone.run (dart:async/zone.dart:1093:19)
#32     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
#33     _CustomZone.bindCallbackGuarded. (dart:async/zone.dart:1037:23)
#34     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#35     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#36     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#37     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)
[ +258 ms] ensureAnalyticsSent: 242ms
[   +7 ms] Running shutdown hooks
[   +4 ms] Shutdown hooks complete
[   +4 ms] exiting with code 1
A minimal complete reproducible code sample that does not uses any third-party plugin/package?
I am using "package:flutter_mobile_vision/flutter_mobile_vision.dart"
Thank you,
Rena

[ +26 ms] "flutter run" took 332ms.
[ +24 ms] Error: No pubspec.yaml file found.
This command should be run from the root of your Flutter project.
Do not run this command from the root of your git clone of Flutter.

I have to run this in the root directory of your project!

Hello Pedro Massango,
What do I need to do?

[ +26 ms] "flutter run" took 332ms.
[ +24 ms] Error: No pubspec.yaml file found.
This command should be run from the root of your Flutter project.
Do not run this command from the root of your git clone of Flutter.

I have to run this in the root directory of your project!

Hello Pedro Massango,
What do I need to do?

Hi @RenaSki
Please run flutter run in a valid Flutter project directory.

This command should be run from the root of your Flutter project.
Do not run this command from the root of your git clone of Flutter.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Documentation improvement, dangers of having an "old/wrong" fingerprint

Hey there,
Wanted to make a note as I did not see this listed in the documentation, I apologize if this was covered over on XDA - I don't frequent there anymore. Anyway, I've noticed complains from folks who sometimes use this module / data from this module that they cannot find certain applications (or find the wrong ones) via Google Play. It may be adding some language in the README around this to explain what is happening. If you'd like me to submit a PR, I can do so.
Basically, when the fingerprint is set, Google Play reads this value, which is obviously why the "certified device" piece suddenly passes. Though this also has a cascading effect of making Google Play believe you are that device for filtering as well. As an example, with the way bundles are produced for Youtube, if a device is presenting as a certified 10 device, but then upgrades to 11, Google Play will continue to believe it is on 10. This resulting in an older version of Youtube being shown as the most up to date APK the device can download. Specifically with Youtube, it will then barf and say "no I was made for an older version" as they do not rely on the fingerprint. It will then prompt a user to update the app and points them to the Play Store, which gets confused and is unable to access the page as it is filtered.
TLDR -
If you mask your fingerprint as a device, you will likely be filtered to the hardware features of that specific device at it's specific version you're presenting. While this seems obvious when explained, it appears many people get confused by this.
Again, let me know if you'd like me to distill the above into something more concrete and submit a PR to the README/Issues section.
Thanks!

That's a good idea. The docs can always be improved...
I'll look at that later, no need for an RP (unless you really want to, but I can't promise I'll use it).

No problem, if I have free time this weekend (maybe not so likely?) and you haven't done it, I'll draft one.
Also, no worries if you don't use it -- that is why I posted it as an issue and offered to do it! :laughing:
Thanks for this repo btw

Ok...
I added some warnings and info on what might happen if you change props and use different/old device fingerprints.
https://github.com/Magisk-Modules-Repo/MagiskHide-Props-Config/blob/master/README.md#warning-1
https://github.com/Magisk-Modules-Repo/MagiskHide-Props-Config/blob/master/README.md#can-i-use-any-fingerprint
https://github.com/Magisk-Modules-Repo/MagiskHidePropsConf/blob/master/README.md#the-play-store-is-broken
I'm considering it a first draft, but hardly anyone reads the docs anyway...
If you've got anything to add I'm all ears.

Generally speaking, I believe this is all good.
Also, I'm not 100% certain exactly how the filtering is done, as it's done server side for Google Play. The fingerprint is potentially a factor - but may not be the leading factor. As google states themselves, one "should not part the fingerprint themselves".
I think your changes to the README are good - I just wanted to state the above incase someone stumbles into this issue, etc.

Yeah... It's because of that kind of uncertainty that I usually try to keep the docs a bit vague on subjects like this (might, possibly, could, etc).
Thanks for the inspiration and the kick in the behind.


[ALLUXIO-3055] Async eviction docs/improvements

https://alluxio.atlassian.net/browse/ALLUXIO-3055
Cleans up async eviction and Alluxio storage documentation.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17780/
Test PASSed.

@gpang @apc999 Thanks for the feedback, I've addressed the comments.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17813/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17827/
Test PASSed.

@apc999 Could you take another look, thanks.


Updated minimalmodbus.read_string arg

For minimalmodbus.read_string(), the numberOfDecimals was changed to number_of_decimals.
This change took effect as of MinimalModbus 1.0, refer to https://minimalmodbus.readthedocs.io/en/stable/apiminimalmodbus.html#minimalmodbus.Instrument.read_register
Before fixing, the following error was encountered:
$ python3 renogy_rover.py
Traceback (most recent call last):
  File "renogy_rover.py", line 185, in <module>
    print('Model: ', rover.model())
  File "renogy_rover.py", line 41, in model
    return self.read_string(12, numberOfRegisters=8)
TypeError: read_string() got an unexpected keyword argument 'numberOfRegisters'

Hi @limweichiang !
I'm behind on PR reviews!  😅
I hope to catch up on these this weekend.
Thanks for using the library and for sending PRs back!!!!

No worries, I love that you built this and I didn't need to spend time hacking something else together. Thanks so much for sharing! Lemme know if you need any help with testing etc, I've got a Renogy Adventurer Li 30A in my setup.

@limweichiang thanks again for the PR!
I've merged https://github.com/corbinbs/solarshed/pull/13 which will flip the project over to use poetry as well as pick up all of the latest versions of the project's dependencies (like minimalmodbus)
I'm going to merge this PR and try to get some runtime on these changes against my own 40A Renogy Rover before releasing a new library version.
Thanks!


Support /retest all to run all supported tests.

Summary by CodeRabbit

New Features

Improved documentation for the GitHub webhook server, including a new command /retest all to run all tests.
Enhanced configuration section with detailed explanations and examples for various settings.

Bug Fixes

Improved feedback for unsupported retest commands, ensuring clearer communication to users.

Documentation

Restructured and clarified the README.md for better usability and understanding.

/verified


Appveyor badge is pointing to wrong repo

Appveyor badge is pointing to @zacps' repo rather than the official Alacritty repo.

Ah whoops, I'm pretty sure that's the only one. The link in README.md definitely points to yours.


C++: Performance of IRBlock and more

These four commits contain some low-hanging performance fruits I found in the IR. The tests pass, but please review thoroughly as I haven't necessarily understood the code I'm changing.
We can't actually merge this yet as it requires changes to sync-identical-files.py in Semmle/code. I'll make a separate PR for moving that file to this repo.

LGTM.
To what extent are the different layers IRBlock, ssa/IRBlock and aliased_ssa/IRBlock` individually well tested?

Makes sense.


fix: explicitly label operations which lead to fallback MONGOSH-1409

Rebased to fix a conflict with the imports. The CI failures on latest Node.js are https://github.com/nodejs/node/issues/47096, seems the project will be doing a release very soon with a fix so I’d probably just not worry about that.


Bug: FILTER_SANITIZE_STRING is deprecated (PHP 8.1.0 early test)

Hi there.
I'm currently testing a PHP 8.1.0 master branch Windows compilation, which will certainly be very close to the final version of PHP 8.1.0, and CodeIgniter 4.1.3.
In the development environment, this error is coming up:
SYSTEMPATH\Router\RouteCollection.php at line 1368
line: 1368         $from = filter_var($prefix . $from, FILTER_SANITIZE_STRING);
ErrorException: Constant FILTER_SANITIZE_STRING is deprecated
It seems to me that this would be a good time to prepare for the future by fixing this "future" bug that is coming.
I will not post any "future bugs" here again unless you expressly direct me to do so, as it may not be a priority at this time to focus on the solution.
Let me know if you want me to identify potential "future bugs" as I test with unreleased versions of PHP.
Specs:
Using Laragon (Apache 2.4.35 + PHP 8.1.0 master branch compilation)

Hi, thanks for early testing. Please direct all found issues under #4883 so we can consolidate all issues. I'll close this first as this is not a bug but a compat issue. Thanks anyway.


Please add support for Dreo Humidifier, Model: DR-HHM002S Blue

Is your feature request related to a problem? Please describe:
No it's not related to a problem technically, it's just related to adding support for a device that is currently not supported by this plugin.
Describe the solution you'd like:
Add plugin support for the new Dreo Humidifier, Model: DR-HHM002S Blue
Describe alternatives you've considered:
n/a
Additional context:
I installed this plugin and configured it correctly, but in the Homebridge logs I get the message "[Dreo Platform] error: Unsupported device type  Humidifier" when it tries to connect.
This humidifier may be relatively new, here's a link to the Amazon page for the model I received.
https://www.amazon.com/dp/B0D2DLWKYW?psc=1&ref=ppx_yo2ov_dt_b_product_details
If it helps, I'm using this Humidifier with firmware version V3.2.4_0.3.9 and when I pull it up in the Apple Home app it shows up but can't do anything because it's not currently supported.

Duplicate of #28


improvement/api-audit

Runs pip-audit once a day to check for security issues in dependencies

Is this instead of dependabot then?

No it's in addition.

No it's in addition.

... can you explain why we need both? Looks like this is checking dev dependencies as well perhaps? But then surely we don't need dependabot. Maybe dependabot is good from a visibility point of view?

Dependabot only runs once a week AFAIK. pip-audit is backed by Google and appears to be the new standard for python scanning. We should scan dev dependencies as their code runs on our machines!

Everything you're saying seems to suggest we should just use this and turn dependabot off then?

Yeah we could do - but tbh I don't see what harm there is running both?

Probably none, yeah, but it's good to understand what the differences are.  Let's go with both and see.


Introduce option to fix the  problem

On commit b817cab23f3e5 there's a good point about having shortcuts that
are numbers. This provides an option to force the use of <nowait>
anyway, if you are sure that numbers won't appear.
References #180

I changed some things and merged it. This patch should solve the <nowait> issues. :)
Thanks!


Cleanup

Pull Request Test Coverage Report for Build 260

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.478%

Totals

Change from base Build 246:
0.0%

Covered Lines:
43

Relevant Lines:
46

💛  - Coveralls


Fix overflow in lexer

Closes https://github.com/jyn514/rcc/issues/339.
Also catches an error for '\xff00000000000000ff', which before was lexed the same as '\xff'.

Codecov Report

Merging #358 into master will increase coverage by 0.03%.
The diff coverage is 88.09%.

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   79.81%   79.85%   +0.03%
==========================================
  Files          26       26
  Lines        6883     6906      +23
==========================================
+ Hits         5494     5515      +21
- Misses       1389     1391       +2

Impacted Files
Coverage Δ

src/lex/tests.rs
95.68% <80.00%> (-0.65%)
:arrow_down:

src/lex/cpp.rs
81.90% <83.33%> (+0.14%)
:arrow_up:

src/lex/mod.rs
88.93% <100.00%> (+0.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68cffcb...ac40d1a. Read the comment docs.


Generate controller mapping class from one or more SDL2 database files

Godot currently gets its mappings from the SDL Game Controller DB.  They make their database available in the form of a txt file, but godot needs to consume the mappings statically in code.  It looks like we currently manually integrate updates from SDL Game Controller DB and transform them into a C++ array format.  It gets the job done, but:

it's toilsome
it's error prone
it makes it hard to distinguish our own custom mappings from the community db

These changes remove the manually generated mappings from input_default.cpp and create a new autogenerated class file at build time.  It reads from one or more database files and records mappings in order.  Any controller GUID collisions are resolved by writing the newer/higher indexed database entry on top of the older one.  When this occurs a "WARNING" comment is added to the generated class file.
I included the following database files (they are written in this order, so the custom godot mappings take precedence):

gamecontrollerdb.txt

current SDL Game Controller DB
SDL 2.0.6

gamecontrollerdb_205.txt

last version of SDL Game Controller DB
SDL 2.0.5

godotcontrollerdb.txt

Any mappings currently in Godot not in the above two files.  This is a combination of custom godot mappings and some mappings from the SDL 2.0.4 community db

Updating our mappings is now as simple as copying the updated db.txt file from the community db.  If we find other databases worth integrating, we can easily do that too.
Caveats:

It assumes all database files are in the community database format (two lines for the header, each OS mapping section starts with # OS_NAME).  I couldn't find a standard so it seemed ok to lock on to this one.
It looks like godot doesn't currently know how to interpret the range / inversion modifiers (+,-,~) introduced in SDL 2.0.6.  The newest version of the community database uses them in some cases.  These entries are discarded and a "WARNING" comment is added to the autogenerated file.
Starting with SDL 2.0.5 the GUID format changed for some platforms.  I'm guessing godot doesn't use this format but I'm unsure.  I can say with certainty that the latest version of the SDL Game Controller DB added useful mappings for me on linux, so that format is probably the same.
When we add new Platforms/OSes that need controller mappings, we need to add a new mapping to the "platform_variables" dictionary

ex: "Linux": "#if X11_ENABLED",

Future Work:

I opted for safety here (preserve existing mappings but add as many new ones as possible).  If godot supported the changes to the mapping format since 2.0.4 (new guid format, modifiers), we should be able to remove gamecontrollerdb_205 and remove the 2.0.4 community mappings from godotcontrollerdb.txt
Even if the above isn't done for awhile, I should probably break out the 2.0.4 community db from the godot custom mappings.  I might do that over the next day or two

@Hinsbart

Hmm I'm having some build issues that I wasn't before (apart from the style validation, which I also failed :smile: ).  I'm looking now

Its an order of operations problem.  The .cpp file is generated correctly on the first build, but it isn't compiled.  It is picked up on the second build.  I'll try to sort it out but this is my first time working on an SCsub file.

Success! (Travis failed during an update)

I don't get why this is less prone to error that writing C++ code. I don't know here, but usually you have compilation errors that prevent you from doing bad things. Also, I don't get why we could not move custom actions in a separated area of the code.
I'm not fundamentally against this, but apart from the "it's easy to copy-paste the file" I don't really see the advantages  in having a dedicated file preprocessed at build time.

Thats a valid critique.  Compile time checks are always good, but we still get them with this automation.  The main benefit I see here is a clean way to perform updates.  Currently you need to download the update, visually diff the changes (or write automation to do it for you), format the changes as a cpp, and insert them.  If it was my day job to do that I would automate it the first time I was asked to do it.
The community db is an external dependency that has no reason to be merged with code (or configuration) here.  It adds upkeep work for no benefit.
I'm curious about what you mean by moving custom actions to a separated area of code.  Are custom actions an scons concept or are you talking about input actions?

Also I just pushed changes that separate the godot mappings from the 2.0.4 community mappings

If you're worried about slowing down the build we could always make it a separate utility that we run once when a db is updated, then check in the outputted class file.

Not really, the impact on compilation time is probably neglictible.
Anyway, I'd better let @akien-mga decide whether if this is a better workflow or not :)

We should definitely do what everyone thinks is best.  This wasn't a huge time investment so I'll happily go along with the crowd on this one.

That's a good change IMO, splitting thirdparty stuff out of Godot code is always better IMO. I'll let @Hinsbart have a look and merge if happy :)

Looks great at a first glance, thanks :)
Should be fine to merge but I'll take a deeper look at it soon to confirm.
Also thanks for noticing that the GUID format changed upstream, this should definitely be investigated and implemented.

Love this! I also think it's better to generate from unchanged upstream files.


Fix: onboarding tasklist order

<IP_ADDRESS>.3

This is actually the intended order because you did steps out of order. CC @reneaaron

I agree it feels strange, PR: https://github.com/getAlby/hub/pull/314