Fix demo page auto-route on signin

Details

I'm guessing this stopped working due to this PR, but unconfirmed: https://github.com/Expensify/App/pull/22437/files
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/307946
Tests

Log out, navigate to /sbe
Log in
Verify you're immediately navigated to /sbe, you see a spinner, and eventually a new workspace chat gets created & you're navigated to it

Log out, navigate to /saastr/
Same as above

[ ] Verify that no errors appear in the JS console

Offline tests
N/A
QA Steps
Same as above

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@Beamanator How urgent is this?

@cubuspl42 - very urgent actually :D do you have time to test very soon?

I don't have access to the issue. Is that an internal repo? Would you copy some details?

True true, actually I believe @mountiny is available to jump in and push this forward

Okey, so I see it this way: this flow is expected to work on its own, without explicit checks for the Onyx keys, which were meant for something else. But something broke and it's not. As the feature is related to the conference, we don't have time to look into the root cause, so we're applying this as a work-around. Do I get it right?

Do you want to have this tested on all platforms, including deep links on mobile?

Yeah you've got it 😅  We don't necessarily have time to pinpoint where the bug happened, so this little workaround should solve it - and yes we need to make sure deeplinks work on native since that'll be a pretty common flow

But yeah it looks like @mountiny has done a bunch of testing already so I think we're good to go shortly 🙏

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.62-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


The command line has unwanted ligatures in it

Here's how it looks in action:

I didn't gather debug logs because I don't think they are necessary.

Hi, @bananu7. The "unwanted" part is questionable. I added them to show the programming ligatures supported by some fonts, e.g. https://github.com/tonsky/FiraCode. But I'm not saying we absolutely need them enabled, if people vote against, we'll remove them. One thing I'm certain about is that there will be no preference to optionally enable them.
Please vote. Thumb up - support ligatures, thumb down - don't support.

@shockone I think the ligature control options have some nice tweaking capabilities, allowing ligatures such as fi or ffi to be disabled, while still retaining the ones supported by e.g. FiraCode. I was unable to make such a change because of the type definition regarding WebkitFontFeatureSettings. I can try to fiddle around that and see whether it could be improved somehow.
All in all, though, for the prompt line specifically, I think that disabling them altogether is a better option that will reduce confusion esp. when copy-pasting the commands. Other areas will probably require more thought.

You've made me change my mind. Will remove them.


Disable cache tests

Fixes flakes due to https://github.com/istio/istio/issues/4304.
Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>

/lgtm

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
2befc0df5dcfd22f24263aa4e7c3f3de97093b90
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


How to use AthensSketchBrowser?

After evaluating the following code in a Pharo 11, I browsed and and it seems that "Start" button is never enabled:
Metacello new
	baseline: 'AthensSketch';
	repository: 'github://rvillemeur/AthensSketch/src';
	load.
AthensSketchBrowser open

Hi Martin
The port to Spec2 looks incomplete, and I don't have the talent of Stephane and Esteban to complete it.
If you want to know how it works on Spec1, you can launch a Pharo9 image and load it with
Metacello new
	baseline: 'AthensSketch';
	repository: 'github://rvillemeur/AthensSketch:b261b4e/src';
	load

All example are there, but Spec2 plumbery is broken

On Pharo11, AthensSketchAppPresenter is working, you can play with it like
	AthensSketchAppPresenter new
		sketch: ASketchExampleAnimation new;
	open

Interesting, thanks!
The only issue is that the animation is already started but the button bar thinks it's stopped. I have a similar issue in the Bloc boids demo with the Spec2 controls.
https://github.com/rvillemeur/AthensSketch/assets/3044265/36e35cd4-95d2-45be-823f-005791d4f688


Enrich onRedirectCallback method with User object (#400)

Description
Enhance the onRedirectCallback prop in the Auth0Provider to expose the user, in this case, to conditionally redirect users.
For example:
Say a user is marked as a VIP in Auth0 as a means of enhancing that user's experience in the app. When the user logs in or creates an account as a VIP, they're redirected to a particular page and presented with special content as a VIP.
// in Next.js...

import { Auth0Provider } from '@auth0/auth0-react';
import Router from 'next/router';

const onRedirectCallback = (appState, user) => {
  const isVip = user['https://namespace.com/isVip'];

  if (isVip) return Router.replace(`/welcome/vip`);

  Router.replace(appState && appState.returnTo ? appState.returnTo : window.location.pathname);
};

// ...

export default function App({ Component, pageProps }) {
  return (
    <>
      <Auth0Provider
        // ... other props
        onRedirectCallback={onRedirectCallback}
      >
        <Component {...pageProps} />
      </Auth0Provider>
    </>
  );
}

The implementation above allows developers to tailor the user's experience based on context from both the appState and any special properties attached to the user object after authentication with Auth0. Effectively creating a shorter journey to get the user where they need to be.
Without this implementation, where the user should be redirected to would be delegated to logic further down the component tree and would not have access to context from appState. This would require a different means of storing context about the user's authentication journey, likely in localStorage, before the user begins authentication with Auth0. That would look something like:
// in Next.js `pages/callback.js`

import * as React from 'react';

import { useAuth0 } from '@auth0/auth0-react';
import { useRouter } from 'next/router';

const CallbackPage = () => {
  const router = useRouter();
  const { user, isLoading, error } = useAuth0();

  const isVip = user ? user['https://namespace.com/isVip'] : undefined;

  React.useEffect(() => {
      if (!isLoading) {
        if (user) {
          const returnTo = localStorage.getItem('returnTo')

          if (isVip) {
            router.push(`/vip/${returnTo}`);
          } else {
            router.push(`/${returnTo}`);
          }

        if (error) router.replace('/');
      }
    }
  }, [error, isLoading, router, user]);

  return (
    // ...
  );
}

To my knowledge, this would be a non-breaking change with a minimal API change that only surfaces the user object to the onRedirectCallback method's second function argument.
References
Resolves #400
Testing

[x] This change adds test coverage for new/changed/fixed functionality

Authentication behavior can be tested by running the demo application included with this package. You could test the new implementation by setting conditional logic based on the user object inside a custom onRedirectCallback method.
My environment consists of:

JS/TS
MacOS
Next.js
Latest version of Chrome

Checklist

[ ] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
[ ] All active GitHub checks for tests, formatting, and security are passing
[x] The correct base branch is being used, if not the default branch

I'm having a bit of trouble completing the PR checklist. Something doesn't seem to work with the CircleCI step, and I also don't know where the proper place is to document this API change.
I'm assuming it would be documented by generating new docs with npm run docs?

Hey @devjmetivier - PR lgtm, thanks
Let me figure out what's going on with the CI and get back to you

I'm assuming it would be documented by generating new docs with npm run docs?

Yep, typedoc will generate new docs with the updated signature on the next release

CI is passing here https://app.circleci.com/pipelines/github/auth0/auth0-react/686/workflows/0c265e51-0e74-4f12-bc02-96c6793210c3/jobs/857


App Crashing

1.7.0 (285) iphone
Click Buy > Click Scan a voucher > Click Checking Account > Click Choose a deposit account.
The app crashes.

-Tested this issue on dev app v1.7.5(296).Unable to reproduce this issue.


.Net: Rename 'Skills' -> 'Plugins'

### Tasks
- [x] .Net: Skill->Plugins: Existing skills Nuget packages and direct dependants
- [x] .Net: Skill->Functions: GRPC and OpenAPI Nuget packages and direct dependants
- [x] .Net: Skill->Plugins: SK Core and Abstractions
- [x] .Net: Skill->Plugins: Update integration tests
- [x] .Net: Skill->Plugins: Update sample skills and examples
- [ ] https://github.com/microsoft/semantic-kernel/issues/2970
- [ ] .Net: Skill->Plugins: Update Matthews document
- [ ] https://github.com/microsoft/semantic-kernel/issues/2127
- [ ] https://github.com/microsoft/semantic-kernel/pull/2943
- [ ] https://github.com/microsoft/semantic-kernel/pull/2937

Done


Remove 'API Endpoints' section from 'README' & move to 'pages' directory.

Removed 'API Endpoints' section and placed in new file called 'apiEndpoints.md' in 'pages' directory.

Can you add a link to the new page from the main README?

Sorry I cut out for a while life and work increased so time decreased but I knew I would be back at some point to check-in/collaborate again. How are things going with Kaguya?

I haven't had too much time to maintain it recently.
I actually tried setting up a simple ChatGPT plugin that should work locally but it didn't... not sure if OpenAI changed things on their end


sentry: Add the observed user's IP address before forwarding.

The default for Javascript reporting is that Sentry sets the IP address of the user to the IP address that the report was observed to come from^1.  Since all reports come through the Zulip server, this results in all reports being "from" one IP address, thus undercounting the number of affected unauthenticated users, and making it difficult to correlate Sentry reports with server logs.
Consume the Sentry Envelope format^2 to inject the submitting client's observed IP address, when possible.  This ensures that Sentry reports contain the same IP address that Zulip's server logs do.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

This looks good to me; if it's easy to write a fixture-based test for this, we might want to do that just to make it safer to refactor in the future.


Unite PackedBaseField with AVX M31 impl

This change is

src/core/backend/avx512/mod.rs line 74 at r1 (raw file):

        self.length
    }
    fn at(&self, index: usize) -> BaseField {

document.
Code quote:
fn at(&self, index: usize) -> BaseField {


Add files via upload

Hi, this is a request from a High Scool http://www.st-joseph-lorient.org/

@JDKKDJD Pull request merged. Thank you!


Test issue

Tesing the newly added closure.yaml.

If you found this useful, please consider starring :start: this repo, or even sponsoring it :dollar:.Even just a $1 can help this keep running.Thank you for using Swiftagram.

If you found this useful, please consider starring :star: this repo, or even sponsoring it :dollar:.Even just $1 can help me maintain this.Thank you for using Swiftagram.


There is now a to-html AUR package

Not an actual issue, but I figured you would like to know :)
https://aur.archlinux.org/packages/to-html

That's nice! You can add me as a co-maintainer: https://aur.archlinux.org/account/Aloso

Done and done!


ice: injection & configuration environment

ICE extracts the logic in sched/config.go and makes it general so it can work for all our binaries.
The central object is an Environment, which binds providers. An Environment can then Eval to create objects. DI, tada!
But we want more: we want configuration. So ice also has Options, which lets a program define Variables with multiple Variants. Then Parse takes JSON and creates a Module that can be Installed to the Environment before Eval.
This gives us:
a) injection
b) configuration
c) extensibility (so it works across all binaries)
This works to create the scheduler, but currently doesn't create the associated health checking, which would take extending Eval to create multiple objects in one go, which I can do easily if we think this is a good approach.

I don't understand combining Dependency Injection & Config.  They seem totally unrelated.
I'm also not a huge fan of the config objects (which are part of operations) bleeding into the application logic.  I'd prefer that the necessary values are passed into new/make functions (these may be parsed from config or created via a test case) this automatically supports dependency injection without the need for config files in each object.
We should be specifying environment as a go flag that is either passed in on the command line or as part of the aurora file.  The environments we want to support are local, devel, staging, and prod.  We should also supply datacenter as a config flag since there will be different config values depending on where the code is deployed.  Ideally then the config code can be modified to parse the correct config file based on the env and datacenter.  On a previous team we named files ..config and could easily construct the config file name based on the two supplied flags.
Another very valuable aspect of config definition & parsing is that it fails to parse at server startup time if required values are not supplied, or values are not in the correct range.  Basically it fails fast.  I think this code does that, i.e. it parses the code before starting the service but is only as restrictive as the type system is expressive.  A lot of time its worth just handwriting the extra validation code to ensure config parses correctly.
In previous projects I've had config defined only at the server/binary level.  This makes operations / maintenance easier since all config for the service is in one location and is easy to find instead of hunting and pecking throughout the entire code base.  From an operation perspective its a bit weird to have it in the application code.
Finally if we want a framework instead of hand writing the parsers & validating why not use an already existing one like Viper

I'm happy to change how we do Configuration! In fact, this change tries to change it as little as possible from what's currently in the Repo. I haven't thought that much about configuration, so I'm happy to change it.
I care a lot about getting our DI story right. I think this change is an improvement in how we do DI (at the cost of using reflection, which, ugh). (And, to reiterate, not a change in how we do configuration).
I think that this change separates Integration and Configuration from where we are today, which I like. The Configuration just changes what Modules are installed. So, yeah, we can totally change them.
I think there are lots of different desires for Configuration. We'd like to balance: flexibility, strictness (and failing fast), documentability, etc.
I'd be happy to use Viper for Configuration, or anything else that's easier.
Concretely, my big fear was that sched/config was doing both DI and Configuration and that was dangerous, and we're about to replicate it into worker/config, which would start nearly the same, but then start diverging. Eeek!
My hope is that we can use fewer, more common (and also better!) libraries.
It sounds like we should get together to get on the same page.

Current coverage is 74.33% (diff: 70.46%)

Merging #78 into master will increase coverage by 2.85%

@@             master        #78   diff @@
==========================================
  Files            41         41
  Lines          2002       1979    -23
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1431       1471    +40
+ Misses          495        434    -61
+ Partials         76         74     -2

Powered by Codecov. Last update 96c7f9f...072d906

This is looking better, particularly after that meeting. I don't really have more than a couple interface-level suggestions, so let me know when you want the nits.

lgtm

lgtm


Ability to build base images that have everything installed except kubernetes

I would like to be able to run packer to build images, but I don't want kubernetes baked in to the image (I'll bring my own). Is there some way to use a packer var and an ansible var to exclude the kubernetes role from the playbook?
@detiber @timothysc

@mauilion this is the issue we chatted about briefly earlier today

@ncdc I believe this falls outside the scope of wardroom. Is this still needed?


How to use Multiple Roles

if I need use two or more roles in vue-roter，How to confing？
if I use role: ['Role1','Role2']，when logged user's role is Role2,It will denied access to this router。Thanks
{
      path:'/value',
      name:'value',
      component:Value,
      meta: {
        requiresAuth: true,
        role: ['Role1','Role2']
      }
    },

如何实现Role1或Role2任意一个角色的用户登陆，都可以具有访问权限，感谢

you will need to change the index.js(https://github.com/joaojosefilho/vuejsOidcClient/blob/master/src/index.js)
In line 24 of index.js, the 'to.meta.role' attribute stores the roles of the route. when there is one more role, 'to.meta.role' is going to be an array. you have to go through the array.

you will need to change the index.js(https://github.com/joaojosefilho/vuejsOidcClient/blob/master/src/index.js)
In line 24 of index.js, the 'to.meta.role' attribute stores the roles of the route. when there is one more role, 'to.meta.role' is going to be an array. you have to go through the array.

thanks,感谢，之前没理解这一块，现在已经解决


support for automatic bisection quite lacking

I'm looking into adding automatic bisection to icemaker reports and it turns out to be quite difficult.
I was hoping I could do something like  cargo-bisect-rustc --preserve  --test-dir=/home/matthias/vcs/github/rust_bisect/foo --start 2021-01-01  --access github --regress ice -- rustc /tmp/icemaker/113793.rs -Zmir-opt-level=3 apparently this requires cargo rustc to be a subcommand  :/
When bisecting manually I used a --script where I would just put in a simple ! rustc args | grep "panic" command to force a bad exit code on crash, but writing, chmodding and executing a bash script which you then run as arg to cargo-bisect seems kinda silly.
I need to be able to use (prlimit run ..) rustc/rustdoc/clippy-driver  <file> <args>) to pipe through the binary, rustflags and filepath that I get from icemaker, creating an extra "cargo" project and putting the file in there, and setting its RUSTFLAGS and then running "cargo build" also does not seem like the right way.
edit: I found cargo x which seems to be a simple passthrough, so that cargo x cmd simply runs cmd, maybe cargo bisect ... x rustc .. can make it work, will try that next
Plans to just use cargo-bisect as a dependency in icemaker were quickly abolished when I saw not even the Config struct was marked public :laughing: so that would probably require a bunch of changes here and there.
It would be great to have something like a --cmd  "rustc --foo --bar crash.rs"  --interesting-exitcodes="101,42,134" --interesting-output="panicked" --interesting-output="stack overflow" --interesting-output="internal compiler error" to make it a bit more versatile

This sounds like there are multiple issues here, can we maybe separate it out into separate things?
For running without cargo, running without cargo explains what you need to do. Roughly, your first command would be rewritten as cargo bisect-rustc … --script=rustc -- /tmp/icemaker/113793.rs -Zmir-opt-level=3.
You mention adding various --interesting flags, but don't quite explain what they mean. Can you detail what you are after there?
The --regress flag already has various options for different regression checks. I personally want one to handle grepping for output, and I'm not sure if that is what you mean by --interesting-output?
What is the purpose of --interesting-exitcodes? I don't recall rustc really having different exit codes.

--script=rustc ...

I do not know why this never crossed my mind :D
Thanks, I'll try that.

--interesting flags

The problem I ran into is for example:
rustc can have a "classic" internal compiler error, caused by a panic!(), bug!(), assertion failure etc
rustc can stack overflow
rustc can get sigabrt/sigsegv'd (might be caused by a miscompilation)
LLVM can run into an assertion failure
LLVM can run into a LLVM_ERROR
a process gets killed by the OOM killer
from my experience, these can have different exit codes, so just having a hardcoded exit_code == 130 is not enough in all cases unfortunately.
https://github.com/matthiaskrgr/icemaker/blob/dcf6aea556b4ed0f082bd89950dcfdda9fb87538/src/main.rs#L1116
You may also find yourself wanting to bisect with some custom condition like "exit code is 130 AND stacktrace contains "argument to drop_in_place is not a raw ptr" to make sure you catch "once ice turning into another" or something like that, but its a bit of a niche case.
I knew the grepping example, but this again needs a custom script to passed to cargo-bisect which I would like to avoid :)


Add MaxPool as an explicit argument to MaxPoolBackprop

Core changes:

Removes the optional weak reference to the forward op in the existing MaxPoolBackprop constructor * Adds an additional constructor which takes the forward MaxPool op as an explicit argument.
Updates op::MaxPool::generate_adjoints to use the new 3-arg backward constructor (thus ngraph-mxnet should require no changes)
Add serializer support

GPU changes:

Support backward pooling without the pooled tensor by recomputing the forward pass (2-arg c-tor)
Use cudnnBackwardPooling when the pooled result is available (3-arg c-tor)

CPU changes:

Add layout for MaxPool arg in layout for backprop
Update workspace insertion pattern matcher to support the new c-tor

This would be a good opportunity to make sure that MaxPool and AvgPool have the same interface (both in forward and backprop).


feat: use portfinder instead of random

Description

Linked Issues
Additional context

Looks good to me, thanks!


change coding style in apiserver

Why are these changes needed?

Related issue number

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

@kevin85421, This is our newbie's second contribution. Please take a look when you are available.

This seems to be duplicate with #2096. Close this one.


Upgrade dependencies

All node and grunt dependencies need to be upgraded.

This issue was moved to consortium/hybrid-publishing-research#38


Access denied for user exception

At the time of installation when I am putting this command
.\bin\init-mongodb.bat --env=dev
I am getting the following error

Please suggest from where this issue arising. I am following this link totally:
https://github.com/Cocolabs-SAS/cocorico/blob/master/doc/installation-application.md

Hi  @Rituparna007
You should execute these SQL statements : https://github.com/Cocolabs-SAS/cocorico/blob/master/doc/installation-server-windows.md#mysql.
by  replacing {DB}, {DBUSER}, {DBUSERPWD} with the corresponding values you have in your parameters.yml:
Ex for:
database_name:     mydb
database_user:     myuser
database_password: mypassword

Your SQL should be :
CREATE DATABASE IF NOT EXISTS mydb DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci;
GRANT SELECT, INSERT, UPDATE, DELETE, CREATE, DROP, INDEX, ALTER, CREATE TEMPORARY TABLES, LOCK TABLES, REFERENCES ON mydb.* TO myuser@localhost IDENTIFIED BY 'mypassword'

Feel free to reopen it if problem persists


Testing for price history

I'm working on this

I think we can close this issue cause already resolve via #458


After dialed # connects, cannot dial an extension

There doesn't seem to be an easy way to pull up the 10 key pad to dial an extension after the initial add participant phone connection is established.  Am I missing something?  I am doing this flow: "Meet Now"  --> Add Participant --> Dial #  --> connect to user at POTS #  --> Cannot dial extension.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d26a08af-4176-49a2-a884-ef436f12ce4b
Version Independent ID: f218dfc6-a3e5-5c4e-c0db-9127c3d88fc9
Content: Dialing out from a Skype for Business meeting so other people can join it
Content Source: Skype/SfbOnline/audio-conferencing-in-office-365/dialing-out-from-a-meeting-so-other-people-can-join-it.md
Service: skype-for-business-online
GitHub Login: @tonysmit
Microsoft Alias: tonysmit

@cjecwest - thanks for this feedback and finding the area where the article needs to be clearer.
@jamesrhea and I are working on figuring out how to get this resolved in the content.
@chuckedmonson - might be able to help too.

@cjecwest, you should be able to use extension numbers after the call has been connected. Do you see a Call Controls button in the bottom right of the conference window?
You can see the icon and available options here, which should include the 10-key pad. https://support.office.com/en-us/article/make-and-receive-calls-using-skype-for-business-228e03aa-7361-4997-8dfa-1dd9bdc717f6


changes to EjectMedia utterances

added periods to cd dvd
included versions using "the" e.g. "eject the disc"

This isn't right.  The (docs)[https://developer.amazon.com/public/solutions/alexa/alexa-skills-kit/docs/defining-the-voice-interface] say
For better recognition, acronyms and other phrases involving spoken letters should either be all caps (“HD”) or separated by periods (“h.d.”). Using lowercase for initialisms may lead to unreliable recognition since the spoken form may not correctly be detected.

It's either lowercase with periods separating the letters (specifically, it doesn't say "also a space") or all capitals.

Not sure what isn't right, you are describing exactly what I did.
I changed eject cd to eject c. d.
You are confusing/referencing what the docs say about using acronyms in Custom Slot values rather than Sample Utterances.
The section Custom Interaction Model Reference says the following about Sample Utterances:

Acronyms and other phrases involving spoken letters should be separated by periods and spaces (“n. b. a.”, not “nba”).

Oh, yes, you are correct.  Odd that they'd have different rules for them.

Can you make these changes on the flask-ask branch as well?

I had assumed we'd just rebase flask-ask onto current master.  I can do that, if you want me to?

Either way is fine.

I can do it now, or later.  In general I rebase right before merging a branch.  Hadn't done it yet because these changes are pretty minor and shouldn't affect testing of the flask-ask branch in any meaningful way.


MudRating component is nesting the interactive controls inputs into the span tags.

Things to check

[X] I have searched the existing issues for this bug
[X] To rule out a caching problem I made sure the bug also happens in an incognito tab

Bug type
Component
Component name
MudRating
What happened?
MudRatingItems into the MudRating Component are nesting the input into span tags, so when you run some accessibility checker those are reporting an ADA issue:
"Ensure interactive controls are not nested as they are not always announced by screen readers or can cause focus problems for assistive technologies"
Expected behavior
Do not nesting the input into span tags
Reproduction link
https://try.mudblazor.com/snippet/wacebvQQfPqDuTKg
Reproduction steps

Add a MudRating component.
Scan the page using a accessibility checker like axe DevTools
-- OR --
Inspect the web app in chrome web development tools, and see that the Input is been contained into a span tag.

Relevant log output
N/A

Version (bug)
7.15.0
Version (working)
No response
What browsers are you seeing the problem on?
Edge
On which operating systems are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

hi @igotinfected what is the next step for this bug to be fixed?

Hi @nesh-globant! you are free to (and we encourage) opening a PR with a fix/improvement if you have the time, otherwise someone from the contribution team will eventually get around to it whenever they find the time to do so. All of us contribute in our free time ;)


shell: fix assert when bypass mode is set during long-running command

Restore previous command context after bypass function is called. If using shell_set_bypass()/shell_process() (i.e. to detect Control-C) during a long-running shell command, shell_fprintf() would assert after the first shell_process() call. This fixes that ASSERT.

@bradeyh Is this going upstream also? Please update with a link when it is.

Yes, that's the plan. Will do.


Add user and authority for mongodb

Fixes - #1506
@pascalgrimaud  have below questions
Didn't added below two method in UserJpaRepository when generated for MongoDB as I think @EntityGraph is not supported by spring-data-mongodb and as a result have not set relation between UserEntity and AuthorityEntity Lazy so that all the child entites also get loaded.
Is it fine ?
@EntityGraph(attributePaths = "authorities")
Optional<UserEntity> findOneWithAuthoritiesByLogin(String login);

@EntityGraph(attributePaths = "authorities")
Optional<UserEntity> findOneWithAuthoritiesByEmailIgnoreCase(String email);

Also for enable auditing i.e @CreatedBy & @LastModifiedBy, we have to provide implementation of AuditorAware
should we generate some dummy implementation ?
Ref - mongo.auditing

The reference should be this repo https://github.com/jhipster/jhipster-sample-app-mongodb
About repository, try to do similar methods than https://github.com/jhipster/jhipster-sample-app-mongodb/blob/main/src/main/java/io/github/jhipster/sample/repository/UserRepository.java
About audit:

https://github.com/jhipster/jhipster-sample-app-mongodb/blob/main/src/main/java/io/github/jhipster/sample/domain/AbstractAuditingEntity.java
https://github.com/jhipster/jhipster-sample-app-mongodb/blob/main/src/main/java/io/github/jhipster/sample/config/DatabaseConfiguration.java#L26

So yes, we could initialize audit too, but as I'm not a MongoDB user, I don't know if it should be generated by default. At least for consistency with SQL options, I would say yes

@pascalgrimaud
should we generate SpringSecurityAuditorAware.java when user execute either of these two api /jwt or /oauth2 ?
also if we use it in mongodb users have to add security when they want to use mongodb, is it fine ?

@pascalgrimaud I have aligned the repository like https://github.com/jhipster/jhipster-sample-app-mongodb/blob/main/src/main/java/io/github/jhipster/sample/repository/UserRepository.java as you mentioned
and for auditing for now I am always returning system, as if we want to extract current logged in user we need security libraries as well, and this will create dependency on security endpoint.
So if user wants to generate only mongodb app they can't and have to include security too.
what you think about this ?
@Component
public class SpringSecurityAuditorAware implements AuditorAware<String> {

  @Override
  public Optional<String> getCurrentAuditor() {
    return Optional.of(UserConstants.SYSTEM);
  }
}

Sorry, didn't see the previous comment
Is this SpringSecurityAuditorAware mandatory to have?

Nope, it is not mandatory, but if we don't have it @CreatedBy won't work automatically, the field annotated with that annotation has to be populated manually.

After thinking, we could do this:

check if there is spring-security-test dependency, it means there is JWT or OAuth2 security, so we can add SpringSecurityAuditorAware
otherwise, we won't' generate SpringSecurityAuditorAware and CreatedBy will be empty (or with default value)

Is it possible?
So we'll have 2 use cases to test:

use mongodb + mongodb user/authority
use security -> mongodb -> mongodb user/authority

@pascalgrimaud getting failure in sonar with code duplication.
And it shows duplication between generated UserDTO and UserEntity class,
could you please suggest what can be done to fix this issue ?

I'll have a look tomorrow but for me, primary is out of scope of this. The ticket is related only to secondary (entity part)

Yes, I have not made any changes in primary, basically I am generating a new project to test mongodb with oauth2, and for that project sonar analysis is failing with code duplication,
as UserDTO is coming from oauth2 code generation and UserEntity is coming from mongodb code generation.

Thanks for the input @beatfreaker
I'll have a look and try to find a solution

So in fact, UserDTO will changed, as JWT option and OAuth2 option will be refactorized to respect more the hexagonal architecture
So maybe we can wait the refactor before merging this?

Yup make sense, I am okay with that.

As discussed here https://github.com/jhipster/jhipster-lite/issues/2482
I don't think we should merge this.
But as you spent a lot of time on this, can I propose you to take the bounty anyway, @beatfreaker ?
Tell me if you agree:

I'll close this ticket
you can claim it
then, we can focus on other stuffs

We'll also use it as an example for the dummy mongo persistence

@pascalgrimaud I am okay closing this ticket, thank you 😊

@pascalgrimaud as discussed claiming bounty https://opencollective.com/generator-jhipster/expenses/88036

Approved!
thanks for your work @beatfreaker and sorry for closing this one


Unable to compile with parent mapper in another module with 1.2.9

JsonMapperLoaderImpl in 1.2.x is module specific, which make it impossible to compile JsonObject across modules, e.g. JsonObjectA extends JsonObjectB which in different module
1.1.0 works well

Would it be possible for you to create a sample project that demonstrates this issue? There's a few different ways you can do modules and I want to make sure I'm covering your use case in whatever fix we come up with.

for example we have module A which is basically full of basic class
package com.nice.common.data.json;

import com.bluelinelabs.logansquare.annotation.JsonField;
import com.bluelinelabs.logansquare.annotation.JsonObject;

@JsonObject
public class BaseResponse {
    @JsonField(name = "code")
    public int code;
}

and we have module B which is full of logic code and have module A as dependency
package com.nice.main.tagdetail.pojo;

import com.bluelinelabs.logansquare.annotation.JsonField;
import com.bluelinelabs.logansquare.annotation.JsonObject;
import com.common.data.json.BaseNextKeyList;
import com.common.data.json.BaseResponse;

import java.util.List;

@JsonObject
public class UserListPojo extends BaseResponse {
    @JsonField(name = "data")
    public UserListEntity data;

    @JsonObject
    public static class UserListEntity extends BaseNextKeyList {
        @JsonField(name = "users")
        public List<User> users;
    }
}

then we compile, we got the following error
/Users/bluef/Documents/code/nice_android.git/app/build/generated/source/apt/china/debug/com/nice/main/tagdetail/pojo/UserListPojo$UserListEntity$$JsonObjectMapper.java:19: Error: Can't find symbol
  private static JsonMapper<BaseNextKeyListPojo> parentObjectMapper = JsonMapperLoaderImpl.COM_NICE_COMMON_DATA_JSONPOJO_BASENEXTKEYLISTPOJO__JSONOBJECTMAPPER;
                                                                                ^
  Symbol: Variables COM_NICE_COMMON_DATA_JSONPOJO_BASENEXTKEYLISTPOJO__JSONOBJECTMAPPER
  Position: Class JsonMapperLoaderImpl

so in the error above, the JsonMapperLoaderImpl mentioned is in moduleA, but the symbol COM_NICE_COMMON_DATA_JSONPOJO_BASENEXTKEYLISTPOJO__JSONOBJECTMAPPER we are looking for is in the JsonMapperLoaderImpl in moduleB which do have that symbol.
I've remove some app specificed code so the code above is just for demostration.

I can confirm this issue.
LoganSquare compiler generates a JsonMapperLoaderImpl class for each module, which causes conflicts during build.
There's a simple & quick solution, that is generate a unique suffix for each JsonMapperLoaderImpl into a empty package, for example com.bluelinelabs.logansquare.impl.JsonMapperLoaderImpl_[md5], and load them all when initializing LoganSquare class.

@bluef Hi, I issued a pull request to this problem, could you try my patch and see whether it works?

@mariotaku I think that makes sense. Would you mind that show me how to apply your patch or compile with your fork?

@bluef Just quote those maven specified fields in build.gradle, like

    bintray {
        user = 'bintray_username'
        key = 'bintray_api_key'
    }

@mariotaku Thanks. I've tried your patch and things work as a charm. Wish @EricKuck could merge your pull request. :)

This was fixed by removing the JsonMapperLoader completely. It's now working in v1.3.4.


Compatibility errors

This extension is very useful, but unfortunately as soon as it is installed the following happens during any image generation (all requirements are met) -submitting as attachment due to huge amount of messages:
error.txt
If this extension is still maintained, PLEASE advise.

I got this issue too


How to extract reponse of workflow in client

I am invoking workflow through ConductorServer class, is it possible to get output of  workflow in the cConductorServer class.?
I also have one more query

is it possible to invoke task which is part of workflow separately through ConductorServer?

Actually what I need to do is , I have many  http tasks  in the workflow,  for some of the http task I need to get response of it, and alter the response and pass it to as input to another http task.  is it possible to achieve this through ConductorServer?

@veveeran
Yes we can get the output from an workflow API given by conductor
First of all we need to have outputParameters properly defined in our workflow.
After workflow created successfully, will get unique workflow Id, using same workflowId we can fetch
output.
Example URL
http://localhost:8080/api/workflow/dfa77699-a3b9-4c20-9339-42d4762d5f34.
For second question, conductor support that, but to understand better please post your workflow structure and will identify a solution.

this is my workflow, I have 2  http task defined.  tt1 and tt2. I have a requirement that I have to get the json response from  tt1 and modified the response( like appending , formatting, deleting some data from json), and  this modified json I have to input to tt2 as body. is it possible

Yes, It is possible.
public TaskResult execute(Task task) {

}

This is the method you should implement and can get the input data as  task.getInputData(); . This will be a Java Map object with underlying data as JSON. You can use Jackson JSON libraries to extract, enrich and transform the data

If the response need not be modified - could we skip the execute task implementation and directly use
tt1.output.response.body.
would it work? Will it work in memory?

@jvemugunta Thanks for the response.
@sudvarma You would still need to implement the execute() method and within this method, you can set the status of the task and also the output of the task.


[bug] Unable to open CSS color picker by clicking on color preview box in the CSS source code.

The documentation says that we should be able to click on the color preview in a CSS file to open the color picker. This has never worked for me. I've never seen this feature, but I've always thought it would make sense to click on the boxes and open a color picker.

Version: 1.47.1
Commit: 485c41f9460bdb830c4da12c102daff275415b53
Date: 2020-07-14T22:01:14.734Z
Electron: 7.1.14
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.4.52-1-MANJARO

Steps to Reproduce:

Open a CSS file with a color in it.
Click the color preview box.
Nothing happens (no color picker)

Does this issue occur when all extensions are disabled?: Yes
Here I am trying clicks and double-clicks:

According to https://github.com/microsoft/vscode/issues/82206, the color picker should appear when hovering. Hovering didn't work either.
I don't think it should. It should be on click, while hovering does not get in the way of the code editing experience (that would be too annoying).

The colorpicker does appear on hover, if you hover "the right way". If you enter the color value from the "wrong" side it will not show. This confused me a lot in the beginning but I somewhat got used to it. Brackets does a better job, the color picker is revealed with a keyboard shortcut.
I agree with @trusktr that clicking the color preview box to reveal the color picker would be a better user experience.

color picker isn't showing for me at all when I hover from the bottom.  what is the keyboard shortcut, if there is one?


Licensing

Hi!
I was wondering whether this project could be used with pandas instead of original pyxlsb. However, they are rather strict with licensing questions.
The original pyxlsb was released under LGPLv3 (which was fine). It seems derived work can't be licensed under Apache 2.0 according to this. You could consider relicensing pyxlsb2 under LGPLv3 so it would be compliant with licenses and usable.

Hi Ingvar,
I think it does not apply to pyxlsb as at the time of forking the license was different:
https://github.com/DissectMalware/pyxlsb2/blob/master/LICENSE_pyxlsb
The above one is the license at the moment, I forked from pyxlsb. They made a license change.
What do you think?

Oh, it seems that I miss-read your request. You mean changing the license from Apache 2.0 to LGPLv3 so it can be used in Pandas? If that's the request, yes I can change that.

Oh, I see, pyxlsb master is licensed under MIT but release versions are licensed under LGPLv3 - that's weird. No, Apache 2.0 license is perfect and better suited for inclusion in non-GPL project like pandas. I am sorry for having bothered you.


Ping Error in release mode

I am getting issue while deploying using docker with mix release mode.
It is working fine without docker.
* (MatchError) no match of right hand side value: {:error, :enoent}
    pubkey_os_cacerts.erl:38: :pubkey_os_cacerts.get/0
    httpc.erl:476: :httpc.ssl_verify_host_options/1
    httpc.erl:1015: anonymous fn/0 in :httpc.http_options_default/0
    httpc.erl:961: :httpc.http_options/3
    httpc.erl:771: :httpc.handle_request/9
    (elixir 1.15.5) lib/enum.ex:1693: Enum."-map/2-lists^map/1-1-"/2
    (elixir 1.15.5) lib/stream.ex:613: anonymous fn/4 in Stream.map/2
    nofile:1: (file)

Going to close this as we're removing the ping function, because neither Google nor Bing support this any longer.


DES references

I am starting this PR to update the DES survey even though the HSC PR #32 is not yet merged as we are waiting for the last HSC obscuration details.
Note that the CTIO website URL has recently changed from ctio.noao.edu to ctio.noirlab.edu so that the main DES survey parameter reference links in the corresponding issues are dead.
For the filter parameters, I have chosen to use the DR1 paper as it contains the sky_brightness, exp_time and psf_fwhm in the same place (we use speclite for zeropoints). We may use the DR3 values but the sky brightness is given in e-/pixel so it would need to be converted to mag/arcsec^2.
Also, in practice, exposure times are 90s (for DR1) and those exposures are coadded by 10 to make 900s coadds so I am not sure if we should set 90s or 900s as exposure time. As previous values were about 800-1000s, I assumed we should use 900s.

Hi @aboucaud  and @mpaillassa - do you also want to include the central_wavelength in every filter of each survey? Currently only "Rubin" has this specified.

Hi @ismael-mendoza. Yes, I remember that we use the same Rubin/LSST central wavelength for all surveys in BTK but it would be nice to have a central wavelength for each specific survey filter. I guess this is to be managed with #36.
For DES we can find information here. Especially, I guess we can compute the central wavelength thanks to the Excel spreadsheet but what is the exact definition of the central wavelength ? Is it the filter response weighted sum of wavelengths through the bandpass ?

Thanks @mpaillassa for the info, I'll talk to Javi about how they computed it in WeakLensingDeblending and let you know. The relevant line is here but the link mentioned is broken.
Feel free to proceed with this PR if possible without the central_wavelength information and we will manage it in a different PR along #36

@mpaillassa are you ok with resolving the existing conflicts or do you want me to do it ?

@aboucaud It's ok I just did it.

Thanks a lot @mpaillassa !


Integrated new hopper-frontend JS files.

HOP-80

[Current coverage][cc-pull] is 97.67%

No coverage report found for develop at 8b8deb2.

Powered by Codecov. Last updated by [8b8deb2...3a2db25][cc-compare]
[cc-base-branch]: https://codecov.io/gh/transcode-de/hopper/branch/develop?src=pr
[cc-compare]: https://codecov.io/gh/transcode-de/hopper/compare/8b8deb2b3bf2b34c8eb5ef13588028417790ee2f...3a2db254de16040b2cd23581182ddccf5c54501f
[cc-pull]: https://codecov.io/gh/transcode-de/hopper/pull/21?src=pr


Adding a Model

How to add a new multimodal model, LLM is Qwen2. Is there a documentation you can refer to, or is there a big guy who has any experience you can provide

Please see https://github.com/NVIDIA/TensorRT-LLM/tree/main/examples/multimodal.
If you run into an issue while doing this, please file an issue with the bug.


Update limitations-gh.md

There was a long running case on how to choose a different branch name.
First time when searching for the branch, it works fine and customer is able to save the pipeline.
If he searches for a different branch, even though it gets the branch, the Get Sources shows "Some settings need attention" and does not allow Save.
If user needs to search a different branch, he needs to close the pipeline and reopen it and enter the other branch name.

@silviuandrica

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Expanded folders are not sorted when code is opened

Issue Type: Bug
Summary:
Already expanded directories in the explorer view do not appear to be sorted when VSCode is first opened. Directories that start collapsed, and are then expanded, do get sorted properly. Additionally, hitting the refresh button or changing explorer's sort order to something else and then back to the default causes everything to get sorted correctly again.
(I've shortened the names of the files/directories below.)
Actual:
+ lib
+ nod
- src
    Err.json
    ILo.ts
    (more files)
  + bin
    bin.yaml
  + com
  + dec
  + dia
    dia.yaml
  + mod
  + sym
    tsc.json
+ tes
(more files)

Expected:
+ lib
+ nod
- src
  + bin
  + com
  + (more directories)
    bin.yaml
    dia.yaml
    Err.json
    (more files)
+ tes
(more files)

VS Code version: Code - Insiders 1.31.0-insider (9606490e26f8cbe4d615305389d45e9b144ded7c, 2019-01-30T15:20:25.145Z)
OS version: Windows_NT x64 10.0.17134
Extensions: none

Yep, appears to be fixed.
xref: #67633

Thanks, adding verified label


Update incorrect pydantic schemas for metrics and add tests for these

Fixes #964
Bug Fix
Describe the bug
Incorrect pydantic schemas cause pydantic_core._pydantic_core.ValidationErrors when using a custom LLM for evaluation, which is implemented with schema injection as described here.
The problem occurs for any Verdicts schema which has reason : str instead of reason : Optional[str], given that the prompt requires the llm-judge to return no reason for 'yes' verdicts. Additionally, the Steps schema for GEval should be steps: List[str] where it is currently steps: str.
To Reproduce
Problem with Verdicts schema:

Run any test_verdict_schema from the new test files using the old version of the schema
See error:

pydantic_core._pydantic_core.ValidationError: 1 validation error for Verdicts
reason
  Input should be a valid string [type=string_type, input_value=None, input_type=NoneType]

Problem with the Steps schema for GEval metrics:

Run test_steps_schema in test_g_eval.py using the old version of the schema
See error:

pydantic_core._pydantic_core.ValidationError: 1 validation error for Steps
steps
  Input should be a valid string [type=string_type, input_value=['step1', 'step2'], input_type=list]

@harriet-wood thank you so much for this PR! Will include it in next release v1.1.1

Oh yes, you're right, I didn't check the prompt templates for those ones and assumed it would be the same for any with a verdict schema 😄 I encountered these originally for geval and contextual relevancy


feat(sdk): add flag to skip strict sats check

What this PR does / why we need it:
This PR adds a flag to bypass the strict sats check in inscription builder class. Many txs that were initiated by users earlier are now stuck because of the recent release that updated the fee calculation.
If fee is changed, the reveal fee is changed too and the inscription builder would not pass the check because the sats/value of original UTXO by user to the commit address would be different.

utACK


Missing License Information

Could you please inform us, if we may use this library without restrictions? May we assume, it is a MIT-License? Thank you very much!

The license information is at the top of the source files

Copyright 2016 Google Inc. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

It's also in the top level COPYING file: https://github.com/web-animations/web-animations-js/blob/master/COPYING


Update resource-locker to v1.1.3

Supersedes #35 and #38
Checklist

[x] PR contains a single logical change (to build a better changelog).
[x] Update the documentation.
[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog.

Actually I don't think it's worth touching this for now. Closig PRs instead


[EASI-2412] Read Only CR and TDLs Subpage

EASI-2412
Changes and Description

Add ReadOnlyCRTDLS component to the Read Only page
Add new fields to GetModelSummary query
Pass down readOnly prop to the CRTDL Table to it adjusts how user will navigate back and forth in the AddCRTDL page via hash location #read-only

AC

CRTDL component on readonly
Similar layout to discussions (hide contact right side bar)
Edit access - Edit should take user to edit page for CRTDL

How to test this change

Preseed data
Navigate to the CRs and TDLs section of the read only page for Plan With CRs and TDLs
Ensure Table shows the correct items
Ensure Edit access is only available for collabortaors and assesment peopleepwewe

Redo test not as a collaborator and not having assessment job code

Ensure that Actions column is MIA

PR Author Review Checklist

[ ] Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
[ ] Added or updated tests for backend resolvers or other functions as needed.
[ ] Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
[ ] Updated the Postman Collection if necessary.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
Always make comments, even if it's minor, or if you don't understand why something was done.

Most of the time removing a CRTDL from readonly doesn't close the modal.  One time it closed.
This is after successfully removing a CRTDL:


-u command bug

When I enter the -u command:
imgur-screenshot.sh -u

I receive the following output:
Version v1.5.1 is available (You have v1.5.3)
Check https://github.com/jomo/imgur-screenshot/releases for more info.

Similarly, when I invoke the script:
imgur-screenshot.sh

I receive the following output:
booker@booker-MS-7681:/usr/local/bin$ imgur-screenshot.sh
Please select area
Uploading '/home/booker/Pictures/imgur-2015_04_14-08:56:49.
...
Update found!
Version v1.5.1 is available (You have v1.5.3)
Check https://github.com/jomo/imgur-screenshot/releases for more info.

Obviously version 1.5.3 is more recent than version 1.5.1.
I am running Ubuntu 14.10.

This will be fixed in a second :)

I guess you need to make a release on GitHub...?
Either way, thank you in advanced.

yes

There it is, it was a one-time bug because the version check was [changed] from comparing the .version.txt to using actual GitHub releases.

I updated my local script using git clone but the problem persists.
Update found!
Version v1.5.4 is available (You have v1.5.3)

Then you don't have v1.5.4

Accidentally forgot a commit, should be fixed now

Works now yay :smile:.
By the way, is there an easier way to update? At the moment I do something like:
cd /usr/local/bin
sudo rm imgur-screenshot.sh
git clone https://github.com/jomo/imgur-screenshot
sudo cp imgur-screenshot/imgurscreenshot.sh imgurscreenshot.sh
sudo rm -rf imgur-screenshot

There is. Setup:
git clone https://github.com/jomo/imgur-screenshot
cd imgur-screenshot
sudo ln -s /path/to/imgur-screenshot.sh /usr/local/bin/imgurscreenshot

Now use imgurscreenshot from anywhere.
To update, simply use git pull in the imgur-screenshot directory

Wicked! Thanks!


Build on OSX

This builds on OS X now. Is untested.

Thank you!

Could you pls upload an executable ?


Uc phenology

These are my examples, please merge so they become easier to find.

@jdries Please add a link to the overview page and to a page that explains what the individual files are about.


✨ Example with alias

This example shows how to configure custom aliases within your next.js project using babel-plugin-module-resolver.
Related to https://github.com/zeit/next.js/issues/877, https://github.com/zeit/next.js/issues/946, https://github.com/zeit/next.js/issues/1535.

We already have an example for this
https://github.com/zeit/next.js/pull/2863
https://github.com/zeit/next.js/tree/master/examples/with-absolute-imports

Ah I didn't see that.
We should link that example to those issues I've mentioned above so it'll be easier to find.

@epilande thanks!


Feature interaction for GPU Hist.

Continuation of #4488.
This PR removed the previous attempt of reusing CPU SplitEvaluator to avoid device/host memory copying during tree update, as suggested by @RAMitchell .  The downside is now the memory usage on GPU side is of size O(n_features^2) + O(n_features * n_nodes), let alone some other buffer allocations.  One possible improvement is to parse the input data during DMatrix construction to optimize sparse dataset memory usage, but that is beyond the scope of this PR.
TODOs:

[x] Fuse some kernels.
[x] Finish tests.
[x] Figure out why is it completely broken on Windows.

@RAMitchell The initialization code is quite a mess due to the fact that I need a lots of auxiliary data structures to pass all information to device.  Feel free to reach me if got stuck.
Currently I use atomic operations to save the troubles.  Later I can map each thread to one uint64_t to avoid those operations.

@RAMitchell I can try and implement a sparse set to drop the O(n_feat^2) part, based on maximum length of all interaction sets, turning it into O(n_feat * max(length)).  Although O(max(length)) == n_feat but I believe it should help a lot in practice, could you take a look at current approach before I proceed? since this optimization is just adding a look up table.
O(n_feat * n_nodes) part is still here.

Another way of expressing this is to pre-compute allowed feature interactions for each feature.
Lets use an example set of constraints:
[[0,1,2],[0,4]]
Where -> means allowed to interact with and * means any feature:
0->0,1,2,4
1->0,1,2
2->0,1,2
3->*
4->0,4

If you have this available as a data structure it does not need to change or have sets merged as you grow the tree. Have I understood this correctly, is this possible? One problem with doing this is the memory requirements of expressing large subsets increases quadratically e.g. [[0, 1, 2, 3, 4, 5...]] is not efficiently represented using my approach.
One other observation about this feature interactions business is that it is possible to input a highly redundant set of feature interactions.
[[0,1],[0,1,2],[1,2]] is the same as [[0,1,2]]
Any interaction set that exists as a subset of another set is redundant.

@RAMitchell
I created a mapping: feature -> sets it belongs to -> features in those sets.  So the memory usage should be better.  All initialization is done on CPU side then copied to device, it makes things easier.  The mapping is done on device side and fully paralleled, so computation speed should not hurt too much.

One other observation about this feature interactions business is that it is possible to input a highly redundant set of feature interactions.
[[0,1],[0,1,2],[1,2]] is the same as [[0,1,2]]
Any interaction set that exists as a subset of another set is redundant.

This is handled in the mapping, but not optimized.  I think a better document could be useful to prevent this kind of mistake.  It can happen since I have to dig through the source code to understand exact behaviour of this constraint. (And I can't memorize it even after writing the implementation).
The bit field is kept, 8 times less is still quite a save, especially for large trees.  If we encounter any obscured bugs of it in the future then I will just replace it with a boolean vector.

What do you think about combining this with monotone constraints into a class implementing similar methods to SplitEvaluator? It shares the need to log tree structure after applying splits.

Let me think about it, see how many code they can share.

Another question: do you think the amount of code, tests an additional complexity for the bitfield justifies the 8x space savings? Is this space saving likely to matter in practice?

It's really due to the fact that I can't run XGBoost with the URL dataset, many of my recent effort including looking at DMatrix and CPU histogram are with that dataset in mind.  So every time an allocation depends on number of features I got sweaty.  If we can introduce some form of compressed dataset, I will happily remove the bit field class.

@RAMitchell I think the two constraints are quite different regarding:

Interaction constraint doesn't need to be passed into split evaluation kernel, monotonic constraint does.
Interaction constraint accept a list, then return another list of features.  Monotonic constraint compute scores feature by feature.
They both record the tree structure, but interaction constraint records the id of feature attached to nodes, while monotonic records values.

I will try to unify GPU constraints in another PR, but I don't think I can design a good interface without moving other constraints around first.  So I want this PR to focus on making interaction constraint work without touching other code (It's quite complicated already).

Finally. ;-)
Thanks @RAMitchell .

Please document this also.

https://xgboost.readthedocs.io/en/latest/tutorials/feature_interaction_constraint.html?highlight=interaction also needs to get updated @trivialfis. Great work!

@RAMitchell @datametrician Will document it along with some more details in another PR.  I'm thinking how to express the exact detail of interaction constraint.  As commented above, I only know these by digging through the original implementation.

I got a segfault somewhere making sphinx doc ...

Looks like tests are failing at head?
$ ./testxgboost --gtest_filter=FeatureInteractionConstraint.Query
Note: Google Test filter = FeatureInteractionConstraint.Query
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from FeatureInteractionConstraint
[ RUN      ] FeatureInteractionConstraint.Query
/home/rou/src/xgboost/tests/cpp/tree/test_constraints.cu:225: Failure
Expected equality of these values:
  h_output.size()
    Which is: 1
  solution.size()
    Which is: 2
/home/rou/src/xgboost/tests/cpp/tree/test_constraints.cu:225: Failure
Expected equality of these values:
  h_output.size()
    Which is: 3
  solution.size()
    Which is: 4
/home/rou/src/xgboost/tests/cpp/tree/test_constraints.cu:225: Failure
Expected equality of these values:
  h_output.size()
    Which is: 0
  solution.size()
    Which is: 1
/home/rou/src/xgboost/tests/cpp/tree/test_constraints.cu:225: Failure
Expected equality of these values:
  h_output.size()
    Which is: 0
  solution.size()
    Which is: 1
[  FAILED  ] FeatureInteractionConstraint.Query (360 ms)
[----------] 1 test from FeatureInteractionConstraint (360 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (360 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] FeatureInteractionConstraint.Query

 1 FAILED TEST

@rongou That's weird. The test is passing in the CI: https://xgboost-ci.net/blue/organizations/jenkins/xgboost/detail/master/251/pipeline/205

What kind of gpu is used on the ci worker? I have two Titan V's on my desktop. It's also failing for @sriramch who is using T4.

@rongou @sriramch I'm running gtx 1080 and 1080 TI.

Is the error deterministic? If not, then @RAMitchell got a point maybe I should try removing the bit field.

It fails consistently on my desktop.

@rong  How about other tests:
 --gtest_filter='Feature*';
 --gtest_filter='BitField*';

I have an idea now.  Will open a new PR for testing.


Investigate what can be done to speed up builds

building the dynamic provisioner is slow because it pulls in lots of kubernetes source code..
why are we rebuilding it every time even though the code changes rarely?
can we cache the build if the code doesn't change?

related: https://github.com/dotmesh-io/dotmesh/issues/298

we can probably speed up our builds by using go1.10 build caching
https://golang.org/doc/go1.10#build
https://groups.google.com/forum/#!msg/golang-dev/qfa3mHN4ZPA/X2UzjNV1BAAJ
Part of epic https://github.com/dotmesh-io/dotmesh/issues/296


Change purchase status text

v.2.0.6
Paid orders should display as "Paid (cancel)" instead of just "Cancel"

+1 this would be helpful

This would require a server change. The client does not have the data at this point to know whether that order is fully funded or not. @morebrownies If you think this is high priority enough, please feel free to log a server bug requesting a fullyFunded boolean to be added to the purchases api.

Thanks @rmisio
I added the issue here: https://github.com/OpenBazaar/OpenBazaar-Server/issues/


conversion of xsd patterns like IsBasicLatin to java

xsd supports unicode pattern names such as IsBasicLatin where as in Java they are name slightly different: InBasicLatin
The generated code thus is not compiling due to incorrect pattern.

I went bit deep into this issue by looking into how Java Pattern treats such unicode notations. Java expects In as prefix for blocks and Is for scripts such as LATIN, GREEK etc. Where as xsd seems to indicate all to start with Is as prefix
All blocks: https://www.unicode.org/Public/UNIDATA/Blocks.txt
It may be interesting to see if there is a direct way to detect blocks. Below is the code snippet from Pattern class :
if (name.startsWith("In")) {
                // \p{InBlockName}
                p = CharPredicates.forUnicodeBlock(name.substring(2));
            } else if (name.startsWith("Is")) {
                // \p{IsGeneralCategory} and \p{IsScriptName}
                String shortName = name.substring(2);
                p = CharPredicates.forUnicodeProperty(shortName, has(CASE_INSENSITIVE));
                if (p == null)
                    p = CharPredicates.forProperty(shortName, has(CASE_INSENSITIVE));
                if (p == null)
                    p = CharPredicates.forUnicodeScript(shortName);
            }


Remove statement excluding samd51j from i2s peripheral

Summary
Removes a statement excluding the samd51j from i2s peripheral. The samd51j series of chips supports i2s. Source
Checklist

[x] CHANGELOG.md for the BSP or HAL updated
[x] All new or modified code is well documented, especially public items
[x] No new warnings or clippy suggestions have been introduced - CI will deny clippy warnings by default! You may #[allow] certain lints where reasonable, but ideally justify those with a short comment.

@FriederHannenheim looking back at the datasheet, SAMD51J indeed does have I2S, whereas the SAMD51G variants do not. Would you mind updating the PR to that effect?


Writes Fail due to Column Mismatch

When writing out new ConceptMaps to an existing table, there can be an exception on column data-type mismatches:
An error occurred while calling o214.writeToDatabase.
: org.apache.spark.sql.AnalysisException: cannot resolve '`useContext`' due to data type mismatch: cannot cast array<struct<id:string,code:struct<id:string,system:string,version:string,code:string,display:string,userSelected:boolean>,valueQuantity:struct<id:string,value:decimal(12,4),comparator:string,unit:string,system:string,code:string>,valueRange:struct<id:string,low:struct<id:string,value:decimal(12,4),comparator:string,unit:string,system:string,code:string>,high:struct<id:string,value:decimal(12,4),comparator:string,unit:string,system:string,code:string>>,valueCodeableConcept:struct<id:string,coding:array<struct<id:string,system:string,version:string,code:string,display:string,userSelected:boolean>>,text:string>>> to array<struct<id:string,code:struct<id:string,system:string,version:string,code:string,display:string,userSelected:boolean>,valueCodeableConcept:struct<id:string,coding:array<struct<id:string,system:string,version:string,code:string,display:string,userSelected:boolean>>,text:string>,valueQuantity:struct<id:string,value:decimal(12,4),comparator:string,unit:string,system:string,code:string>,valueRange:struct<id:string,low:struct<id:string,value:decimal(12,4),comparator:string,unit:string,system:string,code:string>,high:struct<id:string,value:decimal(12,4),comparator:string,unit:string,system:string,code:string>>>>;;
'InsertIntoHadoopFsRelationCommand location/warehouse/ontologies.db/conceptmaps, false, [timestamp#5475], Parquet, Map(serialization.format -> 1, path -> location/warehouse/ontologies.db/conceptmaps), Append, CatalogTable(
Database: ontologies
Table: conceptmaps
Owner: hadoop
Created Time: Mon Aug 06 20:33:27 UTC 2018
Last Access: Thu Jan 01 00:00:00 UTC 1970
Created By: Spark 2.3.0
Type: MANAGED
Provider: parquet
Table Properties: [transient_lastDdlTime=1533587608]
Location: location/warehouse/ontologies.db/conceptmaps
Serde Library: org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe
InputFormat: org.apache.hadoop.hive.ql.io.parquet.MapredParquetInputFormat
OutputFormat: org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat
Storage Properties: [serialization.format=1]
Partition Provider: Catalog
Partition Columns: [`timestamp`]

On analysis it appears the Hive table schema can drift from the dynamically created Spark schema; columns can be in different orders. We can compare gists of the schemas:
Schema for a Dataset<ConceptMap> using Bunsen 0.4.5, using HAPI 3.3.0.
Schema for an existing ConceptMap table, built on a previous version of Bunsen. This schema differs from the first in column order of SourceUri/SourceReference, TargetUri/TargetReference, and useContext.valueQuantity fields (valueQuantity being in a different position is what is conveyed by the error message at the top).
Schema for a new ConceptMap table, built from the Dataset. This schema matches the first.
Even if we load the original table using Bunsen APIs
ontologies_maps = get_concept_maps(spark, "ontologies")

ontologies_maps.get_maps().printSchema()

as opposed to Spark APIs
spark.table("ontologies.conceptmaps").printSchema()

the result is still a mismatch to the Dataset<ConceptMap> we'd intend to write.
I don't think this is related to issues we've seen with Spark in the past, where we have to explicitly SELECT columns in a particular order to avoid data being written under the wrong column.
I think this is an issue related to the order the a RuntimeElement returns information about its children in the EncoderBuilder. Digging into ConceptMap.useContext.value, comparing the Encoder schema for different versions of Bunsen again, we see the differences seen at the table/dataset schema level, and if we dig more deeply into the EncoderBuilder runtime, we find that depending on the HAPI version, we get different orders in the ChoiceType children for ConceptMap.useContext.value, and those orders match the differences we see in the Dataset and table schemas.
This amounts to tables for a given STU release being subject to non-passive changes (even though updates within HAPI for an STU release should be purely passive in regards to the resources).
The simplest thing to do is to just drop/archive the tables and rebuild them with the latest Bunsen version, but this requirement might be unexpected to users while consuming Bunsen over a HAPI version on the same FHIR STU release.

I think the solution here is based on the append vs insert behavior of Spark. We make use of DataFrameWriter#insertInto throughout the codebase, which inserts based on strict column ordering, however, DataFrameWriter#saveAsTable, specifying a mode of "Append" will insert based on column name, irrespective of order.
We specify the insertion mode as "ErrorIfExists", but that may be redundant given the duplicate partition discovery we apply. Also given that FHIR will never have duplicate field names for the same in the same level of a structure, we can guarantee a unique set of column names for each Dataset struct.

The existing code assumes the HAPI API preserved order when it does not, but I don't think this will be a problem once we bring forward the 0.50-dev branch (and adopt its ordering). That branch uses the FHIR resource definition, which unambiguously specifies field ordering, and the same resource definition will produce the same field ordering independently of the version of HAPI.

This is also a problem with performing union on 2 resource datasets. UnionByName does not help either because while it will address the columns it will do nothing about the column types so if we have 2 struct columns and the structs are out of order - it will choke

I'm having this same issue too. Any updates on when the work done in the 0.5.0-dev branch will be merged in, so that FHIR resource definition is used to ensure ordering?

Any update about this issue?

The existing code assumes the HAPI API preserved order when it does not, but I don't think this will be a problem once we bring forward the 0.5.0-dev branch (and adopt its ordering). That branch uses the FHIR resource definition, which unambiguously specifies field ordering, and the same resource definition will produce the same field ordering independently of the version of HAPI.

Any update about this issue?


generate scene script changes

sh generate_scene.sh zzWaveScene
gives
sed: 1: "s/\(\/\/SCRIPT_PLACEHOL ...": unescaped newline inside substitute pattern
sed: 1: "s/\(\/\/SCRIPT_PLACEHOL ...": unescaped newline inside substitute pattern

mmm. I get the error too. It was working yesterday. let me check

sed is super picky with adding new lines, so I just removed it.


Add more constructors for LocationAnnotationNode

Add a couple more constructors for LocationAnnotationNode so you can directly construct with a CALayer or a UIView.
This provides some constructors like (location:uiView:) and (location:rasterizedUiView:) which allow you to choose if you want to convert to an image or try to directly use the view as a texture.
This also removes the annotationNode field and instead directly uses the LocationAnnotationNode's geometry, not sure if that would introduce any issues but everything seems to be OK from as far as I was able to tell.

I can't seem to figure out why, but I'm seeing different results on this branch vs master when using scaleRelativeToDistance = false for my image views. On master, it is working as expected (i.e., they aren't being scaled relative to distance), but on this PR, even with scaleRelativeToDistance = false, my views are tiny since the location is distant.

@ vihanb - can you please address the merge conflicts?

Resolved in PR #147


Connect on Chrome OS

For some reason I am totally unable to connect to Coder on my Chromebook. I can connect totally fine on my Mac Mini and Windows desktop. I am given an error about DNS. Is this because of a way that the Chrome OS handles DNS as opposed to how it works on the other desktops or is this just a weird bug for me?

I had same issue and I fixed it by changing my preferred DNS server to <IP_ADDRESS> in windows.

I know this is an older issue but I am also facing it.  Able to connect via hostname from all other devices except chromebook.  Can access via ip, but not the local hostname.

Chrome books/boxes lack the mDNS software used to discover your Pi.  On your Pi you are running Avahi which provides that function.

@CVBruce yeah i found the answer elsewhere and just ended up changing my /etc/hosts.
Thanks for the info.

There are feature requests and bugs in the Chrome OS to make it work.
If you have a google account, log in and star these: original feature request and current bug.
Currently less than 100 people have 'starred' the issue, so the developers think we don't care too much about fixing it.


Optimize Indexable#join when all elements are strings

Fixes #6634
This PR overrides Indexable(T)#join and if:

T is a String or
T is a union that contains String, and all elements are strings
then an optimized version of join is executed. In this case we can compute the total bytesize of the returned string: separator.bytesize * (array.size - 1) + array.sum(&.bytesize). This prevents potential string reallocations that happen in the default algorithm when String.build is used.

I used a slightly modified version of the code in #6634 to benchmark this:
require "benchmark"

cols = 10
rows = 1000
data = Array.new(rows) { Array.new(cols) { ("x"*1000) } }

Benchmark.ips do |x|
  x.report("doit") do
    csv = data.map { |row| row.join(",") }.join("\n")
  end
end

Before:
doit  91.19  ( 10.97ms) (± 1.70%)  75882435 B/op  fastest

After:
doit 183.46  (  5.45ms) (± 9.41%)  20050063 B/op  fastest

(note the allocated memory per op too)
In Ruby (change require "benchmark" to `require "benchmark/ips" using this gem):
                doit    117.854  (±10.2%) i/s -    585.000  in   5.030671s

So now it's faster than Ruby. Just note that if you run the original code from #6634 Crystal seems to be just a little slower than Ruby depending on the run, but a proper benchmark (Benchmark.ips) shows the real stuff.
Further optimization
There are two cases when this optimization is applied:

T is a String or
T is a union that contains String, and all elements are strings

The first one will be trivially faster than the previous one.
The second one involves an all?(&.is_a?(String)) check. I still think doing this check is faster than reallocating memory, so that's probably good. Ruby always does this check (it has no compile-time information) but while doing it it also computes the expected total bytesize, and switches to the default/slow implementation if an element is not a string. We could do the same, computing the length while checking .is_a?(String) but I think that will make the code a lot harder to read and understand, so maybe it's not worth it. But we could eventually do it if we find it's a significant performance difference (I doubt it).
Also, when there's no String in the array, the implementation is the default (slow) one.

OK, this PR got a tad bigger now. @RX14 found that I had a bug when computing a string's size. So:

I first fixed that but first checking that the sizes (and just in case bytesizes) match
I extracted a private method to do it
then I remembered we also check for size and bytesize equality for stirngs in string_spec.cr, because we manually construct strings in String
I thought about having an eq_string matcher to compare strings, adding it to the support directory and requiring it when needed, but that's bug prone: what if you compare two strings and forget to check for their bytesize and size, and you also forget to require that file from support?
so I then changed the eq matcher to always perform a bytesize and size equality when comparing strings

This actually uncovered a bug in String#gsub(Char, Char). So I think having eq do this comparison by default is good because we create such strings in the whole standard library, but anyone else is also free to use String.new in their shards and they might put incorrect values for bytesize and size there. The eq matcher got a bit more complex, and it might be just slightly slightly slower, but I'm pretty sure it's insignificant.


Powerfull, good work with 'opencv4nodejs'

Hi,
I have integrated jsQR with 'opencv4nodejs' and this works very well.
Conversion from OpenCv is :
let dstReduced = mat.resize( new cv4.Size(0,0), 0.3, 0.3);
let dstRGBA = dstReduced.cvtColor( cv4.COLOR_BGR2RGBA);
let code = jsQR( dstRGBA.getData(), dstRGBA.cols, dstRGBA.rows, undefined);

As you see, from original image (640x480), I resize image from 1/3., QrCode recognition duration changes from 1 second to 60ms.
Great again.
Best regards

Thanks! Love to hear it, and it's neat how simple of a drop in it was.
If I understand correctly, there is not actually an issue here, and as such I'm going to close this, but thanks for sharing :)


Will TextFieldBox be implemented? [Question]

Summary
There's a similar issue in #2302.
Currently, this library did not provide TextFieldBox yet. Therefore I wanted to know if the team will implement it or not. The specification can be found here.
It's appearance would look something like this :

Moreover, this design is also widely adopted in the latest Google Calendar App :

Conclusion
I hope that this component will be implemented soon, as I personally felt that it has a better UX compared to the singe-line text field.

[X] I have searched the issues of this repository and believe that this is not a duplicate.

I wanted to know if the team will implement it or not

I have no idea. We rely on people need. If someone need the component, he will implement it. Then if we are lucky, he will share the implementation with Material-UI.


Switch to pluggable widget API and restore computer widget

Switch to pluggable widget API from Jenkins core. Require 2.414.1
Also restore broken Computer widget for next executions
Planning also to display parametrized next execution and possible execution on computer has well (Was never implemented)
Testing done
Build CI and mvn hpi run

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Inspired by https://github.com/jenkinsci/next-executions-plugin/pull/21


created website

So , there are few things:

Put all md in folder with names with no spaces only underscores
All md files name should not have spaces
Css will be added later on
I will automate the website soon
Thank you

having so many html pages won't help ,you can add all in single page , accepting pr only see the changes , will revert if it's not match the requirement

hey it's uncomplete website , reverting the change

If you ommit the spaces in readme.md of all profiles then it can be a complete website. But did you really expect a whole website in a single commit ?

having so many html pages won't help ,you can add all in single page , accepting pr only see the changes , will revert if it's not match the requirement

makes sense

If you ommit the spaces in readme.md of all profiles then it can be a complete website. But did you really expect a whole website in a single commit ?

not in one commit but atleast a structure of the website for example look this - https://free-courses-with-certificates.netlify.app/   (https://github.com/avinash201199/Free-courses-with-Certificates)
it was added in a single commit.
You have added only html portion , no styling and no functionality , ish tarah se tumhe bahut jada pr banane padte website ko complete karne ke liye and important thing is that,  2,3 pr se jada ek repo mein contribute karna recommend nhi hai because vo log har pr ko review karte hai , agar bahut jada pr ek hi repo mein dekh liya tto blacklist kar sakte hai repository ko

I appreciate your effort , you can make the complete website in your local systems once it done then you can make a pr , I will accept it .

for example you can take code from here https://github.com/avinash201199/Competitions-and-Programs-List

If you ommit the spaces in readme.md of all profiles then it can be a complete website. But did you really expect a whole website in a single commit ?

not in one commit but atleast a structure of the website for example look this - https://free-courses-with-certificates.netlify.app/ (https://github.com/avinash201199/Free-courses-with-Certificates) it was added in a single commit.
You have added only html portion , no styling and no functionality , ish tarah se tumhe bahut jada pr banane padte website ko complete karne ke liye and important thing is that, 2,3 pr se jada ek repo mein contribute karna recommend nhi hai because vo log har pr ko review karte hai , agar bahut jada pr ek hi repo mein dekh liya tto blacklist kar sakte hai repository ko

oh ye pata nhi that mujhe thanks

If you ommit the spaces in readme.md of all profiles then it can be a complete website. But did you really expect a whole website in a single commit ?

not in one commit but atleast a structure of the website for example look this - https://free-courses-with-certificates.netlify.app/ (https://github.com/avinash201199/Free-courses-with-Certificates) it was added in a single commit.
You have added only html portion , no styling and no functionality , ish tarah se tumhe bahut jada pr banane padte website ko complete karne ke liye and important thing is that, 2,3 pr se jada ek repo mein contribute karna recommend nhi hai because vo log har pr ko review karte hai , agar bahut jada pr ek hi repo mein dekh liya tto blacklist kar sakte hai repository ko

oh ye pata nhi tha mujhe thanks

If you ommit the spaces in readme.md of all profiles then it can be a complete website. But did you really expect a whole website in a single commit ?

not in one commit but atleast a structure of the website for example look this - https://free-courses-with-certificates.netlify.app/ (https://github.com/avinash201199/Free-courses-with-Certificates) it was added in a single commit.
You have added only html portion , no styling and no functionality , ish tarah se tumhe bahut jada pr banane padte website ko complete karne ke liye and important thing is that, 2,3 pr se jada ek repo mein contribute karna recommend nhi hai because vo log har pr ko review karte hai , agar bahut jada pr ek hi repo mein dekh liya tto blacklist kar sakte hai repository ko

oh ye pata nhi tha mujhe thanks

it's okay you can contribute in other repo's as well
List of some Github Repositories to contribute in Hacktoberfest
1- https://github.com/avinash201199/Competitions-and-Programs-List
2- https://github.com/avinash201199/Free-courses-with-Certificates
3- https://github.com/avinash201199/Paid-Internship-List
4- https://github.com/avinash201199/weather-app
5- https://github.com/avinash201199/stopwatch
6- https://github.com/avinash201199/To-Do-List
7- https://github.com/avinash201199/Portfolio-Collection

thanks you very much