The minimum price logic when creating/editing a listing seems to be over estimating the minimum price

Currently it's saying I can't list an item for less than $1.16. The current bitcoin fees are probably around 5 cents right now so I'm not sure where $1.16 is coming from. Seems like there is a bug in the logic.

It's not a bug, we decided to set it to 0.002BTC to make sure the transaction goes through.

The issue is we have to set it to some arbitrary amount, since we don't have a way of dynamically detecting what the lower limit should be, so we'll have to continuously update this as prices and the network change.
It'd be nice to have a better way to handle it.

We may want to go back to the drawing board on this one and consider alternative approaches. The main problem is I can't update my listings without raising the price.

The theory is if your prices are in fiat, and the BTC to fiat exchange rate goes up, you need to raise the prices or when people try to buy your products the transaction will fail or never resolve (or take a very long time to resolve). We set the minimum higher than the actual point at which they fail to provide a little buffer against price fluctuations.
There's a ticket to make listings in fiat prices that are below the minimum price unbuyable, to prevent people from getting purchases stuck in limbo.
We should also have a way to notify the vendor if their listings drop below the minimum price, so they can update them.
If we take out the minimum, then we'd need a better way to deal with listings with prices that are too low.

Let's consider using a service like https://bitcoinfees.21.co/api to get a constantly updated number, and base it off of a transaction size of 400 bytes.
For now I'll move the minimums by a decimal place, it was probably a typo when we set it up.

Maybe it's a good idea to follow the reference bitcoin client
https://github.com/bitcoin/bitcoin/blob/28ad4d9fc2be102786a8c6c32ebecb466b2a03dd/src/primitives/transaction.h#L161

This has been fixed. In the future we may set the minimum price dynamically.


YouTube Playlist Save

Is your feature request related to a problem? Please describe.
Save YouTube Playlist
Describe the solution you'd like.
.
Describe alternatives you've considered.
.
Add any other context or screenshots about the feature request here.
No response

can you please elaborate this issue, saving a playlist as in?


lineStyle/lineProp not working

Describe the bug
I tried to highlight specific lines following the example on the page but neither of the props worked..
To Reproduce

                            <SyntaxHighlighter
                                wrapLines={true}
                                showLineNumbers
                                language="javascript"
                                style={docco}
                                lineStyle={(lineNumber) => { const style = { display: 'block', color: '#ff0000' };return style; }}
                            >
                                {this.state.code}
                            </SyntaxHighlighter>

Expected behavior
I was expecting the color change to red.
Screenshots

However if I use the same code with the lineNumberStyle prop  works.

Desktop (please complete the following information):

OS: Ubuntu 18
Chrome

Believe it's been changed to lineProps. Try changing it to that and returning an object like { style: { display: 'block', color: '#ff0000' }}

@samselikoff @carlosmiei
yeah, it was changed to lineProps even when in the documentation and the typescript file say it is still available.


Add health and availability services in configs

Coverage remained the same at 96.639% when pulling 0f8dc2c2aa6f00e20a48da57291f690761e15ebb on service-definition into a209151524cb82b05a693ae7b6872c7f27c7ab50 on master.

Coverage remained the same at 95.161% when pulling 945a146115f949a97fb8c9a547337ed636ee41c3 on service-definition into a8d54159230a8f40c3c8b6f305e3d5f4b2425dee on master.


Updated with SME content changes

@alkohli

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Onboarding should allow updating the Apple ID

New Issue Checklist

[ ] Updated fastlane to the latest version
[ ] I read the Contribution Guidelines
[ ] I read docs.fastlane.tools
[ ] I searched for existing GitHub issues

Issue Description
This just happened to me. I had a typo in my Apple ID and the fastlane init couldn't log in and asked if I want to try with a new password. But I needed to try with a new Apple ID instead.
Complete output when running fastlane, including the stack trace and command used

[INSERT OUTPUT HERE]

Environment

[INSERT OUTPUT HERE]

Bot, please, don't 😢


Inverter Model Typo

The Sandia inverter model implementation in SAM appears to have a typo with one of the coefficients, see description here: https://sam.nrel.gov/forum/forum-general/3844 . Just examined documentation and confirmed issue.

I concur, it's an error - line 424 should be using "C * (Pdc[m] - B) * (Pdc[m] - B)" not "C0 * ..."


[Event Request] Codeunit 99000836 Transfer Line-Reserve - TransferWhseShipmentToItemJnlLine "OnTransWhseShptToItemJnlLineOnAfterGetWhseItemTrkgSetup"

Can we please get the following event?
    procedure TransferWhseShipmentToItemJnlLine(var TransLine: Record "Transfer Line"; var ItemJnlLine: Record "Item Journal Line"; var WhseShptHeader: Record "Warehouse Shipment Header"; TransferQty: Decimal)
    var
        OldReservEntry: Record "Reservation Entry";
        WhseShptLine: Record "Warehouse Shipment Line";
        WarehouseEntry: Record "Warehouse Entry";
        WhseItemTrackingSetup: Record "Item Tracking Setup";
        ItemTrackingMgt: Codeunit "Item Tracking Management";
        QtyToHandleBase: Decimal;
    begin
        if TransferQty = 0 then
            exit;
        if not FindReservEntry(TransLine, OldReservEntry, Direction::Outbound) then
            exit;

        ItemJnlLine.TestField("Location Code", TransLine."Transfer-from Code");
        ItemJnlLine.TestField("Item No.", TransLine."Item No.");
        ItemJnlLine.TestField("Variant Code", TransLine."Variant Code");

        WhseShptLine.GetWhseShptLine(
          WhseShptHeader."No.", DATABASE::"Transfer Line", 0, TransLine."Document No.", TransLine."Line No.");

        OldReservEntry.Lock;
        if ReservEngineMgt.InitRecordSet(OldReservEntry) then
            repeat
                OldReservEntry.TestItemFields(TransLine."Item No.", TransLine."Variant Code", TransLine."Transfer-from Code");
                ItemTrackingMgt.GetWhseItemTrkgSetup(TransLine."Item No.", WhseItemTrackingSetup);

                OnTransWhseShptToItemJnlLineOnAfterGetWhseItemTrkgSetup(TransLine, WhseItemTrackingSetup); <-- NEW EVENT

                WarehouseEntry.SetSourceFilter(
                  OldReservEntry."Source Type", OldReservEntry."Source Subtype",
                  OldReservEntry."Source ID", OldReservEntry."Source Ref. No.", false);
                WarehouseEntry.SetRange("Whse. Document Type", WarehouseEntry."Whse. Document Type"::Shipment);
                WarehouseEntry.SetRange("Whse. Document No.", WhseShptLine."No.");
                WarehouseEntry.SetRange("Whse. Document Line No.", WhseShptLine."Line No.");
                WarehouseEntry.SetRange("Bin Code", WhseShptLine."Bin Code");
                WhseItemTrackingSetup.CopyTrackingFromReservEntry(OldReservEntry);
                WarehouseEntry.SetTrackingFilterFromItemTrackingSetupIfRequired(WhseItemTrackingSetup);
                WarehouseEntry.CalcSums("Qty. (Base)");
                QtyToHandleBase := -WarehouseEntry."Qty. (Base)";
                if Abs(QtyToHandleBase) > Abs(OldReservEntry."Qty. to Handle (Base)") then
                    QtyToHandleBase := OldReservEntry."Qty. to Handle (Base)";

                if QtyToHandleBase < 0 then begin
                    OldReservEntry.CopyNewTrackingFromReservEntry(OldReservEntry);
                    OldReservEntry."Qty. to Handle (Base)" := QtyToHandleBase;
                    OldReservEntry."Qty. to Invoice (Base)" := QtyToHandleBase;

                    TransferQty :=
                      CreateReservEntry.TransferReservEntry(
                        DATABASE::"Item Journal Line",
                        ItemJnlLine."Entry Type".AsInteger(), ItemJnlLine."Journal Template Name",
                        ItemJnlLine."Journal Batch Name", 0, ItemJnlLine."Line No.",
                        ItemJnlLine."Qty. per Unit of Measure", OldReservEntry, TransferQty);
                end;
            until (ReservEngineMgt.NEXTRecord(OldReservEntry) = 0) or (TransferQty = 0);
    end;

    [IntegrationEvent(false, false)]
    local procedure OnTransWhseShptToItemJnlLineOnAfterGetWhseItemTrkgSetup(TransLine: Record "Transfer Line"; var WhseItemTrackingSetup: Record "Item Tracking Setup")
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Fail with error 'SafeERC20: low-level call failed'

https://etherscan.io/tx/0xc0216471231a9a8c41a8f217f97a725e948a9c6161c46510815fc917bf1ffdce

They had 0.348971 USDT and it was an attempted mint for 389.348971 USDT. Noting it looks like they just took the value from the max input and jammed 389 in front of it. I don't see a way to do that with the UI and still submit the transaction so I'd be inclined to chalk this up to a manual contract interaction and close it.


What about Noun phrases mentions?

Hello everyone,
I see that this model is trained to only deal with single words, Does its architecure not based on span representation?
Sometimes a mention is composed of several words and not with one word; can anyone please explain to me this issue ?

Hello,
The data model is indeed based on tokens which
You should be able to retrieve the span corresponding to the tokens by using the subtree , for instance :
mention = doc[token.left.i:token.right.i]
Although it is dependeng on spacy's parse tree (so not necessarily totally accurate) and you should do some tweaking to add some extra rules to include or exclude some parts of the subtree. Here is an example of what I did for french to achieve this, getting inspiration from this for english should not be too difficult.


Adding picture in picture

Summary
So when you swipe out of app it enables picture in picture. Thanks
Please confirm the following

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.

Available on Release 1.7.5


feat(SPV-1214): add contact filter for admin

This pull request focuses on updating the admin contact search functionality to use AdminContactFilter and AdminSearchContacts instead of the previous ContactFilter and SearchContacts. The changes also include updates to the documentation to reflect these new filters.

Pull Request Checklist

[x] 📖 I created my PR using provided  : CODE_STANDARDS
[x] 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
[x] 🏠 I tested my changes locally.
[ ] ✅ I have provided tests for my changes.
[x] 📝 I have used conventional commits.
[ ] 📗 I have updated any related documentation.
[ ] 💾 PR was issued based on the Github or Jira issue.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 45.80%. Comparing base (334c8f5) to head (0e49ad7).

Files with missing lines
Patch %
Lines

models/filter/contact_admin_filter.go
0.00%
8 Missing :warning:

actions/admin/contact.go
0.00%
1 Missing :warning:

actions/admin/contact_old.go
0.00%
1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   45.85%   45.80%   -0.06%
==========================================
  Files         365      366       +1
  Lines       17786    17794       +8
==========================================
- Hits         8156     8150       -6
- Misses       9027     9039      +12
- Partials      603      605       +2

Flag
Coverage Δ

unittests
45.80% <0.00%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

docs/docs.go
0.00% <ø> (ø)

actions/admin/contact.go
0.00% <0.00%> (ø)

actions/admin/contact_old.go
0.00% <0.00%> (ø)

models/filter/contact_admin_filter.go
0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 334c8f5...0e49ad7. Read the comment docs.


Status Message: Private endpoint network policies cannot be enabled on private endpoint subnet

Bicep version
run bicep --version via the Bicep CLI or via VS code by navigating to the extensions tab and searching for Bicep
Bicep CLI version 0.3.126 (a5e4c2e567)
Describe the bug
A clear and concise description of what the bug is vs what you expected to happen
When running and incremental deployment of an AKS private cluster, deployment fails and returns
"Status Message: Private endpoint network policies cannot be enabled on private endpoint subnet"
using Microsoft.ContainerService/managedClusters@2021-02-01 with
To Reproduce
Steps to reproduce the behavior:
build a bicep file to deploy a private cluster, and after it has finished deploying, run the deployment again to see the error.
Additional context
attached is the bicep file I have been using.
PrivAKS.txt

This looks to be an RP specific issue, not a bicep issue. Are you able to open a support case and/or get in touch with the AKS team to get this resolved? Closing for now, but please let us know if you are not able to get traction on the resolution. From the error, it looks like what you are trying to do with private endpoints is not allowed. Did you grab this code from somewhere or write it yourself?


'WindowsPath' object has no attribute 'lstrip'

When I tried passing an address and check that the file existed in OS Windows 10, the following error apears:
'WindowsPath' object has no attribute 'lstrip'
@click.command()
@click.argument('input_filepath', type=click.Path(exists=True))
def main(input_filepath):
    pass

if __name__ == '__main__':
    main("C:/Development/test.csv")

I debugged the click code and the error have raised in line 611 at core.py. I tried to apply str() function but other erros have raised.
Environment:

OS: Windows 10
Python version: 3.8
Click version: 8.1.3

Calling a CLI takes a list of parameters, not a string. main(["test.csv"]).


Creating an isOutlook option for the object

Creating an outlook flag to pass to the mocking object in order to bypass the need for a property wait for load and sync calls.
Previous to this commit, a property assigned in the constructor of OfficeAddinMock would always require a load call, which is not needed for Outlook.
Solves this issue: https://github.com/OfficeDev/Office-Addin-Scripts/issues/587

Are you sure this is not needed across the board for Outlook?  It might be worth it to check with the others who are more familiar with Office.js.

Are you sure this is not needed across the board for Outlook? It might be worth it to check with the others who are more familiar with Office.js.

I was pretty certain that sync and load are not needed in Outlook, but yeah, I'm not 100% sure this goes for all their APIs (there are a lot of them for me to look at).
I looked at the  Outlook API reference and it doesn't mention either sync or load and that's where I'm coming from.

@millerds I just added the host option, so the PR is ready to be reviewed


bug in pmag_gui

I'm using pmag_gui and tried converting an SIO format file to magic.  this works fine.  but then on the 'next step', i get this bug:
File "/Users/ltauxe/Programs/PmagPy/GIT/PmagPy/dialogs/pmag_basic_dialogs.py", line 240, in on_okButton
if ipmag.combine_magic(files, 'magic_measurements.txt'):
File "/Users/ltauxe/Programs/PmagPy/GIT/PmagPy/pmagpy/ipmag.py", line 1612, in combine_magic
pmag.magic_write(outfile,Recs,file_type)
File "/Users/ltauxe/Programs/PmagPy/GIT/PmagPy/pmagpy/pmag.py", line 1422, in magic_write
os.mkdir(os.path.split(ofile)[0])
OSError: [Errno 2] No such file or directory: ''
File  /Users/ltauxe/Dropbox/4Christeanne/Aged_Thellier_III/FreshTRM_III.mag.magic  read in with  1126  records
1126  records written to file  magic_measurements.txt
Traceback (most recent call last):
File "/Users/ltauxe/Programs/PmagPy/GIT/PmagPy/dialogs/pmag_basic_dialogs.py", line 240, in on_okButton
if ipmag.combine_magic(files, 'magic_measurements.txt'):
File "/Users/ltauxe/Programs/PmagPy/GIT/PmagPy/pmagpy/ipmag.py", line 1612, in combine_magic
pmag.magic_write(outfile,Recs,file_type)
File "/Users/ltauxe/Programs/PmagPy/GIT/PmagPy/pmagpy/pmag.py", line 1422, in magic_write
os.mkdir(os.path.split(ofile)[0])
OSError: [Errno 2] No such file or directory: ''
Is this because I'm in a Dropbox folder?

Hey @ltauxe, I went ahead and patched this because I think that's actually a line of code in magic_write which is causing the problem and I managed to quickly recreate the problem on my computer. I added a check that fixed it over here. Let me know if you still have the bug by reopening the github issue.


Changes to use typeorm version 0.3.x

Description
Changes to use typeorm version 0.3.x

Removal of obsolete functions
Change to use DataSource
Creating a new parameter to force the type of entity used
Creation of the useConnection method to define the DataSource in the Container

Checklist

[X] the pull request title describes what this PR does (not a vague title like Update index.md)
[X] the pull request targets the default branch of the repository (develop)
[X] the code follows the established code style of the repository

npm run prettier:check passes
npm run lint:check passes

[ ] tests are added for the changes I made (if any source code was modified)
[X] documentation added or updated
[X] I have run the project locally and verified that there are no errors

Fixes
fixes #66

Thanks for working on this! I was waiting for this update! Hope it gets merged soon!

Thanks for working on this PR. Any timeline for when this PR is going to get merged?

Thanks for this much needed PR. We are also waiting for this PR to be merged. Any idea, by when the last subtask would be done?

Any updates on when this PR gonna be merged?

Any update?


Change URL to login form documentation

Although http://symfony.com/doc/current/cookbook/security/form_login.html is a valid url, I think http://symfony.com/doc/current/cookbook/security/form_login_setup.html is more applicable here.

Much better link! Thanks @xelaris


install-nlp-deps: use the new numpy precached embeddings

The mmap-embeddings branch was merged to decanlp, which changes
the on-disk caching format for embeddings.
This is in turn causes our tests to fail as we try to download
too much and Travis gets upset.

The matrix.org servers are down, which means we cannot install olm, a required dependency of thingengine-core. That is, no tests for thingengine-core or almond-cloud today.
headdesk

Pull Request Test Coverage Report for Build 797

0 of 0   changed or added relevant lines in 0 files are covered.
241 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.02%) to 60.064%

Files with Coverage Reduction
New Missed Lines
%

util/user.js
16
70.27%

routes/my_api.js
60
61.17%

routes/thingpedia_developer_console.js
65
21.29%

routes/user.js
100
42.0%

Totals

Change from base Build 781:
0.02%

Covered Lines:
4593

Relevant Lines:
7151

💛  - Coveralls


Add navigation tutorial links inside class doc

Adds navigation tutorial links inside the class doc to the related and more detailed godot-docs pages for better visibility.

Looks good, but half of the titles don't seem to match the page being linked.

Well, should have also used the save button.


XRP

Thank you very much for everything.
A suggestion, you could put "XRP" as "Ripple".

The coins are named as they appear on the Coinbase API, and this list is auto-generated, so making manual updates to the coin names would be overwritten by the auto-generated list. I have thought about maintaining a list of overrides, which could allow us to assign some "nicknames" to the coins, but I don't have a lot of extra time to maintain or curate this list.


error message after successful (?) hossted register

Registration seems to succeed, instance displays on dashboard, but getting an "empty session token" error
azureuser@wordpress:~$ hossted register
Email<EMAIL_ADDRESS>Registering user. Please wait a second.
Empty Session Token. Some kind of error occoured - {"msg":"Your registration is successful.","jwt":null,"url":"https://app.hossted.com","success":true}.

issue is caused because jwt is null. @liorkesos we should check with Yitzhak

we'll be fixing in the server side, no change required in the CLI


Add IP address information

Hi, I wanted to ask if it was possible to add the ip address of the sonoff in the attributes of the entities (example Sonoff Mini).
Thank you

Hi!
Same request.
I have different subnets for Wi-Fi 2GHz, Wi-Fi 5GHz and wired LAN devices.
Sonoff devices and HA server are in different subnets.
Multicast traffic is not routable
That's why mDNS doesn't work for me.

@issinsky specifying the IP address will not help. All local protocol is built on mDNS. You need to use cloud control.

If I know the IP address it is enough to send API commands to get the state and to switch it on/off. Firmware 3.5.0 doesn't request to send deviceid in request.

Many devices with firmware less than 3.5.
They do not have a command to query the device status.
I have never seen it work.
But I'll check. I have a D1 on firmware 3.5 and a Mini on firmware 3.6
But getting a status using the pull method is not real-time. This will not work well.

I see. Thank you for details.

The original request is another...
I need, if is possible, to get ip address information  for example in one switch attributes

The original request is another...
I need, if is possible, to get ip address information  for example in one switch attributes

Hi
You can add in Configuration.yaml
sonoff:
sensors: [ host ]
Reboot HA And you can see a New sensor with the IP of each devices.
Regards

The original request is another...
I need, if is possible, to get ip address information  for example in one switch attributes

Hi You can add in Configuration.yaml
sonoff: sensors: [ host ]
Reboot HA And you can see a New sensor with the IP of each devices.
Regards

this works very well. thx

Supported in latest version


ExtendedXmlSerializer.Legacy

So I am looking at the Configuration API now.  I think you mentioned you did this, but the Legacy configuration was moved from legacy into v2 root.
The point of Legacy was to have it there in case people wanted to migrate their XML from v1 to v2.
But now I am thinking, maybe we should have an ExtendedXmlSerializer.Legacy nuget for this.
So we can take the Legacy out, and put it in this new package, along with tests.  It would help make it less confusing?  What do you think?

Actually, tests would not go into the nuget package.  But we would make a ExtendedXmlSerializer.Tests.Legacy project that are the tests for ExtendedXmlSerializer.Legacy.

It's not true.
Old configuration is ExtendedXmlSerialization.Legacy.ExtendedXmlSerializerConfig
New configuration is in ExtendedXmlSerialization.Configuration namespace.
New configuration has tests too in ExtendedXmlSerialization.Test.Configuration.
New configuration isn't used in Legacy code.
It is great idea to separate new code from old.
Names is good: ExtendedXmlSerializer.Legacy and EtendedXmlSerializer.Tests.Legacy.
After deploy v2 people will need to change nuget package or update theirs code to new version.

New Configuration ExtendedXmlSerialization.Configuration I created only for version 2.

Ahhhhh then it seems I got my code switched around, haha.  Alright, cool, yeah I must have gotten some wires crossed as I thought I saw some Legacy  code referencing v2 contracts.  I will keep an eye out as I dive through this.

This is now done per #81.  Please note that I changed the default namespace for ExtendedXmlSerializer from ExtendedXmlSerialization to ExtendedXmlSerializer.  This works well because the ExtendedXmlSerializer.Legacy project is ExtendedXmlSerialization.
Also note that I have updated the test projects so that they are consistent in the format of ExtendedXmlSerializer.Tests.*

Namespace ExtendedXmlSerializer isn't good idea.
If you want create ExtendedXmlSerializer() without configuration. in your code you have to write:
new ExtendedXmlSerializer.ExtendedXmlSerializer() because name of class is the same as namespace.
In XmlSerializer is the same situation, that is why the namespace is System.Xml.Serialization.
But if it isn't true this name is ok for me.

Ah but you cannot directly create an ExtendedXmlSerializer from code starting in v2, correct?  It is internal now, and the only way you can create it is through ConfigurationAPI.  Let me know if I have this wrong.

I see where the confusion is... ExtendedXmlSerializer is public still.  I was going to make it internal for #70, along with all the other classes for this task.

Ok. great!


[Nightly] Tapbacks don't send to really old chats

I tried to send a tapback to a chat that hadn't had a message sent in it for about four months but it wouldn't go through and it stopped me from being able to send tapbacks to other chats

@CSab6482 should i close this

@CSab6482 should i close this

No, I just attempted to send a tapback to a group chat from April 11, 2021, and it didn't go through. The terminal doesn't give much information.

The disconnect happened because I clicked a notification from another app.


Bug 1948714: IBM Cloud manifest profile patch

Part 2 of cluster profiles support for IBM Cloud.
Introduces a directory that will contain profile-specific patches.
Profile-specific manifests are generated with 'make profile-manifests'
and 'hack/verify-profile-manifests.sh' (called by 'make verify') verifies
that the manifests directory is up to date.
On IBM Cloud the Image Registry operator needs to run on worker nodes, thus the
master node selector needs to be removed from the operator deployment
manifest.

/hold
This should only merge when profiles support has been turned on in the CVO

/remove-lifecycle stale

@dmage I've now updated this PR to bump to the latest build-machinery-go and I'm now using that add a patch for ibm-cloud-managed.

/retest

/assign @ricardomaraschini

/hold

/retest

/hold cancel

/unhold

/retest

/bugzilla refresh

/retest


make UI consistent across draft up and draft connect

todo for myself after initial draft connect PR is merged

@michelleN think we can close this? The draft * [--environment e] UX where we read information from draft.toml to retrieve the app name has been pretty slick IMO.


AttributeError: 'NoneType' object has no attribute 'headers'

$ wafw00f http://balancepayout.paypal.com
Traceback (most recent call last):
  File "/usr/local/bin/wafw00f", line 4, in <module>
    __import__('pkg_resources').run_script('wafw00f==2.1.0', 'wafw00f')
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 658, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 1438, in run_script
    exec(code, namespace, namespace)
  File "/usr/local/lib/python3.6/dist-packages/wafw00f-2.1.0-py3.6.egg/EGG-INFO/scripts/wafw00f", line 8, in <module>
    main.main()
  File "/usr/local/lib/python3.6/dist-packages/wafw00f-2.1.0-py3.6.egg/wafw00f/main.py", line 442, in main
    if attacker.genericdetect():
  File "/usr/local/lib/python3.6/dist-packages/wafw00f-2.1.0-py3.6.egg/wafw00f/main.py", line 142, in genericdetect
    attackresponse_server = response.headers.get('Server')
AttributeError: 'NoneType' object has no attribute 'headers'

Verified that is a bug. Will shortly push a fix to this.

Verified that is a bug. Will shortly push a fix to this.

This was an interesting case, when using HTTPS, the error never came up, but on HTTP this behavior is reproducible. Was an important fix.
Thank you @m4ll0k for pulling this up!

This was an interesting case, when using HTTPS, the error never came up, but on HTTP this behavior is reproducible. Was an important fix.
Thank you @m4ll0k for pulling this up!


single resolve documentId undefined -> now returns null

Hi,
All in the title. @Apollinaire @SachaG let me know if it is okay. Here is how I intend to update the doc:
Single Resolver
"The single resolver takes a documentId argument, and should return a single document. If no documentId is provided or the id does not match any existing document, it should either return null or throw an error depending on your use case.
If you need to get only one element but you don't know its id, for example to display the last article on your website, the preferred pattern is to use withMulti with a limit of 1."
Edit: I tend to have ugly merge commit, any idea how to avoid this?

Looks good to me!


Scripts with newline characters are not processed as expected in exported builds

Summary
It was discovered that string newlines (e.g. \n) in script tags get evaluated in an unexpected way when importing exported components. For example, this:
<long-content>
  <template shadowrootmode="open">
    <slot></slot>
  </template>
  <script td-method="connectedCallback">
    this.textContent.split('\n');
  </script>
</long-content>

becomes this on export:
// ... tram-deco minified code

importTemplate.setHTMLUnsafe(`<long-content>
	<template shadowrootmode="open">
		<slot></slot>
	</template>
	<script td-method="connectedCallback">
		this.textContent.split('\n');
	</script>
</long-content>
`)

// ... definition of the component

which looks like this at runtime:

		this.textContent.split('
');

We should do something to better preserve special text characters on export.

Resolved in v6.1.1


Update catchability section with env Q

See ss3-source-code PR #596 and issue #595.
@Rick-Methot-NOAA Can you make sure the extra parameters table example looks okay?
@iantaylor-NOAA Could you take a look just to make sure it all makes sense?

@iantaylor-NOAA could you take a quick look at this just to make sure everything makes sense?

Looks good regarding my requested change.
Acknowledging Ian's additional comments.

@iantaylor-NOAA they should be lettered now. I added another condition to the github action that adds the artifacts because I think it was only adding them on the initial PR, not on subsequent pushes but hopefully what I added will get it adding the artifacts on pushes.


Update go.mod to specify the module is go1.14

Thus the go commands will default to -mod=vendor
See: https://golang.org/doc/go1.14#go-command

/approve
/lgtm

Note - integration tests didn't run properly - a fix is here: https://github.com/knative/serving/pull/8150
knative.dev/serving/test/conformance/ingress	[no test files]\u0026#xA;

Kourier fix: https://github.com/knative/net-kourier/pull/89


Implement cameCase for Kube entities

formated and linted nls properties file
added camelCase for kibernetes entities

PR needs rebase

Making another PR from main branch


ENH: Best model statistics

The highscore list should keep track of a struct that contains information on the best model. This struct should be updated whenver a new best model is inserted.

Not relevant anymore.


-moz-linear-gradient was renamed and syntax changed to linear-gradient (bug 1183084)

Fixes bug 1183084

LGTM


[ISSUE #6390] Add break to the exception of WHEEL_TIMER_NOT_ENABLE.

Make sure set the target branch to develop
What is the purpose of the change
Add break to the exception of WHEEL_TIMER_NOT_ENABLE.
fix #6390
Brief changelog
add a break into the switch.
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #6394 (77c0486) into develop (3613821) will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #6394      +/-   ##
=============================================
+ Coverage      43.07%   43.15%   +0.08%
- Complexity      8910     8927      +17
=============================================
  Files           1105     1105
  Lines          77953    77954       +1
  Branches       10144    10144
=============================================
+ Hits           33575    33642      +67
+ Misses         40167    40099      -68
- Partials        4211     4213       +2

Impacted Files
Coverage Δ

...ocketmq/broker/processor/SendMessageProcessor.java
36.29% <0.00%> (-0.10%)
:arrow_down:

... and 26 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Allowing override of the styleguide_path

This'll allows end users to userride the path used by the
MountainView::Engine.routes

I need to make some changes for hound before this is ready for merge, also any direction in how you'd like this tested? I added a TDD test, but I think something closer to an integration would serve it better.

@MikeRogers0 Thanks a lot for the PR! Looks really good!
As you said, it would be really nice to have an integration test when setting the styleguide_path to something different. You already added one for the default case (🎉 ), and would be great to have another one for a custom path.
Thanks again! Really appreciate your great work!

would be great to have another one for a custom path.

@kitop BAM

@MikeRogers0 Amazing!!! And thanks so much for the contribution!!
Merging this and releasing a new version :)


Support Progress

Describe the feature
Now that https://github.com/scalameta/metals/pull/6055 is merged we should consider fully switching over to the LSP progress method way of doing this. nvim-metals always supported a subset of Metals status so honestly I think we should just go all in on the metals progress, see how it works, and attempt to add in anything we might need on the Metals side.
Potential ways to implement
No response

Hi Chris, what would be the responsibility of nvim-metals here? If I understand correctly, users can now just use their progress display they use for all other language servers (e.g. https://github.com/j-hui/fidget.nvim).
Is there anything else that nvim-metals does with the progress notifications?

Good question @kluen. There's noting that nvim-metals really needs to do apart from setting a default. Right now the default is something called show-message. So if they user doesn't set anything for statusBarProvider, then that is used. In order for the new progress to be utilized it needs to be set to "off". So this is basically a question of what should we default to. With the current default the user doesn't need to do anything to see messages. If we default to "off" then they need to have something like fidget installed to handle progress. Or, they set it to "on" and then make sure they capture the status in their bar.

I think it still makes sense to default to printing messages. That way we never run into a situation where someone new who does not now about how notifications work won't get any.
If I understand correctly, the new change in metals does not allow both status bar and LSP progress at the same time, so we have three mutual exclusive options now. How about renaming the setting to progressNotifications and use the three possible values, e.g. showMessage, metalsStatusBar and lspProgress?
Not sure about the naming, but however it is, I think it would be great to make it clear that there is a metals-specific way and an LSP standard way.
For the documentation: Is there any reason for a user to use the metals status bar notifications over the LSP progress ones? This comment sounded like there is some additional functionality.

If I understand correctly, the new change in metals does not allow both status bar and LSP progress at the same time, so we have three mutual exclusive options now. How about renaming the setting to progressNotifications and use the three possible values, e.g. showMessage, metalsStatusBar and lspProgress?

Yea, I think this is a good idea. Originally I was doing a 1 to 1 mapping of what the possibilities are server side here. That still might make sense, but things are starting to get muddled a bit since now we handle "off" in a special way.

For the documentation: Is there any reason for a user to use the metals status bar notifications over the LSP progress ones? https://github.com/scalameta/metals/pull/6055#discussion_r1477111517 sounded like there is some additional functionality.

For a nvim-metals user, honestly no. There are a couple extra things related to status, like there is now also the introduction of the BSP status, which we also provide for users to see if there are issues with their build connection. That's something that sort of just stays in the status bar and doesn't have any sort of progress notification. Then there are also Metals slowTask which is also intertwined with status. Finally there is also "action" that can be attached to the status. However, I stopped supporting this as of https://github.com/scalameta/nvim-metals/pull/642. They were way too aggressive and honestly not really helpful so it didn't make sense to steal the users focus like it was doing. In editors like VS Code this doesn't really matter since it's just a pop up that does steal your focus. I honestly wish we could go all in on progress and find a way to really get rid of status and slowTask in favor of full LSP stuff.

So as of the latest release of Metals a lot of stuff is now using LSP progress. I'll go ahead and close this now.


add boost graph library

Currently I have a massive memory leak in my program which seems to stem from my terrible design of my own Graph datastructure. I'm going to rather use the Boost Graph Library (BGL) for this, for the following reasons:

Need to restructure that part of the app to be const friendly
Learning opportunity to see how it should be done
Added genericity

https://www.boost.org/doc/libs/1_75_0/libs/graph/doc/quick_tour.html

Useful resources found so far:
Graph Library Usage Video
Quick Tour of BGL
two main choices for representation:

Adjacency list
EdgeList

struct VertexData {
  std::string first_name;
  int num;
}

struct EdgeData {
  std::string edge_name;
  double dist;
}

void example0()
{

// define the graph type
typedef boost::adjacency_list<boost::vecS,boost::vecS,boost::directedS,boost::no_property,boost::no_property> MyGraphType
}

// adding vertices and edges to the graph
MyGraphType G;
auto v1 = add_vertex(G);
auto v2 = add_vertex(G);
auto e = add_edge(v1, v2, G);

// looping through the vertices
auto vpair = vertices(G);
for(auto iter=vpair.first; iter!=vpair.second; iter++) {
std::cout << "vertex " < *iter << std::endl;
}

// looping through the edges
auto epair = edges(G);
for(auto iter = epair.first; iter!=epair.second; iter++) {
std::cout << "edge " << source(*iter,G) << " - " << target(*iter,G) << std::endl;
}

Creating a graph can be done in two ways:

auto g = std::make_shared<Graph>(number_of_vertices); and then calling add_vertex and add_edge
Graph g(edge_array, edge_array + sizeof(edge_array) / sizeof(Edge), num_vertices); -> typically more efficient

We can access all of the vertices of the graph using vertices(G) which returns a pair where first is equal to the beginning iterator and second to an iterator past the end. The same is true for edges(G) however to access the vertex at the source you write source(*iter, G) and to get the vertex at the destination write target(*iter,G)
The signature of adjacency_list:
adjacency_list<OutEdgeList, VertexList, Directed,VertexProperties, EdgeProperties,GraphProperties, EdgeList>
It is possible to associate properties with the vertexes and edges. For instance if you want to add an associated weight/cost to each edge then you can use boost::property<boost::edge_weight_t,double>
see property_types for a list of the property types available. Typedefs cannot be templated.
Property Map
There are two different kinds of get() functions.

Takes parameters relative to the graph and return to you a property map get(boost::edge_weight_t(),*g);
Takes a property map and instead of a graph reference takes an edge or vertex reference and returns to you the value of that property. get(weightMap, e)

https://stackoverflow.com/questions/77591501/boost-graph-library-looping-over-edges-of-a-graph


Incorrect length measure in math superscript

Description
The following code:
#let length = context repr(measure("--").width)
$ a length a ^ length $

renders as:

while the length provided in superscript should arguably be smaller. This is also happens with e.g. nested fractions, where content is also shrunk visually, but the measured length remains unchanged. Am I correct to believe the lengths should differ?
This can cause packages which rely on precise measurement to display things incorrectly in these contexts, like xarrow (which has not been too problematic so far because arrows are rarely used in superscript, nested fractions, etc.)
Reproduction URL
No response
Operating system
Web app, Linux
Typst version

[X] I am using the latest version of Typst

if i understand it correctly, length is a concrete value and will not change depends on the context.

to produce the desired result, you may want to define length as a function.

The interaction of math and styling is unfortunately not great at the moment. One workaround is to add a container around the context to force the normal layout pipeline, e.g. a box.


[CARBONDATA-2993] fix random NPE while concurrent loading

Problem:

NPE is thrown from CarbonRDD during concurrent dataload.
This is due to configuration being extracted from broadcast variable and sometimes it gives null instead of hadoopconfiguration.
Array is throwing schema mismatch exception.

Solution:

Keep Hadoop Conf as a transient class level variable for driver and extract from broadcast in executor.
In SDK write array child name was being hard coded as 'val'. Instead use the fieldName.

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/717/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8981/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/913/

LGTM


Windows - reopening previously registered site does not give option to edit

Steps to reproduce:

Enter a new (non existing) NRS URL and accept option to register it.
Click edit in browser and upload a directory to this page.
Close browser.
Launch browser again.

Expected:
Site registered above is listed on My Sites and when opened is editable.
Actual:
Site is not listed on My Sites and if manually navigate to it there is no edit button on the browser.
See linked document for screenshots.
https://docs.google.com/document/d/1B1XlSAF0nW4LEz9KspvqsyPOLdrLlD26l_7jJ23sXFo/edit?usp=sharing
Environment:
This is only seen on Windows (Windows 10 Enterprise Evaluation VM).
Testing on latest dev branch: 3bbb115d (HEAD -> dev, origin/dev) chore(refactor): Minor fix to store sites right latest version in state

Tested this on latest dev: a432982a (HEAD -> dev, origin/dev) chore(ci): Remove rust build code

Claim an NRS URL and upload a basic site:

Close browser and relaunch:

New NRS is listed in My Sites

Navigate to page just created:
Edit button is displayed and clickable

Click on edit button:
can edit page

QA verified - moving this to done.