Fix api servers creation and daemon start order

daemon creation wasn't parallel to request buffering
it was possible that empty volume will be created in
/var/run/docker.sock by some container

ping @runcom
I think I could miss something about signal.Trap.

:heart_eyes:

LGTM!!!

LGTM too


Updated to Swift 2.0

Updated the project to swift 2.0.  Works well in my swift 2.0 app.

there are other pull requests

Fixed with #8 but thank you for your PR! :+1:
@goktugyil: This project is not abandoned, although you could think it was and I'm sorry for this. :disappointed:


privacy manifest 설정

https://github.com/techinpark/ios_privacy_manifest_scanner

서드파티 목록

Alamofire
CombineCocoa
CombineExt
SwiftLinkPreview
AsyncAlgorithms
KeyChainSwift
Firebase
GoogleSignIn
Pulse?
swift-prelude
SQLiteService
publisher-async-bind
Toaster
Kingfisher


"ExtraArgs" option is not available while uploading a file/folder to S3 via CloudPath

If users want to add User defined metadata tags while uploading to S3 they should be able to do so, but currently can't find a way for this using CloudPath function upload_from(). It would be great to have this implementation and I can contribute to enabling this feature if needed.

Thanks for filing @gaisensei! @benbemoh has a sample implementation here which is relevant for the discussion.
I think we'd like to support passing the ExtraArgs, but I want to think a bit about the API design we want. Let's use this issue to explore our options.
A few open questions/thoughts on this topic:

upload_from and download_to are implemented generically (not per service), so we don't want to change the kwargs to be service specific
ExtraArgs can be specified per-operation, whereas implementations like #253 set it at the S3Client level. It may make sense to set defaults there, but we may also want to support passing these args through to functions explicitly.
If we support setting the default ExtraArgs in instantiation, is there a way to avoid having a set of long named kwargs like boto3_upload_extra_args for every potential boto3 function. Seems potentially painful to maintain and support if the internals of the clients get refactored
Do we want to support just ExtraArgs or other potential kwargs as well? I could see just generically collecting sdk_kwargs in upload_from and download_to

Thanks for filing @gaisensei! @benbemoh has a sample implementation here which is relevant for the discussion.
I think we'd like to support passing the ExtraArgs, but I want to think a bit about the API design we want. Let's use this issue to explore our options.
A few open questions/thoughts on this topic:

upload_from and download_to are implemented generically (not per service), so we don't want to change the kwargs to be service specific
ExtraArgs can be specified per-operation, whereas implementations like Add boto3 extra_args field for upload operation #253 set it at the S3Client level. It may make sense to set defaults there, but we may also want to support passing these args through to functions explicitly.

If we support setting the default ExtraArgs in Client instantiation, is there a way to avoid having a set of long named kwargs like boto3_upload_extra_args for every potential boto3 function. Seems potentially painful to maintain and support if the internals of the clients get refactored
Do we want to support just ExtraArgs or other potential kwargs as well? I could see just generically collecting sdk_kwargs in upload_from and download_to
As pointed out in Add boto3 extra_args field for upload operation #253, not all the boto3 functions we use accept ExtraArgs in the same way.

IMHO, the issue with ExtraArgs  in upload_from and download_to methods is that the extra args depends on the implementation: for instance, there exist many aws boto3 methods to upload a file into aws s3 (e.g. boto3.client('s3').upload_file(),  boto3.client('s3').upload_fileobj, etc). So if you change the code implementation of upload_from and download_to methods in the future, these extra_args might require a change accordingly.
Besides, a similar context here has been addressed using ExtraArgs in the client instantiation: see boto3_transfer_config and content_type_method:  I guess there should be a homogeneous implementation/way to deal with ExtraArgs.

@benbemoh @gaisensei Thanks for the helpful discussion here. We've added the ability to pass extra args to the client in #307.
See the updates to the documentation for how to pass the args to the client:
https://cloudpathlib.drivendata.org/stable/authentication/#other-s3-extraargs-in-boto3
You can test it in version 0.12.0, which is on PyPI now.


feature/keep selected tab in view

This PR adds functionality to keep the selected tab in view in the tab/buffer bar so if the bar is overflowing the selecting a buffer will bring the selected buffer into view that way the user isn't looking for a selected buffer somewhere off screen

Awesome, looks great to me @Akin909 ! Thanks for implementing this 👍

Just approved the changes - do you have the option to 'Squash and Merge' now? If so, go for it! 👍

Cool @bryphe it does indeed 😄 Merging!


[PhotoView] Update to v1.3.1

added .nuspec
added external dependencies

Updating this to 1.3.1 (the last of the v1.x series). This is a smaller set of changes and bugfixes. The v2.x series has some major changes with the package names and versioning. Some breaking changes are also going to happen.


Extend files.readonlyInclude setting

I propose to add negations ! and vscode path variables to files.readonlyInclude setting.
To not allow modifying files outside ${workspaceFolder}, most importantly

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


[Feature]: add "preventScroll" Prop for Select

Describe the feature
Right now we cannot scroll page if select is open and have to write workarounds to remove added styles from body. It would be great to have this prop not just for Select but also for similar components like Combobox, Dropdown, etc.
Additional information

[ ] I intend to submit a PR for this feature.
[ ] I have already implemented and/or tested this feature.

This would be very useful.

This should be implemented already. Try bodyLock=false for SelectContent


Blocking 3rd-party cookies breaks webrecorder.io two-domain system

Currently, webrecorder.io serves content from separate domain (wbrc.io) for security and robustness reasons.
If browsers block 3rd-party cookies, this prevents content pages from loading.
A few workarounds:

Allow anonymous, public replay w/o any cookies
For logged in browsing, or recording, warn if 3rd party cookies are disabled (eg. suggest using remote browsers?).

Using a subdomain now to avoid this issue!


Monthly backer email sent to old backers

UserCollectiveId 8179 (UserId 5921) is still receiving the monthly backer email for their subscription to Webpack that has been cancelled 2 months ago.

It's actually normal.
Subscription was cancelled in May and the email report was sent in June 1.
As an (inactive) backer, he will still receive updates from webpack but he can unsubscribe anytime with the unsubscribe link in the footer of the email.


downloading the source code

Why is downloading the source code so slow?

I'll try to fix it, I think it's because I put checkpoints and logs in the repository.

Should be much faster now


Any reason to ignore the package-lock.json in .gitignore

Hello:
I’ve noticed that package-lock.json is ignored in .gitignore. This change was introduced in #2149 and there is a comment asking for its deletion and another comment stating that it is generated automatically by npm so it has been added to .gitignore.
But it is important to know what is the intention of package-lock.json and why it is important to keep it in the repository:

Describe a single representation of a dependency tree such that teammates, deployments, and continuous integration are guaranteed to install exactly the same dependencies.
Provide a facility for users to "time-travel" to previous states of node_modules without having to commit the directory itself.
To facilitate greater visibility of tree changes through readable source control diffs.
Optimize the installation process by allowing npm to skip repeated metadata resolutions for previously-installed packages.
As of npm v7, lockfiles include enough information to gain a complete picture of the package tree, reducing the need to read package.json files, and allowing for significant performance improvements.

The most important thing about package-lock.json is to ensure when one runs npm install one will get a known-to-work state of the entire tree (which is not ensured if this file is removed and each user has their own version of the tree).
But maybe I don’t have the entire context of this change, there was any specific reason for it?

to stop tracking it, add the file to .gitignore (you already did that)

to remove it from the repo without deleting the file, call git rm --cached package-lock.json

call git status to see the file is marked as deleted, and the file is not listed as untracked (because it is gitignored), but it still exists

commit your changes and push if needed.

Hi @acatzk,
I don't understand your comment, are you sure that you wanted to respond to my question?
Regards

Hi @saper,
Thanks for your response but I think that you didn't get the point of the comment that I made three years ago.
This is an issue not even for the final clients using node-sass, the big issue is for node-sass development itself. This means owners and contributors.
You can potentially be publishing a code that is totally different to the code that was tested locally by the developers, because the tree in the developer machine could be potentially different to the tree that the CI environment generates. The code that you wrote is always the same, but the dependencies that your code uses are not.
Different developers developing node-sass will have potentially a different dependency tree each, which means that one of them could be having an error or an issue that the rest cannot reproduce (just because their dependency tree is different).
If the last minor or patch version of one of your dependencies gets a bug, a node-sass contributor that runs npm install will install it as a dependency, and he will not solve the bug until the dependency fixes the bug, a new version is published, and  the contributor runs npm install again.
All of these issues are solved with a package-lock.json file. It is a snapshot of the dependency tree, so two, three, ten developers developing the package, a CI environment or whatever runs npm install will always get exactly the same dependency tree.
This issue affected me when in the past I wanted to contribute to the project and local tests were failing, so I opened the issue just because of that. But I never got to contribute and I am not using node-sass anymore, so this issue is not affecting me anymore, it can be closed if it is not something important for the owners and contributors of the project.
Regards


Doc Feedback: Unclear sentence

Location : https://apim.docs.wso2.com/en/latest//Learn/APISecurity/OAuth2/hashing-oauth-keys/
Run the following command based on the database engine CONN_APP_KEY constraint from the IDN_OAUTH2_ACCESS_TOKEN table.

Fixed in https://github.com/wso2/docs-apim/pull/728


feature: add TypeDefinitions proto

Add TypeDefinitions. This will allow us to read and output an array of type definitions using protojson.
Description

References

Review Checklist

[ ] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[ ] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

I'll just AuthorizationModel.


Continue analysis on socket timeouts for ClearlyDefined

Please have a look at the individual commit messages for the details.

/cc @durikr


remote o doesn't work in 'Git' push arguments level?

In this level, remote is actually referred as 'origin', so command "git push origin XXX" works but "git push o XXX" is not working, but I thought you actually wanted it to be referred as 'o'?

Oooooh you mean the fact that we have:

as the abbrevation? yeah thats confusing -- the only reason why we limit it is because the full origin/master doesnt fit in the UI.
let me clarify this


Fix accessibility issue - role required when aria-expanded attribute is used

Addresses https://github.com/NuGet/NuGetGallery/issues/9415
Add a role to the div elements with the aria-expanded attribute. The role form is likely the best option in these scenarios.

Addressed the issue pointed out by @joelverhagen. New fix is actually to remove the use of the aria-expanded attribute entirely as it is used incorrectly here for the content element. The header button already has the aria-expanded attribute so the use here is redundant.


Add Argo logo to front page

Lets add the Argo logo to the front page.
Will ask the Argo folks to attach their logo to this issue.

Added Argo logo

@mukulikak When I click on the image you added to download, it takes me to (https://user-images.githubusercontent.com/25306803/43103633-a5d61dc4-8e83-11e8-9f0e-7ccdbee01eb6.png) which doesn't have "argo" at the bottom, whereas, if I were to download this image as is, it does have argo at bottom. Would you want me to use that linked image, or this one with the "argo" at the bottom.

@mukulikak Additionally, I would like to link to Argo website from the logo that I add. I couldn't find any specific website. I am planning to link to "https://blog.argoproj.io/" unless you suggest otherwise.


Capabilities setup

@pimeys, I have no write access to prisma, so it's a new PR that supersedes #235.

naming was changed to match MySql's
connection URL support was added

@Weakky, I'll merge this today in case of no objections.

Hey @blackbeam, thank you so much for the fast response! This looks good to me 💯

Nice!

Thanks for making the docs much better too!


Stringification behavior of FileInfo / Directory instances has changed since v6.0.2

How FileInfo / DirectoryInfo instances stringify implicitly used to depend on the specifics of the Get-ChildItem call that emitted them.
Previously, a Get-ChildItem command that targeted a directory path only would yield child items that stringified to their mere name rather than to their full path.
This now behaves differently in PowerShell Core v6.1.0-preview.3.
While the new behavior is more predictable and would actually resolve part of #6057, it is a - presumably unintended - breaking change.
Steps to reproduce
Create a temp. dir tmpDir with single file tmpFile, then use Get-ChildItem to enumerate tmpDir and stringify the resulting item:
$null > (Join-Path (New-Item -force -Type Directory tmpDir) tmpFile); Get-ChildItem tmpdir | % { "$_" }

Expected behavior
tmpFile

That is, only the file's name is reported.
This is what happened up until at least v6.0.2, and still happens in Windows PowerShell.
Actual behavior
/Users/jdoe/tmpdir/tmpFile

That is, stringification now results in the full path.
Environment data
PowerShell Core v6.1.0-preview.3

I think it come from .Net Core 2.0 -> 2.1 update.
$a=[io.fileinfo]::new("C:\Windows\explorer.exe")
$a.ToString()

@iSazonov:
Probably not, given that the behavior in your examples is no different from the one in Windows PowerShell v2 - v5.1 .

I can confirm that now we call obj.ToString() for FileInfo objects but I can't find what's changed in code.

Just ran into this as well.
Here's the commit in corefx where the ToString behavior was changed.
Here's that line specifically.

@SeeminglyScience:
Thanks, but I don't think that explains it. The only .ToString()-relevant change in that commit is to remove the transformation of a path like c: (i.e., a drive-letter-only path) to . via the now-removed ShouldReviseDirectoryPathToCurrent() method, something that the commit message calls a "limited trust holdover".
The fundamental behavior hasn't changed: whatever path you pass in to construct the instance is output by .ToString().
Thus, something on the PowerShell side must have changed:
@iSazonov, when you say "now we call obj.ToString()", can you tell us what we did before, and perhaps point us to the code?

I don't remember already but seems it is here https://github.com/PowerShell/PowerShell/blob/master/src/System.Management.Automation/engine/MshObject.cs#L1244
and in the case we do https://github.com/PowerShell/PowerShell/blob/master/src/System.Management.Automation/engine/MshObject.cs#L1332

Copying some things from the duplicate issue I just closed...
Looks like .NET is leaning toward WontFix.
We should:

Investigate changing LanguagePrimitives so that converting a DirectoryInfo to a string uses Name rather than ToString()
Investigate investment in @rkeithhill's suggested [Path()] attribute (or a similar parameter processing attribute)
Update any relevant documentation

More info in https://github.com/dotnet/corefx/issues/38215.
/cc @SteveL-MSFT and @joeyaiello since we should amend changelogs.
Also tagging for @PowerShell/powershell-committee review

Thus, something on the PowerShell side must have changed:

.NET team verified a change of theirs broke this

Investigate investment in @rkeithhill's suggested [Path()] attribute (or a similar parameter processing attribute)

This would be awesome and could GREATLY simplify writing advanced functions that require paths.  @oising wrote this version for PSCX back in the day:
https://github.com/Pscx/Pscx/blob/master/Src/Pscx.Core/PscxPathAttribute.cs
https://github.com/Pscx/Pscx/blob/master/Src/Pscx.Core/IO/PscxPathInfo.cs
https://github.com/Pscx/Pscx/blob/master/Src/Pscx.Core/IO/PscxPathInfo.ResolvedPscxPathImpl.cs
https://github.com/Pscx/Pscx/blob/master/Src/Pscx.Core/IO/PscxPathInfo.UnresolvedPscxPathImpl.cs
Used simply like this:
        // protected (derived classes may replace Path and LiteralPath)
        protected PscxPathInfo[] _paths;
        protected PscxPathInfo[] _literalPaths;

        [Parameter(
            ParameterSetName = ParameterSetPath,
            Position = 0,
            Mandatory = true,
            ValueFromPipeline = true,
            ValueFromPipelineByPropertyName = true,
            HelpMessage = "Specifies the path to the file to process. Wildcard syntax is allowed."
        )]
        [AcceptsWildcards(true)]
        [PscxPath(Tag="PathCommand.Path")]
        public virtual PscxPathInfo[] Path
        {
            get { return _paths; }
            set { _paths = value; }
        }

        [Parameter(
            ParameterSetName = ParameterSetLiteralPath,
            Position = 0,
            Mandatory = true,
            ValueFromPipeline = false,
            ValueFromPipelineByPropertyName = true,
            HelpMessage = "Specifies a path to the item. The value of -LiteralPath is used exactly as it is typed. No characters are interpreted as wildcards. If the path includes escape characters, enclose it in single quotation marks. Single quotation marks tell Windows PowerShell not to interpret any characters as escape sequences."
        )]
        [Alias("PSPath")]
        [PscxPath(NoGlobbing = true, Tag="PathCommand.LiteralPath")]
        public virtual PscxPathInfo[] LiteralPath
        {
            get { return _literalPaths; }
            set { _literalPaths = value; }
        }

If Core team says about security it is important for PowerShell too and we shouldn't "revert" this too.
It seems unlikely that somebody explicitly use DirectoryInfo.ToString() or FileInfo.ToString() in scripts. It is used as last resort in output only. The output we could easily fix (I am not sure that we should).

If Core team says about security it is important for PowerShell too and we shouldn't "revert" this too.

Yeah basically it's because relative paths might be relative to somewhere else, whereas absolute paths are canonical. I suspect it's a bigger issue in ASP.NET than for us, but I agree that it's the better choice.
Still we must weigh that against the break.

it's a bigger issue in ASP.NET than for us

What is difference C# code and script code in the context? Modern management interfaces is Web - that is ASP.Net and internally it use PowerShell (EAC - Exchange Admnistrative Console, WAC - Windows Admnistrative Console).

Essentially my thinking is that public-facing websites often serve static content, and path traversal is a classic attack (here's another fun one).
That scenario is distinguished because:

The path input comes from a public-facing, untrustable endpoint
A chroot-like environment is in effect
There's arguably no good reason to use relative paths at all (especially since webapps are "stateless")

Compare this to PowerShell, where:

User input should not come from public-facing endpoints (and if it does, path handling is relatively low on the list of concerns)
PowerShell itself doesn't have a chroot responsibility; we leave it to the containing environment to sandbox the user
We have a concept of a current working directory, which changes, so relative paths have a meaningful use

Modern management interfaces is Web

This is true, but the vast majority of websites are not for system management. PowerShell on the other hand is mostly for machine management and automation.

Compare this to PowerShell, where:

:-) You say about ideal world where attacks don't exist. One mistake in public level code and attacker gets possibility to inject specific data and exploit relative path feature.
I mean that we should reduce the attack area.

I mean that we should reduce the attack area.

Sure, on paper that's an easy decision.
But we're currently talking about removing a form of relative path handling from an interactive shell. Is bash or Python having a debate about that?
I'm not saying we should strip out security features, but this is a relatively large breaking change that affects (breaks) official Microsoft-shipped tools.
Windows PowerShell doesn't consider this a security issue and isn't going to change it. So why should PowerShell Core? If .NET hadn't silently broken this, would we have asked them to or let them?
In the real world, attacks exist but so does the usability/security tradeoff. PowerShell already bends over backward trying to manage security boundaries that other applications never contemplate, threading the needle between being able to manage a machine and not being able to do anything bad to it. We have a whole suite of established mechanisms in and around PowerShell to control the power of the user, and I'm not convinced that making this change really enhances that. Factoring in that it's a relatively serious breaking change, I wouldn't endorse it.
Anyway, it's all academic, since the change is already upon us. The question is, what do we do with it? For PowerShell 7 to live up to its compatibility promise, I think we have to seriously consider changing the string coercion logic of FileInfo and DirectoryInfo.

The question is, what do we do with it?

Do you know scripts affect by the change?
I look some my scripts and I never used the ToString conversion - only Name or FullName. So for me it is only formatting issue.

According to https://github.com/PowerShell/PowerShell/issues/9800#issue-451162995, this is an example.
So it turns out not as production-oriented as I thought, there.

I never used the ToString conversion

It's automatic because of LanguagePrimitives' automatic string conversion logic. So any script that takes $item = get-childitem and passes it to a -Path or a -LiteralPath (gcm | ? { $_.Parameters.Keys -contains 'Path' } | % Name, 51 commands) will be affected

Thanks! I see now how the problem arises:
https://github.com/microsoft/vcpkg/blob/3e1b8afb189a78666e2851524ca888b8173daea4/scripts/bootstrap.ps1#L226-L231
It is the bad pattern but it can be used in many scripts.
I think this is happening because of the display of the short name in default output - users do "dir", see short names and trying use its in interpolated strings directly instead of using $_.Name and Join-Path.

I should have made it clearer that the old behavior resulted in hard-to-predict behavior that was the cause of many bugs, namely when passing System.IO.FileInfo or System.IO.DirectoryInfo instances as direct arguments to cmdlets' -Path or -LiteralPath parameters, which situationally - depending on the specifics of the Get-ChildItem call - caused name-only stringification - see https://stackoverflow.com/a/53400031/45375
In short: while it is a breaking change (that we've lived with for quite some time now), the new behavior to me is unquestionably preferable.
As an aside, the problem described above would be mitigated if System.IO.FileInfo or System.IO.DirectoryInfo arguments were bound via their .PSPath property, just as with pipeline input, which is part of a fundamental asymmetry - see #6057

https://stackoverflow.com/a/53400031/45375

It looks awful! Perhaps reference to security (in Core issue) is best time to unify the behavior.

We struggled with this a decade ago when it first started rearing its ugly head:

@rkeithhill Not to hijack the thread, but maybe we could collaborate on an RFC for this. Now that the source is open, we could improve on the PscxPath stuff (by extending PathInfo to handle non-existant paths, for example.)

Quoted from https://github.com/PowerShell/PowerShell/issues/7132#issuecomment-499852757

which situationally - depending on the specifics of the Get-ChildItem call - caused name-only stringification

Just want to point out that the previous behavior was resulted by the inconsistency in FileInfo -- for FileInfo objects retrieved by DirectoryInfo.EnumerateFiles(), calling ToString() on them will return the simplified file name; while for the FileInfo object created using the public constructor, calling ToString() returns the full path. This is why this behavior happens only when running Get-ChildItem targeting a directory.
The inconsistency was fixed in .NET Core -- FileInfo.ToString() object always return the full path, unless it's representing a path that cannot be resolved.

@PowerShell/powershell-committee reviewed this and agrees that the old behavior is inconsistent, however, backwards compatibility is a major concern.  Recommendation is to explore an ETS solution and measure the level of compatibility as well as the perf impact before agreeing that would be the final solution.  If the ETS solution is insufficient for compatibility or there is significant perf impact, @PowerShell/powershell-committee will revisit this issue.

backwards compatibility is a major concern

If .Net Core found this accessible we could do the same.
Perhaps PSSA could help. /cc @rjmholt @bergmeister
Not clear about ETS. I'd expect that we fix only dir output in formatting system.

explore an ETS solution

ETS meaning extended type system? So some kind of script method override? (This is what I was imagining too).
PSScriptAnalyzer doesn't currently have any single rule tracking semantic changes in PowerShell. I think that kind of effort could only really proceed with help from PowerShell. I think we've discussed exactly this before, the idea where we have a big rule that just looks up the PowerShell version and checks the particular syntax.
If we can at least catalogue the nature of any and all breaking changes in one place, such a rule would be feasible to write.
Also, I feel I should register that despite making the opposing case, I'm actually in favour of the new behaviour.

ETS meaning extended type system?

Yes.

I think we've discussed exactly this before

Have we a tracking issue?

Recommendation is to explore an ETS solution and measure the level of compatibility as well as the perf impact before agreeing that would be the final solution.

ETS won't be helpful to retain the old behavior in PowerShell. As described in https://github.com/PowerShell/PowerShell/issues/7132#issuecomment-501451500, the root cause of the original inconsistent behavior in PowerShell is the inconsistency in returning result of FileInfo.ToString(). When invoking Get-ChildItem against a directory, it uses DirectoryInfo.EnumerateFiles() to get the FileInfo objects, which return the file name only when calling ToString() on them. When invoking Get-ChildItem against files directly, it uses the public constructor new FileInfo(string fileName) to create the FileInfo objects, which return the full path when calling ToString() on them.
So to retain the old wrong behavior, we will have to put some hacky code in FileSystemProvider to differentiate the FileInfo objects generated from Get-ChildItem <dir> and Get-ChildItem <file> and Get-Item <file>. That code would be definitely confusing and I don't think we should do that just in order to retain an unfavorable existing behavior. Since .NET accepted the breaking change by fixing the inconsistency, it's a good chance for us to do the same.

I don't think it makes sense to retain the more confusing behaviour just because people are accustomed to dealing with it.
Keeping this change means some scripts will break, maybe, but in fixing those we'd just be removing additional workaround logic that was probably more annoying to have around anyway.
Maybe a small handful of edge cases where it really was helpful, but there is no shortage of available alternatives for those, either. 🙂

Have we a tracking issue?

https://github.com/PowerShell/PowerShell/issues/9138

@PowerShell/powershell-committee reviewed this.  The work involved to maintain compatibility is not worth the effort as the underlying platform has introduced a change to fix an inconsistency problem.  This results in a breaking change for some PowerShell users, but detecting of this will be quick and using .FullName or .Name as appropriate is the right thing to do.  We could make a change in Join-Path to support joining two absolute paths to make this simpler for scripts, but that would be a separate issue.


No longer Formatting on Save with Go fmt

Description of the problem or steps to reproduce
In a previous version, saving a go file would cause it to auto format and align as per fmt, however it no longer does so, though error checking still works.
Specifications
You can use micro -version to get the commit hash.
Commit hash: be81241
OS: Void linux
Terminal: Alacritty

Micro editor does not have the plugin go built in anymore for some reason, since version V1.1.4
You can install the plugin go by typing Ctrl+E and type.
plugin install go

Yeah I thought that it would be inconsistent to have a go plugin by default but not any other language. Language specific plugins shouldn't be shipped with micro by default (syntax highlighting and linting is but I think anything more is too much).
As @tommyshem notes, you can easily install it with the plugin manager.


Introduce casual package for managing random data generation

Use https://github.com/boo1ean/casual for template variable support

implemented


add start/end logs to outage entries

Add log entries that affect the state of an outage to the outage entry.

/test e2e-aws-serial

/test e2e-aws-serial

/test e2e-aws-serial

I'm not really happy with the logic, but I need something in CI now. Please update the endlogs and startlogs.

StartLogs should have only five entries ever, after that, nothing more gets added
EndLogs should always have  at least one entry (the first failure  is the first entry). After that, it should have five entries max, but it should always be the most recent five.

/lgtm

/lgtm
probably want to factor the append logic out and keep using it.  I suspect we may want the lists sorted in opposite directions, but I guess we'll see.


proxy.golang.org: txn2/kubefwd package latest version points to an older version

What version of Go are you using (go version)?
There is nothing to deal with go binary.
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
There is nothing to deal with go binary
What did you do?
Please, see a related problem in kubefwd package source repo https://github.com/txn2/kubefwd/issues/158
What did you expect to see?
proxy must supply latest package version
What did you see instead?
proxy supplies 1.18.2 version

see https://golang.org/ref/mod#versions

Each version starts with the letter v, followed by a semantic version.


Added German Translation

Happy 2017 :)

@Tonat thank you and happy new year :)

@Tonat thank you and happy new year :)


Include bib entries with no s2 paper matches in citations output

Related to https://github.com/allenai/scholar/issues/31778, builds on https://github.com/allenai/scholarphi/pull/351.
The idea is to include output for bib entries that we failed to match to S2 papers in the output of the citations pipeline, so that we can still identify the corresponding mention bounding boxes (and possible show the bib entry text n them instead).
Testing
Running examples
I tested this out by running a couple of papers through (same as the ones for #351).
A paper missing matches, without these changes
Output file:
1611.07004v3-current-2.txt
Logs:
# python scripts/run_pipeline.py    --one-paper-at-a-time    --arxiv-ids 1611.07004v3    --output-forms file    --output-dir outputs-1611.07004v3-current-2    --entities citations
wandb: WARNING W&B installed but not logged in.  Run `wandb login` or set the WANDB_API_KEY env variable.
2022-04-27 19:19:06,158 [INFO]: The following commands will be run, in this order: ['fetch-arxiv-sources', 'fetch-s2-metadata', 'unpack-sources', 'compile-tex', 'normalize-tex', 'compile-normalized-tex', 'raster-pages', 'extract-bibitems', 'resolve-bibitems', 'locate-bounding-boxes-for-citation-fragments', 'locate-citations', 'upload-citations']
2022-04-27 19:19:06,158 [INFO]: Running pipeline for paper 1611.07004v3
2022-04-27 19:19:06,159 [INFO]: Launching command fetch-arxiv-sources
2022-04-27 19:19:27,732 [INFO]: Finished running command fetch-arxiv-sources
2022-04-27 19:19:27,733 [INFO]: Launching command fetch-s2-metadata
2022-04-27 19:19:27,734 [INFO]: Issuing request to S2 @ api.semanticscholar.org
2022-04-27 19:19:36,160 [INFO]: Finished running command fetch-s2-metadata
2022-04-27 19:19:36,161 [INFO]: Launching command unpack-sources
2022-04-27 19:19:36,408 [INFO]: Finished running command unpack-sources
2022-04-27 19:19:36,409 [INFO]: Launching command compile-tex
2022-04-27 19:19:39,639 [INFO]: Finished running command compile-tex
2022-04-27 19:19:39,641 [INFO]: Launching command normalize-tex
2022-04-27 19:19:39,735 [INFO]: Finished running command normalize-tex
2022-04-27 19:19:39,736 [INFO]: Launching command compile-normalized-tex
2022-04-27 19:19:42,860 [INFO]: Finished running command compile-normalized-tex
2022-04-27 19:19:42,861 [INFO]: Launching command raster-pages
2022-04-27 19:19:44,506 [INFO]: Finished running command raster-pages
2022-04-27 19:19:44,507 [INFO]: Launching command extract-bibitems
2022-04-27 19:19:45,310 [INFO]: Finished running command extract-bibitems
2022-04-27 19:19:45,311 [INFO]: Launching command resolve-bibitems
2022-04-27 19:19:45,316 [WARNING]: Could not find a sufficiently similar reference for bibitem sketch2pokemon of paper 1611.07004v3
2022-04-27 19:19:45,318 [WARNING]: Could not find a sufficiently similar reference for bibitem pose of paper 1611.07004v3
2022-04-27 19:19:45,320 [WARNING]: Could not find a sufficiently similar reference for bibitem edges2cats of paper 1611.07004v3
2022-04-27 19:19:45,323 [WARNING]: Could not find a sufficiently similar reference for bibitem fotogenerator of paper 1611.07004v3
2022-04-27 19:19:45,325 [WARNING]: Could not find a sufficiently similar reference for bibitem palette of paper 1611.07004v3
2022-04-27 19:19:45,327 [WARNING]: Could not find a sufficiently similar reference for bibitem background of paper 1611.07004v3
2022-04-27 19:19:45,329 [WARNING]: Could not find a sufficiently similar reference for bibitem sketch2portrait of paper 1611.07004v3
2022-04-27 19:19:45,330 [WARNING]: Could not find a sufficiently similar reference for bibitem sunday of paper 1611.07004v3
2022-04-27 19:19:45,473 [INFO]: Paper has 65 references, able to match 57 reference(s) to S2 data.
2022-04-27 19:19:45,473 [INFO]: Finished running command resolve-bibitems
2022-04-27 19:19:45,473 [INFO]: Launching command locate-bounding-boxes-for-citation-fragments
2022-04-27 19:20:13,767 [INFO]: Finished running command locate-bounding-boxes-for-citation-fragments
2022-04-27 19:20:13,767 [INFO]: Launching command locate-citations
2022-04-27 19:20:13,788 [INFO]: Finished running command locate-citations
2022-04-27 19:20:13,789 [INFO]: We will be writing output to files.
2022-04-27 19:20:13,789 [INFO]: Launching command upload-citations
2022-04-27 19:20:13,798 [WARNING]: Not uploading bounding box information for citation with key sketch2pokemon because it was not resolved to a paper S2 ID.
2022-04-27 19:20:13,798 [WARNING]: Not uploading bounding box information for citation with key pose because it was not resolved to a paper S2 ID.
2022-04-27 19:20:13,798 [WARNING]: Not uploading bounding box information for citation with key edges2cats because it was not resolved to a paper S2 ID.
2022-04-27 19:20:13,798 [WARNING]: Not uploading bounding box information for citation with key fotogenerator because it was not resolved to a paper S2 ID.
2022-04-27 19:20:13,798 [WARNING]: Not uploading bounding box information for citation with key palette because it was not resolved to a paper S2 ID.
2022-04-27 19:20:13,798 [WARNING]: Not uploading bounding box information for citation with key background because it was not resolved to a paper S2 ID.
2022-04-27 19:20:13,798 [WARNING]: Not uploading bounding box information for citation with key sketch2portrait because it was not resolved to a paper S2 ID.
2022-04-27 19:20:13,798 [WARNING]: Not uploading bounding box information for citation with key sunday because it was not resolved to a paper S2 ID.
2022-04-27 19:20:13,799 [INFO]: Saving to file...
2022-04-27 19:20:13,799 [INFO]: About to write 119 entity infos to outputs-1611.07004v3-current-2/citations.json (version: v0).
2022-04-27 19:20:13,805 [INFO]: Finished running command upload-citations
2022-04-27 19:20:13,841 [INFO]: Internal process exited

Mentions in output:
$ cat 1611.07004v3-current-2.json | jq ' .data | map(.id_) | .[]'  | wc -l
     119

A paper missing matches, with these changes
Output file:
1611.07004v3-with-missing-matches-2.txt
Logs:
# python scripts/run_pipeline.py    --one-paper-at-a-time    --arxiv-ids 1611.07004v3    --output-forms file    --output-dir outputs-1611.07004v3-with-missing-matches-2    --entities citations
wandb: WARNING W&B installed but not logged in.  Run `wandb login` or set the WANDB_API_KEY env variable.
2022-04-27 19:09:20,719 [INFO]: The following commands will be run, in this order: ['fetch-arxiv-sources', 'fetch-s2-metadata', 'unpack-sources', 'compile-tex', 'normalize-tex', 'compile-normalized-tex', 'raster-pages', 'extract-bibitems', 'resolve-bibitems', 'locate-bounding-boxes-for-citation-fragments', 'locate-citations', 'upload-citations']
2022-04-27 19:09:20,719 [INFO]: Running pipeline for paper 1611.07004v3
2022-04-27 19:09:20,720 [INFO]: Launching command fetch-arxiv-sources
2022-04-27 19:09:42,544 [INFO]: Finished running command fetch-arxiv-sources
2022-04-27 19:09:42,545 [INFO]: Launching command fetch-s2-metadata
2022-04-27 19:09:42,545 [INFO]: Issuing request to S2 @ api.semanticscholar.org
2022-04-27 19:09:50,283 [INFO]: Finished running command fetch-s2-metadata
2022-04-27 19:09:50,284 [INFO]: Launching command unpack-sources
2022-04-27 19:09:50,537 [INFO]: Finished running command unpack-sources
2022-04-27 19:09:50,538 [INFO]: Launching command compile-tex
2022-04-27 19:09:53,928 [INFO]: Finished running command compile-tex
2022-04-27 19:09:53,930 [INFO]: Launching command normalize-tex
2022-04-27 19:09:54,022 [INFO]: Finished running command normalize-tex
2022-04-27 19:09:54,022 [INFO]: Launching command compile-normalized-tex
2022-04-27 19:09:57,314 [INFO]: Finished running command compile-normalized-tex
2022-04-27 19:09:57,315 [INFO]: Launching command raster-pages
2022-04-27 19:09:59,130 [INFO]: Finished running command raster-pages
2022-04-27 19:09:59,131 [INFO]: Launching command extract-bibitems
2022-04-27 19:09:59,858 [INFO]: Finished running command extract-bibitems
2022-04-27 19:09:59,858 [INFO]: Launching command resolve-bibitems
2022-04-27 19:09:59,864 [WARNING]: Could not find a sufficiently similar reference for bibitem sketch2pokemon of paper 1611.07004v3
2022-04-27 19:09:59,866 [WARNING]: Could not find a sufficiently similar reference for bibitem pose of paper 1611.07004v3
2022-04-27 19:09:59,868 [WARNING]: Could not find a sufficiently similar reference for bibitem edges2cats of paper 1611.07004v3
2022-04-27 19:09:59,871 [WARNING]: Could not find a sufficiently similar reference for bibitem fotogenerator of paper 1611.07004v3
2022-04-27 19:09:59,872 [WARNING]: Could not find a sufficiently similar reference for bibitem palette of paper 1611.07004v3
2022-04-27 19:09:59,874 [WARNING]: Could not find a sufficiently similar reference for bibitem background of paper 1611.07004v3
2022-04-27 19:09:59,876 [WARNING]: Could not find a sufficiently similar reference for bibitem sketch2portrait of paper 1611.07004v3
2022-04-27 19:09:59,878 [WARNING]: Could not find a sufficiently similar reference for bibitem sunday of paper 1611.07004v3
2022-04-27 19:10:00,012 [INFO]: Paper has 65 references, able to match 57 reference(s) to S2 data.
2022-04-27 19:10:00,013 [INFO]: Finished running command resolve-bibitems
2022-04-27 19:10:00,013 [INFO]: Launching command locate-bounding-boxes-for-citation-fragments
2022-04-27 19:10:27,876 [INFO]: Finished running command locate-bounding-boxes-for-citation-fragments
2022-04-27 19:10:27,876 [INFO]: Launching command locate-citations
2022-04-27 19:10:27,898 [INFO]: Finished running command locate-citations
2022-04-27 19:10:27,899 [INFO]: We will be writing output to files.
2022-04-27 19:10:27,899 [INFO]: Launching command upload-citations
2022-04-27 19:10:27,910 [WARNING]: Missing S2 match for bibitem with key sketch2pokemon for paper 1611.07004v3
2022-04-27 19:10:27,910 [WARNING]: Missing S2 match for bibitem with key pose for paper 1611.07004v3
2022-04-27 19:10:27,910 [WARNING]: Missing S2 match for bibitem with key edges2cats for paper 1611.07004v3
2022-04-27 19:10:27,910 [WARNING]: Missing S2 match for bibitem with key fotogenerator for paper 1611.07004v3
2022-04-27 19:10:27,910 [WARNING]: Missing S2 match for bibitem with key palette for paper 1611.07004v3
2022-04-27 19:10:27,910 [WARNING]: Missing S2 match for bibitem with key background for paper 1611.07004v3
2022-04-27 19:10:27,910 [WARNING]: Missing S2 match for bibitem with key sketch2portrait for paper 1611.07004v3
2022-04-27 19:10:27,910 [WARNING]: Missing S2 match for bibitem with key sunday for paper 1611.07004v3
2022-04-27 19:10:27,911 [INFO]: Saving to file...
2022-04-27 19:10:27,911 [INFO]: About to write 127 entity infos to outputs-1611.07004v3-with-missing-matches-2/citations.json (version: v0).
2022-04-27 19:10:27,918 [INFO]: Finished running command upload-citations
2022-04-27 19:10:27,953 [INFO]: Internal process exited

Mentions in output:
$ cat 1611.07004v3-with-missing-matches-2.json | jq ' .data | map(.id_) | .[]'  | wc -l
     127

A paper not missing matches, without these changes
Output file:
2009.12303v4-current-2.txt
Logs:
# python scripts/run_pipeline.py    --one-paper-at-a-time    --arxiv-ids 2009.12303v4    --output-forms file    --output-dir outputs-2009.12303v4-current-2    --entities citations
wandb: WARNING W&B installed but not logged in.  Run `wandb login` or set the WANDB_API_KEY env variable.
2022-04-27 19:21:12,842 [INFO]: The following commands will be run, in this order: ['fetch-arxiv-sources', 'fetch-s2-metadata', 'unpack-sources', 'compile-tex', 'normalize-tex', 'compile-normalized-tex', 'raster-pages', 'extract-bibitems', 'resolve-bibitems', 'locate-bounding-boxes-for-citation-fragments', 'locate-citations', 'upload-citations']
2022-04-27 19:21:12,843 [INFO]: Running pipeline for paper 2009.12303v4
2022-04-27 19:21:12,843 [INFO]: Launching command fetch-arxiv-sources
2022-04-27 19:21:23,888 [INFO]: Finished running command fetch-arxiv-sources
2022-04-27 19:21:23,890 [INFO]: Launching command fetch-s2-metadata
2022-04-27 19:21:23,890 [INFO]: Issuing request to S2 @ api.semanticscholar.org
2022-04-27 19:21:27,177 [INFO]: Finished running command fetch-s2-metadata
2022-04-27 19:21:27,178 [INFO]: Launching command unpack-sources
2022-04-27 19:21:27,218 [INFO]: Finished running command unpack-sources
2022-04-27 19:21:27,219 [INFO]: Launching command compile-tex
2022-04-27 19:21:32,876 [INFO]: Finished running command compile-tex
2022-04-27 19:21:32,877 [INFO]: Launching command normalize-tex
2022-04-27 19:21:32,889 [INFO]: Finished running command normalize-tex
2022-04-27 19:21:32,889 [INFO]: Launching command compile-normalized-tex
2022-04-27 19:21:38,265 [INFO]: Finished running command compile-normalized-tex
2022-04-27 19:21:38,266 [INFO]: Launching command raster-pages
2022-04-27 19:21:39,182 [INFO]: Finished running command raster-pages
2022-04-27 19:21:39,183 [INFO]: Launching command extract-bibitems
2022-04-27 19:21:40,358 [INFO]: Finished running command extract-bibitems
2022-04-27 19:21:40,359 [INFO]: Launching command resolve-bibitems
2022-04-27 19:21:40,578 [INFO]: Paper has 55 references, able to match 55 reference(s) to S2 data.
2022-04-27 19:21:40,578 [INFO]: Finished running command resolve-bibitems
2022-04-27 19:21:40,578 [INFO]: Launching command locate-bounding-boxes-for-citation-fragments
2022-04-27 19:22:06,946 [INFO]: Finished running command locate-bounding-boxes-for-citation-fragments
2022-04-27 19:22:06,947 [INFO]: Launching command locate-citations
2022-04-27 19:22:06,967 [INFO]: Finished running command locate-citations
2022-04-27 19:22:06,967 [INFO]: We will be writing output to files.
2022-04-27 19:22:06,967 [INFO]: Launching command upload-citations
2022-04-27 19:22:06,977 [INFO]: Saving to file...
2022-04-27 19:22:06,977 [INFO]: About to write 102 entity infos to outputs-2009.12303v4-current-2/citations.json (version: v0).
2022-04-27 19:22:06,983 [INFO]: Finished running command upload-citations
2022-04-27 19:22:06,997 [INFO]: Internal process exited

Mentions in output:
$ cat 2009.12303v4-current-2.json | jq ' .data | map(.id_) | .[]'  | wc -l
     102

A paper not missing matches, with these changes
Output file:
2009.12303v4-with-missing-matches-2.txt
Logs:
python scripts/run_pipeline.py    --one-paper-at-a-time    --arxiv-ids 2009.12303v4    --output-forms file    --output-dir outputs-2009.12303v4-with-missing-matches-2    --entities citations
wandb: WARNING W&B installed but not logged in.  Run `wandb login` or set the WANDB_API_KEY env variable.
2022-04-27 19:11:17,538 [INFO]: The following commands will be run, in this order: ['fetch-arxiv-sources', 'fetch-s2-metadata', 'unpack-sources', 'compile-tex', 'normalize-tex', 'compile-normalized-tex', 'raster-pages', 'extract-bibitems', 'resolve-bibitems', 'locate-bounding-boxes-for-citation-fragments', 'locate-citations', 'upload-citations']
2022-04-27 19:11:17,538 [INFO]: Running pipeline for paper 2009.12303v4
2022-04-27 19:11:17,539 [INFO]: Launching command fetch-arxiv-sources
2022-04-27 19:11:28,838 [INFO]: Finished running command fetch-arxiv-sources
2022-04-27 19:11:28,840 [INFO]: Launching command fetch-s2-metadata
2022-04-27 19:11:28,840 [INFO]: Issuing request to S2 @ api.semanticscholar.org
2022-04-27 19:11:32,156 [INFO]: Finished running command fetch-s2-metadata
2022-04-27 19:11:32,157 [INFO]: Launching command unpack-sources
2022-04-27 19:11:32,203 [INFO]: Finished running command unpack-sources
2022-04-27 19:11:32,204 [INFO]: Launching command compile-tex
2022-04-27 19:11:37,973 [INFO]: Finished running command compile-tex
2022-04-27 19:11:37,974 [INFO]: Launching command normalize-tex
2022-04-27 19:11:37,993 [INFO]: Finished running command normalize-tex
2022-04-27 19:11:37,994 [INFO]: Launching command compile-normalized-tex
2022-04-27 19:11:43,336 [INFO]: Finished running command compile-normalized-tex
2022-04-27 19:11:43,337 [INFO]: Launching command raster-pages
2022-04-27 19:11:44,142 [INFO]: Finished running command raster-pages
2022-04-27 19:11:44,144 [INFO]: Launching command extract-bibitems
2022-04-27 19:11:45,245 [INFO]: Finished running command extract-bibitems
2022-04-27 19:11:45,246 [INFO]: Launching command resolve-bibitems
2022-04-27 19:11:45,452 [INFO]: Paper has 55 references, able to match 55 reference(s) to S2 data.
2022-04-27 19:11:45,452 [INFO]: Finished running command resolve-bibitems
2022-04-27 19:11:45,453 [INFO]: Launching command locate-bounding-boxes-for-citation-fragments
2022-04-27 19:12:12,297 [INFO]: Finished running command locate-bounding-boxes-for-citation-fragments
2022-04-27 19:12:12,298 [INFO]: Launching command locate-citations
2022-04-27 19:12:12,317 [INFO]: Finished running command locate-citations
2022-04-27 19:12:12,317 [INFO]: We will be writing output to files.
2022-04-27 19:12:12,317 [INFO]: Launching command upload-citations
2022-04-27 19:12:12,328 [INFO]: Saving to file...
2022-04-27 19:12:12,328 [INFO]: About to write 102 entity infos to outputs-2009.12303v4-with-missing-matches-2/citations.json (version: v0).
2022-04-27 19:12:12,335 [INFO]: Finished running command upload-citations
2022-04-27 19:12:12,349 [INFO]: Internal process exited

Mentions in output:
$ cat 2009.12303v4-with-missing-matches-2.json | jq ' .data | map(.id_) | .[]'  | wc -l
     102

Automated tests
I also ran the tests described here:
# pytest
============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.7.5, pytest-5.3.1, py-1.11.0, pluggy-0.13.1
rootdir: /data-processing, inifile: pytest.ini, testpaths: tests
plugins: cov-2.5.1
collected 214 items

tests/test_bounding_box.py ..................                                                                                [  8%]
tests/test_colorize_sentences.py .....                                                                                [ 10%]
tests/test_colorize_tex.py ........                                                                                [ 14%]
tests/test_compile.py ........                                                                                [ 18%]
tests/test_extract_definitions.py ssss...ss...sssssssss                                                                                [ 28%]
tests/test_locate_symbols.py ...                                                                                [ 29%]
tests/test_match_symbols.py ......                                                                                [ 32%]
tests/test_normalize_tex.py ..............                                                                                [ 38%]
tests/test_parse_equation.py .........................                                                                                [ 50%]
tests/test_parse_tex.py ..............................................                                                                                [ 71%]
tests/test_sanitize_equation.py ....                                                                                [ 73%]
tests/test_scan_tex.py .....                                                                                [ 76%]
tests/test_string.py .............                                                                                [ 82%]
tests/test_unpack.py ....                                                                                [ 84%]
tests/test_visual_validate.py ......                                                                                [ 86%]
tests/common/test_fetch_arxiv.py ......                                                                                [ 89%]
tests/common/test_upload_entities.py ............                                                                                [ 95%]
tests/common/commands/test_fetch_arxiv_sources.py ..                                                                                [ 96%]
tests/common/commands/test_fetch_s2_data.py ........                                                                                [100%]

============================================================================================================== warnings summary ==============================================================================================================
/usr/lib/python3/dist-packages/urllib3/util/selectors.py:14
  /usr/lib/python3/dist-packages/urllib3/util/selectors.py:14: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
    from collections import namedtuple, Mapping

/usr/lib/python3/dist-packages/urllib3/_collections.py:2
  /usr/lib/python3/dist-packages/urllib3/_collections.py:2: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
    from collections import Mapping, MutableMapping

/usr/local/lib/python3.7/dist-packages/wandb/util.py:37
  /usr/local/lib/python3.7/dist-packages/wandb/util.py:37: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
    from collections import namedtuple, Mapping, Sequence

/usr/local/lib/python3.7/dist-packages/wandb/vendor/graphql-core-1.1/graphql/type/directives.py:55
  /usr/local/lib/python3.7/dist-packages/wandb/vendor/graphql-core-1.1/graphql/type/directives.py:55: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
    assert isinstance(locations, collections.Iterable), 'Must provide locations for directive.'

-- Docs: https://docs.pytest.org/en/latest/warnings.html
================================================================================================ 199 passed, 15 skipped, 4 warnings in 2.10s =================================================================================================
root@ac4354aaa2ba:/data-processing# pytest -m slow
============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.7.5, pytest-5.3.1, py-1.11.0, pluggy-0.13.1
rootdir: /data-processing, inifile: pytest.ini, testpaths: tests
plugins: cov-2.5.1
collected 214 items / 199 deselected / 15 selected

tests/test_extract_definitions.py ...........ssss                                                                                [100%]

============================================================================================================== warnings summary ==============================================================================================================
/usr/lib/python3/dist-packages/urllib3/util/selectors.py:14
  /usr/lib/python3/dist-packages/urllib3/util/selectors.py:14: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
    from collections import namedtuple, Mapping

/usr/lib/python3/dist-packages/urllib3/_collections.py:2
  /usr/lib/python3/dist-packages/urllib3/_collections.py:2: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
    from collections import Mapping, MutableMapping

/usr/local/lib/python3.7/dist-packages/wandb/util.py:37
  /usr/local/lib/python3.7/dist-packages/wandb/util.py:37: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
    from collections import namedtuple, Mapping, Sequence

/usr/local/lib/python3.7/dist-packages/wandb/vendor/graphql-core-1.1/graphql/type/directives.py:55
  /usr/local/lib/python3.7/dist-packages/wandb/vendor/graphql-core-1.1/graphql/type/directives.py:55: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
    assert isinstance(locations, collections.Iterable), 'Must provide locations for directive.'

tests/test_extract_definitions.py::test_model_extracts_simple_definitions
tests/test_extract_definitions.py::test_model_extracts_simple_definitions
tests/test_extract_definitions.py::test_model_extracts_simple_definitions
tests/test_extract_definitions.py::test_model_extracts_simple_definitions
tests/test_extract_definitions.py::test_model_extracts_simple_definitions
tests/test_extract_definitions.py::test_model_extracts_nickname_before_symbol
tests/test_extract_definitions.py::test_model_extracts_nickname_before_symbol
tests/test_extract_definitions.py::test_model_extracts_nickname_symbol_filter
tests/test_extract_definitions.py::test_model_extracts_nickname_symbol_filter
tests/test_extract_definitions.py::test_model_extract_abbreviation_acronym
tests/test_extract_definitions.py::test_model_extract_abbreviation_acronym
tests/test_extract_definitions.py::test_extract_abbreviation_acronym
tests/test_extract_definitions.py::test_extract_abbreviation_acronym
tests/test_extract_definitions.py::test_model_extract_abbreviation_shortened_word
tests/test_extract_definitions.py::test_model_extract_abbreviation_shortened_word
tests/test_extract_definitions.py::test_extract_abbreviation_shortened_word
tests/test_extract_definitions.py::test_extract_abbreviation_shortened_word
  /usr/local/lib/python3.7/dist-packages/catalogue.py:138: DeprecationWarning: SelectableGroups dict interface is deprecated. Use select.
    for entry_point in AVAILABLE_ENTRY_POINTS.get(self.entry_point_namespace, []):

tests/test_extract_definitions.py::test_model_extracts_simple_definitions
  /usr/local/lib/python3.7/dist-packages/catalogue.py:126: DeprecationWarning: SelectableGroups dict interface is deprecated. Use select.
    for entry_point in AVAILABLE_ENTRY_POINTS.get(self.entry_point_namespace, []):

-- Docs: https://docs.pytest.org/en/latest/warnings.html
=================================================================================== 11 passed, 4 skipped, 199 deselected, 22 warnings in 168.38s (0:02:48) ===================================================================================

Overall, it looks good to me. Just curious, maybe I missed this part, is there any testing has been done to make sure that missing the key "paper_id" will not crash anything downstream? Maybe it is part of the pytest?

@Mosqidiot I put some notes about some testing I did around this for the old reader/scholarphi reader here:
https://github.com/allenai/scholar/issues/31778#issuecomment-1104382940. Things seemed okay to me (though @kyleclo thinks we might not even necessarily care about that now that we have the new reader so maybe that doesn't matter at all).
For the new reader, making this change alone will not affect what the frontend gets from s2airs. I've split up the remaining work in roughly two:

Get the rest of the backend pipeline from here through s2airs set up. As part of that, ensure that the s2airs API does not include citations/bib entries that are unmatched. (https://github.com/allenai/scholar/issues/31779)
Add bib entry text and bib entries/citations missing matches to s2airs API output, after coordinating with new reader frontend people. (https://github.com/allenai/scholar/issues/31811)

FYI @kyleclo @andrewhead


Update UI to decouple DetailCommand and UiManager and reflect immediate UI changes

Tinkered with the UI and found a way to decouple DetailCommand and UiManager, and to reflect updates immediately on the PersonViewPanel. Generalized it to a few other commands that modify the details of the contact.
The AddressBook has an attribute called detailedPerson, which is initialized to null.
In separate Commands, the person(toEdit, toSchedule, toMark etc) will be used to set the detailed person through model -> modelManager -> AddressBook.
Then in MainWindow#executeCommand, after every command is executed and a CommandResult is returned, in the finally block the PersonViewPanel will be updated with the latest detailedPerson, which is received through logic -> logicManager -> model -> modelManager -> AddressBook.
The implementation is similar to filteredPersons, but I didn't make a JavaFX implementation (with Observeable and listeners) because of time limitations and JavaFX skill issue :( ( I love JavaFX :D )
What's to be expected:

When user starts the app, the user should expect to see this PersonViewPanel (it doesn't matter if the address book is populated, because detailedPerson is initialized as null)

Any command that modifies the contact, like EditCommand, ScheduleCommand etc, will cause the detailedPerson in AddressBook to be updated and reflected immediately in PersonViewPanel. (It doesn't matter if preceding PersonViewPanel is not about the contact that is edited)

Before edit

After edit

DeleteCommand and ClearCommand will cause the PersonViewPanel to be cleared, reverting to the one in 1.

Something could be done for DeleteCommand (like the Panel remains the same if deleted contact is not the one in the Panel, but for now I can't think of a way to do it)

Note that the PersonViewPanel will be restored to the default in 1. after exiting and relaunching the app.

Those are the tentative edits that I make in this branch. Making this PR a draft because it's not complete yet (pending resolve merge conflicts and open for suggestions)
This PR can be discarded if there is a better implementation.
Closes #175

Moved welcome message to ResultDisplay, so that's the first thing they see.


Introduce Microsoft.Terminal.UI and consolidate UI helpers

This pull request introduces the module Microsoft.Terminal.UI.dll, and moves into it the following things:

Any IDirectKeyListener
All XAML converter helpers from around the project

... including IconPathConverter from TerminalSettingsModel
... but not EmptyStringVisibilityConverter, which has died

It also adds a XAML Markup Extension named mtu:ResourceString, which will allow us to refer to string resources directly from XAML. It will allow us to remove all of the places in the code where we manually set resources on XAML controls.

msbuild vcxproj ProjectDependencies
is a tire fire

discussion: what if we just disable the PCH for this one and make our include stack better

At this point, I have forgotten why it is not ready for review. I'm sure I will figure out why soon enough.

I'd reckon my earlier reluctance to merging this was because it's another GB of pch we need to carry around.

Nowadays there's a very nicely written doc for header units: https://learn.microsoft.com/en-us/cpp/build/walkthrough-header-units?view=msvc-170  I think we should migrate to that. In fact, they even say:

Header units are the recommended alternative to precompiled header files (PCH).

Nowadays there's a very nicely written doc for header units

I have a couple threads with Scott and Cameron about doing just that. There was just s o m e t h i n g   e l s e going on for the last 6 months that prevented me from caching that in for long enough 😂. I reckon I'll probably give that a shot this year

I'm going to resolve the conflicts and merge this, because I want to use the EmptyStringVisibilityConverter in my PR.

I'm surprised the existing uses of local:Converters didn't merge conflict

@zadjii-msft i will need a second tap on this due to the merge policy

oof this broke the canary builds pretty bad
https://microsoft.visualstudio.com/Dart/_build/results?buildId=92144278&view=results

oof this broke the canary builds pretty bad
https://microsoft.visualstudio.com/Dart/_build/results?buildId=92144278&view=results

#16811


Can not get API_Key working

I simply cannot get this to work.
I have used the latest image and built from the Dockerfile.
No matter what it appears the GUI cannot talk to the API.
I have changed the API_KEY in the pdns.conf file and rebuilt.
Always connection refused on port 8081.
exec into dockerfile and curl <IP_ADDRESS>:8081 connection refused.
Amy I making a simple mistake with the key?

How are you spawning the container? You need to map the port 8081 when running it, by default is not exposed but you can force it via CLI.


[ENH] Lua stacktrace on managed error

Print lua's debug.traceback when error in managed function occurs

I'm not sure if debug.traceback will work for us, but we definitely need a better experience with exceptions.


Tensorflow parallel decorator

@tensorflow_parallel
Note that this is stacked on top of #871 and thus includes also its commits.
Tensorflow has more involved handshaking than pytorch. We use S3 files to exchange information of each node's address and port. In the future, this could be rewritten to use a simple tcp server to exchange the info.
Simple test flow:
 python test/core/metaflow_extensions/frameworks/tensorflow_parallel_test_flow.py --no-pylint run

Closing as leaving the project. Can be resurrected.


⚠ Panoramas has degraded performance

In 1ffb59e, Panoramas ($SITE_URL_PANORAMAS) experienced degraded performance:

HTTP code: 200
Response time: 9790 ms

Resolved: Panoramas performance has improved in 52cb15c after 7 minutes.


Subscript out of bounds error for much the same PDF

Thanks for this awesome package. It works well on all the .pdf-documents I have tried it on. I do however have a problem about the extract_tables like below. Also, You can reproduce this in your R studio, too.
This works with this pdf in 2015 :
library(tabulizer)
path2pdf <- "/Users/HidetakaKo/Desktop/2015-cookpad.pdf"
out <- extract_tables(path2pdf)
as.data.frame(out[[1]])

This doesn't work with this pdf in 2016 :
library(tabulizer)
path2pdf <- "/Users/HidetakaKo/Desktop/2016-cookpad.pdf"
out <- extract_tables(path2pdf)
as.data.frame(out[[1]])

These .pdf-documents format is much the same with the previous one.
I'm working on a MacAir with
OS X 10.11.6
R 3.3.1
Exploratory Desktop
RStudio Version 0.99.887

What does out look like? (e.g., can you show str(out)? It seems like the extraction is working, but the format isn't exactly what you're looking for. You might try modifying the method argument of extract_tables() so that you get something other than a matrix back.


add option vsc.hover.str.max.level

What problem did you solve?
Added an option, vsc.hover.str.max.level, that configures how R objects hover information is displayed. This is the max.level arg in the str call in capture_str in init.R. It was previously set to 0 which just captured type/dimension info for data frames.
Now the user can configure it to show more info for data frames, e.g. vsc.hover.str.max.level = 2:

(If you do not have screenshot) How can I check this pull request?
Try this example code with  vsc.hover.str.max.level = 0 and  vsc.hover.str.max.level = 2 Hover over the variables and notice the improved info, without becoming overly large:

library(nycflights13)

foo <- flights

bar <- airports

biz <- letters

baz <- as.list(letters)

var <- list(first = "a",
            second = "b",
            third = list("c", list("d")))

Note I also added the vec.len = 1 arg into the str call. It has no effect at the default level.

Adressing #540

I still want to just download the VSIX from this branch to check for any interaction with the LSP extension. Probably don't merge until I've done that.

No issues when using with the LSP extension.

This string will appear not only in the hover, but also in the description of the completion items of session symbols.

I guess we could name this option vsc.str.max.level?

Whoah... I had no idea this was a thing. It seems it never shows for me unless I click the little 'Read more' arrow next to the df in the completion list, and then it always shows. Nice!
New name sounds good.

Okay done, the option is now vsc.str.max.level.


strange if statements

As I am checking the commit https://github.com/ultravideo/uvgRTP/commit/decde85859e8607242dfeb9a5b36666536c85c2a for the issue #12 I saw a lot of code like this:
if (!(pkt_dispatcher_ = new uvgrtp::pkt_dispatcher()))
        return free_resources(RTP_MEMORY_ERROR);

I am not sure I understand what this is supposed to do ?

Hi,
it tries to allocate memory for pkt_dispatcher_ object and if the allocation fails, i.e., nullptr is returned, the code frees all memory thus far allocated and returns an error code.

Although I just checked and it seems that new doesn't return nullptr ever (unlike malloc) but instead throws an exception so that code doesn't really make sense. I guess it should be fixed

That why I asked :-)

We can use this issue. You can do it if you want, contributions are appreciated

Ok, I will get to it but it ma take a while. I have two additional questions/comments.

I would probably replace some of those raw pointer with smart pointers. But I will do that in another PR. Otherwise this PullRequest will get to big ?!
I would like to do a lot of small changes and fixed of stuff I have found. Should I do those in one PR under one new issue ?

I have another question.
I an error of "std::bad_alloc" happens because of a "new" call, I expect that we cannot recover from that or handle it in a useful way?
So I would just let it through.
Any other opinion ?

Try to keep the commits small/self-contained so it'll be easier to bisect through if it every comes to that. As for PRs, I think it would be nicer if one PR would reference one issue so in that sense it would be nicer if this issue wouldn't be reused beyond this pointer issue and a new issue would be created for new improvements.
I think std::bad_alloc can be let through, yes.

Fixed by PR. Thanks!


Update yosys version to 0.44

This commit also disables creating $scopeinfo cells in large designs tests.
$scopeinfo is Yosys internal cell and should be removed before passing netlist to another tool.

LGTM, compiles cleanly against 0.44


[RFC] Deselect tests instead of faking passed ones

Faking them is incomplete / different from how pytest does it (e.g. no
pytest_runtest_logstart before pytest_runtest_logreport, and doing
it from pytest_collection_modifyitems in the first place).

Thanks for the PR!
I don't know how obvious this is, but CI is failing. Your commits have red crosses next to them and two out of three CI checks are listed as "failed".
To me CI failures means that the code doesn't work.
And as long as the code doesn't work there's no point for a human to review it.
If you want to reproduce the CI failures locally, you should be able to install tox and do tox --skip-missing-interpreters.
When the code works, do add me as a reviewer and I'll have a look at it.
Also, if you could provide a concrete example of what this change means for end users, that would be nice. As in "Before this change, if a test was avoided then XXX. With this change in place, you get YYY instead." Bonus points for providing output from actual test runs.

CI failures are only related to code style / typing - and can be easily addressed if the code makes sense in general.
Closing this as not really wanted for now - IIRC the idea here was to not fake reports, but deselect tests, since it is easier and the current faking of reports assumes a certain order of processing in pytest internals.
I'm not using pytest-avoidance myself (but only quickly looked at its code / gave it a spin), and came up with this.

I don't know how obvious this is, but CI is failing. Your commits have red crosses next to them and two out of three CI checks are listed as "failed".
To me CI failures means that the code doesn't work.
And as long as the code doesn't work there's no point for a human to review it.

As a bystander — this seems combative and patronizing.

I'm sorry if my tone was condescending, that was never my intention.
It was unclear to me what the expectation was from @blueyed given that CI was failing and nothing more was happening.
Given your outside perspective @max-sixty, I believe I should have communicated this uncertainty of mine differently.
Apologies @blueyed if I offended you.

Thanks for your thoughtful reply @walles

@blueyed, is this correct?
Before this change, if there was a cache hit, the test would be reported as "successful" without actually being run.
With this change in place, if there is a cache hit, the test is reported as "skipped", and a message is printed at the end counting the number of skipped-due-to-cache-hits tests.


Verify that a js_binary that spawns a node child process gets the toolchain-managed node interpreter

This may have been carried over from rules_nodejs but we aren't sure there's a test to verify it.

@jbedard Any updates on this one?


get rid of PR check that always fails for help dot

IGNORE THIS THIS IS A TEST

A preview of your ExpensifyHelp changes have been deployed to https://0334a3af.helpdot.pages.dev ⚡


Web - Inconsistent styling when selecting phone number with @ mention in chat.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open any chat.
Type @ and select a phone number from the list.
Observe that the styling and properties are different from when selecting an email.

Expected Result:
The styling and properties should be consistent when selecting a phone number or email with @ mention.
Actual Result:
The styling and properties are not consistent when selecting a phone number with @ mention compared to selecting an email.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/cf1b7886-5ebf-43df-969a-7e81312adac6
https://github.com/Expensify/App/assets/93399543/7244f1b8-3ad7-47ef-b119-49aec0f277e5
Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687721109789049
View all open jobs on GitHub

dupe of https://github.com/Expensify/App/issues/21684. Only those phone numbers are not rendered as mentions which don't have accounts because they don't follow the format<EMAIL_ADDRESS>

This is a known issue https://expensify.slack.com/archives/C01GTK53T8Q/p1683753105314829
cc: @puneetlath

Yes this is a known bug and not something that we are currently going to fix. It will be fixed in the next iteration of mentions.


how to run baseline clip detection model

Hi! Thanks for your impressive work! I'm wondering is it possible to run the baseline CLIP detection in table 4 with the released code?

Hi, @twangnh, thanks for your suggestion! We will add that evaluation into this repo. Will let you know once completed.

Hi @twangnh, the released code has already supported the evaluation on CLIP (Table 4 results).
You can find the CLIP weights in our Model Zoo. After downloading it, simply replace our RegionCLIP weights (e.g., in this script) to CLIP weights (e.g., ./pretrained_ckpt/clip/teacher_RN50_student_RN50_OAI_CLIP.pth). Then the results at Table 4 can be reproduced.

@jwyang @YiwuZhong Thanks for noting to me, just to make sure, I'm wondering if the CLIP weights (./pretrained_ckpt/clip/teacher_RN50_student_RN50_OAI_CLIP.pth) are the same as original CLIP?

@twangnh Yes, the weights are the same as original CLIP. We copied CLIP's weights into this file to make Detectron2 convenient to load the pre-trained weights.

thanks!


Auto-complete breaks

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Windows 10 (14986)
Hyper.app version: 1.0.0
Link of a Gist with the contents of your .hyper.js:
Relevent information from devtools (CMD+SHIFT+I on Mac OS, CTRL+SHIFT+I elsewhere):
The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

When using tab to complete directories, it seems it gets lost after pressing tab a few times.
When typing cd at and tab several types here is what happens:

If that helps, diretories matching at are:

athenajs
athenajs-es5
athenajs-gods

@warpdesign could open dev tools and copy html code with this issue?

Can confirm happening for me, as well. Same symptoms as shows in the animated GIFs above.
Windows 10 (Build 14393)
Hyper version 1.0 (via Windows installer)

@warpdesign  Go ya. Just tested the app on windows for the first type. Got to see this tab problem.

This is related to the space of hterm in the currentRow somehow. I will test it.

@ppot I also just noticed that this happens within applications such as node. If I've got the node.js REPL running, and I'm typing in some code, the cursor and text hop from left to right as shown in the GIFs above.

@ryancole  On windows/linux or OS X?

@ppot Windows 10 (Build 14393)

Here's a GIF of me just trying to get the issue to appear. On the first and second lines I type in, everything is fine. On the third and fourth lines, I press up arrow to recall the past line and the issue appears. On the third entry, moving the cursor back across the text caused it to get garbled and unreadable. On the fourth entry it simply appeared off to the right, similar to the above GIFs.

FWIW, I'm having this issue also and from what I can tell it seems to have something to do with the pace at which you are tabbing.
If you press slowly, like 0.5-1s between keypresses, it seems to work as normal. But if you speed up, i.e spam the key, or keeping TAB pressed, it seems as if Hyper can't catch the keypresses fast enough and sooner or later it will insert an actual TAB.

Same issue. Windows 10, Hyper 1.1.0. I can also reproduce it when tabbing relatively slow.

Hi,
I have the same issue on MacOS Sierra 10.12 and latest version of hyper (1.3.3).
For me the issue comes to my zsh theme (hyperzsh).
I remove hyperzsh theme and it's ok now.
Have a nice day.

I am having the same issue on MacOS Sierra. Has anyone figured out a fix?

Can anyone confirm that this issue is fixed in the most recent release? cc @yousefissa @gregorygenova @warpdesign 🤞

I have not seen it yet, but I will post back if I do! @timothyis

Thanks! Please re-open if you encounter this in 2.x 👍


merging startStopTables now complete?

@davidjamesbeck I got a little confused in the merge of your branch, apparently doing it twice, with slightly different results.
I just pushed a change to two files.  In the first I still had a remnant startStopTable passed as a parameter to the Text constructore:

eafToWebPage.py (my exploratory code in the yaml->eaf->html project)
test_IJalLine.py: I commented out the audioData parameter:
   x3 = IjalLine(doc, 3, tierGuide) # ,audioData='a,b,c')

I hope I got this right.  Do let me know.

What you did looks right—as you can see, the audioData parameter in that line of code was a bit of nonsense I stuck in as a placeholder before I fixed the code not to need the startStopTable. Not sure why I didn’t get an error running make, I fixed that in a number of other places.
Cheers
David

On Jul 7, 2019, at 11:05 AM, Paul Shannon<EMAIL_ADDRESS>wrote:
@davidjamesbeck https://github.com/davidjamesbeck I got a little confused in the merge of your branch, apparently doing it twice, with slightly different results.
I just pushed a change to two files. In the first I still had a remnant startStopTable passed as a parameter to the Text constructore:
eafToWebPage.py (my exploratory code in the yaml->eaf->html project)
test_IJalLine.py: I commented out the audioData parameter:
x3 = IjalLine(doc, 3, tierGuide) # ,audioData='a,b,c')
I hope I got this right. Do let me know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/paul-shannon/slexil/issues/41?email_source=notifications&email_token=AKN4HBQYSBTHX2DYBYEN6HTP6IO5DA5CNFSM4H6WENEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5W5NSQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AKN4HBTIGQTABQQ4W7ZHVZLP6IO5DANCNFSM4H6WENEA.


support for sql server 2000?

Could I use this driver to connect sql server 2000?When I did this, I got an error:
Login error: unexpected EOF
I used the correct connect information...   :(

Currently not, oldest supported version is 2005

Thank you!
Excuse me, could you tell me that how can I connect to sql server 2000.
@denisenkom

I would try a ODBC driver:
https://godoc.org/?q=odbc


EncoderDecoder Configuration Issue

I've identified a problem in the EncoderDecoderConfig class within the architecture module of the torchscale package.
The EncoderDecoderConfig class currently does not contain the normalize_output element. This missing element is causing some functionality of the package to not work as expected. Specifically, when the EncoderDecoder class is used with a EncoderDecoderConfig object, the lack of the normalize_output element can lead to incorrect behavior.
I recommend adding the normalize_output element to the EncoderDecoderConfig class. I believe that this change will resolve the issue and make the EncoderDecoder class function as expected.
Furthermore, I have added a new GitHub Action in pull request #31  to help prevent issues like this in the future.

Thank you for the contribution! Already fixed the config issue and merged the PR.


Test model with only 1 valid set of parameters

Currently the parameters in the test models are interdependent, leading to often non-convex cost function. Add model with only 1 valid solution.

Examples added: https://github.com/sdu-cfei/modest-py/pull/44


Add button to open repository

Add an option to open the git repository like the plugin in vscode:

I really like this idea. Didn't know the button text is customizable.

Hey, perhaps you could use the 2nd button to open the file being edited (if not ignored by VCS)
This could lead to 404 errors if the file was not commited yet, though

I think if the file isn't commited, the second button should be pointed to the folder of the file or could be customized. For example to the production website of the current repository

@Almighty-Alpaca Why it's "blocked by discord"?

This is currently marked as "blocked by Discord" because the old discord-rpc library used by the plugin doesn't support custom buttons. There was an attempt to move to the newer GameSDK (mainly in hope of fewer connection issues), but that one doesn't support custom buttons as well (last time I checked).

Can this get some love? Or do we really have to use deprecated API to implement this?

Is this still beeing worked on e.g have you found a library that supports buttons?


Layout of "about" pages

What should the banner look like?
Do we need any special styling for the content?
Should there be a sidebar?

(Enumerating the header and footer links is covered by #2.)

Specs delivered, and a skeleton is up. details can be filed separately.


Subtitles/SRT files are not being sent to other players + Non-instance owner is unable to enter in field.

It seems that people are not being sent the SRT file in the new Unity 2022. The subtitles load up for the instance owner + if they enter the srt in with local enabled.
It also seems like the non-instance owner is not able to enter in the text box field for the SRT.

Did you encounter the issue mentioned in https://github.com/jacklul/USharpVideo-Subtitles/issues/6 ?

I am using the beta. But it doesn't look like I am encountering any compiling errors atm like what that one issue is referencing.

It seems like the synchronization bug appears only in the beta version.
Second beta version will be up soon.

Hey, were you able to check out second beta version?

Oh right. Thanks for the checkup. I got it working on my map =)


Integration of telescope_layout tools into gammasim-tools

Merge telescope_layout repository into gammasim-tools. This avoids duplication of code. Archive the telescope_layouts repository after the successful integration into gammasim-tools.
Following applications will be included into gammasim-tools:

print_layout.py (rename to print_array_elements.py): prints coordinates of array elements (in most cases telescope positions) in the different used coordinate systems
compare_layouts.py (rename to compare_array_elements.py): compare the positions of two lists of array elements and print differences

Integrate updates in telescope_layout code:

telescope-layouts/layout_array.py --> simtools/layout/layout_array.py
telescope-layouts/layout_telescope.py --> simtools/layout/telescope_position.py
review code in simtools/layout at the same time.

Additional functionality:

read telescope positions from DB and print in positions in different coordinate systems.

Suggest not to include the plotting in this issue (see also Sites branch), but do this as a next step.

Some points to be discussed.
simtools/layout/telescope_position.py:

large number of very similar functions (e.g., hasLocalCoordinates(), hasUtmCoordinates, etc). Generalize to hasCoordinates(system='utm').
units and names are defined in data/parameters/telescope-position_parameters.yml - would simplify the code if we put this as a dict into a separate python module and import it (don't need any reading functions for yaml then, etc). Or is it needed at all? Seems that all units are hardcoded anyway using the @u.quantity_input decorators from astropy.units
some of gammasim-tools classes have fromKwargs methods, others not. Same for __repr__ functions. This is nice, but if we don't use them, do we want it?
suggest to rename 'local coordinates' to 'CORSIKA coordinates'

telescope_layout is a bit complicated. Suggest to add a module called array_element, including the coordinates in a given coordinate system only. telescope_layout would than have instances for each coordinate system of array_element.

A couple discussion points, related to coordinate systems and telescope positions (see also draft PR #330)
1. Telescope altitude.
Decided to use the altitude (asl) as 'z' position for all coordinate system, including the corsika system. The logic is that the telescope position should be independent of the telescope type (i.e., sphere radius).
To write out the coordinates in corsika coordinates, one out use in the TelescopePosition class the function
corsikaZ = convertTelescopeAltitudeToCorsikaSystem(telAltitude, corsikaObsLevel, corsikaSphereCenter)

If we agree on that, then I go carefully again through the code to ensure that this is propagated correctly.
2. CORSIKA sphere center and radius
The sphere centre is required to calculated the CORSIKA Z position and is currently hardwired in the code:
   @staticmethod
    def _corsikaTelescopeDefault():
        """
        Default values for CORSIKA telescope dict

        Returns
        -------
        dict
            corsika telescope default values

        TODO: discuss hardwired corsika parameters

        """
        return {
            "corsika_obs_level": None,
            "corsika_sphere_center": {
                "LST": 16.0 * u.m,
                "MST": 9.0 * u.m,
                "SST": 3.25 * u.m,
            },
            "corsika_sphere_radius": {
                "LST": 12.5 * u.m,
                "MST": 9.6 * u.m,
                "SST": 3.5 * u.m,
            },
        }

This also requires a function to derive the telescope type/class from the telescope name.
Could we get rid of this? Is this information in the data base? If yes, could you help me on how to get it?
The sphere radius is required for the writing of the CORSIKA telescope configuration, I guess it is also in the DB?

1. Telescope altitude.
Decided to use the altitude (asl) as 'z' position for all coordinate system, including the corsika system. The logic is that the telescope position should be independent of the telescope type (i.e., sphere radius).
To write out the coordinates in corsika coordinates, one out use in the TelescopePosition class the function
corsikaZ = convertTelescopeAltitudeToCorsikaSystem(telAltitude, corsikaObsLevel, corsikaSphereCenter)

If we agree on that, then I go carefully again through the code to ensure that this is propagated correctly.

The concept is perfectly fine, but why would the user ever need just the altitude? Why is it not "convert to CORSIKA" coordinates which takes care of everything all at once?

   @staticmethod
    def _corsikaTelescopeDefault():
        """
        Default values for CORSIKA telescope dict

        Returns
        -------
        dict
            corsika telescope default values

        TODO: discuss hardwired corsika parameters

        """
        return {
            "corsika_obs_level": None,
            "corsika_sphere_center": {
                "LST": 16.0 * u.m,
                "MST": 9.0 * u.m,
                "SST": 3.25 * u.m,
            },
            "corsika_sphere_radius": {
                "LST": 12.5 * u.m,
                "MST": 9.6 * u.m,
                "SST": 3.5 * u.m,
            },
        }

This also requires a function to derive the telescope type/class from the telescope name.
Could we get rid of this? Is this information in the data base? If yes, could you help me on how to get it?
The sphere radius is required for the writing of the CORSIKA telescope configuration, I guess it is also in the DB?

The sphere radius (and more generally any CORSIKA parameters) are not in the DB. A few weeks ago we discussed first getting everything necessary organised in a yaml file and once we are sure we have everything, open a new collection in the DB for CORSIKA parameters (will require some thought about versioning).
That yaml file already exists (data/corsika/corsika_parameters.yml) and in fact also contains these spheres. I suggest modifying that yaml file to fit exactly what you need (including adding the unit and setting the name as you wish it to be) and use that. We will propagate it later to the DB and modify the way you read it.

I wasn't aware that we are using M-01 anywhere. The only names I am familiar with in gammasim-tools are the full names North-MST-NectarCam-D which are composed of the site, class (should be type), type (should be suffix). So I am not sure what you meant by changing the naming in gammasim-tools.

I did not integrate the tool compare_layouts.py from the telescope-layouts repository and suggest no to do this at this point.
The tool compares two list of telescope positions and prints differences. This was very useful when optimising the array layouts and when layout files have been exchanged between different people. I did not use it since a very long time and I don't see an application for it now.
Ok with everyone? I  would close this issue then.

Sure, can always reopen if we see a need for this tool

Might be only in the layout files, e.g.
https://github.com/gammasim/gammasim-tools/blob/master/data/layout/telescope_positions-South-4MST.ecsv
I suggest to change the telescope names in these files to have always LST/MST/SST etc. Or do we want to move to the CTAO-official names of LSTS/LSTN ?

On 22. Sep 2022, at 10:01, orelgueta @.***> wrote:
I wasn't aware that we are using M-01 anywhere. The only names I am familiar with in gammasim-tools are the full names North-MST-NectarCam-D which are composed of the site, class (should be type), type (should be suffix). So I am not sure what you meant by changing the naming in gammasim-tools.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.

Dr Gernot Maier
CTA
Deutsches Elektronen-Synchrotron DESY
Ein Forschungszentrum der Helmholtz-Gemeinschaft
Platanenallee 6, D-15738 Zeuthen, Germany
Tel.: +49  33 7627 7598
Internet: www.desy.de/cta
Besucheradresse: 1X07

I would like to move to the CTAO-official names. It would require quite a lot of changes and a large change to the DB, but it's better to do it as soon as possible I would say (as long as we get a promise those are the final names).
We could wait with this change until after 0.4.0 or until after the mini-release, but it's a change we should in my opinion.

This was done and we agreed to close.


Not helpful: Using Managed Identity with Azure Communication Services

Section Using Managed Identity with Azure Communication Services makes no sense
It basically says to enable system assigned managed identity on an ACS resource, then give that identity access to the resource it represents.  Maybe it means to grant some other managed identity access to the ACS resource, but it also does not say what access to grant.  This should be rewritten for clarity and specify exactly what access to grant for what functionality.
Also the second to last sentence is a fragment that makes no sense. "Now that you have learned how to enable Managed Identity with Azure Communication Services."

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0e659def-d112-d5d7-7112-03e0f33271dd
Version Independent ID: ab4b80df-4ce1-dfb9-7334-964a7fa93e56
Content: Azure Communication Services support for Managed Identity
Content Source: articles/communication-services/how-tos/managed-identity.md
Service: azure-communication-services
GitHub Login: @Joeleniqs
Microsoft Alias: joelen

@jordanmills
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

Just submitted some feedback from the on-page feedback buttons on this. Its crazy how hard it is to figure out how to authenticate to this service with managed authentication. The fact that this page claims to be doing this but is in fact describing the exact opposite (how to let ACS authenticate to other resources) is disappointing.
The real documentation for this is nested under the SMTP articles for some reason. https://learn.microsoft.com/en-us/azure/communication-services/quickstarts/email/send-email-smtp/smtp-authentication#creating-a-custom-email-role-for-the-microsoft-entra-application
Tucked away in this article is the fact that you need to assign the "Contributor" privileged admin role to principals that need to send email, which is kind of crazy in and of itself - why is there not a built-in role that grants email-sending permissions? I don't think I've ever seen any other Azure service where the official instructions for granting the most basic usage permission of a resource starts out with "here's how to create custom roles in azure".

Related: https://github.com/MicrosoftDocs/azure-docs/issues/109461

Just submitted some feedback from the on-page feedback buttons on this. Its crazy how hard it is to figure out how to authenticate to this service with managed authentication. The fact that this page claims to be explaining this but is in fact describing the exact opposite (how to let ACS authenticate to other resources) is disappointing.
The real documentation for this is nested under the SMTP articles for some reason. https://learn.microsoft.com/en-us/azure/communication-services/quickstarts/email/send-email-smtp/smtp-authentication#creating-a-custom-email-role-for-the-microsoft-entra-application
Tucked away in this article is the fact that you need to assign the "Contributor" privileged admin role to principals that need to send email, which is kind of crazy in and of itself - why is there not a built-in role that grants email-sending permissions? I don't think I've ever seen any other Azure service where the official instructions for granting the most basic usage permission of a resource starts out with "here's how to create custom roles in azure".

Thank you, that definitely helps.  Or at least demonstrates the futility.  That's the kind of thing that should be a data plane action.  There's no world where it's okay to give a client application full control of a resource it needs to use for a specific purpose.  How am I supposed to take any of this seriously when least operating privilege isn't even an afterthought?


Changes based on the latest spec

Based on the latest spec changes, I've made the following updates:

Add info on prebuilding
Add info on image labels
Create a guide for Feature development and publication (based on https://github.com/devcontainers/feature-template)

Thanks @Chuxel! Added your suggestions and moved to earlier in spec.md. Let me know what you think.

Thanks @Chuxel! Will merge now and then open a PR to update https://github.com/devcontainers/spec/blob/main/docs/specs/devcontainer-reference.md.

Opened https://github.com/devcontainers/spec/pull/127.