[1.5] Fix local install, add integration tests

Manual port of https://github.com/istio/istio/pull/22411.

@ostromart: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test gencheck_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test gencheck_istio_release-1.5

lint_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test lint_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test gencheck_istio_release-1.5

lint_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test lint_istio_release-1.5

unit-tests_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test unit-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test gencheck_istio_release-1.5

lint_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test lint_istio_release-1.5

unit-tests_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test unit-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test integ-istioio-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test lint_istio_release-1.5

unit-tests_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test unit-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test integ-istioio-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
4e65330b15c434412e32af8c0b8512e3d08f2ba5
link
/test gencheck_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test unit-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
e4ef0f2ed871e7b743044a7b1d54e54870e88dd5
link
/test integ-istioio-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
4e65330b15c434412e32af8c0b8512e3d08f2ba5
link
/test gencheck_istio_release-1.5

lint_istio_release-1.5
4e65330b15c434412e32af8c0b8512e3d08f2ba5
link
/test lint_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
4e65330b15c434412e32af8c0b8512e3d08f2ba5
link
/test gencheck_istio_release-1.5

lint_istio_release-1.5
4e65330b15c434412e32af8c0b8512e3d08f2ba5
link
/test lint_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
4e65330b15c434412e32af8c0b8512e3d08f2ba5
link
/test integ-istioio-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio_release-1.5
4e65330b15c434412e32af8c0b8512e3d08f2ba5
link
/test integ-istioio-k8s-tests_istio_release-1.5

lint_istio_release-1.5
fde7279eace78f60b48f4abb01c2fb17af90da20
link
/test lint_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ping @howardjohn

@ostromart: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Allow to customize keystore and trustore filename and password via CR

Is your feature request related to a problem? Please describe.
In our organization we use artemis-operator and manage all of PKI infrastructure with cert-manager. It's supports Java's keystores and trustores as certificate output format but doesn't allow to customize key names and sets default as truststore.jks and keystore.jks. In the code:
	keyStorePassword := "password"
	keyStorePath := "\\/etc\\/" + secretName + "-volume\\/broker.ks"
	trustStorePassword := "password"
	trustStorePath := "\\/etc\\/" + secretName + "-volume\\/client.ts"

I see that keystore and trustore names and passwords are hardcoded.
Describe the solution you'd like
I would like to set up this in acceptor spec (i.e. for each SSLSecret) or at least for broker instance. For example, add additional fields in AcceptorType and ConnectorType that has truststore settings too. I can contribute if you don't mind of course.
Best regards!

ArtemisCloud ActiveMQ Artemis Operator supports custom keyStore and trustStore paths adding keyStorePath and trustStorePath entries to the acceptor secret, i.e. supposing the name of the secret created by jetstack cert-manager is broker-cert-secret, the solution is to create an acceptor secret with keyStorePath and trustStorePath entries and to define an extra mount for broker-cert-secret:
oc create secret generic my-acceptor-secret
--from-literal=keyStorePath=/amq/extra/secrets/broker-cert-secret/keystore.jks
--from-literal=trustStorePath=/amq/extra/secrets/broker-cert-secret/truststore.jks
--from-literal=keyStorePassword=
--from-literal=trustStorePassword=
apiVersion: broker.amq.io/v1beta1
kind: ActiveMQArtemis
metadata:
name: ex-aao
spec:
acceptors:
- name: my-acceptor
sslEnabled: true
sslSecret: my-acceptor-secret
...
deploymentPlan:
extraMounts:
secrets:
- broker-cert-secret
...

Works like a charm, thanks!


Query of allowed topics

When creating a allowed topic with:
https://app.notifo.io/api/docs/index.html?url=/api/openapi.json#operation/Users_PostAllowedTopic
There is no possiblity to query the allowed topics again.
I would propose returning them as a field in the GET users/:id endpoint and GET /me:
eg:
{

    "fullName": "string",
    "emailAddress": "string",
    "phoneNumber": "string",
    "preferredLanguage": "string",
    "preferredTimezone": "string",
    "allowedTopics":

[

    "string"

],
    "supportedLanguages":

[

    "string"

],
"supportedTimezones":
[

    "string"

],
"settings":
{

    "property1":

{},
"property2":

        {}
    }

}

I would give it a try and practice my c# coding skills.


Integrates Devappserver1

can we please get a screenshot of the updated UI?

FYI, all dev app server1 changes aren't in 0.2.9 plugins core.

@loosebazooka I'm waiting for your a-ok to merge this PR, after it's gone through code review.

I'm confused, I mean that https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/346 isn't included yet, and it's what we want to end up on before pushing dev appserver 1 changes. I presume this wont affect this PR too much, but it's possible that it could.

@loosebazooka I gave it a test spin with devappserver1 and it seemed to work without a hitch. I kind of assumed you were referring to internal changes that weren't related to the work on our side, but we'll obviously adjust if we need to.
Actually, from https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/346, I don't see any changes in the API, but we might need to provide more parameters than what we otherwise were?

as discussed offline, we decided to update to devappserver1 without a toggleable option to switch to v2. There will also need to be some params that are currently exposed for v2 that will need to be removed for v1. I'll do this in a different PR as it has sufficiently diverged from this one.

This PR becomes obsolete, then.
I'll go ahead and close it.


Cleaned up Game model/schema and added GameCharacter model/schema

Jon is this ready to go? It has merge conflicts. I can resolve them if you need

It's ready to go! I can resolve them, I wasn't sure if that was something I should do or leave for you.

Looks good, thanks Jon!


About flatening the patch

Hi,
Thanks for sharing this implementation. I got one question when flattening the HxW patch to D dimension, you use a FC layer to map it to a fixed dimension. But in the original paper, they use 224x224 to train and 384x384 to test, which can not be achieved if the flatten layer is fixed. Also, in another repo you shared (https://github.com/rwightman/pytorch-image-models/blob/6f43aeb2526f9fc35cde5262df939ea23a18006c/timm/models/vision_transformer.py#L146), they use 1D conv to avoid resolution mismatch problem. Do you know which one is correct? Thanks!

@yueruchen Hi Yifan! If you make sure that both your image sizes are divisible by the patch size, as long as you instantiate ViT with image_size as the maximum image size you will be using (in your case 384), it should work fine for images you pass in of a smaller size

import torch
from vit_pytorch import ViT

v = ViT(
    image_size = 512,
    patch_size = 32,
    num_classes = 1000,
    dim = 1024,
    depth = 6,
    heads = 8,
    mlp_dim = 2048,
    dropout = 0.1,
    emb_dropout = 0.1
)

train_img = torch.randn(1, 3, 256, 256)
test_img = torch.randn(1, 3, 512, 512)

preds_train = v(train_img) # (1, 1000)
preds_test = v(test_img) # (1, 1000)


Simplify lambda expressions when possible

Impact

[ ] Bug fix (non-breaking change which fixes expected existing functionality)
[X] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Use lambda expressions with code block bodies when expression-style bodies. Result of the conversion is shorter and more clear.

Initial/Pre-Review Thoughts
Gets rid of some curly braces that are syntactically unneeded.
Questions I have:

None

Potential risks:

None

What could make the full review difficult:

Nothing


API improvements

Change ValueSet.compose to 0..1 from 0..*
Minor Java API improvements, syntactic sugars, etc.
Support dynamic API docs
Extract branch aware test execution to test.commons.
Expose Elasticsearch Base64 UUID generator
Minor REST API abstractions to simplify development of new REST API routes

Codecov Report

Merging #472 into 7.x will increase coverage by 0.3%.
The diff coverage is 61.95%.

@@             Coverage Diff             @@
##                7.x     #472     +/-   ##
===========================================
+ Coverage     54.98%   55.29%   +0.3%
- Complexity    12118    12413    +295
===========================================
  Files          1717     1718      +1
  Lines         71623    72581    +958
  Branches       8687     8921    +234
===========================================
+ Hits          39381    40131    +750
- Misses        28525    28717    +192
- Partials       3717     3733     +16

Impacted Files
Coverage Δ
Complexity Δ

...rnational/snowowl/snomed/ecl/ecl/impl/AnyImpl.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

...ore/request/rf2/SnomedRf2ExportRequestBuilder.java
92.15% <ø> (ø)
15 <0> (ø)
:arrow_down:

...omed/ecl/ecl/impl/AttributeValueNotEqualsImpl.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

...l/snomed/core/ql/SnomedQueryEvaluationRequest.java
85.38% <ø> (ø)
34 <0> (ø)
:arrow_down:

...l/snowowl/snomed/ecl/AbstractEclRuntimeModule.java
97.67% <ø> (ø)
30 <0> (ø)
:arrow_down:

...nal/snowowl/identity/request/UserLoginRequest.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../snomed/core/ecl/SnomedEclRefinementEvaluator.java
87.71% <ø> (ø)
109 <0> (ø)
:arrow_down:

...omed/ecl/ecl/impl/AndExpressionConstraintImpl.java
46.26% <ø> (ø)
16 <0> (ø)
:arrow_down:

...stry/core/request/CodeSystemGetRequestBuilder.java
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

...l/snomed/ecl/ecl/impl/AttributeConstraintImpl.java
50.89% <ø> (ø)
28 <0> (ø)
:arrow_down:

... and 164 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a16c02...677a5dd. Read the comment docs.


[Help] How to use env var like import.meta.env.VITE_KEY in main/preload ?

Describe the problem you confuse
Vite supports env vars prefixed with "VITE_" if they are placed in the file .env.
However in electron-vite-vue template, env vars like import.meta.env.VITE_KEY can only be used in renderer process.
How to reproduce:

npm create electron-vite & npm i
Add .env file at app root with the content:

VITE_TEST="test string"

Modify electron/electron-env.d.ts:

/// <reference types="vite-plugin-electron/electron-env" />

interface ImportMetaEnv {
  readonly VITE_TEST: string
}

interface ImportMeta {
  readonly env: ImportMetaEnv
}

Add this line into electron/main/index.ts:

console.log("in main process", import.meta.env.VITE_TEST)

Add this line into electron/preload/index.ts:

console.log("in preload", import.meta.env.VITE_TEST)

Add this line into src/main.ts:

console.log("in renderer process", import.meta.env.VITE_TEST)

npm run dev
Result:

BTW, currently I use dotenv to load env vars of .env file into process.env.

It's probable a conservative desing, not sure if it's rihg.
However, usually in Node.js environments, process.env is always avaizble.
  const conf: InlineConfig = {
    // 🚧 Avoid recursive build caused by load config file
    configFile: false,
    envFile: false, // 👈👈👈👈👈👈👈
    publicDir: false,

    build: {
      emptyOutDir: false,
      minify: process.env./* from mode option */NODE_ENV === 'production',
    },
  }

https://github.com/electron-vite/vite-plugin-electron/blob/2df429e643192a0a9a0702b1c3b36544460950b0/packages/electron/src/config.ts#L32

Perhaps, this feature is avaiable in v0.8.2, what do you think about it. My bro 😄 @PAXANDDOS

Thank you for replying!

Perhaps, this feature is available in v0.8.2, what do you think about it. My bro 😄 @PAXANDDOS

Honestly, I thought the env file was exposed everywhere 😅
I was thinking that we don't need .env files here at all, we're building desktop applications with Electron anyways. But then I remembered some cases where you need to have, for example, a hash string for modules, and since all application logic is stored in the main process, exposing environment files to it would be a great idea
@caoxiemeihao So I want to say that yes, it's better to enable the envFile option


Autoplaylist

Adds automatic adding of songs to autoplaylist.
Adds command to remove current song from autoplaylist.
Add alias for !q
Add shuffle mode.

I totally meant to PR this into my own fork. How do I get rid of this? I'm kind of noob at github.

That said, if any of these changes seem interesting to you, I can make a clean fork and try to implement them a bit more cleanly now that I know what I'm doing.


deprecate top-level generate option

Deprecate generate deprecated with resolvers to infer wouldn't be also a bad idea, same as command, considering generate was a big feature of Nuxt 2 with lots of articles and examples using it.
Originally posted by @pi0 in https://github.com/nuxt/framework/issues/10002#issuecomment-1375416701

Concurrency is now implemented in the latest Nitro via https://github.com/unjs/nitro/pull/1223

Concurrency is now implemented in the latest Nitro via unjs/nitro#1223

Would be nice if we had a pre-render section in the docs (maybe a subsection of a Build one)

I actually think that would be a good idea.


Update changelog and CLI reference.

Thanks!
It just need a rebase and we are good to go 👍

@sdispater OK, confession time.  I think I managed to do it right, but you better check it before accepting the changes.

@moigagoo But if you want to feel more comfortable, you can close the PR and open a new one.

@sdispater Thanks for the guide! I've resolved the conflict manually, is it OK?


BIGTOP-3802: Fix Mpack Hive fail to start when kerberos enabled

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
[ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

Metastore in Hive 3.1.3 is not compatible with Hadoop 3.3.x when Kerberos enabled.
Related to https://github.com/apache/bigtop/pull/1001

@timyuer  Thanks for working on it.
But after I combined the https://github.com/apache/bigtop/pull/1001 ,https://github.com/apache/bigtop/pull/1003 with this PR, and rebuilt Hive, it seems HiveServer2 failed to start:
Traceback (most recent call last):
  File "/var/lib/ambari-agent/cache/stacks/BGTP/1.0/services/HIVE/package/scripts/hive_server.py", line 143, in <module>
    HiveServer().execute()
  File "/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", line 352, in execute
    method(env)
  File "/var/lib/ambari-agent/cache/stacks/BGTP/1.0/services/HIVE/package/scripts/hive_server.py", line 53, in start
    hive_service('hiveserver2', action = 'start', upgrade_type=upgrade_type)
  File "/var/lib/ambari-agent/cache/stacks/BGTP/1.0/services/HIVE/package/scripts/hive_service.py", line 101, in hive_service
    wait_for_znode()
  File "/usr/lib/ambari-agent/lib/resource_management/libraries/functions/decorator.py", line 62, in wrapper
    return function(*args, **kwargs)
  File "/var/lib/ambari-agent/cache/stacks/BGTP/1.0/services/HIVE/package/scripts/hive_service.py", line 196, in wait_for_znode
    raise Fail(format("ZooKeeper node /{hive_server2_zookeeper_namespace} is not ready yet"))
resource_management.core.exceptions.Fail: ZooKeeper node /hiveserver2 is not ready yet

................
.........
.....
2022-09-14 08:49:51,350 - Will retry 5 time(s), caught exception: ZooKeeper node /hiveserver2 is not ready yet. Sleeping for 10 sec(s)
2022-09-14 08:50:01,361 - call['/usr/lib/zookeeper/bin/zkCli.sh -server ambari-server:2181,ambari-agent-01:2181,ambari-agent-02:2181 ls /hiveserver2 | grep 'serverUri=''] {}
2022-09-14 08:50:02,086 - call returned (1, '')
2022-09-14 08:50:02,087 - Will retry 4 time(s), caught exception: ZooKeeper node /hiveserver2 is not ready yet. Sleeping for 10 sec(s)
2022-09-14 08:50:12,098 - call['/usr/lib/zookeeper/bin/zkCli.sh -server ambari-server:2181,ambari-agent-01:2181,ambari-agent-02:2181 ls /hiveserver2 | grep 'serverUri=''] {}
2022-09-14 08:50:12,926 - call returned (1, '')
2022-09-14 08:50:12,927 - Will retry 3 time(s), caught exception: ZooKeeper node /hiveserver2 is not ready yet. Sleeping for 10 sec(s)
2022-09-14 08:50:22,938 - call['/usr/lib/zookeeper/bin/zkCli.sh -server ambari-server:2181,ambari-agent-01:2181,ambari-agent-02:2181 ls /hiveserver2 | grep 'serverUri=''] {}
2022-09-14 08:50:23,686 - call returned (1, '')
2022-09-14 08:50:23,687 - Will retry 2 time(s), caught exception: ZooKeeper node /hiveserver2 is not ready yet. Sleeping for 10 sec(s)
2022-09-14 08:50:33,688 - call['/usr/lib/zookeeper/bin/zkCli.sh -server ambari-server:2181,ambari-agent-01:2181,ambari-agent-02:2181 ls /hiveserver2 | grep 'serverUri=''] {}
2022-09-14 08:50:34,521 - call returned (1, '')
2022-09-14 08:50:34,522 - Will retry 1 time(s), caught exception: ZooKeeper node /hiveserver2 is not ready yet. Sleeping for 10 sec(s)
2022-09-14 08:50:44,529 - call['/usr/lib/zookeeper/bin/zkCli.sh -server ambari-server:2181,ambari-agent-01:2181,ambari-agent-02:2181 ls /hiveserver2 | grep 'serverUri=''] {}
2022-09-14 08:50:45,282 - call returned (1, '')

Hadoop: 3.3.4

I deployed Hadoop, zookeeper, Hive, Tez by Ambari UI first, and then enabled Kerberos:

@guyuqi works fine on my machine.

But I MapReduce service check failed at first, but succeed when I run it separately after kerberos enabled

ZhiguoWu's deploy order is:

Deploy Hadoop, zookeeper, Tez by Ambari UI first.
Deploy Hive by Ambari UI first.
Enabled Kerberos.

This lead to the /etc/passwd(source file MapReduce checked) file size changed, and then cause MapReduce Service Check Failed.
This problem maybe caused by a BUG from resource_management in Ambari Server-2.7.5, I will find it and fix it.
All in all, I can make sure this Hive PR is correct.
Can you please try again? @guyuqi
@kevinw66
Thanks.

ZhiguoWu's deploy order is:

Deploy Hadoop, zookeeper, Tez by Ambari UI first.
Deploy Hive by Ambari UI first.
Enabled Kerberos.

This lead to the /etc/passwd(source file MapReduce checked) file size changed, and then cause MapReduce Service Check Failed.
This problem maybe caused by a BUG from resource_management in Ambari Server-2.7.5, I will find it and fix it.
All in all, I can make sure this Hive PR is correct.
Can you please try again? @guyuqi @kevinw66 Thanks.

May I ask which Hadoop version you deploy?

ZhiguoWu's deploy order is:
Deploy Hadoop, zookeeper, Tez by Ambari UI first.
Deploy Hive by Ambari UI first.
Enabled Kerberos.
This lead to the /etc/passwd(source file MapReduce checked) file size changed, and then cause MapReduce Service Check Failed.
This problem maybe caused by a BUG from resource_management in Ambari Server-2.7.5, I will find it and fix it.
All in all, I can make sure this Hive PR is correct.
Can you please try again? @guyuqi @kevinw66 Thanks.

May I ask which Hadoop version you deploy?

Hadoop 3.3.4, compiled by https://ci.bigtop.apache.org/job/Bigtop-trunk-snapshot/.

@timyuer @kevinw66
oops, I found that I did not update my local packages repo and failed to fetch the new built Hive rpms.
After using latest Hadoop and Hive rpms, everything is ok.
LGTM, +1.
Thank you guys for working on it. :-)


Ability to Modify Camera Transform Position at Runtime

Describe the problem
Using MRTK 2.6.1 and Unity 2019.4.25f1 LTS, it's not possible to change the camera position (via code) at runtime. It's possible when running in the editor, but not in the player. Setting Camera.main.transform.position to a new Vector3 does nothing.
The MRTK camera profile being used is: DefaultXRSDKCameraProfile and at runtime the device being used is an Oculus Quest 2.
Describe the solution you'd like
Specifically, the ability to set the position of the transform on the main camera to a new Vector3. This could be a setting that could be enabled/disabled in the MRTK camera profile.
Describe alternatives you've considered
As a work around, I've implemented a system where the entire environment is repositioned and rotated to give the illusion that you've walked up a set of stairs and turned to face the direction you would be facing had you walked up the stairs in real life.
The problem with this alternative is that it requires that you leave everything in the scene as a dynamic object rather than static. This prevents you from having shadows via baked lighting; essentially requiring real time lighting for shadows. On a device like Oculus Quest 2, this is not performant.
Additional context
It's understandable why the camera position is something that you wouldn't want to alter when the application is designed for augmented reality (HoloLens in particular), but for virtual reality, there are a few valid reasons to have this capability.
Movement via the teleportation system works great in single-floor virtual environments. When you need the player to be able to move up or down multiple floors in the environment, the hand gesture teleportation is not ideal. Typically, you can't see where the teleportation cursor is landing.
An example use-case:  the player uses the teleportation system to enter an elevator. Inside the elevator is an up button. They press it. You would then alter the position of the camera to move the player up to another floor in the environment.
Another reason would be if you wanted to move the user a large distance (horizontally), teleporting them to another part of a level without having to load a new scene.

This behavior is unfortunately not controlled by MRTK but is instead inherent in the way Unity keeps the camera aligned with your head.
For this reason, MRTK exposes the MixedRealityPlayspace, which we use for things like teleportation in order to move the camera from one area in the scene to another. You basically need to move a parent of the camera instead of the camera itself.
https://github.com/microsoft/MixedRealityToolkit-Unity/blob/d6398dd1603d7ba9376a0e75ff6e0a6f91d805d8/Assets/MRTK/Core/Utilities/MixedRealityPlayspace.cs#L73-L77

This behavior is unfortunately not controlled by MRTK but is instead inherent in the way Unity keeps the camera aligned with your head.
For this reason, MRTK exposes the MixedRealityPlayspace, which we use for things like teleportation in order to move the camera from one area in the scene to another. You basically need to move a parent of the camera instead of the camera itself.
https://github.com/microsoft/MixedRealityToolkit-Unity/blob/d6398dd1603d7ba9376a0e75ff6e0a6f91d805d8/Assets/MRTK/Core/Utilities/MixedRealityPlayspace.cs#L73-L77

Oh fantastic! Thank you!
I'll give this a shot and see if I can move the camera this way. Sounds simple enough!

@torynfarr Great! Please follow-up here if you run into any blockers!

@keveleigh I can confirm that I'm able to both reposition and rotate the camera using the MixedRealityPlayspace.
    public void OnUpButtonPress()
    {
        MixedRealityPlayspace.Position = UpstairsHotspot.transform.position;
        MixedRealityPlayspace.Rotation = UpstairsHotspot.transform.rotation;
    }

Thanks so much for your quick help!
The way I was doing it before (repositioning the entire environment) was quite difficult to do (given that both position and rotation needed to be changed and destination position was not the pivot point. Way too much math 😅

Glad to hear it!

@keveleigh So, I sort of spoke too soon. I'm able to move and rotate the MixedRealityPlayspace Game Object and this does change the camera's position, however... it doesn't seem to alter the camera's rotation as expected.
The expectation would be that after the rotation is set on the MixedRealityPlayspace, the camera's rotation would be 0, 0, 0 (facing the same orientation as the playspace).
To help visualize what's happening, I put a blue cube scaled into the shape of a rectangle on the MixedRealityPlayspace and can visually confirm that it's both changing the position and the rotation. It's perfectly aligned with the green visual indicator on the destination Game Object (which denotes its orientation).
I put a red cube on the camera (and it's also the selected Game Object, so you can see the directional handles on it).
In the attached images, you can see the positions of everything when I approach the stairs and press a button to go up the stairs. The camera is rotating, but there's an offset. It's no longer matching the orientation of the MixedRealityPlayspace.
What's odd is that it's definitely rotating. It's just not rotating as expected. Is it a local vs. world space issue? Is there a way to reset the main camera Game Object to match the orientation of its parent?

Ah yeah, we have some math in the teleport system to attempt to orient the playspace in a way that puts the camera in the correct pose:
https://github.com/microsoft/MixedRealityToolkit-Unity/blob/d6398dd1603d7ba9376a0e75ff6e0a6f91d805d8/Assets/MRTK/Services/TeleportSystem/MixedRealityTeleportSystem.cs#L300-L308
You might be able to adapt that for your use case! Assuming I'm interpreting those images correctly, it does look like the blue cube ends up in the same spot relative to the green dash on the circles on the floor (it's ~160° counter clockwise in both images)


Standardize AWS category mapping, similar to Azure and GCP

Update the AWS categories to be inline with FOCUS spec.  Use ServiceCategory column name.
Fixes #257

Hi @brianwyka, there are some test cases that are failing could you please look into those.

Hi @brianwyka, there are some test cases that are failing could you please look into those.

This is a polars error that cannon find a particular column,
FAILED tests/plan_validators/test_plan_graph_generators.py::test_lookup_plan - pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value: ColumnNotFound(ErrString("product_code\n\nError originated just after this operation:\n\n  Csv SCAN /home/runner/work/focus_converters/focus_converters/focus_converter/conversion_configs/aws/mapping_files/aws_category_mapping.csv\n  PROJECT */2 COLUMNS\n\nError originated just after this operation:\nErrorStateSync(AlreadyEncountered(not found: product_code\n\nError originated just after this operation:\n\n  Csv SCAN /home/runner/work/focus_converters/focus_converters/focus_converter/conversion_configs/aws/mapping_files/aws_category_mapping.csv\n  PROJECT */2 COLUMNS))\n\n  Csv SCAN /home/runner/work/focus_converters/focus_converters/focus_converter/conversion_configs/aws/mapping_files/aws_category_mapping.csv\n  PROJECT */2 COLUMNS"))

Taking a look @varunmittal91

Hoping this one fixes it.

Thanks @varunmittal91 !


[For Review] Sequence Parallelism + RoPE

Thanks @mingxu1067 for adding the support!
Since the PAXML Llama models are using praxis layers from transformer_engine.jax.praxis, could you please add the Sequence Parallelism + RoPE support in the praxis layers also?

Thanks @mingxu1067 for adding the support!
Since the PAXML Llama models are using praxis layers from transformer_engine.jax.praxis, could you please add the Sequence Parallelism + RoPE support in the praxis layers also?

Done, kindly try commit/aa3d101db out.


Need help with helm upgrade&kubectl apply

Operating system
ubuntu 20.02.4
Helmfile Version
v3.3.4+5.el8
Helm Version
v3.3.4+5.el8
Bug description
The helm upgrade command i use: helm upgrade vdu "nodename/charts/podname/templates/values.yaml" --set xx.yyy=2
Error: Error: failed to download "nodename/charts/podname/templates/values.yaml" (hint: running helm repo update may help)
Another issue with kubectl apply -f
Command: kubectl apply -f configmap.yaml
error: error: error parsing configmap.yaml: error converting YAML to JSON: yaml: line 3: did not find expected key
Example helmfile.yaml
NA
Error message you've seen (if any)
NA
Steps to reproduce
No
Relevant discussion
No response

@ljie-16 Please create issue in https://github.com/helm/helm


something is wrong when using filters

I'm trying to use filters with no luck, i keep getting
Error: Invalid Signature - provided signature does not match [woocommerce_api_authentication_error]
I get that error every time i try to use filters like this:
$params = [
    'filter' => [
        'created_at_min' => '2016-01-01',
        'created_at_max' => '2016-01-15',
    ],
    'page' => 1,
];

if i remove the dates filters it will work:
$params = [
    'filter' => [
        'limit' => 15,
    ],
    'page' => 1,
];

category filter show the same message:
$params = [
    'filter' => [
        'limit' => 15,
        'category' => 'Music',
    ],
    'page' => 1,
];

it will work if i remove it:
$params = [
    'filter' => [
        'limit' => 15,
    ],
    'page' => 1,
];

I experienced the same behavior.
It's only possible to use one of the created_at_* date filters.
Using both at the same time will git the authentication error.

Update to 1.0.1.


[#831] feat(tez): Add the patch of Tez pluggable shuffle

What changes were proposed in this pull request?
Provide  tez patch, to support configurable edge information.
Why are the changes needed?
Fix: #831
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By hand.

No needed.  We prefer https://github.com/apache/incubator-uniffle/pull/966


Docs improvements

Added API section to readme and updated the text about --ignore
fixes https://github.com/maxogden/electron-packager/issues/27 and https://github.com/maxogden/electron-packager/issues/41
:swimmer:

Wonderful- thanks a ton!


Make non-dimensionalizaion and instantiation of rheology structs type stable

This PR addresses the problems raised by @tduretz  and (some of them) discussed in #122.

Phase/CreepLaw names where stored as a NTuple{N, Char}, where the conversion of a String to Char is type-unstable because the length of a string is not known at compile time.
Solved this problem by using string and Adapt.jl to make the structs work on GPUs.

CorrectionFactor is now type stable

Nondimensionalize has been simplified and made type-stable. I suspect that other methods and dimensionalize suffer similar issues, I will address this in a future PR.

I have disallowed mutating struct parameters in the Transform_*Creep methods as that was also making everything unstable. I'm also not very fond of letting the user modify structs within GP.

Units are a pain. The rheology data base is not type stable because

julia> typeof(MPa^-1)==typeof(MPa^-2)
false

therefore the former Dictionarys  were not concrete and retrieving a rheology from them allocated. I reworked the database anyway so that they are not constant parameters anymore, avoiding its (type-unstable) construction when loading GeoParams. I have a couple ideas on how to improve this but will test it out in a different PR.
How to avoid allocations in the code in the current state
This again addresses the allocations observed by @tduretz. Bear with me:
using GeoParams
function main1()
    # Unit system
    CharDim    = SI_units(length=1000m, temperature=1000C, stress=1e7Pa, viscosity=1e20Pas)
    # Numerical parameters
    Ncy        = 100
    # Allocate arrays
    Tv         =    rand(Ncy+1)
    ε0         =    rand()
    ε̇ii        = ε0*ones(Ncy+1)
    η          =   zeros(Ncy+1)
    # Configure viscosity model
    flow_nd  = SetDislocationCreep("Diabase | Caristan (1982)", CharDim)    # non-dimensionalized
    # Setup up viscosity model
    t = @elapsed begin
        a = @allocated begin
            for i in eachindex(ε̇ii)
                η[i] = compute_viscosity_εII(flow_nd, ε̇ii[i], (;T=Tv[i]))
            end
        end
    end
    println("$a allocations; $t seconds")

    return nothing
end

function main2()
    # Unit system
    CharDim    = SI_units(length=1000m, temperature=1000C, stress=1e7Pa, viscosity=1e20Pas)
    # Numerical parameters
    Ncy        = 100
    # Allocate arrays
    Tv         =    rand(Ncy+1)
    ε0         =    rand()
    ε̇ii        = ε0*ones(Ncy+1)
    η          =   zeros(Ncy+1)
    # Configure viscosity model
    p  = DislocationCreep(;
            Name = "Diabase | Caristan (1982)",
            n = 3.05NoUnits,
            A = 6.0e-2MPa^(-61 // 20) / s,
            E = 276kJ / mol,
            V = 0m^3 / mol,
            r = 0NoUnits,
            Apparatus = AxialCompression,
        )
    flow_nd  = Transform_DislocationCreep(p, CharDim)
    # Setup up viscosity model
    t = @elapsed begin
        a = @allocated begin
            for i in eachindex(ε̇ii)
                η[i] = compute_viscosity_εII(flow_nd, ε̇ii[i], (;T=Tv[i]))
            end
        end
    end
    println("$a allocations; $t seconds")
    return nothing
end

julia> main1()
4848 allocations; 5.5875e-5 seconds

As you can see compute_viscosity_εII because the type instability of the data base propagates throughout the code. If one wants to follow this kind of code-style. The current alternative is to just copy-paste the rheology from the data base and call e.g. Transform_DislocationCreep on it. This wont allocate
julia> main2()
0 allocations; 2.042e-6 seconds

Type-instability does not propagate throughout function calls, so an alternative is to break the code into functions
function foo(flow_nd)
    # Numerical parameters
    Ncy        = 100
    # Allocate arrays
    Tv         =    rand(Ncy+1)
    ε0         =    rand()
    ε̇ii        = ε0*ones(Ncy+1)
    η          =   zeros(Ncy+1)
    # Setup up viscosity model
    t = @elapsed begin
        a = @allocated begin
            for i in eachindex(ε̇ii)
                η[i] = compute_viscosity_εII(flow_nd, ε̇ii[i], (;T=Tv[i]))
            end
        end
    end
    println("$a allocations; $t seconds")
    return nothing
end

function main3()
    # Unit system
    CharDim  = SI_units(length=1000m, temperature=1000C, stress=1e7Pa, viscosity=1e20Pas)
    flow_nd  = SetDislocationCreep("Diabase | Caristan (1982)", CharDim)    # non-dimensionalized
    foo(flow_nd)
end

function main4()
    CharDim = SI_units(length=1000m, temperature=1000C, stress=1e7Pa, viscosity=1e20Pas)
    p  = DislocationCreep(;
        Name = "Diabase | Caristan (1982)",
        n = 3.05NoUnits,
        A = 6.0e-2MPa^(-61 // 20) / s,
        E = 276kJ / mol,
        V = 0m^3 / mol,
        r = 0NoUnits,
        Apparatus = AxialCompression,
    )
    flow_nd  = Transform_DislocationCreep(p, CharDim)
    foo(flow_nd)
end

with
julia> main3()
0 allocations; 5.0e-6 seconds

julia> main4()
0 allocations; 3.0e-6 seconds

Closes #122


Dockerfile not found error handling

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[ ] I adhere to the Command Guidelines.

FIXES #9520

https://travis-ci.org/Azure/azure-cli/jobs/545512074
pylint:
************* Module azure.cli.command_modules.acr.task
R: 35, 0: Too many statements (51/50) (too-many-statements)

https://travis-ci.org/Azure/azure-cli/jobs/545512074
pylint:
************* Module azure.cli.command_modules.acr.task
R: 35, 0: Too many statements (51/50) (too-many-statements)


Add support for llvm objdump

LLVM objdump adds ; in front of a lot of lines for example the path of the cpp.

Thank you for this! I think it looks good.
I would like to add some kind of unittest before making a new release, so it will take a bit of time


Max flows parameter can be exceeded for a given slice

I was playing around with Floodlight static flow pusher on top of FSFW, and I was able to create 18 flows in an ovs instance when my slice limit was set to 10:
{
    "DPID": "d0:0d:de:ad:be:a7:da:d5",
    "connected": true,
    "flow_rate": 1111.1111111111111,
    "max_flow_rule": 1,
    "max_flows": 10,
    "max_packet_in_rate": 1,
    "packet_in_rate": 0.016272031924424873,
    "total_flows": 18
}

I sent flows that did the following:

Match VLAN ID 100
Match MAC address (incrementing the src MAC by 1 for each flow)
Output to a specific port (2)

My slice included ports 1 and 2, and VLAN 100 on both ports.  By not specifying the in_port, I believe that FSFW split my flowmods into two flowmods, which match on in_port 1 or in_port 2.  I have not investigated what caused the 18 flows (flow accounting issues vs. race conditions, etc).
Here is the resulting flowtable as reported by Open vSwitch:
https://gist.github.com/gth828r/e2efcdea6e87d647c6b1#file-gistfile1-txt

Hi Tim
How many flows did you try and push?  Did you have some logs from FSFW when you were doing this?  I would like to see the logs of possible.
Also what version of FSFW were you running 1.0.4b?
Thanks

Yes to, 1.0.4b, and yes I do have the logs.  I unfortunately don't know exactly when the problem happened, because I didn't notice the problem at first, so my apologies for that.  Here is a ~2000 line gist of the logs, from startup until a time where I know the problem should have already happened by:
https://gist.github.com/gth828r/1ddb13ed89ba57de8015
I suspect the problem occurred toward the latter half of the logs.  I am working within the "samevlan" slice, and the "diffvlan" slice intentionally doesn't have a controller for the duration of this test.
https://gist.github.com/gth828r/126827c92cd3c34a2bc0
This was one stress test against the various tests against fsfw in a series of them.  If you want to know more about the steps leading up to this test, I can describe it.  FYI, I have not been able to reproduce this again, but I'll be trying many times, and I'll report back if I see it again (hopefully with a more narrow log snippet!)

Oh, and in terms of the number of flows I was trying to push, I think I was trying to push 10 (without the in_port specified in the match).  Note that SFP had previously also had one flow installed prior to this test, but that test was verifying that the slice was disable as part of violating the packet-in rate.  I then re-enabled the slice, but I am assuming those flows got removed when the slice was disabled.

I have not been able to replicate this at all in my testing.  Perhaps I was just doing something funky in my initial exploration, but I am not sure what that would have been.
Anyway, feel free to do as you wish with this ticket.  I don't have a good way to replicate the issue, so I won't hold it against you all if you close it. :)

When we start testing the next release of FSFW we will attempt to reproduce what you described.  If we can't replicate then we will close.

I think I figured out how to replicate what you saw, however I'm not sure there is much we can do about it.
Here is the situation
You add 10 flows to the switch, the switch disconnects and reconnects (at this point fsfw says you have 0 flows installed) then you attempt to push 10 more flows.  Because FSFW says you have 0 flows installed it lets you push them.  Once FSFW gets the flow stats it sees you have 20 flows (or 18 in your case) and sets the value to 20.  The only option I see here is not letting you send flows until we have received flowstats from the switch and sliced them.

Ah, I see.  Nice find!
In the GENI context, my opinion is that we'd always want to flush rules on a switch reconnect, which would bypass this issue.  In general, if the substrate was disconnected, I don't want to make any assumptions about what the switch did while it was disconnected, and since GENI slices aren't really at a high level of production, clearing out the switch's forwarding rules is sufficient.
If you wanted to avoid this problem outside of the GENI context, one other option might be to just freeze the flow stats on a switch disconnect and keep them cached.  This assumes that the common case of a switch disconnect is temporary, and that the switch isn't necessarily going to clear out any flows on its own.  Once the switch reconnects and fsfw pulls in the latest flow stats, you'd have the correct info, but you wouldn't have as much of a risk of slices going over their flow limit as in the current state.
I'll leave it up to you which approach you think is best.

I'm going to take this out of 1.0.5 for now, we will come back to it later

Sounds good.  It seems this problem is not so common in practice, it is probably not catastrophic if it happens, and the right approach requires some thinking.


GitHub duplication Fixed

Close: #957

Added a new field (github_user_id) to the Firestore database.

2. Refer to the video
https://user-images.githubusercontent.com/71075101/234053643-1982560f-700b-453a-b25a-6cce1f5c795f.mp4

Tests Added:
✔ should add the github_user_id to the user collection
✔ should update the github_user_id in the user collection (40ms)
✔ should be a string
✔ should have a maximum length of 50 characters
✔ should be stored correctly in the database

Can you please add tests for the case where the GitHub id is updated?

The test are failing rest things, look good.

Yes working on the test cases.

@iamYashSinha Please share the migration plan for existing uses, how will we add github_user_id to them?

Migration Plan
initially, the plan was to revoke all the users & tell them to reauthorize by visiting the Real Dev Squad website. But this method ended up creating another document of that user and then adding the github_user_id field to it. As of now, I've written the logic for the new users, but in order to do migration I've to find a way where can add the new github_user_id field to the existing user.
@prakashchoudhary07

Test Cases Added

Can you please add tests for the case where the GitHub id is updated?

Tests Added:
heavy_check_mark should add the github_user_id to the user collection
heavy_check_mark should update the github_user_id in the user collection (40ms)
heavy_check_mark should be a string
heavy_check_mark should be stored correctly in the database

@iamYashSinha Please share the migration plan for existing uses, how will we add github_user_id to them?
will be matching the github_id (which is storing the GitHub username) of two documents and if a match is found, will be inserting the github_user_id field. Refer to the attached video @prakashchoudhary07

https://user-images.githubusercontent.com/71075101/234631956-b23af66a-2b28-48db-ac40-cdb6519b2e24.mp4

Documentation
https://island-macrame-1be.notion.site/Architecture-Changes-062bfeb3d2114bacaddc1d9cdafe166e

Please update the data models as well

@iamYashSinha Please update the api contracts and data models as well

@iamYashSinha Please update the api contracts and data models as well
I'm not getting your point what do you mean by saying "update API contracts and data models?"

Tests are failing, please check

Resolved! @prakashchoudhary07

Tests are failing, please check

Resolved! @prakashchoudhary07

@iamYashSinha Please share the migration plan for existing uses, how will we add github_user_id to them?
Ans - will be matching the github_id (which is storing the GitHub username) of two documents and if a match is found, will be inserting the github_user_id field. Refer to the attached video @prakashchoudhary07

2023-04-26.21-20-29.mp4

So when users signs in and I am assuming the user to be a existing user, so when he signs in then if the github_user_id is not present in the collection of user it adds it?

@iamYashSinha Please share the migration plan for existing uses, how will we add github_user_id to them?
Ans - will be matching the github_id (which is storing the GitHub username) of two documents and if a match is found, will be inserting the github_user_id field. Refer to the attached video @prakashchoudhary07

2023-04-26.21-20-29.mp4

So when the user signs in and I am assuming the user to be an existing user, so when he signs in then if the github_user_id is not present in the collection of users it adds it?

@iamYashSinha Please share the migration plan for existing uses, how will we add github_user_id to them?
Ans - will be matching the github_id (which is storing the GitHub username) of two documents and if a match is found, will be inserting the github_user_id field. Refer to the attached video @prakashchoudhary07

2023-04-26.21-20-29.mp4

So when the user signs in and I am assuming the user to be an existing user, so when he signs in then if the github_user_id is not present in the collection of users it adds it?

Well, that was the initial plan, problem was, for example, there were 1400 docs stored in the rds-firestore it is impossible to tell each and every one to sign in again to the RDS as some of them are inactive, and some of them had left.
So to fix this problem I've created one route, SuperUsers just have to hit that route and all the documents will automatically get updated.
Here is the Migration DOC: https://island-macrame-1be.notion.site/Architecture-Changes-062bfeb3d2114bacaddc1d9cdafe166e

Please make changes of removing the github_user_id from a few users and then testing if your script adds the field to the users.

Updated the test to add a user without github_user_id field and testing if the script added the field or not
https://github.com/Real-Dev-Squad/website-backend/blob/7f791932cfc60a53340f010613d07ae3cfa254a8/test/integration/users.test.js#L1259-L1262
https://github.com/Real-Dev-Squad/website-backend/blob/7f791932cfc60a53340f010613d07ae3cfa254a8/test/integration/users.test.js#L1286-L1290


Empty IDs invalidate HTML markup

Sveltestrap components like Container, Row etc. generate an empty id="" attribute on DOM nodes which is invalid according to the W3C spec. It would be great if this empty attribute could just be omitted if it's not set.

Hey thanks for the heads up, yeah we are doing this in a lot of places:
export let id = '';

Should be an easy fix, will PR and update by this weekend hopefully.

Hi @Shackless , this was super easy, should be fixed in #175 , published as<EMAIL_ADDRESS>Will close, let me know if you still see issues

Cool, thanks for the super-fast resolution. It works perfectly now!

I just noticed that the sveltestrap components now render with id="undefined" instead of id="". Interesting is that Chrome doesn't display the id attributes when inspecting an element but if you select "View Page Source" instead, you'll see them. Check https://shipbit.de as live example. It uses latest sveltestrap and Sapper packages. I'm not sure if this issue might be related to the latter.

Hey there, hmm, that's super annoying, I only confirmed in the inspect elements.
Explicitly declaring id="" predates the {...$$restProps} stuff which was not initially supported by Svelte...
I'll reopen and look this weekend. I think the restProps should cover!

Should be corrected by #177 , published as<EMAIL_ADDRESS>I think in upcoming v5 we'll prune out all the HTML props we just pass through


The README implies that recent VS is not supported

Bring README up to date with
https://marketplace.visualstudio.com/items?itemName=SteffenForkmann.PaketforVisualStudio

Works with Visual Studio 2013, 2015, 2017

thanks


Figma Kit

It would be very useful to have a Figma Kit of Nuxt Labs UI components to help designing projects.

Awesome! What's the status? Is it close? 😬🙏

Our designer has been working on it every day for the past weeks.
Should be ready this month 🤞

That would be awesome to have both Figma and UI Library. Speaking from the experience of Storefront UI.
Cant wait to see it!

It's live!
https://www.figma.com/community/file/1288455405058138934


Fonts not working

Font requests are not working offline.
This should be as simple as setting up a 'fetch' event handler for them. Go figure...

fixed in 14fde7243fed4acc43e6ca42fb6021aa41dd4a85


Android app to support Thread Commissioning

Problem
Add support of Thread Commissioning to the Android demo App
Proposed Solution
Integrate ot-commissioner with Android App.

addressed by https://github.com/project-chip/connectedhomeip/pull/1988.


Use application support directory instead of documents

Closes issue #8

Guys please review @abhay-s-rawat @giacathuy @jcarvalho-ptech


Run A/B test to validate new "advanced tutorial" doc type

We are already updating the web API tutorial following the advanced tutorial guidelines.  This issue is for:

Make a copy that follows the existing tutorial guidelines.
Set up an A/B test
Analyze the results

Closing since content model is changing and we would no longer test against old design.


Customizable baseline image name format

Is it possible to make baseline image format name to be customizable?
For now it use the spec file name as prefix for the baseline image name : https://github.com/uktrade/cypress-image-diff/blob/77af07787aec62ad3845aa59f139342f72e4aaf4/src/command.js#L14C1-L25C1
Cause maybe there is needed to re-use baseline image on other spec file
Proposed solution : Maybe can put baseline image format to be configurable via cypress-image-diff.config.js and make current format (which is used spec filename as prefix) as default value

This is probably not well documented, but the name you add to the compareScreenshot command is used as part of the file name. I.E
cy.compareSnapshot('home-page')
means your filename will be something like: spec-name-home-page.png
does this solve your query?

If I understand correctly the @daniellboy would like to customise the baseline image names. In this case remove any 'spec file naming related' dependency, so they can re-use a baseline image in multiple spec files.
Currently is not possible since all the baseline image contain the corresponding spec file name in their filname

yes, thanks @tamasmagyar for providing clearer examples

@daniellboy Cause maybe there is needed to re-use baseline image on other spec file
Can you please share a use case for this?

@tamasmagyar already provided an example above  :

for example: current usage - assuming both signup and login page looks similar/same

signUp.spec.ts which contains a cy.compareSnapshot('signup') will generate a baseline image with the name of signup.spec.ts-signup.png image name
login.spec which contains a cy.compareSnapshot('signup') will generate a baseline image with the name of login.spec.ts-signup.png image name

Daniel would like to have only one baseline images in this instead of two. Which can be achieved if baseline image names are configurable. Removing the file name from the beginning of the baseline images in this case.
Suggested usage:

set some file naming convention in config file, e.g. only use the provided home in this case, thus generating home.png for the baseline image
signUp.spec.ts which contains a cy.compareSnapshot('home')  will use home.png
login.spec which contains a cy.compareSnapshot('home')  will use home.png

I see. This is something we could improve in our next version. However, this should be per command level, not at the global level. We could add an option in the compareSnapshot command to say strictly use this name, otherwise prepend the spec file as default.

@kien-ht sounds like this is a very specific use case and would be best to deliver it on v2 of this plugin like you suggested... Providing the ability to provide an options object to handle the use case sounds good too!


#1509 Display a subset of the sha image names in containers

fix(containers) display a subset of the sha images name in the containers datatable fixes #1509

@deviantony & @1138-4EB  Can you review the latest changes?

I was "inspired" by an other filter but your suggestion looks good. I changed the code to take it into consideration.

Thanks @yassirh :+1:


Django 4.1 compatibility

I decided to grab the changes from a former PR and reintroduce them here in the hope of getting this into master as soon as possible. I have added the original creator to the contributors as well as upgraded the tox.ini to cover wagtail 4.0.x

@MrCordeiro when you have a minute, could you please look this over, would be great to have this package compatible with Wagtail 4.0
I will try to respond quickly to any change requests if needed.

Ah, I was wondering why the test suite wasn't picking up the changes :) Hopefully this will do the trick

Ah, now we can fully test the versions.
@ArnarTumi, Django 4.1 is likely incompatible with older versions of Wagtail/Python. You will have to adjust the settings (either tox or test.yml) so that tests are not run on those. The compatibility list for Wagtail can be found here.
The error on the [Python 3.10, Django 4.1, Wagtail 4.0]-setup indicates that the previous compatibility fix was not enough.

Ok, the tests are failing due to package conflicts, I am going through the matrix and excluding versions that will not work together.

Yeah, I am working through the tests now and trying to figure out what more is failing.

Ok, now the tests "should" pass. There was a change in Page serve that needed to be addressed and the _editor.css file that needed to be optionally imported.

Thanks for the patience and the amazing work, @ArnarTumi (o゜▽゜)o☆

Thank you! :)

@MrCordeiro will there be a release for this version support?

Yes, but I was planning to do it during the weekend when I'm not at work.

From: Sævar Öfjörð Magnússon @.>
Sent: Thursday, October 13, 2022 4:38 PM
To: jazzband/wagtailmenus @.>
Cc: Fernando @.>; Mention @.>
Subject: Re: [jazzband/wagtailmenus] Django 4.1 compatibility (PR #432)
@MrCordeirohttps://github.com/MrCordeiro will there be a release for this version support?
—
Reply to this email directly, view it on GitHubhttps://github.com/jazzband/wagtailmenus/pull/432#issuecomment-1277813587, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE5E6K3LNUJIDULK55TGQ2LWDAUHZANCNFSM6AAAAAARDDAQRI.
You are receiving this because you were mentioned.Message ID: @.***>

Great, thank you. Good to know the plan :)

I think you forgot the “added the original creator to the contributors” part

I think you forgot the “added the original creator to the contributors” part

Weird, I specifically added both of us... @MrCordeiro if you plan on a relase this weekend could you please add us to the contributors if it is missing?

No worries. Already added :)

Thank you @ArnarTumi and @MrCordeiro – I know my contribution was tiny but it was only my second pull request so I'm still proud of it 😆


Querying objects with referenced resource

I have a model
public class QueueObject : IQueue
    {
        [BsonId]
        public int QueueID { get; set; }

        [BsonIgnore]
        public IUserInfo Sender { get; set; }

        [BsonRef("userInfo")]
        public IUserInfo Recipient { get; set; }

        public bool IsProcessing { get; set; }
        public bool IsCompleted { get; set; }

        public string Message { get; set; }

        public int QueueNumber { get; set; }
        public string ClientName { get; set; }
        public string QueueType { get; set; }
    }

Which references
public class UserInfoObject : IUserInfo
    {
        [BsonId]
        public int ID { get; set; }

        public string Name { get; set; }
        public string Username { get; set; }

        public string IPAddress { get; set; }

    }

When I run queries
                var count = queueCollection.Include(x => x.Recipient).Count(x => x.Recipient.ID == 1);
It does not return a result even when I successfully store the queue object on the database collection and can successfully print out all content using FindAll()

up

Hi @ReiSchneider, are running in v4? Are you created index in x.Recipient.ID before?

I'm using 3.1.4 as it is the only available in the NuGet.
I have a separate process for adding a user in the database and I make sure that i used EnsureIndex on the UserInfo ID

Hi! With the objective of organizing our issues, we are closing old unsolved issues. Please check the latest version of LiteDB and open a new issue if your problem/question/suggestion still applies. Thanks!


Need documentation for how to use WinUI3 with RNW

It will be a very long time before RNW can confidently use WinUI3 by default. In the meantime there's a manual switch to try it out. See issue on RNW repo. We need to document those steps, and list or link to the tradeoffs, so that early adopting apps can be informed.

Some thoughts:

Today, we can build a debug version of M.RN that targets WinUI 3 by setting the configuration to WinUI3 instead of Debug or Release.
I checked in a change to the CLI and project templates that adds an option to the project linking command to use WinUI 3 - see PR #4799
We should try to limit the probability that an app will load both WinUI 2.x and WinUI 3 as I don't think this is a [well] supported scenario

https://microsoft.github.io/react-native-windows/docs/next/winui3


notifications for referenda only

I typically vote on referenda but don't pay much attention to motion/tips/etc. It would be nice to only receive emails for new referenda instead of everything that happens.
Add a toggle
notified for new referendum on/off
notified for new proposal in council/motion/other events on/off

We are excited to announce that our notification engine has undergone a comprehensive UI overhaul in https://github.com/polkassembly/polkassembly/pull/297, incorporating the requested functionality. Users now have the ability to fine-tune their notification preferences and select the specific types of events they wish to be notified about. With this granular level of control, you can now choose to receive notifications solely for new referenda while opting out of notifications related to council proposals, motions, and other events.
By utilizing these toggle options, you can tailor your notifications to align with your specific interests and engagement preferences.
For more details and instructions please check out the announcement tweet: https://twitter.com/polk_gov/status/1673731519209193478
We appreciate your patience and understanding during the implementation process. Your feedback is invaluable in helping us refine and improve the Polkassembly platform. If you encounter any issues or have further suggestions, please don't hesitate to reach out to our support team.
Thank you for being an active member of the Polkassembly community, and we look forward to your continued participation in shaping the future of decentralized governance.
Best regards,
Mridul
Polkassembly Team