Put primary macros into a prelude submodule

This is an attempt to put the primary interface -- the items that most people will use and need to import -- into a prelude submodule. So that users can do use cradle::prelude::*;. This has some disadvantages, so I don't think this will ever get merged. The dealbreaker seems to be this:
Even if macros are declared in a submodule, rust puts them into the top module of a crate. Here I'm using this re-exporting hack to work around that, but that seems like a terrible idea. Also, I haven't checked what it does to generated documentation.

I couldn't find a way to make this actually work well in the generated documentation.


Add Stylus Labs Write

Microsoft Reviewers: Open in CodeFlow

I uploaded the installer and it has successfully been approved on Microsoft Security Intelligence but I don't have the rights to remove the "Needs: author feedback" label.


Private Chat Rooms

Hi Piotr. We have reinstalled Author-Chat 2.0.3 after having issues with older versions.   The app is working, but I cannot add Private Rooms to the interface, and I don't see the option working where the pop-up chat appears on any page on the site. It is only appearing on the Admin page.  Last time we had this, we had to pay for the "premium version" for these premium features.  But I no longer see that as an option.

Hello, thanks for your comment. Author Chat is no more premium - it's free for all, so all premium functions are now available for all users without activation. Looks like AC plugin is in conflict with some other element on your website, probably with jQuery library. If previous version worked than try to install it again - in new version some of jQuery lines were rewritten, maybe that's why it doesn't work anymore on your website.


applying redirect maps from a file.

Is it possible to read the redirect_map from a file?
somehting similar to this.
plugins:
  - redirects:
    redirect_map_file: my_redirects.yml

and then the my_redirects.yml file will contain.
redirect_maps:
  "my_old_url.md": "cool_page/my_new_url.md"
  "my_old_url2.md": "cool_page/my_new_url2.md"
  "my_old_url3.md": "cool_page/my_new_url3.md"

This would help when there are a lot of old urls that are removed or should be pointing at something new. Else the mkdocs.yml will be really big.

It's not possible yet, but there's a PR here: https://github.com/mkdocs/mkdocs-redirects/pull/57. Note that I'm only a passer-by maintainer and don't have the time to review and maintain new features, so I won't merge it myself.


cargo install fails, cannot compile libpulse-binding

I get the following error when trying to install via cargo:
sample::CHANNELS_MAX expected usize found u8
Any idea how to fix?
rustc and cargo version 1.49.0

cargo install will gladly ignore the lockfile that makes building this program reproducible. Try using cargo install --locked :)
That said, I need to update dependencies

cargo install will gladly ignore the lockfile that makes building this program reproducible. Try using cargo install --locked :)
That said, I need to update dependencies


Send Location

Hi!, I need help ... how can I send my location whit facebook-chat-api? Is it possible?
Thank you very much

Unfortunately we do not currently support this.  It may be impossible using our current approach but it's hard to say.


Cpu freq fixes

Fix for this false failure:
CPF004.005 CPU with load runs on expected frequency (Ubuntu 22.04)... | FAIL |
Several failures occurred:

1) '4400.0 > 4400.0' should be true.

2) '400.0 < 400.0' should be true.

Also bump the number of threads in CPU stress test to actually load the CPU

@filipleple You might be interested in this


Fix CI error when to check membership

Pull Request Test Coverage Report for Build 7995

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 63.891%

Files with Coverage Reduction
New Missed Lines
%

src/common/scheduler/scheduler.go
1
81.87%

Totals

Change from base Build 7989:
0.0%

Covered Lines:
11993

Relevant Lines:
18771

💛  - Coveralls

Pull Request Test Coverage Report for Build 7994

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 63.87%

Files with Coverage Reduction
New Missed Lines
%

src/common/scheduler/scheduler.go
1
81.87%

src/common/scheduler/policy/alternate_policy.go
3
80.29%

Totals

Change from base Build 7989:
-0.02%

Covered Lines:
11989

Relevant Lines:
18771

💛  - Coveralls


10 TLOS per ballot (not 30 TLOS)

according to this official website, it should be 10 TLOS per ballot.
https://docs.telos.net/telos-decide/introduction
according to the code too.
https://github.com/telosnetwork/telos-decide/blob/master/contracts/decide/src/decide.cpp#L29

You're using an old contract. Please use the contract located at the "telos.decide" account instead of the deprecated "trailservice" account.


pixi run lists tasks

Problem description
Hello fellows,
I am starting to get hooked on pixi :grin:
A minor feature request:
pixi run

lists the available tasks. This is the expected behavior coming from npm, pnpm.
Thanks!

I like this to! I prototyped a interactive pixi run. Looking something like:
> pixi run
Select the task you want to run:
  > build
  - test
  - lint
  - bla

What do you think about that?

@ruben-arts awesome!

the usual pretty colors please :-D

And the task descriptions would be nice :-)

? Please select a task to run: ›
❯ build
  build-docs
  bump
  bump-changelog
  deploy-dev
  deploy-latest
  docs                 Serve the documentation
  generate-schema
  install
  lint
  mike-serve
  pre-commit-install
  pre-commit-run
  pypi-proxy
  test
  test-all
  test-schema
  toml-format
  toml-lint

OR
? Please select a task to run: ›
❯ build
build-docs
bump
bump-changelog
deploy-dev
deploy-latest
docs                 Serve the documentation
generate-schema
install
lint
mike-serve
pre-commit-install
pre-commit-run
pypi-proxy
test
test-all
test-schema
toml-format
toml-lint

what would be even more awesome is, if the list items also have their indices printed along and you can either choose them via cursor or just type the number and press enter.
I find the first option better as a list with right aligned values is not how usually a single column list is displayed in terminal
? Please select a task / task number to run: ›
  1.    build
  2.    build-docs
  3.    bump
  4.    bump-changelog
  5.    test-schema
  6.    toml-format
❯ 7.   toml-lint


Add new doc section with overview for NAS newbies

Adds a new section to the documentation for the inexperienced with links to get them started. Hope this will help people decided if this is the right project for them. You'll probably want to tweak the text a bit in some places, like aims.

This is awesome, and fills a big glaring gap in the docs, thank you. Have added a comment around the hardware bit, aside from that I think we're good to merge. :+1:

Perfect, thank you!


Fb enclave deploy

There are two jenkins files with appropriate ansible playboks for Enclace deployment and termination.

This closes #43

Can we have an updated title?
On Sat, Apr 28, 2018 at 5:10 AM, Kirill Makhonin<EMAIL_ADDRESS>wrote:

This closes #43 https://github.com/epam/legion/issues/43
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/epam/legion/pull/46#issuecomment-385141210, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAMEZ4wa9JU8jlSoKbYGcoh_OWwTREGmks5ts_m8gaJpZM4TqTmb
.


Use of libfdt_native_dep

https://github.com/amboar/culvert/blob/bc6a03a4c268a710914c9966e5ceaa58b8c007a7/meson.build#L20-L24
It's more a question than an issue.
I'm trying to package culvert, and I'm hitting my head on this part of the meson build.
I'm not sure I understand the intent behind this dependency.
It doesn't look like there is any dtc.pc file anywhere.
dtc will only generate a libfdt.pc. That makes my meson build fail (because pkg-config can't find it).
Removing this block seems to do the trick, culvert works fine, but I feel like I'm missing something.

Ah, so I think this is something that might never have worked properly in practice. I tend to have dtc installed on my machines anyway :)
We need dtc to build culvert (to compile the embedded devicetrees), so this was an effort to build dtc via meson if it wasn't otherwise available. From a packaging perspective adding a build dependency on both dtc and libfdt is the correct thing to do, though if you can make this fallback work in some fashion that might help out other people trying to build it from source for their own purposes.

At the moment I'm patching out this block:
https://github.com/NixOS/nixpkgs/pull/349150
dtc is provided in the environment, and it provides both the libfdt and the dtc binary (at least on nixos).

I think at this point I'd merge a PR that simply removes the attempt at building dtc this way (which allows you to drop your patch from the nixpkg)


Can you add a like button so I can save the current song to my favorites?

Hi, currently I use the AppleScript API to get information from Spotify, unfortunately it does not provide an endpoint to save / modify / delete tracks from a users playlist / saved library.
A plausible way to add this feature anyhow would be to use the Web API, but this would require the user to authenticate the application with their Spotify account.

I'd also like this feature. What are your thoughts on allowing the user to sign in for additional features such as this? I'd be willing to work on this functionality, it's just a matter of whether you think that this is "in-scope" for SpotMenu. :)

I think it would be a neat feature as well, I sometimes wish I had this feature too 😄. But since this is an open source project, I don't know how I could securely store a client_id and client_secret. I wouldn't to ask users to create their own Spotify App just to use this feature. If you have any ideas that would be great!

That's a really good point that I hadn't thought of. I suppose we could spin up a small server solely to serve these keys (maybe using https://aws.amazon.com/lambda/)?

I've never used Lambda before either.
Spotify authorization flows
So you think we should set up a Lambda server so we can use the Authorization Code Flow?

Actually, looks like we won't need to. Check this out: https://developer.spotify.com/web-api/authorization-guide/#implicit-grant-flow

I haven't read the documentation thoroughly yet, but I think the problem with the Implicit Grand Flow is that the user won't receive a refresh token and once the access token expires the user will have to login again, which would be really annoying. I don't know how long an issued access token is valid. If it's valid for more than a couple a months, than this is ok, but using a toking that expires weekly or even hourly wouldn't be such a great idea.

Ooh, yeah, good point. Looks like the token expires after one hour. Might not be the best solution. :)
Then yeah looks like Lambda might be a good option. I'm more of a web dev guy myself (I've played around with OS X dev but it's certainly not my strong suit), so perhaps I can work on the Lambda business and you can work on the OS X side (which besides the UI would include providing a callback URI)?

I started implementing this "add to your music" button feature.
Currently, this is the backend: https://github.com/kmikiy/kmikiy-for-spotify which runs on Heroku. I am using a free dyno for this. The url for the backend is this: http://kmikiy-for-spotify.herokuapp.com/
The client side is being developed on the save-button branch. Right now only logging in works, that is, retrieving access and refresh tokens, and nothing else.
I'll try to add the actual save feature as soon as possible. Also, there is a lot of boilerplate code to write for example refreshing access tokens, querying whether or not the current song is saved already or not and displaying a ✔ and ✘ accordingly, etc.

Looks great! Anything I can do to help?

Checkout the save-button branch, build it and see how it works (follow the steps in the README.md to build it).
Known issues:

If you restart the SpotMenu you will have to login again
After you login the "save button" will only be updated when you skip to the next song
If the popover hasn't been open for more than an hour then the save button might show the correct symbol until you skip to the next song (this is due to the that the access token may have expired and   might not have been refreshed yet)
There is no sign out button yet  😅

@camdenb

Looks great! Anything I can do to help?

If you could find out why it keeps hogging so much memory even after the webview has been dismissed that would be great 😃

Just found this little project. It's awesome! I was also hoping that a save song button would de awesome, but I see you're already working on that.
Keep up the good work! Cheers!

Hi @kmikiy, how are you on this enhancement? I can try help in my free time, are you interested in it?

Hey @ManWithBear
I haven't really been working on it lately. But if youre willing to help id be glad to start working on it again.
The changes from the main branch need to be merged in to the save-button branch.
In my previous comments I mentioned the current state of the save-button branch and its issues.
Basically those need to be fixed and evrything should be working fine.
If youre good at debugging memory leaks then that would help because im concerned about the current way spotify login works now. I think it  might be leaking

Update on this?
Would be keen on getting this as a feature, if at all possible now :))

@Zazerr To be honest I haven't worked on this feature for a while due to Spotify's limitations. I'll get back to this after I finish the requests that are currently in work in progress state

Hey, it would be amazing to see this feature. Thanks!

Would still love this aswell

+1...This would be a great feature!

I no longer use Mac, but I would just like to say that I think this feature would still be great if it is possible to implement.

+1 on this feature

+1

+1

I really love SpotMenu but need so much like button, +100500 on this feature

Anything i can do to contribute to this?

up up up

It would also be very nice to see the heart indicator in the menu bar, so we can at least see if the current track is liked or not while playback.
The endpoint on the AppleScript API exists:
tell application "Spotify"
	if player state is equal to playing then
		set is_starred to starred of current track
		return is_starred
	end if
end tell

Unfortunately, it's not working and returns error "Spotify got an error: AppleEvent handler failed." number -10000 and this was reported 4(!) years ago: https://community.spotify.com/t5/Desktop-Mac/Applescript-quot-starred-quot-property-returns-Error/td-p/4853526
It's really nice to see how the Spotify Team "cares" about interoperability.


Samples' README doesn't exist

Under https://github.com/googleapis/java-logging#samples, it mentions:

Samples are in the samples/ directory. The samples' README.md has instructions for running the samples.

However, there is no README and no instructions to run the samples.

No samples in all Java client libraries provide README in the examples/ folder. The sentence about the README will be removed from the template.


Update GMS version in README

Thank you for reminding me to do this, though I am going to choose 2022.3 because it seems to be the most popular stable build at the moment.

That makes sense 👍


Manual

URL from Nabucasa
Port is default 8123
generated in HA
API activation means in config only: "api:"
correct? Does not work for me.

Which app version are you using?
Is your home assistant reachable via HTTPS?
Yes, "api" should be enough.
Did you try to reach the REST api by e.g. curl -X GET -H "Authorization: Bearer <your_token>" -H "Content-Type: application/json" <your_url>:<your_port>/api/?

Then I see problem. Nabu Casa Cloud of Home Assistant providing HTTPS as https://.ui.nabu.casa without port.
Trying without PORT the error is curl: (35) schannel: next InitializeSecurityContext failed: Unknown error (0x80092012).

From version 0.4 on the settings menu contains an entry for a specific port.
Does it work now (after adding the port number)?

Sorry I meant that the nabu casa cloud does not use port. With port the connection does not work. Without port it thow the error.

As I read in this thread that nobody really found a solution to get the Rest API  running with nabu casa.
Since my app is based on the Rest API, I also don't see a solution for you. Sorry.

That´s alright, thank you for trying.

Hey @pyramidak, just try to set port = 443 as this is the default https port and should also work for a nabu.
So both:
https://(URL).ui.nabu.casa
https://(URL).ui.nabu.casa:443
are in fact the same

I tried both, not working. Is setting always loaded new before a try? Some applications have extra button to save new setting to watch. I can only hope the new setting is always used. I tried many times. Not working, but the idea was good.

Each setting is applied instantly.


Guibranco patch 3

📑 Description
PR Description here
✅ Checks

[X] My pull request adheres to the code style of this project
[X] My code requires changes to the documentation
[X] I have updated the documentation as required
[X] All the tests have passed

☢ Does this introduce a breaking change?

[ ] Yes
[X] No

Summary by Sourcery
Build:

Update project files for GuiStracini.Mandae and GuiStracini.Mandae.Tests.

Description by Korbit AI
What change is being made?
Update project files to support .NET 8.0 and .NET 9.0 framework versions.
Why are these changes being made?
These changes are made to ensure compatibility with the latest .NET framework versions, allowing the application and its test suite to take advantage of the new features and performance improvements introduced in .NET 8.0 and .NET 9.0. This proactive update helps maintain modernity and relevance in the software's technological stack.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Summary by CodeRabbit

Compatibility

Updated project target frameworks to include .NET 8.0 and .NET 9.0
Expanded test project compatibility to .NET 9.0

Workflow Changes

Modified GitHub Actions workflow to remove pull_request_target trigger and updated .NET version for build and analysis steps.

@gstraccini create labels

:white_check_mark: Build GuiStracini.Mandae 8.0.749 completed (commit https://github.com/guibranco/GuiStracini.Mandae/commit/d22b9fef74 by @guibranco)

:white_check_mark: Build GuiStracini.Mandae 8.0.756 completed (commit https://github.com/guibranco/GuiStracini.Mandae/commit/065a980411 by @gstraccini[bot])


[BUG] Condition Resets Not working when using GSE Sequence but works from In Game Macro

🔵 Describe the bug:
[BUG] Condition Resets Not working when using GSE Sequence - Works with IN GAME Macro but will not work when using it in a GSE Sequence
These Work perfectly when using iN GAME macros but not when using this in a GSE Sequence / Macro Block
They fail even if set as the SPEC or General Class
/targetenemy [noharm,nocombat]
/startattack [nocombat]
/castsequence [spec:1]   reset=target  Agony, null
/castsequence [spec:2]   reset=target  Shadow Bolt, null
/castsequence [spec:3]   reset=target  Incinerate, null
/petattack [combat]

/targetenemy [noharm,nocombat]
/startattack [nocombat]
/castsequence [spec:1,combat]   reset=target  Wither, Unstable Affliction, null
/castsequence [spec:2,combat]   reset=target  Power Siphon, null
/petattack [combat]

🔵 To reproduce: (Steps to reproduce the behavior)

Try the macro above in GSE Sequence as a Macro Block and in an In Game Macro

🔵 GSE Version:
GSE-3.2.00-beta4-PatronBuild
🔵 Additional context:
For GSE to recognize conditions something - please see macro above as examples.  I wish I could code Tim - I would help you - I feel bad reporting stuff I know you would want fixed and I can't fix it myself.

I think they are doing something to Kill the Direct Keybinding we are using currently in GSE.  I think this because I can Keybind these IN GAME on Normal IN GAME Macros and they work.

So the immediate workaround is to put the name of that macro in the macro box in GSE.  I can’t control what WoW does with the commands we send it.

So the immediate workaround is to put the name of that macro in the macro box in GSE. I can’t control what WoW does with the commands we send it.

I will do that - Just throw the macroname On the top line Tim -
MACRONAME
/targetenemy [noharm,nocombat]
/startattack [nocombat]
/castsequence [spec:1]   reset=target  Agony, null
/castsequence [spec:2]   reset=target  Shadow Bolt, null
/castsequence [spec:3]   reset=target  Incinerate, null
/petattack [combat]

FYI I'm doing the same thing on the Hunter Class with [spec] and having zero issues

What does the compiled macro look like for that - wonder if it’s a base spell issue?

To call a macro it’s just
MACRONAME
with nothing else in the box

Its something specific to the Warlock I think - All the [Spec] worked with the Hunter.  I'll work on it more later and try to narrow it down to exactly why it wont work.

I’d look at the compiled template and https://github.com/TimothyLuke/GSE-Advanced-Macro-Compiler/wiki/Base-Spells and see if there was anything strange happening there.

You could also use a variable to determine if spec =x and then use if blocks

You could also use a variable to determine if spec =x and then use if blocks

I brought the Macro Block all the way down to:
/targetenemy [noharm,nocombat]
/startattack [nocombat]
/cast [spec:1]  Agony
/petattack [combat]

I took it down one thing at a time and it absolutely would NOT fire if there was /castsequence used in the GSE Macro Block.  for the Spell.  Which leads me to believe they may have blocked Insta DOTS and Castsequence so you cant do a
/castsequence reset=combat/target INSTADOT, Null

You are surprised that /castsequence fails?  I am surprised when it works.  It has been broken in implementation since BFA’s alpha where they removed it and then put it back in a broken way 1 day before release.  Null has been a constant source of failure in that it is very dependant on what items a person has picked up over the life  of the game.  Castsequence works in a limited capacity for a normal macro but even then you can’t depend on it.

You are surprised that /castsequence fails? I am surprised when it works. It has been broken in implementation since BFA’s alpha where they removed it and then put it back in a broken way 1 day before release. Null has been a constant source of failure in that it is very dependant on what items a person has picked up over the life of the game. Castsequence works in a limited capacity for a normal macro but even then you can’t depend on it.

I know we have gone back and forth on this with /castsequence and I have had for the most part secess using it for the small things I use it for.  I've never had it fail in GSE and work in an In Game macro - but I have also never had the changes happen that have happened via Blizzard in the last month or so .. its like a whole new game when it comes to thinking about macro sand how to make them work well.
With that being said I'm closer than ever at putting together what I have said that Blizzard is moving to a execution style that matches SWTOR.  My first shot at this is my new Hunter macro Set that without even really thinking about it I was able to line up all 3 specs on the same macro set.

What does the compiled macro look like for that - wonder if it’s a base spell issue?

I'll look when the servers come back up - sorry missed this last night

The work around for this :

Put the castsequence with the reset lines in a normal macro in /macro
In GSE put the /macro name in the Macro box on its own.

The work around for this :
* Put the castsequence with the reset lines in a normal macro in /macro

* In GSE put the /macro name in the Macro box on its own.

When doing this it seems to only run the first macro in a loop (even if it's not the first block in the loop) and nothing else, not even a second named macro. It doesn't even have to be a castsequence macro for it to act this way. A basic /use macro still bricks the rest of the loop.

I have just fixed a weird /targetenemy quirk in #1546.  Could someone test this again in a GSE block to see if that has also fixed this?

I have just fixed a weird /targetenemy quirk in #1546. Could someone test this again in a GSE block to see if that has also fixed this?

The update does appear to make it so the workaround you mentioned does work. I tested it with 2 different named macros with reset conditionals and it seems to be working as expected now.
It still doesn't work properly with the castsequences directly in the macro block, though I don't know if the update was expected to remedy that.

It has no control over that at all.

I have just fixed a weird /targetenemy quirk in #1546. Could someone test this again in a GSE block to see if that has also fixed this?

The update does appear to make it so the workaround you mentioned does work. I tested it with 2 different named macros with reset conditionals in the loop and it seems to be working as expected now.
It still doesn't work properly with the castsequences directly in the macro block, though I don't know if the update was expected to remedy that.

Then its still a wow problem

At least a workaround exists. Thankfully Blizzard gave us 12 more character macros.

yes
/castsequence [mod:alt] reset=combat Thunder Roar, Blade Storm
All content with the condition of using [mod:alt] reset= will not be available
If you don't use reset=combat/number, the order of the abilities will be incorrect
It's distressing, but you can still use Expect future changes

This looks like it is a more significant issue as even /castsequence [nocombat]   reset=combat/target  Azure Strike, null in a NORMAL macro is not respecting the reset=target part

I think I just included the one line where it was breaking Tim - The macro was much larger and that line was a [nocombat] to start combat.. I actually removed the target part - so it ended up something like this:
/targetenemy [noharm,nocombat]
/startattack [nocombat]
/castsequence [nochanneling,nocombat] reset=combat Azure Strike, null
/cast [harm,nochanneling,combat] Azure Strike
But I have other ingame macros being called in the priest macros that need the reset=combat/target in them.

/castsequence [nocombat] reset=target/combat spell1,null
this will never reset on target as once combat starts it will never be evaluated again.
you could just as easily go
/cast [nocombst] spell1
been spending a lot of time experimenting to try to get some rhyme or reason for this problem to go back to blizzard with.

I have incorporated the work around from this into https://github.com/TimothyLuke/GSE-Advanced-Macro-Compiler/wiki/Understanding--castsequence
As Blizzard have no eta on if or when this will be fixed.  Closing this out with the view that we will refer people to the castsequence page.


Blocks Toolkit

Feature adapted from Lynda Tang's graduate work.
Adds project-level property "BlocksToolkit" (internally also called SubsetJSON), which is a JSON string describing UI components and code blocks to be displayed in the Designer and Blocks Editor. This allows projects to limit the options in the GUI to fit the curriculum and not overwhelm students.

When I use the "Export to File" option of the BlocksToolkit it creates a file with the ".txt" extension. Should it use ".json" instead?

In the BlocksToolKit i am missing the extension palet.

In the BlocksToolKit i am missing the extension palet.

It doesn't support the extensions palette right now. It's worth checking out what that would take. Since extensions can be added and removed, which affects what's in the toolkit, I deemed it out of scope.
However, it's important that extensions palette not be turned off in the Designer, and I don't think i've tested that.

Yes the extension palet is turned of now when using a custom Blocks Toolkit.

Yes the extension palet is turned of now when using a custom Blocks Toolkit.

OK, this should be fixed, and I believe the fix is on the test server right now.

I now have to extension categories in the palette

I have fixed some bugs and changed Match Project to match the event/method/property component blocks as well as the components and built-in blocks. This code could use some refinement, but out respect for the upcoming release, I'd like to kick this back into the review queue.


ESP32-C3 doesn't support pattern of #include "rom/uart.h" (IDFGH-4758)

Problem Description
The system provided header file rom/uart.h cannot be found when configured for esp32c3
Fix
Change the INCLUDE line in sdk/esp32-esp-idf/components/esp_rom/CMakeLists.txt to
INCLUDE_DIRS include/${target} include "${target}"

Thanks for reporting.

Hi @pjsg,
Thanks for the clear issue report. In this case, it may be counter-intuitive but this behaviour is by design.
When ESP-IDF only support ESP32, there was a lot of code like #include "rom/blah.h". Which was fine because we only supported one chip, and there were no differences to cause ROM incompatibilities.
However, each Espressif chip's ROM is different and APIs that work on ESP32 may not compile, or they will compile and then not work the same on other chips.  For this reason, when we added ESP32-S2 support (and now ESP32-C3) we changed the method for including ROM headers.
If you #include "rom/uart.h" on ESP32 with a recent version of ESP-IDF (v4.0 or newer) then a warning will be printed like this:
rom/uart.h is deprecated, please use esp32/rom/uart.h instead

This deprecation warning is intended to not break compatibility for ESP32 users, but it will be removed in a major release some in the future (maybe ESP-IDF v5.0).
There are some alternatives possible for when you need to use ROM functionality:

We've extracted common ROM APIs for functions which run on all target SoCs. For example, you can include esp_rom_uart.h and find the ROM UART functions that will work on all targets.

If you only need your code to work on ESP32-C3, you can of  course #include "esp32c3/rom/uart.h". If someone tries to build this for a different target then they'll get a compiler error rather than possibly slightly different behaviour due to some API change.

If you find some functionality that isn't in a chip-agnostic header, but you're using it on more than one target SoC, then you can use #ifdefs like this. This is pretty ugly so if you've found common functionality between SoCs that isn't exposed in the "chip agnostic" headers, please open an issue with a feature request for us to support them there.

If you've found some Espressif-provided code or example that includes #include "rom/uart.h", please let us know and we'll update it.

Thanks for this -- it certainly gives me direction to go in. My problem is that I'm porting the nodemcu-firmware (the lua interpreter/environment) and it has to work on regular esp32 as well as the c3. (The esp8266 version is essentially completely separate and runs in the legacy environment).

Hi @pjsg, ah I see!
Having a peek at https://github.com/nodemcu/nodemcu-firmware/issues/3397, it looks like this involves updating from ESP-IDF V3.x with GNU Make to V4.x with CMake - so there a few differences, but hopefully you can get past them smoothly. If you're updating NodeMCU to use ESP-IDF V4.3 or V4.4 for both ESP32 and ESP32-C3 then it shouldn't be too hard to get code that runs on both with minimal target-specific #ifdefs but it may require some changes - like the ROM headers.
As a first step, suggest looking to see if the thing(s) NodeMCU uses from rom/uart.h have equivalents in esp_rom_uart.h, and change to those functions if possible.

@projectgus Thanks -- some of these are easy. How about rom/spi_flash.h. These are the matching files:
./sdk/esp32-esp-idf/components/esp_rom/include/esp32c3/rom/spi_flash.h
./sdk/esp32-esp-idf/components/esp_rom/include/esp32/rom/spi_flash.h
./sdk/esp32-esp-idf/components/esp_rom/include/esp32s3/rom/spi_flash.h
./sdk/esp32-esp-idf/components/esp_rom/include/esp32s2/rom/spi_flash.h
./sdk/esp32-esp-idf/components/esp32/include/rom/spi_flash.h

The last file says just to use esp32/rom/spi_flash.h. For the esp32c3 which file should I be using? Can I just use the esp32/rom/spi_flash.h or do I have to use the esp32c3 flavor? I have a number of these cases to go through (after I backed out the change that I made to the CMakeLists.txt).
Thanks

Hi @pjsg,
Which functions is nodemcu using from the ROM SPI flash headers? Suggest not calling ROM SPI flash functions from ESP-IDF apps at all if possible (I think all of these headers have warnings to this effect), call the relevant ESP-IDF APIs instead:
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/storage/spi_flash.html
(To answer the general question, on esp32c3 you would need to use the esp32c3/rom/xyz.h flavor and not the esp32/rom/xyz.h flavor - as the two chips have different ROM contents.)

By aggressively commenting out features, I have the basic command
input/interpret/output loop running. Now on to get the network stack up and
running.....
On Thu, Feb 18, 2021 at 9:43 PM Angus Gratton<EMAIL_ADDRESS>wrote:

Hi @pjsg https://github.com/pjsg,
Which functions is nodemcu using from the ROM SPI flash headers? Suggest
not calling ROM SPI flash functions from ESP-IDF apps at all if possible (I
think all of these headers have warnings to this effect), call the relevant
ESP-IDF APIs instead:
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/storage/spi_flash.html
(To answer the general question, on esp32c3 you would need to use the
esp32c3/rom/xyz.h flavor and not the esp32/rom/xyz.h flavor - as the two
chips have different ROM contents.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/espressif/esp-idf/issues/6561#issuecomment-781774697,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALQLTNQVPZGU4UKZRHYNJTS7XF2TANCNFSM4XZM4KAA
.


Stuck on deploying

Hey! I appreciate your work, it's an awesome and useful one. However, when I try to use it in my server - repo connection, I don't know the reason but it is stuck on deploying as you can see from the screenshot. Github says the delivery is successful, but I couldn't resolve the problem.

I also had the same problem, as it turns out, you may want to git pull instead of git fetch.
Just replace it in line 83 of GitAutoDeploy.py.
Actually i have no idea why there is just a git fetch in the script.

had the same problem, check out my pull request solving it. It's a shame it was not merged yet
https://github.com/logsol/Github-Auto-Deploy/pull/29
Enjoy ;)

hi @ThomDietrich  i use your pull request about this problem but i still have the same issue
stuck here
dev@scarlet:~/Github-Auto-Deploy$ python GitAutoDeploy.py
Github Autodeploy Service v0.2 started
<IP_ADDRESS> - - [18/Mar/2017 16:15:22] "POST / HTTP/1.1" 204 -

@fiantinangon I haven't used the script for a while. You should add some debugging to the script to find the point of error. It's probably easy to find...

@ThomDietrich i finally fix the issue, the issue is on
if(repository['url'] == repoUrl):
                res.append(repository['path'])

my conf repository url using .git on the url :) and the repoUrl from git response not use .git on the last URL , finally i simply change my config and change the url to follow new url from git response.


docs: redo events guide

Pull Request Type

[ ] Feature addition
[ ] Bugfix
[x] Documentation update
[ ] Code refactor
[ ] Tests improvement
[ ] CI/CD pipeline enhancement
[ ] Other: [Replace with a description]

Description
This PR aims to redo the events guide, which has been a pain point for a large amount of users. The guide itself is too short, uses unclear language, and does not give proper warnings about what not to do.
This PR does not give a whole list of events, nor is there intention to. It is to my belief that lists of events already exist in the API documentation - I believe adding more information about how events work will outset the need to create a redundant list that will need constant updating. However, if enough people disagree, I can add it in.
Changes
This is largely a "see the diff" PR. That being said...

Completely revamp the events guide. It attempts to mitigate some pain points that people mentioned during feedback, and clarifies on other sections that could use it.
Remove the name disclaimer from the two event API Reference pages.

Related Issues

Test Scenarios

Python Compatibility

[ ] I've ensured my code works on Python 3.10.x
[ ] I've ensured my code works on Python 3.11.x

Checklist

[ ] I've run the pre-commit code linter over all edited files
[ ] I've tested my changes on supported Python versions
[ ] I've added tests for my code, if applicable
[x] I've updated / added  documentation, where applicable

Marking as ready to review.

Most changes that were requested have been accounted for, but I put my two cents for the two final ones.

Added back example usage in the API reference as discussed in Poll's review.


Is there a license issue with the minio Gateway used

Because Minio uses the AGPL-3.0 License,  this may cause legal woes for many.
My Object Storage is not Minio, but I run a gateway through the command juicefs gateway .... Is there the license issue above.
If anyone knows, please answer it. Thx!

The version [1] of MinIO is released under Apache License v2, so there is not GPL issue here.
The problem is that we can't upgrade to latest version of MinIO. We plan to add a plugin of JuiceFS into MinIO.
[1] https://github.com/juicedata/minio


GraphQL invocation does not work with api key headers

Description
GraphQL invocation does not work with api key headers.  Currently custom header support for api-key header feature is implemented only for Rest apis.
And currently in the publisher portal a user can add custom headers for api keys for graphQL and it's not working for graphQL apis.

Therefore the graphQL does not work with default api-keys which is working properly in 4.2.0 version.
API key header input box needs to be hidden for graphQL
Steps to Reproduce

Login to publisher portal
Create a graphql API and publish
Select api keys under the run time tab ( note that user can add custom headers for api keys here)
Login to the devportal.
Subscribe to the api and generate api keys
Invoke graphQL api with default api keys.

Affected Component
APIM
Version
4.3.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

Getting the below error
{
  "errors": [
    {
      "message": "Failed to fetch",
      "stack": "TypeError: Failed to fetch\n    at https://localhost:9443/devportal/site/public/dist/9920.9b2bb8b405df5085d453.bundle.js:2:183754\n    at Generator.next (<anonymous>)\n    at s (https://localhost:9443/devportal/site/public/dist/9920.9b2bb8b405df5085d453.bundle.js:2:183485)\n    at https://localhost:9443/devportal/site/public/dist/9920.9b2bb8b405df5085d453.bundle.js:2:183446\n    at new Promise (<anonymous>)\n    at r.<computed>.a.<computed> [as next] (https://localhost:9443/devportal/site/public/dist/9920.9b2bb8b405df5085d453.bundle.js:2:183398)\n    at https://localhost:9443/devportal/site/public/dist/9920.9b2bb8b405df5085d453.bundle.js:2:149199"
    }
  ]
}


have a process in place to handle queries about the event

What
Look at how we will process and handle enquiries about the event 3
Why
Respond to any enquiries that we have with regards to event 3
Who needs to work on this
Imran, Kam
Done when

[x] Agree on what tools we would use i.e. email, zendesk
[ ] add info to Eventbrite
[ ] agree who will respond to enquiries

You can log into Zendesk and add an internal note
the person on support can copy and paste the response

Kam has access to Zendesk

Everyone is to check at lunchtime and 4 pm -
Add internal notes for person on support


Using pushy in Linux

I am using
Java 7
pushy:0.9.1
netty-tcnative-boringssl-static: 1.1.33.Fork24
It working all fine in windows with tomcat. I am able to send push notification successfully.
Now when I deploy the same in Websphere (in Linux box), I get below error
java.lang.UnsatisfiedLinkError : netty-tcnative-linux-x86_64-fedora (not found in java.library.path)
Please help.

Hello!
This sounds more like a request for general support than it does like a bug report or a feature request. We generally ask people to move these kinds of questions to the Pushy mailing list because:

The mailing list has a wider audience, and you're more likely to find somebody who has experience with your particular circumstances on the mailing list.
Posting your question to the mailing list can help other people who are having the same problem.
Because there isn't a bug to fix or a feature to add, we can't reasonably solve your problem by making any kind of engineering change.

I emphasize that we'd be happy to help, but let's move this conversation to a different venue.


Remove the OTA tests for Linux and Darwin

Problem
The CI OTA tests test are unstable due to mDNS issues. Need to disable the tests while this is being investigated.
Change overview
Remove OTA tests from the CI originally added in https://github.com/project-chip/connectedhomeip/pull/14414
Testing
No executable code changes, tested through CI

fast tracking - this fixes significant CI flakyness.
We will still need a followup for actually fixing the test.


#348 - Server-side rendering.

This implements #348: full server-side rendering support for Skate components.
This implements a single function that takes input as HTML with unexpanded web components (so the same thing you'd expect to write on the client) and it will render everything out and return the resulting string.
The string can be output directly to the client from the server and Skate will not render the components on the client, but it will go through the rest of the lifecycle.
The supported parts of the lifecycle that gets called on the server is:

defines properties
calls created
readies properties
calls render (but not renderer) and passes in the properties.
adds the resolved attribute (this is what prevents it from rendering on the client)

In order to render components on the server-side, all you do is require('skatejs') and require() your component definitions. From there, all you do is call the node render function.
For example, the following:
const render = require('skatejs/node');
const skate = require('skatejs');

skate('x-hello', {
  properties: {
    textContent: null
  },
  render (props) {
    return `Hello, ${props.textContent}!`;
  }
});

console.log(render('<x-hello>World</x-hello>'));

Would log:
<x-hello>Hello, World!</x-hello>

Several parts of the codebase had to be updated to run in a node environment. This includes normalising the global object in a module and using that instead of window as well as ignoring certain parts of the created lifecycle when not running in a browser.

Declined because we're not quite ready to implement this. This was a spike to see if it's possible and roughly how.


Inline if .. else expression

if .. else is sometimes used in lieu of the ternary operator in C, so it might be a good idea to preserve the original intention if the programmer wrote a short if .. else expression in a single line.
A wild case found in rust-lang/rust#28988:
if align <= MIN_ALIGN { 0 } else { mallocx_align(align) }

was converted into:
if align <= MIN_ALIGN {
    0
} else {
    mallocx_align(align)
}

which looks a bit more verbose. Is this an intended behavior?
Hmm, well, looking at the code again, the latter also seems OK to me... Now I'm not sure which side I'm in. Maybe this should be exposed as a configuration option?

It is intended, but it's a style that's often requested, so we should probably have an option for it.
(I thought there was an issue for this already, but I couldn't find one).

+1 on this. There are some libraries in rust-lang in which this change is made all-over the place, even for very short lines.

This is already possible by setting single_line_if_else to true in the config!

https://github.com/nrc/rustfmt/blob/master/tests/target/single-line-if-else.rs has some example output.

Ha! That is why I couldn't find an issue :-)

Ah cool! Thanks!!

@marcusklaas Was option single_line_if_else removed?
$ rustfmt --version
rustfmt 1.4.11-nightly (1838235 2019-12-03)
$ rustfmt main.rs
Warning: Unknown configuration option `single_line_if_else`

I do not know. I haven't been involved with this project for a long time.

even with single_line_if_else if the if-else statement is your return value then the formatter will still open the statement up unless you explicitly use the return keyword (which I believe isn't idiomatic, ironically)


feat: types based on inlay hints (#543)

in progress... doesn't work as expected... will add return types later

@egorio will you provide more content here as to what specifically doesn't work as expected?

will you provide more content here as to what specifically doesn't work as expected

Function param types were not great using inlay hints. The return types are opposite - looks great in provided inlay hints :)

@lynchbomb test for an async function added


KNOX-1275 Add json-smart explicitly to gateway-spi

@saravankrish - I think this PR can be closed since the change was committed. Can you close it?


bug/

I'm getting exception Please someone help me.
office365.runtime.client_request_exception.ClientRequestException: ('AccessDenied', 'Either scp or roles claim need to be present in the token.', '403 Client Error: Forbidden for url<EMAIL_ADDRESS>

@tuhiindass - Could you provide the code you ran to produce the error and information about the OneDrive instance you're looking to connect to?


Add restart flag

Signed-off-by: Ozzy Osborne<EMAIL_ADDRESS>

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


More reliable approach in copy link code

Summary
The copy link was having problem on visualization because re-rendering and
selection and all that stuff... I changed the approach no touch the original
input field.
I didn't add tests because I a super weird behavior that can't be easily
reproduced by code (actually the existing code was expected to behave
correctly, and depending on the browser it fails more or less frequenly).
Ticket Link
MM-17328

The changes will be tested as part of 5.14 release. Removing the QA Review label


collapsable default state for array, block, collapsable fields

add support for setting collapsable fields (array, block, collapsable) to "collapsed" state by default
Description

[x] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[x] I have added tests that prove my fix is effective or that my feature works
[x] Existing test suite passes locally with my changes
[x] I have made corresponding changes to the documentation

Added support to set the collapsible default state for array/blocks/collapsable fields.
      admin: {
        initCollapsed: true,
      },

I hope I did it correctly. Thanks,
Lior

I'm closing this because I can't push my changes to the PR branch since it was closed and reopened https://github.com/payloadcms/payload/pull/1057
:

I'm closing this because I can't push my changes to the PR branch since it was closed and reopened #1057 :

@DanRibbens do you need me to resubmit it?

@DanRibbens do you need me to resubmit it?

Only if you have more changes, but I think it's pretty much done, just needs one more review.


an error with the maxp code

https://github.com/pysal/spopt/blob/b6676446209d1f176f4456e03b83ba9c86fa61fa/spopt/region/maxp.py#L220
The if condition is always false here, the label could never be assigned -1

There could be islands with no neighbors
Sent from my iPhone
On Aug 18, 2020, at 3:52 PM, Yongyi-Liu<EMAIL_ADDRESS>wrote:

https://github.com/pysal/spopt/blob/b6676446209d1f176f4456e03b83ba9c86fa61fa/spopt/region/maxp.py#L220
The if condition is always false here, the label could never be assigned -1
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pysal/spopt/issues/63, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABX5XRY6PW7VQ7QAAJCWLBTSBMAZFANCNFSM4QEHQOEQ
.

There could be islands with no neighbors
…
Sent from my iPhone On Aug 18, 2020, at 3:52 PM, Yongyi-Liu<EMAIL_ADDRESS>wrote:  https://github.com/pysal/spopt/blob/b6676446209d1f176f4456e03b83ba9c86fa61fa/spopt/region/maxp.py#L220 The if condition is always false here, the label could never be assigned -1 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#63>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABX5XRY6PW7VQ7QAAJCWLBTSBMAZFANCNFSM4QEHQOEQ .

I see the point about island. But the if condition should be len(NeighborPolys) = 0 instead of len(NeighborPolys) <0

I see the condition for island. But the condition should be len(NeighborPolys) == 0 instead of len(NeighborPolys) <0  because the length of the neighborhood list cannot be negative

resolved with #64


Relationships in the resources in the "included" section are not shown

All resources in the included section are devoid of their "relationship" section.

Thanks for reporting. I'll look into it.
I remember thinking on this when I first coded the library. Unsure if these are meant to appear according to the 1.0 JSONAPI specification. Need to check.

What about this?
I have the same problem.
I'm programming a project with emberJs which uses jsonapi standard, and it needs the relationships in the included objets to build the relations between models (using Ember Data).
Thanks.

Relationships in the resources in the "included" section are not shown Is this issue fixed yet or not ??

No, not yet :-)

-------- Originalmeddelande --------Från: Samina Tuladhar  Datum: 2016-05-23  11:59  (GMT+01:00) Till: nilportugues/laravel5-jsonapi  Rubrik: Re: [nilportugues/laravel5-jsonapi] Relationships in the resources in the "included" section are not shown (#39)

Relationships in the resources in the "included" section are not shown Is this issue fixed yet or not ??

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/nilportugues/laravel5-jsonapi/issues/39#issuecomment-220937913

@directrix1 @rmarinleal @OskarD let's try get this one ironed out this week.
Bug should be around here. https://github.com/nilportugues/php-json-api/blob/master/src/Helpers/DataIncludedHelper.php#L185

can't we get different type name (when we write in getalias function in
transformer)if we use same model in two different transformer??.
On Mon, May 23, 2016 at 3:48 PM, Nil Portugués Calderó <
<EMAIL_ADDRESS>wrote:

@directrix1 https://github.com/directrix1 @rmarinleal
https://github.com/rmarinleal @OskarD https://github.com/OskarD let's
try get this one ironed out this week.
Bug should be around here.
https://github.com/nilportugues/php-json-api/blob/master/src/Helpers/DataIncludedHelper.php#L185
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/nilportugues/laravel5-jsonapi/issues/39#issuecomment-220938858


Player strip menu title doesnt update on identity change

This one needs more context. Do you mean it doesn't update when you change your identity with an Agent ID?
I also noticed a more prominent issue while looking into this one, probably related.
Admin Command rename doesn't work on humanoids and the likes; when viewing as a ghost or admin, it shows the humanoid as if they had their face covered and have someone else's ID.
Non-Admin/Player view:

Admin/Ghost view:

This also affects the "rename" trick.

i mean strip menu, for example when you open Urist's strip menu, you see Urist McHands in title, but if they change identity (wear mask and Pun Pun id) the title is still Urist McHands

here i provided a video
https://github.com/space-wizards/space-station-14/assets/124214523/d6f86f35-be79-4b5a-a5d4-eec065d614f7

Yeah, I noticed this with the name modifier stuff. The window title doesn't update when the target's name changes.
Recent engine work added an event that gets raised when an entity's name is changed. It might be as easy as subscribing to that on the client and updating the window, but I'm not familiar enough with UI stuff to be sure.


Adds mock implementation for TelemetryPlugin

Description
Adds the mock implementation for TelemetryPlugin and strict check to validate that all the spans opened should be ended properly.
Related Issues
Resolves #7545

Framework PR #7648
Check List

[ ] New functionality includes testing.
[X] All tests pass
[ ] New functionality has been documented.
[X] New functionality has javadoc added
[X] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Looks good @Gaganjuneja , one thing I missed (too many ongoing  initiatives), could you please update the package for new mock classes from org.opensearch.telemetry to org.opensearch.test.telemetry (so we won't have package split brain while moving to JPMS).

Looks good @Gaganjuneja , one thing I missed (too many ongoing initiatives), could you please update the package for new mock classes from org.opensearch.telemetry to org.opensearch.test.telemetry (so we won't have package split brain while moving to JPMS).

Already doing, commit in progress :)

Looks good @Gaganjuneja , one thing I missed (too many ongoing initiatives), could you please update the package for new mock classes from org.opensearch.telemetry to org.opensearch.test.telemetry (so we won't have package split brain while moving to JPMS).

Already doing, commit in progress :)

Moved to org.opensearch.test.telemetry package.

@Gaganjuneja please submit manual backport to 2.x, thank you


more detailed update message during catalog import

Rationale / Begründung
An editor wants to check how the new and old version of the catalog differ.
When importing a new version of a catalog, for every existing entry a message "This element will be updated." is shown. It would be helpful if exact changes are listed during the import as well.
Affected
Managers
Minimal functionality

a more detailed information is given what is changed during the update (e.g. similar to git diff)

References / Verweise

Nearly similar to https://github.com/rdmorganiser/rdmo/issues/272
https://github.com/rdmorganiser/rdmo/issues/653

Will be part of RDMO 2.2.0.


Update chess-moves.md

The validMoves method fails when you have it honor who's team it is.

I think you are saying that there is a test that fails if your implementation of ChessGame.validMoves enforces whose turn it is. What make you think that this is true, and if so how does changing the definition of ChessPiece.pieceMoves relate to this?

Yes, sorry my wording wasn't the best.  What I am saying is that there are 3 tests that fail (at least in my implementation) if 'Chessgame.validMoves' enforces whose turn it is: Pinned King Causes Stalemate, Pieces Cannot Eliminate Check, and Check Forces Movement.  The reason I suggested this change is because as  'ChessPiece.pieceMoves' is defined, 'ChessGame.validMoves' is indirectly defined by differentiation, stating that 'ChessPiece.pieceMoves' doesn't enforce whose turn it is while 'ChessGame.validMoves' does.  In order to get a better understanding of how to implement 'ChessGame.validMoves', I read this and decided to enforce whose turn it is.  In doing so, these tests failed, so I figured 'ChessGame.validMoves' actually isn't supposed to enforce whose turn it is.  I decided to see if I could change this wording just in case this might cause issues for anyone in the future.  If you don't feel it's necessary, that's fine.  I just thought I might send it in just in case.
I've uploaded screenshots of my failing and passing tests with the teamTurn check added and omitted.
Thanks for considering!

Sorry this was coverd in the screenshots

Thanks for the clarification and the proposed changes.
My confusion is that your change is to remove the instruction for ChessPiece.getMoves that specifies that it should not consider whose turn it is. This would actually conflict with what the tests are doing.
I don't think there is any instruction for ChessGame.getValidMoves about if it is supposed to reference the player's turn, but I the tests definitely fail if you do enforce that.
Likewise for ChessGame.MakeMove. The tests for that will fail if you don't consider whose moves it is.
So I think we can do one of three things:

Change the tests and instruction so that getValidMoves enforces the turn.
Change the instruction so that it is clear that getValidMoves doesn't enforce the turn.
Do nothing since there is no conflict between the instruction and what the tests are requiring.

I think you only had a problem because you assumed getValidMoves should enforce the turn. The instruction change proposal you made doesn't seem to fix that, it only further confuses things because 1) the tests don't do what you assumed, and 2) the change would make the tests in conflict with the instruction.
Additionally,  the ChessPiece.getMoves function cannot use turn in its calculation because the board doesn't have a concept of turn. That is on the ChessGame.
What do you think?

I appreciate the follow-up, I'm sorry I haven't gotten back to you.  I see how my proposed change will further confuse things, as it is an edit to the instruction for 'ChessPiece.pieceMoves', and my proposed change might confuse people into adding a turn verification in this method.  I suppose no change is necessary since most students don't look back at the 'ChessPiece.pieceMoves' instruction for further clarification of the 'ChessGame.validMoves' method.  I was just confused because I looked for further clarification of the 'ChessGame.validMoves' method by looking at the instruction for the 'ChessPiece.pieceMoves' to see how they were different.  Based on what I read there, it looked like it was implied that one of the difference between these two methods was that 'ChessPiece.pieceMoves' doesn't verify team turn (which is true), while 'ChessGame.validMoves' does (which is false).  I can see now how it doesn't necessarily imply this difference.
Thanks so much!

@softwareconstruction240/tas - Any thoughts about this?
Which of these would you prefer? Anyone with a strong opinion willing to do the work?

Change the tests and instruction so that getValidMoves enforces the turn.
Change the instruction so that it is clear that getValidMoves doesn't enforce the turn.
Do nothing since there is no conflict between the instruction and what the tests are requiring.

I would suggest option 2, but I would change the instruction for ChessGame.makeMove as well, since it claims to provide a definition for "legal" that (misleadingly) only applies to itself. @jwsearle18, do you want to propose a change? Something like the following:

validMoves: Takes as input a position on the chessboard and returns all moves the piece there can legally make. If there is no piece at that location, this method returns null. This method takes into account all applicable chess rules except that it does not take into account whose turn it is.

makeMove: Receives a given move and executes it, provided it is a legal move. If the move is illegal, it throws an InvalidMoveException. This method takes into account all applicable chess rules: if you couldn't make a move in an actual chess game, makeMove should reject it.

pieceMoves: Takes as input a chessboard and a position on the chessboard and returns all moves the piece there can make. If there is no piece at that location, this method returns null. This method does account for enemy and friendly pieces blocking movement paths. It will need to take into account the type of piece and the location of other pieces on the board. It does not take into account whose turn it is or whether the king will be left in check.

Existing Question & Answer
@jwsearle18 It seems that your confusion has already been asked and answered in this Slack Thread.
I'll excerpt the conversation here for clarity and preservation:

Student: According to the spec, validMoves is supposed to return only legal moves, and legal moves are ones made when it's the correct team's turn. But in order for the validMoves tests to pass, validMoves must not check for the current team turn because the tests don't actually set the team turn, so it's null. The check for current turn needs to be done in makeMove instead.
...

Student: validMoves is a member of ChessGame though, not ChessPiece or ChessBoard. So wouldn't it still be good practice for it to check the turn (if it worked, of course)?

TA: No, it would not be good.
First of all, it would be a duplication of responsibility.
Second of all, it would prevent you from legitimately using the method to identify valid moves for a piece in alternative contexts. For example, later in phase 5 you’ll be responsible for highlighting all the moves a piece can make on the board. A user may want to explore what moves are available even if it isn’t their turn (they may be waiting for the other player to make a move). Therefore, you would be unnecessarily preventing a user from a legitimate behavior by validating the turn inside validMoves().

Chess Organization
The tests are treating the functions just the way they should. Specifically:

Only ChessGame.makeMove() should enforce the current turn of the game
ChessBoard.validMoves() should return all the moves a player could make assuming it were their turn, taking in to account the possibility of exposing the king to check
ChessPiece.pieceMoves() should return all the moves a piece could make just by mechanically following the rules of it's movement (but without consideration of higher level game rules)

This distribution of responsibility does correctly implement a chess engine, and it also minimizes the duplication of responsibility and the organization of good code.
Therefore
Regarding the proposals of @leesjensen:

~1. Change the tests and instruction so that getValidMoves enforces the turn.~
2. Change the instruction so that it is clear that getValidMoves doesn't enforce the turn.
3. Do nothing since there is no conflict between the instruction and what the tests are requiring.

Not an option. The tests are correct and the code organization is good.
Feasible, but this PR doesn't address the issue.
Also feasible, but future students may continue to be confused about this point (we did have to answer similar questions about this multiple times in the Slack channel).

This PR should be closed.

Hey @jwsearle18! We are interested in helping you contribute to the class and make it better, but we'll need you to participate with us. We're closing this PR for now. If you still feel like this is an important issue, please respond back in the comments or open up a new PR to address the issues.


Add filters in code (SQLEntitySet)

I created a view with data for all users.
This is an SQL Entity Set. There is no 'getBuilder' functionality like the Eloquent Entity Set.
How can I hook in the filters, dynamically?
The query should be: 'select * from files_view where user_id = ?'
Where statement is not applied via url but in code.
How can I achieve that?
Thanks,
Yannick

Hi @yannickdesmadryl, I think the best place would be to override generateWhere(). Maybe something along these lines:
protected function generateWhere(): SQLExpression
{
  $expression = parent::generateWhere(); // Use the parameters provided in the URL

  if ($expression->hasStatement()) {
    $expression->pushStatement('AND');
  }

  $expression->pushStatement('user_id = ?');
  $expression->pushParameter(4);

  return $expression;
}

Thanks


Provide some form of credential management for Gradle

Expected Behavior
There can be many ways to solve this, so I don't want to pick one. However a solution should:

Store credentials in a different location than other configuration.
Allow storing credentials encrypted, and even when not encrypted, they should be obfuscated to some degree (maybe with an obfuscation key stored in plain text elsewhere).
If there will be a Gradle command to manage credentials that must work without evaluating the build (since that is likely to crash without credentials).
Don't force me to add the same credentials to the store multiple times.
Note that there is gradle.wrapperUser/ gradle.wrapperPassword, and the wrapper jar should still remain small, so this might put some limit on what can be realistically achieved. So, maybe the wrapper credentials must be treated as an exceptional case. However, even if it is treated as an exception, it still shouldn't be stored in gradle.properties.
Provide a specialized API to set credentials from this store for whatever needs it (most notably repositories).
Gradle should try to prevent accidentally printing the credentials. Obviously, there can't be a protection against malice, but at least mistakenly printing them.

Current Behavior (optional)
Gradle offers no standard way of storing credentials. So, most usually people just store them in gradle.properties in plain text.
Context
We have to pass various credentials to the build. This usually happens through Gradle properties. In fact, even the documentation recommends this in its example. However, this has various drawbacks:

You might need to set the credentials for multiple things.
Often the same credentials have to be set for multiple things requiring copy-pasting the credentials.
They are usually stored in ~/.gradle/gradle.properties alongside with everything else. This is rather problematic, because it often happens that I want to just show my gradle.properties (for some other configurations), but then I have to be careful not to include credentials. And in a screen share, I have to make sure to not show my gradle.properties ever. In fact, I have seen people sharing their screen and then showing their credentials (populated with their credentials, and they didn't even seem to realize).

Sorry for the duplicate. For those who bump into this issue, I assume #3972 is what this is marked as duplicate of.

@kelemen Sorry about what. It seems like the comment from @ljacomet was lost. Indeed, we wanted to mark this as a duplicate of

https://github.com/gradle/gradle/issues/3972

@ov7a Sorry for not noticing the already open issue, which I could have, had I made more effort.


Regarding stage2 (ID consistency) training

Hi.
Is the workflow of the stage 2 training like this:
input -> forward denoising x4 -> vae decoding -> face detection -> arcface feature extraction?
This would consume too much memory if all gradient graphs were retained. Am I misunderstanding the workflow?
Thanks for any discussion in advance.

Hi, from what I have understood the workflow you have written is correct.
I kind of reproduced the code and it does not go out of memory using 4 steps and an A100 80Gb. One suggestion is to use the torch.no_grad() for both the encoding and decoding of the latents. Also, initialize the UNet using fp16, otherwise it would go OOM.

Hi, from what I have understood the workflow you have written is correct.
I kind of reproduced the code and it does not go out of memory using 4 steps and an A100 80Gb. One suggestion is to use the torch.no_grad() for both the encoding and decoding of the latents. Also, initialize the UNet using fp16, otherwise it would go OOM.

thx dude. ok, so torch.no_grad() stops grad for vae in the middle but the final loss can still propagate to the input? I thought in order for the grad to be calculated the graph of the whole path from data to loss should have been retained. So if this can work, the arcface model can also be put under no_grad?

Yes, you can compute the loss even if you set the no_grad for the vae. I haven't tried to put the no_grad for the arcface model, but I don't know if it would work.

Yes, you can compute the loss even if you set the no_grad for the vae. I haven't tried to put the no_grad for the arcface model, but I don't know if it would work.

Hi Davide, may I ask what resolution you're using in your implementation and how much GPU memory it takes up? In my case, I'm training with 512512 (both the SD path and the ID path), and it takes up 80G already. They mentioned they used 768768 which my code could never fit. I'm currently wrapping both vae and arcface under torch.no_grad() already.

Hi, I'm training with 1024*1024, but I'm not using both branches, only the ID one.

Whats the gpu memory usage for that branch, would you disclose? Thx
On Mon, Nov 18, 2024, 23:26 Davide Lobba @.***> wrote:

Hi, I'm training with 1024*1024, but I'm not using both branches, only the
ID one.
—
Reply to this email directly, view it on GitHub
https://github.com/ToTheBeginning/PuLID/issues/159#issuecomment-2483371135,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKSICDTYVLFBEMHD36HZW7D2BIBKDAVCNFSM6AAAAABRTNZWXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBTGM3TCMJTGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

You mean when in stage2, the diffusion loss is calculated in lightning branch? @davidelobba

Yes see another issue where they mentioned this
On Tue, Nov 19, 2024, 15:49 xilanhua12138 @.***> wrote:

You mean when in stage2, the diffusion loss is calculated in lightning
branch? @davidelobba https://github.com/davidelobba
—
Reply to this email directly, view it on GitHub
https://github.com/ToTheBeginning/PuLID/issues/159#issuecomment-2484944262,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKSICDR6VCL7E73XHED3RUT2BLUQZAVCNFSM6AAAAABRTNZWXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBUHE2DIMRWGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Whats the gpu memory usage for that branch, would you disclose? Thx
…
On Mon, Nov 18, 2024, 23:26 Davide Lobba @.> wrote: Hi, I'm training with 10241024, but I'm not using both branches, only the ID one. — Reply to this email directly, view it on GitHub <#159 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKSICDTYVLFBEMHD36HZW7D2BIBKDAVCNFSM6AAAAABRTNZWXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBTGM3TCMJTGU . You are receiving this because you authored the thread.Message ID: @.*>

Hi, this is the memory usage:
step 0, memory after unet forward pass: 30.70 GB
step 1, memory after unet forward pass: 39.01 GB
step 2, memory after unet forward pass: 47.30 GB
step 3, memory after unet forward pass: 55.62 GB

Thanks so much for the information. I just realized I altered the model structure, replacing evaCLIP with CLIP and a larger linear projection. I guess that should be the reason why my GPU consumption is high. But DeepSpeed can dramatically reduce memory usage, more than halving it. I managed to run at bsz=4 now, but I still appreciate your information.

I am training pulid like non-acclerated model for diffusion loss and acclerated model for id loss, and a weird problem arises: the generated image includes many faces of the same person. how can i resolve it? thx

the multi-head problem is likely derived from the lightning model (they mentioned this in the lighting paper). And I did notice that when my training data was not filtered for only containing 1 face, the multi-head problem was more severe. But for stage2 with SDXL+SDXLL training I'm not sure.

thanks for your sharings. in this issue https://github.com/ToTheBeginning/PuLID/issues/150#issue-2632261758, the authors said that all the loss in the stage2 are calculated with the lightning model. i am wondering maybe there is a chance the joint usage of sdxl + sdxll cause this? but i don't know how to derive the diffusion loss for the lightning model either, is it the adversarial loss for training the lighgning model?

Using only sdxll is easier. Since xll is just an xl model with a different set of weights, you can initialize your unet model with the xll weights and compute all losses using it.

The paper does not mention whether they used a DDPM, DDIM, or something else at training time. The only thing written on the paper is that they used a DPM++ 2M at inference time. It is likely that they used a DDPM or a DDIM at training time.

thanks for sharing, i will try.

is the normal sampling schedule for xl suitable for xll? i mean can we calculate the diffusion loss for xll in the similar way to the conventionl xl?

there may actually exist such a problem. directly using the xll weight for calculating the sd loss seems have led to blurred images. Let me know if you also find such a phenomenon.

seems

me too, and i found that in pulid-flux, the image does become more blurry than original flux output

is the normal sampling schedule for xl suitable for xll? i mean can we calculate the diffusion loss for xll in the similar way to the conventionl xl?

there may actually exist such a problem. directly using the xll weight for calculating the sd loss seems have led to blurred images. Let me know if you also find such a phenomenon.

me too, and i found that in pulid-flux, the image does become more blurry than original flux output

is the normal sampling schedule for xl suitable for xll? i mean can we calculate the diffusion loss for xll in the similar way to the conventionl xl?

there may actually exist such a problem. directly using the xll weight for calculating the sd loss seems have led to blurred images. Let me know if you also find such a phenomenon.

me too, and i found that in pulid-flux, the image does become more blurry than original flux output

have you found a solution?

in my case, 1000 iter is enough to converge, so the blurry phenomenon is not severe

in my case, 1000 iter is enough to converge, so the blurry phenomenon is not severe

so fast! did you use the full training objective? what is the batch size for these 1000 iters?

is the normal sampling schedule for xl suitable for xll? i mean can we calculate the diffusion loss for xll in the similar way to the conventionl xl?

I have tested both ways, if the sd loss is calculated using the xll weights, it will lead to blurred images. And when I used xl for sd loss and xll for id loss, everything was fine. So I think the xll model is not suitable for performing traditional sd training.

hello. may i ask the training data should need the seg to acquire the face mask_img，which only contains the face region。when in stage1 only using the mse loss to train the sdxl , the similarity is very low.  May I ask how many training epoches are usually required to train the stage1? Or any other answers


Fix code/cd typo

Perhaps this is naive, but surely "code" in the original was a "cd" (autocorrect?) typo?

Ha, yes it was naive.


Fix #2376 - Update docs for changedAttributes.

This updates the documentation, but for what it's worth I think that returning {} is a good deal less surprising.  Thoughts?

This is really unexpected. In terms of API design this seems to be a poor choice since as mentioned before, changedAttributes implies it returns attributes that have changed. Anyone extending backbone has to handle around this weird edge case. Anyone looking to guard against the changedAttributes being empty should be a doing a call to hasChanged() first.
Consider someone iterating over the changedAttributes with something like _.each. They would have to add code to check if its false.
Behaviour should be changed IMHO.


openSUSE Leap 15-1 fails to install in WSL1/WSL2

Your Windows build number:  18932

What you're doing and what's happening:

WSL1:

Trying to install openSUSE Leap 15-1 via Windows Store
Clicking "Launch"
"Installing, this may take a few minutes..."
Asks for UNIX user name, enter it
Get spammed with "The system cannot find the file specified"

WSL2:

Installation fails with 0x80071772 (seems encryption related)

What's wrong / what should be happening instead:

The app files seem to be created encrypted in the Program Files/WindowsApps folder:

After pressing "Launch", the folders in my LocalState folder are marked as encrypted as well:

Compare that to Ubuntu, for example:
WindowsApps:

LocalState after (successful) install:

It seems this may be related to #4103, however the files don't seem to be compressed, but encrypted instead?

Same issue - Windows Build 18362 here with WSL1.  I have Ubuntu 16.4 and 18.4 installed, but that shouldn't matter, I wouldn't think.

still happening with wsl2 on build 18363.535. Any chance to get that fixed?

@lemmy04 WSL2 was first available in 18917, you're still running WSL1.

@lemmy04 WSL2 was first available in 18917, you're still running WSL1.

I'm on the latest windows 10 build 1909, which according to the microsoft docs should be running WSL2. At least I have a wsl command which i thought means it's wsl2 and not wsl1...

Confirmed here. This is on 19023, --set-default-version set to 2. Also tried 19555 before rolling back. I am not 100% convinced this is limited to OpenSUSE, but not willing to clobber my Ubuntu installs to find out.

still doesn't work with 2004 release

我的20.04版本也存在这个问题，于是我下载了18.04进行安装，最后18.04成功安装，这个时候我打开之前的20.04，居然没有提示找不到路径的错误了。
This problem also exists in my version 20.04, so I downloaded 18.04 for installation. Finally, 18.04 was successfully installed. At this time, I opened the previous version 20.04 without prompting the error that the path could not be found.


Create CODE_OF_CONDUCT.md

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   15.18%   15.18%
=======================================
  Files          81       81
  Lines        4708     4708
  Branches      811      811
=======================================
  Hits          715      715
  Misses       3926     3926
  Partials       67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34f93c5...7311e1b. Read the comment docs.


Hete spec decode

This PR enables heterogeneous speculative decoding by the parameter cpu_draft_worker
To make it happen, some changes need to be reviewed:

compile CPU ops anyway.
tensor-driven dispatch for custom_ops (may not needed once the ipex ops are done)
Extra MultiStepWorkers for CPU copying from GPU.

Hi @cadedaniel. This PR extended the usage of speculative decoding, which enables the draft models to run on the CPU. I only replaced the proposal worker with CPUWorker. However, the performance is not acceptable because the draft model in the CPU is slow.
I'd like to know if we could do it with an async method, which means the CPU and CUDA can run at the same time. The process can be: CPU run 1st req -> async CUDA run 1st req -> CPU run 2nd req -> await CUDA finish 1st req -> CUDA run 2nd req -> CPU run 1st req ......
It could be exciting and maybe the most benefit of heterogenous speculative decoding.
I was looking for some instructions like how to run 2 requests at the same time and if it is possible to use the async llm engine?
Thx!
cc @LiuXiaoxuanPKU

It's challenging to do this because even if you get async draft model, it won't have the latest accepted tokens from the target model during drafting. Probably means need a faster proposal method on CPU, like a high quality ngram model.

Hi @cadedaniel . I think this PR should be ready to be reviewed since issue #6285 has been fixed. Do you mind reviewing it? Thx!

Hi @cadedaniel . I think this PR should be ready to be reviewed since issue #6285 has been fixed. Do you mind reviewing it? Thx!
The main problem is that I compile both CPU and GPU ops, so we need to figure out a way if users want to only run on CPU, would like to hear your advice :)

Once we figure out a solution for this issue, I could update the Cmake file to pass the tests.

Hello @jiqing-feng . I can review the PR if you can show a performance benefit in some configuration that users will benefit from. Can you demonstrate a performance improvement and the configuration used with this PR? See below for the current performance improvement on GPU models.
Thanks.
Cade

Hello @jiqing-feng . I can review the PR if you can show a performance benefit in some configuration that users will benefit from. Can you demonstrate a performance improvement and the configuration used with this PR? See below for the current performance improvement on GPU models.
Thanks.
Cade

Sure! I am preparing the benchmark script and environments. I cannot run too big models such as 70B because I have limited computation results. The llama-7b + llama-68m will be my choice.
The performance data will be posted here once it's finished, thx!

Hi @cadedaniel
I tested this PR with llama-7b + llama-68m in 1 SPR(Intel 4th gen Xeon) with a Nvidia 4090 card. The result is:
greedy: 59 tokens/s
num_tokens = 1: 64 tokens/s
num_tokens = 2: 64 tokens/s
num_tokens = 3: 60 tokens/s
num_tokens = 4: 60 tokens/s
I initialize the llm by
llm = LLM(
            model=model,
            dtype=torch.float16,
            speculative_model=assistant_model, # The draft model. Must have same vocabulary as target model.
            tensor_parallel_size=1,
            num_speculative_tokens=2 if assistant_model else None, # The number of speculative tokens to score.
            use_v2_block_manager=True if assistant_model else None,
            max_num_seqs=args.max_num_seqs,
            enforce_eager=True,
            cpu_draft_worker=True if assistant_model else None,
        )

I only tested max_num_seqs=1, do you think it is enough? If not, please let me know how to test and how to set the QPS as in your chart. Thx!

I feel the improvements are too marginal to support this proposer unfortunately.

Is there a faster cpu model you can try?

Is there a faster cpu model you can try? may also be worth trying 70B base model since the cost ratio is larger

Hi @cadedaniel . I can't find a faster CPU model, but I got a faster CPU which is EMR (Intel 5th Gen Xeon). The performance is as follows:
baseline: 63.5 tokens/s
num_speculative_tokens= 1: 78.3 tokens/s
num_speculative_tokens= 2: 78.5 tokens/s
num_speculative_tokens= 3: 78.5 tokens/s
num_speculative_tokens= 4: 81.5 tokens/s
num_speculative_tokens= 5: 73.8 tokens/s
Do you think it is acceptable?

What QPS is this benchmark running?

What QPS is this benchmark running? Note my graph shows various QPS and how the speedup reduces over time.

I only test offline with some samples selected from wikipedia and set max_num_seqs=1. Do you have any guides for testing QPS? Thx!

Hi @cadedaniel . Do you mind starting to review this PR? I have cleaned all the tests except the AMD failed tests. There are still 2 issues that need your help:

Why AMD tests failed and how to reproduce to debug it?
Where and what kind of tests I should add?

Hi @cadedaniel . This PR is ready to be reviewed, I have cleaned all tests and added an end-to-end test for this feature. Please let me know your opinion. Thx!

Performance offline

Hi @LiuXiaoxuanPKU . There are still 3 failed tests, and they seem not related to my changes:

AMD kernel tests FAILED kernels/test_awq.py::test_awq_dequantize_opcheck - AttributeError: '_OpNamespace' '_C' object has no attribute 'awq_dequantize'
LoRA Long Context FAILED lora/test_long_context.py::test_batched_rope_kernel - IndexError: list index out of range
AMD: Entrypoints Test ERROR entrypoints/openai/test_lora_lineage.py::test_check_lora_lineage - RuntimeError: Server exited unexpectedly. Due to connection error.

Hi @jiqing-feng,
Thank you for sending this PR and demonstrating its performance. I have the following feedback:

We are not comfortable with the changes to the build process, vllm/_custom_ops.py, and Dockerfile. If this feature is merge, it should be an optional feature. Currently, this is requiring the common code path to understand and check whether it is running on CPU or GPU.
One potential way I can see this merged:

A CPUDraftWorker that utilizes Triton or Torch Compile
Demonstrate better speedup compare to the GPU based draft model. The baseline should not be without acceleration, rather, it should compare against GPU worker.
Overall, the changes should be clean and not intrusive.

Hi @simon-mo , thanks for your review. Is it okay to add a flag that controls cpu building in Cuda backend? For example, we can set an env variable export _CPU_CUDA=1, and we will add include(${CMAKE_CURRENT_LIST_DIR}/cmake/cpu_extension.cmake) only if we detected _CPU_CUDA=1 in CMakeLists.txt. The same in custom_ops.py, we will patch ops by input device only when _C_cpu is found.

Currently, the main block changes are not strictly related to speculative decoding, so we can focus on if we can build cpu ops in cuda backend vllm.  We can discuss it here #9224

I opened a new PR for the native path cpu draft model, see #9266 . In that case, we don't need to change anything in the build process.


fix: manually download protovalidate

This change is

Unnecessary. This was fixed upstream: https://github.com/bufbuild/protoc-gen-validate/issues/878


Maybe add a link to Bitcoin whitepaper?

Below the "The History of Bitcoin Cash" heading you are referring to the whitepaper, but maybe host the file and link to the document?

We should link to it, it is on the server already. https://bitcoincash.org/bitcoin.pdf

Ah definitely. It's whitepaper day after all 😜

PR created.


Question about serialized mode

Hi,
In Database.h it says "a Database object shall not be shared by multiple threads".
"SQLiteC++ does not support the fully thread-safe “Serialized” mode of SQLite, because of the way it shares the underlying SQLite precompiled statement in a custom shared pointer (See the inner class “Statement::Ptr”)."
I didn't quite understand the limitation reason for not sharing Database object.
My question is:
is it safe if I have a single database connection, and multiple threads are calling a function to read from/write to the database? (the function creates prepared statement locally, so every thread has its own prepared statement)
Thanks

I have similar question. Please let us know what's the behaviour.

Same here. What about using a unique pointer instead?


This page lists ALTER ANY EVENT SESSION but the docs page for that says it doesnt support Azure SQL

.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e18242cc-01df-27ba-a2cc-0f73e20c27d0
Version Independent ID: af3f329d-8374-9093-ac64-75ad95aa2b57
Content: Quickstart: Extended events in SQL Server - SQL Server
Content Source: docs/relational-databases/extended-events/quick-start-extended-events-in-sql-server.md
Product: sql
Technology: xevents
GitHub Login: @MightyPen
Microsoft Alias: genemi

@StingyJack -- thank you for your feedback.
@MightyPen -- please look into this issue #4210.

@StingyJack this quickstart as written does not work for Azure SQL Database. For Azure SQL Database, see https://docs.microsoft.com/en-us/azure/sql-database/sql-database-xevent-db-diff-from-svr - there are two code samples there that are written for Azure SQL Database

I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.

@WilliamAntonRohm @CarlRabeler this page states that it's for AzureSQL at the top and is littered with disclaimers for azure sql. So it's reasonable for me to expect that it's going to be consistent and correct in that regard. The expected docs work would be to either remove the azure sql stuff or fix the gaps. If it's not a priority right now, that's fine and I kind of understand, but closing the issue without resolving it is not appropriate for a few reasons.

I was not intending to close it. I wanted to give you a quick note telling you about the two articles that are written specifically for Azure SQL while I work on finding the time to address the article that you are asking about.
Carl
From: Andrew Stanton<EMAIL_ADDRESS>Sent: Wednesday, March 18, 2020 4:59 AM
To: MicrosoftDocs/sql-docs<EMAIL_ADDRESS>Cc: Carl Rabeler<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/sql-docs] This page lists ALTER ANY EVENT SESSION but the docs page for that says it doesnt support Azure SQL (#4210)
@WilliamAntonRohmhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FWilliamAntonRohm&data=02|01|Carl.Rabeler%40microsoft.com|e9195c3efd354c46061508d7cabe5ee2|72f988bf86f141af91ab2d7cd011db47|1|0|637200791288542617&sdata=EUPQNL0u3JakpuB8luBP1ZCjid4AVX7NliFtcuqTVto%3D&reserved=0 @CarlRabelerhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCarlRabeler&data=02|01|Carl.Rabeler%40microsoft.com|e9195c3efd354c46061508d7cabe5ee2|72f988bf86f141af91ab2d7cd011db47|1|0|637200791288542617&sdata=jaeAe%2BR0TOwHyyMIYTWcofHBGktrJK%2Bx%2Buf5rdg%2FkaU%3D&reserved=0 this page states that it's for AzureSQL at the top and is littered with disclaimers for azure sql. So it's reasonable for me to expect that it's going to be consistent and correct in that regard. The expected docs work would be to either remove the azure sql stuff or fix the gaps. If it's not a priority right now, that's fine and I kind of understand, but closing the issue without resolving it is not appropriate for a few reasons.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fsql-docs%2Fissues%2F4210%23issuecomment-600320858&data=02|01|Carl.Rabeler%40microsoft.com|e9195c3efd354c46061508d7cabe5ee2|72f988bf86f141af91ab2d7cd011db47|1|0|637200791288552581&sdata=8eVvR9sHEvx7aUUzj4Acwr2FEstoN8V41m4Wmd2HG9Y%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADAIDH63WRFPRXBKSFGUM6TRH7XBPANCNFSM4K2J7INA&data=02|01|Carl.Rabeler%40microsoft.com|e9195c3efd354c46061508d7cabe5ee2|72f988bf86f141af91ab2d7cd011db47|1|0|637200791288552581&sdata=DyvXYQYxXmcRD3pIDF7KF7tfdzcJKkzZBJ5QTA%2FOVAw%3D&reserved=0.

@CarlRabeler, @StingyJack -- my mistake -- I misunderstood Carl's response as final.

PR pending

merged and live


Change mandatory paramerters in create new api REST API

Description:
We should be able to create an api using Pubisher rest api with the minimum parameters as

name
context
version

Fixed with https://github.com/wso2/carbon-apimgt/pull/6273

https://github.com/wso2/carbon-apimgt/pull/6278


Fix container inspect endpoint returning null for network settings / ports

Fixes compatibility issue with testcontainers.
This pull requests adds list of ports to NetworkSettings.Ports
Docker inspect returns Ports:
        "NetworkSettings": {
            "Bridge": "",
            "SandboxID": "8481a8888bee4be0737c003ab80224e8bbcf22064e55a19e93a7eb33f253fd9c",
            "HairpinMode": false,
            "LinkLocalIPv6Address": "",
            "LinkLocalIPv6PrefixLen": 0,
            "Ports": {
                "2222/tcp": [
                    {
                        "HostIp": "<IP_ADDRESS>",
                        "HostPort": "32770"
                    }
                ]
            },

After this change podman returns ports from compat API interface:
  "NetworkSettings": {
    "Bridge": "",
    "SandboxID": "",
    "HairpinMode": false,
    "LinkLocalIPv6Address": "",
    "LinkLocalIPv6PrefixLen": 0,
    "Ports": {
      "2222/tcp": [
        {
          "HostIp": "",
          "HostPort": "38947"
        }
      ]
    },

Incorrect HostIp is out of scope for this pull request. I think that mapping empty string to <IP_ADDRESS> should be done in libpod/container_inspect.go rather than doing it in api/compat/container.go. Considering that I don't fully understand side effects that change to container_inspect could have caused, I decided to not to implement it.

/ok-to-test

LGTM
@mheon @baude PTAL

lgtm, @mheon ptal

/approve

/lgtm


Newly added re-directs are not re-directing.

Hi,
We have been using the notFoundHandler in Optimizely for a while now to create re-directs with no issue.
Recently, the re-directs that we are adding are not actually re-directing.
I have raised a ticket with Optimizely support who have suggested I contact the contributors of this package directly.
Any advice on how I could debug this? or is there any documentation that I could use related to this issue?
Re-directs that were added in the past are still working. However, if we try to add new re-directs, they do not actually re-direct when testing.
Old working re-direct:  https://www.jotun.com/no/no/b2c/how-to/video/how-to-maintain-teak-details-on-boat.aspx > https://www.jotun.com/no-no/decorative/yachting/how-to/how-to-maintain-teak
The above example re-directs from the old url (left of >) to the new url.
New broken re-direct: https://www.jotun.com/no-no/decorative/professional/architects-downloads > https://www.jotun.com/no-no/decorative/professional/farger/jotun-digital-colour-palette
The above example will just direct the user the the old url (left of >)
Geta.NotFoundHandler.Optimiziely version = 5.01
Geta.NotFoundHandler.Optimiziely.Commerce version = 5.01
EPiServer.CMS Version 12.7.0
EPiServer.Commerce Version 14.4.0
Please let me know if you need any more information.

As I see it is not broken. It is just that your old page still exists. 404 handler redirect only 404 requests. If a page exists, it will work as before.

I do not have access to that page. What is a stack trace? Is it related to the NotFound handler?


rpc: try to catch EOF error from lnd sendpayment

A user observed that when using Python, they get an EOF even if the payment succeeds. My guess is that lnd has hung up, then we try to recv and get an EOF error. With this PR, we try to catch that EOF error and just return nil.
One other idea: do we need to call CloseSend at the very end or in a defer?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 6 (0.0%)  changed or added relevant lines in 1 file are covered.
32 unchanged lines in 6 files lost coverage.
Overall coverage decreased (-0.001%) to 40.846%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

rpcserver.go
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

tapchannel/aux_leaf_signer.go
3
36.31%

asset/mock.go
3
92.2%

tapgarden/caretaker.go
4
68.5%

rpcserver.go
6
0.0%

asset/asset.go
6
80.96%

universe/interface.go
10
52.81%

Totals

Change from base Build<PHONE_NUMBER>8:
-0.001%

Covered Lines:
25714

Relevant Lines:
62954

💛  - Coveralls

Not sure if I'm doing something wrong, but I'm getting this error.
unknown flag `taproot-assets.experimental.rfq.priceoracleaddress'
could not load config: error parsing flags: unknown flag `taproot-assets.experimental.rfq.priceoracleaddress'

Has taproot-assets.experimental.rfq.priceoracleaddress been depreciated for something else?

Are you running tapd directly? Then you need to remove the taproot-assets prefix as that's only valid in litd.

I'm running litd. I didn't think you could use sendpayment with tapd directly.

you could use sendpayment with tapd directly

Yeah, you can't. Just trying to find out what's wrong here... Is it possible you have an old litd somewhere in your $PATH that's being picked up?
The flag still exists on the update-to-lnd-18-4 branch (but it probably doesn't on master):
litd --help | grep oracle
      --taproot-assets.experimental.rfq.priceoracleaddress=                    Price oracle gRPC server address (rfqrpc://<hostname>:<port>). To use the
                                                                               use_mock_price_oracle_service_promise_to_not_use_on_mainnet

you could use sendpayment with tapd directly

Yeah, you can't. Just trying to find out what's wrong here... Is it possible you have an old litd somewhere in your $PATH that's being picked up? The flag still exists on the update-to-lnd-18-4 branch (but it probably doesn't on master):
litd --help | grep oracle
      --taproot-assets.experimental.rfq.priceoracleaddress=                    Price oracle gRPC server address (rfqrpc://<hostname>:<port>). To use the
                                                                               use_mock_price_oracle_service_promise_to_not_use_on_mainnet

I was running inside docker, so I don't think that was the issue.

Updated the PR body with more context.

Sorry, I accidentally was not using dev.Dockerfile, so it was just pulling from master instead of using my locally checked out branch.
I can confirm this fix works!


Update Data Transforms

Update Data Transforms for latest release.
Internal Review URL
Fixes https://github.com/dotnet/docs/issues/9476

Thanks, @mairaw!


Do not emit "on-location-change" event

The header is aware of the "vaadin-router-location-changed" event emitted by Vaadin router already.

Looks like it is emitted here: https://github.com/vaadin/directory/blob/main/frontend/index.ts#L25


Project install

I've just realised the admin installations were not done under /project anymore, this PR aims to  fix that. It however keeps the modules and stages installations under scratch.

you can merge and resetart