Certificate Requests not approved when using customized configuration with GKE and workload identity.

I'm trying to deploy google-cas-issuer to a workload identity GKE cluster. When I follow the steps in the README, it works perfectly. Certs are issued and renewed like I would expect. However, when I try to customize the installation to fit with the non-default setup, I receive no certificates, as they are not being approved by the cert-manager controller. I split up the files from the installation YAML blob into templates so that it could be customized and installed via Helm.
The cert-manager controller is using workload identity, also. We create a GCP service account and give it access to our Cloud DNS for letsencrypt DNS challenges. In the case of this customized install, the kubernetes service account is tk-accurate-sloth-cm. Then, for the google-cas-issuer setup, we are creating another GCP service account and giving permissions to request certificates, and associating it with the tk-accurate-sloth-cas kubernetes service account.
While troubleshooting, I tried adding the CLI switch to disable the approval requirement, and certificates were then able to be created. So it really seems to be an RBAC issue.
The cert-manager controller shows the following log message:
Setting lastTransitionTime for Certificate "tk-accurate-sloth-mtls" condition "Issuing" to 2021-07-27 16:13:01.992887246 +0000 UTC m=+2556.823535918
Setting lastTransitionTime for Certificate "tk-accurate-sloth-mtls" condition "Ready" to 2021-07-27 16:13:01.998242329 +0000 UTC m=+2556.828890997
cert-manager/controller/CertificateReadiness "msg"="re-queuing item due to error processing" "error"="Operation cannot be fulfilled on certificates.cert-manager.io \"tk-accurate-sloth-mtls\": the object has been modified; please apply your changes to the latest version and try again" "key"="default/tk-accurate-sloth-mtls"
Setting lastTransitionTime for Certificate "tk-accurate-sloth-mtls" condition "Ready" to 2021-07-27 16:13:02.303237948 +0000 UTC m=+2557.133886616
cert-manager/controller/CertificateReadiness "msg"="re-queuing item due to error processing" "error"="Operation cannot be fulfilled on certificates.cert-manager.io \"tk-accurate-sloth-mtls\": the object has been modified; please apply your changes to the latest version and try again" "key"="default/tk-accurate-sloth-mtls"

The google-cas-issuer deployment shows the following log message:
INFO controller.CertificateRequest Checking whether CR has been approved {"certificaterequest": "default/tk-accurate-sloth-mtls-2qmlg", "cr": {"namespace": "default", "name": "tk-accurate-sloth-mtls-2qmlg"}}
INFO controller.CertificateRequest certificate request is not approved yet {"certificaterequest": "default/tk-accurate-sloth-mtls-2qmlg", "cr": {"namespace": "default", "name": "tk-accurate-sloth-mtls-2qmlg"}}
DEBUG controller-runtime.manager.events Warning {"object": {"kind":"CertificateRequest","namespace":"default","name":"tk-accurate-sloth-mtls-2qmlg","uid":"9129e9a3-a893-4c7a-bf46-7bcaca52c836","apiVersion":"cert-manager.io/v1","resourceVersion":"28598"}, "reason": "CRNotApproved", "message": "certificate request is not approved yet"}

I have attempted to diff the RBAC settings and they appear to be the same, aside from the customized service account name changes. Here's a dump of everything from the non-working customized cluster. Please let me know if there are any additional details I can provide.
apiVersion: v1
automountServiceAccountToken: true
kind: ServiceAccount
metadata:
  annotations:
    iam.gke.io/gcp-service-account<EMAIL_ADDRESS>  creationTimestamp: "2021-07-27T15:32:04Z"
  managedFields:
  - apiVersion: v1
    fieldsType: FieldsV1
    fieldsV1:
      f:automountServiceAccountToken: {}
      f:metadata:
        f:annotations:
          .: {}
          f:iam.gke.io/gcp-service-account: {}
    manager: HashiCorp
    operation: Update
    time: "2021-07-27T15:32:04Z"
  - apiVersion: v1
    fieldsType: FieldsV1
    fieldsV1:
      f:secrets:
        .: {}
        k:{"name":"tk-accurate-sloth-cas-token-xkkmr"}:
          .: {}
          f:name: {}
    manager: kube-controller-manager
    operation: Update
    time: "2021-07-27T15:32:04Z"
  name: tk-accurate-sloth-cas
  namespace: cert-manager
  resourceVersion: "5319"
  selfLink: /api/v1/namespaces/cert-manager/serviceaccounts/tk-accurate-sloth-cas
  uid: 1ccd9e55-2107-4d7c-9d84-d17493df3da2
secrets:
- name: tk-accurate-sloth-cas-token-xkkmr
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  annotations:
    meta.helm.sh/release-name: google-cas-issuer
    meta.helm.sh/release-namespace: cert-manager
  creationTimestamp: "2021-07-27T15:32:12Z"
  labels:
    app.kubernetes.io/managed-by: Helm
  managedFields:
  - apiVersion: rbac.authorization.k8s.io/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .: {}
          f:meta.helm.sh/release-name: {}
          f:meta.helm.sh/release-namespace: {}
        f:labels:
          .: {}
          f:app.kubernetes.io/managed-by: {}
      f:rules: {}
    manager: Go-http-client
    operation: Update
    time: "2021-07-27T15:32:12Z"
  name: cert-manager-controller-approve:casissuer
  resourceVersion: "5402"
  selfLink: /apis/rbac.authorization.k8s.io/v1/clusterroles/cert-manager-controller-approve%3Acasissuer
  uid: 92c4785d-98c8-41dd-9976-4e97c3e9f76f
rules:
- apiGroups:
  - cert-manager.io
  resourceNames:
  - googlecasclusterissuers.cas-issuer.jetstack.io/*
  - googlecasissuers.cas-issuer.jetstack.io/*
  resources:
  - signers
  verbs:
  - approve
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  annotations:
    meta.helm.sh/release-name: google-cas-issuer
    meta.helm.sh/release-namespace: cert-manager
  creationTimestamp: "2021-07-27T15:32:13Z"
  labels:
    app.kubernetes.io/managed-by: Helm
  managedFields:
  - apiVersion: rbac.authorization.k8s.io/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .: {}
          f:meta.helm.sh/release-name: {}
          f:meta.helm.sh/release-namespace: {}
        f:labels:
          .: {}
          f:app.kubernetes.io/managed-by: {}
      f:roleRef:
        f:apiGroup: {}
        f:kind: {}
        f:name: {}
      f:subjects: {}
    manager: Go-http-client
    operation: Update
    time: "2021-07-27T15:32:13Z"
  name: cert-manager-controller-approve:casissuer
  resourceVersion: "5404"
  selfLink: /apis/rbac.authorization.k8s.io/v1/clusterrolebindings/cert-manager-controller-approve%3Acasissuer
  uid: fbbf4c96-dc7d-431e-a68e-9627bdae81d0
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: cert-manager-controller-approve:casissuer
subjects:
- kind: ServiceAccount
  name: tk-accurate-sloth-cm
  namespace: cert-manager
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  annotations:
    meta.helm.sh/release-name: google-cas-issuer
    meta.helm.sh/release-namespace: cert-manager
  creationTimestamp: "2021-07-27T15:32:12Z"
  labels:
    app.kubernetes.io/managed-by: Helm
  managedFields:
  - apiVersion: rbac.authorization.k8s.io/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .: {}
          f:meta.helm.sh/release-name: {}
          f:meta.helm.sh/release-namespace: {}
        f:labels:
          .: {}
          f:app.kubernetes.io/managed-by: {}
      f:rules: {}
    manager: Go-http-client
    operation: Update
    time: "2021-07-27T15:32:12Z"
  name: google-cas-issuer-role
  resourceVersion: "5401"
  selfLink: /apis/rbac.authorization.k8s.io/v1/clusterroles/google-cas-issuer-role
  uid: fb4ae0cf-a5be-4235-a246-2a46a2b0f638
rules:
- apiGroups:
  - ""
  resources:
  - events
  verbs:
  - create
  - patch
- apiGroups:
  - ""
  resources:
  - secrets
  verbs:
  - get
  - list
  - watch
- apiGroups:
  - cas-issuer.jetstack.io
  resources:
  - googlecasclusterissuers
  verbs:
  - create
  - delete
  - get
  - list
  - patch
  - update
  - watch
- apiGroups:
  - cas-issuer.jetstack.io
  resources:
  - googlecasclusterissuers/status
  verbs:
  - get
  - patch
  - update
- apiGroups:
  - cas-issuer.jetstack.io
  resources:
  - googlecasissuers
  verbs:
  - create
  - delete
  - get
  - list
  - patch
  - update
  - watch
- apiGroups:
  - cas-issuer.jetstack.io
  resources:
  - googlecasissuers/status
  verbs:
  - get
  - patch
  - update
- apiGroups:
  - cert-manager.io
  resources:
  - certificaterequests
  verbs:
  - get
  - list
  - update
  - watch
- apiGroups:
  - cert-manager.io
  resources:
  - certificaterequests/status
  verbs:
  - get
  - patch
  - update
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  annotations:
    meta.helm.sh/release-name: google-cas-issuer
    meta.helm.sh/release-namespace: cert-manager
  creationTimestamp: "2021-07-27T15:32:13Z"
  labels:
    app.kubernetes.io/managed-by: Helm
  managedFields:
  - apiVersion: rbac.authorization.k8s.io/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .: {}
          f:meta.helm.sh/release-name: {}
          f:meta.helm.sh/release-namespace: {}
        f:labels:
          .: {}
          f:app.kubernetes.io/managed-by: {}
      f:roleRef:
        f:apiGroup: {}
        f:kind: {}
        f:name: {}
      f:subjects: {}
    manager: Go-http-client
    operation: Update
    time: "2021-07-27T15:32:13Z"
  name: google-cas-issuer-rolebinding
  resourceVersion: "5403"
  selfLink: /apis/rbac.authorization.k8s.io/v1/clusterrolebindings/google-cas-issuer-rolebinding
  uid: af8b5443-b4bd-40ce-a467-734abebea7f7
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: google-cas-issuer-role
subjects:
- kind: ServiceAccount
  name: tk-accurate-sloth-cas
  namespace: cert-manager
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
  annotations:
    meta.helm.sh/release-name: google-cas-issuer
    meta.helm.sh/release-namespace: cert-manager
  creationTimestamp: "2021-07-27T15:32:13Z"
  labels:
    app.kubernetes.io/managed-by: Helm
  managedFields:
  - apiVersion: rbac.authorization.k8s.io/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .: {}
          f:meta.helm.sh/release-name: {}
          f:meta.helm.sh/release-namespace: {}
        f:labels:
          .: {}
          f:app.kubernetes.io/managed-by: {}
      f:rules: {}
    manager: Go-http-client
    operation: Update
    time: "2021-07-27T15:32:13Z"
  name: leader-election-role
  namespace: cert-manager
  resourceVersion: "5405"
  selfLink: /apis/rbac.authorization.k8s.io/v1/namespaces/cert-manager/roles/leader-election-role
  uid: 4a2c8d34-186b-40bc-b04a-ddc734867f08
rules:
- apiGroups:
  - ""
  resources:
  - configmaps
  verbs:
  - get
  - list
  - watch
  - create
  - update
  - patch
  - delete
- apiGroups:
  - ""
  resources:
  - configmaps/status
  verbs:
  - get
  - update
  - patch
- apiGroups:
  - ""
  resources:
  - events
  verbs:
  - create
- apiGroups:
  - coordination.k8s.io
  resources:
  - leases
  verbs:
  - create
  - get
  - list
  - update
---
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
  annotations:
    meta.helm.sh/release-name: google-cas-issuer
    meta.helm.sh/release-namespace: cert-manager
  creationTimestamp: "2021-07-27T15:32:13Z"
  labels:
    app.kubernetes.io/managed-by: Helm
  managedFields:
  - apiVersion: rbac.authorization.k8s.io/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .: {}
          f:meta.helm.sh/release-name: {}
          f:meta.helm.sh/release-namespace: {}
        f:labels:
          .: {}
          f:app.kubernetes.io/managed-by: {}
      f:roleRef:
        f:apiGroup: {}
        f:kind: {}
        f:name: {}
      f:subjects: {}
    manager: Go-http-client
    operation: Update
    time: "2021-07-27T15:32:13Z"
  name: leader-election-rolebinding
  namespace: cert-manager
  resourceVersion: "5407"
  selfLink: /apis/rbac.authorization.k8s.io/v1/namespaces/cert-manager/rolebindings/leader-election-rolebinding
  uid: 11b00b94-9a71-4022-83d7-96c1ec19b4dc
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: Role
  name: leader-election-role
subjects:
- kind: ServiceAccount
  name: tk-accurate-sloth-cas
  namespace: cert-manager
---
apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "1"
    meta.helm.sh/release-name: google-cas-issuer
    meta.helm.sh/release-namespace: cert-manager
  creationTimestamp: "2021-07-27T15:32:13Z"
  generation: 1
  labels:
    app: cert-manager-google-cas-issuer
    app.kubernetes.io/managed-by: Helm
  managedFields:
  - apiVersion: apps/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .: {}
          f:meta.helm.sh/release-name: {}
          f:meta.helm.sh/release-namespace: {}
        f:labels:
          .: {}
          f:app: {}
          f:app.kubernetes.io/managed-by: {}
      f:spec:
        f:progressDeadlineSeconds: {}
        f:replicas: {}
        f:revisionHistoryLimit: {}
        f:selector:
          f:matchLabels:
            .: {}
            f:app: {}
        f:strategy:
          f:rollingUpdate:
            .: {}
            f:maxSurge: {}
            f:maxUnavailable: {}
          f:type: {}
        f:template:
          f:metadata:
            f:labels:
              .: {}
              f:app: {}
          f:spec:
            f:containers:
              k:{"name":"google-cas-issuer"}:
                .: {}
                f:args: {}
                f:command: {}
                f:image: {}
                f:imagePullPolicy: {}
                f:name: {}
                f:resources:
                  .: {}
                  f:limits:
                    .: {}
                    f:cpu: {}
                    f:memory: {}
                  f:requests:
                    .: {}
                    f:cpu: {}
                    f:memory: {}
                f:terminationMessagePath: {}
                f:terminationMessagePolicy: {}
            f:dnsPolicy: {}
            f:restartPolicy: {}
            f:schedulerName: {}
            f:securityContext: {}
            f:serviceAccount: {}
            f:serviceAccountName: {}
            f:terminationGracePeriodSeconds: {}
    manager: Go-http-client
    operation: Update
    time: "2021-07-27T15:32:13Z"
  - apiVersion: apps/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          f:deployment.kubernetes.io/revision: {}
      f:status:
        f:availableReplicas: {}
        f:conditions:
          .: {}
          k:{"type":"Available"}:
            .: {}
            f:lastTransitionTime: {}
            f:lastUpdateTime: {}
            f:message: {}
            f:reason: {}
            f:status: {}
            f:type: {}
          k:{"type":"Progressing"}:
            .: {}
            f:lastTransitionTime: {}
            f:lastUpdateTime: {}
            f:message: {}
            f:reason: {}
            f:status: {}
            f:type: {}
        f:observedGeneration: {}
        f:readyReplicas: {}
        f:replicas: {}
        f:updatedReplicas: {}
    manager: kube-controller-manager
    operation: Update
    time: "2021-07-27T15:32:18Z"
  name: google-cas-issuer
  namespace: cert-manager
  resourceVersion: "5464"
  selfLink: /apis/apps/v1/namespaces/cert-manager/deployments/google-cas-issuer
  uid: 9e4bf84f-0bb5-4709-b60a-2e1426e6213d
spec:
  progressDeadlineSeconds: 600
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app: cert-manager-google-cas-issuer
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        app: cert-manager-google-cas-issuer
    spec:
      containers:
      - args:
        - --enable-leader-election
        - --zap-devel=true
        command:
        - /google-cas-issuer
        image: quay.io/jetstack/cert-manager-google-cas-issuer:0.5.2
        imagePullPolicy: IfNotPresent
        name: google-cas-issuer
        resources:
          limits:
            cpu: 100m
            memory: 30Mi
          requests:
            cpu: 100m
            memory: 20Mi
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      serviceAccount: tk-accurate-sloth-cas
      serviceAccountName: tk-accurate-sloth-cas
      terminationGracePeriodSeconds: 10
status:
  availableReplicas: 1
  conditions:
  - lastTransitionTime: "2021-07-27T15:32:18Z"
    lastUpdateTime: "2021-07-27T15:32:18Z"
    message: Deployment has minimum availability.
    reason: MinimumReplicasAvailable
    status: "True"
    type: Available
  - lastTransitionTime: "2021-07-27T15:32:13Z"
    lastUpdateTime: "2021-07-27T15:32:18Z"
    message: ReplicaSet "google-cas-issuer-98f47c5f9" has successfully progressed.
    reason: NewReplicaSetAvailable
    status: "True"
    type: Progressing
  observedGeneration: 1
  readyReplicas: 1
  replicas: 1
  updatedReplicas: 1

I had overlooked that I was installing an older version of cert-manager. After changing that to install v1.4.0, things appear to be working normally.


docs(blog): adds asyncapi with sqs blog post

Description
Adds blog post
Related issue(s)

Resolves https://github.com/asyncapi/website/issues/908

Just a few simple commit suggestions for you to accept @amuroBosetti and then this should be good to go smile

Thanks for your review! Everything has been applied, so what do the next steps look like here? @derberg @alequetzalli

@amuroBosetti Alejandra is on holidays now, so we need to wait 2 weeks for final approval, which is not a big problem I think, we are not in rush. Also better to publish late September as people will be back from holidays full time then. So more readers for the article 😉

/rtm


add backoff for gRPC errors

Fixes https://github.com/istio/ztunnel/issues/413

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
3fbcc0aacef32f0943315e8c9217790efe05a9e2
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


chore: added warmstart initialization for JaxPlan

This PR modifies JaxPlan to allow it to start with predefined weights for both SLP and DRPs.
It used here: https://github.com/danielbdias/ptb-abstraction-experimentation/blob/main/experiments/intervalanalysis/step3_create_warm_start_policies_and_run.py#L65

Daniel, I am not sure exactly what this pull request is designed to accomplish. Are you simply trying to instantiate a jax policy using a pre-trained weight parameter? If so, why can't you simply create the planner as normal and pass the guess parameter to the optimize function? Maybe your use case is nuanced and you somehow need a custom initialization, not just a plan warm start?
===
Some helpful info about JAX I learned the hard way:
In JAX and it's satellite packages (optax, flax, dm-haiku, etc), all functions that we define must be functionally pure, i.e. they cannot maintain an internal state or memory, and everything has to be specified as part of the function signature (static data are just inputs to the function,  dynamic data are also outputs as well). In the case of specifying a neural network or any JAX based model, you do not modify the initialization procedure to warm start, you simply operate on the pytree of parameters you maintain over time (a PyTree is just a nested collection, with leaves being jax.numpy arrays).
In this case, why can't you just use the pytree of pre-trained parameters for the policy that the planner gives you during the pretraining, then operate on it as needed to remove the ablated fluents, and pass it to a fresh planner instance? You do not need to modify the code and it is much more transparent this way. I actually already do this in the online/replanning regime: I train on a short rollout horizon, then when the env transitions after taking the current action, I cut off the action from the pytree of trained parameters, append a fresh action to the end, and pass this in to the optimizer as a warm start (the function guess_next_epoch is doing this).

Hi Mike, my idea was just to set up the initialization. I'm modifying my code to use the guess parameter and running some experiments to check it.
Thanks for the clarifications about JAX. It helped a lot to understand the reasoning behind some features of JaxPlan.
About return_callback param: I've added it because I'm collecting some statistics on each iteration of the optimize method, like the best_reward at each iteration. Since I noticed that optimize does the iteration internally, is there a way to capture train_return, 'best_return', and test_return for each iteration?

Hi Daniel, yes this is very easy, in fact the reason why I changed the code to use the generator approach.
Does this notebook answer your question?
Specifically, to get the test return each iteration:
for callback in planner.optimize_generator(...):
    print(callback['test_return'])

I believe this has the same arguments as the optimize() function.

I was able to use all features with https://github.com/pyrddlgym-project/pyRDDLGym-jax/pull/9, so I'm closing this PR.
About this feature:

I think what we may wish to keep here is the per-layer initialization which I like a lot, though I don't know exactly how common that is and whether it's worth to provide at the expense of a more difficult argument to pass on the user side In that event, we will need to replace the initializer argument because it will conflict with the new one. Maybe we can auto detect if the user passes a dictionary or a regular initializer as currently? If it is not a dict, we can just make the dict internally with the given initializer as value for all layers/actions.

I need to think about whether it makes sense. I can open a PR later about DRP initialization.


add motion that move cursor to first/last line of the paragraph?

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)

Description
the { and } motion move cursor to blank line
but sometimes it's useful to move cursor to the first/last non-blank line of the paragraph (e.g. when using blockwise-visual mode)
Vim: How to jump to first/last line of the current paragraph?
i hope that mini can add this feature
maybe mini.motions? :)
here is how I implemented it:
local function paragraph_border_line_p(lnum)
	if lnum == 1 then
		return true
	end
	if lnum == vim.fn.line('$') then
		return true
	end
	if vim.fn.getline(lnum) ~= '' and vim.fn.getline(lnum - 1) == '' then
		return true
	end
	if vim.fn.getline(lnum) ~= '' and vim.fn.getline(lnum + 1) == '' then
		return true
	end
	return false
end

function paragraph_border_backward_lnum(lnum)
	if lnum == 1 then
		return lnum
	end
	if paragraph_border_line_p(lnum - 1) then
		return lnum - 1
	end
	return paragraph_border_backward_lnum(lnum - 1)
end

function paragraph_border_forward_lnum(lnum)
	if lnum == vim.fn.line('$') then
		return lnum
	end
	if paragraph_border_line_p(lnum + 1) then
		return lnum + 1
	end
	return paragraph_border_forward_lnum(lnum + 1)
end

function paragraph_border_backward()
	local line_number_current = vim.fn.line('.')
	local line_number_destination = paragraph_border_backward_lnum(line_number_current)
	vim.cmd(tostring(line_number_destination))
end

function paragraph_border_forward()
	local line_number_current = vim.fn.line('.')
	local line_number_destination = paragraph_border_forward_lnum(line_number_current)
	vim.cmd(tostring(line_number_destination))
end

vim.keymap.set({'n', 'v'}, '(', paragraph_border_backward)
vim.keymap.set('o', '(', 'V(')
vim.keymap.set({'n', 'v'}, ')', paragraph_border_forward)
vim.keymap.set('o', ')', 'V)')

Thanks for the suggestion!
Unfortunately, I don't think there will be a good place for this in 'mini.nvim'.
There is no plans for 'mini.motions' or something like it. Maybe if there are more non-trivial motions that can be fit in the same module nicely.
Closing as "probably not planned, but will keep in mind".


Lock for compactors

Thanos, Prometheus and Golang version used:
v0.8.1
Object Storage Provider:
Azure Blob Storage
What happened:
Had several jobs doing compaction at the same time (bogus configuration).
All jobs raced to do the compaction until deletion of old blobs where one did it faster than the others so the others failed.
What you expected to happen:
I'm wondering if we could have a lock written on the storage that prevents multiple compactors to run at the same time.

Hi, have you seen https://thanos.io/proposals/201901-read-write-operations-bucket.md/? Seems like your request is a duplicate of that one.

Not really a duplicate of this, rather a dup of another proposal we used to work on here: https://github.com/thanos-io/thanos/pull/522
The problem here is how to do it without introducing extra dependency like etcd (: Or if really necessary, how to seamlessly introduce it.

Still valid.

Still valid.


Times in BJD_TDB

Instrument
Other (any stage)
What is your suggestion?
I see that the measurement times written in the *LCdata.h5 output file of Stage 4 are the MJD_UTC of the start of the integration. It could be interesting to have them transformed to the BJD_TDB  of the mid-integration instead, as many users will use only Stage 1-4 of Eureka! and will then analyze the resulting light curves with different tools.
Error traceback output
No response
What operating system are you using?
No response
What version of Python are you running?
No response
What Python packages do you have installed?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

The times from Stages 3+ save files are the "int_mid_BJD_TDB" values from the JWST FITS headers (should actually be called "int_mid_BMJD_TDB"). So that's the BMJD_TDB of mid-integration already which I believe is what you're asking for. HST is a bit trickier as that value is not stored just directly in the FITS header, but I'm pretty sure we've already implemented the code to covert the FITS times for HST to BMJD_TDB of the mid-integration.
Closing this issue for now as I believe what you're asking for is already implemented, but please reopen this if I have misunderstood something.


PocketBeagle/TechLab/pushbutton.js depends on epoll being installed

Describe the bug
PocketBeagle/TechLab/pushbutton.js depends on epoll which isn't installed on the "BeagleBoard.org Debian Buster IoT Image 2020-04-06" image.
A simple
npm install epoll
does it.

Thanks @MarkAYoder sadly epoll isn't packaged, so this will be a little fun to script, but i'll work on it..

@RobertCNelson we should just drop that javascript example.  The python version works.

@MarkAYoder it is still useful having a JavaScript example for those wishing to learn how to do things with JavaScript.

@jadonk I think it's worth keeping the example, but not worth preinstalling epoll.  We could include a comment that says how to install it.


10 Rep says get vaccinated: Watch smartslix.com

10 Rep says get vaccinated requests the watch of the watch_keyword smartslix\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

smartslix\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

smartslix\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ

Approved by Spevacus in Charcoal HQ


Feature Aggregation - Sample sizes

There are different ways to consider a "sample" for the AutoML classification. We need to be able to aggregate sets of nPrints into one "sample" to attach a label to. For example, in the original work we tested 1, 10, and 100 packet samples of the same traffic sequences.
This can probably be implemented generally with a groupby on a dataframe. I've used something like this before:
for _, df in group.groupby(np.arange(len(group)) // sample_size):

closed with 8479ea15f4df2db1af18c0922157284c7b926f3f


What will consent banner look

Once google removes support for 3PC what will a consent banner look like? I'm.guessing as still have 1st party cookies if could look kind of similar with strictly necessary, functional still existing? And perhaps performance cookies like GA being deprecated. I do wonder what privacy companies like OneTrust and Trustarc are doing to work with Google Privacy Sandbox. I'm proposing internally we replace cookie policy pages with privacy trust policy pages. Cookies will remain post Googles changes but they will taste a bit different

Hi @Dory998 — thanks for your question, and apologies for the delay in responding.
The Privacy Sandbox Privacy-related compliance FAQs provides information about consent and ePrivacy.
We recommend that you contact your Consent Management Platform (CMP) to find out more about future consent banner requirements.

I'm closing this as completed, as there hasn't been any follow up in several weeks, but feel free to reopen if necessary.


Array item keys should not be based on array index

Prerequisites

[x] I have read the documentation;
[x] In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description
In arrays, the key is currently based on the array index, see https://github.com/mozilla-services/react-jsonschema-form/blob/master/src/components/fields/ArrayField.js#L49.
This is not recommended and can give rise to a number of issues, see https://reactjs.org/docs/lists-and-keys.html
In particular this:

Steps to Reproduce
Run https://jsfiddle.net/wt4hkpy2/, and try to remove 'item 1' or 'item 2'. The last item in the array gets removed.
This is because before removal there are 3 items with in index 0, 1 and 2. After removal there are two items with index 0 and 1. Thus the react reconciler infers that the item with index 2 must have been removed.
(I realise that by making the input controlled in the above example the problem disappears, but I purposely used the 'props to state' antipattern as it is the smallest way I could think of to demonstrate the key issue)
Expected behavior
The correct array item is removed
Actual behavior
The last array item is removed
Version
1.0.2, but problem exists in current master as well

I meant making the value of the input based on the props instead of the internal component state. See this fiddle: https://jsfiddle.net/esgybn75/

@christianeide perhaps. Do you have a method in mind to do this unique id assignment -- able to make a PR fixing this?

Perhaps using something like shortid as outlined in this article?

any updates on this? anything could be used to generate a unique id but it needs to be persisted outside of formState. I have been unable to figure out where that should be on reading the code. it seems like formState is the only source of truth for rendering an array

Like @f0rr0, would be happy to submit a PR if direction is given on what's the best approach and where we'd make this update.

@kylehalleman the best approach would be to create a unique id for each array item as it is added (or rendered for the first time), and set that to the key. You could use a library like shortid to do so; see https://medium.com/@robinpokorny/index-as-a-key-is-an-anti-pattern-e0349aece318


Js translation

Translate the JS、JSX file.

I saw in the 'superset/assets/javascripts/ explore/actions/exploreActions js' in' $= window. $= the require (' jquery ') 'can be used, why can't use in 'superset/assets/javascripts/explore/stores/getLanguage.js', there was' ReferenceError: the window is not defined' mistakes, where I need to configure it.
When I set '$= window.$= require' (' jquery ') 'to' $= require '(' jquery'), it prompts that '$. Ajax is not a function'！
can you help me!

Why are you opening a new PR?

Coverage increased (+0.003%) to 69.353% when pulling ba28118786b2f316def86ef4187e93a75912d11a on lxzhangchao:js_po_translation into 774ad45efbaad86238004e9a21d4c733f57bde36 on apache:master.

I want to create a new PR to remove excess commit, so I just open a branch and submit a new PR, think excess commit will disappear, the results still exist excess commit.I'm Sorry!

That's not how git works :) google for git rebase.
Once you have a handful of commits you can do the same after updating your master branch with latest changes and deal with conflicts.

Coverage increased (+0.003%) to 69.312% when pulling c494593dbafde91a984e1d74b479c8b4a93fcf15 on lxzhangchao:js_po_translation into 62fcdf2a92cc2fa93f77adbd650fc0a7031850a2 on apache:master.

Coverage increased (+0.003%) to 69.312% when pulling d2b91307074b64ba2340ca2151445427b7e375eb on lxzhangchao:js_po_translation into 62fcdf2a92cc2fa93f77adbd650fc0a7031850a2 on apache:master.

Coverage increased (+0.003%) to 69.312% when pulling 2271c201ae0b26460169727f60e90f0375c9edae on lxzhangchao:js_po_translation into 62fcdf2a92cc2fa93f77adbd650fc0a7031850a2 on apache:master.

Coverage decreased (-0.07%) to 69.225% when pulling d45143907d98c43c87cd692594788abb82bcdd11 on lxzhangchao:js_po_translation into 90592d3e3d4d2009ae59fcea55c08c932522e154 on apache:master.

Coverage decreased (-0.07%) to 69.225% when pulling d45143907d98c43c87cd692594788abb82bcdd11 on lxzhangchao:js_po_translation into 90592d3e3d4d2009ae59fcea55c08c932522e154 on apache:master.

Coverage increased (+0.004%) to 69.302% when pulling d45143907d98c43c87cd692594788abb82bcdd11 on lxzhangchao:js_po_translation into 90592d3e3d4d2009ae59fcea55c08c932522e154 on apache:master.

Coverage increased (+0.004%) to 69.302% when pulling d45143907d98c43c87cd692594788abb82bcdd11 on lxzhangchao:js_po_translation into 90592d3e3d4d2009ae59fcea55c08c932522e154 on apache:master.

I am very difficult to get the ajax request in getLanguage and can‘t get the current language. Do you have any Suggestions?

Would be nice if the PR didn't include all of the string translations... Makes it hard to read only the essence of it.
What exactly is the blocker with getLanguage?

Coverage increased (+0.004%) to 69.271% when pulling eaeb2b44021898719abdd180398cada07b1ea795 on lxzhangchao:js_po_translation into 5278b53218187992a089ed734ce90daf9551d44c on apache:master.

Coverage increased (+0.004%) to 69.271% when pulling eaeb2b44021898719abdd180398cada07b1ea795 on lxzhangchao:js_po_translation into 5278b53218187992a089ed734ce90daf9551d44c on apache:master.

You can see the code for only translating a page in 'https://github.com/apache/incubator-superset/compare/master...lxzhangchao:js_trans?expand=1‘’

Is there any way to get Superset current language in the JS file, to be able to compile it！

Coverage increased (+0.003%) to 69.314% when pulling e3acb23aa874944ab11686a2d1e33f0ac8f097fa on lxzhangchao:js_po_translation into f68189b54e0bc6467bf46ffb33b5cc4848a2a582 on apache:master.

Coverage increased (+0.003%) to 69.314% when pulling e3acb23aa874944ab11686a2d1e33f0ac8f097fa on lxzhangchao:js_po_translation into f68189b54e0bc6467bf46ffb33b5cc4848a2a582 on apache:master.

Coverage increased (+0.003%) to 69.314% when pulling 2e2da665112cd8b97da683cc72fdd4b180a7122b on lxzhangchao:js_po_translation into 2385cd445bf1eeffa9d1526640590f31317c3db4 on apache:master.

Coverage increased (+0.003%) to 69.314% when pulling 2e2da665112cd8b97da683cc72fdd4b180a7122b on lxzhangchao:js_po_translation into 2385cd445bf1eeffa9d1526640590f31317c3db4 on apache:master.

Coverage increased (+0.003%) to 69.314% when pulling 2e2da665112cd8b97da683cc72fdd4b180a7122b on lxzhangchao:js_po_translation into 2385cd445bf1eeffa9d1526640590f31317c3db4 on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling 4a08560a1a36cefd2ca3710a3b95882984240d5a on lxzhangchao:js_po_translation into 08b7e891a7dd65616aef4177b72b1e8770310d98 on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling 4a08560a1a36cefd2ca3710a3b95882984240d5a on lxzhangchao:js_po_translation into 08b7e891a7dd65616aef4177b72b1e8770310d98 on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling 4a08560a1a36cefd2ca3710a3b95882984240d5a on lxzhangchao:js_po_translation into 08b7e891a7dd65616aef4177b72b1e8770310d98 on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling 4e14a5a213a44a349fc8f144d928c1c42a32d062 on lxzhangchao:js_po_translation into 08b7e891a7dd65616aef4177b72b1e8770310d98 on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling 4e14a5a213a44a349fc8f144d928c1c42a32d062 on lxzhangchao:js_po_translation into 08b7e891a7dd65616aef4177b72b1e8770310d98 on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling 4e14a5a213a44a349fc8f144d928c1c42a32d062 on lxzhangchao:js_po_translation into 08b7e891a7dd65616aef4177b72b1e8770310d98 on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling 4e14a5a213a44a349fc8f144d928c1c42a32d062 on lxzhangchao:js_po_translation into 08b7e891a7dd65616aef4177b72b1e8770310d98 on apache:master.

when execute to 'npm run sync-backend' command, it can't  ajax request or window,  the following error occurs:

so the 'superset/assets/javascripts/explore/stores/controls.jsx' is not internationalization.
When you load the PO file with require, the following error occurs:

so I have executed some commands to convert the PO file into a JSON file.
Hope you can  receive this code and implement the Superset js internationalization.

Coverage increased (+0.003%) to 69.319% when pulling 4289bbbb2df441322652c5d2ca4e88c3e9e6bf71 on lxzhangchao:js_po_translation into b68084b9ac76c943e55f44b1b5ae22d79fc19d6f on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling 4289bbbb2df441322652c5d2ca4e88c3e9e6bf71 on lxzhangchao:js_po_translation into b68084b9ac76c943e55f44b1b5ae22d79fc19d6f on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling 4289bbbb2df441322652c5d2ca4e88c3e9e6bf71 on lxzhangchao:js_po_translation into b68084b9ac76c943e55f44b1b5ae22d79fc19d6f on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling 4289bbbb2df441322652c5d2ca4e88c3e9e6bf71 on lxzhangchao:js_po_translation into b68084b9ac76c943e55f44b1b5ae22d79fc19d6f on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling e5aa04b67c51a6494132a02a223e28930a922c79 on lxzhangchao:js_po_translation into b68084b9ac76c943e55f44b1b5ae22d79fc19d6f on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling e5aa04b67c51a6494132a02a223e28930a922c79 on lxzhangchao:js_po_translation into b68084b9ac76c943e55f44b1b5ae22d79fc19d6f on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling e5aa04b67c51a6494132a02a223e28930a922c79 on lxzhangchao:js_po_translation into b68084b9ac76c943e55f44b1b5ae22d79fc19d6f on apache:master.

Coverage increased (+0.003%) to 69.319% when pulling e5aa04b67c51a6494132a02a223e28930a922c79 on lxzhangchao:js_po_translation into b68084b9ac76c943e55f44b1b5ae22d79fc19d6f on apache:master.

Coverage increased (+0.003%) to 69.418% when pulling 662bca0b2a1027f4b45f15f6b269bf12fd9ff213 on lxzhangchao:js_po_translation into c9c6bcaabeab4127a601dfda69a1411d2893c1d5 on apache:master.

Coverage increased (+0.003%) to 69.418% when pulling 662bca0b2a1027f4b45f15f6b269bf12fd9ff213 on lxzhangchao:js_po_translation into c9c6bcaabeab4127a601dfda69a1411d2893c1d5 on apache:master.

Coverage increased (+0.003%) to 69.418% when pulling 662bca0b2a1027f4b45f15f6b269bf12fd9ff213 on lxzhangchao:js_po_translation into c9c6bcaabeab4127a601dfda69a1411d2893c1d5 on apache:master.

Hope you can accept this code！ @xrmx

Coverage increased (+0.003%) to 69.423% when pulling b30b7422d554d7ccbcca2acb969f1e978217d26c on lxzhangchao:js_po_translation into<PHONE_NUMBER>2cfa1126df1954cfa58d99cd23fc39 on apache:master.

Coverage increased (+0.003%) to 69.423% when pulling 9961ab00e95ac36e13b53a64dd55091fb9e800dc on lxzhangchao:js_po_translation into 9c6248f3bac6e83f7a4418e499a3f2646a841b3a on apache:master.

Superseeded by https://github.com/apache/incubator-superset/pull/3390 that we're about to merge. Thanks for getting the ball rollin'!


Update Android splash screen.

@keybase/react-hackers, this is ready for review.

the left and right sides of the hexagon get cut off on my pixel 3a xl, intended?

@hyperobject, how does it look with those?

@adamjspooner hexagon fits now, but the keys are a little small on-device

Can you share a screenshot of what it looks like on-device in the public release, please? 🙏

Can you share a screenshot of what it looks like on-device in the public release, please? 🙏
whoops, sorry about that! here's what it looks like on my phone:

Thanks! 🙇

@hyperobject, this is ready for another look.

the details still look a little small on-device but it's better for sure!


Multiple packages

This is bound to be controversial, but...
Javascript packages have been more and more moving towards small, core packages to reduce bloat in their dependent packages. Two examples of this are grunt, and babel, who have respectively split out functionality between ['grunt', 'grunt-cli', 'grunt-contrib-sass', 'gulp-contrib-whatever','etc'] and ['babel','babel-es2015','babel-jsx','etc']. I believe we should at least consider this approach for meyda, purely because there are many different use cases for our users, and a growing one-size-fits-all package might not be the best way to serve users. This isn't a case like C/C++, where a library is included but only the linked-to code remains in the binary after compilation, when a package depends on Meyda it must (some caveats, but usually does) deploy with the entire package, including files that will never get used in the production deployment.
Use cases for meyda include:

Frontend developers who want to run meyda in the browser
Node users who want to run meyda in realtime or "surrealtime" :sparkles:
Users who want to use the CLI
People who want to contribute to Meyda

Cleary those who wish to contribute to Meyda should use the git repository, but the other usecases are not so straightforward. Frontend developers can use both npm or bower to install packages, so it's not entirely clear which files should be in the npm package. It's pretty clear that the bower package shouldn't include the node distribution files (for those who may be unfamiliar, we compile into a minified concatenated file for the web, and to unminified unconcatenated files with module loading for node), but should the node package contain the distribution files? Should we include instructions in the documentation for web developers using the npm distribution to link to the web distribution file instead of the node one, or should we point out that if they include via npm and therefore get the node distribution from require they should take care that browserify (or whatever equivalent tool) is properly requiring the nested files for their build process? Probably neither of those need to be distributed the source ES6 code or the tests, or the config files for the CI services/linter/etc, or the CLI. Users who want to use the CLI probably don't need the source code, just the distribution code, but users who want to use the node module don't necessarily need the cli.
All of this is fine, if meyda is only used infrequently on a small scale, but if meyda is ever included on a project with a very high deploy frequency, the extra cost of deploying the extraneous files could really add up. Given our new focus on offline, I don't think that scenario is too far fetched. In my opinion, we should probably discuss the above in order to make sure meyda serves the widest variety of use cases in the best way possible.

I've thought about this a bit and I agree that a separate package for the CLI is better.

So lets come up with a package structure :smile:
I'm thinking:

meyda

core meyda feature extractors

meyda-web-audio

meyda with the web audio interface

meyda-cli

meyda with the cli

Obviously each should depend on each other, and the code should be written in such a way as to make it possible to update core meyda without needing the others to do anything more than upgrade the dependency version, etc.
Also, do we rebase the CLI out of this repo before it gets merged to master? I think I can figure out how to do this :stuck_out_tongue:

(we can not do meyda-web-audio if you don't want to)

I'll close this issue as stale :)


In the search feature field selectors, indicate which fields are metadata and which are rankings

will help alleviate confusion, esp. with songbird ranking names that are just metadata fields (I don't want people thinking "oh I'm going to select all features with a pH > 5," not that that really makes much sense... it should be clear instead that "oh I'm going to select all samples with a differential for the pH field > 5").

Something that could help with exploration is to enable searching by ranks in the Selecting Features window.
So if the user wants to focus on the top 10 species and the bottom 10 species, they should be able to do this via something like (the actual querying terminology will need some work).
<10 or -10>
On another note,  the y axis in the rank plot should log-fold change, not Rank: Axis 1

Thanks @mortonjt! Let me make sure we're on the same page here.
re: New Features
First off, have you tried out the newest version of Qurro yet (in the open PR I have, which closes this issue)? This supports searching by the rank plot's y-axis values -- so not the actual ranks yet (i.e. x = 1, x = 2, x = 3, ...), but you can at least do something like log(all features with a given coefficient > y0 / all features with a given coefficient < y1). I'd like to add this sort of relative searching in the future, though (which is why the linked PR doesn't fully address #97).
Here's a screenshot of what the searching interface looks like in Qurro v0.3.0 --

In the future I'll probably add in something like Currently Selected Rank as a search option right below Feature ID, and then users can just do normal numeric searching on that (i.e. less than or equal to 10 to select the top 10 lowest features).
So I think we're both in agreement there. The other thing you've brought up is the terminology—and if anything I'm saying in the application is off/incorrect, I definitely want to fix that!
re: Terminology Stuff
Rank plot y-axis
In the earliest earliest version of "rankratioviz" :), I think the y-axis said something to the effect of "log-fold change". I ended up changing this title to make it clear that the actual y-values of each feature in the rank plot change when you select a different ranking. So, right now, this says something like Rank: ASDF where ASDF is just whatever the ID is of the currently selected ranking. (As mentioned in the first comment in this issue, I don't want to just display the ranking name by itself, since I don't want users getting confused and thinking that "oh this indicates the level of pH for each feature somehow")

This makes a bit more sense with differentials (where the ID of the ranking usually involves sample metadata somehow), since you'd get something like Rank: Temperature for the red sea dataset.
For DEICODE output (where the rankings are just feature loadings from the biplot), I used to just default to integer IDs for each PC of the loadings (so this would be something like Rank: 0, Rank: 1, etc.) I changed this a couple weeks back so that loadings are labelled Axis 1, Axis 2, etc. (similar to Emperor's naming conventions).
Since Qurro can accept arbitrary feature loadings/differentials as the input, I'm hesitant to just say "log-fold change" for every rank plot y-axis—if there's another tool that could ostensibly generate differentials in an idiosyncratic way, I'd still like to be able to render those differentials even if they don't necessarily correspond to log-fold changes.
one possible solution: instead of saying Rank: ASDF, say Loading: ASDF or Differential: ASDF depending on whatever the format of the input ranks was?

Rank plot x-axis
I guess I could make this say something like Ranked Features by ASDF, where again ASDF is the current ranking's ID. But it'd probably make sense to also update the rank plot title so it isn't super redundant.
tl;dr
Let me know what you think of this stuff, or if I'm looking at this the wrong way. Happy to adjust plans/change around wordings to make this more useful + correct.

ok - that is very cool, filtering by the coefficients should address the original issue
Regarding the rank plot y-axis, maybe we can have a note to say that this is just the default?
I understand your concern.  For the original applications, the inputs are in units of log-fold change (i.e. DEICODE / songbird / aldex2 / stray / DEseq2, ...).
That being said, there are definitely exceptions to this rule.  Both mmvec and LDA will not return log-fold units, and there are probably many others.
How about this - maybe we can change it to something like (<covariate> magnitude)?  That way it'll be somewhat flexible.  Because rank on the y-axis is a bit misleading.
In the meantime - we could also add in Before/After screenshots of how to change the title and y axis in the Vega editor.  These screenshots could even be added to the wiki to show how plots can be customized.

(sorry for taking a while to respond -- just got lunch)
Understood. It's good to know that for most of these tools, differentials/loadings are in log-fold change.
I like the suggestion of using Magnitude. Should be pretty trivial to make that change, at least for the y-axis title.
As a semirelated question: is saying "Ranking" (not "Rank") in terms of the differential/loading fields in general ok? Most of Qurro's code and docs refer to the differential/loading fields (i.e. columns in the Songbird differentials.tsv) as "Feature Rankings". Can adjust this if it's not the ideal verbiage (better now than later :)

Update: just pushed a commit to the PR (https://github.com/biocore/qurro/pull/192/commits/140a57e6f391cb9f9f7644437903d178998e5587) -- this changes the y-axis to now say e.g. Magnitude: Axis 1 or Magnitude: Temperature instead of Rank: Axis 1 or Rank: Temperature. Thanks Jamie!


horizon: support soroban InvokeHostFn xdr parsing

sub-task from https://github.com/stellar/go/issues/4600
ensure correct parsing of new soroban InvokeHostFn xdr usages

@2opremio @paulbellamy , does OperationTypeInvokeHostFunction need to emit effects for initial soroban use cases or can we leave that as no-op?

confirmed with @paulbellamy , can skip effects wire up here, it's carved out to separate effort - https://github.com/stellar/go/issues/4585

@paulbellamy @2opremio , I'm adding the Details json part for history operation of InvokeHostFunction, and looking at how to serialize the ScVals, I noticed a long conversation on canonical JSON representation of ScVal on  soroban-cli #22 , what was the outcome on that, is there a implementation in cli or elsewhere of JSON model that I could reference for ScVal's here in horizon?
Or any other preferred approach to serialize them for horizon's concern, lmk, I was naively going to just use json.Marshal(scVal)

Re: effects, not for now. There is https://github.com/stellar/go/issues/4585 to add some specifically for the token contract, but those aren't designed yet.

I would just xdr-base64 encode the ScVals. That's fine. Any JSON representation is either super verbose, or ambiguous. So not worth it. Better to send xdr scvals, and let clients parse it from there.

@sreuland I don't think we get enough value out of a stable canonical or even Horizon specific JSON representation of the ScVec of args for the invocation. I think it is okay at this point to base64 XDR encode the ScVec and have it as a single entry.

got it, will keep scope to that, thanks for responses!

I pushed out other non-critical path test coverage of create_contract_from_account and InvokeHostFunction:HostFunctionHostFnCall to follow-on ticket - #4617

bringing this back to 'in progress' to pull in the newest soroban xdr updates from 9/26 on https://github.com/stellar/stellar-xdr-next), should just be an xdr gen change.

back to in progress to update the core version and verify the integration tests still work


[BobaX-21][BobaX-23] Add scoll bar and Add to cart on each drink card

Create list of drinks
create individual Cards for drinks
put add to cart button

Add bottom "add to card " to every drink card

Gave classname to the whole drinks list and use css to make auto scollable
note: cant see the scoll because the list is too short.

General recommendation is to create branch name with informative name like simon/bobax-17-features-main-page-with-cards

 Add bottom "add to card " to every drink card

Try to consider the margin around the card. It appears to be stuck together


RangeError: Maximum call stack size exceeded when using long strings with CSS & JS

https://github.com/abap2UI5/abap2UI5/actions/runs/7238631392/job/19719633896?pr=722

long string with css, javascript lead to an error.

workaround is to split the statement into max 500 lines per statement

thank you, workaround works now!
i just did not enough split statements in the beginning, but 500 was a good hint.

I plan to fix this, sometime


Sharded Merkle Tree

Sharded Merkle Tree as explained in https://youtu.be/c0cKR78TIBg?t=1821
This will help decouple the size of the anonymity set with anonymity "nible". i.e. get 1k anonymity set (~10 layers Merkle Tree), super efficient to proof in a client side like using Metamask Snap. However, the anonymity set doesn't have to be 1000, it can be infinite by implementing an automatic sharding scheme.
Some changes could break the existing Semaphore design.


Report is not working for some queries

Issue was that some queries produce too many results to render the pdf


Prevent global namespace leak in iwlist.js

match was leaking into the global namespace from iwlist's parse_cell()

Closed so I can re-open into develop instead


Update sbt-coveralls to 1.3.13

About this PR
📦 Updates org.scoverage:sbt-coveralls from 1.3.11 to 1.3.13
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scoverage", artifactId = "sbt-coveralls" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scoverage", artifactId = "sbt-coveralls" }
}]

labels: sbt-plugin-update, early-semver-patch, semver-spec-patch, version-scheme:semver-spec, commit-count:1

coverage: 44.828%. remained the same
when pulling 8b130a016cbc0f76bb031c6ee01a592b77831870 on scala-steward:update/sbt-coveralls-1.3.13
into 20266a3209b02490ae17fae8a036e173a6130e96 on evolution-gaming:master.

Superseded by #135.


gpu_voxels: 0.8.3-4 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository gpu_voxels to 0.8.3-4:

upstream repository: https://github.com/BV-OpenSource/gpu-voxels.git
release repository: https://github.com/BV-OpenSource/gpu-voxels-release.git
distro file: melodic/distribution.yaml
bloom version: 0.10.7
previous version for package: null

Hi @BV-OpenSource
Thank you for your work in getting GPU-Voxels release ready. We've also been using and extending it in the past, it's a fantastic tool for research.
Have you liaised with FZI on getting your fixes upstreamed / synced as well as for the release? I saw your PR to upstream some features (https://github.com/fzi-forschungszentrum-informatik/gpu-voxels/pull/116), but no PR explanation or comments from upstream. It would be nice to have a canonical version to which we can also target our extensions (for optimisation-based planning) / fixes.
Many thanks,
Wolfgang

Hi @BV-OpenSource Thank you for your work in getting GPU-Voxels release ready. We've also been using and extending it in the past, it's a fantastic tool for research.
Have you liaised with FZI on getting your fixes upstreamed / synced as well as for the release? I saw your PR to upstream some features (fzi-forschungszentrum-informatik/gpu-voxels#116), but no PR explanation or comments from upstream. It would be nice to have a canonical version to which we can also target our extensions (for optimisation-based planning) / fixes.
Many thanks, Wolfgang

Hi!
Since that PR aggregate 20 commits, we thought that reading it's messages would be a good way to understand what we are adding or changing to the package.

Hi @BV-OpenSource, if you don't mind me asking, what's the goal of this package? Is there another package that is expected to be released that depends on it? If so, what is it?

Hi!
That is exactly the goal of this package. We developed Collision Avoidance and Path Planning using GPU-Voxels as map. In order to release it, we need this package released as well.

@BV-OpenSource I see the release was done from a fork.
We usually prefer releases being made from the original repo.
Did the original authors give you authorization to make a release here?
We need that, because if we approve releasing your fork and then the original authors want to make their own release you would have already taken the name.

No response to the question in a month, so closing.  If you'd like to continue with this PR, please follow-up with the last question (and hopefully the original maintainers).  Thanks for the contribution.


Suggestion: add ACL

This starter pack is great but I wonder if you could add an ACL (Access Control Layer) module to laravel such as: https://github.com/intrip/laravel-authentication-acl or https://github.com/kodeine/laravel-acl
Cheers!

Hi @rooferz thanks for your suggestion!
I am not sure but don't these packages provide the same functionality that Laravel 5.1.1 introduced?
http://laravel.com/docs/5.1/upgrade#upgrade-5.1.11
http://laravel.com/docs/5.1/authorization
If not, can you please point out the difference, as I have not worked with Laravel's ACL yet.
And if they're the same, then maybe we can team up to provide sample policies. What do you think?
Cheers

Indeed, Laravel have inclued policies system and I sure, I'd be glad to help you.
The question now is on AngularJS level which I'm a beginner on...
Do you think, it's a better idea if Front and Backend end are provided by laravel render engine than Angular only itself ?

Do you think, it's a better idea if Front and Backend end are provided by laravel render engine than Angular only itself ?

hmm would that work? (using blade)
My initial thoughts would be the following:
in our case, we can't use ACLs on the front-end without having to redefine them.. So we can probably use all the features except for blade's @can() method
That becomes a bit similar to ng-show and ng-if but maybe we can provide a directive to ease this.. but this would also require duplication of policies so I'm not really sure..
I'd love to get your feedback. Also @Bodom78 and @GrahamCampbell

IMHO, I think, in order to obtain a full separation of data provider and client, it would be logic that Angular handle ACL but with Laravel such as a RESTful service.
BUT javascript may be unsecure with sensitive data...
For the moment, I think Laravel is better to achieve this. In the end, it ends with 2 SPA and I think it more safe.

Javascript validation/ACL is strictly for the User Experience - we can never rely on it for security.
Knowing that the main ACL is going to be implemented in the backend, I think the following would be extremely useful to users of this package:

[ ] route authentication based on a closure (integrated within ui-router) - maybe if you have multiple user types: client & admin
[ ] route authentication based on JWT - #41

Let me know what you think

sounds good to me!

Closing this for now, since the direction of this starter package changed a bit..
If anyone can provide a recipe or plugin as mentioned in #149, I'd be happy to document it :smile:


Show an error message when delimiters are missing

What problem are you facing?
When the delimiters <!-- BEGIN_TF_DOCS --> and <!-- END_TF_DOCS --> are missing the action fails siltently without giving any reason as to why, which can make debugging a nightmare in a big monorepo.
How could terraform-docs help solve your problem?
It would be great if we could get an error message like Delimiters are missing in path/to/USAGE.md

Sorry for the very long delay!
This behavior has been changed as part of terraform-docs v0.13.0 specifically https://github.com/terraform-docs/terraform-docs/commit/4be22230e7bcc4d73e8e69cf57528414903188ba, in which if the surrounding comments not found in the target file, they, along side the generated content, will be appended to the target file.
This will be available in the upcoming v1.0.0 release of gh-actions, in which native terraform-docs' output to file has been incorporated into behavior of the action (https://github.com/terraform-docs/gh-actions/pull/46)

Awesome, thanks!


Unable to retrieve trigger history on workflow in standard Logic App

Describe the Bug with repro steps

Create a Standard logic app and necessary resources
Add the corresponding settings and web connections
Create a standard workflow using the workflow json
Save the logic app
Run the trigger
Open trigger history

What type of Logic App Is this happening in?
Standard (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
{
    "connectionReferences": {
        "sa02-std": {
            "api": {
                "id": "/subscriptions/*sanitized*/providers/Microsoft.Web/locations/westeurope/managedApis/azureblob"
            },
            "authentication": {
                "type": "ManagedServiceIdentity"
            },
            "connection": {
                "id": "/subscriptions/*sanitized*/resourcegroups/*sanitized*/providers/Microsoft.Web/connections/wes08osastd01"
            },
            "connectionName": "wes08osastd01"
        },
        "sbus-02-std": {
            "api": {
                "id": "/subscriptions/*sanitized*/providers/Microsoft.Web/locations/westeurope/managedApis/servicebus"
            },
            "authentication": {
                "type": "ManagedServiceIdentity"
            },
            "connection": {
                "id": "/subscriptions/*sanitized*/resourcegroups/*sanitized*/providers/Microsoft.Web/connections/we-s08-o-sbus-std-01"
            },
            "connectionName": "we-s08-o-sbus-std-01"
        }
    },
    "definition": {
        "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
        "actions": {
            "Scope": {
                "actions": {
                    "Get_blob_content": {
                        "inputs": {
                            "host": {
                                "connection": {
                                    "referenceName": "sa02-std"
                                }
                            },
                            "method": "get",
                            "path": "/v2/datasets/@{encodeURIComponent(encodeURIComponent('AccountNameFromSettings'))}/GetFileContentByPath",
                            "queries": {
                                "inferContentType": true,
                                "path": "@{json(base64ToString(triggerBody()['ContentData']))['path']}",
                                "queryParametersSingleEncoded": true
                            }
                        },
                        "type": "ApiConnection"
                    }
                },
                "runAfter": {},
                "type": "Scope"
            }
        },
        "contentVersion": "<IP_ADDRESS>",
        "outputs": {},
        "triggers": {
            "When_a_message_is_received_in_a_topic_subscription_(auto-complete)": {
                "inputs": {
                    "host": {
                        "connection": {
                            "referenceName": "sbus-02-std"
                        }
                    },
                    "method": "get",
                    "path": "/@{encodeURIComponent(encodeURIComponent(parameters('serviceBusTopicName')))}/subscriptions/@{encodeURIComponent(parameters('serviceBusSubscriptionName'))}/messages/head",
                    "queries": {
                        "subscriptionType": "Main"
                    }
                },
                "recurrence": {
                    "frequency": "Minute",
                    "interval": 3
                },
                "type": "ApiConnection"
            }
        }
    },
    "parameters": {
        "serviceBusSubscriptionName": {
            "type": "String",
            "value": "@{appsetting('SERVICEBUS_SUBSCRIPTION_NAME')}"
        },
        "serviceBusTopicName": {
            "type": "String",
            "value": "@{appsetting('SERVICEBUS_TOPIC')}"
        }
    }
}

Screenshots or Videos
Workflow:

Trigger history page (notice the loader on the right. IRL it keeps flicking, probably corresponding with the failed network requests below)

Browser
Chrome and Edge
Additional context
The app service plan is inside an App Service Environment. All connects from the ASE to storage is established through private endpoints.
AB#25218107

Can this be a permission issue? What permissions are required to be able to see this?

@Eric-B-Wu This issue is still present. Is there any knowledge how or why this issue occurs?

@Serfenia is this still happening to you? We made some fixes around this back in December for another issue that was open. I'm just combing issues and saw this one.


Module-level settings

BaseMeta should inspect the module for a base_url (and window_size, etc), and set the class's attributes if the class itself doesn't specify it.

Fixed by https://github.com/ihodes/seltest/commit/61d244ffbd23e7e9b1fc7852679c4f1ac1d3c177


Bash completion for flags

🎉 New feature
Part of https://github.com/gazebosim/gz-tools/issues/1
Used together with https://github.com/gazebosim/gz-tools/pull/87
Summary
Bash completion, installation, tests.
Test it
$ . install/share/gz/gz.completion
$ ign gazebo -
--force-version         --physics-engine        --verbose
--gui-config            --playback              --version
--help                  --record                --versions
--iterations            --record-path           -g
--levels                --record-resources      -h
--log-compress          --record-topic          -r
--log-overwrite         --render-engine         -s
--network-role          --render-engine-gui     -v
--network-secondaries   --render-engine-server  -z

Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Oops my Docker image was broken yesterday and I couldn't test things locally. Relying on CI

b34bbe9 adds bash completion for the model command and tests it in a new way as described in https://github.com/gazebosim/gz-gui/pull/392#discussion_r889390294


Add note about CloudWatch event compression

It took me some time to understand the CloudWatch event not only Base64 encoded, but either Zip compressed. Please add the note about compression to the documentation 🙇
Related PRs

aws/aws-lambda-go#242

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Looks good thanks!


[CI Problem] docker build can fail due to concurrent docker system prune

Seeing strange build failures due to missing docker images:
1.
[2022-04-28T21:00:02.003Z] Step 22/76 : RUN bash /install/ubuntu_install_java.sh
[2022-04-28T21:00:02.569Z] No such image: sha256:784a469a44d1bddcaf168d978bee1c0ee32de4a157142e77598083a72cf44501

2.
[2022-05-02T17:00:23.338Z] unknown parent image ID sha256:1e211c29ce68f4552a3e76cc8151456ea41f58740ee3c0fcb5a3cd35175fcd6d
[2022-05-02T17:00:23.338Z] ERROR: docker build failed.

Hypothesis is that periodically, the CI workers run docker system prune to remove stale CI images and ensure PRs don't run out of disk space on the executor nodes. This prune nukes the in-progress docker build containers if run at just the right time and prevents the builds from succeeding.
Proposed workaround is to only prune images older than e.g. 20m, which can be done with a flag to docker system prune.
cc @konturn @driazati

Setting an age filter on docker prune won't completely resolve the issue, as it's possible for docker builds to use older cached layers, and then to subsequently fail on the docker push operation if a prune occurs in between the cache and the push. A more sustainable solution would be to limit the lifetime of CI nodes (e.g., https://aws.amazon.com/about-aws/whats-new/2019/11/amazon-ec2-auto-scaling-supports-max-instance-lifetime/) and remove the system prune operation altogether. Thoughts?

in practice our docker containers are built with --no-cache, so only the FROM image should be older than e.g. <longest_step_time> + <fudge_factor> min. i think we could do either thing, but the prune does help to ensure we don't have a rogue CI run that allocates tons of disk

Ah I see--well in any case I just opened https://github.com/tlc-pack/ci-packer/pull/4, which adds a prune filter as proposed.

This should be fixed now


Fix code style.

Summary
This PR fixes code style of Gradle plug-ins.
Background, Problem or Goal of the patch
Task.leftShift() will have become deprecated from Gradle 3.2.
Design of the fix, or a new feature
This includes the two following changes:

using diamond operators instead of explicit type args
using Task.doLast() instead of Task.leftShift()

Related Issue, Pull Request or Code
N/A.
Wanted reviewer
@akirakw

BUILD SUCCESS. <jenkins-prb-asakusafw-sdk-103>


Ready to use animations like Animate.css with styled-components

Is there any possibility to use external library like react-animations with styled-components?
I have a lot of code with styled-components and I'd like to avoid installing another styles engine (e.g. Aprhodite).

As far as I know this is not possible with styled-components. But you can always use the keyframes helper to create the animations.
const fadeIn = keyframes`
  from {
    opacity: 0;
  }

  to {
    opacity: 1;
  }
`;

const Comp = styled.div`
  animation: ${fadeIn} 2s linear;
`

Thanks for an answer.
That's the point that I would like to use prepared animations because it's faster and powerful. I have used keyframes already but now I'd like to have more complex animations.

Mhh, I don't know if it's worth adding to styled-components just to support a single library.

You can use react-animations perfectly fine with styled-components:
import styled, { keyframes } from 'styled-components';
import { fadeIn } from 'react-animations';

const fader = keyframes`${fadeIn}`;

const Title = styled.h1`
  font-size: 1.5em;
  text-align: center;
  color: palevioletred;
  animation: 1s ${fader} alternate infinite;
`;

Live demo: https://www.webpackbin.com/bins/-KktjocigcjvHnP_lPJp

Submitted a PR to react-animations to add an example: https://github.com/FormidableLabs/react-animations/pull/13

React-animations is no longer updated.

react-spring works great with styled components and supports hooks!
On Wed, May 8, 2019 at 7:51 PM chrischen<EMAIL_ADDRESS>wrote:

React-animations is no longer updated.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/823#issuecomment-490702585,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAELFVSUCWOWDSXC2VRNEBLPUNYQBANCNFSM4DMSX7RA
.


Fix crash count not being read

Blame https://github.com/GTNewHorizons/BetterCrashes/pull/12

It was using reflection to access mixin added fields 🤦♂🤮

I moved the mixins accessor interfaces under mixins\interfaces package, if @miozune is ok with it we can merge this

Yeah I didn't know about interface trick at that time 😉


Reproductions sktime030updates

Been fairly out of it recently with sktime and this, but when going back to run some experiments today, I thought I'd pull sktime 0.3.0 and update sktime-dl to that standard
In short -

a couple of imports updated, e.g. tsctasks and strategy
references to check_X_y removed (mloning to check, when I looked at a couple of classifiers in base sktime these had been removed since I last looked)
updated the requirements in setup.py to sktime 0.3.0 as a dependency (from 0.2.0)

Looks good, thanks for keeping it up-to-date! We could add our new input check functions from here.


Hospitality skill needs to be updated

Remove local build of google adapter and link to the most up to date and stable google adapter NuGet package (we shouldn't need an extension as my changes have been implemented in the adapter itself)
Remove all provider conditional logic in the code and move them to .lg (I have validated the possibility of this but it gets a bit trickier with google card responses)
Add Alexa adapter
Add documentation on best practices when using the VA with the adapters

This issue should be about hospitality assistant?


Add encryption key to ID Pass Lite reader

Before starting this, discuss with @jeremi

[ ] load a pkcs12
[ ] Add customizable encryption key

The AndroidKeyStore is the only option for Android to hold secret keys. There are surrounding issues with it as a long term solution, as discussed in stackoverflow.

The AndroidKeyStore is the only option for Android to hold secret keys. There are surrounding issues with it as a long term solution, as discussed in stackoverflow.


Add extension point to filter workflow pending tasks

Problem
The current implementation does not have a method to filter or process the list of pending tasks. The existing rest API provides all the pending tasks if the requested user has required workflow listing scopes. There is no option other than using and external BPS engine if someone needs to do some simple processing on the list.
Solution
Provide an extension point to do some filtering/processing on the list of pending tasks before providing it to the user.
Affected Component
APIM
Version
4.2.0
Implementation
No response
Related Issues
No response
Suggested Labels
No response

Add an interface to add a filter to the listing tasks. Users can create an OSGI service and register the implementation as an OSGI service using this interface.
package org.wso2.carbon.apimgt.api.model;

public interface WorkflowTaskService {

    Workflow[] getFilteredPendingTasks(Workflow[] pendingWorkflowArray, String username, String organization);

}

PR https://github.com/wso2/carbon-apimgt/pull/11724

Unit test https://github.com/wso2/carbon-apimgt/pull/11724/commits/9fa1417bf4f88ee200dd977dbc5c9f4a0cb22422


ModuleNotFoundError 'diff_gaussian_rasterization'

Dear authors:
I tried to implement the code on a docker container based on Windows 11 with Ubuntu 20.06.04 LTS.
All three steps in the Setup section have been successfully deployed and compiled. However, when I tried to run "python3 combined_training_script.py" in the docker, the error "ModuleNotFoundError: No module named 'diff_gaussian_rasterization'"  and "ModuleNotFoundError: No module named 'simple_knn'" keeps recurring. I really wonder whether you have encountered this kind of problem and earnestly hope you can provide some relevant help and suggestions.
Thank you for your time.

hi thanks for trying our work.
This is our problem, we didn't put diff_gaussian_rasterization and simple_knn under the submodules folder, let me add them.
They are cuda code from orioginal 3dgs.
Thanks!

https://github.com/horizon-research/Fov-3DGS/tree/main/fov3dgs/submodules
They are here now. use pip install <their_folder_path> to install them


Remove unsupported font tags

The code is currently cluttered with lots of font tags like
@@external_id@@:

Since these aren't supported by html2ps, we might as well remove them?

👍 I added it before I learned that html2ps didn't support colors, but basically forgot to remove them


Debounce language suggestion

using requestIdleCallback might've been a bad idea for this, let's properly debounce it so it only runs when the user finishes typing
later on I'll try tuning the neural network directly and hopefully we can improve on the suggestions then

having it always clear might be annoying though, let me do some more testing...
edit: yeah it's bad

okay so I figure what you were aiming for was to trigger the detection after a small delay from typing, but now what this means is that it also clears after a small delay, and that is kind of crummy too? If so then we'd need to debounce only if a recommendation isn't made yet. Think that's worth bothering?

up to you. this doesn't really bother me that hard

Closing for now


How can I display no result with algolia custom renderer ?

https://www.algolia.com/doc/ui-libraries/autocomplete/guides/creating-a-renderer

Hi, by default the Autocomplete panel does not open when there are no results. You can change this behavior by setting the shouldPanelOpen: () => true in your configuration. Then you'll need to render your message in your collection when there are no items. You can find a working example in this sandbox: https://codesandbox.io/s/practical-clarke-h2xmur?file=/src/Autocomplete.tsx.

Thanks I will take  a look.
On Thu, Feb 9, 2023 at 11:01 AM Dhaya @.***> wrote:

Hi, by default the Autocomplete panel does not open when there are no
results. You can change this behavior by setting the shouldPanelOpen: ()
=> true in your configuration. Then you'll need to render your message in
your collection when there are no items. You can find a working example in
this sandbox:
https://codesandbox.io/s/practical-clarke-h2xmur?file=/src/Autocomplete.tsx
.
—
Reply to this email directly, view it on GitHub
https://github.com/algolia/autocomplete/issues/1083#issuecomment-1423923279,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQSBLZJBWWNFVWLET2MW4HDWWS56XANCNFSM6AAAAAAUTRPS5Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks, it is working.
On Thu, Feb 9, 2023 at 11:50 AM Ayomiku Olatunji @.***>
wrote:

Thanks I will take  a look.
On Thu, Feb 9, 2023 at 11:01 AM Dhaya @.***> wrote:

Hi, by default the Autocomplete panel does not open when there are no
results. You can change this behavior by setting the shouldPanelOpen: ()
=> true in your configuration. Then you'll need to render your message
in your collection when there are no items. You can find a working example
in this sandbox:
https://codesandbox.io/s/practical-clarke-h2xmur?file=/src/Autocomplete.tsx
.
—
Reply to this email directly, view it on GitHub
https://github.com/algolia/autocomplete/issues/1083#issuecomment-1423923279,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQSBLZJBWWNFVWLET2MW4HDWWS56XANCNFSM6AAAAAAUTRPS5Y
.
You are receiving this because you authored the thread.Message ID:
@.***>


[nmstate-1.3] Bundle patches for openshift SR-IOV use case

Besides patches required to fix openshift SR-IOV use case,
also included important patch from 1.4 branch:

66269212 nm: Retry on device deletion failure
93d701b2 iface: Fix error when assigning IP to port of absent controller
b94f3422 nm: Fix time.sleep() in _import_current_device()

Incorrect branch. Closing.


Add 418 "I'm a teapot" HTTP status

Though this HTTP status is just a joke, it is supported by numerous HTTP implementations, including (but not limited to):

Python
POCO
Golang
Rust actix-web crate

So, I think it's also a good idea to support this HTTP status code in Beast.
Also, C++ is occasionally used for embedded programming, such as smart teapots, and I think it also justifies adding this status code :) :)

We have recently updated the status code list to conform with the boring IANA registry (https://github.com/boostorg/beast/pull/2811/commits/180d9977011203fe53128441638c64528f1c67f8). So, I'm not sure if it's a good idea to break it.

I'm not sure if it's a good idea to break it.

Well, I think that having more status codes is better than having less of them. Also, status code 418 is reserved, so it's quite unlikely that it will receive any other meaning:

Therefore, the 418 status code is reserved in the IANA HTTP Status Code Registry. This indicates that the status code cannot be assigned to other applications currently.

[RFC2324] was an April 1 RFC that lampooned the various ways HTTP was abused; one such abuse was the definition of an application-specific 418 status code, which has been deployed as a joke often enough for the code to be unusable for any future use.
Therefore, the 418 status code is reserved in the IANA HTTP Status Code Registry. This indicates that the status code cannot be assigned to other applications currently. If future circumstances require its use (e.g., exhaustion of 4NN status codes), it can be re-assigned to another use.

I guess we can add it then :)

Well, I think that having more status codes is better than having less of them

Users can use the corresponding integral value for the status codes that are not in the list. The problem with supporting non-standard status codes is that they overlap, and we can't add all of them.

The problem with supporting non-standard status codes is that they overlap, and we can't add all of them.

Well, given that this code is reserved to prevent it being reused, the overlap will be highly unlikely.

I think that having more status codes is better than having less of them.

Interesting, because I think the exact opposite. Fewer choices means less confusion, especially if the extra choices add no value.

Well, given that this code is reserved to prevent it from being reused, the chance of overlap is highly unlikely.

I didn't mean 418; I was referring to the reason why we don't add non-standard status codes in general, like the ones Nginx uses, for example.


Docker Desktop - 2 minutes is not enough time to wait for Kubernetes cluster to start

While #134 fixed the issue where ctlctl stopped waiting for the cluster too early, I'm finding that 2 minutes is sometimes still not long enough. The connection on my Windows VM reports 140 Mbps download speeds (via fast.com), but still frequently takes closer to 4-5 minutes than the 2 minutes ctlptl will wait (maybe the bottleneck isn't internet, but we both have 32 GB of RAM and at least 8 reasonably fast CPU cores). I can of course just run the command a second time and it will work (because the cluster is usually up by then), but I've been surprised by how long it takes Docker Desktop to setup Kubernetes, both on my Windows test VM and my co-worker's Mac.
# ctlptl apply -f ./cluster.yaml
Applied new Docker Desktop settings. Waiting 2m for Docker Desktop to restart...
Switched to context "docker-desktop".
Waiting 2m for Kubernetes cluster "docker-desktop" to start...
timed out waiting for cluster to start: context deadline exceeded

I just timed it on Windows, and it took about 3m 20s to start the cluster.

ahhhhh ya I suspect the bottleneck is how fast it can download the kubernetes images
i don't want to make it TOO long, because I have definitely seen situations where docker-desktop's kubernetes got wedged and would never start up, and would need to be restarted.

should be fixed in v0.5.7! let me know if the timeouts are still causing problems, we can do as many bugfix releases as we need to get it right!


Strict mode changing observed observable values outside actions is not allowed message._store.validated

I think I have an issue with mobx-react. It's a particular case :
It was something that worked before with old mobx version ..
version used :
"react": "^16.9.0",
"mobx": "^5.13.0",
"mobx-react": "^6.1.3",
"mobx-react-devtools": "^6.1.1",

I'm trying to set a message in a mobx action with enforceAction always.
this.dialog.current.setMessage(<div>
                    <Typography key={1} gutterBottom component='span'>
                    Your session is about to expire.
                  </Typography>
                    <Typography key={2} gutterBottom component='span'>
                    You will be automatically signed out in : {expirationDate - currentTimeInS}s
                  </Typography>
                        <Typography key={3} gutterBottom component='div'>
                        Do you want to stay logged in ?
                      </Typography>
                </div>);

when my component is rendered with the message. It enters :

validateChildKeys(arguments[i], type);
with arguments[2] my message as :

 // This element was passed in a valid location.
        if (node._store) {
          node._store.validated = true;
        }

node is my mobx "message" ..
It tries to set "validated" value out of an action directly from react.development.js ...
Can you help ?

Would you be able to create a simple reproduction with eg. CodeSandbox? Seems like some pieces are missing here so we need to see a whole picture.

From the stack trace, it seems that you are trying to update some state inside your render, which is forbidden by both React itself and by MobX :). Render should be pure. To update state, do it from one of the life cycle hooks of React, for example useEffect / componentDidUpdate

Looks like we have misconfigured auto close bot, this tag shouldn't keep it open. I will fix that.
@jkeruzec Sorry, but without reproduction, we are unable to proceed further.


chore(deps): [Snyk] Security upgrade cryptography from 42.0.0 to 42.0.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

server/backend/requirements.txt

Vulnerabilities that will be fixed
By pinning:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

37/1000  Why? Confidentiality impact: None, Integrity impact: None, Availability impact: Low, Scope: Unchanged, Exploit Maturity: No data, User Interaction (UI): Required, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Local, EPSS: 0.01055, Social Trends: No, Days since published: 1, Reachable: No, Transitive dependency: No, Is Malicious: No, Business Criticality: High, Provider Urgency: Low, Package Popularity Score: 99, Impact: 2.35, Likelihood: 1.55, Score Version: V5
NULL Pointer Dereference SNYK-PYTHON-CRYPTOGRAPHY-6210214
cryptography:  42.0.0 -> 42.0.2
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 NULL Pointer Dereference

this packages is only used by the router /jwks.json, verified after deployment in dev api swagger, works fine.


URL should be in English

URL should be in English
Otherwise it will not work

@adityauser, That url is not the one which should be cloned. Username there should be replaced with each users' username. I think having the right translation there makes sense.


RestrictSUIDSGID not supported in Debian buster

The systemd unit file contains RestrictSUIDSGID=true. The RestrictSUIDSGID feature came with systemd 242, Debian buster still uses systemd 241 which leads to the following warnings:
Dec 17 09:00:07 hostnamev systemd[1]: /etc/systemd/system/blackbox_exporter.service:24: Unknown lvalue 'RestrictSUIDSGID' in section 'Service', ignoring

Discussion in https://github.com/cloudalchemy/ansible-prometheus/issues/324


Iterate on this grade

https://website.grader.com/tests/davidvargas.me

Mostly covered by other tasks


Improve manifest loading

Use the same parsing rules for [validator_keys] that we do for [validators] to ensure consistency. @scottschurr, @ximinez

Current coverage is 61.99%

Merging #1510 into develop will not affect coverage as of 423dea6

@@            develop   #1510   diff @@
=======================================
  Files           888     888
  Stmts         62871   62884    +13
  Branches          0       0
  Methods           0       0
=======================================
+ Hit           38979   38983     +4
  Partial           0       0
- Missed        23892   23901     +9

Review entire Coverage Diff as of 423dea6

Powered by Codecov. Updated on successful CI builds.

I'm concerned about the duplication I commented on above, and that the new lines are not covered, but the changes look good, and it's not like overall coverage decreased, so :+1: :shipit: .

Looks pretty good.  My only sticking point is the place I suspect we should return false.  Once that's tended to (possibly by educating me), then it'll be thumbs up from me.

:+1:  Looks good!

(squashed)

Merged as e9e0277b7c7579cc8b2a6f8b848d49e5839e3fac


[FEATURE]Loading a ready-made mapping file during the template creation

Is your feature request related to a problem?
During the creation of an index template I need to import an existing mapping file to use as the schema for this template.
What solution would you like?
The purpose of this additional functionality is to allow the creation of a schema based (mapping) index (data-stream) using existing mapping files that are present in the plugin as part of the catalog deployment of pre-build schema used in the opensearch - Observability  / Security Plugins.
What we need:
Adding a load file option button for loading a ready made mapping file from the file system.

if the file contains composed templates (which do not already exist in the cluster) - the prompt will ask the user if he would like to load the components templates

For example the Logs mapping file that has inner composition of component templates

Http component template
Cloud component template
Communication component template

All these inner compositions relationships are explained and detailed in the catalog config for in the Observability schema
Functionality:

Loading mapping template from file
if contains inner component templates

verify if they already exist
allow selecting them from file location so they can be created

Do you have any additional context?

https://github.com/opensearch-project/opensearch-catalog/tree/main/docs/schema
https://github.com/opensearch-project/opensearch-catalog/tree/main/schema/observability
https://github.com/opensearch-project/opensearch-catalog/blob/main/schema/observability/logs/logs.mapping

@YANG-DB Can't we achieve this by associating the component templates to a template? We can associate component templates to a template on the UI since 2.7.

Actually the use case is that we want to generate the entire scope of both the index mapping including the component mapping that are referenced in that index mapping.
We want this to be automated and not manually adding each component template
See the next logs.mapping example:
 },
  "composed_of": [
    "http_template",
    "communication_template"
  ],

This would prompt the dialog to load the component templates from the file system (folder?)
And once the user select the folder all the depended component templates would be generated and the whole index template would also be generated without the user manually creating each components by himself

I would like to clarify some of the points in this proposal, which may differ from the current create template workflow.
When you mentioned importing a mapping file to a template, does it:
a) attach/associate component templates (containing mappings) to the template the user is creating
or
b) import the mapping structures into the template the user is creating without attaching/associating component templates?


feature request support for customize metric

I think it will be great if t2t can add support for customize metrics, like the way we use customize date generators and models. Currently seems the only way is to directly modify the metrics.py.

You can also override T2TModel.estimator_spec_eval and modify the eval metrics returned.


Add calendar plugin

Adds https://github.com/dereuromark/cakephp-calendar
See

https://sandbox.dereuromark.de/sandbox/calendar for calendar example
https://github.com/dereuromark/cakephp-calendar/tree/master/docs#icalendar-files-icalics for ics generating

Plugin::load('Calendar'); should be removed from readme. It will throw warning in 3.6 :slightly_smiling_face:.


place text off page without creating new page

hi guys,
i really struggle by adding text to my page without creating a second page because the y position of my text to place is off the current page.
documentation tells me nothing about not auto creating new pages... so what can i do?

any advice @devongovett ? :-)

Yea, I'm having the same problem. Clipping doesn't work for texts. When texts are beyond certain coordinates they appear on a new page and drawing (lines, circles) on the current page seams to stop.
Drawing graphics without texts is no problem.


Outputcompilers

Does output like this:
module-whatis "
Compiled with gcc/4.8.2 under PrgEnv-gnu/5.2.82
Compiled with gcc/4.9.2 under PrgEnv-gnu/5.2.82
Compiled with intel/<IP_ADDRESS> under PrgEnv-intel/5.2.82
Compiled for sandybridge
Compiled for ivybridge
Compiled for haswell
"
module-whatis "
Compiled with python/2.6.9
Compiled with python/2.7.10
"
module-whatis "Szip compression software, providing lossless compression of scientific data,
has been provided with HDF software products as of HDF5 Release 1.6.0 and HDF4
Release 2.0.
Szip is an implementation of the extended-Rice lossless compression algorithm.
The Consultative Committee on Space Data Systems (CCSDS) has adopted the
extended-Rice algorithm for international standards for space
applications. Szip is reported to provide fast and effective
compression, specifically for the EOS data generated by the NASA Earth
Observatory System (EOS). It was originally developed at University of New
Mexico (UNM) and integrated with HDF4 by UNM researchers and developers.
For further information see https://support.hdfgroup.org/doc_resource/SZIP/
Compiled with gcc/4.8.5
Compiled with gcc/5.4.0
Compiled with gcc/6.3.0
Compiled with intel/16.0.4
Compiled with intel/17.0.4
"

Conflicts


URLs in release notes point to <IP_ADDRESS>

Just a quick heads up:
Release notes for 0.45 include urls that point to localhost.
https://github.com/simonw/datasette/releases/tag/0.45

Thanks, I've fixed that now. It only affected the GitHub release notes - the ones at https://docs.datasette.io/en/stable/changelog.html#v0-45 had the correct links.


remove github.com/opencontainers/runc dependency

relates to https://github.com/moby/sys/pull/134
relates to https://github.com/opencontainers/runc/issues/3998
relates to https://github.com/opencontainers/runc/pull/4017

remove github.com/opencontainers/runc dependency
This migrates uses of github.com/opencontainers/runc/libcontainer/user to the new github.com/moby/sys/user module, which was extracted from runc at commit opencontainers/runc@a3a0ec48c464fe6458d2ba067f6707c027e5384e.
This is the initial release of the module, which is a straight copy, but some changes may be made in the next release (such as fixing camel-casing in some fields and functions (Uid -> UID).

Still draft?

I think it's fine to merge, but also considering if we'd want those nits to be addressed before doing so; any preferences for "this PR" or "follow-up"? https://github.com/opencontainers/runc/pull/4017#issuecomment-1729278565

Thanks! I'll also have a look at fixing the CameCase nits in moby/sys (for a v0.2.0, or whatever version it will be); for this one I wanted it to be a clean "move"

I think it's fine to merge, but also considering if we'd want those nits to be addressed before doing so; any preferences for "this PR" or "follow-up"?

Not a big deal to just get this in as is then if a later version changes the casing, update then.

ok, rebased;  let me move it out of draft