neovim and coc-python: no python interpreter

Describe the bug

A clear and concise description of what the bug is.

The neovim with vimPlugins."coc-python" in either configure.packages.myVimPackages.start or plug.plugins doesn't bring python into scope, resulting in

"No Python interpreter" error message
A popup repeatedly suggesting to download pylint

To Reproduce
Steps to reproduce the behavior:

Either home-manager with neovim.plugins = [coc-nvim coc-python]
Or shell.nix with

  with import <nixpkgs> {};

  let
      neovimPythonPackages = p: with p; [
                  jedi
                  flake8
                  black
                  pylint
                 ];
      neovim = pkgs.neovim.override {
                          extraPython3Packages = neovimPythonPackages;
                          withPython3 = true;
                          withNodeJs = true;
                          configure = {
                              customRC = builtins.readFile ~/.config/nixpkgs/nvim-init-template.vim;
                              plug.plugins = with pkgs.vimPlugins;  [
                                  coc-nvim
                                  coc-python
                              ];
                          };
                     };
  in
  mkShell {
      buildInputs = [neovim];
  }

Execute nix-shell in the directory with shell.nix (or home-manager switch)
Visit any python file, nvim example.py
Check if python is in PATH: :! which python
Check if e.g. node is in PATH: :! which node

Expected behavior

A clear and concise description of what you expected to happen.

Editor opens normally
Possibly, a path to python (not sure if it should be available with :!, but regardless)
Possibly, a path to node

Observed behaviour

If applicable, add screenshots to help explain your problem.

A popup suggesting to download pylint. An error reporting "No Python interpreter"
"no python in $PATH"
A path to node

Additional context
Add any other context about the problem here.

https://github.com/NixOS/nixpkgs/issues/64560

Notify maintainers

@vcunat (found in vim-plugins/overrides.nix)
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.4.62, NixOS, 20.09pre242769.61525137fd1 (Nightingale)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.7`
 - channels(serge): `"home-manager, nixpkgs-21.03pre243200.c413f10dafa"`
 - channels(root): `"nixos-20.09pre242769.61525137fd1"`
 - nixpkgs: `/home/serge/.nix-defexpr/channels/nixpkgs`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: [pkgs.vimPlugins.coc-python, pkgs.neovim]
# a list of nixos modules affected by the problem
module:

Upd: found that python executable is exposed to nvim, as it is supposed to, through g:python3_host_prog and not PATH:
:echo g:python3_host_prog
/nix/store/gsb3ahrqpd99i4frbrsdb2br3chi88gl-neovim-0.4.4/bin/nvim-python3

Apparently the solution would be to allow to populate the coc-settings.json with python.linting.pylintPath, etc.
I temporarily resorted to the following hack and it kind of works:
# home.nix
  xdg.configFile."nvim/coc-settings.json".text = ''
    {
      "python.linting.pylintPath": "nix-shell -p 'python3.withPackages(ps: [ps.pylint])' --run 'python -m pylint'"
    }
  '';

The UX I'd expect is that adding coc-python to neovim plugins would automatically include pylint, black, isort, etc in the closure and that neovim would be exposed to their executables. I could work on that some time later, but I wouldn't know how to approach the problem. I find nixpkgs somewhat overwhelming

I'm just a NixOS newbie, so I might be doing something very wrong here, but for black and flake8 the following works for me:
# configuration.nix

home-manager = {
  # ..
  programs = {
    neovim = {
      extraPackages = with pkgs; [
        (python3.withPackages (ps: with ps; [
           black
            flake8
        ]))
      ];

This seems to install black and flake8 and expose them in the PATH to the Neovim process, so you would not need your xdg.configFile hack.
I still have not managed to get jedi working, though: Python complains about module jedi not being found, even when I add it to the extraPython3Packages option.

@carletes, modules from extraPython3Packages ends up available to nvim-python3. Try to make sure it's the one you invoke (e.g., as nvim-python3 -m jedi).

@carletes for myself, I hotfixed jedi by explicitly providing path to its site-packages: https://github.com/newkozlukov/dotfiles/blob/7058ff268c6d802621135831b5271ecc781a7c2c/home/program/neovim/coc.nix#L5 (here pylinters comes from https://github.com/newkozlukov/dotfiles/blob/7058ff268c6d802621135831b5271ecc781a7c2c/overlays/pylinters.nix#L33 but probably most of this terrible messy hack is unnecessary; I just don't have time to clean it up)
I didn't check @t184256's solution now, but when I just opened this issue, extraPython3Packages didn't work (at least for me, at least with jedi)
Also, didn't know about nvim-python3, will look into where's it constructed and how - later
Thanks

Try to make sure it's the one you invoke (e.g., as nvim-python3 -m jedi).

@t184256: Thanks for the hint! Yes, I did a /nix/store/<blahblah>/nvim-python3 -m jedi in another terminal and it worked (as in nvim-python3 as able to locate the jedi module).
All I had to do then was to set python.pythonPath to pnvim-python3 in my coc-settings.json and then everything works.
For black and flake8 I made them accessible to nvim's PATH by adding them to extraPackages`, and that seems to do the trick.
To sum up: The following configuration (I use home-manager driven from /etc/nixos/configuration.nix) works for me:
# configuration.nix
{
  home-manager = {
    programs = {
      neovim = {
        enable =true;
        withPython3 = true;
        plugins = with pkgs.vimPlugins; [
          coc-nvim
          coc-python
        ];
        extraPackages = with pkgs; [
          (python3.withPackages (ps: with ps; [
            black
            flake8
          ]))
        ];
        extraPython3Packages = (ps: with ps; [
          jedi
        ]);
      };
    };
  };
  xdg.configFile."nvim/coc-settings.json".text = builtins.readFile ./my-coc-settings.json;
}

And here are the relevant bits of my-coc-settings.json:
{
  "python.formatting.provider": "black",
  "python.jediEnabled": true,
  "python.linting.flake8Enabled": true,
  "python.pythonPath": "nvim-python3"
}

works for me  let g:python3_host_prog='/usr/bin/python3'  (add to your vimrc)

@HT-Moh I'm almost sure that just withPython3 started working since some commit a rather long time ago - the issue can be probably closed already
Also, I recently switched to neovim-nightly with nvim-lspconfig instead of coc and I feel happy

I know this is outdated but a search dropped me here and I wanted to document the fix that worked for me for those in the future. (NixOS newbie as well)
Turns out in 2022 coc-python is archived and you should be using coc-pyright. I didn't have to play with extraPython3Packages or extraPackages at all. Once I replaced coc-python with coc-pyright all was good.


Update go-control-plane

Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>

you need to make your vendor PR first

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fd0243346519dbbe924b65ab61026308ad86ff7d
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fd0243346519dbbe924b65ab61026308ad86ff7d
link
/test istio-unit-tests

prow/istio-presubmit.sh
fd0243346519dbbe924b65ab61026308ad86ff7d
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pilot/pkg/proxy/envoy/v2/placeholder.go:37:2:error: ineffectual assignment to server (ineffassign)

This is dead code: see build !ignore flag above.
On Mon, Feb 26, 2018 at 4:08 PM Laurent Demailly<EMAIL_ADDRESS>wrote:

@ldemailly commented on this pull request.
In pilot/pkg/proxy/envoy/v2/placeholder.go
https://github.com/istio/istio/pull/3792#discussion_r170778091:

@@ -40,6 +40,7 @@ func RunXDS(ctx context.Context, config cache.Cache, port uint) {
if err != nil {
log.Errorf("failed to listen")
}

_ = server

??
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/3792#pullrequestreview-99516647, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJGIxuv6rsw0mYMQMrGc6ifSy9x4LGvCks5tY0eKgaJpZM4SUH0M
.

merged the vendor so please switch your vendor to head
( 1e7ee397956188785387ebce3da0e5dc1941ef5d )
before we merge this one
optional, another round with master in the toml (but that one can wait next update)

/retest

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fd0243346519dbbe924b65ab61026308ad86ff7d
link
/test istio-unit-tests

prow/istio-presubmit.sh
bde644d41000f5a439319b09268d146ae05d8544
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

FAIL	istio.io/istio/mixer/adapter/solarwinds/internal/appoptics	0.578s

Nothing to do with this PR. Flake?

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
bde644d41000f5a439319b09268d146ae05d8544
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-suite-rbac-auth
/lgtm

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
bde644d41000f5a439319b09268d146ae05d8544
link
/test istio-presubmit

prow/e2e-suite-rbac-auth.sh
098ac38a86102df9041efc1af9f6179fc08696a1
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

probably not because of you but...
I0227 00:40:47.469] istio-ca-9fd9f4869-tlsb8               0/1       ImagePullBackOff   0          4m
seems like something is broken - @costinm  maybe your pr ?

never mind the failure is most likely #3645


MissingAnalyzerReference warning with alpha 9.

I'm getting the following warning with beta 9:
Warning MissingAnalyzerReference Analyzer assembly 'D:\projects\Perspex\packages\StyleCop.Analyzers.1.0.0-beta009\analyzers\dotnet\cs\Newtonsoft.Json.dll' depends on 'mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e' but it was not found.

Duplicate of #1345, which I typed out yesterday but forgot to hit submit. :expressionless:


import using /deep/ keyword error!!

I use bootstrap scoply
like this.
<style scoped lang="scss">
    .bootstrapWrapper /deep/ {
      @import "node_modules/bootstrap/scss/bootstrap.scss";
    }

</style>

but when version 4.4 updated, It is not working.
error message is
.was-validated #{if(&, "&", "")}:#{$state},
so I use 4.3.2 version

You can use ::v-deep instead of /deep/ which is deprecated and do not work with dart-sass (and probably not anymore with node-sass).

/deep/ is indeed deprecated, thanks for chiming in here @GauthierPLM


Comment on: EntitySelection

EntitySelectionClass.md

Enter your comment here:
Link to toCollection is wrong.
It's set to https://developer.4d.com/docs/en/API/EntitySelectionClass.html#tocollection
It should be https://developer.4d.com/docs/en/API/EntitySelectionClass.html#tocollection-

thanks, we have fixed the page


Tweaks

Just tightening up code + making event + method names a bit more obvious.

Throws an error if editor / buffer is of unexpected type, making issues such as #62 #58 etc. easier to diagnose

When partner is typing, the SharePane they're typing in has a little pencil icon over it.
Tab names are synced over so people know what they're working on

Obv needs rebase


executing rvm within normal bash conditions

I'm trying to execute a command in an rvm environment.  To do so, I first need to execute rvm env --path -- ruby-version to yield the file with environment variables that should be sourced.  The problem is that this command always returns the global environment, instead of the local environment based on the cwd.
I have verified that the cwd is correct, as well as verifying the output via commandline.
Script:
#!/usr/bin/env bash

ENV_RVM=`rvm env --path --ruby-version`
echo "RVM at $ENV_RVM from `pwd`"
source $ENV_RVM

#rails runner $1

Command line results:
RVM at /Users/kross/.rvm/environments/ruby-2.2.2@af_core from /Users/kross/projects/af_core/spec/dummy
spawn.sync results:
RVM at /Users/kross/.rvm/environments/ruby-2.2.2 from /Users/kross/projects/af_core/spec/dummy
Any thoughts on options I am missing to get RVM to behave as it does on command line?

Found it!
In my bash script, I had to add -l:
#!/usr/bin/env bash -l

ENV_RVM=`rvm env --path --ruby-version`
echo "RVM at $ENV_RVM from `pwd`"


Install Automated CRUD for Single Database Tables

will need admin nav menu option 'Database' which drills down to show all (view-enabled) tables.
Tables should not need a mapper (TableMapper child) defined. Without a mapper, the default will be (list) view only; no insert, update, delete. A mapper can be defined in order to change the defaults ie no view (disables entirely), allow insert/update/delete.

Currently set to allow viewing of all db tables. No CUD.
I was going to include more control and work on the CUD, but holding off. This was removed from settings.php
/** automated database table crud allowances      *       *  if view is allowed on all tables by default, tables that are not to be enabled must be explicitly set false in the tableCrudSettings key, ie 'tableName' => false. insert/update/delete permissions can then be defined explicitly as necessary, ie 'tableName' => ['insert', 'update', 'delete']      *       * if view is not allowed by default, tables that are to be enabled must be explicitly given crud permissions in the tableCrudSettings key, ie 'tableName' => ['view'], or 'tableName' => ['insert', 'update', 'delete']      */     'databaseTables' => [         'allowViewByDefault' => true,         'tableCrudSettings' => [             'roles' => false,             'event_types' => ['insert', 'update', 'delete'],             ],     ],
And this was removed from AdminNavigation:
/** table view is allowed unless settings[table] is set false */     private function isDatabaseTableViewAllowed(string $table) : bool      {         return !(isset($this->container->settings['databaseTables'][$table]) && $this->container->settings['databaseTables'][$table] === false);         return isset($this->container->settings['databaseTables'][$table]) && is_array($this->container->settings['databaseTables'][$table]) && in_array('view',$this->container->settings['databaseTables'][$table]);     }

included with latest update


fix: Use g.user for getting the user_id for async queries

SUMMARY
During some tests in a production-like environment, the user_id in the job_metadata was not being set properly. This causes any charts that reference g.user to fail since we are relying on the user_id to set g.user in the Celery workers.
TEST PLAN
I cannot reproduce the broken behavior locally. However, I did test that this change will correctly set the user_id value.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

cc @robdiciuccio

For public users with no user ID, we may need to tweak the token invalidation logic, depending on the session logout handling (needs testing).

We'll also need to either:

Make all the chart/dashboard query logic behave when g.user is not set (today, it assumes it will always be there), or...
Set g.user to a mock user in Celery tasks when there is no user_id present and ensure all code paths can respect this mock user object


Lecture 3 Duplicate Slide 15+16

Seems that there are two of the same slide, at least in the copy I have downloaded today.

Thanks. I'd meant to hide the answer in the first one so that would have tripped me up. 3 points


ci: added helm-test chart workflow (TRG 5.07)

Description

Adds the helm test workflow according to TRG 5.07. To clarify, if helm upgrade between charts is applicable to us.

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

Hey @almadigabor, could you do a review and tell me why it fails due to kind version 1.27.3?

@tomaszbarwicki, linting progresses but the dockerfile can't be read in this run.
ERROR: failed to solve: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount2079917770/Dockerfile: no such file or directory
Error: buildx failed with: ERROR: failed to solve: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount2079917770/Dockerfile: no such file or directory

Do you got an idea why?

@tomaszbarwicki, linting progresses but the dockerfile can't be read in this run.
ERROR: failed to solve: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount2079917770/Dockerfile: no such file or directory
Error: buildx failed with: ERROR: failed to solve: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount2079917770/Dockerfile: no such file or directory

Do you got an idea why?

The current issue happens because the action does not point to the Dockerfile's path using the context variable. You have your Dockerfiles in the frontend and backend directory. Based on your setup you should build both by duplicating the build step and create a frontend and backend image as well. Then in the end make sure to set the proper registry, app name and tag in the chart install step. You can find a good example here building frontend and backend images and then using them with the chart at the end.
https://github.com/eclipse-tractusx/puris/pull/145/files#diff-33f5fdd3507841f6bb8f87595ecc5669a0397021de950482ca4e8b68c25cfdb6R57

Hey @almadigabor, needed some free space to have a look into it again. It now works. Thanks for your support. Could you please do the final review and accept it?

Hey @tomaszbarwicki! Looks like you requested some changes that are outdated now. Can you re-review this PR?


Aggs/Date_Histogram

Hi guys,
Its possible use aggs/date_histogram in query?
I'm trying get a alert based a average of date_histogram field.. it's a response time.
"aggs": {
"1": {
"avg": {
"field": "duration"
}

:+1:  +1
We'd love to be able to have Elastalert recognize conditions like "lots of records matching the same hostname" without having to specify the hostname. I think aggs are the way to go for this.

You can do that with use_terms_query and query_key. You can set either a set threshold or a spike condition and if any single hostname reaches that threshold, it would trigger an alert.


Configuring Fallback for Circuit Breaker, Timeout and Retry

I am currently using Istio for one of application, and mean time I was trying Fault Tolerance patterns. I have used Resilience4j library and it provides few fault tolerance patterns like Circuit Breaker, Retry, RateLimiter, BulkHead. One of the good thing about Resilience4j is that, it allows me to configure fallback implementations as part of these patterns. For eg: whenever the calls are monitored through CircuitBreaker and if there is trip, then I can send a default response through the fallback method instead of error message. This fallback invocation would be managed by CircuitBreaker, where in I just need to tell Circuit Breaker which is my fallback method. But the bad part of Resilinece4j is that, i need to change my existing code for injecting these patterns into my existing application.
Since my application is cloud based and based on micro services architecture, Istio is the right fit, and I can configure fault tolerance such as circuit breaker without adding any additional code to my existing application. But I don't see any way to configure fallback's to this, like I have in Resilience4j library. Is this is not supported by Istio or am I missing something to configure here.
Thanks
Krishna

Based on this dochttps://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking#arch-overview-circuit-break, envoy does not support it.

i don't think that istio support the fallback logic because it's up to you to customize the fallback.
i'm using Istio as a circuit Breaker and i handle my fallbacks internally in my app when i receiving 503 error.


Create monolithic V8 library

Build monolithic V8 library.
Drop ICU and inspector support, which are useless for Wasm.
Link blobs.
Change Dockerfile to use clang, which now should work.

@lostman, FYI.


wrong fix... it should be ++, not --

https://github.com/apt-sim/AdePT/blob/e96d1ac6a1efbd9f407134b46656d0e2775b964b/base/inc/AdePT/BlockData.h#L122

It should be fNused++;


Using removeClass() has no effect

I can add a class to my select-picker as follows:
$('#propertyType').addClass('pvForm-sp-error').selectpicker('setStyle');
However removing the same class does not work. The class is removed from the select but not from the parent element.
$('#propertyType').removeClass('pvForm-sp-error').selectpicker('setStyle');
The workaround is to manually remove the class using the following:
$('#propertyType').removeClass('pvForm-sp-error').selectpicker('setStyle').parent().removeClass('pvForm-sp-error');
Any idea why removing a class only does half the job or am I missing something?

I have this exact issue

On 2022 and have this same issue. Thanks @davidenco, like @cwilliamson62 said, your work save me!


Fix memory usage on export

Ref https://github.com/yulqen/datamaps/issues/11
Use of a blank template in region of 3/4Mb leads to a RAM max-out at around 18 templates and subsequent machine lock.
Test files are in dft/bcompiler_engine_issue_28.zip.

Thanks Matt.
Do you know which part of the template requires some much memory? I think in the past you have used a method for looking into workbooks to see which worksheets hold a lot of memory. If you can explain/show me how you do that, that would be very useful.

"sheet16.xml" (which I think is 5A...) is 76Mb uncompressed for some reason. There were millions of empty rows in the XML file - to the point where I couldn't jump to the bottom of the file in my editor. However I was able to delete them and resave and I've just run the export and it ran the lot in about 3 minutes.  I don't know what's caused this. I'll send everything over to you, including the fixed blank_template.xlsm. Be warned - that file may now be even more unstable due to me rippings it's internals out, but it seems to have worked for now.

Thanks Matt. Files corrupting is an occupational hazard when working with excel.


Mobile and Tablet View: Contact Us Page Not Responsive

The "Contact Us" page currently exhibits responsiveness issues when viewed on devices with a screen width smaller than 1475 px. On mobile and tablet screens, elements do not adjust properly, leading to a poor user experience.
Users may encounter overlapping text, misaligned fields, or scroll issues, making it difficult to complete contact forms or access essential information. Immediate attention is required to enhance the layout and ensure compatibility across all devices, facilitating a seamless experience for users on mobile and tablet platforms

resolves #1249


Docs for Running Windows Containers in Kubernetes

This is a...

[x] Feature Request
[ ] Bug Report

Problem:
The ability to run Windows Containers in Kubernetes is moving towards GA in 1.14 (or possibly 1.15). Windows Containers aren't identical to Linux containers. They have their own limitations and require Windows nodes. The GA release will not run all Kubernetes services on Windows, so mixed Operating System clusters are required with Kubernetes Master running Linux. The documentation implications are significant since running mixed Operating System clusters is not currently covered.
This issue exists to discuss the best approach to addressing the potentially very broad impact on documentation.
Proposed Solution:
At least two major use cases need to be addressed:

New K8s operators creating clusters to run Windows Containers they've been running in some other way
Those new to K8s need to understand how to stand up a mixed operating system cluster from scratch, and how to get their Windows Containers scheduled on the right nodes.

K8s operators with an existing K8s cluster who want to run both Linux and Windows containers
Experienced K8s operators need to be educated about the limitations of Windows Containers, the variants on the user experience, how to add Windows nodes to their clusters, and how to get Linux and Windows containers to run on the right nodes and communicate with each other.

The proposal is to start by writing monolithic documentation addressing these two use cases first, and then to determine how to land it in the documentation. The alternative is to assess which existing docs need updates, and then plan those.
Page to Update:
https://kubernetes.io/... too many to list

Kubernetes Version:1.14
Additional Information:

KEP For Windows Nodes in Kubernetes which includes some bullet points about topics to include in documentation
Enhancement Issue
PR for Documentation of Windows in Kubernetes for 1.13
Kubernetes Windows Walkthrough
Windows Containers Workshop

Please take a look at the draft outline (also circulated via the mailing list)

/sig windows

Here is placeholder PR for the changes to docs

documentation is now up and running.
You can view it in staging under https://5c914f680410ed000aeebc2e--kubernetes-io-vnext-staging.netlify.com/docs/setup/windows/add-windows-nodes/
/close


feat: Strip HTML from emails

close #229
As discussed, this PR does not alter existing data in the database.

@roschaefer: I added a few more test cases for real-world edge cases. I think we should handle line breaks (at least those introduced by
 and
 tags, possibly by other block elements as well) – otherwise without line breaks long-form emails will become difficult to read.

@roschaefer: I added a few more test cases for real-world edge cases. I think we should handle line breaks (at least those introduced by
 and
 tags, possibly by other block elements as well) – otherwise without line breaks long-form emails will become difficult to read.

done


Add FAQ for questions I've responded to on gn-auth

Add FAQ that has answers to some questions I've helped resolved for gn-auth
Add sections for weird errors I've encountered and how I solved them
Fix minor bugs in existing documentation

@jnduli there's merge conflicts.  Please have a look.


Save in app's own /sdcard directory, doesnt need WRITE_EXTERNAL_STORAGE.

Perhaps @cnorthrop would like to review? This is a useful step in making RenderDoc "just work" for more apps.

I've been meaning to try this experiment.  Kind of freaky that the server app can read the app's data on sdcard, but I guess that's what READ_EXTERNAL_STORAGE is for.  I'll test this PR with some apps that I know suffer from lack of this permission.

Possibly a silly question - does this "just work" when the device doesn't have an SD card? is it just emulated by the OS and /sdcard doesn't necessarily correspond directly to an SD card, or is it up to the application to try/fallback to a different location?
Is there a significant difference in available bandwidth, between SD card and the onboard storage?

Yes, /sdcard is just a symlink to mounted storage, which may or may not be a physical card.  None of my devices actually has a physical sdcard:
$ adb shell
marlin:/ # ls -la /sdcard
lrw-r--r-- 1 root root 21 2009-01-01 00:00 /sdcard -> /storage/self/primary
marlin:/ # ls -ls /storage/self/primary
0 lrwxrwxrwx 1 root root 19 1971-01-28 11:38 /storage/self/primary -> /mnt/user/0/primary

I'm fairly certain (just from my own perspective, not a Google proper statement) that we are always guaranteed to have an /sdcard on the filesystem.  It seems inherent to Android and most applications expect it to be there.  I should try using an sdcard through a USB-C adapter to see how it behaves sometime.

Okay, with the fixes to get Android tracing going again, I've tried this commit out.  It needs a few more changes to update the Android workflow.  Basically just removing more checks.  I made them here if you want to grab them:

android: Remove checks for WRITE_EXTERNAL_STORAGE from Android workflow
https://github.com/cnorthrop/renderdoc/commit/719c1944a578632f88d8207993ed9a4dcb64df8d

With those, I was able to trace an app that didn't have WRITE_EXTERNAL_STORAGE permission, so kudos for the find!

@michaelrgb I'll merge either if you add the extra change or say you'd like to take this as-is.

Removed the checks too, thanks!


Orchard.Blogs - Structure of archives controller ListByArchive is tangled

Depending on how you access the blog archives you can end up with a different type and a confusing re-use of a shape.
If you access it by month like ~/blog/archive/2016/9 (for example by using a link in the Blog Archives Widget) you get a nice ContentType = "BlogArchives" back. This can be targeted by layer rules / conditions and is nice and clean.
If you access the archive index like ~/blog/archive you get a null ContentItem back and it re-uses the shape that is used by the Blog Archives Widget Parts.Blogs.BlogArchives.cshtml to show a simple list of years/months with a post count in brackets.
This means that:

You can't target it with a ContentType("BlogArchives") layer rule
If you have customised the blog archive widget shape expecting it to be a widget and then making use of content item it throws an exception.
There is no page title set
There is no h1 set

For example I had var widgetTitle = contentItem.As<WidgetPart>().Title; which was breaking it for me.

I think the solution should be that the loop that makes the list of years and months in the archive should be pulled out into a shape.
The archives urls should always return a BlogArchives content type.
The ListByArchives.cshtml should be split with an if to either show the new shape with the list of years and months or the detail page like it already does.

I have misunderstood some parts about this. I thought that sometimes it returns a ContentType("BlogArchives"), but that was the "widget" trying to display in the main content zone.
I still think it needs looking at because the other issues are true.
It combines a widget view with a controller view, seemingly to save duplicating the loop that outputs the list but ties the two together and doesn't have the basics in there (h1, title).
At the moment the only way to target the archives is by hard coding the blog url into the layer rule.

For the shape, the ListByArchive method needs to return a custom view named ListArchives when no date is specified. This view will get a the Parts_Blogs_BlogArchives as a property, and will display it with a title too.
For the layers, the recommended solution is to use the url rule, or to create a custom layer rule targeting all things related to a blog.


AWS amplify build failed

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d2y4s18nsmd981
Region
eu-central-1
Amplify Console feature
Custom builds
Describe the bug
Hello,
The bug come when i deploy my modification on git and then build by amplify. The build failed everytime at :
Starting SSR Build...
and i go this message :

Starting SSR Build...
2021-06-29T14:01:29.603Z [ERROR]: Error: 'Command failed with exit code 1: node_modules/.bin/next build',
command: 'node_modules/.bin/next build',
exitCode: 1,
signal: undefined,
signalDescription: undefined,
stdout: 'Loaded env from /codebuild/output/src615757906/src//.env\n' +
'warn  - No build cache found. Please configure build caching for faster rebuilds. Read more: https://err.sh/next.js/no-cache\n' +
'info  - Creating an optimized production build...\n' +
'Attention: Next.js now collects completely anonymous telemetry regarding usage.\n' +
"This information is used to shape Next.js' roadmap and prioritize features.\n" +
"You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:\n" +
'https://nextjs.org/telemetry\n',
stderr: 'Browserslist: caniuse-lite is outdated. Please run:\n' +
'npx browserslist@latest --update-db\n' +
'Failed to compile.\n' +
'\n' +
"ModuleNotFoundError: Module not found: Error: Can't resolve 'net' in '/codebuild/output/src615757906/src//node_modules/tunnel-agent'\n" +
'\n' +
'\n' +
'> Build error occurred\n' +
'Error: > Build failed because of webpack errors\n' +
'    at build (/codebuild/output/src615757906/src/***/node_modules/next/dist/build/index.js:15:918)\n' +
'    at runMicrotasks ()\n' +
'    at processTicksAndRejections (internal/process/task_queues.js:97:5)',
failed: true,
timedOut: false,
isCanceled: false,
Terminating logging...

4 days earlier i did a realease and everything work perfectly my app build with no error.
but today i can't get rid of this error. i search everything on the net but nothing work to resolve it.
I don't understant why next.js come here because i never used it in my project ( react app), and i don't understant why the build start to do "SSR Build". The last build (the worked one) , i look at the log and the command SSR BUILD is not used.
Everything were fine 4 days ago...
Does your guys have a solution for this ?
Expected behavior
Build success with no error like the 25 past succed build.
Reproduction steps

deployed my code in Git
automatic deployement with aws amplify

Build Settings
version: 1
frontend:
  phases:
    preBuild:
      commands:
        - nvm use $VERSION_NODE_12
        - npm ci
    build:
      commands:
        - nvm use $VERSION_NODE_12
        - node -v
        - npm run-script build
  artifacts:
    baseDirectory: build
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

Additional information
The last modification i did on my code where :

call a /Get with API gateway
install xml2js with npm
install node-fetch with npm

that all my changes

Now i have this kind of error :

ModuleNotFoundError: Module not found: Error: Can't resolve 'fs' in '/codebuild/output/src914097980/src/secureasy/node_modules/request/lib'\n" +

Always at "moduleNotFoundError"

Even if i backup and deploy the lastest succesful commit, i still got the error.

ModuleNotFoundError: Module not found: Error: Can't resolve 'fs' in '/codebuild/output/src914097980/src/***/node_modules/request/lib'\n" +

Hi all, we've recently made improvements to our SSR error logging and have added support for Next.js 10/11.
Please follow this guide to upgrade to our latest support of Next.js: https://docs.aws.amazon.com/amplify/latest/userguide/server-side-rendering-amplify.html#update-app-nextjs-version

This is directly related to:
https://github.com/aws-amplify/amplify-console/issues/2098

This issue is a duplicate of https://github.com/aws-amplify/amplify-hosting/issues/2098 and it seems isolated to Next v11. We have since launched improved support for Next.js versions 12 and 13 so this should no longer be an issue.


Process conversation update status changes

Which will be sent by the server when you block a conversation.
cc @keybase/y2ksquad

first commit is already merged, this PR is about the second one.

Couple things:
1.) As mentioned to @joshblum, should use the existing SetStatus method on Inbox.
2.) That new RPC should be in the chat protocol, not gregor.

cc @maxtaco we wanted the server to drive the blocking, so you'd just call one API: SetBlocks, and it will deal with everything

Is that a reply to me?

Yes. Maybe I'm misunderstanding the comment about using SetStatus on Inbox. The original intent here was that the client shouldn't be worrying about this.

This PR is the client's response of removing the conversations from the inbox display. It has to care about it, I am saying they should use an existing function in there instead of modifying the one they did.


starship: 0.57.0 -> 0.58.0

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 138813 run on x86_64-darwin 1

1 package built:

starship

No thank you ;-)


cli: use same extension for chunks as for the main built file

Should fixe the issue highlighted by https://github.com/dhenneke/backstage-jest-error

Build issues should be fixed by #3910

Build issues should be fixed by #3910

Works for us. Thanks!

Works for us. Thanks!


AssertionError in assert end_i <= len(targets), (targets.shape, batch_seg_token_count) during training

Thank you for making the great work open source.
But I met AssertionError in assert end_i <= len(targets), (targets.shape, batch_seg_token_count) during training
The details are below:
File "./PixelLM/model/PixelLM.py", line 600, in model_forward
overlap_loss(pred_mask, gt_mask, gt_mask.shape[0], batch_seg_token_count)
File "./PixelLM/model/PixelLM.py", line 79, in overlap_loss
assert end_i <= len(targets), (targets.shape, batch_seg_token_count)
AssertionError: (torch.Size([9, 500, 375]), tensor([ 0, 12, 24, 36], device='cuda:0'))
Looking forward to your solves.

Sorry, there may be problems with the overlap_loss part of the code when I organize the code. You can cancel overlap_loss during training first. This still works well.

Thanks for your reply. I also met the error as issue#6 in the github even
with update code.
https://github.com/MaverickRen/PixelLM/issues/6
Is there any new update?
Looking forward to hearing from you.
Zhongwei Ren @.***> 于2024年4月27日周六 20:01写道：

Sorry, there may be problems with the overlap_loss part of the code when I
organize the code. You can cancel overlap_loss during training first. This
still works well.
—
Reply to this email directly, view it on GitHub
https://github.com/MaverickRen/PixelLM/issues/16#issuecomment-2080484292,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ3TA3OHWRIZPNGFJ4UM2STY7OHQHAVCNFSM6AAAAABGYV2HQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBQGQ4DIMRZGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Same problem, too.

Same problem, and cannot train


Fix the gRPC User-Agent header name

The gRPC-web protocol uses X-User-Agent, but gRCP uses the standard header User-Agent.
The gRCP transports mistakenly set the X-User-Agent header, like the gRCP-web transport. This PR corrects that mistake to use User-Agent instead.

These changes seem to already be in the CORS export PR right?

Yes, did this in one go, but splitting it up so we have a comprehensible changelog.


Overlay/AdRules

Hello,
I'm quite new at this. Maybe there is no support or there is a mistake on my example code but I am not able to show overlay ads. I created a manuel tag that has 4 element. First one is preroll, others are one overlay midroll, one linear midroll and a postroll video. But SDK skips the overlay one and plays other linear ads. Can we show overlay ads like this? When I use the overlay tag directly(on the adTagUrl), it shows at the beginning of the video like a preroll.
Example: http://www.sporx.com/tv/_videojs/test_ima_adrules.php
TAG: http://adm3.sporx.com/_banner/adrules2.php
Overlay TAG: http://tester.advertserve.com/servlet/vast2/media?mid=125&pid=0&random=8670
Thank you.

The IMA SDK doesn't support overlay ads in a VMAP response, so that's why this isn't working here. See  footnote 3 in the HTML5 column of the VMAP 1.0.1 row here.

Thank you for the very fast response. Just out of curiousity :) Do you know if this support is in the roadmap?
Thanks again.

I know we're looking into options for supporting it, but we don't have any release timeline info yet.

OK. Thanks for the support.


IRGen: ObjC rodata can only go in __objc_const if layout is fixed.

Otherwise, the runtime needs to be able to adjust the instance size when nonfragile ObjC bases
and/or resilient Swift bases are accounted for. rdar://54089488

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - b929343456f0b8b4c30371a930f38bd072686c8b

@swift-ci Please test macOS


Cannot run dependabot due to missing  pom.xml

Package ecosystem
maven
Package manager version
3.6.3
Language version
n/a
Manifest location and content prior to update
n/a
dependabot.yml content
version: 2
updates:
  - package-ecosystem: maven
    directory: "/"
    schedule:
      interval: daily

Updated dependency
n/a
What you expected to see, versus what you actually saw
The root pom that dependabot is running on contains modules like
<modules>
    <module>../module1</module>
    <module>../module2</module>
    <module>module3</module>
    <module>module4</module>
</modules>

Where module1 and module2 are hosted in a different repository which has to be checked out next to the repository containing this. The multi repo structure cannot be changed due to legacy reasons, but the root pom contains all the version management in <dependencyManagement> so ideally the missing poms would just be ignored, and the dependencyManagement is updated.
What happens now is this error in Insights > Dependency Graph > Dependabot:

There are a couple ways I can think of that would allow this to work:

allow ignoring individual submodules
allow ignoring the encountered exception, where it would just silently skip the missing pom instead of hard crashing

Native package manager behavior
n/a
Images of the diff or a link to the PR, issue or logs
n/a
🕹 Bonus points: Smallest manifest that reproduces the issue

👋 sorry for the slow response.
Since the path to the other repository is a local path, there's no way for Dependabot / the underlying package manager tooling to realize it needs to traverse to another repository.
However, the way ignores works is typically as a post-fetch filter. Dependabot is the glue code that looks for the manifest and hands it off to the native package manager. Today for the maven ecosystem, we re-implement Maven logic in Ruby, but poorly. So technically we could support this use case. But our long term product vision is to move toward having the manifest parsing / version checking handled by the native package manager, and then Dependabot as the glue code will handle turning those updates into PRs.
The problem with doing a pre-fetch filter is that most package managers require knowing all the manifests in order to calculate the version constraints. Even for those that accept a list of "ignored" versions, they're still going to typically traverse the full dep tree in order to know what can / cannot be safely bumped.
So I'm afraid I have to close this as wontfix. Down the road, if/when we transition from our Ruby code to actually calling Maven then you could file an upstream ticket with Maven to support this use case.


The requested service provider could not be loaded or initialized.

I am starting to use Selenoid, but I have not been able to start it.
We are running it on windows with the following command
cm selenoid start
The output it produces is:

Docker is not supported - using binaries...
Selenoid is already downloaded
Selenoid is already configured
Starting Selenoid...
Successfully started Selenoid

D:\Selenoid>2019/01/23 07:41:25 [-] [INIT] [Loading configuration files...]
2019/01/23 07:41:25 [-] [INIT] [Loaded configuration from C:\Users\Administrator.aerokube\selenoid\browsers.json]
2019/01/23 07:41:25 [-] [INIT] [Logs Dir: D:\c\Users\Administrator.aerokube\selenoid\logs]
2019/01/23 07:41:25 [-] [INIT] [Timezone: Local]
2019/01/23 07:41:25 [-] [INIT] [Listening on :4444]
2019/01/23 07:41:25 listen tcp :4444: socket: The requested service provider could not be loaded or initialized.
I've been trying to find what that socket message means, but no luck.  Some links found searching in google suggest that I need to have the SYSTEMROOT environment variable set, but it is already configured to C:\windows.
Any Help would be appreciate.

this is Windows security issue. Just start Selenoid as follows:

Is there a solution to this problem in Windows to use cm selenoid start?
If i use your solution I don’t understand how to run a selenoid-ui...

@tCode255 is should work when Docker is available. Currently not sure how to fix this when Docker is not available.


Fix #23 Universe-starter-agent kills any pre-existing tmux sessions

Universe-starter-agent just needs to kill the session a3c, not anything else.

Nice one I updated https://github.com/openai/universe-starter-agent/pull/18 to reflect this, I found that the location of the kill session was causing tmux to return a no server runnning error.

Issue was fixed in the meantime. It currently runs tmux kill-session -t a3c


WIP: Basic koans for the Enum module.

Have a look at the selection of methods from Enum in this PR.
I will make the koans themselves more 'story' like before merging.

@ukutaht @Maikon @marosluuce What do you guys think?

:+1: Descriptions need work but I think it covers most important aspects of the Enum module.

@ukutaht ideas? :)


Avoid hard-coding <IP_ADDRESS> , <IP_ADDRESS>

https://github.com/containerd/nerdctl/blob/fde3eae7cc21f6b010e683026837cab11d544f9f/cmd/nerdctl/run.go#L112
Currently we are hard-coding <IP_ADDRESS> and <IP_ADDRESS> as the DNS, but we should propagate the DNS configuration from the host.
Note that parsing /etc/resolv.conf on the host isn't enough, as it may point to <IP_ADDRESS> which is not accessible from containers.
Rootless
We can just use slirp4netns built-in DNS
$ rootlessctl --socket $XDG_RUNTIME_DIR/containerd-rootless/api.sock info --json | jq .networkDriver.dns
[
  "<IP_ADDRESS>"
]

Rootful
Parse /run/systemd/resolve/resolv.conf? Call some systemd API?

Thanks to the developers, today I can't modify the dns of the container under construction to download particularly slow, I hope to add an interface that can modify the dns when building images

Note that parsing /etc/resolv.conf on the host isn't enough, as it may point to <IP_ADDRESS> which is not accessible from containers.

Docker has a special case behavior for this where it looks at /run/systemd/resolve/resolv.conf. All other <IP_ADDRESS>/8 resolvers are ignored. If no valid resolvers remain, it falls back on a public DNS service.

Docker does this inside the daemon that is guaranteed to be executed on the same machine as the container. On the other hand, nerdctl is not guaranteed to run on the same host. I see 2 options :

add an option --dns=host to make nerdctl lookup the DNS like docker does on the host it runs. The user must guarantee that the DNS nerdctl will resolve is accessible from the host containerd runs on.
Change containerd to have the same behaviour as dockerd (not sure how feasible it is).

In docker build you have only the option to --add-host=DNS:IP but this is also missing here right now.
The option --dns=host works in docker only for run.
I definitely need one of the options, otherwise i'm not able to build my images with nerdctl

Could --dns=host be the default?

Note that nerdctl build uses buildkit under the hood, thus uses buildkit strategy for dns (same as docker). AFAIK, it takes the host DNS and is able to resolve my company's private dns.


Add filtering to start_listening and update documentation

This pull request introduces a new version (0.2.0) of the can_messenger library, adding support for filtering CAN messages in the start_listening method. It includes updates to the documentation, the implementation of the filtering feature, and corresponding tests. The most important changes are as follows:
New Features:

Added filtering support for start_listening via a filter parameter, which can be a single CAN ID, a range of CAN IDs, or an array of CAN IDs. [1] [2]

Documentation Updates:

Updated the README.md to include examples of using the start_listening method with filters.

Implementation Changes:

Refactored the start_listening method to support optional filtering of incoming CAN messages.
Added a helper method matches_filter? to check if a message ID matches the given filter.

Version Update:

Updated the version in lib/can_messenger/version.rb to 0.2.0.

Testing:

Added tests for the matches_filter? method in spec/lib/can_messenger/messenger_spec.rb.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines
Coverage Δ

lib/can_messenger/messenger.rb
90.74% <100.00%> (+1.37%)
:arrow_up:


Make user registration survey mandatory

Fixes #113

Added Middleware to intercept requests by users who haven't filled the registration survey
Add test cases
Updated the language
Removed user_passes_test decorators

@istride

@istride The PR is updated. This should be good to merge now.

Merging as @isedwards has reviewed the code (offline)


[InjectionIII.app] Bundle not found

Create alert when bundle not is found in /Applications

👍

We can set a flag #if (Simulator) to resolve this issue.

Yeah I was experimenting in this direction yesterday. Basically I tried to achieve the following:
Introduce a new conditional compilation flag DISABLE_INJECT and modify the #if flags in Injection, i.e. something along those lines:
#if DEBUG && !DISABLE_INJECT
private var loadInjectionImplementation: Void = {
    guard objc_getClass("InjectionClient") == nil else { return }
#if os(macOS)
    let bundleName = "macOSInjection.bundle"
#elseif os(tvOS)
    let bundleName = "tvOSInjection.bundle"
#elseif targetEnvironment(simulator)
    let bundleName = "iOSInjection.bundle"
#elseif targetEnvironment(macCatalyst)
    let bundleName = "macOSInjection.bundle"
#else
    let bundleName = "maciOSInjection.bundle"
#endif // OS and environment conditions

    if let bundle = Bundle(path: "/Applications/InjectionIII.app/Contents/Resources/" + bundleName) {
        bundle.load()
    } else {
        assertionFailure("InjectionIII not found, verify if it's in /Applications")
    }
}()

Then my app target which uses Inject could define DISBABLE_INJECT whenever it's not building for the simulator and add it to SWIFT_ACTIVE_COMPILATION_CONDITIONS. But, alas, SwiftPM doesn't seem to support that.

Just make it a print with a ⚠ instead of an assertionFailure. Let's keep it simple.

[...] but just make it a print with a ⚠ instead of an assertionFailure. Let's keep it simple.

For sure. I had the impression that the whole point of the PR was to crash under those circumstances. Thanks for clarifying!

Thanks for picking this up and reporting it @mbger. I guess the PR was intended to provide more feedback when the InjectionII app was not installed rather than silently failing to enable reloading. Using an assertionFailure however took it to the opposite extreme when you are running on a device. I think using a print statement would be a good compromise but it's your call @krzysztofzablocki.


Bump plutus for important upstream changes

This PR bumps plutus to:

Address #242 thanks to an upstream fix (https://github.com/input-output-hk/plutus/pull/4331).
Simplify #214, which will then be updated to also cover #240.

Most changes are in the third commit that auto-generates test files. Only the first two commits have (small) manual changes.
Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages
[x] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[ ] Reviewer requested

Nice; thanks @kk-hainq ! :)


Compile Errors

Hi Guys,
Got your device at Defcon, excited to try it out... you seem to have some compile issues...
In function 'set_registerS',
inlined from 'write_mf' at applications\external\canbus\libraries\mcp_can_2515.c:96:5:
applications\external\canbus\libraries\mcp_can_2515.c:33:20: error: array subscript 2 is above array bounds of 'uint8_t[2]' {aka 'unsigned char[2]'} [-Werror=array-bounds]
33 |         instruction[i + 2] = data[i];
|         ~^
applications\external\canbus\libraries\mcp_can_2515.c: In function 'write_mf':
applications\external\canbus\libraries\mcp_can_2515.c:29:13: note: while referencing 'instruction'
29 |     uint8_t instruction[] = {INSTRUCTION_WRITE, address};
|             ^~~~~~~
In function 'set_registerS',
inlined from 'write_mf' at applications\external\canbus\libraries\mcp_can_2515.c:96:5:
applications\external\canbus\libraries\mcp_can_2515.c:33:28: error: '__builtin_memcpy' offset [2, 5] is out of the bounds [0, 2] of object 'instruction' with type 'uint8_t[2]' {aka 'unsigned char[2]'} [-Werror=array-bounds]
33 |         instruction[i + 2] = data[i];
|         ~^
applications\external\canbus\libraries\mcp_can_2515.c: In function 'write_mf':
applications\external\canbus\libraries\mcp_can_2515.c:29:13: note: 'instruction' declared here
29 |     uint8_t instruction[] = {INSTRUCTION_WRITE, address};
|             ^
applications\external\canbus\scenes\snifferoption.c: In function 'save_data_on_log':
applications\external\canbus\scenes\snifferoption.c:73:27: error: the comparison will always evaluate as 'true' for the address of 'log_file_path' will never be NULL [-Werror=address]
73 |     if(app->log_file_path != NULL) {
|                           ^~
In file included from applications\external\canbus\scenes\snifferoption.c:1:
applications\external\canbus\scenes../app_user.h:58:10: note: 'log_file_path' declared here
58 |     char log_file_path[100];
|          ^~~~~~~~~~~~~
applications\external\canbus\scenes\snifferoption.c: In function 'save_address_data_on_log':
applications\external\canbus\scenes\snifferoption.c:89:27: error: the comparison will always evaluate as 'true' for the address of 'log_file_path' will never be NULL [-Werror=address]
89 |     if(app->log_file_path != NULL) {
|                           ^~
applications\external\canbus\scenes../app_user.h:58:10: note: 'log_file_path' declared here
58 |     char log_file_path[100];
|          ^~~~~~~~~~~~~

Hey @RogueMaster
May I know the firmware version are you using to compile the app?

version <IP_ADDRESS> working with SDK77 now @RogueMaster, thanks

On latest dev from OFW, UL and RM firmware this code has compile issues.

Thank you, it is fixed and I added this one to my firmware 😄


Add Travis badge to the README.md file

This closes the issue jorgemanrubia/mailgun_rails#25

Merged! Thank a lot

Merged! Thank a lot


feat(libs): 1. phase from design docs

Install example: ng install moment --typings moment-node
Uninstall examle: ng uninstall lodash --typings lodash

no test? :)

Not yet :-)

Okay please add at least one e2e test for this as this is a sensitive command. We really want to prevent regression.
Try something like:
ng new
ng install moment
ng build

And verify the build is what you expect, or try to ng serve and access the page. Whichever you think it's easier.

Sure, I agree for tests. But this now actually has no meaning because packages are not copied, this is basically just npm install and typings install for now, nothing is automated. Would like to chat about that with you.
I will prepare the tests anyway for later.

Please fix the CI errors.

As we agreed with @hansl I implemented the css preprocessors support for sass/less/stylus/compass.
This works right off after installing for example ng install sass which installs sass into project directory and it's then used (with some hacks) in the angular-cli side. This is the best option we have for now.
I also added the e2e tests where I actually write some styles and checks if they are compiled correctly.

CI fixed. Its working on all platforms now.

Wow @jkuri this is going to be nice to have.  Good work :+1:

Closing this. If nothing else, I learned something from this PR :-) Thanks @hansl!

@jkuri Do I understand it correct, that this did not make it into the master? And if so - why?! :flushed: I think this a super essential feature and many people are looking forward to it...

We had some problems with typings. This will be implemented but cannot tell you when because I don't know it myself :) If you are interested for sass/less support you can follow it here, the rest of the things from design docs will follow later.

Oh, ok - that's sad to hear :/ so to use 3rd party libraries like ngrx we still need to copy the sources to the project?

Unfortunately yes

I just want to clarify that you don't need to copy files to your project
for ngrx. You should simply be able to npm install ngrx and add those
files to your venderNpmFiles.
We are working on the production build story to use CDN versions of those
vendor files.
On Mon, Apr 4, 2016 at 10:41 AM, Jan Kuri<EMAIL_ADDRESS>wrote:

Unfortunately yes
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/angular/angular-cli/pull/294#issuecomment-205410353


Remote Debugger: Improve error message when user fails to establish session to GCP VM

Ping? Do you have a PR for this bug?

Fixed


Replaced ok and error events by error attribute on vis, layer and analyses models

The "API" for errors that we implemented initially (see https://github.com/CartoDB/cartodb.js/pull/1324#issuecomment-229647295) is not working properly because we might need to access the errors after the error event has been triggered (eg: right after the editor has been loaded).
This PR replaces ok and error events triggered by vis, layers and analyses by an error attribute that we can 'query' at any time. (this was suggested by @viddo at some point).
@viddo 👍 ?

Looks legit 👍

Added some bonus feature to this PR 😋 : now the vis object triggers a reload event every time CartoDB.js create a new instance of the map. @nobuti please take a look at the last too commits. Thx!


Feature bcvcpilot

Added the BC VC Pilot project to TOIP configurations

@wadeking98, Just getting around to looking at this now.  The issuer-kit-database was meant to be a shared resource (single instance) for all the agents in that Demo App environments to help minimize resource consumption.  Could you please look into unwinding the changes to the database configurations.  You should be able to backup and restore the wallet to the shared database instance.  Which brings up the other update that is missing from this PR, the update to the backup configurations to backup the bcvcpilot wallet database.


Terminal:SelectBox: Terminal select box should have main ARIA label

@Tyriar
Since accessibility with terminal is a focus of October, would you like me to go ahead and add this?

@cleidigh what would this proposed change do exactly? Also does it impact elsewhere the dropdown is used?

@Tyriar
The aria-label option places the main label on the select element.  This label gets red before the value.
For the debug configurations:
this.selectBox = new SelectBox([], -1, contextViewService, null, { ariaLabel: nls.localize('debugLaunchConfigurations', 'Debug Launch Configurations') });

I'm trying to get all the drop downs with main labels and if possible with the correct role.
For the terminal drop down the title might be: "Open Terminals: 1 cmd"  where 1 cmd is obviously the first selected terminal name.
The change is just on the terminal client side.  I'm going to do the same thing for the output dropdown

@cleidigh sounds good 👍

@Tyriar , Can i work on this ?
if yes then some starter points would be helpful, thanks :)

@skprabhanjan I think @cleidigh was going to work on this one. He's very familiar with this component.

@skprabhanjan
cc: @Tyriar
Absolutely.  Just to be clear on a couple things:

This will probably be just a couple lines of code (but great if you want to set up your dev environment
if you don't already have it and go through the process..)
Timing wise, this is intertwined with some other accessibility bugs so I have to fix those for Electron oddities, you can make this sequential from that.

But I can help you through the process on @Tyriar 's behalf.
I suggest looking at the code referenced above from -
debugActionItems.ts  (around line 40 - sorry I can't select code easily in github)
@IThemeService private themeService: IThemeService,
		@IConfigurationService private configurationService: IConfigurationService,
		@ICommandService private commandService: ICommandService,
		@IWorkspaceContextService private contextService: IWorkspaceContextService,
		@IContextViewService contextViewService: IContextViewService,
	) {
		this.toDispose = [];
		this.selectBox = new SelectBox([], -1, contextViewService, null, { ariaLabel: nls.localize('debugLaunchConfigurations', 'Debug Launch Configurations') });
		this.toDispose.push(this.selectBox);
		this.toDispose.push(attachSelectBoxStyler(this.selectBox, themeService, {
			selectBackground: SIDE_BAR_BACKGROUND
		}));

		this.registerListeners();
	}

The selectBox, selectBoxCustom files contain the drop-down code (for reference these are not needed to be touched)

@cleidigh , Thanks for the reply, I have set up my dev environment already :)
cc: @Tyriar ,
I was able to locate the usage in debugActionItems.ts where the selectBox is this.selectBox = new SelectBox([], -1, contextViewService, null, { ariaLabel: nls.localize('debugLaunchConfigurations', 'Debug Launch Configurations') }); .
The current code has ariaLabel set, but I am not entirely clear as to what it should be changed to , I tried searching for references in other places where this is used but did not make things clear.
Could you please me on this ?
Thanks:)

@skprabhanjan
No problem.

I gave the debugActionItems pointer as the one example SelectBox constructor call that includes the label option within the interface.
The terminal uses SelectActionItem within actionBar.ts
We will have to modify this to pass through the ISelectBoxOptions interface which contains the option
"ariaLabel" which should be localized string.
I would recommend not passing just the label string, but rather the entire interface as we will easily add more options and we won't have to modify the call chain again
The label is for the select, descriptive accessibility name for the SelectBox or dropdown I proposed
"Open Terminals:"  - @Tyriar may have a preference or better idea.
For the localization ID, I look for other module example strings and use a similar format approach for consistency within the module.
If you want to be able to test accessibility labels, you should install NVDA reader for Windows or if you are on OS X you can use built-in voice over
I still have to make the fix for the electron bug within SelectBox, I could not do that today, will do tomorrow.  Without this fix the labeling addition does not get read.
Looks like we might be 8-10 hours apart so I can review anything you do overnight the next day if I have no conflicts

Cheers

export class SelectActionItem extends BaseActionItem {
	protected selectBox: SelectBox;

	constructor(ctx: any, action: IAction, options: string[], selected: number, contextViewProvider: IContextViewProvider, selectBoxOptions?: ISelectBoxOptions) {
		super(ctx, action);

		this.selectBox = new SelectBox(options, selected, contextViewProvider, null, selectBoxOptions);

		this._register(this.selectBox);
		this.registerListeners();
	}

"Open Terminals" sounds good to me.

FYI I cannot build anything so I'm kind of down and out, cannot post the fix for Electron or anything else...
https://github.com/Microsoft/vscode/issues/61274

@cleidigh , sorry I thought debugActionItems had to be changed and hence the confusion.
cc: @Tyriar
Adding selectBoxOptions.ariaLabel = nls.localize('openTerminals', "Open Terminals");  before https://github.com/Microsoft/vscode/blob/master/src/vs/base/browser/ui/actionbar/actionbar.ts#L790 would be good ?

@cleidigh ,
I created a PR but strange things are happening.
it says page not for the PR found https://github.com/Microsoft/vscode/issues/61466
I am not sure what is happening.

@cleidigh ,
I created a PR but strange things are happening.
it says page not found the PR found https://github.com/Microsoft/vscode/issues/61466
I am not sure what is happening.

@skprabhanjan
Thanks for the first PR !

Noticed that VoiceOver doesn't read the ARIA label when just tabbing through. Verified the label is there.

@chrmarti
Thanks, I can reproduce us as well.  Battle between NVDA/voiceover/Electron continues...
I will work on a possible workaround PR.


Add an optional delta_changes to execution_proof

This is the first step of #10922. A new trie backend with delta changes is introduced to create a
state during the entire block execution, e.g., a true state after applying some extrinsic. With this
PR, creating execution proof for any stage(initialize_block, extrinsic, finalize_block) during the
block execution can be supported.

Do we really need to include that into Substrate?

Hmm, the reason for including this in Substrate is to make Substrate generally more flexible which can be also helpful in the future for the other projects in the community. The reason for not including it is that it's not used by any other projects than Subspace at present. IMHO it could be a good addition to Substrate since it does not break any existing code.

Could you give an example on how this would be used?

Like from where is the delta coming?

Sure, here is the complete test for the proof creation and verification, basically delta is constructed by partially re-executing the block using a custom BlockBuilder. The test test_fraud_proof is runnable, but  the proper implementation to create delta gets stuck due to this problem.

Okay thank you. But I still not really see a reason why we should merge this into Substrate. For the moment it could live in Subspace.

Okay, I have no problem with that. Then I think there is only one API missing for now to implement the extrinsic execution proof in subspace which is the overlay in https://github.com/paritytech/substrate/pull/10922/files#diff-af4db6ff4cb4455bad83084dd50fe85e6b22e556a14078f87e9a6013aab1375fR524. I can update #10922 to only expose the API overlay from ApiExt trait if it's good to you. @bkchr

@bkchr Closing this PR and I have updated #10922 to expose the overlay only.


refactor(deps): Remove @google-cloud/promisify dependency in favor of native implementation

Currently we utilize @google-cloud/promisify in numerous files to create functions and methods that handle both callback and Promises APIs. The problem with this approach is that it's difficult to determine when something is promisified on the type-level and it makes debugging/understanding the codebase a bit more cumbersome (it can come off as 'magic' for newcomers).
Source:
https://github.com/googleapis/nodejs-storage/blob/a9c4c182827e221ad7324d0664e2a3c2fa72c41c/src/file.ts#L4121-L4130
Example (difficult to understand how a Promise is returned):
https://github.com/googleapis/nodejs-storage/blob/a9c4c182827e221ad7324d0664e2a3c2fa72c41c/src/file.ts#L1532-L1676
Going forward, we should handle the logic directly in the methods - in a seamless way when possible.
Idea: Perhaps have an internal/private Promise-only (async/await) version of methods, and have the public methods internally handling all difference between callback and Promise (e.g. most logic would be in the internalized-async/await function).

This helper may help:
https://github.com/googleapis/nodejs-storage/blob/0ddef7e81d86c0f12c0cfeb49dd7b8e8ba8f1822/src/util.ts#L18-L29


JS crash occurs after audio data has been decoded, if the WaveSurfer instance has been destroyed in the meantime

Thanks for a cool library/component!
I get the below error if I quickly do next, next, next in a list of audio files, where each "next" action destroys the current wavesurfer and creates a new instance.
This happens because the "onDone" callback when calling decodeArrayBuffer is then executed after I have destroyed the wavesurfer instance and thereby its drawer, causing the drawer.style function to crash because its wrapper property is gone.

Created #819.
Notice that some other PRs had been merged into your master where only the dist files had been changed. That meant that after modifying the src files and running grunt those changes were overwritten... I had to manually copy them into the src files and build again

Oh wow. How did I miss that 🤔 Thanks!

PR was merged, closing.


Cross build for ScalaJS and Scala Native (binary compatible)

This is a follow-up of #251, keeping binary compatibility and support for Scala 2.10 on the JVM.

what do you think of this proposal in general? Anything that needs clarification or refactoring?

I'll give it a read today - thanks for your work!

No problem, thanks for checking it out!
The codebase should be unchanged for the JVM side and is binary compatible with previous versions. The ScalaJS and ScalaNative parts are the same minus the jsonFormatX helper utilities, as these require reflection. It's not ideal, however I don't see any immediate workaround, and the jsonFormat methods that require specifying field names are still available (for some more context, I'm using spray with Magnolia, a really powerful mix IMO).

Any updates?

I published my fork of the project, in case anyone would like to try out spray-json with support for ScalaJS and Scala Native.
The maven coordinates are:
libraryDependencies += "io.crashbox" %%% "spray-json" % "1.3.4-1"

It uses the MiMa plugin to make sure that the JVM project stays binary compatible with the official spray-json library, and does not interfere with existing projects depending on it.
My master branch contains some additional changes related to versioning and publishing. I'll continue to maintain the pull request at branch cross-build-bincompat.

Rebased onto https://github.com/spray/spray-json/pull/244

Rebasing on latest master again

Sorry for keeping this one hanging for such a long time. I think until we have figured out the details we could already try to reorganize the build file in a way that makes this merge less painful. Changes to the build file are always super contentious but I think we can already rearrange the existing one in a way that the changes here are mostly incremental and we won't need frequent rebases / conflict resolution even if we cannot merge this one right away. I'll have a try.

I rebased all changes and consolidated everything into a single commit. Since the PR consists mostly of renames, I think it is actually easier to view this as one set of changes rather than multiple.
In case anyone is interested in using this already, I maintain a fork of spray-json. The fork will not diverge from spray-json and always remain binary compatible. It only adds support for Scala JS and Scala Native.

Can this be merged or are there any other concerns with this PR? It would be super great to get this accepted.

I'm afraid I caused some conflicts by merging #294 here, sorry about that!

No problem, I fixed it

Updated to support Scala 2.13.0-RC2

Several times I was on the verge on just clicking merge on this (and the previous) PR because it seems useful for some people and the work is solid. But then, every time I look into it I have some doubts whether we should really do it:

Build complexity: currently as simple as possible, adding more platforms (especially scala-native) means that you cannot just run test because you need prerequisites at least for scala-native
Support for the new platforms, who would do it, fix bugs, etc.?
What's left of spray-json without the jsonFormatX methods? Mostly the AST and the parser, few people are going to use the variant that requires to list all fields to create a format
State of scala-native, only Scala 2.11 seems currently supported (I suggested removing 2.11 support for upcoming versions altogether but maybe we could carry it around for a while)

On the other hand, it's a bit unclear (to me at least) how useful spray-json would be for scalaJs at all. You don't need a json parser in JS, so only (somewhat crippled) conversion to case classes is left (slightly exaggerated).
So, still not sure where to go with this.
(I've got a few upcoming improvements lined up, so I wanted to make sure not to introduce even more conflicts if it could be helped but it seems I've got no resolution so far.)

This library is certainly useful to Scala Native. The 0.4.x series to be released soon will support Scala 2.12 and 2.13.
I use this library as an independent parser to compare with the parsing in https://github.com/ekrich/sconfig so to me it would be great if it was supported.
The build is a bit more complex but I think it is worth it to support the other Scala platforms. You can always add an alias for plain test to run the sprayJsonJVM/test task. It would just be one item in the Seq I think - https://github.com/scala-native/scala-native/blob/master/build.sbt#L84-L94

@ekrich thanks for that data point. We could still either just merge it and throw it out if it turns out to be a drag. Or, someone could fork the repo and maintain it out of tree (and under a different maven organization).

@jodersky has been publishing but of course that takes extra effort. https://mvnrepository.com/artifact/io.crashbox/spray-json It was also added to the community build - I think they call it something different now.

Thanks for following up! A couple of comments:

Build complexity: currently as simple as possible, adding more platforms (especially scala-native) means that you cannot just run test because you need prerequisites at least for scala-native

The build is slightly more complex, however it is still possible to compile and test only the JVM project by itself.

Support for the new platforms, who would do it, fix bugs, etc.?

I can't promise anything, but so far I have been maintaining and regularly updating my fork.

What's left of spray-json without the jsonFormatX methods? Mostly the AST and the parser, few people are going to use the variant that requires to list all fields to create a format

The jsonFormatX methods are only absent on non-JVM platforms. Furthermore, I would argue that using an explicit constructor format compared to the the formatX versions is only a minor hurdle. Ideally spray-json is  used with some kind of derivation library such as magnolia (see this project for an example).

State of scala-native, only Scala 2.11 seems currently supported (I suggested removing 2.11 support for upcoming versions altogether but maybe we could carry it around for a while)

I thought that spray-json is considered feature complete. I'm not sure how supporting this old version of Scala is an issue.

On the other hand, it's a bit unclear (to me at least) how useful spray-json would be for scalaJs at all. You don't need a json parser in JS, so only (somewhat crippled) conversion to case classes is left (slightly exaggerated).

The beauty of spray-json is that it can run on all platforms, without requiring adaptations to source code. This makes it possible to write typesafe and shared code for many application components. For example, it makes it possible share formats for models across a backend on the JVM, a frontend in ScalaJS and maybe a command line client in native (see this project for a concrete example).
I can understand if you have a different direction in mind for spray-json, and I will continue to maintain my binary compatible fork, regardless of the outcome of this PR. I personally consider spray-json my library of choice when it comes to dealing with JSON, and I thought I would contribute my changes back because there are already way too many JSON libraries in the Scala ecosystem :)

Thanks for your very reasonable comments, @jodersky.

I thought that spray-json is considered feature complete.

That's a good point, in the last years it was super stable so no problems expected. I have a few things upcoming and I was thinking that maybe having to support more platforms might slow me down doing those incremental improvements (which I'm doing in my free time so far). But maybe my concern is exaggerated.

I'm not sure how supporting this old version of Scala is an issue.

In this particular case, Scala 2.11 was missing newer compiler flags but it can probably be worked around.

The beauty of spray-json is that it can run on all platforms, without requiring adaptations to source code.

Right, except for the formats that had to be removed because of reflection usage.

I thought I would contribute my changes back because there are already way too many JSON libraries in the Scala ecosystem

Thanks for that :) That's also my motivation to make incremental and compatible changes, because people are using spray-json already for a long time and can get some nice (e.g. performance and quality of life) improvements pretty much for free.

Anyway, I resolved the conflicts and merged it for now. Should there be any problems we'll look into them when they come up.
Thanks @jodersky for maintaining JS and native support so far and carrying it through here :)

Thank you! Please do let me know anytime if issues arise, or you need extra
resources in supporting the other platforms. I'd be glad to help out in any
way I can
On Fri, Jul 26, 2019, 22:03 Johannes Rudolph<EMAIL_ADDRESS>wrote:

Anyway, I resolved the conflicts and merged it for now. Should there be
any problems we'll look into them when they come up.
Thanks @jodersky https://github.com/jodersky for maintaining JS and
native support so far and carrying it through here :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/spray/spray-json/pull/252?email_source=notifications&email_token=AAHV3JGRZVY7A547PGOETGTQBNJ75A5CNFSM4EUN23XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25SOMY#issuecomment-515581747,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHV3JEIFUNRK7QA7642HJLQBNJ75ANCNFSM4EUN23XA
.

Thanks to both of you for the excellent library and for the cross platform support. If everything is working good this could be added to the Community build and once we get a formal release I can change my dependency too. cc/ @SethTisue

re: the Scala community build, let's pursue that at https://github.com/scala/community-builds/pull/943


Retraining xgboost model with different loss function

Context:
Let us define 2 loss functions (taken from this page):
XGBoost Version: 0.90
Python Version: 3.5.2
Number of epochs: 50
Loss Function 1
def native_rmse(dtrain: xgb.DMatrix,
                dtest: xgb.DMatrix, prev_model:xgb.core.Booster=None) -> Dict[str, Dict[str, List[float]]]:
    '''Train using native implementation of Root Mean Squared Loss.'''
    print('Squared Error')
    squared_error = {
        'objective': 'reg:squarederror',
        'eval_metric': 'rmse',
        'tree_method': 'hist',
        'seed': kSeed
    }
    start = time()
    results: Dict[str, Dict[str, List[float]]] = {}
    trained_model = xgb.train(squared_error,
              dtrain=dtrain,
              num_boost_round=kBoostRound,
              xgb_model=prev_model,
              evals=[(dtrain, 'dtrain'), (dtest, 'dtest')],
              evals_result=results)
    print('Finished Squared Error in:', time() - start, '\n')
    return trained_model, results

Loss Function 2
def native_rmsle(dtrain: xgb.DMatrix,
                 dtest: xgb.DMatrix, prev_model:xgb.core.Booster=None) -> Dict[str, Dict[str, List[float]]]:
    '''Train using native implementation of Squared Log Error.'''
    print('Squared Log Error')
    results: Dict[str, Dict[str, List[float]]] = {}
    squared_log_error = {
        'objective': 'reg:squaredlogerror',
        'eval_metric': 'rmsle',
        'tree_method': 'hist',
        'seed': kSeed
    }
    start = time()
    trained_model = xgb.train(squared_log_error,
              dtrain=dtrain,
              num_boost_round=kBoostRound,
              xgb_model=prev_model,
              evals=[(dtrain, 'dtrain'), (dtest, 'dtest')],
              evals_result=results)
    print('Finished Squared Log Error in:', time() - start)
    return trained_model, results

Note: Let's assume dtrain and dtest are defined.
Problem:
The procedure I would like to follow to train a XGBoost model is as follows:

Train XGBoost Model for 2 epochs using "rmse" loss function and save the model.

rmse_model, rmse_evals = native_rmse(dtrain, dtest)

This works and the output is
[0]	dtrain-rmse:732.556	dtest-rmse:662.783
[1]	dtrain-rmse:679.064	dtest-rmse:675.687
[2]	dtrain-rmse:627.901	dtest-rmse:702.533
.
.
[48]	dtrain-rmse:66.5061	dtest-rmse:804.446
[49]	dtrain-rmse:62.9484	dtest-rmse:804.296

Use the trained rmse_model and retrain a new model using "rmse" loss functin.

rmse_model1, rmse_evals1 = native_rmse(dtrain, dtest, rmse_model)

This also works and gives the following output:
[0]	dtrain-rmse:62.3487	dtest-rmse:804.474
[1]	dtrain-rmse:61.0327	dtest-rmse:804.525
.
.
[48]	dtrain-rmse:19.3592	dtest-rmse:808.246
[49]	dtrain-rmse:19.1166	dtest-rmse:808.246

Use the trained rmse_model and train a new model using "rmsle" loss functin.

rmsle_model, rmsle_evals = native_rmsle(dtrain, dtest)

But this doesn't work. It seems to have stuck.
[0]	dtrain-rmse:62.9484	dtest-rmse:804.296	dtrain-PyRMSLE:10.3872	dtest-PyRMSLE:10.6404
[1]	dtrain-rmse:62.9484	dtest-rmse:804.296	dtrain-PyRMSLE:10.3872	dtest-PyRMSLE:10.6404
.
.
[48]	dtrain-rmse:62.9484	dtest-rmse:804.296	dtrain-PyRMSLE:10.3872	dtest-PyRMSLE:10.6404
[49]	dtrain-rmse:62.9484	dtest-rmse:804.296	dtrain-PyRMSLE:10.3872	dtest-PyRMSLE:10.6404

But this works when I trained with 2 epochs (for both loss functions) with following output:
[0]	dtrain-rmse:679.078	dtest-rmse:675.713	dtrain-PyRMSLE:3.79744	dtest-PyRMSLE:3.63441
[1]	dtrain-rmse:679.13	dtest-rmse:675.729	dtrain-PyRMSLE:3.79698	dtest-PyRMSLE:3.6231

It seems that it is not training or reached a local minima. Can we actually do something like this? Train the model for few epochs with one loss function and retrain it with another loss function? Could anybody help me with what is happening in both the cases.
Thank you.

Can we actually do something like this?

Technically yes.  But the objective defines the gradient (and global bias sometimes), so when you change the objective you are training on a different scale (or even different space) of gradient.

If you are trying to chain training from different models a good way is to train the first as a separate model, then output predictions as margin, create a new DMatrix on the same data initialising with the margin vector and then train a second model with this DMatrix as input.

Ok

create a new DMatrix on the same data initialising with the margin vector and then train a second model with this DMatrix as input.

How should I do this? Is there any article or issue related to this. Thank you.


feat: use new gpt-3.5-turbo model

the tokenizer that was just added doesnt have support for the new model yet, so still using the told model and 🤞 they are very similar.
I used it to generate its own commit message.

This works well for me and seems to write better commit messages :-)

Working pretty well for me!
I also made a slight change to the prompt: "'Write a high-level, insightful and concise Git commit message in a complete sentence in present tense for the following diff without prefacing it with anything:'", which at least in my testing made it give slightly less detail-focused commit messages :)

Thanks!


Update Dockerfile

Hi there, I think you raised this in the Google repository by mistake (it should be in your forked copy).  Thanks


Set non-jsonp accept header correctly for ML8

It needs to be 'application/sparql-results+json' rather than
'application/json'
This is distinct from the dataType ajax setting, because the dataType
setting is overloaded and needs to be 'json' for correct response
parsing.

The problem I was getting when we were on WebEx was that the jQuery ajax response parser was trying to convert to 'sparql-results+json', which is of course not a supported type. I had to disentangle dataType from the Accept header required by ML8.

See also #10, and PR #17. I think you need to disable jsonp as well for MarkLogic, and then you will need to use accepts: { json: instead of accepts: { jsonp:.
Our solutions are pretty similar. You wrapped it in a nice function..

Is this accomplished by #17 or do I need to merge these together?

FYI, the correct mime-type is set in the latest release. Not sure if there's other missing features in this PR ...

I'm not sure how this overlaps with what Geert did, and I'm not actively using this on a project at the moment, so I think we should close this. It looks like Geert fixed the same problem a different way.


Requirement.txt installation crashes.

pip 9.0.1 from /Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg (python 2.7)
After running sudo pip install -r requirements.txt
Exception:
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/basecommand.py", line 215, in main
status = self.run(options, args)
File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/commands/install.py", line 342, in run
prefix=options.prefix_path,
File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/req/req_set.py", line 784, in install
**kwargs
File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/req/req_install.py", line 851, in install
self.move_wheel_files(self.source_dir, root=root, prefix=prefix)
File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/req/req_install.py", line 1064, in move_wheel_files
isolated=self.isolated,
File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/wheel.py", line 377, in move_wheel_files
clobber(source, dest, False, fixer=fixer, filter=filter)
File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/wheel.py", line 316, in clobber
ensure_dir(destdir)
File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/utils/init.py", line 83, in ensure_dir
os.makedirs(path)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/os.py", line 150, in makedirs
makedirs(head, mode)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/os.py", line 150, in makedirs
makedirs(head, mode)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/os.py", line 150, in makedirs
makedirs(head, mode)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/os.py", line 157, in makedirs
mkdir(name, mode)
OSError: [Errno 1] Operation not permitted: '/System/Library/Frameworks/Python.framework/Versions/2.7/share'

This is an issue with pip, not with this package.  Try running pip install --user -r requirements.txt and let me know if that works for you.

Will try as soon as I get home. Great talk by the way. It was my first meet up and I feel like learned so much.
My computers all run Linux but my girlfriend uses a MacBook so I'm using hers.
The OS version on the mac is
OSX

Will try as soon as I get home. Great talk by the way. It was my first meet up and I feel like learned so much.
My computers all run Linux but my girlfriend uses a MacBook so I'm using hers.
The OS version on the mac is
OSX
I submitted an issue to pip to fix the issue, or point me on a direction to fix the issue(This seems like a cool learning exercise)
I also came a cross another answer while doing research, and that is to create a virtual environment, and then proceed with the installation.
I will try both  pip install --user -r requirements.txt   and the virtual environment solutions, and let you know how they turn out.

If you go the virtual environment route, use anaconda, that's the standard at this point.  It'll definitely solve your issue.  Then circle back here to let me know what works!  I'll update the README according.
Also very glad to hear you enjoyed the talk :)  I very much enjoyed the audience engagement!


Gulp dest writes one file to wrong location

What were you expecting to happen?
Gulp dest writes the given files to the correct directory.
What actually happened?
Gulp dest writes all files to the correct directory except one file.
Please post a sample of your gulpfile (preferably reduced to just the bit that's not working)
gulp.task('html', function() {
  return gulp
    .src([
      paths.src.html.files,// './src/**/*.html'
      paths.src.html.js.files,// './src/**/*.js'
      '!' + paths.dist.libs.files,// '!./build/assets/libs/**/*'
      '!' + paths.src.js.files,// '!./src/assets/js/**/*'
      '!' + paths.src.tmp.files, // '!./src/.tmp/**/*'
      '!' + paths.src.partials.files // '!./src/partials/**/*'
    ])
    .pipe(fileinclude({
      prefix: '@@',
      basepath: '@file',
      filters: {
        markdown: function(content) {
          return markdownit.render(content);
        }
      }
    }))
    .pipe(replace(/href="(.{0,10})node_modules/g, 'href="$1assets/libs'))
    .pipe(replace(/src="(.{0,10})node_modules/g, 'src="$1assets/libs'))
    .pipe(replace('@@cdnRoot', cdnRootProd))
    .pipe(replace('@@sdkVersion', sdkVersion))
    .pipe(eol())
    .pipe(useref())
    .pipe(cached())
    .pipe(gulpif('*.js', uglify()))
    .pipe(gulpif('*.css', cleancss()))
    .pipe(gulp.dest(paths.dist.base.dir)) // './build'
    .pipe(debug());
});

What version of gulp are you using?
CLI version: 2.2.0
Local version: 4.0.2
What versions of npm and node are you using?
npm 6.14.2
node v13.10.0
When I place a .pipe(debug()) before gulp.dest I get the following output (snippet):
[15:48:32] gulp-debug: src/index.html
[15:48:32] gulp-debug: src/dashboard/index.html
[15:48:33] gulp-debug: src/assets/css/theme.min.css
[15:48:33] gulp-debug: src/contact/index.html
[15:48:33] gulp-debug: src/new-password/index.html
[15:48:33] gulp-debug: src/privacy-policy/index.html
[15:48:33] gulp-debug: src/assets/js/dashboard/dashboard.min.js
[15:48:33] gulp-debug: src/reset-password/index.html
[15:48:33] gulp-debug: src/sign-in/index.html
[15:48:33] gulp-debug: src/sign-up/index.html
[15:48:33] gulp-debug: src/terms-of-use/index.html
[15:48:33] gulp-debug: src/dashboard/api-keys/index.html
[15:48:33] gulp-debug: src/docs/latest/Adjustment Filters.html
[15:48:33] gulp-debug: src/docs/latest/Common.html
[15:48:33] gulp-debug: src/assets/js/theme.min.js
[15:48:33] gulp-debug: src/docs/latest/Documentation.html
[15:48:33] gulp-debug: src/docs/latest/Enumerations.html
[15:48:33] gulp-debug: src/docs/latest/Exports.html
[15:48:33] gulp-debug: src/docs/latest/Filter Base.html
[15:48:33] gulp-debug: src/docs/latest/Insta Filters.html
[15:48:33] gulp-debug: src/docs/latest/Managing Sessions.html
[15:48:33] gulp-debug: src/docs/latest/Other Enums.html
[15:48:33] gulp-debug: src/docs/latest/Preview Controllers.html
[15:48:33] gulp-debug: src/docs/latest/Protocols.html
[15:48:33] gulp-debug: src/docs/latest/Sessions.html
[15:48:33] gulp-debug: src/docs/latest/Visual Effect Filters.html
[15:48:33] gulp-debug: src/docs/latest/changelog.html
[15:48:33] gulp-debug: src/docs/latest/customizing-colors.html
[15:48:33] gulp-debug: src/docs/latest/exporting-media.html
[15:48:33] gulp-debug: src/docs/latest/getting-started.html
[15:48:33] gulp-debug: src/docs/latest/index.html
[15:48:33] gulp-debug: src/docs/latest/installation.html
[15:48:33] gulp-debug: src/docs/latest/license.html
[15:48:33] gulp-debug: src/docs/latest/writing-custom-filters.html
[15:48:33] gulp-debug: src/dashboard/changelog/index.html
[15:48:33] gulp-debug: src/dashboard/exporting-media/index.html
[15:48:33] gulp-debug: src/dashboard/customizing-colors/index.html
[15:48:33] gulp-debug: src/dashboard/getting-started/index.html
[15:48:33] gulp-debug: src/dashboard/payment-method/index.html
[15:48:33] gulp-debug: src/dashboard/profile/index.html
[15:48:33] gulp-debug: src/assets/css/payment.min.css
[15:48:33] gulp-debug: src/dashboard/support/index.html
[15:48:33] gulp-debug: src/dashboard/writing-custom-filters/index.html
When I place a .pipe(debug()) after gulp.dest I get the following output (snippet):
[15:49:25] gulp-debug: build/index.html
[15:49:25] gulp-debug: build/contact/index.html
[15:49:25] gulp-debug: build/assets/css/theme.min.css
[15:49:25] gulp-debug: build/dashboard/index.html
[15:49:25] gulp-debug: build/new-password/index.html
[15:49:25] gulp-debug: build/privacy-policy/index.html
[15:49:26] gulp-debug: build/assets/js/dashboard/dashboard.min.js
[15:49:26] gulp-debug: build/reset-password/index.html
[15:49:26] gulp-debug: build/sign-in/index.html
[15:49:26] gulp-debug: build/sign-up/index.html
[15:49:26] gulp-debug: build/terms-of-use/index.html
[15:49:26] gulp-debug: build/dashboard/api-keys/index.html
[15:49:26] gulp-debug: build/dashboard/changelog/index.html
[15:49:26] gulp-debug: build/dashboard/customizing-colors/index.html
[15:49:26] gulp-debug: build/assets/js/theme.min.js
[15:49:26] gulp-debug: build/dashboard/exporting-media/index.html
[15:49:26] gulp-debug: build/dashboard/getting-started/index.html
[15:49:26] gulp-debug: build/dashboard/payment-method/index.html
[15:49:26] gulp-debug: build/dashboard/profile/index.html
[15:49:26] gulp-debug: ../assets/css/payment.min.css
[15:49:26] gulp-debug: build/dashboard/support/index.html
[15:49:26] gulp-debug: build/dashboard/writing-custom-filters/index.html
[15:49:26] gulp-debug: build/docs/latest/Adjustment Filters.html
[15:49:26] gulp-debug: build/docs/latest/Common.html
[15:49:26] gulp-debug: build/docs/latest/Documentation.html
The above bolded line is incorrect. It should be:
[15:49:26] gulp-debug: build/assets/css/payment.min.css
What would cause gulp.dest to write one file in a different directory?

Note: If I remove cached() the problem becomes worse, and more files with relative paths appear.

This was an issue with gulp-useref and was solved here https://github.com/jonkemp/gulp-useref/issues/82#issuecomment-294712999


[BUG] Drop annotations with NaN onset in EEGLAB raw files

Reference issue
Fixes #12425.
What does this implement/fix?
Fix bug where MNE cannot handle EEGLAB events with NaN annotations
Additional information
Rationale for decision from EEGLAB documentation:

https://eeglab.org/tutorials/04_Import/Importing_Event_Epoch_Info.html

@cbrnr Should be fixed now!

I would not add a new dataset, but can you add a test with some artificially generated markers that demonstrate the problem (and verify the fix)?

I would not add a new dataset, but can you add a test with some artificially generated markers that demonstrate the problem (and verify the fix)?

Would I have to make a temp file @cbrnr? Because from my understanding, I would have to read a MATLAB .set file then edit the annotations. Then I would need to read the file again to check to see if it drops the bad annotations. Can you think of another way?

Hm, yes, because the fix is in the reader it's probably easiest if you add a small(!) test file then.

EDIT3: Yeah, since MATLAB files are stored as a binary and the _read_annotations expects a MATLAB file. I think I would have to read the MATLAB file, then edit the annotations, then re-export it as a binary.

Can you try this and see if it's easy? If it's old format then scipy.io functions can be used. If it's new format then h5py could perhaps be used directly just to change one or two entries and save to a tmpdir?

I can try @larsoner should I just use the tempfilelibrary?

No in tests typically you use the pytest test fixture def test_something(tmp_path): and write for example in the test with open(tmp_path / "my_file.txt', 'w'): or similar.

Should be good now @larsoner and @cbrnr. Thanks!

There is an error related to testing. Not sure what the problem is. When I ran it locally it passed:

That's a weird error -- I put a little fix in #12491 so ignore it for now and we'll merge that quickly and merge main into your branch afterward to make sure everything is green

Just a couple of minor things, committed and marking for merge-when-green, thanks @withmywoessner !

Pip-pre is unrelated, merging!