Containerize Django Application

Changes proposed

[x] Add patient stats graph - 7272e1935e15f98247c2553589d4774d51738441
[x] Added CodeCov integration. - 0bea23d4b874683cf1210f974c4ec42c785dc019
[x] Containerized django application. - 5675e1841f013757a1ca37c5355fc37fb6511abb
[x] Added a github action to deploy via container registry to heroku. - c48fd45a49bcfadf060aa757745ed8e67b4daf94

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] My Code require a change in the GitHub actions.
[x] I have updated the GitHub actions accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers
It should work fine, fingers crossed 🤞🏼.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7ef47d7). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #74   +/-   ##
=========================================
  Coverage          ?   74.10%
=========================================
  Files             ?       50
  Lines             ?      645
  Branches          ?        0
=========================================
  Hits              ?      478
  Misses            ?      167
  Partials          ?        0

Flag
Coverage Δ

unittests
74.10% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef47d7...c48fd45. Read the comment docs.


Reducing the craziness in SoundCloud provider (don't Regex All the Things)

Old Way:

Get permalink URL from user
Download the target HTML page
Grep for ID
Manually build iframe html

New Way:

Get permalink URL from user
Query SoundCloud's OEmbed Endpoint with that URL
Return Title and iframe code, nicely provided in JSON response from SoundCloud
Profit!

2 questions:

What does this do that's better?
Why are you using making the request using a task?

@davidfowl

Are you saying you don't see anything wrong with downloading an entire webpage (intended to be presented to the user, thus including everything), and greping over it (twice) to get what you want, when there is api available for the exact purpose? Memory and speed savings are the wins here.
Just following standard practice in JabbR, that is how this is handled upstream (see ResourceProcessor.ExtractResource). The entire Provider architecture is based on a flawed assumption that the URL that the user supplies is the one we will always fetch. In case of SoundCloud, user's URL is a parameter, so I have to redo the work that was done in ExtractResource (you'll see I do the same thing).

Memory and speed savings seriously? Did you measure anything?
Anyways, I'm not saying that you're change ins't good I just wanted know if you were just re-factoring and having it work the same way.
One thing we could do is make the external web request Lazy so content providers that don't need it don't end up making the initial request.


Add developer documentation

This makes it obvious exactly how others can contribute and can include things like the contribution guidelines, commit styles etc.
https://brainglobe.info/community/developers/index.html

This should include things like the commit lint applies to this repo


Building a mod for an older version

How can i build a mod for an older version of Geometry Dash (2.204) and Geode (2.0.0-beta.27). I installed sdk for needed Geode version and binaries, but when i try to build it says:
  No valid loader binary to link to! Install pre-built binaries with `geode
  sdk install-binaries`, or build Geode from source and add
  `set(GEODE_LINK_NIGHTLY ON)` to your CMakeLists.txt in the line before
  calling add_subdirectory for Geode.

Is this a arch linux related issue?
(Sorry for my english)

It builds just fine for latest version of geode

try running geode sdk install-binaries

try running geode sdk install-binaries

I already did

Then can you give me the following:

Output of geode sdk version
Contents of your Documents\Geode\bin folder

Oh, i fixed it, no need for help anymore, but thanks anyway!


Set column to None; allow access when real field has no value.

Should fix #2.

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           71        71
=========================================
  Hits            71        71

Impacted Files
Coverage Δ

django_hashids/field.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31079ae...14f549c. Read the comment docs.


Fix for 0.47 Breaking Change with createJSModules Override

Fix for a breaking change made in react native 0.47 "Remove unused createJSModules calls"

@fov42550564 Please merge this and publish?

+1

Please has this been merged? I'm having issues with this and the change doesn't reflect in the code

It hasn't been merged yet :(

vote for this.  we need this. :(


Add support for dependency injection

Maybe this https://packagist.org/packages/php-di/invoker

Work done in https://github.com/matapatos/wp-fastendpoints/pull/7


Broken INTERNAL link in impersonate/*

What happened?
Requested URL: /favicon.ico
Was not found.

Resolved in previous commit


Function can return super class as result instead of defined type

The following example compiles fine, gives however runtime type errors:
class SuperClass {}

class SubClass extends SuperClass {}

SubClass getSubClass() {
  SuperClass test = SuperClass();
  return test;
}

This fails (correctly) if SuperClass is returned directly (The constructor returns type 'SuperClass' that isn't of expected type 'SubClass'.dart(strong_mode_invalid_cast_new_expr)):
SubClass getSubClass() {
  return SuperClass();
}

I detected this behavior when returning an Iterable where a Set was defined as return type:
Set<String> getNames() {
  return data.map((element) => element.name);
}

Dart SDK Version (dart --version)
Dart VM version: 2.2.1-dev.0.0 (Wed Feb 27 18:37:05 2019 +0100) on "macos_x64"

This is expected behavior.
Dart allows a statically superclass-typed value to be used where a subclass is expected, the compiler automatically inserts an "implicit downcast".
It does mean that you get run-time errors rather than compile-time errors when you do such a down-cast, and the value ends up not being of the subclass type anyway.
The reason it is caught for return Superclass() is that the compiler is slightly more clever for a few expressions where it knows the exact type of a value. Since Superclass is a generative constructor, the compiler knows that the result of Superclass() is never an instance of Subclass.
When you assign the value to a variable, that knowledge is lost. The return statement just sees a variable typed Superclass which could contain a value of type Subclass.

Thank you for the explanation. Coming from the Java world, this behavior was a little unexpected.
The above error with the Iterable was only caught when compiling the release code with dart2js (AngularDart). During development the type error did not appear.
This would mean that I could have a Set that was an Iterable and that could contain the same value multiple times, right?

If your value was an iterable and not a set, then it can contain the same element more than once, yes. You also can't add anything to it.
The development compiler is probably skipping some type tests for performance, but those tests are there for your protection. The language inserts them in order to prevent accidental run-time type incompatibilities from happening.


FIO-7958: add normalize processor fn and derive context.value rather than mutate it directly

This PR makes a number of updates to fix server side validation in the Form.io Enterprise Server. Among other things, it

adds a "normalize" processor function to mimic the data normalization in the renderer's updateValue method;
no longer mutates a separate context.value property, and instead uses a getter and a setter to derive from the context.data object; and
makes a number of other small changes to ensure compatibility with server side validation in the Enterprise Server.

👍


Locking a website/API

I am currently using lockup to lock a website that is also accessed as API. I have tried using the "?lockup_codeword=love" in the the API call URL but is looks like it is not working as the json payload gets lost on the redirect.
Is there a way to whitelist a server/ip address so that there is no need to use the lockup_codeword redirect?
Thanks

Yeah, nothing about Lockup is currently designed to work with an API or JSON payload.
You can always set up some before filters that skip Lockup.

Thank you @gblakeman for your quick response.
I am trying the skipping method, using this line in the application_controller.rb file:
skip_before_action :check_for_lockup

But the lockup gem is still being triggered, even without adding the before_action :check_for_lockup in any controller.
What am I missing?

Maybe try skip_before_filter instead of skip_before_action? Which one to use depends on your version of Rails.

I have tried with skip_before_filter and skip_before_action, and neither of them skip the check_for_lockup method.
(using Rails 4.1.2)

@jfanals So you can confirm that neither skip_before_action :check_for_lockup nor skip_before_filter :check_for_lockup at the top of application_controller.rb is working for you on Rails 4.1.X?

@gblakeman I confirm that neither of the skip_before_action :check_for_lockup nor the skip_before_filter :check_for_lockup work right after the server has been restarted.
But they do work if I make a change to the application_controller.rb and the ApplicationController code gets re executed.
It looks like a bug.

Yes, it also does not work in staging (where the lockup gem is used).

I created a separate issue for this. Let’s continue any conversation in #39.


[vier] Support new authentication

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.07.02. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2017.07.02

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Description of your issue, suggested solution and other information
site Vier.be worked before. But since website changed, it's not supported anymore, even when supplying userid and password.

F:\Temp>youtube-dl -v https://www.vier.be/video/achter-de-rug/2017/achter-de-rug-seizoen-1-aflevering-6
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.vier.be/video/achter-de-rug/2017/achter-de-rug-seizoen-1-aflevering-6']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2017.07.02
[debug] Python version 3.4.4 - Windows-10-10.0.14393
[debug] exe versions: ffmpeg N-77704-g68eb208, ffprobe 2.2.3
[debug] Proxy map: {}
[generic] achter-de-rug-seizoen-1-aflevering-6: Requesting header
WARNING: Falling back on generic information extractor.
[generic] achter-de-rug-seizoen-1-aflevering-6: Downloading webpage
[generic] achter-de-rug-seizoen-1-aflevering-6: Extracting information
ERROR: Unsupported URL: https://www.vier.be/video/achter-de-rug/2017/achter-de-rug-seizoen-1-aflevering-6
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpcnuqbtg0\build\youtube_dl\YoutubeDL.py", line 762, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpcnuqbtg0\build\youtube_dl\extractor\common.py", line 433, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpcnuqbtg0\build\youtube_dl\extractor\generic.py", line 2824, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://www.vier.be/video/achter-de-rug/2017/achter-de-rug-seizoen-1-aflevering-6

I am still not able to download from vier.be
Not sure if it is due authentication or geo-restrict. Url I try to download:
https://www.vier.be/video/de-slimste-mens-ter-wereld/de-slimste-mens-ter-wereld-seizoen-15/de-slimste-mens-ter-wereld-seizoen-15-aflevering-4
When using username and password.
PS C:\Users\Ruud\Dropbox\Ruud\Installers> .\youtube-dl.exe --username<EMAIL_ADDRESS>--p
assword qAeMdz24Scxw24% https://www.vier.be/video/de-slimste-mens-ter-wereld/de-slimste-mens-te
r-wereld-seizoen-15/de-slimste-mens-ter-wereld-seizoen-15-aflevering-4 --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--username', 'PRIVATE', '--password', 'PRIVATE', 'https://www.vier.be/video/de-slimste-mens-ter-wereld/de-slimste-mens-ter-wereld-seizoen-15/de-slimste-mens-ter-wereld-seizoen-15-aflevering-4', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2017.10.29
[debug] Python version 3.4.4 - Windows-10-10.0.15063
[debug] exe versions: none
[debug] Proxy map: {}
[vier] Logging in
ERROR: Unable to log in: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpk63cqkyt\build\youtube_dl\extractor\common.py", line 503, in _request_webpage
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpk63cqkyt\build\youtube_dl\YoutubeDL.py", line 2195, in urlopen
File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default
Read in some others that authentication is bypassed, so tried without:
PS C:\Users\Ruud\Dropbox\Ruud\Installers> .\youtube-dl.exe --geo-bypass-country BE https://www.
vier.be/video/de-slimste-mens-ter-wereld/de-slimste-mens-ter-wereld-seizoen-15/de-slimste-mens-
ter-wereld-seizoen-15-aflevering-4 --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--geo-bypass-country', 'BE', 'https://www.vier.be/video/de-slimste-mens-ter-wereld/de-slimste-mens-ter-wereld-seizoen-15/de-slimste-mens-ter-wereld-seizoen-15-aflevering-4', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2017.10.29
[debug] Python version 3.4.4 - Windows-10-10.0.15063
[debug] exe versions: none
[debug] Proxy map: {}
[debug] Using fake IP <IP_ADDRESS> (BE) as X-Forwarded-For.
[vier] de-slimste-mens-ter-wereld-seizoen-15-aflevering-4: Downloading webpage
ERROR: Unable to extract filename; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpk63cqkyt\build\youtube_dl\YoutubeDL.py", line 784, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpk63cqkyt\build\youtube_dl\extractor\common.py", line 434, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpk63cqkyt\build\youtube_dl\extractor\vier.py", line 170, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpk63cqkyt\build\youtube_dl\extractor\common.py", line 797, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract filename; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Any help?

Try with my custom version of youtube-dl https://forum.videohelp.com/threads/382423-YoutubeVideoDownloader-download-video-and-audio-from-900-sites
Let me know if that works.

@wernerkarlheisenberg implemented this in #15412

Issue should be closed, URL is dead


WSL2 cannot open variables view for native notebooks

Window is blank:

Get 404 errors on the resources

This is working now


Quick Question about NPC responses.

Is there anyway I could edit the text an NPC says to have it include the questers Name? For instance on completion of the quest the NPC says  "Thanks '@playername' for killing those pesky mobs for me.'

Also, Anytime I try and set an initial event, save the quest and do a reload. It clears the initial event.

That is the "finish message" if I'm not mistaken. You can either edit via commands or go to your quests.yml file.
Please create a new issue with more information for your other problem.


Multiple values separated by a delimiter only?

I'm trying to make an arg that accepts one or two comma-delimited values, and also accept unnamed (index) argument after that.
prog -q 1,2 file # OK: parses as q=[1,2]; input=file

prog -q 1 file # should parse as q=[1]; input=file; but parses as q=[1,file]; input missing

The problem is that multiple arguments allow spaces, which causes ambiguity. I don't know how to disable that.

Currently, there isn't a way to force the use of a delimiter. That is something that could be added.
But there are few other things about this scenario too:  Is there a limit on the number of values for q? Otherwise, prog -q 1,2 file won't parse like q=[1,2]; input=file
I could consider this a bug, so-to-speak. i.e. if a delimiter is present, parsing something after a space probably shouldn't be part of the same value group. This still doesn't help your scenario 2 though. To go along with the above "bug" is parsing something like -q=1 file shouldn't lump file in with -q, but currently does.
So, would solving those two bugs suffice, or would a force_delimiter still be preferred? i.e.

if a delimiter is present, don't parse anything after a space as the same group of values
if a = is present, don't parse anything after a space as the same group of values

This would allow you do -q=1 file and the option of either -q 1,2 file or -q=1,2 file all parsing correctly.
My only issue with the require_delimiter type thing, is it seems somewhat niche assuming the above bugs are fixed. I would assume most people, upon realizing -q 1 file isn't working would try -q=1 file next.

Thank you for your response.
In my case it's strictly 1 or 2 values for q. require_delimiter would be ideal for me, as -q 1 file case is going to be the most common in my program.

#547 implements those two bug fixes and will be uploaded to crates.io as v2.7.1, then I'll add the Arg::require_delimiter in a new PR and upload as v2.8.0 to crates.io to keep all SemVer users aware of changes.

Fantastic! Thank you!

Arg::require_delimiter isn't implemented yet, doing so now :wink:
I want to keep this open just a tracking issue for that, until the PR merges.

This will be fully implemented with #551


Added new example T for temp table creation.

@jzabroski : Thanks for your contribution! The author, @CarlRabeler, has been notified to review your proposed change.

@jzabroski : Thanks for your contribution! The author, @CarlRabeler, has been notified to review your proposed change.

#sign-off

@jzabroski : Thanks for your contribution! The author, @CarlRabeler, has been notified to review your proposed change.


perl534Packages.IOTty doesn't cross-compile

Describe the bug
nix-build -A  pkgsCross.aarch64-multiplatform.perl534Packages.IOTty fails:
these derivations will be built:
  /nix/store/7wmnpdwycwc6al6c71i91k0fq1b8b19y-perl5.34.0-IO-Tty-aarch64-unknown-linux-gnu-1.15.drv
building '/nix/store/7wmnpdwycwc6al6c71i91k0fq1b8b19y-perl5.34.0-IO-Tty-aarch64-unknown-linux-gnu-1.15.drv'...
unpacking sources
unpacking source archive /nix/store/phiymjsipz66gkjibxmbrqzj7js4xinj-IO-Tty-1.15.tar.gz
source root is IO-Tty-1.15
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file IO-Tty-1.15/META.yml
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
patching ./t/test.t...
patching ./t/pty_get_winsize.t...
Can't load module IO, dynamic loading not available in this perl.
  (You may need to build a new perl executable which either supports
  dynamic loading or has the IO module statically linked into it.)
 at /nix/store/98rdfdqc7kax6ipm1jrmyqiacc7264vp-perl-5.34.0-aarch64-unknown-linux-gnu/lib/perl5/5.34.0/aarch64-linux/IO/Handle.pm line 268.
Compilation failed in require at /nix/store/98rdfdqc7kax6ipm1jrmyqiacc7264vp-perl-5.34.0-aarch64-unknown-linux-gnu/lib/perl5/5.34.0/aarch64-linux/IO/Handle.pm line 268.
BEGIN failed--compilation aborted at /nix/store/98rdfdqc7kax6ipm1jrmyqiacc7264vp-perl-5.34.0-aarch64-unknown-linux-gnu/lib/perl5/5.34.0/aarch64-linux/IO/Handle.pm line 268.
Compilation failed in require at /nix/store/98rdfdqc7kax6ipm1jrmyqiacc7264vp-perl-5.34.0-aarch64-unknown-linux-gnu/lib/perl5/5.34.0/aarch64-linux/IO/Seekable.pm line 100.
BEGIN failed--compilation aborted at /nix/store/98rdfdqc7kax6ipm1jrmyqiacc7264vp-perl-5.34.0-aarch64-unknown-linux-gnu/lib/perl5/5.34.0/aarch64-linux/IO/Seekable.pm line 100.
Compilation failed in require at /nix/store/98rdfdqc7kax6ipm1jrmyqiacc7264vp-perl-5.34.0-aarch64-unknown-linux-gnu/lib/perl5/5.34.0/aarch64-linux/IO/File.pm line 132.
BEGIN failed--compilation aborted at /nix/store/98rdfdqc7kax6ipm1jrmyqiacc7264vp-perl-5.34.0-aarch64-unknown-linux-gnu/lib/perl5/5.34.0/aarch64-linux/IO/File.pm line 132.
Compilation failed in require at Makefile.PL line 10.
BEGIN failed--compilation aborted at Makefile.PL line 10.
builder for '/nix/store/7wmnpdwycwc6al6c71i91k0fq1b8b19y-perl5.34.0-IO-Tty-aarch64-unknown-linux-gnu-1.15.drv' failed with exit code 255
error: build of '/nix/store/7wmnpdwycwc6al6c71i91k0fq1b8b19y-perl5.34.0-IO-Tty-aarch64-unknown-linux-gnu-1.15.drv' failed

This seems to be part of the mosh buildInputs, breaking cross-compilation of NixOS closures.
Steps To Reproduce
Steps to reproduce the behavior:

nix-build -A  pkgsCross.aarch64-multiplatform.perl534Packages.IOTty

cc @NixOS/mobile-nixos @NixOS/exotic-platform-maintainers

Still broken.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/cross-compile-nixos-sd-image-for-rasberry-pi-2/20877/1


Create Utility functions

This PR introduces wrappers around AppLauncher.
I think it's nice to have this, because there is one less struct for newcomers to worry about, when they just want to get into creating UIs.
At the same the additional wrapper-code can be expected to remain this simple.
When AppLauncher grows in functionality, people will be pointed to it this way.

While it is nice, imo it is a conflict of responsibilities

This has been unmergeable for about a year now, I'm going to go ahead and close it for now.


Fix a bug in answer() function inside the Xonomy.editRaw()

The following statement is probably not what was intended:
var jsElement=...;
Xonomy.answer=function(val) {
  ...
  var jsElement=parameter.toJs(val, jsElement);
}

The parameter.toJs() function is called with undefined as
a second argument and not with jsElement closure as intended.
Inside the Xonomy.answer() function the jsElement is declared
as a new variable and so the closure value is hidden
in the whole function scope.

That was a silly bug, thanks for catching it.


Docco: Needs es5 shim for IE8

For this to work under IE8, it needs a shim.  Don't know exactly which method, but https://github.com/es-shims/es5-shim makes it come alive :)
You may want to add this ref to the docco.

IE8 finally dead, closing this.


fix:Explore Search: No title bar for item, non-existent menu for item, wrongly-worded menu for category

Description (required)
Fixes #4271
What changes did you make and why?

add toolbar in WikidataItemDetailsActivity
minor change
add javadoc

Tests performed (required)
Tested { ProdDebug} on {name of device :Redmi 4} with API level {25,28}.
Screenshots (for UI changes only)

Codecov Report

Merging #4274 (2f7cf2c) into master (e82fdd0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4274      +/-   ##
============================================
- Coverage     10.40%   10.39%   -0.02%
  Complexity      474      474
============================================
  Files           343      343
  Lines         13069    13085      +16
  Branches       1052     1052
============================================
  Hits           1360     1360
- Misses        11641    11657      +16
  Partials         68       68

Impacted Files
Coverage Δ
Complexity Δ

.../nrw/commons/category/CategoryDetailsActivity.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...xplore/depictions/WikidataItemDetailsActivity.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82fdd0...2f7cf2c. Read the comment docs.

@nicolas-raoul rewiew my this PR

up for review @nicolas-raoul , @neslihanturan

Hey @Prince-kushwaha , thanks for the PR. There are 3 issues in the issue linked (ideally they should have been separated issues).
1- The text "view file page" should be "View category page". (PR solves this)
2- Item should have a tree dot menu containing "View item page" (PR solves this)
3- Adds toolbar to media item when it is selected from search->item (PR solves this)
So I am good to merge this PR as soon as the minor string naming issue is solved, thanks :)


Fix LabelExpression constructors when using array or collection

Impact

[x] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Fixes #4763
Having a changeset like the one below:
<changeSet author="Liquibase" id="labelExpressionIssue" labels="foo">
        <!-- GOOD CHANGE -->
        <createTable tableName="TABLE_1">
            <column name="COL1" type="INT"/>
        </createTable>
    </changeSet>

When a LabelExpression is defined as:
new LabelExpression(new String[]{"bar", "test"})

or:
new ArrayList<>(List.of("bar, test"))

What was happening was that labels were ignored and changesets were deployed anyway.

Things to be aware of

Things to worry about

Additional Context

This change looks good to me.  I think this issue escaped us because that constructor is only used in tests internally.

Done, I have applied the same logic to ContextExpression. I'm going to create a DAT ticket to apply the constructor refactoring Steve mentioned.
cc: @suryaaki2
Thanks,
Daniel.


Conflicting method/path combination for action - Swagger unable to distinguish alternate version from Route

I have the following controller setup in my solution:
[Route("api/v{VersionId}/[controller]")]
[Produces("application/json")]
[Consumes("application/json")]
public class MyBaseController : ControllerBase
{
}

[ApiVersion("1.0")]
[ApiVersion("1.1")]
public class AuthenticationController : MyBaseController
{
    private readonly ILoginService _loginService;

    public AuthenticationController(ILoginService loginService)
    {
        _loginService = loginService;
    }

    [ProducesResponseType(StatusCodes.Status200OK)]
    [ProducesResponseType(StatusCodes.Status403Forbidden)]
    [ProducesResponseType(StatusCodes.Status404NotFound)]
    [ProducesResponseType(StatusCodes.Status500InternalServerError)]
    [ProducesResponseType(StatusCodes.Status400BadRequest)]
    [HttpPost("login")]
    public ActionResult<v1.JwtTokenResponse> Login([FromBody] v1.LoginRequest loginRequest)
    {
        var loginResult = _loginService.Login(loginRequest.Email, loginRequest.Password);
        if (loginResult.StatusCode != HttpStatusCode.OK)
        {
            return StatusCode((int)loginResult.StatusCode);
        }

        var tokenResponse = new v1.JwtTokenResponse() { Token = loginResult.Token };

        return Ok(tokenResponse);
    }
}

Between the two versions of my API, nothing has changed for this method and so logically in my documentation I want to display that the method is still supported in the new version. Let's argue that we have a second controller of customer that has had some changed logic and hence is the reason why we have the new version 1.1 as semantic versioning dictates something new has been added but in a backwards compatible manner.
When running this code, naturally everything builds fine. The code is valid and .net core allows this sort of implementation however, when it comes to the swagger gen I am hitting issues with it producing the following error:
NotSupportedException: Conflicting method/path combination "POST api/v{VersionId}/Authentication/login" for actions - Template.Api.Endpoints.Controllers.AuthenticationController.Login (Template.Api.Endpoints),Template.Api.Endpoints.Controllers.AuthenticationController.Login (Template.Api.Endpoints). Actions require a unique method/path combination for Swagger/OpenAPI 3.0. Use ConflictingActionsResolver as a workaround

As you can see above, the path is different because the version parameter passed into the route makes it that way. Furthermore, it does not make sense to create a brand new method purely to represent that the code is available through documentation so, my question is why is swagger ignoring the version differences in the path and suggesting the use of the ConflictingActionsResolver?
Furthermore, after digging into this further and seeing that a lot of other people were having the same issue as far back as 2017 the general approach seems to be to using the conflicting actions resolver to only take the first description it comes across which would only expose version 1.0 in the api documentation and leave out the 1.1 version giving the impression in Swagger that there is no 1.1 version of the endpoint available.
Swagger UI Config

app.UseSwaggerUI(setup =>
{
   setup.RoutePrefix = string.Empty;

   foreach (var description in apiVersions.ApiVersionDescriptions)
   {
      setup.SwaggerEndpoint($"/swagger/" +
                            $"OpenAPISpecification{description.GroupName}/swagger.json",
                            description.GroupName.ToUpperInvariant());
   }

});

How can we get around this and correctly display available endpoints in Swagger without having to create new methods that effectively result in a duplication of code just to satisfy what seems like an oversight in the Swagger spec? Any help would be greatly appreciated.
N.B. Many may suggest appending action on to the end of the route however we wish to avoid this as it would mean our endpoints are not restful where we want to strive for something like customers/1 with the GET, POST, PUT attributes deriving the CRUD operations without having to append something like customers/add_customer_1 or customers/add_customer_2 reflecting the method name in the URL.

Can you please share your Startup.cs. I have a feeling you may not have the API Versioning library wired up correctly to work with Swashbuckle. Have you followed these steps from that library:
https://github.com/microsoft/aspnet-api-versioning/wiki/API-Documentation#aspnet-core
The exact scenario you've described should work with no problem. In fact, there's a "MultipleVersions" sample app in the Swashbuckle repo that covers a a very similar scenario to what you've described and it works just fine.

Closing due to inactivity


PoC: Group by

really rough initial start at group by poc
TODO:

[ ] Provide selected group by dimensions to DataQueryRequest in SceneQueryRunner (similar to how filters are provided via subscription). This requires updating the type in core Grafana to accept groupBy dimensions on the DataQueryRequest.
[ ] Implement tests
[ ] Implement AdHocAggredationVariable

@ashharrison90  - I've added some todos to make this mergable.

@dprokop did you forget to apply the TODOs? i don't see them 😅


[release-1.0] enable live migration with dedicated cpus and isolated emulator thread

Manual cherry-pick of https://github.com/kubevirt/kubevirt/pull/9722.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

NONE

I don't know if there will be conflicts with https://github.com/kubevirt/kubevirt/pull/11012
/lgtm

I don't know if there will be conflicts with #11012 /lgtm

Let's see if this passes all tests before that one, in that case we'll hold #11012

/retest-required

/test pull-kubevirt-goveralls

@acardace how can this be a manual cherry pick of https://github.com/kubevirt/kubevirt/pull/9722, which has only 2 changed files with a couple of lines removed?

I would at least expect some explanation which backports had to be made additionally in the PR description, so people can follow along.

I would at least expect some explanation which backports had to be made additionally in the PR description, so people can follow along.

It wasn't an additional backport, I just had to run make generate separately and I did a separate commit for that so that it's pretty clear that this is a backport + make generate.

I would at least expect some explanation which backports had to be made additionally in the PR description, so people can follow along.

It wasn't an additional backport, I just had to run make generate separately and I did a separate commit for that so that it's pretty clear that this is a backport + make generate.
https://github.com/kubevirt/kubevirt/pull/11015/commits

Thank you for clarifying, and I'll take the blame of not backporting the year removal fix :(


Update _magic.py

This basicmove to setuptools, so way still be able to do the wheel on python-3.12.
next change would be a pyproject.toml


VPC_SG_OPEN_ONLY_TO_AUTHORIZED_PORTS

AWS managed rule: VPC_SG_OPEN_ONLY_TO_AUTHORIZED_PORTS
is using

authorizedTCPPorts instead of authorizedTcpPorts
authorizedUDPPorts instead of authorizedUdpPorts

Is there any update on this?
as the naming of parameters are not consist with documentation...

Hey there, this code is not the AWS managed rules code, it is only a sample. If you are you looking for the managed rule code, may I ask you why?

Hey there, this code is not the AWS managed rules code, it is only a sample. If you are you looking for the managed rule code, may I ask you why?

I think it is AWS managed rules code, as it is present on the below page?
https://docs.aws.amazon.com/config/latest/developerguide/managed-rules-by-aws-config.html

I can confirm you that it is not the code of the managed rule. I understand that there is the disparity with the managed rule, but they are not related.


Allow OR with multiple filters

It's possible to use multiple filters by running something like:
terraformer import aws --resource iam --filter="Name=role;Value=role1:role2" --filter="Name=name;Value=name1:name2"
Specifically, in this example, the iam resource actually imports several resources, including aws_iam_policy and aws_iam_role_policy_attachment. In aws_iam_policy there is a field named name and in aws_iam_role_policy_attachment there is a field named role. Unfortunately, the above command will return 0 results because terraformer requires all filters to be true to allow a resource to be imported and neither of these resources has both name AND role.
It would be cool if there was a way to specify an OR relationship in cases like this to allow for the desired outcome. I don't have a proposal for how to achieve this at the moment. I might be wrong about how I'm understanding this also, so let me know if what I want here is achievable and if not, what a good way to implement this might be. Thanks

This would be a very helpful feature

this is interesting


[5.3] Remove 5.5 bug workaround

This was a workaround for a bug in PHP <= 5.5.13, but was fixed in PHP 5.5.14.
Since we're dropping support for 5.5, there's no reason for this workaround anymore.

:+1:

:+1:

Incredible, I really did not know it was a bug :smiley: what really made no sense due to the fact of being in the same context.

@anteriovieira I had it right there in the comments:
Since some versions of PHP have a bug that prevents it from properly
binding the late static context in a closure, we will first store
the model in a variable, which we will then use in the closure.

I don't know how it could have been any clearer than that.

:smile:  yes is clear. But I did not see this review before. I had only seen this function superficially.


GIX-1481: Get latest reward event NNS Governance

Motivation
Add endpoint to get the latest reward event of the NNS Governance
Changes

New endpoint in NNS Governance lastestRewardEvent.
Update nns-js candid interfaces. Only changes in governance canister.

Tests

Add test for new endpoint.

@dskloetd @peterpeterparker please review

I don't understand this code but I'm approving because it looks like mostly safe boilerplate within the context. Would be good if you can explain it some time.

This is related to this issue: https://dfinity.atlassian.net/browse/GIX-1481
That will give you the context to understand this change.


import Error

There has an error  'ImportError: cannot import name 'BayesianOptimization'.
But, I have installed this package successfully.
So, I didn't find the solution about this question.
Please , help!

same error :(

Still error when I try from bayes_opt import BayesianOptimization


Google Calendar Resources

On December 15, the old GDATA Calendar Resource API was replaced by a new Calendar Resource API, part of the Admin SDK’s Directory API  (http://googleappsdeveloper.blogspot.be/2015/12/introducing-new-calendar-resource-api.html)
As far as I see, this open some possibilities for solving https://github.com/google/google-api-php-client/issues/206, and allow to manga ressources from php-client.
Is there any plan to implement this?
Kind regards,

This will be added in #835

this has now been merged into the master branch

Thanks, it works like a charm !
$client = new \Google_Client();
$client->useApplicationDefaultCredentials();
$client->setScopes(['https://www.googleapis.com/auth/admin.directory.resource.calendar','https://www.googleapis.com/auth/admin.directory.resource.calendar.readonly']);
$client->setSubject('user@domain.com');
$directoryService = new \Google_Service_Directory($client);

$resources = $directoryService->resources_calendars->listResourcesCalendars('my_customer')->getItems();

@lfroidmo , I got below error
Fatal error: Call to undefined method Google_Client::setSubject() , There is no method into Google_Client.php


Fix post-process bug & Small fixes

Fix bugs in the common variable conversion routines for post-process where the wrong indices were being used:

#ifdef MFC_POST_PROCESS
        rho_sf(i, j, k) = rho
        gamma_sf(i, j, k) = gamma
        pi_inf_sf(i, j, k) = pi_inf
#endif

instead of
#ifdef MFC_POST_PROCESS
        rho_sf   (j, k, l) = rho
        gamma_sf (j, k, l) = gamma
        pi_inf_sf(j, k, l) = pi_inf
#endif

Here i was just a generic loop iterator.

Remove the requirement to specify case_dir. All cases set it to . because mfc.sh just runs mfc from within the case directory. This user input was probably useful when mfc was still using the master_scripts setup for running jobs. It may confuse users more than it benefits them to have to included. The default is now ..

Removed unnecessary whitespace and \ (at the end of lines) in example cases.

Fixed a few other small issues like

        real(kind(0d0)), parameter :: alpha_mp = 2d0
        real(kind(0d0)), parameter :: beta_mp  = 4d0/3d0

never being declared.

Can we create tests to ensure bugs like this don't go unnoticed in the future?

We could perhaps just post-process all test cases (without checking results). This bug resulted in the process aborting so it would have been caught in this way. What do you think? If you agree, should this be the default behavior of ./mfc.sh test ?

We could perhaps just post-process all test cases (without checking results). This bug resulted in the process aborting so it would have been caught in this way. What do you think? If you agree, should this be the default behavior of ./mfc.sh test ?

Yes I think that would be good (to try out at least). An additional test is an h5dump on the HDF files and doing a grep for NaNs (and ensuring that the files even exist). Perhaps you can find more clever ideas as well.


Update readme

A live preview is being deployed!Please note that it may take a few seconds for GitHub Pages to build and deploy. The preview will be removed in a few days.


peercoin testnet object

I think dart dislikes variables with dashes

What about this?

Surprised the linter didn't complain. This is valid now but camelCase is usually enforced

I'm pythonista, camel case is sacrilege for us.


libc++abi.dylib: Pure virtual function called!

Does anyone else get this error?
libc++abi.dylib: Pure virtual function called!
Occurs during playback, sometimes happens on the first song, sometime happens a few songs in. Seems very random and I cannot force it to happen. This happens if I am using headphones or the build-in speaker.
I am also sometimes getting "Segmentation Fault 11". I really want to be able to use this but is seems very buggy at this point.
OSX 10.10.1
Node v0.10.35

It must be just my issue, ill close this.

I'm also getting these errors.
OSX 10.11
Node v0.12.2

I also get this error
OSX 10.11
Node v6.3.0


Update ElectRS to 0.8.3

https://github.com/rootzoll/raspiblitz/pull/1175

Also ElectRS is now served over HTTPS with nginx.

[ ] retest ElectRS over HTTPS

Electrs 0.8.5 is out (improves Electrum 4.0 compatibilty)
https://github.com/romanz/electrs/blob/master/RELEASE-NOTES.md

OK ElectRS is update

[ ] retest ElectRS over HTTPS

Hi, how can I update my raspiblitz to have the ElectRS 0.8.5?

@ogas2 ElectRS 0.8.5 will be part of RaspiBlitz v1.6 release. There is already a RC3 available for v1.6 ... but if its just recommended for test nodes: https://github.com/rootzoll/raspiblitz/blob/v1.6/README.md#downloading-the-software
Final v1.6 will be out within next week hopefully.

Not sure how to test the https (electrum just eat sthe https string) .. but it installs after recovery/update. Will be part of v1.6. Closing issue.


Refactor

This PR includes macros for defining fields for estimator structs, fixes the type instability when estimating causal effects for G-computation and S-learning, decouples estimating causal effects for double machine learning and R-learning, adds doctests where practical, gets rid of unnecessary constructors, and ensures code complies with Aqua.jl and Blue recommendations.

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Make sure clap doesn't ship unless the binary feature is enabled

Awesome! However, it also makes it a bit harder to use as a stand-alone project:
$ cargo run
error: target `jan` in package `splaycompress` requires the features: `binary`
Consider enabling them by passing, e.g., `--features="binary"`
[$? = 101]

Is there a way to automatically turn the binary feature on by default, without making it a default for library users?

Unfortunately there's not an easy way to do that. One thing we could do is make jan a separate repo, if you'd like. We could also restructure the repo such that the whole thing is jan and then a workspace contains splaycompress, but that would be a big change that I didn't want to make, and would also require renaming the repo to keep names in sync.


basis nworkers error

Changing nworkers=1 to anything above 1 in the basis.json file causes the following error for any molecule I try it on:
====== Iteration 0 ======
Calculating 15 systems on
LocalCluster(d5f9cd8d, 'tcp://<IP_ADDRESS>:42955', workers=2, threads=2, memory=16.70 GB)
Traceback (most recent call last):
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/distributed/worker.py", line 3398, in dumps_function
    result = cache_dumps[func]
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/distributed/utils.py", line 1523, in __getitem__
    value = super().__getitem__(key)
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/collections/__init__.py", line 991, in __getitem__
    raise KeyError(key)
KeyError: <function in_private_dir.<locals>.wrapper_private_dir at 0x7f66774bd950>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/distributed/protocol/pickle.py", line 49, in dumps
    result = pickle.dumps(x, **dump_kwargs)
AttributeError: Can't pickle local object 'in_private_dir.<locals>.wrapper_private_dir'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/awills/anaconda3/envs/nxc/bin/neuralxc", line 7, in <module>
    exec(compile(f.read(), __file__, 'exec'))
  File "/home/awills/Documents/Research/neuralxc/bin/neuralxc", line 266, in <module>
    func(**args_dict)
  File "/home/awills/Documents/Research/neuralxc/neuralxc/drivers/model.py", line 209, in sc_driver
    kwargs=engine_kwargs)
  File "/home/awills/Documents/Research/neuralxc/neuralxc/preprocessor/driver.py", line 141, in driver
    results = calculate_distributed(atoms, app, dir, kwargs, nworkers)
  File "/home/awills/Documents/Research/neuralxc/neuralxc/preprocessor/driver.py", line 106, in calculate_distributed
    [app] * len(atoms), [kwargs] * len(atoms))
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/distributed/client.py", line 1774, in map
    actors=actor,
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/distributed/client.py", line 2542, in _graph_to_futures
    dsk = dsk.__dask_distributed_pack__(self, keyset)
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/dask/highlevelgraph.py", line 939, in __dask_distributed_pack__
    client_keys,
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/dask/highlevelgraph.py", line 392, in __dask_distributed_pack__
    dsk = toolz.valmap(dumps_task, dsk)
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/toolz/dicttoolz.py", line 83, in valmap
    rv.update(zip(d.keys(), map(func, d.values())))
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/distributed/worker.py", line 3436, in dumps_task
    return {"function": dumps_function(task[0]), "args": warn_dumps(task[1:])}
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/distributed/worker.py", line 3400, in dumps_function
    result = pickle.dumps(func, protocol=4)
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/distributed/protocol/pickle.py", line 60, in dumps
    result = cloudpickle.dumps(x, **dump_kwargs)
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/cloudpickle/cloudpickle_fast.py", line 102, in dumps
    cp.dump(obj)
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/cloudpickle/cloudpickle_fast.py", line 563, in dump
    return Pickler.dump(self, obj)
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/pickle.py", line 409, in dump
    self.save(obj)
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/pickle.py", line 476, in save
    f(self, obj) # Call unbound method with explicit self
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/cloudpickle/cloudpickle_fast.py", line 745, in save_function
    *self._dynamic_function_reduce(obj), obj=obj
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/cloudpickle/cloudpickle_fast.py", line 682, in _save_reduce_pickle5
    dictitems=dictitems, obj=obj
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/pickle.py", line 610, in save_reduce
    save(args)
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/pickle.py", line 476, in save
    f(self, obj) # Call unbound method with explicit self
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/pickle.py", line 751, in save_tuple
    save(element)
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/pickle.py", line 476, in save
    f(self, obj) # Call unbound method with explicit self
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/pickle.py", line 736, in save_tuple
    save(element)
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/pickle.py", line 476, in save
    f(self, obj) # Call unbound method with explicit self
  File "/home/awills/anaconda3/envs/nxc/lib/python3.6/site-packages/dill/_dill.py", line 1169, in save_cell
    f = obj.cell_contents
ValueError: Cell is empty

The error occurs when trying to pickle a function that was modified by a decorator. This only occurred in for certain versions of pickle (and "dill"). I removed the decorator which should fix the issue.


(3.7.0) Creating dev profile results in non-interactive level 3 weapon wall

Items cannot be placed on wall

Originally written by chomp

Fixed with: https://dev.sp-tarkov.com/SPT-AKI/Server/commit/b8239e253ebc931803f99db6363a23fb3979a951

Originally written by chomp


Noisy imagenette more info in new folder

@hamelsmu: As we discussed on Discord, I have added a separate folder with more information about the dataset (label generation, extended LB).
Should I also edit the Imagenette README mentioning the update to the Imagenette dataset and introducing the noisy Imagenette dataset/LB? Or will that be done later?

Yeah I think updating the README is a good idea.  Make sure to mention which information is optional given we are only showing certain noise levels etc

@hamelsmu Let me know if this is fine, or if you think something needs to be more clear...

@hamelsmu Thank you for your suggestions! I have added more detail to generate_labels.ipynb, renamed the folder, and updated the READMEs. Let me know if there are more changes you think need to be made...

LGTM


Branch 136481222

See merge comments, proper merge of the tensorflow/examples/skflow/BUILD wrt resnet.

Superceded by #5047, which includes the cmake fix.


Fixed a bug where NdotV can be >1.0

Fixed a bug where NdotV can be >1.0 resulting in a black spot if used with the diffuse term from "Disney implementation of diffuse from Physically-Based Shading at Disney" by Brent Burley.
vec3 diffuse(PBRInfo pbrInputs)
{
    float f90 = 2.0 * pbrInputs.LdotH * pbrInputs.LdotH * pbrInputs.alphaRoughness - 0.5;

    return (pbrInputs.diffuseColor / M_PI) * (1.0 + f90 * pow((1.0 - pbrInputs.NdotL), 5.0)) * (1.0 + f90 * pow((1.0 - pbrInputs.NdotV), 5.0));
}

The term 1.0-pbrInputs.NdotV will become negative.

I think I've seen that black spot... Do you know how to reproduce it?

/cc @snagy NdotV seems odd with its lack of clamping when a number of parameters surrounding it are clamped.  Was this intentional?

Current implementation uses this code for diffuse:
vec3 diffuse(PBRInfo pbrInputs)
{
    return pbrInputs.diffuseColor / M_PI;
}

If we go to https://github.com/KhronosGroup/glTF-WebGL-PBR and replace the code above with this fragment
vec3 diffuse(PBRInfo pbrInputs)
{
    float f90 = 2.0 * pbrInputs.LdotH * pbrInputs.LdotH * pbrInputs.alphaRoughness - 0.5;

    return (pbrInputs.diffuseColor / M_PI) * (1.0 + f90 * pow((1.0 - pbrInputs.NdotL), 5.0)) * (1.0 + f90 * pow((1.0 - pbrInputs.NdotV), 5.0));
}

The black circle will appear.


sdl: events: Fix DropEvent stubs #294

SDL_DROPTEXT, SDL_DROPBEGIN, and SDL_DROPCOMPLETE are available since SDL 2.0.5, not 2.0.4.

This change is

Thanks! Weird that it doesn't fail during the build on Travis since it's always using SDL 2.0.0. Gonna have a look at that later!

It doesn't fail because this constants are substituted with the stubs on 2.0.0. The problem appeared when SDL 2.0.4 was checked against >= 2.0.4, the check passed and  constants were not substituted, but they are not present in this version.

Ah I see. Guess the builds have to be made more rigorous then.


Adds Login page

Adds login page;
Fetches safira token if credentials valid;
Shows pop up if credentials invalid;
Token is not being saved in the device for a future login or requests(will be worked on in the future);
Introduces modularity into the app.

I would put the .env.sample in the nativemoon folder instead, but let us see what the others have to say.

I would put the .env.sample in the nativemoon folder instead, but let us see what the others have to say.

I agree with @herulume :point_up:

I would put the .env.sample in the nativemoon folder instead, but let us see what the others have to say.

I agree with @herulume

Done


Hotstar clone

Hello Sir/Ma'am,👋
I have added the  Hotstar Clone project to the Issue. Please take a look in the PR & review it & please merge it.🙏

@apu52 please create a README.md file in your project and mention issue no. and attach working video here in conversation section.

@shubhisingh184 Ma'am I have made the README file(with issue no.) & also added the video of the project. Please review and merge it.🙏

@shubhisingh184 ma'am can you please merge it?? It is not merged yet

@apu52 please mention issue number..

#436**Issue no. ** @shubhisingh184 @Vikash-8090-Yadav

#436Issue no. @shubhisingh184 @Vikash-8090-Yadav

The issue no is #430 not 436 please correct it.

#430**Issue no. ** @shubhisingh184 @Vikash-8090-Yadav

#430**Issue no. ** @shubhisingh184 @Vikash-8090-Yadav

Sorry for the inconvenience

@apu52  please correct it in README.md file too.

Yes.I am correcting it

@shubhisingh184 @Vikash-8090-Yadav I have updated the Issue no. #430 in the README.md file .please check it. Please merge my PR🙏.
Sorry for the inconvenience.


Result not good on custom data.

Hi, did you test the code on the custom data processed by neus tutorial? I cannot get right mesh using this project. Thanks very much.

Hi @YiChenCityU, in my work I mostly deal with synthetic data, where I know ground truth camera matrices, so I have not tried running the code on custom data. Are you sure you are getting the right outputs from COLMAP? For instance, something I have encountered a few times is that COLMAP will discard most of the provided views.
If your COLMAP outputs are OK, then I don't know what could be wrong. Is any mesh generated at all? How long have you trained for? Are you getting good renderings despite bad mesh quality?
That being said, someone produced a similar codebase to this repo (instant-nsr-pl), which seems to have gained a lot of traction. I have tried it and it looks more robust and overall better. That's why for the sake of your time, especially since I have not tried custom data on this codebase, I encourage you to try out that repo and see if it fits your needs.


[$250] LHN:  Emoji is misaligned with message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.68-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tgolen
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714492986409729
Action Performed:

Send a message with emoji from A to B
Login as B and observe the LHN

Expected Result:
There is no misalignment with emoji
Actual Result:
Emoji is misaliged
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d8085509ba977455
Upwork Job ID:<PHONE_NUMBER>151866880
Last Price Increase: 2024-04-30

Issue OwnerCurrent Issue Owner: @mananjadhav

Proposal
Please re-state the problem that we are trying to solve in this issue.
LHN: Emoji is misaligned with message in focus mode
What is the root cause of that problem?
When we are in focus mode we are showing the content of each conversation in the same line, this makes the content try to fit but we are also adding an unnecessary line height and min height which cause the misalignement.
What changes do you think we should make in order to solve the problem?
We should remove the line height and min height when user is in focus mode from OptionRowLHN component, like:
const alternateTextStyle = isInFocusMode
        ? [textStyle, styles.textLabelSupporting, styles.optionAlternateTextCompact, styles.ml2, style]
        : [textStyle, styles.optionAlternateText, styles.textLabelSupporting, style];

Testing the change in IOS:
https://github.com/Expensify/App/assets/5216036/1d03faa1-07ca-4952-a817-4dffbe1c0c7a
Testing in other platforms:
Android Chrome:

Android:

IOS Safari:

Mac Chrome:

Please re-state the problem that we are trying to solve in this issue.
LHN: Emoji is misaligned with message in focus mode
What is the root cause of that problem?
Currently, we've observed that emojis within the LHN can appear misaligned when users are in focus mode. This misalignment not only affects the visual consistency of the interface but also may lead to usability issues, particularly for users who rely on visual cues for navigation.
What changes do you think we should make in order to solve the problem?
adjusting the lineHeight property from its current value to a slightly larger value. By increasing the lineHeight, we ensure that there is adequate vertical spacing between lines of text, including emojis, thereby improving their alignment within the LHN.
https://github.com/Expensify/App/blob/57d2aee42ecc04d196cb3f86730b30415969836c/src/styles/index.ts#L1832
we can use this
 lineHeight: variables.lineHeightXXXLarge,
ScreenShot:-

@mananjadhav, please review the proposals above. Thanks!

Hmm I would think the emoji should just have the same line height as the text that is next to it, no?

Yeah I also assumed that would fix the issue

Hi @shawnborton and @dubielzyk-expensify,
It would be good to know what the target is, because it looks like the one reported here is for this misalignment:

After my proposal I put all the content text in the same line height:

Even in gmail emoticons can cause the effect of needing more line height depending on which one it is, see this:

Also even here in github (I think this should be the correct alignment):
Hello 🏰
This is not noticeable in emoticons such as 😄:
Hello 😄
Hello 🏰😄

@shawnborton raises an important consideration regarding the alignment of emojis with adjacent text. While initially, both text height and lineHeight were set to the same values, we encountered issues with misalignment. Despite having the same line height as the adjacent text, emojis may still appear misaligned due to variations in rendering, inherent size differences, and platform-specific rendering behaviors.

I agree that this one is the correct alignment I would expect - and it looks like the emoji is not getting any special kind of line height or anything like that, it just follows whatever is being applied on the p element:

@mananjadhav, can you please provide an update? Thanks!

Not overdue.

Waiting for @mananjadhav to update.

I don't see any proposals that solve this in an accurate way. I agree that Emojis being rendered different on platforms, apps and devices. But if the expectation is that the emoji should pick the line height of the given<p> tag, we are looking at proposals to solve this instead of updating the line height for generic style.

Hi @mananjadhav, is there any visual example of how this should look like, it could be from another platform just to get an idea.

@samilabud It's added here in the previous comment.

@samilabud It's added here in the previous comment.

Got it, I think that was added based on my proposal, isn't it?

@mananjadhav, can you please provide an update? Thanks!

I think I am going to reassign this one.

@ikevin127 is taking this over.

can you please provide an update? Thanks!

I will review proposals today and provide an update by EOD (PST timezone).

@kaushiktd Your RCA does not clearly state the root cause of the issue, instead it's more of an observation. As for the proposed solution I agree with https://github.com/Expensify/App/issues/41367#issuecomment-2089054405, that we sould not change the global styles.optionAlternateText style as this could lead to regressions across the app in all the other 6 components where the style is used.

@samilabud's proposal looks good to me and tests well.
The RCA is correct in the sense that for isInFocusMode true we're adding the same styles.optionAlternateText as for the most recent mode (not focus mode).
Based on my tests, the proposed solution of removing the styles.optionAlternateText styles only for isInFocusMode true seems to fix the issue on iOS: Native (see diff screenshots below) based on design team input here, and it does not seem to affect the UI on any of the other platforms when isInFocusMode is true.

iOS: Native

Before
After

🎀👀🎀 C+ reviewed

@tgolen @isabelastisser Can any of you help with assignment for me as reviewer ? I need this for both the issue and PR https://github.com/Expensify/App/pull/42162 (reviewer was auto-assigned already).

@samilabud Is PR ready for review ?

Yes it is

@tgolen Can you please also remove the auto-assigned reviewer from the PR https://github.com/Expensify/App/pull/42162 and add me so I can start working on the checklist ?

Done!

The payments were processed in Upwork. All set!


Add documentation for users to run e2e tests locally

Also, we need to specify that cleanup is kinda broken and the user may have to do it manually to avoid incurring costs


Update log4j-api, ... to 2.21.0

About this PR
📦 Updates

org.apache.logging.log4j:log4j-api
org.apache.logging.log4j:log4j-layout-template-json
org.apache.logging.log4j:log4j-slf4j-impl

from 2.20.0 to 2.21.0
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.logging.log4j" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.apache.logging.log4j" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #499.


Same quest completed twice

In rare cases, it can happen that same quest can be completed twice. Investigate.

Fixed by reducing deadlocks.


cache_tool plugin can't find phar

When added cachetools config section:
plugins:
  cache_tool:
    version: 5.0.0
    opcache: true

I get following error:
php cachetool.phar opcache:reset --fcgi

 [ERROR] Could not open input file: cachetool.phar

Looks like I need to download cachetool manually, but in that case, what is version config option good for? Wouldn't be better to add path option? Does Automate look for cachetool executable in $PATH?
Also, what if my PHP isn't fcgi? This should be configurable too.

Hello,
Automate will download cachetools.
Can you try the following command from the server to see if there is not a network problem :
curl -sO  https://gordalina.github.io/cachetool/downloads/cachetool-5.0.0.phar
Currently only fcgi is support but you can just use cache tools without the plugin
post_deploy:
    - "php path/to/cachetool.phar ..."

curl downloads phar ok. What can I do to give you more data?

I just fixed the problem
can you test on the master?
if it's good i release a new version

@julienj How do I download or generate phar from master?

We don't need to build the phar to test
php bin/automate deploy ‹platform› -c [path_of_config_file]

fix in 3.1


Request for Permission to Translate Plugin "Avaice" into Chinese

Dear Punish,
I hope this message finds you well. I am reaching out to express my admiration for your exceptional plugin, "Avaice." It has proven to be an invaluable tool, and I deeply appreciate the effort you've put into its development.
I am writing to request your permission to undertake the task of translating "Avaice" into Chinese through the Ecommons platform. As a Chinese user, I believe that providing a localized version will greatly benefit the Chinese-speaking community and increase the plugin's accessibility to a broader audience.
I want to assure you that I will handle the translation process with utmost care and accuracy, ensuring that the essence and functionality of the original plugin are preserved. If you grant me permission, I will promptly begin working on the Chinese translation to the best of my abilities.
Please let me know if you have any specific guidelines or preferences regarding the translation. Your valuable input will be invaluable in ensuring a high-quality localized version.
Thank you for considering my request. I genuinely appreciate your contributions to the community, and I am eager to contribute back by making "Avaice" available to a wider audience.
Looking forward to your response.
Best regards,
Yuwuhuo
[Please accept my apologies if there are any unintended offenses or linguistic inaccuracies in this letter, as the content was generated using Google Translate.]

Hello! You can translate it of course, but please keep in mind that Ecommons's translation engine is in early development still and may be changed in future


add new Fullscreen home and account Info

To have a consistent page with the new full screen pages

this issue can be closed!


BMT: Organize Cypress test per role type (facilitator, participant, lead, everyone else)

Note that role-first approach wouldn't make much sense for majority of the functionality as it would be the same for everyone.
So I think we better go with "What can be done by whom" instead of "Who can do what".


Make some helper functions for determining hashed bins part of repository_lib

Fixes issue #: N/A
Description of the changes being introduced by the pull request:
In order to support users of the WIP low-level API for updating individual metadata on addition of a target (see #1048), specifically Warehouse and PEP 458, make some of the helper functions for determining the appropriate bin for a given target part of the public API in repository_lib.
Please verify and check that the pull request fulfills the following
requirements:

[x] The code follows the Code Style Guidelines
[ ] Tests have been added for the bug fix or new feature
[x] Docs have been added for the bug fix or new feature

TODO: these functions don't yet have explicit tests (though they are tested implicitly by the delegate_hashed_bins tests)

Thanks for relocating the code, @joshuagl! I support your find_bin_for_target_hash rename suggestion.

Pushed an update with the rename in ed45fb2

Also, I'm for moving on without adding explicit tests. The delegate_hashed_bins tests cover the functionality sufficiently for the time being. And we can still add tests when we set the public API in stone. What do you think?

I think this makes sense, thanks @lukpueh


Change name of package

Hey, @jonathantneal! I found your package while searching for my own:D I have a package with same name postcss-sass. I know you using a prefix @csstools/ in order to distinguish our packages. But may be better to change name of your package, to not to mislead users? I speaked with @ai, he propose a name postcss-with-sass. What you think about?

Closing due to inactivity and no continued concern from the community.

I just thought I'd share some learnings with my own projects. I have decided it helps if the name is more descriptive. For example I have a plugin which allows you to create borders using box-shadows. I chose the name postcss-border-align because this is at the heart of what the plugin helps with while still being flexible for the future possibilities of my plugin. I could have called it postcss-border but it could have conflicted with someone else's plugin in the future and it's a bit ambiguous and doesn't tell you much about the plugin. Equally I could have called it postcss-border-align-property but this would have been quite lengthy and isn't completely accurate. Not all plugins will be this straight forward to name and unfortunately the fact is that if two plugins do something very similar of not the same thing, will ultimately lead to the likelihood of having the same name.

https://www.npmtrends.com/postcss-sass-vs-@csstools/postcss-sass

https://www.npmtrends.com/postcss-sass-vs-@csstools/postcss-sass


Username/password

I changed operator to My OWN credentials....But it won't be accepted?!

Changed it back and working!

Alright, I propose to close this.


Request: Translation for Menu Links

Hi all,
with Quarx I can translate all my pages and blog entries, which can have different links. But I can't translate menu or more specific the link name. Creating multiple Menus per Language does not make sense in my context. How can I have one menu with multiple translations per link?
Thank you.

Based on general feedback I'm doing a full review and refactoring of translations and will be including menus in this process. #132


ES6 React Map Prop Validation

In the below example I receive three missing in props validation for products.title products and products.description however it feels like these aren't actually needed to be explicitly declared.
import radium from 'radium';
import React, { Component, PropTypes } from 'react';
import Button from '../../containers/buttonContainer';
import styles from './ProductsList.styles.js';

class ProductsList extends Component {

  static propTypes = {
    model: PropTypes.object.isRequired,
  };

  renderListItem({ title, description }) {
    return (

        {title}

{description}

    );
  }

  render() {
    return (

        <Button kind="primary">Primary</Button>
        <Button kind="secondary">Secondary</Button>
        <Button kind="warning">Warning</Button>

          {this.props.model.products.map(this.renderListItem)}

    );
  }
}

export default radium(ProductsList);

Is this error correct I'm getting correct?
eslint-plugin-react ^4.2.3

Of course they need to be explicitly declared. However, why not pass products directly? You don't want to be providing too much access/responsibility to components.

@ljharb I shall and agreed on the responsibility comment this is a WIP component so no worries.
Excuse any naivety but why is explicit type declaration needed when model is defined as an object?

Closing. Just found the answer in React.PropTypes.shape. Thanks @ljharb.

@Palgie it should instead be defined as a shape with every referenced property explicitly denoted with a PropType.


Supressed warnings

Changes to the copyright notice were caused by Clang-format, with no actual change to the text. I can revert it back if needed.
Suppressed warnings that appeared due to the "-Weverything" option which did not seem to have an immediate solution in order to satisfy the requirements set by the "WARNINGS_AS_ERRORS" option that users (like me) might use.
Please let me know if there is anything I might've botched and I'll fix it.

Is this code repository abandoned?

No, I'm still maintaining this project. If you don't mind, please update the PR code and fix the formatting changes that were made. Almost all of the code changes are formatting related (indentation, braces on new lines, etc) and it's impossible for me to find the actual code changes.


Fix FileCheck directive typos in several tests.

Thanks for the fixes!

Oops, seems like one test was failing. Fixed it, sorry about that.

Just bumping this up in case it fell through the cracks. The tests have passed, so I think this should be mergeable :)


RT-7.8: BGP Community Match Action

Following changes in this PR -

Added test script bgp_comm_match_action_test.go
Added new deviation bgp_actions_set_community_method_unsupported

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

Pull Request Functional Test Report for #2850 / 4769c3c3d65ae66033d9fa5557026d1f5d1bead5
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Cisco 8000E

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Cisco XRd

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Juniper ncPTX

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Nokia SR Linux

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Openconfig Lemming

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Cisco 8808

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Juniper PTX10008

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Nokia 7250 IXR-10e

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 54.484%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1847

Relevant Lines:
3390

💛  - Coveralls

@dipchauh could you please rebase and resolve conflicts

@dipchauh could you please rebase and resolve conflicts

Done


I can't start the example script

When I try to use the exmple script i get the following error
Error

boot.lua:577: Cannot load game at path 'C:/Users/micro/Documents/GitHub/lua-discordRPC/main.lua'.
Make sure a folder exists at the specified path.

Traceback

[C]: in function 'error'
[C]: in function 'xpcall'
[C]: in function 'xpcall'

I can't find out how to fix it, could someone help.
Thanks.

Pretty sure you are not starting your game correctly. Read this thoroughly: https://love2d.org/wiki/Getting_Started

That could very well be, but I now have a working one but without Löve. But still thanks. Shall i then close the issue?


Chrome Extension building

Hi there,
If Manga Downloader is a real Chrome extension, why do we have to build it?
I am on a Chromebook and I can't build the extension to use it with Chrome browser.
Thank you.

Hi! You can try to use builded extension file - manga-downloader-v1.3.crx from release.

Awesome, thank you!


EnsureDir errors when directory exists

ERROR:vagga::builder: Error building container "tank": step EnsureDir("/var/lock") failed: Error creating dir: File exists (os error 17)
ERROR:vagga::wrapper: Error executing _build: Builder exited with code 1

Aha, this is because the target is a broken symlink (so it exists, but not a directory)


Remove redundant isMounted ref from connect

Most likely this should fix https://github.com/reduxjs/react-redux/issues/1940 . It would be cool if @markerikson or @bvaughn could test this out using the parent of this commit in Replay: https://github.com/replayio/devtools/commit/477dd472eebf5210213500e798f6c94a7fad8c86

AHHHH that makes sense!

I guess the fix is not fully correct since tests fail 🤣 but nevertheless I think that it would fix the mentioned issue. It would be interesting to understand how the subscription nesting works and how it depends on this isMounted stuff to figure out a solution that would cover both requirements.

So basically with this change, we have 2 affected tests:

should not notify nested components after they are unmounted
should enforce top-down updates to ensure a deleted child's mapState doesn't throw errors

The first one fails because mapStateToProps gets called more times - it's not ideal but potentially wouldn't necessarily have to be treated as a big problem. However, the second one is more concerning and after some light analysis, I think that actually both failures are related to the same thing. I could be mistaken though.
So what's the problem? The problem here is that mapStateToProps for a given component is called before that component has a chance to get unsubscribed. This again is related to the usage of a layout effect to manage isMounted. With that, the component was treated as unmounted "sooner" and the notification from the parent (originating in its layout effect where captureWrapperProps leads to notifyNestedSubs) was simply being skipped. The useSyncExternalStore is a passive effect though so it gets unsubscribed later and thus we no longer skip this notification.
Interestingly, I went back in time to check out something and in 7.x this isMounted wasn't in the code at all. That's because the subscription to the store was not passive. It was also managed from a layout effect:
https://github.com/reduxjs/react-redux/blob/fee81904ba4414d75872da1e84b24e54214eb371/src/components/connectAdvanced.js#L417-L419
I've noticed one additional thing in the current implementation:
https://github.com/reduxjs/react-redux/blob/720f0ba79236cdc3e1115f4ef9a7760a21784b48/src/components/connect.tsx#L161-L163
Perhaps if this could be refactored to get more "inline" with the intended usage the problem would go away. I assume that in such a case React's implementation wouldn't rerender this component at all as it was already unmounted in its internal data structures and mapStateToProps wouldn't get called at all. This would change the timing of mapStateToProps calls though and perhaps it would have some performance implications as React would get notified about potential changes more often. However, I would also assume that it could mostly bailout from unwanted rerenders thanks to the /with-selector. You would know better though as you probably have already tried the less hacky usage of that hook and it didn't play out well for you 😅

Yeah, the reason for all that "non-standard" usage of uSES is that connect cares about more than just "the store state" or "the result of mapState" having changed.  It has to combine together the results of mapState + mapDispatch, and optionally use the results of mergeProps if that's been supplied, and then use whatever that combined object is to decide if the child component should re-render.
I couldn't come up with a good way to break apart that logic, so I ended up with an implementation where connect is still doing the bulk of the comparison work.

After further investigation, I've concluded this is actually a bug in the 03-25 experimental React build Replay is using - it works as expected in a current (08-17) React experimental build.
See #1940 for discussion.
Thanks for the attempted fix!


Update things

I hope it's alright

Appreciate the PR, however I usually leave it up to Renovate to update dependencies mostly. Appears it wasn't running though. Thanks

What about Paper? It wasn't updated


fix: remove composer files of recovery from check for changed files

Do it directly in the generated files instead of here 🤔
https://github.com/FriendsOfShopware/api-doc/blob/master/generate-file-sums.php

Do it directly in the generated files instead of here 🤔 https://github.com/FriendsOfShopware/api-doc/blob/master/generate-file-sums.php

yeah, but old ones would have to be regenerated, wouldn't they?

trigger by own and set it to 1


Is this function implemented?

Hello, it has been 4 years, has this #681 function been implemented?

The issue linked to was closed as “will not implement”. There is no particular reason why anyone should need to be able to compile multiple proto files into one pb.go file. Go allows for multiple files to exist in one package, and so one should just generate the several pb.go files to the same package. Done.

thanks


Remove the relationship between APM and the wcm/core/components/designer

We have a config for Delegating Servlet from ACS Commons  that is mapping the wcm/core/components/designer to acs-commons/components/utilities/designer.
Because of the fact that /apps/cqsm/core/renderers/cqsmRenderer inherits from cqsm/core/renderers/base and this in turn inherits from wcm/core/components/designer, the Delegating servlet was mapping the cqsmRenderer to acs-commons/components/utilities/designer which was causing the tool to break. This realtionship is really weird and probably could be removed.

The config we've got on the instance

What is rendered on the page


Added new aggregate functions FIRST, LAST, RANDOM

Just sharing this little idea that I had while travelling the other day ... Adding some more aggregate functions to MetaModel.

FIRST which picks the first value
LAST which picks the last value
RANDOM which picks a random value

One limitation of the PR is that the JDBC module does not support these functions. This is because there is no fallback strategy in place for the JDBC module when a particular query part cannot be pushed to the database. In my opinion that is already a problem that we have lived with - for instance in case of "scalar functions in where clause" which is also not supported - so I didn't try to solve it, just make sure it fails fast (and in a similar fashion to the mentioned other case).

Update the PR with more tests and made the JDBC module fail fast. Will update my previous PR description accordingly.
Now this is ready for a final review IMO - any takers?

LGTM, but I'm really no fan of reformatting an entire file unless we touch much of the file. It makes reviews much harder than they need to be, and destroys history.
I'd suggest we keep our hands off the reformat shortcut without selecting an area around our edits.

Agree. This was unintentional and just muscle-memory driven. Will fix it. Maybe we can put the eclipse formatting rules somewhere so that one can make sure he is using the single-version-of-the-formatting-truth :)

Hehe, yeah. :)


feat: add uSTX lending/borrowing

I need some information regarding this feature. I've got two implementations in mind.
I can use the following approach and create a wrapper-stx-token which will work the same as token-wbtc. However I need to know if you have the service where if the user mints wstx, the service will handle the transfer of stx from the user into the contract and then wstx is minted.
(define-public (mint (recipient principal) (amount uint))
  (begin
    (asserts! (is-eq tx-sender (var-get contract-owner)) ERR-NOT-AUTHORIZED)
    (ft-mint? wstx (fixed-to-decimals amount) recipient)
  )
)

However, if we don't have such service then I will have to add the logic inside the contract where stx-transfer? is called from the tx-sender and if the transaction is successful, the wstx is minted in his account.
(define-public (mint (recipient principal) (amount uint))
  (begin
    (asserts! (is-eq tx-sender recipient) ERR-NOT-AUTHORIZED)
    (try! (stx-transfer? amount tx-sender (as-contract tx-sender)))
    (ft-mint? ustx (fixed-to-decimals amount) tx-sender)
  )
)

Hi @SaadTahirTintash , we don't have a service to handle stx-transfer, so the second option makes sense, except that stx should be sent to alex-vault.
(define-public (mint (recipient principal) (amount uint))
  (begin
    (asserts! (is-eq tx-sender recipient) ERR-NOT-AUTHORIZED)
    (try! (stx-transfer? amount tx-sender .alex-vault))
    (ft-mint? ustx (fixed-to-decimals amount) tx-sender)
  )
)

When a user burns wstx, stx should also be sent from alex-vault (since wrapper-stx-token does not hold any stx). This will require adding transfer-stx to alex-vault that checks if contract-caller is approved and, if it is, transfers the requested stx to recipient, similar to transfer-ft (below)
https://github.com/alexgo-io/alex-v1/blob/ed7f3d83e5d8662fa902f43f2b58dcba9a6430e9/clarity/contracts/alex-vault.clar#L60-L67

Yeah that makes total sense now. One more thing that in order to test wstx, I cannot use faucet contract to get-some-tokens because the check for contract-owner conflicts with the wstx mint. So do we have some test cases for token transfers, mints, burns or should I write separate for wstx in the faucet contract.


Added conda-forge channel to environment.yml

If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #353.
How did you implement your changes
Adds conda-forge to the channels section in the environment.yml file.
Remaining issues
N/A.

Looks good! We should probably have someone re-install the environment as a test.

@camisowers I think an Intel mac is left.

I'll test now on Intel mac and get back to you

Re-installed toffy and successfully created the environment on Intel Mac! Thanks :)


Show all the assigned JIRA tasks

Retrieve all assign tasks from JIRA instances.

So this has to be connected with the LUIS cognitive service #10 to have more flexibility when searching for assigned JIRA tasks.


Brazilian Portuguese translation json

Hello!
I have created a json file for a brazilian portuguese translation of your game. If you can please make it available.
pt-BR.zip

Is it different from this?
https://cairnrpg.com/localizations/brazilian-portuguese/

Or should I just link to the JSON?

Hello!
I believe you just need to add the json to the lang folder for the next
release.
Em seg., 7 de ago. de 2023 às 18:48, Yochai Gal @.***>
escreveu:

Or should I just link to the JSON?
—
Reply to this email directly, view it on GitHub
https://github.com/yochaigal/Cairn-FoundryVTT/issues/85#issuecomment-1668621976,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBY54IV3EETTSZWGFDOK7WLXUFPDTANCNFSM6AAAAAA3HQCIUQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Which language folder?

This one:
[image: image.png]
Em ter., 8 de ago. de 2023 às 15:42, Yochai Gal @.***>
escreveu:

Which language folder?
—
Reply to this email directly, view it on GitHub
https://github.com/yochaigal/Cairn-FoundryVTT/issues/85#issuecomment-1670117653,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBY54IV2Y7S5SMRC7YASRATXUKCBFANCNFSM6AAAAAA3HQCIUQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'm sorry, I can't see that image!

OK, I have attached it in GH too. Check if you can see now.

Ah, OK I see the confusion. I think perhaps a Pull Request would make this much easier in the future: you can just put the file in the folder and then make the PR, I can merge, and so on!
Thank you!

Oh OK. I'm new to this thing, so I apologize for the mess.


How can I generate automatic typescript types, with Hasura and graphql-codegen [Question]

I was following Hasura automatic type generation for React/Angular Apps. It seems that code-gen takes all the query and mutation and introspection and then it generates typescript  type defs.
https://hasura.io/learn/graphql/typescript-react-apollo/codegen/
In refine since I don't have to write query and mutation, how can I generate typescript type definition file.
As of now I am writing all possible query and mutation.
I am using create react app and refine as npm deps

Hey @nirmaanlabs 👋,
Thank you for contacting us.I will look into it for you.
Hey @BatuhanW, do you have any idea?

Hey @nirmaanlabs ,
I guess there is no way to create Typescript types without queries. Did you find a way

@omeraplak
No I did not find a good solution for now.
For now I have to add all the query and mutation in .graphl file so that it can generate it types

If you could somehow expose the function which build query and mutation internally, or a function which output query and mutation file ?

Can you share me the the code file, which is responsible for generating or making query and mutations by introspection ?
Also I tried to a find a tool, which does introspection and generates query and mutation, but I could not, also hasura has it's query name and mutation name defined in very specific way
Thanks

Unlike GraphQL clients, Refine does not use introspection. Our approach is to generate a query. We think this approach is much more manageable, but not being able to auto generate TypeScript types is a big miss...
Data providers are responsible for creating the queries.
for example,
https://github.com/pankod/refine/blob/master/packages/graphql/src/index.ts#L63

@omeraplak just updated my comments

@omeraplak If I may suggest , the operationName was missing from mutation, I think it will be better if operation name is also sent along with it, because I just copied my mutation from network tab and pasted it, without operationName it somehow fails to generation types properly

but

Hey @nirmaanlabs, Unlike GraphQL clients, Refine does not use introspection. Our approach is to generate a query. We think this approach is much more manageable, but not being able to auto-generate TypeScript types is a big miss...
Data providers are responsible for creating the queries. for example, https://github.com/pankod/refine/blob/master/packages/graphql/src/index.ts#L63

@omeraplak
Is there any faster approach I can use ? Meanwhile I am trying to find a way to generate possible queries and mutations

In our example, we manage interfaces manually. An example line where this definition works is,
https://codesandbox.io/s/refine-hasura-example-790ew?from-embed=&file=/src/pages/posts/list.tsx:2105-2171

If I may suggest , the operationName was missing from mutation, I think it will be better if operation name is also sent along with it, because I just copied my mutation from network tab and pasted it, without operationName it somehow fails to generation types properly

We send operationName to mutations. Am I missing something?
https://github.com/pankod/refine/blob/master/packages/hasura/src/index.ts#L212

Is there any faster approach I can use ? Meanwhile I am trying to find a way to generate possible queries and mutations

I'm afraid there is no faster way

@omeraplak sorry It's queryName
example
This is how it was in network tab
mutation ($object: temp_post_insert_input!) {
  insert_temp_post_one(object: $object) {
    id
    content
  }
}

Then I changed it into

mutation insert_temp_post_one($object: temp_post_insert_input!) {
insert_temp_post_one(object: $object) {
id
content
}
}

has to be named manually

@omeraplak Is it possible I may run into any issue If i used autogenerated type ?

has to be named manually

@omeraplak Is it possible I may run into any issue If i used autogenerated type ?

You won't have any problems. If you succeed, can you share it with us?

@omeraplak yes definitely. Let me first try how to generate all possible queries and mutation
Thanks