HBASE-24577 Doc WALSplitter classes

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 57s
branch-2 passed

+1 :green_heart:
checkstyle
1m 16s
branch-2 passed

+1 :green_heart:
spotbugs
2m  9s
branch-2 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
2m  0s
root in the patch failed.

-0 :warning:
checkstyle
1m 13s
hbase-server: The patch generated 1 new + 0 unchanged - 1 fixed = 1 total (was 1)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
2m 22s
The patch causes 20 errors with Hadoop v3.1.2.

-1 :x:
hadoopcheck
4m 42s
The patch causes 20 errors with Hadoop v3.2.1.

-1 :x:
spotbugs
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

18m 55s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1913

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux c61f8505d325 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / c49df36e85

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-general-check/output/patch-javac-3.2.1.txt

spotbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 36s
branch-2 passed

+1 :green_heart:
compile
0m 52s
branch-2 passed

+1 :green_heart:
shadedjars
5m  0s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
branch-2 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 48s
root in the patch failed.

-1 :x:
compile
0m 51s
hbase-server in the patch failed.

-0 :warning:
javac
0m 51s
hbase-server in the patch failed.

-1 :x:
shadedjars
4m  1s
patch has 20 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 52s
hbase-server in the patch failed.

20m  3s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1913

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7d3e2aa17d51 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / c49df36e85

Default Java
1.8.0_232

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/testReport/

Max. process+thread count
88 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 52s
branch-2 passed

+1 :green_heart:
compile
1m 10s
branch-2 passed

+1 :green_heart:
shadedjars
6m 29s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

-1 :x:
mvninstall
2m 31s
root in the patch failed.

-1 :x:
compile
1m  4s
hbase-server in the patch failed.

-0 :warning:
javac
1m  4s
hbase-server in the patch failed.

-1 :x:
shadedjars
5m  5s
patch has 20 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
1m  4s
hbase-server in the patch failed.

26m  3s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1913

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e2da9475ab97 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / c49df36e85

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/testReport/

Max. process+thread count
91 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 37s
branch-2 passed

+1 :green_heart:
checkstyle
1m  9s
branch-2 passed

+1 :green_heart:
spotbugs
1m 59s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 10s
the patch passed

-0 :warning:
checkstyle
1m  7s
hbase-server: The patch generated 1 new + 0 unchanged - 1 fixed = 1 total (was 1)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 26s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m  4s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

32m 35s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1913

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux ff480c5257e3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e202c98fb0

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 12s
branch-2 passed

+1 :green_heart:
compile
1m  3s
branch-2 passed

+1 :green_heart:
shadedjars
5m 47s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 53s
the patch passed

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

+1 :green_heart:
shadedjars
5m 45s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
123m 31s
hbase-server in the patch passed.

149m 25s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1913

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a5b94087c197 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e202c98fb0

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/2/testReport/

Max. process+thread count
4801 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 52s
branch-2 passed

+1 :green_heart:
compile
0m 56s
branch-2 passed

+1 :green_heart:
shadedjars
5m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 27s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
5m 25s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
187m 27s
hbase-server in the patch passed.

211m  0s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1913

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ee6fc56bbbb5 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e202c98fb0

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/2/testReport/

Max. process+thread count
2575 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 53s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 32s
branch-2 passed

+1 :green_heart:
checkstyle
1m 20s
branch-2 passed

+1 :green_heart:
spotbugs
2m 17s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 43s
the patch passed

-0 :warning:
checkstyle
1m 19s
hbase-server: The patch generated 1 new + 0 unchanged - 1 fixed = 1 total (was 1)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 28s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 54s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

40m 53s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1913

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux b7e71b0e79c1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e202c98fb0

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 43s
branch-2 passed

+1 :green_heart:
compile
1m  9s
branch-2 passed

+1 :green_heart:
shadedjars
6m 25s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 23s
the patch passed

+1 :green_heart:
compile
1m  8s
the patch passed

+1 :green_heart:
javac
1m  8s
the patch passed

+1 :green_heart:
shadedjars
6m 24s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
183m 34s
hbase-server in the patch passed.

212m 21s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1913

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 438b448c14c7 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e202c98fb0

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/3/testReport/

Max. process+thread count
3206 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 53s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 32s
branch-2 passed

+1 :green_heart:
compile
1m  4s
branch-2 passed

+1 :green_heart:
shadedjars
5m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 50s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
shadedjars
5m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
199m 35s
hbase-server in the patch passed.

226m 41s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1913

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 459e52911708 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e202c98fb0

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/3/testReport/

Max. process+thread count
2541 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1913/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


formula_assertions: add assert_not_match compat

There are some formulae using this method:
https://github.com/Homebrew/homebrew-core/search?q=assert_not_match&type=

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Review period will end on 2021-03-02 at 00:00:00 UTC.

Review period skipped due to critical label.


Deploy my portfolio

Hi <STUDENT_MENTION>,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights
✔Portfolio deployed correctly
✔Design very well implemented
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Cool, Thank you..


Incremental md5

Implements #8.
Tested with a 47 Gb file, with LuaJIT only, using the following program:
local md5 = require 'md5'

local f,x = io.open(arg[1], 'rb')
print(f, x)

local state = md5.new()

repeat
  local s = f:read(math.random(1, 800))
  if not s then break end
  state:update(s)
until false
f:close()

print(md5.tohex(state:finish()))

(took 3+ hours; the result was compared to that of md5sum which took ~8 minutes). The updates were sent with random lengths to exercise different buffer fills.
Couldn't test with Lua as it refused to open the file.
It is based on the commits of PR #9, so they are included too. I can rebase if necessary.

I have not forgotten about this (hectic weekend). I still have to give it a more thorough review.

Thanks for the heads-up. Take your time, there's no hurry. Meanwhile I'll push my rebased version.

I finally was able to review this (sorry about the delay).
I made a small change: update returns self. This way, you can chain commands:
local x = md5.new():update('foo'):update('bar'):finish()

I will now create a changelog and release md5 1.1.0


chore: update dependencies

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
Update lsp-factory dependencies
What is the current behaviour (you can also link to an open issue here)?
Outdated dependecies
What is the new behaviour (if this is a feature change)?
Remove TypeDoc from the repo
Update erc725.js to latest
Remove web3 as a dependency it looks like it is not used anymore (we use ethers in that project)
Other information:
Ticket : CU-860pvv1vk

closing as done in https://github.com/lukso-network/tools-lsp-factory/pull/183


Added a flag in dummy_request() to inform middleware that the request is a dummy

This is useful for middleware that perform destructive changes in
process_response(). They rightfully expect process_response() to only get called
once per thread, but it happens twice during a Page preview when running under
Django 1.10's middleware system. This flag lets the middleware know that they
should potentially skip their destructive operations.

This is the PR for #3850.

I no longer have any use for this flag, as I discovered an alternative solution to the problem I wrote this PR for (which I discuss in #3850). However, this is such a small change, and it could potentially be useful to someone, so maybe it's worth keeping?

Merged in c8b0fff58670b31b9876b0866617d317b54e4bc9 - thanks @coredumperror!
(Have left this change undocumented, as dummy requests are an internal implementation detail.)


Mark crash cases 28483, 28490 and 28493 as non-deterministic.

Credits to @rintaro (#5743) and @jrose-apple (#5780, #5837) who reported the non-deterministic behavior of these crash cases.

@swift-ci please smoke test

@swift-ci please smoke test


chore(main): release 2.0.0

:robot: I have created a release beep boop
2.0.0 (2023-06-27)
⚠ BREAKING CHANGES

requires node 18

Features

update rollup and svgr (10bea44)

Miscellaneous Chores

@pob/root update (cbebb77)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/christophehurpeau/rollup-plugin-svgr/releases/tag/v2.0.0 :sunflower:


Adding 'ClusterRole' and 'ClusterRoleBinding' to rook-ceph-mgr

In a multicluster mode, rook operator pod is throwing following exception,
failed to enable external service monitor.
service monitor could not be enabled: failed to retrieve servicemonitor.
servicemonitors.monitoring.coreos.com "rook-ceph-mgr" is forbidden:
User "system:serviceaccount:openshift-storage:rook-ceph-system" cannot
get resource "servicemonitors" in API group "monitoring.coreos.com" in
the namespace "openshift-storage-extended"

Adding cluster wide role and rolebinding to rook-ceph-mgr serviceaccount.

After changing RBACs, we need to update the generated changes. Please add a new commit with generated changes make gen-latest-csv.

Done

/test ocs-operator-bundle-e2e-aws

/test ocs-operator-bundle-e2e-aws

/test ocs-operator-bundle-e2e-aws

@aruniiird CI might be failing for genuine reasons. Please verify it manually.

I tried it locally (on one of our daily clusters), but I'm hitting a different issue,
$  bash hack/install-ocs.sh

Namespace "openshift-storage" exists
INFO[0052] Creating a File-Based Catalog of the bundle "quay.io/ocs-dev/ocs-operator-bundle:latest"
INFO[0055] Generated a valid File-Based Catalog
FATA[0055] Failed to run bundle: create catalog: error creating catalog source: catalogsources.operators.coreos.com "ocs-operator-catalog" already exists

/test ocs-operator-bundle-e2e-aws

/retest

/cherry-pick release-4.15

/retest

@umangachapagain , @agarwal-mudit ,
Created a test/dummy PR (on top of main branch) to check ocs-operator-bundle-e2e-aws tests and it is failing there as well.
Please take a look at PR#2402 's e2e tests

From the CI error log:
'error creating clusterrolebinding rook-ceph-monitor-mgr: ClusterRoleBinding.rbac.authorization.k8s.io
      "rook-ceph-monitor-mgr" is invalid: subjects[0].namespace: Required value'

So this approach might not work with ClusterRoleBinding. We might need to create these RBACs from within the operator.

Working on it...

/cherry-pick release-4.15

From the CI error log:
'error creating clusterrolebinding rook-ceph-monitor-mgr: ClusterRoleBinding.rbac.authorization.k8s.io
      "rook-ceph-monitor-mgr" is invalid: subjects[0].namespace: Required value'

So this approach might not work with ClusterRoleBinding. We might need to create these RBACs from within the operator.

Made the changes.
@umangachapagain , can you please take a look

@aruniiird lint is failing.

Lint fixed...


error with command twscrape login_accounts

I run the command:
twscrape add_accounts ./accounts.txt username:password:email:email_password:cookies
The result was:
2024-01-17 13:41:16.484 | INFO     | twscrape.db:migrate:86 - Running migration to v1
2024-01-17 13:41:16.500 | INFO     | twscrape.db:migrate:86 - Running migration to v2
2024-01-17 13:41:16.515 | INFO     | twscrape.db:migrate:86 - Running migration to v3
2024-01-17 13:41:16.515 | INFO     | twscrape.accounts_pool:add_account:97 - Account MY_TWITTER_ACCOUNT added successfully (active=False)
Then I run the command:
twscrape login_accounts
And then appear this error:
2024-01-17 13:41:39.631 | INFO     | twscrape.accounts_pool:login_all:155 - [1/1] Logging in MY_TWITTER_ACCOUNT - MY_EMAIL
2024-01-17 13:41:40.456 | ERROR    | twscrape.accounts_pool:login:141 - Error logging in to MY_TWITTER_ACCOUNT: 'ct0'
{'total': 1, 'success': 0, 'failed': 1}
Exception ignored in: <function _ProactorBasePipeTransport.del at 0x000001F78C198670>
Traceback (most recent call last):
File "C:\Users\AppData\Local\Programs\Python\Python310\lib\asyncio\proactor_events.py", line 116, in del
self.close()
File "C:\Users\AppData\Local\Programs\Python\Python310\lib\asyncio\proactor_events.py", line 108, in close
self._loop.call_soon(self._call_connection_lost, None)
File "C:\Users\AppData\Local\Programs\Python\Python310\lib\asyncio\base_events.py", line 750, in call_soon
self._check_closed()
File "C:\Users\AppData\Local\Programs\Python\Python310\lib\asyncio\base_events.py", line 515, in _check_closed
raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
And twscrape no longer works...

Sorry!
My error!
I changed my twitter password but I dont update the file:
accounts.txt


Blazor templates: add @using Microsoft.AspNetCore.Authorization

We should add @using Microsoft.AspNetCore.Authorization to the top-level _Imports.razor, otherwise it's hard to write:
@attribute [Authorize]

It's an open question whether we do this unconditionally or only when one of the authentication mechanisms has been chosen.

Warpping in am Auth conditional is what the other templates do, so that makes most sense

Currently we're not using conditionals in .razor files due to a tooling limitation, so for now at least this will be added unconditionally. There isn't really any drawback to doing this, considering what other stuff is also there unconditionally.

Done inhttps://github.com/aspnet/AspNetCore/pull/11736

@SteveSandersonMS what do you mean there is a tooling limitation? Using this approach works just fine
@*#if (!Hosted)
	Stuff I want conditioned
#endif*@

It didn't used to work when the template was executed inside VS (though it did on the command line). Whether that's fixed or not yet in VS I don't know, and so it's safer to proceed assuming it hasn't been fixed, considering how close we are to the deadline for including this change. Also, it's done and merged now :)


Avoid front running between deterministic deployment and initialize function

Describe the bug
I 'm using deterministic deployment, but I'm not using a proxy (perhaps I suspect proxy deployment has same issue).
My contract has an empty constructor and I use initializer from oz, so:
await deploy('MyContract', { deterministicDeployment: true });
await execute('MyContract', {}, 'initialize', args);

There is a way to do inside a single transaction?

There is no mechanism in hardhat-deploy for this currently
You can wrap it in a multi call but you ll have to save the deployment information manually using deployments.save)


fix!: launchNode.cleanup not killing node in last test of test group

Closes #2712

Summary
Launching a fuel-core node via launchNode and killing it via the cleanup function wouldn't kill the last  node in a test group because the test runner would exit before the node was killed and the node wouldn't get killed. The other nodes would get killed because there was enough time for the killing to happen before the last test finishes. Launching the nodes in a detached state and killing them via process.kill(-child.pid) did the trick.
Breaking Changes
The killNode function and the KillNodeParams interface have been internalized and no longer exported. It's marked as a breaking change for pedantic reasons and there shouldn't really be any affected users given that they kill nodes via cleanup which is unchanged, so no migration notes are necessary.
Checklist

[x] I added — tests to prove my changes
[ ] I updated — all the necessary docs
[x] I reviewed — the entire PR myself, using the GitHub UI
[x] I described — all breaking changes and the Migration Guide

@arboleya Upon removing tree-kill I realized that there is no need for the the killNode abstraction given that the killing now happens via process.kill exclusively so I internalized it here and simplified the related test.

@arboleya Upon removing tree-kill I realized that there is no need for the the killNode abstraction given that the killing now happens via process.kill exclusively so I internalized it here and simplified the related test.

I don't think this should be a breaking change given that killNodeParams was being exported solely for the purposes of our own internal consumption, corroborate that with the fact that it's not documented.

@maschad I'm fine both marking it or not marking it as a breaking change.

[..] Upon removing tree-kill I realized that there is no need for the the killNode abstraction

@nedsalk Ok, so you internalized the functionality and deleted the interface/method. 👍

@arboleya that's better phrasing, I updated the description.


Am I installing this correctly?

I'm on a Windows 10 Laptop. I installed Node.js, then i opened that script in cmd, then entered "npm install -g litero" (without the quotes), and i receive multiple lines of errors. I even tried running the script with admin privileges, still the same result.

Hi there!
May I bother u for a screenshot of error plz ?
On 6 Nov 2016 19:02, "nr1864"<EMAIL_ADDRESS>wrote:

I'm on a Windows 10 Laptop. I installed Node.js, then i opened that script
in cmd, then entered "npm install -g litero" (without the quotes), and i
receive multiple lines of errors. I even tried running the script with
admin privileges, still the same result.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openone/litero/issues/2, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA1_qOc-35n-e8snEG1HR_WFkrEHtpzOks5q7dbtgaJpZM4KqjgB
.

I got it working, had to reboot my pc. Also, the code is slightly different than inside your wiki


DOM-35529 MPI cluster Failed status

Only changes to pkg/cluster/mpi/statusupdate.go are relevant for this work (I accidentally merge DOM-35816 into this branch).


Fix paste button being permanently disabled when clipboard was previously empty.

Fixes #292.

So this will make the button enabled even if nothing's on the clipboard, right? I guess that just means pressing it is a no-op, which isn't terrible.

This doesn't change previous behavior -- before, the disabled paste button was still visible, but did not indicate it was disabled. Now, the enabled button will "ripple" when touched, at least indicating that the button works.


Using edit_physio() in Spyder breaks console after closing interactive plot session.

This happens in Spyder 4 (didn't test on previous Spyder versions), in Ubuntu 18.04 and latest winpython.
If we can figure out why, it would be great - starting with trying to reproduce the problem in different environments @physiopy/all .

Update: it seems it's a problem related to the Qt4Agg and Qt5Agg backends in Spyder. Using the same backend from a python console (e.g. IPython) doesn't raise any issue. @rmarkello, which backend were you using when you were coding peakdet?

Oh jeez, that's a tough question... I was almost certainly using one of those you listed: likely originally Qt4Agg and then later Qt5Agg. I know that Spyder has a lot of confirmed graphical compatibility issues (e.g., I know it has bugs with the tqdm module). Note that I have never used Spyder myself, so all development was done in Python/IPython, exclusively.

Ok, that's good to know! Out of curiosity, did you also test it in a jupyter notebook? Does it work without issues?
I guess that then we can just add a warning in the documentation saying not to use it in Spyder...

@smoia : I tested it in a jupyter notebook yesterday! that's a funny coincidence. I was thinking of posting something here to cover the issue.
At first I thought it may be a %pylab inline or %matplotlib inline confusion, but then I realized the issue was too complex for me to describe properly. Here I am : it doesn't work in jupyter.

Mmm, like this it might be a bit difficult to "debug", but I'd say the first thing we can do is to write in the readme and in the documentation that we don't guarantee that the interactive plot session works in Spyder or Jupyter notebook. Sounds good?

Sounds right yeah. Pin me if you think you'd need me to send a PR

Sure! Why don't you go on and open a PR?

@sangfrois @smoia: you will likely need to install ipympl and enable it with %matplotlib widget for use of peakdet in Jupyter notebooks! That is, loss of interactivity in maptlotlib plots is a standard feature of Jupyter notebooks and is not just peakdet specific. (That's not to say peakdet will 100% work with this solution, but it definitely won't work without it.)
(Also to explicitly answer @smoia's previous question: no, I had never tried testing in Jupyter!)

Ah, nice!
@sangfrois care to try it out? If it works we can add ipympl as an extra dependency!

it thinks I've tried, but let me give it a shot again! I'll pin you once I'm done!

Ok, so : I've tried installing ipympl and executing %matplotlib widget to get the interactive plot and only got that string.
<matplotlib.axes._subplots.AxesSubplot at 0x1f3b07b9470>
Something seems to be processed here, so I've double checked with %matplotlib inline and got a static figure.
Assuming that the string output meant there was a plot object, I've tried to call plt.show() and got nothing 😢
Everything works fine in my terminal though. Even got the chance to try out the GUI. Looks great 😁

New question: does the library need OpenGL?

@smoia: I'm not sure! I want to say no, probably not, but did very limited testing on this whole thing 😅 Sorry to not be of more help here.


Set secure cookie key from env var to enable bypassing authentication

Overwrite the default secure cookie key with one from an environment variable, so that we know it for encrypting the auth cookie in the proxy
Don't echo commands, to avoid the key being logged

Can't see the whole picture but what I see looks alright 👍


Any news on the 0.9.0 release?

I have a need for this bug fix<EMAIL_ADDRESS>

Please follow the discussion on the mailing list about the 0.9.0 release. In the meantime, you can always install the master branch from source


Stats

This PR implements the first stage of producing a dashboard to track the daily number of claims that are being
submitted.  It models a statistics table to store the results, and the first collector, to store the number of submitted claims.
It does not yet implement the cron job to record this information daily, nor the gecko API.

👍  When building the API endpoints bear in mind please that we may wish to pull this information out in the future with other clients - the LAA have a data store called MI which stores a wide array of performance metrics and their Integration Hub is currently pushing data to it from APIs in existing apps.


[Security Tooling] Veracode account locked / password not working

Security Tooling Support Request
Tool

Veracode asked me to reset my password due to expiration.
Issue Description
After I updated the password I am now unable to log in. A password request mail told me to ask my administrator to do it for me. Could you help out here? Thanks
Reset password for<EMAIL_ADDRESS>

@ds-mwesener : Reset password mail sent. Please check.

Solved, thank you very much.


Try infogail

Let's merge this to v0.7fixes_in_progress. The capability to run infogail experiments is crucial going forward.

Yeah sure, since v0.7 fixes are still in progress. I don't think there are a lot of changes, so it should be fine. We should make sure to fix some of the remaining issues and then merge to master. (Same with AutoRisk).


KAFKA-2658: Add PLAIN mechanism to SASL implementation

Implementation and unit tests for SASL/PLAIN. A simple login module and SaslServer implementation for PLAIN mechanism are included in the implementation, but these can be replaced to integrate with authentication servers.

@ijuma  Thank you for reviewing this. I will update the PR with the changes you suggested.

Sorry @rajinisivaram, can you please merge trunk as there are now conflicts?

@ijuma  I have rebased and merged the changes. Thanks.

Thanks for the patch. Since this is a relatively large patch and we are getting really close to cut the 0.9.0 release, perhaps we should defer committing this patch until the 0.9.0 branch is cut.

[~junrao] We were hoping that SASL/PLAIN could be supported in <IP_ADDRESS>. Most of the changes in the patch are to enable testing. While it would be good to have a default PLAIN provider integrated into Kafka, that is not critical for us. If I split this into two PRs, one to add the ability to plugin a PLAIN provider and the second to add a default provider plus tests, can the first one be committed into <IP_ADDRESS>? That should be a much small patch. Thank you...

@rajinisivaram : You need a default PLAIN provider for SASL PLAIN to work, right? Perhaps we can get KAFKA-2644 in first and then revisit this. In the meantime, could you test the patch on system tests?

@junrao Testing KAFKA-2644 locally at the moment, will deliver later today. For SASL/PLAIN, the default provider is useful for testing, but you can plug in your own provider through your Jaas config and that would work for us. Will let you know when KAFKA-2644 is ready.

This is now being done under KAFKA-3149.


Refactor

This PR includes a comprehensive refactor of the codebase. It also introduces a new route method on the Aerni\Zipper\Zipper class which makes it possible to use this addon programmatically without using the Antlers tag.
This should also make the request of PR https://github.com/aerni/statamic-zipper/pull/4 possible.

Hi @aerni,
Thanks, I have been able to test this and have the following feedback.
https://github.com/aerni/statamic-zipper/blob/feature/refactor/src/Zipper.php#L46 Blocks CDN or Cloud storage from being a possibility (S3 etc)
And https://github.com/aerni/statamic-zipper/blob/feature/refactor/src/Zipper.php#L42 has substr with an offset of 1, this would cause the h from http:// or https:// to be dropped on fully qualified urls (such as with S3)
Removing those, seems to work for us.
    protected static function files(Collection|array $files): array
    {
        return collect($files)
            ->map(fn ($file) => match (true) {
                ($file instanceof Asset) => $file->url(),
                (is_array($file)) => Arr::get($file, 'url'),
                default => $file,
            })
            ->all();
    }

Oh, good catch! Both issues should be fixed now. Can you give it another try?

Hi @aerni,
I can confirm that it works, The use of the Http::get check might introduce some slowness for generating downloads which have a number of files within them, but at that point, it is probably worth setting the Zipper config to  'save' => true,

Cool, thanks for checking.
I wasn't sure if I should add Http::get or not. This is a new addition that wasn't there before. I've added it to avoid an exception if a requested file doesn't exist. This could be the case when creating a zip with files from an external source.
The HTTP request happens before 'save' => true though. But I could probably refactor this.
What is your opinion? Should I remove it or not? It's really only there to avoid a potential exception.

I'd probably suggest removing it, and having the check in place on the actual download generation action, rather than the link creation action.

I'm already working on exactly that ;-)

Yep, looks good to me.


DBZ-5852:Snapshotter#snapshotCompleted is invoked regardless of snaps…

Added two lifecycle methods completed(...) and aborted(...) to AbstractSnapshotChangeEventSource.java to perform any cleanup required specific to snapshot complete or aborted.
Also, Override completed method in PostgresSnapshotChangeEventSource.java as complete is calling snapshotter.snapshotCompleted()
Common cleanup regardless of snapshot result should be done in complete(...) method (like in oracle or sql server connector)

@jpechane I am working on writing unit tests. is there a way to interrupt or fail the snapshot programmatically ?

@jpechane Added IT test and all test cases are successful except DB2. DB2 testcase failures are not related to the PR changes.

Ping.

Added AutoCloseable implementation changes. Failed tests are not related to the PR. Could you please review ? thanks.

ping @jpechane . any feedback is appreciated. thanks.

@adasari Rebased to the latest main to make sure the tests passes. Db2 and Vitess PRs needed to get their code aligned to the new interface.

@adasari Rebased to the latest main to make sure the tests passes. Db2 and Vitess PRs needed to get their code aligned to the new interface.

DB2 PR : https://github.com/debezium/debezium-connector-db2/pull/92
Vitess PR: https://github.com/debezium/debezium-connector-vitess/pull/120


Loading default DATABASE is extremely slow in WASM

For some reason, the initial deref of the lazy_static takes several seconds, locking up the page while the first phone number is either parsed or formatted. After that, it's really snappy. Using the Chrome Dev Tools profiler, it looks like the bincode deserializing only takes ~40ms and most of the time is spent in Database::from. The callgraph is dominated by closure calls. I can only guess that the WASM backend can't optimize away all the closures as aggressively as the x86 one can?

Initializing the database in a web worker won't work, because it doesn't share memory with the main thread. The database is not Deserialize + Serialize, so you can't send it over manually either. I considered raw JS interop with one of the libphonenumber-based NPM packages out there, but there would be no way to convert the result to a  phonenumber::PhoneNumber, since the struct is encapsulated such that the only way to make one is by parsing from a string. That leaves the most promising option as an unnecessary client type, something like
pub enum ClientPhoneNumber {
    PhoneNumber(phonenumber::PhoneNumber),
    DefinitelyAValidPhoneNumberIPromise(String),
}

and leaving the final say to the backend. This is certainly possible, but negates a lot of the benefit of having a unified client+server in full-stack Rust.

Update: Ok, to be clear, that's the unoptimized dev build. Timing the release build is much less egregious, though still a noticeable hitch. I didn't think about this at first, since the x86 dev build is rust-iliciously fast.

It's a little harder to tell what's going on, since the function names are gone. 0.5s is definitely better than 4.0s, but it still feels like there's room for improvement.
When I get a chance, I may fork and hack on Database::from to see if de-closuring has any effect. If successful, would an associated pull request be welcome? Is the current testing situation sufficient?

I had a look into this. The issue is that when the metadata gets initialized from the database, a syntax check on all regexps is performed (and theres a lot of them!). This is to prevent ugly runtime errors later on. The deserialization from the bincoded database itself is fast as you pointed out.

The fix is quite straightforward actually, as we do not need to perform the syntax check at runtime if we already validate the regexps during the build phase when we parse Googles XML using loader. As an added benefit, this also means that there will never be a error due to invalid regexps in Googles data as the crate will not compile in that case.
I already implemented it with good results on my machine and would expect the time to go down to less then 15ms in your wasm use case on your machine.

I will post the PRs to rust-phonenumber and regex-cache (which required a minor modification) later.

Wow, @yannleretaille, you rock!
Gotta love compile-time guarantees. :)


Add charges controller

Moved charges controller React/Rails Shopify base app
In the future would be useful to override this class in the base app to config charge_params(minimizing the exposed params to avoid overriding params like shop or plan).

@mib32 Please review but don't merge


Feature Request: Multiple resourcesPath

It would be great to have ability to get translations from the few files.
resourcesPath -> resourcesPaths: string[]
For example:
lazy loading of translations for different modules
server-side translations
Let me know if the contribution is allowed

That sounds like it would be useful, if you want to feel free to submit a pull request or I can look to add it in the future

Please, review the PR

Merged and extension published. Thanks


'estimatefee 2' testnet returning -1

estimatefee 2
testnet returning -1
block count on dev: 125589
My live node works fine.

Was your testnet node recently started? Per the help description:

A negative value is returned if not enough transactions and blocks
have been observed to make an estimate.

Yup Blockchain download finished just yesterday.
This is what I figure as I provided my block count tally on dev: 125589
Thanks for your input, I a going to close this isse


Use ol3-cesium

Hi,
I am trying to use ol3-cesium on windows7.How to do that.Please help.Thanks.

You have two choices:

either use an already compiled version from https://github.com/openlayers/ol3-cesium/releases
or compile the library yourself.

In order to compile the library you will need to install some dependencies, see README.md.
I think you are the first one wanting to do it on Windows.
The easy way would be to install an Ubuntu VM however there is certainly a native way.
Feel free to reopen and share your findings.


Configuring and compiling GoAccess on FreeBSD 10.1

Hello guys. I am running Freebsd 10.1. I am trying to compile Goaccess with geoIp support.
When I do the configure with geoIP I get:
checking for GeoIP_new in -lGeoIP... no
configure: error: *** Missing development files for the GeoIP library

I have the geoip port installed (net/GeoIP)
root@e5-2620v3x2:/tmp/goaccess-0.9.4 # /usr/local/bin/geoiplookup -f /usr/local/share/GeoIP/GeoLiteCity.dat <IP_ADDRESS>
GeoIP City Edition, Rev 1: US, CA, California, Mountain View, 94040, 37.386002, -122.083801, 807, 650

Can someone please tell me how to make it work with geoip ?
If I install the goaccess port from freebsd it's version 0.8.5 and it doesn't have geoip support

Try the following:
# pkg_add -r GeoIP
# export LDFLAGS=-L/usr/local/lib
# ./configure --enable-geoip --enable-utf8
# make
# make install

Just configured and compiled in FreeBSD 10.1 and the steps above worked fine.

Damn it. Still the same :(
[root@e5-2620v3x2 /tmp/goaccess-0.9.4]# /usr/local/bin/geoipupdate.sh
Fetching GeoIP.dat and GeoIPv6.dat...
/usr/local/share/GeoIP/GeoIPupdate.4KwoRT/GeoI100% of  441 kB  840 kBps 00m01s
/usr/local/share/GeoIP/GeoIPupdate.pPQiNn/GeoI100% of  712 kB  836 kBps 00m01s
[root@e5-2620v3x2 /tmp/goaccess-0.9.4]# set env LDFLAGS -L/usr/local/lib
[root@e5-2620v3x2 /tmp/goaccess-0.9.4]# ./configure --enable-geoip
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... ./install-sh -c -d
checking for gawk... no
checking for mawk... no
checking for nawk... nawk
checking whether make sets $(MAKE)... yes
checking for gcc... no
checking for cc... cc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether cc accepts -g... yes
checking for cc option to accept ISO C89... none needed
checking for style of include used by make... GNU
checking dependency style of cc... gcc3
checking whether cc understands -c and -o together... yes
checking for pthread_create in -lpthread... yes
checking build system type... x86_64-unknown-freebsd10.1
checking host system type... x86_64-unknown-freebsd10.1
checking whether to build with rdynamic for GNU ld... yes
checking for GeoIP_new in -lGeoIP... no
configure: error: *** Missing development files for the GeoIP library
[root@e5-2620v3x2 /tmp/goaccess-0.9.4]#

Make sure is setenv LDFLAGS -L/usr/local/lib and not set env...

It is working now. THANK YOU VERY VERY MUCH !

Glad that worked :)


Separate debug & release build in CI

This should make CI run faster overall.

CI went from 26 min per job to 10-15 min per job (in debug-release mode respectively)


403 eval to value

#403
Note for the reviewer:

Found that this breaks point/lines detection :stuck_out_tongue:
Already hot-fixed in master.


Updated ContactUs Section

Updated Contact Us Section with Responsiveness.

Good Job @SasiVardhan247  just few changes -

Add the social media icons you used by replacing the icons in the footer and hyperlink those with my active links on them.
In the email field give<EMAIL_ADDRESS>In the number field give: +91 9304******
Add some border radius matching the rest of buttons present on the site.

Good Job @SasiVardhan247 just few changes -

Add the social media icons you used by replacing the icons in the footer and hyperlink those with my active links on them.
In the email field give<EMAIL_ADDRESS>In the number field give: +91 9304******
Add some border radius matching the rest of the buttons present on the site.

Yeah sure 😊

I've done the changes @SurajPratap10

 I've done the changes @SurajPratap10

Rest is fine @SasiVardhan247  but for the icons, I said to remove the icons from the contact section and just put those icons you showed at the beginning of PR to the footer section with hyperlinks. (we don't need icons in 2 sections)

Is it ok now Can I make a pr.

 Is it ok now Can I make a pr @SurajPratap10

ya, do it in the same pr but

Ok , if you are having issues then make a new PR @SasiVardhan247 👍


Remove version: StrawberryMusicPlayer.Strawberry version 1.0.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/strawberrymusicplayer/strawberry/releases/download/1.0.0/StrawberrySetup-1.0.0-Qt6-x64.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 911)


Fix Adam() optimizer reference

keras.optimizers v2.8.0 no longer has a direct import of the Adam class, it's now in keras.optimizers.adam_v2 or keras.optimizer_v2 (which I assume is identical)

Thanks for the PR. If this was an actual issue, it would have been a major compatibility breakage. But keras.optimizers.Adam works in both 2.8 and 2.9 (nightly). Perhaps you were using import keras instead of from tensorflow import keras?

Ah I see, my mistake! Thanks for clarifying @fchollet


MobiusLoop can't receive onActivityResult

The current suggested way to setup Mobius is to call start() in onStart and stop() in onStop. This lifecycle doesn't allow the system to receive onActivityResult calls since it takes place before onStart calls start()

Not sure of other solutions but here is what I did to get file selection implemented.  As I noted here, my base (conductor) Controller is an EventSource for my UI mobius loop.  When the EventSource is subscribed to, the Controller will store the Consumer as a member until it is disposed of.  This Consumer is what I use to push onActivityResult events (among others) into the Loop.  As you noted this and other events can occur while the Loop is stopped, meaning no Consumer is available.  Instead of making the Consumer nullable, which would mean all events are lost while the Loop is stopped, I set it to a simple Consumer implementation that caches all events it receives.  This implementation also provides a method to empty the stored events into a new Consumer, this occurs when the EventSource is subscribed to, before replacing the old Consumer.
class QueuedConsumer<V> : Consumer<V> {

  private val queue = arrayListOf<V>()

  override fun accept(value: V) {
    queue.add(value)
  }

  fun dequeueAll(target: Consumer<V>) {
    queue.forEach(target::accept)
    queue.clear()
  }
}

abstract class BaseController(args: Bundle?) : Controller(args), EventSource<AppEvent> {

  var eventConsumer: Consumer<AppEvent> = QueuedConsumer()
    private set

  override fun subscribe(newConsumer: Consumer<AppEvent>): Disposable {
    (eventConsumer as? QueuedConsumer)?.dequeueAll(newConsumer)
    eventConsumer = newConsumer
    return Disposable {
      eventConsumer = QueuedConsumer()
    }
  }
}

I understand that it's a bit confusing with the names - we chose start and stop for the names so that the controller would make sense outside of activity/fragment lifecycles, so unfortunately it doesn't actually have anything to do with onStart() or onStop().
The recommended approach when using a controller in a fragment/activity is to use onResume() and onPause() for the lifecycle of the controller, as fragments will call onSaveInstanceState() before onStop() and you therefore might end up losing state if you keep the loop running past onPause() during eg. a configuration change. Of course there is nothing that prevents you from using onStart()/onStop() if you want or need to, but it does come with that caveat.
Regarding getting onActivityResult into the loop, using an EventSource as @DrewCarlson is suggesting is how we prefer to do it. There is in fact an example of this in the mobius-android-sample app. In the TaskFragment we are using an RxJava BehaviorSubject, like this:
https://github.com/spotify/mobius-android-sample/blob/master/todoapp/app/src/main/java/com/example/android/architecture/blueprints/todoapp/tasks/TasksFragment.java
  private BehaviorSubject<TasksListEvent> mOnActivityResult = BehaviorSubject.create();

// ...

  @Override
  public void onActivityResult(int requestCode, int resultCode, Intent data) {
    if (AddEditTaskActivity.REQUEST_ADD_TASK == requestCode && Activity.RESULT_OK == resultCode) {
      mEventSource.notifyEvent(taskCreated());
    }
  }

@DrewCarlson one note about your QueuedConsumer implementation: since Mobius (and Android apps in general) use multiple threads, it would be a good idea to make it thread safe. Two easy ways of doing that are by making the queue a Collections.synchronizedList or by making the accept and dequeueAll methods synchronized. The latter is a bit safer, because it handles an unlikely  race if there is an accept while dequeueAll is being executed.
@togi the code you pasted has a bug. :) The mOnActivityResult field looks like it's unused. Instead, the DeferredEventSource mEventSource is what's handling the activity result. I'll create a PR to fix it.
Other than that, I agree with both the answers! :)

Closing this, as I think it has been answered.


Not compatible with the latest version of PyCharm CE

Trying to add the plugin and there is a compatibility issue.
PyCharm info.:
PyCharm 2023.2 (Community Edition)
Build #PC-232.8660.197, built on July 26, 2023
Runtime version: 17.0.7+7-b1000.6 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 13.4.1
GC: G1 Young Generation, G1 Old Generation
Memory: 3072M
Cores: 8
Metal Rendering is ON
Registry:
debugger.new.tool.window.layout=true
ide.experimental.ui=true
Non-Bundled Plugins:
com.chesterccw.excelreader (2023.6.1-222.232)
com.intellij.ideolog (<IP_ADDRESS>)
com.intellij.plugin.adernov.powershell (2.0.10)
org.rust.lang (<IP_ADDRESS>21-232)
nl.rubensten.texifyidea (0.9.1)
com.firsttimeinforever.intellij.pdf.viewer.intellij-pdf-viewer (0.15.0)

I've published a new version which will work for PyCharm Community — 2021.3 — 2023.2.1. It is pending approval (version 0.0.15).
I will close this issue when it is approved.

The plugin has been approved.


Update Site Wide Settings

Update the site-wide settings, including specifically docs\_sass\minima\_base.scss, to reflect the change in project name to ContaX.

Closed in commit 6cc4723.


Reconnect issue

Hi,
I'm using this source to create a command line bot. But if I disconnect from a server I will not be able to reconnect to that server.
public static void connect(MinecraftProtocol protocol, String host, int port) {

	Client client = new Client(host, port, protocol, new TcpSessionFactory(Proxy.NO_PROXY));
	client.getSession().setFlag(MinecraftConstants.AUTH_PROXY_KEY, Proxy.NO_PROXY);
	client.getSession().addListener(new SessionAdapter() {
		@Override
		public void packetReceived(PacketReceivedEvent event) {
			if (event.getPacket() instanceof ServerChatPacket) {
				Message message = event.<ServerChatPacket> getPacket().getMessage();
				System.out.println("  " + message.getFullText());

			}
		}

	});

	client.getSession().connect();

	BufferedReader is = new BufferedReader(new InputStreamReader(System.in));

	while (client.getSession().isConnected()) {
		try {
			String line = is.readLine();
			if (line.equalsIgnoreCase("/disconnect")) {
				client.getSession().disconnect(null);
				System.out.println("Disconnected!");
			} else {
				client.getSession().send(new ClientChatPacket(line));
			}

		} catch (IOException e) {
			e.printStackTrace();
		}
	}
}

So let's say I connect to a server with connect(), disconnect and use connect() again. That would be fine right? But it isn't working so can someone please help me out here!
All help is appreciated,
~ Diego

Try wait few seconds after disconnect. Also connect is not mean that you joined game.

Okay thankyou I will try

Like Java sockets, Client/Server instances are not reusable.


Help rst man

Change
Fix #312 by adding a script that takes the --help output of a Votca CLI and output a file containing the help in rst format.
Groff
The help to Groff conversion can be performed using help2man

@junghans  @JensWehner  I think that there is not point in using Python to convert the help output to groff because the help2man command can do that

@junghans  @JensWehner  I think that there is not point in using Python to convert the help output to groff because the help2man command can do that

I am happy with this.

I am happy with this.

@junghans @JensWehner I think that there is not point in using Python to convert the help output to groff because the help2man command can do that

Except then help2man needs to be installed and it currently doesn't work:
$ help2man ./csg_map
help2man: can't get `--version' info from ./csg_map
Try `--no-discard-stderr' if option outputs to stderr

plus I would really like an example and copyright section, e.g.
http://manpages.ubuntu.com/manpages/bionic/man1/csg_map.1.html

@junghans @JensWehner I think that there is not point in using Python to convert the help output to groff because the help2man command can do that

Except then help2man needs to be installed and it currently doesn't work:
$ help2man ./csg_map
help2man: can't get `--version' info from ./csg_map
Try `--no-discard-stderr' if option outputs to stderr

plus I would really like an example and copyright section, e.g.
http://manpages.ubuntu.com/manpages/bionic/man1/csg_map.1.html

okay then what @junghans says. :)

okay then what @junghans says. :)

I renamed the script to votca_help2doc, so better fit with the other tools when installed.
It also need a --help output similar to all other tools, so that we can use itself to generate its own rst and man page.

I renamed the script to votca_help2doc, so better fit with the other tools when installed.
It also need a --help output similar to all other tools, so that we can use itself to generate its own rst and man page.

@junghans  I have added your suggestions

@junghans  I have added your suggestions

The following is the output of running the script on csg_map:
NAME
****
csg_map - Part of the VOTCA package

SYNOPSIS
********
csg_map [OPTION] [OPTIONPARAMETERS]

DESCRIPTION
***********
Convert a reference atomistic trajectory or configuration into a coarse-grained one
based on a mapping xml-file. The mapping can be applied to either an entire trajectory
or a selected set of frames only (see options).
Examples:
* csg_map --top FA-topol.tpr --trj FA-traj.trr --out CG-traj.xtc --cg cg-map.xml
* csg_map --top FA-topol.tpr --trj FA-conf.gro --out CG-conf.gro --cg cg-map.xml
* csg_map --top FA-topol.tpr --trj FA-traj.xtc --out FA-history.dlph --no-map
* csg_map --top FA-field.dlpf --trj FA-history.dlph --out CG-history.dlph --cg cg-map.xml
* csg_map --top .dlpf --trj .dlph --out .dlph --cg cg-map.xml  convert HISTORY to HISTORY_CGV

OPTIONS
*******
::

  Allowed options:
    -h [ --help ]             display this help and exit
    --verbose                 be loud and noisy
    --verbose1                be very loud and noisy
    -v [ --verbose2 ]         be extremly loud and noisy
    --top arg                 atomistic topology file
    --out arg                 output file for coarse-grained trajectory
    --vel                     Write mapped velocities (if available)
    --force                   Write mapped forces (if available)
    --hybrid                  Create hybrid trajectory containing both atomistic
                            and coarse-grained
  Mapping options:
    --cg arg                  coarse graining mapping and bond definitions
                            (xml-file)
    --map-ignore arg          list of molecules to ignore separated by ;
    --no-map                  disable mapping and act on original trajectory
  Trajectory options:
    --trj arg                 atomistic trajectory file
    --begin arg (=0)          skip frames before this time (only works for
                            Gromacs files)
    --first-frame arg (=0)    start with this frame
    --nframes arg             process the given number of frames

AUTHORS
*******
Written and maintained by the VOTCA Development Team<EMAIL_ADDRESS>
COPYRIGHT
*********

Copyright 2009-2011 The VOTCA Development Team (http://www.votca.org)

Licensed under the Apache License, Version 2.0 (the "License"); you may not use this  file
except in compliance with the License.  You may obtain a copy of the License at

       http://www.apache.org/licenses/LICENSE-2.0

Unless  required by applicable law or agreed to in writing, software distributed under the
License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY  KIND,
either  express  or  implied.   See  the  License  for  the  specific  language  governing
permissions and limitations under the License.

The following is the output of running the script on csg_map:
NAME
****
csg_map - Part of the VOTCA package

SYNOPSIS
********
csg_map [OPTION] [OPTIONPARAMETERS]

DESCRIPTION
***********
Convert a reference atomistic trajectory or configuration into a coarse-grained one
based on a mapping xml-file. The mapping can be applied to either an entire trajectory
or a selected set of frames only (see options).
Examples:
* csg_map --top FA-topol.tpr --trj FA-traj.trr --out CG-traj.xtc --cg cg-map.xml
* csg_map --top FA-topol.tpr --trj FA-conf.gro --out CG-conf.gro --cg cg-map.xml
* csg_map --top FA-topol.tpr --trj FA-traj.xtc --out FA-history.dlph --no-map
* csg_map --top FA-field.dlpf --trj FA-history.dlph --out CG-history.dlph --cg cg-map.xml
* csg_map --top .dlpf --trj .dlph --out .dlph --cg cg-map.xml  convert HISTORY to HISTORY_CGV

OPTIONS
*******
::

  Allowed options:
    -h [ --help ]             display this help and exit
    --verbose                 be loud and noisy
    --verbose1                be very loud and noisy
    -v [ --verbose2 ]         be extremly loud and noisy
    --top arg                 atomistic topology file
    --out arg                 output file for coarse-grained trajectory
    --vel                     Write mapped velocities (if available)
    --force                   Write mapped forces (if available)
    --hybrid                  Create hybrid trajectory containing both atomistic
                            and coarse-grained
  Mapping options:
    --cg arg                  coarse graining mapping and bond definitions
                            (xml-file)
    --map-ignore arg          list of molecules to ignore separated by ;
    --no-map                  disable mapping and act on original trajectory
  Trajectory options:
    --trj arg                 atomistic trajectory file
    --begin arg (=0)          skip frames before this time (only works for
                            Gromacs files)
    --first-frame arg (=0)    start with this frame
    --nframes arg             process the given number of frames

AUTHORS
*******
Written and maintained by the VOTCA Development Team<EMAIL_ADDRESS>
COPYRIGHT
*********

Copyright 2009-2011 The VOTCA Development Team (http://www.votca.org)

Licensed under the Apache License, Version 2.0 (the "License"); you may not use this  file
except in compliance with the License.  You may obtain a copy of the License at

       http://www.apache.org/licenses/LICENSE-2.0

Unless  required by applicable law or agreed to in writing, software distributed under the
License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY  KIND,
either  express  or  implied.   See  the  License  for  the  specific  language  governing
permissions and limitations under the License.

What are we doing about the manpage?

What are we doing about the manpage?

What are we doing about the manpage?

@junghans   we  can use help2man like:
help2man xtp_run --version-string=0.1

By passing explicitly a version the xtp_run doesn't need to have --version option

What are we doing about the manpage?

@junghans   we  can use help2man like:
help2man xtp_run --version-string=0.1

By passing explicitly a version the xtp_run doesn't need to have --version option

--version-string=0.1

ok that works but the man page doesn't parse the examples section right:
CSG_MAP(1)                                                                                User Commands                                                                                CSG_MAP(1)

NAME
       csg_map - manual page for csg_map 2021-dev

DESCRIPTION
       ================================================== ========   VOTCA (http://www.votca.org)   ======== ==================================================

       please submit bugs to https://github.com/votca/csg/issues

       csg_map, version 2021-dev gitid: 1742774 (dirty) (compiled Jan  7 2021, 10:20:52) votca_tools, version 2021-dev gitid: 1742774 (dirty) (compiled Jan  7 2021, 10:20:43) gromacs, 2019.6 (double
       precision)

       Convert a reference atomistic trajectory or configuration into a coarse-grained one based on a mapping xml-file. The mapping can be applied to either an entire trajectory or a selected set of
       frames  only  (see  options).  Examples: * csg_map --top FA-topol.tpr --trj FA-traj.trr --out CG-traj.xtc --cg cg-map.xml * csg_map --top FA-topol.tpr --trj FA-conf.gro --out CG-conf.gro --cg
       cg-map.xml * csg_map --top FA-topol.tpr --trj FA-traj.xtc --out FA-history.dlph --no-map * csg_map --top FA-field.dlpf --trj FA-history.dlph --out CG-history.dlph --cg  cg-map.xml  *  csg_map
       --top .dlpf --trj .dlph --out .dlph --cg cg-map.xml  convert HISTORY to HISTORY_CGV

   Allowed options:

Not sure if we could change the output to make that work.
@jens we have the version in --help already, so how hard would it be to add a --version option?

--version-string=0.1

ok that works but the man page doesn't parse the examples section right:
CSG_MAP(1)                                                                                User Commands                                                                                CSG_MAP(1)

NAME
       csg_map - manual page for csg_map 2021-dev

DESCRIPTION
       ================================================== ========   VOTCA (http://www.votca.org)   ======== ==================================================

       please submit bugs to https://github.com/votca/csg/issues

       csg_map, version 2021-dev gitid: 1742774 (dirty) (compiled Jan  7 2021, 10:20:52) votca_tools, version 2021-dev gitid: 1742774 (dirty) (compiled Jan  7 2021, 10:20:43) gromacs, 2019.6 (double
       precision)

       Convert a reference atomistic trajectory or configuration into a coarse-grained one based on a mapping xml-file. The mapping can be applied to either an entire trajectory or a selected set of
       frames  only  (see  options).  Examples: * csg_map --top FA-topol.tpr --trj FA-traj.trr --out CG-traj.xtc --cg cg-map.xml * csg_map --top FA-topol.tpr --trj FA-conf.gro --out CG-conf.gro --cg
       cg-map.xml * csg_map --top FA-topol.tpr --trj FA-traj.xtc --out FA-history.dlph --no-map * csg_map --top FA-field.dlpf --trj FA-history.dlph --out CG-history.dlph --cg  cg-map.xml  *  csg_map
       --top .dlpf --trj .dlph --out .dlph --cg cg-map.xml  convert HISTORY to HISTORY_CGV

   Allowed options:

Not sure if we could change the output to make that work.
@jens we have the version in --help already, so how hard would it be to add a --version option?

@junghans in general adding a version information to application would not be hard, do you want it for all other scripts as well?

@junghans in general adding a version information to application would not be hard, do you want it for all other scripts as well?

@junghans in general adding a version information to application would not be hard, do you want it for all other scripts as well?

If we want to use help2man we will, but there is still the format issues.

@junghans in general adding a version information to application would not be hard, do you want it for all other scripts as well?

If we want to use help2man we will, but there is still the format issues.

which issues?

which issues?

See the formatting here: https://github.com/votca/tools/pull/316#issuecomment-756382263

See the formatting here: https://github.com/votca/tools/pull/316#issuecomment-756382263

ping @felipeZ

ping @felipeZ

I am implementing  the groff writer

I am implementing  the groff writer

@junghans  I have added a GROFF generator following the man page at the csg_map's Ubuntu man page

@junghans  I have added a GROFF generator following the man page at the csg_map's Ubuntu man page

@junghans I have added a GROFF generator following the man page at the csg_map's Ubuntu man page

Thanks!

@junghans I have added a GROFF generator following the man page at the csg_map's Ubuntu man page

Thanks!

@junghans  I think I have introduced all your suggestions

@junghans  I think I have introduced all your suggestions

I am happy with this now, so let's merge it and see what breaks!
There is some follow up clean to do, see #326.

I am happy with this now, so let's merge it and see what breaks!
There is some follow up clean to do, see #326.


Position of Editor is not valid

Starting with v1.2.0 the position of Editor at the task bar is not correct

Fixed with 528056fbf6176181b54e58af625b31bead45f2fa


Configurable help and contact information

Is your feature request related to a problem? Please describe.
Maybe: Playing on too many channels?
Describe the solution you'd like
Channelling support requests in a helpdesk system, such as Zammad (or OTRS).
Describe alternatives you've considered
Helpdesk via Jitsi, as already available in OpenSlides-dev branch.
Additional context

I cannot extract any information from this request.

I could imagine that using Jitsi-Meet as a helpdesk, i.e. using another channel, might be too much effort in the long run. However, if companies / NGOs etc. already use Zammad or OTRS as a helpdesk system, integrating them might make more sense.

The jitsi-meet helpdesk us usually used as an additional support channel for virtual assemblies, where the users tend to require quick help on using OpenSlides. What you require, on the other hand, is a central area to display arbitrary information in a meaningful way. I'll talk with our designers about that, perhaps we can offer something that goes in that direction. For the time being, arbitrary help information can be put on the start page of OpenSlides, which can be designed using HTML at runtime.

seems to be done (start page or jitsi helpdesk room)


Observer not reporting any devices on Mac

With a python3, conda installation, I can run the code, but the observer never sees any devices (whereas I can see other devices when using other ways of scanning for them).
In particular, I was running
 sudo python -m bleson --observer --debug
and got this output:
2022-12-02 11:46:59,346  DEBUG -              __init__.py: 28 -             get_provider(): Provider is <bleson.providers.macos.macos_provider.MacOSProvider object at 0x101351880>
2022-12-02 11:46:59,347  DEBUG -         macos_adapter.py: 99 -   wait_for_event_timeout(): wait_for_event_timeout starting
2022-12-02 11:46:59,347  DEBUG -         macos_adapter.py:101 -   wait_for_event_timeout(): event set: True
2022-12-02 11:46:59,347  DEBUG -         macos_adapter.py: 95 -                      off(): TODO: adatper off
2022-12-02 11:46:59,347  DEBUG -         macos_adapter.py: 92 -                       on(): TODO: adatper on
2022-12-02 11:46:59,408  DEBUG -         macos_adapter.py:171 - centralManagerDidUpdateState_(): State: 5
2022-12-02 11:47:04,348  DEBUG -         macos_adapter.py:110 -            stop_scanning():

In particular, bleak works and reports like 15 devices, with the default scanning example, which is just what is on the main page:
import asyncio
from bleak import BleakScanner

async def main():
    devices = await BleakScanner.discover()
    for d in devices:
        print(d)

asyncio.run(main())

Intel or Apple silicon?
macOS version?
Python version?

On an M1 Mac , macOS 12.6, Python 3.10.8 (homebrew),  I see the same:
2022-12-02 20:12:17,942  DEBUG -         macos_adapter.py: 99 -   wait_for_event_timeout(): wait_for_event_timeout starting
2022-12-02 20:12:17,942  DEBUG -         macos_adapter.py:101 -   wait_for_event_timeout(): event set: True
2022-12-02 20:12:17,942  DEBUG -         macos_adapter.py: 95 -                      off(): TODO: adatper off
2022-12-02 20:12:17,942  DEBUG -         macos_adapter.py: 92 -                       on(): TODO: adatper on
2022-12-02 20:12:17,967  DEBUG -         macos_adapter.py:171 - centralManagerDidUpdateState_(): State: 5
2022-12-02 20:12:22,948  DEBUG -         macos_adapter.py:110 -            stop_scanning():

Which maybe re-assuring, isn't a fix.     But thanks for the heads up.
Any reason why you wouldn't use bleak instead?

M1 Mac, macOS 12.6, and python is:
[Clang 12.0.1 ] on darwin```

Why not `bleak`? [`BLEParser`](https://github.com/Ernst79/bleparser) should work out of box with `bleson` (supposedly), while for `bleak` I need to figure out how to integrate.

From what I recall macOS (and Windows) doesn't give you access to the raw advertisement data, so using BLEParser on anything other than Linux is a dead end.   (You may want to double check that as I'm going back a bit and things can and do change...)
The discovery.py example in bleak scans and find devices ok on my mac.
Bleak should show you what you can get, e.g. manufac data might be enough?

The issue seems to have been a problem noted elsewhere... so I'm leaving this link as a reference.
https://github.com/hbldh/bleak/issues/635

I'm saying that the issue bleak HAD is the issue Bleson HAS.

Still, bleson won't help you on Mac. so closing this as won't fix.

Please see my comment about the raw advertising data on any platform other than Linux.
Even if bleson observing was fixed the same way bleak was I think the BLE Advertising data restrictions of Mac (and windows) would prevent you from being able to use BLEParser anyway.

I'll leave this open as it is a valid bleson issue on Mac.  (Other than, not quick)

Please see my comment about the raw advertising data on any platform other than Linux. Even if bleson observing was fixed the same way bleak was I think the BLE Advertising data restrictions of Mac (and windows) would prevent you from being able to use BLEParser anyway.

BLEParser seems to have some sort of ability to parse things given structured data, but it is indeed yet to be determined whether it can be made to work with data coming from bleson (or bleak). Thanks for the quick responses though!


fix #11 #12 #13 - Add acknowledgment on the home page. Fix nvigation …

…tab for home page. Remove nf-core material which has an incompatible license. Use external-markdown extension to include nf-core page in the course. Add raw/endraw attributes to avoid problem with jinja/Django syntax that use {{ }} as the external-markdown extension system

fix #13
fix #12


Fixing Math in "For Developers" section.

The math was not rendering correctly in the "For Developers" section. I went through it at fixed the formatting. Nothing in the actual math was changed.

thanks, @tomroesch for the fixes - several people have attempted to fix these math typesetting issues, but with only partial success. So it would be really useful if we can preview the changes before merging. However, I'm not sure how to set up a preview workflow on Github. An alternative route is to make sure this math can be built successfully locally.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 81.806%

Files with Coverage Reduction
New Missed Lines
%

src/inference/mh.jl
1
85.19%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1223

Relevant Lines:
1495

💛  - Coveralls

I tried tested the "Variational Inference" site on a different Jekyll based website, and I was not aware of the issues that come up there, so the pages will not render correctly with the fixes that I added. I will give it another run and open a new PR with new fixes that I have tested at least elsewhere.


Deephaven Python v2

Update to use the v2 Deephaven python API, which is present in Deephaven v0.11.0+
Resolves #23

The changes look good. I do have some general questions:

should we elevate Table to the package level, so user can do from deephaven import Table'
_jcompat is referenced in the code, should we make it public by renaming it to 'jcompat'
DHError isn't handled in the code, is that by design?


[BUG] Add volume not mounted to vm

Describe the bug
Use vm's Add volume function to see that the volume is not eventually mounted on vm

To Reproduce
Steps to reproduce the behavior:

create a vm with the name ltang
create a volume named ltang-test
Add the volume ltang-test to the virtual machine ltang through the Add volume function of ltang
Connect to the virtual machine ltang and use the fdisk -l command to view the volume mount，there is no mounted volume

Expected behavior

Support bundle

Environment:

Harvester ISO version: v1.0.0
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context
Add any other context about the problem here.

the added volume was mounted as "/dev/sda"
{"component":"virt-launcher","kind":"","level":"info","msg":"Attaching disk hot1, target sda","name":"test1","namespace":"default","pos":"manager.go:868","timestamp":"2021-12-27T02:36:48.997696Z","uid":"12daffe5-faf5-4ef3-a738-f68626dbc18c"}

I made a mistake in observation


Support TLS Cipher Suites in run-vault

Problem
The Vault server configuration supports a tls_cipher_suites arg in the TLS listener: https://www.vaultproject.io/docs/configuration/listener/tcp.html#tls_cipher_suites. But run-vault does not support updating this arg.
How I'm using the modules
I am making use of the vault-elb and vault-cluster modules, running install-vault through my Packer image as recommended.
One of the changes I made to the default settings was using ECDSA P384 encryption for my TLS certificate.
What problems are caused
My vault server instances work just fine when I ssh onto them. I was able to init the Vault instances with a vault operator init, and vault status looks as I'd expect.
The issue is that I cannot communicate to DNS entry I set up in front of the load balancer, as the health checks are failing.
Running a journalctl -b --no-pager -u vault | tail -n 3 on the Vault server, I see that the error is:
http: TLS handshake error from <lb_ip>:9098: tls: no cipher suite supported by both client a nd server
Proposed Solution
If possible, I'd like to request a new flag in the run-vault script that would add a flag argument that could optionally add a tls_cipher_suites param to the tcp listener.
After this, if needed, users of these modules could update those flags in their user data, which are much easier to change than the run-vault/install-vault scripts.
If desired, I could add support for these flags, so that a run-vault command could look something like:
/opt/vault/bin/run-vault \
  --tls-cert-file "$VAULT_TLS_CERT_FILE" \
  --tls-key-file "$VAULT_TLS_KEY_FILE" \
  --enable-auto-unseal \
  --auto-unseal-kms-key-id "${kms_key_id}" \
  --auto-unseal-kms-key-region "${aws_region}
  --custom-cipher-suites TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA

Please let me know your thoughts!

I was able to solve this by using a Network Load Balancer instead of the classic load balancer from this repo. I can close this issue.


Broken symlinks and/or missing files from  data test set

It seems that there are files missing from the example dataset at https://github.com/a-ludi/dentist-example/releases/download/v1.0.2-2/dentist-example.tar.gz.
Although there are mentions of this in some of the other issue threads, I don't see an open issue thread that specifically for the missing files.
I downloaded your test data set today 9th June 2021:
wget https://github.com/a-ludi/dentist-example/releases/download/v1.0.2-2/dentist-example.tar.gz
tar -xzf dentist-example.tar.gz
cd dentist-example

However, several symbolic links point to a folder called ./dentist-example/ that is missing from the tarball:
~/dentist-example$ ll
total 111M
-rw-r--r-- 1 ubuntu djs217 2.3K Apr 28 04:40 checksum.md5
lrwxrwxrwx 1 ubuntu djs217   54 Apr 26 08:30 cluster.yml -> dentist-example/external/dentist/snakemake/cluster.yml
drwxrwxr-x 2 ubuntu djs217 4.0K Jun  9 13:39 data
-rw-r--r-- 1 ubuntu djs217 1.3K Feb 18 14:42 dentist.json
-rwxr-xr-x 1 ubuntu djs217 111M Apr 27 08:52 dentist_v1.0.2.sif
lrwxrwxrwx 1 ubuntu djs217   66 Apr 26 08:29 profile-slurm.drmaa.yml -> dentist-example/external/dentist/snakemake/profile-slurm.drmaa.yml
lrwxrwxrwx 1 ubuntu djs217   73 Apr 26 08:29 profile-slurm.submit-async.yml -> dentist-example/external/dentist/snakemake/profile-slurm.submit-async.yml
lrwxrwxrwx 1 ubuntu djs217   72 Apr 26 08:29 profile-slurm.submit-sync.yml -> dentist-example/external/dentist/snakemake/profile-slurm.submit-sync.yml
-rw-r--r-- 1 ubuntu djs217 4.5K Apr 27 08:54 README.md
lrwxrwxrwx 1 ubuntu djs217   52 Apr 26 08:29 Snakefile -> dentist-example/external/dentist/snakemake/Snakefile
-rw-r--r-- 1 ubuntu djs217 3.8K Apr 28 04:40 snakemake.yml

Many thanks,
David

Hi David,
thanks pointing this out! I am preparing a new release which will include the example with this issue fixed. The new release will be finished one of these days. If you cannot wait for it please copy the files from GitHub:

cluster.yml
profile-slurm.drmaa.yml
profile-slurm.submit-async.yml
profile-slurm.submit-sync.yml

Thanks for you patience!

Thank you! I will test this with the downloaded files tomorrow.
Thanks for the prompt response and advice on where to download the files.
Best wishes,
David
From: Arne @.>
Reply to: a-ludi/dentist @.>
Date: Wednesday, 9 June 2021 at 16:52
To: a-ludi/dentist @.>
Cc: "Studholme, David" @.>, Author @.***>
Subject: Re: [a-ludi/dentist] Broken symlinks and/or missing files from data test set (#21)
CAUTION: This email originated from outside of the organisation. Do not click links or open attachments unless you recognise the sender and know the content is safe.
Hi David,
thanks pointing this out! I am preparing a new release which will include the example with this issue fixed. The new release will be finished one of these days. If you cannot wait for it please copy the files from GitHub:

cluster.ymlhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fa-ludi%2Fdentist%2Fd85a86fda8da241b0de3d3b8d3b02cf9e3405302%2Fsnakemake%2Fcluster.yml&data=04|01|D.J.Studholme%40exeter.ac.uk|5988fcc4477a430b20d108d92b5e9100|912a5d77fb984eeeaf321334d8f04a53|0|0|637588507424151044|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=inRGvEjg7Y%2Btikcz9KwaZ08E4Qsj5WAztu9OrlphZ8I%3D&reserved=0
profile-slurm.drmaa.ymlhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fa-ludi%2Fdentist%2Fd85a86fda8da241b0de3d3b8d3b02cf9e3405302%2Fsnakemake%2Fprofile-slurm.drmaa.yml&data=04|01|D.J.Studholme%40exeter.ac.uk|5988fcc4477a430b20d108d92b5e9100|912a5d77fb984eeeaf321334d8f04a53|0|0|637588507424151044|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=hmy%2FpHoPhHbKPoTfUC57Mdko%2FMFRRyuLuwXgd54fwXo%3D&reserved=0
profile-slurm.submit-async.ymlhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fa-ludi%2Fdentist%2Fd85a86fda8da241b0de3d3b8d3b02cf9e3405302%2Fsnakemake%2Fprofile-slurm.submit-async.yml&data=04|01|D.J.Studholme%40exeter.ac.uk|5988fcc4477a430b20d108d92b5e9100|912a5d77fb984eeeaf321334d8f04a53|0|0|637588507424161298|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PC3oazcVKGzg%2Bc872%2FNpcl20%2Fculbuc51LY6POAwNJE%3D&reserved=0
profile-slurm.submit-sync.ymlhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fa-ludi%2Fdentist%2Fd85a86fda8da241b0de3d3b8d3b02cf9e3405302%2Fsnakemake%2Fprofile-slurm.submit-sync.yml&data=04|01|D.J.Studholme%40exeter.ac.uk|5988fcc4477a430b20d108d92b5e9100|912a5d77fb984eeeaf321334d8f04a53|0|0|637588507424161298|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=dLZdaGneCeoos0Zl7K93nhFbjTYTf0jJkKEHTpadPsc%3D&reserved=0

Thanks for you patience!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fa-ludi%2Fdentist%2Fissues%2F21%23issuecomment-857823277&data=04|01|D.J.Studholme%40exeter.ac.uk|5988fcc4477a430b20d108d92b5e9100|912a5d77fb984eeeaf321334d8f04a53|0|0|637588507424171038|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=e9HlA5Q9x4N24NFS0WjBzwL5E%2FBS%2Bt7PqWs%2FpBaJQE8%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAXKLNXRIXPGDJB3TGGTQXLTR6E2NANCNFSM46MCUCYA&data=04|01|D.J.Studholme%40exeter.ac.uk|5988fcc4477a430b20d108d92b5e9100|912a5d77fb984eeeaf321334d8f04a53|0|0|637588507424171038|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=wW4W8oqzR9Eb3GUeZ9nKUXCHt6pnQ5MEKuryGL6%2BELQ%3D&reserved=0.


Shotgun related mods

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the feature
Would be nice if you can also implement this
https://thunderstore.io/c/lethal-company/p/axd1x8a/LCAmmoCheck/
https://thunderstore.io/c/lethal-company/p/Hexi/HexiBetterShotgun/
https://thunderstore.io/c/lethal-company/p/Horsey4/ShotgunFix/
https://thunderstore.io/c/lethal-company/p/kim_bird/ShotGunMissFireFix/

Maybe in the future I will add functionality from these mods

In version 1.1.0 (https://github.com/Hypick122/BetterShotgun/commit/acd8d3a1319e280b597023e2e69c3802aed67dfc) I added functionality from ShotGunMissFireFix and LCAmmoCheck (still worse than the original)

@Hypick122 here are some tweak that you may consider to change

Change ShotgunShell shop name from "Ammo" to "Shells"

Everything that changing vanilla behavior should be default disable
MisfireOff and ShowAmmoCount is okay to be default enable

Shell Rarity Default to -1
ReloadKeybind Default to E
AmmoCheckAnimation Default to false

also you can close this issue when AmmoCheckAnimation already stable enough or at any time
HexiBetterShotgun & ShotgunFix i'm consider as optional since their implement is still stable enough
and thanks for your work, Great mod!


adding an optional boolean to remove ios-blue styling for phone numbe…

Adding a boolean to hide iOS blues for phone numbers and addresses. You can still wrap these elements in anchor tags to give them the appropriate anchor styles.

@tdhartwick This looks good - but it also removes the contributing.md file? Is that intended?
Is there an issue open that this closes?

@rafibomb Looks like this would close #442. #640 is related but it's not clear that this would fix that one.


Not able to get sorted content when using reactive form In Array of json.

example?

no information => closing


Add alternative url for prometheus metrics

Add /_metrics/prometheus metrics url to make it easier to get it working in Kubernetes using Proemtheus annotations.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage decreased (-0.1%) to 91.185% when pulling 40739dbaf83c99e1eda6d10f3032321a1f446175 on mblaschke:feature/prometheus-metrics-alt-url into 875a4af155281b112b43b68d4c3c995baf3b0546 on square:master.

Hi @mblaschke, this looks good. I'm not super familiar with Kubernetes, is there anything I should know going forward to make this type of stuff easier? Is a Prometheus annotation something you set in a config?

You annotate Pods (bunch of containers but mostly one container) with a scrape configuration which seems not be able to include query parameters.
Using /_metrics/prometheus works fine.
Kubernetes annotations:
      annotations:
        prometheus.io/path: /_metrics/prometheus
        prometheus.io/port: "6060"
        prometheus.io/scrape: "true"

Ah, is that a YAML? It might need ' if you want to have special chars like ?.

It seems that prometheus parses the URL correctly but also escapes the url. The URL is visible in the backend but throws a 404 every time.
Maybe it's a limitation of the automatic scraping using the Kubernetes API.

Merged into master. I also did an analogous change to expose JSON metrics in /_metrics/json, and updated the integration test for metrics accordingly.


Focus the scene tree dock after hitting one of the "Create Root Node:" buttons

See https://github.com/godotengine/godot-proposals/issues/2850
You can now create a new scene using the "Create Root Node:" buttons and hit Enter/F2 to rename the root node (previously it only worked when using the "Other Node" button).

Needs a rebase.

Rebased

You'll need another rebase due to a temporary CI issue fixed since, sorry :|

Rebased again :)
Ideally I'd like to also automatically select rename when creating the root node of a new scene to close https://github.com/godotengine/godot-proposals/issues/2850 (IMO it's pretty rare to leave the root node of a scene as the default node name), but it's not as simple as adding a _tool_selected(TOOL_RENAME); (that looks like this, the "2D" get's cut off of "Node2D"):

It also prints this error to the console:
ERROR: Condition "!metadata.has(p_name)" is true. Returned: Variant()
   at: Object::get_meta (core\object.cpp:1067)

Anyways, this is probably good enough for now.

Thanks!

Cherry-picked for 3.4.


SiteWrapper

This takes the SiteWrapper component used in the example site and creates a reusable Site.Wrapper tabler-react component. In addition, SiteHeader and SiteNav both gain new shorthand hand props.
Other bits and pieces:

FormMaskedInput fixed type issue
AccountDropdown and Notification prop types are now exported

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


upstream: clean up feature parsing code

Additional Description:
Fixing a perfectly safe and fairly terrible version merge in the ALPN pr the "refactor all upstream config" PRs.
the original code created the new options for new config, and parseFeatures handled parsing features from either the new options, or the old config.  I decided that was too complicated, changed the code to always create the new options struct and forgot to clean up parseFeatures to assume the presence of the new options struct and remove handling things the old style way.
Risk Level: low (clean up inaccessible code)
Testing: added one extra unit test just because
Docs Changes: n/a
Release Notes:  n/a

@lizan this should be good to go

@lizan this should be good to go