Increase test coverage of Collection::Element.

Coverage increased (+0.3%) to 44.853% when pulling 07ec0471915c0570e47f3731141abfaadb4d33aa on collection-tests into 59a105aad8047d8a2f98b4759376ffcb0ca2b3dd on master.

Coverage increased (+0.3%) to 44.9% when pulling b6b10d71ed22b58641cbaf4d7f2826490d1969a9 on collection-tests into 59a105aad8047d8a2f98b4759376ffcb0ca2b3dd on master.

Coverage increased (+0.4%) to 44.971% when pulling 5a6efc913a52a5dff7ed7c4051fa49fa3b8505c3 on collection-tests into 59a105aad8047d8a2f98b4759376ffcb0ca2b3dd on master.

Coverage increased (+0.5%) to 45.023% when pulling 02d54497e56dc34959a9161d67215ab2df7b4ce8 on collection-tests into 59a105aad8047d8a2f98b4759376ffcb0ca2b3dd on master.

Coverage increased (+2.6%) to 47.136% when pulling f07681b4a969efd5abea129c5db062b8ef710e19 on collection-tests into 59a105aad8047d8a2f98b4759376ffcb0ca2b3dd on master.

Coverage increased (+3.0%) to 47.559% when pulling f314ab6a02441a7dc9c7e61b99c8f505bc0665a6 on collection-tests into 59a105aad8047d8a2f98b4759376ffcb0ca2b3dd on master.

Coverage increased (+3.2%) to 47.746% when pulling f2f98d6cb65a850392d75c77ec7f47e2c1f4dcf9 on collection-tests into 59a105aad8047d8a2f98b4759376ffcb0ca2b3dd on master.

Coverage increased (+3.9%) to 48.498% when pulling 756cfac2bb28509df01d3253f8fa363689672e90 on collection-tests into 59a105aad8047d8a2f98b4759376ffcb0ca2b3dd on master.

Coverage increased (+4.02%) to 48.589% when pulling b8063ad380ab5b55c25edf87b01422aea433d6b9 on collection-tests into 59a105aad8047d8a2f98b4759376ffcb0ca2b3dd on master.


'No such module' when trying to import framework in playground

Running xCode 7.3
have tried to delete the derived data and rebuild as in another issue but still no luck

To fix;
Schema ---> Manage Schema ---> Check AlamoFire
Build AlamoFire
Go back to play ground and its all good.


Poppins Font

Add variable
import<EMAIL_ADDRESS>// Contains ONLY variable weights and no other axes.
import<EMAIL_ADDRESS>// Italic variant.
// Or
import<EMAIL_ADDRESS>// This contains ALL variable axes. Font files are larger.
import<EMAIL_ADDRESS>// Italic variant.

That's up to google/fonts, not me. I can't add this without them sourcing the variable font files.


Upgrade to node 10

This PR upgrades to node 10. This has been tested with:

Debian Buster on a Raspberry Pi. Since Nodejs 10 is available in Debian Buster, this removes the need for installing node from nodesource.com
Debian Buster on x86_64
The Dockerfile that ships with signalk-server-node

This should solve:
https://github.com/SignalK/signalk-server-node/issues/546
https://github.com/SignalK/signalk-server-node/issues/823

Do you know what this resolves to now? It could be explicitly 10 I think.
https://github.com/SignalK/signalk-server-node/blob/master/.travis.yml#L3

Yes, it's 10 currently. So until 2020 we're good. I could pin it to 10 instead as well.


Change "agent" to "openhermes" in Ollama example

Is a response to solve issue: https://github.com/joaomdmoura/crewAI/issues/31


Come up with some official notes on governance/flow chart of process

Consensus seems to be that this is less necessary than I thought. I think I'm going to close this and consider the discussions we've had the informal flowchart.


fix: inject path to strategy when building manifest from config

Fixes #1883

I can try when I have some time

Hello @xabufr, any chance you will have time to work on the requested test?


refactor: [M3-6694] - Convert  to functional component

Description 📝
Converts the App class component to a functional component, using hooks instead of containers where possible. This is useful for the RQ Events work since that query is awkward to deploy as a container.
Major Changes 🔄

Make App a functional component

How to test 🧪

Ensure the Cloud Manager loads and works normally.
Ensure <TheApplicationIsOneFire /> component is displayed when the app crashes (you can add a random throw statement to trigger a crash).
Ensure NewRelic and analytics scripts load and work as intended.
Ensure keyboard shortcuts to change theme/open go-to menu work.
Ensure event handlers work (e.g., the linodes cache is invalidated when an update event comes in)
Unit tests: yarn test
E2E tests: yarn cy:e2e

Looks like the unit test needs to be updated. Might need to move away from enzyme


Improve display of results of Implementations to include symbol/container names

When running "Find all Implementations", extensions can currently only return ranges in a document and no information abotu symbols (and as far as I can tell, VS Code doesn't use these ranges to look up symbol information). This means the implementations lists are quite sparse and miss useful information such as the classes.
For example:
abstract class A {
	foo(): void { } // Find All Implementations on 'foo'
}

class B extends A {
	foo() {}
}

class C extends A {
	foo() {}
}

Shows this:

The entries have no indication of the classes they're in, they just show a snippet of text. It would be useful if you could tell which classes these implementations belonged to (either by allowing extensions to provide it, or using symbol data to look it up).

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Error in "code-block" directive:      maximum 1 argument(s) allowed, 2 supplied.

Hello, I'm trying to set the arguments in the directives, but get an error:
.. code-block:: python
    :linenos:

    print("Hello!")

$ rstcheck source/hello.rst
source/hello.rst:87: (ERROR/3) Error in "code-block" directive:
maximum 1 argument(s) allowed, 2 supplied.

.. code-block:: python
    :linenos:

    print("Hello!")

Without :linenos: work OK

Is :linenos: some Sphinx-specific thing? If so, please see #1, #2, #3, and #4.

There is an idea to include it directly from sphinx

This is fixed in #6.


Trouble w/ SCPI_ResultDouble

Hello,
I'm developing an embedded ARM Project (ARM7TDMI, Atmel AT91SAM7X128). While integrating SCPI told me about issues with some newlib stuff (which I could solve), I'm now in trouble when trying to display double numbers. Doing multiplactions with them is not a problem, though.
My question: What standard libraries do you rely on? Do you maybe have a suggestion where I can look, what to fix? Unfortunately I cannot connect via JTAG to the controller (and don't have access to UART yet).
I will do a workaround for the time being, but I would be happy if I could fix this later. I'm also looking into other ressources, but maybe there is a hint/fix available for this I think could be a common issue on embedded systems without native floating point support.
Thx in advance!
P.S.: SCPI_ResultDouble and SCPI_ResultText (in conjunction with SCPI_NumberToString) crash.

Conversion from string to double is easy and it uses strtod but there is no good way to convert double to string.
On AVR, I'm using dtostre on other platforms, snprintf(...., "%lg", ...) is used. snprintf has big disadvantage that it uses malloc/free and it needs lot of heap memory - start at least with 4kB. If you don't have working malloc, or your heap is smaller then 4kB, it will fail.
In config.h there is define SCPIDEFINE_doubleToStr(v, s, l) where v is double value, s is result string and l is a length of provided string buffer. Return value should be length of result string. If you have better implementation of doubleToStr, you can just redefine this macro.
We can start with http://stackoverflow.com/questions/7228438/convert-double-float-to-string there is a link to musl-libc library, which is licensed under MIT licese (so compatible with us). And it is possible to extract double to string conversion from there.

I would like to implement some minimal and not so precise implementation of this, so we can live without sscanf on limited platforms.

I added new function in c51c359b7601f4f071444a4579d1678b5aac7d06. It is based on old FreeBSD's implementation of fcvt. If you define USE_CUSTOM_DTOSTR as 1 in config.h, it will use this function in double and float to string conversion functions. It is still not perfect, because it needs 310 bytes on stack. I would like to minimize this, but I don't have much time to study the conversion algorithm.
It is still better for minimal systems, because sprintf needs about 4k on heap and needs malloc.


feat: Add terraform module

Adds a terraform module, as designed in CC006 - Terraform modules organization in the Juju ecosystem spec. The module facilitates the deployment of argo-controller charm, using the Terraform juju provider.
Since the spec is not finalized yet, the PR may miss features/decisions that are still under discussion.
Parts where we deviate from the spec

Omitted units from variables (inputs). This is because CKF charms have not been designed to function with more than one units.

Decisions that are still under discussion in the spec

outputs.tf and variables.tf are (and should be) in alphabetical order as per Terraform style guide.
outputs provides and requires endpoints.
variable channel has null as default value to replicate native juju behaviour, which also asks Charmhub about the default channel, if it's not provided. The spec leaves that up to the developers.
variable app_name has a default value, same as the one in juju_application.argo_controller.charm.name. This is because juju deploy native behavior uses the charm.name as the application name, if none is provided.

Additional implementation notes

.gitignore: I added things that didn't need to be commited. Not 100% sure this covers everything.

CI
Regarding the CI, there is a comment in the spec by Ghislain where he mentioned that "the first implementation steps for this spec will be to create shared workflows". Thus, I think we shouldn't block too much on the CI right now. I 'd prefer if we removed it completely than spend too much time reviewing it, since it will change in the future. That being said, here are the implementation details about it.

This is to be merged after https://github.com/canonical/charmed-kubeflow-workflows/pull/58. I updated there the lint job in order to install tflint, which cannot be installed as a pip dependency.
For running terraform fmt and terraform validate,  we are using Telco team's reusable workflow . An example of its usage can be found here).
CI is using reusable workflow to deploy terraform module from https://github.com/canonical/charmed-kubeflow-workflows/pull/59

Closes #196
Referenced work

https://github.com/canonical/mimir-worker-k8s-operator/pull/74
https://github.com/canonical/terraform-juju-sdcore/tree/main/modules/sdcore-control-plane-k8s

(optional) TO DO

[x] Create a reusable workflow under charmed-kubeflow-workflows similar to https://github.com/canonical/sunbeam-terraform/blob/main/.github/workflows/deploy.yml in order to make a simple deployment using the module

Testing
The terraform can be used with a terraform apply like the one below, using only the arguments that are needed.
terraform apply -var "app_name=argoo" -var "channel=3.4/stable" -var "model_name=kubeflow" -var "resources={oci-image: 3}"

Thank you @DnPlas. @hmlanigan let me know that changes look good, so I went ahead and resolved those. Merging..


audioplayers fails in 0.12.0 with issues in path_provider

"Because flutter_gongke depends on audioplayers ^0.12.1 which depends on path_provider ^1.1.0, path_provider ^1.1.0 is required.So, because flutter_gongke depends on path_provider ^0.5.0+1, version solving failed."
I don't want to upgrade "path_provider" library , because  "flutter_cache_manager" dosen't support it. Are there other ways to be compatible?
My Flutter
[√] Flutter (Channel dev, v1.6.3, on Microsoft Windows [Version 10.0.17134.829], locale zh-CN)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[√] Android Studio (version 3.3)
[√] Connected device (1 available)

You can do this as a temporary fix to make it compile. Add this in pubspec.yaml
dependency_overrides:
  path_provider: ^1.1.0

and comment out path_provider in dependencies.
This is a workaround for now but it will work.

You can do this as a temporary fix to make it compile. Add this in pubspec.yaml
dependency_overrides:
  path_provider: ^1.1.0

and comment out path_provider in dependencies.
This is a workaround for now but it will work.

tks. This method works. See if there are any other problems later.


Per-record changelog does not show changes made through API

When looking at the history of a domain record (Dashboard -> Select Domain -> Click on the clock icon of a record), only changes made by Accounts from the web UI are present.
I believe this is because actions made from UI are logged with "add_rrsets" and "del_rrsets" keys, while actions from the API are logged as the PowerDNS Authoritative API format which is "rrsets". Below are the database entries for API and UI, respectively.
id         | 248
msg        | replace zone A record of test.example.com
detail     | {"rrsets": [{"name": "test.example.com.", "type": "A", "ttl": 86400, "changetype": "REPLACE", "records": [{"content": "<IP_ADDRESS>", "disabled": false}]}]}
created_by | api-test
created_on | 2023-02-08 12:13:08.229078
domain_id  | 3
-[ RECORD 234 ]-
id         | 250
msg        | Apply record changes to domain example.com
detail     | {"domain": "example.com", "add_rrsets": [{"name": "test.example.com.", "type": "A", "ttl": 86400, "records": [{"content": "<IP_ADDRESS>", "disabled": false}], "comments": [{"content": "", "account": ""}], "changetype": "REPLACE"
}], "del_rrsets": [{"comments": [{"content": "", "account": ""}], "name": "test.example.com.", "records": [{"content": "<IP_ADDRESS>", "disabled": false}], "ttl": 86400, "type": "A", "changetype": "DELETE"}]}
created_by |<EMAIL_ADDRESS>created_on | 2023-02-08 12:28:38.131618
domain_id  | 3
-[ RECORD 236 ]

Looks like the following function is responsible for this display. When retrieving logs per record, it only looks for the "add_rrsets" and "del_rrsets" keys.
https://github.com/PowerDNS-Admin/PowerDNS-Admin/blob/c5b9e2460498e28baad214afc8c9217a25d1f4d5/powerdnsadmin/routes/admin.py#L906
My Setup:

Environment: Docker
PowerDNS-Admin image version: powerdnsadmin/pda-legacy:latest
PowerDNS-Admin backend: postgres:15.1
PowerDNS-Authoritative image version: powerdns/pdns-auth-47:latest

Well the API logging has been broken since the new history format was introduced. I stumbled into it too.
Here's my patch to provide decent logging for API replace/delete operations. I'll do a pull request too.
https://github.com/raunz/PowerDNS-Admin/commit/02700ee7b0b53c7adb5b35f03efc6e4382cacd31

Thank you for the quick response @raunz . I have tested your commit and all seems to be good! History table entry for API request is now as below.
id         | 262
msg        | Apply record changes to domain example.com
detail     | {"domain": "example.com", "add_rrsets": [{"name": "test.example.com.", "type": "A", "ttl": 86400, "changetype": "REPLACE", "records": [{"content": "<IP_ADDRESS>", "disabled": false}]}], "del_rrsets": []}
created_by | api-test
created_on | 2023-02-09 09:32:43.888249
domain_id  | 3

I am now able to see changes made by both UI and API.


Keepalive ping

cc @ctiller
No watchdog yet. Just wanna see how the tests fare on Jenkins.

The watchdog is now an urban yorkshire terrier; looks nice in a dog-sweater but is otherwise completely useless.

@ctiller ASAN failures look like leaks due to my use of the combiner. Do combiners have specific lifetime requirements I'm goofing up, or are they supposed to be cleanly handled by the final grpc_shutdown?

ASAN tests pass locally - assigning to reviewers for their feedback.


ManipulationHandlerOriginOffset test has race condition causing unpredictable failures

Describe the bug
Running ManipulationHandlerOriginOffset locally in different branches, I get consistently get inconsistent success/fail results. There is a failure for checking the position of the expected vs actual data components at the very end of the test.
Not exactly sure what is going on but I believe it is causing the CI failures intermittently
To reproduce
In Test Runner, just run selected multiple times and get different results
Expected behavior
This should pass 100% of the time predictably.
Screenshots
If applicable, add screenshots to help explain your problem.
Your Setup (please complete the following information)

Unity Version 2018.4.5
MRTK Version Stabilization branch

Target Platform (please complete the following information)

HoloLens
HoloLens 2
WMR immersive
OpenVR

Additional context
Add any other context about the problem here.

I've also encountered this on the mrtk_development branch, It seems to be non-deterministic. I'm verifying my changes for a PR I'll be putting out today, and it seems like it fails [3-5]/10 times it is run in the mrtk_development branch.

The errors aren't consistent, and sometimes only puts out a position error, and other times will spit out a huge log of errors like so:

Failed for position of object for one hand rotate near, expected (0.000, 0.000, 1.000), was (0.016, -0.049, 1.014)
Failed for rotation of object for one hand rotate near, expected (0.000, 0.000, 0.000, 1.000), was (0.462, 0.191, 0.191, 0.845)
Failed for position of object for two hand rotate/scale near, expected (0.000, 0.000, 1.000), was (-0.041, 0.041, 1.008)
Failed for rotation of object for two hand rotate/scale near, expected (0.000, 0.000, 0.000, 1.000), was (0.000, 0.000, 0.241, 0.971)
Failed for scale of object for two hand rotate/scale near, expected (0.200, 0.200, 0.200), was (0.480, 0.480, 0.480)
Failed for position of object for two hand rotate/scale far, expected (0.000, 0.000, 1.000), was (0.015, 0.055, 1.436)
Failed for rotation of object for two hand rotate/scale far, expected (0.000, 0.000, 0.000, 1.000), was (0.000,
Failed for scale of object for two hand rotate/scale far, expected (0.200, 0.200, 0.200), was (1.079, 1.079, 1.0
Failed for position of object for one hand rotate far, expected (0.000, 0.000, 1.000), was (0.709, 0.006, 0.709)
Failed for rotation of object for one hand rotate far, expected (0.000, 0.000, 0.000, 1.000), was (0.000, 0.383, 0.000, 0.924)

For stabilization branch, looks like BoundingBoxTests.ScaleViaHoloLens1Interaction may need to be added to the list as well. Although harder to notice? succeeded 7/8

@CDiaz-MS and @davidkline-ms FYI

Adding in a WaitForSeconds in ManipulationHandlerOriginOffset() seems to decrease the frequency of failures but not solve it completely
            for (int i = 0; i < vertices.Length; i++)
            {
                vertices[i] += offset;
            }
            mesh.vertices = vertices;
            mesh.RecalculateNormals();
            testObject.GetComponent<BoxCollider>().center = offset;

            testObject.transform.position = Vector3.forward - testObject.transform.TransformVector(offset);

            yield return new WaitForSeconds(1);

            // Collect data for modified cube
            OriginOffsetTest actualTest = new OriginOffsetTest();
            yield return actualTest.RecordTransformValues(testObject);
            yield return null;

This test is failing even when you do not modify the vertices to offset them from the origin. In other words, if you move and record positions of a cube, then reset that cube, then move and record the positions again, they do not match.


transform insert at the same position - incorrect result

As I understand, when the side param to transform is "left", the first operation should "happen" first. However, the logic here seems to be reversed.
> require('rich-text').type.transform([ { insert: 'a' } ], [ {insert: 'b'} ], 'left')
Delta { ops: [ { retain: 1 }, { insert: 'a' } ] } // I'd expect Delta { ops: [ { insert: 'a' } ] }

For comparison:
> require('ot-text').type.transform([ 'a' ], [ 'b' ], 'left')
[ 'a' ] // as expected

I think this line should be changed to return delta2.transform(delta1, side === 'right');

when the side param to transform is "left", the first operation should "happen" first

Do you have a reference for this? The API spec just specifies it how it is used (tiebreakers) and that apply(apply(snapshot, op1), transform(op2, op1, 'left')) == apply(apply(snapshot, op2), transform(op1, op2, 'right')) which is does.

Thanks for the quick reply @jhchen. The spec is very vague wrt to the side param, so no, I don't have a reference. I raised this issue only because the behaviour is inconsistent between rich-text and text and intuitively the latter (text) seems right.
I'd think that apply(apply(snapshot, op1), transform(op2, op1, 'left')) == apply(apply(snapshot, op2), transform(op1, op2, 'right')) would also be satisfied, if the side was "swapped" as I suggested. So, it's your call, if you want to make this change.

Someone can just as easily claim the opposite and rich-text is implementing what the spec describes so I don't see a need to make a breaking change for everyone.


Updates to reflect changes in the provisioning script

Hi @JohnPWSharp, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, AZPRBOT;


Folder Yellow (Vault) Icon

This is an awesome theme, love it.  Noob, question.  Is it possible to chang that ugly yellow (vault) folder icon to match more the dark style theme?

Hi @j4r0-code,
There is a guide on how to customise the Vault Banner Icon here in the Wiki: https://github.com/damiankorcz/Prism-Theme/wiki/Vault-Banner-Icon-Customisation


localization in existing map

Hi,
   Thanks for your excellent work in cartographer. I could create the map using the cartographer with 3D pointCloud2.

   But, I want to perform the localization in the existing map for a mobile robot, at this case:

is there any method that you could recommend ?

are your working on the localization function in existing map in terms of the cartographer?

We are working on this. Please follow #315.

Hi, @SirVer
Thanks  for your reply!
I will track this issue. Looking forward to your excellent work on "localization in existing map".
apart that, could you pls recommend some method else which may able to perform localization in existing 3D map (such as .pcd file )?
Thanks a lot!
Best regards

You could always use AMCL, but we have little experience with it.

Hi, @SirVer
AMCL is a package used in 2D robot localization instead of 3D  localization.
Looking forward your progress in cartographer in terms  of localization in existing map.
best regards

A sorry, yes that is true. I do not know of a 3D localization package that is open source, sorry.

Hi, @SirVer
Thanks a lot anyway, I will try other methods later


opnsense and pfsense openVPN route explanation do not match

If you navigate to VPN -> OpenVPN -> Clients -> Add you can see the following:
On opnsense and pfsense there explanations for these two route push checkboxes are swapped. I am not sure which of both is correct.

image is from pfsense
image is from opnsense

I am opening this on GitHub because it might need to be replaced in the code. Therefore it is maybe also a bug.

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues and I'm convinced that mine is new.

Don't pull routes links to route-nopull
https://github.com/opnsense/core/blob/5dd129c967d001e7c08b06a280624346959faec1/src/etc/inc/plugins.inc.d/openvpn.inc#L922-L924
The other one to route-noexec
https://github.com/opnsense/core/blob/5dd129c967d001e7c08b06a280624346959faec1/src/etc/inc/plugins.inc.d/openvpn.inc#L926-L928
OpenVPN documents its settings here https://openvpn.net/community-resources/reference-manual-for-openvpn-2-4/
I think we're good :)
We forked pfSense more than 5 years ago and went very different directions......

So Don't add/remove routes is route-noexec?
In the OpenVPN documentation route-noexec is explained with Don’t add or remove routes automatically. Instead pass routes to --route-up script using environmental variables. which is what pfsense does. opnsense does mention --route-up Don't pull routes

Looks like you forked a few days/weeks/months too early https://redmine.pfsense.org/issues/4273 ;)

hehe, you're right, even reading it again, I totally missed the swap :) Let me fix that and close the issue..
.... although.... It's never too early to fork pfsense ;)


Only gitignore specific example files

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem?
The docs suggest to not check in an .env file and instead use .env.example and gitignore .env. However, the generated .gitignore ignores all example files. In order to check in an example file I'd have to disable gitignore generation, remove /**/*.example and check the .gitignore in as well.
Describe your solution
I would like to leave the generated .ddev/.gitignore untouched and use my project root gitignore to ignore .ddev/.env and checkin .ddev/.env.example.
It would be great if only the example files generated by ddev, like web-build/Dockerfile.example, would be ignored.
Describe alternatives
No response
Additional context
No response

Hi @dvdmlln - To commit a file that is gitignored, just use git add -f. For example, git add -f .ddev/.env.example

Closing, happy to continue the conversation. Let me know if there's anything to add or you need additional help, happy to continue the conversation here or elsewhere.


[Coverity CID :186196] Error handling issues in /samples/sensor/mcp9808/src/main.c

Static code scan issues seen in File: /samples/sensor/mcp9808/src/main.c
Category: Error handling issues
Function: main
Component: Samples
CID: 186196
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

Fixed via pull request https://github.com/zephyrproject-rtos/zephyr/pull/8046, merge pending

@mandarcthorat1 Hi. We have a new Coverity issue with the same number
I fixed it, #15743


[1.5.x] BXMSPROD-1394 Quarkus to 1.11.7 from 1.11.6

Many thanks for submitting your Pull Request :heart:!
Ticket: https://issues.redhat.com/browse/BXMSPROD-1394
Please make sure that your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Your code is properly formatted according to this configuration
[ ] Pull Request title is properly formatted: KOGITO-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting master: [0.9.x] KOGITO-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

How to retest this PR or trigger a specific build:

Run all builds
Please add comment: Jenkins retest this

Run (or rerun) specific test(s)
Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] tests

Quarkus LTS checks
Please add comment: Jenkins run LTS

Run (or rerun) LTS specific test(s)
Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] LTS

Native checks
Please add comment: Jenkins run native

Run (or rerun) native specific test(s)
Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] native

Full Kogito testing (with cloud images and operator BDD testing)
Please add comment: Jenkins run BDD
This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

The Linux check has failed. Please check the logs.

@danielezonca @cristianonicolai any idea about
ArtifactNotFoundException: Could not find artifact org.kie.kogito:kogito-quarkus-rules-integration-test-legacy
ArtifactNotFoundException: Could not find artifact org.kie.kogito:kogito-quarkus-rules-integration-test-session
ArtifactNotFoundException: Could not find artifact org.kie.kogito:kogito-quarkus-decisions-integration-test
ArtifactNotFoundException: Could not find artifact org.kie.kogito:kogito-quarkus-predictions-integration-test

The fails are all similar. Seems suspiciously like problem in quarkus artifact resolution :/
07:12:36,728 [ERROR] testAdult  Time elapsed: 0.014 s  <<< ERROR!
java.lang.RuntimeException: io.quarkus.bootstrap.BootstrapException: Failed to create the application model for org.kie.kogito:kogito-quarkus-decisions-integration-test::jar:1.5.1-SNAPSHOT
.
.
.
Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact org.kie.kogito:kogito-quarkus-decisions-integration-test:jar:1.5.1-SNAPSHOT
        at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:414)
        ... 49 more

so it's failing at finding the artifact itself ...

@aloubyansky are you aware of one such issue with 1.11.7 [1]?
@jstastny-cz @Ginxo I'd say if we are in a rush we have two choices (1) we ignore the failure and merge nonetheless (pretty risky, especially because I fear the release pipeline would break (2) we stay on 1.11.6 for our own build (1.11.7 should still work if used with our extension)
in the meantime I am trying this locally
[1] interestingly enough I am seeing a similar issue on Quarkus 2 on ecosystem ci https://github.com/kiegroup/kogito-runtimes/runs/2969254706?check_suite_focus=true

@evacchi many thanks man!! I usually choose the safest way in cases like this... So let's wait for your local testing

It might also be related to the issue I was investigating last week. There is some serious issue with your CI but I'm not yet sure what the issue is.

This specific one could be related to the way you clone repos. I guess you clone into kogito-runtimes and then you clone again under kogito-runtimes. So you end up with a nested repo. It may or may not be the cause.

@aloubyansky I just tried this locally and I have no issue by first mvn install -DskipTests and then mvn install could it be this?

@evacchi try the CI layout locally. I.e. do a nested clone. It does look like that's the cause. I think I already fixed in later versions.

So, test the nested repo, not the "outer" one.

@Ginxo I wonder if changing this line :
https://github.com/kiegroup/kogito-runtimes/blob/1.5.x/Jenkinsfile#L61
                mvnCmd.run('clean install')

into
                mvnCmd.run('clean install -DskipTests')
                mvnCmd.run('install')

could fix the issue for now? 🤔  -- I would prefer not to fiddle too much with the dir layout on this branch @aloubyansky

Sure, but it'd be good to know the cause anyway.

yes sure I'll try it rn @aloubyansky

Make sure you clean your local repo when you test that @evacchi

Make sure you clean your local repo when you test that @evacchi

reproduced. Yes the directory layout is the culprit. I am trying if just removing the pom.xml from the root directory could do the trick -- I don't think the outer project is being used at all, it may be even rm -rf ./* for that matter
another trick may be to clone the nested repos into a subfolder e.g. K/kogito-runtimes

BTW, I think this particular issues has been fixed in later versions of Quarkus.

I believe this was the fix https://github.com/quarkusio/quarkus/pull/16751

I am running locally it seems to work so far, try this @Ginxo https://github.com/Ginxo/kogito-runtimes/pull/4

retrying https://eng-jenkins-csb-business-automation.apps.ocp4.prod.psi.redhat.com/job/KIE/job/kogito/job/pullrequest/job/kogito-runtimes/453/ with @evacchi's suggestion

I don't think you have merged it @Ginxo

I don't think you have merged it @Ginxo

No, i didn't, just replayed job adding your changes directly from jenkins (I will in case we agree this is something to commit)

Jenkins retest this

Jenkins retest this

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

Jenkins Tests / jenkinsfile-tests (pull_request) failing is a problem with http usage in dependent pom.
This check can be ignored here as the Jenkinsfile change should not impact.


Fix on-load errors

Loading a brand new world in v10 results in the following two errors:
VM361:1

       Uncaught (in promise) SyntaxError: Unexpected token o in JSON at position 1
    at JSON.parse (<anonymous>)
    at gameSkillsList (swffg-main.js:205:26)
    at Object.fn (swffg-main.js:275:9)
    at Function.#call (foundry.js:361:20)
    at Function.callAll (foundry.js:318:17)
    at Game.initialize (foundry.js:6552:11)
    at window.addEventListener.once (foundry.js:69174:26)

commons.js:4553

       Uncaught (in promise) Error: Data Validation Errors
value: may not be null
    at Setting.validate (commons.js:4553:23)
    at new DataModel (commons.js:4325:26)
    at new Document (commons.js:4909:7)
    at new BaseSetting (commons.js:8777:3)
    at new ClientDocumentMixin (foundry.js:11783:5)
    at new Setting (foundry.js:19384:1)
    at ClientSettings.get (foundry.js:2236:21)
    at Object.fn (swffg-main.js:496:40)
    at Function.#call (foundry.js:361:20)
    at Function.callAll (foundry.js:318:17)

Should be fixed in https://github.com/StarWarsFoundryVTT/StarWarsFFG/tree/foundry-10


signify integration. "Key not present in Dictionary: buffer"

I have been using both signature & signify together without any issues for a long time using
let g:SignatureMarkTextHLDynamic=1
But recently I started getting some different issues. Namely, when editing a file not version controlled (so signify shouldn't do anything), I get the following error:
Error detected while processing function signature#utils#Input[26]..signature#mark#Toggle[51]..<SNR>193_Place[7].
.signature#sign#Place[30]..<SNR>192_RefreshLine[15]..<SNR>192_EvaluateHL[8]..signature#sign#GetSignifyHLGroup[7].
.sy#sign#get_current_signs:
line    4:
E716: Key not present in Dictionary: buffer)
E116: Invalid arguments for function sy#util#execute
E15: Invalid expression: sy#util#execute('sign place buffer='. a:sy.buffer)

After some digging around I found that the sy dictionary gets created, but not populated. For example:
echo(b:sy)
returns:
{'internal': {}, 'external': {}}
I fixed this problem in vim-signature by changing the file:
vim-signature/autoload/signature/sign.vim
line 308-310. From:
  if !exists('b:sy')
    return ""
  endif

to
  if !exists('b:sy.buffer')
    return ""
  endif

Now everything seems to works as excepted again. Thanks for a great plugin.

Thank you for this fix.


flutter_google_ad_manager/flutter_google_ad_manager-Swift.h file not found

While trying to build the project in both Android Studio and Xcode, there was this error that prevented the build from completing:
/Users/user/.pub-cache/hosted/pub.dartlang.org/flutter_google_ad_manager-0.7.0/ios/Classes/FlutterGoogleAdManagerPlugin.m:2:9: fatal error: 'flutter_google_ad_manager/flutter_google_ad_manager-Swift.h' file not found

@UtopiaMint Please check the following.
https://github.com/ko2ic/flutter_google_ad_manager/wiki#ios


Thread safe of ServiceState

BUG REPORT

There is a  #getServiceState() method existed in DefaultMQPullConsumerImpl, as well asDefaultMQPushConsumerImpl, application will get a wrong state by #getServiceState() if another thread haven't finish the #start() but already set state to ServiceState.START_FAILED;
Make the read and write of serviceState much safer  both in DefaultMQProducerImpl and DefaultMQAdminExtImpl.

这个我们之前在生产遇到过。哈哈，看这个pr

pr#3066

@lwclover 谢谢Thanks♪(･,･)ﾉ老铁，我看看。


Plugin request for Buf Schema Registry for grpc-dart

Not ready to open an issue, but want to chat about your plugin? Come find us on our Public Slack channel:
https://buf.build/links/slack
Mandatory
Where is the source code for the plugin?
Example, the source code for the protoc-gen-connect-go plugin is found here:
https://github.com/grpc/grpc-dart
thanks!

Hey there, please take a look at this https://github.com/bufbuild/plugins/issues/760#issuecomment-1697941615. There's not much for us to add here.

thanks!


feat: add kubeflow-dashboard sidebar relation

Adds the sidebar relation for kubeflow-dashboard, plus the library to manage it.  This allows this charm to request a link in the kubeflow dashboard's sidebar.

I would add integration tests for this new relation.

After discussion within the team, we decided to reduce the testing here. Each application using the kubeflow-dashboard-links lib will have no integration tests for that in the charm itself, and instead we will catch that at bundle-level tests (captured as issue https://github.com/canonical/bundle-kubeflow/issues/636)

tests are failing but I think unrelated to the new dashboard links in this pr


Adding week number to weeks displayed

How could I add the week number to each week displayed?

Do you want it like this?
calm:

calw:

This is fine. Having it at the beginning of the week is even finer :-)

Is this okay?

That would be great. And make that an option (like --weeknumber)?

Ok I made it an option (--week-numbers) on my fork off the latest master branch.
I made the change here: https://github.com/kpence/gcalcli/commit/50b0cc5b8b0ef616722aa29917d645daf7398468
50b0cc5b8b0ef616722aa29917d645daf7398468
Example usages:
gcalcli calm --week-numbers
gcalcli calw --week-numbers

@kpence would you want to send a PR to upstream the same change here?


Loaded Image for Button is Too Padded

<mx:Application xmlns:fx="http://ns.adobe.com/mxml/2009" xmlns:mx="library://ns.apache.org/royale/mx"
	applicationComplete="init()"
	width="600" height="400">
	<fx:Script>
	<![CDATA[
		import mx.containers.HBox;
		import mx.controls.Button;

		private function init():void
		{
			var buttonContainer:HBox = new HBox();
			this.addChild(buttonContainer);
			var minimizeButton:Button = new Button();
			minimizeButton.width = minimizeButton.height = 16;
			minimizeButton.icon = "icon_close_up.png"
			buttonContainer.addChild(minimizeButton);
			var maximizeButton:Button = new Button();
			maximizeButton.width = maximizeButton.height = 16;
			maximizeButton.icon = "icon_close_up.png";
			buttonContainer.addChild(maximizeButton);
		}

	]]>
	</fx:Script>
</mx:Application>

Above application has an overflow on the HBox after the icons are loaded. This seems to be caused by these lines in Button.as
var img:HTMLImageElement = event.target as HTMLImageElement;
		element.style["padding-left"] = String(img.naturalWidth+4)+"px";

I'm not sure what the purpose of this was (added by @pentapache ).

I suspect that code is to put 4 pixels of padding between the image and the label.
I think you may just be running into another deferred layout situation like you did in #790.  The Button will be measured before the image gets loaded so will need to be re-measured when the image loads.

The thing is the style.width and style.height are correct, so I don't think measuring will help. What's overflowing is the button contents (bg image in this case).

I just confirmed call BoxLayout.measure() doesn't change anything because explicitWidth is set on the children.

I have a similar issue related with icon image of button. Button size iş dider than the image size, behaves diffrent compared with flex.

I have a similar issue related with icon image of button. Button size iş dider than the image size, behaves diffrent compared with flex.

Actually, here it seems to be the other way around. The button size (width: 16px) is more narrow than the size calculated by Chrome (21px). I was reading that box-sizing: border-box; should prevent that but that doesn't seem to be the case. I guess this is a css issue we'll need to explore.

Ah, sorry, I didn't notice that the button had explicit width/height.  Is element an  or  or ? Possibly the fix is to detect that there is no label and set padding to 0.  The 4 is probably a guess at standard gap between elements when you have

Closed with  9d6252d

Icon on the button fits good now but i think some styling is still needed for buttons with icon image.
flex :

royale :


Add checkbox to onboarding to approve terms / privacy

Description:
We need to let users decide if they approve or decline terms/privacy policy in order to use Ruuvi Station app.
We will force users to see the onboarding screens when they install this new version.
There are 3 different scenarios:
New user, who just installed app
Old user, who updates app and is not signed in
Old user, who updates app and is signed in

We will show on last page of the onboarding (before sign up/sign in) checkbox for approving terms & conditions.

Note:
New user will see last page with string: onboarding_thats_it
Signed in user will see last page with string: onboarding_thats_it_already_signed_in

Grey out Next button if terms checkbox is unchecked. If user checked checkbox and selected Next, we will allow to continue to Benefits screen.
Terms and conditions will be a link that opens in default browser. Link: https://ruuvi.com/privacy/
If old user updates app, we will show onboarding once to user, so he will need to approve terms & conditions in order to use the app. If user is signed in, we will skip sign in / sign up screens and land him on home screen.

We we will write to sentence to approving terms and conditions mention that

User approves terms and conditions and privacy policy
User approves collecting statistics and crash reports anonymously to improve service

iOS card: https://github.com/ruuvi/com.ruuvi.station.ios/issues/2022
Web card: https://github.com/ruuvi/com.ruuvi.station.webui/issues/414

QA passed


Feat: Add WhatsApp integration

Added capability to send encrypted messages thought WhatsApp as like twitter.
It uses the phone numbers. Just put full number as handle.
Ex:<PHONE_NUMBER>88

I tried to run here and got an error:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'dataset')     at findWhatsappNumber (content.js:50:75)
I'm using brave browser on Linux.

Thaks for the feedback. I'll check it tonight when I got from work.

@sarsey-walker I updated your version to be compatible with Twitter desktop/mobile and Whatsapp. The file contents.js.zip is attached (just unpack it to the /src folder)
Please check if it works in your environment, and then you can submit it.
content.js.zip

@eddieoz I worked based on this file. Fixed some errors and is working fine on brave at windows. MAYBE that error from linux was gone. I'll check linux 'till morning bc i need some sleep


Iterate all dictionary key types in cast test

Which issue does this PR close?

Closes #.
Rationale for this change

Increasing test coverage. Per the comment https://github.com/apache/arrow-rs/pull/3482#discussion_r1065506680, the dictionary key types are chose arbitrarily and we can improve it.
What changes are included in this PR?

Are there any user-facing changes?

What's the rationale for this choice of dictionary keys

This is the comment. I thought it was referring the dictionary keys?

How strange, on my phone it links to https://github.com/apache/arrow-rs/pull/3482#discussion_r1065505943


Background cmd.exe process left on Windows when launched from command line

Description of your problem
What steps will reproduce the problem?

Open a Windows command prompt
Get a virtual environment available that has spyder and its dependencies (I use conda, so activate myenv)
Launch spyder by running the spyder command
Close spyder
Open up task manager or process explorer and view current processes. Notice there is a cmd.exe that was left by spyder

What is the expected output? What do you see instead?
When closing spyder, it's parent cmd.exe should not be left
Please provide any additional information below
This "hanging" process is particularly troublesome because it places a lock on the working directory when the spyder command was launched (meaning it cannot be deleted, renamed, etc.) without manually killing the process
Versions and main components

Spyder Version: 3.1.4
Python Version: 3.5.2
Qt Version: 5.6.0
PyQt Version: 5.6.0
Operating system: Windows

Dependencies
Please go to the menu entry Help > Optional Dependencies (or
Help > Dependencies), press the button Copy to clipboard
and paste the contents below:
jedi >=0.9.0     :  0.9.0 (OK)
matplotlib >=1.0 :  1.5.3 (OK)
nbconvert >=4.0  :  4.2.0 (OK)
numpy >=1.7      :  1.11.2 (OK)
pandas >=0.13.1  :  0.19.1 (OK)
pep8 >=0.6       :  1.7.0 (OK)
pyflakes >=0.6.0 :  1.3.0 (OK)
pygments >=2.0   :  2.1.3 (OK)
pylint >=0.25    :  1.5.4 (OK)
qtconsole >=4.2.0:  4.2.1 (OK)
rope >=0.9.4     :  0.9.4-1 (OK)
sphinx >=0.6.6   :  1.4.8 (OK)
sympy >=0.7.3    :  None (NOK)

What do you mean by a cmd.exe? Is there a system terminal left open?

Sorry for the confusion. When I launch spyder from the command line, it is initiated as a subprocess of the terminal window I had open. Here is what the process tree looks like after launching spyder using Process Explorer:

When spyder is launched, the terminal window spyder was instantiated from is closed. I assume that is because spyder is opened using pythonw.exe, but I could be wrong. After I close spyder the process tree looks like this:

The parent process is still open. There is no terminal window open as evidence. This process holds file locks to the working directory when spyder was launched. Only after manually killing this process am I able to delete/rename files in that directory.

I see, thanks for the detailed explanation. Now I understand what's happening.
We'll try to fix this in a future release.

After upgrading to version 3.2.6, it appears this is no longer a problem. My Windows command prompt no longer closes, and when I close spyder I am returned to the command prompt.

That's right, we changed the default behavior so that now Spyder doesn't hide automatically the terminal from which it's started.

Thanks you for the work! I appreciate it


[Monitoring v2] include grafana link on cluster dashboard metric tabs

in cluster dashboard, please include links to grafana similar to how it is in v1 .

verified on v2.5-head (31f00c1):
new links are working as expected and bring user to grafana dashboard, displaying metrics that were on the cluster dashboard

tested ETCD summary and details -- pass
tested k8s components summary and details -- pass
tested cluster metrics summary and details -- pass

all look good now! (v2.5-head 31f00c1)


Upstream 20220418

Based off DataHub v0.8.33 ++
including changes necessary for the merge to work.
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

@xiphl able to list down the files that you want me to review? Things that we included only in our project (not from their master branch). Not easy to go through so many files here

@xiphl able to list down the files that you want me to review? Things that we included only in our project (not from their master branch). Not easy to go through so many files here

don't have any new functionality that is added. but maybe commit 36037e8 cos we added UNKNOWN class not long ago.

i see heap space exhausted related errors in the failed runs, but don't see any issues at upstream. hmmm.


doc: Re-introduce EBS driver

DO NOT MERGE until https://github.com/emccode/libstorage/pull/273 has been merged.
Formerly known as ec2, add the ebs driver back into the mix. Add links
to EBS and EFS drivers from libstorage. Also, fixup the README to have a
working example of setting env vars on the CLI and running rexray.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Current coverage is 44.55% (diff: 100%)

Merging #566 into master will not change coverage

@@             master       #566   diff @@
==========================================
  Files             2          2
  Lines           193        193
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             86         86
  Misses          107        107
  Partials          0          0

Powered by Codecov. Last update 8964279...e51a6e5

Hi @codenrhoden,
I'm approving this and will be closing it with #578 and the commit that replaces this one, 13421b4598949378503f1279854ca6f890713bc7. Thank you again!

FWIW @codenrhoden, the new commit uses your old commit's message and authorship, so you don't lose any attribution. That's important to me.


Add API for messaging/notification plugins

At last weekend's EthWaterloo hackathon, two of the winning entries extended MetaMask to incorporate messaging!

Connexion
Wallet Notify

There is clearly a desire for a messaging/notification API, so I'm opening this issue as an initial catch-all for thoughts on the UI/API of this kind of feature.
For mere notifications, I think we can pretty easily canonize a new kind of EIP-2255 restrictedMethod that allows plugins the permission to show notifications. I think the bigger question is:
If a plugin wants to provide messaging/an inbox, where should it go? Should the assets list simply evolve into a general "toolbox", kindof a fancier type of bookmark list, or is there a more first-class place where people would prefer messaging in the wallet to exist?
If we did have a conversations tab, and this was populated by a plugin API, it would mean you could potentially have conversations from many protocols rolled into the same queue. That thought is pretty cool.
Anyways, share your thoughts, how should it work, what should it look like, etc.

Hi! I am one of the hackers who worked on Connexion.
Wallets are the first place users would look if they were to have a new message pop up.
It would be amazing if MetaMask had a tab called inbox. It would show a list of messages and it would look very similar to the transactions view but styled accordingly. Handling messages would be determined by a standard that we should adhere to. There would be data within the message that would explain to the wallet exactly what should be displayed, whether it's an external link to an IPFS hosted website, or if it's just plain text.
Although it would be really cool to build everything within the plugin, some of the features that we would like to have would be too much for a plugin (sharing images, sending markdown). We're thinking of creating something similar to sending an email. I think the Wallet's role in communications should be to handle different protocols and broadcast them to the user based on certain settings that the user has set up. That way, third party applications can build upon this generic protocol and handle rich data if they so choose within their own application that the wallet redirects them to.
I am still thinking of what is the best course of action in terms of having a generic message.

Should each message be sent as part of a transaction?
(Maybe we can batch this up and send it through a relayer)
Should each message be an event?
Then Metamask will need to comb through and filter each event and each wallet will need to keep track of when a user has viewed the message,
Should this be an api that companies handle that give to Metamask instead? We used Dfuse at the hackathon to handle this.

I wanted to just alert people if they didn't already know about another project trying to do something similar to this. Might want to include them in conversations? https://mailchain.xyz/

Thanks @brantlymillegan - I saw Connexion and Wallet Notify liking their approaches a lot!
At Mailchain, we've created an offering for what we believe the standard for sending asynchronous messages using blockchain protocols should be. We built the Ethereum implementation initially and it works across testnets and mainnet.
Specification: https://github.com/mailchain/mailchain-specification
We welcome feedback from the community on better ways to handle/ extend message functionality... don't be shy to contribute ideas and feedback.
One extensible concept we created that may be handy is 'Programmable Envelopes' where the sender can specify how the message data is handled (i.e. message header and body stored off-chain vs on-chain, encrypted message for the recipient vs 'open letter' or anything else the community can dream up).
Storage type (and location) is intended to be flexible (any kind of object store e.g. S3, IPFS, etc.).
@jsdu

Should each message be sent as part of a transaction? (Maybe we can batch this up and send it through a relayer)

There are strong arguments to support this approach. We implemented it this way so the transaction needed GAS (acting as anti-spam) and verification of sender/recipient was a little more transparent.
We'd like to explore batching as a way of reducing costs, but understand what tradeoffs there are.

Should each message be an event?

Guaranteeing delivery is really important. While the trade off of waiting for the next block to show the tx may limit some applications (over near-instant events), supporting true decentralised asynchronous messages needs to leverage transactions in some way. Events may be useful to provide a temporary notification until the tx has been sufficiently confirmed.
@danfinlay: +1 for the conversations tab! There's a bunch of use cases listed on https://mailchain.xyz.
Without getting into the weeds of additional message features on Mailchain's roadmap, the most simple requirements that we'd see MetaMask need to consider are:

Messages may contain a payment.
Messages should be checked for validity (sender, file integrity etc) to prevent spam.
The Ethereum account private key is needed for decryption if the account public key is used (related to metamask-extension/issues/1190).
A user should be able to reply to a message (and that message be decrypted, then sent in a tx).

Happy to work together and help explore this further... let me know all your thoughts.

@tboeckmann For my question of whether to use events, I was talking about Solidity events. I was thinking how would encrypted data be shared to another user, whether it is with a function call to store the message in state, to use Solidity events, or to simply attach it to the data field of a transaction.
I think layer 1 messaging would be detrimental in terms of user experience as each tx requires gas. This would be more geared towards notifying users. And to be fair, I don't think gas for a transaction would work as a spam filter, I think it would hinder regular users more. There could be services that would send transactions on behalf of users (gas station network, etc) as well.
Also happy to help and talk more about this, hope we can collaborate! I think decentralized messaging on blockchain would be really powerful.

For the purpose of keeping this MetaMask support productive, I'd recommend keeping it agnostic to the exact messaging protocol: Snaps have access to the blockchain, and can request access to the network, so there are a lot of approaches possible, and we'd love to implement an agnostic and extensible approach to these.
For MetaMask to best support these various approaches, the biggest questions for us are things like "Where do these messages best integrate into our interface?" and "What permissions does a messaging system require to work well?".
Sounds like the conversations tab is appealing, we will review this thread and keep talking with you as we start designing for this use case.

Where do these messages best integrate into our interface?

I see two main approaches. Depending on whether this should be part of native MetaMask or remain a plugin.
Natively: A conversations/messages tab would be the best way. Could extend the side menu to include more options than the assets manager.
Plugin: There was talk at ETHWaterloo of allowing plugins to render their own HTML+CSS within Metamask. That could be utilised if this were to be added as a plugin.

What permissions does a messaging system require to work well?
Is this in the context of plugin permissions? If so, then

view list of eth addresses in metamask
alert/notify
I think permissions aren't as complex as some API requirements are. At the hackathon, some things were not working as expected which would've proven to be useful.
an event or callback when wallet is logged into or account is switched
a way to prompt metamask or automatically decrypt data using the account's private key
(if the message listener will be part of metamask) - a way to read those messages

@danfinlay Its exciting to see your plans to build a permissionless extension. This would allow Mailchain and other messaging applications to using Metamask as a key building block.
I read your Introducing Web3 Plugins article and have looked through snaps API wiki.
My thoughts below are based on a first look at that and knowledge of building messaging applications. The trust that Metamask has built with users around key management offers messaging platforms a secure but trustworthy way to work with private keys.

Reading messages - access to events and related data is required. Mailchain uses transactions and the data field, this would require listening to transactions. .onMetaMaskEvent(eventName, callback) appears to cover this.
Sending messages - transmitting messages and propagating them through the network. Mailchain sends transactions with the data field populated. Exposing internal events such as getGasPrice,  look helpful. I could not easily see the best way to find the next nonce isNonceTaken? or to  sign and send a transaction.
Mailchain encrypts all data (users can send plaintext messages, although that is not expected to be the primary usecase). Encryption requires access to the public key which is relatively freely available. Decryption requires access to the private key applied to the relevant algorithm. Subcrypto supports AES-CBC (is this 256 bit?) among others. Access to a decrypt method would then allow the contents to be viewable by the calling function.

Since each messaging protocol will likely have a different messaging standard especially early on, exposing a set of functions that would support messaging primitives would allow products to innovate ontop of Metamask and Snaps. We have outlined the Send, Receive, Read primitives plus the specification this can be useful to understand our approach. I believe exposing these primitives allows the community to build now and in the future.
To implement in the interface itself is more subjective, I think a lot depends on how much messaging UX you want in the extension. It gets a bit more complex as email vs instant messaging has a different UX. An initial approach could be to identify messages as belong to a messaging platform via a function (for mailchain its a prefix in the data field) then this could either display the message or deep link to the messaging platform.
Open to thoughts and feedback on this from the community.
Big :+1: on the work Connexion and  Wallet Notify have done at eth waterloo.

Thanks for all the ideas, these are great, please do keep them coming!
A note to messaging protocols that are hoping to use on-chain data to send messages to MetaMask users, and receive them using a snap:
Today, MetaMask achieves pretty good performance (network, cpu, and energy) by "sleeping" when not active. This is because we are very much not a full client, or even a light client at the moment, and so we don't keep up with blocks when the user is not actively engaged on the blockchain, instead allowing the user to connect to a full node of their preference, either local or remote.
If your protocol requires parsing every incoming transaction on the block that it is included, either:

MetaMask needs to track each block for the user, and so energy/cpu/network consumption goes up considerably, because it would then be constant (which it is not otherwise).
The MetaMask user needs to subscribe to an external service/network to be pushed notice of these messages in the blockchain, which it can then verify with its blockchain connection.

I'm highlighting this because it's the kind of stuff we think about a lot as wallet developers, and if you're building a snap, this may be your first taste of wallet development, so I want you to know that not all users want to run a full client and keep it synced, so you will want your snaps to perform well under a variety of user preferences.


Script removal error

#319
When removing script tags after a jsonp request, check that the current browser supports ChildNode.remove()
https://developer.mozilla.org/en-US/docs/Web/API/ChildNode/remove
@jeanmw @scott-branchio

@jsaleigh @jeanmw completed testing IE11 on Win7 env - verified the error using cdn.branch.io/example.html page; tested against updated build.js in QA environment example.html page and did not see the error; also tested QA example.html page using Chrome, Firefox and Safari on Mac and saw no errors. 👍

Awesome, thanks @scott-branchio !


Adding fixed CVEs for policy-controller

Adding Fixed Advisory GHSA-9763-4f94-gfch for policy-controller

added here https://github.com/wolfi-dev/advisories/pull/914


[hardware security] outdated Network API block CI

If the issue is to do with Azure CLI 2.0 in-particular, create an issue here at Azure/azure-cli

Extension name (the extension in question)
hardware security
Description of issue (in as much detail as possible)

Since this PR is outdated, https://github.com/Azure/azure-cli-extensions/pull/1626 and Fan has bumped Network SDK version, and the merge time is later than it. So, currently, it will block our CI now for hardware security extension is using outdated Network API.

@bquantump can you take a look at this issue?

@haroldrandom can you give some more information on this? I assume this is in regards to the test scenario VNET creation. I though I had fixed this in the PR:

Recently, azure-mgmt-network has bumped to a newer version.
Locally, you are using the older one, but CI will follow the latest one, That's why it failed on here network API.

I updated the test scenario based on your comment above, and seemed to have fixed the CI issue. Has the network SDK bumped again?

@bquantump
Did you record the test YAML file against the latest azure-mgmt-network?
If that so, could you fire a PR to fix it?

Is azure-mgmt-network 10.1.0 the correct version ? That’s the one I ran the test on that allowed the CI to pass in the PR.

Is azure-mgmt-network 10.1.0 the correct version ? That’s the one I ran the test on that allowed the CI to pass in the PR.

It's azure-mgmt-network. The virtual network API is 2020-04-01

Uh ic ok, so the yaml is out of date with the network API. I’ll rerun with 10.2.0 then. It will take a bit since HSMs need a lot of pre-setup  to provision. Then the HSM provision itself  is about 20 mins.


File Uploader

Create a file upload feature for the application.  Here, the user will be able to upload a zip file containing the multiple sub-files required for a shapefile. The application will upload the file into the database, and use it to load the spatial data with the gdal API. The file uploaded should replace the hard-coded file.

I will create a simple html page, and you can add the file uploader in there? It can be a simple bootstrap button that uploads the selected file to the DB as a Datafile model #12 . I'll create the model too.

It seems like uploading the file to the DB as a Datafile #12 might not be a good idea after all. It is redundant and the BLOB datatype does not seem very robust. We can do all the file checking on a file upload controller instead.

The file uploader gets the following error on a windows machine:
Error:  { [Error: ENOENT: no such file or directory, rename 'C:\Users\mitadm\Dropbox (MIT)\Thesis\07. Webapp\PaintingWithData_Riyadh\app\controllers\shape_files\riyadh' -> 'C:\Users\mitadm\Dropbox (MIT)\Thesis\07. Webapp\PaintingWithData_Riyadh\app\controllers\shape_files\riyadh_1475172716']   errno: -4058,   code: 'ENOENT',   syscall: 'rename',   path: 'C:\\Users\\mitadm\\Dropbox (MIT)\\Thesis\\07. Webapp\\PaintingWithData_Riyadh\\app\\controllers\\shape_files\\riyadh',   dest: 'C:\\Users\\mitadm\\Dropbox (MIT)\\Thesis\\07. Webapp\\PaintingWithData_Riyadh\\app\\controllers\\shape_files\\riyadh_1475172716' }
It is not creating the directory riyadh_1475172716. Instead it dumps all the files on the shape_files directory.


Configurable posts limit, instead of hardcoded limit 10 posts

feed.xml:
{% for post in posts limit: 10 %}
   ...

It would be nice if this were configurable.
Another option that would work is to generate a feed for the last 10 and eg 100 and 1000.  This would provide some of the value of a URL parameter while still being doable in a static site.

See also: #192 #56 #40

@pathawks Re the smart union of last n posts and last m hours mentioned in #193:
For last m hours you could take same approach of generating multiple options.
/feed.1h.xml, /feed.2d.xml, /feed.7d.xml
If you combined the two heuristics, and the number of generated feeds blows up to a few dozen, I assume it would still be reasonably cheap.

Do any feed readers support paginated Atom feeds?
http://www.ibm.com/developerworks/library/x-tipatom2/index.html

I assume so, but I am the wrong person to answer that.  For my client, and maybe for others, what matters how easy it is to consume programmatically in a mobile app, so you could look at the top Android libs.
But note that pagination is not being requested here, adds complexity and is usually not used much.

But note that pagination is not being requested here, adds complexity and is usually not used much.

I understand, but I think the case against a configurable feed limit has been stated already, so I am trying to think of a way to provide more posts without adding another config option.

@pathawks Follow-up: we worked around this by dropping jekyll-feed and implementing our own layout.


Link to app qos in README is not working

The link at this commit
https://github.com/intel/kubernetes-power-manager/blame/84b6c0c80c16f44f7c4b90d0a52b4c355cab1147/README.md#L81
points to App QOS, but the deep link within the repo goes to 404. (I think it's a simple fix because the code is there.)

V2 release does not include App QoS


Incorrect position of widgets

Hello!
In some cases gridster places widgets in incorrect cells.
Simple example: http://jsfiddle.net/Skryabind/rPVPe/
You can see that element with data-row="2" and data-col="2" actually places on (1,1). Element with data-row="3" and data-col="2" places on (2,2).
This problem happens in other cases, but I did not find what they have in common.

Hello @dustmoo ,
I have 12*10 widget. I want to set one box fix at first row and first column, that can not be drag or change the position, so how can we do that ? Please suggest your answer.

Currently this only (kind of) works on the dustmoo branch by using the “static” class. Did you try that?
On Mon, Mar 16, 2015 at 6:05 AM, harshmsp<EMAIL_ADDRESS>wrote:

Hello @dustmoo ,
I have 12*10 widget. I want to set one box fix at first row and first column, that can not be drag or change the position, so how can we do that ? Please suggest your answer.
Reply to this email directly or view it on GitHub:
https://github.com/ducksboard/gridster.js/issues/147#issuecomment-81647550

Yes @dustmoo , But with that if other object can move to that position then it works and  I want to fix that layout of define row and column that not draggable and also other objects can not be take that position.
Please give your suggestion.

Hello all. Just to share the information. I faced the same issue and found the reason based on gridster initialization:
$(".gridster ul").gridster({
widget_margins: [tileMargin, tileMargin],
widget_base_dimensions: [tileSize, tileSize],
Problem was that my variables tileMargin and tileSize were strings. After changing to floats, the grid was looking just fine:
$(".gridster ul").gridster({
widget_margins: [parseFloat(tileMargin), parseFloat(tileMargin)],
widget_base_dimensions: [parseFloat(tileSize), parseFloat(tileSize)],

Is anyone interested in a simpler/less resource intensive solution? Sort operation could be costly if there's a number of widgets on the board (though won't ever be too bad I assume)
The problem is caused by cell occupation information being over-written in gridster.gridmap when fn.add_faux_cell is called. I fixed it by making following change:
fn.add_faux_cell = function(row, col) {
        var coords = $({
                        left: this.baseX + ((col - 1) * this.min_widget_width),
                        top: this.baseY + (row -1) * this.min_widget_height,
                        width: this.min_widget_width,
                        height: this.min_widget_height,
                        col: col,
                        row: row,
                        original_col: col,
                        original_row: row
                    }).coords();

        if (!$.isArray(this.gridmap[col])) {
            this.gridmap[col] = [];
        }

-       this.gridmap[col][row] = false;
+       this.gridmap[col][row] = this.gridmap[col][row] || false;
        this.faux_grid.push(coords);

        return this;
    };

i am getting this error after updating the gridster.js file in my project
this.gridmap is occuring undefined which is causing problems while adding the widget

Kindly comment below if anyone faced the same issue


request:compatibility for java17

Is it possible to update the target Java version of the project to Java 17 in the next Maven release, considering that Java 17 can run SIMD API without any issues?

I don't think it's possible because the library relies on certain functionalities that are not available in Java 17, such as Math.unsignedMultiplyHigh.

Math.unsignedMultiplyHigh.

It can be solved using "JEP238".
We can copy source of unsignedMultiplyHigh method Into NumberParser:

Yes, but this function is annotated with @IntrinsicCandidate, which means that if we copy it, we will lose support from the JVM in terms of optimization.

Yes, but this function is annotated with @IntrinsicCandidate, which means that if we copy it, we will lose support from the JVM in terms of optimization.

What I mean is, in order to comply with the “Multi Release” feature, we should create a separate duplicate file for the NumberParser class (as well as the source code for unsignedMultiplyHigh) for Java 17. It will not conflict with Java 20.

OK, I get it. Have you tried applying the changes you mentioned and testing the library's performance on Java 17? I'm asking because it would be good to know if there is any advantage over other JSON parsers in terms of performance and, thereby, if there is a reason to add support for Java 17. The library highly relies on the advancements in the Vector API, so the newer the Java version, the better the performance we should expect.

OK, I get it. Have you tried applying the changes you mentioned and testing the library's performance on Java 17? I'm asking because it would be good to know if there is any advantage over other JSON parsers in terms of performance and, thereby, if there is a reason to add support for Java 17. The library highly relies on the advancements in the Vector API, so the newer the Java version, the better the performance we should expect.

Not yet. I'm a gradle noob, so I'm currently using maven, and I don't know how to run the code in the src/jhm/java directory through maven.


Swap out create archive in fmriprep for fw-heudiconv export

https://github.com/PennBBL/fmriprep/blob/af1c0da6668f71f02b1eceaf7ec1864aee0cbb02/run#L238
https://github.com/PennBBL/fmriprep/blob/af1c0da6668f71f02b1eceaf7ec1864aee0cbb02/Dockerfile#L46-L50

also test on https://github.com/poldracklab/fmriprep/blob/e2f2825ac93af749779cfe2ab47465cbba7b9fa1/.circleci/config.yml#L96

https://github.com/PennBBL/fmriprep_fw


Add piko twitter

Adding piko twitter will be nice.
Link: https://github.com/crimera/piko-builds

This is not the place to make app suggestions. In the app, you can send an app suggestion. However, I will look into it 👍

Moved to new repo
Link: https://github.com/crimera/twitter-apk


Add timer when snapshot creation fails due to timeshift running

This enables the user to close Timeshift and try again in a 30-second time window.
I hope you can understand my code, I sometimes write very non-self-explanatory code xD I'll add some comments to explain how it works. I tested it with the apt install, apt remove and apt purge commands - it works as expected.

This was a problem for me too, especially that all updates are done in the background. It happened to me that updates failed because I left Timeshift open the whole time.
Since being in the background mean that I cannot interact with it, I just edited the exit code. exit 0 instead of exit 1 😄
{ echo "Unable to run timeshift-autosnap-apt! Please close Timeshift and try again. Script will now exit..." >&2; exit 0; }

I'm not sure of what would be a more elegant solution... (Kill Timeshift?)


Add github action for manifests

Create a Github action that generates manifests using helm template meilisearch charts/meilisearch and compares the output with the manifest stored at manifests/meilisearch.yaml to be sure that the manifests are up to date with the Helm chart changes.
It would be interesting to explore if there is a better way of automatically generating manifests in the CI.

@HelmutLety
This issue address the idea you proposed in #39
The only "problem" I have found with this approach, is that a lot of tags are added to the manifests that are completely unnecessary and polute them. This doesn't create any issue other than affecting readability, and this is a good approach for maintainability!

Fixed by #61 but reverted by #64
Waiting for fix... so I reopen


Hours not set at all when using DTP as TimePicker

using DTP with format: 'HH.mm' doesn't update the hours at all
Removing passing date and oldDate to notifyEvent solves the Problem
(problem seems to be that fillTime is called twice, first with new date and afterwards with old date so HOURS will be changed from new to old immediately)

This PR doesn't pass CI checks. Please make sure you run the build script and deal with any errors.
Per the contrib doc, please make your PRs to the development branch. PRs to the master will be closed.


Add strategy guide

Add some rough strategies about how one could potentially play. I need help.

To start you will need a argentx or braavos wallet. I personally use braavos. Right now loot survivor is on testnet so you would like to check out https://faucet.goerli.starknet.io/ to get testnet ETH, 0.001 ETH will be ideal for later.  After you connected loot survivor to your wallet, I strongly recommend you to create an Arcade Account. It is in the middle at the top on desktop, and upper right corner on mobile with an arcade icon. The reason why I suggest it is because loot survivor is a fully on chain game. So every move you make is a transaction to the smart contract. Using arcade account will make everything smoother for the permissions of the account are tied to the contract. Game Basics:Now, you can choose your own weapon. They are the same due to the fact that the first beast you will encounter is depended on which type of weapon you choose. There are three weapon classes in the lootverse, blade, bludgeon and magic. Type in your adventurer’s name and you are good to go.A beast lurks in the shadow, prepare for battle!You can check your adventurer profile on the left hand side, and profile tab on mobile. You can see your status at the top, statistics in the middle and loots in the bottom. Status bar tells your golds, health points, levels and experinece progress bar.Statistics are broken down to 7 types, check out the table below.Stat Types

3D PHYSICAL
STRENGTH
BOOSTS ATTACK DAMAGE BY 10%

VITALITY
INCREASES MAX HEALTH AND CURRENT BY +10HP

DEXTERITY
IMPROVES CHANCES OF SUCCESSFULLY FLEEING

3D MENTAL
INTELLIGENCE
AIDS IN AVOIDING OBSTACLES

WISDOM
HELPS EVADE BEAST AMBUSHES

CHARISMA
GIVES GOLD DISCOUNT ON ITEMS AND HEALTH POTIONS

1D METAPHYSICAL
LUCK
RAISES CHANCES OF CRITICAL DAMAGE 1% PER POINT AND CANNOT BE UPGRADED DIRECTLY

The contract is so delicately designed like this Magic/Cloth,Blade/Hide, and Bludgeon/Metal. I found it easier to remember all the efficacy this way.

Necklace Abilities

ITEM
ABILITY

(T1) NECKLACE
BONUS STAT AT G20 (+2 INSTEAD OF NORMAL +1)3% increase per greatness metal armor defense

(T1) AMULET
2X HEALTH FROM HEALTH DISCOVERIES3% increase per greatness cloth armor defense

(T1) PENDANT
2X GOLD FROM GOLD DISCOVERIES3% increase per greatness hide armor defense

Ring Abilities

ITEM
ABILITY

BRONZE RING (T3)
NO SPECIAL ABILITY

SILVER RING (T2)
+20 LUCK (+1 bonus luck per greatness when equipped TOTAL OF +40 LUCK AT G20)

GOLD RING (T1)
2X GOLD WHEN DEFEATING BEASTS，3% per greatness increase in gold rewards from beasts

PLATINUM RING (T1)
2X CRITICAL HIT DAMAGE, 3% per greatness increase in name match damage bonus

TITANIUM RING (T1)
2X SPECIAL NAME DAMAGE (WHEN WEAPON NAME PREFIX MATCHES BEAST), 3% per greatness increase in critical hit damage bonus

To me personally, DEXTERITY aka DEX, VITALITY aka VIT and CHARISMA aka CHA are minor stats compared to other stats. Loot survivor is a roguelike game, a game genre you would like to take down as many beasts as you can so that you snowball all the in-game resources then get a liner growth curve.
Fleeing will not be an option for me until either the beast is double the level of my character. With this being said, DEX is a trivial thing both in early and late game, basically after the second combat I don’t flee anymore.
Vitality comes as a tradeoff to Intelligence and Wisdom. If you can dodge the obstacles and ambushes, then 100 or 200 hp does not matter at all. But note that 200 hp is important in the mid-game, it is hard to keep the build and the dynamic meta to be honest.
You are going to need around 5 points in Charisma to buy items such as tier1 weapon, first ring and necklace, and swap out Tier5 armors later.  After I collect all seven items, the gold I accumulated either goes to higher tier items or pay for the potions.
VIT vs CHA decision making largely depends on your experience or should I say DEATH?


Update Maintenance API wrapper to 1.28

Package / App
Maintenance API typescript wrapper
Description
DFW needs a QA-built wrapper for development purposes when maintenance API adds functionality for deleting images.
Alternatives
No response
Other info
No response

Blocked until mAPI adds the related endpoint


Consider requiring a higher version of Mono

Due to many recent changes in APIs that require stuff not in Mono 3.4, I would increase teh minimum Mono version to 4.1 i.e. the current master. Any prior version is incapable of running a decent ASP.NET 5 app from the current dev branches.

+1 - pretty much every example mentions MVC, which fails with mono 3.x

+1 Here as well. It would be nice to have an updated docker image too. When I tried to use the docker image (microsoft/aspnet) which is currently based off of mono 3.12 and it would not work with the MVC samples or the MVC template projects from Visual Studio (they were both using beta-3). I upgraded everything to the latest (beta-4), used the last nightly build from the aspnet/docker repo, and used a custom docker image that i installed Mono v4.1.0 into and everything seems to work fine. I am assuming this is all because the beta builds are being changed a lot right now.

Now that Mono 4.0 has been released it will be a lot easier for people to get a compatible version

W00p!

Dosen't look to be officially released yet, those release notes are just the draft at the moment. It's a good sign that the release is close though, can't wait!


Fix #4039: Use different L.Bounds for "marking as prunable" and loading tiles

Another alternative for #4039. This one hooks up with the code that calculates the tileRange for loading tiles, and calculates another bigger L.Bounds. Tiles within those bounds will never be flagged for pruning.

Looks good!

Did 3 tests for various scenarios, however because it is working well we are not triggering any grid.on('load') events so it doesn't trigger the last bit.
https://github.com/Leaflet/Leaflet/pull/4650/commits/79d203bee2132bec849b315e4c2997bbbacbc235#diff-19a7d53df5d545ee8cde69a53256057cR801

Fixed the test using spy(). Also run the test on master and it fails "Loads map, moves forth and back by 512 px, default keepBuffer" with "expected 12 to equal 0" to confirm it works.

Tests look good to me :-)

When will this be published on NPM?

With 1.0.0-rc2, but not date planned atm.

It will be done when it's done. https://github.com/Leaflet/Leaflet/milestones/1.0-rc2

Ok this is now in the npm version. Thanks! The experience has improved.
However, an initial pan still leaves a lot of white space to each side. Is there currently a property that can be tweaked to pre-load 1 row on each side and diagonal?


[Package Issue]: Oracle.JavaRuntimeEnvironment - No applicable update found when one does exist

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
No applicable update found.
Brief description of your issue
Winget shows a new version of JRE when using list command, but when attempting to upgrade to it, returns with 'No applicable update found.'
Steps to reproduce

Open Windows Terminal as administrator
winget list Oracle.JavaRuntimeEnvironment
winget upgrade Oracle.JavaRuntimeEnvironment

Actual behavior
winget upgrade Oracle.JavaRuntimeEnvironment returns with "No applicable update found."
Expected behavior
winget upgrade Oracle.JavaRuntimeEnvironment would upgrade JRE to the latest version
Environment
Windows Package Manager v1.1.13405
Windows: Windows.Desktop v10.0.22000.527
Package: Microsoft.DesktopAppInstaller v1.16.13405.0
Current Install: Java 8 Oracle.JavaRuntimeEnvironment 8.0.3110.11
Available: Java 8 Oracle.JavaRuntimeEnvironment 8.0.3210.7

Screenshots and Logs
winget list Oracle.JavaRuntimeEnvironment.log
winget upgrade Oracle.JavaRuntimeEnvironment.log

Hey and thank you for using the issue template as intended! :)
The issue is resolved in the Windows Package Manager 1.3.432-preview client, the issue is caused by the Installer unpacking another Installer (in this case a MSI) which makes WinGet think you got the MSI version installed instead of a regular EXE (f.ex Nullsoft/Inno)
The current Manifest is specced out for this feature so we're just waiting for winget-cli to catch up :)
https://github.com/microsoft/winget-pkgs/blob/777c8230620f6bb5e40412cd348daeac426127ca/manifests/o/Oracle/JavaRuntimeEnvironment/8.0.3210.7/Oracle.JavaRuntimeEnvironment.installer.yaml#L29-L47

Awesome, thanks for the quick reply. I had looked through the preview patch notes but must have missed that. Thanks for letting me know!


Fixed 'getAsync' to work on Android

It was crashing with a "getHeight" not defined error. Turns out you can access the status bar height in Android by using the currentHeight property, so I made that change in the getAsync() method. Not sure how this impacts the event listeners.

also encountered this issue


Magick: abort due to signal 11 (SIGSEGV)

After I updated from outdated upconv branch to master, I got this error message:
Magick: abort due to signal 11 (SIGSEGV) "Segmentation Fault"...

and nothing.
I git bisected, and found out that 3b72864 is the first commit that the problem happens. I have no idea what's going on; I've updated Torch7 and rocks, but it still happens. Maybe the updated model is the problem? But why Magick? I don't know...
I'm using up-to-date Arch Linux 64bit. No -force_cudnn used.

waifu2x is using GraphicsMagick. Maybe it is related.
Did you update  graphicsmagick package?
luarocks install graphicsmagick

But I am not sure why is https://github.com/nagadomi/waifu2x/commit/3b728643ec382242815dc3f60cc1f3e772aee688.
Did you update nn&cunn with luarocks command?
luarocks install nn
luarocks install cunn

If this issue cannot be solved, could you check the backtrace?
$ gdb luajit
> run waifu2x.lua
> bt

I have updated nn and graphicsmagick(and that Magick error occurs), but updating cunn failed with lots of compile errors. I'll find out what's wrong and update cunn as soon as possible. I don't have much time nowadays :(

It seems that Arch Linux is not compatible with recent CUDA luarocks. I'll close this issue for now.

Finally succeeded to update cunn(it was kinda easy), and it works well.


Keycloak admin console isn't reachable

After deploying EnMasse with the Keycloak instance, the web console seems to be not reachable using the browser.
Getting the ip address of the standard-authservice service and trying with following :
http://<ip-address>:8080/auth/admin/
I get this error :
This site can’t be reached
<IP_ADDRESS> refused to connect.

Strange, this works for me with the latest snapshot: https://dl.bintray.com/enmasse/snapshots/latest/enmasse-latest.tgz
Also works when I deploy directly from the master repo.
Deployed as such: ./templates/install/deploy-openshift.sh -d -k admin
It does take a while, but keycloak becomes reachable after 1-2 minutes. Then I am able to create users and assign credentials in the console and verify:
PN_TRACE_FRM=1  python /usr/share/proton-0.18.0/examples/python/simple_recv.py -a amqp://lulf:lulf@<IP_ADDRESS>:5672

One thing I do notice is that the HTTP liveness probe on the console fails as it is unable authenticate, so that will cause the console to get restarted sometimes, but no errors in the log as far as I can see.

I have just deleted all my previous images (to be sure) and updated the master branch on my local PC.
The I have used the getting started guide command (as always) :
./deploy-openshift.sh -m "https://localhost:8443" -n enmasse
but adding a -k admin for Keyclock (using "admin" as password for admin :-))
I still see an error in the Keyclock log about Could not start http listener and the admin console isn't reachable.
At the end of the log I also see :
05:21:34,145 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0060: Http management interface listening on http://<IP_ADDRESS>:9990/management
| 05:21:34,145 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0051: Admin console listening on http://<IP_ADDRESS>:9990
but maybe it's the admin console of some other component in Keycloack ?
In the OpenShift events I also see this :
Liveness probe failed: dial tcp <IP_ADDRESS>:5671: getsockopt: connection refused
related to a not started keycloack instance and the reason why the console can't connect to it and crashes.

I have also tried with the enmasse-latest.tgz ... same problem.
I have checked that no one is already listening on port 8080 on my PC ... no one is there.

The 9990 port is for the WildFly app server. Could you try the following:
openssl req -new -x509 -batch -nodes -days 11000 -out tls.crt -keyout tls.key
mkdir -p certs && mv tls.crt tls.key certs
docker run -ti -v $PWD/certs:/opt/jboss/keycloak/standalone/certs:z -e KEYCLOAK_USER=admin -e KEYCLOAK_PASSWORD=admin enmasseproject/keycloak:latest

The problem seems to be related to this error :
"protocol family unavailable"
which is related to the usage of the IPv6 stack. On my side even disabling IPv6 doesn't fix the problem.
The way to do that is set the preferred stack to use (IPv4) on Keycloak startup with this Java options :
java.net.preferIPv4Stack=true
So this issue is fixed by aa8cc3a603e379c2612328e2b4093b75a32f3723

After deploying EnMasse with the Keycloak instance, the web console seems to be not reachable using the browser.
Getting the ip address of the standard-authservice service and trying with following :
http://<ip-address>:8080/auth/admin/
I get this error :
This site can’t be reached
<IP_ADDRESS> refused to connect.

this is because Jboss is listening only on <IP_ADDRESS>
Solution is here:
https://serverfault.com/questions/830053/cant-access-jboss-remotely-despite-of-proper-binding-of-ip-address-in-standalon

After deploying EnMasse with the Keycloak instance, the web console seems to be not reachable using the browser.
Getting the ip address of the standard-authservice service and trying with following :
http://<ip-address>:8080/auth/admin/
I get this error :
This site can’t be reached
<IP_ADDRESS> refused to connect.

this is because Jboss is listening only on <IP_ADDRESS>
Solution is here:
https://serverfault.com/questions/830053/cant-access-jboss-remotely-despite-of-proper-binding-of-ip-address-in-standalon


test: comprehensive testing of narrowing binary operations

#9604 highlighted that more testing of narrowing binary operations is required.

Reopening for minux to add more tests.

I wrote a trivial extension of your code. it works, but 6g takes a huge
amount
of memory to compile the resulting program.
6.92user 0.47system 0:07.38elapsed 100%CPU (0avgtext+0avgdata
1916388maxresident)k
0inputs+89560outputs (0major+483391minor)pagefaults 0swaps
I'm using the multiple init() trick, but it seems that is not enough.
Some interesting statistics:

all in the same function:
7.28user 0.55system 0:07.83elapsed, 1965620K MSS
each typecast in a different init():
7.30user 0.59system 0:07.89elapsed, 1900004K MSS
each test type (unary, binary, shift) for each type cast in different
init():
6.92user 0.47system 0:07.38elapsed, 1916388K MSS

Because gc always keeps every toplevel function in memory, so splitting the
functions
will not help reducing memory requirements much.
We still need to split the test into smaller pieces, like the rotate tests.

Too late for Go 1.5.


Fix #14: Added fill method to the handler

Adds a method to the handler class to fill a memory object with a certain value

Looks good to me :+1:


Network(?) issue when connecting through docker

I am using the Dockerfile to run a docker container for the satellite (as I do with homeassistant, piper and whisper).
However, while all services nicely connect and integrate into Wyoming in my Homeassistant, the satellite fails to so, despite being configured in the same way the other containers are.
The satellite does not connect automatically to HA, and adding it manually via the Wyoming protocol integration leads to "No services found at endpoint". Notably, when I provide a different Host address or Port, it searches for a long while, so it seems that the network connection is fine to some degree.
Below the debug output of my docker container.
[I] moritz@moxps ~/wyoming-satellite (master)> docker logs  wyoming-satellite
DEBUG:root:Namespace(mic_uri=None, mic_command='arecord -D plughw:1,0 -r 16000 -c 1 -f S16_LE -t raw', mic_command_rate=16000, mic_command_width=2, mic_command_channels=1, mic_command_samples_per_chunk=1024, mic_volume_multiplier=1.0, mic_noise_suppression=0, mic_auto_gain=0, mic_seconds_to_mute_after_awake_wav=0.5, mic_no_mute_during_awake_wav=False, mic_channel_index=None, snd_uri=None, snd_command='aplay -D plughw:0,0 -r 22050 -c 1 -f S16_LE -t raw', snd_command_rate=22050, snd_command_width=2, snd_command_channels=1, snd_volume_multiplier=1.0, wake_uri=None, wake_word_name=[], wake_command=None, wake_command_rate=16000, wake_command_width=2, wake_command_channels=1, wake_refractory_seconds=5.0, vad=False, vad_threshold=0.5, vad_trigger_level=1, vad_buffer_seconds=2, vad_wake_word_timeout=5.0, event_uri=None, startup_command=None, detect_command=None, detection_command=None, transcript_command=None, stt_start_command=None, stt_stop_command=None, synthesize_command=None, tts_start_command=None, tts_stop_command=None, tts_played_command=None, streaming_start_command=None, streaming_stop_command=None, error_command=None, connected_command=None, disconnected_command=None, awake_wav=None, done_wav=None, uri='tcp://<IP_ADDRESS>:10700', name='living_room', area=None, no_zeroconf=False, zeroconf_name=None, zeroconf_host=None, debug_recording_dir=None, debug=True, log_format='%(levelname)s:%(name)s:%(message)s')
INFO:root:Ready
DEBUG:root:Detected IP: <IP_ADDRESS>
DEBUG:root:Zeroconf discovery enabled (name=0242ac140003, host=None)
DEBUG:root:Connecting to mic service: ['arecord', '-D', 'plughw:1,0', '-r', '16000', '-c', '1', '-f', 'S16_LE', '-t', 'raw']
DEBUG:root:Connecting to snd service: ['aplay', '-D', 'plughw:0,0', '-r', '22050', '-c', '1', '-f', 'S16_LE', '-t', 'raw']
INFO:root:Connected to services
DEBUG:root:Connected to mic service
Recording raw data 'stdin' : Signed 16 bit Little Endian, Rate 16000 Hz, Mono

Here the process spawned by the docker:
root        6623  0.1  0.0<PHONE_NUMBER>6 ?        Sl   18:25   0:01 /app/.venv/bin/python3 -m wyoming_satellite --uri tcp://<IP_ADDRESS>:10700 --name living_room --mic-command arecord -D plughw:1,0 -r 16000 -c 1 -f S16_LE -t raw --snd-command aplay -D plughw:0,0 -r 22050 -c 1 -f S16_LE -t raw --debug
Any help is greatly appreciated!

I tested some further and I don't suspect it's a network issue anymore, but it is really challenging to pinpoint what else it should be. Is there a convenient command-line way to check the functionality of the satellite service?

@famgala thanks for your response.
Note that I am on the same machine but everythin runs within docker containers:
[I] moritz@moxps ~> docker ps | grep -E 'wyoming|homeass'                                                                                3864ace4db12   rhasspy/wyoming-openwakeword                   "bash /run.sh --prel…"   2 weeks ago    Up 2 weeks             10400/tcp                                                                  openwakeword                                                                                0708f48deefc   rhasspy/wyoming-piper                          "bash /run.sh --voic…"   2 weeks ago    Up 2 weeks             <IP_ADDRESS>:10200->10200/tcp                                                   wyoming-piper                                                                                44edb7b44b51   satellite                                      "/app/run --name liv…"   2 weeks ago    Up 2 weeks             <IP_ADDRESS>:10700->10700/tcp                                                   wyoming-satellite                                                                                573b715eddea   ghcr.io/home-assistant/home-assistant:stable   "/init"                  2 weeks ago    Up 2 weeks             <IP_ADDRESS>:8123->8123/tcp                                                     homeassistant                                                                                b91cbf587e35   rhasspy/wyoming-whisper                        "bash /run.sh --mode…"   2 weeks ago    Up 2 weeks             <IP_ADDRESS>:10300->10300/tcp                                                   wyoming-whisper

On the host, 10700 seems to listen (and I get the same result within the container)
[I] moritz@moxps ~> netstat -an | grep 10700                                                                                tcp        0      0 <IP_ADDRESS>:10700           <IP_ADDRESS>:*               LISTEN

root@wyoming-satellite:/app# netstat -an | grep 10700
tcp        0      0 <IP_ADDRESS>:10700           <IP_ADDRESS>:*               LISTEN

What's strange is that the other containers (e.g. piper) connected well with wyoming in my HA.
Also, there seems to be another guy with the same problem


Gradle ignores MaxRAMPercentage as an option for tests

Current Behavior
When configuring the memory usage of the gradle test VM via jvmArgs, specifically with -XX:MaxRAMPercentage, instead of using maxHeapSize = 1234m, Gradle will always explicitly enforce a maximum heap size of 512M via https://github.com/gradle/gradle/blob/master/subprojects/core/src/main/java/org/gradle/process/internal/worker/DefaultWorkerProcessBuilder.java#L251
The JVM then ignores the XX:MaxRAMPercentage parameter, because there is also an -Xmx parameter, which has precedence.
This is visible if -XX:PrintFlagsFinal is used, as the line specifying the MaxHeapSize looks like this:
size_t MaxHeapSize                              = 536870912                                 {product} {command line}
Expected Behavior
Gradle should not enforce a fixed maximum heap size, or provide a parameter to allow the disabling of the automatically set value. In a JVM where only -XX:MaxRAMPercentage is used, and no -Xmx option is set, the MaxHeapSize line should look like this:
size_t MaxHeapSize                              = 262144000                                 {product} {ergonomic}
The important part hear is that it's marked "ergonomic", which means that it was calculated by the JVM based on some parameters (in this case -XXMaxRAMPercentage), rather than being set to a fixed value.
Context (optional)
We run in a containerized CI setup with limited, but variable memory. We would like to be able to tell our CI jobs to use only a certain percentage of the container's RAM, rather than a fixed value. The -XX:MaxRAMPercentage option is generally the preferred way to manage JVM memory inside a containerized setup.
cc @joke
Self-contained Reproducer Project
https://github.com/sonOfRa/gradle-jvm-fork-memory/tree/groovy-dsl
This line https://github.com/sonOfRa/gradle-jvm-fork-memory/actions/runs/11745968219/job/32724613177#step:5:24 shows the supposed "all JVM args" which seems to be a misnomer, since gradle actually appends at least one more jvmarg (-Xmx) if maxHeapSize is not set.
This line https://github.com/sonOfRa/gradle-jvm-fork-memory/actions/runs/11745968219/job/32724613177#step:5:230 shows that the JVM's maximum heap size is set via the command line, rather than being derived from the MaxRAMPercentage of the host's memory.
Gradle version
8.10.2
Build scan URL (optional)
No response
Your Environment (optional)
No response

This feature request is in the backlog of the relevant team and is prioritized by them.