No Index, No Follow - Remove from Index

Please change the application in order it does not index in Serps.

It should be possible to add some headers to the NGINX proxy config to achieve this.

I believe the quick answer is to add the following to the location blocks in nginx
add_header  X-Robots-Tag "noindex, nofollow, nosnippet, noarchive";

but it might be more useful to add in the meta tag to the html and haml.

To make sure nothing is index I added to all path/pages/assets:
location / {
    add_header  X-Robots-Tag "noindex, nofollow, nosnippet, noarchive";
    ....
}

location /assets {
    add_header  X-Robots-Tag "noindex, nofollow, nosnippet, noarchive";
    ....
}

location @puma {
    add_header  X-Robots-Tag "noindex, nofollow, nosnippet, noarchive";
    ....
}

@Igcorreia I've just spotted that there is an extra space between add_header and X-Robots-Tag so you should remove that so the header is correct and not  X-Robots-Tag. I'll update my original comment.


Chrome Web Store

The link  for the Chrome Web Store (https://chrome.google.com/webstore/detail/nojknakoailnpbjlmfkpbbhoodlolfbh) doesn't work anymore. Is this not available anymore?

Any new?


fix: fix missing deps and build order

some package used in source code, but not listed in package.json

repo dir
missing deps
used in

@vuepress/client
vite
https://github.com/vuepress/vuepress-next/blob/e028f887ee9ee10d52abff9e37a9148139372e43/packages/%40vuepress/client/tsconfig.json#L22

@vuepress/plugin-docsearch
@docsearch/react
https://github.com/vuepress/vuepress-next/blob/e028f887ee9ee10d52abff9e37a9148139372e43/packages/%40vuepress/plugin-docsearch/src/shared/types.ts#L1

@vuepress/plugin-pwa-popup
vue
https://github.com/vuepress/vuepress-next/blob/e028f887ee9ee10d52abff9e37a9148139372e43/packages/%40vuepress/plugin-pwa-popup/src/client/components/PwaPopup.ts#L1

@vuepress/plugin-search
vite
https://github.com/vuepress/vuepress-next/blob/e028f887ee9ee10d52abff9e37a9148139372e43/packages/%40vuepress/plugin-search/tsconfig.json#L9

@vuepress/plugin-theme-data
vite, vue
https://github.com/vuepress/vuepress-next/blob/e028f887ee9ee10d52abff9e37a9148139372e43/packages/%40vuepress/plugin-theme-data/tsconfig.json#L9 https://github.com/vuepress/vuepress-next/blob/e028f887ee9ee10d52abff9e37a9148139372e43/packages/%40vuepress/plugin-theme-data/src/client/clientAppEnhance.ts#L1

@vuepress/plugin-toc
vue-router
https://github.com/vuepress/vuepress-next/blob/e028f887ee9ee10d52abff9e37a9148139372e43/packages/%40vuepress/plugin-toc/src/client/components/Toc.ts#L4

@vuepress/theme-vue
@vuepress/core
https://github.com/vuepress/vuepress-next/blob/e028f887ee9ee10d52abff9e37a9148139372e43/packages/%40vuepress/theme-vue/src/node/vueTheme.ts#L1

ts build order:

@vuepress/theme-vue deps on @vuepress/core, thus @vuepress/core should build first

I think @vuepress/client should not depend on vite

I personally think @vuepress/client should not depend on vite

Vite exposes its manual HMR API via the special import.meta.hot object, and declare it at vite/client.d.ts. @vuepress/client using it to avoid ts build error, so at least vite should be an devDependencies, i will change it, and others. 😁

Nice catch. Then @types/webpack-env should go along with vite.

I've noticed that we are missing deps. I'll update the eslint rules later to check the dependencies.

Nice catch. Then @types/webpack-env should go along with vite.

Updated，😄

@meteorlxy thanks for your review, changed.


Do you want to share your theme? Forecast

Hello, how are you,
any forecast to be ready?
I look forward to creating my hehe

@CeruttiMaicon This is something that is still on my to-do list but I could not advance it because I dedicate myself to other priorities and my time is limited, I hope I can find time to do it soon, it is definitely something that I am interested in doing.


RTL support

input

input’s icon should have appropriate padding for rtl direction
label rtl positioning is broken

textarea

label rtl positioning is broken

checkbox

label rtl positioning is broken

radio button

label rtl positioning is broken

button

icon rtl spacing

phone input

Should always be LTR even when theme is RTL (numbers in RTL are still LTR, and switching the layout to RTL breaks the “country code” section
double check arabic numeric support

from https://tablecheck.atlassian.net/browse/BEXS-679

progress:

[x] input
[ ] textarea
[ ] checkbox
[ ] radio button
[ ] button
[ ] phone input

@wahidfarid can we close this one?

i'm not 100% sure 😓
i would have spent more effort here as part of working on RTL in the booking form. but that epic keeps getting delayed. we do eventually need to do it though, and there's no guarantee we will have transitioned the booking form to TK3 before then

I we keep the ticket open, it'd be better to do the RTL on TK 3

@gazpachu i agree


List the known identifiers, and link them to the corresponding service

In the Virtual Network's subnet UI it is possible to choose which service a subnet is delegated to. However, it is very difficult to find a comprehensive and understandable list of what service is e.g. "Microsoft.App/environments" or "Microsoft.ContainerService/managedCluster".
Apparently these names have some resemblance or link to the ARM / Bicep reference docs but even from there it is very difficult to find what you're looking for.
Perhaps putting the identifier of the service in parenthesis next to the name on this page would help make things more clear?
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2422f8ec-802e-7f92-c499-9181f3fe8d8b
Version Independent ID: eb2b0e2c-8fb5-573c-ef0d-50073d053c3d
Content: Virtual network for Azure services
Content Source: articles/virtual-network/virtual-network-for-azure-services.md
Service: virtual-network
GitHub Login: @asudbring
Microsoft Alias: allensu

@anttikes
Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

Thanks for your dedication to our documentation. We have created an internal work item in our backlog to resolve this issue. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


Add Adyen 3ds redirect test

I want to merge this change because of adding Adyen 3ds redirect test.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-2738 Optimize paymentStatusDisplay resolver in Order type

Task linked: SALEOR-2783 Fix Adyen 3ds tests.


not working in local env

What am I trying to do..
Getting it to work on XAMPP
What I did:

cloned repo into htdocs folder
renamed folder
created mysql db in phpmyadmin
imported the included sql file
changed the base url in config file
changed db details in database.php file
tried viewing the site

..What's happening
See attached photo

Thanks in advance

I fixed the issue, it was an issue with the .htaccess file. Thanks!!

I fixed the issue, it was an issue with the .htaccess file. Thanks!!

How you fixed this? Can you please let me know?
What changes you made?

for reference this is my .htaccess in a standard lamb stack:


Output development build

Hey guys, is there a way to output a development build? So basically the same way yarn run build builds a production bundle, is there a way to build & output a development bundle where process.env.NODE_ENV !== 'production'?

I think the issue with that would be with webpack-dev-server since it doesn't write files to disc. So you can't really do it.
You could try ejecting and manually setting the NODE_ENV in the build script if you want to.
Here: https://github.com/facebook/create-react-app/blob/next/packages/react-scripts/scripts/build.js#L13

Closing as dupe of https://github.com/facebook/create-react-app/issues/790


Missing ENTRYPOINT and CMD annotations in manifest with newer Docker versions

Hi @yifan-gu , @jonboulle
Related to: https://github.com/appc/docker2aci/issues/122 , @mlin and I noticed that there appears to be an issue where the manifest file is missing ENTRYPOINT and CMD annotations when newer versions of Docker are used to build images and those images are subsequently posted to Dockerhub.
An example to reproduce this issue is:
Using two versions of Docker (in our case we used 1.6.2 and 1.11.2, the current versions on Ubuntu 14.04 and 16.04 respectively):

Build a simple Docker image using both versions of Docker:

echo "FROM ubuntu:14.04
ENTRYPOINT ls" | docker build -

Push each image to Dockerhub (in our example we have geetduggal/docker2aci-entrypoint-issue and dnamlin/docker2aci-entrypoint-issue built with Docker versions 1.6.2 and 1.11.2 respectively)

Run docker2aci docker://<repo>/<imagename> on each of these images

We noticed that the manifest file for image associated with dnamlin (Docker version 1.11.2) did not contain the entrypoint annotation while the image associated with geetduggal (Docker version 1.6.2) does.
Consequently, we cannot emulate the ENTRYPOINT + CMD user experience as discussed in the original issue.
If we manually pull and save the image from Dockerhub (using docker pull and docker save), then the annotation is preserved.   Therefore it appears that something in the interaction between docker2aci and Dockerhub is causing this missing annotation and that's about as far as we have narrowed it down to.

It seems the older image uses Docker API v2.1 and the newer v2.2.

Excellent.  Thanks!

@iaguis do we need a rkt bump? :grin:


exclusiveFilter doesn't follow disallowedTagsMode=escape

exclusiveFilter is always removing the tag from the text instead of escaping when disallowedTagsMode=escape
test('exclusiveFilter with escape', () => {
  const config = {
    disallowedTagsMode: 'escape',
    allowedTags: [ 'a' ],
    allowedAttributes: { 'a': [ 'href' ] },
    allowedSchemes: [ 'http', 'https' ],
    exclusiveFilter(frame): boolean {
        return (frame.tag === 'a' && /google.com/.test(frame.attribs.href));
    },
  };
  const input = 'ok google other';
  const expected = 'ok <a href="google.com">google</a> other';
  const output = sanitizeHtml(input, config);

  // fails, actual output: 'ok  other'
  expect(output).to.equal(expected);
});

Thanks for the contribution, but I don't think this is a bug. The description of the option is "You can provide a filter function to remove unwanted tags" (my emphasis). The intention is to remove them. There's a valid use case for exclusive escaping, but that would be an enhancement.


chore: drop un-necessary urllib3 dep

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Upstream removed this un-necessary dep

@conda-forge-admin please rerender


Spiget plugins ignored

The PLUGINS env is ignored too

I'm not sure why you think this is an issue with this docker image.

As you see there, the plugin PaTzCore need LuckPerms... then you need to install LuckPerms in the folder.
And it's not Spiget, is Spigot.


Added Clear-cache option in menu

Closes #89 A clear cache option in menu has been added which clears the cache of the electron application.

@jajodiaraghav thanks for working on this. Two things -

Remove it from help menu and put it in file menu. Specifically here and here.
I see no changes after clearing the cache. What does it do?

@akashnimare

Remove it from help menu and put it in file menu. Specifically here and here.

Done

I see no changes after clearing the cache. What does it do?

It opens a dialog which prompts with the message "Cache cleared".

And what happens once the cache is cleared? Does user gets logged out?

No. Should it logout automatically after cache gets cleared?

Wait. Let me investigate what should ideally happens once the cache is cleared in electron.

Could you please fixed these linting errors - https://travis-ci.org/zulip/zulip-electron/jobs/189759542#L303

Okay. I am working on it

You can test it with npm run test. We are using XO linter.

@jajodiaraghav cool. It works as expected. Basically this option deletes the temp. files present in userData/Zulip/Cache folder 😄  I'll merge it once you fix those linting errors.

@jajodiaraghav Merging 🚀


Scientific-SNAP branch. Provides means of leveraging Xilinx ap_fixed …

Scientific-SNAP fork. Provides means for leveraging Xilinx ap_fixed data-type for both sw and hw actions. Added hls_double_mult app based on said data-type .
Signed-off-by: Flavio M. de Paula<EMAIL_ADDRESS>

@bmesnet
Hi Bruno, I uploaded this ap_fixed version of hls_double_mult so that folks have available to them two different approaches to deal with single and double floating-point precision numbers. I didn't intend to overwrite hls_decimal_mult.  However, given that I have hls_decimal_mult with ap_fixed in my sandbox. I could either upload it with an alternative name or overwrite the existing one. Let me know what you prefer. I would then delete hls_double_mult.
To reiterate my point, I  think it would be a good idea to have those two approaches as examples since, in fact,  they handle float/doubles in different ways.  Please, let me know what you think.


[SUGGESTION] Reformat the way whitelist works for multiple job types

Is your feature request related to a problem? Please describe.
Currently the whitelist works only for job types that share the same or similar whitelist values. Which means you can't have a job type of SHEAR and BREAK, because SHEAR only expects color types, so it throws an error when you add a block type.
Describe the solution you'd like
Could a solution like this be added:
whitelist:
  shear:
  - RED
  break:
  - hay_block

This way you can specify specific object types for that job type

This feature was added in the latest commit, if for some reason there is something wrong with it make sure to re-open this issue or create another one.


KAFKA-15364: Replay BrokerRegistrationChangeRecord.logDirs

Any directory changes must be considered when replaying BrokerRegistrationChangeRecord. This is necessary
to persist directory failures in the cluster metadata, which #14902 missed.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

36 tests have failed There are 0 new tests failing, 36 existing failing and 271 skipped.

@rondagostino PTAL

@stanislavkozlovski I think this is important for 3.7. I now restarted the unit tests as previously seems like Jenkins terminated. I'll make sure to cherry-pick this to the 3.7 branch too and the tests there as well.

Raised the cherr-pick in #15042

shouldHaveSamePositionBoundActiveAndStandBy – 34 tests have failed.  There are 26 new tests failing, 8 existing failing and 288 skipped.`
'org.apache.kafka.streams.integration.ConsistencyVectorIntegrationTestfailed in 3 of the 4 JDK versions (8, 11, and 17), but that seems unrelated. testTaskRequestWithOldStartMsGetsUpdated() – org.apache.kafka.trogdor.coordinator.CoordinatorTest` failed in JDK 21 and 11 and also seems unrelated.
@viktorsomogyi WDYT?

shouldHaveSamePositionBoundActiveAndStandBy only failed on JDKs 8 and 21 on the 3.7 PR (https://github.com/apache/kafka/pull/15042), which overall had 37 tests have failed.  There are 0 new tests failing, 37 existing failing.
testTaskRequestWithOldStartMsGetsUpdated only failed on JDK 11 on the 3.7 PR.
I'm inclined to say these are flaky tests.  I'mm ognna merge this and the other one.


Additionally support oidc-token-verifier:^1.0

@acoulton having to guess at this a bit but the failure due to the alg here being RSA256 where here it's keyed as RS256??
If I change that to RSA256 it throws DomainException : Algorithm not supported so presumably we need to publish a new (or replacement) key at oidc-auth-sandbox?

Hmm, I'm just having a quick look. RS256 is the algorithm name as defined in JWT, it's possible that previously something in the key parsing was coping with the openid file saying RSA... and mapping that to the value JWT expects.

Argh, ok so it's a historical typo in our test stuff. Google's certs endpoint has "alg": "RS256" and that matches the JWK spec, which points to the RFC for the algorithms for use with all the JWT / JWK / etc protocols
But prior to firebase/php-jwk@v6 it didn't matter because the alg in the provider's JSON keys file was being ignored, we were just forcing RS256 when comparing to the actual JWT that had been issued.
So yeah, as you say we'll need to change https://github.com/ingenerator/oidc-auth-sandbox/blob/main/openid-jwks-certs.json#L8 to RS256 (which should be safe to do in-place because older versions of this lib ignore that anyway).
We'll also need to change the cloud-tasks-emulator, I based that cert endpoint on the tests for this package so it's wrong too https://github.com/acoulton/cloud-tasks-emulator/blob/master/oidc.go#L140 - I can look at that.

OK, fixed in our fork of the emulator with https://github.com/acoulton/cloud-tasks-emulator/commit/3c478a26e5c2c15b47a8932166724da7078ea4c1 and I've released that as ghcr.io/acoulton/cloud-tasks-emulator:1.2.5-acoulton but need to chat to you tomorrow about tagging strategy for that fork.


Updating jurisdiction outreach

This PR ...
Updates the documentation

@RickHawesUSDS @anshulkumar-usds just made the latest update to the jurisdictions doc

@RickHawesUSDS could you take a look at the latest update?


Password prompt syntax

It would be nice if the password prompt ended with a ":" instead of a ">" so that expect scripts and other tools (e.g. emacs) could recognize that it's a password and not echo.
Change
fmt.Print("password>")
to
fmt.Print("password:")
or make this configurable.

I've got no strong feeling about it, so I added a PR.

Sorry, late to the party!  Yes a prompt ending in : seems to be the unix standard.
@leighklotz can you submit your pull request to this repo.  Note that you only need to change the markdown docs as the other docs are auto generated.


Fix pre-commit issues in the files imported for demo2

Files imported from corporate-data-pipeline for demo2  have code style errors that should be fixed for our pre-commit tests to pass.

/assign


The MFA scripts is wrong

I think your provide align MFA scripts is wrong. I following your scripts to do, but it can not work.

Could not find 'fstcompile'.  Please ensure that you are in an environment that has the openfst conda package installed, or that the openfst binaries are on your path if you compiled them yourself.


Support Ubuntu 21.04

Description
Solves #5361

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[X] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

Built, deployed and launched an Advanced Zone on a single host with Ubuntu 21.04

@tetra12
can you revert the changes which are unrelated to the ubuntu 21.04 support ?
The only change we need seems to be
qemu-kvm (>= 2.5) | qemu-system-x86 (>= 4.2),

Ping @tetra12 can you please address the open comments?

Closing due to inactivity

@tetra12
I have created #5755 to support qemu-system-x86


not working using express 4.16.1

Hi,
ive tried to make the express-ws work with express 4.16.1
im using packages:
"cookie-parser": "~1.4.4",
"debug": "~2.6.9",
"express": "~4.16.1",
"express-session": "^1.17.0",
"express-ws": "^4.0.0",
"glob": "^7.1.6",
"morgan": "~1.9.1",
"mysql": "^2.18.1",
"nunjucks": "^3.2.0",
"webdav": "^3.2.0"
the code ive tried is:
app.ws('/socket/media_files', function (ws, req) {
    ws.on('message', async msg => {
        const file_object = JSON.parse(msg);
        ws.send(`data:${file_object.mime};base64,${await client.getFileContents(file_object.filename, {format: 'text'})}`);
    })
});
app.ws('/socket', function(ws, req) {
    ws.on('message', function(msg) {
        ws.send(msg);
    });
});```

ive also tried using the router but that also fails missirably, the issue i have is that i always get a 200 status request back

Hi reashetyrr.
I had the same trouble.
Try the links below.
https://stackoverflow.com/questions/40362258/package-express-ws-doesnt-let-clients-connect

@maruneko0 want to elaborate on this? like explain what it's doing?


Supporting tagging images during build

Resolves #213
Includes:

docs
validation for tags as list not string or dict
unit tests and an integration test

The first commit was some small cleanup in preparation for this change. _build_tag_name() would be confusing since it's not related to tags exactly. I believe full_name is more clear here because it's the name used by fig to uniquely identify this service, not just the image name.
The new unit tests also found a bug where BuildError() was not being called correctly.

@dnephin Can you point to this tool please? Came here from #467 and there you suggested to wait till this will be resolved. I just new to fig and want to know if pushing to registry from fig will be implemented anyhow, is there any plans for this?

The tool I'm using isn't open sourced yet, but it's basically something like this
fig build
fig up -d
# run some tests
fig stop

If the tests pass, the tool does:
docker tag project_service_1 new_image_name
docker push new_image_name

I think fig (now docker-compose) will probably support push eventually, I'm not sure when that will be though.

@dnephin yeah, I understood you can just tag all images, its just there can be more than one docker image to push, I mean some fig.yml parsing for images that have build entry in it, figuring out the name of image from it and pushing all of them at once.
Anyway, thanks for answer. I love fig's 'simplicity sweetness' and even think now that it can be damaging in some way - may be should do separate simple deploy tool.

Ya, I think there could be value in having some companion tools for complex build scenarios, and deployment scenarios. That way fig can mostly focus on composition, with very simple build, and the companion tools can focus on the more complex scenarios for each of those.

We still can't specify an image name of each build of compose... see use case here http://stackoverflow.com/q/30339950/535203
Neither tags: nor image_name: are supported by docker-compose...

See #2092 for the plan to support this


remove deprecation:false from scalacOptions in Test once Mesos removes deprecated fields from API

https://github.com/mesosphere/marathon/pull/4131#discussion_r72054647

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-2237. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-2237. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


examples: fix lsgpio flags output

I guess an user want's to see the flags ;)

Thanks! Sure, entry added.

Thanks, bors r+

bors r+


how do I fill a form?

I'm looking the option to fill the form, but it seems if I update model.name the input updated is not been submitted, I'm missing something?

meh, was a typo with nedb, sorry.


Create DOI button probably not in right place

Bug Report
The Create DOI button is next to Publish/Unpublish button, whose scope is the whole workflow.
The Create DOI button creates a button for a workflow version. Perhaps it should be located on the versions tab. OTOH, that will tend to hide its prominence.
Also, the Create DOI button is appearing on the My Services page, which we probably don't want at this point.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Issue Number: DOCK-846

The Create DOI button creates a button for a workflow version. Perhaps it should be located on the versions tab. OTOH, that will tend to hide its prominence.

:+1:

Also, the Create DOI button is appearing on the My Services page, which we probably don't want at this point.

Yes, it should probably be hidden given bandwidth.

In progress at https://github.com/dockstore/dockstore-ui2/pull/736

➤ Charles Overbeck commented:
Covered by DOCK-830.


How do I set asset name?

In unmaintained https://github.com/actions/upload-release-asset, we can set  each asset name with asset_name field.
Are there any equivalent functions/fields supported by this action?

Same problem here.
Any plans to add this?

There's also no equivalent for the asset_content_type field.


minor refactoring for the authentication changes

refactor validate method to be used across authenticators/token mangers
add types for token manager properties in authenticators
add return type for getAuthenticatorFromEnvironment
return Error object in checkCredentials rather than a string
add setters for disableSslVerification and headers in token managers so we can use stricter typing
Make authenticator optional in the base service options

This last point needed to be done to compile the Watson SDKs - TypeScript does not allow you to declare an optional parameter on an interface that extends another interface where the same parameter is required. We aren't exactly extending the interface (although I think we should) but we use the "extended" interface in a place where the base interface is expected and TS complains. This resolves the issue. We still validate for the authenticator, just can't type it that way.

It does and actually needs to PR in order to compile. I'll create an RC to use in the compatibility chart


Super tiny update: Add llama3.2

Hi thanks for the great list! When glancing it to find some information, I realize llama 3.2 seems to be missing, thus this super tiny PR :)

Thanks for adding this! Maybe llama 3.2 vision model should be included here?

Done!


v7.0.0-preview.1: can't cast string to [WMIClass] anymore

Steps to reproduce
Invoke the following:
[WMIClass] "\\$env:computerName\root\default:StdRegProv"

Expected behavior
Like in Windows PowerShell 5.1 and PowerShell 6.2.1, a ManagementClass object should be returned:
   NameSpace: ROOT\default
Name                                Methods              Properties
----                                -------              ----------
StdRegProv                          {CreateKey, DeleteK… {}

Actual behavior
Cannot convert value "\\SBAHOME\root\default:StdRegProv" to type "System.Management.ManagementClass". Error: "Cannot marshal 'parameter #3': Cannot marshal a string by-value with the [Out] attribute."
At line:1 char:1
+ [WMIClass] "\\$env:computerName\root\default:StdRegProv"
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : InvalidArgument: (:) [], RuntimeException
+ FullyQualifiedErrorId : InvalidCastToWMIClass

Environment data
PS C:/Users/steph> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.0.0-preview.1
PSEdition                      Core
GitCommitId                    7.0.0-preview.1
OS                             Microsoft Windows 10.0.18362
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

I can repo as:
[System.Management.ManagementClass]::new("test")

I guess it is .Net Core issue

@iSazonov what version of System.Management is PowerShell 7 referencing? If PowerShell updates the version of System.Management it ships with, then this exception should go away.

@jkoritzinsky It is 3.0.100-preview5-011568

@SteveL-MSFT @daxian-dbw Should we close the issue or wait until we move to the new .Net preview version?

@iSazonov the System.Management DLL ships out of band (it’s not part of the SDK). It lives in its own NuGet package. You’re using an outdated version from before 3.0.0-preview3.

@jkoritzinsky Thanks for clarify!
Is https://www.nuget.org/packages/System.Management/4.6.0-preview5.19224.8 right version?

Yes that is the correct version.

Wouldn't Dependabot keep us up to date, or does that not automatically happen for major versions?

@SteveL-MSFT @daxian-dbw Do we ready to update all packages to new versions (from 4.5.* to 4.6.*)?

dependabot is configured to bump stable versions to newer stable versions, and pre-release versions to anything that is currently available. Since we have moved to target .NET Core 3.0 preview5, I think we should update the nuget references to the latest preview versions.

Ran into this as well.  Importing the SCCM module hard crashes pwsh because they use that constructor in a finalizer.

they use that constructor in a finalizer.

Ooh, that's bad form!


protein glycosylation  not for direct annotation

I see a lot of modification terms  representing single steps are now flagges as not for direct annotation (yay)!
However, I think we need to 'unblock'
protein glycosylation
because this represents pathways rather than functions.
See for example:
https://www.pombase.org/term/GO:0006486
It is also in quite a few slim sets, and has children which are more clearly pathways, like
https://www.pombase.org/term/GO:0006488
dolichol-linked oligosaccharide biosynthetic process (GO:0006488)

I don't know the best solution here. Maybe change to "protein glycosylation pathway", in the short term?

Odd that this branch has do not annotate, but  the clearly single step processes like  "phosphorylation" and "methylation"  do not have the "do not annotate" tag?
Also for these terms, maybe a comment is needed for curators  and GO users  something like " this term should not be used for new direct annotations as it represents a single step process (molecular function), and is pending obsoletion from GO once existing manual annotations are migrated"

We added 'in bulk' do not annotate to all children of protein modification. I removed a few incorrect ones that I spotted, but this was was missed (it may not be the only one).
Thanks for reporting.
Pascale

The only things I have left annotated in the modification branch are
glycosylation
ubiquitin-type modifiers
peptidyl-diphthamide metabolic process (GO:0017182)
GPI anchor biosynthetic process
then
endoplasmic reticulum mannose trimming] (but this looks like an activity)
cytochrome c-heme linkage (but this looks like an activity)
protein-FAD linkage (but this looks like an activity)
protein deglycation (but this looks like an activity)
(I will remove PomBase annotations to these)

Do you get errors with ubiquitination? Normally I had removed the 'do not annotated' from these.

I removed the 'do not annotate' from GO:0017183 peptidyl-diphthamide biosynthetic process from peptidyl-histidine
I think we could obsolete GO:0017182 peptidyl-diphthamide metabolic process and GO:0017184 peptidyl-diphthamide catabolic process, as they are not used.
What do you think ?

glycosylation was the only error I saw, but I only saw that through PHi-base. I haven't checked PomBase logs.
I was just letting you know the ones I think should not be blocked to see if we agree ;)

not sure...
https://www.pombase.org/term/GO:0018202
these is a pathway. I think it probably just needs different parents?

Right, the synthesis is OK. I dont know that there is a catabolic process? Is this modification reverted? (at least, that's not annotated)

I think we could obsolete GO:0017182 peptidyl-diphthamide metabolic process and GO:0017184 peptidyl-diphthamide catabolic process, as they are not used.

OK, I misread, I agree


Add Esperanto to the list of available languages for the documentation?

Sorry if this isn't the right place for this^^, I was wondering if anybody here had considered adding Esperanto as a supported language for translation. I'll admit it isn't a very popular language, but I feel there's some overlap with Esperanto speakers and the FOSS community- maybe enough to justify it?
Any discussion appreciated :D

Sure, you can add the translation yourself if you intend to contribute to it:

But I'd focus on contributing to the editor translations first maybe: https://hosted.weblate.org/projects/godot-engine/godot/eo/
Translating the docs is a tremendous amount of work.

(BTW issues about the documentation website should go to https://github.com/godotengine/godot-docs :))

Ooh, right. I'll take a look at the editor translations, I didn't even realize that existed. Thanks so much :D


Replace SegmentIO with EventTracker

Description
MA-2981
Notes

The user is able to setup the wanted service in the RuntimeApplication class.
Every tracking service should implement the IEvents interface before appending it to the tracking services.
The EventsTracker class is the one responsible for calling all services tracking methods (The change that's responsible for the large diff).
I refactored the login and register to track failures as well.
Some naming advice is needed.

Testing

[ ] Unit, integration, acceptance tests as appropriate
[ ] Analytics
[ ] Performance

Thanks for the pull request, @ahmedaljazzar! I've created OSPR-1612 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.
If you like, you can add yourself to the AUTHORS      file for this repo, though that isn't required.     Please see the CONTRIBUTING     file for more information.

Current coverage is 18.74% (diff: 12.91%)

Merging #890 into master will decrease coverage by 0.20%

@@             master       #890   diff @@
==========================================
  Files           470        470
  Lines         19992      20194   +202
  Methods           0          0
  Messages          0          0
  Branches       2926       2965    +39
==========================================
- Hits           3789       3786     -3
- Misses        15752      15960   +208
+ Partials        451        448     -3

Powered by Codecov. Last update edfe648...cd1542d

Thanks for the great contribution.
As you might already know that currently we are working on Firebase integration and this generic framework is what we need for it. So, I've checked out a branch from yours and have added a refactoring commit over it (which is still a work in progress).
Branch: https://github.com/edx/edx-app-android/tree/khalid/MA-2981
Commit: 56afab9234f7a2babbe7bd694bf675c03003b69e
Moving forward, would you want to continue on this PR or should I open one from my branch ?

Thanks @miankhalid for the review! I saw your refactoring commit and the changes looks much better that way :)
We at Edraak are interested in these changes too, so I have the capacity to continue working and updating them. I'll start by cherry-picking your changes :)

@ahmedaljazzar so are you suggesting that we work on the same branch or our own branches ?

@miankhalid we can work on any branch you prefer.

@ahmedaljazzar I'd like to work on my own branch :)
p.s. I am currently exploring the possibilities of removing return types from all our analytics events i.e. the return types from functions in Analytics interface, as they don't make much sense. But that leads to some test failures which use those return values.
Closing this PR in favor of 1 that I'll open very soon.

@miankhalid Great!
I noticed that the return types are being used in the tests, so I kept them. But as you said, they don't make much sense.


VScode opens empty file

VSCode Version: 1.52.1
OS Version: macOS Big Sur 11.1

Steps to Reproduce:

Terminal -> Go to yours code directory -> code . OR Launch Visual Studio Code -> Open folder

Does this issue occur when all extensions are disabled?: Yes

Hey @markkkkas how you solved this issue, I am also facing this issue.
Issue does not solve this issue.

Hey @markkkkas how you solved this issue, I am also facing this issue.
Issue does not solve this issue.

Hi @hackrx. Unfortunately its very rare case when i hit this bug, for my helped pc restart

Hi @hackrx. Unfortunately its very rare case when i hit this bug, for my helped pc restart

In My case opening the folder directly from vs code Explore is also not working. :(,

In My case opening the folder directly from vs code Explore is also not working. :(,


How to test on macos

could you share .project file?

I'm sorry, haven't updated this in a long while, I don't think it works with current godotengine.


enable apple-mobile-web-app-capable

This would make a Home Screen link open without the safari window chrome, to feel more native.
Is there a security issue in this? I mean you won't know if you're
getting MITM’d  in safari either, and if this encourages bookmarking
and not following links to a funny looking domain, then that's safer.
Safari and the PWA/home-screen instances have different
sandboxes entirely though, so this sort of complicates link-handling.
A user clicking a link to receive funds would have to funnel through their
second safari wallet to the PWA wallet.
I'm not really sure if there's UX gains here or in #11 versus going full React Native. And maybe not even full RN? There is a lot of elegance in basic web only. 🤔
Honestly I couldn't even get the app to load from my phone over LAN, with or without PWA mode enabled. (Was loading & sending funds on simulator just fine, but testing "Link" button hung at 100% progress, unsure why, running low on steam tonight)
Figured it was worth pushing what I'd done and the results of the investigation (doesn't look great for this direction IMO).

The problem with "display": "standalone" is that the camera doesn't work in this mode. So the QR reader falls back to the legacy version.


strip out mailto: from author email uri with wp_parse_url

It doesn't look like the $author['url'] is validated either?
What should happen if $author['email'] isn't an address?  Would it be valid to put in a URL to a email submission form?

I agree, we should improve both.

What if it has no mailto:? Does it also work?

is_email has a warning: Does not grok i18n domains. Not RFC compliant.
I wrote quick test:
$strings = [
<EMAIL_ADDRESS><EMAIL_ADDRESS>
<EMAIL_ADDRESS><EMAIL_ADDRESS>
    "snar.com",
    "com",
    "https://snar.com/path/to/email/form"
];

$parse = "wp_parse_url";
if( ! function_exists( $parse ) ) {
    $parse = "parse_url";
}

$isemail = "is_email";
if( ! function_exists( $parse ) ) {
    $parse = "parse_url";
}
$validate = "filter_var";
if ( function_exists( "is_email" ) ) {
    $validate = "is_email";
}
echo "Using " . $parse . " and " . $validate . "\n";
foreach ($strings as $string)
{
    $email = $parse($string, PHP_URL_PATH );
    $valid = "n ";
    if( function_exists( "is_email" ) && is_email($email) ||
        filter_var($email, FILTER_VALIDATE_EMAIL) ) {
        $valid = "y ";
    }
    echo $valid . $string . " -> " . $email  . "\n";
}

// Using parse_url and filter_var
// y<EMAIL_ADDRESS>-><EMAIL_ADDRESS>// y<EMAIL_ADDRESS>-><EMAIL_ADDRESS>// y<EMAIL_ADDRESS>-><EMAIL_ADDRESS>// y<EMAIL_ADDRESS>-><EMAIL_ADDRESS>// n snar.com -> snar.com
// n com -> com
// n https://snar.com/path/to/email/form -> /path/to/email/form

// Using wp_parse_url and is_email
// y<EMAIL_ADDRESS>-><EMAIL_ADDRESS>// y<EMAIL_ADDRESS>-><EMAIL_ADDRESS>// y<EMAIL_ADDRESS>-><EMAIL_ADDRESS>// y<EMAIL_ADDRESS>-><EMAIL_ADDRESS>// n snar.com -> snar.com
// n com -> com
// n https://snar.com/path/to/email/form -> /path/to/email/form

We can use filter_var, I just think we should start validating urls and emails properly.

I didn't look at filter_var details.  What should the behavior be when it's an invalid email?

It should not save the parameter

I'm not convinced this is working right... do the tests cover any of this code?


Second factor page displaying broken iframe on Firefox

After authenticating with username/password, I see this in Firefox on the second factor page:

It looks like Firefox isn't able to understand the chrome-extension iframe, so it displays an error in the iframe.

Hello @tpansino , what version of Firefox do you use?

Hello, same iframe on second factor page. I use Firefox 66.0.5 (64-bit)

@clems4ever Version 66.0.5 (64-bit), same as @tunip. I also think version 65 had it as well.

It's weird, I cannot reproduce with 66.0.3 (64-bit). I thought I had solved that issue a while ago... I will continue to search what it can be due to. My guess right now is that I have something installed on my laptop that you guys don't have. I need to figure out what.
I'll let you know if I find something.

Do you use the latest version of Authelia?

I use version 3.15.0 installed via npm.

I'm using image: clems4ever/authelia:latest in my docker-compose.yml file.
I tested it with all Firefox add-ons disabled and was still able to reproduce the issue. @clems4ever, you might try the "Restart with Add-ons Disabled" option as well, see if that helps you.

Thanks @tpansino , did not know that option, I will have a look.

I've just tried and I still don't reproduce. That's weird. Do you have the the config flag: "security.webauth.u2f" disabled or enabled? What if you toggle it? You need to access "about:config" to do so.

Ah yes, security.webauth.u2f = false in my about:config (which is the default).
Toggling it to true does resolve the issue. So I guess there needs to be a fix around that setting?

I guess there should be a fix indeed but I've not found it yet unfortunately. I'm still actively looking for it though.

@clems4ever it looks like Firefox now defaults security.webauth.u2f = true, at least as of version 67. That makes this issue less significant since most people won't change defaults and notice it.
Do you still want to leave this open to eventually find a fix?


Make ockam relay delete (no args) interactive by asking the user to choose from a list of relay names to delete (tuify)

Current behavior
When a user runs ockam relay delete without any arguments, currently they are presented with an error & help text. Here's a screenshot of this.

Desired behavior
Instead of displaying help text, change the behavior of this command so that it becomes interactive with the user. Note that this can only be allowed to happen if:

the terminal is interactive, and,
the --no-output or --quiet flags have not been passed, and,
no arguments have been passed in to the command.

This what the user flow should look like in interactive mode.

Use the tuify crate's select_from_list() function to ask the user to select from a list of relay names, at the default node. They should be able to make multiple selections. If there are none, then simply display a message saying that none exist (not an error) and exit.

Once the user has made their selection(s), display a confirmation prompt letting the user know that that a destructive operation is about to take place with the relay names they have selected. Use select_from_list() to display this prompt. They should be able to make a single selection.

If they have made no selections then exit by displaying a message to the user letting them know they did not make any selection.

If they choose "YES", then delete each selected relay, and display a success / failure message for each relay that got deleted.

If an operation succeeds then use the ✅ emoji as a prefix for the message.
And if it fails, then use the ⚠ emoji as a prefix for the message.

The following is a video showing a generic user flow that shows the user experience when a user is asked to choose a from a list of "things". Then an action is performed on each "thing". Finally status information is reported for each action that is performed on each "thing". Please note that this flow is not specific to this issue.

https://asciinema.org/a/612547

Implementation details

If it hasn't been added already, please add the tuify crate the Cargo.toml file here by adding this line r3bl_tuify = "0.1.16" to the [dependencies] section (or whatever the latest version of this crate is).

You can learn more about how to use the select_from_list() in the tuify crate here. Here is an example that is very similar to the steps you might have to take for this issue.

Here's a file you can look at to detect when a terminal is interactive or not.

Here's a file you can look at to see where the ockam relay delete command is implemented.

We love helping new contributors! ❤
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.

I've taken https://github.com/build-trust/ockam/issues/6466 which is very similar to this (at least in the functionality). So I think it will be better if you can assign this to me too, so I can implement them in one PR and maintain on the constantly across the project.

@0x61nas Once you land the PR for https://github.com/build-trust/ockam/issues/6466 you can pick the next issue after that 👍🏽

Hi! I am wondering if I could pick up this issue? :)

@PanGan21 That's awesome, this is all yours. Please let us know if you have any questions as you explore. You can also ask questions on the contributors discord https://discord.gg/RAbjRr3kds

@PanGan21 Since you started working on this issue, here's some new information that's become available that might help you w/ your PR.

Please use the functions select_multiple, and confirm_interactively in this file.

Here's a similar PR to get some ideas from: https://github.com/build-trust/ockam/pull/6480


Custom Resource Tagging Feature

Description

Custom Resource Tagging Feature added: Tags, VMTag, DiskTag, and NicTag.
Respective columns mentioned above are added in the Input.csv as well.

Az version: 10.1.0

#sign-off


HADOOP-19242. Aliyun oss add a redirection switch

Description of PR
How was this patch tested?
New unit tests; cloud store tests
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m  5s

trunk passed

+1 :green_heart:
compile
0m 28s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 27s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 27s

trunk passed

+1 :green_heart:
mvnsite
0m 32s

trunk passed

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 48s

trunk passed

+1 :green_heart:
shadedclient
33m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 20s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 15s
/results-checkstyle-hadoop-tools_hadoop-aliyun.txt
hadoop-tools/hadoop-aliyun: The patch generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0)

+1 :green_heart:
mvnsite
0m 21s

the patch passed

+1 :green_heart:
javadoc
0m 21s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 45s

the patch passed

+1 :green_heart:
shadedclient
33m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 23s

hadoop-aliyun in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

133m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6967/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux f740b5f6e52a 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b672ebc7057f88fe2cbcbb958080ee8a3f93d9d4

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6967/1/testReport/

Max. process+thread count
704 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aliyun U: hadoop-tools/hadoop-aliyun

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6967/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

I think we need to review how other Ailyun integration tests are binding...they should all have the prefix ITest to make clear they are integration tests to only run in a mvn verify target

Currently, none of the OSS test cases have the ITest prefix. I'm not sure about the historical reasons, and I may need to discuss this with other colleagues on the Aliyun OSS team. Can this PR be considered separately from the changes to add the ITest prefix?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
9m 16s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 41s

trunk passed

+1 :green_heart:
compile
0m 25s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 24s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 29s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 45s

trunk passed

+1 :green_heart:
shadedclient
34m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 17s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 4 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 14s
/results-checkstyle-hadoop-tools_hadoop-aliyun.txt
hadoop-tools/hadoop-aliyun: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 46s

the patch passed

+1 :green_heart:
shadedclient
34m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 21s

hadoop-aliyun in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

132m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6967/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d2ec15b338c8 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c195866b352ad43381e5f007248b5e2036cdf001

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6967/3/testReport/

Max. process+thread count
645 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aliyun U: hadoop-tools/hadoop-aliyun

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6967/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 15s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 29s

trunk passed

+1 :green_heart:
compile
0m 27s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 26s

trunk passed

+1 :green_heart:
mvnsite
0m 29s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 44s

trunk passed

+1 :green_heart:
shadedclient
34m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 20s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 18s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 4 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 14s
/results-checkstyle-hadoop-tools_hadoop-aliyun.txt
hadoop-tools/hadoop-aliyun: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 47s

the patch passed

+1 :green_heart:
shadedclient
34m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 21s

hadoop-aliyun in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

136m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6967/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c099904aa814 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c195866b352ad43381e5f007248b5e2036cdf001

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6967/2/testReport/

Max. process+thread count
627 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aliyun U: hadoop-tools/hadoop-aliyun

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6967/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran @masteryhx @zeekling   hi，I have made the suggested changes to the code. Please take a look again. Thanks.
The main changes include simplifying the code mentioned in the comments, updating some comments, and adding Javadoc for the flag.
Additionally, I consulted with other colleagues from the Aliyun OSS team. Since the original code did not include the ITest prefix for OSS integration tests, and the case names have not been changed since then, I do not plan to modify the case names in this PR. I propose creating a separate PR to update the integration test names later.


Viewportsize parameter is ignored

I have discovered that some situations the --viewportsize option is ignored. For example if I run
capturejs --uri http://www.fosspatents.com/ \
            --viewportsize 1400x1000 \
            --output 'fosspatents.com.png'

all I get is a pretty large website. Maybe I get the meaning of this parameter wrong but I would expect that all the content that is not in the viewport is cut off.

I had the same issue, but the problem is not the viewportSize parameter and the lack of the clipRect I will submit a PR with the fix

Check-it out my PR #21

Nice! :thumbsup:


Data Manipulation and Querying in SQL_2.

Data Manipulation and Querying in SQL_2.

Data Manipulation and Querying in SQL_2.


Annotation selection not working when setting the hotkey as inverted

Hello guys,
(sorry in advance for my English)
I think I found an issue when using the plugin along with the hotkey config, setting the inverted value as true. I have provided below a simple code that can replicate the behavior.
When I set the inverted property as true, I'm no longer able to select directly the annotation, only while holding the hotkey button I'm able to select it.
The documentation says "Image navigation is only possible when the hotkey is pressed", which is exactly what I want, but I also wanted to select the annotation just by clicking on it, without holding the hotkey.
Setting the inverted as false, I can select directly the annotation to Edit/Delete without any problems.
Is this the correct behavior when using the inverted key?
Is it possible to have the inverted as true and being able to select the annotation only by clicking?
I tested with the latest release version (2.7.8) in Mozilla Firefox 106.0.5
Thanks!!
<!DOCTYPE html>

    <title>SeaDragon hotkey</title>

    <link
      rel="stylesheet"
      href="https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>    />

Thanks, I can reproduce. Hm, yes that's currently the way it works. (Just like a click on an annotation does not select it when you are not using inverted hotkeys, and have Shift pressed.) But I agree a click should trigger selection in any case. I need to check how to best implement this. I'll put it on the list!

Just to add, with OpenSeadragon v4.1 headless mode with inverted key is true, the creation of the annotation only happens on first load. After creating one annotation, you cannot create annotation anymore.
You can check it here: https://jsfiddle.net/riichan/j3Lvq92h/7/
Hopefully, it gets fixed after the release of Annotorious v3.


Web animation polyfill

Could be a good move to use https://github.com/web-animations/web-animations-js polyfill and join forces on that.

I am part of the team behind that polyfill. The most recent releases don't support SVG attributes.
See also my comments in #46


Added Q on VPAT et al.

Added pointer to the US user group.
Also cleaned up the file a little.

Just some small errors there @anitagraser then LGTM after


As an Administrator I want to be able to configure Metrics components to use TLS client authentication for PostgreSQL so that the connection is more secure

Currently, there is no way to configure the components to connect to PostgreSQL using client TLS even if the PostgreSQL is configured to accept them. We should extend the settings so that PostgreSQL can also be configured to use TLS. Currently, the following modules require access to PostgreSQL:

Anonymizer
Opendata
Networking

More information about the X-Road Metrics system architecture is available here.
The ticket this issue was created from is available here: https://nordic-institute.atlassian.net/browse/OPMONDEV-150
Acceptance criteria:

[ ] Client TLS can be configured in settings.yaml for PostgreSQL connections in all Metrics modules that use PostgreSQL
[ ] The old configuration continues to work without TLS
[ ] Documentation is updated to inform users about this option
[ ] The example settings.yaml files of all affected modules are updated

This was released with v1.1.0 so I will close this issue now.


Fixed Pytest on Python 2.6 & 3.3

Fixed Pytest on Python 2.6 & 3.3
Description
CI was failing with  Python 2.6 & 3.3 because new version of Pytest doesn't support.
I make Python 2.6 & 3.3 use the last compatible Pytest version.
https://docs.pytest.org/en/latest/changelog.html#pytest-3-3-0-2017-11-23
Status
Done
Checklist (tick everything that applies)

[x] Code linting (required, can be done after the PR checks)
[x] Documentation
[x] Tests
[x] ICLA (required for bigger changes)

Codecov Report

Merging #1150 into trunk will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            trunk    #1150      +/-   ##
==========================================
- Coverage   85.49%   85.49%   -0.01%
==========================================
  Files         348      348
  Lines       66579    66579
  Branches     5925     5925
==========================================
- Hits        56924    56922       -2
- Misses       7247     7249       +2
  Partials     2408     2408

Impacted Files
Coverage Δ

libcloud/test/compute/test_ec2.py
97.77% <0%> (-0.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb0cef...37e26a8. Read the comment docs.

Okay, no oppositions on the mailing list, and we'll always have time to add support again if the release is blocked because of this during the vote.
@ZuluPro Do you think you coud open a new PR to remove support for 2.6 and 3.3? Let's not remove paramiko just yet to give us some time to investigate. Thanks for your really helpful work on this!

Hi Quentin,
I don't know if anyone can check, what happens when you try and install it
from 2.6? Does it just install an older version? I've heard solutions that
would support this kind of setup
On Fri, Dec 8, 2017 at 3:28 PM, Quentin Pradet<EMAIL_ADDRESS>wrote:

Okay, no oppositions on the mailing list, and we'll always have time to
add support again if the release is blocked because of this during the vote.
@ZuluPro https://github.com/zulupro Do you think you coud open a new PR
to remove support for 2.6 and 3.3? Let's not remove paramiko just yet to
give us some time to investigate. Thanks for your really helpful work on
this!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/libcloud/pull/1150#issuecomment-350169183, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABdiARp3ACRJEPwz1ss2zmwZ6e7AdusUks5s-LrWgaJpZM4Q4sVY
.

@tonybaloney You mean installing pytest from 2.6 or 3.3? It fails, which is why the CI was failing and we noticed the issue. But that's exactly what @ZuluPro was proposing. Do you think keeping 2.6 or 3.3 is valuable?

Would be nice to see this getting solved so that the CI would be fully functional and the PR's would be processed in normal way.

@iler The problem is that nobody is reviewing the pull requests, including this one.


Adding e2e tests for MyHunt page.

this is the e2e tests for the MyHunt page.

This issue is being covered in another issue and branch 11


Blindauth wip

This could use an intermittent review @benthecarman
There will certainly need to have a few more methods in the blind auth client, but this structure should be complete as far as creating blind messages and stuff.

Need to check for tokens after subscribing to mutiny+

Made an issue from all the TODOs in here #1079


Fix: UI enhancement on L1.

Closes #883
Description

When switching/connected to L1 (or any other network not being Optimism Mainnet or Optimistic Kovan):

[x]  hide Futures & Leaderboard in nav bar
[x] hide Futures Positions & Futures Markets on Dashboard
[x] hide Futures Markets in "Markets" tab (dashboard) and default to Spot
[x] hide accessible margin (Futures markets) in sUSD modal
[x]  Show a CTA "Switch to L2 to access Perpetual Futures" on the Dashboard (design tbd, contact devDAO PM)

Related issue

#883
Motivation and Context

When refactoring the code, keep in mind that we might add more networks in the future with different conditions, so the code should already take this into account and be flexible in this sense.
How Has This Been Tested?

Screenshots (if appropriate):

Something needs to be done:
-[ ] clear the console error:

Something needs to be done:
-[ ] clear the console error:

i think you would only receive that error if your wallet is not properly connected

Something needs to be done:
-[ ] clear the console error:

i think you would only receive that error if your wallet is not properly connected

Reconnect exactly, IDK if it's my PR change problem.

Thanks! Code is correct however we afterwards decided this needs to be addressed differently. Will keep this for future reference.


Support for cross-origin requests

I cannot find a way to get kue to allow cross-origin requests; I can only inject express middleware after i've required('kue') and it's too late.
kue.app.use('*', function(req, res, next) {
  res.header("Access-Control-Allow-Origin", "*");
  res.header("Access-Control-Allow-Headers", "X-Requested-With");
  next();
 });

Don't work with api method


Shortcut buttons do not work on Android devices after v1.18 and 1.19 (but other key inputs work normally)

Environment

OS: Windows
scrcpy version:  1.19
installation method: Windows release
device model:android all device
Android version: all os

Describe the bug
Shortcut buttons do not work on Android devices after v1.18 and 1.19 (but other key inputs work normally)
Control keys such as CTRL+P do not work at all in Windows. (Check normal operation until version 1.12)
Can you tell me why?
It is a function that must be operated normally for operations such as process movement in lower-level devices with physical buttons.
(ex-CTRL+S)

See the highlights of the change introduced in v1.15: https://github.com/Genymobile/scrcpy/releases/tag/v1.15


Incorrect date md-datepicker localization Thai language

Bug, feature request, or proposal:
md-datepicker Locale 'th' (Thai) is displaying the wrong year.
What is the expected behavior?
Input and datepicker should be in the correct year
What is the current behavior?
Input is displaying year in distant future. DatePicker is set to a different year in the distant future.
What are the steps to reproduce?

set locale to 'th' in @NgModule
create datepicker with today's date

https://plnkr.co/edit/6guQWJyfAUtEgPje9Tcd?p=preview
What is the use-case or motivation for changing an existing behavior?
Bug fix
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Material beta.10
Is there anything else we should know?

It looks like this is actually working as expected.  I am seeing the same thing myself when I load using the th local.  I looked into and found that "Thailand mainly uses the Buddhist calendar which is 543 years ahead of the Gregorian calendar." [source]


Playing an album (local media) using checkbox does not play in correct track order

What version of Music Assistant has the issue?
2022.7.0b7
The problem
Playing an album (local media) using checkbox does not play in correct track order
How to reproduce
To recreate:
From Music Assistant main page, click 'Artists', select an artist, click 'Albums', click album art to check checkbox, click 'Play'
I would expect this to begin the album and play the first track but it doesnt. It appears the track it plays is the first track in the 'Tracks' view on the 'Artist' page (which is ordered by 'Recently added' by default
Relevant log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2022.7.5
What type of installation are you running?
Home Assistant Supervised
On what type of hardware are you running?
Raspberry Pi

You found a workflow that never crossed my mind :-)
Selecting items is more or less meant for doing actions but i guess you can also use it this way.
The button above is linked to whatever "main" details you're viewing, so when watching an Artist, play will play the top tracks of that artist and so on.
I consider your observation not as big but as small improvement/request.
Leave it open here as it is pretty small for me to fix so I can pick it up sometime in between.

Im interested in having as few clicks as possible to start an album and stumbled on this method
Thanks very much for all your work on this great project; I am very impressed!

I've enhanced the UI a bit to make it more clear. This change is available in the 2022.7 release


Configs/templates versioning in timetables repo

Making this issue here since it's more about coordinating g2h upgrades in gtfs-to-html-service, but this could also go in the timetables repo.

[ ] Decide how assets will be updated and what timetables branches g2h sites will use.
[ ] Make necessary changes and branch updates in ansible
[ ] Document in this repo and in timetables repo README

@ekeaton @danielleogden I've proposed a system below for branches in the timetables repo that I think will work well with the gtfs-to-html-service server setup for:

Testing changes to timetable assets and new assets in a non-production environment
Testing g2h tool upgrades without disrupting the existing production or testing environment

It's important to note that the branches in the timetable repo will be maintained by the websites team, so if anything about this setup raises any concerns about usability or maintainability or if you have any questions please let me know! Or any feedback or thoughts you have about how you'd like to maintain assets, I figured it'd be helpful to have something to start with.
The one thing I'm not sure about how well it will work in website's workflow is having to update a production branch from the working branch whenever a change is deemed acceptable, as that could either be tedious if that's a common task or require cherry-picking of commits into production if not all of main is acceptable (you'd of course be more than welcome to organize work into separate working branches if you wanted, but I think it's best to have staging always deploy main outside of rare exceptions, so those could be hard to test). I don't think there's any way around that if we want to maintain a stable assets branch but lmk if you think the effort isn't worth it.
Timetables branches

main

"development/working" branch, unstable (but should not be used for testing changes related to g2h version updates)
Deployed to staging-gtfstohtml

Staging will be where users can test changes to configs and templates almost* immediately (*currently updates assets every 5 minutes or can be manually triggered using this jenkins task)
Staging should always be using the same gtfs-to-html-service branch as production (master), so it can always serve as a reliable testing environment for changes to timetables assets

production

production branch, stable configs/templates only

should be updated from main each time an experimental change is accepted or new config/template is finalized

Deployed to production-gtfstohtml

Experimental version branches (i.e. 2.x or 1.6.4)

created for testing g2h tool version updates, will ultimately be pulled into main and production
When ready for testing with gtfs-to-html-service, these will be deployed to development-gtfstohtml.

Development will host experimental gtfs-to-html-service code (also a versioned branch like 2.x) for testing the g2h upgrade with the new assets.

G2H tool version upgrade process

Websites team opens a github issue in gtfs-to-html-service repo with the version number they want to upgrade to
Websites team creates a new versioned branch in timetables repo and updates the github issue with the branch name when it's ready to test.

The branch might be identical to main but it's important to test on a separate branch so changes can be tested if needed without additional steps.

gtfs-to-html-service developer upgrades g2h in a new versioned branch and deploys to development
Websites team tests on development-gtfstohtml, and lets gtfs-to-html-service developer know if more changes are needed or if everything works ok.
When development gtfs-to-html-service is confirmed to be working with the new assets, the gtfs-to-html-service developer performs an upgrade (these things should all happen at the same time):

gtfs-to-html-service: version branch is pulled into master
timetables: version branch is pulled into main, then main is pulled into production
Staging and production gtfs-to-html-service are upgraded with updated code and assets
Version branches can be removed at this point, or kept for future use or reference if helpful

gtfs-to-html-service developer closes github issue when upgrade is complete

@anniekfifer This makes sense! The only part I'm trying to think through is:

production
production branch, stable configs/templates only
should be updated from main each time an experimental change is accepted or new config/template is finalized

Ultimately I'd like the Timetables repo to be used by the Support team. Since they will be the ones Generating Timetables from GTFSM and this process is for them. So if they are running timetables and realize one line in the config needs to be changed from  showStopCity": false, to "showStopCity": true and do so on the Main branch. (Which makes sense)  I'm trying to think through how they would get those changes onto the Master branch without needing to use the terminal etc. Maybe just then updating the Production branch manually with the same changes? I'll run this by Evan! Because I believe they do update Static Assets at this time for imap changes, I'm just not sure how. But I think its from editing within GH like so

But thank you for outlining all of this out!

Ultimately I'd like the Timetables repo to be used by the Support team.

Thank you for clarifying this!

@anniekfifer I spoke to @evantrillium and he's come up with a solution that should resolve my question above. I believe he'll be reaching out to you soon to go over it.

Awesome, sounds great!
I'll say now that the more I think about it, having a working branch and production branch for assets is probably overkill. If most changes are going to be small config changes, we probably don't need to have a separate branch for testing changes. It'd be more convenient and not super risky to just push changes directly to production, if there are broken or un-finalized configs or templates they're unlikely to be used mistakenly. I think that's how maps assets work too, changes to assets on the main/master branch are immediately deployed to production.

I'm trying to think through how they would get those changes onto the Master branch without needing to use the terminal etc. Maybe just then updating the Production branch manually with the same changes

To answer this question though -- edits on main could be made with that edit tool in github, and then a pull request would be created for pulling main into production in the github UI as well.

@anniekfifer my preference is for a small library of config files for support to choose from, and their export receipts will tell them which to use
so rather than having say, one for each agency, or one for all agencies, we'd have maybe 4-5 different ones with generic names like 'config-a' and 'config-b' and then agencies get slotted into them - we'd work to have those be the available option for future g2h clients and website clients.
how hard is it to add additional configs to the available options?

@anniekfifer my preference is for a small library of config files for support to choose from, and their export receipts will tell them which to use
so rather than having say, one for each agency, or one for all agencies, we'd have maybe 4-5 different ones with generic names like 'config-a' and 'config-b' and then agencies get slotted into them - we'd work to have those be the available option for future g2h clients and website clients.

Definitely, this will be a given no matter what. The question at hand concerns the process for editing and creating new configs and templates and how those changes will be tested.

how hard is it to add additional configs to the available options?

It won't be difficult, all of it can be done in the github UI. The potential tricky step the might be needed is creating a pull request to pull changes into a production branch once the editor is satisfied with the edits -- I'm still mulling this over, but I'm thinking this might not be necessary.
It's less clear though for templates -- templates require more time to create and more testing and tweaking, and it's more likely that people will need to switch between testing an experimental template and running g2h with a stable production template.
For example, say a website is getting a redesign and the appearance of timetables needs to change, so the websites team works on a new template and needs to be able to use gtfs-to-html-service to test it out. While that redesign is in progress, the agency has a schedule update and needs to update timetables with their old template. The goal is that we don't have to manually revert back to an older version of the template to do this.
I'm gonna mull on this a bit more, in the meantime these are the goals I want to keep in mind when it comes to managing assets and deploying them to gtfs-to-html-service servers:

No one should need to have a local install of g2h to either create timetables, or for creating and testing configs and templates
Updating configs should be easy to do on-the-fly
Ideally, people should be able to test changes to assets in a testing gtfs-to-html-service environment without necessarily needing to deploy those changes to production gtfs-to-html-service/GTFSM

@anniekfifer we won't be touching templates - that's far outside the scope of support
for configs, the support team won't be able to do edits to these, whether on staging or prod, with any simplicity. I would prefer to have a menu of available configs defined, with no need to do small tweaks.
I understand that there may be instances where the available menu of configs does not suit the website, and @ekeaton can always run g2h locally with modified configs, but we won't be able to support edits to configs on web-based gh at this time.  This also ensures we don't run into issues where multiple edits are happening simultaneously (unlikely, buit possible) and doesn't require edits be undone after the mods have been used.
My desire is to only have 4-5 total available configs (and ditch default and pvvta) so that a tech, using instructions from their export receipts, can select one of the available configs

@anniekfifer we won't be touching templates - that's far outside the scope of support

For sure, I meant to direct that to @ekeaton

we won't be able to support edits to configs on web-based gh at this time.

That's good to know! @ekeaton lmk if that changes things

@anniekfifer I'm on board with Support not being able to make edits to the configs within the GH UI but instead choosing from a list of 4-5 ready-to-go configs. For my example regarding showStopCity: false, to showStopCity: true as a reason they might need to edit a config before, instead that could just fall under its own config i.e. config-a. And any website that needs that option Support can just use that ready-to-go config no tweaks are needed. Makes sense to me!

It's less clear though for templates -- templates require more time to create and more testing and tweaking, and it's more likely that people will need to switch between testing an experimental template and running g2h with a stable production template.

I will say we never create new templates for new websites. We only use the Trillium template and I've tweaked it beyond the default version to fit 99% of our websites. So we should be good to go there we won't need to update those on the fly or much. The only case will be when Brendan updates g2h with any major changes (generally he also changes up the template files) meaning we will need to test and then update ours accordingly. But I believe you solved this situation by coming up with testing branches!

@ekeaton Thank you so much for your help with this! It sounds like just having the working branch deployed to gtfstohtml is the way to go. We can always beef up the branching process later if its needed for testing.
Thanks for being patient with the back-and-forth, let me know if this sounds alright!
Timetables branches

main

main working branch
Deployed to staging-gtfstohtml and gtfstohtml

Users can test changes to configs and templates on either site almost* immediately (*currently updates assets every 5 minutes or can be manually triggered to update production gtfstohtml using this jenkins task)

Experimental version branches (i.e. 2.x or 1.6.4)

created for testing g2h tool version updates, will ultimately be pulled into main once it has been tested with the proper g2h version

G2H tool version upgrade process

Websites team creates a new versioned branch for assets in timetables repo

The branch might be identical to main but it's ideal to test on a separate branch so any needed changes can be tested without additional steps.

Websites notifies gtfs-to-html-service developer of the branch name and desired g2h version to test with
gtfs-to-html-service developer upgrades g2h in a new versioned branch and deploys to staging with versioned timetables branch
Websites team tests on staging-gtfstohtml, and lets gtfs-to-html-service developer know if any changes are needed in the application or if everything works ok.
When staging gtfs-to-html-service is confirmed to be working with the new assets, the gtfs-to-html-service developer performs an upgrade (these things should all happen at the same time):

gtfs-to-html-service: version branch is pulled into master
timetables: version branch is pulled into main
Production gtfs-to-html-service is upgraded with updated code and assets
Version branches can be removed at this point, or kept for future use or reference if helpful

@anniekfifer This all sounds good to me! 😁
I think the only step we have left (unrelated to the processes you mentioned above) is the configs that @evantrillium would like his team to use. I know he has it on his docket to work on them so after that, we should be able to start using this wonderful new addition for our timetable process oh so soon. Thank you, thank you for all of your hard work!!

Thanks @ekeaton ! I've added the info above to the timetables README.


Tabs ??

hello a great job, I'm already integrating it into a project :),
Is tab on roadmap?

Yes, hopefully by 1.1.0. And thank you.


Cannot launch more than one account at a time.

I used to be able to launch a few accounts at a time, which is very convenient and saves time. Since a few days ago though, whenever I try to do that it'll only launch the first acc I selected, while for every other I get the message "Client X got closed or crashed before a clean Start. Do you want to retry to start this Client?".
Selecting yes only results in the same message.
Whelp!

I now, unexpectedly, am starting to see the same behavior.  When it happens, I can reboot my system and LaunchBuddy will work fine again and if I keep LaunchBuddy up and running I can use it properly.  However, once I close the app and restart it, the issue returns, and a reboot fixes it.
Sounds like a file lock issue.


chore(deploy): update k8s deployment config files

Revert tags of mayastor pod images to :latest as part of the post-release GitFlow process

Closing request - will commit required changes from a new working branch to avoid having to --force push an amended commit message.

Closing request - will commit required changes from a new working branch to avoid having to --force push an amended commit message.


[SPARK-40040][SQL] Push local limit to both sides if join condition is empty

What changes were proposed in this pull request?
This PR enhances LimitPushDown to support  push local limit to both sides if it is outer join and join condition is empty.
For example:

Why are the changes needed?
Improve query performance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.

cc @cloud-fan

cc @sigmod

The idea is very simple. We should explain the rationale for this optimization in the PR description, instead of giving a screenshot which doesn't provide much value to understand this optimization.

cc @sigmod

Merged to master.


High CPU consumption after last update

Hi,
the latest update is causing a constant increase in CPU usage, even long after it was activated.
It is not due to other plugins. Even when I disable all settings within the make.md settings, the CPU usage remains consistently high.
Has anyone else the same problem after the last update?

Thanks, I'm prioritizing these performance issues. How many notes do you have?

I have a good idea of where the issue is coming from, but some debug information would be helpful, for example, are you using smart/live search and formula properties?

There's a fix in the next version that should address the CPU issue

Let me know if this is resolved in the newest version


Windows path issue in $saber.getPageLink

Bug report
https://github.com/saberland/saber/blob/ac3f80d415071186e92ffa3266ff78444500b85c/packages/saber/vue-renderer/app/create-app.js#L128-L138
In line 137 route.meta.__relative is a path separated by slash /, but relativePath is separated by backslash \ on Windows (since we're using path.join in line 128.
Other relevant information

Result of running saber -v: saber/0.9.0 darwin-x64 node-v10.16.2

It would be great if we can just get rid of using path in the fix.

I will just say that relativePath.replace(/\\/g, '/') fix the problem


bluetooth mesh proxy filter

in proxy.c bool bt_mesh_proxy_relay(struct net_buf_simple *buf, u16_t dst)
if (!client_filter_match(client, dst)),   it should be client_filter_match(client, src address)?

no problem


Remove unnecessary logos in Wordpress

As we now have the source for our logos in the landscape we should clean up the Wordpress CAMARA instance to avoid failure

All unused pictures and logos removed from Wordpress


License?

Thanks for taking the time to build this! Any chance I could convince you to add a license to make consumptions/contributions easier? The GitHub documentation talks a lot about selecting a license and some of the ramifications of a project not having one.

Doh! Thank you for the reminder, can't believe I forgot this. I've added an MIT licence, so I'll close this now. Thanks!


Error in setup.py

Hi,
when I try to run the installation via python setup.py install I got this:
Traceback (most recent call last):
File "setup.py", line 51, in
os_arch = "mac_x%d"%(arch)
TypeError: %d format: a number is required, not str
It works if I change the string with:
os_arch = "mac_x64"
I have a macOS Catalina 10.15.4.

Thanks for your report.
I will revise the setup.py script.


feature tests for arg separator

most of these tests are failing.
it looks like the feature isn't fully implemented

feature to be implemented as discussed at https://github.com/bilal-fazlani/commanddotnet/issues/123


Obtaining SENet model

Sir, would you please to upload your SENet model to the Baidu Cloud cause we  can not download them from the GoogleDrive. Thank you very much in advance.

We upload all the models to Baidu Yun driver. You can download them without any restrictions.


Concurrency issues with condor_vault_storer

The utility that the vaultToken package uses, condor_vault_storer doesn't expect concurrent uses on the same client side for the same vault token.  This is causing problems in the v0.9 series with the concurrent calls for the experimentOverriddenServices like dune and dune-global-pool.  We need to have some sort of check on the worker side or even the executable side where we don't try to concurrently run these two.
I've worked around it temporarily in production by splitting out the config.

Okay - this is fixed now.  I've done the following:

VaultTokenStoreHoldoff worker.Config.Extras key and accompanying Set/Get funcs to worker package
token-push now checks to see if aservice.Service it wants to make a worker.Config for is a cmdUtils.ExperimentOverriddenService.  If it is, it sets the key in (1) when calling worker.NewConfig
worker.StoreAndGetTokenWorker now supports the holdoff mechanism.  If a goroutine for a worker.Config the worker wants to store tokens for has (1) set to true, it will block until all the Configs that don't have (1) set are finished.  Then each one of these deferred goroutines will try to acquire a shared sync.Mutex, store the token, and release the mutex.  This way they run serially in effect, even though they're launched concurrently.

This scope of change is enough that the next release should be 0.10 or 1.0 - probably the former.


Password input field in multiplayer is on top of text

Describe the bug
After inputting a wrong password in multiplayer login input field is being placed on top of text
To Reproduce
Steps to reproduce the behavior:

Press 'Multiplayer' text-button in main menu
Accept profile
Press 'Login' in bottom
Enter anything, but the password, in the text field and accept
Enter anything but don't accept
See the problem

Expected behavior
I think the wrong-password-text should be under the input field
Screenshots

Desktop (please complete the following information):

OS: Windows 10 x64 LTSB 1607
Version: 0.65.1

Additional context
There's a already a big bunch of commits in the 'develop' branch so it may already be fixed
Putting it here as I couldn't find an issue for that problem

I dont think this Is currently fixed. A hacky fix might be as simple as moving it after the "enter password" and adding a couple newlines inbetween

fixed<PHONE_NUMBER>d602d796b37e78088f6f39bb00a28e


Prepare error handler component

This PR is an improvement for our error handler. Most of the time we should handle errors properly, but in some cases like Network errors or any unexpected error we should notify users and handle them properly instead of displaying an empty page.
Testing Instructions:

Start the app without running API service and observe

I feel like the message "Network Error" just because it can't reach the API server might cause a little confusion. Could be nothing to do with Network and just the server is down. Should be make it more clear that the issue is reaching the API server?

Thanks, @zenweasel, I will update the error message.