docs for interfacing with extension?

The "non-react" examples here all bundle react, and ultimately the codebase here adds a lot to a non-react project!
I realize it might be a bit too much to ask for a more framework-agnostic refactor, but is there documentation somewhere to show how to do only the extension-interface flow?
I'd imagine that it doesn't use its own UI, just that of the extension, and should be able to do more cleanly?
(as an aside - I couldn't get the provider to build in rollup at all)

@dakom Since the goal of the sample is to explain the behavior of WalletController, I just used react-scripts without creating a separate lightweight webpack setting.
Since the primary goal of this project is to provide multiple interfaces (Extension, Walletconnect...) as a common simple interface, no separate interface is provided for Extension alone.
However, if you want, you can compose @terra-dev/chrome-extension and @terra-dev/use-wallet to create a new React Context that can be used instead of <WalletProvider>. (or you can only use @terra-dev/chrome-extension if you don't use React)
I want to provide documents for these sub-packages, but I haven't been able to provide them yet because other projects are underway together. I think this can be provided in the future.
This project is not using rollup. If you want to understand how it is built, run yarn workspace packages run build and you'll see that the ~/packages/out/packages directory is created. Please refer to these links.

https://www.npmjs.com/package/rocket-punch
https://github.com/terra-money/wallet-provider/blob/main/packages/.packages.json

Closing this issue for now... I was able to just work around this by putting the wallet provider in a separate iframe 😅


cdc: fix unstable old value test

Signed-off-by: 5kbpers<EMAIL_ADDRESS>
What problem does this PR solve?
Problem Summary:
Fix unstable test.
What is changed and how it works?
What's Changed:
Get ts from pd client instead of hardcode ts.
Related changes

Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test

Release note

N/A

/lgtm

/merge

/merge


i18n

react-i18next is good for this

Going to close this one in favor of a tutorial. Makes too many assumptions about your project and it adds enough overhead that could make development cumbersome if you don't need it.


python312Packages.testcontainers: 4.8.2 -> 4.9.0

Things done
Changelog: https://github.com/testcontainers/testcontainers-python/releases/tag/testcontainers-v4.9.0
cc @onny

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 363989

x86_64-linux

:fast_forward: 8 packages marked as broken and skipped:

python311Packages.apache-beam
python311Packages.apache-beam.dist
python311Packages.dm-sonnet
python311Packages.dm-sonnet.dist
python311Packages.tensorflow-datasets
python311Packages.tensorflow-datasets.dist
python312Packages.apache-beam
python312Packages.apache-beam.dist

:x: 4 packages failed to build:

python311Packages.aio-pika
python311Packages.aio-pika.dist
python312Packages.aio-pika
python312Packages.aio-pika.dist

:white_check_mark: 4 packages built:

python311Packages.testcontainers
python311Packages.testcontainers.dist
python312Packages.testcontainers
python312Packages.testcontainers.dist

aarch64-linux

:fast_forward: 4 packages marked as broken and skipped:

python311Packages.apache-beam
python311Packages.apache-beam.dist
python312Packages.apache-beam
python312Packages.apache-beam.dist

:x: 4 packages failed to build:

python311Packages.aio-pika
python311Packages.aio-pika.dist
python312Packages.aio-pika
python312Packages.aio-pika.dist

:white_check_mark: 4 packages built:

python311Packages.testcontainers
python311Packages.testcontainers.dist
python312Packages.testcontainers
python312Packages.testcontainers.dist

x86_64-darwin

:fast_forward: 4 packages marked as broken and skipped:

python311Packages.apache-beam
python311Packages.apache-beam.dist
python312Packages.apache-beam
python312Packages.apache-beam.dist

:x: 4 packages failed to build:

python311Packages.aio-pika
python311Packages.aio-pika.dist
python312Packages.aio-pika
python312Packages.aio-pika.dist

:white_check_mark: 4 packages built:

python311Packages.testcontainers
python311Packages.testcontainers.dist
python312Packages.testcontainers
python312Packages.testcontainers.dist

aarch64-darwin

:fast_forward: 4 packages marked as broken and skipped:

python311Packages.apache-beam
python311Packages.apache-beam.dist
python312Packages.apache-beam
python312Packages.apache-beam.dist

:x: 4 packages failed to build:

python311Packages.aio-pika
python311Packages.aio-pika.dist
python312Packages.aio-pika
python312Packages.aio-pika.dist

:white_check_mark: 4 packages built:

python311Packages.testcontainers
python311Packages.testcontainers.dist
python312Packages.testcontainers
python312Packages.testcontainers.dist

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 363989

x86_64-linux

:fast_forward: 8 packages marked as broken and skipped:

python311Packages.apache-beam
python311Packages.apache-beam.dist
python311Packages.dm-sonnet
python311Packages.dm-sonnet.dist
python311Packages.tensorflow-datasets
python311Packages.tensorflow-datasets.dist
python312Packages.apache-beam
python312Packages.apache-beam.dist

:white_check_mark: 8 packages built:

python311Packages.aio-pika
python311Packages.aio-pika.dist
python311Packages.testcontainers
python311Packages.testcontainers.dist
python312Packages.aio-pika
python312Packages.aio-pika.dist
python312Packages.testcontainers
python312Packages.testcontainers.dist

aarch64-linux

:fast_forward: 4 packages marked as broken and skipped:

python311Packages.apache-beam
python311Packages.apache-beam.dist
python312Packages.apache-beam
python312Packages.apache-beam.dist

:white_check_mark: 8 packages built:

python311Packages.aio-pika
python311Packages.aio-pika.dist
python311Packages.testcontainers
python311Packages.testcontainers.dist
python312Packages.aio-pika
python312Packages.aio-pika.dist
python312Packages.testcontainers
python312Packages.testcontainers.dist

x86_64-darwin

:fast_forward: 4 packages marked as broken and skipped:

python311Packages.apache-beam
python311Packages.apache-beam.dist
python312Packages.apache-beam
python312Packages.apache-beam.dist

:white_check_mark: 8 packages built:

python311Packages.aio-pika
python311Packages.aio-pika.dist
python311Packages.testcontainers
python311Packages.testcontainers.dist
python312Packages.aio-pika
python312Packages.aio-pika.dist
python312Packages.testcontainers
python312Packages.testcontainers.dist

aarch64-darwin

:fast_forward: 4 packages marked as broken and skipped:

python311Packages.apache-beam
python311Packages.apache-beam.dist
python312Packages.apache-beam
python312Packages.apache-beam.dist

:white_check_mark: 8 packages built:

python311Packages.aio-pika
python311Packages.aio-pika.dist
python311Packages.testcontainers
python311Packages.testcontainers.dist
python312Packages.aio-pika
python312Packages.aio-pika.dist
python312Packages.testcontainers
python312Packages.testcontainers.dist


allow namespace filter to use a namespace selector

Problem description
in a cluster where namespaces are frequently created and destroyed (for example because tenants are onboarded and removed) listing the included/excluded namespaces as an array makes it necessary to frequently patch the Policy object
Describe the solution you'd like
a namespace selector (based on label) can be specified in alternative to the include/exclude list. This is the standard that is followed by many other operators.
Describe alternatives you've considered
none
What version of descheduler are you using?
latest
Additional context

yet, good idea~~
would you like to have a try on this feature ? @raffaelespazzoli

I also like the flexibility it brings but should we do this work as part of descheduler/v1alpha2 initiative? Given the breaking changes.
cc: @ingvagabund  @damemi

Would it be a breaking change to make the namespace include/exclude fields a regex? Current settings with alphanumeric namespace strings would still only match the exact name, so the functionality is the same. As long as no regex special characters are allowed in k8s namespace names.
I am not sure about taking a labelling approach as it decouples descheduler config from the descheduler itself, which I could see causing headaches

In my organization, we're discussing use-cases around skipping a namespace via a label. Currently, we have to re-deploy Descheduler to exclude a namespace. [Alternatively, we can label each Deployment as well]
It would be ideal for us to label a namespace and have it be ignored by Descheduler.
example:
kind: Namespace
apiVersion: v1
metadata:
  name: example
  labels:
    descheduler.k8s.io/opt-out: "true"

Where my Descheduler configuration would define a namespaceSelector at a plugin definition:
 namespaceSelector:
   matchExpressions:
   - key: descheduler.k8s.io/opt-out
     operator: In
     values: ["true"]

cc: @jklaw90

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle rotten

/remove-lifecycle rotten


fix: add missing schemas

Explanation
Add missing schemas.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5258ca3) 79.61% compared to head (529a98c) 79.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #843   +/-   ##
=======================================
  Coverage   79.61%   79.61%
=======================================
  Files         106      106
  Lines        3272     3272
=======================================
  Hits         2605     2605
  Misses        516      516
  Partials      151      151

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New Feature - Use KQL to Search in KQLSearch

Hi,
I have to say that it would really be awesome to be able to write KQL query instead of drop downs in the Advanced Filter.

Hi @Groumy,
can you elaborate on this?
Do you want to copy past the query in the search field?

Currently, when you use the advanced search feature in kqlsearch, you got a bunch of dropdown that shows up to let you pick things like Table, Author, Keyword and Operator.
All that are probably fields in a BD somewhere, it would be fun to be able to write a kql query instead. Something like that :
kqlsearch
| where Table in ('SomeTable', 'OtherTable)
| where Operator != '--'
| order by Author desc

Got it. Let me see how and if I can implement it.


Getting Started

Venturing into picking an animation library.
Honestly have come down to choosing between Mo.js or Velocity.
Mainly will be doing UI animations but also have need for a few animations that mojs seems perfect for.
The one thing that's keeping me back from picking mo.js is the lack of a getting started documentation any news on when this will be up? I think I may have read somewhere that you had a few drafts that needed proofreading, why not push the drafts to the repo and then commit for the proofread version? Just an idea. That way those of us interested can read through them even if they are not completely ready.
Love the style mo.js bring though, very well presented!

Hi @FrancosLab ! Thanks for the issue!
That's a great question. That version of getting started is deprecated - the proofreading was delayed and a lot of new modules and tools added, but most importantly, a library has changed a lot so that API's don't work anymore. Thus it will add much more harm than knowledge and will mess up things a lot. I know how frustrating it can be to start with some library without a decent guide! I will try to spend more time on that and maybe even create screencasts on the topic.
Meanwhile, you can start with the docs -  there are some basic codepen examples that might help, also you can checkout some of the tutorials on the mojs.io website. And if you have any questions, please don't hesitate to ask me, I always happy to help!
Sorry and thanks! Cheers

I'm not sure if it will help or not, but I'm writing an intro article for CSS-Tricks right now. Though truthfully, it's mostly based off of what I've learned in the tutorials section of the site (which is quite excellent) along with some tips from @legomushroom. I hope to have it out in the next couple of weeks.

@legomushroom If you need help proofreading anything I would be happy to contribute some time to help. Also, I just get your letter in the mail, and it was much appreciated!

@sdras awesome!

@zfrisch thanks a lot!

No need to apologize. Decided to go with mo.js after all! Took a read through the 2 modules, loving the declarative api. Look forward to contributing as well!

@FrancosLab yay!

I needed, would like to help with updating the docs :). Still have to get to know mojs better but when helping maybe this wil also help me.

@RobbertWolfs sure! Anything helps!


Added :class:~.PolarPlane, a subclass of :class:~.NumberPlane for polar coordinates.

Motivation
To create a version of NumberPlane for polar coordinates with a set of useful (and not so useful) default unit labels.
Explanation for Changes
Adds a subclass of NumberPlane for polar coordinates. Four default sets of azimuth labels are provided (number of ticks customizable using azimuth_line_frequency, though convenient defaults are provided):

"PI radians": Fractional labels in the interval [0, 2π] with π as a constant.
"TAU radians": Fractional labels in the interval [0, τ] with τ as a constant.
"degrees": Decimal labels in the interval [0, 360] with a degree symbol.
"gradians": Decimal labels in the interval [0, 400] with a superscript "g".

Examples

Testing Status
Have generated planes with each set of default azimuth_units, as can be seen above.
Further Comments
Will look at adding a special transformation animation between a NumberPlane and PolarPlane in future (a naive implementation with apply_function looks "weird", see #1264).
Checklist

[x] I have read the Contributing Guidelines
[x] I have written a descriptive PR title (see top of PR template for examples)
[x] I have written a changelog entry for the PR or deem it unnecessary
[x] My new functions/classes either have a docstring or are private
[x] My new functions/classes have tests added and (optional) examples in the docs
[x] My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

[x] The PR title is descriptive enough
[x] The PR is labeled correctly
[ ] The changelog entry is completed if necessary
[ ] Newly added functions/classes either have a docstring or are private
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

That's no problem. Regarding the issue of inheritance, this was discussed in the relevant issue #1264 and @MrMallIronmaker suggested it should inherit from NumberPlane. Personally I can see advantages and disadvantages for both, so I'd like to get a consensus before making changes regarding that, so someone else doesn't ask me to change it back.
(P.S. is it possible for you to link #1264 to this PR? I forgot to do it when creating it and I can't seem to do it now. Thanks!)

Regarding the issue of inheritance

Sure, we should agree on the way forward. To make my argument a bit more explicit: I think that NumberPlane refers to a two-dimensional cartesian coordinate system, while CoordinateSystem refers to a general one. For me, the polar plane is a specialized coordinate system, but not a specialized cartesian 2D one. Also, you don't really seem to use any NumberPlane specific features, or do you?

To add to this discussion of general inheritance/design decision (I haven't looked at the code for PolarPlane btw), I think PolarPlane/PolarCoordinateSystem/etc. and what is currently NumberPlane (which should probably be renamed/deprecated/or an alias of CartesianPlane/CartesianCoordinateSystem/etc.) should inherit from EuclideanPlane/EuclideanCoordinateSystem/etc. as that's axiomatically how I see them inheriting from the more general "Plane". Perhaps CoordinateSystem should be the general "Plane"?

The class is currently constructed by creating a NumberPlane with super() (much like in ComplexPlane) and then applying a function to it to turn cartesian coordinates into polar. Of course it would be possible to write the functions in NumberPlane to create a radial grid instead of a square one, it would just take more lines of code. But, on the other hand, I think it would require less computation and would probably be more extensible in future I imagine.

I think it would require less computation and would probably be more extensible in future I imagine.

I think this is worth discussion and if should likely be brought up in the Manim Architecture Town Hall meeting coming up. There's a couple of other impactful design decisions that I believe should be altered as well where the inheritance doesn't really match up with what is mathematically expected (e.g. Circle inheriting from Ellipse -- where mathematically it makes more sense that Circle IS-A special type of Ellipse).
I'm ultimately in favor of what makes Manim more extensible/intuitive; but seeing as this is a really useful feature, I can be onboard with this integrating this and then later handling inheritance/redesign.

(e.g. Ellipse inheriting from Circle -- where mathematically it makes more sense that Circle IS-A special type of Ellipse)

Apparently that specific example is a well known problem in software development: Circle–ellipse problem

The way variables are set using x_min, x_max and x_line_frequency doesn't follow the precedent set by #1161. Would it be possible to switch to using x_range and y_range as is the case for the other classes in CoordinateSystem for that PR?

From one of the examples in the doctest (after the changes in #1430):

The coordinates along the azimuth are a little bit unusual since they're created based on the range of the Plane (which is very small in these cases). If there isn't an easy way to correct them, maybe it would be worthwhile to simply remove the coordinates along the azimuth?

The coordinates along the azimuth are a little bit unusual since they're created based on the range of the Plane (which is very small in these cases). If there isn't an easy way to correct them, maybe it would be worthwhile to simply remove the coordinates along the azimuth?

For the sake of getting this merged for 0.6.0, I think it's probably the best option. I'm leaning towards a complete rewrite where things are built from scratch, rather than relying on NumberPlane. There's been some suggestions regarding this already. We can consider this a temporary solution.

I was doing some light testing and noticed that if the radius_max is just above a whole number, then it looks like a circle:
class A(Scene):
    def construct(self):
        polarplot_pi = PolarPlane(azimuth_units="PI radians", radius_max=3 + 1e-8).add_coordinates()
        self.add(polarplot_pi)

Would we want to update the documentation to use this construction as opposed to scaling from a full size plane?

Have you changed something else? I don't get the same result.

Have you changed something else? I don't get the same result.

#1430 has been merged so updating the branch should yield that plane.

I wouldn't worry about the documentation too much, it will likely not work that way with v2.

Could you submit an empty commit to restart the checking process? The macOS test randomly failed 🤔

Looks like we missed 0.6.0. That's fine, I've started work on v2 already. It's on a new branch, so should I close this PR and start a new one?

Looks like we missed 0.6.0. That's fine, I've started work on v2 already. It's on a new branch, so should I close this PR and start a new one?

Sorry - yes please. (The release was already a bit delayed due to other bugs that needed to be fixed first; I felt more comfortable with not merging this PR for the release (especially if there were plans to rework some of it anyways).
If you already have a separate branch, then the easiest approach is to open a new PR, yes. Thank you for your efforts!


set default location for pipeline produced blazegraph version of go-lego

The shex validation system, as implemented in minerva, requires a blazegraph journal containing go-lego (which contains the gene entities from neo). This will eventually be a stable pipeline product at a stable location. When that is done geneontology/pipeline#35 (comment) , we can update the default location (currently stuck in code for BlazegraphOntologyManager but could come out into a config file).   Close this ticket when the pipeline stabilizes on a location for this file.  (Current default is http://skyhook.berkeleybop.org/blazegraph-go-lego.jnl.gz )

@kltm keep an eye on this one regarding pipeline changes...


Port: Added PUBLIC_PORT to fix redirects when running on a port != 80.

Hi mplx,
Thanks a lot for your project it helps to dockerize webvirtcloud.
When using it on ports != 80, I've found that redirects (e.g. to login page) don't work as webvirtcloud thinks it runs on port 80 (due to the proxy headers forwarded by nginx).
One solution would have been to modify the proxy headers to tell webvirtcloud what the outside port is. However I found it more straight forward to change the nginx port config.
Hope you find this useful.
Best regards, Juergen

Hi Jürgen,
thank you very much for your contribution! The proposed change seems useful so I'd happy to merge it. :)
Can you please do a rebase to the current master as I've added some tiny CLA feature to get the legal stuff right and keep everybody secure. Just append your name/nick and author email address to the contributors file and include it in your PR. Thanks for your understanding ;)
Best regards, Martin

Hi Martin,
My apologies for the delay.
Rebase and CONTRIBUTOR entry are added, let me know if you need anything else.
Thanks again for the nice little project.
Einen guten Rutsch!
Cheers Jürgen


[stable/airflow] Airflow on minikube Postgre connection refused

Describe the bug
After  the helm chart deployment on minikube, airflow webserver, scheduler and worker are in error status
airflow-scheduler-64d896449d-zhrvv   1/2     CrashLoopBackOff   9          25m airflow-web-55545c66cb-xmhxm         1/2     CrashLoopBackOff   9          25m airflow-worker-0                     1/2     CrashLoopBackOff   9          25m
Version of Helm and Kubernetes:
Helm version : Version:"v3.2.4", GitCommit:"0ad800ef43d3b826f31a5ad8dfbb4fe05d143688", GitTreeState:"dirty", GoVersion:"go1.14.3"
Kubernetes version : Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.5", GitCommit:"20c265fef0741dd71a66480e35bd69f18351daea", GitTreeState:"clean", BuildDate:"2019-10-15T19:16:51Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean", BuildDate:"2020-03-25T14:50:46Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
Minikube version : v1.9.2
Which chart:
stable/airflow
What happened:
Worker, scheduler and webserver are in error state.
In webserver logs : [2020-07-15 13:42:10,682] {cli_action_loggers.py:107} WARNING - Failed to log action with (psycopg2.OperationalError) could not connect to server: Connection refuse
What you expected to happen:
Pods in status running and to be able to access the web UI
How to reproduce it (as minimally and precisely as possible):
From the helm repo in charts/stable/airflow
helm install airflow stable/airflow --version "v7.2.0" --namespace "airflow" --values ./examples/minikube/custom-values.yaml

Nothing here ?


Convert sslapitest to test framework

Whew :)

rebased, pushed, ready for re-review.

710756a on master, thanks!

Red cross from travis was relevant. --strict-warnings complains about "ISO C forbids conversion of function pointer to object pointer type".

well, i guess i'll go look for that error in master now.


[Feature Request] Autoretainer x Deliveroo - option to use "/li auto" instead of it forcing FC teleport

I would greatly appreciate an option to use "/li auto" so we can control where our character goes after it is done handing in seals instead of being forced to go to the FC house. For example, i would much prefer going to an inn.
I believe an optional check box that toggles "/li auto" for the TP home step in post processing could facilitate this.
The "/li auto" itself is configured inside of lifestream and the onus would be on the end user by enabling said option.

I have made a PR.
I am testing it now and there seems to be no problem.

Added already, forgot about this issue


[BUG] bloxstrap menu

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
i dont have bloxstrap menu but only the "Play Roblox" shortcut. how do i get the menu?

Did you read the preliminary instructions?
https://github.com/pizzaboxer/bloxstrap/wiki/Opening-the-Bloxstrap-menu
You also would have been told about this when you first installed.


Use BuildKit features in Dockerfile

cache apt packages;
cache opam packages;
use COPY --link for faster copy;
sort package lists.

https://docs.docker.com/reference/dockerfile/#example-cache-apt-packages
https://docs.docker.com/reference/dockerfile/#benefits-of-using---link
https://docs.docker.com/build/building/best-practices/#sort-multi-line-arguments
Currently based on #985.

https://github.com/ocurrent/ocurrent-deployer/pull/243 enables Buildkit


⚠ Bofrost.lu has degraded performance

In e534c5d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1157 ms

Resolved: Bofrost.lu performance has improved in 1df08c3 after 6 minutes.


Solving linear equations using matlab

Article checklist
Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #3298

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

@ahmadmardeni1 requesting for a test review

Plagiarism check done.

@EspiraMarvin changes made.

@ahmadmardeni1 Please add the tech review label.

@ahmadmardeni1 from the article standpoint, it's good to go. But it seems like the content must be migrated to the new directory structure. After he's done migrating, I will add the front matter as a comment.

@jumapaul  can you please update your branch to the updated directory structure?
Pull the main branch into your branch.
Move your article folder from articles/ to content/articles.
Move your author folder from author/ to content/author.
Commit and Push to your branch.
If you need further assistance, please ping me via slack.

@ahmadmardeni1 This article is ready for final review. But it seems like the content must be migrated to the new directory structure. I have informed @jumapaul he will do it when it's ready to be merged.
Below is the format of the front matter.

layout: engineering-education
status: publish
published: true
url: /solving-linear-equations-using-matlab/
title: Solving Linear Equations Using Matlab
description: This article will look at how to solve linear algebra equations using Matlab. We will also look at the setup of these equations and the different types of equations.
author: paul-juma
date: 2021-08-11T00:00:00-02:25
topics: []
excerpt_separator:
images:

url: /engineering-education/solving-linear-equations-using-matlab/hero.jpg
alt: Solving Linear Equations on Matlab Hero Image

Equations in the form Ax=b in mathematics are linear algebra equations. In such equations, A is a matrix while x and b are column vectors. A matrix is a two-dimensional arrangement of numbers. Such equations are common in engineering and scientific disciplines.

Thus, understanding the setup of these equations and finding solutions to the problems is an essential skill.

Peer Review Contributions by: Espira Marvin

Hey @EspiraMarvin. The author should open a new PR, and put his files in the right structure.
I'm going to close this PR. Please @ me when he opens a new PR and I will do the final review.
cc @jumapaul


Do not reuse tag names (misra 5.7)

Do not reuse tag name following zephyr coding guidelines (misra 5.7)
this is just the first pass.
- fdtable: fdtable: do not use tag name fd_entry

logging : do not reuse tag name log_output
doc: device: follow coding guidelines
drivers: device: do not reuse tag name 'device'

Do we have a tool to prevent this issue from being (re-)added later on?

we do, but this will take some time to integrate.

Are we 100% sure we're reading that rule correctly? ANSI put the struct tag into a separate namespace from symbols way back in the 80's precisely to prevent collisions like this and permit code like exactly the stuff this patch is changing. Why would MISRA care?

I think the interpretation  is correct, the rule says that a tag name has to be a unique identifier. According with the C standard an identifier can be an object, a function, a tag, a member of a struct, union, typedef name, ....
My understanding is that the main problem that the rule address is the re-use of a tag for different types, but probably based on observation or some kind of statistical analysis they identified that reusing a tag name lead developers to make mistakes and recommended to not do this.


Determine future usage/inclusion of is_accepted flag

On Mar 18, 2021, at 12:09 PM, Laurent, Louise wrote:
Hi Amanda,
Responses tracked in in blue below: [ed: now bold for github]
From: Birmingham, Amanda
Sent: Thursday, March 18, 2021 11:46 AM
Subject: Re: Indel flag and Pangolin calls
Hi, Folks,
Thanks for the detailed requirements.  I have a couple of follow-up questions on the specifics:
a) Re “only samples with coverage >=70% go onto the step #2”: the CCBB pipeline currently produces for each sample a True/False “is_accepted” value indicating whether the sample passed acceptance checking.  Currently, samples only receive a True if they pass a coverage>=95% criterion (among others, such as % of relevant non-ACGT bases).  Should we:
1) Change the acceptance checking done by the CCBB pipeline so that, to receive an “is_accepted” value of True, samples must have >=70% coverage (instead of >=95% coverage)?
2)  Do not change the acceptance checking calculation, but simply do not use its “is_accepted” output when deciding which samples to send to bjorn; instead, base that decision directly on a sample having coverage_gte_10_reads >=70%
3) Remove the “is_accepted” value from the pipeline output altogether (and, of course, use coverage_gte_10_reads >=70% in deciding what to samples to send to bjorn)
I don't have a strong feeling about this. The one thought I had is that the term "acceptance" implies to me an overall acceptance, and that is not what this field represents -- it is only a preliminary filter to remove the low quality sequences so that the multiple sequence alignment function in Bjorn does not choke. In future, if/when we transition to pairwise alignment in the Bjorn module, we may remove this filter altogether and do what we discussed yesterday (calculate everything on all samples, and then use a decision tree at the end to triage to pass/fail/manual review).
[snip]

Stakeholder: need a decision here


fix "any" typings

look into implementing typing for graphql queries. Currently, we are getting back lots of "any" types which can cause issues with development, and specifying types is a better practice
https://github.com/prisma-labs/graphql-request#get-typed-graphql-queries-with-graphql-code-generator

duplicate


Delay behavior

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
#11

Need help for fixing Scrutinizer config

Need help for fixing Scrutinizer config

Docker support must be enabled to get use the same image for Scrutinizer https://scrutinizer-ci.com/docs/guides/docker

Need help for fixing Scrutinizer config

I think that somehow the config should look like this in this case, but you need to look at the output
checks:
  php: true

filter:
  paths:
    - src/

build:
  image: default-bionic

  nodes:
    analysis:
      tests:
        override:
          - php-scrutinizer-run

    phpunit:
      environment:
        docker: true
      dependencies:
        override:
          - docker compose build && docker compose run --rm php82 vendor/bin/phpunit

      tests:
        override:
          - command: docker compose run --rm php82 vendor/bin/phpunit --coverage-clover coverage.xml
            on_node: 1
            coverage:
              file: coverage.xml
              format: php-clover

https://github.com/yiisoft/yii-queue/pull/152


yl2x is a DigitalMars-specific builtin

Fix linker errors building with gdc, much more to come... :-)

The y2lx instruction is x86 specific, not Digital Mars specific.

Is INLINE_YL2X set in the DMD compiler?  That would be one compromise if it did.

Is  INLINE_YL2X  set in the DMD compiler?

No. Just provide a yl2x function in the GDC port.

No. Just provide a yl2x function in the GDC port.

I'd rather not.  There is no way to map it to any architecture (even x86) on my side.

Why wouldn't inline assembler work?

It goes against convention - and will be a red flag for any reviewers in upstream GCC.
It's difficult enough fixing the front-end so it doesn't care about what target it is generating code for, let alone what host we will be running on.

This change means that ddmd built with gdc won't be able to evaluate the yl2x intrinsics at compile time, while dmd built with gcc can?  Does gcc/gdc really not provide this builtin in some way?

Sorry, hit wrong button.

Sorry, hit wrong button.

You're lucky I'll be absent next week, or you will have something to be sorry about... :-)

This change means that ddmd built with gdc won't be able to evaluate the yl2x intrinsics at compile time, while dmd built with gcc can? Does gcc/gdc really not provide this builtin in some way?

There's log2l, but it will produce wildly different results from fy2lx - that is to say, dmd's fy2lx will give incorrectly rounded results vs. log2l.

You're lucky I'll be absent next week, or you will have something to be sorry about... :-)

You're not coming this year?

There's log2l, but it will produce wildly different results from fy2lx - that is to say, dmd's fy2lx will give incorrectly rounded results vs. log2l.

Hmm ok.  Do we have a ctfeable implementation in core.math?  If so, can we just completely remove ctfe builtin support?  It seems like much too obscure a thing to have compiler code dedicated to it.
I don't want a compiler built by dmd and a compiler built by gdc to have different capabilities, I'm sure you can agree.

Do we have a ctfeable implementation in core.math?

No.

It seems like much too obscure a thing to have compiler code dedicated to it

This is what I said in the original PR for CTFE-yl2x!  You still merged it in despite my warnings.

I don't want a compiler built by dmd and a compiler built by gdc to have different capabilities

On that note, std.math.tan is a problematic function too that DMD treats like a built-in.

Do we have a ctfeable implementation in core.math?

No.

Oh yeah, it doesn't need to be ctfeable.  Just present.  Does GDC druntime not provide this either?

This is what I said in the original PR for CTFE-yl2x! You still merged it in despite my warnings.

I didn't merge it.

On that note, std.math.tan is a problematic function too that DMD treats like a built-in.

What's so problematic about tan?
But yeah, we should probably avoid adding ctfe intrinsics that depend on the host compiler/runtime.

What's so problematic about tan?

It's a weird half/half.  DMD recognises it as a CTFE-able builtin, but runtime it uses inline assembler.
For simplicity on my part, I only implement body-less functions in std.math/core.math as intrinsics.

And... I found a case where the implied use of yl2x broke gdc, along with every non-x86 target.  https://github.com/D-Programming-Language/phobos/pull/3309
Sigh  -  We should put a stop to this by removing uses of yl2x from std.math.  They might have been useful in the beginning.  But not anymore.

Or by implementing a portable version somewhere.

Or by implementing a portable version somewhere.

It's caled log2, I did this 2 years ago.
https://github.com/D-Programming-Language/phobos/commit/bf2b2a1858000dc88f0f3940faf0556feb4a90df


javadoc fixes, remove doclint:none

Removed the -Xdoclint:none configuration from pom.xml testing whether the javadoc is valid.
Did some fixes - but not all errors could be fixed, because there are generated java-sources which are now excluded from javadoc.

Coverage remained the same at 88.767% when pulling 817d76ba9353bbd9454f3a9817dbc0e605c74588 on gitmotte:master.javadoc-fixes into 449b74a67c50700e6cf6a36a6b2f760ebfb4602a on JSQLParser:master.

Coverage remained the same at 88.767% when pulling 817d76ba9353bbd9454f3a9817dbc0e605c74588 on gitmotte:master.javadoc-fixes into 449b74a67c50700e6cf6a36a6b2f760ebfb4602a on JSQLParser:master.

So if I understand you right, you could not do a complete build due to unresolvable javadoc problems. Therefore I will not merge.

So if I understand you right, you could not do a complete build due to unresolvable javadoc problems. Therefore I will not merge.

The setting doclint:none ignores errors during the generation of javadoc, i.e. the build does not abort, in consequence the javadoc-html files are created incorrectly.
I fixed this by fixing the existing errors (there are still some warnings, i.e. missing descriptions for parameters, ... ) and by removing the setting -Xdoclint:none within pom.xml - by default, the -Xdoclint option is enabled.
See https://docs.oracle.com/javase/8/docs/technotes/tools/unix/javadoc.html for detailed documentation.

The setting doclint:none ignores errors during the generation of javadoc, i.e. the build does not abort, in consequence the javadoc-html files are created incorrectly.
I fixed this by fixing the existing errors (there are still some warnings, i.e. missing descriptions for parameters, ... ) and by removing the setting -Xdoclint:none within pom.xml - by default, the -Xdoclint option is enabled.
See https://docs.oracle.com/javase/8/docs/technotes/tools/unix/javadoc.html for detailed documentation.

While I am no developer, it appears to me that we have two different issues here:

the is a lot of invalid JAVADOC in the manually written sources which deserves to get fixed, e.g.

Javadoc Warnings
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/parser/CCJSqlParserUtil.java:55: warning - @return tag has no arguments.
/home/are/Documents/src/JSqlParser/target/generated-sources/javacc/net/sf/jsqlparser/parser/Provider.java:26: warning - @param argument "length" is not a parameter name.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/parser/feature/Feature.java:513: warning - Tag @see: reference not found: CreateSynonym
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:126: warning - @return tag has no arguments.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:150: warning - @return tag has no arguments.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:160: warning - @return tag has no arguments.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:169: warning - @return tag has no arguments.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:179: warning - @return tag has no arguments.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:188: warning - @return tag has no arguments.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:198: warning - @return tag has no arguments.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:150: warning - Tag @link: can't find getOnDeleteReferentialAction() in net.sf.jsqlparser.statement.alter.AlterExpression
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:169: warning - Tag @link: can't find getOnDeleteReferentialAction() in net.sf.jsqlparser.statement.alter.AlterExpression
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:188: warning - Tag @link: can't find getOnDeleteReferentialAction() in net.sf.jsqlparser.statement.alter.AlterExpression
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:160: warning - Missing closing '}' character for inline tag: "{@link #setOnDeleteReferentialAction(Action)"
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:179: warning - Missing closing '}' character for inline tag: "{@link #setOnDeleteReferentialAction(Action)"
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:198: warning - Missing closing '}' character for inline tag: "{@link #setOnDeleteReferentialAction(Action)"
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:160: warning - @return tag cannot be used in method with void return type.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:179: warning - @return tag cannot be used in method with void return type.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java:198: warning - @return tag cannot be used in method with void return type.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/statement/create/table/ForeignKeyIndex.java:71: warning - @return tag has no arguments.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/util/SelectUtils.java:57: warning - @return tag has no arguments.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/util/SelectUtils.java:84: warning - @return tag has no arguments.
/home/are/Documents/src/JSqlParser/src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java:185: warning - @return tag has no arguments.

independent from that, there is a question if and how to activate DOCLINT.
In my own opinion, this did not yield in any merit because the automatic generated code will always break DOCLINT and when you look into the parser definition file then JavaDoc is your least concern.

So my suggestion was: why not focus on the brave task of fixiing the JavaDoc for the manually written code, but split off/remove the DOCLINT part. Would you like to amend your PR please, I really would love to see the JavaDoc fixed. Thank you already and cheers.

The javadoc fix can of course also be carried out without changing the doclint setting. However, in this case javadoc will still not checked for correctness for manually written sources, so switching on doclint validation would only ensure code quality for future changes.
For generated sources, a valid javadoc is desirable, but not possible without fixing javacc, so these sources were excluded from the validation.
@wumpz can of course change the request according to his wishes.

The javadoc fix can of course also be carried out without changing the doclint setting.
Then I would like to suggest to do so, because it looks to me like a low hanging fruit.

However, in this case javadoc will still not checked for correctness for manually written sources, so switching on doclint validation would only ensure code quality for future changes.
I get your point, but right now the Java Doc is more alike a stub in anyway. It is largely empty and in fact the toString() methods yield the most information at the moment. Personally I would care more about adding flesh to the documentation itself than about its syntax or enforcement.

For generated sources, a valid javadoc is desirable, but not possible without fixing javacc, so these sources were excluded from the validation.
Agreed.

@wumpz can of course change the request according to his wishes.
I can only assume that he does not have the necessary time and simply expects any PR to at least survive the CI as a kind of minimum quality assurance. So how can we help to get the cow off the ice? I see three options:

a) you quickly remove the blocking doclint related change in order to salvage the more relevant javadoc fixes
b) you abandon the PR (that would be sad)
c) I will need to pull from your repository, remove the blocking ddoclint part and re-issue a new PR (that would be last stupid and should be the last resort)
Which one will your prefer, it is your work, it is good and I am keen to get it merged.

I think there is just a misunderstanding: the rejection stems from a questionable Codacy Static Code Analysis, but not from DocLint.
(I have tested Coadcy once, laughed about it and deleted it.)

Please check PR #1163
I added
@SuppressWarnings({"PMD.MethodNamingConventions"})

to net.sf.jsqlparser.parser.SimpleCharStream which resolves 9 PMD issues.
If my understanding is correct, this would make your PR pass the CI without any ado.
@wumpz: Should we not add the PMD plugin to maven and check the same rules as Codacy does. It may annoy any contributor when cleanly compiling PRs get rejected just because the CI wrecks havoc afterwards. I spent almost 3 hours walking through this Codazy/PMD stuff when @gitmotte's PR itself seems to have no issue at all.

I think there is just a misunderstanding: the rejection stems from a questionable Codacy Static Code Analysis, but not from DocLint.

yes, these comments/fails from codacy are not new - i don't know how codacy works and how to fix it. it seems to be a code quality tool like sonarlint.

a) you quickly remove the blocking doclint related change in order to salvage the more relevant javadoc fixes

no, i won't. as i said, the pr can also be partially adopted - but i don't recommend it.

b) you abandon the PR (that would be sad)

no, others may find it usefull

c) I will need to pull from your repository, remove the blocking ddoclint part and re-issue a new PR (that would be last stupid and should be the last resort)

You are welcome to do so, but the Doclint change does not block a build as you think.

I get your point, but right now the Java Doc is more alike a stub in anyway. It is largely empty and in fact the toString() methods yield the most information at the moment. Personally I would care more about adding flesh to the documentation itself than about its syntax or enforcement.

I think syntax and its enforcement is the first step to good Javadoc documentation. If not enforced, the errors will cause the build to fail with default doclint - settings. Feel free to extend the documentation further - I'm sorry that I'm not doing this work for the whole library, but only for the parts i added / i have changed.

@manticore-projects You are right, it is an issue of time.
@gitmotte If I change the code, to be honest, I have to force myself to correct documentation and stuff. That's why doclint:none check is there. To make it easier.
@manticore-projects Codacy is there because it was sometimes advertised and somehow automatically integrated. You are right that it is a very lightweight checker. PMD should be integrated so the rules are in our hands. It would be a good addition to checkstyle which is already included. So the removal of Codacy is only a matter of time.
I am a huge fan of self documenting code, to avoid javadocs whereever this is possible. I think like the most developers documentation is a daunting task to me. Thats why much of for instance the old javadocs of the original project from sourceforge are still present even if there is so much to improve. I know.
/**
     * Read a character.
     * @return the character read
     * @throws IOException
     */
    public char readChar() throws java.io.IOException {
´´´

For instance this javadoc is without additional meaning. It needs to be removed or this

```java
     * @param feature
     * @param namedObject
     * @param fqn - fully qualified name of named object
     * @param alias
     */
    protected void validateFeatureAndNameWithAlias(Feature feature, NamedObject namedObject, String fqn, String alias)  {

The better way to document this is to rename the parameter to fullyQualifiedName and again the javadoc is without any additional meaning.
By the way there is another issue that wanted to start a separate documentation (#898), but the issue owner seemed to have lost its energy.
So I would say:

improve javadocs, via writing a right documentation or replace it with refactoring
let doclint checking switched off
include pmd with a starting rule that
lets think about a new start website or wiki page again. somehow one understands why many projects have their own documentation writer and that is definitely not me :/

@manticore-projects Codacy is there because it was sometimes advertised and somehow automatically integrated. You are right that it is a very lightweight checker. PMD should be integrated so the rules are in our hands. It would be a good addition to checkstyle which is already included. So the removal of Codacy is only a matter of time.

As far as I understand it, Codazy just uses PMD (beside a few less usefull checkers, the SQL checker for example got it very wrong and yielded n my harsh judgement). So I think, you should keep it because it creates such a nice badge. However, to make it useful, the PMD check must happen before commit and also the PMD ruleset should be customized and synchronised.
Especially the NPath complexity ( LOL the toString() methods) and the UnusedImports rules are not too helpful.
I have worked on that stuff, please see PR #1165

I am a huge fan of self documenting code, to avoid javadocs whereever this is possible.

Fully agreed, there will be ALWAYS a discrepancy between the latest code and any documentation and nothing is worse than wrong/old documentation. That said, I think any existing JavaDoc should be at least syntactical correct. Clean code is good from a Sales perspective too.

By the way there is another issue that wanted to start a separate documentation (#898), but the issue owner seemed to have lost its energy.

Website would be nice though. What is your opinion on sharing a website for JSQLParser and JSQLFormatter (as soon as JSQLFormatter becomes a bit more matured). They belong together and I spend more effort on yours than on mine over the last 3 days :-D

1. improve javadocs, via writing a right documentation or replace it with refactoring

Done by PR #1095, but depends on the PMD related fixes by PR #1165

2. let doclint checking switched off

No objection, but DocLint does not even seem to be the issue. I will check that out when revising this PR @1095

3. include pmd with a starting rule that

Done, PR #1165 waits  for your approval.

4. lets think about a new start website or wiki page again. somehow one understands why many projects have their own documentation writer and that is definitely not me :/

I definitely won't write much documentation, but I could look into this website thing eventually.
Writing a website is easy, the main problem will be how to maintain it over the time.

@gitmotte If I change the code, to be honest, I have to force myself to correct documentation and stuff. That's why doclint:none check is there. To make it easier

Doclint none is guaranteed to lead to faulty documentation over time, which is why I like having it turned on.
By the way, javadoc without comment but with parameter names is very valuable, because the compiler turns parameter names into arg0-argn. An IDE can use the information from the javadoc-jar to show me the parameter names correctly if the source is not available.
Furthermore, javadoc is for me a stylistic device for clarity (between each declaration a javadoc block), but maybe that's just my feeling.

By the way, javadoc without comment but with parameter names is very valuable, because the compiler turns parameter names into arg0-argn. An IDE can use the information from the javadoc-jar to show me the parameter names correctly if the source is not available.

Which parameters do a compiler turn to arg0-argn? Every jar without javadoc holds the information of the original method names and parameter names. Only by some kind of obfuscation you are loosing those?

BTW nearly all IDEs are able to present now parameter names as inline hints so this is available without any additional javadoc opening.

I have merged @gitmotte's stuff as good as possible and fixed the DocLint entries.
DocLint is active and will stop when anything material is breaking, but will ignore any Missing Warnings.

By the way, javadoc without comment but with parameter names is very valuable, because the compiler turns parameter names into arg0-argn. An IDE can use the information from the javadoc-jar to show me the parameter names correctly if the source is not available.

Which parameters do a compiler turn to arg0-argn? Every jar without javadoc holds the information of the original method names and parameter names. Only by some kind of obfuscation you are loosing those?

only if debug-information for vars is present in class files (By default, only line number and source file information is generated i.e. without -g option is being specified. )
most ide's have this turned on by default, but maven has only true by default, not source,lines,vars

Can we close this? I believe to have merged the relevant parts in 2021 already.

merged by @manticore-projects


fix: permission denied when running on Jenkins

This PR when merged will have a same tags, e.g: 2.0.0-jenkins and make sure this is not shipped in latest tag (as it might break our Gitlab CI permission related)
ref:

https://stackoverflow.com/questions/52683091/how-to-build-a-docker-image-for-jenkins-with-android-and-docker-build-support
https://stackoverflow.com/a/58027325/3763032
sudo adduser

Looks like in our Jenkins server, the home user was sampingan (how to check jenkins system config) so there's no impact in Dockerfile doing chown thing.
Looks like this is should be fixable by providing the argument when trying to run the Docker, as there's a following API:

Image.run([args, command])
Uses docker run to run the image, and returns a Container which you could stop later. Additional args may be added, such as -p 8080:8080 --memory-swap=-1. Optional command is equivalent to Docker command specified after the image. Records a run fingerprint in the build.
Image.withRun[(args[, command])] {…}
Like run but stops the container as soon as its body exits, so you do not need a try-finally block.
Image.inside[(args)] {…}
Like withRun this starts a container for the duration of the body, but all external commands (sh) launched by the body run inside the container rather than on the host. These commands run in the same working directory (normally a Jenkins agent workspace), which means that the Docker server must be on localhost.

3 API mentioned above cited from here or go here for the official docs of Jenkins Docker Plugin

Jenkins uid mentioned in hub.docker.com/_/jenkins was 1000, we also checks for our own Jenkins server that has the same uid 1000


Adding cameras

I think that Didier told me that it possible to add tofu.geom.CamLOS1D objects together. I can't seem to get this work in tofu 1.4.0 - is it a feature for the next release? It would be very useful for building our pinhole cameras, because they are constructed from several subcameras.

This feature is already available in the development version (since PR #100 ) and will be available in the next release (1.4.1)
Example use case:
import numpy as np
import tofu as tf

D0 = np.array([[ 4.09044068,  0.        , -3.34447391],
                        [ 4.09472034,  0.        , -3.34173696]])
D1 = np.array([[ 4.10327966,  0.        , -3.33626304],
                        [ 4.10755932,  0.        , -3.33352609]])

u0 = np.array([[ 0.04536299,  0.        , -0.99897057],
                        [ 0.30236989,  0.        , -0.95319067]])
u1 = np.array([[ 0.73845534,  0.        , -0.67430239],
                        [ 0.88781539,  0.        , -0.46019978]])

config = tf.geom.utils.create_config('A2')
cam0 = tf.geom.CamLOS1D(dgeom=(D0, u0), config=config, Exp='ITER',
                                              Diag='Bolometer', Name='0')
cam1 = tf.geom.CamLOS1D(dgeom=(D1, u1), config=config, Exp='ITER',
                                              Diag='Bolometer', Name='1')

cam = cam0 + cam1

Excellent, thank you.

Closed in 1.4.1


Can see Hisense TV but no input sources appear, cant adjust volume or change channel

Describe The Bug:
Television joins via Homekit nicely.  Button appears, can switch TV on.
To Reproduce:
Tried to disable SSL, didnt work. Added 'custom' and progressed but no inputs.
Expected behavior:
Wanted to see the input sources appear
Logs:
Received Python command error: Error: [2021-09-14 20:56:40,992] [INFO    ] SSL context created with cert file (/home/pi/rcm_certchain_pem.cer) and private key (/home/pi/rcm_pem_privkey.pkcs8)
Traceback (most recent call last):
File "/usr/lib/node_modules/homebridge-hisense-tv-remotenow/bin/hisensetv.py", line 6, in
main.main()
File "/usr/lib/node_modules/homebridge-hisense-tv-remotenow/bin/hisensetv/main.py", line 128, in main
with tv:
File "/usr/lib/node_modules/homebridge-hisense-tv-remotenow/bin/hisensetv/init.py", line 137, in enter
self._mqtt_client.connect(self.hostname, self.port)
File "/usr/local/lib/python3.7/dist-packages/paho/mqtt/client.py", line 941, in connect
return self.reconnect()
File "/usr/local/lib/python3.7/dist-packages/paho/mqtt/client.py", line 1104, in reconnect
sock.do_handshake()
File "/usr/lib/python3.7/ssl.py", line 1117, in do_handshake
self._sslobj.do_handshake()
ConnectionResetError: [Errno 104] Connection reset by peer
Show the Homebridge logs here, remove any sensitive information.

Plugin Config:
Show your Homebridge config.json here, remove any sensitive information.
{
            "ifname": "eth0",
            "devices": [
                {
                    "id": "HiSenseTV",
                    "name": "HiSense",
                    "ipaddress": "<IP_ADDRESS>",
                    "macaddress": "removed",
                    "sslmode": "custom",
                    "sslcertificate": "/home/pi/rcm_certchain_pem.cer",
                    "sslprivatekey": "/home/pi/rcm_pem_privkey.pkcs8"
                }
            ],
            "platform": "HiSenseTV"
        }```

**Screenshots:**
<!-- If applicable, add screenshots to help explain your problem. -->

**Environment:**
Pi

* **Plugin Version**:
* **Homebridge Version**: <!-- homebridge -V -->1.3.4
* **Node.js Version**: <!-- node -v -->14.6.1
* **NPM Version**: <!-- npm -v -->6.14.2
* **Operating System**: <!-- Raspbian / Ubuntu / Debian / Windows / macOS / Docker / hb-service --> Raspbian

<!-- Click the "Preview" tab before you submit to ensure the formatting is correct. -->

Hi, have still not had any luck and using Hisense 40S4, which operates with RemoteNow native app, but I cant seem to get the TV to display a pin, and receive the error below as they havent successfully paired.
An error occurred while fetching inputs: TypeError: Cannot read property 'join' of null

@woodgieboodgie thanks for reporting this!

An error occurred while fetching inputs: TypeError: Cannot read property 'join' of null

This error is always reported when the TV and your Homebridge device aren't paired.

ConnectionResetError: [Errno 104] Connection reset by peer

This error means that the SSL certificates you're trying to use are not valid for the TV model. Unfortunately, there's not much we can do on the plugin side here. You'd have to find a way to get those certificates from the TV or the RemoteNOW app. I'd be happy to help on this quest, but I wouldn't even know where to start.
The reason why turning on works is because it uses the Wake-On-Lan magic packet, which doesn't require authentication nor SSL.
Closing as this is, unfortunately, not a plugin issue.


Batched inputs support (base_cam.py)

Hi Jeffery,
Can you please explain what this PR does.
The code already supports batches.


Move javascript code to sprockets/importmaps

move view component javascript to sprockets
use import maps for transport surverys

rolling into https://github.com/Energy-Sparks/energy-sparks/pull/3676


Ensure links are consistently enabled in Host summary screens

Specifically fixes the links in the Configuration section.
https://bugzilla.redhat.com/show_bug.cgi?id=1202529
@h-kataria, @dclarizio please review.

@h-kataria made suggested change.  Ready for review.

@Fryguy, I don't see a good way to use alias_method instead of alias in this instance as I'm relying on being able to call super.  Am I missing something obvious?

verified in UI, merging.


MultiPolygon Parsing, polygons require two entries

I imported a shape file using shp2pgsql that contains MultiPolygons. When I try to retrieve them from the database, I get these two errors:
InvalidArgumentException in MultiPolygon.php line 19: $polygons must contain at least two entries
and
ParserException in Parser.php line 43: Parsing failed: $polygons must contain at least two entries
In the model, it doesn't matter how the $postgisFields are defined: MultiPolygon, Polygon or GeometryCollection, I still get the same error.

Hi,
this is unfortunately a bug/issue in the geo-io/wkb-parser package.
It doesn't really matter what you define in $postgisFields (the type is not being used after we switched to that package).
You could try filing an issue there, just show the WKB data (the hex-like data you see in the database) and the error you get.
An alternative is to cast the MultiPolygon to a Polygon in the database, but that's a workaround, not really a solution.

Hi @phaza,
could you explain why this is a bug in the wkb parser? The geometry is a multipolygon which contains a single polygon:
MULTIPOLYGON(((-80.214554 25.769598 0 0,-80.2147 25.774514 0 0,-80.212983 25.77456 0 0,-80.212977 25.773597 0 0,-80.211448 25.773655 0 0,-80.211498 25.774579 0 0,-80.209432 25.774665 0 0,-80.209392 25.773667 0 0,-80.204387 25.773834 0 0,-80.199383 25.774324 0 0,-80.197718 25.774031 0 0,-80.197757 25.774975 0 0,-80.193655 25.775108 0 0,-80.193623 25.774134 0 0,-80.191855 25.772551 0 0,-80.193442 25.76969 0 0,-80.192231 25.768345 0 0,-80.192879 25.758009 0 0,-80.196301 25.759985 0 0,-80.195608 25.76152 0 0,-80.198856 25.761454 0 0,-80.200646 25.763287 0 0,-80.20401 25.763164 0 0,-80.204023 25.76367 0 0,-80.205673 25.763141 0 0,-80.214326 25.762935 0 0,-80.214451 25.765883 0 0,-80.214539 25.768649 0 0,-80.216203 25.76858 0 0,-80.214554 25.769598 0 0)))

Not sure if i miss something but this looks valid to me and the wkb parser extracts it correctly. Why does your MultiPolygon class require at least 2 polygons?

I'm very sorry, @jsor.
It was a mistake on my part where I seemed to recall something which wasn't correct.
I've fixed the issue and pushed out a new version (2.11), so this should now be fixed.
Let me know if you still have problems.

Cool! No need to be sorry and thanks for using my library :smiley:

hi,
I am getting this error.
not sure, whats the solution to this.
Can someone please let me know


Splitting mobile benchmarks into CPU + GPU.

The goal is to reduce latency by using multiple devices.
Each configuration still fetches the artifacts for all of them and that
takes a decent chunk of time - we could split them up in
build_android_benchmark.sh to make that better.

Hmm, looking at the Buildkite jobs, CPU takes ~25min while GPU takes ~8min. Quite imbalanced. Might be good to partition between, say, dylib vs (?!dylib).*? This moves VMVX to run together with Vulkan at least. Or find ways to split among dylib vs dyblib-sync.

Discarding for now since it wasn't such a big win - when the larger infra improvements come we can do it, hopefully.


buildGoModule: form GOFLAGS from goFlags

This PR introduces a new argument, goFlags, to form GOFLAGS at build time at the beginning of buildPhase and checkPhase.
This PR also adds a helper Bash function to setup.sh named removeAllPrefixedFromVar, which removes all the elements with given prefixes from the Bash array/IFS-separated string variable of the given name.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

By the way, is the rationale behind having goFlags the fact that lists are more ergonomic to use with overrideAttrs?

By the way, is the rationale behind having goFlags the fact that lists are more ergonomic to use with overrideAttrs?

It's because a list is more structured than a string, and I hope to keep having a way to specify GOFLAGS with a list. As you said, the main benefit would be a smoother overrideAttrs experience.

I reimplemented this PR and made buildGoModule form GOFLAGS at build time at the beginning of buildPhase and checkPhase.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/breaking-changes-announcement-for-unstable/17574/74


Shuffle(Table) doesn't work for Lazy Table

Given a table of a custom lazy type:
class LazyTableType : TableType
{
  //...
}

Calling Filter(Table, ...) works fine but Shuffle(Table) complains about argument types. It's possible that other table functions also have this issue, I haven't done an exhaustive search.
Possibly this has to do with ShuffleFunction.SupportsParamCoercion being false?

TableType is sealed now. (recent change).  Is this still an issue?

Yup. This was a tiny oversight, turns out. Shuffle calls DType.ToTable even on a table, and we missed a no-op case.


Move missing platform specific metrics

Two platform specific metric reporter were missing. These two reporters are required for Agent and Fleet server.

:broken_heart: Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-04-11T13:44:25.518+0000

Duration: 10 min 17 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
49

Skipped
0

Total
49

Steps errors
Expand to view the steps failures

Running Go tests

Took 0 min 2 sec . View more details here
Description: gotestsum --format testname --junitfile junit-report.xml -- -v ./...

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.


Cannot open local file

I download a file, and save it in the path '/Users/wos/Library/Developer/CoreSimulator/Devices/F5C257D2-62F8-4E14-BC43-5BD659F501A8/data/Containers/Data/Application/90044531-7176-439E-AA88-768721406A9A/Documents/burpees.mp4'.
The videoplayer can not play this.

Solved adding "file://" to the start of the url


Non-regular promotion of develop to main

This update is initiated in favor to promote  #422 into production but it seems we can make a prod release.
cc @charleslavon @calebjacob any objections?

@gabehamilton does this PR included the activityfeed change that introduced the error which we ended up reverting?

@charleslavon it has the fixed version of that. Please check the feed after deployment, though :-)


[Select] Custom option schema + getOptionLabel + noResultsMsg prone to cause errors

Current Behavior
Using a custom option schema in conjunction with the getOptionLabel prop render a label that uses multiple properties from your object is pretty common.
However, when using noResultsMsg="..." to render a pseudo-option when someone types a query that doesn't match, your getOptionLabel callback will be passed this pseudo-option which may not have the properties expected.
This results in a JavaScript error that unmounts your app (if you don't have error boundaries configured)
How to replicate
CodeSandbox: https://codesandbox.io/s/7m18o9r73x
Type in random characters like "kxzckjvhasdf", app will unmount due to error.
Expected Behavior
Base UI should take steps to protect users from this failure scenario
Potential Solutions

Don't call getOptionLabel for the special No Results option. Downside is this may prevent people from being able to customize how this looks.
Switch to a renderNoResults: () => Node prop that is used instead of noResultsMsg (getOptionLabel wont be called here either)
Update the flow types for getOptionLabel to be ({option: OptionT | NoResultsOptionT}) => Node where NoResultsOptionT is an exact object type. This has the downside that users who aren't using noResultsMsg will still have to do null checks since the flow type is stricter.

I probably lean towards number 2 but open to any other ideas you might have.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Tested this with flow checking and it seems to properly warn when I'm dangerously accessing a missing property. Is that coming up when importing the package as a dependency?

I find that there's a lot to be gained from co-locating the label rendering to a single function call + if statement, rather than splitting up amongst two functions. Another option, that I think may be the best way forward, is to reconsider the 'no results' implementation itself. It should not repurpose the 'option' rendering at all. Overloading like in the getOptionLabel function leads to unexpected results/bugs where people will assume consistency. We have updated 'No Results' designs that suggest decoupling anyway. My suggestion is to move towards a styled-component/override approach, and possibly allow a React.Node for noResultsMsg

Tested this with flow checking and it seems to properly warn when I'm dangerously accessing a missing property. Is that coming up when importing the package as a dependency?

Interesting – I'm sort of reporting this on behalf of another engineer on the team, but I think the way our code is structured, the flowtype for this callback was getting lost, thus we weren't getting warned though.
Either way, I don't think it's unreasonable to allow Option with a custom schema. How else are we supposed to do custom rendering that uses a variety of fields (not just leveraging labelKey)? Theoretically it seems like Option should actually be a generic type for Select:
class Select<O> extends Component<PropsT<O>, SelectStateT> {

That way the param of getOptionLabel can exactly match the schema of the object the user is passing in. Seems like this works using a quick and dirty test in try flow.
That said, that's a much broader change that is likely outside the scope of this issue.
I agree with your proposed solution, sounds pretty close to what I was outlining in option number 2. 👍

Added the no results state in here #1245 and closing this issue.


++i; -> i++;

It may be causing some problems...

What happened with TestSwitchPatternMatching22.dec?

The steamroller happened

At a glance, looks like that may be due to a difference in the compiler?

This has been discussed on the socials, there's some discrepancy between the github actions and local. I would request dropping TestSwitchPatternMatching22.dec and TestSwitchPatternMatchingFuzz1.dec from the patch.

Ah, thanks! I've restored the files to the commit a based the branch on

This PR has been merged manually as commit 55eb5e3 due to the large amount of conflicts, and as so I'll close this PR. Thank you for this!

Oops. Couldn't you have pushed to my branch?

It was easier to do this patch workflow style on my end, by grabbing the patchfile and fixing the diffs. The end result is the same in any case.

but GitHub PR stats :pleading_face:
Ah, I see


Bug: Config Server label needs noted

In Configure a Spring Cloud Config Server - Configure Azure Spring Cloud to access the Git Repository, the Label field is not addressed.
Some things to note:

The default value for Label is master.
If your Git repo does not have a master branch - as most have moved on to the main branch as a default, the Label should be set to main.
If you want the config server to look at a different branch or tag, that value should be used for Label.

Yes I totally agree on this. In fact I just changed yesterday our Microsoft Learn based on this workshop  to have exactly the same fix!
@selvasingh feel free to assign this to me if you want me to do this change.


fix: SubProcess task may fall into an endless-loop by fault-tolerant

Purpose of the pull request

When sub-process task submitted with a finished state, the SubProcessTaskExecThread.waitTaskQuit() will return directly, and set task state with sub-process's state (even if the sub-process is running, such as READY_PAUSE/READY_STOP or others), so the sub-process-task will ended with an unfinished state (READY_PAUSE or READY_STOP),
so the parent thread MasterExecThread will fall into an endless-loop.

Brief change log
SubProcessTaskExecThread.waitTaskQuit() should check subProcessInstance's state first:

If subProcessInstance is not null and its state is unfinished, it still enters the waiting loop.

Issue
#6062

hi, can you resolve the CI check Fail?

OK.

Codecov Report

Merging #6063 (7db2d7e) into dev (e0eea99) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #6063      +/-   ##
============================================
- Coverage     46.38%   46.30%   -0.08%
+ Complexity     3738     3733       -5
============================================
  Files           609      609
  Lines         25075    25076       +1
  Branches       2868     2869       +1
============================================
- Hits          11630    11611      -19
- Misses        12300    12321      +21
+ Partials       1145     1144       -1

Impacted Files
Coverage Δ

...server/master/runner/SubProcessTaskExecThread.java
37.66% <0.00%> (-0.50%)
:arrow_down:

...he/dolphinscheduler/common/enums/SqoopJobType.java
0.00% <0.00%> (-88.89%)
:arrow_down:

...eduler/server/worker/runner/TaskExecuteThread.java
56.71% <0.00%> (-4.48%)
:arrow_down:

...er/master/processor/queue/TaskResponseService.java
63.88% <0.00%> (-4.17%)
:arrow_down:

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (-2.00%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.35% <0.00%> (-1.70%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0eea99...7db2d7e. Read the comment docs.

@reele  Thank you very much for your contribution,  the implementation of sub-process is reconstructed.
Would you please checkout the new code and check this problem exists?

well, because of the json-split is not completed, the depenent node still used 'id' to reference the process_id, i can't import the 6000 tasks' dag of dw to test the stability, i may try it at some other times.


Add exceptions for OSEHRA VistA update from Feb 2019

Add the XINDEXExceptions for XINDEX error introduced in the OSEHRA VistA
update for February 2019
Change-Id: I943da971dd6d19ad8d40746d96ffcf197a0fbfd2

Merge was to set to target wrong branch.  closing/


[Enhancement]: Move starter kits location based on ecosystem

What would you like us to improve?
I'd love to see the starter kits moved based on their ecosystem.

Have a "Starter Kits" page under the main getting started location under "resources".

This page would have all the starter kits, and maybe a reference to this github repo:
https://github.com/smartcontractkit/starter-kits
(Or, it would have a reference to EVM starter kits and Solana Starter Kits)

Have the EVM chains and Solana chains pages have references to the starter kits.

right now, the EVM Chains has one under "Install frameworks" but it's not often updated. Wondering if it would be easier to point to this repo: https://github.com/smartcontractkit/starter-kits and just put them in EVM vs Solana categories somehow.
How important it is?
Low priority

We reorganized our top nav and made some updates to the "Install Frameworks" page: https://docs.chain.link/resources/create-a-chainlinked-project?parent=gettingStarted
I think that resolves this issue. We match the starter kits list 1-1 now.


Is it possible to use pre-specified tokenization when generating bert embeddings?

Hi. For datasets with gold tokenizations, is it currently possible to use these gold tokenizations and generate BERT embeddings from those tokens (instead of using BERT's in-house tokenizer from a text string)? Thanks.

Yeah, I think it is possible, but I never experiment it. As long as the format is good for bert, it should be fine. However, I don't know once you convert your gold tokenizations into bert format, does it hurts your performance. (Just a roughly thinking)

I am using the python imported module for the purpose. I am not sure how to input a list of tokens since the documentation only introduces inputting a string of sentences. Thanks.


Fix duplicated code format

When formatting multiple ranges, there may be duplicated TextEdits.
Make sure to dedupe them to avoid encountering the error
"Overlapping ranges are not allowed!"

When formatting multiple ranges, there may be duplicated TextEdits.

Who says that? Isn't that a bug of the formatter and we shouldn't cover up?

The formatting provider is given the ranges one by one, so it process each one without any knowledge of the list of ranges. In some cases, it makes sense for the formatter to provide an edit spans further than the input range to avoid awkward formatting.
Problems arise when there 2 of the input ranges are close to each other, and when the resulting edit for each one includes the other. That is totally fine as long as both edits are identical.
See this example, some basic C++, formatting provider is clangd:
#include <vector>

int main(int, char**)
{
    std::vector<int> v = {
                1, // A
            2, // B
                 3, // C
    };
    return 0;
}

I'll use the comments A, B and C to reference lines.
For reference, clangd wants to format like this (not lines A, B and C changed):
#include <vector>

int main(int, char**)
{
    std::vector<int> v = {
        1, // A
        2, // B
        3, // C
    };
    return 0;
}

Let's say I use git and I modified lines A and C, I use "Format modified lines". VSCode will ask clangd to format 2 ranges independently: one is line A, and the second is line C. For both, clangd will format lines A, B and C because it considers that these 3 lines form a single block that should be indented consistently. This results in 2 identical edits. Both what clangd and the user expect is pretty trivial, yet vscode will reject the formatting.
Basically you have to make a choice, either you:

do nothing

users (me) cannot format the document at all, and are spammed with pop-ups

require formatters to be strict about range

users will be mad because they end up with an awkward formatting, which may be even worse than no formatting at all

allow and merge strictly identical edits

users are happy and will send you love

Note that I draw a line as to what should be allowed: edits must be strictly identical. It's not up to the IDE to fix an inconsistent formatter.

users are happy and will send you love

That's a goal we all strive for but I think you meant  "I am happy" because cases where edits overlap but aren't identical aren't covered. Different alternatives:

Add new API like DocumentRange_S_FormattingEditProvider which is always called with an array of ranges to format. This would be the best solution because all the control and power is with extensions. However, it will be a new API and it is unlikely that extensions adopt this and we still stuck with how to use the other, single range, API

A different idea is this: Check for what ranges the returned edits overlap, then discard those edits, merge the ranges into a single, bigger range, and ask for edits again. In your sample above that would mean:

make format request for line A, make format request for line C
detect overlap between the edits for A and C
merge the ranges into a single range A,B,C and ask again for edits
repeat until edits are free of overlap or when only a single range is left

I believe that would work and is a more complete and pragmatic approach to the problem

I like number 2., I'll implement that when I find some time

Here's my take on this

@qchateau Thanks for contributing this PR! ❤ It also fixes an issue of the prettier extension when formatting only modified lines.

Yes, many thanks to @qchateau. You creating the PR was a lucky coincidence because @hediet and me had brainstormed about this exact problem a day earlier.

Nice to see we all have the same problems :D


FIREBREAK: 🔥 Create a Dashboard for GitHub Actions Private Minutes

Background
The ministryofjustice relies heavily on GitHub Actions for continuous integration and deployment. We have a monthly allocation of private minutes for running these actions. However, we often find ourselves depleting this allocation before the end of the month, which can disrupt our workflow and potentially incur additional costs. Currently, we lack visibility into how these minutes are being consumed, making it difficult to optimize our usage or identify potential misuse.
Questions / Assumptions

What data does GitHub provide regarding Actions minutes consumption?
Can we access this data programmatically through GitHub's API?
How granular is the available data (e.g., per repository, per workflow, per job)?
What tools or technologies would be best suited for creating a dashboard?
How frequently does GitHub update the minutes consumption data?
Are there any rate limits or other constraints on accessing this data?

What hypothesis do we want to test?/What do we want to learn?
We hypothesize that creating a dashboard to visualize GitHub Actions private minutes consumption will allow us to:

Identify patterns in our usage over time
Pinpoint specific workflows or repositories that are consuming a disproportionate amount of minutes
Detect any unusual or unexpected spikes in consumption that might indicate misuse or inefficiencies
Make more informed decisions about optimizing our GitHub Actions usage
Potentially reduce costs by addressing inefficiencies or unnecessary runs

We want to learn:

The feasibility of creating such a dashboard using available GitHub data
The most effective way to visualize this data for easy comprehension
Whether this increased visibility leads to more efficient use of our private minutes allocation
If there are any unexpected insights about our CI/CD processes revealed by this data

Definition of done

[ ] Design and implement a dashboard interface that displays:

[ ] Overall monthly consumption with comparison to allocation
[ ] Daily/weekly consumption trends
[ ] Per-repository and per-workflow breakdowns
[ ] Alerts for unusual spikes or high-consumption workflows

[ ] Implement user authentication to ensure only authorized team members can access the dashboard
[ ] Set up automated data refresh to keep the dashboard up-to-date

The current dashboard provided by Github doesn't allow you to filter by runner type either, which means that is impossible to differentiate which repositories are using minutes on hosted or self-hosted runners.


Added error checking for usernames starting with dots and underscores

Closes: #1
Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


Setup clear queries from JSON

The JSON is crazy but we need to extract the necessary information

I want athlete names bundled with their stats and headers to the stats but that can likely be hard coded given an array of strings to represent it. Teams stats would be nice to setup the query.


fix: 🐛 Correctly handle scopeToMiddlewareScope for Asset types

Description
scopeToMiddlewareScope was not correctly modifying the incoming scope in order to filter out data from SQ entities. Old attribute value was still used instead of new assetId in case of ScopeType.Asset. This correctly now maps the same.
Breaking Changes
NA
JIRA Link
DA-1359
Checklist

[ ] Updated the Readme.md (if required) ?

/fast-forward

:tada: This PR is included in version 26.0.0-alpha.7 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 26.0.0-beta.4 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 26.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Delete old CARTO tables

We have a new limit of 10 tables on CARTO. We should delete older tables after backing them up to Drive

The following tables have been backed up to Drive and deleted from CARTO
https://drive.google.com/drive/folders/1zL9BNTXmBVnW3wFrZy-S0l8HJtOyygsc?usp=drive_link


Templating engine

I should add a second templating engine to simplify the creation of html elements without using the Java api, by writting html directly with java mixed in, just like JSP.

  %for (int i = 0; i < 10; i++) {%

%i%

  %}%

I have discovered a use case where I can load the html template as a String and just server it to the client or replace patterns using the replace and replaceAll methods from a string. E.g:
String template = FileSystem.readToString("./template/card.html").unwrap();
// Draw 10 cards
StringBuilder sb = new StringBuilder();
for (int i = 0; i < 10; i++) {
  sb.append(
     template
       .replaceAll("${title}", "Card: " + i)
       .replaceAll("${price}", "R" + (i + 1) * 20)
       .replaceAll("${description}", "This is card number: " + i);
  );
}

response.sendData(sb.toString());

./template/card.html

${title}

${description}

${price}

This is nice but still feels limited, I have to work on a more streamlined template system.  I could've used the template engine for JSP but it seems like its tied to whatever the stack for JSP is.

Today I finally implemented the templating engine, but it's not yet integrated with BlazingWebx and I do not intend on doing so. Instead it is its own standalone application called JTemple and can take a .jsp file and turn it into a java class that represents the template. It's essentially a .jsp to .java compiler.


Enhance Model Selection Workflow and Data Integration in Classification Interface

Added a grid layout to display classification models, allowing users to choose from a list of models.
Integrated real and static data sources for model details, facilitating seamless switching for testing and production environments.
Implemented a toggle functionality for switching between live model data and static test data for development ease, enhancing developer experience and testing efficiency.
The selected model is now globally accessible via selectedModel state, streamlining the process of model selection and ensuring consistency across the application.
Introduced a new popup mechanism for model selection, making the user interface more intuitive and user-friendly.
Conducted thorough testing to validate new features and ensure compatibility with existing functionalities, emphasizing reliability and quality in the user experience.

#28
#74
#93
#96

The lint error in the Github Workflows is probably caused by running eslint on the whole repo instead of only the src/ directory instead of . (root directory).


Enhance workerpool. Reuse bytes buffer in some case. Reload bugfix.

Support worker pool to process events
Reuse bytes buffer in some case.
Reload bugfix.

Codecov Report

Merging #107 into master will decrease coverage by 0.29%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #107     +/-   ##
=========================================
- Coverage   22.27%   21.98%   -0.3%
=========================================
  Files          40       41      +1
  Lines        3488     3535     +47
=========================================
  Hits          777      777
- Misses       2673     2720     +47
  Partials       38       38

Impacted Files
Coverage Δ

pkg/config/parser.go
3.21% <0%> (-0.02%)
:arrow_down:

pkg/upstream/healthcheck/http2healthchecker.go
0% <0%> (ø)
:arrow_up:

pkg/upstream/healthcheck/sofarpchealthchecker.go
0% <0%> (ø)
:arrow_up:

pkg/network/buffer/slabbufferpool.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 283e1ac...f93876b. Read the comment docs.


do not exports module structures

I don't know C++, so probably not the way to do it but just to get the grasp of it :
only the extern C PyInit_zengl() should be visible since it's a shared library.
On some platforms loading TWO c++ modules with same "module_methods" name (quite common since it's the name in examples ! ) may mask each other.
It happens to be the case with glcontext.egl imported in egl headless, which is also a C++ module and use the same identifiers.

On some platforms loading TWO c++ modules with same "module_methods" name (quite common since it's the name in examples ! ) may mask each other.

I never knew why single file projects may need static so I ommitted them on purpose.
I add them back, basically it should go everywhere.
PS: you might not need glcontext for WebGL support. You just need an object with an OpenGL function resolver. I paste an example below. For WebGL it should be as simple as these few lines:
https://github.com/szabolcsdombi/zengl/blob/7971a6fb2b6b215852e7ee9da1552e4d19e15435/_zengl.py#L164-L173

Closing this, (resolved in https://github.com/szabolcsdombi/zengl/commit/fe6bcce205a13622200467aa3d73ce8fb62f773b)
Linking https://github.com/szabolcsdombi/zengl/issues/34


what's the seed's nodejs version NO？does those ERR effect ?

npm ERR! node v4.2.0
npm ERR! npm  v2.14.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node install.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node install.js'.
npm ERR! This is most likely a problem with the phantomjs2-ext package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node install.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls phantomjs2-ext
npm ERR! There is likely additional logging output above.

Problem in phantomjs2-ex as npm states? It is not issue related to the seed.


ButtonConfigHelperInspector typo fix

Overview
Fix some typos in ButtonConfigHelperInspector that are causing exceptions in the inspector.
Changes

Continuation of #8848

/azp run


Initial CI Integration

CI Integration that enables automated building and pushing to Quay using Travis
cc: @thomasmckay

ack - thanks!


Unify the time unit for intervals to microseconds.

We sometimes use microseconds and sometimes use milliseconds to set the intervals for the components that wake up periodically. This can lead to confusion and sometimes we even have the wrong specification in settings (e.g., we use us for LogSerializerTask for in settings it says ms).
This PR unifies all these intervals to use us. And this also gives us more flexibility to set finer-grained intervals.
In addition, this PR:

Cap exponential back-off logic for LogSerializerTask to 10000us.
Set the intervals to some values I think "reasonable":
LogSerializerTask: 100us
DiskLogConsumerTask: 100us
GarbageCollectorThread: 1000us
MetricsThread: 10000us
Fix typos.

Do we know what the performance implications are for these settings? For example changing the log serialization interval means that the latch that committing transactions need will be grabbed by the serialization thread every 100 microseconds. That seems aggressive but don't have numbers to back it up.

We could wait to see the benchmarking results from the logging group. And if 100us is too aggressive, we could just bump them up to 1000us. Regardless, I think unifying everything to us is helpful.

@thepinetree And what was the idle CPU usage before this PR?

@thepinetree And what was the idle CPU usage before this PR?

0.5-3%. Its essentially the same on this branch once it hits max sleep.