SHOW TABLES kills clickhouse

No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.2 LTS
Release:	16.04
Codename:	xenial

ii  clickhouse-client   1.1.54190      amd64          clickhouse-client
ii  clickhouse-server-b 1.1.54190      amd64          clickhouse-server-base
ii  clickhouse-server-c 1.1.54190      amd64          clickhouse-server-common

:) use default;

USE default

Ok.

0 rows in set. Elapsed: 0.001 sec.

:) show tables;

SHOW TABLES

Exception on client:
Code: 32. DB::Exception: Attempt to read after eof: while receiving packet from localhost:9000, ::1

Connecting to database default at localhost:9000.
Code: 210. DB::NetException: Connection refused: (localhost:9000, ::1)

vg@ubuntu:~$ clickhouse-client
ClickHouse client version 1.1.54189.
Connecting to localhost:9000.
Code: 210. DB::NetException: Connection refused: (localhost:9000, ::1)

ClickHouse client version 1.1.54189.
Connecting to localhost:9000.
Connected to ClickHouse server version 1.1.54189.

:) show tables from system;

SHOW TABLES FROM system

Exception on client:
Code: 32. DB::Exception: Attempt to read after eof: while receiving packet from localhost:9000, ::1

Connecting to localhost:9000.
Code: 210. DB::NetException: Connection refused: (localhost:9000, ::1)

2017.03.25 22:21:07.228223 [ 4 ] <Error> BaseDaemon: ########################################
2017.03.25 22:21:07.228256 [ 4 ] <Error> BaseDaemon: (from thread 2) Received signal Illegal instruction (4).
2017.03.25 22:21:07.233747 [ 4 ] <Error> BaseDaemon: 1. clickhouse-server() [0x1f10be0]
2017.03.25 22:21:07.233801 [ 4 ] <Error> BaseDaemon: 2. clickhouse-server(Poco::ThreadImpl::runnableEntry(void*)+0xa5) [0x3571245]
2017.03.25 22:21:07.233814 [ 4 ] <Error> BaseDaemon: 3. /lib/x86_64-linux-gnu/libpthread.so.0(+0x76ba) [0x7f77d2a746ba]
2017.03.25 22:21:07.233827 [ 4 ] <Error> BaseDaemon: 4. /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f77d209582d]

Received signal Illegal instruction
It means that your CPU doesn't support required instruction set.
For Yandex pre-built packages, minimal instruction set is SSE 4.2.
To show supported instruction sets, run cat /proc/cpuinfo.
You may build ClickHouse by yourself (either on target machine or with explicitly limited instruction set during build) and it will work even on older CPUs.


Send profile should send resume in the mail

Currently send profile is only sending the job details which are applied and offers received. It should also send the resume of the applicant

Added the resume as an attachment in email functionality. Please test and close @akhilkumarmengani

@niveditalodha This feature works great! :-D


feat: add image support to groq

This PR contains:

[X] New features
[ ] Changes to dev-tools e.g. CI config / github tooling
[ ] Docs
[ ] Bug fixes
[ ] Code refactor

What is the current behavior? (You can also link to an open issue here)
Groq only supports text queries
What is the new behavior?
Groq now also supports images!!
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:

@jjallaire @jjallaire-aisi it would be much appreciated to have this in a new release soon - it would be very helpful for some of the stuff we're doing at Groq 🫡

This is now merged to main. We are planning on a PyPI release sometime tomorrow.


Allow configs changes without language server restart

Purpose

Allow configs changes without language server restart

Fixes #21336
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #21418 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master   #21418   +/-   ##
=======================================
  Coverage   14.64%   14.64%
=======================================
  Files          51       51
  Lines        1400     1400
  Branches      214      214
=======================================
  Hits          205      205
  Misses       1179     1179
  Partials       16       16

Impacted Files
Coverage Δ

tool-plugins/vscode/src/extension.ts
0% <0%> (ø)
:arrow_up:

tool-plugins/vscode/src/core/extension.ts
28.03% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eddb0f...ad63fe7. Read the comment docs.


Add Traffic Ops Golang user/current

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1798/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1806/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1848/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1940/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1941/
Test PASSed.

This pr is ready to go, manually verified and all tests pass.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2009/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2010/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2011/
Test PASSed.


Docker - Do not use pre-release versions of Agent

Agent Version and Platform
Ubuntu 20.04
Agent Version 2.198.2
Azure DevOps Type and Version
Azure DevOps
What's not working?
We are using the self-hosted agent running in a container. When our agents spin up, they are installing a pre-release version of the agent. Specifically, version 2.198.2, which is marked as a Pre-release. Is there a way for us to ignore pre-release versions and use the latest released version of the agent?
The start.sh from https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/docker?view=azure-devops#create-and-build-the-dockerfile-1 has this logic:
AZP_AGENT_PACKAGES=$(curl -LsS \
    -u user:$(cat "$AZP_TOKEN_FILE") \
    -H 'Accept:application/json;' \
    "$AZP_URL/_apis/distributedtask/packages/agent?platform=$TARGETARCH&top=1")

When I run the same command, it is pulling back 2.198.2. Ideally, we have a way to ignore pre-release versions of the agent.

Hey @jsheetzati, the pre-prerelease state is a part of our deployment process and actually means that we are not completed the deployment of the agent for all customers. Here is some more info about our deployment states.

Thanks @EzzhevNikita, I missed that.


Set auto releases

https://localheinz.com/articles/2022/01/24/creating-releases-with-github-actions/

Did not work


QuickStart: could not get past dependency checker on windows 10

Dev Home version
No response
Windows build number
No response
Other software
No response
Steps to reproduce the bug
Install VS Code
Install Docker
Install container plugin

Expected result
No response
Actual result
Despite going to the website and choosing install,
VSCode knows it is installed.
But the dependency checker does not.

Maybe i need to reboot
Included System Information
No response
Included Extensions Information
devhome20240510.zip

Issues seems to be that I needed to reboot.

Thanks! Based on the repro, it looks like you installed each dependency in sequence. Docker Desktop does require a reboot to complete its setup (its installer should have asked you, if I remember correctly), so rebooting for that specifically is expected.
For detection of the remote container extension: we rely on invoking Visual Studio Code to tell us what extensions are installed- and if you installed Visual Studio Code right beforehand as your steps indicate, I suspect that the PATH had been updated but Dev Home still had the 'prior' path from when its process was created- so it couldn't find code.cmd and thus couldn't run that check. There's an error to that effect in the logs, which I believe is related to this (we also have a string interpolation bug in the log which I'll fix):
[2024/05/16 12:10:45.743 ERR] (InstalledAppsService) Unable to find Visual Studio Code's launcher in path.
Restarting Dev Home should be a workaround for that (it'll pick up the updated PATH, find code.cmd, and then be able to find the extension from there). We hit this problem internally in testing and know that this needs to be better, so we will use this issue to help track improving that aspect of the detection logic.


Dashboard is empty

The configured home route is the jetstream dashboard. At the moment, this page is empty. We should brainstorm content for this page, provide a placeholder for future content, or perhaps even scrap it for now and make the profile the home route.

The current exploratory effort now is to build out documentation for team-specific functions and provide these links on the dashboard. For example, a wiki editor will see a set of guides related to common tasking in the admin panel.


Overhaul XRootD GridFTP install

This PR tries to make the XRootD GridFTP material minimally not-bad.
The old GridFTP installation document basically contained:

Generic GridFTP install documentation (better written elsewhere).
Copious suggestions that SRM is the Big Thing that should be installed (nope).
Installation directions for GridFTP on XRootD.
Install instructions for XRootD FUSE mounts.  (Not GridFTP related)
Install instructions for an alternate security mechanism.  (Not GridFTP related)

Of these, only (3) was actually relevant.  Note what the GridFTP document didn't contain: how to configure GridFTP!
Accordingly, this commit reworks the content to contain just GridFTP/XRootD install and configuration instructions, and places the additional content elsewhere.

Travis-CI failures appear unrelated.

@brianhlin - OK, I think this one is ready to go.

It LGTM but I think you missed my question about adding a "installation with xrootd" subsection in the GridFTP doc with a link pointing to the "install gridftp" section of the xrootd doc

Gotcha - I just added a cross-reference in the GridFTP install doc to the XRootD section (same thing that already existed for HDFS).


EnPackageDecl is not documented

The command EnPackageDecl is not documented. In my case its not working, so not able to figure out what it is doing.

This is basically the same issue as what #231 now represents, but that one ought to be renamed to make that clearer—I'll do that now.


add support for mergeObjects operator

As per https://github.com/mongomock/mongomock/issues/642
The current implementation follows the operator as defined such that on all null an empty doc is returned, and the docs are merged using dict.update method

removed mergeobjects exception checking tests and added a single test__merge_objects under the aggregate tests

removed mergeobjects exception checking tests and added a single test__merge_objects under the aggregate tests

Thanks, almost there. Please fix the remaining styling issues
https://travis-ci.org/github/mongomock/mongomock/jobs/754673610

Thanks, almost there. Please fix the remaining styling issues
https://travis-ci.org/github/mongomock/mongomock/jobs/754673610

Thanks @elbehery95 for the hard work!

Thanks @elbehery95 for the hard work!


IDL Parser: Add support for read-only attributes in namespaces

Towards #73. See https://heycam.github.io/webidl/#idl-namespaces for spec details.

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #74   +/-   ##
======================================
  Coverage    94.6%   94.6%
======================================
  Files          95      95
  Lines         797     797
======================================
  Hits          754     754
  Misses         43      43

Impacted Files
Coverage Δ

lib/org/chromium/webidl/Parser.js
95.45% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2280e2a...17830d6. Read the comment docs.


Should decorators be implemented?

@fkleuver Is this needed? You mentioned it in this issue ticket.  In any case it has to land in 2.1 after you push 2.0 to NPM.

No, not yet. Decorators are still in a lot of flux.

Any idea when the specs are ready for an implementation? I implemented decorators in my private project, and yes I ran into several funny scenarios.

Stage 3 is usually when it’s time for implementation; they’re still at stage 2.


Feature/test

Critical Changes
Changes
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata

No longer required - (Just to check the access)


How to call multiple scripts

I can use script_name and script_args to call a script and make it effective. If there are multiple scripts, how do I use them? For example, if I want to add Lora layer control on XYZ, what should I do?

Will consider if webui API supports it.


Updated cat.describe() and linked every columns

Minor update of all linkages and describe function.
Additionally removed errors and added things for consistency.

Updated some things in the columns description
added the protocol with Alex, with some extensions :)


Populate the Shared Services DAPA Client ID SSM param in a Venue Deployment

Luca said he needs this:
/unity/shared-services/dapa/client-id
The naming will be different, and @mike-gangl is going to help think about the approach of how these get populated in Shared Services account.
U-CS would populate this value to the Venue AWS account, upon deployment, by looking at the value in the proper shared services account.

This value is already populated in the unity-venue-dev shared services accounts as /unity/shared-services/dapa/client-id.
It is an advanced SSM parameter, and can be viewed by the venue account.

This has also now been populated for the unity-test account.

and also for unity-prod.  This ticket is now complete.


Changing series type from area to line doesn't work

One-line summary [问题简述]
Version & Environment [版本及环境]

ECharts version [ECharts 版本]:
Browser version [浏览器类型和版本]:
OS Version [操作系统类型和版本]:

version 3.4.0
Chrome
Expected behaviour [期望结果]
Replacing options on existing chart changing series from area to line doesn't work. Chart still renders areas. Two set of options below. Render first set, then call chart.setOption() with second set.
ECharts option [ECharts配置项]

Option 1:
{"legend":{"data":["dude 1","dude 2"]},"series":[{"name":"dude 1","stack":"x","type":"line","itemStyle":{"normal":{"areaStyle":{"type":"default"}}},"data":[442333,442333,442334,1062500,2162500,3112500,4362500,22000000,22000000,22000000,22000000,26000000,21680727,22708525,28000000,33000000,33000000,32000000,30000000,29000000]},{"name":"dude 2","stack":"x","type":"line","itemStyle":{"normal":{"areaStyle":{"type":"default"}}},"data":[109000,109000,187500,350000,1500000,3000000,3600000,4850000,6375000,6725000,6975000,316000,850000,1500000]}],"yAxis":[{"name":"Salary","type":"value"}],"xAxis":[{"name":"Year","type":"category","data":[1994,1995,1996,1997,1998,1999,2000,2001,2002,2003,2004,2005,2006,2007,2008,2009,2010,2011,2012,2013]}]}```

```javascript
{"legend":{"data":["dude 1","dude 2"]},"series":[{"name":"dude 1","stack":"x","type":"line","itemStyle":{"normal":{"lineStyle":{"type":"solid"}}},"data":[442333,442333,442334,1062500,2162500,3112500,4362500,22000000,22000000,22000000,22000000,26000000,21680727,22708525,28000000,33000000,33000000,32000000,30000000,29000000]},{"name":"dude 2","stack":"x","type":"line","itemStyle":{"normal":{"lineStyle":{"type":"solid"}}},"data":[109000,109000,187500,350000,1500000,3000000,3600000,4850000,6375000,6725000,6975000,316000,850000,1500000]}],"yAxis":[{"name":"Salary","type":"value"}],"xAxis":[{"name":"Year","type":"category","data":[1994,1995,1996,1997,1998,1999,2000,2001,2002,2003,2004,2005,2006,2007,2008,2009,2010,2011,2012,2013]}]}

Other comments [其他信息]

You need to remove areasStyle, in ECharts, line series with areaStyle will be drawn as a area chart

i don't think i'm making it clear
i have chart instance and i call chart.setOption(option1), the intent is to display area chart, which it does
next i call chart.setOption(option2) with intent to display line chart. As you can see areaStyle is not set on option2 but chart still renders area.
it would work as expected if i call chart.clear() before chart.setOption(option2) but this does complete re-render.

Sorry for mistaken it. You don't need to clear the chart. Try
chart.setOption(option2, true)

the second parameter means whether to replace the previous option. If it is false, which is default value, new option will be merged. And the areaStyle will also be kept.

Perfect, this worked! Thanks for your help!


Add controller launch file

Let's test this before review

Also please compare what we have here with what we have in the odom_launch_test branch (https://github.com/gtagency/buzzmobile/compare/odom_launch_test?expand=1#diff-70ded371a262786239dd11de118c2c46R5) as we modified the latter for debugging during testing yesterday and it might have important changes that we need here.

If you want to clean up this PR and then make another one with more highlevel launch files, I'm ok with that. You can have all the subsystems launch files in buzzmobile/launch/subsystems/controller.launch etc, then you have a  buzzmobile/launch/main.launch that includes the subsystems like so:
<launch>
	<group>
		<include file="$(find buzzmobile)/launch/subsystems/controller.launch" />
		<include file="$(find buzzmobile)/launch/subsystems/lidar.launch" />
		etc
	</group>
</launch>


Update README.md

Added Data structure and algorithm for C++- DevTown
by creating issue- #542

sorry we are not adding google form registeration courses


All tests should use string UIDs rather than integer UIDs

The following unit test:
@pytest.mark.parametrize("model_uid", rand_l(1, 500, 5))
def test_set_cube_uid_keeps_passed_uid_intact(
   mocker, default_setup, model_uid, comms, ui
):

Passes sometimes and fails sometimes.
It can be found in the script:
 medperf/cli/medperf/tests/commands/test_compatibility_test.py
Most probably it fails for certain parameters that are randomly generated. To reproduce, replace  rand_l(1, 500, 5) in the parameterization with the list [20,47,45]. The following errors will be raised:
FAILED test_compatibility_test.py::test_set_cube_uid_keeps_passed_uid_intact[20] - AssertionError: assert 'test_1651680003' == 20
FAILED test_compatibility_test.py::test_set_cube_uid_keeps_passed_uid_intact[47] - AssertionError: assert 'test_1651680003' == 47
FAILED test_compatibility_test.py::test_set_cube_uid_keeps_passed_uid_intact[45] - AssertionError: assert 'test_1651680004' == 45

This bug is caused by passing model_uid as an integer rather than a string.
model_uid was passed to the os.path.exists function during the test. os.path.exists for python3.3+ treats integers as open files descriptors, so it returns True for some integers, causing the model_uid to change to a temporary UID that causes the assertion error.
All tests should be fixed to avoid any misleading future test failure.

Awesome catch Hasan! What do you propose for this?
I'd say we need to make it explicit that the input to the function that is misbehaving should be a string. Maybe throw an error otherwise?


Add unit tests to test GET changes timeout

Added unit tests to test GET changes timeout for both longpoll and continuous feed.

Reimplemented LiteTestCaseWithDB.parseJSONResponse() method to parse response body from connection.getResponseInputStream() InputStream instead of from connection.getResponseBody() which will not always have value especially when Router is writing the result to the connection’s OutputStream directly.

https://github.com/couchbase/couchbase-lite-java-core/issues/1296

ready to be merged once https://github.com/couchbase/couchbase-lite-java-core/pull/1384 is merged.


[BUG] image-width or image-height properties on .gif image widget doesn't seems to change size

Checklist before submitting an issue

[x] I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
[X] I have specifically verified that this bug is not a common user error
[X] I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug
Using the image widget
I can't render an animated image (in gif format), it just doesn't appear on screen, and shows no error on eww logs
Reproducing the issue
(image
    :path "/path/to/image.gif"
    :image-width 256
    :image-height 256
)

Expected behaviour
Seeing the image animated
Additional context
No response

i am able to render gifs this way, animated or not. can you provide more info?
does the image tag render other images?

Ok that's weird, it renders now! (and i think i understand why it didn't earlier) but i still encountered one issues : image-width and image-height properties doesn't change the size of the image
And it doesn't output anything to the eww logs
Should i open another issue, or edit the original post (i just changed the title for now) ?
Reproducing the issue
(defwindow giftests
	:monitor 0
	:windowtype "overlay"
	:geometry (geometry
		:width 512
		:height 512
		:anchor "center"
	)
	(image
		:path "/path/to/image.gif"
		:image-width 50
		:image-height 50
	)
)

~ > eww open giftests

Then change image-width and image-height to another value
Additional Context
I'm on wayland
~ > eww --version
eww 0.4.0 d58d91de78d2b9984a1bbb8314be197bc0e283dc

~ > uname -srmo
Linux 6.7.1-arch1-1 x86_64 GNU/Linux

what sort of output were you expecting from eww logs?
i set up this test
(defwindow giftests
	:monitor 0
	:windowtype "overlay"
	:geometry (geometry
		:width 512
		:height 512
		:anchor "bottom left"
	)
	(image
		:path "/home/grace/jam.gif"
		:image-width 50
		:image-height 50
	)
)

(defwindow control
	:monitor 0
	:windowtype "overlay"
	:geometry (geometry
		:width 512
		:height 512
		:anchor "bottom left"
	)
  (box
    (button 'foo')
    (button 'bar')
  )
)

and eww logs is outputting
 2024-01-31T22:09:52.234Z INFO  eww::app        > Opening window giftests
 2024-01-31T22:09:53.153Z INFO  eww::app        > Closing gtk window giftests
 2024-01-31T22:09:55.000Z INFO  eww::app        > Opening window control
 2024-01-31T22:09:55.808Z INFO  eww::app        > Closing gtk window control

The sizing does definitely seem to be an issue though.

what sort of output were you expecting from eww logs?

I didn't expected much, but maybe an internal error from the image handler

I think i found the issue in code :
https://github.com/elkowar/eww/blob/master/crates/eww/src/widgets/widget_definitions.rs#L521
const WIDGET_NAME_IMAGE: &str = "image";
/// @widget image
/// @desc A widget displaying an image
fn build_gtk_image(bargs: &mut BuilderArgs) -> Result<gtk::Image> {
    let gtk_widget = gtk::Image::new();
    def_widget!(bargs, _g, gtk_widget, {
        // @prop path - path to the image file
        // @prop image-width - width of the image
        // @prop image-height - height of the image
        prop(path: as_string, image_width: as_i32 = -1, image_height: as_i32 = -1) {
            if path.ends_with(".gif") {
                let pixbuf_animation = gtk::gdk_pixbuf::PixbufAnimation::from_file(std::path::PathBuf::from(path))?;
                gtk_widget.set_from_animation(&pixbuf_animation);
            } else {
                let pixbuf = gtk::gdk_pixbuf::Pixbuf::from_file_at_size(std::path::PathBuf::from(path), image_width, image_height)?;
                gtk_widget.set_from_pixbuf(Some(&pixbuf));
            }
        }
    });
    Ok(gtk_widget)
}

If the file ends in .gif, an animation is created with no size parameters (PixbufAnimation::from_file), but if the file is not a gif, Pixbuf::from_file_at_size is used

Yeah, I saw that, but there is no equivalent resizing function for the pixbuf_animation, and I couldn't find good docs for it.


Python rewrite

Sorry, I couldn't resist. Don't worry about saying "thanks, but no thanks"; I won't mind. If you're interested, here's what I did:

Modified the syntax to python (i.e. minimze git diff --word-diff) with all tests passing
Change to a full pythonized version with all tests passing
Added full float support (gh-28); this changed the sparkles slightly
Added support for negatives

This all is about an order of magnitude faster:
/tmp/spark $ time ./spark -- '0,10,100,1,10,1,10,20,10,40,50,30,10,30,50,60,40,20,304,50,40,50,50'
▁▁▃▁▁▁▁▁▁▂▂▁▁▁▂▂▂▁█▂▂▂▂

real	0m0.023s
user	0m0.013s
sys	0m0.010s
/tmp/spark $ time ./spark.sh -- '0,10,100,1,10,1,10,20,10,40,50,30,10,30,50,60,40,20,304,50,40,50,50'
▁▁▁▃▁▁▁▁▁▁▂▂▁▁▁▂▂▂▁█▂▂▂▂

real	0m0.290s
user	0m0.092s
sys	0m0.229s

If this is something that anyone wants to consider, my next step would be to remove print_tick loop, since with float support we can compute the tick directly.
But now I should get back to real work. :)

Cool.

Streams in 7879797. ;) Thanks for the distraction!


#1253 Include qualification certificates in candidate profile

What's included?
THIS IS CURRENTLY A WORK IN PROGRESS PR SO NOT READY TO TEST NOR CODE REVIEW!!
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Describe the steps required to test & verify this change
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Include screen grabs, notes etc.

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Awaiting feedback from @nickaddy after speaking to JAC about whether need to have a certificate per qualification

@drieJAC I confirm that we only need to support the current setup whereby candidates can upload a single practising certificate and/or a single exemption certificate; moving back to sprint backlog.


Issue40 fixing: code splitting into subfolder/subfiles

Hi,
This Pull Request divides the SlicerCART.py main code into different files/subfolders from code main branch version d2714db (actual main).
Rationale: to facilitate further development and organization.
Difficulty: to avoid circular imports related to interaction between classes from initial code.
Why this ‘EPIC’ PR instead of incremential changes?: interactions between classes makes it more complex to deal with code subdivision in different files, increasing a lot the complexity and expected time to solve the issue.
What has been done:
Code division in different files, but otherwise no change in the code. That means that this PR makes using SlicerCART identifcal as from the actual main branch code (so, same use, same functionalities, same bugs but with code splitted). In that context, this PR:

Introduces subfolder ”utils”. Contains:
- requirements.py --- listing of all modules required to import for using SlicerCART (can be upgraded in the future)
- install_python_packages.py --- function that check and install required packages for using SlicerCART
- global_variables.py --- listing of all global variables in the module
- init.py --- enables all subfolder “utils” content importation

Introduces subfolder “scripts”. Contains:
1. InteractingClasses.py --- This NEW file contains all classes that interact with each other from the initial module, including:

SlicerCARTConfigurationSetupWindow
SlicerCARTConfigurationInitialWindow
ConfigureSegmentationWindow
ConfigureSingleLabelWindow
ConfigureClassificationWindow
ConfigureSingleClassificationItemWindow

N.B.  The scheme below describes the hierarchical organization between interacting classes.

N.B.  That means other classes from the initial code do not provide circular import issues. For further development, any file in the scripts repository should contain 1 class. In other words: 1 file == 1 class ; this will be added in the developer guide.

Multiple pythons files listing one class per file, including:

CompareSegmentVersions.py
CustomInteractorStyle.py
LoadClassificationWindow.py
LoadSegmentationwindow.py
OptionalMethods.py
ShowSegmentVersionLegendWindow.py
SlicerCARTLogic.py
SlicerCARTTest.py
Timer.py

Once this PR will be merged into the main branch, then optimized further development can be achieved.
Thanks!

Is reloading more complex with this code splitting ? I am looking at the discussion https://discourse.slicer.org/t/is-it-possible-to-split-a-python-extension-into-multiple-files/21713/7
Was this tested ?

Hi! @Kuan I addressed your comments. Now it should work regarding the check_and_install_python_package(). In fact, you were right: it was not called! (now it is directly in the requirements.py ) @LLG : yes. In the initial PR commit, this was not tested. However, now it is (on my side, no issue); Regarding re-organization, the order of module importing and reloading has been the same as it was originally (linear): no deviation has been made regarding this point.

Did some tests and reloading also works on my end too (no need to restart Slicer).

Ok great! So, waiting for further feedback/other comments from @LLG about this PR (and/or approval) before merging!

My main issue right now is how modules are imported.
The from module import * will make the code harder to maintain with potential namespace conflict. I think this should be changed beforme merging the PR. What do you think ?

Ok good point. Available now for calling if you prefer. I ve looked into SlicerHeart. I am not an expert, but a good point is that they import only the functions that they need, at multiple locations. However, this would make very difficult to address in the SlicerCART module since it has been created in one main file so we cannot traceback (without extensive debugging work) when each imported module is used ... (would require weeks) I organized that way so if further modules are imported, then it can be added under the requirements.py file and will be accessible from each other file/main slicer cart in the module. I totally agree that it would be better to use import utils (for example) instead of from utils import * : however, this would also require the use of extensive code reviewing due to how SlicerCART has been initially developed... What do you think? Are you available for a Teams?


Webhook Wrappers

The payloads that come through from Webhooks are slightly different than the models. For example, here's the payload from the session creation webook:
{
  "id": "ID here",
  "object": "event",
  "api_version": "2020-03-02",
  "created":<PHONE_NUMBER>,
  "data": {
    "object": {
      "id": "ID here",
      "object": "checkout.session",
      "billing_address_collection": null,
      "cancel_url": "URL Here",
      "client_reference_id": "Client Ref Here",
      "customer": "Customer ID Here",
      "customer_email": null,
      "display_items": [],
      "livemode": false,
      "locale": null,
      "metadata": {
      },
      "mode": "payment",
      "payment_intent": "Payment Intent",
      "payment_method_types": [
        "card"
      ],
      "setup_intent": null,
      "shipping": null,
      "shipping_address_collection": null,
      "submit_type": null,
      "subscription": null,
      "success_url": "Success URL here"
    }
  },
  "livemode": false,
  "pending_webhooks": 2,
  "request": {
    "id": null,
    "idempotency_key": null
  },
  "type": "checkout.session.completed"
}

This almost matches the required structure for StripeSession, but has the extra wrapper around it (i.e. root.data.object matches StripeSession).
For the time being I've been decoding this:
struct StripeWebhookObject: Content {
    let data: DataObject

    struct DataObject: Content {
        let object: Object
    }

    struct Object: Content {
        let client_reference_id: String?
        let customer: String?
    }
}

Which works just fine, so not urgent or anything, but it might be nice to provide webhook decodable wrappers.

Closing this since it's not an issue and just confusion with how to pull the data out.
for future reference something like this can be achieved for checking webhook payloads.
func handleStripeWebhooks(req: Request) throws -> EventLoopFuture<Response> {
        try StripeClient.verifySignature(for: req, secret: "whsec_1234")
        // Stripe dates come back from the Stripe API as epoch and the StripeModels convert these into swift `Date` types.
        // Using a custom decoder to successfully parse out the time.
        let decoder = JSONDecoder()
        decoder.dateDecodingStrategy = .secondsSince1970
        let event = try req.content.decode(StripeEvent.self, using: decoder)

        switch (event.type, event.data?.object) {
        case (.accountUpdated, .account(let account)):
            return req.eventLoop.makeSucceededFuture(Response(status: .ok))

        case (.paymentIntentSucceeded, .paymentIntent(let paymentIntent)):
            print("Payment capture method: \(paymentIntent.captureMethod?.rawValue)")
            return req.eventLoop.makeSucceededFuture(Response(status: .ok))

        default: return req.eventLoop.makeSucceededFuture(Response(status: .ok))
        }
    }


On the fly

Is there any way we could use this on the fly?
For example we got raw H264 bytes (NAL units), pass them to the muxer and get back bytebuffer / bytearray ?
I couldn't really find anything in the source which will allow this.

I'd also be interested in storing received H.264 stream in real time over a network to an mp4 file...
As far as I understand, mp4parser works with finite audio/video files as input, not streams.


Tooltip sometimes not showing on hover of text underlined

Tooltip not showing on underlined error in some cases
Describe the bug
There seems to be an issue where the error tooltip does not appear when hovering over underlined text in certain situations. It's unclear what specific conditions trigger this problem.
To reproduce
Steps to reproduce the behavior:

Go to https://mkslanc.github.io/ace-linters/default_services.html
Hover over the underlined word "os" in the Python code example. No tooltip appears.
Similarly, go to https://mkslanc.github.io/ace-linters/webworker.html
Hover over the underlined word "country". Again, no tooltip is displayed.

Expected behavior
Hovering over underlined text that indicates an error should consistently display a tooltip explaining the error / info / warning.

@Jxhnn hey! Should be fixed in new version


Limit DID VerificationMethods to specific key types and encodings

We have some language limiting the key formats to secp256k1 and ed25519, but nothing about a consistent key format in the DID Documents.
I think we should also limit the DID Document's Verification Method types to JsonWebKey2020 or EcdsaSecp256k1VerificationKey2019, using the publicKeyJwk field instead of publicKeyMultibase or a deprecated field.

Related to this, there's an extension DID resolution option called "transformKeys", which you can use to instruct a resolver to convert between key formats. E.g. if a DID method uses EcdsaSecp256k1VerificationKey2019 in its DID documents, then a resolver can convert that to JsonWebKey2020.
See here: https://github.com/decentralized-identity/did-spec-extensions/blob/main/parameters/transform-keys.md

@peacekeeper: I saw that, and I can't tell if it's been implemented anywhere, or just described.   "transformKeys" as a string doesn't appear anywhere in decentralized-identity outside of documentation.
Do you know if anyone has a resolver which actually does that?  It seems like it would be very expensive to implement as described.

I think we should also limit the DID Document's Verification Method types to JsonWebKey2020 or EcdsaSecp256k1VerificationKey2019, using the publicKeyJwk field instead of publicKeyMultibase or a deprecated field.

I would be in favor of a simpler solution of limiting Verification Method types as proposed above.

I'm also in favor of this for compatibility.

@dwight-holman to make PR as proposal to discuss in next meeting

if key types are bound to DID methods rather than signature suites, I think we can address the issue of limiting to JWK, and not mandating multibase (any one can still implement it outside this profile) in a way other than mentioning concrete sig suites? ie just clarify, JWK is used with the DID methods currently chosen in the spec.


Prefixing collectors and dimensioanlising them

Adding some of the metric names to the main namespace is a very bad idea
for example the EntropyCollector had the metric => 'available' in the
main name space that is really frustrating.
Also since we now have support for dimensions, I have incorporated
dimensionalising the collectors that have been recently newly migrated from
Ganglia and those that existed but have been touched due to the
migraiton.

These migrations have been very carefully tested. Since most of their tests were not working to start with for reasons of initial migraiton of diamond to fullerite .. I am not going to make the unit tests pass for this change because that will mean making them pass first for the old state. I am willing however to do a full revmap of the tests at a later time making them all pass as to allow running the tests part of Travis CI.
as per METRICS-95

Seems all legit to me, but I don't have much info about the form of this metrics. I'm cool if you said you carefully tested it.

Looks good T. Would we want to address this for the NetworkCollector or is having them namespaced by interface good enough? Currently it's 'eth0.tx_bytes' etc. which is then dimensionalized by host etc down the pipeline (I think).

@tiras-j NetwrokCollector as far as I know is sane enough as eth0, eth1 ..etc although I would prefer those to be dimensions, it seems users like them more this way, I am not heavily opinionated here, what do you think?

FYI: not all of the collectors have been prefixed, only those that make sense to do so. for example TCPCollector has metrics that are unique enough to it that prefixing them would be ugly, same with osdistro and others that are meaningless to prefix.

@tsheasha Yea I agree, and since this isn't a new collector we already have those timeseries in SFX, better to stick with em. All we added was the 'tun' interface I believe.

I will not merge this specific PR without at least 3 ship its
since it is important enough

@zachm @venkey-ariv what do you think? ship?

@tsheasha out of curiosity, why do you think users like more "eth0" in the name of the metrics than as a dimension? I agree with you on the fact that it seems more a dimension.

well @poros using the network interface as a dimension specifically is counter intuitive for all the network nerds I spoke to.
they are so much used to this representation that anything else will make them confused for a bit. That is why I thought of leaving this out of the dimensionalisation. Also the fact that having this as part of the metric name is not that ugly imho, it's not like eth0.hostname.bla .. although that is a very poor argument :)
I am still hesitant whether to keep it as a metric name or move it to a dimension, so I am up for a reason to help push me either way.

This biggest reason I can think of to keep it as is would be changing it will break charts for everyone already using this data. But yea interface would definitely make more sense as a dimension, and have something like 'network.tx_byte' and then you could filter on interface. I'm guessing we'd want some kind of namespacing rather than putting just 'tx_byte' out there.

@tiras-j breaking charts is fine as long as we can easily rebuild them. However what do you think about the readability issue I mentioned, that network oriented people are used to metrics this way more than I would imagine.?

@tsheasha I feel like they'd adapt just fine, and conceptually it would be nice to clean up our global namespace a bit. But then again if our metrics are not ergonomic for the user what's the point? Should we ping #neteng for their thoughts?

alright I have changed that collector to be prefixed with network.
and dimensionalised the iface

Ship it!


Push to Docker Registry broke our build

Do you want to request a feature or report a bug?
Bug.
What is the current behavior?
When our CI process runs where we docker-compose graph-node repo to set up a local instance of the subgraph, it breaks.
Here is the specific error:
Store error: query execution failed: Subgraph `Qmbj5GncTD5fyFid6V2Gpj8tCzffUatY22eckJQiR9iqzY` has not started syncing yet. Wait for it to ingest a few blocks before querying it: {"response":{"errors":[{"message":"Store error: query execution failed: Subgraph `Qmbj5GncTD5fyFid6V2Gpj8tCzffUatY22eckJQiR9iqzY` has not started syncing yet. Wait for it to ingest a few blocks before querying it"}]

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
https://github.com/superfluid-finance/protocol-monorepo/actions/runs/3190729992/jobs/5206222908
Here is the failed build with the exact same code as the working build below.
What is the expected behavior?
https://github.com/superfluid-finance/protocol-monorepo/actions/runs/3189691780/jobs/5203801204
Here is a succesful build with the same code as above.

hello, we are still running into the same issue with v0.28.1: https://github.com/superfluid-finance/protocol-monorepo/actions/runs/3280227780/jobs/5400752721 - just wanted to give you a heads up

We released v0.28.2 a few hours after v0.28.1, you may want to try that!


NewPR

Let's also update the Makefile to add test-engine rule such that it will run the test for engine Gradle sub project.


Investigate bad token

It looks like EthPad is causing issues in simulation (https://dashboard.tenderly.co/gp-v2/staging/simulator/754fd516-3e5e-456b-9aeb-8e80c3813b81) but is not classified as a BadToken.
Order: https://gnosis-protocol.io/orders/0x861df8015564d4c96e191316b47849124350919b7a7120f66368e3cdd8f3d212788356e5d2abb4646d253eb02973f08c0b06d444611b6594
Should investigate what is going wrong and whether we can detect it.

The code for the contract is https://etherscan.io/address/0x9ed27d7f260ee52668b209a15159045011c8d007#code .
As Nick said on Slack:

If the recipient is a pair and it isn't excluded, then it takes some fees on transfer. As such, the GPv2Settlement -> UniPair  transfer if taking a fee. But the bad token detector checks if some account -> GPv2Sttelement transfer is OK. (correct me if I'm wrong).

We test the transfer from the pool to the settlement contract and from the settlement contract to an address that doesn't own the token. The token takes fee on transfer to some addresses (not excluded pools) which we don't detect. This is something we in general cannot detect as their is no guarantee what pool address we pick in the detector.

Makes sense.
While there is no guarantee, if we implemented #858 there would be a good chance that the simulated baseline path would be the same as the final solution (at least it means there exists a valid path - removing bad pools based on simulation failure is another pandora box).


Feture request: Add a wrapper for the go executable

Hi Daniel,
/usr/bin/go in the go package in Arch Linux supports the -buildmode=pie argument.
While PIE is not as critical for security for Go executables as for C executables, it might be nice to have the option of also hardening Go package just by depending on hardening-wrapper (it's a nifty idea in the first place!).
Please consider adding a wrapper script for go as well.
There's a related discussion at this bug report: https://bugs.archlinux.org/task/53087
Best regards,
Alexander F Rødseth

hardening-wrapper is now deprecated as Arch will be adopting these features in the standard toolchain.


Fix representation of literal enums (#1747)

Change Summary
Fix for Literal enum values does not respect the use_enum_values config
Related issue number
#1747
Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[x] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)

I still don't know what is the expected behaviour with Literal and use_enum_values.
We could have simply changed make_literal_validator into
def make_literal_validator(type_: Any, config: Type['BaseConfig']) -> Callable[[Any], Any]:
    permitted_choices = all_literal_values(type_)
    allowed_choices_set = set(permitted_choices)

    def literal_validator(v: Any) -> Any:
        if v not in allowed_choices_set:
            raise errors.WrongConstantError(given=v, permitted=permitted_choices)
        return v.value if isinstance(v, Enum) and config.use_enum_values else v

    return literal_validator

but it would have meant that both fields in model
    class Model(BaseModel):
        baz: Literal[FooEnum.foo]
        boo: FooEnum = FooEnum.foo

        class Config:
            use_enum_values = True

would be considered the same.
With your implementation, they are equal only for dumping (dict())

Ok, I see. Perhaps @samuelcolvin or someone else could give an opinion on the best way to proceed?


chore: Release 0.14.1

:robot: I have created a release beep boop
root: 0.14.1
0.14.1 (2023-06-07)
Features

Re-use intermediate variables created during width reduction, with proper scale. (#343) (6bd0baa)

acir: 0.14.1
0.14.1 (2023-06-07)
Features

Re-use intermediate variables created during width reduction, with proper scale. (#343) (6bd0baa)

Dependencies

The following workspace dependencies were updated

dependencies

brillig_vm bumped from 0.14.0 to 0.14.1

acir_field: 0.14.1
0.14.1 (2023-06-07)
Miscellaneous Chores

acir_field: Synchronize acvm versions

acvm: 0.14.1
0.14.1 (2023-06-07)
Features

Re-use intermediate variables created during width reduction, with proper scale. (#343) (6bd0baa)

acvm_stdlib: 0.14.1
0.14.1 (2023-06-07)
Miscellaneous Chores

acvm_stdlib: Synchronize acvm versions

brillig_vm: 0.14.1
0.14.1 (2023-06-07)
Miscellaneous Chores

brillig_vm: Synchronize acvm versions

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/root-v0.14.1 :sunflower:

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/acir-v0.14.1 :sunflower:

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/acir_field-v0.14.1 :sunflower:

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/acvm-v0.14.1 :sunflower:

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/brillig_vm-v0.14.1 :sunflower:

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/acvm_stdlib-v0.14.1 :sunflower:


JS Errors in 0.4.9

I'm using the latest version of rail_admin (0.4.9) and rails 3, and the js on the page just won't work.
It's being caused by a problem with how the bootstrap js is being loaded, but how do you fix it, and why is it happening?
Here's a screenshot of the error. This erros means I can't use the "add filters" menu.
cheers

Please reopen if the problem still exists.


Delete Stripe customer by deleting Firestore customer file

Feature request

firestore-stripe-subscriptions

Is your feature request related to a problem? Please describe.
Yes. Firebase already has an extension that allows for data (besides the authentication account) to be removed upon account deletion.
Describe the solution you'd like
If removing the customer file within Firestore would send a trigger to delete the customer on the dashboard, that would be the best solution.
Additional context
https://firebase.google.com/products/extensions/delete-user-data
P.S. I'm so thankful for this extension. It really makes my life 400 thousand times easier. Keep up the phenomenal work!

Thanks @JakeMalis for the kind words and the feature request :)
We're hoping to add this as a fast-follow. One important detail is: how do we handle active subscriptions for a user that is being deleted?
Would love to hear your thoughts on that!

Maybe something like the cleanUp function here:
https://github.com/firebase/functions-samples/blob/master/stripe/functions/index.js
/**

When a user deletes their account, clean up after them
*/
exports.cleanupUser = functions.auth.user().onDelete(async (user) => {
const dbRef = admin.firestore().collection('stripe_customers');
const customer = (await dbRef.doc(user.uid).get()).data();
await stripe.customers.del(customer.customer_id);
// Delete the customers payments & payment methods in firestore.
const snapshot = await dbRef
.doc(user.uid)
.collection('payment_methods')
.get();
snapshot.forEach((snap) => snap.ref.delete());
await dbRef.doc(user.uid).delete();
return;
});

if i'm right a stripe delete customer automatically deletes customer subscriptions ?

Thanks @rikelk. Yes, deleting a customer will cancel all their subscriptions. Yes, I'll add something along the lines. Will need to verify if this works together with the existing Delete User Data extension, that would be ideal.

This has been added and should roll out with the next release on Thursday. Thanks again for your input! :)

@thorsten-stripe If it cancelled the user subscription when deleting the account that would be amazing. Thank you so much, keep up the amazing stuff!

Hi all, I'm going to humbly suggest that this change be backed out. Deletion of customer objects in Stripe is irreversible! Well, at least through their public API--though apparently sometimes permanently 😓. It's handled on a case-by-case basis through Stripe Support.
While yes, deletion of an Auth user would suggest a willingness to nuke data (there's no undoing the deletion of the user), there are scenarios where this may happen accidentally. I just added an issue 👆with one such example. We were migrating users from one Firebase project to another (as part of a monorepo reorganization). We had previously copied data from production into the new project for testing. The Stripe Firebase extension was enabled during the testing. On cut-over day, we cleared all data from the new Firebase project to have a clean slate to import all of the latest production data. The Auth users in the new project were not production yet, but they were connected to the live Stripe customers through the extension, and upon deletion all our live customers were deleted, all their payment methods were deleted, and all their subscriptions were cancelled.
Admittedly, I misstepped by not disabling the Stripe Firebase extension before beginning our cut over; however, that's kind of the point. Accidents happen in real life and it's our responsibility to enable fast recovery when they do. This feature is akin to foregoing database backups. Sure, you shouldn't delete data you still need, but what happens when you do?
For anyone who needs this functionality (GDPR, perhaps?), it is easily added via a short and simple cloud function. If we're using customer deletion for its side-effect of cancelling subscriptions, then I think we should just be cancelling subscriptions. You can always reactivate subscriptions cancelled in error.

Correction: Cancelled subscriptions cannot be reactivated.
Fortunately, Stripe Support was able to recover our deleted customers and their payment methods; however, there's no way to "un-cancel" all the subscriptions. So, we'll have to rebuild all of them from scratch. I think this confirms that automatic deletion of Stripe Customers is far too destructive an operation and shouldn't be the default behavior of this extension.


Extract css

Is  it possible to compile the script without and then use an external stylesheet.
It will mean using two lines of code instead of one to use the script but it will make it easier to customise the css to match the site

Hi @brianteeman,
I was thinking about exposing all CSS values as variables. That way they would be overridden in a convenient manner.
WDYT?

The ability to have an external css would be more useful/practical
When I look at the main requests we are receiving it would be much easier to resolve with external css.
Example requests are

support dark mode
change the main icon
change the tool iconsets

Can't imagine someone adding his own style for all elements of the component and all cases and functionality like iframe model, screen reader etc.
A much more healthier approach will be to override only what you want. It's currently possible but with the exposure of CSS variables it's going to be even easier.

support dark mode

Supporting dark mode is already possible and will be easy with CSS variables.

change the main icon

Not necessarily possible with CSS only anyways. You can currently use this:
 {icon: {
    img: 'my new text icon',
    fontClass: 'my new font class'
}}

The default value of img is accessibility.
The default value of fontClass is material-icons.

change the tool iconsets

It's currently impossible but we can enable it view CSS variables as well. The icons are actually the value of the content CSS attribute of a before pseudo element.
Having said that:

We will add a new parameter for suppressing the CSS injection (if not defined we will inject as usual) suppressCssInjection: boolean.
We will expose the injectCSS function.
We will expose a new function called removeCSS.

Just to satisfy all.

All I can say is that given the choice I would want to rewrite 100% of the css for my own use.
Changing the icon - currently you can only use a font icon from material-icons or an emoji - which is a limitation if I just wanted to use an svg or an icon from a font already loaded on the site.
So yes please to your proposal and for Joomla we will chose to supress the css injection

@brianteeman understood. Version 5.0.1 is live and ready. Please let me know if there are any issues.
Just for documentation sake, I would argue that you can change the icons to another set as described here without suppressing the original CSS.

Thanks. Will test over the weekend


Providing Border radius for better UI design in the cards of Documentation section

The cards are'nt attractive in below screenshot, applying border radius cann fix this.

@HimanshuNarware Please assign me under GSSOC'24.

@Suvam3456  Not needed now


Portuguese language support

Offers support for the portuguese language, changing the 'Loading' message to 'Carregando'.

Can you run gulp and gulp build and commit those files too?


[GEP-18] Do not rely on constant CA secret names and drop legacy coding

How to categorize this PR?

/area security
/kind enhancement
What this PR does / why we need it:
This PR changes the remaining code which was not yet adapted such that it no longer relies on the constant CA secret names but uses the new secrets manager instead.
With this now being done we can finally drop the entire legacy secret management (last commit) 🎉 . There is still some coding left to migration and backwards compatibility, though this will be dropped in subsequent releases as well.
Which issue(s) this PR fixes:
Part of #3292
Special notes for your reviewer(s):
:x: Depends on #5779, hence this PR is still in draft state.
Release note:

NONE

/cc @plkokanov

/assign


PNG files

Hey,
First of all, really great job!
I found out that not all the png files came with in the file directory of the slides which means that i cannot see all the content.
Do you have any solution for this?
Thank you!
Some example in attachment.

Hey,
Do you have the original slides from the course content? Can you inspect element and check what's the source of these files (i.e., where it's loading from). Should be in the network tab.
Unless it's external files being loaded. It should work just fine. Did you notice this behavior for multiple courses or just one? If its just this one, not much can be done.


Support for cargo rustc to build tests?

Is it feasible to support the new cargo rustc command as an alternative to rustc for running compile tests? It would mean significantly less pain specifying paths to dependencies. I tried to make it work with the existing options in compiletest::common::Config but to no avail, unfortunately.
(If you intend to keep the source of this crate as close to the upstream source in rust-lang/rust as possible, then this probably isn't an option, but I thought I'd ask anyway!)

Oh, shoot. I guess cargo rustc doesn't actually support compiling arbitrary source files. Phooey.


Button for message "Move bookmark here"

In Skype Desktop have helpful feature.
In chat possible right click on message and select "Move bookmark here" then this chat marked as unread start from selected message.
This helpful when impossible read all messages and then cancel read mark from message when stop read.
In e-mail also possible  mark messages as "unread".
Thanks.

@frg-tarasov We already have the ability to star messages, maybe that's what you were looking for?

I guess marking messages as "unread" is a little different from starring messages.

@synicalsyntax @lonerz Yes, star message mark one message, but  "Move bookmark here" in Skype all message frome point mark as "unread".


Error java.lang.NoClassDefFoundError: Failed resolution of: Landroidx/compose/runtime/PrimitiveSnapshotStateKt

this error :(

thanks for reporting, this seems to be a Compose dependency conflict issue, have you checked this link?
https://stackoverflow.com/questions/76950205/failed-resolution-of-landroidx-compose-runtime-primitivesnapshotstatekt

Hi @dokar3
Thanks for your help. What compose version does this library use?

That's weird, BOM 2023.10.01 should map to Compose 1.5.3 as this page mentioned: https://developer.android.com/jetpack/compose/bom/bom-mapping.
And PrimitiveSnapshotStateKt should be included in the classes if the dependency Compose Runtime 1.5.3 was applied:

Hi @dokar3, I applied compose-runtime and compose-runtime-saveable, but still getting same error message. Am I missing any other libs?

It may be conflicted with other libraries/dependencies so the build system picked an older version of runtime, can you force the runtime version to 1.5.4?
implementation("androidx.compose.runtime:runtime") {
    version {
        strictly("1.5.4")
    }
}

I got the same error in the sample app after I changed it to 1.4.3.

It may be conflicted with other libraries/dependencies so the build system picked an older version of runtime, can you force the runtime version to 1.5.4?
implementation("androidx.compose.runtime:runtime") {
    version {
        strictly("1.5.4")
    }
}

I got the same error in the sample app after I changed it to 1.4.3.

Thank you, I am trying it out and let you know :)

I applied the strict versioning but still get the same error. But mine is not a greenfield project and probably because of that too many libs overlapping with each other. Thanks for your help :) I will update in this thread if I find a solution.

You're welcome, glad to help.


Modify response of ResourceTypes endpoint

This modifies the response of /ResourceTypes as described in the RFC here: https://datatracker.ietf.org/doc/html/rfc7644#section-3.4.2
I described the problem in more detail in https://github.com/RIPAGlobal/scimitar/issues/146

Thanks, yes, that was a silly error. PR and test coverage much appreciated.

Published as v2.10.0 - see https://rubygems.org/gems/scimitar


Transaction history improvements

Problem
You dont see resulting balance
Transaction status is not obvious
You don't see pending transaction if someone initiataded a transfer
Task
You need to make it look good.

You need to  make resulting balance of transaction visible

It should be visible in  the currency of the current wallet.

The dollar (eur etc) amounts should be shown on hover.
When you hover over an amount  in BTC, you should see full amount  in btc without rounding, and its approximate equivalent in fiat currency.

If its a multisig account  and someone  initiated a transaction, and haven't cancelled it,  you need to  see  it in list of transaction with "requires signature" status. The resulting balance should not be affected, such transactions should be  clearly visible:

The date will appear of initiation  of transaciton, but once confirmed, it should be sorted by date (or block) of first confirmation .

When  you click on transaciton you need to animate unfolding of
the transaction block right inside the  table of all transaction with more details.

transaction id
exact amount
number  of confirmations
actions required (if any): cancel, sign, etc..
fees taken
fiat equivalents of amounts
etc..

Most importantly we need to fix issues with jumping balances and transactions not appearing in status bars..
Purpose
Intuitiveness and usefulness.
Area
frontend and some backend changes to make changes immediate. we  can't wait fo blockchain to swallow a transaction to display correct list of transaction including those that are pending
backend need to  cache whatever it  got from blockchain or from us to make sure it has the most recent list of pending, confirmed and unconfirmed transactions. so when you do reloads or go back and forth between screens you receive  always  the same list  of transactions unless there is some new comming in.
Estimate time of implementation
1   month?
Additional data

Also good idea to add accounting-friendly number of significant digits and have the same number of digits after the "."
Less significant digits we can make gray.
monospace font family will make it so that digits with same  significance are on  equal level

Диалоги должны быть

закрываемые (кнопкой и крестиком)
иметь одинаковый look and feel. то есть быть в том  же месте и одинакового  стиля
размывать ненужный фон (возможноо кроме баланса) и делать его не кликабельным
всегда работать как t34

It would be nicer if send dialogues was on 1 screen. without having to click
The source wallets would  be displayed in dropdown. by default - the last used wallet (for sending) or wallet with biggest balance in usd equivalent.

по поводу транз требующих действия давайте по дизайну сделаем, просто не дошли до этого пока. но займемся поочереди

history table, invoice table, table from the currency page are the same data just with different filters
therefore, you need to rewrite these 3 components, to 1 common, which will be based on the history table, but add filters there that will be thrown by props
this leads to a decrease in the code, its greater comprehensibility and reduces the risk of crash
if you upload a list of transactions and put it in the store, you don’t have to unload this data every time while change route just filter (display data from the store and update it in the background)

Here is the designers vision of transactions which needs actions, let's take this as basic design

Ok the designer didnt take into account the following:
https://user-images.githubusercontent.com/22708849/79560253-f36f2100-80af-11ea-8a7d-d613c19a8717.png
Also, the designer did  not change the resulting balance after  transaction, not good. Must be as I  asked.
I  know it looks nicer when there is no mono  fonts, and too many colors, but from the pro user point  imho,  its better to stress the important  part of the amounts.

Строка  поиска в истории транзакций - это бомбейская идея
посмотрите как сделано у gitlab

Надо сделать что-то типа того, так-же легко удобно и логично

https://github.com/swaponline/MultiCurrencyWallet/issues/2687#issuecomment-616097987
The confirmation screen can be universal for a few scenarios:

[ ] Confirmation of simple wallet transaction
[ ] Multisignature wallets, when the other pary signs the trasaction
[ ] 2FA comfirmation.
Связанное ишью https://github.com/swaponline/MultiCurrencyWallet/issues/2625

Transaction ledger service
If we make trnsaction ledger service on the backend with the functionality to save transactions on all stages, we need to remove the "requests" folder

Instead, this will be a filter on regular transaction list:

And  the link of such page should be:

https://swaponline.io/#/history?filter=tag:invoice

And there should be notifications, also different types:

Incomming invoices
Incomming multisig transactions that require signatures
New Incomming transactions to wallets

(decomposition https://github.com/swaponline/MultiCurrencyWallet/issues/2419 )
Unlike many other blockchain explorers, our must be more accounting-oriented, rather than blockchain oriented. This means, our transaction list must be more user-friendly to professionals who wish to view balances and transactions, rather than understand the blockchain details. This means that in the (5) transaction list we need to

[ ]  display the date of transaction

[ ]  amount of transaction (in currency of the wallet. e.g. btc)

[ ]  balance (the new balance after the transaction was complete, or when it will be complete)

[ ]  we need an easy way to convert the transaction amount to fiat currency amount (usd), so you can see your transactions in fiat representation, the exchange rate must be valid for the time when the transaction was complete, rather than current exchange rate. So if you sent 3 months ago 0.1 btc, you should see first of all the 0.1 btc, but also its important that it was approx $700 at the time of transaction. (there is no need to convert resulting balance after transaction to fiat amount, as its irrelevant)

[ ]  We need to see current balance of the wallet in the currency of the wallet (BTC) as main focus, but there current balance should also be shown in preferred fiat currency (e.g. USD), with lighter accent.

[ ]  pending transactions should not influence the current balance, and the balance after transaction field must be empty, it will only be shown after transaction is accepted, and the time of acceptance should be the sorting value.

有点麻烦，我直接接入了优盾钱包，去中心化的，资产动向和操作日志一目了然，还可以余额一键归集


Add support for importing this library as an esm module

As a fix for https://github.com/LilyRose2798/trpc-openapi/issues/6

So this fix is also necessary if you want to use next v14+
The custom rename.js script is a bit hacky. I'm sure you could use a proper build tool to solve the issue, but I didn't want to mess with the build process too much, so this works for now.

@LilyRose2798 any chance you could take a look at this?

Looks good. Will merge it now.

Published on npm as v1.4.0


Two tier example

Can you point us to a nice example of a two tier set-up?
I.e. the webapi just does a request to MediatR and the boilerplate does the call to the actual service using WCF or gRPC. The actual service on another node picks up the request, does the processing and responds back the result.

I don't have one, sorry!


Upgrade to Ruby 2.7.1

These are the changes necessary for Ruby 2.7.1
I've left the Ruby version as 2.6.6 since there is a script that updates all the apps' Ruby versions at once.

This change looks good, but we should probably also update the Changelog.md as well.


error refreshing state

I have two modules ami and eks.
ami is doing the encryption of the AWS public EKS AMI, while eks reference the result and proceed with the cluster maintenance. With AMI v25 release, I somehow run into the error refreshing state issue as below:
Error: Error refreshing state: 1 error(s) occurred:

* module.eks.aws_launch_configuration.workers: 1 error(s) occurred:

* module.eks.aws_launch_configuration.workers: aws_launch_configuration.workers: InvalidAMIID.NotFound: The image id '[ami-0141200bb38f52bc1]' does not exist
	status code: 400, request id: a463578f-65c1-4eda-9bf1-3171f3c6a2d2

I have two questions:

how to fix the invalid AMI issue? maybe something like terraform state rm? Or just directly modify the S3 tf state file.
How to specify the module to module execution sequence?

Thanks!

I ended up deleting the state and recreate the resource:
$ terragrunt state list
$ terragrunt state rm module.eks.aws_launch_configuration.workers


Add How to Use section in UG

Codecov Report
Base: 44.46% // Head: 44.46% // No change to project coverage :thumbsup:

Coverage data is based on head (92d1848) compared to base (4612f90).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #201   +/-   ##
=========================================
  Coverage     44.46%   44.46%
  Complexity      648      648
=========================================
  Files           142      142
  Lines          3403     3403
  Branches        398      398
=========================================
  Hits           1513     1513
  Misses         1753     1753
  Partials        137      137

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[TR#107] Sidebar Revisitons

Task
TR #107
Why?
The current Sidebar does not match the current Designs
What Changed

[X] Remove subtle primary sidebar
[X] Remove sidebar items in favor of using normal buttons
[X] Add compact sidebar style

Sanity Check

[X] Have you updated any usage of changed tokens?
[X] Have you updated the docs with any component changes?

[X] Have you tried building the css?
[X] Have you tried building storybook?
Do you need to update the package version?

Screenshots

 Sidebar


Allow Validated to annotate non-entity objects

This is a fix for #1433.
Previously, the Validated annotation would only be allowed on entity parameters of a resource, even though a BeanParam could be validated. This created a problem where one would want to specify a validation group on an endpoint that only accepted a BeanParam, as they would be forced to annotate a dummy request entity with Validated.
This pull request also handles the situation when the user supplies two or more entities with Validated. These annotations must be equivalent (and thus redundant), else an exception will be thrown as the underlying validator cannot validate parameters under different validation groups.
I would like critiques of the implementation because as of right now, a WebApplicationException is thrown, as a RuntimeException will result in Jersey interpreting it as a ProcessingException, and WebApplicationException works around it. Alternatively, we could define a new exception type but that would require adding a new exception mapper as well, which I feel like is more code bloat than I care for.
As a side note, it should definitely be documented (looking at me) that a single parameter annotated with Validated will be effect how the rest of the parameters are validated with the same group. Some would find the following surprising:
@PUT
public FooBar putFoo(@Validated(Group.class) @Valid @BeanParam MyParams params,
                     @Valid @NotNull FooBar entity) {
    // ...
}

In this case, both params and entity are validated under the Group class. The same would apply if entity was annotated and params wasn't.

Thanks for a detailed description of the issue! I find the implementation is quite terse and, what more important, it fixes the problem. Let's merge the implementation and refactor it, if needed.


Adds multi-platform support to Docker CI

Related issues:

https://github.com/cityofaustin/atd-airflow/pull/121/files#r1261640778

I copied this from Frank's work in atd-airflow
I'm not sure how to test this :/

test by merging! :yolo

thanks y'all!


Maximum call stack size exceeded

An Autocomplete field that has minimum_characters: 0 will freeze the browser when selected (until Call stacks is exceeded).

function
file:line

Uncaught RangeError: Maximum call stack size exceeded
jquery.min.js:2

n.extend.camelCase
jquery.min.js:2

n.extend.css
jquery.min.js:3

Zb
jquery.min.js:3

n.cssHooks.(anonymous function).get
jquery.min.js:3

n.extend.css
jquery.min.js:3

(anonymous function)
jquery.min.js:4

n.access
jquery.min.js:3

n.fn.(anonymous function)
jquery.min.js:4

yourlabs.Autocomplete.fixPosition
autocomplete.js:511

yourlabs.Autocomplete.show
autocomplete.js:400

yourlabs.Autocomplete.fetch
autocomplete.js:549

yourlabs.Autocomplete.show
autocomplete.js:409

yourlabs.Autocomplete.fetch
autocomplete.js:549

yourlabs.Autocomplete.show
autocomplete.js:409

yourlabs.Autocomplete.fetch
autocomplete.js:549

yourlabs.Autocomplete.show
autocomplete.js:409

...
...

yourlabs.Autocomplete.fetch
autocomplete.js:549

yourlabs.Autocomplete.show
autocomplete.js:409

Odd thing is that this only happens on remote server, when running locally no problems.

This might be a bug in yourlabs.Autocomplete.prototype.hasChanged which is responsible for preventing this.

Is there any way we could reproduce this ?
Thanks !

only happens on remote server, when running locally no problems

This might indicate that some latency is needed to trigger this, or that the remote app behaves differently, e.g. because of DEBUG=True etc.


Not using full paths within scripts

Script paths need straightening out - while trying to run viruspy.sh and magicblast_w_opts.sh I got repeated "file not found" errors.
./viruspy.sh -s SRR5675673 -o /zfs1/ncbi-workshop/virus-discovery/JW/Pipeline_Rerun/
srr: SRR5675673
outdir: /zfs1/ncbi-workshop/virus-discovery/JW/Pipeline_Rerun/
blastDB:
paired:
./viruspy.sh: line 73: magicblast_w_opts.sh: command not found
This error is because of line 73 in the script:
$magic_blast -s $srr -o $srr.fastq
without ./$magic_blast or bash $magic_blast, my shell won't be able to interpret the command.
Once that's fixed, I get:
bash: magicblast_w_opts.sh: No such file or directory
That's because of line 67:
cd $magic_dir
Which takes us out of the current directory into out_dir/data_magicblast, and the full path for magicblast_w_opts is not given, so it can't find the file. Since this is a larger issue (most of our paths in scripts are not full paths) I'm putting it up as an issue rather than just fixing it in the script.

I don't think full paths should be in our scripts. Code users need to put the scripts directory in their $PATH variable. Maybe this needs added to the README. Does this solve your issue?

@jkwaldman is it ok to close this?

@pcantalupo Let me check and get back to you tomorrow - today's a little hectic to test things out.

@pcantalupo Adding /scripts/ directory to $PATH solved my issues - added it to the readme.


PLFM-1695: Add service account for GHA portals deployment

This is the replacement for https://github.com/Sage-Bionetworks-IT/organizations-infra/pull/388.
The intent is to create a role and user to use in Github workflow to deploy files to S3 bucket (and
invalidate a Cloudfront distribution).

Superseded by GH OIDC.


[WIP] A 'Friends of PHP' alternative to Code Sniffer

This PR adds a suggestion to change the PHP code style 'linter' to the PHP CS fixer with the Symfony code standards configured.

By using the cs-fixer instead of the current code sniffer, we can lose the phpcs.xml file right?

Yes, we can. I can remove the configuration file and dependency in this PR when we decide we want to use the PHP CS fixer instead of the code sniffer.

Why "instead" and not just use both checks? I know the PSR2 standard doesn't validate docblocks. Also code sniffer comes with a patcher tool to fix most changes.


source map outputs '\' but not '/' in the sources path list on Windows

Here is my simple gulpfile, just copying from the given sample of simplifyify README.md:
var gulp        = require("gulp"),
    simplifyify = require("simplifyify");   // https://www.npmjs.com/package/simplifyify

gulp.task("browserify", function(done) {
  simplifyify("app.js",
    {
        outfile: "bundle.js",
        debug: true,
        minify: true
    })
    // .on("end", function() {
    //     // Finished successfully!
    //     done();
    // })
    .on("error", function(err) {
        // Something went wrong
        done(err);
    });
});

And the output of the bundle.js.map as below (my OS is Windows 10 64bit)
  "version": 3,
  "sources": [
    "node_modules\\browserify\\node_modules\\browser-pack\\_prelude.js",
    "app.js",
    "buttons\\button.js",
    "node_modules\\jquery\\dist\\jquery.js"
  ],
  ...

however, if I use browserify app.js --debug | exorcist bundle.js.map > bundle.js, I will get as follow:
  "version": 3,
  "sources": [
    "node_modules/browserify/node_modules/browser-pack/_prelude.js",
    "app.js",
    "buttons/button.js",
    "node_modules/jquery/dist/jquery.js"
  ],
  ...

I think the output path of the source with '\' will be not correct when I deploy them to the server. Is it a bug? or where can I have an option to make the path separator to '/', but not system default sep '\'?
Thank you.

I think you're right, that this is a bug.  When I get a chance, I'll look into it further to confirm whether it's a bug and get it fixed.  Thanks for reporting it!

I looked into this further, and I honestly don't know whether it's a bug or not.  The source maps are created by Exorcist, which in-turn uses mold-source-map.  That's where the backslashes are coming from.  So, it may be a bug in mold-source-map, or it may not be a bug at all.  I don't know the details of the source map spec, so I can't say for sure.

I'm gonna' go ahead and close this issue, since I'm not sure if it's actually a bug or not.  If it is a bug, then it's a bug in mold-source-map


Geode SDK 2.206 Question

Your Question
When Geode will be compatible with 2.206 and mods will work?

Please have the foresight to look at other posts asking the same question as it has been answered 100 times. Of course it’ll be supported but there is no time frame. Just gotta be patient.

Stay on 2.205. No reason to update.


Without IO, endpoint consumes 800MB throughout

Environment info

NooBaa Version: master-20210728
Platform: OCP 4.6.16

Actual behavior

Idle system Grafana view showed 800+MB consumption by endpoint pod. CPU usage is 1% which is OK

Expected behavior

Endpoint pod should consume much less memory as it is 40% of the overall memory.

Steps to reproduce

Captured Grafana view and looked at top command from endpoint pod

Copying Grafana o/p and must-gather o/p along with noobaa diagnose
More information - Screenshots / Logs / Other output

noobaa_diagnostics_1625025948.tar.gz

Memory_Snapshot_Grafana.zip

@akmithal How much memory would you expect the endpoint pod to consume?
You can define endpoint resource limit in the NooBaa CR (spec.endpoints.resources... - doc)
Or you mean that you expect the endpoints to shrink their heap size more aggressively after I/O calms down?

Hello @guymguym , I found 40% consumption of 2 GB limit in idle environment to be very high. My reference point is, on new installation, it stayed around 200-300MB. On doing IO, it peaks upto 1.5 GB's but I was expecting it to come down to initial memory limit post installation. I didn't change any resource value in the configuration.
I suspect such consumption in idle setup would result in huge scaling of endpoints resulting in proportionate allocation of memory.
Does this consumption of resources look OK to you ?

@jeniawhite had a thought regarding our 500MB buffers for NS FS which might be affecting this as well. Those are not dynamic but flat 500...

@akmithal endpoints would currently scale only on CPU and not mem

Hi @nimrod-becker , I am finding that Memory resources were not freed up after IO was stopped.
I have 3 GB RAM defined in the configuration. During IO, usage went upto 1.8GB and it didn't drop after that.
must-gather-1.tar.gz

@romayalon can we have the JIRA ticket mentioned for this
@nimrod-becker , could you screen and assign

There were multiple fixes to memory handling in the endpoint by Guy and Jacky, can we please rerun with a new build ?

It is available 4.11 as well as 4.10

@neeshapan , please check when time permits.

Closing, HPO is discontinued.


Update to python-ldap 3.4.2

Minor version bump. This is necessary to resolve build issues on Alpine 3.15+ or other OpenLDAP 2.5+ distributions.
When attempting to build with 3.4.0 on Alpine 3.15+ or any distribution using OpenLDAP 2.5+ (which should be all of them as OpenLDAP 2.4 is fully end of life,) the build of python-ldap will fail due to the python-ldap maintainers requiring re-entrant OpenLDAP and previously insisting users fix it by simply installing a totally different distribution.
python-ldap 3.4.2 finally saw the light and implemented a proper fix which handles both 2.4 and 2.5+.
Tested locally on Alpine 3.16.1, Rocky 8.5, and RHEL7 using a virtual environment, did not run into any issues.

Hello,
Seems correct.
Regards


Each project should be a namespace for target names

Žinoma already makes it possible to connect different projects with the imports keyword.
However, in order to avoid ambiguous situations, Žinoma also enforces manual target names disambiguation throughout projects. This means it is currently impossible for 2 targets to have the same name, even in different projects. This is a rather annoying situation. For instance, it is usually common to have a build or test target in each project, but impossible as soon as the projects depend on each other.
The proposed solution is to make each project a namespace for target names. When referencing targets from other projects, it should be possible to specify the targets' project.

Here are some constraints:

Project names should be non-ambiguous.
We should avoid having a single project named in different ways.
We should avoid centralizing projects declaration.

Here's my proposal:
Any project being imported needs to define a name in its zinoma.yml. When importing projects, instead of specifying an array of paths, we'd have to specify a map of project_name to project_path. The name specified in the map should match the name specified in the imported project.
In addition to that, the namespace would now have to appear when any imported target is referenced. I suggest the format project_name::target_name.
Example
subproject1/zinoma.yml:
name: subproject1

targets:
  my_target: {}

subproject2/zinoma.yml:
imports:
  subproject1: ../subproject1

targets:
  my_target:
    dependencies: [subproject1::my_target]


Update electron version

UnelmaSupport
Hello!
Thanks for getting in touch! This is an automatic email just to let you know that we've received your request and your ticket reference is #306.
One of our support agents will get back to you shortly. Please do not submit multiple tickets for the same request, as this will not result in a faster response time.
View Help Center: https://unelmasupport.com/hc
Regards,
UnelmaSupport
If you’re having trouble clicking the "View Help Center" button, copy and paste the URL below into your web browser: https://unelmasupport.com/hc
© 2024 UnelmaSupport. All rights reserved.

UnelmaSupport
Hello!
Thanks for getting in touch! This is an automatic email just to let you know that we've received your request and your ticket reference is #307.
One of our support agents will get back to you shortly. Please do not submit multiple tickets for the same request, as this will not result in a faster response time.
View Help Center: https://unelmasupport.com/hc
Regards,
UnelmaSupport
If you’re having trouble clicking the "View Help Center" button, copy and paste the URL below into your web browser: https://unelmasupport.com/hc
© 2024 UnelmaSupport. All rights reserved.


[python] Move string encoding to ChipDeviceCtrl.py

Problem
With #19792 SetWiFiCredentials() changed from taking string arguments to byte arrays. This shifts responsibility to choose the right encoding to the caller, which seems not ideal.
Change overview
Exposing a Pythonic API and encode the string in ChipDeviceCtrl.py.
Testing
Manually using chip-repl.

Needs more changes in tests. I see:
[2022-07-05 14:29:58.995671][TEST][STDERR]INFO:PythonMatterControllerTEST:Commissioning device fe80::42:acff:fe12:2
[2022-07-05 14:29:58.997094][TEST][STDERR]'bytes' object has no attribute 'encode'
[2022-07-05 14:29:58.997123][TEST][STDERR]Traceback (most recent call last):
[2022-07-05 14:29:58.997129][TEST][STDERR]  File "/__w/connectedhomeip/connectedhomeip/src/controller/python/test/test_scripts/mobile-device-test.py", line 224, in <module>
[2022-07-05 14:29:58.997135][TEST][STDERR]    run()
[2022-07-05 14:29:58.997140][TEST][STDERR]  File "/__w/connectedhomeip/connectedhomeip/.environment/pigweed-venv/lib/python3.9/site-packages/click/core.py", line 829, in __call__
[2022-07-05 14:29:58.997146][TEST][STDERR]    return self.main(*args, **kwargs)


Bug:

What happened?
A bug happened!
Steps to reproduce

step one...
step two...

What OS are you seeing the problem on?
No response
Relevant log output
options: {
  "path": "D:\\Downloads\\Ieuan Jones Bible Intro.m4a",
  "model_path": "C:\\Users\\Administrator\\AppData\\Local\\github.com.thewh1teagle.vibe\\ggml-medium.bin",
  "lang": "en",
  "verbose": false,
  "n_threads": 4,
  "init_prompt": "",
  "temperature": 0.4,
  "translate": null,
  "max_text_ctx": null
}

Caused by:
    ffmpeg not found

Location:
    core\src\audio.rs:54:42
App Version: 2.0.3
Commit Hash: 6c5ace63edd36807905fd906c26ec34fab1325ea
Arch: x86_64
Platform: windows
Kernel Version: 10.0.19045
OS: windows
OS Version: 10.0.19045
Models: ggml-medium.bin
Default Model: "C:\\Users\\Administrator\\AppData\\Local\\github.com.thewh1teagle.vibe\\ggml-medium.bin"

{
    "avx": {
        "enabled": true,
        "support": true
    },
    "avx2": {
        "enabled": true,
        "support": true
    },
    "f16c": {
        "enabled": true,
        "support": true
    },
    "fma": {
        "enabled": true,
        "support": true
    }
}

Thank you for reporting this issue!
Could you please check if you installed the NVIDIA version? I think I may have missed bundling ffmpeg in the latest update.

How do I check if it's the NVIDIA version?
Bitdefender found and quarantined Gen:Variant.Lazy.540663 from ffmpeg.exe when I installed Vibe, so it looks like the ffmpeg was not installed. Can I add ffmpeg another way?
Thanks,Stephen
On Tuesday, June 11, 2024 at 01:35:45 PM EDT, thewh1teagle<EMAIL_ADDRESS>wrote:

Thank you for reporting this issue!
Could you please check if you installed the NVIDIA version? I think I may have missed bundling ffmpeg in the latest update.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

How do I check if it's the NVIDIA version? Bitdefender found and quarantined Gen:Variant.Lazy.540663 from ffmpeg.exe when I installed Vibe, so it looks like the ffmpeg was not installed. Can I add ffmpeg another way? Thanks,Stephen On Tuesday, June 11, 2024 at 01:35:45 PM EDT, thewh1teagle @.> wrote: Thank you for reporting this issue! Could you please check if you installed the NVIDIA version? I think I may have missed bundling ffmpeg in the latest update. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.>

You can open vibe folder in the path %localappdata%\vibe (paste this in explorer.exe in the top bar)
If it contains some DLL files which named like cuda it's nvidia, if not it's regular. also the folder size should be small if it's not nvidia.
Also when you open the folder check if ffmpeg.exe is there.
Try to reinstall vibe, looks like Windows defender deleted the file ffmpeg.exe when you installed it. if you can screenshot when it report it, and also provide here the exact URL you downloaded vibe from, I will be able to report it to Microsoft so they will stop blocking it.
Thanks :)

I downloaded ffmpeg, and copied the exe over to the Vibe folder. Vibe is now working, and even though I've just started, it looks like it's doing a great job.
I've got an old tape of a Welsh teacher with his sing-songy voice that's been converted to an m4a file, and it looks like Vibe is getting everything.
I've got some Chinese stuff that needs transcribed, so I'll check that out later.
Thanks for this.
Stephen
On Wednesday, June 12, 2024 at 03:44:40 PM EDT, thewh1teagle<EMAIL_ADDRESS>wrote:

How do I check if it's the NVIDIA version? Bitdefender found and quarantined Gen:Variant.Lazy.540663 from ffmpeg.exe when I installed Vibe, so it looks like the ffmpeg was not installed. Can I add ffmpeg another way? Thanks,Stephen On Tuesday, June 11, 2024 at 01:35:45 PM EDT, thewh1teagle @.> wrote: Thank you for reporting this issue! Could you please check if you installed the NVIDIA version? I think I may have missed bundling ffmpeg in the latest update. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.>
You can open vibe folder in the path %localappdata%\vibe (paste this in explorer.exe in the top bar)
If it contains some DLL files which named like cuda it's nvidia, if not it's regular. also the folder size should be small if it's not nvidia.
Also when you open the folder check if ffmpeg.exe is there.
Try to reinstall vibe, looks like Windows defender deleted the file ffmpeg.exe when you installed it. if you can screenshot when it report it, and also provide here the exact URL you downloaded vibe from, I will be able to report it to Microsoft so they will stop blocking it.
Thanks :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Do you have a PayPal account so I don't have to fill out all my info on github?
Stephen
On Wednesday, June 12, 2024 at 03:44:40 PM EDT, thewh1teagle<EMAIL_ADDRESS>wrote:

How do I check if it's the NVIDIA version? Bitdefender found and quarantined Gen:Variant.Lazy.540663 from ffmpeg.exe when I installed Vibe, so it looks like the ffmpeg was not installed. Can I add ffmpeg another way? Thanks,Stephen On Tuesday, June 11, 2024 at 01:35:45 PM EDT, thewh1teagle @.> wrote: Thank you for reporting this issue! Could you please check if you installed the NVIDIA version? I think I may have missed bundling ffmpeg in the latest update. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.>
You can open vibe folder in the path %localappdata%\vibe (paste this in explorer.exe in the top bar)
If it contains some DLL files which named like cuda it's nvidia, if not it's regular. also the folder size should be small if it's not nvidia.
Also when you open the folder check if ffmpeg.exe is there.
Try to reinstall vibe, looks like Windows defender deleted the file ffmpeg.exe when you installed it. if you can screenshot when it report it, and also provide here the exact URL you downloaded vibe from, I will be able to report it to Microsoft so they will stop blocking it.
Thanks :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

I downloaded ffmpeg, and copied the exe over to the Vibe folder. Vibe is now working, and even though I've just started, it looks like it's doing a great job. I've got an old tape of a Welsh teacher with his sing-songy voice that's been converted to an m4a file, and it looks like Vibe is getting everything. I've got some Chinese stuff that needs transcribed, so I'll check that out later. Thanks for this. Stephen

If you have macOS or an NVIDIA GPU, you can transcribe audio incredibly quickly, processing up to 2 hours of content in just a few minutes. I'm glad to hear everything is working well for you and that you're enjoying it so far!

Do you have a PayPal account so I don't have to fill out all my info on github? Stephen

I appreciate your willingness to support the project! While I don't have a PayPal account, you can easily support the project on Ko-fi without needing to sign up or fill in details. Just follow this link: Ko-fi.


[Feature] Update to reason react jsx to version 3

Summary
This PR attempts to update jsx syntax for reason react to version 3. Currently the branch is in an error state because, I think, my dependencies are incorrect. Also, I have duped bs-platform and reason-react dependencies instead of having just one of them in the dependency chain. More guidance is needed on my end for how the dependency chain works with packages, plugins, and examples.

To be sure the thing is working, you also need to edit example/reason-react-app.
That's where you can specify an actual reason-react version & run a build :)
Good start anyway!

Cool! I will try and work on this more tonight, but might be tomorrow. Also, I realized that we might have to use ReasonReactCompat.wrapReasonReactForReact in cases where we can't convert jsx 2 to jsx 3.

@MoOx Still just working along and making necessary changes but running into an issue that I am not able to diagnose:
sh: /Users/arecvlohe/Documents/development/phenomic/node_modules/bs-platform/lib/bsppx.exe -bs-jsx 3: No such file or directory
File "", line 1:
Error: Error while running external preprocessor
Command line: '/Users/arecvlohe/Documents/development/phenomic/node_modules/bs-platform/lib/bsppx.exe -bs-jsx 3' '/var/folders/h6/x5vgndfs0dv_y2017t23x51m0000gn/T/camlppx3bf7df' '/var/folders/h6/x5vgndfs0dv_y2017t23x51m0000gn/T/camlppxf075b9'

The error will show in your editor at the very top of link.re. It seems like everything else builds fine. I was having this issue in other files but it's only an issue in one now. I will take a look at this some more tomorrow night but wanted to leave it here in case you could take a look at it.

@MoOx Thanks for the context, it looks like the error is coming from RLS. I still have errors when running yarn run test so I will into that more today.

@MoOx Leaving a comment here because I can't figure this out. When I run yarn run transpile I am getting a syntax error in link.re on the line where it has React.element. I am not sure why this is happening. I Also found it strange that in Link.js no children are passed but when it's used a React.array is passed to <Link />. Maybe this is shows a lack of understanding but wanted to make note of it so I can learn something. Anyhow, the syntax error is main thing that is blocking me so any help would be appreciated!

@MoOx Sorry for spamming you on a Saturday but I think the code is now ready. After running yarn run test, all the tests pass. It looks as though there is a build error though, something related to using &&. You probably would know more about that than me. Anyhow, have a good weekend and let me know if the code needs any more tweaking!

@MoOx Done. I can see the benefit of splitting it up into different packages. Might make it easier to maintain overall. If more people contribute/maintain then it would be easier for one person to maintain one library instead of many.

@MoOx Done. I thought this made more sense (React.component('a), Js.t({..})) => React.component('b) since it's a HOC, it should be going from 'a to 'b.

@MoOx ping

@MoOx Ping

1.0.0 is out on npm (just include this change). Thanks for helping!

@MoOx Awesome!


Wraeth/activity event separation [2/a]

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #1772

PR #1777
PR #1895   👈

This comment was auto-generated by Graphite.

@wraeth-eth should we close these 3 PRs?


Alternative code approval process

While current LGTM.co provides availability to protect codebase with strict approval system (that I'm in favor), it also exposes lacks of customization would better to have such as

Different approval permissions per maintainers
: Someone like full-committer can approve codes with single approval, while other maintainers requires N approval
Allow / block self approval
Other some good-to-have (do not allow to approve WIP PR, clear approval if PR's getting updated..)

Options can be considerd

Simply lower LGTM approval require to 1
Remove approval system
Moving LGTM to different approval checker (https://pullapprove.com/), support various customization mentioned in above

/cc @staltz @blesh @jayphelps .
I'd personally vote 3, which will mostly satisfies requirement as well as preserving explicit approval checker as well. (I believe 3 won't solve requiring rebase by protected branch though)

I vote for 3, if it truly does provide such ability.  I did some initial digging and couldn't find any solutions other than not using them.

For a reference, attaching docs http://docs.pullapprove.com/yaml/reviewers/ . It'll allows to setup reviewer group, each group can have different approval requirement.

I didn't know about pullapprove. Sounds ok to me.

In the mean time I've already done this:

Simply lower LGTM approval require to 1

I think it'll be hard to get two of us to review every PR.

pullapprove LGTM :shipit:

I'm verifying per-group permission to ensure to not cause daily flow churns - once verified will create PR shortly. Assigning myself for now.

I believe we actually CAN enable PR merges without requiring everyone to rebase even when there aren't conflicts! It's an option in Settings so an admin will have to change it (assuming everyone agrees)

Require branches to be up to date before merging

(assuming everyone agrees)

👍 ❤

My current suggestion is https://github.com/zalando/zappr other than pullapprove, but main debate here will be
Do not use separate approval process (just use Github Review Approval) vs. use 3rd party , better than LGTM(which is gone now)

LGTM is now discontinued and no longer works, see: https://github.com/ReactiveX/rxjs/pull/2270
Now that GH supports native review/approvals, I think we should give that a spin before trying out any more third party solutions.

I'm closing this as inactivity. We can consider separate review process later.