Grouped nullifier encode/decode methods into NullifierValueEncoder

Resolved discussion started here: https://github.com/0xPolygonMiden/miden-node/pull/264#discussion_r1514358952

Now that the repo has a next branch, shouldn't this PR target next?

Now that the repo has a next branch, shouldn't this PR target next?

@plafer since it just a refactoring, I don't think it matters, but let ask @bobbinth for his opinion.

Closed since we decided to make Smt generic over AsRef<Word>: https://github.com/0xPolygonMiden/crypto/issues/288

While I think https://github.com/0xPolygonMiden/crypto/issues/288 could be independently interesting, I wonder if we should use a different approach for this specific issue. Specifically, we could create a newtype NullifierDbor NullifierTree which would look something like this:
pub struct NullifierTree(Smt);

impl NullifierTree {

    pub add(&mut self, nullifier: Nullifier, block_num: u32)-> Result<(), NullifierTreeError> {
        // returns an error if the nullifier is already in the tree
    }

    pub fn get_block_num(&self, nullifier: &Nullifier) -> Option<u32> {
        // returns None if the nullifier is not in the tree
    }
}

This should help abstract away the logic of how block numbers are associated with nullifiers and would leave more flexibility for the future (e.g., we could build a specialized implementation of the NullifierTree which assumes that leaves are just 32-bit values).

@bobbinth great idea, I like it!


Compile problem with Eigen versions

This might end up being a question about opam that I should ask about on discuss.ocaml.org or StackOverflow, but it could be that the difficulty I'm experiencing has to do with how the current versions of Owl and Eigen work together, so I thought I'd ask here first.
The latest version of Owl won't compile with the opam version of Eigen, producing this error:
# Error: Unbound value Eigen.Dense.S.gemm

I saw in the Eigen git history that dot was recently renamed to gemm, so I assumed that I just needed a more recent version of Eigen.  I got Eigen from github and was able to compile and install it using 'opam pin add eigen <my source dir>.   I don't quite understand all of the command variants in the Eigen source, but I think the appropriate version of gemm is in there (in eigen_dismat_s.ml?).
However, when try to pin my local owl git tree, I get the same error, ie.. that gemm is unbound (see below).  I don't understand this.
On the other hand, if I then compile a file to a native executable (rather than running utop), Owl seems to be available.  I have no problem compiling code that uses Owl.
Any thoughts about what might be going wrong?
Thanks-
Marshall
/docs/src/ml/owl(master)*$ opam pin add owl `pwd`
[NOTE] Package owl is already path-pinned to /Users/marshall/docs/src/ml/owl.
       This will erase any previous custom definition.
Proceed ? [Y/n] y

[owl] /Users/marshall/docs/src/ml/owl/ synchronized
[owl] Installing new package description from /Users/marshall/docs/src/ml/owl

owl needs to be installed.
The following actions will be performed:
  ∗  install owl 0.2.4*
Do you want to continue ? [Y/n] y

=-=- Gathering sources =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=  🐫
[owl.0.2.4] /Users/marshall/docs/src/ml/owl/ already up-to-date

=-=- Processing actions -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=  🐫
[ERROR] The compilation of owl failed at "ocaml setup.ml -build".
Processing  1/1: [owl: ocaml]
#=== ERROR while installing owl.0.2.4 =========================================#
# opam-version 1.2.2
# os           darwin
# command      ocaml setup.ml -build
# path         /Users/marshall/.opam/yo/build/owl.0.2.4
# compiler     4.04.1
# exit-code    1
# env-file     /Users/marshall/.opam/yo/build/owl.0.2.4/owl-64484-d2d111.env
# stdout-file  /Users/marshall/.opam/yo/build/owl.0.2.4/owl-64484-d2d111.out
# stderr-file  /Users/marshall/.opam/yo/build/owl.0.2.4/owl-64484-d2d111.err
### stdout ###
# [...]
# /Users/marshall/.opam/4.04.1/bin/ocamlfind ocamldep -package str -package plplot -package gsl -package eigen -package dolog -package ctypes.stubs -package ctypes -modules lib/owl_stats.ml > lib/owl_stats.ml.depends
# /Users/marshall/.opam/4.04.1/bin/ocamlfind ocamldep -package str -package plplot -package gsl -package eigen -package dolog -package ctypes.stubs -package ctypes -modules lib/owl_dense_common.ml > lib/owl_dense_common.ml.depends
# /Users/marshall/.opam/4.04.1/bin/ocamlfind ocamldep -package str -package plplot -package gsl -package eigen -package dolog -package ctypes.stubs -package ctypes -modules lib/owl_pretty.mli > lib/owl_pretty.mli.depends
# /Users/marshall/.opam/4.04.1/bin/ocamlfind ocamlc -c -g -annot -bin-annot -ccopt -I/Users/marshall/.opam/4.04.1/lib/ctypes -ccopt -O3 -package str -package plplot -package gsl -package eigen -package dolog -package ctypes.stubs -package ctypes -I lib -I lib/backend -I lib/ext -I lib/nlp -o lib/owl_pretty.cmi lib/owl_pretty.mli
# /Users/marshall/.opam/4.04.1/bin/ocamlfind ocamldep -package str -package plplot -package gsl -package eigen -package dolog -package ctypes.stubs -package ctypes -modules lib/owl_dense_ndarray_a.ml > lib/owl_dense_ndarray_a.ml.depends
# /Users/marshall/.opam/4.04.1/bin/ocamlfind ocamlc -c -g -annot -bin-annot -ccopt -I/Users/marshall/.opam/4.04.1/lib/ctypes -ccopt -O3 -package str -package plplot -package gsl -package eigen -package dolog -package ctypes.stubs -package ctypes -I lib -I lib/backend -I lib/ext -I lib/nlp -o lib/owl_dense_common.cmo lib/owl_dense_common.ml
# + /Users/marshall/.opam/4.04.1/bin/ocamlfind ocamlc -c -g -annot -bin-annot -ccopt -I/Users/marshall/.opam/4.04.1/lib/ctypes -ccopt -O3 -package str -package plplot -package gsl -package eigen -package dolog -package ctypes.stubs -package ctypes -I lib -I lib/backend -I lib/ext -I lib/nlp -o lib/owl_dense_common.cmo lib/owl_dense_common.ml
# File "lib/owl_dense_common.ml", line 202, characters 17-35:
# Error: Unbound value Eigen.Dense.S.gemm
# Command exited with code 2.
### stderr ###
# E: Failure("Command ''/Users/marshall/.opam/4.04.1/bin/ocamlbuild' lib/libowl_stubs.a lib/dllowl_stubs.so lib/owl.cma lib/owl.cmxa lib/owl.a lib/owl.cmxs lib/neural/owl_neural.cma lib/neural/owl_neural.cmxa lib/neural/owl_neural.a lib/neural/owl_neural.cmxs perftest/perf_common.cma perftest/perf_common.cmxa perftest/perf_common.a perftest/perf_common.cmxs perftest/perf_dense_real.native perftest/perf_sparse_real.native perftest/perf_sparse_complex.native perftest/perf_dense_ndarray.native perftest/perf_dense_matrix.native perftest/perf_sparse_ndarray.native perftest/perf_sparse_matrix.native perftest/perf_specific_fun.native examples/test_neural.native -use-ocamlfind -tag debug' terminated with error code 10")

=-=- Error report -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=  🐫
The following actions failed
  ∗  install owl 0.2.4
No changes have been performed
[NOTE] Pinning command successful, but your installed packages may be out of sync.

Hi Marshall,
I think this is because the Eigen lib installed on your computer is outdated. Have you tried to update your opam then upgrade the Eigen lib with the following command.
opam update
opam upgrade eigen

You can also install both Owl and Eigen from git repo directly. Because Owl is dependent on Eigen, so you need to build and install Eigen first.
git clone https://github.com/ryanrhymes/eigen.git
cd eigen
make cleanall
make && make install

The make cleanall is just to remove previously installed Eigen version. After installing Eigen, you can then install Owl in a similar way.
git clone https://github.com/ryanrhymes/owl.git
cd owl
make cleanall
make && make install

Of course, you can still install Eigen with opam but only build Owl from source, this should also work.

Thanks Liang.  I realize now that this was a foolish mistake on my part.  It didn't occur to me to run opam update, so I was only able to get Eigen 0.0.3 using opam install.   Sorry about that!
I'm happy to install Eigen directly with opam install.  I want to be able to build Owl from a local clone so that I can to try to add the ability to change the perspective in a 3D plot.  If that works, I'll submit a pull request and you can decide whether you want to include it.

I'm happy to install Eigen directly with opam install.  I want to be able to build Owl from a local clone so that I can to try to add the ability to change the perspective in a 3D plot.  If that works, I'll submit a pull request and you can decide whether you want to include it.

That would be great! PR is always welcome! I think you can try to introduce some optional parameters for orientation to mesh and surf functions. 👍

git clone https://github.com/ryanrhymes/owl.git
cd owl
make cleanall
make && make install

It looks like make oasis is also needed after make cleanall, because that step removes setup.ml.

It looks like make oasis is also needed after make cleanall, because that step removes setup.ml.

Yes you are right. Sorry I forgot to add that, I have fixed the previous comments.


Stack

I'm getting this error in my tests:
AttributeError: 'Stack' object has no attribute '_new_LinkList'
Have another look at your push method and resubmit. You also have a lot of easily fixable linter errors in stack.py.


Other sub members

What this PR does

Fixes #50
State Of - Be In State,
Causes - Is Caused By,
In Manner - Manner Of,
Attribute,
Subevent - Is Subevent Of,

Todo
Couldn't find documentation for

Other and see also
Restricts - Restricted By,
Classifies - Classified By,
Entails - Is Entailed By,

You can find minimal documentation for some of these here (like fuzzynym): https://www.cl.ut.ee/ressursid/teksaurus/   Also use this to check our understanding of the others is correct.
Entails is in https://wordnet.princeton.edu/documentation/wngloss7wn
Classifies is introduced here: https://www.aclweb.org/anthology/L16-1685.pdf
Please leave restricts, I will do it.

You can find minimal documentation for some of these here (like fuzzynym): https://www.cl.ut.ee/ressursid/teksaurus/ Also use this to check our understanding of the others is correct.
Entails is in https://wordnet.princeton.edu/documentation/wngloss7wn
Classifies is introduced here: https://www.aclweb.org/anthology/L16-1685.pdf
Please leave restricts, I will do it.

Thanks. I will check them out.


[UI > PluginCard] Add opening author profile

I plan to make a couple of my own further refactors to this PR, but not tonight. I've just made my stylistic changes as usual.


 width preserved when resizing &  spacing

Probably already on the todo list, but making the window small enough that the <asides> relocate themselves does not cause <main> to resize to fill the screen.
[Safari 146<IP_ADDRESS>.1]

May or may not be fixable, but Mateo's /p287497 of /t16887 (deleted) said that the gap between the [Logged In] and [Online Users] is bigger than the other gaps because they are in separate <aside>'s.

Yes, I'll fix this before releasing 2.1
That is correct. I fixed it with some CSS- see https://github.com/Legend-of-iPhoenix/cemetech-userstyle/blob/88b103b1ff6156e8d1409fea664918a9ccc144aa/userstyle.css#L150-L153


pre-push Git Hook update

Takes care of #45. After discussion using the pre-commit library would have been a lot more overhead than was necessary for the scope of this update.

I've been playing around with this a bit (as you can tell by all the trivial commits). One thing I'm still seeing is that the new commit doesn't actually get pushed along with the originally-intended commits; I had to "git push" twice in order to get the single commit (https://github.com/oasis-open/cti-documentation/pull/46/commits/a4fdb89c76850be62646bec4d4591ae7b7472740) to appear in this PR. I have another local, un-pushed commit for the second time I ran git push.

Hmm that's interesting. I'm not able to reproduce that bug locally. Here is what it looks like on my end on a test repo. From the git log you can see both getting pushed. Any ideas on what could cause the disparity?

From the git log you can see both getting pushed.

Not necessarily. That's showing the log of your local branch. Try git log origin/master to see.
For comparison, here's what my log looks like after running git push for the second time. note that I have two commits generated by the hook, but only one is pushed (my git client also shows branch names, which makes it more readable).
commit 80b6dd26c1180fb2ebbaa9ae57b0173af977ed74 (HEAD -> pre-push-hook)
Author: Greg Back<EMAIL_ADDRESS>Date:   Tue Nov 7 22:48:42 2017 +0000

    Git Hook: Updated 'last_updated' time

commit a4fdb89c76850be62646bec4d4591ae7b7472740 (origin/pre-push-hook)
Author: Greg Back<EMAIL_ADDRESS>Date:   Tue Nov 7 22:48:21 2017 +0000

    Git Hook: Updated 'last_updated' time

commit f1981d72d711ff5c05795f3b50af9cd1c42df644
Author: Greg Back<EMAIL_ADDRESS>Date:   Tue Nov 7 22:48:17 2017 +0000

    Make hook executable

Actually, it's possible to see without running git log again. What was pushed to master was e2f15db..89f6e8c, which includes the "added test" commit but not the commit generated by the hook.

@gtback When you get a chance can you test out these new changes (e81104c)? I chose option 2 from this stackoverflow post, which rejects the push but adds a commit with the updated date. Once another push is done, all changes, including the updated time, are pushed.

Looking good! Exactly how I expect it to work 😁


feat(icons): added volleyball icon

#1978
What is the purpose of this pull request?

[x] New Icon
[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other:

Description

Adds new volleyball icon
Icon use case

showing volleyball courts on a map

Alternative icon designs

Icon Design Checklist
Concept

[x] I have provided valid use cases for each icon.
[x] I have not added any a brand or logo icon.
[x] I have not used any hate symbols.
[x] I have not included any religious or political imagery.

Author, credits & license

[ ] The icons are solely my own creation.
[x] The icons were originally created in #1304 by @danielbayley
[ ] I've based them on the following Lucide icons:
[ ] I've based them on the following design:

Naming

[ ] I've read and followed the naming conventions
[x] I've named icons by what they are rather than their use case.
[x] I've provided meta JSON files in icons/[iconName].json.

Design

[x] I've read and followed the icon design guidelines
[x] I've made sure that the icons look sharp on low DPI displays.
[x] I've made sure that the icons look consistent with the icon set in size, optical volume and density.
[x] I've made sure that the icons are visually centered.
[x] I've correctly optimized all icons to two points of precision.

Before Submitting

[x] I've read the Contribution Guidelines.
[x] I've checked if there was an existing PR that solves the same issue.

Is that a sufficient enough use case?
Is the name good, or should it be ball-volleyball instead?

Nice one @jguddas, do all of my previous icons that got merged into lab have to be submitted one at a time now? 😖

do all of my previous icons that got merged into lab have to be submitted one at a time now? 😖

They should always be submitted one at a time IMO, otherwise they are never gonna get merged.

I have this little script for now. Ideally lucide studio would handle moving things between branches.
grab-lab () {
  git fetch origin lab;
  git checkout main;
  git checkout -b gbc studio/$1;
  git checkout origin/lab icons/$1.svg icons/$1.json
  git commit -m "chore: pull `$1` icon from lab branch"
}

I have this little script for now.

@jguddas Nice, maybe this can be simplified, and expanded on with gh CLI…


Eden as a library: Decoupling viper and openevec

Description
openevec module takes configuration struct (currently named EdenSetupArgs) removing dependency of reading from file we decoupling dependencies and make it easier to work. This is necessary before writing tests
What do we ant to change:
This red line in UML diagram

https://github.com/lf-edge/eden/pull/921


Add device model code for Samsung devices

I would like to have one more field on Samsung devices that contains the device model code for the device.
Sadly there are sometimes more than one code for a device model like for the S10.
https://techbeasts.com/list-of-samsung-galaxy-s10-model-numbers-and-differences/
It would be useful to have this information because for example Intune collects hardware information on devices and creates an inventory. Sadly in the informations only this device model code is included. So when we are trying to get information about the support status of a device we have to resolve the device model code to a model name and then use that name to search for the support status.

Is there actually a difference in the support cycle depending on the code?
I could see carriers supporting their carrier branded devices for shorter amounts, but to keep track of this would be a nightmare. Maybe more appropriately we can add a disclaimer at the bottom about this?

I'm facing the same issue in the iPhone page, where some iPhone models have different model codes. iPhone 13 Pro Max is A2484 A2641 A2644 A2645 A2643 for eg.
I wanted to use the model codes for the API, but unsure how to keep it accessible. In my case, there's no difference in support cycle, but it would allow some interesting use-cases via the API (get model code, validate over API).

Is there actually a difference in the support cycle depending on the code?
I could see carriers supporting their carrier branded devices for shorter amounts, but to keep track of this would be a nightmare. Maybe more appropriately we can add a disclaimer at the bottom about this?

I do not think there is a difference in this. It just would be pleasant to be able to use the code from a data source like EMM system and query this against the database. This way not only the base models would be resolved.
It is not about anything just about to be able to resolve the code via API to device and corresponding support status.


add https: protocol to cdnUrl default config

Safari throws a CORS fit without the https: protocol included in the default cdn url and won't load the playground. Other browsers seem fine.
Here is the error in the Safari console:

Cross-origin redirection to https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>denied by Cross-Origin Resource Sharing policy: Origin http://localhost:4000 is not allowed by Access-Control-Allow-Origin. Status code: 302

When I override the default render options the problem on Safari goes away:
renderOptions: {
   cdnUrl: 'https://cdn.jsdelivr.net/npm'
}

I'm not sure if there is a downside you were trying to avoid by omitting the protocol, so there might be a tradeoff I'm not aware of by doing this.

GraphQL Playground does this and it seems to work fine:
https://github.com/graphql/graphql-playground/blob/60f90a910f6df590c6c87cf3f8922a4f61ef454e/packages/graphql-playground-html/src/render-playground-page.ts#L95

Interesting... I'm not sure what is going on here. I'm going to close this PR. If more people report Safari not working I can circle back and try to find the root cause, but the renderOptions solution in my comment above gets Safari working.


Deploy on Maven

The build.gradle file should deploy on Maven using prebuilt dependencies. This normally means adding a task in the gradle file.
Example of a gradle file that does that can be found here:
https://github.com/apache/incubator-tuweni/blob/main/build.gradle#L421

Hey @thomas-quadratic can I try solving this?
Also lmk if you have anything regarding this in mind


style(components): enforce extensions to align with esm

see reason why barrel file does not satisfy extension rule
https://github.com/import-js/eslint-plugin-import/issues/1920#issuecomment-719953032
------- edit
removing eslint import/extensions rule in favor of typescript moduleResolution "nodeNext"
see
https://github.com/microsoft/TypeScript/issues/42813#issuecomment-942633095

waiting on https://github.com/rollup/plugins/issues/1058#issuecomment-1114011903


Add described_class feature

It looks like the build is failing because it could not install Crystal. :(

This will be fixed soon here: https://github.com/travis-ci/travis-build/pull/764
I will check it manually and merge if everything is OK.
Thank you! :+1:

I have released 0.9.0 with this feature in.

Thank you for helping me! :+1:


Xamarin.Essentials Gelocation: No Altitude property to Location

On the Geolocation page
https://docs.microsoft.com/en-us/xamarin/essentials/geolocation?tabs=android
the example for getting the current location shows an error for Altitude property:
var location = await Geolocation.GetLastKnownLocationAsync();

if (location != null)
{
    Console.WriteLine($"Latitude: {location.Latitude}, Longitude: {location.Longitude}, Altitude: {location.Altitude}");
}

var alt = location.Altutude;
shows a squiggly line under Altitude and message says the property is unknown. It suggests that it should be replaced with Lattitude!
PS: This is not a runtime issue of it being null. Its picked up by Intellisense.

Hi @djaus2, I tried the code in the docs using the latest version of Xamarin.Essentials (0.8.0-preview) on both iOS and Android (making sure to add location permissions in both cases), and everything worked as expected.  Since it appears the docs are correct, and this repository is for documentation-specific issues, I'm going to close this issue.
That said, please try updating to the latest version of Xamarin.Essentials and giving it another try.
If that doesn't work, please feel free to post on Developer Community for support. Thank you!

No Altitude property.

Glad both items were resolved. Thx.
From: Brad Umbaugh<EMAIL_ADDRESS>Sent: Monday, 16 July 2018 11:27 PM
To: MicrosoftDocs/xamarin-docs<EMAIL_ADDRESS>Cc: David Jones<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/xamarin-docs] Xamarin.Essentials Gelocation: No Altitude property to Location (#533)
@djaus2https://github.com/djaus2 Great to hear – glad it's working for you. Thanks for posting how you solved it to help anyone else that has the same issue, I appreciate it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/xamarin-docs/issues/533#issuecomment-405246870, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AL9NEYs977y0GApo1HzfwX0ycX0Xai1kks5uHJS2gaJpZM4VOTWy.


[Feature Request] Allow other bots to queue up songs

Is your feature request related to a problem? Please describe.
I currently have a different custom-created locally-run bot which has a speech-to-text feature built in.
I wanted to add a feature to my other bot to allow requesting songs using voice.
When my bot sends a message, like '!p take on me', JMusicBot does not do anything with it.
I am assuming that JMusicBot automatically cancels any commands from other bots, which makes sense from a security standpoint.
What is your ideal solution to the problem?
Considering the security issues associated with allowing other bots' messages to be read, I would consider adding a whitelist into the config.
This whitelist would consist of bot IDs that the bot is allowed to read messages from.
That way, it can only be done on a case-by-case basis.
How would this feature be used?

Open JMusicBot's config file
Go to line with config property 'botWhitelist'
Add in comma-separated list of bot IDs
Save config
Restart bot

Additional Info
I am hoping that this isn't actually a misuse from my side and that this bot should normally be able to read other bots' messages.
Checklist

[X] I have checked the documentation to make sure this feature doesn't already exist
[X] I have searched for similar feature requests
[X] I have confirmed that my requests is not on the list of things that will not be added
[X] I am running the latest version of the bot:

As far as I am aware, bots invoking other bots is technically against the TOS.


v1.15 envoy: Avoid duplicated upstream callback

This commit is to manually bump envoy image hash to pick up the below fix.
Relates: https://github.com/cilium/proxy/pull/570
Related build: https://github.com/cilium/proxy/actions/runs/7995710357/job/21836617617

/test-backport-1.15

Required reviews are in, CI is green, let's merge it in.


Review of #42 with a few code changes and added some tests

Review for #42:
Adopted code changes from @kroimon and @ThomDietrich, made some changes to _common, _fixtures and sentences and added some tests for hopefully every combination.

@Scorpoon Looks like just a few duplicate test sentences that need to get cleaned up :+1:

@Scorpoon Looks like just a few duplicate test sentences that need to get cleaned up :+1:

Saw the doc folder too late for the lint script explanation, should work now 👍

Awesome, thanks @Scorpoon!

Do i need write permissions to adopt suggestions? @synesthesiam

You can't apply suggestions on an merged PR 😉
You need to create a new one


+info and +balance as the same message?

This is the message for +info with https://github.com/just-an-dev/sodogetip/pull/22
Here are your account details %s!

^very ^info

^Your ^Balance
%s DOGE

^Deposit ^Address
%s

^Withdraw
^+withdraw

%s being whatever is supposed to be replaced and ^ being superscript.
IMO it would make sense to have +info and +balance have this same message, as it shows everything the user needs to know.

yeah there are same info on 2 message maybe delete +info (use same function of balance)

+balance is now using +info. https://github.com/just-an-dev/sodogetip/commit/6a92c7a55a6d35720f9f69c10ae8995a1e4901aa
I think +info is better for balances because it has the nice table with the "very info" header :)


React Server Components: Remove Rollbar Context

Description of the change
React Server Components don't play nicely with Context. So we are removing the dependency on context from our ErrorBoundary
Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Maintenance
[ ] New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists
Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers assigned
[ ] Issue from task tracker has a link to this pull request
[ ] Changes have been reviewed by at least one other engineer

Notes
This also removes our React Hooks. They are also dependent on context, and looking at them they seem like low value adds. The functionality present can easily be replaced by simply importing Rollbar and then calling the config function. This will require updates to documentation

Decided to approach this in a different manner


VectorHand encoding -- and some encoding progress

Early stages for a Networking module that are being pulled in to support some dependencies in the Hierarchy Recorder.
I am not a huge fan of the random Encoding interfaces, they have not been fully fleshed out.

[x] VectorHand should have functioning I/O
[x] We should probably figure out whether we need the interfaces at all, I can just remove them because they probably are overkill right now? The idea is they can provide the common link for different types of hand encodings in a future NetworkedProvider.
[x] The files are placed in Core/Scripts/Encodings because they probably are going to be dependencies for various modules including Networking and the Hierarchy Recorder.

Heyy what do you know, ReadBytes doesn't actually work. Fixin' soon. Don't.. merge.


Failing tests with master and 2.7.0

Hi, I am getting some errors/failures with master (and 2.7.0 as well):
$ testrb -Ilib test/test_*.rb
Testing with Rails 4.0.0
Using standard socket IO (ruby 2.0.0p353 (2013-11-22 revision 43784) [x86_64-linux])
test/test_active_support.rb: cannot load such file -- connection_pool
Run options: -Ilib

# Running tests:

[ 6/96] Dalli::Cas::Client::using a live server#test_0005_handles CAS round-trip operationsFound memcached 1.4.15 in PATH
[ 8/96] Dalli::Cas::Client::using a live server#test_0002_supports multi-get with CAS = 0.02 s
  1) Error:
Dalli::Cas::Client::using a live server#test_0002_supports multi-get with CAS:
NoMethodError: undefined method `second' for ["foo",<PHONE_NUMBER>27567616]:Array
    /home/strzibny/projects/dalli/test/test_cas_client.rb:44:in `block (5 levels) in <top (required)>'
    /home/strzibny/projects/dalli/test/test_cas_client.rb:43:in `each_pair'
    /home/strzibny/projects/dalli/test/test_cas_client.rb:43:in `block (4 levels) in <top (required)>'
    /home/strzibny/projects/dalli/test/memcached_mock.rb:76:in `memcached_cas'
    /home/strzibny/projects/dalli/test/test_cas_client.rb:32:in `block (3 levels) in <top (required)>'

[84/96] Sasl::a server requiring authentication#test_0001_fail SASL authentication with wrong optionsThis server is not built with SASL support.
 = 0.12 s
  2) Failure:
Sasl::a server requiring authentication#test_0001_fail SASL authentication with wrong options [/home/strzibny/projects/dalli/test/test_sasl.rb:45]:
[Dalli::DalliError] exception expected, not
Class: <Dalli::RingError>
Message: <"No server available">
---Backtrace---
/home/strzibny/projects/dalli/lib/dalli/ring.rb:45:in `server_for_key'
/home/strzibny/projects/dalli/lib/dalli/client.rb:328:in `perform'
/home/strzibny/projects/dalli/lib/dalli/client.rb:103:in `set'
/home/strzibny/projects/dalli/test/test_sasl.rb:46:in `block (5 levels) in <top (required)>'
---------------

[87/96] Sasl::a server requiring authentication::without authentication credentials#test_0002_gracefully handl
  3) Failure:
Sasl::a server requiring authentication::without authentication credentials#test_0002_gracefully handle authentication failures [/home/strzibny/projects/dalli/test/test_sasl.rb:35]:
[Dalli::DalliError] exception expected, not
Class: <Dalli::RingError>
Message: <"No server available">
---Backtrace---
/home/strzibny/projects/dalli/lib/dalli/ring.rb:45:in `server_for_key'
/home/strzibny/projects/dalli/lib/dalli/client.rb:328:in `perform'
/home/strzibny/projects/dalli/lib/dalli/client.rb:103:in `set'
/home/strzibny/projects/dalli/test/test_sasl.rb:36:in `block (6 levels) in <top (required)>'
---------------

Finished tests in 15.183154s, 6.3228 tests/s, 952.3054 assertions/s.
96 tests, 14459 assertions, 2 failures, 1 errors, 0 skips

I would expect that the tests would be skipped if memcached is not available. Besides if I run memcached with:
memcached -p 19124 -l localhost
I am still getting the failures (just nothing has been raised at all):
$ testrb -Ilib test/test_*.rb
Testing with Rails 4.0.0
Using standard socket IO (ruby 2.0.0p353 (2013-11-22 revision 43784) [x86_64-linux])
test/test_active_support.rb: cannot load such file -- connection_pool
Run options: -Ilib

# Running tests:

[ 6/96] Dalli::Cas::Client::using a live server#test_0001_supports get with CASFound memcached 1.4.15 in PATH
[10/96] Dalli::Cas::Client::using a live server#test_0002_supports multi-get with CAS = 0.01 s
  1) Error:
Dalli::Cas::Client::using a live server#test_0002_supports multi-get with CAS:
NoMethodError: undefined method `second' for ["foo",<PHONE_NUMBER>03423488]:Array
    /home/strzibny/projects/dalli/test/test_cas_client.rb:44:in `block (5 levels) in <top (required)>'
    /home/strzibny/projects/dalli/test/test_cas_client.rb:43:in `each_pair'
    /home/strzibny/projects/dalli/test/test_cas_client.rb:43:in `block (4 levels) in <top (required)>'
    /home/strzibny/projects/dalli/test/memcached_mock.rb:76:in `memcached_cas'
    /home/strzibny/projects/dalli/test/test_cas_client.rb:32:in `block (3 levels) in <top (required)>'

[86/96] Sasl::a server requiring authentication#test_0001_fail SASL authentication with wrong optionsThis server is not built with SASL support.
 = 0.12 s
  2) Failure:
Sasl::a server requiring authentication#test_0001_fail SASL authentication with wrong options [/home/strzibny/projects/dalli/test/test_sasl.rb:45]:
Dalli::DalliError expected but nothing was raised.

[87/96] Sasl::a server requiring authentication::without authentication credentials#test_0002_gracefully handl
  3) Failure:
Sasl::a server requiring authentication::without authentication credentials#test_0002_gracefully handle authentication failures [/home/strzibny/projects/dalli/test/test_sasl.rb:35]:
Dalli::DalliError expected but nothing was raised.

Finished tests in 15.957208s, 6.0161 tests/s, 906.1109 assertions/s.
96 tests, 14459 assertions, 2 failures, 1 errors, 0 skips

ruby -v: ruby 2.0.0p353 (2013-11-22 revision 43784) [x86_64-linux]

Am I doing something wrong or does this needs to be fixed?

@strzibny It very much looks like you installed a version of Memcached without SASL support.  If this is still an issue, can you please confirm you install Memcached as described in the README?
Closing - please reopen if this is still a problem.


Workflow service Refactor and new implementation

SonarQube analysis reported 17 issues

 2 critical
 5 major
 9 minor
 1 info

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 WorkflowApprovalAPI.java#L64: Remove this useless assignment to local variable "apiName".
 WorkflowApprovalAPI.java#L78: This block of commented-out lines of code should be removed.
 WorkflowApprovalAPI.java#L114: Remove this useless assignment to local variable "operatorId".
 WorkflowApprovalAPI.java#L115: Remove this useless assignment to local variable "operationId".
 WorkflowApprovalAPI.java#L129: This block of commented-out lines of code should be removed.
 WorkflowApprovalAPI.java#L64: Remove this unused "apiName" local variable.
 WorkflowApprovalAPI.java#L68: Move the array designator from the variable to the type.
 WorkflowApprovalAPI.java#L114: Remove this unused "operatorId" local variable.
 WorkflowApprovalAPI.java#L115: Remove this unused "operationId" local variable.
 WorkflowApprovalAPI.java#L119: Move the array designator from the variable to the type.

SonarQube analysis reported 14 issues

 2 critical
 5 major
 6 minor
 1 info

Watch the comments in this conversation to review them.
10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 WorkflowApprovalAPI.java#L64: Remove this useless assignment to local variable "apiName".
 WorkflowApprovalAPI.java#L78: This block of commented-out lines of code should be removed.
 WorkflowApprovalAPI.java#L114: Remove this useless assignment to local variable "operatorId".
 WorkflowApprovalAPI.java#L115: Remove this useless assignment to local variable "operationId".
 WorkflowApprovalAPI.java#L129: This block of commented-out lines of code should be removed.
 WorkflowApprovalAPI.java#L64: Remove this unused "apiName" local variable.
 WorkflowApprovalAPI.java#L68: Move the array designator from the variable to the type.
 WorkflowApprovalAPI.java#L114: Remove this unused "operatorId" local variable.
 WorkflowApprovalAPI.java#L115: Remove this unused "operationId" local variable.
 WorkflowApprovalAPI.java#L119: Move the array designator from the variable to the type.

SonarQube analysis reported 24 issues

 24 info

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 NotificationAPI.java#L38: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L50: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L62: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L74: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L86: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L98: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L109: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L120: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 WorkflowApprovalAPI.java#L45: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 WorkflowApprovalAPI.java#L57: Reduce the number of returns of this method 2, down to the maximum allowed 1.

SonarQube analysis reported 24 issues

 24 info

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 NotificationAPI.java#L38: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L50: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L62: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L74: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L86: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L98: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L109: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 NotificationAPI.java#L120: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 WorkflowApprovalAPI.java#L45: Reduce the number of returns of this method 2, down to the maximum allowed 1.
 WorkflowApprovalAPI.java#L57: Reduce the number of returns of this method 2, down to the maximum allowed 1.

retest this please


The quoting-related operators should be optionally available in their raw form.

This is complicating https://github.com/anko/eslisp/issues/13 and https://github.com/anko/eslisp/issues/23 majorly.

This can be done by using the options object to take an optional option like rawQuoting. It will require a different, new node type for each node, though.

What do you mean by their “raw” form? An example would help.

Like this:
// 'foo
{
  type: "quote",
  value: {type: "atom", value: "foo"}
}

// `foo
{
  type: "quasiquote",
  value: {type: "atom", value: "foo"}
}

// ,foo
{
  type: "unquote",
  value: {type: "atom", value: "foo"}
}

// ,@foo
{
  type: "unquote-splicing",
  value: {type: "atom", value: "foo"}
}

It would make handling those operators consistently tremendously easier in
Eslisp itself, as they're their own data type.
On Sat, Jan 2, 2016, 18:35 An<EMAIL_ADDRESS>wrote:

What do you mean by their “raw” form? An example would help.
—
Reply to this email directly or view it on GitHub
https://github.com/anko/sexpr-plus/issues/3#issuecomment-168438633.

And after #4, it would be literally trivial. Just making this function, depending on the option, return the two-item list or @node quote, @parseExpr!.

The ` ' , ,@ are intended only to be syntactic sugar for calling quasiquote, quote, unquote and unquote-splicing. Exposing in the parser results how exactly one of those was written sounds like it's mixing concerns, which makes maintenance and changing parsers in the future harder. Is this really necessary? Why?

It's not so much mixing concerns. It's making assumptions about how the
output is read and used. Maybe, the API consumer is a custom Lisp
interpreter, and those symbols map to a different type name. Maybe it's an
s-expression based XML template system that has a special syntax for quoted
expressions, but it wants to permit quote to be open for custom mixins.
Maybe it's an s-expression based language that uses symbol instead of
quote, and needs a different data type.
To get the old behavior from this proposal, you'd simply walk the tree and
convert appropriately. So, in other words, this mixes fewer concerns by
assuming less about what the consumer does with the API. It's less
coupled to Eslisp, so it's more inviting to other projects that need it.
On Sun, Jan 10, 2016, 14:59 An<EMAIL_ADDRESS>wrote:

The ` ' , ,@ are intended only to be syntactic sugar for calling
quasiquote, quote, unquote and unquote-splicing. Exposing in the parser
results how exactly one of those was written sounds like it's mixing
concerns https://en.wikipedia.org/wiki/Separation_of_concerns, which
makes maintenance and changing parsers in the future harder. Is this really
necessary? Why?
—
Reply to this email directly or view it on GitHub
https://github.com/anko/sexpr-plus/issues/3#issuecomment-170385949.

I've thought about this.

To get the old behavior from this proposal, you'd simply walk the tree and convert appropriately. So, in other words, this mixes fewer concerns by assuming less about what the consumer does with the API. It's less coupled to Eslisp, so it's more inviting to other projects that need it.

That's a flawed line of reasoning. We could make even fewer assumptions by exposing the entire input string character-by-character to the consumer, but that would make this module redundant. Consumers could then get the "old behaviour" by reimplementing this module.
What makes this parser a useful point on the continuum between exposing nothing and exposing everything is that S-expressions are a frequently understood standard; a structure consisting of lists, atoms and strings. The exact way an atom was written (e.g. 'a vs (quote a)) doesn't figure into that standard. If we expose the way-of-writing information, this would stop being a well-understood standard S-expression parser and start being a poorly understood custom S-expression-and-special-quote-symbols parser, or whatever we'd want to call that.

Maybe it's an s-expression based XML template system that has a special syntax for quoted
expressions, but it wants to permit quote to be open for custom mixins. Maybe it's an s-expression based language that uses symbol instead of quote, and needs a different data type.

Languages that require AST primitives in addition to just atoms, strings and lists are by definition not S-expression-based languages. This is the sacrifice one makes for a simple AST format.
We'll just have to live with (mymacro 'a 'b) and (mymacro (quote a) (quote b)) being indistinguishable.
I feel like the question behind your question here is the currently proposed implementation for https://github.com/anko/eslisp/issues/13 and https://github.com/anko/eslisp/issues/23, which is to reuse the quotes inside the . macro so (. a b)→a[b]; and (. a 'b) → a.b;. I think that would be better to do by having the . macro look through its arguments for lists that start with a quote atom and replacing them with the appropriate estree identifier nodes. The parser doesn't need to care. It would cause (. a (quote b)) → a.b;, but I think that's OK.

@anko I see what you're talking about now. On that note, this is worthy of closing, since you are probably right in that the best way to go for that particular macro is to check against list(atom("quote"), atom("foo")) instead of quote(atom("foo")). I didn't think of that when I initially wrote the patch. :smile:
Closing, as this is rather moot now.


Define Strategy for Container Management Spanning CMSs, Providers, etc.

What happened (or feature request):

Feature request

What you expected to happen:
See roadmap issue https://github.com/drud/ddev/issues/430. One open loop from the comments was the process of defining how flexible we would be in supporting containers across dimensions such as CMS and hosting provider.
How to reproduce this:
Version: Please include the output of ddev version, docker version and the project's .ddev/config.yaml.
Anything else do we need to know:
Related source links or issues:
Please use a complexity rating of 1-5 (5 is high) for a feature request. (High complexity implies more PR planning)

Here's an example where there is a Drupal 7/8 difference where having different default containers would be of value https://github.com/drud/ddev/issues/648.

I think this one is obsolete.


Rc 2.10 -> master after release

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]

@pkdash tests weren't passing before due to network timeout. I triggered them again and now they are good!


Pixelated Text when using Label

Issue: See the attached screenshot for example of issue that some team members are encountering, which are the dark pixels surrounding the label text. I have NOT been able to recreate this issue, but have been notified that multiple team members are encountering this issue both in development and in production. For some, it appears to be a consistent issue, for others, it is more random and only happens from time to time.
We are using a label to add fillColor as well as text to each of these objects, and the pixelation appears to be an issue no matter how near or far the user is zoomed. Any thoughts on what the issue is / some potential solutions are greatly appreciated.
Sandcastle example: N/A
Browser: Chrome 89.0.4389.90
Operating System: Mac OS | Big Sur 11.2.3

There is some discussion here regarding image scaling which you may find relevant: https://github.com/CesiumGS/cesium/issues/7875.
In particular, setting viewer.resolutionScale = window.devicePixelRatio can help with the pixelation. I created an example here:
Sandcastle link.
Without viewer.resolutionScale = window.devicePixelRatio:

With the above set:

viewer.useBrowserRecommendedResolution = false is another way of telling CesiumJS to render at the screen's native resolution.

I think this is the same issue already documented in https://github.com/CesiumGS/cesium/issues/4235. I'm going to close this issue to keep the discussion in one place. If you have any further input on this, please post it there instead.


No default Filament panel is set. You may do this with the default() method inside a Filament provider's panel() configuration.

Lunar version: 1.0.0-beta.6
Laravel Version: 11.33.2
PHP Version: 8.2.12
Database Driver & Version: PostgreSQL 9.2

I am installing with the below steps.
1 | composer create-project laravel/laravel example-store
2 | create database example_store;
3 | Update composer.json"minimum-stability": "dev"
4 | composer require lunarphp/lunar:"^1.0.0-beta" -W
5 | php artisan lunar:install
Expected Behaviour:
It should be installed without error.
Actual Behaviour:
Getting error on 5th step (while migrating database):
No default Filament panel is set. You may do this with the `default()` method inside a Filament provider's `panel()` configuration.

  at vendor/filament/filament/src/Exceptions/NoDefaultPanelSetException.php:17

You have to register the admin panel
https://docs.lunarphp.io/core/installation.html#register-the-admin-panel
Is the step right before to make lunar:install
https://docs.lunarphp.io/core/installation.html#run-the-artisan-installer

Got it, thanks


Async Continuous File Importing 🎉

⚠ Still WIP - Creating PR for anyone who wants to check out the progress! ⚠
Currently Implemented 🎉

Async File System Watching and Scanning
Async File Hashing (Parallel Requests Currently)
New Hub Importing using New Scanning Method
Resumeable Importing on Open
Automatic Thumbnail Extraction, better queuing and progress display

Still To Implement ⏳

Deal with file changes/deletions during and between VHA launches (deal with #381)
Remove unused methods
Bring all scanning to new importing method (simplify?)
Non persistent scanning (no fs-watching)
[x] Persistent -> (re)start any scan with persistence, restart on reopen?
[ ] Persistent -> Cancel any running scan
Fix cancelling thumbnail extraction
Fix duration filtering
Skip initial video count in wizard (cool, but not functional and adds long delay)
Reindex file array to match default sort (or just make default sort by file path)
Convert all fs async methods to promises (there's a library for that)
Fix bugs 🐞
Clean up code

Will close #373 and probably #381 😄

I'm excited to see how the changes improve the app 🎉😄
I'm thinking I should release version 2.2.0 with current master (and maybe another minor bugfix or two -- this/next week) and make this PR part of 2.3.0 release a month or more later.
The main reason is that it's a large-enough change that I'd like to live with it for a bit and test-drive as much as possible before a public release 😅
Hope this timeline is OK for you (and it means you don't have to rush this PR) 🤝

Yep - I wasn't expecting or planning for this to make it into 2.2.0! 👍
And it will need a good bit of testing to make sure all bugs are dealt with!

😭 😍 ❤ 😮 ❗ 🤸♀ 😁 WOW! THIS IS AMAZING!!!
So cool!!!! Thank you so much for this work 🙇 🙇 🙇 🙇 🙇
Please let me know if you'd like me to help out with any part of it!

@cal2195 -- I'm thinking of releasing version 2.2.3 next week 🎉 After that I'd love for this code change to be in the following release (version 2.3.0 as it's a major improvement 💇♂ )
Please let me know if you'd like to do anything more with this branch before I merge it. I'm happy to fix up whatever you feel is unfinished 🙇 🤝
Cheers!

Hey @whyboris - sorry for the delay on this! This have gotten very busy in the last few weeks. 😢 But I'll try find some time this week for it! Most of it that is left is just edge cases, and adding the GUI for turning it on and off! 🎉
If you do have some free time and feel like helping - adding an option to enable persistent scanning on hub creation, along with a synced option in the setting menu to enable/disable it would be awesome! I can do all the logic behind it, but I hate adding the menu options! 😂

No worries! And thank you again for your amazing work!
I'm very happy to do all the GUI stuff -- leave it to me 🤝
Also feel free to leave me with bugs / edge cases to deal with too (if you happen to know what they are please let me know) 👍

I am considering adding multi-source-folder support into the app finally 🎉
I think managing adding/removing input folders should be easy from the "Statistics" tab in the settings (tab name will be renamed).
In the process of adding this feature I'll have to refactor many methods relating to extracting videos. So perhaps trying to fix bugs / edge cases isn't even needed.
I released version 2.2.3 a few days ago, so I can comfortably merge even bug-ridden code 👌 and then work on it along with the major multi-source-folder-support overhaul 😅
@cal2195 Let me know if I should just merge your PR as is (from my initial test it's already stellar 🌟 )
ps - The multi-source-folder feature is not too annoying to get to work -- instead of source folder string it will be a Record<number, string> (I tried new Map() but it fails to persist with JSON.stringify()) and each ImageElement will have a 'source' property with an integer that aligns with the key in the source-folders object 😎

@cal2195 -- I have a very rough draft merging your changes along with my idea of more-than-one-source-folder per hub 🤝 #432
One option is you can change the branch this PR will merge onto: many-folders-async instead of master and I'll take over from there 🤝 🙇

@cal2195 -- if you happen to have a moment to confirm whether I understand the intended process:

On loading a file, we start a file system watcher chokidar

a process that monitors additions / removals in some folder & its subfolders
whenever it detects a new file it adds it (one at a time) into a metadataQueue

metadataQueue processes each file one at a time

if it's not already in the finalArray it extracts video's metadata
sends created metadata to Angular
checks if all required thumbs are present; if any missing, adds video to thumbQueue

thumbQueue processes each file one at a time

creates all the desired thumbs for a video

I like how clean the pipeline is.
I will experiment more and read more, but please let me know if you think there would be any problem monitoring several different folders (run startFileSystemWatching a few times thus creating several chokidar watchers). My initial test suggests 'no', but perhaps you've had some experience with this  setup 😀

When I merge this code into an integration branch would you prefer I Merge pull request or Squash and merge? If you have no preference I'll squash 👍

Hey Boris!
Sorry for the delay, got very busy here (applying for a mortgage), but all you've said sounds good! 👍 Squash and merge sounds good to me!
In case you want to work on finishing this up before I have time, I'll list the outstanding items below that I remember needed to be completed:

Deal with file changes/deletions during and between VHA launches (deal with #381)
Basically when scanning, detect if a file has changed, moved or been deleted and update the array appropriately. This will probably require waiting until the ready event to know if a file is completely gone or moved.
Remove unused methods
This new method will obsolete the old scanning methods.
Bring all scanning to new importing method (simplify?)
As above, all scanning methods (the ones we have buttons for in the app), need to be moved to this scanning method.
Non persistent scanning (no fs-watching)
This one is easy. Just pass persistent: false to chokidar.watch, and events won't be emitted after the final ready event, turning it into a single scan affair. As a bonus, because everything is still emitted as events, it can use the exact same scanning logic as fs-watching mode! 🎉
Persistent -> (re)start any scan with persistence, restart on reopen?
Add a new Persistent button to the settings/new hub wizard. On enabling, restart any scan with persistent: true, and also start the scan if you open the app and you have this option enabled.
Persistent -> Cancel any running scan
When you turn off persistence, cancel any running fs-watching scan.
We'll also need the manual scan buttons we already have, just fire a single scan off with persistent: false. We'll need to keep track of any running chokidar instances.
Fix cancelling thumbnail extraction
This is just not ported for working with the new async queuing method. Easy fix, just clear the queue.
Fix duration filtering
I think I just didn't fill in the duration correctly or something. 🤔
Skip initial video count in wizard (cool, but not functional and adds long delay)
This will help a lot, and isn't required for persistent scanning.
Reindex file array to match default sort (or just make default sort by file path)
Scanning currently just adds each file as it's event is emitted, which I think the order is filesystem dependent. We could just add a default-sort pipe and sort it regardless, or sort it on insertion.
Convert all fs async methods to promises (there's a library for that)
Let's make everything a promise!
Fix bugs 🐞
You know, those annoying things that make things not work.
Clean up code
🤷

I'm hoping to get back to this soon, but this should help if you want to make progress with this feature! Let me know if you have any questions! 👍

Hey Cal!
No worries at all! Good luck with mortgage and the associated purchase 🏠  🎉
Thank you for the clear list of things to do to make the feature production ready 🙇
Much like last time - when you built the foundation of the current image extraction engine, you're again pushing Video Hub App to the next level 🎖 🏅 🥇
I'll likely move some methods you wrote around (to a new file perhaps) but I'll attach credit to it all 🙇 🙇 🙇
Cheers 👋


[DPE-4230] - fix: sort endpoints so not constantly updating

Fixes https://github.com/canonical/opensearch-operator/issues/269, I think

Note: don't worry about HA scaling failures. It's broken. You could merge.


Josh: Consistent formatting on your costs.  In the select room type the price of the queen shows cost as $157.5 without the 0 and in the total costs there is not a $

Completed:


sn gives "The variable _currentScreen is not defined" error

Full error is:
~/.termtile/changeScreen.scpt: execution error: The variable _currentScreen is not defined. (-2753)

I'm not fluent in applescript, but I looked at changeScreen.scpt on master, and it did look like that variable is used on line 24 before it's been declared anywhere.

Right, I've introduced this bug in fullscreen branch :confused:
I've pushed a fix


Create a Media Query - a Chinese user wrote right code but couldn't pass the test

Affected page
https://chinese.freecodecamp.org/learn/responsive-web-design/responsive-web-design-principles/create-a-media-query
Your code

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus quis tempus massa. Aenean erat nisl, gravida vel vestibulum cursus, interdum sit amet lectus. Sed sit amet quam nibh. Suspendisse quis tincidunt nulla. In hac habitasse platea dictumst. Ut sit amet pretium nisl. Vivamus vel mi sem. Aenean sit amet consectetur sem. Suspendisse pretium, purus et gravida consequat, nunc ligula ultricies diam, at aliquet velit libero a dui.

Expected behavior
The code looked good and worked for me (MacOS, Chrome). As the user said, the first word (@media?) was not identified on his end, so he couldn't pass the test.
System (please complete the following information):

Device: Laptop
OS: Windows 10
Browser: QQ
Version: 10.5.2

this is one of the challenges that would benefit from #42373 most
the code is correct and it passes, but there are often browser settings or extensions, or maybe an older browser version that interferes and then it doesn't pass

@ieahleen This challenge already makes use of the new CSSHelp function.
@miyaliu666 Are you able to try this on Safari? If it is going to fail anywhere, it would be there. Otherwise, as Ilenia mentioned, it sounds like an old browser version.

I could not reproduce this on firefox or safari.

It works for me on Safari. I'll let the user check his browser or change another one. Thanks!

@miyaliu666 is this good to close?

@miyaliu666 is this good to close?

Yes, he changed browser and passed the test. Thanks!


Nuxt won't install, postinstall errors for opencollective

➜  nuxt-test npm install --save nuxt

<EMAIL_ADDRESS>postinstall /home/patrick/Programming/nuxt-test/node_modules/nuxt
opencollective postinstall

sh: 1: opencollective: not found
Hi folks, trying to install Nuxt from the documentation.
After running
npm install --save nuxt in my project I get the following -
18809 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
18810 verbose lifecycle<EMAIL_ADDRESS>PATH: /home/patrick/.nvm/versions/node/v8.2.1/lib/node_modules/npm/bin/node-gyp-bin:/home/patrick/Programming/nuxt-test/node_modules/nuxt/node_modules/.bin:/home/patrick/Programming/nuxt-test/node_modules/.bin:/home/patrick/.nvm/versions/node/v8.2.1/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
18811 verbose lifecycle<EMAIL_ADDRESS>CWD: /home/patrick/Programming/nuxt-test/node_modules/nuxt
18812 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'opencollective postinstall' ]
18813 info lifecycle<EMAIL_ADDRESS>Failed to exec postinstall script
18814 verbose unlock done using /home/patrick/.npm/_locks/staging-cc286ed05dfa9616.lock for /home/patrick/Programming/nuxt-test/node_modules/.staging

npm WARN my-app@ No description
npm WARN my-app@ No repository field.
npm WARN my-app@ No license field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>postinstall: `opencollective postinstall`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Here is a gist of the debug log from NPM - https://gist.github.com/patrickbolle/fdc59190506b3797b4806d2b0b8eed23
Any ideas here?
Thanks.

Why not use vue-cli ?

Hi @patrickbolle, which version of node and npm do you have?


expose chart ref

This pull request resolves #6, taking advances of React.forwardRef and React.useImperativeHandle
Breaking Changes
// No more
import { ReactChart } from 'chartjs-react';
ReactChart.register(...);

// Do below
import { ReactChart, register } from 'chartjs-react';
register(...);

// It's no good to add arbitrary props or functions to an FC in TypeScript.
// Let's be definitely typed!

Demo
https://codesandbox.io/s/musing-stallman-wbq7s?file=/src/App.tsx
https://codesandbox.io/s/musing-stallman-wbq7s?file=/src/ReactChartWithRegister.tsx

It's hard to get register under ReactChart however...

Ok. I did a little digging. It's okay to keep `ReactChart.register.
Please refer to https://codesandbox.io/s/musing-stallman-wbq7s?file=/src/ReactChartWithRegister.tsx
However, this would make code a little more complicated. What do you think?
Looking forward to your feedback. I make another pull request if necessary.
Best Regards,
Ace

Ok. I did a little digging. It's okay to keep ReactChart.register.
Please refer to https://codesandbox.io/s/musing-stallman-wbq7s?file=/src/ReactChartWithRegister.tsx
However, this would make the code a little more complicated. What do you think?
Looking forward to your feedback. I could make another pull request if necessary.
Best Regards,
Ace

Hey! First, I want to apologize for this delay and thank you for your participation.

ReactChart.register -  the main idea was to align the syntax with Chart.js to make the wrapper easier to use. I think that this is exactly what we have achieved, so I don’t see any reason to change the syntax yet.
The forwardRef. I once had a similar solution in my mind, but the main problem is that such a solution does little for end-users. One of the main ideas for giving users the ref to the instance is to allow them to add listeners for events like click or hover. As in request: https://github.com/xr0master/chartjs-react/issues/3
In addition, the ref will be null while the canvas element is not mounted, which requires end-users to constantly check if there is an instance.

On the other hand, though... Most of the API will be available
https://www.chartjs.org/docs/next/developers/api

After some thought, I still think that such a pattern will not be stable and effective. At the moment, I added the ability to specify the chart ID, which makes it possible to get an instance through the API Chart.
const myChartInstance = Chart.getChart('unique-chart-id');

Thank you very much!


Image component features

Here's a list of potential features for Hydrogen's Image component:

[x] Support for external images
[ ] Support for loading app static images
[x] Enforce width and height attributes for better performance
Image loading optimizations:

[x] Default lazy load images
[ ] Preload images

[ ] Support image loaders

[x] Inline loaders
[ ] Global loaders

Support responsive images:

[ ] Add srcset and sizes to image
[ ] Global settings for sizes

[ ] Support low quality image placeholders

Closing and opening #1223.


Testing instantiation with argument of a type that we didn't generate bindings for

Input C/C++ Header
namespace JS {
template <typename a> class Rooted { a b; };
class AutoValueVector : Rooted<int> {
  using Vec = int;
  using c = Rooted<Vec>;
};
}

Bindgen Invocation
Some complicated thing from SM bindings. Will see what more minimal flags required are and report back.
Actual Results
/* automatically generated by rust-bindgen */

#![feature(const_fn)]
pub use self::root::*;
unsafe impl Sync for JSClass {}
unsafe impl Sync for JSFunctionSpec {}
unsafe impl Sync for JSNativeWrapper {}
unsafe impl Sync for JSPropertySpec {}
unsafe impl Sync for JSTypedMethodJitInfo {}

#[allow(non_snake_case, non_camel_case_types, non_upper_case_globals)]
pub mod root {
    #[allow(unused_imports)]
    use self::super::root;
    pub mod JS {
        #[allow(unused_imports)]
        use self::super::super::root;
        #[repr(C)]
        #[derive(Debug, Copy, Clone)]
        pub struct Rooted<a> {
            pub b: a,
            pub _phantom_0: ::std::marker::PhantomData<::std::cell::UnsafeCell<a>>,
        }
    }
    #[test]
    fn __bindgen_test_layout_Rooted_instantiation_1() {
        assert_eq!(::std::mem::size_of::<root::JS::Rooted<::std::os::raw::c_int>>()
                   , 4usize , concat ! (
                   "Size of template specialization: " , stringify ! (
                   root::JS::Rooted<::std::os::raw::c_int> ) ));
        assert_eq!(::std::mem::align_of::<root::JS::Rooted<::std::os::raw::c_int>>()
                   , 4usize , concat ! (
                   "Alignment of template specialization: " , stringify ! (
                   root::JS::Rooted<::std::os::raw::c_int> ) ));
    }
    #[test]
    fn __bindgen_test_layout_Rooted_instantiation_2() {
        assert_eq!(::std::mem::size_of::<root::JS::Rooted<root::JS::AutoValueVector_Vec>>()
                   , 4usize , concat ! (
                   "Size of template specialization: " , stringify ! (
                   root::JS::Rooted<root::JS::AutoValueVector_Vec> ) ));
        assert_eq!(::std::mem::align_of::<root::JS::Rooted<root::JS::AutoValueVector_Vec>>()
                   , 4usize , concat ! (
                   "Alignment of template specialization: " , stringify ! (
                   root::JS::Rooted<root::JS::AutoValueVector_Vec> ) ));
    }
}

And then this fails to compile because we don't emit any definition for AutoValueVector_Vec:
error[E0412]: cannot find type `AutoValueVector_Vec` in module `root::JS`
  --> js.rs:42:70
   |
42 |         assert_eq!(::std::mem::align_of::<root::JS::Rooted<root::JS::AutoValueVector_Vec>>()
   |                                                                      ^^^^^^^^^^^^^^^^^^^ not found in `root::JS`

Expected Results
We probably should just avoid emitting tests of any instantiation involving non-whitelisted things.

It seems that --enable-cxx-namespaces --whitelist-type JS::Rooted is enough to trigger this.

Slightly more reduced test case:
// bindgen-flags: --enable-cxx-namespaces --whitelist-type Rooted

template <typename T>
class Rooted {
    T member;
};

class AutoValueVector : Rooted<int> {
    using IntAlias = int;
    using RootedIntAlias = Rooted<IntAlias>;
};

We probably should just avoid emitting tests of any instantiation involving non-whitelisted things.

Alternatively, we should consider the argument type whitelisted, and should emit bindings for it. I think that this is what is supposed to be happening, but we are collapsing a type alias away (or maybe libclang is doing this before giving it to us...).

Ok, here's what's going on: the alias is whitelisted, but because its parent is a struct, and not a module, and its parent struct is not whitelisted, we don't ever add it as a child of a module in BindgenContext::add_item and therefore don't ever generate a definition for it in the codegen phase.


Add nominee: Period Dignity Bristol

Automatic addition of a new nominee submitted through the online form available at https://digitalpublicgoods.net/submission

@lacabra please note that the licenseURL and repositoryURL as per now point to a generic link. Proposing to contact the project owner to share a more explicit URL. Thanks.

@lacabra please note that the licenseURL and repositoryURL as per now point to a generic link. Proposing to contact the project owner to share a more explicit URL. Thanks.

@nathanbaleeta Yes please do, and circle back when you hear back 👍

@nathanbaleeta Yes please do, and circle back when you hear back 👍

Feedback from the project contact person clarified the following about the repos:

The client and server repos have the frontend and backend code for the app itself.
The wrapper repo is to help developers to spin up a local development environment with both frontend and backend code running to work on.

PS:  The above repo updates are found in commit ed958b3

Thanks @nathanbaleeta, this looks ready for your formal review and approval.


can't clone - repository corrupt?

$ go get -v github.com/remogatto/gospeccy/src/gospeccy
github.com/remogatto/gospeccy (download)
# cd .; git clone https://github.com/remogatto/gospeccy /Users/pmoore/go/src/github.com/remogatto/gospeccy
Cloning into '/Users/pmoore/go/src/github.com/remogatto/gospeccy'...
error: object cec29ea04ebd325e17a9defbd2ec1c027eaf703b: zeroPaddedFilemode: contains zero-padded file modes
fatal: Error in object
fatal: index-pack failed
package github.com/remogatto/gospeccy/src/gospeccy: exit status 128

It worked fine for me just now on Ubuntu 16.04 with go1.8.1 and git 2.7.4. Have you got recent versions of those?
Also, it might need some work before it will build/run on Mac/Windows (especially the latter), one of which you seem to be using. I've only run it on linux.

I thought I might see if I can help out with a Mac port (even maybe Windows!)
I'm using
pmoore@Petes-iMac:~/go/src/github.com/petemoore $ uname -a
Darwin Petes-iMac.local 15.6.0 Darwin Kernel Version 15.6.0: Fri Feb 17 10:21:18 PST 2017; root:xnu-3<IP_ADDRESS>.1~1/RELEASE_X86_64 x86_64
pmoore@Petes-iMac:~/go/src/github.com/petemoore $ git version
git version 2.12.0
pmoore@Petes-iMac:~/go/src/github.com/petemoore $ go version
go version go1.8 darwin/amd64
pmoore@Petes-iMac:~/go/src/github.com/petemoore $

I can work around the issue by just cloning with a depth of 1, although that might be tricky for feeding back Pull Requests later. Not to worry, I'll see if I can find out what is going wrong.

The zeroPaddedFileMode problem can be seen because you have fsckobjects = true in your ~/.gitconfig

Hope jabley's tip helps. And sure it would be nice to see it work on mac/windows. For starters, some of the sdl interface files currently have '+build' directives restricting to linux/freebsd that will need to be fixed. That's all I know off hand.

Indeed, that was the case, thanks @jabley and @ivorget!
@ivorget If you run git fsck in your repository, you should see the same problems. It looks like fsck checking is disabled on fetch by default in most git distros, but I think it is diagnosing a genuine issue. I was able to repair the history, but most of the commit SHAs changed (starting from about the 5th commit) so you may prefer not to that. Anyway, I can work with it by disabling the fsck checking when working with this repo.


use uv?

Hi and thanks for the action.  currently, I'm doing this to use uv:
      - name: Install rye
        uses: eifinger/setup-rye@v2

      - name: Install library
        run: |
          rye config --set-bool behavior.use-uv=true
          rye sync

is that the recommended approach or am I missing a feature?

That is how I am doing it as well

ok thanks!  feel free to close this if it's unlikely to be added to the top level options 👍


CPU

Hi, can the code run in win10+pytorch(CPU) environment？

This version works on CPU only on old PyTorch 0.4 version and python 2.x
If you work with PyTorch 1.x and python 3.x you can try my my implementation of this work that full work on CPU.

Hello, I took a look at the link you provided, may I ask if there is a detailed readme tutorial？
------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2020年4月14日(星期二) 下午2:52
收件人<EMAIL_ADDRESS>抄送: "痴"<2957574745<EMAIL_ADDRESS>主题: Re: [jwyang/faster-rcnn.pytorch] CPU (#772)
This version works on CPU only on old PyTorch 0.4 version and python 2.x
If you work with PyTorch 1.x and python 3.x you can try my my implementation of this work that full work on CPU.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I'm working on it right now. Coming soon.

Do you need to change the code to run in a CPU environment?
---Original---
From: "Andrey<EMAIL_ADDRESS>Date: Fri, Apr 17, 2020 23:47 PM
To<EMAIL_ADDRESS>Cc: "Author"<author<EMAIL_ADDRESS>Subject: Re: [jwyang/faster-rcnn.pytorch] CPU (#772)
I'm working on it right now. Coming soon.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Do you need to change the code to run in a CPU environment?

No, network implementation that i left by link above already working on CPU. For quick start, just follow readme.
Now i'm working on some docs in addition to help message in CLI.


Add combat calculator to skill calc

What:

More skill calculator features

Solution 1:

Strength, attack, defense, and range calculator ~ Search for a monster, enter the amount of times you plan on killing it, and calculate xp gained for killing that many monsters.

Why:

All the other skills have ways to calculate the number of actions needed, so why not add the ability to calculate the potential xp gained from killing monsters. I'm aware that the xp rate is the same throughout all the levels (1dmg to 4xp), but it would still be nice to be able to have a quick way to calculate this.

Solution 2:

Add an actual calculator to the skill calculator.

Why:

Because it shows a calculator icon for the skills calculator, but there's not even an actual calculator tucked in there somewhere.
Ex: I was trying to calculate how many runs I'd need to do to get my construction to 50, from 38, and
RuneLite shows I should make 146 Oak Larders. Knowing I can only make three larders per inventory, I scrolled to the top of the skill calculator to see if there was a real calculator so I could calculate the number of trips I'd be making. 146/3=48.67 ~ 49 trips. I know there are real calculators everywhere, but to have it in the client would just allow more ease-of-access.

Adding an actual calculator to the skills calculator seems really excessive and not a good idea. Why would we want to duplicate development work between runelite and the windows (or osx and linux) native calculator app. It takes less than 5 seconds to open the os native calculator app so it seems like a waste of time to add one into Runelite.
But having skill calculator features for attack, strength, defense and range seems reasonable. It would probably be better to have them based on attack style since in addition to being able to train those individually there are options to train them together which affects the xp per kill. (also we can add constitution into this bit of calculation). Perhaps the calculator for each skill, attack, strength, defense, etc... would let you use a radio button to select which attack style you want to use for the calculation. We already have the hp data per monsters so I definitely see it as feasible to allow the user to search for a monster (we'll need two search boxes - combat level and name to uniquely identify the target) and then compute the xp gains per kill (and as such the kills until goal level) for that monster. Additionally since we have a map of monster to slayer xp we can do the same for slayer in addition to just the main combat skills.

We could always scrape the wiki for this info could we not?


Quotes being escaped in  CSS

[X] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Bug: the single quotes are escaped when they shouldn't be in this code:
<Head>
  <style>{`
  body {
    display: flex;
    align-items: center;
    justify-content: center;
    background: url('/static/img/bg.jpg');
  }
  `}</style>
</Head>

Current Behavior

This is rendered as:
  <style class="next-head">
  body {
    display: flex;
    align-items: center;
    justify-content: center;
    background: url('/static/img/bg.jpg');
  }
  </style>

Which is incorrect.
Steps to Reproduce (for bugs)

See above code

Context

This makes using URL resources or fonts with spaces in  CSS close to impossible.
Your Environment

Tech
Version

next
3.2.1

node

OS

browser

etc

This is basic react functionality which we won't be able to change. You can use dangerouslySetInnerHtml to inject without escaping. If you're doing global styling you can also use <style jsx global>{html { background: red; }}</style>. In that case please don't use <Head> around it 👍

Yep, read the docs a bit more and realized that style global works outside of Head. Thanks!

Great 🙌


Templatize the template!

Pull everything pracitical out.  Plan for secret storage.  Load into pipelines and .yml (templates).

Done!


Migration Create Error - Undefined index: version

Hi everyone!
I trying to use Yii Migrations with the follow command:
./yii migrate/create migration_name
and the Migration Tool return the error below:
PHP Notice 'yii\base\ErrorException' with message 'Undefined index: version'

in /Users/kildersonsena/web-workspace/cadimoweb/vendor/yiisoft/yii2/console/controllers/MigrateController.php:336

Stack trace:
#0 /Users/kildersonsena/web-workspace/cadimoweb/vendor/yiisoft/yii2/console/controllers/MigrateController.php(336): yii\base\ErrorHandler->handleError(8, 'Undefined index...', '/Users/kilderso...', 336, Array)
#1 /Users/kildersonsena/web-workspace/cadimoweb/vendor/yiisoft/yii2/console/controllers/BaseMigrateController.php(631): yii\console\controllers\MigrateController->getMigrationNameLimit()
#2 [internal function]: yii\console\controllers\BaseMigrateController->actionCreate('migration_name')
#3 /Users/kildersonsena/web-workspace/cadimoweb/vendor/yiisoft/yii2/base/InlineAction.php(57): call_user_func_array(Array, Array)
#4 /Users/kildersonsena/web-workspace/cadimoweb/vendor/yiisoft/yii2/base/Controller.php(157): yii\base\InlineAction->runWithParams(Array)
#5 /Users/kildersonsena/web-workspace/cadimoweb/vendor/yiisoft/yii2/console/Controller.php(135): yii\base\Controller->runAction('create', Array)
#6 /Users/kildersonsena/web-workspace/cadimoweb/vendor/yiisoft/yii2/base/Module.php(528): yii\console\Controller->runAction('create', Array)
#7 /Users/kildersonsena/web-workspace/cadimoweb/vendor/yiisoft/yii2/console/Application.php(180): yii\base\Module->runAction('migrate/create', Array)
#8 /Users/kildersonsena/web-workspace/cadimoweb/vendor/yiisoft/yii2/console/Application.php(147): yii\console\Application->runAction('migrate/create', Array)
#9 /Users/kildersonsena/web-workspace/cadimoweb/vendor/yiisoft/yii2/base/Application.php(386): yii\console\Application->handleRequest(Object(yii\console\Request))
#10 /Users/kildersonsena/web-workspace/cadimoweb/yii(27): yii\base\Application->run()
#11 {main}

I dont find out nothing about this, so... I created the issue here for this.

Q
A

Yii version
<IP_ADDRESS>

PHP version
7.1.11

Database
PostgreSQL

Operating system
MacOS

Are you able to reproduce it on clean basic application template?

Firstly, thanks for your answer @samdark ! In a clean basic template application is working. However, a few days ago I used the migrations tools and was working normally. I dont changed nothing in the core, I only running yesterday and appears this error.
What would this "version" that is returning? I tried fix, but, not successful. Can you help me?

Sorry! The single thing that I changed was the composer.json requirements. See below:
PS: I dont know if this has anything to do with the error, but, was the single modification.
{
    "name": "yiisoft/yii2-app-advanced",
    "description": "Cadimo WEB",
    "authors": [
        {
            "name": "Kilderson Sena",
            "email"<EMAIL_ADDRESS>        },
        {
            "name": "Diego Pedrosa",
            "email"<EMAIL_ADDRESS>        }
    ],
    "homepage": "http://www.cadimoweb.com.br",
    "type": "project",
    "license": "BSD-3-Clause",
    "support": {
        "issues": "https://github.com/yiisoft/yii2/issues?state=open",
        "forum": "http://www.yiiframework.com/forum/",
        "wiki": "http://www.yiiframework.com/wiki/",
        "irc": "irc://irc.freenode.net/yii",
        "source": "https://github.com/yiisoft/yii2"
    },
    "minimum-stability": "stable",
    "repositories": [
        {
            "type": "composer",
            "url": "https://asset-packagist.org"
        }
    ],
    "require": {
        "php": ">=7",
        "ext-intl": "*",
        "ext-mbstring": "*",
        "ext-soap": "*",
        "yiisoft/yii2": "~2.0.11",
        "yiisoft/yii2-bootstrap": "~2.0.0",
        "yiisoft/yii2-swiftmailer": "~2.0.0",
        "yiisoft/yii2-jui": "~2.0.0",
        "kartik-v/yii2-widget-growl": "*",
        "kartik-v/yii2-widget-activeform": "^1.4",
        "kartik-v/yii2-widget-select2": "2.0.8",
        "kartik-v/yii2-widget-datepicker": "@dev",
        "kartik-v/bootstrap-fileinput": "dev-master",
        "yiibr/yii2-br-validator": "*",
        "mpdf/mpdf": "^6.1",
        "kartik-v/yii2-widget-fileinput": "@dev",
        "bower-asset/jquery-numeric_input": "@dev",
        "bower-asset/bootstrap-datepicker": "@dev",
        "bower-asset/lightbox2": "*",
        "bower-asset/jquery-maskmoney": "^3.0.2",
        "bower-asset/bootstrap-toggle": "^2.2",
        "bower-asset/select2": "^4.0",
        "bower-asset/bootstrap-fileinput": "^4.4",
        "bower-asset/summernote": "^0.8.6",
        "dersonsena/yii2-widget-inputsaddon": "@dev",
        "dersonsena/cadimoweb-gii": "^1"
    },
    "require-dev": {
        "yiisoft/yii2-debug": "~2.0.0",
        "yiisoft/yii2-gii": "~2.0.0",
        "yiisoft/yii2-faker": "~2.0.0",
        "codeception/base": "^2.2.3",
        "codeception/verify": "~0.3.1",
        "codeception/codeception": "^2.3",
        "deployer/deployer": "^6.0"
    },
    "config": {
        "process-timeout": 1800
    }
}

How does your migration table look like? Did you accidentally create a migration table with a wrong structure manually?

Hi @schmunk42 ! In fact, when I execute the command it already issues this error. Since it is something version related, I will put another version of my postgresql.

I just figured out the problem! I had a similar issue with this issue [#13229].
(https://github.com/yiisoft/yii2/issues/13229) by commit #8f5f5
The error is giving in the method below:
protected function getMigrationNameLimit()
{
    if ($this->_migrationNameLimit !== null) {
        return $this->_migrationNameLimit;
    }
    $tableSchema = $this->db->schema ? $this->db->schema->getTableSchema($this->migrationTable, true) : null;
    if ($tableSchema !== null) {
        // The error happens in the line below...
        return $this->_migrationNameLimit = $tableSchema->columns['version']->size;
    }

    return static::MAX_NAME_LENGTH;
}

If run the print_r($tableSchema->columns) returns:
Array
(
    [VERSION] => yii\db\ColumnSchema Object
        (
            [name] => VERSION
            [allowNull] =>
            [type] => string
            [phpType] => string
            [dbType] => varchar
            [defaultValue] =>
            [enumValues] =>
            [size] => 180
            [precision] =>
            [scale] =>
            [isPrimaryKey] => 1
            [autoIncrement] =>
            [unsigned] =>
            [comment] =>
        )
    [APPLY_TIME] => yii\db\ColumnSchema Object
        (
            [name] => APPLY_TIME
            [allowNull] => 1
            [type] => integer
            [phpType] => integer
            [dbType] => int4
            [defaultValue] =>
            [enumValues] =>
            [size] =>
            [precision] => 32
            [scale] => 0
            [isPrimaryKey] =>
            [autoIncrement] =>
            [unsigned] =>
            [comment] =>
        )
)

All the fields in my database are in the uppercase, so it is necessary to make the same correction that was made in the issue quoted at the beginning:
protected function getMigrationNameLimit()
{
    if ($this->_migrationNameLimit !== null) {
        return $this->_migrationNameLimit;
    }
    $tableSchema = $this->db->schema ? $this->db->schema->getTableSchema($this->migrationTable, true) : null;
    if ($tableSchema !== null) {
        if ($this->db->slavePdo->getAttribute(\PDO::ATTR_CASE) === \PDO::CASE_UPPER) {
            $tableSchema->columns = array_change_key_case($tableSchema->columns, CASE_LOWER);
        }
        return $this->_migrationNameLimit = $tableSchema->columns['version']->size;
    }

    return static::MAX_NAME_LENGTH;
}

Tests also fail on PgSQL >=9.5 see https://github.com/yiisoft/yii2/issues/15254 - but the error looks not directly related.

maybe you upgraded your PG version?

I'm using the PostgreSQL 9.6, but, this error appears in the versions 9.5 and 9.6! The code above worked in the 2 versions :)

@dersonsena try PostgreSQL 9.4

Hi @bscheshirwork! My production Postgresql Version is 9.5, so .... my Postgresql container it has to be highter 9.5. But, this solution above fix the problem... How @klimov-paul helped me in another issue ;)

@dersonsena you can add link to  @klimov-paul 's comment?
PostgreSQL v9.5 not convert default values to column format.
check your default value for this problem.
int column can contain string default value
float column can contain string default value
10.0 also not convert CURRENT_TIMESTAMP to now(), convert to string 'CURRENT_TIMESTAMP'
#15266

But in the issue that was solved the problem was the uppercase array keys. Same thing happened here. Upstairs has the commit links and the issue.


Cluster upscale flow refactor for new recipes handling

@keyki pls review

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/cloudbreak-pull-request/2700/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/191/


2.x

Prep for 2.x.

@buzzdeee I believe this is ready for merge.  If you are not ready for Puppet4, you may want to pin the version of this module to the latest 1.x.

Jepp, I'm on my boxes @home with Puppet 4.x now, if you merge, and I run into trouble, I'll cry out loud ;)
A couple of month ago, I took over Puppet maintainership from jasper@, and we agreed, with hist last duty, he disabled puppet3.
And, there is even some progress getting the puppetserver up and running now:
https://tickets.puppetlabs.com/browse/SERVER-14
\o/


Logo Proposal for mTasks

Hello,
This my logo/Icon design for your project.I design this logo using adobe illustrator cc 2017. I hope you like this logo

If you need anything change please contact me
Md Nazmul Hasan
Email<EMAIL_ADDRESS>Thank You.

Thank you for creating this logo. I am not looking for a logo now as the project name could change or I may want to purchase another domain and start building on that. It would be bad if I market it now later shift to something else.
But when I will require one, I'll definitely ping you.


graphiql: update readme

No changeset since there was no functional change.
Fixes #4032

Aww yeah good point on the readme on npm, added a changeset

Aww yeah good point on the readme on npm, added a changeset


Transform stack for custom virtual modules are not present

Describe the bug
I have a custom loader that intercepts funky-looking import specifiers, ala: import foo from "prefix:some-argument".
const prefix = "custom-loader:";

export default function customLoader() {
  return {
    name: "custom-loader",

    resolveId(id) {
      if (id.startsWith(prefix)) return "\0" + id;
    },

    load(id) {
      if (!id.startsWith("\0")) return;
      if (!id.slice(1).startsWith(prefix)) return;
      const arg = id.slice(1 + prefix.length);
      return `export default ${JSON.stringify(arg)}`;
    },
  };
}

vite.config.js
import { defineConfig } from "vite";
import customLoader from "./custom-loader.mjs";
import Inspect from "vite-plugin-inspect";

export default defineConfig({
  plugins: [customLoader(), Inspect()],
});

As per rollup convention:

If your plugin uses 'virtual modules' (e.g. for helper functions), prefix the module ID with \0. This prevents other plugins from trying to process it.

But the transform stack of such virtual modules are empty (aka. I cannot see the result of a load step)

Reproduction
https://stackblitz.com/edit/vitejs-vite-g5udhe?file=custom-loader.mjs
System Info
System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.6.12 - /usr/local/bin/pnpm

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Just stumbled upon this as well. As a workaround i have to use a simple console.log in the meantime.

Interesting — I just ran a quick trace on this and it seems the hijack for load doesn’t work on custom virtual modules. The result of this line is null:
https://github.com/antfu/vite-plugin-inspect/blob/main/src/node/hijack.ts#L104

The virtual module content not added to the recorder since the rollup filter is returning false: we need to apply the filter in resolveId hook, the filter should be applied to the original id and not in the resolved id.

Playground working after updating to latest 0.8.4 release: https://stackblitz.com/edit/vitejs-vite-qu7ibm?file=package.json,vite.config.js


NPM signatures suggestions

Didn't know NPM finally supported plain ECDSA signatures, rather than PGP. Hurray 🎉
Just a few suggestions:

Prefer public_key:verify over crypto:verify, removing a few unnecessary assumptions
Prefer or over ||, as per https://hexdocs.pm/elixir/main/code-anti-patterns.html#non-assertive-truthiness

(Was going to add signature lookup by public key ID, but I saw that's already proposed in #67)

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


Fix audit issues

Description
This pull request changes the following:

Fixes the issue outlined in the audit report

Related Issues

Closes #308

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 30.58%. Comparing base (2d16494) to head (edb12e1).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   30.58%   30.58%
=======================================
  Files           7        7
  Lines         206      206
  Branches       48       48
=======================================
  Hits           63       63
+ Misses        143      134    -9
- Partials        0        9    +9

Files
Coverage Δ

...a-wallet-snap/packages/snap/src/utils/SnapUtils.ts
68.75% <100.00%> (ø)

... and 3 files with indirect coverage changes


[Impeller] Add an FML_CHECK to initial host buffer creation

https://github.com/flutter/engine/blob/main/impeller/core/host_buffer.cc#L31-L33

I'll do this.  I'll also change the allocator signature to use StatusOr so we'll get a good assert message.

I changed my mind about StatusOr.  It was a bit involved and since the return type is a pointer where null previously meant some sort of error I was a bit worried about confusing errors since you'd have to check FML_CHECK(buffer.ok() && buffer.value()) everywhere.

fml::StatusOr is not really great for APIs that return pointers, because you end up with the Java Optional problem where you can have fml::Status(value), fml::Status(nullptr), fml::Status(nullptr, failure).


Failing to compile: "undefined: net.ListenConfig"

Hi there,
I'm running into an error when attempting to compile singularity-server
Steps Taken

go get -v github.com/nccgroup/singularity
cd ~/go/src/github.com/nccgroup/singularity/cmd/singularity-server
go build

Output:
# github.com/nccgroup/singularity
../../singularity.go:797:20: undefined: net.ListenConfig

I'm on a fresh Ubuntu 18.04.4 VPS with Golang 1.10.4 installed. Any tips would be greatly appreciated!

Easy fix: I didn't realize the official Ubuntu apt repos had a pretty outdated version of golang. Installed 1.14 and it compiled no problem.


Add default for EnginePlugin.getEngineFactory

Description
Adds default implementation for getEngineFactory in EnginePlugin. The
default just returns Optional.empty(), allowing plugin developers to
implement this plugin without implementing this method.
Related issues: #1805
Issues Resolved
#2418
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jmazanec15 does other plugins will have to make any change on their end as well?

@jmazanec15 does other plugins will have to make any change on their end as well to incorporate this?

No change needed. Adding default will just allow plugin implementors to skip implementing getEngineFactory as noop.

@jmazanec15 can you create an issue to add tests for the other methods present in EnginePlugin file? Thanks

start gradle check

@jmazanec15 @owaiskazi19 there is a large number of tests under EngineConfigFactoryTests, it might be better to move the new one there as well.

@reta I can move the unit test to EngineConfigFactory, but what would the benefit be? It is not testing the functionality of the EngineConfigFactory, its more so testing the default of the interface works as expected.
Also, @reta @owaiskazi19 do you have any ideas on why "org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards" is failing? It seems to be unrelated, but I cannot find reference elsewhere or similar failures on other PRs. Scanning the log, I see this:
  1> [2022-03-10T02:23:45,606][INFO ][o.o.c.m.MetadataIndexStateService] [node_t0] completed closing of indices [test12]
  1> [2022-03-10T02:23:48,598][INFO ][o.o.c.m.MetadataCreateIndexService] [node_t0] [test13] creating index, cause [api], templates [], shards [5]/[1]
  1> [2022-03-10T02:23:50,839][INFO ][o.o.c.r.a.AllocationService] [node_t0] Cluster health status changed from [RED] to [YELLOW] (reason: [shards started [[test12][1], [test12][3], [test12][2], [test12][0], [test12][4], [test13][1], [test13][3], [test13][4]]]).
  1> [2022-03-10T02:23:54,112][INFO ][o.o.c.m.MetadataIndexStateService] [node_t0] closing indices [test13/vo6FWb7_T-28zuI25nND3Q]
  1> [2022-03-10T02:23:54,285][INFO ][o.o.c.r.a.a.BalancedShardsAllocator] [node_t0] Cannot move any shard in the cluster as there is no node on which shards can be allocated. Skipping shard iteration
  1> [2022-03-10T02:23:54,799][INFO ][o.o.c.m.MetadataIndexStateService] [node_t0] completed closing of indices [test13]
  1> [2022-03-10T02:23:54,812][INFO ][o.o.c.r.a.a.BalancedShardsAllocator] [node_t0] Cannot move any shard in the cluster as there is no node on which shards can be allocated. Skipping shard iteration

...
  1> java.lang.IllegalStateException: transport not ready yet to handle incoming requests

but not much else. Also, I was not able to repro locally:
./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards" -Dtests.seed=FF9F1BDE6DF4DC66
Picked up JAVA_TOOL_OPTIONS: -Dlog4j2.formatMsgNoLookups=true

> Configure project :qa:os
Cannot add task 'destructiveDistroTest.docker' as a task with that name already exists.
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.3.3
  OS Info               : Mac OS X 10.16 (x86_64)
  JDK Version           : 14 (OpenJDK)
  JAVA_HOME             : /Users/jmazane/.sdkman/candidates/java/14.0.2-open
  Random Testing Seed   : FF9F1BDE6DF4DC66
  In FIPS 140 mode      : false
=======================================

> Task :server:internalClusterTest
Picked up JAVA_TOOL_OPTIONS: -Dlog4j2.formatMsgNoLookups=true
OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=warn; support was removed in 17.0
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.opensearch.bootstrap.BootstrapForTesting (file:/Users/jmazane/workspace/Opensearch/mine/OpenSearch/test/framework/build/distributions/framework-2.0.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.opensearch.bootstrap.BootstrapForTesting
WARNING: System::setSecurityManager will be removed in a future release
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/Users/jmazane/.gradle/wrapper/dists/gradle-7.3.3-all/4295vidhdd9hd3gbjyw1xqxpo/gradle-7.3.3/lib/plugins/gradle-testing-base-7.3.3.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

BUILD SUCCESSFUL in 3m 31s
44 actionable tasks: 1 executed, 43 up-to-date

@jmazanec15 it's flaky test. We have an issue for it: https://github.com/opensearch-project/OpenSearch/issues/1561.

start gradle check

@reta I can move the unit test to EngineConfigFactory, but what would the benefit be? It is not testing the functionality of the EngineConfigFactory, its more so testing the default of the interface works as expected.

If you look at this test case, EngineConfigFactoryTests, it basically exercises the large part of the EnginePlugin so we could add getEngineFactory tests as well, but this is just a suggestion (the benefit would be to keep  EnginePlugin tests in a single place).

@reta got it! Just moved the test


Sharing an animated gif loses the animation

Hello,
Thanks for your great work on this! I'm using this syntax to share images:
window.plugins.socialsharing.share(null, null, 'http://domain.com/image.gif');

image.gif is an animated gif. When it shares, such as via SMS, the animation is lost and only the first frame shares. Is there any way around that?
Thanks,
Matt

Does this help?
https://stackoverflow.com/questions/37007067/ios-share-gif-animated-image-not-working