Hardware Section!

Description
https://deploy-preview-1713--privacytools-io.netlify.com/hardware/
This is a WIP draft but it's a start. TODO:

[x] Mobile device recommendations
[x] U2F key recommendations
[x] PC recommendations
[ ] https://github.com/privacytoolsIO/privacytools.io/issues/904#issuecomment-586592856?

Closes: 904 (Actually we should probably merge this PR and add laptops/desktops at a later date)
Closes: #616 (supersedes, we will try to eventually import the useful content from that PR here)
Closes: #989 (supersedes)
Closes: #420
Closes: #1714
Closes: #1731
Related: https://github.com/privacytoolsIO/privacytools.io/issues/832#issuecomment-489236848 (Pixel+Graphene info)

Were any of my recommendations useful?

Nice; glad to see a PR for a new hardware section!

@5a384507-18ce-417c-bb55-d4dfcc8883fe link?

Is this really a good phrase to use?

The iPhone 11 Pro and the iPhone 11 are the most secure and tested mobile devices on the market.

Wouldn‘t it be better to say „one of the most secure“ instead of „the most secure“ ?
Also: Doesn‘t the FairPhone2 come with a modified Stock Android by default? Or does it really come with UbuntuTouch preloaded?
Apologies, I don’t really know how to participate here on github or with this repo properly..

Isn’t the YubiKey closed-Source Hardware (and maybe even software?)?
NitroKeys is open hard- and software as far as I know.
What about this one as well? https://onlykey.io/

NitroKeys is open hard- and software as far as I know?
But YubiKey‘s Hardware/firmware has never been OpenSource or audited:

https://www.yubico.com/blog/secure-hardware-vs-open-source/
The YubiKey hardware with its integral firmware has never been open sourced

So, what made you prioritize YubiKey over the others / mentioning it first? Yubikey also had security issued if I remember correctly: https://www.schneier.com/blog/archives/2019/07/yubico_security.html
Good to see onlykey being mentioned as well.

NitroKeys is open hard- and software as far as I know?
But YubiKey‘s Hardware/firmware has never been OpenSource or audited:

https://www.yubico.com/blog/secure-hardware-vs-open-source/
The YubiKey hardware with its integral firmware has never been open sourced

Yubikey also had security issued if I remember correctly: https://www.schneier.com/blog/archives/2019/07/yubico_security.html
Good to see onlykey being mentioned as well. Don’t understand why Yubikey as closed Hardware is being privatized over onlykey.

@github-userx thats because we still have some issues with only key, mainly the points raised in #428

@blacklight447 i don’t get it, you referenced a dnscrypt issue from 2018?

@blacklight447-ptio and why no nitrokey?

@github-userx sorry that should have been issue #489 , typo on my part, sorry about that.

@5a384507-18ce-417c-bb55-d4dfcc8883fe  nitrokey is going to be added.

@blacklight447 thanks ! I gotta admit I don’t like their Defensive Tone/vibe in their response to that issue.

@github-userx thats the same reason why we are a bit weary, especially as the first comment seemed to be non hostile and just a user asking well founded questions.
It could be nothing, but then again we are watching the situation from a distance. We don't want to take chances with accidentally recommending something insecure or untrustwortht.

@blacklight447 good to know that my feeling/impression of that old issue and the tone wasn’t just me being super sensitive or something lol.

Also: Doesn‘t the FairPhone2 come with a modified Stock Android by default? Or does it really come with UbuntuTouch preloaded?

It does come with Android, but it is one of the few phones supported by the Ubuntu Touch project. The point of the Worth Mentioning section there is to recommend phones for the custom ROMs we also recommend on the OS page. You still need to flash it yourself.

NitroKeys is open hard- and software as far as I know?

We did add it to the worth mentioning section if you hadn't seen:

Nitrokey - A variety of security key products for different workloads. All Nitrokey products are open-source and customizable. The firmware and hardware have been independently assessed by Cure53 in 2015. We have found that there is no best overall product (the Pro 2 lacks Curve25519 while the lower-end Start supports it, for example) and they are lacking a variety of form factors such as USB-C and NFC that would be more convenient for many users.

It also clarifies the reason we recommended the Yubikey over it^
I did reorder the recommendations to list the SoloKey first, because if you only need U2F it is better than the YubiKey/NitroKey for cheaper and is also completely open-source :)

Actually I'm going to remove OnlyKey from being mentioned at all. I'm very concerned after reading #489 that the developers don't understand how hardware security works.
Specifically, I don't understand how they can make the claim that private keys can only ever exist on the device, while also allowing you to back up your keys from the device 🤔

It also clarifies the reason we recommended the Yubikey over it^

so in this case you actually prioritize more features over fully OpenSource? I thought ptio‘s general standpoint is to always take / choose FOSS software/hardware over closed source?
apologies if I misunderstood anything, I’m not very quick brain-wise and English isn’t my native language.

I thought ptio‘s general standpoint is to always take / choose FOSS software/hardware over closed source?

It is not. It is our general standpoint to recommend the best tools for any particular task. Being open-source is a big factor, but it is not the only factor.
The biggest thing here is that the YubiKey "does it all", so to speak. It supports U2F, FIDO2, Curve25519 PGP keys, and TOTP keys. On the Nitrokey side of things...

Only the Pro 2 supports TOTP codes, but it does not support FIDO 2 or U2F. For that you need a FIDO2 key.
Only the Pro 2 and the Start support OpenPGP, but only the Start supports Curve25519 (which we like, cc @dngray) and Koblitz curves. And strangely, only the Pro 2 and the HSM support Brainpool curves.

This means that you need a minimum of two NitroKeys for similar functionality (a Pro 2 and a FIDO2 key). Three if you are dead set on Curve25519 for your private keys (a Pro 2 for TOTP codes, a Start for your PGP key, and a FIDO2 for WebAuthn), which is a reasonable assumption actually because they have a number of benefits).
You might say you don't need TOTP or OpenPGP functionality at all, so you would only need the FIDO2 key, which is fine. But in that case, we already recommend the SoloKeys, which also support FIDO2, are fully open-source, are cheaper, and come in USB-C and NFC formats.
Also, most YubiKey applications are open source. And we do not have to be concerned about malicious closed-source updates, since the firmware is read-only.

To expand on this above: most nitrokeys (except the gnuk version) and most other "open source" keys are not entirely opensource, by far the most of them still run a minimal operating system that controlls the smart card inside the usb key which is proprietary.

@blacklight447 thats good to know, thanks! I continue to rely on you guys opinions and knowledge ;)

@JonahAragon If you can let me know what issues you have with OnlyKey I will be glad to respond to and address those concerns. I think as @github-userx mentioned it would be good to see OnlyKey added to this list. You can read about OnlyKey security on our page here - https://docs.crp.to/security.html

NitroKeys is open hard- and software as far as I know?

With the exception of the Nitrokey Start which is a rebranded version of the open-source GnuK, the Nitrokey Pro instead uses a smartcard chip as the secure element. There are no open Smartcards; although BASICcard and JavaCard allow for their own applets to be loaded onto the card, the functions of BASICcard that are implemented with power analysis and timing attacks in mind are non-free themselves and cannot be open sourced. For both JavaCard and BASICcard, the card's onboard operating system and interpreters or the JavaCard applet compilers and toolchain are non-free, even if the platform tools are.
While I fully recognize that using physical tokens represent an appreciable part of a defense in depth strategy against key compromise, because the Nitrokey Pro uses the secure element of the smartcard as the most privileged portion of the token which actually handles the cryptographic materials, and the most privileged and important parts of the smartcard such as the card operating systems and interpreters are non-free, none of the lesser privileged items on the Nitrokey Pro should count toward the Nitrokey being more meaningfully open source than the Yubikey.

I also should mention:
The Trezor Model T should be something worth looking into as not a bitcoin wallet, but an SSH Key tool, U2F tool, GPG token, and password manager. The workflow for it is very different, and in the case of using it for GPG, is in a pre-Alpha state. Unlike other tokens it has a backup and recovery system that does not require any secret cryptographic materials to be sent to or handled by the computer and can be entered directly on the touchscreen of the device itself.
Source code for the Trezor is at https://github.com/trezor .

The Trezor Model T should be something worth looking into...

Do you own one yourself? Do you happen to know whether the 24-word recovery seed backs up keys like PGP, U2F, etc., or only crypto wallets?
I did mention that in its listing:

Trezor also has password manager functionality, supports GPG and SSH key storage functionality, and can act as a U2F key, making it a great backup for your U2F key (or vice versa).

But it seems like in both Trezor and Ledger's case, additional functionality is an afterthought. Especially with Ledger, which has some weird restrictions with its apps. I have both a Trezor One and a Ledger Nano X arriving tomorrow to test. Can't test the Model T.
One of the factors for the U2F key recommendation specifically is probably convenience. Neither Trezor nor Ledger products seem to be super convenient in the same way that a Yubikey might be with USB-C functionality, keychain form factor, NFC functionality for mobile devices, etc...
The Ledger Nano X has Bluetooth and supports iOS, but cannot currently be used as a Bluetooth U2F key on iOS [1] (or, reportedly Android). Trezor has no mobile functionality as far as I can tell which would be terrible for 99% of users.

Do you own one yourself? Do you happen to know whether the 24-word recovery seed backs up keys like PGP, U2F, etc., or only crypto wallets?

Yes, I own one myself and can confirm that the recovery memnonic and password will back up and restore things besides the crypto wallet. At this moment, subkey functionality with GPG is not usable with keys generated from the Trezor, only with regular keys, and you would need to find a way to set the U2F counter correctly for restoring U2F so that adds another element to using it as a U2F token. Regenerating your GPG private keys also requires either a copy of the public keys, or knowing the exact timestamp at which they were created on. Customizing keying options such as cert digest algorithm for self signatures on your PGP public key certificate is also not available. However, the core functionality for GPG certifying, signing, and encryption works at this moment, experimentally. It is at this point in time likely to change and in the future could change in ways that are not going to be backwards compatible, but it does work and could be expanded upon in the future. Some ssh functions like rsync and scp aren't working as of yet; scp is currently working but it requires a bit of an odd way and I haven't figured out how to get it to sync directories yet.

One of the factors for the U2F key recommendation specifically is probably convenience. Neither Trezor nor Ledger products seem to be super convenient in the same way that a Yubikey might be with USB-C functionality, keychain form factor, NFC functionality for mobile devices, etc...

I agree, it's definitely not nearly as convenient. There's no NFC, it's larger and much clunkier than the other key tokens and it's not nearly as durable. The touchscreen is definitely going to be a fragile part of it, so I wouldn't ever try to do something like put it in my pocket alongside anything like a coin or a key. I'm glad to see it is still there though!

@JonahAragon I wanted to follow up here as I didn't get a response to my previous message. I need to be able to understand the threat model you are referring to in regards to "developers don't understand how hardware security works" in order to be able to respond to your concerns.

Actually I'm going to remove OnlyKey from being mentioned at all. I'm very concerned after reading #489 that the developers don't understand how hardware security works.

In terms of OnlyKey hardware security we have a similar approach to that of Trezor, SoloKeys, and NitroKey. Of course its never an apple to apples comparison with hardware and these are all great products but I do want to point our a couple of key differences.

Those devices all use STM32 MCUs with flash security. A flaw has been identified in STM32 MCUs that permits bypassing the flash security and dumping the contents of flash as shown in the kraken post here
OnlyKey is the only one out of the 4 devices not using an STM32 MCU as OnlyKey utilizes a Freescale mk20dx256vlh7 MCU.

While the attack mentioned by Kraken has only been demonstrated on the Trezor's STM32, it most likely affects the Nitrokey and Solokey to some extent as they use similar STM32 MCUs. We specifically decided not to go with STM32 in our products because of these vulnerabilities. In contrast there are no known vulnerabilities in OnlyKey's Freescale flash security.

So I am trying to understand why OnlyKey, the only one of the 4 devices listed that does not use the vulnerable STM32 architecture is not being included in the list here. Additionally, OnlyKey is the only device of the 4 that requires a PIN code, Trezor supports a passphrase but it is not required by default. Giving OnlyKey another layer of security for data at rest.

Specifically, I don't understand how they can make the claim that private keys can only ever exist on the device, while also allowing you to back up your keys from the device 🤔

I read through #489 and don't see there being any mention of claiming that private keys can only ever exist on the OnlyKey. We mentioned that private keys are stored offline, in separate hardware, but no, there are plenty of cases where your private key would exist somewhere else temporarily. I.e. You could export your private key from Protonmail and import to OnlyKey, you could export from Keybase and import to OnlyKey. We do provide specific instructions for user's that when loading keys to only do so from a trusted computer.
No technology is perfect but we do take user's privacy and security seriously, and if you find a vulnerability in OnlyKey we have a bug bounty program that will pay. The bounty is $1000 USD for things like extracting secrets from flash.

I think "Browser" should be moved within the "Software" section since there isn't more space on the nav bar when you are using Tor, or using Firefox with "privacy.resistFingerprint" activated.  And I guess that PTio cares about Tor users.
Image of how it looks.
https://upload.vaa.red/2cogLr#35ceab28cc612e7397ff3ea35a67cb92

Works for me with privacy.resistFingerprint enabled. Might just be your screen resolution, lower than most? We can maybe still switch it though.

Works for me with privacy.resistFingerprint enabled. Might just be your screen resolution, lower than most? We can maybe still switch it though.

Mmm, yeah, my monitor is quite small. Still, I think it would fit better but that's just m opinion.

I would argue that it would be better to create a seperate issue for it, as its a bit offtopic for this pull request.

Why no desktops, laptops hardware recommendations (in preview)?

@kaushalyap it's difficult to find laptops and desktops that are actually good. @privacytoolsIO/editorial I think we should probably merge this PR now to have something on the site, and add PCs at a later date. More research required for those recommendations (we might even shy away from products and recommend certain components, like "look for a Ryzen laptop" for example, idk)

I wonder if the recommendations should also have a date on when were they recommended as I imagine hardware recommendations evolve a lot more than software recommendations as the physical device won't get improved while software does?

https://github.com/joeycastillo/The-Open-Book

As a society, we need an open source device for reading. Books are among the most important documents of our culture, yet the most popular and widespread devices we have for reading — the Kobo, the Nook, the Kindle and even the iPad — are closed devices, operating as small moving parts in a set of giant closed platforms whose owners' interests are not always aligned with readers'.
The Open Book aims to be a simple device that anyone with a soldering iron can build for themselves. The Open Book should be comprehensible: the reader should be able to look at it and understand, at least in broad strokes, how it works. It should be extensible, so that a reader with different needs can write code and add accessories that make the book work for them. It should be global, supporting readers of books in all the languages of the world. Most of all, it should be open, so that anyone can take this design as a starting point and use it to build a better book.

If we come up with some criteria for desktops and laptops, I can begin talking to manufacturers about their products that meet those criteria to see if we want to list them.
We have Pine64, System 76, etc. They are only Linux systems, but you get my drift. Though I can't see us listing Macbooks (though we will iOS) or Windows systems.

https://github.com/joeycastillo/The-Open-Book

I like this, but I think we need to decide where the hardware line is. Not saying it's here, but we need to figure that out.

I like this, but I think we need to decide where the hardware line is. Not saying it's here, but we need to figure that out.

Yes, I know it doesn't quite fit with the rest of the recommendations, but it's a really good project and it's the only alternative so far to e-readers with privacy in mind. I say you shouldn't add it for now or only as worth mentioning, y'all should talk through those details.

The Google Pixel supports GrapheneOS
Shouldn't it be reversed?

https://static.solokeys.com/en/start/
Connects to facebook.com without consent of user. I don't think we should recommend websites of products that do this.

Description
https://deploy-preview-1713--privacytools-io.netlify.com/hardware/
This is a WIP draft but it's a start. TODO:

[x] Mobile device recommendations

[x] U2F key recommendations

[x] PC recommendations

[ ] https://github.com/privacytoolsIO/privacytools.io/issues/904#issuecomment-586592856?

Closes: 904 (Actually we should probably merge this PR and add laptops/desktops at a later date)
Closes: #616 (supersedes, we will try to eventually import the useful content from that PR here)
Closes: #989 (supersedes)
Closes: #420
Closes: #1714
Closes: #1731
Related: https://github.com/privacytoolsIO/privacytools.io/issues/832#issuecomment-489236848 (Pixel+Graphene info)

Just curious, what's holding up this pull request?

@bionfinc several things, though mainly the fact that none of our PRs our building right now.

Instead of tresorit, I would rather choose Disroot with Lufi
https://github.com/privacytools/privacytools.io/issues/2406


KOGITO-2076: Open File API

Task: KOGITO-2076
Related PRs:

https://github.com/kiegroup/appformer/pull/961
https://github.com/kiegroup/kogito-tooling/pull/151

Note: Wait for https://github.com/kiegroup/kogito-tooling/pull/142 get merged first.

@caponetto  Hi.. your PR can proceed.... however (not unexpectedly) there are some conflicts now the re-usable embedded editor changes have been merged (-desktop and -online now use the same core embedded editor so you will need to move some of your changes to embedded-editor but the code should look familiar, just in a different place). Also, whatever you change to embedded-editor will affect -desktop, -online and -chrome-extension so be warned!

@caponetto Is this ready for review?

@tiagobento not yet! I'm working on it.

Hi @jomarko, thanks for the review! Currently, it is just a middle step. Is is up to the editors to use the API to fit their needs.


Fail connect port 9200

Hello, I apologize for bad writing, I'm from Brazil.
I have this problem that follows in the print.
I tried several adjustments, and it doesn't work.
Your work is fantastic

Hei,
Can you please verify that your Wazuh installation is reachable from the server running this integration? This message means that Wazuh's OpenSearch server cannot be reached. More specifically, it can reach the IP address, but it appears that OpenSearch isn't running on that port (9200), or possibly not running at all.

Thank you very much, champ.
Working 100%.
Again, your work is amazing and should be shared.


Discussions: "Number of items on site home page" has no effect

I added a "New Discussions" block on my home page, but it only uses the "items per page" and not the "items on site home page" settings.

Cannot reproduce the issue. I did the following:

Activated the default "New Discussions" block on homepage.
Go to Studio->Discussions and changed 'Number of items on site home page' from 6 to 3.
Checked site's home page and it shows 3 items in "New Discussions" block.


Create  markdown to html/react parser util

Is your feature request related to a problem? Please describe.
In mapbox-gl-js and mapbox-tiling-service, we are using a function to convert markdown to markup:
import remark from 'remark';
import reactRenderer from 'remark-react';

export default function md(str) {
  return remark()
    .use(reactRenderer)
    .processSync(str).contents;
}

The latest version of remark is not compatible with IE11, which means we need to be careful about not upgrading remark in docs-site repos.
Describe the solution you'd like
We should move this utility into dr-ui where we can properly test it to avoid accidentally upgrading a dependency without understanding its effects.
Ref https://github.com/mapbox/mts-docs/pull/23

iOS and Android now use the same function, we found a solution by adding the following to batfish.config.js:
babelPlugins: [require.resolve('@babel/plugin-transform-object-assign')],
babelInclude: ['remark', 'remark-react'],

Ref https://github.com/mapbox/android-docs/pull/1579/commits/099cd35abee58189412fd5ef65663bfc0a3a6cbb

We no longer support IE 11 https://github.com/mapbox/documentation/issues/276


XML snippets throw java errors

We parse coding examples as text, so brackets are converted to HTML name encodings (< >) in the canonicalized xm. What follows are endless java errors:
ERROR: Unable to parse the following XML snippet, which is apparently not well-formed:
Parsing them as xml doesn't work, because the snippets are actually not well-formed. Any ideas?

I recognized this behaviour the first time with the changes in https://github.com/music-encoding/music-encoding/pull/1148#issuecomment-1563276012.
Beside the other changes that removed the warnings from the Verovio image generation step, it introduced these Java errors. Maybe the XML declaration added to the beginning of the files causes this?
<?xml version="1.0" encoding="UTF-8"?>

OK, when I remove the XML declaration, all the parsing errors are gone.
What's left is a warning: WARNING: Unable to retrieve definition of element rend>. No link created. Please check spelling?
Not sure though where this rend is coming from?

Preparing a PR that removes the declarations.

Found the reason for the rend> warning above. Preparing another PR.


[CS] Don't set parsed paths for dynamic member key paths

The logic here could form AST loops due to passing in anchor for the key path's parsed path.
However setting a parsed path here seems to be a holdover from the CSDiag days, so we can stop setting a parsed path and rip out and the rest of the synthesis and SanitizeExpr logic for it.
rdar://85236369

@swift-ci please test

@swift-ci please test source compatibility

@swift-ci please SourceKit stress test

Debug source compat failure is unrelated


fix: ADDON-65405 multi level menu

This PR introduces select_nested() method in dropdown component which enables user to operate multi-level menu for inputs by providing to method sequence of buttons that are going to be clicked in given a order.
sleep() function used within select_nested() function to avoid issue with broken pop-up animation.

:tada: This PR is included in version 2.5.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


⚠ Bofrost.de has degraded performance

In 7203fa5, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1251 ms

Resolved: Bofrost.de performance has improved in f906b39.


Yet another ByteBuffer related java 1.8 bug

Similar to #23 but more ByteBuffer methods.

I'm not sure if it is all of these.

I've tested it with jNeedle, there was no more error: probably this is the last issue with java 1.8


 Please ensure your spreadsheet contains the 'submission name' column"

Quota::Error was also added - I can revert that if necessary


Add Swedish localization

Adds a new Swedish localization for all strings present at the time of translating.

@marcusbillman Thank you!


Make context reload manual, and freeze context on incompatible or forced upgrade

Context reload is currently a complicated process to expose and consume. In many cases it will require a refresh of the page hosting the container. If we are not very careful this could result in data loss.
Rather than building complicated detection, interception, and cancellation logic, i propose we change the fundamental mechanism here. Rather than automatically closing and reloading the context, we should split this is two.
On an incompatible code proposal an event should be fired, and the current context should become readonly, no longer accepting any local or remote operations.
There should be a mechanism the host can call at this point to manually reload the context, or ask the user to refresh the page. Ideally, we can detect this in a way to prevent data loss, such that no pending changes are accepted that won't be able to be round tripped.
For backwards compatibility we should maintain the current behavior with the NullRuntime to a real runtime.
The detection method that the context has been frozen should also be extensible, as there are other cases, like server side file operations (delete, restore, ...) that could also result in the context needing to be frozen

it is possible we can leverage the existing behavior of closing the container rather than closing the context only.


Add GitHub actions

This has given a github actions instead of travis ci
Also a section of main.go was deleted for it being dead code

@andmarios care to review / shut it down?

Nah, closing this


fix(date-picker): adds input setter coercion

Adds input setter coercion for the date input to enable a nullable input according  to the nullable output in projects with strict template checks.
https://angular.io/guide/template-typecheck#input-setter-coercion
Signed-off-by: Tobias Wittwer<EMAIL_ADDRESS>PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
It is not possible to pass null as empty value to the date picker input in strict template mode.
What is the new behavior?
Date picker accepts Date | null as input.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
A better option would be add null in the input setter as well in the output.
- @Output('clrDateChange') dateChange: EventEmitter<Date> = new EventEmitter<Date>(false);
+ @Output('clrDateChange') dateChange: EventEmitter<Date | null> = new EventEmitter<Date | null>(false);

- set date(date: Date) {
+ set date(date: Date | null) {

If this is acceptable I would update the PR accordingly.

I'm ok with this, but I think you're right the best thing is to add it on the input setter.

@gnomeontherun I can update the setter and event emitter as well


migrated clusterloader2/testing/network/config.yaml to use namespace

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Migrates clusterloader2/testing/network/config.yaml to use namespace
Which issue(s) this PR fixes:

Part of  #1696
Special notes for your reviewer:
Ref PR #1825
Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @marseel

/ok-to-test
/lgtm
/approve


Invalide Attribute Combination

Description
When target group's target type is set to lambda, the following
│ Warning: Invalid Attribute Combination
│
│   with module.lb["devops-nebula-lambda-alb-1"].aws_lb_target_group.this["lambda-target-group-0"],
│   on .terraform/modules/lb/main.tf line 485, in resource "aws_lb_target_group" "this":
│  485:   port                               = try(each.value.target_type, null) == "lambda" ? null : try(each.value.port, var.default_port)
│
│ Attribute "port" cannot be specified when "target_type" is "lambda".

[x ] ✋ I have searched the open/closed issues and my issue is not listed.

⚠ Note
Versions

Module version [Required]: 9.7.0

Terraform version:
1.50

Provider version(s):
.
├── provider[registry.terraform.io/hashicorp/aws]
├── module.gateway_lb
│   └── provider[registry.terraform.io/hashicorp/aws]
└── module.lb
└── provider[registry.terraform.io/hashicorp/aws] >= 5.33.0

Reproduction Code [Required]
lambda-target-group-0 = {
name_prefix                        = "l1-"
target_type                        = "lambda"
lambda_multi_value_headers_enabled = true
target_id                          = module.lambda_with_allowed_triggers.lambda_function_arn
}
Steps to reproduce the behavior:

define a ALB with target group above
terraform apply

Got  the  warning in description

we have this https://github.com/terraform-aws-modules/terraform-aws-alb/blob/eb15097ece19399858ae84518bb900bd34494a74/examples/complete-alb/main.tf#L396-L401 in our example and it works as expected
closing for now since I am not able to reproduce


Small things to do before opening the project up to the public

There's quite a few small things that should be done before opening this up to the public.

[ ] Clean up dirtier code and make names more consistant and understandable.
[ ] Write a few basic covering tests for all the different areas.
[x] Clean up the unnecessary tests.
[x] Figure out how to generate and host the Haddock generated documentation.
[ ] Reorganize some of the code, files, and directory structure.
[ ] Make use of String, Text, ByteString, and/or Lazy ByteString more consistent throughout the code.
[x] Go over all the other tasks and see if there's anything else that should be done before opening this up to the public.
[ ] Consider adding an examples directory with examples of code using the library.

Of course, there are the other issues with the "opening up to the public" milestone as well.

Obviously I released this so I didn't do all of them before the public release. I decided that some of them weren't completely necessary to do before releasing the library to the public. However, a few of them should still be done I think.


Complete Loading screen does not hide Loading text and throbber

Hi, so in my game i want to have a press any key to continue (hide loading screen), so i set this up in Async Loading Screen and every thing is fine with the exception of one, then the loading is complete, the "Press any key" Text shows in the center, but the Loading text and throbber is not hideing at the bottom, and thats very strange. How can i set the loading text hide when the loading complete text shows up ? Is this a bug ? or there is a bool in config that i does not see?

Hi, I'll implement it in the next update


Migrate over to using enabledApiProposals in package.json

Closes https://github.com/microsoft/vscode-python/issues/18184

I'm merging this PR but do let me know if there's an issue!


feat: add getting started steps

Description
Add getting started steps (left on mobile, right on desktop)
ref #103

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[x] New feature
[ ] Other

@ydcjeff thanks but UI is not that friendly. Once selected a tempate we can not see the guide and even can not get back to see it without refreshing the page. Let's find another way to do it.

@vfdev-5 Then moved inside the Template Tab?


Links to deploy actions do not work

We use GH actions with a deployment pipeline. I get the notification but clicking on it does not open the URL.
It's something quite new, so I guess it is not supported yet, but I think it would be a great addition.
Let me know if you need more info, happy to help

PS: I love this tool, it saved me from GitHub fatigue ❤

@ianaya89 ooh, thanks! Sometimes GitHub does this - they add new types without documenting them. I'm not sure we can properly fix up the links, since GitHub doesn't fill in the Notification URLs for newer stuff in their REST API, but we can at least get a nice icon and fix up the type in there. I'll see what I can do!

Makes sense, that would a good solution. Thanks for your quick reply :)


Use new logger throughout code base

Currently there is a lot of code which fails without any log entry. Also at some places console.log was used for debugging. Other places use vscode.window.showXxxMessage. All existing code should be scanned and log entries should be done properly.
The new log API from #7  should be used everywhere.

[x] Replace all console.log, console.warn, ...
[ ] Check all vscode.window.showXxxMessage and replace with logger if appropriate
[ ] Check where error and warning log entries should be done
[ ] Check where info and debug log entries should be done

All existing console log were replaced. Existing functionality without log will be adjusted on change of architecture (#5)

Most places now use the new logging system, so the issue will be closed. Other missing logging / overlogging will be handled in separate issues when problems arise.


How to autowire cookieProvider dynamically (without cookie name)?

Hi,
We recently needed to add another way to login to another part of our application with an autologin link.
We add the cookie to the response in the AuthenticationSuccessHandler::onAuthenticationSuccess method:
$response->headers->setCookie($this->cookieProvider->createCookie($this->JWTManager->create($token->getUser())));

I tried many ways to dynamically autowire JWTCookieProvider but nothing worked and I still have to inject it with the cookie name. Is there a way to autowire JWTCookieProvider(s) without giving cookie name or by giving it from .env ? If not, wouldn't it be useful? :)

We'll need to create a cookie chained provider service rather than using an iterable and we can easily do that


[Storage] Fixed Blob Readme Indentiation

API change check
API changes are not detected in this pull request.

@microsoft-github-policy-service rerun

/check-enforcer override


#1345 Fixed insensitive or inconsiderate language

Ran linter and improved insensitive or inconsiderate language. Removed some unnecessary 'just's and 'simply's and tried to use more appropriate or descriptive words where possible.

I have fixed that breaking change now :)

Oh no, I'm sorry I think you removed the wrong yarn.lock 🙈

Docker Engine Version: 18.09.6
Kernel Version: Linux 0aa454aaed4d 4.15.0-1043-aws #45-Ubuntu SMP Mon Jun 24 14:07:03 UTC 2019 x86_64 Linux
Starting container circleci/node:8
  image cache not found on this host, downloading circleci/node:8

  Error pulling image circleci/node:8: Error response from daemon: received unexpected HTTP status: 503 Service Unavailable... retrying
  image cache not found on this host, downloading circleci/node:8

  Error pulling image circleci/node:8: Error response from daemon: received unexpected HTTP status: 503 Service Unavailable... retrying
  image cache not found on this host, downloading circleci/node:8

  Error pulling image circleci/node:8: Error response from daemon: received unexpected HTTP status: 503 Service Unavailable... retrying
  image cache not found on this host, downloading circleci/node:8

  Error pulling image circleci/node:8: Error response from daemon: received unexpected HTTP status: 503 Service Unavailable... retrying
  image cache not found on this host, downloading circleci/node:8

  Error pulling image circleci/node:8: Error response from daemon: received unexpected HTTP status: 503 Service Unavailable... retrying
  image cache not found on this host, downloading circleci/node:8

Error response from daemon: received unexpected HTTP status: 503 Service Unavailable```

This is the error on the latest CI run, it's some problem with building the container? I'm not sure what to do to resolve it

@hatwell if you could give me access to edit this PR I can wrap this up for you!

@rickhanlonii I am so sorry but I don't know how to grant someone else access.


[POAE7-2624] support is distinct from for nextgen

What changes were proposed in this pull request?
support IS DISTINCT FROM codegen
Why are the changes needed?
support IS DISTINCT FROM codegen
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT
Which label does this PR belong to?

@bigPYJ1151 @jikunshang @kd97 please help review this PR. Thanks.


Allow commands to take arguments and subcommands

I'm working on a simple cli app that queries GitHub's API, and I've organized it with the following interface:
./cli get repo [repo name]
./cli get org [org name]

I'd like to add the following subcommand:
./cli get org repos [org name]

As you can see, the 'org' subcommand would need to both be able to evaluate arguments [org name], and print help and usage details when the args are missing, AND it would need to know when the arg matches a subcommand and execute that instead.
This partially works today. I can get ./cli get org [org] and ./cli get org repo [org] to execute by having the latter as a subcommand, and the former placed in the Action section, but usage and help details are missing. Even the global --help flag fails to evaluate it unless I start writing my own argument parsing logic.
Hope this makes sense. Still new to Go, and still learning. Love this utility though!

I actually just found out about the cli.ShowSubcommandHelp function, and it looks like I've solved my issue. Closing this out.


duffle export unversioned image pulls in all versions in local registry

Create a bundle.json that references nginx, without a version tag:
    "images": [{
        "imageType": "docker",
        "image": "nginx"
    }],

Export this on a machine with only nginx:1.14 in the local registry.  Record the size of the output.
Now pull another version of the image to the local registry e.g. docker pull nginx:1.15.  (Do not modify bundle.json.)  Export the bundle again.  Record the size of the output.
I saw variations starting around 46MB and eventually climbing to 118MB with four nginx versions on the machine!  I originally noticed the issue because I had a nginx version other than latest locally, and it looks like duffle export pulled latest (without me explicitly pulling) and then tarred both versions up.  (Subsequent exports did not pull further versions - I had to do that manually.)
Possibly this is expected/desired but it was quite surprising to me!  From the pull behaviour I assume duffle export is intending to treat unversioned as latest but it ends up pulling in everything.  By comparison if I specified nginx:latest in the bundle, the output was about 46MB again, so it clearly hadn't included the additional versions that time.

@itowlson The way duffle export works has changed drastically since this bug was raised. I hope that bug no longer occurs. Please could you re-test.
Here's some background. When you raised the bug, duffle export used to do the equivalent of docker save to store images in multiple tar files. These days exported images are stored in an OCI image layout and I think only one image should be stored per image reference.


RealHeat 4.6 installed with KSP 1.3

Background
CKAN Version:
1.25.1
KSP Version:
<IP_ADDRESS>1
Operating System:
Windows 10 Professional 64-bit v1803
Have you made any manual changes to your GameData folder (i.e., not via CKAN)?
No
Affected mods and mod versions:
RealHeat
Problem
What steps did you take in CKAN?
Installed RealHeat
What did you expect to happen?
v4.5 to be installed
What happened instead?
v4.6 was selected to be installed, which is not compatible with 1.3.x
See https://github.com/KSP-RO/RealHeat/blob/v4.6/Source/Checkers.cs
Screenshots:

CKAN error codes (if applicable):

Thanks for letting us know. Should be fixed within a few minutes.


Update to run on rust nightly 1.15.0

llamadb is broken in the current rust nightly 1.15.0 release.
The first change is using the Cow:: smart pointer constructor instead of into_cow, since it has been depreciated. The other change is to the time::Duration module, where span was depreciated. The idiomatic way to time a function is to use Instant::now() with the corresponding elapsed() function.

It can be working on latest stable Rust release?

@stalkerg I took a look at it and I'm not sure if I want to mess around with it. Associated types are behind a feature gate and are being used in the parser for generic programming. I'd rather spend my time doing some other things (namely adding tests).
For more reference, here's the tracking issue for associated types if you're curious on how they work and want to tackle it yourself.


Support "shared runtime" mode, bundling apps as pure configuration

This is a proper issue for https://github.com/jiahaog/nativefier/issues/184#issuecomment-214967131 by @deksden. Re-phrasing them,
A nativefier app is a URL + options (and maybe some --injected resources), all specified to the CLI at
packaging time. So rather than spit the whole electron runtime in each app, we could have only one instance of the shared runtime, and use it to launch the apps, which would become thin launchers calling the shared runtime with their configuration as params.

Benefits:

Letting the OS share memory across Electron instances
Reduce disk space usage

Drawbacks:

Differs a lot from existing behavior, and goes against the desire for packaging "as statically as possible" that some some users are wishing for, e.g. https://github.com/jiahaog/nativefier/issues/342 .
→ Should be an option.
We'd have nativefier running in two very different modes (the initial "one-folder-per-app" builds, OR the new "1 common-runtime + N thin app-as-settings" mode).
→ Use cases explosion, need for more tests.
Means doing in Nativefier platform-specific work that we're currently avoiding as we're just shipping the bare output of electron-packager.

New project targeted same problem: https://github.com/pojala/electrino
Blog post: https://medium.com/dailyjs/put-your-electron-app-on-a-diet-with-electrino-c7ffdf1d6297

Are there any updates on this issue?
I currently have 6 web applications I use daily, eating up most of my memory available..

This is also the premise behind WebCatalog, would love it if Nativefier had an option to define a shared runtime though, since it's a much more powerful and stable tool

Webcatalog is now deprecated.
But you can use electron /path/to/nativefied-app/resources/app to run a nativefied app using a globally installed electron runtime. Only injected css doesn't seem to work, probably because of wrong relative paths (look for INJECT_CSS_PATH if you want to debug this).

I've made a wrapper script to do this: lean-nativefier.sh

Any reason why we couldn't create a fully "clickable" app that would launch/run the electron /path/to/resources command? This feels trivial...

So, with a little experimentation, I created an Automator based (macOS) app that will launch electron with the bundled app/ directory.
Essentially, create your Nativefier app the way you normally would, right click on the resulting .app, go into Contents/Resources/ and copy the app/ directory into the Contents/Resources/ directory in this app.
Assuming you have electron installed in either /usr/bin or /usr/local/bin, it should launch. Leaves me with an app about 4MB in size.
The only two things that don't work are for some reason the app name in the menu bar still says Electron (I poked around a lot, couldn't figure out why it wasn't honoring the Nativefier configuration json files) and the app Icon. It's a step in a direction. Not quite enough for me to switch to it, but the proof of concept is there, and if someone could help me figure out or tell me why electron isn't respecting the config files, we'd basically be there.
Attaching a screenshot of the AppleScript app (and the workflow itself) in case you don't trust some random guy on the internet giving you an unsigned app to run 😂.

Still love the concept of Nativefier, but the 250+ MB app size per app makes it pretty untenable except for the one-off app here or there... It's been almost 3 years since this issue was last interacted with. Do we have any official movement on it? Is my hackery (above) worth pursuing? I'm wondering if anyone has insights/answers for those two issues I was left with after my experimentation.

The app name in the menu bar still says Electron (I poked around a lot, couldn't figure out why it wasn't honoring the Nativefier configuration json files)
The app Icon


Configure codecov to ignore tests folder

Based on Zarr-Python, I think it should work to put the configuration inside .github rather than the repository root, but let's see...

Looks like we're not getting codecov uploads for all the commits - https://app.codecov.io/gh/zarr-developers/VirtualiZarr/commits/All branches 🚀


Issue 160 implement more mlchallenges

Implemented more MLChallenges with different estimators.

Resolve #160

Codecov Report

Merging #161 into master will decrease coverage by 2.46%.
The diff coverage is 73.52%.

@@           Coverage Diff            @@
##           master   #161      +/-   ##
========================================
- Coverage   94.46%    92%   -2.47%
========================================
  Files          36     38       +2
  Lines         795    888      +93
========================================
+ Hits          751    817      +66
- Misses         44     71      +27

Impacted Files
Coverage Δ

btb/benchmark/challenges/__init__.py
100% <100%> (ø)
:arrow_up:

btb/benchmark/challenges/challenge.py
94.54% <100%> (+0.2%)
:arrow_up:

btb/benchmark/__init__.py
100% <100%> (ø)
:arrow_up:

btb/benchmark/challenges/bohachevsky.py
65.21% <20%> (-34.79%)
:arrow_down:

btb/benchmark/challenges/rosenbrock.py
65.21% <20%> (-34.79%)
:arrow_down:

btb/benchmark/challenges/branin.py
75% <20%> (-25%)
:arrow_down:

btb/benchmark/challenges/census.py
95.45% <91.66%> (-4.55%)
:arrow_down:

btb/benchmark/challenges/wind.py
95.45% <95.45%> (ø)

btb/benchmark/challenges/boston.py
95.65% <95.65%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f58bcea...6cee7d7. Read the comment docs.


Open UV errors post 0.81b

Home Assistant release with the issue:

Last working Home Assistant release (if known):
0.80.3
Operating environment (Hass.io/Docker/Windows/etc.):
Ubuntu 18.04 in VE

Component/platform:

Description of problem:
OpenUV post 81 Beta install
2018-10-22 07:41:59 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry -31.######, 115.####### for openuv
2018-10-22 08:01:05 ERROR (MainThread) [homeassistant.components.openuv] No valid protection window data for this location
2018-10-22 08:01:05 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Error requesting data from uv: 500, message='Internal Server Error'
2018-10-22 08:01:05 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 08:02:27 ERROR (MainThread) [homeassistant.components.openuv] No valid protection window data for this location
2018-10-22 08:02:28 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Error requesting data from uv: 500, message='Internal Server Error'
2018-10-22 08:02:28 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 08:03:51 ERROR (MainThread) [homeassistant.components.openuv] No valid protection window data for this location
2018-10-22 08:03:52 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Error requesting data from uv: 500, message='Internal Server Error'
2018-10-22 08:03:52 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 08:05:14 ERROR (MainThread) [homeassistant.components.openuv] No valid protection window data for this location
2018-10-22 08:05:14 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Error requesting data from uv: 500, message='Internal Server Error'
2018-10-22 08:05:14 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:

Will need your latitude and longitude to diagnose. Feel free to reach out to me on Discord (my username is bachya#9921).

Hi Aaron,
latitude: -31.917354
longitude: 115.898573
As requested.
Regards

On 22 Oct 2018, at 9:37 pm, Aaron Bach<EMAIL_ADDRESS>wrote:
Will need your latitude and longitude to diagnose. Feel free to reach out to me on Discord (my username is bachya#9921).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/home-assistant/home-assistant/issues/17683#issuecomment-431837785, or mute the thread https://github.com/notifications/unsubscribe-auth/AdLnQpKwgDjICZGkNJd6E7u4wc69Lwpyks5uncoRgaJpZM4Xyvmf.

I used your lat/lon in the latest dev version of HASS everything sets up correctly; note that the exposure times are empty because that data isn't available for your location:

I'm not certain how often the beta is updated with new functionality from dev. I would recommend waiting for 0.81 proper to determine if this is still an issue; if so, feel free to re-open.

Thanks, there are skin exposure times readings during the day when there is a UV reading - you would have been testing during our night maybe?

On 23 Oct 2018, at 3:02 am, Aaron Bach<EMAIL_ADDRESS>wrote:
I used your lat/lon in the latest dev version of HASS everything sets up correctly; note that the exposure times are empty because that data isn't available for your location:
https://user-images.githubusercontent.com/47216/47312730-589ca000-d5fa-11e8-9adb-f709411b561d.png
I'm not certain how often the beta is updated with new functionality from dev. I would recommend waiting for 0.81 proper to determine if this is still an issue; if so, feel free to re-open.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/home-assistant/home-assistant/issues/17683#issuecomment-431938560, or mute the thread https://github.com/notifications/unsubscribe-auth/AdLnQjKIPfA_aAItbWGWbvLEZDyKw6Bmks5unhY7gaJpZM4Xyvmf.

Ah, yes. When I test now, I see all the data:

It does seem to be working, but I was getting these new errors until 8.30pm last night - it is now 10am on the 23rd and nothing in the logs. Maybe the site was down? It went from the original “500" error the what is below
Anyway, thanks for your time
2018-10-22 20:37:47 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 20:39:09 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Invalid API key
2018-10-22 20:39:09 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 20:40:31 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Invalid API key
2018-10-22 20:40:31 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 20:41:53 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Invalid API key
2018-10-22 20:41:53 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 20:43:15 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Invalid API key
2018-10-22 20:43:15 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 20:44:37 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Invalid API key
2018-10-22 20:44:37 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 20:45:59 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Invalid API key
2018-10-22 20:45:59 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 20:47:21 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Invalid API key
2018-10-22 20:47:21 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 20:48:43 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Invalid API key
2018-10-22 20:48:43 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 20:50:05 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Invalid API key
2018-10-22 20:50:05 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 20:51:33 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Invalid API key
2018-10-22 20:51:33 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-22 20:53:04 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry None, None for openuv
File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/openuv/init.py", line 154, in async_setup_entry
await openuv.async_update()
File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/openuv/init.py", line 207, in async_update
resp = await self.client.uv_protection_window()
File "/srv/homeassistant/lib/python3.6/site-packages/pyopenuv/client.py", line 75, in uv_protection_window
File "/srv/homeassistant/lib/python3.6/site-packages/pyopenuv/client.py", line 50, in request
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host api.openuv.io:443 ssl:None [Temporary failure in name resolution]

On 23 Oct 2018, at 9:45 am, Aaron Bach<EMAIL_ADDRESS>wrote:
Ah, yes. When I test now, I see all the data:
https://user-images.githubusercontent.com/47216/47329708-0166f180-d633-11e8-8259-94cef011f806.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/home-assistant/home-assistant/issues/17683#issuecomment-432055005, or mute the thread https://github.com/notifications/unsubscribe-auth/AdLnQpm9Wn5kFuNthEsdDvlnwwmaBOcGks5unnTVgaJpZM4Xyvmf.

Interesting. Very possible the API went down. Let's keep an eye on it and re-open if necessary. Thanks!

Just so you are aware that there could still be an issue - I have noticed the errors creeping back this morning.
2018-10-23 11:04:02 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry -31.917354, 115.898573 for openuv
Traceback (most recent call last):
File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/config_entries.py", line 241, in async_setup
result = await component.async_setup_entry(hass, self)
File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/openuv/init.py", line 174, in async_setup_entry
timedelta(seconds=config_entry.data[CONF_SCAN_INTERVAL]))
KeyError: 'scan_interval'
2018-10-23 11:04:02 ERROR (MainThread) [homeassistant.components.openuv] No valid protection window data for this location
2018-10-23 11:04:02 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Error requesting data from uv: 500, message='Internal Server Error'
2018-10-23 11:04:02 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 5 seconds.
2018-10-23 11:04:06 WARNING (MainThread) [homeassistant.helpers.entity] Updating state for camera.side (<class 'homeassistant.components.camera.arlo.ArloCam'>) took 3.668 seconds. Please report platform to the developers at https://goo.gl/Nvioub
2018-10-23 11:04:26 ERROR (MainThread) [homeassistant.components.openuv] No valid protection window data for this location
2018-10-23 11:04:26 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Error requesting data from uv: 500, message='Internal Server Error'
2018-10-23 11:04:26 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 10 seconds.
2018-10-23 11:04:37 ERROR (MainThread) [homeassistant.components.openuv] No valid protection window data for this location
2018-10-23 11:04:37 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Error requesting data from uv: 500, message='Internal Server Error'
2018-10-23 11:04:37 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 20 seconds.
2018-10-23 11:04:45 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.kitchen_sonos is taking over 10 seconds
2018-10-23 11:04:59 ERROR (MainThread) [homeassistant.components.openuv] No valid protection window data for this location
2018-10-23 11:04:59 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Error requesting data from uv: 500, message='Internal Server Error'
2018-10-23 11:04:59 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 40 seconds.
2018-10-23 11:05:06 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.this_device is taking over 10 seconds
2018-10-23 11:05:07 WARNING (MainThread) [homeassistant.components.media_player] Updating alexa media_player took longer than the scheduled update interval 0:00:10
2018-10-23 11:05:28 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.kitchen_sonos is taking over 10 seconds
2018-10-23 11:05:29 WARNING (MainThread) [homeassistant.components.media_player] Updating alexa media_player took longer than the scheduled update interval 0:00:10
2018-10-23 11:05:41 ERROR (MainThread) [homeassistant.components.openuv] No valid protection window data for this location
2018-10-23 11:05:41 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Error requesting data from uv: 500, message='Internal Server Error'
2018-10-23 11:05:41 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-23 11:05:50 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.study_sonos is taking over 10 seconds
2018-10-23 11:05:51 WARNING (MainThread) [homeassistant.components.media_player] Updating alexa media_player took longer than the scheduled update interval 0:00:10
2018-10-23 11:06:12 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.theatre_alexa is taking over 10 seconds
2018-10-23 11:06:13 WARNING (MainThread) [homeassistant.components.media_player] Updating alexa media_player took longer than the scheduled update interval 0:00:10
2018-10-23 11:06:25 WARNING (MainThread) [homeassistant.helpers.entity] Update of alarm_control_panel.base_station is taking over 10 seconds
2018-10-23 11:06:34 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.living_alexa is taking over 10 seconds
2018-10-23 11:06:35 WARNING (MainThread) [homeassistant.components.media_player] Updating alexa media_player took longer than the scheduled update interval 0:00:10
2018-10-23 11:06:56 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.this_device is taking over 10 seconds
2018-10-23 11:06:57 WARNING (MainThread) [homeassistant.components.media_player] Updating alexa media_player took longer than the scheduled update interval 0:00:10
2018-10-23 11:07:03 ERROR (MainThread) [homeassistant.components.openuv] No valid protection window data for this location
2018-10-23 11:07:03 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Error requesting data from uv: 500, message='Internal Server Error'
2018-10-23 11:07:03 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-23 11:07:18 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.study_alexa is taking over 10 seconds
2018-10-23 11:07:19 WARNING (MainThread) [homeassistant.components.media_player] Updating alexa media_player took longer than the scheduled update interval 0:00:10
2018-10-23 11:07:40 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.kitchen_alexa is taking over 10 seconds
2018-10-23 11:08:02 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.kitchen_alexa is taking over 10 seconds
2018-10-23 11:08:03 WARNING (MainThread) [homeassistant.components.media_player] Updating alexa media_player took longer than the scheduled update interval 0:00:10
2018-10-23 11:08:24 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.study_alexa is taking over 10 seconds
2018-10-23 11:08:25 ERROR (MainThread) [homeassistant.components.openuv] No valid protection window data for this location
2018-10-23 11:08:25 ERROR (MainThread) [homeassistant.components.openuv] Config entry failed: Error requesting data from uv: 500, message='Internal Server Error'
2018-10-23 11:08:25 WARNING (MainThread) [homeassistant.config_entries] Config entry for openuv not ready yet. Retrying in 80 seconds.
2018-10-23 11:08:45 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.theatre_alexa is taking over 10 seconds
2018-10-23 11:09:07 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.bedroom_sonos is taking over 10 seconds
2018-10-23 11:09:08 WARNING (MainThread) [homeassistant.components.media_player] Updating alexa media_player took longer than the scheduled update interval 0:00:10
2018-10-23 11:09:29 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.living_alexa is taking over 10 seconds
2018-10-23 11:09:30 WARNING (MainThread) [homeassistant.components.media_player] Updating alexa media_player took longer than the scheduled update interval 0:00:10
�������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������nds.
2018-10-23 11:09:51 WARNING (MainThread) [homeassistant.helpers.entity] Update of media_player.living_alexa is taking over 10 seconds

On 23 Oct 2018, at 10:13 am, Aaron Bach<EMAIL_ADDRESS>wrote:
Interesting. Very possible the API went down. Let's keep an eye on it and re-open if necessary. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/home-assistant/home-assistant/issues/17683#issuecomment-432060875, or mute the thread https://github.com/notifications/unsubscribe-auth/AdLnQihSA1FkUsEeZbX5zscXzRM1_wYjks5unns4gaJpZM4Xyvmf.


Missing instructions for creating your own baseline policy for End User protection

I am looking for instructions to create the exact same policy as the baseline policy, as the Baseline policy: "End user protection (preview)" can not be edited to add exclusions to this policy.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c08f708d-bd04-a587-65c5-78a5f02adebc
Version Independent ID: 7c277e69-3e43-8542-03db-2d4a23dd5442
Content: Baseline policy End user protection (preview) - Azure Active Directory
Content Source: articles/active-directory/conditional-access/howto-baseline-protect-end-users.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@MarcoJanse
Thanks for your feedback! We will investigate and update as appropriate.

See https://docs.microsoft.com/azure/active-directory/conditional-access/concept-conditional-access-policy-common

Closing this out as it is already documented. Feel free to tag us in the comments if you have further questions.


Add Makefile for Github with MFA support

what

Add Makefile for Github with MFA support

why

This is needed in one of our clients

@exequielrafaela I'll proceed to merge this as it is needed right now


Question: tomli.load doesn't work with pathlib.read_bytes?

It seems that I can do this:
with open("./config.toml", "rb") as f:
    tomli.load(f)

But not this:
f = Path("./config.toml").read_bytes()
tomli.load(f)

Error message:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
/var/folders/jc/rnc4j5c90sx162px6x2gl33h0000gp/T/ipykernel_86569/1174330575.py in <module>
      1 f = Path("./config.toml").read_bytes()
----> 2 tomli.load(f)

/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/tomli/_parser.py in load(__fp, parse_float)
     57 def load(__fp: BinaryIO, *, parse_float: ParseFloat = float) -> dict[str, Any]:
     58     """Parse TOML from a binary file object."""
---> 59     b = __fp.read()
     60     try:
     61         s = b.decode()

AttributeError: 'bytes' object has no attribute 'read'

I assume the pathlib.read_bytes method would be equivalent to  with open(path, "rb"). Any idea why the pathlib method doesn't work with tomli?
The latest recommendations from Python is to use pathlib over the with open method, so would be nice if this works. Thanks!

It seems that I can do this:
...
But not this:

Yep, load takes a binary file-like object, not bytes.

I assume the pathlib.read_bytes method would be equivalent to with open(path, "rb")

The former returns bytes and the latter a binary file-like object. They're not the same.

If you're using pathlib you can do either
with pathlib_path.open("rb") as f:
    data = tomli.load(f)

or
data = tomli.loads(pathlib_path.read_bytes().decode())


.bindSync & .unbindSync locks up socket into busy state if error occurs during operations

This makes it impossible to retry the bind operation if something goes wrong, and also prevents node from gracefully shutting down.
(e.g. address in use temporarily)
When the error is returned, the state should be switched back to READY
check:
https://github.com/JustinTulloss/zeromq.node/blob/master/binding.cc#L769

wait, what cases do we want to retry bind?

I'm sure @AlmirKadric could give an example (since he ran into this), but in any case, we need internal state to remain sane.

@AlmirKadric I'm interested to learn from an example, b/c I can't see where retrying bind makes sense..

@reqshark:

You listen on a file socket, the previous instance crashed hard and failed to cleanup, the next run will fail to bind, so you check if the file socket is in use (by attempting to connect), if you get an invalid file socket error (no one is listening anymore), you delete the file and re-attemp the bind.
You listen on a port, the configuration you use leaves sockets around for longer with time-waits to improve performance. You app crashes hard, when the application restarts you try and bind, it fails. So you create a 5 second retry timer and try again. Eventually it will succeed.

Ideally it is good practice to make error handling a choice. You never know when you need it. Having an application crash hard just to shutdown is extremely hacking and not really a good option in production / robust environments. But this is subjective and could just be my opinion.

It's also my opinion ;)

some things are meant to be hard coded. arguments to bind, IMO, is one of them
So now this all makes more sense if you pass unknowns to bind. That's a piece of logic I would strive to avoid at the outset. But nonetheless, assuming some variable makes it to bind, now from that perspective I could see why you need a statefull socket to reinitialize


Allow WHERE clause in addForeignKeyConstraint (or ForeignKeyConstraintBuilder)

I came across functionality where WHERE clause is needed to 'hardcode' value in a composite foreign key, e.g.:
.addForeignKeyConstraint(
    'service_provider', ['provider'],
    'user_role', ['user', 'role'], b => b.where(sql`role = 'provider'`)
)

Corresponding SQL:
...
FOREIGN KEY (provider, role) REFERENCES user_role (user, role)
      ON UPDATE CASCADE
      ON DELETE CASCADE
      WHERE role = 'provider'

Would something like this work?
.addForeignKeyConstraint(
    'service_provider', ['provider', 'role'],
    'user_role', ['user', 'role'],
    b => sql`
      FOREIGN KEY (provider, role) REFERENCES user_role (user, role)
      ON UPDATE CASCADE
      ON DELETE SET NULL
      WHERE role = 'provider'` as unknown as ForeignKeyConstraintBuilder
  )

Hey 👋
What database engine is it supported in? How common is this? Can't find documentation on this one anywhere.
Btw, your workaround could be safer:
sql`${db.schema
  .alterTable('service')
  .addForeignKeyConstraint('service_provider', ['provider'], 'user_role', [
    'user',
    'role',
  ])
  .onDelete('cascade')
  .onUpdate('cascade')} where ${sql.ref('role') = ${sql.literal(
    'provider',
)}`.execute(db)

I think it's safe to close this now 😄


Unable to assign cluster roles when in MCM=false mode

When mcm is disabled via --features=multi-cluster-management=false it's impossible for a cluster admin to assign cluster membership roles

They can't edit the cluster (correctly)
They can't see the Clsuter Explorer / RBAC / Cluster Members page (incorrectly)

This happens because a number of resources aren't available

Cluster Members page link

(missing) management.cattle.io.clusterroletemplatebinding (RBAC / Cluster Members)

Cluster Members page itself

Norman

(Missing) clusterRoleTemplateBinding
(Missing) principal

Steve

(Missing) management.cattle.io.clusterroletemplatebinding
management.cattle.io.user
(Missing) management.cattle.io.roletemplate

This has been caused by the change from Steve to Norman. Will transfer to backend.


Highlight module dependency issues on Module Details page

What you were trying to do
Test a new Omega zip that ended up having some funny versions. Noticed some modules in red within the Gameplay Template drop-down as well as on the Advanced Game Setup page. Would have been nice to also see that after pressing the "Module Details" button while highlighting one of the red modules in the list.
What actually happened
No highlighting at all on the Module Details page, although it outright lists enough to clearly spot an issue. See screenie below.
Find the code that results in coloring bad modules in red, then also apply it to the Module Details page in various places. See annotated screenie below.
See also #3131 for a bigger picture issue on the topic - but this one spot should be doable on its own without too much work, I hope!
How to reproduce

Mess with versions on a given module. For instance change Cities to v9.9.9 and modules like Light And Shadow should fail
See the red highlight on the Advanced Game Setup page
With Light & Shadow (or whichever affected module) highlighted click the Module Details page. No highlights!

Screenies
Now you see it

Now you don't!

To clarify: The minimum required version is 0.6.2, max supported is 0.7.0, yet actual installed version is 1.0.0, which is out of bounds, therefore the dependency resolution fails.

Hey, I would like to work on this issue.
I'm new to the codebase but on initial analysis was able to change the text color on the Modules List on the left column to red on any dependency issue.
Also, I guess the module Dependencies list was already showing red color to problematic dependencies.
However, I'm not sure how can I change the text of the Installed version text. Do I've to define a new Canvas for it and set the color as red? Please help


⚠ Bofrost.de has degraded performance

In 24ee653, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 822 ms

Resolved: Bofrost.de performance has improved in fd0dd0b after 8 minutes.


Clarifying Application Manifest identifierUris example

Hello,
The overall doc was overall really helpful.
However, the example for the app configuration "identifierUris":"https://tenant-name.onmicrosoft.com" is misleading. I lost a lot of time figuring it out. After carefully reading the description, I finally figured it out but I believe it would be cleared to adjust it to "identifierUris":"https://tenant-name.onmicrosoft.com/SAMLApp1"
Regards,
David

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7f4e153e-0fe3-2f8f-58b9-0402e3d11951
Version Independent ID: 8f7af191-8ac1-ac6c-a733-0216075373ee
Content: Configure Azure Active Directory B2C as a SAML IdP to your applications
Content Source: articles/active-directory-b2c/saml-service-provider.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

Thanks for the feedback @xrousseau! We are currently investigating and will update you shortly.

Hi @xrousseau , thank you for bringing this to our attention. I will work with the author and update the document.
Best,
James

I do not believe that the suggested correction of "identifierUris":"https://tenant-name.onmicrosoft.com/SAMLApp1" is correct. As explained in https://github.com/MicrosoftDocs/azure-docs/issues/98195#issuecomment-1261299222 I believe this example is incorrect and the identifierUris value should be set to your application's Issuer URL, which almost certainly won't be a subdomain of onmicrosoft.com.


Make spelling of "canceled" match stdlib

I have a feeling this may be contentious. However, I noticed that the concurrency section using the spelling "canceled" but the Swift standard library uses "cancelled". I'm not entirely sure which is right, but it seems like the book should match, don't you think?

This is a known incompatibility between style guides.  Apple Style Guide, which this book follows, calls for the spelling "canceled":

Use one l for the verb cancel—for example canceled, canceling. Use two l’s for the noun cancellation.

https://support.apple.com/guide/applestyleguide/c-apsgb744e4a3/1.0/web/1.0
For historical reasons dating back to NeXTSTEP (in the 1980s), APIs in Foundation use the spelling "cancelled" — and I assume the standard library is following that spelling, for consistency between APIs.

Ah ha - thank you for explaining that! It certainly did seem intentional, so I should have known.


Defining a global actor

hi @jan-molak  , I'm a newbie to serenity-js.
I have a doubt and an issue.
const actor = actorCalled('Sandeep').whoCan(
       BrowseTheWeb.using(protractor.browser),
       CallAnApi.at('http://localhost:8080'),
   );
   it(`Test-1: helps us learn Serenity/JS`, () =>
       // grant ability / permission
       actor.attemptsTo(
               // re using the task
               EnsureTheServerIsUp(),
               OpenTheApp(),
               AddAnItemCalled(`Learn Serenity/JS`),
               // assertion
               Ensure.that(RecordedItems(), equals([
                   `Learn Serenity/JS`,
                   `Love 123!`,
               ])),
           ));

Whenever I define a global actor and run a test, the report could not capture the screenshot of the failure case. (Yes I configured the screenshot capture condition in protractoconf.js). Hope you would suggest a possible solution to the issue I'm facing.

Hey @gokul10cs12!
Have a look at the example test in the serenity-js-jasmine-protractor-template project.
You'll notice that there is a beforeEach call that engages the Actors (a class that configures the Actor instances for your tests):
    beforeEach(() => engage(new Actors()));

It is important to do this before each scenario, as in web-based tests each actor that has the BrowseTheWeb ability holds a reference to the protractor.browser object. Should you choose to restart your browser between the tests, this will then turn into an invalid reference and cause you trouble.
Once you have the Actors class (as per the example), make sure to call the actorCalled function within your test rather than outside:

    // This won't work:
    // const actor = actorCalled('Sandeep').whoCan(
    //     /* ... */
    // );

    it(`Test-1: helps us learn Serenity/JS`, () =>
        // This works:
        actorCalled('Sandeep').attemptsTo(
            // re using the task
            EnsureTheServerIsUp(),
            OpenTheApp(),
            AddAnItemCalled(`Learn Serenity/JS`),
            // assertion
            Ensure.that(RecordedItems(), equals([
                `Learn Serenity/JS`,
                `Love 123!`,
            ])),
        ));

Calling actorCalled tells Serenity/JS which actor you're using (in Serenity-speak, it "puts the actor in the spotlight").
When Photographer (the service responsible for taking the screenshots) needs to take a screenshot, it checks which actor is active, and then uses their browser to take the screenshot.
Let me know if this helps!
Best,
Jan

Thank you @jan-molak . It was helpful.
Regards,
Gokul


[Firebase] Remote config for force update

inremote config we will have 2 properties to read.
android version.
ios version.
everytime user opens the app, we will compare the current version with the remote version.
if remote version is higher than current version then we will display the force app update dialog. and navigate the user to store.


Use single slash instead of double before id()

Your to-do
See issue title
Explanation
The current version works, but there's no reason to use the descendant-or-self axis when all we need is to specify a context for the statement.

Fixed by @ljo and @djbpitt


[WIP] LINK-1445 maintenance warning

Description :sparkles:
Issues :bug:
Closes :no_good_woman:
DEV-XXX:
Related :handshake:
Testing :alembic:
Automated tests :gear:
Manual testing :construction_worker_man:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #209 (c32ae87) into develop (96b47de) will increase coverage by 0.00%.
Report is 4 commits behind head on develop.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #209   +/-   ##
========================================
  Coverage    99.86%   99.86%
========================================
  Files          507      508    +1
  Lines         9468     9471    +3
  Branches      2083     2077    -6
========================================
+ Hits          9455     9458    +3
  Misses          13       13

Files Changed
Coverage Δ

...aintenanceNotification/MaintenanceNotification.tsx
100.00% <100.00%> (ø)

src/domain/app/layout/pageLayout/PageLayout.tsx
100.00% <100.00%> (ø)

src/domain/auth/utils.ts
100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update Bluetooth.md

The links under Supported Bluetooth Profiles are useless:
HID takes you to a MS Mouse!
RFCOMM takes you to Remote-Wiring repo on GitHub
GATT takes you to the Samples page, not even filtering for BT.
HID should take you to something on MS for HID  <-- Changed this link
RFCOMM ??  (I have blogged on this but that's offsite)  .. Should I author a page add it here in docs?  <-- Removed this link
GATT should go to, say. https://www.bluetooth.com/specifications/gatt/generic-attributes-overview <--Changed this link
David Jones MVP

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/connect-your-device/Bluetooth.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thank you so much for your contribution, David!

Awesome -- thanks @djaus2!  Also, thanks for pointing out the broken feedback link! We've fixed it now -- Apologies. Just changed the tool used for this feedback and had a small naming error.
Regarding RFCOMM: We would LOVE to have you contribute content about this. If you'd like to add a new page, just fork the repo, click to add a new file, and author away. (There is a yaml block at the top of each page for metadata which I'm sure you've noticed... you can copy that from another page or we can add it when you submit the pr).
Thank you again for contributing, helping us to improve, and for being an MVP. Really appreciate it.
~Matt


Nested lazy loading no longer works, bundles not being generated - beta 24

Please provide us with the following information:

OS?
Windows 10
Versions.
angular-cli: 1.0.0-beta.24
node: 7.2.1
os: win32 x64
@angular/common: 2.3.1
@angular/compiler: 2.3.1
@angular/core: 2.3.1
@angular/forms: 2.3.1
@angular/http: 2.3.1
@angular/platform-browser: 2.3.1
@angular/platform-browser-dynamic: 2.3.1
@angular/router: 3.3.1
@angular/compiler-cli: 2.3.1
(Tried angular 2.4 too)
Repro steps.
App was created with cli (beta 5). Lazy loading was working with beta.22-1. No longer works after upgrading to beta 24.
Have many nested levels of lazy loaded routes.  (I get about 10 bundles in my app compared to about 25 when its working)
Workaround - If I cut and paste the routes exactly as they are (I did change the paths to fake paths so they wont ever be matched) from the third level routing module into the second level one, the bundles are created, and the app works. The routes are then matched properly from the third level, so its strictly a bundling issue. Whatever analysis is being done to figure out what lazy loaded bundles need to be built isn't following the trail far enough. (I thought I saw an issue related to a recent change in how the cli determines what bundles need to be built a week or two ago, but couldn't find it now. That was before the problem manifested itself though, so unless it was against the unreleased version it wasn't a problem for me until now)
The log given by the failure.
I see very few bundles produced by ng serve and the when attempting to route I get:
EXCEPTION: Uncaught (in promise): Error: Cannot find module 'FULL_PATH/MY_MODULE.module'.
Error: Cannot find module 'FULL_PATH/MY_MODULE.module'.
at webpackAsyncContext (http://localhost:4200/main.bundle.js:628:25) [angular]
at SystemJsNgModuleLoader.loadAndCompile (http://localhost:4200/vendor.bundle.js:86862:40) [angular]
at SystemJsNgModuleLoader.load (http://localhost:4200/vendor.bundle.js:86850:60) [angular]
at RouterConfigLoader.loadModuleFactory (http://localhost:4200/vendor.bundle.js:25223:128) [angular]
at RouterConfigLoader.load (http://localhost:4200/vendor.bundle.js:25210:81) [angular]
at MergeMapSubscriber.project (http://localhost:4200/vendor.bundle.js:91107:111) [angular]
at MergeMapSubscriber._tryNext (http://localhost:4200/vendor.bundle.js:17084:27) [angular]
at MergeMapSubscriber._next (http://localhost:4200/vendor.bundle.js:17074:18) [angular]
at MergeMapSubscriber.Subscriber.next (http://localhost:4200/vendor.bundle.js:5016:18) [angular]
at ScalarObservable._subscribe (http://localhost:4200/vendor.bundle.js:74230:24) [angular]
at ScalarObservable.Observable.subscribe (http://localhost:4200/vendor.bundle.js:748:27) [angular]
at MergeMapOperator.call (http://localhost:4200/vendor.bundle.js:17049:23) [angular]
at Observable.subscribe (http://localhost:4200/vendor.bundle.js:745:22) [angular]
at MergeMapOperator.call (http://localhost:4200/vendor.bundle.js:17049:23) [angular]
Mention any other details that might be useful.

Thanks! We'll be in touch soon.

Can corroborate this, though I am on:
angular-cli: 1.0.0-beta.22-1
node: 6.9.2
os: win32 x64
I tried jumping up to beta 24, that didn't fix it. I tried uninstalling angular-cli globally, clearing the cache, and reinstalling, that didn't do it, and lastly I made a new project to see if building would work there. It did. I moved the created package.json from there to my project (which does have a fairly nested structure as the above comment stated) to ensure the packages I'm using are correct, and I still had the same issue

If you are using the default key word, try to remove it and append #yourModuleName

I've also been experiencing the same with<EMAIL_ADDRESS>Even putting angular2-router-loader looks like not to work any longer.

@diicar Thanks but I'm already doing it that way

I had a look at the source today and it seems the the function that crawl the lazy loaded modules does not dive into submodules. This code has been added after the @ngtools/webpack version  1.0.0. It might be a on liner to fix but I don't know the code base so this is not obvious.

I also encountered the same problem, how should be resolved?

+10086 ..  why old version can suuccess lazyload , but new version incorrect(Can't find loadChildren Module) .. new version change lazyload express ? not resolve path ??

@Meligy since you're looking at a solution, also see https://github.com/angular/angular-cli/issues/3593, particularly @jmpmscorp's comment that seems to have a temporary solution.

When will this be released? Our entire app is completely broken because of this.

A temporary fix based on the pr:
at ROW54<EMAIL_ADDRESS>replace:  lazyRoutes.forEach(function (lazyRoute) {         var route = lazyRoute.routeDef.toString();         _assertRoute(routes, lazyRoute);         routes[route] = lazyRoute;         var lazyModuleSymbol = reflector.findDeclaration(lazyRoute.absoluteFilePath, lazyRoute.routeDef.className || 'default');         var subRoutes = _extractLazyRoutesFromStaticModule(lazyModuleSymbol, reflector, host, ROUTES);         // Populate the map using the routes we just found.         subRoutes.forEach(function (subRoute) {             _assertRoute(routes, subRoute);             routes[subRoute.routeDef.toString()] = subRoute;         });     });     return routes;
with: ` const allLazyRoutes = lazyRoutes.reduce(
function includeLazyRouteAndSubRoutes(allRoutes, lazyRoute) {
const route = lazyRoute.routeDef.toString();
_assertRoute(allRoutes, lazyRoute);
allRoutes[route] = lazyRoute;
        // StaticReflector does not support discovering annotations like `NgModule` on default
        // exports
        // Which means: if a default export NgModule was lazy-loaded, we can discover it, but,
        //  we cannot parse its routes to see if they have loadChildren or not.
        if (!lazyRoute.routeDef.className) {
            return allRoutes;
        }

        const lazyModuleSymbol = reflector.findDeclaration(
            lazyRoute.absoluteFilePath, lazyRoute.routeDef.className || 'default');

        const subRoutes =
            _extractLazyRoutesFromStaticModule(lazyModuleSymbol, reflector, host, ROUTES);

        return subRoutes.reduce(includeLazyRouteAndSubRoutes, allRoutes);
    },
    {});

return allLazyRoutes;`

I have the same problem with webpack beta 24 ! And the solution of @Cronkan doesn't fix the issue !

Can this issue be listed in the breaking changes section of the change log? I'm guessing that some people won't upgrade until this is fixed in CLI or until they have time to  make their app aot ready.

@zecide I've tried "his" solution and I can confirm that it works. It's the official PR solution as well. Have you restarted your server after changing the file?

i managed to make it work without the fix, cause it doesn't work for me !
Here is what i done :
1 - make the routing code in the module ( not a file )
2 - make the module file  in the parent directory of the component
3 ) delete the 'default' in the export like this
export DEFAULT class HomeModule { }
became
export class HomeModule { }
for some reason when the module file is not in the same folder that the component it works,
i know it sounds weird but i tested it, you can see that it works with beta 24 here :
https://github.com/mauricedb/lazy-routes
i don't know what is happening !!!

@Cronkan 's solution is not working for me either. I am still getting a "Could not resolve" module error in the terminal and the dev console says that it cannot find my second-level nested module now, which was working fine previously.

I am seeing the same issue, after upgrade to cli beta 24, nested lazy loading is broken as it cannot find the module. But I can confirm that the workaround proposed by @Cronkan is working for me with no changes to my code.

A couple things:

Default imports are problematic at the moment, please avoid them until you see something about enabling them in release notes or something
Anyone able to try the generated @nagular/compiler package / folder from this PR https://github.com/angular/angular/pull/13678 ? It should fix the issue

FYI: I upgraded this project to Angular CLI 25.5 and chunking IS working with AOT and lazy loaded routes - https://github.com/rodneyjoyce/lazy-routes

The issue arise with two levels of lazy loaded component so I think your demo does not prove it works. I saw a fix in Angular 4, not sure it has been back ported.

Ah, I see - if I get time will try and replicate that scenario

i found a solution
maybe this will help someone:
when i was searching on the internet for a tutorial for lazy loading they making sure to use the word "default" on the exported module
well this actually makes you to import the module in the route like this :
{ path: 'project', loadChildren:'app/components/project/project.module' },
WITHOUT #ProjectModule at the end or the module path
when i have a nested lazy loaded modules this giving me an error can't find the submodule
to fix this error i have to load all the modules with the #Modulename at the end of the module path:
{ path: 'create', loadChildren: 'app/components/project/create-project/create-project.module#CreateProjectModule' },
and remove all the default word on the modules
this works for me with angular cli BUT when i build the project with ng build and try to run the project the error back again
please if someone know how to fix this ?


jenkins build unstable

Maven build finishes without problem, but the after/during archiving build is marked unstable, output in console of build:
[JENKINS] Archiving /var/lib/jenkins/workspace/webofneeds-integration-test/webofneeds/won-bot/pom.xml to webofneeds/won-bot/0.2-SNAPSHOT/won-bot-0.2-SNAPSHOT.pom
[JENKINS] Archiving /var/lib/jenkins/workspace/webofneeds-integration-test/webofneeds/won-bot/target/won-bot-0.2-SNAPSHOT.jar to webofneeds/won-bot/0.2-SNAPSHOT/won-bot-0.2-SNAPSHOT.jar
[JENKINS] Archiving /var/lib/jenkins/workspace/webofneeds-integration-test/webofneeds/won-bot/target/won-bot-0.2-SNAPSHOT-sources.jar to webofneeds/won-bot/0.2-SNAPSHOT/won-bot-0.2-SNAPSHOT-sources.jar
[JENKINS] Archiving /var/lib/jenkins/workspace/webofneeds-integration-test/webofneeds/won-bot/target/bots.jar to webofneeds/won-bot/0.2-SNAPSHOT/won-bot-0.2-SNAPSHOT-shaded.jar
channel stopped

Sending e-mails to: ...
Finished: UNSTABLE

problem where failed tests that didnt fail the jenkins build. add maven option "-Dmaven.test.failure.ignore=false" for every env to not ignore these kind of tests in builds


crypto/rsa: RSA-PSS PKCS1v15 should support SHA3 hashes (and others)

$ go version
go version go1.15.5 linux/amd64

Does this issue reproduce with the latest release?
Yes
What did you do?
rsa.VerifyPKCS1v15(myPublicKey, crypto.SHA3_224, hashed, signature)

What did you expect to see?
A properly verified hash. pkcs1v15HashInfo() needs to calculate the ASN1 DER prefix for algorithms that aren't in the lookup table.
What did you see instead?
crypto/rsa: unsupported hash function
Additional notes
The current code has a table of precomputed ASN1 DER prefixes for 8 algorithms. All other algorithms get crypto/rsa: unsupported hash function, even though they are valid.

/cc @FiloSottile

/cc @FiloSottile

It's a bit unclear to me why anyone would want to use legacy PKCS#1 v1.5 with SHA-3, but if there is a need I'd accept a PR to add the relevant ASN.1 prefixes.

It's a bit unclear to me why anyone would want to use legacy PKCS#1 v1.5 with SHA-3, but if there is a need I'd accept a PR to add the relevant ASN.1 prefixes.

I too wish the originator of the signatures I'm dealing with had used PSS. I'll try to find some time to submit a PR so I can ditch the current workaround I put in place.

I too wish the originator of the signatures I'm dealing with had used PSS. I'll try to find some time to submit a PR so I can ditch the current workaround I put in place.

Trying to reimplement a program, for some reason they use an SHA-3 hash in this way and it's broken for me.
@shaunco What's your workaround?

Unfortunately, it's still used, even in new hardware like ZynqMP FPGA -- RSA4096-SHA3-384 with pkcs#1v1.5 is the only scheme it supports; I suspect there's other hardware out there with similar settings. In those cases no pkcs#1v.15 with SHA3 support also means it's hard (not impossible) to use Vault transit keys for signing.

It's a bit unclear to me why anyone would want to use legacy PKCS#1 v1.5 with SHA-3, but if there is a need I'd accept a PR to add the relevant ASN.1 prefixes.

Unfortunately, it's still used, even in new hardware like ZynqMP FPGA -- RSA4096-SHA3-384 with pkcs#1v1.5 is the only scheme it supports; I suspect there's other hardware out there with similar settings. In those cases no pkcs#1v.15 with SHA3 support also means it's hard (not impossible) to use Vault transit keys for signing.


format code KVConfigManager

format code KVConfigManager
Make sure set the target branch to develop
What is the purpose of the change
format code KVConfigManager.java
Brief changelog
format code KVConfigManager.java
Verifying this change
import org.apache.rocketmq.namesrv.NamesrvController;
public class KVConfigManager {
change to
import org.apache.rocketmq.namesrv.NamesrvController;
public class KVConfigManager {
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Line 38 can be simplified to
new HashMap<>();

would you like to do that?