Issue1068

Added some functions on the logging package so that we can hand back a Handler for the log/slog standard library package.  This lets us hand in a standard library logger into the HTTP server and get much better logs out (with level handling).
This PR addresses https://github.com/gravwell/gravwell/issues/1068

I forced a panic in a handler, output is clean now:


Add PVC Provisioning Job

Description
Added Job that changes the owner of the MyDrive from root (default) to user 1010 (CrownLabsUserID), so that it is writable by tenants inside Instances deployed as containers (that run as user CrownLabsUserID). If the Job completes, it adds a label to the PVC pvc-provisioning: completed to flag it.
Fixes issue: NFS MyDrive cannot be written from containers since owner is root
~ Alessio Giliberti, Chiara Mercurio

Managed to have a look. Overall logic now seems fine. Minor changes:

switch from CreateOrUpdate to r.Update for pvc labels, since for sure you already have the pvc there.
change 'pvc-provisioning' to 'mydrive-provisioning'. Also I'd likely add a new 'pending' value that can be used to retrieve all tenants that for any reason are stuck on provisioning.
as you can see here there are issues with linting. you can go to your go settings in vscode and select golangci-lint as the linter, to get in sync with the linter we're using in the pipeline
we'll still deploy now and, if it works, we can still already test the logic

/deploy-staging


native: Add support for TAP net device

Now that we have native_posix port, we need to add a TAP net device to be able to utilize the host network for testing and simulation.

@aescolar-ot Do you have plans to work on this? If not, I could start to look into it.

Do you have plans to work on this? If not, I could start to look into it.

No plans from my side, so feel free.

Ok, taking this one.


Added RavenDB exporter to the list

This PR extends the list of exporters with one for RavenDB. RavenDB is a document database.

Thanks for pointing out the problem with metric names. I will adjust them.
The process collector also looks interesting, however in dockerized environment it wouldn't be easy to get it to work. Or am I missing something?


Angular CLI installation is stuck and never ends

Hi, I cannot get the ng command to work because of installation failure.
Versions
Output from: `node --version`: v8.9.4 (nodejs was installed with the nodejs windows msi installer)
Output from: `npm --version`: v5.6.0
OS: Windows 7

Trying to fix the problem, I reinstalled npm to my user directory instead of the default "Program files". It did not work any better, the behavior remains identical.
 Do you have more information that would point to this issue being specific to Angular CLI? There's no preinstall or postinstall steps in our package.json.
Closing this as this is an npm issue.

i had a similar problem, deleting npm and npm-cache and running cmd as administrator solved it


kvdb/bolt_compact: have log message take account space multiplier

Fixes #5937

It looks like there is an integration test failing:
=== RUN   TestLightningNetworkDaemon/tranche00/01-of-90/bitcoind/test_multi-hop_htlc/committype=SCRIPT_ENFORCED_LEASE/local_force_close_on-chain_htlc_timeout
    harness.go:354:
        	Error Trace:	harness.go:354
        	            				lnd_multi-hop_test.go:264
        	            				lnd_multi-hop_local_force_close_on_chain_htlc_timeout_test.go:29
        	            				lnd_multi-hop_test.go:111
        	Error:      	Received unexpected error:
        	            	failed to receive state client stream: rpc error: code = DeadlineExceeded desc = context deadline exceeded
        	Test:       	TestLightningNetworkDaemon/tranche00/01-of-90/bitcoind/test_multi-hop_htlc/committype=SCRIPT_ENFORCED_LEASE/local_force_close_on-chain_htlc_timeout
        	Messages:   	unable to create new node for Carol

Which seems unrelated to this change

Thanks for the PR! You may consider use [skip ci] as mentioned in the contribution guidelines,

If a PR only fixes a trivial issue, such as updating documentation on a small scale, fix typos, or any changes that do not modify the code, the commit message should end with [skip ci] to skip the CI checks.

As for the integration test, there are flakes so it's unrelated.

Thanks for pointing that out @yyforyongyu. I've added [skip ci] to the end of the commit message.

Awesome. Thank you both for the review. I don't think this necessitates editing release notes as per the guideline, since this is an extremely minor change. Which means, all is required is for an authorized user to merge.

Awesome. Thank you both for the review. I don't think this necessitates editing release notes as per the guideline, since this is an extremely minor change. Which means, all is required is for an authorized user to merge.

Indeed, that's what the skip ci is for. I've updated the checklist to hopefully make it clear, as in #5953

We're currently in the RC phase of a release, so merging is blocked. Your PR will be merged as soon as the merge window opens again.

@jyturley can you add this to the 0.14.1 release notes?

I don't see a 0.14.1 release notes file, so I created a new one. I hope that was okay.


Info

I need use items like bombs or restoring pack...Please
How long does it take?

We can't do that yet, since we don't have any bombs or other goods. If you want, you can provide an account with these items and then we can implement this. If you are interested, write to one of us @Dellenoam or @YourLov3r on Telegram.


Add Stereo Madness no copyright by ForeverBound

Song Name
Stereo Madness no copyright
Artist Name
ForeverBound
Source
Youtube
Youtube Link
-E_LvPws4To
Direct File Link
No response
Song ID
1
Start Offset [ms]
0.2
Extra
Created from Auto Nong.
Created for level: 17711004

reject
offset is in ms (no decimals allowed)


Rework proxy keep alive mechanism

Fixes #1212
Motivation
The keep alive had a few major flaws and would frequently cause the connection to drop. This also caused every PINGREQ to get many PINGRESP back if the proxy was forwarding the ping to many brokers.
Modifications
Now the keep alive is managed between the client and the proxy, and the proxy and the brokers separately using a scheduled task. This reduces the PINGRESP to 1 regardless of how many brokers are being forwarded to.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

@Technoboy- I'm fine adding tests to this. There is no real contribution guidelines, or explanations on how testing is currently setup. I understand this change has a large impact than previous changes, but I would like to point out your current tests do not catch this very apparent bug. I'm getting a PINGREQ per subscription, and the current method of keep alive forwarding does not work, nor does it comply with any version of the MQTT spec. Refer to section <IP_ADDRESS> of the MQTT v3.1.1 specification,

In the absence of sending any other Control Packets, the Client MUST send a PINGREQ Packet.

This is exactly how MQTT clients work.  Current MoP on cluster pulsar does not work as intended, and the current test suite does not catch this issue. So what exactly do you expect here? Regressions tests? Just making sure current integration tests remain passing?
I'm fine adapting these tests, but frankly the amount I've been contributing it would be nice if the ask wasn't a single sentence met by months of no response. I need some guidelines. Your test suite is not documented, has very few comments. I had previously asked about what the expectations where around tests in another PR, it went 8 months without a response. It was merged without explanation. I think you guys need to communicate better with the community, and perhaps among yourselves. Please note, this is a draft PR. This is not complete, nor proposed for merge yet.

I'm abandoning this effort. This patch has improved connection stability, and keep alive semantics between the client and the proxy. Previously I'd get a PINGRESP for every topic the client interacted with, this does not do that. I'm unsure how the MoP proxy has ever worked outside of maybe the most basic use cases.
Other issues I've noticed. AdapterChannel attempts reconnect, this reconnect NEVER sends an MQTT connect message. This means the reconnect fails, this failure causes a stack overflow because of unbound recursive retry. Even if you send a MQTT connection message this makes session state mismatch between brokers, because if you have cleanSession set to true, you end up with a cleanSession after reconnect with that broker but not other brokers. Really the only logical thing to do here is fail the entire proxy connection if any of the adapterChannels fail. You could try to build a more robust session state manager which you can somehow coordinate between brokers.
So far connections fail and seem to have trouble reconnecting with or without this change. With this change the connections seem to last several hours, but without the change and a keep alive of 3 seconds and constant stream of publishes, the client would fail in a matter of seconds. The current keep alive mechanism does not work, nor does it meet spec.
I honestly do not know how MoP proxy has ever worked in recent iterations. I'm fairly certain this isn't a matter of configuration after spending nearly a month troubleshooting several issues related to the proxy. The proxy is inherently complicated, and doesn't really seem to pose any tangible benefits. We are deciding to roll out own solution at this point as we believe the architecture of MoP is too complicated, redundant, and does not comply with MQTT spec.


update New-CsOnlineSchedule article to replace legacy OAA with AA

New-CsOnlineSchedule creates scheduled that can be used for:

CsOrganizationalAutoAttendant
CsAutoAttendant

CsAutoAttendant replaced legacy CsOrganizationalAutoAttendant
Suggested changes to the article:

in the "DESCRIPTION" and "RELATED LINKS" section replace all references to legacy CsOrganizationalAutoAttendant with new CsAutoAttendant

Example 5 - first two lines should be deleted, as they are not relevant to line 3 in the code.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 93094674-2964-b558-4543-ac3f60ee1e8f
Version Independent ID: 5b46aa89-0965-e0d2-6e73-e831651e0271
Content: New-CsOnlineSchedule (SkypeForBusiness)
Content Source: skype/skype-ps/skype/New-CsOnlineSchedule.md
Service: skypeforbusiness-powershell
GitHub Login: @tomkau
Microsoft Alias: tomkau

Thanks for reporting @shivtorov


Extend key collision clustering results

Is your feature request related to a problem? Please describe.
I would like to be able to run the kNN cluster algorithm (when it is implemented) on the collision keys that are generated for column values instead of the column values themselves. this would allow to have pre-processing step that normalizes values before the kNN clusters are being generated.
Describe the solution you'd like
The openclean.clisyer.key.KeyCollision clusterer should return a list of clusters that are sub-classes of the openclean.cluster.base.Cluster. The sub-class should extend the cluster with a reference to the cluster key.
Describe alternatives you've considered
An alternative would be to pass a pre-processing function the the kNN clusterer. This, however, appears to make the implementation more difficult since the algorithm would have to maintain a mapping of pre-processed values to original values, i.e., run key collision clustering and be able to maintain the collision keys (exactly what is proposed above).

Closed by PR #101

Closed by PR #101

Closed by PR #101


C# verbatim-string-literal has some issues.

(Original issue 733 created by albertjan on 2012-01-31T08:28:37.537277+00:00)
In verbatim-strings in c# you can only escape the " char with "" these strings for example should all render correctly:
{{{
#!c#
var verbatimString = @"c:\test"; //here the last \ should not escape the ".
var anotherVerbatimString = @"this is a test with
some new lines
in it.";
var andAVerbatimStringWithSomeEscapes = @"this shouldn't be escaped \ \n \r \t. But this should:
""He said ""she says""""";
}}}
I've tried changing the verbatimstring rule in the CSharpLexer:
{{{
#!python
from:
(r'@"(\\|\"|[^"])"', String),
to:
(r'@"(""|[^"])"', String),
}}}
When I test the regex it appears to work but pygments still renders the first example incorrectly. Escaping the last ".
Could someone point me in the right direction?
I forgot to do a clean between builds and now I've found out it does work. I will clean things up a bit and do a new pull request.
See pull request: the pull request has disappeared from the list so here's a link https://bitbucket.org/birkenfeld/pygments-main/pull-request/48

(Original issue 733 last updated on 2012-02-04T07:46:57.572086+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by birkenfeld on 2012-02-04T07:46:57.562281+00:00)
Pulled.


How to get existing rules to extend then using at-function?

[EDIT: I know about https://www.npmjs.com/package/markdown-it-attrs – but since I'm aiming for even more customization than explained here and learning to extend markdown-it in general, I'd like to add the mentioned functionality myself]
Bit of background:
I wanna enable my colleagues to add ScrollTriggers to call specific functions when the user has scrolled there. I'd like to extend existing rules rules for that. What I need is all block rules accepting an optional (kebab-case) string parameter, that then gets added as a data--attribute to the html (or ideally initializes the scrolltrigger directly, but I guess that's not possible, because I need a DOM element for that and markdown-it only produces strings, right?)
When I do md.block.ruler.at('heading', function()... I need a the original render (?) function.
All the examples I found in the issues so far include md.renderer.rules.<rule-to-overwrite>, but neither heading nor paragraph nor any other block rules are present there.
Only other way I can think of getting the function is by filtering through md.block.ruler.__rules__ array, which doesn't seem right.
So, here are my specific questions

How would you suggest to enhance all block rules with that functionality?
What syntax would you suggest to add optional string parameter to block rules (mainly headings/paragraphs)?

Thanks a lot :)

Only other way I can think of getting the function is by filtering through md.block.ruler.rules

If you need existing functions, there probably isn't a better option. Accessing existing functions for the purpose of overriding is such a rare case, so there just isn't any API for it.

(or ideally initializes the scrolltrigger directly, but I guess that's not possible, because I need a DOM element for that and markdown-it only produces strings, right?)

Browser will see these strings as DOM elements. You can write initialization code inside <script> right after that element's closing tag, and I think that would probably maybe work.

How would you suggest to enhance all block rules with that functionality?
What syntax would you suggest to add optional string parameter to block rules (mainly headings/paragraphs)?

There is a more foolproof solution for this:
https://github.com/markdown-it/markdown-it-container
You can make a syntax like:
~~~~~ Any ScrollTriggers Arguments Here
## heading
~~~~~

So you don't override heading itself, but instead nest it inside another markdown token. Then merge such tokens in one in a separate rule_core rule as post-processing.


Carla PythonAPI building macOS Mojave

Hello!
I am attempting to build ONLY the PythonAPI for Carla and Python 3.7 on macOS. I do not wish to run the actual Carla simulation on macOS. I have a windows PC that I can run the simulation on but, I want the Python library installed on my Mac. I have pulled the repository and have attempted to run make PythonAPI but, I get an error: clang 8 is required, but it's not installed. I believe that I need to install clang 8 via sudo port install clang-8.0 but I do not want to mess up Xcode as I also code apps on my machine. Any help would be appreciated.
I have been able to install @analog-garage fork for macOS but, it uses PythonClient vs PythonAPI. When I try to connect, Carla crashes with Fatal error! and from what I can tell, this is due to the depreciated PythonClient

Hi @bwees,
You could try to remove the following to avoid the check, and try to compile again?
https://github.com/carla-simulator/carla/blob/67684c5b0d56df1fe9fc54f59b650975afe6b759/Util/BuildTools/Setup.sh#L7-L10

Ok. Will this compile everything or just the PythonAPI?

So it no longer complains about clang 8 (Thank you!) but, it is now complaining about installing boost.
Building Boost.Build engine with toolset clang...  Failed to build Boost.Build build engine Consult 'bootstrap.log' for more details make: *** [setup] Error 1
I cannot find bootstrap.log in /var/logs or any of the boost directories (ran recursive grep).

So that fixed the clang issue! Thank you! Now it is complaining about the rpclib and having too many errors. Here is a part of the log:
/Applications/Xcode.app/Contents/Developer/usr/bin/g++  -DASIO_STANDALONE -DRPCLIB_ASIO=clmdep_asio -DRPCLIB_FMT=clmdep_fmt -DRPCLIB_MAC -DRPCLIB_MSGPACK=clmdep_msgpack -I/Users/kristiwees/Downloads/carla/Build/rpclib-v2.2.1_c2-c8-source/include -isystem /Users/kristiwees/Downloads/carla/Build/rpclib-v2.2.1_c2-c8-source/dependencies/include -fPIC -std=c++14 -stdlib=libc++ -I/Users/kristiwees/Downloads/carla/Build/llvm-8.0-install/include/c++/v1 -Wl,-L/Users/kristiwees/Downloads/carla/Build/llvm-8.0-install/lib -DBOOST_NO_EXCEPTIONS -DASIO_NO_EXCEPTIONS -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -mmacosx-version-min=10.14   -Wall -pedantic -Weverything -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-padded -Wno-missing-prototypes -Wno-undef -pthread -std=gnu++11 -MD -MT CMakeFiles/rpc.dir/lib/rpc/this_session.cc.o -MF CMakeFiles/rpc.dir/lib/rpc/this_session.cc.o.d -o CMakeFiles/rpc.dir/lib/rpc/this_session.cc.o -c /Users/kristiwees/Downloads/carla/Build/rpclib-v2.2.1_c2-c8-source/lib/rpc/this_session.cc
clang: warning: -Wl,-L/Users/kristiwees/Downloads/carla/Build/llvm-8.0-install/lib: 'linker' input unused [-Wunused-command-line-argument]
In file included from /Users/kristiwees/Downloads/carla/Build/rpclib-v2.2.1_c2-c8-source/lib/rpc/this_session.cc:1:
In file included from /Users/kristiwees/Downloads/carla/Build/rpclib-v2.2.1_c2-c8-source/include/rpc/this_session.h:6:
/Users/kristiwees/Downloads/carla/Build/llvm-8.0-install/include/c++/v1/atomic:12:9: warning: macro name is a reserved identifier [-Wreserved-id-macro]
#define _LIBCPP_ATOMIC
        ^
In file included from /Users/kristiwees/Downloads/carla/Build/rpclib-v2.2.1_c2-c8-source/lib/rpc/this_session.cc:1:
In file included from /Users/kristiwees/Downloads/carla/Build/rpclib-v2.2.1_c2-c8-source/include/rpc/this_session.h:6:
In file included from /Users/kristiwees/Downloads/carla/Build/llvm-8.0-install/include/c++/v1/atomic:543:
/Users/kristiwees/Downloads/carla/Build/llvm-8.0-install/include/c++/v1/__config:12:9: warning: macro name is a reserved identifier [-Wreserved-id-macro]
#define _LIBCPP_CONFIG
        ^
In file included from /Users/kristiwees/Downloads/carla/Build/rpclib-v2.2.1_c2-c8-source/lib/rpc/this_session.cc:1:
In file included from /Users/kristiwees/Downloads/carla/Build/rpclib-v2.2.1_c2-c8-source/include/rpc/this_session.h:6:
In file included from /Users/kristiwees/Downloads/carla/Build/llvm-8.0-install/include/c++/v1/atomic:544:
/Users/kristiwees/Downloads/carla/Build/llvm-8.0-install/include/c++/v1/cstddef:12:9: warning: macro name is a reserved identifier [-Wreserved-id-macro]
#define _LIBCPP_CSTDDEF
        ^
In file included from /Users/kristiwees/Downloads/carla/Build/rpclib-v2.2.1_c2-c8-source/lib/rpc/this_session.cc:1:
In file included from /Users/kristiwees/Downloads/carla/Build/rpclib-v2.2.1_c2-c8-source/include/rpc/this_session.h:6:
In file included from /Users/kristiwees/Downloads/carla/Build/llvm-8.0-install/include/c++/v1/atomic:544:
In file included from /Users/kristiwees/Downloads/carla/Build/llvm-8.0-install/include/c++/v1/cstddef:38:
/Users/kristiwees/Downloads/carla/Build/llvm-8.0-install/include/c++/v1/version:12:9: warning: macro name is a reserved identifier [-Wreserved-id-macro]
#define _LIBCPP_VERSIONH
        ^
In file included from /Users/kristiwees/Downloads/carla/Build/rpclib-v2.2.1_c2-c8-source/lib/rpc/this_session.cc:1:
In file included from /Users/kristiwees/Downloads/carla/Build/rpclib-v2.2.1_c2-c8-source/include/rpc

Not sure if this is the issue but, I commented out sed  -i s/"3.9.0"/"3.5.0"/g ${RPCLIB_BASENAME}-source/CMakeLists.txt due to the error of -i not able to be used with stdin.

You need llvm-8 anyway. You could use a virtual machine or a Docker to compile it without compromising your already configured machine. Are you sure you cannot use version 8 with the current one that you have?
I'm not a macOS user and I cannot test it, sorry about that.

Related to #2797?

It is exactly like #2797. Will try to install llvm-8 and set the env variables to the correct paths later today.

So I installed clang-8 and llvm-8 and have set those for the compilers in Setup.sh I still get the errors in #2797

@geohot do you have any advice?

Setup.sh line 204 adding "-Wno-reserved-id-macro" option supresses the warnings shown.
The following error messages seem to be related to C++13 added functions in stdlib, which indicates that the generation of Build/llvm-install... grabs older stdlib.h on MAC without those

Related to #2797?

definitely the same, see my comment there.

I guess just installing clang-8.0 may be a simpler fix


Kakashi Hatake

Hello Law Millenium,
This is not an issue, but I wanted to ask if there was a working version with a Kakashi icon included? I been enjoying this awesome plugin, but wanted Kakashi included.
Thank you!

Hello Hanzo,
I didn't have a lot of time recently to work on this plugin but I'm about to have some time to do so !
And, about Kakashi, he's already in a feature branch that i'll release soon !! 😄
Hope you'll enjoy this plugin even more this way (you'll see a surprise 😉), don't hesitate to ask again if you want specific content (it can be done quickly if you have pixel-art gifs already made or sprites corresponding to what you'd like).
See u !

Ah I see, no worries. Thank you for the response, very much appreciated. Glad to hear it and looking forward to it!

Hey!
I released a new version and it's been approved by Jetbrains, you can update it in order to find Kakashi and Kakashi with Anbu outfit!
Hope you'll enjoy this!


[AutoPR apimanagement/resource-manager] Add revision and Version Description to Contract

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3430

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/2242


Inconsistent log directory names in docs/docker-compose

Describe the bug
The example docker-compose* file use "logs" as directory for log files, while the example production_template.yaml file uses "log".
Change so that "log" is used everywhere.

Fix in https://github.com/ptarmiganlabs/butler-sos/releases/tag/v6.0.1


NNBD: Analyzer throws error for Set<double> x2 = {1 + 1}; where dart passes here

Dart SDK version: 2.10.0-27.0.dev (dev) (Thu Aug 13 23:48:41 2020 -0700) on "windows_x64"
The following source code example passes with Dart without errors whereas analyzer throws a compile time error for Set<double> x2 = {1 + 1}; and passes with  Set<double> x1 = {1}; if null safety is turned on:
main() {
  Set<double> x1 = {1};
  Set<double> x2 = {1 + 1};
}

Both analyzer and dart throws a compile error with nnbd turned off here.
I am not quite sure which behavior is correct, but anyway all the tools should work in the same manner.
Sample output is:

$> dart test.dart
test.dart:3:23: Error: A value of type 'int' can't be assigned to a variable of type 'double'.
Set x2 = {1 + 1};
^
$> dartanalyzer test.dart
Analyzing test.dart...
error - The element type 'int' can't be assigned to the set type 'double'. - test.dart:3:21 - set_element_type_not_assignable
hint - The value of the local variable 'x1' isn't used. - test.dart:2:15 - unused_local_variable
hint - The value of the local variable 'x2' isn't used. - test.dart:3:15 - unused_local_variable
1 error and 2 hints found.
$> dart --enable-experiment=non-nullable test.dart
$> dartanalyzer --enable-experiment=non-nullable test.dart
Analyzing test.dart...
error - The element type 'int' can't be assigned to the set type 'double'. - test.dart:3:21 - set_element_type_not_assignable
hint - The value of the local variable 'x1' isn't used. - test.dart:2:15 - unused_local_variable
hint - The value of the local variable 'x2' isn't used. - test.dart:3:15 - unused_local_variable
1 error and 2 hints found.
$>

Dart promotes integer literals to double literals in a double context. That''s what double x = 1; works, and also why Set<double> s = {1}; works.
However, there is traditionally no double context for the integers in double x = 1 + 1;. The former 1 is a receiver for the + method, the object it's being called on, and it has no context type at all. The latter 1 is an argument to the num operator+(num) operator of int, so its context type is num. The result is still an int because of the special rules for integer arithmetic.
With null safety, we are currently in the process of changing those rules to be more clever (desing doc). That's necessary because null safe Dart does not have implicit downcasts, so ending up with a num result in cases where we could derive that the result is double  is introducing new annoying errors.
One of these changes is that doing 1 + x in a double context will figure out that the only way int + something is going to be a double is if the something is a double, so it will give x a context type of double. Then double x = 1 + 1; will convert the latter 1 to a double literal, and the result becomes a double.
What you are seeing is likely that the front-end has made this change, but the analyzer hasn't made it yet. It will be implemented on both engines before null-safety is released.

Fixed in 9af30dbb06d164c926e465137e179c057059b259


Quality Control

The front end of the website, mainly the text, needs to be evaluated for correctness and consistency. All resources should read and feel the same to the user.
Some things to look at first:
Breadcrumb uniformity
Titles
Resource independent front end text (The static portions of resource headers, etc.)

I'm closing it because we do it all the time and create issues for single tasks.


fix(cli) Duplicated trait set as modeline and kamel run parameters causes error

Fix #2466
Release Note
NONE

@oscerd or @nicolaferraro can you review and merge ?

retest

@claudio4j have you checled if it affect traits having multiple values.
E.g. if I want to set knative.sink-channels to chan1 and chan2, can I run -t knative.sink-channels=chan1 -t knative.sink-channels=chan2 ? Does it only apply to modeline vs command line params?

The precedence applies only to trait/property keys from modeline and cli and in the case you mentioned, the values are correctly applied as []string, example
kamel run -o yaml files/JavaDuplicateParams.java -t knative.enabled=true -t knative.channel-sinks=chan1 -t knative.channel-sinks=chan2

The output
  traits:
    knative:
      configuration:
        channelSinks:
        - chan1
        - chan2
        enabled: true

There are test errors related to this PR

@nicolaferraro I fixed the e2e tests, can you review ? Thanks.

@nicolaferraro can you check if it's ok to merge this one  ?


OTEL enrichment agent do not set labels or host metadata during scaling event

We observed that whenever OTEL pod scales up we start seeing few logs with incomplete metadata (labels, host).
Expected

Actual
As we can see there are no labels & host present in Kuberenetes block

During scaling phase as OTEL pod doesn't have metadata from k8s API in its cache it sends logs without setting few metadata fields.
This behaviour is valid for short-lived pods but not appropriate for running pods.
Is this Kubernetes problem or this can be fixed in OTEL?

Since this only happens for new otel Pods, I have a suspicion that it's because the k8sprocessor processed data without first having populated its Pod cache completely. As I suggested on Slack, can you try adding a delay to the otel container (for example via initialDelaySeconds in the readiness probe) and see if that helps?
If this is the case, we can consider explicitly waiting for caches to sync while starting the processor.

I tried updating initialDelaySeconds from default 5sec to 20 sec but it didn't help to alleviate the issue.