Fix return Promises so each step runs in sequence

Return the Promise of each executeCommand() call to PromiseSeries, so that commands are executed in sequence, not in parallel.

+1

please merge this. this extension is pretty much broken without this.

@Spongman Indeed

also, the 'custom delay' patch is unnecessary with this patch.

Is this extension abandoned? This fix is pretty core, why no merge?

This worked well for me and is easy to understand.  Simply add return  to the beginning of lines 34 and 38.
Current:
https://github.com/geddski/macros/blob/96b0d7b2930c26eea22f2a9acbebba823bc98c5b/extension.js#L34
https://github.com/geddski/macros/blob/96b0d7b2930c26eea22f2a9acbebba823bc98c5b/extension.js#L38
Fixed:
https://github.com/geddski/macros/blob/de2633df8bb5ab0042fe0f0ebe15e40da1fe16fa/extension.js#L34
https://github.com/geddski/macros/blob/de2633df8bb5ab0042fe0f0ebe15e40da1fe16fa/extension.js#L38

Since it's been three years with no merge I found this fork that fixes this: https://github.com/ctf0/macros

@geddski how is it about this Pull Request? Can we may work on this this weekend and merge and release a version 1.1?

This worked well for me and is easy to understand. Simply add return to the beginning of lines 34 and 38.
Current:
https://github.com/geddski/macros/blob/96b0d7b2930c26eea22f2a9acbebba823bc98c5b/extension.js#L34
https://github.com/geddski/macros/blob/96b0d7b2930c26eea22f2a9acbebba823bc98c5b/extension.js#L38
Fixed:
https://github.com/geddski/macros/blob/de2633df8bb5ab0042fe0f0ebe15e40da1fe16fa/extension.js#L34
https://github.com/geddski/macros/blob/de2633df8bb5ab0042fe0f0ebe15e40da1fe16fa/extension.js#L38

I also am affected by the issue. See https://stackoverflow.com/questions/72153504/prevent-asynchronous-order-of-command-sequence-execution-in-vs-codium
I added these two return in the ~/.vscode/extensions/geddski.macros-1.2.1/extension.js, but it did not work for me. It still always execute commands in parallel. Any advise?

Since it's been three years with no merge I found this fork that fixes this: https://github.com/ctf0/macros

@jpotterm How to install that? It seems it has not been published in marketplace?


Click on Select All check box.

The previously selected row stays highlighted.
A bit related:

Select a row.
Click outside the grid to loose focus.
Click on a different row.

The previously selected row makes an un-selection animation, this should originally happen after clicking outside so the animation is too late.

Root cause:
In Vaadin Grid, by default v-grid-row-focused class is added to the first tr. It seems that in the current design, one exact tr must have this class.
This conflicts with the current CSS:
:focus .v-grid-row-focused {
...
}

Since the class v-grid-row-focused is always present, extra unneeded animation happens.
Proposed solutions:

Update our CSS rules and probably not use :focus.
If it's a bug against Vaadin Grid design, remove the class v-grid-row-focused when it's not needed.

Note v-grid-row-focused is completely different than v-grid-row-selected.

I’ve noticed this also, but haven’t considered it a priority yet. If possible, I would definitely opt for removing the v-grid-row-focused classname from all the rows when the grid if blurred/unfocused.
If we do that, we can also stop using :focus at the same time.

Working on a fix now for the main Vaadin Grid code. This should fix many issues in components.

https://dev.vaadin.com/ticket/18521

Thanks to @Artur-, this issue is progressing 👍

Probably not worth fixing any more. Closing as “won’t fix”.


Applicant - Definition of Tagline

Description
Users are unsure of what a Tagline is under My Profile. Include a definition and sample tagline. Replace the heading Other Information with Tagline.
Note: The text has to be reviewed.
Images

@laurenoncoffee can you please review the text Jasmita has proposed in the image above?

I think it's hard to judge right now if there's any value in having this field, as most users weren't filling it out since they didn't understand what it meant. I believe it would be good to add an explanation like in the image above, and then see if more users fill it out. If users still don't complete this field, then we should remove it. It might also be worthwhile to check if this is something managers like reading.

@JasmitaChawla @gobyrne
Can we get EN/FR copy for this? Or please close the issue.


Support meetingRegistrantGet operation

https://developers.zoom.us/docs/api/rest/reference/zoom-api/methods/#operation/meetingRegistrantGet

Thanks for the contribution! I'll get this merged and a new version published here soon!

Thank you!


Added some clarification to the readme

Both #2 and #6 mention the could not open specified HEX file error. This might be because some people go to the directory containing the hex file on GitHub and do a save as... on the link instead of going to the raw file.
Hopefully this will prevent some people from getting this error in the future 😉

Thanks!


x86 version of this tool

Hello Fidel, Thank you very much for making this tool available!
Any chance of x86 version?

Thanks IL2, my pleasure :)
Absolutely, I'll compile an x86 version today. I haven't tried it in 32-bit mode so not sure how well it would work, but hopefully .NET does the right things for it to run smoothly. You'll be the guinea pig :)

Actually the program is compiled as 'Any CPU', which supports both x86 and x64.
But that doesn't apply to the tools I've bundled (gztool and 7-Zip) which are both x64 only.
Could you please attach a screenshot of what you are seeing?
I'll make sure to bundle x86 version of the two tools in the next release (today).
Thank you,
Fidel

Hi IL2,
Just published a new version, and this time included an x86 version. Please let me know how it goes.
Cheers,
Fidel

Hi IL2,
Just published a new version, and this time included an x86 version. Please let me know how it goes.
Cheers,
Fidel

Hello Fidel, v1.5 now starts on x86 w/o issues.
[00:46:11 INF] clonezilla-util v1.5
clonezilla-util 1.0.0
Copyright (C) 2022 clonezilla-util
I'll try to mount the image and report back.
Thanks!

Hello Fidel, finally could find some time to check v1.5.
In brief I fiound it working for cases in bold.
extract-partition-image and mount operations were checked against different clonezilla modes (beginner, expert: partclone, ntfsclone, dd, partimage) with and w/o compression with two different cloenzilla versions (2015 and 2019).
Results are in the table below and reports attached:
clonezilla-util.v1.5.win-x86.zip
image mode	clonezilla	operation	result
beginner gzip	2015	extract	GzDecompressor requires a partition cache. Not yet implemented.
beginner gzip	2019	extract	OK
beginner gzip	2015	mount	GzDecompressor requires a partition cache. Not yet implemented.
beginner gzip	2019	mount	GzDecompressor requires a partition cache. Not yet implemented.
dd gzip	2015	extract	GzDecompressor requires a partition cache. Not yet implemented.
dd uncomp	2015	mount	OK
dd uncomp	2019	mount	OK
ntfsclone gzip	2015	extract	GzDecompressor requires a partition cache. Not yet implemented.
ntfsclone uncomp	2015	mount	Cannot open the file as archive
ntfsclone uncomp	2019	mount	Cannot open the file as archive
partclone lzip	2015	extract	Cannot open the file as archive
partclone lzip	2015	mount	Cannot open the file as archive
partclone uncomp	2015	mount	Cannot open the file as archive
partclone uncomp	2019	mount	OK
partimage gzip	2015	extract	GzDecompressor requires a partition cache. Not yet implemented.
partimage uncomp	2015	mount	Cannot open the file as archive
partimage uncomp	2019	mount	Cannot open the file as archive

Oh wow! Thanks so much for taking the time to do this. I'll work through the list.
Thanks again

Hi, it was revelating that mounting has worked out with the simplest clonezilla 2015 dd image!
I was going through these cases o undestand what modes can be used in conjunction with your tool.
Observations:

result of extract/mount depends on the type of input argument - clonezilla folder or image file
runs with folder as argument failed in all cases except extracting clonezilla 2019 beginner image in 2019\OK_extract_beginner_folder.txt
mount was OK with uncompressed dd 2015/2019 and partclone 2019 clonezilla images, extracted clonezilla 2019 beginner image!
mount in other cases failed either with GzDecompressor, or 7-zip "Cannot open as arrchive", or "Could not determine compression used by partition", or "Error while opening partition" errors. I didn't put in the table above results with folder as input argument except positive extracing clonezilla 2019 beginner image
there is no x86 version of ext\gztool in v1.5 and v1.5.3

I guess results might have been improved in v1.5.3 due to https://github.com/fiddyschmitt/clonezilla-util/commit/e47529b0643941010b98e2c14a05949f02670083
Reports are named as <result>_.txt
2019\err_extract_beginner_img.txt
2019\OK_extract_beginner_folder.txt

So good! Thank you!


How about Paypal?

It's a wonderful package @taylorotwell Can you add Paypal or Authorize.net in this package please?

@taylorotwell I know that Strip is excellent, but I live and work in Argentina and here is obsolete, as it is in many other countries, because it doesn't work with many of our national banks and local payments solutions. Are you planing to add the posibility of using other gateways instead of Strip like Paypal?

I'm with @PabloRozin here, I'm also from Argentina and the business for which I work was using Stripe a few months ago. Stripe sent us an email telling us that because we have less than half of our customers living in the USA they had to close our account.
The thing is, regrettably, that Stripe has a long way to go before it can be used for any businesses that has more customers outside the USA than inside the USA.
Braintree (and PayPal for that matter) do not have this limitation and work all over the globe. I think it would be great to allow cashier to use a driver model in which we can hook different providers.
I understand that this is no easy undertaking and it might be outside the scope of the package, and that's okey... Just my two cents.

+1. Stripe is an awesome service of course. However its availability around the World is quite limited, to say the least. If @taylorotwell sees any interest in folks not residing in the few countries supported by Stripe, he should most definitely consider adding other payment processors, such as Paypal, 2checkout, Skrill etc. The way it is now, over 90% of potential Cashier users remain out of the game, which is sad.

21 Countries out of 205? Are you serious??
Furthermore, only 9 countries are production ready by now, 8 in beta and 4 in private beta.
Really, a payment platform which accept payments only by the 10% (5% production ready) of the world is just a bit more than a college summer project.
@taylorotwell I really don't think Stripe is suitable for any global business in the world.
Maybe you've agreed to a partnership with stripe or you like stripe more than any other platform, no one will blame you for that, but please don't deny the evidence. Otherwise, why not implementing the new paypal RESTful API? What about the framework agnosticity? Can you really ignore the fact Paypal is the most widespread payment service in the world?

@lucabartoli that isn't constructive at all from your side, is it? Please bear in mind that Github's issues are not meant to be used as a discussion forum. You should not use it to express your opinions and emotions, but rather to share useful information.
After all, both Cashier and Laravel are open source libraries, and if you are that much affected by lack of PayPal integration, there's literally nothing stopping you to build a PayPal integration library on your own and share it for the benefit of us all.

@tomicakorac everyone in this issue expressed his opinion, referring the fact Taylor doesn't consider this as issue at all. Mainly, I followed the flow, expressing my opinion about the coverage of stripe.
We are here because we all think Cashier is an amazing component, but stripe is useless for 196 countries out of 205 worldwide (at the moment).
Can I write my own implementation? sure I can. is it the point? no.
You're free to answer, but you're right, this is not a forum, so i will not comment anymore about that. Feel free to read between the lines and catch the real meaning of my comment.
Nothing personal against you or Taylor, believe me.

If someone wants to write a 100% cashier syntax compatible PR to support PayPal then go for it and send it over.
On Thu, Oct 1, 2015 at 7:02 AM, lucabartoli<EMAIL_ADDRESS>wrote:

@tomicakorac everyone in this issue expressed his opinion, referring the fact Taylor doesn't consider this as issue at all. Mainly, I followed the flow, expressing my opinion about the coverage of stripe.
We are here because we all think Cashier is an amazing component, but stripe is useless for 196 countries out of 205 worldwide (at the moment).
Can I write my own implementation? sure I can. is it the point? no.
You're free to answer, but you're right, this is not a forum, so i will not comment anymore about that. Feel free to read between the lines and catch the real meaning of my comment.
Nothing personal against you or Taylor, believe me.
Reply to this email directly or view it on GitHub:
https://github.com/laravel/cashier/issues/7#issuecomment-144706940

Can I write my own implementation? sure I can. is it the point? no.

Actually, that's exactly the whole point of Open Source development.

The easiest way to integrate paypal in cashier is to pre-pay stripe credit using paypal express checkout.
User pays with paypal fixed amount (prepays his subscription) and this amount is added to the stripe customer (as account balance credit).

@onlymega I'm afraid you've missed the point. Vast majority of the World's population are not allowed to have a Stripe account at all, as Stripe only operates in a very small number of countries. The problem is not paying from the buyer's side, it's funds withdrawal from the seller's side.

I have two projects running on Stripe cashier library and many users simply cannot pay because their cards are declined (5-10% of transactions are failed even if user has payed firs time with the same card without any problems). It would be nice to add the prepay option using Paypal express checkout to solve such issues.

There is about a 0.01% chance that Cashier will ever support Paypal. The
whole process of processing subscription payments on a recurring basis is a
giant leaky abstraction because each payment provider is going to be
slightly different. There isn't some PSR for subscription processing. We
can never use a library like OmniPay because it doesn't do subscription
billing, it does one-time billing, meaning you would need to write all of
your own actual recurring billing logic, refunds, cron jobs, proration,
coupons, etc.
The best chance to have something like Cashier for Paypal is just fork
Cashier or even start from scratch and write a package for subscription
billing specifically for Paypal. It will never be jammed into Cashier.
On Wed, Dec 2, 2015 at 1:37 PM, onlymega<EMAIL_ADDRESS>wrote:

I have two projects running on Stripe cashier library and many users
simply cannot pay because their cards are declined (5-10% of transactions
are failed even if user has payed firs time with the same card without any
problems). It would be nice to add the prepay option using Paypal express
checkout to solve such issues.
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/cashier/issues/7#issuecomment-161409650.

@taylorotwell - Hi I understand that you don't wish to integrate PayPal into Cashier. But Stripe is not as spread as PayPal.

The whole process of processing subscription payments on a recurring basis is a giant leaky abstraction because each payment provider is going to be slightly different
I agree with that too. Can we have separate package for PayPal, or that would be too much overkill.

I stand to be corrected but what @taylorotwell is pointing out here is pretty simple, he likes to work with stripes, which is pretty opinionated but acceptable considering that Laravel and Cashier are open source. However, as the end consumers of these awesome products, we would appreciate a little guidance on how to 'hack' into cashier and bring in Paypal  or any other gateway for that purpose.

We will have to consider starting a paypal-cashier project. Taylor is going to stand his ground on this no matter what we say.

Let's look at the problem from a different angle and find a positive point. Developers have to code a little bit more in countries that are not supported by many services, which gives them experience and makes them stronger. There is not the third option, you either swim or sink.

So, if you're trying to startup a business outside the US, and you want to use Laravel, you have to frickin' wait until Stripe decides to enter your country.

So, if you're trying to startup a business outside the US, and you want to use Laravel, you have to frickin' wait until Stripe decides to enter your country.

"Entrepreneurs are simply those who understand that there is little difference between obstacle and opportunity and are able to turn both to their advantage."  - Victor Kiam

(Now almost 2018 - more than 3.5 years since this issue was closed)
I checked Paypal's PHP SDK and it seems to now support almost the same flow as Stripe and Braintree's recurring payments now (if I'm not mistaken):
https://paypal.github.io/PayPal-PHP-SDK/sample/#billing

Create a plan (https://paypal.github.io/PayPal-PHP-SDK/sample/doc/billing/CreatePlan.html)
Use that plan for the recurring billing (https://paypal.github.io/PayPal-PHP-SDK/sample/doc/billing/CreateBillingAgreementWithPayPal.html)

Does anyone think integrating Paypal is becoming more of a possibility now with the current state of their API? I've worked with both Stripe API and Paypal API and I'm seeing the usage of both are very similar now.
Just wondering if the door is opening for Paypal to be included to this wonderful package.

Most of us do. However as this issue is closed and Taylor clearly has no interest in reconsidering the decision, this remains highly unlikely to happen.

So, if you're trying to startup a business outside the US, and you want to use Laravel, you have to frickin' wait until Stripe decides to enter your country.

Or you could you know... use your programmers to solve the business problems? Many people use PayPal with Laravel and other frameworks. It doesn't need official support to work.

Most of us do. However as this issue is closed and Taylor clearly has no interest in reconsidering the decision, this remains highly unlikely to happen.

If there was a PR or someone showed how apparently similar they are now I'm sure he might consider it again (consider, not do it). That said, if it is so similar it wouldn't be hard to fork and adapt?

So I checked the source code of this repo and found that this package seems only for Stripe. I checked back at the docs and found that the Braintree implementation is an entirely different package. So it seems for anyone who'd like to contribute to make Laravel Cashier Paypal a reality (developers in 150+ countries will thank you profusely!), they'd have to create something like a cashier-paypal implementation that adheres to how Taylor does it in these two packages.
If anyone has the skill (that I don't have) to take this on, this might be a good starting point on creating subscription billing with Paypal's newer REST API (as of 2017): https://devdojo.com/blog/tutorials/using-paypal-in-your-laravel-app
I understand that anyone can make their own implementation but the way Taylor does it is just beautiful. I'm sure people from non-developed-countries would absolutely appreciate also being able to do
if ($user->onTrial())

or
$user->subscribed('main')->cancel();

and all of those goodness just by doing something like
composer require laravel/cashier-paypal

like you guys in developed-countries are able to do with laravel/cashier and laravel/cashier-braintree :D
It might also make good business sense for the Laravel team to make this possible. I'm sure Laravel usage would get a big boost because devs from 150+ countries can now also integrate billing to their apps easier (let's face it, what percentage of Laravel apps don't need billing nowadays?). More Laravel usage = more users of Laravel's paid products like Forge, Spark, Envoyer, etc. (The friction experienced by developers from 150+ countries to be able to do something as fundamental as subscription billing when using Laravel might be a lost opportunity!)

Why is it called Cashier if it is hard set to only support one gateway? Shouldn't it just be laravel-stripe?

Because cashier sounds way cooler.

that's really shitty though... example Spark is built to support Cashier structure. So if Cashier was a library structure as opposed to just a strict one-off tool, then people could write Cashier compatable libraries to work with the gateways they use. Instead this is just some random library for a specific company, not a functionality expansion. So every implementation of any gateway has to be rewired on both sides to be usable.

and the refusale to make that ability possible isn't much motivation for people to try to help the framework that is literally telling them it doesn't care what they need. So the solutions are all going to stay internal

Nah cashier does sound way cooler and if someone made drivers for other providers well enough they would be merged.
I'd rather the framework be the focus instead of gateways which change lots, have lots of differences and already have many libraries.
You know you can also write your own code right? You don't need everyone to do it for you.

@robclancy from looking at the code, it currently has no abiltiy to support other providers. That's why the "cashier-braintree" is a totally unrelated project as opposed to an extension.
as far as...

You know you can also write your own code right? You don't need everyone to do it for you.

you realzie the point of these public projects is so that the 4 years of people complaining about the same exact problem can be solved instead of everyone solving it themselves internally. Especially when this is tool is meant to be a selling point for a not-free package. Telling people they have to switch providers in order to use a product is not a great path.

Look at the 3rd comment. Anything after that is pointless bitching like what you are doing now. All providers have libraries you can use. This one works with stripe.

well then I guess laravel shouldn't exist at all. cuz people can write their own code.  So that people will use switch to their platform and make them money. Cuz "why make things dynamic and extendable" is the absolute opposite of an engineering goal. And you already showed you don't know the codebase with your comment that another provider would be added, but already a new one is in another project by the same people. Because Cashier has no technical dynamics in it.

I don't need to know the codebase because I can do this thing called programming. And I could change it to support whatever I wanted.

Laravel Cashier does support Braintree... I'm confused ¯_(ツ)_/¯

You call this small thread with like 5 people community complaints? Holy moly what a small community.

@mikerogne no, another separate library called "cashier-braintree" supports braintree. They have no actual technical relation

@robclancy if your only input is "don't support things" then you serve no purpose in communal software

https://laravel.com/docs/5.5/billing#introduction

Laravel Cashier provides an expressive, fluent interface to Stripe's and Braintree's subscription billing services. It handles almost all of the boilerplate subscription billing code you are dreading writing. In addition to basic subscription management, Cashier can handle coupons, swapping subscription, subscription "quantities", cancellation grace periods, and even generate invoice PDFs.

What does it matter if it's "separate" -- it's still a part of Laravel Cashier according to the official documentation. Why are we raising such a stink about this again?

then the docs are lying. that's super great for a technical tool. Either way the point was to have PayPal ( and really should be able to support anything via extension ), nothing to do with Braintree

Braintree is a Paypal company, and does support Paypal.

When you argue with a mad man in the streets, you start looking like one. Let common sense prevail.

pretty sure I've said the specific reason for cashier to be an extendable base 4 times in response to you, let alone my original post and every post from people before me. You have no reason to be writing on here. Do you understand what "extendable" means? You're basically just trolling to say code should not be improved and everyone should solve their own internal features in their own way.
Cashier does the exact job it set out to do and quite well. At no point does it attempt to or say it is for all providers. That's just something in you made up in your little self entitled head.

just to be clear. you're only goal is to make it so that cashier stays unable to be extended upon. Correct?

I tend to agree with @robclancy here honestly. It sounds like you're expecting Cashier to do "too much" -- even though it already does support what you want (Paypal ... Braintree is a Paypal company). If you're curious about fees, just look at Braintree docs.
Unsubscribing from this thread. Good luck to ya.

Spark only works with Casher. So if I want to use.. AuthorizeNet or FirstDate or whatever... because of the short sighted structure of Cashier, it means rewriting Spark myself to support other gateways.

Neither Stripe or Braintree are supported here in my country. 👎

Damn each time I'm looking for a laravel functionnality I found a 13 years old or locked threads...
What a community... 😕
I'm also sad to see how fast the idea was rejected.
I will find a proper alternative, thanks for the package though. 👍

@Adrion this is what I read
"Damn each time I want someone to do something for me I find it isn't done for me! Why doesn't Laravel create the entire website for me??!!

Oh the conspiracy theorist is back :D

Darn, time is flying! I feel like I started this conversation few weeks ago!

We won't be reconsidering PayPal in this library sorry. There's now cashier-mollie library which you might want to look into. It has PayPal support.

We won't be reconsidering PayPal in this library sorry. There's now cashier-mollie library which you might want to look into. It has PayPal support.

@driesvints: Last time we checked you are not @taylorotwell so just stop answering questions not directed to you and hogging all the questions. Thank you!

@taylorotwell I was wondering if you would reconsider you choice not to support PayPal. The initial decision looks like it was made a few years ago and I would find it very useful. I am about to embark on using a different system because of it but I would be happy to put my efforts into extending Cashier instead.

 Try to learn how to read and understand statements it will alienate stupidity and introduce enlightenment.

This issue really does seem to attract morons.

@robclancy Yes Captain Moron.


Is this a bug or I did something wrong? (new to Python)

Actual Behavior

Other Information
OS: win7 32bit
PokemonGo-Bot dev
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)

Are you on dev? It looks like there's a known issue right now. #1291
Delete the catch_above_cp lines from the config.json and you should be good.

yes sir, I'm on dev.
is this the right way to delete it
"use_lucky_egg": false,
"evolve_captured": false,
"catch": {
  "any": {"catch_above_cp": 0, "catch_above_iv": 0, "logic": "or" },

  "// Pokemons with example": { "always_catch": true },
  "// Gets filtered with release parameters": {},

to
"use_lucky_egg": false,
"evolve_captured": false,
"catch": {
  "any": { },

  "// Pokemons with example": { "always_catch": true },
  "// Gets filtered with release parameters": {},

I deleted line 61 and 132 completely and I'm catching magikarp fine. Before I deleted them, I had issues. Eevee also has the same issue.
	Line 60:       "// Magikarp evolves to Gyarados": {},
	Line 61:       "Magikarp": { "catch_above_cp": 91, "catch_above_iv": 0.9, "logic": "and" },
	Line 131:       "// Magikarp evolves to Gyarados": {},
	Line 132:       "Magikarp": { "release_below_cp": 91, "release_below_iv": 0.8, "logic": "and" },
	Line 177:       "Magikarp": { "release_below_cp": 91, "release_below_iv": 0.8, "logic": "and" },

Will try your fix sir ayiire.

I think that did the trick. It doesn't happen anymore, 6 Magikarps caught and transferred already. Thank you.
But what about the 2nd picture sir?
It only happened 1 time, and 1 hour of using it after, it still doesn't produce the same error.

pip install -r requirements.txt

doesn't work


fix: Error when a type variable is unbound during monomorphization instead of defaulting to Field

Description
Problem*
Resolves
Summary*
Adds an error when encountering an unbound TypeVariableKind::Normal instead of defaulting it to a Field.
Additional Context
Documentation*
Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

HirLValue's now all have both a Location and a Type
LValueRhs's now all have a Span

@jfecher Would it make sense to factor out the common fields into a struct, e.g.
struct HirLValue {
  location: Location,
  typ: Type,
  kind: HirLValueKind,
}

?


Add prefix-textual-length pre and postprocessor

Pull request
Description
add support for the RFC 5425 transport protocol (textual length prefix)
Checklist

[x] The RFC, if required, has been submitted and approved
[ ] Any user-facing impact of the changes is reflected in docs.tremor.rs
[x] The code is tested
[x] Use of unsafe code is reasoned about in a comment
[x] Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
[ ] The performance impact of the change is measured (see below)

Coverage increased (+0.05%) to 83.516% when pulling 03c252faa3c185ab1d4386c3484578ecaf44e34c on murex971:textual-preprocessor into 1507b6dafabd8ba5b4c61fc05c9c9c34b2c7a683 on tremor-rs:main.

This is a great contribution :+1: really nice set of tests too! Great job :D


build using @grafana/toolkit

kinda complicated.
This has raw js library files:
https://github.com/NatelEnergy/grafana-plotly-panel/tree/master/src/lib
and loads them manually using:
https://github.com/NatelEnergy/grafana-plotly-panel/blob/master/src/libLoader.ts

@dprokop -- can you take a look at this?
The build works yarn dev, but yarn test is not able to load some things?
Also... any ideas on importing the static libs?


Bug Crunch January '24

[ ] Switch styling (keeps rmwc default theme unless @rmwc/theme/styles is imported)
[ ] Switch onClick/onChange
[x] Switch evt.currentTarget.checked does not work
[ ] Switch stays focused after interaction
[ ] Select (enhanced) gets unwanted padding from wrapping anchor
[ ] Select (native) can't be fullwidth (maybe due to new rmwc-default-width class added)
[ ] Button still has ripple even though ripple is disabled in RMWCProvider
[ ] RMWC incompatible with react-hook-form

I'll jump on React Hook Form


Fixing typo from PR #1569, adding throw keyword.

From PR #1569: https://github.com/dotnet/corefxlab/pull/1569/files
cc @KrzysztofCwalina

Thank!


WriterBase should allow writing to multiple locations in the string

Currently, parameter declarations for the factory method formatter look like this:
Lambda(
    new [] {
        var s = Parameter(typeof(string), "s")
    },
    s
)

Ideally all the variable declarations should be either before the Lambda method call:
var s = Parameter(typeof(string), "s");

Lambda(
    ...

or perhaps after; not intermingled with the lambda call.
In order to do this, and still maintain the span for each expression tree node, we would have to either

allow moving the insertion point to somewhere else in the string builder, and then continually modify the spans from these other texts as more text is inserted at the original point, OR
allow creating another string builder, and then modifying the resulting span to be offset from the final results of the original string builder

The only reasonable way to approach this is with 2.
We'd want to allow many string builders, not just two.
We'd need a Dictionary<string, StringBuilder>, perhaps with the empty string as the key for the main string builder.
How do we specify which string builder to write to? The safer way would be to pass the string builder name as an optional parameter to each writing method, Alternatively, we could have the concept of the active string builder; setting/unsetting some property could change the active string builder.
Let's try the safe way; there's not yet a public API for formatters.

Conclusion:

Dictionary<string, (StringBuilder, pathSpans)>
WriteX methods take an optional string, for the stringbuilder name
Once WriteNode has been called from the constructor, all string builder contents need to be merged into a single string builder. The order of the string builders is defined in the derived class. Each successive string builder will need its pathspans adjusted.
ToString returns results from the final, merged, stringbuilder


Service Request by David Lounsbury for Donrie - Review and update units labels for consistency

[ ] Problem NOT RESOLVED
[ ] Problem PARTIALLY RESOLVED
[ ] Problem FULLY RESOLVED and Issue is Closed

Use comments feature (below) to document:

A clear and concise description of the solution.

A clear and concise description of any alternative solutions or features you've considered.

Any additional context, such as screenshots about the problem.

@donriepurcell
Please go into Tracker Options and scroll through all PRIMARY, SECONDARY, STRUCTURAL, and OTHER MEASURES labels to make sure that all MEASURES have units labels and that the units labels are consistent. Note: use 'Persons' not 'Individuals.' Use 'Kits' not 'Units' etc., etc.
THANKS

Hi Profe'
I reviewed all 4 Measures in Options Categories and I changed only two option values.

Secondary Measures: Safer Prescribing and Dispensing= 1.0 Number of opioid overdose deaths (from individuals to Deaths)
Secondary Measures: Expand MOUD Availablilty = 2.7.1 # of individuals receiving buprenorphine/Naloxone retained beyond 6 months (from individuals to persons in agreement with all the rest)

Hi Profe'
There is one item that caught my attention with the unit of measurement as settings. I did not get it and will defer to your advise on it.

Hi Donrie:
Settings makes sense for a STRUCTURAL measure. But I wonder if we should use the term 'Venues'?
Maybe a Setting is with a 'Venue', in this case.
Let me know if I am making sense.
Thanks!

Hi Profe:
I quite agree that Venue may be more appropriate as a unit of measurement.

Hi Donrie:
I want to meet with to work through these 'units' issues.
One think to check, first off, is that the Tracker will not let regular (non-Admin) users create 'Other' measures on their own. We want users to ask us to create them, so that we can set up the units, properly, for all users.
Best and thanks,
David

Hi Jeff,
Please can you assist us with a feature in the Measures Download that will allow us to see the units of measurements currently associated with each measure. In other words,  # of individuals initiated onto interim methadone will have a unit of measurement be persons.
Jeff, we really need to see these in the download because it will allow us to know where there are missing units of measurements especially in the case of other measures  and consequently allow us to stay on top of data

Hi Jeff, Please can you assist us with a feature in the Measures Download that will allow us to see the units of measurements currently associated with each measure. In other words, # of individuals initiated onto interim methadone will have a unit of measurement be persons. Jeff, we really need to see these in the download because it will allow us to know where there are missing units of measurements especially in the case of other measures and consequently allow us to stay on top of data

@jbazinet1111 To add to Donrie's request, what we need in analogous to what you created for generating a download of all users, users' affiliation, and Admin vs county access.
The download table should include  EBP Category, Primary, Sec, Structure, Other, Measure name, and units.
How many professional hours to do this?
DL

Might I suggest that we have a download button on the list options page? It would download all the option data, including the measures and their units. If that works for you, I would estimate a 4 hour ordeal with deployment by Tuesday morning.

Did you want to proceed? I'm afraid the window is closing soon for a Tuesday delivery, but if its not needed right away, then that probably doesn't matter. Let me know.

Did you want to proceed? I'm afraid the window is closing soon for a Tuesday delivery, but if its not needed right away, then that probably doesn't matter. Let me know.

Dear @jbazinet1111
Yes, this is great. Please proceed. Sorry about my delayed reply! Friday was so busy for me.
Best,
David

This has been deployed a day earlier than expected. There is a download list options button available to you.

Jeff: Excellent and thank you!


Adjust wording on upgrade guide

Followup to #21434

@bot-gradle test and merge

OK, I've already triggered a build for you.


ComputerVision SDK not support Cognitive Service that hosted on Mooncake

@ryogok, @TFR258, @tburns10 Could you please look into this issue ?

Hi @micli, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.


s6-overlay-suexec

On add-on start, nothing happens, this shows on log:
s6-overlay-suexec: fatal: can only run as pid 1
RBPi4
Home Assistant 2022.10.2
Supervisor 2022.10.0
Operating System 9.0
Frontend: 20221006.0 - latest

What add-on are you talking about?

Whatsapp add-on
Em seg., 10 de out. de 2022 às 13:39, w35l3y @.***>
escreveu:

What add-on are you talking about?
—
Reply to this email directly, view it on GitHub
https://github.com/w35l3y/hassio-addons/issues/20#issuecomment-1273571279,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQSDR2Y3VBANMSTXCTPJYR3WCRBC5ANCNFSM6AAAAAARBMQDEU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Duplicate of #19

I suggest you mark this add-on as not maintained any more, so no one
opens issues for it.
Em seg., 10 de out. de 2022 às 14:42, w35l3y @.***>
escreveu:

Closed #20 https://github.com/w35l3y/hassio-addons/issues/20 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/w35l3y/hassio-addons/issues/20#event-7556060956, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQSDR25X7654RX7JOLFY7RTWCRIRVANCNFSM6AAAAAARBMQDEU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Ensure scratch directory exists when calling extractCache

When running the action for the first time and no cache exists, inject does not get called, so scratch dir is not created. Then extracting the cache fails because it tries to write to scratch/buildstamp but the scratch folder does not exist.
Workaround is to chance the scrath folder to some other folder that already exists:
  - name: inject cache into docker
    uses: reproducible-containers/buildkit-cache-dance@v3
    with:
      ...
      scratch-dir: folder_that_exists_in_the_repo

This PR ensures the directory exists even if the inject job is not called. Should fix #23

Thanks, but CI is failing

yeah i forgot to build, so i did, then i was missing the signed off so i added it following the instructions (which added a new commit). But the the pipeline was mad because the last commit didn't contain the build.
I reverted and now everything should be contained in a single commit.

Not sure why its failing now

Please try this
https://github.com/reproducible-containers/buildkit-cache-dance/blob/5de31fc1534ed8789e63d41ea933c5df9944a261/.github/workflows/unit-tests.yml#L17-L26

I did try that but it was not updating anything in the dist folder.
I added --no-cache and it seem to have worked.


Release preparation for 0.7.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.57%. Comparing base (771d1c2) to head (edb8ba5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   90.57%   90.57%
=======================================
  Files          34       34
  Lines        1909     1909
=======================================
  Hits         1729     1729
  Misses        180      180

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Please add back the sync filling of cmsRun1-stdout.log and cmsRun1-stdout.err !

Dear all, I am trying to debug a new system (Leonardo HPC) and I have a very hard time, since (I understood it is a feature!) the files cmsRun1-stdout.log and cmsRun1-stdout.err on the WN are no more filled in sync withe the job execution.
Hence, it is a nightmare to debug.
Is there a way to re-establigh the old behavior?

Hi @tommasoboccali , isn't that actually populated by CMSSW itself?
We had a few changes in the relevant WMCore module
https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WMSpec/Steps/Executors/CMSSW.py
but I don't think any of those would have affected the functionality of these logs.


Dashboard for All Projects in Organisation

It would be nice to implement a dashboard where you can see all exceptions being captured on all projects in your organisation.

My Mouth is watering :) Will it have a migration path from Exceptionless 1.0 for self-hosted installations?

Yes, You'll have to set up new services like elasticsearch and run the migration script.


How to ensure that the Go version specified in go.mod is picked?

What happened?

What were you attempting to do?
Trying to build a Go project that specifies go 1.17 as the version in go.mod.
Command: bin/pack build <my image name> --builder=paketobuildpacks/builder:tiny

What did you expect to happen?
The pack runs the build with Go 1.17 as that's the language version specified in the go.mod file. Note that it's not just that I expected this to happen, it's what I actually want, I don't want a different build version to be used. i.e., I don't want to hardcode a version, I want the version in go.mod to be used.

What was the actual behavior? Please provide log output, if possible.
 An excerpt from the logs:

===> DETECTING
5 of 9 buildpacks participating
paketo-buildpacks/ca-certificates 3.2.1
paketo-buildpacks/go-dist         1.1.3
paketo-buildpacks/git             0.4.2
paketo-buildpacks/go-mod-vendor   0.6.0
paketo-buildpacks/go-build        1.1.2
===> ANALYZING
Previous image with name "<my image name>" not found
===> RESTORING
===> BUILDING

Paketo CA Certificates Buildpack 3.2.1
  https://github.com/paketo-buildpacks/ca-certificates
  Launch Helper: Contributing to layer
    Creating /layers/paketo-buildpacks_ca-certificates/helper/exec.d/ca-certificates-helper
Paketo Go Distribution Buildpack 1.1.3
  Resolving Go version
    Candidate version sources (in priority order):
      go.mod    -> ">= 1.17"
      <unknown> -> ""

    Selected Go version (using go.mod): 1.18.1

  Executing build process
    Installing Go 1.18.1
      Completed in 1m55.095s

Build Configuration

What platform (pack, kpack, tekton buildpacks plugin, etc.) are you
using? Please include a version.

$ pack version
pack 0.21.1+git-e09e397.build-2823

What buildpacks are you using? Please include versions.

paketo-buildpacks/ca-certificates 3.2.1
paketo-buildpacks/go-dist         1.1.3
paketo-buildpacks/git             0.4.2
paketo-buildpacks/go-mod-vendor   0.6.0
paketo-buildpacks/go-build        1.1.2

What builder are you using? If custom, can you provide the output from pack inspect-builder <builder>?
paketobuildpacks/builder:tiny

$ pack inspect-builder paketobuildpacks/builder:tiny
Inspecting image: paketobuildpacks/builder:tiny

REMOTE:

Stack: io.paketo.stacks.tiny

Base Image:
  Top Layer:

Run Images:
  (none)

Buildpacks:
  (buildpack metadata not present)

LOCAL:

Stack: io.paketo.stacks.tiny

Base Image:
  Top Layer:

Run Images:
  (none)

Buildpacks:
  (buildpack metadata not present)

Can you provide a sample app or relevant configuration (buildpack.yml,
nginx.conf, etc.)? Not at this time.

Checklist

[ x ] I have included log output.
[ ] The log output includes an error message.
[ ] I have included steps for reproduction.

Hi @matteoolivi – I'm curious about how this version selection is impacting your build. Is something going wrong with your build or your running app? Some undesired/unexpected behaviour?
For a bit of background context on why the buildpack behaves this way today, the buildpack interprets the version of go in the go.mod file as the minimum go version requirement. This is aligned with Golang's documentation of the meaning of the go directive in a go.mod file.
But this decision could be revisited if we get a sense that this causes undesired behaviour for users. How is this impacting you?

Hi @fg-j , thanks for the prompt answer, and sorry for my belated reply.
Thanks for the pointer, I wasn't aware that the semantics of the version in go.mod is "at least" - I thought it was stricter than that.
I would still prefer to use the version in go.mod rather than a more recent one, so I'll lobby for support for that feature here. I think it allows to make the build more deterministic and more consistent between different mechanisms (e.g. manual build triggered via a makefile and an automated build with something such as buildpacks). With just one look at one standard file one knows which version is being used for the build, rather than having to look at logs of the build process or the configuration for it. I also think it's safer. I know in theory if a program has been written with go 1.17 in mind it should be totally safe to build it with Go 1.x as long as x > 17, but in practice there could be oversights and mistakes from the language developers that break that (and not necessarily in obvious ways).
I know I can configure the buildpack to a specific version: https://paketo.io/docs/howto/go/#override-the-detected-go-version . But I'd rather have a unique, universally known place where the version for the build is used, so that any developer who looks at go.mod knows with which version the project is being built with. So it'd be nice if there was a way to configure the buildpacks always loyally tracks the version in go.mod.

I don't think we should enforce a semantic that is different than what the Go development team itself defines. Its actually relatively common to see applications with relatively old go directives in their go.mod file. In these cases, the buildpack could fail to build their application if it specifies a version that is now unsupported even though it should be reasonably buildable with any recent version of Go. I think many Go developers would find that behavior surprising since Go just "does the right thing" for them on their workstation even when they have a relatively old version specified.
As you've seen, we have other mechanisms that allow you to define what version you would like to be used.

@ryanmoran what about making the semantics I described a configuration option? i.e. keep the existing behavior, but allow providing a special value for the go version to use that loyally picks the version specified in go.mod ?

I think that could work. Maybe something like BP_LOCK_GOMOD_VERSION=true? If this gets set, we'd treat a go.mod file with the directive go 1.17 as 1.17.x instead of >= 1.17.0.

Thanks a lot for being open to consider this.
Yes, what you proposed would work.
An alternative would be to use a special value for the BP_GO_VERSION variable, such as follow-go-mod, the advantage is that there aren't two different variables that affect the same behavior.

@matteoolivi I like the idea of using the existing BP_GO_VERSION env var. Other @paketo-buildpacks/go-maintainers what do y'all think about that?

This issue has been open for a year without further comment. I'm going to close it as I don't think we're going to implement go.mod go version semantics that contradict the behavior of go.mod outside of a buildpack context.
If there are examples of how this proposed behavior would improve the user experience of a go application developer I'm happy to hear them and we can re-open this issue.


Would be awesome to be able to specify sizes of svg's like grunticon does it.

Any chance you'll release an update where it's possible (like with grunticon) to specify width and height for the output like so?
.icon {
background-repeat: no-repeat;
display: inline-block;
}
{{#items}}
.icon-{{slug}} {
background-image: url('{{{datauri}}}');
width: {{this.width}};
height: {{this.height}};
}
{{/items}}
Cheers,
Prakash

Dear Gavro,
Is this enhancement still being added? It would be really nice if the width and height could be set automatically within the mustache template file. This way we can just use something like  out of the box without specifying each of the dimensions in the CSS/SASS/LESS files individually.
Regards,
Leroy

Okay, working on it; will be using grunt-icon logic (from img-stats.js) for this.

Awesome! Thanks

On 27 Mar 2015, at 16:32, Gabrijel Gavranović<EMAIL_ADDRESS>wrote:
Okay, working on it; will be using grunt-icon logic (from img-stats.js) for this.
—
Reply to this email directly or view it on GitHub https://github.com/gavro/gulp-iconify/issues/1#issuecomment-86975980.


characters dropped after $

when using kustomize_patch as per below, anything attached to $ disappears from the render, there doesnt appear to be an escape key either to stop this from happening.
plugin:
  name: argocd-lovely-plugin
  env:
    - name: LOVELY_KUSTOMIZE_PATCH
      value: |-
        - op: replace
          path: /patches/0/patch
          value: |-
            - op: add
              path: /data/agent3.yaml
              value: $value

So in the above example the entire "$value" will disappear and leave it empty.
My use case is patching in configs for an prometheus that includes scraping configs that require variables such as "$1:$2" which are dropped and rendered as ":"

I have failed to reproduce this - see https://github.com/crumbhole/argocd-lovely-plugin/commit/db050c2a8c08938b05a7c15eef20e7a050b57ef1
That doesn't try and play with prometheus, but successfully injects a $value into a label.
Does this work if you manually run kustomize with a patch of that form, so not getting lovely to generate the kustomization.yaml?


approximate quantifiers in ElimData on incomplete types

For a datatype τ approximated in an incomplete way but with finite cardinal (say, 16), we need to encode ∀x:τ. p x into card(α_τ) = 16 ∧ ∀x:α_τ. p x.
See: bugs/quantifier_kodkod.nun

cc @blanchette for reference.


More background info?

A few questions I have about this repo:

It says pre-built binaries are included. Is this simply to reduce rebuild complexity, or is there another reason?

Pre-built binaries are only provided for linux and osx, what about windows, bsd, etc? Aside from reducing your own build complexity, is there any reason those platforms are omitted?

I saw mention of C, why is C used instead of rewriting v8 in pure go?

Another interpreter, otto, is written in Go, but has some limitations, such as Go doesn't support backtracking in regex which means those regex patterns aren't supported in the executed js. I assume this library isn't impacted since it doesn't use pure go?

What's the author's use case for this repo? Curious what problems you solved for yourself by tying v8 to go.

I really don't want to troll here, but this needs to be said: You can use otto to have a fairly complete js interpreter for ECMAscript 5. But if you want to really extensively use JS in your application, then you kind of need to use the v8 engine just because its the most mature implementation of the ECMAscript(6, 7?) standard. Rewriting the v8 engine in pure go would be more work than you can imagine. If you look at the issue tracker of the v8 engine you will see nearly 10k closed issues and the repo has over 65k commits. Sounds like the job of a bit more than a few weekends.
If you want to to see a more practical example, try to run this in otto:
package main

import (
	"fmt"

	"github.com/rs/zerolog/log"
	"rogchap.com/v8go"
)

// from https://github.com/v8/v8/blob/master/samples/hello-world.cc
const code = `
let bytes = new Uint8Array([
   0x00, 0x61, 0x73, 0x6d, 0x01, 0x00, 0x00, 0x00, 0x01, 0x07, 0x01,
   0x60, 0x02, 0x7f, 0x7f, 0x01, 0x7f, 0x03, 0x02, 0x01, 0x00, 0x07,
   0x07, 0x01, 0x03, 0x61, 0x64, 0x64, 0x00, 0x00, 0x0a, 0x09, 0x01,
   0x07, 0x00, 0x20, 0x00, 0x20, 0x01, 0x6a, 0x0b
]);
let module = new WebAssembly.Module(bytes);
const webasm = new WebAssembly.Instance(module);`

func main() {
	vm, _ := v8go.NewIsolate()    // creates a new JavaScript VM
	ctx, _ := v8go.NewContext(vm) // new context within the VM
	_, err := ctx.RunScript(code, "webassembler.js")
	if err != nil {
		log.Fatal().Err(err).Msg("failed to setup webassembler")
	}
	val, err := ctx.RunScript("webasm.exports.add(3, 4)", "main.js")
	if err != nil {
		log.Fatal().Err(err).Msg("failed to run script")
	}
	fmt.Printf("val: %v\n", val)
}

I really appreciate this library and how easy it is to use. It worked out of the box for me and its not the first v8 wrapper I tried.
Also, as far as I can tell, this is the best maintained wrapper :)
@rogchap please remove this comment if its too unconstructive, I really don't want to offend anyone.

I think this issue should be closed and the README could be extended with some information about the intended scope of the project. Adding prepared binaries for more platforms is surely a welcome contribution and contributors should feel free to step forward and assit.

More info in the Readme would make me happy. I wasn't critiquing the library, just wanting to understand a few choices.

I've update the readme to include project goals:

To provide a high quality, idiomatic, Go binding to the V8 C++ API.
The API should match the original API as closely as possible, but with an API that Gophers (Go enthusiasts) expect. For example: using multiple return values to return both result and error from a function, rather than throwing an exception.
This project also aims to keep up-to-date with the latest (stable) release of V8.

I've update the readme to include project goals:

To provide a high quality, idiomatic, Go binding to the V8 C++ API.
The API should match the original API as closely as possible, but with an API that Gophers (Go enthusiasts) expect. For example: using multiple return values to return both result and error from a function, rather than throwing an exception.
This project also aims to keep up-to-date with the latest (stable) release of V8.


Create Side Drawer Component

As part of the Home & Search redesigns, we will be leveraging a panel which is collapsible on mobile for the search filters & Home page information. While we wait on designs to finalize, we can begin implementing this component

Awaiting some additional UXD input before moving forward here

Closing this issue based on discussion with UXD. While we are still moving forward with the filters panel as well as the informational panel on the home page, we will not implement it as an expandable / closable drawer


📖 add a solution to join cluster through proxy server

Summary
Related issue(s)
Fixes #

/hold

/approve
/lgtm

/unhold


Update holding cells logic to handle already rendered nodes

Resolves #224

and npm publish-ed 3.8.2


More code cleanup

NormalView's constructor was getting unmanageable. These patches break it up into pieces and then clean those functions up to avoid code duplication.

Current coverage is 42.51% (diff: 49.52%)

Merging #6 into master will decrease coverage by 1.38%

@@             master         #6   diff @@
==========================================
  Files             3          3
  Lines           385        374    -11
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            169        159    -10
+ Misses          216        215     -1
  Partials          0          0

Powered by Codecov. Last update 1b7f79e...3ed3452

Looks great!


ARROW-12098: [R] Catch cpp build failures on linux

9896

 Quality gate: Passed
4 Issues

 4 Code issues

Details


ursula should fail is ursula_os is undefined

make ursula_os check covering the case that ursula_os is undefined.
Also, I notice that we support defined ursula_os in envs file, e.g group_vars/all.yml
Why should we support this feature?
Ursula always run setup to fetch ansible_distribution, then we set ursula_os according to ansible_distribution. May we meet the case that no ansible_distribution exists?

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

ok to test

Envs are generated by our tool and we know what operating system the cloud node are at that point. That is why have our envs generator tool always set in envs.


Add two backup urls for zookeeper

I've experiences some flakiness with a few of the zookeeper archive
urls. This adds two backup urls in the event that one of them is down or
a connection cannot be established.
Zookeeper was the only obvious candidate that had mirrors so we can start here and add other mirrors if people experience flakiness for other archives.
Closes https://github.com/apache/incubator-heron/issues/2855

👍


Long text in editor becomes invisible when selecting and scrolling horizontally.

When editor is in Single line mode, Long text in editor becomes invisible when selecting and scrolling horizontally.
Attached a video that shows the issue. the editor on the left is a normal gio editor and the right one is gioview editor with single line mode enabled.
https://github.com/user-attachments/assets/4d9baaba-42dd-40ee-895c-402abc530ab3

Did you do a diff with the gio editor regarding the single line mode code? I am not sure if some code is missing or not.

There are some differences but not related to single line.
I have found something in text_iterator.go on this line:
	glyphOffset := op.Affine(f32.Affine2D{}.Offset(f32.Point{X: span.offset})).Push(gtx.Ops)

And span.offset is -1 until selection reach the end visible area.
Original editor used t.lineOff here. I have tried with t.lineOff.X, as result selection looks working but text is not rendered correctly.
https://github.com/user-attachments/assets/3cc60157-dcc6-41e0-bd53-08373728a201

Hi @mirzakhany ,
I think I solved this problem after a few hours debugging😂. The problem is related to offset calculating of the glyph group. For multi-line editor, this was never a problem because editor does not scroll horizontally, and this issue was never found.
I put the patch in the same branch as the line number feature, so you could test them using the same branch.

Great job 💯  😆 Its working now!


jps: Watch <IP_ADDRESS>

jps requests the watch of the watch_keyword 38\.180\.14\.226. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

38\.180\.14\.226 has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


Sudo Plugin

When i try to run gui.sh i cannot access the sudo command. The message i get is: fatal error, unable to load plugins

When i try to run gui.sh i cannot access the sudo command. The message i get is: fatal error, unable to load plugins

Kindly share the output of
termux-info and which sudo


[gym_website]: Added a Scroll To Top Button with the theme

Title and Issue number
Successfully added a scroll to top button to the website and kept the theme same as website.
Preview

Close #4362

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md

@MohitGupta121 @TusharKesarwani sir kindly review this PR


METRON-389 Create Java API to Read Profile Data During Model Scoring

METRON-389
Changes

Created a Java API for reading profile data written by the Profiler.  This is contained within a new project metron-analytics/metron-profiler-client.
Altered the Profiler to use deterministic row keys so that multiple Gets can fetch the data.  This should scale much better at high volumes.

Points of Interest

ProfileMeasurement - Represents a single data point within a Profile.  A Profile is effectively a time series.  To this end a Profile is composed of many ProfileMeasurement values which in aggregate form a time series.
ProfilePeriod - The Profiler captures one ProfileMeasurement each ProfilePeriod.  A ProfilePeriod will occur at fixed, deterministic points in time.  This allows for efficient retrieval of profile data.
RowKeyBuilder - Builds row keys that can be used to read or write profile data to HBase.
ColumnBuilder - Defines the columns of data stored with a profile measurement.
ProfileHBaseMapper - Defines for the HBaseBolt how profile measurements are stored in HBase.  This class leverages a RowKeyBuilder and ColumnBuilder.

Testing
Spin up a Metron install and write some Profile data to HBase.  Read the profile data using metron-profiler-client.

Ok, I think I'm +1 on this pending the two JIRAs mentioned from the review:

Adjust ProfilerClient to add a method that takes a start/end time method.
Change the Serializer.toBytes(Object) to Serializer.toBytes(Number)

Created METRON-412 and METRON-413 to track those changes.  Will merge once the final CI build completes.


Audio 'File type' filters are missing types

Description

Currently, Audio only shows mp3, ogg and flac File type filters.
We need to add wav and aif to the list (any other type I missed?).
First reported by @dhruvkb
Reproduction

Go to https://search-staging.openverse.engineering/search/audio?q=sound&extension=mp3,ogg,flac
Open the filters if they are closed. Scroll down to the File type section.
You can only see 3 items in the list.

Screenshots

Additional context

Audio filtering by extension is still under development on the API and the Catalog side, so it's difficult to test.
I could only get results for filtering by mp3 extension (which includes all the audio results).
Resolution

[ ] 🙋 I would be interested in resolving this bug.

I wonder if these should be returned in the audio stats request (maybe same with the photos one) so we're not trying to hand maintain a list of all the formats we've catalogued.

For context, here are the filetypes we currently have in the audio database:

filetype

mid

mp32

oga

wav

webm

flac

mp3

opus

ogg


Disabled CollisionShape2D is not processed now

Fixes #24183

very nice

Fix is good, can you apply the same code to the Godot 3D part of physics?

Thanks!


Core, with net452 framework?

I'm not seeing a way to install Swashbuckle on an Asp.Net Core application using the net452 framework.
Swashbuckle 6.0 will only install on dnx framework.
Swashbuckle 5.0 is set up for OWIN
Is it possible to get Swashbuckle on a Core/net452 application?

Having the same issue. Any way around it?

See https://github.com/domaindrivendev/Ahoy/issues/143


feat(pwa-kit-dev): minor performance improvements and added comments

Description
This adds two minor improvements:

more if conditions to only execute the code than needed - it has a minor impact and saves around one second of build time as measured by the the speed-measure-webpack-plugin
added comments explaining the code a bit more - I had to customize this plugin for a project and it took me a few minutes to understand

Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

(change1)

How to Test-Drive This PR

(step1)

Checklists

General

[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[ ] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

@ecRobertEngel thank you for this PR. We'll take a look.

@vmarta I agree that I went a bit overboard with the comments. I guess that was the consequence of having to debug it. 😄 I cleaned it up a bit and followed your suggestions.
I also updated the condition as per your suggestion. Thank you for your feedback. 💯


Split credits by semicolons instead of commas

The character used to split credits in the glTF copyright field has been changed to semicolons in order to accommodate copyrights with commas in them.
cc @lilleyse for review

Thanks for the pull request @j9liu!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.


tomcat8

Hello.
i just noticed that the JDBC connector is bundled into the WAR file.This can cause memory leaks in tomcat8 as explained  here.
It would be better that the docs be updated to comment out the jdbc dependency for tomcat8 and instead the jar file be put in TOMCAT_HOME/lib.
I shall edit the wiki for this.
Thanks.

Edited the wiki


Travis builds failing on fork

Please only submit reproducible issues.
Worker information
hostname<EMAIL_ADDRESS>version: v6.2.0 https://github.com/travis-ci/worker/tree/5e5476e01646095f48eec13196fdb3faf8f5cbf7
instance: travis-job-df415e6f-857c-46c9-ad9c-e383f4c066a4 travis-ci-sardonyx-xenial-1553530528-f909ac5 (via amqp)
startup: 9.157477235s
system_info
Build system information
Build language: node_js
Build group: stable
Build dist: xenial
Build id: 117396176
Job id: 212052222
Runtime kernel version: 4.15.0-1028-gcp
travis-build version: b8049365d
Build image provisioning date and time
Mon Mar 25 16:43:24 UTC 2019
Operating System Details
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.6 LTS
Release:	16.04
Codename:	xenial
Systemd Version
systemd 229
Cookbooks Version
42e42e4 https://github.com/travis-ci/travis-cookbooks/tree/42e42e4
git version
git version 2.21.0
bash version
GNU bash, version 4.3.48(1)-release (x86_64-pc-linux-gnu)
gcc version
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609
docker version
Client:
Version:           18.06.0-ce
API version:       1.38
Go version:        go1.10.3
Git commit:        0ffa825
Built:             Wed Jul 18 19:11:02 2018
OS/Arch:           linux/amd64
Experimental:      false
Server:
Engine:
Version:          18.06.0-ce
API version:      1.38 (minimum version 1.12)
Go version:       go1.10.3
Git commit:       0ffa825
Built:            Wed Jul 18 19:09:05 2018
OS/Arch:          linux/amd64
Experimental:     false
clang version
clang version 7.0.0 (tags/RELEASE_700/final)
jq version
jq-1.5
bats version
Bats 0.4.0
shellcheck version
0.6.0
shfmt version
v2.6.3
ccache version
3.2.4
cmake version
heroku version
heroku/7.22.7 linux-x64 node-v11.10.1
imagemagick version
Version: ImageMagick 6.8.9-9 Q16 x86_64 2018-09-28 http://www.imagemagick.org
md5deep version
4.4
mercurial version
version 4.8
mysql version
mysql  Ver 14.14 Distrib 5.7.25, for Linux (x86_64) using  EditLine wrapper
openssl version
OpenSSL 1.0.2g  1 Mar 2016
packer version
1.3.3
postgresql client version
psql (PostgreSQL) 10.7 (Ubuntu 10.7-1.pgdg16.04+1)
ragel version
Ragel State Machine Compiler version 6.8 Feb 2013
sudo version
1.8.16
gzip version
gzip 1.6
zip version
Zip 3.0
vim version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Nov 24 2016 16:44:48)
iptables version
iptables v1.6.0
curl version
curl 7.47.0 (x86_64-pc-linux-gnu) libcurl/7.47.0 GnuTLS/3.4.10 zlib/1.2.8 libidn/1.32 librtmp/2.3
wget version
GNU Wget 1.17.1 built on linux-gnu.
rsync version
rsync  version 3.1.1  protocol version 31
gimme version
v1.5.3
nvm version
0.34.0
perlbrew version
/home/travis/perl5/perlbrew/bin/perlbrew  - App::perlbrew/0.86
phpenv version
rbenv 1.1.2
rvm version
rvm 1.29.7 (latest) by Michal Papis, Piotr Kuczynski, Wayne E. Seguin [https://rvm.io]
default ruby version
ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-linux]
CouchDB version
couchdb 1.6.1
ElasticSearch version
5.5.0
mInstalled Firefox version
firefox 63.0.1
MongoDB version
MongoDB 4.0.7
PhantomJS version
2.1.1
Pre-installed PostgreSQL versions
9.4.21
9.5.16
9.6.12
Redis version
redis-server 5.0.4
Pre-installed Go versions
1.11.1
mvn version
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z)
gradle version
Gradle 4.10.2!
lein version
Leiningen 2.9.1 on Java 11.0.2 OpenJDK 64-Bit Server VM
Pre-installed Node.js versions
v10.15.3
v11.0.0
v4.9.1
v6.17.0
v8.12.0
v8.15.1
v8.9
phpenv versions
system
5.6
5.6.40
7.1
7.1.27
7.2

7.2.15 (set by /home/travis/.phpenv/version)
hhvm
hhvm-stable
composer --version
Composer version 1.8.4 2019-02-11 10:52:10
Pre-installed Ruby versions
ruby-2.3.8
ruby-2.4.5
ruby-2.5.3
docker_mtu
resolvconf
git.checkout
1.40s$ git clone --depth=50 --branch=newinstaller https://github.com/sdetweil/MagicMirror.git sdetweil/MagicMirror
Cloning into 'sdetweil/MagicMirror'...
remote: Enumerating objects: 8019, done.
remote: Counting objects: 100% (8019/8019), done.
remote: Compressing objects: 100% (3571/3571), done.
remote: Total 8019 (delta 4577), reused 7783 (delta 4370), pack-reused 0
Receiving objects: 100% (8019/8019), 7.74 MiB | 27.79 MiB/s, done.
Resolving deltas: 100% (4577/4577), done.
$ cd sdetweil/MagicMirror
$ git checkout -qf db62b7421a3179b807af0d34a8e61d564f4ba2da
nvm.install
3.29s$ nvm install 8
Downloading and installing node v8.16.0...
Downloading https://nodejs.org/dist/v8.16.0/node-v8.16.0-linux-x64.tar.xz...
Computing checksum with sha256sum
Checksums matched!
Now using node v8.16.0 (npm v6.4.1)
cache.1
Setting up build cache
$ export CASHER_DIR=${TRAVIS_HOME}/.casher
0.29s$ Installing caching utilities
0.00s2.25sattempting to download cache archive
fetching newinstaller/cache-linux-xenial-e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855--node-8.tgz
fetching newinstaller/cache--node-8.tgz
fetching master/cache-linux-xenial-e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855--node-8.tgz
fetching master/cache--node-8.tgz
could not download cache
0.00s1.23sadding /home/travis/build/sdetweil/MagicMirror/node_modules to cache
creating directory /home/travis/build/sdetweil/MagicMirror/node_modules
$ node --version
v8.16.0
$ npm --version
6.4.1
$ nvm --version
0.34.0
install.npm
23.49s$ npm ci
npm WARN prepare removing existing node_modules/ before installation

<EMAIL_ADDRESS>postinstall /home/travis/build/sdetweil/MagicMirror/node_modules/electron
node install.js
<EMAIL_ADDRESS>install /home/travis/build/sdetweil/MagicMirror/node_modules/electron-chromedriver
node ./download-chromedriver.js
successfully dowloaded and extracted!
<EMAIL_ADDRESS>install /home/travis/build/sdetweil/MagicMirror
cd vendor && npm install
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
added 81 packages from 56 contributors and audited 219 packages in 3.091s
found 5 vulnerabilities (4 low, 1 high)
run npm audit fix to fix them, or npm audit for details
<EMAIL_ADDRESS>postinstall /home/travis/build/sdetweil/MagicMirror
sh installers/postinstall/postinstall.sh && npm run install-fonts
MagicMirror installation successful!
<EMAIL_ADDRESS>install-fonts /home/travis/build/sdetweil/MagicMirror
cd fonts && npm install
added 1 package from 1 contributor and audited 1 package in 0.956s
found 0 vulnerabilities
added 926 packages in 23.128s
before_script.1
0.92s$ yarn danger ci
yarn run v1.15.2
$ /home/travis/build/sdetweil/MagicMirror/node_modules/.bin/danger ci
You may have updated from Danger 2.x -> 3.x without updating from danger to danger ci.
Skipping Danger due to this run not executing on a PR.
before_script.2
5.04s$ npm install grunt-cli -g
/home/travis/.nvm/versions/node/v8.16.0/bin/grunt -> /home/travis/.nvm/versions/node/v8.16.0/lib/node_modules/grunt-cli/bin/grunt

<EMAIL_ADDRESS>added 150 packages from 121 contributors in 4.606s
before_script.3
0.00s$ export DISPLAY=:99.0
0.00s$ sh -e /etc/init.d/xvfb start
sh: 0: Can't open /etc/init.d/xvfb
The command "sh -e /etc/init.d/xvfb start" failed and exited with 127 during .
Your build has been stopped.

Hi @sdetweil this happend because the image using in default was xenial with PR #1748 fixed this issue. Please update your upstream branch from develop and should not failed.

Solved


NETOBSERV-1478: Add eBPF Agent flows filtering capability

Description
Add ability to configure flow filtering rule for ebpf agent
Dependencies

https://github.com/netobserv/netobserv-ebpf-agent/pull/307
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

[X] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
[X] Does this PR require product documentation?

[X] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

[ ] Does this PR require a product release notes entry?

[ ] If so, fill in "Release Note Text" in the JIRA.

[X] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

[ ] If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

[X] Standard QE validation, with pre-merge tests unless stated otherwise.
[ ] Regression tests only (e.g. refactoring with no user-facing change).
[ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

/ok-to-test

/ok-to-test

config used for testing
flowFilter:
        config:
          cidr: <IP_ADDRESS>/0
          destPorts: 0
          protocol: UDP
          sourcePorts: 53
        enable: true

/test e2e-operator

/retest

/ok-to-test

/ok-to-test

/ok-to-test

/test e2e-operator

/test e2e-operator

/retest

/ok-to-test

/ok-to-test

/ok-to-test

some cosmetic comments other than that lgtm

/ok-to-test

/ok-to-test

/ok-to-test

/label qe-approved

/approve

/test e2e-operator


Tests run for docs PRs

What happened:
There is a docs only PR here: https://github.com/kudobuilder/kudo/pull/676
The tests still ran for it and were required.

/priority low

Tests are running for every PR


Add workaround for travis issue.

As of the 2017-05-04 update to travis Precise images, /usr/local/bin/sbt is not
actually executable out of the box. We add a before_script hook per the
recommendation issued by the travis folks at travis-ci/travis-ci#7703 in order
to make sbt executable again, allowing the rest of the build to continue
normally.

If this fixes travis I'm just going to merge it <_<

It worked! :tada:


OpTestPCI: Ignore harmless timeout message.

When a sufficient amount of debugging has been enabled[0] Skiboot will
produce messages of the form
PHB#0030[8:0]: TRACE: Timeout waiting for link up
This is harmless and only represents an empty slot so filter it out on
all platforms.
Fixes #491
[0] nvram -p ibm,skiboot --update-config pci-tracing=true
Signed-off-by: Samuel Mendoza-Jonas<EMAIL_ADDRESS>

harmless

I would think we already addressed this with skiboot not reporting this as an error (by lowering the severity of the skiboot TRACE) and we may be going down a path here that we make defensive filtering and where would we stop that.  The proper fix is in skiboot and we should catch this failure and manually clean the system if needed.
I don't think this is needed, IMHO.

I can see what you're saying, but putting aside the log-level of the message this message is informational only AFAICS so it seems an over-reaction to fail a test on it. Indeed even once Skiboot changes the level for this to NOTICE, depending on what the log-level at runtime is op-test could still fail on it.
With the 177004 bug the timeout message was not directly related to the pcie-max-link-speed parameter being set I believe, but the point about clearing NVRAM debug options is good - I'm currently working on a solution for this for https://github.com/open-power/op-test-framework/issues/492

log-level at runtime

I think the command will not output the PR_NOTICE:
("grep ',[432]\].*PHB#.* Link down' /sys/firmware/opal/msglog"

clearing NVRAM debug options is good

Yes.

Ah right, it will ignore NOTICE. I still think we should filter this for existing Skiboot versions though and handle warning/clearing NVRAM options in a separate patch.

filter this for existing Skiboot versions

Since this is the first time we have seen this, I'm not sure it warrants introducing a maintenance item for the short window this will exist.

I think this got resolved in skiboot, so eh.


LogCollect jobs shouldn't clean up

It causes problems because you don't know if the job actually succeeded only with runtime information, there are other things that play a role there. Deleting the logArchives can lead to hopeless retries by subsequent jobs.
Discussed with @hufnagel, and a better idea would be to have a Cleanup subscription that takes care of the logs after these have been LogCollected and the jobs came back successfully.

If I looked at the right place
https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WMSpec/Steps/Executors/LogCollect.py#L184
then the cleanup in logCollect jobs is still in place and we need to fix it, eventually :D


docker compose bind mounts incorrect

Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /home/michael_e_brown/git/iDRAC-Telemetry-Reference-Tools/dashboards/FanRPM.json
When running setup:
$ ./docker-compose-files/compose.sh --setup-influx-test-db
Pass: Docker compose version is 2.2.3.
Cleaning up old containers for telemetry-reference-tools-influx: 8c090a61b2b4
833789f8c09c
Stopping: 8c090a61b2b4
833789f8c09c
Removing: 8c090a61b2b4
833789f8c09c
Cleaning up old containers for telemetry-reference-tools-grafana: 757330c6973d
Stopping: 757330c6973d
Removing: 757330c6973d
Removing volume: telemetry-reference-tools_influxdb-storagetelemetry-reference-tools_influxdb-storage
Set up environment file in /home/michael_e_brown/git/iDRAC-Telemetry-Reference-Tools/.env
To run manually, run the following command line:
docker-compose --project-directory /home/michael_e_brown/git/iDRAC-Telemetry-Reference-Tools -f /home/michael_e_brown/git/iDRAC-Telemetry-Reference-Tools/docker-compose-files/docker-compose.yml --profile setup-influx-test-db up  -d
WARN[0000] The "SPLUNK_HEC_URL" variable is not set. Defaulting to a blank string.
WARN[0000] The "SPLUNK_HEC_KEY" variable is not set. Defaulting to a blank string.
WARN[0000] The "SPLUNK_HEC_INDEX" variable is not set. Defaulting to a blank string.
[+] Running 5/5
⠿ Volume "idrac-telemetry-reference-tools_influxdb-storage"                    Created                                                                            0.0s
⠿ Volume "idrac-telemetry-reference-tools_grafana-storage"                     Created                                                                            0.0s
⠿ Container telemetry-reference-tools-influx                                   Created                                                                           13.8s
⠿ Container telemetry-reference-tools-grafana                                  Created                                                                           28.0s
⠿ Container idrac-telemetry-reference-tools-setup-influx-pump-1                Created                                                                           17.4s
⠋ Container idrac-telemetry-reference-tools-grafana-setup-influx-datasource-1  C...                                                                               0.0s
Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /home/michael_e_brown/git/iDRAC-Telemetry-Reference-Tools/dashboards/FanRPM.json
It looks like the compose yaml file has old stuff:
$ grep -r FanRPM.json *
docker-compose-files/docker-compose.yml:        source: ${PWD}/dashboards/FanRPM.json

accidentally broken and will be fixed with PR#85 in the review. Need one more approver to merge. other teams are OOO.


Fixed CanSupport func across all volumes (for PV)

CanSupport for PV was spotty across volumes.
NFS is covered in #8688.
ISCSI is covered #8133.
Added a test for ISCSI in this PR, though, because #8133 is already flagged ready to go.
@thockin

LGTM


Don't delete files from S3 if removed localy

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Recursive and alternative alias property types

Any plans to support recursive properties or alternate properties?
Could you not just have a class level attribute:
[CollescePropertyType("heading", "name")], such that heading is created with:
return this.GetPropertyValue<string>("heading", this.GetPropertyValue<string>("main"));
[RecursivePropertyType("heading")], such that heading is recursive:
return this.GetPropertyValue<string>("heading", true);

Could do. Will look into it after "3.next" is out, which will refactor how we process attributes and generate code--and should make such a feature easier to implement. So, stay tuned, but don't expect anything soon.

The simplest approach I have found is to add Strong-Typed support for GetPropertyValue to all the generated models.  Ie once doe the following sorts of things would work:
@Model.Content.GetPropertyValue(s => s.BannerImage, true)
@Model.Content.GetPropertyValue(s => s.BannerImage, "someOtherImage.gif")
@Model.Content.GetProeprtyValue(s => s.BannerImage, Model.Content.AlternateImage)

This approach keeps everything consistant with methods/mentality of the existing IPublishedContent methodology and doesn't generate a bunch of getter functions will still providing full support for Strong type's.
The code to do this is pretty simple.  Basicaly the following needs to be added to each gnerated model.
        //
        // Summary:
        //     Gets the value of a content's property identified by its alias, converted to
        //     a specified type.
        //
        //   property:
        //     The property.
        //
        // Type parameters:
        //   T:
        //     The target property type.
        //
        // Returns:
        //     The value of the content's property identified by the alias, converted to the
        //     specified type.
        //
        // Remarks:
        //     The value comes from IPublishedProperty field Value ie it is suitable for use
        //     when rendering content.
        //     If no property with the specified alias exists, or if the property has no value,
        //     or if it could not be converted, returns default(T).
        //     If eg a numeric property wants to default to 0 when value source is empty, this
        //     has to be done in the converter.
        //     The alias is case-insensitive.
public T GetPropertyValue<T>(Expression<Func<HomePage, object>> property)
        { return this.GetPropertyValue<T>(property.Body.NodeType == ExpressionType.Convert ? ((MemberExpression)((UnaryExpression)property.Body).Operand).Member.Name : ((MemberExpression)property.Body).Member.Name); }
        //
        // Summary:
        //     Recursively gets the value of a content's property identified by its alias, converted
        //     to a specified type.
        //
        //   property:
        //     The property.
        //
        //   recurse:
        //     A value indicating whether to recurse.
        //
        // Type parameters:
        //   T:
        //     The target property type.
        //
        // Returns:
        //     The value of the content's property identified by the alias, converted to the
        //     specified type.
        //
        // Remarks:
        //     Recursively means: walking up the tree from content, get the first value that
        //     can be found.
        //     The value comes from IPublishedProperty field Value ie it is suitable for use
        //     when rendering content.
        //     If no property with the specified alias exists, or if the property has no value,
        //     or if it could not be converted, returns default(T).
        //     If eg a numeric property wants to default to 0 when value source is empty, this
        //     has to be done in the converter.
        //     The alias is case-insensitive.
        public  T GetPropertyValue<T>(Expression<Func<HomePage, object>> property, bool recurse)
        { return this.GetPropertyValue<T>(property.Body.NodeType == ExpressionType.Convert ? ((MemberExpression)((UnaryExpression)property.Body).Operand).Member.Name : ((MemberExpression)property.Body).Member.Name, recurse); }
        //
        // Summary:
        //     Gets the value of a content's property identified by its alias, converted to
        //     a specified type, if it exists, otherwise a default value.
        //
        //   property:
        //     The property.
        //
        //   defaultValue:
        //     The default value.
        //
        // Type parameters:
        //   T:
        //     The target property type.
        //
        // Returns:
        //     The value of the content's property identified by the alias, converted to the
        //     specified type, if it exists, otherwise a default value.
        //
        // Remarks:
        //     The value comes from IPublishedProperty field Value ie it is suitable for use
        //     when rendering content.
        //     If no property with the specified alias exists, or if the property has no value,
        //     or if it could not be converted, returns defaultValue.
        //     If eg a numeric property wants to default to 0 when value source is empty, this
        //     has to be done in the converter.
        //     The alias is case-insensitive.
        public T GetPropertyValue<T>(Expression<Func<HomePage, object>> property, T defaultValue)
        { return this.GetPropertyValue<T>(property.Body.NodeType == ExpressionType.Convert ? ((MemberExpression)((UnaryExpression)property.Body).Operand).Member.Name : ((MemberExpression)property.Body).Member.Name, defaultValue); }
        //
        // Summary:
        //     Recursively gets the value of a content's property identified by its alias, converted
        //     to a specified type, if it exists, otherwise a default value.
        //
        //   property:
        //     The property.
        //
        //   recurse:
        //     A value indicating whether to recurse.
        //
        //   defaultValue:
        //     The default value.
        //
        // Type parameters:
        //   T:
        //     The target property type.
        //
        // Returns:
        //     The value of the content's property identified by the alias, converted to the
        //     specified type, if it exists, otherwise a default value.
        //
        // Remarks:
        //     Recursively means: walking up the tree from content, get the first value that
        //     can be found.
        //     The value comes from IPublishedProperty field Value ie it is suitable for use
        //     when rendering content.
        //     If no property with the specified alias exists, or if the property has no value,
        //     or if it could not be converted, returns defaultValue.
        //     If eg a numeric property wants to default to 0 when value source is empty, this
        //     has to be done in the converter.
        //     The alias is case-insensitive.
        public  T GetPropertyValue<T>(Expression<Func<HomePage, object>> property, bool recurse, T defaultValue)
        { return this.GetPropertyValue<T>(property.Body.NodeType == ExpressionType.Convert ? ((MemberExpression)((UnaryExpression)property.Body).Operand).Member.Name : ((MemberExpression)property.Body).Member.Name, recurse, defaultValue); }

I'm not that familiar with the project so I am looking through the code trying to find the generation code so I can make a PR.

A PR for this feature.  Might want to add some sample code somewhere to assist people.
https://github.com/zpqrtbnk/Zbu.ModelsBuilder/pull/114

Looking at the PR, I take it this issue should be closed?
A short explanation about availability in v8 (mentioned in the PR) would be welcome
Also is it really not worth adding it for those peeps that are stuck on v7?

Oh my this is old. Triaging now...
I think v4 (the upcoming new MB for v8) deals with this in a nice way... all properties eg model.Foo also have a corresponding method model.Foo() that supports all the overloads for fallback, recursive, etc.
So we do not generate properties that automatically recurse for instance. That is, model.Foo does not recurse, you'd have to model.Foo(fallback: Fallback.ToAncestors).
Going to close this issue as it's old. Interested in ideas, though.