wlroots: 0.14.1 -> 0.15.0

Release notes: https://gitlab.freedesktop.org/wlroots/wlroots/-/tags/0.15.0
https://gitlab.freedesktop.org/wlroots/wlroots/-/tags/0.15.0#changes-for-packagers

Motivation for this change
Note: Needs to target staging because https://github.com/NixOS/nixpkgs/pull/148588 isn't even in staging-next yet.
It might also be possible to avoid overriding Meson but reverting https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/31db23270426e47ca6487997ef3af25474593802 alone isn't sufficient (I might revisit this later but overriding Meson might be the better solution for now). Update: It looks like https://github.com/NixOS/nixpkgs/pull/144779 might make it in time :) I missed https://github.com/NixOS/nixpkgs/pull/150486. There are quite a few PRs regarding Meson... :o
Anyway, this is only a preliminary draft as most packages don't support wlroots 0.15.0 yet. We're in no hurry as this depends on staging so we can wait for a few reverse-dependencies to release updates (and for the rest we might have to keep wlroots 0.14 around).
nixpkgs-review

output

25 packages updated:
cage cagebreak dwl fnott grimshot hikari labwc nwg-panel python3.8-pywlroots python3.9-pywlroots qt-video-wlr qtile river sway sway-unwrapped tinywl (0.14.1 → 0.15.0) waybar waybox-unstable wayfire wayfire wcm wcm wf-shell wio wlroots (0.14.1 → 0.15.0)
$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/michael/.cache/nixpkgs-review/rev-2cda05aa1891ff30d9d1741da64f45e4bf54caa2/build.nix
error: builder for '/nix/store/ib4sikcymvhp2z5jqm4a1z48hlhzjhqj-cage-0.1.4.drv' failed with exit code 1;
last 10 log lines:
> [11/12] Compiling C object cage.p/seat.c.o
> In file included from ../view.h:8,
>                  from ../seat.h:12,
>                  from ../server.h:16,
>                  from ../output.h:8,
>                  from ../seat.c:30:
> /nix/store/viwpmq9yjklm864bf4flcf2bqwzn3g25-wlroots-0.15.0/include/wlr/types/wlr_box.h:4:2: warning: #warning "wlr_box has been moved to wlr/util/box.h" [-Wcpp]
>     4 | #warning "wlr_box has been moved to wlr/util/box.h"
>       |  ^~~~~~~
> ninja: build stopped: subcommand failed.
For full logs, run 'nix log /nix/store/ib4sikcymvhp2z5jqm4a1z48hlhzjhqj-cage-0.1.4.drv'.
error: builder for '/nix/store/r65n9ym6kc0snikh5sssji0v2sjg5mwb-dwl-0.2.1.drv' failed with exit code 2;
last 10 log lines:
> dwl.c: In function 'setup':
> dwl.c:2006:8: error: implicit declaration of function 'wlr_backend_get_renderer'; did you mean 'wlr_backend_get_session'? [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Werror=implicit-function-declaration8;;]
>  2006 |  drw = wlr_backend_get_renderer(backend);
>       |        ^~~~~~~~~~~~~~~~~~~~~~~~
>       |        wlr_backend_get_session
> dwl.c:2006:6: error: assignment to 'struct wlr_renderer *' from 'int' makes pointer from integer without a cast [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wint-conversion-Werror=int-conversion8;;]
>  2006 |  drw = wlr_backend_get_renderer(backend);
>       |      ^
> cc1: all warnings being treated as errors
> make: *** [: dwl.o] Error 1
For full logs, run 'nix log /nix/store/r65n9ym6kc0snikh5sssji0v2sjg5mwb-dwl-0.2.1.drv'.
error: builder for '/nix/store/a51fcgsljmqyg0yv1vpqf7975igz4nhs-cagebreak-1.8.1.drv' failed with exit code 1;
last 10 log lines:
> Host machine cpu: x86_64
> Found pkg-config: /nix/store/7qz8f0waphy9w9k72n10dsnp469cbnx0-pkg-config-wrapper-0.29.2/bin/pkg-config (0.29.2)
> Dependency wlroots found: NO found 0.15.0 but need: '< 0.15.0' ; matched: '>=0.14.1'
> Did not find CMake 'cmake'
> Found CMake: NO
> Run-time dependency wlroots found: NO
>
> meson.build:56:0: ERROR: Invalid version of dependency, need 'wlroots' ['< 0.15.0'] found '0.15.0'.
>
> A full log can be found at /build/source/build/meson-logs/meson-log.txt
For full logs, run 'nix log /nix/store/a51fcgsljmqyg0yv1vpqf7975igz4nhs-cagebreak-1.8.1.drv'.
error: builder for '/nix/store/6vmziaxrj3bgpc6hhmk8v8apw37gw0wx-hikari-2.3.2.drv' failed with exit code 2;
last 10 log lines:
> --- layout_config.o ---
> gcc -g  -DNDEBUG -D_POSIX_C_SOURCE=200809L -DHAVE_XWAYLAND=1 -DHAVE_GAMMACONTROL=1 -DHAVE_SCREENCOPY=1 -DHAVE_LAYERSHELL=1 -Wall -I. -Iinclude -DHIKARI_ETC_PREFIX=/nix/store/f9fkxbf8xvrn98xswldjahc34c67lf9k-hikari-2.3.2 -I/nix/store/viwpmq9yjklm864bf4flcf2bqwzn3g25-wlroots-0.15.0/include -DWLR_USE_UNSTABLE=1  -I/nix/store/zmxymm75klwac50jgl9a420rpgfg6my2-cairo-1.16.0-dev/include/cairo -I/nix/store/706b004d0pxn8d46a56lxm43rhsr2wmd-freetype-2.11.1-dev/include/freetype2 -I/nix/store/706b004d0pxn8d46a56lxm43rhsr2wmd-freetype-2.11.1-dev/include -I/nix/store/p8ykq0gnbwsa794d8mj4yakmk67bp19n-glib-2.70.2-dev/include -I/nix/store/p8ykq0gnbwsa794d8mj4yakmk67bp19n-glib-2.70.2-dev/include/glib-2.0 -I/nix/store/j8p94v2z2nyswfgrwx8apf8x8ybhs6h0-glib-2.70.2/lib/glib-2.0/include -I/nix/store/247v8a736k31lvk91ckhv6isjahxibqk-pango-1.50.0-dev/include/pango-1.0 -I/nix/store/ngisypcp2av7lq3nd1xnxncb8crs0j4h-harfbuzz-3.1.2-dev/include/harfbuzz  -I/nix/store/zmxymm75klwac50jgl9a420rpgfg6my2-cairo-1.16.0-dev/include/cairo -I/nix/store/706b004d0pxn8d46a56lxm43rhsr2wmd-freetype-2.11.1-dev/include/freetype2 -I/nix/store/706b004d0pxn8d46a56lxm43rhsr2wmd-freetype-2.11.1-dev/include  -I/nix/store/wczr3m65fw2vrdk326lvy6rvmj5jfijb-pixman-0.38.4/include/pixman-1  -I/nix/store/0clba7vlkxjf30andxcirvm8byswyp0g-libxkbcommon-1.3.1-dev/include  -I/nix/store/4jvpab4vm58bk5pgvf8v78vczwy2gw69-wayland-1.20.0-dev/include  -I/nix/store/pgz5qlaisq2nsv503n8v2q5iwska2wgm-libinput-1.19.1-dev/include  -I/nix/store/93pr07i9afpxi665n4i48y6ikbvq3yw1-libucl-0.8.1/include/  -c src/layout_config.c
> In file included from include/hikari/split.h:4,
>                  from src/layout_config.c:6:
> /nix/store/viwpmq9yjklm864bf4flcf2bqwzn3g25-wlroots-0.15.0/include/wlr/types/wlr_box.h:4:2: warning: #warning "wlr_box has been moved to wlr/util/box.h" [-Wcpp]
>     4 | #warning "wlr_box has been moved to wlr/util/box.h"
>       |  ^~~~~~~
> 1 error
>
> bmake: stopped in /build/source
For full logs, run 'nix log /nix/store/6vmziaxrj3bgpc6hhmk8v8apw37gw0wx-hikari-2.3.2.drv'.
error: builder for '/nix/store/9iji64icrrkb3z9xzvpqv49lnlwy97vr-labwc-0.3.0.drv' failed with exit code 1;
last 10 log lines:
> Found pkg-config: /nix/store/7qz8f0waphy9w9k72n10dsnp469cbnx0-pkg-config-wrapper-0.29.2/bin/pkg-config (0.29.2)
> Dependency wlroots found: NO found 0.15.0 but need: '<0.15.0' ; matched: '>=0.14.0'
> Did not find CMake 'cmake'
> Found CMake: NO
> Run-time dependency wlroots found: NO (tried pkgconfig and cmake)
> Looking for a fallback subproject for the dependency wlroots
>
> meson.build:52:2: ERROR: Subproject "subprojects/wlroots" required but not found.
>
> A full log can be found at /build/source/build/meson-logs/meson-log.txt
For full logs, run 'nix log /nix/store/9iji64icrrkb3z9xzvpqv49lnlwy97vr-labwc-0.3.0.drv'.
error: builder for '/nix/store/r67hfgvijb2gmnb5vbp7mxdyzb60i09v-go-1.16.12.drv' failed with exit code 1;
last 10 log lines:
> ok          cmd/link/internal/benchmark     0.030s
> ok      cmd/link/internal/ld    4.772s
> ok      cmd/link/internal/loader        0.039s
> ok      cmd/nm  3.105s
> ok      cmd/objdump     4.912s
> ok      cmd/pack        3.497s
> ok      cmd/trace       0.264s
> ok      cmd/vet 17.931s
> FAIL
> go tool dist: Failed: exit status 1
For full logs, run 'nix log /nix/store/r67hfgvijb2gmnb5vbp7mxdyzb60i09v-go-1.16.12.drv'.
error: builder for '/nix/store/19jcpc96xbbm8nhv7kg7fikf6jvhzz96-python3.9-pywlroots-0.14.11.drv' failed with exit code 1;
last 10 log lines:
> 17350 |   { "wlr_output_state_buffer_type", 801, _cffi_prim_int(sizeof(enum wlr_output_state_buffer_type), ((enum wlr_output_state_buffer_type)-1) <= 0),
>       |                                          ^~~~~~~~~~~~~~
> build/temp.linux-x86_64-3.9/wlroots._ffi.c:17350:107: error: conversion to incomplete type
> 17350 |   { "wlr_output_state_buffer_type", 801, _cffi_prim_int(sizeof(enum wlr_output_state_buffer_type), ((enum wlr_output_state_buffer_type)-1) <= 0),
>       |                                                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> build/temp.linux-x86_64-3.9/wlroots._ffi.c:541:22: note: in definition of macro ‘_cffi_prim_int’
>   541 |     ((size) == 1 ? ((sign) ? _CFFI_PRIM_INT8  : _CFFI_PRIM_UINT8)  :
>       |                      ^~~~
> build/temp.linux-x86_64-3.9/wlroots._ffi.c:17350: confused by earlier errors, bailing out
> error: command '/nix/store/69z43737d703p0q8c5liv27qfsd126ld-gcc-wrapper-10.3.0/bin/gcc' failed with exit code 1
For full logs, run 'nix log /nix/store/19jcpc96xbbm8nhv7kg7fikf6jvhzz96-python3.9-pywlroots-0.14.11.drv'.
error: builder for '/nix/store/18mlf7mn0d5nnb5k9fqbycjz75h7zwyq-python3.8-pywlroots-0.14.11.drv' failed with exit code 1;
last 10 log lines:
> 17350 |   { "wlr_output_state_buffer_type", 801, _cffi_prim_int(sizeof(enum wlr_output_state_buffer_type), ((enum wlr_output_state_buffer_type)-1) <= 0),
>       |                                          ^~~~~~~~~~~~~~
> build/temp.linux-x86_64-3.8/wlroots._ffi.c:17350:107: error: conversion to incomplete type
> 17350 |   { "wlr_output_state_buffer_type", 801, _cffi_prim_int(sizeof(enum wlr_output_state_buffer_type), ((enum wlr_output_state_buffer_type)-1) <= 0),
>       |                                                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> build/temp.linux-x86_64-3.8/wlroots._ffi.c:541:22: note: in definition of macro ‘_cffi_prim_int’
>   541 |     ((size) == 1 ? ((sign) ? _CFFI_PRIM_INT8  : _CFFI_PRIM_UINT8)  :
>       |                      ^~~~
> build/temp.linux-x86_64-3.8/wlroots._ffi.c:17350: confused by earlier errors, bailing out
> error: command 'gcc' failed with exit status 1
For full logs, run 'nix log /nix/store/18mlf7mn0d5nnb5k9fqbycjz75h7zwyq-python3.8-pywlroots-0.14.11.drv'.
error: builder for '/nix/store/6028wc3zm358nk7xzn1p0rfi9qzg6xq0-sway-unwrapped-1.6.1.drv' failed with exit code 1;
last 10 log lines:
> Library m found: YES
> Library rt found: YES
> Neither a subproject directory nor a wlroots.wrap file was found.
> Subproject  wlroots is buildable: NO (disabling)
> Dependency wlroots found: NO found 0.15.0 but need: '<0.15.0' ; matched: '>=0.14.0'
> Run-time dependency wlroots found: NO
>
> meson.build:74:1: ERROR: Invalid version of dependency, need 'wlroots' ['<0.15.0'] found '0.15.0'.
>
> A full log can be found at /build/source/build/meson-logs/meson-log.txt
For full logs, run 'nix log /nix/store/6028wc3zm358nk7xzn1p0rfi9qzg6xq0-sway-unwrapped-1.6.1.drv'.
error: 1 dependencies of derivation '/nix/store/dl1552pw5716ll1bxbr9pfrfl5yjr0ak-sway.drv' failed to build
error: 2 dependencies of derivation '/nix/store/srwqqcsd5m4sd7898shnkn8zylx5s6zk-sway-1.6.1.drv' failed to build
error: builder for '/nix/store/i1nnb4jaikzg5dm9ahzjhh507whhxvfc-waybox-unstable-2021-04-07.drv' failed with exit code 1;
last 10 log lines:
> ../waybox/server.c: In function 'wb_create_backend':
> ../waybox/server.c:18:21: error: implicit declaration of function 'wlr_backend_get_renderer'; did you mean 'wlr_backend_get_session'? [-Werror=implicit-function-declaration]
>    18 |  server->renderer = wlr_backend_get_renderer(server->backend);
>       |                     ^~~~~~~~~~~~~~~~~~~~~~~~
>       |                     wlr_backend_get_session
> ../waybox/server.c:18:19: error: assignment to 'struct wlr_renderer *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
>    18 |  server->renderer = wlr_backend_get_renderer(server->backend);
>       |                   ^
> cc1: all warnings being treated as errors
> ninja: build stopped: subcommand failed.
For full logs, run 'nix log /nix/store/i1nnb4jaikzg5dm9ahzjhh507whhxvfc-waybox-unstable-2021-04-07.drv'.
error: builder for '/nix/store/16m71ph8yq6bqfky43j183dbwfffbczj-wayfire-0.7.2.drv' failed with exit code 1;
last 10 log lines:
> |Run-time dependency xcb-dri3 found: YES 1.14
> |Run-time dependency xcb-present found: YES 1.14
> |Run-time dependency xcb-render found: YES 1.14
> |Run-time dependency xcb-renderutil found: NO (tried pkgconfig and cmake)
> |Message: Install "xcb-renderutil" or pass "-Dx11-backend=disabled" to disable it.
> |Required for X11 backend support.
>
> subprojects/wlroots/backend/x11/meson.build:22:1: ERROR: Dependency "xcb-renderutil" not found, tried pkgconfig and cmake
>
> A full log can be found at /build/wayfire-0.7.2/build/meson-logs/meson-log.txt
For full logs, run 'nix log /nix/store/16m71ph8yq6bqfky43j183dbwfffbczj-wayfire-0.7.2.drv'.
error: 1 dependencies of derivation '/nix/store/d8iclihg29pic4324fp2s0aym1m1zgcg-grimshot-1.6.1.drv' failed to build
error: 1 dependencies of derivation '/nix/store/4gm2098jfydydiws3smrc0is00mwijgg-python3.9-qtile-0.18.1.drv' failed to build
error: 2 dependencies of derivation '/nix/store/fhsrk4bl27d23pp9nk2qgvnwhqhhdlsq-qtile-0.18.1.drv' failed to build
error: 1 dependencies of derivation '/nix/store/p6s7hr30acl48l02s51cbx81fjqs773a-nwg-menu-0.1.1.drv' failed to build
error: 1 dependencies of derivation '/nix/store/c7bmmk1dlijm7657xzfrwxv281cb9x10-wio-0.pre+unstable=2021-06-27.drv' failed to build
error: 2 dependencies of derivation '/nix/store/7jgzwhbin5rcx4rwr1ib2hil6i926371-nwg-panel-0.5.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/xciqxlrar5n4hpvxa68awvsjhxi8879a-waybar-0.9.8.drv' failed to build
error: 1 dependencies of derivation '/nix/store/brjvxb0005196jkp5f93csjqvaw54ydd-wf-shell-0.7.0.drv' failed to build
error: 2 dependencies of derivation '/nix/store/sq25d6baxp2hdr83zbc7brrknqbbszcv-wayfire-0.7.2-wrapped.drv' failed to build
error: 2 dependencies of derivation '/nix/store/1c0ss4xsv5agvjnzvi3fa02ly5830zfx-wcm-0.7.0.drv' failed to build
error: 2 dependencies of derivation '/nix/store/rvvpsgwdc1ap3w7fs8y1rr0n63gjpp1q-wcm-0.7.0-wrapped.drv' failed to build
[2/335/354 built (11 failed), 322 copied (1265.8/1266.9 MiB), 691.5 MiB DL] building qtbase-5.15.3 (buildPhase): g++ -c -include .pch/Qt5Widgets -pipe -O2 -std=c++1z -fvisibility=hidden -fvisibility-inlines-hidd [2/335/354 built (11 failed), 322 copied (1265.8/1266.9 MiB), 691.5 MiB DL] building qtbase-5.15.3 (buildPhase): g++ -c -include .pch/Qt5OpenGL -pipe -O2 -std=c++1z -fvisibility=hidden -fvisibility-inlines-hidde error: builder for '/nix/store/c7rw7vxfp7yd73m3m0x775nl1j60714y-river-0.1.0.drv' failed with exit code 1;
last 10 log lines:
> building
> no Makefile, doing nothing
> installing
> 7LLVM Emit Object... 878787Semantic Analysis... 87Semantic Analysis [83/203] 87Semantic Analysis [199/597] 87Semantic Analysis [428/929] 87Semantic Analysis [653/1208] 87Semantic Analysis [787/1457] 87Semantic Analysis [909/1703] 87Semantic Analysis [953/1745] 87Semantic Analysis [965/1775] 87Semantic Analysis [965/1810] 87Semantic Analysis [965/1830] 87Semantic Analysis [967/1852] 87Semantic Analysis [967/1855] 87Semantic Analysis [967/1862] 87Semantic Analysis [967/1862] 87Semantic Analysis [1042/2022] 87Semantic Analysis [1124/2308] 87Semantic Analysis [1230/2414] 87Semantic Analysis [1293/2545] 87Semantic Analysis [1419/2707] 87Semantic Analysis [1443/2780] 87Semantic Analysis [1476/2806] 87Semantic Analysis [1593/2959] 87Semantic Analysis [1723/3044] 87Semantic Analysis [1850/3152] 87Semantic Analysis [1984/3375] 87Semantic Analysis [2192/3515] 87Semantic Analysis [2221/3625] 87Semantic Analysis [2251/3741] 87Semantic Analysis [2387/3851] 87Semantic Analysis [2460/3965] 87Semantic Analysis [2523/4010] 87Semantic Analysis [2550/4032] 87Semantic Analysis [2625/4136] 87Semantic Analysis [2783/4223] 87Semantic Analysis [2869/4303] 87Semantic Analysis [3483/4375] 87Code Generation [112/2926] std.leb128.readULEB128... 87Code Generation [593/2926] std.build.Builder.validateUserInputDidItFail... 87Code Generation [1055/2926] std.io.writer.Writer(*std.io.fixed_buffer_stream.FixedBu... 87Code Generation [1433/2926] std.zig.binNameAlloc... 87Code Generation [1803/2926] std.buf_set.BufSet.init... 87Code Generation [2216/2926] std.fmt.format... 87Code Generation [2643/2926] std.fmt.formatIntValue... 87LLVM Emit Object... 87LLVM Emit Object... 8787LLVM Emit Object... 8787Semantic Analysis... 87Semantic Analysis [129/190] 87Semantic Analysis [129/968] 87Semantic Analysis [129/1329] 87Semantic Analysis [400/1901] 87Semantic Analysis [568/2456] 87Semantic Analysis [893/2852] 87Semantic Analysis [1059/3111] 87Semantic Analysis [1293/3310] 87Semantic Analysis [1532/3686] 87Semantic Analysis [1747/3833] 87Semantic Analysis [1929/3991] 87Semantic Analysis [1994/4136] 87Semantic Analysis [2124/4301] 87Semantic Analysis [2243/4399] 87Semantic Analysis [2357/4498] 87Semantic Analysis [2451/4597] 87Semantic Analysis [2581/4674] 87Semantic Analysis [2661/4748] 87Semantic Analysis [3962/4850] 878./deps/zig-wlroots/src/wlroots.zig:165:9: error: zig-wlroots requires wlroots version 0.14
>         @compileError("zig-wlroots requires wlroots version 0.14");
>         ^
> river...The following command exited with error code 1:
> /nix/store/frb7ahy5lzv6zncy3h9f60g05l6jpwwp-zig-0.8.1/bin/zig build-exe /build/source/river/main.zig -lc -levdev -linput -lwayland-server -lxkbcommon -lpixman-1 -lwlroots -cflags -std=c99 -O2 -- /build/source/river/wlroots_log_wrapper.c -cflags -std=c99 -- /build/source/zig-cache/zig-wayland/xdg-shell-protocol.c -cflags -std=c99 -- /build/source/zig-cache/zig-wayland/pointer-gestures-unstable-v1-protocol.c -cflags -std=c99 -- /build/source/zig-cache/zig-wayland/xdg-output-unstable-v1-protocol.c -cflags -std=c99 -- /build/source/zig-cache/zig-wayland/pointer-constraints-unstable-v1-protocol.c -cflags -std=c99 -- /build/source/zig-cache/zig-wayland/river-control-unstable-v1-protocol.c -cflags -std=c99 -- /build/source/zig-cache/zig-wayland/river-status-unstable-v1-protocol.c -cflags -std=c99 -- /build/source/zig-cache/zig-wayland/river-layout-v3-protocol.c -cflags -std=c99 -- /build/source/zig-cache/zig-wayland/wlr-layer-shell-unstable-v1-protocol.c -cflags -std=c99 -- /build/source/zig-cache/zig-wayland/wlr-output-power-management-unstable-v1-protocol.c --pkg-begin build_options /build/source/zig-cache/river_build_options.zig --pkg-end -OReleaseSafe --cache-dir /build/source/zig-cache --global-cache-dir /build/.cache/zig --name river --pkg-begin wayland /build/source/zig-cache/zig-wayland/wayland.zig --pkg-end --pkg-begin xkbcommon /build/source/deps/zig-xkbcommon/src/xkbcommon.zig --pkg-end --pkg-begin pixman /build/source/deps/zig-pixman/pixman.zig --pkg-end --pkg-begin wlroots /build/source/deps/zig-wlroots/src/wlroots.zig --pkg-begin wayland /build/source/zig-cache/zig-wayland/wayland.zig --pkg-end --pkg-begin xkbcommon /build/source/deps/zig-xkbcommon/src/xkbcommon.zig --pkg-end --pkg-begin pixman /build/source/deps/zig-pixman/pixman.zig --pkg-end --pkg-end --pkg-begin flags /build/source/common/flags.zig --pkg-end -I /nix/store/zdjdgnfpbd934z6a34mnsrd7v7603qy7-libevdev-1.11.0/include/libevdev-1.0 -I /nix/store/pgz5qlaisq2nsv503n8v2q5iwska2wgm-libinput-1.19.1-dev/include -I /nix/store/4jvpab4vm58bk5pgvf8v78vczwy2gw69-wayland-1.20.0-dev/include -I /nix/store/0clba7vlkxjf30andxcirvm8byswyp0g-libxkbcommon-1.3.1-dev/include -I /nix/store/wczr3m65fw2vrdk326lvy6rvmj5jfijb-pixman-0.38.4/include/pixman-1 -I /nix/store/viwpmq9yjklm864bf4flcf2bqwzn3g25-wlroots-0.15.0/include -L /nix/store/zdjdgnfpbd934z6a34mnsrd7v7603qy7-libevdev-1.11.0/lib -L /nix/store/8pgxy693dvi33b62xvi455zhjdm9v20w-libinput-1.19.1/lib -L /nix/store/df0dzhc32haz9qwc9pvzv8ga7sm5yhqy-wayland-1.20.0/lib -L /nix/store/viwwaij8rg308q9fgsnbffsvvpp4v6pi-libxkbcommon-1.3.1/lib -L /nix/store/wczr3m65fw2vrdk326lvy6rvmj5jfijb-pixman-0.38.4/lib -L /nix/store/viwpmq9yjklm864bf4flcf2bqwzn3g25-wlroots-0.15.0/lib --enable-cache
> error: the following build command failed with exit code 1:
> /build/source/zig-cache/o/adaced282b5169c0cbb795b10fc8562f/build /nix/store/frb7ahy5lzv6zncy3h9f60g05l6jpwwp-zig-0.8.1/bin/zig /build/source /build/source/zig-cache /build/.cache/zig -Drelease-safe -Dcpu=baseline -Dxwayland -Dman-pages --prefix /nix/store/jjvgyp855vil183h63xpl5nq323wdys2-river-0.1.0 install
For full logs, run 'nix log /nix/store/c7rw7vxfp7yd73m3m0x775nl1j60714y-river-0.1.0.drv'.
error: 21 dependencies of derivation '/nix/store/p2n723lrc328nngs5364c1l1lvwqh87y-review-shell.drv' failed to build
21 packages failed to build:
cage cagebreak dwl hikari labwc nwg-panel python38Packages.pywlroots python39Packages.pywlroots qtile river sway sway-contrib.grimshot sway-unwrapped waybar waybox wayfire wayfireApplications-unwrapped.wayfire wayfireApplications-unwrapped.wayfirePlugins.wf-shell wayfireApplications-unwrapped.wcm wcm wio
4 packages built:
fnott qt-video-wlr tinywl wlroots

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Supersedes #144142
On Sat, 18 Dec 2021, 23:48 ofborg[bot], @.***> wrote:

@ofborg https://github.com/ofborg[bot] requested your review on: #151234
https://github.com/NixOS/nixpkgs/pull/151234 wlroots: 0.14.1 -> 0.15.0.
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/151234#event-5788539410, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABV7PJ5U4UG5MAZVAC2O4TLURUFSVANCNFSM5KLCXZGQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because your review was requested.Message ID:
@.***>

@primeos I pushed some work I had locally on this same bump onto your branch, feel free to drop my commits though if you think they increase complexity too much.
I just made the renderer and backends configurable as derivation args.

@lovesegfault thanks for your efforts. Unfortunately I do disagree with most of those changes though. Could you provide a rationale for them (i.e. is there also a use-case in or outside Nixpkgs that requires this degree of customization)?
I'd just keep enabling all features for now and only introduce such options when there's a need for them (to keep unnecessary complexity to a minimum).
I'm also against setting options to their defaults ("-Dexamples=true" and "-Dxcb-errors=enabled"). And if we want to make the backends and renderers configurable they should default to [ "auto" ] (or e.g. null) - i.e. all enabled).
This is just my personal opinion though and it's up for debate ;)

@lovesegfault thanks for your efforts. Unfortunately I do disagree with most of those changes though. Could you provide a rationale for them (i.e. is there also a use-case in or outside Nixpkgs that requires this degree of customization)?

There are new things using wlroots being released all the time, I think it makes sense to let other drvs easily customize wlroots. In particular, the Qubes folks have been doing work on making a lot of the currently built-in components of wlroots optional, and it'd be cool if Nix was an easy was of experimenting with that.
Mostly, I just see wlroots as a flexible library, and want to make sure it's easy to express that flexibility in nix.

I'd just keep enabling all features for now and only introduce such options when there's a need for them (to keep unnecessary complexity to a minimum).

That's fair enough, as I said I'm absolutely fine with dropping my commits, I just had them ready and wanted them to be outside of my local checkout in case there was interest. We could just revisit this when someone opens an issue for this.

I'm also against setting options to their defaults ("-Dexamples=true" and "-Dxcb-errors=enabled"). And if we want to make the backends and renderers configurable they should default to [ "auto" ] (or e.g. null) - i.e. all enabled).

I feel mixed about this, IMHO if we have code to install examples (which we do) we should be manually saying "please build examples" to prevent this from silently breaking if examples ever default to false. Likewise, if we're going through the trouble of bringing in xcb-errors as a dependency (which we are) we should also be making sure it's being used by enabling it. I mostly fear a scenario where their build system decides it will look for xcb-errors differently, won't find ours, and the build will start to happen without xcb-errors silently (as opposed to erroring if the feature was manually enabled).

This is just my personal opinion though and it's up for debate ;)

I think we should revert/drop my commits for now, once this lands I'm happy to place them in a new/separate PR and further discussion can happen there. I probably should have done that to begin with :)

That's fair enough, as I said I'm absolutely fine with dropping my commits, I just had them ready and wanted them to be outside of my local checkout in case there was interest. We could just revisit this when someone opens an issue for this.

Ok, your points are also valid. If I think about it I'd prefer to keep this out of this PR though as this is only about updating wlroots and should try to cause as little discussion as possible (it should be a simple bump but of course there are already a few additional design decisions that have to be made). Feel free to open a dedicated PR if you want ;)

I feel mixed about this, IMHO if we have code to install examples (which we do) we should be manually saying "please build examples" to prevent this from silently breaking if examples ever default to false.

The examples are optional and we could rewrite postFixup to detect this. It's also unlikely that they silently change the default and I always keep an eye on such changes.

I mostly fear a scenario where their build system decides it will look for xcb-errors differently, won't find ours, and the build will start to happen without xcb-errors silently (as opposed to erroring if the feature was manually enabled).

No, that's my point, unless upstream changes the default or we drop -Dauto_features=enabled it doesn't make a difference. And after all we have -Dauto_features=enabled for a reason.

I think we should revert/drop my commits for now, once this lands I'm happy to place them in a new/separate PR and further discussion can happen there. I probably should have done that to begin with :)

+1, thanks :) We can hopefully merge this PR soon.
Regarding this PR: I'm currently waiting a bit until the first reverse-dependencies start to support version 0.15 but we could already merge it regardless, if required.

Maybe merge, but set wlroots = wlroots_0_14 until Sway updates?
On Tue, 21 Dec 2021, 21:12 Michael Weiss, @.***> wrote:

That's fair enough, as I said I'm absolutely fine with dropping my
commits, I just had them ready and wanted them to be outside of my local
checkout in case there was interest. We could just revisit this when
someone opens an issue for this.
Ok, your points are also valid. If I think about it I'd prefer to keep
this out of this PR though as this is only about updating wlroots and
should try to cause as little discussion as possible (it should be a simple
bump but of course there are already a few additional design decisions that
have to be made). Feel free to open a dedicated PR if you want ;)
I feel mixed about this, IMHO if we have code to install examples (which
we do) we should be manually saying "please build examples" to prevent this
from silently breaking if examples ever default to false.
The examples are optional and we could rewrite postFixup to detect this.
It's also unlikely that they silently change the default and I always keep
an eye on such changes.
I mostly fear a scenario where their build system decides it will look for
xcb-errors differently, won't find ours, and the build will start to happen
without xcb-errors silently (as opposed to erroring if the feature was
manually enabled).
No, that's my point, unless upstream changes the default or we drop
-Dauto_features=enabled it doesn't make a difference. And after all we
have -Dauto_features=enabled for a reason.
I think we should revert/drop my commits for now, once this lands I'm
happy to place them in a new/separate PR and further discussion can happen
there. I probably should have done that to begin with :)
+1, thanks :) We can hopefully merge this PR soon.
Regarding this PR: I'm currently waiting a bit until the first
reverse-dependencies start to support version 0.15 but we could already
merge it regardless, if required.
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/151234#issuecomment-999064241, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABV7PJ3V4TQRMUVRWXCZVCTUSDNTRANCNFSM5KLCXZGQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because your review was requested.Message ID:
@.***>

@Synthetica9 ok, yeah, I was thinking of setting wlroots = wlroots_0_14 per package instead of "globally" (which is what you meant, right?) but now I actually like your global approach more :) The packages that break with this update have a high chance to break again with wlroots 0.16 so it could make sens to select the wlroots version per package, e.g. via wlroots = wlroots_0_15 in all-packages.nix to make future updates a bit easier. Anyway, I'm fine with both approaches (IMO there are advantages and drawbacks to both but I don't want to write too much about that :D).
nixpkgs-review result:
1 package added:
wlroots_0_15 (init at 0.15.0)

2 packages updated:
fnott qt-video-wlr

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/michael/.cache/nixpkgs-review/rev-ee39a36b58fafe0b6dfc57960e96f40abab6b428/build.nix
3 packages built:
fnott qt-video-wlr wlroots_0_15

Should be good to go then :)

(I think we should take an example from other packages that expect to have multiple versions and set wlroots = wlroots_0_15 in all-packages instead, name the file 0.15.nix as well. See GCC for example.)

@Synthetica9 ok, I misunderstood your previous comment then, so should I change it to this?:
  wlroots = wlroots_0_15;
  wlroots_0_12 = callPackage ../development/libraries/wlroots/0.12.nix {};
  wlroots_0_14 = callPackage ../development/libraries/wlroots/0.14.nix {
    inherit (xorg) xcbutilrenderutil;
  };
  wlroots_0_15 = callPackage ../development/libraries/wlroots/0.15.nix {
    inherit (xorg) xcbutilrenderutil;
  };

@Synthetica9 ok, I misunderstood your previous comment then, so should I change it to this?:

Exactly!

Done:
1 package added:
wayfireApplications-unwrapped.wlroots (init at 0.14.1)

5 packages updated:
fnott qt-video-wlr tinywl (0.14.1 → 0.15.0) waybar wlroots (0.14.1 → 0.15.0)

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/michael/.cache/nixpkgs-review/rev-42cb675c148ecc19c7d44d04b1483f3c6fa999da/build.nix
6 packages built:
fnott qt-video-wlr tinywl waybar wayfireApplications-unwrapped.wlroots wlroots

Ok, let's merge it then :tada:.
There's no hurry (this'll take weeks to land in master anyway) but it seems like we've already resolved all open questions and so we don't block other PRs that depend on this wlroots bump.
I've already opened #151311 to track the status of all reverse dependencies.


t-SNE activation plots

All things involved (scripts, figures, data) with applying t-SNE to tybalt and raw data features.
Python for t-SNE and R for visualization

Thanks @danich1 and @jaclyn-taroni - I believe I addressed your comments in the most recent commits


Custom title ignored on knobs?

I recently got a Stream Deck+ to use as a remote for HASS; thank you for this plugin!
I'm trying to show {{brightness}} on the knob for my living room lights and no matter which variable I use the plugin is showing Entity (generic) for the title. It appears Custom title is ignored entirely.
Steps to reproduce

Leave Title: empty
Choose light as domain
Choose a light entity that supports dimming
Click Use custom title
Put {{brightness}} in for the title value.
Save configuration

Expected results
It shows the brightness value from HASS for the entity. In my case that should be 157 according to the HASS Developer > State dashboard.
Actual results
Title shows Entity (generic) for any custom title value. I've tried both variables and static labels; none appear to work on the knobs.

It does, however, work on the buttons:

Updating to add the variables do work on knobs in the Custom label field. Just not the Use custom title field.

Yep that seems to be a bug...

Has there been any movement on this? I just for a Plus, and am seeing the same issue half a year later.

@clarinetJWD looks like the pre-release works really well now.


Add basic websocket support for GDAX

This PR makes a first step into reading data from the websocket stream for GDAX instead of continually polling their REST APIs. It doesn't feed the websocket reports directly into the system, but rather sets up a couple of objects/arrays that will act as a buffer or cache for the incoming websocket data and then when the exchange level API functions run, they're set to check the websocket cache (or websocket fed live orderbook) before making a REST call. This should initially alleviate REST calls from getTrades and getQuote. At a minimum, should also be able to write a little more processing code and set up a similar cache for getOrder in the near future.

This is great!  It might help people review the changes if they were squashed and rebased onto master with only relevent commit names retained (requires a git push --force to the branch to change the history).

I got an issue testing this change. I could reproduce it like this:

git pull latest zenbot
pull this PR
create/copy in conf.js with API keys for gdax
try to backfill (i tried gdax.ETH-BTC)

It will fail with message that not all keys are filled in.

@Fredrik81, I thought that issues was fixed in 22c569e 17 hours ago.  When did you perform this test?
Backfill works fine for me.

I was reading the gdax docs and found https://docs.gdax.com/#sequence-numbers stating that some messages will be dropped or sent out of order.  They say at https://docs.gdax.com/#the-code-classprettyprintmatchescode-channel that the heartbeat channel should be used to identify and resync when information is lost, using either sequence numbers or trade ids.  I don't know if this is a huge issue if a trade is dropped here and there, but it's perhaps the next thing missing.

same steps of Fredrik81 i get:
(node:4844) DeprecationWarning: new PublicClient() no longer accepts a product ID as the first argument.
(node:4844) DeprecationWarning: getProductTrades() now requires a product ID as the first argument. Attempting to use PublicClient#productID (LTC-EUR) instead
while backfilling

Hello,
Tested same steps again using a new git pull so all the latest merged PR's included.
Give same result as @luponata.
I hope your able to fix it :-)
zenbot$ ./zenbot.sh backfill gdax.ETH-BTC --days=2
node-telegram-bot-api deprecated Automatic enabling of cancellation of promises is deprecated.
In the future, you will have to enable it yourself.
See https://github.com/yagop/node-telegram-bot-api/issues/319. module.js:635:30
(node:6907) DeprecationWarning: new PublicClient() no longer accepts a product ID as the first argument.
(node:6907) DeprecationWarning: getProductTrades() now requires a product ID as the first argument. Attempting to use PublicClient#productID (ETH-BTC) instead.
gdax.ETH-BTC saved 100 trades 2 days left
(node:6907) DeprecationWarning: getProductTrades() now requires a product ID as the first argument. Attempting to use PublicClient#productID (ETH-BTC) instead.
.(node:6907) DeprecationWarning: getProductTrades() now requires a product ID as the first argument. Attempting to use PublicClient#productID (ETH-BTC) instead.
websocket connection to ETH-BTC opened
.(node:6907) DeprecationWarning: getProductTrades() now requires a product ID as the first argument. Attempting to use PublicClient#productID (ETH-BTC) instead.
.(node:6907) DeprecationWarning: getProductTrades() now requires a product ID as the first argument. Attempting to use PublicClient#productID (ETH-BTC) instead.
.(node:6907) DeprecationWarning: getProductTrades() now requires a product ID as the first argument. Attempting to use PublicClient#productID (ETH-BTC) instead.

Anyway i don't know if these tests should be done after successful merge of e9bf0d58c4cc792e8d90a5eec87f6bbc41a5435b

@luponata @Fredrik81 I don't get those warnings.  This PR updates the version of gdax-node depended on in package.json -- have you run npm install to download that updated version?

yes i did :/

Looks like they changed the API last night with https://github.com/coinbase/gdax-node/pull/178

Pinned the dependency to the old API for now with https://github.com/krystophv/zenbot/pull/2

Thanks everyone for the interest and testing. I merged @fuzzyTew's PR pinning the dependency to a tag so the dependency doesn't update with breaking changes unexpectedly in the future. I guess we'll just need to check up on the dependency periodically to see if it's got a new tag (and at that point update it). Hopefully they just start using NPM properly, but that might be a bit much to hope for :/

I've tried to update the code for the development changes in gdax-node at https://github.com/fuzzyTew/zenbot/tree/gdax_websocket_subscribe mostly so I can use the subscribe/unsubscribe change, but it also has changes equivalent to @Frederik81's now.  I haven't really tested it.

It updates/download data super quick. this will be a big improvement when live.

Once this lands, I'll have another PR up shortly that will build out the local orders cache based on the websocket feed so we can avoid making getOrder calls too.

I can confirm that with the last API version change the problem i faced is gone.

now i'm facing another problem (with https://github.com/fuzzyTew/zenbot/tree/gdax_websocket_subscribe)
GDAX API is down! unable to call getBalance, retrying in 10s
{ Error: non-200 status: 429
at statusErr (/root/zenbot/extensions/exchanges/gdax/exchange.js:30:17)
at /root/zenbot/extensions/exchanges/gdax/exchange.js:93:25
at Request._callback (/root/zenbot/node_modules/gdax/lib/clients/public.js:45:7)
at Request.self.callback (/root/zenbot/node_modules/gdax/node_modules/request/request.js:187:22)
at emitTwo (events.js:126:13)
at Request.emit (events.js:214:7)
at Request. (/root/zenbot/node_modules/gdax/node_modules/request/request.js:1044:10)
at emitOne (events.js:116:13)
at Request.emit (events.js:211:7)
at IncomingMessage. (/root/zenbot/node_modules/gdax/node_modules/request/request.js:965:12)
at emitNone (events.js:111:20)
at IncomingMessage.emit (events.js:208:7)
at endReadableNT (_stream_readable.js:1056:12)
at _combinedTickCallback (internal/process/next_tick.js:138:11)
at process._tickCallback (internal/process/next_tick.js:180:9)
code: 'HTTP_STATUS',
body:
{ message: 'Rate limit exceeded. For rate limit information see https://docs.gdax.com/#rate-limits' } }
[ { currency: 'EUR', asset: 'ETH' } ]

@luponata that's clearly a rate limit exceeded error. and not entirely relevant to this PR discussion. if you feel it's an issue with fuzzy's changes, then maybe making an issue on his branch would be appropriate, or perhaps asking around in the Discord. I'd recommend turning down the poll rate.

my fault, was using a copy of conf-sample.js from another repository with too low ms on poll-trades..

This issue was moved to highvelocityspace/zenbot#24

This issue was moved to highvelocityspace/zenbot#54


metaReader

```js`
const metaReader = sharp()
.metadata()
.then(info => {
console.log(info)
})
.catch(err => {
console.log(err)
})

is metaReader fast enough to using it in a high throughput server? is it block thread?
I want to `pipe(metaReader)` a stream , stream is a file uploaded by end user

"Everything remains non-blocking thanks to libuv, no child processes are spawned and Promises/async/await are supported."

http://sharp.pixelplumbing.com/en/stable/#fast

@lovell I want to

Get a file from end user
Check dimension
must be square

larger than 100x100
less than 1000x1000

Generate thumbnail

I want to check dimension in main thread , but generate thumbnail in a worker thread (using rabbitmq)
I see http://sharp.pixelplumbing.com/en/stable/performance/
You have 25.30 Ops/sec , is it 1000/25=40ms blocks thread? If yes I must use worker thread , If no , can I use main thread to generate thumbnail?
What about dimension? how much it block thread?

Please see #1297

Hope this helped, please feel free to re-open with more details if not.


redundancy code optimization

Ⅰ. Describe what this PR did
redundancy code optimization
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #3177 into develop will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #3177      +/-   ##
=============================================
- Coverage      50.38%   50.26%   -0.12%
+ Complexity      3118     3114       -4
=============================================
  Files            594      595       +1
  Lines          19632    19601      -31
  Branches        2441     2394      -47
=============================================
- Hits            9891     9853      -38
+ Misses          8747     8730      -17
- Partials         994     1018      +24

Impacted Files
Coverage Δ
Complexity Δ

...pc/processor/server/AbstractRemotingProcessor.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...rpc/processor/server/ServerOnRequestProcessor.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...pc/processor/server/ServerOnResponseProcessor.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

... and 31 more

add optimize: before the heading

This pr was freezing for a long time. So I will close it and waiting for you next contribution.


gcc 4.8 nightly test fails due to test (AwsConfigTest) compilation warning

Fixes the ASSERT_TRUE/FALSE usage in the test so that gcc4.8 does not fail due to warnings.

Test PASSed.


[doc] move the docker usage to the first section

@pengzhendong will refactor this further according to the English  version.


Get started color polish

@misolori did the changes and I tested them out. I had to revert a fix that moved focus more consistently.

Looks good, thanks!


feat: support traced go routine

What this PR does / why we need it:
support traced go routine
Specified Reivewers:
/assign @liuhaoyang

/approve


basic.py: RuntimeWarning: invalid value encountered in cdouble_scalars

I am getting this error when using Bessel functions with the latest scipy.    I can't find any simple way to debug it.   The inputs to the function look valid.
/usr/local/lib/python3.4/dist-packages/scipy/special/basic.py:428: RuntimeWarning:
invalid value encountered in cdouble_scalars
  s += p*L(v-n + i*2, z)

Unfortunately, without the actual code this is not informative for us to understand the problem. We can at best guess which is not the most productive way to debug.
You might try to record the variables that causes the problem and figuring out which function is emitting this.


Add automatic deployment

Release to npm on new tag via Travis integration
Release new version of docs on push to master
Fix asset-paths in docs-app

I currently don't understand how the es5 transpiling is triggered before npm publish which is made with the travis plugin. Did you forget to do that?

you are right, the whole transpiling step should be set as prepublish-script. i am surprised that this is not the case anyways. I will add it and update the documentation accordingly.

ah, and don't comment with the ci user 😄

sorry about that! 😓 you are right, the whole transpiling step should be set as prepublish-script. i am surprised that this is not the case anyways. I will add it and update the documentation accordingly.

I tested the gh-pages deployment locally without the travis-stuff like this: https://gist.github.com/fspoettel/59b641f3acbd24748c06ce624f54d416 and it works. Not sure if i got the travis- tuff right tho - only a push to master can tell I guess.


SSL Support for Connections

Hello,
As far as I can tell, there doesn't seem to be ssl support for mysql connections. Is this a feature that is planned or is it already there but not in the documentation? SSL support would be very useful for a wide range of users I believe.

Has there been any progress on this? I need to connect to a database via SSL and the codebase I'm working with has been setup to use PHP-AR.


Allow override of isPathRequested() in Parser implementation

It would be great if the visibility of Parser::isPathRequested() can be changed from private to protected so it can be easily overridden.
The reason for this request is i implemented support for wildcard include paths and check them in the mentioned method. For now i have to copy your complete parser implementation to achieve this.

Hi, I've created a branch issue231 with better Parser extensibility. Can you please modify custom parser and test in a suite created for your case?

Updated. @66mm Please have a look.

@66mm Ping

Sorry, was busy over the Weekend.
Looks fine for me. Would be great if it will be merged into master. Thank you!

pushed to develop. Will be pushed to master and released in a couple of days.

Published https://github.com/neomerx/json-api/releases/tag/v3.0.3
Thanks for the support :star2:


Visual update to the result table (File Name column)

Remove File Name column
Combine PEM Database and Display Chant (and File Name) together
File Name redirects to GABCtoMEI GitHub file
For chants that has 2 PEM database link (spans two pages)

...

Refresh Database should be executed whenever page is reloaded to improve user experience and reduce confusion

A single link just for the page where the chant starts will be enough! Many thanks

@martha-thomae Here's what I just marked up for the last column. There can be another column for Syllable that contains the ornamental figures for #13

Hi @notkaramel! This was helpful for our discussion today, thank you!

In "Search Panel" change "search for chant with the following notation types" to "search for chant with the following music scripts"


Use Bluebird promises by default in browser

I apologize if this was answered maybe 100 times before, but I wasn't able to find a good answer for this.
I know how to do it in Node environment (global.Promise = ...), but how to do it for the browser?
What I want to achieve is to not import (`import * as Promise from 'bluebird') bluebird in every file, but instead do it once.

window.Promise = require('bluebird');

That won't work for async functions without a babel transform though.


Does it makes sense to get filter stats when there is no overviews metadata?

So when metadata is empty in here: https://github.com/CartoDB/Windshaft-cartodb/blob/5eda4888edf665eeb060647ade2c734f55cbf914/lib/cartodb/models/mapconfig/adapter/mapconfig-overviews-adapter.js#L28-L31
Does it make sense to retrieve information about the filters?

I think we can safely avoid both fetching the filters and the stats when there's no overviews and just avoid producing the query_rewrite_data. We only need that for the overviews query rewriter, which won't be used if there's no query_rewrite_data.


update to new atom version, '.editor' deprecated

changed the syntax according to the documentation for version 0.176 https://atom.io/docs/latest/advanced/keymaps
Remember to

[ ] merge this PR
[ ] update release (create tag, whatever...)

Thanks for the PR, I will re-release shortly


Support for Object Type UDMO - Data model

Support for the serialisation and de-serialisation of the Data Modeller (Tx SD11) object types UMDO - Data Model,  UENO - Entity Type presently missing.  Whilst perhaps not the most commonly used objects, relatively simply objects to implement.

Happy to implement this by the way..

cool, never tried SD11 before 😄
Perhaps open 2 issues, one for UMDO and one for UENO? Alternatively change the title of this issue

Name of the TADIR object type is UDMO instead of UMDO?

Correct - Object type is UDMO.

UDMO is undergoing testing. Support for the data model, language dependent descriptions and language dependent long texts. Shouldn't be too long now.

merged in https://github.com/larshp/abapGit/pull/1966 so I guess this can be closed


Implement multiplication and division

Besides addition and subtraction, implement other arithmetic operations such as multiplication and division to provide more flexibility when working with Money objects. Ensure that these operations handle potential edge cases and follow standard financial practices. For instance, when dividing money, you may want to deal with remainders properly.

Multiplication is now implemented. Only division remains TODO.


GUI displayname

(Required) What is your Quests version / build number (do not say "latest")?
3.0.0
(Required) Please describe the problem and how to replicate it. Any console errors?
/
(Optional) Can you provide an example quest from quests.yml using Pastebin.com?
/
I just wanna request a feature in the messages file where we can set the color for the displayname of the quest GUI. ;)

Most strings are already configurable. Could you post a screenshot of the one you're referring to?

I am talking about this purple title. It'd be nice if you could choose your own color code to match your server's design ;).
https://img.christophe6.be/9pAbJ.png

If you're talking about "Quests | Hagrid", you might able to change that under the questNPCListTitle string.
Otherwise, I'll have to look into changing the code here
https://github.com/FlyingPikachu/Quests/blob/e88d7159fe5759f81ac20ec96c3912a50c8826f0/src/main/java/me/blackvein/quests/Quester.java#L2565

Yes I am talking about the second one with the dark purple


Quartz feature does not work

Description
There is a compilation error when compiling apps that has added the quartz feature:
Unable to load class 'org.quartz.JobExecutionContext'
Related: https://github.com/grails-plugins/grails-quartz/issues/107#issuecomment-575951471
Adding:
implementation("org.quartz-scheduler:quartz:2.3.2") {
    exclude group: 'slf4j-api', module: 'c3p0'
}

will make the quartz plugin work.
This is because the grails-quartz plugin does not put the org.quartz-scheduler:quartz on the compileClasspath but only on the runtimeClasspath of grails apps.
./gradlew dI --dependency org.quartz-scheduler:quartz --configuration compileClasspath
Starting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details

> Task :dependencyInsight
No dependencies matching given input were found in configuration ':compileClasspath'

./gradlew dI --dependency org.quartz-scheduler:quartz --configuration runtimeClasspath

> Task :dependencyInsight
org.quartz-scheduler:quartz:2.3.2 (selected by rule)
  Variant runtime:
    | Attribute Name                 | Provided     | Requested    |
    |--------------------------------|--------------|--------------|
    | org.gradle.status              | release      |              |
    | org.gradle.category            | library      | library      |
    | org.gradle.libraryelements     | jar          | jar          |
    | org.gradle.usage               | java-runtime | java-runtime |
    | org.gradle.dependency.bundling |              | external     |
    | org.gradle.jvm.environment     |              | standard-jvm |
    | org.gradle.jvm.version         |              | 11           |

org.quartz-scheduler:quartz:2.2.3 -> 2.3.2
\--- org.grails.plugins:quartz:2.0.13
     \--- runtimeClasspath

Fixed by grails/grails-quartz#125


Libzip missing from dense-flow

This is same issue as https://github.com/yjxiong/temporal-segment-networks/issues/237
However, I am not sure how I would be able to get the docker build AND use the denseflow lib provided.
Shortened error below
-- Found CUDA: /usr/local/cuda-8.0 (found suitable exact version "8.0")
-- Could NOT find LIBZIP (missing:  LIBZIP_LIBRARY)
-- Boost version: 1.58.0
-- Found the following Boost libraries:
--   python
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
LIBZIP_LIBRARY
    linked by target "denseflow" in directory /home/ubuntu/anet2016-cuhk/lib/dense_flow
    linked by target "extract_cpu" in directory /home/ubuntu/anet2016-cuhk/lib/dense_flow
    linked by target "extract_warp_gpu" in directory /home/ubuntu/anet2016-cuhk/lib/dense_flow
    linked by target "extract_gpu" in directory /home/ubuntu/anet2016-cuhk/lib/dense_flow

-- Configuring incomplete, errors occurred!
See also "/home/ubuntu/anet2016-cuhk/lib/dense_flow/build/CMakeFiles/CMakeOutput.log".
See also "/home/ubuntu/anet2016-cuhk/lib/dense_flow/build/CMakeFiles/CMakeError.log".
make: *** No targets specified and no makefile found.  Stop.
Failed to build Dense Flow. Please check the logs above.

I also tried using @yjxiong solution from https://github.com/yjxiong/temporal-segment-networks/issues/62 to install libzip, but its already installed
Reading package lists... Done
Building dependency tree
Reading state information... Done
libzip-dev is already the newest version (1.0.1-0ubuntu1).


Unable to install locusio

Hello,
I tried to install locustio via pip as follows:
pip install locustio
Then I ran into the following issue:
copying gevent/wsgi.py -> build/lib.macosx-10.10-x86_64-3.4/gevent

running build_ext

Traceback (most recent call last):

  File "<string>", line 1, in <module>

  File "/private/var/folders/2k/hb_2nnks2g36msntyvbmqpwr0000gn/T/pip-build-eb4393nv/gevent/setup.py", line 317, in <module>

    run_setup(ext_modules)

  File "/private/var/folders/2k/hb_2nnks2g36msntyvbmqpwr0000gn/T/pip-build-eb4393nv/gevent/setup.py", line 312, in run_setup

    "Development Status :: 4 - Beta"])

  File "/Users/Pac/.pyenv/versions/3.4.3/lib/python3.4/distutils/core.py", line 148, in setup

    dist.run_commands()

  File "/Users/Pac/.pyenv/versions/3.4.3/lib/python3.4/distutils/dist.py", line 955, in run_commands

    self.run_command(cmd)

  File "/Users/Pac/.pyenv/versions/3.4.3/lib/python3.4/distutils/dist.py", line 974, in run_command

    cmd_obj.run()

  File "/Users/Pac/.pyenv/versions/3.4.3/lib/python3.4/site-packages/setuptools/command/install.py", line 61, in run

    return orig.install.run(self)

  File "/Users/Pac/.pyenv/versions/3.4.3/lib/python3.4/distutils/command/install.py", line 539, in run

    self.run_command('build')

  File "/Users/Pac/.pyenv/versions/3.4.3/lib/python3.4/distutils/cmd.py", line 313, in run_command

    self.distribution.run_command(command)

  File "/Users/Pac/.pyenv/versions/3.4.3/lib/python3.4/distutils/dist.py", line 974, in run_command

    cmd_obj.run()

  File "/Users/Pac/.pyenv/versions/3.4.3/lib/python3.4/distutils/command/build.py", line 126, in run

    self.run_command(cmd_name)

  File "/Users/Pac/.pyenv/versions/3.4.3/lib/python3.4/distutils/cmd.py", line 313, in run_command

    self.distribution.run_command(command)

  File "/Users/Pac/.pyenv/versions/3.4.3/lib/python3.4/distutils/dist.py", line 974, in run_command

    cmd_obj.run()

  File "/Users/Pac/.pyenv/versions/3.4.3/lib/python3.4/distutils/command/build_ext.py", line 339, in run

    self.build_extensions()

  File "/Users/Pac/.pyenv/versions/3.4.3/lib/python3.4/distutils/command/build_ext.py", line 448, in build_extensions

    self.build_extension(ext)

  File "/private/var/folders/2k/hb_2nnks2g36msntyvbmqpwr0000gn/T/pip-build-eb4393nv/gevent/setup.py", line 234, in build_extension

    self.gevent_prepare(ext)

  File "/private/var/folders/2k/hb_2nnks2g36msntyvbmqpwr0000gn/T/pip-build-eb4393nv/gevent/setup.py", line 231, in gevent_prepare

    configure(self, ext)

  File "/private/var/folders/2k/hb_2nnks2g36msntyvbmqpwr0000gn/T/pip-build-eb4393nv/gevent/setup.py", line 139, in configure_libev

    make_universal_header('config.h', 'SIZEOF_LONG', 'SIZEOF_SIZE_T', 'SIZEOF_TIME_T')

  File "/private/var/folders/2k/hb_2nnks2g36msntyvbmqpwr0000gn/T/pip-build-eb4393nv/gevent/setup.py", line 111, in make_universal_header

    print >>f, line

TypeError: unsupported operand type(s) for >>: 'builtin_function_or_method' and '_io.TextIOWrapper'

Running '/bin/sh /private/var/folders/2k/hb_2nnks2g36msntyvbmqpwr0000gn/T/pip-build-eb4393nv/gevent/libev/configure > configure-output.txt' in /private/var/folders/2k/hb_2nnks2g36msntyvbmqpwr0000gn/T/pip-build-eb4393nv/gevent/build/temp.macosx-10.10-x86_64-3.4/libev

----------------------------------------
Command "/Users/Pac/.pyenv/versions/3.4.3/bin/python3.4 -c "import setuptools, tokenize;__file__='/private/var/folders/2k/hb_2nnks2g36msntyvbmqpwr0000gn/T/pip-build-eb4393nv/gevent/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /var/folders/2k/hb_2nnks2g36msntyvbmqpwr0000gn/T/pip-lnmc3qyc-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /private/var/folders/2k/hb_2nnks2g36msntyvbmqpwr0000gn/T/pip-build-eb4393nv/gevent

What could be the reason? I'm running python 3.4.3.
Thanks.

My operating system is Mac OS X 10.10.5.

@sivabudh
Locust is not currently compatible with Python 3.x.
try again with Python 2.7.

be aware there is an open issue to add support for Python3 #279

Thanks both @cgoldberg and @nryoung. Sorry I didn't read your doc carefully!


latest npm release is broken

there's a duplicate react native dependency and packager crashes.
i installed it as a git dependency and it works fine, a new release is required.

Also need a new release that has these changes...
https://github.com/JackDanielsAndCode/react-native-multi-slider/pull/18

Updated npm, sorry for the delay!


mailgun: Add basic mailinglist support

Awesome. If you're happy with this, I'm happy with this.

Oh hey, could you please push an update to README with usage instructions? Seeing as that's our only source of documentation at the moment. Then I'll tag a new release.


Editor on git index is no longer read-only

Edit a file tracked by Git
Stage the file
In the SCM viewlet, click the file in the "staged" section to open an editor that says (Index)
Type in the file
In 1.24.1, I can't edit it because it's a read-only editor
In 1.25, I can type in the editor, but changes aren't actually written anywhere. If I switch away from the file and switch back, they are gone

@bpasero thanks for the fix, I will review it now.


Add 'sdk' argument to '.xctool-args'

Current coverage is 94.14%

Merging #17 into master will not affect coverage as of 9b0ca0d

@@            master     #17   diff @@
======================================
  Files           59      59
  Stmts         1658    1658
  Branches         0       0
  Methods          0       0
======================================
  Hit           1561    1561
  Partial          0       0
  Missed          97      97

Review entire Coverage Diff as of 9b0ca0d

Powered by Codecov. Updated on successful CI builds.


Update cmake to only use dirent header on windows

So checking for the include, breaks the test on mingw, because mingw has the header but is not feature complete. Instead, I updated to only use the header on windows, otherwise use the system.
I also, updated it to only install the header on windows. So on linux it doesn't install anything since its not necessary. However, to make it successfully install with cget, I added a fake install target that does nothing.

Thanks!


[T4A3][T09-B1]Zhang Yunxuan

Ready for review

Accepting this PR without a review because another of your PRs for this tutorial was reviewed in detail.


Fix postgres in tutorials

Closes #364
Also, Laravel/PHP tutorial was changed to use Postgres instead of MySQL because Postgres was a bit easier to work with.

Great job. Thanks!
Any specific issues with mysql? I'm going to add mysql into examples too because it's another thing a lot of people are interested in.

I just tried to initialize the database volume the same way we did with PostgreSQL, but I could not get it to work, I was probably missing something.


Adding goal to last quiz assignment

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


signIn completion handler - fetchAuthSession() is not available

Describe the bug
I am using signIn and modified it with completion handler. Use case is to call REST api with cognito-access token in header to invoke insertion into DynamoDB as a user logs in for first time. Gist of the flow is: Swift -> Amplify-> signIn -> userNotFound error -> signUp -> signIn -> after signIn completion, call fetchAuthSession -> get cognito access token -> amplify -> REST api -> APIGateway -> Lambda -> insert metadata into DynamoDB.
After signIn(), in its completion handler, amplify.Auth.fetchSession() is gives error:
Fetch auth session failed with error - AuthError: There is no user signed in to retreive cognito tokens
Recovery suggestion: Call Auth.signIn to sign in a user and then call Auth.fetchSession

If I keep a sleep of 60s, it works. The delay sometime works for 30s and very few times for 20s.
This is not mentioned anywhere. What can be done?
Using the signature:
private func signIn(username: String, password: String, firstAttempt: Bool, completion: @escaping () -> Void) { .. }
where completion() is called at the end of function. Completion() block has a call to fetchAuthSession() when signIn succeeds.
private func signIn(username: String, password: String,
                    firstAttempt: Bool,
                    completion: @escaping () -> Void) {
    print("signIn(\(username), \(password), \(firstAttempt))")
    Amplify.Auth.signIn(username: username, password: password) { result in
        do {...} catch {...}
        print("calling completion() in signIn()" + String(firstAttempt))
        completion()
    }
}

Now, if this is unexplained and expected behaviour:

Please put up an explaination on this in doc.
Suggest what can be done to insert metadata after first signIn. This metadata require cognito tokens to pass them as header in downstream api calls.

Steps To Reproduce
Steps to reproduce the behavior:
1. Define a completion handler for signIn()
2. Call fetchAuthSession() in completion handler. fetchAuthSession() is called when signIn succeeds.
3. /* sleep(60) */ //to make it work
4. See error : Fetch auth session failed with error - AuthError: There is no user signed in to retreive cognito tokens. Recovery suggestion: Call Auth.signIn to sign in a user and then call Auth.fetchSession

Expected behavior
When signIn completes, fetchAuthSession() should be able to return cognito access/id token for enabling calls to downstream apis.
Amplify Framework Version
1.28.2-unstable.2
Amplify Categories
Auth
Dependency manager
Cocoapods
Swift version
5.0
CLI version
9.2.1
Xcode version
Version 14.1 (14B47b)
Relevant log output
<details>
<summary>Log Messages</summary>

Fetch auth session failed with error - AuthError: There is no user signed in to retreive cognito tokens
Recovery suggestion: Call Auth.signIn to sign in a user and then call Auth.fetchSession

```
Is this a regression?
No
Regression additional context
No response
Device
iPhone11 - Real Device (ModelNo: MHDD3HN/A)
iOS Version
iOS 16.1
Specific to simulators
No response
Additional context
No response

Based on information provided via the other ticket, the reason Auth.fetchAuthSession is returning "no user signed in" is because it's being called after Auth.signIn, but before Auth.confirmSignIn.
Note for amplify-swift team: More information is available in the following SIM: V780829163

Information was helpful, thanks.
I checked on it. Calling Auth.fetchSession() after Auth.confirmSignIn() produces the result fine and fetching of Cognito token succeeds. I will move Auth.fetchSession() from completion-handler of signIn to completion handler of Auth.confirmSignIn() under its success case.
As I see it, confirmSignIn() is automatically invoked by the case "confirmSignInWithCustomChallenge" in Auth.signIn().
Flow: Swift -> Amplify-> signIn -> userNotFound error -> signUp -> signIn -> case "confirmSignInWithCustomChallenge" and prompt user for custom challenge answer -> Auth.confirmSignIn ->  Auth.fetchSession -> get cognito access token -> amplify -> REST api -> APIGateway -> Lambda -> insert metadata into DynamoDB
I am planning to move to v2 soon. For that, what is the way to represent this Flow with async/await?
A sample fragment in doc can clarify and reason the behaviour better for adoption in an involved scenario.

Glad that it worked for you, the flow is same in v2 as well. You need to call Auth.confirmSignIn if the Auth.signIn api returned confirmSignInWithCustomChallenge as the next step. Auth.fetchSession will give you authenticated credentials only after the signIn process is complete.
You can find the documentation on v2 apis here - https://docs.amplify.aws/lib/auth/signin/q/platform/ios/

Thanks. This ticket can be closed now.


L.SVG render has a problem

The element of path will lose interactive sometimes when move the map  in firefox

You can try in this  demo: http://leafletjs.com/examples/quick-start/

Hi, I'm closing this issue because the quality is not good enough. I suggest reading "How To Ask Questions The Smart Way" and "How to Report Bugs Effectively" so you can make good bug reports.

My English is poor! But the problem I say is really exists!

I don't know what is the problem. I don't know how I can reproduce the problem on my computer. I do not know if the problem happens on all web browsers.
I do not know if the problem happens when panning the map with the mouse, or with a touchscreen, or with the keyboard, or with all. I don't know if the problem happens when doing one thing at once, or several things at once.
We do not have enough information to know what the problem is.

Huh, I was trying this example out in Firefox, and just about to say this works as expected, but then realized there is actually a problem here.
After panning the map, sometimes part of the circle and polygon do not catch click events, and the click is passed through to the map itself.
You can see this in action by hovering the mouse pointer over the polygon or circle. Normally, the pointer should then be the cursor:pointer shape, indicating you can click the vector item, Sometimes, however, the pointer changes to the grab hand (used for panning the map), even though you're still clearly over the vector item.
Looks like a browser issue, possibly some weird interaction with what we're doing in Leaflet.
Tested on Firefox 55.0.2 (64-bit) on Win10.

I also stumbled across this problem. I am working with Ubuntu 16.04. When I pan a polygon out of the visible area in browser Firefox 55.0.2 (64-bit) and pan it immediately back, the click-able area of the polygon is no longer OK. If I move the polygon out of the top area of the browser, the top area of the polygon is not click-able after moving it back. If I move the polygon out of the bottom area of the browser, the bottom area of the polygon is not click-able after moving it back.
If I release the mouse in between, all is OK. Also in Chrome everything is OK.

My Firefox installation was a little old (54.0 32-bit).  I was not able to reproduce this at that version, but after updating to 56.0 (32-bit) I was able to reproduce this behavior.
Possibly an issue introduced at Firefox 55?

I confirm.

Firefox 55.0.2 (64-bit) for Linux Mint.

I have a similar problem, and do not yet know whether the root might be the same.
I have a SVG layer, with a g element and a number of circles in it. Now, when I pan the g still reflects the coordinats of the positioned circles whilst the svg element pans "apart", which invisibles the circles beyond the new position of the svg, but still within the remaingly correct positioned g.
Still investigating. But surely the original click event on the circle is also gone.
PS. Who is going to reopen this issue, please?

I'm currently experiencing this issue. Maybe this is a no-brainer, but for anyone who's looking for a workaround and hasn't found one, you can use a Canvas renderer.

@nrenner did you open an issue on Firefox's bugzilla already with your nice Leaflet-less tests?
(if you didn't, I could do it; just avoiding to create a double one)

No, I haven't yet. Go for it.
I had a hard time searching Bugzilla for already existing bugs, closest I could find by searching the SVG Component page, but not sure if related:

1424758 - SVG rendering of transformed group members leads to eventable area being offset from visual rendering of elements
1416178 - Inaccurate mouseover regions for elements with coordinates in unit interval when SVG child of transformed DIV

Mhhh… they might be related but not exactly "our" problem (both seems to be precision-related, this one seems not)… so I guess I'll file a new one:
Bugzilla 1486952

@nrenner @lapo-luchini nice work, both of you! Creating a minimal reproduction as well as submitting the Firefox bug is greatly appreciated!

This is now fixed in current Firefox 65.


[README] Need to add Community Forum

Description

README.md is the first file one should read when starting a new project. Our community launched Discussion forum for help seekers; needs to publish it officially on README.md for convenience.
Screenshots

Current behaviour:

Desired behaviour:

Note:
Need to add only last line for Community Forum
Environment:

OS: any [e.g. Ubuntu]
Browser: any [e.g. Chrome, Safari]
Version: any [e.g. 22]
Device: any [e.g. laptop, iPhone 8]

Reference:

Take reference to this pull request

hey@ amino19 can I have this issue ?

@The-Loony-Coder : It's already fixed here.
Just hop to our slack, for more info. :slightly_smiling_face:


fix the balance quantity increase problem

Thanks for great team !
When I try to use the ERC721PsiTrackBalance and write down the test, find some confused from balanceOf always be zero,
for this patch, changed [from] to [to] to make the balance increase correctly.
Expect
call _safeMint(to, 1), to account balanceOf should be 1
Actual
balanceOf is 0
Test
Traces:
  [113270] WAGMITest::testBalanceOf()
    ├─ [92174] WAGMIPsi::multiMintTo(0x00a329c0648769a73afac7f9381e08fb43dbea72, 1)
    │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: 0x00a329c0648769a73afac7f9381e08fb43dbea72, tokenId: 0)
    │   └─ ← ()
    ├─ [2656] WAGMIPsi::balanceOf(0x00a329c0648769a73afac7f9381e08fb43dbea72) [staticcall]
    │   └─ ← 0
    ├─ emit log(: "Error: a == b not satisfied [uint]")
    ├─ emit log_named_uint(key: "  Expected", val: 1)
    ├─ emit log_named_uint(key: "    Actual", val: 0)
    ├─ [0] VM::store(VM: [0x7109709ecfa91a80626ff3989d68f67f5b1dd12d], 0x6661696c65640000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000001)
    │   └─ ← ()
    └─ ← ()

Awesome! That is the experimental code.
I am thinking of replacing it with this extension. @madeinfree  Any idea?
https://github.com/estarriolvetch/ERC721Psi/pull/2


cannot build helloworld example in C++, error about ssl unresolved, with VS2015

1>grpc.lib(ssl_transport_security.obj) : error LNK2001: unresolved external symbol _SSL_CTX_set_options
1>grpc.lib(ssl_transport_security.obj) : error LNK2001: unresolved external symbol _SSL_CTX_set_tlsext_servername_arg
1>grpc.lib(ssl_transport_security.obj) : error LNK2001: unresolved external symbol _BIO_get_mem_data
1>grpc.lib(ssl_transport_security.obj) : error LNK2001: unresolved external symbol _BIO_should_retry
1>grpc.lib(ssl_transport_security.obj) : error LNK2001: unresolved external symbol _SSL_CTX_set_tlsext_servername_callback
1>grpc.lib(ssl_transport_security.obj) : error LNK2001: unresolved external symbol _SSL_CTX_add_extra_chain_cert
1>grpc.lib(ssl_transport_security.obj) : error LNK2001: unresolved external symbol _SSL_CTX_set_tmp_ecdh
1>grpc.lib(ssl_transport_security.obj) : error LNK2001: unresolved external symbol _SSL_set_tlsext_host_name
1>grpc.lib(ssl_transport_security.obj) : error LNK2001: unresolved external symbol _SSL_is_init_finished
1>grpc.lib(ssl_transport_security.obj) : error LNK2001: unresolved external symbol _BIO_pending
1>grpc.lib(ssl_transport_security.obj) : error LNK2001: unresolved external symbol _OpenSSL_add_all_algorithms

So you're trying to build without having previously compiled either OpenSSL or BoringSSL and put the libraries and headers in a path where the compiler/linker can find them. That's basically what these errors are saying. You can solve this (and then be stuck with the next build problem, then the next, then the next...) by making sure your build environment can locate the OpenSSL libraries (static .libs appears to be the preferred way) and headers.
But...
grpc is so difficult to build on Windows that someone has created a repo specifically to ease the building process: https://github.com/plasticbox/grpc-windows
It worked for me; I highly recommend you check out the grpc-windows repo. I am not optimistic that efforts in upstream grpc will yield anywhere near as easy of a build on Windows in the near future.

@allquixotic
Thanks for your reply.
The problem has been solved. Just change STATIC to DYNAMIC link to openssl. The helloworld example works well!

I have same issue. Compiling on windows.
Compiled gprc 1.4.0 (including boringssl) with CMakeList
Now, trying compile helloworld, but CmakeList compilation fails due to various issues.
So created solution manually, found correct includes and libraries. However getting above errors.
@cpzhang, could you advise how to fix it? Where should I change the link from static to dynamic?


Remove deprecated AWS Mobile Hub service

This PR will remove the, now deprecated, AWS Mobile Hub service from the Boto3 SDK. This service will no longer be accessible in all new AWS SDKs starting today, July 22nd, 2024.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.06%. Comparing base (b4a86ed) to head (c68aa1a).
Report is 62 commits behind head on develop.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3226      +/-   ##
===========================================
- Coverage    93.14%   93.06%   -0.09%
===========================================
  Files           66       66
  Lines        14248    14252       +4
===========================================
- Hits         13272    13263       -9
- Misses         976      989      +13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added undocumented CLI Argument

Thanks for this amazing project!!!
I added info to the help screens about the undocumented --open=false argument.
Helped me with some automation 👍

Thanks for the merge 😸


Update passwords.php

補上一個項目的翻譯
(the original one is simplified chinese, translated to traditional chinese)

:+1:

thanks and I updated the master branch


Update field to match argo Workflow spec

The example did not work as-is, because the spec field is apiVersion rather than api (ref: https://argo-workflows.readthedocs.io/en/stable/fields/#workflowspec).

Reference Issues or PRs

What does this implement/fix?
Put a x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[X] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[X] Did you test the pull request locally?
[ ] Did you add new tests?

Documentation

Access-centered content checklist
Text styling

[ ] The content is written with plain language (where relevant).
[ ] If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
[ ] All links describe where they link to (for example, check the Nebari website).
[ ] This content adheres to the Nebari style guides.

Non-text content

[ ] All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
[ ] If there are emojis, there are not more than three in a row.
[ ] Don't use flashing GIFs or videos.
[ ] If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Thanks, @maxrjones, for catching it!


Exception: Ctypes_ffi_stubs.CallToExpiredClosure

Hi, I'm currently playing with a proof-of-concept Gtk4 bindings and I've run into this issue CallToExpiredClosure exception being thrown.
It happens when I let window open a rather long time, and here is the closure
action_save#activate <~> (fun _ ->
     Out_channel.(
         if not readonly then
            with_open_bin path (fun ch -> output_string ch buffer#text)
     );
     self#application#quit ()
);

Where <~> is just a shortcut for signal_connect and (fun _ ...) is the callback. Is that something expected?
Now that I think of it probably yes, since buffer is local to the method were this is called.
Is that the case?

Is that something expected?

It's expected (though not guaranteed) if the closure passed to C is garbage collected before it's called from the C side.  It should be possible to avoid the problem by keeping a reference of some kind to the closure in OCaml, but the details will depend on your library or application.


Convert to ES6, drop support node v4.

Does this mean that we can/want to use things like classes (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes)?

"JavaScript classes are introduced in ECMAScript 6 and are syntactical sugar over JavaScript's existing prototype-based inheritance"
ES6 === ECMAScript 6
So we need to support it and convert to classes.

I was aware of ES6 == ECMAScript 6. I was just wondering if we'd like to use that feature, which makes the whole thing more understandable for a (Node.)JS noob like me :stuck_out_tongue:

Ye we will.


fix client secret keyref value key in readme

Description
Just an update to the readme to document the correct key names for existing clientsecret values from pre-existing secret

I have read and understood the CLA and hereby agree to its terms by making this Pull Request Comment.

Thanks for your fix @psych0d0g!  🦦
This also needs fixing in https://github.com/otterize/docs/blob/main/docs/reference/network-mapper/helm-chart.mdx, let me know if you'd like to take care of that or I will 🙏

@psych0d0g I noticed the failing E2E CI tests on your PR, they seem related to this issue https://github.com/dorny/test-reporter/issues/149.
I'm on it.

@psych0d0g could you please pull the latest https://github.com/otterize/helm-charts main into your fork? Hopefully this commit: https://github.com/otterize/helm-charts/commit/9fc35a81d9ba1cb22cc8e4bf5d87b5e58b2436d9 solves the CI issues

I see it's still failing. I'll merge your PR despite the failures (it's only failing to report the test results, the tests themselves are fine), and will follow this up at a later time.


Can I connect multi peripherals?

Yes

Yes

How?

Take a Peripheral and .establishConnection() to it 🎉

Take a Peripheral and .establishConnection() to it 🎉

Thanks a lot

I hope this helps you.
If you need further assistance feel free to clearly state your needs.
Best Regards


Update sensitive-information-type-entity-definitions.md

@chrfox  updates to EU Driver License SITs

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks


Review/Fix console warnings when running locally (metro)

Almost all metro log warnings have been fixed, but there is one caused by the onboarding screens changing too quickly which can only be fixed by changing the navigation flow or disabling animation


[.xcodeproj] Share SwiftXCTest scheme

What's in this pull request?
Currently, running the Swift build script /path/to/swift/utils/build-script --xctest on OS X fails because it attempts to use the Linux-only build_script.py.
We should make it possible for swift-corelibs-xctest to be built via the --xctest switch on OS X, which means making the project buildable via the command line.
To make the project buildable via the command line, share the "SwiftXCTest" scheme. This allows the project to be built via:
$ xcodebuild -project SwiftXCTest.xcodeproj -scheme SwiftXCTest

Why merge this pull request?
After merging these changes and #46, I plan on allowing swift-corelibs-xctest to be built and tested via the Swift build script. This could be accomplished via the following changes to apple/swift:
diff --git a/utils/build-script-impl b/utils/build-script-impl
index eebeef7..7b176f5 100755
--- a/utils/build-script-impl
+++ b/utils/build-script-impl
@@ -1797,11 +1797,18 @@ for deployment_target in "${HOST_TARGET}" "${CROSS_TOOLS_DEPLOYMENT_TARGETS[@]}"
                 continue
                 ;;
             xctest)
-                SWIFTC_BIN="$(build_directory_bin ${deployment_target} swift)/swiftc"
-                SWIFT_BUILD_PATH="$(build_directory ${deployment_target} swift)"
-                set -x
-                "${XCTEST_SOURCE_DIR}"/build_script.py --swiftc="${SWIFTC_BIN}" --build-dir="${build_dir}" --swift-build-dir="${SWIFT_BUILD_PATH}"
-                { set +x; } 2>/dev/null
+                if [[ "$(uname -s)" == "Darwin" ]] ; then
+                    set -x
+                    # FIXME: When built on Darwin, the '$build_dir' is ignored.
+                    xcodebuild -project "${XCTEST_SOURCE_DIR}"/XCTest.xcodeproj -scheme SwiftXCTest
+                    { set +x; } 2>/dev/null
+                else
+                    SWIFTC_BIN="$(build_directory_bin ${deployment_target} swift)/swiftc"
+                    SWIFT_BUILD_PATH="$(build_directory ${deployment_target} swift)"
+                    set -x
+                    "${XCTEST_SOURCE_DIR}"/build_script.py --swiftc="${SWIFTC_BIN}" --build-dir="${build_dir}" --swift-build-dir="${SWIFT_BUILD_PATH}"
+                    { set +x; } 2>/dev/null
+                fi

                 # XCTest builds itself and doesn't rely on cmake
                 continue
@@ -2021,7 +2028,21 @@ for deployment_target in "${STDLIB_DEPLOYMENT_TARGETS[@]}"; do
                 if [[ "${SKIP_TEST_XCTEST}" ]]; then
                     continue
                 fi
-                # FIXME: We don't test xctest, yet...
+                echo "--- Running tests for ${product} ---"
+                if [[ "$(uname -s)" == "Darwin" ]] ; then
+                    set -x
+                    xcodebuild -project "${XCTEST_SOURCE_DIR}"/XCTest.xcodeproj -scheme SwiftXCTestFunctionalTests
+                    { set +x; } 2>/dev/null
+                else
+                    SWIFTC_BIN="$(build_directory_bin ${deployment_target} swift)/swiftc"
+                    SWIFT_BUILD_PATH="$(build_directory ${deployment_target} swift)"
+                    set -x
+                    # FIXME: This re-builds swift-corelibs-xctest. Instead, 'build_script.py' should take
+                    # a top-level 'test' command that only tests an already built XCTest.
+                    "${XCTEST_SOURCE_DIR}"/build_script.py --swiftc="${SWIFTC_BIN}" --build-dir="${build_dir}" --swift-build-dir="${SWIFT_BUILD_PATH}" --test
+                    { set +x; } 2>/dev/null
+                fi
+                echo "--- Finished tests for ${product} ---"
                 continue
                 ;;
             foundation)

We haven't traditionally been quick to notice when swift-corelibs-xctest is broken; the failures introduced by #33 and #44 took several days to even discover. Adding swift-corelibs-xctest to the Swift test suite will allow us to discover failures quicker.
What downsides are there to merging this pull request?
We probably want a shared scheme in any case, but one could argue that adding swift-corelibs-xctest tests to the Swift build script is premature. After all, the changes I suggest above already have two FIXMEs in them. Still, I think this is forward progress--the FIXMEs can be addressed in turn.

LGTM, as far as the contents of this PR itself are concerned. I'm not very familiar with the overall build script and can't really speak to the other proposed changes. Thanks a lot for taking on all this infrastructure effort @modocache!

Thanks for the review! I'm sure my proposed changes to the build script will undergo a bit of revision when I submit the pull request to apple/swift, but I think we'll need the SwiftXCTest scheme exposed either way.
Now that I think about it, with regards to the first FIXME above: I wonder if the directory where built products are placed can be specified using an environment variable when invoking xcodebuild? That is, something like the following: BUILT_PRODUCTS_DIR=/some/path xcodebuild -project XCTest.xcodeproj -scheme SwiftXCTest?


Remove dependency on dwave-tabu

The dwave.system.testing module requires dwave-tabu, see https://github.com/dwavesystems/dwave-system/blob/082c95b2d48c481a7dcf9d72d16a118a06735c68/dwave/system/testing.py#L20
This is probably an over-large dependency for a testing module. We should consider other options. To throw out an idea:

We could use dimod's SimulatedAnnealingSampler as a fallback when dwave-tabu is not installed. Or even the RandomSampler from dimod.

See also #282

One downside to dimod.SimulatedAnealingSampler is that is is tentatively scheduled for deprecation, see https://github.com/dwavesystems/dimod/issues/298.

On closer inspection, I'm not sure MockLeapHybridSolver should live in dwave.system.testing. It's not a dimod.Sampler, but rather a dwave.cloud.Solver.
If this class is a one-off for use in the unitttest, I would just include it there. If we want to make a mock hybrid solver accessible across Ocean, probably a better place to include it would be dwave.cloud.testing.

@randomir, excellent point.

I used tabu because of its timeout parameter thinking that some use cases might benefit from having the ability to play with longer/shorter runs. Don't believe I've used that until now though.

I am still in favor of migrating this to the cloud client. In terms of which solver it uses on the backend, I think it should be dimod's RandomSampler. Though since one can implement a random sampler with SampleSet.from_samples_bqm(np.random.randint(low=0, high=2, size=(num_samples, len(bqm)), bqm) I am not sure that the cloud client needs to use dimod's if we want to avoid that dependency.
@randomir also pointed out off-line that we should give the user the ability to use another dimod sampler in place if they wish.

Well, we removed the dependency on dwave-tabu, but now we rely on dwave-samplers (see https://github.com/dwavesystems/dwave-system/pull/484). I think the original intent still stands, so I'll leave this issue open for now.


Is there a way to implement the frequency using my phone's integrated IR emitter?

My smartphone (Honor V10) has a integrated IR emitter that can be used for controlling things like TV. Is it possible to use that emitter so it can send the frequency that would make the wristband light up?

https://github.com/danielweidman/pixmob-ir-reverse-engineering/issues/10

ummmm i guess i just found the solution


Error

I'm getting an error when trying to register the service broker using the smctl tool:
$ smctl register-broker my-broker-i812662 https://my-broker-i812662-proud-camel-zy.cfapps.sap.hana.ondemand.com -b broker-user:broker-password
Error: request GET https://service-manager.cfapps.sap.hana.ondemand.com/v1/service_brokers?async=false failed: StatusCode: 200 Body: {"num_items":0,"items":[]}

I'm running on a Mac and a colleagues is running on windows (same version of smctl), and we both have the same problem.
smctl version
Service Manager Client v1.10.4 (b7476e0fafff00d2505751ddb29fc9a04cc8b255)

Can some help to identify the issue?
Best regards,
Roberto Falk

in the login command I was missing the httpS, and this is causing the problem later on


Discover works fine, but unable to run index.js with success

Colleague is running successful with Mac, I am running Ubuntu 14.04 with noble, temporal, rolling-spider, and bluetooth-hci-socket node modules.
Discover showed my minidrone
1: RS_B075911 (e014b3783d48), RSSI -54
When I run index.js, just hangs
Any advice is appreciated,
also any pointers on how to get debugging or logging on also appreciated.
Apologies if I sound dumb..... still getting up to speed with node
Thanks for this great piece of code/functionality

I had the same problem
https://github.com/voodootikigod/node-rolling-spider/issues/68

Thanks roeku, you mentioned, the following - so the BLE stops scanning, and it can then set up
this.ble.stopScanning();

is this correct

Also, there are 2 more things I should mention
A. when I say the index.js hangs, I get the following coming up, which I think it means it stops
1: RS_B075911 (e014b3783d48), RSSI -36
B. assuming it does not matter where I run the index.js files
appreciate your help

Thanks roeku, you mentioned, the following - so the BLE stops scanning, and it can then set up
this.ble.stopScanning();
is this correct

Also, there are 2 more things I should mention
A. when I say the index.js hangs, I get the following coming up, which I think it means it stops
1: RS_B075911 (e014b3783d48), RSSI -36
B. assuming it does not matter where I run the index.js files
appreciate your help

Go into lib/drone.js and add this line to 201
this.ble.stopScanning();
under
 this.peripheral = peripheral;
And then execute the index.js or another file in the eg folder. As far as I know this should resolve your issue.

yippee !!!!
that worked - many thanks
I am still a little confused, why I had to include that one line of code in
my version on ubuntu

when my colleague on Mac did not

regardless - I am very happy

Thank You

On Fri, Jan 15, 2016 at 5:29 AM, roeku<EMAIL_ADDRESS>wrote:

Go into lib/drone.js and add this line to 201
this.ble.stopScanning();
under
this.peripheral = peripheral;
And then execute the index.js or another file in the eg folder. As far as
I know this should resolve your issue.
—
Reply to this email directly or view it on GitHub
https://github.com/voodootikigod/node-rolling-spider/issues/74#issuecomment-171739079
.

Thanks @roeku !

For us this solved the problem, but not after having to re-connect
Thank you

Hi,
Same problem here:
noble warning: unknown peripheral eXXXXXXXXXXX
Discover.js works fine but I can't run index.js
Already add this.ble.stopScanning(); but there is no difference.
Drone: Rolling-Spider
Distrib: Debian 8
Thanks in advance.

Is this still an issue?

Problem solved...
I edited the message.


Fix haskell-lsp and lsp-test references

Motivation for this change
Tree did not evaluate otherwise due to broken references
Things done
Tested that tree evaluates

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@grahamcofborg eval

I'm not sure what to do here because the source no longer contains any reference to the old version but ofborg still picks it up from somewhere...

Unfortunately it looks like ghcide depends on haskell-lsp ==0.18.*, haskell-lsp-types ==0.18.*, so updating them here doesn't work.
@mgttlinger Could you make haskell-lsp_0_18_0_0 and haskell-lsp_types_0_18_0_0 available?  You can do this by sending a PR adding the required lines to extra-packages in configuration-hackage2nix.yaml and waiting for hackage-packages.nix to be regenerated.

@cdepillabout Can you recommend documentation to read to get an idea of what is going on with this yaml file so that I have more of an idea of what to do next time?

@mgttlinger Sorry, I don't actually have a good recommendation for documentation.  I've pieced it together by being active here in nixpkgs.  Although it is something I would like to help write at some point.

If you watch the weekly twitch streams from peti, you can get an idea of everything that goes into keeping haskell packages updated:
https://www.twitch.tv/peti343

@cdepillabout Actually would it be a possibility to update ghcide because the current version is fine with 0.19: https://github.com/digital-asset/ghcide/blob/v0.0.5/ghcide.cabal#L44-L45

Oh never mind the stack.yaml of ghcide disallows 0.19

I gues this is obsolete by now


Adds jupyter_raijin.sh in scripts folder

I think this is a good idea. Should we first update this for Gadi before merging?

I already did update it. I'm closing this PR and I'll submit a different one with the gadi version.


How to use laravel's Storage::download response?

How can I use Storage::download() with Inertia? Currently it just opens up a modal with the contents of the downloaded file..

You need to make a normal, non-Inertia request to download files. All Inertia requests must return a valid Inertia response, which a file download of course isn't. So, instead of using an <inertia-link>, just use a regular <a>. 👍

gular <a>.

Did you find a way around this?
I need to send a post request to download the file.

You should be able to just use a regular form. Optionally with the target set to _blank to ensure a new window/tab opens and your Inertia app will just keep running.
<form action={yourDownloadUrl} method="post" target="_blank">
    <button>Download</button>
</form>

You can do it with a form... but remember the csrf token.
First, send the token to the Inertia view where you are going to insert the form:
return inertia ( 'YourView', [ 'token' => csrf_token() ] );

Now, in the view, insert the csrf token in a hidden input.
For instance, in a React view:
<form action = { route ('your.named.route', your.param) } method = "post">
    <input type="hidden" name="_token" value={props.token}/>
    <button>Download</button>
</form>

You can use this in onClick
fetch(route('documents.download', { id: document.id }))
    .then((res) => res.blob())
    .then((blob) => {
      const file = window.URL.createObjectURL(blob)
      window.location.assign(file)
    })

Is there any new and convenient way to do this, just with inertiajs form ?


Do not disable apparmor by default

No idea why this would be made the default, include_recipe 'apparmor'
doesn't sound like something that would remove apparmor from my systems.
Fixes: https://github.com/chef-cookbooks/apparmor/issues/6

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@jordant

Please sign the CLA here.

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

100% agreed that apparmor shouldn't be disabled by default.  I actually have a branch going locally to make the default install/enable and to add a new apparmor_policy LWRP for managing the policy files.  I think that's probably what most people  expect this cookbook would do.

I released a 1.0.0 release that installs / enables by default and includes a basic LWRP.  Let me know if that works for you.

@tas50 I'll try that out, thanks!