Updated user guide + fix to predict_proba + updated tree-based weights and similarity

This is a first iteration of the updated documentation. It is not fully complete but good enough for a first merge.
Additionally to the documentation there are several fixes for problems I came across while writing the user guide and creating examples:

There was a bug in predict_proba where it converted the probabilities to integers.
The tree-based weights did not fully match what I originally intended. Specifically, it did not account for the repeated observations that can happen when fitting a random forest. Additionally, I switched the scaling to row-wise as this seems more inline with most existing works on this.
I removed the scaling from the similarity as I don't think it makes sense (there is now a formal math definition in the user guide).

I also added a tests for each of these points.

Added some more fixes/changes:

predict_proba for forests was still incorrect (hopefully its correct now)
There was bug in refit_leaf_nodes: If the tree only consisted of a root node it set it None and did not update the leaf_nodes.
When trying to integrate the RF weights I needed some additional flexibility on the sampling schemes, so I changed sampling_parameters to sampling_args which is dict now. I feel this is a bit easier to understand than having parameters that are too different.

One additional fix: The impurity for LocalLinear and LocalQuadratic was not scaled properly (similar to Squared_error).

Added documentation to the predict_weights, predict_leaf and similarity of the decision tree and the random forest. Feel free to take a look, if you are happy with the version I have created or not. @NiklasPfister


bower_components2 error

Followed the instructions on xcomponents.org to build a new application. When I accessed the app for the first time there were several 404 errors. Several were due to a path of bower_components2 being used rather than bower_components.

Instructions talked about doing a bower install xcomponents --save to get xcomponents, but I tagged the last release a couple of weeks ago. Changed it to bower install xcomponents --save for now to fix that (that automatically gets the latest commit). Once a stable release is available, I can change it back.


Manpages

Whenever I run uwsm -h, I find that it floods my terminal with a lot of information. I have to fullscreen the terminal or reduce the font size in order to see all of the text.
I think it would be a good idea to move the more verbose information to manpages to make it easier to read (and reduce the cognitive load).
A couple examples on how to set this up with meson (requires #17):

systemd uses an XML-based manpage generator: https://github.com/systemd/systemd/blob/414ae39821f0c103b076fc5f7432f827e0e79765/man/meson.build
sway uses scdoc: https://github.com/swaywm/sway/blob/c5fd8c050f7ddbfe3e5b7abc8f5f6ace3a3c5307/meson.build#L124C21-L124C26

What do you think about 10f589b? Now I either have to find something to template it with uwsm-bin-name, or drop the renaming thing entirely.

Nice! I looked through it briefly and it looks good to me :+1:
As for the uwsm-bin-name option:
I thought you could use configure_file() for this, but it seems to strip trailing white spaces, which breaks scdoc's parser.
This is what I used:
scdoc = dependency(
  'scdoc',
  version: '>=1.9.2',
  native: true,
  required: get_option('man-pages'),
)
if scdoc.found()
  scdoc_prog = find_program(scdoc.get_variable(pkgconfig: 'scdoc'), native: true)
  mandir = get_option('mandir')
  man_files = [
    'uwsm.1.scd.in',
    'uwsm-plugins.3.scd',
  ]
  conf = configuration_data()
  conf.set('BIN_NAME', UWSM_BIN_NAME)

  foreach filename : man_files
    basename = filename.split('/')[-1]
    if basename.endswith('.in')
      basename = basename.substring(0, -3)
      scd_file = configure_file(
        input: filename,
        output: basename,
        configuration: conf,
      )
    else
      scd_file = filename
    endif

    topic = basename.split('.')[-3]
    section = basename.split('.')[-2]
    output = '@0@.@1@'.format(topic, section)

    custom_target(
      output,
      input: scd_file,
      output: output,
      command: scdoc_prog,
      install: true,
      feed: true,
      capture: true,
      install_dir: '@0@/man@1@'.format(mandir, section),
    )
  endforeach
endif

I don't think this feature is worth the trouble. It's probably easier to remove uwsm-bin-name instead.

Thanks for the feedback, closing this.


feat: 为TernaryFilter的boolean方法增加可选参数以支持数字过滤

此更改扩展了TernaryFilter类的boolean方法，允许用户指定是否以数字形式（1和0）而非布尔值（true和false）进行查询过滤。通过新增参数 $isNumeric，可以在查询时根据其值选择使用数字或布尔值进行过滤，从而提高了查询的灵活性和兼容性。

Description

Visual changes

Functional changes

[ ] Code style has been fixed by running the composer cs command.
[ ] Changes have been tested to not break existing functionality.
[ ] Documentation is up-to-date.

Hi, I am not interested in supporting non-boolean boolean columns at the moment. You may override this using the queries() method on your own ternary filter though. Please check out our contributing guide which talks about proposing the feature before submitting the PR, to ensure you aren't spending time building something that we won't merge.


Add StringPrefix filter with tests

https://github.com/zendframework/zend-filter/issues/28

Thanks, @thexpand! I have added documentation and merged for release!


Broken Link (whats-new-in-hybrid-mobile-device-management.md)

The file:
SCCMdocs\sccm\mdm\understand\whats-new-in-hybrid-mobile-device-management.md
Includes the following broken link that should be corrected:
https://docs.microsoft.com/intune/intune-user-help/sync-your-device-manually-windows#sync-from-device-taskbar-or-start-menu
(admin edit: add metadata for article link)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 09aaf204-6890-76e6-a0fe-e246847c893f
Version Independent ID: 421111f1-df75-f692-aaeb-e6b5ecfdfe2d
Content: What's new in hybrid MDM - Configuration Manager
Content Source: sccm/mdm/understand/whats-new-in-hybrid-mobile-device-management.md
Product: configuration-manager
Technology: configmgr-hybrid
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

An easy fix, just drop the first "intune/" from the path, for example:
https://docs.microsoft.com/intune-user-help/sync-your-device-manually-windows#sync-from-device-taskbar-or-start-menu

@aczechowski - this was fixed in commit 711153c976c3fa3f53d1e99aeef3f7d819ac9461 (not by me) and can be closed.


Create multiple student accounts at once

Add the ability to create more than one student account at a time. And idea; the teacher could specify a generic ID e.g. the name of the school, and the number of accounts required. Then, automatically generate the users with username . For example, MySchool1, MySchool2, ..., MySchooln
Generating all the passwords may be tricky.

@DGraveling Finally got time to work on this - sorry it took so long!


[ASK] Remove deprecated Python settings from devcontainers.json

Description

Hi there!
I'm a PM for Python in VS Code, and I notice some of the Python extension's python.linting and python.formatting settings are being used in this repo's devcontainer.json file. These settings have been deprecated as in the latest Python extension pre-release version, as we're migrating our tooling support to extensions (see here for more details).
Because pylint is enabled for this repository, one workaround could be to include the new Pylint extension maintained by our team, and set the appropriate settings to use the pylint executable from the container itself.  For example:
	"settings": {
		"python.pythonPath": "/usr/local/bin/python",
		"python.languageServer": "Pylance",
		"pylint.importStrategy": "fromEnvironment",
		"pylint.path": ["/usr/local/py-utils/bin/pylint"]
	},

	"extensions": [
		"ms-python.python",
		"ms-python.vscode-pylance",
		"ms-python.pylint"
	],

Alternatively, the  path and importStrategy settings could be omitted so the pylint executable that is shipped with the Pylint extension is used instead (this approach would allow pylint to run faster than the one proposed above).
References

https://github.com/microsoft/vscode-python/wiki/Migration-to-Python-Tools-Extensions
https://github.com/devcontainers/features/pull/625

Thanks!

This should be fixed in this PR https://github.com/recommenders-team/recommenders/pull/2167
FYI @SimonYansenZhao


testMotors() function

instead of creating multiple testMotors() functions, create one in an opmode called "test".
it also gave me the idea that in this "test" opmode we can write all of our checks.
example:
testMotors(Motor motor){}
testServos(Servo servo){}
subsystemChecks(){}

Run each robot state for 5 seconds.

aight im on it


Add Numbers API code snippets

First attempt at curl building blocks for the Numbers API. Includes:

List owned numbers
Search for available numbers
Buy a number
Cancel a number
Update a number

Code snippet specs here

I did not know that! Fixed.


How to do a quick health check

Hello,
Is there a simple command to check whether the kafka connection is all good without doing any writes/reads like producing/consuming messages. A simple example could be to get the topics count. If it returns a number greater than 0, I can assert that my configuration and connection/handshake to kafka is good.
I can see Racecar uses rdkafka under the hood. So, if i can use a simple command to vet that configuration is good, it would be great. Thank you

Yeah racecar v2 is using rdkafka-ruby under the hood. So you can reach in to the underlying library to do something. Here is a quick example:
    config = { "bootstrap.servers" => "localhost:9092" } # add other config
    native_config = Rdkafka::Config.new(config).send(:native_config) # priv method
    native_kafka = kafka_config.send(:native_kafka, native_config, :rd_kafka_consumer)

    # do whatever with native_kafka, like get the topics count
    kafka_topic_names = Rdkafka::Metadata
                        .new(native_kafka, nil)
                        .topics.count

Note that this is reaching in to private methods, so it's possible the interface changes, i hope you get the idea though

Thank you, I did something similar long back, forgot to update it here.
  config = { "bootstrap.servers" => ENV['KAFKA_BROKERS'] }
  if ENV['SECURITY_PROTOCOL'] == 'SSL'
    config.merge!({
      "security.protocol" => "SSL",
      "ssl.certificate.location" => ENV['SSL_CLIENT_CERT_FILE_PATH'],
      "ssl.key.location" => ENV['SSL_CLIENT_CERT_KEY_FILE_PATH'],
      "ssl.key.password" => ENV['SSL_CLIENT_CERT_KEY_PASSWORD']
    })
  end
  native_kafka = Rdkafka::Config.new(config).consumer.instance_variable_get('@native_kafka')
  topics = Rdkafka::Metadata.new(native_kafka).topics.count
  puts "Kafka connection successful. Found topics: #{topics}"


:pencil2: Ignore table formatting

@steff456  - so the formatter does add the many spaces but it does not render accordingly in GH, which is annoying.
I prefer compact tables so went ahead and added an explicit <!-- prettier-ignore--->

This looks great! Thanks for working on this :)


WashingPostCollection does not work properly

When I run to index the WashingtonPost collection v2: ~/Anserini/target/appassembler/bin/IndexCollection -collection WashingtonPostCollection -input /scratch2/more_collections/WashingtonPost.v2/WashingtonPost.v2/data/ -generator JsoupGenerator -index lucene-index.wash18.pos+docvectors -threads 44 -storePositions -storeDocvectors -optimize &>log.wash18.pos+docvectors
The error occurs:
java.lang.NullPointerException
        at io.anserini.index.IndexCollection$IndexerThread.run(IndexCollection.java:198) [anserini-0.1.1-SNAPSHOT.jar:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_181]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_181]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_181]
2018-08-02 10:24:33,729 WARN  [main] index.IndexCollection (IndexCollection.java:365) - Unexpected difference between number of indexed documents and index maxDoc.
2018-08-02 10:24:33,730 INFO  [main] index.IndexCollection (IndexCollection.java:368) - # Final Counter Values
2018-08-02 10:24:33,730 INFO  [main] index.IndexCollection (IndexCollection.java:369) - indexed:                0
2018-08-02 10:24:33,730 INFO  [main] index.IndexCollection (IndexCollection.java:370) - empty:                 84
2018-08-02 10:24:33,730 INFO  [main] index.IndexCollection (IndexCollection.java:371) - unindexed:             84
2018-08-02 10:24:33,730 INFO  [main] index.IndexCollection (IndexCollection.java:372) - unindexable:            0
2018-08-02 10:24:33,731 INFO  [main] index.IndexCollection (IndexCollection.java:373) - skipped:                3
2018-08-02 10:24:33,731 INFO  [main] index.IndexCollection (IndexCollection.java:374) - errors:                 0
2018-08-02 10:24:33,736 INFO  [main] index.IndexCollection (IndexCollection.java:377) - Total 30,745 documents indexed in 00:00:24

And the indexer quits unexpectedly

I think we need to add the .jl extension to the allowedFileSuffix in WashingtonPostCollection.

@Peilin-Yang I addressed this exception results from the ContentObj in this line may be null.
After handling the Null exception, the program works fine. However, I noticed that the number of skipped files is quite large compared to my original design, which may affect the correctness of our results. I suspect there're some other problems in our code. I'll address it and do the pull request together

@Kytabyte I think this line is redundant.

The reason for this issue is because the content may not only be a String, but possibly List<String> or Map<String, String>. I addressed a dirty way to solve this problem just to get the indexer working as soon as possible. I will raise a PR and we can discuss a neater way to do this.

@Kytabyte
I think there are still two problems:

I think we should include title and fullcaption field.
When concatenating paragraphs we should explicitly set a splitter, e.g. \n or  . The default Lucene Analyzer will not split the terms by .

Related to #383, you should also update the unit test and make sure it actually works

Related to #383, you should also update the unit test and make sure it actually works

@Peilin-Yang Has this issue already been solved?

@Kytabyte I just merged the PR, you should be able to send PR on top of it.

Merged #390


Compat with mypy 1.1.1

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
Mypy 1.1.1 was just released (main highlight is support for dataclass_transform).
Signature for Model.__init__ appears to be broken with this latest mypy version when Config.allow_population_by_field_name=True.
Example Code
class Model(pydantic.BaseModel):

    toto: str = pydantic.Field(alias="tata")

    class Config:
        allow_population_by_field_name = True

Model(toto="toto")  # error: Unexpected keyword argument "toto" for "Model"  [call-arg]
Model(tata="tata")

Python, Pydantic & OS Version
pydantic version: 1.10.5
            pydantic compiled: True
                 install path: [...]/.venv/lib/python3.11/site-packages/pydantic
               python version: 3.11.2 (main, Feb 16 2023, 02:55:59) [Clang 14.0.0 (clang-14<IP_ADDRESS>)]
                     platform: macOS-13.1-arm64-arm-64bit
     optional deps. installed: ['typing-extensions']

Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[X] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Also got into the same issue with the code below when running mypy, which I think it's related:
from pydantic import BaseSettings, Field

class Settings(BaseSettings):
    class Config:
        env_file = ".env.test", ".env"
        env_file_encoding = "utf-8"

    token: str = Field(..., env="token")

Settings()  # Missing named argument "token" for "Settings"  [call-arg]

Version 1.10.6 was released a few hours ago. https://github.com/pydantic/pydantic/releases/tag/v1.10.6
To restore the previous behavior, you might need to add the pydantic.mypy plugin to your mypy config.
https://docs.pydantic.dev/mypy_plugin/

👍 thanks @cdce8p for all your work.

All good on my part. Thanks!


Android RN 0.48.2

"react-native-circular-progress": "^0.0.8",
npm version
0.0.8': '2016-12-23T09:34:56.994Z' },
homepage: 'https://github.com/bgryszko/react-native-circular-progress
If you have a new version, please update the NPM,thx

Manual updates, but there are problems
change prop size bigger

Same problem

@Mad-hu @MrFlox #72 has a solution

Closing as duplicate


Support Lidarr

For music!

I think this will make things more complicated than just video media - considering we brought in overseerr (which doesn't support lidarr)


cassandra-k8s deployment is not working with vagrant

official cassandra charm :- https://charmhub.io/cassandra-k8s
We are using command to deploy cassandra on vagrant
 juju deploy cassandra-k8s --channel edge

but after deploying Cassandra ,it is getting stuck in Waiting for Database , please find all the details as listed below.
Pods status
vagrant@microk8s1:~$ microk8s.kubectl get pods -n dev -w
NAME                            READY   STATUS    RESTARTS   AGE
modeloperator-c4c46f7f6-q8rxz   1/1     Running   0          55m
cassandra-k8s-0                 2/2     Running   0          54m

Juju status
Every 2.0s: juju status --color                                                                                microk8s1: Thu Sep 30 07:31:32 2021

Model  Controller  Cloud/Region        Version  SLA          Timestamp
dev    micro       microk8s/localhost  2.9.11   unsupported  07:31:34Z

App            Version  Status   Scale  Charm          Store     Channel  Rev  OS          Address       Message
cassandra-k8s           waiting      1  cassandra-k8s  charmhub  edge       7  kubernetes  <IP_ADDRESS>  installing agent

Unit              Workload     Agent  Address      Ports  Message
cassandra-k8s/0*  maintenance  idle   <IP_ADDRESS>         Waiting for Database

Error details :-
unit-cassandra-k8s-0: 07:30:05 ERROR juju.worker.dependency "log-sender" manifold worker returned unexpected error: cannot send log message: write tcp <IP_ADDRESS>:41290-><IP_ADDRESS>:17070: write: connection reset by peer
unit-cassandra-k8s-0: 07:30:05 INFO unit.cassandra-k8s/0.juju-log Caught exception <class 'cassandra.cluster.NoHostAvailable'>:('Unable to connect to any servers', {'<IP_ADDRESS>:9042': ConnectionRefusedError(111, "Tried connecting to [('<IP_ADDRESS>', 9042)]. Last error: Connection refused")}): deferring
unit-cassandra-k8s-0: 07:34:38 ERROR juju.worker.dependency "log-sender" manifold worker returned unexpected error: cannot send log message: write tcp <IP_ADDRESS>:43930-><IP_ADDRESS>:17070: write: connection reset by peer

System Info
vagrant@microk8s1:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.2 LTS
Release:        20.04
Codename:       focal
vagrant@microk8s1:~$ sudo snap list
Name        Version     Rev    Tracking       Publisher   Notes
charm       2.8.2       609    latest/stable  canonical✓  classic
charmcraft  1.2.1       603    latest/stable  canonical✓  classic
core        16-2.51.7   11743  latest/stable  canonical✓  core
core18      20210722    2128   latest/stable  canonical✓  base
core20      20210702    1081   latest/stable  canonical✓  base
docker      20.10.8     1125   latest/stable  canonical✓  -
jq          1.5+dfsg-1  6      latest/stable  canonical✓  -
juju        2.9.15      17320  latest/stable  canonical✓  classic
lxd         4.18        21497  latest/stable  canonical✓  -
microk8s    v1.21.5     2487   1.21/stable    canonical✓  classic
snapd       2.51.7      13170  latest/stable  canonical✓  snapd
vagrant@microk8s1:~$

Hello @Vaishalinicky
Currently Cassandra takes quite a while to start up. This is because if the database is not ready it defers action until the next hook fires. I am working on a rather extensive change that should speed things up a bit, but there will still be some amount of waiting.
If you are concerned that the charm is actually stuck, I would recomment the following debugging:
Run microk8s.kubectl exec cassandra-k8s-0 -c cassandra -- ps aux and make sure there is a java process running. If it is you likely just need to wait.
Run microk8s.kubectl logs cassandra-k8s-0 -c cassandra and look for any errors in the logs.
Let me know if this is helpful. If you still have issues, I can help you debug further.


Version 1.3.2 mysteriously ignores previously nested  no matter what

Admittedly our use case is not exclusively within a StackNavigator but none of our code has changed.
Unfortunately upon revisiting the project the nested AndroidBackHandlers are totally ignored, not run at all, and only the highest level onBackPress is captured and run.
Returning false, true at the highest level has no effect, and any other actions in nested handlers don't work to preempt this because the functions simply aren't run. Any thoughts would be greatly appreciated because we're otherwise looking at a huge amount of unexpected work and rethinking of our application.
I've examined my yarn.lock to try to find differences in version of this package or react-navigation packages, but I don't see anything wrong there either.

Upgrading to 1.4.0 fixed one nested back handler, so I thought we were home free. Unfortunately, it broke another. -_-

hello and thanks for reporting! Indeed, outside of Stack I'm not even sure how this works, but this might be an opportunity to get it to work somehow. However, to be able to help, I need to have some runnable code that I can work with and test the different use cases. Would you be able to provide this? Thanks!

Hey @vonovak thanks for your reply.
Unfortunately the runnable code is a bit too complex to put together a repro. I never figured out why this happens, but I ended up with a workaround until we upgrade to React-Navigation 5. It's not pretty, but it doesn't need to scale. Hope it helps someone.
To give an example in case anyone else hits this:
(We upgraded to 1.4.0 which isn't necessary I think, but mentioning for completeness.)
    if (navigator.state.nav.routes
       .find(route => route.routeName === 'mainStack')
        .routes.find(route => route.routeName === 'innerNav')
        .routes.find(route => route.routeName === 'myScreen').isDrawerOpen)
            NavigationService.DrawerActions.closeDrawer()


Set default selected colour to match the colour wheel

This commit sets SelectedColour to the default set in the .xaml after
the colour wheel component is initialized
This fixes issue #7

Thanks for the PR. Looks good, going to merge.


AttributeError: 'Contact' object has no attribute 'name'

    sender = '{}'.format(message.sender)
  File "WebWhatsapp-Wrapper-master/webwhatsapi/objects/contact.py", line 51, in __repr__
    safe_name = self.get_safe_name()
  File "WebWhatsapp-Wrapper-master/webwhatsapi/objects/contact.py", line 43, in get_safe_name
    name = (self.name or self.push_name or self.formatted_name)
AttributeError: 'Contact' object has no attribute 'name'

it's working now for what it's worth


examples: fix and improve init script

What are the changes and their implications?
Fix the example init script that doesn't work on debian 12, with droppy installed with npm install -g @droppyjs/cli.
What I changed to fix and improve it so it works better:

args -c and -f are not read because of -- and it falls back to the ~/.droppy default
process isn't droppy but @droppyjs/cli so it doesn't match
use a pid file instead, more reliable

Checklist

[ n/a ] Changes covered by tests (tests added if needed)
[ n/a ] PR submitted to droppyjs.com for any user facing changes

Thanks for the fork and maintaining it <3

Thanks for the improvement!


Update table.py

If an empty list is passed as an arg to the data param, it will pass the isinstance test on line 53 but will fail with an IndexError: list index out of range on line 55.  Checking to see if data is not empty will solve this error as well as other potential downstream errors.  Throwing a ValueError if the data is empty, but open to other suggestions on how to gracefully handle.

hey i resolved the merge conflict. it seems like just calling any doesn't work well if the input is a dataframe. the checks seems like it needs to be type specific?
i guess also the question is whether we want to raise or just noop when you pass empty input to table.add?


Provide option to generate circular images

Yes i thought of that but most of them would like to obtain that through CSS

as this plugin is server-side, many devs may use it along with an API, if that's the case you can't say that they necessarily use the API on the web. If they are using it in an Android app then I don't know if there is a technique for circular  images.

Yes, that is a valid point. I will add that this also to the TODO for next release

Whoever picking this up please refer https://www.npmjs.com/package/jimp


W-14322169 Update install-rtfctl.adoc

Writer's Quality Checklist
Before merging your PR, did you:

[ ] Run spell checker
[ ] Run link checker to check for broken xrefs
[ ] Check for orphan files
[ ] Perform a local build and do a final visual check of your content, including checking for:

Broken images
Dead links
Correct rendering of partials if they are used in your content
Formatting issues, such as:

Misnumbered ordered lists (steps) or incorrectly nested unordered lists
Messed up tables
Proper indentation
Correct header levels

[ ] Receive final review and signoff from:

Technical SME
Product Manager
Editor or peer reviewer
Reporter, if this content is in response to a reported issue (internal or external feedback)

[ ] If applicable, verify that the software actually got released

Closing due to new PR created https://github.com/mulesoft/docs-runtime-fabric/pull/1161


[Feature Request]: Table - Group rows

Description
Hi, it would be nice to have a feature in the Table component to group rows together and have buttons to expand or compress groups. To give an example, I mean something like the AWS RDS Databases table:

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate requests

Hi, thank you for reaching out. We currently don't have concrete plans for building such a feature, but it is a reasonable request. We'll keep this ticket open and update it if/when we implement that feature.

Hi! We just released this feature, called expandable rows, a few weeks ago. Check out the demo here, which also links to the source code. We also wrote up an article to help you understand the choices behind the design. Hopefully this helps!

Wow, this looks nice, great job!
Thank you


ShowContinuousQueries shows queries from all databases despite db name passed as argument

Can you confirm whether or not it is actually possible to do this in influxdb?
When looking at the API, I do not think it is possible to do this, which would mean the fact that this library accepts db as a parameter is a bug.

yes, you are right, the api does not allow to specify db name


The AMP Layout System

@jmadler what is this issue about? Is there something specific that you want done or that you think is wrong?

This'd be a sample to explain the AMP Layout system


Storage Limit Update V0.12.5

DO NOT MERGE: flow-go version needs to be pinned to a tag first
References: https://github.com/dapperlabs/flow-go/issues/5127, https://github.com/onflow/flow-go/pull/208
Description
Default behaviour has not changed.
Using the --storage-limit emulator flag storage limiting can be turned on. This changes the following:

every account has a minimum Flow balance. If the account is below the minimum balance any transaction that touches that account will fail.
if accounts storageUsed is more or equal to accounts storageCapacity at the end of a transaction that touches that account the transaction will fail.
creating a new account deducts flow from the payer of that accounts creation.

For contributor use:

[x] Targeted PR against v0.12.5 branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[ ] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

@turbolent where should I put the documentation for this emulator flag?

@turbolent where should I put the documentation for this emulator flag?

@janezpodhostnik I think the README is the best place for now. agree @psiemens?

@janezpodhostnik I think the README is the best place for now. agree @psiemens?

Closing, we'll merge this feature directly to master instead of backporting it to the older/current version

Closing, we'll merge this feature directly to master instead of backporting it to the older/current version


compilation error ...

[ERROR] /home/test/tools/RmiTaste/src/main/java/m0/rmitaste/rmi/RmiRegistry.java:[4,24] error: cannot find symbol
symbol:   class RMIReplyDataParser
location: package m0.rmitaste.utils
[INFO] 1 error

Attempt to use compilation on windows and Linux systems failed    :(

Thank you for reporting, it should work now :)


[Map] CTF-AF-Coloraido-103

Not for Air Fight but just a normal UT99 CTF map.  The AF prefix here indicates the makers of the map, ActionForce Studios.
Same comment applies to the two other AF maps added at the same time as Coloraido except, of course, that the DM map is a normal DeathMatch map.
Maps for Air FIght have the prefix AF and not any of the normal UT gametype prefixes.

URL: https://unrealarchive.org/maps/unreal-tournament/airfight/C/ctf-af-coloraido-103_197e96bf.html
Hash: 197e96bf11f7a6116e552a94c422998ff8b4cf06
Current name: CTF-AF-Coloraido-103

Thanks, fixed.


Updated to .Net Standard 2.0

Updated library project to .Net Standard 2.0 and Test project to .Net Framework 4.7.
Fixed some small typos and updated nuget packages in the Test project.
I created new .Net Standard 2.0 project and copied the contents of old FluentConsole project into it. The original main FluentConsole project is still there but is now called FluentConsole.Net45 but it's not loaded in the solution file.  You can delete it of you're happy with the new library project.
I also added the nuget settings to the project properties with the same information as was in the AssemblyInfo.cs file and also added your post build step to build the nuget back.
Finally, I renamed the original .Net Framework demo project to FluentConsole.NetFramework.Demo and created another demo project for .Net Core called FluentConsole.NetCore.Demo.  Not great names, I know.  Feel free to amend as you wish.
Hope this helps.  You should be able to step the versions of .Net core and .Net Framework down as you require.
Let me know if you have any questions or need anything else done.
Regards,
Chris

Not sure how to resolve the AppVeyor build error.  Never used it before.  According to articles I've just read, the msbuild version must v15.
See here:  https://stackoverflow.com/questions/42509313/the-default-xml-namespace-of-the-project-must-be-the-msbuild-xml-namespace/44166281#44166281

OK.  I created an AppVeyor account and got the build working by selecting Visual Studio 2017 as the build worker image and adding the following 2 pre-build commands:
dotnet restore
nuget restore
Now the issue is 2 tests are failing and I don't understand why.
https://ci.appveyor.com/project/Chris42131/fluentconsole/build/tests
Any ideas?

Hey Chris, sorry for the long delay. I will look at this as soon as I can. Might not happen until this weekend.

The original main FluentConsole project is still there but is now called FluentConsole.Net45 but it's not loaded in the solution file.

Why not just change the target framework and leave the original name intact?

Closing due to inactivity.


Test Java 17

Java 17 will be a long term release (LTS) candidate. Java 17 is expected to be released in September 2021.
For more information have a look at: http://openjdk.java.net/projects/jdk/17/

Java 17 will be released on the 14th of September 2021.

Java 17 has been released on the 14th of September 2021:

Oracle Releases Java 17
JDK 17: The new features in Java 17

Can you help me in this

Can you help me in this

First, thanks for being interested in this topic.
This issue requires on to test whether SecHub can be run and/or build with Java 17. To run / build SecHub using Java follow the instructions of the Quickstart Guide: https://daimler.github.io/sechub/latest/sechub-quickstart-guide.html.
Please first make sure to use Java 11 as we already tested it with Java 11 and it should work well: https://github.com/Daimler/sechub/issues/187.
After using Java 11, switch your Java version to 17 and try to build it. In case it fails, report the problems this issue here.
My assumptions are:

One can run SecHub with Java 17 just fine
The build will fail, because of Gradle #495.

However, just give it a try.
NOTE: All of this manual work is required, because we do not do an automatic matrix build with different Java versions.

Please have a look at the Java 16 test, you might get the same issue: #613.

Java 17 support was added in Gradle 7.3. Depends on: #495 and #1085.

This can be tested with additional runtimes from the Adoptium Marketplace: https://adoptium.net/marketplace/.

Eclipse Adoptium provides APIs for:

the Temurin Java distribution: https://api.adoptium.net/
the Adoptium marketplace: https://marketplace-api.adoptium.net/

those can be used to get the Java binary releases for OpenJ9 and Temurin.

Test: Debian Container
OpenJDK Package:
The open Semeru runtime 17 (Eclipse OpenJ9 build) can be used to run SecHub, but not build it:
#15 60.37 > Task :sechub-pds:ensureLocalhostCertificate
#15 60.37 dev-base.sh: line 25: keytool: command not found
#15 60.37 Start creating localhost certificate
#15 60.37 Created file /build/sechub/sechub-pds/src/main/resources/certificates-untracked/generated-dev-localhost-keystore.p12

Apparently, there is no keytool command available.
Temurin 17:
Works
OpenJDK (Debian package):
Works


[BUG] Envycontrol not working after Python 3.12 update

Describe the bug
Envycontrol don't run after python 3.12 update on Endeavour (Arch based)
To Reproduce
Steps to reproduce the behavior:

Run sudo envycontrol -s nvidia
Error:
Traceback (most recent call last):
File "/usr/lib/python3.12/importlib/metadata/init.py", line 397, in from_name
return next(cls.discover(name=name))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
StopIteration

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/bin/envycontrol", line 33, in
sys.exit(load_entry_point('envycontrol==3.4.0', 'console_scripts', 'envycontrol')())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/bin/envycontrol", line 22, in importlib_load_entry_point
for entry_point in distribution(dist_name).entry_points
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/importlib/metadata/init.py", line 862, in distribution
return Distribution.from_name(distribution_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/importlib/metadata/init.py", line 399, in from_name
raise PackageNotFoundError(name)
importlib.metadata.PackageNotFoundError: No package metadata was found for envycontrol
System Information:

Model: Dell G15
Distro: EndeavourOs
Kernel: 6.7.9-zen1-1-zen
DE/WM and Display Manager (if applicable): KDE 6 SDDM
EnvyControl version: 3.4.0
Nvidia driver version: 550.76-2
lspci output:

0000:00:00.0 Host bridge: Intel Corporation Device a719 (rev 01)
0000:00:01.0 PCI bridge: Intel Corporation Device a70d (rev 01)
0000:00:02.0 VGA compatible controller: Intel Corporation Raptor Lake-S UHD Graphics (rev 04)
0000:00:04.0 Signal processing controller: Intel Corporation Raptor Lake Dynamic Platform and Thermal Framework Processor Participant (rev 01)
0000:00:0e.0 RAID bus controller: Intel Corporation Volume Management Device NVMe RAID Controller Intel Corporation
0000:00:12.0 Serial controller: Intel Corporation Device 7a78 (rev 11)
0000:00:14.0 USB controller: Intel Corporation Raptor Lake USB 3.2 Gen 2x2 (20 Gb/s) XHCI Host Controller (rev 11)
0000:00:14.2 RAM memory: Intel Corporation Raptor Lake-S PCH Shared SRAM (rev 11)
0000:00:14.3 Network controller: Intel Corporation Raptor Lake-S PCH CNVi WiFi (rev 11)
0000:00:15.0 Serial bus controller: Intel Corporation Raptor Lake Serial IO I2C Host Controller #0 (rev 11)
0000:00:15.1 Serial bus controller: Intel Corporation Raptor Lake Serial IO I2C Host Controller #1 (rev 11)
0000:00:16.0 Communication controller: Intel Corporation Raptor Lake CSME HECI #1 (rev 11)
0000:00:1c.0 PCI bridge: Intel Corporation Device 7a3e (rev 11)
0000:00:1f.0 ISA bridge: Intel Corporation Device 7a0c (rev 11)
0000:00:1f.4 SMBus: Intel Corporation Raptor Lake-S PCH SMBus Controller (rev 11)
0000:00:1f.5 Serial bus controller: Intel Corporation Raptor Lake SPI (flash) Controller (rev 11)
0000:01:00.0 VGA compatible controller: NVIDIA Corporation GN20-P0-R-K2 [GeForce RTX 3050 6GB Laptop GPU] (rev a1)
0000:01:00.1 Audio device: NVIDIA Corporation Device 2291 (rev a1)
0000:02:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8211/8411 PCI Express Gigabit Ethernet Controller (rev 15)
10000:e0:1b.0 System peripheral: Intel Corporation RST VMD Managed Controller
10000:e0:1b.4 PCI bridge: Intel Corporation Raptor Lake PCI Express Root Port #21 (rev 11)
10000:e1:00.0 Non-Volatile memory controller: ADATA Technology Co., Ltd. SM2P41C3 NVMe SSD (DRAM-less) (rev 03)

Idem on Garuda Linux

Arch Linux changed something on their side, will take a look and thanks for reporting!

@luciorgomes @overwrite00 if you uninstall envycontrol, clear cache and install it again does it work?
I remember experiencing a similar issue each time Arch Linux did a major Python upgrade.

@luciorgomes @overwrite00 if you uninstall envycontrol, clear cache and install it again does it work?
I remember experiencing a similar issue each time Arch Linux did a major Python upgrade.

I removed envycontrol, cleared cache and installed again. Upon reboot everything works perfectly. Thanks and great work 😉 💪

@luciorgomes @overwrite00 if you uninstall envycontrol, clear cache and install it again does it work?

I remember experiencing a similar issue each time Arch Linux did a major Python upgrade.

I removed envycontrol, cleared cache and installed again. Upon reboot everything works perfectly. Thanks and great work 😉 💪

Amazing @overwrite00, do you mind sharing the exact commands in order to update the README? 😉

No problem. The commands to type in your terminal are the following:
sudo pacman -R envycontrol #uninstall envycontrol
sudo pacman -Sc #clear package cache
sudo Pacman -Sy envycontrol #install envycontrol
Procedure performed successfully on Garuda Linux.

Thanks @bayasdev @overwrite00 ! It's ok now.

on vanilla arch and endeavouros you need to also rm -r $HOME/.cache/paru/clone/envycontrol && sudo rm /usr/bin/{netaddr , tqdm} as it can cause
error: failed to commit transaction (conflicting files) python-netaddr: /usr/bin/netaddr exists in filesystem python-tqdm: /usr/bin/tqdm exists in filesystem Errors occurred, no packages were upgraded.

You can also do this to fix it: paru -S --rebuild envycontrol.
This problem happens with AUR packages depending on python after major python version updates occur. I have a pacman hook to warn me of these cases, but I kind of wish there was a graphics card switcher not written in python for this reason (eg in shell, rust, go, etc).
At least with envycontrol (because it's not service based) these problems won't break my system like they did with optimus-manager

FYI - for future readers - I tend to use a Python venv for all software that I rely upon and not the system installation. I.e., I do not install any pip packages globally.
PDM (https://pdm-project.org/) can help deal with duplicate package installs across Python apps to minimize filesystem footprint.
Just realize that the root user will need its own cache as well as your login user. So not perfect (yet), but it helps a lot.
Kudos to @bayasdev for his experience with the matrix of variables people are exposed to!

Closing due to inactivity


Update  extra reading section in "errors"?

Context:https://tour.ardanlabs.com/tour/error-handling/1
Link to https://crawshaw.io/blog/xerrors
probably should be replaced with?
https://go.dev/blog/go1.13-errors,
now that it is part of standard library, not a proposal anymore.
Also, maybe https://go.dev/blog/go1.13-errors supersedes https://go.dev/blog/error-handling-and-go ?
Also, the correct link for Why Go's Error Handling is Awesome is:
https://rauljordan.com/why-go-error-handling-is-awesome/

Can you create a PR and add yourself to the CONTRIBUTORS file?


Incorrect Orientation set by SecondSpectrum deserializer

Applying the Second Spectrum deserializer on the example test data results in an inconsistency between the orientation (Orientation.FIXED_AWAY_HOME) and periods' attacking directions (AttackingDirection.AWAY_HOME and AttackingDirection.HOME_AWAY). This is even included in the test case.
https://github.com/PySport/kloppy/blob/64d9f1edf8a13d872310f704ed2220785dd03215/kloppy/tests/test_secondspectrum.py#L34-L68
I am not familiar with Second Spectrum tracking data, so I do not know whether this is an issue with the fake example data or with the parser.

This was correct. I misunderstood what Orientation.FIXED_AWAY_HOME means.


Change CSS formating of pre blocks the elmclient

See here: https://www.dropbox.com/s/hrw4vi1iga7bl5e/Screenshot 2018-08-16 10.35.11.png?dl=0

Closed by 2180ab11c7d2f11785fa6e21db424eed1cf6b060


Fix issues rebasing hotfixes

Sorry for late! I'm a bit busy lately. I have test it. Here's my mock experiments
Common scenario: Let say that I have one package to develop named docs. It's start with version 0.0.0
Scenario 1: docs was pre-release with version 0.0.1-beta0. But the team found that version 0.0.0 need a hotfix.

Branch from main branch named hotfix
Fix the issue and commit it ti branch hotfix
Add changeset file as always to describe what you change for this branch
Open the PR, wait for approvals, and then merge it
The PR Version Packages appeared. Merge it
docs was bumped to version 0.0.1. The CHANEGLOG and package.json was updated
The CI try to rebase beta into main. The error occurred. CHANGELOG and package.json of docs got conflicts!

Scenario 2 docs was not pre-release yet. But the team found that version 0.0.0 need a hotfix.

Like scenario 1. Release hotfix
The CI try to rebase beta into main. No conflicts. Everything works well.

So, to summarize, you may have to manually rebase if you're in scenario 1. But, you don't have to do anything if you're in scenario 2.
The pre-release is the hardest thing to do when you want to apply versioning system to your own repository, said by Changeset themself. So, I suggest that you don't have to add pre-release to your workflows if you don't have to. Just use release-without-versioning like dev for beta.
For your PR, unfortunately, it do not solve the problem you raised. So, I'll close this with the comment.


Upgrade CI test caching

Want:
I had a build where the linter failed (the MISC travis job) but all the others worked (PPS1, PPS2, PPS3). I'd love to be able to push a new commit w the one change I need, and the other test results are cached.

Travis caches test results per branch
Right now only the PFS suite uses the cache, we've disabled the test cache everywhere else, because all the other test suites require the pach cluster to be up and running, and so the go build ... process that gets run as part of the test compilation and execution doesn't capture all the dependencies ... so we could see a cached result even though deps changed, which would be invalid.
But!
I think is a way to mark go deps so that this cache is updated at the right time.

This seems like a very far off CI optimization and likely an unsafe one. Assuming that you can tell that certain tests on a commit are going to pass because they passed on the parent commit and none of the changes affect the outcome of the test seems like it's only possible to do in a tiny fraction of cases. The case mentioned here seems particularly impossible, to fix the linter you have to change code, so you can't really be sure that you fixed the linter without breaking the code in some other way (I mean, normally you're sure of this and right, but CI should be paranoid). I don't think waiting for another CI run when you need to fix actual issues with CI is that big of a burden on engineering, so I'm going to close this.


remove unnecessary code in requester.js

authenticatedRequest() is called twice, and neither call uses a return value, so safe to remove "return request".
operation.requestBodyProvider property is never set, so safe to remove the logic that acts on it.

Mike, thanks for cleaning up the code base.
I filled in the labels, milestone, and assignee.
Aries, this refactoring requires no new tests -- it simply just shouldn't cause any regressions.


Crash after installing previous version of app

When we add a new feature, there will always be 0.1% of people who hate the new feature so much that they switch back to the previous version of the app. I think that has happened to many of us too, and if they prefer that version well why not.
Problem: After switching to a previous version, any attempt to start the app is met with this crash:

Unknown to most users, the logcat below offers an explanation.
Rather than crashing, we should probably explain how to fix the problem ("please uninstall then reinstall"), or even remove the database (we don't store vital information in there right?) then start normally.
06-05 17:02:38.802 2360-2360/fr.free.nrw.commons.debug E/AndroidRuntime: FATAL EXCEPTION: main
    Process: fr.free.nrw.commons.debug, PID: 2360
    java.lang.RuntimeException: Unable to start activity ComponentInfo{fr.free.nrw.commons.debug/fr.free.nrw.commons.contributions.ContributionsActivity}: android.database.sqlite.SQLiteException: Can't downgrade database from version 7 to 6
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2684)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2751)
        at android.app.ActivityThread.-wrap12(ActivityThread.java)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1496)
        at android.os.Handler.dispatchMessage(Handler.java:102)
        at android.os.Looper.loop(Looper.java:154)
        at android.app.ActivityThread.main(ActivityThread.java:6186)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)
     Caused by: android.database.sqlite.SQLiteException: Can't downgrade database from version 7 to 6
        at android.database.sqlite.SQLiteOpenHelper.onDowngrade(SQLiteOpenHelper.java:360)
        at android.database.sqlite.SQLiteOpenHelper.getDatabaseLocked(SQLiteOpenHelper.java:254)
        at android.database.sqlite.SQLiteOpenHelper.getReadableDatabase(SQLiteOpenHelper.java:187)
        at fr.free.nrw.commons.contributions.ContributionsContentProvider.query(ContributionsContentProvider.java:52)
        at android.content.ContentProvider.query(ContentProvider.java:1020)
        at android.content.ContentProvider$Transport.query(ContentProvider.java:239)
        at android.content.ContentProviderClient.query(ContentProviderClient.java:145)
        at android.content.ContentProviderClient.query(ContentProviderClient.java:127)
        at fr.free.nrw.commons.contributions.ContributionDao.loadAllContributions(ContributionDao.java:50)
        at fr.free.nrw.commons.contributions.ContributionsActivity.onAuthCookieAcquired(ContributionsActivity.java:116)
        at fr.free.nrw.commons.auth.AuthenticatedActivity.requestAuthToken(AuthenticatedActivity.java:26)
        at fr.free.nrw.commons.contributions.ContributionsActivity.onCreate(ContributionsActivity.java:140)
        at android.app.Activity.performCreate(Activity.java:6684)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1119)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2637)

Going forward, it seems like we can use https://developer.android.com/reference/android/database/sqlite/SQLiteOpenHelper.html#onDowngrade(android.database.sqlite.SQLiteDatabase, int, int) . Or if not, can we offer to delete the (too new) database when the old app is started?
For the versions that are already released, a section or a page in the documentation would be better than nothing. (on the wiki or store page?)

A DB migration unhandled exception, handled in the latest commits, seems to very very old, closing this one


Set environment variable to disable building swift-syntax in Swift 6 mode

This allows us to work around the following issue in CI: The self-hosted SwiftPM job has Xcode 15.3 (Swift 5.10) installed and builds a Swift 6 SwiftPM from source. It then tries to build itself as a fat binary using the just-built Swift 6 SwiftPM, which uses xcbuild from Xcode as the build system. But the xcbuild in the installed Xcode is too old and doesn't know about Swift 6 mode, so it fails with: SWIFT_VERSION '6' is unsupported, supported versions are: 4.0, 4.2, 5.0 (rdar://126952308). This is fixed by setting SWIFTSYNTAX_DISABLE_SWIFT_6_MODE in build-using-self.
The source compat suite is seeing the same issue, just by using bootstrap, so set it there as well.
Accompanies https://github.com/apple/swift-syntax/pull/2621

https://github.com/apple/swift-syntax/pull/2621
@swift-ci Please test


Accessing values from other columns

First of all, thank you @ratiw -- I love the way you've architected Vuetable-2, and appreciate all of your hard work.
I have a use-case where I'd like to be able to access values from other columns in a given row inside of the callback that I define in the field defs.
I want to be able to link a text field to a URL based on data in another column in the row, but it doesn't appear there's any way to do this via the callback; something like id = row['id'];
I also looked into __component: but that too appears to only pass in the data for the current column.
How might this be accomplished? I'm using Vuetable-2 1.7.x
Looking into this to see if it applies... https://github.com/ratiw/vuetable-2/issues/507

@khalwat __component and __slot do get the whole row data, not just the column data. That means you can use them to solve your problem. The reason that the callback (renamed to formatter in v2.0) receives only the column value because it was meant to be used for formatting only.


Update packages

Description
Updates to latest core and common packages
Checklist

[x] The version field in package.json is incremented following semantic versioning
[x] The box that allows repo maintainers to update this PR is checked
[x] I tested locally to make sure this feature/fix works
[x] This PR passes the Circle CI checks

Description
Updates to latest core and common packages
Checklist

[x]  The version field in package.json is incremented following semantic versioning
[x]  The box that allows repo maintainers to update this PR is checked
[x]  I tested locally to make sure this feature/fix works
[x]  This PR passes the Circle CI checks


Make tutor.utf-8 like tutor

tutor.utf-8 did not get changed when tutor was changed

Codecov Report

Merging #3204 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3204      +/-   ##
==========================================
- Coverage   76.43%   76.43%   -0.01%
==========================================
  Files          93       93
  Lines      136775   136776       +1
==========================================
  Hits       104538   104538
- Misses      32237    32238       +1

Impacted Files
Coverage Δ

src/gui_beval.c
61.57% <0%> (-0.88%)
:arrow_down:

src/ex_cmds2.c
82.63% <0%> (-0.1%)
:arrow_down:

src/term.c
59.72% <0%> (-0.06%)
:arrow_down:

src/getchar.c
75.16% <0%> (-0.05%)
:arrow_down:

src/channel.c
83.03% <0%> (-0.04%)
:arrow_down:

src/window.c
82.18% <0%> (-0.04%)
:arrow_down:

src/gui.c
49.58% <0%> (ø)
:arrow_up:

src/if_py_both.h
76.57% <0%> (ø)
:arrow_up:

src/os_unix.c
57.47% <0%> (+0.04%)
:arrow_up:

src/gui_gtk_x11.c
48.23% <0%> (+0.04%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6ef5f9...8abe64c. Read the comment docs.

included


Memory leak caused by lost references in _key_normalized_obj

The lines in the _key_normalized_obj method which assign a new object to *key cause references to the object to be lost and memory to be leaked. An example follows:
if (PyUnicode_Check(*key)) {
    *key = PyUnicode_AsUTF8String(*key);
    if (*key == NULL)
        return 0;
}

If the caller of _key_normalized_obj decrements the reference returned in key, the object passed in as the initial value of *key will not be decremented. If the caller does not decrement the object reference count, then any object allocated inside of _key_normalized_obj will be leaked. The only way this method doesn't seem to lose an object reference is if a bytes (or an invalid object) is passed in and the length is less than the maximum allowed.

Does this fix the problem?

Also e3d9871

That does fix the leaks in that method, but there are others in callers of that method which are non-obvious due to the method's interface (in my opinion). Many callers of _key_normalized_obj aren't releasing the reference returned when a new object is allocated by _key_normalized_obj. PylibMC_Client_get is a good example of this. See below for a simple script which illustrates the memory leak, even with the latest fixes:
import pylibmc
mc = pylibmc.Client(["<IP_ADDRESS>"], binary=True)
while True:
    try:
        mc.get(u'foo')
    except:
        pass

I would consider changing _key_normalized_obj to return a PyObject*, with a new reference and require the caller to release that reference. I think that would lessen the likelihood of memory leaks such as these.

Oh, I see the problem.

Hm, now that I think about it I disagree again.

After spending a couple of hours on hunting down these memory leaks, I think I fixed most of them for now. Will have to revisit before next release, and put some kind of test in for this.

See d52bfba.

@hfalcic, there were a lot of memory leaks in the Python 3.x unicode-str bridge stuff! What gives?

Any idea when an official release with these fixes will be up on pypi?

Soon! I want to do some testing first though, I'd like to have a tool to do it actually, as part of the test suite.

Ludvig (phone)

On 19 maj 2015, at 01:13, joshuahlang<EMAIL_ADDRESS>wrote:
Any idea when an official release with these fixes will be up on pypi?
—
Reply to this email directly or view it on GitHub.

This has been released. :smile:


Add depth to 3D contours and isosurfaces

This is a continuation of https://github.com/JuliaPlots/GLMakie.jl/pull/188. I added the option to compile with or without the correct depth via enable_depth and I added a refimage test. Currently the depth calculations are on my default.

Merged in #1393


Language selector of aaapy doesn't work

Bug Report
Description
I found a small bug though. The language selector doesn't work for x86 and Scratch doesn't work.
Steps to Reproduce
Steps to reproduce the behavior:

Go to https://aaapy.herokuapp.com
Click on the FFT Chapter
Select either x86-64 Assembler or Scratch
Nothing Happens

Expected behavior
The language displayed should switch to the selected one.
For Algorithm Archive Developers

[x] The bug can be reproduced
[x] The bug can be fixed (if not, please explain why not in a comment below)
[ ] There is a timeline to fix the bug
[ ] The bug has been fixed (Please link the PR)

I have successfully reproduced this bug, will try to fix it for asm.

ASM is working correctly now, Scratch fix left.

Strangely, the page renderer outputs the Julia code for Scratch.

This is what the current implementation does too, so I believe you should send a bug report to the upstream.
Closing.


Cloning of Input Documents

First of, thanks for the great work.
I am wondering why the API of embed takes ownership of the texts vector instead of borrowing it. I tried it locally and it works just as well with a reference which removes the need of cloning as well.
https://github.com/Anush008/fastembed-rs/blob/044f3eb0d7e91f56b31b79dc714b4fb67fa58684/src/text_embedding.rs#L225

Hi @smelm. Thanks for raising this issue.
Unfortunately, switching now will be a breaking change.


Visual treatment of the icon indicating the reason for disablement

Testing #127368
I realized that because the icon is "disabled" I would not have hovered over the icons indicating the reason for disablement in the extension view if the test plan item would not have told me to. Also, in the details editor this piece of information is important but is presented in a subdued fashion. This is less of an issue for non-built-in extension since they have buttons for enabling/disabling.

It's also strange that I can actually click the disabled icons and get a visual click response.

@misolori Any recommendations?

First step - changed the info/warning icon from disabled to enabled mode

What about adding the warning/info colors on the icon? We do that in the terminal and it looks good.

Good idea. Updated


Add preset stolperstein with deprecations and memorial:addr field

Recently the wiki page https://wiki.openstreetmap.org/wiki/DE:Stolpersteine was updated which resolved a few of the blockers I saw in #318.
Preset

The fields are split of from the regular memorial preset in order to now show the material on the Stolperstein Preset which always brass AFAIK and none of the wiki pages does recommend it
The name "Memorial Plaque Stolperstein" is meant to be descriptive for other language users. I think the German translations should just be "Stolperstein"
I did not add a ref pr memorial:ref field because again, the wiki/community is not clear on what to use but mainly there is no current usage of either in Taginfo
I did not add those person:date_of_birth fields because I did not want to research how to add custom date fields but also I think those special fields can be added with the "Tags" area in iD when users want to…
Info-i: Nothing to do here; the wiki and wikidata is present https://wiki.openstreetmap.org/wiki/Tag:memorial%3Dstolperstein

memorial:addr field

TODO: Lets see if this works in the branch preview…
The wiki and talk page are not clear on which tag to use, so I added both "address" and "memorial:addr". At least for the new tagging of memorial=stolperstein all users agreed to use "memorial:addr" (Taginfo)
The wiki is not clear on which address, so I took a risk here and clarified as "Nearest building address" which is the only think that makes sense IMO because we map what we see in OSM. Research tasks like "where did this person live" can be recorded on the Wikidata item. It is also what makes sense for the completeness-verification process that is described on the wiki.
I only added the subkeys that are most often used https://taginfo.openstreetmap.org/search?q=memorial%3Aaddr#keys but also described as importent on the wiki
Info-i: There is no wiki page (Search) but there is an empty Wiki data item https://wiki.openstreetmap.org/wiki/Item:Q1507

deprecations

The wiki is now pretty clear about the update path for memorial:type (usage 25k with a bit of double tagging)
And it makes sense to also update the core info from memorial:text at the same time (usage 21k)

Regional preset?
In https://github.com/openstreetmap/id-tagging-schema/issues/318#issuecomment-1015287842 we talked about making this a regional preset or not. The wiki page on which countries/cities have Stolpersteine (https://de.wikipedia.org/wiki/Liste_der_Orte_mit_Stolpersteinen) is quite long.
Given this long list, I think we should either make it a regional preset for just the top 3 countries … or keep it as a general preset.
TODOs

[x] Check address-field ==> Works great
[ ] Later: Add info on address-wikidata item
[ ] Resolve regional preset
[ ] Where does the empty "wikipedia" field come from? / how to remove it? It is not part of the preset…

Closes https://github.com/openstreetmap/id-tagging-schema/issues/318

Testing

https://pr-964--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=n6879076451&locale=en&map=22.00/52.47629/13.44686 is a good place to test the preset
https://pr-964--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=n10982639457&map=20.00/52.46499/13.33045 can be used to test the deprecations (https://overpass-turbo.eu/s/1xN9)

@tyrasd ready to review. Please have a look at the todo list above for your input. 🙏

Thanks for your feedback & help @tyrasd. This is ready for review again.

Regional Preset

Given that there are (logically) very few exceptions outside of Europe, maybe limiting the scope to Europe (code Q46) would be reasonable.

Good idea! I added it like that in https://github.com/tordans/id-tagging-schema/commit/8e90f9954fa716e6df3bece0af461e1bd4731462

At least for the new tagging of memorial=stolperstein all users agreed to use memorial:addr

But the wiki page recommends to put the full address as a string into memorial:addr=… and that also seems to be more common than using the address subtags. 🤷 🤔

OMG this tagging is so unfortunate…
I tried adding both variants and make it that the UI picks the right one based on existing tags. However, the type:address  does not allow other tags that addr:* (it does not automatically use a different prefix), so that was a dead end.
Now, there is just an optional (moreFields) address string field…

Where does the empty "wikipedia" field come from? / how to remove it? It is not part of the preset…

This is the behaviour of the wikidata field type: It automatically tries to sync a matching wikipedia page for wikidata entries, adding the field for the wikipedia entry. This does of course not make all too much sense for wikidata entries which don't have a corresponding wikipedia entry. This must be fixed on iD's side, however.

I think that is fine for now…

@tyrasd thanks for the help with the *addr* part. I changed it to use the street instead of housenumber since that is a good fit as well and a bit more broad IMO.
I looked at the data https://overpass-turbo.eu/s/1z4c and Hamburg uses this schema a lot, so it is worth adding…

Testcase
https://pr-964--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=n2652126042&locale=en&map=19.00/53.57327/10.03401

First update the tags
Now the address-fields show up (because now the Stolpersteine preset is active)

@tyrasd this is ready to be merged IMO


Checkbox: only update state if change was not cancelled

This change: (check at least one)

[x] Adds a new feature
[ ] Fixes a bug
[ ] Improves maintainability
[ ] Improves documentation
[ ] Is a release activity

Is this a breaking change? (check one)

[ ] Yes
[x] No

Is the: (complete all)

[x] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
[x] Test suite(s) passing?
[x] Code coverage maximal?
[ ] Changeset added?
[ ] Component status page up to date?

What does this change address?
This solves an issue I have where I want to prevent the change event in the consumer and allow the consumer to decide whether or not to accept the change.
How does this change work?
To facilitate that I made the change event cancelable and only apply the changes to the local state if the event was not prevented.
Additional context
a gotcha that could effect this is:
given an unchecked checkbox, onclick; if consumers were expecting event.target.checked to be true that will no longer be the case. This Boolean will be swapped and will behave as a toggle.

@chrisjbrown that's a good point about the order of events leading to a change in behavior...how do native elements behave here?

@chrisjbrown that's a good point about the order of events leading to a change in behavior...how do native elements behave here?

natively seems be the other way 😕
so perhaps i've missed something here

That makes sense I guess, and means that the native event does change the element's state but still allows it to be canceled (and therefore undone). Could we update the state first, but set it back if it gets canceled?

That makes sense I guess, and means that the native event does change the element's state but still allows it to be canceled (and therefore undone). Could we update the state first, but set it back if it gets canceled?

I was thinking the same. But event.target is a reference to the dom object and it becomes kinda unclear what's going on when the 'checked' value is true before the prevent default  and false after
Still looking for a better solution

this latest change works for my needs. and i don't think would be a breaking change for others... 🤔
I don't love it's kinda confusing... but not sure i have any better ideas

@chrisjbrown I think this makes sense to me; can you give an example of the expected usage on the consumer?

sure thing.
Consumers who do not preventDefault() will see no difference other than the addition of the event.detail.target
Consumers who do preventDefault() will see that that as soon as preventDefault() is called the pharos-checkbox will not be checked (or vice versa depending on it's original state).
Either way a new property will be available on the change Event in the form of event.detail.target which will refer to the original native checkbox should the consumer need to access it.


Logo Design Contribution Proposal

Hi,
I am a graphic designer.  I support the open source community with design contributions. I have made design contributions to different projects before. You can view my works from my profile. I can design a logo for BookStore if you need it.

We will gladly accept your contribution , submit a pull request and we will review your work .


Exception occurs when user doesn't add onListen prop

There is no check to ensure that the user has supplied an onListen function, and attempts to call it.
https://github.com/justinmc/react-audio-player/blob/master/src/index.jsx#L90

Hmm. Just looked at source, and it's there...but it still occurs. Does the version in npm need to be bumped?

I just bumped the npm version and republished.  Let me know if that fixes it.  Otherwise I'll try to reproduce this later.

Thanks, I'll give it a try when I get home.

This isn't happening for me with the latest version.  I checked the history and indeed I merged a recent PR that fixed this: https://github.com/justinmc/react-audio-player/commit/6ca06909c5a12b979a59886472c1086aaf0be5eb
Closing, but let me know if updating doesn't fix it for you.

Yup, it fixed it. Thanks for the fix!!


Shortcuts using the Mouse

Description of the new feature / enhancement
I propose that Power Toys enable shortcuts from the mouse.
Simple shortcuts like back, copy, paste, navigate forward, reload, open in new tab, all through mouse gestures, whether by pressing the left or right button or both.
The proposed model would be similar to the extension.
CrxMouse Chrome™ Gestures
Scenario when this would be used?
Introducing mouse shortcuts as a feature in Power Toys would greatly enhance user productivity and streamline various tasks. This feature would allow users to perform common actions such as navigating backward, copying, pasting, navigating forward, reloading, and opening in a new tab through mouse gestures. The proposed model for this feature would be similar to the functionality provided by the "CrxMouse Chrome™ Gestures" extension available on the Chrome Web Store.
By incorporating mouse shortcuts into Power Toys, users would be able to reduce their reliance on the keyboard and perform actions directly from their mouse. For instance, they could easily go back to the previous folder by dragging the mouse to the left while holding down the left mouse button. Similarly, they could reload a folder with a specific movement, eliminating the need to open the context menu and search for the refresh option.
Moreover, the potential for enhancing certain functions by performing an Internet search of the selected term through a mouse gesture opens up numerous possibilities. This feature could significantly improve efficiency and convenience for users, allowing them to accomplish tasks more seamlessly.
In conclusion, implementing mouse shortcuts within Power Toys would empower users to optimize their workflow, minimize keyboard usage, and execute actions efficiently through intuitive mouse gestures. This addition has the potential to greatly enhance the overall user experience and productivity.
Supporting information
This extension summarizes well, but unlike it, it would be beyond the browser.
CrxMouse Chrome™ Gestures

Duplicate of #19041

/dup https://github.com/microsoft/PowerToys/issues/19041


[CT-3019] TestShow::test_numeric_values, TestShow::test_numeric_values_with_nulls are flaky

Full path: tests/functional/show/test_show.py::TestShow::test_numeric_values
Examples of flakiness:

Integration tests during 1.6.1 release
Integration tests during backport to 1.6.latest

Note: Thus far I've only seen this on branch 1.6.latest

This flaked on the nightly release test that runs off main https://github.com/dbt-labs/dbt-core/actions/runs/6122803796/job/16619476620

Tests still consistently fail on all releases on main and 1.6.latest.
More details on slack


Basicviz Experiment model

changes to this model mean that is not possible now to use get_or_create (at least when it has to create). Still possible to create by:
e = Experiment()
stuff
e.save()
Any ideas?

It's awkward, but probably best not to touch it for now.


Encryption password

Proceed button is being enabled even on weak passwords.

No encryption option for now in 2.0.75


LimeQuickTest issues

I feel like some sort of check should be added to LimeQuickTest to ensure a device is connected.
Right now I get the following outputs:
No device connected.
[ TESTING STARTED ]
->Start time: Fri Oct  5 19:22:46 2018

Listening on port: 5000
Started listening thread
connect failed with error: -1
connect failed with error: -1
connect failed with error: -1
connect failed with error: -1
->Device: Remote, media=TCP, module=Z_Remote
Warning: USB3 not available
  Serial Number:
connect failed with error: -1
connect failed with error: -1
Failed to connect

Device connected (Only 1 device donnected!)
[ TESTING STARTED ]
->Start time: Fri Oct  5 19:24:50 2018

Error: Multiple Devices Connected
Failed to connect

LimeQuickTest wants only one connection to be present. It seems you have ConnectionRemote enabled that always adds one connection to the list. It was introduced for debugging/testing purposes and should be disabled in normal build.

Is that STREAM_UNITE?

You should disable ENABLE_REMOTE

LimeQuickTest should now connect the first device instead of failing when more than one possible connection is detected (1bfa380aeb7d3d08f6e7341911095da9fae886fb). This makes it possible to still run LimeQuickTest with ConnectionRemote enabled ('ENABLE_REMOTE').


No message is generated for component create command with -o json flag

[kind/bug]

What versions of software are you using?

Operating System: All
Output of odo version: Master

How did you run odo exactly?
$ odo component create python -o json
$
// i am expecting json format output or an error message if it is not supported

$ odo component create python -o json
{
    "kind": "Error",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "message": "this directory already contains a component"
}
// looks good

Actual behavior
No display of output message
Expected behavior
Json format output or an error message if it is not supported
Any logs, error output, etc?

/kind bug

successfully reproduced.
would a message like be shown the user?
{
    "kind": "Success",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "message": "Please use `odo push` command to create the component with source deployed"
}

i.e. the final message produced by the cli when -o json is not provided?

successfully reproduced.
would a message like be shown the user?
{
    "kind": "Success",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "message": "Please use `odo push` command to create the component with source deployed"
}

i.e. the final message produced by the cli when -o json is not provided?

Nope. If the operation is successful it should return what was created. So, in this case, the output should be the same as odo component describe -o json

@kadel
For odo component describe -o json to work, you actually have to push the component.
See below:
▶ odo component describe -o json
{
    "kind": "Error",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "message": "component nodejs-nodejs-ex-geah not pushed to the OpenShift cluster, use `odo push` to deploy the component"
}

So in theory, we're unable to actually output everything to the user after using odo create -o json since odo describe uses this function:
https://github.com/openshift/odo/blob/master/pkg/odo/cli/component/describe.go#L72
Which requires ports to be available to get it..
Which I was hoping to simply drop into the create.go file.
This opens up another issue, we can't actually use odo describe without the component being pushed, should we remove the GetPorts() all-together?
https://github.com/openshift/odo/blob/master/pkg/odo/cli/component/describe.go#L72

/priority medium

For odo component describe -o json to work, you actually have to push the component.

Not anymore. This PR https://github.com/openshift/odo/pull/2399 implemented odo describe even for not pushed components.
/kind feature
/remove-kind bug
/priority high
This is not a bug, but something that was not yet implemented.

https://github.com/openshift/odo/pull/2532


support folia

support folia plz ;-)
your plugins helps me alot

i agree!
also, William is legend for creating this

Is there any news now?


Attempt #1 to fix heroku

bypassing protection - don't have a presentation without this so considering it an emergency.


Added 'nb_features' directly in the hdf file for lazy access

Hello @EmmaRenauld! Thanks for opening this PR.

In the file dwi_ml/data/dataset/utils.py:

Line 30:19: E127 continuation line over-indented for visual indent

In the file tests/test_multisubjectdataset_creation_from_hdf5.py:

Line 48:80: E501 line too long (88 > 79 characters)

Do see the PEP 8 -- Style Guide for Python Code


Update docs build

This is a WIP to update the docs build to use a Read the Docs v2 config file. I was originally intending just to fix issue #693 but it turns out that RTD is building on Python 3.7 for which quite a few of the dependencies are a bit old and no longer updated. So this is updating the docs build system to follow a similar approach to fsspec and to fix a variety of doc-related issues at the same time.

It seems that in order to test this we would need to alter the RTD Advanced Settings to build on PRs and not just commits to main branch.

it turns out that RTD is building on Python 3.7

With the conda env option, we can pick our python version, no?

I have enabled PR builds in RTD

With the conda env option, we can pick our python version, no?

Yes, we can specify it in the docs/environment.yml that we tell RTD to use.

Oh, but I do remember that conda (as opposed to mamba) was using a lot of memory and crashing RTD builds at some point.

Oh, but I do remember that conda (as opposed to mamba) was using a lot of memory and crashing RTD builds at some point.

OK, we'll see what happens.

RTD hasn't automatically built the docs for this, presumably because the PR had already been created. I'll close this and create another PR to see if that works.


Fix runtime args for iterative warping runner

This PR has the following fixes:

Added .gitignore to ignore common Python extensions and files that should not be included in commits
cv2.VideoWriter_fourcc has a warning recommending lowercasing the mp4v code, which is now done.
The app.py did not take the output FPS parameter from the Gradio app when writing the output video, which is now fixed.
The iterative warping runner had some hyperparameters set without using the args. This would result in shape errors for the tensors if the number of output frames is not 16. Also, the mask size of the dilation masks, and the kernel size do not change when varying those parameters in the Gradio app.

Thanks for your great efforts! @rayryeng We sincerely appreciate it!


HADOOP-19114. Upgrade to commons-compress 1.26.1 due to CVEs. (#6636)

This addresses two CVEs triggered by malformed archives
Important: Denial of Service CVE-2024-25710
Moderate: Denial of Service CVE-2024-26308
Contributed by PJ Fanning

Description of PR
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.4 Compile Tests _

+0 :ok:
mvndep
4m  9s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
40m 23s

branch-3.4 passed

+1 :green_heart:
compile
17m  9s

branch-3.4 passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
16m  2s

branch-3.4 passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
4m 25s

branch-3.4 passed

+1 :green_heart:
mvnsite
20m 59s

branch-3.4 passed

+1 :green_heart:
javadoc
8m 36s

branch-3.4 passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
7m 55s

branch-3.4 passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+0 :ok:
spotbugs
0m 21s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

-1 :x:
spotbugs
31m 13s
/branch-spotbugs-root-warnings.html
root in branch-3.4 has 4 extant spotbugs warnings.

+1 :green_heart:
shadedclient
34m 25s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 34s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
30m 58s

the patch passed

+1 :green_heart:
compile
18m 18s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
18m 18s

the patch passed

+1 :green_heart:
compile
16m 36s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
16m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 57s

the patch passed

+1 :green_heart:
mvnsite
17m 59s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
8m 16s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
7m 42s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+0 :ok:
spotbugs
0m 17s

hadoop-project has no data from spotbugs

+1 :green_heart:
shadedclient
69m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
787m 12s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 45s

The patch does not generate ASF License warnings.

1167m 41s

Reason
Tests

Failed junit tests
hadoop.hdfs.protocol.TestBlockListAsLongs

hadoop.hdfs.TestLeaseRecoveryStriped

hadoop.hdfs.TestEncryptedTransfer

hadoop.hdfs.server.datanode.TestLargeBlockReport

hadoop.hdfs.TestErasureCodingPolicies

hadoop.hdfs.TestDFSStripedOutputStreamWithFailure

hadoop.hdfs.TestReconstructStripedFile

hadoop.hdfs.server.balancer.TestBalancerRPCDelay

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6867/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6867

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs

uname
Linux 31ce0bd39bb5 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.4 / 075e7331f08c7b8420820e1270513d159bb383f2

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6867/1/testReport/

Max. process+thread count
3854 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6867/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

done. FWIW I'm thinking we should push out a 3.3.9 release this summer. shall we include this here? doing a full update of those dependencies we can upgrade seems wise


chore: expand the widget so that the cell edit icon is visible

Description
Fix expand the widget so that the cell edit icon is visible
Type of change

Chore (housekeeping or task changes that don't impact user perception)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test sha=chore/one-click-binding-review-callouts-new

/ok-to-test sha=3b0208f555ee2f004aa7fdb68fb329e537b94c95

/ok-to-test sha=16c9ba6adf926dd07184f3c0e1fa2f9e14f301c3

/ok-to-test sha=12e36cafc2baef5bb8d46743f4eb396f63d31e9f

/ok-to-test sha=86d45baa269312668e6f4634ab950af38a92afb4

/ok-to-test sha=2d464456041e37507baafca12772f03d754f180f


Enable compression

I'm using this for a website and now I am getting dinged by Google PageSpeed Insights. Is there any way to enable compression?

What sort of compression?

Aka what is it that needs to be compressed?

Google recommends Gzip compressing https://feedrapp.herokuapp.com/…og.nextgen.com%2Ffeed%2F&_=1484751162688. This could save 11.5KiB (63% reduction).

Guess that makes sense :)

@sdepold any updates on how to compress this?

Added this today :)


Filter trainees by "ready to be badged" status

On the "Trainees" page, we'd like "Is SWC Instructor?" and "Is DC Instructor?" to have one more option each: "Eligible".  This would filter by people who have fulfilled requirements, but do not yet have the badge.  I know we can calculate this (it's what turns their marker green), and it would be very helpful when one person is marking completion of work and another is issuing badges.

@gvwilson, what about combining "is SWC instructor" and "is DC instructor" filters into one choice filter with the following options:

Unknown
SWC and DC instructor
SWC or DC instructor
SWC instructor
DC instructor
Eligible to be certified (SWC or DC)
Not an instructor

Italic choices are combinations that you can't achieve having two separated fields.

PR #1026 (without merging "is SWC instructor" and "is DC instructor" fields).

Looks good to me - only question is, what is "Unknown"?  Does it mean
"don't care"?  (If AMY doesn't know, who does?)

Looks good to me

Do you mean the PR or the idea of merging "is SWC instructor" and "is DC instructor" filters?

only question is, what is "Unknown"?  Does it mean "don't care"?  (If AMY doesn't know, who does?)

Yes, it means "include every person regardless of their instructor status".

OK, "Unknown" probably isn't the right word (it means "we don't know"
rather than "we don't care").

OK, "Unknown" probably isn't the right word (it means "we don't know" rather than "we don't care").

I agree, but on the other side, we use "unknown" in all places where there is BooleanFilter or ChoiceFilter and nobody has reported that it's confusing. If we want to change it, we should change it in all filters at once.

OK, let's make it "Unknown" and I'll file a PR to come up with a better
word.

I've updated the PR so that the two filters are merged into the one that I proposed.

Ready for review?

Yes.

@narayanaditya95 , could you review?


fixed WOQL.post function

fixes #117

Is this PR ready? Or is it waiting on fixes to the server?

It is waiting for fixes on server

Yay, thanks!!


Australia missing death, and recoveries information Level: Country

Original issue https://github.com/covidatlas/coronadatascraper/issues/877, transferred here on Wednesday Apr 22, 2020 at 20:25 GMT

Location, date, and short issue description

Source

File

Issue details

Snippet/screenshot
<!-- If you can, please include a snippet of the file here, or a screenshot, to help us find it.-->

Additional context

(Transferred comment)
Last report for this data was 3/27


Add fuzzer for RowNumber operator

The RowNumberFuzzer is a testing tool that automatically generates equivalent
query plans and then execute these plans to validate the consistency of the results.
It works as follows:

Data Generation: It starts by generating a random set of input data, also known as a vector.
This data can have a variety of encodings and data layouts to ensure thorough testing.
Plan Generation: Generate two equivalent query plans, one is row-number over ValuesNode
and the other is over TableScanNode.
Query Execution: Executes those equivalent query plans using the generated data and asserts
that the results are consistent across different plans.
Iteration: This process is repeated multiple times to ensure reliability and robustness.

@mbasmanova @xiaoxmeng  I've updated the PR description, resolved all the comments, and added supporting of RowNumber in both DuckDbQueryRunner and PrestoQueryRunner. Could you please help take another look? Thanks.

@duanmeng Thank you for updating PR description.

Plan Generation: Generate a variety of logically equivalent query plans.

This is a bit generic statement and it creates an impression of the Fuzzer creating many plans, but in fact it only creates 2 plans: row-number over ValuesNode and over TableScanNode. It would be nice to make this clear both in PR description and documentation.

@duanmeng Thank you for updating PR description.

Plan Generation: Generate a variety of logically equivalent query plans.

This is a bit generic statement and it creates an impression of the Fuzzer creating many plans, but in fact it only creates 2 plans: row-number over ValuesNode and over TableScanNode. It would be nice to make this clear both in PR description and documentation.

@mbasmanova I've updated the PR description and document according to your guidance.

@duanmeng Thanks.


Allow decoupling of dropwizard and joda-time

I'm starting a new dropwizard project and would like to use the new java8 time library instead of joda-time.  I tried excluding joda-time from the dropwizard dependencies:
io.dropwizard:dropwizard-core -> io.dropwizard:dropwizard-util -> joda-time:joda-time
AND
io.dropwizard:dropwizard-core ->  io.dropwizard:dropwizard-jackson -> com.fasterxml.jackson.datatype:jackson-datatype-joda -> joda-time:joda-time
...but I get CNFEs at runtime, becase Bootstrap.java calls Jackson.newObjectMapper() which has a hard dependency on JodaModule which depends on joda.
Ideally I'd be able to specify my own ObjectMapper in the application so I can avoid that code path entirely, and safely be able to exclude joda-time.  Thoughts?  If I start down the path of making a PR to allow this, would it be accepted?

Take a look at #1112. Would it cover your use case? It's available only in unreleased 0.9.0, though.

Can you use the dropwizard-java8?

@nickbabcock I'm already using dropwizard-java8 (it's great!) but it doesn't solve this problem.
@arteam #1112 looks like it would almost work.  Main issue is that I'd need to avoid that constructor call to Jackson.newObjectMapper() entirely (presumably by implementing a ProvidesCustomObjectMapper interface on the Application that's passed into Bootstrap's constructor).

@arteam does that approach sound ok?  Any preference on what that ProvidesCustomObjectMapper interface's name?  Once I get the go-ahead I don't mind writing up the PR.

Oh, I now see the issue.
I think that changing Application it not a very good option, because then we will have two places where we can set a custom ObjectMapper, which is confusing.
I'm more inclined to the idea of lazy loading of the mapper. We could mark the objectMapper field in Bootstrap as volatile and  load it on demand in the getter. In this case we will avoid NoClassDefFoundError if Joda-Time is not present in the classpath and will have one place, where users can provide a custom mapper. What do you think about this approach?

To be honest I'm not a big fan of decoupling Joda-Time (or any other of the "core" libraries) and Dropwizard.
The idea of Dropwizard is to have a fixed set of good libraries tightly integrated to simplify the creation of opinionated RESTful services. Adding abstraction layers around all core libraries (e. g. Joda-Time, Jersey, or Jetty) is a lot of work and frankly contradicts the "Dropwizard mantra".

I would concur, but actually we don't have a compile-time dependency on Joda-Time. We just import it for users' convenience and automatically configure JSON serialization/deserialization. Bearing in mind the fact that there is a viable alternative shipped with JDK 8, I think we should allow users not to import Joda-Time, if they don't want to.

If we're being opinionated, then maybe the answer to all of this is to just get rid of Joda-Time entirely in 2.0.  Force people to upgrade to java8 time (if the creator of Joda thinks the java8 stuff is better, I believe him).  Or at least remove the hard joda-time dependency and allow people to add the dependency themselves if they really really don't want to migrate?

That's actually is not a bad idea for 1.0 version, which will target Java 8.

My suggestion would be to improve configuration so that set of modules to register with Jackson would be determined dynamically from boostrapped Configuration.
That is: initialization of things would use a bare-bones Jackson ObjectMapper, with minimal set of modules (possibly none), to read in Configuration (and not sub-type specified by Application), ignoring unknown properties.
Based on core configuration information, bootstrap process would construct "full" ObjectMapper, allowing users to specify additional modules, and/or remove other ones.
It would also be possible, if so desired, to handle basic logging configuration and initialization at this point, just to improve troubleshooting (before logging is initialized, things are bit opaque). But very little else should occur at this point.
Fully configured mapper would then be used to re-bind the input configuration file; allowing use of all kinds of additional datatypes as per configuration.
This way it would be simple to change the set of datatype modules registered, as well as any other extensions; and do it fully declaratively. One can still do explicit changes above and beyond declarative stage; this would not change overridability.
One side-benefit of such separation is to make bootstrapping process even more stable: as useful as modules like Afterburner are, they also add potential breakage points.
I have hoped to work on this idea for a while, but unfortunately haven't had much time. I thought I'll mention it nonetheless in case anyone else found this interesting.

Is this still an issue in the current 1.0.0 code now that we've integrated dropwizard-java8 into the core?  The usage of Joda Time is now optional.

True, but we still import Joda-Time and register its support as a Jackson module. In the end, we took a pragmatic approach and will support Joda-Time and JSR-310 simultaneously in 1.0.0. See #1365.

I'm going to close this out for now.


Change styled-components -> tailwindcss

For #42, which no longer allows css-in-html, and so is incompatible with styled-components
https://tailwindcss.com/docs

Those commits implement all of the primary changes. Everything works, except the division of the main useEffect call into three handles with two of them calling append("g") causes those to constantly overdraw each time the selector is activated, rather than redrawing. Just  need to fix that ...

That's done, now just have to tweak the axis appearance to extend the tick lines all the way up the plot as a reference grid (and make the lines lighter).

Now just have to adjust range of plots, because some of the bars extend all the way to the right side. Need to increase the margin there

Finally re-opening to remove tailwindcss entirely, and just call the d3 attributes directly...


Newest version doesn't work with my Parameterized URL

I have this route: /domain/1
I'm using this code:
`var router = new Navigo(root = null, useHash = false);
    router.on({
        '/domain/:id': function (params) {
            $.ajax({
                type: 'GET',
                url: '/domain/' + "1" + '/json/get-records',
                datatype: "json",
                contentType: "application/json charset=utf-8",
                success: function (data) {
                    //domain.records(data[0].fields);
                }
            }).always(function () {
                //website.loading_columns(false);
            });
        }
    }).resolve();`

But it simply doesn't run that ajax call. I tried an older version I still have on my computer and that code does work pretty fine. (https://dr0p.it/9lk_)
What am I doing wrong?

Can you try without a slash in front - domain/:id. Or maybe set the root to /.

With root = null
/domain/:id and domain/:id doesn't work
With root = /
/domain/:id doesn't work
domain/:id works!
Thank you :+1:


Potential case-insensitive import collision: import path should be "github.com/unknwon/com", not "github.com/Unknwon/com"

Background
The repo github.com/Unknwon/com already renamed to github.com/unknwon/com in the version v1.0.0.
https://github.com/unknwon/com/blob/v1.0.0/example_test.go
package com_test
import (
	"github.com/unknwon/com"
	…
)

The github.com/Unknwon/com is the old path, any repos using it should be updated to import and require github.com/unknwon/com. Or this may take some potential problems.
Solution
Replace all the import paths, change "github.com/Unknwon/com" to "github.com/unknwon/com".
Where did you import it: https://github.com/rai-project/mlmodelscope/search?q=github.com%2FUnknwon%2Fcom&unscoped_q=github.com%2FUnknwon%2Fcom

@abduld  @yhchang3  Could you help me review this issue? Thx :p


[Bug]: App crashes when exploring a tab widget

Is there an existing issue for this?

[X] I have searched the existing issues

Description
App crashes when trying to explore/add widgets to a tab widget on a specific tab of an app.
Unable to repro the exact scenario since I don't know how the app ended up in this state.
Steps To Reproduce

Navigate to the app here  and try to add widgets to the tab widget or use the entity explorer to look at child widgets and observe the app crash

Linking app JSON to repro on prod
crash.zip
Public Sample App
No response
Issue video log
https://www.loom.com/share/b66b6e98a0314010800d8ce09499637e
Version
Cloud

@dhruvikn can you find why is this happening?

On it.

There seems to be Listv2 inside the Tab widget. @ramsaptami You might have used this Application to test Listv2 , since the widget is not available in release,hence the unexpected behaviour
cc: @dilippitchika @somangshu @dhruvikn

@dilippitchika We can close this

@kamakshibhat-appsmith you're right, I did use this app during our bug bash, my bad!