Support for python 3.10

Hi,
I have noticed that there were some commits that solved problems with python 3.10, are there any plans to make release with python 3.10 support?
It is the only package that stops us from migration to 3.10, I would be thankful for any ETA.

Hi,
We are also interested in Python 3.10 support. All of our development was under 3.10 so far, but just because of this package seems like we will be forced to move back to 3.9. Would be good to know ETA to make an informed decision.

you only need to change the imports i guess, should work then.

you only need to change the imports i guess, should work then.

could you elaborate?

you only need to change the imports i guess, should work then.

could you elaborate?

For others who may be wondering, the imports that need to be fixed for python 3.10+ are the import collections calls.  They need to be replaced with one of the following, depending on the module:
from collections.abc import Mapping
form collections.abc import Sequence
from collections.abc import Iterable
from collections.abc import Sized
and the subsequent references to those imported classes need to be updated as well.  This was already done in 8fe225b but the changes have not been pushed to pypi.
You can install the updated package by running pip install git+https://github.com/ni/nixnet-python@8fe225b to install from source after the commit that fixed the issue.


Wrong API endpoint of existing default config file is kept

Describe the bug
Using Epinio-0.0.24 on linux. If there's a config file from a previous install already, e.g. ~/.config/epinio/config.yaml - epinio install will read that file, and use the previous configured API endpoint, even if the system domain will change.
To Reproduce
Have a pre existing ~/.config/epinio/config.yaml config file - e.g. from "install=>uninstall" procedure.
Make sure the Traefik Ingress info (traefik public IP) will differ for the next installation (if you always get the same IP, you could change the former one in the config file, to see the effect later).

Install Epinio with epinio install (e.g. getting Traefik Ingress info: [{"ip":"<IP_ADDRESS>"}])
Uninstall Epinio with epinio uninstall
Install Epinio with epinio install (e.g. getting Traefik Ingress info: [{"ip":"<IP_ADDRESS>"}])
See Epinio picking up a new external IP (e.g. Traefik Ingress info: [{"ip":"<IP_ADDRESS>"}]), and later fail with
e.g. 🚢 Retrying (0/10) after Post "https://epinio.<IP_ADDRESS>.omg.howdoi.website/api/v1/namespaces": dial tcp <IP_ADDRESS>:443: i/o timeout, which is the old API endpoint.

Expected behavior
Since finally Epinio will rewrite the default config file with the current API endpoint information, I'd expected that it will not read, or keep the existing value from the default config file, when running a plain epinio install.
Logs
existing "~/.config/epinio/config.yaml":
api: https://epinio.<IP_ADDRESS>.omg.howdoi.website
certs: |
  -----BEGIN CERTIFICATE-----
********
  -----END CERTIFICATE-----
colors: true
epinio_protocol: http
epinio_workloads_namespace: epinio-workloads
epinio_ws_protocol: ws
gitea_namespace: gitea
gitea_protocol: http
namespace: ""
org: workspace
pass: ********
user: ********
wss: wss://epinio.<IP_ADDRESS>.omg.howdoi.website

Output from epinio install:
> ./epinio install

🚢 Epinio v0.0.24 installing...

Configuration...
  🧭  skip-traefik: false
  🧭  skip-linkerd: false
  🧭  skip-cert-manager: false
  🧭  system_domain:
  🧭  email_address<EMAIL_ADDRESS>  🧭  user: 082338fdc859745b
  🧭  password: eb21266ce034e7b9
  🧭  tls-issuer: epinio-ca
  🧭  use-internal-registry-node-port: true
  🧭  loadbalancer-ip:

🚢 Deploying Linkerd...
✔  Linkerd deployed

🚢 Deploying Traefik Ingress..........................
✔  Traefik Ingress deployed
.
✔  Using system_domain: <IP_ADDRESS>.omg.howdoi.website

🚢 Deploying Gitea...

🚢 Deploying Tekton...
🚢 Deploying CertManager...
🚢 Deploying ServiceCatalog...🚢 Deploying Registry...
🚢 Deploying Kubed...
🚢 Deploying Epinio...I0907 16:04:15.588976   15287 request.go:655] Throttling request took 1.015143713s, request: POST:https://sebi-ch1l8-sebi-ch1l8h-epin-f416cc-12b10ce2.hcp.eastus.azmk8s.io:443/api/v1/namespaces
............................................................
✔  Kubed deployed
.................................................................................................................................
✔  CertManager deployed
..............................................................
✔  ServiceCatalog deployed
......................
✔  Registry deployed
...................................................
✔  Tekton deployed
..
✔  Epinio deployed
................
✔  Gitea deployed

✔  Epinio installed.
System domain: <IP_ADDRESS>.omg.howdoi.website
API User: 082338fdc859745b
API Password: eb21266ce034e7b9
Traefik Ingress info: [{"ip":"<IP_ADDRESS>"}]

🚢 Updating the stored credentials from the current cluster
Config: /home/paas/.config/epinio/config.yaml

✔  Ok

🚢 Creating namespace...
Name: workspace

🚢 Retrying (0/10) after Post "https://epinio.<IP_ADDRESS>.omg.howdoi.website/api/v1/namespaces": dial tcp <IP_ADDRESS>:443: i/o timeout

Final "~/.config/epinio/config.yaml" after install:
api: https://epinio.<IP_ADDRESS>.omg.howdoi.website
certs: |
  -----BEGIN CERTIFICATE-----
********
  -----END CERTIFICATE-----
colors: true
epinio_protocol: http
epinio_workloads_namespace: epinio-workloads
epinio_ws_protocol: ws
gitea_namespace: gitea
gitea_protocol: http
namespace: ""
org: workspace
pass: ********
user: ********
wss: wss://epinio.<IP_ADDRESS>.omg.howdoi.website

Cluster (please complete the following information):

Provider: AKS
Options: 2 nodes, kubelb
Kubernetes Version: v1.20.9

Desktop/CLI (please complete the following information):

OS: Linux
Epinio Version: 0.0.24
Epinio Install Options: none/default

I am taking this as this may be the cause behind #758 . And even if not, I am already in the guts of the config handling because of that one.

Reading the logs in full now this definitely looks very similar to #758 where a different api url was used in the post-install when the configured domain.


Create new Europe PMC evidence table in rewrite version

On the evidence page in the rewrite, can we please create a new data table that displays the Europe PMC evidence data?
Example GraphQL API query
PTGS2 and asthma (with size:10 argument)
Current implementation
The current production version of the Platform relies on a multi-step process to generate the data table:

Retrieve the PMIDs from our API /evidence endpoint
Retrieve the publication details from Europe PMC's API /search endpoint using the PMIDs from step 1 (example API call)
Use the  tStart, tEnd, dStart, dEnd, section, and text to determine the placement of the blue (target) and yellow (disease) highlighting
Render the publication title, citation, PMID, abstract, year, and other sections (if relevant)

Current production view for PTGS2 and asthma
Data table
My recommendation is that we simplify the text mining representation on the evidence page by only showing the abstract and highlighted text in either the title or abstract.
This is because:

We will soon have access to a new Europe PMC pipeline output, which will change the data structure and could remove the need to make a separate query to the Europe PMC /search API endpoint
Sometimes the highlighting does not work and highlights the incorrect word or is not visible as the positions returned in the evidence string are incorrect
The text in the "other" sections can vary in length (see "Other: 2 matched sentences" for the "Associations between aspirin use and the risk of cancers: a meta-analysis of observational studies." entry on the PTGS2 and asthma evidence page)

To provide some context on what might be coming. @andrewhercules is true a few pieces of the data retrieval might change early next year. However, the relevant content for each evidence would not be too different:

Title - highlighted when appropiate
Publication metadata - author(s), journal, date, PMID, etc.
Abstract - highlighted when appropriate
Other sentences (highlighted) retrieved from the full text article.

I would also revisit the React version of the widget that was implemented last year by @LucaFumis #672. I would anticipate that most of the work is already done.

Makes sense - @javfg can you please revisit the previous version built by Luca in #672 and port to the alpha branch?

Just to be on the safe side, because I'm not sure I understood correctly what we discussed in the meeting: @mkarmona, when you said some matches might not be in the abstract, do you mean they are in the title? Or can they come from other parts of the article?

What's shown in "Other" in the screenshot above are matches in which target and disease co-occur in the same sentence. The section field will tell you where they are in the paper and they might indeed belong to the body of the manuscript. Occasionally, the pipeline might not have access to the full text article. In these cases, all matches will be in the abstract or title.

they might indeed belong to the body of the manuscript

This is what I needed to know. If it is only title/abstract, we could get rid of that 'matches' section altogether, and highlight the title and abstract only.

Can we please make some adjustments to the Europe PMC evidence table?
Table functionality

[ ] By default, only show 5 rows in the table
[ ] Implement the "Rows per page" feature to allow users to set number of rows visible in table

Columns

[ ] Set a smaller max width on the "Publication" column to prevent layout/readability issues

Table content

[ ] Truncate list of authors as some entries have 50+ authors (e.g. BRAF and cardiofaciocutaneous syndrome) - instead, show only the first author and "et al."

This can be achieved using the existing call to the Europe PMC API (sample query). Instead of displaying authorString, please use the authorList.authors array to determine if the publication has more than 1 author. If yes, then use the fullName value and append "et al." (e.g. Bhaumik S et al.)

Once the data is returned sorted by score in descending order - see #1264 - we can reimplement the little bar visualisation that shows the relative strength of the publication and text mining results.

Regarding the above comment:

Truncate list of authors as some entries have 50+ authors (e.g. BRAF and cardiofaciocutaneous syndrome) - instead, show only the first author and "et al."

To increase the information content, we can alternatively allow for a reasonable number of authors and finish with et al. or use "show more". Your call @andrewhercules

[x]  Truncate list of authors as some entries have 50+ authors (e.g. BRAF and cardiofaciocutaneous syndrome) - instead, show only the first author and "et al."

As we discussed in the meeting yesterday, the component will show a given number of authors and a 'show more' button to expand the full list.
In the end, the number of authors shown initially is dynamic and adjusts to the width of the viewport. Let me know if this should change, but fixing it will break small viewports.


macOS: Window menu no longer shows all opened windows

Steps to Reproduce:

have 2 windows opened, e.g. one on vscode and an empty window
quit
start
verify 2 windows open

=> 🐛 the "Window" menu only shows 1 window for me

Since I cannot reproduce with stable, I suspect a possible Electron 25 regression.

Hm, I cannot reproduce with vscode-bisect...

I am unable to repro with latest insiders.

I can repro.

@deepak1556 this requires "workbench.startupEditor": "none" and no editors being opened in both windows. I can reproduce in stable, its not a regression.
I wonder if a title update is needed to make the window update? Because its possible that the title is not set on startup if no editor is opened.

Thanks, I can confirm the behavior now. Yeah if no window title is available then the window seems to be excluded from the menu. Can confirm with a simple electron fiddle.

Even setting the same title does not work, I need to set something like window.document.title = '.';...

The menu is created by the OS and Electron does not control it, the behavior we are seeing for empty title comes from the OS, validated with the following swift app https://gist.github.com/deepak1556/ca6d1e565ba4347568166b1f9cdc785b

To clarify, the window.title is not empty, we always set it even for empty windows:
https://github.com/microsoft/vscode/blob/d95102088a99d81e1bb10a5d2d84997bb72fdd54/src/vs/platform/windows/electron-main/windowImpl.ts#L221

Yeah I can confirm the title being set, and the issue only happens when exiting the application with the empty window, relaunching it. I am unable to repro this scenario with the swift app when Window title is set.

Should I then push a workaround to mutate the title away from the one I have set in the main process as a workaround?

Yeah I think that would be a good workaround and since this only impacts empty window, it is also of low impact fix.

Its somewhat ugly though, the only way how I can fix it is to really put a different title and then the real one. This causes a bit of flicker in the title bar, at least with native title bar style.
Code POC (before this call):
if (!window.document.title && isMacintosh && nativeTitle === this.productService.nameLong) {
   window.document.title = `${nativeTitle}\u2800`;
}

A simple whitespace is not enough!


Place ViroImage perpendicular to floor

Hi, using a vertical ViroARImageMarker i'm trying to place a ViroImage perpendicular to floor but sometimes the image it is not. There is a way to make the image appear always perpendicular to the floor? thanks

Hi @Tamiyadd, take a look at our AR Poster Demo sample to see how to do this. The poster is vertical and the 3Dobject is perpendicular to the floor. -> https://github.com/viromedia/viro/tree/master/js/ARPosterDemo
Rotate the node relative to the image marker e.g.
<ViroNode position={[0, -.1, 0]} scale={[0,0,0]} rotation={[-90, 0, 0]} dragType="FixedToWorld" onDrag={()=>{}} animation={{name:"scaleModel", run:this.state.playAnim,}} >

hi @dam00n i'm using that  code but as you can see from my screenshoot the item is not perpendicular

this is the marker

and this is how the camera get the marker, i've put a copy of the marker in position: {[0,0,0]} so i can see what the camera get

@Tamiyadd can you try another marker and see if you see the same drift. Perhaps the Tesla Marker or another marker in your office as a comparison test? Would like to see if the issue is with the marker or the platform.
Here is ARKit's guidance regarding image markers -> https://developer.apple.com/design/human-interface-guidelines/ios/system-capabilities/augmented-reality/
"Design and display reference images to optimize detection. When you provide reference images, you specify the physical size at which you expect to find those images in the user’s environment. Providing a more precise size measurement helps ARKit detect images faster and provide more accurate estimates of their real-world position. Detection performance and accuracy are best for flat rectangular images with high contrast and bold details. Avoid trying to detect images that appear on reflective or curved real-world surfaces."
If you are able to change your marker, perhaps adding more high contrast and bold details might help?

@dam00n yeah i can confirm that with the example marker the recognition works a lot better!
There is a way to compensate the drift without changing the marker?

Unfortunately there is not much you can do at this time to compensate for the drift besides changing the marker.

@dam00n can i know when an image is exactly on the marker?
because if i can know that i can create a workaround and make the user adjust the rotation using pauseUpdates={false} then lock the correct rotation disabling the updates.
i have also noticed that using transformBehaviors={'BillboardY'} the image stand more perpendicular but it rotate on Y axys, can i prevent that rotation?
thanks

Hi @Tamiyadd,
Unfortunately, ARCore/ARKit don't provide any "confidence" values for you (or us) to determine how "accurate" a match is.
If you want something to be perpendicular to the ground, you can manually listen to onAnchorFound or onAnchorUpdated and set the position/rotation of an object based on the returned Anchor's position and/or rotation. Keep in mind that for rotations, there are multiple combinations of X, Y and Z values that can represent a rotation (rotations aren't "stable" in value).
The use of BillboardY is to make an object rotate about the y-axis to always face the user, so as you move about your world, the object will always follow you. Something you could consider is using the given rotation of the found Image Anchor to compute the projected X-Z rotation and use that rotate the image (after positioning) to make sure the image faces "forward" from the marker.
Let me know if you have any other questions!

Closing this issue due to inactivity. If you are still having issues, please re-open and provide additional comments so we can investigate further. Thanks


(another) cla test pr

don't merge

Hi @dalaro2, thanks for your contribution!
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

You did it @dalaro2!
Thank you for signing the Contribution License Agreement.


pdfs "no results found'

Attach (recommended) or Link to PDF file here: https://gracebaptistottawa.com/parable-of-the-banquet-tract/
Configuration:

Web browser and its version: chrome Version 95.0.4638.69 (Official Build) (x86_64)
Operating system and its version: MacOs Version 11.6
PDF.js version: Version 2.1.4
Is a browser extension: I don't think so

Steps to reproduce the problem:

re-loaded pdfs
still 'no results found'

What is the expected behavior? to see the pdf in the viewer. It worked since I first installed it months ago.
What went wrong? (see screenshot)

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

Attach (recommended) or Link to PDF file here: https://gracebaptistottawa.com/parable-of-the-banquet-tract/

That link seems to point to a HTML file, rather than a PDF file, hence it's somewhat difficult to understand what problem you're trying to report here.

PDF.js version: Version 2.1.4

That version is no longer supported (and it was not an official release), please find the latest releases at https://mozilla.github.io/pdf.js/getting_started/#download

Steps to reproduce the problem:
1. re-loaded pdfs
2. still 'no results found'
What is the expected behavior? to see the pdf in the viewer. It worked since I first installed it months ago.

In addition to the previous points, please note that it's unfortunately not possible to provide much (or any) assistance as-is; please also see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.


[Windows] Onboard Envoy to SCM

Signed-off-by: Sotiris Nanopoulos<EMAIL_ADDRESS>Commit Message:
Fixes #13188
Additional Description:
Utilizes the same inter process communication as signal_impl to handle close.
Pending work:

[x] Add tests
[x] Add documentation on how to use the feature

Risk Level: Low (Windows Only)
Testing: Unit/Integration
Docs Changes: Added on how to run Envoy
Release Notes: N/A

Creating as draft to have an idea of what the CI is thinking and get some early feedback

@envoyproxy/windows-dev  want to do an early pass to see if this going to the correct direction?

/retest

@wrowe this ready for review

Marked the test as flaky in #14419

/retest

@wrowe  let me know if I should augment the PR with calls to the Event log manager in case we fail before the loggers get initialized

let me know if I should augment the PR with calls to the Event log manager in case we fail before the loggers get initialized

I believe that's out of scope for this PR, we are ready to accept, apply and iterate.

We appreciate the work of the coders and the reviewers of the Windows Envoy PRs. Thanks!

If folks want to try this in the coming couple months, I think they might be better served using dev builds for the time being, and picking up our enhancements on the dev branch instead of relying on 1.17 incremental releases, WDYT?

At this point it make sense not to take in 1.17 release.

@wrowe  can we get this on track to get merged since 1.17 is out now

@wrowe  can we get this on track to get merged since 1.17 is out now

@wrowe just a ping for a review

@wrowe just a ping for a review

@envoyproxy/senior-maintainers anyone interested in reviewing this one?

@envoyproxy/senior-maintainers anyone interested in doing a win32 code review to get this one merged?

I can take a look.

picking up main to fix the CI


Nest.PropertyName constructor issue

NEST/Elasticsearch.Net version:
5.0.0:
Nest.PropertyName constructor (PropertyName(string name)) doesn't initialize the private field _type:
Steps to reproduce:

Check the code at - _https://github.com/elastic/elasticsearch-net/blob/master/src/Nest/CommonAbstractions/Infer/PropertyName/PropertyName.cs_
The constructor is not initializing the field - private readonly Type _type

This is by design. _type is only used when resolving from an Expression, and we have necessary null checks in place.
Do you have a particular scenario where this is problematic?

Closing.  Feel free to re-open @ljnotes if this is still an issue.


Clarify documentation about using rotating logs?

The documentation actually is amazing, but for me (maybe for someone else) it's not clear: can I use the rotating logs setup with the logspout?
For example, I have the following command for starting some docker container:
docker run --log-opt max-size=10m --log-opt max-file=5 ...

And the Logstash command is:
docker run -d --name=logspout\
 --volume=/var/run/docker.sock:/var/run/docker.sock\
 gliderlabs/logspout\
 tcp://address:ip

As I know, the docker rotating logs mechanism will remove the "old-logs", so the total size of all logfiles will remain constant. Is this not a problem for Logspout? Can logspout correctly process multiple log files?

+1, good question

FWIW I tested this out and it was working just fine for me. This is based on my admittedly minimal testing. I believe logspout uses the the docker api to get logs instead of looking directly at files in the filesystem. You can have a container running, and go through log rotations before logspout starts up, and it should pick up the backlog of log entries.
The only time I ran into a problem was if I restarted an existing container. I got duplicate log entries, but I think that has nothing to do with log rotation. Setting BACKLOG=false prevents the duplicate entries, but that will also cause logspout to miss log entries that were created prior to logspout startup. That's the normal behavior even without docker log rotation.


Change compiler from dpcpp to icpx -fsycl Part 1

Existing Sample Changes
Description
First Part of compiler change from dpcpp to icpx -fsycl. This
Fixes Issue#
External Dependencies
List any external dependencies created as a result of this change.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[X] Implement fixes for ONSAM Jiras

[X] Command Line

@KanclerzPiotr Can you remove Makefile and Makefile.fpga from the simple-add folder and resubmit the PR? Yohann removed all Makefiles and cleaned everything up so that we have just one CMakeLists.txt for simple-add and vector-add.


add highlight.js

Connected to #262

I've tried it out, looks generally good! Did you pick-and-choose languages? If so, it looks like the dockerfile language is not installed, and would ve very useful. Would love to hear what languages were chosen too. Here are some that I think we need to include (but not complete list): bash, python, javascript, go, rust, dockerfile, coffeescript, cpp, yaml, json. Any other you can think of?

I've just included the default package, it seems to have the langs marked
here:
https://highlightjs.org/download/
Can make the custom build instead, of course
On Sun, Jul 31, 2016 at 1:29 PM, Gergely Imreh<EMAIL_ADDRESS>wrote:

I've tried it out, looks generally good! Did you pick-and-choose
languages? If so, it looks like the dockerfile
https://github.com/isagalaev/highlight.js/blob/master/src/languages/dockerfile.js
language is not installed, and would ve very useful. Would love to hear
what languages were chosen too. Here are some that I think we need to
include (but not complete list): bash, python, javascript, go, rust,
dockerfile, coffeescript, cpp, yaml, json. Any other you can think of?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/resin-io/docs/pull/271#issuecomment-236422539, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgGCDjcaw-HAWK9KT_GsEIGVUw9gzv5ks5qbHkPgaJpZM4JX_ZJ
.

--
Eugene Mirotin
Senior Frontend Engineer
site: Resin.io https://resin.io/, twitter: @resin_io
https://twitter.com/resin_io

Now it makes complete sense, thanks! :) I think we got to make a custom build (and somewhere mark what languages we chose, to be repeatable). I propose keeping all the defaults, and adding these ones:

Device Tree (should be useful, especially for RPi)
Dockerfile (used a lot)
Go (core language for us)
Handlebars (used in versionist)
Rust (have some internal project in it, future proofing)
YAML (used in resin sync for config, maybe elsewhere too?)

(at a minimum). Any other ones you'd think this time?

I get some strange behaviour locally, investigating now.


Extract common functionality into the interfaces

Migrated from Enterprise Github.
Creator: @mrossinek

[ ] extract common functionality into the ParticleOperator

This will probably affect things like __sub__, __rmul__, __neg__, __pow__, __ne__ because all of these can link to their counterpart

[ ] extract common functionality into the SumOp (similar to the above)

Since we merged the ParticleOperator and SumOp interfaces, this issue is outdated and can be closed.


Create container to avoid local dependencies

Currently a bunch of dependencies are required for local installation (carvel tools, kind, yq, etc.) as documented in the CONTRIBUTING.md.
We should build and publish a container to simplify the running of the script.

Outstanding task is:

[ ]  Completely automate the process by adding to the container the Git and GitHub credentials so that commits and releases can be automatically done from it.


Suggesting to replace syscall.Getenv("GOFIPS") with Read registry key

Hi,
In the documentation you recommend using GOFIPS and set at runtime to support both option of running in FIPS mode or non-FIPS.
The problem is that unless set before service installation, adding GOFIPS during the installation, requires restart of the Windows in order for the GOFIPS change to be visible to the service.
I want to suggest to replace syscall.Getenv("GOFIPS") with read of the registry GOFIPS key to check to decide how to run a service and avoid the restart.
Path: Computer\HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment
Similar to enableSystemWideFIPS(), microsoft-go/eng/_util/cmd/run-builder/systemfips_windows.go
Thanks,
Lilach

I might not be understanding your suggestion, but I think it might already work in the way you want. On Windows, FIPS mode cannot be enabled or disabled for a specific application: it's always a system-wide setting, and changing that registry key is one way to configure it.
On Windows, GOFIPS only checks that the system is running in the desired mode. It will never try to change the mode. https://github.com/microsoft/go/tree/microsoft/main/eng/doc/fips#windows-fips-mode-cng. To make sure it's clear: GOFIPS has two options on Windows (different from OpenSSL/Linux):

1: panic if systemwide FIPS mode isn't enabled.
<anything else>: don't run a check, simply use what the system provides.

https://github.com/microsoft/go/blob/8122764bbbbd5072c1ae428862465317653a5e1f/patches/0005-Add-CNG-crypto-backend.patch#L216-L227
cng.FIPS() uses BCryptGetFipsAlgorithmMode, which is affected by that registry key.
It sounds like GOFIPS isn't useful for your case (a Windows service), and that's fine--there's no need to use it for every program. On Windows, it's just a small feature that lets you potentially detect misconfigured systems.

If understood correctly, the FIPS policy must be enabled as a prerequisite
to run a FIPS compliant app service.
Assuming the FIPS policy is already enabled, then the GOFIPS=1  is still
required on runtime in order for the service to run using CNG.
If above is correct my question is on the first installation of the app,
that runs as a service. Is restart mandatory after adding GOFIPS=1,
assuming it was not defined or it is not required?
Thanks
On Thu, Dec 5, 2024, 00:16 Davis Goodin @.***> wrote:

I might not be understanding your suggestion, but I think it might already
work in the way you want. On Windows, FIPS mode cannot be enabled or
disabled for a specific application: it's always a system-wide setting, and
changing that registry key is one way to configure it.
On Windows, GOFIPS only checks that the system is running in the desired
mode. It will never try to change the mode.
https://github.com/microsoft/go/tree/microsoft/main/eng/doc/fips#windows-fips-mode-cng.
To make sure it's clear: GOFIPS has two options on Windows (different
from OpenSSL/Linux):

1: panic if systemwide FIPS mode isn't enabled.
: don't run a check, simply use what the system
provides.

https://github.com/microsoft/go/blob/8122764bbbbd5072c1ae428862465317653a5e1f/patches/0005-Add-CNG-crypto-backend.patch#L216-L227
cng.FIPS()
https://github.com/microsoft/go-crypto-winnative/blob/550ad8080584651ce6c99de9204132ec77b8a5bb/cng/cng.go#L21
uses BCryptGetFipsAlgorithmMode
https://learn.microsoft.com/en-us/windows/win32/api/bcrypt/nf-bcrypt-bcryptgetfipsalgorithmmode,
which is affected by that registry key.
It sounds like GOFIPS isn't useful for your case (a Windows service), and
that's fine--there's no need to use it for every program. On Windows, it's
just a small feature that lets you potentially detect misconfigured systems.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/go/issues/1429#issuecomment-2518672164, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALUI5LVBCEULTE4UBA57V7T2D55M5AVCNFSM6AAAAABS73GHEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJYGY3TEMJWGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

According to the documentation Usage Common Configuration
Using GOEXPERIMENT=systemcrypto which is the default, can be used to create a compliant app. FIPS mode is automatically enabled at runtime if it is configured systemwide or GOFIPS=1.
GOEXPERIMENT=systemcrypto and in runtime, during app start it sets GOFIPS=1 this replaces the need to define GOFIPS system wide. The app either enables FIPS mode or ensures it is already enabled. Otherwise, the app panics.
GOEXPERIMENT=systemcrypto and in runtime, the app sets GOFIPS=0 to run as non-FIPS. Crypto usage is not FIPS compliant. The app attempts to disable FIPS mode and panics if it isn't possible.
To run as FIPS compliant it is required that the Windows FIPS policy will be enabled as a prerequisite. Is that correct?
In addition either GOFIPS is added system wide or at runtime.
In our use case we install and run a Windows service. Assuming that the FIPS policy is enabled but GOFIPS var is not defined system wide the question was what are the options in order for the service to immediately start running using CNG, FIPS compliant?
Windows services spawned by SCM. SCM starts on early boot stage and acquires the environment, all services will inherit SCM's environment. Even the newly added/installed service might get a stale SCM environment.
Thus adding system wide GOFIPS environment variable requires a system reboot for SCM to be aware of it and propagate it to the services.
Please consider the following scenario:
Installing a Go-based service on a FIPS-compliant Windows host.
The system administrator may not know the Go prerequisite of having a GOFIPS=1 environment variable, thus the variable might be missing.
Attempts to set this variable from the MSI context will not affect the newly added services - as the parent SCM process is unaware of the new variable. Thus a reboot of the host is required to make it work properly.
Go reading the value directly from HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment will have an immediate effect.
The option of dynamically adding GOFIPS=1 after the service was started will have the same affect as having a predefined system wide GOFIPS=1 var?
Thanks

FIPS mode is automatically enabled at runtime if it is configured systemwide or GOFIPS=1.

Ah, apologies, that only describes the OpenSSL backend, not CNG/Windows. I'll get that fixed. That particular note might not have been revised since the CNG backend was added--OpenSSL was first.
On Windows, the Go application is not responsible for enabling FIPS mode. https://github.com/microsoft/go/tree/microsoft/main/eng/doc/fips#windows-fips-mode-cng is correct, sorry about the conflicting information.

In addition either GOFIPS is added system wide or at runtime.

The Go application just reads the environment variable upon startup (during an init func). The app doesn't try to determine if GOFIPS is defined system-wide or specifically in the Go process or its parent process. They are equivalent as far as the app is concerned.
For clarity: none of the language in the doc is intended to say anything about defining environment variables system-wide or specific to a certain process. I'll give the doc a pass-through to try to make sure this is clear. (In my experience, on Linux it's a little clearer that this concept won't affect anything, so some of the current wording might be muddy when reading for Windows.)

Assuming that the FIPS policy is enabled but GOFIPS var is not defined system wide the question was what are the options in order for the service to immediately start running using CNG, FIPS compliant?

There are two factors here:

A Windows Go app built using the cngcrypto backend (or the alias systemcrypto) will always use CNG calls.
If the FIPS policy is enabled while a cngcrypto (or systemcrypto) app is initializing, the app will be in FIPS mode.

We use a CNG API call to check FIPS policy. We expect this to be very accurate and futureproof.

GOFIPS doesn't affect either of those. The only effect is that during app init, if GOFIPS is 1 and the FIPS policy is not enabled, the app will panic.

Missed this Q, I think it's a good one for me to answer directly to make sure everything makes sense together: 🙂

To run as FIPS compliant it is required that the Windows FIPS policy will be enabled as a prerequisite. Is that correct?

Yes, and the only other prerequisite is that the app is built with cngcrypto or systemcrypto.

Thanks @dagood, it is clear now.
Last thing, beside using the GOFIPS to detect whether the FIPS policy is enabled or not, what are other straightforward ways to know that the Go app is running in FIPS?
Is there an event logged to Event Viewer?
If on runtime I want to add an indication in the app UI whether it is running in FIPS or not but don't want to panic, what is the best approach?
Thanks

We haven't provided a supported API to check FIPS mode--a bit more background about why in this issue:

https://github.com/microsoft/go/issues/999 (Also contains a workaround that uses linkname.)

There also aren't any external indicators like event viewer, etc.
(Note that #999 also mentions that upstream has accepted a proposal that includes adding a built-in function to check the mode, crypto/fips140.Enabled(). Once upstream does that, we will follow. Upstream was previously against adding this API, but a lot is changing.)
Summary: for now, there is no straightforward way. In 1.24 there might be.

Thanks @dagood.
What is your opinion about checking whether FIPS local security policy is enabled to conclude the app is running is FIPS mode?
Also, does the changes from building with the goexperiment.systemcrypto or goexperiment.cngcrypto tags, replace the standard crypto package https://pkg.go.dev/crypto including the https://pkg.go.dev/crypto/tls in the vendor and vendor-patched modules?
What is the expected impact of running in FIPS mode if the app is using weak hash such as MD5?
What is the expected impact on the TLS handshake?
Thanks

What is your opinion about checking whether FIPS local security policy is enabled to conclude the app is running is FIPS mode?

I think that if you need to check FIPS mode, the workaround in the description of https://github.com/microsoft/go/issues/999 is currently the best way to do it (if using an ordinary build of Microsoft Go). I think that checking whether FIPS local security policy is enabled by some other means and then making a conclusion about FIPS mode could maybe end up ok, but I'm not familiar with that and the potential caveats.

Also, does the changes from building with the goexperiment.systemcrypto or goexperiment.cngcrypto tags, replace the standard crypto package https://pkg.go.dev/crypto including the https://pkg.go.dev/crypto/tls in the vendor and vendor-patched modules?

I'm not sure I understand "the vendor and vendor-patched modules". If you mean you have an app, it imports some packages from external modules, and you've called go mod vendor, yes, they use the same crypto package as the app's code does, and the crypto package's logic is different when the app is built by Microsoft Go. Modifying the files in vendor/ ("vendor-patched?") also doesn't affect how the imports work.

What is the expected impact of running in FIPS mode if the app is using weak hash such as MD5?

I would expect it to succeed, but the app would not be considered FIPS compliant if the MD5 call was performed for a cryptographic purpose.

https://github.com/microsoft/go/tree/microsoft/main/eng/doc/fips#microsoft-go-fork-fips-compliance
[...] The modified crypto runtime will fall back to Go standard library crypto if it cannot provide a FIPS-compliant implementation, e.g. when hashing a message using crypto/md5 hashes or when using an AES-GCM cipher with a non-standard nonce size.

What is the expected impact on the TLS handshake?

It should be restricted to FIPS approved settings (and I see this happen with my example program at https://github.com/microsoft/go/issues/1434#issuecomment-2529436763):

https://github.com/microsoft/go/tree/microsoft/main/eng/doc/fips#tls-with-fips-compliant-settings
Since Go 1.22, the Microsoft Go runtime automatically enforces that crypto/tls and crypto/x509 only use FIPS-compliant settings when running in FIPS mode.

I've read #999 and linked issue there and understand that in the next release, 1.24, there will be a function that can be called to check whether the app is running in FIPS mode.
Regarding the TLS. I'll continue the discussion in #1434.
Thanks @dagood.


Failed to fetch data from ...

Running this script in version aea563c on Debian 12 will produce an error.

bin/list.sh --country FR --category kimsufi
fetching servers in FR
fetching data from https://eu.api.ovh.com/v1/order/catalog/public/eco?ovhSubsidiary=FR
saved    data to   kimsufi-notifier.jmpwgp
failed to fetch data from https://eu.api.ovh.com/v1/order/catalog/public/eco?ovhSubsidiary=FR

Manually opening the "kimsufi-notifier.jmpwgp" file reveals that the data has actually been downloaded correctly:
{     "catalogId": 7725,     "locale": {         "currencyCode": "EUR",         "subsidiary": "FR",         "taxRate": 20     },     "plans": [         {             "planCode": "24rise06-sgp",             "invoiceName": "RISE-6 | Intel Xeon Gold 6312U",             "addonFamilies": [                 {                     "name": "memory",                     "exclusive": true,                     "mandatory": true,                     "addons": [                         "ram-128g-ecc-3200-24rise",                         "ram-512g-ecc-3200-24rise",                         "ram-256g-ecc-3200-24rise",                         "ram-1024g-ecc-3200-24rise"                     ],                     "default": "ram-128g-ecc-3200-24rise"                 }, [...]
The script seems to recognize this valid response as invalid and will crash with the error message above.
Another example:

bin/check.sh --plan-code 24sk50

checking 24sk50 availability in fr,gra,rbx,sbg datacenter(s)
fetching data from https://eu.api.ovh.com/v1/dedicated/server/datacenter/availabilities?planCode=24sk50&datacenters=fr,gra,rbx,sbg
[{"fqn":"24sk50.ram-32g-ecc-2400.softraid-2x2000sa","memory":"ram-32g-ecc-2400","planCode":"24sk50","server":"24sk50","storage":"softraid-2x2000sa","datacenters":[{"availability":"1H-high","datacenter":"gra"},{"availability":"1H-high","datacenter":"rbx"},{"availability":"1H-high","datacenter":"sbg"}]},{"fqn":"24sk50.ram-32g-ecc-2400.softraid-2x450nvme","memory":"ram-32g-ecc-2400","planCode":"24sk50","server":"24sk50","storage":"softraid-2x450nvme","datacenters":[{"availability":"1H-low","datacenter":"gra"},{"availability":"1H-low","datacenter":"rbx"},{"availability":"unavailable","datacenter":"sbg"}]},{"fqn":"24sk50.ram-64g-ecc-2400.softraid-2x2000sa","memory":"ram-64g-ecc-2400","planCode":"24sk50","server":"24sk50","storage":"softraid-2x2000sa","datacenters":[{"availability":"1H-high","datacenter":"gra"},{"availability":"1H-high","datacenter":"rbx"},{"availability":"1H-low","datacenter":"sbg"}]},{"fqn":"24sk50.ram-64g-ecc-2400.softraid-2x450nvme","memory":"ram-64g-ecc-2400","planCode":"24sk50","server":"24sk50","storage":"softraid-2x450nvme","datacenters":[{"availability":"unavailable","datacenter":"gra"},{"availability":"1H-low","datacenter":"rbx"},{"availability":"unavailable","datacenter":"sbg"}]}]
saved    data to   kimsufi-notifier.cnr1Ig
failed to fetch data from https://eu.api.ovh.com/v1/dedicated/server/datacenter/availabilities?planCode=24sk50&datacenters=fr,gra,rbx,sbg

Your IP looks banned by OVH.

Your IP looks banned by OVH.

What makes you say that?
The reply I get from the request is valid JSON. Manually querying the IP also works just fine.
I am a customer of OVH and can guarantee that my IP is not banned.

The data looks correct, could you share more information about your environment like os, bash, and curl versions
cat /etc/os-release
bash --version
curl --version

I made some recent changes and fixes into the scripts, you might want to have another try with the latest version.

That's now fixed, support for arm architecture and macOS has been added.


Update DG

Individual contributions were removed?

Pull Request Test Coverage Report for Build 183

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.178%

Totals

Change from base Build 179:
0.0%

Covered Lines:
1693

Relevant Lines:
1942

💛  - Coveralls


Mock some requests in tests

#211
The multiple refs test is failing since I can't figure out how to mock it to different values
This is based off of https://realpython.com/testing-third-party-apis-with-mocks, maybe better ways to do this

Okay, the first test passes now.

This might be something you can do a better job of, @umesh-timalsina? It's a low priority but would be a nice feature.

Yeah I will take a stab at this PR. Starting with : we should change the way we have written the requests function call assuming that it will always pass here.

Sorry for the notifications, I am no longer trying to mock stuff but instead using this branch to fix another issue. Hopefully the git history is salvageable enough to anybody trying to solve the original issue of mocking requests.


bad_alloc and exit code when attempt to load_model

What version of Python are you using (python --version)?
Python 2.7.9
What operating system and processor architecture are you using?
Linux jessie 3.16.0-4-amd64
Architecture: x86_64
What did you do?
built model with fasttext CLI
./fasttext supervised -input /vagrant/data/train.txt -output /tmp/model

this worked and I can run test and predict.
(I built model with CLI because attempt to use model = fasttext.cbow('/vagrant/data/train.txt', '/tmp/model') end up with the same error shown below.)
then attempt to load the model as follows:
>>> import fasttext
>>> model = fasttext.load_model('/tmp/model.bin')
terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
Aborted

What did you expect to see?
I expected that model to be loaded to model variable
What did you see instead?
I saw the following error and python existed
terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
Aborted

What is the size of your bin model?

it is 793mb
vagrant@jessie:~$ ls -alh /home/vagrant/ | grep model
-rw-r--r-- 1 vagrant vagrant 793M Aug 17 20:51 model.bin
-rw-r--r-- 1 vagrant vagrant  79M Aug 17 20:52 model.vec

Hi Naoko,
The size of your model.bin is normal, and it should work as expected.
std::bad_alloc error is caused by the C++ extension fails to
allocate memory. This shouldn't problem if you have ~1GB free ram.
On Thursday, 18 August 2016, Naoko Reeves<EMAIL_ADDRESS>wrote:

it is 793mb
vagrant@jessie:~$ ls -alh /home/vagrant/ | grep model
-rw-r--r-- 1 vagrant vagrant 793M Aug 17 20:51 model.bin
-rw-r--r-- 1 vagrant vagrant  79M Aug 17 20:52 model.vec
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/salestock/fastText.py/issues/26#issuecomment-240544360,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACHHDhxe5JXUIBySEgox72KpKm3rZ0-Gks5qg3SigaJpZM4JmoxX
.

--
Bayu Aldi Yansyah,
Universitas Airlangga
https://github.com/pyk

Hmm, I have more than 1GB of freem ram
vagrant@jessie:~$ free -mh
             total       used       free     shared    buffers     cached
Mem:          2.0G        53M       1.9G       332K        52K        11M
-/+ buffers/cache:        42M       1.9G
Swap:         461M        24M       437M

any other data i can dump to investigate?

Yup, can we access the .txt data that you use? I will try to re-produce it
I have tried with my own model (text9.bin):
(fasttext) % ls -lsh result/
total 1.1G
156K -rw-rw-r-- 1 501 dialout 156K Aug 10 00:29 skipgram.vec
934M -rw-rw-r-- 1 501 dialout 934M Aug 10 00:29 text9.bin
182M -rw-rw-r-- 1 501 dialout 182M Aug 10 00:29 text9.vec
(fasttext) % python
Python 2.7.6 (default, Jun 22 2015, 17:58:13)
[GCC 4.8.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import fasttext
>>> model = fasttext.load_model('result/text9.bin')
>>> model['king']
[-0.16784165799617767, -0.4711022973060608, -0.3373805582523346, 0.6067320108413696, -0.2716444134712219, -0.4812774062156677, -0.3166585862636566, 0.5353936553001404, 0.9370109438896179, -0.9412822127342224, -0.4473196864128113, 0.12252281606197357, 0.01782635785639286, 0.2321011871099472, 0.005254420451819897, -0.27218711376190186, -0.05221862345933914, 0.41009068489074707, 0.48507145047187805, -0.5433980226516724, 0.2901340126991272, 0.29300951957702637, -0.4539581835269928, -0.1802728772163391, -0.009078800678253174, 0.31277552247047424, 0.2562687397003174, 0.2610059380531311, -0.39578014612197876, -0.04009539633989334, -0.5180484056472778, 0.8406932353973389, -0.26266956329345703, 0.19579696655273438, -0.47587722539901733, -0.035721227526664734, -0.4593009352684021, -0.3765336573123932, -0.001768058049492538, 0.06441915780305862, 0.08696946501731873, -0.6499592065811157, -0.1879948526620865, -0.1572948396205902, -0.005987414158880711, 0.28767943382263184, -0.09148744493722916, 0.03199046850204468, -0.4601893126964569, 0.13289642333984375, 0.32671576738357544, -0.027682863175868988, 0.3940761387348175, 0.12189480662345886, -0.301717072725296, -0.28382381796836853, 0.807844340801239, 0.6995733380317688, 0.2245093286037445, 0.01596692018210888, 0.07866773754358292, 0.45165181159973145, 0.3363269567489624, -0.7025864720344543, 0.19094844162464142, 0.2228030413389206, -0.31027859449386597, -0.30575716495513916, -0.024556534364819527, 0.3115992844104767, 0.44243282079696655, -0.11615170538425446, 0.22610057890415192, -0.14012892544269562, -0.634835958480835, -0.461560994386673, 0.3927555978298187, 0.8361159563064575, 0.4145791530609131, 0.09680262953042984, -0.4256342649459839, 0.36583471298217773, -0.46189969778060913, -0.06288062781095505, -0.6200613975524902, 0.10725054144859314, 0.23836052417755127, 0.3132688105106354, -0.61988365650177, 0.24967744946479797, -0.2008746862411499, 0.12375567853450775, 0.03935942053794861, 0.06365758180618286, 0.015391523949801922, -0.0308303814381361, 0.04854980483651161, -0.5449500679969788, 0.09447596222162247, 0.46398618817329407]
>>>

And it works as expected

Nevermind, I able reproduce your case using different data dbpedia.train
(fasttext) % ./fasttext/cpp/fasttext supervised -input data/dbpedia.train -output /tmp/model
Read 32M words
Progress: 100.0%  words/sec/thread: 735560  lr: 0.000001  loss: 0.119935  eta: 0h0m
Train time: 40.000000 sec

(fasttext) % python
Python 2.7.6 (default, Jun 22 2015, 17:58:13)
[GCC 4.8.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import fasttext
>>> model = fasttext.load_model('/tmp/model.bin')
terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
Aborted (core dumped)

Hotfix is on progress

thank you so much @pyk !

@naoko This problem is caused by FastTextModel::setMatrix in fasttext/interface.cc.  You can see #29 for more details
Fixed on v0.6.3
You can get the newest version using the following command:
pip install --no-cache-dir -U fasttext

@pyk , thank you soooooo much!  I got the latest and now I can use it with no issue.

@naoko yup yup :+1:

I am still not able to use current version of https://github.com/facebookresearch/fastText/ with current version of https://github.com/salestock/fastText.py. Free memory -
total       used       free     shared    buffers     cached
Mem:           59G        29G        30G        16M       1.4G        23G
-/+ buffers/cache:      4.1G      55G
Swap:           0B         0B           0B
My model size is 410MB.
What am I missing?

@nugrahatheo did you try to use the bucket option?


Add the possibility to pass personal number requirement to sign using BankIdFlowService

This PR adds  the possibility to pass a personal number requirement to the /sign operation when calling it via the BankIdFlowService.
This is done by adding a property RequirePersonalNumber to BankIdFlowOptions, which by default will not be set, and then using that to set the personal number requirement in the SignRequest.

Thanks for the PR! Would like to se that you use PersonalIdentityNumber as type instead of string, to ensure a valid number is passed.

Looks good, down to the nitty gritty details now :) I would vote for calling it RequiredPersonalIdentityNumber instead. Required to show that it's not a bool (in contrast to the other properties) and PersonalIdentityNumber to align with our other naming conventions.

I called it PersonalNumber since that's what it's called in the BankId Requirement according to their documentation, but no problems, I have changed it to RequiredPersonalIdentityNumber.

Thanks for this! Will see when I can get this out, would probably be an 8.1 release.


Add rationale for strict-boolean-expressions

The documentation for the strict-boolean-expressions rule does not mention the rationale. Rationale is helpful for people when they trigger a lint rule for the first type and don't know what the point of it is. If someone writes code that triggers a lint rule, and they can't figure out what the point of the rule is, then it just ends up being a nuisance for them and often the response is to disable it. If the rationale is in the documentation and it is explained well, then people can make an informed decision and are more likely to keep the rule.
I've been having trouble figuring out the rationale for the strict-boolean-expressions rule. At first I thought it could be because !(expression) returns true or false, which may not be included in the type of expression. But then I realized that that means the type of !(expression) is a different type, and any type errors will be caught by the compiler.
At this point there are two possible reasons for the rule that I've found: one is that 0 and "" are falsy, and that this can confuse people. That is explained in issue #4331, which proposes allowing unions with null, undefined and object types because objects are never falsy. The other possible reason is that it's just a style that people want to follow.
Whatever the rationale is for the rule, it should be well explained in the documentation - and the rationale for each of the different options should be explained, too, even if they are just a style choice. Or if there is no rationale for an option, then doesn't that mean the option should be deprecated?

💀 It's time! 💀
TSLint is deprecated and no longer accepting pull requests other than security fixes. See #4534. ☠
We recommend you instead use typescript-eslint to lint your TypeScript code with ESLint. ✅
👋 It was a pleasure open sourcing with you!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


Change all occurences and Command Palette is in every editor

Refs: https://github.com/microsoft/vscode/issues/74472
Notice how the context menu in the comment input box is pretty useless. It has all the unrelated actions. And we have  similar problem in the debug console input box.
I belive the Change all occurences and the Command Palette belong only in the main editor and they should be removed from all others.
@bpasero @jrieken On what context keys do we contribute these commands. Can we fine tune them so they do not appear in every editor?

Makes sense to not have them in there. I would think there should be a context key set whenever the editor is not used as a real text editor and then we can change those registrations.

There is a context key isInEmbeddedEditor https://github.com/microsoft/vscode/blob/master/src/vs/editor/common/editorContextKeys.ts#L31 but it's only used in Playground/Walkthrough. We should probably make better use of it.

I can look into this this mielstone, thus assignign to October and removing other asignees.

@rebornix please review the fix. I checked out how it beahves and it seems good

Thanks, I’ll take a look.

@isidorn not sure if I understand it incorrectly, restricting the command to ContextKeyExpr.and(EditorContextKeys.writable, EditorContextKeys.editorTextFocus)  doesn't filter it out from Comment Editor, right?

I believe it does. Because the editorTextFocus is set only when the editor is not a simple widget. Check it out here https://github.com/Microsoft/vscode/blob/f554449e3baa6db81c04ed2c321c60ec3a8e9b9f/src/vs/editor/browser/widget/codeEditorWidget.ts#L1640
And I hope the comment editor is a simple editor widget like the repl input is. I set this here https://github.com/Microsoft/vscode/blob/f554449e3baa6db81c04ed2c321c60ec3a8e9b9f/src/vs/workbench/contrib/codeEditor/browser/simpleEditorOptions.ts#L43

I did use the simple editor by following repl input but turned out that language features won't be enabled when doing so. But we may still want to do so otherwise it's polluting the extension API.

@isidorn thanks, I changed it to simple editor and considering we only need suggestion / snippet, it should be fine.

@rebornix great, thanks for doing that.


MAINT: reduce tutorial memory usage

#9156 added a tutorial that is very memory-hungry, and CircleCI can't handle building it.  This PR reduces build time / memory consumption on my machine from 167.38 sec  / 3563.6 MB before this PR to  23.90 sec / 244.5 MB after this PR.  Along the way I tightened up the text and code in a few places.

circle is happy, so in it goes!


homepage: resource + article card issues

Resource cards should hang on both sides:

https://gatsby-theme-carbon.now.sh/components/ResourceCard
Article cards should hang on left:

https://gatsby-theme-carbon.now.sh/components/ArticleCard
@jeanservaas

Also an urgent one to fix


OSPRay not producing shadows.

Describe the bug
I ran VisIt 3.0.0 on Mac using Kevin's new OSPRay-enabled version. I can turn on OSPRay but little to nothing is different when I render. I can see that when OSPRay is enabled, the bounding box changes to shaded tubes. The overall picture quality is no better though. I see that OSPRay settings in the Rendering window have a "Shadows" check box. This setting appears to do nothing.
I made a script that does an isosurface and adds another plot to serve as a ground plane. When I use normal SR mode plus shadows, I get shadows cast. I do not get that when I run using OSPRay, plus the image looks no better.
I also noticed that the first image's depth buffer is saved out to a separate file though pixel data is set to 1 in the SetSaveAttributes. I think that pixelData == 1 means just save ColorRGB (see SaveWindowAttributes.h). This is a bug too.
Helpful additional information
(Please click check boxes AFTER submitting ticket)

[ ] Did VisIt crash?
[ x] Did you get wrong results?

Impact

[ ] High - User productivity significantly degraded
[x] Medium - User productivity partially degraded
[ ] Low - User productivity trivially degraded

Likelihood

[ ] High - occurrence is not specific to platform, data, config, a combination of operators, queries, etc.
[ x] Medium - neither low nor high likelihood
[ ] Low - occurrence is specific to combination of multiple factors such as configuration, data, platform, etc.

To Reproduce
Steps to reproduce the behavior:

Unzip the attached zip file to get the ospray.py script
visit -cli -nowin -noconfig -s ospray.py
Look at the resulting visit????.png files. The first one is for SR mode. The second one is for OSPRay and it is not as good as the SR mode version.

Expected behavior
I expected that when I select OSPRay rendering that I would get better shadows than I would get in SR mode. I also expected some ray traced appearance (reflections, etc). Without those, I see no upside to OSPRay.
Attachments

See the attached Python script that uses noise.silo
ospray.py.zip

Desktop

MacOS X 10.12
VisIt Version: 3.0
MacOS X 10.12

Additional context
N/A

@BradWhitlock there is some strange multi-layer initialization bug. If you enable ospray w/ shadows, nothing seems to happen until you actually move a light.  If you turn it off an on again you still have the same type of issue.


Queries related to issues App features and Change requirements.

Hi,
Request you to kindly suggest the options for below requirements.

While composing message by author in config tab, can we use the image url from our intranet Sharepoint site document library . Does it has to be a public folder?, If we want to use the app for intranet purpose then can't we use the image url from intranet repository or it needs to be public folder only.. Kindly suggest.
Could you please explain a bit more about "Send in Chat to everyone" option
Does it sends the message to everyone in the organization, it will be bit risky to give such option to authors. In the warning message it says the message will be sent to all who have client app. So, if we install the app with parameter proactivelyInstallUserApp set to true. in that case will it send message to everyone in the organization?. How do we prevent or restrict this option, should we install the app with the parameter proactivelyInstallUserApp set to false.

Please do share your feedback on these queries with a bit of explanation so that we are very clear on it. Thanks you very much in advance.

Hi @raghavendrakumbhar ,
1)Image should be a public folder. If it is from intranet Sharepoint site all the users should have access to the image, then only the image will be displayed/delivered to all.
2)If proactive installation is set to true and user app is installed in that team/teams then the user app will installed to all users automatically and message will be sent to all of them  . If false, it can be restricted but the user app has to be installed explicitly for the user/users who wants to receive the message.

Hi @gsv022,
Thanks for your response will check and let you know on the image requirement.
In case of send message to everyone option, say if we have 10 teams in ms-teams and the user app is installed on 5 of them. So, if we choose send message to everyone, will the message go to all members of 10 teams or all members of 5 teams where the user app is installed. We just want to know if that option sends message to everyone in the organization who have access to teams, as its a risk to send message to everyone in the organization?

Hi @raghavendrakumbhar ,
Send to everyone is primarily focused to send messages across the tenant users. If proactive installation is enabled and user app is uploaded to tenant level then the app will be installed to respective users during message sending.
However to avoid this scenario, there are two alternatives,

Turn off  proactive installation and manually install the user app using permission policies. In this messages will be send only to users for whom App is installed.

Even if proactive installation is enabled, but if user app is not uploaded at tenant level, instead added to respective teams then the feature of proactive installation will not work and messages will be sent only for the users for whom the user app is manually installed.

Hi @v-royavinash ,
Thank you very much for the alternative options, these would definitely help us.
While installing the app, we had kept proactive installation of aap setting as true, can we change that from the configuration of app service by setting it to false.
or, we shall keep the proactive setting as true and not upload the user app at tenant level, instead can we do side loading of the user app to only the teams where it is required. So, we if we side load the app to 5 teams. then users of only those 5 teams will receive message and not the rest of teams, right?

Hi @raghavendrakumbhar ,
The steps you mentioned are valid and the suggested approach.
However to disable the proactive installation, the app setting of both app service and *-prep-function has to be updated.

Hi @raghavendrakumbhar ,
Thank you for submitting this issue, as we work to ensure consistent responses with items logged in our issues list, we are working to address these items that did not get responses. Please let us know if you are still facing this issue and require assistance and we will be happy to discuss. If no further action is needed at moment and no response is received, we will close out the issue in 3 business days. You may also always open a new issue or respond here if something does come back up.

Hi,
We tried below scenario today, its not behaving the way you explained above. We wanted to test "Send Message to all " scenario, which should send message to only those teams where user app is installed.

Installed the author app on a Team through side loading option
Installed the user app to 3 teams through side loading option
During Company Communicator app deployment, we have set Proactive Installation as true.
When we tried to send message using the option "Send Message to All", it took almost 9 minutes with status showing as installation in progress, so we cancelled the send message which was in progress. When we viewed the status it was showing it got failed for 1000 users and cancelled to around 1500 users. Actually we were testing it only for 3 teams which had hardly 25 users altogether. So, this means if the app is installed with Proactive installation as true the send message to all option sends it to everyone in organization, irrespective of it being installed at tenant level or not.
Kindly suggest what approach to use if we dont want to keep send message to all option to avoid sending it to everyone in organization.


Report attribution by acquisition source to analytics from the tool

The tool only has access to what is already on the user's system, and what is contained in the downloaded archive or pulled from github. Therefore, for the tool to accomplish this, the archive would need to contain the data that the tool should report. Some examples of how to accomplish this:

A referrer url is tracked in a query parameter, which is then injected into the archive server-side before download.
We create different archives based on broad classifications of referrer. The archives each contain the data (e.g. a string in a file in the repo root) that distinguishes among these broad classifications.

Alternately, the referrer at the time of download could be stored in a cookie, which the tool could then extract. I'd consider doing this only if (1) and (2) are not possible since it entails an n^3 OS/browser/browser version implementation and testing blowup in the tool.
@sfshaza2 I was referred to you for help (or routing to the right person) on the website side of things.
@jonahwilliams for thoughts.
/cc @jayoung-lee

Since new downloads have a special button on flutter.dev, handling this in the backend via a referrer url seems like the most straightforward. It doesn't correctly require the tool to shuffle data from the local system correct/safely

@jonahwilliams sorry I was unclear. The goal is to get an acquisition source associated with tool commands and events. Website analytics already collect referrer data etc., but there is a disconnect between website and tool analytics, and the goal is to bridge some of the gap.

@zanderso, we are woefully short on infrastructure support for the website these days, but I do have a suggestion. You might want to spin up a convo between, @johnpryan, @RedBrogdon, and @dnfield. (Dan has been helping out with the website infrastructure and may have some insight, though this isn't related to what he's been doing. John and Andrew are DPEs on our team. You might want to go right to a meeting, rather than trying to resolve this here.

@zanderso - the site today does not have any backend capabilities that would be able to help with this.  I'm also not sure how any of this would work for people who just clone directly from GitHub.
What's the goal here?  Wouldn't the referrer almost always be either flutter.dev, one of the mirror sites, or none (because they got it from GitHub directly via git clone)?


:sparkles: Add Google Analytics

For those interested in traffic analysis, you could include a feature which enables Google Analytics.

merged into
https://github.com/seehase/neowx-material/pull/15


Updates to Hub browser with updated Auth SDK

Closing. The code has already been updated to the latest beta version of the SDKs.


CORS issue with 0.2

We had this issue, and found this loggly forum discussion where a few others confirmed it:
http://community.loggly.com/customer/portal/questions/16136807-posting-logs-with-cors?b_id=50
We downgraded to 0.1.3 and the problem went away.
From what I can tell, 0.1.3 used the tracking pixel method, and 0.2 uses an XHR request, so the browser initiates an OPTIONS pre-flight request with the following headers:
Access-Control-Request-Headers:accept, authorization, content-type
Access-Control-Request-Method:POST

And the loggly server rejects it with:
Request Method:OPTIONS
Status Code:405 Method Not Allowed

I assume some people are using 0.2 successfully, so just wondering if there something different we should be doing in configuration?

@chrissimon-au There is a fix for CORS headers pending from #41.  I'll cut a release with that fix and see if that helps in 0.2.

@chrissimon-au I confirmed the fix in #41 solves this issue.  I just cut a new release 0.2.2.  Please let me know if you continue to have issues.  Thanks!

Great, thanks @ajbrown - appreciate the rapid response!


mir_robot: 1.0.0-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository mir_robot to 1.0.0-0:

upstream repository: https://github.com/dfki-ric/mir_robot.git
release repository: https://github.com/uos-gbp/mir_robot-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.6.6
previous version for package: null

mir_actions
* Initial release
* Contributors: Martin Günther

mir_description
* Initial release
* Contributors: Martin Günther

mir_driver
* Initial release
* Contributors: Martin Günther

mir_gazebo
* Initial release
* Contributors: Martin Günther

mir_msgs
* Initial release
* Contributors: Martin Günther

mir_navigation
* Initial release
* Contributors: Martin Günther

Yes, I have. The invitation is still awaiting @ros-pull-request-builder's response though.


Utilize the Primitive type only when required

If the paremetric or return type is the pure primitive type, do not wrap it into the Primitive type.
class Something { ... } // -> Primitive<Something>
interface ISomething { ... } // Do not wrap

Have tried but it's hard to determine the exact primitive type because of the type aliases.
Therefore, delay this issue for a while.


Capture not linking despite port being available

The capture is not linking. But the port is available and reachable by Webbrowser.

I think this is a problem with socket io connections between the capture and galactus. A simple Javascript Socket-io client is able to connect to the socket.io server. However, the capture does not.
https://github.com/denverquane/amonguscapture/issues/104


fix: disable clone for v2 volume

Which issue(s) this PR fixes:

longhorn/longhorn#9106
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context

@mergify backport to v1.7.x


Add CI for udep

we want to add cargo +nightly udeps --all-targets to our CI tests. This will ensure that we do not have any unused crates so that we don't have any unneeded dependencies.
Edited by @Autoparallel

Low prior


./configure not found with gitClone method

When running with new updates and git Clone, the configure script is not generated until after autogen.sh is run.  How to work around this?
/secp256k1.sh: line 94: ./configure: No such file or directory

I add a work around for the git clone feature, refer the latest code
Thank you

Thanks! I had a pull request but you fixed it already :)


set (target) dataset path correctly in RecursiveCopyableDataset

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-XXX

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (42f1be5) 46.76% compared to head (c71fc2d) 46.03%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3867      +/-   ##
============================================
- Coverage     46.76%   46.03%   -0.74%
+ Complexity     9674     2188    -7486
============================================
  Files          1877      417    -1460
  Lines         75200    18054   -57146
  Branches       8400     2199    -6201
============================================
- Hits          35168     8311   -26857
+ Misses        36851     8861   -27990
+ Partials       3181      882    -2299

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Email domain not populating

Describe the bug
Once deployed, the application shows example.com as the email domain with no option to change.
To Reproduce

Deploy the application
Access the domain and see email domain option being grayed out

Expected behavior
See actual email domain options
Actual behavior
It shows @ example.com
Screenshots

Sorry to create two issues in two days!

Sorry to bump but has anyone else seen this?

Yes, I'm working on this to complete my project (https://github.com/LeoColomb/dispoflare/tree/feat/rework).
Currently, on main branch is a simple PoC, and even if the domain is not populating, the form should work fine.
That being said, if you're working at Cloudflare it is very weird to read you putting pressure like this…

@LeoColomb thank you for the cool project!
I also didn't realize it was just a PoC for now.
It might be a good idea to add a warning at the top of the readme
to prevent users from assuming it's ready for usage.

Here we go, no more a PoC! 😃
Probable room for improvement on UX side, but all the main features are working now, and data is populating correctly.
It should also be easier to deploy using the “Deploy” button (I hope so)

Here we go, no more a PoC! 😃
Probable room for improvement on UX side, but all the main features are working now, and data is populating correctly.
It should also be easier to deploy using the “Deploy” button (I hope so)

Awesome thank you!


Never responds again after network error

Last night I was working with this, and found once there is a network error, button presses are ignored from that point on. If I can replicate it tonight, I will add an exception trace to this issue, and see if I can see where the code is actually failing.
I found an old USB plantronics headset was sufficient as a single-input single-output device for Audio. This also allows me to talk to the Assistant without anyone else getting too annoyed with me, which is nice. I was pushing the button described in https://github.com/androidthings/sample-button and after only a few tries, sometimes after 20 or so questions answered, the assistant service would throw an exception, and then I'd have to reboot the device.
After reboot, I would have to wait several minutes before the Pi3 board had a correct System Time (it starts off with EPOCH time, Jan 1, 1970) and the SSL connection fails.
Then I'd be able to push the button again for a little while before the first exception would cause the button to become non-responsive.
I'll look into this more, this evening, and add to this report.

Here's the stack trace I am seeing:
7-12 01:02:05.824 725-1397/com.example.androidthings.assistant E/AssistantActivity: converse response error: # com.google.rpc.Status@91ef3c9b
                                                                                code: 14
                                                                                message: "Service unavailable."
07-12 01:02:06.806 725-1397/com.example.androidthings.assistant E/AssistantActivity: converse error:
                                                                                io.grpc.StatusRuntimeException: UNKNOWN: Unknown Error.
                                                                                at io.grpc.Status.asRuntimeException(Status.java:540)
                                                                                at io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onClose(ClientCalls.java:392)
                                                                                at io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:428)
                                                                                at io.grpc.internal.ClientCallImpl.access$100(ClientCallImpl.java:76)
                                                                                at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl.close(ClientCallImpl.java:514)
                                                                                at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl.access$700(ClientCallImpl.java:431)
                                                                                at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInContext(ClientCallImpl.java:546)
                                                                                at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:52)
                                                                                at io.grpc.internal.SerializingExecutor$TaskRunner.run(SerializingExecutor.java:152)
                                                                                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
                                                                                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
                                                                                at java.lang.Thread.run(Thread.java:761)

I have encountered this issue occasionally as well, although I don't know how to reproduce reliably.

@nealsanche @Fleker I'm curious if after further button presses will trigger the same error again and again?
Pressing the button again should repost the mStartAssistantRequest Runnable:
https://github.com/androidthings/sample-googleassistant/blob/master/app/src/main/java/com/example/androidthings/assistant/AssistantActivity.java#L347

Yes the same error happens consistently after the app gets into that state.
I have to kill and restart the app to get it functional again.
On Wed, Aug 9, 2017, 6:07 AM Johan Euphrosine<EMAIL_ADDRESS>wrote:

@nealsanche https://github.com/nealsanche @Fleker
https://github.com/fleker I'm curious if after further button presses
will trigger the same error again and again?
Pressing the button again should repost the mStartAssistantRequest
Runnable:
https://github.com/androidthings/sample-googleassistant/blob/master/app/src/main/java/com/example/androidthings/assistant/AssistantActivity.java#L347
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/androidthings/sample-googleassistant/issues/32#issuecomment-321236424,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFHsyakT77Qc43dIpTPHnvcOPnf18Y-Yks5sWaEegaJpZM4OUy2u
.

--
Neal Sanche* | Android Tech Lead*
*(c)**403.870.2356 **(o)*888.740.0967
http://robotsandpencils.com
--
Robots and Pencils Inc | 1507 14th Ave SW Calgary AB T3C 0W4
You can unsubscribe from the Robots and Pencils mailing lists by clicking
here. https://robotsandpencils.com/contact/unsubscribe.html

I have the same error, the only different is that I use other mic array board (MATRIX Creator), not voicehat.
My fork: Google Assistant code for MATRIX Creator
Output:
com.example.androidthings.assistant E/AssistantActivity:
converse response error: # com.google.rpc.Status@91ef3c9b
code: 14
message: "Service unavailable."
com.example.androidthings.assistant E/AssistantActivity:
converse error:
io.grpc.StatusRuntimeException: UNKNOWN: Unknown Error.
at io.grpc.Status.asRuntimeException(Status.java:540)
at io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onClose(ClientCalls.java:392)
at io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:428)
at io.grpc.internal.ClientCallImpl.access$100(ClientCallImpl.java:76)
at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl.close(ClientCallImpl.java:514)
at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl.access$700(ClientCallImpl.java:431)
at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInContext(ClientCallImpl.java:546)
at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:52)
at io.grpc.internal.SerializingExecutor$TaskRunner.run(SerializingExecutor.java:152)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
at java.lang.Thread.run(Thread.java:764)

My own answer,
I resolved issue or I found the problem in the implementation on Audio Driver (UserDriver) for my hat (MATRIXCreator), but maybe is similar issue for VoiceHat or USB plantronics headset from @nealsanche. When the audio buffer on read interface implementation below is wrong and it sending maybe empty buffer or a bad ByteBuffer to GRPC service, it reproduce the issue. Maybe the issue or bug on Google Assistant service is a missing message or missing empty buffer detection.
private class AudioInputUserDriver extends AudioInputDriver {
        @Override
        public void onStandbyChanged(boolean b) {
        }

        @Override
        public int read(ByteBuffer byteBuffer, int i) {
            try {
                // VoiceHat => mDevice is I2S device
                // MATRIXCreator => mDevice is custom wishbone device (SPI)
                return mDevice.read(byteBuffer, i);
            } catch (IOException e) {
                Log.e(TAG, "[MIC] error during read operation:", e);
                return -1;
            }
        }
    }

Details in my fork.

Did you resolve the issue in your fork, or do you believe you found where the issue may be?

Apparent I resolved the issue in my fork, maybe was it a possible bad  audio buffer implementation, but too maybe the GRPC assistant service haven't error messages for bad or empty buffers.

I looked at your code. Are you still using the VoiceHat driver? I didn't see how your user driver was any different.

No, I don't use VoiceHat hardware, for now I still creating MATRIX Creator user driver, the difference is in the buffer handler and device type:
My extend from InputDriver not use I2S protocol, use SPI handler (micArray class):
    private class AudioInputUserDriver extends AudioInputDriver {

        @Override
        public void onStandbyChanged(boolean b) {
        }

        @Override
        public int read(ByteBuffer byteBuffer, int i) {
            try {
                return micArray.readFromDevice(byteBuffer, i);
            } catch (IOException e) {
                Log.e(TAG, "[MIC] error during readFromDevice operation:", e);
                return -1;
            }
        }
    }

And micArray class implements read buffer like next (see details in MicArray class)
   public int readFromDevice(ByteBuffer byteBuffer, int i) throws IOException {
        if(isReadyData&&!stopService) {
            int oldpos = byteBuffer.position();
            for (int x = 0; x < (i / 2); x++) {
                byteBuffer.putShort(mic0.poll());
            }
            int newpos = byteBuffer.position();
//            Log.d(TAG, "[MIC] byteBuffer bytes read: "+(newpos-oldpos));
            return newpos - oldpos;
        }
        return 0;
    }

Right now it works fine, but in my first tries maybe my buffer handler was sending a wrong buffer read, and GRPC was fails. I don't know if this, maybe helps a detection of this issue for another devices, like the USB device in thread here.

#42 isn't the same. The error is different for my case -
                                                                                io.grpc.StatusRuntimeException: INTERNAL: Received unexpected EOS on DATA frame from server.

Using
        classpath "com.google.protobuf:protobuf-gradle-plugin:0.8.2"
instead of
        classpath "com.google.protobuf:protobuf-gradle-plugin:0.8.0"
fixes it for me

I'll try updating that plugin version and test it myself.


⚠ Bofrost.at has degraded performance

In 67555f8, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 3134 ms

Resolved: Bofrost.at performance has improved in bb84b57 after 17 minutes.


customers: deploy with vault secret storage

The Customers service should be deployed with vault as its storage backend. This is in part to prove out it works, but also as a better deployment example for production and audits.

I've been having issues getting this working. Here are some issues I've ran into.

https://github.com/coreos/vault-operator/issues/366
https://github.com/hashicorp/vault/issues/7001
https://github.com/etcd-io/etcd/issues/10319
https://github.com/banzaicloud/bank-vaults/issues/105
https://github.com/coreos/etcd-operator/issues/1995

Customers seems okay using the local Go Cloud Dev SDK provider to base64 encode encrypted secretes. There doesn't seem to be a need to also store these in Vault.


Improve MacOS build, faster, more stable at least a bit less complex.

Removed unnecessary copy of .dmg file. Also pack it now differently. Most part is now in Resources and the StartScript is in MacOs folder.

whats the generated arangod.conf? is it all good? or are all relevant settings overriden by the shellscript?
Are logs created in the users library folder?
Did you try from a clean build including V8-Party?

I checked on my system that the conf and the folders are created correctly.
It is independent of the build, as it only affects packageing.
I manually tested if resulting image is Codesigned and arangodb is starting properly.


Supabase Start Error Requested image not found

Describe the bug
I tried to run npx supabase start after running npx supabase init and npx supabase link --project-ref
I get the following error from the CLI: Error response from daemon: manifest for public.ecr.aws/supabase/postgres:<IP_ADDRESS> not found: manifest unknown: Requested image not found
To Reproduce
Steps to reproduce the behavior:
npx supabase init
npx supabase link --project-ref
npx supabase start
error message: Error response from daemon: manifest for public.ecr.aws/supabase/postgres:<IP_ADDRESS> not found: manifest unknown: Requested image not found
Expected behavior
Supabase starts locally
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS] - macbook m1
Browser (if applicable) [e.g. chrome, safari]
Version of CLI [e.g. v1.60.0] - 1.110.1
Version of supabase-js (if applicable) [e.g. v2.22.0]
Version of Node.js (if applicable) [e.g. v16.20.0] - v18.18.0
Docker version - 24.0.6

Additional context
I checked another issue that mentioned possibly a version issue between 14 and 15. When I run SELECT VERSION() in supabase SQL editor I see 'PostgreSQL 15.1 on aarch64-unknown-linux-gnu, compiled by gcc (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0, 64-bit' and the major_version in my config.toml is 15.

That worked. Thanks for the help!


Gulp Task Runner

Resolves #38. Added Gulp with Babel, UglifyJS, ESLint. I also added UMD so the index.js can be used in both browser and Node. I added gulp as a prepublish and as a build command. @superhackerboy Would you mind connecting a continuous integration service to this repository to run builds on commits and pull requests?

Hey I'm not sure what that does or how to do that. Can you create a new issue, link me something, or tell me what privileges you need?

@superhackerboy here is github's docs for CI https://docs.github.com/en/actions/building-and-testing-code-with-continuous-integration/about-continuous-integration


MYNEWT-715 Extended Advertising - Advertiser support for controller

This adds support for controller for Extended Advertiser. Included:

all HCI commands and events for setting advertising instances
support for all types of AUX advertising PDUs
advertising using Coded and 2M PHY
Android extensions are removed in favor of new commands

Limitations (will be address in followup PRs):

Advertising Data and Scan_Rsp are still limited to 31 bytes
no chaining support (only 1 AUX_ADV_IND per advertising event)
advertising duration parameter is ignored (only events count is implemented)

Changes looks good to me.

I've updated PR branch.  Fixed nitpick pointed by WIll and fixed sending scan req notification to host.

I've updated branch with comments addresses (except flags define which I left as is)

Thanks, looks good.


Removing splunk integration

What is the context of this PR?
As a part of reviewing the logging we don't use the splunk integration hence we are removing it.
Related to structured logging
How to review
Tests pass

Will this not be needed going forward? Or are the splunk team only concerned with logging SDX traffic?
Or is splunk just slurping everything in from Syslog?

To clarify we don't actually integrate with splunk via this integration or at all yet. I think the plan is to log to syslog or sysout and something collects and forwards the logs on to splunk


Proxy: Improve DNS name parsing

Signed-off-by: Brian Smith<EMAIL_ADDRESS>

PR #673 was backed out due to causing TestCheck to fail. I'm now splitting that PR up into three PRs to be reviewed separately. This is the second commit from that PR, with the additions to address Oliver's review comments in that PR.

I verified that TestCheck and all other tests pass with this commit, without any changes. The regression must be in the third commit from PR #673. If the regression has something to do with this code then the upcoming PR replacing the third commit from PR #673 will fix it.


Typos / Null check / Library updates / Fixed connection status events

I submitted these pull requests to flyingxu's fork and he accepted them, but said that it would be better if I submitted them directly to the base repository

@fozzzgate Great job :) Thank you :)


Can't add f64 + {float}

fn foo(x: f64) {
    let y = x + 1.0;
}

error[E0277]: cannot add `{float}` to `f64`
 --> <source>:2:15
  |
2 |     let y = x + 1.0;
  |               ^ no implementation for `f64 + {float}`
  |
  = help: the trait `Add<{float}>` is not implemented for `f64`
  = help: the following other types implement trait `Add<Rhs>`:
            <&'a f64 as Add<f64>>
            <&f64 as Add<&f64>>
            <f64 as Add<&f64>>
            <f64 as Add>

error: the type `fn(f64, _) -> <f64 as Add<_>>::Output` is not well-formed
 --> <source>:2:15
  |
2 |     let y = x + 1.0;
  |               ^

That WF error is strange.

Probably also fixes: tests/ui/associated-types/issue-18655.rs

Oh, we were canonicalizing float vars wrong. Easy fix. Phew.


benchmarks/iperf: add rubygem-rexml dependency

Adds the missing rubygem-rexml dependency to os-iperf
This makes the service startable and allows the Interfaces -> Diagnostics -> iperf GUI to work again
Fixes #3522

I allow this since rubygem-rexml happens to be in our binary packages, but I'd rather have someone rewrite the ruby script to python or remove the plugin altogether if it breaks again.
Merged, thanks!


Proposal page no longer updates automatically to show what user voted for

Description
This has been introduced in regression where the proposal page no longer updates automatically when user votes for/against a proposal.

Go to an open proposal
Vote for or against the proposal

Result:

Page updates when user manually reloads the page

I was not able to replicate this issue. Closing for now

Banging my head against a brick wall with this one. I'll pick it up again soon when I don't want to throw my monitor out the window


bug: Long textarea in ion-content can't type or scroll

Type: bug
Platform: ios 7 webview
If you put a long textarea in an ion-content, you can't type in it or scroll it.
When would you want to put a long textarea in an ion-content? One example would be our case: we want to show image previews on top followed by an auto-growing textarea. This allows the user to see image previews that scroll off-screen when he scrolls down.
To repro:

Create a blank Ionic starter project.

In index.html, make the body the following:

Ionic Blank Starter

     Preview images:

     Enter a comment:

       Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
       Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
       Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

Run the app on an iPhone.

Scroll down a little bit.

Click the textarea, to bring up a keyboard.

// Expected: You can scroll the textarea
// Actual: You can't scroll the textarea.
// Expected: You can type in the textarea.
// Actual: When you type, nothing seems to happen. What is happening is that you can't see what you are typing because the cursor is actually at the top of the textarea.
// Expected: Clicking the textarea puts the cursor where you click.
// Actual: Clicking the textarea does not move the cursor there.
// Expected: Typing does not put the cursor under the ion-footer.
// Actual: If you type long enough to bring the cursor into view, and continue typing until the cursor is at the end of the viewable portion of the textarea, the cursor disappears behind the ion-footer.

Greetings, @JonathanAquino!
My sensors indicate that this issue has been inactive for a while.
Due to this, the issue will be closed in 7 days.
If you believe the issue has not been fixed, please add a comment.
This will notify us so we can assist you, and will prevent the issue from being automatically closed.
Feel free to include the following information about the issue, so that we may assist you:

Can you provide a detailed description of this issue?
How would a robot go about replicating this issue?
What platform does this happen on? (iOS, Android, all, etc.)
What platform versions does this happen on? (Android 4.2, iOS 7, all, etc.)
Is this an issue with the Ionic Framework, or Ionic CLI?

Thank you for allowing me to assist you.

Is this still an issue?


[Feature Request] Support for Protocol Buffers

Hi @mzabriskie,
It would be nice if Axios will be the library that can support Protocol Buffers response by default not only JSON.
Thank you.
Best,

This is something you can implement using the transformResponse config option or using response interceptors.
Supporting it by default in axios would increase significantly the bundled size, given that we need to include a dependency to parse the received data against a schema. It also doesn't look like something most of our users will use, so I think the best way to go is like I said at the beginning. That feature could also be included in some axios plugin so you don't have to repeat the code every time.


Fusion Chart not showing properly in iOS - WKWebView

In iOS, fusion chart was working fine in UIWebView (as shown below sample image from my project).
Now in iOS, UIWebView has been replaced with WKWebVeiw. After replacing the UIWebView to WKWebView, same fusion graph is not showing properly in the WKWebView.
Graph in UIWebView

Graph in WKWebView

Graph is zoomed out.
Fonts are very small.

Fusion Chart Code
 function showChart(dataChart,chartWidht,chartHeight,chartTypeValue){

  FusionCharts.ready(function(){

  var chartVar = dataChart;
  var ctype;

  // Get Chart Type.
  switch (chartTypeValue) {

    case 1:
    ctype = "stackedcolumn2d";
    break;

    case 2:
    ctype = "pie3d";
    break;

    case 3:
    ctype = "column2d";
    break;

    default :
    ctype = "stackedcolumn2d";
    break;

  }

   var ddd = JSON.stringify(chartVar);
   var ddd2 = JSON.parse(ddd);
   var width = chartWidht;
   var height = chartHeight;

   // Height and width variable are not in use.

   var revenueChart = new FusionCharts({

        "type": ctype,      // 1 == stackedcolumn2d 2 == pie3d 3 == column2d
        "renderAt": "chartContainer",
        "width": "100%",
        "height": "100%",
        "dataFormat": "json",
        "dataSource": ddd2

  });

    revenueChart.render();

 })
 }

System Configuration

Swift 4.x
iOS 12.x

Hi,
Thanks for getting in touch.
From both the image we could find two different data source has been provided.
Could you please confirm whether the same data source has been provided.
Also please let us know if any error you are getting at your end and if possible please upload the entire project in a GitHub repo for further investigations.