Context file contains "undefined" word, making node-red restarting all the time

What are the steps to reproduce?
Unknown.
What happens?
After many days of proper behaviour Node-red could not start. Ended up in an infinite restart loop.
error.log:
Error: Error loading context store: SyntaxError: Unexpected token u in JSON at position 0
at /opt/node-red/node_modules/@node-red/runtime/lib/nodes/context/index.js:177:15
What do you expect to happen?
I expect context files to have consistent data in them in JSON format, so the system will not break ending up in infinite restart loop.
At the moment node-red requires me to delete the context files with "undefined" word to boot properly.
Please tell us about your environment:

[ ] Node-RED version:
[info] Node-RED version: v0.20.5

[ ] Node.js version:
v10.15.0

[ ] npm version:
npm: '6.4.1',
ares: '1.15.0',
cldr: '33.1',
http_parser: '2.8.0',
icu: '62.1',
modules: '64',
napi: '3',
nghttp2: '1.34.0',
node: '10.15.0',
openssl: '1.1.0j',
tz: '2018e',
unicode: '11.0',
uv: '1.23.2',
v8: '6.8.275.32-node.45',
zlib: '1.2.11'

[ ] Platform/OS:
Linux raspberrypi 4.19.42-v7+ #1219 SMP Tue May 14 21:20:58 BST 2019 armv7l GNU/Linux
RPi 3b+

[ ] Browser:
not relevant

The context configuration is a default one:
contextStorage: {
default: {
module: "localfilesystem"
}
},


Submit poster to ESWC?

Assigned to @petermr in first instance, can be reassigned
http://2015.eswc-conferences.org/important-dates/call-posters

Submission Deadline: March 13, 2015
Notification of Acceptance: April 6, 2015
Camera-Ready Paper: April 20, 2015

Demo call also still open
http://2015.eswc-conferences.org/important-dates/call-demos

Submission Deadline: March 13, 2015
Notification of Acceptance: April 6, 2015
Camera-Ready Paper: April 20, 2015


16-bit archives

There's already support for 32-bit and 64-bit archives, adding support for 16-bit archives would round it out to match the options for target_pointer_width and could get back some memory on small archives.

Fixed by dae8a8dcbf821ecae3c46db22069e8d954cbdf07


chore: update routing and extended-operations protos

Probably want this as a feat type?

Probably want this as a feat type?

Good call. Even though updating Protos seems like a chore :P

Are we sure that release-please refers to the PR title instead of the commit message?

I don't think release-please is involved in our process with this repo yet.


The rail of n-slider has problem while using vertical mode.

Describe the bug
The rail of n-slider didn't display while using vertical mode. It looks like the width of n-slider’s rail has some problems.
Steps to reproduce
Using n-slider with vertical prop.
Link to minimal reproduction
https://github.com/dustbin1415/reproduction-of-NSlider-bug
System Info
System:
    OS: Windows 11 10.0.22631
    CPU: (8) arm64 Snapdragon (TM) 8cx Gen 3 @ 3.0 GHz
    Memory: 2.31 GB / 15.43 GB
  Binaries:
    Node: 20.11.1 - C:\Program Files\nodejs\node.EXE
    npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (126.0.2592.81)
    Internet Explorer: 11.0.22621.3527
  npmPackages:
    naive-ui: ^2.38.2 => 2.38.2
    vue: ^3.4.31 => 3.4.31

Used Package Manager
npm
Validations

[x] Read the Contributing Guidelines.
[x] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

Please provide an example where you can run and see this bug as it does not exist in the documentation and its codesandbox.

Please provide an example where you can run and see this bug as it does not exist in the documentation and its codesandbox.

I have already update the hub of reproduction with the whole vue framework. And I'm sure the bug can be seem in that. I just built the project with npm creat vue@latest command and change the vue file.

It’s caused by the universal selector style box-sizing: border-box. Remove or override it.


Automator: update proxy@master in istio/istio@master

Generated by Automator - 2023-04-10T02:54:22+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
5a0a362c17941d172a396cd29cf40ee51ccad807
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests-arm64


Shader uniform vec4 array shows as PackedFloat32Array, breaking future uniforms with the same name.

Godot version
v4.0.alpha.custom_build [ae5668f81]
System information
Arch on 5.18.11-arch1-1
Issue description
See reproduction steps, as it goes through more thoroughly
Steps to reproduce

Make a shader with some working uniforms
shader_type canvas_item;

uniform vec3 my_array1[4];
uniform vec3 my_array2[4];

Change one of them to a vec4 array:
uniform vec4 my_array1[4];

Array type changes to PackedFloat32Array which kinda makes sense, but the values are still Vec3

Rename it to my_array without the number and it changes to this:
Since it's a new variable name, it's pretty much the expected behavior.

Change it back to a vec3 array:
Same variable name so the bug happens. The type changes to PackedVector3Array but the values are still floats.

Minimal reproduction project
(Right after step 1) test15.zip

I'm still running into this on 4.1.3

i'm running into this on 4.2.1 as well


Add cron schedule for verification

@jackkleeman you probably need to rebase this PR, you picked the moment where i had e2e main not aligned with sdk-java main :)

i think for a gha change we can probably cope :D


how to install commandline tools?

I don't see anything in the docu - github or on the website - about how to install the commandline tool.
I see an installer script in the app bundle - but it's using make variables, so it can't be used as-is.
I don't see any UI to trigger this, and I can't find any docu for it either.
There's no makefile, so I can't just cd into the Resources tree and make install it, either....
that pretty much seems to leave either downloading and building from source, or perhaps homebrew?

https://github.com/sveinbjornt/Platypus/blob/master/Documentation/Documentation.md#show-shell-command


MM-13967: Add support for more issue events

Fixed MM-13967: Added support for various ticket update events. Did not add support for worklogs and issue links because these events have only limited data
Fixed MM-8650: removed enable/disable
Replaced SlackAttachments with regular markdown for display

Awesome!! 🎉

Did not add support for worklogs and issue links because these events have only limited data

is the data so limited, that any info we post back would be more-or-less useless?
Not a big deal if we don't support them (less important than the other issue-related events). Just curious so that when someone asks why we don't support it, I'll have the justification ready (we have at least one request for worklogs).

Replaced SlackAttachments with regular markdown for display

UX and I can work out the formatting after this is merged - thinking it might be easier when we see the data sent back.
Curious if there was a reason for replacing SlackAttachments with regular markdown?

I propose to use https://ci-linux-mysql.mattermost.com for testing this. I can set up a test environment, once the initial review is done.

I propose to use https://ci-linux-mysql.mattermost.com for testing this. I can set up a test environment, once the initial review is done.

@jasonblais:
RE: "...the data so limited, that any info we post back would be more-or-less useless": there are neither issue keys nor the user data readily available in these messages. There are internal IDs, so with proper auth/API usage we can get the details later, but the webhooks themselves appear very limited. So, if we need it, will come in v2.
RE: Reason for replacing SlackAttachments with regular markdown. Just seems a lot cleaner without them.Was there a reason that they were used to start with?

Codecov Report

Merging #22 into master will decrease coverage by 32.76%.
The diff coverage is 40.86%.

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
- Coverage   79.05%   46.29%   -32.77%
===========================================
  Files           4        4
  Lines         191      270       +79
===========================================
- Hits          151      125       -26
- Misses         30      137      +107
+ Partials       10        8        -2

Impacted Files
Coverage Δ

server/configuration.go
34.78% <ø> (ø)
:arrow_up:

server/webhook.go
32.78% <32.02%> (-51.49%)
:arrow_down:

server/plugin.go
91.93% <93.33%> (+3.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d885e8a...7332066. Read the comment docs.

@jasonblais @jwilander @hanzei @DHaussermann I updated the code with the PR feedback, you can see it in action at https://i-0cba36c59c7d65ed7.test.spinmint.com/ad-1/channels/autem-2 (sysadmin/sysadmin). It posts from https://levbrouk.atlassian.net/secure/RapidBoard.jspa?rapidView=1&view=planning.nodetail&selectedIssue=TES-39.

@levb Sounds good for issue links and worklogs, not a top priority so let's cut. That explanation helps when going back to customer(s).
Re: attachments, that was a design decision in V1. However, Asaad and I are working on updating them for V2, and we'll compare how the messages look with just plain Markdown.

@hanzei I think I got your change request covered, sorry for the initial misunderstanding.
@jasonblais please confirm with regards to whether to commit this with markdown messages once fully dev-approved, or hold until further UX review.

@levb Please hold for now, I got UI designs from Asaad (unrelated to changes in this PR), will see how the designs compare with the Markdown messages.

My 2 cents on attachments:
For me (and this is a personal opinion) attachments are the "bot way" to show information in Mattermost. When I search for e.g. a new JIRA issue in a channel, I just look out for the style of attachments. It help keeping bot messages separated from user messages.
I know of the technical flaws of slack attachments, but I think this we have decided to have them this way in our system and should stick (for now) with this.
2/5 on sticking with attachments.

@levb Is this ready for a final round of review?

@levb Is this ready for a final round of review?

@hanzei Yes it is. I rewrote much of it to simplify dual-mode md/slack attachment, but stopped short of making it configurable.

Thanks @levb. It would be good to see the formatting of the new events before merging.

@levb As discussed last week, we can merge and test on community-daily. We have designs from Asaad, but they can be done on a separate PR.


AmazonBedrockChatGenerator de/serialization issue

Describe the bug
The serialize_callable function in callable_serialization.py throws an AttributeError when the callable_handle argument is None.
Error message
AttributeError: 'NoneType' object has no attribute 'name'
  File "~\AppData\Local\Programs\Python\Python311\Lib\runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~\AppData\Local\Programs\Python\Python311\Lib\runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "~\.vscode\extensions\ms-python.debugpy-2024.2.0-win32-x64\bundled\libs\debugpy\adapter/../..\debugpy\launcher/../..\debugpy\__main__.py", line 39, in <module>
    cli.main()
  File "~\.vscode\extensions\ms-python.debugpy-2024.2.0-win32-x64\bundled\libs\debugpy\adapter/../..\debugpy\launcher/../..\debugpy/..\debugpy\server\cli.py", line 430, in main
    run()
  File "~\.vscode\extensions\ms-python.debugpy-2024.2.0-win32-x64\bundled\libs\debugpy\adapter/../..\debugpy\launcher/../..\debugpy/..\debugpy\server\cli.py", line 284, in run_file
    runpy.run_path(target, run_name="__main__")
  File "~\.vscode\extensions\ms-python.debugpy-2024.2.0-win32-x64\bundled\libs\debugpy\_vendored\pydevd\_pydevd_bundle\pydevd_runpy.py", line 321, in run_path
    return _run_module_code(code, init_globals, run_name,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~\.vscode\extensions\ms-python.debugpy-2024.2.0-win32-x64\bundled\libs\debugpy\_vendored\pydevd\_pydevd_bundle\pydevd_runpy.py", line 135, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "~\.vscode\extensions\ms-python.debugpy-2024.2.0-win32-x64\bundled\libs\debugpy\_vendored\pydevd\_pydevd_bundle\pydevd_runpy.py", line 124, in _run_code
    exec(code, run_globals)
  File "~test.py", line 21, in <module>
    main()
  File "~/test.py", line 14, in main
    yyy = p.dumps()
          ^^^^^^^^^
  File "~\AppData\Local\Programs\Python\Python311\Lib\site-packages\haystack\core\pipeline\pipeline.py", line 196, in dumps
    return marshaller.marshal(self.to_dict())
                              ^^^^^^^^^^^^^^
  File "~\AppData\Local\Programs\Python\Python311\Lib\site-packages\haystack\core\pipeline\pipeline.py", line 118, in to_dict
    components[name] = component_to_dict(instance)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~\AppData\Local\Programs\Python\Python311\Lib\site-packages\haystack\core\serialization.py", line 24, in component_to_dict
    return obj.to_dict()
           ^^^^^^^^^^^^^
  File "~\AppData\Local\Programs\Python\Python311\Lib\site-packages\haystack_integrations\components\generators\amazon_bedrock\chat\chat_generator.py", line 223, in to_dict
    streaming_callback=serialize_callable(self.streaming_callback),
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~\AppData\Local\Programs\Python\Python311\Lib\site-packages\haystack\utils\callable_serialization.py", line 20, in serialize_callable
    full_path = callable_handle.__name__
                ^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute '__name__'. Did you mean: '__ne__'?
Expected behavior
The function should handle the case where callable_handle is None and raise a more descriptive error message. For example, it could raise a ValueError with the message "callable_handle must be a callable, not None".

Additional context
This issue occurs when trying to serialize a None value as a callable, which is not a valid operation.
to reproduce the behavior:
from haystack_integrations.components.generators.amazon_bedrock import (
    AmazonBedrockChatGenerator,
)
from haystack import Pipeline

def main():
    p = Pipeline()
    p.add_component(
        "generator",
        # can be any chat supported model
        AmazonBedrockChatGenerator(model="anthropic.claude-3-sonnet-20240229-v1:0"),
    )
    print(p.dumps())

if __name__ == "__main__":
    main()

FAQ Check
Have you had a look at our new FAQ page?
Yes
System:
OS: Windows
GPU/CPU: I7
Haystack version (commit or version number): Version: 2.0.1
amazon-bedrock-haystack version : 0.7.0
This might be affecting all the generator that uses the streaming_callable (cohere chat generator, ...)

Hey! Thanks for reporting the issue.
This is probably an oversight.
In fact, I see that we generally do that:
https://github.com/deepset-ai/haystack-core-integrations/blob/00354a634b76223f11006ee2998a277f13730e6f/integrations/ollama/src/haystack_integrations/components/generators/ollama/generator.py#L80
Would you like to check if this works and open a simple PR to fix the issue?
If you can't, we will take care of it...

released a new version: https://pypi.org/project/amazon-bedrock-haystack/0.7.1/


How to check if a chart is zoomed

I would like to react to a zoom operation: the user draws a chart, let's say a scatter plot with some tens of thousend points, and then he zooms to see more clearly a portion of it. My question is: is there a way to react to the zoom event? I couldn't find an event related to zoom operations.
My workaround is:

save the initial limits of the axes when the chart is first drawn;
check with plt.Axis() if the actual limits are different than the inital ones.
It would be nice if I could attach that check to an event...

Hey @dprevato, it sounds like you found a pretty good workaround! The windows forms user control has an AxesChanged event you can create a handler for which might be more consistent with what you were initially looking for. The downside there is that I think it's fired as the axes are being changed (click-dragged), not just when they're released (dropped)... but perhaps for that you could create a handler for the MouseUp event if that's the event you wish to target.
Long-term I'm trying to make ScottPlot stateless, so storing previous axis states isn't really consistent with the future design goals, and saving and comparing current axis limits with previous ones on the user side (like you're doing) is probably the best long-term solution for this.
Hope it helps!
Scott

It sure does... I've been studying Scottplot for some time now, and I like it more and more. I will certainly make more questions in the near future :)


HTML

#HTML
##UserStory
As a bootcamp student
I want the pre-work notes to be structured on the web page
so that i can easily find and read information
##Accepted Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed

close


Using sipnat: outbound ua: outbound requires valid UUID! (iOS)

Hay! So i'm using baresip for a project, and i cant figure out why uuid module wont work.
Any ideas on how to get this to work on ios?
here is what i get when i start the sip stack.
aucodec: PCMU/8000/1
aucodec: PCMA/8000/1
aufilt: vumeter
auplay: coreaudio
ausrc: coreaudio
vidisp: opengles
mediaenc: srtp
mediaenc: srtp-mand
mediaenc: srtp-mandf
uuid: fopen() /var/containers/Bundle/Application/3C393CC7-F238-4C22-BDEB-C2E8099F4F1D/example.app/Frameworks/example.framework/uuid (Operation not permitted)
dl: mod: ./uuid.so (dlopen(//uuid.so, 6): image not found)
module uuid.so: No such file or directory
account: creating accounts template /var/containers/Bundle/Application/3C393CC7-F238-4C22-BDEB-C2E8099F4F1D/example.app/Frameworks/example.framework/accounts
dl: mod: ./account.so (dlopen(//account.so, 6): image not found)
module account.so: No such file or directory
Populated 2 audio codecs
Populated 1 audio filter
Populated 0 video codecs
Populated 0 video filters
<EMAIL_ADDRESS>Using sipnat: `outbound'
ua: outbound requires valid UUID!
userAgent

And here is the account
<sip:1000@9999.freeswitch.example.com>;sipnat=outbound;outbound=sip:freeswitch.example.com;auth_pass=1234;

I fixed it by myself. All i ended up doing was copying the account and config files to a diffrent documents dir and wholla!:)

@mathipalm Please I need your help with using baresip on IOS.

Have you tested with the recent IOS versions
Can you assist with working guidelines for compiling for IOS


prerender: false by default

add prerender=1 as a parameter to the URL to enable Server-Side Rendering  (cf.  react_on_rails)

the problem is this is going to be a big semantic change... we have apps in the wild that are assuming prerenender is on.  Perhaps we should do this via a rails config file?  Also thinking of adding as an optional param in the render_component method like this:
render_component "Foo", {param1: 12}, prerender: false, layout: "baz"

Totally agree about adding and optional param to set prerender (à la react_on_rails). Especially, it completes the #148 suggestion (Customize rendered layout)  (@rdlh and me are in the same team)

Okay I can add the prerender option with #148.  How about a default value in initialization?
I think perhaps it should have the following values:  true = always on, false or nil always off, any other symbol means if that symbol is present as a http param then prerendering will be off.
Whatever value is in the config, can be overridden via the call to render_component

Perfect :)

and I assume if you want to get on with it, you can know how to monkey patch the current implementation?

We have too many concerns with this gem (especially, the default routing logic of render_component). Even if we enable Client Only, we don't manage to get react_component right in our view templates in slim. Thus, we will use react_on_rails that is more suited to our needs to ensure a smooth transition of the legacy part of our app.

thanks for the feedback...

Prerendering is now controllable at three levels:

in the rails hyperloop initializer you can say:
Hyperloop.configuration do |config|
  config.prerendering = :off # :on by default
end

in a route you can override the config setting by setting a default for hyperloop_prerendering:
get '/some_page', to: 'hyperloop#some_page', defaults: {hyperloop_prerendering: :off} # or :on

This allows you to override the prerendering option for specific pages.  For example the application may have prererendering off by default (via the config setting) but you can still turn it on for a specific page.

You can override the route, and config setting using the hyperloop-prerendering query param:
http://localhost:3000/my_hyper_app/some_page?hyperloop-prerendering=off

This is useful for development and testing
NOTE:  in the route you say hyperloop_prererendering but in the query string its hyperloop-prerendering (underscore vs. dash).  This is because of rails security protection when using defaults.


FIX Respect SS_BASE_URL scheme in CLI environment

Additionally set _SERVER variables for HTTPS and SSL to respect SS_BASE_URL scheme when executing builds and tasks through CLI. This should solve base tags not being provided with the correct HTTP scheme. This is important to resolve mixed content issues and insecure requests.
Parent issue

https://github.com/silverstripe/silverstripe-framework/issues/10615

I've changed the base of this to 4.12 so it can be in a patch release. I'll merge once CI is green again.


load_model() does not return when layer of model was renamed

keras version 2.2.4 , I also tried 2.4.3
tensorflow 2.2.0
Windows 10 Pro Build 19041
I cannot open a saved model, load_model() newer returns, it runs for ever without displaying an error.
It hapens when the Normalisation layer (not BatchNormalisation) is renamed. Renaming other layers like the dense, doesnt trigger this error.
I tried to integrate the information that the Normalisation layer is initalized into the model that no aditional information is needed.
Is there a posibitly to see if a Normalisation layer is allready initialized (adapt())?
Is there a posibility to load these models somehow or are they lost?
The following code demonstrates my problem:
The first load works, but the second just leads to high CPU load.
I get this output form the Code:
INFO:tensorflow:Assets written to: test.nn\assets
WARNING:tensorflow:No training configuration found in save file, so the model was *not* compiled. Compile it manually.
load sucessfully model
INFO:tensorflow:Assets written to: test.nn\assets

Code:
from tensorflow.keras.layers import Dense, Input
from tensorflow.keras.layers.experimental.preprocessing import Normalization
from tensorflow.keras.models import Model, load_model
input_tensor = Input(12)
o = Normalization(name="uninitialized_input_normalisation")(input_tensor)
o = Dense(units=10, activation='relu', use_bias=True)(o)
o = Dense(2, use_bias=True)(o)
m = Model(inputs=input_tensor, outputs=o)
m.save("test.nn")
m1 = load_model("test.nn")
print(f"load sucessfully {m1.name}")
for layer in m.layers:
    if hasattr(layer, 'adapt') and layer.name == "uninitialized_input_normalisation":
        layer._name = "input_normalisation"
m.save("test.nn")
m1 = load_model("test.nn")
print(f"load sucessfully {m1.name}")

Thanks in advance

@blubbrezn I think once you rename any layer, you need to reconnect layers as shown below. Otherwise, Functional model will be looking for old-name ("uninitialized_input_normalisation") which doesn't exist anymore. Just added one line to your code.
for layer in m.layers:
    if hasattr(layer, 'adapt') and layer.name == "uninitialized_input_normalisation":
        layer._name = "input_normalisation"

# connecting renamed layers
m = Model(inputs=m.input, outputs=m.output)

Here is a gist for a reference. Thanks!


Add SignUp/SignIn Feature

I have Added SignUp and Login feature in the index.html file.

@flyingsonu122 please review the PR.


Inserting HTML in an ng-embed shown as text instead of rendered HTML

Hi,
I noticed after https://github.com/ritz078/ng-embed/pull/15 inputting HTML into a div that is using ng-embed does not render the HTML but instead it is shown as text. Is there any way to support inputting HTML using ng-embed? I currently have comments panel where a user can be mentioned, these mentions are detected and wrapped in anchor tags with the appropriate classes. Removing the sanitize code renders the HTML correctly because < and > are not encoded. Would it be possible to fix this by decoding the encoded HTML just before returning the input (after insertFontSmiley, insertEmoji etc has been called). Thanks.
Kind regards,
Rishi.

I will have to make this optional. Will add this in the next release. Just a bit busy with other projects.

Thank you, looking forward to this enhancement!

Since adding sanitizeHtml option ngEmbed can render html. I'm not sure it can render any html but simple tags like , ,  work if you set the option of sanitizeHtml to false.

I am in struggle because I need to use  tag and it doesn't works.
It convert it like <a href="".....
Toggle sanitizeHtml change nothing.
What can I do please ?


Storyboard TableView

Can this work with a tableview within a storyboard or does it require a programatically created one?

Why do you closed the issue? I have the same problem, with a storyboard...


It keeps crashing

Plz help Mr zhuowi block launcher for mcpe 0.13/1 keeps crashing it says it supports Android version 6.q but I have Android 5.0 for my next book and I can't update it plx help

You're using an Intel Atom device, right? Which mods/texture packs are you using?


Darkmode for iOS

Hi ,
would be grade when a Darkmode is possible for iOS
Sent with GitHawk

dark power full ios
Sent with GitHawk

Sent with GitHawk

#~~```

```~~
```

Sent with GitHawk


Add thws.de to the list of de-domains

@SirPalamedes First stage of verification passed, official domain is thws.de as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@SirPalamedes Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Permission authorization happening inside of the permission policy

Expected Behavior

We actually could see a few alternatives on expected behavior - would love consultation of intent from plugin author
Actual Behavior

If an adopter installs the playlist plugin, features within the playlist plugin do not respect the (presumably) intended behavior.
Context
Original PR
So sorry to mislead you in the comment in the original PR! Upon some further thought and discussion, we've discovered some issues with the pattern established by the playlist plugin inside the permission policy here. We understand that the exposed DefaultPlaylistPermissionPolicy is only meant to be a default version of a possible policy that an adopter could implement. However, the structure of the current policy means that authorization is happening inside the policy instead of inside the plugin. This is an anti-pattern since it places the protection of possibly sensitive data under the control of the adopter's policy. If the adopter installs the plugin but does not configure the policy, for example, you may be exposing entities/access/features that you do not intend.
Of course, the nature of what is considered sensitive is highly dependent upon the context of the plugin, and we're not sure if the plugin author, in this case, is ok with this exposure, but regardless of intent we think it would be good to do the following:

move the authorization out of the policy and inside the plugin (this should be fairly straightforward since the plugin is already integrated with the permission framework)
rollback to the AllowAllPolicy in the example backend
consider refactoring the permission framework integration, with more of a focus on exposing sensible permissions instead of exposing a default policy

hmm ...
The original intent here was to follow the same convention as the catalog plugin as the example. In the same way that the default out of the box experience (from my understanding) does not inherently enforce any default policy (eg. any user can read/delete any entity) and it's up to the adopter to author their own policy as part of the permissions backend configuration to place the proper access controls desired.
In the same manner, the out of the box experience of the playlist plugin also does not make any assumptions on how to enforce access control (anyone user can edit/delete any playlist), it has the permissions framework integrated in appropriate access points the same way as the catalog and also relies on the adopter to write the desired policy. With the DefaultPlaylistPermissionPolicy, I was hoping to provide a "batteries included" (though not "batteries installed") experience where the adopter can make use of a sensible default (by installing said included batteries if desired or using different batteries, to continue this analogy 😄)

This is an anti-pattern since it places the protection of possibly sensitive data under the control of the adopter's policy. If the adopter installs the plugin but does not configure the policy, for example, you may be exposing entities/access/features that you do not intend.

I'm am not sure I understand your statement here as I thought this was the purpose of the permissions framework? Shouldn't the adopter be responsible for configuring the desired policy?
I do understand the concern of possible footguns due to shipping plugins that are by default "open-access" but I'm also not sure what the current stance is on what warranties we explicitly provide if the adopter doesn't correctly configure their desired access control (again pointing to the catalog plugin as an example where by default is also "open-access")
However I do fully support additional enhancements to the permissions framework to be able to provide a better "batteries included & preinstalled" approach 😁 The shipping of a default policy was just my initial idea of introducing this kind of pattern that works with the current framework.
Let me know if I misunderstood anything here!

I think the main thing to focus on are private/public playlists, the rest I believe is more of a grey area that is most likely fine to keep.
As a user I think it's fair to assume that private playlists are private, and that apart from perhaps some admins, I'm the only one that can see them. There also isn't any other use of the private/public distinction a part from access control. The tricky bit then is if you don't install the default permission policy, where all of a sudden there's no distinction between private and public playlists at all. In the end it means that if you don't install the default permission policy, you end up with unexpected behavior, and that's the core of the issue.

As a user I think it's fair to assume that private playlists are private, and that apart from perhaps some admins, I'm the only one that can see them.

Fair point! I guess one thought I had was that an adopter may not want to support the distinction of private vs. public playlists and would like everything to always be pubic. However that would probably also require additional customization of the frontend UI to remove that option completely (which could potentially be part of future changes to expose more customization options, listed under "Future enhancements" in my original PR 😁)
Either way, this was originally implemented to be as flexible as possible to leave it up to the adopters interpretation how public vs private, personal vs team owned, etc. should be enforced and instead of making just an exception for the public vs private use-case, I like the following idea by @Rugvip:

I would add that if there's a strong desire to keep the existing flexibility in the access control, it could make sense to expose an option (probably in code) to disable the built-in authorization and defer that to the permission policy, just like it works today.

My vote is that we probably want it to be an opt-in to the built-in authorization instead of opt-out if we're establishing this as a general pattern and want the adopters "master policy" to always take precedence (though this brings us back to the original problem at hand of the adopter mistakenly misconfiguring their policy 😕)

@kuangp I think as a general pattern it's best to make sure that a plain installation of a plugin does not lead to surprising or insecure behavior, even if it skips parts of the README. I feel that in this case it's perhaps not critical, but since you've ended up in the situation of setting a bit of a precedent here, I'd say it's needed. With that all I mean we should go for opt-out. That's unless we can find some other way to handle it that is also safe, but all out of ideas atm.

hm fair enough! Then perhaps we can do something like
router.get('/:playlistId', async (req, res) => {
  const decision = useDefaultPolicy ? await defaultPolicy.handle(...) : await permissionEvaluator.authorize(...);
  ...
});

where useDefaultPolicy defaults to true is is overridable through the createRouter() options.
Or, alternatively if we can modify PermissionEvaluator with an API to accept and apply a default policy if enabled 🤔

Yep I think something like the first thing you're suggesting, can iron out details in review.
The PermissionEvaluator approach sounds like a more complex way to achieve the same thing I would think? So probably not that 😅

The PermissionEvaluator approach sounds like a more complex way to achieve the same thing I would think? So probably not that 😅

Ah this idea was more for abstracting this pattern into the permissions framework so other plugins can easily apply the same convention in the future but probably something to revisit down the road 🙂

What about handling this logic in configuration, rather than through createRouter options? Feels like it makes it a bit easier to document the behaviour, and also seems like a nicer standard to encourage people towards: you can enable and disable the permissions framework completely by toggling permission.enabled, and you can enable and disable integration with permissions per-plugin by toggling a configuration option too?

you can enable and disable the permissions framework completely by toggling permission.enabled, and you can enable and disable integration with permissions per-plugin by toggling a configuration option too?

That is definitely an interesting idea! There could be a parallel with the backend.database config where we follow the same pattern by establishing something like the following:
permission:
  enabled: true | false
  plugin:
    [pluginId]:
      enabled: true | false
      policy: 'default' | 'master' # might need to iron out the details here a bit

@Rugvip thoughts?

Hmm, what does this mean?
permission:
  enabled: true
  plugin:
    playlist:
      enabled: false

I'm feeling that the sensible way forward would be to add it to the createRouter options, since switching off the auth checks are tightly coupled with updating the entity policy, both of which are in code. You also wouldn't ever be varying the setup in different environments either I would think, which is the primary purpose of the configuration.

Related: #18064


dasharo-compatibility/memory-speed-displayed.robot: added

Replaced by: https://github.com/Dasharo/open-source-firmware-validation/pull/243 Please have a look @filipleple


when I trim the video and send to firebase it showing "type" as application/octet-stream instead of video/mp4 why how can I fix this

when I trim the video upload it to firebase it showing "type" as application/octet-stream instead of mp4

see this image

Problem is with com.googlecode.mp4parser:isoparser:1.1.22 it some how fucks up the file.
last version that doesn't mess up things is com.googlecode.mp4parser:isoparser:1.1.14
I wasted whole day to fix this f***ing issue :)

I think you need set the extension of the video manually


Add partial invoice support

For more details see https://qr-faktura.cz/

Please use same indentation in new code as is in current code (tabs instead of spaces)

Fixed


CORS: 404 request for all OPTION requests

Describe the bug
I get a 404 for OPTIONS requests, that work with GET.
I've tried preflightContinue: true that didn't help either
To Reproduce
app
  .use(cors({origin: '*'}))
  .options('*', cors({origin: '*'}))
  .get('/collection', async (_, res) => {

Versions

node: 14
@tinyhttp/cors: 1.1.5
@tinyhttp/app: 1.1.12

@tim-field do you have an idea of how to fix this?

@tim-field can you please try using #231 or through my sample repo here: https://github.com/aldy505/tinyhttp-cors-test

@aldy505 should be fixed with the new version:
pnpm i<EMAIL_ADDRESS>


Reading BAM/SAM file - ERROR - CIGAR string is not present in PAF at line 2364  8479    37257382        37251209        6116    6174    95.73   1       -1      chr01   chr22. Exiting

Hi Manish，
when I run 'fixchr -c S.P.filter.coords -r S.genome.fa -q P.genome.fa -F P',it showed 'Reading BAM/SAM file - ERROR - CIGAR string is not present in PAF at line 2364  8479    37257382        37251209        6116    6174    95.73   1       -1      chr01   chr22. Exiting.' .The S.P.filter.coords file is the output of 'show-coords -THrd' .
I'm wondering which file should be the input(alignment.paf) for fixchr and how to get it ?
Best,
Lily

Hi @ShirelyI . You can use fixchr with either .paf files generated by minimap2 (using -F  P) or with .coords files generated by mummer/show-coords (using -F T). Write now the input file and the -F parameter are inconsistent. Also, if you want to use the .coords file, then you also need to provide the .delta file as input using the -d parameter.

As you wanted to run syri, you need to now align the newly generated ref.filtered.fa and qry.filtered.fa. Then use these fasta files and the newly generated alignments as input for syri. The order of chromosomes in the query genomes do not matter and will not affect the analysis.
Regarding dotplot, the homologous_strand_corrected.pdf contains the final plot. If you want to re-plot it from homologous_strand_corrected_alignments.txt then you will need to delete the first row containing the header and then use it with dotplot.

As you wanted to run syri, you need to now align the newly generated ref.filtered.fa and qry.filtered.fa. Then use these fasta files and the newly generated alignments as input for syri. The order of chromosomes in the query genomes do not matter and will not affect the analysis.
Regarding dotplot, the homologous_strand_corrected.pdf contains the final plot. If you want to re-plot it from homologous_strand_corrected_alignments.txt then you will need to delete the first row containing the header and then use it with dotplot.
Hi Manish,
Thanks for your reply!
I'll  run syri after align the newly generated ref.filtered.fa and qry.filtered.fa files.
The 'homologous_strand_corrected.pdf' file is as follows :

As you said, 'The order of chromosomes in the query genomes does not matter and will not affect the analysis'.Do you mean that although the order  of chromosomes in the genome has changed, the collinearity is still refchr01-qrychr01,refchr02-qrychr02...refchr24-qrychr24 as my origion collinear result? if so ,why the plot shows refchr02-qrychr24,refchr03-qrychr14 etc？
Besides, it seems like that maybe some of the chromosomes are remain not right strand(chr01/7/8/9/15/18/19/20/24) according to the plot?
In addition, I found that the chromosomes in the drawing are not sorted in order. Do you know how to show the chromosomes from chr01 to chr24 in the plot?
Best,
Lily

I guess that this is happening because the two genomes have same chromosome IDs for non-homologous chromosomes. For example: Chr2 in reference is actually homologous to Chr24 in query, whereas the two Chr2-s are not homologs. Syri assumes that the chromosomes with the same ID are homologs but since that is not the case, it crashes. Please modify the IDs in qry.filtered.fasta to something like 'qry_Chr1', 'qry_Chr2' etc. before doing the alignment. I think that should solve this.
In case, there are more issues, could you please also share the dotplot generated with the ref.filtered.fa and the modified qry.filtered.fa.

Hi Manish,
Actually,two genomes are not  non-homologous chromosomes one-to-one at first, I get the plot after I ran nucmer,the result shows as follows:

I realized that the two genomes contain same chromosome IDs for non-homologous chromosomes,so I adjusted the chromosomes IDs for query genome(for example:oldC07-newC02,oldC23-newC03,oldC11-newC05 etc).
The plot seems better and have same chromosome IDs for homologous chromosomes(refchr01-qrychr01,refchr02-qrychr02 etc) after adjusted the chromosomes IDs :

Then I use the adjusted query genome as input to run nucmer,delta-filter,show-coords and fixchr.
As you can see, the collinearity of the chromosomes has changed again(refchr02-qrychr24,refchr03-qrychr14 etc) after fixchr. That's troubled me a lot.
I'm not clear what do you mean by 'modify the IDs in qry.filtered.fasta to something like 'qry_Chr1', 'qry_Chr2' etc. before doing the alignment',for the order of qry.filtered.fa is chr01,chr24,chr14,chr04,chr17...,do you mean I need to modify the chr24 to qry_Chr2 or modify chr02 to qry_Chr2?
As you said ,I try to plot by using  the ref.filtered.fa and the qry.filtered.fa(not the modified qry.filtered.fa as you mentioned above for I'm not sure how to modify), I delete the first row containing the header of homologous_strand_corrected_alignments.txt to plot,but it also showed'ValueError: Length mismatch: Expected axis has 11 elements, new values have 12 elements' .It's hard to explain.
I could send my genomes to you via email if it's convenient for you. Thanks!
Best,
Lily

Hi Lily,

'modify the IDs in qry.filtered.fasta to something like 'qry_Chr1', 'qry_Chr2' etc. before doing the alignment'

I meant to only append some string in the chromosome IDs.
You can do this using:
sed 's/>/>qry_/g' qry.filtered.fa > qry.filtered.new.fa

Then you can use the ref.filtered.fa and qry.filtered.new.fa with nucmer, delta-filter, show-coords and syri. I believe that this would work.

As you can see, the collinearity of the chromosomes has changed again(refchr02-qrychr24,refchr03-qrychr14 etc) after fixchr.

This new dotplot is same as the one you shared earlier, so I presume that your fixchr run used old files and not the new ones. Please re-check that, or run it in a new folder.
Best

Hi Manish,
I replace IDs in qry.filtered.fasta as you said.

I use the ref.filtered.fa and qry.filtered.new.fa with nucmer, delta-filter, show-coords and syri.

Then chr07 failed again

When I check mapids.txt for mapping used I found that it was mapped to qry_chr18,

Besides,many of the output files are empty

Looking forward to your reply
Best,
Lily

Hi Lily,
So there is some progress, that is great. Based on the dotplots, Chr7 is homologous to qry_Chr18, so the mapping is correct. These two chromosomes have large local inversions. In such scenarios, fixchr sometimes cannot determine which orientation is syntenic (in fact, even manually it is tricky to determine which strand is better match).
Please retry by reverse complementing (using other strand) of qry_Chr18. Hopefully, that would work.
NOTE: Similar problem could happen for Chr8, Chr9, Chr18, and Chr19. Unfortunately, this would need to be manually tested and fixed.
Best
Manish

Hi Manish,
Thanks for your patience and now l see that the cause is the presence of large local inversions.
You said 'retry by reverse complementing (using other strand) of qry_Chr18 ', do you mean that should I rerun fixchr and use the new qry.filtered.new_2.fa(for instance)  and ref.filtered.fa to rerun nucmer, delta-filter, show-coords and syri?
'retry by reverse complementing (using other strand) of qry_Chr18', can I rerun fixchr specify for  qry_Chr18 or when I retry fixchr it may automatic identification qry_Chr18 ? and how can I specify other strand ?
Looking forward to your reply.
Best,
Lily

Unfortunately, you will have to do this manually (fixchr cannot do that). I am not sure how experienced you are with scripting, but basically what you need is to create a new "qry.filtered.new_2.fa" where, compared to qry.filtered.new.fa, only the qry_Chr18 is reverse complemented. And then try rerun nucmer, delta-filter etc with it. You can probably find many solutions for doing this online. I have a small tool here which can do that, but it is not well documented or supported.


title screen

ubuntu 22.04 + Steam

ModLog.txt
Player.log.txt
ModLog 06 23 2023 (15 18 48).txt

This is a bug with Linux and our assets not being for Linux I will look into a fix for this soon

I too have this bug I am on arch


Update Elementary Statistics.ipynb

I added a comment

@SidKasi I’m out now but can review and merge by 2pm eastern

@SidKasi Have you installed the GitHub app on your phone? Would recommend it


mmex: 1.6.1 -> 1.6.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/moneymanagerex/moneymanagerex/releases.
meta.description for mmex is: "Easy-to-use personal finance software"
meta.homepage for mmex is: "https://www.moneymanagerex.org/"
meta.changelog for mmex is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.2 with grep in /nix/store/7r3d95w5dvn19ap0h6i197pv6wkkgqi6-money-manager-ex-1.6.2
found 1.6.2 in filename of file in /nix/store/7r3d95w5dvn19ap0h6i197pv6wkkgqi6-money-manager-ex-1.6.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
mmex

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7r3d95w5dvn19ap0h6i197pv6wkkgqi6-money-manager-ex-1.6.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mmex https://github.com/r-ryantm/nixpkgs/archive/630528beece8f2245a1321d6d3aa85dac1a5bb41.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7r3d95w5dvn19ap0h6i197pv6wkkgqi6-money-manager-ex-1.6.2
ls -la /nix/store/7r3d95w5dvn19ap0h6i197pv6wkkgqi6-money-manager-ex-1.6.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

mmex

Maintainer pings
cc @viric for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/moneymanagerex/moneymanagerex/releases.
meta.description for mmex is: Easy-to-use personal finance software
meta.homepage for mmex is: https://www.moneymanagerex.org/
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.3 with grep in /nix/store/1lnx9biragf7c0j5jxhgvsrpyry1czii-money-manager-ex-1.6.3
found 1.6.3 in filename of file in /nix/store/1lnx9biragf7c0j5jxhgvsrpyry1czii-money-manager-ex-1.6.3

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
mmex

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1lnx9biragf7c0j5jxhgvsrpyry1czii-money-manager-ex-1.6.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mmex https://github.com/r-ryantm/nixpkgs/archive/525dbb13f52285356a9589692413d4391ce90962.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1lnx9biragf7c0j5jxhgvsrpyry1czii-money-manager-ex-1.6.3
ls -la /nix/store/1lnx9biragf7c0j5jxhgvsrpyry1czii-money-manager-ex-1.6.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

mmex

Maintainer pings
cc @viric for testing.


Release new harvester (Publinova)

Steps to take by DET before switching to new harvester
Things to test on Publinova side once all sources are connected:

[ ] Webhooks (Sharekit and Publinova)
[ ] Search
[ ] Filters (do all filters continue to exist with the new search index?)
[ ] Importer

Things to test on Harvester side:

[x] Metadata output (the metadata tree as used by Edusources filters, can be tested with command)
[ ] Product endpoints (new!)
[ ] to_search comparison with legacy documents per source (tested automatically, but doesn't hurt to check a few times)

Steps to take for deploy:

[x] APPLICATION_MODE=production invoke db.load-fixture production sources/fixtures/initial-publinova.json
[x] Harvest files and products where products will create indices without promotion and files do nothing with search
[x] Configure publisher_year_normalized

To switch to new harvester completely:

[x] Run "promote dataset version index" from the admin
[x] Switch webhook links in Sharekit to new webhook endpoints
[x] Disable "is_latest" for core datasets
[ ] Remove the run_legacy_harvest from AWS scheduled tasks
[x] Make a release where document endpoints point to products
[x] Remove redundant indices
[ ] Delete S3 data
[ ] Add publisher_year_normalized to fixtures
[ ] Revisit CPU and memory definitions for command and celery Fargate tasks
[ ] Make a list of 404 files

Some highly recommended updates for Publinova
A list of updates to discuss with Zooma. We may choose not to do some of these updates and accept the consequences, but these are recommended for good reasons.

[ ] "harvest_source" and "feed" should be replaced with "set" which is a concatenation of source and set like: "sharekit:nppo". This allows channel switching and improves identification of products/sources.
[ ] (required) New harvest endpoint for Publinova is at /api/v1/product/ instead of /api/v1/document/. Any detail lookups will go through SRN instead of external_id.
[x] Youtube thumbnails could now come from Youtube instead of Harvester S3 bucket (how to provide this?)
[x] Similarity API call should specify the SRN and not the external_id

HKU
Is this institute still on its way to sign a contract? Can we abandon this connection? If not we'll need to migrate the connection to the new Harvester. This is relatively simple.

BUAS / HANZE
What are the requirements that we still need to fill so that BUAS and Hanze can sign the contracts and move to production? Would it be ok to remove them from acceptance promising that we'll re-add them with the requirements at a later date?
Can we stimulate BUAS to move to Pure API v2. That way we could refactor HvA, BUAS and Hanze to an abstract "PureV2" class and logic will be mostly share between the three sources.

Saxion
Check url task is not working as expected. Can Saxion support HEAD requests with Location headers?

HBO Kennisbank
Making ClosedAccess the default for files without an access policy

Documentation
The how-to-harvest in the README is outdated. I could update it for developers. Is there another way we want to document this? Are we going to enable TPO's to start harvests?

MetadataValue comparison
I ran the compare_metadata_values command and it looks very good. The publisher_year_normalized occurs much more often in the new harvester, which was to be expected (because old harvester doesn't support that). For the rest MetadataValues are very similar. See file
metadata-value-comparison.json

VHL is returning empty documents. There are 5 of these as far as I can tell:

oai:www.greeni.nl:VBS:2:150433
2022-12-19
ALLRECORDS
PUBVHL
VHL

Saxion should be supporting "from" parameter as well as deletes.

Unfortunately the list of products without files coming from HvA is quite large
hva-missing-files.csv

Example of a file that should be marked 404, but isn't: hanze:hanze:c4a62181-503a-401c-9e85-31e1e5001d89:0f8e26176a23faa76e0a43adffc1badee48e98e5

Deletes of indides from production:
DELETE document-logs-20*
DELETE harvest-logs-20*
DELETE document-logs-*-2023
DELETE harvest-logs--2023
DELETE beta*
DELETE delta-1401*
DELETE delta-1402*
DELETE delta-1404*
DELETE delta-14050*
DELETE service-logs-2022*
DELETE service-logs-2023*


Update subscription client with new api version

LGTM.

No modification for Ruby

No modification for Python

No modification for NodeJS


Permissionless TokenDistributor

Upgrade openzeppelin contracts to v4
Implement safeERC20 for token transfers
Use call for ETH transfer instead of transfer. See https://solidity-by-example.org/sending-ether/

Is it necessary to have a "room" variable? Does this solve any pain points since we are already able to gather transaction data for a room.
Just wanted to know, it seems like it may help us retrieve room info directly from the blockchain, so seems like a good idea.

Is it necessary to have a "room" variable? Does this solve any pain points since we are already able to gather transaction data for a room.
Just wanted to know, it seems like it may help us retrieve room info directly from the blockchain, so seems like a good idea.

Yup, pretty much the reason behind it. Also indexing it makes for better record keeping

Tested the contract, seems everything is working fine, also, do we need to make the contract Ownable? Making it ownable seems to add extra functions that the contract doesn't seem to need.


BREAKING CHANGE: Changes to xSQLServerDatabaseOwner

Added tests for resources

xSQLServerDatabaseOwner

Fixes and enhancements in xSQLServerDatabaseOwner

BREAKING CHANGE: Fixed so the same owner can now be added in one or more databases, and/or one or more instances. Now the parameters SQLServer and SQLInstanceName are mandatory.

This change is

Hi @luigilink, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Jean-Cyril Drouhin). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

I need some help on pester tests, it works perfectly on PowerShell ISE bu not in PowerShell Prompt.
What did I miss ?
Thanks in advance.

What's happening when you try running it in the command line? Are you just calling Invoke-Pester?

Tag "Help wanted" can't be removed, I find my mistake. Pester Test works perfectly in PowerShell and PowerShell ISE.

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.

xSQLServerHelper.psm1, line 175 at r3 (raw file):

if (($DesiredValues.GetType().Name -eq "CimInstance") -and ($null -eq $ValuesToCheck))

Quoted 4 lines of code…
>     {
>         throw ("If 'DesiredValues' is a Hashtable then property 'ValuesToCheck' must contain " + `
>                "a value")
>     }

>
The check is against CimInstance, but the error message is about Hashtable

xSQLServerHelper.psm1, line 804 at r3 (raw file):

Write-Verbose "SQL Database name $Database does not exist"

this should be an error

xSQLServerHelper.psm1, line 811 at r3 (raw file):

$null = $Name

what is the purpose of those assignments to null? they don't have any effect

xSQLServerHelper.psm1, line 852 at r3 (raw file):

throw [Exception] ("Failed setting owner $Name for SQL Database $Database")

The new exception should include the original exception, or the latter should be logged

Comments from Reviewable

@luigilink Could you please remove 'fixes #92' from the PR title? Otherwise it will auto-close that issue, and since the issue is to add test for all existing resources that wouldn't be good at this time (we have a few more to fix 😄 )

Review status: 0 of 5 files reviewed at latest revision, 4 unresolved discussions.

xSQLServerHelper.psm1, line 175 at r3 (raw file):
Previously, narrieta (Norberto Arrieta) wrote…
> >  if (($DesiredValues.GetType().Name -eq "CimInstance") -and ($null -eq $ValuesToCheck))
> >     {
> >         throw ("If 'DesiredValues' is a Hashtable then property 'ValuesToCheck' must contain " + `
> >                "a value")
> >     }
> >
>
> The check is against CimInstance, but the error message is about Hashtable

Done.

xSQLServerHelper.psm1, line 804 at r3 (raw file):
Previously, narrieta (Norberto Arrieta) wrote…
> > Write-Verbose "SQL Database name $Database does not exist"
>
> this should be an error

Done.

xSQLServerHelper.psm1, line 811 at r3 (raw file):
Previously, narrieta (Norberto Arrieta) wrote…
> >  $null = $Name
>
> what is the purpose of those assignments to null? they don't have any effect

Done. $null Deleted

xSQLServerHelper.psm1, line 852 at r3 (raw file):
Previously, narrieta (Norberto Arrieta) wrote…
> > throw [Exception] ("Failed setting owner $Name for SQL Database $Database")
>
> The new exception should include the original exception, or the latter should be logged

Done.

Comments from Reviewable

Reviewed 1 of 3 files at r3, 2 of 2 files at r4.
Review status: 3 of 5 files reviewed at latest revision, 4 unresolved discussions.

Comments from Reviewable

I made all changes as requested

Reviewed 1 of 4 files at r2, 2 of 3 files at r3, 2 of 2 files at r4.
Review status: all files reviewed at latest revision, 14 unresolved discussions.

xSQLServerHelper.psm1, line 150 at r4 (raw file):

    param
    (
        [parameter(Mandatory = $true, Position=1)]

No need to have the 'Position' in the params.

xSQLServerHelper.psm1, line 154 at r4 (raw file):

        $CurrentValues,

        [parameter(Mandatory = $true, Position=2)]

Can you capitalize 'Parameter' in all of these cases

xSQLServerHelper.psm1, line 235 at r4 (raw file):

                                    Write-Verbose -Message "$($_.InputObject) - $($_.SideIndicator)"
                                }
                                $returnValue = $false

Instead of making a variable '$returnValue' you can just return $false.

xSQLServerHelper.psm1, line 244 at r4 (raw file):

                        {
                            "String" {
                                if ([string]::IsNullOrEmpty($CurrentValues.$fieldName) `

Instead of having an empty if block, just negate the if statement and put the else logic there and then get rid of the else:
if (-not [String]::IsNullOrEmpty($CurrentValues.$fieldName) -or `
    -not [String]::IsNullOrEmpty($DesiredValues.$fieldName))
{
    Write-Verbose -Message ("String value for property " + "$fieldName does not match. " + `
                            "Current state is " + "'$($CurrentValues.$fieldName)' " + `
                            "and Desired state is " +  "'$($DesiredValues.$fieldName)'")
    return $false
}

Same with below instances

Examples/Resources/xSQLServerDatabaseOwner/1-SetDatabaseOwner.ps1, line 11 at r4 (raw file):

        param(
            [Parameter(Mandatory = $true)]
            [PSCredential]

This should be:
[Parameter(Mandatory = $true)]
[System.Management.Automation.PSCredential]
[System.Management.Automation.Credential()]
$SysAdminAccount

Tests/Unit/MSFT_xSQLServerDatabaseOwner.Tests.ps1, line 147 at r4 (raw file):

            It 'Should return the state as false when desired login is not the database owner' {
            $testParameters = $defaultParameters

this  line and the 3 below should be tabbed in

Tests/Unit/MSFT_xSQLServerDatabaseOwner.Tests.ps1, line 160 at r4 (raw file):

                $result | Should Be $false

                Assert-MockCalled Connect-SQL -Exactly -Times 1 -ModuleName $script:DSCResourceName -Scope It

Why is this set to check only within the 'It' scope and the one below is set to check withing the 'Context' scope?

Tests/Unit/MSFT_xSQLServerDatabaseOwner.Tests.ps1, line 180 at r4 (raw file):

                $result | Should Be $true

                Assert-MockCalled Connect-SQL -Exactly -Times 1 -ModuleName $script:DSCResourceName -Scope It

Same question as above about different scope checks

Tests/Unit/MSFT_xSQLServerDatabaseOwner.Tests.ps1, line 210 at r4 (raw file):

                } -ModuleName $script:DSCResourceName -Verifiable

                { Set-TargetResource @testParameters } | Should Throw

Whenever you check that a function Should Throw, you should check that it throws the actual error object expected. Otherwise it could be throwing any error.
So you'll need to create a 'fake' error record of the type thrown in the mocked function and then check that that object is thrown here.

Tests/Unit/MSFT_xSQLServerDatabaseOwner.Tests.ps1, line 244 at r4 (raw file):

            }

            It 'Should throw an error when desired database does not exist' {

This 'It' test and the one below it seem to be the same as the ones in the above context block. Could you replace them with tests that check that the correct mocks are called when the system is in the desired state?

Comments from Reviewable

Review status: all files reviewed at latest revision, 14 unresolved discussions.

xSQLServerHelper.psm1, line 235 at r4 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> Instead of making a variable '$returnValue' you can just return $false.

If I don't use the variable $returnValue, how can I return $true.
Can I put a return $true on the script beginning ?

Comments from Reviewable

Reviewed 3 of 3 files at r5.
Review status: all files reviewed at latest revision, 14 unresolved discussions.

xSQLServerHelper.psm1, line 150 at r4 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> No need to have the 'Position' in the params.

Done.

xSQLServerHelper.psm1, line 154 at r4 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> Can you capitalize 'Parameter' in all of these cases

Done.

xSQLServerHelper.psm1, line 244 at r4 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> Instead of having an empty if block, just negate the if statement and put the else logic there and then get rid of the else:
>
> ```powershell
> if (-not [String]::IsNullOrEmpty($CurrentValues.$fieldName) -or `
>     -not [String]::IsNullOrEmpty($DesiredValues.$fieldName))
> {
>     Write-Verbose -Message ("String value for property " + "$fieldName does not match. " + `
>                             "Current state is " + "'$($CurrentValues.$fieldName)' " + `
>                             "and Desired state is " +  "'$($DesiredValues.$fieldName)'")
>     return $false
> }
> ```
>
> Same with below instances
>

Done.

Examples/Resources/xSQLServerDatabaseOwner/1-SetDatabaseOwner.ps1, line 11 at r4 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> This should be:
> ```powershell
> [Parameter(Mandatory = $true)]
> [System.Management.Automation.PSCredential]
> [System.Management.Automation.Credential()]
> $SysAdminAccount
> ```

Done.

Tests/Unit/MSFT_xSQLServerDatabaseOwner.Tests.ps1, line 147 at r4 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> this  line and the 3 below should be tabbed in

Done.

Tests/Unit/MSFT_xSQLServerDatabaseOwner.Tests.ps1, line 160 at r4 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> Why is this set to check only within the 'It' scope and the one below is set to check withing the 'Context' scope?

Done.

Tests/Unit/MSFT_xSQLServerDatabaseOwner.Tests.ps1, line 180 at r4 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> Same question as above about different scope checks

Done.

Tests/Unit/MSFT_xSQLServerDatabaseOwner.Tests.ps1, line 210 at r4 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> Whenever you check that a function Should Throw, you should check that it throws the actual error object expected. Otherwise it could be throwing any error.
> So you'll need to create a 'fake' error record of the type thrown in the mocked function and then check that that object is thrown here.

Done. Is it better like this ?

Tests/Unit/MSFT_xSQLServerDatabaseOwner.Tests.ps1, line 244 at r4 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> This 'It' test and the one below it seem to be the same as the ones in the above context block. Could you replace them with tests that check that the correct mocks are called when the system is in the desired state?

Done.

Comments from Reviewable

Review status: all files reviewed at latest revision, 14 unresolved discussions.

Tests/Unit/MSFT_xSQLServerDatabaseOwner.Tests.ps1, line 248 at r5 (raw file):

            $testParameters.Database = 'UnknownDatabase'

            It 'Should throw an error when desired database does not exist' {

This last 'It' test still seems to be testing the same thing as the one in the Context block above.

Comments from Reviewable

Reviewed 1 of 1 files at r6.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

Tests/Unit/MSFT_xSQLServerDatabaseOwner.Tests.ps1, line 248 at r5 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> This last 'It' test still seems to be testing the same thing as the one in the Context block above.

Done. It was a copy/paste of too

Comments from Reviewable

Hope it's good for merging :)

Review status: all files reviewed at latest revision, 9 unresolved discussions.

xSQLServerHelper.psm1, line 145 at r6 (raw file):

}

function Test-SQLDscParameterState

Could you please add comment based help to this function.
See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#functions-have-comment-based-help
I know no other function has that yet, but let start somewhere, like now. 😄

xSQLServerHelper.psm1, line 765 at r6 (raw file):

}

function Get-SqlDatabaseOwner

Could you please add comment based help to this function.

xSQLServerHelper.psm1, line 800 at r6 (raw file):

}

function Set-SqlDatabaseOwner

Could you please add comment based help to this function.

Comments from Reviewable

Reviewed 1 of 3 files at r5, 1 of 1 files at r6, 1 of 1 files at r7.
Review status: all files reviewed at latest revision, 9 unresolved discussions.

xSQLServerHelper.psm1, line 804 at r3 (raw file):
Previously, luigilink (Jean-Cyril Drouhin) wrote…
> Done.

I think you should probably throw an error here rather than just writing an error

xSQLServerHelper.psm1, line 235 at r4 (raw file):
Previously, luigilink (Jean-Cyril Drouhin) wrote…
> If I don't use the variable $returnValue, how can I return $true.
> Can I put a return $true on the script beginning ?

Can't you just return $false immediately after finding that it's not in the desired state, and then at the very end, instead of returning $returnValue, just returning $true?

xSQLServerHelper.psm1, line 160 at r7 (raw file):

.PARAMETER ValuesToCheck

This is a list of which properties in the desired values list should be checkked.

'checked' - typo

Comments from Reviewable

Reviewed 1 of 1 files at r8.
Review status: all files reviewed at latest revision, 9 unresolved discussions.

xSQLServerHelper.psm1, line 804 at r3 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> I think you should probably throw an error here rather than just writing an error

Done.

xSQLServerHelper.psm1, line 235 at r4 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> Can't you just return $false immediately after finding that it's not in the desired state, and then at the very end, instead of returning $returnValue, just returning $true?

If I do this, the function always returns $true :(

xSQLServerHelper.psm1, line 160 at r7 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> 'checked' - typo

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r8.
Review status: all files reviewed at latest revision, 10 unresolved discussions.

xSQLServerHelper.psm1, line 811 at r3 (raw file):
Previously, luigilink (Jean-Cyril Drouhin) wrote…
> Done. $null Deleted

It looks like you added the $null = $Name back in

xSQLServerHelper.psm1, line 235 at r4 (raw file):
Previously, luigilink (Jean-Cyril Drouhin) wrote…
> If I do this, the function always returns $true :(

Okay, this is fine as is.

xSQLServerHelper.psm1, line 823 at r8 (raw file):

        {
            $null = $Name
            Throw "SQL Database name $Database does not exist"

You should use the New-TerminatingError function in the helper file

Comments from Reviewable

Reviewed 1 of 1 files at r9.
Review status: all files reviewed at latest revision, 8 unresolved discussions.

xSQLServerHelper.psm1, line 811 at r3 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> It looks like you added the $null = $Name back in

Done.

xSQLServerHelper.psm1, line 823 at r8 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> You should use the New-TerminatingError function in the helper file

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r9.
Review status: all files reviewed at latest revision, 8 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, 8 unresolved discussions.

Comments from Reviewable


Centralize NLP tokenizers (and potentially model configs)

Problem
Two parts of the NLP stack need access to the tokenizer and model configuration. More specifically, the models (in order to know which inputs are required for the forward pass) and Datasets (in order to tokenize the dataset input)
https://github.com/mosaicml/composer/blob/ab0da9ee5a4fcb72ad9461581cac99c8410dac3b/composer/models/transformer_shared.py#L43
https://github.com/mosaicml/composer/blob/ab0da9ee5a4fcb72ad9461581cac99c8410dac3b/composer/models/transformer_shared.py#L42
https://github.com/mosaicml/composer/blob/ab0da9ee5a4fcb72ad9461581cac99c8410dac3b/composer/datasets/lm_datasets.py#L85
https://github.com/mosaicml/composer/blob/ab0da9ee5a4fcb72ad9461581cac99c8410dac3b/composer/datasets/lm_datasets.py#L86
This leads to some messy user experiences, such as specifying the tokenizer three times in the YAML:
https://github.com/mosaicml/composer/blob/cf33785f95407dc19eafd118c9cd14d7a2b47295/composer/yamls/models/glue/qnli.yaml#L4
https://github.com/mosaicml/composer/blob/cf33785f95407dc19eafd118c9cd14d7a2b47295/composer/yamls/models/glue/qnli.yaml#L12
https://github.com/mosaicml/composer/blob/cf33785f95407dc19eafd118c9cd14d7a2b47295/composer/yamls/models/glue/qnli.yaml#L21
I think it might be better design if we can centralize the storage of these in a single place, which would be cleaner design and lead to less room for error. However, there is the question of "where would we store it?"
Open to opinions!

I believe this problem is limited to the YAHP route, as the user would pass an already-constructed model and dataloader into Composer. We ran into a similar issue in image classification, where the model (and sometime algorithms) needed to know the number of classes from the dataset.
One idea is to pass the initialized model when constructing the datasets (e.g. train_dataset = train_dataset_hparams.initailize_object(batch_size, dataloader_hparams, model)). The tokenizer could be a model attribute, and the DatasetHparams would know to read that attribute. We already do something similar for image classification, where num_classes is an attribute of ComposerClassifier. We would just need to update the YAHP code-path to pass the already-constructed model when initializing the dataloaders.
Thoughts?
@moinnadeem going to assign to you to design and implement. The above proposal, if it would solve this problem, should be fairly straightforward to do in trainer_hparams.py.


Suggestion #1: Image sliders

ModestaCSS could have image sliders for portfolios etc.

Will look into it.

I see.

I won't cover too much JS in this framework as it's called ModestaCSS
Yes I do have JS for some stuff but that's just needed for few things.


Fix Column Sort Resize Issue

loadItems is now only called when the items in fields and directions are different.

I've only seen usages that allow sorting by one column, but I think it would be small change to this pull request to support the possibility of sorting by multiple columns (so instead of just checking fields[0] and direction[0]).

Since, the project already uses/depends on lodash, I think it would be more concise to use _.isEqual().
https://lodash.com/docs/4.17.2#isEqual


Add support for "Best" brand model "BSTS18CNE2"

i have gathered codes of AC "Best" brand model "BSTS18CNE2" the file uploaded in the below link.
note:

Fan: has only low, mid, and high. without temperature adjustment. also copied high in auto.
Dry: has only one code, copied across all low, mid, high & auto.
Auto mode: not added yet.

1000.zip

Thanks!


[SPARK-39677][SQL][DOCS] Fix args formatting of the regexp and like functions

What changes were proposed in this pull request?
In the PR, I propose to fix args formatting of some regexp functions by adding explicit new lines. That fixes the following items in arg lists.
Before:

After:

Why are the changes needed?
To improve readability of Spark SQL docs.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By building docs and checking manually:
$ SKIP_SCALADOC=1 SKIP_PYTHONDOC=1 SKIP_RDOC=1 bundle exec jekyll build

Merging to master/3.3/3.2/3.1. Thank you, @HyukjinKwon for review.

The changes cause conflicts in 3.2 and 3.1 (probably). I will backport this PR separately.

late LGTM


How to use customControls options

How to use customControls options, can support a demo

Please see the new version docs:  http://jossmac.github.io/react-images/#/components


[BUG] the undo history don't get cleared after user switch apps

i didn't confirm my theory but i think this will cause errors

even across pages it could cause problems


test: add test case for json tag in line protocol

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add --dry-run completion to nix-build and nix-shell

nix-build explicitly documents --dry-run in its --help, while nix-shell
passes it onto nix-store --realise.

Cheers :)

Thanks! :tada:


Vision Statement in README

Have linkable from game page (maybe title page).

Serve from github pages via link

Button itself works, the link connected to it needs changed as soon as permissions updated.


monaco-graphql: Unexpected EOF with comments-only content

A user reported a UI bug in the GraphiQL design prototype I've been working on that's related to monaco-graphql.
When the model value consists only of comment lines, we get a syntax error:

This is reproducible in the monaco-graphql-react-vite example.
While it's simply a little annoying to see the error in the editor, the impact is heavy when attempting to parse the comments-only value because it errors out.
Ideally, a comments-only value wouldn't produce an error during parsing.
I can work around this in the prototype, so this is low priority.

we get something similar with codemirror-graphql as well it seems. when graphql-js tries to parse an empty file with only comments, it doesn't like this! it used to just skip it, which is why this worked better in earlier versions of graphiql/playground/etc
the simple answer to this without comments (aka empty file) in monaco-graphql at least, was to make sure we only call validation in cases where the query is a string of more than a minimum length of say, two or three characters, which is what we do now.
however, this doesn't work when there is only empty whitespace lines or comments. so when graphql-js tries to parse this, it sees only whitespace. we can use a regex perhaps to see if any lines don't start with comment blocks, but what if the comment blocks are indented? there is a lot of complexity to his.


ACS Commons - Parameterized Granite Include - "Server Error" occurred, after use search in inbox.

Required Information

[ ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: AEM <IP_ADDRESS>
[ ] ACS AEM Commons Version: 4.8.0

Expected Behavior
When i open inbox select search and type title of existing inbox item

search it, should find these items
.
Actual Behavior
When i open inbox select search and type title of existing inbox item

search it, error popup is shown
.
Steps to Reproduce
Starting from a vanilla instance of AEM 6.5 install 6.5.5 Service Pack, install ACS AEM Commons Version: 4.8.0. Go to /aem/inbox, select search, try to find "Configure".
Additional info
It broken due to use IncludeDecoratorFilterImpl filtering by resourceType. Sling https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceTypeUtil.java relativizeResourceType(...) method throw java.lang.NullPointerException: null for "/aem/inbox" search

The screenshot points to a resource w/ this type:
https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/ui.apps/src/main/content/jcr_root/apps/acs-commons/granite/ui/components/include/include.jsp
... I'm not sure why this is a problem or how its being called looking at the screenshot stack

Ok, nice find, this is really weird.
Clear steps to reproduce. Il take a look on this bad boy.


allow to reorder products in catalog

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
Enter Issue number here
✅ Checklist

[ ] Github issue details are up to date for people to QA.
[ ] I have tested all my changes.

🕵♂ Notes for Code Reviewer
Technical explanations to help your peers review your work - including environments, credentials, etc.
🙈 Screenshots
For all UI changes

description 1
description 2

img1
img2

👯♀ Paired with
@github-handle or "nobody" if you did not pair.

#427

#427

Not working - in this branch I see only 2 products

In the 426 branch...

Not working - in this branch I see only 2 products

In the 426 branch...

Also you need to merge 426 into this, and make the other list an ordered list too
Main problem is I can't really tell whether or not it's going to show the list correctly ....

Also you need to merge 426 into this, and make the other list an ordered list too
Main problem is I can't really tell whether or not it's going to show the list correctly ....

Not same sort order

Not same sort order

Some weird data duplication going on here

Some weird data duplication going on here

conflicts

conflicts

I merged this into my PR and fixed the bugs

I merged this into my PR and fixed the bugs


installation: codsign delve under macOS

Please answer the following before submitting your issue:
Note: Please include any substantial examples (debug session output,
stacktraces, etc) as linked gists.

What version of Delve are you using (dlv version)?
current master: Version: 1.0.0-rc.2
Build: $Id: 5c7676404d10d52e16be57fea744a7312b831f0c $
What version of Go are you using? (go version)?
go version go1.9.2 darwin/amd64
What operating system and processor architecture are you using?
macOS 10.13.2 (17C88)
What did you do?
tried to use delve with VS Code
What did you expect to see?
Debugger
What did you see instead?
exceptions about fork/foo

...until I found out, that I need to codesign delve with:
codesign -s dlv-cert $(which dlv)

Closing, no feedback


Create an Aurelia-CLI config reference library (cookbook)

Intention

I'm submitting a feature request
Environment

Operating System:
Windows 10

Node Version:
v6.2.2

NPM Version:
3.10.5

Description
Current situation:
I'm seeing a lot of questions in Aurelia-CLI issue tracker on how to change the build scripts or any other kind of configuration. For example "how to let BrowserSync proxy requests" or "how to enable push-state debugging with BrowserSync".
Most of the time, the answer seems to be "what's stopping you from changing the build tasks?".
Frankly, this is not an answer at all.
Expected/desired behavior:
Monterey should have a cookbook repository as a companion site (because you can't link from GitHub issues to a desktop app).
Monterey itself should support this repository by providing a means to easily share a recipe like f.i. a BrowserSync proxy configuration.
What is the motivation / use case for changing the behavior?
To be able to answer questions like this with:
"This feature request is covered by changing the build tasks. Have a look at our cookbook (link to Monterey cookbook repository site). There are a few recipes that may help you."

A few first recipes:
Enable BrowserSync to proxy a backend server
In aurelia_project/tasks/run.js change the server task to:
let serve = gulp.series(
  build,
  done => {
    browserSync({
      // online: false,
      // notify: true,
      open: false,
      port: 9000,
      logLevel: 'silent',
      proxy: {
        target: 'localhost:24562'
      }
    }, function(err, bs) {
      let urls = bs.options.get('urls').toJS();
      console.log(`Application Available At: ${urls.local}`);
      console.log(`BrowserSync Available At: ${urls.ui}`);
      done();
    });
  }
);

Replace localhost:24562 to the url you'd like to proxy.
(should work but doesn't) Enable requirejs loading from 'scripts' directory
Add this to build.loader in aurelia.json:
"config": {
  "baseUrl": "scripts/"
},
``´

I like this idea, but perhaps it's better to keep this in the original aurelia-cli repository as documentation, assuming that the aurelia-cli folks like this idea 😄 Maybe it would even be visible on the aurelia hub

Yes, I think you're right.. I could issue a PR when I understand their doc structure.. :smiley:


ME Dense Cable Conduit Texture

Hi, dont know if it is only me or others as well. But for some reason , texture for ME Dense Cable conduit is showing me only the pink, black block, when they are missing textures. I even tryied to just get vanila setup for MC and still got missing texture sign.
Thx.
Maybe i am just missing something obvious.

Close?


Optimize ParallelChannel AddChannel Interface

What problem does this PR solve?
Issue Number:Closes-https://github.com/apache/brpc/issues/2466
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:

Performance effects(性能影响):

Breaking backward compatibility(向后兼容性):

Check List:

Please make sure your changes are compilable(请确保你的更改可以通过编译).
When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

LGTM

LGTM


Return the same connection to the SQL Pool layer

Is there any good reason why the driver doesn't return, or have an option to return, the same connection to the sql pool layer?
I.e. in: func (d *SQLiteDriver) Open(dsn string) (driver.Conn, error), can we just reuse the previously opened connection?
Doesn't sqlite handle better multiple requests to the same handle vs opening multiple connections?

To my knowledge because SQLite is file-based for writing is takes an exclusive file-lock. And everybody has to wait.


Retrieve bean validation parameter names from Spring MVC / JAX-RS annotations

Fixes #96

Additional question: do we keep using <maven.compiler.parameters>true</maven.compiler.parameters>?

I prefer to keep it, yes. I think it's a good practice. I wonder why it's not enabled by default actually.
When there is no annotation, the ParameterNameProvider/Discoverer falls back to the parameter name.
Also: for the Spring MVC annotations, the name in the annotation is actually optional. So there, we should also fall back to the parameter name, which I overlooked in the current implementation.

Additional question: do we keep using <maven.compiler.parameters>true</maven.compiler.parameters>?

I prefer to keep it, yes. I think it's a good practice. I wonder why it's not enabled by default actually.
When there is no annotation, the ParameterNameProvider/Discoverer falls back to the parameter name.

Ok, but wouldn't it be better to then document that best practice in the documentation?

wrong button


Storybook: TypeError: module.ReactComponent is not a function

The issue
Hi, we're trying to move vite-plugin-svgr to latest version but we're getting this error.

We load our SVGs components in async mode with a code like this:
  const [Svg, setSvg] = useState<JSX.Element>(null)
  const file = iconNames[name]
  const iconColor = colors.textColors[color]

  useEffect(() => {
    let unmounted = false

    const fetchIcon = async () => {
      const module = await import(`../../assets/icons/${file}.svg`)

      if (unmounted) return

      setSvg(
        module.ReactComponent({
          ref,
          className: cn('fill-current', className, iconColor, {
            'w-4 h-4': small,
          }),
        })
      )
    }

    fetchIcon()

    return () => {
      unmounted = true
    }
  }, [name, iconColor, className])

  if (!Svg) return <div className='w-4 h4' />

  return Svg
})

Versions
Storybook: 6.5.10
Vite 2.9.13
vite-plugin-svgr: 2.2.1
Any idea of what could be the issue. I see that you did a big change in the way the React component is created but I don't know how to relate to Vite version.
The latest version that is working for us is Vite 1.1.0

Any progress on this? My versions are a little bit newer, but the issue remains

Storybook: 6.5.13
Vite: 3.2.3
vite-plugin-svgr: 2.2.2

Sorry I didn't remember this was open.
It fixed magically for me after moving to new versions 🎉

Storybook ^7.0.0-alpha.47
Vite ^3.1.4
vite-plugin-svgr ^2.2.1

@andresgutgon could we keep it open? I'm not sure that integrating alpha version of Storybook into a project is the best idea (not a pet project I mean). And who knows when 7.0.0 will be out
Or what is the common approach for such issues?

It was not an issue at all in our case. And we have quite some amount of code already. I would try to update and see if you find some issues

Oh, actually, I may've found the issue.
| The builder will not read your vite.config.js file by default.
So one should add the plugin into both vite.config.js and into .storybook/main.js. Here's my current config, the bug went away. Can we treat it as a solution and close the issue finally? Maybe, add some know-how line into the docs?
const { mergeConfig } = require('vite');
const svgr = require("vite-plugin-svgr");

module.exports = {
  async viteFinal(config) {
    return mergeConfig(config, {
      plugins: [svgr()]
    });
  },
  "stories": [
    "../src/**/*.stories.mdx",
    "../src/**/*.stories.@(js|jsx|ts|tsx)"
  ],
  "addons": [
    "@storybook/addon-links",
    "@storybook/addon-essentials",
    "@storybook/addon-interactions"
  ],
  "framework": "@storybook/react",
  "core": {
    "builder": "@storybook/builder-vite"
  },
  "features": {
    "storyStoreV7": true
  }
}


Focus Continuous don't work after first picture taken

The autofocus work perfectly when take the first picture. But, after that, the autofocus don't work anymore.

Might be related to #41


switch temperature to comfort/normal temperature

Hi, thanks for your efforts so far, fritzctl is great :-)
i would like to request a new feature:

switch to the predefined comfort temperature
switch to predefined economy temperature
(i dont know if its called like this in the english translation of the fritzbox. in german its Komforttemperatur / Spartemperatur)

So you can use the predefined setting in the fritzbox.
Edit: Its "saving temperature"?

Hi @seppeel.
Thanks for rising this issue. It sounds like a reasonable proposal. I will look into it soon™ (have very limited time on my hands rn).
Btw. yes it's "saving".

Feature will be included in the next release. Thx again for reporting.


Context menu for adding waypoint type at mouse point

Im thinking of a context menu (mui). It should not replace the current waypoint type, rather just place a waypoint at the cursor. From MUI docs, it should mirror IconMenu with the icons and colors matching with the waypoint type.
I can experiment with other information on the menu, like obstacles (since constraints/scopes don't make much sense). If groups are implemented, will look like:

Source

Determined that I want to use Popovers, since they can specify an x and y position, which is my pointer.

Now, the context menu is aware of waypoints they are over. For example, if you right click a translation waypoint, it will show translation waypoint and you can change it to a pose waypoint, for example.


Modify upstream downstream relationships api to use new lineage model

Creates a new response type for relationships tab for lineage to be able to fill out all our necessary lineage information (actor, modified, type, etc). dataset/<urn>/upstream and dataset/<urn>/downstream will use this new response format instead.
../gradlew build results:
BUILD SUCCESSFUL in 1m 7s
21 actionable tasks: 6 executed, 15 up-to-date

Coverage decreased (-0.1%) to 22.766% when pulling c94234a548ff93b0ea897ea765ef6097523d2b5e on cptran777:new-relationships-api into 97f08e0b81ec677c65bbb399e5197c4c2dc176e3 on linkedin:master.

Since another PR and internal push depends on this, will merge for now since build is successful and address issues retroactively.

ps remove the modified attribute, it does not seem to exist on the expected response