smartlog: Some commits may throw error on mergebase path calculation

Sidenote: my git undo crashed when I tried to go back that far in history. I was in the 560's and pressing p got this:
The application panicked (crashed).
Message:  A fatal error occurred:
   0: 79708aa2ba5b7a6b2f60685c959715b2268062e4 cannot be found

Location:
   /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/core/src/result.rs:1915

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ SPANTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

   0: branchless::git::dag::find_path_to_main_branch with self=<Dag> effects=<Output fancy=true> head=<static [79708aa2ba5b7a6b2f60685c959715b2268062e4]>
      at src/git/dag.rs:422
   1: branchless::commands::smartlog::graph::walk_from_active_heads with effects=<Output fancy=true> dag=<Dag> event_replayer=<EventReplayer events.len=2521 ref_locations.len=52> event_cursor=EventCursor { event_id: 739 } public_commits=<spans [0354c52e2459d828fe4831b9374c3fef707b62e2:27e2829ca0d8116b47db6be384affebafa873022+0:192187]> active_heads=<or <or <or <or <spans [b5696f860f93162bc8c52c5e2d199a375af42826+N470, 23977c9f52de2ddd0ac6352fc585d025088f0980+N421, 246c610563117c86cdb28a75e1bf98b4a21e52a1+N288] + 1 span> <static [79708aa2ba5b7a6b2f60685c959715b2268062e4]>> <lazy [] + ? more>> <static [27e2829ca0d8116b47db6be384affebafa873022]>> <and <lazy [8449ca9b624e0a2f74e03866ae66424464fbfcb2, 60496efa4cb8b2e93c2d9f8224d47a7aad25b662, 4d9a5105919eaaa475263fc75fe9a431f6bbb73a] + 170 more> <spans [0354c52e2459d828fe4831b9374c3fef707b62e2:27e2829ca0d8116b47db6be384affebafa873022+0:192187]>>>
      at src/commands/smartlog.rs:113
   2: branchless::commands::smartlog::graph::make_smartlog_graph with effects=<Output fancy=true> dag=<Dag> event_replayer=<EventReplayer events.len=2521 ref_locations.len=52> event_cursor=EventCursor { event_id: 739 } remove_commits=true
      at src/commands/smartlog.rs:195
   3: branchless::commands::undo::select_past_event with effects=<Output fancy=true> dag=<Dag> event_replayer=<EventReplayer events.len=2521 ref_locations.len=52>
      at src/commands/undo.rs:302
   4: branchless::commands::undo::undo with effects=<Output fancy=true> git_run_info=<GitRunInfo path_to_git="git" env=not shown>
      at src/commands/undo.rs:782

Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
Location: src/commands/mod.rs:261

Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

Originally posted by @KevinWuWon in https://github.com/arxanas/git-branchless/issues/209#issuecomment-966808281

The undo code is somewhat hardened against GC'ed commits, such as for rendering the historical event descriptions, but the smartlog code is less so, and the undo code calls into the smartlog code.
The smartlog code should be updated to use the DAG for these calculations, and not require the successful load of Commit objects. The Node structure should also be updated to make commit be represented as absent due to garbage-collection.

I thought that this was due to GC, but it seems more likely that it's due to a DAG/event log mismatch. To get into this situation, you'd have to attempt to find the path to the main branch from a commit that hasn't been observed by the DAG. That means that the event log had to have observed the commit at some point, without the DAG having become aware of it.
The DAG scans all HEAD and all local branches on startup, and it also scans any commit returned by resolve_commits. After looking through the places where we add events to the event log, it looks like the only reasonable candidates are RewriteEvents (in move.rs or amend.rs), which might have rewritten the commit without the DAG being aware of it. I'm still trying to get a repro case.

I still haven't been able to get a repro case for this.

I never succeeded in reproducing this. If you see it again, please reopen.


Lazy listener executions do not respect AWS Lambda's provisioned concurrency

I have a slack application running 100% on AWS and have been having problems for some time with expired_trigger_id error.
As is already known, it is necessary to respond to the slack API within 3 seconds to avoid this error. I even had to create a lambda to run every 3 minutes, invoking the main lambda to escape the cold start, but this is always the wrong solution.
AWS allows the lambdas to be loaded by default by activating the provisioned concurrency option and indicating how many containers you want to leave on, thus avoiding the cold start problem.
It turns out that I configured everything correctly, but when I call the slack API, instead of the request going to the lambda that is already running, it ends up invoking a new one, thus generating the expired_trigger_id error.
I'm in doubt if this is an AWS or Slack Bolt API problem, I even created a topic on stackoverflow: Provisioned lambda correctly configured but not working as it should
If anyone here can help me with this, I appreciate it.

Hey @BSouzaDock 👋🏻 I'm sorry to hear that you're running into this hosting issue, especially when you're app is already running!
I'm not the right person to help you with this problem, but I just wanted to let you know that you're heard and the core Bolt Python team has eyes on your problem 👀 I'll share it with the team so others can jump in to help out!
I'd encourage others to read over the Stack Overflow post because @BSouzaDock has left some incredible detail in it.

Hey @BSouzaDock, according to AWS's document,

Provisioned Concurrency is not supported on the unpublished version of the function ($LATEST). Ensure your client application is not pointing to $LATEST before configuring provisioned concurrency.
https://docs.aws.amazon.com/lambda/latest/dg/provisioned-concurrency.html#configuring-provisioned-concurrency

Pointing to $LATEST does not work with provisioned concurrency. So, you may need to point version 42 instead of $LATEST in this case.

Hello @seratch , thanks for the reply.
It turns out that me lambda is configured correctly exactly as it says in the documentation.
I created an Alias called Prd and pointed the API Gateway to it instead of the Latest version as you can see:

It has 5 lambdas provisioned in version 44

When the requests begin to arrive, the impression I have is that only 1 provisioned lambda receives the requests, and the others, even if started, cannot receive them, so a new lambda is invoked cold and generates the errors.

Despite multiple provisioned lambdas started, only 1 provisioned lambda is receiving requests.

I performed a very interesting test here, I believe it will help you understand the problem:

I created a workflow step and monitored the lambda logs after execution.
After sending the workflow, the api gateway redirected the request to the lambda alias Prd(v.45) correctly as shown in the printscreen below (red):

Briefly this is the code of the main method of my lambda:
# Start app
def main(event, context):
    show_income_event(event)
    slack_handler = SlackRequestHandler(app=app)

    return slack_handler.handle(event, context)

The show_income_event function is responsible for displaying the request data (body, method, etc.) as shown on the printscreen.

During the processing of the request by the bolt api in the line "return slack_handler.handle(event, context)", instead of continuing the execution within the current lambda or using a provisioned lambda, it is invoking a new lambda cold, as I show in printscreen (marked in green), and within this lambda the workflow step is processed. I believe this is the cause of the problem.

@seratch Yes, I'm using lazy, and I always call lazy by default. This could be the problem.
You can get the lambda alias at runtime like this:
import os

def lambda_handler(event, context):
    function_name = os.environ['AWS_LAMBDA_FUNCTION_NAME']
    alias = function_name.split(':')[-1]

@BSouzaDock
Accessing the os env variables may work too but currently the lazy listener invocation uses ARN rather than the function name. The string is extracted this way: https://github.com/slackapi/bolt-python/blob/v1.16.4/slack_bolt/adapter/aws_lambda/handler.py#L59
And then, the string is passed this way: https://github.com/slackapi/bolt-python/blob/v1.16.4/slack_bolt/adapter/aws_lambda/lazy_listener_runner.py#L26
It seems that function_version is also available in the event context: https://docs.aws.amazon.com/lambda/latest/dg/python-context.html
We need to check if it's feasible to properly invoke a function with the given function version.

Also, if your issue is only the 3+ second expiration of trigger_id, I'd suggest moving the code parts that require trigger_id to ack function side. With that, you can run the code in provisioned funtion, so that the specific issue should be quickly resolved.

Hello @seratch ,
Apparently I managed to solve the problem by passing all initial calls to ack(), thanks for the suggestion.
When it's a call that will take some time for another load and I need to call lazy, I'm displaying a loading modal first and then updating it.
Thanks.

@BSouzaDock How do you transfer view_id and hash from ack function to lazy functions?

Hello @oxess
Both the body and the view can be captured by the ack function or by the lazy one receiving it as a parameter.


Compile GRT instead of using static library

We will need to make changes to GRT; plus adding it to ./setup should be straightforward. Changing CMake is also straightforward. Need to evaluate Xcode...

Commit 1b5660403cbdf5b11a049406a14854cca8bdcb51 directly includes Filter module in ESP codebase instead of GRT. This avoids re-building GRT, thus no need to update libgrt.dylib.
Should this be the intended structure?

Good question. To me, it was convenient because it didn't require re-building the GRT. But in the long run, we may want to send our additions upstream, which will be easier if they're in the GRT repository. How hard do you think it will be to compile the GRT?

It's fairly straightforward with CMake; the current CMake setup in GRT is easy to extend (see an example here: https://github.com/damellis/grt/commit/317b9ce568b5e54f6e992a93beb06201319bcd96, and there were more changes than it needed because of spaces/tabs issue).
I'm leaning toward a clean separation.

Using CMake to compile build changes to the GRT seems reasonable, but it might be good to commit the updated .dylib to this repository so that Xcode users don't need to compile the GRT (and install CMake). What do you think?

For reference, here's the command to run on the libgrt.dylib to set its install path correctly (corresponding to its use in the ESP Xcode project):
install_name_tool -id @executable_path/../Frameworks/libgrt.dylib libgrt.dylib

Maybe we want a custom "make install" action to instal the GRT dylib into the ESP project? Or just a script we can run?

There isn't a decision made on this issue. It looks like we are currently putting custom processing modules (MFCC, e.g.) in ESP instead of GRT. This works fine for now and there doesn't seem to be more custom processing modules at this stage.
The extensibility of GRT is being questioned and can only be resolved with a discussion with Nick. I am closing this issue now; we can reopen this if needed in the future.


can we port this into core?

Hey, I was wondering if we can port some refactored form of this into pytorch?

(because the repo does not have a license)

Oh yeah sure. Would be happy to help with that too! Let me add a license today, which one would work best for PyTorch?

standard BSD 3 clause, like in pytorch.
thank you.

Done!

thank you.

istft isn't in core pytorch yet, it's being worked upon.
Follow pytorch/pytorch#3775 for progress

Does it mean that torch.stft is the optimized version of this stft-pytorch repo?


SASS-179: Connect Personal Income Tax Submission FE MS with Income-Tax-NRS-Proxy MS

Description
Connect the personal-income-tax-submission-frontend service to the income-tax-nrs-proxy service.
SASS-179
Checklist PR Reviewer
Before Reviewing

[x]  Have you pulled the branch down?
[x]  Have you assigned yourself to the PR?
[x]  Have you moved the task to “in review” on JIRA?
[x]  Have you checked to ensure all dependencies are up to date?
[ ]  Have you checked to ensure its been rebased against the current version of main?

Whilst Reviewing

[x]  Have you run the tests?

[ ]  Have you looked at the JIRA story to make sure all Acceptance Criteria has been met?

After Reviewing

[ ]  Have you checked for merge conflicts or any changes in the current main that may affect the current pull request? i.e. does it need another rebase?
[ ]  Have you checked to make sure there are no builds in the pipeline before you merge?
[ ]  Have you moved the task to “in pipeline” on Jira?

[X]  Have you rebased against the current version of main?
[X]  Have you checked code coverage isn’t lower than previously?

After PRs been raised

[X]  Have you checked the PR Builder passes?

NRS released boolean can also be added into the AppConfig and Application.conf then overridden in the MockAppConfig as below.
https://github.com/hmrc/income-tax-submission-frontend/blob/SASS-1736/app/config/AppConfig.scala
https://github.com/hmrc/income-tax-submission-frontend/blob/SASS-1736/test/config/MockAppConfig.scala


intelrealsenseD415（Given depth profile is not supported by current device!）

I have installed Intel® RealSense™ SDK 2.0 (build 2.9.1) successfully and there is no problem installing ROS Wrapper for Intel® RealSense™ Devices.But there existed a question that "Given depth profile is not supported by current device!" when I was testing. I have been confused about the question for a long time .Look forward to your help .Thanks a lot!

This is the output by typing lsusb -t below.The camera is connected to the port belong to bus 002 and it shows that the port on the bus 002 is USB 3.0 .

The 5 GB/s speed claimed by Bus 02 means that it's a USB3 interface and in other hand, the 480 MB/s speed claimed by Bus 01  means that it's a USB2 interface .

Now it can work succesfully.It is the 2.0 connecting line that result in the question.Thanks a lot for your help!

@icarpis My camera is functioning correctly in the RealSense Viewer software that comes with the RealSense SDK 2.0.The detection picture is as follows.And i can run the order 'roslaunch realsense_ros_camera rs_camera.launch' to get the rgb picture.But When i run the order 'roslaunch realsense_ros_camera rs_rgbd.launch' to try to get pointcloud data. It fails and shows the mistake as follows.
/home/tju/Pictures/Screenshot from 2018-03-06 20:40:56.png

@icarpis   My camera is functioning correctly in the RealSense Viewer software  that comes with the RealSense SDK 2.0.The detection picture is as  follows.And i can run the order 'roslaunch realsense_ros_camera  rs_camera.launch' to get the rgb picture.But When i run the order  'roslaunch realsense_ros_camera rs_rgbd.launch' to try to get pointcloud  data. It fails and shows the mistake as follows.


Issue with Gunicorn workers

Too many gunicorn workers. Need some way to share the secret key amongst workers or have less workers.

I was trying to figure out why when I set gunicorn workers to 2 or more, I would not be login properly and then I saw this issue. Temporary fix is to run gunicorn with only a single worker.

I actually didn't realize this was an explicit issue.
I've resolved it in 81345dc6d2ca774ae92e01dd4a6658cafbd8b532 by writing a secret key to the .ctfd_secret_key file. The gunicorn workers will look for the file before generating a new key.
This won't work with multiple servers but it works for most setups.


plot ROC AUC across cv folds

Creates a plot of the ROC AUC across multiple different folds, currently uses sklearn.model_selection.StratifiedGroupKFold to make folds that correspond to each processing batch. Open to suggestions on how to split this into two functions (one for common and one for logisitcReg, but I was hesitant to break up the for loop that fits each model while making each curve. One other concern was the fact that one fold will never have an auc (since one group has no SLE cases)-- but if we want to make groups that are processing batches I don't see a way around that. Here is the figure now:

@pascoesean I've never seen the average ROC curve included as well, on top of the ROCs for each batch.
@aarmey thats all the comments for this PR that I have!


Get a list of anyone who has ever talked to my bot, or has added it? (Node.js)

I'm trying to get an array of addresses, consisting of everyone the bot has ever talked to. There are 2 things I need to accomplish: the ability to get a full address from an address.id, and the ability to generate a full contact list.
Is this possible? If not, I can create an array on the fly as message come in, and put it in a file that updates.

@laptopdude90 your bot needs to keep track of users that it is having a conversation with to achieve this. You can use a data storage of your choice, e.g. a simple persistent hash table, to track unique users that the bot have interacted with.


MenuViewController subclass of UITableViewController

As of now it is not possible to subclass from UITableViewController for the MenuViewController. For example I've written the following class:
class MyMenuViewController: UITableViewController {
    // some logic
}

Now I would like to use this framework. The README states I just need to make MyMenuViewController a subclass of MenuViewController which doesn't work though as I need to subclass UITableViewController and MenuViewController is just a UIViewController subclass.

Hi, @Dschee.
Yes, as you mentioned MenuViewController is a UIViewController subclass and, unfortunately, there is no an ability to use UITableViewController at the moment.
A simple solution is just to use UITableView in your MenuViewController subclass and implement dataSource and delegate as well.
It would be interesting to know why do you prefer to use UITableViewController instead of putting UITableView?
We're thinking about improving this point. Thanks for addressing it!

Please refer to this answer on SO if you want to learn the benefits of UITableViewController – I will not explain why we use it. I know that I could do things with UIViewController and a UITableView but that's not the point. We will not change our code because this library isn't as flexible as it should be.
I think you should not make MenuViewController a class and require apps to subclass from it. I don't have the time right now to think of a better solution, but I know from other side bar libraries that I can assign anything that is a subclass of UIViewController to some type from the library as the menu. If you really need this menu UIViewController to have additional logic you could maybe use a protocol for that instead and make the menu controller confirm to that? Just an idea though, I'm sure there are plenty of different concepts to make this point more flexible.

@Dschee Thanks for your feedback.


Grey text invisible on Solarized Dark

The IDLE indicators are invisible on Solarized Dark, because it renders as bright black, and is invisible on this theme (to be accurate, there's very little contrast so it's effectively invisible):

Extensive discussion of this issue w/ other projects here:
https://github.com/altercation/solarized/issues/220
Expected Behavior
Text should be rendered in a foreground color that is broadly supported by different color schemes.
Current Behavior
Bright black text is invisible.
Context
I didn't even realize there were IDLE indicators until I did an asciinema recording of my terminal!
Steps to Reproduce (for bugs)
Use iTerm 2 w/ Solarized Dark theme. Note that the IDLE indicators are not shown.
Your Environment
OSX Sierra, iTerm 2, Solarized Dark.

I've noticed this depends on the terminal. In the IntelliJ terminal, it shows up, but in iTerm it doesn't.
The loss of "> IDLE" has pretty low impact as a bug, and we cannot control what a user maps to the ANSI colors, so I'm not sure if there's a fix that is easy enough to be worth it.
I welcome others' ideas, and will mark this as help-wanted in case someone wants to come up with a scheme that works in all environments. I think one would start in the DefaultWorkInProgressFormatter class.

@DanielThomas Sorry for the runaround. This is an easy fix, so this'll be improved in Gradle 4.1. See #2444. Closing as complete.


Map Issues

Issues:

Zoom broken when changing map
Flags (Init) and Circle (Goals) duplicated after changing map

Thank you!


Remove CTest support from GoogleTest plugin

We have the new CTest plugin. To avoid confusion, I remove CTest support in the GoogleTest plugin. IIRC, the feature is undocumented and no customer uses it.

oh, test failed 😢

Fixed!


Add \long to definition to mitigate issue.

The linked issue can be mitigated by making \@asy@processerrorline into a \long macro (so it can consume line boundaries (i.e., \par tokens) in its arguments). This likely doesn't address the underlying issue (whatever that may be), but it should at least make the package usable in this case.

I think (one of the) underlying issue is that there are 3 uses of \read instead of \readline. \read tokenizes the line under the current category regime, which includes two consecutive newlines being tokenized into \par --- it would be safer to use \readline instead, although admittedly that makes the programming a bit harder because you need to match the asy string in other cat instead of letter cat.

I've changed one particular instance of the line \endlinechar=‘ˆˆJ to \endlinechar=-1. This has eliminated several gratuitous empty lines in the error message, and appears to make the \long declaration unnecessary. Let me know if it works for you.
I looked into \read versus \readline, and there's no clear consensus that \readline is better. To avoid the programming issues you mentioned, I've continued to use \read. If there are other reasons to prefer \readline, I'm happy to hear them. (If the implications are something like a minor misformatting of the error message, I'm still interested to know about it, but I reserve the right to deprioritize fixing it.)

Tokenizing all these tokens as TeX tokens has the obvious implications.
Example 1.
%! TEX program = pdflatex
\documentclass{article}
\usepackage{asypictureB}
\begin{document}
\begin{asypicture}{}
    unitsize(1cm);
    draw((0, 0)--(1, 1));
    var      ""     error;
\end{asypicture}
\end{document}

⟹
! Package asypictureB Error:
var "" error;
^
a-noname.asy: 7.15: syntax error
error: could not load module 'a-noname.asy'

3
4
5     unitsize(1cm);
6     draw((0, 0)--(1, 1));
7     var      ""     error;
.

Problem:
! Package asypictureB Error:
var "" error;
^

the multiple spaces are collapsed into one.

%! TEX program = pdflatex
\documentclass{article}
\usepackage{asypictureB}
\begin{document}
\begin{asypicture}{}
    unitsize(1cm);
    draw((0, 0)--(1, 1));
    {
\end{asypicture}
\end{document}

Error:
Runaway definition?
->{
! File ended within \read.
<read 4>

l.9 \end{asypicture}

?

%! TEX program = pdflatex
\documentclass{article}
\usepackage{asypictureB}
\begin{document}
\begin{asypicture}{}
    unitsize(1cm);
    draw((0, 0)--(1, 1));
    "\ab" error
\end{asypicture}
\end{document}

Error:

! Undefined control sequence.
\@asyerrormessage ->
"\ab
                          " error
^
a-noname.asy: 7.11: syntax error
error: ...
l.9 \end{asypicture}

Using \readline is safer.

Those are some pretty good points. I've changed the two instances of \read for comparing files to \readline, which for some reason seems to fix your Example 2 (unmatched {). I consider Example 1 (collapsing whitespace) unfortunate but not critical since the only remaining use of \read is for parsing and printing the error message.
Example 3 (undefined control sequence) still seems to be a major bug. Unfortunately, it may be beyond my capability to fix. (The error-parsing code of asypictureB was the culmination of my TeX programming expertise, which has since grown rusty.)

I see, looks like you don't fully understand what's the difference either. (no offense intended) I'll try to fix it and send a pull request.

I see, looks like you don't fully understand what's the difference either. (no offense intended)

No offense taken. I mostly understand the difference between \read and \readline, but I had forgotten (to the extent I ever knew) about tools like \noexpand and especially \detokenize that make your modifications feasible. Thanks!


Entity.Null after reboot scene

after restarting the scene with the entity prefabs, they become Null, but the entries in the dictionary remain, the problem was solved as follows
           [Unity.Burst.BurstCompile]
   partial struct RegisterPrefabPoolJob : IJobEntity
   {
       public EntityCommandBuffer ECB;
       public NativeHashMap<FixedString64Bytes, Entity> Prefabs;
       [ReadOnly] public FixedString128Bytes WorldName;
       public void Execute(in Entity entity, in DynamicBuffer<RequestPrefabPoolRegistration> buffer)
       {
           int numBefore = Prefabs.Count;
           foreach (var request in buffer)
           {
               if (Prefabs.TryAdd(request.PrefabID, request.Prefab))
               {
                   Debug.Log($"{WorldName} RegisterPrefabPoolJob: '{request.PrefabID}' prefab registered successfully.");
               }
               else
               {
                   if (Prefabs[request.PrefabID] == Entity.Null)
                   {
                       Prefabs[request.PrefabID] = request.Prefab;
                   }
                   else
                   {
                       Debug.LogWarning($"{WorldName} RegisterPrefabPoolJob: '{request.PrefabID}' prefab registration failed! Prefabs.Count ={Prefabs.Count}");
                   }
               }
           }
           int numAfter = Prefabs.Count;

           ECB.RemoveComponent<RequestPrefabPoolRegistration>(entity);
           ECB.DestroyEntity(entity);

           Debug.Log($"{WorldName} RegisterPrefabPoolJob: RequestPrefabPoolRegistration processed, {numAfter - numBefore} prefabs added");
       }
   }

Hi @kostarevVP!
Thank you for investigating this. It would probably be the best if you could create a PR originating from #develop or #upm branch - I will then merge it so github will credit you as project contributor properly.
I can add this code myself if you have no time for that ofc, let me know.
Have a good day

Hi again @kostarevVP!
Can we arrange this as a PR? Or maybe you prefer me to do this instead?
Cheers!


audit the useage of RngCore + CryptoRng vs Rng vs CSPRNG

this triggers me to think if we should replace some RngCore + CryptoRng trait bound in our API to just Rng?

We are not implementing an PRNG ourselves, so we should probably always use Rng over RngCore, (since the latter is for backend implemented by the generator)
What are some places where we have to use CSPRNG? probably not in schonrr or transcript?

Originally posted by @alxiong in https://github.com/EspressoSystems/jellyfish/pull/53#discussion_r851586106

Some follow-up conversations here: https://github.com/RustCrypto/traits/issues/1087


Translates the files of the folder lesson-template in french

Hi microsoft devs :slightly_smiling_face:
I am creating this Pull Request to help a little with the french translation of this repository, during the Hacktoberfest.
This Pull Request translates the README.md and the assignment.md files of the folder lesson-template into french..

This Pull Request is actually waiting for reviewers to take a look at it, and give me some feedback on it.


[WIP] Update installation-guide.md

Update installation guide.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3085/

Build Success with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/495/

Can one of the admins verify this patch?

LGTM


chore: add e2e tests for notifications sms & in-app-messaging

Description of changes
This adds test coverage for pre-existing notification channels (SMS), and ensure compatibility between those channels and the new channel (In-App Messaging). It also make sure that both SMS/In-App Messaging channels continue to work well with Pinpoint/Analytics.
These test cases ensure the following flows work, and that configuration files are set correctly.

adding/removing notifications in a new project (SMS)
adding/removing notifications in a new project (in-app messaging)
adding/removing notifications in a project that has pinpoint configured already (SMS)
adding/removing notifications in a project that has pinpoint configured already (in-app messaging)

Additionally, several checks for file configuration states, locally & in the cloud, are included.
See slack for information on test cases.
E2E is running at: https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli?branch=run-e2e%2Faluja%2Fadd-e2e-notifications-in-app

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #11207 (f5a2008) into dev (6f15294) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev   #11207   +/-   ##
=======================================
  Coverage   49.46%   49.46%
=======================================
  Files         680      680
  Lines       32830    32830
  Branches     6702     6702
=======================================
  Hits        16239    16239
  Misses      15111    15111
  Partials     1480     1480

Impacted Files
Coverage Δ

...otifications/src/notifications-amplify-meta-api.ts
16.66% <ø> (ø)

...y-category-notifications/src/channel-in-app-msg.ts
92.64% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Feat/corcel+llama+gemini

Proposed changes
Adds corcel, llama and gemini request tools that support both prediction and completion.
Fixes
N/A
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

[x] Non-breaking fix (non-breaking change which fixes an issue)
[ ] Breaking fix (breaking change which fixes an issue)
[ ] Non-breaking feature (non-breaking change which adds functionality)
[ ] Breaking feature (breaking change which adds functionality)
[ ] Refactor (non-breaking change which changes implementation)
[ ] Messy (mixture of the above - requires explanation!)

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] I am making a pull request against the main branch (left side). Also you should start your branch off our main.
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works

Further comments
N/A

Not sure what is happening to Windows lock check. It seems to stall while installing tomte.

@0xArdi I'm getting a linter error failure on an already existing component:
Processing /home/david/Valory/repos/mech/packages/nickcom007/customs/prediction_request_sme_lite/component.yaml
Failed!
sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='/dev/null' mode='w' encoding='UTF-8'>
ERROR: InvocationError for command /home/david/Valory/repos/mech/.tox/check-packages/bin/autonomy check-packages (exited with code 1)
__________________________________________________________________________________________ summary ___________________________________________________________________________________________
ERROR:   check-packages: commands failed


Warnings about using Node12

In my project, I'm seeing deprecation warnings about Node12. They look like:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: baptiste0928/cargo-install@v1

I see that your action.yml file does specify Node16 - Can you give any hints about how to avoid the warning above? Many thanks.

Hello! The action was updated to Node.js 16 in a commit that hasn't yet been released. I will publish an update soon.

Excellent. Thank you!

I have rolled back the changes for the 1.3.1 release to avoid any breakage. The removal of node 12 for actions is planned for this summer, I will release a new major version before then.

OK, thanks @baptiste0928 .
BTW your action has been great — we've now replaced all similar ones in PRQL with it, and I've been recommending it to others. Thanks for your work!

Thank you, I appreciate your message! Glad to hear that my work has been helpful to you and your team.

I finally fixed this warning in the latest version! Since it's a major update, you'll need to manually update your workflows to use the v2 tag (changelog).


[Docs] Update Chinese documentation

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

Hi, @ZCMax , @jshilong, the documentations have been updated to latest version. Please have a check.


Zuul stripPrefix problem

I am playing with the customers-stores sample.
I routed all traffic from the UI app to go through a separate Zuul server.
Problem:

in the UI I have these configurations:

  .constant('appConfiguration', {
   customerApiUrl: 'http://localhost:8765',
    storeApiUrl: 'http://localhost:8765/stores'
  })

in Zuul:

zuul:
  ignored-services: "*"
  routes:
    stores:
      path: /stores/**
      stripPrefix: false
    customers:
      path: /customers/**
      stripPrefix: false

According to the documentation:
application.yml
 zuul:
  routes:
    users:
      path: /myusers/**
      stripPrefix: false

In this example requests to "/myusers/101" will be forwarded to "/myusers/101" on the "users" service.
But, it doesn't really work like that. In the Zuul console:
Matching patterns for request [/customers] are [/customers/**]
RestClient sending new Request(GET: ) http://CLUJPC100:9000

So, it strips the suffix "customers". Am I missing something?
From an API Gateway perspective it does not make sense to have "/customers/customers" anyway.

Sorry, I'm not quite following what. Since it obviously works with the existing sample, maybe we could work backwards from there. What is it that does work there and doesn't for you?

It may be the fact that the app is configured with a servlet path of '/' .  Maybe try it with the trailing '/'.  so something like this http://<IP_ADDRESS>:8765/customers/ instead of http://<IP_ADDRESS>:8765/customers .  I think i had run into similar issues before.

I will clone the original samples project and see what I did wrong.
I'll keep you posted.

I cloned the customers-stores sample again.
Having the same problem though:
(request generated from the UI)
GET http://localhost:9900/stores 200 OK
{
"_links" : {
"stores" : {
"href" : "http://localhost:9900/stores/stores{?page,size,sort}",
"templated" : true
},
"profile" : {
"href" : "http://localhost:9900/stores/alps"
}
}
}
I was supposed to see the list of stores in the UI, and get the list of stores straight away.
Am I missing something?

I am seeing the same thing.  My code was working a couple weeks ago using the stripPrefix setting (I had not been working on the code for a couple of weeks) but today when I did a build and pulled down the latest snapshots it does not appear that the stripPrefix property is working, it looks like it is still stripping them off.

@ryanjbaxter same here

I still don't know what you guys are seeing that I am not. Can someone write a test that fails please?

Hi, i will test later today with your change.
Should I declare properties related to server.servletPath?

I think the whole thing is that if you have, in zuul, the stripPrefix: false specified for your service. Then in the service configuration you have this set
server:
  contextPath: /yourservice

you should be able to perform the request without issues.  I have a few services that do this exact thing, they are working as expected.

I didn't even test server.contextPath (but I expect it should just work). Do you mean we can close this issue?

Does not work. Here is the current situation:
*1. Original Sample Customers-Stores
The stores tab does not work. nothing is loaded. The response received is this:
{
"_links" : {
"stores" : {
"href" : "http://localhost:9900/stores/stores{?page,size,sort}",
"templated" : true
},
"profile" : {
"href" : "http://localhost:9900/stores/alps"
}
}
}
The url that works is http://localhost:9900/stores/stores
Setting the server.contextPath to /stores makes things even worse. The url that would work would be like this http://localhost:9900/stores/stores/stores.
So the sample application does not work out of the box.
*2. My custom setup removes the proxy capabilities from the customers-ui and routes all requests to a standalone Zuul server on 8765.
If I declare these configurations in app.js:
customerApiUrl: 'http://localhost:8765/customers',
storeApiUrl: 'http://localhost:8765/stores'
works to load customers, add customer and display stores.
This configuration does not work:
customerApiUrl: 'http://localhost:8765',
storeApiUrl: 'http://localhost:8765'. It would be the same case as the original sample.
The problem appears when displaying a customer and loading stores nearby. Loading the stores nearby does not work.
The response for  http://localhost:8765/customers/customers/1 contains:
"_links" : {
"self" : {
"href" : "http://localhost:8765/customers/customers/1"
},
"stores-nearby" : {
"href" : "http://localhost:8765/stores/search/findByAddressLocationNear?location=0.0,0.0&distance=50"
}
}
I wonder why /customers/ is doubled and /stores/ is not.

The magic is performed here:
@HystrixCommand(fallbackMethod = "defaultLink")
public Link getStoresByLocationLink
where:
http://CLUJPC100:8081/stores/search/findByAddressLocationNear?location=0.0,0.0&distance=50
becomes:
http://localhost:8765/stores/search/findByAddressLocationNear?location=0.0,0.0&distance=50

Guys,
I would like Zuul to behave like this:
A request to Zuul localhost:8765/stores/xxx to be routed to Stores service on localhost:8081/stores/xxx.
Whatever I do I am not able to make it behave like this.
I got the UI app working by adding doubling suffixes everywhere such that all requests passing through Zuul look like this: localhost:8765/customers/customers/xxx and localhost:8765/stores/stores/xxx

I'm seeing the issue in customer-stores.  I'm working on it.

Thanks

@aivans @ryanjbaxter can you test snapshots (once the build completes) and let me know?  My locally running customer-stores was fixed.

@spencergibb Thank you. Works as expected.

@spencergibb its working for me as well, thanks!


Added files to support azure datalake storage

Description of changes:
This PR adds functionality to support Azure DataLake type storage.
Issue :
This is in response to the discussion in the issue #292.
Fixes #292.
Merge Checklist:
Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the contributor guidelines
[x] This is a documentation change or typo fix. If so, skip the rest of this checklist.
[x] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
[x] I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

[x] I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
[x] I have added tests that prove my fix is effective or that my feature works (if appropriate).
[x] I ran the tests locally to make sure it pass. (check out testing)
[x] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

Hi @shivshandilya, thanks for creating the PR. With respect to your linting failures, are you running pre-commit run --all-files to ensure it complies with the linting rules ? Ref link.

Hey @karan6181 , running the command pre-commit run --all-files, doesn't show any errors with the files I added but with some other older files like docs/source/examples and all the yaml files.

and

There seems to be some eol erros that the pre-commit hooks detect. I am running this on a wsl environment with Ubuntu.
Any idea why this happens? maybe due to the difference in eol sequence in windows and linux(LF and CLRF)?

Also strangely the pre-commit checks pass here, and not on my local machine😅.

I am also running it on a wsl environment with Ubuntu, but I still have the error🤔.

Can you also update the description with the output showing that upload and download functionality works as expected ? Thanks!


[Snyk] Security upgrade alpine from 3.18.2 to 3.19.1

This PR was automatically created by Snyk using the credentials of a real user.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

monitoring-as-code/Dockerfile

We recommend upgrading to alpine:3.19.1, as this image has only 2 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

714
Out-of-bounds Write SNYK-ALPINE318-BUSYBOX-5890990
No Known Exploit

714
Out-of-bounds Write SNYK-ALPINE318-BUSYBOX-5890990
No Known Exploit

714
Out-of-bounds Write SNYK-ALPINE318-BUSYBOX-5890990
No Known Exploit

614
CVE-2023-5363 SNYK-ALPINE318-OPENSSL-6032386
No Known Exploit

614
CVE-2023-5363 SNYK-ALPINE318-OPENSSL-6032386
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Note: This is a default PR template raised by Snyk. Find out more about how you can customise Snyk PRs in our documentation.
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Superseded.


Github6121

Reference Issue

What does this implement/fix? Explain your changes.
The Issue
rdDetermineBonds.DetermineBonds() throws an error ValueError: Final molecular charge does not match input; could not find valid bond ordering when used for a single atom.
The Fix
When a single atom is inputted into the determineBonds() function it will now check the number of atoms in the mol object and if it is <= 1 it will return to prevent an error from being thrown.
I have also included a test specific to this issue in DetermineBonds/catch_tests.cpp
Any other comments?
This is my first official commit to an open-source project, so if there is ANYTHING I can do better please tell me. Nothing will be taken to heart but I want to get better at programming.

@dessygil thanks for taking this on and diving into making C++ contributions to the RDKit. It's non-trivial to get started and it's great that you've come so far!
A general comment on working with the code and suggesting PRs: It looks like you're making changes and then updating the PR in order to see if they work. It's more efficient to build the code locally and test your changes on one of the RDKit's supported platforms before doing (or updating) the actual PR. Doing the CI builds generally takes at least an hour and you have to wait that full hour every time, whereas if you build/test locally you only have to rebuild the files you change each time. Those quicker feedback loops make things a lot easier for most cases.

@Greg Landrum @.***> It seemed sensible to put the test
in Code/GraphMol/DetermineBonds/catch_tests.cpp, but we couldn't work out
what target that test is in to build it separately.  The CLion analyser
says it's not in any project, for example.  Running tests via the CI builds
seemed like the only option, on the assumption that the code is being run
there.
On Mon, Mar 6, 2023 at 5:22 AM Greg Landrum @.***>
wrote:

@dessygil https://github.com/dessygil thanks for taking this on and
diving into making C++ contributions to the RDKit. It's non-trivial to get
started and it's great that you've come so far!
A general comment on working with the code and suggesting PRs: It looks
like you're making changes and then updating the PR in order to see if they
work. It's more efficient to build the code locally and test your changes
on one of the RDKit's supported platforms before doing (or updating) the
actual PR. Doing the CI builds generally takes at least an hour and you
have to wait that full hour every time, whereas if you build/test locally
you only have to rebuild the files you change each time. Those quicker
feedback loops make things a lot easier for most cases.
—
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/pull/6171#issuecomment-1455474611, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACGF2FWHHTYPSRAKPX2HIL3W2VYAVANCNFSM6AAAAAAVQLCHW4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
David Cosgrove
Freelance computational chemistry and chemoinformatics developer
http://cozchemix.co.uk

@greg Landrum @.***> It seemed sensible to put the test in Code/GraphMol/DetermineBonds/catch_tests.cpp, but we couldn't work out what target that test is in to build it separately. The CLion analyser says it's not in any project, for example.

As usual, I'm not sure what CLion is doing. :-)
The way to figure out the target for a given test file is to look in the CMakeLists.txt in the directory where the file lives.
In this case you'd see:
rdkit_catch_test(determineBondsCatchTest catch_tests.cpp
           LINK_LIBRARIES DetermineBonds FileParsers SmilesParse DistGeomHelpers ForceFieldHelpers)

telling you that the target is determineBondsCatchTest

i did look there, but in my standard CMake build dir, independent of CLion,
I get:
make determineBondsCatchTest
make: *** No rule to make target `determineBondsCatchTest'.  Stop.
whereas, for example 'make moldraw2DTest1' does build. A find for
determineBondsCatchTest doesn't come up with anything either.
On Mon, Mar 6, 2023 at 9:32 AM Greg Landrum @.***>
wrote:

@greg https://github.com/greg Landrum @.***> It seemed sensible to
put the test in Code/GraphMol/DetermineBonds/catch_tests.cpp, but we
couldn't work out what target that test is in to build it separately. The
CLion analyser says it's not in any project, for example.
As usual, I'm not sure what CLion is doing. :-)
The way to figure out the target for a given test file is to look in the
CMakeLists.txt in the directory where the file lives.
In this case you'd see:
rdkit_catch_test(determineBondsCatchTest catch_tests.cpp
LINK_LIBRARIES DetermineBonds FileParsers SmilesParse DistGeomHelpers ForceFieldHelpers)
telling you that the target is determineBondsCatchTest
—
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/pull/6171#issuecomment-1455786668, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACGF2FU5PZTEDWDNKJSFD6DW2WVLTANCNFSM6AAAAAAVQLCHW4
.
You are receiving this because you commented.Message ID:
@.***>

--
David Cosgrove
Freelance computational chemistry and chemoinformatics developer
http://cozchemix.co.uk

i did look there, but in my standard CMake build dir, independent of CLion, I get: make determineBondsCatchTest make: *** No rule to make target `determineBondsCatchTest'. Stop. whereas, for example 'make moldraw2DTest1' does build. A find for determineBondsCatchTest doesn't come up with anything either.

Did you run cmake with -DRDK_BUILD_XYZ2MOL_SUPPORT=ON?

I feared it might be something as obvious as that.  Thanks.
On Mon, Mar 6, 2023 at 11:17 AM Greg Landrum @.***>
wrote:

i did look there, but in my standard CMake build dir, independent of
CLion, I get: make determineBondsCatchTest make: *** No rule to make target
`determineBondsCatchTest'. Stop. whereas, for example 'make moldraw2DTest1'
does build. A find for determineBondsCatchTest doesn't come up with
anything either.
Did you run cmake with -DRDK_BUILD_XYZ2MOL_SUPPORT=ON?
—
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/pull/6171#issuecomment-1455945778, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACGF2FXEAIN6M6JQWLAIK5DW2XBVRANCNFSM6AAAAAAVQLCHW4
.
You are receiving this because you commented.Message ID:
@.***>

--
David Cosgrove
Freelance computational chemistry and chemoinformatics developer
http://cozchemix.co.uk

Thanks, both of you for the help, I'm going to make the quick change that was suggested for the test and then rebuild with the -DRDK_BUILD_XYZ2MOL_SUPPORT=ON?

@dessygil thanks for the contribution!
For future reference: if you include something like "Fixes #6171" in either a commit message, the name of the PR, or the PR description, then the PR will be automatically linked to the associated issue and the issue will be closed when the PR is merged. I've done that manually here, but please do it yourself for future PRs.


Overriding both default light and dark theme's not working

I'm trying to override the default light theme with "emerald" and dark theme with "black"
daisyui: {
    themes: ["emerald", "black"],
    darkTheme: "black",
}

But this doesn't work. Instead it only overrides the light theme, and the dark theme is the same as the light one.
But when i let the default light theme be "light", the dark theme overriding works normally:
daisyui: {
    themes: ["light", "black"],
    darkTheme: "black",
}

Additionally when i add another theme to the array, the dark theme overriding also doesn't work:
daisyui: {
    themes: ["light", "black", "emerald"],
    darkTheme: "black",
}

I don't know if i'm doing something wrong there, but from what i've read at the docs it's pretty much explained like that

Hi @greidinger-reis !
I couldn't replicate this issue on my end.
Would you mind creating an mwe for this ?
I'd love to help :blush:

I don't even think it's a good idea to do what I was trying to do, so I will just close this issue


Virtual keyboard with ESP32 and Gemini GEM-K2AS

I'm happy to found this project! What you do is great and I'm looking for to do the same but with an ESP32 and a GEM-K2AS keypad.
The Arduino code is just for sending bytes (am I right?). How can you read out the information from the keyboard? What kind coding/decoding needed to get the information running through on the wires from the keypad to the sec. system? Is it the same as from the initial idea? (https://www.wizzycom.net/napco-1632-virtual-keypad-project/)
The ESP32 has a TX and RX pins - but if the signal is too weak it also has digital pins as well. I have some experiences building circuits but I'm mainly an sw developer. Making my home smart, the only thing is left to make my old, wired security system a bit smarter. Wanted to arm and disarm remotely and get the current status of my alarm. I plan to make it work with Homekit via a Homebridge plugin.

Hey @zonehun, I am a hw and sw dev who is in the same boat as you. Do you have a napco system you're trying to make a virtual/local controller for as well?
I found this, which seems to be a minimal java implementation of parts of the serial protocol: https://github.com/poflynn/jGemNap
I'd like to make an ESP32/esphome device that plugs in to the security system, because I want to read the zone info, arm, and disarm without using the napco app or keypad.


feat: refresh on BufModifiedSet

Add the event BufModifiedSet to default_refresh_events so that it is instantly visible if the buffer content is modified or not.

(I find this useful when jumping around in history with u/Ctrl-r so that it is immediately obvious when you are at the current state of the file, i.e. the buffer modified indicator updates immediately.)

I have squashed the commits now.
Is there anything I can/should do to get this merged?


Provide options in devcontainer.json for store-dir and virtual-store-dir

PNPM benefits come from symlinking existing packages into your curent project.
Working with docker, creates the necessity to store your global pnpm store in a volume in order to reuse them.
Usually one would create an .npmrc file to store these variables so that pnpm knows where to look at.
(This is also done when executing pnpm config set store-dir <PATH> and pnpm config set virtual-store-dir <PATH>. The file will be created in the current PWD)
PNPM looks at different places for that file. If there is nothing in your project directory, it will look in $HOME which depends on the current user. Currently before I can reuse my packages I always have to execute these lines when building the container:
ARG PROJECT_NAME=demo

# set pnpm store locations
# store-dir = global store
RUN cd ~ \
  && mkdir .pnpm \
  && pnpm config set store-dir ~/.pnpm/${PROJECT_NAME}/store \
  && pnpm config set virtual-store-dir ~/.pnpm/${PROJECT_NAME}/node_modules/.pnpm

Setting the global store as part of the config, would eliminate this step and ~/.pnpm/store would be read from the volume.
ref:

https://pnpm.io/configuring
https://pnpm.io/npmrc#node-modules-settings

Thank you for the suggestion!
If #4 takes too long or is rejected, I will look into this :)

This feature was moved into devcontainers-contrib:
https://github.com/devcontainers-contrib/features/issues/265
Therefore the version in this repo is deprecated.
I suggest that you repeat your feature request over there, maybe the new maintainer will add it. :)


Fix typo in nf-winreg-reggetvaluew.md

Change "Restrict type to 64-bit RRF_RT_REG_BINARY | RRF_RT_REG_DWORD" to "Restrict type to 64-bit RRF_RT_REG_BINARY | RRF_RT_REG_QWORD".

#sign-off


Doesn't work with Vitejs

Describe the bug
Danfojs cannot be loaded in a Vitejs project.
To Reproduce
Steps to reproduce the behavior:

Create a new Vitejs project
Install danfojs as a dependency
Import it in any module of the application with import * as dfd from 'danfojs'
See the error below:

[plugin:vite:import-analysis] Failed to resolve entry for package "danfojs". The package may have incorrect main/module/exports specified in its package.json.

Expected behavior
The import works and you can use danfojs in your Vitejs app
Repro
You can see a repro in CodeSandbox here. Creating a new Vitejs application locally leads to the same issue (meaning that it's not an issue with CodeSandbox), and the issue happens regardless of whether you use TypeScript or JavaScript.

Yeah likewise I encountered the same problem :thinking:

Hey @simoneb is there any work around you did about this to work?

I fiddled around with the installed package's package.json file but it wasn't by any means a robust solution. The fix should be fairly simple though, it's just a matter of getting the exports right in the package file.

same here

While this is not fixed, here is a temporary solution at least worked for me, btw i'm using yarn.
add this to your package.json file:
"resolutions": {
"mathjs": "11.11.0"
},

My less than ideal workaround to get it going before this is fixed is just loading via script tags <script<EMAIL_ADDRESS>/> then you can use dfd globally.

I've created a draft PR with an implementation that works locally, but I'm not too happy with.
I'm new to package exports, so it's all a little blurry, hence why I'm keeping this one as a draft, but hopefully that's a start to fix the issues and could do with some help to finish it off.
Both for a new vite app and a new CRA app, I've linked the package locally with npm link danfojs, then used the following code in the root file:
import * as dfd from 'danfojs'
const s = new dfd.Series([1, 3, 5, undefined, 6, 8])
s.print()

Both apps run fine without runtime errors and display the series in the console.

However, types don't work, and I get the following error in CRA terminal output:
WARNING in ../danfojs/src/danfojs-browser/lib/bundle.esm.js 9:47-54
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

WARNING in ../danfojs/src/danfojs-browser/lib/bundle.esm.js 12:44-51
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

Has anyone figured out how to fix this issue? I was really looking forward to using this library in our production pipeline, but I can't remove Vite unfortunately and local hacks/fixes are a no go either.

I managed to get it work in ViteJS. I found out that the main problem is that they pointed out "module": "lib/bundle-esm.js" when it should actually be "module": "lib/bundle.esm.js". (the path is incorrect).
To get it working:

Clone their code: https://github.com/javascriptdata/danfojs.git
In package.json of my project I added the dependency: "danfojs": "file:///C:/GitRepo/danfojs/src/danfojs-browser"
Change directory to danfojs/src/danfojs-browser
Edit package.json line 7:   "module": "lib/bundle.esm.js"
Run yarn build:esm-bundle
Done!

This hack works for me, instead of
import * as dfd from "danfojs"
do
import * as dfd from "danfojs/dist/danfojs-browser/src"

This hack works for me, instead of import * as dfd from "danfojs" do import * as dfd from "danfojs/dist/danfojs-browser/src"

thanks 😊


KeyError: 'layerFile' issue

Describe the bug
While following the steps as mentioned in the article- https://software.intel.com/en-us/articles/detecting-acute-lymphoblastic-leukemia-using-caffe-openvino-neural-compute-stick-2-part-1?fbclid=IwAR15wmR-qw10GfVuaswuLV6RGcPqx3PLyXY8x1gLEv_ijdyxjkfwOHcapQA , I tried running the command to check the Network configuration using python Info.py NetworkInfo, and that's when I got the error. Logs provided in later section.
To Reproduce
Steps to reproduce the behavior:

Follow the steps up till installing any requirements using Setup.sh and then check the network config.
See error

Expected behavior
Should have worked as intended,i.e. show the network being created properly.
Actual behavior
python Info.py NetworkInfo
2019-03-20 23:31:51|allCNN|Status: Init complete
Traceback (most recent call last):
File "Info.py", line 177, in
main(sys.argv[1:])
File "Info.py", line 155, in main
allCNN.loadCaffeNet()
File "Info.py", line 62, in loadCaffeNet
self.net = caffe.Net(self.confs["Settings"]["Classifier"]["layerFile"], caffe.TEST)
Desktop (please complete the following information):

OS: [Ubuntu 16.04 LTS]
Hardware: [UP2 Board]

Hi @rishabhbanga thanks for the bug report. The fix will be pushed soon.

Issue should now be resolved with: https://github.com/AMLResearchProject/AML-ALL-Classifiers/pull/42


FLOPs computation

Dear author！ Thank you for your exciting work. Can you share your code about how to compute the FLOPs?

you can find this information under each examples
https://guochengqian.github.io/PointNeXt/examples/scanobjectnn/


added kick command for #166

Very WIP, not sure if everything I did is correct

maybe add ice thing, otherwise seems pretty good

very WIP? more like very poggers!
Thanks!


Try out Mesh Networks

Try out different Mesh network implementations (i.e. B.A.T.M.A.N-adv) - either in Docker or bare-metal and directly on the
Pi's

Install Batman: apt-get install batctl
Create a mesh.sh file:

#!/bin/bash
sudo modprobe batman-adv
killall wpa_supplicant
sudo ip link set wlan0 down
sudo ifconfig wlan0 mtu 1500
sudo iwconfig wlan0 mode ad-hoc
sudo iwconfig wlan0 essid my-mesh-network
sudo iwconfig wlan0 ap any
sudo iwconfig wlan0 channel 8
sleep 1s
sudo ip link set wlan0 up
sleep 1s
sudo batctl if add wlan0
sleep 1s
sudo ifconfig bat0 up
sleep 5s
# Use different IPv4 addresses for each device
# This is the only change necessary to the script for
# different devices. Make sure to indicate the number
# of bits used for the mask.
sudo ifconfig bat0 <IP_ADDRESS>/16

make the script executable: chmod 700 mesh.sh
Add to crontab so that its executed at every reboot:
sudo su crontab -e add the following line @reboot /path_to_mesh.sh_file/mesh
Test by executing the following command:
batctl n

Source: http://www.techinterchange.com.au/howto-setup-rasbian-buster-with-batman-mesh-networking/


livepeer_orch_delegator_bonded_amount doe not include pending stake

Describe the bug
I just noticed that the livepeer_orch_delegator_bonded_amount parameter does not include the pending stake accumulated due to network inflation. It would also make sense to offer users the ability to show the total reward (i.e. bonded + pending).
Reproduction steps

Go to https://dashboards.transcode.ninja/public-dashboards/612ce9347bc44e1885e6417b145f4093?orgId=1&refresh=30s.
Check out the delegators panel.
See the summed rewards don't add up to the amount shown on the orchestrator transcoder page.

Expected behaviour
No response
Screenshots / Live demo link
No response
System information

Run method: docker
OS: Linux Ubuntu 22.04
Exporter version: 2.4.1

Additional context
No response

@stronk-dev, the subgraph also returns the bonded amount without the pending rewards of a delegator. Do you maybe know of a way to improve this:
https://github.com/transcodeninja/livepeer-exporter/blob/d25dda8bc9c9d8568d9565aab36d987734aa7b2d/exporters/orch_delegators_exporter/orch_delegators_exporter.go#L23-L28
My main account, for example, has a cumulated stake of 49.76 while the subgraph returns 49.018229682364821635  🤔.

You could check pending stake on-chain: https://arbiscan.io/address/0x35Bcf3c30594191d53231E4FF333E8A770453e40#readProxyContract#F19
My new API would also count the total stake correctly once that's finished (and I might put some PR's back to the subgraph repo so that one is correct too)

You could check pending stake on-chain: https://arbiscan.io/address/0x35Bcf3c30594191d53231E4FF333E8A770453e40#readProxyContract#F19
My new API would also count the total stake correctly once that's finished (and I might put some PR's back to the subgraph repo so that one is correct too)

@stronk-dev, thanks a lot for your answer! For now, I'm happy with the stake without the pending stake. It would be nice to add this feature to the subgraph. If I find time, I will also take a look 👍🏻.

@stronk-dev I've opened issue #158 to keep tabs on our discussed feature request. With a strong interest in incorporating this info into the exporter, I'm considering taking it up when time allows. I'll drop a comment on the issue if I proceed. If you're planning any PRs for the subgraph, feel free to comment as well to avoid duplicate efforts 👍🏻.


Improve message logging functionality of NetworkConnection.

Now it shows the Message type.

why is this better?

Because now it shows the Message Type name, which is actually useful as opposed to the msgid, which you can't learn anything from directly.

I agree. Would help identify what's going on rather than going "uhh, what message is associated with this ID?" and have to try to look it up etc.

I improved the else if case in NetworkConnection so we don't have to do it in this PR too.
please resolve conflicts, sorry

actually, let's wait for NetworkMessage removal for this one.
after NetworkMessage removal we will be able to return the Message in UnpackMessage, which means that we can simply add GetType(message) in the NetworkConnection logging.
checking NetworkConnection.logMessages from MessagePacker is a bit weird too.


Task's declared required resources are missing from the TaskRun

Playing around with tasks for a while but it doesn't matter if I change the order of the spec. If keeps saying Task's declared required resources are missing from the TaskRun
Expected Behavior
Running task without error
Actual Behavior
Error: Task's declared required resources are missing from the TaskRun
Steps to Reproduce the Problem

tkn task create -f java-gradle-test-task.yml
tkn task start java-gradle-test-task --showlog

Additional Info
java-gradle-test-task.yml
apiVersion: tekton.dev/v1beta1
kind: Task
metadata:
  name: java-gradle-test-task
  namespace: helixs-tst
spec:
  inputs:
    resources:
      - name: source
        type: git
    params:
      - name: gradle-image
        type: string
        default: 'gradle:jdk8'
      - name: pathToContext
        type: string
        default: /workspace/source
  stepTemplate:
    env:
      - name: GRADLE_USER_HOME
        value: $(inputs.resources.source.path)
  steps:
    - args:
        - '-c'
        - |
          set -e
          ./gradlew check
      command:
        - /bin/bash
      image: $(params.gradle-image)
      name: test
      resources: {}
      workingDir: $(inputs.resources.source.path)

Kubernetes version:

Client Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.6-beta.0", GitCommit:"e7f962ba86f4ce7033828210ca3556393c377bcc", GitTreeState:"clean", BuildDate:"2020-01-15T08:26:26Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"17+", GitVersion:"v1.17.1+9d33dd3", GitCommit:"9d33dd3", GitTreeState:"clean", BuildDate:"2020-06-21T18:17:38Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}

Tekton Pipeline version:

Client version: 0.9.0
Pipeline version: v0.11.3

Does this happen because of resources: {} ?  Does it stop happening if you remove that line?

Does this happen because of resources: {} ? Does it stop happening if you remove that line?

No sadly enough not. When leaving this empty it still creates resources:{}
When I create the task with tkn task create -f java-gradle-test-task.yml it adds this automatically.

hey @grebit !  a couple things:

Like @ImJasonH was pointing out, i dont think steps have a "resources" field
in v1beta1, there is no "inputs" section
if you still have trouble, is it possible to see what the created taskrun looks like? if you are using tkn to create it, i wonder if tkn is not realizing you need the resources since the inputs.params/inputs.resources sections are in v1alpha1 format

Like @ImJasonH was pointing out, i dont think steps have a "resources" field

Steps do have a resources: field, to configure the amount of CPU/RAM resources to request/limit each step to.
I didn't realize until this comment that the Task indeed does specify inputs which isn't valid in v1beta1. That's likely the cause of the error, though it seems like we could use a better error message in that case 🤔

Like @ImJasonH was pointing out, i dont think steps have a "resources" field

Steps do have a resources: field, to configure the amount of CPU/RAM resources to request/limit each step to.
I didn't realize until this comment that the Task indeed does specify inputs which isn't valid in v1beta1. That's likely the cause of the error, though it seems like we could use a better error message in that case 🤔

But looking at this, it's the same setup right? Or are I'm looking wrong?
# Task.yaml (v1beta1)
spec:
  resources:
    inputs:
    - name: src-repo
      type: git
    outputs:
    - name: baked-image
      type: image

This is by the way the result of the taskrun:
status:
  completionTime: '2020-09-16T14:37:53Z'
  conditions:
    - lastTransitionTime: '2020-09-16T14:37:53Z'
      message: build failed for unspecified reasons.
      reason: Failed
      status: 'False'
      type: Succeeded

@grebit there is a few things:

tkn is 0.9.0. I am not sure if that version of tkn asked interactively for resources to bind or not. Does it ? If it doesn't ask for anything when you issue tkn task start …, then you either need to specify the resource manually or upgrade you tkn version (0.12.1 is the latest as of today) to have this interactiveness.
The task yaml specified shouldn't be accepted at all by the webhook, it's not a valid v1beta1 object.

cc @piyush-garg @pradeepitm12 @danielhelfand on this (for tkn version, interactive and all)

Hey again @grebit !
Echoing what @vdemeester pointed out, I'm not sure how to repro this b/c like he said:

The task yaml specified shouldn't be accepted at all by the webhook, it's not a valid v1beta1 object.

I tried to reproduce it with this task definition (slightly different from yours above but I think the same in the important areas):
apiVersion: tekton.dev/v1beta1
kind: Task
metadata:
  name: repro-resources
spec:
  inputs:
    resources:
      - name: source
        type: git
    params:
      - name: gradle-image
        type: string
        default: 'gradle:jdk8'
      - name: pathToContext
        type: string
        default: /workspace/source
  stepTemplate:
    env:
      - name: GRADLE_USER_HOME
        value: $(inputs.resources.source.path)
  steps:
    - args:
        - '-c'
        - |
          echo "hello $(params.gradle-image) $(params.pathToContext) $GRADLE_USER_HOME"
      command:
        - /bin/sh
      image: busybox
      name: test
      resources: {}
      workingDir: $(inputs.resources.source.path)

I tried this with both the current HEAD commit (6d8f4513213a0a85f5164e0ed13b8a15c1839f89) and I tried v0.11.3 and both times I got:
Error from server (BadRequest): error when creating "foo.yaml": admission webhook "webhook.pipeline.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "inputs"

I tried changing it to v1alpha1:
apiVersion: tekton.dev/v1alpha1
kind: Task
metadata:
  name: repro-resources
spec:
  inputs:
    resources:
      - name: source
        type: git
    params:
      - name: gradle-image
        type: string
        default: 'gradle:jdk8'
      - name: pathToContext
        type: string
        default: /workspace/source
  stepTemplate:
    env:
      - name: GRADLE_USER_HOME
        value: $(inputs.resources.source.path)
  steps:
    - args:
        - '-c'
        - |
          echo "hello $(params.gradle-image) $(params.pathToContext) $GRADLE_USER_HOME"
      command:
        - /bin/sh
      image: busybox
      name: test
      resources: {}
      workingDir: $(inputs.resources.source.path)

And I was able to run it successfully:
tkn task start repro-resources --showlog
? Choose the git resource to use for source: repro-git (https://github.com/tektoncd/pipeline.git)
? Value for param `gradle-image` of type `string`? (Default is `gradle:jdk8`) foo-bar
? Value for param `pathToContext` of type `string`? (Default is `/workspace/source`) /workspace/source

I got the logs:
[test] hello foo-bar /workspace/source /workspace/source

I'm using a newer version of tkn (built from source maybe a month ago?) tho.
Do you have any more info on how we can repro this @grebit ?


Night mode

I made the night mode with gratitude.
Kelvin is red for small values and blue for large values.
Usually, it is slightly red.

Nobuhiro Takasaki wrote:

I made the night mode with gratitude.
Kelvin is red for small values and blue for large values.
Usually, it is slightly red.

What does this do that can't be done with a colorscheme?
--
hundred-and-one symptoms of being an internet addict:
151. You find yourself engaged to someone you've never actually met,
except through e-mail.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

The color of ':terminal' also changes. This is not possible with colorscheme.
I have an eye disorder and it is difficult to keep looking at the normal colored screen.

I want to contribute a little more to Vim.

Codecov Report

Merging #4185 into master will increase coverage by 0.01%.
The diff coverage is 71.15%.

@@            Coverage Diff             @@
##           master    #4185      +/-   ##
==========================================
+ Coverage   79.32%   79.34%   +0.01%
==========================================
  Files         105      105
  Lines      141288   141309      +21
==========================================
+ Hits       112083   112127      +44
+ Misses      29205    29182      -23

Impacted Files
Coverage Δ

src/terminal.c
78.88% <0%> (-0.19%)
:arrow_down:

src/option.c
85.8% <100%> (+0.01%)
:arrow_up:

src/syntax.c
79% <91.89%> (+0.09%)
:arrow_up:

src/gui.c
58.25% <0%> (-0.26%)
:arrow_down:

src/sign.c
93.38% <0%> (-0.13%)
:arrow_down:

src/version.c
88.93% <0%> (ø)
:arrow_up:

src/ex_getln.c
77.48% <0%> (+0.03%)
:arrow_up:

src/channel.c
83.42% <0%> (+0.07%)
:arrow_up:

src/screen.c
80.51% <0%> (+0.12%)
:arrow_up:

src/if_xcmdsrv.c
84.02% <0%> (+0.35%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2912abb...5847e0e. Read the comment docs.

Nobuhiro Takasaki wrote:

The color of ':terminal' also changes. This is not possible with colorscheme.
I have an eye disorder and it is difficult to keep looking at the
normal colored screen.

Well, what runs in a terminal window should work the same as it does in
the terminal run by itself.  Are you using Vim as a way to adjust the
terminal colors?  Perhaps this can be done by the terminal itself.  That
is a more generic solution than trying to do this with Vim.
--
hundred-and-one symptoms of being an internet addict:
156. You forget your friend's name but not her e-mail address.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I found the problem with the VTP implementation and sent a fix.
Since I knew the existence of :highlight Terminal, I implemented it there.

I was wrong. It was already supported. Oh…
For now, I will refocus on this.

There is no addition.
If a defect is found in the function, fix it.
My eyes are less tired.
The time I can write code has been extended.
I think it would be useful to someone else.

Make up what is missing and resubmit. Thank you very much.

This feature was also included in Windows 10. Close quietly.


Replace mutable default arguments with None

Using mutable types (e.g. [], {}) for default arguments can lead to unexpected behaviour as detailed here.
I have done my best to locate all the occurances within the repository however some may still remain through various searches including =[]):, ={}):, =[],, ={},.
Replacements should follow as such:
# Function with mutable argument as default
def func(self, var=[]):

# Should become
def func(self, var=None):
    if var is None:
        var = []

This fixes https://github.com/keras-rl/keras-rl/issues/309

Rebased to master.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-24-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1838

Questions ?
Please refer to the Backport tool documentation


Support RGB in imshow

I would like to work on this one : )

You're welcome to it - thanks Parsa!

Deps on #311
https://gist.github.com/qti3e/f516ad5c597e811971d0443b3261a151

It should be closed : )


prevent CSI driver from being evicted

Without any resource specifications, the CSI driver pod is among the first that gets evicted when resources are running low on a node. I was filling up /var by pulling a large image on host-1 of the QEMU virtual cluster and the result was:
pmem-csi-node-testing-dml4m               0/1     Evicted   0          2m4s    <none>        host-1   <none>           <none>
pmem-csi-node-testing-fn86q               1/1     Running   0          74m     <IP_ADDRESS>   host-3   <none>           <none>
pmem-csi-node-testing-pz64d               1/1     Running   0          74m     <IP_ADDRESS>   host-2   <none>           <none>
pmem-csi-node-w56mn                       0/2     Evicted   0          4m15s   <none>        host-1   <none>           <none>
...

I did not catch the description, but some other evicted pod had this event:
 Warning  Evicted    6m28s  kubelet, host-1    The node was low on resource: ephemeral-storage. Container .... was using 52Ki, which exceeds its request of 0.

We need to ensure that we properly declare the resource usage of our containers, including all sidecars.

The other evicted pod was rfs-redisfailover-pmem-75d4b4d856-2qwzf, from the spotahome redis operator. That operator also needs to be fixed to create pods with resource settings.


Related Resources is only displaying 4 URLS on Dev Site

Bug
Related Resources is only displaying 4 URLS on Dev Site

Steps to Reproduce

go to a page like this.
look at resources in the right rail, see only 4 links,
view the front matter of the page
Notice that 4 URLS are set to be static resources.
This means 1 resources should be populating in the right rail.
Notice that the label of a resource does appear but the link doesn't 🤔

Expected
related resources documentation

up to 5 resources should appear in the right rail.
If static URLS are set in the front matter, they'd take priority.
Then we should be backfiling the remaining URLs with those populated by swiftype

It looks like this may be only occurring on links to the developer site that are related resources.

Here's another great example https://developer.newrelic.com/build-apps/add-nerdgraphquery-guide
The tags show up for all 5 links, but the links themselves are missing.

been doing some very simple local testing & verification.
for develop & main, with and without a production build, i see the following when running locally for the two pages mentioned above:

@nr-kkenney to confirm locally this is working for you?

my intent was not to say thats its working, just providing what i saw when running locally.

i just ran it locally on develop both with gatsby develop and gatsby serve, no issues. ran it on main (after a cache clean) and reproduced the issue locally, so i'm starting to dig in

FYI, local and prod might have slightly different data depending on whether main has been merged into develop. Running locally, you're subject to whatever is in related-pages.json. The nightly job that refetches all the of data commits directly to main.
Just wanted you to be aware of this in case you're wondering why the data is different 😄

swiftype results are coming back with an empty title whenever the page is from a /embed url. the embed layout doesn't include seo and has no title set. we don't want these pages indexed in the first place so i'm going to adjust the indexing rules by adding /embed to the block list (where we also exclude urls that include /404)

a little trial and error but the /embed pages are now excluded from being indexed and there are no longer title-less related resources for developer 🎊


Is it possible for it to perform on an existing piece?

Is it possible for it to perform on an existing piece?  I don't see on the documentation how to "feed it" sheet music.

Which model are you referring to? Please reopen with the answer.


?OverrideOfficialDifficulty=5.0 issue

The newish option to override the difficulty setting (?OverrideOfficialDifficulty=5.0) has had us perplexed.  What's the syntax and where does it go?
We've tried it several different ways with no effect.

it works well for me this is the steps you need to do

go to the instance or the config of the arkmanager
the setting you want to place is ark_OverrideOfficialDifficulty=40.0 where 40 is the difficulty you want to use.
Next thing to do is to make sure you destroy all wild dinos and boom your good that's it.

@Flukethoughts
Dear god you are the best ever, i did not even notice you can put this option like this in arkmanager.
Now i can use this on my multiple servers so i have the same lvl no matter what changes on ark !
Is this still correct for the island and the center ?
4.0 = 120 LVL WILD
5.0 = 150 LVL WILD
6.0 = 180 LVL WILD


Fix get_execution_info syscall

The get_execution_info syscall should:

Hold an execution_info_ptr that holds a reference to the execution_info segment created by the first call to the get_execution_info syscall, and use it on every following call instead of writting all the information at each call
Write the execution_info on read-only segments, so that they are not counted as memory holes if not accessed

This PR fixes the the get_execution_info behaviour to match the one described above, fixing memory hole mistatches such as #1079
Checklist

[x] Linked to Github Issue
[ ] Unit tests added
[x] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report

Merging #1081 (e5670b9) into main (8ed7fb7) will decrease coverage by 0.02%.
The diff coverage is 95.91%.

:exclamation: Current head e5670b9 differs from pull request most recent head 846acdc. Consider uploading reports for the commit 846acdc to get more accurate results

@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
- Coverage   89.76%   89.74%   -0.02%
==========================================
  Files          49       49
  Lines       13040    13037       -3
==========================================
- Hits        11705    11700       -5
- Misses       1335     1337       +2

Files
Coverage Δ

src/syscalls/business_logic_syscall_handler.rs
76.45% <95.91%> (-0.36%)
:arrow_down:


How to prevent documents from being searched？

How to prevent documents from being searched？~

It's possible to prevent documents from being searched by removing the search box in the navigation bar. Below is an example code for achieving this. In this code, we are passing an empty element to the option to replace the search box in theme.config from the Docs Theme Configuration, effectively disabling the search functionality.
import type { DocsThemeConfig } from "nextra-theme-docs";

const config: DocsThemeConfig = {
  search: {
    component: <></>,
  }
};

export default config;

I hope this helps! Let me know if you need any further assistance.

Thank you, what should I do if I just want a document not to be searched?

Specify a document.~


Issue with images and links

I am facing an issue with posts that contain multiple images attached. Such post media is not getting displayed on the channels.
Example: https://www.reddit.com/r/KeralaGW/s/fYys0BAJ7I
Another issue I am facing is RedGIFs links not getting embedded into channels.
Example: https://www.reddit.com/r/Cuckold/comments/1cbwxm7/theyre_nailing_us_so_hard_and_we_completely/
Feature suggestion: It would be great If we had an option to ignore the posts that contain specific flairs.

in https://github.com/topi314/Reddit-Discord-Bot/releases/tag/v2.0.0-beta.6 I added the option to use a reddit post proxy such as https://rxddit.com which can solve the issue of not embedding all images


[ElevenSports] Add Extractor

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

Eleven Sports is a multinational sports and entertainment media group. Headquartered in the United Kingdom, it is owned by DAZN Group, a subsidiary of Access Industries. Eleven Sports' business model initially centred around the acquisition of major international sports rights in smaller countries. Wikipedia
[debug] Loaded 1824 extractors
[ElevenSports] Extracting URL: https://elevensports.com/view/event/clf46yr3kenn80jgrqsjmwefk
[ElevenSports] clf46yr3kenn80jgrqsjmwefk: Downloading webpage
[ElevenSports] clf46yr3kenn80jgrqsjmwefk: Downloading JSON metadata
[ElevenSports] clf46yr3kenn80jgrqsjmwefk: Downloading m3u8 information
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] clf46yr3kenn80jgrqsjmwefk: Downloading 1 format(s): hls-6000
[info] Writing video metadata as JSON to: test_ElevenSports_clf46yr3kenn80jgrqsjmwefk.info.json
[debug] Loaded 1824 extractors
[ElevenSports] Extracting URL: https://elevensports.com/view/event/clhpyd53b06160jez74qhgkmf
[ElevenSports] clhpyd53b06160jez74qhgkmf: Downloading webpage
[ElevenSports] clhpyd53b06160jez74qhgkmf: Downloading JSON metadata
[ElevenSports] clhpyd53b06160jez74qhgkmf: Downloading m3u8 information
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] clhpyd53b06160jez74qhgkmf: Downloading 1 format(s): hls-3000
[info] Writing video metadata as JSON to: test_ElevenSports_1_clhpyd53b06160jez74qhgkmf.info.json
ok

----------------------------------------------------------------------
Ran 1 test in 9.944s

OK

Fixes #6737
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[x] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Copilot Summary

🤖 Generated by Copilot at 9312cc8
Summary
🆕📺🌐

Add new extractors for CRTVG and Eleven Sports websites. These extractors enable yt-dlp to download videos from these sources.

Oh we are the coders of the sea, me hearties
We write extractors for the videos we crave
We pull and push with yt-dlp, so smartly
And download from ElevenSports and CRTVG

Walkthrough

Add extractor for Eleven Sports website (elevensports.py, link, link)
Import ElevenSportsIE class in _extractors.py and register it in the _ALL_CLASSES list (link)
Import CrtvgIE class in _extractors.py and register it in the _ALL_CLASSES list (link)

check linter


Does Windows builds support il2cpp?

Looking at https://github.com/game-ci/unity-builder/pull/305 and the v2.0.0-alpha-14 release, it appears Windows builds should support il2cpp:
- Added build tests for windows il2cpp, WSAPlayer, and tvOS in build-test workflow

I just tried to build an app with il2cpp and it fails:
Asset Pipeline Refresh: Total: 0.266 seconds - Initiated by StopAssetImportingV2(NoUpdateAssetOptions)
DisplayProgressNotification: Build Failed
Error building Player: Currently selected scripting backend (IL2CPP) is not installed.
Unloading 51 Unused Serialized files (Serialized files now loaded: 0)
Unloading 57 unused Assets / (2.1 KB). Loaded Objects now: 9210.

It appears to be using unity-builder:windows-2021.2.8f1-windows-il2cpp-0
If I switch to mono, the CI works great and a working executable is produced.
Do I need to do something else to get il2cpp working?

There was a bug with the initial rollout of 0.17 images so I don't think the 2021 versions had the modules properly installed. It was sorted out mid deployment so 2020 images started getting the modules. Will need to wait for the next tag to be pushed for the images to be rebuilt with the modules unfortunately.

@AndrewKahr  - Thank you for the info. So you mean I can try again when we have something newer than editor-2021.2.8f1-0.17.0?

unity-builder:windows-2021.2.8f1-windows-il2cpp-0 should now be updated by v0.17.2
@jsm174 Are you able to get il2cpp working now?

Hello. I will check. Unfortunately my github actions quota is all used up until the end of the month. I wasn't thinking that mono builds I should just use ubuntu. And with macos being 10x minute multiplier..  arg...

Just wanted to follow up.  I was able to successfully make a windows il2cpp build of our app!

Awesome! Closing this issue.


Use GAID as Distinct ID for new users

Use GAID as Distinct ID for new users, also adding this as a super property and a people property. This PR uses delay to wait for the asynch GAID to return, and only then starts to process events and people updates requested on the main thread. Although this might not be a final solution due to the asycnh issues with getting the GAID, hopefully it can serve as inspiration for one.

Thanks for providing the PR. We will not use GAID on the SDK unfortunately.


Line break settings are not respected (Windows)

What version of Flyway are you using?
Flyway 4.0-4.0.3
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Command Line
What database are you using (type & version)?
MS SQL Server 12
What operating system are you using?
Windows 10
What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
I created the following sql script:
CREATE PROCEDURE CreatePriceData
AS
BEGIN
 PRINT 'Test'
END

with the settings UTF-8, Windows Line Endings (CR/LF) and named it V1_0__initial.sql.
Then I executed flyway: flyway migrate
What did you expect to see?
I expected flyway to recreate the stored procedure exactly as I specified it in the sql script file.
In my case this is essential since I want to use the Schema Compare Tool of Visual Studio to find any changes I made compared to a productive version of the database.
What did you see instead?
When I opened Microsoft SQL Server Management Studio and tried to modify the stored procedure there was an error box complaining about inconsistent line breaks and offering to repair it.
Since I am usually not doing any Java projects I do want to submit a pr, but I think I found the responsible line in the code:
flyway/flyway-core/src/main/java/org/flywaydb/core/internal/dbsupport/SqlStatementBuilder.java, line 178: statement.append("\n");
This should not use a hardcoded \n but

either the used line endings of the script file (preferrably)
make the used line endings configurable

I can provide more info or test changes if you need anything.

+1

This has now been fixed.


Replacing LoopVectorization

Hi there,
What with LoopVectorization.jl getting deprecated in Julia v1.11, are there any plans to replace it in this package? From what I've read the only path forward (while keeping performance) is to write efficient kernels ourselves.

It’s not clear that there’s any replacement forthcoming anywhere in the community. If there is we can try to port the implementations in this package to that, but currently the next best thing is @.*** @fastmath, which is what LoopVectoriztation falls back to anyways (so things should keep working here, and will still benefit for the<EMAIL_ADDRESS>functions for each dimensional case, just probably not quite as fast as they used to be)

I see, what do you think about explicitly replacing @turbo with @fastmath just to remove the dependency? (I might be able to find time for it if you think that's a good idea)

Eventually probably yes if no one resurrects LoopVectorization, but no rush I think

While it looks like we can't use @fastmath due to what that does to handling of NaNs, @simd ivdep for seems to work pretty well here
Closed by #48


Enable CLI to read and convert raw image data files

Summary
To make the CID CLI more flexible we want to enable our users (and our automation) to read raw image data files as provided by the cloud provider and output formatted image data according to our schema standard.
Expected outcome

A flag needs to be added to the CLI tool (--file /-f) that accepts a path to a raw data file.
The CLI needs to be able to read the image data and apply the existing image format routine as needed.
Add necessary test cases.

Hints
This will involve a lot of code changes. Ideally a PR for each cloud provider should be created.
Acceptance Criteria

The CLI tool can generate formatted image data from raw data files.
The CLI can still generate formatted image data from cloud provider live data.

This task might take more time than we have for this milestone. Let's move it to March.


Improved UI for profile page  #1448

This pull request enhances the user profile page with the following improvements:

-Profile Completion Progress Bar:
Added a visual progress bar to indicate profile completion.
New CSS styles for .progress-container, .progress-bar, and .progress.
-Tabbed Content:
Implemented a tabbed interface with "About", "Badges", and "Activity" sections.
Added styles for .tab, .tablinks, and .tabcontent, along with JavaScript for tab switching.
-Reorganized Content:
Moved "About", "Badges", and "Activity" into separate tabs, improving organization and reducing scrolling.
-Styling Improvements:
Updated styles for the badges section and adjusted existing styles for the new layout.
-Responsive Design:
Ensured all elements are responsive for smaller screens.
These changes aim to create a more organized and interactive profile page, enhancing the overall user experience.
Let me know if further adjustments are needed.

@kashish8001 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. You can also contribute in my another Repository BuddyTrail which is also under Hacktoberfest
Great contribution to HACKTOBERFEST'24! 🎉


[Bug] WhatsApp map crash

Seen this bug on Android 4.4 and 9.0. For reproduce this bug try expand map, found yourself and tapping on random places around.
Logcat: https://pastebin.com/raw/Xfh38Fy2

WhatsApp crashing after close map activity
Log: https://del.dog/tikadyfifu.txt


Setup GitHub Actions to run system tests

As seen in action here: https://github.com/tswast/ibis-bigquery/pull/1/checks
The trick is to use pull_request_target, which has access to secrets, but only allow it to run when the run-ci label is added. This workflow is described here: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
Note: While the tests are running, they are not all passing. It's going to take some more work to get this repo to a healthy state. Also, I'm installing ibis from source, which we do want to be doing, but we'll probably want some tests against the released version of ibis as well.

Looks good, nice clean up. I didn't realize I named the module ibis-bigquery, thanks for fixing it.


[Android][SDK] Implement Native Deep Linking for signing

In three word: port TrustSDK-iOS into Android, use best practices.
Original repo: https://github.com/TrustWallet/TrustSDK-iOS
We need to port iOS implementation of TrustSDK-iOS into Android (should be written in Kotlin)
TrustSDK allows any application to sign transactions and message via Trust app.
Let's assume you would like to sign hey Viktor.

You would call trustSDK.signMessage("hey Viktor"),
Check if Trust app installed: trust://, then it would call trust://sign-message?message=base64("hey Viktor")
Confirm message in the Trust App and return signed message to the requester app.

Implementation on the the side of the wallet: https://github.com/TrustWallet/trust-wallet-ios/blob/master/Trust/Core/Coordinators/LocalSchemeCoordinator.swift
Contact me: @vikmeup on telegram or discord: trustwalletapp.com/discord
Demo iOS:
Signing message:

Signing transaction:

Just to calm the @gitcoinbot down - there's a PR in progress. I should have probably mentioned this issue in one of the commits to make it relevant.


credit card

credit card adding system not work

fixed in https://github.com/hackirby/discord-injection/commit/a653df7398dc1bd5361d784a055273ec1364fcf6


Error parsing triggers: Cannot find module '@custom-path'

Operating System version: win10
Firebase SDK version: latest
Firebase Product: all

I'm trying to use Path Mapping for Cloud Functions but when I use a custom path like import * as b from '@custom-path/barrel' I get an error on tslint for implicit imports. If I disable this rule and try to deploy, I get the following error:

Error parsing triggers: Cannot find module '@custom-path'

Code example:
 "baseUrl": "../",
    "paths": {
      "@be-utils/*": ["functions/src/utils/*"],
    }

Tried this as well:
"baseUrl": ".",
  "paths": {
    "@custom-path/*": ["src/utils/*"],
    "@other-path/*": ["../other/path/*"]
  }

Am I doing something wrong?
If not, how can I use path mapping with Cloud Functions? Thanks.
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.

Please use stackoverflow or the Google group for usage questions such as this.

Ok I give up. I can't get help on this anywhere, thanks

Did you ever figure it out? I have the same issue and it was working before.


Misc org update

Description
Updated references to Kitura GitHub organization.

Motivation and Context

How Has This Been Tested?

Checklist:

[x] I have submitted a CLA form
[x] If applicable, I have updated the documentation accordingly.
[ ] If applicable, I have added tests to cover my changes.

I can't re-run the Travis jobs, but it all looks fine to me.