source code about ex17.3

I try to change the file constructor of chapter 17 , but when I see the directory of ex17.3 , I find that the source code is not complete ! It lacks a header file !
Now I will let it alone ! And I will comment it in the makefile !

I added #include into it, please try again.

Another question about '#include "queryresult.h" '!
where is the queryresult.h file ????
I can't find it in the repo!

Then ..just leave it alone.

leave it alone ???? I don't understand!

I mean.. I don't know as well..

OK! When I read the book about this question I will try to complete it !


Add support for diameter information in uvfits files for HERA

from Chris Carilli -- apparently CASA assumes a 25 m dish unless there's a diameter information in the uvfits antenna table. That should be easy to add, waiting on an example file from Chris to see what the implementation should look like.

This branch should ensure that the antenna diameter column appears in uvfits files if the file read in has the telescope name set to 'HERA'. Do our current data files have that set properly? @dannyjacobs @adampbeardsley

Done in PR #208


Add digital garden (/notes)

Adds a Digital Garden notes page to my website. Check it out! https://jmulholland.com/notes

Deploy preview for james ready!
Built with commit f2011ba4c2e32cbdffd93c491b8f58f2415b813a
https://deploy-preview-106--james.netlify.app


What is the license type?

Summary of the suggested change
Add license type to the repo
Link(s) to the documents to be changed
N/A
Links to relevant resources
https://choosealicense.com/licenses/
When you are finished:

If this is an update to the Readme or Contributing.md, PR this into development.
If this is an update to the Wiki, @ a maintainer so they can review your changes.

If you're interested in working on this feature, please comment so you can be assigned

Done!


Set alert email to user still use old template

The code https://github.com/microsoft/pai/blob/bf41920d6d7319e310760df5b9ad1bb4a1531241/src/alert-manager/src/alert-handler/controllers/mail.js#L156
Seems should change to
const template = req.query.template

Fixed in #5113


Add support for cargo-dinghy

Closes #132

cargo-dinghy's archive seems to be an archive of a directory containing binary, so perhaps bin field (example) is needed.

Fixed!

LGTM. Could you add cargo-dinghy to the following tool lists?
https://github.com/taiki-e/install-action/blob/7bda3b1d5e4f0b183b453259c3b03dcfa68c6be2/.github/workflows/ci.yml#L44-L47
https://github.com/taiki-e/install-action/blob/7bda3b1d5e4f0b183b453259c3b03dcfa68c6be2/.github/workflows/ci.yml#L105-L107

Published in 2.11.0.


Bug in events.

When every component (Tooltip, Popover, Modal etc) was created some times handlers will be from first component. It`s incorrect and will have memory leak because handlers will have link on other (first) component.
Example:
var modal = new Modal(el, options1);
modal = new Modal(el, options2);

Is it bug?
if ( !(stringAffix in element ) ) { // prevent adding event handlers twice
      on( globalObject, scrollEvent, self[update] );
      !isIE8 && on( globalObject, resizeEvent, self[update] );
}

if ( !(stringAlert in element ) ) { // prevent adding event handlers twice
      on(element, clickEvent, clickHandler);
}

if ( !( stringButton in element ) ) { // prevent adding event handlers twice
        on( element, clickEvent, toggle );
        queryElement('['+tabindex+']',element) && on( element, keyupEvent, keyHandler ),
                                                  on( element, keydownEvent, preventScroll );
}

etc

Well to me it makes no sense to initialize same component for same element twice, but I understand what you're trying to say, might be a memory leak although I never had any issues with the versions 2.0.0 and above.
Lately I was working on ways to export handlers to global objects' events (DOCUMENT, WINDOW) and I think I have a good idea on how to improve future versions, it's gonna require a lot of effort to change all that.

User can initialize it twice: one by default and write some code for initialization.

How about this:
// options
var options1 = {
  interval: 5500,
  pause: 'hover'
};

var options2 = {
  interval: false,
  pause: false
};

// init
var myCarouselInit = new Carousel ('#myCarousel', options1);

// change options
myCarouselInit.interval = options2.interval;
myCarouselInit.pause = options2.pause;

Now the only issue with this particular component is when the change involves changing the content by adding/removing new/existing content items, a case where I would do something like this:
// init
var myCarouselInit = new Carousel ('#myCarousel', options1);

// change occurs
var myCarousel = document.getElementById('myCarousel');
// remove second content item
myCarousel.removeChild(myCarousel.querySelectorAll('.item')[1]);
// remove second content item's navigation
myCarousel.removeChild(myCarousel.querySelectorAll('[data-slide-to]')[1]);

// "destroy" the initial init
myCarousel.Carousel = null; // we keep this so we don't re-add events
myCarouselInit = null;

// re-init with new options and contents
 var myCarouselInit2 = new Carousel ('#myCarousel', options2);

What do you think, will you give this a try?

I know that user can change some properties but he need read source for it.
If you change logic of your bootstrap component then user must be change his source.
My opinion: user should use your components like black box with public methods without read source and searching events and changeable properties.

IMO: you like the script, you read docs and start implementing it. That's what Bootstrap original plugin developers expect from you too, not just me.
I never heard someone complain the events of our components are incorrect when it comes to init + change/destroy + re-init, mostly later added elements, but if someone comes with a good argument, I will have no problem taking the time to try to improve the components.
As a matter of fact, I've considered making a destroy() method either for global use or component specific, but this was a practice mostly for legacy browsers, so since now modern browsers have some very smart garbage collection and memory cleanup capability (I've done extensive research on the matter for my KUTE.js library), I decided not to implement them.
Once you remove an element from the document, all associated events and objects/instances are garbage collected, so the use of a destroy() method is really not needed anymore.
I will close this for now, I believe my arguments are on everyone else's mind.

I can confirm v4 Carousel leaks memory (checking with Chromium Task Manager)

We're open to any suggestions on how to improve the code.

@nicola-spb please have a test at the master, enjoy :)


Publish version 2.2 to npm

Thanks for the awesome project! Can yoy publish 2.2 to npm.
$ npm view node-opus

{ name: 'node-opus',
  description: 'NodeJS native binding to OPUS',
  'dist-tags': { latest: '0.2.1' },
  versions:
   [ '0.1.0',
     '0.1.1',
     '0.1.2',
     '0.1.3',
     '0.1.4',
     '0.1.5',
     '0.1.6',
     '0.1.7',
     '0.1.8',
     '0.1.9',
     '0.1.10',
     '0.1.11',
     '0.1.12',
     '0.1.13',
     '0.2.0',
     '0.2.1' ],
  maintainers: [ 'rantanen<EMAIL_ADDRESS>],
  time:
   { modified: '2016-06-27T14:15:55.331Z',
     created: '2015-04-27T19:12:13.858Z',
     '0.1.0': '2015-04-27T19:12:13.858Z',
     '0.1.1': '2015-04-28T18:19:14.595Z',
     '0.1.2': '2015-04-28T20:54:34.206Z',
     '0.1.3': '2015-05-06T19:43:32.614Z',
     '0.1.4': '2015-05-06T21:01:27.903Z',
     '0.1.5': '2015-05-15T13:34:10.095Z',
     '0.1.6': '2015-05-19T20:51:38.050Z',
     '0.1.7': '2015-05-19T22:07:05.949Z',
     '0.1.8': '2015-05-19T22:12:55.829Z',
     '0.1.9': '2015-05-20T00:32:33.163Z',
     '0.1.10': '2015-07-06T14:44:34.278Z',
     '0.1.11': '2015-09-29T22:49:17.720Z',
     '0.1.12': '2016-01-23T14:05:42.642Z',
     '0.1.13': '2016-04-30T21:57:45.352Z',
     '0.2.0': '2016-06-05T21:15:26.562Z',
     '0.2.1': '2016-06-27T14:15:55.331Z' },
  //...

Oops. I had a feeling I had forgot to do that to one of my modules, but couldn't remember which one.
Thanks for finding it! Published now!


detect and auto-suggest to update to latest ZS version

-detect if ZS is running an older version
-through some UI element (e.g. toast etc) ask if user wants to update to latest ZS version from current version

related: #75

I was testing an older ZS version, and I didnt realize it

Will add a one-time toast when a new zap.store version is available. If dismissed, it won't show up again and user can update app like any other (via the updates screen)

Fixed a few commits ago


example_scripts-Different C rates

When the case of different C rates in example_scripts is running, no parameters are changed. Why are the cut-off voltages obtained by three different ratios not about 2.5V, but between 3.1, which can't match the data of journal papers? Why?

hello
I am a student.I think your team is good for this work,but Ineed help recently.
When the case of different C rates in example_scripts is running, no parameters are changed. Why are the cut-off voltages obtained by three different ratios not about 2.5V, but between 3.1, which can't match the data of journal papers(figures of paper are 2.5V)? Why?

Hello. The simulation you are running assumes thermal dynamics enabled. Try to disable them and re run the simulation. That should drive the 2.5V simulation fine.

Hello, I'm sorry to bother you again.
I tried to turn off the thermodynamic model again, the result is still not like the paper, I also tried to adjust the other models to enable and close, still can't achieve the effect in the paper, the result trend is right, but the discharge cut-off voltage is never up to 2.5V, including other cases, and the data results in the paper can not be well matched, I hope you can help me answer. If you can, I'd love if you can provide me with the source code of the case in the paper, and I'd like to try to run it and see if it matches the data in the journal. This is used to deduce the problem.

example_scripts:CarCycling_example2

https://iopscience.iop.org/article/10.1149/2.0291607jes

Since it's very initial release, the code has been undergoing refactoring and some of the parameters may have been updated, or new equations introduced. While the code should have kept the backward compatibility, it may be that some of the default values for some of the parameters, or type of model approximations of some equations, changed. My suggestion is to checkout an older version of the framework (either 2.0 or 1.024) and use that as reference.


OSIDB-3137: Allow multiple user saved searches

OSIDB-3137: Allow multiple user saved searches
Checklist:

[x] Commits consolidated
[x] Changelog updated
[x] Test cases added/updated
[x] Jira ticket updated

Summary:
Adds logic and UI adjustments to support multiple user saved searches.
Changes:

Updates searchStore to handle an array of searches
Updates advance search components logic and UI to support loading, editing and removing saved searches
Updates index view to display a list of saved searches
Reduces initial query textarea height to be same as other input elements (still resizable)
Adds support to set one saved search as favorite/default, so it is directly used on the issue queue of the index view
Allows keeping draft advance search values so when deselecting a loaded saved search the previous 'non saved' search remains the same
Blocks text selection on summary elements
Changes naming of 'filters' to 'searches' for everything referencing to user saved searches
Some code cleanup
Updates snapshots
Update and adds new test cases

Demo
https://github.com/user-attachments/assets/f3c17aa0-f42b-4074-a0aa-811455ecb43c
*Update: Properly display saved searches when too many saved

Closes OSIDB-3554
Closes OSIDB-3555
Closes OSIDB-3556
Closes OSIDB-3137

Update: Commits squashed for reduced noise and better organization


SearchBar don't work in some profile tabs

It looks like searchbar don't really work in collected & sold tabs from /rmrk/u/{id}

Tested on deepologic profile.
Searched "mask" with "Buy now" filter

Screenshot

I will take this


5098 branch 8 update invalid block params

PR description
Update code to use RpcErrorType.INVALID_BLOCK_PARAMS
Fixed Issue(s)

https://github.com/hyperledger/besu/issues/5098

@Matilda-Clerke I think the unit test failures are legit - can you take a look?


Triangle curation interface

Given that the Biomappings website identifies and lists incomplete triangles, it might make sense to create a new curation interface that just focuses on resolving these

Alternatively, we could include these as predictions with an appropriate method string and curate them using the existing UI.


getting an error event instead of a response event

Short version is that I am trying to create a client (master) to read holding registers on a server (slave) via modbus. I am getting the following error event: Error: connect ECONNREFUSED
at errnoException (net.js:776:11)
at Object.afterConnect [as oncomplete] (net.js:767:19).
Long version is here:
http://stackoverflow.com/questions/18989638/node-modbus-stack-econnrefused
any guidance would be appreciated, I am kind of new to this area of development.

I am the beginner on Node.js. May I have a complete example of the modbus master (client)?


failure when finalize response does not include Location header

RFC 8555 example finalize (success) response includes a Location header containing the URL of the order resource.  But the RFC does not state that this header is required, and intuitively it is not required, because the context of having POSTed to the finalize resource implies that the order URI is (or was at some point) known, and furthermore the order data in the finalize response contains the URI to the certificate resource.
Nevertheless, mod_md fails when the ACME server does not include a Location header in the finalize response.  This is no doubt an artifact of the older (pre-RFC draft) protocol where the Location header pointed to the issued certificate.
Other clients (well, Certbot at least), work fine when the finalize response does not include a Location header.
Expected behaviour: when speaking ACME v2, mod_md should not require the Location header in the response.

I believe I've seen this as well, but it's masked by some other issues I've been chasing with non-Boulder servers.
Is there an open server with this behavior that we can test against?

@tlhackque no open server that I know of.  I can see about setting one up.


Add gitignore

Type
enhancement

Description

Translated a comment in the Assembly Info file from Portuguese to English.
Added a new Visual Studio solution file with configurations.
Updated project paths, NuGet configurations, and added new dependencies.
Simplified XML structures in NuGet properties and targets files.
Updated project assets with new .xml related files and configurations.

Changes walkthrough
Relevant filesEnhancement

example-csharp-api-tef.AssemblyInfo.csTranslate Assembly Info Comment to English

obj/Debug/netcoreapp3.1/example-csharp-api-tef.AssemblyInfo.cs

Comment translation from Portuguese to English.

+1/-1

aditum-api-tef-csharp-example.slnAdd New Visual Studio Solution File

aditum-api-tef-csharp-example.sln
Added a new Visual Studio solution file with configuration for Debug and Release modes.

+25/-0

example-csharp-api-tef.csproj.nuget.g.targetsSimplify NuGet Targets File

obj/example-csharp-api-tef.csproj.nuget.g.targets

Simplified the XML structure by removing unused property groups.

+1/-5

Configuration changes

example-csharp-api-tef.csproj.nuget.dgspec.jsonUpdate NuGet Configuration and Project Paths

obj/example-csharp-api-tef.csproj.nuget.dgspec.json
Updated project paths and NuGet configuration.  Added targetAlias and downloadDependencies for .NET Core 3.1.  Updated runtimeIdentifierGraphPath to .NET SDK 6.0.418.

+19/-9

example-csharp-api-tef.csproj.nuget.g.propsUpdate NuGet Properties Configuration

obj/example-csharp-api-tef.csproj.nuget.g.props
Updated NuGet package folders path and tool version.  Simplified property group structure.

+3/-6

project.assets.jsonUpdate Project Assets and NuGet Configuration

obj/project.assets.json
Added .xml related files for Newtonsoft.Json.dll.  Updated package folders, project paths, and NuGet configuration.  Introduced targetAlias, downloadDependencies, and updated runtimeIdentifierGraphPath.

+24/-10

project.nuget.cacheUpdate NuGet Cache Configuration

obj/project.nuget.cache
Updated the dgSpecHash and project file path.  Added new package file for Microsoft.NETCore.App.Host.win-x64.

+4/-3

 ✨ Usage guide:
Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:
/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:
[pr_description]
some_config1=...
some_config2=...

  Enabling\disabling automation

When you first install the app, the default mode for the describe tool is:

pr_commands = ["/describe --pr_description.add_original_user_description=true"
                         "--pr_description.keep_original_user_title=true", ...]

meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.

Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:

pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

type: the PR type.
summary: the PR summary.
walkthrough: the PR walkthrough.

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

  Custom labels
The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].
If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

Main topic:performance - pr_agent:The main topic of this PR is performance
New endpoint - pr_agent:A new endpoint was added in this PR
SQL query - pr_agent:A new SQL query was added in this PR
Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

  Inline File Walkthrough 💎
For enhanced user experience, the describe tool can add file summaries directly to the "Files changed" tab in the PR page.
This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set pr_description.inline_file_summary in the configuration file, possible values are:

'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.
true: A collapsable file comment with changes title and a changes summary for each file in the PR.
false (default): File changes walkthrough will be added only to the "Conversation" tab.

  Utilizing extra instructions
The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
[pr_description]
extra_instructions="""
- The PR title should be in the format: '<PR type>: <title>'
- The title should be short and concise (up to 10 words)
- ...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

/review


Make CLI tool smarter

Currently, this cool reads lines in projects and matches strings to a list of guarded words. It will always throw a warning if the guarded word exists in a project. Make this tool 'smarter' by detecting whether the value of a key or password is actually exposed in the project before throwing a warning

check entropy


Fix #6234 : Check organization visibility before everything else

Fixing #6235

Hmm... I think we need to formally specify what the authorisation and permission regime should be. We're getting a lot of these little fixes and although I don't think they're ending up inconsistent, I suspect edge cases are likely to be missed and we may end up with security holes.

I hope I get it right.
Having a well defined permission model would be nice - for example, it's not clear for me, if having public repositories in a private organization would make any sense. But an organization can freely switch between it's visibility settings, their repository should behave consistently after switching back and forth.

Codecov Report

Merging #6235 into master will decrease coverage by <.01%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master    #6235      +/-   ##
==========================================
- Coverage   38.86%   38.85%   -0.01%
==========================================
  Files         354      354
  Lines       50223    50232       +9
==========================================
+ Hits        19517    19520       +3
- Misses      27879    27882       +3
- Partials     2827     2830       +3

Impacted Files
Coverage Δ

modules/context/repo.go
58.4% <11.11%> (-0.89%)
:arrow_down:

models/unit.go
14.28% <0%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 141c58f...7350e35. Read the comment docs.

I like @zeripath 's idea. I think maybe someone could add that on the docs.

But that's for another PR. @zeripath please review again.


reserved identifier violation

I would like to point out that identifiers like “_Brush” and “_Font” do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

Thanks for your suggestion.

This issue is moved to #5

Because it is very big codebase, the reserved name issue will be fixed gradually. Instead I've opened new issue #5

There are still more update candidates to consider.

I've pushed remaining updates.

Thanks for another source code improvement.


native image error CommandLine$InitializationException: CommandLine$AutoHelpMixin@74101cef is not a command

Created new ticket from @zipper01's below comment on #631:
Same here. Code:
import java.awt.GraphicsEnvironment;
import java.awt.HeadlessException;
import java.util.concurrent.Callable;
import picocli.CommandLine;
import picocli.CommandLine.Command;
import picocli.CommandLine.Option;
import com.myapp.util.SYS;

@Command(name = "myapp", mixinStandardHelpOptions = true, description = "MyApp", version = "1.0")
public class Main implements Callable<Integer> {

    //comman-line option to set tui mode under gui environment
    @Option(names = "--tui", description = "Use Text User Interface")
    boolean _tui;

    //command-line option to turn debug on
    @Option(names = "--debug", description = "Turn On Debug")
    boolean _debug;

    public static boolean supportGUI;

    static {
        try {
            supportGUI = !GraphicsEnvironment.isHeadless()
                    && GraphicsEnvironment.getLocalGraphicsEnvironment().getScreenDevices().length > 0;
        } catch (HeadlessException | java.lang.UnsatisfiedLinkError e) {
            supportGUI = false;
        }
    }

    @Override
    public Integer call() {
        //set debug
        if (_debug) {
            SYS.DBG_LEVEL = 2;
        }

        //set user interface
        if (supportGUI && _tui) {
            supportGUI = false;
        }

        if (supportGUI) {
            //Init GUI ...
        } else {
            //Init TUI ...
        }
        return SYS.ResultCode.SUCCEEDED;
    }

    public static void main(String args[]) {
        int exitCode = new CommandLine(new Main()).execute(args);
        System.exit(exitCode);
    }
}

result running the generated native image it shows: Exception in thread "main" picocli.CommandLine$InitializationException: picocli.CommandLine$AutoHelpMixin@74101cef is not a command: it has no @Command, @Option, @Parameters or @Unmatched annotations. graalvm-ce-java17-22.3.0, picocli 4.7.0, CentOS Linux release 8.2.2004 (Core).

@zipper01 does the native image generate a stack trace when the error happens? Can you post this stack trace please?
If you used the picocli-codegen annotation processor, that should have generated a reflect-config.json file under META-INF/native-image/picocli-generated/$project during compilation.
Can you post the content of the generated reflect-config.json file please?

@remkop Thank you. After adding the picocli-codegen plugin, the native image works fine.

Glad to hear that!


fix: responsive design for Artist profile

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] PR closes #3106
[ ] Requires deployment <rubick/magick_issue>
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[x] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.
mobile:

desktop:

pay 50

😍 Perfect, I’ve sent the payout
💵 $50 @ 67.74 USD/KSM ~ 0.738 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xb90decec650ad96923017bafc2975977d8dbc63056bdf4580c26754f0fc6cf7b
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Ensure Compatibility with uvloop

Resolves Issue #55
Re-implements asyncio.run to avoid using shutdown_default_executor. Instead set's the default executor and uses it's shutdown method when loop.run_until_complete() fails.

Putting this on the backburner for now. Please submit PR that drops uvloop. We can revisit later if there are perf problems or we have time to run time comparisons.


[GPU] Support multiple contraction dims in MmaSchedules

This adds support for multiple M, N, and K dims in problems when deducing a GPUMMASchedule.  The new heuristic is similar to the old one, but works on pairs of M and N dims. For example:
tensor<M1xM0xK1xK0> * tensor<N1xN0xK1xK0> -> tensor<M1xN1xM0xN0>

This will try to distribute the seeded tile counts to M0 and N0 (first attempting to distribute evenly, and then distributing to N followed by N), and then distribute the residual counts to M1 and N1. The K tile counts will be partitioned to K0 first, and then the residual tile counts will be partitioned to K1.
This PR also updates the config selection logic for the TileAndFuse pipeline to make use of the multiple contraction dimensions in mma schedules.
Depends on https://github.com/iree-org/iree/pull/18565

Oh man, the tuner will need some updating after this lands...

Oh man, the tuner will need some updating after this lands...

Oh, I would have thought this doesn't break the tuner. Does the tuner use the logic here somehow?

Oh man, the tuner will need some updating after this lands...

Oh, I would have thought this doesn't break the tuner. Does the tuner use the logic here somehow?

We discussed this offline and I misunderstood this part of the PR: the configuration logic changes but the attributes do not, so no need to update the tuner.

I understand how subgroup and workgroup tiles are distributed with multiple m/n/k dimensions. But slightly confused what happens with the thread tiles. Are we only targeting the innermost dimensions? Or are we targeting a reshaped version of the innermost dimensions (by packing?) ?

I added some more docs to help explain this. The m/n/kTileCounts naming was confusing, and it is more like m/n/kTileSizes. We target the intrinsic shape to the innermost dimension, so the innermost m/n/kTileSizes need to be aligned with (or able to pad to) the intrinsic shapes. The outer tile sizes can be thought of as unrolling factors of the innermost tile sizes.

While VectorDistribute doesn't support multiple dimensions for subgroup dims, can we try to keep the configuration logic similar to TileAndFuse? We plan to soon support that, and It would involve changing a lot of things this patch already did. I mentioned it at some places, but would be nice if we can get them to be similar. This is ofcourse best effort request, and not blocking in any way.

Thanks for all the comments! I basically just did a find and replace for all the VectorDistribute logic to use only the first dimension for M, N, and K. I chose to leave the functionality the same because I don't understand the VectorDistribute pipeline well enough to know if we can/how to change the configuration logic to support multiple contraction dimensions. I will just leave it as TODO comments for now, since I don't have enough knowledge of VectorDistribute to support it properly.
I'm happy to help with adding the support for VectorDistribute (and attention schedules) as well, but I think it is best to do it later, since this PR is needed for flipping the IGEMM flag.

While VectorDistribute doesn't support multiple dimensions for subgroup dims, can we try to keep the configuration logic similar to TileAndFuse? We plan to soon support that, and It would involve changing a lot of things this patch already did. I mentioned it at some places, but would be nice if we can get them to be similar. This is ofcourse best effort request, and not blocking in any way.

Thanks for all the comments! I basically just did a find and replace for all the VectorDistribute logic to use only the first dimension for M, N, and K. I chose to leave the functionality the same because I don't understand the VectorDistribute pipeline well enough to know if we can/how to change the configuration logic to support multiple contraction dimensions. I will just leave it as TODO comments for now, since I don't have enough knowledge of VectorDistribute to support it properly.
I'm happy to help with adding the support for VectorDistribute (and attention schedules) as well, but I think it is best to do it later, since this PR is needed for flipping the IGEMM flag.

Sure, that's fair enough. TODO comments sound good. Thanks! I'll let Quinn take the final approval on this since he mentioned he wanted to have a look at this. Soft approval from my side.


AutoLinking in React 0.60 causes error in PackageList

I have a fresh React-Native 0.60 project and have this dependency included.  After syncing the gradle files, it appears that the generated PackageList.java file creates the list of dependency constructors (that we used to have to manually do) but RNNotificationsPackage needs a parameter to work correctly.
react-native-notifications version: 2.0.0
react-native version: 0.60.3
The generated code looks like this:
  public ArrayList<ReactPackage> getPackages() {
    return new ArrayList<>(Arrays.<ReactPackage>asList(
      new MainReactPackage(),
      new RNNotificationsPackage() // This throws an error since it requires the application param
    ));
  }

Which throws an error since the constructor needs the application.

Unfortunately, my fork is a little too messed up to create a pull request, but this can be fixed by adding a react-native.config.js file to the package with the following:
module.exports = {
  dependency: {
    platforms: {
      android: {
        packageInstance: "new RNNotificationsPackage(this.getApplication())"
      }
    }
  }
};

Thank you, I actually did something pretty similar:
module.exports = {
  dependencies: {
    'react-native-notifications': {
      platforms: {
        android: null // disable Android platform, other platforms will still autolink if provided
      }
    }
  }
}

Based on the documentation: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md#how-can-i-disable-autolinking-for-unsupported-library

I resume both solutions into one that worked for me:
module.exports = {
  dependencies: {
    'react-native-notifications': {
      platforms: {
        android: {
          packageInstance: 'new RNNotificationsPackage(this.getApplication())'
        }
      }
    }
  }
}


Change DropdownAdapter

How can I disable the dropabove behaviour?
"When the dropdown is attached to the body, you are not limited to just displaying the dropdown below the container. Select2 will display above the container if there is not enough space below the container, but there is enough space above it. You are also not limited to displaying the dropdown within the parent container, which means Select2 will render correctly inside of modals and other small containers."
How can I change this behaviour? I want the dropdown to always display bellow.

Ok I found a solution in case someone else is looking to achieve this. In 4.0, you can use the AttachContainer module to attach the dropdown to the parent container. - ref: https://github.com/select2/select2/issues/2873
Example: http://jsfiddle.net/brunodd/jEADR/2009/

The problem with this solution is that it places dropdown inside wrapper container and if you have special style requirement (as I had in my case) it'll be difficult to make it work.
So alternative solution is use attachBody adapter as mentioned here, but patch its _positionDropdown function that it always think, it's openning below. Just change
        var enoughRoomAbove = false;
        var enoughRoomBelow = true;

and it's done
Can we rename this topic in 'Always open dropdown below'?


»manimgl example_scenes.py -lo« command does not work. -

Describe the error
I run the following command at the end of installation of manim, and then there is the following error.
Code and Error
manimgl:
manimgl example_scenes.py -lo
Error:
ManimGL v1.6.1
[23:13:55] INFO     Using the default configuration file, which you can modify in                         config.py:265
c:\windows\system32\manimce\manimgl\manimlib\default_config.yml
INFO     If you want to create a local configuration file, you can create a file named         config.py:266
custom_config.yml, or run manimgl --config
WARNING  You may be using Windows platform and have not specified the path of                  config.py:232
temporary_storage, which may cause OSError. So it is recommended to specify the
temporary_storage in the config file (.yml)
Traceback (most recent call last):
File "C:\Windows\System32\ManimCE\ManimGL\mgl\Scripts\manimgl-script.py", line 33, in
sys.exit(load_entry_point('manimgl', 'console_scripts', 'manimgl')())
File "c:\windows\system32\manimce\manimgl\manimlib_main_.py", line 21, in main
config = manimlib.config.get_configuration(args)
File "c:\windows\system32\manimce\manimgl\manimlib\config.py", line 300, in get_configuration
module = get_module(args.file)
File "c:\windows\system32\manimce\manimgl\manimlib\config.py", line 184, in get_module
spec.loader.exec_module(module)
File "", line 879, in exec_module
File "", line 1016, in get_code
File "", line 1073, in get_data
FileNotFoundError: [Errno 2] No such file or directory: 'C:\Windows\System32\ManimCE\ManimGL\example_scenes.py'
Environment
Windows 11:
ManimGL 1.6.1: master
Python 3.10.0:

I believe I have installed everything correctly and that I also installed the optional dependencies. I have made the tests following the instructions of this video  that SquareToCircle and WriteStuff «that is said uses LaTeX».
What can I do to solve this?

I am not a software engineer «not even close», but I can understand this area's concepts and commands with no difficulty IFF I am explained didactically... Any help would be welcomed.

Now, I was able to render the video of animation 4, but it doesn't show the lines of the graphic?!?!

Some animations of examples_scenes do work, and some texts as well, but others don't. I just moved examples_scenes and examples_scenes.py.1 files to ManimGL folder... I actually am just trying anything which will seem to work, but have no idea if I am doing anything which is actually correct.

I reinstalled ManimGL «this time» v1.3.0 and tried to run example_scenes command and nothing. It doesn't work, later on I will try TonyCrane correction of this python file. ManimCE works, no problem.


Added progress events, w/ test

We needed to give the user progress notifications when extracting large zips, so they don't give up or think it is stuck. It's a small change, but may prove useful for others.
I'm not super-familiar with the codebase or with promises, but I think this should do the trick. I added a test & it passes.
Note that if #37 reduces the number of files in the first test zip file (as requested in https://github.com/bower/decompress-zip/pull/32#issuecomment-55375832 ?), then the numTotalFiles variable in the test will need to be adjusted.

thanks @sindresorhus -- and thank you for all your work maintaining this project over the weekend, it is much appreciated.


fix slashingProtection reference

I was getting an error Error: Cannot find module '@chainsafe/lodestar-validator/src/slashingProtection/utils' when trying to run init, so i changed the reference to be local rather than referencing the global package name to get past the error.

Sorry, I have to watch out for these bad import statements added by VSCode automatically

Scanned the entire codebase and there are no more instances of self imports


Rename to opentelemetry-js?

@rochdev had this idea in https://github.com/open-telemetry/opentelemetry-node/issues/6#issuecomment-497320318
I would like us to make sure the core packages are compatible with the browser, and I think it will be easier to have Node + browser instrumentation code all living in the same repo to make it easier to keep everything up to date when refactorings happen.
I think the rename would be good for that purpose and to make it clear we are shooting for the broader JS community and not just Node, though Node will be the primary initial implementation target.

@bogdandrutu and @SergeyKanzhelev any thoughts?

If the goal is aligned across the SIG members to develop this package node independent I am fine with the raname. @mayurkale22 is everyone on board with this? Do you need an escalation on this?

Should there be another repo like -js-api? node and web may keep corresponding repositories with extra packages. Some logic may be very much node or web specific

The downside to separate repos is that then refactoring is kind of hard, because you can't have a single PR that changes the API and also all the users of the API, and it's harder to keep the API in sync in the dependent packages between versions. In contrast, if it's all in one repo, you can make sure that changes to the API package pass all the CI tests for both Node-specific and browser-specific packages.

than it's for @open-telemetry/node-maintainers to decide.  There is an inercection of people who knows both worlds. But sometimes people are only familiar with either of two and it may be harder for them to contribute

@mayurkale22 could you bring this up in the next SIG and see what people think?

@mayurkale22 could you bring this up in the next SIG and see what people think?

Sure, will update the thread once we have some conclusion after the meeting.
I'd prefer to keep both in the same repo., because we can work on both the version (server and browser) simultaneously without forcing us to publish to npm or other registries to share the types and core packages. And wherever is applicable we can mention, this package is intended for use both on the Node and in the browser.

Just my 2 cents: I am not really fond of this approach of anti-componentization as it creates large interdependent project, as already mentioned in #21. I would prefer well-defined interfaces and APIs.
It's always possible to check out two or more repos and use them as dev dependency without pushing anything to any registry.
The question should be, what the functional overlap between browser and Node.js would be in the end - not so much if they will share some types.
In #19 we are already discussing how to collect time in a way that works for browser- and serverside. I think many discussions like that will come up eventually.
Node.js and browser side JavaScript are still fundamentally different and there is also a whole new world of version topics and JavaScript engines in the browser.
I'm happy to discuss on the next meeting.

I prefer a single repo as well. I used to be against it because I believed it promotes coupling, but then I realized that it's very possible to couple many repos together anyway. It also gets really painful to keep multiple repos in sync. This is even more true as the number of repos increases. It's also a lot easier for users who simply want to mix and match different packages if they all use the same version numbers.

My initial reaction is (also) to support the single-repo, but we can discuss further in the SIG.

What I did to manage keeping the types in sync between opencensus-web and  opencensus-node was to write a kind of hacky [copy-types script]*https://github.com/census-instrumentation/opencensus-web/blob/master/packages/opencensus-web-types/scripts/copy-types.js) that would extract out only the type files from @opencensus/core  for a specific Git commit. This worked the Node-specific dependencies in @opencensus/core and enabled updating the types incrementally commit-by-commit as they changed in opencensus-node. But keeping it all in one package would simplify this.
For OpenCensus, the web and Node packages only share TS enums/interfaces. But for OpenTelemetry, I think it would be interesting to share a common platform-neutral API similar to OpenTracing. Then there could be platform specific packages of the API for Node/web.

I believe there was an agreement to rename the repository. We should probably do that sooner rather than later since the more we wait the more contributors will be impacted.

@open-telemetry/node-maintainers can you please confirm that you requesting this change. Happy to accommodate.

@open-telemetry/node-maintainers can you please confirm that you requesting this change. Happy to accommodate.

👍

Renamed


Poor Ethernet Performance using NXP Enet MCUX Driver

Describe the bug
Ethernet performance is very poor when running samples/net/zperf on any board using the MCUX Enet driver. This poor performance does not manifest on the STM32 Ethernet driver, so it is unlikely this issues is related to the networking stack
To Reproduce
Flashing the sample

west build -p always -b mimxrt1050_evk samples/net/zperf
west flash

Host configuration

sudo ifconfig network_adapter_name <IP_ADDRESS> netmask <IP_ADDRESS>

Running TX test
2. run sudo iperf -s -B <IP_ADDRESS> on host
4. run zperf tcp upload <IP_ADDRESS> 5001 10 1K 1000M on device
Running RX test

run zperf tcp download on device
run iperf -c <IP_ADDRESS> on host

The below TCP TX/RX results were collected using an RT1050 EVKB:
RX: 496Kbps
TX: 23.1 Mbps
Expected behavior
This Ethernet hardware is capable of iperf results up to 94Mbps download and 94Mbps upload on other NXP stacks. The Zephyr implementation should at least approach these numbers.
Environment (please complete the following information):

OS: Ubuntu 22.04
Toolchain: Zephyr SDK 0.14.2
355da1dd84e4550683e8cc1cf9a2c69fdbbfd49e

Additional context
STM32 iperf tests yield up to 63Mbps RX, so this should be treated as an initial goal for the iMX.RT 1050 board to achieve. That being said, there is still roughly 40 Mbps of performance left on the table versus the maximum seen on this hardware.

#47643 should serve as a hotfix: it does not correct all issues with the driver, but fixes TCP download performance back to usable levels

@danieldegrasse, do we want to keep this issue open given the merge of #48752?

@dleach02 I think we can close it.


add quality badges on the README page

Coverage remained the same at 38.642% when pulling 436f656285a6520398d64d1ec5ee1bc8248f91cc on quality-badges into 97ed8752af8e6abc0dda6a2076152f8b749b1fe7 on develop.


staging-next 2022-08-06

workflow docs: nixos.org/manual/nixpkgs/unstable/#submitting-changes-commit-policy
important job(s): hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
jobset: hydra.nixos.org/jobset/nixpkgs/staging-next
nix-review reports: https://malob.github.io/nix-review-tools-reports/
previous staging-next: https://github.com/NixOS/nixpkgs/pull/183748

Highlight reel:

commit
description

c22150c09ef
python310Packages.jsonschema: 4.7.2 -> 4.9.1

b55345f1314
cairo: pull upstream fix for grayscale aliasing bug

6f8fdc5b87b
SDL: add patch for CVE-2022-34568

19c5c57e72d
libtiff: add patch for CVE-2022-34526

67dece3b2c0
python310Packages.attrs: 21.4.0 -> 22.1.0

b34a4df8574
[staging] cmake: 3.23.3 -> 3.24.0

83daa6a3161
nspr: 4.34 -> 4.34.1

c817efe660f
gcc: extend stripping of .a libraries and .o objects

b4ba441d7c8
python310: 3.10.5 -> 3.10.6

112cd59c6ab
vim: 9.0.0115 -> 9.0.0135

ae26091d373
python3Packages.django_3: 3.2.14 -> 3.2.15

3d17b4c305c
cmake/setup.sh: allow for cmakeBuildDir to be configured

09c61607460
libcap: 2.63 -> 2.65

5e2471dfecf
perldevel: 5.35.9 -> 5.37.0, perl-cross: 31dac3e2 -> c8760457

20868cb2d07
perl: 5.34.1 -> 5.36.0

eba5f13c08c
go_1_18: 1.18.4 -> 1.18.5

81163361cc3
openh264: 2.2.0 -> 2.3.0

8907016b22e
linuxHeaders: 5.18 -> 5.19

f2298fcf8f5
unbound: 1.16.0 -> 1.16.2

c78ef1c764f
libdvdread: 6.1.2 -> 6.1.3 (#184291)

d1cc42ef524
libnl: 3.5.0 -> 3.7.0

964ee6f55f2
libwebp: 1.2.2 -> 1.2.3

549e08c8e8a
bintools-wrapper, cc-wrapper: avoid invalid export of 'expand-response-params'

5dfbe0ac192
iwd: 1.28 -> 1.29

a4cfeb7cf18
cmake: 3.23.2 -> 3.23.3

c826b18a286
patchelf: 0.14.5 -> 0.15.0

d82ce045579
windows.mingw_w64: enable stripping

51d1d82cc1c
libass: 0.15.2 -> 0.16.0

4c1987ddb18
python310Packages.urllib3: 1.26.10 -> 1.26.11

d338b732615
ell: 0.51 -> 0.52

bf817382e73
gnupg: 2.3.6 -> 2.3.7

43f0842a919
freeglut: 3.2.1 -> 3.2.2

e384d91be48
libfido2: depend on pcsclite to support nfc keys

a79c8da189e
libfido2: 1.10.0 -> 1.11.0

Built and booted into staging-next, required two small patches to disable 2 test cases from 2 different python3 packages. On #185627

[ ] python3Packages.ipython tests are broken, portably:
https://hydra.nixos.org/build/186605987
https://hydra.nixos.org/build/186574704
https://hydra.nixos.org/build/186577229
https://hydra.nixos.org/build/186537730
maintainers: @bjornfor, @FRidh.
(not sure why thousands of packages depend on it transitively)
[ ] perl536Packages.CpanelJSONXS
https://hydra.nixos.org/build/186584479
https://hydra.nixos.org/build/186513584
(builds on *-darwin)
Perhaps /cc @stigtsp?

The IPython failure:
=================================== FAILURES ===================================
_______________________ test_pprint_heap_allocated_type ________________________

    def test_pprint_heap_allocated_type():
        """
        Test that pprint works for heap allocated types.
        """
        module_name = "xxlimited" if sys.version_info < (3, 10) else "xxlimited_35"
        xxlimited = pytest.importorskip(module_name)
        output = pretty.pretty(xxlimited.Null)
>       assert output == "xxlimited.Null"
E       AssertionError: assert 'xxlimited_35.Null' == 'xxlimited.Null'
E         - xxlimited.Null
E         + xxlimited_35.Null
E         ?          +++

IPython/lib/tests/test_pretty.py:146: AssertionError

Given the if sys.version_info < (3, 10) I'd say this test started failing when python-3.10 was made the default. Disable test?

Re: IPython test failure: https://github.com/ipython/ipython/pull/13714

So in our case due to b4ba441d7c8 most likely.

Applying that makes it all pass, so I trust that it's a good solution and I'm pushing that.

perl536Packages.CpanelJSONXS

This should fix the build:

https://github.com/NixOS/nixpkgs/pull/186207

Here's some choice of more problematic dependencies with counts from nix-review-tools report.  Only those regressing since master, verified locally on x86_64-linux (but usually regressed cross-platform):

[ ] python310Packages.loguru (166)
[ ] python310Packages.cattrs (72)
[ ] libsForQt5.mailcommon (48)

In nix-review-tools reports it can be confusing that builds fixed by a restart are still shown as failed.  And running a new eval after success apparently doesn't help, probably due to some caching.  Also for staging-* it would be perhaps better to show diff against target branch.

I forgot to notify maintainers.

loguru: @jbaum98, @rmcgibbo
cattrs: @fabaff
mailcommon: @ttuegel, @vandenoever, @nyanloutre

I don't think libsForQt5.mailcommon is a channel blocker, so maybe it's OK-ish to let it regress on master?

That failure was triggered by cmake update in PR #185287.  (though that information doesn't seem very useful)

Uh, so I worked around the failure for now.

I think I just found the missing piece of the puzzle: https://invent.kde.org/pim/messagelib/-/commit/6eaef36d42bdb05f3412c178e53077fb6224ff80

I haven't tried that due to qt6 not being involved.

Opened https://github.com/NixOS/nixpkgs/pull/186967 to test it out.


feature/WEBDEV-2492-Download_pdf_in_Firefox_it_is_no_working

Ticket https://tignum.atlassian.net/browse/WEBDEV-2492
How?
feat: render each page independently, then stich them together

The current implementation has a problem: When the HTML to render is big enough, the canvas size needed to render the whole lot is bigger than the maximum supported canvas size from the browser and then we get glitches: Pages appear empty, images dissapear.
This compounds with the scale option. We need a high scale to be able to
render the PDF at a good enough resolution for print, but that makes the
canvas size grow dramatically.
The solution is render each page independently, store the mini PDFs and
then stich them all together in a unique PDF.
This is what this commit does.
LIMITATIONS

The #element-to-print must have a collection of HTML elements, one per
page, self contained. That means the styles needed to render each page
must be on each page container.

ALSO

Adds 'progress' events to inform the parent how far in the PDF
creating process we are.

Testing?
E2E: Not needed
Unit: Not needed

@dgrabla Trying to test it in the repo saw that we miss the preview, so we can no check in local, it is possible to fix that? It is important that we can check the repo is working properly before test in qot because we need to see the changes while we are changing!

@marenpri92 You are right, the local demo was broken. I fixed it on 79b5cd438fe07cf365240395f952ec860f7c6001 , thanks!

Also works in Firefox! the issue I see it is that the loading in the btn it is no visible and spend some time doing nothing visual till start to show the toast:
Chrome:
https://user-images.githubusercontent.com/60199681/164031922-1e5c2b4d-3187-417a-98e7-2c2ec62c7e8c.mov
Firefox:
https://user-images.githubusercontent.com/60199681/164032396-674f245c-6d8f-427b-a952-20472d2e05ea.mov

@marenpri92
I made a few changes on this PR. The render of the pages is synchronous instead of asynchronous, what allow us to start and finish the conversion of each page before starting with the next one. This allow us to display a reliable progress indicator to the user.
To be able to test it better, I also added shpi-report as dependency to generate a new demo page with out report (indexTignum). The demo page also reacts to the progress events with a toast message.
I think the new changes cover all your concerns, please give it a new look.

(rebased)


[CARBONDATA-1121]sort_columns blocked for alter table

Can one of the admins verify this patch?

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2230/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/103/

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/122/Failed Tests: 1carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test: 1org.apache.carbondata.spark.testsuite.allqueries.InsertIntoCarbonTableTestCase.insert into carbon table from carbon table union query

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2249/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2255/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/128/

LGTM


Odd Clear Behavior in yarnish and multi example

This seems like a regression from what I remember. The yarnish example has 4 virtual concurrent build spinners and once they are done, three print out waiting... and one is cleared resulting in this:
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
[1/?]   waiting...
[2/?]   waiting...
[3/?]   waiting...
✨  Done in 13 seconds

I expected either none of them to show up or all 4.
Likewise I think there is a bug in the multi example where one retains the bar:
starting!
pb1 is done!
[00:00:02] ########################################     128/128     done
pb3 is done!
pb2 is done!

Tested on 39ebd5faa898c5ab802e4ad79dcddb0224d14101. Both of those examples use the multi bar clear function.

I bisected it down on the yarnish example, 1d47e1dbd57bf4013e36bda3eed6a1e9f068a6b6 is the regression.

I think that belongs to https://github.com/console-rs/indicatif/pull/438 but I'm not entirely sure. There is no clear merge commit mentioning the PR.

Yes, it's #438.

I'll take a look.

What's strange is that if you add a call to drop(pb) after the call to finish_with_message it works:

I cannot reproduce that it works as expected. This is fundamentally some sort of race condition so every once in a while it works when you run it. Potentially you just had a few lucky runs.

Hah, sure enough I re-ran it and you're right :/.

The issue here is that the zombie pruning code I added changed the semantics of MultiProgress. Previously, MultiProgress never forgot about progress bars (unless you MultiProgress::removed them). That's true even if you call finish (or friends) on the ProgressBars. Zombie pruning taught MultiProgress to forget about progress bars that don't exist anymore (because they got dropped). Because of this, clear no longer clears those dropped ProgressBars.
The yarnish example is acting non-deterministically because the order in which those 4 pbs are dropped is random. Zombie pruning (and adjustment of last_line_count) happens in MultiState::draw, but MultiState::clear doesn't use draw. I haven't traced through exactly what is happening, but I don't think I'll bother because I have a proposition.
I now see that zombie pruning changes the behavior of MultiProgress in unintended ways. I'd like to propose turning off zombie handling by default, and making it an option you can set on MultiProgress. For example, MultiProgress:set_reap_zombies(True). If zombie reaping is enabled, I'd also propose making MultiProgress::clear an illegal operation. It doesn't make sense to call clear on a MultiProgress that can't necessarily clear everything it was responsible for drawing. If a user utilizing MultiProgress in zombie reap mode needs to clear pbs, then they are responsible for not letting those pbs becomes zombies in the first place.
What do you think?

To restate the reason for introducing zombie reaping in the first place (from #426):

Since we never call MultiProgress::remove on ProgressBars that are dropped/finished (see #419), bars are always redrawn even when they don't need to be. When the number of bars (n) becomes greater than terminal lines (m), on each draw MultiProgress will clear the last m lines but write n lines, leaving m - n lines in the scrollback history.

So could we get the terminal height from console and only reap once we run out of lines instead of requiring extra configuration/setup from the user?

To me it seems at least that this keeping track in to_clear and manually invoking finish_and_clear is something that the MultiProgress could do automatically itself?

So could we get the terminal height from console and only reap once we run out of lines instead of requiring extra configuration/setup from the user?

Personally I'd rather not deal with console height if we don't have to, since the user can resize the terminal whenever they want and mess us up. I think even if we did something based on height, it still wouldn't fix clear. Once a pb has been reaped MultiProgress has lost track of it. Regardless of when that happens, clear won't be able to touch it.

To me it seems at least that this keeping track in to_clear and manually invoking finish_and_clear is something that the MultiProgress could do automatically itself?

I think this is on the right track. MultiProgress should keep track of previously-reaped progress bars. The last number of lines that were printed is enough. Then clear just has also clear that number in addition to whatever is being displayed by the currently active set.
One wrinkle: calling MultiProgress::println should reset the reaped line counter to 0, since clear can't erase lines above the printed message without also erasing the message itself. We should do it for MultiProgress::suspend too - making the assumption that the user wrote something to the terminal during the suspend.

I did some more digging on this today. I think I can fix the zombie reaping so that MultiProgress::clear works well, with a caveat. Previously you could do a draw operation after a clear (e.g. just a tick on some pb that's part of the MultiProgress) and it would be able to reconstitute everything, including stuff that had been dropped. Now that zombie reaping is a thing, that re-draw will only be able to re-draw what hasn't been reaped.
Also, I think I can more clearly characterize the interaction between reaping and MultiProgress::println. println will be able to print lines above anything that hasn't been reaped. I don't foresee this as an issue because MultiProgress::println is new for 0.17.0 anyway. What do you think? Are these limitations ok?

@djc @mitsuhiko  thoughts on above?

I think it makes sense.

I did some more digging on this today. I think I can fix the zombie reaping so that MultiProgress::clear works well, with a caveat. Previously you could do a draw operation after a clear (e.g. just a tick on some pb that's part of the MultiProgress) and it would be able to reconstitute everything, including stuff that had been dropped. Now that zombie reaping is a thing, that re-draw will only be able to re-draw what hasn't been reaped.

This seems to make sense -- remind me what the criteria for getting reaped again? Does it even make sense to tick something in a state where it can be reaped?

Also, I think I can more clearly characterize the interaction between reaping and MultiProgress::println. println will be able to print lines above anything that hasn't been reaped. I don't foresee this as an issue because MultiProgress::println is new for 0.17.0 anyway. What do you think? Are these limitations ok?

Seems fine!

This seems to make sense -- remind me what the criteria for getting reaped again? Does it even make sense to tick something in a state where it can be reaped?

A progress bar becomes a zombie when it is droped. So you will never be able to tick it after that, no.

Hi @mitsuhiko - when you get a chance, can you please re-test with main?

This seems to be resolved.


UI: Repo header tweaks

Use basic buttons on the header buttons, matching gogs
Make 'Manage topic' text smaller, remove margin-left with no topics
present
Move various inline styles to CSS
Use flexbox on header title and buttons

Before

After

Codecov Report

Merging #5945 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5945      +/-   ##
==========================================
+ Coverage   38.54%   38.54%   +<.01%
==========================================
  Files         330      330
  Lines       48518    48518
==========================================
+ Hits        18700    18702       +2
+ Misses      27111    27108       -3
- Partials     2707     2708       +1

Impacted Files
Coverage Δ

models/unit.go
14.28% <0%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c0f7d...7faca82. Read the comment docs.

After screenshot updated, now centered .repo-title vertically.


Update Flax mission, fix some links

@marcvanzee @andsteing

Codecov Report

Merging #2797 (11d1859) into main (33afdc9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2797   +/-   ##
=======================================
  Coverage   81.18%   81.18%
=======================================
  Files          53       53
  Lines        5645     5645
=======================================
  Hits         4583     4583
  Misses       1062     1062

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Introduce a Cache abstraction

Hi,
Guava is a tricky dependency. Large projects can have multiple dependencies to libraries that depend on different Guava versions and cause conflicts.
I see there's a plan to switch to Caffeine (great!) for Pebble 3.0, but I guess this means in a pretty far future.
Instead, would you be interested in a contribution to introduce a cache abstraction, with Guava and Caffeine based implementations (Caffeine only being an optional dependency)?
This way, Guava would still be the default, at least in Pebble 2, but users could prefer passing Caffeine based caches instead and exclude the Guava dependency.
Please let me know.

@ebussieres @mbosecke Gentle ping :)

So actually, as Caffeine uses Java 8, it would be complicated to have such an API without upgrading first.
Would you be interested in upgrading in Pebble 1.5 without waiting for 2.0? Or releasing beta versions of 2.0?
FYI, as I didn't get any answer to my messages and really needed to move forward with this issue and #293, I had no choice but to fork. I would really love to be able to contribute my changes back instead of forking... Please answer.

Since caffeine has guava adapters, could that be the abstraction that is implemented based on the jdk version? Might be easiest.

@ben-manes Did you hack Google's robots so they would notify you of every new mention of Caffeine on Github? ;-)

Since caffeine has guava adapters, could that be the abstraction that is implemented based on the jdk version? Might be easiest.

The point is to no longer depend on Guava, hence not expose it in the Pebble API.
IMHO, Guava must go away:

It's legacy

Functions? Use Java 8
Fluent collections? Use Java 8's Streams
Immutable and primitive collections? Use Eclipse collections
Cache? Use Caffeine

It's a cancer

The issue here is not because of Guava itself but because of library maintainers who miss the point that Guava will release a new major version every 4 months or so, hence with breaking changes. You're supposed to keep your Guava dep up to date, otherwise you'll ruin large projects. For example, Pebble depends on 16.0.1 that was released almost 4 years ago.
As Guava is popular, you can easily end up with conflicting dependency versions. In my case, I pull Guava from Pebble, Openstack, Cassandra Java driver and cassandra-unit.
If you're unlucky and can't find a version that's compatible with all your deps, you have to:

either contribute an upgrade to all your deps and hope maintainers will accept to merge and release
or fork
or build fatjars that ship Guava in a translated package

Projects not updating their dependencies despite modern tooling is frustrating, since libraries should be allowed to evolve. Guava did change the policy to no longer break backwards compatibility after 2 year depreciation cycle so hopefully this issue will be reduced in the future. It’s still useful, but you’re right that it’s much less so these days. I do think libraries should minimize their dependencies do to conflict issues and upgrade regularly. Seems to make sense to remove Guava here.
GitHub search is great and super easy to monitor keywords with :)

Seems to make sense to remove Guava here.

I think so too. Pebble only depend on Guava for caching, Caffeine is simply better than Guava cache and if one really want to use Guava cache, he can use the adapter.

I agree! Having recently added Pebble to my project, Guava is now my biggest dependency by far (almost 2Mb), and I prefer cache2k for caching

I'm not familiar with the plans for Pebble 3, but for the current release this is still a no go. See #155

I am in support of @nicky9door's changes and think it would be beneficial if they could be PR'd and move forward (along with the Java 7 deprecation). GAE now supports Java 8 and it doesn't seem that there is any other real impediment (i.e. legacy users can still use the older version if they wish).

We're gonna use caffeine in v3. Already done in branch 3.0


Document Sendgrid SMTP on Azure

Apologies if this is inappropriate, but I can't find detailed documentation on how to deploy a NuGetGallery on Azure using Sendgrid as the email service provider.
Apparently Sendgrid SMTP URIs need to be in the form:
smtpTLS://CREDENTIAL-USERNAME:PASSWORD@smtp.sendgrid.net:587
But this format seems to cause an exception when I set Gallery.SmtpUri value like this.
The existing documentation in README.md states that

"SMTP connection string, such as: smtp://user:password@smtpservername:25"

should be used, but this does not seem to work for Sendgrid Azure service. Also, Sendgrid recommend using API Key, but the Gallery.SmtpUri does not support this.
Can someone provide guidance on correct usage for Sendgrid Azure service for email?

@corinja , apologies for the slow reply. We have missed this issue.
What is the exception you are seeing and what is the stack trace? What is the config value you used (provide the string with obfuscation of sensitive data)?

For using SMTP over SSL one should specify smpts as the schema in URL in the value for Gallery.SmtpUri. Another caveat is that if your login/password contains URL-unfriendly characters (such as @, %, etc.), they have to be URL encoded.
E.g. if your username is u$ername password is p@ssw0rd, then URL should look like:
smtps://u%24ername:p%40ssw0rd@smtp.sendgrid.net:587/


Ingest companions to Roth24 sources

Part of #445 .
The 87 sources in Roth24 all have higher mass companions to be ingested into the Companion Relationships table.

Here's a template to get you started: https://docs.google.com/spreadsheets/d/1NHav3lDDbH95KtBe0Lq4OvIzKkRmIhP5LSaw_BUS-5Y/edit?gid=0#gid=0

Here is the google sheet containing the companion relations: https://docs.google.com/spreadsheets/d/1JFa8F4Ngzp3qAW8NOBurkz4bMKo9zXYeF6N1vMtqDZs/edit?usp=sharing


Playlists in folders become too small to read

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

ℹ Environment / Computer Info
- Spotify version: Spotify for Windows <IP_ADDRESS>4.gccacfc8c
- Spicetify version: 2.9.5
- Fluent installation method: Github readme

📝 Description
When folders are opened, the playlists inside of them are indented, which means that after one or two layers of subfolders, they are unreadable/extremely thin. Perhaps a vertical way of dividing folders (using e.g. a line to divide folders) would be good.
📸 Screenshots

After 3 or so layers, it spills into the sidebar padding...


Service record content not displaying properly on mobile

@PeaceGeeks can you please describe what the issue is? I know that moving the content left to right isn't intuitive - is that what this ticket is?

correct - i wouldn't know it was there at all if it wasn't for me accidentally swiping.

In that case, I would recommend that we just switch this to your suggestion of having the info appear in one column.

that works for me.

As discussed, use #115 as a solution.

@Jareechang - this is still displaying incorrectly to me.

Think there was a cache issue. Can we have the labels wrap as occurs on the desktop version?

it's fixed in the Search Branch. We just need to wait for it to be deployed :)


Fix issue #14

Prevents accidental deletion of folders

I've integrated this fix into the next version, thanks.


Improve reward setting functionality

Right now, rewards values are defined in a dictionary given as input to the AnnubesEnv class. We can define a standard and give more flexibility to the user, which now has to mandatorily fill in values for "abort", "correct", and "fail".  Or we can keep it fixed in this sense, if we can individuate a way to assign rewards that satisfies the majority of annubes types of tasks.

Kamino closed and cloned this issue to neurogym/neurogym


[Feature]: Add projects to profile detail page

#547
#554

Implemented it to be visible for all session users incl. "anon"
Should we change this?


[Feature] - Blog's Page 'Page Number Handler Section' Design Enhancement

Problem
The alignment of the page number handler section is not properly aligned. It's neither left nor right aligned.  This can be improved by making this section centered-aligned in order to improve overall design.
Description
This current design of this section can be improved by working on its position. It can be aligned in center in order to improve overall design.
Alternatives
If center-aligned not work, then we can set it completely towards left or right.
Additional context
Current Design

Expected Updated Design

Implementation

[x] I would be interested in implementing this feature.

@iamRabia-N This is an interesting improvement. Our Design System, Vocabulary, as it currently stands sets the pagination navigation as left aligned. Which means any site utilizing this component would need to have that adjusted. And we'd need to evaluate how it being centered might affect things, I'm not sure if the improvement for this one site might have an unexpected outcome on others.
Also, The menu is left aligned to the content box edge, rather than the contents of the content box edge.
I think this Issue would likely be better placed on the Vocabulary repository, so I'm going to create a new Issue there referencing this one and close this one.
We'd have to consider larger use case affect for making it center aligned, but initially this seems like a good idea.


avoid using dockerHub for base images

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Azure pipeline for e2e tests now fail at pretty high rate due to docker hub throttling. Remove all dependencies from dockerHub.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer

coverage: 80.447% (-0.08%) from 80.528%
when pulling 3770d9552b453784c35194e7bdb985cdacb8e2f4 on jwtty/pipeline
into c8a70f524d12a390f641b6123e268506efbc0365 on main.


Feat: lastUpdate is missing

The current implementation doesn't contain lastUpdate filed, which is important to UCL (Unified Customer Landscape). UCL has a function to decide whether update the ord document backend by version and lastUpdate fileds.

Good catch!
First idea: We could just create a new Date() on startup of the CAP server. Then as long as the server runs, it will not change and UCL will not fetch metadata again. This works fine as long as the metadata is static - as it cannot change while the server is running.
If you want lastUpdated to not update everytime you restart the server ,you have to manually set it via @ORD.Extensions. (this should already work).
Once we have run-time tenant specific ORD metadata, the lastUpdate situation gets more complicated because it needs to be updated everytime the resource has been changed at run-time. But for now this is not supported and we should first improve the static metadata case.


Use Gradle's logger to print debug output

Resolves #1855

Codecov Report

Merging #1869 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1869   +/-   ##
=========================================
  Coverage     80.31%   80.31%
  Complexity     1958     1958
=========================================
  Files           325      325
  Lines          5517     5517
  Branches       1025     1025
=========================================
  Hits           4431     4431
  Misses          557      557
  Partials        529      529

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a6327b...e3d28af. Read the comment docs.

I'm sorry I merged this too fast on my mobile without paying attention of the build status. ..
I've reverted the merge. Sorry for the trouble.

@arturbosch 1a6327b causes problems in combination with Jsr223. The reverted commit works fine.


Upgrade Dataset View and dependencies to support Harvest/Registry upgrades

💡 Description

It seems like Solr is not running on the OL8 test machine.

PRs merged. Testing underway


Move Storyline Up & Down Shortcut

Allow assignment of a shortcut to move a storyline up and down in the order.

I wonder if this can be more easily achieved now with hs.finalcutpro @randomeizer ?


Windows Server 2016 Upgrde

Hi,
The article mentions "upgrading to Windows Server 2016, Windows Server 2019 and Windows Server 2022 are supported."
However, the PowerShell script says that $sku must be either "server2022Upgrade" or "server2019Upgrade".
Customers that would need to upgrade from 2012 or 2012R2 to 2016 need to provide their own installation media?
Thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 780935e4-9fdd-d41a-c4ae-69e1cf118653
Version Independent ID: 7d156aed-66b7-e010-0647-6064aa54f58b
Content: Windows in-place upgrade - Azure Virtual Machines
Content Source: articles/virtual-machines/windows-in-place-upgrade.md
Service: virtual-machines
GitHub Login: @cynthn
Microsoft Alias: cynthn

@juanand
Thanks for your feedback! We will investigate and update as appropriate.

@juanand
Thank you for your feedback!
I'd recommend working closer with our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
[Teams Q&A forum] (https://docs.microsoft.com/en-us/answers/topics/46488/office-teams-windows-itpro.html) for technical questions about the configuration and administration of Microsoft Teams on Windows.
[Microsoft Teams Community forum] (https://answers.microsoft.com/en-us/msteams/forum?sort=LastReplyDate&dir=Desc&tab=All&status=all&mod=&modAge=&advFil=&postedAfter=&postedBefore=&threadType=All&isFilterExpanded=false&page=1)
Thank you for your time and patience throughout this issue.


Build for Linux x86 and arm64

Closing because it's failing to build and I have no idea how to fix it.


[Terminal] Cursor in :terminal window is invisible

I tried vim 8.0.0776 :terminal and immediately noticed that the cursor is invisible. I tried two terminal emulators (st and xterm), as well as running in a tty directly. I also tried running inside a tmux pane. And finally with both white and black background in terminal.
There is a point where the cursor becomes visible. After I press <C-w> and vim begins to wait for the next key press it displays the cursor properly. Even blinking cursor is working in tty as long as vim is waiting for that second key press.
Here's the output of :version:
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Jul 26 2017 00:30:01)
Included patches: 1-776
Compiled by Arch Linux
Huge version without GUI.  Features included (+) or not (-):
+acl             +file_in_path    +mouse_sgr       +tag_old_static
+arabic          +find_in_path    -mouse_sysmouse  -tag_any_white
+autocmd         +float           +mouse_urxvt     -tcl
-balloon_eval    +folding         +mouse_xterm     +termguicolors
-browse          -footer          +multi_byte      +terminal
++builtin_terms  +fork()          +multi_lang      +terminfo
+byte_offset     +gettext         -mzscheme        +termresponse
+channel         -hangul_input    +netbeans_intg   +textobjects
+cindent         +iconv           +num64           +timers
+clientserver    +insert_expand   +packages        +title
+clipboard       +job             +path_extra      -toolbar
+cmdline_compl   +jumplist        -perl            +user_commands
+cmdline_hist    +keymap          +persistent_undo +vertsplit
+cmdline_info    +lambda          +postscript      +virtualedit
+comments        +langmap         +printer         +visual
+conceal         +libcall         +profile         +visualextra
+cryptv          +linebreak       -python          +viminfo
+cscope          +lispindent      +python3/dyn     +vreplace
+cursorbind      +listcmds        +quickfix        +wildignore
+cursorshape     +localmap        +reltime         +wildmenu
+dialog_con      -lua             +rightleft       +windows
+diff            +menu            -ruby            +writebackup
+digraphs        +mksession       +scrollbind      +X11
-dnd             +modify_fname    +signs           +xfontset
-ebcdic          +mouse           +smartindent     -xim
+emacs_tags      -mouseshape      +startuptime     -xpm
+eval            +mouse_dec       +statusline      +xsmp_interact
+ex_extra        +mouse_gpm       -sun_workshop    +xterm_clipboard
+extra_search    -mouse_jsbterm   +syntax          -xterm_save
+farsi           +mouse_netterm   +tag_binary
   system vimrc file: "/etc/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H   -D_FORTIFY_SOURCE=2  -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -L/usr/local/lib -Wl,--as-needed -o vim    -lSM -lICE -lXt -lX11 -lXdmcp -lSM -lICE  -lm -lncurses -lelf -lnsl   -lacl -lattr -lgpm -ldl

Note: It does say Compiled by Arch Linux, but this is a custom build I've done.

Now @ichizok is working on this.
https://groups.google.com/forum/#!topic/vim_dev/HhczoxAdcWE
@bstaletic Could you please try this patch?
https://gist.github.com/ichizok/9dafd126bb6f6d5f79878a18f5665e6f

Could you please try this patch?

Gladly. Give me a few minutes.

I've done some testing.
Good news: Cursor is visible
Bad news: If the terminal spawned by :terminal opens a tmux pane inside it backspace gets broken.
In case I wasn't clear enough, with this patch cursor is visible but here's how to reproduce the backspace issue:

Run vim
:terminal
Run tmux new-session
Write anything
Press backspace

@bstaletic Could you please try one more patch?
diff --git a/src/terminal.c b/src/terminal.c
index 0532d01..3e2412e 100644
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -368,7 +368,7 @@ term_convert_key(int c, char *buf)
        case CAR:               key = VTERM_KEY_ENTER; break;
        case ESC:               key = VTERM_KEY_ESCAPE; break;
                                /* VTERM_KEY_BACKSPACE becomes 0x7f DEL */
-       case K_BS:              c = BS; break;
+       case K_BS:              key = VTERM_KEY_BACKSPACE; break;
        case K_DEL:             key = VTERM_KEY_DEL; break;
        case K_DOWN:            key = VTERM_KEY_DOWN; break;
        case K_END:             key = VTERM_KEY_END; break;

I tried the patch and the immediate issue is resolved, but i didn't have the tme to test it for any possible breakage.

@mattn I tested the ptch a bit more and it doesn't break anything I tried.

@bstaletic thank you!

Yasuhiro Matsumoto wrote:

@bstaletic Could you please try one more patch?
diff --git a/src/terminal.c b/src/terminal.c
index 0532d01..3e2412e 100644
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -368,7 +368,7 @@ term_convert_key(int c, char *buf)
        case CAR:               key = VTERM_KEY_ENTER; break;
        case ESC:               key = VTERM_KEY_ESCAPE; break;
                                /* VTERM_KEY_BACKSPACE becomes 0x7f DEL */
-       case K_BS:              c = BS; break;
+       case K_BS:              key = VTERM_KEY_BACKSPACE; break;
        case K_DEL:             key = VTERM_KEY_DEL; break;
        case K_DOWN:            key = VTERM_KEY_DOWN; break;
        case K_END:             key = VTERM_KEY_END; break;

That is not a solution, as it makes it impossible to send a real
backspace to the job.  Everything is turned into 0x7f (which is Delete).
--
hundred-and-one symptoms of being an internet addict:
269. You receive an e-mail from the wife of a deceased president, offering
to send you twenty million dollar, and you are not even surprised.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

With current vim 8.0.779 inside a :terminal window both Ctrl-H and Backspace send a ^H, which means programs like cat do not interpret it as a backspace.  For the record, stty -a shows erase = ^? both inside a vim's :terminal, and in a regular gnome-terminal.
With @mattn's patch Ctrl-H correctly sends ^H and Backspace correctly sends a ^? (aka DEL).
I don't have a terminal set up where Backspace normally sends a ^H, so I cannot check whether it would incorrectly convert that ^H to a ^? or not.
Perhaps vim should check t_kb and do one thing when it's set to ^H and a different thing when it's set to ^??

Marius Gedminas wrote:

With current vim 8.0.779 inside a :terminal window both Ctrl-H and
Backspace send a ^H, which means programs like cat do not interpret
it as a backspace.  For the record, stty -a shows erase = ^? both
inside a vim's :terminal, and in a regular gnome-terminal.
With @mattn's patch Ctrl-H correctly sends ^H and Backspace correctly
sends a ^? (aka DEL).
I don't have a terminal set up where Backspace normally sends a ^H, so
I cannot check whether it would incorrectly convert that ^H to a ^? or
not.
Perhaps vim should check t_kb and do one thing when it's set to ^H
and a different thing when it's set to ^??

It doesn't depend on Vim but on the command you run.  For me "csh" uses
erase ^H whild bash has ^?.
  Read the label!
If I make the change to have K_BS produce VTERM_KEY_BACKSPACE then in
cat I get ^[[3~, so that doesn't work either.  In fact, in this
situation all three keys produce that.
--
Ten bugs in the hand is better than one as yet undetected.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Cursor problem is fixed, thus this issue can be closed.
I'll look into the erase problem.


qcodes dataset cannot be stored easily

The qcodes dataset can only be stored to disk using a qcodes formatter. To save results totgether with other data it would be good to be able to serialize a dataset to a string or something like pickle, json or xml. So someting like:
s=dataset.tostring()
dataset2 = qcodes.load_dataset_string(s)

or
mystring=pickle.dumps(dataset)
dataset2=pickle.loads(mystring)

The method used for converting the dataset to a string could be taken from the formatter.

yes that is a problem.  The entire data_set needs more love.
I am thinking and thinkering with sqlite. This should allow us to have a better life 🥇

@eendebakpt @AdriaanRol @damazter @MerlinSmiles
now the big question is:
- do we want binary or not ? (pickle, sqlite, hdf5)  vs (json, younameit)

@giulioungaretti i'd like it to be independent(no funny software to install to run a database just to get a single trace, and fast as in saving and loading a dataset. And i want to be able to load that data in 15 years from now.

@MerlinSmiles  so no HDF5, or any thing for you  just text.

Im not saying just text?! I dont see the issue with HDF5, pretty standard thing? But i am very unsure about sql stuff for instance, I dont know much about it. And there are requirements for data archiving and stuff that we might not know about

outside the science world the use of SQL like databases is probably 1000 of times larger than HDF5 and sqlite even has build in support in python https://docs.python.org/3.5/library/sqlite3.html

As I said I dont know much about it. Would just be a pitty to use something and in half a year your profs come and tell you no way.

Ok, makes sense I understood it as you were primarily concerned with the format going out of use in general and being to obscure

@unga @merlinsmiles @jenshnielsen Both binary and text are fine with me. Sqlite is pretty standard,  so quite future proof. However, i am not sure sqlite is really suitable for storing mixed type data (e.g. dicts containing strings, floats, numpy arrays,  datasets and others dicts)
Both json and pickle do a good job of storing such structures, except for the dataset.


Saleor 3907 add top card to gift card list

I want to merge this change because...

PR intended to be tested with API branch:
Screenshots

Pull Request Checklist

[ ] This code contains UI changes
[ ] All visible strings are translated with proper context including data-formatting
[ ] Attributes [data-test-id] are added for new elements
[ ] Changes are mentioned in the changelog
[ ] The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://master.staging.saleor.cloud/graphql/

Task linked: SALEOR-3907 Add top card to Gift Cards list


Script Hangs

When I run the python script it just hangs.  Do you have a list of dependencies?

@TechJeeper you'll need the other two repos from my github: https://github.com/keithprickett/lacrosse_weather and https://github.com/keithprickett/wunderground_uploader
I expect you'd get a different error than "it just hangs" if you didn't have those already though.  Is there any output associated with your "hang?"

@TechJeeper you'll need the other two repos from my github: https://github.com/keithprickett/lacrosse_weather and https://github.com/keithprickett/wunderground_uploader
I expect you'd get a different error than "it just hangs" if you didn't have those already though.  Is there any output associated with your "hang?"

No response in months.

I'm trying to set this up and I'm actually getting the same exact thing.... When I run the script it just hangs and does nothing until I ctrl-c it....  Once I hit ctrl-c it returns a trace:
`root@martha:~/myweather# python3 ./lacrosse_to_wunderground.py
Warning: Didn't get latest observation time, loading from time 0
^CTraceback (most recent call last):
File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 331, in _make_request
httplib_response = conn.getresponse(buffering=True)
TypeError: getresponse() got an unexpected keyword argument 'buffering'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "./lacrosse_to_wunderground.py", line 85, in
push_all_since_timestamp_temperature_to_wunderground(w, old_utc_timestamp)
File "./lacrosse_to_wunderground.py", line 50, in push_all_since_timestamp_temperature_to_wunderground
wunderground_upload_data_point(station_id, station_key, weather_data, utc_timestamp)
File "/root/myweather/wunderground_uploader/uploader.py", line 49, in wunderground_upload_data_point
requests.get('http://rtupdate.wunderground.com/weatherstation/updateweatherstation.php', params=payload)
File "/usr/lib/python3/dist-packages/requests/api.py", line 60, in get
return request('get', url, **kwargs)
File "/usr/lib/python3/dist-packages/requests/api.py", line 49, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/lib/python3/dist-packages/requests/sessions.py", line 457, in request
resp = self.send(prep, **send_kwargs)
File "/usr/lib/python3/dist-packages/requests/sessions.py", line 569, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python3/dist-packages/requests/adapters.py", line 362, in send
timeout=timeout
File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 516, in urlopen
body=body, headers=headers)
File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 333, in _make_request
httplib_response = conn.getresponse()
File "/usr/lib/python3.4/http/client.py", line 1224, in getresponse
response.begin()
File "/usr/lib/python3.4/http/client.py", line 390, in begin
version, status, reason = self._read_status()
File "/usr/lib/python3.4/http/client.py", line 352, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/usr/lib/python3.4/socket.py", line 371, in readinto
return self._sock.recv_into(b)
KeyboardInterrupt
`
I get a slightly different trace when using the full command you specify in the readme
root@martha:~/myweather# cd ~/myweather && python3 ./lacrosse_to_wunderground.py cat myweather_ts> myweather_ts ^CTraceback (most recent call last):   File "./lacrosse_to_wunderground.py", line 85, in <module>     push_all_since_timestamp_temperature_to_wunderground(w, old_utc_timestamp)   File "./lacrosse_to_wunderground.py", line 50, in push_all_since_timestamp_temperature_to_wunderground     wunderground_upload_data_point(station_id, station_key, weather_data, utc_timestamp)   File "/root/myweather/wunderground_uploader/uploader.py", line 49, in wunderground_upload_data_point     requests.get('http://rtupdate.wunderground.com/weatherstation/updateweatherstation.php', params=payload)   File "/usr/lib/python3/dist-packages/requests/api.py", line 60, in get     return request('get', url, **kwargs)   File "/usr/lib/python3/dist-packages/requests/api.py", line 49, in request     return session.request(method=method, url=url, **kwargs)   File "/usr/lib/python3/dist-packages/requests/sessions.py", line 457, in request     resp = self.send(prep, **send_kwargs)   File "/usr/lib/python3/dist-packages/requests/sessions.py", line 569, in send     r = adapter.send(request, **kwargs)   File "/usr/lib/python3/dist-packages/requests/adapters.py", line 362, in send     timeout=timeout   File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 516, in urlopen     body=body, headers=headers)   File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 308, in _make_request     conn.request(method, url, **httplib_request_kw)   File "/usr/lib/python3.4/http/client.py", line 1142, in request     self._send_request(method, url, body, headers)   File "/usr/lib/python3.4/http/client.py", line 1180, in _send_request     self.endheaders(body)   File "/usr/lib/python3.4/http/client.py", line 1138, in endheaders     self._send_output(message_body)   File "/usr/lib/python3.4/http/client.py", line 963, in _send_output     self.send(msg)   File "/usr/lib/python3.4/http/client.py", line 898, in send     self.connect()   File "/usr/lib/python3/dist-packages/urllib3/connection.py", line 154, in connect     conn = self._new_conn()   File "/usr/lib/python3/dist-packages/urllib3/connection.py", line 133, in _new_conn     (self.host, self.port), self.timeout, **extra_kw)   File "/usr/lib/python3/dist-packages/urllib3/util/connection.py", line 78, in create_connection     sock.connect(sa) KeyboardInterrupt
I've tried letting the process run for 5+ mins but nothing ever seems to happen.  There also isn't any increased load on the system but I do see that the python3 command does remain running in ps ax:
6870 pts/0    S+     0:00 python3 ./lacrosse_to_wunderground.py 0


fix(cli): disable vertical borders of the update notification

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[x] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fixes #9239. This is a really small modification. I just added a custom borderStyle to boxenOptions.
Test Plan

I changed notifier in beforeCli in beforeCli.mjs to:
updateNotifier({
    pkg: {
      "docusaurus",
      version: '2.4.0',
    },
    // Check is in background so it's fine to use a small value like 1h
    // Use 0 for debugging
    updateCheckInterval: 0,
  });

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Screenshot ran in WebStorm with zsh:

Related issues/PRs

#9239

great idea, didn't know it was possible to remove only a part of the border. Thanks 👍


System build

[x] minor .bashrc fix
[ ] docker: USE_SYSTEM_*

[x] dependencies from CCPPETMR_VM/scripts/INSTALL_prerequisites_with_apt-get.sh
[x] USE_SYSTEM_Armadillo=ON?

[x] missing from above - add there?
note that according to .travis.yml#L12 can't use system's version on trusty

[ ] USE_SYSTEM_GTEST=ON? (#50)
[ ] pip install other libs from INSTALL_prerequisites_with_apt-get.sh (e.g. h5py)?
[x] requirements.txt (build)
[x] requirements-tests.txt (see SIRF#69)
[ ] requirements-runtime.txt
Note that USE_SYSTEM_*:

halves image size (4GB -> 2GB, and compressed size ~ a CD)
reduces build time

[x] add STIR-exercises and full STIR build as per https://github.com/CCPPETMR/CCPPETMR_VM/blob/master/scripts/update_VM_to_full_STIR.sh
[ ] Travis: address #37

[ ] ccache?
[ ] docker?

[ ] cache docker layers?

[ ] travis_wait

I don't think STIR-exercises should be a sub-project here. we could add it as an optional external-project maybe, but not more.


formatting on nvalt (for mac) is not saved when synch with simplenote (for android)

If I format part of a note (ex: bold) on nvalt (2.2.7) on my mac (OS 10.12.6), and activate synchronization with simplenote on my android (7), the formatting is not saved: neither on my mac, nor on my android.
If synch is turned off, the formatting is saved.

I'm not a coder, but I've been using these two in sync for years, and have just accepted that this is the reality. Simplenote wipes the formatting. I don't think there's anything you can do about it, except not use formatting.


chore: Use MegaLinter

This might not work right away...

For info, if this is merged and works well, we could consider also using it for chezmoi, given that the repo contains Go/Markdown/Python/PowerShell/Shell/YAML/etc. files.

I'd rather configure individual linters than use MegaLinter. Reasons:

We can update individual linters more easily, instead of having to wait for MegaLinter bulk updates. It's easier to stay on top of multiple small changes than a few, occasional large ones.
Totally subjective, but MegaLinter is just so terribly ugly. Its config files, its output, its interface... It makes my eyes hurt.
 Would you prefer if rework this PR to use individual linters?
The markdown linter is there because I have some (rough) initial documentation ready.

Would you prefer if rework this PR to use individual linters?

Yes please!
Also, please consider adding the Markdown linters to twpayne/chezmoi.


scrolling month and year at a time picker getting freez

@gusparis  i tested the picker in different ways, it was getting freeze,
when i start scrolling the date and year same time, after some time application getting closed
can you help me in it to fix this issue.
Thanks

@nani0531 Hello! Platform?

@nani0531 Hello! Platform?

@gusparis android

@gusparis android

Because of the way it is implemented, it is possible for that to happen. Who scrolls both pickers at the same time anyway? 🤔

Because of the way it is implemented, it is possible for that to happen. Who scrolls both pickers at the same time anyway? 🤔

Let me review it.

Let me review it.

:tada: This issue has been resolved in version 1.6.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: