[$250] Opening Two-Factor Authentication settings causes two duplicate API requests for EnableTwoFactorAuth

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.24-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tgolen
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1724704755405909
Action Performed:

Go to staging.new.expensify.com
Click Account settings > Security > Two Factor authentication setting

Expected Result:
No duplicate calls API calls
Actual Result:
Two duplicate API requests for EnableTwoFactorAuth
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/3743ae8c-483d-4d12-b03e-37032fff6aec

Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0184daf84295192016
Upwork Job ID:<PHONE_NUMBER>978232742
Last Price Increase: 2024-09-04

Issue OwnerCurrent Issue Owner: @mollfpr

Thanks for the investigation @Nodebrute. I think the thing that I really dislike about that is now dev is a very different environment than production, which makes testing and development much more difficult. We are being forced into some weird patterns (using a bunch of useRef) to try and get development to work more like we expect production to work.
Do you know if React is planning to make production work in this concurrent mode like dev is running in? I guess that would return it to an apples-to-apples situation at some point, which is better, but I really don't like having to guess "does this only happen in dev or not".
I'm going to assign this to external and get a C+ to review your proposal to implement (because even though it only happens in dev, it messed me up enough that I think it's worth fixing).

@mollfpr Are you OK with the proposal here? I think it's OK to move forward with.

@mollfpr bump on the above?

Sorry for the delay!

Are you OK with the proposal https://github.com/Expensify/App/issues/48034#issuecomment-2311238332? I think it's OK to move forward with.

@tgolen The issue seems to affect other pages for example OpenReport and OpenInitialSettingsPage . I'm onboard if we decide to specifically fix the issue for this 2FA page.
Also, the solution doesn't fix your issue here https://github.com/Expensify/App/pull/48030#issuecomment-2321849748.

Also, the solution doesn't fix your issue here https://github.com/Expensify/App/pull/48030#issuecomment-2321849748.

OK, thanks!

@tgolen The issue seems to affect other pages for example OpenReport and OpenInitialSettingsPage .

@mollfpr The issue affects any API calls made within useEffect because Strict Mode runs effects twice. To ensure consistency between production and development, we can turn off Strict Mode.

OK, that is a bit unfortunate. Maybe we should discuss this on Slack in the open-source channel?

I started a conversation about it in Slack here.

Thanks for doing that, @tgolen! 🙌

It looks like the discussion in Slack may still be ongoing.

@mollfpr I haven't been able to follow the discussion very closely. Do you feel we've come to a conclusion? If so, can you summarize where we've landed?

I haven't been able to follow the discussion very closely. Do you feel we've come to a conclusion? If so, can you summarize where we've landed?

We haven't had any conclusion yet, but we might have a holistic solution to fix this issue. I think it's better to move this issue weekly/monthly and I'll keep visiting the thread.

I think there was enough support internally for disabling strict mode by default until there is a more clear problem statement and project detailing what is expected to be gained from having strict mode enabled.
@Nodebrute Can you please update your proposal and I'll go ahead and assign this to you.

Waiting on QA to test the fix. @tgolen, it looks like Applause is asking on the PR which URL should be used for staging. Can you let them know?

I have replied to the question.

@johncschuster I think we can use the date for this issue https://github.com/Expensify/App/issues/48791 closed. It's 11th September.

Payment Summary:
Contributor: @Nodebrute paid $250 via Upwork - PAID
Contributor+: @mollfpr due $250 via NewDot
Upwork job here! Please apply
@mollfpr can you please provide regression test steps if they are necessary?

@johncschuster I think we don't need a regression step since it's only affecting the development side and it's knowingly a feature from React but we happen not to need it yet.

Ok great! Thanks for clarifying that! Please request payment!

$250 approved for @mollfpr


Tweak ClassToAPI.classCanonicalName

Builds on the spec defined in #380, proposing a change in behaviour.

So I was wondering. Is there any particular reason we're trying so hard to name the given class when we get a malformed class name error? What's wrong with Class.getName?

I'll come back to this on Wednesday. I'm on vacation for now.

To validate this pull request against other sbt modules, please visit this link.

I think we should clarify if we want a fully qualified name (String that is able to identify a type) or a real canonical name (one and only name name that identifies a type).
https://docs.oracle.com/javase/specs/jls/se8/html/jls-6.html#jls-6.7:

The difference between a fully qualified name and a canonical name can be seen in code such as:
package p;
class O1 { class I {} }
class O2 extends O1 {}

Both p.O1.I and p.O2.I are fully qualified names that denote the member class I, but only p.O1.I is its canonical name.

For the purpose of extracting API Info, I'm guessing that fully qualified name is ok.

@eed3si9n That's interesting info, thank you. However I'm left confused - could you clarify what change exactly are you suggesting, please?

Here's a straw-man table to simplify the situation. Correct me if I the values are wrong here:

Canonical
Fully qualified

Scala support
No really?
Yes

Needed for API extraction
No?
Yes

Backward compat
Yes
Maybe?

We've already shipped of the name extraction using canonical name, but for the one problematic ones we can fall back to fully qualified name, I guess is gist of my argument.


refactor(throttle): remove tryCatch/errorObject

This change is same kind of #1251.
I have not benchmarked this yet. So this is purely refactoring to unify code style.

The current codebase does not have any benchmark about throttle().
throttle() suppress the value traffic. How do we benchmark this without a throughput benchmark?

Can you flatten the first two commits? There's no reason for them to be separate, really. They're just TypeScript fixes.

I added the micro perf benchmars for throttle() ( https://github.com/saneyuki/RxJS/commit/8963abb98f305c39ff9b5d84a1224436f7c01a0d ), but RxJS v4 does not accept Observable<T> as a durationSelector (see also #1321). So we should only watch the v5's result.
(Should we really add this benchmark to the tree?)
These are results of benchmarks (this table drops v4's results):
Before this pull request
                                         |             RxJS 5.0.0-beta.1 |
----------------------------------------------------------------------------
                    throttle - immediate |                38,030 (±2.18%) |
                                throttle |                32,392 (±5.58%) |

My first patch
                                         |             RxJS 5.0.0-beta.1 |
----------------------------------------------------------------------------
                    throttle - immediate |                45,254 (±1.21%) |
                                throttle |                33,630 (±3.33%) |

@blesh's proposal
                                         |             RxJS 5.0.0-beta.1 |
----------------------------------------------------------------------------
                    throttle - immediate |                58,980 (±5.69%) |
                                throttle |                41,971 (±5.14%) |

By these results, @blesh's suggestion is right!

@kwonoj
updated :)
And, I add some comments which explain why we cannot compare with v4's throttle(durationSelector)  to https://github.com/saneyuki/RxJS/commit/6060977541430ec3ccd3b30a84ad18af4169e479.

Merged with 7bae860, thanks @saneyuki !


clippy: Fix remaining doc_markdown lints.

This and #508 are preparing the way for another PR, so no need to have these add additional #![warn(...)] stuff.


Asp.net Core not Collecting Garbage

Copied from https://github.com/aspnet/Home/issues/1976
@Pinox commented on Mar 31, 2017
@zorthgo  Yes I have also seen this. Was using servicestack in my .net core console app and every time i make a call to the api the memory usage increased by massive amounts 50mb.  I assumed it was a VS2017 bug but then confirmed the high usage in the task manager.  As zorthgo stated by just making simple calls to api the memory usage increase significantly and does not seem to release memory.
@Pinox commented on Mar 31, 2017
In my instance I i was using only target framework .NetCoreApp 1.1 and my console app was referencing an object model in a shared project.
@Pinox commented on Mar 31, 2017
Not sure if this will help anyone. a sample app that calls hellorequest. In this app the startup memory is 85mb , then by repetitive request i managed to push up the memory use to about 145mb. It falls back sometimes to 125mb but then stays there. Not sure if this is normal behavior as I'm not used to .Net Core console apps. i always assumed I was doing something wrong or not instantiating correctly.
https://drive.google.com/open?id=0B0Gm-m-z_U84TU5keWFTMzc1ZWc
@davidfowl commented on Apr 7, 2017
Did anybody take a memory dump and look at what is taking up all of the memory in your particular applications?
@ikourfaln commented on Apr 7, 2017
@davidfowl  @Pinox
I'm working on a big company, and we want to start a new project with ASP.NET Core, But when I saw this issue, I was afraid :worried: . this is a critical issue and can block lifecycle of our project.
So please, is it related to ASP.NET Core or .NET Core (CoreCLR) ? we will target Full .NET (4.6) that's why I'm asking.
@Pinox commented on Apr 7, 2017
@ikourfaln in my case I was using  .net core console app , servicestack (.net core version)  and kestrel. The weird thing is the memory use goes up to a level , then it stops suddenly and it does not go up again.  I guess best is to test it on your side with small sample and check behaviour.
Perhaps @zorthgo can check on his side if he sees similiar behaviour in that memory is used to a certain level and then stops increasing as that is the behaviour that I'm seeing.  I have updated my sample app to include @zorthgo  example and I dont see the memory running away. It goes up but eventually stops.
I did change the source slightly:
public object Any(TestGC request)
{
const string message = "TEST";
return Enumerable.Repeat(message, 100000);
}
@ikourfaln commented on Apr 8, 2017
@Pinox
Thank you, I will check behavior on my side.

@Pinox
Can I assume there is no more issue on your side and close this issue?


Flutter web cannot run on chrome

Steps to reproduce

Create a new project
Run Flutter Web

Expected results
Open on Chrome
Actual results
Launching lib/main.dart on Chrome in debug mode...
../../flutter/packages/flutter/lib/src/widgets/router.dart:758:6: Error: Expected a class member, but got ';'.
    };
     ^
../../flutter/packages/flutter/lib/src/widgets/router.dart:816:1: Error: Expected a declaration, but got '}'.
}
^
../../flutter/packages/flutter/lib/src/widgets/router.dart:592:7: Error: The non-abstract class '_RouterState' is missing implementations for
these members:
 - State.build
Try to either
 - provide an implementation,
 - inherit an implementation from a superclass or mixin,
 - mark the class as abstract, or
 - provide a 'noSuchMethod' implementation.

class _RouterState<T> extends State<Router<T>> with RestorationMixin {
      ^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/framework.dart:1467:10: Context: 'State.build' is defined here.
  Widget build(BuildContext context);
         ^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:754:7: Error: 'await' isn't a type.
      await delegateRouteSetter()(data);
      ^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:754:13: Error: Expected ';' after this.
      await delegateRouteSetter()(data);
            ^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:752:9: Error: A value must be explicitly returned from a non-void function.
        return;
        ^
../../flutter/packages/flutter/lib/src/widgets/router.dart:754:34: Error: The method 'call' isn't defined for the class '()'.
Try correcting the name to the name of an existing method, or defining a method named 'call'.
      await delegateRouteSetter()(data);
                                 ^
../../flutter/packages/flutter/lib/src/widgets/router.dart:754:35: Error: The getter 'data' isn't defined for the class '_RouterState<T>'.
 - '_RouterState' is from 'package:flutter/src/widgets/router.dart' ('../../flutter/packages/flutter/lib/src/widgets/router.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'data'.
      await delegateRouteSetter()(data);
                                  ^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:750:19: Error: A non-null value must be returned since the return type 'Future<void>
Function(T)' doesn't allow null.
 - 'Future' is from 'dart:async'.
  _RouteSetter<T> _processParsedRouteInformation(Object? transaction, ValueGetter<_RouteSetter<T>> delegateRouteSetter) {
                  ^
../../flutter/packages/flutter/lib/src/widgets/router.dart:762:5: Error: Setter not found: '_routeParsePending'.
    _routeParsePending = true;
    ^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:763:30: Error: Undefined name 'widget'.
    _processRouteInformation(widget.routeInformationProvider!.value, () => widget.routerDelegate.setNewRoutePath);
                             ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:763:76: Error: Undefined name 'widget'.
    _processRouteInformation(widget.routeInformationProvider!.value, () => widget.routerDelegate.setNewRoutePath);
                                                                           ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:763:5: Error: Method not found: '_processRouteInformation'.
    _processRouteInformation(widget.routeInformationProvider!.value, () => widget.routerDelegate.setNewRoutePath);
    ^^^^^^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:767:5: Error: Setter not found: '_currentRouterTransaction'.
    _currentRouterTransaction = Object();
    ^^^^^^^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:768:12: Error: Undefined name 'widget'.
    return widget.routerDelegate
           ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:770:38: Error: Undefined name '_currentRouterTransaction'.
      .then<bool>(_handleRoutePopped(_currentRouterTransaction));
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:775:26: Error: Undefined name '_currentRouterTransaction'.
      if (transaction != _currentRouterTransaction) {
                         ^^^^^^^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:786:5: Error: Method not found: 'setState'.
    setState(() {/* routerDelegate is ready to rebuild */});
    ^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:787:5: Error: Method not found: '_maybeNeedToReportRouteInformation'.
    _maybeNeedToReportRouteInformation();
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:792:5: Error: Method not found: 'setState'.
    setState(() {/* routerDelegate wants to rebuild */});
    ^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:793:5: Error: Method not found: '_maybeNeedToReportRouteInformation'.
    _maybeNeedToReportRouteInformation();
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:799:15: Error: Undefined name 'bucket'.
      bucket: bucket,
              ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:801:35: Error: Undefined name 'widget'.
        routeInformationProvider: widget.routeInformationProvider,
                                  ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:802:31: Error: Undefined name 'widget'.
        backButtonDispatcher: widget.backButtonDispatcher,
                              ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:803:33: Error: Undefined name 'widget'.
        routeInformationParser: widget.routeInformationParser,
                                ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:804:25: Error: Undefined name 'widget'.
        routerDelegate: widget.routerDelegate,
                        ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:805:22: Error: Expected identifier, but got 'this'.
        routerState: this,
                     ^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:811:20: Error: Undefined name 'widget'.
          builder: widget.routerDelegate.build,

Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        // This is the theme of your application.
        //
        // TRY THIS: Try running your application with "flutter run". You'll see
        // the application has a purple toolbar. Then, without quitting the app,
        // try changing the seedColor in the colorScheme below to Colors.green
        // and then invoke "hot reload" (save your changes or press the "hot
        // reload" button in a Flutter-supported IDE, or press "r" if you used
        // the command line to start the app).
        //
        // Notice that the counter didn't reset back to zero; the application
        // state is not lost during the reload. To reset the state, use hot
        // restart instead.
        //
        // This works for code too, not just values: Most code changes can be
        // tested with just a hot reload.
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  // This widget is the home page of your application. It is stateful, meaning
  // that it has a State object (defined below) that contains fields that affect
  // how it looks.

  // This class is the configuration for the state. It holds the values (in this
  // case the title) provided by the parent (in this case the App widget) and
  // used by the build method of the State. Fields in a Widget subclass are
  // always marked "final".

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      // This call to setState tells the Flutter framework that something has
      // changed in this State, which causes it to rerun the build method below
      // so that the display can reflect the updated values. If we changed
      // _counter without calling setState(), then the build method would not be
      // called again, and so nothing would appear to happen.
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    // This method is rerun every time setState is called, for instance as done
    // by the _incrementCounter method above.
    //
    // The Flutter framework has been optimized to make rerunning build methods
    // fast, so that you can just rebuild anything that needs updating rather
    // than having to individually change instances of widgets.
    return Scaffold(
      appBar: AppBar(
        // TRY THIS: Try changing the color here to a specific color (to
        // Colors.amber, perhaps?) and trigger a hot reload to see the AppBar
        // change color while the other colors stay the same.
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        // Here we take the value from the MyHomePage object that was created by
        // the App.build method, and use it to set our appbar title.
        title: Text(widget.title),
      ),
      body: Center(
        // Center is a layout widget. It takes a single child and positions it
        // in the middle of the parent.
        child: Column(
          // Column is also a layout widget. It takes a list of children and
          // arranges them vertically. By default, it sizes itself to fit its
          // children horizontally, and tries to be as tall as its parent.
          //
          // Column has various properties to control how it sizes itself and
          // how it positions its children. Here we use mainAxisAlignment to
          // center the children vertically; the main axis here is the vertical
          // axis because Columns are vertical (the cross axis would be
          // horizontal).
          //
          // TRY THIS: Invoke "debug painting" (choose the "Toggle Debug Paint"
          // action in the IDE, or press "p" in the console), to see the
          // wireframe for each widget.
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headlineMedium,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
 flutter run -d chrome
Launching lib/main.dart on Chrome in debug mode...
../../flutter/packages/flutter/lib/src/widgets/router.dart:758:6: Error: Expected a class member, but got ';'.
    };
     ^
../../flutter/packages/flutter/lib/src/widgets/router.dart:816:1: Error: Expected a declaration, but got '}'.
}
^
../../flutter/packages/flutter/lib/src/widgets/router.dart:592:7: Error: The non-abstract class '_RouterState' is missing implementations for
these members:
 - State.build
Try to either
 - provide an implementation,
 - inherit an implementation from a superclass or mixin,
 - mark the class as abstract, or
 - provide a 'noSuchMethod' implementation.

class _RouterState<T> extends State<Router<T>> with RestorationMixin {
      ^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/framework.dart:1467:10: Context: 'State.build' is defined here.
  Widget build(BuildContext context);
         ^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:754:7: Error: 'await' isn't a type.
      await delegateRouteSetter()(data);
      ^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:754:13: Error: Expected ';' after this.
      await delegateRouteSetter()(data);
            ^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:752:9: Error: A value must be explicitly returned from a non-void function.
        return;
        ^
../../flutter/packages/flutter/lib/src/widgets/router.dart:754:34: Error: The method 'call' isn't defined for the class '()'.
Try correcting the name to the name of an existing method, or defining a method named 'call'.
      await delegateRouteSetter()(data);
                                 ^
../../flutter/packages/flutter/lib/src/widgets/router.dart:754:35: Error: The getter 'data' isn't defined for the class '_RouterState<T>'.
 - '_RouterState' is from 'package:flutter/src/widgets/router.dart' ('../../flutter/packages/flutter/lib/src/widgets/router.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'data'.
      await delegateRouteSetter()(data);
                                  ^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:750:19: Error: A non-null value must be returned since the return type 'Future<void>
Function(T)' doesn't allow null.
 - 'Future' is from 'dart:async'.
  _RouteSetter<T> _processParsedRouteInformation(Object? transaction, ValueGetter<_RouteSetter<T>> delegateRouteSetter) {
                  ^
../../flutter/packages/flutter/lib/src/widgets/router.dart:762:5: Error: Setter not found: '_routeParsePending'.
    _routeParsePending = true;
    ^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:763:30: Error: Undefined name 'widget'.
    _processRouteInformation(widget.routeInformationProvider!.value, () => widget.routerDelegate.setNewRoutePath);
                             ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:763:76: Error: Undefined name 'widget'.
    _processRouteInformation(widget.routeInformationProvider!.value, () => widget.routerDelegate.setNewRoutePath);
                                                                           ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:763:5: Error: Method not found: '_processRouteInformation'.
    _processRouteInformation(widget.routeInformationProvider!.value, () => widget.routerDelegate.setNewRoutePath);
    ^^^^^^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:767:5: Error: Setter not found: '_currentRouterTransaction'.
    _currentRouterTransaction = Object();
    ^^^^^^^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:768:12: Error: Undefined name 'widget'.
    return widget.routerDelegate
           ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:770:38: Error: Undefined name '_currentRouterTransaction'.
      .then<bool>(_handleRoutePopped(_currentRouterTransaction));
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:775:26: Error: Undefined name '_currentRouterTransaction'.
      if (transaction != _currentRouterTransaction) {
                         ^^^^^^^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:786:5: Error: Method not found: 'setState'.
    setState(() {/* routerDelegate is ready to rebuild */});
    ^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:787:5: Error: Method not found: '_maybeNeedToReportRouteInformation'.
    _maybeNeedToReportRouteInformation();
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:792:5: Error: Method not found: 'setState'.
    setState(() {/* routerDelegate wants to rebuild */});
    ^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:793:5: Error: Method not found: '_maybeNeedToReportRouteInformation'.
    _maybeNeedToReportRouteInformation();
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:799:15: Error: Undefined name 'bucket'.
      bucket: bucket,
              ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:801:35: Error: Undefined name 'widget'.
        routeInformationProvider: widget.routeInformationProvider,
                                  ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:802:31: Error: Undefined name 'widget'.
        backButtonDispatcher: widget.backButtonDispatcher,
                              ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:803:33: Error: Undefined name 'widget'.
        routeInformationParser: widget.routeInformationParser,
                                ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:804:25: Error: Undefined name 'widget'.
        routerDelegate: widget.routerDelegate,
                        ^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:805:22: Error: Expected identifier, but got 'this'.
        routerState: this,
                     ^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:811:20: Error: Undefined name 'widget'.
          builder: widget.routerDelegate.build,

Flutter Doctor output
Doctor output
flutter doctor -v
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.5 23F79 darwin-arm64, locale en-KH)
    • Flutter version 3.22.2 on channel stable at /Users/king/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (3 weeks ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/king/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/king/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.90.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.90.0

[✓] Connected device (4 available)
    • iPhone 15 Pro Max (mobile)      • AD8B9609-6709-4BA7-8123-DF988E3ECC9A • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-4
      (simulator)
    • macOS (desktop)                 • macos                                • darwin-arm64   • macOS 14.5 23F79 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                • darwin         • macOS 14.5 23F79 darwin-arm64
    • Chrome (web)                    • chrome                               • web-javascript • Google Chrome 126.0.6478.127

[✓] Network resources
    • All expected network resources are available.

• No issues found!

@lexermekongnet
I tried the same by creating new Flutter project using latest stable and ran in chrome which compiled, built and rendered the app properly as below without throwing any log:

The log you shared seems to be pointing to router.dart file

../../flutter/packages/flutter/lib/src/widgets/router.dart:793:5: Error: Method not found: '_maybeNeedToReportRouteInformation'.
    _maybeNeedToReportRouteInformation();
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../flutter/packages/flutter/lib/src/widgets/router.dart:799:15: Error: Undefined name 'bucket'.
      bucket: bucket,
              ^^^^^^

Please check the flutter sdk you have to confirm if you see above elements present in it or not. That way we would know if it due to corrupt sdk or any other issue at your end.

I ended up re-installing my flutter sdk and it works can be closed


Question about paper

Thank you for your great work.
I would like to know
1.What's the meaning of Fake Batch Embeddings？Is there any difference between real batch embedding and fake ones?
2.What memory cost of CGAN?

And how long does the generator generate a prompt?


new tag request

can we please have a new tag, the last one was Oct 2, 2013 and lots of new pull request were made in the meantime

Oh damn yeah, I think I have forgotten about it. I'll 0.3.0 it.

Done.


6.0 missing in CHANGELOG

Hello!  I'm trying to see what changes come with 6.0, but it's not included in CHANGELOG.md.  Any chance of updating that for clarity?  Thanks!

@mhuggins please feel free to send a PR


Create fixtures

When running the fixtures for a test app it would be nice to have a few pixels created

Fixed at #36 (e0ea099)


[chains] Cycle httpx clients every 8h and upgrade poetry version.

:rocket: What

:computer: How

:microscope: Testing

looks good. were you able to test this manually? if so could you write out in the PR description how?
One more thing -- in a higher-concurrency environment, the second that the client "expires", every request will concurrently create a new httpx.Client. This is not particularly expensive, (and should be fine) right?

Good observation, I think I'll make an async lock around the re-creation.


Named analyzers and better error handling

When the SDK runs analyzers, it swallows all errors making it impossible for FSAC to know which analyzer is problematic and makes troubleshooting harder. This PR addresses this issue by allowing the analyzers to be (optionally) named via the attribute like this [<Analuzer "AnalyzerName">]. I added a new function to run the analyzers of this signature:
val runAnalyzersSafely : Context -> AnalysisResult list

Where each AnalysisResult is the result of each registered analyzer and is defined as follows:
type AnalysisResult = {
  AnalyzerName : string
  Output : Result<Message list, exn>
}

This way, we will be able to identify which analyzer wasn't able to run successfully and why (cc @baronfel)
This is also preparation for fixing #8 which required the analyzers to be named.

Thanks.


Documentation for Strict Environments

@gsoltis took another pass. feel free to make edits and merge if the time is right


Change the text alignment on Google Calendar

When I enable the PaperMemory extension on Google Chrome, my Google Calendar will be Changed. Specifically, the text of the name of the calendar will not be well-aligned.

Hey!
I thought I had fixed this in #86 which is part of the 0.5.3 release.
Can you tell me the PaperMemory version you're using and if it's not the latest can you update and check the problem persists?

I'm going to assume this is not an issue anymore and there was a lag in the auto-update of the extension. Feel free to re-open if the problem persists


Add support for cri-dockerd

Since Kubernetes 1.24, dockershim.sock has been replaced
with cri-dockerd.sock (and similar npipe, for Windows)
What type of PR is this?
/kind feature
What this PR does / why we need it:
detect the "docker" runtime, after moving from dockershim to external endpoint
https://github.com/Mirantis/cri-dockerd
https://kubernetes.io/docs/setup/production-environment/container-runtimes/
Which issue(s) this PR fixes:
Fixes #868
Special notes for your reviewer:
Does this PR introduce a user-facing change?
detect cri-dockerd socket, after dockershim removal

@afbjorklund thanks for adding this.


Build Issue

when click the auth and click Login V1 there is a this error..
Warning: Failed prop type: Invalid props.style key fontSize supplied to View.
Bad object: {
"flexDirection": "row",
"borderBottomWidth": 1,
"borderBottomColor": "#0000003B",
"marginVertical": 9,
"backgroundColor": "#ffffff",
"borderRadius": 100,
"borderWidth": 1,
"borderColor": "#0000003B",
"fontSize": 16.07142857142857,
"opacity": 1
}
Valid keys: [
"display",
"width",
"height",
"start",
"end",
"top",
"left",
"right",
"bottom",
"minWidth",
"maxWidth",
"minHeight",
"maxHeight",
"margin",
"marginVertical",
"marginHorizontal",
"marginTop",
"marginBottom",
"marginLeft",
"marginRight",
"marginStart",
"marginEnd",
"padding",
"paddingVertical",
"paddingHorizontal",
"paddingTop",
"paddingBottom",
"paddingLeft",
"paddingRight",
"paddingStart",
"paddingEnd",
"borderWidth",
"borderTopWidth",
"borderStartWidth",
"borderEndWidth",
"borderRightWidth",
"borderBottomWidth",
"borderLeftWidth",
"position",
"flexDirection",
"flexWrap",
"justifyContent",
"alignItems",
"alignSelf",
"alignContent",
"overflow",
"flex",
"flexGrow",
"flexShrink",
"flexBasis",
"aspectRatio",
"zIndex",
"direction",
"shadowColor",
"shadowOffset",
"shadowOpacity",
"shadowRadius",
"transform",
"transformMatrix",
"decomposedMatrix",
"scaleX",
"scaleY",
"rotation",
"translateX",
"translateY",
"backfaceVisibility",
"backgroundColor",
"borderColor",
"borderTopColor",
"borderRightColor",
"borderBottomColor",
"borderLeftColor",
"borderStartColor",
"borderEndColor",
"borderRadius",
"borderTopLeftRadius",
"borderTopRightRadius",
"borderTopStartRadius",
"borderTopEndRadius",
"borderBottomLeftRadius",
"borderBottomRightRadius",
"borderBottomStartRadius",
"borderBottomEndRadius",
"borderStyle",
"opacity",
"elevation"
]
in View (at createAnimatedComponent.js:134)
in AnimatedComponent (at TouchableOpacity.js:245)
in TouchableOpacity (at rkTextInput.js:184)
in RkTextInput (at login1.js:64)
in RCTView (at View.js:112)
in View (at login1.js:52)
in RCTView (at View.js:112)
in View (at createAnimatedComponent.js:134)
in AnimatedComponent (at rkAvoidKeyboard.js:77)
in RkAvoidKeyboard (at login1.js:47)
in LoginV1 (at rkThemeProvider.js:41)
in ThemeProvider (at SceneView.js:31)
in SceneView (at CardStack.js:412)
in RCTView (at View.js:112)
in View (at CardStack.js:411)
in RCTView (at View.js:112)
in View (at CardStack.js:410)
in RCTView (at View.js:112)
in View (at createAnimatedComponent.js:134)
in AnimatedComponent (at Card.js:26)
in Card (at PointerEventsContainer.js:55)
in Container (at CardStack.js:454)
in RCTView (at View.js:112)
in View (at CardStack.js:383)
in RCTView (at View.js:112)
in View (at CardStack.js:382)
in CardStack (at CardStackTransitioner.js:97)
in RCTView (at View.js:112)
in View (at Transitioner.js:192)
in Transitioner (at CardStackTransitioner.js:49)
in CardStackTransitioner (at StackNavigator.js:60)
in Unknown (at createNavigator.js:52)
in Navigator (at createNavigationContainer.js:212)
in NavigationContainer (at SceneView.js:31)
in SceneView (at DrawerScreen.js:40)
in DrawerScreen (at withCachedChildNavigation.js:66)
in withCachedChildNavigation(DrawerScreen) (at DrawerNavigator.js:106)
in Unknown (at createNavigator.js:52)
in Navigator (at DrawerView.js:215)
in RCTView (at View.js:112)
in View (at createAnimatedComponent.js:134)
in AnimatedComponent (created by DrawerLayout)
in RCTView (at View.js:112)
in View (created by DrawerLayout)
in DrawerLayout (at DrawerView.js:195)
in DrawerView (at DrawerNavigator.js:127)
in Unknown (at createNavigator.js:52)
in Navigator (at createNavigationContainer.js:212)
in NavigationContainer (at SceneView.js:31)
in SceneView (at CardStack.js:423)
in RCTView (at View.js:112)
in View (at createAnimatedComponent.js:134)
in AnimatedComponent (at Card.js:26)
in Card (at PointerEventsContainer.js:55)
in Container (at CardStack.js:454)
in RCTView (at View.js:112)
in View (at CardStack.js:383)
in RCTView (at View.js:112)
in View (at CardStack.js:382)
in CardStack (at CardStackTransitioner.js:97)
in RCTView (at View.js:112)
in View (at Transitioner.js:192)
in Transitioner (at CardStackTransitioner.js:49)
in CardStackTransitioner (at StackNavigator.js:60)
in Unknown (at createNavigator.js:52)
in Navigator (at createNavigationContainer.js:212)
in NavigationContainer (at app.js:86)
in RCTView (at View.js:112)
in View (at app.js:85)
in App (at registerRootComponent.js:35)
in RootErrorBoundary (at registerRootComponent.js:34)
in ExpoRootComponent (at renderApplication.js:35)
in RCTView (at View.js:112)
in View (at AppContainer.js:102)
in RCTView (at View.js:112)
in View (at AppContainer.js:122)
in AppContainer (at renderApplication.js:34)

node_modules/fbjs/lib/warning.js:33:20 in printWarning
... 19 more stack frames from framework internals

Hello @cumali-demir.
It's not error. This is warning. And this is duplicate of #53


Add playsInline attribute on the video element

Fixes #7357

Just checking - has this been tested on an actual iOS device?

Not yet... but maybe @Malvoz can help to test it...

@donnisnoni I don't own an iOS device (I just made the observation and reported on the potential requirement), sorry.

Well, even though the code looks good (thanks @donnisnoni for sending the PR), I'd rather not merge until it has been tested (and I don't have a iOS device either)


Include permissions

We should start to include permissions. A canViewForum has been included but there are several others:

[x] canPostTopics
[x] canReply
[x] canOnlySeeOwnTopics
[x] canAddPolls
[x] canEditPolls
[x] canEditOwnPolls
[x] canVoteInPolls
[x] canViewProfiles
[x] canUseCustomTitle
[x] canUploadAvatar
[x] canViewWhosOnline
[x] canViewMemberlist
[ ] canViewTopics
[ ] canOnlyReplyToOwnTopics
[ ] canUseParsingCode (markdown and mycode)
[ ] canUseImageCode
[ ] canUseVideoCode
[ ] canUseMeCode
[ ] more existing parsing permissions

Moderation permissions should be included in that PR (eg canSeeDeletedPosts).

@JN-Jones @euantorano As of 5.1.11, Laravel introduces an Authorization system based on abilities using a Gate before requests and a policies implementation, IMHO it'd be great to extend the native Authorization system from Laravel, see here

Yes, we know about this and the plan is to migrate the system to use this. The default implementation in Laravel is slightly lacking, so we'll be expanding upon it significantly.


Allow user to provide runtime to client_factory

Problem description
Right now the client factory creates its own runtime. However the user may already be running inside of one. In which case they should be able to supply it.
Problem location
Client_factory
Suggestions for an improvement
Add a new constructor method.

Fixed by above PR


Change Zenodo dataset icon color if figure is stale

If a figure was generated on CI from a Zenodo upload managed by showyourwork, make its color blue if the figure is up to date with the script that generated the dataset, and yellow if it is stale. This shouldn't be too hard to implement.

An easier thing to fix is the following: if a figure depends on a script and on a large Zenodo-hosted dataset, I don't think the GitHub Actions runner will re-execute the figure script to generate the figure unless the figure script itself changed since the last build. This is not ideal behavior, since the Zenodo deposit may have since changed (if the user re-ran the pipeline locally). We should always query Zenodo and look for newer versions of the deposit; if they exist, the figures should be re-run.


Bug: QA Date Errors

Issue:

User is experiencing the following error when entering dates:
Flow to Load Ref. End Date not accepting users selection "[TEST-4-B] - You reported a [endDate] of [2023-07-01], which is outside the range of acceptable values for this date for [Test Summary]."
This is happening in other QA Certs as well.
This error should only be firing if a user enters a date prior to 1993

Neither Moses or I could reproduce this bug - closing


nuke checking format blocking workfiles

if the format of asset is changed during production, then every new launch of script with already set format is poping up window that format already exists and is created new with _1 as hard-coded
next change the check is performed and want to add _1 again and block the process
workfile is not finished but not logging error

already solved in pype3 https://github.com/pypeclub/pype/pull/887

already solved in pype3 https://github.com/pypeclub/pype/pull/887


Found error in current tidyr cheatsheet

I frequently use this package and the connected cheatsheet.
Hence I found an error:
Chapter "Handling missing Values"
the first function is called "s()" and I suppose it should be the function "drop_na()"
Thanks for your great work and best regards

Duplicate of #336, fixed in https://github.com/rstudio/cheatsheets/commit/f17ddaae9b9fe2c9499265bda32e89482b932e22


3 high severity vulnerabilities

npm i llamaindex@latest
npm WARN deprecated<EMAIL_ADDRESS>This package has moved to @smithy/protocol-http
npm WARN deprecated<EMAIL_ADDRESS>This package has moved to @smithy/signature-v4
added 126 packages, changed 7 packages, and audited 1238 packages in 53s
3 high severity vulnerabilities
Some issues need review, and may require choosing
a different dependency.
Run npm audit for details.

Fixed in<EMAIL_ADDRESS>


[Angular] Can't get my global less file into storybook

Issue details
As I've read in several issues and merges Storybook's webpack loader automatically uses .angular-cli styles - correct?
In my current environment I need to use the following .angular-cli config for my global styles
  "styles": [
    "styles.less"
  ],
  "defaults": {
    "styleExt": "less",
    "component": {}
  }

I expected that my global less is getting imported by storybook
Steps to reproduce

Create an angular project
Add a styles.less / add it to your .angular-cli config
Create an angular component
Add it as a story

Please specify which version of Storybook and optionally any affected addons that you're running

"@ storybook/angular": "^3.3.13"

Screenshots / Screencast / Code Snippets (Optional)
// webpack.config.js
const genDefaultConfig = require('@storybook/angular/dist/server/config/defaults/webpack.config.js');

module.exports = (baseConfig, env) => {
    const config = genDefaultConfig(baseConfig, env);

    // Overwrite .css rule
    const cssRule = config.module.rules.find(rule => rule.test && rule.test.toString() === '/\\.css$/');
    if (cssRule) {
        cssRule.exclude = /\.component\.css$/;
    }

    // Add .scss rule
    config.module.rules.unshift({
        test: /\.less$/,
        loaders: ['raw-loader', 'less-loader'],
    });

    return config;
};

Yep. but in the alpha version. (3.4.something-alpha, take the latest).

Works great and as expected! Great work :)
I had to remove my webpack.config.js and do some configurations in the .angular-cli (I removed most of the properties since it's a library that does not necessarily depends on .angular-cli) - after that it just started.


Private fields which are never modified were made readonly

Done automatically by IDE, but occurrences were few, so reviewing it shouldn't be too daunting

/assign @ForNeVeR


Item Identification: Add Unfinished Potions option

Add a new option to the Item Identification plugin for unfinished potions and separate potions from unfinished potions.
Suggested here: https://github.com/runelite/runelite/issues/18204

Would it be better to close this and reopen it with one commit? Not sure why my IDE tabbed everything ever (cause of 2 of the commits).

Would it be better to close this and reopen it with one commit? Not sure why my IDE tabbed everything ever (cause of 2 of the commits).

I wouldn't create a new PR just for that. The commits can always be squashed.


⚠ Spryr has degraded performance

In 75bf35d, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 6418 ms

Resolved: Spryr performance has improved in e891498 after 10 minutes.


generated package names start with numbers if tag starts with a number

Describe the bug
See title.
To Reproduce
Generate a client from this Swagger: https://converter.swagger.io/api/convert?url=https://integration-www.tangocard.com/raas_api_console/v2/api-docs/swagger.json
The package names will start with a number and be un-importable.
Expected behavior
Number is dropped.
OpenAPI Spec File
https://converter.swagger.io/api/convert?url=https://integration-www.tangocard.com/raas_api_console/v2/api-docs/swagger.json

Thanks for reporting! I'll make sure to get this into the next release.

After some investigation, I'm going to fix this in the next breaking version. It's possible that the fix won't impact any already-valid names, but there is a chance some edge cases will be modified.


Detect Indentation from Content doesn't work

Issue Type
Bug
Description
I have an HTML file open, click on the Tab Size button in the taskbar. From the command pallette that pops open I choose Detect indentation from content. The tab size doesn't change (stays at 4). In my preferences I can see that HTML is supposed to be 2 tabs.
I have the same issue with a CSS file.
HTML worked once, CSS never worked.
VS Code Info
VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:34:36.336Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
AMD A8-4500M APU with Radeon(tm) HD Graphics    (4 x 1896)

Memory (System)
3.46GB (1.38GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

LiveServer
rit
3.2.1

@yoizfefisch Indentation is controlled via 3 settings:
  // When opening a file, `editor.tabSize` and `editor.insertSpaces` will be detected based on the file contents.
  "editor.detectIndentation": true,

  // Insert spaces when pressing Tab. This setting is overridden based on the file contents when `editor.detectIndentation` is on.
  "editor.insertSpaces": true,

  // The number of spaces a tab is equal to. This setting is overridden based on the file contents when `editor.detectIndentation` is on.
  "editor.tabSize": 4,

If you want all files to always have tabSize: 2, you must set:
"editor.detectIndentation": false,
"editor.tabSize": 2

editor.detectIndentation and the associated action, Detect Indentation From Content, means that the content (the text!) will be analyzed and tab settings that best match that content will be used. If the content uses mostly 4 spaces, tab size 4 will be chosen, as that would best match that content.


Update Package Description to 4.0 and Spectre version to 0.8.0

This replaces https://github.com/kylef/PathKit/pull/38 and should pass on CI

Looks like the test failure here is real 🤔

Thanks! ❤

A tag is planned with this ? If it's possible I would like to do the same things for the Stencil Package who depends of Pathkit ^^
And BTW obviously thx u for your work @kylef 👍


Retrieve ID from insert to DB

Hi!
I have this insert into the database:
user := new(User)
res, err := db.NamedExec("INSERT INTO users (email) VALUES (:email) RETURNING id", user)

And I'd like to get the ID of that record. I believe I'm using the RETURNING id incorrectly. Is this the correct way to do it via db.NamedExec? If not, what are the proper ways to do so?
Thanks!
@luiscvega

@jmoiron Hi
When the insert fails you still get the id returned. err is also nil.
How can you tell if the insert was not successful (e.g. due to a foreign key constraint)?

@jmoiron I am running into the same issue as @dontogbe - I am using NamedQuery() to insert values into a table such that a foreign key constraint is violated.
However, the error returned by NamedQuery() is nil, and the issue can only be caught when the transaction is being committed.
Is there a way for us to catch this error sooner?

As a reminder, for people using this method, don't forget to add
rows.Close()

to the end of the query before continuing, otherwise there would be idle sql connections hanging in the database, which may cause database unreachable.

Hi Luis,
Try using NamedQuery instead and scanning the resulting rows:
var id int
var user User
rows, err := db.NamedQuery("INSERT INTO users (email) VALUES (:email) RETURNING id", user)
// handle err
if rows.Next() {
    rows.Scan(&id)
}

You could also use a prepared named statement which you can then use Get with.
Hope this helps!


Recommend Additional RLS or Security Definer

Problem
Currently, anyone is able to modify the client side request to select every rows in the notes table.
Here is a minimal curl command to do so:
curl 'https://blablabla.supabase.co/rest/v1/notes?select=*' -H 'apikey: <insert-client-side-api-key>'

Proposed Solution
In most apps, there should be additional RLS to only allow users to query their own rows.
But since this is an app requiring no authenticated users, perhaps something like this StackOverFlow post could suffice as a solution? What do you think?

working on this now! thanks for pointing it out :)

just merged this change!


Done

Added a Q & A to a README from information found throughout the web

I think this information is better stored somewhere else than the README.

Do you mind if I ask where a more appropriate place would be for this?

A post on your personal blog, as this is almost entirely opinion.  Also, there are a bunch of spelling and grammar mistakes, and some of the answers seem to be cut short.

Besides that, "Done" is not a very good title for a pull request...


CUDA memory error while training with real data

Hello,
I would like to apply your model to my real dataset but with any size of data I am getting the following error, any idea how can I solve it?

RuntimeError: CUDA out of memory. Tried to allocate 4.23 GiB (GPU 0; 15.78 GiB total capacity; 11.67 GiB already allocated; 2.90 GiB free; 84.79 MiB cached)

Try reducing the batch size in run.sh


[terra-date-time-picker] Add support for time-input keyboard shortcuts

Summary
Adding initial support of time-input keyboard shortcuts of "N" (set time to now, if date is blank or invalid set date to today as well), "-" (decrement minute by 1, set date to today if no valid date and time to now if no valid time, then decrement), and "+" (increment minute by 1, set date to today if no valid date and time to now if no valid time, then increment).
Also includes some edge case fixing in time-input for increment and decrementing time in roll-over cases.

Closes #
Deployment Link

https://terra-framework-deployed-pr-#.herokuapp.com/
Testing

Additional Details

Thank you for contributing to Terra.
@cerner/terra

Functionally Reviewed


Feature: Add Treatment Discontinuation Report

Feature Details
More to be discussed:

Default the KRI to any discontinuation (excluding death).
Add table of all discontinuation reasons

c38764)

@jwildfire to add more specs

Updated spec to remove treatment stratification/filter. Focus instead on discontinuation reason/timing.

Not prioritized for development this year, so closing as won't fix for now. May re-visit down the road.


Linux kernel compatibility

First commit: drm_dev_unplug change fixes building with linux master but is not triggered as master's version is still 4.13, so it still fails on travis.
Second commit is based on daxtens work and fixes building against kernel 4.13
Third commit enables kerenls 4.12 and 4.13 building on travis

I can confirm @brandimarte

Thanks, a similar change has now been included.


Please upload an example dataset / metadata

Can you please upload the example colorado.csv you mention and the .json file metadata that you talk about during the setup.
Would like to try this out but can't find the example files you're talking about to test it.
Thanks.

@oregonpillow  Chi cerca trova! ;)
It should be the data linked from this page (did not try yet) look for "The Competitor Pack"
Ciao!

@oregonpillow did you find the colorado dataset?
In "The Competitior Pack"  mentioned above I only find an extract of 2016 data from the San Francisco Fire Department's Call for Service, used for the previous matches. However, for the final match the 1940 Colorado census is used, with a total of 98 fields, which I can't find on their site.
Thanks in advance.

The competitor pack available on Topcoder  website has the San Franscisco dataset which was used in Round 1 of the competition.
Provisional scoring of Round 3 Match used another Dataset from 1940 Colorado Census which is no longer available on the website , but you can download it from this link.


cloud experience host information

Cloud experience host related information was missing in the document. Required information has been added.
Problem: https://github.com/MicrosoftDocs/windows-itpro-docs/issues/3276

@nenonix @JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

@joinimran  - please merge the commit on the copy/edit review made by nenonix  or make the necessary changes on the PR following the suggestions made. Thank you.

Suggested changes have been applied. Ready to merge the content.

@DaniHalfin @mapalko - Can you please assist to check, approve and merge the content for this PR based on issue #3276?
Thank you.

@DaniHalfin @mapalko - I would like to follow up. Can you please assist to check, approve and merge the content for this PR based on issue #3276?
Thank you.

@joinimran - please review the comment of mapalko and make the necessary changes to this PR. Thank you.

@mapalko - Can you review and merge the content of this PR? I believe @joinimran already applied your suggested changes to the content. Thank you.

@mypil I approve of the change in content. I do not have merge rights, though. @DaniHalfin can you help merge this?


Issue / Progress Tracking

@kamejosh
@if14b038
Do we want to use Github Issues to keep track of our tasks, progress and problems (bugs) that we encounter on our way?
I've never tried Github features since we're using internally hosted repositories and more complex issue tracking systems at my company, but I think we could give it a go.

If yes, we should discuss in which language we'll write them.
As soon as that's decided we could start adding milestones (releases) and add the issues for milestone 1.

I tried working with this feature before, but most project were to small to benefit. But yes i'd like to try it, could enhance the whole project.

Wir haben beschlossen das wir das verwenden.


What is the license ?

Hi
The license section of the repo states that the license is MIT but the copyright header on top of the source files state that the license is BSD. What exactly is the license ?

Thanks for your feedback.
We are going to check the inconsistency problem of license that will be fixed later.

Also, Pink library used in Pika is GPL


bug fix

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #119 (095479a) into main (1304fd8) will decrease coverage by 1.14%.
The diff coverage is 28.57%.

@@             Coverage Diff              @@
##               main     #119      +/-   ##
============================================
- Coverage     65.42%   64.27%   -1.15%
+ Complexity     8406     8266     -140
============================================
  Files           421      421
  Lines         46526    46391     -135
  Branches       9455     9424      -31
============================================
- Hits          30441    29820     -621
- Misses        12438    12955     +517
+ Partials       3647     3616      -31

Impacted Files
Coverage Δ

...main/java/com/alibaba/fastjson2/JSONReaderStr.java
18.98% <28.57%> (-0.01%)
:arrow_down:

...n/java/com/alibaba/fastjson2/util/UnsafeUtils.java
30.18% <0.00%> (-49.06%)
:arrow_down:

...main/java/com/alibaba/fastjson2/util/JDKUtils.java
40.25% <0.00%> (-30.07%)
:arrow_down:

...va/com/alibaba/fastjson2/reader/ValueConsumer.java
16.66% <0.00%> (-16.67%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONReaderASCII.java
66.74% <0.00%> (-15.20%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONWriterUTF16.java
64.54% <0.00%> (-10.91%)
:arrow_down:

...java/com/alibaba/fastjson2/JSONWriterUTF8JDK9.java
73.41% <0.00%> (-8.87%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONWriterJSONB.java
52.04% <0.00%> (-5.95%)
:arrow_down:

.../main/java/com/alibaba/fastjson2/util/IOUtils.java
54.39% <0.00%> (-5.07%)
:arrow_down:

...baba/fastjson2/reader/FieldReaderObjectMethod.java
72.50% <0.00%> (-5.00%)
:arrow_down:

... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1304fd8...095479a. Read the comment docs.


chore(TwoSidedIdeal/Basic): apply forgotten review comments

After being delegated, I forgot to apply the suggestions from #13902 by @jcommelin ....

Thanks for following up! I have just one tiny question; would maintainer merge with that addressed.
Did you think about this part of jcommelin's comment?

Then you can use it in theproofs of sub_mem and nsmul_mem etc [...] this isn't very important

Thanks for following up! I have just one tiny question; would maintainer merge with that addressed. Did you think about this part of jcommelin's comment?

Then you can use it in theproofs of sub_mem and nsmul_mem etc [...] this isn't very important

Thanks for pointing this out. I have applied this suggestion as well!

Thanks!
bors merge


added support for null, not null

Hey, @Prekshagupta99 thanks for the contribution. There were some changes to the implementation, can you please upgrade your implementation? Post that I will merge.

Hey @ChakshuGautam, updated the code. Thanks.


KAFKA-13430: Remove broker-wide quota properties from the documentation

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@dajac Sure! Please have a look when you are free! :smile:

Merged to trunk and 3.1.


Disallow a conflicting draft editions

Currently, a publishing application can send a draft edition to Publishing API, which has the same base path as a live edition but with a different content ID.
This results in a valid draft edition being created in Publishing API.
However after this occurs, neither the original live edition with the original content ID or the draft edition can have a new edition created, as there will be a conflict in content IDs.
This updates the validation to disallow a draft edition with a different content ID if there is already a published edition at that base path.
Trello card

Closing as this causes issues with the pact tests.  Maybe there is a reason we permit draft editions that "take over" a base path, even if they have a different content ID?

Closing as this causes issues with the pact tests. Maybe there is a reason we permit draft editions that "take over" a base path, even if they have a different content ID?


problem with ImVehFt & GFXHack

all the other essential plugins are working properly, patches, asi plugins, mods, everything. except for GFXHack and Improved Vehicle Features. Soon as I install those, the .exe file launches after giving GFXHacl error Code: 988 if I'm not mistaken; then crashes when having loaded the game completely on Loading Screen. I have already tried reinstalling my game, Deleting the User Files, changing when I install either of those mods, etc. But the game still refuses to run properlly when having any of these two mods installed with CLEO V.5 Alpha.
thanks in advance.

Is working without GFXHack?

@answerix-core do you still have the issue? does it work if you install CLEO 4?

I tested SkyGFX recently and it works. GFXHack seems to start correct if not placed in ModLoader folder.
As @CanerKaraca23 mentioned vehicle features mod also works ok.


All endpoints to return "last_updated"

The /summary endpoint returns a "last_updated" value. It would be great if others (especially /reports) returned that value, as well. Specifically, I'm pulling Alberta data and looking for null values or zero length arrays to judge if the content is added for the current day (and popping the array if it isn't). It would be helpful to have that field instead.

I am considering a rework to last_updated to cover the data at least at province/health region level. Right now that timestamp is sitewide and based on when the report processing utility was last run.


feat: allow to override preconfigured options

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Create boilerplate Angular app for Agora

Lawrence and I met last week to generate an Angular app for Agora.

@sagely1 Let's document in this thread the generation of the app. The was also an error with Jest if I remember well: describe is not defined.


Announcement bar text being cut off

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
Announcement bar text is being cut off on some display sizes if the announcement is long enough.
View demo on codesandbox. In this example the bug will occur at a screen size of 997px.
Reproducible demo
https://codesandbox.io/s/blissful-currying-nqeocf?file=/docusaurus.config.js&resolutionWidth=997&resolutionHeight=675
Steps to reproduce

Add an announcement that is sufficiently long
Shrink the window size down and the issue should appear when the announcement occupies more than 1 line.

Expected behavior
The announcement bar should resize to fit the whole message.
Actual behavior
The announcement bar is too small to fit the whole message. It clips the message vertically.

Your environment
No response
Self-service

[x] I'd be willing to fix this bug myself.

Probably not a regression, this is what we had before:
https://deploy-preview-5000--docusaurus-2.netlify.app/

Related to https://github.com/facebook/docusaurus/issues/8370, we should probably fix both issues at once ensuring an announcement bar with dynamic height is possible and does not mess up with the docs layout


fail should allow an exception object in addition to a string

I noticed that this pattern fails with Exception: wrong type of 1'th argument: wrong type: need string, got exception:
try {
    /usr/bin/false
} except e {
    fail e
}

It seems to me it should be possible to re-throw an exception. Yes, you can do fail (to-string $e) but that will lose information if and when exception objects have attributes other than cause. It also violates the DRY principal (don't repeat yourself).
On a closely related note we'll probably want fail to accept options to set the hypothetical attributes that seem likely to be added in the future. As a stepping stone fail it might be useful to augment it accept an optional cause option that can be used instead of the current string argument. Either that or the current mandatory argument could be used but not both at the same time.

I see that @hanche proposed re-throwing an exception in this comment.


Redundant points

Could we comment on the redundant points? for example:
Following points more or less indicate to same feature "Open transparent effective efficient respectful communication"
Extensive access to and communication with users
Quick responses to bug fixes/feature requests
Easy to contribute to

Thanks for that, Malvkia.
Don't know how best to deal with this issue.
You're right, the bottom three points are all aspects of the first.
At the same time, I think it's useful to highlight those particular aspects of the general point, as being common features of great communities.
Perhaps include all the points, and at the top of the 'subfeatures' put the text 'This is a specific aspect of feature "Open transparent effective efficient respectful communication", but is included as it's a very specific important case of that, one that if it's not there, can have major negative impact on the quality of the community" (or something much more elegantly worded than that"...?
So it becomes clearer, that the set of features we're looking to list may include 'subfeatures' (i.e. there's some kind of branching/heirachy here). Justification for including a particular subfeature as an important enough aspect of the main feature, to be included on its own, is that it's a particular subfeature that has been observed as a common one that is not followed and causes problems/non-greatness for the community...?

Thanks for addressing this. The idea of branching/heirarchy can guide the texts to be included for each main feature.
Just so its clear, do you suggest that at the end of the feature collection we can decide 'subfeatures' of a main feature or should we address/explain each point separately during text writing?

I encourage you to do it the way that feels most useful/appropriate to you - we can change this as we go along, if we feel it needs alternative approaches.

I'm will close this for now.


Automate checking inclusive language coding guideline

Introduction
An inclusive language coding guideline was agreed upon by the TSC on 26 Aug 2020 and added to the documentation in #30508.
Add an automatic compliance check to verify that PRs don't introduce new usage of offensive terms.
https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html#rule-a-2-inclusive-language
Problem description
Violations of the inclusive language coding guideline currently are caught by manual inspection only and therefore are easily missed.
Example in https://github.com/zephyrproject-rtos/zephyr/pull/56800#discussion_r1177953787
Proposed change
Add a compliance check to automate checking PRs for violations of the inclusive language coding guideline.
Concerns and Unresolved Questions
How to handle PRs that modify existing usages of offensive terms?

@maureenhelm I noticed some violations, but those were by manual inspection. Wanted to see if there was any interest in how to add automated checking for this
@henrikbrixandersen at Vestas I believe we are using some off the shelf tools for checking text for offensive language (job ads, brochures, etc.). I can look into this
@nashif we can use checkpatch for this -- saw a PR from @nandojve on this using things like 'slv'
@maureenhelm that was in the name of the register, though, so we agreed to leave this, while changing variables. Need to deal with subtleties like this and probably leave the check at the warning level to support this
@galak I remember LF presenting something about this, maybe reach out to Brett as well
@stephanosio implementing is one thing, but we need to come up with a list of such terms
@maureenhelm we have a list that's part of the coding guidelines (https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html#rule-a-2-inclusive-language)
@stephanosio so only these?
@nashif start with these. Can use checkpatch's spelling checks for this

Standard Linux spellchecker have apparently not been mentioned yet:

https://github.com/hunspell/hunspell/issues/448 , https://linux.die.net/man/4/hunspell "the most popular spellchecker"
https://github.com/codespell-project/codespell - already used by checkpatch.pl
https://facelessuser.github.io/pyspelling/

@kartben This issue covers checking inclusive language for new code.  But we need a process to address breaking changes for violations already in the tree.
@nashif - We need to open issues for each area that need updates.
@jfischer-no - there is a sample pulling in a 3rd party tool that adds in "slave" as part of the documentation.  Tool test modbus Zephyr.  How should we handle this?
@kartben - The documentation should note Zephyr makes a best effort to use inclusive language and ask contributors to open issues that aren't compliant.  We probably can't get rid of all instances, so a disclaimer would be helpful.
@kartben - Will run the Microsoft tool to see what the status of inclusive terms in the tree.  "blackbox" is a term flagged by the MS tool that should probably be allowed.


Introduce a UserCollectionProvider component

Problem
We are constructing user collection references in multiple places across the codebase, leading to redundancy and potential inconsistency.
Solution
Introduce a UserCollectionProvider class that centralizes the logic for retrieving user collections. This class would inject the necessary dependencies and streamline the process. For example:
class UserCollectionProvider @Inject constructor(
    private val firebaseFirestore: FirebaseFirestore,
    private val userSessionManager: UserSessionManager,
) {
    fun getUserCollection(): Result<CollectionReference> = runCatching {
        val uid = userSessionManager.getUserUid() ?: error("User not available")
        firebaseFirestore.collection("$USERS_PATH/$uid")
    }
}

This would eliminate the need to redeclare constants and manage multiple dependencies across different locations. Similar work has been done in ObservationCollectionProvider.
Additional context
The implementation would help simplify code and reduce duplication, ensuring a single source of truth for user collection management.
Code of Conduct

[X] I agree to follow this project's Code of Conduct and Contributing Guidelines

Just as an FYI to not do too much work and then regret that it may be replaced anyways: On iOS, we have a snapshot listener on the user account within SpeziAccount and expose that property through that. So we may be able to just get that user information (as well as the notification settings) from the AccountDetails value...
I'm currently working on bringing SpeziAccount and SpeziFirebase to a point where we can use it on Android as well

Just as an FYI to not do too much work and then regret that it may be replaced anyways: On iOS, we have a snapshot listener on the user account within SpeziAccount and expose that property through that. So we may be able to just get the organization (as well as the notification settings) from the AccountDetails value instead of fetching them manually right before fetching the organization.
I'm currently working on bringing SpeziAccount and SpeziFirebase to a point where we can use it on Android as well

good to know, then I think I would just close the issue to avoid confusion and probably it makes sense to remove ticket #27 and #25 as well, right?
CC @eldcn


[Component] Pressing delete at the end of an AuroraTextField causes a crash.

Pressing delete at the end of an AuroraTextField (TextFieldStringProjection shown below) causes a java.lang.IllegalArgumentException: end cannot negative. [end: -1] error.

Likely linked to #2023 on Compose-JB.

Not seeing the crash in the latest dev version 1.2-SNAPSHOT. But yes, in this particular case Aurora wraps the core BasicTextField and all the text handling including backspace / delete comes from that layer.


fix: initialize toolbox

Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Fix CI?

i discovered more issues with the sdk e2e scaffolding. going to take some
time for this to merge but i reverted the pr on main
https://github.com/MystenLabs/sui/pull/16653


Incorrect link back to table if contains special characters

That links to https://simon.datasette.cloud/data/graph.henryn.ca.nodes which is incorrect - it should link to https://simon.datasette.cloud/data/graph~2Ehenryn~2Eca~2Enodes

The breadcrumbs link to the right place.


MAINT/ENH/BUG: Remove special cases from cdf2rdf

This:

allows arbitrary dimensions of stacking
catches issues in stacked matrices with non-even numbers of complex values in each row
avoids recomputation of k+1
avoids crashes when called on array_likes that are not arrays

This does not:

fix cdf2rdf([1+1j, 2-1j, 1-1j, 2+1j], np.eye(3))

Follow up from #8550

Thanks Eric. @NKrvavica would you like to review this?

Updating with passing tests, now that I have a local build working

Looks like the eigenvector order has changed for the docstring examples

scipy.linalg.cdf2rdf
--------------------
File "build/testenv/lib/python3.5/site-packages/scipy/linalg/decomp.py", line 1341, in cdf2rdf
Failed example:
    vr
Expected:
    array([[ 1.     ,  0.40016, -0.01906],
           [ 0.     ,  0.64788,  0.     ],
           [ 0.     ,  0.     ,  0.64788]])
Got:
    array([[ 1.        , -0.0190554 , -0.40016337],
           [ 0.        ,  0.        , -0.64788354],
           [ 0.        ,  0.64788354,  0.        ]])
File "build/testenv/lib/python3.5/site-packages/scipy/linalg/decomp.py", line 1346, in cdf2rdf
Failed example:
    vr @ wr
Expected:
    array([[ 1.     ,  1.69593,  1.9246 ],
           [ 0.     ,  2.59153,  3.23942],
           [ 0.     , -3.23942,  2.59153]])
Got:
    array([[ 1.        ,  1.92459523, -1.69593045],
           [ 0.        ,  3.23941772, -2.59153418],
           [ 0.        ,  2.59153418,  3.23941772]])
File "build/testenv/lib/python3.5/site-packages/scipy/linalg/decomp.py", line 1350, in cdf2rdf
Failed example:
    X @ vr
Expected:
    array([[ 1.     ,  1.69593,  1.9246 ],
           [ 0.     ,  2.59153,  3.23942],
           [ 0.     , -3.23942,  2.59153]])
Got:
    array([[ 1.        ,  1.92459523, -1.69593045],
           [ 0.        ,  3.23941772, -2.59153418],
           [ 0.        ,  2.59153418,  3.23941772]])
ERROR: refguide or doctests have errors

@ilayn: That surprises me a lot. Perhaps I'll split this into smaller PRs

Went for a bunch of small commits instead, which separates the BUG and MAINT more clearly. Each should be pretty self-contained, so I see no reason to squash them

Yep, this falls into the "should never happen" class of errors, which using
assert will save the cost of a check if the user runs python with
assertions disabled
On Sun, 25 Mar 2018 at 12:20 Warren Weckesser<EMAIL_ADDRESS>wrote:

@WarrenWeckesser commented on this pull request.
In scipy/linalg/decomp.py
https://github.com/scipy/scipy/pull/8595#discussion_r176950899:

     raise ValueError('expected complex-conjugate pairs of eigenvalues')

find complex indices

idx = nonzero(complex_mask)
idx_stack = idx[:-1]
idx_elem = idx[-1]

filter them to conjugate indices, assuming pairs are not interleaved

j = idx_elem[0::2]
k = idx_elem[1::2]
stack_ind = ()
for i in idx_stack:

   # should never happen, assuming nonzero orders by the last axis

   assert (i[0::2] == i[1::2]).all(), "Conjugate pair spanned different arrays!"

Don't use assert for argument validation. If the input is not as
expected, raise a ValueError. (But maybe you did this because this should
never happen?)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/pull/8595#pullrequestreview-106740406,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZ9LB8npLYaAKxO5ZbEc_XTnhk5PNfaks5th-4JgaJpZM4S4H_k
.

@pv: Updated


feat(RouteDiagram): Proper visualisation of parallel processing of the multicast

Also I added tests for the multicast rendering and did small variables refactor.
Route visualisation without parallelProcessing=true:

with parallelProcessing=true:

@mmelko Don't forget to point to the issue that the pull req is supposed to fix from here.


EOFError while invoke Docker::Container.create

I wrote a piece of code to create a container from existing image like this:
container = Docker::Container.create('Cmd' => ['ls'], 'Image' => 'busybox')

However, when I run this line of code, I got the following error messages:
/root/.gem/ruby/2.2.0/gems/excon-0.45.4/lib/excon/socket.rb:45:in `read_nonblock': end of file reached (EOFError) (Excon::Errors::SocketError)
        from /root/.gem/ruby/2.2.0/gems/excon-0.45.4/lib/excon/socket.rb:45:in `readline'
        from /root/.gem/ruby/2.2.0/gems/excon-0.45.4/lib/excon/response.rb:53:in `parse'
        from /root/.gem/ruby/2.2.0/gems/excon-0.45.4/lib/excon/middlewares/response_parser.rb:6:in `response_call'
        from /root/.gem/ruby/2.2.0/gems/docker-api-1.22.0/lib/excon/middlewares/hijack.rb:45:in `response_call'
        from /root/.gem/ruby/2.2.0/gems/excon-0.45.4/lib/excon/connection.rb:372:in `response'
        from /root/.gem/ruby/2.2.0/gems/excon-0.45.4/lib/excon/connection.rb:236:in `request'
        from /root/.gem/ruby/2.2.0/gems/docker-api-1.22.0/lib/docker/connection.rb:40:in `request'
        from /root/.gem/ruby/2.2.0/gems/docker-api-1.22.0/lib/docker/connection.rb:65:in `block (2 levels) in <class:Connection>'
        from /root/.gem/ruby/2.2.0/gems/docker-api-1.22.0/lib/docker/container.rb:228:in `create'
        from ./xxx.rb:xx:in `<main>'

and the Docker daemon also seems to throw a runtime error:
2015/07/17 16:47:22 http: panic serving @: runtime error: invalid memory address or nil pointer dereference
goroutine 78 [running]:
net/http.func·011()
        /usr/local/go/src/net/http/server.go:1130 +0xbb
github.com/docker/docker/api/server.adjustCpuShares(0xc2081628a7, 0x4, 0x0)
        /go/src/github.com/docker/docker/api/server/server_linux.go:112 +0x61
github.com/docker/docker/api/server.(*Server).postContainersCreate(0xc208076cc0, 0xc2081628a7, 0x4, 0x7fde9a485dd8, 0xc208199cc0, 0xc2080b1a00, 0xc208162a20, 0x0, 0x0)
        /go/src/github.com/docker/docker/api/server/server.go:923 +0x21a
github.com/docker/docker/api/server.*Server.(github.com/docker/docker/api/server.postContainersCreate)·fm(0xc2081628a7, 0x4, 0x7fde9a485dd8, 0xc208199cc0, 0xc2080b1a00, 0xc208162a20, 0x0, 0x0)
        /go/src/github.com/docker/docker/api/server/server.go:1566 +0x7b
github.com/docker/docker/api/server.func·008(0x7fde9a485dd8, 0xc208199cc0, 0xc2080b1a00)
        /go/src/github.com/docker/docker/api/server/server.go:1522 +0xc8f
net/http.HandlerFunc.ServeHTTP(0xc2081c4040, 0x7fde9a485dd8, 0xc208199cc0, 0xc2080b1a00)
        /usr/local/go/src/net/http/server.go:1265 +0x41
github.com/gorilla/mux.(*Router).ServeHTTP(0xc2080a19a0, 0x7fde9a485dd8, 0xc208199cc0, 0xc2080b1a00)
        /go/src/github.com/docker/docker/vendor/src/github.com/gorilla/mux/mux.go:98 +0x297
net/http.serverHandler.ServeHTTP(0xc2081aa060, 0x7fde9a485dd8, 0xc208199cc0, 0xc2080b1a00)
        /usr/local/go/src/net/http/server.go:1703 +0x19a
net/http.(*conn).serve(0xc208199b80)
        /usr/local/go/src/net/http/server.go:1204 +0xb57
created by net/http.(*Server).Serve
        /usr/local/go/src/net/http/server.go:1751 +0x35e

So, I think it seems like some errors on messages between API and server. Could you please  tell me the exact reasons or how to solve it? Thanks a lot!

This looks like the docker deamon is dying and that's why the API is failing.  What version of docker are you running? Does the docker CLI work?

Yes, at first glance, I also thought it was dying... However, after this exception, I then ran command lines like sudo docker images, and it works well. So it still works well.
The docker's version is 1.7.1, cloned and compiled from the Github source.

Hi,
This appears to be a combination of a bug in the backend docker daemon (it has a null pointer exception) to the invalid request, coupled with the client (docker-api) not specifying the 'HostConfig' object client side in the 'create' request.
I've created a pull request that fixes it for me and allows docker-api to work with the latest docker development version.
https://github.com/swipely/docker-api/pull/296

Hey guys, let me know if this gets fixed in the release of 1.8.0.  @srust's fork works for now if you're hitting this issue, but I'd prefer this be fixed upstream if possible.

Thanks @tlunter. Will let you know. I've opened an issue with upstream.

Thanks @tlunter, will let you know. I've opened an issue with upstream.

FYI, the fix for this has been merged into docker master, scheduled for 1.8.
https://github.com/docker/docker/pull/14917


Correction for raw affiliation UMR AGAP, CIRAD, Avenue Agropolis, 34398 Montpellier Cedex 5,#R#France

Correction needed for raw affiliation UMR AGAP, CIRAD, Avenue Agropolis, 34398 Montpellier Cedex 5,#R#France
raw_affiliation_name: UMR AGAP, CIRAD, Avenue Agropolis, 34398 Montpellier Cedex 5,#R#France
new_rors: 00txxwv34;05kpkpg04;02w4exq36
previous_rors: 00txxwv34;05kpkpg04
works_examples: W2038057909
contact: b57f59d3c32e7455d66eefc066036312:2769ee6c6a4b1586941d4e4c9ad03d878b75 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


Add optional case_info nodes for HERON

Pull Request Description
What issue does this change request address?
Closes #38
What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass.
[x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large tes.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
[x] 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL I'm able to run a few modified test-cases containing <label> nodes. But I'm not sure where we want it to end up. I thought it may end up in disp_results.csv but it doesn't.

civet seems to be locked up right now; hopefully that's resolved soon.

@PaulTalbot-INL I added an integration test which is just an extended production_flex test. Let me know if that's sufficient.

Yeah, it looks fine. It can become a great test in the future for testing what gets sent into the Functions, so standalone test is fine. I think we're just waiting on some documentation and the automatic tests, or did I miss the docs being added?

@PaulTalbot-INL I updated the documentation, but I just put all the points together on referencing meta['HERON']['Case']. I'm updating that now. Other than that, after the tests pass it should be good to go.


Navigation options

This PR:

Adds support for replace to Link and Redirect
Makes it possible for external libraries to define their own navigational options. Example:

import useLocationWithState from '@wouter/use-location-state';

const App = () => (
  <Router hook={useLocationWithState}>
    <Link to="/app" state={{ foo: 'bar' }}>Click Me</Link>
  </Router>
);

Next steps: the proper types are still WIP.

Codecov Report

Merging #121 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   99.44%   99.45%   +0.01%
==========================================
  Files           7        7
  Lines         181      185       +4
  Branches       32       32
==========================================
+ Hits          180      184       +4
  Misses          1        1

Impacted Files
Coverage Δ

index.js
100.00% <100.00%> (ø)

use-location.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6fc166...b9a65be. Read the comment docs.


Fix performance bucket corner case

Previously, because flakiness detection repeats the same test for 2 times,
2 same scenarios might be split into the same bucket, triggering an IllegalArgumentException.
This PR handles this case specially.

Superseded by https://github.com/gradle/gradle/pull/17442


Documentation website setup based on 11ty

Setup documentation website setup based on 11ty.

[ ] configuration
[ ] setup structure

Done by #63


Cannot get type of the resource

type property is undefined:
Project.find('1').then(project => {
    console.log(project.type); // undefined
});

I need exactly type of the resource returned from the server and not className defined in client application.

Sorry I'm just responding to these now, for some reason my notifications were off.
project.klass().queryName is the closest I can think of. If you get a type back from the server that is supposed to be a Project but doesn't have type: 'projects' it won't work anyway

I agree with @antonkomarev, I think this should be provided.
object.id is available, type is the only other internal attribute that's critical.  If there is a sophisticated STI pattern, users will have to use a 'kind' alias or something similar, but .type should be available regardless.


Fix small bug with sending messages to manager

Env variable DirectManagerChannelID is not used and in general very misleading. Need to remove it and instead of setting manager to manager account, set it to Manager User ID which will be much more useful in sending data to manager

[ ] remove env variable, change manager to managerSlackUserID
[ ] modify config type to use new env variables set up
[ ] modify docker-compose to use new env variables set up
[ ] modify notifier functionality (instead of SendMessage use SendUserMessage)
[ ] modify tests
[ ] check if tests are working correctly and notifier works correctly as well.
[ ] change server docker-compose file
[ ] Apply all changes in staging


Deuteronomy upgrade

Thank you @EyeOfPython! ❤

https://github.com/givelotus/lotusd/wiki/Upgrade-Checklist


Update to log4j 2.17.0

Signed-off-by: Andriy Redko<EMAIL_ADDRESS>Description
Update to log4j 2.17.0. It seems like it could be dragging for a while:

Address CVE-2021-45105.
Require components that use JNDI to be enabled individually via system properties.
Remove LDAP and LDAPS as supported protocols from JNDI.

Issues Resolved
Address CVE-2021-45105.
Closes https://github.com/opensearch-project/OpenSearch/issues/1772.
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sorry @dblock :( it seems like log4j just got all the attention these days ...

You rock, thanks for beating me to this one.

Thanks @reta for this.
Could backport this to 1.x, 1.2?


Progress bar stays loading forever (until completed is called) and an…

…imation is much smother

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes #61

It makes the progress bar to grow in a way that allows it to not be completed ever (like in youtube)
until the complete method is called, when start is called.
Made possible to change the transition timing function from the code.
Set the transition timing function to linear by default (looks better when the progress is changed by
the start method)
Made the transition speed of the bar, equal to the velocity of the bar when start is called (That and
the timing function being linear makes the loading way more smoother).
Removed the completed callback from the start method, because that callback will never be called under the new algorithm for the bar growth.

What is the current behavior? (You can also link to an open issue here)
When start is called, the loading bar loads for 50 seconds until it looks completed.

What is the new behavior (if this is a feature change)?
When start is called, the bar stays loading forever, showing increments of lower amounts as time progresses allowing for it to stay doing increments to the bar forever.
(9%, 17%, 25%, 32%, 38%, 44%, 49%, 53%, 58%, 61%, 65%, 68%, 71%, 74%, 76%, 78%, 80%, 82%, 84%, 85%, 86%, 88%, 89%, ...) but no 100%.

Other information:

The velocity of this change can be modified by changing the field growVelocity in the service, and the higher the value, the more quickly the bar will look full.

The issue with the test are with the versions of the dependencies that are downloaded for testing. If the @angular/common dependency is specified to only match the other dev dependencies, the tests runs

I have been looking for something similar to this - Would be great if it could be merged in!


VSCode doesn't remember account information, "Unable to transform input"

Issue Type: Bug
For about a week now, it seems like VSCode is unable to remember me being logged in for settings and live share. This means that in the lower left corner I always have 2 notifications prompting me to log in.

VS Code version: Code 1.53.2 (622cb03f7e070a9670c94bae1a45d78d7181fbd4, 2021-02-11T11:48:04.245Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz (8 x 4200)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.94GB (4.32GB free)

Process Argv
C:\Users\barnabas.makkay\AppData\LocalLow\FuturLab\PowerWash Simulator\Player.log --crash-reporter-id c4cbbaa4-6c2b-44f1-a550-be6673d158f2

Screen Reader
no

VM
0%

Extensions (4)

Extension
Author (truncated)
Version

gitlens
eam
11.2.1

theme-monokai-pro-vscode
mon
1.1.18

csharp
ms-
1.23.9

vsliveshare
ms-
1.0.3784

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt617cf:30253240
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vstry244:30256636
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
pythontb:30260843

So what's new is that "Restart to Update" button, that also gives me a notification. Clicking on that seems to log in to Live Share, but not Settings Sync. And by fixing I mean for that session or day, because the next day I have all three notifications again.
Microsoft Authentication output after "Restart to Update":
[Error  - 09:17:50.314] Getting token failed: Error: Unable to transform input.

As an extension author I am also seeing this same behavior while developing two new extensions.
Seems to be occur when two extensions attempt to use microsoft authentication getSession for different resource/scopes, it fails with "Getting token failed: Error: Unable to transform input." on window reload (after some sort of timeout) and then asks to resign in through browser flow again.
//extension-a
getSession(resource-A/scope-A)

//extension-b
getSession(resource-B/scope-b)

Flow

sign into extension A
sign into extension B
reload window
after a while Microsoft Authentication fails with Getting token failed: Error: Unable to transform input.
resign in through browser flow

vscode version: 1.5.62
OS: windows 10

On Windows, secrets have to be stored in chunks because there's a size limit. When we reassembled the stored passwords, we were not incrementing an index... so if the amount of tokens you used caused more than 2 chunks to get stored into CredMan, you'd be in a loop until the stack overflowed.
Now that we increment the index, no more issue.
Verification steps:

Grab this zip and install the 3 extensions: extensions.zip
Run the 3 "Hello World" commands in order. Login with your WORK account
Reload VS Code
Run the 3 "Hello World"s again. The notification should show up almost immediately and you should not be asked to log in again


Update Spatial docs

Fixes #1118, fixes #2352, fixes #2611, fixes #2674

I was just surprised that Brice wrote 9,700 lines worth of content in docs. 😮

lol, that JSON file is pretty big