Objective-C OAuth library does not use ARC

@MatthewHendy writes in #32 :

In my build settings the 'Objective-C Automatic Reference Counting' flag is set to yes, yet I have 94 errors relating to 'release' , 'autorelease' , ARC restrictions, and ARC casting rules. I copied this code into my project and double checked my ARC flag and it doesn't run. If I turn off ARC then it runs fine.

First step: Repro and find a few of these 94 errors.
@MatthewHendy: Do you have 2-3 example errors we could look at?

@SSheldon , feel like taking a first pass?

@MatthewHendy, sorry for the trouble! This issue is because the OAuth library used in our Objective-C code sample does not use ARC. It should work if you add the -fno-objc-arc compiler flag to the OAuth files (like in these steps: http://stackoverflow.com/a/6658549).
On a related note, if you have any ARC-compatible OAuth libraries to recommend, I'd be happy to hear it :)

That seemed to work SSheldon, thank you!


Minlen error on telescopic_ota_guard_ring

We seem to be getting an error in telescopic_ota_guard_ring. There is a min length error in the vss power hookup.
@Lastdayends @854768750 Here is picture.

The metal1 wire is only 72 long.
To duplicate this error, you can run:
schematic2layout.py $ALIGN_HOME/examples/telescopic_ota_guard_ring

Closing this issue as also assigned in #850 (Guardring flow fails on master). We are trying to resolve it in PR #862.

@stevenmburns
Will look into it.


Translate file "authentication.md"

Notes for contributors, the file can be translated by being aware of and understanding the file you are translating, you must have an understanding of the techniques and the explanation provided by the documentation file, and it must be in Standard Arabic, and the technical terms should be translated as follows:
For example, المتحكمات with the term next to it in English (Controllers)
For example, التهجير and next to it the term in English (Migrations)
And so on
Thank you for your contribution

I will take this


include annotation for component creation to new quay repo

Fixes

https://issues.redhat.com/browse/HAC-3623
Description

Add annotation image.redhat.com/generate: 'true' to the Component creation.
Type of change

[x] Feature
[ ] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review

No UI change.
How to test or reproduce?

Create a new component in the UI. Inspect the yaml.
While the annotation value begins as true, the controller will update the value to false and add a new annotation named image.redhat.com/image.
Browser conformance:

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

/retest

/retest


mergeToFile not working because on input and out sar parameters not matching

I am attempting to merge two different videos using mergeToFile().
Code below:
var twoMerged = function (one, two){
setTimeout(function(){
new FfmpegCommand(one).addOption('-strict', 'experimental')
.input(two).addOption('-strict', 'experimental')
.on('end', function() {
console.log('files have been merged succesfully');
})
.on('error', function(err, stdout, stderr) {
console.log(" =====Convert Video Failed======");
console.log(err);
console.log("stdout: " + stdout);
console.log("stderr: " + stderr);
})
.mergeToFile('twoTest.mp4', './temp');
}, 5000)
I get the following error:
input link in1:v0 parameters ('size 1920x1080', SAR(10:11) do not match the cooresponding output link in:vo parameters size 1920x1080', SAR(57600:633391).
I had this error before I used the setsar filter to change the video sar on both videos in case that was the error, but did not solve the problem.  I know you are busy, thanks for any thoughts.  As a side issue, do you know a good intermediate codec to use with ffmpeg that works well with alpha?  Thanks

This should be solved when adding setsar filters. What's the error you're getting in that case?
Additionaly, a SAR of 57600:633391 seems really weird (that means each pixel in the video is more than 10x taller than it is wide).
As for your codec question, I don't have an answer unfortunately (but maybe someone else does).

Oh, my bad, you cannot use filters with mergeToFile, because internally it uses a complex filtergraph.
My advice would be to do the merge manually by copying the code from mergeToFile (in lib/recipes.js) and changing the complex filtergraph to add setsar.

I will give that a shot today.  Thanks for the quick responses.
On Jun 25, 2015 12:27 AM, "Nicolas Joyard"<EMAIL_ADDRESS>wrote:

Oh, my bad, you cannot use filters with mergeToFile, because internally
it uses a complex filtergraph.
My advice would be to do the merge manually by copying the code from
mergeToFile (in lib/recipes.js) and changing the complex filtergraph to add
setsar.
—
Reply to this email directly or view it on GitHub
https://github.com/fluent-ffmpeg/node-fluent-ffmpeg/issues/414#issuecomment-115109054
.

Worked.  Thanks for the lookout.

I'm still having issues with this. Can you provide me with a code snippet of the solution @apprisingapps ?

@apprisingapps can you share your solution with us?


Atrocious performance caused by Timer/DMA controllers

Whilst there are lots of micro optimisations across the application the fundamental architecture is slow.

shows the breakdown of CPU time spent during a frame. Notably it's not the ppu or cpu which are causing <60fps on my device. It's the timer controller and dma controller which are stepping every cycle and causing slowdowns.
Many emulators use a scheduler to get around this issue, instead of ticket components like the timer each cycle they specify when an event like reload will occur and simply skip through to then (caveat that it needs to handle cpu reads). That's certainly one option here although I'd like to see if I can improve performance in other ways first.

Minor fix for timer controller to remove unnecessary allocations of a bool array each time it's ticket

Minor fix for DMA controller to not need to check all channels on a write cycle brings perf down to <15% total

Starting to track adding a scheduler in a new branch https://github.com/DaveTCode/GBADotnet/tree/scheduler

https://github.com/DaveTCode/GBADotnet/tree/scheduler/compatibility outlines performance with my laptop (surface book 3) before adding a scheduler

After moving ppu and timers off the main clock function I get much higher performance (10fps average increase from ppu, 100fps increase from timers)
Remaining large ticket items for performance are looking at the dma controller, and off loading the ppu rendering routines to another thread. Be interesting to check that and see if it's quick enough. Just a question of how fast we can shuffle the bytes across between threads. Definitely don't want to mutex lock on vram/palette etc access!

Scheduler branch merged into main, the timer is no longer a concern from a performance point of view so I'll close this ticket down and raise separate tickets for other performance enhancements.


rustfmt settings (linebender-wide?)

In setting up the seed for vello_svg, a comment came up that there's a fragmented story around rustfmt.toml settings across linebender.
"Kurbo, Glazier, Druid, and Piet have the following. Vello and Xilem right now don't have the file at all. I think going with the Kurbo one is fine." - @xStrom
max_width = 100
use_field_init_shorthand = true
newline_style = "Unix"

And I'd love to add the following, which keeps imports very tidy:
imports_granularity = "Crate"

Is this something that needs more discussion or can I chug along with a PR to add all of these settings?

I agree that reducing fragmentation and having a unified standard is a good goal. Introducing the existing rustfmt.toml to repos that don't have it yet, like Vello, seems like a very reasonable step that I would approve immediately.

Now imports_granularity is a bit trickier.
Main issue with it is that it's not stabilized and thus can only be used via the nightly toolchain. Thus it's probably too much friction to require a match via CI, as people would need to either download the nightly toolchain or manually apply the diff. We could decide to have it configured in a opt-in way, so that whenever someone does use the nightly toolchain it will apply our chosen unstable style. Downside of that is that PRs can then have a bunch of unrelated imports restyling. Not the biggest problem but it does add noise for reviews. Another effect of this being unstable is that it still has issues with certain scenarios and so doesn't always work well.
I do really like the idea of consistency though. With Druid we aimed for a bit of consistency as well via manual review comments, but that can get socially taxing and having cargo fmt do it is just so much nicer. In that sense, I would be all for configuring options like this if they were stable. With them unstable, I'm hesitant but maybe slightly in favor.
Now as for the value, I personally would prefer Module over Crate. Although I prefer any value over Preserve which keeps things inconsistent.
If we do decide to configure imports_granularity then I think we should also configure group_imports. It has a similar unstable story and isn't fully refined yet. For its value I would strongly prefer StdExternalCrate, which was also the manually kept standard in Druid.
I think the question of whether to introduce these unstable options and which values to go for does warrant additional input from others.

I'm fine with the Module > Crate granularity.
For the linked PR, #513 -
I applied the standard rustfmt settings - These have existed in many repos for a while.
But I also included a one-time assist from imports_granularity = "Module" to get things more consistent until imports_granularity is stable. We can revisit the imports_granularity when it's stable.


docs(README): fix typo

Issue #271

Changes
instuctions changed to instructions
Flags

Related Issues

Issue #
Pull Request #

Signed-off-by: steffinstanly<EMAIL_ADDRESS>

how to sign the DCO

You could git commit --amend --signoff and then force push, I believe.


included synth::Frames in pub use so it is accessible for users

Due to the module synth being private, synth::Frames isn't directly accessible from the outside, but since it's the return value of  Synth::frames(), which is accessible, one cannot type the return type out/ use this furhter. This seems to be unintentional and a bug

Thanks!


Message error is shown twice in the report if test uses an assertion that trows an error directly

When my test fails because an error was thrown directly (e.g. using throw new Error(reason)), the error message in the report is displayed twice, as in this example

In the console, this does not happen, the error is displayed only once.
Do you have an idea of what I can change in my setup so the error is not duplicated in the report?
I am using:
Detox: 20.19.5
detox-allure2-adapter: 1.0.0-alpha.11
jest-allure2-reporter: 2.0.0-beta.22
Your help is much appreciated. Thank you!

Hm, can I see some more details about the error. I am confused by Error:\nERROR\n... why two times in different case? 🤔
I assume you see that once? And when you click to expand error details, you see the duplication below, right?

I tried to reproduce this issue but it seems that it is missing some important details... 🤔

Sorry, I was wrong! There is some magic in putting \nERROR there in the message. I will take a look

yeah, my error message starts with \n but it doesn't have to :) Thank you for checking this

In any case, this is a nice catch. I will fix it soon.


Multi-model analysis

Expands Model bias analysis notebook to work on multiple score columns instead of one. In general, all analyses now compute the median and variance across a set of model scores.
I still need to expand this to work on multiple model families in order to see the effect of the experiments, but this is the first step.
Builds on top of the jetpack-cleanup-biasanalysis branch.
Note: the true/false negative term rate plots seem pretty different now compared with before: the plots look less biased. The plots are now based on the median TNRs/FNRs for each term. It's also possible that the models are just better now. Remains to be seen how the experimental models compare with the original model.

Sadly, diff is too large for inline comments. Generally LGTM.

In cells [88 - 92] you give examples of FP and FN. Why not use the median value for these?

I only added the median score column later on, and didn't go back and fix this. Done.

Uh, dunno how i closed this PR or how to re-open... going to go ahead and merge though.

Can you merge a closed PR?

I just merged it manually in git.
On 13 October 2017 at 13:49, nthain<EMAIL_ADDRESS>wrote:

Can you merge a closed PR?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/conversationai/unintended-ml-bias-analysis/pull/19#issuecomment-336522443,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AISgGBRVzWt_1kxt28SJdyvhJVUqaSbdks5sr6KrgaJpZM4P36dF
.


#1: add support for horses in database initialization

Looks good, ready to merge.

/paulo - can you please review this pull request?

/paulo - can you check now?


Add ENS avatars to profile using @davatar/react

Description
Add robust avatar image lookup support for ENS for wallet profile display using @davatar/react to seek to fulfill the spec outlined in avatars.md
Problem:
Snapshot currently shows a wallet's ENS name but not the ENS avatar photo (instead they show a blockie):

Solution:
Replace the <Blockie ... /> component with a <Davatar ... /> component and this will show the ENS profile photo if the wallet has one. Here's an example on UniSwap:

Implementation Requirements
Dev docs found here for reference : @davatar/react
Steps:

Add @davatar/react package
Replace use of  <Jazzicon ... /> or <Blockie ... /> with <Davatar ... /> component
Set param generatedAvatarType='jazzicon' or generatedAvatarType='blockies' matching the app's previous component

How to test:

Test changes with wallet addresses that have davatars set and make sure the davatar shows up replacing the jazzicon or blockie. Here are a couple to try (you can set a davatar to your own wallet here too!):
-- 0xE88F99aDC1aB6B1204C027e14c746DA9C3a66970
-- 0x9B6568d72A6f6269049Fac3998d1fadf1E6263cc
Test changes with wallet addresses that don't have a davatar set and make sure the blockie shows up as the default image.

Example PRs:

https://github.com/scaffold-eth/scaffold-eth/pull/438
https://github.com/Uniswap/interface/pull/2321 (note: we do now support NFT-metadata reference type)

@GailWilson we dont use React

Yes, sorry about that.


Less ignores the relative urls flag

I tried to use the "relative paths" flag with no luck. The transformer ignores that directive. For example, the following file is in the same directory that the common.less file:
@import 'common.less';

/* more things */

Here's my pubspec.yaml transformer:
transformers:
- less_dart:
    other_flags:
      - --relative-urls

After running the dart server (pub serve), it prints something like this:
[Info from less-dart] ERROR lessc --no-color --relative-urls lib/components/axis_login.less > lib/components/axis_login.css took 0.0s
**** ERROR ****  see build/lib/components/axis_login.css

FileError: 'axis_app.less' wasn't found. Tried - axis_app.less in - on line 1, column 1:
1 @import 'axis_app.less';
..^

But if I execute the above command manually, it works well:
# works like a charm
> lessc --no-color --relative-urls lib/components/axis_login.less > lib/components/axis_login.css took

More info
less: 0.3.3
OS: Xubuntu 16.04
Dart VM version: 1.16.0 (Tue Apr 26 14:18:21 2016) on "linux_x64"
Pub version: 1.16.0
lessc version: 2.7.1 (Less Compiler) [JavaScript]

Could you send me file contents to start a test environment?

No problem. Attached is the project.
app.zip

To test the application, remove the "rootpath" and "include" flags from pubspec.yaml and replace them by the "relative-paths" flag.

I don't understand very well the problem. Your description and the file contents don't match.
I guess the problem isn't the relative-urls, but the current directory used by the dart transformer (the project root).
Attached is a simplified working test
darttest.zip with web/index.less as if it were at root level.
Please modify the test to show the problem.

Thanks so much for your time. So I misunderstood the use of the "relative-urls" flag. I changed the application and now it works as expected, but I also realized that I prefer to use the "rootpath" and the "include-path" flags :)

Looking on this issue. I created a very simple angular2 project from scratch:
> stagehand web-angular

and I added the following less files:

lib/common.less
lib/app_component.less

The app_component.css file is loaded from app_component.dart:
@Component(
    selector: 'my-app',
    templateUrl: 'app_component.html',
    styleUrls: const ['app_component.css'])

And, at the same time, app_component.less imports common.less, which is in the same directory. Then I excuted the pub serve command and it throws the following error:
FileError: 'common.less' wasn't found. Tried - common.less in - on line 2, column 1:
1 //@import 'packages/test/common.less';
2 @import 'common.less';
..^
3

Build error:
Transform StylesheetCompiler on test|lib/app_component.css threw error: Url test|lib/app_component.css.dart is not a valid asset: url

Now copy and paste the above command and execute it directly from the project root:
# change the the project root and execute the following command
> lessc --no-color --relative-urls lib/app_component.less > lib/app_component.css

It throws no errors.
May be it is a problem with Angular 2 and less_dart.
Attached is the test project.
test.zip


Cherry pick 16691 to release 1.2

Fixes #16573 by backporting #16691 and #16753 to release-1.2
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@maxbischoff: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
014b50d1ea852f37e3740a90a47374436a2d053e
link
/test release-test-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Text composer dissapears and shows up while in editing mode after changing tabs

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open a chat
Edit a comment
Notice the text composer becomes hidden
Open another chat or another app and return back to chat (or) click outside

Expected Result:
Text composer should stay hidden or it should not disappear in the first place.
Actual Result:
Text composer reappears while in editing mode (or disappears while in editing mode).
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.10
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/236340518-329c3cc9-1b52-44ab-8272-0bca167e85ad.mp4
https://user-images.githubusercontent.com/43996225/236340581-2c23e6b7-c89c-43b7-8278-9fc0aa8f1887.mp4
Expensify/Expensify Issue URL:
Issue reported by: @nathan-mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683219440561249
View all open jobs on GitHub

I've run out of time this week; I will test over the weekend to continue the process.

No update

I will test soon.

No update

Closing - I'm unable to replicate. The keyboard remains open for me when moving around between apps or clicking around in Chat.


fix(ci): Remove old backend-roundtrip ci step

Are we intending to continue to support secure share with this code base? It is still based off of backend (underneath some layers of proprietary addons)


RobotHandler (logging) is not supporting formatters

UseCase: see this answer.
When using the RobotHandler class as custom handler for python's logging module, the formatters of the config wouldn't be supported.
Fix:
Getting the message str from log record as described here:
message = self.format(record)

EDIT
While providing a fix as branch, I got a 403 (Permission to robotframework/robotframework.git denied)
Here is the patch:
0001-apply-logging-formatter-as-stated-here-https-dzone.c.patch.zip

I don't have time to study this right know. Anyway, if you want to provide a fix, please provide a pull request.

I can't provide a branch.

I got a 403 (Permission to robotframework/robotframework.git denied)

Either you do something wrong or GitHub is experimenting problems. Have you created GitHub PRs earlier? If not, please check its instructions first. They are linked, for example, from our contribution guidelines that contain also other valuable information.

@pekkaklarck : It's open.

The PR definitely needs some tests. They are needed for me to understand the actual problem better and, more importantly, to make sure we don't break the fixed functionality later.

Original PR #3210 never got tests but new PR #4147 by @Robtom5 has them and looks so good that I add this issue to RF 5.0 scope. Smallish changes needed to the new PR still, though.

PR #4147 by @Robtom5 merged and this issue closed. Thanks for contribution!


Revert PR #886

@malikabhi05 You should revert this PR. The commits are messed up and it needs to be resolved. Ivan pushed the changes to one of my previous commit #887 . I am planning to resolve commits and open a new PR with Ivan's changes.

@Mani-Sadhasivam Could you provide some clarity on this, I just want to understand this better. Since we cannot rewrite history, are you asking that we revert 284d882b9db8637dc67773a86e9cf4a8564230a3 and 7ea32cf1ecce38d3ecf245d5245f244390ab0a86 or either one of them? This would remove support for Dragon board 820c added by @IvanFarkas . Is there anything in one of Ivan's commits which is wrong and shouldn't be there? or is it just that one of the commits in his PR was based on one of your older commits and the commit message got carried over to the new commit?
@pylbert @Propanu thoughts?

@malikabhi05

Please think about all those people who you deprive by delaying this long-awaited change.
Regrettably, you are not allowed using any of my code without my permission.
Be positive, please.

I think what happened was that both @Mani-Sadhasivam and @IvanFarkas worked on the same source file at the same time and the changes weren't rebased properly, it happens. The issue I see with it is here, the chardev map for the hikey board is removed. And 7ea32cf is a partial duplicate of dee7b80 that @IvanFarkas picked up in his PR. I assume it was unintentional, and all that's needed is a bit of clean-up.

@malikabhi05 Exactly it is same of what @Propanu said. I'm happy with @IvanFarkas change of adding DB820c. But somewhat the commits needs a bit of cleanup. If you are good to do then please go ahead and clean the commits. But it is completely unintentional from @IvanFarkas and all I want is a clean commit history.

@malikabhi05 There should be two commits:

Adding basic board support for DB820c
Adding Chardev support for DB820c

Both were already added by @IvanFarkas but not organised properly in commits.

I'm not sure what you mean by this? Please read - https://github.com/intel-iot-devkit/mraa/blob/master/CONTRIBUTING.md
Sorry but I'm not seeing what you're seeing - who isn't being positive? We screwed up, no one is debating that, let's just figure out how to fix it asap...

@malikabhi05 this doesn't rewrite history it's not rebasing which as you say we can't do now it's on master. Personally I'm not a huge fan of reverts because it just adds garbage to the history forever, but it does mean that someone needs to clear up the mess in either case. @malikabhi05 since it's your mess I propose you start, please treat this as urgent as it is not good to leave master in this state.

Leaving to Budapest Hungary today.
Be back in early May.
I'll have limited Internet access.
I am visiting my friends and family who I have not seen for almost 2 years.
I agree with your rules.
If you decide to revert, please allow me to add my code later, so I can get the credit.
Thank you very much for your understanding in this matter,

No.
It works perfectly.
I tested it for GPIO A-L on my DB820c.

Thanks @IvanFarkas for testing this and confirming that it works. We can't re-write history and reverting it isn't such a good option. Apart from the incorrect commit message, there seems to be nothing broken or out of place(specific to the files changed in the 2 commits). @Mani-Sadhasivam can we close this?

@malikabhi05 @pylbert There is no issue with the implementation related to src/arm/96boards.c but the issue is with the commits adding them.
Commit https://github.com/intel-iot-devkit/mraa/commit/7ea32cf1ecce38d3ecf245d5245f244390ab0a86 should only add DB820c board support(there should be no chardev support for DB820c/Hikey). For commit https://github.com/intel-iot-devkit/mraa/commit/dee7b80f063f869bc393544a57e177dc070d6d03 it should only add DB820c chardev mapping not Hikey. It is already mentioned by @Propanu.
But again, there is nothing wrong with the implementation (couple of pin mappings are wrong which I'll fix it)

Hi @malikabhi05 @Propanu Any update on this issue?

Hi @Mani-Sadhasivam, considering only 1 commit got messed up and since functionality wise everything is in order, I would leave this as is. I know it's not ideal and it's totally on us, we'll try to be more careful when rebasing/merging in the future. We have new PR's open that are waiting to be merged so we really need to move on.

@malikabhi05 @Propanu Thanks for taking your time to look into this issue. As we all agreed to move on, closing this issue.


Less branchy variable length load for short hashes

Inputs <= 8 bytes incur complexity to load from variable lengths without too many branches.
https://github.com/backtrace-labs/umash/blob/3d7730a541bff0b86a2e8c013057c5e2edc6f709/umash.c#L646-L690
Would it make sense to instead 8 bytes unconditionally (modulo end of page checks) and shuffle the relevant bytes in place with a data-driven PSHUFB?

Let's evaluate on an EPYC 7713 with an incorrect lower bound, and https://github.com/backtrace-labs/umash/blob/master/bench/notebooks/bench_short_inputs.md, the worst case (based on prod traces) for the current branchy code.
TEST_DEF inline uint64_t
vec_to_u64(const void *data, size_t n_bytes)
{
        v128 bytes;

        bytes = _mm_loadl_epi64(data);  /* Vector load */
        __asm__("" : "+x"(bytes));  /* Make the vector opaque to the compiler */
        return bytes[0];  /* vector -> GPR */
}

The worst code path for the current branchy implementation is short loads (< 4 bytes), and the vectorised lower bound essentially matches its performance.

Longer inputs are slower with the vector lower bound.

The exact test agrees:
[('0-3',
  {'mean': Result(actual_value=0.14017005926307652, judgement=0, m=19425, n=19425, num_trials=250),
   'lte': Result(actual_value=0.865793671001393, judgement=0, m=19425, n=19425, num_trials=500),
   'q99': Result(actual_value=-20.0, judgement=-1, m=19425, n=19425, num_trials=2750000),
   'q99_sa': Result(actual_value=-20.0, judgement=-1, m=19425, n=19425, num_trials=2750000)}),
 (4,
  {'mean': Result(actual_value=4.072072072072072, judgement=1, m=20000, n=20000, num_trials=2750000),
   'lte': Result(actual_value=0.710147615, judgement=-1, m=20000, n=20000, num_trials=2750000),
   'q99': Result(actual_value=0.0, judgement=0, m=20000, n=20000, num_trials=250),
   'q99_sa': Result(actual_value=0.0, judgement=-1, m=20000, n=20000, num_trials=2750000)}),
 ('5-7',
  {'mean': Result(actual_value=4.078078078078078, judgement=1, m=20000, n=20000, num_trials=2750000),
   'lte': Result(actual_value=0.7084625025, judgement=-1, m=20000, n=20000, num_trials=2750000),
   'q99': Result(actual_value=0.0, judgement=0, m=20000, n=20000, num_trials=250),
   'q99_sa': Result(actual_value=0.0, judgement=-1, m=20000, n=20000, num_trials=2750000)}),
 (8,
  {'mean': Result(actual_value=3.968968968968969, judgement=1, m=20000, n=20000, num_trials=2750000),
   'lte': Result(actual_value=0.712530075, judgement=-1, m=20000, n=20000, num_trials=2750000),
   'q99': Result(actual_value=0.0, judgement=0, m=20000, n=20000, num_trials=250),
   'q99_sa': Result(actual_value=0.0, judgement=-1, m=20000, n=20000, num_trials=2750000)})]

0-3 byte inputs are about the same, faster at the p99 (by 20 cycles, order of one branch misprediction). Others are slightly slowed down on average, with no improvement to the p99.
The latency of vector -> GPR on zen3 seems to make this approach a non-starter, at least on AMD machines.


Consistency in labels of (cellular) metabolic processes

Hi,
Not sure if there's already an ongoing discussion on this.
GO differentiates between
GO:0008152 metabolic process (The chemical reactions and pathways, including anabolism and catabolism, by which living organisms transform chemical substances.)
and its child
GO:0044237 cellular metabolic process (The chemical reactions and pathways by which individual cells transform chemical substances.).
However, not all descendants of 'cellular metabolic process' contain 'cellular' in their label (though some do in their exact synonyms). See e.g. the Ancestor chart in https://www.ebi.ac.uk/QuickGO/term/GO:0006593 where alpha amino acid metabolic process, alpha amino acid catabolic process, ornithine metabolic process and ornithine catabolic process don't contain 'cellular' in their label. There is 'cellular amino acid metabolic process' but no 'amino acid metabolic process'. Ultimately, amino acids are synthesized at the level of a single cell, so I get why 'amino acid metabolic process' is less useful. But then you have
'negative regulation of ornithine catabolic process'
is a subclass of
'negative regulation of cellular amino acid metabolic process'
The ancestry shows that 'negative regulation of ornithine catabolic process' refers to the single-cell process, but the name doesn't, and the parentage to a 'cellular' term may seem incorrect at first glance. Being more consistent with including 'cellular' in labels (or not) would help.
Thanks,
Paola

We want to merge all those.
Maybe to discuss on an ontology call for the strategy?
Should we drop the 'cellular' terms (since this is implied) ?
Thanks, Pascale

If we have decided to merge these, then I suggest that they be merged in the non-cellular direction. The result will be that there will not be a direct link to cellular process in the ontology.

My proposal makes metabolic process a subclass of cellular process. https://gist.github.com/cmungall/4ed28123c3db832a7d99cbdd8e8a5920
I think the use case for CP is a grouping for things at a level of granularity

But if you ask an endocrinologist to describe glucose metabolism, I suspect they will talk about it at a system and organismal level.

[x] GO:0006520 ~cellular~ amino acid metabolic process
[x] GO:0008652 ~cellular~ amino acid biosynthetic process
[x] GO:0009063 ~cellular~ amino acid catabolic process
[x] GO:0009072 aromatic amino acid ~family~ metabolic process

Obsolete with replaced by:

[x] GO:0044260 cellular macromolecule metabolic process  >> GO:0043170 macromolecule metabolic process
[x] GO:0044265 cellular macromolecule catabolic process  >>  GO:0009057 macromolecule catabolic process
[x]  GO:0034645 cellular macromolecule biosynthetic process   >> GO:0009059 macromolecule biosynthetic process
[x] GO:2000112 regulation of cellular macromolecule biosynthetic process >> GO:0010556 regulation of macromolecule biosynthetic process
[x] GO:0010558 negative regulation of macromolecule biosynthetic process >> GO:2000113 negative regulation of cellular macromolecule biosynthetic process

Obsolete, unnecessary grouping class:

[x] GO:0070589 cellular component macromolecule biosynthetic process (no annotations, no mappings, not in subsets)

[ ] GO:0044262 cellular carbohydrate metabolic process >>  GO:0005975 carbohydrate metabolic process
[ ] GO:0034637 cellular carbohydrate biosynthetic process >> GO:0016051 carbohydrate biosynthetic process
[ ] GO:0044275 cellular carbohydrate catabolic process >> GO:0016052 carbohydrate catabolic process
[ ] GO:0010675 regulation of cellular carbohydrate metabolic process >> GO:0006109 regulation of carbohydrate metabolic process
[ ] GO:0010676 positive regulation of cellular carbohydrate metabolic process >> GO:0045913 positive regulation of carbohydrate metabolic process
[ ] GO:0043471 regulation of cellular carbohydrate catabolic process >> GO:0045912 negative regulation of carbohydrate metabolic process

[ ] GO:0044264 cellular polysaccharide metabolic process >> GO:0005976 polysaccharide metabolic process
[ ] GO:0033692 cellular polysaccharide biosynthetic process >>  GO:0000271 polysaccharide biosynthetic process
[ ] GO:0044247 cellular polysaccharide catabolic process  >> GO:0000272 polysaccharide catabolic process

[ ] GO:0006073 cellular glucan metabolic process  >> GO:0044042 glucan metabolic process

Still need to look at: (list not exhaustive):

[ ] GO:0044107 cellular alcohol metabolic process
[ ] GO:0006081 cellular aldehyde metabolic process
[ ] GO:0043446 cellular alkane metabolic process
[ ] GO:0043449 cellular alkene metabolic process
[ ] GO:0043452 cellular alkyne metabolic process
[ ] GO:0006725 cellular aromatic compound metabolic process
[ ] GO:0046950 cellular ketone body metabolic process
[ ] GO:0042180 cellular ketone metabolic process
[ ] GO:0044255 cellular lipid metabolic process
[ ] GO:0044260 cellular macromolecule metabolic process
[ ] GO:0043094 cellular metabolic compound salvage
[ ] GO:0006575 cellular modified amino acid metabolic process
[ ] GO:0034641 cellular nitrogen compound metabolic process
[ ] GO:0090345 cellular organohalogen metabolic process

Work will be continued here:
https://github.com/geneontology/go-ontology/issues/28908


[refactor] The code related to CRI has a lot of redundancy

Ⅰ. Issue Description
For compatibility with the two versions of kubernetes CRI, we have maintained two pieces of code temporarily. Now it is time to optimize it. Actually, we have to maintain two pieces of code to some extent, but we can extract the common part to reduce redundancy. It is necessary even will take a lot of effort.
Ⅱ. Describe what happened
as above
Ⅲ. Describe what you expected to happen
reduce the code redundancy
Ⅳ. How to reproduce it (as minimally and precisely as possible)
None
Ⅴ. Anything else we need to know?
Ⅵ. Environment:

pouch version (use pouch version):
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

I will do that！

Any update on this?

@allencloud  Yes, the code about Stream and CNI has been refactored. More work will be done later.


Can't update opcodes after recent XivAlexander commit

Hello,
When trying to run the script I get the following errors in the screenshot below:

I believe it is caused by the addition of this new file in a recent commit to XivAlexander:
https://github.com/Soreepeong/XivAlexander/blob/6e5d42402f972478fc6893ea6280eedc3d355d49/StaticData/OpcodeDefinition/notes.txt
To test I forked XivAlexander and XivMitmLatencyMitigator, deleted notes.txt and changed "OPCODE_DEFINITION_LIST_URL" in "mitigate.py" to point to the fork and it was now able to update opcodes like normal.
(I'm extremely new to GitHub, so I'm sorry if I did anything wrong.)
P.S. Thank you for creating this tool. I can finally enjoy playing the game after years of being unable to double weave.

It's now fixed; it'll work if you download/run the script again., and if it doesn't work right away, try again after like 5 mins. Sorry about that!


support google play music?

After checking details, it's not possible to do that right now, so need to close this issue first.


Docker alpine support

Hello I've been trying to run this package with a docker image but when I try to run it I get this error:
/src/node_modules/uWebSockets.js/uws.js:31
                throw new Error('This version of µWS is not compatible with your Node.js build:\n\n' + e.toString());
                ^

Error: This version of µWS is not compatible with your Node.js build:

Error: Error loading shared library ld-linux-x86-64.so.2: No such file or directory (needed by /src/node_modules/uWebSockets.js/uws_linux_x64_72.node)
    at /src/node_modules/uWebSockets.js/uws.js:31:9
    at Object.<anonymous> (/src/node_modules/uWebSockets.js/uws.js:33:3)
    at Module._compile (internal/modules/cjs/loader.js:1138:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
    at Module.load (internal/modules/cjs/loader.js:986:32)
    at Function.Module._load (internal/modules/cjs/loader.js:879:14)
    at Module.require (internal/modules/cjs/loader.js:1026:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/src/index.js:1:13)
    at Module._compile (internal/modules/cjs/loader.js:1138:30)

This is my dockerfile
FROM node:lts-alpine
RUN apk --no-cache add git
WORKDIR /src
COPY package*.json ./

RUN npm install
COPY . .
EXPOSE 9001
CMD ["npm","start"]

@FerLuisxd See https://github.com/uNetworking/uWebSockets.js/issues/26 as this issue is Pinned in issues 😉

You are free to compile the sources for any platform you like, but the pre-compiled Linux binaries require glibc. Alpine is a muslc dist unlike 99% of Linux dists.


hackernews_js_fetch example fails ci

Describe the bug
error: could not compile `leptos_dom`

See CI (examples/hackernews_js_fetch) / Run ci (nightly) log.
Leptos Dependencies
N/A
To Reproduce
Steps to reproduce the behavior:

Go to examples/hackernews_js_fetch
Run cargo make ci
See compile error

Expected behavior
Running ci should succeed.
Screenshots
N/A
Additional context
The build has been failing for two weeks.

Thanks for pointing this out! I had mentally marked this as "need to merge the PR before releasing 0.5, the actual build works and I can fix cargo make lint for it later" and never did it. The fundamental issue was the existence of .cargo/config.toml setting the build target always to wasm32-unknown-unknown, but I cleaned up the other linting issues too. I think it should be fine now.


Missing React/JSX props not working in strict mode

First off, thanks for the library! This is a very simple/clean way to test typescript definition files. I've come across a strange bug with React/JSX, and tried my best to replicate the issue. It mostly has to do with testing for missing (but required) react props.
Here's the type definition, for example:
import * as React from 'react'

export interface MyProps {
  prop1: string
  prop2: number
}

export const MyComponent: React.ComponentType<MyProps>

The following tests fail but should work (they produce an error output, but it's different from what I guess tsd expects):
// This one's broken
expectError(<MyComponent prop1="hello" />)

// This one too
expectError(<MyComponent prop2={2} />)

Full reproduction, with tsconfig.json can be found here
Please let me know if I'm missing something/if there's a clear work-around. Thanks!

A work-around would be to declare MyComponent as a React.FC<MyProps> and not use tsx:
import * as React from 'react'

export interface MyProps {
  prop1: string
  prop2: number
}

export const MyComponent: React.FC<MyProps>

// This one's fine
expectError(MyComponent({ foo: "bar" }))

// This one's also fine
expectError(MyComponent({ prop1: 1, prop2: 2 }))

// This one's also fine
expectError(MyComponent({ prop1: "hey", prop2: 1234, iShouldNotBe: "here" }))

// fixed
expectError(MyComponent({ prop1: "hello" }))

// also fixed
expectError(MyComponent({ prop2: 2}))

It seems the errors I care about are explicitly suppressed here:
https://github.com/SamVerschueren/tsd/blob/3bb25ef8942ba661329d0ef878484c911d53a35a/source/lib/compiler.ts#L20

Sorry for the late reply. I looked into this and it turns out we had a test for this use case
import {Component} from 'react';

interface UnicornProps {
	unicorn: number;
	rainbow: string;
}

export class Unicorn extends Component<UnicornProps> {}

But not when working with ComponentType which produces different errors then when you use extends.
The code block you referenced, namely diagnosticCodesToIgnore is only used in the expectError assertion. It's a list of errors that expectError supports. I added the diagnostic produced with ComponentType to the list and it works as expected now.
Will release in the coming days.

Released as 0.13.1


⚠ Bofrost.de has degraded performance

In 3cf9f90, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1112 ms

Resolved: Bofrost.de performance has improved in 4b42c47.


Applied nested mutation for animal

As nested optional fields are one of the GQL advantages, animalRegistration mutation can be done inside animal mutation.
By this we have more integral data and we don't have to treat both entities separately.

Please take care of test for this to pass. Also left some comments.
It's definitely useful having this approach. However, we lose the ability to change / create registration separately from the animal. We need to send the whole animal mutation to just create the registration. I believe it would be good to have this possibility separately as well

I don't think that there is a point of creating animal registration without animal itself. That even wouldn't be possible, because animal registration requires animal id.

Please take care of test for this to pass. Also left some comments.
It's definitely useful having this approach. However, we lose the ability to change / create registration separately from the animal. We need to send the whole animal mutation to just create the registration. I believe it would be good to have this possibility separately as well

I don't think that there is a point of creating animal registration without animal itself. That even wouldn't be possible, because animal registration requires animal id.

I meant rather the request JSON (knowing animal id), I'll ask front-end how do they imagine these things


Configure updated vertebrates for e103

Jira ticket: https://www.ebi.ac.uk/panda/jira/browse/ENSWEBREL-989
Looks like our updated assemblies are ahead of UCSC. I'm removing the links to the older assemblies at UCSC.
Reference (from the report of updated species):
   "vertebrates" : {
      "new_genomes" : {},
      "removed_genomes" : {},
      "renamed_genomes" : {},
      "updated_assemblies" : {
         "mus_musculus" : {
            "old_assembly" : "GRCm38",
            "name" : "mus_musculus",
            "assembly" : "GRCm39",
            "species_id" : 1,
            "has_variation" : 1,
            "has_microarray" : 1,
            "database" : "mus_musculus_core_103_39",
            "strain" : "reference (CL57BL6)"
         },
         "ailuropoda_melanoleuca" : {
            "old_assembly" : "ailMel1",
            "name" : "ailuropoda_melanoleuca",
            "assembly" : "ASM200744v2",
            "species_id" : 1,
            "has_variation" : 0,
            "has_microarray" : 0,
            "database" : "ailuropoda_melanoleuca_core_103_2",
            "strain" : null
         },
         "gadus_morhua" : {
            "has_microarray" : 0,
            "strain" : null,
            "database" : "gadus_morhua_core_103_3",
            "has_variation" : 0,
            "species_id" : 1,
            "assembly" : "gadMor3.0",
            "name" : "gadus_morhua",
            "old_assembly" : "gadMor1"
         },
         "macaca_fascicularis" : {
            "species_id" : 1,
            "has_variation" : 0,
            "database" : "macaca_fascicularis_core_103_6",
            "strain" : null,
            "has_microarray" : 1,
            "old_assembly" : "Macaca_fascicularis_5.0",
            "name" : "macaca_fascicularis",
            "assembly" : "Macaca_fascicularis_6.0"
         },
         "drosophila_melanogaster" : {
            "has_variation" : 0,
            "species_id" : 1,
            "strain" : null,
            "database" : "drosophila_melanogaster_core_103_9",
            "has_microarray" : 1,
            "old_assembly" : "BDGP6.28",
            "assembly" : "BDGP6.32",
            "name" : "drosophila_melanogaster"
         },
         "anabas_testudineus" : {
            "old_assembly" : "fAnaTes1.1",
            "name" : "anabas_testudineus",
            "assembly" : "fAnaTes1.2",
            "species_id" : 1,
            "has_variation" : 0,
            "database" : "anabas_testudineus_core_103_12",
            "strain" : null,
            "has_microarray" : 0
         },
         "mastacembelus_armatus" : {
            "old_assembly" : "fMasArm1.1",
            "assembly" : "fMasArm1.2",
            "name" : "mastacembelus_armatus",
            "has_variation" : 0,
            "species_id" : 1,
            "has_microarray" : 0,
            "strain" : null,
            "database" : "mastacembelus_armatus_core_103_12"
         }
      },

If the older assemblies are present on UCSC, we should add the assembly mapping, similar to that seen in, e.g. mouse: https://github.com/Ensembl/public-plugins/blob/release/102/ensembl/conf/ini-files/mus_musculus.ini#L20

What's that line used for @ens-ap5 ?

@ens-st3 When someone tries to attach a trackhub with an assembly name that doesn't match either the current Ensembl assembly name for that species or the UCSC equivalent, we check the other mappings and if we find a match, advise the user that they can use one of our archives instead. I can't remember if we suggest a specific archive or if it's just a courtesy message.

Assembly names for the panda, the cod, and the macaque are the same at Ensembl and UCSC. I've updated the mapping for the new mouse assembly.
I'll need to update files for model organisms whose assemblies got updated. E.g. drosophila — I only updated it in eg-web-metazoa.

Turns out, I already updated the drosophila assembly in the ini file a month ago, and completely forgot about this.
@ens-ap5 Would you say this PR is good to merge into species-update?

OK, I'm happy with it!


Adding the SDK manager stuff as a new Service node

It would be great to have not a new window for this AndroidSdkManager stuff, more a new root node inside services tab.
Services
|_Android SDK Manager (Root node)
   |_SDK Platforms
      |_Other nodes
   |_SDK Tools
      |_Other nodes

Regards
Chris

Will be remodeled in #42


Language switch button not working on older Google Chrome versions

I use the academic theme for my website http://hackdown.me/ and on some devices, the menu animations (scrolling) are not displayed and the language switch button just reloads on home page. I tested the menu on two different versions of Google Chrome:

Google Chrome Version 60.0.3112.90 (Official Build) (64-bit) - Menu animations not displayed and language switch button not working
Google Chrome 64.0.3282.167 (Official Build) (64-bit) - Menu animations displayed and language switch button working
Firefox 52.5.2 (64-bit) - Menu animations displayed and language switch button working
I think that on old Google Chrome versions, animations do not exist but the language button should be fixed.

Additional details : I created English and French versions of my website

I updated the website several times and now everything works fine (scrolling animation and menu buttons)! I'll close the issue


feat: replace o1-preview by o1

Description
replaces o1-preview by o1.
o1-preview and o1-mini do not support system messages. o1 supports the new developer messages instead of the system messages, so I added support for that.
Risk
N/A
Deploy Plan
Deploy core, deploy front

thanks, yeah they do @spolu


feat: add api docs

Add etcd-operator api documentation, reference tool: https://github.com/elastic/crd-ref-docs
We can make api-docs to generate the latest api documentation.
Preview: https://github.com/etcd-io/etcd-operator/blob/93d6c9415461c7b47621943c11aa203f7e381c65/docs/api-references/docs.md

Thanks @daviderli614 for the contribution. The generated docs looks great.
cc @jmhbnz @hakman @jberkus @justinsb

@daviderli614 please rebase this PR instead of merging the changes from main.

@daviderli614 please rebase this PR instead of merging the changes from main.

Please rebase and squash the commits. Search "git rebase and squash" on google.

@daviderli614 please rebase this PR instead of merging the changes from main.

Please rebase and squash the commits. Search "git rebase and squash" on google.

Hi @ahrtr
I have made some changes. Please review it again, thank you.


move compiler to babel 7

With this we can use new language features like destructing inside the code.

Will reopen this after Import works again.

I will reopen it after tests running again!

With babel 7 you can use destructuring assignment
  let obj = {
    t1: 1,
    t2: 2
  };
  const obj1 = {t1, ...obj};


Opening a page via injectJavaScript rewrites the last history frame

Bug description:
When I inject script for navigate to another page, the last page in history is replaced with a new one. This means that if I execute .goBack(), WebView opens not the previous page (-1), but the one that was in front of it (-2)
The following script variants performed a transition to a new page, and replaced the last one in the history:
const script = `window.open( '${url}', '_self'); `;

const script = `window.location.href = '${url}';`;

const script = `
history.pushState({}, '', '${url}');
history.go('${url}');
`;

const script = `
var link = document.createElement('a');
link.href = '${url}';
link.target = '_self';
document.body.appendChild(link);
link.click();
`;

To Reproduce:
Option 1

Open any page in WebView
Add any transition script to the page, for example const script = `window.location.href = '${url}';`;
Execute goBack()
Discover that the WebView cannot go back

Option 2

Open any page in WebView
Make 2 clicks on links
Inject script for const script = `window.location.href = '${url}';`;
Execute goBack()
Catch that the WebView did not return to the previous page and return on the second page

Expected behavior:
goBack open previous page, if there was one.
Environment:

OS: android
OS version: android 12
react-native version: 0.73.5
react-native-webview version: 13.8.1

Still relevant

Still seeing this bug


little correction

little correction, it should be Exchange license instead of 0365. may be is not that relevant.

@rdiazel : Thanks for your contribution! The author, @jeevansd, has been notified to review your proposed change.


images_sr = model(images_hr)

At line 1734 in interfaces/super_resolution.py,
images_sr = model(images_hr)

It seems that HR images are input into the model. Is this correct specification?

@chnoguchi Hi, thanks for pointing out that problem, this piece of code is not actually used on our evaluation. Please check eval() function in super_resolution.py. You can directly remove this piece and the project will still perform normally.


Add improvements to the filter of the subscription

Description
The pr adds improvements to the filter of the subscription and reduces the request at the Kubernetes API server.

[x] No pubsubAsyncIterator on the sub-labels.
[x] Check on namespace at the beginning.
[x] Change resolve from a list type query to a query of a single resource based on the metadata of the payload.

/deploy-staging

/deploy-staging

/deploy-staging

/deploy-staging

/deploy-staging

/deploy-staging

/merge


I have a question about IdentityServer4

When IIS restarts or the program pool is recycled, the first verification is very slow.

How should I solve this problem?

this is IdentityServer4 demo:

when I restart api


Incorrect custom shortcut displayed in menus for Run Cell command

Problem Description
I've defined a custom shortcut, Ctrl-Shift-Return, for "Run Cell" (along with the other run commands). While other shortcuts display fine, "Run Cell" displays the shortcut as Ctrl-Return in the Run menu instead, which I believe is (perhaps not coincidentally) the original shortcut. However, the correct shortcut does work just fine.
This is the case in both Spyder 3 and Spyder 4. Ctrl-Shift-Return is the correct shortcut that I set, and indeed works, but it displays as Ctrl-Return... There should be enough space to do so, considering it adds only one extra small character over Alt-Shift-Return that is displayed, and there's a ton of extra horizontal space in the menu. Do you want me to run some more tests on this?

Versions

Spyder version: 3.3.1 and master
Python version: 3.6.6
Qt version: 5.9.6
PyQt version: 5.9.2
Operating System name/version: Windows 8.1 x64

Thanks for filling an Issue about this. If I recall correctly, this happens because the label in the menu is hardcoded for this shortcut. I will take care of it.


way to create / import data using existing JSON as payload

please provide a (or document an existing) way to create / import data using JSON files.
example where it came up:  a 3rd party tool generates product drafts as JSON which should be used in ProductCreateRequests  instead of building the Product Drafts on the PHP API.
what happened is that the user did not use the PHP SDK for that but did it all manually (and ran into OAuth issues). It's propbably just documentation, but I think it would be helpful to provide explicit named constructors "ofDraftJson"  or similar to either the Create Requests or the Draft Model Objects.
It's performance sensitive (batch imports), so there should not be a full object mapping roundtrip involved (validation is done platform-side anyways).   JSON could be provided either as a String or as a PHP associative array.

+1
Another use case would be replication of data from one database to another. ofObject would be a killer feature here.

+1

Hi, as there seems to be demand:  Every Model Object in the SDK (in this case you're probably looking for the *Draft ones) can be created via  its fromArray() function that takes the associative array created by PHP's own json_decode().
The same applies in the opposite direction: all the model objects are done to be cleanly serialized to JSON  via  json_encode($myCommercetoolsModel) .
So practically spoken the following (UNTESTED!) code is the pattern how you can do a bulk import using PHP:
<?php

use Commercetools\Core\Model\Product\ProductDraft;
use Commercetools\Core\Request\Products\ProductCreateRequest;
use Commercetools\Core\Client;
use Commercetools\Core\Config;

$client = Client::ofConfig(Config::fromArray(["clientId" => ""/* to do complete config*/]));

// for every batch of e.g. 100 products do:
    // for each product:
    $productDraftAsArray = json_decode(file_get_contents("./myFile.json"));
    $productDraft = ProductDraft::fromArray($productDraft);
    $addProductRequest = ProductCreateRequest::ofDraft($productDraft);
    $client->addBatchRequest($addProductRequest);
    //
$client->executeBatch();  // SDK will do the requests with a parallelity of (sensible default) 25
echo("added a batch of products");
//
// do next batch

That being said, IF you're importing Products, Prices (JSON or CSV) or other stuff (just CSV) you will still be faster and more robust using the Command-Line import / export tooling.  Especially if you're updating / synchronizing and not just initially bulk importing.  Generating the necessary update actions by "diffing" the current and new JSON is a real pain these tools do for you.
https://github.com/sphereio/sphere-product-import   //  http://sphereio.github.io/nodejs/
(@jayS-de  FYI in case you have something better or tested available)


Add normal framework target so this can be installed outside of CocoaPods.

Said another way, Carthage support would be great - at present the repo doesn't have an xcodeproj with a framework target to build from.

And of course I said that before looking at the PRs, @avalanched's #19 adds an xcodeproj with dynamic framework target to do precisely this. :wink:

@pizthewiz Hey, I just merged pr #19 :+1:
I will be closing this issue, thanks :)


Priors not appearing in Priors/Posts 4-panel plot in main figures section

It looks good except for there being no priors shown. I will take another look at this, I just put this issue here so I don't forget.

It's actually the MLE that is appearing as a stick, not the priors. And I still haven't resolved this.

Fixed this by hacking SSplotPars. Closing.


feat: referenceNode support for reference objects (closes #800)

Fix for #800
Basically popper.js was assuming popper's were always in global (client) coordinates when a reference object was provided instead of a reference element. We now detect reference object usage and calculate coordinates relative to the popper's parent node.
There is now an additional property, referenceNode, which can be provided on a "reference object". popper.js will now position relative to this node when the property is specified.

Sigh! IE11. Will boot up a VM and take a look.

It's been a while since last time I checked, but I think the idea was to allow the consumer to define their own object reference parent node to improve flexibility?

@FezVrasta Yeah, I did see some old comments indicating that would be a desirable approach, however unfortunately it doesn't work that way, at least not at present:

https://codepen.io/anon/pen/JQwGww

You'd also need to implement nodeType in your reference object, in addition to parentNode. However, that also doesn't work, because all DOM methods throw errors (TypeError: Illegal invocation) when you pass them a non-DOM object:
e.g. compareDocumentPosition ends up being called like realDomElement.compareDocumentPosition(referenceObject) which explodes: https://github.com/FezVrasta/popper.js/blob/master/packages/popper/src/utils/findCommonOffsetParent.js#L21

https://codepen.io/anon/pen/qzLbvv

...
However, this PR was actually may second pass at resolving this issue. My first attempt is here.
I'll happily submit that as an alternate resolution, particularly if it means I don't have to touch IE11 😉
My original approach is entirely non-breaking as the alternate behavior is only triggered if a newly defined property exists. If you'd like me to submit it as a PR, just let me know.

Thanks, your other attempt seems cleaner to me, I'd like to merge it if you decide to send a PR.

@FezVrasta Seems as other people have already reference this PR. and I'm still resolving the same issue, I've just pushed it here.

Whoops, hold up. Released there's a couple of issues - not with the functionality, but code structure and comments i.e. getReferenceNode isn't re-exported from utils. Will fix that right now...

Don't worry about the utils re-export, that's a deprecated feature anyways

@FezVrasta No problem. If you don't have any other feedback, then please go ahead and merge this as is.
I was going to change the docs for getReferenceNode, however in doing so I'll just be opening a whole can of worms regarding consistency e.g. There's severakl other functions that are documented as taking an Element parameter but are actually Element|Object.
Additionally there's the whole Node vs Element thing, for this particular piece of functionality a Node is actually acceptable, however I don't want to confuse matters.
So if it's okay with you, I'll leave those sorts of decisions to you 😄 Obviously, feel free to make any changes you desire post-merge.

Yeah type annotations aren't the best in v1... v2 is written from the ground up with Flow so this should get fixed if I'll ever manage to complete it.

Is it possible to release 1.16.0 with this?

ping @FezVrasta
New release for this feat would be great

https://github.com/FezVrasta/popper.js/releases/tag/v1.16.0


Get rid of the need for the matrix in the matrix free operator

Codecov Report

Merging #109 into master will decrease coverage by 0.56%.
The diff coverage is 81.98%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   87.08%   86.52%   -0.57%
==========================================
  Files          43       45       +2
  Lines        1835     1877      +42
==========================================
+ Hits         1598     1624      +26
- Misses        237      253      +16

Impacted Files
Coverage Δ

include/mfmg/dealii/amge_host.templates.hpp
100% <ø> (ø)
:arrow_up:

include/mfmg/dealii/dealii_mesh_evaluator.hpp
0% <ø> (-20%)
:arrow_down:

source/dealii/dealii_trilinos_matrix_operator.cc
90.24% <ø> (ø)
:arrow_up:

...de/mfmg/dealii/dealii_trilinos_matrix_operator.hpp
100% <ø> (ø)
:arrow_up:

.../mfmg/dealii/dealii_matrix_free_mesh_evaluator.hpp
0% <0%> (ø)

...nclude/mfmg/dealii/dealii_matrix_free_operator.hpp
0% <0%> (-100%)
:arrow_down:

...rce/dealii/dealii_matrix_free_hierarchy_helpers.cc
100% <100%> (ø)
:arrow_up:

source/dealii/dealii_matrix_free_smoother.cc
86.66% <100%> (-2.23%)
:arrow_down:

tests/hierarchy_driver.cc
95.31% <100%> (-0.08%)
:arrow_down:

tests/test_hierarchy_helpers.hpp
64.86% <100%> (-0.47%)
:arrow_down:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f91dd3...84cd9ac. Read the comment docs.

still need to clean the history before merging

Done


🐛Bug: [Docs] Copy button sometimes blocks code block content

The copy button on code blocks should probably have a background and the code block should have extra right padding so that it never covers the content if you scroll to the right fully.

Closed by #313


Microsoft Kinect SDK.props ??

Hello,
Thanks for great work.
Can you also provide the properties files?
Thank you

Thanks,
I've updated the repo and you can find some sample .props files here:
https://github.com/jorticus/face-replace/tree/master/props
You'll need to modify them to match your system.
Let me know if you run into any other problems!


Dragging an image in Firefox loads the image URL

I'm opening this issue because:
I am experiencing an issue when dragging images in Firefox. After dragging is complete, I am redirected to URL of the image that was dragged. Works as expected in other browsers.
supporting information:

I use sortable version: 0.9.16
I tested in the following browser (incl. versions): FF 71
Windows, OS X/macOS, or Linux?: macOS 10.14.6

How can the issue be reproduce the problem?
I can reproduce this problem given the following:

Forgive me if this specific issue has already been brought up, but i was unable to find it, at least in open issues. Thank you.

Hey @tbhockey, sadly this is a known problem with firefox. There was no way of fixing this for some time. I don't know if this has changed, but if you find a way to improve or completely fix this behavior it would be great if you could send a PR.

Understood, thank you for the response.

FYI I have no issues on FF 75.0

Closed due to fix in FF 75


declarativeNetRequestWithHostAccess permission is needed for modifyHeaders and redirect

Regarding FB12074754 and FB12074747, a change was made to align with Chrome that requires the declarativeNetRequestWithHostAccess permission for redirect and modifyHeaders dNR actions.
https://github.com/sammacbeth/mv3-compat-tests/blob/367cf7dbe15b201fc8d4a5f5850f867819f8a28c/Shared (Extension)/Resources/manifest.json#L40-L45

@sammacbeth

Thanks for this @xeenon. I added the declarativeNetRequestWithHostAccess to the manifest and now those issues are mostly resolved (addOrReplaceParams does not seem to work though).
I'm not sure this behavior is entirely aligned with Chrome, as the original manifest permissions were sufficient for redirect and modifyHeaders DNR rules. Perhaps, declarativeNetRequest permission and <all_urls> host permissions is sufficient, and the additional declarativeNetRequestWithHostAccess is considered redundant in this case. I'll check if that is the case, then raise a WECG issue to document the inconsistency.


US 02.01.01

As a player, I want to be able to scan QR codes and record a photo of the location or object, and the geolocation of the location or object.
Acceptance Criteria

When scanning a code, allow an option to open camera to take an image of the code's location
Create some kind of dialogue that allows a player to select whether or not to record the geolocation of a code
Store the geolocation and photo in the player's account
Store the geolocation and photo in Firestore

Unknowns

How will photos and locations be stored, will they be attached to account or will they be a separate collection in database
How to open the camera and take an image
How to store the image
How to generate geolocation data

Story Points

4
Number of challenges based around the storage of the geolocation data and the image data
Challenges surrounding how to open and use the camera within the app
Ensure that there is an option for geolocation data and image, it should not be required with every code

Risk Level

High
Challenges in determining how to store photo and location data in Firestore
Challenges in use of the camera within the app
Ensuring that location and photo data are not always required could be challenging

Currently having trouble passing data from the Fragment to the MainActivity, so this does not work 100% although the framework is there


Get the running OS version from the process rather than the platform.

It turns out the OS information returned by the platform can't be trusted
because the platform code is bogus (rdar://problem/42595503). Get the OS
version information from the process instead where it is accurate. This
commit also fixes the test to pass an older deployment target to the
compilation command so that it actually tests the feature we are trying
to exercise.
rdar://problem/42351790
(cherry picked from commit dbf58532c3a277690d28a88a52c4a564fd4fc2d8)

@swift-ci test and merge


CI: Try using ubuntu/focal64 box as a workaround for failing CI

What type of PR is this?
/kind bug

What this PR does / why we need it:
our CI seems to be hitting
https://bugs.launchpad.net/cloud-images/+bug/1939580
which causes the shared folder to not be mounted and eventually
manifests as the hack/ci/e2e-ubuntu.sh not found, because it's not
copied over to the shared folder.
which is resolved by upgrading to a recent kernel (<IP_ADDRESS>). The
generic/ubuntu64 image we have been using appears to be using <IP_ADDRESS>.
Unfortunately, the official ubuntu boxes only ship for virtualbox, which
means that we can't use them in general. But at least let's use them for
our CI, anyone running locally would probably not run into the issue
with the VB shared folders anyway.
Which issue(s) this PR fixes:
None

Does this PR have test?
N/A

Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?

NONE

@saschagrunert I didn't find a way to provide different boxes for different providers. I tried vm.box under the per-provider section but that was just giving me an error locally with libvirt:
Bringing machine 'default' up with 'libvirt' provider...
There are errors in the configuration of this machine. Please fix
the following errors and try again:

Libvirt Provider:
* The following settings shouldn't exist: box

Do you have another idea how to set a per-provider box?

Superseded by #599


Pom validation fixes & version updates

This PR updates the pom.xml file so that it is now a valid pom (previously there were unsupported tags, and the reporting plugins were in unsupported locations). This update also explicitly specifies the versions of the plugins in the org.apache.maven.plugins groupId, so the versions will not default to the version in the super pom of whatever maven version users are using. This should ensure that builds are as repeatable as possible across environments.
I also updated the versions of plugins to the latest available, which required updating the required maven version to 3.0.4. Since 3.0.4 was released in January 2012, I don't anticipate this being a problem for anybody.

I noticed that the surefire plugin is using a pginstrument jar file when running unit tests. I'm not familiar with this and can't find any information about it.
@adamfisk or @oxtoacart  -- do you know what this jar file is being used for when running unit tests? Unfortunately it appears to be compiled with Java 7, which means unit tests do not run under Java 6.
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-surefire-plugin</artifactId>
        <version>2.18.1</version>
        <configuration>
          <skipTests>${skipTests}</skipTests>
          <forkCount>1</forkCount>
          <reuseForks>true</reuseForks>
            <argLine>-javaagent:pginstrument-0.1.0-shadow.jar -Xbootclasspath/a:pginstrument-0.1.0-shadow.jar -Dpginstrument.outfile=LittleProxy.pro</argLine>
        </configuration>
      </plugin>

Now that this has been ruminating for a while, I'd like to get it merged in before it becomes too stale. There are no changes to the actual code, so it should be safe. If anybody does have any information on the pginstrument jar file, we could get that question resolved as part of this PR.

Since this only affects unit tests and the pom file, I'll go ahead and merge, then rebase other changes on top of this.


Problem with multiprocessing?

Hi, thanks a lot for releasing this project.
I wonder if you could give me some advice? I'm trying to adapt your code to a different environment. It's working great for a single thread, when I simple execute train.py,, without using torch multiprocessing. When I try to use it with multiprocessing, it still runs, but I get a screen full of error messages, like these,
*** Error in `*** Error in `python': double free or corruption (out): 0x00007f6598000c80 *** *** Error in `*** Error in `python': double free or corruption (out): 0x00007f6598000c80 *** *** Error in `*** Error in `python': double free or corruption (out): 0x00007f6598000c80 ***
I'm not sure whether it's learning either? I have a TensorFlow implementationn, so I know both my environment and A3C algorithm work.
I just wondered if you've seen this before? It might be something to do with the the action variable, because when I set it to a constant, the error goes away, but of course it doesn't learn then?
Thanks a lot for your help :)

Hi, I need to see your code to understand what might go wrong.

OK, thanks a lot for your offer of help. :)
It's part of a larger project, so I need to make it stand alone. I don't think the problems with your code as it works fine on a single processor. Also my code works fine asynchronously with TF?
Will get back to you very soon! Cheers

Hi, sorry about this - it seems this error was due to a combination of, re-installing TF,
and my screwing up testing my project when porting things over from TensorFlow to PyTorch.
I'm working with a Black Box simulator, and God (and probably the Devil too), only know how it works. Testing with it per simulation is costly time wise, and I've got an austere computational budget?
I might have made a mistake testing, but as far as I can tell your implementation behaves the same as my other TF A3C implementation. So basically I think your codes great :+1:
Thanks once again for releasing it :+1:
On another note - I wonder if you have tried to implement your meta-optimiser for a single thread Actor Critic RL learner? Just curious, because I'm trying to do that now? Hopefully once the meta-optimiser is trained with a single learner, it can then be used for each of the learners in the full A3C?


Add nukkit support

Nukkit is a server software for minecraft bedrock edition

Yea, please add Nukkit Support... It would be so helpful...

I hope so, pls.


Smooth time

Added default config options and flipped digitFade to false as a default value.
Added some Notes to README.
Hope that was what you had in mind.

Thanks! Nice work!


Fix --package  --workspace

What does this PR try to resolve?
Information is available in the following issue #12978
Additional information
Closes #12978

@rustbot author
Also, we recently updated our CI configuration, and this will need to be rebased on the latest master.


Peer to peer review

In this repo

[ ] Created a new empty repo - "Peer-FeedBack-To-do-list
[ ]  Copied previous code from the "To Do list" project and commit it as one big chunk of code in a new branch.
[ ] Opened a pull request.

Thank you


Instance of 'CircularDependencyError'

I got Instance of 'CircularDependencyError' but I don't know the reason for this error.
I have 2 providers that use each other
final calendarStateNotifier = StateNotifierProvider((ref) {
  return CalendarStateNotifier(
      ref.read(scheduleStateNotifier).value, ref.read(mainStateNotifier).value);
});

and
final scheduleStateNotifier = StateNotifierProvider((ref) {
  return ScheduleStateNotifier(ref.read(calendarStateNotifier).value);
});

Providers cannot somehow depend on themselves.
Your calendar depends on the schedule, but the schedule depends on the calendar.
You cannot have both. One of them must go away

Yes.  😅


Evaluate route paths relative to ROOT_URL parameter

When running my meteor app in production mode, my ROOT_URL is defined as www.mysite.com/prototype.
My router file is defined as such:
Router.map(function routerMap() {

  this.route('index', {
    path: '/',
    template: 'index'
  });

});

When going to www.mysite.com/prototype, I get a Exception in defer callback: Error: Oh no! No route found for path: "/prototype" error.
The route path should be evaluated as / instead of /prototype because the ROOT_URL includes /prototype.

There's some discussion of this issue in https://github.com/iron-meteor/iron-router/issues/154 as well.

I created a pull request for this => https://github.com/iron-meteor/iron-url/pull/17
I modified the URL.parse function within the Iron:URL package (that is used from the iron router). now the functions is using the meteor runtime variable ROOT_URL instead of sticking the root url together by itself.

I hit this issue too. I have a temporary fix in the form of the following monkey patch hack which is working for me, but an official fix would be nice
// note: this hack will cause issues if any of your routes are expected to contain
// the same string used in your ROOT_URL_PATH_PREFIX, e.g. if you
// have the url http://yoursite.com/prefix/url/that/repeats/prefix/
(function() {
    Iron.Url._oldParse = Iron.Url.parse;
    Iron.Url.parse = function(url) {
        if (__meteor_runtime_config__.ROOT_URL_PATH_PREFIX) {
            url = url.replace(__meteor_runtime_config__.ROOT_URL_PATH_PREFIX, "");
        }
        return Iron.Url._oldParse(url);
    };
})();


Add typing in python scripts

Add typing in python scripts, reducing chance of making mistakes.

Although I appreciate your work on this, I'm in the midst of a bunch of significant changes and improvements to stubgen. I fear that there will be lots of conflicts. Would it make sense to put this on pause and wait until stubgen is ready to be released? (e.g. closer to the 2.0.0 release)

I thought adding typing can help with development by offering autocompletes and prevent bugs. But sure, just notify my me when ready!

I wrapped up the refactoring of stubgen and also did a stab at adding type information to it.

Looks good, it passes pylance standard type checking. I can help add typing so it passes strict type checking, but I will wait until you are ready.

Please go ahead. I am done with this script for now.

(I pushed one more tiny change)

Please review, thanks!

This is getting kind of large. Would you mind splitting this PR into smaller ones that are easy to accept individually? Many parts of it are edits on lines without code additions. Relatively unobjectionable.
I am less positive about adding quite a bit of typing-related code and data structures (protocols) at the beginning of the file.

I think using protocol can also serve as documenting the data structures of nanobind objects, as well as providing IDE autocompletions.
However, if you insist on not adding protocol-related code, I can prepare another PR with that removed.

Hm, let me do a more thorough pass over it. I do see the value in documenting the data structures.
It's really important that everything makes sense on Python 3.8 even if it is very old.

Rest assure that it is python 3.8 compatible, the non-compatible typings are wrapped in quotes.

All changes done, please review, thanks!

Pushing from above, should we change:
if (
    type(fget).__module__ == "nanobind"
    and type(fset).__module__ == "nanobind"
):
    assert isinstance(fget, NbGetter)
    assert isinstance(fset, NbSetter)
    ...

To:
if isinstance(fget, NbGetter) and isinstance(fset, NbSetter):
    ...

NbGetter and NbSetter has __nb_signature__, we can use this to determine if a property is from nanobind.

That looks cleaner indeed.

All changes done, please review, thanks!

Did you see the other comments above?

All those comments that have been replied to have been taken action. Anything I missed?

Wait I see a re.Pattern, let me patch that

There were a few more (I responded See also this. to each one)

Oh I have taken action in the "Multiple improvements" (bf482084282a9777d6c2190ea2f110c35170d2dd) commit, did that address the problem?

ok I tried to open this github PR page in incognito mode. Seems like my comments could not be seen...?
It has a Pending label on my comment. Pressing Resolve conversation did not make my comments appear...

Oops I completely forgot about adding comments... Copied your comments and added in latest commit.

how about creating it differently with signature Tuple[str, Optional[str], Optional[Tuple[Any, ...]]]

I was so upset that python did not accept Tuple[Optional[str], Optional[str], Any, ...] and had the same thought of changing C++ code so that the default args are in tuple, but I thought you would think this is too much work and did not mention about this.
Should I make this change for you? Or leave this to you?

Could you explain why the func and call elements are needed here?

For the __func__, it was required as I typed the fn in put_function() as NbFunction, and there is access for fn.__func__. It is not required now, let me remove that.
For the __call__ in NbFunction, it is necessary as this is what make a python object a function. I called fn = cast(NbFunction, fn) before self.put_nb_func(fn, name) in put_function() to inform type checker that fn is NbFunction so it does not complain that I am putting an incompatible fn arg to self.put_nb_func. If there is no __call__ I cannot cast fn to NbFunction as fn is originally a Callable[..., Any] and it should cast to a Callable, in which Callable has __call__. If that sound confusing, you can try to remove __call__ in NbFunction and see how a strict type checker react.

If we are doing the change to nb_func.cpp:
diff --git a/src/stubgen.py b/src/stubgen.py
index 955cf68..2fea6d9 100755
--- a/src/stubgen.py
+++ b/src/stubgen.py
@@ -99,17 +99,19 @@ PackagesDict = Dict[str, ImportDict]

 # Type of an entry of the ``__nb_signature__`` tuple of nanobind functions.
 # It stores a function signature string, docstring, and a tuple of default function values.
-# (signature_str, doc_str, default_arg_1, default_arg_2, ...)
-NbSignature = Tuple[Optional[str], Optional[str], Any]
+# (signature_str, doc_str, (default_arg_1, default_arg_2, ...))
+NbSignature = Tuple[Optional[str], Optional[str]]
+
+# Type of an entry of the ``__nb_signature__`` tuple of nanobind functions.
+NbFunctionSignature = Tuple[Optional[str], Optional[str], Optional[Tuple[Any, ...]]]

 # Type of an entry of the ``__nb_signature__`` tuple of nanobind getters and setters.
 NbGetterSetterSignature = Tuple[str, str]

-
 class NbFunction(Protocol):
     __module__: Literal["nanobind"]
     __name__: Literal["nb_func", "nb_method"]
-    __nb_signature__: Tuple[NbSignature, ...]
+    __nb_signature__: Tuple[NbFunctionSignature, ...]
     __call__: Callable[..., Any]

@@ -240,7 +242,7 @@ class StubGen:
         docstr = f'{raw_str}"""{docstr}"""\n'
         self.write_par(docstr)

-    def put_nb_overload(self, fn: NbFunction, sig: NbSignature, name: Optional[str] = None) -> None:
+    def put_nb_overload(self, fn: NbFunction, sig: NbFunctionSignature, name: Optional[str] = None) -> None:
         """
         The ``put_nb_func()`` repeatedly calls this method to render the
         individual method overloads.
@@ -256,45 +258,47 @@ class StubGen:
         sig_str = sig_str[:paren] + self.simplify_types(sig_str[paren:])

         # Substitute in string versions of the default arguments
-        for index, arg in enumerate(sig[2:]):
-            pos = -1
-            custom_signature = False
-            pattern = None
-
-            # First, handle the case where the user overrode the default value signature
-            if isinstance(arg, str):
-                pattern = f"\\={index}"
-                pos = sig_str.find(pattern, start)
-                if pos >= 0:
-                    custom_signature = True
-
-            # General case
-            if pos < 0:
-                pattern = f"\\{index}"
-                pos = sig_str.find(pattern, start)
-
-            if pos < 0:
-                raise Exception(
-                    "Could not locate default argument in function signature"
-                )
+        default_args = sig[2]
+        if default_args:
+            for index, arg in enumerate(default_args):
+                pos = -1
+                custom_signature = False
+                pattern = None
+
+                # First, handle the case where the user overrode the default value signature
+                if isinstance(arg, str):
+                    pattern = f"\\={index}"
+                    pos = sig_str.find(pattern, start)
+                    if pos >= 0:
+                        custom_signature = True
+
+                # General case
+                if pos < 0:
+                    pattern = f"\\{index}"
+                    pos = sig_str.find(pattern, start)
+
+                if pos < 0:
+                    raise Exception(
+                        "Could not locate default argument in function signature"
+                    )

-            if custom_signature:
-                arg_str = arg
-            else:
-                # Call expr_str to convert the default value to a string.
-                # Abbreviate with '...' if it is too long.
-                arg_str = self.expr_str(arg, abbrev=True)
-                if arg_str is None:
-                    arg_str = "..."
-
-            assert isinstance(arg_str, str)
-            assert (
-                "\n" not in arg_str
-            ), "Default argument string may not contain newlines."
-
-            assert pattern is not None
-            sig_str = sig_str[:pos] + arg_str + sig_str[pos + len(pattern) :]
-            start = pos + len(arg_str)
+                if custom_signature:
+                    arg_str = arg
+                else:
+                    # Call expr_str to convert the default value to a string.
+                    # Abbreviate with '...' if it is too long.
+                    arg_str = self.expr_str(arg, abbrev=True)
+                    if arg_str is None:
+                        arg_str = "..."
+
+                assert isinstance(arg_str, str)
+                assert (
+                    "\n" not in arg_str
+                ), "Default argument string may not contain newlines."
+
+                assert pattern is not None
+                sig_str = sig_str[:pos] + arg_str + sig_str[pos + len(pattern) :]
+                start = pos + len(arg_str)

         if type(fn).__name__ == "nb_func" and self.depth > 0:
             self.write_ln("@staticmethod")

diff --git a/tests/test_functions.py b/tests/test_functions.py
index f415e69..d0f3593 100644
--- a/tests/test_functions.py
+++ b/tests/test_functions.py
@@ -420,7 +420,7 @@ def test39_del():
 def test40_nb_signature():
     assert t.test_01.__nb_signature__ == ((r"def test_01() -> None", None),)
     assert t.test_02.__nb_signature__ == (
-        (r"def test_02(j: int = \0, k: int = \1) -> int", None, 8, 1),
+        (r"def test_02(j: int = \0, k: int = \1) -> int", None, (8, 1)),
     )
     assert t.test_05.__nb_signature__ == (
         (r"def test_05(arg: int, /) -> int", "doc_1"),

I am committing anyway as I need to sleep. In case you don't want it, I will just revert the commit.
Please review. Feel free to merge when you are satisfied.

It looks great! Could I ask you to squash this into two commits and rebase on top of master? The first to adapt nb_func.cpp and related tests, and the second one which improves typing of stubgen. I will merge the PR following this. Thanks!

Let me re-open another PR...

Seems like I can reopen here


Update pull_request_template.md

Description

1. Why the change?

2. User API changes

3. Summary of the change

4. How to test?

[ ] N/A
[ ] Unit test: Please manually trigger the Unit test here by inputting the full commit ID (SHA value) of your last commit (e.g., a1b2c3d4e5f6g7h8i9j0). And paste your action link here.
[ ] Application test
[ ] Document test
[ ] ...

5. New dependencies

[ ] New Python dependencies
- Dependency1
- Dependency2
- ...
[ ] New Java/Scala dependencies and their license
- Dependency1 and license1
- Dependency2 and license2
- ...

PR Validation: https://github.com/intel-analytics/ipex-llm-workflow/actions/runs/9753926803

ALL TEST PASSED: https://github.com/intel-analytics/ipex-llm-workflow/actions/runs/9771086304


add more tryCatch in export

@rfeng2023 typically for tryCatch usuallly a warning is made before falling back to a trivial behavior, unless in this case you are 100% sure that users need not be warned.

if (${"TRUE" if exported_file.is_file() else "FALSE"}){",
res_exp <- tryCatch({readRDS(combine_data)}, error=function(x){return(NULL)})

Hi @gaow The logic implemented in this command is designed to handle the processing of exported meta files from previous scenarios. When an exported file is supplied, the command verifies the presence of an existing exported file with specified data (such as geneA with ROSMAP). If found, and there's a need to append new data (like geneA with MSBB), the command reads and merges the new data with the existing file. In contrast, if it's necessary to add data for a different entity (like geneB) for which no exported file exists (unlike geneA, which was previously exported), the command would not report error by read geneB file.  This allows for flexible handling of adding new conditions or incorporating additional genes into the export process.
The choice to omit a warning in the second scenario stems from the belief that the readRDS function is unlikely to encounter numerous failure scenarios, without warning would avoid filling the log file with extensive warnings during the export of multiple genes. However, if adding a warning is considered more prudent for enhancing the process's clarity or for tracking purposes, I am open to incorporating it.

Then sounds like a clearer logic is that instead of tryCatch, an if else statement shoudl be used?
The general point is that tryCatch is typically designed to ensure that most of the case it works out and fail only at unexpected cases. For example to read a file, something like:
try:
   read_file(file)
except:
   warning_message()
   pass

is less clear than
if file.exists():
  read_file(file)

That said, I'm neutral about whatever you do, as long as you can comment it a couple of sentences as comment strings. No warning necessary then.


remove index and storage artifact/source cache type

Once upon a time, we had a non-standard API for storing artifact information. However, we now use the remote asset API which is part of the remote execution APIs. We no longer need to have separate index and storage for the cache.
Even for implementations that separate the CAS and remote asset, we can just push the responsibility to whoever is deploying it to just add a traefik proxy.

Right now the client has the ability to deal with setups where the AssetCache is separate from the CAS, which I think is nice to keep.
Also our API is stable since our last beta, so we can't rightly remove this.
That said, it can be an interesting feature to add which allows the client to communicate with the same URI configuration for both pushing and pulling.
But there is one really big problem with adding such a new feature... looking at the code right now, it appears that the feature is already supported :-/
It is called the all type: https://docs.buildstream.build/master/using_config.html#cache-servers ... and in fact it is the default, so if you specify a cache server and neglect to specify the type, it is assumed to be usable for both indexing and storage.

Indeed, this is not about adding a feature but rather about removing one. I don't think it is useful, and it would be nice to not have to support it. For instance, it is the main reason we still have bst-artifact-server for the tests.
Either way, this needs to be discussed with the other developers and would be either a blocker or a "won't fix".

It’s a clear API break, afaics that ship has sailed.

Let's close this as it is an API break and there does not seem to be an urgent reason to do this.


generating sequence using language model

using interactive.py by pre-trained language model on fairseq, I got generated sequence as below.
S-0     In this test ,
H-0     -2.1058778762817383     In this test , the researchers used a fluorescence microscope to measure the amount of terbium ions in the blood of the volunteers .
P-0     -8.1061 -12.5155 -25.0781 -0.0000 -0.0008 -0.1352 -0.0717 -0.0004 -1.5938 -0.5852 -0.0000 -0.0732 -0.0000 -0.6246 0.0000 -2.7639 -1.0158 -0.0004 -0.0004 -0.0111 -0.0049 -0.0009 -0.0633 -0.0015 0.0000

However, I want to make LM to generate sequences from given some tokens (ex. In this test , in above) in a large-scale. interactive.py is so slow because LM model processes per sample.
Is there way to generate sequences from LM model by using mini-batch?
In this case, I assume input is a few tokens in each lines.
In this test,
Today I went
She was

I also tried generate.py and transformer language-model same as above, but it doesn't seem to work.
$ python generate.py ./adaptive_lm_gbw_huge/data-bin/ --path ./adaptive_lm_gbw_huge/model.pt --sampling --sampling-topk 10 --temperature 0.2 --beam 1 --no-repeat-ngram-size 3  --task language_modeling

| loaded 306688 examples from: ./adaptive_lm_gbw_huge/data-bin/test
| WARNING: 7907 samples have invalid sizes and will be skipped, max_positions=256, first few sample ids=[7906, 6056, 3835, 6495, 3129, 1900, 2065, 2821, 1232, 5719]

you can use --buffer-size to read several sentences at a time in interactive.py (which will be evaluated in a batch) and you can also use --input to specify a file to use as input


Setting attrs for HTML elements; doing so on init; .editorconfig

The commits propose:

being able for the plugin users to set attributes of all the HTML elements that Squire can create via its API;
setting them, along with the block tag and properties, as a Squire construct parameters;
.editorconfig.

Would love to hear your opinions.

Sorry it took a while to get to this. I'm afraid I don't think this is suitable for merging in its current form. I've added various inline comments with issues I noticed, but didn't have time to do a thorough analysis. I think the main thing is to understand when a <div> is needed regardless of standard block type, and to understand the difference between inline, block and container formatting.

It's ok, thanks for your time and the comments, I really missed some cases where div is still needed. I agree with most of the remarks.
So is the idea ok in general? Should I make a new PR applying the appropriate changes (if everything else is ok)?

Yes, the idea is good. Adding an options parameter to the Squire constructor makes sense, and I know some people want default attributes for tags. Be careful with your merge function. The name should not be capitalised as it's a function, not a constructor, and there were some more white-space errors too.


Support for Transactions?

Is there any plan to support transations in DynamoDb using the mapper?
https://aws.amazon.com/blogs/aws/new-amazon-dynamodb-transactions/

@drc-jpoehler If you need a working library for this today, checkout dynamo-easy
disclaimer: I am one of the maintainers of dynamo-easy


Add Bucks CC project story

Take two
PT: https://www.pivotaltracker.com/n/projects/1364344

To staging :+1:


has ir pattern

librealsense
2.25.0 RELEASE

OS
Windows

D415

Please provide a description of the problem

has white ir

when i click install button on the right-top panel in Depth.Quality.Tool.exe

Remove IR pattern preset only has effect when configuring Infrared stream to RGB8 format. Y8 will still produce raw infrared data.
Also, even in RGB8 mode, the device is trying to remove the pattern using color correction (basically erasing the specific color of the projector) but it will not succeed 100%. This is one of the reasons for an additional RGB sensor.

Is there any more question about this issue?
Thanks


Clean site of old artifacts

The current page does not use anything from html5up anymore, so all information can be removed.

ping?

thanks @ottlinger !


optimize

Admittedly, this can take a while to run.
Wants:

Thread/parallelize the calculation loop.
Minimize number of loops needed

Added a gcd version. May not be optimal.

As it turns out, referencing the itunes file objects cause calls to iTunes (which is the engine to access the .itl database). This is slow.
Maybe do a pre-cache to redis or something? First run will take a bit, but every run afterwards will be faster.

http://code.google.com/p/titl/


Enhance Multiway implementation

Benefits:

Limit diagonal movement to same magnitude as horizontal or vertical movement.
Allow diagonal movement and arbitrary direction movement with correct speed when pressing down multiple keys (may be of interest for isometric)

Caveat:

Takes an additional 5% of total frame time on top of current approach in worst-case scenario (smashing combination of 8 keys on a blank screen with 1 entity).

Notes:

See the 8-way example.
Velocity values handled by Multiway are truncated, so diagonal movement is approximated (can be changed).
Solves issue described here
I tried many alternatives to the current implementation, but my benchmarks showed it's not worth it on newest firefox and chrome

checking if we move in only one direction / diagonal so we can avoid Math.sqrt calculations, not worth it
memoization of input parameters, not worth it

There is probably a faster approach to handle diagonal movement only (current one is for generic directions)

I'm still on the fence whether the additional correctness & complexity is needed for Multiway or not (at least for its current uses).
What do you think @starwed? I'd like to hear your input on this.

I have put some more thought to it, it's just overly complicated.
Who needs more than 8 directions for keyboard control?
Joystick / Gamepad support (with arbitrary directions) is already provided by external component.

Closing, since mucaho ended up feeling it was too complicated, and it's also superseded by #1051


WIP general cleanup

Signed-off-by: David Lawrence<EMAIL_ADDRESS>(github: endophage)

@endophage rebase please

@diogomonica rebased

LGTM if tests pass


Add transaction fraud detection using simulated payments dataset

Hi I have added a new SageMaker Sample for fraud detection using simulated transactions dataset. The algorithm it uses for now is XGBoost.
Note . Currently XGBoost doesn't support AUCPR (arc under precision curve) for highly imbalanced dataset....

Hi No problem. will fix this and update the notebook soon

Unless I've missed something... it seems that you've defined the regex for metrics but they weren't really used since you didn't do HPO in this example. I'd suggest not to include metric definition if they are not going to be used.

Outdated - New fraud detection service available