update correct field

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/54493
https://github.com/Expensify/App/issues/54495
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

https://docs.google.com/document/d/1GDPmbvV47VVxucr-tHYjH80VylcJptP0RfGMVy3zanY/edit?tab=t.0#heading=h.j93ukuhgh4on

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/0ba2b12b-3e3d-4358-b4d5-61e989555732

Android: mWeb Chrome
https://github.com/user-attachments/assets/0e225b8b-f306-434b-b14e-b43b800c6673

iOS: Native
https://github.com/user-attachments/assets/ea5fa266-d088-4f92-8119-aa8366fde855

iOS: mWeb Safari

https://github.com/user-attachments/assets/9dd64054-ae84-4241-95da-e50481a7accf

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/3290f0c8-8e84-4f1d-9034-89112fe09d6c

MacOS: Desktop

https://github.com/user-attachments/assets/8d7450eb-e61e-45cb-aadb-332849a7844a

@jayeshmangwani Could you review this PR?

@DylanDylann I'll

You already saw that in the original PR but I missed committing the suggestion for the failure data :(

Haha, we sometimes miss things. I’m reviewing PR in 5 minutes.

@DylanDylann Upon pressing downgrade, nothing happens for me—it just reloads the page. Are you facing the same issue?
https://github.com/user-attachments/assets/da1f2baa-5b48-4911-b2f7-06d3aaf14d6c

As mentioned here, It is a BE bug. currently, the BE only allows the owner of policy downgrade

@DylanDylann , it seems we need to adjust the permissions here. We should display the Plan Type if the user is the owner of the workspace, rather than the Admin.
https://github.com/Expensify/App/blob/8b7096fc4c4d522407a6f51b4fe0fd3543e5feb2/src/pages/workspace/WorkspaceProfilePage.tsx#L331-L334

I think admin should have permission to downgrade and upgrade the workspace as design docs

Okay then BE needs to be adjusted as I am getting BE error

{
    "code": 666,
    "jsonCode": 666,
    "type": "Expensify\\Libs\\Error\\ExpError",
    "UUID": "4d7b2da5-d585-403a-aee7-793621b49e49",
    "message": "Only policy owner can downgrade",
    "title": "",
    "data": [],
    "htmlMessage": "",
    "onyxData": [],
    "requestID": "8f6fa64f085df29a-BOM"
}

@jayeshmangwani I have added a new commit to solve this bug, too

Thanks, testing that issue too

@jayeshmangwani There is a minor problem. The App already updated the selected option when another device updated it. But the background focus still be outdated see the below video
https://github.com/user-attachments/assets/85e09c99-9ffc-4f7b-9e9e-8ae73bd9678e
But this is a bug in SelectionList that will happen to all places where we use SelectionList. Now, we already have a PR to address it separately. I think we can ignore it here

I think we can ignore it here

Sounds good to me

@DylanDylann PR changes looks good, but can we please update the QA Steps to include the testing steps instead of doc link? It seems the tester doesn’t have access to the document , as they’ve commented on this PR https://github.com/Expensify/App/pull/54356#issuecomment-2560320808. Please update that PR with QA Steps as well.

@jayeshmangwani Done. I updated test step for https://github.com/Expensify/App/issues/54495 only

To test https://github.com/Expensify/App/issues/54493, I think we need to wait for the BE change

I think we need to wait for the BE change

Yes we can wait, I think we can update this steps once BE will be fixed

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/dfd2f410-b3ea-4098-81d7-f60ac308a899

Android: mWeb Chrome
https://github.com/user-attachments/assets/846f3c92-0ca0-47b3-865a-b4e48542f42a

iOS: Native
https://github.com/user-attachments/assets/e2032498-918d-4677-8ebe-0f79c20e4c0e

iOS: mWeb Safari
https://github.com/user-attachments/assets/2318b2d9-a7db-45e6-8e83-80f7355af774

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/1b5e234c-74ba-4fe1-8ec6-46a24599149c

MacOS: Desktop
https://github.com/user-attachments/assets/26bddce3-a75d-4b38-ab23-76b184ba8a28

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


OAuth2PasswordGrant does not respect --proxy option

I set up my authenticator as shown in the example:
// app/authenticators/oauth2.js
import OAuth2PasswordGrant from 'ember-simple-auth/authenticators/oauth2-password-grant';
export default OAuth2PasswordGrant.extend();
and run with proxy:
ember server --proxy http://<IP_ADDRESS>:3000 &
but the authenticator request still goes to:
localhost:4200/token
If I add the serverTokenEndpoint setting:
// app/authenticators/oauth2.js
import OAuth2PasswordGrant from 'ember-simple-auth/authenticators/oauth2-password-grant';
export default OAuth2PasswordGrant.extend( {
serverTokenEndpoint: 'http://localhost:3000/token'
});
The request goes to the correct URL but I get a CORS error.
I use the --proxy startup in development to avoid dealing with CORS since the deployed app is reverse proxied through nginx and so there is no cross domain issue.
It seems that the authentication request should respect the --proxy option.

Duh - my server wasn't routing the post. SOLVED.


[WIP] Re-enable journald logger

There were some instances where logging to journald was segfaulting.  It appears to be if a printf-style format specifier was printed.
See https://github.com/ledbettj/systemd-journal/issues/89 for more details
https://github.com/ledbettj/systemd-journal/pull/90 and v1.4.2 should resolve this issue.  Thanks to @djberg96 for finding and reporting this!

👍

This has been running for a while on a test appliance without issue, going to take out of wip now that @djberg96 has fuzzed the library and it is no longer segfaulting


Fix length check in PSSnapinQualifiedName.GetInstance()

Hi,
I came across this when looking at the alerts for this project on LGTM.com (full disclosure: I work on the C# analysis there). The existing check splitName.Length < 0 is redundant, and I believe it should have been splitName.Length == 0, since the constructor of PSSnapinQualifiedName expects an array of length 1 or 2.
You can see the original alert on LGTM.com here: https://lgtm.com/projects/g/PowerShell/PowerShell/alerts/?mode=tree&ruleFocus=1506101336231
Best regards,
Tom

@hvitved Please add empty commit with '[Feature]' in the commit header to run all tests.

Ok, thanks. Sorry, this was not clear to me given the surrounding variable names.

@hvitved Thanks for your contribution!


Allow radiation packages to specify needed optical properties

Radiation packages should be able to indicate which optical properties they are interested in:

total optical depth (tau)
scattering optical depth (tau * omega)
asymmetric scattering optical depth (tau * omega * g)
any number of scattering phase functions

decided to leave this to hack-a-thoners


updated indian first names

👨💻 Changes proposed
Addes Soumya and Chandrakant in the indian first names datasets

[✔ ] My code follows the code style of this project.
[✔ ] This PR does not contain plagiarized content.
[✔ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Hey @chakradhar4
Can't accept this PR because according to the PR/MR policy of Hactoberfest, repos that encourage simplistic PR/MRS (like adding a name or profile to a list or arbitrarily curating content) will be excluded from Hacktoberfest.
Hope to see some quality changes from your side next time. Remember: quantity is fun, quality is key.


please add pfpmoji.json metadata to cardanoscan.io

please add pfpmoji.json metadata to cardanoscan.io

@havealoha please add at least one contract, see here https://github.com/StricaHQ/cardano-contracts-registry#4-add-contracts-details

Is this better @ashisherc  https://github.com/havealoha/cardano-contracts-registry/commit/f3fd81fd370cc441fc88959f8b0fa7085a221769

@havealoha please re-verify the format.  https://github.com/StricaHQ/cardano-contracts-registry#4-add-contracts-details

I think I got it?
https://github.com/havealoha/cardano-contracts-registry/commit/50f7f3606a57328460fda7764fd7885f0ef1af32

@havealoha also plz change as per below,

"contract" to "contracts"
contracts is an array, with your script as one item

@havealoha please convert it to an array, see item 2 in my previous comment

Phew, https://github.com/havealoha/cardano-contracts-registry/commit/f50ec305c6bd09642c3e2b2ad1606606799cb762

@havealoha "languageVersion" is required, the value would be 1 for your. This should be the last change. BTW you could also validate this locally before the see, PR https://github.com/StricaHQ/cardano-contracts-registry#5-validate-your-changes

@havealoha done

I think if the project description will not be shown on the explorer, and
the policy description is shown instead, maybe I'll copy the description
from the project to the policy.
Is the layout of the info displayed in the explorer set in stone? Thoughts
about displaying description?
On Mon, Sep 4, 2023, 23:18 Ashish Prajapati @.***>
wrote:

Merged #5 https://github.com/StricaHQ/cardano-contracts-registry/pull/5
into master.
—
Reply to this email directly, view it on GitHub
https://github.com/StricaHQ/cardano-contracts-registry/pull/5#event-10279296173,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A25MFKZY6KWQMJ4KO5OYOZLXY272NANCNFSM6AAAAAA4LGBKFQ
.
You are receiving this because you were mentioned.Message ID:
@.***
.com>

@havealoha you can add the description to the policy, and it will update on the explorer after merge.


Respawn

Areas need the ability to respawn their contents on their own timers. Perhaps mobs should individually be able to control their respawn as well. This feature should include the ability to limit the number of a particular mob/item loaded into the game at one time.
This could be approached a couple ways that I could think of:

Simple timer once every interval that just immediately spawns in the appropriate number of npcs/items all at once

A progressive approach that is constantly respawning an area at a computed rate such that if the area was left alone for interval length it would fully respawn.

Personally I prefer the approach 2. It keeps players from sitting around for 10 minutes waiting for a respawn.

Perhaps mobs should individually be able to control their respawn as well.

I've thought of doing this as well. I like the idea of having a respawn probability or respawn interval per mob, since some mobs may be rarer than others (I'm thinking mini-bosses or such).
A probability would give the mob a certain chance of spawning per areaRespawnTick (defaulting to 100%).
An interval would say that the mob respawns every number of areaRespawnTicks (defaulting to one).
Let's say you have a super-rare mob that drops a hard to find item, you could limit it to 1 instance total, give it a respawnProbability of 50%, and a respawnInterval of 3. The area's respawnTick is 2 minutes. So if you kill it, there's a good chance it'll respawn within 6-12 minutes but no guarantee.
Alternatively, it could be set up so that the respawnInterval forces it to respawn at least that often, regardless of probability. In that case, there'd be a 50% chance of respawn in the first 5 minutes after killing the mob, but then it'd definitely respawn on the 3rd tick, after 6 minutes.
Either way I like the idea of keeping it configurable at a mob or area level, preferably both.

A progressive approach that is constantly respawning an area at a computed rate such that if the area was left alone for interval length it would fully respawn.

I agree that this is the most desirable and I think that allowing for mob-level respawn configuration would mimic the progressive approach, as explained above.


Ensure all classes have proper ApexDocs

HEDA ApexDocs are getting some publicity (https://partners.salesforce.com/s/education/general/Role_Salesforce.org_Higher_Education). We need to ensure all recent changes to public/global classes and methods contain proper ApexDocs.
ApexDocs example: https://github.com/SalesforceFoundation/HEDAP/blob/master/src/classes/ADDR_Account_TDTM.cls#L62-L69

**lurch: add

Tracking W-018891


Command does not work as expected

Hi all,
I have this question, first of all: for the Identity parameter in the first example, where would we get the ID of the item if it is deleted (I want to refer here to the Audit Log)?
Could you please inform, if possible, where would one find the item ID after it's deleted in the Audit Log of the deletion event (assuming we can't see the item in the Deleted Items in the RB - possible scenario: we can have a lot of items and could not find it in the list)? :)
I noticed that the ObjectID in the Audit appears only as the path, thus can't be used.
Also, the example provided in the article, Get-PnPRecycleBinItem | ? FileLeafName -like ".docx" | Restore-PnpRecycleBinItem is not quite right. If an user would try to use it, he won't succeed.
The right way would be:
Get-PnPRecycleBinItem | where -Property LeafName -like '.docx'
Get-PnPRecycleBinItem | ? {$_.LeafName -like '*.docx'}
Thank you in advance!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a801b64d-a533-6c80-e8d2-8ceba6552945
Version Independent ID: c1d2ada4-de0e-d434-b138-8fa1b904eef3
Content: Restore-PnPRecycleBinItem (sharepoint-pnp)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Restore-PnpRecycleBinItem.md
GitHub Login: @techwriter40
Microsoft Alias: kirks

@officedocsbot assign @yogkumgit

Thanks.

Hello @ramonabadea thanks for your feedback.
To obtain the Id needed for the Restore-PnPRecycleBinItem you need to use the Get-PnPRecycleBinItem cmdlet that outputs it to console.
I created a Pull Request to correct the 2nd example based on your feedback. Thank you!

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @ramonabadea Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@officedocsbot close


many CVEs by ago

I found this blog listed many security reports. Most of them have CVEs and mentioned AFL.
https://blogs.gentoo.org/ago/

Thanks. I believe I've added them all.

In the mean time, lots of new bugs cropped up on Agostino's blog, but we didn't keep up. :(


Get tempo

Add to the API a function for retrieving the current song tempo. Something like get_tempo().
This function should not consider the current tempo offset if one is applied. There should be a separate function for getting the tempo offset itself.

I'm going to change this a little -- if you want the current tempo, you'll have to use the tempo offset.  If you want the current playing tempo, you'll call get_current_tempo()


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/24743

TagBot fix

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/25299

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/26369

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/33347

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/35126

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/38351

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/52143

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/52317

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/52363

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/52903

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/54706

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/85231

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/85227

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/86012

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/86446

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/87293

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/99563


[GLCC] Spring Cloud Admin

Background
Spring Cloud Alibaba (SCA), as a comprehensive solution for microservices, greatly simplifies the development process of microservice applications. But how to check and view the status of SpringCloud microservice clusters, including the number of services, instances, applications, etc., has always been a lack of content in the community ecosystem. Therefore, through this project, we expect to develop a Spring Cloud Admin console that can visually display and monitor the status of microservice clusters.
Task details
Develop a visual console for the Spring Cloud Admin backend. Admin positioning is a visual microservice management platform that allows users to view the entire status of Spring Cloud microservices, including the number of services, instances, applications, and more. At the same time, SpringCloudAdmin should also integrate with mainstream Prometheus and Grafana systems, providing the ability to query and monitor cluster status indicators. Related reference implementation Spring Boot Admin
Deliverables

Complete backend implementation of Spring Cloud Admin
Related user documentation and examples

Related skills

Familiar with Java
Familiar with Spring Spring Boot、Spring Cloud

背景
Spring Cloud Alibaba (SCA) 作为微服务整体解决方案，极大的简化了微服务应用应用开发过程。但如何查查看 SpringCloud 微服务集群状态，包括服务数、实例数、应用数等，一直都是社区生态欠缺的内容。因此，通过此项目，我们期望开发一个 Spring Cloud Admin 的控制台，能够可视化的展示、监控微服务集群状态。

任务详情

开发可视化控制台 Spring Cloud Admin  后端，Admin 定位是一款可视化的微服务管控平台，通过它能够查看整个 SpringCloud 微服务状态，包括服务数、实例数、应用数等。同时 SpringCloudAdmin 还应与主流的 Prometheus、Grafana 系统集成，提供对集群状态的指标查询与监控能力。相关参考实现 Spring Boot  Admin

交付内容

Spring Cloud Admin 完整的后端实现
相关的用户文档与示例

相关技能

熟悉Java
熟悉 Spring、Spring Boot、Spring Cloud

@chickenlj Check out this repository for your business needs!


Added base recipe to ChangeValidatedLambda.

@traceyyoshima I am going to merge this PR, because it looks pretty good to me. I am going to continue writing some tests in a new branch, I'll let you know if I encounter any issues.


fix dup alias, fix client cert paths

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 13 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 9.497%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/handlers/dev/configure.go
0
13
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
359

Relevant Lines:
3780

💛  - Coveralls


ROX-21201: Test sensor deployment enhancement component

Description
Add test for EnhanceDeploymentReadOnly, called by enhanceDeployment.
This test verifies that

the wrap is enhanced with Permission Levels
the wrap is enhanced with Port information
the Deployment Store is not changed (read only operation)

Checklist

[x] Investigated and inspected CI test results
[x] Unit test and regression tests added
[x] Evaluated and added CHANGELOG entry if required
[x] Determined and documented upgrade steps
[x] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
Automated CI tests
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/test all

/retest


Adding Ansys Python Manager article

📝 Description of the feature
Inclusion of article on Ansys Python Manager.
💡 Steps for implementing the feature
Markdown file
🔗 Useful links and references
No response

Hi @abhishekchitwar! Yeah, great idea. Let's do that. Let's include it in our docs. I would add  it to the main landing page of our documentation, and move the existing landing page to a new tab called "Getting started". What do you think?


added apc

Coverage decreased (-3.2%) to 85.824% when pulling 69d89b29b43345c29ec3e8daacb75f77058f4cda on apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on master.

Coverage decreased (-3.2%) to 85.824% when pulling 69d89b29b43345c29ec3e8daacb75f77058f4cda on apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on master.

Coverage decreased (-3.2%) to 85.824% when pulling 69d89b29b43345c29ec3e8daacb75f77058f4cda on apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on master.

Coverage decreased (-4.5%) to 84.528% when pulling 86aefe03137528eeceddb8d85cc06e77e50220ba on apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on master.

Coverage decreased (-4.5%) to 84.528% when pulling 86aefe03137528eeceddb8d85cc06e77e50220ba on apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on master.


cannot build/run because of missing assets file

Hi,
looks like the assets dir is empty?
ERROR in ./src/characters/Enemy.js
Module not found: Error: Can't resolve<EMAIL_ADDRESS>in '/home/arpu/Work/githubsources/another-dumb-zombie-game/src/characters'
 @ ./src/characters/Enemy.js 12:0-51 35:81-87 45:81-87
 @ ./src/managers/Game.js
 @ ./src/ui/Game.svelte
 @ ./src/main.js

ERROR in ./src/characters/Enemy.js
Module not found: Error: Can't resolve<EMAIL_ADDRESS>in '/home/arpu/Work/githubsources/another-dumb-zombie-game/src/characters'
 @ ./src/characters/Enemy.js 11:0-52 35:89-95 45:89-95
 @ ./src/managers/Game.js
 @ ./src/ui/Game.svelte
 @ ./src/main.js

ERROR in ./src/characters/Player.js
Module not found: Error: Can't resolve<EMAIL_ADDRESS>in '/home/arpu/Work/githubsources/another-dumb-zombie-game/src/characters'
 @ ./src/characters/Player.js 8:0-52 29:80-86
 @ ./src/managers/Game.js
 @ ./src/ui/Game.svelte
 @ ./src/main.js

ERROR in ./src/characters/Player.js
Module not found: Error: Can't resolve<EMAIL_ADDRESS>in '/home/arpu/Work/githubsources/another-dumb-zombie-game/src/characters'
 @ ./src/characters/Player.js 7:0-53 29:88-94
 @ ./src/managers/Game.js
 @ ./src/ui/Game.svelte
 @ ./src/main.js

ERROR in ./src/weapons/Pistol.js
Module not found: Error: Can't resolve<EMAIL_ADDRESS>in '/home/arpu/Work/githubsources/another-dumb-zombie-game/src/weapons'
 @ ./src/weapons/Pistol.js 6:0-47 24:80-86
 @ ./src/managers/Game.js
 @ ./src/ui/Game.svelte
 @ ./src/main.js

ERROR in ./src/weapons/Pistol.js
Module not found: Error: Can't resolve<EMAIL_ADDRESS>in '/home/arpu/Work/githubsources/another-dumb-zombie-game/src/weapons'
 @ ./src/weapons/Pistol.js 7:0-46 37:34-39
 @ ./src/managers/Game.js
 @ ./src/ui/Game.svelte
 @ ./src/main.js

ERROR in ./src/weapons/AK47.js
Module not found: Error: Can't resolve<EMAIL_ADDRESS>in '/home/arpu/Work/githubsources/another-dumb-zombie-game/src/weapons'
 @ ./src/weapons/AK47.js 6:0-46 24:78-83
 @ ./src/managers/Game.js
 @ ./src/ui/Game.svelte
 @ ./src/main.js

ERROR in ./src/weapons/AK47.js
Module not found: Error: Can't resolve<EMAIL_ADDRESS>in '/home/arpu/Work/githubsources/another-dumb-zombie-game/src/weapons'
 @ ./src/weapons/AK47.js 7:0-46 38:34-39
 @ ./src/managers/Game.js
 @ ./src/ui/Game.svelte
 @ ./src/main.js

Hi! Yeah, I know. I wanted to avoid duplicating these assets that has to be present here to make builds work on github pages.
You can just copy those assets and put them in src/assets/characters/ & src/assets/weapons/ as required (AK47.mp3 is embedded). Please consider that this experiment is still under (active) development and a lot could be changed, including assets management. Thanks for your :star: and feedback. :blush:


Where to get model_points from?

Hi There, I was wondering what the source to attain the 3D model points.
If there is a paper or a database that would be helpful!
Thanks!

How to run this code.
Please help me. Contact on<EMAIL_ADDRESS>


reduce getHeaders() call in Request::setServer()

[x] Is this related to quality assurance?

Thanks, @samsonasik!


how-to-create-horizontal-scrolling-menu-using-jquery-and-php

Article checklist

[X] Have you used the correct folder and file structure? - see Contribution Guidelines

[X] Is your article properly formatted in Markdown? - see Github Markdown guide

[X] Have you used our preferred heading structure? - H3 (###) and up

[X] Does your article follow any of the suggested structure formats? - see example formats

[X] Is your article over 750 words? - Tool: Wordcounter.net

[X] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[X] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[X] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[X] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[X] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[X] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[X] Have you checked your article for readability? - Tool: Hemmingway
[ ] Have you added sources for quotes and images that aren't yours?

Technical checks

[X] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[X] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[X] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes
This closes #4090

Okay thanks

Hello @Njengab, your article has been filled with codes, that makes it hard to understand the article. Why are you writing CSS for small screens?
Your paragraphs have long texts as examples? And even logically you can't have<h1>, after <p>. Kindly rewrite this article, following the set guidelines on this page.
If you have any questions, I'm here to help you! Thanks.

hello, @jumamiller I have made the changes you requested. Please have a look. thank you.

@Njengab, after some thorough review on your article, I realised it still doesn't have enough content of great value to our community. I'm closing this PR for now( it doesn't mean that it won't be published). I would suggest that you work on it outside the queue, ensure that you do away with all styling(CSS) on the article.
I will reach you on slack with more details.

Hello @Njengab...

Plagiarism check done ✅

@Njengab
it seems this PR is still quite a bit aways from being completed.
As a rule of thumb - please only submit articles (pull requests) with a complete and fully polished article - ready to be published.
All revisions and edits should be completed on your own forked repo (as to not take up room in the queue).
We will be closing this and please re-submit when it is ready to be published as a new PR (and you can add the duplicate label) and ping the reviewer and myself.
Closing a PR does NOT mean the article can not be published (or fixed) it simply means that the edits, revisions, and fixes will happen outside of the queue.
👍
cc @jumamiller


add ETH PHY JL1101 driver (IDFGH-12570)

@me-no-dev this PR is needed before it can be added to Arduino.
Verified working. Tested with this board https://templates.blakadder.com/dingtian_DT-R008.html

Thanks for adding new Ethernet PHY driver! @Jason2866
I suggest submitting the PHY driver to https://github.com/espressif/esp-eth-drivers
The benefit is, the PHY driver can have its own release cycle, which is independent to the release of esp-idf. So the user won't have to wait for the release of esp-idf v5.3 if he wants to use the JL1101 driver in the product.

Since the ETH drivers in the component registry needs IDF 5.3 it makes no sense for this use case The driver should be available in Arduino too, which is based on IDF 5.1

@Jason2866 thanks for your contribution! We do not accept PR's to release branches. We have special backport process for it. In addition, the backports are intended for fixes and not for features.
There is no restriction for Ethernet drivers from component registry to need IDF v5.3.
Therefore, I'm closing this PR and let's discuss the rest at https://github.com/espressif/esp-eth-drivers/pull/28


Reverse the order of terms in the Create Event term dropdown

 Reverse the order of terms in the Create Event term dropdown #694


Test against Django 4.2 and main

At the moment the package is tested up to version 4.1 of Django , we want to test it also with version 4.2 and main to solve in advance any problems related to future versions of Django.

main is already in there but 4.2 wasn't. Thanks!


fix: Make UITextDisplayer constructor backward compatible

Keep constructor backward compatible with earlier that had two arguments, i.e. make the new third optional for existing applications.
Fixes https://github.com/shaka-project/shaka-player/issues/6531

This will make it possible to run existing application that creates an UITextDisplayer object and only supply two arguments to the constructor. A test is added to check this. If the third argument is not given, the old value before PR https://github.com/shaka-project/shaka-player/pull/6477 is used. This fix issue https://github.com/shaka-project/shaka-player/issues/6531.

Great Álvaro with the deprecate message. I have teested it, ok.
Sorry I was late this morning. I now see that you have commit it and also merge it. I will not take any action.
Thanks!


add end_date property to email_verification template

-remove old email template files
-add end_date property to email_verification template
-pylint
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #1975 (20e3903) into main (d8c482b) will increase coverage by 0.03%.
Report is 5 commits behind head on main.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main    #1975      +/-   ##
==========================================
+ Coverage   69.37%   69.40%   +0.03%
==========================================
  Files         443      443
  Lines       13588    13612      +24
  Branches     1015     1015
==========================================
+ Hits         9426     9448      +22
- Misses       3974     3976       +2
  Partials      188      188

Flag
Coverage Δ

metapi
77.96% <71.42%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...src/met_api/services/email_verification_service.py
77.93% <71.42%> (ø)

... and 6 files with indirect coverage changes


💡 [REQUEST] - upstage/SOLAR-10.7B-Instruct-v1.0

Model introduction
We introduce SOLAR-10.7B, an advanced large language model (LLM) with 10.7 billion parameters, demonstrating superior performance in various natural language processing (NLP) tasks. It's compact, yet remarkably powerful, and demonstrates unparalleled state-of-the-art performance in models with parameters under 30B.
We present a methodology for scaling LLMs called depth up-scaling (DUS) , which encompasses architectural modifications and continued pretraining. In other words, we integrated Mistral 7B weights into the upscaled layers, and finally, continued pre-training for the entire model.
SOLAR-10.7B has remarkable performance. It outperforms models with up to 30B parameters, even surpassing the recent Mixtral 8X7B model. For detailed information, please refer to the experimental table. Solar 10.7B is an ideal choice for fine-tuning. SOLAR-10.7B offers robustness and adaptability for your fine-tuning needs. Our simple instruction fine-tuning using the SOLAR-10.7B pre-trained model yields significant performance improvements.
Model URL
https://huggingface.co/upstage/SOLAR-10.7B-Instruct-v1.0
Data type
float16
Additional instructions (Optional)
No response
Author
No
Security

[X] I confirm that the model is safe to run which does not contain any malicious code or content.

Integrity

[X] I confirm that the model comes from unique and original work and does not contain any plagiarism.

These are the results I got.

Before publishing the scores, can you quickly check if the scores are consistent to your repros and check my usage scripts here: https://github.com/evalplus/evalplus/blob/7b8371379defb135e6c4cffcd9736fa4e13291ef/codegen/model.py#L178

Update: improved the parsing to get better MBPP scores:

I have updated the scores on the leaderboard but feel free to correct me if my usage is wrong. :)


feat: unused code

remove inexisting align property in readme
remove unused function in docker-utilities... maybe there is a reason to keep it?

The align works with GFM, so I'd like to keep it.


[FEAT] Maintain the size of the top information bar on the window at various zooms

Figma and Framer both maintain the same typography size and button size for the top navigation over windows. It would be nice if we could also do the same for Onlook.
So rather than scaling up the buttons and text on zoom, they remain consistent:

Also align the buttons to go all the way to the left and right edge of the window – they seem to have a little bit of padding
Technical recommendation: We're applying transform and scale on these. Perhaps they can be ignored.

It would be nice to also do this for the dimension labels #259
Figma does this well when zooming in and out on the canvas.

Hey @Kitenite Can I take this issue up!

@kartik-raj7 go for it!


seeding_date updated

…roject schedule and actuel date

Good work. rollback and db:setup works with new dates.

Approved


It would be good if Hebrew OCR could detect Latin words like how Serbian Cyrillic .traineddata can detect a switch to Latin

After noticing that .traineddata for Serbian Cyrillic can detect a switch to Latin when there are like several Latin words in a row, I thought that I should mention this...
Since Hebrew looks much more distinct from Latin, it should be easier for OCR engine to detect if there is an English word in a Hebrew text... and it would be really good to have that, especially if someone wanted to do OCR of some books for learning Hebrew or some dictionary or something like that...
Obviously, in cases where it is not very clear is it Hebrew or Latin (like if there were just some individual letters that can look similar in some fonts), then it should just default to Hebrew... like if there was just the Latin letter "I" somewhere, it shouldn't assume that it would be a Latin letter if there aren't any Latin letters near it because "vav" (letter "ו") in Hebrew can look kind of similar in some fonts.
But if there are whole words and it is very clear is it Latin or Hebrew, then it would be very useful to detect the switch.

Something like this is already implemented:
https://github.com/tesseract-ocr/tessdata_fast/blob/master/script/Hebrew.traineddata

@MaxPower85, is that solution sufficient? Or does giving more than one language to Tesseract help? Then please close this issue.

@zdenop, please close this issue.

I've tested the "Hebrew.traineddata" now... yes, that seems to work for texts that have mixed Hebrew and English words...
But it would be good if there was a version of "Hebrew.traineddata" in https://github.com/tesseract-ocr/tessdata and https://github.com/tesseract-ocr/tessdata_best also.

It should be there in tessdata_best. Look under the script folder.
ShreeDevi

भजन - कीर्तन - आरती @ http://bhajans.ramparivar.com
On Wed, May 9, 2018 at 7:24 PM, zdenop<EMAIL_ADDRESS>wrote:

Closed #1548 https://github.com/tesseract-ocr/tesseract/issues/1548.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/tesseract/issues/1548#event-1617677531,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE2_owbDinKREn-VXS45i9O69a9cgDuaks5twvT6gaJpZM4Tvlj3
.


[bn] Localize content/bn/chaos-engineering.md

Describe your changes: Completely Localized Chaos Engineering in Bengali.
Signed-off-by: Tanmay Sarkar<EMAIL_ADDRESS>Localizes content/bn/chaos-engineering.md  to Bengali.
This is an initial PR as may need some improvements!
Tracking issue: #410

@mitul3737 @Mouly22 @Imtiaz1234 @ikramulkayes Take a look.

@mitul3737 Look again.


Bug - Challenges not saving

We git cloned the repo today and are encountering an issue that we did not have with 1.x. When creating challenges they are not saving. Hitting the save button does nothing and does not provide feedback. There is no errors in the logs related to it when the challenge is fully filled out. If pre-requisite is left blank, the following error is thrown:
angular.js:13307 TypeError: Cannot read property 'type' of null
    at Scope.$scope.saveChallenge (challenges.js:390)
    at angular.js:14723
    at expensiveCheckFn (angular.js:15146)
    at callback (angular.js:24614)
    at Scope.$eval (angular.js:16888)
    at Scope.$apply (angular.js:16988)
    at HTMLFormElement.<anonymous> (angular.js:24619)
    at HTMLFormElement.dispatch (jquery.js:4732)
    at HTMLFormElement.elemData.handle (jquery.js:4544)

Seems to be a bug with the newest version. Please let us know if you need any other logs or data.

Sorry about that, there was an issue with the resource methods where creation would not work.  I'm pushing the fix now.


feat(batch,stream): support create iceberg source

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Related issue https://github.com/risingwavelabs/risingwave/issues/14742
Support create iceberg source.
iceberg source could not be used in streaming queries.
iceberg source enumerator only checks source schema against iceberg schema.
Because iceberg source has its own row format and doesn't need to be specified by users explicitly, we could omit it.

Iceberg source Example
create source s
( user_id bigint, user_name string)
with (
    connector = 'iceberg',
    catalog.type = 'storage',
    warehouse.path = 's3a://hummock001/',
    s3.endpoint = 'http://<IP_ADDRESS>:9301',
    s3.access.key = 'minioadmin',
    s3.secret.key = 'minioadmin',
    s3.region = 'us-east-1',
    database.name='demo_db',
    table.name='demo_table'
);

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

    warehouse.path = 's3a://hummock001/',
    s3.endpoint = 'http://<IP_ADDRESS>:9301',
    s3.access.key = 'minioadmin',
    s3.secret.key = 'minioadmin',
    s3.region = 'us-east-1',

iceberg source
kinesis source/sink (src)
avro/protobuf definition from S3 (src)

s3.access.key
aws.credentials.access_key_id (kinesis.credentials.access)
access_key

s3.secret.key
aws.credentials.secret_access_key (kinesis.credentials.secret)
secret_key

s3.region
aws.region (kinesis.stream.region)
region

We have so many different names for the same aws concepts, and this list may not be exhaustive ...
Not a blocking issue as we can just support many different aliases. But would like to bring it to people's attention.

We have so many different names for the same aws concepts, and this list may not be exhaustive ...
Not a blocking issue as we can just support many different aliases. But would like to bring it to people's attention.

We have iceberg sink and I just think iceberg source should have similar field names to the sink.


Rewrite releaser for clarity

The code in releaser.go which builds a record of what to do with each image/container is very difficult to follow, and therefore difficult to modify. It could do with a rewrite to clear things up (after writing a test to guard against regressions!).

Sam, can this be closed, or is there more to be done do you think?

There'll always be refactoring to do, this isn't a special case anymore :)


fix: expo router main file

This PR is for the problem of not finding the correct path for the expo-router on android devices when using monorepo.

@juliusmarminge fyi.

@juliusmarminge i can't merge this, can you help?


Error: Cannot find module 'jimp'

Expected Behavior
var Jimp = require('jimp'); to load the requested modules.
Checked the node_modules folder and it only has the browser and fonts folders.
Dist folder seems to be missing.
No errors when running npm install.
Using in node env not browser.

Current Behavior
Error: Cannot find module 'jimp'

Failure Information (for bugs)

Steps to Reproduce
npm i --save jimp
var Jimp = require('jimp');
Screenshots

https://i.ibb.co/dbr79sM/Screenshot-042819-031817-AM.jpg
https://i.ibb.co/wsyfVXs/Screenshot-042819-031913-AM.jpg
Context

Jimp Version: 0.6.1 & 0.6.2
Operating System: Windows
Node version: 10.15.1

Failure Logs

Same here....
I think the dist/ folder wasn't published.
When I tried installing with Node 12 the message was:
Cannot find module '/Users/danielgraham/appium/node_modules/jimp/dist/index.js'. Please verify that the package.json has a valid "main" entry

dist/ wasn't there only browser/.

I'd recommend unpubishing 0.6.2 and then republishing 0.6.3 as the latest once the problem has been figured out.

@dex-labs @dpgraham how does 0.6.3 look?

Now I am receiving:
Error: Cannot find module '@jimp/types'

Okay I synced all the package versions and changed lerna to force publish all of them. 0.6.4 should work 🙏

0.6.3 worked for me

0.6.4 worked for me.  The 0.6.3 publish was giving "Error: Cannot find module '@jimp/types'" for me.

sweet. sorry for the fuss!

Everything's good now! Thanks for the quick response.

All is good in the world once again


Update cake.component.css

Hi @anshuman35! Thank you for the pull request! Could you please explain why you made this change?


Some pdf file can't be preview

What were you trying to do?
Preview a pdf file and add watermark
How did you attempt to do it?
<html>
  <head>
    <meta charset="utf-8" />
    <script src="https://unpkg.com/pdf-lib"></script>
  </head>

  <body>
    <iframe id="pdf" style="width: 100%; height: 100%;" type="application/pdf"></iframe>
  </body>

  <script>
    createPdf();
    async function createPdf() {
      const existingPdfBytes = await fetch('./test.pdf').then((res) => res.arrayBuffer());
      const pdfDoc = await PDFLib.PDFDocument.load(existingPdfBytes);
      const pdfDataUri = await pdfDoc.saveAsBase64({ dataUri: true });
      document.getElementById('pdf').src = pdfDataUri;
    }
  </script>
</html>

What actually happened?
Nothing render, and no error in devtools console.

What did you expect to happen?
Render the pdf file
How can we reproduce the issue?
run the index.html in http-server.
Version
1.17.1
What environment are you running pdf-lib in?
Browser
Checklist

[X] My report includes a Short, Self Contained, Correct (Compilable) Example.
[X] I have attached all PDFs, images, and other files needed to run my SSCCE.

Additional Notes
test.pdf
test.pdf

Same issue


Delete this.

This should not exist.

hmm ... why?

https://www.davidhaney.io/npm-left-pad-have-we-forgotten-how-to-program/

https://www.davidhaney.io/npm-left-pad-have-we-forgotten-how-to-program/

Unlike in npm in deno.land/x I cannot remove an already uploaded package. Apart from that the package is accessible from github or nest.land


MSB3073: Sdk.targets The command exited with code 1

Installed the template and added all the sql files + 1 post deployment script. When go to build the project. It failes with MSB3073 error.
File: sdk.targets
Points to this line:
<Exec Command="$(DacpacToolCommand)" ConsoleToMsBuild="true" EchoOff="true" StandardOutputImportance="Low"
          Condition="'$(DesignTimeBuild)' != 'true' AND '$(BuildingProject)' == 'true'">

in
<Target Name="GetIncludedFiles" DependsOnTargets="ValidateEnvironment">     <!-- Build arguments for the command line tool  -->     <PropertyGroup>       <PreDeploymentScriptArgument>@(PreDeploy->'--predeploy %(Identity)', ' ')</PreDeploymentScriptArgument>       <PostDeploymentScriptArgument>@(PostDeploy->'--postdeploy %(Identity)', ' ')</PostDeploymentScriptArgument>       <DebugArgument Condition="'$(MSBuildSdkSqlProjDebug)' == 'True'">--debug</DebugArgument>       <DacpacToolCommand>dotnet "$(DacpacToolExe)" collect-includes $(PreDeploymentScriptArgument) $(PostDeploymentScriptArgument) $(DebugArgument)</DacpacToolCommand>     </PropertyGroup>     <!-- Run it, except during design-time builds -->     <Message Importance="low" Text="Running command: $(DacpacToolCommand)" />     <Exec Command="$(DacpacToolCommand)" ConsoleToMsBuild="true" EchoOff="true" StandardOutputImportance="Low"           Condition="'$(DesignTimeBuild)' != 'true' AND '$(BuildingProject)' == 'true'">       <Output TaskParameter="ConsoleOutput" PropertyName="IncludedFiles" />     </Exec>     <Message Importance="low" Text="Included Files: $(IncludedFiles)" />   </Target>

Please share your csproj (and format as code)

<Project Sdk="MSBuild.Sdk.SqlProj/2.0.0">
    <PropertyGroup>
        <TargetFramework>netstandard2.0</TargetFramework>
        <SqlServerVersion>Sql150</SqlServerVersion>
        <!-- For additional properties that can be set here, please refer to https://github.com/rr-wfm/MSBuild.Sdk.SqlProj#model-properties -->
    </PropertyGroup>

    <PropertyGroup>
        <!-- Refer to https://github.com/rr-wfm/MSBuild.Sdk.SqlProj#publishing-support for supported publishing options -->
    </PropertyGroup>

    <ItemGroup>
      <None Remove="GetIntegrations.sql" />
      <None Remove="GetIntegrationsByIntegratingEntity.sql" />
      <None Remove="IntegratingEntities.sql" />
      <None Remove="IntegratingEntityMappings.sql" />
      <None Remove="IntegrationTypes.sql" />
      <None Remove="RemoveIntegration.sql" />
      <None Remove="UpdateIntegration.sql" />
    </ItemGroup>

	<ItemGroup>
		<PostDeploy Include="..\Post-Deployment\Script.PostDeployment.sql" />
	</ItemGroup>
</Project>

Also get this error when right click db project => properties:
Microsoft.VisualStudio.ProjectSystem.Query.QueryExecutionException: Object reference not set to an instance of an object. ---> System.NullReferenceException: Object reference not set to an instance of an object.    at Microsoft.VisualStudio.LanguageServices.CSharp.ProjectSystemShim.EntryPointFinder.FindEntryPoints(INamespaceSymbol symbol)    at Microsoft.VisualStudio.ProjectSystem.Properties.StartupObjectsEnumGenerator.<GetListedValuesAsync>d__8.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at Microsoft.VisualStudio.ProjectSystem.PropertyPages.PageDynamicEnumProperty.<CreateAdmissibleValuesAsync>d__6.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.VisualStudio.ProjectSystem.VS.Query.SupportedValueDataProducer.<CreateSupportedValuesAsync>d__1.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.VisualStudio.ProjectSystem.VS.Query.QueryDataFromProviderStateProducerBase1.d__0.MoveNext()
--- End of inner exception stack trace ---
at Microsoft.VisualStudio.ProjectSystem.Query.QueryExecution.QuerySubscription1.<RunQueryOnceAsync>d__9.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.VisualStudio.ProjectSystem.Query.QueryExecution.QuerySubscription1.<>c__DisplayClass8_0.<b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.PropertyPages.Designer.ProjectPropertyDataAccess.Observer.d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()    at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.PropertyPages.Designer.ProjectPropertyDataAccess.Observer.<CreateAsync>d__9.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.PropertyPages.Designer.ProjectPropertiesEditor.<>c__DisplayClass0_0.<<-ctor>b__0>d.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.PropertyPages.Designer.AsyncLoadContent.<>c__DisplayClass0_0.<<Initialize>b__0>d.MoveNext()

Could you share the full output of dotnet build as well? First time I'm seeing this, so we're just trying to figure out where it goes wrong exactly.

Found the issue with PostDeployment script. It was not pointing to correct folder. I updated it and the dotnet build works fine now. However I still get the error throws when trying to bring up properties view for the project.
Microsoft.VisualStudio.ProjectSystem.Query.QueryExecutionException: Object reference not set to an instance of an object. ---> System.NullReferenceException: Object reference not set to an instance of an object. at Microsoft.VisualStudio.LanguageServices.CSharp.ProjectSystemShim.EntryPointFinder.FindEntryPoints(INamespaceSymbol symbol) at Microsoft.VisualStudio.ProjectSystem.Properties.StartupObjectsEnumGenerator.<GetListedValuesAsync>d__8.MoveNext() --- End of stack trace from previous location where exception was thrown --- at

@jmogera What version of Visual Studio are you using? I haven't seen this before to be honest.

Can you share a repro project?

db.zip

I was looking at the wrong branch- everything builds and project properties work fine for me.

Not sure what you mean "Remove". in the syntax? or the file name itself?

@jmogera Is this still an issue with VS 17.4?

Closing as this seems to be a VS issue, and may have been fixed in later versions.


Added detail on code behind requirements on Popup page

Fixes issues #114 by adding some extra detail around the code behind requirements for a XAML based Popup.

Docs Build status updates of commit 5c59cad:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/views/popup.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 03a2409:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/views/popup.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6b9c765:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/views/popup.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Don't memoize strings when hashing since two identical strings may have different python ids

When hashing an object that has several times the same string, the hashing could return a different hash if the identical strings share the same python id() or not.
Here is an example code that shows how the issue can affect the caching:
import json
import pyarrow as pa
from datasets.features import Features
from datasets.fingerprint import Hasher

schema = pa.schema([pa.field("some_string", pa.string()), pa.field("another_string", pa.string())])
features_from_schema = Features.from_arrow_schema(schema)
Hasher.hash(features_from_schema) # dffa9dca9a73fd8c

features_dict = json.loads('{"some_string": {"dtype": "string", "id": null, "_type": "Value"}, "another_string": {"dtype": "string", "id": null, "_type": "Value"}}')
features_from_json = Features.from_dict(features_dict)
Hasher.hash(features_from_json) # 3812e76b15e6420e

features_from_schema == features_from_json # True

This is because in features_dict, some strings like "dtype" are repeated but don't share the same id, contrary to the ones in features_from_schema.
I fixed that by disabling memoization for strings.
This could be optimized in the future by implementing a smarter memoization with a special handling for strings.

This change slows down the hash computation a little bit but from my tests it doesn't look too impactful. So I think it's fine to merge this.


Hanging testcase

Thank you for this package, it is such an important piece. Please find attached 2 minor things I ran into.
As far as I can see, this fixes #9.

Thanks!


Using query parameters in require statements: require('~/assets/something?test=true')

Hi, I've encountered an issue I think might be due to the magic import handling for assets. Using nuxt 1.0.0-rc11.
I'm using responsive-loader to resize images from assets.
If I configure the loader in nuxt.config.js like this:
 extend: (config, { isClient }) => {
      const urlLoader = config.module.rules.find(
        rule => rule.loader === 'url-loader'
      );
      urlLoader.test = /\.(gif)$/;

      config.module.rules.push({
        test: /\.(jpe?g|png)$/i,
        loader: 'responsive-loader',
        options: {
          placeholder: true,
          placeholderSize: 20,
          sizes: [300]
        }
      });
    },

...then this works:
require(`~/assets/images/${item.key}/${i}.png`)

However, if I add a query parameter:
require(`~/assets/images/${item.key}/${i}.png?sizes[]=300`)

I get:
 Cannot find module "~/assets/images"

Is this due to import handling, or have I misconfigured the loader?

This question is available on Nuxt.js community (#c1673)

Because this bug report seems to be inactive for quite some time, I'll close it now. If you feel like it deserves some attention because it's not fixed, feel free to ping me and I'll reopen it.


Example for a project using a package lock file

Hello again, I don't see an example of a project using a package lock file on the repo. Looking through some of the issues, I see that the API for adding packages is also different than usual. I don't see where to go from here, and it might be troubling for other newcomers as well.
Could you add some example/s where a package lock is used in a project?

Hey, so the package lock essentially allows to manage dependencies from a single file in large projects, without needing to change other CMake files. You can see an example usage in my modern-wasm-starter project.
Note that it's more of an advanced feature and not suited for library projects. If you don't already see the need for it, I'd recommend against using it in your projects.

Ah, thanks for the link to the example project. I still think it would be worth putting some example usage in the readme or wiki though.
Anyways, thanks again, I'll close this now.


Reactions issues

GitHub replaced their old JS-based dropdown with summary+details. So here are some necessary changes.

I wasn't able to restore the show-popup-on-hover for whatever reason. opacity !important is ignored and it stays 0.
It might need to be implemented via JS (mouseenter -> trigger click). Let's merge these visual fixes for now and then open an issue to restore the feature.

A tiny z-index issue.


Derive Debug, PartialEq and Eq for module errors

Closes: #1281
Description
This PR (currently) only derives these traits for errors in the ibc crate, but we could do this for all public errors.

For contributor use:

[ ] Added a changelog entry, using unclog.
[ ] If applicable: Unit tests written, added test to CI.
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation (docs/) and code comments.
[ ] Re-reviewed Files changed in the Github PR explorer.

I just want to point out that the derive attributes are being applied to the ErrorDetail struct, not Error. This is because Error contains the error tracer like eyre::Report, and we cannot in general derive trait implementations that make sense. For example, what does it means for two error tracers to be equal? They probably do not even implement the Eq trait.
The best we can do is to explicitly have custom implementations that somehow ignore the error tracer. For example, we can have a custom implementation of Eq for error, by comparing only the ErrorDetail field and ignore the error tracer. Even then, the implementation may violate laws and assumptions of the traits and result in bugs.

Maybe we could also provide a impl Deref<Target=ErrorDetail> for Error for ease of use.

That is a good idea! I could try that out.


dropbear: 2022.82 -> 2022.83

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dropbear/versions.
meta.description for dropbear is: "A small footprint implementation of the SSH 2 protocol"
meta.homepage for dropbear is: "https://matt.ucc.asn.au/dropbear/dropbear.html"
meta.changelog for dropbear is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2022.83 with grep in /nix/store/dw9bxz6pw55b91661lxx5fprgavlwp9i-dropbear-2022.83
found 2022.83 in filename of file in /nix/store/dw9bxz6pw55b91661lxx5fprgavlwp9i-dropbear-2022.83

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
dropbear

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dw9bxz6pw55b91661lxx5fprgavlwp9i-dropbear-2022.83 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dropbear https://github.com/r-ryantm/nixpkgs/archive/488b8d231c0909022509fa53718beb7e1a9ac155.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dw9bxz6pw55b91661lxx5fprgavlwp9i-dropbear-2022.83
ls -la /nix/store/dw9bxz6pw55b91661lxx5fprgavlwp9i-dropbear-2022.83/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

dropbear

Maintainer pings
cc @abbradar for testing.

Result of nixpkgs-review pr 204068 run on x86_64-linux 1

1 package built:

dropbear


provide a way to specify resource groups

provide a way to define groups

based on resources types / labels

add a parameter to the deploy task to take a list of groups.
add a boolean parameter to deploy all resource groups.

--allGroups option has been added for deploy and generateYaml tasks

--group option has been added for deploy and generateYaml tasks

Current implementation is not based on resource types / labels, but a simple group attribute on the EnvResource and EnvResources annotations.


[feat]: Add link to github tag release in About

Is your feature request related to a problem? Please describe.
We should include a link that opens the release tag in the About section eg
https://github.com/axonops/axonops-workbench-cassandra/releases/tag/0.1.1-internal-20240826
Just add the update the github URL to have the app version in there

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."


[form] Save and Cancel buttons hidden when mouse out of panel

Actual behaviour
In a panel inside a form :

The Edit button appears only when the mouse is over the panel => OK
I click the Edit button and switch to edition mode => OK
The buttons are now Save and Cancel => OK
The buttons disappears when the mouse it out the panel => KO

Expected behaviour
Once in edit mode in a panel, the buttons should not disappear when the mouse is out the panel.
Versions

focus-core : 0.11.0
focus-components : 0.7.3-5

The fix doesn't seem to cover all of the cases:  we have a form with the property "hasForm" set to False and the buttons disappear when the mouse is out of the section.
The fix should also be applied to sections with the property "hasForm" set to false.
Thank you
@pierbrisson


Molecule class

Added a molecule class with psi4 geometries, basis set, number of electrons, and number of doubly occupied orbitals.

@dgasmith Fixed all comments

Awesome thanks!


fix: forward_id_buffer full blocking training

close. Because relevant code removed in https://github.com/PersiaML/PersiaML-server/pull/18/commits/511f18d13c480b8e1f96d0b49e6a0664fdfc70ba.


Thaumatorium recipe for spiritus crystals is missing

(Beta 24) The teeny-tiniest of bugs. A sliver of a bug, if you will =P
Upon inserting a quartz sliver into the thaumatorium, it offers you 36 different crystal recipes - one for each aspect. Except, there are 37 aspects in Thaumcraft. Spiritus is missing in the recipe list of the thaumatorium, so you cannot use it to convert spiritus essentia into crystals.
Not like it's difficult to just use a crucible instead, but for completeness' sake...

Dupe of #1260


Kylin 3977

add ResourceStore.delete(respath, timestamp) interface & impl
add ResourceStore.updateTimestamp(respath, timestamp) interface & impl
update resource timestamp when reusing dict/snapshot
Retry avaibility build process of dict & snapshot
refactor metadata cleanup by using delete with timestamp interface

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 4454

161 of 357 (45.1%)  changed or added relevant lines in 13 files are covered.
189 unchanged lines in 14 files lost coverage.
Overall coverage increased (+0.2%) to 28.035%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceSQL.java
0
1
0.0%

core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java
34
35
97.14%

core-common/src/main/java/org/apache/kylin/common/persistence/FileResourceStore.java
13
15
86.67%

core-dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotManager.java
31
37
83.78%

engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java
0
6
0.0%

core-common/src/main/java/org/apache/kylin/common/persistence/PushdownResourceStore.java
0
8
0.0%

core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
0
14
0.0%

core-common/src/main/java/org/apache/kylin/common/persistence/HDFSResourceStore.java
1
17
5.88%

core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java
35
52
67.31%

server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java
47
65
72.31%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java
1
0.0%

storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseResourceStore.java
1
0.0%

core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceSQL.java
1
0.0%

core-dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotManager.java
1
75.0%

server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java
1
71.53%

core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceStore.java
1
0.0%

core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
1
42.88%

core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java
2
68.46%

core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java
2
51.67%

core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
2
80.23%

Totals

Change from base Build 4420:
0.2%

Covered Lines:
23002

Relevant Lines:
82048

💛  - Coveralls

Codecov Report

Merging #619 into master will increase coverage by 0.2%.
The diff coverage is 40.61%.

@@             Coverage Diff             @@
##             master     #619     +/-   ##
===========================================
+ Coverage     25.34%   25.55%   +0.2%
- Complexity     5840     5920     +80
===========================================
  Files          1379     1379
  Lines         81802    82048    +246
  Branches      11464    11496     +32
===========================================
+ Hits          20731    20965    +234
- Misses        59049    59050      +1
- Partials       2022     2033     +11

Impacted Files
Coverage Δ
Complexity Δ

...ylin/common/persistence/PushdownResourceStore.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...he/kylin/common/persistence/JDBCResourceStore.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...he/kylin/common/persistence/HDFSResourceStore.java
18.65% <0%> (-2.53%)
5 <0> (ø)

...apache/kylin/storage/hbase/HBaseResourceStore.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ache/kylin/common/persistence/JDBCResourceSQL.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...c/main/java/org/apache/kylin/cube/CubeManager.java
38.02% <0%> (+0.25%)
44 <0> (ø)
:arrow_down:

...che/kylin/engine/mr/steps/CreateDictionaryJob.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../apache/kylin/cube/cli/DictionaryGeneratorCLI.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../java/org/apache/kylin/dict/DictionaryManager.java
44.49% <57.69%> (+3%)
27 <5> (+2)
:arrow_up:

...he/kylin/common/persistence/FileResourceStore.java
62.24% <60%> (+2.72%)
28 <3> (+4)
:arrow_up:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf2de69...e07ce37. Read the comment docs.


Add openstack/manila as an external storage provisioner

This PR is still in WIP status, pushed here to hope to get feedbacks
update gophercloud to new version which has enabled sharedfilesystems
set needed parameters: share-networkid, share-protocol or anything else into cloud config file of cluster

I think it's better to split this change into two:

upgrade gophercloud to new version which has enabled sharedfilesystems and to resolve compatible problems.
add openstack/manila as an external storage provisioner.

@aglitke @strigazi , what's your opinions? thanks.

seems the openstack community has converged on maintaining one here https://github.com/kubernetes/cloud-provider-openstack , let's point to that.


Getting FileNotFound error when running the project locally

I'm getting this error when running the project locally even after following the specified installation steps:
FileNotFoundError: [Errno 2] No such file or directory: 'config1.ini'
Please help

You need to change your configuration in config.ini,  Real_File = config1.ini

I'm still getting the same error, even after making the specified changes. I think it is because of the fact that there's no file which exists in the repo
Please help!

Please look into this issue as soon as possible.
Thank you!


Okta Authentication

Implements a new SecurtiyConfig that also creates a tokenStore and connects our Controllers with Okta. A dummy enpoint is also up for checking the JWTAuthenticationToken. The resource issuer was also added to application properties & okta's dep was added to our pom file.
Before making the Pull Request:

[x] Is there a description to this pull request that points to a specific user story, feature, or bugfix?
[x] Are there comments where the code may be unclear?
[x] Is all dead code, commented out code, etc. removed?
[ ] Are there tests written for these changes?
[ ] Does the ReadMe need to be updated?

Before being merged by the TPL:

[ ] Has the pull request been reviewed by at least two team members?
[ ] Did they leave any comments or suggestions?
[ ] Were those suggestions acted on?
[ ] Are all tests passing?
[ ] Has the documentation been updated?

In future commits application properties should comment out h2 and use postgresql


paimon-trino support of prestosql-332

#6

Merged in https://github.com/apache/incubator-paimon-presto/commit/d310320d57693a30fe9373aa50bbc7c501e6a6c6


Incorrect word_tokenize for Dutch

I have observed the following incorrect word_tokenize for Dutch. The characters ' and ’ are very often used unbalanced to represent an apostrophe that is part of correct word. It will chopped up words when tokenizing on it. The in the code below tmp is the correct tokenization.
from nltk import word_tokenize
from pprint import pprint

sentence = "Test alinea's alinea’s ‘smaak’ 's-Hertogenbosch ’s-Hertogenbosch test."
print("sentence:", sentence)
pprint(word_tokenize(sentence, language="dutch"))
tmp = ""
opened = False
for char in sentence:
	if char == "'":
		tmp += "α"
	elif char == "‘":
		opened = True
		tmp += char
	elif char == "’":
		if opened:
			opened = False
			tmp += char
		else:
			tmp += "β"
	else:
		tmp += char
print()
print("tmp:", tmp)
result = []
for word in word_tokenize(tmp, language="dutch"):
	result.append(word.replace("α", "'").replace("β", "’"))
pprint(result)

with output:
sentence: Test alinea's alinea’s ‘smaak’ 's-Hertogenbosch ’s-Hertogenbosch test.
['Test',
 'alinea',
 "'s",
 'alinea',
 '’',
 's',
 '‘',
 'smaak',
 '’',
 "'s-Hertogenbosch",
 '’',
 's-Hertogenbosch',
 'test',
 '.']

tmp: Test alineaαs alineaβs ‘smaak’ αs-Hertogenbosch βs-Hertogenbosch test.
['Test',
 "alinea's",
 'alinea’s',
 '‘',
 'smaak',
 '’',
 "'s-Hertogenbosch",
 '’s-Hertogenbosch',
 'test',
 '.']

I think the word_tokenize was originally meant for English. It's possible to extend it like how we did it for the french chervon https://github.com/nltk/nltk/issues/1434.
But we'll need some more explanation as to how apostrophe works for Dutch. Pardon the Dutch noobness =)
Is it safe to assume that if the not-normal apostrophe ’ appears at the start of the word i.e. $’W+, it's doesn't need to be balance?
How about the normal ' apostrophe, is it always balanced, i.e. it always comes in pairs?

I will add full specs on Dutch here soon, also for https://github.com/nltk/nltk/issues/1969 It is not that trivial as it looks in the first place, but it can be parsed.

Proper balanced use for a word, phase, sentence or multiple sentences:

double neutral quotes: opening " U+0022 and closing " U+0022
single neutral quotes: opening ' U+0027 or U+0060* and closing ' U+0027
double quotes: opening “ U+201C or „ U+201E or ‟ U+201F and closing ” U+201D
single quotes: opening ‘ U+ 2018 or ‚ U+201A or ‛ U+201B and closing ’ U+2019
double angle quotes: opening « U+00AB* and closing » U+00BB*
single angle quotes: opening ‹ U+2039* and closing › U+203A*

Here * indicates rare usage, but nevertheless found in present day corpora. All of the above can be nested in any way. So "one 'two' three" is as valid as 'one "two" three'. Trying to handle fix improper usage for missing opening or closing quotation marks would be a step too far for now. Unless nltk has already something in place for English which applies here too.
Several often-used Dutch words have an apostrophe, which is part of the official spelling. Most often ' U+0027 is used, but also ’ U+2019 is used regularly. Then some operating systems or word processors try to (incorrectly) help the user and replace intended apostrophe usage with an opening single quotation mark. Mianly when they start a sentence with a word at starts with an apostrophe. So also ‘ U+2018, ‛ U+2018 and U+0060 can be found intended as an apostrophe. Some of these operating systems or word processors are so adamant that it is hard for the user to correct this to the proper apostrophe. So apostrophe support needs to be broad for all the characters listed in this paragraph in order to help proper quotation parsing.
Apostrophes (any of those characters) can be found at the beginning of a word, inside a word or at the end of a word. Then, still, the word can be written with spelling errors. So the rules below take spelling errors, case errors and typos into account.

Examples for an apostrophe at the beginning of a word are 's morgens (=in the morning), 't (=short for it) and 's-Hertogenbosch (=name of a large city). Luckily, these can be detected easily:

the complete word consists of an apostrophe, the single letter (usually lower letter s), a hyphen - U+002D or a non-breaking hyphen ‑ U+2011 and two or more letters (usually one uppercase letter followed by one or more lower case letters).
the complete word starts with an apostrophe and has only one lower case letter [a-z], some examples are 's,'t or 'm.
(Case 2. is often followed by a space and a word of minimally two characters, examples are 's morgens or 's anderendaags. But case 2. can also occur in its own right.)

Then there are other words with an apostrophe inside the word. Examples are A4'tjes (several A4 papers), zo'n (=such one), m'n (=my), Jeanne d'Arc, and maître d'hôtel. So that is one or more letters, an apostrophe and again one or more letters.
Words with an apostrophe at the end are mainly names such as Beatrix', Stevens', Matiz' or Félix'. These can be detected by minimally two letters followed by an apostrophe. (Often the first letter is in uppercase.)

Note that other letters in Dutch are not [a-zA-z] but much broader. If nltk has already a good implementation for this, please use that. Otherwise, it encompasses approximately [a-zA-Z0-9áàäâåéèëêíìïîóòöôøúùüûñçÁÀÄÂÅÉÈËÊÍÌÏÎÓÒÖÔØÚÙÜÛÑÇ+/] (with hyphen, non-breaking hyphen and apostrophes omitted from this regex). Perhaps this regex needs to be broader to support academic writing on other languages or math, support typos and input encoding errors. Hopefully, you don't need the exact regex to solve this issue. It is mainly here to illustrate that [a-zA-z] is way too narrow.
All examples above have been checked to officially approved word list of over 500.000 Dutch words.
Unlike in French, for Dutch no space is expected directly on the inside of a quotation mark or before punctuation, such as ., ,, ?, !, ; or :, unless someone made an typing error. The nltk tokenizer already handles this properly.
Out of scope is improper usage of grave accent, acute accent, prime, double prime and other quotation looking symbols. If nltk already handles these too, leave that as is.

@PanderMusubi Thanks for the informative gamut of information!
As for

Then there are other words with an apostrophe inside the word. Examples are A4'tjes (several A4 papers), zo'n (=such one), m'n (=my), Jeanne d'Arc, and maître d'hôtel. So that is one or more letters, an apostrophe and again one or more letters.

That's covered, word_tokenize() will not make a mistake with these:
>>> apostrohe_inside_words = ["maître d'hôtel", "Jeanne d'Arc", "m'n", "zo'n", "A4'tjes"]
>>> [word_tokenize(w) for w in apostrohe_inside_words]
[['ma\xc3\xaetre', "d'h\xc3\xb4tel"], ['Jeanne', "d'Arc"], ["m'n"], ["zo'n"], ["A4'tjes"]]
>>> apostrohe_inside_words = ["maître d'hôtel", "Jeanne d'Arc", "m'n", "zo'n", "A4'tjes"]
>>> [word_tokenize(w) for w in apostrohe_inside_words]
[['ma\xc3\xaetre', "d'h\xc3\xb4tel"], ['Jeanne', "d'Arc"], ["m'n"], ["zo'n"], ["A4'tjes"]]
>>> sent = "The maître d'hôtel named Jeanne d'Arc took m'n zo'n with an A4'tjes paper"
>>> word_tokenize(sent)
['The', 'ma\xc3\xaetre', "d'h\xc3\xb4tel", 'named', 'Jeanne', "d'Arc", 'took', "m'n", "zo'n", 'with', 'an', "A4'tjes", 'paper']

For the following I think it's safe to put a space after the name. BTW, why is there an apostrophe after the name in these cases?

Words with an apostrophe at the end are mainly names such as Beatrix', Stevens', Matiz' or Félix'. These can be detected by minimally two letters followed by an apostrophe. (Often the first letter is in uppercase.)

To the last point, these are the problematic ones:

Examples for an apostrophe at the beginning of a word are 's morgens (=in the morning), 't (=short for it) and 's-Hertogenbosch (=name of a large city).

My suggestion is to not try to extend the word_tokenize to handle these and try to use more complicated tokenizers, e.g the MosesTokenizer which can be extended to support non-breaking prefixes.

As for #1969, the double quotes must be padded with space regardless so the latest merge code #1974 patched that.

One solution I could think of is to first block out a list of phrases, then tokenize and replace it back, e.g.
from nltk.tokenize import _treebank_word_tokenizer
from nltk import sent_tokenize
language = 'dutch'

text = "Something, 's morgen, ik 's-Hertogenbosch gehen"
phrases = ["'s morgen", "'s-Hertogenbosch"]
preserve_line = False

original_text = copy(text)

if phrases:
    backplacement = {}
    for i, phrase in enumerate(phrases):
        backplacement["MWEPHRASE{}".format(i)] = phrase.replace(' ', '_')
        text = re.sub(r"{}".format(phrase), "MWEPHRASE{}".format(i), text)

sentences = [text] if preserve_line else sent_tokenize(text, language)
tokens = [token for sent in sentences for token in _treebank_word_tokenizer.tokenize(sent)]

if not phrases:
    tokens = tokens
else:
    tokens = [backplacement[tok] if tok in backplacement else tok for tok in tokens]

I think this is a useful feature that we can easily extend to the current word_tokenize() but I would prefer if more people expressed interest before creating a PR.

@rmalouf, the proposed extension for word_tokenize above sort of overlap with MWETokenizer, is it a feature worth adding?
This is a little complicated since it involves punctuations in the MWE and I couldn't find an elegant solution to re-stitch the phrases back using MWETokenizer, so I thought replacing them before tokenization and putting them back is easier.

To tackle the issues one by one, I have found one that might be easy. The one regarding a word containing a single quote followed by only a single letter might have a hard-coded condition which letters are allowed there without breaking the word.
words = "alinea's auto's m'n zo'n sms't ge-sms't ftp't ge-ftp'd"
print(word_tokenize(words, language="dutch"))
['alinea', "'s", 'auto', "'s", "m'n", "zo'n", "sms't", "ge-sms't", "ftp't", 'ge-ftp', "'d"]
# should be ["alinea's", "auto's", "m'n", "zo'n", "sms't", "ge-sms't", "ftp't", "ge-ftp'd"]

As you see, 'n and 't are processed correctly, but 's and 'd not. A more generic example is:
words = "aaa'd aaa'n aaa's aaa't"
print(word_tokenize(words, language="dutch"))
['aaa', "'d", "aaa'n", 'aaa', "'s", "aaa't"]
# should be ["aaa'd", "aaa'n", "aaa's", "aaa't"]

words = "a'd a'n a's a't"
print(word_tokenize(words, language="dutch"))
['a', "'d", "a'n", 'a', "'s", "a't"]
# should be ["a'd", "a'n", "a's", "a't"]

Can you pinpoint this to source code for this? For Dutch, even though some are rare, these should never be a word break when a word of one or more characters is followed by a single quote and a single letter.


SimpleXMLObject to SimpleXMLElement in phpdoc.

It is the correct name and a good help for the editor.
http://php.net/manual/es/class.simplexmlelement.php

Thanks for the contribution! The changes look good. I will look at it closer soon and probably merge it later today or tomorrow.


How to change modal size?

First, thanks for this awesome project.
The default size of modal is too large for my component. How to change the size?

They don't have any option to change the width from the component.
But, you can change the modal width from CSS
.xl\:rsm-w-1\/2 {
    width: 420px;
}

Big thanks.


"validate" prop leaking to Field component

Not sure if this is expected behaviour.
But when you set the "validate" prop of a Field, the component also gets the "validate" prop passed to it. Usually api props shouldn't get passed down to inner components.
It's pretty trivial to work around though.

Thanks. Good reporting. Will fix.


extension dialling

Hello,
I am trying to dial an extension using search and dial tab. I hit
enter and the extension dispersers. When I dial the extension from the history tab it works.
Any ideas why?
Thanks,
Luiza

Currently, the regular expression check on the "destination" entry in the dial tab is not allowing extensions, and validating for entire phone numbers. You can see this in dotabs.js on line 136.
The regular expression is shown below:
((([2-9][0-8][0-9])|([(][2-9][0-8][0-9][)]))(.|-| )?([2-9][0-9]{2})(.|-| )?([0-9]{4}))
This needs to be changed to allow extensions.


Cant install Thorium-Win on ZorinOS/Linux using WINE

See screenshot:

This might help solve problem:
https://forum.winehq.org/viewtopic.php?t=34839

@Intellectual234
It is not recommended to run thorium in wine, if you really want to run thorium in wine, you need to pay attention to whether thorium is compatible with wine

@Ho, yeah i know, but I'm trying to get IDM(Internet download manager) to work with my ZorinOS. Have u used IDM before?

@Intellectual234
Please note that if you want to @ me inside github, please @gz83.
I have only used IDM on windows, I have not used IDM in linux or wine

@ho, i know it wasnt going to tag you. :)  what is your main OS that you use?

@Intellectual234
I mainly use windows, but I also use debian and ubuntu.
It should be noted that I use debian and ubuntu to cross-compile Thorium/Chromium for windows.

I like windows design a lot, its much better & smoother than ubuntu/zorin. But windows has tons of spyware, bloatware & tracking telemetry. & there is no way to block it or remove it, as it gets re-installed after every update. & also if you block it via firewall, it causes malfunctions where RAM & CPU become high, get used up, a spiral. I know of no solution.
Perhaps you would like to help figure out how to use IDM in ubuntu/Zorin.

@SoulInfernoDE , thanks for the advice. unfortunately. Jdownloader has disadvantages. it doesnt actually integrate into the web browser, therefore it makes you tell it ur social media login info & cookies. Whereas IDM & XDM bypasses all of that. So Jdownloader is not what im looking for.

@Intellectual234 Running Chromium (or based browsers) on WINE has been hit and miss. Depending on WINE version, whether you have Wines optional C++ Mono framework and web engine installed, and Chromium version, it may or may not work. Also, often you have to pass the --disable-gpu cmdline flag to disable hardware acceleration in chromium to get it to work.