refactor: make AbstractConfigurationService easier to use by sub-classes

I'm again missing the explanation for the motivation behind the change.

@adam-sandor it's all in the title 😄 AsbtractConfigurationService is an abstract class meant to be extended but as it is, it's not very usable by subclasses because it really doesn't provide ways to interact with its internal structure.

@adam-sandor I'm going to go ahead and merge these changes as I need them for the quarkus extension.

sure, go for it :) but do know that I hate abstract classes 😂

Well, the class is not new, I just made it easier to use downstream… and yes, abstract classes certainly have their flaws. 😄


e.preventDefault() inside passive event listener in mobile devices

With "react-color": "^2.17.0"
In Chrome 71.0.3578.98, with devtools responsive mode, the following warning is emitted.

It look like React implicitly addEventListeners touchmove event as { passive: true }.
Since you should not fire e.preventDefault() in touchmove handler, which Saturation component is violating it.
https://github.com/casesandberg/react-color/blob/8bde391b44d9336bccae91757b748b32d91bb1cd/src/components/common/Saturation.js#L20-L26
Fundamentally it is caused by saturation.calculateChange(), so it seems this could be solved by

making .calculateChange not requiring Event object
not using Saturation.this._handleChange for onTouchmove, replacing to another event handler

Hmm, this is an interesting case. I am going to look back through to see why preventDefault was added in the first place. We might be able to just remove it.

Looks like this is a known issue with Chrome and React:
https://github.com/facebook/react/issues/8968

I am going to go ahead and close this as it has to do with a specific version of React and not this package itself.


unresolved imports opencv::cudafilters, opencv::cudaimgproc no cudafilters in the root

Hi I am trying to run code in example/cuda, but it failed to find those 2 modules, and it's strange that on docs it's in default feature.

Looks like your OpenCV installation doesn't have CUDA support that's why those modules are missing. To include CUDA support you most likely need to build OpenCV manually. Pre-built binary packages rarely contain it.

Looks like your OpenCV installation doesn't have CUDA support that's why those modules are missing. To include CUDA support you most likely need to build OpenCV manually. Pre-built binary packages rarely contain it.

Thanks!


Revert "[SPARK-21642][CORE] Use FQDN for DRIVER_HOST_ADDRESS instead …

…of ip address"
This reverts commit d695a528bef6291e0e1657f4f3583a8371abd7c8.

Can we add a config flag and submit upstream?

@robert3005 yeah I think that's the right path forward here.  Still there's the question of how do we handle TLS (while in kubernetes) -- the reason for the change upstream

Planning to:

revert this change to unblock testing, and release
propose flag to upstream for flipping between IP and hostnames


Enable more loggings for github actions

Description
Enable more Logging in Github Action.
Consolidate the naming of tests profiles for travis and github actions

Codecov Report

Merging #5555 into master will increase coverage by 0.10%.
The diff coverage is 71.64%.

@@            Coverage Diff             @@
##           master    #5555      +/-   ##
==========================================
+ Coverage   66.44%   66.55%   +0.10%
==========================================
  Files        1075     1105      +30
  Lines       54773    56954    +2181
  Branches     8168     8514     +346
==========================================
+ Hits        36396    37905    +1509
- Misses      15700    16247     +547
- Partials     2677     2802     +125

Flag
Coverage Δ

#integrationtests
45.26% <52.06%> (?)

#unittests
56.98% <65.19%> (?)

Impacted Files
Coverage Δ

...quota/HelixExternalViewBasedQueryQuotaManager.java
67.87% <0.00%> (ø)

...org/apache/pinot/common/function/FunctionInfo.java
73.33% <ø> (ø)

...java/org/apache/pinot/common/segment/ReadMode.java
66.66% <ø> (ø)

...org/apache/pinot/common/utils/CommonConstants.java
39.02% <0.00%> (+0.92%)
:arrow_up:

...troller/helix/core/retention/RetentionManager.java
80.28% <0.00%> (+1.11%)
:arrow_up:

...he/pinot/controller/util/AutoAddInvertedIndex.java
0.00% <0.00%> (ø)

.../org/apache/pinot/core/common/BaseBlockValSet.java
3.03% <0.00%> (-1.32%)
:arrow_down:

.../java/org/apache/pinot/core/common/DataSource.java
100.00% <ø> (ø)

...data/manager/realtime/DefaultSegmentCommitter.java
80.00% <ø> (ø)

...e/data/manager/realtime/SplitSegmentCommitter.java
63.63% <ø> (ø)

... and 432 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd774c7...86640ad. Read the comment docs.

LGTM. What's the log size limit for github actions?

i don't find that explicitly. So we will find once we exceed that.


Atom Linter support for build errors/warnings

I added support for pushing errors/warnings to Atom's Linter package, currently only for the Rust extension. I created a linthelper.js class under tools, which can handle parsing the regex and building an array of Linter-complaint objects, and pushing them to that package.
I added a linter property to your extension settings (currently only in the Cargo.js one), which is then queries in the build.js whenever a build is requested, and if it exists it updates the lint.
I'm not sure if it covers all bases, but anyway, let me know if you think this is something that could be merged!

There were some linting errors in your code. Please fix these.

Ah! Ok, I'll look into those today if I get time. I don't work with Javascript too often, so I'm not sure of what workflows exist for code quality checking - sorry about that.

I wonder whether this could lead to duplicate lint-messages when combined with other linter-tools.
But I like the general idea - it should probably be optional if duplicate lints could be an issue.

Severely outdated. Please open a new PR if you intend to continue on this.


Dynamically loading GWT assets

The Problem
Currently the way things are set up in the gwt-backend, all files are loaded upon starting the application. Once this is complete, no more files can be loaded due to the way GwtFileHandle is implemented.
The files available to load through the FileHandle constructor are tied to com.badlogic.gdx.backends.gwt.preloader.Preloader class which currently has no api for loading extra files once it has completed the initial load.
Potential Solutions

Expose a loadAsset method on the Preloader class which takes a link String and a callback function as arguments
Add an overload to the preload method with an extra argument String[] extraAssetLinks

Personally, I would prefer the former, although it would require some refactoring to keep the Preloader  class DRY, the place where each asset is loaded individually could be extracted into its own function for example.
I am willing make this change myself, but I was wondering if it was more sensible to simply create a subclass of Preloader in my own project instead.

There is a way to make different bundles for the preloader to defer loading of assets until a time that is more appropriate. Most of should still apply.
There is currently an error on my blog but the way back machine looks to have a copy:
http://web.archive.org/web/20171021204851/http://nexsoftware.net:80/wp/2013/07/07/libgdx-deferred-asset-loading-with-gwt/

The issue has been adressed on different other issues and PRs.

If you need the feature to not load everything at startup, but have a closed set of assets to load dynamically, PR #5677 is for you - please review and vote to get it merged
If you need real dynamics to fetch images not known at compile time, issue #6023 is for you

Closing this as a dublicate.


Update Settings “general”

Automatically generated by Netlify CMS

👷 Deploy Preview for ekhdmny processing.

Name
Link

🔨 Latest commit
366a4fbc7be66cef22293243c1748a965da96a6e

🔍 Latest deploy log
https://app.netlify.com/sites/ekhdmny/deploys/63833f31ccf1f50008459320


Added deconstructors to the primitives

Prerequisites

[X] I have written a descriptive pull-request title
[X] I have verified that there are no overlapping pull-requests open
[X] I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules :cop:.
[X] I have provided test coverage for my change (where applicable)

Description
I added deconstructors to the primitives. I was trying to use ImageSharp for a project, and when using the mutate function I already had a variable named size.
So then I wanted to use a deconstructor and I tried:
var (width, height) = ctx.GetCurrentSize();

This proofed not possible since there were no deconstructors, so I thought I write a few.
With this PR the above code will work, and makes imagesharp a bit more usable :)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Gerard Gunnewijk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Will review this tonight.


trusted_config_paths no longer expands ~ into users home directory

Describe the bug
The paths in the trusted_config_paths setting used to be expanded with the users home directory (ie. from ~/work/my-trusted-projects into /home/jdx/work/my-trusted-projects). This is no longer happening on the latest version.
To Reproduce

created ~/.config/mise/settings.toml with:

trusted_config_paths = [
    '~/work/my-trusted-projects',
]

cd into a relevant project

$ cd ~/work/my-trusted-projects
Error:   × error parsing config file: ~/work/my-trusted-projects/.mise.toml
  ╰─▶ Config file is not trusted.
      Trust it with `mise trust`.

Error:   × error parsing config file: ~/work/my-trusted-projects/.mise.toml
  ╰─▶ Config file is not trusted.
      Trust it with `mise trust`.

Expected behavior
Paths should be expanded with the users home directory.
Additional context
$ mise -v
2024.1.12 macos-arm64 (2024-01-07)

huh this is strange, I think it actually broke before the settings change. In any case, it works with my patch now.


has no attribute class_type when running NUMBA_DISABLE_JIT

integrator_spec = [
    ("model", NumbaModel.class_type.instance_type),
    ("plasma", NumbaPlasma.class_type.instance_type),
    ("points", int64),
]

This does not work in DISABLE_JIT_MODE that we use for debugging. numba==0.53.0

@wkerzendorf thank you for reporting this. Would it be possible to attach a reproducer?

MWR:
from numba import int32
from numba.experimental import jitclass

foo_spec = [('value', int32),]

@jitclass(foo_spec)
class Foo(object):
    def __init__(self, value):
        self.value = value

bar_spec = [("foo_ref", Foo.class_type.instance_type),]

@jitclass(bar_spec)
class Bar(object):
    def __init__(self, foo_inst):
        self.foo_ref = foo_inst

foo_instance = Foo(1)
bar_instance = Bar(foo_instance)

run with NUMBA_DISABLE_JIT=1.

@stuartarchibald thanks 😄


Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Installation issue.
Brief description of your issue
Previously was using the following command to install Microsoft Office
winget install -e --id Microsoft.Office --accept-package-agreements --accept-source-agreements --silent
It is now erroring out with a "Couldn't install" error. "We couldn't find the specified configuration file. Check the file path and file name.
Steps to reproduce
winget install -e --id Microsoft.Office --accept-package-agreements --accept-source-agreements --silent
Actual behavior
Error's out.
Expected behavior
Microsoft.Office would be installed.
Environment
Windows: Windows.Desktop v10.0.22621.1105
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.10173.0

Screenshots and Logs
No response

I guess someone at Microsoft needs to renew a certificate:
$ curl -L -v https://aka.ms/fhlwingetconfig
*   Trying <IP_ADDRESS>:443...
* Connected to aka.ms (<IP_ADDRESS>) port 443 (#0)
* ALPN: offers h2
* ALPN: offers http/1.1
*  CAfile: /etc/ssl/certs/ca-certificates.crt
*  CApath: /etc/ssl/certs
* [CONN-0-0][CF-SSL] TLSv1.0 (OUT), TLS header, Certificate Status (22):
* [CONN-0-0][CF-SSL] TLSv1.3 (OUT), TLS handshake, Client hello (1):
* [CONN-0-0][CF-SSL] TLSv1.2 (IN), TLS header, Certificate Status (22):
* [CONN-0-0][CF-SSL] TLSv1.3 (IN), TLS handshake, Server hello (2):
* [CONN-0-0][CF-SSL] TLSv1.2 (IN), TLS header, Finished (20):
* [CONN-0-0][CF-SSL] TLSv1.2 (IN), TLS header, Supplemental data (23):
* [CONN-0-0][CF-SSL] TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* [CONN-0-0][CF-SSL] TLSv1.2 (IN), TLS header, Supplemental data (23):
* [CONN-0-0][CF-SSL] TLSv1.3 (IN), TLS handshake, Certificate (11):
* [CONN-0-0][CF-SSL] TLSv1.2 (IN), TLS header, Supplemental data (23):
* [CONN-0-0][CF-SSL] TLSv1.3 (IN), TLS handshake, CERT verify (15):
* [CONN-0-0][CF-SSL] TLSv1.2 (IN), TLS header, Supplemental data (23):
* [CONN-0-0][CF-SSL] TLSv1.3 (IN), TLS handshake, Finished (20):
* [CONN-0-0][CF-SSL] TLSv1.2 (OUT), TLS header, Finished (20):
* [CONN-0-0][CF-SSL] TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
* [CONN-0-0][CF-SSL] TLSv1.2 (OUT), TLS header, Supplemental data (23):
* [CONN-0-0][CF-SSL] TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
* ALPN: server accepted http/1.1
* Server certificate:
*  subject: C=US; ST=WA; L=Redmond; O=Microsoft Corporation; CN=go.microsoft.com
*  start date: Oct 13 21:29:19 2022 GMT
*  expire date: Oct  8 21:29:19 2023 GMT
*  subjectAltName: host "aka.ms" matched cert's "aka.ms"
*  issuer: C=US; O=Microsoft Corporation; CN=Microsoft Azure TLS Issuing CA 06
*  SSL certificate verify ok.
* [CONN-0-0][CF-SSL] TLSv1.2 (OUT), TLS header, Supplemental data (23):
> GET /fhlwingetconfig HTTP/1.1
> Host: aka.ms
> User-Agent: curl/7.87.0
> Accept: */*
>
* [CONN-0-0][CF-SSL] TLSv1.2 (IN), TLS header, Supplemental data (23):
* [CONN-0-0][CF-SSL] TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* [CONN-0-0][CF-SSL] TLSv1.2 (IN), TLS header, Supplemental data (23):
* [CONN-0-0][CF-SSL] TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* old SSL session ID is stale, removing
* [CONN-0-0][CF-SSL] TLSv1.2 (IN), TLS header, Supplemental data (23):
* Mark bundle as not supporting multiuse
< HTTP/1.1 301 Moved Permanently
< Content-Length: 0
< Server: Kestrel
< Location: https://prod.officeconfig.msocdn.com/mirrored/services/flux/cloudconfigs/wingeta.xml
< Request-Context: appId=cid-v1:b47e5e27-bf85-45ba-a97c-0377ce0e5779
< X-Response-Cache-Status: True
< Expires: Mon, 13 Feb 2023 10:01:34 GMT
< Cache-Control: max-age=0, no-cache, no-store
< Pragma: no-cache
< Date: Mon, 13 Feb 2023 10:01:34 GMT
< Connection: keep-alive
< Strict-Transport-Security: max-age=31536000 ; includeSubDomains
<
* Connection #0 to host aka.ms left intact
* Issue another request to this URL: 'https://prod.officeconfig.msocdn.com/mirrored/services/flux/cloudconfigs/wingeta.xml'
*   Trying [2a02:26f0:3500:598::265f]:443...
* Connected to prod.officeconfig.msocdn.com (2a02:26f0:3500:598::265f) port 443 (#1)
* ALPN: offers h2
* ALPN: offers http/1.1
*  CAfile: /etc/ssl/certs/ca-certificates.crt
*  CApath: /etc/ssl/certs
* [CONN-1-0][CF-SSL] TLSv1.0 (OUT), TLS header, Certificate Status (22):
* [CONN-1-0][CF-SSL] TLSv1.3 (OUT), TLS handshake, Client hello (1):
* [CONN-1-0][CF-SSL] TLSv1.2 (IN), TLS header, Certificate Status (22):
* [CONN-1-0][CF-SSL] TLSv1.3 (IN), TLS handshake, Server hello (2):
* [CONN-1-0][CF-SSL] TLSv1.2 (IN), TLS header, Finished (20):
* [CONN-1-0][CF-SSL] TLSv1.2 (IN), TLS header, Supplemental data (23):
* [CONN-1-0][CF-SSL] TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* [CONN-1-0][CF-SSL] TLSv1.2 (IN), TLS header, Supplemental data (23):
* [CONN-1-0][CF-SSL] TLSv1.3 (IN), TLS handshake, Certificate (11):
* [CONN-1-0][CF-SSL] TLSv1.2 (OUT), TLS header, Unknown (21):
* [CONN-1-0][CF-SSL] TLSv1.3 (OUT), TLS alert, certificate expired (557):
* SSL certificate problem: certificate has expired
* Closing connection 1
curl: (60) SSL certificate problem: certificate has expired
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

I reached out to the folks I worked with on the hackathon to make this package possible via WinGet. It should be working now.


Update address validation for bech32

Check bech32 address encoding in addition to base58 when validating bitcoin
addresses.

Per @cpacia we'll need to adjust the QR code settings, he had to change the type to 8 to get it to work, which caused some layout issues.

We should patch that before merging this PR.

Per @cpacia we'll need to adjust the QR code settings, he had to change the type to 8 to get it to work, which caused some layout issues.

@jjeffryes ok, i'll look into that.

closed in liu of #709


Server validation return success as false and errorcodes as NULL

Response
object(ReCaptchaResponse)#2 (2) { ["success"]=> bool(false) ["errorCodes"]=> NULL }

google/recaptcha version: Invisible

Why is it NULL? There is details on the docs for that.

What version of the client library are you using? This should be listed in the README.md or as const VERSION in src/ReCaptcha/ReCaptcha.php.


Suggestion: make bitsandbytes optional

If I'm not mistaken, bitsandbytes is only used for this one line:
https://github.com/johnsmith0031/alpaca_lora_4bit/blob/main/monkeypatch/peft_tuners_lora_monkey_patch.py#L125
Meaning, you can move the import to within that if loaded_in_8bit, and thus make bitsandbytes only required when 8bit models are loaded.
I suggest this because on the text-gen-webui Discord I've been hearing so many users complain about the difficulty of getting bitsandbytes installed on Windows, and that's been renewed by monkey-patch requiring it... but it should be simple to remove the explicit dependency, if I'm not missing anything.

Yes I think I'll remove it from the monkey patch. Thanks for the advice


nuget: fix PR missing commits in message when using private registry

Context
Dependabot PRs are missing the release notes and commits sections that we expect them to have when using a private NuGet registry like nuget.pkg.github.com.
This is because the GitHub NuGet registry doesn't support downloading .nuspec files currently, and this is the way we're finding the source repo of the project.
The .nuspec URL is part of the NuGet Server spec.
A solution
This PR adds a fallback to try to find the projectUrl or licenseUrl in the search data, which might contain the repo. The search URL is supported by GitHub Packages and the official NuGet server.
This will require users to enter a repo URL in the projectUrl, instead of the repositoryUrl field, since repositoryUrl isn't exposed in the search endpoint. The only way to get to that repositoryUrl seems to be in that .nuspec file.
Another possible solution is downloading the .nupkg and extracting the .nuspec, but I think that could have an effect on billing and that is probably undesirable. Also there's a risk the .nupkg is quite large since it contains binaries.
We could also ask GitHub Packages to implement that endpoint, this PR is meant as a stopgap or fallback when the nuspec is not available.
No tests yet: Wanted to get buy-in from the approach here.

@dependabot/reviewers This is ready for review now.


Failure to send messages to discord when token image has spaces in its filename.

This bug is present in Foundry Version 11 (11.315) while running in the DnD5e Game System (3.0.4)
To Reproduce
Select a token with a space in its filename and attempt to send a message.
The chat message appears in Foundry without issue, but it fails to get to Discord. Console log spits out a 404 error.
Expected behavior
The resulting message should mirror from Foundry chat to the linked Discord channel.
Screenshots

Additional context
After testing, I think this issue came up by using Aedif's Token Variant Art during token configuration. Selecting a file through the normal file browser appends a '%20' on spaces in filenames, whereas going through the token variant retains the filename space.

Yeah, this is because back in v9, filepaths on Foundry weren't using an encoded URI scheme, which is probably retained in that module. There are two ways to go about this: opening an issue on Aedif's Token Variant to make the filepaths properly encoded, or I can just fix it myself here.

Should be fixed in c4ca4de476f64bb2422827cc724f64743e7b7d1e of the 2.0 branch. Unfortunately, Foundry's FilePicker doesn't have a native way to encode file paths, so I had to do it manually through crawling. Other special characters should be included too, not just spaces.

Fixed in 2.0.0.


Fix AccountCreationCaptcha error logging

If a http error occured the logging did not actually report
the error message.

Thanks


Angular 1.6 breaking change to ngModelOptions

I apologize in advance, as this is not normally the place for this sort of issue, but I actually am in need of a bit of guidance here as to how to patch a breaking change made to Angular 1.6 in UI Bootstrap while maintaining compatibility with Angular 1.5.
Currently in UI Bootstrap, we are allowing override of ngModelOptions with defaults specified by the user - for example, like https://github.com/angular-ui/bootstrap/blob/master/src/datepicker/datepicker.js#L164-L166 . If someone is wrapping any of our components with a directive using ngModel & ngModelOptions, this will automatically wipe out the old behavior of it being not present, so it will not fallback by default but use the ngModelOptions from the parent directive.
Any suggestions?

Moving the discussion to https://github.com/angular-ui/bootstrap/issues/6360


get_layers()

get_layers() is not able to handle the situation where a layer of the same name exists in another workspace e.g ws1:layer1 and ws2:layer1. The geoserver/rest/layers.xml will contain two identical
 entries for both which means that is not possible to access the second resource href
geoserver/rest/workspaces/ws2/datastores/ds/featuretypes/layer1.xml
A Fix would probably require changes to GeoServer REST code as well as layers.xml would to be modified to include a reference to the workspace maybe:
-layer
--name layer1
--atom:link rel="alternate" href="/geoserver/rest/workspaces/ws1/layers/layer1.xml" type="application/xml"/
-layer
--name layer1
--atom:link rel="alternate" href="/geoserver/rest/workspaces/ws2/layers/layer1.xml" type="application/xml"/>
Kind Regards,
Sirko

Same problem here...


Add 'Change-By' field to Debian control lexer

The content of the 'Change-by' field has the 'Maintainer' field format: https://www.debian.org/doc/debian-policy/ch-controlfields.html#changed-by
so it should use it instead of the default parsing.
I added a test with a fake e-mail address ending with '.test' as top level domain instead of '.tld' previously because someone learn me the existence of the RFC 2606 (Reserved Top Level DNS Names). I can modify the other occurrences in the file but I'm sure it's really useful. What do you think on this point?

Merged, thanks!


Exiting the debugger

Whenever I try to exit the debugger on 2.3.9 and Python 3.5, I see an In [number] prompt, but there is an ipdb> prompt right below it. I cannot see a way to exit the debugger so that the next command I type will be in the In prompt directly. I believe this may be a bug in Spyder.

I think this is fixed in Spyder 3.0 (which will come out in some of hours :-), please test again when that version comes out and let us know what happens :-)

Closing because of lack or response.


add unit test to pagination under routes.

the percent of unit test was very low 20%
this pr increase the covarage of unit test
Signed-off-by: mgold1234<EMAIL_ADDRESS>Description

FIXES:
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Codecov Report
Base: 52.32% // Head: 52.48% // Increases project coverage by +0.15% :tada:

Coverage data is based on head (b43d89d) compared to base (9cb4a57).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1860      +/-   ##
==========================================
+ Coverage   52.32%   52.48%   +0.15%
==========================================
  Files          70       70
  Lines        9857     9857
==========================================
+ Hits         5158     5173      +15
+ Misses       4228     4212      -16
- Partials      471      472       +1

Impacted Files
Coverage Δ

pkg/routes/common/pagination.go
84.00% <0.00%> (+60.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Mac support ?

Hey!
I know this is currently only a windows 10 feature but I was wondering if your software will ever come to macOS! I’m hoping that it does!

Hello,
I personally am miles away from the knowledge required about development in an Apple environment, their driver ecosystem and have never owned any Apple hardware. So the signs are not the best 😅 but I wonder what benefit would it bring, Virtual Xbox Controllers on MacOS I assume?

Oh ok! It’s all good I know not many people dude software type of stuff on Mac thus it being limited to things that windows has that macOS doesn’t!
Either way I really love this software and I can’t ware to see future inventions of yours

It'll permit to a software like dualsensex to work on mac, and to bring support DualSense with Adaptative triggers… also with an universal method for developpers on Steam working on several Os I guess.
If a mac dev want to bring vigem on mac that'll be nice so :D


Entire viewport placed in left bottom quarter of window

There is some bug on MacOS Catalina where if I initiate a window sized 300 x 300, place the sprite at 300 x 300 - then I get what's seen in the attachment - a window that's 600 x 600 and the sprite is in it's center with only a quarter of it visible.
Any idea how to fix it?
I'm on:
cocos2d==0.6.8
pyglet==1.5.0
Sample code:
cocos.director.director.init(width=300, height=300)
And then a layer with:
cocos.sprite.Sprite(pyglet.resource.animation('player.gif', rotate=-90))
sprite.position = 300, 300
self.add(sprite, z=1)

I'm guessing the viewport is set using values from window.get_size() instead of window.get_framebuffer_size().

I just moved to plain pyglet from cocos, and no issues.  Thanks for your reply, closing this since it seems to be a cocos issue.


Open tabs programmaticaly does not work

Calling
activeTab.tab('show') does not work on accordions. Still works on tabs.

@coorasse thank you for submiting! In accordions you should use activeTab.collapse('show') instead of tab('show'). Example:
$('#collapseOne').collapse('show');
$('#collapseOne').collapse('hide');


from aioredis change to redis

aioredis is no longer maintained, so switch to redis
https://github.com/redis/redis-py/releases/tag/v4.2.0rc1
PR

Thanks! I have corrected the mistake you mentioned, please check again to see if there are other problems


Channel and its guide different

i setup EPlusTV but on website cricket matches shows and live. but in VLC media player channel 1 shows colorado vs xxx. in xmltv guide there is no cricket schedule. whats wrong with this ?

How are you viewing the XMLTV data?

Closing stale ticket


Which is the preferred View library?

Hi.
Since there are problems with using the Chaplin:
TypeError: f.utils.delegate is not a function

caused by the Backbone.utils.delegate and Backbone.utils.undelegate functions that are absent which substitute for the Chaplin would you recommend?

We got rid of utils.delegate and utils.undelegate in favor of sticking them on View.prototype like Backbone does. Chaplin hasn't been updated to support the latest view hooks (see my pull in https://github.com/chaplinjs/chaplin/pull/780).


ToTimecode function is not work properly

It seems to be a bug in hh part when I try to use ToTimecode in Perfetto SQL.
https://github.com/google/perfetto/blob/main/src/trace_processor/perfetto_sql/intrinsics/functions/clock_functions.h#L191
int64_t hh = mm % 60;
It should be '/' operator rather than '%' to calculate hh.
Some test examples:
TO_TIMECODE(3600123456789)
return   00:00:00 123 456 789
but expected is 01:00:00 123 456 789
TO_TIMECODE(3599123456789)
return   59:59:59 123 456 789
but expected is 00:59:59 123 456 789

Yes seems like a real bug. @aMayzner can you PTAL?


Remove locking and remove check for double events.

We are observing behavior in some resizing events that content loads, tells the parent to resize the iframe, and locks it. Then, more content loads, but since the trigger is locked, it will not appropriately send the message to resize the frame.
This pull removes the lock and the check for double events, because it is sufficient to only run the resizing when the content has changed size.
Another option is to remember the size as it changes, and send it up to the parent as soon as it unlocks, but this is simpler.
It looks like this has been in the file for some time; if there is another reason for having these extra checks, we haven't run into it in testing it on a variety of iframes and interactions.

Hi,
The reason for the locking, is to reduce the overhead of working out the size of the content. When you use the standard height calculation method this isn't much of a problem. However, with some of the other methods,  it can become an issue and also cause screen flicker.
Have a look at https://github.com/davidjbradshaw/iframe-resizer#heightcalculationmethod to see how the different options work.
That said, I can also see how in your use case it creates a problem, so maybe the solution is to disable the locking only with the simple height calculation methods or make it optional.

I see. Then, I believe I've found a simpler solution—do you see a reason why we couldn't remove the isDoubleEventFired() check? If we keep the locking, but rely solely on isSizeChangeDetected() to update the size, this seems to fix our height issue and allows locking to still be turned on and off.

Yep, the problem is that with some calculation methods you have to first
size the frame down to zero height and then resize it to the content,
because some browsers (Chrome) don't correctly report the size of the
content shrinking.
The easiest way to over come your issue without forking the code, is the
call parentIFrame.size() when you load new content in, as this isn't
blocked by the isDoubleEventFired() check.
On Wed, Feb 18, 2015 at 6:52 PM, Jenn Scheer<EMAIL_ADDRESS>wrote:

I see. Then, I believe I've found a simpler solution—do you see a reason
why we couldn't remove the isDoubleEventFired() check? If we keep the
locking, but rely solely on isSizeChangeDetected() to update the size,
this seems to fix our height issue and allows locking to still be turned on
and off.
—
Reply to this email directly or view it on GitHub
https://github.com/davidjbradshaw/iframe-resizer/pull/152#issuecomment-74923327
.

--
David J. Bradshaw )'<EMAIL_ADDRESS>


solutions#misc-weakpass missing

credentials can be retrieved by looking at the code but the solution section is missing. Probably some change from a previous version :)

good catch! This was fixed.

Closing :)


Jackson serialization exception for range

There is a problem when using the new ranges that was just recently merged with master #64  and the problem was due to no public getters/setters in the Range class.
I'm happy to fix it if allowed. I've fixed it locally by adding getters and setters for the upper and lower limits.

@AbdulR3hman Thanks for the ifx. Looking forward to it. Make sure you add a test case too.

Could be fixed by this commit. If it's not, please reopen the issue.


Don't have permissions to contribute

I updated the markdown file (don't know enough about ruby to try to update the tool), and I found that I do not have permissions to publish my branch or to create a pull request.
Can this be updated? There might be people out there willing to update the tool who've not been able to. Thanks!
-M. Taraan

False alarm. Forgot how to use GitHub.


✏ | Reduce scrollbar opacity to show minimap colours

Description
Reduces the opacity of the scrollbar so that colours on the minimap - such as Git additions and deletions and errors - are visible underneath it for all states (hover, idle, and active).
https://github.com/withastro/houston-vscode/assets/20650404/e9c9341f-454c-4fd6-9490-61e3ef521167
Related issues & labels
This PR does not yet close #5, however it addresses one of the issues mentioned.

Will write a changeset later today.


Replace multi-function call with multi function variables and singular function call

Description
Imagine a typo anywhere...yeah, not fun. This avoids that possibility by insuring that each function is called with the exact same parameters

pushed to HEAD


Solve Issue #63: Add Support for Token Authentication and User/Pass Authentication in BMC Firmware Update

Issue Addressed: Resolves #63
Changes Made:

Added support for token-based authentication alongside existing user/password authentication in the BMC firmware update process.
Introduced two distinct blocks in roles/bmc_fw_update/tasks/main.yml:
User/Password Authentication Block: For handling authentication using username and password.
Token Authentication Block: For handling authentication using tokens.

Details:
Updated the community.general.redfish_info task to support both authentication methods.
Ensured compatibility with existing configurations and backward compatibility.
@glimchb  Please review these changes. Your feedback is appreciated!

@abhashsolanki18 thanks for fixing this
Please see commitlint failure.
Otherwise looks good.
If you rebase, those ansible ci failures should be resolved

@glimchb i have rebased the commits now it should pass the ci.

@abhashsolanki18

looks like linter fails on your changes, please fix
i saw one place at the end when you don;t give neither user/pass nor auth token... looks like a bug...

@glimchb
the linters should also exclude ansible 2.17 with python 3.9, fixed that in the latest commit
also fixed the bug you highlighted earlier.

Invalid workflow file: .github/workflows/docker-publish.yml#L13
The workflow is not valid. .github/workflows/docker-publish.yml (Line: 13, Col: 3): Error calling workflow 'opiproject/actions/.github/workflows/docker-publish.yml@main'. The nested job 'build' is requesting 'id-token: write', but is only allowed 'id-token: none'.
@glimchb what is the error about? failing while executing docker workflow as well as openSSF workflow

@glimchb what is the error about? failing while executing docker workflow as well as openSSF workflow

will check it

@abhashsolanki18 I tested your changes and they fail, please fix
I used for user/pass flow:
ansible-playbook ./playbooks/firmware.yml -vvv -i "<IP_ADDRESS>," -e dpu_bmc_username='root' -e dpu_bmc_password='123456' -e bmc_fw_update_inventory_name='6d53cf4d_bmc_firmware' -e bmc_fw_update_image_file='/tmp/bf2-bmc-ota-24.04-5-opn.tar'

I hit errors, so I had to make those changes:
diff --git a/roles/bmc_fw_update/defaults/main.yml b/roles/bmc_fw_update/defaults/main.yml
index ba5ffaf..ba8a611 100644
--- a/roles/bmc_fw_update/defaults/main.yml
+++ b/roles/bmc_fw_update/defaults/main.yml
@@ -8,5 +8,5 @@ bmc_fw_update_reboot: true
 bmc_fw_update_job_wait: true
 bmc_fw_update_inventory_name: bmc_firmware
 bmc_fw_update_image_file: /tmp/bf3-bmc-24.04-5_opn.fwpkg
-bmc_fw_update_image_url: https://content.mellanox.com/BlueField/BMC/24.04-5-Apr-2024/{{ bmc_fw_update_image_file | basename }}
+bmc_fw_update_image_url: https://www.mellanox.com/downloads/BlueField/BMC/24.04-5-Apr-2024/{{ bmc_fw_update_image_file | basename }}
 https_port: 443
diff --git a/roles/bmc_fw_update/tasks/main.yml b/roles/bmc_fw_update/tasks/main.yml
index e37647c..93b8d05 100644
--- a/roles/bmc_fw_update/tasks/main.yml
+++ b/roles/bmc_fw_update/tasks/main.yml
@@ -23,11 +23,11 @@

 - name: Store current fw version
   ansible.builtin.set_fact:
-    bmc_fw_update_cur_fw_version: "{{ get_bmc_facts_before.get_bmc_facts_all_fw_versions[bmc_fw_update_inventory_name] }}"
+    bmc_fw_update_cur_fw_version: "{{ vars.get_bmc_facts_all_fw_versions[bmc_fw_update_inventory_name] }}"

 - name: Print BMC Version
   ansible.builtin.debug:
-    msg: "{{ get_bmc_facts_before.get_bmc_facts_all_fw_versions }}"
+    msg: "{{ get_bmc_facts_all_fw_versions }}"

 - name: Check if firmware image exists locally {{ bmc_fw_update_image_file }}
   ansible.builtin.stat:

once fixed, I can test the same with token:
ansible-playbook ./playbooks/firmware.yml -vvv -i "<IP_ADDRESS>," -e dpu_bmc_token='123456' -e bmc_fw_update_inventory_name='6d53cf4d_bmc_firmware' -e bmc_fw_update_image_file='/tmp/bf2-bmc-ota-24.04-5-opn.tar'

@abhashsolanki18 I tested your changes and they fail, please fix
I used for user/pass flow:
docker run --rm -it --entrypoint ansible-playbook -v $(pwd):/opt -w /opt/roles ghcr.io/opiproject/ansible-opi-dpu:main ../playbooks/firmware.yml -vvv -i "<IP_ADDRESS>," -e dpu_bmc_username='root' -e dpu_bmc_password='123456' -e bmc_fw_update_inventory_name='6d53cf4d_bmc_firmware' -e bmc_fw_update_image_file='/tmp/bf2-bmc-ota-24.04-5-opn.tar'

I hit errors, so I had to make those changes:
diff --git a/roles/bmc_fw_update/defaults/main.yml b/roles/bmc_fw_update/defaults/main.yml
index ba5ffaf..ba8a611 100644
--- a/roles/bmc_fw_update/defaults/main.yml
+++ b/roles/bmc_fw_update/defaults/main.yml
@@ -8,5 +8,5 @@ bmc_fw_update_reboot: true
 bmc_fw_update_job_wait: true
 bmc_fw_update_inventory_name: bmc_firmware
 bmc_fw_update_image_file: /tmp/bf3-bmc-24.04-5_opn.fwpkg
-bmc_fw_update_image_url: https://content.mellanox.com/BlueField/BMC/24.04-5-Apr-2024/{{ bmc_fw_update_image_file | basename }}
+bmc_fw_update_image_url: https://www.mellanox.com/downloads/BlueField/BMC/24.04-5-Apr-2024/{{ bmc_fw_update_image_file | basename }}
 https_port: 443
diff --git a/roles/bmc_fw_update/tasks/main.yml b/roles/bmc_fw_update/tasks/main.yml
index e37647c..93b8d05 100644
--- a/roles/bmc_fw_update/tasks/main.yml
+++ b/roles/bmc_fw_update/tasks/main.yml
@@ -23,11 +23,11 @@

 - name: Store current fw version
   ansible.builtin.set_fact:
-    bmc_fw_update_cur_fw_version: "{{ get_bmc_facts_before.get_bmc_facts_all_fw_versions[bmc_fw_update_inventory_name] }}"
+    bmc_fw_update_cur_fw_version: "{{ vars.get_bmc_facts_all_fw_versions[bmc_fw_update_inventory_name] }}"

 - name: Print BMC Version
   ansible.builtin.debug:
-    msg: "{{ get_bmc_facts_before.get_bmc_facts_all_fw_versions }}"
+    msg: "{{ get_bmc_facts_all_fw_versions }}"

 - name: Check if firmware image exists locally {{ bmc_fw_update_image_file }}
   ansible.builtin.stat:

once fixed, I can test the same with token:
curl -k -H "Content-Type: application/json" -X POST https://<IP_ADDRESS>/login -d '{"username" : "root", "password" : "123456"}'
docker run --rm -it --entrypoint ansible-playbook -v $(pwd):/opt -w /opt/roles ghcr.io/opiproject/ansible-opi-dpu:main ../playbooks/firmware.yml -vvv -i "<IP_ADDRESS>," -e dpu_bmc_token='123456' -e bmc_fw_update_inventory_name='6d53cf4d_bmc_firmware' -e bmc_fw_update_image_file='/tmp/bf2-bmc-ota-24.04-5-opn.tar'

will find out whats going wrong


ACCUMULO-4604 Improve 'accumulo classpath' command

Default output is now colon seperated jars on one line
Added '-d' option to print old human readable format
Improved usage for accumulo script commands

I am going to merge today if there are no objections

Executing the following reveals a lot of duplicates out of the box. This should be resolved with your other PR to trim out the redundantly configured jars from the site file.
accumulo classpath | tr ':' "\n" | less | sort | uniq -c | grep -v ' 1 '

To test that, I set general.classpaths to /var/tmp/ in accumulo-site.xml, and re-ran this command. I verified that it removed the duplicates, but it also added an item, $(pwd)//var/tmp/, to the output. I set it to empty string, and it added $(pwd)/ to the output. These are both incorrect. The current directory should never get added, and absolute paths should not be resolved relative to the current directory.
Also, it's not clear that the expected output of this command should include stuff from the AccumuloClassLoader or the AccumuloVFSClassLoader by default (without specifying some sort of depth/level).


Bug 1316224 - User can not create projects in any other repository than master

https://github.com/droolsjbpm/guvnor/pull/285
https://github.com/droolsjbpm/kie-wb-common/pull/302
https://github.com/droolsjbpm/drools-wb/pull/143
https://github.com/droolsjbpm/jbpm-console-ng/pull/364
https://github.com/droolsjbpm/optaplanner-wb/pull/46
https://github.com/droolsjbpm/kie-wb-distributions/pull/228

+1 to merge (when green).

Jenkins please retest this.

master: 37c8934107abe11b49e488ff51a2b25f0e7f9fb2


Update Fedora Package

The last copr build is from 4 months ago. https://copr.fedorainfracloud.org/coprs/jdoss/nebula/
Please update it to v1.5.0
@jdoss
Also, how do you run nebula with SELinux enforcing ? For Fedora I can use this copr but are there any specific SELinux instructions for other distros ?
Example: In Rocky Linux nebula refuses to work with SELinux enforcing. The SeLinux logs spewed some commands to grant an exception for nebula's sytem service and thats how I got it to work there.

I'll get it upgraded this weekend.

Thanks

I have been trying to get this packaged but the minimum supported Go version is 1.17 and Fedora 35 only has 1.16.8. I am getting failures due to //go:build lines from the new version.
https://download.copr.fedorainfracloud.org/results/jdoss/nebula/fedora-34-x86_64/02990805-nebula/build.log.gz
+ go-rpm-integration install -i github.com/slackhq/nebula -b
/builddir/build/BUILD/nebula-1.5.0/_build/bin -s
/builddir/build/BUILD/nebula-1.5.0/_build -o
golang-github-slackhq-nebula-devel.file-list -O
/builddir/build/BUILD/nebula-1.5.0 -V 1.5.0-1.fc34 -p
/builddir/build/BUILDROOT/nebula-1.5.0-1.fc34.x86_64 -g
/usr/share/gocode -r '.*example.*'
Installing: github.com/slackhq/nebula
panic: //go:build comment without // +build comment
goroutine 1 [running]:
panic(0x564a8a71c5e0, 0xc000028d90)

I can revert  https://github.com/slackhq/nebula/pull/553/files and patch it as part of the package process but that might cause issues. @nbrownus what would you do here? Fedora 34 and 35 have Go 1.16.x and Fedora 36 will have 1.17 once it is released in the spring.

I think this is actually a bug on our side, it looks like we didn't run gofmt properly on some of the windows files, (perhaps because they don't automatically gofmt when we are developing on Linux?)
I think the issue might actually be from the wintun code we imported. It looks like we need to run gofmt on them to fix the build comments (it looks like wintun/tun.go and wintun/device.go are both missing them)

created a proposed patch in #598.
Can you try building the rpm with this patch?

@wadey it built just fine with your PR 🥳
https://copr.fedorainfracloud.org/coprs/jdoss/nebula/build/2995114/
I think we can close this issue now as 1.5.0 is now released on the Copr.

Thank you


variables renaming

Thanks for your work on this @adesokanayo - I added a few notes for small changes that need to be addressed, and I also ran the tests, which failed unfortunately. However, please note you can also run any of these tests locally. You can see which tests run in the CI by looking here

@malwaredllc  I have only the integration test failing.  Do you think there is a config  mismatch in my changes ?

@adesokanayo It looks like it's because you need to update the Node struct JSON serialization/deserialization here. You change the key names in the config file so you need to update that.

If the workflow still fails, I will start from a fresh clone of main  and will start with function-scoped variables only.

@adesokanayo Tests are passing but can you change the name of cacheClient.go to client.go, and cacheClient_Docker_Test.go to client_test.go?

@adesokanayo Nice, I am glad you changed the lru_cache to lru as well. You will need to update the CI test here to use that new name: https://github.com/malwaredllc/minicache/blob/main/.github/workflows/go.yml

Merged! Thanks for your work on this @adesokanayo


Live migration fails if OSPF is used in the container

Required information

Distribution: Ubunto 16.04.1
Kernel version: 4.4.0-38-generic
LXC version: 2.0.5
LXD version: 2.4.1
Storage backend in use: zfs

Issue description
Live migration is not possible if OSPF is used in the container. Migration fails with the following messages:
error: Error transferring container data: migration dump failed
(00.568350) Warn  (arch/x86/crtools.c:132): Will restore 8668 with interrupted system call
(00.572573) Warn  (arch/x86/crtools.c:132): Will restore 9274 with interrupted system call
(00.631159) Warn  (arch/x86/crtools.c:132): Will restore 8674 with interrupted system call
(00.722985) Warn  (arch/x86/crtools.c:132): Will restore 8680 with interrupted system call
(00.827495) Warn  (arch/x86/crtools.c:132): Will restore 8699 with interrupted system call
(00.870483) Warn  (arch/x86/crtools.c:132): Will restore 8706 with interrupted system call
(00.870872) Warn  (arch/x86/crtools.c:132): Will restore 8710 with interrupted system call
(00.882325) Warn  (arch/x86/crtools.c:132): Will restore 8711 with interrupted system call
(00.932500) Warn  (arch/x86/crtools.c:132): Will restore 8715 with interrupted system call
(00.933495) Warn  (arch/x86/crtools.c:132): Will restore 8717 with interrupted system call
(00.982186) Error (sk-inet.c:105): Unsupported proto 89 for socket e528
(00.982236) Error (cr-dump.c:1303): Dump files (pid: 8917) failed with -1
(00.996372) Error (cr-dump.c:1600): Dumping FAILED.

It's problematic because OSPF could be very usefull setting up some dynamic routing scenario... especially when using live migration to have no (or very small) interruption.
Is there something really problematic with OSPF ?

As of now, CRIU seems to only support IP, TCP, UDP, and UDPLITE. A patch to CRIU would be required to add support for the OSPF IP protocol.

Yes, I've seen that.
But I realize that it's not realated with LXC/LXD but more with CRIU. I close this issue and re-open one here.


Uploading test data fails

Current behaviour
❯ ./upload-testdata.sh
Uploading testdata
Traceback (most recent call last):
  File "item-relationship-service/local/deployment/full-irs/../../testing/testdata/transform-and-upload.py", line 455, in <module>
    raise ArgumentException("Dataplane URLs have to be specified with -d or --dataplane if --aas flag is set!")
TypeError: exceptions must derive from **BaseException**

Expected behavior
Test data should be written to the local deployment.
Steps to reproduce the Bug

Follow the readme for local deployment: https://github.com/eclipse-tractusx/item-relationship-service/blob/main/local/deployment/full-irs/README.md
Upload test data as described here: https://github.com/eclipse-tractusx/item-relationship-service/blob/main/local/deployment/full-irs/README.md#3-prepare-test-data

I tried changing local/deployment/full-irs/upload-testdata.sh for a bit but I can't figure out what I need to add.
Thanks for your time!

Thank you for this input. We will discuss that in the next sprint

[ ] Add the description to use one the specific tag 2.4.0 to use this
[ ] Add documentation to tractus-X to use one specific tag 2.4.0

Testdata upload was successful on the local full-irs deployment using tag 2.6.0.
Unfortunately, the issues with the JSON schema validation library are also affecting older IRS versions, so it is currently not possible to complete IRS jobs on versions older than 3.5.1.
For this to work, we need to update the entire full-irs deployment to the latest IRS version

@jzbmw Ready for PO Review


Validation on entire form triggers a wrong "rrf/setSubmitFailed" when validation passes again

If I have a form with a validation rule on the form model (with key ""):
<Form model="my_model"
	  validateOn="submit"
	  validators={{
		"": [ function(m){ return myValidators.match(m.password,m.passwordConfirmation); } ],
		password: [ myValidators.isRequired, myValidators.isPassword ],
		passwordConfirmation: [ myValidators.isRequired ],
	  }}
	  onSubmit={props.onSubmit}>

Password

    <Field model="my_model.password">
		<input type="password" />
	</Field>
	<Errors model="my_model.password"
	    messages={{
		    "0": "Password is required",
		    "1": "The password must be at least 6 characters long"
    	}}
    	show={{ touched: true, focus: false }} />

Retype your password

    <Field model="my_model.passwordConfirmation">
			<input type="password" />
    </Field>
    <Errors model="my_model.passwordConfirmation"
	         messages={{
		    "0": "Password is required"
	         }}
	         show={{ touched: true, focus: false }} />
    <Errors model="my_model"
	         messages={{
		    "0": "Password and password confirmation must match"
	         }}
	         show={{ touched: true, focus: false }} />

		<button type="submit">Next</button>

</Form>

Now if I input values that trigger a validation error:
{"type":"rrf/setSubmitFailed","model":"my_model"}
{"type":"rrf/setFieldsValidity","model":"my_model","fieldsValidity":{"":{"0":true},"password":{"0":false,"1":false},"passwordConfirmation":{"0":false}},"options":{"errors":true}}

And then correct the input so that there is no more validation error, I then have to click on submit twice because the first time I click on submit, it will trigger:
{"type":"rrf/setSubmitFailed","model":"my_model"}    <= it should NOT trigger this
{"type":"rrf/setFieldsValidity","model":"my_model","fieldsValidity":{"":{"0":false},"password":{"0":false,"1":false},"passwordConfirmation":{"0":false}},"options":{"errors":true}}

And the second click will trigger just this:
{"type":"rrf/setFieldsValidity","model":"my_model","fieldsValidity":{"":{"0":false},"password":{"0":false,"1":false},"passwordConfirmation":{"0":false}},"options":{"errors":true}}

Version `"react-redux-form": "^0.13.1"``

Also meet that issue today.
To simplify you just need form(with validators prop) with one field(field must not has validator prop).
Every time after input will become valid, you need to press button twice.
<Form
    model={MODEL}
    validators={{name: val => !!val}}
    onSubmit={this._save}
    validateOn="submit"
>
    <TextField model={`${MODEL}.name`}>
        <input/>
    </TextField>
    <button type="submit">submit</button>
</Form>

Fixed! In case you were wondering what the issue was:
-    const formValid = form
+   const formValid = (form && !fieldsValidity.hasOwnProperty(''))
      ? form.valid
      : true;

The formValid flag was being determined on the existing validity of the form, and not taking into account the new validity. Now it does!
This fix also improves performance slightly, as the callback functions for handling valid form submits are no longer recreated each time in render() - they're only created once.

Will wait for release 👍


About connect the 5-frames snippets into a complete sequence

I want to test the whole sequence pose estimate, but the pose net output the 5-frames snippets. By observing the 5-frames snippets(format: timestamp tx ty tz qx qy qz qw), the world coordinate system in each snippets is different ,how to change it to the same world coordinate system,such as reference frame is the NO.0 frame.And how to reduce the error while project to the same coordinate system.

A naive way is to do pose estimation in a sliding window manner (i.e. [t0, t1, t2, t3, t4] and then [t4, t5, t6, t7, t8, t9] and so on), and then transform all poses to be w.r.t. the reference frame t0. Since there's overlap between consecutive snippets, it is straightforward to transform the poses back to t0 by tracing back recursively.


feat(costmodels): get provider's cost models from /providers API

closes #1128
Use the cost_models data from the response of providers API instead of doing N+1 calls.

Codecov Report

Merging #1130 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1130   +/-   ##
=======================================
  Coverage   75.24%   75.24%
=======================================
  Files         228      228
  Lines        4408     4408
  Branches      833      833
=======================================
  Hits         3317     3317
  Misses        973      973
  Partials      118      118

Impacted Files
Coverage Δ

src/api/providers.ts
55.55% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e034e...f57757a. Read the comment docs.


CLS and Promises

Is there a way to patch this so CLS works inside the Promises without having to fork and patch the entire thing with cls-bluebird?

Request-Promise uses just one promise internally which is instantiated when a request is made.
In comparison to the patch code of your fork you may even do the patching after you require Request-Promise:
var rp = require('request-promise');
var clsBluebird = require('cls-bluebird');

clsBluebird(...);

rp('http://google.com').then(...);

IMHO with this code there is no need to fork Request-Promise anymore. However, does this solution meet your expectation?

wouldn't this require that I have bluebird as a package as well, maybe it's a mis-understanding of how this works.
I can't patch bluebird cause I'm not using it in my own code.
inside of cls-bluebird, it's requiring bluebird.
I was under the assumption that npm modules are scoped to the library that adds it as a dependency.
If my assumption above is correct (it's probably not). How would I get to bluebird inside of request-promise to patch it without forking it?
I would love to not have to fork it.

I think mongoose went down the route of giving you the option of supplying your own promise library and since promises are built in to es6, maybe it wouldn't be a bad idea to follow that convention on libraries that use promises (give people the option of supplying a promise library or maybe even checking to see if one exists on the globally (es6)).

 But anyways, to not having multiple versions of Bluebird laying around in your project Request-Promise intentionally has a loose version requirement for Bluebird (^2.3). If you already have installed Bluebird in your project then this version will be used by Request-Promise as well. That is NPM won't install another version of Bluebird anymore. Then the above code would actually work. However, as I write this I get the feeling this is not a save / clean solution.
I think CLS is a really important concept and should be treated accordingly. How about we add the following method to Request-Promise?
rp.bindCLS(/* ns */);

yes the above would work as well!

I just realized that cls-bluebird should not work even for your fork because Request-Promise requires a fresh Bluebird prototype (require("bluebird/js/main/promise")() - see details here) and cls-bluebird therefore gets a different Bluebird prototype (require('bluebird')).
Could you double check that?

It works, cls-bluebird has bluebird as a peerdependency so it's looking for it in the parent project. I was wondering that too, till I looked in the package.json
The fork is currently working for me.

Oh, I don't know about the fresh bluebird prototype though, it passes my unit test :).. it has access to the CLS namespace in the success callback of the promise when hitting google.com.

the main bluebird entry point is this file (bluebird.js)
"use strict";
var old;
if (typeof Promise !== "undefined") old = Promise;
function noConflict() {
    try { if (Promise === bluebird) Promise = old; }
    catch (e) {}
    return bluebird;
}
var bluebird = require("./promise.js")();
bluebird.noConflict = noConflict;
module.exports = bluebird;

and it ultimately requires promise.js?

I'm not sure how what their saying even relates, it looks like bluebird stomps on the global Promise and you wouldn't want your blueprint of a dependency lib setting the 'old' property after a blueprint lib in a app set it, otherwise the behavior of calling 'noConflict' would have unexpected results. It might restore it to another bluebird promise instead of the old one..

so someone should do a pull request into cls-blueprint to not require blueprint.js, but instead promise.js like you guys are doing, to prevent the above..

:D good point.
cls-bluebird could only also require promise.js if it afterwards returns the patched Bluebird prototype. If the user requires Bluebird himself - in any way - it will always get a different Bluebird prototype.

I just checked Bluebird's code and find it really puzzling that your fork actually works. It shouldn't because the Bluebird prototype Request-Promise is using doesn't get patched. At least from what I can tell by reading all the relevant code. ;D
Anyway, I am now tending towards your suggestion to follow mongoose's strategy. Partly because issue #43 suggests some larger changes that result in being able to inject Bluebird - which might be CLS patched by the user - into Request-Promise.

give me a few minutes, I'll put a unit test together in my fork, the unit test I have working in a different library.

I can't get it to fail now (sigh). I swear I just recently switched it and it failed, now it won't fail... So maybe the patch isn't doing anything.

I added a unit test anyway to that fork, that's similar to what we're doing where I swear it wasn't working, the only problem with my unit test is if you don't enable the patch, it still passes. So I don't know anymore.

Working on the other issues was overdue anyway. I'll take all requirements - including CLS - and work on the next version of Request-Promise this weekend.

I just released version 1.0.0 which includes the rp.bindCLS(/* ns */); function which we discussed. For details see the README section for that.
I am sorry, but I can only call this feature experimental. Since cls-bluebird is so quick and dirty it still misses a lot of use cases. Namely not allowing the user to bind the same namespace twice and allowing the user to bind multiple namespaces.
I am tracking cls-bluebird on VersionEye and will look into its code once a new version is released.
Thanks for getting this ball rolling @silverbp !

Hi @silverbp , I just released<EMAIL_ADDRESS>which drops CLS support due to numerous complaints about the way I added its support. However, I came up with an alternative solution which should be very easy for you to migrate to: https://github.com/request/request-promise/wiki/Getting-Back-Support-for-Continuation-Local-Storage
I hope this introduces no trouble for you! And let me know if the migration doesn't work in one way or another so I can help.


V4 pre-signed url gets SignatureDoesNotMatch error

I am tried to generate a valid V4 pre-signed url for uploading an image to S3.
I have checked and double-checked this:

I have a valid set of accessKey and secretKey
The IAM user for the keys has PutObject & PutObjectAcl permissions for the correct bucket
The bucket's ACL has "Any authenticated AWS user" Read, Write access
My bucket name does not contain a - or a .

Here is my code:
let path = generateUrlForAsset(withName: assetName, fileExtension: validated.fileExtension)
let requestHeaders = ["x-amz-acl": "public-read"]
let preSigned = try s3Signer.presignedURLV4(httpMethod: .put, urlString: path, expiration: .thirtyMinutes, headers: requestHeaders)

the generateUrlForAsset function generates a url like https://s3.amazonaws.com/mybucketname/originals/5FBD0704-882B-4A8A-B931-8DB03D8DECBC.png
I've tried using the signed url both with a web form but also curl like so:
curl "https://s3.amazonaws.com/mybucketname/originals/5FBD0704-882B-4A8A-B931-8DB03D8DECBC.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=MYS3ISSUEDACCESSKEY%2F20170629%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20170629T125701Z&X-Amz-Expires=1800&X-Amz-SignedHeaders=host;x-amz-acl&X-Amz-Signature=68c7d70b876a581bb581d23b159c2161dcc4f76343468dc5d805813ef1724b9c" --upload-file test.png -H "x-amz-acl: public-read"

I am out of options for debugging so far. Do you have any idea what I might be doing wrong?
Update 1:
I studied the generated url further and I saw that the query parameter for signed headers seperate the headers by ; which doesn't seem like a valid query parameter value to mee
X-Amz-SignedHeaders=host;x-amz-acl
Update 2:
I remove the x-amz-acl header from the list of headers and the url works now.
Update 3:
Escaping the ; is unfortunately not enough.
I tried generating a url with the native aws-sdk for node.js and it generates the same url where the ; is escaped, but it also appends &x-amz-acl=public-read. This URL however works.

I studied the generated url further and I saw that the query parameter for signed headers seperate the headers by ; which doesn't seem like a valid query parameter value to mee
X-Amz-SignedHeaders=host;x-amz-acl

I remove the x-amz-acl header from the list of headers and the url works now.

hey @ksmandersen, thanks for reporting the issue you were having. Were you able to get it working properly with your fork?

 I am not sure exactly what the issue is. I only know for certain that it only occurs when adding additional headers to the pre-sign request.

@JustinM1 Adding no headers generates a valid url. Adding any kind of header generates a url with an invalid signature.

@ksmandersen alright thanks, I'll try to look into it as soon as possible.

@ksmandersen I was able to make some updates to the project, cleaned a lot of things up, and added tests from the AWS Test Suite and the S3 examples. Unfortunately, I have only been able to find one example using V4 pre-signed URL and it doesn't add extra headers.
https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-query-string-auth.html#query-string-auth-v4-signing-example
Without having a chance to test with a real request, I believe it was an encoding issue. I have updated how headers are signed for V4 pre-signed URL requests to include percentEncoding according to characters AWS specifies. If you get a chance to try it out, let me know.
There are some minor breaking changes when you update to 3.0.

Closing for now. Please reopen if issues continue.


Disable Proxy for 'whitelisted' domains

Hey there,
It would be great if there is an extension, that allows a list of domains to not be altered by the proxy, beside maybe https>http.
I have macintosh.jipvankuijk.com which already shows perfectly on older browsers, and via the proxy looks worse as an example.
Cheers.

Hey there, thanks for checking out the project.
What computer and browser are you using?
I've been using MacWeb 2.0, which doesn't have CSS support, so currently MPP strips all CSS from all pages.
This could be what's causing your site to look worse.
If it is just a CSS issue, the change should be fairly straightforward. Would a boolean flag in config.py that globally allows/disallows CSS stripping solve the issue for you?
Images of the expected rendering and the actual rendering might be helpful for debugging. And if your vintage browser has a way to view a page's source, before and after images of the HTML the browser is receiving might also be helpful.

Hey!
I'm using a Macintosh Plus, and Macintosh SE running System 7.0 both with MacWeb 2.1, these indeed don't support CSS and they work fine.
On my SE/30 however I can use Internet Explorer 3.1 or iCab 2.9.9. These browsers do support, in a limited fashion CSS and inline images etc.
I've already added a piece of code that adds CSS code inline for images to set the max width to 480 pixels, and reduced the image conversion script to match 480 width and 300 height.
But it would be nice to have a way to have a list in proxy.py or in an extension that can be used as a whitelist, where the proxy does not do anything to the html code, no css removal etc, and only run the image processing(if possible).

Hey @jipvankuijk,
I just merged a PR that should address these issues.
As of a8e8d1acc56cb3d2a81a77518233c04c2b09cf4d, MacProxy Plus now allows you to specify a whitelist in config.py, which disables tag and attribute stripping for whitelisted domains.
Additionally, config.py now allows you to specify some image conversion settings (max_width, max_height, etc).
You can also quickly switch between presets for different browsers (stored in /presets) by specifying a PRESET string in config.py.
If this addresses your need, I'll close this issue.
Thanks again for your suggestion! I think it pushed the project in a good direction.

Closing this for now, as the requested feature has been implemented.


Bump kcp chart to version 0.8.3

To release updates from #106 and #108.

/hold
until #108 is merged.

/hold cancel
/approve


Ensure partial re-renders are stable

Addresses https://github.com/tildeio/glimmer/issues/174
Next, I'll refactor so that you get the stable DOM test for free with rerender(), which will address https://github.com/tildeio/glimmer/issues/175
Tested the changes in Ember and confirmed that they make the partial tests pass.
cc @mmun

Woohoo!


Implement possibility to skip some test/tests depends on browser

Currently we think it would be nice to have something like this in new API:
test('Test name')
    .skipIf( browserInfo => ...)

There browserInfo contains UA string, alias and version.

Closing in favor of #246


update README

What

update README to improve auto-generated doc lp

https://openfoodfacts.github.io/smooth-app

Thanks @monsieurtanuki


ScrollMark(Up|Down) should scroll to absolute beginning/end if it would overflow

Trivial alternative to #836.

Abstract
Executing ScrollMarkUp to jump to the previous prompt should jump to the current beginning of the scrollback buffer in case the previous prompt no longer exists. If we have two large outputs in the buffer with only one prompt in the middle, we need to press ScrollToTop explicitly, instead of ScrollMarkUp falling back to its behaviour.
In an analogous fashion, if the last jumped marker is the last prompt and the "next" does not exist yet (because the process is still running, perhaps), then ScrollMarkDown should behave the same way as ScrollToBottom
Motivation
C++ SFINAE outputs.

Lovely motivation! :)


Wow!

This is awesome! Maybe it could have it's own permissions system? That'd be cool

Thank you for the feedback!


[T4A6][W13-B2]YongLinHan

Ready for review

@ylhlh

in general good work on this. keep it up!
Some comments added. Please ack & close the PR after reading comments.


Odd Hanging Behaviour on OrderedWorkers Based On Payload Size

I'm seeing hangs using OrderedWorker if the payload used in put is longer than a certain size.  Here is an example that will randomly hang on my machine if a single character is added to the payload:
from __future__ import print_function
import random
import mpipe

class OWorker(mpipe.OrderedWorker):
    def doTask(self, value):
        return value

if __name__ == '__main__':

    stage_get = mpipe.Stage(OWorker, 2)
    p = mpipe.Pipeline(stage_get)

    j=95
    if random.randint(0,1):
        print("HANGS")
        j += 1
    else:
        print("WORKS")

    for i in list(range(10)):
        d = {'payload': 'a'*j}
        p.put(d)

    p.put(None)

    for r in p.results():
        print(r)

Tested hanging behavior on OS X using Python 2.7.11 and 3.5.1.  Latest version of mpipe installed via pip install mpipe.

@lycovian, unfortunately i'm not able to duplicate the result--it's not hanging on my platform with either 95 or 96 character string (Python 2.7.12 and 3.5.2, mpipe version 1.0.8, Ubuntu 16.04.) I'm not seeing anything wrong with your code, either.


docs(tutorials/blog): fix code highlight

Fixed incorrect code highlighting.
Closes: #

[x] Docs
[ ] Tests

Testing Strategy: N/A (docs change)
Current code highlighting is below:

Going to close this as the code highlighting is correct
http://remix.run/docs/en/main/tutorials/blog


Rename to gingersnap

OLM bundle validation failing locally. Need to fix and add bundle validation to CI

Merging as failure not related to changes.


fix: Reset compositionKey when backspacing a selection on Android where anchor and focus keys are different

fixes #5259
PR #5077 added a fix for the android backspace bug where pressing backspace delete two characters at once, by setting the compositionKey to selection.anchor.key when on Android. However, in cases where the anchor.key and focus.key are different, the compositionKey isn't cleared causing an issue where the selection wouldn't go away as described in #5259.

Looks right, thank you!


Can't open pdf when using internal help browser

This might actually be an interaction with Adobe Acrobat Reader.
R packages often have vignettes which are pdf files. Trying to open these from the internal help fails. An example is the Matrix package:
library(Matrix)
?Matrix

In the internal help, navigate to the main Matrix help page, then go to the vignettes link (2nd from top). Click on any of the pdf links. The help pane goes blank, and when I try to go back (click on the Back button), VS spins its wheels for a few seconds. Acrobat Reader also starts up in the background, and then disappears.

By design. internal browser is IE and has limitations. For complex content external browser is the only option.

Would it be possible to display an alert at least, if this happens? Or is it unrelated to RTVS?

I have simple solution

https://github.com/Microsoft/RTVS/commit/1e205ba4476f9703a1e00bc5c2c17907255b7e50


About describing parameter in django-rest-swagger 2.2.0

Hello I am documenting my django rest api by using django-rest-swagger 2.2.0. and I can not find any way/documentation to describing required parameters etc.So if there is please help.
Thanks

Hello , has the problem been solved？

Hello , has the problem been solved？

I have the same problem, I can't find anything about documentation to add parameters


Infinitive loop in custom modifier

Reproduction demo
https://codesandbox.io/s/react-popper-v2x-issue-template-zck02?file=/src/index.js
Steps to reproduce the problem

open attached link
open console
you will see infinitive loop and whole application and browser stuck

What is the expected behavior?
Custom modifier modifies popper's width with the same width of input element. Also, without any infinitive loop.
What went wrong?
Custom modifier goes to infinitive loop of defined function:
 fn: ({state: { elements: { popper, reference }}}) => {
   console.log("state", state);
  popper.style.width = `${reference.offsetWidth}px`;
}

Any other comments?
The same code worked with packages popperjs/core 2.4.0 and react 16.13.1. Code was tested in Firefox (76.0.1) and Brave (Version 1.8.96 Chromium: 81.0.4044.138) browser of Linux Ubuntu 76.0.1 OS.
Packages versions

Popper.js: 2.4.0
react-popper: 2.2.3

This happens because you are defining the modifier in-line, so on each render its identity changes, and leas to the render loop.
You should define the modifier in a useCallback, or directly outside the component.
https://codesandbox.io/s/react-popper-v2x-issue-template-zfrf6?file=/src/index.js

It might be good to mention this in the documentation if not already there.

https://popper.js.org/react-popper/v2/faq/#why-i-get-render-loop-whenever-i-put-a-function-inside-the-popper-configuration


Unrug Thread Stark Degenz.md

@StarkDegenz add to already existing threads.md document please

@StarkDegenz add to already existing threads.md document please
should be good now ?

no :(


Improvements in swagger and generics

Fix swagger specification to can load in swagger editor.
Improved type resolution for generic types arguments.

Had to modify the type resolution a bit in order to remove the type variable names from the Type. Btw, why was the longName stored in the MethodResult and ResourceMethod?
Thank you very much for contibuting and reminding me of the problem with type arguments (and parameterized methods, and wildcard types, and so on)! :smiley:

I forgot to remove longName, I had put in swagger output to easily verify the results.
Thank you! :)


Show error when creating configuration settings that are blocked

In the portal, creating a setting named FUNCTIONS_WORKER_RUNTIME or AzureWebJobsStorage are not allowed, but the configuration editor accepts the values. Things appear to be okay, but the values are actually not saved and the user is not alerted.
Related #61

Hi @anthonychu, I believe this issue can be closed. See https://github.com/Azure/static-web-apps/issues/374#issuecomment-920729015 🙂


feature request: show diffs in errors messages

When we have diffs in error messages they are simply rendered as plain text:

It would be nice if they were rendered diffs.

They were diffs in the previous version, I just didn't like them much with the test failure outputs in the Dune project. The problem with the way VS Code handles them is that either the diff is displayed or the whole failure message (which I always append to the tests).
Adding them back in and making them configureable isn't much work, so I'll do that.

Just released a new version. I did not make this configurable, as the whole output can still be seen by hovering the let%expect_test stanza above the diff.

Works since version 0.6.0

Looks great thanks!


migrate from k8s.gcr.io to registry.k8s.io

Description

Fix  https://github.com/kubernetes/k8s.io/issues/4780
Additional Information
This PR migrate from k8s.gcr.io to registry.k8s.io

This has been addressed via https://github.com/kubewarden/docs/pull/166. Sorry, I was going through my github notifications in reverse order...
Nevertheless, thanks for your contribution!


Catchup slow on testworld

More than an hour
Seeing validation timeouts on blocks

@deepthiskumar could this be a problem with persisted vs non-persisted frontier? Removing the conf directory resolves the syncing issue for some

@deepthiskumar could this be a problem with persisted vs non-persisted frontier? Removing the conf directory resolves the syncing issue for some

@trevorbernard did you try this around the same time? We saw this when the node had to do a full catchup because its persisted state was far too behind (older than 280 blocks)

Unfortunately no, I didn't run into this issue.

Testworld has ended. Closing.


Only part of dialogs are shown in lu/lg navigation list

Describe the bug
In my bot, I have lots of dialogs and I can see all of them as below

But in the LU/LG navigation list, I can just see part of them

Version

Browser

[x] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Additional context

https://github.com/microsoft/BotFramework-Composer/pull/2747


RLLib version

Hi,
Can you please specify the Ray version under which the rllib example code runs? I am currently getting this error with Ray 1.11.0:
Traceback (most recent call last):
  File "/Users/grigoriiguz/projects/speech_acts/meltingpot/examples/rllib/self_play_train.py", line 116, in <module>
    main()
  File "/Users/grigoriiguz/projects/speech_acts/meltingpot/examples/rllib/self_play_train.py", line 109, in main
    trainer = get_trainer_class(agent_algorithm)(env="meltingpot", config=config)
  File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/agents/trainer.py", line 746, in __init__
    super().__init__(config, logger_creator, remote_checkpoint_dir,
  File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/tune/trainable.py", line 124, in __init__
    self.setup(copy.deepcopy(self.config))
  File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/agents/trainer.py", line 822, in setup
    self.workers = self._make_workers(
  File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/agents/trainer.py", line 1995, in _make_workers
    return WorkerSet(
  File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/evaluation/worker_set.py", line 101, in __init__
    remote_spaces = ray.get(self.remote_workers(
  File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/_private/client_mode_hook.py", line 105, in wrapper
    return func(*args, **kwargs)
  File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/worker.py", line 1765, in get
    raise value
ray.exceptions.RayActorError: The actor died because of an error raised in its creation task, ray::RolloutWorker.__init__() (pid=26916, ip=<IP_ADDRESS>, repr=<ray.rllib.evaluation.rollout_worker.RolloutWorker object at 0x168f2cb80>)
  File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/evaluation/rollout_worker.py", line 636, in __init__
    self.async_env: BaseEnv = convert_to_base_env(
  File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/env/base_env.py", line 732, in convert_to_base_env
    return env.to_base_env(
  File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/env/multi_agent_env.py", line 311, in to_base_env
    env = MultiAgentEnvWrapper(
  File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/env/multi_agent_env.py", line 481, in __init__
    self._agent_ids = self._unwrapped_env.get_agent_ids()
  File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/env/multi_agent_env.py", line 210, in get_agent_ids
    if not isinstance(self._agent_ids, set):
AttributeError: 'MeltingPotEnv' object has no attribute '_agent_ids'
(RolloutWorker pid=26916) 2022-04-06 15:27:14,711       ERROR worker.py:430 -- Exception raised in creation task: The actor died because of an error raised in its creation task, ray::RolloutWorker.__init__() (pid=26916, ip=<IP_ADDRESS>, repr=<ray.rllib.evaluation.rollout_worker.RolloutWorker object at 0x168f2cb80>)
(RolloutWorker pid=26916)   File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/evaluation/rollout_worker.py", line 636, in __init__
(RolloutWorker pid=26916)     self.async_env: BaseEnv = convert_to_base_env(
(RolloutWorker pid=26916)   File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/env/base_env.py", line 732, in convert_to_base_env
(RolloutWorker pid=26916)     return env.to_base_env(
(RolloutWorker pid=26916)   File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/env/multi_agent_env.py", line 311, in to_base_env
(RolloutWorker pid=26916)     env = MultiAgentEnvWrapper(
(RolloutWorker pid=26916)   File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/env/multi_agent_env.py", line 481, in __init__
(RolloutWorker pid=26916)     self._agent_ids = self._unwrapped_env.get_agent_ids()
(RolloutWorker pid=26916)   File "/Users/grigoriiguz/miniconda3/envs/rlenv/lib/python3.9/site-packages/ray/rllib/env/multi_agent_env.py", line 210, in get_agent_ids
(RolloutWorker pid=26916)     if not isinstance(self._agent_ids, set):
(RolloutWorker pid=26916) AttributeError: 'MeltingPotEnv' object has no attribute '_agent_ids'

@grig-guz You can try version 1.4.1.

For now you can add

    self._agent_ids = [
        PLAYER_STR_FORMAT.format(index=index)
        for index in range(self._num_players)
    ]

to the end of MeltingPotEnv.init() in examples/rllib/multiagent_wrapper.py.

@Muff2n that worked thanks!

Could you please turn this into a pull request so that it is fixed for everyone?

This is added as part of PR 25 (if you are happy to have one PR address two issues).

It would be preferable to split single PR for single change, please :)

@Muff2n
I tried both running your proposed solution and the code that you submited in the pull request and I got the following error:
KeyError: 'player_0'
Do you know why could this happend?

I think that the issue is associated with the new Ray version that was published today.
I will check this hypothesis ASAP.

@Muff2n Hello, I managed to get the code working  by installing pip install ray==1.11.0.
However, I wonder how would this affect your PR.

Thank you for the heads up. It is a problem with ray==1.12.0. Taking a look at rllib it seems to have some bugs in it.
While I can give the new-style _agent_ids with:
    self._agent_ids = set(
        PLAYER_STR_FORMAT.format(index=index)
        for index in range(self._num_players)
    )
    super().__init__()

There are other issues.
For example in ray/rllib/utils/pre_checks/env.py lines 333-341:
def _check_reward(reward, base_env=False, agent_ids=None):
    if base_env:
        for _, multi_agent_dict in reward.items():
            for agent_id, rew in multi_agent_dict.items():
                if not (
                    np.isreal(rew) and not isinstance(rew, bool) and np.isscalar(rew)
                ):
                    error = (
                        "Your step function must return rewards that are"
                        f" integer or float. reward: {rew}. Instead it was a "
                        f"{type(reward)}"
                    )
                    raise ValueError(error)

Here they test that the rewards returned are real, not boolean and scalar. That trips out for me because meltingpot is passing float rewards. The error message says that floats are acceptable (which I think they should be) and quotes the type of the reward dictionary rather than the type of the reward that they are testing.
Therefore I think it best to stick with ray=1.11.0 for now. I can look more closely and submit the PR next week.


Add explicit import of get_ipython()

As is, the code works if run directly inside a Jupyter notebook. It works because get_ipython() has already been implicitly imported into the top-level namespace. However, if you write Python code that in turn calls igv_notebook, you get an error: "Line 61: NameError: name 'get_ipython' is not defined." This modification explicitly imports get_ipython() so that it works regardless of whether or not igv_nbotebook is run from the top level namespace.

Thanks Thorin.


Automatic Extrae deployment on Distributed.Workers

Extrae automatically deploys on multi-node jobs if MPI communication is detected, which is not always the case in Julia. Automatically deploying to remote workers on execution and posteriously merging the intermediate trace files would make Extrae a perfect match for Julia.

I think that this issue contains different subtopics, so I will try to put some thouths on them
Initialization of Extrae
When using the libseqtrace library, Extrae is automatically initialized at library load. This can be avoided by setting the environment variable EXTRAE_SKIP_AUTO_LIBRARY_INITIALIZE=1.
To simplify, our first implementation can initialize Extrae manually, when Distributed is already loaded and the number of processors is already set (addprocs()) and therefore known.  This requires to setup the two resources functions (Extrae_set_threadid_function and Extrae_set_numthreads_function), correctly identifying the master process (which is worker id 1) as the process 0 for Extrae.  Therefore, this functions have to be implemented and passed to Extrae before initialization:
function distributed_taskid()::Cuint
    id = Distributed.myid() - 1
    return id
end

function distributed_numtasks()::Cuint
    nworkers = Distributed.nworkers()
    return nworkers
end

Also, the second requirement before initialization is to setup a program name for the mpits trace file. This is needed when using the libseqtrace library because each Extrae process is not aware of the existance of the others, so running the default configuration would end up in files with the same name causing conflicts. This can be solved setting an environment variable before initialization, more or less like this:
# Set environment variable for different TRACE{Var}.mpits files
    name = "JULIATRACE" * string(id)
    var = "EXTRAE_PROGRAM_NAME"
    @ccall setenv(var::Cstring, name::Cstring)::Cint

Then initialization can be done by just executing Extrae.init() in all workers with @everywhere.
If we wanted to autmatically initialize Extrae when setting up new workers, we can implement this in the prehook of addprocs, or adding a specialized addprocs function.  Then we can initialize extrae on those workers. This will require also to notify Extrae of changes of number of processors during execution.
Setting up context overdubbing in workers
The second technical subtopic related to automatic Extrae deployment is how we execute the runtime in the workers under the Extrae context, so we can overdub the Distributed runtime calls.  For now, two paths have been found:

First, as a proof of concept, we can ignore the "runtime" side of the workers, and only overdub the workload function itself, by sending an overdubbed version of the function to the workers. This way, at the workers' side we can detect when workload is execution, and correctly differentiating between useful and not useful work.
Then, a more final implementation would consist in running a whole overdubbed version of the event loop.  To to this, we need to launch the workers in a way that Julia executes our code when it starts.  Right now the only possible way to do this without modifying Julia image is to implement a custom ClusterManager that has a worker launcher that meets this requirements.

Finally, I would discuss this second topic in a separate issue.


[Google Bard] Unable to connect with servers

Extension
https://www.raycast.com/EvanZhouDev/raycast-bard-ai
Description
The current method of using the cookie from visiting bard doesn't work.
Steps To Reproduce
Using MacOS 13.4 and Google Chrome I visited bard.google.com.
I then had a quick conversation, opened the required cookie.
Copied this cookie into the input field.
It'd never be able to connect to the server.
Current Behaviour
No response
Expected Behaviour
No response

Found this now too! Still happening unfortunately :/

Still happening. Can't connect.
Steps:

Open Raycast
Enter Google session cookie key
Test command with Bard Ask AI
Bard failed to connect

Extension
https://www.raycast.com/EvanZhouDev/raycast-bard-ai
Description
The current method of using the cookie from visiting bard doesn't work.
Steps To Reproduce
Using MacOS 13.4 and Google Chrome I visited bard.google.com. I then had a quick conversation, opened the required cookie. Copied this cookie into the input field. It'd never be able to connect to the server.
Current Behaviour
No response
Expected Behaviour
No response

I encountered the same issue as well. I resolved it by re-completing the necessary steps in Google Chrome without extensions, and it worked.

Same here.

Please migrate to the PaLM API extension, if you are able to. The Bard extension is no longer stable, and the library powering it, bard-ai, is only working now for some people.


Refactor next track

Description
The main purpose of this pull request is to enhance the process of playing the next track in the queue.
Test Plan
N/A
Motivation and Context
The general functionality of the app needs to be improved to be leaner and more performant overall. By refactoring not only the NextTrack async thunk, but as well as the containers where the thunk is used, the process of playing the next track in the queue can be improved upon.
How Has This Been Tested?
I've manually tested the performance of the app by going through the containers in question and seeing how the new implementation is performing.
Types of Changes

Documentation
Bug fix
[x] New feature
Breaking change

Checklist

[x] My code follows the code style of this project

 Next track thunk


RancherCLI changes API version, and don't let execute docker commands in host

Rancher versions:
Rancher | v1.6.14
Cattle | v0.183.37
User Interface | v1.6.37
Rancher CLI | v0.6.7
Rancher Compose | v0.12.5
Agent: v1.2.9
Infrastructure Stack versions:
healthcheck: v0.2.3
**Docker version:  17.12.1-ce
**Environment Template: Cattle
Steps to Reproduce:
1) Using Rancher CLI execute volume ls
rancher --env 1a30 --host 1h272 docker volume ls
Answer:
docker volume ls requires API version 1.21, but the Docker daemon API version is 1.15
2) verify docker version using rancher CLI:
rancher --env 1a30 --host 1h272 docker version
Answer

Client:
Version:	17.12.1-ce
API version:	1.15
Go version:	go1.9.4
Git commit:	7390fc6
Built:	Tue Feb 27 22:17:40 2018
OS/Arch:	linux/amd64
Server:
Engine:
Version:	17.03.1-ce
API version:	1.27 (minimum version 1.12)
Go version:	go1.7.5
Git commit:	c6d412e
Built:	Fri Mar 24 00:40:33 2017
OS/Arch:	linux/amd64
Experimental:	false
3) Verify local docker version
dockcer version
Answer

Client:
Version:	17.12.1-ce
API version:	1.35
Go version:	go1.9.4
Git commit:	7390fc6
Built:	Tue Feb 27 22:17:40 2018
OS/Arch:	linux/amd64
Server:
Engine:
Version:	17.12.1-ce
API version:	1.35 (minimum version 1.12)
Go version:	go1.9.4
Git commit:	7390fc6
Built:	Tue Feb 27 22:16:13 2018
OS/Arch:	linux/amd64
Experimental:	false
Results:
The api version tag  API version:	1.15  does not correspond with de versions instlled in the local machine where rancher CLI is executed. Also take present the Git commit:	7390fc6 is the same using local or througth rancher command.

I did update the docker server version to  docker-ce=17.09.1~ce-0~ubuntu and it fixed the problem.


Request scanpollinginterval to be added

120 seconds to poll can feel far too slow in our pipelines.
Any chance scanpollinginterval could be added?

scanpollinginterval is now supported on the latest version of the action

closed


The shortcut key of adjust the Terminal size.

workbench.action.increaseViewSize and workbench.action.decreaseViewSize can adjust the size of View editor.
But Terminal panel  can only adjust the size by workbench.action.toggleMaximizedPanel.
I look forward to enhancing the ability to adjust the size of the terminal.

Is there a function of fold\unfold the all panel header of side bar?

There are terminal-specific commands to resize it:

This is not what I want to express.
Look at the picture below.

This is not what I want to express.
Look at the picture below.

Can achieve this purpose by workbench.action.increaseViewSize and workbench.action.decreaseViewSize, but that just can adjust the size of  current view editor.
And when focus on termianl, It will can't adjust the size between view editor and terminal.

@unihon in insiders (and the upcoming version of vscode) will resize the panel when using resize up/down

@Tyriar  Good!


Add effect to disable an input.

It is very much like the 'hide' effect written above it.

Thank you!


Add support for Python 3.5

Please add support for Python 3.5.
The latest Python 3 from the Ubuntu 16.04 LTS repo is Python 3.5.2. This Ubuntu LTS still has 5 years of support :)

Let me look into it, off the top of my head I'm not sure if I did use any features that require Python 3.6

Upon further research... I am using the Python code formatter Black which has a requirement on Python 3.6. Given this requirement I will not be supporting Python 3.5. Sorry.


Confirmation message when submitting the form

Show confirmation message before submitting the form.
Here is the iphone look of the confirmation message:

LGTM. Merged.


Add support for custom per-volume uniforms

This PR adds:

support for adding custom per-volume uniforms
support for integer array uniform types (uniform1i, 2i,...)
support for Vector4f array type

Poke @tpietzsch :-)

Poke again @tpietzsch :-)

And one more poke for @tpietzsch :-) We'd really appreciate if this could be merged soonish 👍

Apologies I missed the July poke, please regard this as a double-poke then 🤣

@tpietzsch scenery needs this in order to stop forking. Let's work on it during this week's hackathon! :+1:

Yes 👍
This is one of the last things to do before I can release...

I kind of merged this via https://github.com/bigdataviewer/bigvolumeviewer-core/commit/9c6694235b6abbbd07745b53e53b6936a3437220
I reworked it heavily in https://github.com/bigdataviewer/bigvolumeviewer-core/commit/7434f7670be0572c40090aa7fcc0dcce564c3bbb though.
I removed the additionalSamplers and additionalUniforms HashMaps again, because the Uniform* classes already represent a layer of caching that defers the "actual setting" via the GpuContext to  later.
The logic to decide by type of the Object value argument what uniform type to set moved to SegmentedShader.
Everything should now done by just MultiVolumeShaderMip.setUniform(...).
The methods
	public void registerCustomSampler( int index, String name, Texture texture )
	public void setCustomUniformForVolume( int index, String name, Object value )
	public void removeCustomUniformForVolume( int index, String name )
	public void setCustomIntArrayUniformForVolume( int index, String name, final int elementSize, final int[] value )
	public void setCustomFloatArrayUniformForVolume( int index, String name, final int elementSize, final float[] value )

I left in as @Deprecated, but will remove in the next release. I hope that makes it easier to first migrate scenery to the changed package names, and then -- if everything works -- replace the deprecated methods.
The only thing that is not covered is removeCustomUniformForVolume
I could add that if it is still needed. But I don't really understand why it would be useful. Either the uniform exists in the program or not, so if it is removed (instead of just overridden), wouldn't that mean that the program doesn't work anymore???


[DEMO] Modals css exemples not working on FF

Modals (Examples with CSS frameworks) not working with Firefox on https://biig-io.github.io/ngx-smart-modal/

Thank you for reporting this @athos7933! 👍


Implement scheduler basic functionality

Design scheduler that passes all unit tests

The first part of this project is to create an algorithm that solves all of the test cases that were provided to us, which is what this PR is for. The next part is to create more tests and to add more to the initial functionality, and this is what I am currently working on.

The first part of this project is to create an algorithm that solves all of the test cases that were provided to us, which is what this PR is for. The next part is to create more tests and to add more to the initial functionality, and this is what I am currently working on.

Starting from this project, I would like to see all new code come together with the detailed tests, which should be in the same pull request. I think the tutorial also implicitly indicates this: the step of sending PR comes after writing more tests
https://github.com/panerorenn9541/step/blob/master/walkthroughs/week-5-tdd/project/calendar-walkthrough.md#pull-request

The first part of this project is to create an algorithm that solves all of the test cases that were provided to us, which is what this PR is for. The next part is to create more tests and to add more to the initial functionality, and this is what I am currently working on.

Starting from this project, I would like to see all new code come together with the detailed tests, which should be in the same pull request. I think the tutorial also implicitly indicates this: the step of sending PR comes after writing more tests
https://github.com/panerorenn9541/step/blob/master/walkthroughs/week-5-tdd/project/calendar-walkthrough.md#pull-request


Fix: [WIP] update transaction controllers to use selected account

Explanation

References

Changelog

@metamask/package-a

: Your change here
: Your change here

@metamask/package-b

: Your change here
: Your change here

Checklist

[ ] I've updated the test suite for new or updated code as appropriate
[ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate

@metamaskbot publish-preview


BUG:  2_apply_layout.sh overrides wallpaper

The script 1_apply_themes.sh works perfectly, but if the second script 2_apply_layout.sh runs it changes the wallpaper to the default.
My config:
workspace = {
      clickItemTo = "select";
      theme = "default";
      colorScheme = "CatppuccinMochaTeal";
      cursorTheme = "Catppuccin-Latte-Teal-Cursors";
      wallpaper = /etc/wallpaper/catppuccin-mocha.jpg;
    };

Quite sure this happens due to the screen-specification of the panels needing to restart kwin. We can probably fix it by setting the wallpaper after creating the panels though. I'll see if that helps anyway.

It worked. Should be fixed by #118. If the issue persists feel free to reopen.


Nothing happens on open from github

Maybe I am confused on how this is supposed to work, but when I click open, github, navigate to the file, it shows up to the right of the menu, but is not loaded in the json editor window and does not show up on the map. I can copy/paste the same file into the editor window, edit it and save it back to github without issues. I am looking for a way to host and edit simple map files, and have multiple contributors, and this seems like a cool way to do that, too bad it does not work.

This actually may have been due to a bug introduced in a recent commit.  For some reason the fileUrl for GitHub files from repos was incorrectly modified: https://github.com/mapbox/geojson.io/blob/gh-pages/src/source/github.js#L117-L130

Should be fixed by https://github.com/mapbox/geojson.io/pull/401