Delay Command Kills Robot Run

Using a 'delay' command in a protocol causes the protocol run to stop and not recover.
Expected Behavior

Robot should delay for specified amount of time and then continue running

Observed Behavior

Robot delays for specified about of time, begins next action (?), and then stops

Steps to Recreate

Connect to robot young-moon (science bot)
Load a protocol with 'p300.delay(seconds=60)'
-- Tested with protocol copied below
Run protocol
Observe robot pause for appropriate amount of time at delay step, make an additional movement (possibly beginning of next aspirate?) and then stop
Remove delay from protocol
Run protocol and observe that it runs fine
Note: also observed with 'robot.pause('')'

Worked on this a little bit with Kinnary. It looks like this may have been a power-supply issue. Leaving the ticket open for now, but may not be a software bug


Add support to override "composed-task-arguments" for a particular child in the graph

As a user, with multiple child tasks in the graph, when using the composed-task-arguments property, the override is passed to all the children. I'd like to pass only to a particular child instead. Specifically, if I want to launch "same" task a few times, but the only one of many launches should receive the override, this enhancement is required then.
Definition:
task create foo --definition “tb1: timestamp-batch && tb2: timestamp-batch && t1: timestamp”

Today:
task launch  --arguments “--composedTaskArguments=--timestamp.format=YYYYMMDD”

This passes --timestamp.format=YYYYMMD to all the 3 children in the graph (i.e., tb1, tb2, and t1).
If I have to override only for tb2, it might be nice to have an option to pass it as:
task launch  --arguments “--composedTaskArguments=--tb2.timestamp.format=YYYYMMDD”

Maybe even a different top-level property in CTR could be useful to solution it.

Moved to https://github.com/spring-cloud/spring-cloud-dataflow/issues/3919


Add example to README

It took me a while to realise how to import this library as NativeSettings export wasn't documented and I had to read through the source.
An example:
import { NativeSettings } from 'capacitor-native-settings'

NativeSettings.openIOS({ option: 'app' })

or

NativeSettings.openAndroid({ option: 'application' })

It has already changed
This is the updated usage:
    NativeSettings.openAndroid({
      option: AndroidSettings.ApplicationDetails,
    });


DateComponents: Support LocalDate

An app that I was working on used LocalDate for most date operations. Converting from LocalDate to Date to use this library caused the times to come out wrong. This PR aims to allow you to construct a DateComponents object using LocalDate

jazakumAllah khairan for this, but would rather avoid this for now because Android devs who use this without enabling core library desugaring will get unexpected crashes at runtime.
will push a branch in the near future though that will use LocalDate primarily since it will be in KMP, but that will be a parallel version to this version of adhan.


Investigate and optimize slow Windows CodeQL runs

Windows CodeQL runs take almost 10x longer than the Linux variant and are the biggest chunk of CI time by far.
Why? Can this be improved?

Yeah CodeQL is taking up so much time for execution in windows, I went through the workflow. These are the things, I found.
The hotspot for this entire workflow is the step Autobuild. This step executes the yaml file of codeql-action/autobuild, and this is trying to build the code automatically. And below is the breakdown of the time taken for parts of autobuild step.
Linux Execution Autobuild (6m 33sec)      |  Windows Execution Autobuild (56m 29sec)
-------------------------------------------------------------------------------------
First Package (download modules)          |  First Package (download modules)
                                          |
2024/03/31 15:05:52                       |  2024/03/31 15:06:36
2024/03/31 15:06:07                       |  2024/03/31 15:12:48
                                          |
Time Taken: 00:00:15                      |  Time Taken: 00:06:12
                                          |
---                                       |  ---
Running Extractor command                 |  Running Extractor command
                                          |
2024/03/31 15:06:12                       |  2024/03/31 15:12:56
2024/03/31 15:12:10                       |  2024/03/31 16:00:36
                                          |
Time Taken: 00:05:58                      |  Time Taken: 00:47:40
                                          |
---                                       |  ---
Second Package (download modules)         |  Second Package (download modules)
                                          |
2024/03/31 15:12:10                       |  2024/03/31 16:00:36
2024/03/31 15:12:22                       |  2024/03/31 16:02:55
                                          |
Time Taken: 00:00:12                      |  Time Taken: 00:02:19

I hope this helps anyone, who will be picking up this issue.
Thanks :)

Thanks for looking in to this @4rivappa 🙂
I guess the next step is for someone to figure out why Windows Extractor is taking so long

I had an idea to make Windows CodeQL faster - don't run it on Windows.
I set GOOS=windows but run the Job on an Ubuntu runner.
Is it faster? Yes.
Does it actually analyze Windows? I'm not sure.
Here's the link to the CodeQL run.
I'm encouraged that it says it scanned a different number of files, but the math still doesn't add up to the number of files on either platform that I would expect.

I would love to hear from a CodeQL expert (or anyone willing to investigate this further) but in the meantime I think #212 may resolve this


Test VIM improvements

Testing https://github.com/VSCodeVim/Vim/issues/1706
Complexity 2

[ ] AnyOS @jrieken

@rebornix Can you add a test description or close the test item if nothing needs to be tested here?

@aeschli Vim guys already helped tested and verified those items. Thanks for your help.


Update some dependency

Does this fix #133 ?

Nope. on my end i could not update the version of clap without some bugs. I just update the rest of dependency.

Closing this, if there's no specific goal I prefer not to update dependencies at the moment, since I won't spend time verifying they aren't introducing some undesired side-effect.


wip: switch to rest-API

I started moving from XML-RPC to the REST-API.
This work has only just started and is far from finished, expect a lot of bugs and unimplemented features.
It gives us the opportunity to rethink what this package can and should provide.

a complete set of commands to interoperate with an existdb instance
or just a tool to sync files from OS to db and back

superseded by #243


When sidebar open cannot access right-most cards

Added inline width style to mainContent calculated using sidebar width


Develop

What does this PR do?

Code review by Omedale

Description of Task to be completed?
Code review by omedela
How should this be manually tested?

none

Any background context you want to provide?

none

What are the relevant pivotal tracker stories?

none

Screenshots (if appropriate)

none

Questions:

Changes Unknown when pulling 635903a8074434725c38b514771efe7ef8719f72 on develop into ** on code-review-omedale**.


Adds C Modules to the Runtime Modules page in the web UI

Adds the C Modules to the web UI's Runtime Modules page:

While putting this together, I realized that the RPCs from the rust nakama example project aren't actually being registered. I'm not sure what the root issue with that is, but I'm going to look into that next.
@attackgoat I guess we haven't discussed expectations around merge/commit hygiene yet, but I figured I'd do a self review later with fresh eyes before merging this, that way stuff is still being reviewed without me making extra obligations for ya 😅 If you'd prefer to review stuff before merging, that's totally alright too- just let me know 👍

Force pushed to clean up the commit message. 5:30am brain isn't so good with grammar lol


Add scripts to ease experimenting with barebone production install.

$(this) should ease an unspecified amount of provision suffering to some. Based on several scripts written in @galexrt's #450, repurposed for $(this).

[ ] need testing

Automated message from Dropbox CLA bot
@rht, it looks like you've already signed the Dropbox CLA. Thanks!

@rht When should the tools/run-prod-barebone be used?

This is ./tools/run-prod-barebone, shorter than ./tools/provision && ./tools/run-dev.py.
This shouldn't be documented first until the default values for the build option tree has been figured out.
Defaults should be there much like C structs do have defaults.

Should I remove the scripts/setup/configure-certs from the PR #450?

@galexrt hmm I have had the use case of #5611 in mind for a while, though it was just not serialized to words yet. As stated, some improvements don't get merged because testing them often takes a while.
I think it is a contingent event -- you can remove scripts/setup/configure-certs only if the commit in this PR is merged.

I add your comment to the chat so we can later easily access it.

@rht posted a few comments on the certs piece.  I think once those are resolved we can merge that script and start building off of it.

@timabbott I have resolved the self-signed commit one. I have also added a password argument to manage.py commit -- if merged, will help us in simplifying the Docker entrypoint (and also its spin-off script in this PR).

Cool.  I merged create_user and posted one comment on configure-certs; I think once that's resolved, we can merge that too.

Great!  I merged the first commit as c961ca023cb6e330b3bc689514980065f0a52f7d (note the rename of the script to better match the project's naming scheme).  Thanks for working on this @rht!  @galexrt FYI.

@feorlen, @hackerkid, @derAnfaenger I made this script so that testing a production install can be automated. What do you think about it?

For 1.8, 1.9, ...

I think this script isn't super helpful; most changes we make to production install are either things we'll want to test manually or will be caught by the existing Travis test that does one.
We should instead invest in making the --certbot option work.

@timabbott this is to make production easier to debug. I have developers in mind as the audience to this script rather than users running on intranet.

To put it simply, so that prod envs can be tested more easily.


does returning an error in a unit test not cause the tests to fail?

The stats unit tests were passing on microns even though the stats service wasn't setup... so, obviously, that was a problem! I did some digging and discovered that the following block was resulting in a pass:
    try:
      # Build a get request
      req = urllib2.Request(url)
      response = urllib2.urlopen(req)
    except urllib2.HTTPError,e:
      return e

Changing to an explicit assert in except causes the test to fail:
    try:
      # Build a get request
      req = urllib2.Request(url)
      response = urllib2.urlopen(req)
    except urllib2.HTTPError,e:
      print e
      assert(0)

Which totally makes sense. What doesn't make sense is why the test still passed, even though response, etc were not even defined.
@kunallillaney @randalburns any thoughts?

Fixed in stats. Not sure about other tests, but closing for now.


Add Typing Speed Checker Game

Fixes
#279

Description

Added Typing Speed Checker Game
Type of change

[x] New project (non-breaking change which adds functionality)

How Has This Been Tested?
The program has been tested multiple times on various browsers and is working fine.

Tech Stack used:

HTML, CSS, JS
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have included a README.md file
[x] My project follows this structure: Domain Folder/ Project Name Folder/ Project files and Readme.md files
[x] I am a GSSoC'22 Participant

Please check it @TrickSumo

Please check it @advaita-saha

Kindly assign labels

If there is any change to be done do remind me

@TG922 Any update?


[servingsys]  Remove exctractor

[x] I've verified and I assure that I'm running youtube-dl 2018.01.14

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[x] Other

It's malware domain without any videos only with links to sizmek.com and it's down.
I can't even insert link to it, github doesn't show it.

@dstftw Please review.


Packaging

Checks for coverage of testing.
Includes packaging setup config

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8b393ae). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master      #5   +/-   ##
========================================
  Coverage          ?   91.3%
========================================
  Files             ?       1
  Lines             ?      92
  Branches          ?       0
========================================
  Hits              ?      84
  Misses            ?       8
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b393ae...29c46f1. Read the comment docs.


UI refactor

The UI for the utilities is functional, but could be more intuitive and look better. There's also opportunity to extract reusable layout components.

Covered by https://github.com/JStruk/UtilsNinja/issues/37


Google Auth error

I'm not too sure what's going on. I've installed a fresh copy and moved to a server in my country to prevent being blocked by snapchat. Is anyone familiar with what I might be doing wrong?
REQUEST TO: https://feelinsonice-hrd.appspot.com/loq/device_id

Sent Request info: POST /loq/device_id HTTP/1.1
User-Agent: Snapchat/<IP_ADDRESS> (HTC One; Android 4.4.2#302626.7#19; gzip)
Host: feelinsonice-hrd.appspot.com
Accept: */*
Accept-Language: en
Accept-Locale: en_US
X-Snapchat-Client-Auth-Token: Bearer
Content-Length: 98
Content-Type: application/x-www-form-urlencoded

DATA: timestamp=1442573747768&req_token=9309bb530f3131486e2214edf4a7a70419e34d85                                                                                19b22a8ef9b45b14d1c5189b
RESULT: {"dtoken1i":"00001:BSFztJpyTMqmt7bOS4NagGXKnHDG97PzTFVtekeoQ24Sw/mRzDSDW                                                                                QlV8z+VMjq+","dtoken1v":"PUm6CsssCWBSJ6D5UzNvmIRD4CspJzFUL3w/kqD8pd8\u003d"}

REQUEST TO: https://android.clients.google.com/auth
Array
(
    [device_country] => us
    [operatorCountry] => us
    [lang] => en_US
    [sdk_version] => 19
    [google_play_services_version] => 7097038
    [accountType] => HOSTED_OR_GOOGLE
    [Email] =><EMAIL_ADDRESS>    [service] => audience:server:client_id:694893979329-l59f3phl42et9clpoo296d8r                                                                                aqoljl6p.apps.googleusercontent.com
    [source] => android
    [androidId] => 378c184c6070c26c
    [app] => com.snapchat.android
    [client_sig] => 49f6badb81d89a9e38d65de76f09355071bd67e7
    [callerPkg] => com.snapchat.android
    [callerSig] => 49f6badb81d89a9e38d65de76f09355071bd67e7
    [EncryptedPasswd] => AFcb4KSBQwp04Nv-RVSY2mPrlkgoX1KT2qORT9kGibdGUgt27wETUOp                                                                                oLiZzJzFuonOJycgIY-6kDpQp3AyBB8WnaktJut2gUiZrT5CwGc_eg6hf8nWvfM6IzCz85u2-bdB_Z8k                                                                                4OtBVka0zBlepIc0SqWJCb9eDKcfbqrUdfqohzhTUYg==
)
DATA: 1
RESULT: Auth=eyJhbGciOiJSUzI1NiIsImtpZCI6IjZjYjUxZWZkZDQzNTJjNWRmMGFhOWYzZDNkZTN                                                                                hMzg1M2Y2YjMzMzIifQ.eyJpc3MiOiJhY2NvdW50cy5nb29nbGUuY29tIiwiYXVkIjoiNjk0ODkzOTc5                                                                                MzI5LWw1OWYzcGhsNDJldDljbHBvbzI5NmQ4cmFxb2xqbDZwLmFwcHMuZ29vZ2xldXNlcmNvbnRlbnQu                                                                                Y29tIiwic3ViIjoiMTA2NTQyNDY0OTM0MTQ0NDUyNDE3IiwiZW1haWxfdmVyaWZpZWQiOnRydWUsImF6                                                                                cCI6IjY5NDg5Mzk3OTMyOS1xZzBpMHU4OHQwaG04azZrMW1icmJuc3VqMTAxaDczdi5hcHBzLmdvb2ds                                                                                ZXVzZXJjb250ZW50LmNvbSIsImVtYWlsIjoic2luZ2VyaGFsbGJvdEBnbWFpbC5jb20iLCJpYXQiOjE0                                                                                NDI1NzM3NDgsImV4cCI6MTQ0MjU3NzM0OH0.MLeRN_6JwRau1vof4W7f9LzwCnEf5iAxa8JC78S_rezf                                                                                Pk1qOP2S6EN14D9E_wHHc60LI8BVtORQ5fNZhlQlB8_6KGku_JEK75vWoUZEA8GPOZ6goQPd-vq-He-H                                                                                8AHD_PVco6AWIpW8VPXW_M8HdggSKlKnDh9rvXkTfhjyyLI5rsL2iUIa_P0jx60xmy1rtwAZcytUowXN                                                                                rff04rsQlkISnNf19fSoh-HVJDb_5Evu3y2OjwlDABDPV2PRtBDbeCha1s26n2HsR4m6gTz-GcAPhhsu                                                                                gxoDsYt77XzjUpgEeaU4Hw_llqhclVy1rKtUrFz9cWJMUmAVoPiDNdGEcA
issueAdvice=auto
Expiry=1442577348
storeConsentRemotely=1

There is a bug in Casper's gateway, it works, but you will need to try to login many times. For example, i tried 10 times til i succeed.

Yeah, sorry. I'm in the process of testing some changes to the internal code, because the internal bytes I've been using don't work properly anymore.
I've implemented some GPU code, which appears to have fixed the issue in Casper, and am still in the process of testing this on the servers.
Once I see it works properly, I'll push it to the live servers, and logins will work for you again.
Until then, there's not much any of you can do sorry.

As long as it works that's fine :) Thanks for the help guys!
I just tried again and got this crazy error, I'll set a crontab up to try every 5 minutes.
(
    [message] => Oh no! Your login temporarily failed, so please try again later. If your login continues to fail, please visit https://support.snapchat.com/a/failed-login :)
    [status] => -103
    [logged] =>

Yeah, that issue is caused by receiving an invalid attestation value from the Google servers.
The invalid attestation is caused by the internal byte arrays being wrong in my system.
I'll hopefully have the fix out in an hour or so.
I wouldn't suggest setting a cron tab for every 5 minutes, as this will get your IP banned, by making too many failed logins.

All servers have been updated with the new code.
Let me know if that solves the attestation issue for you.
Cheers.

That's great Liam, i've just tested it and it works well. Just having a small problem where the users aren't being sent a message. Do you know how to save the images into a folder? I'm going to try get them to post to instagram too.
// Login
$tmpPath = '/tmp/';
$snapchat = new Snapchat($username, $gEmail, $gPasswd, $debug);
$snapchat->login($password);

if($addback == true)
{
    $unconfirmed = $snapchat->getUnconfirmedFriends();
    if (!is_null($unconfirmed))
  {
    print_r($unconfirmed);
    foreach($unconfirmed as $friend)
    $snapchat->addFriendBack($friend);
  }
}

$snaps = $snapchat->getSnaps();

if (!is_null($snaps))
{
    foreach($snaps as $snap)
    {
        echo "Processing SNAP ID [" . $snap->id . "]
";
        $snapchat->writeToFile('../src/snaps/' . $snap->id, $snapchat->getMedia($snap->id));
        $tmpFilePath = $tmpPath . $snap->id;
        file_put_contents($tmpFilePath, $snapchat->getMedia($snap->id));
        $snapchat->setStory($tmpFilePath, $snap->time);
        $snapchat->markSnapViewed($snap->id);
        unlink($tmpFilePath);
        $snapchat->sendMessage($snap->sender, "Your snap has been processed! Thank you for submitting & Please tell your friends!");
        echo "Processed!

";
    }
}

$snapchat->closeAppEvent();
?>

@HW73 read the wiki and example files

$Snapchat->getSnaps(true);

On 18/9/2015, at 9:43, mgp25<EMAIL_ADDRESS>wrote:
@HW73 read the wiki and example files
—
Reply to this email directly or view it on GitHub.

@mgp25 @LanchaBasualdo thanks guys, I had a look and tried it out but the bot stopped working once I added that line in. Do I need show it where to save the snaps to?

you can, but no. Post your code, and debug.

On 18/9/2015, at 11:02, HW73<EMAIL_ADDRESS>wrote:
@mgp25 https://github.com/mgp25 @LanchaBasualdo https://github.com/LanchaBasualdo thanks guys, I had a look and tried it out but the bot stopped working once I added that line in. Do I need show it where to save the snaps to?
—
Reply to this email directly or view it on GitHub https://github.com/mgp25/SC-API/issues/207#issuecomment-141459202.

Pilo Basualdo

I'm quite the noob when it comes to those things. I can't find any way to get the debug code, could you point me in the right direction please?

Don't publish issues if you lack abilities, joel and mgp will get angry. Send me an email i'll show you. Never the less. Please read the wiki en the main page of this library, everything is explained there.
<EMAIL_ADDRESS>
On 18/9/2015, at 11:19, HW73<EMAIL_ADDRESS>wrote:
I'm quite the noob when it comes to those things. I can't find any way to get the debug code, could you point me in the right direction please?
—
Reply to this email directly or view it on GitHub.

Sorry guys, I've just dived in at the deep end trying to learn a few things. My email is<EMAIL_ADDRESS>thanks @LanchaBasualdo

@HW73 It's okay to learn things, we all have been begginners, but just because of that you need to read more.
The very first step is to read the whole wiki:https://github.com/mgp25/SC-API/wiki/Snap-API-Documentation
In the wiki you will find everything you need to know, and most of the things are explained. Once you know the theory you can go to the experimental part, so we prepared example files you can play with to test: https://github.com/mgp25/SC-API/tree/master/examples
If you have any other issue not tracked yet or not explained in the wiki its okay to ask, but not PHP questions, if you have questions about how to code something, the best thing you could do is google it or search it in PHP Manual: https://secure.php.net/manual/en/index.php
So this comment https://github.com/mgp25/SC-API/issues/207#issuecomment-141463717 could be answered just by reading the wiki: https://github.com/mgp25/SC-API/wiki/Snap-API-Documentation#logging-in
Regards

@liamcottle @mgp25  are we still down or am I the only one with the attestation issue?

Attestation API should be working now. I just tested the PHP lib myself, and had to delete my src/authData/auth-*.dat file for Login to work.


[Feature request] optimum upgrade and enable GPU device selection for optimum in huggingface MLServer

Hi there,
We're recently working on the ONNX model with GPU in huggingface MLServer. We want to raise below 3 request for huggingface MLServer:

Enable onnx model loading as I mentioned in this issue (https://github.com/SeldonIO/MLServer/issues/852)
We also want to enable GPU inferencing on ONNX model too. I checked the issue mentioned in the  comments and it seems they already provided fix for the issue. Could we resume to enable the GPU device for ONNX model?
We also noticed that current optimum version is low. As optimum released 1.5.0 which contains the IO binding enhancement that fix the low performance issue on GPU for ONNX model. We are requesting its upgrade to leverage this enhancement to avoid huge performance slowdown on optimum compared to transformers based on our test.

Thanks! Looking forward to your reply:)

Hey @bugzyz,
Massive thanks for taking the time to try ONNX models in the Huggingface runtime :+1:
This feedback is really useful. I think all three points make a lot of sense, so hopefully we can address them in the next version :+1:

@adriangonz Thank you for your supports! 😄
Btw, do you have the ETA for these features to be released or available on dev?

Hey @bugzyz ,
No ETA, but you can see the roadmap for the next 1.3.0 version in the link below:
https://github.com/SeldonIO/MLServer/projects/6?query=is%3Aopen+sort%3Aupdated-desc


Test manual watcher in vuex store

Subject of the issue
Hello, we've encountered an unexpected error in one of our route guard tests which tests the store's watchers.
The test adds a manual watcher using store.watch() and subsequently verifies that the watcher has been added to store?._watcherVM?._watchers.
When using vue 2.6.14 and vue-template-compiler 2.6.14, the test runs flawlessly.
The test fails when using vue 2.7.8 and vue-template-compiler 2.7.8.
During runtime we could verify that the watcher is added correctly, so it only seems to be an issue inside the test.
Steps to reproduce
import Vuex, { Store } from 'vuex'

import { createLocalVue } from '@vue/test-utils'

const localVue = createLocalVue()
localVue.use(Vuex)

describe('my route guard', () => {
  it('should add a new watcher to store._watcherVM._watchers', () => {
    // Arrange
    const store: any = new Store({})
    const mockedTask = jest.fn()
    const mockedCallback = jest.fn()

    // Act
    const stopWatching = store.watch(
      (state, getters) => getters['getCurrentTask'],
      (newStoreValueValue) => {
        if (newStoreValueValue) {
          stopWatching()
          mockedCallback()
        }
      }
    )

    const storeWatchers: Array<any> = store?._watcherVM?._watchers
    storeWatchers[0].cb.call(this, mockedTask)

    // Assert
    expect(storeWatchers).toHaveLength(0) // Watcher was deregistered after execution
    expect(mockedCallback.mock.calls.length).toBe(1)
  })
})

Expected behaviour
The test should pass with vue 2.7.8 and vue-template-compiler 2.7.8
Actual behaviour
The test fails on 2.7.8, but works on 2.6.14
Possible Solution
We have not found a workaround yet

Forcing a watcher like that seems like a bad idea - as you said, it works perfectly in prod, so getting this test to pass isn't exactly meaningful - it's failing, despite the feature working correctly.
You are also accessing implementation details with _watcherVM - likely Vue changed something internally around reactivity, which is why your test broke. Can you not trigger the watch without forcing it via _watcherVM?
Also - is this even the right repo for this? I don't see Test Utils here, except for createLocalVue - and I'm guessing this is still a bug, even if you use the actual Vue and Vuex instance, as opposed to createLocalVue? I don't think there's anything we can change in this repo that will fix your test.

Heya, thanks for the swift response. Indeed the test also fails when removing createLocalVue.
However, I've investigated the store again and found out that _watcherVM itself has a _scope.effects property which contains the watchers. I assume you're correct that the Vue behaviour has changed here and that the watcher array is now in _scope.effects instead of _watchers.
Thanks again and have a sunny day!


fix(bar): Configure position before remapping

Some WMs like i3 discard position information when unmapping the bar and
because of that the bar would be at the wrong position after being
remapped.
Fixes #1484
Ref: https://github.com/i3/i3/pull/3834

I have now changed it to reconfigure the entire window (restacking, struts, wm hints, geometry) to be on the safe side. Please review again.

It is okay for me but maybe we should put the reconfigure_window in map_window_checked (and rename it) to avoid any problem if we add a map_window_checked somewhere.

I first started out doing this. But I couldn't come up with a situation where we would need to unmap and remap the bar, so I didn't put it in a function.


GG-7502: si-protected-user-list-admin-frontend: move entry ID from form to URL

test this please

test this please


ci: push latest docker image

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 5 committers have signed the CLA.:x: evenyag:x: v0y4g3r:x: zyy17:x: killme2008:x: waynexiaYou have signed the CLA already but the status is still pending? Let us recheck it.


Refactor | Remove Summary component from vaultsOverview feature

Remove Summary component and stories (should have been done as part of Positions Overview PR)

Closing this old PR. Please ping me for details if needed.


auth()->user() does not have methods in User model

Hi I have trouble with autocompleting methods in User model when I use auth()->user()
so I have a method foo in User model, and when I use auth()->user() to get the login user instance I do not have the foo method show up.
can some one tell me what congfig I need to do?

Got the same problem, without a solution so far.

I am using auth()->user() for checking permissions in combination with spatie/laravel-permissions. php artisan ide-helper:models tries to call a member function on null in my use case as well.

I am able to get this working if I edit
vendor/laravel/framework/src/Illuminate/Support/Facades/Auth.php
and delete line 9 in the docblock:
 * @method static \Illuminate\Contracts\Auth\Authenticatable|null user()
Then it pulls out the autocomplete information from the _ide_helper.php
Class Auth function user() that has a doc block that returns
\App\Models\User

@wisemanta  so you mean you changed the Laravel source code?

Wondering if anyone has a solution that doesn't involve editing a file in the vendor directory

I am using Auth::user() for now and it works with the autocompletion...
But I would like to use auth()->user()
Hope somebody come with a solution for that!

I've still the same issue... Thanks!

Can still see this problem as of Laravel 8.30.1. Both auth()->user() and Auth::user() do not show code-completion for User model properties and functions.
I'm using VSCode 1.56.2 and have already generated doc-blocks using IDE Helper package.

Any solutions ?

I have renamed User to PracticeUser in auth.php
On this statementUnderfined method on Auth->user()->relationMethod on user.
I have renamed User to PracticeUser in auth.php

I have same problem 'Undefined method'
I have renamed User model to PracticeUser in auth.php
Project uses Laravel 10.13.2 and Inertia/Vue3 1.0.7
Here is an abstraction of my code
inertia:render('myroute', [ 'list' => Auth:user() ->relationMethodOnPracticeUserModel()
The method relationMethodOnPracticeUserModel is flagged as Undefined Method.
I have verified that Auth:user() is an instance of PracticeUser
I have verified that the method  relationMethodOnPracticeUserModel is defined on the PracticeUser model.
Any Solutions?

I created a comment last week, but no reponse.
Auth::user()->method(), where method() names is the name of a relation
In Laravel Breeze project, Laravel version 101.3.2,

method() is flagged in VS Code as Undefined method.
No problem calling the relation method in Tinker on an instance of User model.
In a Laravel project, without Breeze,  Laravel version 9.46.0, method() in VS Code is not flagged as Undefined method.

Would appreciate some feedback.


Update 01_example_project.md

@lawwu please branch off the develop branch and create a PR to merge the changes into develop.

@lawwu Also, if you could make all those typo, grammar and wording fixes on one branch that would be lovely. And thanks for contributing!

@lawwu Make sure to check out our contributing guide.

I close this since PR #55 includes this one and follow guidelines. Thanks for contributing!


Directory was not included into executable at compilation stage

Trying to work with the oauth2orize package. Running into some problems specifically here.
Here's the full error output:
D:\snapshot\Code\temp\pkg-oauth2orize\node_modules\oauth2orize\lib\index.js:39
fs.readdirSync(__dirname + '/grant').forEach(function(filename) {
   ^

Error: Directory 'D:\Code\temp\pkg-oauth2orize\node_modules\oauth2orize\lib\grant' was not included into executable at compilation stage. Please recompile adding it as asset or script.
    at error_ENOENT (evalmachine.<anonymous>:0:0)
    at readdirFromSnapshot (evalmachine.<anonymous>:0:0)
    at Object.fs.readdirSync (evalmachine.<anonymous>:0:0)
    at Object.<anonymous> (D:\snapshot\Code\temp\pkg-oauth2orize\node_modules\oauth2orize\lib\index.js:39:4)
    at Module._compile (module.js:571:32)
    at Module._compile (evalmachine.<anonymous>:0:0)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)

I've tried adding every combination / variation of globs I could think of which would point to the node_modules/oauth2orize/lib/grant directory (windows slashes, recursive from a higher folder, full paths instead of relative, including the files inside that folder directly, grabbing the entirety of node_modules/**/*, etc), but I haven't found the right combination yet. Moving it out of node_modules and into a local libs folder didn't help, either (but I didn't really expect that to work).
Is my pkg property in package.json misconfigured, or is it something else?
Can reproduce by sending the following through pkg:
// package.json
{
  "name": "pkg-oauth2orize",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "dependencies": {
    "oauth2orize": "^1.8.0"
  },
  "pkg": {
    "scripts": [
      // obviously way too many entries here,
      // just wanted to show a few of the things i tried,
      // some as a group, some separately
      "node_modules/oauth2orize/**/*.js",
      "node_modules/oauth2orize/lib/grant",
      "node_modules/oauth2orize/lib/grant/",
      "node_modules/oauth2orize/lib/grant/*",
      "node_modules/oauth2orize/lib/grant/*.js",
      "node_modules/oauth2orize/lib/grant/**/*.js",
      "node_modules/oauth2orize/lib/grant/code.js",
      "node_modules/oauth2orize/lib/grant/token.js"
    ]
  }
}

// index.js
require('oauth2orize');

If I go in and re-write the oauth2orize code to do the following instead, it works fine (but I'd like to avoid this, if at all possible):
exports.grant = {};
exports.grant.__defineGetter__('code', function() {
  return require('./grant/code');
});
exports.grant.__defineGetter__('token', function() {
  return require('./grant/token');
});

// alias grants
exports.grant.authorizationCode = exports.grant.code;
exports.grant.implicit = exports.grant.token;

exports.exchange = {};

exports.exchange.__defineGetter__('authorizationCode', function() {
  return require('./exchange/authorizationCode');
});
exports.exchange.__defineGetter__('clientCredentials', function() {
  return require('./exchange/clientCredentials');
});
exports.exchange.__defineGetter__('password', function() {
  return require('./exchange/password');
});
exports.exchange.__defineGetter__('refreshToken', function() {
  return require('./exchange/refreshToken');
});

// alias exchanges
exports.exchange.code = exports.exchange.authorizationCode;

Have a sort of similar issue with cache-manager. This error message occurs at runtime after pkg completes with warnings:
Error: Cannot find module './stores/memory'

Stems from here, and works fine if I modify the code to just require('./stores/memory') directly instead of dynamically.
Can't seem to come up with the right blob to include the asset / scripts for this module either. Tried the following for both pkg.assets and pkg.scripts in package.json without any luck:
"node_modules/cache-manager/**/*.js",
"node_modules/cache-manager/lib/stores/memory.js"

Here's a quick example to reproduce:
// package.json
{
  "name": "pkg-cache-manager-test",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "dependencies": {
    "cache-manager": "^2.4.0"
  },
  "devDependencies": {
    "pkg": "^3.0.5"
  },
  "scripts": {
    "pkg": "pkg index.js"
  },
  "pkg": {
    "scripts": [
      "node_modules/cache-manager/**/*.js",
      "node_modules/cache-manager/lib/stores/memory.js"
    ]
  }
}

// index.js
const cacheManager = require('cache-manager');
const memoryCache = cacheManager.caching({
  store: 'memory',
});

Added support for oauth2orize. Please try again with<EMAIL_ADDRESS>

LGTM for oauth2orize, thanks for the work!
Still having problems with cache-manager, but that one is much simpler to solve than oauth2orize was, so this will save us some time.

Hi, can you add support for "cache-manager" as well, as it seems to be still an issue.

@igorklopov "cache-manager" is still an issue here.

Hi, I have a similar issue with node-windows. When I run .exe file I get "my personal address/node_modules/node-windows/bin/winsw/winsw.exe was not included into executable at compilation stage". I tried adding my .js file to a the .json file in as bin and the "windw.exe" address as pkg assets. But it didn't help.
the .js file under the name of "windowsServiceInstaller.js"
`
var Service = require('node-windows').Service;
// Create a new service object
var svc = new Service({
name:'tes',
description: 'tes',
script: 'C:\Users\Fakhreddin\OneDrive\Tart Scratch\Scratch for Expo\developer files\bundle\Deploy Files\bin\Tart Education Scratch\server_E.js'
});
// Listen for the "install" event, which indicates the
// process is available as a service.
svc.on('install',function(){
svc.start();
});
svc.install();
`
and my package.json
`
{
"name": "service_ins",
"version": "1.0.0",
"description": "",
"main": "windowsServiceInstaller.js",
"scripts": {
"test": "echo "Error: no test specified" && exit 1"
},
"author": "",
"license": "ISC",
"dependencies": {
"node-windows": "^0.1.14"
},
"pkg": {
"assets": "./node_modules/node-windows/bin/winsw/winsw.exe"
},
"bin": "windowsServiceInstaller.js"
}
`
I run "pkg ." in the directory where both .js and .json files and node_modules folder are present. But I get the mentioned error when I run the .exe. I also tried running it as administrator. The .js code runs perfectly with "node windowsServiceInstaller.js" in cmd.
Any suggestions will be really appreciated. Thanks.

the example in this repository (https://github.com/zeit/pkg/tree/master/examples/express), when pkg to a single executable also fails,
     Error: File or directory 'C:\**\repos\pkg\examples\express\views\index.html' was not included into executable at compilation stage. Please recompile adding it as asset or script.


update release-docs.yml to create a PR, when there's a new Changelog file

This PR fix failing release-docs pipeline, by pushing updated mkdocs.yml (with added reference to new Changelog file) to feature branch and opening a new PR to merge it directly into the master.

Looks quite nice, did you test it?

@MarioUhrik, yes, I did. If you want you can see the testing here


[NotifTemplates] Flashing when status changing

Chrome
/admin/notifications

@dawid-g fixed

verified as fixed.


Remove most deprecated APIs

Currently, we still need the diagnostics compatibility layer because swift-driver uses the TSC diagnostics engine.

@swift-ci please smoke test

nice 🥳

@swift-ci please smoke test

Looks like SourceKit-LSP may rely on some of the deprecated methods:
macosx/release/SKSwiftPMWorkspace.build/SwiftPMWorkspace.swift.o/Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/sourcekit-lsp/Sources/SKSwiftPMWorkspace/SwiftPMWorkspace.swift:110:18: error: value of type 'Workspace.Location' has no member 'workingDirectory'        location.workingDirectory = customWorkingDirectory        ~~~~~~~~ ^~~~~~~~~~~~~~~~/Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/sourcekit-lsp/Sources/SKSwiftPMWorkspace/SwiftPMWorkspace.swift:133:28: error: value of type 'Workspace.Location' has no member 'workingDirectory'        dataPath: location.workingDirectory.appending(component: triple.platformBuildPathComponent()),

https://github.com/apple/sourcekit-lsp/pull/643
@swift-ci please smoke test


Issue #6957  Fixed

Issue Reference
#6957

Customer-Orders-translation-fixed

@Nikitajoshi39
This is fixed, please find the screenshot Here


Add 6.1 kernel

Update kernels
Test Plan
CI

Oh, you got ahead of me, I wanted to squash these two commits 😞


Correct parameters for mercator projection

I've been trying to get this package working with 4 pinhole cameras at 90 degrees apart, each 0.5m from the center (facing outwards)
I've been running the cameras in a unity simulation and it seems no matter what parameters I reconfigure the mercator projection with, the image is never fully showing in rqt (always stretched or cut off at the edges).
I can supply a bagfile with the cam feed if anyone is interested in helping out.
Thanks in advance.

https://drive.google.com/file/d/1ouWeQ2I7ZdD4LgH45FcGlYIpF-THuDno/view?usp=sharing
for those interested in the bagfile (~1.2GB)

Your camera setup should work. Can you please also share your launch/config files so I can take a look?

I took a look at your bag file. Your camera setup does not follow ROS conventions. Your camera links have the x-axis pointing fowards. This is fine, but you need a second optical frame with Z axis pointing forwards. The camera info should reference the optical frame with Z-axis fowards in the header. Otherwise, the projection is wrong.

Thanks - I'll try it out

Worked great! thanks


Must pipe input or define at least one file.

But i do!
‰ js-beautify -i < s_c.js
Must pipe input or define at least one file.
<EMAIL_ADDRESS>
Javascript beautifier (http://jsbeautifier.org/)

Usage: jsbeautifier.py [options] <infile>

    <infile> can be "-", which means stdin.
    <outfile> defaults to stdout

Input options:

 -i,  --stdin                      Read input from stdin

when you cat s_c.js | js-beautify -i what happens?
Also try cat s_c.js | js-beautify

On Tue, Feb 14, 2017 at 09:25:11PM -0800, Liam Newman wrote:

when you cat s_c.js | js-beautify -i what happens?
Also try cat s_c.js | js-beautify

All the same.
--
()  ascii ribbon campaign - against html mail
/\  http://arc.pasp.de/   - against proprietary attachments

@l29ah
An idea on how these tests are working and your case isn't?
https://github.com/beautify-web/js-beautify/blob/master/python/jsbeautifier/tests/shell-smoke-test.sh#L95
I'm kind of at a loss.

The script needs node.js it seems :/

Er, nope, i just ran it in a wrong cwd.

Dunno what magic it does.
l29ahZl29ah-x201 ~ ‰ cat /tmp/s_c.js | wc -l
1
l29ahZl29ah-x201 ~ ‰ cat /tmp/s_c.js | js-beautify
Must pipe input or define at least one file.
<EMAIL_ADDRESS>
Javascript beautifier (http://jsbeautifier.org/)

Usage: jsbeautifier.py [options] <infile>

    <infile> can be "-", which means stdin.
    <outfile> defaults to stdout

Input options:

 -i,  --stdin                      Read input from stdin

Output options:

 -s,  --indent-size=NUMBER         Indentation size. (default 4).
 -c,  --indent-char=CHAR           Character to indent with. (default space).
 -e,  --eol=STRING                 Character(s) to use as line terminators.
                                   (default first newline in file, otherwise "\n")
 -t,  --indent-with-tabs           Indent with tabs, overrides -s and -c
 -d,  --disable-preserve-newlines  Do not preserve existing line breaks.
 -P,  --space-in-paren             Add padding spaces within paren, ie. f( a, b )
 -E,  --space-in-empty-paren       Add a single space inside empty paren, ie. f( )
 -j,  --jslint-happy               More jslint-compatible output
 -a,  --space_after_anon_function  Add a space before an anonymous function's parens, ie. function ()
 -b,  --brace-style=collapse       Brace style (collapse, expand, end-expand, none)(,preserve-inline)
 -k,  --keep-array-indentation     Keep array indentation.
 -r,  --replace                    Write output in-place, replacing input
 -o,  --outfile=FILE               Specify a file to output to (default stdout)
 -f,  --keep-function-indentation  Do not re-indent function bodies defined in var lines.
 -x,  --unescape-strings           Decode printable chars encoded in \xNN notation.
 -X,  --e4x                        Pass E4X xml literals through untouched
 -w,  --wrap-line-length                   Attempt to wrap line when it exceeds this length.
                                   NOTE: Line continues until next wrap point is found.
 -n, --end_with_newline            End output with newline
 --editorconfig                    Enable setting configuration from EditorConfig

Rarely needed options:

 --eval-code                       evaluate code if a JS interpreter is
                                   installed. May be useful with some obfuscated
                                   script but poses a potential security issue.

 -l,  --indent-level=NUMBER        Initial indentation level. (default 0).

 -h,  --help, --usage              Prints this help statement.
 -v, --version                     Show the version

l29ahZl29ah-x201 ~ ‰ cat - | js-beautify
asdgagege
asdgagege%                                                                                l29ahZl29ah-x201 ~ ‰ echo testy | js-beautify
testy%                                                                                l29ahZl29ah-x201 ~ ‰

strace'd it:
read(0, "!function(e){var t={};function n"..., 8192) = 8192
read(0, "is.opts.onProgressUpdate&&addEve"..., 8192) = 8192
read(0, ".split(\"_\");if(n&&n.length>1&&(t"..., 8192) = 8192
read(0, "ounce)),!isTouch&&n.formatHint&&"..., 8192) = 8192
write(2, "Must pipe input or define at lea"..., 45Must pipe input or define at least one file.

What version of python are you using?

On Wed, Feb 15, 2017 at 05:35:57PM -0800, Liam Newman wrote:

What version of python are you using?

Python 3.4.5
--
()  ascii ribbon campaign - against html mail
/\  http://arc.pasp.de/   - against proprietary attachments

@l29ah Are there any more updates on this issue?

I'm closing this issue for now.  Please comment if we should reopen

The behaviour is the same on 1.7.5.

Thanks for the response.  I still have no idea how this is happening.

Also having this problem on Node 9.0 when attempting to set a config file path via js-beautify --config ~/.jsbeautifyrc.

Okay... Well, here's the problem:
Here are the automated tests that get run with every build that are supposed to ensure this works.
Python: https://github.com/beautify-web/js-beautify/blob/master/python/jsbeautifier/tests/shell-test.sh#L94
Node: https://github.com/beautify-web/js-beautify/blob/master/js/test/shell-test.sh#L100
These get run by travisci and appveyor on multiple versions of python and node on linux and windows.  I run on MacOS, so there's quite a bit coverage.   None of them currently reports failure.
@nickkrein @l29ah
Any thoughts on what I've missed? Is this working in automation but not on your system or is it failing somehow and not reporting?
Really what I could use is for one of you to submit a PR with a script that reproduces this issue.

Seems like js-beautify just hates a certain file.
https://dump.bitcheese.net/files/vuvilin/s_c.js

As part of the output in 1.8.1 running on python 3.7:
'utf-8' codec can't decode bytes in position 6806-6807: invalid continuation byte

@nickkrein  Please open a separate bug - this particular issue is specific to python.


Consistent field names in reports

The most hated 'feature' in previous AdWords API was the inconsistency in field names in reports. For instance, if you request field CreativeQualityScore then the resulting report would have a field named adRelevance.
This sounds like a one-time nuisance, but when the API version got upgraded, and the upgrade docs stated for instance that CpcBid may now give a "--" result, then you had to go through your sources to look for maxCPC. And if a field was discontinued, you had to look in OLDER documentation what its result name would be. And so on.
Unfortunately Ads API seems to have the same problem. You ask for ad_group.name, and you get AdGroup.Name. Can't we use the exact same names? And also the same usage of uppercase and lowercase.
Note: Maybe it's not a problem in the library, but a problem in the API. In that case, can this bug be passed on?

Hi Zwitze,
This one is unfortunately a problem on the client library side itself, but one that is unlikely to get fixed. There are two parts to this issue.

In the Google Ads API, you can retrieve a field name by specifying its path in the class structure, as shown in the documentation or the proto buffer definition

e.g. To retrieve the domain_name field in the dynamic_search_ads_setting field of the campaign entity, you need to request campaign.dynamic_search_ads_setting.domain_name in your selector field. This same logic extends to reporting also.
E.g. in the GetKeywordStats code example, we request metrics.cost_micros field because the entity Metrics has a field by that name.
So in that sense, there's no more discrepancy in terms of selector name and column name. You get what you request. This should also address the magic values like "--". Since cost_micros is an Int64Value in proto buffer definition (which is mapped to a long? on the client library side), you either get a null, or an actual value in the reporting results.

As far as field names in the client libraries go, they are generated from the proto buffer definitions, in a way that matches the language's common naming conventions. C# uses PascalCase to match with Microsoft's conventions, where as protocol buffer fields are snake_cased. The code generator does the snake=>pascal conversion by capitalizing every letter after the underscore.

So, campaign.dynamic_search_ads_setting.domain_name in protocol buffer definition maps to DynamicSearchAdsSetting.DomainName property of a Campaign object.
This convention is baked into all the other Google APIs, and it is unlikely that we can break it. It will also make the external developers unhappy.
That still leaves the issue you raised, so I'm thinking of generating enums like in the existing client library so the end user won't have to worry about the naming style differences.
Pls chime in your thoughts.

If you consider generating different enums, do realize that you also have to update the documentation on Ads API. I don't think this will happen as other libraries may use the naming as seen in the current docs.
My point is that Ads API should use consistent naming AND use the same naming as used in its documentation.
Consistency with naming conventions of other parties is by far not as important.
You stated all Google libraries follow the same naming conventions.
I don't think this is the case, not all Google API libraries apply naming conventions of a language. For instance, recently I did a project in Python using Google DBM API - and note that Python is probably more strict on naming conventions, and tries to enforce snake_casing. Now, Python library oauth2client has a method "GoogleCredentials", doubleclickbidmanager service has a method "lineitems", etc. Those libraries have no problem leaving preferred Python naming conventions.
However, I do realize that sometimes naming conflicts can occur. In such cases I like the approach of existing AdWords API, in class Predicate. The API states this has a member "operator", but that exact name cannot be used in C# classes. So, in the library this member was renamed to "@operator". I like this workaround.

I did explore this further, however we decided to stick with the current naming style which is consistent with other Google GRPC APIs.


Cloning submodule dosen't work.

Hi,
I am trying to test the simulator but cannot clone the submodule.
E:\test_LVGL\lv_sim_codeblocks_win>git submodule update --init --recursive
Cloning into 'E:/test_LVGL/lv_sim_codeblocks_win/lvgl'...
error: RPC failed; curl 56 OpenSSL SSL_read: Connection was reset, errno 10054
error: 1542 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: index-pack failed
fatal: clone of 'https://github.com/lvgl/lvgl' into submodule path 'E:/test_LVGL/lv_sim_codeblocks_win/lvgl' failed
Failed to clone 'lvgl'. Retry scheduled
Cloning into 'E:/test_LVGL/lv_sim_codeblocks_win/lvgl'...
error: RPC failed; curl 56 OpenSSL SSL_read: Connection was reset, errno 10054
error: 3877 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: index-pack failed
fatal: clone of 'https://github.com/lvgl/lvgl' into submodule path 'E:/test_LVGL/lv_sim_codeblocks_win/lvgl' failed
Failed to clone 'lvgl' a second time, aborting
Do you have any solution or work around?

I am sorry,
after many retries, now it works.
Sorry.


drivers: eth: gmac: Fix cache support for SAM GMAC

What needs to be done for the cache to work properly:

Make sure cache operations are aligned to 32B
Make sure to clean and invalidate the operations on gmac descriptors
(thus all the helper functions)

This commit is needed for SAM GMAC to work when caches are enabled and
MPU mapping is changed to cacheable (See #8185)
Signed-off-by: Tomasz Gorochowik<EMAIL_ADDRESS>

Codecov Report

Merging #8282 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8282      +/-   ##
==========================================
- Coverage   64.54%   64.53%   -0.01%
==========================================
  Files         420      420
  Lines       40117    40117
  Branches     6762     6762
==========================================
- Hits        25892    25891       -1
  Misses      11108    11108
- Partials     3117     3118       +1

Impacted Files
Coverage Δ

boards/posix/native_posix/timer_model.c
98.21% <0%> (-1.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9042c...9421ac3. Read the comment docs.

While working on Zephyr with this patch and the MPU/caches patches applied I noticed that I am getting a MPU FAULT every now and then. I've found out that forcing the gmac descriptors to be aligned to 32B (same as the caches) seems to fix this problem, so I just updated this PR with this change.


Zero-phase filtfilt distortion of weighting filter frequency response?

Great library!
In signal.weigh there is the zero-phase option that uses scipy.signal.filtfilt.
To inspect the frequency response of the zero-phase (forwards-backwards operation) filter Hzp, it is necessary to calculate the frequency response of the forwards filter H (using scipy.signal.freqz), and then multiply it by the complex conjugate H*. Doing this shows that the forwards-backwards operation (ie applying the filter two times to the signal) distorts the overall frequency response Hzp, which in many cases will not give the desired response. In this case, zero-phase operation pushes the filter response outside the relevant IEC acceptance limits.
To avoid this distortion it would be necessary to pre-warp the filter frequencies (in a similar way to compensating for bilinear transform distortion), although I'm unaware of any way to determine the appropriate pre-warping analytically for arbitrary filter responses.

That's interesting. For my application I never bothered with validating the high-frequency response because my signal of interest was typically below 4 to 8 kHz.

Unfortunately the filtfilt distortion is limited to the high frequency range - it affects the entire frequency response, and is a result of applying the filter twice, once forwards, once backwards. This is a separate problem to the issue I raised in relation to the bilinear transform distortion, which affects mainly the high frequencies. To demonstrate both problems, see the figures below. The first one compares the frequency response obtained using a one-way filter (lfilter) with that using a zero-phase forwards-backwards filter (filtfilt), against the IEC 61672-1 acceptance limits, when pre-warping for bilinear transform distortion has not been applied (ie representing the code currently in your library):

This comparison shows that the frequency response using filtfilt is considerably outside the IEC limits (whereas the lfilter response is inside, although the roll-off at higher frequencies is faster than the IEC ideal curve).
The next figure shows exactly the same comparison, but this time with pre-warping to compensate for bilinear transform distortion, but no compensation for the filtfilt distortion (as I don't currently know one would achieve this!):

From this second figure you can see that the effect of compensating for the bilinear transform distortion is to slightly improve the higher frequency response roll-off, but there is negligible effect elsewhere in the response.
In either case (ie with or without bilinear distortion pre-warping compensation), the frequency response obtained using filtfilt is way outside the IEC acceptance limits because the zero-phase filter applies the filter twice, which drastically exaggerates the overall response.

@mlotinga
I know it's been a while but I'm looking into this at the moment as well and can't reproduce your figures. Could you share your code to produce the figures?


Update hid-architecture.md

Add some links.
Remove duplicated and outdated info.

@DJm00n thanks for the update!
@barrygolden can you please merge?

Merged per request


Add refresh ability to user tokens, and expose tokens for storage

This changes the API by adding an extra (optional) client secret field.
I also make some fields pub so that an application can retrieve them post-refresh and store them for the next run.

I can't seem to get the output of my cargo fmt to match what these tests require, sorry!

wierd, could be a rustfmt.toml file somewhere in a subfolder

looks like a fix in rustfmt https://github.com/rust-lang/rustfmt/pull/4557

thanks!
bors r+

bors r+


Add support for setting baud rate

Pull the baud rate from Netbox and use this in the OpenGear configuration. Defaults to 115200 baud if not specified, which was the previous default.
Also some minor autoformatter changes.

Only did this as a PR because for some reason I don't have commit on the target repo


Add benchmark data to README

It would be great to include high-level benchmark data in the README (cost and throughput).

From https://skyplane.org/en/latest/benchmark.html#

@parasj can we close this?


Make WithRouterProps accept the type of the query

This PR is part of #7797, it allows to define the type of QueryString.
This PR only extends the type, the Query type is optional, if given it extends the type if not, it works the same.
Without type

With type

@felixmosh Can you add tests for the new types in test/integration/typescript 🙏 . I'm still not too sure about how is this useful 🤔

For some reason bundle size increased quite a bit.

Bundle size increased quite a bit for a types change, we don't want to increase bundle size for a change like this.

I'm not sure how this PR increases bundle size, can you help?
The only thing that I've think that may affect this is re-exporting of WithRouterProps but I'm not sure how this related to bundle size.

Yeah I'm pretty sure it's related to the re-export. The reason for that is that types are stripped but this is just an export

Yeah I'm pretty sure it's related to the re-export. The reason for that is that types are stripped but this is just an export

But there was an import to that file, I've just added a specific import of a type to it :\

Ping, any updates?

Hi @felixmosh I'm still not sure if it's worthed to increase the build size for this, I don't like the test added here, it feels too complicated, I would prefer to do const query = router.query as { page: string } instead. Let me know what you think, cc @Timer

Where do u see bundle size increase? It is only type change 😔
Any way my PR is just alignment of those type with the community one.

Where do u see bundle size increase? It is only type change 😔

You can see it here:
https://github.com/zeit/next.js/pull/7922#issuecomment-515757497
Diff is included

I really want this ability, what I can do ?

Stats from current PR

Click to expand stats ⚠ Total Bundle Size Increase ⚠

zeit/next.js canary
felixmosh/next.js WithRouter-with-query-type
Change

Build Duration
22.2s
21.4s
-746ms

node_modules Size
43.6 MB
43.6 MB
⚠  +304 B

Total Bundle (main, webpack, commons) Size
207 kB
207 kB
⚠  +54 B

Total Bundle (main, webpack, commons) gzip Size
68.1 kB
68.1 kB
⚠  +16 B

Total Bundle (main, webpack, commons) Modern Size
181 kB
182 kB
⚠  +54 B

Total Bundle (main, webpack, commons) Modern gzip Size
59.9 kB
59.9 kB
⚠  +12 B

Client _app Size
2.39 kB
2.39 kB
✓

Client _app gzip Size
1.08 kB
1.08 kB
-1 B

Client _app Modern Size
1.83 kB
1.83 kB
✓

Client _app gzip Modern Size
890 B
890 B
✓

Client _error Size
8.22 kB
8.22 kB
✓

Client _error gzip Size
3.16 kB
3.16 kB
✓

Client _error Modern Size
5.85 kB
5.85 kB
✓

Client _error gzip Modern Size
2.33 kB
2.33 kB
✓

Client pages/index Size
343 B
343 B
✓

Client pages/index gzip Size
246 B
246 B
✓

Client pages/index Modern Size
319 B
319 B
✓

Client pages/index gzip Modern Size
254 B
254 B
✓

Client pages/link Size
4.08 kB
4.08 kB
✓

Client pages/link gzip Size
1.8 kB
1.8 kB
✓

Client pages/link Modern Size
3.7 kB
3.7 kB
✓

Client pages/link gzip Modern Size
1.7 kB
1.7 kB
✓

Client pages/routerDirect Size
423 B
423 B
✓

Client pages/routerDirect gzip Size
306 B
306 B
✓

Client pages/routerDirect Modern Size
411 B
411 B
✓

Client pages/routerDirect gzip Modern Size
314 B
314 B
✓

Client pages/withRouter Size
435 B
435 B
✓

Client pages/withRouter gzip Size
301 B
300 B
-1 B

Client pages/withRouter Modern Size
423 B
423 B
✓

Client pages/withRouter gzip Modern Size
309 B
309 B
✓

Client main Size
15.8 kB
15.8 kB
✓

Client main gzip Size
5.46 kB
5.46 kB
⚠  +2 B

Client main Modern Size
12.8 kB
12.8 kB
✓

Client main Modern gzip Size
4.83 kB
4.83 kB
✓

Client commons Size
188 kB
188 kB
⚠  +54 B

Client commons gzip Size
61.3 kB
61.3 kB
⚠  +15 B

Client commons Modern Size
169 kB
169 kB
⚠  +54 B

Client commons Modern gzip Size
55.1 kB
55.1 kB
⚠  +12 B

Client webpack Size
1.53 kB
1.53 kB
✓

Client webpack gzip Size
778 B
778 B
✓

Client webpack Modern Size
1.53 kB
1.53 kB
✓

Client webpack Modern gzip Size
785 B
785 B
✓

Base Rendered Size
2.76 kB
2.76 kB
✓

Build Dir Size
1.39 MB
1.39 MB
⚠  +683 B

Click to expand serverless stats ⚠ Total Bundle Size Increase ⚠

zeit/next.js canary
felixmosh/next.js WithRouter-with-query-type
Change

Build Duration
23.1s
23.1s
⚠  +24ms

node_modules Size
43.6 MB
43.6 MB
⚠  +304 B

Total Bundle (main, webpack, commons) Size
207 kB
207 kB
⚠  +54 B

Total Bundle (main, webpack, commons) gzip Size
68.1 kB
68.1 kB
⚠  +15 B

Total Bundle (main, webpack, commons) Modern Size
181 kB
182 kB
⚠  +54 B

Total Bundle (main, webpack, commons) Modern gzip Size
59.9 kB
59.9 kB
⚠  +12 B

Client _app Size
2.39 kB
2.39 kB
✓

Client _app gzip Size
1.08 kB
1.08 kB
✓

Client _app Modern Size
1.83 kB
1.83 kB
✓

Client _app gzip Modern Size
890 B
890 B
✓

Client _error Size
8.22 kB
8.22 kB
✓

Client _error gzip Size
3.16 kB
3.16 kB
✓

Client _error Modern Size
5.85 kB
5.85 kB
✓

Client _error gzip Modern Size
2.33 kB
2.33 kB
✓

Client pages/index Size
343 B
343 B
✓

Client pages/index gzip Size
246 B
246 B
✓

Client pages/index Modern Size
319 B
319 B
✓

Client pages/index gzip Modern Size
254 B
254 B
✓

Client pages/link Size
4.08 kB
4.08 kB
✓

Client pages/link gzip Size
1.8 kB
1.8 kB
✓

Client pages/link Modern Size
3.7 kB
3.7 kB
✓

Client pages/link gzip Modern Size
1.7 kB
1.7 kB
✓

Client pages/routerDirect Size
423 B
423 B
✓

Client pages/routerDirect gzip Size
306 B
306 B
✓

Client pages/routerDirect Modern Size
411 B
411 B
✓

Client pages/routerDirect gzip Modern Size
314 B
314 B
✓

Client pages/withRouter Size
435 B
435 B
✓

Client pages/withRouter gzip Size
301 B
301 B
✓

Client pages/withRouter Modern Size
423 B
423 B
✓

Client pages/withRouter gzip Modern Size
309 B
309 B
✓

Client main Size
15.8 kB
15.8 kB
✓

Client main gzip Size
5.46 kB
5.46 kB
✓

Client main Modern Size
12.8 kB
12.8 kB
✓

Client main Modern gzip Size
4.83 kB
4.83 kB
✓

Client commons Size
188 kB
188 kB
⚠  +54 B

Client commons gzip Size
61.3 kB
61.3 kB
⚠  +15 B

Client commons Modern Size
169 kB
169 kB
⚠  +54 B

Client commons Modern gzip Size
55.1 kB
55.1 kB
⚠  +12 B

Client webpack Size
1.53 kB
1.53 kB
✓

Client webpack gzip Size
778 B
778 B
✓

Client webpack Modern Size
1.53 kB
1.53 kB
✓

Client webpack Modern gzip Size
785 B
785 B
✓

Serverless pages/link Size
255 kB
255 kB
⚠  +82 B

Serverless pages/link gzip Size
68.5 kB
68.5 kB
⚠  +16 B

Serverless pages/index Size
247 kB
248 kB
⚠  +82 B

Serverless pages/index gzip Size
66.3 kB
66.4 kB
⚠  +15 B

Serverless pages/_error Size
247 kB
247 kB
⚠  +82 B

Serverless pages/_error gzip Size
66.1 kB
66.1 kB
⚠  +15 B

Serverless pages/routerDirect Size
248 kB
248 kB
⚠  +82 B

Serverless pages/routerDirect gzip Size
66.3 kB
66.3 kB
⚠  +16 B

Serverless pages/withRouter Size
248 kB
248 kB
⚠  +82 B

Serverless pages/withRouter gzip Size
66.4 kB
66.4 kB
⚠  +15 B

Build Dir Size
2.59 MB
2.59 MB
⚠  +929 B

Diff for commons.js

@@ -6704,7 +6704,7 @@ var _interopRequireDefault = __webpack_require__("KI45");
 exports.__esModule = true;
 exports.useRouter = useRouter;
 exports.makePublicRouterInstance = makePublicRouterInstance;
-exports.createRouter = exports.withRouter = exports["default"] = void 0;
+exports.createRouter = exports.WithRouterProps = exports.withRouter = exports["default"] = void 0;

 var _extends2 = _interopRequireDefault(__webpack_require__("htGi"));

@@ -6719,9 +6719,10 @@ exports.NextRouter = _router2.NextRouter;

 var _routerContext = __webpack_require__("9EOK");

-var _withRouter = _interopRequireDefault(__webpack_require__("0Bsm"));
+var _withRouter = _interopRequireWildcard(__webpack_require__("0Bsm"));

 exports.withRouter = _withRouter["default"];
+exports.WithRouterProps = _withRouter.WithRouterProps;
 /* global window */

 var singletonRouter = {

Diff for commonsModern.js

@@ -4850,7 +4850,7 @@ var _interopRequireDefault = __webpack_require__("KI45");
 exports.__esModule = true;
 exports.useRouter = useRouter;
 exports.makePublicRouterInstance = makePublicRouterInstance;
-exports.createRouter = exports.withRouter = exports.default = void 0;
+exports.createRouter = exports.WithRouterProps = exports.withRouter = exports.default = void 0;

 var _extends2 = _interopRequireDefault(__webpack_require__("htGi"));

@@ -4865,9 +4865,10 @@ exports.NextRouter = _router2.NextRouter;

 var _routerContext = __webpack_require__("9EOK");

-var _withRouter = _interopRequireDefault(__webpack_require__("0Bsm"));
+var _withRouter = _interopRequireWildcard(__webpack_require__("0Bsm"));

 exports.withRouter = _withRouter.default;
+exports.WithRouterProps = _withRouter.WithRouterProps;
 /* global window */

 const singletonRouter = {

@felixmosh I don't believe we're interested in pursuing this, for a few reasons:

It increases bundle sizes.
Typing a query is a flawed idea, since it's user-supplied data. The shape of the object is not known. If anything, we'd need to force the keys to be optional and have a specific type, which this PR does not.
You can always cast the query object to an interface within your page.
There's no 👍's on this PR, meaning there's not a lot of interest for this addition.

For these reasons, I'm going to close this PR. We're not interested in having complete compatibility with the old community types, especially in these scenarios.

it increased the bundle with bytes, not sure if this is an issue with your bundle size method or not.
your comment is wrong, cause query strings are not defined by users but by dev, yeah, user can change its value, but the field it self defined by dev.
casting in TS world it not suggested, and requires to do so in each one of the query usages.
This PR is improvement of types, I'm not sure how many Next users are TS users.

Anyway, thank you for your time.


call nl2br on header message output so it can contain more than 1 line

See discussion: http://www.concrete5.org/index.php?cID=255424

+1


Performance during MiTM

Hi, just to let you know that when using mitmHandler, a lot of CPU time is spent in mitm_handler.transmit.

Not sure if the client-side connections are pooled?

Yes, I know. MITM does not use connection pooling, and I am still considering a solution.
The tunnel agent has used the connection pool.
https://github.com/telanflow/mps/blob/668b4ac974bbc66848672bcdd0c2150a5b74406c/mitm_handler.go#L133-L142

However, you need to pay attention to:
The client needs to reuse the connection every time it initiates a request. Otherwise the request will re-create the connection, resulting in repeated TLS handshake

Hi @telanflow , i'll check the http protocol version.
So what does this todo refer to then? https://github.com/telanflow/mps/blob/master/mitm_handler.go#L134

@telanflow Interesting, I've disabled connection: close on request & response and always use HTTP/1.1.


Add elm-format

Has the change to not report errors if it fails, I experiemented with using the below shell script which can be used instead if desired, though it wasn't 100% accurate.
elm-format --yes "$1" || elm make "$1"

Initial failure was #99

Oh, sorry, I think I missed this. Let me take a look.

Aware I can merge my own PRs now, personally unsure about doing that but if you're happy with this I can merge this in too :) @raxod502

Sorry, should have gotten back to you much earlier about this. Yeah, please feel free.


Update deployment jobs in Jenkins

The deployment jobs for BETA and PROD need to be updated to correspond to the software changes came with the upgrade.
Acceptance criteria:

[x] jobs for BETA updated
[x] jobs for PROD updated

Upgraded neo4j on beta and on both prod servers. Jenkins jobs were updated to reference new neo4j installations and to get PID from the app.
Given that we are currently running the old versions, when doing the release some downtime is inevitable since the new deploy script is not able to shut down the old instances, I will need to do that manually.

Updated all deployment scripts with the exception of the live checker.


Fixed HomeAssistant IP & Token not updating to "None"

In this updated version of the saveApiKeys function:
Before sending the setupValues to the main process, we check if the dynamic-textbox-home-assistant-url and dynamic-textbox-home-assistant-token values are not provided (i.e., they are empty or falsy).
If either the Home Assistant URL or token is not provided, we set their values in the setupValues object to "none".
Finally, we send the updated setupValues object to the main process using ipcRenderer.send('saveApiKeys', setupValues) to save the API keys.
With this modification, if the user skips the Home Assistant setup step (i.e., clicks the "no-home-assistant" button), the HomeAssistant_URL_IP and HomeAssistant_Token values in the apikey.py file will be set to "none".

I tested this out and it worked for me (I'm on Mac M1 Pro)

Totally overlooked that on my part, thank you!!


[libraqm] Add new port (0.6.0)

Hi @tobbi, thanks for the new port. Here are the test results from the current CI system:

x64-windows
test
notes

libraqm
Fail
New Port

x64-windows-static
test
notes

libraqm
Fail
New Port

x64-osx
test
notes

libraqm
Skip
New Port

arm64-windows
test
notes

libraqm
Skip
New Port

x86-windows
test
notes

libraqm
Fail
New Port

x64-linux
test
notes

libraqm
Skip
New Port

x64-uwp
test
notes

libraqm
Skip
New Port

arm-uwp
test
notes

libraqm
Skip
New Port

failureLogs.zip

Curious. Building worked just fine on my machine, which is a Win 10 x64. Does anyone have any idea what could have gone wrong?

@tobbi: read the logs:
CMake Error at C:/vsts/_work/9/s/scripts/buildsystems/vcpkg.cmake:198 (_add_library):
  Target "raqm" links to target "unofficial::glib::glib" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?

you are simply missing a dependency

@tobbi: read the logs:
CMake Error at C:/vsts/_work/9/s/scripts/buildsystems/vcpkg.cmake:198 (_add_library):
  Target "raqm" links to target "unofficial::glib::glib" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?

you are simply missing a dependency

You see, when I built this locally, I didn't need that dependency. Here's a list of locally installed packages:
C:\vcpkg>vcpkg.exe list
bzip2:x64-windows                                  1.0.6-4          High-quality data compressor.
bzip2:x86-windows                                  1.0.6-4          High-quality data compressor.
freetype:x64-windows                               2.9.1-1          A library to render fonts.
freetype:x86-windows                               2.9.1-1          A library to render fonts.
fribidi:x64-windows                                58c6cb3          GNU FriBidi is an implementation of the Unicode ...
fribidi:x86-windows                                58c6cb3          GNU FriBidi is an implementation of the Unicode ...
harfbuzz:x64-windows                               2.4.0            HarfBuzz OpenType text shaping engine
harfbuzz:x86-windows                               2.4.0            HarfBuzz OpenType text shaping engine
harfbuzz[ucdn]:x64-windows                                          Builtin (UCDN) Unicode callbacks support
harfbuzz[ucdn]:x86-windows                                          Builtin (UCDN) Unicode callbacks support
libpng:x64-windows                                 1.6.37-1         libpng is a library implementing an interface fo...
libpng:x86-windows                                 1.6.37-1         libpng is a library implementing an interface fo...
libraqm:x64-windows                                0.5.0            A library for complex text layout
libraqm:x86-windows                                0.6.0            A library for complex text layout
ragel:x64-windows                                  6.10-1           Ragel State Machine Compiler
ragel:x86-windows                                  6.10-1           Ragel State Machine Compiler
zlib:x64-windows                                   1.2.11-5         A compression library
zlib:x86-windows                                   1.2.11-5         A compression library
So I'm a bit confused as to why glib is suddenly required.

hmm on which commit is your checkout of vcpkg compared to current master of vcpkg? Could be some recent change which introduced the target in one of those dependent targets.

I'm now on latest master. But even after rebasing, I can still build it fine. I rebuild every time with
vcpkg.exe remove libraqm && vcpkg.exe install libraqm

You have to rebuild vcpkg upgrade --no-dry-run  or start clean by deleting the folders installed, buildtress and packages.

Even after running that command, the build still worked fine.

hmm tested it locally and it also worked. Try to retrigger CI by either pushing a whitespace change or merging current master

Done, let's see about the results.

hmm seems like CI is again partly broken (at least the Preview CI is already finished an giving the same errors as before)

Is the error message the same this time?

/azp run

CI keeps reporting failures on Windows, but I've been successful in installing it locally.
I'll take a look at what's causing the issues.

The dependency to unofficial::glib::glib can come from harfbuzz when some features are enabled. However, that's not the case when harfbuzz[ucdn] is installed, so more investigation is required.
For x64-windows-static I did notice a problem with fribidi, the library produces a libfribidi.a binary on Windows and libraqm seems unable to find it because of it.

/azp run

As of now, it passes on most platforms, but fails on x64-windows-static due to issue an issue withfribidi's meson build #6789.
I'm OK with merging this PR now and waiting for a new PR that addresses #6789 in the future.


Upgrading from 5.1.1 to 5.2.0 breaks API project

When updating from 5.1.1 to 5.2.0 i started getting this exception.
Autofac.Core.DependencyResolutionException: An exception was thrown while activating ?:Microsoft.Extensions.Hosting.IHost -> Microsoft.Extensions.Hosting.Internal.ApplicationLifetime -> Microsoft.Extensions.Logging.Logger`1[[Microsoft.Extensions.Hosting.Internal.ApplicationLifetime, Microsoft.Extensions.Hosting, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60]] -> ?:Microsoft.Extensions.Logging.ILoggerFactory -> ?:Serilog.SerilogHostBuilderExtensions+RegisteredLogger.
---> System.TypeLoadException: Could not load type 'Serilog.Sinks.Http.Private.Sinks.HttpSink' from assembly 'Serilog.Sinks.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=24c2f752a8e58a10' because the parent type is sealed.

Thanks for the note @alastor09.
Adding a dependency on Serilog.Sinks.PeriodicBatching v3.1.0 will resolve this, until #186 is merged (which we'll do shortly).

I run into the same issue just with another Sink (AwsCloudWatch), explicitly adding Serilog.Sinks.PeriodicBatching resolves it indeed.
This was the call stack that i got when i created the logger:
Could not load type 'Serilog.Sinks.AwsCloudWatch.CloudWatchLogSink' from assembly 'Serilog.Sinks.AwsCloudWatch, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=23b095b16108dcf5' because the parent type is sealed.
   at System.Reflection.RuntimeAssembly.GetExportedTypes()
   at System.Reflection.Assembly.get_ExportedTypes()
   at Serilog.Settings.Configuration.ConfigurationReader.<>c.<FindConfigurationExtensionMethods>b__32_1(Assembly a)
   at System.Linq.Enumerable.SelectManySingleSelectorIterator`2.MoveNext()
   at System.Linq.Enumerable.SelectManySingleSelectorIterator`2.MoveNext()
   at System.Linq.Enumerable.WhereEnumerableIterator`1.ToList()
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Serilog.Settings.Configuration.ConfigurationReader.FindConfigurationExtensionMethods(IReadOnlyCollection`1 configurationAssemblies, Type configType)
   at Serilog.Settings.Configuration.ConfigurationReader.FindSinkConfigurationMethods(IReadOnlyCollection`1 configurationAssemblies)
   at Serilog.Settings.Configuration.ConfigurationReader.ApplySinks(LoggerConfiguration loggerConfiguration)
   at Serilog.Settings.Configuration.ConfigurationReader.Configure(LoggerConfiguration loggerConfiguration)
   at Serilog.Configuration.LoggerSettingsConfiguration.Settings(ILoggerSettings settings)
   at Serilog.ConfigurationLoggerConfigurationExtensions.Configuration(LoggerSettingsConfiguration settingConfiguration, IConfiguration configuration, String sectionName, DependencyContext dependencyContext)

Thanks @JochemE .
v5.2.1 is out now, and fixes this: https://github.com/datalust/serilog-sinks-seq/releases/tag/v5.2.1
🎉

It looks like NuGet.org is taking longer than usual to index the package - hopefully it pops up soon, I'll keep an eye on it.

I see it on nuget and our CI build is green 💚


[Task] Adjust icons to make pixel perfect

As pointed out by @mpodciwinski, our icons aren't pixel perfect and it's about time to fix that.
A good reference about pixel perfect icon designing: https://www.youtube.com/watch?v=KYpVtDj-xQs

@JimiC it's sounds good for me.
I attach 2 folder samples Dropbox
Check with yourself, and write to me or see the differences before and after.

Looking at your icons I have the following requests:

The icon MUST have a 2px margin from all sides, meaning if the artwork is a 32x32 canvas, the background icon should always be 28x28.
The background icon SHOULD be centered.
The overlaying icon MUST be no more than 21x21px and MUST always be placed on the right bottom corner with a 1px margin from right and bottom.

@JimiC Ok, but now can you send me folder with examples? or write me how I can easily create own?
You guidelines is not correct. I will describe them exactly tomorrow.

We have no folder with examples. All icons are in the icons folder.

I know, but how i want see how icon look in VsCode, must create folder (or file) with this extension. This is problematic.

Yeah. you see the examples generator is a lagcy tool. I made it when we switched from PNG to SVG and at that time we didn't have implemented the language id support. So all the icons that are supported via a language highlighting extension will not show if the extension is not installed in vscode.
There is though a workaround by using the customization feature. This works if you follow these instructions.

 It's too hard for me now. :sweat:
I just start with code, i am beginner. Before this, i was only designing, i still do this, but it's time learning something new. Meybe thats why i saw this not perfect icons. :grin:
I would be grateful if you do this himself and publish.

I can help you further tomorrow.

Thank's :v:

@mpodciwinski Turns out that examples-generator has a bug on Windows. Some bug was in wpilgenerator, I fixed that but forgot to do the same with the examples-generator It works on *nix OSes though. So I assume you are working on Windows (hench you working with Ai).
So until I get the fix in, you can start with the folders manually in vscode.

Create a folder named examples.
Under examples folder, create a folder using as name any value from the Folder Name column in the folders list.

The icon should show up.
Now if you want to test your icons simply replace the existing icon (make a backup first just in case) in the icons folder. Then start Launch Extension from the Debugger (F5) and open the examples folder in the new vscode instance that will pop-up.

If you have any link I can read or watch on why our guidelines aren't correct, I would appreciate it much.

@JimiC ok, give me a sign if you fix it and generate examples.

@JimiC i did as you wrote:

Now if you want to test your icons simply replace the existing icon (make a backup first just in case) in >the icons folder. Then start Launch Extension from the Debugger (F5) and open the examples folder in >the new vscode instance that will pop-up.

but some errors appear to me Error screencast

And when I preview the file's file it still leads to the installation folder.
I'm doing something wrong?

That means that the project did not build. Try npm run build. If all goes well you will see a success message in console. Otherwise, post back any error message.

output from shell:
PS D:\Dropbox\Folder zespołu Inspect\Repo\github\vscode-icons> npm run build

><EMAIL_ADDRESS>prebuild D:\Dropbox\Folder zespołu Inspect\Repo\github\vscode-icons
> npm run lint && npm run test

><EMAIL_ADDRESS>lint D:\Dropbox\Folder zespołu Inspect\Repo\github\vscode-icons
> tslint -p .

'tslint' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>lint: `tslint -p .`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\mpodc\AppData\Roaming\npm-cache\_logs\2018-06-04T10_44_33_250Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>prebuild: `npm run lint && npm run test`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prebuild script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\mpodc\AppData\Roaming\npm-cache\_logs\2018-06-04T10_44_33_288Z-debug.log

I've installed all the recommended packages.

Delete  node_modules folder and install the dependencies again via npm i. Something must have gone wrong in the first install.

You are in trouble. The Git installation seems busted.

Maybe, but other project works correct with git.
I will reinstall Git and see what happens.
PS C:\Users\mpodc\Desktop\vscode-icons> node -v
v8.11.2
PS C:\Users\mpodc\Desktop\vscode-icons> npm -v
6.1.0
PS C:\Users\mpodc\Desktop\vscode-icons>

Node and npm looks good although we use Node 7.9.0 for the project to be inline with the node version vscode uses.
Can you perform git submodule update --init --recursive on the project directly?

Reinstal Git and still this same.
Yes, i try. 😢

I do not know if this is important, but I meant it as a "change" for files and I did not change anything there.

You need to revert any changes.

I do not make any changes to the entire root, except changing the same svg files. These changes in the submodule it creates itself after typing npm i in console.

I'm at a loss here. I don't know how to help you further.

Thanks anyway, i give up too.
I will wait until you solve the problems you mentioned above. ✌

Stil,l you will have to resolve the issue with npm install. Even fixing the bug examples-generator is a submodule of the project.

@mpodciwinski I figured out your issue. It's a bub with npm 6.1.0 (https://github.com/npm/npm/issues/20815)
Since some commits have been made to the project it's prudent to fetch those commits before you try the following workaround.
There are two ways to bypass the error:

Downgrade npm to 5.10.0 by typing npm i -g<EMAIL_ADDRESS>
or

Remove the preinstall script from package.json and perform a manual git submodule update --init --recursive.

Then proceed with npm i as usual. In case of 2, revert the removal of the preinstall script.

I did as you said, install node 7.9.0 and npm 5.10.0.
❯ node -v
v7.9.0
❯ npm -v
5.10.0

but still 😞
><EMAIL_ADDRESS>preinstall /Users/michal_mac/Dropbox/Folder zespołu Inspect/Repo/github/vscode-icons
> git submodule update --init --recursive

><EMAIL_ADDRESS>install /Users/michal_mac/Dropbox/Folder zespołu Inspect/Repo/github/vscode-icons/node_modules/nodegit
> node lifecycleScripts/preinstall && node lifecycleScripts/install

[nodegit] Running pre-install script
[nodegit] Configuring libssh2.
{ Error: spawn /bin/sh ENOENT
    at exports._errnoException (util.js:1050:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
    at onErrorNT (internal/child_process.js:367:16)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)
    at process._tickCallback (internal/process/next_tick.js:104:9)
  code: 'ENOENT',
  errno: 'ENOENT',
  syscall: 'spawn /bin/sh',
  path: '/bin/sh',
  spawnargs:
   [ '-c',
     '/Users/michal_mac/Dropbox/Folder\\ zespołu\\ Inspect/Repo/github/vscode-icons/node_modules/nodegit/vendor/libssh2/configure --with-libssl-prefix=/Users/michal_mac/Dropbox/Folder\\ zespołu\\ Inspect/Repo/github/vscode-icons/node_modules/nodegit/vendor/openssl/openssl' ],
  cmd: '/Users/michal_mac/Dropbox/Folder\\ zespołu\\ Inspect/Repo/github/vscode-icons/node_modules/nodegit/vendor/libssh2/configure --with-libssl-prefix=/Users/michal_mac/Dropbox/Folder\\ zespołu\\ Inspect/Repo/github/vscode-icons/node_modules/nodegit/vendor/openssl/openssl' }

[nodegit] ERROR - Could not finish preinstall
{ Error: spawn /bin/sh ENOENT
    at exports._errnoException (util.js:1050:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
    at onErrorNT (internal/child_process.js:367:16)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)
    at process._tickCallback (internal/process/next_tick.js:104:9)
  code: 'ENOENT',
  errno: 'ENOENT',
  syscall: 'spawn /bin/sh',
  path: '/bin/sh',
  spawnargs:
   [ '-c',
     '/Users/michal_mac/Dropbox/Folder\\ zespołu\\ Inspect/Repo/github/vscode-icons/node_modules/nodegit/vendor/libssh2/configure --with-libssl-prefix=/Users/michal_mac/Dropbox/Folder\\ zespołu\\ Inspect/Repo/github/vscode-icons/node_modules/nodegit/vendor/openssl/openssl' ],
  cmd: '/Users/michal_mac/Dropbox/Folder\\ zespołu\\ Inspect/Repo/github/vscode-icons/node_modules/nodegit/vendor/libssh2/configure --with-libssl-prefix=/Users/michal_mac/Dropbox/Folder\\ zespołu\\ Inspect/Repo/github/vscode-icons/node_modules/nodegit/vendor/openssl/openssl' }
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node lifecycleScripts/preinstall && node lifecycleScripts/install`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/michal_mac/.npm/_logs/2018-06-09T15_52_34_852Z-debug.log

Even how i delete preinstall script. Still this same error.
I don't know why he installs this script as I removed it.
"preinstall": "git submodule update --init --recursive",

Since some commits have been made to the project it's prudent to fetch those commits before you try the following workaround.

I missed it.
Now it's works! 😄
Thanks!

@mpodciwinski Have you abandoned the task?

No, I'm still working. there is a lot to do.

Good to know.

@mpodciwinski FYI, you can update npm to 6.4+ as the bug with the submodule was fixed.

Does this task still in progress? Because there is a option to make every icon pixel perfect for their current size (32x32) without having to rely on those steps. Just right click on the selection and select "Generate Pixel Perfect" and adobe Illustrator will automatically modify the svg sizes to make it fit the grid as stated by the guidelines.
Example with the default file icon:

Illustrator version?

@JimiC Adobe Illustrator CC 2019 :)


Unable to get deployed application url https://deployedtest.azurewebsites.net after successful deployment of Azure IIOT 2.9.2

Describe the bug
Unable to get deployed application url https://deployedtest.azurewebsites.net after successful deployment of Azure IIOT 2.9.2
To Reproduce
Steps to reproduce the behavior:

Followed url https://github.com/Azure/Industrial-IoT/blob/main/docs/web-api/readme.md#running-the-industrial-iot-platform-opc-publisher-web-service-locally to deploy the azure IIOT 2.9.2
Download the code in local machine using git clone https://github.com/Azure/Industrial-IoT
cd Industrial-IoT
Run the poweshell ./aad-register.ps1 -Name testapp -ReplyUrl https://testapp.azurewebsites.net/ -TenantId ************************* -Output aad.json
After that run the powershell ./deploy.ps1 -version 2.9.2-aadConfig aad.json-applicationName testapp
Error : Got message Deployment '2.9.2' succeeded. but did not receieve message "the deployed application can be found at https://testapp.azurewebsites.net" as per msdn docs. Although receieved message "Save environment as C:\Code\Industrial-IoT.env for local development? [y/n]: n" we choose 'n', also got below urls
PCS_RESOURCE_GROUP=rg-tfp-prod
PCS_KEYVAULT_URL=https://keyvault-test.vault.azure.net/
PCS_AUTH_PUBLIC_CLIENT_APPID=****************************
PCS_AUTH_TENANT=*******************************************
PCS_IMAGES_TAG=2.9.2
PCS_SERVICE_URL=https://testapp.azurewebsites.net

Tried to access the https://testapp.azurewebsites.net  which is PCS_SERVICE_URL, got error message "This testapp.azurewebsites.net  page can’t be found"

The service url is the endpoint of the rest api.  You can use swagger UI to exercise the API as described in the referenced documentation.  The engineering tool has been removed, but we would take contribution to make what we saved in the engineeringtool branch working again and check it into the samples folder.


[REQUEST] Zigbee Router configuration for ESPHome on ZB-GW03

FYI, xsp1989 has uploaded a signed Zigbee Router firmware for ITead's Sonoff ZBBridge which could possibly make it a Tasmota/ESPHome connected Zigbee Router (instead of as a Zigbee Coordinator).
I think that this firmware image should also be compatible with ZB-GW03 as it too uses "SM-011 V1.0"?
Do you think that ESPHome could send basic commands to Zigbee Router firmware to initiate paring/joining and restart/reset?

https://drive.google.com/file/d/1H-M5CTh_XGGVl2te4vHLQ5SfGPHL6yCS/view?usp=sharing
This is the signed routing firmware used by ZBB, the usage method is the same as the unsigned firmware.
https://github.com/xsp1989/zigbeeFirmware/blob/master/firmware/Zigbee3.0_Dongle/RouterForDongle/README.md

Idea around this is also discussed for ITead's Sonoff ZBBridge hacked with Tasmota/ESPHome here:
https://github.com/arendst/Tasmota/discussions/11536
https://github.com/thegroove/esphome-zbbridge/issues/3
https://github.com/xsp1989/zigbeeFirmware/issues/2
https://github.com/xsp1989/zigbeeFirmware/issues/16
I have not tried this myself as I got rid of my ITead Sonoff ZBBridge because being WiFi-based it did not work any good as a remote Zigbee Coordinator, and never bought a ZB-GW03, but might reconsider buying these if it worked as a Zigbee Router device that can be paired/joined and restarted/reset remotely via Tasmota and/or ESPHome. So that Tasmota/ESPHome is basically only used to initiate virtual join/pair button and restart/reset the device similar to a remote power-cycle it hangs.

Update from xsp1989 on router firmware posted on https://github.com/arendst/Tasmota/discussions/11536
"This firmware can ground the PA00 5S into pairing mode, and ground the RST to restart routing. UART is used to transmit data transparently.
and
"There is also another version of the routing firmware that can control the join network through a proprietary serial port protocol"

Check out this new "How to Convert the Sonoff Zigbee Bridge into a Router / Repeater" blog article by @digiblur here:
https://www.digiblur.com/2022/02/convert-sonoff-zigbee-bridge-to-router-repeater.html
Note that the article already assumes that you have flashed Tasmota onto ITead Sonoff ZBBridge as per his previous guide:
https://www.digiblur.com/2020/07/how-to-use-sonoff-zigbee-bridge-with.html

{
  "NAME":"Sonoff ZigRouter","GPIO":
  [
    320,   # GPIO0     Led_i 1     Inverted LED - default state ON
    5088,  # GPIO1     TCP TX      TCP to serial bridge
    0,     # GPIO2     Not used
    5120,  # GPIO3     TCP RX      TCP to serial bridge
    257,   # GPIO4     Relay_i 2   Relay inverted
    256,   # GPIO5     Relay_i 1   Relay inverted
    0,     # GPIO6     Not used
    0,     # GPIO7     Not used
    0,     # GPIO8     Not used
    576,   # GPIO9     LedLinki    Device Status LED, inverted
    0,     # GPIO10    Not used
    0,     # GPIO11    Not used
    32,    # GPIO12    Button 1    Button active low, internal pull-up resistor
    0      # GPIO13    Not used
   ],
  "FLAG":0,
  "BASE":18
} ; delay1 ; module 0

Summary: GPIO5 is used to trigger to pairing mode (via Relay_i  1 or Button 1) at digiblurs tasmota template.

Comparison of different Sonoff Zigbee Bridge tasmota templates:
{"NAME":"ZHA ZBBridge",    "GPIO":[ 56, 208,0, 209, 59, 58,0,0,0,  0,0,0,17  ],"FLAG":0,"BASE":18}
{"NAME":"Sonoff ZHABridge","GPIO":[ 56, 208,0, 209, 59, 58,0,0,0,  0,0,0,17  ],"FLAG":0,"BASE":18} ; module 0
{"NAME":"Sonoff ZigRouter","GPIO":[320,5088,0,5120,257,256,0,0,0,576,0,0,32,0],"FLAG":0,"BASE":18} ; delay1 ; module 0

https://github.com/xsp1989/zigbeeFirmware/issues/16#issuecomment-1044625713
https://github.com/arendst/Tasmota/discussions/11536#discussioncomment-2202272
"This firmware can ground the PA00 5S into pairing mode, and ground the RST to restart routing. UART is used to transmit data transparently.

At the ZB-GW03 PA00 is attached to GPIO12 of the ESP: https://github.com/syssi/esphome-zb-gw03/blob/main/example.yaml#L93-L99

I've added a guide to use the ZB-GW03 as Zigbee router: https://github.com/syssi/esphome-zb-gw03/blob/main/docs/router.md

I kept it simple with the pairing and zigbee reset for folks.

@syssi Could you copy the button press paring mode option from @digiblur as well as too is a great alternative option?
https://www.digiblur.com/2022/02/convert-sonoff-zigbee-bridge-to-router-repeater.html
Next we need to enable the ability for the GUI and reset button to be used as the device pairing procedure.  Paste the following command into the console all on one line:
backlog template {"NAME":"Sonoff ZigRouter","GPIO":[320,5088,0,5120,257,256,0,0,0,576,0,0,32,0],"FLAG":0,"BASE":18} ; delay1 ; module 0
The bridge should reboot and come back up on the console.  The device is ready to be paired with your Zigbee network.    Enable pairing on your Zigbee Network as you would normally pair a regular sensor, switch, etc.  NOTE: Zigbee2MQTT users as of this time will need to add a custom file to support this router before pairing (see last section of this guide)
To place the device into pairing mode, simply use a paper clip to briefly push the reset button next to the USB power plug.

The green LED will light up.  Allow 5-6 seconds to pass and press the button again, this will turn off the green LED and the device will be in pairing mode.

This is already the case: https://github.com/syssi/esphome-zb-gw03/blob/main/packages/button_pairing_mode.yaml#L21-L31
If you press the button of the device the pairing mode is triggered. On difference: There is no LED attached.


[POC][WIP] - using zinc's Dependency analysis for rules_scala strict deps

This POC is related to "smart" strict deps issue

Can we close this?

Done