[Bug] Watch folder stops after 1 file

Current Behavior
When I start the container, with multiple files in the watch folder, it will process the first one, then not continue with the next files. As well, in the logs it says the original file was removed, but its not actually removed.
Expected Behavior
All the files in the watch folder should be encoded and then removed.
Steps To Reproduce
No response
Environment

OS: Unraid
OS version:
CPU:
Docker version:
Device model:
Browser/OS:

Container creation
Created in Unraid
Container log
╭――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――╮
    │                                                                      │
    │ Application:           HandBrake                                     │
    │ Application Version:   1.6.1                                         │
    │ Docker Image Version:  23.02.1                                       │
    │ Docker Image Platform: linux/amd64                                   │
    │                                                                      │
    ╰――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――╯
[cont-init   ] 89-info.sh: terminated successfully.
[cont-init   ] all container initialization scripts executed.
[init        ] giving control to process supervisor.
[supervisor  ] loading services...
[supervisor  ] loading service 'default'...
[supervisor  ] loading service 'app'...
[supervisor  ] loading service 'gui'...
[supervisor  ] loading service 'certsmonitor'...
[supervisor  ] service 'certsmonitor' is disabled.
[supervisor  ] loading service 'nginx'...
[supervisor  ] loading service 'xvnc'...
[supervisor  ] loading service 'openbox'...
[supervisor  ] loading service 'logmonitor'...
[supervisor  ] service 'logmonitor' is disabled.
[supervisor  ] loading service 'logrotate'...
[supervisor  ] loading service 'autovideoconverter'...
[supervisor  ] all services loaded.
[supervisor        ] starting services...
[supervisor        ] starting service 'xvnc'...
[xvnc              ] Xvnc TigerVNC 1.12.0 - built Feb 14 2023 01:01:21
[xvnc              ] Copyright (C) 1999-2021 TigerVNC Team and many others (see README.rst)
[xvnc              ] See https://www.tigervnc.org for information on TigerVNC.
[xvnc              ] Underlying X server release 12013000, The X.Org Foundation
[xvnc              ] Mon Jul 24 22:57:23 2023
[xvnc              ]  vncext:      VNC extension running!
[xvnc              ]  vncext:      Listening for VNC connections on /tmp/vnc.sock (mode 0660)
[xvnc              ]  vncext:      Listening for VNC connections on all interface(s), port 5900
[xvnc              ]  vncext:      created VNC server for screen 0
[supervisor        ] starting service 'nginx'...
[nginx             ] Listening for HTTP connections on port 5800.
[supervisor        ] starting service 'openbox'...
[supervisor        ] starting service 'app'...
[supervisor        ] starting service 'autovideoconverter'...
[autovideoconverter] Processing watch folder '/watch'...
[autovideoconverter] Skipping video '/watch/Futurama - S11E02 - 1080p.mkv' (ebaf732f7688af580d7540ef9f5a793f): already processed successfully.
[autovideoconverter] Waiting 5 seconds before processing '/watch/Futurama - S11E01 - 1080p.mkv'...
[supervisor        ] all services started.
[autovideoconverter] Starting conversion of '/watch/Futurama - S11E01 - 1080p.mkv' (5e3a45c66572893c4d35d11e4866a637) using preset 'General/Very Fast 1080p30'...
[autovideoconverter] 1 title(s) to process.
[autovideoconverter] Executing pre-conversion hook...
[autovideoconverter] Pre-conversion hook exited with 0
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 4.39 %
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 8.49 % (386.95 fps, avg 419.12 fps, ETA 00h01m17s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 14.29 % (561.92 fps, avg 462.01 fps, ETA 00h01m06s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 20.61 % (625.66 fps, avg 504.63 fps, ETA 00h00m55s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 25.72 % (522.27 fps, avg 507.74 fps, ETA 00h00m52s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 31.64 % (573.31 fps, avg 515.82 fps, ETA 00h00m47s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 37.28 % (581.54 fps, avg 524.01 fps, ETA 00h00m43s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 43.13 % (578.20 fps, avg 527.28 fps, ETA 00h00m38s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 49.25 % (599.67 fps, avg 536.03 fps, ETA 00h00m33s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 54.89 % (549.74 fps, avg 537.22 fps, ETA 00h00m30s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 60.55 % (548.62 fps, avg 539.46 fps, ETA 00h00m25s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 66.17 % (553.52 fps, avg 540.47 fps, ETA 00h00m22s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 71.91 % (559.03 fps, avg 541.73 fps, ETA 00h00m18s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 77.69 % (565.00 fps, avg 543.16 fps, ETA 00h00m15s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 83.44 % (564.10 fps, avg 544.72 fps, ETA 00h00m11s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 88.83 % (518.86 fps, avg 543.34 fps, ETA 00h00m08s)
[autovideoconverter] Encoding /watch/Futurama - S11E01 - 1080p.mkv: task 1 of 1, 94.87 % (589.24 fps, avg 546.26 fps, ETA 00h00m03s)
[autovideoconverter] Executing post-conversion hook...
[autovideoconverter] copied '/output/Futurama - S11E01 - 1080p.mp4' -> '/storage/user/Media/TV Shows/Futurama/Season 11/Futurama - S11E01 - 1080p.mp4'
[autovideoconverter] removed '/output/Futurama - S11E01 - 1080p.mp4'
[autovideoconverter] Post-conversion hook exited with 0
[autovideoconverter] Conversion ended successfully.

Container inspect
No response
Anything else?
No response

Please provide the output of docker inspect <container name> so we can have a complete picture of how the container has been configured.
Also, the output of the following command would be useful to see if there is any permission issue:
docker exec <container name> ls -l /watch

Wanted to mention, I have run into this same issue, and determined what was causing it was the rm command for removing the source file after conversion.    The rm is failing due to not having the appropriate write permission to remove the file, so that's the key to fixing the issue.    That said, this error could be handled more gracefully so that processing can continue.

Did you get an error in the log ?  The script should not stop because of a removal failure.


Renaming the git checkout of a fips-driven project directory will render the run unusable

E.g.
git clone git://foo/fancyname

CMakeLists.txt creates fips project called fancyname
mv fancyname nameisfancy
./fips run fancyname

^^ doesn't work anymore.
Is that intended? Imo it makes my own preferred directory structure a little bit inflexible. Building and so on still works as intended and puts the binary into the proper location.

Hmm yes currently the 'project name', directory name and github project name must all be the same. I'm actually surprised that run is the only thing that's broken, need to experiment around with this a bit....


What should I do next?

The script for the anti-ban is not working because the console running program states "The page’s settings blocked the loading of a resource at eval (“script-src”)."

can you do the thing where it gives auto awnsers


VSCode + “Remote - Containers” extension + no_project_mount: true = speed

I've been experimenting with using the VSCode Remote - Containers extension in combination with DDEV's no_project_mount setting and the end result so far is freakin' fast!
I have things mostly working, but am having an issue with using my SSH key pair once all is set up - I'll get to that in a moment. First, here's my setup:

Mac OS X Big Sur
Docker for Mac 3.6.0
VSCode 1.61.1
DDEV 1.18.0

DDEV config changes/additions

config.yaml - added no_project_mount: true
config.yaml - added:

hooks:
  post-start:
    - exec-host: "docker cp ./web/sites/default/settings.php ddev-${DDEV_PROJECT}-web:/var/www/html/web/sites/default/"
    - exec-host: "docker cp ./web/sites/default/settings.local.php ddev-${DDEV_PROJECT}-web:/var/www/html/web/sites/default/"
    - exec-host: "docker cp ./web/sites/default/.gitignore ddev-${DDEV_PROJECT}-web:/var/www/html/web/sites/default"

The above copies the Drupal settings files that DDEV touches into the container.

Created new docker-compose.web.yaml file with the following:

version: "2"

services:
  web:
    volumes:
      - web:/var/www

volumes:
  web:

The above creates a Docker volume for the code to persist through container stops and starts.
Current results
So far, the overwhelming takeaway from this is speed. So much speed. In a totally unscientific test, I compared a drush cr on a standard DDEV config with Drupal 9 with the same command using the setup above. It was about an 80% speed improvement!
Current challenges

When VSCode connects to the project web container, the Terminal only knows about the container - nothing outside of it. This means that the VSCode Terminal cannot run DDEV commands. In my initial testing, I've kept a standard Mac Terminal open to the project directory for running DDEV command, while using the VSCode Terminal to run Git/Drush/Composer commands inside the web container. Side note: Git inside the container is totally useable when the codebase isn't mounted to Mac OS X. Side note 2: Composer (2.x) is freakin' fast as well.
Main issue - I haven't figured out how to run git clone (ssh) from inside the VSCode Terminal when it is connected directly to the container and have my keys work.

From the Mac OS X Terminal, I can ddev ssh and then run git clone without an issue. From the VSCode Terminal, when I try to run the same command:
michael@moddev-web:/var/www/html/web/modules/custom$ git clone git@github.com:ultimike/user_blocker.git
Cloning into 'user_blocker'...
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

So, there appears to be some something that ddev ssh is doing to pass in my keypair that is missing when VSCode is directly connected to the web container. Is there anything I can do to get around this? I've run ddev auth ssh prior to this testing.
-mike

Hi Mike -

I think you'd have the same exact experience with mutagen_enabled, which also doesn't do the project mount.  It also takes care of making sure you code is synced during ddev start so you don't need all those exec host things.
You really need a volume mounted though, so you don't lose everything if docker or the computer restarts or whatever. That's also provided if you turn on mutagen.
ddev ssh is not involved at all in getting your keys into the container. It's just a wrapper on docker exec. You can use ssh-add -l to see if any of your keys have been proxied into the container. I don't know of any reason you'd have this side-effect. But you can always just add your keys into homeadditions/.ssh and then use ssh-add to get them loaded inside the container.

But basically.. try the same thing with mutagen enabled. I think you'll love the experience. But you probably won't even need to use the "Remote containers" extension. The one thing you'll want to do if you're using this exact setup is the default .ddev/mutagen/mutagen.yml does not sync your .git directory, so if you want to use git inside the container you'll want to edit that.  https://ddev.readthedocs.io/en/stable/users/performance/#using-mutagen

You were perfectly clear. I understand.
thanks,
-mike


issues parsing genbank files produced by Pharokka

Hello,
While trying to parse gbk files produced by Pharokka using Biopython, I came into this error 4694
Essentially, some of the qualifier keys in the genbank records are too long and wrap to the next line but Biopython has no way to handle this.
I addressed it with Biopython developers and ended up editing file parser in Bio package itself (scanner.py) as a workaround.
Their suggestion was for me to reach out to you with the error also so that perhaps you can fix these wrap-around-keys
They also added a warning when writing genbank files with sketchy qualifier keys 4703
Thanks! and thanks for your tool too :)
Varada

Hi @vmkhot ,
Thanks for this - 2021-2 me who wrote pharokka was pretty average at coding. A little bit improved now I hope! Pharokka needs a complete refactor to be honest at some point when I get some time.
The issue steps from this part of pharokka https://github.com/gbouras13/pharokka/blob/40c78f65a19dd33e0b2a30b1a8ca434f3c8a2792/bin/processes.py#L760
My question here is, are the ID and locus tag lines wrapping an issue? Or only the other qualifiers (VFDB, CARD etc) - I do also think that 'function' might be an issue with DNA, RNA metabolism. If you came across more please let me know.
The ID and locus tags being too long I am not sure what fix I can put in unless I truncate them (which will almost certainly cause issues inside Pharokka). If I do this, that may make them not unique between CDS. I would say that for these, the user really needs to rename their contig IDs and/or use shorter locus tags.

George

Hi George,
Thanks for your reply!
I didn't have any issues with the IDs or locus tags and the ones in the gbk files I parsed were quite long (like below). The only errors I got was with one of the qualifier keys. Below is an example of a problematic feature. In particular, when we debugging, we found that it was /resistance-nodulation-cell division (RND) antibiotic efflux pump="true" that was breaking the biopython parser.
     CDS             568..951
                     /ID="ERZ1035062_ERZ1035062.110-NODE-110-length-34883-cov-5.
                     965832_CDS_0002"
                     /transl_table=11
                     /phrog="30333"
                     /top_hit="p76161 VI_12486"
                     /locus_tag="ERZ1035062_ERZ1035062.110-NODE-110-length-34883
                     -cov-5.965832_CDS_0002"
                     /function="unknown function"
                     /product="hypothetical protein"
                     /CARD_short_name="marA"
                     /AMR_Gene_Family="General Bacterial Porin with reduced
                     permeability to beta-lactams"
                     /resistance-nodulation-cell division (RND) antibiotic
                     efflux pump="true"
                     /CARD_species="Escherichia coli str. K-12 substr. W3110"
                     /source="Pyrodigal-gv_0.2.0"
                     /score="40.0"
                     /phase="0"
                     /translation="MSRRNTDAITIHSILDWIEDNLESPLSLEKVSERSGYSKWHLQRM
                     FKKETGHSLGQYIRSRKMTEIAQKLKESNEPILYLAERYGFESQQTLTRTFKNYFDVPP
                     HKYRMTNMQGESRFLHPLNHYNS*"

There might be more instances that are problematic but our workaround skipped over these so this is the only one I know of.
In terms of renaming or truncating IDs and locus tags - I strongly prefer it when programs don't auto-rename data as I often use that information downstream to map results back and forth. I agree that the contig names are way too long in my dataset. Typically, my workflows include renaming my bins and contigs to meaningful headers before using programs like Pharokka, but the gbk files were not generated by me so just trying to make the most of what's available :)

Thanks @vmkhot I'm glad the locus tags and IDs are ok.
I should be able to fix this in the next update of pharokka by cleaning up the format-breaking metadata from CARD and VFDB (not that it will be helpful for you necessarily but still it will be helpful downstream!) - thanks for alerting me.
George

Hi @vmkhot ,
I've put in a fix to solve this issue (I hope) and it will be available in v1.7.3 soon.
Regarding your data, I see you're in Jena with Bas - I think I was probably involved in generating it :) and have some improvements to make with https://github.com/gbouras13/phold  coming soon. Best to move chat over email if you'd like<EMAIL_ADDRESS>George


readonly visibility modifier for TS2.0+

Did a quick review of the code in actions and I don't see anything that seems to be readonly, so I'd recommend we close this out @kitsonk.


CodeGen: Inline param refs

This looks up parameter references, successfully tested on a proprietary project.

@qxjit Test case added in 94fa13dde596de57fb3f232ba8386d60f11b4ec0


Ocompose for UWD with renaming of junction labels

@epatters, @bosonbaas, this snippet does the composition of UWDs with renaming of the variables via the outer ports like we discussed for the composition of equations. I've tested it on some UWDs, but before I make a PR with tests and stuff. We have some bikeshedding.

Where should this live? If this we are using Structured Cospans of Equations beyond just physics, we should probably put it in Catlab with the UWDs directly
Is this a new function ocompose_rename or can we specialize on UWDs with names and make this ocompose the default for that operad? The current version of ocompose for UntypedUnnamedRelationDiagram checks that the names match, which is really useless because you have to globally name things coherently before you start composing.
I wrote this by mutating the variable column on the input subsystems. None of our ocomposes are destructive on their arguments so far. So this code should probably by fused into the current ocompose implementation to avoid doing a copy of the arguments before composing.
How strictly do we want to make the type parameters on this?

function rename_variables!(uwd, boxes)
    map(1:length(boxes)) do b
        ports = incident(uwd, b, :box)
        jnames = uwd[ports, [:junction, :variable]]
        newnames = map(parts(boxes[b], :OuterPort)) do op
            j = boxes[b][op, :outer_junction]
            oldname = boxes[b][j, :variable]
            # for box $b outer junction $j, renames $oldname → $(jnames[j])
            return jnames[j]
        end
        boxes[b][boxes[b][:outer_junction], :variable] .= newnames
    end
    return boxes
end
ocompose_rename!(uwd, boxes) = ocompose(uwd, rename_variables!(uwd,boxes))

@slibkind, would this help satisfy the need for LACSets in AlgebraicDynamics? It is an ocompose for UWDs where the junctions have names and when you ocompose, you take the names from the outer diagram and assign them to the junctions of the inner diagram.

WIP branch with examples https://github.com/AlgebraicJulia/Catlab.jl/blob/362d8c4df1b33863ff17526b2442aa11b37ad7ad/docs/literate/wiring_diagrams/uwd_vars.jl


Fix #5: Return true instead when setAdvertiserTracking succeed

Intead of returning nil when when setAdvertiserTracking succeed, return
true instead.
Also fix a small typo in the comment

Is there a reason this hasn't been merged yet?


We don't allow speciesism on the main servers, so it has to go.


Missing Required Icon File - Application Loader

New Issue Checklist

[X] I have read the Contribution Guidelines
[X] Updated fastlane to the latest version

Issue Description
http://stackoverflow.com/questions/38640414/missing-required-icon-file-application-loader
After doing a build with Fastlane, which produces a .ipa file, when using the Application Loader application to upload a .ipa file to iTunes Connect for review I encounter an error:
"Missing Required Icon File. The bundle does not contain an app icon for iPad of exactly '167x167' pixels, in .png format for iOS version supporting iPad Pro."
However, in my Images.xcassets folder in my AppIcon Image Set there is an icon set for iPad Pro and it is a .png at 167x167. When I look inside the .ipa file the icon file is not there. It appears the icon file is not being added to the bundle. Could the Fastlane build be doing anything to exclude iPad Pro App Icons?
Notes:

I am not using Xamarin
I have tried adding CFBundleIconFiles to the Info.plist. It did not work.
I have tried cleaning the project, updating Xcode and restarting my computer. It did not work.

Complete output when running fastlane, including the stack trace and command used
The company would prefer not to share this. I can provide information upon request. No errors are being shown except for this:
You're using Xcode 7, the `provisioning_profile_path` value will be ignored
[11:51:58]: Please follow the Code Signing Guide: https://codesigning.guide (for match) or https://github.com/fastlane/fastlane/blob/master/fastlane/docs/CodeSigning.md

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile (snippets only - not actual format. We have several Targets and the only ones that do not submit are ones that specify and iPad Pro icon.):
desc "Performs a build for the App Store"
	lane :build_store do |options|
		output_directory = options[:output_directory] || "/Users/tmbuild/Desktop/Builds"

		cert(output_path: "./artifacts")

		project_udid = sigh(
			adhoc: false,
			force: true,
			output_path: "./fastlane/artifacts"
		)

		ENV["PROJECT_UDID"] = project_udid

		build_app("App Store", ENV["TM_SCHEME"], Actions.lane_context[SharedValues::ENVIRONMENT], "release", output_directory)
	end

def my_get_version_number
	pbx_contents = IO.read("../Tentmaking.xcodeproj/project.pbxproj")
	version_match = pbx_contents.match(/TM_MOBILE_VERSION\s*=\s*(.*?);/)

	if version_match == nil or version_match.size < 2
		raise "Could not find version number"
	end

	return version_match[1]
end

def build_app(configuration, scheme, client_name, friendly_configuration, output_directory)
	version_number = my_get_version_number

	# TODO: For enterprise builds I think we need to specify export_method: "enterprise" (also ad-hoc, app-store are possible)

	gym(
		clean: true,
		configuration: configuration,
		output_directory: output_directory,
		output_name: "#{client_name}-#{version_number}-#{friendly_configuration}.ipa",
		scheme: scheme
	)
end

Environment
fastlane version (run fastlane -v):
fastlane 1.99.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)?
No
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)?
No

@fastlane-bot You probably think all issues are related to Code Signing...

Any update on this? I can submit apps using Application Loader to iTunes Connect if I Archive the .ipa from Xcode. But if I use Fastlane the .ipa does not contain the iPad Pro app icons that I've specified.

Can you repro this in a sample project that you can share with us?

@vpolouchkine  I'll work on that and get back to you. Thanks for responding

@vpolouchkine Okay, I create a super simple test project. The project does nothing, but it has App Icon assets. I was able to reproduce it using a simple 'gym' command. It does not put the iPad Pro image asset in to the bundle. I've attached the zipped project. See the IPA Archive folder for the Unarchived .ipa file contents. Choose the 'Payload' folder and right click on the GymTest > Show Package Contents. You'll see there is no iPad Pro icon in the bundle, but there is an iPad Pro icon in the app image assets.
GymTest.zip

Any update on this? @vpolouchkine @KrauseFx

Apologies for the late followup. Thanks for providing a repro, we'll take a look.


Toast does not remain in action center after

A fired toast does not remain in the action center, once the foreground notification disappear, the notification in the action center disappear too.
It disappear immediately. It would be better if the toast disapper only when dismissed manually.
when I read the documentation at : https://docs.microsoft.com/en-us/windows/uwp/design/shell/tiles-and-notifications/send-local-toast-desktop-cpp-wrl
at step 4 there are the lines :

You must impelment a handler for toast activation, so that when the user clicks on your toast, your app can do something. This is required for your toast to persist in Action Center (since the toast could be clicked days later when your app is closed). This class can be placed anywhere in your project.

A fire toast does not remain in the action center, on the foreground notification time is passed.
It disappear immediately. It would be better if the toast disapper only when dismissed manually.
when I read the documentation at : https://docs.microsoft.com/en-us/windows/uwp/design/shell/tiles-and-notifications/send-local-toast-desktop-cpp-wrl
at spet 4 there are the lines :

You must impelment a handler for toast activation, so that when the user clicks on your toast, your app can do something. This is required for your toast to persist in Action Center (since the toast could be clicked days later when your app is closed). This class can be placed anywhere in your project.

@kowlown could you provide an example of this issue?
WinToast does keep the notifications in the action center by default if the user does not dismiss it or Windows does not hide them.  Make sure that there is nothing wrong in your Windows configuration. See: https://github.com/mohabouje/WinToast#toast-configuration-on-windows-10
Once the toast is in the action center, WinToast does no longer get any call from there. This is an issue that has been discussed in this  issue #35

Well, the issue is exactly as @kowlown said.

Create the Toast
Wait until the Toast times-out and disappears from the screen
The toast is not anymore in the Action Center

The expected behavior (customizable if possible),
would be to leave the Toast in the Action Center, unless the user clicks on the Toast to hide it.
So this

WinToast does keep the notifications in the action center by default if the user does not dismiss it or Windows does not hide them

seems to not be working properly!
I've checked my Notification Settings (as described here, and it is all good.
Hope that the explanation was clean enough,
Than you for all your work @mohabouje

@kowlown could you provide an example of this issue?
WinToast does keep the notifications in the action center by default if the user does not dismiss it or Windows does not hide them. Make sure that there is nothing wrong in your Windows configuration. See: https://github.com/mohabouje/WinToast#toast-configuration-on-windows-10
Once the toast is in the action center, WinToast does no longer get any callback or event from there. This is an issue that has been discussed in this issue #35

I know his means since I'm facing the same problem. The effect what I want is just like the Screen Capture in the newest Windows 10 -- Capturing a photo, and user hide the notification into the action center. When user need it, open the action center and click the remaining notification to get the photo.
//Sorry my English might no very good.


[Feature Request] Add Cookie Header

Hi,
I think it would be very useful to users add custom HTTP Cookie header. This option can be used to specify how to connect to the target URL.
Thanks,

Thanks for the idea!
I am currently working on a complete refactor and I will implement authentication options like BasicAuth, OAuth and also custom headers.
I hope to have it ready in a few days 😄

@fatihersinadim I just released version 3.0.0. Cookies are now supported. Check the README for installation & usage instructions.


change instance type to t3.large

This is to accommodate capacity limits of new regions: ap-southeast-7 and mx-central-1

Hi  @alexxa ,
As discussed offline, this may have cost implications in other deployments that other teams use and in general.
This is an instance type we used to use and we actually changed it to t3.medium to be more cost-effective while still keeping good instance performance.
We can always control which instance type is going to be used directly in the resources.json file.


Decryption of provisioned device

Hi,
If I use this provision a device, and then the device malfunctions and I want to investigate it by decrypting the data - what's the process to decrypt it?
Thank you!

In order to decrypt in a RMA-style situation, you must record the device private key - and this can only be done as part of initial provisioning.
Automating this is on my roadmap. If you cannot wait for that release, add an additional fastboot command before setting the LED status: https://github.com/raspberrypi/rpi-sb-provisioner/blob/b8dfe1550e06f85aabddfb3ed59c4a81cd0e3ef2/service/rpi-sb-provisioner.sh#L872
Add something like:
fastboot getvar private-key > ${your_secure_key_material_storage}

Then, use that key as the LUKS passphrase when you mount the storage on a host. In practice, depending on the sort of failure involved, this may require you to dismount the eMMC and re-mount it on a media accessible by another machine.
As ever - this would have you capture sensitive key material - you must take precautions to prevent unauthorised and unnecessary accesses.

Thank you @tdewey-rpi - that's very helpful.
Is there any way to support such development to help accelerate delivery of such functionality?

Not directly, I'm afraid - but given your response I'm going to classify this issue as high priority, and apportion time accordingly.

If there's GitHub Sponsors / Open Collective / etc. setup for this project I'd be happy to sponsor some further development.
Either way, thank you for the information and all the work in creating this!

While I appreciate the thanks, I must point out that I'm a full-time employee of Raspberry Pi, and as such the knowledge that this will help our products better meet your needs is enough.


Windows 11

Does not follow terminal size
Freezes upon creation of timer check
Starter and timer files are not generated.

Bug only experienced on Windows 11

reorganized logic and removed screen size settings - screen size was causing issues in windows 11 (no actual fix found yet)


analyze by import identifier

It seems to recognize the module by its export identifier.
This is a bit odd.
Also, it adds an export { xxx }  to the analysis results, which is not needed for actual use, and does not indicate the exact size.

Could you please expand on this

@okikio For example, the following will result in a bundle result of 0.
Unused modules will be removed.
import { Result } from "https://deno.land/x/result_js/mod.ts";

This result is correct if i want to know the "bundled result".
My expectation was that the above example would allow me to measure the cost.
For example, the following is available: https://github.com/wix/import-cost
This is due to differences in project policies.
I realized that what I sought was not the role of this project.

In a future version this may be added as an extra feature, but as of right now you're correct it's a little bit out of scope.
The one thing you can try is to use the bundle analysis as a replacement for this feature https://twitter.com/okikio_dev/status/1523562099334541313?s=20&t=JPPB2KIF8Wv1tQrJI5rm7w
You can try out bundle analysis https://bundlejs.com/?q=deno:result_js/mod.ts&treeshake=[{+Result+}]&config={"analysis":true}

@okikio interesting!

^ It's not perfect, it doesn't give a perfect treeshake size

Indeed, the rendering of treemap seems to succeed only once in several times.


Update spelling in list.ex

Change passoword to password, since it shows up in hex docs

🚀 Thank you for your contribution! 🚀


MWPW-153245 [merch][analytics] dispatch wcomp events, and let default lh

dispatch merch wc shadow event for analytics,
if lh attribute is already set, keep it, appending eventually mep information,
also remove merch-sidenav dependency that is only consumed in CC atm,

Resolves: MWPW-136881
Test URLs:

Before: https://main--milo--adobecom.hlx.live/?martech=off

After: https://mwpw-153245--milo--npeltier.hlx.live/?martech=off

Before: https://main--cc--adobecom.hlx.live/products/catalog

After: https://mwpw-153245--cc--npeltier.hlx.live/products/catalog?milolibs=mwpw-153245--milo--npeltier

no "need" to resolve conflicts right now, as dep will be overwritten one last time once first approvals are made

@npeltier Can you plz review below:

Sort:Popularity event name is "authored--:sort|s2|all|nopzn|catalog-devicet" doesn't have keyword Popularity
Hover over action menu click on any card generates same event name without any product name i.e.
"merch-card:action-menu-toggle|s2|all|nopzn|catalog-devicet"

@Roycethan can you have a second look? (not sure why but search related network call happens much after it, but still does)

@npeltier Can you plz review below:

Sort:Popularity event name is "authored--:sort|s2|all|nopzn|catalog-devicet" doesn't have keyword Popularity
Hover over action menu click on any card generates same event name without any product name - for all the product cards i.e.
"merch-card:action-menu-toggle|s2|all|nopzn|catalog-devicet"
Search box - search doesn't triggered any events
Show more button not triggering analytics events - can be checked at https://main--cc--adobecom.hlx.live/products/catalog?milolibs=mwpw-153245--milo--npeltier#category=all
Product icon in the card which is clickable , same case with product name -
6)Learn more (link) - has daa-ll , but event name is not populated

Apart from above observation/issues , covered regressions.

@npeltier 1,2,4 are fixed... 3 ,5,6 are open

@npeltier Can you plz review below:

Sort:Popularity event name is "authored--:sort|s2|all|nopzn|catalog-devicet" doesn't have keyword Popularity
Hover over action menu click on any card generates same event name without any product name - for all the product cards i.e.
"merch-card:action-menu-toggle|s2|all|nopzn|catalog-devicet"
Search box - search doesn't triggered any events
Show more button not triggering analytics events - can be checked at https://main--cc--adobecom.hlx.live/products/catalog?milolibs=mwpw-153245--milo--npeltier#category=all
Product icon in the card which is clickable , same case with product name -
6)Learn more (link) - has daa-ll , but event name is not populated

Apart from above observation/issues , covered regressions.

@npeltier 1,2,4,5,6 are fixed... 3 is fixed


cmd/serve/restic: add append-only mode

This PR adds an optional append-only mode to the restic serve cmd, similar to the one implemented in restic's rest-server. Specifically, deletes to any resources that are not locks are disallowed.  For reference, here are the spots in the rest-server handlers where this is used:
https://github.com/restic/rest-server/blob/master/handlers.go#L233
https://github.com/restic/rest-server/blob/master/handlers.go#L527

Rclone will still allow objects to be overwritten. It used to have a check to disallow that but we decided it wasn't necessary. Do you need that for an append only mode?

Restic never overwrites existing objects so I think we should be fine as-is.

Thanks for clarifying that - it looks great :-)

Oh, thanks a lot for implementing this feature! For it to work correctly, we need to check that no files are overwritten. It's something that restic itself won't do, but it's relevant to the situation where the append-only mode is needed. I've described the scenario here: https://github.com/restic/caddy/issues/2#issuecomment-377768378 Attackers may very well talk to rclone directly and instruct it to overwrite files.
When attackers gained access to a server, they learn the credentials needed to access rclone (e.g. an SSH key or username/password for the REST server). Usually, this is enough for them to empty the repo and destroy all backups (after all, deleting files in the repo is needed for restic prune to work). When the append-only mode is used, attackers should not be able to delete any files in the repo. That's already implemented. However, with the current code, it's possible for attackers to overwrite existing files, for example with empty files. That will still destroy backups, which should be prevented in append-only mode. Hm.
The REST server we've implemented does not have such a check in the SaveBlobs function any more because it opens local files with O_EXCL. When the file already exists, the call to os.Open fails, so it's not possible to overwrite files.
We need to add this test to rclone, but it should only be active in append-only mode. Is there a way (with the FS implementation of rclone) to maybe simulate O_EXCL?
I've opened #2195 to track this issue.


[Swift 4.2] Updated Heap

Checklist

[x] I've looked at the contribution guidelines.
[x] This pull request is complete and ready for review.

Description

References #748. Makes it easier to find algorithms to update.

Thanks for the update 👍


Horizontal scroll appears when renaming nested elements

EPAM AI DIAL chat version
0.10.3
How to reproduce
Create a highly nested structure. Rename the bottom level.

Actual result

Expected result
No horizontal scroll
Confidential information

[X] I confirm that do not share any confidential information

Verified on staging env successfully. Verified conversation; the lowest level folder renaming in chats/prompts.


add "publish up" and "publish down" dates on widgets

this is a full implementation of the feature request #127

We released the Pagekit Beta today. I close this pull request because the code base completely changed. Please create a new one


Look_at not starting from the Node rotation

Godot version:
Godot 3
Issue description:
Look_at function should be start from the Node rotation .. not from 0 or 90
it should be smooth rotation
download the project and see
press the Arrow the move the Target , press Space bar to start looking at the target
it must start from the node rotation to be smooth rotation .. not from 0 or 90 degree
Minimal reproduction project:
Look_at.zip

Not sure if I understand the issue correctly, but look_at works in global coord system, so you need to use global positions. If you have direction then you need to do something like look_at(global_transform.origin + lookDir)

I think ghost wanted to have an "offset" for the node rotation applied after look_at(). Isn't this a matter of just calling look_at() then adding the angle you need to the rotation property every frame?

It's unclear what this issue is about and the author is no longer with us, so closing.
There is new lerp_angle() function that probably addresses it.


Update artemis-jms-client-all to 2.34.0

About this PR
📦 Updates org.apache.activemq:artemis-jms-client-all from 2.19.1 to 2.34.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.activemq", artifactId = "artemis-jms-client-all" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.apache.activemq", artifactId = "artemis-jms-client-all" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #444.


[Editor] Fix cursor up/down navigation

Lines are skipped when navigating up/down

Cursor does not preserve x coordinate when moving over shorter lines

It finally works! 🎉

To debug the problem, we first created a tool:

This tool allowed us to reproduce the problem. Here we see how moving up from the red place (the left most side of the line) will incorrectly make the cursor skip two lines:

The problem was that the algorithm mistakenly tried to find the closest distance by comparing the distance from the red to the center of the surrounding elements. Once the problem was fixed, it looked like this:

Interestingly, adornment elements can make cursor stuck 😃


Add some improvements for pipeline module, engine and assertion into ds engine

There are some improvements.

Improve error message of pipeline engine. see https://github.com/microsoft/DeepSpeed/pull/1438
Move has_bool_tensors to kwargs to make usable with deepspeed.initialize and rename has to send. see https://github.com/microsoft/DeepSpeed/pull/1399
Add assertion to DS engine. see https://github.com/microsoft/DeepSpeed/issues/1034
Add @property to make module.mpu usable.

when we use PipelineEngine, we use syntax like engine.mpu. but when we use PipelineModule we must use module.mpu(). this can be confusing front end users.
So, I added @property to make module.mpu usable. We can use same syntax like something.mpu.
I also added __call__() method to PipelineParallelGrid to be compatible with exsting code

cc. @tjruwase

I can't understand why formatting CI was failed... 😂

AssertionError: At least one of the `optimizer` and `model_parameters` must be input to train the model.

we should modify test code

Can one of the admins verify this patch?

Hi @hyunwoongko - apologies for taking so long to reply to this.  Is this still a branch you'd like to see merged?  If so, could you resolve merge conflicts?  If not, we're closing and cleaning up old branches in the repo.


Iterator implementations are unable to satisfy Iterator interface

I am pretty much unable to implement to implement iterator that would satisfy flow, here is an example code inlined below for convenience
class FilteredIterator  {
  p:(input:a) => boolean
  source:?Iterator
  @@iterator() {
    return this
  }
  next() {
    const {source, p} = this
    while (source) {
      const result = source.next()
      if (result.done) {
        this.source = null
        break
      } else {
        const {value} = result
        if (p(value)) {
          return {value, done:false}
        }
      }
    }
    return {done:true}
  }
}

export const filter =  (p:(input:a) => boolean, iterator:Iterator):Iterator => {
  const filtered = new FilteredIterator
  filtered.source = iterator
  filtered.p = p
  return filtered
}

Flow reports following error:
    return {value, done:false}
                         ^ object literal. This type is incompatible with
    [LIB] static/v0.41.0/flowlib/core.js:531:   | { done: false, value: Yield };
                                                  ^ object type

You have to add some explicit annotations:
class FilteredIterator  {
  p:(input:a) => boolean
  source:?Iterator
  @@iterator(): $Iterator { // <-- HERE
    return this
  }
  next():IteratorResult { // <-- AND HERE
    const {source, p} = this
    while (source) {
      const result = source.next()
      if (result.done) {
        this.source = null
        break
      } else {
        const {value} = result
        if (p(value)) {
          return {value, done:false}
        }
      }
    }
    return {done:true}
  }

Thanks @vkurchatkin, that does indeed fixes it! Never the less isn't flow's inability to infer this is still a bug ? For the very least please consider amending error messages with suggestion to add explicit annotations.

Also worth noting that if I do entype base class all subclasses still need explicit annotations or they still fail to type check.


Correcting the end tag for http block

#Bugfix
Http Redirect code snippet (https_redirect_all) is outside the disable_http block.
Due to this, it is not possible to disable http interface.

Thanks! Can you add release notes for this using your comment in the ci/release_notes.md file?

@geofffranks included the release_notes, request you to take a look again.

Final release 8.0.3 created today with this in it.


Fix MQTT binary switch

Description:
I was getting this in my log files:
2018-11-12 00:21:26 WARNING (MainThread) [homeassistant.core] Unable to remove unknown listener <function async_track_point_in_utc_time.<locals>.point_in_time_listener at 0x102948378>
After some analysis I reached binary_sensor/mqtt line 157 where an async callback was supposed to be called in order to cancel an evt.async_call_later.
The proper fix would have been to await for self._delay_listener() but we are outside async function.
This patch fixes the warning, but I'm not sure if it is the right approach 😞
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):
binary_sensor:
  - platform: mqtt
    state_topic: "test/1"
    payload_on: 1
    payload_off: 0
    name: test_mqtt_delay_off
    device_class: motion
    off_delay: 5

mosquitto_pub -h <IP_ADDRESS> -t test/1 -m 1 && mosquitto_pub -h <IP_ADDRESS> -t test/1 -m 0

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

but setting the callback to None was part of the callback. 🤷♂
It does work 😄


Not for 4.2.2

It's not working in 4.2.2 but works in other versions of Godot can you please update <3

Hmm, it sure doesn't work for 4.2.2 anymore, I can't remember what changed offhand. I think it's something to do with how the raycast is being handled.
I imagine the solution here will be to create an if/else together with get_version_info inside the method perform_raycast_with_exclusion in script scene_builder_dock.gd, but I'm not sure. I'll have to spend a bit more time on this soon.
I'm currently working in 4.3.rc1, though I would not recommend this version. There's was a performance reimport regression, though that seems to already be fixed in 4.3rc3, which I will be upgrading to soon!

sounds good thanks for responding!

Thank you so much Guilherme, looks great! The whitespace changes are definitely appreciated as well, I didn't mean to stray from GDScript convention.
Please reopen the issue if there's still a problem @Puklinae!


Implement Service Method Generation Control

Allow users to specify which methods they would like to generate for a gRPC service.

Hey @JeremyV2014,
Thanks for working on this!
A few things:
Define the method enums with1 << iota like in https://github.com/ent/ent/blob/3ba2b4e1737a4db1cb7ee9b81c7bff5961f515fa/ent.go#L354-L360
For example, https://play.golang.org/p/HiXdR5Ck1Ni
How about making the API:
// only render Get and Delete
entproto.Service(
  entproto.Methods(entproto.MethodGet | entproto.MethodDelete)
)

// render all
entproto.Service(
  entproto.Methods(entproto.MethodAll)
)

// default behavior equivalent to MethodAll
// to make this work you will need to use the functional options pattern
entproto.Service()

The implementation looks right, thanks! Please add tests?

Please add tests?

To internal/entprototest/service_test.go?

Also notice that CI is failing

Looks like I'm missing copyright headers in the new files.

Also if you can, please update the README file for entproto (in a separate PR is fine)

Should entproto.Service() get a higher header level? It seems like this is quite a bit of information to add to that section.

update the gRPC documentation on the ent site (also in a separate PR).

How would you like this introduced on the website? Are you thinking of a new page discussing method generation options for services? I could walk through modifying the User service to generate only Get and Create methods. This could become the last page for the gRPC tutorial. It could be called "Service Generation Options" or something like that.


'Runtime Error: revert' - when creating contract from contract

Hello, I have this basic contracts in solidity but when i try to create a contract from another contract I have this 'Runtime Error: revert'
// SPDX-License-Identifier: GPL-3.0
pragma solidity >=0.6.0 <0.9.0;
contract User {
string public name;
constructor(string memory _name) public payable {
name = _name;
}
function getUserName() public view returns(string memory _name) {
return name;
}
}
contract Users {
User[] public users;
User public user;
function create(string memory _name) public {
User user = new User(_name);
}
function getUsers() public view returns (User[] memory _users) {
return users;
}
function getUser() public view returns (User _user) {
return user;
}
}

What's the error?

Hello, I have this basic contracts in solidity but when i try to create a contract from another contract I have this 'Runtime Error: revert'
// SPDX-License-Identifier: GPL-3.0
pragma solidity >=0.6.0 <0.9.0;
contract User {
string public name;
constructor(string memory _name) public payable {
name = _name;
}
function getUserName() public view returns(string memory _name) {
return name;
}
}
contract Users {
User[] public users;
User public user;
function create(string memory _name) public {
User user = new User(_name);
}
function getUsers() public view returns (User[] memory _users) {
return users;
}
function getUser() public view returns (User _user) {
return user;
}
}

I was interested in this issue as it sounds like (but may not be) related to a new issue I recently opened https://github.com/trufflesuite/ganache-cli/issues/827#issue-891337412.

I was interested in this issue as it sounds like (but may not be) related to a new issue I recently opened #827 (comment).

I was able to fix it, it seems it was related with the solidity version I was using on my smart contracts.
With this config on the top of the smart contract everything seems fine.
// SPDX-License-Identifier: MIT
pragma solidity >=0.4.22 <0.9.0;
Cheers! :P

@tapmapp Thanks for the suggestion. Unfortunately, it didn't seem to resolve my issue so assuming it is unrelated.


DEX Trades: SELL displayed as BUY in SCAN

Displayed correctly in mobile wallet, but DEX Trades SELL displayed as BUY
the 40 sells at 451 ,  display as BUY in Scan

Update column to "Taker side" to remove the confusing.

solved


Add Zhejiang University City College

add Zhejiang University City College
Here are the requested links:
Official web page 浙江大学城市学院
Other proofs :
Wiki about Zhejiang University City College（Chinese Simplified）
The email web page of Zhejiang University City College
Thank you!

@HDsky Pull request merged. Thank you!


Corrects four signal routes which were missing from the caravan top level

Corrects four signals which were missing from the caravan top level
(management output and output enable to GPIO 0 and 1---these errors
would have prevented the houskeeping SPI from working on caravel).
Corrected RTL verilog (source of the error), GL verilog, and layout.

Note:  This error was undetected because there is no testbench designed specifically to check the operation of the housekeeping SPI on caravan.  Ideally, we should have duplicates of every caravel testbench for caravan.


make Layer.redraw not unconditionally set zoomChanged to true when calling Layer.moveTo

This pull request supersedes #36, and fixes the issue reported there. It also addresses a 5-year old comment from @schuyler: http://trac.osgeo.org/openlayers/changeset/1448.
Tests pass in FireFox 8.0.1.

Closing. Commit range is wrong.


WIP: Try CRI-O v1.30

What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Refers to https://github.com/kubernetes-sigs/security-profiles-operator/pull/2444
Which issue(s) this PR fixes:

None
Does this PR have test?
None

Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.85%. Comparing base (11d77f4) to head (1f04353).
Report is 418 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2449      +/-   ##
==========================================
- Coverage   45.50%   41.85%   -3.65%
==========================================
  Files          79      109      +30
  Lines        7782    16013    +8231
==========================================
+ Hits         3541     6702    +3161
- Misses       4099     8814    +4715
- Partials      142      497     +355


wrangler: support darwin and arm64

Description of changes

Followup on #272014 adding support for the other supported platforms
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 272211 run on x86_64-linux 1

If anyone with a non-aarch64 darwin machine could try this to make sure I got the correct hash with my command that would be great, otherwise I'm going to merge this in a couple of hours

Got my x86 darwin machine running as well and it works as expected, going to merge this


Can't pay trough Request Finance app

We have implemented Request Finance to pay our contractors throughout the app, yet it isn't working.
You'll see that our ledger address (top right) is connected but it looks like is trying to send it from a different one.
Furthermore, if you go to Manage Safe Owners it shows 3 different addresses that we do not recognise and we cant change nor remove.
Could you please provide further assitance?
I appreciate it.
See prints below:

It seems to me that your ledger (0xf18...) is not an owner of the Safe.

Please use the chat in the bottom right on https://gnosis-safe.io/ for support queries


Doesn't seem to understand "through" relationships

The model:
defmodule Database.Models.Account do
  @moduledoc false
  use Ecto.Schema
  import Ecto.Changeset

  @primary_key {:id, :binary_id, autogenerate: true}
  @foreign_key_type :binary_id
  schema "accounts" do
    has_many(:organization_memberships, Database.Models.OrganizationMembership)
    has_many(:organizations, through: [:organization_memberships, :organization])
  end

  @spec data :: Dataloader.Ecto.t()
  def data() do
    Dataloader.Ecto.new(Database.Repository)
  end
end

The type:
defmodule Graphql.Types.Account do
  @moduledoc false
  use Absinthe.Schema.Notation
  import Absinthe.Resolution.Helpers

  object :account do
    field :id, non_null(:id)
    field :organizations, list_of(:organization),
      resolve: dataloader(Database.Models.Organization)
  end
end

The context with dataloader
def context(context) do
  context
  |> Map.merge(%{
    loader: Enum.reduce(
      [
        Database.Models.Account,
        Database.Models.Organization
      ],
      Dataloader.new(),
      fn model, loader -> Dataloader.add_source(loader, model, model.data()) end
    )
  })
end

The exception:
attempting to cast or change association `organization_memberships` from `Database.Models.Account` that was not loaded. Please preload your associations before manipulating them through changesets

I attempted to also add dataloader sources for OrganizationMembership, but that didn't change anything.

Hey @krainboltgreene I'm a bit confused. It is not particularly normal to do a source for each Ecto schema, usually you use one source per context or database.
Can you provide the full stacktrace or an executable example?

This was largely my attempt at understanding the dataloader integration, so I might have gotten it very wrong, but I was able to do accounts->some_other_relationships just fine in other requests, which is why I thought I got it right.
Here's the stack trace:
[error] #PID<0.830.0> running ClumsyChinchillaWeb.Endpoint (connection #PID<0.724.0>, stream id 2) terminated
Server: <IP_ADDRESS>:4000 (http)
Request: POST /graphql
** (exit) an exception was raised:
    ** (RuntimeError) attempting to cast or change association `organization_memberships` from `Database.Models.Account` that was not loaded. Please preload your associations before manipulating them through changesets
        (ecto 3.4.6) lib/ecto/changeset/relation.ex:80: Ecto.Changeset.Relation.load!/2
        (ecto 3.4.6) lib/ecto/changeset/relation.ex:500: anonymous fn/4 in Ecto.Changeset.Relation.surface_changes/3
        (elixir 1.10.3) lib/enum.ex:2111: Enum."-reduce/3-lists^foldl/2-0-"/3
        (ecto 3.4.6) lib/ecto/changeset/relation.ex:489: Ecto.Changeset.Relation.surface_changes/3
        (ecto 3.4.6) lib/ecto/repo/schema.ex:235: Ecto.Repo.Schema.do_insert/4
        (absinthe 1.5.2) lib/absinthe/resolution.ex:209: Absinthe.Resolution.call/2
        (absinthe 1.5.2) lib/absinthe/phase/document/execution/resolution.ex:230: Absinthe.Phase.Document.Execution.Resolution.reduce_resolution/1
        (absinthe 1.5.2) lib/absinthe/phase/document/execution/resolution.ex:185: Absinthe.Phase.Document.Execution.Resolution.do_resolve_field/3
        (absinthe 1.5.2) lib/absinthe/phase/document/execution/resolution.ex:170: Absinthe.Phase.Document.Execution.Resolution.do_resolve_fields/6
        (absinthe 1.5.2) lib/absinthe/phase/document/execution/resolution.ex:88: Absinthe.Phase.Document.Execution.Resolution.walk_result/5
        (absinthe 1.5.2) lib/absinthe/phase/document/execution/resolution.ex:67: Absinthe.Phase.Document.Execution.Resolution.perform_resolution/3
        (absinthe 1.5.2) lib/absinthe/phase/document/execution/resolution.ex:24: Absinthe.Phase.Document.Execution.Resolution.resolve_current/3
        (absinthe 1.5.2) lib/absinthe/pipeline.ex:368: Absinthe.Pipeline.run_phase/3
        (absinthe_plug 1.5.0) lib/absinthe/plug.ex:445: Absinthe.Plug.run_query/4
        (absinthe_plug 1.5.0) lib/absinthe/plug.ex:258: Absinthe.Plug.call/2
        (phoenix 1.5.4) lib/phoenix/router/route.ex:41: Phoenix.Router.Route.call/2
        (phoenix 1.5.4) lib/phoenix/router.ex:352: Phoenix.Router.__call__/2
        (clumsy_chinchilla 1.0.0) lib/clumsy_chinchilla_web/endpoint.ex:1: ClumsyChinchillaWeb.Endpoint.plug_builder_call/2
        (clumsy_chinchilla 1.0.0) lib/plug/debugger.ex:132: ClumsyChinchillaWeb.Endpoint."call (overridable 3)"/2
        (clumsy_chinchilla 1.0.0) lib/clumsy_chinchilla_web/endpoint.ex:1: ClumsyChinchillaWeb.Endpoint.call/2

It looks like this was related to me doing an insert when I should be doing an update?


can't install this package

Hey! This module looks nice!
I was just trying to install it, but it failed to download (see error message below). I tried it on different machines and also on a co-workers machine. I think the problem is that this repo is named differently than the repo in elm-package.json. So I think the solution would be to rename this repo to match elm-package.json.
Thanks 😻
❯ elm-package install wernerdegroot/listzipper
Some new packages are needed. Here is the upgrade plan.

  Install:
    wernerdegroot/listzipper 1.0.2

Do you approve of this plan? [Y/n] y
Starting downloads...

  ✗ wernerdegroot/listzipper 1.0.2
Error: Problem when downloading the wernerdegroot/listzipper 1.0.2 code.

I've renamed the repo (all lowercase characters now). Does that fix your problem?

Yes, it works now!
Thanks for the fast response.

I think that it must be an 0.17 thing, as this never appeared to be a problem with me in Elm 0.16


UI for Google Sign in

This ticket is to keep track of the UI component for https://github.com/rancher/rancher/issues/1411

Version: master-head (v2.3) (7/8/19) (latest UI)
Step 2 first copy to clipboard includes http:// protocol - is there a way to prevent this? We should only be copying the IP/rancher domain to clipboard not http.

When I paste the content I get this in the Google UI (and have to manually remove the protocol)

Also Google requires proper domains/fqdns you cannot use an IP address. It would be nice to warn the user about this in my opinion.
More testing to be done later, just noticed this.

https://github.com/rancher/rancher/issues/21511 fixes some en-us translations (help text, instructions, etc).
I have tested basics, next up is to test with various users, some RBAC checks, etc.

Version: master-head (7/16/19)
Initial testing has been completed. Further testing will be more thorough following our internal test plan.
I was successfully able to follow the steps outlined and set up Google auth and leverage it. I made some tweaks to instructions in issue #21511 and this is now merged in. This should help to make things a little more clear to end users. Once we have docs in, we may tweak this again later especially with regards to step four which has some extra steps in various areas.


incorrect calling # of SNPs

Hi,
Tried to validate SKA2 to current methods by comparing clustering abilities using this dataset:
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC8549354/. Supplementary tabel S2 contains detailed info.
tried various filter settings (little effect), K 31 and default (17 I believe) with major effect.
according to clustering reported in the paper, there should be plenty of clusters (even according to SKA1) but now the lowest has a few hundred SNPs. should I then use <1000 snps as a cut-off for calling identical? seems very odd. Advice is appreciated.
thanks,
Pieter
k-31 output:
Sample1	Sample2	Distance	Mismatches
VRE01	VRE02	253.00	0.01965
VRE01	VRE03	285.67	0.02038
VRE01	VRE04	301.67	0.02102
VRE01	VRE05	2093.25	0.22315
VRE01	VRE06	2281.50	0.26828
VRE01	VRE07	2271.00	0.26410
VRE01	VRE08	2292.17	0.26630
VRE01	VRE09	2711.08	0.32633
VRE01	VRE10	2408.00	0.31685
VRE01	VRE11	2137.67	0.27616
VRE01	VRE12	247.50	0.01924
VRE01	VRE13	2301.67	0.28808
VRE01	VRE14	2272.50	0.26346
VRE01	VRE15	2242.00	0.26199
VRE01	VRE16	229.33	0.00975
k-17 output:
Sample1	Sample2	Distance	Mismatches
VRE01	VRE02	938.00	0.01617
VRE01	VRE03	988.25	0.01657
VRE01	VRE04	1020.25	0.01717
VRE01	VRE05	4294.58	0.19870
VRE01	VRE06	4780.00	0.24028
VRE01	VRE07	4748.33	0.23723
VRE01	VRE08	4799.83	0.23887
VRE01	VRE09	5553.08	0.29795
VRE01	VRE10	5094.67	0.29039
VRE01	VRE11	4423.75	0.24879
VRE01	VRE12	938.33	0.01582
VRE01	VRE13	4976.08	0.26186
VRE01	VRE14	4758.83	0.23660
VRE01	VRE15	4664.83	0.23577
VRE01	VRE16	937.50	0.00718
code and v output below.
(base) pietersmit@mbpvanpieter2 VRE dataset % ska build -f samples.tsv -k 31 -o KP_ska_index --min-count 3 --threads 4
SKA: Split K-mer Analysis (the alignment-free aligner)
SKA done in 288s
⬛⬜⬛⬜⬛⬜⬛
⬜⬛⬜⬛⬜⬛⬜
(base) pietersmit@mbpvanpieter2 VRE dataset % ska distance -o distances2.txt KP_ska_index.skf --filter-ambiguous
SKA: Split K-mer Analysis (the alignment-free aligner)
SKA done in 7s
⬛⬜⬛⬜⬛⬜⬛
⬜⬛⬜⬛⬜⬛⬜
(base) pietersmit@mbpvanpieter2 VRE dataset % ska build -f samples.tsv -o KP_ska_index --min-count 3 --threads 4 -v
SKA: Split K-mer Analysis (the alignment-free aligner)
2024-09-16T10:26:29.294Z INFO  [ska] k=17: using 64-bit representation
2024-09-16T10:26:29.294Z INFO  [ska::merge_ska_dict] Building skf dicts from sequence input
2024-09-16T10:26:29.294Z INFO  [ska::merge_ska_dict] FASTQ files filtered with: min count: 3; minimum quality 20 (5); filter applied: Whole k-mer quality filtering
2024-09-16T10:26:29.295Z INFO  [ska::merge_ska_dict] Build and merge skf dicts in parallel using 4 threads
2024-09-16T10:31:42.224Z INFO  [ska::generic_modes] Converting to array representation and saving
SKA done in 315s
⬛⬜⬛⬜⬛⬜⬛
⬜⬛⬜⬛⬜⬛⬜
2024-09-16T10:31:44.956Z INFO  [ska] Complete
(base) pietersmit@mbpvanpieter2 VRE dataset % ska distance -o distances3.txt KP_ska_index.skf --filter-ambiguous -v
SKA: Split K-mer Analysis (the alignment-free aligner)
2024-09-16T10:32:07.749Z INFO  [ska::generic_modes] Applying filters: threshold=0 constant_site_filter=No constant sites filter_ambig_as_missing=false ambig_mask=false no_gap_only_sites=false
2024-09-16T10:32:08.405Z INFO  [ska::merge_ska_array] Filtering removed 2057265 split k-mers
2024-09-16T10:32:08.405Z INFO  [ska::generic_modes] Applying filters: threshold=0 constant_site_filter=No constant sites or ambiguous bases filter_ambig_as_missing=false ambig_mask=false no_gap_only_sites=false
2024-09-16T10:32:08.889Z INFO  [ska::merge_ska_array] Filtering removed 13568 split k-mers
2024-09-16T10:32:08.889Z INFO  [ska::generic_modes] Calculating distances
SKA done in 6s

(base) pietersmit@mbpvanpieter2 VRE dataset % ska -V
ska 0.3.10

Some initial thoughts:

There are more filtering options you could include, see this post: https://www.bacpop.org/guides/snp_alignment_with_ska/. Have a look at the alignments produced by ska align in e.g. seaview too, to see if you have obvious problems with gaps or ambiguous sites.
Also see the --min-freq filter, 0.9 is a sensible default. I think ska distance supports this, but if not you can run ska weed on your skf file first.
If you also have assemblies available, it might be sensible to validate that your filtering of the fastq data was sufficient by doing a build with fasta input too.

thanks for prompt reply!
ran align as suggested (ska align --no-gap-only-sites --filter-ambig-as-missing --filter no-ambig-or-const KP_ska_index.skf >VRE.fa), doesnt seem to be too odd (see 2 printscreens below).

also attached the fasta file below.
when running distance again with your suggestion, -v showed this:
pietersmit@mbpvanpieter2 VRE dataset % ska distance -o distances5.txt KP_ska_index.skf --filter-ambiguous --min-freq 0.9 -v
SKA: Split K-mer Analysis (the alignment-free aligner)
2024-09-16T13:40:36.837Z INFO  [ska::generic_modes] Applying filters: threshold=36 constant_site_filter=No constant sites filter_ambig_as_missing=false ambig_mask=false no_gap_only_sites=false
2024-09-16T13:40:37.260Z INFO  [ska::merge_ska_array] Filtering removed 1978942 split k-mers
2024-09-16T13:40:37.260Z INFO  [ska::generic_modes] Applying filters: threshold=36 constant_site_filter=No constant sites or ambiguous bases filter_ambig_as_missing=false ambig_mask=false no_gap_only_sites=false
2024-09-16T13:40:37.313Z INFO  [ska::merge_ska_array] Filtering removed 1229 split k-mers
2024-09-16T13:40:37.313Z INFO  [ska::generic_modes] Calculating distances
we got the output lowered (to almost a reasonable number) but is still way to high for what is expected. there are no other filter options with distance as far as --help stated. below the top of the output file.
Sample1	Sample2	Distance	Mismatches
VRE01	VRE02	128.50	0.00055
VRE01	VRE03	129.50	0.00055
VRE01	VRE04	131.50	0.00055
VRE01	VRE05	1263.50	0.01216
VRE01	VRE06	1902.00	0.00058
VRE01	VRE07	1901.00	0.00054
VRE01	VRE08	1901.00	0.00050
VRE01	VRE09	2133.67	0.02631
VRE01	VRE10	2083.50	0.01599
VRE01	VRE11	1760.00	0.01124
VRE01	VRE12	127.00	0.00055
VRE01	VRE13	1912.50	0.00050
VRE01	VRE14	1912.00	0.00050
VRE01	VRE15	1890.00	0.00212
VRE01	VRE16	27.50	0.00057
suggestions are welcome why this is not 0 snps as expected. thanks!
VRE.txt

suggestions are welcome why this is not 0 snps as expected. thanks!

Can you clarify why zero SNPs are expected here? I've only had a quick scan of the paper and supplementary table you mention, but it only looks like some are expected to be in the same sequence type (which is usually within ~0.5% genome divergence, which can be thousands or tens of thousands of SNPs).

regarding the issue associated with distance estimates, I believe it corresponds to a previous reported issue: https://github.com/bacpop/ska.rust/issues/69
These distances might be overestimated due to ambiguous nucleotides (a gut feeling; I've checked in details). According to the alignment, the distance VRE01 VRE02 should be 4 or 5, not 128.

nb: according to Table 4 of this paper, VRE1-VRE2-VRE3-VRE4 are part of a 5-SNPs cluster.

another example and a possible solution
Here is a skf file built from 55 Mtb isolates belonging to the same 12-SNPs cluster of transmission (available here: https://drive.google.com/drive/folders/1OWEQtq0UdnzZMPEIi-X0O_wxqEPn1mOo?usp=sharing). The SNP alignment is composed of about 90 SNPs, with lot of isolates separated by 0,1,2 or 3 SNPs.
When distances are computed with the command 'ska distance out_4.8.2.skf --filter-ambiguous', distances are here again a bit overestimated, with distances ranging from 5.25 to 31. Here are the first 12 lines of the output:

Sample1	Sample2	Distance	Mismatches
ERR046926	ERR072044	6.75	0.01393
ERR046926	ERR072046	7.75	0.01682
ERR046926	ERR072047	6.75	0.01323
ERR046926	ERR072048	8.75	0.01371
ERR046926	ERR2512672	7.50	0.01736
ERR046926	ERR2513864	11.50	0.01256
ERR046926	ERR2513968	10.50	0.01258
ERR046926	ERR2514094	9.50	0.02025
ERR046926	ERR2514103	13.50	0.01257
ERR046926	ERR2514145	9.25	0.01262
ERR046926	ERR2514147	9.25	0.01275
ERR046926	ERR2514208	11.50	0.01266

My assumption was that the '--filter-ambiguous' argument was incorrectly passed on to the function variant_dist in the merge_ska_array.rs. Therefore, I modified the following code from the file generic_modes.rs (starting at line 142; modifications correspond to 2 'true' and original code in comments):
let mask_ambig = false;
let ignore_const_gaps = false;
let filter_ambig_as_missing = false;
let constant = apply_filters(
    ska_array,
    min_freq,
    filter_ambig_as_missing,
    &FilterType::NoConst,
    mask_ambig,
    ignore_const_gaps,
);
if filt_ambig || (min_freq * ska_array.nsamples() as f64 >= 1.0) {
    if filt_ambig {
        apply_filters(
            ska_array,
            min_freq,
            true,  //filter_ambig_as_missing,
            &FilterType::NoAmbigOrConst,
            true,  //mask_ambig,
            ignore_const_gaps,
        );
    } else {
        apply_filters(
            ska_array,
            min_freq,
            filter_ambig_as_missing,
            &FilterType::NoFilter,
            mask_ambig,
            ignore_const_gaps,
        );
    }
}

After recompiling ska, I now obtain distances ranging from 0 to 19, with lot of distances between 0 and 3 as expected. A few distances are still decimals (eg, 4.75) but it isn't too surprising since the SNP alignment contains a few ambiguous nucleotides. Here are the first 12 lines of the output:

Sample1	Sample2	Distance	Mismatches
ERR046926	ERR072044	3.00	0.01393
ERR046926	ERR072046	4.00	0.01682
ERR046926	ERR072047	3.00	0.01322
ERR046926	ERR072048	5.00	0.01371
ERR046926	ERR2512672	3.00	0.01736
ERR046926	ERR2513864	7.00	0.01256
ERR046926	ERR2513968	6.00	0.01258
ERR046926	ERR2514094	5.00	0.02025
ERR046926	ERR2514103	9.00	0.01257
ERR046926	ERR2514145	4.75	0.01262
ERR046926	ERR2514147	4.75	0.01274
ERR046926	ERR2514208	7.00	0.01266

@johnlees, could this be a solution?

Yeah thanks Romain, this looks like the right fix. I'll try and get this in and document this clearly next week

nice!
question; if you filter ambiguous nucleotides, how come you still have ambiguous nucleotides in your outcome, Romain?

@PWSmit This fix essentially mimics the 2 arguments "--filter-ambig-as-missing --filter no-ambig-or-const" of the module ska align (see the post pointed out by John). Here, distances ignore:
_ split k-mers that contain a lot of ambiguous nucleotides (ie, spit k-mers repeated in the genome) by considering ambiguous nucleotides as missing data -> split k-mers ignored due to the --min-fre filter
_ split k-mers that contain middle base differing solely by the presence of an ambiguous character or absent in one sample (ie, no ATGC variation).
Therefore, this filtering only keeps split k-mers with ATGC variations, excluding positions with lot of ambiguous nucleotides, similar to the alignment you posted. However, there can also be ambiguous nucleotides in these split kmers ... see VRE26 in your alignment (probably a mixture of strains). Does this explanation help?

I appreciate the use in ska distance is quite misleading at present, as the filters are based on ska align. Really I think we just want to be able to filter on split k-mer frequence and whether to include ambiguous bases or not. I will address this in #82


Fix source control hooks

The module.xml explicitly says where in the source workspace the DeepSee resources live. This allows the source control extension to export them to the right place when you edit.

Thank you @isc-pbarton !
This helps.
Though Directory for pivots doesn't make sense as git source control doesn't work for pivots in Analyzer


Keyboard layout widget is practically unusable

The current query delay in the keyboard layout widget is too long.
If I change the layout, the widget will not reflect the change for a long time, a better way to do this would be to listen to the system event of keyboard layout change and only update then.
In my fork I just changed it to 1 second refresh rate, which is very inefficient

This could help
https://stackoverflow.com/a/15169594

Yes this widget could really be improved, I'll look into it, thanks! :)

Eagerly waiting for this feature/enhancement.

This could help
stackoverflow.com/a/15169594

Looks great!

I'm closing this issue in favor of this one (#205). A system that would allow to trigger refresh on a specific widget like the keyboard one would resolve the issue.


[compiler] VM translation of Module to bytecode crashes

What happened?
I got a segfault in mlir::iree_compiler::IREE::VM::translateModuleToBytecode.
Here is a vm-translate-to-bytecode-crash.zip.
Steps to reproduce your issue
Use compile.sh in the ZIP.
What component(s) does this issue relate to?
Compiler
Version information
#18217
Additional context
No response

It turned out that I had missing dialect_resources. program-with-dialect-resources.zip has the missing IR.
During verification of util.global we should probably check if the referenced resource is missing.
util.global private @__constant_tensor_4x6x5x5xf32 {inlining_policy = #util.inline.never, stream.affinity.default = #hal.device.affinity<@__device_0>} = dense_resource<torch_tensor_4_6_5_5_torch.float32> : tensor<4x6x5x5xf32>

Ah yeah, someone hit this the other day when they incorrectly deleted required resources. MLIR should be checking this kind of thing, if anything - resources are an MLIR concept. Globals aren't enough to validate as any op can reference resources.


UI: Multi-row contact list for home section?

Sorry for double posting but initially I posted my suggestion in https://github.com/vector-im/riot-web/issues/2984#issuecomment-354194839 and then was asked to post it under https://github.com/vector-im/riot-android/issues/1800 which is closed now redirecting to the place were I came from.
Would you add an option to list users and rooms in home section of Riot Android/iOS not in this (current) way...
PEOPLE
1 2 3 4 5 6 7 8 9 10

ROOMS
A B C D E F G H I J

...but in this way:
PEOPLE
1 2 3 4 5
6 7 8 9 10

ROOMS
A B C D E
F G H I J

...so that all PEOPLE and ROOMS listed in more than one horizontal line so that the user is not forced to scroll horizontally?
The current way is quite confusing because users are more used to scroll vertically (as they are used to do reading a chat: scrolling vertically).
More than one time people asked me: where are my contacts and rooms (after adding more and more contacts)?
Thx for Matrix and Riot!
Edit: just suggested https://github.com/vector-im/riot-web/issues/2984#issuecomment-392200590 which I would like to see in addition. Even a combined list for/merge of PEOPLE and ROOMS should be listed in multiple rows, not in one.

Hi, #1800 has not been closed, I close this one as a duplicate then


Update 0.1.5 & noarch

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Fixes #18

@conda-forge-admin, please rerender


fix: handle "receiver" in paymentSuccesNotification if used via popup #770

After looking at this please take a look at #1339 and merge that one first if possible.
Describe the changes you have made in this PR

For Send - LNURLPay/confirmPayment do not provide an Origin
Hide PublisherCard if no Origin is set
Handle lnAddress independent of PublisherCard
Payment success notification only shows receiver if available
Location in TransactionList will only be shown if available

Link this PR to an issue
#770
Type of change (Remove other not matching type)

fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes (If any)

Via https://webln.twentyuno.net/invoice:

Via twitter:

How has this been tested?
manually and added a basic unit-test for the success notification
Checklist

[x] My code follows the style guidelines of this project and performed a self-review of my own code
[x] New and existing tests pass locally with my changes
[x] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@dvoroneca is this payment confirmation screen ok for now?

Yes, it looks a bit empty. Here is a confirmation card design proposed in the 1-click pay flow.


Not an issue, so much as some questions

I saw your reference to reflection_factory in a thread about the dart:mirror module.
I have two questions:

can reflection_factory be used as a replacement for json_serializable?
if yes, will "dart compile exe" fail if I use your reflection_factory the way it does when using json_serializable?
if no, (I doubt this) could importing reflection_factory, cause json_serializable to no longer cause this compilation issue?

You can see my use case in a comment below yours.
Thanks

I use 'reflection_factory' with a project that is compiled with 'dart compile exe' and also another that compiles to JS/Web.


Add the Durango platform.

The Durango platform is used by the Xbox One.
This platform currently differs from the Windows platform only in that
it does not support the SystemTimeToTzSpecificLocalTime API.

Looks good to me - ready to be merged?

Ready when you are.

Ok, thanks!


Smarti Solr search keyword wrap issue in rocket chat

Issue Background:
A horizontal scroll bar was displayed in the smarti side bar container when the solr search keyword is long which leads to misalignment due to text overflow.

Expected Behavior:
The keyword must be wrapped to fit in the container, thus would be appropriate.

see also redlinkgmbh/smarti#128


Search not working to well

When I try and search for a style in our style guide it returns unexpected results. For example if I search for button instead of showing the section titled button it shows me the section titled colors. Is there something specific I need to do to make our styles more search friendly?

Is this the only (wrong) result (with no good result) or are they both part of the list of results, with a numerical sort which makes (for example) 1.1 Colors display before 2.2 Buttons?


Allow editing petition even if petition is already live

I moved the 'Edit petition' link down to the list of petition actions - wdyt?

Ah, I left it next to the petition text to keep it consistent with how it appears in the moderation view. Can we keep it like that?

@henryhadlow sure - I'll move it back


Persistence

Hey i have some problems with persistence first of all how can i make sure that the meterpreter will back to me when ever i want..(hiw to make persistence)?
Second when i am not connected to the victim via meterpreter the puffader code does not work and does not send the logs to email ( or the meterpreter and puffader work together or they r just dont work..)
Any ideas?
For the second thing i think its only for me because i dont think we need to have access to the victim with meterpreter to receive logs to email cause we cant control 10 slaves in 1 time.. so puffader should work even if i dont connected to the victim...

Ok so i converted the puffader again with the persistence file and it worked i get puffader back when restart BUT i dont get the meterpreter session when i do that.. only when i restart the victim machine and the attacker listening...
So the meterpreter does not work ...
Just the puffader itself...(logs sends to email)
How can i make sure to reconnect to the victim when ever i want? (Even if the victim did not restart his machine)??


Return unknown error when none is returned by last_error

Fixes #60
Open to the usual bikeshedding for function names & cie...

Looks great to me, thanks!


LFS-709: Subject selector improvements

LFS-711: Remove Select a  from the dialog body
LFS-708: Display the full id for available subjects
LFS-688: UI anomaly when having multiple tumors with the same name

711 - tested; all good
709 - the full id is displayed, however the new problem is introduced. Steps to reproduce:
create 3 patients ( P1, P2, P3)
create 3 same tumors and assign them to each patient ( P1/liver, P2/liver. P3/liver)
create tumor form for P1/liver
create tumor form for P2/liver - the error will be shown "Tumor liver already has 1 Tumors Data form(s) filled out."

Another problem:

create a patient (P1)
create tumors and assign the to patient (P1/liver)
create tumor region 1 and assign it to P1/liver
try to create another tumor region 1 for P1/liver - it will fail (correct), however the error message is incomplete "Subject 1 already exist for parent liver". It should state "Tumor region 1 already exist for tumor P1/liver."


Getting None as predicted values

I am getting None as a predicted output, what would be the reason for it?
environment:
pandas==0.25.1
numpy==1.17.2
tqdm==4.36.1
Python 3.7.4
train data
test data
code:
chefboost_c45.txt
(unable to attach .py as Github doesn't allow, hence added .txt)
output:
C4.5  tree is going to be built...
Accuracy:  79.16666666666667 % on  24  instances
finished in  0.41808056831359863  seconds
Win
Win
Win
None
Win
Win
Win
Win
Win
Lose
Win
Lose
Also, does the chefboost have support to get precision, recall, and f1 score?

Your prediction features do not satisfy the built decision tree rules. This should be handled and fixed in framework. Also, currently precision, recall metrics are not calculated in the FW as well. I'll add those metrics. I plan to fix these issues tonight or tomorrow night. Thank you for your deeply explanation about issues.

I am also experiencing the same issue.

I will inform you when I updated the code. Unfortunately, I could not work on it yet.

Also experiencing the same issue.

Sorry for the late solution.
This issue is solved in chefboost=0.0.5. Please upgrade your package.
The problem was decision tree has no branch for the instance you passed. As a solution, I returned the most frequent one for the current branch in the else statement. Mean value of the sub data set for the current branch will be returned for regression problems as well.
Please inform me after you tried the new version.

works great, thanks!


Need small help!

Hello! Big thanks for your work!
Could you shoe me how to align names and buttons on the same level?
Like:

https://codepen.io/bubnenkoff/pen/KKyzWOa

Hi!
When you use <h*> elements you need to use no-margin helper because they have default margins that can affect the alignment. And you can use the middle-align to align vertical and the center-align to align horizontal. Try the code below:

Name1

  <button>foo</button>
  text

Name2

  <button>bar</button>
  text

Bit thanks!
Could you add more docs about helpers?
Maybe it's obvious for devs who use HTML/CSS every day, but I am who use it time to time for some trivial tasks.

And could I do what I want if every element is placed in own div (for example I want encapsulate is to make padding\coloring)?

Name1

  <button>foo</button>
  text

Name2

  <button>bar</button>
  text

I think you can get the same initial result using middle-align on that divs. If you need to encapsulate, try this:

Name1

    <button>foo</button>
    text

Name2

    <button>bar</button>
    text

Oh really big thanks for your help and your work!


tomcat kitchen converge error in chef

can anyone help me. why this error is coming

Hi Reddy,
From logs it stats that Tomcat group already exists, and my guess was you are using shell/command instead of chef resource. So try using "group" resource so that it will not fail if group exists due to idempotency

Hi Reddy,
From logs it stats that Tomcat group already exists, and my guess was you are using shell/command instead of chef resource. So try using "group" resource so that it will not fail if group exists due to idempotency

when we are creating centos-7 for the First time we have to create manually. then it won't ask again for a subscription while using CLI commands.


Type problems on type check

My type checker says:
There are types at<EMAIL_ADDRESS>but this result could not be resolved when respecting package.json "exports". The '@ysx-libs/vue-virtual-tree' library may need to update its package.json or typings.

I think you need to also export the type files? But not sure why. I use regular npm 10.2.4.

This seems to solve it, move the trypes inside of the export: https://stackoverflow.com/a/77566206

  "types": "./dist/typings/tree/index.d.ts",
  "exports": {
    ".": {
      "import": {
        "types": "./dist/typings/tree/index.d.ts",
        "default": "./dist/vue-virtual-tree.es.js"
      },
      "require": {
        "types": "./dist/typings/tree/index.d.ts",
        "default": "./dist/vue-virtual-tree.umd.js"
      }
    },
    "./style.css": "./dist/style.css"
  },

But this is still a bit odd when importing VirTree, maybe you should export VirTree as default? My IDE has problems to distinguish between the type and the real impl.

Update to v0.0.8 Try it out

this works for the types very good, but now I have:
MyTree.vue:2:10 - error TS1484: 'VirTree' is a type and must be imported using a type-only import when 'verbatimModuleSyntax' is enabled.

not sure how to fix that. It does think VirTree is a type and not a component.

Can reference this demo

Yes I know, but we use verbatimModuleSyntax so only type imports will be dropped in the output, and that seems to be not correctly determined.

update to v0.0.9 that can be import like:

update to v0.0.9 than can be import like:

Very cool, that seems to work good! Thank you very much.


HttpContextProvider: load CA to fetch client

Description
HttpContextProvider needs to load CA in fetch client from host like LLMProviders.
Checklist

[x] The base branch of this PR is preview, rather than main

@Berber31 thanks for the contribution! I'm going to merge, but also keep an eye out for a follow-up set of changes I'm just about to make, so that you'll be able to actually use requestOptions in config.json for context providers as well. Right now this won't necessarily acknowledge any "caBundlePath" that you've set


updating dependencies to account for pyyaml

Checklist for This Pull Request
🚨Please adhere to the guidelines for contributing to this repository.

[x] Ensure you are submitting your pull request to a branch dedicated to a specific topic/feature/bugfix. Avoid using the master branch for pull requests.
[x] Target your pull request to the main development branch in this repository.

[x] Check that your code additions do not fail any linting checks or unit tests.

Pull Request Description
Update dependencies
What does this pull request accomplish?

Bug fix

Are there any breaking changes included?

[ ] Yes
[x] No

Is there anything the reviewers should know?
Thank you for your contributions!

Resolves #14


Using Vector2(NaN, NaN) as position in Control.SetPosition sets Control.Size to Vector2(Nan, Nan)

Godot version
4.2.dev5.mono.official [e3e2528ba]
System information
Windows 10 Pro Vulkan API 1.1.95 - Forward+ - Using Vulkan Device #0: NVIDIA - Quadro K1100M
Issue description
It took me a while to figure out why my UI elements weren't visible on the screen because of Control.SetPosition behavior.
I have a scenario where I instantiate my player and the player's camera on the same frame. I also have a signal that is emitted when player is instantiated. Upon receiving the signal my UI script will instantiate an UI widget for the player. In the UI widget's _Process I make it follow the player's position using UnprojectPosition.
It seems like the first time the UI widget's _Process is called and the camera is not yet initialized properly the UnprojectPosition method returns Vector2(NaN, NaN). This is fine, but now when using this value in SetPosition, the method sets the Size of the Control node to Vector2 (Nan, Nan), making the UI widget disappear from the screen. On the next frame when the camera is initialized, calling SetPosition with a proper value works as expected, but since the Size was previously set to Vector2(NaN, Nan) the UI element won't be visible on the screen.
Here's a code explanation of what happens:
public override void _Process(double delta)
{
    Vector2 screenPosition = _camera3D.UnprojectPosition(_entity.Position);
    // screenPosition is (Nan, Nan), _entity.Position is (0, 0, 0)

    Vector2 sizeBefore = this.Size;
    // sizeBefore is (100, 12)

    if (float.IsNaN(screenPosition.X) || float.IsNaN(screenPosition.Y))
    {
        SetPosition(screenPosition);

        Vector2 sizeAfter = this.Size;
        // sizeAfter becomes (NaN, NaN)
    }
}

I know that I should not call the method with invalid argument in the first place. I also know I can work around this issue via multiple ways (e.g. initializing the camera earlier, checking for NaNs).
That said, I think it would be more user friendly if calling with SetPosition with position=Vector2(NaN,NaN) (accidentally or not) would not modify the size of the control node. It could potentially save many hours of developer time if they didn't need to go through debugging this unexpected behavior.
Steps to reproduce
Call Control.SetPosition with Vector2(NaN, NaN) as the position argument.
Minimal reproduction project
N/A

v4.3.dev.custom_build [b7145638d]
I ran into something similar when placing some Buttons at unprojected 3D camera positions.
For some reason the button sizes were getting set to NaN despite the positions being perfectly valid, causing the buttons to consume all GUI input, despite being visually the correct size (possibly because I was using custom_min_size?).
I "fixed" my issue by setting the size to Vector2.ZERO directly after setting the position, so that it would recalculate based on the minimum size.

I'd say this is expected, NaN is a broken data type and breaks things, adding checks everywhere for NaN is expensive and you should avoid doing so yourself, it's generally not too hard to avoid NaN if you make sure you don't do any risky mathematical operations, I'm not even sure how you managed to get NaN here? It could only really happen if some of the input data is already broken, like an invalid camera transform.
I'd say the cost of adding NaN checks everywhere for a very few cases it's needed isn't worth it, compared to the very limited load on a developer to use mathematical operations responsibly

A debug-only warning for this sounds fine to me, though.

A little debugging later, and my problem was indeed my own fault. Turns out I posted a little too early.
I was setting the 2D position even if the 3D position was behind the camera, which created the initial NaNs. I assume the size got contaminated by that, possibly somewhere in Godot's layout code.

If there are cases where you find NaN generated by the engine then those are the area for bug reports (some already are open, like for audio), otherwise it's more user error than an issue that the engine accepts NaN input, the engine isn't necessarily going to be completely resistant to user error, though in some cases it should protect against it
NaN values are hard, and can pop up in various places, but they are possible to guard against as well :)


Support for CVV/CVV Less card

<img width="1362" alt="ima@BushraAsif rc="https://user-images.githubusercontent.com/1629945/192951137-7f96eaa1-eecb-49c5-80ec-b08b8c71ba48.png">
@BushraAsif  could you explain why we are removing this code?

@BushraAsif could you explain why we are removing this code?

Because this code was commented out and the method is not in use. It's not calling in the phtml file. We are using progress.phtml file to get billing/shipping/payment steps.


DSET-4002: Extract serverHost from the logs and traces

Description: Introduce server_host configuration to allow specifying server host
There is new configuration option server_host that allows specifying how to fill the field ServerHost of the Event structure.
New configuration looks like this:
    server_host:
      # If these attributes are not specified or empty,
      # use the value from the env variable SERVER_HOST
      use_host: ${env:SERVER_HOST}
      # If it's not set, use the hostname value
      use_host_name: true

This configuration is applied for logs and traces.
Since it's touching the same code, I have already merged changes from this PR - https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/23881 - into this branch, hoping that it will be merged soon. It's still not merged, so it's blocked by this.
Link to tracking Issue: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/24252 / DSET-4002
Testing:
I have added several unit tests to make sure that it works as expected.
Documentation: There is new section in the README describing the newly added configuration options.

Both approaches have some advantages and disadvantages:

this approach - you do not have to study anything else, you do not have to modify your data
"it has to be serverHost" approach - if you use this field for something else, then you have to move this data somewhere else and then replace it with the serverHost value

But now when I think about it, I would bet that otel maintainers would also prefer the second version => so I will change it.

Just to confirm / clarify, extracting serverHost from the LogRecord Resource will be done in a separate PR, right?
I think that's fine, but I think it's better to combine those two PRs together into a single one when opening PR against upstream repo - this should be less work for the open telemetry maintainers since those two changes are related.

Yes. It will be in the next PR

@martin-majlis-s1 Thanks.
To be able to confirm that serverHost extraction from Resource works correctly, I think we should also test it with otel demo.

@martin-majlis-s1 Thanks.
To be able to confirm that serverHost extraction from Resource works correctly, I think we should also test it with otel demo.

I have added unit test to verify, that it works as expected. I have also used telemetrygen - and it works as expected:

@martin-majlis-s1 I think we are not exactly on the same page here.
I meant inferring serverHost from LogRecord Resource object when that value is not stored directly as part of resource.attributes.serverHost, but when it's stored as part on some other attribute as part of otel conventions. (likely host.name, but it needs more digging in and research - https://opentelemetry.io/docs/specs/otel/resource/semantic_conventions/host/).
Similar to what do we do with inferring service name for tracing part of the plugin.
That's why I said it's important to test it end with the actual otel demo setup. This way we known it works with real work setup and not just manual and specific code path you are exercising.

Just to confirm / clarify, extracting serverHost from the LogRecord Resource will be done in a separate PR, right?
I think that's fine, but I think it's better to combine those two PRs together into a single one when opening PR against upstream repo - this should be less work for the open telemetry maintainers since those two changes are related.

Now the serverHost is also extracted from the Resource (as well as host.name).

When I run the demo, I can see, that the host.name from the resource is correctly extracted. However it's used just for single service.

@martin-majlis-s1 Can you please share DataSet link for the search query above so I can quickly have a look? Thanks.

@martin-majlis-s1 Can you please share DataSet link for the search query above so I can quickly have a look? Thanks.

The thing is, that only two services are populating logs:

https://app-qatesting.scalyr.com/y/SXRDxLUjA6D
https://app-qatesting.scalyr.com/y/j4xov1vVCDj

@martin-majlis-s1 Thanks. I had a quick look and it looks good to me :)
P.S. I assume "martin" is hostname which is specified in the config which is used as a default when Resource doesn't contain host.name, right?
Did we also test a scenario where it uses collector hostname when that "martin" value is not specified in the config? Thanks.

I can see, that:

only adservice (Java) and recommendation service (python) are producing logs
Language of that service is from  https://opentelemetry.io/docs/demo/
Python has experimental support for logs
Php is alpha, C++ is experimental

but for C++ - https://opentelemetry.io/docs/instrumentation/cpp/manual/#logs - it's not there
but for PHP - https://opentelemetry.io/docs/instrumentation/php/manual/#logs - it should be easy to add


Issue/issue/remove std config file usages iso6

Description
iso6-specific PR for https://github.com/inmanta/inmanta-core/pull/7636
identical PR except for

the test_server_recompile_param_fact_v2 test that is not present in iso6.
test_export in tests/test_app_cli.py -> agentname is set

Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box
- [ ] Attached issue to pull request

[x] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Merged into branches iso6 in 78c1a20444d6f81dfae74455a12b777eac5ac220