Community Balance Changes

@YakaryBovine for some reason there seems to be multiple file changes for very slight changes in vectors for regions and units etc. Annoyingly seems to do it every time I edit, i have left them in case it messed anything up.
Community Feedback / Balance Sheet
General
Mana potions generally from 20 to 16
Reduced cost of Periapt of Vitality 85>70
Increased number of charges included with a Dust of Appearance 2>5 Potion of Greater Mana cost reduced 40>30
Scourge
Reduced Kel’Thuzads starting level 4>3
Lordaeron
Added a Blacksmith in Hearthglen
Dalaran
Added Reveal to Violet Towers
Gilneas
Reduced life steal on Worgen’s Bite ability 80%>60% Increased Greyguard’s total Mana and Mana Regen 280>320 1.00>1.2 Reduce sides per die on Cyclone Cannons 5>4
Added a Passive Icon for Worgen showing HP only regens at night (Lunar Regeneration)
Stormwind
Increase gold cost of Bladesman to 14>16
Reduced gold cost of Pikeman 18>17
Ironforge
Removed Goblin Tinkers from the Fuselight creep camp
Kul’Tiras
Remove Goblin Tinkers from Booty Bay creep camp
Westfall Outpost quest amended; Players now need to complete the Continental Outpost quest and build the following in Westfall:
Barracks
Altar
Caster Building
Workshop
Townhall
Removed Mana Shield from Meridith Waycrest and replaced with Brilliance Aura Reduced Daelin Proudmoore’s movement speed to be in line with other heroes 270>230
Fel Horde
Increased cast range of Magtheridon’s ultimate ability Felfire 500>600
The Exodar
Lowered Vindicators Hitpoints 1850>1650
Lowered Elekk Knights Hitpoints 2800>2500
Lowered Elekk Knights base attack 167>151
Reduced Elekk Knights gold cost 135>125
Sentinels
Archer attack speed decreased 1.6>1.9
Zandalari
Added a blacksmith at both Zulfarrak and Zandalar
Frostwolf
Reduced cost of Robes of the Magi 90>65
Vol’jin’s starting level increased 3>5
Warsong
Reworked Varok Saurfang’s Battleshout ability

All of the balance changes look good to me and I'd be happy to merge those.
However there are several changes in here that are not pure balance changes/bug fixes, so I can't merge this into main. These are:

Added Reveal to Violet Towers
Added a Passive Icon for Worgen showing HP only regens at night (Lunar Regeneration)
Westfall Outpost quest amended; Players now need to complete the Continental Outpost quest and build the following in Westfall
Removed Mana Shield from Meridith Waycrest and replaced with Brilliance Aura
Reworked Varok Saurfang’s Battleshout ability

If you raise a PR with just the balance changes I'll merge it in! For the rest, we'll need a separate PR into dev which I can then review.


Rabbit Foot

Is there any place to change the Lucky Rabbit's Foot drop percentage to be able to get Normal Rabbit's Foot sometimes? I need it in another mod.

The Lucky Foot does not change the drop chance of the normal rabbit's foot, it is added as an extra item.

strange then, the only thing I get from the rabbit is this loot, not even meat and leather is dropping, but, thanks!


[🚀esl-utils]: make __esl_sequanse__ a private key (using Symbol)

:tada: This issue has been resolved in version 4.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


DS Native Editor functional test failing in CI

https://dev.azure.com/ms/vscode-python/_build/results?buildId=50546&view=logs&j=988a0fb7-1e3d-5a71-acac-13c2385e77a1&t=648d549c-d6c4-561a-0e71-812af6327ba6

 111 passing (5m)
  68 pending
  1 failing

  1) DataScience Native Editor
       Editor tests
         Auto Save
           Auto save notebook every 1s:
     Error: Timeout waiting for dirty state to get updated to true
      at Timeout.setTimeout (out/test/common.js:392:20)

npm ERR! code ELIFECYCLE
npm ERR! errno 1

Started happening when I disabled the Reports step for all pipelines 🤷♀

And interestingly did not happen for the next CI run: https://dev.azure.com/ms/vscode-python/_build/results?buildId=50588&view=results

Uggh. We need to make the test use a more concrete method of determining if something is dirty or not. Sleeping never works.

This has been addressed.

@greazer how frequent would be frequent enough?
Of the 10 failing runs there:

Only 3 did not fail because of DS functional tests (the one above and this one):


Property is private and only accessible within class

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.0.0
node: 6.9.5
os: linux x64
@angular/common: 2.4.10
@angular/compiler: 2.4.10
@angular/core: 2.4.10
@angular/forms: 2.4.10
@angular/http: 2.4.10
@angular/material: 2.0.0-beta.2
@angular/platform-browser: 2.4.10
@angular/platform-browser-dynamic: 2.4.10
@angular/router: 3.4.10
@angular/cli: 1.0.0
@angular/compiler-cli: 2.4.10
Repro steps.

ng build -prod
The log given by the failure.

ERROR in /home/u/maps-msda-ng2/src/$$_gendir/app/app.component.ngfactory.ts (4028,18): Property '_sidenav' is private and only accessible within class 'AppComponent'.
/home/u/maps-msda-ng2/src/$$_gendir/app/app.component.ngfactory.ts (4030,18): Property '_infoSidenav' is private and only accessible within class 'AppComponent'.
/home/u/maps-msda-ng2/src/$$_gendir/app/app.component.ngfactory.ts (4032,18): Property '_owlCarousel' is private and only accessible within class 'AppComponent'.
/home/u/maps-msda-ng2/src/$$_gendir/app/app.component.ngfactory.ts (4034,18): Property '_tree' is private and only accessible within class 'AppComponent'.
/home/u/maps-msda-ng2/src/$$_gendir/app/app.component.ngfactory.ts (4036,18): Property '_ol3Map' is private and only accessible within class 'AppComponent'.
/home/u/maps-msda-ng2/src/$$_gendir/app/app.component.ngfactory.ts (4524,22): Property '_extendedSearchAccordion' is private and only accessible within class 'AppComponent'.
Mention any other details that might be useful.

ng serve works
link to the code of the component: http://pastebin.com/p8EFtbFB

dupe of https://github.com/angular/angular-cli/issues/5621

no errors with angular v4.0.0

Is there a way to solve this error with angular 2.4?

rolling back to rc.4 fixed this for me

The red text is via ng build --prod, however ng serve works just fine.
This is a project I upgraded from ng2.4

Same here. Apparently 1.0.0 only works with angular 4?

Same here with cli 1.0.0 and angular 4

Same here with cli 1.0.0 and angular 4

Duplicate, as said before.The Angular team will move to full AoT eventually and considers templates as separate entities from the component which means no private variables can be accessed from them. Basically, either convert your code or stay on Angular 2.4 or JIT.

I have resolved it with Angular 2.4.10, Angular-CLI 1.0.0-rc.2, and TypeScript 2.1.6

I use  cli 1.0.0 & angular 4 but still have this issue? any news please ?

FYI, If you're only using @ngtools/webpack in your own custom webpack setup, these versions worked for me:
"@ngtools/webpack": "1.2.14",
"webpack": "2.3.3",
"webpack-dev-server": "2.4.5",
"webpack-merge": "4.1.0"

+1 Reopen please.

same problem. unable to make prod build

same problem. any news?

Set properties that will be accessed from the template to public and you're good to go

We have also the same issue! "public" is not a solution.

i have also the same issue.
i use ver 4.0.1 with cli 1.0.
how fix?

@j-nord @tsandtm
Guys, this is not a bug from angular CLI. It's the way angular implements it.
Actually the only bug there was here is that angular CLI didn't show the errors / warning of the compiler before the release. Now this bug is fixed and you can see the errors.
@j-nord Unfortunatelly, yes you will have to change all the components variable from private to public if they are used into your template. It's not a angular CLI issue, it's an angular requirements that was not well reported by the CLI until now.
The other option for you if you want to keep your variable private is to downgrade to @angular/cli-rc.4 and maybe stay on angular 2.x.x (not sure about that).
Another option I heard of (check by yourself, I didn't try) is that you only use JiT instead of AOT.
For more info you can check the comments of this issue #5623
Hope it helps.

Guys, its a tslint.json issue. Ensure your configuration meets with what you set up on tslint.json
Hope it helps.

@iamonuwa  Could you please elaborate on how to do that?

running this command to deploy the app will fix it.. ng build --env=prod
found the solution in github

ng build --env=prod worked.
Seems ng build --env=prod and ng build --prod are not same.
@deeptiProjects can you describe the difference

@deeptiProjects @arun31786 with ng build --env=prod you do not achieve AOT compilation, for more details see docs: https://github.com/angular/angular-cli/wiki/build#build-targets-and-environment-files
Original "error" reported is not an error, but normal restriction of AOT at least for versions 2, 4, 5. The variable used in the template needs to be declared as "public". Template is treated as a separate Typescript class.

ng build -prod --aot=false

@arun31786 Documentation claims those commands are the same:
# these are equivalent
ng build --target=production --environment=prod
ng build --prod --env=prod
ng build --prod

传送门

Try ng build --prod aot false

I have also the same issue!

Same issue here after angular 5 update. I don't want to make all properties en methods public.

I used angular 2.4.10 , angular-cli 1.0.6 ,typescript 2.2.1
I got this error when i upgrade to 2.4.10 from 2.3.1
it serves but cant build for prod with aot
i have solved to build without aot -> "ng build --prod --aot=false"

+1
Property 'nav' is private and only accessible within class.
Angular 5.1+
CLI: 1.6.3
This errormsg appears when ng build --prod

I have several instances of the same injected variable and it's private in some places and public in others, and it's used in some templates as a private variable, yet one module is complaining that it's private, and the rest aren't.

+1
it happens with protected as well. I'm not able to make right sense from those keywords then!

I am using Angular 5 and having the same issue when deploying Jenkins build. The annoying part is it works locally but not when I make a build

Changing to public when used in templates worked for me. Not sure why only one module complained though.

Same, cannot make a build for production, this is quite annoying.
Angular 6.0.7
Angular CLI : 6.0.8
Everything is working fine in development and for a regular build.
POO but forced to make everything public ?

I had the same issue. What I understood, the most correct way is to define your variable as public when planning on using them in a template.
With that said I ended up having to change 1000+ properties in my components. In order to do that efficiently I created this python-script:
https://github.com/marcus13371337/angular-aot-fixer
Hope that can help some others to speed up the migration from private properties to public properties in your projects!


Class 'Facebook\FacebookSession' not found "

hii darkwhispering ..
I try your library but I find trouble, may be I dont understand how to instalation your library in point no 3 that "In CodeIgniter /application/config/config.php, configure the Session Variables." or point no 5 ..
I have setting /application/config/facebook.php with my facebook app id and facebook app secret ..
I found message eror report like this " Message: Class 'Facebook\FacebookSession' not found "

If you know this solution, please explain to me ..
Thanks

Hi @eduhakim, sry for this late reply.
For point on 3, you need to activate and configure the CI session library, using one of the available drivers. Read more about it in the CI Documentation
For point no 5. To download and install the Facebook SDK you need to user Composer, a dependency manager for PHP. Details on how to user Composer can be found on there website
I'm guessing you see the error because you have not installed the Facebook SDK using Composer.

This also might be caused by the update to the SDK. If you have it installed you have to make sure you have 4.x installed and not 5.x. The 5.x version no longer has a FacebookSession class and running your script will fail on this line (it did for me when I realized the SDK updated). Also don't be fooled by the SDK directory name (facebook-sdk-v4). They left the folder/package name intact but updated the version.

In index.php file of CodeIgniter...
Add the line
include_once './vendor/autoload.php';
just before the require_once BASEPATH.'core/CodeIgniter.php'; line.
It's not loading the autoload.php by default.

@tarunmangukiya If you use CodeIgniter 3, you don't need to manually include the autoload file. CodeIgniter 3 has built in support for Composer.
However, if you use CodeIgniter 2 or below (which this library do not support), you need to manually add the autoload file as you commented.

True... Recently I came to know about that.
Thank you,Tarun MangukiyaCo-founder | Remarkin - Learn to Code | https://remarkin.comMicrosoft Student Partner | Microsoft
Date: Tue, 6 Oct 2015 10:16:55 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [facebook-sdk-v4-codeigniter] Class 'Facebook\FacebookSession' not found " (#4)
@tarunmangukiya If you use CodeIgniter 3, you don't need to manually include the autoload file. CodeIgniter 3 has built in support for Composer.
However, if you use CodeIgniter 2 or below (which this library do not support), you need to manually add the autoload file as you commented.
—
Reply to this email directly or view it on GitHub.

Hello everyone,
I'm unable to load the library of FB... Same error message but not the session actually it's showing unable to load class Facebook /Facebook class
Line no 67 in library file of Facebook
I configure the config file and session also
Please help me
Thank you


New list sources

Hello. A few (well, a lot of) ad/malware domains have been compiled by the OpenWRT project:
https://github.com/openwrt/packages/blob/master/net/adblock/files/README.md
Could these be absorbed into this repo and regularly synced?

Hi @hyder365 thank you for this suggestion.
Several of our sources, including our amalgamated list, are in that list.
Which component of that list do you recommend absorbing here?
Our main criteria is, the lists we carry are all actively curated.  We aren't interested in add-only buckets of countless domain names.  Quality, for us, comes from active curation.

In particular I'm interested in the adguard list, which is well known and actively maintained. Slightly less important, but still nice to have, would be the ones specializing in mobile ads,YouTube ads, and smart TV telemetry. Many of the non-English lists, bitcoin miners, and so on are less important.

@hyder365 we've talked about AdGuard before, particularly in Issue #1181.  Review that, so you're up-to-speed.
I think AdGuard would be a good addition.  I have concerns about how this list is properly curated.

Thanks for the link. Even without AdGuard, some of these would be nice to add.
The YouTube one (https://github.com/kboghdady/youTube_ads_4_pi-hole) has made a big difference here!

I'm considering adding several new sources, and this is one of them.

I'm considering adding several new sources, and this is one of them.

Steve @StevenBlack  i've read some of the issues: example.
Doesn't look like it works for everyone with some stating that the videos can't even start playing. Also the curator recommends
the list to be updated at least daily. Not sure that you want go trough that hassle.

Thanks Dan @dnmTX that clarifies things for me.


Eliminate unused expressions in WorkflowBuilder.

Fixes #1895
Previously this optimization happened in Workflow, which meant that expressions
could be irreversibly converted to JS even though it was unnecessary for the
optimized form.
Also includes some formatting clean-up.

Codecov Report

Merging #1925 into master will increase coverage by 0.01%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #1925      +/-   ##
==========================================
+ Coverage    65.6%   65.62%   +0.01%
==========================================
  Files         376      376
  Lines       18583    18579       -4
  Branches      229      229
==========================================
  Hits        12192    12192
+ Misses       6391     6387       -4

Impacted Files
Coverage Δ

.../quasar/physical/mongodb/planner/JoinHandler.scala
97.56% <ø> (-0.02%)
:x:

...la/quasar/physical/mongodb/optimize/optimize.scala
91.59% <100%> (ø)
:white_check_mark:

...cala/quasar/physical/mongodb/workflowbuilder.scala
84.28% <100%> (+0.34%)
:white_check_mark:

...asar/physical/mongodb/planner/MongoDbPlanner.scala
83.6% <75%> (-0.21%)
:x:

...quasar/physical/mongodb/workflow/Crystallize.scala
0% <ø> (ø)
:white_check_mark:

...nector/src/main/scala/quasar/qscript/MapFunc.scala
64.17% <ø> (+0.4%)
:white_check_mark:

...la/quasar/physical/mongodb/workflow/Classify.scala
78.57% <ø> (+13.86%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bcbbcc...2856029. Read the comment docs.


SoS running java applications

Here is a MWE:
[1]
run: docker_image = 'dceoy/gatk'
     java -Xmx4g -jar GenomeAnalysisTK.jar -h

I got the command line interpolated:
INFO: docker run --rm --security-opt label:disable  -v /home:/home -v /tmp:/tmp -v /home/gaow/Documents/GIT/github/pet-project/tmphnzuaurk/docker_run_14466.sh:/var/lib/sos/docker_run_14466.sh    -t -P -w=/home/gaow/Documents/GIT/github/misc -u 1000:1000    dceoy/gatk /bin/bash /var/lib/sos/docker_run_14466.sh

It fails on this error:
***********************************************************************

A USER ERROR has occurred: '/bin/bash' is not a valid command.

***********************************************************************
Set the system property GATK_STACKTRACE_ON_USER_EXCEPTION (--java-options '-DGATK_STACKTRACE_ON_USER_EXCEPTION=true') to print the stack trace.

So it looks like the dceoy/gatk /bin/bash /var/lib/sos/docker_run_14466.sh line is problematic. Has anyone ran into this before? I guess there should be a fix with docker switches but it is not apparent to me.

run uses bash to execute script by default. Perhaps you should use
run:
    #!/usr/bin/java -Xmx4g -jar
   GenomeAnalysisTK.jar -h

or simply
script:
   java -Xmx4g -jar  GenomeAnalysisTK.jar -h

to start?

Oh I never have used this script action. I'll give it a go when I get back to my desk. Does script: interpreter = 'java -Xmx4g' work?

The root question is how to execute a file with
 java -Xmx4g -jar  GenomeAnalysisTK.jar -h

In this case you will have to have an interpreter. If /bin/bash does not exist, you will have to use sh: or #!/path/to/sh. If you want to use java as interpreter, you will have to figure out the syntax to run java whatever_option a_temp_file_with_the_script.

Right, I'm still in the search for such a command that uses java directly. Various script interpreter did not work for that docker image.

The problem is that this Docker has a specific "entry point": https://hub.docker.com/r/dceoy/gatk/~/dockerfile/
In this case we are restricted to providing java -jar gatk.jar some scripts to run ...

So the docker image will be run as additional parameter passed to java -jar gatk.jar?

Note that outside of docker, there is a trick to use script as parameter, that it to say
run: args='{script}'
    real args

The mechanism is that if no args is specified, args will be set to {filename}. I can implement the same mechanism for docker if this is helpful.

Well, this docker image will be executed essentially like this: java -jar gatk.jar  <sos task interpreter> <sos generated sh file> which is problematic. I can simply create my own docker image to disallow entrypoint. I am not sure if your proposed solution is going to deal with it, from what you've described: a script is involved anyways, right?

Well, it is complicated. Outside of docker,
run:
  script

is /bin/bash temp_script_name which is the most comm case.
run: args='{script}'
  content

will run /bin/bash content which passes content to command line.
script does not have a default interpreter, so
script:
   content

execute temp_file_with_content directly, and
script: args='{script}'
  content

will execute content directly.
Now, if I can make this work also for docker, you should be able to do
script: args='script', docker_image='blah'
    java ...

With the patch I just committed,
[0]
script: docker_image='ubuntu', args='{script}'
echo 'Echo'

will be translated to
INFO: docker run --rm   -v /Users:/Users -v /tmp:/tmp -v /Users/bpeng1/sos/tmp2b4en3xl/docker_run_67576.sh:/var/lib/sos/docker_run_67576.sh    -t -P -w=/Users/bpeng1/sos -u<PHONE_NUMBER>:895809667    ubuntu  echo 'Echo'

Basically echo 'Echo' becomes the command. Will this work for you?

I see. Yes I agree this is going to work for me if it works for docker applications.

Great! Now this works:
[1]
script: args = '{script}', docker_image = 'dceoy/gatk'
     PrintReads -h

Does the following also work?
[1]
script: args = 'Print Reads -h', docker_image = 'dceoy/gatk'

Yes it does! though it is not that useful because the arguments are very long.
BTW are we stable enough to make another release, or some other issues needs to be resolved before doing so? I'd like to share my script with someone. Would be nice to have him pip it.

OK, I have documented such advanced usages at action doc and option docker_image, and released sos <IP_ADDRESS>.

Okey it looks like we need another bug fix release because this ticket has broken something:
[1]
bash: docker_image = 'gaow/debian-ngs'
  STAR -h

gives
INFO: docker run ...   gaow/debian-ngs ['/bin/bash', 'bash'] /var/lib/sos/docker_run_7138.sh

which, as you can tell, is doomed to fail. Using run we do not have the problem.
If we are to make a bug fix release it would be great to resolve #934 as well so users only need one upgrade ...

Great, it works now.
Before we release, should we check pyflake? A couple of red flags are raised if you check it. Additionally tools like https://github.com/hhatto/autopep8 might also be helpful.

already released. Will deflake later.


Default Docker CMD not updated on image update

I'm using this cookbook to run a container that specifies a default CMD in the dockerfile.
For example, my Dockerfile has the line
CMD /usr/src/run.sh

If I run the container like:
docker_image "my_image" do
  tag 'latest'
  action :pull
  notifies :redeploy, 'docker_container[my_container]', :delayed
end

docker_container "my_container" do
  repo "my_image"
  tag 'latest'
  port "8080:8080"
  restart_policy 'always'
end

This runs fine.
If I push a version of the image that changes the default CMD, e.g. update the Dockerfile with
CMD /usr/src/run_new.sh

and re-run the recipe, the new image is pulled, and run, BUT with the old command.
When I run docker ps I see '/usr/src/run.sh' as the command, but expect '/usr/src/run_new.sh'. Yet the image is the new one, containing other updates if things other than the CMD are updated.

this is an issue from https://github.com/chef-cookbooks/docker/issues/619

We're seeing this issue as well. Any updates or workarounds for this?

I can't seem to replicate this one...
https://github.com/chef-cookbooks/docker/commit/8014525467dcb1075f44d9f45b849283144c26f0
The general strategy for testing this kinda thing is:

Edit a recipe ran by a test-kitchen suite
Set up the preconditions with executes and markers
Replicate (un)expected behavior in recipe
Test for evidence with inspec

I did my best to set up the conditions you described with the above commit... but can't seem to get it to fail.
I even tried commenting out the bottom three resources, converging, putting them back, and converging again across multiple chef-client runs.
Am I misunderstanding the issue here?
-s

so this was an issue i struggled with in the past and had tests that replicated it. went back and reran my tests and everything is working as it should now. i think this issue with load_current_value and properties has been resolved in newer version of chef/compat_resource.
https://github.com/chef-cookbooks/docker/pull/734 is a good explanation of what was going on.
i think it is safe to close this out.

Closing for now. Thanks everyone!
-s


End the suffering, turn back on implicit_transitive_deps

This was a mistake, and we have now learned from it :)
Context:
We had hoped that this option would get dune to warn us when we were underspecifying our dependencies. In particular, since dune is able to infer the transitive dependencies, it has all the information that we need. However, in practice this is implemented in a way that's very inconvenient to use:

dune doesn't emit any warnings;
dune doesn't resolve upstream transitive dependencies (e.g. core -> core_kernel -> base -> base.caml), which makes our external dependencies unnecessarily and unhelpfully verbose;
the OCaml compiler is the only thing 'checking' the dependencies, and missing types are treated as 'abstract'

this causes unpleasant and confusing error messages,
the OCaml compiler uses head-normalising type path expansion, so if we have A.t = B.t = C.t = int * bool, the error will report that A.t is abstract even when B or C are the missing libraries.

The correct approach is to add a mode for dune to check the (local/workspace) dependency enumeration, using its internal tracking; this is explicitly not done here.

!ci-build-me

Our dune deps could be so pretty...

I get it ended up being too much pain, and not worth the benefit, but could you include a few bullet points at the top about why it ended up being a mistake so we have a record of it?
Here's the original issue on it:
https://github.com/MinaProtocol/mina/issues/2451

!ci-build-me

As a quick example of the pain, a recent change I introduced to wire types required changing exactly 100 of our packages to add a trivial line, otherwise getting annoying errors about the types being opaque.

!ci-build-me

!approved-for-mainnet


Dependency injection implemented

Application class created
Activity and Fragments annotated
App Module created and provideRetrofit function created
Util package created

Please review my code and apply merge if everything works for you


Incorrect TEXTURE_COMPARE_MODE with shadow samplers.

The GLES spec requires the comparison mode to be COMPARE_REF_TO_TEXTURE when sampling from a depth texture using a shadow sampler. We are setting this up correctly in ShadowMap::prepare, however we are somehow losing this state by the time we make a draw call.
Many GL implementations seem to allow this without erroring, but WebGL in Chrome Canary has extra validation that triggers an error.  To repro: add builder.castShadows(true) to MeshReader.cpp and launch the helmet or suzanne demos in Canary.
Theory: the texture is bound but not actually sampled by the shader, which is why there is no apparent error on most platforms.
Possibly related to #935
CC @AdrianAtGoogle

Are we losing the GL state or the Filament sampler state? (compareMode in SamplerParams)

@prideout I tracked SamplerParams from the shadowmap code to the gl draw calls using material_sandbox and didn't see this problem. Is it specific to this test?

You're right, I added some prints and it looks like the sampler is properly using COMPARE_REF_TO_TEXTURE.  I'll set up a repro page so that the Chrome team can investigate.

Hack workaround: adbdfeb21bae854d43cc69d046f0d7f8a2c2d56f

The Chrome team has acknowledged a bug on their end but are unlikely to get it in before Chrome 73, so I'll leave this open in case we need to do a temporary workaround such as adbdfeb.

The parquet and flighthelmet demos don't work for me on Chrome 72. Parquet shows a black frame, FlightHelmet shows nothing (just a white background).

parquet and helmet are now fixed on Chrome 72, there were files in Friday's web update that didn't get merged.   Note that helmet is our only demo with shadows, so it will regress when Chrome 73 lands unless we have a workaround.  I'm not sure if it's worth adding a workaround to Filament given Chrome's frequent update schedule.

We confirmed through experimentation that the Chrome team has fixed this in the next version, meanwhile our helmet demo has been upgraded to use gltfio, and it now has a workaround in place.


CarEmblemGenerator-Cral-Cactus

This project is a Car Emblem Generator that creates and displays one of three randomly selected car logos - Toyota, Audi, and Renault - at random positions on a canvas. Each time the script is executed, it randomly chooses which emblem to draw and determines its location on the screen.

Thanks for the submission. I like the idea but the emblems are a bit too simple. Could you make it more than single lines?

@maxwofford, so you just want to I make it generate random car next to car emblems and everything would be good?

@maxwofford, could you give opinion? I created car which parts are fully random generated using bt.randInRange, is this what you wanted? Thanks

@Cral-Cactus that's a start, but the gif you're showing me doesn't look that randomly generated besides the placement of the car. What if you put the logo on the car and changed the same/porportions of the car each generation? For inspiration check out https://turtletoy.net/turtle/browse/love/0

I think you don't see much random generation of the car because that's just the luck when I was recording the gif and yea seems like in the gif is too small but you mean to make the car bigger and inside the car body put smaller version of the emblem?

Something like this?

@maxwofford, what do you think?

This is getting closer, but I think you can go further. Here are a couple ideas:

only show the tail spoiler sometimes
give it bumpers! maybe even different types of bumpers randomly chosen
what about wheel wells! Most cars aren't directly ontop of their wheels.
You can even figure out how to raise the car a random amount & end up with a lowrider

@maxwofford, sorry but I have no idea what kind of bumper to do so it fit. But I changed wheels and created suspensions with springs and made the spoiler spawn chance to be 50%

oh what how I closed it

Thank you so much for reopening the PR, I updated it :)

@maxwofford, is everything alright with the PR? 😃

@BrightTheBackpack @maxwofford wtf guys, 3 weeks you guys are telling me that it is good and ready to be merged and now you are throwing that I should do more changed??? This isn't how the life works nor fair in any case.  I am totally disappointed from you guys. Also while in the gallery there are lots of ars which are way worse. You can't be telling me that it is good and you are going to merge it and 3 weeks later with no any response in the chat you are changing your mind out of nowhere that you want more changes and that it doesn't fit your criteria that is just bs

You can close the pr, i don't want to deal with you guys in any case nor listen your explanations how in those 2 weeks without replys only from bright you changed your decision and so on i will build my own blot, this kind of acting really cancelled me doing anything for blot project, i am sure leo would've done better than you

ok give me time, I will do better car

that is kinda weird logic which this bot have with image file names, should I rename them how it want them like from 2.png to 12.png and 3.png to 13.png?

Anyways I will update the images and will just rename them

Honestly that artwork check is weird, it always want to add 1 more number if artwork names are numbers only so I will just use letters

that artwork check system is broken i literary tried everything :(

I tried but still show that, this artwork check is indeed so broken

Thank you max and sorry for all troubles, have a nice day!


Remove Setup Steps from Action

what

moved setup steps outside of action

why

The python setup step does not support Amazon Linux: https://github.com/actions/setup-python/issues/460

references

https://github.com/actions/setup-python/issues/460

we're going to dockerize this action instead


Support writing gremlin queries in Python

Currently the gremlin queries are passed in string:
interactive = sess.gremlin(g)
papers = interactive.execute("g.V().has('author', 'id', 2)....)

Ideally, the gremlin should be written in Python, (maybe with the help of gremlinpython package?)
# a wrapper to get a Traversal object.
g = sess.interactive(graph)

g.V().has('author', 'id', 2)...

It has already been here: https://github.com/alibaba/GraphScope/blob/main/python/graphscope/interactive/query.py#L187
Wrap the gremlin API to g itself still worths a PR.

OK, thanks for reminding me..


Image anonymization is slow

Hi,
First of all, thank you guys for making this awesome project :)
I wanted to ask if there are any ways to improve image anonymization performance. I'm using Presidio as a python package and it takes about 5~ seconds to process pretty small images. I'm using the example code from the Presidio docs.

Hi @kubistika, thanks for your issue.
This is indeed a bug. the AnalyzerEngine instance used in the presidio-image-redactor is initialized on every request, which takes a few seconds. If you or anyone is interested in fixing it, that would be great. If not, we'll get to it soon.

Hi @omri374, thanks for you reply. I submitted a pull request.

@kubistika issue was closed after your PR was merged - thanks for contributing! if there's still an issue, feel free to reopen this one, or open a new issue


refactor ~ improve code coverage implementation

modifies GHA:CICD workflow to successfully calculate code coverage for macos, unix, and windows
uploads coverage maps to CodeCov.io (which can integrate reports from multiple platforms)
includes shortcut utilities to calculate and show locally generated code coverage

@sylvestre , if you have some time, would you look at the "util/show-codecov.sh" shell script?
Specifically, I've marked three lines "FixME". Probably just a brain misfire, but I can't figure out how to code this to condense the ignore's for grcov into a variable and use it at the later two spots as an option to grcov. When I've tried to debug using echo ..., the command line seems correct, but grcov ignores the options included via ${GRCOV_IGNORE_OPTION}. And, so, I'm having to duplicate the ignores, writing them directly on the commands lines.
😕

As a reminder, I'll update the GHA:CICD workflow to include some appropriate grcov line and branch exclusions (eg, --excl-br-line 'assert(_eq|_ne)?!') when https://github.com/mozilla/grcov/pull/416 is merged.

Yeah, bravo, thanks :)


can't use alpine,void?

ive yet to try others but:
python install.py alpine:latest
or python install.py voidrootfs.tar.xz
does successfully build the rootfs but when i execute 'bash' it gives me:
Error: 0x80070002
whats up?

Hi,
Alpine uses busybox, which doesn't seem to work under WSL as a replacement for bash. Not sure about void.
This isn't an issue with the distribution switcher, rather with WSL crashing on distributions that deviate too much from the standard.
I implemented hooks for fixing most of the distributions' issues, but some distributions plain and simple don't start. You could try some more popular at first, such as Debian or Fedora, which will work.

im actually an archlinux user, since the two mentioned dont work, i wanna try archlinux, what commands do i need to get archlinux running?
i've tried:
get-source.py archlinux
get-source.py base/archlinux
get-prebuilt.py archlinux
get-prebuilt.py base/archlinux
it seems that all get-prebuilt.py commands give me:
Traceback (most recent call last):   File "get-prebuilt.py", line 25, in <module>     with urllib.request.urlopen('https://auth.docker.io/token?service=registry.docker.io&scope=repository:%s:pull' % fimage) as f:   File "C:\Users\admin\AppData\Local\Programs\Python\Python35\lib\urllib\request.py", line 163, in urlopen     return opener.open(url, data, timeout)   File "C:\Users\admin\AppData\Local\Programs\Python\Python35\lib\urllib\request.py", line 466, in open     response = self._open(req, data)   File "C:\Users\admin\AppData\Local\Programs\Python\Python35\lib\urllib\request.py", line 484, in _open     '_open', req)   File "C:\Users\admin\AppData\Local\Programs\Python\Python35\lib\urllib\request.py", line 444, in _call_chain     result = func(*args)   File "C:\Users\admin\AppData\Local\Programs\Python\Python35\lib\urllib\request.py", line 1297, in https_open     context=self._context, check_hostname=self._check_hostname)   File "C:\Users\admin\AppData\Local\Programs\Python\Python35\lib\urllib\request.py", line 1256, in do_open     raise URLError(err) urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:645)>

VoidLinux works for me:
C:\Users\RoliSoft\Desktop\wsl-distrib > python get-prebuilt.py voidlinux/voidlinux
[*] Requesting authorization token...
[*] Fetching manifest info for voidlinux/voidlinux:latest...
[*] Downloading layer sha256:cc40ca6dff2d219ffebac10ec6c623dd00a717c157d2abd3e0c9a39ea877e692...
[*] Rootfs archive for voidlinux/voidlinux:latest saved to rootfs_voidlinux_voidlinux_latest.tar.gz.

C:\Users\RoliSoft\Desktop\wsl-distrib > python install.py voidlinux/voidlinux
[*] Probing the Linux subsystem...
[*] Default user is RoliSoft at /home/RoliSoft.
[*] Reading /etc/{passwd,shadow,group,gshadow} entries for root and RoliSoft...
[*] Removing leftover rootfs-temp...
[*] Beginning extraction...
[*] Backing up current rootfs to rootfs_debian_sid...
[*] Switching to new rootfs...
[*] Writing entries of root and RoliSoft to /etc/{passwd,shadow,group,gshadow}...
[*] Switching default user to root...
[*] Running post-install hook all...
[*] Detecting operating system...
Unsupported operating system.
[!] Failed to run hook in WSL: Command '['cmd', '/C', 'C:\\WINDOWS\\System32\\bash.exe', '-c', 'REGULARUSER="RoliSoft" WINVER="14393" /root/hook_postinstall_all.sh']' returned non-zero exit status 1
[*] Switching default user back to RoliSoft...

C:\Users\RoliSoft\Desktop\wsl-distrib > bash
RoliSoft@ROLISOFT-PC ˜/wsl-distrib $ xbps-install -S
[*] Updating `http://repo.voidlinux.eu/current/x86_64-repodata' ...

To install ArchLinux run:
> python get-prebuilt.py pritunl/archlinux
> python install.py pritunl/archlinux

If you get Python errors, you can try the compiled version of the scripts from here: https://github.com/RoliSoft/WSL-Distribution-Switcher/releases
In that case, instead of python whatever.py run whatever.exe and the parameters.

Also, the error you're getting from get-prebuilt.py is that it can't verify the SSL certificate of auth.docker.io.
 Try the compiled exes.

Okay you might wanna write a note in your readme. musl-based distros don't seem to work with WSL.
https://repo.voidlinux.eu/live/current/
I downloaded rootfs-musl version which was why i had the error. I now downloaded the glibc version, and install.py, it just worked.

I'm using python-3.5.2-amd64.exe
Definitely not firewall issue. I'll try your compiled version.
Now that voidlinux is running, are you able to see if anything obvious needs patching? You mentioned something about hooks on your readme.

python-3.5.2-amd64.exe

I'm using the same, so it should work fine. You could try running:
pip install certifi

While this installs a CA database, not sure if this actually fixes your problem, since this database won't be used by default, as far as I can tell.

anyway, i can't get the package manager to work in voidlinux.
lxrun /setdefaultuser root
xbps-install -S # syncs
it immediately tells me "Killed"
Do you know a quick fix for it? If you don't I'm gonna give up and just move to archlinux now.

Alpine also uses musl it seems. The issue might actually be this. I'll do some more experiments later and update the README accordingly.
As for your issue, VoidLinux is not a distribution I am familiar with (other than hearing about it) and there is no support for it in the hooks.
So, if you want a smooth experience, I'd recommend using pritunl/archlinux, since that is what I optimized it for. Make sure to rename the hook_postinstall_all.sample.sh file to hook_postinstall_all.sh, so the hook script actually runs after installation, and fixes the quirks.
The post install script non-interactive, so just let it do its thing. If you interrupt it with Ctrl+C, you might end up with a broken installation. (Of course, you can always just re-run the installation for a fresh start.)

Running your latest release get-prebuilt.exe also gives me that ssl cert error

Interesting. Also, the sync command works for me, it's not killed:
RoliSoft@ROLISOFT-PC ˜ $ su -l
Password:
# xbps-install -S
[*] Updating `http://repo.voidlinux.eu/current/x86_64-repodata' ...
x86_64-repodata: 1161KB [avg rate: 12GB/s]
#

Not sure how to proceed with the troubleshooting.

I'm on 14393, you?

Same, the anniversary update. Only using Insider in VMs.

Any suggestions? Start fresh? Honestly its my first time using WSL.
So how do I do this? lxrun /uninstall /full?

Yes, and then reinstall it, make sure you have a working Ubuntu installation first.
Then try installing something like pritunl/archlinux, which should work flawlessly.
As for your issue, you could try seeing if you can fix your Python installation: https://www.google.com/search?q=python+ssl+certificate+verify+failed
Alternatively, you can edit the get-prebuilt.py script, add to header:
import ssl

ssl._create_default_https_context = ssl._create_unverified_context

This monkeypatches SSL verification to ignore verification errors.

the monkeypatch fixed it for now.
voidlinux is now without the "killed". what are the sort of things that i should test to see if everything is good?
i saw comments on "dnf" or something.

note: voidlinux original rootfs tarball from https://repo.voidlinux.eu/live/current/ spews that killed error. using the docker version is fine (strangely?)

i dont know why i have this python issue (But not you) but anyway.. i asked folks on irc and they seem to think that python isnt communicating with windows cert store.
unfortunately, i do not know anything about python. so ill just leave you some information that you might find useful:
 biax: https://docs.python.org/3.2/library/urllib.request.html#urllib.request.urlopen you can patch the global urlopener to use the ca path in certifi
https://pypi.python.org/pypi/wincertstore

also, are you familiar with this? https://github.com/turbo/alwsl
Archlinux appears to be working with your setup, any idea what they are trying to accomplish that your setup cant?
Pardon my many comments & questions.
Thanks for this wonderful piece of software by the way!

i saw comments on "dnf" or something.

dnf is Fedora's package manager. One of the issues with Arch was chrooting, but the postinstaller fixes that completely.

note: voidlinux original rootfs tarball from ... spews that killed error.

Maybe it needs some initialization? Not sure. You could check the Dockerfile of one of the working VoidLinux docker archives to check what they do in extra after including the rootfs.

you can patch the global urlopener to use the ca path in certifi

I know I can, but since no one met this issue before, I did not know I had to. I'm still not sure how to proceed, since for other users it works properly, and I don't want to just shovel on dependencies if not absolutely required.

Archlinux appears to be working with your setup, any idea what they are trying to accomplish that your setup cant?

There isn't really much competition here, since we're trying to do different things. My project tries to be as generic as possible, support as many distributions as possible by supporting a wide range of sources (docker hub [prebuilt], docker library [sources], rootfs archives, squashfs images) and fix any known issues if the distribution is recognized.
alwsl is an ArchLinux distribution tweaked to work under WSL. The batch file downloads a prebuilt rootfs image from the owner's servers and installs that as rootfs. If you only want to use ArchLinux, and my script is giving you a hard time, you could use that project as well.

alright then. in any case, things are up and running so till again then.
truly appreciate all your help.

So I ran the script under a debugger, and it seems that they were right on IRC. \Python35\Lib\ssl.py has load_default_certs which calls _load_windows_store_certs and automatically reads the Windows Certificate Store.
In your case, it fails to communicate with it. Try running it as admin? Although you shouldn't need to, but at least we can check if this changes anything.

I did run it using a created admin account with UAC disabled even. I've never had any privileges issue. I'll try opening cmd as administrator...

Maybe I shouldn't edit/update comments so I'll repeat again:
same issue running cmd as administrator
On 2016-10-24 04:28, Roland Bogosi wrote:

So I ran the script under a debugger, and it seems that they were
right on IRC. |\Python35\Lib\ssl.py| has |load_default_certs| which
calls |_load_windows_store_certs| and automatically reads the Windows
Certificate Store.
In your case, it fails to communicate with it. Try running it as
admin? Although you shouldn't need to, but at least we can check if
this changes anything.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/RoliSoft/WSL-Distribution-Switcher/issues/20#issuecomment-255612171,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOdsCsH1yN-43e3i9Z0bmIsaWj1y89Jqks5q28NWgaJpZM4KeMoK.

Please check whether commit 1adbfbc fixes your issue.
If the certificate checking works properly, it should fall back to using certifi, or fail with a message asking you to install certifi.


Combine Motion and presence feature: when no motion use Eco or Eco_away preset depending of the presence state.

Discussed in https://github.com/jmcollin78/versatile_thermostat/discussions/264

Originally posted by mldytech December 10, 2023
Hi,
is there any way to set a temperature in motion preset when there is no presence at all?
Right now, the motion state is configured to eco when "no motion" is detected, and to comfort if there is "motion". When nobody is home, the temperature is therefore set to eco. However, I would like to set this to a lower temperature.
Thanks and best regards,
mldy

Hello, I understand your case but this is not possible to natively use both presence and motion and combine them.
But this could be an interesting improvement and I think very simple to do.
What I think is to use the Eco preset temp if present or the Eco_away preset temp if not present.
I will keep it as an enhancement issue.

I vote for it :)
I had to make a few automations to get around the problem, but it would be better in native mode.

Done in https://github.com/jmcollin78/versatile_thermostat/releases/tag/6.8.0

Great news, thank you for all your work !

Un grand merci, cela marche super. 2 evenements maintenant pour le chauffage pour le passage en mode éco la nuit et activity le jour.
Au départ, j’avais  20 événements pour gérer l’arrivé de chaque personne, le départ ets les détecteurs de mouvements...
Et l’état des vannes est super clair. Mes thermostats netatmo sont  plus efficaces que la programation base du constructeur.
Vraiment génial. Merci


Unable to use Authorise keyword in Configure method of Endpoint

I have my user service in another project just need to configure jwt .. can we use Authorize attribute somehow instead of Claims or Permissions ?

https://fast-endpoints.com/wiki/Get-Started.html#configuring-endpoints-using-attributes


Map is broken

For some reason, and I have absolutely no idea why, #60 broke the map. Looks like the latitude 16.402660 is being parsed as a string in javascript instead of a number. Whhyyy??
Need to update the javascript to force numeric parsing.

Weird, well I should have parsed it properly anyway. JavaScript is a mystery itself sometimes.

Fixed #62


Move ListPods endpoint out of Telemetry service

Currently, the public-api calls ListPods via the telemetry service, which queries prometheus for reports_total to get all the pods that have reported.
Move this functionality into the public-api and delete the telemetryClient uses in api/public/grpc_server.go

Related: #615


 The default number of chat lines displayed on screen when unfocused is 10. I want the entirety of the map to fit on screen so people can use it as they walk around the world. If you count the number of lines there (excluding the header), it is 10, whereas changing it to have 5 on each side it bumps it up to 11, meaning one line would be hidden anyway by the chat.

Maybe then reduce bottom/all lines to 4? The map looks strange when there's just one odd side.

Yeah, that's reasonable. I'll change it tomorrow as it's 12:40 am for me now.


Nested list items in markdown are displayed flat

For example: https://tsdocs.dev/docs/rpc-anywhere/1.2.0/index.html#md:features-under-consideration

What do you mean by "displayed flat" ? Could you add more details about the actual and expected output?

The source:

1

a
b
c

How it looks in tsdocs:

1
a
b
c

The link in the issue description should take you to a section of a README with a list containing nested items. If you compare it with the source you can observe this problem.
Hope this helps, let me know if you need any more details or clarification :)


Missing Object.entries() in IntelliSense for JavaScript

VSCode Version: 1.43.2
OS Version: macOS 10.15.4

It seems that IntelliSense is missing the Object.entries() function completely. This is weird, since being introduced with ES2017 it is pretty "old". I couldn't find any other issues on this.
Then I found this statement on Languages - JavaScript

Since VS Code's JavaScript support doesn't understand ES7 constructs, features like IntelliSense might not be fully accurate.

However the String.prototype.trimStart() and trimEnd() methods from ES2019 are present. So this sentence seems to be a forgotten relict from the past. I updated the docs, but I'm still wondering why Object.entries() is missing from IntelliSense?
(I know I could enable the TypeScript compiler for .js files, which would give autocomplete for Object.entries(), but I prefer the built-in IntelliSense since it doesn't give me red squiggly lines all over the place.)
Steps to Reproduce:

Create a .js file.
Type Object.entries().
Watch how IntelliSense doesn't show it.

Does this issue occur when all extensions are disabled?: Yes

You need to tell VS Code you are targeting with a newer JavaScript runtime that supports Object.entries.
To do this, in your jsconfig, set "target": "es2019" (or possible "es2017"):
{
    "compilerOptions": {
        "module": "commonjs",
        "target": "es2019",
    },
    "exclude": [
        "node_modules",
        "**/node_modules/*"
    ]
}

@mjvbz Thanks. But still why do newer language additions like String.prototype.trimStart show up by default without needing to enable anything while Object.entries does not. This does not make sense.

@mjbvz Thanks. But that still doesn't explain why newer language additions like String.prototype.trimStart show up by default without needing to enable anything while the older Object.entries does not. This does not make sense.


[Task]: [Avro] Stop using Avro in "core"

What needs to happen?
After extracting all Avro-related class into a separate Avro extension and make all other modules, that leverage Avro in some way, depend on this extension, we need to make sure that "core" doesn't rely on Avro anymore.
Issue Priority
Priority: 2 (default / most normal work should be filed as P2)
Issue Components

[ ] Component: Python SDK
[X] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

Hi @aromanenko-dev! Thanks for the effort here!
Do we have any plans to move this forward? We're noticing concerns regarding vulnerabilities/CVEs on jackson-mapper-asl (which comes from Avro 1.8.2) -- so wondering if we should put any effort on upgrading that dependency, or if it's best to proceed here and get rid of it in "core".

Thanks for the response @aromanenko-dev! I'll look into using extensions/avro. Although vulnerability scanners will still dislike having Avro 1.8.2 packaged, it sounds like we have a good plan to move forward and eventually get rid of it.

Hi @aromanenko-dev, I went over most of the Beam issues and PRs related to the avro dependency (dated back from 2019!) and have now reached this task. Thank you again for leading the entire epic task!
I have two questions to ask if you don't mind.

I notice we still have avro versions defined in
https://github.com/apache/beam/blob/v2.48.0/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L589-L590. Are we planning to clean them up?
Do we have a timeline for when it will be released? I have included some upcoming releases and cut-off dates below for your reference:
2.50.0: Aug 9, 2023
2.51.0: Sep 20, 2023

@shunping-google
Thanks, I'm happy to help!

We will update Avro version to more recent one.
We deprecated Avro in "core" in Beam 2.46.0 and we usually remove deprecated stuff, at least, after 3 Beam releases if there are no issues discovered during this period. So, for the moment, I don't see any blockers to remove it in, say, 2.50.0. Anyway, I'll send an email to mailing list before to make sure that there are no other objections for this.


Remove unneeded switch statement to fix warning

https://github.com/openssl/openssl/issues/10958
This is a trivial change which has no functional impact, just to fix a couple of warnings.

This pull request is ready to merge

Merged to master.   Thanks for checking the early change.


Upgrading NodeUnit reveals failures in w3c tests?

Please help @Sebmaster! It looks like the first 9 w3c tests pass and the last 9 do not? I tried rearranging them and the same thing happens. My best guess is something wrong with w3ctest.js?

LGTM, with nice atomic commits too. Merge at will, or I will do so when I get a chance. Great stuff, and thanks for saving the day :D

There might actually be another problem at the event fireing order in regards to legacy events although I think it's correct. We should at least add another test for that in any case.

You mean like .onload = ...? Yeah I think we have an open issue for that. https://github.com/tmpvar/jsdom/issues/696

Oh yeah, right. We're good then.


This is source. It tells me to set HXCPP_MSVC_CUSTOM and configure the executable, but I do not know how.

Describe your problem here.
no code input, so I will put code here. C:\Users\noneya\Desktop\Psychsourcebreh>lime test windows
source/Achievements.hx:132: characters 30-54 : Warning : FlxCamera.defaultCameras is deprecated, use FlxG.cameras.setDefaultDrawTarget instead
C:\Users\noneya\Desktop\Psychsourcebreh\export\release\windows\obj>setlocal enabledelayedexpansion
Error: 64bit is not automatically supported for this version of VC. Set HXCPP_MSVC_CUSTOM and manually configure the executable, library and include paths
Error: Error: 64bit is not automatically supported for this version of VC. Set HXCPP_MSVC_CUSTOM and manually configure the executable, library and include paths
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Nothing edited

Bro use the frickin search bar
And install MSVC 2019


Email not working.

Summary
Cannot get email delivered from backuppc.  Also not seeing any issues in logs.
Steps to reproduce
Review email list in web console of emails that went out.  Never received any of these messages.
What is the expected correct behavior?

Relevant logs and/or screenshots
tested from commandline and successfully received the email.
[tiredofit/backuppc:6.0.2 12:57:54 /home] $ /usr/bin/msmtp -t -f mybackuppcfromaddress@mydomain mybackuppcadmin@mydomain
Subject: Test
test

Sorry maybe a blind answer but you have to set the email where you want to receive the notification in the ui of backuppc
https://github.com/stephdl/ns8-backuppc?tab=readme-ov-file#test-email


perf: optimize main stats & sub stats ocr reader

Sometimes tesseractjs gives output like
+ ATK+4,.2%   // double period or comma
 « ATK+4,2%   // non Alphabet character
3,.358        // also double period or comma in main stat

because that some other sub stat cannot be detected.
here before fixed

and here after fixed

I see here that your decimal eliminators are commas. Which language do you play in? I did not realize that was an option.

yeah javascript / typescript, sometimes it gives comma sometimes it gives period

i use Indonesian, sometimes it gives comma sometimes it gives period

how does a artifact main stat of like HP 4780 look in your game? can you include a screenshot?
for example, in my game, it is in the form of 4,780 in my game

here it its

It depends on language english (us, uk) use "." as decimal separator and "," as  thousands separator
Conversely Europe and indonesia use "," for decimal and "." for thousands
I think they all can use space for thousands separator
So seems like Indonesian translators kept english but didn't switch the logic
I'm french, adding to the dot and comma thing, the key are differents so need to switch language to take screenshots

@LrkDev yeah i just realized to since im playing in indonesia from begining, not paying attention to the separator


Hide: MachinesReady=False Deleted

  org-foopilot machinesets demo-1-md-0-q9qzp-tnwbb Condition MachinesReady=False Deleted @ Machine/demo-1-md-0-q9qzp-tnwbb-jbnlc "" (873h4m7s)

Hide it always, or hide it if older than X minutes?

fixed in 624066098e4e678e0b4ef134afafa2e9cae1711f


Can ozzo-Config Support Array?

{
    "com": [
        "foo",
        "bar"
    ]
}

How to Deal this Data in JSON File?

good question

Take a look at this test: https://github.com/go-ozzo/ozzo-config/blob/master/config_test.go#L25

looks like jsonpreprocesssupport Array @bestony please close this issue~

Thanks For Reply!


Installation of stacks fails for helm upgrade

What happened?
(taken from #1020)
Currently helm chart installation fails when stacks deployment enabled and installed with helm upgrade --install
helm install --name crossplane crossplane-alpha/crossplane --namespace crossplane-system  --version 0.4.0 --set 'clusterStacks.gcp.deploy=true' ==> Works
helm upgrade --install crossplane crossplane-alpha/crossplane --namespace crossplane-system  --version 0.4.0 --set 'clusterStacks.gcp.deploy=true' ==> Fails
The root cause is post-install and post-update hooks do not work reliably (i.e. work differently for helm install vs helm upgrade —install even it is first time install both).
What environment did it happen in?
Crossplane version:  v0.4.0

FYI, I verified this on the v0.4.1 release that was promoted to the alpha channel.  Both the GCP and Rook stacks were installed at their latest versions using the following command:
helm upgrade --install crossplane crossplane-alpha/crossplane --namespace crossplane-system --version 0.4.1 --set 'clusterStacks.gcp.deploy=true,clusterStacks.rook.deploy=true'


SOS2 Battle Bug

Describe the bug
IMPORTANT: Please first search existing bugs to ensure you are not creating a duplicate bug report.
To Reproduce
Steps to reproduce the behaviour:

Load RimThreaded and SOS2
Start a game in space
Get into a battle
???
Profit.

Error Log
Link to contents of Player.log or Error.log (Please use something like gist or Pastebin. DO NOT PASTE HERE)
https://gist.github.com/c54d5f99681b1acd30aa6e62efaa8ace
Mod List
Paste contents of ModList used when the bug occurred.
[Mod list length: 196]
Harmony [https://steamcommunity.com/sharedfiles/filedetails/?id=2009463077]
Core [https:// no link (local mod)]
Royalty [Official DLC] [https:// no link (local mod)]
RuntimeGC [https://steamcommunity.com/sharedfiles/filedetails/?id=2228430510]
HugsLib [https://steamcommunity.com/sharedfiles/filedetails/?id=818773962]
SRTS Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=1845423808]
[SRTS Expanded] Planes and Bombs [https://steamcommunity.com/sharedfiles/filedetails/?id=2164607079]
Realistic Planets - Fan Update [https://steamcommunity.com/sharedfiles/filedetails/?id=2009542732]
Achtung! [https://steamcommunity.com/sharedfiles/filedetails/?id=730936602]
[XND] Adrenaline! (Continued) [https://steamcommunity.com/sharedfiles/filedetails/?id=2037728879]
Mod Manager [https://steamcommunity.com/sharedfiles/filedetails/?id=1507748539]
[JDS] The Forge - Anvil [https://steamcommunity.com/sharedfiles/filedetails/?id=1967561500]
ResearchPal [https://steamcommunity.com/sharedfiles/filedetails/?id=946390822]
Camera+ [https://steamcommunity.com/sharedfiles/filedetails/?id=867467808]
Mortar Accuracy [https://steamcommunity.com/sharedfiles/filedetails/?id=1729446857]
Research Info [https:// no link (local mod)]
FSharp.Core [https://steamcommunity.com/sharedfiles/filedetails/?id=2059725183]
RimNauts [https://steamcommunity.com/sharedfiles/filedetails/?id=2198026141]
Relations Tab [https://steamcommunity.com/sharedfiles/filedetails/?id=709317151]
Humanoid Alien Races 2.0 [https://steamcommunity.com/sharedfiles/filedetails/?id=839005762]
[O21] Toolbox [https://steamcommunity.com/sharedfiles/filedetails/?id=1660622094]
RimPy Mod Manager Database [https://steamcommunity.com/sharedfiles/filedetails/?id=1847679158]
In-game wiki [https://steamcommunity.com/sharedfiles/filedetails/?id=2113685739]
RimSaves [https://steamcommunity.com/sharedfiles/filedetails/?id=1713367505]
More Vanilla Biomes [https://steamcommunity.com/sharedfiles/filedetails/?id=1931453053]
[KV] More Trait Slots [https://steamcommunity.com/sharedfiles/filedetails/?id=1508292711]
Medical System Expansion 2 [https://steamcommunity.com/sharedfiles/filedetails/?id=2056706586]
Expanded Prosthetics and Organ Engineering - Forked [https://steamcommunity.com/sharedfiles/filedetails/?id=1949064302]
Vanilla Traits Expanded [https:// no link (local mod)]
EPOE-Forked: Royalty DLC expansion [https://steamcommunity.com/sharedfiles/filedetails/?id=2008970276]
Vanilla Expanded Framework [https://steamcommunity.com/sharedfiles/filedetails/?id=2023507013]
A Dog Said... Animal Prosthetics [https://steamcommunity.com/sharedfiles/filedetails/?id=746425621]
Androids [https://steamcommunity.com/sharedfiles/filedetails/?id=1541064015]
Androids Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=2179977828]
Simple sidearms [https://steamcommunity.com/sharedfiles/filedetails/?id=927155256]
99 Percent [https://steamcommunity.com/sharedfiles/filedetails/?id=1267149586]
RimHUD [https://steamcommunity.com/sharedfiles/filedetails/?id=1508850027]
Allow Tool [https://steamcommunity.com/sharedfiles/filedetails/?id=761421485]
Compact Hediffs [https://steamcommunity.com/sharedfiles/filedetails/?id=2031734067]
Auto links [https://steamcommunity.com/sharedfiles/filedetails/?id=2059389912]
Bionic icons [https://steamcommunity.com/sharedfiles/filedetails/?id=1677616980]
Auto-Cut Blight [https://steamcommunity.com/sharedfiles/filedetails/?id=1885186534]
Character Editor [https://steamcommunity.com/sharedfiles/filedetails/?id=1874644848]
EdB Prepare Carefully [https://steamcommunity.com/sharedfiles/filedetails/?id=735106432]
Damage Indicators [1.2] [https://steamcommunity.com/sharedfiles/filedetails/?id=2016331497]
Colonist History [https://steamcommunity.com/sharedfiles/filedetails/?id=2143758723]
Stand Your Ground [https://steamcommunity.com/sharedfiles/filedetails/?id=2185757415]
CustomDeathRandomness [https://steamcommunity.com/sharedfiles/filedetails/?id=1464742390]
DocPawnOverhaul [https://steamcommunity.com/sharedfiles/filedetails/?id=1975381493]
Gunplay [https://steamcommunity.com/sharedfiles/filedetails/?id=2034896549]
Diseases Overhauled [https://steamcommunity.com/sharedfiles/filedetails/?id=2174246491]
TradeHelper [https://steamcommunity.com/sharedfiles/filedetails/?id=2113372560]
Dress Patients [https://steamcommunity.com/sharedfiles/filedetails/?id=1667901146]
More Trade Ships [https://steamcommunity.com/sharedfiles/filedetails/?id=725465444]
Dubs Mint Menus [https://steamcommunity.com/sharedfiles/filedetails/?id=1446523594]
Dubs Mint Minimap [https://steamcommunity.com/sharedfiles/filedetails/?id=1662119905]
Everybody Gets One [https://steamcommunity.com/sharedfiles/filedetails/?id=1687566130]
Beautiful Bodies [https://steamcommunity.com/sharedfiles/filedetails/?id=2068281501]
RunAndGun [https://steamcommunity.com/sharedfiles/filedetails/?id=1204108550]
Dub's Paint Shop [https://steamcommunity.com/sharedfiles/filedetails/?id=1579516669]
No Sympathy for Prisoners [https://steamcommunity.com/sharedfiles/filedetails/?id=2167490674]
Infusion 2 [https://steamcommunity.com/sharedfiles/filedetails/?id=2063008864]
Custom Year and Speed [https://steamcommunity.com/sharedfiles/filedetails/?id=2093902544]
Interaction Bubbles [https://steamcommunity.com/sharedfiles/filedetails/?id=1516158345]
Better ModMismatch Window [https://steamcommunity.com/sharedfiles/filedetails/?id=1872244972]
[SS]Lovely Hair Style [https://steamcommunity.com/sharedfiles/filedetails/?id=1498706339]
LBE's A Dog Said Easy Patcher [https://steamcommunity.com/sharedfiles/filedetails/?id=944381237]
Locks [https://steamcommunity.com/sharedfiles/filedetails/?id=1157085076]
Long Distance [https://steamcommunity.com/sharedfiles/filedetails/?id=2028511550]
No Job Authors [https://steamcommunity.com/sharedfiles/filedetails/?id=2009825774]
Field Medic [1.0+] [https://steamcommunity.com/sharedfiles/filedetails/?id=1541287769]
OgreStack [https://steamcommunity.com/sharedfiles/filedetails/?id=1447140290]
Faster Smoothing [https://steamcommunity.com/sharedfiles/filedetails/?id=1807439023]
Mad Skills [https://steamcommunity.com/sharedfiles/filedetails/?id=731111514]
Pharmacist [https://steamcommunity.com/sharedfiles/filedetails/?id=1365242717]
LWM's Deep Storage [https://steamcommunity.com/sharedfiles/filedetails/?id=1617282896]
Power Indicators [https://steamcommunity.com/sharedfiles/filedetails/?id=899714534]
Prisoner Harvesting [https://steamcommunity.com/sharedfiles/filedetails/?id=730854291]
Pawn Badge Fan Fork [https://steamcommunity.com/sharedfiles/filedetails/?id=2112663412]
Pawn Badge - Soviet Navy [https://steamcommunity.com/sharedfiles/filedetails/?id=2112979470]
Pawn Badge - Soviet Army [https://steamcommunity.com/sharedfiles/filedetails/?id=2112979140]
Pawn Badge - Soviet Aviation [https://steamcommunity.com/sharedfiles/filedetails/?id=2112978863]
Pawn Badge - Vietnamese People's Army [https://steamcommunity.com/sharedfiles/filedetails/?id=2114315356]
Quick Stockpile Creation [https://steamcommunity.com/sharedfiles/filedetails/?id=1742151109]
Raids For Me [https://steamcommunity.com/sharedfiles/filedetails/?id=1633517937]
RandomPlus [https://steamcommunity.com/sharedfiles/filedetails/?id=1434137894]
Recipe icons [https://steamcommunity.com/sharedfiles/filedetails/?id=1616643195]
RenameColony [https://steamcommunity.com/sharedfiles/filedetails/?id=1359645236]
Random's Random Assortment of Hair [https://steamcommunity.com/sharedfiles/filedetails/?id=2022675283]
Reverse Commands [https://steamcommunity.com/sharedfiles/filedetails/?id=858744731]
Non-Deadly Smokeleaf [https://steamcommunity.com/sharedfiles/filedetails/?id=872197723]
Xeva's Rimhair [https://steamcommunity.com/sharedfiles/filedetails/?id=705924057]
Metal Don't Burn [https://steamcommunity.com/sharedfiles/filedetails/?id=2022726345]
Vanilla Hair Expanded - Beards [https://steamcommunity.com/sharedfiles/filedetails/?id=2187520791]
Absolute Legends Hair [https://steamcommunity.com/sharedfiles/filedetails/?id=2195744587]
Ceramics [https://steamcommunity.com/sharedfiles/filedetails/?id=1833163132]
[SPK] Additional Vanilla Crafting [https://steamcommunity.com/sharedfiles/filedetails/?id=2122304719]
[Ry]HD Pawn Textures [https://steamcommunity.com/sharedfiles/filedetails/?id=1951826884]
Shit Rimworld Says [https://steamcommunity.com/sharedfiles/filedetails/?id=2069706266]
Show Draftees Weapon [https://steamcommunity.com/sharedfiles/filedetails/?id=1690978457]
Rimocracy [https://steamcommunity.com/sharedfiles/filedetails/?id=2159080853]
Rimpedia [https://steamcommunity.com/sharedfiles/filedetails/?id=2145524536]
ShowModDesignators [https://steamcommunity.com/sharedfiles/filedetails/?id=1399212509]
Simple Search Bar [https://steamcommunity.com/sharedfiles/filedetails/?id=1827546987]
Skilled Stonecutting [https://steamcommunity.com/sharedfiles/filedetails/?id=1207390617]
Snap Out! [https://steamcommunity.com/sharedfiles/filedetails/?id=1319782555]
Stabilize [https://steamcommunity.com/sharedfiles/filedetails/?id=2023407836]
Tech Advancing [https://steamcommunity.com/sharedfiles/filedetails/?id=735268789]
Stackable Chunks [https://steamcommunity.com/sharedfiles/filedetails/?id=1619558325]
Thermal Units [https://steamcommunity.com/sharedfiles/filedetails/?id=2006814687]
ThrumBRUH [https://steamcommunity.com/sharedfiles/filedetails/?id=1783405267]
Use Resurrector Mech Serum On Rotten or Skeleton People [https://steamcommunity.com/sharedfiles/filedetails/?id=1827609208]
Pawn Name Variety [https://steamcommunity.com/sharedfiles/filedetails/?id=2159633754]
Vanilla Events Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=1938420742]
Conduit Deconstruct [https://steamcommunity.com/sharedfiles/filedetails/?id=838336462]
Vanilla Hair Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=1888705256]
Yayo's Combat 3 [https://steamcommunity.com/sharedfiles/filedetails/?id=2038409475]
WeaponStats [https://steamcommunity.com/sharedfiles/filedetails/?id=974066449]
Wearing Armor Info [https://steamcommunity.com/sharedfiles/filedetails/?id=1839305669]
Gunmetal [https://steamcommunity.com/sharedfiles/filedetails/?id=2181643016]
Graphics Settings+ [https://steamcommunity.com/sharedfiles/filedetails/?id=1678847247]
Vanilla Ranged Retexture [https://steamcommunity.com/sharedfiles/filedetails/?id=2180749296]
Real Drug Names [https://steamcommunity.com/sharedfiles/filedetails/?id=784325872]
Search and Destroy [https://steamcommunity.com/sharedfiles/filedetails/?id=1467764609]
Smarter Construction [https://steamcommunity.com/sharedfiles/filedetails/?id=2202185773]
[KV] Show Hair With Hats or Hide All Hats [https://steamcommunity.com/sharedfiles/filedetails/?id=1180826364]
Killfeed [https://steamcommunity.com/sharedfiles/filedetails/?id=1362098265]
[SYR] Harvest Yield [https://steamcommunity.com/sharedfiles/filedetails/?id=1461790308]
[WD] Reinforced Doors [https://steamcommunity.com/sharedfiles/filedetails/?id=1857597307]
Advanced Parka [https://steamcommunity.com/sharedfiles/filedetails/?id=1677752791]
Anti-Air Artillery [Unofficial Update] [https://steamcommunity.com/sharedfiles/filedetails/?id=2045686960]
BondageBed Torture [https://steamcommunity.com/sharedfiles/filedetails/?id=2094933315]
Jewelry [https://steamcommunity.com/sharedfiles/filedetails/?id=2020964421]
Power++ [https://steamcommunity.com/sharedfiles/filedetails/?id=1771402217]
Vanilla Plants Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=2134308522]
Prisoner Arena (Continued) [https://steamcommunity.com/sharedfiles/filedetails/?id=2022581505]
Perfectly Generic Item [https://steamcommunity.com/sharedfiles/filedetails/?id=2169353373]
Quarry 1.1 [https://steamcommunity.com/sharedfiles/filedetails/?id=2007576583]
Glass+Lights [https://steamcommunity.com/sharedfiles/filedetails/?id=826153738]
Exotic Arsenal [https://steamcommunity.com/sharedfiles/filedetails/?id=2170891422]
Project RimFactory Revived [https://steamcommunity.com/sharedfiles/filedetails/?id=2033979700]
Reinforced Walls [https://steamcommunity.com/sharedfiles/filedetails/?id=1929389479]
Communicable Diseases [1.2] [https://steamcommunity.com/sharedfiles/filedetails/?id=2016577520]
Simply More Bridges (Continued) [https://steamcommunity.com/sharedfiles/filedetails/?id=2012484790]
Rimatomics [https://steamcommunity.com/sharedfiles/filedetails/?id=1127530465]
Simple Turrets [https://steamcommunity.com/sharedfiles/filedetails/?id=1790155285]
Elite Bionics Framework [https://steamcommunity.com/sharedfiles/filedetails/?id=1665403571]
Electric Braziers [https://steamcommunity.com/sharedfiles/filedetails/?id=2119557949]
Statue of Colonist [https://steamcommunity.com/sharedfiles/filedetails/?id=1539031321]
MedPod [https://steamcommunity.com/sharedfiles/filedetails/?id=2153065191]
Combat Enthusiast's Collection [https://steamcommunity.com/sharedfiles/filedetails/?id=2221508815]
Preemptive Strike (Fork) [https://steamcommunity.com/sharedfiles/filedetails/?id=2056230561]
Super Soil [https://steamcommunity.com/sharedfiles/filedetails/?id=823626435]
More Linkables [https://steamcommunity.com/sharedfiles/filedetails/?id=1103809207]
Tilled Soil [https://steamcommunity.com/sharedfiles/filedetails/?id=725747149]
Mixed Stone Blocks [https://steamcommunity.com/sharedfiles/filedetails/?id=2076686656]
Vanilla Apparel Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=1814987817]
Drop on Water Revived [https://steamcommunity.com/sharedfiles/filedetails/?id=1807530429]
Awesome Inventory [https://steamcommunity.com/sharedfiles/filedetails/?id=2050289408]
Don't Drop Weapon [https://steamcommunity.com/sharedfiles/filedetails/?id=2130390903]
Vanilla Armour Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=1814988282]
Vanilla Furniture Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=1718190143]
Absolute Legends Guns [https://steamcommunity.com/sharedfiles/filedetails/?id=2162631828]
Vanilla Weapons Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=1814383360]
Gun Nut - Community Pack [https:// no link (local mod)]
Gun Nut - Chapter #2 [https://steamcommunity.com/sharedfiles/filedetails/?id=2239800263]
Gun Nut - Chapter #1 [https://steamcommunity.com/sharedfiles/filedetails/?id=2208576613]
Vanilla Furniture Expanded - Power [https://steamcommunity.com/sharedfiles/filedetails/?id=2062943477]
Small Hi-tech Research Bench [https://steamcommunity.com/sharedfiles/filedetails/?id=2148706684]
Small Simple Research Bench [https://steamcommunity.com/sharedfiles/filedetails/?id=2147483288]
Vanilla Weapons Expanded - Laser [https://steamcommunity.com/sharedfiles/filedetails/?id=1989352844]
Alpha Ships [https://steamcommunity.com/sharedfiles/filedetails/?id=2163702706]
Kenshi Armory [https:// no link (local mod)]
[SYR] AK-47 [https://steamcommunity.com/sharedfiles/filedetails/?id=1510446096]
War Crimes Expanded 2 Core [https://steamcommunity.com/sharedfiles/filedetails/?id=2059450213]
Locks 2: Lock Them Out! [https:// no link (local mod)]
[TRAHS]Framework [https://steamcommunity.com/sharedfiles/filedetails/?id=2251954192]
[TRAHS]Blood [https://steamcommunity.com/sharedfiles/filedetails/?id=2170595802]
Rim of Madness - Bones [https://steamcommunity.com/sharedfiles/filedetails/?id=1180573408]
Death Rattle Continued [1.2] [https://steamcommunity.com/sharedfiles/filedetails/?id=2206107940]
Enhanced Combat Sounds [https://steamcommunity.com/sharedfiles/filedetails/?id=2095586726]
Vanilla Weapons Expanded - Quickdraw [https://steamcommunity.com/sharedfiles/filedetails/?id=1906780517]
Advanced Shield Belts [https://steamcommunity.com/sharedfiles/filedetails/?id=1417354001]
Execution Mod [https://steamcommunity.com/sharedfiles/filedetails/?id=2186151886]
Vanilla Factions Expanded - Insectoids [https://steamcommunity.com/sharedfiles/filedetails/?id=2149755445]
[1.2] Nukes [https://steamcommunity.com/sharedfiles/filedetails/?id=1777069843]
Let's Have a Cat! [https://steamcommunity.com/sharedfiles/filedetails/?id=1629060163]
Gastronomy [https:// no link (local mod)]
Trait Rarity Colors [https://steamcommunity.com/sharedfiles/filedetails/?id=1751884355]
Apparel Gizmos From Comps [V1,V1.1,V1.2] [https://steamcommunity.com/sharedfiles/filedetails/?id=1272185463]
Suicide Vest [V1,V1.1,V1.2] [https://steamcommunity.com/sharedfiles/filedetails/?id=1272186441]
MinifyEverything [https://steamcommunity.com/sharedfiles/filedetails/?id=872762753]
Wa! Skeleton! (Continued) [https://steamcommunity.com/sharedfiles/filedetails/?id=2159119022]
RimWorld - The Dark Descent [https://steamcommunity.com/sharedfiles/filedetails/?id=2151315388]
RimThreaded [1.2] [https://steamcommunity.com/sharedfiles/filedetails/?id=2222907981]
Save Our Ship 2 [https://steamcommunity.com/sharedfiles/filedetails/?id=1909914131]

Resolved by recent 1.127 update.


Fix enableStickyHeader not working when layout mode is grid-no-grow

@mintaka2479
Can you explain how startWith fix this issue? I am guessing there is multiple layout mode starting with grid? perhaps also add a screenshot of the result?
thank you!


Add "organization" field to more events.

This should cover all events that GitHub says have an organization field.
Fixes #2950

Thank you, @WillAbides !
Merging.


Extension based HW (Linux) Automation documentation is out of date (Powershell 7.2).

Reference to one of the specifics in the documentation: https://github.com/MicrosoftDocs/azure-docs/blame/a635b1688c9c089f945c569f0c8a7390052a2f1c/articles/automation/automation-hrw-run-runbooks.md#L132C3-L132C3
Here it mentions about PS 7.2 environment variable. And only talks about version 7.2. (Linux)
Powershell is now in 7.4, and I don't know if the same environment variable is used (although it seems to be version specific), or if it is the same except ending in 7_4, or if both need to be there for different runtime environments.
What I do know is that I am having issues with runtime environment and I am not sure where the problem is.
It would be great if this document is updated to account for runtime environments and different versions of powershell.
What I am experiencing is that packages added to a runtime environment are unavailable for the runbook executed in it, when executed by the hybrid worker. An up to date documentation can help me narrow down my issue.
Best,
Fábio

@fabio-s-franco
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!!

@fabio-s-franco It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!!

https://learn.microsoft.com/en-us/azure/automation/automation-hrw-run-runbooks

@fabio-s-franco
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.


Disable Style/ConditionalAssignment

This cop says that:
foo = if bar
  1
else
  2

is better than
if bar
  foo = 1
else
  foo = 2
end

I think on many projects we actually prefer the second style.

What does it say about:
foo =
  if bar
    1
  else
    2
  end
``` ?

I always have a 1/2 second of worry about lexical scoping when I write `foo = <something>` inside a conditional, so prefer the other form because it's obvious what the scoping is (it's not a problem in ruby, but might be for those coming from other languages).  Admittedly this form relies on ruby's "everything is an expression" semantics that could be confusing to those coming from other languages, so....

I would argue that we shouldn't do either :)
def foo   if bar     1   else     2   end end

Supporting Tijmen's point: I'm more used to the second example. I'd never seen the first before the example in this PR and it seems very confusing 😟.

I guess my main problem with the cop is that the solution it comes up with is quite ugly in some cases:

I'm definitely not against the conditional assigment style, but I do think it shouldn't be mandatory.

I'm with Murray on the scoping issue.

Oh. I misunderstood what disabling the cop would do.  It not being mandatory seems like a sensible plan as that extreme indent version seems gross (and at odds with any linelength cops).

Assignment out of an if (or case) isn't mentioned in our styleguides but it's definitely a house rule as I use it a lot but not here.

Okay, perhaps leaving this cop as-is is better, as the scoping issue feels like it is a real code-quality concern, as opposed to my objections which are mostly esthetical.
Odd auto-correct may be solvable, as the cop supports some checking on LineLength.

Following a discussion in Slack, I was directed here.
I personally find heavily right-indented code hard to read. As your eyes scan downwards they have to jump from left to right and I think there's an argument to be made for discouraging this style.
@h-lame's suggestion is a nice middle-ground in my opinion, although I'm not sure how that would "scale" for more than one variable? e.g.
if foo
  bar = 1
  baz = 2
else
  bar = -1
  baz = -2
end

Is lexical scoping going to throw non-Rubyists off such that we should be explicitly assigning variables to nil before the conditional? In a language with explicit declaration, this is effectively what you'd do, but that seems far from idiomatic to me.
I personally think we should be ok with accepting Ruby's quirks and assigning the same variable in more than one branch of a conditional. It might catch people out the first time they see it, but I think the benefits of keeping text left-indented and quickly scannable outweigh this.


Add link to terms of use

Not sure why you didn't use a link to the terms. Care to elaborate?

I think reads the full terms anyways, but maybe this is the cleaner solution

Yes, I agree, but at least now it points to where they could, if they want :smile:


Learn Combine

https://habr.com/ru/post/476678/

[X]  watch videos
[ ] get practice

https://www.youtube.com/watch?v=hbY1KTI0g70

https://www.youtube.com/watch?v=Uog7d8VHqX8


Multiple Elasticsearch Target Urls

Hello,
This more of a question than an actual issue, but I could not find anywhere else to present this doubt I am having.
Given the possibility to have multiple elasticsearch urls in nlog config, how are these managed? It will always send requests to both targets? will it detect if the node is available, and forward to the first available node? will it balance between node urls?
Thank you,

Hi if you specify multiple urls, it'll use a Static Connection Pool that will ping the nodes to make sure they're healthy. It can issue requests against any healthy node.

Thank you for your reply. Should be enough to get me going and to understand how to "balance" connections to our cluster.


fix(engine-core): Incorrect error message for platform

Fix error message

I’m sorry, I don’t have time.

From: Alexey Orlenko @.>
Sent: Monday, January 10, 2022 4:43:00 PM
To: prisma/prisma @.>
Cc: Joshua @.>; Author @.>
Subject: Re: [prisma/prisma] fix(engine-core): Incorrect error message for platform (PR #11045)
@aqrln approved this pull request.
This looks good to me. Would you mind adding a small test for this as well?
—
Reply to this email directly, view it on GitHubhttps://github.com/prisma/prisma/pull/11045#pullrequestreview-848064629, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWCQNMAUG3IL24FMZ5LDGDUVMEBJANCNFSM5LT6JVKA.
You are receiving this because you authored the thread.Message ID: @.***>

Okay
We're gonna do some works on this.

@Josh-a-e no worries, either me or someone else will add a test before merging then.
@Fdril could you please elaborate what you mean? Do you want to contribute a test to this PR?

Please open an issue to create a test then @aqrln @Jolg42 - I would not be able to say if this has no side effects :/

Added in our tech debt Slack channel and will be processed there ✅


Network access is required to run?

Issue
Setup:

Deno Version: 1.6.2 (but also occurs for earlier versions)
v8 Version: <replace_with_v8_version>
Typescript Version: 4.1.3
Opine Version: 1.0.0 (but also occurs for versions 0.24.0, 0.25.0, 0.26.0 & 0.27.0

Please replace this line with a short description of the issue.

Details
Since v0.24.0 Opine seems to required network access to run.
Steps to reproduce
Step 1: Create an app.ts file with the following contents
import { opine } from<EMAIL_ADDRESS>
const app = opine();

app.get("/", function(req, res) {
  res.send("Hello World");
});

app.listen(3000);

Step 2: Run deno cache app.ts to cache the dependencies
Step 3: Run `deno run app.ts' and get the following error
error: Uncaught (in promise) PermissionDenied: network access to<EMAIL_ADDRESS>run again with the --allow-net flag
    at processResponse (deno:core/core.js:223:11)
    at Object.jsonOpAsync (deno:core/core.js:240:12)
    at async fetch (deno:op_crates/fetch/26_fetch.js:1278:29)
    at async read (mod.ts:19:15)
    at async init (https://deno.land/x/denoflate@1.1/pkg/denoflate.js:217:45)
    at async mod.ts:23:1

I would have expected this to run without an error.

the option flag, "--allow-net --allow-read" is required to run any deno application (or library) that requires network access, because by default there is No file, network, or environment access, unless explicitly enabled.
as it was stated on  https://deno.land/
@mocoso
can try running it with the flag
   deno run --allow-net --allow-read app.ts

Thanks for raising this @mocoso!
You’re quite right, in 0.24.0 I introduced the denoflate module to handle gzip and deflate. (REF: https://github.com/asos-craigmorten/opine/blob/main/.github/CHANGELOG.md#0240---17-10-2020)
This particular module uses wasm and curiously this is requested dynamically during runtime rather than an install... hence why when you run the application, it requests network access to download this wasm file 😅
I’ve prioritised features over experience til now, but it would be good to start closing in on these security / developer experience aspects as well 😊. If your server doesn’t need net access then the library shouldn’t force you to!
To begin I’m curious if this happens on the run of a hello world Opine example, or only with servers making use of the body parsers given it is in these that the gzip/deflate code lies?
As a starter for 10, I wonder if specifying the wasm import in the deps.ts would suffice to cache the wasm at installation so it is not refetched at runtime, but I am doubtful. In which case the follow-up would be to follow up with the library author, or find an appropriate module substitute!
For now you can limit the security impact of this by specifying deno.land in the —allow-net allowlist.

As alluded in the comment before mine, I’m fairly certain you can’t run an http server in Deno without allowing network access for the local IP and port you are running on, e.g. --allow-net <IP_ADDRESS>:3000 so can’t see dropping the flag completely ever being an option?

To begin I’m curious if this happens on the run of a hello world Opine example, or only with servers making use of the body parsers given it is in these that the gzip/deflate code lies?

It happens with the hello world example above and so affects all opine servers

For now you can limit the security impact of this by specifying deno.land in the —allow-net allowlist.

From a security perspective this seems like a reasonable work around.

There are two non-security reasons that make it useful to run code that imports Opine without it requiring network access (which was possible before https://github.com/asos-craigmorten/opine/pull/81)

For unit testing. ideally unit tests can be run without requiring access to the internet because requiring access to the internet slows the running of tests down and makes them less stable. The same issue is encountered running deno test on a project which imports Opine as is outlined her.

For packaging an app to deploy. I deploy my app as a container and would ideally like that container to already include all the code it requires to run (to make start up faster)

As a starter for 10, I wonder if specifying the wasm import in the deps.ts would suffice to cache the wasm at installation so it is not refetched at runtime, but I am doubtful. In which case the follow-up would be to follow up with the library author, or find an appropriate module substitute!

I am not quite sure if/how this can be achieved but I will investigate

Asking about this on Discord got the following response

wasm imports can solve it (https://github.com/denoland/deno/issues/5609) but not here yet.
for my wasm based module, i just download file locally and load local wasm if its present download it otherwise

Nice sleuthing @mocoso!
I think there is sufficient use-case to keep this open, just not sure of the best way forward... we could even store the wasm in Opine for now but I don’t think that would solve the issue as the runtime request would just be passed onto the opine module rather than within denoflate.
The issue feels to be around the use of fetch within the module to grab the wasm following the lack of import support, if this were to be instead wrapped in “cache-fetch” like method then we’d be sorted... complications arising with where and how this is cached. The Deno directory would make most sense, but to know where that is require env var access and it opens up a whole other can of worms for doing this well - feels almost like a library in itself! All to solve an issue which really Deno should handle through wasm imports, which maybe will drop soon?
Not sure what to suggest for now... we could try and bypass the whole issue through feature switching gzip and deflate so this usage can be switched off (though doesn’t really solve the issue, for your tests it would simply replace a flag with a config setting and you may still want compression support!), or we can explore non-wasm libraries (or write one if doesn’t exist)?

For some prior art, the deno-canvas authors have opted to download and cache the wasm file relatively. REF: https://github.com/DjDeveloperr/deno-canvas/blob/master/lib.js#L4
An update to denoflate’s entrypoint could handle this in the same fashion, though feels a little clunky for wasm files to be popping up in peoples codebases (I guess just explicitly rather than hidden in a Deno directory so maybe not so bad)? Nothing that couldn’t be solved with some documentation I suppose 🤔

Just found https://github.com/deno-library/compress/tree/v0.3.6 which appears to be a typescript implementation of compression line which we may be able to use instead of denoflate, will spike out this weekend and see if is workable

Just found https://github.com/deno-library/compress/tree/v0.3.6 which appears to be a typescript implementation of compression line which we may be able to use instead of denoflate, will spike out this weekend and see if is workable

Hey @mocoso, can you try out 1.1.0 and see if that has solved it? Please reopen if not!

Hey @mocoso, can you try out 1.1.0 and see if that has solved it? Please reopen if not!

It works very nicely. Thank you for resolving this.

It works very nicely. Thank you for resolving this.


Automatically rewrite with PEP 585 types

From pyupgrade (I really want this one personally):

Resolved by #368 and #369.


jetty-server .pom dependency is added inside .war file

jetty-server doesn't make sense inside .war file for the demo apps.
pom.xml accepts a property "packaging.type" with a separate profile for jar / war but it's not affecting jetty-server only pippo-jetty.
PS: There are also some other jetty deps brought but I don't know which one are really necesary in a .war scenario.

It's a bug. If I run mvn dependency:tree I have this result:
[INFO] ro.pippo:pippo-demo-basic:war:0.7.0-SNAPSHOT
[INFO] +- ro.pippo:pippo-demo-common:jar:0.7.0-SNAPSHOT:compile
[INFO] |  +- ro.pippo:pippo-jetty:jar:0.7.0-SNAPSHOT:compile
[INFO] |  |  +- org.eclipse.jetty:jetty-server:jar:9.2.11.v20150529:compile
[INFO] |  |  |  +- javax.servlet:javax.servlet-api:jar:3.1.0:compile
[INFO] |  |  |  +- org.eclipse.jetty:jetty-http:jar:9.2.11.v20150529:compile
[INFO] |  |  |  |  \- org.eclipse.jetty:jetty-util:jar:9.2.11.v20150529:compile
[INFO] |  |  |  \- org.eclipse.jetty:jetty-io:jar:9.2.11.v20150529:compile
[INFO] |  |  \- org.eclipse.jetty:jetty-annotations:jar:9.2.11.v20150529:compile
[INFO] |  |     +- org.eclipse.jetty:jetty-plus:jar:9.2.11.v20150529:compile
[INFO] |  |     |  \- org.eclipse.jetty:jetty-jndi:jar:9.2.11.v20150529:compile
[INFO] |  |     +- org.eclipse.jetty:jetty-webapp:jar:9.2.11.v20150529:compile
[INFO] |  |     |  +- org.eclipse.jetty:jetty-xml:jar:9.2.11.v20150529:compile
[INFO] |  |     |  \- org.eclipse.jetty:jetty-servlet:jar:9.2.11.v20150529:compile
[INFO] |  |     |     \- org.eclipse.jetty:jetty-security:jar:9.2.11.v20150529:compile
[INFO] |  |     +- javax.annotation:javax.annotation-api:jar:1.2:compile
[INFO] |  |     +- org.ow2.asm:asm:jar:5.0.1:compile
[INFO] |  |     \- org.ow2.asm:asm-commons:jar:5.0.1:compile
[INFO] |  |        \- org.ow2.asm:asm-tree:jar:5.0.1:compile
[INFO] |  \- ro.pippo:pippo-jaxb:jar:0.7.0-SNAPSHOT:compile
[INFO] +- ro.pippo:pippo-core:jar:0.7.0-SNAPSHOT:compile
[INFO] |  \- org.slf4j:slf4j-api:jar:1.7.7:compile
[INFO] +- ro.pippo:pippo-freemarker:jar:0.7.0-SNAPSHOT:compile
[INFO] |  +- org.freemarker:freemarker:jar:2.3.22:compile
[INFO] |  \- org.ocpsoft.prettytime:prettytime:jar:3.2.5.Final:compile
[INFO] +- ro.pippo:pippo-jackson:jar:0.7.0-SNAPSHOT:compile
[INFO] |  +- com.fasterxml.jackson.core:jackson-core:jar:2.5.4:compile
[INFO] |  \- com.fasterxml.jackson.module:jackson-module-afterburner:jar:2.5.4:compile
[INFO] |     \- com.fasterxml.jackson.core:jackson-databind:jar:2.5.4:compile
[INFO] |        \- com.fasterxml.jackson.core:jackson-annotations:jar:2.5.0:compile
[INFO] \- org.slf4j:slf4j-simple:jar:1.7.7:compile

So the problem is in pom.xml of pippo-demo-common.

Actually the problem is that the 'war' profile is not activated in demo-parent pom.
I'm creating a pull request

Actually there is no problem, instead of passing the packaging.type one must use mvn -Pwar profile which in turn sets the packaging prop.
It's unclear if the pull request that also sets the profile if the packaging.type=war brings any value.

@decebals can you confirm that by building the demos with the mvn -P war clean package the jetty-server is not present in the war?
It does not appear to be the case for me, but the pom.xml seems to be ok.
"mvn -P war" should deactivate the activeByDefault of the "main" profile but for me it doesn't appear to do this. I'll try tomorrow with another mvn version.

Did the tests again with a clean build myself on work pc. Works perfect.


When I use safe-app-sdk in Next.js, I have got error "window is not defined."

Hello.
I am trying to use<EMAIL_ADDRESS>in Next.js. But I have got error "window is not defined".
If anyone know how to fix, please help me.

Hi @climax-solution. Is your repo public or can i take a look to the code?
Thanks

Fix is ready, will be delivered in next SDK release


object detection dataset

great works！！Can I use the dataset for object detection and how should I modify the configuration?

Yes, you can use object detection datasets. You can refer to this documentation to customise the dataset https://easyfl.readthedocs.io/en/latest/tutorials/dataset.html#customize-datasets


Add seaborn to environment.yml

Required to run polyglot-ds.ipynb
https://hub.mybinder.org/user/binder-examples-i-language-demo-ah2jl97h/notebooks/polyglot-ds.ipynb

Thanks for the catch - I'll merge and then we can see if the repo works! I just added PyPlot to the Julia config file as well, which you noted was missing too.
cc @Carreau

Thanks


spi: Refactor Conn and ConnCloser into Conn, Port and PortCloser

This clarifies the difference on ownership and makes it clear that DevParams()
is essentially a 'connection factory'.
Doing this caught inconsistencies in the unit tests. Made the structs in spitest
enforce the fact that DevParams() can only be called once.

Hi I'd like to know your impressions on this, as I feel this would clarify the separation of "spi connection before it is configured" and "configured spi connection" as an atomic operation by calling DevParams().
The device drivers now essentially accept a "connection factory" spi.ConnConfig. I think it's makes everything cleaner and more maintainable. wdyt?

Codecov Report

Merging #131 into master will decrease coverage by 0.57%.
The diff coverage is 79.05%.

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   85.58%   85.01%   -0.58%
==========================================
  Files          60       60
  Lines        4524     4592      +68
==========================================
+ Hits         3872     3904      +32
- Misses        587      619      +32
- Partials       65       69       +4

Impacted Files
Coverage Δ

conn/spi/spi.go
100% <ø> (ø)
:arrow_up:

devices/ssd1306/ssd1306.go
100% <100%> (ø)
:arrow_up:

conn/spi/spireg/spireg.go
100% <100%> (ø)
:arrow_up:

devices/bme280/bme280.go
98.42% <100%> (+0.01%)
:arrow_up:

devices/lepton/lepton.go
89.44% <100%> (+0.06%)
:arrow_up:

devices/apa102/apa102.go
100% <100%> (ø)
:arrow_up:

conn/spi/spitest/spitest.go
84% <73.03%> (-16%)
:arrow_down:

host/sysfs/spi.go
74.49% <81.17%> (-3.43%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736a47d...e018601. Read the comment docs.

I had an epiphany and realized that Port was the right term to use for an unconfigured Conn.
So this leads to ì2c.Bus and i2c.BusCloser but to spi.PortCloser, spi.Port then spi.Conn. As noted above, this wouldn't preclude from spi.Bus but from trying it out, it didn't give any benefit while making app code harder to use.


Synchronizing multiple opened tabs

Hi, I was wondering what's the workflow when i want to be able to synchronize few opened tabs. Currently if i change language, i have to refresh other tabs in order to see content in new language.
Regards

#265 is the same issue i guess


[coverage][test]modify run-be-ut.sh for run be cov, no need merge

Proposed changes
Issue Number: close #xxx

modify run-be-ut.sh for run be cov, no need merge
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Capitalize lines 100-103

Capitalized lines 100-103 to match other single-line comments

I’ll probably be rewriting this code for D3 4.0, so it doesn’t feel worth it to me to apply this change, sorry. Also, those comments are sentence fragments rather than sentences; complete sentences should be capitalized and have punctuation, but sentence fragments or single words are often done lowercase and without punctuation.