reached the type-length limit while instantiating tokio::runtime::Handle::enter::<...()}]>>)]>, ()}]>}]>, ()}]>], ()>

Describe the bug
   Compiling cargo-fetcher v0.9.0
error: reached the type-length limit while instantiating `tokio::runtime::Handle::enter::<...()}]>>)]>, ()}]>}]>, ()}]>], ()>`
  --> /home/amnesia/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/runtime/handle.rs:72:5
   |
72 | /     pub fn enter<F, R>(&self, f: F) -> R
73 | |     where
74 | |         F: FnOnce() -> R,
75 | |     {
76 | |         context::enter(self.clone(), f)
77 | |     }
   | |_____^
   |
   = note: consider adding a `#![type_length_limit="2014460"]` attribute to your crate

error: aborting due to previous error

error: failed to compile `cargo-fetcher v0.9.0`, intermediate artifacts can be found at `/tmp/cargo-installoI3KJo`

Caused by:
  could not compile `cargo-fetcher`.

Not much to explain, the rust compiler did a great job at it.
This is the case on my Linux laptop and windows work machine.
To Reproduce

cargo install cargo-fetcher

Expected behavior
cargo-fetcher installs.
Device:
1.

ThinkPad T495s
Manjaro Linux
Linux Kernel: <IP_ADDRESS>-MANJARO
Cargo: 1.46.0
Rustc: 1.46.0 (04488afe3 2020-08-24)
Rustup: 1.22.1 (b01adbbc3 2020-07-08)

Wierd old Computer at Work
Windows 10
Cargo: ?
Rustc: ?
Rustup: ?

Additional context
Sorry if this issue sucks, I'm just not very sure what to put else here.

I had this as well after updating to 1.46, but I haven't had it since updating to 1.47 or higher, so I'm closing this for now, sorry I'm late in closing this!


Manage external IP mask

Hello,
in all 3 examples you have used mask 32, and in the article it is stated
For IPv4, use mask 32. For IPv6, use mask 128
so i am not really sure if it is supported to use different bitmask to add ip range ? or must we use bitmask 32 for IPv4?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ad0130c8-4343-ba04-cd55-0c3305a14347
Version Independent ID: 24db6f00-bfdc-ea9c-6922-e9f09e5cef27
Content: Direct Routing Local Media Optimization - Microsoft Teams
Content Source: Teams/direct-routing-media-optimization-configure.md
Service: msteams
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

@waelschakaki thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Remove pnpm-workspace since this is not a repo with multiple pkgs

LGTM

Why was it there in the first place?
Anyway, I have a minor comment

Apparently when it was being migrated to here from the core repo, it was thought to be needed for the test to work but that is clearly not the case


Add JSON support to RequestBuilder

Using serde/serde_json:
// on RequestBuilder
fn json<T: Serializable>(mut self, json: T) -> Self {
    // sets Content-Type to json
    // sets body to serialized json bytes
}

Would allow:
reqwest::post(url)
    .json(SomeSerializableThingy::new())
    .send()

This has been added. It could use some more documentation.


[2.1] Cleanup ErrorHandler

For 2.1 some cleanup can be done in the ErrorHandler component.

[x] Remove HHVM code (#14280)
[ ] Check if we can remove handleFatalError, since they are now thrown instead.
[ ] (re)Consider using some library like whoops (I know this has been previously considered in #297, but it makes sense to reconsider this from time to time)

I was just looking into this, some more, what is your opinion on removing the global exception handler after application initialization?
Currently the global registration via set_exception_handler is a side effect.
While there might be cases where we need it (during init or bootstrap), as soon as we enter run():
try {
            $this->state = self::STATE_BEFORE_REQUEST;
            $this->trigger(self::EVENT_BEFORE_REQUEST);

            $this->state = self::STATE_HANDLING_REQUEST;
            $response = $this->handleRequest($this->getRequest());

            $this->state = self::STATE_AFTER_REQUEST;
            $this->trigger(self::EVENT_AFTER_REQUEST);

            $this->state = self::STATE_SENDING_RESPONSE;
            $response->send();

            $this->state = self::STATE_END;

            return $response->exitStatus;
        } catch (ExitException $e) {
            $this->end($e->statusCode, isset($response) ? $response : null);
            return $e->statusCode;
        }

We could add another catch statement from which we invoke the error handler.

I see no pros compared to handling exceptions via set_exception_handler.
There are still exceptions outside run() to be handled.

It is a side effect that changes global state.

Alright. How would you deal with exceptions outside of run() method then?

Haven't said I have it all figured out ;).
We have 4 phases

before construction
construct / init
run
after run

The first and last one are technically out of scope of the app; currently we can't handle 1 but we do handle 4.
We need to solve step 2, 4 is easy. One simple solution is to register the exception handler and unregister it at the end of the init phase.
Mostly I feel having special components is a code smell. And I'd like to gather some more opinions on this case.

@yiisoft/core-developers, @yiisoft/reviewers ?

There are also 'shutdown' functions. which are run on script termination outside of the application scope.
They may trigger extra errors. Having error handler attached all the time is an insurance every error including ones causes by application destruction (e.g. at Application::__destruct() and destructor of any internal object) or at shutdown function will be at least logged.

That's a good point; destruction matters as well.

Wrapping Application::run() into a try...catch is unlikely to suffice.
At the present state error handler is registered during Application instance creation, e.g. at Application::__construct(). It is registered before other components and other application initialization code, thus it is able to handle any error or exception causes by application internal components processing. Thus global try...catch should cover application construction as well, which demands creation of another static method for application run:
class Application extends Module
{
    public static function runApp($config)
    {
        try {
            $app = new static($config);
            $app->run();
        } catch (\Throwable $e) {
            if (isset($app) && isset($app->errorHandler)) { // error may occur before application created or error handler initialized
                $app->errorHandler->handleException($e);
            } else {
                throw $e;
            }
        }
    }
}

// file `index.php`
$config = require(__DIR__ . '/../config/frontend.php');
yii\web\Application::runApp($config);

For my taste this looks a little ugly.

Yii may introduce its onw 'application end' callbacks list to be used instead of register_shutdown_function() and will be invoked at the application run ending. Thus saving session, writing logs and so on should be performed through it.
But in case developer uses some 3rd party library, which relies on register_shutdown_function() those callbacks will drop out of Yii error handling or logging.
Also developer will be stripped of ability to terminate script flow using exit or die operators, as thier invocations will prevent Yii ending callbacks to be executed, meaning no session will be written no logs flushed and so on.

It is a side effect that changes global state.

If you concern about about error handler remains registered after application running is complete, you can always invoke ErrorHandler::unregister() after application run:
$config = require(__DIR__ . '/../config/frontend.php');
(new yii\web\Application($config))->run();
Yii::$app->errorHandler->unregister();
//script continues

Updated https://github.com/yiisoft/yii2/blob/master/docs/internals/design-decisions.md since, because of things mentioned by @klimov-paul, handler is unlikely to be done in another way.

Why closing?

Hmm, was writing a post and then decided not to post it; clicked close instead of closing the page :|
Could you move this to core?


⚠ Bofrost.de has degraded performance

In 03151c3, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1253 ms

Resolved: Bofrost.de performance has improved in a44a9ad.


Where is source code?

Release tar and zip files do not contain any source. Is it possible to run this without docker? This is hinted at in the readme but it seems like there is a missing section or two.

@jjv5 ,
DeepSomatic uses the same codebase as DeepVariant. To maintain development cadence and not break the simultaneous development branches, the code of DeepSomatic can be found under DeepVariant. For example, r1.7 is available here: https://github.com/google/deepvariant/tree/r1.7 with the run_deepsomatic script available through: scripts/run_deepsomatic.py

If you want to build the dockerfile, it's available here: https://github.com/google/deepvariant/blob/r1.7/Dockerfile.deepsomatic


Review LogMessages across assemblies to ensure partitioning of error space

In 5.2.0 we have added a number of new assemblies. Each of these has a LogMessage file.
Each of these should have it's own range for error id's.
Some messages are duplicated.
For example: Saml and Saml2 both define: IDX10400.

Once this is done we will be in a position to provide FAQ's and help on error messages.

Partition id's as per xls that we worked on.


Add Splunk notice to README

This small PR adds the acquisition notice with a link to the README file.

Codecov Report

Merging #301 (6ddf4ef) into main (99ce426) will decrease coverage by 2.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   77.17%   74.93%   -2.24%
==========================================
  Files          47       47
  Lines        2278     2278
==========================================
- Hits         1758     1707      -51
- Misses        471      517      +46
- Partials       49       54       +5

Flag
Coverage Δ

Linux
?

Windows
?

macOS
74.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...c/confluent-kafka-go/kafka/splunkkafka/producer.go
67.67% <0.00%> (-19.20%)
:arrow_down:

...c/confluent-kafka-go/kafka/splunkkafka/consumer.go
75.20% <0.00%> (-13.23%)
:arrow_down:

...n/github.com/lib/pq/splunkpq/internal/connector.go
50.25% <0.00%> (-6.54%)
:arrow_down:

instrumentation/database/sql/splunksql/config.go
81.94% <0.00%> (-2.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ce426...6ddf4ef. Read the comment docs.

Hi @MrAlias :

  if for formatting. GH renders the emoji with no separation from the word that comes after. Happy to apply a suggestion
See the message in Slack as for what we're trying to accomplish.

Thanks!

@MrAlias What's the rationale for enforcing 80 columns per line? It's not enforced in most other repos, and I'd argue it's a bit outdated in most cases. Even Linus agrees :) https://linux.slashdot.org/story/20/05/31/211211/linus-torvalds-argues-against-80-column-line-length-coding-style-as-linux-kernel-deprecates-it

@MrAlias What's the rationale for enforcing 80 columns per line? It's not enforced in most other repos, and I'd argue it's a bit outdated in most cases. Even Linus agrees :) https://linux.slashdot.org/story/20/05/31/211211/linus-torvalds-argues-against-80-column-line-length-coding-style-as-linux-kernel-deprecates-it

IIRC it's the default config of markdownlint that was setup when the project was created.


Nominate myself @fourierr(maxiangbo) as a Review member

@fourierr(maxiangbo)
I am a contributor from China Merchants Bank and uses Kubevela to promote construction of private cloud. I has been actively contributing to KubeVela Core and three of his pull requests have been merged.
oam-dev/kubevela/pull/3393
oam-dev/kubevela/pull/3452
oam-dev/kubevela/pull/3462
I has met the requirement for the Review role of KubeVela membership. So nominate him as a Review member.
Please sponsor me with 👍.

LGTM


Add an option to compile using css variables

Would be great to have an option (either in node or a sass variable) to choose to not hard-code the colors, but use css variables instead!
So, for example, the class .bg-secondary would compile like this :
.bg-secondary {
  background-color: var(--secondary) !important;
}

Of course this could be extended to not only the theme colors, but pretty much any common value
The benefits I see are :

Most new projects do not support or try to support IE, these end up missing a lot of flexibility not using css variables. 93% of user browsers support css variables
You wouldn't need to recompile Bootstrap to change the colors, development and testing would be much quicker, not everyone that uses Bootstrap knows how to deal with SASS/NodeJS
You'd be able to change colors on the fly, for example if you want to leverage the prefers-color-scheme selector to quickly change between light/dark mode

I understand the historical purpose of the compiled colors, but it would be great to have an alternative!

Also, this article is cool : https://medium.com/@Hermanhasawish/how-i-repainted-bootstrap-without-sass-d789f41aa74b

Most new projects do not support or try to support IE

Still a lot do. We decided to keep IE support for Bootstrap 5 so we can't implement this yet. Once we drop IE support, we will probably switch to CSS variables.

@MartijnCuppens
Yes I understand, but just reiterating that I'm talking about a compiling option, not to drop IE support

have some mercy on angular developers,  the demand for dark mode and multiple themes has increased significantly. this is driven from Apple having dark mode as an option on  OS and IOs.
I know Material (https://material.angular.io/) offers a better solution for having dynamic themes.  (some of us like bootstrap)
I've read most of the comments against having CSS variables, but the reality is the industry adds features when is trendy and it seems there isn't a nice solution for this on bootstrap.
shouldn't the focus be on the future feature on V5 instead of having to support old mate Internet Explorer?
overall look bootstrap and thanks for everything you guys do <3


LDAP via Authentik

Wanted to harden my login and potentially migrate my local user to an Authentik login, I see the LDAP in the application-dev.yml
is this currently working?
Edit: I did see #10 , just didn't see docs on LDAP

Found the docs 🤦🏼♂


Initial implementation of Relational Neural Gas.

Coverage increased (+0.2%) to 89.815% when pulling 15558140c7de73e7f74ce4a0b359ba899358f365 on neural-gas-algos into 9bde03266d4180952629fbaab65ef2e03b5ee5a6 on master.


3D Point transform from depth coordinate system to color coordinate system

Required Info

Camera Model
L515

Operating System & Version
Win 10

Platform
PC

SDK Version
2.0

Language
python

Segment
Robot

Issue Description
<Describe your issue / question / feature request / etc..>
Hello everybody,
I got the intrinsics for the depth and the color camera
I created a point cloud with help of the RealSense SDK functions:
rs_PC = rs.pointcloud()
rs_PC.map_to(color_frame)
rs_PointCloud = rs_PC.caluclate(depth_frame)
rs_PointCloud.export_to_ply(path, color_frame)
After this I work with PCL and Open3D to get center points of a plane. And then I want to transform this point to the color camera coordinate system but I point don't know in which coordinate system lies the point cloud. (from the depth sensor or the color sensor)
To get some background to the project:
With the help of the RGB camera and ArUco Marker I estimate the pose of a robot. This works fine so far. When I measure a point in the ArUco marker coordinate system I can send this point through the transformations to the color camera and then to the gripper coordinate system with the hand-eye calibration.  This works.
But I want to use the Lidar sensor from the L515 for depth information so I calculate a point cloud and get the center of a plane in this Pointcloud. This Works too.
But now I want to send this point to the gripper, so I need this point in the color camera coordinate system. And there is the problem.
Can someone tell me how I can transform the point?
In which coordinate system lies the point cloud? The depth camera or the color camera coordinate system?
I don't know why but I thought the camera coordinate system is:
x-Axes: right
y-Axes: left
z-Axes: out of the camera
So I thought the z coordinate of my points should be positiv but I got negative points.
Thanks for your help.

Case closed!
I had to rotate the saved .ply point cloud file with open3d around the x axes at 180° with the center point (0,0,0)

Hi, i have this same case. But i don't know the reason for rotating the saved .ply point cloud file with open3d around the x axes at 180° with the center point (0,0,0).
Thanks for your reply!


CA-164 - Adds server access log feature.

Adds S3 bucket server access log opt-in/opt-out feature.

:tada: This PR is included in version 1.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat(xworkspaces): Add support for showing number of windows in a workspace

This adds support for an %nwin% token in xworkspaces that shows the number of windows. This is related to #604
Here is the relevant config:
[module/ewmh]
type = internal/xworkspaces

enable-click = true
enable-scroll = false

icon-0 = TXT;
icon-1 = WEB;
icon-2 = EXT;
icon-3 = FLT;
icon-default = 

label-active = "  %icon% %name% [%nwin%] "
label-active-foreground = ${colors.foreground}
label-active-background = #882E3440
label-active-underline = ${colors.accent-light}

label-occupied = "  %icon% %name% [%nwin%] "
label-occupied-foreground = ${colors.foreground-alt}

label-empty = "  %icon% %name% [%nwin%] "
label-empty-foreground = ${colors.foreground-alt}

A screenshot showing the above config in action.

Closes #604

Closing due to inactivity


\yii\db\pgsql\QueryBuilder::dropIndex() cannot remove unique index created by \yii\db\Migration::createTable()

I can't drop unique index from column if it was created while table creation (PostgreSQL 9.5.4).
Such index is created as table constraint and "DROP INDEX" cannot drop it.
I haven't found any workaround for this problem yet :(
Please help.
What steps will reproduce the problem?
$this->createTable('test', ['id' => $this->primaryKey(), 'name' => $this->string(255)->unique()]);
// Constraint "test_name_key" was created by createTable()
$this->dropIndex('test_name_key', 'test');

What is the expected result?
After this migration you should get table without unique index.
What do you get instead?
Exception: SQLSTATE[2BP01]: Dependent objects still exist: 7 ERROR:  cannot drop index test_name_key because constraint test_name_key on table test requires it
HINT:  You can drop constraint test_name_key on table test instead.
The SQL being executed was: DROP INDEX "test_name_key"

Additional info

Q
A

Yii version
2.0.10

PHP version
7.0.11

PostgreSQL version
9.5.4

Operating system
Ubuntu 14.04

I've found workaround.
Instead of:
$this->dropIndex('test_name_key', 'test');

you should write this:
Yii::$app->db->createCommand('ALTER TABLE test DROP CONSTRAINT test_name_key')->execute();

But it's not platform-independent anyway.

How would you solve the issue? Seems both unique constraints and unique indexes are possible. Moreover, both could be added for the same field.
http://flatiron.engineering/technology/2016/09/13/uniqueness-in-postgres.html

I would say ->unique() adds a constraint, which in turn adds an index, hence $this->execute('ALTER TABLE test DROP CONSTRAINT test_name_key'); would be appropriate.

While technically unique indexes are “powered” by constraints, it’s IMO a common case and should be handled by db.


Password Alias attribute for dcm:key and dcm:certificate elements

The dcm:certificate and dcm:key elements indicate a password attribute however that is deprecated.  Is there password alias attribute that can be used?

This missing feature has also irritated me for quite some time and I'm quite sure it has lost DCM some users over the years.
That said, I wouldn't worry too much about using a deprecated DP feature in pre-production environments. So you are ok where you absolutely need deployments to be fully automated (e.g. CI/CD pipelines).
When it comes to production, you can minimize the pain by using the "objects-from-def" DCM task and a definition file with something like this:
<dcm:object-create> 	<PasswordAlias name="MyPasswordAlias"> 		<mAdminState>enabled</mAdminState>	 		<UserSummary>Blah blah blah</UserSummary> 		<Password>${my.password}</Password> 	</PasswordAlias> </dcm:object-create>
Then post-deploy you will just need to manually use the UI to select the correct PasswordAlias for all your Key objects. Good enough for a handful of passwords; bad luck if you have dozens I'm afraid...


when security group yaml make an error and applyed,the sg rules work properly,some rules deleted and the egress rule is empty

Describe the bug
when security group yaml make an error and applyed,the sg rules work properly,some rules deleted and the egress rule is empty
I installed the latest version of ec2-controller and still get the same error
Steps to reproduce
Expected outcome
A concise description of what you expected to happen.
Environment

Kubernetes version
Using EKS (yes/no), if so version? yes
AWS service targeted (S3, RDS, etc.)

Hi @Scumwong - can you please share an example of the yaml file you're trying to apply and a concise description of what you expect to happen?

`apiVersion: ec2.services.k8s.aws/v1alpha1
kind: SecurityGroup
metadata:
name: test-sg
spec:
description: http
egressRules:

fromPort: 0
ipProtocol: '-1'
ipRanges:

cidrIP: <IP_ADDRESS>/0
description: ''
toPort: 0
ingressRules:

fromPort: 80
ipProtocol: tcp
ipRanges:

cidrIP: <IP_ADDRESS>/0
description:
cidrIP: <IP_ADDRESS>/0
description:
toPort: 8080
name: test-sg
vpcID: vpc-05ffcf85f02e8d651`

Just like the yaml above,there is repeated rule.when i apply the yaml ,error occers and shows that repeated rule,and the sg got no rule,include egress.What i want is that when there are incorrect configurations,the log shows the erroe,but do not affect the previous security group rule


[CI/textlint] "Auto Config*" rewrite-rule capitalization fix

Completes the fix for #3891
Fixes the "Auto Config*" rewrite-rule so that it forces the "c" in "config*" to be in lowercase
Scrubs some page-local dictionaries

works for me, since this mainly affects java so far, would be good to hear if this makes sense?

works for me, since this mainly affects java so far, would be good to hear if this makes sense?

@svrnm - the rule is already present in the TextLint config, this PR is just a fix to the rule. So, ... is this good to merge?

Would a sentence starting with Configure would be accepted with the new rule, for example:

Configure this library in the following way:

@jeanbisutti - such an occurrence would not be affected by the rule.

works for me, since this mainly affects java so far, would be good to hear if this makes sense?

@svrnm - the rule is already present in the TextLint config, this PR is just a fix to the rule. So, ... is this good to merge?

Yes :-)


Not ABle to add Gradle dependency

I am not able to add gradle dependecy.
Added the following line to the build.gradle file
compile 'net.jodah:failsafe:0.9.3'
The Dependency that got included is joda-time:2.9.4

Is there a particular class where you're seeing a dependency on joda-time? I'm not seeing it.

I want to use CircuitBreaker. I added up the dependency but could not import the class since the joda-time :2.9.4 jar does not contain CircuitBreaker class. Am I using it wrongly? If so, how to use a CircuitBreaker. In the Docs I could see you have just instantiated CircuitBreaker and worked with it.
Thanks,

You might check your gradle settings again. joda-time is unrelated to Failsafe. The proper dependency to import is here.


Open a new file instead of fire a message

What do you think about following feature

Open an empty file when no spec/test or target file presents.

It can be adopted from https://github.com/wangyuhere/atom-rails-rspec or something like this. It can be prepopulated from grammar based template. For instance if we working with rails we can specify default template for Model <-> Model Spec , Controller <-> Controller Spec etc.

Open an empty file when no spec/test or target file presents.

I can imagine that being useful. How would you determine the path for the empty file?

It can be prepopulated from grammar based template. For instance if we working with rails we can specify default template for Model <-> Model Spec , Controller <-> Controller Spec etc.

I'd like to keep the package focused strictly on toggling between a source code file and its corresponding test file. While templates might be useful, I wouldn't personally get enough benefit from that functionality to justify the increased complexity that it would bring to the package's codebase. For those reasons, I'd be hesitant to add support for templates.


Revert app list: Latest on the bottom.

One should scroll always from bottom to the top and the latest app should be on the bottom always just above the keyboard.

@volnes, what do you think?

not bad)

Any news about that feature?

Non. Didn't have time.

@volnes I am afraid people may find it confusing. What do you think?

IMO just add an option for it.. better than forcing everyone to use it that way :)

@vackosar yes it's confusing a little

Wont be implemented for now.


feat(behavior_path_planner): stabilize lane_following end points

Signed-off-by: Takayuki Murooka<EMAIL_ADDRESS>Description
Stabilize end points of path_with_lane_id generated by lane_following module in the same way as avoidance and sideshift.
Small refactoring is contained in this PR.

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

I confirmed that lane_following, avoidance and sideshift work well with this PR.
@TakaHoribe @rej55 Could you review this PR


BLD: libgfortran 3.0 is failing our build, so pin to 1.0

Merged with https://github.com/quantopian/zipline/commit/ba42e6d8b972dcce9271526562ceff0cddd3fa30


Would be use to be able to run simplify() (NOT transform()) AFTER a tokenizer step

To understand why I would like to be able to apply simplify() rather than transform() Ill explain my use case.
I am comparing artist credits for a song, in the case of classical music releases the artist credit often contains multiple composers/performers separated by a comma or semicolon. Sometimes composers are given their surname other times their whole names so for the most popular composers I want to simpilify their names.
i.e
beethoven; london symphony orchestra to
ludwig van beethoven, symphony orchestra
To do this I need to tokenize on ',;' so i can use ClassicalComposerShortner to replace 'ludwig van beethoven' with 'beethoven' by looking up value in a map, but I then want to run my srs simplier which amongst other things remove all punctution with .replaceAll("\p{Punct}","").. So I want to this to be applied to the whole string not just the tokens, of course I cant do this before I run tokenizers because at that point I need the punctuation in order to tokenize it, and the code doesnt support simplifiers after tokenization.
I suppose I could do this by doing some string processing before passing them tot he metric builder but I wanted to show you a reason why it would be useful to be able to simplify after tokenization to see if this would make sense for the library. After tokenization you no longer have the complete string so I guess what would be needed would be some kind of reversible tokenizer that can tokenize, allow some transforms then untokenize whilst keeping the transform.
StringMetric metric = with(new CosineSimilarity<String>())
                .simplify(new EquivalentCharsSimplifier())
                .simplify(Simplifiers.toLowerCase())
                .simplify(Simplifiers.removeDiacritics())
                .tokenize(Tokenizers.pattern("[,;]")) //Multiple artists
                .transform(new ClassicalComposerShortener())
                .simplify(srs)
                .tokenize(Tokenizers.whitespace())
                .filter(not(in(commonWords)))
                .transform(new RemovalPlurals())
                .tokenize(Tokenizers.qGram(2))
                .build();

So you want to be able to this transformation?
"ludwig van beethoven, symphony orchestra - opus 5"       //initial string
["beethoven", "symphony orchestra - opus 5"]              // split on the comma
["beethoven", "symphony orchestraopus 5"]                 // other punctuation removed

And for that you want to use a Simplifier rather then a function. You could write a simple wrapper and use that to transform your simplifier but I suppose it wouldn't be a bad thing to add  a .transform(Simplifier) method to the builders.
public static Function<String,String> simplifierToFunction(final Simplifier s){
   return new Function<String,String>(){
        public String apply(String token){
          return s.simplify(token);
        }
   }
}

I may have a solution (see end of post) but Im not entirely sure if you have understood my point, I'll try again.
I want to replace certain strings e.g "ludwig van beethoven" with "beethoven", to me this seems like a use of transform(), replacing one token value with another value rather than parsing the whole string to find occurences of "ludwig van beethoven" I would just compare each token.
However "ludwig van beetthoven" is not a final token because I tokenize my white space (and then ngrams but this is irrelevent for this discussion) , so I cant run transform() after whitespace tokenizer. But I could use if I tokenized by (,;), the troiuble is I then cant use my simplifier because that cant after a tokenizer.
This is my simplifier method
 public String simplify(String input) {

        if(input==null)
        {
            return null;
        }

        String result =  input
                .replace("[", "(")
                .replace("{", "(")
                .replace("]", ")")
                .replace("}", ")")
                .replace(" & ", " and ")
                .replace("\"", "")
                .replace("'","")
                .replace("-", " ")
                .replace(":", " ")
                .replace(";", " ")
                .replace(",", " ");
        return result.replaceAll("\\p{M}", "").replaceAll("\\p{Punct}","").replaceAll("\\p{Space}"," ").trim();
    }

Having said that perhaps I could rewrite my simplifier so it removed all punctuation except ';' and ',', and then it could be ran before the first tokenizer. Maybe the roles of simplier, transformer just nee dmore explanation.

The simplifier works on the string before it is tokenized. The transformer works on the individual tokens that the tokenizer produces. Functionally there is no real difference as both have the signature String -> String.

Yes I understand the difference but has performance implications, for example replacing a token with another value it much more efficient than searching for those tokens in a string if there are many words to search for and replace since the second method requires a regex for each pair using tokens does not.
But I have fixed my particular issue my changing simplifier to
return result.replaceAll("\\p{M}", "")
                .replaceAll("(?![,;])\\p{Punct}", "")
                .replaceAll("\\p{Space}"," ").trim();

    }

so the , and ; remain so can be tokenized in the first instance based on these, run the transformer and then tokenize again based on white space

Function<String, String> composerNameTransform = new Function<String, String>() {

	@Override
	public String apply(String s) {
		if ("ludwig von beethoven".equals(s)) {
			return "beethoven";
		}

		return s;
	}
};

Predicate<String> commonWords = new Predicate<String>() {
	@Override
	public boolean apply(String s) {
		return !"london".equals(s);
	}
};

StringMetric metric =
		StringMetricBuilder.with(new CosineSimilarity<String>())
				.simplify(Simplifiers.toLowerCase())
				.tokenize(Tokenizers.pattern("[,;]"))
				.transform(composerNameTransform)
				.tokenize(Tokenizers.whitespace())
				.filter(commonWords)
				.tokenize(Tokenizers.qGram(3))
				.build();

System.out.println(metric.compare(
    "Ludwig Von Beethoven; Symphony Orchestra",
    "beethoven symphony orchestra"));
System.out.println(metric.compare(
    "Ludwig Von Beethoven, London Symphony Orchestra",
    "beethoven symphony orchestra"));

I dont think you are getting my point - which was it would be useful to be able to run a simplifier (not a tranformer) after a tokenization step, but maybe its a silly idea anyway so since Ive solved the issue anyway please dont waste any more time on it.


Leverage AI Search indexer (with integrated chunking and vectorization)

This issue is for a: (mark with an x)

[ ] bug report -> please search issues before submitting
[x] feature request
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Expected/desired behavior
Eventually, users often want continuous indexing of a blob storage. The local script could ingest the files to a blob storage and configure the indexers and skillsets (e.g. Form Recognizer/OCR) for continuous reindexing.
Azure AI Search has an integrated chunking and vectorization engine in public preview, thus not ready for production yet. However would be good to investigate if more native AI Search features can be incorporated in this example in the future.
See https://techcommunity.microsoft.com/t5/ai-azure-ai-services-blog/announcing-the-public-preview-of-integrated-vectorization-in/ba-p/3960809
Documentation: https://learn.microsoft.com/en-us/azure/search/vector-search-integrated-vectorization
Example notebook: https://github.com/Azure/azure-search-vector-samples/blob/main/demo-python/code/azure-search-integrated-vectorization-sample.ipynb
Advantages

Continous reindexing out of the box
Easy to index new documents (even via UI), by uploading to blob storage

Disadvantages

Harder to test different chunking strategies

@iMicknl thanks, @srbalakr  is looking into this


Filter inactive monitors (Windows)

Fixes an EnumerationMismatch error on Windows that occurs when having a display physically connected but not enabled.

Thank you for the fix! Is there anything else to do to address #4 ? If not, I will merge and publish a new version.

So it is as much as I think I can do for now - whether or not we have fixed all possible situations a EnumerationMismatch error could arise I do not know. I have written up a full investigation of what is going on in #4 .
Either way this PR will fix the situation where we have Show only on 1 display set so it is definitely worth merging.


[FRONTEND][TFLITE] get input tensor information from graph

get input tensor information from graph

Any other comments?

Any other comments?

Sorry I forgot to check this again after CI.

@FrozenGene can you have a look on this one, and merge if you think it is ok?


[indexer] Fix incorrect RelationCalledBy for pseudo accessors

reportPseudoAccessor is called when visiting AbstractStorageDecl references to report getter/setter calls as appropriate.  It calls initCallRefIndexSymbol to initialize the call reference and that method adds the top of the entities stack as the calling method/function. That's normally the right behavior, but in this case that's the AbstractStorageDecl itself. This patch corrects that behavior and the previously incorrect tests.

@swift-ci please smoke test

What are pseudo-accessors?

From my understanding, fake accessors that only exist in the index. From the code:
if (!VarD->getGetter() && !VarD->getSetter()) {
        // No actual getter or setter, pass 'pseudo' accessors.
        // We create accessor entities so we can implement the functionality
        // of libclang, which reports implicit method property accessor
        // declarations, invocations, and overrides for properties.


FlutterFragment could not be hidden on some Android versions

I need to hide and show fragment without removing it. I have used method hide of FragmentTransaction
FragmentManager fragmentManager = getSupportFragmentManager();
FlutterFragment flutterFragment = (FlutterFragment) fragmentManager.findFragmentByTag(TAG_FLUTTER_FRAGMENT);
if (flutterFragment != null) {
	fragmentManager
			.beginTransaction()
			.hide(flutterFragment)
			.commitNow();
}

It works on Android 10, but does not work on 8 and 9.
Code to add fragment:
FragmentManager fragmentManager = getSupportFragmentManager();
FlutterFragment flutterFragment = (FlutterFragment) fragmentManager
		.findFragmentByTag(TAG_FLUTTER_FRAGMENT);
if (flutterFragment == null) {
	flutterFragment = FlutterFragment.withCachedEngine(FLUTTER_ENGINE_ID).build();
	FragmentTransaction transaction = fragmentManager.beginTransaction();
	transaction.add(
			R.id.flutter_container,
			flutterFragment,
			TAG_FLUTTER_FRAGMENT
	).commitNow();
}

Full example in attach
flutter_fragment.zip

Hi @CruorVult
Tried your code sample on latest master channel, it hides the flutter fragment on Android 10 but not Android 8
Android 8 not working

Android 10 not working

flutter doctor -v
[✓] Flutter (Channel master, 1.20.0-1.0.pre.132, on Mac OS X 10.15.5 19F101,
    locale en-GB)
    • Flutter version 1.20.0-1.0.pre.132 at
      /Users/tahatesser/Code/flutter_master
    • Framework revision<PHONE_NUMBER> (3 days ago), 2020-06-19 16:15:58 -0700
    • Engine revision 676cd566f7
    • Dart version 2.9.0 (build 2.9.0-17.0.dev 7e72c9ae7e)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (6 available)
    • SM M305F                  • 32003c30dc19668f          • android-arm64  •
      Android 10 (API 29)
    • Android SDK built for x86 • emulator-5554             • android-x86    •
      Android 8.0.0 (API 26) (emulator)
    • Taha’s iPhone             • 00008020-001059882212002E • ios            •
      iOS 13.5.1
    • macOS desktop             • macos                     • darwin-x64     •
      Mac OS X 10.15.5 19F101
    • Web Server                • web-server                • web-javascript •
      Flutter Tools
    • Chrome                    • chrome                    • web-javascript •
      Google Chrome 83.0.4103.106

• No issues found!

Hi, I'm facing FlutterFragment could not be hidden on Android7.1.2

same isue

Hi, I hava a solution, but I don't know if there will be unexpected side effects. extends FlutterFragment and override FlutterFragment#onFlutterSurfaceViewCreated(FlutterSurfaceView) to get the flutterSurfaceView instance,  and set flutterSurfaceView's visibility on Fragment#onHiddenChanged(boolean).
class MyFlutterFragment : FlutterFragment() {

    private var flutterSurfaceView: FlutterSurfaceView? = null

    override fun onFlutterSurfaceViewCreated(flutterSurfaceView: FlutterSurfaceView) {
        super.onFlutterSurfaceViewCreated(flutterSurfaceView)
        this.flutterSurfaceView = flutterSurfaceView
    }

    override fun onHiddenChanged(hidden: Boolean) {
        super.onHiddenChanged(hidden)
        flutterSurfaceView?.visibility = if (hidden) View.GONE else View.VISIBLE
    }
}

Hi, I hava a solution, but I don't know if there will be unexpected side effects. extends FlutterFragment and override FlutterFragment#onFlutterSurfaceViewCreated(FlutterSurfaceView) to get the flutterSurfaceView instance, and set flutterSurfaceView's visibility on Fragment#onHiddenChanged(boolean).
class MyFlutterFragment : FlutterFragment() {

    private var flutterSurfaceView: FlutterSurfaceView? = null

    override fun onFlutterSurfaceViewCreated(flutterSurfaceView: FlutterSurfaceView) {
        super.onFlutterSurfaceViewCreated(flutterSurfaceView)
        this.flutterSurfaceView = flutterSurfaceView
    }

    override fun onHiddenChanged(hidden: Boolean) {
        super.onHiddenChanged(hidden)
        flutterSurfaceView?.visibility = if (hidden) View.GONE else View.VISIBLE
    }
}

Thank you~

this problem still exits in flutter 3.0.5

this problem still exits in flutter 3.0.5
I post a question
https://stackoverflow.com/questions/73454694/flutter-reuse-fragment-float-above-other-views

This issue seems to have been fixed on the latest stable channel as I cannot reproduce it there on some below Android versions.

Android 8.0
Android 9.0

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.7.12, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.7.12 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4d9e56e694 (2 days ago), 2023-04-17 21:47:46 -0400
    • Engine revision 1a65d409c7
    • Dart version 2.19.6
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.77.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.62.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 13 (API 33)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 112.0.5615.137

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[!] Flutter (Channel master, 3.10.0-10.0.pre.38, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.10.0-10.0.pre.38 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7aa01f53f8 (38 minutes ago), 2023-04-20 22:31:11 -0400
    • Engine revision 122c3b3820
    • Dart version 3.1.0 (build 3.1.0-26.0.dev)
    • DevTools version 2.23.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio Flamingo.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio Flamingo.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.77.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.62.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 112.0.5615.137

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

I will close this issue since it has already been fixed on the stable channel. If you still experience this issue on the stable channel, kindly leave a comment below and I will reopen this. Thank you!


openpgp: address CORE-2344

via vendored PR keybase/go-crypto#5

(Already got sign-off from @oconnor663, but this PR for C/I's benefit)


Local port forward (-L) from sish

Hello!
I have another question ;-)
When publishing TCP ports with aliases to sish, I can local forward these from another machine after.
Also, if the 2nd ssh client is not asking any remote port forward (-R) the connection is considered "unbound" and is terminated according to --cleanup-unbound, which is expected I guess.
However, the local port is working for only 1 tcp connection.
As soon as I disconnect from the local port, sish terminates the whole session of the 2nd ssh client.
Is this expected as well ?
Or is there a workaround ?
Thank you!
Regards,
Olivier

Hey @blop,
Can I have some SSH commands to reproduce this/understand what you're expecting? Sorry for the delay between getting to this. My life has been busy and sish unfortunately hasn't been a priority but I'm trying to change that :)
You'll see some progress on the other features you mentioned over the next day!

Hello @antoniomika,
Thanks for your hard work on sish ;-)
The local port fortward -L is described in the SSH man page.
The idea is to make some TCP port open on the target available locally.
In the Sish context, it can be used to extend a tunnel further, or make it available to clients that cannot access sish directly.
Currently, it's working only partially.
Small example :
@ Machine A

Service running on port 80

A first SSH client which publish that service on sish (using a TCP alias to keep it private) :
ssh -R myalias:1234:localhost:80 sish.server`

@ Machine B

A second SSH client connects to sish and wants to extend that tunnel with another one in the opposite direction, publishing the service locally :
ssh -L <IP_ADDRESS>:80:myalias:1234 sish.server

Issue #1 is that this command is not working because we get "No forwarding requests sent. Closing connection." after ~5 seconds.
The workaround is to publish some random useless service in addition, like this :
ssh -L <IP_ADDRESS>:80:myalias:1234 -R foo:2345:localhost:2345 sish.server
@ Machine C

A service client on machine C can now connects to the machine B on port 80 and access the HTTP service from machine A directly, without having any access to sish.
curl -v machineB/

Issue #2 is that right after the curl finishes, the second SSH client is terminating for some reason, we have to start it again before another HTTP request can be made.
Log of the sish server for the 3 calls :
`
2021/11/08 - 13:12:06 | Accepted SSH connection for: <IP_ADDRESS>:2780
2021/11/08 - 13:12:06 | Login attempt: <IP_ADDRESS>:2780, user ov key: ssh-rsa ***
2021/11/08 - 13:12:06 | TCP Alias forwarding started: myalias:1234 -> /tmp/<IP_ADDRESS>:2780:1234657440039 for client: <IP_ADDRESS>:2780
2021/11/08 - 13:12:15 | Accepted SSH connection for: <IP_ADDRESS>:1025
2021/11/08 - 13:12:16 | Login attempt: <IP_ADDRESS>:1025, user ov key: ssh-rsa ***
2021/11/08 - 13:12:16 | TCP Alias forwarding started: foo:2345 -> /tmp/<IP_ADDRESS>:1025:2345461572186 for client: <IP_ADDRESS>:1025
2021/11/08 - 13:12:21 | Accepted connection from <IP_ADDRESS>:1025 -> myalias:1234
2021/11/08 - 13:12:21 | Closed SSH connection for: <IP_ADDRESS>:1025 user: ov
`
I know it's an odd use case but I feel like not much is missing to make it work ;-)
Also, the standard SSH client always had the capability of creating TCP tunnels that work in either directions, so I feel sish should support that as well.
Let me know if you need me to perform other tests.

I have this working over in #198! There's a distinction between two commands now because SSH does not send anything to the server when setting up a local forward until a forward request comes through. To make this work, set --cleanup-unbound to false (the new default). There's also a new flag --cleanup-unauthed so that we remove unauthenticated connections. Just note that on public instances, not having --cleanup-unbound can retain a lot of bot connections!

Great news ;-) I can't wait to test it!
I assume the "cleanup-unbound to false" fixes both issues mentioned above ?
The goal is obviously to be able to handle more than one connection to the local forward.

Correct! There was also a piece of code that was closing the session when data finished copying which shouldn't be the case.


Docs: incomplete description of callbacks.ModelCheckpoint's save_best_only parameter

URL(s) with the issue:
https://www.tensorflow.org/api_docs/python/tf/keras/callbacks/ModelCheckpoint
Description of issue (what needs changing):

mode: "{auto, min, max}" should be {auto, min, max}, I guess (minor)
save_best_only: I believe the description is incomplete. With save_best_only=True, not only will "the latest best model [...] not be overwritten": but also the current model is not written at all, even if it has another filename than the "latest best model". This is kind of implied by the name of the parameter, but the description should include that, too.

Hi Can I create a PR to fix this?

PR to fix this issue is here https://github.com/tensorflow/tensorflow/pull/41567
Please review, thank

This is already fixed by https://github.com/tensorflow/tensorflow/pull/41567. Please check the updated tf-nightly page https://www.tensorflow.org/api_docs/python/tf/keras/callbacks/ModelCheckpoint?version=nightly.
I am closing this issue as this was already resolved. Thanks!


express res.cookie takes a maxAge param that should be a number, not a string

I'm sorry that this is just a regular issue instead of a pull request, but I wanted to make sure that I recorded it somewhere before I forgot:
According to the express documentation, res.cookie takes a maxAge param, which should be a number (in milliseconds). The flow annotations for express complain when you pass a number; flow thinks the argument should be a string.

Fixed in #492


Key Item de-dupe bypass does not (completely) depend on mCount 0

The conventional understanding of when acquired key items fail to de-dupe, which the simulator uses, is that they dupe whenever mCount is 0. For example, if you transfer a Sheikah Slate into a new game and pick one up from the terminal, you will get a second slate item. However, the way the game does this is more complicated.
When loading a save (or starting a new game), mListHeads is filled with nulls[^1]. The game is always attempting to de-dupe items regardless of mCount, but because the tab data isn't fully populated yet, it doesn't find any existing key items to check against. This state is broken as soon as an item is loaded from GameData (that item itself will always dupe), or the inventory is synced while mCount is at any non-zero value (tab data is correctly set up, and future potential dupes will be caught).
Here are some simulator scripts that give incorrect results compared to the game, due to this behavioural difference:
Slate de-dupe: We transfer in a slate to a new game via void out storage, so that we can sync in a +ve mCount. Even after dropping back to mCount 0, a collected slate will still de-dupe with the transferred one.
Glider activation in -ve mCount: The glider in this save file dupes and activates on reload, even though there is one in an offset slot with -ve mCount, because it's the first item to load in.
Controllable duping of Revali's Gale: A variation on the above two, demonstrating two things:

Champion powers don't work differently here; syncing at non-zero mCount fully enables de-duping.
The opposite happens if you omit the item D&P. Staying in mCount 0 will stop de-dupe from fully working, despite the implicit sync in fast travelling back to Rito Village. Syncing at mCount 0 seems to leave tab data in that same empty state, prolonging the effect.

[^1]: https://github.com/zeldaret/botw/blob/9a6a5fffa4ffcf159198e3b10fe318aea6b3ef5b/src/Game/UI/uiPauseMenuDataMgr.cpp#L335 Credit to kinak for confirming this behaviour in the engine decomp code.

Do you mean a key item as the first item to load skips the dupe check because the game can't find any tabs yet? (Regardless of mCount)

Correct. That's what causes the de-dupe skip, not mCount 0 per se (getting back to mCount 0 after a non-0 sync doesn't restore the skip, because the game still has the tab data it needs to find all populated slots).

Ok. I am not actively working on the sim at the moment. The sim currently always dynamically compute list heads, which needs to be changed. Will you be willing to fix this with a PR?

Sure, I've never done TypeScript but I'll take a look


Idea: Add a "feedback" sub-command to allow easy feedback

This is probably overkill. BUT, we could add an informational message to the end of a run that asks for feedback & suggestions.


YJDH-340 | KS-Backend: Add YouthApplication.encrypted_vtj_json

Description :sparkles:
Add YouthApplication.encrypted_vtj_json as EncryptedCharField field
using validate_optional_json validator.
Add validators:

validate_json
validate_optional_json

Otherwise like validate_json but also accepts None and ""

Add tests:

backend/kesaseteli/applications/tests/test_application_validation.py:

test_validate_youth_application_vtj_json

backend/shared/shared/common/tests/test_validators.py:

test_validate_json_with_valid_input
test_validate_json_with_invalid_input
test_validate_optional_json_with_valid_input
test_validate_optional_json_with_invalid_input

Refs YJDH-340
Issues :bug:
YJDH-340
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #569 (75e9432) into develop (c01f97b) will decrease coverage by 9.95%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #569      +/-   ##
===========================================
- Coverage    95.67%   85.72%   -9.96%
===========================================
  Files          230       47     -183
  Lines         9039     1499    -7540
===========================================
- Hits          8648     1285    -7363
+ Misses         391      214     -177

Impacted Files
Coverage Δ

...kend/shared/shared/common/tests/test_validators.py
100.00% <100.00%> (ø)

backend/shared/shared/common/validators.py
100.00% <100.00%> (ø)

backend/shared/shared/ytj/ytj_client.py
27.58% <0.00%> (-65.52%)
:arrow_down:

...nd/shared/shared/service_bus/service_bus_client.py
33.33% <0.00%> (-57.58%)
:arrow_down:

backend/shared/shared/yrtti/yrtti_client.py
37.50% <0.00%> (-53.13%)
:arrow_down:

backend/shared/shared/audit_log/viewsets.py
46.96% <0.00%> (-43.94%)
:arrow_down:

backend/shared/shared/audit_log/audit_logging.py
76.59% <0.00%> (-21.28%)
:arrow_down:

backend/shared/shared/common/tests/conftest.py
87.87% <0.00%> (-12.13%)
:arrow_down:

backend/kesaseteli/applications/models.py

.../applications/tests/test_application_validation.py

... and 181 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c01f97b...75e9432. Read the comment docs.

The browser test for filling the youth application failing has been reported in ticket YJDH-374.

Looks good to me! The length limit in the encrypted_vtj_json seems quite large, if you feel it could be shorter then I suggest changing it, but merge at will

I lowered the max_length of the encrypted_vtj_json from 256MiB to 1MiB.
BTW YouthApplication model is historized using HistoricalModel which uses HistoricalRecords from django-simple-history and looking at its documentation it says—here Choice and Poll are models whose changes are historized:

Every time a create, update, or delete occurs on Choice or Poll a new row is created in the historical table for that model including all of the fields in the instance of the base model

So, having the encrypted_vtj_json duplicated every time when any of the fields in YouthApplication change will make the database blow up quite easily if the field is large. I won't address this in this PR but I will make a ticket about this.

So, having the encrypted_vtj_json duplicated every time when any of the fields in YouthApplication change will make the database blow up quite easily if the field is large. I won't address this in this PR but I will make a ticket about this.

I didn't make a ticket for this but removed HistoricalModel from YouthApplication and force pushed the changes.


Fix support for Cider (figwheel dependency versions need to match) + Emacs instructions

Thanks a lot!


Fix wrong dependency name

Upon following the installation guide, this output is given:

Changing from:
dependencies:
  color:
    github: crystal-term/color

to:
dependencies:
  term-color:
    github: crystal-term/color

Fixes the issue and is the aim for this pull request.

Thanks for this!

Happy to help!


Support for new math.div Sass module

I have some SCSS that uses "/" to perform a division operation, but this produces a deprecation warning:
DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

If I change this to use "math.div" I get the following error:
error: [plugin: sass-plugin] There is no module with the namespace "math"

Suggestions?

I'm using "sass": "^1.37.5" and math.div works for me. Maybe try updating sass?

@Canuckaholic please update to v1.4.10


feat: ✨ add cwd option

I want to use esbuild-runner in contexts where the current directory is not the directory containing the package.json whose dependencies should be used to chose externals. This makes the location for package.json configurable. It's roughly equivalent to the cwd option from ts-node: https://github.com/TypeStrong/ts-node/blob/abc616ece2a8cdb066439a4e5c6fc7d493aa4612/src/index.ts#L191-L196.

Why not just make use of process.chdir?

It would change the execution environment of the code that the runner is running, which may be expecting the current directory to be the one where the command was executed.

Yes, but is that not the intention of a --cwd flag? For example, running ts-node --cwd /some/where your-script.ts will try to execute /some/where/your-script.ts. I'm just saying, cwd as flag is confusing if the actual goal is to just tell esbuild-runner to read from another package.json.


Add table rowkey

This PR adds a new property to the Table element, namely rowKey.
As its name implied, it allows to customize React key for each row.
The obvious reason is to leverage existing identifiers in the users data, instead of relying on indexes. More practically, this also solves the bug described below (which might be of interest on its own).

The bug this solves.
I have have dynamic data in my table, with rows frequently inserted and deleted. Using event delegation on the whole table element, I determine which cell was clicked. Cells have a custom rendered which sets data-something="whatever", that's how I extract my data the event's target element.
After removing a few rows, I discover the target elements had data-something pointing to the wrong data: that of the cell that was previously at the same location. Suspecting some optimization-related-code reusing the same DOM element because it has the same key and type, I tried this quick fix that got it worked.
I'm beginner-level with React, so unsure if that might point out to a deeper issuer.
Anyways, as I read about it, it seems like the bug I have is identical to what is described here: using indexes as keys is an anti-pattern.

Let me explain, a key is the only thing React uses to identify DOM elements. What happens if you push an item to the list or remove something in the middle? If the key is same as before React assumes that the DOM element represents the same component as before. But that is no longer true.

So, using smarter row keys seems to be the answer to such bugs.

Any chance to have this bug fix enter master?

Anyone?

I don't think specifying a custom rowKey is necessary. You can use event.target for your use case. For such use cases, it usually doesn't require an API change but rather how you're using the component

@wuweiweiwu Ok, regardless of the bug. React specifies in the doc that using indexes as key is a bad idea.
From https://reactjs.org/docs/lists-and-keys.html#keys

We don’t recommend using indexes for keys if the order of items may change. This can negatively impact performance and may cause issues with component state.

I (and maybe others) fell into a bug due to that, react is allowed to consider the inner content as identical when the key doesn't change.


Tentatively fixes #739 NullReferenceException

Tentatively fixes #739 NullReferenceException in ReverseExpressionParser.GetExpressionRange
Ensures that Classifier is always non-null.
I can't see anything else in the function that could potentially be null, so guessing this is it.

:+1:

:+1:


Include the --serve-assets flag in README

This tripped me up the first few times I tried to work with FastBoot. I propose it be included in the README, be set as a default, or we leave a note as to why neither of the first two options were taken.

Seems good to me!


LogToTable in different database intead of Master

First let me tell you that your maintenance solution is awesome and i really like.
A very important feature to me is the ability to log all process in a table where i can analyses later the performance and look for improvements.
But i think use Master database (system db) as repository is not so good, i prefer to create a new user database and save all logs, store procedures and etc over there.
So is it possible to create a variable in the procedures to the "@LogToTable" in a database that i point ?
Thanks again.

check the details here - https://ola.hallengren.com/frequently-asked-questions.html

You can create the log table and the stored procedures in any database (but the log table and the stored procedures have to be in the same database).


add homebrew install directory for proving key

As you add another entry, consider making a monad out of the:
`Yes / `No / `Unknown

I think I've seen @enolan 	do this before, if you want tips on how to do it

But this one let's just land!


Doc Typo fixes

Fixes #1195

Since you're already fixing docs - can you also fix
https://github.com/jscs-dev/node-jscs/commit/4f6115185485706022ba5c71efbca31ce7b21801#diff-9d58844b5d2a3f2d6b78e14720a9d46aR13?
remove the extra space from the wordpress entry preset in OVERVIEW.md

Done

Thank you!

Coverage remained the same at 99.09% when pulling 6170b6131abb940aafbafff843573ff1adde3f22 on TheSavior:fix/doc-typos into 64afa279305d16df14c81da240a391fb08b5b9a0 on jscs-dev:master.

Coverage remained the same at 99.09% when pulling d5e515a66028f761da5c664a4b34ed83c6e32908 on TheSavior:fix/doc-typos into 64afa279305d16df14c81da240a391fb08b5b9a0 on jscs-dev:master.

Coverage remained the same at 99.09% when pulling 0ac9f3cf1bf57a47292a2d8bfc7816430a7766dd on TheSavior:fix/doc-typos into 64afa279305d16df14c81da240a391fb08b5b9a0 on jscs-dev:master.


Retain instance name css class for custom modules

When adding a custom module with a name, e.g.:
{
  ...,
  "custom/foo#bar": { },
  ...
}

The custom module does not retain the bar class as it should, because all the classes are replaced with the runtime output:
https://github.com/Alexays/Waybar/blob/1b4a7b02f46c1bce2eafdde2a76f4a3adec6620e/src/modules/custom.cpp#L141-L147
Avoid removing the module instance name class so css class behavior is consistent between all modules.

LGTM, can you just lint your code :)
Thanks!

I've fixed the lines in my commit. The CI's linting step is still failing on files that are not part of this PR (src/modules/network.cpp). Should I fix and commit them anyways?

Thanks, i'll lint src/modules/network.cpp


Database setup SQL script

Hi there,
Just wondering if there are any setup SQL scripts that could be used in a environment where I don't have permissions to create databases or tables.
I noticed membership reboot had a migration sql script, but could not find a similar one here.
Thanks

You're expected to use migrations. You can do this from your dev environment and have that generate a SQL script, which you can then hand over to your DBA. Check the EF documentation.


yandex-cloud: init at 0.109.0

Description of changes
Packages yc, a command-line tool for managing Yandex.Cloud resources.
Things done

Built on platform(s)

[x] x86_64-linux (pkgsCross.gnu64)
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@SuperSandro2000 gentle ping, can you take a look at this?

I’ve renamed the package to yandex-cloud (was yandexcloud-cli) to match https://repology.org/project/yandex-cloud

@SuperSandro2000, is there anything else that should be addressed or it’s good for merge?

Updated, rebased, formatted package with nixfmt-rfc-style.


[framework] dont load file bytes all at once in FileImage

This is a workaround for https://github.com/flutter/flutter/issues/112881, which prevents dart from opening files greater than INT_MAX bytes on windows.

Even when we fix the linked issue, we won't be able to open files greater than INT_MAX on windows-  it will just fail with an exception instead of crashing. This change is required to be able to load images this big at all

Maybe lets just see if we can land https://github.com/flutter/engine/pull/36623 first. Then use that new API instead, which doesn't have the problem dart:io does

The next magic trick should be ImmutableBuffer.fromNetwork that somehow returns chunk events.


add provider option into the cli tests when creating kafka instance

in order to be able to cli tests targeting (i.e. using) gcp/aws provider for kafka instances.

/lgtm

gcp, all ✅ merging.


NotFoundError (see above for traceback): Unsuccessful TensorSliceReader constructor

I ran "python build_data.py" on my dataset and it was Ok but when i run "python main.py" to train  my model i get an error.
Here is the traceback:
C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\ops\gradients_impl.py:93: UserWarning: Converting sparse IndexedSlices to a dense Tensor of unknown shape. This may consume a large amount of memory.
"Converting sparse IndexedSlices to a dense Tensor of unknown shape. "
2017-07-25 13:01:13.770555: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\platform\cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE instructions, but these are available on your machine and could speed up CPU computations.
2017-07-25 13:01:13.780837: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\platform\cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE2 instructions, but these are available on your machine and could speed up CPU computations.
2017-07-25 13:01:13.792198: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\platform\cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE3 instructions, but these are available on your machine and could speed up CPU computations.
Reloading the latest trained model...
INFO:tensorflow:Restoring parameters from /results/crf/model.weights/
Restoring parameters from /results/crf/model.weights/
2017-07-25 13:01:16.256308: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.256371: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.256429: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.256485: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.256525: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.256590: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.340877: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.284399: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.298523: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.312538: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.326592: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.270016: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.355930: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.370020: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.383945: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.397983: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.411831: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.425676: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.439582: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.453446: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.467343: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.481262: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.495121: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.509338: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.523517: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.537511: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.552983: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.566865: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.580697: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.594563: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.608358: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.622190: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.637740: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.651574: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.665625: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.679549: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.693420: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.707397: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
2017-07-25 13:01:16.722452: W c:\tf_jenkins\home\workspace\release-win\m\windows\py\35\tensorflow\core\framework\op_kernel.cc:1158] Invalid argument: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
Traceback (most recent call last):
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\client\session.py", line 1139, in _do_call
return fn(*args)
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\client\session.py", line 1121, in _run_fn
status, run_metadata)
File "C:\Users\New\Anaconda2\envs\python35\lib\contextlib.py", line 66, in exit
next(self.gen)
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\framework\errors_impl.py", line 466, in raise_exception_on_not_ok_status
pywrap_tensorflow.TF_GetCode(status))
tensorflow.python.framework.errors_impl.InvalidArgumentError: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
     [[Node: save/RestoreV2_38 = RestoreV2[dtypes=[DT_FLOAT], _device="/job:localhost/replica:0/task:0/cpu:0"](_arg_save/Const_0_0, save/RestoreV2_38/tensor_names, save/RestoreV2_38/shape_and_slices)]]

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "main.py", line 38, in
model.train(train, dev, vocab_tags)
File "D:\Mashhadirajab\DeepNN-NER\sequence_tagging-master\sequence_tagging-master\model.py", line 340, in train
saver.restore(sess, self.config.model_output)
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\training\saver.py", line 1548, in restore
{self.saver_def.filename_tensor_name: save_path})
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\client\session.py", line 789, in run
run_metadata_ptr)
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\client\session.py", line 997, in _run
feed_dict_string, options, run_metadata)
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\client\session.py", line 1132, in _do_run
target_list, options, run_metadata)
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\client\session.py", line 1152, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
     [[Node: save/RestoreV2_38 = RestoreV2[dtypes=[DT_FLOAT], _device="/job:localhost/replica:0/task:0/cpu:0"](_arg_save/Const_0_0, save/RestoreV2_38/tensor_names, save/RestoreV2_38/shape_and_slices)]]

Caused by op 'save/RestoreV2_38', defined at:
File "main.py", line 38, in
model.train(train, dev, vocab_tags)
File "D:\Mashhadirajab\DeepNN-NER\sequence_tagging-master\sequence_tagging-master\model.py", line 333, in train
saver = tf.train.Saver()
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\training\saver.py", line 1139, in init
self.build()
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\training\saver.py", line 1170, in build
restore_sequentially=self._restore_sequentially)
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\training\saver.py", line 691, in build
restore_sequentially, reshape)
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\training\saver.py", line 407, in _AddRestoreOps
tensors = self.restore_op(filename_tensor, saveable, preferred_shard)
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\training\saver.py", line 247, in restore_op
[spec.tensor.dtype])[0])
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\ops\gen_io_ops.py", line 640, in restore_v2
dtypes=dtypes, name=name)
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\framework\op_def_library.py", line 767, in apply_op
op_def=op_def)
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\framework\ops.py", line 2506, in create_op
original_op=self._default_original_op, op_def=op_def)
File "C:\Users\New\Anaconda2\envs\python35\lib\site-packages\tensorflow\python\framework\ops.py", line 1269, in init
self._traceback = _extract_stack()
InvalidArgumentError (see above for traceback): Unsuccessful TensorSliceReader constructor: Failed to get matching files on /results/crf/model.weights/: Not found: FindFirstFile failed for: /results/crf/model.weights : The system cannot find the path specified.
     [[Node: save/RestoreV2_38 = RestoreV2[dtypes=[DT_FLOAT], _device="/job:localhost/replica:0/task:0/cpu:0"](_arg_save/Const_0_0, save/RestoreV2_38/tensor_names, save/RestoreV2_38/shape_and_slices)]]

Do i set config.reload= false if i am going to train a new model and there is no any trained model for restore?

yes! The default value to True from the latest pull request was misleading. I changed it!


Error in distributed training

I got an error frequently when distributed training is enabled. It occurs roughly for every 50~100 epochs. Here is the error message:
terminate called after throwing an instance of 'std::system_error'
  what():  Transport endpoint is not connected
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.6/multiprocessing/spawn.py", line 105, in spawn_main
    exitcode = _main(fd)
  File "/usr/lib/python3.6/multiprocessing/spawn.py", line 115, in _main
    self = reduction.pickle.load(from_parent)
_pickle.UnpicklingError: pickle data was truncated
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.6/multiprocessing/spawn.py", line 105, in spawn_main
    exitcode = _main(fd)
  File "/usr/lib/python3.6/multiprocessing/spawn.py", line 115, in _main
    self = reduction.pickle.load(from_parent)
EOFError: Ran out of input

Could you help me to resolve the issue?

It's unlikely this issue is related to this project. Transport endpoint is not connected means your network is probably unreliable.

Hi,
I encountered the same issue as well. Any thoughts for this issue? Thanks.

I couldn't solve the issue, so I ended up with saving checkpoints every epoch and resuming experiments multiple times.

来信收到，谢谢！

@kibok90 Thanks! That is literally what I do for my project. Thank you for providing your solution. :)


Updating Meta Tags

Description
Closes #176
Checklist

[x] I have not referenced individuals, products or companies in any commits, directly or indirectly
[x] I have not added data or restricted code in any commits, directly or indirectly
[x] I have updated the docstring of any public function/class/model changed
[ ] I have added tests to cover my changes (if applicable)

Types of changes

[ ] Docs/refactoring (non-breaking change which improves codebase)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

This first commit is just a demo of  how a logo and description can be included in the meta tags.

I'd like to do the docs in a separate PR, so this is ready to review.
I allowed for the option to set a path to an image because the id can have spaces which is not ideal for filenames.
Please let me know what sort of tests you would like.

This looks great to me, thank you very much for your first PR @AnnMarieW.
Probably we should remove the get_relative_path(f"/{STATIC_URL_PREFIX}/images/app.svg") for now sine the point you raised against it is very valid!
As for tests, here's where our current tests for Dashboard.pre_build are: https://github.com/mckinsey/vizro/blob/8d82ebf346db3494ee733b69c00fe7e69add8f44/vizro-core/tests/unit/vizro/models/test_dashboard.py#L149. I have some ideas for tests that I would write but am very curious to hear what tests you think would be useful? Our current testing setup is quite new and could definitely be rigorous in places, which is something I'd like to us to improve in the new year.
I was looking through the Dash tests that you linked me to. Am I right in thinking that all the tests on Dash pages are contained here? And there's no explicit tests for _infer_pages itself? Instead it's this test and the following one that test the behaviour of (a) no image is supplied and app.jpeg is used and (b) birds.jpeg is used.

Yes most of the Pages tests are in the links you provided.  The Dash tests confirm the meta tags are created as expected based on the dash.page_registry.  For the Vizo tests, it's probably enough to test that the dash.page_registry is correct.  I'll take a look at adding some tests in the Dashboard.pre_build  section you pointed to.

@AnnMarieW Here's the sort of thing I'd suggest for tests (haven't tried it out at all yet, no doubt has typos and errors, but hopefully you get the idea). Take a look at #228 first for context 🙂
    def test_page_registry_with_description(self, vizro_app, mocker):
        mock_register_page = mocker.patch("dash.register_page", autospec=True)
        vm.Dashboard(
            pages=[vm.Page(title="Page 1", components=[vm.Button()], description="My description")]
        ).pre_build()

        mock_register_page.assert_any_call(
            module=page_1.id,
            name="Page 1",
            title="My dashboard: Page 1",
            path="/",
            order=0,
            description="My decription",
            layout=mocker.ANY,  # partial call is tricky to mock out so we ignore it.
        )

    @pytest.mark.parametrize(
        "image_filename", ["app.png", "app.svg", "folder/app.png", "folder/app.svg", "logo.png", "logo.svg"]
    )
    def test_page_registry_with_image(self, vizro_app, page_1, mocker, tmp_path, image_filename):
        (tmp_path / image_filename).touch()
        mock_register_page = mocker.patch("dash.register_page", autospec=True)
        vm.Dashboard(pages=[page_1], title="My dashboard").pre_build()

        mock_register_page.assert_any_call(
            module=page_1.id,
            name="Page 1",
            title="My dashboard: Page 1",
            path="/",
            order=0,
            image=str(tmp_path / image_filename),
            layout=mocker.ANY,  # partial call is tricky to mock out so we ignore it.
        )

@antonymilne - I got all your suggested tests added :confetti_ball:

Hi @antonymilne
I see the following  error message in the failing test.  I'm running Python 3.10 and when I run the test locally everything passes. Do I need to install and run Python 3.11 locally too?

@AnnMarieW hopefully you don't need to install Python 3.11 to get this to pass. For now ignore the error message and just running hatch run schema locally and then pushing to see if it fixes the check.


[v2] Toast with icon

@nolimits4web
Could you please add toast with icon?
Here an example:
https://github.com/valnub/Toast-for-Framework7

@nolimits4web
Thx :)