peripheral.h missing

I had to comment out the include. Where can I get this file? It seems to be for board-specific functionality.

My apologies - peripheral.h is unpublished work in progress that's not fit for release just yet, and the line that includes it should have stayed commented out for now. I have updated the referring file, and thanks for the heads-up.
FYI, the only new functionality that's enabled by that file is battery levels on the TBeam (the only supported board with a power management unit) - fairly inessential at this stage.

I have pushed the peripheral support code, which should properly close this issue :)


No Exception Handler

Thank you for this great plugin, I really want to know if their is away i can capture response from message channels and use them inside notification class. USE CASE i have an sms channel that uses external api to send message, I want to capture and use api responses inside notification class.

That's not the intended use of the notification class, you should do that on the channel level, either by hard-coding it or emitting a event.

thank you so much am now getting the following when i create a try to use custom channel "sms" driver is not supported by "Notification"

Can you provide a reproduction repo with your channel?


AlternateEmailAddresses does not translate to StrongAuthenticationUserDetails | select Email

I'm not really sure the above guide is true. Changing AlternateEmailAddresses does not change "StrongAuthenticationUserDetails".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aae83fda-27b9-edca-1b59-1140de4cc3f5
Version Independent ID: c93eb84b-f04b-de03-f3f5-57d4672b0559
Content
Content Source
Service: active-directory

Thanks for your feedback. We will investigate and update on it soon.

Thanks for reporting! I have assigned the issue to the author to investigate and update as appropriate.

@FrederikLeed it does not immediately appear. It will move when the user confirms the information. Setting it for a new user will allow them to confirm the data and then it is copied to that field.

#in-process

When or where is the user supposed to get prompted to confirm this? It does not even happen when the user goes to the MFA details page from myapps.microsoft.com.

On first time registration for SSPR this will show up for the user.

Yes, but what about changes to existing? Also, one could consider it a security risk, that users (or someone with a non-mfa regitrered users username+pwd) is able to enter 2. factor details.

Work is being done to allow organizations to lock down registration to trusted areas. Changes to existing registration info are in the works. A Graph API for setting and changing security info is coming soon but no dates to share.

Thank you very much for shedding some more light on the roadmap of this subject it really help in planning.

No problem @FrederikLeed

#please-close


fix single keybind trigger with modifiers

This fixes an unexpected behavior when you have something like this:
  if event.is_keybind_pressed('w') {
      // Do something
  }

  if event.is_keybind_pressed(Keybind::from('w').ctrl()) {
      // Do something else
  }

...and both being triggered when ctrl-w is pressed.

Thanks


KNE support for nested "kind" environments.

Evaluating the capability to support kind https://kind.sigs.k8s.io/ (or potentially other k8s implementations) in a KNE topology build.
Use case associated : to be able to test, validate build topologies which includes CNI specific capabilities. In that case, the nested kind cluster must be able to implement off the shelf CNIs connected to emulated network topology (see attached diagram).

Not sure I follow exactly what you want here (although the diagram is definitely helpful). Would utilizing the node HOST implementation work for this?
The HOST node could either use a base linux container which could be set up to talk with the existing kind worker nodes or potentially the HOST node could bring up kind node container image directly?
@marcushines

@alexmasi thanks for the pointer towards HOST ... in essence, I want to emulate an application cluster with CNI connected to an emulated network.


nothing

Motivation:
Explain here the context, and why you're making that change.
What is the problem you're trying to solve.
Modifications:
Describe the modifications you've done.
Result:
After your change, what will change.
[One line description of your change]
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]

@swift-nio-bot test perf please

@swift-nio-bot test perf please

@swift-nio-bot test perf please

@swift-nio-bot test perf please


Bump to cf-deployment 13.17 based on CVEs

https://www.cloudfoundry.org/blog/cve-2020-5416/ and https://www.cloudfoundry.org/blog/cve-2020-5417/ appeared over the weekend and they detail 2 high priority vulnerabilities tied to routes being exposed to other developers and an NGINX DoS exploit.
We need to bump to https://github.com/cloudfoundry/cf-deployment/releases/tag/v13.13.0 which will include updated router (0.204.0) and CAPI (0.197.0 from cf 13.12) releases.

Two new CVEs arose that may require a bump to 13.17:

https://www.cloudfoundry.org/blog/cve-2020-5420/ -- High: Gorouter is vulnerable to DoS attack via invalid HTTP responses, also needs routing 0.206.0+
https://www.cloudfoundry.org/blog/cve-2020-5418/ -- Low: Cloud Controller allows users with no roles to list droplets, also needs CAPI 1.98.0+

Two new CVEs arose that may require a bump to 13.17:

https://www.cloudfoundry.org/blog/cve-2020-5420/ -- High: Gorouter is vulnerable to DoS attack via invalid HTTP responses, also needs routing 0.206.0+
https://www.cloudfoundry.org/blog/cve-2020-5418/ -- Low: Cloud Controller allows users with no roles to list droplets, also needs CAPI 1.98.0+

Confirming that cf-deployment 13.17 includes routing-release 0.206 and capi-release 1.98.


Job Missing files after 3 seconds: phill.f

I try to run simulations with the phill and the new cbox solvers:
# from snek5000_cbox.solver import Simul
from phill.solver import Simul
params = Simul.create_default_params()
sim = Simul(params)
sim.make.list()
sim.make.exec()

For the 2 solvers, I can't run the simulation and I get the following error (here for phill):
[...]
WARNING: Waiting at most 3 seconds for missing files.

#############################################################
#                  Compilation successful!                  #
#############################################################
   text	   data	    bss	    dec	    hex	filename
1925422	 178812<PHONE_NUMBER><PHONE_NUMBER>	42f8104a	nek5000

MissingOutputException in line 33 of /home/pierre/Dev/snek5000/src/snek5000/assets/compiler.smk:
Job Missing files after 3 seconds:
phill.f
This might be due to filesystem latency. If that is the case, consider to increase the wait time with --latency-wait.
Job id: 5 completed successfully, but some output files are missing. 5
ERROR: MissingOutputException in line 33 of /home/pierre/Dev/snek5000/src/snek5000/assets/compiler.smk:
Job Missing files after 3 seconds:
phill.f
This might be due to filesystem latency. If that is the case, consider to increase the wait time with --latency-wait.
Job id: 5 completed successfully, but some output files are missing. 5
Removing output files of failed job compile since they might be corrupted:
nek5000
WARNING: Removing output files of failed job compile since they might be corrupted:
nek5000
Shutting down, this might take some time.
WARNING: Shutting down, this might take some time.
Exiting because a job execution failed. Look above for error message
ERROR: Exiting because a job execution failed. Look above for error message
Complete log: /home/pierre/Dev/Nek5000/.snakemake/log/2021-07-16T154450.705078.snakemake.log
WARNING: Complete log: /home/pierre/Dev/Nek5000/.snakemake/log/2021-07-16T154450.705078.snakemake.log

If the "Compilation successful" is seen then the .f should have been created. I wonder if it is an issue attributed to your environment...

Which shell are you using?
Can you run sim.make.exec(keep_incomplete=True) and then list the contents of the generated simulation directory?

I reproduce with bash and Python 3.8
With sim.make.exec(keep_incomplete=True) (and with the phill solver, to be sure, I get):
me@mycomputer:~/Sim_data/phill_run_22x16x19_V1.x1.x1._2021-07-20_09-56-38$ ls
build.log        makefile_usr.inc  phill.box  phill.re2     Snakefile
etc              nek5000           phill.log  phill.usr     templates
info_solver.xml  obj               phill.ma2  SESSION.NAME  toolbox

I also get the same error with the code given in snek5000 README.
When and by what phill.f should be produced ?


Revert "Add xunit 2.4.2 and xunit-abstractions 2.0.3 (#167)"

This reverts commit 949f900bb9393262183fb94b0c26f2b8248d07d9.
Unblock offline source build. The interdependency between xunit.abstractions and xunit causes problems there.

Also should revert the changes in https://github.com/dotnet/source-build-externals/pull/173. A signing key was added there.

I reverted this commit as well.


feat: onError props for Form component

Issue: #715
❓ Type of change

[x] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Remove exception in customer side if validation fails.
If it fails the user can execute @error type: (value: FormSubmitEvent<T>) => void
~Also I added focusOnFail props. To set the focus to the first element that contains an error.  But only works if  name is the same that state key~

Resolves #715
📝 Checklist

[x] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

This code is ready to be review.

@albertcito I made some changes to include the input identifier directly inside the error object, wdyt?

Looks great, simpler code.

The issue came from a silent hydration mismatch on the input identifier (c.f. https://github.com/nuxt/nuxt/issues/14143#issuecomment-1397344346). I found a quick fix here https://github.com/nuxt/ui/pull/718/commits/97ca4c58d718de5edbf937575e7ddc62cf405eda which should do it for now.
A more elegant solution would be to find a way to make the uid function SSR friendly, but I could not figure it out yet.

Used to be able to do @submit.prevent. Now it complains e.preventDefault is not a function.
Is this related? Looks like it's a breaking change of this release.

@yuelikestocode The Form component already handles the prevent for you: https://github.com/nuxt/ui/blob/dev/src/runtime/components/forms/Form.vue#L2


CHAD-12648 SmartSense MultiPurpose sensor missing negative temperature handling

Original PR: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1227
This PR incorporates the changes made in the original PR and also adds unit tests for these changes

Closed for swapped branches


Add CLI option to output messages as raw JSON

This way output can be easily processed using other CLI tools like jq.
Related: #14

Merged: https://github.com/yaniswang/HTMLHint/commit/7c5f2f65d5eb95973995a83b0da4b949f5e7e5c8


change apt::key server to valid server

I think we're dropping gluster support, so I'll close after updating README


square/go-jose deprecated

Calling out https://github.com/square/go-jose being deprecated and the official recommendation is to migrate to https://github.com/go-jose/go-jose.

Hi @yagehu, thanks for raising this!
We're aware of the deprecation as we use the square/go-jose module in other projects as well.
We're currently evaluating alternatives and will update soon.

Great. I want to get a sense of alternatives you are considering. We're using go-jose v3 everywhere else in our Go code.

@yagehu We ended up switching to go-jose/go-jose v3 as well in #108. It provides everything we need for our needs and it's a drop-in replacement so migration was easy.
We considered the following alternatives.

https://github.com/golang-jwt/jwt
https://github.com/kataras/jwt
https://github.com/go-chi/jwtauth
https://github.com/lestrrat-go/jwx

Of all the alternatives, lestrrat-go/jwx was the strongest contender. Eventually, since go-jose v3 does not have any breaking changes, we decided to stick with that.


Fix: MELTCD Logo Url in Readme

Fixed the URL of MELTCD logo in readme. The updated url is from digitomize repo.
fixes #447

Summary by CodeRabbit

Documentation

Updated the README with a short summary of recent changes.

New Features

Adjusted image dimensions for a more uniform and visually appealing layout.

Bug Fixes

Updated image URLs to ensure all images are correctly displayed and sourced.

@c4coderandcreator May I know how exactly you got this link? I am not sure where to store the image.

nothing is required @Chakit22  !! Image is already in the assests folder, the url is generated from the digitomize website itself !!


Update version to 2.6.3-SNAPSHOT for branch-2.6

What changes are proposed in this pull request?
Change version to 2.6.3-SNAPSHOT
Why are the changes needed?
Since 2.6.2 has been released, need to update version to 2.6.3-SNAPSHOT for branch-2.6
Does this PR introduce any user facing changes?
No changes

@yuzhu Could you please take a look? Thanks

@LuQQiu could you review this since you did the last edge release?

@LuQQiu Hi, I want to find the latest stable version and find that v2.6.2 is the new. And I want to maintain inner branch, there are 2 choices: 1) checkout the released tag v2.6.2; 2) the branch 2.6. Here I have a question about the release, I find that maybe v2.6.2 does not cut from branch-2.6, is it? What is the release process of Alluxio?

@ferhui targetting for faster release circle, we are doing release much more frequent and directly cutting releases from master branch. Yeah all 2.6.1, 2.6.2, 2.6.3 are cutting from Master branch directly and we are not back porting changes from master branch to this branch-2.6 branch.
Then actually 2.6.1-SNAPSHOT is the correct version for this branch.

In the future, we may not cut branch-2.7

LGTM, thanks for updating the branch version

@ferhui targetting for faster release circle, we are doing release much more frequent and directly cutting releases from master branch. Yeah all 2.6.1, 2.6.2, 2.6.3 are cutting from Master branch directly and we are not back porting changes from master branch to this branch-2.6 branch.

Got it, thank you very much. So we should choose v2.6.2 directly.


v 3+ (BUG/FEATURE UPDATE) Replace the name-based location look-up with lat/long for the 'Calculate Benefits' / iTree API call

ToDO: iTreeAPI has updated their spec to deprecate the name based location search.
The updated API documents are here (and the specific section on the location parameters is pg 13): iTreeAPI Documentation
We need to update our API call accordingly to use lat/long instead of the name based location search that @JonathanKoerber put in a few years ago (see: git #148 & #74 ).
Long story short: We should use the lat / long in the api call (to iTreeAPI) BUT still save the location name to our Firebase storage (as it does now) AND in the Calculated Tree Benefits dialog show the users the name of the place.
Only thing changing here is the api call parameters. Keep everything else.

verified on 4.1.5


Saving an autoprognosis model

Dear bcebere, how do you save an autoprognosis model file ? It seems tha tpickel does not work for that.
Many thanks in advance
jb

Hello @jbwoillard
You can use the save_model/load_model methods from the autoprognosis.utils.serialization module.
You can find an example here.
Let me know if this isn't working for you.

Thanks that is perfect


Missing section on how to contribute and pytest error

Rasa Core version
0.7.3
Operating system
Ubuntu 16.04
Issue:
Currently, I can't find any section on how to contribute. The link in the README is pointing nowhere.
I actually had problems making the tests run, presumably I'm missing something. The error is:
$ py.test
Traceback (most recent call last):
  File "/home/bbossan_dev/anaconda3/lib/python3.5/site-packages/_pytest/config.py", line 283, in _getconftestmodules
    return self._path2confmods[path]
KeyError: local('/mnt/data01/work/ben/forks/rasa_core/tests')

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/bbossan_dev/anaconda3/lib/python3.5/site-packages/_pytest/config.py", line 314, in _importconftest
    return self._conftestpath2mod[conftestpath]
KeyError: local('/mnt/data01/work/ben/forks/rasa_core/tests/conftest.py')

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/bbossan_dev/anaconda3/lib/python3.5/site-packages/_pytest/config.py", line 320, in _importconftest
    mod = conftestpath.pyimport()
  File "/home/bbossan_dev/anaconda3/lib/python3.5/site-packages/py/_path/local.py", line 650, in pyimport
    __import__(modname)
  File "/mnt/data01/work/ben/forks/rasa_core/tests/conftest.py", line 11, in <module>
    from rasa_core.agent import Agent
  File "/mnt/data01/work/ben/forks/rasa_core/rasa_core/agent.py", line 12, in <module>
    from rasa_core.domain import TemplateDomain, Domain
  File "/mnt/data01/work/ben/forks/rasa_core/rasa_core/domain.py", line 16, in <module>
    from pykwalify.errors import SchemaError
ImportError: No module named 'pykwalify'
ERROR: could not load /mnt/data01/work/ben/forks/rasa_core/tests/conftest.py

However, pykwalify is installed:
$ pip list | grep pykwalify
pykwalify (1.6.0)

py.test in your above log is using python 3. depending on your setup, pip list usually shows packages installed for python 2.7. so might be that the package is not installed for python 3.

You can also use the makefile commands to run the tests. But I agree - there should be a section about contributions.

I use a conda environment, and pykwalify is part of that environment. Running make test results in the same error.

Did you run pip install -r dev-requirements.txt?

Yes:
conda create -n rasa_core2 python=2.7
source activate rasa_core2
pip install -r requirements.txt
pip install -r dev-requirements.txt
python setup.py develop
py.test

The same with Python 3.6.
Interestingly, pykwalify seems to be installed:
$ python -c 'from pykwalify.errors import SchemaError;print("works")'
works

My colleague reprocuded the problem on his machine.

ok let me try that sequence as well

Okay, I discovered the source of the problem: pytest itself is missing from the requirements. Therefore, invoking the tests resulted in invoking the global pytest.

I've added pytest to the dependencies, so this should be fixed.


#10-UI/UX Mockups

Description
Created Voxnostra Mockup which consists of

Project Landing Page
Signup / Login / Change Password
User Landing Page / Update Profile
View Organisations / Follow Projects
View Projects / Vote Projects / Follow Projects
View Project Progress / Raise a Report on Projects

Other Notes
The Footer and any pages lacking will be implemented in html. You can also view the Project Mockup here on Figma
Fixes #10

This is a design document. The Pull Request is not needed.


Allow extensions to activate once users click on its tile in the Getting Started walkthrough

Hey there! We are starting to implement our contribution to the Getting Started walkthrough and it'd be great if the Python extension could activate once users click on our "Get started with Python development" tile.

cc @brettcannon


Implement engine v2 functionality to upload to cipd.

Implement uploads to cipd funtionality in engine v2 configs and recipes. This is required to upload sky engine to cipd.

@zanderso do you know where are we using the sky_engine cipd package?

I couldn't figure out what it is for, no. I think the tool gets the sky_engine package as part of the engine artifacts, but @christopherfujino will be able to check for sure. I looked back at the recipe repo history to try to figure out why the sky_engine CIPD upload was added, but it turns out that it was added in the initial recipe check-in with no comments, so I guess it must have been in the old pre-LUCI scripts. I'm not sure how to find the history for those.

From looking at the tool codebase, I'm pretty sure the only CIPD artifacts we directly rely on are related to the Fuchsia runner. It's definitely possible we're not using this. Let me ask on LUCI users if there are logs we can access.

CL removing the upload to cipd: https://flutter-review.googlesource.com/c/recipes/+/43200


feat(): Add animation on skeleton text

Short description of what this resolves:

The animation gives you a feeling of progress and is something i miss in this component.

Changes proposed in this pull request:

Add animation on the skeleton text component.

Hello and thank you for contributing to Ionic! We have recently updated master to the core branch.  We will no longer be merging PRs into core. If you have the time, please resubmit this PR against the master branch. Thanks so much for your time!


JS Engine - Known Issues/Suggestions

WARNING: CHECK THIS ISSUE ENTIRELY AND BE SURE TO CHECK THE ACTIONS TAB FOR THE ACTION BUILDS TO CHECK IF YOUR ISSUE HASN'T ALREADY BEEN FIXED.
this is just a page for those that want to know what issues i'm aware of
Status Legend
✅ - Fixed (if not in newest update, check the action builds!)
❌ - Not fixed yet
🟡 - Working on a fix
🟠 - Low Priority
🔴 - Currently not a priority
⚫ - Unfixable/Unable to implement
❓ - Not an actual issue/Unsure of the cause, as this doesn't occur for me
Bugs
Big icons will crop off - ✅
Sometimes the preloader will crash the engine because of a broken path - ✅
If you exit an editor while music is fading in, the engine will crash - ✅
If you reload a JSON in the Chart Editor, the music will stack on top of each other - ✅
macOS users cannot open the Engine - ❌🔴 (I do not use macOS.)
Linux users will have frames saved in Rendering Mode save to the main directory instead - ✅
If GPU Caching is enabled, Get Icon Color is broken and always returns a black color - ✅
Events are broken in Rendering Mode - ✅
Hurt Notes crash the game if Enable Color Shader is turned off - ✅
If Color Quant notes are used, sometimes a sustain note will use a different sustain color than the previous notes - ✅
If you turn on Rendering Mode but turn on the rating popups, running popUpScore will make the vocals play, even if you don't want them to - ✅ (This is when you should become aware that.. the music isn't supposed to play when Rendering Mode is turned on.)
The Dave Engine and TGT V4 Score Styles crash the game, and their respective Time Bar Styles use the wrong font - ✅
Note types will show the wrong texture if a LUA script changes it - ✅
Note splashes are affected by note colors regardless of whether or not the color shader is actually enabled - ✅
If you change your noteskin to Default when using another noteskin, then the notes would use the same noteskin you used before - ✅
Camera shaders stack on top of each other - ✅
If you enter a song with Pixel notes, the notes will be invisible while in the Chart Editor - ✅
Hurt Notes don't do the correct animation while in the chart editor - ✅
If a song has an ending cutscene, the game will softlock - ✅
If you enable "Hide HUD" and enable "Score Text Zoom on Hit" and trigger a rating popup, the game will crash due to scoreTxt being null - ✅
The game crashes on a Hurt Note - ✅
Texts made in LUA go to camGame - ✅
Some people will crash when opening songs - ✅
Crashes don't generate a crash log - ✅
While in Chart Playtesting, Sustain Notes will cause regular notes to be stretched and everything will just break - ✅
Saving a modded note splash with the Note Splash editor crashes the game - ✅
1.36.0
While custom ratings work in the main game, they don't work in EditorPlayState - 🟡
Suggestions
Extra key support (up to 18K) - ⚫ (Would break noteskins.)
Modchart Editor - ❌🔴
Making the engine work with the latest libraries - ✅
A rendering mode that actually uses FFmpeg - ✅
Bugs (pre-release)
BPM changes will cause sustain notes to look longer/shorter than they actually are - ✅
Sustain notes don't give health - ✅

@JordanSantiagoYT I saw a way to implement extra keys without breaking the note skins, I’ve seen a repo do it before
https://github.com/Starmapo/FNF-PsychEngine-Extra

@JordanSantiagoYT I saw a way to implement extra keys without breaking the note skins, I’ve seen a repo do it before https://github.com/Starmapo/FNF-PsychEngine-Extra

The base noteskin there is an EK noteskin (aka. one that uses more than 4 keys)

@JordanSantiagoYT I saw a way to implement extra keys without breaking the note skins, I’ve seen a repo do it before https://github.com/Starmapo/FNF-PsychEngine-Extra

The base noteskin there is an EK noteskin (aka. one that uses more than 4 keys)
What I mean by breaking noteskins is that adding EK would make all the current noteskins in this engine (aside from the default one) unusable, because they don't support key counts higher than 4

yeah but checks for ek more skins can be added though, since the xml names and such are different, and we can check if they’re different or not

like this, but there’s other methods too

Starting from 1.36.0 onward, all known bugs from this version and later will be sorted by the update that said bug was first found in.


Error colour

1.12.2 don't bugs
1.15.2 - 1.14.2 - ... colors are displayed incorrectly

Congratulations by the plugin.
It happens the same to me. Anyone know how to fix it.

Thanks to all.

Between those versions Minecraft changed the max length of the text you can see.
It should be fixed in the recode


Commit-boost signing integration

Context
There's one part of the commit-boost integration left that we need to fix: a way to delegate to their proxy keys so we can use them in the sidecar when requesting signatures. The signing domain is the same as what we're using.
The easiest way to start supporting it is to just have the bolt-cli generate delegations to the first of the proxy keys running inside of the commit-boost signing module, and then providing those the the sidecar at startup. Since these delegations sit in a file, we'll also have to add some sort of volume support to the CB configuration so they can be read from inside of the containers.

Related to #365, as they both implement the same Signer API as of Nov 28th 2024


Expose methods for colliding body count

Like get_overlapping_bodies().size() but slightly faster.
New methods:
Area.get_overlapping_area_count()
Area.get_overlapping_body_count()
Area2D.get_overlapping_area_count()
Area2D.get_overlapping_body_count()
RigidBody.get_colliding_body_count()
RigidBody2D.get_colliding_body_count()

I think running doctool on non-mono binary would remove some doc entries by accident. Class reference was synced in daa9092 without those errors. Please rebase.

Removed doc commits

Sorry for the late review.
I hadn't merged it yet as I was not convinced that it's worth adding such _count methods when we can access the same information with existing methods, simply calling size() on the returned array.
We discussed it on IRC today (logs from 16:15) and the consensus was that it's likely not worth adding to the API, and we should instead review existing int get_something_count() methods that match an exposed Array get_somethings() for Godot 4.0, to see if they're all worth keeping or if we can make things more consistent.


Disable Editor-Widgets

I'm not sure, if this is a bug, or just own disability ^^
I want to disable an editor-widget under some circumstances. I added an OpenListener to the editor to check the condition and disable the CheckBox
getEditor().addOpenListener(event -> {
            boolean enabled = !event.getBean().isRequired();
            activeCheckBox.setEnabled(enabled);
        });

But even if the CheckBox should be disabled, the EditorStateManager enables the CheckBox in the #waitForEditorOpen-> complete() Method of the Callback, because this column is not in the disabledColumns
Is there any other possibility to disable this CheckBox ?!

I think this discussion here is pretty much about the same thing. There are couple of ways to do this. One of them is to use event.disableColumns() method.
https://github.com/TatuLund/GridFastNavigation/issues/55

ah ok =)
hadn't seen this. thx
-- can be closed

No problem.


Disable CSRF for a route in routeRules

Is your feature request related to a problem? Please describe.
I'm using CSRF option in nuxt-security. I need to have a route handling a POST request from an external system that doesn't need CSRF protection, but getting a CSRF mismatch error for it.
It would be nice to have an option to disable CSRF in routeRules.

I should also mention that I tried using excludedUrls, and it doesn't work for me. I created a new Nuxt project to make sure it’s not something with my code. Installed nuxt and nuxt-security, created a route, added it to excludeUrls, but still getting CSRF mismatch error. And the type checker helper says it’s not a valid option.
`// https://nuxt.com/docs/api/configuration/nuxt-config
export default defineNuxtConfig({
devtools: { enabled: true },
modules: [
'nuxt-security',
],
security: {
	enabled: true,

	csrf: {
		enabled: true,
		https: true,
		cookie: {
			secure: true,
		},
		addCsrfTokenToEventCtx: true,
		excludedUrls: [
			'/test',
		],
	},
},

})`
{   "name": "nuxt-app",   "private": true,   "type": "module",   "scripts": {     "build": "nuxt build",     "dev": "nuxt dev",     "generate": "nuxt generate",     "preview": "nuxt preview",     "postinstall": "nuxt prepare"   },   "dependencies": {     "nuxt": "^3.11.2",     "nuxt-security": "^1.3.2",     "vue": "^3.4.21",     "vue-router": "^4.3.0"   } }

If I set CSRF enabled: false, the route works. Otherwise I'm getting a 403 CSRF Token Mismatch error. Maybe this should be a bug instead.

Hey, thanks for reporting this issuez
@Morgbn what are your thoughts on that? :)

Heyo, I have found the following in the nuxt csurf playground.
Could you try to add it to the nuxt.config.ts file and see if it makes a difference?
routeRules: {
    '/api/nocsrf': {
      csurf: false
    }
  },

I will be able to help end of this week as I am off for short vacations and dont have access to the computer :)

Hello !
Yes that's right, nuxt-csurf now supports configuration by route, and no longer excludedUrls. This new feature was supposed to be included only in v2, but the breaking change wasn't taken into account at release time.. apologize for the sudden change!

Thanks @Morgbn for details!
@igorgusarov could you check if it works like that? :)

@Baroshem @Morgbn This worked, thank you both!

Awesome, closing the issue then :)

Hi @Baroshem, @Morgbn,
I came across that thread as I also need to switch off CSRF for a few server routes, and also using nuxt-security v1.3.2.
However, I am still facing a few issues.
I have tried the following:
 security: {
    csrf: {
      routeRules: {
        "/server/route": {
          csurf: false,
        },
      },
      addCsrfTokenToEventCtx: true,
      methodsToProtect: ["POST", "PATCH"],
    }
}

But keep getting 403s. If I remove the csrf object altogether the requests go through.
Do the routeRules assume that the routes are api routes, or shall they work with server routes too?
Thanks!


Fibonacci Series

I created a issue for add some algorithm in java language #18 . @rudrakshi99 tell me to make separate issue for each algorithm. So I am creating this issue for Fibonacci.
Now, Can I work on this ?

I can implement this issue in java,c++,python.I am good at data structures and algorithm .Please assign me this issue under GSSOC'2021.

Hey, I am Kanchan Jeswani, a GSSOC'21 participant.
I am a Competitive Programmer and C++ enthusiastic.
I would love to solve this problem using CPP with well-explained code and along with its time and space complexity.
Please assign me this issue.
Hope to hear from you.
@anubhavitis @dheerajkotwani @tarun26091999 @todi-2000 @geekquad @plazzy99 @rudrakshi99

@pallavidhere23 do it in java
@Ayan-10 you cannot raise a PR until issue is assigned to you.

Hey @tarun26091999 Sorry for that. Actually I had made another issue some months ago and I was told to make separate PR for this issue. So I think I will be assigned and I made the PR. It was a misunderstanding. Sorry for inconvenience. It will never happen again.

hi, I am a Gssoc'21 participant and  I want to work on the "Fibonacci series using recursion " in python.
could you please assign me?  @tarun26091999

I want to work on this issue. Please assign to me

@tarun26091999 Pls assign it to me I want to do it in Java or python..

I would like to implement it using dynamic programming, please assign it to me.

please assign the issue to me, i want to do it in cpp

I would like to this in any of the following language Kotlin , Java or C . Please assign this to me

@tarun26091999 Pls Assign it me to would like to contribute in java

Hello! I am a GSSoC'21 Participant. I would like to work on this issue. Would be highly obliged if you could assign it to me. I will be using Java. Thanks!

@tarun26091999, I am new to open source and I am a GSSOC'21 participant. I can do it with the help of c++. Please assign me. As it would me my first PR . Thanks!

@tarun26091999 @kanchan1910 and other maintainers of the project, I am GSSoC'21 Participant, I would like to work over this issue in Python, please assign it to me.
Thanks!

hello @tarun26091999 thank you for assigning me this.
i will update asap.
plz assign me again, I have been removed mistakenly

@Aj7t do it soon


Move to Rust 2018 and get rid of extern crate

extern crate makes it less obvious where a given macro comes from. Especially the way we use it, i.e. by putting all extern crate lines at the root of the crate, where they affect all of our modules. Rust 2018 brings a slightly different system where macros are imported just like functions, e.g. use strprintf::fmt instead of #[macro_use] extern crate strprintf;.
The majority of these changes were automated. All I did was:

cargo fix --edition --package CRATE_NAME && cargo fmt, review and commit;
edit rust/CRATE_NAME/Cargo.toml to include edition = "2018". Commit;
cargo fix --edition-idioms CRATE_NAME && cargo fmt, review and commit.

(There were a few more changes fromcargo fix, but I only committed those that related to extern crate and use.)
The only changes that were done manually are in https://github.com/newsboat/newsboat/commit/97665ae5f4038ce0297c31c000741b39ba6f8d53 and https://github.com/newsboat/newsboat/commit/09c3ed6c979fa0a47594b1d82be86213780e826d.
These changes mean our code now requires Rust 1.31+. Considering no-one responded to our warning about scheduled MSRV bumps (#709), and no-one complained about master requiring 1.40+, this should not be a problem.
Despite the number of changed files, this is a very lightweight PR, so I'll merge it in three days. Reviews are welcome as usual!

Coverage remained the same at 56.935% when pulling 09c3ed6c979fa0a47594b1d82be86213780e826d on feature/no-extern-crate into 83b7f7010f55d1b5dad467e56df3eaf7d6fb48eb on master.


Better const prop

Don't merge until sure this passes for rocket-chip, there have been problems.

I've pushed a new commit that reverts to original behavior of running ConstProp before PadWidths because rocket-chip seems to break when that doesn't happen. I've also added some width padding  to ConstProp for Connections to wires so that things work properly. I'm kicking off a rocket-chip Travis run to check this PR overnight but I think it should work this way.

Okay given that https://github.com/freechipsproject/rocket-chip/pull/820 passes I think this is probably good to go, going to rebase the last commit then merge after Travis passes

This even improves compilation time despite adding a second pass to each iteration of ConstProp (probably due to fixing the performance bug which is technically orthogonal but reducing the amount of firrtl code should also make later passes run faster):
master (5135e9c6aeb1c9d472a5b29adb44a4acaf504fb8)
[info] BenchmarkVerilogCompiler.measureRob     avgt   10  11.647 ± 0.064   s/op
[info] BenchmarkVerilogCompiler.measureRocket  avgt   10  15.127 ± 0.237   s/op
better-const-prop (978d54599d92070158f941ea974b65f0ed383a53)
[info] BenchmarkVerilogCompiler.measureRob     avgt   10  11.052 ± 0.116   s/op
[info] BenchmarkVerilogCompiler.measureRocket  avgt   10  13.420 ± 0.276   s/op


Bump unarm to 1.5.0

unarm 1.5.0 fixes some erroneous instructions, including prioritizing LDRSB/LDRH/LDRSH over CMP (they have very similar bit patterns) and allowing backwards branches on Thumb (my apologies to GBA devs). See other changes at https://github.com/AetiasHax/unarm/pull/5.

Thanks for the continued ARM support!


Dead code diagnostic has wrong highlight range

The dead code analysis in the analyzer produces diagnostics with the wrong highlight range in at least two cases. Create a file in a package that will be analyzed with null safety enabled that has the following content (after removing the [[ and ]] markers:
void f() {
  for (int i = 0; i < 2; [[i++) {
    print(i);
    return;
  }]]
}

void g(bool c) {
  do {
    print(c);
    return;
  } while ([[c);]]
}

The markers indicate where the highlight ranges are. The offsets are correct, but the lengths are wrong. The first length should be 3 (rather than 36) and the second length should be 1 (rather than 3).

For the second case (with additional statements after the while loop):
void g(bool c) {
  do {
    print(c);
    return;
  } while (c);
  print('2');
}

I think it is not only the condition in while should be dead code, but also the following statements (print('2').
Also, how about marking the do { and } while(); as well, since they can be safely deleted, and their condition (c) is not the only dead code which isn't reachable.

@stereotype441
We are no longer reporting dead code in the first case, though I believe that the updater can't be reached. Is that expected?
Is the behavior in the second case (that only the condition is marked as being dead) expected, or should we be marking more, as per the second comment?

We are no longer reporting dead code in the first case, though I believe that the updater can't be reached. Is that expected?

Flow analysis is aware that the updater is unreachable, but the analyzer isn't querying reachability during the course of analyzing the updater.  Looking at the code for ResolverVisitor, it looks like a few visit methods simply don't call checkUnreachableNode.  It might be as easy as just sprinking in a few more unreachability checks.

Is the behavior in the second case (that only the condition is marked as being dead) expected, or should we be marking more, as per the second comment?

The behavior in the second case is that the additional statements after the while loop are marked as unreachable, and this is correct from the standpoint that yes, those statements are indeed unreachable.  However, it feels a little weird to me that we highlight c); print('2'); as a single range of unreachable code.  I think we're trying to do some clever heuristics in NullSafetyDeadCodeVerifier to try to coalesce together the results of several individual calls to isReachable into nice human-comprehensible code ranges.  Those same heuristics are probably why in the original issue report, we highlighted c); as unreachable rather than just c.
Maybe we're being too clever for our own good?  It seems like we could replace the clever logic in NullSafetyDeadCodeVerifier with a few simple heuristics based on the immediate parent of the dead node, e.g.:

If control flow is unreachable at the beginning of any statement, highlight the statement as unreachable.  If the statement's parent is a block, or a switch member, extend the unreachable range to include the rest of the statements in the parent as well.
If control flow is unreachable at the beginning of any expression, highlight the expression as unreachable.

If the expression's parent is a list literal, set literal, or argument list, extend the unreachable range to include the rest of the expressions in the parent as well.
If the expression's parent is a binary operator (and the expression is the RHS of the binary operator), extend the unreachable range to include the operator as well (this way, if the parent is true || x, we mark || x as unreachable, which is nice because the user could delete the || x without effect)

And of course:

If control flow is unreachable at the beginning of any expression or statement, we suppress reporting of dead code for sub-expressions and sup-statements, so that the user doesn't see overlapping dead code hints.

https://dart-review.googlesource.com/c/sdk/+/260109
changes the range of dead code of the RHS of binary operator

https://dart-review.googlesource.com/c/sdk/+/260110
handles do statement as two separate regions (one for do, another for while), and correcting the quick fix.

For removing the following statements after the do while, please see sdk/263900
There is a currently a failing test, which points to this issue of the scenario:

void f(bool c) {
  do {
    print(c);
    return;
  } while (c);
}

It is expecting at the return is removed. It is more like a lint I guess, however the following case is not triggering any hint or lint (unnecessary_statements for example)
void f() {
  return;
}

So, I guess we follow the test expectation, and lint about the unnecessary return (in various situations), or the test expectation should be changed to accept the existence of a redundant empty return.

https://dart-review.googlesource.com/c/sdk/+/263940 for the first part in OP.

https://dart-review.googlesource.com/c/sdk/+/266388
which is similar to https://github.com/dart-lang/sdk/commit/931961eac8d38df12f14a6d8b945c4c4840d2979.
MethodInvocation was missed, because I incorrectly locally tested it as a Statement, not as an Expression.

https://dart-review.googlesource.com/c/sdk/+/271200
Fixes an additional case, as was hinted in the review in https://dart-review.googlesource.com/c/sdk/+/266389/comment/7c2f0988_3783009b/


wip: prerender for vercel static

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#358  👈
#357
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on  Graphite


Training the model with my own data

Hi,
As the train.py describes, the program support training with my own data. However, when I use my own .wav files by --data_dir, it says IOError: CRC check failed 0x7668da3b != 0x316d6d75L. Have you ever test the program with some other database instead of the google recordings? Thanks.

Hi @zhaoforever,
It works fine on a different dataset. To train on your own data, use "--data_url= " (i.e. data_url=) along with --data_dir as given in comments here. Otherwise, the script tries to download the speech commands dataset into your data_dir (and cause CRC check fail error, if interrupted before the full download of the speech commands dataset).

@navsuda Thanks for your advice and the program runs well using both the google dataset and my own. But when I use the "python train.py --model_architecture ds_cnn --model_size_info 5 64 10 4 2 2 64 3 3 1 1 64 3 3 1 1 64 3 3 1 1 64 3 3 1 1 --dct_coefficient_count 10 --window_size_ms 40 --window_stride_ms 20 --learning_rate 0.0005,0.0001,0.00002 --how_many_training_steps 10000,10000,10000" command to get the .pb file of google database, the recognition results seems terrible comparing with the pretrained models. Does anything else need to be done?

Hi @zhaoforever,
What accuracy are you getting? This model should give close to 94% accuracy with those parameters.

@navsuda The accuracy of the training result about 94%. But when I run the label_wav.py using the trained  model, the accuracy is below 50%.

@navsuda Thanks for your help. The accuracy is low as the window size is not set correctly.

Hi @zhaoforever ,
My own data are used to train the model, the accuracy 95.19. Then, the following command to generate pb model file used. Then the following error appears, what may be the reason?
python train.py --model_architecture dnn --model_size_info 144 144 144 --dct_coefficient_count 10 --window_size_ms 40 --window_stride_ms 40 --learning_rate 0.0005,0.0001,0.00002 --how_many_training_steps 10000,10000,10000 --summaries_dir work/DNN/DNN1/retrain_logs --wanted_words 'help,stop,start,goup,others'  --train_dir ./data/ --data_url= --data_dir ./data

python freeze.py --model_architecture dnn --model_size_info 144 144 144 --checkpoint=./data/best/dnn_9519.ckpt-9600 --output_file dnn_kws.pb

InvalidArgumentError (see above for traceback): Assign requires shapes of both tensors to match. lhs shape= [3920,144] rhs shape= [250,144]

@sailor88128 When using file freeze.py , you also need the following parameters  "--dct_coefficient_count 10 --window_size_ms 40 --window_stride_ms 40" .

@zhaoforever  It's OK now. thanks!

Thanks @zhaoforever.
Closing this issue

In my case the error was due to difference between number of wanted_words with default words, so I resolved that with adding --wanted_words switch for freeze.py and the error cleared out.

Hi @zhaoforever ,
My own data are used to train the model, the accuracy 95.19. Then, the following command to generate pb model file used. Then the following error appears, what may be the reason?
python train.py --model_architecture dnn --model_size_info 144 144 144 --dct_coefficient_count 10 --window_size_ms 40 --window_stride_ms 40 --learning_rate 0.0005,0.0001,0.00002 --how_many_training_steps 10000,10000,10000 --summaries_dir work/DNN/DNN1/retrain_logs --wanted_words 'help,stop,start,goup,others'  --train_dir ./data/ --data_url= --data_dir ./data

python freeze.py --model_architecture dnn --model_size_info 144 144 144 --checkpoint=./data/best/dnn_9519.ckpt-9600 --output_file dnn_kws.pb

InvalidArgumentError (see above for traceback): Assign requires shapes of both tensors to match. lhs shape= [3920,144] rhs shape= [250,144]

In my case the error was due to difference between number of wanted_words with default words which is 12, so I resolved that with adding --wanted_words switch for freeze.py and the error cleared out.


Fix build

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.851%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
94

Relevant Lines:
94

💛  - Coveralls


Filtering in outrider.R and how to load output to voila

Dear developers,
First thank you for bringing such a beautiful tool!
A few questions I encountered when using this for my own data:

In “outrider.R” script, the filtering step used the following filtering rule:
"filter counts based on TPM_genes with 95th percentile > 0.1875"
If I understand correctly, tpm.tsv file would be generated for gene, exon and intron respectively by the normalisation_methods.py. May I know if you used the same filtering criteria for all three?

I obtained the output from outrider.R now, and I was able to set up the server for voila application (I can navigate through your demo data with this server). Could you please give an instruction on how to load my own data to the voila application. The github instructions appear to have a gap between these two steps.

The outrider output for my exon file was listed below. Does the minor difference of missing transcript ID in the last column (as in your demo outrider output) affect voila navigation?

╰─$ head res_outr_expBG01_pax_untreated_exons_counts.csv
geneID,sampleID,pValue,padjust,zScore,l2fc,rawcounts,normcounts,meanCorrected,theta,aberrant,AberrantBySample,AberrantByGene,padj_rank,FDR_set,treatment,species,experiment_GS,R031,chr,start,end,gene
10_100003847_100003912_R3HCC1L-NM_001256619.2,R001,0.4448672503844058,1,0.73,0.08,395,311.64,295.93,491.56,FALSE,0,0,257173.5,transcriptome-wide,untreated,pax,BG01,299,10,100003847,100003912,R3HCC1L
10_100003847_100003912_R3HCC1L-NM_001256619.2,R002,0.4921346523117049,1,-0.64,-0.06,355,281.37,295.93,491.56,FALSE,0,0,257173.5,transcriptome-wide,untreated,pax,BG01,299,10,100003847,100003912,R3HCC1L
10_100003847_100003912_R3HCC1L-NM_001256619.2,R003,0.9828578923210077,1,-0.03,0,286,294.53,295.93,491.56,FALSE,2,0,257174.5,transcriptome-wide,untreated,pax,BG01,299,10,100003847,100003912,R3HCC1L
10_100003847_100003912_R3HCC1L-NM_001256619.2,R004,0.6324825391935679,1,-0.49,-0.05,280,284.64,295.93,491.56,FALSE,0,0,257173.5,transcriptome-wide,untreated,pax,BG01,299,10,100003847,100003912,R3HCC1L
10_100003847_100003912_R3HCC1L-NM_001256619.2,R005,0.7760281961425951,1,0.31,0.04,351,301.92,295.93,491.56,FALSE,0,0,257173.5,transcriptome-wide,untreated,pax,BG01,299,10,100003847,100003912,R3HCC1L
10_100003847_100003912_R3HCC1L-NM_001256619.2,R006,0.8904038309099112,1,-0.12,-0.01,398,292.47,295.93,491.56,FALSE,0,0,257173.5,transcriptome-wide,untreated,pax,BG01,299,10,100003847,100003912,R3HCC1L
Thanks again, and I really appreciate your kind help.

TPM counts were indeed generated for gene, exon and intron; but in the filtering step (outrider) we only make use of the TPM gene counts. The genes with TPM <0.1875 are filtered out of the resp. gene-, exon- and intron count files.
To load your own data you have to rewrite the voila application for your own locations and your own filenames. For rewriting this script you may need the help of a (bio)informatician.
Any difference in the number of columns, or column names effects the working of the voila application. As I mentioned in 2. You might need the help of a (bio)informatician to rewrite the application before running it on your own data.

I hope this helped you out, Good luck!


remove blank line between results in output

This method will change the output to remove the blank lines between every result line. Here is an example:
plasmactl dependencies foundation/applications/roles/metrics
INFO  Selected source is .compose/build
INFO  Dependencies:
foundation/services/roles/metrics_prometheus_alert_machine

foundation/softwares/roles/prometheus

foundation/softwares/roles/prometheus_alert_machine

integration/libraries/roles/application
...

to
plasmactl dependencies foundation/applications/roles/metrics
INFO  Selected source is .compose/build
INFO  Dependencies:
foundation/services/roles/metrics_prometheus_alert_machine
foundation/softwares/roles/prometheus
foundation/softwares/roles/prometheus_alert_machine
integration/libraries/roles/application
...

It allow to get a better experience for user that want to chain multiple commands between them.
Eg if I want to get the defaults values of a new component and all its dependencies I can do:
for dep_path in $(plasmactl dependencies foundation/applications/roles/metrics); do cat $dep_path/defaults/main.yaml; done

Tested ok


Samvera, the Change we believed in

We will share our experience as we built the United States Department of Agriculture's  Economics Statistics and Market Information System (USDA ESMIS) from Sufia 7.2 to Hyrax 2.1.
Tahir Poduska<EMAIL_ADDRESS>Lynette Rayle,
John Fereira - unable to attend

Lynette registered 8/14 - system info

Reg reminder 8/23


update sqlite3 to 3.45.2

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[x] The "supports" clause reflects platforms that may be fixed by this new version.
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

The CI is cancelled...

It seems the CI is still running: https://dev.azure.com/vcpkg/public/_build/results?buildId=100561&view=results
But the statuses here are not updated?

@c8ef Do you want to continue this PR?

I open another pr in #37404, in which CI works fine.


feat(NumberTheory/LSeries): introduce notations

This just introduces L as a short notation for LSeries and ↗f as notation for fun n : ℕ ↦ (f n : ℂ),
both scoped to LSeries.notation. The latter makes it convenient to use arithmetic functions
or Dirichlet characters (or anything that coerces to a function N → R, where ℕ coerces
to N and R coerces to ℂ) as arguments to LSeries etc. The first is for convenience (and agreement with informal math, where we write "L(f, s)"), and the second one considerably simplifies statements involving Dirichlet characters or arithmetic functions like the von Mangoldt function and their L-series.
See here on Zulip.

maintainer merge


Unit tests it's not running in travis

It's easy to check it in any build log
https://travis-ci.org/angular-ui/ui-select/builds/110334334

They're running just not displayed in reported. (karma-runner/karma/issues/1344).


Bug: No cap on dates in the burndown chart

Currently, the chart has no cap on days shown. This may cause the chart to overflow if the data size is large (multiple months).
Add checks for this to ensure that the maximum days shown for total work left does not exceed 30 days.

Same reasoning as in #129


[ERROR DRT-0218] Guide is not connected to design.

Describe the bug
Following the suggestion here https://github.com/The-OpenROAD-Project/OpenROAD/discussions/5507#discussioncomment-10250593 on how to run repair_antennas after detailed routing, OpenROAD generates the error reported in the title. Note that this specifically happens when repair_antennas -iterations 2 is set to higher than 1 iterations.
Expected Behavior
Unless there is something wrong with the script, this error shouldn't happen
Environment
Git commit: 56c3c86ba5aea97d1a6c18e90c8d2076c5740929
kernel: Linux 6.10.12-1-liquorix-amd64
os: Ubuntu 22.04.4 LTS (Jammy Jellyfish)
cmake version 3.25.1
-- The CXX compiler identification is GNU 11.4.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- OpenROAD version: v2.0-16219-g56c3c86ba
-- System name: Linux
-- Compiler: GNU 11.4.0
-- Build type: RELEASE
-- Install prefix: /usr/local
-- C++ Standard: 17
-- C++ Standard Required: ON
-- C++ Extensions: OFF
-- The C compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Performing Test C_COMPILER_SUPPORTS__-Wall
-- Performing Test C_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Failed
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal
-- PerformingCMake Warning at src/CMakeLists.txt:267 (message):
  spdlog: SPDLOG_FMT_EXTERNAL=ON

CMake Warning (dev) at src/sta/CMakeLists.txt:32 (option):
  Policy CMP0077 is not set: option() honors normal variables.  Run "cmake
  --help-policy CMP0077" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  For compatibility with older versions of CMake, option is clearing the
  normal variable 'USE_TCL_READLINE'.
This warning is for project developers.  Use -Wno-dev to suppress it.

 Test C_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Failed
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive - Success
-- Performing Test C_COMPILER_SUPPORTS__-x
-- Performing Test C_COMPILER_SUPPORTS__-x - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-x
-- Performing Test CXX_COMPILER_SUPPORTS__-x - Failed
-- Performing Test C_COMPILER_SUPPORTS__c++
-- Performing Test C_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__c++
-- Performing Test CXX_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test C_COMPILER_SUPPORTS__-std=c++17
-- Performing Test C_COMPILER_SUPPORTS__-std=c++17 - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-std=c++17
-- Performing Test CXX_COMPILER_SUPPORTS__-std=c++17 - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- TCL readline library: /usr/lib/x86_64-linux-gnu/libtclreadline.so
-- TCL readline header: /usr/include/x86_64-linux-gnu
-- Found SWIG: /usr/bin/swig4.0 (found suitable version "4.0.2", minimum required is "4.0")
-- Found Boost: /usr/local/lib/cmake/Boost-1.81.0/BoostConfig.cmake (found version "1.81.0")
-- boost: 1.81.0
-- Found GTest: /home/karim/.local/lib/cmake/GTest/GTestConfig.cmake (found version "1.13.0")
-- GTest: 1.13.0
-- Found Python3: /usr/include/python3.10 (found version "3.10.12") found components: Development Development.Module Development.Embed
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11")
-- Found Threads: TRUE
-- spdlog: 1.9.2
-- Found BISON: /usr/bin/bison (found version "3.8.2")
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
-- STA version: 2.6.0
-- STA git sha: 20925bb00965c1199c45aca0318c2baeb4042c5a
-- System name: Linux
-- Compiler: GNU 11.4.0
-- Build type: RELEASE
-- Build CXX_FLAGS: -O3 -DNDEBUG
-- Install prefix: /usr/local
-- Found FLEX: /usr/bin/flex (found version "2.6.4")
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- TCL readline library: /usr/lib/x86_64-linux-gnu/libtclreadline.so
-- TCL readline header: /usr/include/x86_64-linux-gnu/tclreadline.h
-- CUDD library: /usr/local/lib/libcudd.a
-- CUDD header: /usr/local/include/cudd.h
-- SSTA: 0
-- Found SWIG: /usr/bin/swig4.0 (found suitable version "4.0.2", minimum required is "3.0")
-- STA executable: /home/karim/work/OpenROAD/src/sta/app/sta
-- Found re2: /home/karim/Downloads/or-tools_x86_64_Ubuntu-22.10_cpp_v9.5.2237/lib/cmake/re2/re2Config.cmake (found version "9.0.0")
-- Found Clp: /home/karim/Downloads/or-tools_x86_64_Ubuntu-22.10_cpp_v9.5.2237/lib/cmake/Clp/ClpConfig.cmake (found version "1.17.7")
-- Found Cbc: /home/karim/Downloads/or-tools_x86_64_Ubuntu-22.10_cpp_v9.5.2237/lib/cmake/Cbc/CbcConfig.cmake (found version "2.10.7")
-- Found SCIP: /home/karim/Downloads/or-tools_x86_64_Ubuntu-22.10_cpp_v9.5.2237/lib/cmake/scip/scip-config.cmake (found version "8.0.1")
-- Found OpenMP_CXX: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- Found OR-Tools: /home/karim/Downloads/or-tools_x86_64_Ubuntu-22.10_cpp_v9.5.2237/lib/cmake/ortools (version: 9.5.2237)
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- Found OpenMP_C: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- GUI is enabled
-- Charts widget is not enabled
-- Found Boost: /usr/lNumber of processor cores: 20
ocal/lib/cmake/Boost-1.81.0/BoostConfig.cmake (found version "1.81.0") found components: serialization
-- Could NOT find VTune (missing: VTune_LIBRARIES VTune_INCLUDE_DIRS)
-- Found Boost: /usr/local/lib/cmake/Boost-1.81.0/BoostConfig.cmake (found suitable version "1.81.0", minimum required is "1.78")
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- Found Boost: /usr/local/lib/cmake/Boost-1.81.0/BoostConfig.cmake (found version "1.81.0") found components: serialization system thread
-- Found Boost: /usr/local/lib/cmake/Boost-1.81.0/BoostConfig.cmake (found version "1.81.0")
-- Found Eigen3: /usr/share/eigen3/cmake/Eigen3Config.cmake (found version "3.4.0")
-- TCL readline enabled
-- Tcl Extended disabled
-- Python3 enabled
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/tmp.5UO7epjLQS

To Reproduce
test-case.ab.tar.gz
test-case.aa.tar.gz
cat test-case.* > test-case.tar.gz
tar xvf test-case.tar.gz
cd test-case
openroad -exit run.tcl

run.tcl:
read_db ./picorv32.odb
read_liberty ./sky130_fd_sc_hd__tt_025C_1v80.lib
read_sdc ./base.sdc
set_thread_count 20
remove_fillers
set_global_routing_layer_adjustment * 0.4
set_routing_layers -signal met1-met5 -clock met1-met5
global_route -start_incremental -allow_congestion -verbose
repair_antennas -iterations 2
global_route -end_incremental -allow_congestion -verbose
detailed_route -save_guide_updates -verbose 1 -bottom_routing_layer met1 -top_routing_layer met5

Relevant log output
[INFO DRT-1000] Pin _06122_/X not in any guide. Attempting to patch guides to cover (at least part of) the pin.
[INFO DRT-1000] Pin _06129_/A1 not in any guide. Attempting to patch guides to cover (at least part of) the pin.
[INFO DRT-1000] Pin _06161_/B not in any guide. Attempting to patch guides to cover (at least part of) the pin.
[INFO DRT-1000] Pin _06163_/X not in any guide. Attempting to patch guides to cover (at least part of) the pin.
[INFO DRT-1000] Pin _06164_/X not in any guide. Attempting to patch guides to cover (at least part of) the pin.
[INFO DRT-1000] Pin _06172_/C not in any guide. Attempting to patch guides to cover (at least part of) the pin.
[INFO DRT-1000] Pin _06171_/X not in any guide. Attempting to patch guides to cover (at least part of) the pin.
[INFO DRT-1000] Pin _06172_/X not in any guide. Attempting to patch guides to cover (at least part of) the pin.
[INFO DRT-1000] Pin _06174_/X not in any guide. Attempting to patch guides to cover (at least part of) the pin.
[WARNING DRT-1001] No guide in the pin neighborhood
[WARNING DRT-0215] Pin _06174_/X not covered by guide.
[WARNING DRT-0215] Pin _06174_/X not covered by guide.
[WARNING DRT-0225] _02593_ 2 pin not visited, fall back to feedthrough mode.
[WARNING DRT-0224] _02593_ 2 pin not visited, number of guides = 4.
[ERROR DRT-0218] Guide is not connected to design.
Error: run.tcl, 10 DRT-0218

Screenshots
No response
Additional Context
No response

For post-DRT repair_antennas, I don't recommend to use the -iterations keyword for this command, since in the second iteration the antennas will be evaluated following the route guides. I suggest something similar to what OR regression tests and ORFS do:
OR regression: https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/test/flow.tcl#L244-L272
ORFS: https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/blob/master/flow/scripts/detail_route.tcl#L53-L61
In any case, this error should not be happening. I will investigate what is happening here.

For post-DRT repair_antennas, I don't recommend to use the -iterations keyword for this command, since in the second iteration the antennas will be evaluated following the route guides. I suggest something similar to what OR regression tests and ORFS do: OR regression: https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/test/flow.tcl#L244-L272 ORFS: https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/blob/master/flow/scripts/detail_route.tcl#L53-L61
In any case, this error should not be happening. I will investigate what is happening here.

Thank you. In the sections that you posted, I noticed that -iterations is not used at all and the loop is capped at 5 iterations. Is there a specific reason for the cap?

@kareefardi I was able to complete your design with zero antenna violations doing the following updates to your script:
read_db ./picorv32.odb
read_liberty ./sky130_fd_sc_hd__tt_025C_1v80.lib
read_sdc ./base.sdc
set_thread_count 20
remove_fillers
set_global_routing_layer_adjustment * 0.4
set_routing_layers -signal met1-met5 -clock met1-met5

set repair_antennas_iters 1
while {[check_antennas] && $repair_antennas_iters < 5} {
  repair_antennas
  detailed_route -save_guide_updates -verbose 1 -bottom_routing_layer met1 -top_routing_layer met5
  incr repair_antennas_iters
}

check_antennas

It takes two iterations to reach zero violations.

@kareefardi I was able to complete your design with zero antenna violations doing the following updates to your script:
read_db ./picorv32.odb
read_liberty ./sky130_fd_sc_hd__tt_025C_1v80.lib
read_sdc ./base.sdc
set_thread_count 20
remove_fillers
set_global_routing_layer_adjustment * 0.4
set_routing_layers -signal met1-met5 -clock met1-met5

set repair_antennas_iters 1
while {[check_antennas] && $repair_antennas_iters < 5} {
  repair_antennas
  detailed_route -save_guide_updates -verbose 1 -bottom_routing_layer met1 -top_routing_layer met5
  incr repair_antennas_iters
}

check_antennas

It takes two iterations to reach zero violations.

@eder-matheus I noticed you are not using global_route -start_incremental. Is it not needed?

@eder-matheus I noticed you are not using global_route -start_incremental. Is it not needed?

For post-DRT repair_antennas it is not needed. repair_antennas itself is responsible to store and call grt to reroute the modified nets. At some point, I would like to not need to call global_route -start_incremental for any command, but for now only repair_antennas has support for it.


[TASK] ReadME for frontend mobile

Task Request

[x] can someone please make the 2 iphones overlap each other
just like how it is in the figma

@waveyboym , please tick off as you complete each task by clicking on the task you are done with in this comment
Additional info
File under discussion: https://github.com/COS301-SE-2024/occupi/blob/develop/frontend/occupi-mobile/README.md?plain=1#L5-L6

@u21631532 , completed


Device type creation: Dynamic source registration

Can not set the dynamic source registration when creating a new device type, either when creating or editing. There should be a checkbox to enable or disable dynamic source registration.

Correction: clicking the label 'Dynamic source registration' and then saving actually toggles the state, so there might be display issue.

@dennyverbeeck i tested this on latest dev and i do not see any problems. Clicking on the Dynamic source registration checkbox should change the state, so should be the display.


apple app review

can this be used in production app ? .. dose it pass apple app review?

This repo contains mostly type aliases to hidden public types of SwiftUI. I don't see any reason why it won't pass apple app review. As of can this be used in production app - it's up to you to decide, I don't provide a warranty of any kind that these types will persist being available in future versions of SwiftUI.


API 0.9 order endpoint alpabetically

closed as the api 0.9 page will be removed in next docs version


User/bdschnapp/jaco bringup

I'm going to set this to be ready for review so we can leave reviews on it

For more arm stability changes for the gripper are needed to be made. I've detailed them here: https://bdschnap.atlassian.net/wiki/spaces/FYDP/pages/38600718/Arm+control+application. Basically I think we should bound the input values to the kinova driver to 0.01 and 0.165(seen from the init sequence where the grippers open and close) to make sure the gripper code does not crash due to the math error. Then we can find the expected range of moveit values and then map them to the range of 0.01-0.165. I can do this if we agree this is useful

should this be closed

Yeah the new branch has the same changes and does not have a lot of the other messy things. I will close https://github.com/nightingale-project/kinova-movo/pull/33


Update checkoutRequiredCodeToBuild() to checkout the expected branch

Using the expected branch is required for
https://github.com/ibmruntimes/openj9-openjdk-jdk21/pull/42 to work and automatically checkout the same branch of OpenJ9 and OMR.

Updated.

@AdamBrousseau this can be merged any time. If it causes a problem for the milestone/RC/GA build, we can revert or fix it.

I think the only effect of reset --hard was to check out the desired commit. The problem was that it operated on the default branch. The proposed order avoids modifying any branches (even those local to the clone), other than to possibly create the requested (local) branch (tracking the remote branch of the same name).
After running checkout -B, reset --hard should have no effect. Done in the reverse order might leave the (local) branch (with the default name) at a commit other than where the corresponding, remote tracking branch points in the remote repository. Since we never push that (default) branch to the remote repository, it never mattered.
Because reset --hard should never do anything after checkout -B, we could remove reset --hard, but I think we might have a harder time convincing Adoptium of that.
The bottom line is that we (OpenJ9) care what the branch name is as the build proceeds, so we need to use some command that arranges that.

Talked to Pete.
When we do the reset we are on some branch (openj9 usually). Resetting to the right SHA will not checkout that branch. So when the ext code sniffs for the branch name it won't return what we want.
We do a fresh clone every time so the reset shouldn't be needed after the checkout but leaving it in doesn't hurt. I'm still not entirely sure how it would be different if we did the reset first then the checkout. Adopt might have a comment and also they don't clean their WS between builds so they may hit that code differently.


@NotEmpty fields in config break the configuration

We are building a Core library on top of dropwizard, it provides some default, basic values for configurations, and allow to specific service to override them.
We got several breaking changes after https://github.com/dropwizard/dropwizard/commit/207c3cbc98131463bc28cbf6cab814f44af1ece2#diff-e5126a75b90a2bf1ce64a60b923c8eadR343
For example:
-    @NotNull
-    private String driverClass = null;

+    @NotEmpty
+    private String driverClass = "";

driverClass has an empty string in Core config. But now, a specific service which don't use database, cannot validate the config, until provides some dummy value.
Of course, we can find a workaround for this, just want to point your attension to our usecase.
Maybe, it worth to not be so strict with validation rules.

Thanks, I will take a look where we use empty strings with @NotEmpty and whether null values makes sense like in such cases.


Fix #151011

Fix #151011

Tests are failing because of this change. Will fix them and resubmit for review.

Fixed tests !
@bpasero Can you please review and approve again.


Add Workload Identity Support

Resolves #2158
In this pull request, I make two changes:

Use the User Id as the Client Id for workload identity if specified when using Authentication = Active Directory Default
Add a new value ActiveDirectoryWorkloadIdentity for the enum SqlAuthenticationMethod that operates very similarly to ActiveDirectoryManagedIdentity except that it uses WorkloadIdentityCredential instead.

Like with managed identities, it will use the value of the User Id parameter in the connection string for its Client Id if specified. But unlike managed identity, WorkloadIdentityCredentialOptions defaults its value from environment variables: AZURE_TENANT_ID, AZURE_CLIENT_ID, and AZURE_FEDERATED_TOKEN_FILE. As of writing this description, only the Client Id may be overridden by the connection string.

To use WorkloadIdentityCredential, I needed to update Azure.Identity to 1.9.0 and Azure.Core to 1.32.0.

@wsugarman,I have not investigated the details yet, but couldn’t’ve achieved this by setting a custom provider? I will dig deeper into this next week, but do we have to add every possible scenario to the driver?

@wsugarman,I have not investigated the details yet, but couldn’t’ve achieved this by setting a custom provider? I will dig deeper into this next week, but do we have to add every possible scenario to the driver?

I had no idea this API existed 😅 This would be a great workaround!
I do think the library will benefit from including it in the driver as it replaces more and more managed identity scenarios.

In addition to creating a custom provider that overrides existing authentication options, there is a new, simpler AccessTokenCallback property added in 5.2 preview 3 that makes implementing new token authentication methods much easier. (Not quite as easy as a connection string adjustment, but a-few-lines-of-code easy.)
using Azure.Core;
using Azure.Identity;
using Microsoft.Data.SqlClient;
...

            string s_defaultScopeSuffix = "/.default";
            DefaultAzureCredentialOptions options = new()
            {
                //set your options here
                ExcludeAzureCliCredential = true,
                ExcludeVisualStudioCredential = true
            };
            var cred = new DefaultAzureCredential(options);
            Func<SqlAuthenticationParameters, CancellationToken, Task<SqlAuthenticationToken>> myTokenCallback = async (ctx, cancellationToken) =>
            {
                string scope = ctx.Resource.EndsWith(s_defaultScopeSuffix) ? ctx.Resource : ctx.Resource + s_defaultScopeSuffix;
                AccessToken token = await cred.GetTokenAsync(new TokenRequestContext(new[] { scope }), cancellationToken);
                return new SqlAuthenticationToken(token.Token, token.ExpiresOn);
            };

            using (SqlConnection sqlConnection = new SqlConnection("Server=name.database.windows.net;Database=db;"))
            {
                sqlConnection.AccessTokenCallback = myTokenCallback;
                sqlConnection.Open();
                Console.WriteLine("Connected successfully!");
            }

In addition to creating a custom provider that overrides existing authentication options, there is a new, simpler AccessTokenCallback property added in 5.2 preview 3 that makes implementing new token authentication methods much easier. (Not quite as easy as a connection string adjustment, but a-few-lines-of-code easy.)
using Azure.Core;
using Azure.Identity;
using Microsoft.Data.SqlClient;
...

            string s_defaultScopeSuffix = "/.default";
            DefaultAzureCredentialOptions options = new()
            {
                //set your options here
                ExcludeAzureCliCredential = true,
                ExcludeVisualStudioCredential = true
            };
            var cred = new DefaultAzureCredential(options);
            Func<SqlAuthenticationParameters, CancellationToken, Task<SqlAuthenticationToken>> myTokenCallback = async (ctx, cancellationToken) =>
            {
                string scope = ctx.Resource.EndsWith(s_defaultScopeSuffix) ? ctx.Resource : ctx.Resource + s_defaultScopeSuffix;
                AccessToken token = await cred.GetTokenAsync(new TokenRequestContext(new[] { scope }), cancellationToken);
                return new SqlAuthenticationToken(token.Token, token.ExpiresOn);
            };

            using (SqlConnection sqlConnection = new SqlConnection("Server=name.database.windows.net;Database=db;"))
            {
                sqlConnection.AccessTokenCallback = myTokenCallback;
                sqlConnection.Open();
                Console.WriteLine("Connected successfully!");
            }

Oh! That will be great! So, it will join the existing AccessToken property, but this will be a more generic callback complete with the auth parameters from the connection string?
That will be super helpful, but I still think a common scenario like workload identity will warrant inclusion in the driver. Otherwise, users will have to create the same workload identity SqlAuthenticationProvider or likely create some abstraction around SqlConnection that automatically assigns the AccessTokenCallback if there a lot of places in the codebase where a SqlConnection is created and opened.

Oh! That will be great! So, it will join the existing AccessToken property, but this will be a more generic callback complete with the auth parameters from the connection string?

Yes. The AccessToken property suffers from some major drawbacks that affect connection pooling:

SqlClient doesn't know when the token will expire, resulting in errors when a connection with an expired token is obtained from the connection pool.
Since it's part of the pool key, if you set min pool size, those min connections will never be automatically cleaned up unless ClearPool() or ClearAllPools() is called.

The callback gives SqlClient the expiration date and allows it to get a new token when a new physical connection is required, just like the built-in methods.

That will be super helpful, but I still think a common scenario like workload identity will warrant inclusion in the driver. Otherwise, users will have to create the same workload identity SqlAuthenticationProvider or likely create some abstraction around SqlConnection that automatically assigns the AccessTokenCallback if there a lot of places in the codebase where a SqlConnection is created and opened.

Oh definitely. It's just difficult to keep up with all the new Azure AD authentication methods they keep coming up with. So a generic method at least takes the pressure off implementing every new one ASAP. You can write a wrapper around SqlConnection to authenticate however you want and still have connection pooling work correctly.

@JRahnama - Thanks for merging it!


Update disks-prem-v2-limitations.md

based on the https://msazure.visualstudio.com/One/_workitems/edit/24440243

Thanks, @roygara. I committed the change to fix the validation warning. Go ahead and #sign-off when this PR is ready to merge.

Thanks @Court72 :)
#sign-off


TypeRef.Equals should check assembly MVID

Currently TypeRef.Equals does not check the MVID of its assembly, just the full assembly name. This is inconsistent with the check that TryUseFastReflection uses. Meaning that cache equality comparisions can return true but slow reflection would still have to be used.

Looking into this more I don't think TypeRef is actually the correct place for this change. The issue is that TypeRef was meant to be considered equal even if the MVIDs were different. If this was not the case then you wouldn't be able to grab an export from a slightly stale catalog since the two types would not be considered equal. @AArnott, thoughts?

Does it already consider metadata token in equality checks? If so, then we must already have code in place to handle your scenario.


test: show mock chain tips instead of entire chains in failures

Some of our failures now include hundreds of blocks. 'show' for hundreds of
blocks for each of 2-5 nodes creates hundreds of megabytes of output, most of
which is entirely useless. That much output makes the logs difficult to
interpret and unnecessarily bloats the artifacts from the nightly build run.
If that info is actually required for a debugging session, the unlucky dev can
revert this commit. (Though I would recommend projecting out the relevant parts
of the blocks and/or subarrays of the chain instead of dumping the whole
thing.)

Yep, that's exactly my most constant pain point with this as well.

bors r+

That bors failure seems like a hiccup and also unrelated to this diff. Retrying.

bors retry

Hydra is being clever and reused the previous result :grin:. I typically ask @nc6 to let Hydra rerun the job in question.


Separate reader and writer classes

Summary
The original code contained a comment at the top of the read(Uint8List bytes) method:
 // Utils for reading.

... followed by a bunch inline utility functions. These have all been moved to a separate WavBytesReader class.
Similarly, the Uint8List write() method included the following comment:
// Utils for writing.

Again, all of the subsequent inline utility classes have been moved to a separate WavBytesWriter class.
In order to be able to put those classes in separate files, a couple of other things that were dependencies of both also had to be moved to a separate file (to avoid circular references). So there are some odds and ends in the wav_types.dart and wav_utils.dart files.
Important Note
wav.dart was renamed to wav_file.dart. The reason for this is so that existing code that depended on a single import of wav.dart will continue to function without change. The wav.dart file now simply exports two other files that are required to use this package. This makes it look like a much bigger change than it actually is.

Hey @liamappelbe... having another crack at it. I tried to keep this as small/tight as possible. It looks much more significant than it is becuase I renamed wav.dart to wav_file.dart.
This pull request is simply moving the reader/writer util functions into their own classes/files... which, I think, makes the Wav.read and Wav.write methods much smaller and easier to reason about.
Let me know your thoughts.
Cheers,
James

I don't see a button to run the tests on my github UI, so I assume that won't be possible until you mark it ready for review.

Yeah it was a draft PR. I've incorporated all your feedback/suggestions and changed the status to "Ready for Review".
Regarding the tests, writeTest('float64', WavFormat.float64) fails the expect on my machine at line 36 (both in this branch and in the main branch):
location [256] is <168> instead of <169>

I imagine all these tests are passing for you, so this might be related to my operating environment.

It looks like CI turned itself off because I haven't had to touch this repo in a while. Maybe that's why I still don't have a button to run the tests on this PR. I'll have to get the bot running again before we can safely submit this PR.

I imagine all these tests are passing for you, so this might be related to my operating environment.

Interesting. What CPU architecture and OS are you using? That test is unnecessarily strict, so I wouldn't be surprised if a tiny difference in the way your CPU handles floats causes it to fail. We can probably just change the function slightly to get it to pass, but that's a separate issue that I wouldn't worry about right now. The important thing is that it passes on the bot.

Interesting. What CPU architecture and OS are you using?

I'm running on macOS 13.4 (22F66) with an Apple M1.

Each new file you added needs the copyright header.

Done 👍🏻

Ok, suddenly today I have access to the CI button. Not sure why it wasn't showing up earlier.

Looks like the dart format check is failing, so you'll need to reformat.
The analyis job failure is not related to your change. I'll fix it in a minute.

The rest of the PR is looking good. I've fixed the analysis failure at HEAD, so just git pull it. Once you do that, and fix the formatting issue, I'll approve.


Example 1: Transactions – dynamic period seesm wrong

Hello,
Could you review the example "Example 1: Transactions – dynamic period."
https://docs.microsoft.com/en-us/dynamics365/unified-operations/supply-chain/master-planning/reduction-keys#example-1-transactions--dynamic-period
The planned orders look like wrong there.
They should be:
January 1		500	Forecast requirements (= 1,000-500)
January 15	500	Sales orders requirements
February 1	400	Forecast requirements (= 500 – 100)
February 15	100	Sales orders requirements
Please provide more explanations if I'm wrong.
Thanks,
Vadim

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0f36dc1d-4d8e-0bb7-317e-6b3cad97b4f6
Version Independent ID: 8afbf079-6620-a200-af81-4ed147d28dbf
Content: Forecast reduction keys - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/supply-chain/master-planning/reduction-keys.md
Service: dynamics-ax-applications
GitHub Login: @roxanadiaconu
Microsoft Alias: roxanad

@vavd, thank you for noting this. We will investigate to determine if the topic needs to be updated.
@ChristianRytt, please review this feedback and consider making updates, if needed.

@vavd  You are absolutely right, there is an error in the numbers. I have updated the forecast and sales order qty to match the result in the example. So now Jan and Feb forecast are both 1,000; Jan sales 200 and Feb sales 400. Giving the original result in the example.


Use dye.dyes to generate MTG dye and wools

This PR removes the static dye and wool data from MTG's material table, and adds code to generate them from dye.dyes. This adds every variant of dye and wool into xcompat.
The code of VoxelLibre is so chaotic (missing dyes, etc) so I did not do that.
This PR is ready for review.

Has this any advancements besides removing some LoC?

Well, perhaps doing this by hardcoding every line would be a better choice.

Some are missing now… Well, perhaps doing this by hardcoding every line would be a better choice.
Some dyes are missing or? Less LoC is good imo but missing dyes isnt good.

Also, does this cause any strange behavior with dye mods?

first and foremost:
this only edits minetest game dye/wool, it does not add the new defs to the other game compats, thus it would fail the tests if run.
as for the actual implementation:
it does leave us at risk if minetest game (or a derivative) ever adds to/removes/changes/etc the dyes.dyes, this would mean that we are then lacking in cross compat
for example, what if minetest game soup number #84589023 decides to add color hotflamingpink now technically under that game xcompat.materials.dye_hotflamingpink is supported, but anywhere else that will cause a crash
take the flip side of the above example, that minetest game soup #84673265409 removes a standard color, not then we will have a crash.
much has hardcoding is bad, etc, if its hardcoded for xcompat.materials.whateverhere, you are always going to get a value back, as well as when passed to minetest.register_craft, the engine wont crash at least.

I will redo this by putting all dyes into all game's definitions manually.


[FEAT]: Add Blog page

Is your feature request related to a problem? Please describe.
It is a new feature.
Describe the solution you'd like.
To add a blog page where posts about new tech is posted.
Describe alternatives you've considered.
No response
Additional context.
No response
Show us the magic with screenshots
No response
Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

@ArchanRD please check the existing issues.
this issue was assigned also.

Ohh I am sorry. I might have missed it!


chore(license): update the license (DEV-374)

resolves DEV-374

@mpro7 we also need the start year, e.g., @ 2021 - 2022


Warthunder headset flicker with NIS and FSR

Describe the bug
flicker when using version 1.01 with war thunder.  menu shows up fine, however, when NIS or FSR are enabled flickering of image in headset...  flickering goes away when NIS or FSR are disabled.
Environment

war thunder <IP_ADDRESS>
Make and model of VR device  HP Reverb G2  V1
Version of the OpenXR runtime 110.2202.10002.0
Make and model of GPU   AMD Radeon 6900xt

To Reproduce
Steps to reproduce the behavior:

Run war thunder, uncheck easy anti cheat as Open Xr Toolkit is flagged as untrusted and will not work with  EASY ANTI CHEAT (mulitplayer disabled)
Enable option FSR or NIS,  restart app for changes to take place
horrible flickering in headset, monitor mirror of headset image  is uneffected

Expected behavior
NIS and FSR will not work with war thunder
other settings not tested ( brightness, contrast, ect)
Screenshots
My rig is setup for running lean and clean, only required apps. ( open xr toolkit required for MSFS 2020 in my opinion)
including specs just in case
windows 10 latest
x570 5800x
32gb 3600 ram
gen 4 SSD
6900xt
x56 rhino throttle and joystick, honeycomb bravo throttle quadrant,  2 logitech throttle quadrants  thrust master TPR
You have a wonderful toolkit! thank you

Thank you! I noticed that issue with flickering the day before the release, and it was too late to do anything. We're highly focused on FS2020, but I will take a look at WT when I have a chance.

Thanks for waiting patiently. I finally took the time to address this issue, and the next release (not public yet) seems to work well with War Thunder.

You legend :) a few people on the war thunder forums are gonna be happy, I just linked this post to somebody yesterday asking about it

Check your discord ;)


[prelude] Add undefined

https://developer.mozilla.org/ru/docs/Web/JavaScript/Reference/Global_Objects/undefined lol

What exactly should be in no_flowlib lib?


Simplify passing options

This PR is a proposal to allow users to pass node:child_process native options directly at the top-level instead of namespacing them in options.nativeOptions.
Using options.nativeOptions is nice as it allows us to distinguish between nano-spawn curated options, and forwards "everything else" to node:child_process spawn().
That being said, I believe allowing native options at the top level could provide with more pros than cons:

The most commonly used options are most likely going to be some of the native ones: stdout: 'inherit', timeout, signal, shell, env, cwd. Entering {nativeOptions: {timeout: 1000}} is more cumbersome than directly {timeout: 1000}.
Exposing some of the native options at the top level (like we currently do with signal and timeout), but not others, requires typing and documenting them. It also adds a few bytes (although not much). Flattening it the top level would remove that, keeping the API and types small. Hopefully, nano-spawn will not have that many options (if any? let's see), so it'd be nice to be able to keep the API very small.

Please let me know what you think.

Yeah, I agree. It's probably easier this way.


basic amplicon pipeline added

Basic amplicon pipeline added.
Does not include sample_id validation.
Does not include prep-info-file generation.
Does not include tests.

Sample ID validation + Amplicon-specific unittests added. Ready for review.


[rush] Let's document best practices for WSL + Rush

Relatively few people are using Windows Subsystem for Linux (WSL) with Rush.
In a recent Zulip thread, @Akres encountered some problems where Rush's incremental builds were not calculated correctly:

The incremental build feature works, but sometimes triggers a full rebuild while nothing has changed. That wouldn't be so bad. The flip side of the same issue is that when there is a change, the package sometimes does not rebuild, which makes it largely unusable.
I have done a bit of digging and found that the issue happens in https://github.com/microsoft/rushstack/blob/main/libraries/package-deps-hash/src/getRepoState.ts#L309 getRepoStateAsync
I did some debugging and found that the git status call quite frequently (about 50% of times, for me) returns an empty output, so the hashes, which this function returns, are that of the repo in its unmodified state.
I was pointed in this direction by https://stackoverflow.com/a/55692650 this comment. It seems that the issue really comes from two git commands running simultaneously, because when I tried to play with the code that I have locally and I serialized the calls, the issue disappeared.

Reply to this thread with any wisdom, recommendations, or workarounds for WSL+Rush.  Then we can write up a website documentation page providing guidance for best practices with WSL.

@dmichon-msft said:

I used rush on WSL for quite a while; I only stopped due to migration to GitHub codespaces
The main guidance I would give for WSL is that the only path that should resolve from /mnt is code; everything else needs to resolve from the WSL installation or you are completely undoing any benefits of WSL
i.e. your Git enlistment itself needs to not be in /mnt, etc.

The Stack Overflow article above talks about issues with inconsistent casing of filenames, which result in git status printing an empty output.

Cheers, @octogonz, thank you for the debugging session 😁
I'll just explain, for posterity, the original issue that I've encountered.
I had no special setup in my WSL and I tried to separate it from the host as much as possible (e.g. I had my code the /home, I have appendWindowsPath=false in /etc/wsl.conf, so this definitely has nothing to do with me accidentally exececuting git-for-windows from my WSL.
After some investigation, we found that nothing is mysteriously wrong with Git, but the issue is actually a race condition in https://github.com/microsoft/rushstack/blob/main/libraries/package-deps-hash/src/getRepoState.ts : spawnGitAsync
The function sets up data event handlers for stdout and stderr, but it then only awaits the exit event on the process itself. It is possible for the data and close events of the streams to arrive after the exit event (a late buffer flush, I assume). However, in that case the function will have already returned the empty string that the stdout variable is intialized to.

@akres - The WSL issue should be fixed in Rush v5.124.7

Confirmed 🙂 I've just done the same test on the same repo and it works fine now.


Use WebCrypto for PGP operations

On desktop, PGP operations are acceptably fast in the current implementation, which uses the e2e library's implementation of elliptic-curve PGP.  On Android, especially low-end Android devices, PGP operations are incredibly slow, rendering uProxy unusable.  We could potentially solve this by using WebCrypto's native-code-backed crypto APIs instead.  Currently, e2e only supports RSA for WebCrypto, but for compatibility (and performance) we need to use EC.
We should add WebCrypto+EC support to e2e, and then use it for all our PGP needs.  The e2e team would welcome this idea, and has done sufficient refactoring that it should be straightforward ... maybe as easy as adding a e2e.asymmetric.keygenerator.newWebCryptoEcdsaWithP256 function, parallel to the existing one for RSA.

@bemasc you fixed this, right?

Yep, fixed by https://github.com/google/end-to-end/commit/79449442571462cf08adb32c36a8583645c34c04 and https://github.com/freedomjs/freedom-pgp-e2e/pull/54


Improve the test coverage of Atlas Proxy

Atlas proxy was developed with a very limited test data (default test data that comes with the Atlas), which is not realistic at all, hence misses a lot of scenarios on the production environment.
We need to improve the fixtures, to make it more realistic and closer to the what we have on production, and try to cover many of the edge cases while working on that.

Improved the code coverage and individual functions in Atlas Proxy!


Update cats-effect to 2.5.4

Updates org.typelevel:cats-effect from 2.2.0 to 2.5.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Applied Scalafix Migrations

org.typelevel:{cats-effect,cats-effect-laws}:2.4.0 (created no change)

github:typelevel/cats-effect/v2_4_0?sha=v2.4.0
Documentation: https://github.com/typelevel/cats-effect/blob/v2.4.0/scalafix/README.md

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "cats-effect" } ]

labels: library-update, early-semver-minor, semver-spec-minor, scalafix-migrations, commit-count:1

@Mergifyio refresh