negative coordinates

As far as I understand, the game does not support directly setting negative values.
Apart from coordinates, where I can add negative coordinates in game (in the add instruction).
Something like this does not compile:
let position = getLocation(self);
let new_pos = position + coord(-2, 0);

It is possible to work around this by using:
let position = getLocation(self);
let new_pos = position - coord(2, 0);

In terms of coordinates, I personally find this unintuitive (and therefore error-prone to use).
I don't know if fixing it is worthwhile, though. I just want to hint at this and think it may be a good idea to include it in documentation/examples.

Being able to use negative numbers (both for coordinates, and plain number types) is something I plan to PR.
Unrelated to desynced-tools, but based on what beathwho (developer of desynced) has said on discord the game might also allow setting negative values at some point via its UI.

This is now supported.


Removal of extra class 'IRequestHandler'

not in use/wrong namespace/no matching signature implementation
looks like it was added accidentally as part of an earlier commit

That might have been me smashing the keyboard/ReSharper shortcuts. :shipit:


use SystemExit instead os sys.exit

[X] Closes #658
[ ] Tests added
[ ] Fully documented, including history.rst for all changes and api/*.rst for new API

There are no tests for setup.py as far as I can tell I also think this does not need documentation.
This change should be "seamless" for pyproj but it will allow package parsers to inspect this by catching the BaseException instead of exiting.
Ping @marcelotrevisani who had issues in grayskull when parsing this package.

@snowman2 note that a bare exception or BaseException would catch the sys.exit but this will allow for more elegant code upstream where we can catch SystemExit and handle exits differently from other failures.
TL;DR this is not essential to pyproj and feel free to close it if you think it is not important here.

Looks like it works fine - I think this is a good change:
$ python -m pip install -e .
Obtaining file:///home/snowal/scripts/pyproj
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  ERROR: Command errored out with exit status 1:
   command: /home/snowal/miniconda/bin/python /home/snowal/.local/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpahd2zjhh
       cwd: /home/snowal/scripts/pyproj
  Complete output (1 lines):
  ERROR: Minimum supported proj version is 7.1.0, installed version is 4.9.3. For more information see: https://pyproj4.github.io/pyproj/stable/installation.html
  ----------------------------------------
ERROR: Command errored out with exit status 1: /home/snowal/miniconda/bin/python /home/snowal/.local/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpahd2zjhh Check the logs for full command output.

@ocefpaf do you want to squash your commits? Or do you mind if I do a squash-and-merge?

@ocefpaf do you want to squash your commits? Or do you mind if I do a squash-and-merge?

Done.

Thanks!

Thanks @ocefpaf!


NodeVerificationManager does not actually verify

Control's NodeVerificationManager is set to auto-verify. We need a way to validate the auth for the nodes.

I'm going to remove this. I think once we have auth we'll have a better way.


Reach out request, re distro support

My apologies if this is not an appreciated way of reaching out, I was unable to find a better alternative.
I have interest in packaging the proprietary Linux Radeon drivers for NixOS. The key difference between NixOS and the officially supported distros is that Nix doesn't play well with other tools trying to manage what is installed on the system. The benefit I'm hoping to bring to NixOS is primarily in the game-specific optimizations that don't get released in this project.
What I would like is if I could get in contact with someone at AMD who could help me navigate how to bridge the gap here. Hopefully, they could point me to where the assets I would need to fetch for Nix would be, though ideally they could provide information that would make it easier to maintain the wrapper.
If not through replies to this issue, I can be reached through the email on my profile.

I am not the ideal contact, but will try and start the ball rolling here.
If possible, can you expand on which assets and information you need?
I don't have any experience with NixOS, so apologies in advance if my questions/comments miss the mark.
Are you asking about installing/repackaging existing binaries created for other distributions?
Or, building new packages from public sources?
Normally for binary distribution the user downloads a package file, like this one (for Ubuntu):
https://repo.radeon.com/amdgpu-install/23.40.2/ubuntu/focal/amdgpu-install_6.0.60002-1_all.deb
This installs a bash script called amdgpu-install, which when invoked adds package sources for kernel mode drivers (KMD) via DKMS, user mode drivers for APIs OpenGL, OpenCL, Vulkan, and X11/Xorg/Wayland drivers.  More recently this can also add ROCm sources if required.
On Ubuntu the script then invokes apt to install combinations of packages based on the support the user requested.
You might want to review what amdgpu-install does if your intention is to port the existing binary packages.
Binary repackaging has been done by a few distributions, for example Gentoo.
Some useful information may be present in the relevant ebuilds:
https://gitweb.gentoo.org/repo/gentoo.git/tree/media-libs/amdgpu-pro-vulkan
Or GURU binary build:
https://gitweb.gentoo.org/repo/proj/guru.git/tree/media-libs/amdvlk-bin
If you want to go the source route then Gentoo's GURU source build might also be a good starting point:
https://gitweb.gentoo.org/repo/proj/guru.git/tree/media-libs/amdvlk
As an aside, it might be worth changing the title of this issue to "NixOS support" (or similar), if that is your goal.


[Pass][Bugfix] StorageFlatten, buffer var definitions in LetStmt

Previously, any buffers whose buffer var was defined in a Let or LetStmt would result in an error when running StorageFlatten, stating that the buffer var was undefined.  These are used for allocations in external calls, such as those produced by LowerVtcmAlloc.

Rebased onto main to restart CI, had stalled out in tvm-ci/pr-merge step.


filter list of genes associated with a disease by drug attributes (moa, type,trial phase)

Issue closed as it is a duplicate of issue 51


[Feature] ACL 远程地址配置 支持域名

Is Your Feature Request Related to a Problem?
希望在acl 配置文件中，如下参数whiteRemoteAddress, globalWhiteRemoteAddresses ，支持hosts域名的配置。
globalWhiteRemoteAddresses
- <IP_ADDRESS>
- 192.168.3.*
Describe the Solution You'd Like
cat /etc/hosts
<IP_ADDRESS> domain1
<IP_ADDRESS> domain2
<IP_ADDRESS> domain3
希望达到如下效果
globalWhiteRemoteAddresses
- domain1
- domain2
- domain3
目前这样配置的话，会有AclException
public OneRemoteAddressStrategy(String netaddress) {
            this.netaddress = netaddress;
            InetAddressValidator validator = InetAddressValidator.getInstance();
            if (!(validator.isValidInet4Address(netaddress) || validator.isValidInet6Address(netaddress))) {
                throw new AclException(String.format("**Netaddress examine Exception netaddress** is %s", netaddress));
            }
        }

Describe Alternatives You've Considered
方便配置。
Additional Context
No response

网络传输协议层决定了服务端只能拿到对端ip，该issue在技术上是无法实现的。
The network transport protocol layer determines that the server can only obtain the IP address of the network endpoint. This issue is technically unattainable.

并且并不推荐生产上使用whiteRemoteAddress，globalWhiteRemoteAddresses，目前版本的白名单会跳过鉴权，会存在安全风险。
后续会考虑废除该字段，改为同时需要满足在白名单之内且满足鉴权要求。
Moreover, it is not advisable to use "whiteRemoteAddress" and "globalWhiteRemoteAddresses" in production. The current version of the whitelist bypasses authentication, posing a security risk. In the future, we will consider deprecating this field and instead require compliance with both the whitelist and authentication criteria.

ok明白了，谢谢你


Enum improvements

This hotfix will fix any reported minor issues with RPC enum classes.

[ ] Fix #79
[ ] Fix #91
[X] Fix #102
[ ] Fix #119

When this PR is merged, make sure to note #92 added valueOf() where it didn't exist before.  Ensure VrCapabilities enum is updated with this change once #92 is merged as part of #113.

Trivial change is being marked for 3-day offline review. Anticipated merge date is 2/23 at 3pm.

Here are the results of the current unit tests for this PR.

Tests Run
Test Passes (%)
Test Failures (%)
Test Errors (%)

1486
1476 (99%)
9 (<1%)
1 (<1%)

Of the 10 failed tests, 9 are related to #71, and 1 is related to #89.  Both of these issues are slated to be merged by version 3.3.0, so all unit tests should be passed by March 1 or earlier.


arcade physic collide/overlap sprite or group vs tilemaplayer does not use overlapOnly

See https://github.com/photonstorm/phaser/blob/master/src/physics/arcade/World.js#L638
The comments, which include overlapOnly, indicate that this is an oversight rather than by design. Should be easy enough to fix! :)

@photonstorm Hi Richard! Well, I think TilemapLayer be supported by overlap would be a great advance for most users.
If you don't mind, I want to work on this in the 2.x.x branch. Is there space for this feature on the next release roadmap?

@raphaklaus I'm sure they would be very happy to receive the feature in the Phaser CE repo!


Does not seem to work ...

Hi and thanks for your extension!
Somehow it does not seem to work. I got a Chrome UX Report API key, installed the extension and added the key. Then nothing happens on my SERP.
I have checked the key and GCP says its fine and active. I checked the options of your extension and out of the box, there is seems nothing that I would need to "active" somehow.
Finally I restarted Chrome and checked again. Nothing is happening.
Is it mandatory to be logged into my G-Account on Chrome? That's the only thing I haven't checked because I don't trust Chrome with any kind of my surf data.
Greetings,
Chris

Have you tried searching for a generic term like 'test'? It could be that for your search queries there are no results available in the CrUX report.


Tag descriptions rendered as tags

Given a Swagger spec with:
"tags": [
    {
        "name": "foo",
        "description": "Foo"
    },
    {
        "name": "bar",
        "description": "Bar"
    }
]

The generated asciidoc has this redundant list of tags:
=== Tags

* foo: Foo
* foo
* bar: Bar
* bar

Thx

Fixed in v0.8.0

Can I close the issue?

Works for me now, thanks!


init: dragmap 1.3.0 (resubmit)

This is a resubmission of #307720 due to a massive ping.
Genomic mapper. Open-source version of DRAGEN.
Tests are run during execution with google-tests.
Description of changes
Bioinformatics tools for genomics : align data according to a reference genome. Open-source version of proprietary software (DRAGEN).
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage -
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

~The package builds fine on its own but fails with nix-pkgs review~ -> This has been fixed.
Thanks,
Add a :+1: reaction to pull requests you find important.

Note: the new version pass nix-pkgs review.

@drupol Could you check out my answers to your questions and see if it answers them ? Thanks

@drupol If you have some time to look at this PR, it would be great, thanks !

Moving this to draft until everything is fixed.

Okay, I hope you are seeing the previous comments now ! PR title, commit have been reformatted and the additional commit have been removed.


update Readme

Codecov Report

Merging #2 into master will decrease coverage by 1.09%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master       #2     +/-   ##
=========================================
- Coverage    70.9%   69.81%   -1.1%
=========================================
  Files           3        3
  Lines          55       53      -2
  Branches       10        6      -4
=========================================
- Hits           39       37      -2
  Misses         16       16

Impacted Files
Coverage Δ

src/main/scala/flashtext/Main.scala
0% <0%> (ø)
:arrow_up:

src/main/scala/flashtext/KeywordProcessor.scala
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99cf23b...c6284b7. Read the comment docs.


Restructuring modules into respective subfolders

One folder per module would allow us to include the following 3 files for each functionality:

The source code
The default configuration JSON for the module.
The documentation reference

Closed by Pull Request #39


Fast, secure and less annoying

While thinking about #558 I stumbled over the "Fast and secure business network" motto.
Thoughts

It's not just a "business network". It is a generic social network.
Three adjectives always sound nicer.
It doesn't hurt to put a smile on somebodies face.

Motto
So I'm thinking about calling it Fast, secure and less annoying or The Fast, Secure and Less Annoying Social Network
But I'm not a native speaker. @riverrun: How does it sound for you?
It would translate nicely into German too which is a nice aspect.
How does everybody think about it?

Second though: Maybe just "Fast and less annoying" and "The fast and less annoying social network"
I don't know how important the word "secure" is in this context.

My initial thoughts are that "fast, secure and less annyoing" and "the fast and less annoying social network" both sound good.
It would be interesting to hear why you see it as a social network, rather than just a business network, and in what way it will be less annoying.

It would be interesting to hear why you see it as a social network, rather than just a business network, and in what way it will be less annoying.

IMO business network is a limitation. Of course it is a business network but not just that. With the new posting feature it will become a bit more Twitter/Facebook/Medium like. I'm not totally against "business network". I just want to discuss if "social network" might be the better term.
But there is no harm to change it form "business" to "social" later.

"fast, secure and less annoying" it is.


Missing UIRaycastCamera error

Describe the bug
Removed and recreated the Unity library folder and the app started spewing errors. I don't think anything else changed. Clearing the cache, removing and readding MRTK, made no difference.
Trying to trace this to the source without much success. A new project doesn't have the issue, but a new scene in the existing project with all default Toolkit settings does.
In FocusProvider.cs the Initialize method never gets called and so the Raycast camera never gets set up:
`#region IMixedRealityService Implementation
    /// <inheritdoc />
    public override void Initialize()
    {
        if (!IsSetupValid) { return; }

        base.Initialize();

        if (Application.isPlaying)
        {
            Debug.Assert(uiRaycastCamera == null);
            FindOrCreateUiRaycastCamera();
        }`

Oddly, while it never gets called on startup, it does get called when the application is stopped. The first method, get called but never reaches the FocusProvider initialize, but the second method does when the app is shutting down:
private bool ExecuteOnAllServicesInOrder(Action<IMixedRealityService> execute)

private bool ExecuteOnAllServicesReverseOrder(Action<IMixedRealityService> execute)

And, as a terrible hack, I can force it to initialize by editing the MixedRealityToolkit.cs  by adding to the execute(services[i]), getting the focus provider service and calling Initialize on it. But I have no idea how this happened or how to fix it.
`private bool ExecuteOnAllServicesInOrder(Action<IMixedRealityService> execute)
    {
        using (ExecuteOnAllServicesInOrderPerfMarker.Auto())
        {
            if (!HasProfileAndIsInitialized)
            {
                return false;
            }

            var services = MixedRealityServiceRegistry.GetAllServices();
            int length = services.Count;
            for (int i = 0; i < length; i++)
            {
                execute(services[i]);

                if (i == 1)
                {
                    var focusProviderService = services[1] as IMixedRealityFocusProvider;
                    if (focusProviderService.UIRaycastCamera == null)
                    {
                        focusProviderService.Initialize();
                    }
                }
            }

            return true;
        }
    }`

A clear and concise description of what the bug is.
Missing UIRaycastCamera!
UnityEngine.Debug:Assert (bool,string)
Microsoft.MixedReality.Toolkit.Input.FocusProvider:RaycastGraphics (Microsoft.MixedReality.Toolkit.Input.IMixedRealityPointer,UnityEngine.EventSystems.PointerEventData,UnityEngine.LayerMask[],Microsoft.MixedReality.Toolkit.Input.FocusProvider/PointerHitResult) (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Services/InputSystem/FocusProvider.cs:1363)
Microsoft.MixedReality.Toolkit.Input.FocusProvider:UpdatePointer (Microsoft.MixedReality.Toolkit.Input.FocusProvider/PointerData) (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Services/InputSystem/FocusProvider.cs:1070)
Microsoft.MixedReality.Toolkit.Input.FocusProvider:UpdatePointers () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Services/InputSystem/FocusProvider.cs:974)
Microsoft.MixedReality.Toolkit.Input.FocusProvider:Update () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Services/InputSystem/FocusProvider.cs:554)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit/<>c:b__72_0 (Microsoft.MixedReality.Toolkit.IMixedRealityService) (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Core/Services/MixedRealityToolkit.cs:1054)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit:ExecuteOnAllServicesInOrder (System.Action`1<Microsoft.MixedReality.Toolkit.IMixedRealityService>) (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Core/Services/MixedRealityToolkit.cs:1145)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit:UpdateAllServices () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Core/Services/MixedRealityToolkit.cs:1054)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit:Update () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Core/Services/MixedRealityToolkit.cs:727)
NullReferenceException: Object reference not set to an instance of an object
Microsoft.MixedReality.Toolkit.Input.FocusProvider.RaycastGraphics (Microsoft.MixedReality.Toolkit.Input.IMixedRealityPointer pointer, UnityEngine.EventSystems.PointerEventData graphicEventData, UnityEngine.LayerMask[] prioritizedLayerMasks, Microsoft.MixedReality.Toolkit.Input.FocusProvider+PointerHitResult hit) (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Services/InputSystem/FocusProvider.cs:1364)
Microsoft.MixedReality.Toolkit.Input.FocusProvider.UpdatePointer (Microsoft.MixedReality.Toolkit.Input.FocusProvider+PointerData pointerData) (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Services/InputSystem/FocusProvider.cs:1070)
Microsoft.MixedReality.Toolkit.Input.FocusProvider.UpdatePointers () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Services/InputSystem/FocusProvider.cs:974)
Microsoft.MixedReality.Toolkit.Input.FocusProvider.Update () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Services/InputSystem/FocusProvider.cs:554)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit+<>c.b__72_0 (Microsoft.MixedReality.Toolkit.IMixedRealityService service) (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Core/Services/MixedRealityToolkit.cs:1054)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.ExecuteOnAllServicesInOrder (System.Action`1[T] execute) (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Core/Services/MixedRealityToolkit.cs:1145)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.UpdateAllServices () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Core/Services/MixedRealityToolkit.cs:1054)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.Update () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Core/Services/MixedRealityToolkit.cs:727)
NullReferenceException: Object reference not set to an instance of an object
Microsoft.MixedReality.Toolkit.Input.MixedRealityInputModule.UpdateMousePointerEventData (Microsoft.MixedReality.Toolkit.Input.MixedRealityInputModule+PointerData pointerData) (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Services/InputSystem/MixedRealityInputModule.cs:252)
Microsoft.MixedReality.Toolkit.Input.MixedRealityInputModule.GetMousePointerEventData (System.Int32 pointerId) (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Services/InputSystem/MixedRealityInputModule.cs:222)
UnityEngine.EventSystems.StandaloneInputModule.ProcessMouseEvent (System.Int32 id) (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/EventSystem/InputModules/StandaloneInputModule.cs:540)
Microsoft.MixedReality.Toolkit.Input.MixedRealityInputModule.Process () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@3bad99c89252/Services/InputSystem/MixedRealityInputModule.cs:161)
UnityEngine.EventSystems.EventSystem.Update () (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/EventSystem/EventSystem.cs:501)
Your setup (please complete the following information)
Unity 2021.3.21f1
MRTK 2.7.3

Unity Version [e.g. 2018.3.11f1]
MRTK Version [e.g. v2.0]

Target platform (please complete the following information)
Happens on Windows and UWP

I've got the same problem, it all works fine in a new project , anyone had the solution of it yet?

Same problem here on 2.8.2

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


Try .gz if .xz does not exist

I just found out there's no node-v5.1.0-linux-x64.tar.xz and node-v5.1.0-linux-x86.tar.xz file on Node.js server.
Because of that, I couldn't install Node.js v5.1.0 from binary since I have xz installed.
# nvm install 5.1.0
Downloading https://nodejs.org/dist/v5.1.0/node-v5.1.0-linux-x64.tar.xz...
######################################################################## 100.0%
WARNING: checksums are currently disabled for node.js v4.0 and later
xz: (stdin): File format not recognized
tar: Child returned status 1
tar: Error is not recoverable: exiting now
Binary download failed, trying source.

It might be Node.js team's mistake, but I think it would be great if nvm tries .gz file if .xz file does not exist on the server.

I think that is a very good idea, since it turns out not every .gz has a corresponding .xz (cc @jbergstroem).

This is a mistake. They should always exist. I'll have a look at what went wrong.

@jbergstroem even for FreeBSD?

Here's the reason: https://github.com/nodejs/build/issues/258

@ljharb regarding FreeBSD -- we don't release binaries for it.

Thanks! @Snack-X, looks like this is resolved for now.


General Code Improvements

These should be pretty uncontroversial code improvements, but let me know if otherwise. Most of these improvements were automatically done through intellij with me reviewing the changes.

Fixup mockito deprecations
Rest of Guava's propagate replaced
Remove unneeded throws declaration
Simplify stream calls to collection foreach
Remove caught and rethrown exception
Replace anonymous types with lambdas
Replace isPresent check with ifPresent function
Replace asList with singleton list with one element
Use diamond operator
Prefer contains to indexOf() != -1
Directly sort list instead of Collections.sort

Feel free to squash this into a single commit

Coverage increased (+0.004%) to 81.721% when pulling ad5a1e941d178edbf395889d2431fb6556093e44 on nickbabcock:code-improvements into aad71bd6e0406d1dda1bfb6a007a420ab5242b9e on dropwizard:master.

Today I learned that Jersey doesn't accept lambda ExceptionMappers 😞 (that's why travis failed earlier, for the curious few)


Select Popover not positioning correctly

Start WebKit Browser (seems to affect only safari on my mac, not Firefox or Vivaldi/Chromium).
Clone my minimal reproducible example repo (Sorry about the bright colours, my intention is to help differentiate)
Start Quik
Click dropdown button
Observe that the popover is out of place.

Not sure what interaction is causing this, but the popover element is not positioned under the trigger, instead to the left of it.
This was noticed by me when I tried to create this in Tauri on my MacBook as it uses webkit on MacOS.
I'm around if more info is needed.
Observed Behaviour:

Popover is far left in WebKit browsers

Expected Behaviour:

Popover is beneath element on all browsers

Thank you!

Interesting, @apolo49 it looks like there is margin on the webkit browser

I don't have a mac to really test this 😅 any ideas on how to check this on windows haha

Not sure for Windows (there is Otter Browser, but that's an outdated version of WebKit), but on a Linux machine there are several WebKit browsers; otherwise you can also use Playwright with a WebKit minibrowser, but not sure that would reproduce the effect (I do suspect it would though).

Any news on this @thejackshelton? I don't know how to fix this myself, if you can guide me where to look I may be able to be some help!

Hey @apolo49! @cwoolum and I are going to pair at 3 PM PST and try to improve the popover, hopefully having enough time for this issue.
We'll be in the pairing session in the qwikifiers discord if you'd like to join us 😄.


No colors in Run-TestsInNavContainer

When I call Run-TestsInNavContainer from VSCode terminal, the result have no colors (is just white). I am expecting that they are lost when transferring the result from the container. Is it solvable? Screenshot:

That is because you are not running as admin. That means that I have to launch the function in the container using docker exec - which means that the colors disappear
Få Outlook til iOShttps://aka.ms/o0ukef

Fra: Kamil Sacek<EMAIL_ADDRESS>Sendt: Wednesday, February 27, 2019 6:13:35 AM
Til: Microsoft/navcontainerhelper
Cc: Subscribed
Emne: [Microsoft/navcontainerhelper] No colors in Run-TestsInNavContainer (#364)
When I call Run-TestsInNavContainer from VSCode terminal, the result have no colors (is just white). I am expecting that they are lost when transferring the result from the container. Is it solvable? Screenshot:
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F110221%2F53496375-3d5b0900-3aa2-11e9-99c0-163b57508338.png&data=02|01|freddy.kristiansen%40microsoft.com|f3aae371bb3446d121a808d69cbdc39c|72f988bf86f141af91ab2d7cd011db47|1|0|636868736178139644&sdata=%2F9%2FyKPsf%2Ba8Ets3VvuEr016Cw%2FqgbDPclIJ9A%2BP9Cyw%3D&reserved=0
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fnavcontainerhelper%2Fissues%2F364&data=02|01|freddy.kristiansen%40microsoft.com|f3aae371bb3446d121a808d69cbdc39c|72f988bf86f141af91ab2d7cd011db47|1|0|636868736178139644&sdata=G8GD1uH7%2FKxis%2FY0QaNI3vAYK4YOpx%2FwDiKdNfbLqk0%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKRqAxjpnfbHFZBB3PB4uToII396t0l9ks5vRpKPgaJpZM4bUn07&data=02|01|freddy.kristiansen%40microsoft.com|f3aae371bb3446d121a808d69cbdc39c|72f988bf86f141af91ab2d7cd011db47|1|0|636868736178149632&sdata=EUaxfeqiSkmlm7gE2GNrd5W%2BQxgHf8HtqSvKUON9kPE%3D&reserved=0.


[nri-infrastructure] Reduce DNS load on the K8 clusters

Is your feature request related to a problem? Please describe.
On my EKS cluster I see newrelic to be the n#1 DNS request issuer. By default when doing a DNS query on "infra-api.newrelic.com", coreDNS will try to resolve it in different context :

infra-api.newrelic.com.eu-west-1.compute.internal.
infra-api.newrelic.com.cluster.local
infra-api.newrelic.com.svc.cluster.local.
infra-api.newrelic.com.newrelic.svc.cluster.local.

Finally it's able to understand that the pod is not asking for a local address but for api.newrelic.com public one. So each time a pod is doing a DNS query to newrelic, it goes through 5 errors in the DNS resolution before finding the good one.
Since newrelic is using multiple endpoints (intra, indentity, metric), multiplied by the number of hosts and the frequency of theses requests, you end up with hundread thousands of DNS request per day for nothing.
Describe the solution you'd like
One solution could be to use only fully qualified domain name (FQDN) like infra-api.newrelic.com. (mind the tailing dot), or add an option to override the default newrelic endpoint.
Describe alternatives you've considered
Another option would be to allow us setting the NDOT setting of the deamonset :

dnsConfig:
    options:
      - name: ndots
        value: '1'

ndots sets a threshold for the number of dots which must appear in a name before an initial absolute query will be made. The default for n is 1, meaning that if there are any dots in a name, the name will be tried first as an absolute name before any search list elements are appended to it.

Additional context
A good article about FQDN kube and DNS : https://pracucci.com/kubernetes-dns-resolution-ndots-options-and-why-it-may-affect-application-performances.html

Hi!
We're still working on figuring the possible impact of changing the defaults for the infra-agent so they include the trailing dot.
In the meantime, as a workaround, these endpoints can actually be overridden by the user. Please take a look here, where you can see the default value and the name of the yaml property that is mapped to it. The place to specify these keys would be under the config entry of the newrelic-infrastructure chart.

Hi @roobre , sounds like a good workaround indeed. Thanks.

The common library implements dnsConfig but we still have to adapt all the helm charts to use it. Github autoclosed this but this is still an issue.

This should be fixed with the latest version of the charts that implement the common-library chart:

Global keys
Local keys
Default
Merged1
Description

global.dnsConfig
dnsConfig
{}

Sets pod's dnsConfig

Hi @kang-makes , could it be that the newrelic-logging subchart is the only chart where the global.dnsConfig value is not applied?
I used the following values.yaml:
global:
  customSecretName: newrelic-license-key
  customSecretLicenseKey: license_key
  dnsConfig:
    options:
      - name: ndots
        value: '1'
  cluster: "test"
pixie-chart:
  enabled: false

kube-state-metrics:
  # kube-state-metrics.enabled -- Install the [`kube-state-metrics` chart](https://github.com/kubernetes/kube-state-metrics/tree/master/charts/kube-state-metrics) from the stable helm charts repository.
  # This is mandatory if `infrastructure.enabled` is set to `true` and the user does not provide its own instance of KSM version >=1.8 and <=2.0
  enabled: true

newrelic-infrastructure:
  enable: true

newrelic-logging:
  enabled: true
  fluentBit:
    logLevel: "info"
    path: "/var/log/containers/*.log"

When I render the pulled nri-bundle table locally with helm template like this: helm template -f newrelic-bundle/values.yaml nri-bundle --debug I see that all deployments/daemosets set the spec dnsConfigkey. For example, see the kublet daemonset deployment below:
# Source: nri-bundle/charts/newrelic-infrastructure/templates/kubelet/daemonset.yaml
apiVersion: apps/v1
kind: DaemonSet
metadata:
  namespace: newrelic
  labels:
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: newrelic-infrastructure
    app.kubernetes.io/version: 3.15.1
    helm.sh/chart: newrelic-infrastructure-3.20.1
    mode: privileged
  name: release-name-nrk8s-kubelet
spec:
  updateStrategy:
    rollingUpdate:
      maxUnavailable: 1
    type: RollingUpdate
  selector:
    matchLabels:
      app.kubernetes.io/instance: release-name
      app.kubernetes.io/name: newrelic-infrastructure
      app.kubernetes.io/component: kubelet
  template:
    metadata:
      annotations:.
      ...
      labels:
        ...
        app.kubernetes.io/component: kubelet
    spec:
      dnsConfig:
        options:
        - name: ndots
          value: "1"
      serviceAccountName: release-name-newrelic-infrastructure
      hostNetwork: false
      containers:
        - name: kubelet

But the newrelic-logging deployment (fluent-bit output pod) will not get the dnsConfig from global key as you can see here:
# Source: nri-bundle/charts/newrelic-logging/templates/daemonset.yaml
apiVersion: apps/v1
kind: DaemonSet
metadata:
  namespace: newrelic
  labels:
    app: newrelic-logging
    chart: newrelic-logging-1.14.2
    heritage: Helm
    release: release-name
    app.kubernetes.io/name: newrelic-logging
  name: release-name-newrelic-logging
  annotations:
spec:
  updateStrategy:
    type: RollingUpdate
  selector:
    matchLabels:
      app: newrelic-logging
      release: release-name
  template:
    metadata:
      annotations:
       ...
      labels:
        ...
    spec:
      serviceAccountName: release-name-newrelic-logging
      hostNetwork: true # This option is a requirement for the Infrastructure Agent to report the proper hostname in New Relic.
      dnsPolicy: ClusterFirstWithHostNet
      terminationGracePeriodSeconds: 10
      containers:
        - name: newrelic-logging
          image: "newrelic/newrelic-fluentbit-output:1.16.0"
          imagePullPolicy: "IfNotPresent"
          env:
            - name: ENDPOINT
              value: "https://log-api.newrelic.com/log/v1"
            - name: SOURCE
              value:  "kubernetes"
            - name: LICENSE_KEY
              valueFrom:
                secretKeyRef:
                  name: newrelic-license-key
                  key: license_key
            - name: CLUSTER_NAME
              value: test
            - name: LOG_LEVEL
              value: "info"
            - name: LOG_PARSER
              value: "docker"
            - name: FB_DB
              value: "/var/log/flb_kube.db"
            - name: PATH
              value: "/var/log/containers/*.log"
            - name: K8S_BUFFER_SIZE
              value: "32k"
            - name: K8S_LOGGING_EXCLUDE
              value: "Off"
            - name: LOW_DATA_MODE
              value: "false"
            - name: RETRY_LIMIT
              value: "5"
            - name: HOSTNAME
              valueFrom:
                fieldRef:
                  fieldPath: metadata.name

          command:
            - /fluent-bit/bin/fluent-bit
            - -c
            - /fluent-bit/etc/fluent-bit.conf
            - -e
            - /fluent-bit/bin/out_newrelic.so
          volumeMounts:
            - name: fluent-bit-config
              mountPath: /fluent-bit/etc
            - name: var
              mountPath: /var
          resources:
            limits:
              cpu: 700m
              memory: 512Mi
            requests:
              cpu: 250m
              memory: 64Mi
      volumes:
        - name: fluent-bit-config
          configMap:
            name: release-name-newrelic-logging-fluent-bit-config
        - name: var
          hostPath:
            path: /var
      nodeSelector:
      tolerations:
        - effect: NoSchedule
          operator: Exists
        - effect: NoExecute
          operator: Exists
        - effect: NoSchedule
          key: CriticalAddonsOnly
          operator: Equal
          value: "true"

So my question is why does this deployment not get the dnsConfig? Maybe something was overlooked when adding this feature? Or is the fluentbit image being used incompatible with this dnsConfig?
I want to set this ntdot value as the newrelic logging pod on my AKS cluster is facing DNS issues like below:
newrelic-logging [2023/07/26 11:18:40] [ warn] [net] getaddrinfo(host='kubernetes.default.svc.cluster.local', err=-3): Temporary failure in name resolution newrelic-bundle-nrb-newrelic-logging-gd7wl newrelic-logging [error] [filter:kubernetes:kubernetes.0] kubelet upstream connection error
My hope is that setting ndot = 1 will reduce the amount of DNS requests so that timeouts do not occur again.
Thanks in advance for your help/replies
Regards


Elasticsearch pods fail to startup

Chart Version
7.3.0
Kubernetes Version
1.13
Kubernetes provider
AWS (EKS cluster)
Helm Version
2.11.0
Everytime I run helm install --name elasticsearch elastic/elasticsearch --namespace elasticsearch --set resources.requests.memory=1.5Gi --set resources.limits.memory=1.5Gi --tiller-namespace spinnaker it appears to be deploying the master pods but they don't start.
NAME:   elasticsearch
LAST DEPLOYED: Wed Sep 11 17:49:30 2019
NAMESPACE: elasticsearch
STATUS: DEPLOYED

RESOURCES:
==> v1/Pod(related)
NAME                    READY  STATUS       RESTARTS  AGE
elasticsearch-master-0  0/1    Init:0/1     0         1s
elasticsearch-master-1  0/1    Terminating  0         5m46s
elasticsearch-master-2  0/1    Terminating  4         5m46s

==> v1/Service
NAME                           TYPE       CLUSTER-IP    EXTERNAL-IP  PORT(S)            AGE
elasticsearch-master           ClusterIP  <IP_ADDRESS>  <none>       9200/TCP,9300/TCP  1s
elasticsearch-master-headless  ClusterIP  None          <none>       9200/TCP,9300/TCP  1s

==> v1beta1/PodDisruptionBudget
NAME                      MIN AVAILABLE  MAX UNAVAILABLE  ALLOWED DISRUPTIONS  AGE
elasticsearch-master-pdb  N/A            1                0                    1s

==> v1beta1/StatefulSet
NAME                  READY  AGE
elasticsearch-master  0/3    1s

NOTES:
1. Watch all cluster members come up.
  $ kubectl get pods --namespace=elasticsearch -l app=elasticsearch-master -w
2. Test cluster health using Helm test.
  $ helm test elasticsearch

Here is the output of running helm get elasticsearch --tiller-namespace spinnaker
REVISION: 1
RELEASED: Wed Sep 11 17:49:30 2019
CHART: elasticsearch-7.3.0
USER-SUPPLIED VALUES:
resources:
  limits:
    memory: 1.5Gi
  requests:
    memory: 1.5Gi

COMPUTED VALUES:
antiAffinity: hard
antiAffinityTopologyKey: kubernetes.io/hostname
clusterHealthCheckParams: wait_for_status=green&timeout=1s
clusterName: elasticsearch
esConfig: {}
esJavaOpts: -Xmx1g -Xms1g
esMajorVersion: ""
extraEnvs: []
extraInitContainers: []
extraVolumeMounts: []
extraVolumes: []
fsGroup: ""
fullnameOverride: ""
httpPort: 9200
image: docker.elastic.co/elasticsearch/elasticsearch
imagePullPolicy: IfNotPresent
imagePullSecrets: []
imageTag: 7.3.0
ingress:
  annotations: {}
  enabled: false
  hosts:
  - chart-example.local
  path: /
  tls: []
initResources: {}
labels: {}
lifecycle: {}
masterService: ""
masterTerminationFix: false
maxUnavailable: 1
minimumMasterNodes: 2
nameOverride: ""
networkHost: <IP_ADDRESS>
nodeAffinity: {}
nodeGroup: master
nodeSelector: {}
persistence:
  annotations: {}
  enabled: true
podAnnotations: {}
podManagementPolicy: Parallel
podSecurityContext:
  fsGroup: 1000
priorityClassName: ""
protocol: http
readinessProbe:
  failureThreshold: 3
  initialDelaySeconds: 10
  periodSeconds: 10
  successThreshold: 3
  timeoutSeconds: 5
replicas: 3
resources:
  limits:
    cpu: 1000m
    memory: 1.5Gi
  requests:
    cpu: 100m
    memory: 1.5Gi
roles:
  data: "true"
  ingest: "true"
  master: "true"
schedulerName: ""
secretMounts: []
securityContext:
  capabilities:
    drop:
    - ALL
  runAsNonRoot: true
  runAsUser: 1000
service:
  annotations: {}
  nodePort: null
  type: ClusterIP
sidecarResources: {}
sysctlInitContainer:
  enabled: true
sysctlVmMaxMapCount: 262144
terminationGracePeriod: 120
tolerations: []
transportPort: 9300
updateStrategy: RollingUpdate
volumeClaimTemplate:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 30Gi

HOOKS:
---
# elasticsearch-sjzcy-test
apiVersion: v1
kind: Pod
metadata:
  name: "elasticsearch-sjzcy-test"
  annotations:
    "helm.sh/hook": test-success
spec:
  containers:
  - name: "elasticsearch-sphns-test"
    image: "docker.elastic.co/elasticsearch/elasticsearch:7.3.0"
    command:
      - "sh"
      - "-c"
      - |
        #!/usr/bin/env bash -e
        curl -XGET --fail 'elasticsearch-master:9200/_cluster/health?wait_for_status=green&timeout=1s'
  restartPolicy: Never
MANIFEST:

---
# Source: elasticsearch/templates/poddisruptionbudget.yaml
apiVersion: policy/v1beta1
kind: PodDisruptionBudget
metadata:
  name: "elasticsearch-master-pdb"
spec:
  maxUnavailable: 1
  selector:
    matchLabels:
      app: "elasticsearch-master"
---
# Source: elasticsearch/templates/service.yaml
kind: Service
apiVersion: v1
metadata:
  name: elasticsearch-master
  labels:
    heritage: "Tiller"
    release: "elasticsearch"
    chart: "elasticsearch-7.3.0"
    app: "elasticsearch-master"
  annotations:
    {}

spec:
  type: ClusterIP
  selector:
    heritage: "Tiller"
    release: "elasticsearch"
    chart: "elasticsearch-7.3.0"
    app: "elasticsearch-master"
  ports:
  - name: http
    protocol: TCP
    port: 9200
  - name: transport
    protocol: TCP
    port: 9300
---
# Source: elasticsearch/templates/service.yaml
kind: Service
apiVersion: v1
metadata:
  name: elasticsearch-master-headless
  labels:
    heritage: "Tiller"
    release: "elasticsearch"
    chart: "elasticsearch-7.3.0"
    app: "elasticsearch-master"
  annotations:
    service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"
spec:
  clusterIP: None # This is needed for statefulset hostnames like elasticsearch-0 to resolve
  # Create endpoints also if the related pod isn't ready
  publishNotReadyAddresses: true
  selector:
    app: "elasticsearch-master"
  ports:
  - name: http
    port: 9200
  - name: transport
    port: 9300
---
# Source: elasticsearch/templates/statefulset.yaml
apiVersion: apps/v1beta1
kind: StatefulSet
metadata:
  name: elasticsearch-master
  labels:
    heritage: "Tiller"
    release: "elasticsearch"
    chart: "elasticsearch-7.3.0"
    app: "elasticsearch-master"
  annotations:
    esMajorVersion: "7"
spec:
  serviceName: elasticsearch-master-headless
  selector:
    matchLabels:
      app: "elasticsearch-master"
  replicas: 3
  podManagementPolicy: Parallel
  updateStrategy:
    type: RollingUpdate
  volumeClaimTemplates:
  - metadata:
      name: elasticsearch-master
    spec:
      accessModes:
      - ReadWriteOnce
      resources:
        requests:
          storage: 30Gi

  template:
    metadata:
      name: "elasticsearch-master"
      labels:
        heritage: "Tiller"
        release: "elasticsearch"
        chart: "elasticsearch-7.3.0"
        app: "elasticsearch-master"
      annotations:

    spec:
      securityContext:
        fsGroup: 1000

      affinity:
        podAntiAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
          - labelSelector:
              matchExpressions:
              - key: app
                operator: In
                values:
                - "elasticsearch-master"
            topologyKey: kubernetes.io/hostname
      terminationGracePeriodSeconds: 120
      volumes:
      initContainers:
      - name: configure-sysctl
        securityContext:
          runAsUser: 0
          privileged: true
        image: "docker.elastic.co/elasticsearch/elasticsearch:7.3.0"
        command: ["sysctl", "-w", "vm.max_map_count=262144"]
        resources:
          {}

      containers:
      - name: "elasticsearch"
        securityContext:
          capabilities:
            drop:
            - ALL
          runAsNonRoot: true
          runAsUser: 1000

        image: "docker.elastic.co/elasticsearch/elasticsearch:7.3.0"
        imagePullPolicy: "IfNotPresent"
        readinessProbe:
          failureThreshold: 3
          initialDelaySeconds: 10
          periodSeconds: 10
          successThreshold: 3
          timeoutSeconds: 5

          exec:
            command:
              - sh
              - -c
              - |
                #!/usr/bin/env bash -e
                # If the node is starting up wait for the cluster to be ready (request params: 'wait_for_status=green&timeout=1s' )
                # Once it has started only check that the node itself is responding
                START_FILE=/tmp/.es_start_file

                http () {
                    local path="${1}"
                    if [ -n "${ELASTIC_USERNAME}" ] && [ -n "${ELASTIC_PASSWORD}" ]; then
                      BASIC_AUTH="-u ${ELASTIC_USERNAME}:${ELASTIC_PASSWORD}"
                    else
                      BASIC_AUTH=''
                    fi
                    curl -XGET -s -k --fail ${BASIC_AUTH} http://<IP_ADDRESS>:9200${path}
                }

                if [ -f "${START_FILE}" ]; then
                    echo 'Elasticsearch is already running, lets check the node is healthy'
                    http "/"
                else
                    echo 'Waiting for elasticsearch cluster to become cluster to be ready (request params: "wait_for_status=green&timeout=1s" )'
                    if http "/_cluster/health?wait_for_status=green&timeout=1s" ; then
                        touch ${START_FILE}
                        exit 0
                    else
                        echo 'Cluster is not yet ready (request params: "wait_for_status=green&timeout=1s" )'
                        exit 1
                    fi
                fi
        ports:
        - name: http
          containerPort: 9200
        - name: transport
          containerPort: 9300
        resources:
          limits:
            cpu: 1000m
            memory: 1.5Gi
          requests:
            cpu: 100m
            memory: 1.5Gi

        env:
          - name: node.name
            valueFrom:
              fieldRef:
                fieldPath: metadata.name
          - name: cluster.initial_master_nodes
            value: "elasticsearch-master-0,elasticsearch-master-1,elasticsearch-master-2,"
          - name: discovery.seed_hosts
            value: "elasticsearch-master-headless"
          - name: cluster.name
            value: "elasticsearch"
          - name: network.host
            value: "<IP_ADDRESS>"
          - name: ES_JAVA_OPTS
            value: "-Xmx1g -Xms1g"
          - name: node.data
            value: "true"
          - name: node.ingest
            value: "true"
          - name: node.master
            value: "true"
        volumeMounts:
          - name: "elasticsearch-master"
            mountPath: /usr/share/elasticsearch/data

And the ooutput of running kubectl get pods --namespace=elasticsearch -l app=elasticsearch-master
NAME                     READY     STATUS             RESTARTS   AGE
elasticsearch-master-0   0/1       CrashLoopBackOff   4          4m
elasticsearch-master-1   0/1       Running            0          4m
elasticsearch-master-2   0/1       Error              4          3m

If you reduce the amount of memory you will also need to adjust the jvm memory size:
https://github.com/elastic/helm-charts/blob/8502b6f5224e51b228c13e21681770c03e337fb8/elasticsearch/values.yaml#
That could potentially be causing issues although I think that the cluster should still start up properly.
Could you also give me the log output from each of the containers? It's interesting that elasticsearch-master-1 does seem to be running but the others are crashing.

I have the same issue. Everything is running (3 nodes) but readinessProbess are failing and causes the pods to restart.
If I try to check the health, this is what I get:
{"error":{"root_cause":[{"type":"master_not_discovered_exception","reason":null}],"type":"master_not_discovered_exception","reason":null},"status":503}

(I forwarded port with kubectl port-forward svc/elasticsearch-master 9200 -n logging and then curl 'http://localhost:9200/_cluster/health?wait_for_status=green&timeout=1s'
Logs:
| elasticsearch {"type": "server", "timestamp": "2019-10-10T15:33:46,214Z", "level": "WARN", "component": "r.suppressed", "cluster.name": "elasticsearch", "node.name": "elasticsearch-master-2", "message": "path: /_cluster/health, params: {wait_for_status=green, timeout=1s}",                                                                                │
│ elasticsearch "stacktrace": ["org.elasticsearch.discovery.MasterNotDiscoveredException: null",                                                                                │
│ elasticsearch "at org.elasticsearch.action.support.master.TransportMasterNodeAction$AsyncSingleAction$2.onTimeout(TransportMasterNodeAction.java:214) [elasticsearch-7.4.0.jar:7.4.0]",                                                                                │
│ elasticsearch "at org.elasticsearch.cluster.ClusterStateObserver$ContextPreservingListener.onTimeout(ClusterStateObserver.java:325) [elasticsearch-7.4.0.jar:7.4.0]",                                                                                │
│ elasticsearch "at org.elasticsearch.cluster.ClusterStateObserver$ObserverClusterStateListener.onTimeout(ClusterStateObserver.java:252) [elasticsearch-7.4.0.jar:7.4.0]",                                                                                │
│ elasticsearch "at org.elasticsearch.cluster.service.ClusterApplierService$NotifyTimeout.run(ClusterApplierService.java:598) [elasticsearch-7.4.0.jar:7.4.0]",                                                                                │
│ elasticsearch "at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:703) [elasticsearch-7.4.0.jar:7.4.0]",                                                                                │
│ elasticsearch "at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]",                                                                                │
│ elasticsearch "at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]",                                                                                │
│ elasticsearch "at java.lang.Thread.run(Thread.java:830) [?:?]"] }                                                                                │
│ elasticsearch {"type": "server", "timestamp": "2019-10-10T15:33:53,510Z", "level": "WARN", "component": "o.e.c.c.ClusterFormationFailureHelper", "cluster.name": "elasticsearch", "node.name": "elasticsearch-master-2", "message": "master not discovered or elected yet, an election requires at least 2 nodes with ids from [jfp510YSTUWui7MHQ_kcNg, wsK1Hg0P │
│ mKHlnCoU0hwZg, -F4nt28_Q7ORXOrpl2_KPQ[], have discovered [{elasticsearch-master-2}{jfp510YSTUWui7MHQ_kcNg}{LtX9Z5psRVKcNtfb3UxNQQ}{<IP_ADDRESS>}{<IP_ADDRESS>:9300}{dilm}{ml.machine_memory=2147483648, xpack.installed=true, ml.max_open_jobs=20}] which is not a quorum; discovery will continue using [<IP_ADDRESS>:9300, <IP_ADDRESS>:9300] from hosts provid │
│ ers and [{elasticsearch-master-2}{jfp510YSTUWui7MHQ_kcNg}{LtX9Z5psRVKcNtfb3UxNQQ}{<IP_ADDRESS>}{<IP_ADDRESS>:9300}{dilm}{ml.machine_memory=2147483648, xpack.installed=true, ml.max_open_jobs=20}] from last-known cluster state; node term 9, last-accepted version 280 in term 9" }                                                                            │
│```

@RobertoUa another gotcha that I've encountered is that even if you delete the app that had 3 replicas and install again with 2 replicas but forget to delete persistent volume claims (which don't get removed by Helm when you delete the app), it still fails with MasterNotDiscoveredException.

@dolsem got the same problem on Digital Ocean managed K8s. After removing PVC manually that didn't fix anything :(

@dolsem got the same problem on Digital Ocean managed K8s. After removing PVC manually that didn't fix anything :(

@holms Would you mind opening a new bug report with the requested details so we can investigate further.

@fatmcgav
After increasing readiness probe to 200 it worked:
readinessProbe:
    initialDelaySeconds: 200

And I think it might be due to this exit 1 in readinessProbe that you have in here:
https://github.com/elastic/helm-charts/blob/e463e7a1f4f719687e8b4294bc3223bfbd021915/elasticsearch/templates/statefulset.yaml#L223

@fatmcgav opened new issue #361 also with logs attached. But really this happens even on my home server. So IDK what is going on, but best practises states you never do exit 1 in readiness, you might end up in such situation anytime in different environment.

@holms Cool, cheers. Let's continue this discussion on #361.

@CallmeTorre Is this still an issue for you?

Hi guys,
I'm also receiving master_not_discovered_exception / MasterNotDiscoveredException and I can't figure out why.
Kubernetes: v1.17.0
Manifest:
---
# Source: elasticsearch/templates/poddisruptionbudget.yaml
apiVersion: policy/v1beta1
kind: PodDisruptionBudget
metadata:
  name: "elasticsearch-master-pdb"
spec:
  maxUnavailable: 1
  selector:
    matchLabels:
      app: "elasticsearch-master"
---
# Source: elasticsearch/templates/service.yaml
kind: Service
apiVersion: v1
metadata:
  name: elasticsearch-master
  labels:
    release: "es"
    chart: "elasticsearch"
    app: "elasticsearch-master"
  annotations:
    {}
spec:
  type: ClusterIP
  selector:
    release: "es"
    chart: "elasticsearch"
    app: "elasticsearch-master"
  ports:
  - name: http
    protocol: TCP
    port: 9200
  - name: transport
    protocol: TCP
    port: 9300
---
# Source: elasticsearch/templates/service.yaml
kind: Service
apiVersion: v1
metadata:
  name: elasticsearch-master-headless
  labels:
    release: "es"
    chart: "elasticsearch"
    app: "elasticsearch-master"
  annotations:
    service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"
spec:
  clusterIP: None # This is needed for statefulset hostnames like elasticsearch-0 to resolve
  # Create endpoints also if the related pod isn't ready
  publishNotReadyAddresses: true
  selector:
    app: "elasticsearch-master"
  ports:
  - name: http
    port: 9200
  - name: transport
    port: 9300
---
# Source: elasticsearch/templates/statefulset.yaml
apiVersion: apps/v1
kind: StatefulSet
metadata:
  name: elasticsearch-master
  labels:
    release: "es"
    chart: "elasticsearch"
    app: "elasticsearch-master"
  annotations:
    esMajorVersion: "7"
spec:
  serviceName: elasticsearch-master-headless
  selector:
    matchLabels:
      app: "elasticsearch-master"
  replicas: 3
  podManagementPolicy: Parallel
  updateStrategy:
    type: RollingUpdate
  volumeClaimTemplates:
  - metadata:
      name: elasticsearch-master
    spec:
      accessModes:
      - ReadWriteOnce
      resources:
        requests:
          storage: 1Gi
  template:
    metadata:
      name: "elasticsearch-master"
      labels:
        release: "es"
        chart: "elasticsearch"
        app: "elasticsearch-master"
      annotations:

    spec:
      securityContext:
        fsGroup: 1000
        runAsUser: 1000
      affinity:
        podAntiAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
          - labelSelector:
              matchExpressions:
              - key: app
                operator: In
                values:
                - "elasticsearch-master"
            topologyKey: kubernetes.io/hostname
      terminationGracePeriodSeconds: 120
      volumes:
      initContainers:
      - name: configure-sysctl
        securityContext:
          runAsUser: 0
          privileged: true
        image: "docker.elastic.co/elasticsearch/elasticsearch:7.5.2"
        imagePullPolicy: "IfNotPresent"
        command: ["sysctl", "-w", "vm.max_map_count=262144"]
        resources:
          {}

      containers:
      - name: "elasticsearch"
        securityContext:
          capabilities:
            drop:
            - ALL
          runAsNonRoot: true
          runAsUser: 1000
        image: "docker.elastic.co/elasticsearch/elasticsearch:7.5.2"
        imagePullPolicy: "IfNotPresent"
        readinessProbe:
          failureThreshold: 3
          initialDelaySeconds: 50
          periodSeconds: 10
          successThreshold: 3
          timeoutSeconds: 5
          exec:
            command:
              - sh
              - -c
              - |
                #!/usr/bin/env bash -e
                # If the node is starting up wait for the cluster to be ready (request params: 'wait_for_status=green&timeout=1s' )
                # Once it has started only check that the node itself is responding
                START_FILE=/tmp/.es_start_file

                http () {
                    local path="${1}"
                    if [ -n "${ELASTIC_USERNAME}" ] && [ -n "${ELASTIC_PASSWORD}" ]; then
                      BASIC_AUTH="-u ${ELASTIC_USERNAME}:${ELASTIC_PASSWORD}"
                    else
                      BASIC_AUTH=''
                    fi
                    curl -XGET -s -k --fail ${BASIC_AUTH} http://<IP_ADDRESS>:9200${path}
                }

                if [ -f "${START_FILE}" ]; then
                    echo 'Elasticsearch is already running, lets check the node is healthy and there are master nodes available'
                    http "/_cluster/health?timeout=0s"
                else
                    echo 'Waiting for elasticsearch cluster to become cluster to be ready (request params: "wait_for_status=green&timeout=1s" )'
                    if http "/_cluster/health?wait_for_status=green&timeout=1s" ; then
                        touch ${START_FILE}
                        exit 0
                    else
                        echo 'Cluster is not yet ready (request params: "wait_for_status=green&timeout=1s" )'
                        exit 1
                    fi
                fi
        ports:
        - name: http
          containerPort: 9200
        - name: transport
          containerPort: 9300
        resources:
          limits:
            cpu: 1000m
            memory: 2Gi
          requests:
            cpu: 100m
            memory: 2Gi
        env:
          - name: node.name
            valueFrom:
              fieldRef:
                fieldPath: metadata.name
          - name: cluster.initial_master_nodes
            value: "elasticsearch-master-0,elasticsearch-master-1,elasticsearch-master-2,"
          - name: discovery.seed_hosts
            value: "elasticsearch-master-headless"
          - name: cluster.name
            value: "elasticsearch"
          - name: network.host
            value: "<IP_ADDRESS>"
          - name: ES_JAVA_OPTS
            value: "-Xmx1g -Xms1g"
          - name: node.data
            value: "true"
          - name: node.ingest
            value: "true"
          - name: node.master
            value: "true"
        volumeMounts:
          - name: "elasticsearch-master"
            mountPath: /usr/share/elasticsearch/data
---
# Source: elasticsearch/templates/test/test-elasticsearch-health.yaml
apiVersion: v1
kind: Pod
metadata:
  name: "es-khddf-test"
  annotations:
    "helm.sh/hook": test-success
spec:
  containers:
  - name: "es-xsqvw-test"
    image: "docker.elastic.co/elasticsearch/elasticsearch:7.5.2"
    command:
      - "sh"
      - "-c"
      - |
        #!/usr/bin/env bash -e
        curl -XGET --fail 'elasticsearch-master:9200/_cluster/health?wait_for_status=green&timeout=1s'
  restartPolicy: Never

$ kubectl get pods
NAME                     READY   STATUS    RESTARTS   AGE
elasticsearch-master-0   0/1     Running   0          14m
elasticsearch-master-1   0/1     Pending   0          14m
elasticsearch-master-2   0/1     Pending   0          14m
es-khddf-test            0/1     Error     0          14m

and logs for the Running pod keeps repeating:
{"type": "server", "timestamp": "2020-02-04T15:31:04,041Z", "level": "DEBUG", "component": "o.e.a.s.m.TransportMasterNodeAction", "cluster.name": "elasticsearch", "node.name": "elasticsearch-master-0", "message": "timed out while retrying [cluster:monitor/health] after failure (timeout [1s])" }
{"type": "server", "timestamp": "2020-02-04T15:31:04,042Z", "level": "WARN", "component": "r.suppressed", "cluster.name": "elasticsearch", "node.name": "elasticsearch-master-0", "message": "path: /_cluster/health, params: {wait_for_status=green, timeout=1s}",
"stacktrace": ["org.elasticsearch.discovery.MasterNotDiscoveredException: null",
"at org.elasticsearch.action.support.master.TransportMasterNodeAction$AsyncSingleAction$2.onTimeout(TransportMasterNodeAction.java:218) [elasticsearch-7.5.2.jar:7.5.2]",
"at org.elasticsearch.cluster.ClusterStateObserver$ContextPreservingListener.onTimeout(ClusterStateObserver.java:325) [elasticsearch-7.5.2.jar:7.5.2]",
"at org.elasticsearch.cluster.ClusterStateObserver$ObserverClusterStateListener.onTimeout(ClusterStateObserver.java:252) [elasticsearch-7.5.2.jar:7.5.2]",
"at org.elasticsearch.cluster.service.ClusterApplierService$NotifyTimeout.run(ClusterApplierService.java:598) [elasticsearch-7.5.2.jar:7.5.2]",
"at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:703) [elasticsearch-7.5.2.jar:7.5.2]",
"at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]",
"at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]",
"at java.lang.Thread.run(Thread.java:830) [?:?]"] }
{"type": "server", "timestamp": "2020-02-04T15:31:05,590Z", "level": "WARN", "component": "o.e.c.c.ClusterFormationFailureHelper", "cluster.name": "elasticsearch", "node.name": "elasticsearch-master-0", "message": "master not discovered yet, this node has not previously joined a bootstrapped (v7+) cluster, and this node must discover master-eligible nodes [elasticsearch-master-0, elasticsearch-master-1, elasticsearch-master-2] to bootstrap a cluster: have discovered [{elasticsearch-master-0}{jcDINcndSQSZ5fPBuhiyQw}{VOTh1xvtSLy9ygU_R-IVFw}{<IP_ADDRESS>}{<IP_ADDRESS>:9300}{dilm}{ml.machine_memory=2147483648, xpack.installed=true, ml.max_open_jobs=20}]; discovery will continue using [] from hosts providers and [{elasticsearch-master-0}{jcDINcndSQSZ5fPBuhiyQw}{VOTh1xvtSLy9ygU_R-IVFw}{<IP_ADDRESS>}{<IP_ADDRESS>:9300}{dilm}{ml.machine_memory=2147483648, xpack.installed=true, ml.max_open_jobs=20}] from last-known cluster state; node term 0, last-accepted version 0 in term 0" }
{"type": "server", "timestamp": "2020-02-04T15:31:13,039Z", "level": "DEBUG", "component": "o.e.a.s.m.TransportMasterNodeAction", "cluster.name": "elasticsearch", "node.name": "elasticsearch-master-0", "message": "no known master node, scheduling a retry" }

SSH-ing into the pod and running curl on elasticsearch-master-0:9200 and elasticsearch-master-headless:9200 resolves the names and returns:
{
  "name" : "elasticsearch-master-0",
  "cluster_name" : "elasticsearch",
  "cluster_uuid" : "_na_",
  "version" : {
    "number" : "7.5.2",
    "build_flavor" : "default",
    "build_type" : "docker",
    "build_hash" : "8bec50e1e0ad29dad5653712cf3bb580cd1afcdf",
    "build_date" : "2020-01-15T12:11:52.313576Z",
    "build_snapshot" : false,
    "lucene_version" : "8.3.0",
    "minimum_wire_compatibility_version" : "6.8.0",
    "minimum_index_compatibility_version" : "6.0.0-beta1"
  },
  "tagline" : "You Know, for Search"
}

but doing /_cluster/health gives:
{"error":{"root_cause":[{"type":"master_not_discovered_exception","reason":null}],"type":"master_not_discovered_exception","reason":null},"status":503}

At this point I don't have any ideas on what to check further. Please help :(

Found the problem: antiAffinity was set to hard and but I didn't have enough nodes so only one pod was being scheduled... since that pod couldn't go green (not finding enough masters) the deploy hanged.


High severity vulnerability affecting this repo

Hi there,
We noticed that your repo has a high severity vulnerability:

Regular Expression Denial of Service
Affected package: minimatch <=3.0.1

Here is the test report for this repo.
If you’d like to fix this vulnerability, Snyk lets you generate a pull request that recommends the best upgrade path - there’s a link to fix this vulnerability on the test report.
Stay secure :-)
Snyk Community

@snyk-community I really hate these automated spam bots trying to generate leads for a service, masquerading as doing a favor.


Infer returns incorrect type for object without optional properties

Package version
<EMAIL_ADDRESS>Describe the bug
I am defining a schema with all required fields:
const authSchema = vine.object({
  email: vine.string().email(),
  password: vine
    .string()
    .minLength(8)
    .maxLength(32)
})

And a function with parameter formData: FormData
When I try to validate this schema:
const data = await vine.validate({
    schema: authSchema,
    data: formData,
  });

I see the following type for data:
const data: {
    email?: string;
    password?: string;
}

I will open a new bug for this, but wanted to flag it here too.
Perhaps related, but it seems the opposite behaviour was reported in #78
Reproduction repo
No response

I am so sorry for this. I didn't even confirm that typescript is configured with "strictNullChecks": true. I believe this is the issue but will confirm when I'm back at my computer 🤦♂

Yup, I ended up with strict: false somehow


"net localgroup" is correct

"net localgroup" is correct command to add user to local group

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 740d8b1d-7a60-9c21-5eec-11cb6a623b9d
Version Independent ID: f728db3a-a2a9-cf29-f2f9-daea26052093
Content: Troubleshoot Windows 7 virtual machines in Windows Virtual Desktop - Azure
Content Source: articles/virtual-desktop/troubleshoot-windows-7-vm.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@makotog Thanks for your feedback. We are looking into this and will update you shortly.

@eriawan Thanks for the PR.
@makotog PR for fixing the document has been raised. The doc will be updated once the author approves the PR. I am closing the issue for now.


browserSync fails because of empty  element

BrowserSync fails with Uncaught TypeError: Cannot read property 'indexOf' of null
The following issue explains the problem:
https://github.com/BrowserSync/browser-sync/issues/1504
I pinpointed the issue in Microweber to this line:
https://github.com/microweber/microweber/blob/2c8ba85984214ea033a3677d0169a15dd8498b47/src/MicroweberPackages/App/Http/Controllers/FrontendController.php#L1172
To fix this issue, add an empty href argument to the link element.
$liv_ed_css = '<link rel="stylesheet" href="" id="mw-custom-user-css" type="text/css" />';

fixed in this commit 7f0aebbd6cf6e9828ba115dddfdae424f182a9b8 , but the problem remains in browser-sync


Publish does not always respect concurrent actions

It should add another two cids to the log, but it doesn't.
This happens after very quickly doing various actions after each other.
Maybe the CID is the same for the following two publishes?

Confirmed that this works properly. Issue was a race condition of the writes which I need to fix in my app. We'll later have fs.transaction to help with this.

Confirmed that this works properly. Issue was a race condition of the writes which I need to fix in my app. We'll later have fs.transaction to help with this.


Ensure docker build is not broken with a verify script

/kind bug
What steps did you take and what happened:
The docker build is broken! It should have a verify script.

/priority important-longterm

/assign


Apply -debug-prefix-map to isysroot

Previously the absolute path to the sysroot, which could differ across
machines in remote build scenarios, was included in the debug info of
object files:
!11 = distinct !DICompileUnit(language: DW_LANG_Swift, file: !12, producer: "Swift version 5.3-dev (LLVM 93caf26adb68d37, Swift 58b2ddc65afbd60)", isOptimized: false, runtimeVersion: 5, emissionKind: FullDebug, enums: !13, imports: !14, sysroot: "/Applications/Xcode-11.5.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk", sdk: "MacOSX.sdk")

With this change these are included in the remapping done by
-debug-prefix-map.

I honestly don't have a good sense of the side effects this could cause, but I was looking at why our object files aren't perfectly hermetic in our remote builds and found that this was one source.

Makes sense. Must have been missed when implementing 78edd30
@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test Windows platform

@swift-ci please clean smoke test macOS platform

⛵

Thanks!
--
Keith Smiley


Rejig the user manual navigation

This is an attempt to simplify and shorten the left-hand navigation for the
user manual.
See in-commit comments for the rationale behind the various changes.

@eriwen @jlstrater I'm not sure about the Extending Gradle section. It's a little skinny right now, but I can see it evolving into topics like developing your own DSL/model. To be fair, the line between authoring and extending is pretty fuzzy for a tool like Gradle. One might consider writing your own tasks to be "extending".

I think this is superseded by #7725. Right @pledbrook?

Yes and no. Let me rebase this against the latest and have a look at the differences. There may some changes here that make sense in the context of #7725 as well.

@eriwen @jlstrater I've updated the pull request. It's now a smaller set of changes based on the current release branch. Should be pretty quick to review. The changes consist of a bit of tidying up.


fix: reexport the WASIProcExit error so it can be caught when calling exported functions

So you can do
    try {
      instance.exports.my_exported_func();
      return 0;
    } catch (e) {
      if (e instanceof WASIProcExit) {
        return e.code;
      } else {
        throw e;
      }
    }

Makes sense.

Published in v0.2.21


[CLOSED] Mistaken PR

I apologize for the mistake. This pull request was sent to the wrong repository by accident. I have closed it now. Sorry for any inconvenience caused.


Incompatible with DamageTilt

When CombatEdit and DamageTilt are used at the same time, DamageTilt no longer works correctly.

Fixed in version 1.3.3, thank you for the bug report!


it doesnt work at all

after login success, the req has no user property, and passport.deserializeUser doesnt run at all

can, when you defied you to miss option passport.use(new Strategy ({usernameField: 'email'}, function ())
because default name field in the form is the username, if you login with email, you must add {usernameField: 'email'} to first params of Strategy

This example app is confirmed to be working.   There's not enough information reported here to be actionable, so I'm closing.  If more information can be provided, please reply here and re-open the issue.


doc(plugins): add ChunksWebpackPlugin

This PR adds the ChunksWebpackPlugin to the plugins documentation page.
A dedicated page with instructions for use is also added.

Thank you @EugeneHlushko for your comments 👍.
I updated the doc with several of your suggestions and a few other commits (I don't know if I could close these threads, sorry if not).
I have a few questions about open threads.

Thanks @EugeneHlushko and @jamesgeorge007, everything is up to date.


Add favicon support

This should work out of the box. Submissions/ideas welcome!

@davezuko First of all, thanks for all the work you've put into this. Since the html-webpack-plugin is being used couldn't we just pass 'favicon' into the configuration options in the _base.js and then add the favicon path/filename in the config index for users to change if needed? I'm just getting started with this kit so this may be a naive approach.

Here's what I've done to add a favicon on a personal project.
Favicon support: branch
I'm sure there's a smarter way to do this for the kit, but this covers my immediate needs.

I like it, how does it end up in the compiled version? Just favicon.ico in the root and no links in the html?

@mtsr Yeah, just favicon.ico in the root and no links in the html. It's not a robust solution, e.g. apple-touch icons, but it does the trick for basic use cases. Another option could be to use an html template, for example, in order to add a link in the html.

@N8-B Thanks for the example, I didn't have anything more complex in the mind, but just didn't have a favicon to actually use haha. If somebody has any options to contribute it would be appreciated.
I also thought about possibly just creating a public folder in the root and putting the favicon in there (and referencing it correctly from HtmlWebpackPlugin). That way you could add more static assets as needed without having to copy non-imported assets from src -> dist.

I don’t know about this. I feel having static content used without require is becoming more of an anti-pattern with webpack.
On 12 Dec 2015, at 15:51, David Zukowski<EMAIL_ADDRESS>wrote:

@N8-B Thanks for the example, I didn't have anything more complex in the mind, but just didn't have a favicon to actually use haha. If somebody has any options to contribute it would be appreciated.
I also thought about possibly just creating a public folder in the root and putting the favicon in there (and referencing it correctly from HtmlWebpackPlugin). That way you could add more static assets as needed without having to copy non-imported assets from src -> dist.
—
Reply to this email directly or view it on GitHub.

@davezuko let's just use react favicon?

https://facebook.github.io/react/favicon.ico

Sure, sounds good to me

I also thought about possibly just creating a public folder in the root and putting the favicon in there (and referencing it correctly from HtmlWebpackPlugin). That way you could add more static assets as needed without having to copy non-imported assets from src -> dist.

@davezuko i agree, this is a good opportunity to create a folder for static assets such as index.html, favicon.com, robots.txt, etc.

@justingreenberg what do you suggest, just something like public or static?

@davezuko how about assets?

@justingreenberg I just want to make sure I'm clear on the design:
Are you imagining this as a root directory (as I am)? If so, I'm still curious about the proposed workflow. If you were to serve an application with this design, you'd have to point the web server to both static and dist, which seems kinda silly. Is there a better solution that I'm missing?
If I'm wrong in this assumption, and it's a folder within src (~/src/static) then are those files copied over upon compilation?

i was initially thinking a folder within src/assets, but it could also be in root directory—since we're using webpack, all assets should really be passing through a loader and bundled before hitting the build target (./dist). webpack-dev-middleware will handle serving during development and in production it would be handled by express (or simple static file server ie. s3)
does that make sense?

Yes, thanks. My only question was with regard to the robots.txt and similar files, since I don't understand how those would get processed by webpack unless you were using something like react-helmet (if I understand that package correctly).

can we use webpack/file-loader to pipe static files through webpack?

Oh, probably, I'll take a stab at it. And ok, thanks for the heads up.

Closing this in favor of https://github.com/davezuko/react-redux-starter-kit/issues/234, we can move the discussion there. Favicon will be added once this is all sorted out.


[SM]: StartPage implementation

could you also set the back link in the ClaimPeriod page to refer back to this start page?


Empty strings not allowed in PolicyName parameter

Example 2 is syntactically correct but does not work. There seems to be an error in the New-CsBatchPolicyAssignmentOperation commandLet. Now it validates parameters and it does not allow empty strings passed to the PolicyName parameter. I have run it several times and I always got this error:
+ ... entOperation -PolicyType TeamsMeetingPolicy -PolicyName $null -Identi ...
+                                                             ~~~~~
    + CategoryInfo          : InvalidData: (:) [New-CsBatchPolicyAssignmentOperation], ParameterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationErrorEmptyStringNotAllowed,New-CsBatchPolicyAssignmentOperation

Either you change the documentation or you ask for the developers to change the code.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d149ca60-bfb7-5077-2643-1a08ad926cca
Version Independent ID: 24754aee-bff2-fa16-e7e6-af45362fd916
Content: New-CsBatchPolicyAssignmentOperation (teams)
Content Source: teams/teams-ps/teams/New-CsBatchPolicyAssignmentOperation.md
Service: teams-powershell
GitHub Login: @tomkau
Microsoft Alias: tomkau

Hello @qosobrin how are you?
I was able to run Example 2 as is, are you passing $null to the PolicyName parameter right? What version of the module are you using? Please be sure to run 1.1.4 (current GA version)

Hi there, Andrés:
well that's not my case here even when I think I meet all the requirements:
[image: image.png]
I do not try to make this a support session but I think someone is missing
something here.
Thank you very much for your prompt response.
Best regards,
El mar., 8 sept. 2020 a las 13:38, Andres Mariano Gorzelany (<
<EMAIL_ADDRESS>escribió:

Hello @qosobrin https://github.com/qosobrin how are you?
I was able to run Example 2 as is, are you passing $null to the PolicyName
parameter right? What version of the module are you using? Please be sure
to run 1.1.4 (current GA version)
[image: image]
https://user-images.githubusercontent.com/36666927/92471598-94b95980-f1ae-11ea-88b2-177fe852ab0b.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/office-docs-powershell/issues/6441#issuecomment-688810890,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSOTN3XKHX2YLWFTGT2GW3SEYJTHANCNFSM4QQXFP6Q
.

--
Luis A. Martínez Sobrino

Hello @qosobrin the image you tried to attach is missing.
Please be sure to run the latest GA version of the powershell module.
Thank you

You are right and I had both modules versions 1.0.5 and 1.1.4 installed. After removing the older version everything worked fine. I close the ticket.
Thank you very much. Regards.


unable to deploy libraryRequirements in Azure Synapse sparkpool via bicep

Bicep version
Bicep CLI version 0.10.61 (8f44805506)
Describe the bug
Error:
SparkComputePropertiesNotAllowed
Synapse Spark pool must be created before libraries are installed
To Reproduce
Try to create sparkpool resource with libraryRequirements section filled in.
'Microsoft.Synapse/workspaces/bigDataPools@2021-06-01'
    libraryRequirements:  {
      content: content
      filename: filename
    }

Additional context
Either put the libraryRequirements as separate resource to sparkpool (if it requires time), or build in mechanism to wait for sparkpool creation. If it is provided as part of resource it shall be created in one run.

Can you provide the full bicep file or resource (feel free to redact sensitive parts) for a repro?

Sure thing:
resource sparkpool 'Microsoft.Synapse/workspaces/bigDataPools@2021-06-01' =  {     name: PoolName     location: location     parent: synapse     properties:{       autoPause:{         enabled: true         delayInMinutes: 15       }       nodeSize: nodeSize       nodeSizeFamily: 'MemoryOptimized'       autoScale:{         enabled: true         minNodeCount: MinNodeCount         maxNodeCount: MaxNodeCount       }       libraryRequirements:  {         content: content         filename: filename       }       sparkVersion: '3.1'     }   }


Investigate register_symbolic_tensor_type

This could potentially be useful re tfe.keras. From TF source code:
def register_symbolic_tensor_type(cls):
  """Allows users to specify types regarded as symbolic `Tensor`s.

  Used in conjunction with `tf.register_tensor_conversion_function`, calling
  `tf.keras.utils.register_symbolic_tensor_type(cls)` allows non-`Tensor`
  objects to be plumbed through Keras layers.

  Example:

  # One-time setup.
  class Foo(object):
    def __init__(self, input_):
      self._input = input_
    def value(self):
      return tf.constant(42.)

  tf.register_tensor_conversion_function(
      Foo, lambda x, *args, **kwargs: x.value())

  tf.keras.utils.register_symbolic_tensor_type(Foo)

  # User-land.
  layer = tf.keras.layers.Lambda(lambda input_: Foo(input_))

  Arguments:
    cls: A `class` type which shall be regarded as a symbolic `Tensor`.
  """

This was experimented with in tf-big. It seems to rely on register_tensor_conversion_function since symbolic tensors are converted when the model is applied to an input:
x = convert_to_tensor(np.array(10))
model = tf.keras.models.Sequential([
  tf.keras.layers.Dense(10)
])
model(x)  # <-- x is asked to convert

and the dtype of the result is checked to be in a whitelist, effectively rendering it useless since we can only convert to strings without dataloss:
TypeError: Value passed to parameter 'a' has DataType string not in list of allowed values: bfloat16, float16, float32, float64, int32, int64, complex64, complex128

Closing for now, we can reopen if more ideas show up.


Add support for various missing record types

As it says on the tin, but not complete yet. Will probably add support for more involved types, e.g. SVCB, in separate PRs.

Compiles now, onto tests...

Still need to fixup handling of unknown record types and there seems to be a quirk in the fallback scanner. After that this should be ready to go in. Fun fact: I now made sure that even on error, the data member in the token points to valid memory, allowing us to handle the unusual case of generic encoding (start RDATA with \\#) quicker. i.e. check if it starts with \\ instead of checking if it's CONTIGUOUS and then verifying it exactly matches \\#. This improves performance noticeably.


Avoid memory copying / heap allocation

Given Tank is targeting "very high performance" one suggestion would be to use ByteBuffers or an abstract over ByteBuffer to access the message key & payload.
This avoids the need to allocate a byte array on the heap, copy the data into it, and then garbage collect the byte array for every message received.

Thanks for your comments.
I'll start working on it asap.

Unfortunately my implementation using ByteBuffers is proving slower than the original implementation.
So for now I'm going to revert, and maybe give it a fresh attempt later.
The branch buffers would be the latest iteration, using direct allocated byte buffers for most things.
Thanks


Bug: Get Posts by Tag

At this time, the endpoint for getting a user's post by clicking on a tag ('/api/entries/:tagName') gets ALL posts in the database that use that tag. In other words, it gets not only the user's posts, but other user's posts as well.
Edit the endpoint so it gets only the current user's posts. Make sure the endpoint's url is also RESTful!

Hi @nikobatzi1990, I want to work on this endpoint issue. Can you please assign it to me?

@DarshanDixit05 Sure thing! Thank you for contributing!


incorrect link on the about dialog

About dialog has the below link for GitHub which is wrong
https://github.com/code-ready/crc-tray-macos

I think the about dialog should not have to mention this. Omitting it sounds a better option than fixing it. WDYT?

I agree. Let's remove it.

Why is omitting it a better solution? By putting the link there people can get to the github repository and they can file issues for the tray there, rather than in the main crc repo.

Tray is not a thing by its own. When tray graduates from experimental tray repository will  be the only place that users are going to end up with for all kinds of issues. IMHO tray or no tray all issues should go to a single place. After all this is why we have issue templates and labels.

Okay, will remove the Github repo link from the status window!

Components labels exist and can be added for individual parts, for drivers
this is the same thing. They are reported against CRC and it is our duty to
resolve and deal with this accordingly.
On Mon, Apr 27, 2020 at 1:02 PM Anjan Nath<EMAIL_ADDRESS>wrote:

Okay, will remove the Github repo link from the status window!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/code-ready/tray-macos/issues/14#issuecomment-619720235,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAOZRLMIELZEYVWY7HIFDROUGWRANCNFSM4KPNYICA
.

--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]

The link is gone, closing this.


StandardizeIncrementFixer - static property access handling

Bug report
The standardize_increment rule doesn't correctly handle static property access.

PHP version: 7.4.7
PHP CS Fixer version: 2.16.4
the command used to run PHP CS Fixer: php-cs-fixer fix snippet.php --rules=@Symfony --using-cache=no -vvv
the configuration file you used: (none)

Code snippet that reproduces the problem
<?php

A::$b += 1;

Expected output: Fixed to:
<?php

++A::$b;

Actual output: Error:
Files that were not fixed due to errors reported during linting after fixing:
   1) /usr/src/z/snippet.php

        [PhpCsFixer\Linter\LintingException]
        PHP Parse error: syntax error, unexpected '++' (T_INC) on line 3.

      Applied fixers: standardize_increment

Adding --diff to the command shows it wanted to fix to:
<?php

A::++$b;

Additional info
$a::$b += 1; gives the same error.
$a->$b += 1; is OK.

Thanks for reporting!
Confirmed as bug on 2.15 and I suspect all versions up

ping @ntzm as author of the fixer, maybe you wanna give it try to patch?


Fix broken default view settings

This addresses BZ 1348813:
https://bugzilla.redhat.com/show_bug.cgi?id=1348813
Some settings in Default Views did not seem to persist due to mismatched keys with UI Constants.
After fix, setting the default view mode works:

/cc @h-kataria

verified in UI.


add couch_util:with_proc/{3,4}

BugzId: 2657

Commit message references to the nonexisted with_proc/3
A little bit notice why with_proc exists and what it does would be awesome (:

hah good call @kxepal. I'll rename the commit and I'm just going to cherry-pick it in so I'll leave this PR as is rather than recreating one.

+1

Merged manually.


Not work with magento <IP_ADDRESS>

Hello,
i installed the extension in my magento <IP_ADDRESS> www.ladebora.it but the extension not work. when i go in a category i see the loading but not loading the items.
Can I resolve?
Best Regards

Hello the-wanted, can you please give us some idea about your error?
Maybe a url where you host your site?

Hello the-wanted, can you please post the url to the category you see the error on?

Hello @janmyszkier this is the error

@the-wanted
I don't see any request to next/prev page on your page which means the most important part is missing.
Please:
a)
go to Admin -> System -> Cache Management -> Flush Cache Storage
and if the extension still won't work try:
b) Switch for a moment to base theme and confirm the extension has been installed correctly and work there (on rwd package)
Switching packages can be done on
Admin -> System (top menu section) -> Configuration (top menu item) -> General (left menu section) -> Design(left menu item) ->Package (main section)

@janmyszkier

i flushed the cache
i switched to base theme but the extension does not work

@the-wanted : now that I look at it you are redirected to checkout/cart if you scroll down, and when I look into your code you indeed have .next link to checkout cart:
Vai al carrello

please try to change its class first and then check again

@janmyszkier in which file this issue is?

@the-wanted: unfortunately I'm not sure, you have to search for yourself
just search your theme files for "viewcart_button" within the theme folder (app/design/frontend/default/galarainbow) and you'll surely find the file that you're looking for

@janmyszkier thanks i fix my issue