xz: set CONFIG_SHELL to /bin/sh, fix retained reference to bootstrap

stdenv should be buildable cleanly with new Nix!
I ran into this while working on the musl PR (#34645)
but this is reproducible on master with Nix 2
(AFAIK not with Nix 1.11).
Please review and test.  And yes this will require rebuilding all the things.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Using CONFIG_SHELL since that's what is checked first.
Don't force the shell to use, let xz test what it finds
and come to its own conclusions about suitability.
As-is our stdenv fails to build with Nix 2.0 due to references
in xz's scripts to bootstrap tools' "sh".
Try nix-build -A xz --check and look at what configure detects
for the POSIX-compat shell: it needs to be /bin/sh, and if
it instead is a path with the word "bootstrap" then you've reproduced.

Success on aarch64-linux (full log)
Partial log (click to expand)
stripping (with command strip and flags -S) in /nix/store/i8y9d92h61dfpvimvw0zn70906c8w2am-xz-5.2.3/lib
checking for references to /build in /nix/store/i8y9d92h61dfpvimvw0zn70906c8w2am-xz-5.2.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/6y82lnxb1qrv9yd8xgzrwjvcdgg5jv36-xz-5.2.3-man
gzipping man pages under /nix/store/6y82lnxb1qrv9yd8xgzrwjvcdgg5jv36-xz-5.2.3-man/share/man/
strip is /nix/store/gfgczbs0cy0blibb0acv39cayq7qbplg-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/6y82lnxb1qrv9yd8xgzrwjvcdgg5jv36-xz-5.2.3-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/nsk6id9cy08aw0imhmycd4bqs0wd6c53-xz-5.2.3-doc
strip is /nix/store/gfgczbs0cy0blibb0acv39cayq7qbplg-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/nsk6id9cy08aw0imhmycd4bqs0wd6c53-xz-5.2.3-doc...
/nix/store/z346cdfnvn4ihf9bwqqff99pzwr33xqr-xz-5.2.3-bin

Failure on x86_64-linux (full log)
Partial log (click to expand)
/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/xg++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/ -B/nix/store/s670dyz8vm2mnd600l2myynsgnskfn6c-gcc-6.4.0/x86_64-unknown-linux-gnu/bin/ -nostdinc++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include/x86_64-unknown-linux-gnu  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include  -I/tmp/nix-build-gcc-6.4.0.drv-0/gcc-6.4.0/libstdc++-v3/libsupc++ -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs -fno-PIE -c   -O2 -I/nix/store/4nva0c0qadvi2sjjirk0wg5vr2883xy3-glibc-2.26-131-dev/include -B/nix/store/4h0allsz28x9mdirzb4wv51algacxzr7-glibc-2.26-131/lib/ -idirafter /nix/store/4nva0c0qadvi2sjjirk0wg5vr2883xy3-glibc-2.26-131-dev/include -idirafter /nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/lib/gcc/x86_64-unknown-linux-gnu/5.3.0/include-fixed -Wl,-rpath,/nix/store/grhn0xic5c6py68sb5852xvy58rq00yk-gcc-6.4.0-lib/lib -Wl,-L/nix/store/4h0allsz28x9mdirzb4wv51algacxzr7-glibc-2.26-131/lib -Wl,-rpath -Wl,/nix/store/4h0allsz28x9mdirzb4wv51algacxzr7-glibc-2.26-131/lib -Wl,-L/nix/store/4h0allsz28x9mdirzb4wv51algacxzr7-glibc-2.26-131/lib -gtoggle -fprofile-generate -DIN_GCC     -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H -I. -I. -I../../gcc-6.4.0/gcc -I../../gcc-6.4.0/gcc/.  -I. -I../../gcc-6.4.0/gcc -I../../gcc-6.4.0/gcc/. -I../../gcc-6.4.0/gcc/../include -I../../gcc-6.4.0/gcc/../libcpp/include -I/nix/store/lrw06gvflnx7kcjmli7h1p8945cg791k-gmp-6.1.2-dev/include -I/nix/store/g3496kg9vkd4n18zp94nw8hp5lkqjx2s-mpfr-3.1.3-dev/include -I/nix/store/ca7ywzdjgf98pgg26pyinkvrv1bgcglj-libmpc-1.0.3/include  -I../../gcc-6.4.0/gcc/../libdecnumber -I../../gcc-6.4.0/gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc-6.4.0/gcc/../libbacktrace -I/nix/store/4ij7kfj57dhxl1g9yxakrpy1f15cf5av-isl-0.14.1/include  -o tree-ssa-loop-im.o -MT tree-ssa-loop-im.o -MMD -MP -MF ./.deps/tree-ssa-loop-im.TPo ../../gcc-6.4.0/gcc/tree-ssa-loop-im.c
/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/xg++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/ -B/nix/store/s670dyz8vm2mnd600l2myynsgnskfn6c-gcc-6.4.0/x86_64-unknown-linux-gnu/bin/ -nostdinc++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include/x86_64-unknown-linux-gnu  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include  -I/tmp/nix-build-gcc-6.4.0.drv-0/gcc-6.4.0/libstdc++-v3/libsupc++ -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs -fno-PIE -c   -O2 -I/nix/store/4nva0c0qadvi2sjjirk0wg5vr2883xy3-glibc-2.26-131-dev/include -B/nix/store/4h0allsz28x9mdirzb4wv51algacxzr7-glibc-2.26-131/lib/ -idirafter /nix/store/4nva0c0qadvi2sjjirk0wg5vr2883xy3-glibc-2.26-131-dev/include -idirafter /nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/lib/gcc/x86_64-unknown-linux-gnu/5.3.0/include-fixed -Wl,-rpath,/nix/store/grhn0xic5c6py68sb5852xvy58rq00yk-gcc-6.4.0-lib/lib -Wl,-L/nix/store/4h0allsz28x9mdirzb4wv51algacxzr7-glibc-2.26-131/lib -Wl,-rpath -Wl,/nix/store/4h0allsz28x9mdirzb4wv51algacxzr7-glibc-2.26-131/lib -Wl,-L/nix/store/4h0allsz28x9mdirzb4wv51algacxzr7-glibc-2.26-131/lib -gtoggle -fprofile-generate -DIN_GCC     -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H -I. -I. -I../../gcc-6.4.0/gcc -I../../gcc-6.4.0/gcc/. -I../../gcc-6.4.0/gcc/../include -I../../gcc-6.4.0/gcc/../libcpp/include -I/nix/store/lrw06gvflnx7kcjmli7h1p8945cg791k-gmp-6.1.2-dev/include -I/nix/store/g3496kg9vkd4n18zp94nw8hp5lkqjx2s-mpfr-3.1.3-dev/include -I/nix/store/ca7ywzdjgf98pgg26pyinkvrv1bgcglj-libmpc-1.0.3/include  -I../../gcc-6.4.0/gcc/../libdecnumber -I../../gcc-6.4.0/gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc-6.4.0/gcc/../libbacktrace -I/nix/store/4ij7kfj57dhxl1g9yxakrpy1f15cf5av-isl-0.14.1/include  -o tree-ssa-loop-ivcanon.o -MT tree-ssa-loop-ivcanon.o -MMD -MP -MF ./.deps/tree-ssa-loop-ivcanon.TPo ../../gcc-6.4.0/gcc/tree-ssa-loop-ivcanon.c
/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/xg++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/ -B/nix/store/s670dyz8vm2mnd600l2myynsgnskfn6c-gcc-6.4.0/x86_64-unknown-linux-gnu/bin/ -nostdinc++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include/x86_64-unknown-linux-gnu  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include  -I/tmp/nix-build-gcc-6.4.0.drv-0/gcc-6.4.0/libstdc++-v3/libsupc++ -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs -fno-PIE -c   -O2 -I/nix/store/4nva0c0qadvi2sjjirk0wg5vr2883xy3-glibc-2.26-131-dev/include -B/nix/store/4h0allsz28x9mdirzb4wv51algacxzr7-glibc-2.26-131/lib/ -idirafter /nix/store/4nva0c0qadvi2sjjirk0wg5vr2883xy3-glibc-2.26-131-dev/include -idirafter /nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/lib/gcc/x86_64-unknown-linux-gnu/5.3.0/include-fixed -Wl,-rpath,/nix/store/grhn0xic5c6py68sb5852xvy58rq00yk-gcc-6.4.0-lib/lib -Wl,-L/nix/store/4h0allsz28x9mdirzb4wv51algacxzr7-glibc-2.26-131/lib -Wl,-rpath -Wl,/nix/store/4h0allsz28x9mdirzb4wv51algacxzr7-glibc-2.26-131/lib -Wl,-L/nix/store/4h0allsz28x9mdirzb4wv51algacxzr7-glibc-2.26-131/lib -gtoggle -fprofile-generate -DIN_GCC     -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H -I. -I. -I../../gcc-6.4.0/gcc -I../../gcc-6.4.0/gcc/.  -I. -I../../gcc-6.4.0/gcc -I../../gcc-6.4.0/gcc/. -I../../gcc-6.4.0/gcc/../include -I../../gcc-6.4.0/gcc/../libcpp/include -I/nix/store/lrw06gvflnx7kcjmli7h1p8945cg791k-gmp-6.1.2-dev/include -I/nix/store/g3496kg9vkd4n18zp94nw8hp5lkqjx2s-mpfr-3.1.3-dev/include -I/nix/store/ca7ywzdjgf98pgg26pyinkvrv1bgcglj-libmpc-1.0.3/include  -I../../gcc-6.4.0/gcc/../libdecnumber -I../../gcc-6.4.0/gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc-6.4.0/gcc/../libbacktrace -I/nix/store/4ij7kfj57dhxl1g9yxakrpy1f15cf5av-isl-0.14.1/include  -o tree-ssa-loop-manip.o -MT tree-ssa-loop-manip.o -MMD -MP -MF ./.deps/tree-ssa-loop-manip.TPo ../../gcc-6.4.0/gcc/tree-ssa-loop-manip.c
building of ‘/nix/store/svaqbrzsaf1yvmp9f6mmp08zr26b3lr3-gcc-6.4.0.drv’ timed out after 3600 seconds
cannot build derivation ‘/nix/store/gnn0r2q7kx3xymp0zdmjlw60bcad6lfy-gcc-wrapper-6.4.0.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/9i8xmdr2jj0abqmhqrc3s9s2zgiapq2c-stdenv-linux-boot.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/0zqi8bh3g89s2iln9h4w9nmjzz92nh9v-xz-5.2.3.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/0zqi8bh3g89s2iln9h4w9nmjzz92nh9v-xz-5.2.3.drv’ failed

Failure on x86_64-darwin (full log)
Partial log (click to expand)
cannot build derivation '/nix/store/7ddspi80c2nnkb2968k53q3bak9qc5xz-libtool-2.4.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/dhgdmgjq2sjp5rv3gbvdrn23cvx2d1pg-cctools-port-895.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/g8q65162skaa4fn7f6psjq02rcfs8yf7-cctools-binutils-darwin.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/5k40zihf6flqn2d9ijs40qhdsass4k64-cctools-binutils-darwin-wrapper.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/b0779abx444kg1c7gn1hx3a73qv1v0r9-bash-4.4-p12.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/j0kfm0fn3m1m0x29ki8bb5f94gwalw10-binutils-wrapper-9.9.9.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/ikplcsjj8f83zr9ia10i8rd9xk17cl1g-clang-wrapper-9.9.9.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/yasrkayxfwwz426g545k1vhbqzp0jffk-stdenv-darwin-boot-3.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/jwb5j3yxh0iwwnlg2hlyrs1bnh761dnx-xz-5.2.3.drv': 2 dependencies couldn't be built
error: build of '/nix/store/jwb5j3yxh0iwwnlg2hlyrs1bnh761dnx-xz-5.2.3.drv' failed

Can't reproduce
$ nix-store -qR $(nix-build -A xz.dev '<nixpkgs>')
/nix/store/z0b60y0khix9jb74ka56gw7b7n9s8awx-glibc-2.26-131
/nix/store/zsiv7x9m1bqnz0n554ckajgx5ck8i3kj-xz-5.2.3
/nix/store/f7jfl4ql2302g07r6hym9dgna2db7772-xz-5.2.3-bin
/nix/store/5dkhk20dcqilprqxdas5izwzz0l5a6ws-xz-5.2.3-dev

$ nix-store --version
nix-store (Nix) 1.12pre5788_e3013543

nixpkgs 2e4aded3669
I see no references to "bootstrap". Probably this only occurs for musl libc? I see similar fixes in nixpkgs though
https://github.com/NixOS/nixpkgs/commit/a9a3ed108472a987ba892162ce9ab4d24f383eff

@danbst did you build those paths yourself (using nix 1.12/2) or did you fetch them from a cache? You'll need to build yourself to see this.
FWIW xz.bin contains the references, I forget if xz.dev includes that or no.
Don't believe it has anything to do with musl other than we don't rebuild bootstrap tools often and so things like this can sneak in unnoticed. I say this because before filing this PR I tested using nixpkgs master to confirm it wasn't. ... Although it'd be good to see someone else reproduce to be sure it's not dtz-specific :).

Thanks for the link to the commit, I thought I remembered this being an issue. Hmm.

Yes, I've tried cached and local results:
$ nix-store -qR $(nix-build -A xz.bin '<nixpkgs>' --check 2>/dev/null)
/nix/store/z0b60y0khix9jb74ka56gw7b7n9s8awx-glibc-2.26-131
/nix/store/zsiv7x9m1bqnz0n554ckajgx5ck8i3kj-xz-5.2.3
/nix/store/f7jfl4ql2302g07r6hym9dgna2db7772-xz-5.2.3-bin

Hmm, thanks.  1.12 might not be new enough, including corresponding NixOS changes made for 2.0 that move to using a busybox-based /bin/sh instead of a more complete bash.
(Although to be honest I don't quite follow how that change caused this exactly but it seems much too related to be a coincidence :)).
Can someone already running Nix 2.0 using NixOS master give this a go?
I'll see if I can't find a way to reproduce more confidently, maybe some NixOS VM magic?

Alright, another attempt to reproduce this. You should see  same result running locally, otherwise something impure is happening
$ nix-shell -I nixpkgs=https://github.com/nixos/nixpkgs/archive/master.tar.gz -p nixUnstable --run '
    nix-store -qR $(nix-build -A xz.bin -I nixpkgs=https://github.com/nixos/nixpkgs/archive/master.tar.gz "<nixpkgs>" --option sandbox true --check 2>/dev/null)
  '
/nix/store/4h0allsz28x9mdirzb4wv51algacxzr7-glibc-2.26-131
/nix/store/p8q89pf7xxy5n6j39sjsxryzy38yv2gd-xz-5.2.3
/nix/store/khh0hwhrzpmjb5fijxrcm0s1iapkl9jg-xz-5.2.3-bin

My NixOS is 18.03.pre.e860b65, not quite master though.
Which nixos commits are you talking about?

@danbst mostly I was referring to 700e21d6dac4683ef40f20127a6eb2a74b9bd8c6.  Your nixpkgs seems plenty new.
Thanks for the invocation goodness! That command produces no output for me since the --check fails :).  I guess that's not what you're seeing.... probably the nix-daemon used matters, unless running as root? Either way it fails for me, hmm.

Ok, I'll try to update to that commit, 2.0 stuff should be so cool. In meanwhile I've stopped my nix-daemon and launched 2.0 one inside nix-shell - xz still builds for me.

Thank you for your heroic efforts.  In an attempt to help I asked on IRC and @lheckemann was kind enough to try with latest Nix/NixOS.  I believe he found that --check failed at least sometimes but that it still used /bin/sh not the bootstrap shell as I'm experiencing.
Meanwhile I'm still observing this behavior, currently using:

system: "x86_64-linux"
host os: Linux 4.15.2, NixOS, 18.03.git.9b080c3 (Impala)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.0pre5889_c287d731
channels(will): "allvm, nixos-1609-16.09.1943.25f4906da6, unstable-18.03pre127302.e860b651d6e"
channels(root): "nixos"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

I'm really not sure why I'd be seeing different behavior than you guys, but if no one else can reproduce ("until" they can) then that's good news for everyone :).  Well, except me since I'm not sure I'll be able to let this go until I sort out what's going on.

I have now
 - system: `"x86_64-linux"`
 - host os: `Linux 4.15.2, NixOS, 18.03.pre.e860b65 (Impala)`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.0pre5889_c287d731`
 - channels(root): `"nixos-18.03pre127302.e860b651d6e"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`

which is similar to @lheckemann and @dtzWill
and still can't reproduce @dtzWill  issue with  either https://github.com/NixOS/nixpkgs/pull/34916#issuecomment-365248112 nor https://github.com/NixOS/nixpkgs/pull/34916#issuecomment-365252434
Though I see now that --option sanbox true doesn't work, I should set this option in nix.conf, and now I also observe non-deterministic warning.
This kind of irreproducibility makes me sad, because Nix is all about reproducibility...

@dtzWill can you post your error log?

Allright, I see some progress. I've tried nix-build --check -K and then diffoscope on resulting outputs. Now I see like this:
--- /nix/store/khh0hwhrzpmjb5fijxrcm0s1iapkl9jg-xz-5.2.3-bin
+++ /nix/store/khh0hwhrzpmjb5fijxrcm0s1iapkl9jg-xz-5.2.3-bin.check
├── bin
│ ├── xzdiff
│ │ @@ -1,8 +1,8 @@
│ │ -#!/bin/sh
│ │ +#!/nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/bin/sh
│ │
│ │  # Copyright (C) 1998, 2002, 2006, 2007 Free Software Foundation
│ │  # Copyright (C) 1993 Jean-loup Gailly
│ │
│ │  # Modified for XZ Utils by Andrew Dudman and Lasse Collin.
│ │

So, I understand like this: nix builds xz locally, but doesn't replace the derivation in store with newly built one (because those should be identical, why bother replacing?). So @dtzWill and I both have different packages with same name

@danbst Yay! You reproduced it! :D.  Thank you and I'm very relieved-- I was struggling something fierce to explain why I was seeing this and others weren't.
Also I found this from when this was previously discussed/observed: https://github.com/NixOS/nixpkgs/pull/3574 .

Still don't get why previous "fix" (unset CONFIG_SHELL) worked
See https://git.tukaani.org/?p=xz.git;a=blob;f=m4/posix-shell.m4;h=4c56193c1571dbf86074727a933b44c739bf70b7;hb=HEAD#l46
  45      for gl_cv_posix_shell in \
  46          "$CONFIG_SHELL" "$SHELL" /bin/sh /bin/bash /bin/ksh /bin/sh5 no; do
  47        case $gl_cv_posix_shell in
  48          /*)
  49            "$gl_cv_posix_shell" -c "$gl_test_posix_shell_script" 2>/dev/null \
  50              && break;;
  51        esac
  52      done])
  53
  54   if test "$gl_cv_posix_shell" != no; then
  55     POSIX_SHELL=$gl_cv_posix_shell
  56     PREFERABLY_POSIX_SHELL=$POSIX_SHELL
  57   else
  58     POSIX_SHELL=
  59     PREFERABLY_POSIX_SHELL=/bin/sh
  60   fi

CONFIG_SHELL unset, but SHELL is not. Why doesn't it influence build result? Probably because when sandbox disabled, SHELL is set to /bin/sh (impure), but in sandbox it is set to some bash.

I have the same confusion, although I like your explanation.

FWIW this was merged as part of the musl PR, closing for now. Thanks everyone!

I've dig deeper here.
So here's what happens. Both with and without sandbox SHELL is initialized to some bash.
However xz configure script ignores it and sets it from CONFIG_SHELL. If CONFIG_SHELL is set, then it's used for all the shells.
Now, what happens when CONFIG_SHELL is unset?

configure scans /bin/sh, /bin/ksh, etc, then packages from PATH for available shells
first one which is (according to some test) compliant is used as CONFIG_SHELL (and SHELL subsequently)
the compliance is, however, strange. It requires some features, but values also some other features
in sandbox mode it chooses bash from PATH (the one from bootstrap tools), because it looks like "more featurefull" to configure. /bin/sh is a minimal ash shell from busybox (after https://github.com/NixOS/nix/commit/a2d92bb20e82a0957067ede60e91fab256948b41)
in non-sandbox mode it chooses /bin/sh (because it's full-featured bash) and comes first in list.

Probably another instance of what https://github.com/NixOS/nixpkgs/pull/34628 should fix, but I'm not sure


[Math] NumDot needs more functions

What good is a maths library without maths functions? Most of them should be pretty easy to implement thanks to xtensor, but it has to be done.
Most of what numpy and xtensor support are in scope for NumDot.

Numpy's supported functions can be found here.
XTensor's supported function can be found here.

Consider these sub-issues:

[x] #35
[x] #29
[x] #31
[x] #32
[x] #22
[x] #12

[x] #33
[x] #34
[x] #52

[x] #13
[x] #21
[x] #16
[x] #14
[x] #45
[x] #50
[x] #53

Consider these sub-issues:

[ ] #29
[ ] #31
[ ] #32
[ ] #22
[ ] #12

[ ] #33
[ ] #34

[ ] #30
[ ] #13
[ ] #21
[ ] #16
[ ] #14
[ ] #17

Closing, as finally I have all basic categories of functionality implemented! 🎉
This of course doesn't mean work is done, but new functionality can be tracked elsewhere.


Docs improvement

Hi,
This Pr contains :

chore(provider): add APPCLACKS_API_URL env var: This commit adds the APPCLACKS_API_URL environment variable to the Appclacks provider. This variable allows users to specify the URL of the Appclacks API, which is required for the provider to function properly.

chore: add MakeFile: This commit adds a MakeFile to the project. The MakeFile includes various commands that can be used to build and test the provider.

chore: Add docs templates: This commit adds templates for the documentation. These templates provide a consistent structure for documenting the provider and its resources.

docs: Update doc from templates: This commit updates the documentation using the new templates. The documentation has been revised to conform to the new templates, and additional information has been added where necessary.

Thank you :)


chore: Tooling/docs to generate test files for better test onboarding

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Allows generating gingko test suite and spec files from templates that follow some of the test standards already in place in this repo. This should facilitate a more efficient test onboarding
Issue ticket number and link
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
go mod tidy
go mod vendor
running make targets manually - No Env Vars set
running make targets manually - Single Env Var set
running make targets manually - Combo Env Var set
Checklist:

[x ] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("[test_id:01] DEVHAS-62 devfile source")
[ ] I have updated labels (if needed)

/test redhat-appstudio-e2e

/lgtm

/hold


Using with ES6/Babel

Hi! I've just set it up and got this issue:
Error while loading rule 'typelint/composite': Unexpected token import
/Users/***/Documents/work/***/src/app.js:1
(function (exports, require, module, __filename, __dirname) { import Auth from './components/auth/auth';
                                                              ^^^^^^
SyntaxError: Unexpected token import
    at Object.exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:513:28)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at setSchema (/Users/***/Documents/work/***/node_modules/eslint-plugin-typelint/lib/schemas/formats/json.js:24:28)
    at lookUp (/Users/***/Documents/work/***/node_modules/eslint-plugin-typelint/lib/schemas/formats/json.js:36:12)

My .eslintrc.js looks like:
module.exports = {
  'extends': [
    'defaults'
  ],
  'parser': 'babel-eslint',
  'plugins': [
    'react',
    'react-native',
    'typelint'
  ],
  'rules': {
    'no-unused-vars': [2, {'vars': 'local', 'args': 'none'}],
    'no-console': 0,
    'quotes': [2, 'single', {'allowTemplateLiterals': true}],
    //ES6
    'constructor-super': 2,
    'arrow-spacing': 2,
    'no-const-assign': 2,
    'no-var': 2,
    'prefer-spread': 2,
    'prefer-template': 2,
    'no-dupe-class-members': 2,
    'no-this-before-super': 2,
    //React
    'react/jsx-uses-react': 2,
    'react/jsx-key': 2,
    'react/no-deprecated': 2,
    'react/jsx-max-props-per-line': [2, {maximum: 4}],
    'react/jsx-uses-vars': 2,
    'react-native/no-unused-styles': 2,
    'react-native/split-platform-components': 2,

    'typelint/composite': 2,
    // 'typelint/primitive': 2
  },
  'env': {
    'es6': true,
    'commonjs': true,
    'mocha': true,
    'node': true
  },
  'globals': {
    'fetch': true,
    'console': true,
    'expect': true
  },
  'settings': {
    'typelint': {
      'models': {
        'json': {
          'dir': './src'
        }
      }
    }
  }
};

As you see, I use babel-eslint. What can I do to make it work?

Hi!
Thanks for the issue.
I've created a small project with your config and it seems working fine.
You can check it out here https://yadi.sk/d/dw2TLCtgt3FAs
I freezed dependencies to the shrinkwrap (just installed default versions of needed libs)
How do you run eslint? Probably there is a mismatching between plugins/versions of local and global libraries.
I would recommend always to run eslint as ./node_modules/.bin/eslint

@yarax Okay thank you! If it works for simple project, it seems to be kind of misconfiguration. I'll investigate and report here.
By the way I use eslint from local project's node_modules and I run it by npm script: "lint": "eslint src"

@yarax actually I didn't succeed with example:
I installed the dependencies (had to create empty package.json to make npm do that). I use Node 5.7.1, NPM 3.6.0;
Package.json:
{
  "name": "test_typelint",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "lint": "eslint .",
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC"
}

Output:
➜  test_typelint  ./node_modules/.bin/eslint .

/Users/***/Documents/github/test_typelint/1.js
  1:16  error  Parsing error: Unexpected token

/Users/***/Documents/github/test_typelint/index.js
  7:15  error  Invalid access to property wrong for type var  typelint/composite

✖ 2 problems (2 errors, 0 warnings)

The first error is actually real one :) My fault, export and const are not going together, previously I just checked index.js.
But the second is an error from typelint, which means it works properly :)
PS @huston007 According to your package.json eslint is still using globally.
PS (btw npm install works fine with me, just having npm-shrinkwrap.json)

@yarax Okay, thanks, will continue investigation. Just for information, npm scripts use binaries from project's node_modules first. Actually I even has no eslint installed globally
➜  build git:(master) eslint
zsh: command not found: eslint
➜  build git:(master)

@huston007  Oh, I see. Good to know :)
So feel free to notify if something else goes wrong

@yarax I got what I did wrong. I have javascript (ES6) files in src directory. typelint tried to parse it as model schemas.
Anyway, this issue could help someone faced into same problem. Thanks for you help!


Generate Odometry data from Phidgets Encoders

We can generate JointState data from the encoders, but not Odometry data. When this node is created, the node will take in JointState messages, combine that with data from a URDF, and output Odometry data detailing the 2D pose of the robot.

I verified this works to a pretty decent extent using the mapping bagfile Sam and I created, but I need to consciously mess with it and test its behavior to be sure.

After testing with gmapping, it works well enough. However, it doesn't rotate around the correct spot when turning.


Added missing head to markdown

Fixed missing head to markdown.

I am not using vercel anymore.Please disregard any issues related to deployment of vercel.


Rebuild harfbuzz4

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Closes https://github.com/conda-forge/openjdk-feedstock/pull/90

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin please rerender

The OSX build fails with
+ codesign --remove-signature bin/jaotc
--sign is required

any ideas about how to fix that @conda-forge/openjdk ?

The linux_aarch64 and linux_ppcle64 builds both have this problem in the testing step:
qemu: fatal: Tried to call a TRAP

There is an open bug report about this at https://gitlab.com/qemu-project/qemu/-/issues/588
Options here include a) disable the test for linux_aarch64 and linux_ppcle64 or b) wait until an updated qemu is released with a fix for this issue. How should we proceed @conda-forge/openjdk ?

@conda-forge-admin please rerender

Tried Travis but got
The job exceeded the maximum log length, and has been terminated.

What's the reason for the log being that large?

gcc seems to be pinned in ppc64le try to unpin in?
Also it seems that there is a likely bug with register char c

You can likely delete the file: https://github.com/izahn/openjdk-feedstock/blob/rebuild-harfbuzz4/recipe/conda_build_config.yaml

What's the reason for the log being that large?

Log is at https://app.travis-ci.com/github/conda-forge/openjdk-feedstock/jobs/568466954

@conda-forge-admin please rerender

Well if "just" ppc64le is failing on azure, you can likely skip the compilation test for that one while qemu is fixed.
It is really curious as to why the logs are so verbose on ppc64le

@conda-forge-admin please rerender

@conda-forge-admin please rerender

linux_aarch64 fails with
2022-04-28T11:42:38.3382062Z /home/conda/feedstock_root/build_artifacts/openjdk_1651143572459/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/10.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: skipping incompatible /home/conda/feedstock_root/build_artifacts/openjdk_1651143572459/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/10.3.0/../../../libasound.so when searching for -lasound
2022-04-28T11:42:38.3384235Z collect2: error: ld returned 1 exit status
2022-04-28T11:42:38.3434461Z make[3]: *** [Lib-java.desktop.gmk:64: /home/conda/feedstock_root/build_artifacts/openjdk_1651143572459/work/src/build-build/support/modules_libs/java.desktop/libjsound.so] Error 1

Anyone have ideas about this one?

sorry :(

@conda-forge-admin please rerender

Well if "just" ppc64le is failing on azure, you can likely skip the compilation test for that one while qemu is fixed.

Ugh, so I tried this in https://github.com/conda-forge/openjdk-feedstock/pull/93/commits/4f6e23c3fc6d42b8d7392f4593b0de692af3ac71 https://github.com/conda-forge/openjdk-feedstock/pull/93/commits/f084698369942311309f5389091297a99a831fe7 but it looks like it still tries to run the test. What selector can we use to skip that test on both windows and ppc64le?

I think additve selectors were broken.

https://github.com/conda-forge/conda-smithy/issues/1617

conda-forge/conda-smithy#1617

Ah, thanks, I was starting to think my mind was going...

Still having problems with the aarch build. I tried setting --with-alsa to PREFIX / BUILD_PREFIX in https://github.com/conda-forge/openjdk-feedstock/pull/93/commits/e6ea9a0977be49405f990ab0f5f83c5ce3119f3d and https://github.com/conda-forge/openjdk-feedstock/pull/93/commits/f4d1fd45c1027a7bcf477c874071486011454e7c but either way we get
/home/conda/feedstock_root/build_artifacts/openjdk_1651249498229/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/10.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: skipping incompatible /home/conda/feedstock_root/build_artifacts/openjdk_1651249498229/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/10.3.0/../../../libasound.so when searching for -lasound
collect2: error: ld returned 1 exit status
make[3]: *** [Lib-java.desktop.gmk:64: /home/conda/feedstock_root/build_artifacts/openjdk_1651249498229/work/src/build-build/support/modules_libs/java.desktop/libjsound.so] Error 1

Any ideas? @xhochy I think you were the one that got a aarch64 build working in the first place, any thoughts about this?

I can't figure out the aarch64 alsa problem, if no one else has time to fix it I recommend merging this as-is and addressing the aarch64 bug later @conda-forge/openjdk

You are hitting https://github.com/conda/conda-build/issues/3155. A rebuild of alsa-lib-feedstock should fix this.

Seems like you might just be able to copy the migrator in. As yours might be the only feedstock that needs rebuilding

@conda-forge-admin please rerender

@conda-forge-admin please restart ci

@conda-forge-admin please restart ci

@conda-forge-admin please restart ci

Thanks to all your help @isuruf and @hmaarrfk I think this is ready.

Did you want to add yourself as a maintainer?

@conda-forge-admin please rerender

Did you want to add yourself as a maintainer?

Sure, happy to help!


kong 500 error：received: 500; {"message":"An unexpected error occurred"}

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
Kong 3.0.0
Current Behavior
No response
Expected Behavior
No response
Steps To Reproduce
No response
Anything else?
These error logs exist. I'm not sure if they are relevant.
2024/03/27 17:07:29 [error] 1124#0: *62 [lua] handler.lua:415: reconfigure failed: ...l/share/lua/5.1/kong/runloop/balancer/healthcheckers.lua:419: bad argument #1 to 'pairs' (table expected, got nil), context: ngx.timer
2024/03/29 07:24:29 [error] 1126#0: *58047224 upstream prematurely closed connection while reading response header from upstream

Is there any other error log with the error or the critical level?
Also, we always recommend updating to the latest version.

I didn't see any other error logs.

How often does this occur? It sounds like a previously-fixed bug. Could you also try with the latest version?

Kong gateway 3.0 is EOL, could you upgrade it to the latest or LTS version and try again?

@StarlightIbuki @chronolaw This issue seems to have happened while get_all_upstreams returns nil + error, but error was swallowed : https://github.com/Kong/kong/blob/3.0.0/kong/runloop/balancer/healthcheckers.lua#L419.
It should have the same issue in latest version, should we check the error and don't iterate the get_all_upstreams returns nil + error? like below:
function healthcheckers_M.stop_healthcheckers(delay)
  local upstreams, err =  upstreams.get_all_upstreams()
  if err ~= nil {
    return err
  }
  for _, id in pairs() do
  ...
end

And log the error message where calls the stop_healthcheckers.

@oowl , could you take a look? thanks.

Hi @git-hulk, We have fixed this bug in the master branch, Please be patient to wait for the next major version release. It will be included.

@oowl That's cool, thank you!

failed the initial dns/balancer resolve for 'UPSTREAM_HOST' with: failed to get from node cache: could not acquire callback lock: timeout
Hello, we have checked the relevant logs and found that they should be related to this.
And it can be confirmed that 500 is not related to the fix above.

Can this be reopened?

@dubuqingfeng Hi, You can open a new issue, and I will be happy to help you investigate.


[LIBCLOUD-1026] Update documentation for UpCloud driver

Update UpCloud driver documentation
Description

Dropped www from the URL
Added missing datacenters
Updated API credentials instructions
Updated logo

https://issues.apache.org/jira/projects/LIBCLOUD/issues/LIBCLOUD-1026
Status

done, ready for review

Checklist (tick everything that applies)

[x] Documentation
[x] ICLA (required for bigger changes)
[ ] Code linting (required, can be done after the PR checks)
[ ] Tests

Thanks! Merged in trunk. :sparkles:

Ah shoot, should have waited for the tests my bad:
$ git clone --depth=50 https://github.com/apache/libcloud.git apache/libcloud
Cloning into 'apache/libcloud'...
remote: Enumerating objects: 3957, done.
remote: Counting objects: 100% (3957/3957), done.
remote: Compressing objects: 100% (2572/2572), done.
remote: Total 3957 (delta 1658), reused 3016 (delta 1323), pack-reused 0
Receiving objects: 100% (3957/3957), 5.63 MiB | 19.10 MiB/s, done.
Resolving deltas: 100% (1658/1658), done.
$ cd apache/libcloud
3.78s$ git fetch origin +refs/pull/1259/merge:
fatal: Couldn't find remote ref refs/pull/1259/merge
The command "eval git fetch origin +refs/pull/1259/merge: " failed. Retrying, 2 of 3.
fatal: Couldn't find remote ref refs/pull/1259/merge
The command "eval git fetch origin +refs/pull/1259/merge: " failed. Retrying, 3 of 3.
fatal: Couldn't find remote ref refs/pull/1259/merge
The command "eval git fetch origin +refs/pull/1259/merge: " failed 3 times.
The command "git fetch origin +refs/pull/1259/merge:" failed and exited with 128 during .

I'm sure this is fine though since it is just a textual change

@vdloo just to make sure that I've understood the current contribution workflow correctly I should now make a patch out of this change and then attach the patch to the JIRA ticket?

Hi @iler, no that is not necessary I think. I've merged your change into the trunk and pushed it to the Apache Software Foundation repositories. The way it works is that we don't merge directly on github but instead merge the commits to trunk, sign the commits, and then once we push it the asfgit bot will come by to sync the repo back to github and close the pull request. Your change is now in the current trunk and the change has been documented here in the CHANGES file. What should happen in relation to the JIRA ticket and how the documentation is used to generate the readthedocs website I do not know.

@vdloo Ok, I'm cool with that. Was just following the instructions found from the documentation at https://libcloud.readthedocs.io/en/latest/development.html#attach-a-final-patch-with-your-changes-to-the-corresponding-jira-ticket


css key missing from manifest if cssCodeSplit is set to false

Describe the bug
If build.cssCodeSplit is set to false, the manifest does not list any information about CSS-output for each entry.
Reproduction
https://stackblitz.com/edit/vitejs-vite-n4xegc?file=vite.config.js
System Info
System:
    OS: Linux 4.19 Ubuntu 20.04 LTS (Focal Fossa)
    CPU: (32) x64 AMD Ryzen Threadripper 2950X 16-Core Processor
    Memory: 45.16 GB / 50.12 GB
    Container: Yes
    Shell: 3.1.2 - /usr/bin/fish
  Binaries:
    Node: 16.13.1 - /tmp/fnm_multishells/18_1643474543039/bin/node
    Yarn: 1.22.17 - /tmp/fnm_multishells/18_1643474543039/bin/yarn
    npm: 8.1.2 - /tmp/fnm_multishells/18_1643474543039/bin/npm

Used Package Manager
yarn
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

duplicate of https://github.com/vitejs/vite/issues/6477


Refactor for steam MFA changes #56

Refactor for #56
Steam changed its MFA behavior recently. ssfn* files appear to be no longer relevant. And supplying passwords in the action script has been noted as causing a steam MFA regression where it will invalidate prior MFA approvals.
This PR makes the required adjustments to match current steam MFA behavior
Changes

Removes the need for the ssfn* files
Removes the need to supply a password
Updates instructions to match new Steam MFA behavior

Please merge whenever possible haha, im having the ssfn issue for steam

@davidmfinol shall we merge and bump major?


Rink: Use ratatui instead of tui-rs

Problem
rink currently depends on tui-rs, which is no longer maintained.
Solution
Switch to ratatui, which has been named the official successor to tui-rs.
It should just be a drop-in replacement, simply changing the Cargo.toml entry to:
tui = { package = "ratatui", version = "0.22", features = ["all-widgets"]}

Nice

We don't really use the TUI crate for anything except rendering. Wrap their widget trait and events. We could switch to a more raw terminal rendering crate like termwiz. Termwiz supports images, and raw pixel graphics on some terminals unlike TUI or ratatui

We could switch to a more raw terminal rendering crate like termwiz. Termwiz supports images, and raw pixel graphics on some terminals unlike TUI or ratatui

That does sound like a good idea. I have looked into termwiz and it seems like a better option if Rink isn't using any widgets from tui-rs. (also ratatui does have a termwiz backend if dioxus-tui ever does find use in the widgets).


e2e cases failed quite often after testing TestFlowAggregator

Describe the bug
Many e2e tests failed after testing TestFlowAggregator regardless of where it ran:
Jenkins tests:
https://jenkins.antrea-ci.rocks/job/antrea-e2e-for-pull-request/2180/console
https://jenkins.antrea-ci.rocks/job/antrea-e2e-for-pull-request/2181/console
Kind tests:
https://pipelines.actions.githubusercontent.com/rI6se88BdHGIt3c6pWSIOE7hniT9sK2Yykq02f3adUskIOWLhd/_apis/pipelines/1/runs/41803/signedlogcontent/62?urlExpires=2021-03-15T10%3A33%3A53.1605722Z&urlSigningMethod=HMACV1&urlSignature=wdQSJpI%2FMRR0L8CQN8qzg%2Bz%2FD58ic2XdpXQm%2FEYNYVg%3D
https://pipelines.actions.githubusercontent.com/rI6se88BdHGIt3c6pWSIOE7hniT9sK2Yykq02f3adUskIOWLhd/_apis/pipelines/1/runs/41784/signedlogcontent/64?urlExpires=2021-03-15T11%3A51%3A10.5229666Z&urlSigningMethod=HMACV1&urlSignature=PSJmMVUGj9jRbGmfnS0AaHRIx%2FQSfewr3aClt6bhRTA%3D
The common pattern is antrea-agent cannot get up and running after runnning TestFlowAggregator, the case itself may succeed or fail:
2021-03-13T06:13:57.0285748Z === RUN   TestFlowAggregator
2021-03-13T06:13:57.0288577Z ##[error]    fixtures.go:133: Creating 'antrea-test' K8s Namespace
2021-03-13T06:13:57.0311588Z ##[error]    fixtures.go:96: Applying Antrea YAML
2021-03-13T06:13:57.9460506Z ##[error]    fixtures.go:100: Waiting for all Antrea DaemonSet Pods
2021-03-13T06:13:58.9598129Z ##[error]    fixtures.go:104: Checking CoreDNS deployment
2021-03-13T06:14:01.9906449Z ##[error]    fixtures.go:160: Applying flow aggregator YAML with ipfix collector address: <IP_ADDRESS>:4739:tcp
2021-03-13T06:14:05.3566800Z ##[error]    fixtures.go:172: Deploying flow exporter with collector address: <IP_ADDRESS>:4739:tcp
2021-03-13T06:15:36.9364958Z ##[error]    flowaggregator_test.go:110: Error when setting up test: error when restarting antrea-agent Pod: antrea-agent DaemonSet not ready within 1m30s
2021-03-13T06:15:36.9368127Z --- FAIL: TestFlowAggregator (99.91s)
2021-03-13T06:15:36.9369146Z === RUN   TestReplaceFieldValue
2021-03-13T06:15:36.9372023Z --- PASS: TestReplaceFieldValue (0.00s)
2021-03-13T06:15:36.9392459Z === RUN   TestIPSecTunnelConnectivity
2021-03-13T06:15:36.9395283Z ##[error]    fixtures.go:36: Skipping test for the 'kind' provider: IPSec tunnel does not work with Kind
2021-03-13T06:15:36.9398119Z --- SKIP: TestIPSecTunnelConnectivity (0.00s)
2021-03-13T06:15:36.9399464Z === RUN   TestIPSecDeleteStaleTunnelPorts
2021-03-13T06:15:36.9401897Z ##[error]    fixtures.go:36: Skipping test for the 'kind' provider: IPSec tunnel does not work with Kind
2021-03-13T06:15:36.9407904Z --- SKIP: TestIPSecDeleteStaleTunnelPorts (0.00s)
2021-03-13T06:15:36.9409278Z === RUN   TestNetworkPolicyStats
2021-03-13T06:15:36.9411329Z ##[error]    fixtures.go:133: Creating 'antrea-test' K8s Namespace
2021-03-13T06:15:36.9413605Z ##[error]    fixtures.go:96: Applying Antrea YAML
2021-03-13T06:17:08.0802565Z ##[error]    networkpolicy_test.go:40: Error when setting up test: error when waiting for antrea-agent rollout to complete
2021-03-13T06:17:08.0859094Z --- FAIL: TestNetworkPolicyStats (91.14s)
2021-03-13T06:17:08.0860619Z === RUN   TestDifferentNamedPorts
2021-03-13T06:17:08.0862750Z ##[error]    fixtures.go:133: Creating 'antrea-test' K8s Namespace
2021-03-13T06:17:08.0865191Z ##[error]    fixtures.go:96: Applying Antrea YAML
2021-03-13T06:18:39.0666049Z ##[error]    networkpolicy_test.go:155: Error when setting up test: error when waiting for antrea-agent rollout to complete
2021-03-13T06:18:39.0686473Z --- FAIL: TestDifferentNamedPorts (90.99s)

--- PASS: TestFlowAggregator (209.81s)
    --- PASS: TestFlowAggregator/IntraNodeFlows (11.19s)
    --- PASS: TestFlowAggregator/InterNodeFlows (11.24s)
    --- PASS: TestFlowAggregator/LocalServiceAccess (11.10s)
    --- PASS: TestFlowAggregator/RemoteServiceAccess (11.10s)
=== RUN   TestReplaceFieldValue
--- PASS: TestReplaceFieldValue (0.00s)
=== RUN   TestIPSecTunnelConnectivity
    fixtures.go:133: Creating 'antrea-test' K8s Namespace
    fixtures.go:96: Applying Antrea YAML
    fixtures.go:100: Waiting for all Antrea DaemonSet Pods
    ipsec_test.go:66: Error when setting up test: antrea-agent DaemonSet not ready within 1m30s
--- FAIL: TestIPSecTunnelConnectivity (91.18s)
=== RUN   TestIPSecDeleteStaleTunnelPorts
    fixtures.go:133: Creating 'antrea-test' K8s Namespace
    fixtures.go:96: Applying Antrea YAML
    ipsec_test.go:100: Error when setting up test: error when waiting for antrea-agent rollout to complete
--- FAIL: TestIPSecDeleteStaleTunnelPorts (91.16s)

To Reproduce
Run e2e test
Expected
A test case should clean up its side effect, not affecting other cases.

Thanks @tnqn for reporting this. This may have caused by #1898
Looking into this closely to figure out the exact reason.

@srikartati maybe the hack that was used to ensure correct restart order between agent and aggregator?
please prioritize this so that PRs don't get stuck because of CI failures.

Flow aggregator starting with no sleep affects only its yaml, but in this case, flow aggregator started fine and the error is related to Antrea Agent not restarting again properly during TestFlowAggregator or after the test. Need to look at logs to see why Antrea Deamonset did not come up properly.
2021-03-13T06:14:01.9906449Z ##[error]    fixtures.go:160: Applying flow aggregator YAML with ipfix collector address: <IP_ADDRESS>:4739:tcp
2021-03-13T06:14:05.3566800Z ##[error]    fixtures.go:172: Deploying flow exporter with collector address: <IP_ADDRESS>:4739:tcp
2021-03-13T06:15:36.9364958Z ##[error]    flowaggregator_test.go:110: Error when setting up test: error when restarting antrea-agent Pod: antrea-agent DaemonSet not ready within 1m30s
2021-03-13T06:15:36.9368127Z --- FAIL: TestFlowAggregator (99.91s)

Tried to reproduce this locally to get hold of agent logs when the error has occurred, but I was not successful even after running multiple times. Artifacts in tests do not seem to store the logs when the error has occurred on both kind and Jenkins runs. I was thinking of doing dummy PR and turning on logsExportOnSuccess to fetch logs for CI runs. Any better ideas on saving logs?

By dumping the describe output when error happens, I see that the antrea-agent container goes into crashloopbackoff state and doesn't start again :
Warning  Unhealthy  5s (x8 over 75s)  kubelet, antrea-e2e-for-pull-request-2200-5g9kg  Readiness probe failed: Get "https://localhost:10350/readyz": dial tcp <IP_ADDRESS>:10350: connect: connection refused
I think the root cause is the non-availability of correct certificates related to flow aggregator service when the antrea agent restarts. This is caused by a code change related to fetching certificates in agent in PR #1714. Adding the fix now and doing testing to confirm.

Log prior to the crash shows that DNS resolution error:
E0317 02:49:02.724945       1 process.go:116] Cannot the create the connection to the Collector flow-aggregator.flow-aggregator.svc:4739: dial tcp: lookup flow-aggregator.flow-aggregator.svc on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:40549-><IP_ADDRESS>:53: i/o timeout
E0317 02:49:02.727441       1 exporter.go:195] Error when initializing flow exporter: error when starting exporter: error while initializing IPFIX exporting process: dial tcp: lookup flow-aggregator.flow-aggregator.svc on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:40549-><IP_ADDRESS>:53: i/o timeout

Backtrace that caused the agent to crash is following:
goroutine 500 [running]:
k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
	/go/pkg/mod/k8s.io/apimachinery@v0.18.4/pkg/util/runtime/runtime.go:55 +0x10c
panic(0x1c24a20, 0x2e159c0)
	/usr/local/go/src/runtime/panic.go:969 +0x1b9
github.com/vmware-tanzu/antrea/pkg/ipfix.(*ipfixExportingProcess).CloseConnToCollector(0x0)
	/antrea/pkg/ipfix/ipfix_process.go:53 +0x22
github.com/vmware-tanzu/antrea/pkg/agent/flowexporter/exporter.(*flowExporter).Export(0xc0009012c0)
	/antrea/pkg/agent/flowexporter/exporter/exporter.go:198 +0x1ff
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0xc000996c10)
	/go/pkg/mod/k8s.io/apimachinery@v0.18.4/pkg/util/wait/wait.go:155 +0x5f
k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0xc000996c10, 0x2126e20, 0xc00087ce70, 0x1, 0xc0000abb00)
	/go/pkg/mod/k8s.io/apimachinery@v0.18.4/pkg/util/wait/wait.go:156 +0xad
k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc000996c10, 0x3b9aca00, 0x0, 0x1fa2c01, 0xc0000abb00)
	/go/pkg/mod/k8s.io/apimachinery@v0.18.4/pkg/util/wait/wait.go:133 +0x98
k8s.io/apimachinery/pkg/util/wait.Until(0xc000996c10, 0x3b9aca00, 0xc0000abb00)
	/go/pkg/mod/k8s.io/apimachinery@v0.18.4/pkg/util/wait/wait.go:90 +0x4d
created by github.com/vmware-tanzu/antrea/pkg/agent/flowexporter/exporter.(*flowExporter).Run
	/antrea/pkg/agent/flowexporter/exporter/exporter.go:184 +0x85

The reason is with the code for checking the interface to be nil. The interface is not nil, even though the object typecasted by the interface is nil. This led to illegal check and crash. Fixed it using reflect package.

Summarizing the fix here: There are two bugs here.

Eetching certificates right before connecting to the flow aggregator service during the retries.
If there is any issue is creating an exporter connection to the flow aggregator (because of prior bug or unavailability of service leading to DNS failure). This leads to Antrea agent crash.

Fixed those in #1959


Publish dependency changes to event queue

Also we should merge your other PR merged first so that the CI can pass here.

@Druotic @austinkelleher pls review.


[Bug] Model, sprite still display after delete object in edit mode (disappear when play and stop)

Fixed in build#188


Real-time notification

#2186 Real_time_notification app
Close #2186
Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

@pranjay-poddar  I am pushing project second time by creating new branch but still it shows old commit also, can u give some suggestion for this suggestion.

Two diff projects are raised in one PR


autocomplete for tools

I really like the ability to call any tool from powershell.
It would be nice to have autocomplete when using exe's whithin a powershell script
for example:
git clone https://github.com/PowerShell/PowerShell.git -branch master
it would be nice it after typeing git clone https://github.com/PowerShell/PowerShell.git - and tab it would complete to branch (or another option).
A possible implementation could be to create wrapper functions for each exe methods.
for example:
function git-clone {
	param(
		[ValidatePattern('(?:git|ssh|https?|git@[\w\.]+):(?:\/\/)?[\w\.@:\/~_-]+\.git(?:\/?|\#[\d\w\.\-_]+?)')]
		[Parameter(Mandatory=$True, ValueFromPipeline)]
		[string]$giturl,

		[alias('b')]
		[string]$branch
	)

	$expression = "git clone $giturl"

	if($branch){
		$expression += " -branch $branch"
	}

	if($noHardlinks){
		$expression += ' --no-hardlinks'
	}

	#Invoke-Expression $expression
}

this could be a project like https://github.com/DefinitelyTyped/DefinitelyTyped that is used just for autocomplete

See https://github.com/lzybkr/TabExpansionPlusPlus/.  And for Git specifically, checkout posh-git. It is in the PowerShell and at https://github.com/dahlbyk/posh-git.  Wait for 0.7.0 to release though.  Should be out by the end of the week.

I didn't totally understand how this works but it seams to me like this is for more advanced scenarios where I would want to have autocomplete based on used parameters and more, instead of having the same completions  for the command no matter what.
The learning curve for a  wrapper for an exe is extremely low since the only thing needed is to go over the exe's available parameters.

@Meir017 I think you're looking for TabExpansionPlusPlus here. I don't think it makes a lot of sense for PowerShell itself to go implementing all native EXE parameters: even we wanted to maintain a massive database of all native binary parameters (we don't), many are contextual anyway (the problem posh-git and TE++ work to solve).
That being said, I know I've briefly discussed with @lzybkr the possibility of parsing man pages on Linux to provide some automated propagation of IntelliSense (which would be really cool with PSReadline Tooltips that show the description, or in VS Code, but I don't think anyone is planning to do that work any time soon.

I did that for git, i.e. scraped the html pages of the help and generated the completions for the common commands.
But there will always be manual work to figure out the contextual completion that is needed to make completion really useful.

Makes no sense  to maintain a massive database of all native binary parameters but perhaps it makes sense to think about how to provide a simple mechanism for third-party providers to add their own additions to Intellisense by means of .ps1xml and .psd1.
It would also be good to have a standard for the description of the parameters through a APIs or/and manifests. Then we could get everything we need in the native way on both platforms.

I think the best we can hope for is something like this.
The idea here is to have a framework for command line tools that is capable of generating completions for your favorite shell, and then get everybody using your library.
This might be sufficient for many tools, but it would still require lots of work for advanced uses like completing branch names for git.

I think sufficient enough and pretty cool option would be if we had some possibility to use bash scripts for tabcompletion in powershell.
There are tons of bash scrips for tab completions (for example bash_completion) and many command line tools if they provide tab completion then it's almost always at least bash (and sometimes zsh), for example, angular cli, docker-compose, npm.
I have no big experience and knowledge how bash and powershell tabcompletions works but this is the idea for implementation I had in my head:
In Register-ArgumentCompleter script block call bash and ask it what it would complete (there must some function for it) and then provide that completion to powershell. On Windows we could use WSL on linux just call bash.

It would be really helpful if PowerShell Core had support for bash-completion scripts - at least on Linux.

https://www.powershellgallery.com/packages/PSUnixUtilCompleters leverages existing bash-completers and zsh-completers.  I don't think there's any additional specific work we'd do here.  I would recommend contributing to TabExpansionPlusPlus for any native utils that aren't covered by bash-completers.


CloudWatchReporter is tightly coupled with ScheduledReporter

CloudWatchReporter has a lot of great functionality, like the dimension support, but it currently extends ScheduledReporter, so there's limited control over when metrics are published to CloudWatch. I'd like to break out the functionality to publish metrics to CloudWatch into a separate class that can be composed with a ScheduledReporter subclass, but also used standalone.
That way I can use the standalone class to report metrics on a per-request basis. I need this for a serverless application I'm working on since I can't rely on the container continuing to exist and would instead like to create a new MetricRegistry for each request and then publish any metrics collected at the completion of that request.
I've forked the repo and intend to make this change myself and send a PR, but I'm opening this issue to discuss the best way to do this.

Ideally I'd just change CloudWatchReporter to no longer extend ScheduledReporter and just implement Reporter and work in a standalone way. Then I'd create a ScheduledCloudWatchReporter object that extends ScheduledReporter and have it take a CloudWatchReporter in its constructor and delegate to it in the report() override method.
However that change would not be backwards-compatible so that wouldn't be something I could send a PR for. A backwards-compatible approach would be to create a class like NonScheduledCloudWatchReporter or AdhocCloudWatchReporter (better name suggestions would be appreciated) and move most of the CloudWatchReporter logic there. Then update CloudWatchReporter to take that class in its constructor so it continues to work.
I'm going to code up that approach and send a PR when I have it working. Just wanted to post my thoughts on it since I'm new to the codebase. If you have comments or suggestions, or there's something I'm missing, let me know. Thanks!


Current package name doesn't show on vscode search

I realized this while trying to install the theme using the command ext install theme-levelup
The current name of the package is theme-levelup and with this name the theme does not show in the classical search on the visual studio interface.

This immediately changes when the name is changed as theme-level-up

I prepared a pull request for this, but wanted to first of all check with you as this will require an update of the name of the package and update on the vscode marketplace.
Edit: Sorry for the bad screenshots

Merged. Thank you!


fail to install in linux.

my input and output information:

npm install hexo-asset-image --save
<EMAIL_ADDRESS>/home/ziyuan/Program/Hexo
└──<EMAIL_ADDRESS>npm WARN optional Skipping failed optional dependency /hexo/hexo-fs/chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN optional Skipping failed optional dependency /hexo/nunjucks/chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN optional Skipping failed optional dependency /hexo-deployer-git/hexo-fs/chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN optional Skipping failed optional dependency /hexo-math/hexo-fs/chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>

I got these warnings while installing<EMAIL_ADDRESS>on linux mint using node v6.9.1, but it did finish installing:

npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

This is warning, just ignore it.
fsevents is only for macOS


feat: ^^ to run previous command

^^ should be used to run the previous command, so that for people lazy to copy paste when they have to add anything new to the command (example set a env variable then run command)

added in https://github.com/Hilbis/Hilbish/commit/b735421af89427e6e819abe7750d1ef77c1583a0


Functions on mapped object types with inlined computed keys don't infer correctly

Bug Report

🔎 Search Terms

object type, type inference, mapped type, computed keys
🕗 Version & Regression Information
Issue occurs in the same way on  all TS versions in playground.
Tested on all from ver 3.3 -> 4.9.5 -> Nightly

This is the behaviour in every version I tried, and I reviewed the FAQ for entries about Type System Behaviour

⏯ Playground Link

Playground link with relevant code
Further information and discussion from my StackOverflow question.
💻 Code

type Original = { foo: 'expects a string literal', baz: boolean, bar: number }
type Mapped = {
  // we're mapping the keys of Original to functions whose argument and return types are
  // the same as the value types for Original
  // so for `bar: number`, we map to `bar: number => number`
  [prop in keyof Original]: (arg: Original[prop]) => Original[prop]
}

// This function is technically redundant, but helps illustrate the bug
// the `propName` type should be the literal string
const propSelector =  <propName extends string>(propName: propName): propName => propName;

// Will just be the string 'bar'
const barKey = propSelector<'bar'>('bar');

const workingTestObject: Mapped = {
  foo: (arg) => 'expects a string literal',
  baz: (arg) => true,
  // works just fine referencing the computed key as a const ,
  // `arg` infers to `number` as it should
  [barKey]: (arg) => 51345
}

const unexpectedlyFailingExample: Mapped = {
  foo: (arg) => 'expects a string literal',
  baz: (arg) => true,
  // unexpected type check error: `arg` is implicitly `any`?  But return type is fine?
  // even though they should both be the same type.
  // Expected behaviour should be identical to the 'barKey' example in 'workingTestObject',
  // so `arg` should be inferred as `number`
  [propSelector('bar')]: (arg) => 51345
}

🙁 Actual behavior
When an object with a mapped type has a computed property key whose expression is inlined (e.g [returnsSomeKey(arg)]: etc), when the value is a function with a mapped argument type, typescript fails to infer it and reverts to any, but simply assigning the expression to a const (e.g const someKey = returnsSomeKey(arg)) and referencing the const as the key (e.g [someKey]: etc) works just fine, and the argument type is properly inferred.
🙂 Expected behavior
The behaviour should be the same for either inlining the computed expression or assigning to a const and referencing it as the key, that is, the argument type should be inferred correctly in both cases.  This is because both cases are effectively equivalent, and should be equivalent as far as the type checker is concerned. It seems that the inlined computed key is resolved in a different order than in other cases, perhaps?

There might be some subtle reason this is harder than it looks, but given that barKey works I can't think of one.

Yeah, logically one would think it to be fairly straight forward, but this bug being a thing feels like there is a much more complex system than you'd expect, perhaps to do with the order at which certain kinds of expression are inferred or something like that.

@RyanCavanaugh if one wanted to go looking for it (particularly one without previous experience messing with the type checker), where would you suggest as a starting point/points?  I had a perusal through the structure to see if anything obvious stood out, but there is a lot in there!

This is already fixed by https://github.com/microsoft/TypeScript/pull/51915 and awaits review 😉

Wow, that was fast.  You're amazing @Andarist :) thank you for that fix, and thank you to the TS team for merging it!


ARROW-4192: [CI] Fix run docker compose

rebased

We should probably port gen_apidocs to the top level docker-compose and remove these.

I might take a look next week for getting rid of dev/docker-compose.yml.
https://issues.apache.org/jira/browse/ARROW-4309
https://issues.apache.org/jira/browse/ARROW-4405
https://issues.apache.org/jira/browse/ARROW-4415

@kszucs I think this can be merged.


Multiple worker creation is legal

Hello
I have been using G3log for my project. Really good job, the code is really beautiful (the way you got things done). Just wanted to know the use case of the worker thread. Reading through your code I thought the Worker thread is supposed to be singleton, as the otherwise doesn't make sense to me (multiple worker writing to sink?). I could do the following and observed 5 thread: (main + 2 + 2)
int main()
{
std::unique_ptr logworker {LogWorker::createLogWorker()};
std::unique_ptr logworker1 {LogWorker::createLogWorker()};
auto sinkHandle = logworker->addSink(std2::make_unique(), &MySink::SendMessageToMySink);
auto sinkHandle2 = logworker->addSink(std2::make_unique(), &MySink::SendMessageToMySink);
  initializeLogging(logworker.get());
  initializeLogging(logworker.get());

}
Maybe you are missing the std::once before doing new LogWorker? Would really appreciate some light on this.
Thanks
-R

Did you really call initialize logging twice?
There is a CHECK in g3log.cpp so that if you call initialize logging multiple times there's a FATAL exit.
CHECK(!internal::isLoggingInitialized());
Apart from that, yes you can have as many sinks as you want. You can also have as many background workers as you want, but only one can be used to dispatch the LOG calls (the one that is initialized). Only the sinks that are attached to active "ref: initializeLogging(...)" will see the LOG calls.
The background worker has a log message dispatching thread that it sends to the sinks. Each sink is powered by its own Active object (no CPU used unless there is work to do).

There are reasons why you might want to use a sink by itself. For example doing some custom logging outsides of the g3log API of scope. However in that case it is likely better to use Concurrent<T> instead of g3::LogWorker (ref: https://github.com/KjellKod/concurrent)

I confirmed that there was a initialization/shutdown bug if initializeLogging was called multiple times. At some point a while back the CHECK(...) call in the initialization triggered a deadlock instead of a fatal exit.
I have changed that in https://github.com/KjellKod/g3log/pull/94

The only issue here was the deadlock that could happen when calling initializeLogging(...) twice.
That was resolved in https://github.com/KjellKod/g3log/pull/94

Thanks for the explanation! :)


Align menu icon to middle

Fixed by https://github.com/razonyang/hb-base/commit/34700f30d06dc9ba52d3a6873db568003e61b7b6


Cannot open markdown link, Plugin conflicts

Description
Cannot open markdown link. The real cause of the problem is a conflict between burodepeper/language-markdown and atom/link
Steps to Reproduce

Install this plugin -> https://github.com/burodepeper/language-markdown
Install this plugin -> https://github.com/atom/link/
Make sure both plugins are enabled at the same time
Create and open a new markdown file
Add link , for example

source : <https://github.com/GitbookIO>

[GitBook on GitHub](https://github.com/GitbookIO)

<https://github.com/GitbookIO>

[testLink1](https://github.com/GitbookIO)

Save file
Use command pallet to run link: open

Expected behavior:
Link opened in default browser chromium.
Actual behavior:
Nothing happens, no error, nothing.
Reproduces how often:
Always when both plugins are enabled at the same time.
Versions
Atom    : 1.22.1
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0
(node:24571) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
apm  1.18.11
npm  5.6.0
node 9.3.0 x64
atom 1.22.1
python 2.7.14
git 2.15.1
OS Manjaro Linux , everything is latest and up to date
Additional Information
https://github.com/atom/link/issues/24
This issue was opened by me, it was closed because it did not provide enough information. I did not provide information because I thought markdown links are not supported by this plugin and developer will understand. The real cause of the problem is a conflict between burodepeper/language-markdown and atom/link
https://github.com/atom/link/issues/23
This issue was opened by another github user , it was closed because user was not able to provide enough information about the cause of this problem.

This is an issue with language-markdown: they need to scope links as markup.underline.link for this package to recognize them.


Remove "use strict" from blockly_compressed.js

Its presense for some reason breaks apps tests

This PR is necessary for https://github.com/code-dot-org/code-dot-org/pull/10794 to pass unit tests


Could you provide GPT-distilled weights of LLaVA and Qwen-VL ?

Thanks for your great work! Could you provide GPT-distilled weights of LLaVA or Qwen-VL?

Hi, thanks for your interest in our work. Which benchmark do you need checkpoints on? In fact, the iter0 in our self-training will provide the GPT-distilled weights of LoRA.


filebox throws exception when shown

Trying to run the example code from:
http://nanapro.org/en-us/documentation/utilities/filebox.htm
I get unhandled exception:
throw std::runtime_error("The revert is not allowed");
from:
window_manager.cpp
caused by the example code line:
if (fb())
Using Windows 10 and Visual Studio 2017
Works fine with Visual Studio 2015

Thanks for reporting issue. I will review the issue.

Updated missing link to the example code

Hi,
confirmed the bug and the fix seems to works.
I finally installed VS2017, see
https://developercommunity.visualstudio.com/content/problem/31844/error-0x80004003-installing-microsoft-visual-studi.html
and now the example compile and runs ok.

@qPCR4vir Thanks a lot for confirming this fix!

Every example compile OK with VC++v14.1 from VS2017 update preview. Run most of them - ok.

Fix works for me too


I don't think you have to go too far in this, as it is probably not the responsibility of  to fully train a user in StateMod, but since I think there is an implication that  is a portal to new users of StateMod, a little more help explaining its principles in the notebooks would be appreciated. I understand you are all probably experts in it so it is probably difficulty to identify what is implicit and what is not, so I will just list things I would appreciate explaining under this task as I identify them

From the original issue:
I see there is a river_id and structure_id in the model output file, which are the same. It seems these are the same as users? But maybe this is also the same as reservoirs? Are these four things always the same?
Maybe whenever you first mention a StateMod file type (e.g., .ddr) you could link to a description of that file type - though I can see that the description on their readthedocs is limited and when I go further in it just gets more complicated rather than clearer.. If you know where to find a good description probably link that otherwise those 'NOTE' blue boxes you have been using would be good.

In regards to the first comment: river_id and structure_id are the same, but this is not the same as reservoirs. We create functionality to preserve the whole output file in the .parquet file, but only utilize the "shortage" column. Much of the detail in the results file, especially for columns that aren't being used, is best left out of the notebook. However, we have gone through the notebooks and linked to the StateMod documentation for each StateMod file that is mentioned if the user wants to read more about the input and output file structures.


doc: Improve package.json

Pull Request Test Coverage Report for Build 430270057

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 428134438:
0.0%

Covered Lines:
252

Relevant Lines:
252

💛  - Coveralls


Making angular-translate available as a Visual Studio NuGet package also?

First of all, thanks for your effort in creating Angular Translate and also for keeping it moving forward. The company I am working for is using it for a big government project and we really appreciate the features is provides.
As you might have guessed from the title, having Angular Translate available as a NuGet package would be a good thing for us. Some folks out there have already published earlier versions in the past but the last version available over at NuGet is as old as 2.1.0 (https://www.nuget.org/packages/AngularTranslate/). I already tried to encourage a maintainer of one those repositories to update but to no avail as of yet.
Previous excess foam removed.
So my hope is that Angular Translate would claim a kind of an official channel over there too. Is there anything I can do to help you in making it happen?

+1. Would be nice to have an actively maintained and up to date NuGet Package. Also with an NuGet package dependent on the modular angular.core (or no dependency so that the user can choose) as already requested in #797

As already mentioned in #797, we are currently not able to provide this. Neither I'm willing to proceed with a developer-only-releasing solution (which actually does not work currently because I'm not working w/ windows and the mono solution is buggy for me), nor I have enough knowledge how to solve this automatically.
Right, any developer with "release permission" is able to make release publishing to npmjs.org, bower (actually GitHub) and GitHub itself. No other OS dependency, and no other tools than a npm install had included.

The author just updated the existing NuGet package to the latest version: https://www.nuget.org/packages/AngularTranslate/

I can confirm the package update and but it still has one small glitch. It appears that the angular-translate-storage-cookie.js file has somehow slipped through the cracks, so to speak.
The version of angular-translate-storage-cookie.js I got from NuGet on 20.01.2015 18:31 (GMT +02:00) contains the following header:
/*!
 * angular-translate - v2.4.0 - 2014-09-22
 * http://github.com/PascalPrecht/angular-translate
 * Copyright (c) 2014 ; Licensed MIT
 */

When using the cookie storage option with that one, the updated Angular Translate package fails with Uncaught Error: Couldn't use storage '$translateCookieStorage', missing get() or put() method!.
Although I managed to fix it manually, I sent a message about it to the author of the package also, I hope he will find the time to fix it.
I also discovered that at least in our scenario when migrating from 2.1.0 to 2.5.2, we had to register available languages with $translateProvider.registerAvailableLanguageKeys(); during the configuration phase. Without it, there was only a beautiful white screen with Uncaught TypeError: undefined is not a function		 angular-translate.js:182 written inside the console window.
Other than that, it's all good. Thank you very much!

angular-translate-storage-cookie.js is not part of the NuGet package. The AngularTranslate package only contains the core file (angular-translate.js), the AngularTranslate.LoaderUrl additionally the angular-translate-loader-url.js file.

Aah, my mistake then, apologies. You're right, the cookie storage file is not a part of the AngularTranslate package. Nor does it presently seem to be a part of any other one, so go figure.
But whatever the case may be, the updated 2.5.2 package itself seems to be working and at least for me that's good enough. Hence, for the time being, the problem is solved. Thanks!


Update winapi

Related: https://github.com/hniksic/rust-subprocess/issues/17

Have you tried building on Windows? On my machine updating winapi requires more changes in the code. I've now pushed commits that do that, and also move from crossbeam to the newer crossbeam-utils.


Reverting commit 8ef77a076472feb995b7c9690a534e2e6e749a75 to restore correct rendering for SoText2.

Reverting commit 8ef77a076472feb995b7c9690a534e2e6e749a75 to restore correct rendering for SoText2. fixes #384

Thanks for your comments Mario. My knowledge about glyph handling in Coin is very limited, so my first attempt was simply to revert the commit in question. But I agree that the code can and should be simplified. So do I understand you correctly, that all glyphs of a SoText2 will be either drawn with a glBitmap call (per glyph) or by a call to glDrawPixelBuffer (for the combined glyphs in the pixel_buffer)?

Yes, that's how it works. While the original implementation drew the text glyph by glyph (and potentially toggled between glBitmap and glDrawPixelBuffer), I refacored it (starting with commit 609653f, pull request #275) to first copy all non-monochrome glyphs into a pixel buffer and render it in one step at the end. However, I did not change the rendering of monochrome glyphs, because fonts are usually grey-scale today and I did not want to implement all the necessary bit operations to copy the monochome bitmap into the pixel buffer.
That's why the original implementation needed "didenableblend", but the latest version does not.


Eval a line of code without resetting the interpreter?

So I was writing some bindings to control Arduino functions with this, and thought it would be really cool if you could do something suspending a running interpreter, evaluating a line of code, and then returning to normal execution.
This would let you interact with a running program during development, change variables, etc, and would be great for using it like the early home computers that you used through a BASIC prompt.
Is this possible with the current API?

The interpreter is not designed to work as REPL, but it's possible to load and run without resetting the interpreter, eg:
int main(int argc, char* argv[]) {
	struct mb_interpreter_t* bas = 0;

	mb_init();

	mb_open(&bas);

	mb_load_string(
		bas,
		"n = n + 1\n"
		"print \"entry \", n;\n",
		false
	);
	mb_load_string(bas, "a = 22", false);
	mb_run(bas, false);
	mb_load_string(bas, "b = 7", false);
	mb_run(bas, false);
	mb_load_string(bas, "c = a / b", false);
	mb_run(bas, false);
	mb_load_string(bas, "print c;", false);
	mb_run(bas, false);

	mb_close(&bas);

	mb_dispose();

	return 0;
}

You would see each mb_run is a top-down execution with previous values reserved in the variables. Although this is not reentrant.
It's also possible to inspect variables with the mb_debug_get and mb_debug_set API, if this was the only interaction you were looking for.

Oh thanks! Those 2 APIs actually do cover 90% of what I'd like to do interactively.
I started working on a fork to allow multiple parsing contexts and stacks per interpreter, so you can load multiple "threads" (probably with a python style GIL ) and do traditional reentrant REPL, but that's a fairly big project.

Nice work! I appreciate your efforts, and I believe it would help others a lot.
Here's the dev roadmap:

Releasing current v1.2
Rewriting a new kernal as v2.0

So for the current branch, it's kinda feature-frozen. But it inspired me, I would consider adding REPL for v2.0.
I prefer to keep this open so others will find.

Awesome! I'll probably be following this project for a while, I'm using it to allow remote code updates on an open source IoT platform I'm doing, and I might try to port it to a handheld game console at some point.
It's a great language! Definitely one of the easiest to embed interpreters out there, and it doesn't use too much RAM on embedded systems.

Thanks! Looking forward to your sharing of your creations.

it's such a shame there is no REPL :(


1.2 - Modify gene plots

changes to add full gene plots to datatables container
allows for searching and scrolling in fixed window
deferred rendering enable hundreds of plots in report and only renders first 3 on initial load => doesn't break on big panels
reduced file size of each plot by ~60% through dropping dpi and making plots transparent
example report at bottom of page here: https://cuhbioinformatics.atlassian.net/wiki/spaces/P/pages/2216230925/Development

Hello @jethror1! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file bin/coverage_report_single.py:

Line 314:80: E501 line too long (80 > 79 characters)


CI: Add workflow to update NOTICE file

Description
This pull request updates the NOTICE file based on the FOSSA analysis. The FOSSA CLI is used to analyze the project and generate an updated NOTICE file. The changes include including unused dependencies and generating attribution information. For more details, please refer to the FOSSA analysis report at FOSSA.
Action items

It requires FOSSA_API_KEY API token be to added and add them as secrets to be consumed by GitHub Action. (ref docs)

It requires a FOSSA subscription (see ref)

References

fixes #1319
Review Checklist

[x] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[ ] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

Tests are failing, flaky? 🫠

I need to create a service account for OpenFGA so that we can create a token for it in FOSSA. Hang tight...

@willvedd, As you can see in logs, issue is with permission, I would suggest to create PAT token from admin's account (so it has the correct permissions)

@Siddhant-K-code thanks for your reply. The token needed must be created in FOSSA, not Github. I already got in touch with FOSSA support :)


Advanced HTTP template status check mechanism: pass/fail templates based on condition

Summary
What change needs making?
Support something like successCondition and failureCondition in HTTP template
Use Cases

status code allowlist
check content in response
...

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@sarabala1979 do we support this already? Is there a work around? If not, seems like a neat enhancement. Maybe we could add a condition: resp.statusCode == 300 && asJson(body).foo.bar = 'yes'?

We don't support it and in fact I had already worked on a PoC for this when I was working on #7113. I'll take this one


Add Holiday Names in German language

I don't know why the tests are not passing. I'll try it tomorrow during the day..


Add a Gitter chat badge to README.md

Xercoy/blobs now has a Chat Room on Gitter
@Xercoy has just created a chat room. You can visit it here: https://gitter.im/Xercoy/blobs.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Coverage remained the same at 86.822% when pulling 986459ed3f5f364e6c7715c2758b7c143ad2963d on gitter-badger:gitter-badge into 209c75e1a398d511e18e9710c311b5162a29be30 on Xercoy:master.


A potential redundant call to X509_free()

I find a potential redundant call to X509_free in OpenSSL-1.1.1m, which is in function execute_test_large_message (./test/sslsaptest.c)
Specifically, at line 754, variable 'chaincert' is freed by X509_free() when SSL_CTX_add_extra_chain_cert fails. However, variable 'chaincert' is freed again at line 774. We believe that the call to X509_free at line 754 is redundant. Directly removing it can fix the issue.
 707 static int execute_test_large_message(const SSL_METHOD *smeth,
 708                                       const SSL_METHOD *cmeth,
 709                                       int min_version, int max_version,
 710                                       int read_ahead)
 711 {

 ...

 753         if (!SSL_CTX_add_extra_chain_cert(sctx, chaincert)) {
 754             X509_free(chaincert);
 755             goto end;
 756         }

 ...

 773  end:
 774     X509_free(chaincert);

 ...

 781 }

I am looking forward to your confirmation.
Best,
Wentao

No, the code is correct as it stands. This particular failure occurs just after an "up-ref" of chaincert:
        if (!X509_up_ref(chaincert))
            goto end;

After a successful call to X509_up_ref() there are 2 references to the X509 object held by the test code. One of those references is immediately passed to, and owned by, the SSL_CTX object via the call to SSL_CTX_add_extra_chain_cert. However in the event that that call fails then the test still retains 2 references to the X509 object and so needs to call X509_free twice.


Unique index on DateTime

When i add unique index to DateTime field type i get this error when i use save method:
Catchable Fatal Error: Object of class DateTime could not be converted to string

Are you getting this in a migrate?
This can happen if you are setting a new DateTime object on the default property. The default property is used during a migrate to set the default value in the actual database. If you want a default DateTime object as the default value for new entities, use the value property instead. This does the same thing, but it does not translate to the database itself like default does.

No. I'm just building a new entitie $entity = $mapper->build(['date'=> new \DateTime($timestamp)]) and am trying to save it $mapper->save($entity). While having unique key on that field it throws an exception.

Ah, so it's in the validation. Can you provide a full stack trace so I can pinpoint where the error is happening please?

same issue here. Mapper::validate query conditions are unconverted php values
 if (!empty($uniqueWhere)) {             foreach ($uniqueWhere as $field => $value) {                 if (!is_array($value)) {                     $value = [$field => $entity->$field];                 }                 if (!in_array(null, $value, true) && $this->first($value) !== false) {


PMB-07: Parallelize music downloading and transcoding

Problem:

The videos are loading synchronously
If one decides to load and transcode a lot of videos, all of them will be downloaded in order of submitting
This means, that if the internet is slow enough and the songs are short enough, there may be pauses between playing
Also, right now transcoding is being done in one thread, so we do not use all the resources

Solution:

Change the code so it will submit a task for downloading music to a separate worker

Changes:

Server

Which song should be played first? First downloaded or first added by user to the queue?

If the first downloaded song is first in the queue, the songs will start faster, but only the first song, since generally song download time is significantly less than song playback time.
If the first added song is the first in the queue, there can be bottlenecks during the first song download and/or transcoding of really long songs on low powered hardware, but the queue will be more honest.

Looks like telebot handles commands from users in sequential way. Solutions:

Rewrite everything in python-telegram-bot, which supposedly can parallelize
Stumble about some more


fixes #16

Transforms are now applied to new groups if a path or element has already been drawn in a given group.

@clintjd if you merge in, don't forget to update the gh-pages branch to bump the version :)

@gwwar i committed the change to index.html and readme.md. is that correct?  thanks!

Yup! If you ever need to update the demo page at http://gliffy.github.io/canvas2svg/ it lives on the gh-pages branch: https://help.github.com/articles/creating-project-pages-manually/


addField type browse file restriction

Hey
I'm new to Backpack and I'm having a great time not reinventing the wheel :). I have this code in one of my CrudControllers:
    $this->crud->addField([
        'name' => 'file',
        'label' => 'File',
        'type' => 'browse',
        'mimes_allowed' => '/jpeg' //Looking for something like this
    ]);

My question is how can i restrict file types allowed to upload? Lets say i want user to be able to upload only 'jpeg' or 'mp3'. How can i achieve that?
I've looked up 'vendor/backpack/crud/src/resources/views/fields/browse.blade.php' to set the restriction there but the input use is of 'text' type not 'file' type.
Anyways a big thanks to contributers of this awesome package. peace.

You can of course write your own "upload" field type (take a look at custom field types in the doc)
Or you can hook into the store (new) and update functions inside your WhateverCrudController.php to validate the uploaded files and deny them if they don't comply with your requirements, something along the lines...
public function store(StoreRequest $request)
{
	if (!$this->validate_upload()) { /* Custom function that validates uploaded files mimes */
		return \Redirect::back()->withErrors(\Validator::make(\Input::all(), [])->getMessageBag()->add('tutorias', 'Incorrect file type on create!');)->withInput();
	}
	$redirect_location = parent::storeCrud();
	return $redirect_location;
}

public function update(UpdateRequest $request)
{
	if (!$this->validate_upload()) { /* Custom function that validates uploaded files mimes */
		return \Redirect::back()->withErrors(\Validator::make(\Input::all(), [])->getMessageBag()->add('tutorias', 'Incorrect file type on update!');)->withInput(); }
	}
	$redirect_location = parent::updateCrud();
	return $redirect_location;
}

I knew my question was rather noobish but i was frustrated last night about this. Thank you for your response. I wish you a very good day.

Although i still think mime filter should be added as an extra option. like:
$this->crud->addField([
    'name' => 'file',
    'label' => 'File',
    'type' => 'browse',
    'mimes_allowed' => '/jpeg' //Looking for something like this
]);

No noobish questions, just a desire to learn, that's great.
If you want that, you need to create a custom field type; and even doing so, you'll still have to create a validation, as you can't trust every browser out there to follow your specifications.

Its not a complete solution but in the request validation u could do something like this in the rules function:
public function rules()     {         return [              'file' => 'ends_with:.jpeg,'         ];     }
and in the messages function u could do:
public function messages()     {         return [             'file.ends_with' => 'Icon type must be jpeg'         ];     }


Add NFT Vending Machine to Builder Tools

Fixes https://github.com/cardano-foundation/developer-portal/issues/651 (cc @thaddeusdiamond @matiwinnetou)

Thanks for this guys! Didn't even know it was going on, happy to answer any questions.  Also thinking about taking this through Catalyst so let me know if you have any suggestions for that process.
And to the comment on #651 I went to business school and switched to prod mgmt hence the dormancy lol.

@thaddeusdiamond: thinking about taking this through Catalyst so let me know if you have any suggestions for that process.

Following along with at least the weekly "Town Hall" slides may be a burden but was a big part of our project's success in Fund 9: it's a bureaucratic scheme so proposers seem to do much better if they pay bureaucratic attention and follow all requirements to the letter.
Also in Fund 10 there is now a major assessment category for "Value for Money" which it seems like your tool can easily demonstrate... so you should demonstrate it in your proposal with lots of real-world scenarios about how people & the Cardano community can leverage your software to save money and build up new business propositions more economically. 🤠


Changes made --- yet not able to push changes

Hi Roland,
Got a new laptop and installed everything. Changes have been made to this project and have commited them in GitHub Desktop for Windows, yet when I choose Pull Request to join with Master, it tells me I don't have permission.
My branch is called "make-it-work-with-MSVC".
This is my first experience wiuth using GitHub for "group development" so please give me a small push here so I can share the changes...
Regards,
Juan Dent

Hi Juan,
The normal procedure is for you to fork the repository you want to contribute to, make your changes and then to create a pull request. See for instance: https://help.github.com/articles/using-pull-requests/
Best,
Roland
PS: Looking forward to seeing your changes.
PPS: Please try not to "hijack" other threads. I am going to remove your messages from the sybase thread as they are not related.

Sorry for "hijacking"
Thanks for the link - will look into it✌🏽
Juan
Sent from my iPhone

On Apr 23, 2016, at 12:41 AM, Roland Bock<EMAIL_ADDRESS>wrote:
Hi Juan,
The normal procedure is for you to fork the repository you want to contribute to, make your changes and then to create a pull request. See for instance: https://help.github.com/articles/using-pull-requests/
Best,
Roland
PS: Looking forward to seeing your changes.
PPS: Please try not to "hijack" other threads. I am going to remove your messages from the sybase thread as they are not related.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub


what happens when runtime is set to gpu?

does it use nvidia drivers and cuda, or in backend does it use issac-ros2 packages or something?

it’s for running simulation with gpu


optional --ll-exception flag during testing

I've been using this to track down a problem with a compiled module (panda-test XML::Query failing but prove -e 'perl6 -Ilib' /t passing), although there may be a better way to implement it other than setting env PANDA_LL_EXCEPTION=1

Closing this for now, will try to solve it in some general way in #186