openapiPath directory resolution

Interestingly, the openapiPath doesn't work if I just provide a raw string (relative to the root of the repo directory). I have to this to make it work:
module.exports.plugins[0][1].openapiPath = require.resolve(module.exports.plugins[0][1].openapiPath);

What kind of raw path is expected for it to work? Something like ../../../openapi.json?

require.resolve resolves the file to an absolute path

@bourdakos1 Is there some way to make it so if the import fails it tries again after using require.resolve?

@avaidyam I updated how we import the OpenAPI definition, so you now provide a raw string relative to the siteDir. Does this resolve your issue?
- openapiPath: require.resolve("./examples/openapi.json")
+ path: "examples/openapi.json"

I think this should work! Thanks.

@bourdakos1 Actually, could you please create a new release so that I can test this out?

There’s a few breaking changes in master so I want to wait a little bit longer to make sure everything is finalized before cutting a release


Add hideShowToolbar() to onScroll()

Toolbar will hide and show as you scroll up and down. One quibble is that it obscures a bit of text on the side navigation menu.
Edit: I fixed the obscuring. The secondary nav now resizes when needed on scroll.
Edit 2: I noticed that the search results don't go away if you scroll. I think maybe the toolbar should remain visible if there are search results. I'll look into it.

Code looks good, but I need to pull this down & build with a few projects to test it. I'll try to get to it this week, or next weekend at the latest.

Looks, great. Thanks!


QoS-class resource configuration

Problem:
Configuring qos-class features in containerd requres a custom containerd configuration template.
Solution:
Look for configuration files in default locations and configure containerd to use them if they exist.

Proposed Changes

If rdt_config.yaml and/or blockio_config.yaml exists, configure containerd to use them by specifying their paths in the generated containerd config.toml file.
The predefined file locations to check are (same directory as containerd configuration file):

/var/lib/rancher/k3s/agent/etc/containerd/rdt_config.yaml
/var/lib/rancher/k3s/agent/etc/containerd/blockio_config.yaml

Types of Changes

New Feature

Verification

Ensure generated config.toml does not contain any line similar to any of:
[plugins."io.containerd.service.v1.tasks-service"], rdt_config_file = "...", or blockio_config_file = "..."
touch /var/lib/rancher/k3s/agent/etc/containerd/rdt_config.yaml
Restart k3s
This should mean k3s fails to start, as containerd will exit due to an empty file not being a valid configuration.
Ensure the file reference exists in the config.toml file (in accordance with https://github.com/containerd/containerd/blob/main/docs/man/containerd-config.toml.5.md)

Testing

Not covered
Linked Issues

#8720

User-Facing Change

Containerd may now be configured to use rdt or blockio configuration by defining `rdt_config.yaml` or `blockio_config.yaml` files.

Further Comments

I'll try to look into why the build is failing on 32 bit arm. There doesn't seem to be any error message of value though.

As the failing armv7 build is not unique to this PR, I'll leave it for now.

arm flaked; merging


Starbase inclusion?

Page 95 of the command book includes Starbase talents. Now, it's perhaps not that useful to include them for creating a ship, but it may be nice to have them included in the overview list.
Although I suppose it may be possible to expand the starship creation to allow for starbases as well, given that they are essentially the same process.

Starbase talents were added to the list of talents with 16974cd2870feee41eef3e8dc6c424a1a0925569.


GameObjects added to Layers are destroyed twice on Scene shutdown causing crashes

Version

Phaser Version: 3.70.0

Operating system: Windows 10

Browser:

Description

Adding a GameObject to a Layer throws unhandled exceptions when the Scene they're added to shuts down (such as when transitioning to a new scene).
The Scene destroys the Layer, then the Layer destroys the Sprite which causes it to emit its DESTROY event. This event is caught by the Layer which removes the Sprite from its list as well as attempts to destroy it again because the Layer is being destroyed by the scene. The destroy attempted by the Layer throws an exception in Sprite.preDestroy when this.anims is null because it was already removed by the original destroy.
Example Test Code

https://codepen.io/crockergd/pen/RwvMxNG
The demo attempts to add a Sprite to a Layer, then transition to a different Scene which displays a small green square. Currently, the demo crashes while trying to stop the current scene. The demo completes successfully if the line adding SceneA's rect to the layer is removed, or if the Phaser dependency is set to a version before 3.70.0.
Additional Information

The exception thrown by the demo doesn't trace the source of the issue well, I've attached an image of a call stack from a debugger as well.

I'm having the same issue. But for me it only happens when I restart the scene (this.scene.restart()). If I switch to a new scene this is not a problem.

In case it helps anyone, my workaround is to run something like this before restarting the scene:
        for (let child of this.children.getAll()) {
            if (child instanceof Phaser.GameObjects.Layer) {
                child.destroy();
            }
        }

My example with an error and temporary fix (check the comments): https://codepen.io/valentoros/pen/VwRvGqW

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Impl time embedding

implement time embedding according to the paper.
The implementation of ODE time embedding is in section 3.3.
We should concatenate X_c and time embedding x_t along the time dimension.

@yzmyyff hey Kuang! thank you for the PR
so if you turn back the clocks, I had it this way at an earlier commit. however, I don't think this makes sense with relative positional encoding, not without introducing more complexity
that's why it got switched over to adaptive normalization methods, which a number of text to image works have used successfully

@yzmyyff the reason is because there should be no relative distance to the time token

Thanks for your reply.
You are right about sin pos embedding.
But the difference between the current implementation and the original paper is a bit confusing, have you considered adding an implementation that is the same as the paper?
The optimized implementation is specified by extra parameters, or something else called VoiceBox 2

@yzmyyff i don't think it is correct, so i'm just going to make a note of the differences in the readme (mainly the choice of rotary embeddings, as well as adaptive layernorm for conditioning on time)


Investigate libp2p concurrency issue when connecting peers with multiple addresses

It appears that there is a concurrency issue within libp2p when attempting to connect a node to another node using multiple addresses. We've seen this in both using libp2p directly (#2129) and IPFS to connect using libp2p (#2162).
The solution we've taken to ensure tests are stable is to use a single localhost address to connect to peers, but this doesn't allow libp2p to discover the best/most suitable connection to use.
We will ideally need to provide a minimal test case to upstream so that the issue can be resolved.

I've managed to produce a test case, which doesn't depend on any Bacalhau code (https://github.com/bacalhau-project/bacalhau/commit/55324ae91322cde010e3626cda0cfb385d7b5ee7) and the resulting test failure (https://app.circleci.com/pipelines/github/bacalhau-project/bacalhau/4549/workflows/53e2b6d0-a236-42a9-a151-8be550044fc9/jobs/59344). This test also fails locally for me when GOMAXPROCS=1 is set.


Create comments column in control mapping spreadsheet

[ ] replace Notes column with Comments column in xlsx file
[ ] add them to TTL output as rdfs:comment.
[ ] Clear out old "Notes" cell values as well.

@hack-sentinel
@netfl0 will update UI to render comments in another ticket.

OBE


lookup to <IP_ADDRESS>

Hello!
I turned the lancash around. If I request to the dns server of the lancache directly, the response is the cache's ip-address. However, if I do a forward on my primary dns server, the lancache responds with the ip address <IP_ADDRESS>
inetnum:         [<IP_ADDRESS> - <IP_ADDRESS>
netname:         UK-NGCS
org:             [ORG-FHL1-RIPE]
descr:           UK Next Generation Cloud Server (NGCS)
My primary dns server has a real ip-address.
When does the dns server lancaсhe respond with this address?
Thank you

This (non-obvious) issue is because *.cache.lancache.net (inappropriately IMO) resolves on the global Internet.
On your DNS server a Domain Override needs to be created for:

cache.lancache.net

Pointing to your lancache-dns server IP.
(lancache server <IP_ADDRESS>)
(non-lancache DNS server <IP_ADDRESS>)
Improper configuration:
C:\Users\SomeUser>nslookup uplay.cache.lancache.net
Server:  yakko.somelan.lan
Address:  <IP_ADDRESS>

Non-authoritative answer:
Name:    uplay.cache.lancache.net
Address:  <IP_ADDRESS>

Proper configuration:
C:\Users\SomeUser>nslookup uplay.cache.lancache.net
Server:  yakko.somelan.lan
Address:  <IP_ADDRESS>

Non-authoritative answer:
Name:    uplay.cache.lancache.net
Address:  <IP_ADDRESS>

Would be awesome if whomever owns/runs the webserver for cache.lancache.net would add a custom HTTP header pointing to lancache documentation or something giving those troubleshooting a clue bat instead of simply 404'ing every HTTP/HTTPS request. ):
Hope this post helps others scratching their head with this issue.


remove unnecessary synchronization

The map used to collect work does not need to be wrapped in a synchronized collection.
The map was being synchronized by 1) wrapping with synchronized collection and 2) synchronized on the map during access, only one synchronization method should be necessary,

Taking away the synchronized wrapper on the map also requires adding a synchronization block on remove which isn't currently being done, so without it the remove would be unprotected, See https://github.com/apache/accumulo/blob/7f49667f1347ba446d0f8e31271df8ba7ee48397/server/tserver/src/main/java/org/apache/accumulo/tserver/log/LogSorter.java#L127

Changing base brought in additional changes - closing and will resubmit new PR


Scrub synbiohub credentials from commit history

In GitLab by @bbartley on Oct 16, 2019, 11:13
Doh!  I accidentally committed the synbiohub user credentials in one of my utility scripts.

In GitLab by @jakebeal on Jun 8, 2020, 14:12
assigned to @mweston and unassigned @bbartley

In GitLab by @jakebeal on Jun 8, 2020, 14:13
@mweston The commit in question should be indicated by the date of the issue.  After scrubbing, please move to GitHub.

In GitLab by @mweston on Jun 8, 2020, 14:19
@tramyn can you add your additional history request to this issue?

In GitLab by @tramyn on Jun 8, 2020, 14:23
yep. I would like this credentials.json file removed from this repo's commit history.

In GitLab by @tramyn on Jun 12, 2020, 13:35
@mweston What is the current status of this? @jakebeal discussed moving intent parser from gitlab to github. I think this issue must be resolved before we can make that transition.
If this issue is close to completion, @jakebeal do you have a specific github organization or account you want intent parser to exist on?

In GitLab by @mweston on Jun 12, 2020, 15:09
@tramyn sure I can complete this today. Note that this will forcefully re-write history on the repository. Do you have any pending work in local branches that is not checked in? Please ensure everything is pushed and let me know when you're ready. I'll test locally in the meantime.

In GitLab by @jakebeal on Jun 12, 2020, 15:49
This should move into the SD2 GitHub organization.

In GitLab by @tramyn on Jun 12, 2020, 16:42
@mweston Please go ahead and perform a history rewrite. I have everything I need on my end to prepare for this change.

In GitLab by @mweston on Jun 12, 2020, 19:15
@tramyn done. GitLab still has a cache, so if you know the commit hashes, it looks like you can still view them here, despite having re-written all of the commits.
The GitHub mirror, however, does not have those commits, and properly shows the credentials files and password being scrubbed:
https://github.com/SD2E/experimental-intent-parser/commit/23a7f30c82ca768a27dfd99999cf9533b02dfd04
https://github.com/SD2E/experimental-intent-parser/commit/0fb0d0ef120cd1a00558d07a7f80b713579f8e0b
https://github.com/SD2E/experimental-intent-parser/commit/786436900726440c74f76657c48a0afe700a4470
So this, and the mirroring dependency, should be resolved. I'll work with TACC to clean up the GitLab issue (it looks like there is some sort of rake task we can run to clear the Redis cache here: https://docs.gitlab.com/ee/user/project/repository/reducing_the_repo_size_using_git.html#repository-cleanup)

In GitLab by @mweston on Jun 15, 2020, 13:19
If you haven't already done so, @tramyn, you and other developers working on this repo should clone a fresh copy of the repository and resume work from there.

In GitLab by @tramyn on Jun 15, 2020, 14:46
Thank you @mweston. From what I'm seeing, you have ported intent parser over to GitHub. This is wonderful! Thank you for doing this. I assume that when you mention to clone a copy of the new repo, this mean clone a new copy of intent parser from gitlab and not GitHub. Correct?
Also, is there an option to move GitLab issues to GitHub as well or do I have to manually recreate each issue?

In GitLab by @mweston on Jun 15, 2020, 15:16
Yes - re-clone from GitLab. The commit ids have all been replaced.
I will look into the GL -> GH issue migration.

In GitLab by @tramyn on Jun 16, 2020, 13:56
@mweston, I do not have the ability to delete branches on experimental-intent-parser github repository. Is this limitation due to me being a member and not an owner of SD2E organization?

In GitLab by @mweston on Jun 16, 2020, 14:03
@tramyn I am looking - is the delete icon (trash icon) grayed out? Does it give an error?

In GitLab by @tramyn on Jun 16, 2020, 14:05
@mweston nvm, I had to browse to find it.

In GitLab by @mweston on Jun 16, 2020, 14:08
OK good - I confirmed you do have write access to the repository.

This has been completed.


[TASK][UI] add new recurring job task - filesystem trim

What's the task? Please describe
Introducing 1 new recurring job task type:

filesystem-trim

Describe the items of the task (DoD, definition of done) you'd like

Please use a task list for items on a separate line with a clickable checkbox https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists

[ ] Support filesystem-trim in UI.

Additional context

https://github.com/longhorn/longhorn/pull/5520
https://github.com/longhorn/longhorn/issues/5186

cc @smallteeths

Verified pass in longhorn master (longhorn-manager 023dd3, longhorn-ui 5219e4)
This ticket verified in https://github.com/longhorn/longhorn/issues/5186#issuecomment-1567700522, thank you


endpoint for providing information about application

An endpoint for providing information about the application in json. Link to endpoint from homepage

Slack Name: omzi
Live Link: http://companyfiles.zuri.chat/info

I dropped a comment earlier about the fields needed

Slack Name: omzi
Link to PR: https://github.com/zurichat/zc_plugin_company_files/pull/205
Live Link: http://companyfiles.zuri.chat/info

Nice one. Please remove the info about issues and the repo - not relevant

Ok Mark 😅. Thanks for the feedback.


Bluetooth auto reconnect service

Motivation
Hi, after installing ChimeraOS, I was unable to connect my Xbox Series controller until I navigated to the bluetooth settings. It was very similar to this issue
Investigation
After searching the cause of this problem, it seems that a Bluetooth scan was triggered while navigating to the Gnome Bluetooth Settings, and disabled when leaving that page.
Later, I was able to reconnect my controller by using the command bluetoothctl -t -1 scan on without navigating to the bluetooth settings
Solution
This PR add a simple systemd service that periodically scan for previously connected Bluetooth devices
I am now able to automatically reconnect my controller in the following cases :

On startup even before the session is loaded
When I unplug & replug my bluetooth dongle
When my controller is disconnected due to idle or battery and I press the guide button

Mention
It seems that Bluez allow for periodic scans in the config via ScanIntervalAutoConnect & ScanWindowAutoConnect parameters (link).
This could be a way cleaner solution, but I was unable to make them work.
Hardware & Software

Xbox Series Official Wireless Controller
my bluetooth dongle (https://www.amazon.fr/dp/B09TT7SXHY?ref=ppx_yo2ov_dt_b_fed_asin_title)
NVidia Geforce 1080TI
ChimeraOS 47 (b88d2bf) [UNSTABLE]

Note
This is my first PR for Chimera so I may not have respected some design & architectural choice

Thanks for the work, I am a bit confused as to why this is necessary.
If the controller is paired, it should be able to autoconnect without this service.

It appears that Bluez don't support autoconnect for some bluetooth controller unless there is a bluetooth scan occuring. It was the case with the bluetooth dongle mentioned above.
However, I tried to run a fresh chimeraos with another bluetooth dongle (this one) and didn't got any issue
This service is a fix for controllers that need a scan for connecting devices

I see, so it is hardware dependent. Thank you.
I am not sure if it is a good idea to be scanning constantly like that. I will have to do some research and think about it.

@alkazar Have you had a chance to consider this further? I've had to implement it myself locally to resolve the same issue as there seems to be no other viable solution for me.
I implemented the following;
`[Unit]
Description=A service that periodicaly scan & connect for previously connected bluetooth devices
After=bluetooth.service
[Service]
ExecStart=/usr/bin/bluetoothctl -t 3 scan on
Restart=always
RestartSec=15`

I bought a pci bluetooth/wifi card and this problem has been resolved for me. It is hardware dependent as far as I can tell.
Maybe a nice compromise could be to add this service for the next release and keeping it disabled by default. We can also add an option to the web UI to enable/disable this service in case some user have this problem.
I can start working on that if needed @alkazar


I get « Abusefilter-warning-otrs » error when trying to upload

When I try to upload a file to Commons, I get this error:
« abusefilter-warning-otrs ». But it's weird because I was able to transfer one test image!
Now, if I look at the log files, I don't see any error message that could give me more precision as to what the detail of the problem.
What/where should I look?
Regards, Antoine

I've pinpointed my problem:
I was sending « {{PermissionOTRS|id=2019071810007699}} »
instead of « {{subst:OR|id=2019071810007699|reason=processing}} »
Is it possible to have a better error handling on this issue?
Regards, Antoine


how to send data has text or json from server side

how to send data has text or json from server side and how to receive that data in sw.js file

Hey @madhufeb this repo is for content of WebFundamentals - if you have questions, I suggest posting question to stack overflow or mailinglist, thanks ! :)


Attempting to apply multiple ACL rules to a port will crash faucet

If we do say this:

    interfaces:
        1:
            name: "port1.0.1"
            native_vlan: redcables
            acl_in: [protect_from_access, capture_all]

We will get this:

Jul 13 16:07:51 faucet.exception ERROR    Unhandled exception, killing RYU
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/faucet/valve_util.py", line 54, in __koe
func(*args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/faucet/faucet.py", line 387, in _handler_datapath
dp_id, discovered_up_port_nums)
File "/usr/local/lib/python3.5/dist-packages/faucet/valve.py", line 625, in datapath_connect
ofmsgs.extend(self._add_ports_and_vlans(discovered_up_port_nums))
File "/usr/local/lib/python3.5/dist-packages/faucet/valve.py", line 580, in _add_ports_and_vlans
self.dp.dp_id, all_port_nums, cold_start=True))
File "/usr/local/lib/python3.5/dist-packages/faucet/valve.py", line 762, in ports_add
acl_ofmsgs = self._port_add_acl(port_num)
File "/usr/local/lib/python3.5/dist-packages/faucet/valve.py", line 646, in _port_add_acl
for rule_conf in self.dp.acls[acl_num].rules:
TypeError: unhashable type: 'list'

https://github.com/REANNZ/faucet/pull/757
Adds pretty basic default type checking to config classes which now catches this at parsing time.


Improve @def

o = @def expr in addition to @def o expr
@def! o expr to update (add feature) existing o

@ocots side notes:

would be possible to provide an @def! macro to add things to a previously created ocp (with the correct type according to time / variable dependences)
not completely coherent with the fact that with the current global (= all at once definition) we infer these dependences (hence the type)

@ocots side notes:

would be possible to provide an @def! macro to add things to a previously created ocp (with the correct type according to time / variable dependences)
not completely coherent with the fact that with the current global (= all at once definition) we infer these dependences (hence the type)

You couls simply redo all the parsing since you have the model in ocp.model_expression.

You could simply redo all the parsing since you have the model in ocp.model_expression.
https://github.com/control-toolbox/CTBase.jl/blob/main/src%2Ftypes.jl#L1157

right, as you did for the REPL. but this only works for an ocp first defined abstractly, while it could be first defined using the functional API. BTW, I more and more think that we should keep the functional API more or less internal.

We could use this here: https://control-toolbox.org/OptimalControl.jl/dev/tutorial-basic-example.html#State-constraint

Yes. Always nice to avoid code duplication. There are other ways, though (working on expressions, strings, then parsing...) Keeping hereafter for further reference https://github.com/control-toolbox/CTBase.jl/issues/235


Python agent test fails when run against docker 1.7

in 1.6 if you did docker run foo, docker ps would should the image "foo:latest"
in 1.7 they changed it so always docker run X, docker ps will show X
so to make the tests works on 1.6 and 1.7 you have to pass in "foo:latest" in the req and assert "foo:latest" in the resp

This was just fixing a unit test. No QA based testing necessary really.


Support Tree Table in DataView

RHCLOUD-34946

enhanced the DataViewTable component to support displaying data in a tree table
added documentation
enhanced tests

Preview: https://react-data-view-pr-data-view-19.surge.sh

@Hyperkid123 made some cleanup. The issues should be resolved now, thanks!


Integrate USDT from Binance Smart Chain to Vortex

User Story
As a user, I want to off ramp my USDT from Binance Smart Chain to the off ramping currencies available on Vortex
Acceptance criteria

Update the Vortex flow such that it starts from Binance USDT
Show the "USDT" in the from dropdown
If the user starts offramping using USDT from Binance chain, then trigger network change if they are not on Binance chain.
USDT logo can be reused which is already added in #262

Note

Assumption: This ticket is for both frontend and backend changes, assuming configuration changes to the current setup
USDT token contract - 0x55d398326f99059fF775485246999027B3197955

@prayagd let's detail this ticket and keep in Being Prepared, to be moved to Ready in case there are no tickets for tech to progress. No partner dependency, all known variables here.

Hey team! Please add your planning poker estimate with Zenhub @ebma @gianfra-t @Sharqiewicz @TorstenStueber

This ticket is not ready and should not be picked up yet.

Update the Vortex flow such that it starts from Binance USDT
In reality we want to add this flow to the existing Polygon flow and don't want to replace it. So the question is how to switch between these flows and between networks? Is it similar to what we defined for Asset Hub? This would need to be defined in this ticket.

I took a quick look how it works on Uniswap:

No pre-select token when connecting wallet.  I can explore all tokens regardless of the current network in my wallet.
I do get the balance regardless of the network I am connected to.
I can also explore quotes without changing networks, no automatic reconnect.

Only when confirming, will ask the change of network, similarly to how we do now I think if the user is in the "wrong" one.

@ebma I would not change anything, it was regarding the comment above.
I think the description aligns with how Uniswap's UI works and that this is ready, but of course this is much opinion based.

@pendulum-chain/product is there a reason this ticket is not in Ready yet? Or is it blocked by the Asset Hub epic?


scalers

I get the same results with and without scalers. Shouldn't there be a difference?

Can you explain a bit more? I'm not sure I understand.


Error in manifest

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Flutter:

version
channel

Dart:

version

Additional context
Add any other context about the problem here.

Please explain the issue, so that I can help you here.


added iap template

📝 Changed routes:

/templates

(view full size)

Commit 9ed1627f466376e93d7bace8eced2871b7a64e86 (https://thirdweb-yu8iew8b5.thirdweb-preview.com).


Add document to trace Configuration DebugView during Startup

[EDIT by guardrex to add the metadata. @cnmade, please use the This page feedback button and form at the bottom of the topic, which adds the metadata automatically and pings the author. I'll add it manually to this issue, so no worries here.]
I am hardly to find the way to debug Configuration while development
here is my Startup.cs

 // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
        public void Configure(IApplicationBuilder app, IWebHostEnvironment env, ILogger<Startup> logger)
        {
            var _cm =<EMAIL_ADDRESS>            logger.LogInformation(_cm + " env:" + env.ToString() + " > " + env.EnvironmentName);
            logger.LogInformation(_cm + " configfile: " + (Configuration as IConfigurationRoot).GetDebugView());
            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }
            else
            {
                app.UseExceptionHandler("/Home/Error");
            }
            app.UseStaticFiles();

            app.UseRouting();

            app.UseAuthorization();

            app.UseEndpoints(endpoints =>
            {
                endpoints.MapControllerRoute(
                    name: "MyArea",
                    pattern: "{area:exists}/{controller=Home}/{action=Index}/{id?}");
                endpoints.MapControllerRoute(
                    name: "default",
                    pattern: "{controller=Home}/{action=Index}/{id?}");
            });
        }

And these code can print the configuration you were using on the console, It is very useful.

For summary , i use two key point to make this possible.

Inject logger for Configure method, to let it can log into console
Call IConfigurationRoot.GetDebugView() to dump the valid and the working Configuration file loaded into memory

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0eb4d762-3910-2c57-8741-3306c15537b6
Version Independent ID: ba2254a0-ea8e-9b28-e94b-edd0fc58c043
Content: Configuration in ASP.NET Core
Content Source: aspnetcore/fundamentals/configuration/index.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@cnmade Startup.cs hasn't been used since ASP.NET Core 5 and earlier, two versions back.
Why are you using Startup?

Tracing the loaded env and configuration during the boot time

If something wrong ,we check the startup log, we can know it.

We're not adding to Startup documents anymore.


Proper RUS translation

Proper RUS translation for all mod strings.

Merged, thanks for your contribution
I've just realised that there are some obsolete MCM options (or just translation strings) that I should remove


Bump pihole Docker image to v5.8.1 for FTL v5.8

Thanks for the PR!  This is a dupe of #77 - we're just waiting for the new version to bake for a few more days before merging.

Yikes! Apologies. I completely forgot to check for other PR's first.

No worries!!  Reminders are always appreciated, so thank you!


Add --path flag

This change allows us to provide a directory for creating and loading both corral.json and dep-lock.json files. It affects most commands as they mostly need to load the file before doing their job. So, from now on, we can pass the --path "path/to/the/bundle/dir/" argument.
corral[master] % mkdir tmp
corral[master] % corral init --path tmp

init: from dir tmp
INFO: Created bundle in /Users/ordepdev/Work/corral/tmp
FINE: Going to write /Users/ordepdev/Work/corral/tmp/corral.json
INFO: Writing /Users/ordepdev/Work/corral/tmp/corral.json
FINE: Going to write /Users/ordepdev/Work/corral/tmp/lock.json
INFO: Writing /Users/ordepdev/Work/corral/tmp/lock.json
INFO: init: created: tmp

Solves https://github.com/ponylang/corral/issues/23.

So, I took the liberty to include the path parameter in the context with two possible values, either the provided path or the default one, Path.cwd(). It makes things so easy after calling the corresponding command, we just need to use ctx.path everywhere we want to use it.

@cquinn you are the subject matter expert. Can you give this a review?

@ordepdev thoughts on tests that can be added with this change?

@SeanTAllen I can add tests for creating and loading the corral.json files with custom paths. Something this maybe:
class iso _TestCreateBundleInCustomPath is UnitTest
  fun name(): String => "bundle/create-in-custom-path"

  fun apply(h: TestHelper) ? =>
    let log = Log(LvlFine, h.env.err, LevelLogFormatter)
    let expected = FilePath(h.env.root as AmbientAuth, "tmp")?
    match BundleFile.create_bundle(h.env, "tmp", log)
    | let bundle: Bundle =>
      h.assert_eq[String](expected.path, bundle.dir.path)
    end

@ordepdev do you want to squash this and push so you can control the commit message or shall I squash and merge?

You can squash and merge with the first commit message.

Thanks, @ordepdev.


Disallow decimals without leading and trailing digits, enforce subscript indentation

Makes 1. and .1 illegal; must be 1.0 or 0.1. This reduces ambiguities in the upcoming pattern-matching PR and generally makes for a more explicit language, especially considering the arr.0 array-access feature.
Also enforces indentation for member expressions, making these all illegal:
a
.b

a
~b()

a
?.b

(this raises an Indentation required. error).
This makes all subscripts more consistent with computed property access, where an indent is required. It is also intended to reduce the confusion that would have occurred from
a()
.0

which otherwise would have been interpreted as a()[0].

I have mixed feelings about this, but I'm merging for now. It just makes for a more consistent, predictable language. The error messages should be very clear.


[Search] Use reflection to clone SearchOptions

Copy all properties using reflection to alleviate the issue of missing some properties in the copy code.

/azp run net - search - tests

/azp run net - search - tests

Issue #27549

Issue #27549

This is the category of issues I am trying to kill with this approach. It has happened a few times now. The current issue is for an old property, so the bug has existed for a while.

/azp run net - search - tests

cc: @tg-msft
What do you think of this solution? Alternatively, we could add the one we know is missing currently and be more diligent in the future.

It looks like these are all value types, would a MemberwiseClone work?

Another idea would be to just do the reflection in the unit test, and keep the production code up to date by hand. This way you will catch future missing properties automatically in the test, but won't have to use reflection in production code.

Another idea would be to just do the reflection in the unit test, and keep the production code up to date by hand. This way you will catch future missing properties automatically in the test, but won't have to use reflection in production code.

What would the test check? The count of the properties?

Another idea would be to just do the reflection in the unit test, and keep the production code up to date by hand. This way you will catch future missing properties automatically in the test, but won't have to use reflection in production code.

What would the test check? The count of the properties?

The test could check that each property on the source is equal to the corresponding property on the destination.

API change check for Azure.Search.Documents
API changes are not detected in this pull request for Azure.Search.Documents


when reading loom files, construct a matrix from 1D attributes

While loom supports multidimensional annotations, the community tends to store embeddings (e.g. tSNE, umap) in individual 1D attributes ("_tSNE1","_tSNE2", etc. see: http://linnarssonlab.org/osmFISH/availability/).
It would be useful to import these files into the scanpy ecosystem (incl cellxgene) if these dimensions could be composed into a new obsm dimension when loading a loom file.
Example API:
# indicates the target key and which attributes it should be constructed from
obsm_names = {
    'X_spatial': ['X','Y'],
    'X_tsne': ['_tSNE_1','_tSNE_2'],
}

fname = "osmFISH_SScortex_mouse_all_cells.loom"
adata2 = anndata.read_loom(
    fname,
    obsm_names=obsm_names,
)

I've implemented this for review. PR incoming...

Closed by #132


doc:add some comments and stacks tags

Add some stacks tags to etale, flat, unramified etc morphisms.
This contribution was created as part of the AIM workshop "Formalizing algebraic geometry" in June 2024.

bors d+

bors r+

bors r+


Feat/issues#12

Pull Request Title
Description
Added command for creating controller, service and route and test added
Related Issue(s)
Changes Made
If yes, do [x].

[x] Added a new feature
[ ] Fixed a bug
[ ] Refactored existing code
[ ] Updated documentation
[x] Other (explain): added tests under tests dir for creating controller, service, route

List and describe the main changes here:

create controller command
create service command
create route command

Checklist
Please ensure the following have been completed:
If yes, do [x].

[x] Code compiles without errors
[x] Tests are written and passing (if applicable)
[ ] Documentation is updated (in code or README as needed)
[ ] Code adheres to style guidelines (Prettier, ESLint)

Dependencies

jest

Additional Notes
Kindly check my changes
Thank you

Check the code it does not pass es lint checl run npm run lint, npm run lint:fix

yup
tests were out of eslint configuration. added that.


Display tag for button on main page

Wake up and do the chanes :P

This kind of defeats the purpose of catz, no?

No
On Mar 26, 2015 5:38 AM, "Cade Scroggins"<EMAIL_ADDRESS>wrote:

This kind of defeats the purpose of catz, no?
—
Reply to this email directly or view it on GitHub
https://github.com/omgcatz/omgcatz/pull/6#issuecomment-86259221.

The idea is to not explicitly show what the website does.


feat(tds-table): added horizontal scroll

Describe pull-request
Describe what the pull-request is about
Issue Linking:
Choose one of the following options

Jira: Add ticket number after CDEP-: [CDEP-    ](https://tegel.atlassian.net/browse/CDEP-3368)
GitHub: Include issue link
No issue: Describe the problem being solved.

How to test
Provide detailed steps for testing, including any necessary setup.

Go to...
Check in...
Run ...

Checklist before submission

[ ] I have added unit tests for my changes (if applicable)
[X] All existing tests pass
[ ] I have updated the documentation (if applicable)

Suggested test steps

[ ] Browser testing (Chrome, Safari, Firefox)
[ ] Keyboard operability
[ ] Interactive elements have labels.
[ ] Storybook controls
[ ] Design/controls/props is aligned with other components
[ ] Dark/light mode and variants
[ ] Input fields – values should be displayed properly
[ ] Events

Screenshots
Include before/after screenshots for UI changes.
Additional context
Add any other context or feedback requests about the pull-request here.

Maybe design should have a look at this as well? @charlottelorensson

After discussion with @theJohnnyMe and Laurens improvements we wanted to do was:

Only use one prop for activating horizontal scrolling ( horizontalScrollWidth is used now )
Have both footer and tooltip (if in the table) to be "sticky"
Create a separate story-test for horizontal scrolling to be able to fully test everything
Also being able to set column width when horizontal scroll i activated, not just when setting noMinWidth flag

Note:
noMinWidth should still work to set width of columns, although i cannot use multiple conditionals for showing column width input on both horizontal scroll flag and minWidth flag. https://github.com/storybookjs/storybook/discussions/18542

The story includes both pagination and table tooltip, so there is some code duplication there.
Any suggested improvements?

Accepted by design :)


Extend HTTP probe type to support more complex probes

It would be useful if the HTTP probe was extended to supported the following:

All HTTP method types (GET, POST, PUT, HEAD, DELETE, PATCH, OPTIONS).
Request bodies.
Arbitrary headers.

Being able to customize HTTP requests in these ways would allow for a more comprehensive probe into a system in line with normal user behavior.

Fixed in the commit 2ac8624.


Speed-up conventions info

https://codeascraft.com/2020/02/03/production-webpack-builds/

https://twitter.com/iamakulov/status/1275769142809944064

https://github.com/iamakulov/awesome-webpack-perf


Automatic version numbering with versioneer

dask_image uses versioneer, could use their setup as a template.

Look at the matplotlib releases guidelines for what to do when tagging for a new release: https://matplotlib.org/2.0.0/devel/release_guide.html


iOS payment widget very slow

Hello, this may not be an issue of the plugin but the Apple sandbox thing but when I tap on my button in the app to execute the payment, it takes almost 4 seconds on iOS to display the payment widget. It works like a charm on android but iOS is really slow... is this like normal thing...?
It does not matter on what version of the library I use, it behaves the same tbh. But I use the lates versions of VS, MAUI, the library etc.

i see this issue as well.  Trying to figure how to handle sometimes it takes like over a minute.  The real problem is if the connection to the store is slow, the code needs to handle that.  I tried implementing user cancel and user timeout tokens but even even though i can keep the UI going, the appl store popups still eventually come up,

Sandbox users can be very slow


64 bit import thunks, cross section RVAs in import table

Addresses the issues uncovered by the binary in https://github.com/sevaa/dwex/issues/57 :

in PE32+, the thunks in the import lookup/address tables are 64 bit
the RVAs in the import table (both import directory and thunks) may be cross section
also, there are more 64 bit architectures than AMD64

The PE format reference doc I went by is here.
Windows Defender might complain the binary contains a virus. Nothing wrong with that binary as far as I could see.

Thanks. Another one coming.


ARC data Controller creation fails due to space in Azure location name

Describe the bug
While using the azure arc data jumpstart arm template, it creates the aks cluster and then the jumpbox vm. however when you login to the jumpbox vm, the logon script fails at data controller creation as the environment variable ARC_DC_REGION contains a space and it doesnt pickup the complete name. When i was trying, i chose southeast asia and because of the space, the controller creation fails.
To Reproduce
Steps to reproduce the behavior:

choose southeast asia as region for the deployment in the parameter file
proceed with normal deployment
after vm creation login to the jumpbox, and logon script should start
after a while the script errors out saying invalid region name.

Expected behavior
data controller should have been created irrespective of the selected region, may be the space between the region name should be eliminated by some replace function before setting the environment variable

In your ARM template parameters file, try "southeastasia" instead "southeast asia". You should be using the region id and not the region display name.

@Nagi-MSFT any updates?

I haven’t retried it. I just modified the environment variable after it failed to kick start again and it went through. However found another issue where the data studio was not connected to arc due to extensions not being installed correctly. And the VM has security control which doesn’t allow to download from internet. I then got it connected on my laptop by exposing firewalls.
I will retry the region id and comeback if it solves.
Thanks
[cid:image001.png@01D6CD48.55539A10]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fazure.microsoft.com%2F&data=02|01|navirdi%40microsoft.com|241af741467b4364272a08d83e681723|72f988bf86f141af91ab2d7cd011db47|1|0|637327964088030858&sdata=G5LlJVPRfFKEjSRD4LDn74dPSUXv7plL7Opyzuv94ro%3D&reserved=0Naginder Singh Virdi
Global Blackbelt Technical Specialist – Open Source Databases | Microsoft
Tel +65 68887202(Office), +65 83019663(mobile)
From: Lior Kamrat<EMAIL_ADDRESS>Sent: Tuesday, December 8, 2020 4:54 AM
To: microsoft/azure_arc<EMAIL_ADDRESS>Cc: Naginder Singh Virdi<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/azure_arc] ARC data Controller creation fails due to space in Azure location name (#165)
@Nagi-MSFThttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNagi-MSFT&data=04|01|navirdi%40microsoft.com|caee34ac68174b5df9e208d89af23bb4|72f988bf86f141af91ab2d7cd011db47|1|0|637429712477922517|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=x%2BN5JDkSWMPhDIVRQX5iikAEeu4k%2Bhy5MLYWNaFJAU0%3D&reserved=0 any updates?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fazure_arc%2Fissues%2F165%23issuecomment-740174017&data=04|01|navirdi%40microsoft.com|caee34ac68174b5df9e208d89af23bb4|72f988bf86f141af91ab2d7cd011db47|1|0|637429712477932475|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Pu%2FuAMPSHTQEEEuiS8MWYJxSMyXSzFJWzlQfY7FJAK0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAF7QLUDKQQ5YZQL5WVOOAWLSTU6GZANCNFSM4UE4I3DQ&data=04|01|navirdi%40microsoft.com|caee34ac68174b5df9e208d89af23bb4|72f988bf86f141af91ab2d7cd011db47|1|0|637429712477932475|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=X1oGT3%2FjruzWkEo%2BDbUqeObQ8Y624xbzV%2Bh2DePXG2Q%3D&reserved=0.

I haven’t retried it. I just modified the environment variable after it failed to kick start again and it went through. However found another issue where the data studio was not connected to arc due to extensions not being installed correctly. And the VM has security control which doesn’t allow to download from internet. I then got it connected on my laptop by exposing firewalls.
I will retry the region id and comeback if it solves.
Thanks

@Nagi-MSFT any updates before closing this issue?

No. Please go ahead and close this.
Thanks for support
Regards,
Naginder Singh Virdi
Get Outlookhttps://aka.ms/qtex0l for iOS

From: Lior Kamrat<EMAIL_ADDRESS>Sent: Friday, December 18, 2020 2:27:44 AM
To: microsoft/azure_arc<EMAIL_ADDRESS>Cc: Naginder Singh Virdi<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/azure_arc] ARC data Controller creation fails due to space in Azure location name (#165)
@Nagi-MSFThttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNagi-MSFT&data=04|01|navirdi%40microsoft.com|724a33e11bc749055ed708d8a2b972c9|72f988bf86f141af91ab2d7cd011db47|1|0|637438264700286850|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=AWjmNjETRPomo6Z5uwoWDJm8FeOuPSu04y%2BYHMXMDcs%3D&reserved=0 any updates before closing this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fazure_arc%2Fissues%2F165%23issuecomment-747616951&data=04|01|navirdi%40microsoft.com|724a33e11bc749055ed708d8a2b972c9|72f988bf86f141af91ab2d7cd011db47|1|0|637438264700296844|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=KdA7sHIyl5Wv5h9GlsBsnxr50ixo5mFnf6OWmvE5lfk%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAF7QLUAKU6E6MBOTF3OCZKTSVJESBANCNFSM4UE4I3DQ&data=04|01|navirdi%40microsoft.com|724a33e11bc749055ed708d8a2b972c9|72f988bf86f141af91ab2d7cd011db47|1|0|637438264700296844|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=SKUvztTI21WzP2u5ImeE7klN1pmpZntT0Z3rGZf40%2Bw%3D&reserved=0.


[BUG] - Error when retrieving credentials from container-role - destroyteams

Describe the bug
Destroy teams fails after destroying resources/namespaces. In my observation, this seems to happen in a destroy where the env has had more activity, and therefore more stuff to delete.
[destroy.py   : 85] Destroyed all lake-admin resources using thread Thread-1
[ Error ] CredentialRetrievalError: Error when retrieving credentials from container-role: Error retrieving metadata: Received error when attempting to retrieve ECS metadata: Could not connect to the endpoint URL: "http://<IP_ADDRESS>/v2/credentials/f014f115-c05c-4e7e-84ec-d820da7bbc02"
Full trace:
Error Traceback:
Traceback (most recent call last):
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/urllib3/connection.py", line 169, in _new_conn
conn = connection.create_connection(
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/urllib3/util/connection.py", line 96, in create_connection
raise err
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/urllib3/util/connection.py", line 86, in create_connection
sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/httpsession.py", line 323, in send
urllib_response = conn.urlopen(
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 755, in urlopen
retries = retries.increment(
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/urllib3/util/retry.py", line 507, in increment
raise six.reraise(type(error), error, _stacktrace)
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/urllib3/packages/six.py", line 770, in reraise
raise value
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 699, in urlopen
httplib_response = self._make_request(
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 394, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/urllib3/connection.py", line 234, in request
super(HTTPConnection, self).request(method, url, body=body, headers=headers)
File "/root/.pyenv/versions/3.8.10/lib/python3.8/http/client.py", line 1252, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/awsrequest.py", line 92, in _send_request
rval = super(AWSConnection, self)._send_request(
File "/root/.pyenv/versions/3.8.10/lib/python3.8/http/client.py", line 1298, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "/root/.pyenv/versions/3.8.10/lib/python3.8/http/client.py", line 1247, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/awsrequest.py", line 120, in _send_output
self.send(msg)
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/awsrequest.py", line 204, in send
return super(AWSConnection, self).send(str)
File "/root/.pyenv/versions/3.8.10/lib/python3.8/http/client.py", line 947, in send
self.connect()
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/urllib3/connection.py", line 200, in connect
conn = self._new_conn()
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/urllib3/connection.py", line 181, in _new_conn
raise NewConnectionError(
urllib3.exceptions.NewConnectionError: <botocore.awsrequest.AWSHTTPConnection object at 0x7f375ab45910>: Failed to establish a new connection: [Errno 111] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/utils.py", line 2255, in _get_response
response = self._session.send(request.prepare())
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/httpsession.py", line 352, in send
raise EndpointConnectionError(endpoint_url=request.url, error=e)
botocore.exceptions.EndpointConnectionError: Could not connect to the endpoint URL: "http://<IP_ADDRESS>/v2/credentials/f014f115-c05c-4e7e-84ec-d820da7bbc02"
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/credentials.py", line 1870, in fetch_creds
response = self._fetcher.retrieve_full_uri(
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/utils.py", line 2205, in retrieve_full_uri
return self._retrieve_credentials(full_url, headers)
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/utils.py", line 2241, in _retrieve_credentials
return self._get_response(
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/utils.py", line 2273, in _get_response
raise MetadataRetrievalError(error_msg=error_msg)
botocore.exceptions.MetadataRetrievalError: Error retrieving metadata: Received error when attempting to retrieve ECS metadata: Could not connect to the endpoint URL: "http://<IP_ADDRESS>/v2/credentials/f014f115-c05c-4e7e-84ec-d820da7bbc02"
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/codebuild/output/src689/src/s3/01/cli/.venv/bin/orbit", line 8, in
sys.exit(main())
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/aws_orbit/main.py", line 907, in main
cli()
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/click/core.py", line 829, in call
return self.main(*args, **kwargs)
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/aws_orbit/main.py", line 362, in destroy_teams
destroy_commands.destroy_teams(env=env, debug=debug)
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/aws_orbit/commands/destroy.py", line 85, in destroy_teams
remote.run(
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/aws_orbit/remote.py", line 105, in run
_execute_codebuild(
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/aws_orbit/remote.py", line 83, in _execute_codebuild
_wait_execution(
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/aws_orbit/remote.py", line 42, in _wait_execution
for status in codebuild.wait(build_id=build_id):
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/aws_orbit/services/codebuild.py", line 213, in wait
build = fetch_build_info(build_id=build_id)
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/aws_orbit/services/codebuild.py", line 168, in fetch_build_info
client = boto3_client("codebuild")
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/aws_orbit/utils.py", line 50, in boto3_client
return boto3.Session().client(service_name=service_name, use_ssl=True, config=get_botocore_config())
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/boto3/session.py", line 258, in client
return self._session.create_client(
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/session.py", line 839, in create_client
credentials = self.get_credentials()
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/session.py", line 441, in get_credentials
self._credentials = self._components.get_component(
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/credentials.py", line 1977, in load_credentials
creds = provider.load()
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/credentials.py", line 1840, in load
return self._retrieve_or_fail()
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/credentials.py", line 1849, in _retrieve_or_fail
creds = fetcher()
File "/codebuild/output/src689/src/s3/01/cli/.venv/lib/python3.8/site-packages/botocore/credentials.py", line 1875, in fetch_creds
raise CredentialRetrievalError(provider=self.METHOD,
botocore.exceptions.CredentialRetrievalError: Error when retrieving credentials from container-role: Error retrieving metadata: Received error when attempting to retrieve ECS metadata: Could not connect to the endpoint URL: "http://<IP_ADDRESS>/v2/credentials/f014f115-c05c-4e7e-84ec-d820da7bbc02"

This happens in a scenario when codebuild times out. Pls raise the build time out


Fixes join group by code e2e

Description
Fixes #...
Notes (out of scope, known isues, hints for reviewing code, ...)  (optional)
...
Test cases

[ ] Case 1:

Given I am the usual user
When I go to [this page](branch link)
And I click on ...
Then I see ...
And

[ ] Case 2:

Given I am the usual user
When ...

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/bugfix/e2e-no-parallelism-tests/playwright-report/index.html


Question: plans for context.Context support?

Specifically, support passing contexts through to the new go1.8 sql.DB methods that take them.  Something like ExecutorContext (and TransactorContext, etc), and I guess variations of the finalizer methods which take them.

There's no roadmap item or anything for this. I was sort of waiting for the demand of this feature to be high enough to do it. Because there needs to be support in the drivers (lib/pq, go-sql-driver/mysql, etc.) to support this before it's of any use in SQLBoiler I thought we had a bit more time before there'd be a good reason to implement it.
It also uglies up our everything quite badly. Which is a squishy human reason for not wanting to do it. I've thought of three interfaces, none of which I really like (please help with suggestions if you have some):

Everywhere there's a db parameter, also pass in a context. This has the downsides of being a breaking change for everyone, being ugly, and requiring non-context users (probably most) to supply context.TODO everywhere.

p, err := models.Pilots(db, ctx).All()

Have C variants to expose the same behavior as above so they become optional. We already have many method variants, this'd just be another one. It's better than the first since it's a non-breaking change.

p, err := models.PilotsC(db, ctx).All()

Have a wrapper object whose bound to a context for the context calls and if the context is present in the wrapper attempt to upgrade the Executor to a ContextExecutor. This is probably the cleanest, and the upshot
is there's no breaking change, no extra variant. The downside is that it's a bit hard to see if there's a context being passed in.

type ContextDB struct {
   Executor
   ctx      context.Context
}

db = boil.WithContext(db, c)
p, err := models.Pilots(db).All()

An issue with all these approaches is they don't follow the suggested practice of not storing contexts as attributes.  I think the reason for that is to avoid accidentally hanging on to a context for longer than a single transaction/operation/thread of execution.  The recommendation is to only pass contexts as arguments.
What if the terminal functions (All(), Bind(), Exec() etc) had variants:
p, err := models.Pilots(db).AllContext(ctx)

These variants would try and upgrade the Executor to ExecutorContext if possible.

So we talked about this (sorry for the slow reply). Thanks for pointing out the best practices surrounding Context use. Despite hovering around a lot of Go stuff, I wasn't actually aware of this particular nit when using it.
One of the issues with your suggestion however is it does ugly up the API a certain amount in that the db is put far away from the context when in reality, they go together and are "one" thing (can't make the call without both).
An example where this becomes kind of awkward is where you create a query and then execute it later inside a different function. The context ends up being "used" in a different function, rather than in the same one with the database handle. Also with the suggestion you've made we increase the amount of variants of the finishers (and update/find/upsert) a fair amount, and though in my previous post I thought that was okay, when you look at the number of methods it would spawn it seems less okay.
.All()
.AllP()
.AllContext()
.AllContextP()
Find()
FindG()
FindGP()
FindGContext()
FindGPContext()

The only way around the separation mentioned above that seems clean is to move them to one or the other side. Though this is a breaking change in both cases.
p, err := models.PilotsC(db, ctx).All()
p, err := models.Pilots().AllContext(db, ctx)

The only way around creating variants is one of two methods:

Wrap the db like I showed earlier, which goes against the very sane advice of only passing contexts as parameters.

db = boil.WithContext(db, c)
p, err := models.Pilots(db).All()

Force a context, and have people put todo everywhere. Also a big breaking change. Also goes against all the advice given above.

p, err := models.Pilots(db, context.TODO()).All()

So as I've typed this all out, I realize that I've essentially said the same thing with a slight variation where we could break the API in order to move the arguments around so it's more consistent. This seems like it's the only middle ground between all the approaches. Since any that I've come up with hold the context (which you've rightly pointed out is bad) and any that don't break the API, or make it less pleasant.
It's a sort of impasse since the only reasonable change would be a breaking one. I wanted to ask what the urgency behind the request is, do you have a driver that supports contexts and you want to use SQLBoiler with it? Or is it that you want to pass your contexts through so that when the driver does finally support them that you'll be ready to go?

I'm not currently using sqlboiler.  We currently use gorm pretty extensively, but that also doesn't have context support, so I was looking around at alternatives.
Our desire for context support comes from the way our project is instrumented.  The thing I liked about sqlboiler is that I don't need to pass a *sql.DB to it.  I can wrap the *sql.DB in something that tracks metrics like the number of database calls, and time spent in database operations.  And further, sqlboiler (or gorm) were context aware, that wrapper could use the context to track even more stuff, like total db time per request.  We also use zipkin-style transaction tracing in our app, and we could add database operations to those traces with contexts.
The driver support for context deadlines is cool too, but that's not what we're itching for right now.  It's really about tracing and metrics.
Personally, I still the think the right thing to do is variants of the finalizer methods.  You mentioned above that it feels wrong to you that the context and the db instance could be so disassociated ("the db is put far away from the context").  But I think the that notion that they are coupled, are "one thing" that "go together" might not be correct.  The context doesn't follow the db around.  It follows around main thread of execution, the "hot path", where the interesting work is happening.  In sqlboiler, I think that in the finalizers.
The stuff like models.Pilots(db), and the query modifiers, that's all basically constructors for re-usable queries.    I could see projects setting up sets of common queries at initialization time and re-using them (a bit like "scopes" in rails).  That means those queries might be long-lived things that span many requests or transactions.  Which is why you wouldn't want to associated a context with them.
As far as API bloat...eh.  I would just take the hit and add all the variants.  It's not worth making a breaking change.  It's what the go guys themselves did.  I'd keep the the *G variants as variants of the starters...I see it's pretty tough, because it's not only finishers that would need *Context variants.  You've got PilotsFind methods, the methods on the models (like Insert, Upsert, etc), Reload(), associations stuff, potentially supporting alternate hook interfaces which can accept them.  It's a lot... Some of that could be simplified by attaching the context to the Query as an attribute.  That's probably an acceptable compromise, since the Query already represents a single operation.  Then maybe you could attach a context via a Query Modifier?  And perhaps expand the hook support to give hooks access to the Query, and therefore the context.  That might have other advantages as well, like allowing hooks to add additional modifiers to queries (a soft-delete feature might be implemented this way).
If there's anywhere I'd consider trimming, it would be the *P variants.  DB operations are intrinsically unpredictable (because they interact with an external system), so it seems appropriate to me to force the developer to handle the error.  These operations will error sometimes, guaranteed.  In go, I tend to reserve panics for situations like "this never should have happened, and if it did, all my assumptions are wrong, so OMG I'm outta here".  I'd consider deprecating the *P variants of the finishers
One other thing about context convention: for those functions/methods which accept a context, it should be the first argument, e.g. `models.Pilots(db).

I'm with @ansel1. The finalizer methods seem like the best place to add context.
To address API bloat, with if users could control generation of certain finalizer styles through config? I don't use any of the *P methods (in fact, I added a template override to my project so they aren't even generated).
Storing context in the query (using a query mod) seems like it would be fair as well (this would mirror how net/http handles context for outbound requests), but I think this makes it too easy to forget to pass context into a query.

Sorry I've been on business and haven't been able to respond quickly.
I agree with the context being the first parameter, also following the guidelines and I'm happy to oblige.
I still dislike separating the db and the context - to me they're both "required to execute the query" and the only reason the db is where it is is because it made the API more consistent in that the first argument to the first function in a chain is always the db. Again I'd prefer to move the DB to the end if the context is going to be there too. Not sure we'll be able to reach agreement here. Keep in mind this means that we'd move the db, not the context. This actually could provide some more re-usable query fragments perhaps since the db is bound late.
Proposal ends up being:
p, err := models.Pilots().All(ctx, db)

Also the query mod is no better than wrapping the DB in a contexted DB as it still stores the context which we're trying to avoid and is basically the same level of weirdness.
What I do really like is what bj says about controlling variant generation via config. Not only would this allow us to break the API for context (though depending on the extent the templates could get PRETTY messy) but I think it's also a fair point that *P and *G should be optional at generation time. If context was handled in this way we could also decide to not implement the variant, but simply put the context as required parameter everywhere. I think if you buy in to using context, you should be using it everywhere and so this is a good idea, please correct me if I'm wrong.
Join us on Slack if you'd like, hopefully we can get some more interactive discussions going on :)
https://sqlboiler.from-the.cloud/

Ok, I see...yep, I like it.  Moving db param to the end of call chain, and using a generation flag to turn context variants on and off...that all feels pretty elegant.

I think I'd be in favor of moving DB to the end and keeping it with context. That would certainly make cloning queries simpler and safer.

I guess hooks could be handled with the same kind of flag, generating context variants if requests, ie
// Define my hook function
func myHook(ctx context.Context, exec boil.Executor, p *Pilot) {
  // Do stuff
}

// Register my before insert hook for pilots
models.AddPilotHook(boil.BeforeInsertHook, myHook)

Yep. I did have one more question before we can execute on this. Is it appropriate for a context to be used in multiple queries to the DB. For example an eager load could do N select queries and would be re-using the same context since at least with the current proposal would be no way to get a new one. Does this pose a problem?

Yep, that is definitely correct. Using the same context enables packages like github.com/ExpansiveWorlds/instrumentedsql to profile each of the queries in the operation separately, which would be super helpful for debugging slow eager loads (or slow queries in general).

Also worth noting that @bjyoungblood's previous suggestion to remove panic and global variants was taken seriously and they are now off by default and hidden by flags: 1121042


Separate signed header and data to different blobs

fixes #829
major changes are related to da/ package and dalc.proto:
proto/dalc/dalc.proto

splits various block related types to header and data

da/da.go

splits block submit, checkavail, and retrieve methods to header and data
accept two namespace ids (header & data) in the dalc init (also check config/config.go, config/defaults.go, config/config_test.go)
check the changes in the implementations

da/celestia/celestia.go

fairly straightforward split of methods from block to (header and data)

da/celestia/mock/server.go

this has bit crazy logics to handle differentiating header & data methods that both arrive into the common apis like submit_pfb, namespaced_shares and namespaced_data (uses namespace id to differentiate)

da/grpc/grpc.go & da/grpc/mockserv/mockserv.go

fairly straightforward split of methods from block to (header and data)

da/mock/mock.go

has some additional logic to handle mocking the DA. although it is not important, as it is just a mock and the logic does not necessarily 1-to-1 translate to actual DA, some of the logics are questionable.

update to da/test/da_test.go

next important change is in the manager.go which handles this changed logic

remove namespaceId from NewBlockExecutor (as it was not used)
fetchBlock returns header and data response instead of block response as it makes two separate calls to RetrieveBlockHeaders and RetrieveBlockDatas
change submitBlockToDA to accept additional parameter onlyHeader to fire either SubmitBlockHeader or SubmitBlockData. the idea here is that, we first submit the data, get the data committment (right now it is just Data.Hash(), but later it will be changed to DA committment), insert that into the header before signing and then submit the signed header to DA in the second call to submitBlockToDA

node/full.go (node/full_client_test.go, node/full_node_integration_test.go)

changes related to accepting two namespace ids

types/hashing.go

adds Hash() to Data, which is used temporarily as Data committment and included in the header's data hash field, which is checked in the ValidateBasic (types/validation.go)

types/serialization.go

adds missing serialization methods (UnmarshalBinary, FromProto) to Data

state/executor.go (state/executor_test.go)

removed namespaceID which is not used in the executor

why separate namespaces?

why separate namespaces?

we can have faster queries and efficient processing of headers if you only need headers and not data. @nashqueue have some ideas for future utility for the common header namespace.
@S1nus any downside to this?

Follow-up Issues:

Before Blob Module:

Make Hash not a response to DA but calculated on the fly

After 2 PFB, one Blob node-support

Change the Logic of submitting header/data together in a package instead of submitting it individually. (Maybe we should think about if we want to aggregate all of the blob submissions into one PFB per DA height )

After Blob Module

Instead of using the Hash function, we should use the commitment provided by Celestia

@nashqueue @tzdybal re-review required.
Removed the hash dependency: we directly compute the hash and insert to header dataHash field before signing. while doing this, came across a bug where we were signing the header with dataHash which is obtained before updating the ISRs to block data (meaning it was empty when we data.Hash() and insert to header and sign). To fix this, I had to refactor the ApplyBlock (@tuxcanfly), which mainly moves the block.validate outside of ApplyBlock such that we can call the validate before apply block for syncing and call the validate after apply block in case of publishing the new block. this way, while publishing the new block, we can first apply the created block to compute ISRs (this also solves @tuxcanfly issue were we can have the updated NextValidators to be inserted in to the header before signing it), compute the data.Hash() with the updated ISRs and then insert it to header.DataHash field and sign it.
also, came across a potential issue: Header and data blob separation assumes same da height (#913)
note that, I am hesitant to merge the two APIs (SubmitBlockHeader and SubmitBlockData) as it will create many issues to design the mock correctly. if this is a must, we can address it in the separate issue.

New commits make sense. Only 1 small comment. As this is breaking so much, we should test it out thoroughly. Run a Gm / Ethermint tutorial as a sanity check.
Also, protobuf linter complains.

will run the tutorial.
protobuf linter complains are not valid, it is asking for expansion of proto messages for the two types (header and data), but it is not necessary. for example, it is asking me to expand SubmitBlockResponse (https://github.com/gupadhyaya/rollkit/blob/separate_blobs/proto/dalc/dalc.proto#L29) to SubmitBlockHeaderResponse and SubmitBlockDataResponse. this is not really needed as both message will have same field DAResponse result = 1; and the newly created types will be redundant.

while testing the actual celestia DA, the block data submission fails with ERR DA layer submission failed error=",cannot use zero blob size" attempt=1 module=BlockManager. the problem is that, when there is no txs in the block, the block.Data is empty and trying to submit zero bytes to celestia DA fails. this was not an issue earlier as we were submitting the whole block with SignerHeader and Data, where even when the txs dont exist, header won't be empty.
hopefully the new tx, isr format (#885) fix the problem, where even when the txs empty, isr will wrap the block.Data to make it non-empty, hence we always have non-zero bytes to submit to DA. is this assumption correct @Manav-Aggarwal ?

@gupadhyaya This does not unblock the separation of block/header, as we would need to enable fraud proofs. But for pessimistic chains, we don't need the ISR overhead. We wouldn't need the header referencing the block, as there are no light nodes. You need full nodes to get full security for pessimistic mode.

Can we post an empty share instead? Like just a 0? Would this deserialize correctly?

@gupadhyaya This does not unblock the separation of block/header, as we would need to enable fraud proofs. But for pessimistic chains, we don't need the ISR overhead. We wouldn't need the header referencing the block, as there are no light nodes. You need full nodes to get full security for pessimistic mode.

agreed, we should make sure things are consistent with pessimistic mode as well


Fix Traefik Tunnel resource config

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #395

PR #396   👈

PR #374

This stack of pull requests is managed by Graphite.


Added support for Swift Package Manager | Fix Xcode 12.5 has invalid header layout

Thanks for this PR, i've tested and is working well for me 👍

@harryblam How did imported it through this PR ?

When it will be merged??

@harryblam How did imported it through this PR ?

@MohammedBadr20s  I referenced the branch repo in the package url in my package.json like this: .package(name: "SVProgressHUD", url: "https://github.com/Pimine/SVProgressHUD.git", .branch("master"))

I've updated the component and addressed several bugs. Please review version 2.3.0, and should you find any remaining issues, your feedback would be greatly valued.


ConfigMap reflection: fix race condition

Description
This PR fixes an issue in the configmap reflection logic, caused by a race condition with the remote controller-manager for the creation of the root CA configmap.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[x] Unit tests (new + existing)

/test

/merge


Add Memoizable from ROM

This copies across Memoizable from ROM. Having it in dry-core will make it easier to use across a variety of different places.

@solnic @flash-gordon if you're happy with this, I'll merge this and cut a new dry-core release tomorrow morning, then start on a PR to have rom use Dry::Core::Memoizable.


app crash on start with android 4.3, work good on >= 5.x

Environment
OS: Windows 10
Node: 8.9.3
Yarn: Not Found
npm: 5.5.1
Watchman: Not Found
Xcode: N/A
Android Studio: Not Found
Packages: (wanted => installed)
react: ^16.4.1 => 16.4.1
react-native: ^0.55.4 => 0.55.4
Description
I create an app who work good on android 5 and higher. today i wanted to test it on android 4.3 but the app crash on startup. not working on debug or release mode
Reproducible Demo
I cannot share code because i don't know from where the bug come.
It get the error with adb :
W/dalvikvm( 4508): VFY:  rejected Lbr/com/classapp/RNSensitiveInfo/RNSensitiveInfoModule;.decryptWithAes (Ljava/lang/String;Lcom/facebook/react/bridge/Promise;Ljavax/crypto/Cipher;)V
W/dalvikvm( 4508): Verifier rejected class Lbr/com/classapp/RNSensitiveInfo/RNSensitiveInfoModule;
W/dalvikvm( 4508): threadid=18: thread exiting with uncaught exception (group=0x4174b700)
E/AndroidRuntime( 4508): FATAL EXCEPTION: Thread-224
E/AndroidRuntime( 4508): java.lang.VerifyError: br/com/classapp/RNSensitiveInfo/RNSensitiveInfoModule
E/AndroidRuntime( 4508):        at br.com.classapp.RNSensitiveInfo.RNSensitiveInfoPackage.createNativeModules(RNSensitiveInfoPackage.java:20)
E/AndroidRuntime( 4508):        at com.facebook.react.NativeModuleRegistryBuilder.processPackage(NativeModuleRegistryBuilder.java:106)
E/AndroidRuntime( 4508):        at com.facebook.react.ReactInstanceManager.processPackage(ReactInstanceManager.java:1172)
E/AndroidRuntime( 4508):        at com.facebook.react.ReactInstanceManager.processPackages(ReactInstanceManager.java:1142)
E/AndroidRuntime( 4508):        at com.facebook.react.ReactInstanceManager.createReactContext(ReactInstanceManager.java:1080)
E/AndroidRuntime( 4508):        at com.facebook.react.ReactInstanceManager.access$900(ReactInstanceManager.java:113)
E/AndroidRuntime( 4508):        at com.facebook.react.ReactInstanceManager$5.run(ReactInstanceManager.java:911)
E/AndroidRuntime( 4508):        at java.lang.Thread.run(Thread.java:841)
W/ActivityManager(  688):   Force finishing activity org.plantnet/.MainActivity

Any advice are welcome
thanks

Your error is very likely an issue with RNSensitiveInfoModule class, not react-native framework itself. You should open the Github issue to https://github.com/mCodex/react-native-sensitive-info Btw your issue may be the same as https://github.com/mCodex/react-native-sensitive-info/issues/90

Closing this issue, because as @hey99xx noted, this issue is not related to React Native.


Refactoring Code as of  July 2020

There are a few things we could do to refactor the codebase and set up a proper style guide.
Estimation
4d
Acceptance

[ ] We have code linting and prettifying which is checked automatically as part of CI
[x] We have shared components that are reused
[ ] Typescript set up with proper types
[ ] No map using index as key
[ ] Create custom hooks/Context API, and replace initializeApollo with it

Tasks

[x] atm no shared components. We can define shared components like input, forms, buttons, etc.
[x] There's no gql schema management system. Right now, it has a gql query defined in each component file, which should be managed in one place.
[ ] Why don't we use lazy hooks method like useLazyQuery as well as useQuery?
[ ] It seems like they're trying to use typescript, but no types defined. Actually, it's not typescript.
[x] I can see a bunch of duplicated code, which we can refactor by using well-structured data.
e.g. /components/dataset/About.tsx => We can define table columns/rows.
[ ] Implement code linting e.g. use eslint?
[ ] Do not use array index as key when rendering list
[ ] Create and use custom hooks/Context API for managing 3rd party libraries. e.g. apollo-client initializer defined in lib

Analysis

cc @azfullstack2258

@abhishekgahlot can we get details of this issue.

There's no gql schema management system. Right now, it has a gql query defined in each component file, which should be managed in one place.
Why don't we use lazy hooks method like useLazyQuery as well as useQuery?
It seems like they're trying to use typescript, but no types defined. Actually, it's not typescript.
I can see a bunch of duplicated code, which we can refactor by using well-structured data.
e.g. /components/dataset/About.tsx => We can define table columns/rows.
It has no theme setup, no stylesheets defined.
No shared components. We can define shared components like input, forms, button, etc.
In terms of coding style, why don't we use eslint?

@rufuspollock we have added the checklist here.

@tavareshansen can you please estimate this item in d.

@tavareshansen can you please estimate this item in d.

@rufuspollock sure.

@tavareshansen Can we also check the items that are merged into this PR, I am not sure if the PR had everything mentioned above?

yes, I did.

Cool thanks as this PR requires another PR to be updated which is #42 .

The PR has been merged so the issue has been automatically closed.


Wrong classifications in MNIST dataset

Hello, ty for your projet
can you please tell me or show me the python code to show wrong classifications of lenet on MNIST ( The Figure 8.4 on your pdf )
TY

Hey ty for your answer, can you possibly advice me any website where to look for a solution please ?


Do not send variables to env by default

Fixes #2798
Before this PR stacks had these defaults applied to all variables:
from:
  env: <same_as_variable_name>
to:
  env: <same_as_variable_name>

After this PR the variables are no longer sent to local env to avoid leaking stack variables from parent stacks to child stacks when using stack dependencies.
The default becomes:
from:
  env: <same_as_variable_name>

Breaking change
After this PR something like this no longer works:
variables:
   db_host:
     type: string
     from:
       prompt: Enter DB_HOST
  backup_db_host:
     type: string
     from:
       prompt: Enter backup DB_HOST or leave blank to use the DB_HOST
       env: db_host

To fix, change to:
-       env: db_host
+       variable: db_host

or send the value to env manually:
     from:
       prompt: Enter DB_HOST
+     to:
+       env: db_host

Opto has been updated to 1.8.7 to bring in the variable resolver.

Confirmed to fix #2798
$ kontena stack install test/deptest.yaml
...
$ kontena service show deptest-foo/redis | grep PEERS
    - PEERS=
$ kontena service show deptest-bar/redis | grep PEERS
    - PEERS=foo=redis://$STACK-foo:6379/

$ kontena stack upgrade deptest test/deptest.yaml
...
$ kontena service show deptest-foo/redis | grep PEERS
    - PEERS=
$ kontena service show deptest-bar/redis | grep PEERS
    - PEERS=foo=redis://$STACK-foo:6379/

Look a quick look through all the public stacks on the stack registry, and I couldn't find any from: env: ... usage that would be broken like this. All of the from: env: ... usages were like
variables:
  version:
    from:
      env: VERSION

@jakolehm @jnummelin aware of any from: env: ... usages that would break here? I couldn't find any, so I think this is an easy call to fix the dependent stack variable leakage. I'll mention it in the release changelogs.

I don't think many people realized it was there.

aware of any from: env: ... usages that would break here?

Not aware, haven't really used/seen that anywhere.

I had no idea that you could do that. After seeing the usage example, I’m quite sure that I would have never done that.

There's a fixture btw that uses this, I don't know why specs are still passing.
https://github.com/kontena/kontena/blob/386dd763a6c242057410abbedbbcfe665f872165/cli/spec/fixtures/stack-with-variables.yml

There's a fixture btw that uses this, I don't know why specs are still passing.

The from: env usages there are similar to what I found in the stacks, so stuff like variable tag being from: env: TAG. The to: env: TAG  is ATM broken per  #2815, but then it's not actually interpolated in that spec fixture. I have no idea what the WORDPRESS_DB_PASSWORD=${STACK}_secret and type: string # has a callback that writes the value to vault there are supposed to be, though.

It seems this breaks the way I was using variables to define tags on my docker images. I did not have to check this during the RC, but still wanted to share it here in case anyone else runs into it (which I doubt).
The problem seems to be that if you used an to: env variable in a kontena.yml that has the same name as an ENV variable in your docker-compose file, then the kontena stack validation fails. Looks like this is a bug in the YML reader when it tries to interpolate a variable.
Here is config to reproduce this:
# kontena.yml
stack: demo
version: 1.0.0

variables:
  myvar:
    type: string
    default: 'test'
    from:
      env: ENV_VAR
    to:
      env: ENV_VAR

services:
  node:
    extends:
      file: docker-compose.yml
      service: node

# docker-compose.yml
version: '2.1'
services:
  node:
    image: node:alpine
    environment:
      - ENV_VAR=$ENV_VAR

then run
$ ENV_VAR=whatever
$ kontena stack validate
 [error] RuntimeError : Undeclared variable 'ENV_VAR' in c:/repos/demo/docker-compose.yml:5 --       - ENV_VAR=$ENV_VAR
         See C:/Users/superzadeh/.kontena/kontena.log or run the command again with environment DEBUG=true set to see the full exception

For more context, here is how I was using this in my setup and ran into the error:
Below are the files that I use as an example. The way it works is:

I am using Travis as CI. Travis sets TRAVIS_BRANCH when it builds
If the command kontena stack build is run in a CI environment, then the tag is the branch-name. This allows me to easily have find images related to a branch. This is especially useful because it lets me tag images automatically with :staging, :v1.3.0 based on my branch or git tags.
If the TRAVIS_BRANCH is not set, then the current kontena ${GRID} will be used as tag. This provides a nice default, since the image built/pushed has the same name as the current grid.
Finally, in docker-compose.yml, the tag used when you build the image (using docker-compose build for example) is local. If for some reason docker-compose build is used in a CI, then the image is tagged with the branch name (there are some case where we are not using docker-compose build in the CI instead of kontena-stack build).

# kontena.yml
stack: mystack
version: 1.0.0

variables:
  app_branch:
    type: string
    default: ${GRID}
    from:
      env: TRAVIS_BRANCH
    to:
      env: TRAVIS_BRANCH

services:
  myservice:
    extends:
      file: docker-compose.yml
      service: myservice

# docker-compose.yml
version: '2.1'
services:
  myservice:
    image: bunch/myservice:${TRAVIS_BRANCH-local}
    build:
      context: .
      dockerfile: Dockerfile

The full exception stack trace:
E, [2017-10-16T15:18:56.884759 #9176] ERROR -- CLI: Undeclared variable 'TRAVIS_BRANCH' in c:/repos/akula/docker-compose.yml:3 --     image: bunch/akula:${TRAVIS_BRANCH-local} (RuntimeError)
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:379:in `block (2 levels) in interpolate'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:369:in `gsub'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:369:in `block in interpolate'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:364:in `map'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:364:in `with_index'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:364:in `interpolate'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:99:in `fully_interpolated_yaml'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:249:in `validate'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:202:in `execute'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:353:in `from_external_file'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:444:in `extend_config'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:321:in `process_config'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:278:in `block in parse_services'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:277:in `each'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:277:in `parse_services'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:211:in `block in execute'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:205:in `chdir'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/yaml/reader.rb:205:in `execute'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/common.rb:33:in `stack'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/cli/stacks/validate_command.rb:55:in `execute'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/command.rb:213:in `run'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/clamp-1.1.2/lib/clamp/subcommand/execution.rb:11:in `execute'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/command.rb:213:in `run'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/clamp-1.1.2/lib/clamp/subcommand/execution.rb:11:in `execute'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/lib/kontena/command.rb:213:in `run'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/clamp-1.1.2/lib/clamp/command.rb:132:in `run'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/kontena-cli-1.4.0/bin/kontena:18:in `<top (required)>'
C:/Ruby24-x64/bin/kontena:22:in `load'
C:/Ruby24-x64/bin/kontena:22:in `<main>'

I made the following change to fix this. It now means that docker-compose build should only be used locally/in development, whereas kontena stack build should be used for everything else.
# docker-compose.yml
version: '2.1'
services:
  myservice:
-    image: bunch/myservice:${TRAVIS_BRANCH-latest}
+    image: bunch/myservice:local
    build:
      context: .
      dockerfile: Dockerfile

# kontena.yml
variables:
  app_branch:
    type: string
    default: ${GRID}
    from:
      env: TRAVIS_BRANCH
    to:
-      env: TRAVIS_BRANCH
+      env: TAG

services:
  myservice:
    extends:
      file: docker-compose.yml
      service: myservice
    instances: 2
-    image: "bunch/myservice:${TRAVIS_BRANCH}"
+    image: "bunch/myservice:${TAG}"

It seems this breaks the way I was using variables to define tags on my docker images. I did not have to check this during the RC, but still wanted to share it here in case anyone else runs into it (which I doubt).

Thanks for reporting this regression as #2943. It's not an intended effect of this "breaking change", whichjust removed the default to: env: .... If you're explicitly using to-env in your YAML, then it should behave the same as before.


Add Llama2 inference benchmark under a new "benchmarks" section

This is basically the content of the benchmark paragraph in the corresponding blog post.
I have also added the scripts to run the benchmark and generate the images.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Ambient: should use istio.io/dataplane-mode=ambient for enrolling individual pods

Describe the feature request
Right now, adding the annotation ambient.istio.io/redirection: enabled to an individual pod implicitly enrolls that pod into ambient. This annotation is added by istio-cni to indicate it has already enrolled a pod, and is not really intended to be user-applied.
Adding the label istio.io/dataplane-mode=ambient to namespaces enrolls everything in the namespace.
This is a bit backwards and unintuitive, and sort of an unintended side effect - the ambient.istio.io/redirection: enabled annotation should not add or remove pods from ambient or munged by users at all, it is largely intended to be a status managed only by istio-cni, not a mechanism of user intent.
We should update the istio-cni logic to check for the label istio.io/dataplane-mode=ambient on both namespaces and individual workloads, for the sake of consistency, and if that label is found in either spot, that pod should be enrolled by istio-cni and get the annotation ambient.istio.io/redirection: enabled
Alternatively (implementer's choice/others can make cases) we can make both be labels, as described in the "alternatives" section - either would be fine, we just need to be consistent, and have one field for intent, and one field for status.
Describe alternatives you've considered

Make the ambient.istio.io/redirection: enabled annotation a label instead (both of them labels).

We don't have a specific need to do this at this time
It makes sense to keep labels as "intent" and annotations as "status"
We would be writing (heavier) labels on every pod add, as this label would continue to be a controller-written status.
Could theoretically make indexed querying easier (but we have no need to do that for this field right now, as the other label can be used for that)
This option IS on the table and would also be acceptable.

Make the istio.io/dataplane-mode=ambient label an annotation instead (both of them annotations)

Makes querying hard

Affected product area (please put an X in all that apply)
[x] Ambient
[x] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context
https://istio.slack.com/archives/C049TCZMPCP/p1712672952578429

(if we do not think this belongs as an ambient beta blocker, can remove)

Hi @bleggett, I'd like to work on this issue.
Thoughts/questions after an initial read-through:
1. In `cni/pkg/util/podutil.go`, update the `PodRedirectionEnabled` function to account for Pods labelled `istio.io/dataplane-mode=ambient`. This looks like it _should_ (?) cover all necessary checks in `cni/pkg/nodeagent/informers.go` (in functions `GetPodIfAmbient`, `GetAmbientPods`, and `reconcilePods`), allowing all Pods with this label to become enrolled in ambient and receive the annotation `ambient.istio.io/redirection: enabled`.

Yep.

2. Do we want to update the `PodInAmbient` function in `pkg/config/analysis/analyzers/utils/in_mesh.go` to account for this label? (i.e. return true if either the annotation `ambient.istio.io/redirection: enabled` or the label `istio.io/dataplane-mode=ambient` is set)

We should not need to change that - the CNI logic should add the annotation automatically, as a side effect of getting triggered to enroll the pod via the label.

@eoinfennessy happy to have you work on it, ping me if/when you open a PR and I will assign this issue to you, and feel free to reach out if you have questions!

@bleggett, thank you! I should have a PR for this before the week is out.