Change iOS compass offset dynamically [Feature request / Bug]

Summary
Hi, in our project we have a compass that has a starting offset position based on other components on the screen. After few seconds of scrolling the map we are hiding those components and it would be nice to move compass to the top of the screen. Currently it is not possible to change compass position dynamically.
Reproducible sample code
import React, { useState } from 'react'
import MapView from 'react-native-maps'

export const BaseMapView = () => {
  const [compassOffsetY, setCompassOffsetY] = useState(150);

  const onOtherComponentsHide = () => {
    setCompassOffsetY(20)
  }

  // Call the otherComponentsHide after 6 seconds of scrolling the map or whatever action
  // to reproduce it could be even onPress event
  return (
    <MapView compassOffset={{x: 0, y: compassOffsetY}}/>
  )
}

Steps to reproduce
Use provided code reproducible code and try to modify compass offset.
Expected result
Compass will move from y=150 to y = 20.
Actual result
Compass stays at his initial position.
React Native Maps Version
1.8.0
What platforms are you seeing the problem on?
iOS (Apple Maps)
React Native Version
0.72.4
What version of Expo are you using?
Not using Expo
Device(s)
iPhone 15
Additional information
The main point of this issue is to get information if such a feature will be helpful for anyone or if it's only our, very edge case problem. I couldn't open an issue with another label and I would say that it's not a bug, but rather a missing feature.

@mateki0 Thank you for your request, as you mentioned this is not a bug since it's not an unexpected behaviour.
and yes as you mentioned it's such a niche request it doesn't make sense for us to consider adding it to the library itself.
I would recommend that you look into:
https://stackoverflow.com/questions/48343381/how-to-reposition-compass-of-mkmapview
seems very possible to apply your package patch to this library where you add some native / JS glue to modify the functionality of MKMapView without having to maintain your own fork of the library.
https://github.com/ds300/patch-package


Sync hang for 22 minutes on mainnet after checkpoint error

Version
zebrad main branch, as at 19 October 2019.
Platform
Linux ... 5.4.68 #1-NixOS SMP Sat Sep 26 16:03:16 UTC 2020 x86_64 GNU/Linux
Description
zebrad start on mainnet did not output any logs at info level for 22 minutes. It restarted sync after a checkpoint error, started obtain_tips, then hung for 22 minutes. Then it logged a similar checkpoint error.
I tried this:
Running zebrad start on mainnet, with some global and some local peers.
My network is slower and higher latency than the average Zebra developer.
I expected to see this happen:
zebrad start syncs up to the tip of the best chain.
Checkpoint errors contain a detailed explanation of the error, rather than a generic error message.
Instead, this happened:
Error Before Hang
Error:
   0: failed to verify block
   1: block could not be checkpointed

Metadata

key
value

version
3.0.0-alpha.0

SpanTrace and Logs

This error was preceded by at least one similar checkpoint error.
Oct 19 14:11:19.525  INFO sync: zebrad::components::sync: starting sync, obtaining new tips
Oct 19 14:11:19.525  INFO sync:obtain_tips: zebra_state::util: created block locator tip_height=Height(106000) min_locator_height=105901 locators=[Height(106000), Height(105999), Height(105998), Height(105996), Height(105992), Height(105984), Height(105968), Height(105936), Height(105901)]
Oct 19 14:11:31.034  WARN sync: zebrad::components::sync: sync error in ready task, waiting to restart sync e=
   0: zebrad::components::sync::block_fetch_verify
           with hash=0000000020a7360c83af082530bd98a573f8ba543ab742605b846955b0bc43f4
             at zebrad/src/components/sync.rs:615
   1: zebrad::components::sync::obtain_tips
             at zebrad/src/components/sync.rs:314
   2: zebrad::components::sync::sync
             at zebrad/src/components/sync.rs:169
Oct 19 14:13:11.037  INFO sync: zebrad::components::sync: starting sync, obtaining new tips
Oct 19 14:13:11.037  INFO sync:obtain_tips: zebra_state::util: created block locator tip_height=Height(106000) min_locator_height=105901 locators=[Height(106000), Height(105999), Height(105998), Height(105996), Height(105992), Height(105984), Height(105968), Height(105936), Height(105901)]

There was no info-level output for 22 minutes after the hang, then it logged a similar error, but only delayed for about 2 minutes.

@hdevalence I think you were the last person to modify the sync code, do you have any insights here?
@yaahc how can we show the detailed checkpoint error message in the logs, rather than just "block could not be checkpointed" ?

how can we show the detailed checkpoint error message in the logs, rather than just "block could not be checkpointed" ?

I tried adding #[source] to the inner errors, based on:
https://docs.rs/thiserror/1.0.21/thiserror/#details
If that's a good way to fix this issue, let's open a follow-up ticket to do that for all error types in every zebra crate?

The Windows CI sync tests also hang intermittently, when initialising the syncer:
https://github.com/ZcashFoundation/zebra/pull/1179/checks?check_run_id=1280264596
The hangs might be due to this bug, or they might be caused by the network on the CI host.

I saw similar issues while getting #1041 working but plumbing error context through the checkpointer was more work than I wanted to commit to doing in that chunk of work.

If that's a good way to fix this issue, let's open a follow-up ticket to fix all the error types in every zebra crate?

I think we may want to make a style choice here and choose to avoid Tuple style enum variants in our error types. If we write the errors as struct-style enum variants where we always remember to name the source error field source then thiserror will always automatically use that as a source error kind. I feel like with tuple enums + an error derive it is way too easy to make this mistake and accidentally break the chain of source errors.

Unblocked by #1041 and #1198.

We think this issue is fixed by the RocksDB change in #1325.


VRL support for the ingest APi

Right now VRL is not supported for the PushAPI (!?)
Can we add move this to the docmapper?

duplicate of #3549
(for details, the ingest API technically supports VRL, but you can't configure it without messing manually with the metastore)

thx


Authentication process isn't fully implemented

[ ] handling of failed authentication on client side
[ ] implement authenticate device


ISPN-7047 Wait for conatiner after creating it

https://issues.jboss.org/browse/ISPN-7047

both comments addressed, PR updated


How to add local project setting

how can add local project setting for any lsp i want.
something like nvim-lspconfig described.
.nvimrc and .exrc do not any effect on the local project

I don't know. But I don't think it's related to this plugin.


gemspec: Update mini_magick version requirement to 4.9.4

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
We received a GitHub dependency security vulnerability alert for our projects using fastlane. The dependency in question is mini_magick which is used by fastlane.

CVE-2019-13574
Vulnerable versions: < 4.9.4
Patched version: 4.9.4
In lib/mini_magick/image.rb in MiniMagick before 4.9.4, a fetched remote image filename could cause remote command execution because Image.open input is directly passed to Kernel#open, which accepts a '|' character followed by a command.

Description
I've updated mini_magick's version requirement from 4.5.1 to 4.9.4. Following other dependency declarations in fastlane.gemspec I've also added an upper bound (< 5.0.0).
To test, I've run bundle install, bundle exec rspec, and bundle exec rspec frameit.
closes #15043

I signed it!

On 18.07.2019, at 16:50, googlebot<EMAIL_ADDRESS>wrote:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
Corporate signers
Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot http://go/cla#troubleshoot (Public version https://opensource.google.com/docs/cla/#troubleshoot).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must also be attached to your GitHub account https://github.com/settings/emails.
ℹ Googlers: Go here https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Ffastlane%2Ffastlane%2Fpull%2F15042 for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/fastlane/fastlane/pull/15042?email_source=notifications&email_token=AEIMT6A4OPPK7Q5UGOJGAITQAB7JRA5CNFSM4IE4JRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2IXFSI#issuecomment-512848585, or mute the thread https://github.com/notifications/unsubscribe-auth/AEIMT6AXAMOO3TZ5GGRLKJTQAB7JRANCNFSM4IE4JRBQ.

Thanks for the quick turnaround!

Btw, when can we expect some releases to include these fixes?

FYI this fix breaks the appicon plugin for me.

I think this has break the appicon plugin for me too. I'm getting this error after I have updated the fastlane :

Error loading plugin 'fastlane-plugin-appicon': Unable to activate fastlane-plugin-appicon-0.10.0, because mini_magick-4.9.5 conflicts with mini_magick (~> 4.5.1)
It seems like you wanted to load some plugins, however they couldn't be loaded
Please follow the troubleshooting guide: https://docs.fastlane.tools/plugins/plugins-troubleshooting/

Any help on this ?


ResultSetMetaData throws exception when used on select statements with schema name or quoted table names

When a ResultSetMetaData is requested for a query like SELECT * FROM INFORMATION_SCHEMA.INDEXES or SELECT * FROM FOO, some of the methods will throw an exception about an unknown column on index X.

Fixed in version 1.0.7


为什么一直初始化不了解码器？

为什么一直初始化不了解码器，请问您是使用的哪个版本的mpp？
panic: MPP_ERR_NULL_PTR

goroutine 1 [running]:
main.main()

main.main()
	/opt/www/infer/abc/abc.go:13 +0x174

This library has not been developed for over two months (I'm sorry :( ), and as far as I know (important), mpp may have had a significant number of updates during this time.
Please provide the minimal reproducible code you used, and I will investigate the issue as soon as possible.

以下是我编译MPP的过程
mkdir -p /opt/mpp && cd /opt/mpp
git clone -b jellyfin-mpp --depth=1 https://github.com/nyanmisaka/mpp.git rkmpp
pushd rkmpp
mkdir rkmpp_build
pushd rkmpp_build
cmake \
    -DCMAKE_INSTALL_PREFIX=/usr \
    -DCMAKE_BUILD_TYPE=Release \
    -DBUILD_SHARED_LIBS=ON \
    -DBUILD_TEST=OFF \
    ..
make -j $(nproc)
make install

The test code is exactly the code used in your example.

Hi,
I'm try to fixed in 92b57a3e430c1d026cd61505ca6522a12b0e048b, It could run through in my board.
go get -u<EMAIL_ADDRESS>Let me know if you have any issue else.

Hi,
Sorry for the delayed response. My board, the OrangePi5, accidentally had a short circuit between the 5V pin and the GND pin, and now it's on its way to the factory :(
Once the board is back, I will supplement it with some samples and test data that can run on my device, which are all about ready.

Hi,
Sorry for the delayed response. My board, the OrangePi5, accidentally had a short circuit between the 5V pin and the GND pin, and now it's on its way to the factory :( ~Once the board is back, I will supplement some samples and test data that can run on my device, which are all about ready.~ It's dead. I have to buy new one.

Glad to see you're continuing to maintain the code again; it looks like your new development board has returned.


gui

My issue is not really about commands and what not since my instillation went great but is it possible if you the microfsoft wsl devs could make a gui for the wsl to give users a very native feel of kali instead of just using the cli

See this article https://www.kali.org/news/kali-linux-in-the-windows-app-store/. You can find the GUI tutorial video at last in that article.

#637

exactly where on the page
On Sun, May 20, 2018 at 11:16 PM, therealkenc<EMAIL_ADDRESS>wrote:

Closed #3217 https://github.com/Microsoft/WSL/issues/3217.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/WSL/issues/3217#event-1636029939, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Ak4G1S1x48S2fbz3ORIwu3NiRn2Qnzpmks5t0c86gaJpZM4UGA9d
.

it is ok i found out how
On Thu, May 24, 2018 at 6:04 PM, Joshua Tabuti<EMAIL_ADDRESS>wrote:

exactly where on the page
On Sun, May 20, 2018 at 11:16 PM, therealkenc<EMAIL_ADDRESS>wrote:

Closed #3217 https://github.com/Microsoft/WSL/issues/3217.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/WSL/issues/3217#event-1636029939, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Ak4G1S1x48S2fbz3ORIwu3NiRn2Qnzpmks5t0c86gaJpZM4UGA9d
.


1.0.2-RC1: Fix the IdentityFlowProcessorVerification class

This PR fixes the IdentityFlowProcessorVerification class as it did not properly use the FlowAdapters and required the developer to specify helper structures manually and unnecessarily.
The LockstepFlowProcessorTest was ported as a native Flow.Processor implementation to ensure IdentityFlowProcessorVerification is properly implementable.
Related: https://github.com/reactive-streams/reactive-streams-jvm/issues/413#issuecomment-349640154

Thanks for finding, and fixing, this issue, David!
@reactive-streams/contributors Merge?

Awesome, @akarnokd!
@reactive-streams/contributors Merging


Use struct for Avg map value type

Similar to how min/max works, instead of storing
two keys (one for total and one for count) for
each user key store a struct with the total and
count. This skips an additional map lookup and
allows users to loop over avg type maps.
This also fixes implicit casting of avg in
kernel space when the avg is a negative number.
Checklist

[ ] Language changes are updated in man/adoc/bpftrace.adoc
[ ] User-visible and non-trivial changes updated in CHANGELOG.md
[ ] The new behaviour is covered by tests

Just as a high level comment: if we're changing avg then should we be changing stats at the same time? They currently share an implementation and this PR splits them so we've got two different versions.

Ah I didn't realize they were so close. Yes, I'll just update stats so it uses the same struct as avg. I'll also switch 'avg' back to printing out 'stats' as the map type just to not be a breaking change.

@ajor Gentle ping


Preview effects on options screen

Open chrome://extensions/?options=mlneofdamjbcmahdcjjbmbjomedanhal
Change option
Expect: Preview area on options screen shows what the effect looks like, so I can pick the "best" choice for my taste.

I want this, too. :-)
Do you have an idea for a good test image I can use for the preview?
I got stuck on that part.


fix: Show the number of seed words correctly (don't split across lines)

Fixes #2443

The 2nd commit that I added also makes the layout shift less when clicking the visibility button
Before:
https://github.com/get10101/10101/assets/6688948/4983f6e8-33fd-41e9-8fbe-0917fb8f058d
After:
https://github.com/get10101/10101/assets/6688948/a7fe3bd3-705c-4096-a436-85c73730ad0a


Terminal transcript

Welcome to Termux!
Communities: https://termux.org/community
Gitter chat: https://gitter.im/termux/termux
IRC channel: #termux on libera.chat
Working with packages:

Search packages:   pkg search
Install a package: pkg install
Upgrade packages:  pkg upgrade

Subscribing to additional repositories:

Root:     pkg install root-repo
X11:      pkg install x11-repo

Report issues at https://termux.org/issues
~/downloads $ root
No command root found, did you mean:
Command broot in package broot
Command proot in package proot
~/downloads $ debug
No command debug found, did you mean:
Command debugfs in package e2fsprogs
Command h5debug in package libhdf5
~/downloads $ pkg install e2fsprogs
Checking availability of current mirror: ok
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following packages were automatically installed and are no longer required:
libidn libtiff openjpeg
Use 'apt autoremove' to remove them.
The following NEW packages will be installed:
e2fsprogs
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 738 kB of archives.
After this operation, 5009 kB of additional disk space will be used.
Get:1 https://dl.kcubeterm.com/termux-main stable/main aarch64 e2fsprogs aarch64 1.46.5-1 [738 kB]
Fetched 738 kB in 3s (225 kB/s)
Selecting previously unselected package e2fsprogs.
(Reading database ... 46428 files and directories currently installed.)
Preparing to unpack .../e2fsprogs_1.46.5-1_aarch64.deb ...
Unpacking e2fsprogs (1.46.5-1) ...
Setting up e2fsprogs (1.46.5-1) ...
Processing triggers for man (1.14.5-3) ...
~/downloads $

**
**


haskell-ng: nix-build using old cabal version

I generated a simple .nix file using cabal2nix .. Now when I try to build this using nix-build -E 'with (import <nixpkgs> {} ); haskellngPackages.callPackage ./structured-haskell-mode.nix {}' it tries to use Cabal 1.18 by default. This seems strange because otherwise 1.22 seems to be the default and also causes breakage because you don't seem to be able to compile something with Cabal 1.18 that links to libs built with 1.22. Adding an explicit Cabal_1_22_0_0 to the arguments and buildDepends fixes this problem.

I'm not sure what you mean. Builds in haskellngPackages always use the native version of Cabal that comes with the compiler -- and that would be 1.8.x in case of GHC 7.8.x. Cabal 1.22.x isn't used.

Ok, looks like I missread the source when I had a quick look earlier. I guess what was confusing me is that cabal-install is using cabal 1.22 (line 11 in configuration-common.nix).


Travis CI is not reporting in pull requests

I am experiencing this issue with several other repositories. I have solved it in all of my personal repositories by migrating to travis-ci.com. But for my repositories that are in organizations, this didn't seem to solve the issue. I would like admin permissions to be able to attempt to fix this issue, @paldepind, please.

Migrated to travis-ci.com and we have integrated reporting again. Awesome.


Inventory parsing role

first iteration on creating a tool/ play to parse ansible inventory into  nagios inventory
fixes #2629
signed off by @lumuchris256

Have you run the python script to see if it produces the cfg files?
I tried running it in a container and got a syntax error
root@83c64d4f6731:~/infrastructure# python ansible/playbooks/nagios/roles/Nagios_Config/scripts/nagios_yaml.py
  File "ansible/playbooks/nagios/roles/Nagios_Config/scripts/nagios_yaml.py", line 101
    with open(f"{formatted_name}.cfg", "w") as f:
                                    ^
SyntaxError: invalid syntax

I am using Python 2.7.16 for reference

I have severally, though out of a container  stand alone

Side comment, I think Python 3 should be the runtime here if possible.


More strict handling of Date object

  @Field(Date)
  public end_time: Date;

When i'm passing "start_time": "",
I get no validation error, but null. same for when passing blah string.
When passing number.
Is there a way to make it accept only JSONed date objects?

plainToClass does not validate per default. You should use validate before you pass the data into plainToClass
class Entity {
  @Field(Date)
  public end_time: Date;
}
const data = {end_time: ""};
const errors = validate(Entity, data);
if (errors.length) {
    //handle it
}
const entity = plainToClass(Entity, data);

I just pushed a new method validatedPlainToClass which does both at the same time. It throws ValidationFailed exception when validation failed.
await validatedPlainToClass(Entity, data);

I also added more Date validations, they were basically non-existent. Thanks for pointing out! Let me know if that fixes for you.

I also removed the async nature of validation, as there was basically no need for t.

Released in v0.8.0.

I'm actually using the Marshal ValidationPipe and had this problem there

I see, should be fixed now =)

Thank you very much!


Damping implementation

Work in progress

@matt-frey: Let me know if the layout etc. looks OK now.


transfer speed is shown incorrectly on slower then internet storage

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
hi,
i have some bad setup, i am writing to an usb2 hard disk with is mounted using wifi using sshfs, normally that is fine and all but when i have a couple of transfer jobs running at the same time the it drops so deep that it is slower then the internet speed, but it is not shown correctly (compere download speed and time left). Also i would appreciate if the FixupM3u8 step could be improved maybe with using /tmp/ instead of the destination to speed thins up a little...
thanks in advance for looking into it
relevant  Output
not relevant to show the whole stuff but manually braking lines at the right tme to get comparable values is key in this case...:
[download]  21.2% of ~ 380.38MiB at    1.31MiB/s ETA 12:01 (frag 33/152)
[download]  35.6% of ~ 361.28MiB at    1.35MiB/s ETA 03:03 (frag 54/152)
[download] 100% of  320.70MiB in 00:06:18 at 868.70KiB/s

here you can see what happens when a ytdlp transer is done while the blocking transfer is is just getting finished, note that MiB/s dosnt represent the actual transfer speed, while it is waiting for the storage, also maybe a good idea to write fragments and part files to /tmp and not to the destinaton if it is network storage
PS: yes i omitted the verbose log steps for a good reason: it is not reproducible, i was happy to be able to capture the behavior at all, also it is hardly relevant given my hopefully adequate description

also maybe a good idea to write fragments and part files to /tmp

-P "temp:/tmp"


#153009907 Setup Continuous Integrations and Badges

What does the PR do?
Establishing continous integration and test coverage reports
Description of task to be completed

Include config files of continuous integration services
Add badges that reflect test build and coverage to read me

How should this be manually tested?

Clone the project repository
$ git clone https://github.com/AppCypher/EventsManager

Checkout into the proper branch
$ git checkout ch-continuous-integration-153009907

This project requires Nodejs and it is expected to run in Nodejs version 6 or higher

Install project dependencies by running
$ npm install

There project bundles task runners that make trying out parts of the project easy to use

Below is a list of some of the available task runners

server to start the server

test:api to run the api test suite

build to start webpack build on all server, frontend and test suite code

build:server to start webpack build on server code

build:client:dev to start webpack build on client code under a dev environment variable

build:client:prod to start webpack build on client code under a production environment variable

To run the server or test suite, the project code needs to be built
$ npm run build

Background context

Tests scripts need to return lcov.info for proper test coverag with code climate

Relevant pivotal tracker stories
153009907

Changes Unknown when pulling 631830a4ce227c1c2d9c3f64f4e2fc356f5c2992 on ch-continuous-integration-153009907 into ** on dev**.


feat: optional tab namespacing

Description
This adds the ability to optionally provide a name value to a tab, and have it function the same as a Group when storing/retrieving from the database.
As an example, the following collection:
const collection = {
  slug: 'tab-examples',
  fields: [
    {
      type: 'tabs',
      tabs: [
        {
          label: 'First tab'
          fields: [
            {
              name: 'text'
              label: 'Text'
            }
          ]
        },
        {
          name: 'myTab',
          label: 'Second tab'
          fields: [
            {
              name: 'text'
              label: 'Text'
            }
          ]
        },
      ]
    }
  ]
}

Would return this data:
{
  "myTab": {
    "text": "This is exampled text in a named tab."
  },
  "text": "This is example text"
}

[x] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Existing test suite passes locally with my changes
[x] I have made corresponding changes to the documentation

I had a couple of questions before I mark it ready for review:

I'm having issues with displaying the values in the example array within Tab with Name. I updated how paths are defined for tabs (here and here), and the name attribute of the inputs reflects this with tab.array.X.text. Also updating and saving the field correctly updates the data in the database (confirmed via GraphQL response), but on initial render the text values in tab.array use the values from array. I feel like I've missed something – any ideas?
I'm not very familiar with test suites, but I couldn't see anything that was testing the Tabs field implementation (maybe because they were only presentational?). Is this something that needs to be added?

This is my first time contributing to a repo this complex, so all feedback is welcome!

@slavanossar I pushed some updates to your branch, good work overall. Some of the changes I covered were:

named tabs make the label optional
unnamed tabs cannot be localized
typescript types and schema validation for tabs is more accurate regarding above changes
tabs cannot be localized at the main level
added tests

There seems to be an issue with default values inside of the tabs still. If you have time to look at it, let us know, otherwise I'll pick it back up when I get time.
We also need some graphql tests coverage.
More manual testing should be done before merging, aside from just the automated testing mentioned.

Hey @slavanossar — thanks again for the work on this branch. You really dove in there and got a lot done and this feature adds a lot of value.
The team and I went through everything this evening and wrapped it up. All tests pass, features are built, and everything's working great!
THANK YOU!

Sorry I completely missed Dan's response, been pretty busy the past month with work.
Thanks for completing it, will go through and have a read through the additional changes so I can understand it better 👍


Remove pivot totals

Hi,
Is there any way I could remove the row totals and column totals?

@nicolaskruchten thanks for your reply!


fix java.lang.IllegalStateException: Read only 0 bytes!

Fixes https://github.com/micronaut-projects/micronaut-data/issues/1295

I don't think so, the type that is returning 0 is ByteArrayInputStream which is a JDK class

oh i see. because the buffer is exactly the size of the input stream, the buffer has no more space in the final read call, in which case it is valid to return 0.
But that means that this code doesn't work (the previous one didn't either) if InputStream.available is wrong. InputStream.available is an optional method, and it looks like users can supply their own streams, so we should fix this

yeah I am not sure relying on available() is the correct thing to do here. Seems we should create a reasonable size buffer and then resize if necessary 🤔

just copy to a ByteArrayOutputStream and then ByteBuffer.wrap the returned byte array, i guess

yeah probably for the best

lgtm


Add BLS12-381 verification

Abstract
Barreto-Lynn-Scott ("BLS") signature verification will become more important for Fuel as we deploy to data constrained environments like Ethereum. In this PR we define a BLS signature verification operation for the Fuel Virtual Machine.
This operation allows three modes: singular, aggregate and special aggregate verification of BLS12-381 signatures.
Proposed Modes

Single signature verification - signature, message and public key are in memory
Aggregate verification - signatures, messages, and public keys are in memory
Special aggregate verification - (i.e. "allow the block producer to optionally aggregate my signature mode") - public key and message is in memory and is either included in an aggregate signature batch with other public keys, messages and a valid aggregate signature within the block or the individual signature is in memory

Notes

Here for mode 3, the user would submit their transaction and witness data to the mempool, but there is no guarantee the signature will be available in memory as it may have been aggregated.
Gas prices can be done based upon the number of messages to be aggregated upfront
Perhaps the third option can fit into an optional transaction policy (as it's a special case)

Would request HashCloak to writeup the cryptographic specifics in the cryptography section of the specifications.

Abstract
Barreto-Lynn-Scott ("BLS") signature verification will become more important for Fuel as we deploy to data constrained environments like Ethereum. In this PR we define a BLS signature verification operation for the Fuel Virtual Machine.
This operation allows three modes: singular, aggregate and special aggregate verification of BLS12-381 signatures.
Proposed Modes

Single signature verification - signature, message and public key are in memory

Aggregate verification - signatures, messages, and public keys are in memory

Special aggregate verification - (i.e. "allow the block producer to optionally aggregate my signature mode") - public key and message is in memory and is either included in an aggregate signature batch with other public keys, messages and a valid aggregate signature within the block or the individual signature is in memory

Notes

Here for mode 3, the user would submit their transaction and witness data to the mempool, but there is no guarantee the signature will be available in memory as it may have been aggregated.

Gas prices can be done based upon the number of messages to be aggregated upfront

Perhaps the third option can fit into an optional transaction policy (as it's a special case)

Would request HashCloak to writeup the cryptographic specifics in the cryptography section of the specifications.


[ERROR => kiss update] POSIX requires LOGNAME be set while doing kiss update

While doing kiss update, I get this error:
/usr/bin/kiss: line 1936: LOGNAME: POSIX requires LOGNAME be set
Any solution?

Just do export LOGNAME="$(logname)".

Just do export LOGNAME="$(logname)".
Would It work if I put in the /etc/profile.d/?

Maybe. I just put it in my ~/.profile since I don't really use any other account.

My logname variable seems to be empty and when I redo kiss update, It doesn't seem to be working.

Seems like a log-out and log-in from the chroot seems to get it work.

You can also do LOGNAME=yourusername manually as an alternative rather than relying on $(logname). That's why I recommended it on ~/.profile and not /etc/profile.d.

I hope doing it in the /etc/profile.d doesn't creates any problems. I hope so...


Problem with launching ReshadeforUWP.exe

Hi,
Thanks Milky for you work and your tutorial.
I'm metting a problem on th the first step of the installation process.
Indeed, I just launched the ReshadefoUWP.exe  a screen quickly appear (like 0.1 seconds) and nothing happen after. I don't have have the screen where I can target flighsimulator.exe
I disabled my antivirus and Windows firewall but nothing change.
Maybe I did something wrong?
Thanks in advance for you answer

Windows 10, this is exactly what happens for me as well, no matter which version I try. Added an exemption as well, same result. Disabled firewall, same result.
I'm guessing it's just busted because it hasn't been updated in like 3 months?

Hi.
I didn't find a direct solution for it but now I use Nvidia application for putting filters inside game. You can also add Reshade filters and it works well, no fps addition on my side

Those filters are probably a decent solution, I've used them before.


Standard key bindings for tree navigation

Issue Type: Feature Request
ADS doesn't support standard Windows10 key bindings for navigating its treeview.
In File Explorer, Visual Studio, SSMS, etc you can use the cursor keys to navigate up and down, with the left/right keys expanding and collapsing the selected folder. In particular if you scroll down a long list of stored procedures, you can press 'left' to collapse the parent folder, which makes it much quicker and easier to (e.g.) get out of the list of procs to find a table., or get out of one database and into another one.
This may sound a small feature but it makes ADS so clumsy and slow to use that I have been forced (reluctantly) to revert to SSMS.
Azure Data Studio version: azuredatastudio 1.25.0 (8c6bd8c857592c14afbb589a7d307baec1f5b5ed, 2020-12-05T06:45:46.586Z)
OS version: Windows_NT x64 10.0.18363

@zotrb Thanks for opening this issue. In ADS, you can press Enter instead of right key to expand a folder. Rest of it should work exactly the same way. Is your request to change the Enter key to right key instead?

Hi Aditya,
Thanks for the quick response.
Yes, Space and Enter will expand or collapse the current item.
However, in Windows TreeViews, you can also use the cursor keys to navigate the hierarchy like this:
·        The -> right key should work as Enter and Space already do, to expand the selected item.
·        The <- left key will collapse the current item, but if it is already collapsed, it will move the cursor to the parent item.
That is, if you have the selection on a stored procedure like this:
<EMAIL_ADDRESS>In SSMS I can press <- (left cursor), and because the current selected item is already collapsed, it navigates the selection to the parent item:
<EMAIL_ADDRESS>If I then press <- a second time, it collapses the selected item, like this:
<EMAIL_ADDRESS>This means I can quickly navigate open/collapse whole subtrees with the keyboard – much faster than with a mouse.
You can try this behaviour out in any tree-view – e.g. in SSMS or in a file explorer.
There are two cases where this is a massive improvement on using the mouse:

If I need to collapse 4 levels to close away the entire database I’m working on, I just press <- four times and I’m done.

When I have a large list of child items:

<EMAIL_ADDRESS>In this case I can’t see the parent folder at all, and I have to scroll up to find it. With the mouse or moving the cursor up the list one item at a time this can easily take 20-30 seconds on a large database, but in SSMS by pressing <- I can teleport instantly to the parent folder.
I use this a lot (e.g. when browsing stored procedures, if I want to go back and look at a table, I can use <- to get instantly back to the tables)
Best regards,
Jason
Jason Williams
Software Engineer Team Lead
T: +44 (0) 1908 650 098
E: jason.williams<EMAIL_ADDRESS>Red Bull Technology
Building 1, Bradbourne Drive
Tilbrook, Milton Keynes, UK
MK7 8BJ
[cid:amrbr_email_signature_817x160_05_4a18e18e-e152-4b33-994a-e34577bc4ebd.jpg]http://www.redbullracing.com/
Red Bull Technology Limited is a company registered in England and Wales under number 05202976 and whose registered office is Building 1, Bradbourne Drive, Tilbrook, Milton Keynes, MK7 8BJ
Please note, Red Bull Technology Limited only enter into contracts with suppliers based on Red Bull Technology Terms and Conditions of Purchase, copies of which are available on request. This e-mail is confidential and may contain valuable information. If you are not the intended recipient, you should not copy it, re-transmit it, use it or disclose its contents, but should return it to the sender immediately and delete your copy from your system.
From: Aditya Bist<EMAIL_ADDRESS>Sent: 10 December 2020 21:08
To: microsoft/azuredatastudio<EMAIL_ADDRESS>Cc: Jason Williams<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/azuredatastudio] Standard key bindings for tree navigation (#13749)
@zotrbhttps://urldefense.com/v3/__https:/github.com/zotrb__;!!NVy5GN1c4PwkIg!jL977Qb8UXgM-VnQp9aBhaibydsTJeQlldvbCdvDiZnHpCLM3a9iwrVPTHwKjm7MHnu3YR_OyrFy8g$ Thanks for opening this issue. In ADS, you can press Enter instead of right key to expand a folder. Rest of it should work exactly the same way. Is your request to change the Enter key to right key instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/microsoft/azuredatastudio/issues/13749*issuecomment-742799667__;Iw!!NVy5GN1c4PwkIg!jL977Qb8UXgM-VnQp9aBhaibydsTJeQlldvbCdvDiZnHpCLM3a9iwrVPTHwKjm7MHnu3YR-gv6kjog$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ASCHOQ2DVJF5U2BM5XMYI33SUE2CFANCNFSM4UVBQGXQ__;!!NVy5GN1c4PwkIg!jL977Qb8UXgM-VnQp9aBhaibydsTJeQlldvbCdvDiZnHpCLM3a9iwrVPTHwKjm7MHnu3YR-Yayc5Xw$.


docs: fix typo in contributing guidelines

Change-type: patch
Signed-off-by: Lucian Buzzo<EMAIL_ADDRESS>

@LucianBuzzo Commit title needs to start with a capital letter
Other than that, lgtm

@thundron done


Move 520 trunk workflows to alpha1

This PR updates the 5.2.0+trunk workflows to target the public 5.2.0~alpha1

CI summary:

macOS trunk failed to build dune #433

Out of 44 workflows 1 failed with a genuine error

CI summary for merge to main:

MinGW bytecode trunk timed out during threadomain #203
macOS trunk failed to build dune #433
macos-arm64-5.2 aborted with a Fatal error: Failed to create domain in domain_spawntree #428

The last one should be fixed though, which may indicate erroneous CI caching.
Out of 45 workflows 3 failed - all with genuine errors


Not able to add a service link to a service when it is in active state.

Server Version - V0.20.1
Steps to reproduce the problem:
Create a service.start it.
Now Edit the service.
When a service link is added , clicking on the "save" /"cancel" button does nothing

Ugh, this is because labels are in the API now and the keys have dots in them ("io.rancher.service.name") and that doesn't play nicely with Ember, which uses that to mean labels['io']['rancher']['service']['name'].

v0.20.2
Verified fixed


🐛 [Locale-Emulator] Run error……

Bug report
Describe the bug
When I open some game with LE,than error show up.
Steps to reproduce
Steps to reproduce the behavior:

Open some Galgame(like 遊聖天使プリマヴェールDrei) with LE <IP_ADDRESS>
Error code:C00736B1

Expected behavior
can't run game

Additional context
The most of Galgame can be run by LE.Also can run most of Japanese TXT.I run it on Win7 and success,but when I change Win10 than LE show up this issue.All of the suggestion I already tried,but none of those work.

Click To Expand
---------------------------
Locale Emulator Version <IP_ADDRESS>
---------------------------
Error Number: C00736B1

Commands: "F:\PriveDrei.exe"

Microsoft Windows NT 10.0.19042.0 x64

NTDLL.DLL: 10.0.19041.610

KERNELBASE.DLL: 10.0.19041.572

KERNEL32.DLL: 10.0.19041.546

USER32.DLL: 10.0.19041.610

GDI32.DLL: 10.0.19041.546

If you have any antivirus software running, please turn it off and try again.

If this window still shows, try go to Safe Mode and drag the application executable onto LEProc.exe.

If you have tried all above but none of them works, feel free to submit an issue at

https://github.com/xupefei/Locale-Emulator/issues.

You can press CTRL+C to copy this message to your clipboard.

---------------------------
确定
---------------------------

@xupefei   need help:(

Hi @maidlover
Are you sure you're filling this issue in the correct repository?  I don't see anything related to Flutterfire
Closing, as this isn't an issue with flutterfire itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Using a common Layout component for Markdown pages and content collections

📚 Subject area/topic
Layouts
📋 Page(s) affected (or suggested, for new content)
https://docs.astro.build/en/basics/layouts/#using-one-layout-for-md-mdx-and-astro
📋 Description of content that is out-of-date or incorrect
I can't decide if this is a proposal, a bug report against Astro, or a documentation issue. It boils down to an ugliness with trying to re-use a Layout component between a Markdown page and a Markdown content collection entry, and how frontmatter keys are passed to the Layout component.
The Layout component of a Markdown page accesses frontmatter like Astro.props.frontmatter.author (docs).
The .astro file that renders a Markdown content entry accesses the frontmatter via Astro.props.data (docs). Following the documented conventions, these are passed through to a Layout component, which can then access the frontmatter like Astro.props.author.
This leads to confusion using the same Layout for both content entries and Markdown pages, how should the frontmatter be accessed? This is partially covered in the documentation, giving a workaround like this:
const { author } = Astro.props.frontmatter || Astro.props;

However, this is an incomplete solution, because content collections have a Zod schema that can include field transformations. For example, "dates written without quotes around them are interpreted as Date objects", and arbitrary transformations can be applied with .transform(). These transformations are skipped entirely for Markdown pages.
I think a more complete version would be:
import { collections } from '../content/config';
const { author } = Astro.props.frontmatter ? collections.blog.schema.parse(Astro.props.frontmatter) : Astro.props;

However, I think it would be conceptually clearer to address this another way. It's odd for a Layout component to have to invoke a parser / validator on its props.
🖥 Reproduction in StackBlitz (if reporting incorrect content or code samples)
No response

Hi, thank you for this report! We already have an issue about this exact line in docs, and an open PR #8763 where someone is attempting to improve this. I think that tells us this is pretty problematic, indeed!  :sweat_smile:
I'd love it if you commented in the PR itself to let us know whether that is on the right track for addressing your concern, and honestly, there's a case for removing that entire example entirely.
Fun fact: if I recall, that section was added after a breaking change to the Markdown props exported to .astro files (I think maybe even for v1.0!) At the time, we were helping to bridge the gap between people who might have needed to update projects and handle their props differently. We thought showing something like this was helpful back then, but certainly, it may have outgrown its use!
Please take a look and see whether the proposed PR seems like a helpful change, and/or let us know if you'd suggest removing this section entirely! Two issues is a pretty big indication that maybe the content is more harmful than helpful!


[docs] Incorrect decoration implementation shown

I was browsing through HTML/CSS patterns section of documentation and noticed one thing under Setting Background Color section, document has following notes

In Flutter, you set background color in a Container’s decoration property.

and shows this implementation
var container = new Container( // grey box
    child: new Text(
      "Lorem ipsum",
      style: bold24Roboto,
    ),
    width: 320.0,
    height: 240.0,
    color: Colors.grey[300],
  );

From what I've seen, don't width, height and color need to go under decoration?
decoration: new BoxDecoration(
    width: 320.0,
    height: 240.0,
    color: Colors.grey[300],
)

Found in the current documentation. The section mentioned still vague.

@Hixie My PR was just merged. Perhaps we can close this now?

Hi @TheBiirb
Thank you for confirming that is was fixed.
Closing as fixed.


Disable Validator

Is there currently any way to disable the "Error {...}" validation indicator when the API is not visible to the public internet (e.g. is an internal API)?

Error message is "{"schemaValidationMessages":[{"level":"error","message":"Can't read from file http://[internalurladdress]/swagger/v1/swagger.json"}]}" as expected because the validator at online.swagger.io cannot reach the internal address.
Previous version of Swashbuckle offered configuration to change or disable the validator as shown below, however I do not see options for configuration in the .Net Core packaged version:
httpConfiguration
    .EnableSwagger(c => c.SingleApiVersion("v1", "A title for your API"))
    .EnableSwaggerUi(c =>
        {
            c.InjectStylesheet(containingAssembly, "Swashbuckle.Dummy.SwaggerExtensions.testStyles1.css");
            c.InjectJavaScript(containingAssembly, "Swashbuckle.Dummy.SwaggerExtensions.testScript1.js");
            c.BooleanValues(new[] { "0", "1" });
            **_c.SetValidatorUrl("http://localhost/validator");
            c.DisableValidator();_**
            c.DocExpansion(DocExpansion.List);
            c.SupportedSubmitMethods("GET", "HEAD")
        });

I'm using "Swashbuckle": "6.0.0-beta902" .

Available with latest pre-release. Note the package rename to "Swashbuckle.AspNetCore.1.0.0-rc1"

@domaindrivendev I'm looking for the "DisableValidator" method and I can't find it - it seems not to have made the transition from Swashbuckle 6 to AspNetCore 1.x.....


Istio Not adding VirtualService.spec.hosts fields to generated routeConfig

Bug description
Istio Not adding VirtualService.spec.hosts fields to generated routeConfig
[ x] Networking
[ x] User Experience
Expected behavior
Istio should generate routeConfig that matches all of the virtualHosts provided in VirtualService.spec.hosts section
Steps to reproduce the bug
Hey , I am hitting an issue while trying to use VirtualService to route traffic to different subesets of backend. For the Context the VirtualService looks something like this
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata: {namespace: istio, name: service-A}
spec:
  hosts:
    - service-A
    - service-A.v2
    - service-A.v3
  http:
  # a rule per registration
  - match:
      - headers: {":authority": {exact: service-A.v2}}
    route:
    - destination: {host: service-A, subset: v2}
      weight: 100
  - match:
      - headers: {":authority": {exact: service-A.v3}}
    route:
    - destination: {host: service-A, subset: v3}
      weight: 100

```.
And the DestionationRule look like something this

apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata: {namespace: istio, name: service-A}
spec:
host: service-A # k8s service name
subsets:

name: v2
labels: {version: v2}
name: v3
labels: {version: v3}

For the endpoint discovery we have a single k8s service that contain all backends irrespective  of the version they are running
apiVersion: v1
kind: Service
metadata: {namespace: istio, name: service-A}
spec:
  selector: {service: service-A}
  ports: [{protocol: TCP, port: 8888}]

We were assuming that we can hit the the service name with specific host header and that will route the traffic to correct subset. For example
curl service-A:8080 -H "Host: service-A.v3" ------> Backend from subest v3
While trying to debug the issue, I noticed that in the route config of envoy there is an entry like below for listener bound to 172.x.x.x:8888 (172.x.x.x is service IP of service-A service).
"virtualHosts": [
 {
 "name": "service-A.istio.svc.cluster.local:8888",
 "domains": [
 "service-A.istio.svc.cluster.local:8888",
"172.x.x.x:8888".
 ]

I was assuming that the extra headers in VirtualService.pec.Hosts like service-A.v2 and service-A.v3 will also be added on the above routeConfig but that doesn’t seem to be case. Due to this any request send to above service with these specific host headers fail.
After searching the routeConfig for service-A.v2 or v3 and found a route config block port 80 (which i found weird since the service is  listening on port 80 ) something like this
Port: 80
"virtualHosts": [
 {
 "name": "service-A.v2",
 "domains": [
 "service-A.v2",
 ]}]```.

I tried using this route config by trying to do curl like below
`curl localhost:80 -H "Host: service-A.v2"`

But i am getting connection refused on port 80 which seems a bit weird since i can see a listener is bounded in envoy to address <IP_ADDRESS>:80
So for TLDR, there are two questions

Is it possible to add additional hostname entries in VirtualService.spec.hosts  that doesn’t exist in k8s service registry ( example service-A.V2 and still add them to some existing  routeConfig block in Envoy , I was assuming this can be done by adding those extra hostnames inside Virtualservice.spec.hosts but this doesn’t seem to be case
Is there some additional config require to access listener on port 80 since i can see a listener on <IP_ADDRESS>:80 but i can’t access them and getting connection refused

Istio Version: 1.10.2

@ramaraochavali this seems related to https://github.com/istio/istio/pull/34137
@Buffer0x7cd does it work if you make 3 virtual services (on for each hostname) instead of a single one?

I didn’t tried with creating 3 Virtual services but i did tried with creating 3 K8s services (one for each version) and it seem to work since now we have theree different routeConfig objects binded to 3 different Listeners  objects ( created on serviceIP:Port). The issue with this approach is that K8s does not allow putting dots in service names ( and out clients use the format of Service.Version , So we want to support clients calling services in Service-Name.Version format).
I will try with creating 3 different VirtualService and update here.

@howardjohn no, that doesn't work either, curling on port 80 (to hit route 80) with correct Host header results in "503 NC cluster_not_found"
related questions:

is there a way to stop istio from generating anything related to k8s Service object (listener on 8888, routes, etc)
why is our virtual service intercepted on port 80 and can this be changed?

I have added a test case https://github.com/istio/istio/pull/34208 - It seems to generate routes correctly. Not sure why you are getting routes under "80".  Is it possible for you to validate against master?

@ramaraochavali We have deployed the current system using master branch so not sure what you meant with  Is it possible for you to validate against master?

Istio Version: 1.10.2 - I see this. So I thought you are running 1.10.2? I meant running master build https://github.com/istio/istio?

ohh sure, will try with master. We got some partial success after switching to multiple VS , but we ran into a different issue from there
https://github.com/istio/istio/issues/34213

to be more specific, we had to specify port: {number: 8888} in our VS/route/destination for istio to correctly pick outbound cluster port, previouysly it was trying to send traffic to outbound port 80 which didn't exist

I am not sure where "80" route is coming from. Are you able to reproduce this in master?
@hzxuzhonghu Any idea why 80 is coming? I am not able to reproduce it master but istio 1.10.2 has it seems. Was any of your recent fixes would have fixed this?

could this be due to the fact that we're not using helm to install istio and instead generate and apply the manifest manually using istioctl menifest generate?
i see istio-ingressgateway service mentioning port 80:
---
apiVersion: v1
kind: Service
metadata:
  name: istio-ingressgateway
  namespace: istio-system
  annotations:
  labels:
    app: istio-ingressgateway
    istio: ingressgateway
    release: istio
    istio.io/rev: default
    install.operator.istio.io/owning-resource: unknown
    operator.istio.io/component: "IngressGateways"
spec:
  type: LoadBalancer
  selector:
    app: istio-ingressgateway
    istio: ingressgateway
  ports:
    -
      name: status-port
      port: 15021
      protocol: TCP
      targetPort: 15021
    -
      name: http2
      port: 80
      protocol: TCP
      targetPort: 8080
    -
      name: https
      port: 443
      protocol: TCP
      targetPort: 8443

@ramaraochavali  @hzxuzhonghu Considering even if we have port 80 listener created due to ingress-gateway, we are still not sure why we can see the routeConfig generated by VirtulalService binded on port 80
Our VirtualService looks something like this
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata: {namespace:istio, name: service-A-V2}
spec:
  hosts: [service-A.V2]
  http:
  - route:
    - destination: {host: service-A, subset:V2, port: {number: 8888}}
      weight: 100

apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata: {namespace: istio, name: service-A-destination}
spec:
  host: service-A # k8s service name
  subsets:
  - name: V2
    labels: {version:  V2}
  - name: V3
    labels: {version: V3}

 apiVersion: v1
kind: Service
metadata: {namespace: istio, name: service-A}
spec:
  selector: {service: service-A}
  ports: [{protocol: TCP, port: 8888}]

Since the port for the k8s service is 8888 we assumed that the generated routeConfig for service-A.V2 will be binded to listener on port 8888, but we can see that this routeConfig to also being attached to the Listener on port 80

@hzxuzhonghu Any idea why 80 is coming? I am not able to reproduce it master but istio 1.10.2 has it seems. Was any of your recent fixes would have fixed this?

https://github.com/istio/istio/issues/33760

@hzxuzhonghu I am not fully understanding - So what I get is your fix ensures that if there is no matching host it does not consider the route and add it 80. So the above case is fixed by your PR in master. Is that correct? If yes, should we backport that to 1.10?
And

https://github.com/istio/istio/issues/33760

Is  not clear to me. Are you saying the earlier code was a hack and you fixed? And what is else is remaining in https://github.com/istio/istio/issues/33760 to close?

I wanted to change the hack behavior, but the integration test depends on it. So i reverted the fix.

https://github.com/istio/istio/pull/33764#issuecomment-873505981

OK. Can we backport your fix to 1.10?

@ramaraochavali We tried the same config with a built from master branch and we couldn’t generate the additional VirtualHosts section. The only generated virtualHosts domains were for service-A. Is there a way to add the additional virtualHosts (service-A.V2, service-B.V3)  in a already existing virtualHosts block (service-A here). For testing we tried creating a VS with hosts sections mentioning service-A, service-A.V2, service-A.v3 and a k8s service with name service-A (please note there is no service for service-A.V2 and service-A.V3

Can you confirm if your config matches this test case https://github.com/istio/istio/pull/34208? I am seeing subset routes generated

@ramaraochavali Yeah just confirmed. , we are using the same config ( 1 k8s svc for service-A and 1 VitualHosts with Hosts values set to service-A, service-A.V2 and service-A.V3 ).
In the above setups subsets are still missing from the virtualHosts.
control plane version: 1.12-dev

@Buffer0x7cd Interesting. Can you please share config_dump? I want to understand why that routes are not generated?

@ramaraochavali  I have added the generated config below
route.json
[     {         "name": "compute-infra-test-service.paasta.svc.cluster.local:8888",         "virtualHosts": [             {                 "name": "compute-infra-test-service.paasta.svc.cluster.local:8888",                 "domains": [                     "compute-infra-test-service.paasta.svc.cluster.local",                     "compute-infra-test-service.paasta.svc.cluster.local:8888",                     "compute-infra-test-service",                     "compute-infra-test-service:8888",                     "compute-infra-test-service.paasta.svc",                     "compute-infra-test-service.paasta.svc:8888",                     "compute-infra-test-service.paasta",                     "compute-infra-test-service.paasta:8888",                     "<IP_ADDRESS>",                     "<IP_ADDRESS>:8888"                 ],                 "routes": [                     {                         "match": {                             "prefix": "/",                             "caseSensitive": true,                             "headers": [                                 {                                     "name": ":authority",                                     "exactMatch": "compute-infra-test-service.main"                                 }                             ]                         },                         "route": {                             "weightedClusters": {                                 "clusters": [                                     {                                         "name": "outbound|8888|main--k8s|compute-infra-test-service.paasta.svc.cluster.local",                                         "weight": 33                                     },                                     {                                         "name": "outbound|8888|crossover|compute-infra-test-service.paasta.svc.cluster.local",                                         "weight": 33                                     },                                     {                                         "name": "outbound|8888|downthenup|compute-infra-test-service.paasta.svc.cluster.local",                                         "weight": 34                                     }                                 ]                             },                             "timeout": "0s",                             "retryPolicy": {                                 "retryOn": "connect-failure,refused-stream,unavailable,cancelled,retriable-status-codes",                                 "numRetries": 2,                                 "retryHostPredicate": [                                     {                                         "name": "envoy.retry_host_predicates.previous_hosts"                                     }                                 ],                                 "hostSelectionRetryMaxAttempts": "5",                                 "retriableStatusCodes": [                                     503                                 ]                             },                             "maxGrpcTimeout": "0s"                         },                         "metadata": {                             "filterMetadata": {                                 "istio": {                                     "config": "/apis/networking.istio.io/v1alpha3/namespaces/paasta/virtual-service/compute-infra-test-service"                                 }                             }                         },                         "decorator": {                             "operation": "compute-infra-test-service:8888/*"                         }                     },                     {                         "match": {                             "prefix": "/",                             "caseSensitive": true,                             "headers": [                                 {                                     "name": ":authority",                                     "exactMatch": "compute-infra-test-service.autoscaling-2"                                 }                             ]                         },                         "route": {                             "cluster": "outbound|8888|autoscaling--2|compute-infra-test-service.paasta.svc.cluster.local",                             "timeout": "0s",                             "retryPolicy": {                                 "retryOn": "connect-failure,refused-stream,unavailable,cancelled,retriable-status-codes",                                 "numRetries": 2,                                 "retryHostPredicate": [                                     {                                         "name": "envoy.retry_host_predicates.previous_hosts"                                     }                                 ],                                 "hostSelectionRetryMaxAttempts": "5",                                 "retriableStatusCodes": [                                     503                                 ]                             },                             "maxGrpcTimeout": "0s"                         },                         "metadata": {                             "filterMetadata": {                                 "istio": {                                     "config": "/apis/networking.istio.io/v1alpha3/namespaces/paasta/virtual-service/compute-infra-test-service"                                 }                             }                         },                         "decorator": {                             "operation": "compute-infra-test-service.paasta.svc.cluster.local:8888/*"                         }                     }                 ],                 "includeRequestAttemptCount": true             }         ],         "validateClusters": false     } ]
listener.json
[     {         "name": "<IP_ADDRESS>_8888",         "address": {             "socketAddress": {                 "address": "<IP_ADDRESS>",                 "portValue": 8888             }         },         "filterChains": [             {                 "filterChainMatch": {                     "transportProtocol": "raw_buffer",                     "applicationProtocols": [                         "http/1.0",                         "http/1.1",                         "h2c"                     ]                 },                 "filters": [                     {                         "name": "envoy.filters.network.http_connection_manager",                         "typedConfig": {                             "@type": "type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager",                             "statPrefix": "outbound_<IP_ADDRESS>_8888",                             "rds": {                                 "configSource": {                                     "ads": {},                                     "initialFetchTimeout": "0s",                                     "resourceApiVersion": "V3"                                 },                                 "routeConfigName": "compute-infra-test-service.paasta.svc.cluster.local:8888"                             },                             "httpFilters": [                                 {                                     "name": "istio.metadata_exchange",                                     "typedConfig": {                                         "@type": "type.googleapis.com/udpa.type.v1.TypedStruct",                                         "typeUrl": "type.googleapis.com/envoy.extensions.filters.http.wasm.v3.Wasm",                                         "value": {                                             "config": {                                                 "configuration": {                                                     "@type": "type.googleapis.com/google.protobuf.StringValue",                                                     "value": "{}\n"                                                 },                                                 "vm_config": {                                                     "code": {                                                         "local": {                                                             "inline_string": "envoy.wasm.metadata_exchange"                                                         }                                                     },                                                     "runtime": "envoy.wasm.runtime.null"                                                 }                                             }                                         }                                     }                                 },                                 {                                     "name": "istio.alpn",                                     "typedConfig": {                                         "@type": "type.googleapis.com/istio.envoy.config.filter.http.alpn.v2alpha1.FilterConfig",                                         "alpnOverride": [                                             {                                                 "alpnOverride": [                                                     "istio-http/1.0",                                                     "istio",                                                     "http/1.0"                                                 ]                                             },                                             {                                                 "upstreamProtocol": "HTTP11",                                                 "alpnOverride": [                                                     "istio-http/1.1",                                                     "istio",                                                     "http/1.1"                                                 ]                                             },                                             {                                                 "upstreamProtocol": "HTTP2",                                                 "alpnOverride": [                                                     "istio-h2",                                                     "istio",                                                     "h2"                                                 ]                                             }                                         ]                                     }                                 },                                 {                                     "name": "envoy.filters.http.cors",                                     "typedConfig": {                                         "@type": "type.googleapis.com/envoy.extensions.filters.http.cors.v3.Cors"                                     }                                 },                                 {                                     "name": "envoy.filters.http.fault",                                     "typedConfig": {                                         "@type": "type.googleapis.com/envoy.extensions.filters.http.fault.v3.HTTPFault"                                     }                                 },                                 {                                     "name": "istio.stats",                                     "typedConfig": {                                         "@type": "type.googleapis.com/udpa.type.v1.TypedStruct",                                         "typeUrl": "type.googleapis.com/envoy.extensions.filters.http.wasm.v3.Wasm",                                         "value": {                                             "config": {                                                 "configuration": {                                                     "@type": "type.googleapis.com/google.protobuf.StringValue",                                                     "value": "{\n  \"debug\": \"false\",\n  \"stat_prefix\": \"istio\"\n}\n"                                                 },                                                 "root_id": "stats_outbound",                                                 "vm_config": {                                                     "code": {                                                         "local": {                                                             "inline_string": "envoy.wasm.stats"                                                         }                                                     },                                                     "runtime": "envoy.wasm.runtime.null",                                                     "vm_id": "stats_outbound"                                                 }                                             }                                         }                                     }                                 },                                 {                                     "name": "envoy.filters.http.router",                                     "typedConfig": {                                         "@type": "type.googleapis.com/envoy.extensions.filters.http.router.v3.Router"                                     }                                 }                             ],                             "tracing": {                                 "clientSampling": {                                     "value": 100                                 },                                 "randomSampling": {                                     "value": 1                                 },                                 "overallSampling": {                                     "value": 100                                 },                                 "customTags": [                                     {                                         "tag": "istio.authorization.dry_run.allow_policy.name",                                         "metadata": {                                             "kind": {                                                 "request": {}                                             },                                             "metadataKey": {                                                 "key": "envoy.filters.http.rbac",                                                 "path": [                                                     {                                                         "key": "istio_dry_run_allow_shadow_effective_policy_id"                                                     }                                                 ]                                             }                                         }                                     },                                     {                                         "tag": "istio.authorization.dry_run.allow_policy.result",                                         "metadata": {                                             "kind": {                                                 "request": {}                                             },                                             "metadataKey": {                                                 "key": "envoy.filters.http.rbac",                                                 "path": [                                                     {                                                         "key": "istio_dry_run_allow_shadow_engine_result"                                                     }                                                 ]                                             }                                         }                                     },                                     {                                         "tag": "istio.authorization.dry_run.deny_policy.name",                                         "metadata": {                                             "kind": {                                                 "request": {}                                             },                                             "metadataKey": {                                                 "key": "envoy.filters.http.rbac",                                                 "path": [                                                     {                                                         "key": "istio_dry_run_deny_shadow_effective_policy_id"                                                     }                                                 ]                                             }                                         }                                     },                                     {                                         "tag": "istio.authorization.dry_run.deny_policy.result",                                         "metadata": {                                             "kind": {                                                 "request": {}                                             },                                             "metadataKey": {                                                 "key": "envoy.filters.http.rbac",                                                 "path": [                                                     {                                                         "key": "istio_dry_run_deny_shadow_engine_result"                                                     }                                                 ]                                             }                                         }                                     },                                     {                                         "tag": "istio.canonical_revision",                                         "literal": {                                             "value": "latest"                                         }                                     },                                     {                                         "tag": "istio.canonical_service",                                         "literal": {                                             "value": "compute-infra-test-service-main--k8s"                                         }                                     },                                     {                                         "tag": "istio.mesh_id",                                         "literal": {                                             "value": "cluster.local"                                         }                                     },                                     {                                         "tag": "istio.namespace",                                         "literal": {                                             "value": "paasta"                                         }                                     }                                 ]                             },                             "streamIdleTimeout": "0s",                             "delayedCloseTimeout": "1s",                             "accessLog": [                                 {                                     "name": "envoy.access_loggers.file",                                     "typedConfig": {                                         "@type": "type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog",                                         "path": "/dev/stdout",                                         "logFormat": {                                             "textFormat": "[%START_TIME%] \"%REQ(:METHOD)% %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)% %PROTOCOL%\" %RESPONSE_CODE% %RESPONSE_FLAGS% %RESPONSE_CODE_DETAILS% %CONNECTION_TERMINATION_DETAILS% \"%UPSTREAM_TRANSPORT_FAILURE_REASON%\" %BYTES_RECEIVED% %BYTES_SENT% %DURATION% %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)% \"%REQ(X-FORWARDED-FOR)%\" \"%REQ(USER-AGENT)%\" \"%REQ(X-REQUEST-ID)%\" \"%REQ(:AUTHORITY)%\" \"%UPSTREAM_HOST%\" %UPSTREAM_CLUSTER% %UPSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_REMOTE_ADDRESS% %REQUESTED_SERVER_NAME% %ROUTE_NAME%\n"                                         }                                     }                                 }                             ],                             "useRemoteAddress": false,                             "upgradeConfigs": [                                 {                                     "upgradeType": "websocket"                                 }                             ],                             "normalizePath": true,                             "pathWithEscapedSlashesAction": "KEEP_UNCHANGED"                         }                     }                 ]             }         ],         "defaultFilterChain": {             "filters": [                 {                     "name": "istio.stats",                     "typedConfig": {                         "@type": "type.googleapis.com/udpa.type.v1.TypedStruct",                         "typeUrl": "type.googleapis.com/envoy.extensions.filters.network.wasm.v3.Wasm",                         "value": {                             "config": {                                 "configuration": {                                     "@type": "type.googleapis.com/google.protobuf.StringValue",                                     "value": "{\n  \"debug\": \"false\",\n  \"stat_prefix\": \"istio\"\n}\n"                                 },                                 "root_id": "stats_outbound",                                 "vm_config": {                                     "code": {                                         "local": {                                             "inline_string": "envoy.wasm.stats"                                         }                                     },                                     "runtime": "envoy.wasm.runtime.null",                                     "vm_id": "tcp_stats_outbound"                                 }                             }                         }                     }                 },                 {                     "name": "envoy.filters.network.tcp_proxy",                     "typedConfig": {                         "@type": "type.googleapis.com/envoy.extensions.filters.network.tcp_proxy.v3.TcpProxy",                         "statPrefix": "outbound|8888||compute-infra-test-service.paasta.svc.cluster.local",                         "cluster": "outbound|8888||compute-infra-test-service.paasta.svc.cluster.local",                         "accessLog": [                             {                                 "name": "envoy.access_loggers.file",                                 "typedConfig": {                                     "@type": "type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog",                                     "path": "/dev/stdout",                                     "logFormat": {                                         "textFormat": "[%START_TIME%] \"%REQ(:METHOD)% %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)% %PROTOCOL%\" %RESPONSE_CODE% %RESPONSE_FLAGS% %RESPONSE_CODE_DETAILS% %CONNECTION_TERMINATION_DETAILS% \"%UPSTREAM_TRANSPORT_FAILURE_REASON%\" %BYTES_RECEIVED% %BYTES_SENT% %DURATION% %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)% \"%REQ(X-FORWARDED-FOR)%\" \"%REQ(USER-AGENT)%\" \"%REQ(X-REQUEST-ID)%\" \"%REQ(:AUTHORITY)%\" \"%UPSTREAM_HOST%\" %UPSTREAM_CLUSTER% %UPSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_REMOTE_ADDRESS% %REQUESTED_SERVER_NAME% %ROUTE_NAME%\n"                                     }                                 }                             }                         ]                     }                 }             ]         },         "deprecatedV1": {             "bindToPort": false         },         "listenerFilters": [             {                 "name": "envoy.filters.listener.tls_inspector",                 "typedConfig": {                     "@type": "type.googleapis.com/envoy.extensions.filters.listener.tls_inspector.v3.TlsInspector"                 }             },             {                 "name": "envoy.filters.listener.http_inspector",                 "typedConfig": {                     "@type": "type.googleapis.com/envoy.extensions.filters.listener.http_inspector.v3.HttpInspector"                 }             }         ],         "listenerFiltersTimeout": "0s",         "continueOnListenerFiltersTimeout": true,         "trafficDirection": "OUTBOUND",         "accessLog": [             {                 "name": "envoy.access_loggers.file",                 "filter": {                     "responseFlagFilter": {                         "flags": [                             "NR"                         ]                     }                 },                 "typedConfig": {                     "@type": "type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog",                     "path": "/dev/stdout",                     "logFormat": {                         "textFormat": "[%START_TIME%] \"%REQ(:METHOD)% %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)% %PROTOCOL%\" %RESPONSE_CODE% %RESPONSE_FLAGS% %RESPONSE_CODE_DETAILS% %CONNECTION_TERMINATION_DETAILS% \"%UPSTREAM_TRANSPORT_FAILURE_REASON%\" %BYTES_RECEIVED% %BYTES_SENT% %DURATION% %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)% \"%REQ(X-FORWARDED-FOR)%\" \"%REQ(USER-AGENT)%\" \"%REQ(X-REQUEST-ID)%\" \"%REQ(:AUTHORITY)%\" \"%UPSTREAM_HOST%\" %UPSTREAM_CLUSTER% %UPSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_REMOTE_ADDRESS% %REQUESTED_SERVER_NAME% %ROUTE_NAME%\n"                     }                 }             }         ]     } ]
config.yaml
`# single service entity for all paasta service/instance entities
apiVersion: v1
kind: Service
metadata: {namespace: paasta, name: compute-infra-test-service}
spec:
selector: {paasta.yelp.com/service: compute-infra-test-service}
ports: [{protocol: TCP, port: 8888}]

destination rule declares subsets in a service for each paasta instance
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata: {namespace: paasta, name: compute-infra-test-destination}
spec:
host: compute-infra-test-service # k8s service name
subsets:

name: main--k8s
labels: {paasta.yelp.com/instance: main_k8s}
name: crossover
labels: {paasta.yelp.com/instance: crossover}
name: downthenup
labels: {paasta.yelp.com/instance: downthenup}
name: autoscaling--2
labels: {paasta.yelp.com/instance: autoscaling_2}

single VirtualService entity per paasta service
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata: {namespace: paasta, name: compute-infra-test-service}
spec:
hosts:
- compute-infra-test-service
- compute-infra-test-service.main
- compute-infra-test-service.autoscaling-2
http:
a rule per registration

match:

headers: {":authority": {exact: compute-infra-test-service.main}}
route:
destination: {host: compute-infra-test-service, subset: main--k8s}
weight: 33
destination: {host: compute-infra-test-service, subset: crossover}
weight: 33
destination: {host: compute-infra-test-service, subset: downthenup}
weight: 34

match:

headers: {":authority": {exact: compute-infra-test-service.autoscaling-2}}
route:
destination: {host: compute-infra-test-service, subset: autoscaling--2}
weight: 100
`

I do see main--k8s cluster configured to receive 33% of traffic
[ { "name": ":authority", "exactMatch": "compute-infra-test-service.main" } ] }, "route": { "weightedClusters": { "clusters": [ { "name": "outbound|8888|main--k8s|compute-infra-test-service.paasta.svc.cluster.local", "weight": 33 },
Now I am confused, what is missing?

The issue here is that while the above block is right, we dont have  compute-infra-test-service.main in virtualHosts section, So if we send a traffic tocompute-infra-test-serviceendpoint with host header set to compute-infra-test-service.main, it won’t match the virtualHosts which in turn cause envoy to skip the routing block

I can not reproduce either

@hzxuzhonghu what's the generated virtualHosts section in your test setup ?


Add page for statistics dashboard

This pull request adds a simple placeholder for the Statistics Dashboard along with a button to access it from the map.

This looks fine, but it seems like you included some commits from your last PR.

I merged part of this pull request under the commit ace787c89a4e52322692477eaf3fe22228420f63.

You should create a new branch off of main next time you start working on a PR, rather than creating your branch based off of your most recent PR.


Push.js doesn't work in iOS simulator

I'm developing a Phonegap application. Push.js works (loads other pages into the .content element) in the Android emulator, in Google Chrome web browser but not in the iOS simulator.

    About

Is about.html served up via the filesystem?  Meaning it complied in your phonegap/cordova app?  It could be that url are loaded using the file:// protocol inside compiled apps which isn't supported by push.js currently.
I was able to get it working by applying a modified version of the push.js code from @artemave
Just replace the "// Core PUSH functionality" section of ratchet.js with this version:
https://github.com/artemave/ratchet/commit/5ccfdd765ecd15666b83b0b9abc15e4c120b7713

This would have been very nice to know before I went to cordova-httpd for http protocol so I could make push.js work...


The function MyApp is not defined

Hey everyone as I am polish my skills on UI but when I code it's completely fine even working but in console it's showing a message in file widget_test.dart error message like => The MyApp function is not defined
Thanks in advance 🙂

Steps to Reproduce

Run flutter create bug.
Update the files as follows: ...
...

Expected results:
Actual results:

Logs

Hi @rohan1234,
You might have changed the root method of your app in main.dart which usually is something like:
void main() {
  runApp(MyApp());
}

And the test/widget_test.dart file looks for MyApp() method in its test upon compiling. If you have removed / renamed the MyApp() method in main.dart file and if you are not running any widget tests, you can simply comment out the entire widget_test.dart which should resolve your issue.
Thanks.

@darshankawar @maheshmnj it`s resolved thnx for cooperating


Introducing ABAP Syntax missleading information?

Hello Team,
while going through the learning-journey "learn the basics of abap programming on sap btp" i found some weird information concerning Declaration of Literals:
The documentation differs between Text Literas and String Literals, but the definition seems to be the same:
"Text Literals are character strings in a pair of single quotes ( ‘ ). String literals are of type STRING. They should be used to provide values for string typed data objects."
"String Literals are character strings in a pair of singe quotes ( ‘ ).  String literals are of type STRING. They should be used to provide values for string typed data objects."
i was expection something like:
"Text Literals are character strings in a pair of single quotes ( ‘ ). Text literals are of type TEXT. They should be used to provide values for TEXT typed data objects." - Which as a newbe in ABAP does not make any sense (where is the difference to String?

Support for Learning Journeys can be found here: https://support.learning.sap.com/


NXP MIMXRT595_EVK board no longer boots

A recent update to the repo broke this board, and apps no longer boot correctly.  The commit that caused the regression is e2d3fe9.
To replicate, load the samples/basic/blinky app for the board target mimxrt595_evk//cm33.  The boot banner and other strings do not print, and the LED does not toggle.

Adding these Kconfigs back allows blinky to run properly:
CONFIG_FLEXSPI_CONFIG_BLOCK_OFFSET=0x400
CONFIG_CODE_DATA_RELOCATION=y
CONFIG_CODE_DATA_RELOCATION_SRAM=y


Expose fragments as a property on Info

Feature Request Type

[ ] Core functionality
[x] Alteration (enhancement/optimization) of existing feature(s)
[ ] New behavior

Description
Hi there! :slightly_smiling_face:
We use fragments from the _raw_info attribute on Info in our project, and we thought it would be nice if it could be exposed as a property on Info itself. Similar to how field_nodes & context are exposed as properties:

I'd be happy to contribute a PR for this!

@cpd67 thanks! A PR would be very appreciated 😊

@patrick91 you're welcome! I've just created a PR for this. Let me know if there's anything else I need to do :blush:


Test item doesn't show as busy after setting its busy field

Does this issue occur when all extensions are disabled?: Yes

Version: 1.69.0 (user setup)
Commit: 92d25e35d9bf1a6b16f7d0758f25d48ace11e5b9
Date: 2022-07-07T05:28:36.503Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19043
I've created a simple test extension to reproduce this issue. The code is located here: https://github.com/KaravolisL/simple-test-extension. In particular, see https://github.com/KaravolisL/simple-test-extension/blob/0cb1a52d8f4b0fccc34e9b7a7dc8ed0e6308dd24/src/extension.ts#L45.
Inside of a run profile's run handler, I can call test.busy = true; and the test will show as busy in the user interface. Calling test.busy = false; returns the user interface to its idle state. This is the expected behavior.
The unexpected behavior is when I try to do this in a separate command that gets registered in the package.json under "testing/item/context". The call test.busy = true; doesn't seem to do anything in this case.

I think I found an issue that may be related to this issue. I'm trying to keep additional data associated with every TestItem in a weak map like is suggested here: https://code.visualstudio.com/api/extension-guides/testing. When a test is run, I'm adding to the test item and its value to the weak map. In my separate command that's registered in the package.json, I'm trying to get that associated data using the TestItem parameter, but it's not being found. I updated the repository linked above with console.logs to demonstrate this

I ran the example extension, and when I click the squirrel, the test does not show the busy state. Is that what changed? Can you verify it @KaravolisL?

This bug has been fixed in the latest release of VS Code Insiders!
@KaravolisL, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 2c801254ebf547baaee771b99aa76d202f999622 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!

@connor4312  Can you please provides steps to verify this if we don't hear back from @KaravolisL

@connor4312 This issue is still present in the following version
Version: 1.72.0-insider (user setup)
Commit: 9fb452c4852ef098206ec67a2b236ad5fd0ba828
Date: 2022-10-03T07:34:58.711Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19043
Sandboxed: Yes
Using the example extension linked above, I clicked the squirrel button on the test item and the busy state is still not shown. Additionally, the test item still isn't being retrieved from a WeakMap after it's been added

Ah, I fixed an issue that setting the busy state on any generic test item didn't update in the UI. But it seems, particularly in the followup comment, that you've a different problem in that the test items in actions are different instances.
I'm not sure this is something we'll fix, but I'll reopen for investigation

Tested with:
Version: 1.73.0-insider (user setup)
Commit: fad3a77833b9249158dfd88477114a06435e46a2
Date: 2022-10-07T05:18:17.049Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19043
Sandboxed: Yes
Everything seems to be working now

/verified


Add an executor::Wait trait

This commit adds a new trait, Wait, to serve as the implementation for
functions like Future::wait. The intention for this trait is for executors to
be able to customize the blocking behavior of futures.
Closes #360

As a reference, here is the tokio-core snippet from https://github.com/alexcrichton/futures-rs/pull/436#issuecomment-301673150.
extern crate tokio_core;

fn main() {
    tokio_core::run(|handle| {
        let future = ...;
        let result = future.wait();
        println!("{:?}", result);
    });
}

Ok, I've pushed an updated which I believe addresses comments. I'd like to integrate this into tokio-core first before landing.

I think it would be wise to first agree how tokio-core should use this. I have significant reservations about supporting recursive calls to wait w/ tokio-core as there is no way to guarantee that futures ever complete. This isn't just a hypothetical concern as historically, other "future" platforms built on top of Java's Fork/Join pool did exactly this and my recollection is that it did not end well.
IIRC, this was attempted w/ Akka and other less known libs and has since been removed. Maybe someone who is more familiar w/ these libs could provide further insight.

I believe this this is now a "won't fix" with the direction being taken in #645. Please re-open if I am wrong.


Add collection support to operation

same as #39 but with squashed commits

:kiss:

iahuhulllllll :kissing:


Dynamically handle scrolling

Please describe the feature that you want to propose
I have a canvas which is bound by left and rightside panels where connections flow from one side to another. Try to add in a scroll behavior such that both the panels and canvas can be scrolled together. It would be great if it is possible to control the scrolling of canvas dynamically, i.e. stop or start scrolling canvas in connection with the side panels on either side.

Could you create a codesandbox for this https://new.reactflow.dev ?


feat(ui): Support Argo Events in the UI. Fixes #888

Checklist:

[x] My organization is added to USERS.md.

Fixes #888

TestResourceTemplateStopAndTerminate/ResourceTemplateStop

@jessesuen @sarabala1979 @simster7 I'm pondering what to do with this PR now. It does contain two major items: the Argo Events UI and the GUI workflow editor. However, we now have feedback that a workflow editor is not very useful to users, one person found it confusing.
One option - only have Argo Events :

Remove the workflow editor from this PR and only have the Argo Events code. Maybe be do a later PR for that code.

Pros will reduce complexity and bugs
Con: loses lots of code refactored to use useEffect which is 10x easy to debug.
Thoughts?

@jessesuen @sarabala1979 @simster7 I'm pondering what to do with this PR now. It does contain two major items: the Argo Events UI and the GUI workflow editor. However, we now have feedback that a workflow editor is not very useful to users, one person found it confusing.
One option - only have Argo Events :

Remove the workflow editor from this PR and only have the Argo Events code. Maybe be do a later PR for that code.

Pros will reduce complexity and bugs
Con: loses lots of code refactored to use useEffect which is 10x easy to debug.
Thoughts?

@alexec I am a fan of a lot of the code refactors in this PR, including useEffect. Is it feasible to revert just the Workflow editor and keep the rest in?

@alexec I am a fan of a lot of the code refactors in this PR, including useEffect. Is it feasible to revert just the Workflow editor and keep the rest in?

@simster7 lets discus at stand-up. I think v3.0 is really pack with stuff and we're going to need to really focus and push to get it out in the time frame MK's requested.

@simster7 lets discus at stand-up. I think v3.0 is really pack with stuff and we're going to need to really focus and push to get it out in the time frame MK's requested.


[Feature] Focus frame cast bar - "Show only interruptable spells"

Describe the feature
Focus frames are often used for tracking spells to interrupt. Would be great if there was a way to distinguish in the cast bar of the focus frame which spells can or cannot be interrupted so you don't waste an interrupt for nothing.
In the UI options of the focus frame there could be a dropdownlist with options such as:

Show all casts (by default)
Only show interruptable casts
Highlight interruptable casts (so its easy to distinguish between the ones that can and those that can't be interrupted.

Describe the implementation
Described above everything :)

I like this idea. Will look into this once I get around to doing the already planned Cast Bar optimizations.

Highlight interruptable casts (so its easy to distinguish between the ones that can and those that can't be interrupted.

This part however I'm a bit unsure what you mean, since you can already change the color of the Cast Bar based on if the cast is interruptible or not.

I like this idea. Will look into this once I get around to doing the already planned Cast Bar optimizations.

Highlight interruptable casts (so its easy to distinguish between the ones that can and those that can't be interrupted.

This part however I'm a bit unsure what you mean, since you can already change the color of the Cast Bar based on if the cast is interruptible or not.

You're correct, found out that that part exists already after already posting.


Fix compiler crash in Release mode

fatalError  crash compiler in Release mode (for example with building branch with Carthage)
but preconditionFailure  so let's use it instead ?

turn out I was wrong, compiler is still crashing :-(