releases: api, proxy, istio tags and branches must match

The last api repo tag is 0.3.0
for 0.8.0 and the release-0.8 branch they must exist on all the repo which make the release
(this is probably a dup of an older issue I filled long ago)

@rkpagadala did you have a chance to verify?

https://github.com/istio/proxy/pull/1518#issuecomment-384068481

adding @qiwzhang the proxy and istio repos have different versions of api. istio is leading api. Wayne will move proxy to match the version in istio repo and then move the proxy sha in istio repo. All these changes in release-0.8 branch.

thanks for the investigation, good plan, but both master and the branch, right?

why is this a blocker for release? Is it going to turn of some key istio functionality? or is this just for hygiene ? If latter, its a good to have but not a must. It certainly does not stop anyone from installing or using Istio.

it's basic hygiene / software engineering, and yes to make an LTS that can be patched for bug fixes, it needs to have all the branches in order

why is this a blocker for release?

because we can't make and maintain a release if we don't know what is in it or if what is in it is a mismatch between the components.

Fixed by https://github.com/istio/istio/pull/5314
Both proxy and istio are using API SHA 793db0cb1a2e33012166f1d6ee5918596b8199d4


feat: Add SFN driven rosbag-image-pipeline module

[X] ASL -> CDK Conversion
[X] CDK Synth passing
[X] CDK Deploy passing
[x] Functional Testing
[x] seed-farmer integration testing
[ ] Security & Unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Wondering if we should make this a generic module...keep it in ADDF, but it may be better to make all new modules generic so it can be leveraged in other projects?
Lets debate

Depends how generic you mean..
A good 90% of this code is setting up what was in the DAG. So if you mean bringing your own logic for EMR, batch, sagemaker, yes.
For just SFN usage, doesn't quite make sense.

Line 509 in stack.py...should be ObjectDet, not LaneDet...makes reading SM difficult


Oh joy, I just lost a blog post

Spent sometime writing a blog post, took a long break before completing it... foolishly hit submit and...
...redirect to login. Whoops.
It's no biggy. Here's the information I lost that is needed however:
On Credible Demo and HelvellynJS, create stores:
authentication/tokens
authentication/session
authentication/user

Tokens are distinct enough to justify own store. Actions should belong to object they have the greatest effect on, e.g.

user#signUp > creates a user
user#confirm > sets confirmed_at on user
session#login > creates a session
session#refresh > destroys session and creates new; provides new tokens

Makes sense. Anyway...
I just lost a blog post!
This is fine, this is good. This teaches us something. We need to add...
We need to store entity state (among others), to be restored after login. It would also be useful to say to the user, "Don't worry, you haven't lost your content", and... yeah, present signin in a modal, that way they still see their content in the background.
So we'll do the session tweaks first that are detailed in a codeblock above - will create a separate issue for this. Then:

Add login modal
Do not redirect on session invalidation (show login modal instead)
Do still redirect to login on any attempted navigation ?? Maybe... Actually, I'm thinking persistent modal (blurred background would be dope too), so manual navigation isn't possible for your average user. And a refresh or hard navigation would indeed redirect, because... the session will have been invalidated. This is more of a rescue modal; create your session and restore where you were.

First part now complete.
Likelihood that second part needed at all with use of refresh-token is extremely low - negligible, even, next to zero. For login credentials to be required, the user would need to keep a page open for 14 days without reload or refresh, and then attempt to submit data.
Which is fine but...
If it can be broken, it will be broken. Catching attempted submissions and introducing the modal still makes sense. I'm just in no rush to implement it. This stays open to await being addressed.

Progress to mitigate this issue has now been made across these issues and PRs:
Issues

https://github.com/thombruce/helvellyn.js/issues/7
https://github.com/thombruce/helvellyn.js/issues/9

Pull Requests

https://github.com/thombruce/helvellyn.js/pull/8
https://github.com/thombruce/helvellyn.js/pull/10

Every action is now preceded by a call to refresh if necessary.
A timeout has also been set which runs every two minutes performing the same check.
This issue now barely exists. But it should perhaps be revisited when Credible becomes configurable to allow shorter expirations and non-usage of refresh tokens. In fact...
...
...this issue does still exist if a user does not use refresh tokens. Well worth still looking at in the short term.


[1.11] Crashing with java.lang.NullPointerException: Rendering screen

Similar crash to https://github.com/McJty/RFTools/issues/890 but this time is only with some of special dimlets such Cheater while other dimlet types are fine. Thanks!
Forge <IP_ADDRESS>0
CompatLayer 0.1.0
McJtylib 2.3.0
RFTools 5.70
RFTools Dimensions 4.50
Logs
http://pastebin.com/CLCaP5WK

Fixed next release


Where is the code for the demo?

http://react-dnd.github.io/react-dnd/examples/drag-around/naive

I have found the code, how can I run it.

Clone react-dnd repo then run yarn && yarn start. http://localhost:8000 is the local version of http://react-dnd.github.io/react-dnd.


Release notes configuration is broken

Invalid release notes configuration: The property '#/changelog/exclude/labels' of type null did not match the following type: array

I'm not that optimistic it was going to work anyway.    I wonder whether we wouldn't be better off auto-populating milestones, and we could just assemble from those.

Okay, #5937 generates notes. :tada:  Let's see how it goes.  The real test will be 0.23: it's the subsequent branches that have been full of Type I and Type II errors on other repos.

I should clarify my grumpiness: I think the workflow here is a good start.  I find the underlying GitHub feature has been unreliable.

Yeah, no worries :) I've also been frustrated with the underlying feature's inability to understand pre-releases.


[Bug]: [connectivity_plus][iOS] checkConnectivity returns None when run twice

Platform
Android and IOS
Plugin
connectivity_plus
Version
all version
Flutter SDK
3.7.2
Steps to reproduce
Open onConnectivityChanged.listen at screen A, then remove screen A, navigate to screen B, and run Connectivity().checkConnectivity(), you will see sometime or always it returns none
Code Sample
Screen A:
subscription =
        connectivity.onConnectivityChanged.listen((ConnectivityResult result) {
      setState(() {
_isOffline = result == ConnectivityResult.none;
      });
    });
Screen B:
var connectivityResult = await (Connectivity().checkConnectivity());

Logs
Don't have Logs

Flutter Doctor
[✓] Flutter (Channel stable, 3.7.2, on macOS 13.3.1 22E772610a darwin-arm64, locale en-VN)
    • Flutter version 3.7.2 on channel stable at /Users/macbookm1/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 32fb2f948e (11 months ago), 2023-02-08 07:30:10 -0800
    • Engine revision f40b73f8a4
    • Dart version 2.19.2
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/macbookm1/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.77.3)
    • VS Code at /Users/macbookm1/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.78.0

[✓] Connected device (4 available)
    • Ngurn duj🍓 (mobile)       • 1f7ae3dfd42c61af48b2e836c394e761bff908e5 • ios            • iOS 16.7.2 20H115
    • iPhone 14 Pro Max (mobile) • 403DD1E1-3CD5-4348-88C1-D3187DB93A3D     • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)            • macos                                    • darwin-arm64   • macOS 13.3.1 22E772610a darwin-arm64
    • Chrome (web)               • chrome                                   • web-javascript • Google Chrome 120.0.6099.109

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Checklist before submitting a bug

[X] I searched issues in this repository and couldn't find such bug/problem
[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I'm using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

Same issue here, we do listen to .onConnectivityChanged events on many occasions, and since the migration from connection: 3.0.2 to connection_plus: 5.0.2 iOS app version does briefly report ConnectivityResult.none, to then follow up with actual connection state, e.g. ConnectivityResult.wifi. The incorrect .none report only happens for subsequent stream requests, first one works correctly.
Above issue was observed on iPadOS 15.8.1 and iOS 17.3, Flutter SDK 3.16.7. Issue does not affect Android.

Same issue here. 5.0.2 iOS 17.2

bump

same issue, any known fixes?


Loading not triggered when switching between views

Hi,
Really like your plugin, was very easy to get started. I did notice a little 'feature'.
I have a list of images in a List View. When i click to a Detail View, where additional information is shown about the image and then back to the List View, only the first row of images is loaded. Although 10 more images are already in the Viewport. When i scroll the browser 1px after i got back to the list view, the lazy load is triggered and the images are loaded fine.
Best regards,
Tim

Tim, do you have an online example? For me it is easier to breakpoint it since our own examples work.

Yeah, i can probably setup an online demo tomorrow for you to look at.
I've also noticed it when i was filtering my list (changing which items are shown in ng-repeat)
I'll give you an update tomorrow!
Thanks!
Tim
On Sat, Sep 12, 2015 at 4:11 AM -0700, "SquadraCorse" <notifications<EMAIL_ADDRESS>wrote:
Tim, do you have an online example? For me it is easier to breakpoint it since our own examples work.

Reply to this email directly or view it on GitHubhttps://github.com/afklm/ng-lazy-image/issues/26#issuecomment-139749537.

when running the sample please check c7483811e31f5d45c896c03a024c7fc4c7a151ab overthere i created an repeat sample with filter demo

http://afklm.github.io/ng-lazy-image/sample-repeat.html

Thanks, will have a look at it tomorrow!
On Sat, Sep 12, 2015 at 6:49 AM -0700, "SquadraCorse" <notifications<EMAIL_ADDRESS>wrote:
http://afklm.github.io/ng-lazy-image/sample-repeat.html

Reply to this email directly or view it on GitHubhttps://github.com/afklm/ng-lazy-image/issues/26#issuecomment-139772300.

I'm trying to create a simplified example to check if some other part of my code is causing the problem (which is most likely, as i'm still new to Angular). But i haven't been able to consistently reproduce the problem. Which so far makes me think some of my other code is causing troubles...
I'll report back if can find anything. So far i'm assuming i made a error somewhere else which causes your plugin to not be able to do what is should do.
Thanks for the help so far!

No worries, angular keeps on changing it's core so we all will be new in some regions. Just open a ticket if you are stuck. The directive is depending on two things: scope (so knowing when it will be added) and position calculation. Maybe we have a bug in this calculation but then i need a sample :) Good luck!

Hi,
I've had a little more time to test my problem and have been able to reproduce my problem. I'm using a grid with a toggle checkbox to change the layout of the grid with 1 large image per row or 4 small images per row.
The Lazy Load script calculates the offsets of the elements to see if they are in the viewport and need to be loaded. But even if the Layout is set to 4 small images per row, the calculations appear to be performed on the 1 large image per row layout. The amount of large images in the 1 per row situation determine the amount of small images shown. (if only 2 large images are shown due to screen size restriction, when you toggle to 4 images per row, again only 2 images are loaded)
The calcuations seem to be performed before the styling is applied which changes the grid elements positions.
Simple example with the problem: http://litedesigns.nl/lazy-test/sample-repeat.html
I hope you can shed some light on why calculations are performed on incorrect list layout.
Thanks!
Tim.

Yes you switch by ng-class (more or less how we do stuff with jQuery). So $scope wise nothing changes. Can you try with an ng-include where you include the correct template based on this switch? Maybe i can introduce an event to listen on so yuo are able to trigger it, but in your case the magic happens in the ng-class.

I can give it a try, i'll follow up on this later.
Your code which performs the offset calculations is called each time you toggle the layout though

Stop, i found it :)

\o/

The class '.small-block-grid-4' is being set AFTER the directive already is kicked in. So when setting a breakpoint at 'remaining' inside the directive code I can see that the first li is 100% wide and because of that the further calculations are right because the first image takes the whole screen. So ng-class has a lower priority. You can try by having the class="{{var}}" where var is based on the toggle? Or an ng-include / ui-view which makes two different scopes for both. I will look at priority, maybe you are not the only one switching like this :)

Using class="{{var}}" does not help. Then it depends on the initial block-grid class. If initially the large images are show (1 per row), the problem persists. If initially the small images (4 per row) are shown, the problem is solved. Problem is that i save the layout display setting in localStorage for next time user visits (or refreshes the page), the same layout display is shown (grid or list)
Works: http://litedesigns.nl/lazy-test/block-grid-4/sample-repeat.html
Doesn't work: http://litedesigns.nl/lazy-test/block-grid-1/sample-repeat.html

No, you can use an 'ng-if' even or 'ng-include' or 'ui-view' if you use routes. So first you check which view you want to provide (based on default, sessionstorage, localstorage, Provider whatever). THEN you render the correct view.

please look at ui-router! That is a real view concept (so with states also can be reloaded)

Thanks for all the tips. Have to go now, but i'll do some additional testing later :)
On Sat, Sep 19, 2015 at 3:34 AM -0700, "SquadraCorse" <notifications<EMAIL_ADDRESS>wrote:
please look at ui-router! That is a real view concept (so with states also can be reloaded)

Reply to this email directly or view it on GitHubhttps://github.com/afklm/ng-lazy-image/issues/26#issuecomment-141643704.

The ui-router is looking really interesting. Gonna give that a go! My enitre application IS only filtering, sorting and searching the list of items. Toggling between views to provide users the interface the prefer and clicking to detail views of a single item and back to the filtered list.
I tried ng-include before, but that feels slow (delay is too big between parts being loaded). So splitting up my filters, sorting buttons and different list views in different views is gonna slow down my application noticeably.

OK. Then use the dev version currently in our master. Since others where using transitions and stuff i now check if the item has a width (dirty check for if vissible). See example:
http://afklm.github.io/ng-lazy-image/sample-hide-show.html


ReactiveUI.Events.WinForms missing

Do you want to request a feature or report a bug?
Packaging bug.
What is the current behavior?
The ReactiveUI.Events.WinForms package is not present.
What is the expected behavior?
The package should be present (renamed from reactiveui-events-winforms.
What is the motivation / use case for changing the behavior?
Consistency/availability.
Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and development snapshot
v8

In the Winforms-Events branch the file Events_WinForms.cs is missing.

So it seems like reactiveui-events-winforms was published at some point, perhaps completely independently of the main project (not sure). But because #1352 is not yet merged, there is no ReactiveUI.Events.WinForms package, which reflects the new package naming convention.

This needs to be fixed. Looking for a community member to finish up my work. #1352 is quite old and you may need to start again from develop and harvest the nuggets from that PR.


feat(compiler): find queries accept &str

This should make it a bit easier querying for definitions. Because all find_queries are transparent, and not cacheable, we can use &str instead of String.

Going to close this as we are rewriting the way find_ is going to be working in the new version of apollo-compiler, and this will no longer be relevant.


[ADR] Support for experimental configuration parameters in Istio Custom Resource

Support for experimental configuration parameters in Istio Custom Resource
Status

Status
Date

Accepted
04.04.2024

Context
To support features that are not yet production ready, or might not get promoted to a GA feature, we need to introduce a mechanism that allow users to use those features and provide feedback.
Decision
Support experimental feature configuration in Istio Custom Resource. The features will be exposed under spec.experimental path, to ensure that those are separated from GA features.
A sample configuration would look as follows:
apiVersion: operator.kyma-project.io/v1alpha2
kind: Istio
spec:
  experimental:
    pilot:
      #[...]

The experimental features should be only available to be used with a separately built controller image. Using the experimental features with production image should result in Istio Custom Resource being set to Warning state.
BTP Kyma runtime
In context of BTP Kyma runtime, experimental features should only be available in experimental release channel.
Consequences
We will extend Istio CRD as described in Decision section.  A separate image with {Release-number}-experimental (e.g. 1.0.0-experimental) will be additionally built apart from the standard, production ready image with {Release-number} tag.
The experimental image will be rolled out only in BTP Kyma runtime experimental channel. In fast and regular channels, the production ready image will be rolled out, as before.

closing as accepted and already implemented


[SPARK-12567][SQL] Add aes_{encrypt,decrypt} UDFs

Test build #48484 has started for PR 10527 at commit 9edeba7.

Test build #48484 has finished for PR 10527 at commit 9edeba7.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class AesDecrypt(left: Expression, right: Expression)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48484/
Test FAILed.

Jenkins, retest this please.

Test build #48511 has started for PR 10527 at commit 9edeba7.

Test build #48744 has started for PR 10527 at commit 27693b4.

Test build #48748 has started for PR 10527 at commit 0558bf8.

Test build #48748 has finished for PR 10527 at commit 0558bf8.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class AesEncrypt(left: Expression, right: Expression)
case class AesDecrypt(left: Expression, right: Expression)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48748/
Test PASSed.

Test build #48744 has finished for PR 10527 at commit 27693b4.

This patch fails from timeout after a configured wait of `250m`.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
case class AesDecrypt(left: Expression, right: Expression)

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48744/
Test FAILed.

cc @cloud-fan @marmbrus @davies

Test build #48890 has started for PR 10527 at commit ed38390.

Test build #48890 has finished for PR 10527 at commit ed38390.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48890/
Test PASSed.

Test build #48943 has started for PR 10527 at commit 9476822.

Test build #48943 has finished for PR 10527 at commit 9476822.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48943/
Test PASSed.

retest this please.

Test build #50212 has started for PR 10527 at commit 9476822.

Test build #50212 has finished for PR 10527 at commit 9476822.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50212/
Test FAILed.

Test build #50243 has started for PR 10527 at commit 9476822.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50245/
Test FAILed.

Test build #50243 has finished for PR 10527 at commit 9476822.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50243/
Test PASSed.

@cloud-fan Okay, addressed comments.

Test build #50456 has started for PR 10527 at commit 3a2510b.

Test build #50457 has started for PR 10527 at commit 04a14cf.

Test build #50456 has finished for PR 10527 at commit 3a2510b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50456/
Test PASSed.

Merged build finished. Test PASSed.

Test build #50457 has finished for PR 10527 at commit 04a14cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50457/
Test PASSed.

Merged build finished. Test PASSed.

Test build #50990 has finished for PR 10527 at commit 1de0453.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50990/
Test PASSed.

LGTM except some minor comments, thanks for working on it!

LGTM except some minor comments, thanks for working on it!

@cloud-fan Thanks so much for your code review! There is the update for the doc and error cases review.    :)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51233/
Test FAILed.

Test build #51235 has started for PR 10527 at commit 6bc1b63.

Test build #51235 has finished for PR 10527 at commit 6bc1b63.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51235/
Test PASSed.

Test build #51476 has started for PR 10527 at commit dc76057.

Test build #51476 has finished for PR 10527 at commit dc76057.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51476/
Test FAILed.

Test build #51508 has started for PR 10527 at commit 8e2960c.

Test build #51508 has finished for PR 10527 at commit 8e2960c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51508/
Test PASSed.

LGTM overall

Test build #51549 has started for PR 10527 at commit 60b9da7.

Test build #51551 has started for PR 10527 at commit 0856fb0.

Test build #51549 has finished for PR 10527 at commit 60b9da7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51549/
Test PASSed.

Test build #51551 has finished for PR 10527 at commit 0856fb0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51551/
Test PASSed.

@davies does this implementation even make sense? decrypt always return a string, while encrypt always take in a binary? The two are not symmetric.

Sorry I'm not convinced this is correct (decrypt returning string type), and there are other issues with it. I'm just going to revert the patch, since it is unlikely other things will conflict with this.

@vectorijk I've reverted the patch. Can you reopen the pull request and fix the return types?

Ok, Sure. I will do.

I did not look into this closely, since @cloud-fan already reviewed this many rounds. sorry for the rush.

I would also just remove support for 192/256, so we don't have to explain the JCE stuff.

Sorry missed the symmetry part, but it is symmetric underneath, except AesDecrypt wrap the bytes into a string at last. We should return binary directly, sorry for the rush.

Thanks so much for suggestion! I will open a new PR for update.

@vectorijk Is this PR dead ?


MBL-1326 bonus support input

📲 What
In late pledge flow, allow user to input bonus support amount, not just step increase/decrease
🤔 Why
Match checkout flow.
🛠 How
Ended up choosing BasicTextField over TextField but this came with tradeoffs.
Pros: BasicTextField allowed me to use Modifier.width(IntrinsicSize.Min) to properly wrap-content for width and end-align to row. I was struggling to not have a TextField take up the entire width of row otherwise.
Cons: BasicTextField does not allow a hint, which can make for a poor user experience if you try to delete a "0" amount. e.g. If the initial bonus amount is 0 and I try to delete it to enter amount "2", it enters "20" instead.
👀 See

Light mode
Dark mode

📋 QA
Go through the late pledge flow and input bonus support amount on Confirm Pledge Details screen.
Story 📖
https://kickstarter.atlassian.net/browse/MBL-1378

Codecov Report
Attention: Patch coverage is 0% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 67.15%. Comparing base (7eeb4f9) to head (099939e).

Files
Patch %
Lines

.../compose/projectpage/ConfirmPledgeDetailsScreen.kt
0.00%
70 Missing :warning:

.../viewmodels/projectpage/ConfirmDetailsViewModel.kt
0.00%
6 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2030      +/-   ##
============================================
- Coverage     67.31%   67.15%   -0.16%
+ Complexity     2064     2063       -1
============================================
  Files           353      353
  Lines         21460    21509      +49
  Branches       3025     3034       +9
============================================
- Hits          14445    14444       -1
- Misses         5406     5455      +49
- Partials       1609     1610       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I was doing a bit of testing and it looks like the amount is not being compared correctly to the maximum amount somewhere.

For the above screenshot, it looks like the maximum amount its allowing is 7835 euro, when converting that to USD thats about 8500, so perhaps the currency conversion is not working correctly

https://github.com/kickstarter/android-oss/assets/7563288/b5333047-ee10-44ba-b266-7d66b82fceea
also seeing some unusual behaviour here:

Go to a late pledge and select the no reward option
In the text field move the cursor behind the 1
click zero then backspace repeatedly

I think something similar happens on the current bonus support text box too


⚠ Bofrost.at has degraded performance

In 2df2d5f, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 881 ms

Resolved: Bofrost.at performance has improved in c87b46a.


Welcome page

Description
Update the Welcome Page with a little more detail, and better presentation.
Motivation and context
I wanted to help communicate some of the design intentions behind the application.
How has this been tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Screenshots (if appropriate)
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:
Go over all the following points, and put an x in all the boxes that apply.
Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

[ ] I have read the CONTRIBUTING document.
[ ] My pull request addresses exactly one patch/feature.
[ ] I have created a branch for this patch/feature.
[ ] Each individual commit in the pull request is meaningful.
[ ] If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

:tada: This PR is included in version 3.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Set Dynamic Percent Position Icon in Lovelace Picture Style

**Home Assistant release with the issue: **
0.96.0

Last working Home Assistant release (if known):
Operating environment
Hass.io

Component/platform:
Raspberry Pi 3B

Description of problem:
I am new to Hass. I have two MQTT sensor which send two position strings seperately("90% 20%........“). These two percentages will be used as the Top or Left of the lovelace icon style to create a dynamic position icon on the picture-elements. The grammar check seems OK but the {{ states('sensor.camposleft' )} seems not working(the icon appears at the corner.
Please leave a comment if anyone could give some ideas about this. Thanks!!
Problem-relevant frontend raw config editor(button in the upper right corner of the webpage) entries and (fill out even if it seems unimportant):
          - entity: camera.frontdoor
            icon: 'mdi:cctv'
            style:
              '--iron-icon-fill-color': '#11AB7D'
              '--iron-icon-height': 40px
              '--iron-icon-width': 40px
              left:
                {{states('sensor.camposleft')}}
              top:
                {{states('sensor.campostop')}}
            type: icon

Traceback (if applicable):

Additional information:

Is this still an issue?

@baozinihao321 any updates? :)


Beyond Meteor

This is a place to centralize questions about how we could one day move beyond the Meteor ecosystem.
Package-based Architecture
How does NPM handle package-based architectures? Should we use Lerna.js?
To clarify: in Vulcan's current architecture, 100% of the code is inside separate Meteor packages, there is no "app" code per se. This means the entirety of the codebase can be overridden on a package-by-package basis if a developer needs to do so.
Server/Client Split
In a Meteor package you can do:
  api.mainModule('lib/server/main.js', 'server');
  api.mainModule('lib/client/main.js', 'client');

What would be the NPM equivalent? Can import foo from 'foo' have different values on the client and server like with Meteor?
What about things like
if (Meteor.isServer) {
  //…
}

Fibers
Where do we still rely on Fibers? Could we replace this by async/await code?
What about Meteor.wrapAsync? Meteor.bindEnvironment?
Meteor.startup(...)
What is the equivalent of Meteor.startup() in, say, Next.js?
Accounts
What do we use for Accounts? Auth0? Can we still preserve backwards compatibility with existing Meteor accounts?
Mongo
What do we do about Mongo.Collection? How do we run and connect to Mongo? What do we do about Collection.find()?

Hi, do u hear spectrum. I got a lot ideas from their source code, and made a simple similar next.js app for my previous project.
U may take a look on their github.
Rethinkdb+graphql+backpack+passportjs
U may get some thoughts from their structure

That's a good idea, I'll check out their stack!

For the lazy ones out there: Spectrum.chat stack

It's possible to achieve Meteor-like "isomorphism" by using Webpack as the build tool, thanks to its fine-grained configurability. While "zero config" is great for application developers, configurability is vital for framework developers not wanting to reinvent some wheels, imho :)
E.g. Meteor.isServer and Meteor.isClient can be easily emulated via Webpack's DefinePlugin – I do it in my current project (pretty large codebase) that uses Webpack to bundle Meteor client-side code (with some help from  meteor-client-bundler)
Perhaps the above can also be done using other bundlers like Parcel and Fusebox (if anybody has experience with them, please share), but Webpack is clearly the most popular one today – almost the de-facto build tool for new web apps today.
The whole journey of migration away from Meteor could be a long one, so strategically it might be a good idea to do it gradually and iteratively. The fine-grain control that Webpack allows would come in handy for that.
Perhaps it would be best to start with only the client-side code first, because there's less of Meteor magic there, especially since this project seems to be already using Apollo-client instead of Minimongo etc. That way, you'd also not have to worry about removing Meteor.wrapAsync and Meteor.bindEnvironment initially, as they are thankfully only relevant on the server-side. Similarly, decisions on Meteor.startup and Mongo.Collection on server could be deferred. On client side, I believe Mongo.Collection may not be getting used much, and should anyways be migrated to Apollo-client if there's any stray usage.
During iterative migration, you may need to use both Webpack and Meteor for building and bundling client-side code; achievable with meteor-client-bundler. If it was feasible to build a Webpack loader or plugin for loading Meteor packages, that would have been a better approach – something I have wondered but never had the bandwidth to pursue. Alternatively, meteor-webpack could also be tried out.
I believe Meteor is still quite superior a framework and toolchain for server-side. It would make good architectural sense to have a separate "Backend Server" (Apollo-server on Meteor) that provides Web APIs for different datasources and the "Presentation Server" that provides isomorphic view rendering (via a framework specifically built for that purpose, like Next.js). This may also open up the possibility of the community implementing non-React presentation layers like Nuxt.js and Angular-Universal.
While for the server-side Meteor code, the "modernization" could involve migrating towards async/await and Promise. Wherever it gets tricky to use async keyword for any function declaration (because it would start returning a Promise<Value> instead of the original Value, and hence would affect the entire chain of calls), Promise.await provides a good stopgap (note it's Meteor/Fiber specific). But migrating server-side can be considered less urgent, imo. If you're interested in alternatives to Meteor for the backend too, I'd suggest considering Nest.js – a framework that I'd definitely consider for my next greenfield Node.js project

Wow thanks for the detailed comments! That makes a lot of sense. I hadn't heard about Nest.js, I'll check it out as well.

Here's an unofficial timeline for the next couple months:

August: release OpenCRUD version with new API.
September-November: work on Apollo 2.0 and React Router 4.0 version (work on client side first and optionally add in Meteor SSR support later)
December-January: depending on current state of the Meteor ecosystem, work on Next.js migration.

I'd likely start incremental migration towards Next.js + Meteor for my own app. If I make any significant discoveries, will definitely share them here

What about a fullstack framework based on Reactxp as frontend and Nest.js as backend.Both are made with typescript.

@SachaG before starting the move to Next.js, check out Fusion.js that was open sourced by Uber's web platform team couple of days ago! The more I think about its architecture and features, the more it looks like what I'd imagine Meteor 2.0 to be 🤩
Perhaps ideally Vulcan's features should be reusable npm packages, so that they are as framework-agnostic as possible. And choose one of the frameworks like Next.js and Fusion.js as the showcase implementation. Do you think that's a direction worth considering?
w.r.t. https://github.com/VulcanJS/Vulcan/issues/2017#issuecomment-408011847, I'm now thinking of first evaluating Fusion.js for the presentation layer of my app.

Hello, I recommend to avoid all Microsoft pseudo new technologies like ReactXP, I have been MS "expert" for 15 years with several certifications.
But since about 7 years I have seen many of the "new" MS politics, like with MS SQL Server, Windows Server, etc. going only on the paying model. And none of them are as good as .NET in the beginning or Windows 7, Windows NT, etc. So now we are leaving away from MS and using only true open source alternatives like Debian, Nodejs, Ubuntu and many others.
MS can change all their politics in the future and, like buying Github, can be against their users very easily.
Thanks a lot to all for this excellent framework.

Just to keep everybody up to date, I've now had calls with core members of both the Next and Fusion teams.
I would say both projects look great, and they both have their pros and cons. My very rough impression so far is that migrating to Next might have a little bit more upshot (more mature product, larger community) but migrating to Fusion would potentially be a lot easier due to the fact that it uses a plugin architecture very similar to Vulcan.
So anyway, I'm keeping a close eye on both for now :)

I read your concept and it was interesting. I agree that meteor is currently the easiest backend could be found in the market but should be moving to lighter framework which support graphql. I would like to share my opinion.
Have you considered loopback.io as a backend ? It has user management, authentication, ORM and REST api generation out of the box. With additional package available, I can get graphql online. I am waiting for their 4.x release on early 2019.
This is what I currently have. I integrated react-admin and fix some rest adaptor issues and vola!! admin interface ready. Please find the code here:
https://github.com/meepeek/loopback3-with-admin
My opinion about loopback
PROS

remote datasource is killing feature. You may use another loopback server as a datasource, which makes it easy to split the services but share some data. Modified data will share across the servers automatically.
REST auto generation, with additional module, graphql and graphiql get generated automatically also.
impressive performance. ORM included.

CONS

Roles and ACL implementation are quite complex. Unnecessary complex, IMO.
you may use async/await but it not fully support yet. need bluebird to wrap the framework's methods before it fully support in LB4.
React integration / GraphQL will be officially support in LB4. currently, they were just plugin and workaround
Isomophic feature (loopback on browser) has been beta for so long with no progress. I really wish to use that since it can do remote datasource to the server as well.

Hmm, I don't know if it makes sense to migrate to something like Loopback. I feel like at this point we'd be more or less rewriting the entire framework from scratch. And also I don't think it would help with the main reasons why we'd be migrating in the first place (better bundling/SSR)?

Imo Vulcan should provide components that depends only on apollo. So we can choose whatever ui library and platform we prefer(next, fusion, cra ecc)
And maybe implement 1 of them like bootstrap + next as default

what if we use assembler instead? in the backend? it would be very very fast!

Imo Vulcan should provide components that depends only on apollo. So we can choose whatever ui library and platform we prefer(next, fusion, cra, gatsby ecc)

That's an interesting idea but it would basically be a different project. Also running a bunch of React components on Fusion/Next/Gatsby/etc. is not the issue, the problem would be ensuring your Vulcan components can connect to your GraphQL back-end. Unless we end up in a world where there's a common standard for GraphQL schemas and APIs, you'd basically have to do 90% of what Vulcan does yourself which would defeat the point…

Unless we end up in a world where there's a common standard for GraphQL schemas and APIs, you'd basically have to do 90% of what Vulcan does yourself which would defeat the point…

@SachaG I think the current feature set and usability of Vulcan can be retained, and yet its reach be made broader by expanding on Rockson's suggestion. I had actually suggested something similar in my earlier comment:

Perhaps ideally Vulcan's features should be reusable npm packages, so that they are as framework-agnostic as possible. And choose one of the frameworks like Next.js and Fusion.js as the showcase implementation. Do you think that's a direction worth considering?

To summarize the whole idea properly, Vulcan should probably be broken into separate projects that play well together:

A set of NPM packages that implement "end-to-end GraphQL data layer of various features" i.e server-side and/or client-side modules of those features.

They could be tightly coupled with Apollo, at least to start with, especially on the client-side

Reference UI implementation of these features, using React.

That should hopefully not look much different than today's implementation.
Encourage community to implement them with other view technologies

Reference SSR implementation using a framework like Next.js or Fusion.js.

Encourage community to implement them with other frameworks

Reference GraphQL service implementation.

Can continue to be on Meteor.js, at least initially

Easier said than done. But the changes should mostly be about removing the dependence on (and assumption of) Meteor API and packages, at least for client-side stuff. I think this should be doable one package at a time, hopefully with the community chiming in to accelerate the process.

For the MongoDB dependency, you can take a look at Feathers adapter system. Basically they kept the MongoDB syntax as a common syntax (selectors, filtering) and let people use custom adapters to connect other kind of databases. That's similar to a micro-ORM.

@gaurav- I think those are all great ideas, and if I was starting Vulcan from scratch today I might go that route. But at this point I just think the folks at Prisma or Apollo are closer to building this than I am.
Also given that making Vulcan work on a single stack is already an infinite quantity of work as far as I can tell, making it work on two or three stacks would mean two or three infinities of work. So I'll pass on that thank you very much.

@SachaG my suggestion is to maintain only one stack officially (aka "reference implementation"). But in doing so, I see an opportunity to also allow users to use their own stacks, if they choose to.
The path to that "one stack" (be it Next.js, Fusion.js or something else) could be gradual, like I proposed earlier in some detail: https://github.com/VulcanJS/Vulcan/issues/2017#issuecomment-406778893

A small part that would need a refactor is the newsletter system. It relies on a Meteor package while we should be able to do the same with Node cron (or any other npm package relevant to this) and bindEnvironment. See https://stackoverflow.com/questions/40687237/cron-jobs-in-meteor.

https://medium.com/@karloluis/rng-react-next-js-graphql-can-slay-the-mean-stack-f580ac04b830

RNG (React, Next.js, GraphQL) can slay the MEAN stack

That article is pretty lazy, since it brushes over half of the MEAN stack (Express, Mongo, and arguably Node) and just tells you to use a third-party service as your API server.

December-January: depending on current state of the Meteor ecosystem, work on Next.js migration.

Any updates on this front? It's now March 2019.

@jay-jlm Migrating away from Meteor is not currently on the roadmap. I think it'd just be too much work at this point and would kill any momentum Vulcan currently has. Let's see how far we can go with Meteor for now :)

I see there is a lot of activity in the Next.js version of Vulcan. Has there been a new decision made about whether Vulcan will be migrated away from Meteor?

Hi @ErikDakoda ,
We have indeed started to migrate toward Next, as a replacement to Meteor. Note that we will have to keep Meteor around for a while, we have legacy apps to maintain but even new ones being developed
The server part of Vulcan will be abstracted away as NPM packages. Next week I'll improve the development environment of https://github.com/VulcanJS/vulcan-npm. It will be doable to maintain both Next and Meteor versions with a shared codebase
The process will probably be like this:

Creating a Next Starter with a dev environment as mature as Vulcan's: https://github.com/VulcanJS/vulcan-next-starter (in progress, will be done before july)
Creating packages to help consuming a Vulcan backend from any frontend (so be it Meteor or Next or even other frameworks, eg Gatsby)
=> those first 2 step will allow to consume an existing Vulcan Meteor backend from any JS app, with Next as a first-class citizen
Creating packages to help spawning a Vulcan backend in any Express compatible architecture. When you look at it, at this point, Vulcan is already more an Express framework than a Meteor framework.
Making the Next application "full-stack ready", by adding a way to easily spawn a DB + an apollo sever route
=> this will be the true replacement of Meteor by Next

What triggered this migration is the addition of API routes in Next in v9, which makes it an hybrid framework, supporting both full-stack and pure frontend usage.

Okay, thank you for the update! I agree with the decision to move most of the code to NPM packages. Then the next biggest hurdle to moving away from Meteor will be the Accounts functionality. Very, interesting - I'll be keeping an eye on this.

Regarding accounts we've introduced GraphQL endpoints in the latest release, so in the backend we don't depend on Meteor. We lack the UI at this point though, and support way less features than Meteor does, that's indeed a big subject.


Internal audit of Reserve, Oracles, Exchange

Work in pairs, or divide-and-conquer.
Goal is to produce a brief document we can walk-through as a group that covers the following:

[ ] How does this work?
[ ] What are the dependencies?
[ ] What design docs or specs cover this feature? Any gaps? Is the spec wrong, or the implementation?
[ ] Are there areas missing unit tests?
[ ] What e2e tests cover this? What could be added?
[ ] Are inputs validated?
[ ] Are parameters and constants set sensibly?
[ ] If we discover a serious issue, how many hrs to a full fix inc data recovery?
[ ] What is the path for upgrading or changing this feature (e.g governance, backwards-compatible validator upgrade, hard fork, ..)?  Does this difficulty match the quality and completeness?
[ ] How could this be attacked?
[ ] Are the user docs correct and complete? Links to code?

Share document, then comment on the doc, then let's have the walkthrough meeting before end of Sprint.

First version of report, focused on Reserve.sol, Exchange,sol, SortedOracles and Integration of these modules: https://docs.google.com/document/d/11-hfu7JhJq9xQXFXhBP3Xo37QN5knZoOBB3i7MpQXOY/edit?userstoinvite=a%40celo.org&ts=5e7b8c46&actionButton=1#heading=h.yx6vxgosxfso

Need to double-check if we want to fix High priority items now before mainnet or not. Also confirm if we want to open issues for Medium and Low priority items.


notifications: Handle exception when trying to play audio.

Safari denies user from playing audio without an interactive trigger like a button by default. So, when user received a notification in Zulip via Safari, it triggers an error when trying to play the notification sound.
Our goal for this commit is to simply handle the error.

I posted one comment. We presumably will want to investigate a bit whether there's a way we can better indicate to the user that they haven't granted the Safari permission (or prompt for it when asking for desktop notifications permission), but that can be a follow-up to this exception behavior fix.

I looked into workarounds to the problem and a common solution seems to be to trigger a fake audio play on touchstart or something like that and then use the same element to play the audio we want by changing its src. Should I implement it or does this feel wrong?

Start a thread about that in #frontend (possibly with a WIP PR) -- I think the answer is possibly yes but it needs more eyes on it than just mine.

Merged, thanks @amanagr!


feat(types): add support to generate docs for classes

:tada: This PR is included in version 0.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


MessageType is not updated after a XmlTranslator

Given a micro-pipeline component when a XML translator is added the message type is not updated.
Sample configuration:
public class SendPort : SendPort<NamingConvention>
{
	public SendPort()
	{
		Name = SendPortName.Towards("Party").About("Any").FormattedAs.Xml;
		SendPipeline = new SendPipeline<XmlTransmit>(
			pipeline => {
				pipeline.PreAssembler<MicroPipelineComponent>(
					microComponent => {
						microComponent.Components = new IMicroPipelineComponent[] { 				new XmlTranslator() };
					});
			});
		Transport.Adapter = new FileAdapter.Outbound(adapter => { adapter.DestinationFolder = FOLDER; });
		Transport.RetryPolicy = RetryPolicy.LongRunning;
		Transport.Host = CommonSettings.B2BTransmitHost;
		State = ServiceState.Started;
	}

	public static readonly string FOLDER = Path.Combine(@"C:\Files\Drops\", typeof(SendPort).Name);
}

MessageType is promoted to context when Schema is deployed in BTS, i.e. DocumentSpec is known


ADD: Added descriptive titles for all three buttons

Pull Request Title
Issue #351 : Add Descriptive Titles to Icons solved
Type of PR

[x] Bug fix
[x] Feature enhancement
[x] Documentation update

Description
This pull request aims to enhance the user interface by adding hover effects for three buttons: the Dark Mode toggle, the Chatbox icon, and the Scroll to Top button. The hover effects provide users with visual feedback, improving usability and accessibility.
Screenshots / Videos (if applicable)
Before

The buttons did not provide any feedback on hover, making it unclear to users that they were interactive.

After

The buttons now display hover text, improving user understanding and interaction. The hover text appears above the buttons, clearly indicating their function.

Checklist

[x] I have performed a self-review of my code.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional Context
The hover effects were achieved using CSS pseudo-elements. I faced some challenges with positioning the hover text correctly, but adjustments were made to ensure that it appears neatly above the respective buttons. The implementation was tested in multiple browsers to ensure consistency.
Thank you for reviewing my pull request!

once review
and let me know if any changes there

@Sai-ganesh-0004 The chatbot button styling is changed, it should remain same.

The 'chat with us' should in black type background like other namings you made

The 'chat with us' should in black type background like other namings you made

Actually it is in black because as you directly bought it from the website chatbase i could not actually add descriptive title for as it is not an element in html or css so i installed a photo of the chatbox and when clicked on that it will open the chatbox

@Sai-ganesh-0004 The chatbot button styling is changed, it should remain same.

Actually it is in black because as you directly bought it from the website chatbase i could not actually add descriptive title for as it is not an element in html or css so i installed a photo of the chatbox and when clicked on that it will open the chatbox

@Sai-ganesh-0004 The chatbot button styling is changed, it should remain same.

Actually it is in black because as you directly bought it from the website chatbase i could not actually add descriptive title for as it is not an element in html or css so i installed a photo of the chatbox and when clicked on that it will open the chatbox

If you want i could put the orange chatbox icon instead of black one

any updates


Rethrow thrown errors in checkThrow

When checkThrow is called with a property that fails due to a thrown
Error, instead of throwing a new Error whose message includes the stack
trace (which leads to noisy reporting from test frameworks that print
the message), just update the message on the thrown Error and reuse it.
This way, the outer framework has the choice of including the stack
trace or not, and any additional data attached to the Error aren't lost.

Merged in https://github.com/jsverify/jsverify/commit/b1b5bb11abd154f2019969babec8be621d92988e. Thanks!


switch to use http request instead of using komodo cli

Title: [Persona name] should (not) be able to [overarching action]
Business/User Value: Make source code testable
Acceptance Criteria
GIVEN [necessary context and preconditions for story]
WHEN [action]
THEN [reaction]
DEV NOTES
None
DESIGN Notes
None
---other items that you may add to a story---
NEEDS PM
None
NEEDS DESIGN
None
Related issues
None
/label ~"story"

better to give an option what to use
in certain cases cli might be the only way to execute a command

@pbca26 I want to switch to use HTTP request because I want to make code testable
taken a look at bitcoin core lib (https://github.com/ruimarinho/bitcoin-core) they use HTTP request too (RPC call)
But I noted your feedback!


build(openapi): don't regenerate on same md5sum and delete files

Running the generate script twice on a nix-build was failing because we don't make use of the .git during this build.
Fix this by manually cleaning up files as required. This should not happen anyway as md5sum would have been the same so: Ensure md5sum is correctly calculated

bors merge


deleted the bad marker

The bug is when pins change type from being inside to outside and previos version of the marker doesnt get deleted but rather gets drawn over(saw this when my gps randomly changed location otherwise I wouldnt have noticed). I tried to fix this in the helper method by both setting the changing marker's map to null to remove it off the map and then also I deleted the obj itself (double tap) :gun: :gun:
the other bug was for some UNKNOWN REASON if you make a new drop and then YOU DONT REFRESH the page whenever you go into a drop view and then press the 'x' button it would then redrop that marker onto the map. I had no idea why it was doing this (why wouldnt it drop jake bot again he has the drop animation too) but to deal with this I took out the drop animation completely so that the point just appears so whatever the error was is now hidden (not MVP fix maybe) :sleepy:
edit: another bug...... every 5 seconds when the timer hits and it redraws the menu next to the map it scrolls you back up to the top no matter where you are which is annoying and shitty UX :bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug::bug:
sorry i snuck bugs into master.
love ninja saboteur/team lead -
jake

I liked the animations 😭😢

ಠ_ಠ


Collect metrics and dashboards for node disk I/O

How to categorize this issue?

/area monitoring
/kind enhancement
/priority normal
What would you like to be added:
Configure the Shoots' node_exporter to collect disk I/O metrics (--collector. diskstats), whitelist the metrics in prometheus and build some charts around it in grafana.
Why is this needed:
Having metrics about disk I/O and visualizing them will help operators and endusers identify problems that are caused in limited disk I/O, e.g. if a I/O-heavy application is running into its limits because the underlying PV doesn't provide the required IOPS.

/cc @wyb1 @istvanballok
Would you be able to tackle this one?
Seems like we have recently been bitten by this in some of our Seed clusters. Metrics and dashboards for disk/volume IOPS would support such investigations.

/touch

/reopen
(we haven't added the dashboards yet)

Do you still plan to add the dashboards?


cmd/silence: allow empty tag sets

fixes #1650

@kylebrandt  can you review when you get a chance


Create JSON errors under the Swish domain

Previously we were using the error constructor provided from Result when
converting Decoded, to Result. This resulted in vending NSError
instances with the Result domain. This felt wrong for a number of
reasons.
This change moves the construction of these errors to our internal
function, which means the error is now under our domain.

Fixes #48

ping @thoughtbot/ios

Don't mind me coming in here SUPER late ... :+1:


ignore BOM

I ran into an issue where the tokenizer is choking on files with a BOM. This throws with Error: Unexpected "ï" at position "0" in state START.
I was able to patch tokenizer with a quick and dirty addition of TokenizerStates.BOM. Unfortunately I don't have time to submit a formal PR but wanted to raise the issue for tracking.

json-with-utf-8-bom.json
This is a simple json file with a UTF-8 BOM (initial byte sequence EF BB BF). The BOM displays differently when opened in Sublime Text or Notepad++ and not at all in VS Code, but they all identify this kind of file as "UTF-8 with BOM". I think BOM's are relatively rare for UTF-8 files so this can reasonably be considered an edge case, but my software's old Export feature includes it so I need to accommodate it in the Import.
As an aside, TextDecoder will by default skip over the BOM but gives an option not to. https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder/ignoreBOM
Anyway, as mentioned code changes were made in haste so I'm sure I missed some things but here's a summary of what I added (inspired by TokenizerStates.SEPARATOR code):
added to Tokenizer constructor:
this.bom = [0xef,0xbb,0xbf]
this.bomIndex = 0;

added to Tokenizer write loop START case:
case TokenizerStates.START:
    this.offset += 1;
    if (n === this.bom[0]) {
        // console.log('found BOM')
        this.state = TokenizerStates.BOM;
        continue;
    }

added Tokenizer write loop BOM case:
case TokenizerStates.BOM:
    // console.log('processing BOM')
    this.bomIndex += 1;
    if (n !== this.bom[this.bomIndex]) {
        break;
    }
    if (this.bomIndex === this.bom.length - 1) {
        this.state = TokenizerStates.START;
        this.bomIndex = 0;
    }
    continue;

Excellent library by the way! Thanks for creating it.

Published as part of v0.0.20.
BOM is now supported for Uint8Array, Uint16Array and Uint32Array.

Thanks for the quick fix!
Unfortunately I'm now running into this error using that same sample file I provided:
Error: Unexpected "ï" at position "3" in state START
setting reader up this way:
const parser = new JSONParser({
  stringBufferSize: undefined,
  keepStack: false,
})

const stream = file.stream().pipeThrough(parser)
const reader = stream.getReader()

Any suggestions?

Hi @hansifier,
Sorry, I just reviewed your file and it includes the BOM sequence twice.
I implemented BOM support following the unicode rules.

Q: What should I do with U+FEFF in the middle of a file?
In the absence of a protocol supporting its use as a BOM and when not at the beginning of a text stream, U+FEFF should normally not occur. For backwards compatibility it should be treated as ZERO WIDTH NON-BREAKING SPACE (ZWNBSP), and is then part of the content of the file or string. The use of U+2060 WORD JOINER is strongly preferred over ZWNBSP for expressing word joining semantics since it cannot be confused with a BOM. When designing a markup language or data protocol, the use of U+FEFF can be restricted to that of Byte Order Mark. In that case, any U+FEFF occurring in the middle of a file can be treated as an unsupported character. [AF]

So, I treat the BOM sequence as an unsupported character except for the first sequence at the beginning of the file.
Do you have any idea of why your file might be "wrong"?

Oh wow. You're right. There's an old bug in my code that was manually adding the BOM and so was FileSaver. 🤦♂
Sorry I completely missed that.
Thanks for your quick responses and patience.


Feature request - play nicely with tinloaf/autocomplete-plus-python-jedi

It appears that autocomplete-plus-python-jedi runs jedi-cmd.py at the time a new window is created and it persists (with whatever environment it got at that point) until that window is closed, whereas the virtualenv Atom package allows for later context switching at the window level. This context switch is completely missed by autocomplete-plus-python-jedi.
It would be nice if there was some mechanism by which autocomplete-plus-python-jedi could restart the jedi-cmd.py under the new environment when it detects one. This may require coordination between the two projects. I have filed a sister issue (tinloaf/autocomplete-plus-python-jedi#12) to track this.

Migrated from https://github.com/tinloaf/autocomplete-plus-python-jedi/issues/7#issuecomment-95366119:
--
Also, if the virtualenv Atom package is installed, it seems to be ignored. For example:
% export WORKON_HOME="${HOME}/venvs"
% mkdir -p "${WORKON_HOME}"
% mkvirtualenv testjedi && "${HOME}/venvs/testjedi/bin/pip" install jedi
...
% .../Applications/Atom.app/Contents/Resources/app/atom.sh &

Now select testjedi from the Packages -> Virtualenv submenu. Open a .py file (or create a new one). Start typing. You'll get a similar jedi-not-found error (assuming jedi is not also installed along with the default python installation).
I can file this as a separate issue if desired.

I think getting specific packages to play nicely with each other is the wrong approach.
@jhutchins is doing it right by emitting events. It think it might be very useful if emissions like this one were changed to be like:
@emit('virtualenv:changed', @env, @path)

However I know absolutely nothing about whether those events "bubble up" to be available to other packages. But assuming they are available, then could use something like event-kit or whatever to handle that event AND the args it sends to do the needful wrt virtualenv:
class JediProvider
  # ...
  onVirtualenvChanged: (virtualenvName, virtualenvPath) ->
    @proc.kill()
    delete @proc # dunno if this is necessary
    command = "#{virtualenvPath}/bin/python"
    @proc = spawn(command, [ __dirname + '/jedi-cmd.py', projectPath ])
    # ...whatever other setup for the new process has to happen ...

Ok obviously I am just making things up at this point but hopefully i've made it clear what I'm thinking.

@mattdeboard, thanks for that. :+1: I had not researched this package thoroughly enough to be aware of its existing event emission. :disappointed: It might interest you to know that I was (crudely) converging on something similar to your more-informed suggestion (see this https://github.com/tinloaf/autocomplete-plus-python-jedi/issues/12#issuecomment-95661445).

So... as long as the events do not contain the path / environment, is there any other way for some other package to get a path to the currently activated environment? It would be easy to just reload that every time the 'virtualenv:canged' event is received...


0.0.9a2 - Page not found

Cannot install the latest version 0.0.9a2. Returns with the following error:
ERROR: Could not find a version that satisfies the requirement ovos-config==0.0.9a2 (from versions: 0.0.0, 0.0.1a2, 0.0.1, 0.0.2a1, 0.0.2a2, 0.0.2a3, 0.0.2a4, 0.0.2, 0.0.3a1, 0.0.3, 0.0.4a1, 0.0.4a2, 0.0.4a3, 0.0.4a4, 0.0.4a5, 0.0.4, 0.0.5a1, 0.0.5a2, 0.0.5a3, 0.0.5a4, 0.0.5a5, 0.0.5a6, 0.0.5, 0.0.6a1, 0.0.6a2, 0.0.6, 0.0.7a1, 0.0.7a2, 0.0.7, 0.0.8a1, 0.0.8a2, 0.0.8a3, 0.0.8a4, 0.0.8a5, 0.0.8, 0.0.9a1) ERROR: No matching distribution found for ovos-config==0.0.9a2
0.0.9a1 installs fine

where is this error coming from? what is trying to install 0.0.9a2?

I am trying to install 0.0.9a2 via pip
pip install ovos-config==0.0.9a2

Looks like that failed https://github.com/OpenVoiceOS/ovos-config/actions/runs/4909901019/jobs/8766585019
Working on a fix now


UDP Time Program

Prerequisites

[X] I am a GSSoC-22 Participant
[X] I checked to make sure that this issue has not already been filed

Description
I will show the client-server architecture using the UDP protocol.There will be a server.c and a client.c. The client will then try to bind with the server.The remote server will send the time(as per server) to the client, which the client will then display.
It is an implementation of client-server connection and communication using UDP to show how to retrieve the time of a remote server.
Tech Stack
C

@heet-kumar Kindly assign

@shreya024 go for it . Good Luck 👍

closed with #550


Improve HLS error details

Current Behavior
HLS errors logged by the ReactPlayer are just the string "hlsError"
Expected Behavior
HLS errors logged by the ReactPlayer are more verbose, describing the nature of the error to allow for better troubleshooting
Steps to Reproduce

Implement ReactPlayer component with onError={e => console.log(e)}
Encounter an HLS Error
View log in console as the string "hlsError"

onError gets fired with 4 params when playing HLS files. The second of which is an error data object:
https://github.com/CookPete/react-player/blob/f1ba67a7e534ae9f1e9934469eec7ef334f80791/src/players/FilePlayer.js#L129-L131
More info on the data object here: https://github.com/video-dev/hls.js/blob/master/docs/API.md#fifth-step-error-handling
You also get given the HLS instance and the HLS global, for things like
if (data.details === Hls.ErrorDetails.FRAG_LOAD_ERROR) {
  // ...
}

@CookPete I was using v1.5.0 and catching hlsErrors just fine but then I upgrade to latest (v1.11.0) and I am getting undefined for all 4 params that you mention in your previous post. So onError is just giving me hlsError string as @naheller described.
Is there something extra that should we do to catch these hls errors?


Increase default rocksdb cache size

Current default of 128Mb is too low. It can lead to severe performance degradation when a single rocksdb compressed block does not fit into cache and each DB query has to go through block decompression.
Closes #10653

bot merge


Community Call Comments, Questions, and Feedback (January 18)

This issue is open for the community to submit comments, questions, or feedback from the DSC Resource Kit community call on January 18, 2017 9-9:30 AM.
The agenda for the call is available on GitHub here.

Doh! Sorry I missed this! :cry:

Hi @kwirkykat,
Where can I find the link to the call so join the next on please? :)
Kind Regards,
Raf

I had some family stuff to attend to. Typical. I've had this penciled in my calendar for ages! 😢

@RafDelgadoUK Links for the next community call are now posted here


MNT: Clean up of conf.py and conftest.py

Follow-up of #101
Fix #102

Hmm... Adding TESTED_VERSIONS still shows "Astropy 4.0," not "astrowidgets ..."
@astrofrog , is it possible that TESTED_VERSIONS does not work with tox? It works fine in my other projects that don't use tox.

I also don't understand why this change would cause timeout for:
        - stage: Comprehensive tests
          env: PYTHON_VERSION=3.6 NUMPY_VERSION=1.14

🤷♀

That timeout is strange...tempting to not use conda for this. I'm re-running that test to see what happens.

Still fails, I'm going to try switch to pip install on that job...

Good news: the travis failure isn't related to your changes!
Bad news: I think it is timing out on the solve and have no idea why!
Some attempts at fixing are incoming...

If this latest fix doesn't work I'll open a separate PR to play around on, and either way will clean up the commit history here.

Still failing, so I'm going to open a separate PR to work on that case.

Close/reopen to trigger tests...

codecov seems a little confused, but tests are passing so I'm merging.

Thanks, @mwcraig !


Half-open time interval

Context / purpose
See Issue
Description
implemented a simple way of return lower/upper bounds as i64::MIN and i64::MAX
Checklist

[x] added unit tests

@evanxg852000 Francois gave its LGTM, can you rebase and merge it yourself?


cargo seems to start several build jobs with -j1 (but doesn't?)

Problem
When building cargo itself with cargo build -j1, it looks like it compiles several crates at once sometimes, ignoring my -j1 directive, according to the compile progress output:
 Building [=============================================>         ] 135/160: backtrace-sys(build), libssh2-sys(build), libnghttp2-sys(build), toml

Looking at htop, it does not seem that more than 1 thread is cpu-intensive though.
Steps

cargo build -j1 in the cargo repo

Notes
Output of cargo version:
cargo 1.41.0-nightly (626f0f40e 2019-12-03)
linux  5.3.12-1-MANJARO

This is normal for build scripts that use the cc crate. It is related to the concern I mention in https://github.com/rust-lang/cargo/pull/7344#issuecomment-530184088 where the build script has finished its work, but there is a brief window where it needs to drop and then re-acquire a token.  During this time, the build script will be in memory, but it shouldn't be doing any work (it's just blocking for the token before it exits).
I haven't (yet) been able to reproduce it actually spawning multiple rustc processes or using multiple CPUs.   I can pretty easily reproduce accumulating multiple -sys(build) crates.  @matthiaskrgr if you can maybe provide more details of when you see it using multiple CPUs that might help.  Like, is it multiple rustc processes? Or is it a single rustc using multiple CPUs?  Or is it something else?
One possibility is to alleviate the cc issue is to put a hard cap on the job queue from exceeding the number of jobs (only when Cargo is in control of the job server).  That would prevent it from accumulating multiple foo-sys(build) jobs doing nothing (it's pretty easy to have 3 or 4 of them with -j1).

It turned out that the problem of niceness and -j being ignored while bootstrapping rustc only appears when I use sccache as as rustc_wrapper, hmm.

I agree that part of this is definitely a bug in the cc crate itself, where cc should never drop its own implicit token. I would also agree though that if you're using sccache that can also mess with things because the jobserver file descriptors aren't inherited to the actual rustc instance so if rustc spawns parallel work it won't be rate-limited.

I believe this issue also leads to misleading cargo build --timings output. I've created an issue for cc -- https://github.com/rust-lang/cc-rs/issues/858. I'm unsure if any cargo work is needed on top of that.


[BUG] Query(regex) does not work for date types

Describe the bug
I would like to be able to make some data filter by GET parameter which is date
/api/foo?from_date=2019-01-01
And I want specifically it to be in YYYY-MM-DD format
To Reproduce
Steps to reproduce the behavior:
1.
I made the following parameter with query and regex:
def filter_order(from_date: date = Query(..., regex=r'\d{4}-\d{2}-\d{2}')
Expected behavior
when i query /api/foo?from_date=1 I expect a validation error
instead my date is valid and equal to date(1970, 1, 1)

I think this is an issue with pydantic's parsing of the date type. (The regex only affects documentation.)
Probably worth creating an issue there, or maybe just searching for one (I feel like I've seen this discussed before...).
As a workaround, you could create a custom date type that actually performs the regex check (rather than just documenting it). I believe this is documented in the pydantic docs.

well I checked - for str type regex works as well on server side (not only documentation)
I would work on a patch but cannot figure out where is exactly types are "casted" from request.GET..

It's handled entirely by pydantic -- the annotation is basically converted directly to a pydantic model field annotation.

@vitalik if you use a date or datetime type, then Pydantic uses it to handle data parsing. And anything you pass to Query() is used only for documentation.
If you use str, then the regex in  Query(..., regex="") is used for documentation AND regex.
If you want to have something constrained to some types of dates only, you could declare the parameter as str with the regex. And then if you want to have a date from it, you could put that in a dependency.
E.g.
from datetime import datetime, date

from fastapi import FastAPI, Query, Depends

app = FastAPI()

def strict_date(
    from_date: str = Query(..., regex=r"\d{4}-\d{2}-\d{2}", format="date")
) -> date:
    dt = datetime.strptime(from_date, "%Y-%m-%d")
    return dt.date()

@app.get("/")
def filter_order(from_date: date = Depends(strict_date)):
    return from_date.isoformat()


[chore] remove TODO

It looks like we're now using the browser fetch types instead of the node-fetch types so there's no longer a type checking warning. I'm not exactly sure how install-fetch doesn't run into an issue with the types being different or maybe it does and that's ignored elsewhere, but at least in this portion of the code there no longer seems to be an issue

node-fetch implements the fetch API, so the types match by design (there are some edge cases, e.g. it uses node streams instead of web streams to represent bodies, and Headers has a raw method, but for it's better to use standard types everywhere anyway)


run code不会根据python解释器切换 --> 'Will not switch according to python interpreter'

Issue Type: Bug
The python interpretercode of run code is incompatible with the setting
VS Code version: Code 1.21.1 (79b44aa704ce542d8ca4a3cc44cfca566e7720f1, 2018-03-14T14:46:47.128Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)

Memory (System)
7.89GB (3.09GB free)

Process Argv
G:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

code-runner
for
0.9.2

python
ms-
2018.2.1

Reproduces only with extensions

Please provide us with a reproducible list of steps on how to trigger this bug.


Project addition : Cardiod

Related Issue
Project Cardioid added.
A cardioid (from the Greek καρδία "heart") is a plane curve traced by a point on the perimeter of a circle that is rolling around a fixed circle of the same radius. It can also be defined as an epicycloid having a single cusp. It is also a type of sinusoidal spiral and an inverse curve of the parabola with the focus as the center of inversion. It's also the set of points of reflections of a fixed point on a circle through all tangents to the circle.
This project is an attempt to showcase its visualization.
Source-wikipedia
Closes: #1222
Describe if there is any unusual behavior of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots

@991rajat @urvashi-code1255 Please review the PR and add GSSOC and level tag

Looks Good. Just Fix the image, its png in script.js
And resolve the conflicts

@991rajat done

Done

Resolve the conflict please.

@991rajat please review this PR for merge, I have made all the requested changes.


OCaml 5.3 support

Dream currently doesn't compile with OCaml 5.3 and fails with the following error:
#=== ERROR while compiling dream-httpaf.1.0.0~alpha3 ==========================#
# context     2.2.1 | linux/x86_64 | ocaml-base-compiler.5.3.0~alpha1 | file:///home/opam/opam-repository
# path        ~/.opam/5.3~alpha1/.opam-switch/build/dream-httpaf.1.0.0~alpha3
# command     ~/.opam/5.3~alpha1/bin/dune build -p dream-httpaf -j 255
# exit-code   1
# env-file    ~/.opam/log/dream-httpaf-1-ea8029.env
# output-file ~/.opam/log/dream-httpaf-1-ea8029.out
### output ###
# (cd _build/default && /home/opam/.opam/5.3~alpha1/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I src/vendor/h2/hpack/util/.gen_huffman.eobjs/byte -I /home/opam/.opam/5.3~alpha1/lib/ocaml/compiler-libs -no-alias-deps -open Dune__exe -o src/vendor/h2/hpack/util/.gen_huffman.eobjs/byte/dune__exe__Gen_huffman.cmo -c -impl src/vendor/h2/hpack/util/gen_huffman.ml)
# File "src/vendor/h2/hpack/util/gen_huffman.ml", line 113, characters 28-71:
# 113 |              [ Exp.constant (Pconst_integer (string_of_int code, None))
#                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: This expression should not be a constructor, the expected type is
#        Parsetree.constant

This is a problem in upstream package hpack, which was vendored into Dream until https://github.com/aantron/dream/pull/351, but that PR hasn't been released yet. Does hpack compile with 5.3?

The latest release does yes. (dune build @all has some issues https://github.com/anmonteiro/ocaml-h2/issues/252 but it doesn't matter for vendored libraries)

This should vanish completely with the next releases of hpack and Dream. I'd like to keep it open to make sure I check it. Thank you!

I've tried to install Dream from repo with OCaml 5.3.0~alpha1. It fails on opam pin.
 opam pin add dream --dev-repo
ends with the following error:
[dream.1.0.0~alpha7] synchronised (git+https://github.com/aantron/dream.git)
dream is now pinned to git+https://github.com/aantron/dream.git (version 1.0.0~alpha7)

[ERROR] Package conflict!
  * No agreement on the version of ocaml:
    - (invariant) → ocaml-base-compiler >= 5.3.0~alpha1 → ocaml-compiler >= 5.3.0~alpha1 → ocaml = 5.3.0
    - dream → dream-httpaf >= 1.0.0~alpha3 → ocaml < 5.3
    You can temporarily relax the switch invariant with `--update-invariant'

[NOTE] Pinning command successful, but your installed packages may be out of sync.

@alxtuz The issue is that you're pinning only dream from its remote repository, not the rest of the dream packages. So dream is trying to install dream-httpaf from opam-repository which has been rightfully marked as not compatible with OCaml 5.3. opam install still doesn't work since you've pinned the package.
The correct command is: opam pin add https://github.com/aantron/dream.git. I haven't tried it locally as i don't want to downgrade my installation of h2 but hopefully it should work for you.

Now running opam pin add https://github.com/aantron/dream.git fails on compilation of dream-mirage.dev with the error below:
[ERROR] The compilation of dream-mirage.dev failed at "dune build -p dream-mirage -j 7".

#=== ERROR while compiling dream-mirage.dev ===================================#
# context     2.2.1 | linux/x86_64 | ocaml-base-compiler.5.3.0~alpha1 ocaml-compiler.5.3.0~alpha1 | pinned(git+https://github.com/aantron/dream.git#6c75fb9e2289bb1ac7e6f22f6712bb242e1a2f96)
# path        ~/.opam/dream-5.3.0/.opam-switch/build/dream-mirage.dev
# command     ~/.opam/opam-init/hooks/sandbox.sh build dune build -p dream-mirage -j 7
# exit-code   1
# env-file    ~/.opam/log/dream-mirage-10236-0fb5d7.env
# output-file ~/.opam/log/dream-mirage-10236-0fb5d7.out
### output ###
# File "src/mirage/dune", line 18, characters 2-31:
# 18 |   dream-mirage.dream-paf.mirage
#        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: Library "dream-mirage.dream-paf.mirage" not found.
# -> required by library "dream-mirage" in _build/default/src/mirage
# -> required by _build/default/META.dream-mirage
# -> required by _build/install/default/lib/dream-mirage/META
# -> required by _build/default/dream-mirage.install
# -> required by alias install

Whole output attached
opam_pin_add_dream_output.txt

Perhaps
opam pin add dream-pure --dev-repo
opam pin add dream-httpaf --dev-repo
opam pin add dream --dev-repo

The inverse would be required in this case since they already pinned all the dream packages:
opam pin remove dream-mirage

Thanks!
Both ways worked in my case. To make sure that pinning packages in that specific order is working I created switch again. Finally, it installed Dream with Ocaml 5.3.0~alpha1 without any errors.
Output attached
Dream_support_ocaml-5.3_output.txt

Thank you for checking that @alxtuz and for reporting @kit-ty-kate! I think we can close this issue at this point, because Dream master will continue to compile on 5.3, and if not, then not due to this issue, and any issues with Dream not compiling would likely be upstream.

Would it be possible to have a release so people have a way to install a release of dream on 5.3. The final release is approaching and is currently slotted for mid-december

The release is in https://github.com/ocaml/opam-repository/pull/27005. Thanks for the ping @kit-ty-kate!


Library extensions

The purpose of this PR is to improve the library abstraction with two practical enhancements to minimize redundancy in workload definition files:

Additional Template Types: Alongside the existing task templates, this update will allow the definition of session and phase templates. This facilitates the definition of a session or phase once and reuse it in a workload multiple times.
Tasks Sequences (see #133): This update introduces the concept of tasks sequence. Multiple sequences can be combined within a single session definition. (This also implies that our library has been extended to be able to define task instances in addition to task templates.)

@anjagruenheid , I think I addressed your comments. Could you take another look? Thanks


Add proper basic tests for the cookie and the project

We quickly need unittests to ensure quality since project has largely growed and we don't want to create regression.
The cookie needs tests for itself to ensure generation succeed.
A project needs basic tests, however there is some questions about application tests since we need to be modular, like a CMS test should not be runned if the CMS is not enabled. This is an issue with composer, if we remove the CMS tests from generation, they won't be there anymore if the CMS is enabled further.

It has been started with 0.3.8 pre releases for hook coverage.

It should be enough with 0.3.8 pre 10 with test and other quality stuff. We just need to maintain it for new changes and features.


SOLVED: (Parse + Android) Nothing happens when app is in background...

Hey!
I have an issue with the plugin. When I am in the app, and I send notification with Parse, I receive an alert with the message (this works as intended). However, when app is in the background, nothing displays on the phone. Here is how I use plugin, and how I handle notifications:
var gmcId = "xxxxxxx";
var androidConfig = {
  senderID: gmcId
};

document.addEventListener("deviceready", function(){
  $cordovaPush.register(androidConfig).then(function(result) {
    console.log("result: " + result);
  }, function(err) {
    // Error
  })

  $rootScope.$on('$cordovaPush:notificationReceived', function(event, e) {

    switch( e.event )
    {
      case 'registered':
        if ( e.regid.length > 0 )
        {

          // Your GCM push server needs to know the regID before it can push to this device
          // here is where you might want to send it the regID for later use.
          console.log("regID = " + e.regid);
        }
        break;

      case 'message':
        // if this flag is set, this notification happened while we were in the foreground.
        // you might want to play a sound to get the user's attention, throw up a dialog, etc.
        if ( e.foreground )
        {

          // if the notification contains a soundname, play it.
          navigator.notification.beep(1);
          alert(e.payload.data.alert)
        }
        else
        {  // otherwise we were launched because the user touched a notification in the notification tray.
          if ( e.coldstart )
          {

          }
          else
          {

            navigator.notification.beep(1);
            alert(e.payload.data.alert)
          }
        }

        break;

      case 'error':
        $("#app-status-ul").append('
ERROR -> MSG:' + e.msg + '
');
        break;

      default:
        $("#app-status-ul").append('
EVENT -> Unknown, an event was received and we do not know what it is
');
        break;
    }

  });

}, false);

Thanks!!
Btw, this is the structure of the Parse notification that I receive:
{"collapse_key":"do_not_collapse",
"event":"message",
"foreground":true,
"from":"xxxxxxxxxx",
"payload":{
"data": {"alert":"asdasdas","push_hash":"bff149a0b87f5b0e00d9dd364e9ddaa0"},"push_id":"2iFhVp2R4u","time":"2015-07-21T12:24:09.905Z"}}
Edit:
Here is my AndroidManifest
<?xml version='1.0' encoding='utf-8'?>
<manifest android:hardwareAccelerated="true" android:versionCode="1" android:versionName="0.0.1"     package="com.ionicframework.xxxxxx." xmlns:android="http://schemas.android.com/apk/res/android">
<supports-screens android:anyDensity="true" android:largeScreens="true" android:normalScreens="true" android:resizeable="true" android:smallScreens="true" android:xlargeScreens="true" />
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
<application android:hardwareAccelerated="true" android:icon="@drawable/icon" android:label="@string/app_name" android:supportsRtl="true">
    <activity android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale" android:label="@string/activity_name" android:launchMode="singleTop" android:name="MainActivity" android:theme="@android:style/Theme.Black.NoTitleBar" android:windowSoftInputMode="adjustPan">
        <intent-filter android:label="@string/launcher_name">
            <action android:name="android.intent.action.MAIN" />
            <category android:name="android.intent.category.LAUNCHER" />
        </intent-filter>
    </activity>
    <activity android:exported="true" android:name="com.plugin.gcm.PushHandlerActivity" />
    <receiver android:name="com.plugin.gcm.CordovaGCMBroadcastReceiver" android:permission="com.google.android.c2dm.permission.SEND">
        <intent-filter>
            <action android:name="com.google.android.c2dm.intent.RECEIVE" />
            <action android:name="com.google.android.c2dm.intent.REGISTRATION" />
            <category android:name="com.ionicframework.xxxxxx." />
        </intent-filter>
    </receiver>
    <service android:name="com.plugin.gcm.GCMIntentService" />
    <meta-data android:name="com.google.android.gms.version" android:value="@integer/google_play_services_version" />
</application>
<uses-sdk android:minSdkVersion="10" android:targetSdkVersion="22" />
<uses-permission android:name="android.permission.GET_ACCOUNTS" />
<uses-permission android:name="android.permission.WAKE_LOCK" />
<uses-permission android:name="android.permission.VIBRATE" />
<uses-permission android:name="com.google.android.c2dm.permission.RECEIVE" />
<permission android:name="com.ionicframework.xxxxxx.permission.C2D_MESSAGE" android:protectionLevel="signature" />
<uses-permission android:name="com.ionicframework.xxxxxx.permission.C2D_MESSAGE" />
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />

And this is what I get from debuggin when I send push notification and app is in background:
I/GCM     ( 4177): GCM message com.xxxxxx.xxxxxxxx 0:1437489184268058%b9a1ad81f9fd7ecd
V/GCMBroadcastReceiver(22357): onReceive: com.google.android.c2dm.intent.RECEIVE
V/GCMBroadcastReceiver(22357): GCM IntentService class: com.plugin.gcm.GCMIntentService
V/GCMBaseIntentService(22357): Acquiring wakelock
V/GCMBaseIntentService(22357): Intent service name: GCMIntentService-GCMIntentService-8
D/GCMIntentService(22357): onMessage - context: android.app.Application@2b12b79a
V/GCMBaseIntentService(22357): Releasing wakelock

I have same problem. Nothing happens in background.

This page https://developers.google.com/cloud-messaging/server say about two push-message types: Notifications and Data messages. I start with Notifications and didn't get right result. When i change "notification" to "data" in server-JSON request I get notify in background mode.
But I don't understand diff.
Sorry for my English.

Alright, I think I've moved step forward. Now, when app is in background, I can at least hear the beep form notification. Here is the adb catlog
I/GCM     ( 4170): GCM message com.xxxxxxx.xxxxxx 0:1437503029560661%b9a1ad81f9fd7ecd
V/GCMBroadcastReceiver( 6354): onReceive: com.google.android.c2dm.intent.RECEIVE
V/GCMBroadcastReceiver( 6354): GCM IntentService class: com.plugin.gcm.GCMIntentService
V/GCMBaseIntentService( 6354): Acquiring wakelock
V/GCMBaseIntentService( 6354): Intent service name: GCMIntentService-GCMIntentService-7
D/GCMIntentService( 6354): onMessage - context: android.app.Application@6085382
D/GCMIntentService( 6354): FINDME: log tag to check that code works.
V/PushPlugin( 6354): extrasToJSON:     {"event":"message","from":"763425973806","collapse_key":"do_not_collapse","foreground":true,"payload":{"push_id":"PS64adCUua","data":{"message":"message","push_hash":"d41d8cd98f00b204e9800998ecf8427e","title":"joj"},"time":"2015-07-21T18:23:49.551Z"}}
V/PushPlugin( 6354): sendJavascript: javascript:angular.element(document.querySelector('[ng-   app]')).injector().get('$cordovaPush').onNotification({"event":"message","from":"xxxxxx","collapse  _key":"do_not_collapse","foreground":true,"payload":{"push_id":"PS64adCUua","data":  {"message":"message","push_hash":"d41d8cd98f00b204e9800998ecf8427e","title":"joj"},"time":"2015-07-21T18:23:49.551Z"}})
V/GCMBaseIntentService( 6354): Releasing wakelock

For Android you need to put the PushPlugin.sendExtras(extras); from GCMIntentService.java outside of the foreground loop. This methods calls a javascript function, but by default for some reason they put it only in the foreground loop instead of outside of it. There's been a bunch of topics about this on here.

ANSWER:
So, after two days of pulling my hair, I finally managed to to fix the issue. So, the problem is that it doesn't matter how you specify the JSON in Parse, its always send in the form presented above - meaning that what you specify is always in payload->data->'key':'value'. However, the GCMIntentService seeks for a notification, that has "message" in the first layer of the JSON. Meaning, it has to look like that:
 {"collapse_key":"do_not_collapse",
    "event":"message",
    "foreground":true,
    "from":"xxxxxxxxxx",
    "message":"ssadasdasdsa"
......}

You can see that it is specified in the GCMIntentService.java below lines that start
"protected void onMessage" (I think its line 53).
Anyway, you to fix this, we need to change the handling of a notification, when app is not in foreground. We need to change it to:
	@Override
protected void onMessage(Context context, Intent intent) {
	Log.d(TAG, "onMessage - context: " + context);

	// Extract the payload from the message
	Bundle extras = intent.getExtras();
	if (extras != null)
	{
		// if we are in the foreground, just surface the payload, else post it to the statusbar
        if (PushPlugin.isInForeground()) {
			extras.putBoolean("foreground", true);
            PushPlugin.sendExtras(extras);
		}
		 else {

		 try {
     		   JSONObject object_example = new JSONObject( extras.getString("data"));
     		   Log.i(TAG, "Received JSON >>: " +object_example.toString());
				String message = object_example.getString("alert");
		 		 Log.i(TAG, "Received message >>:  "+ message.toString());
		 		 extras.putString("message", message);
             } catch (JSONException e) {
                 //some exception handler code.
             }

                       //String message = extras.getExtras().getString("alert"); //parse puts the message as an alert if you don't use custom json payload
                       //extras.putString("message", message);
                       createNotification(context, extras);
        }
    }
}

Here, our code will take into consideration that our notification doesnt have 'message' in first layer of JSON - it will seek it at the payload->data->alert (standard form of the notification from PARSE).
I hope that helps, because I've spend waaay to many days trying to figure it out :).

@uksz this really helped me.  Thanks a lot.  So changing code is the only way?
This how I handled it -- just always send PushPlugin.sendExtras(extras).

@bryanmanalo I've tried playing with sendExtras, but it didn't worked for me. In my case, it was an issue with structure of data coming from Prase server, and adjusting the onMessage function.

@uksz rather than changing the issue to SOLVED I would suggest to send a PR because I guess this is a very common issue since lot of people use Parse...

Hereby: https://github.com/phonegap-build/PushPlugin/pull/617

@rubenstolk  thanks!