fix: add non-owning username to space list

Fixes #509

There were the following issues with your Pull Request

Commit: e59f26b95deac21d5f12698c7638ecaeef46ae04
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com


Segmentation fault when using beanstalkd windows version

Hi all,
We have experienced a segmentfault when using beanstalkd windows version. It occured almost on every servers in production even though light load.
Here is more information.

The beanstalkd.exe is compiled by CygWin (GNU bash Version 4.3.42(4)-release (i686-pc-cygwin))

The beanstalk version used: beanstalkd 1.10 --https://github.com/caidongyun/beanstalkd
The command is:  beanstalkd.exe -l <IP_ADDRESS> -p 11300 -z 1048575  -b "bst\binlog" -f 1000

There is a stackdump files generated, the content is:

	Exception: STATUS_ACCESS_VIOLATION at eip=0040A108
	eax=14A57719 ebx=0028CBCC ecx=CA12A808 edx=14A57719 esi=80061A8B edi=0028CB98
	ebp=0028CA38 esp=0028CA00 program=C:\Program Files (x86)\360\skylar6\bst\beanstalkd.exe, pid 11164, thread main
	cs=0023 ds=002B es=002B fs=0053 gs=002B ss=002B
	Stack trace:
	Frame     Function  Args
> 	0028CA38  0040A108 (8006B8A0, 00000000, 00000000, 800630F8)
	0028CAA8  0040ABF9 (0040F120, 00000072, 00000000, 00000001)
	0028CAE8  0040B973 (0040F120, 0028CB10, 0028CB98, 6FB50000)
	0028CBA8  0040D985 (0000000D, 0028CBCC, 800280E8, 61090DD3)
	0028CD28  610084DC (00000000, 0028CD84, 61007520, 00000000)
	End of stack trace

I disassemble the beanstalkd.exe with objdump.exe, here is some content:

	static void
	conn_timeout(Conn *c)
	{
		... ...
	    int r, should_timeout = 0;
	    job j;

	    /* Check if the client was trying to reserve a job. */
	    if (conn_waiting(c) && conndeadlinesoon(c)) should_timeout = 1;
	    ... ...

	    /* Check if any reserved jobs have run out of time. We should do this
	     * whether or not the client is waiting for a new reservation. */
	    while ((j = connsoonestjob(c))) {
	  40a100:	e9 e4 00 00 00       	jmp    40a1e9 <_conn_timeout+0x127>
	        if (j->r.deadline_at >= nanoseconds()) break;
	  40a105:	8b 45 f0             	mov    -0x10(%ebp),%eax
> 	  40a108:	8b 58 30             	mov    0x30(%eax),%ebx
	  40a10b:	8b 70 34             	mov    0x34(%eax),%esi
	  40a10e:	e8 05 19 00 00       	call   40ba18 <_nanoseconds>
	  40a113:	39 d6                	cmp    %edx,%esi
	  40a115:	7c 10                	jl     40a127 <_conn_timeout+0x65>
	  40a117:	39 d6                	cmp    %edx,%esi
	  40a119:	0f 8f e4 00 00 00    	jg     40a203 <_conn_timeout+0x141>
	  40a11f:	39 c3                	cmp    %eax,%ebx
	  40a121:	0f 83 dc 00 00 00    	jae    40a203 <_conn_timeout+0x141>

So, I assume the error is happened at instruction "if (j->r.deadline_at >= nanoseconds()) break;" in function "conn_timeout".

I read the beanstalkd code, but I can't figure out why this happened.
Has anyone else experienced this and/or have a solution to the  problem?
Thanks

I think you posted on a wrong repo. This one is not officially support windows from what I know.

Technically it can be compiled under cygwin, but there is not official support there, so the behaviour might a bit weird there.

Pls post it here https://github.com/caidongyun/beanstalkd-win. Closing this issue


vmware controller: Error message in mail not useful when creating instance with name either too small or too long

[Version]
V16.0 Fix 6
[Date]
2016/06/26
[Test category]
Creative
[Description]
Error message in mail not useful when creating instance with name either too small or too long
[Steps to reproduce]
create vmware instance with target name larger then 63 chars or with 1 char.
[Expected result]
Error message which tells me that the name is too long or too short
[Observed result]
Email with following content:
Dear Ms. Julia,
The subscription 'VMware_Original_With_ALL(4)' for the customer with the ID 'da530744' could not be activated. The service instance could not be provided.
CORBA MARSHAL<PHONE_NUMBER> Maybe; nested exception is:
org.omg.CORBA.MARSHAL: WARNING: IOP00810011: Exception from readValue on ValueHandler in CDRInputStream  vmcid: OMG  minor code: 11 completed: Maybe
With best regards.
This email has been automatically generated. Please do not reply to this email
[Details]
See above;
[Messages and logs]

@StavrevaS
The issue #187 is also concerning error messages in mails. In this context, if you are around there, could you check please if this issue is valid? Thanks.

Fixed with commit.

MIME-Version: 1.0
Message-ID<EMAIL_ADDRESS>Subject: Provisioning process for subscription 'VMware_4_Nics_Preset'
Content-Transfer-Encoding: 7bit
To<EMAIL_ADDRESS>Content-Type: text/plain; charset=UTF-8
Reply-To<EMAIL_ADDRESS>From<EMAIL_ADDRESS>Now I get the following message:
Dear user,
The current operation on subscription 'VMware_4_Nics_Preset' for customer '82c2686e' has been suspended (Instance: '1469177466721').
Reported problem: Invalid instance name a (Pattern: ^[a-zA-Z0-9][a-zA-Z0-9-]{0,61}[a-zA-Z0-9]$).
To continue automatic processing, please click the following URL:http://estgoetz.intern.est.fujitsu.com:8880/oscm-app/notify?sid=1469177466721&cid=ess.vmware&_resume=yes
If the problem cannot be solved and the processing cannot be continued, please terminate the subscription and create a new one.
But this link does not make sense
URL:http://estgoetz.intern.est.fujitsu.com:8880/oscm-app/notify?sid=1469177466721&cid=ess.vmware&_resume=yes

Set severity to minor

If the link does not make sense, it should be quick to fix by removing it.

Preparing mails is a central method which may affect other functionality. Quick fix for 16.1 GA2 is not possible.


ISPN-1752 - Modify readme links of CDI integration

https://issues.jboss.org/browse/ISPN-1752

thanks Kevin, merged it.


Flutter and Symbol/Zebra MC18 Android

Hi!
We are experiencing major problems on the SymbolZebra MC18 in combination with Flutter. We've built apps using DataWedge on MC18 and PS20 devices, but performance on MC18 is terrible, making the device unusable. User presses a button and the app freezes for 2 seconds... We know this is a rather old device with a limited CPU/GPU, but performance is ok, when these lag spikes are gone. We have already filed a issue for it for the Flutter Team (https://github.com/flutter/flutter/issues/71315), but we're wondering...

if other people are experiencing the same issue and maybe have a workaround for it
if Zebra maybe has a fix for this (seems to be GPU related, see ticket above)

We haven't encountered this bug with native Android development or Xamarin development.
Best regards,
Mark

Looking at the issue you filed with the Flutter team, I would not be able to provide any further comment as it looks comprehensive to me and you seem to have isolated the issue to Flutter's handling of the PowerVR SGX540 chip so I will need to defer to any response you get on that thread.
I can confirm that we have not seen this reported elsewhere but that is likely because Flutter is not widely adopted amongst our developer community.
Let's keep this issue open until your flutter ticket gets some resolution.

Re-Vision also created and Support case and we have an Engineering query referring the same within Zebra  under SPR 41631

Understood.  Please note from the readme: "Please be aware that this application / sample is provided as-is for demonstration purposes without any guarantee of support"

Hi @darryncampbell and @xbr786
Just a small report on this issue. We have also reported this issue to Google together with a reproducible test that identified the issue. After a meeting with some Google engineers, sharing tracelogs and sending an MC18 to Google in March/April, Google identified that "during SkCanvas::flush occurred during calls to glTexSubImage2D using the GL_RED texture format". This issue (GPU Driver bug) could be worked around by no longer using the GL_RED texture format on devices with the PowerVR SGX 540 GPU.  At the end of April this fix landed on Flutter's Master channel, later it was merged into the Beta channel and since Flutter 2.5 that was released September 7th, this fix is now also in Flutter's Stable channel. So Flutter apps are now running again fine on MC18s and this issue on the support case SPR 41631 can be closed. Big thanks to Google's Flutter team for pocking this up and fixing this issue.
Best regards,
Mark

Thanks for the update @mark-revision .  I am closing this issue


No test is available in directory

Hi,
I tried to run or debug CalculatorTest from your github repository and I get this error:
[5/22/2018 10:18:46 AM Warning] No test is available in C:\Users\Administrator\Desktop\FlaUI-master\FlaUI-master\src\FlaUI.Core.UnitTests\bin\FlaUI.Core.UnitTests.dll. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.
It concerns every available test. Target framework is set to .NET Framework 4.5. What is the problem?
Thanks in advance!

You probably try to run it with MSTest but the tests are NUnit tests. So either run them withthe NUnit Console runner or with the included cake file or install the [NUnit3 Test Adapter].(https://marketplace.visualstudio.com/items?itemName=NUnitDevelopers.NUnit3TestAdapter)

Yes, it worked! Thanks a lot!


CAMEL-20459: documentation fixes for the EIPs

Signed-off-by: Otavio R. Piske<EMAIL_ADDRESS>

Marking as a draft for now, as I'll merge later. I'm still adding a few changes.


[HOLD for payment 2024-03-14] [$500] Back button in SAML page doesn't work to go back to log in page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Found when validating PR: https://github.com/Expensify/App/pull/35294
Version Number: 1.4.42-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal team
Slack conversation:
Action Performed:

Log in to OD with<EMAIL_ADDRESS>account
Enable SAML required to sign in
Go to ND and enter<EMAIL_ADDRESS>in login field
Press Continue
Confirm you're automatically redirected to your SSO providers login page (with the interstitial page being briefly shown)
Disable SAML toggle in OD
Try to go back to login page in ND

Expected Result:
Back button should work & user able to go back to login screen
Actual Result:
Back button in SAML page doesn't work to go back to log in page. Even killing the app does not work. User has to uninstall & reinstall app to get the login screen
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/39dd7da0-935e-4c51-914f-b81c658e1763

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013f786b4a5d463af8
Upwork Job ID:<PHONE_NUMBER>991674368
Last Price Increase: 2024-02-23
Automatic offers:

ikevin127 | Contributor | 0

I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

I can reproduce this. The back button doesn't work. However, the swiping-back gesture does work for me. The back button should work if it's there though.
https://github.com/Expensify/App/assets/54866469/d6c0eea0-3a02-4e62-b046-8e8e11b50b75

Should be fine to be external! No back end code should need to change for this to be fixed.

Cool cool. TY!

@rayane-djouah Why does navigation home does not work?

Proposal
Please re-state the problem that we are trying to solve in this issue.
Users are unable to navigate back to the login screen from the SAML SSO page. This issue persists even after restarting the app, requiring a complete reinstallation to reset the login state.
What is the root cause of that problem?
Took a lot of setup in order to reproduce the error. Managed to do so on real iPhone XS as well.
The root issue, is caused by the fact that SAML isn't properly configured to work correctly. When a user logs in via SAML, they are taken to the SAMLSignInPage component.
This page is incorrectly receiving props which results in the webview having the incorrect url structure and broken SAML page

The reason you cannot go back to the sign in page and you are stuck even after an app reload, is because no matter what, anytime you come back to the app, it will always be set to this URL:
https://github.com/Expensify/App/blob/b7418b909338d9b5c1583b6a42cc72fe46f0512a/src/pages/signin/SAMLSignInPage/index.native.tsx#L19
Which, I am seeing turn out as https://www.expensify.com/authentication/saml/login?email=undefined&referer=ecash&platform=android
That must mean that credentials is being lost or reset at some point between clicking "Sign In via SAML" and reaching the SAML page. That said, once we are on the SAML page, assuming credentials is now corrupt / not what we are expecting, we can't expect the navigate back to home button to work becuase the Session.clearSignInData is likely not clearing the right data we need to produce any re-render.
<HeaderWithBackButton
      title=""
      onBackButtonPress={() => {
          Session.clearSignInData();
          Navigation.navigate(ROUTES.HOME);
      }}
  />

What changes do you think we should make in order to solve the problem?
Potential Backend Issue
So I think this is both a frontend and backend issue. Seeing as the actual SAML integration is probably handled backend?
Main question on this is, should the backend be returning undefined for the email if it messes up? Why is it returning undefined?
To fix on the frontend:
update handleNavigationStateChange to check for email to be undefined. If so, kick us back to the login page immediately
 const handleNavigationStateChange = useCallback(
        ({url}: WebViewNativeEvent) => {
            // ... other code
            // If the login attempt is unsuccessful OR email from backend is undefined, set the error message for the account and redirect to sign in page
            if (searchParams.has('error') || searchParams.get('email') === 'undefined') {
                Session.clearSignInData();
                Session.setAccountError(searchParams.get('error') ?? 'Domain Not Setup for SAML');
                Navigation.navigate(ROUTES.HOME);
            }
        },
        [credentials?.login, shouldShowNavigation, account?.isLoading],
    );

Original:
https://github.com/Expensify/App/blob/b7418b909338d9b5c1583b6a42cc72fe46f0512a/src/pages/signin/SAMLSignInPage/index.native.tsx#L25

That must mean that credentials is being lost or reset at some point between clicking "Use single sign-on" and reaching the SAML page

Why is it being lost?

assuming credentials is now corrupt / not what we are expecting, we can't expect the navigate back to home button to work becuase the Session.clearSignInData is likely not clearing the right data we need to produce any re-render

@brandonhenry Can you elaborate on this point? How is the corrupt session data linked with the re-render needed for showing the home page?

Proposals still in review

Finally got android and ios builds running locally. Digging deeper here

So found the culprit @allroundexperts - its definitely that we need to do:
Navigation.goBack(ROUTES.SAML_SIGN_IN);

https://github.com/Expensify/App/assets/15656774/167a1003-5cb5-404b-9efe-87fbdacdd985
I did notice that the SAMLSignInPage is still broken though - based on the logs in pic at bottom, here are my findings:
The log indicates that the credentials are being cleared at some point during the SAML sign-in process. Here are a few key points from the log that might help explain why the credentials and login information are being lost:

BeginSignIn API Call: The BeginSignIn API is called with an email, and the request is completed successfully (jsonCode: 200) meaning the initial sign-in process starts correctly.

Navigating to SAML Sign-in: The app navigates to the SAML sign-in route ("/sign-in-with-saml"), which indicates that the SAML sign-in process is being initiated.

Clearing Sign-in Data: The log shows multiple instances of "Clearing sign in data" immediately following the "Handling SAML navigation change" messages. This suggests that some part of the SAML sign-in process or navigation logic is triggering the clearing of sign-in data, including credentials.

Empty Credentials: After the sign-in data is cleared, the log shows "Credentials: - """, indicating that the credentials are indeed empty at this point.

Took a fair amount of digging, but finally figured this one out. We don't need to use .goBack
@allroundexperts
Updated Proposal
Please re-state the problem that we are trying to solve in this issue.
Users are unable to navigate back to the login screen from the SAML SSO page. This issue persists even after restarting the app, requiring a complete reinstallation to reset the login state.
What is the root cause of that problem?
The issue is caused by the Navigation setup of the PublicScreens stack navigator. Specifically, this line
https://github.com/Expensify/App/blob/c425c3412856c07d6126da4147a8af4b49cc8db1/src/libs/Navigation/linkTo.ts#L206
When you press the back button, actionForBottomTabNavigator is calculated and returned as an empty object. This causes the navigation to early return and never actually do anything
What changes do you think we should make in order to solve the problem?
Instead of early returning there, and breaking navigation - we should instead check if the actionForBottomTabNavigator variable is there and send the dispatch and keep running the rest of the code below
if (actionForBottomTabNavigator) root.dispatch(actionForBottomTabNavigator);

This fixes navigation. The main reason I think navigation is setup like this is because it needs to work the same for PublicScreens and AuthScreens so the navigate function works the same for both. However, I don't think we have any actionForBottomTabNavigator to calculate when not signed in (going from SAML back to the homepage). This was causing some properties to not be available in the navigation route, thus resulting in actionForBottomTabNavigator being null

Proposals still in review

Thanks for the updated proposal @brandonhenry. I still don't understand why the action has a payload of NAVIGATORS.BOTTOM_TAB_NAVIGATOR in the first place? Shouldn't we just have an action of type CONST.NAVIGATION.ACTION_TYPE.NAVIGATE?

@joekaufmanexpensify I think it would be good if we can maybe raise the bounty to get more proposals.

Not overdue

Floated it in Slack here.  Let's see if that generates more interest before doing anything else.

@allroundexperts is there not a path where you could see us using one of the two existing proposals on the issue?

Hm... the RCA isn't fully clear to me here so not sure if we can go along with any of these proposals. @brandonhenry Did you manage to find an answer for my above question?

Someone flagged that this may actually be a dupe of this one. Thoughts?

@joekaufmanexpensify The issue you linked is specifically for Desktop only. The accepted proposal there manipulates the window object which won't work on native applications.

@alitoshmatov can confirm if the solution is supposed to fix this as well

@joekaufmanexpensify I saw the accepted proposal actually. In it, its proposed to use the window object. This object does not exist on native platforms but we can hold this one on #29825 as I might be wrong.

This issue does look similar to https://github.com/Expensify/App/issues/29825 since both working with the SAML flow. But I think this issue is addressing different bug. I would suggesting holding this one

No https://github.com/Expensify/App/issues/29825 won't fix this issue, but I thought this two might effect each other's progress since they both addressing the same functionality.

Proposal
Please re-state the problem that we are trying to solve in this issue
Back button in SAML page doesn't work to go back to log in page, esentially locking the user on the SAML page.
Even killing the app does not work, the user has to uninstall & reinstall app to get to the login screen.
What is the root cause of that problem?

[!NOTE]
Navigation.navigate() === Navigation.navigate(ROUTES.HOME) since if no route is passed, navigate's default is HOME -> see code here.

The reason why calling navigate to home doesn't reset the navigation anymore while unauthenticated (public screens) which broke the SAML page onBackButtonPress functionality comes from the recent navigation refactoring.
More context can be found on this issue, where I detailed the root cause:

Since the new navigation was implemented (bottom tab navigator), Navigation.navigate() does not work anymore in calling navigate to the home route like it did before and I suspect this has to do with the new navigation logic -> which I cannot fully understand the inner workings of.

Here is the involved code (before / after)

Before
After

https://github.com/Expensify/App/blob/76e5b1cbd80e7dc55c52f47c5572b2984a7f7ed6/src/libs/Navigation/linkingConfig.ts#L33-L36
https://github.com/Expensify/App/blob/9bfe961622d03de5ac8e18652bbb56dda5ed9f60/src/libs/Navigation/linkingConfig/config.ts#L26-L38

Before
After

https://github.com/Expensify/App/blob/76e5b1cbd80e7dc55c52f47c5572b2984a7f7ed6/src/libs/Navigation/AppNavigator/PublicScreens.tsx#L19-L23
https://github.com/Expensify/App/blob/9bfe961622d03de5ac8e18652bbb56dda5ed9f60/src/libs/Navigation/AppNavigator/PublicScreens.tsx#L20-L25

Besides these important changes in routing structure, we also had some important changes to the linkTo function which actually calls navigate when Navigation.navigate() is called.

What changes do you think we should make in order to solve the problem?
We should replace Navigation.navigate() with Navigation.goBack() just like other PR's did (https://github.com/Expensify/App/pull/35850) in order to fix similar issues after the new navigation logic was implemented.
Simply replace this line:
https://github.com/Expensify/App/blob/807ce54e7b045f4e19c0a5b2876f401d23869d8f/src/pages/signin/SAMLSignInPage/index.native.tsx#L61
with:
Navigation.isNavigationReady().then(() => {
    Navigation.goBack();
});

and we're good to go!

@ikevin127's proposal looks good to me. It has a clear RCA and proposes a simple fix.
🎀 👀 🎀 C+ reviewed

PR will be ready in 2-3 hours!

PR https://github.com/Expensify/App/pull/37618 ready for review!

@allroundexperts can you complete BZ so we can prep to issue payment?

Bumped in slack

Reviewer checklist

https://github.com/Expensify/App/pull/33280
The above PR changed the structure of navigation stacks which caused this. There isn't any single line I was able to point to.
N/A
Regression test would be useful here. The test steps given in the OP should be clear enough.

@joekaufmanexpensify 👋 Any blockers from completing the payment here ?

Nope. I will complete it today.

Checklist is complete. All set to issue payment. We need to pay:

@ikevin127 $500 for PR via upwork.
@allroundexperts $500 for C+ review via NewDot.

@ikevin127 $500 sent and contract ended!

@allroundexperts could you please request $500 via NewDot and confirm here once complete?

All done. Feel free to close!

TY!

$500 approved for @allroundexperts based on summary.


subDirectory for Files object

Pull Request Description
What issue does this change request address?
Closes  #277
What are the significant changes in functionality due to this change request?
Adding the functionality for locating Files in a path relative to the workingDir.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?

Addressed Dan's comments

Job Code Coverage on 7ba4301 wanted to post the following:
View the site here

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True. Open Issue
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync. N/A
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added? N/A


Support StatsPerform Tracking data

Description
There is no implementation for loading StatsPerform tracking data. To allow Kloppy to load this data, there should be added an extra deserializer for StatsPerform.
Proposal

Create serializers/tracking/statsperform.py : that handles the loading of StatsPerform tracking data with input files being: metadata.xml, players.csv & tracking.txt
Add test_statsperform.py
Add StatsPerform coordinate system to common.py  (x: 0,100 & y: 0,100)

Hi Milan. I like the idea of adding a deserializer for Stats Perform!

I believe that Stats Perform are currently using slightly different setups in different leagues. Do I understand correctly that your proposal refers to SportVU 2.0? If so, I would be in favor of being more explicit about it.
I am a bit confused regarding the three required input files. Based on the pull request, the metadata.xml file appears to contain the MA25 feed from the Stats Perform API, whereas the players.csv and tracking.txt files appear to be in the Stats format. Is there a chance that we could rely entirely on responses from the Stats Perform API? For example, take the metadata from the MA1 feed and the tracking data from the MA25 feed?

Hi Milan @MKlaasman and Jan @JanVanHaaren ,
I have already implemented both tracking and event data serializer for StatsPerform for a project of mine. But it has some minor bugs right now I need to fix. If it fits you, I can share it with you after fixing the bugs. It can take about 2 days.

@denizcanoruc Requirements here are that it fits in the Kloppy structure.
If you think it can be beneficial for the implementation, you can always reach-out to me via LinkedIn or Twitter.

While reviewing pull request #191, I was wondering the following: What would be the best way to deal with data providers that provide their data in multiple formats? For example, the Stats Perform API supports both XML and JSON, but the current implementation of the deserializer only supports XML. Should we make this more explicit by, for example, including XML in the name of the deserializer class? Any thoughts, @koenvo?

Be explicit
Being explicit and have 'xml' or something in the class name (and corresponding function in kloppy/<vendor>.py) makes sense. People will often know in what format they have the files. And especially when kloppy is used within a bigger python program, the program should know the format upfront.
or Auto-detect
In the future it might be nice to auto detect the format of the files and determine how to deserialize it.
or Split deserialize and parse
Currently we call it deserializers but they also do the parsing. We could split it.
Is the data exactly the same but only in a different format? In that case we could - also in the future - make a split between reading/deserialize the files into a dict and parsing into kloppy objects. Like this:

Yes, the data is exacty the same but the delivery format is different.
I would be in favor of separating the deserialization and parsing functionality in the future. Besides simplifying the deserializers, this separation would also be helpful for users who would want to store the raw data in an alternative way. They would only need to implement a custom deserializer and could re-use the parser.
I also think that both the second and the third option could be implemented. We could still have a single entry point for a data provider and then automatically detect the appropriate deserializer from the data.

Issue addressed by pull request https://github.com/PySport/kloppy/pull/191.


Style Parsing

This feature implements style parsing for vector layers. This is achieved by combining ol-mapbox-style as a parser for mapbox styles, while keeping the simpler layer and source definition that is already implemented in the project.
The basic idea is that the properties of our custom layer-JSON-format can, additionally to the id and the source of the layer, also hold a style object, which should be a simple mapbox style object. All layers from that object should reference the same source. This mabox style will not override the source, if no source is defined, a dummy source will be added, since it is needed to create a valid mapbox style object.
This solution is meant to style vector data (Vector or VectorTile sources). Style expressions can be used to implement more complex and dynamic styles, like referencing object properties of features for dynamic styling or filtering.

Thank you @RobertOrthofer, a quick test didn't work on my end, with the console error Uncaught (in promise) Error: Can only apply to VectorLayer or VectorTileLayer (at apply.js:238:13). Other than that I will have a more in-depth look this afternoon.

Originally i was thinking about using the "style"-property as both, accepting either mapbox styles but also the flat styles, or maybe even the simple style notation of ol%3B-,const%20styles%20%3D%20%7B,%27,-fill%2Dcolor%27%3A%20%27yellow). This would also prevent users from defining both, which might lead to unwanted results.
Differentiating between the style notations should be trivial, as the "version" property is mandatory for mapbox styles, but not allowed in ol-styles.

Originally i was thinking about using the "style"-property as both, accepting either mapbox styles but also the flat styles. This would also prevent users from defining both, which might lead to unwanted results.
Differentiating between the style notations should be trivial, as the "version" property is mandatory for mapbox styles, but not allowed in ol-styles.

Right, but in the current test the style is set as a property, not as a style - there is a difference between those two things:
console.log(layer.getStyle()) // gets the layer style
console.log(layer.get("style")) // gets a custom "style" property

So in the current state, the user could both apply a style and a style property. What we could do is to check a bit sooner (during the layer generation), if the style includes e.g. a "version", then don't apply it as a style but apply it with mapbox-styles at a later stage.
I think part of the confusion comes from the different ways of defining properties. It is totally fine to add custom proeprties directly to the layer, but there are special properties that are used otherwise (such as style):
const layer = new VectorLayer({
  source: source,
  style: styles,
  id: "foo", // custom property
  title: "bar" // custom property
});
console.log(layer.get("id"); // returns "foo"
console.log(layer.get("title"); // returns "bar"
console.log(layer.get("style"); // returns undefined
console.log(layer.getStyle()); // returns layer style

versus
const layer = new VectorLayer({
  source: source,
  style: styles,
  properties: {
    id: "foo", // custom property
    title: "bar", // custom property
    style: "baz" // custom property
  }
});
console.log(layer.get("id"); // returns "foo"
console.log(layer.get("title"); // returns "bar"
console.log(layer.get("style"); // returns "baz"
console.log(layer.getStyle()); // returns layer style

:+1: from my side to have both defined as style property in the JSON structure (nor properties.style), but then the order of doing tings needs to change a bit :blush:

Ah, now i understand. Yes, that would be best, i will update the code.

Thank you for the updates, works well with Vector layers but I am struggling to make it work with VectorTile layers - trying to find out what the issue could be.

To sum it up: The issue was the missing flag updateSource: false and a missing source-layer-prop in the mapbox style. Also there might have been a mismatch between ol and ol-mapbox-style, on my side also problems with the npm-cache.
The map-Element as well as the Tests have now been updated.


Unit tests

service/ folder need unit-tests, currently only for local-service implementation.

cc: @Onurhan1337

Resolved by: #59


Task are not taken into account for the validate button

Hi Michel,
I followed you tutorial and I have integrated one task into the cspace structure, but the task doesn't appear into the chapter grading structure.
PLease see there is 0 assignements into studio.
https://imt.algorea.org/contents/5807-5802-745723603112028441-943610494122964335/
https://studio.edx.org/container/block-v1:Dartmouth_IMTx+DART.IMT.C.01+1T2020+type@vertical+block@e9317cf792024f9cbd2d3854d73a2335

But there is one task integrated which is this one https://imt.algorea.org/contents/5807-5802-745723603112028441-943610494122964335-1925718034702675433-548574824319546249-1620370338258757999/
Thanks for your help.
Best,

Hi,
The chapter validation system was made considering only "leaf chapters" would be integrated as much, which is to say directly the chapters containing the tasks, and not a chapter containing chapters containing chapters etc. ...
For instance, using the URL https://imt.algorea.org/contents/5807-5801-745723603112028441-943610494122964335-1925718034702675433-548574824319546249/ works, because it's a "leaf chapter", but the one you had used, https://imt.algorea.org/contents/5807-5801-745723603112028441-943610494122964335/, doesn't work, because it only contains chapters.
The change to be able to integrate any chapter, not only "leaf" ones, is easy to make ; please tell me if you want me to change the behavior.

Hi Michel,
Thanks for your quick answer. The faculty members would like to have one button for one MOOC. So it would be great to have all chapters integrated into the grade policy.
All the best,
Ella

Hello, it has been changed to be able to accomodate integrating any chapter, and displaying the results of the whole subtree of that chapter.


Features lc 190 lc 235

replaced by:
https://github.com/Civil-Service-Human-Resources/lpg-services/pull/610
https://github.com/Civil-Service-Human-Resources/lpg-services/pull/611
https://github.com/Civil-Service-Human-Resources/lpg-services/pull/612
https://github.com/Civil-Service-Human-Resources/lpg-services/pull/613


Installation fails (on Ubuntu 22) when using isntruction (via curl): curl: (23) Failure writing output to destination

I have a new ubuntu 22 computer, and try to install Julia via:
$ curl -fsSL https://install.julialang.org | sh

info: downloading installer
curl: (23) Failure writing output to destination
juliaup: command failed: downloader https://julialang-s3.julialang.org/juliaup/bin/juliainstaller-1.14.5-x86_64-unknown-linux-musl /tmp/tmp.reaO5Z3yWc/juliainstaller x86_64-unknown-linux-musl

(output included)
Not sure how to proceed from here. The computer is new, and there is not previous Julai installations on it. I have sudo permissions. Here is some info:
 lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 22.04.4 LTS
Release:	22.04
Codename:	jammy

I have tried restarting the computer, but the result is the same.

This was solved using a workaround as described here: https://discourse.julialang.org/t/installation-fails-on-ubuntu-22-when-using-instruction-via-curl-curl-23-failure-writing-output-to-destination/110977/10


Fix issue where, __iterator() returns the same reference

$Subject

Codecov Report

Merging #20451 into release-stage will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-stage   #20451   +/-   ##
==============================================
  Coverage          15.21%   15.21%
==============================================
  Files                 50       50
  Lines               1341     1341
  Branches             208      208
==============================================
  Hits                 204      204
  Misses              1121     1121
  Partials              16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d9c1c8...1f6b864. Read the comment docs.


volume access mode

Add support for volume access mode
Also add rudimentary volume processing to simulate hosts/containers

Failure is test_global_service_update_label and seems to be unrelated.


unable to install anything above 2.0.0 on CENTOS 5.11 x86_64 standard

I just finished setting up rbenv on a centos server. Everything worked perfectly well. Then I tried installing ruby 2.3.0 and it failed.
Basically I worked back to see what would build and I was able to install:

1.9.3-p551
2.0.0-p648

for anything above it just exits with:
Installing ruby-2.1.0...

BUILD FAILED (CentOS release 5.11 (Final) using ruby-build 20160228-3-g37b3ded)

Inspect or clean up the working tree at ~/tmp/ruby-build.20160306143018.4483

If I try
# cat ~/tmp/ruby-build.20160306143018.4483
cat: /home/valuebal/tmp/ruby-build.20160306143018.4483: No such file or directory

So I tried to install with -v option, I can't really quite spot the issue in the last lines:
make[2]: Nothing to be done for `install-data-am'.
make[2]: Leaving directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6/src'
make[1]: Leaving directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6/src'
Making install in .
make[1]: Entering directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6'
make[2]: Entering directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6'
make[2]: Nothing to be done for `install-exec-am'.
test -z "/home/valuebal/.rbenv/versions/2.1.0/lib/pkgconfig" || /bin/mkdir -p "/home/valuebal/.rbenv/versions/2.1.0/lib/pkgconfig"
 /usr/bin/install -c -m 644 yaml-0.1.pc '/home/valuebal/.rbenv/versions/2.1.0/lib/pkgconfig'
make[2]: Leaving directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6'
make[1]: Leaving directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6'
Making install in tests
make[1]: Entering directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6/tests'
make[2]: Entering directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6/tests'
make[2]: Nothing to be done for `install-exec-am'.
make[2]: Nothing to be done for `install-data-am'.
make[2]: Leaving directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6/tests'
make[1]: Leaving directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6/tests'
Making install in win32
make[1]: Entering directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6/win32'
make[2]: Entering directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6/win32'
make[2]: Nothing to be done for `install-exec-am'.
make[2]: Nothing to be done for `install-data-am'.
make[2]: Leaving directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6/win32'
make[1]: Leaving directory `/home/valuebal/~/tmp/ruby-build.20160306143018.4483/yaml-0.1.6/win32'
~/~/tmp/ruby-build.20160306143018.4483 ~
~
~/~/tmp/ruby-build.20160306143018.4483 ~
Installing ruby-2.1.0...

BUILD FAILED (CentOS release 5.11 (Final) using ruby-build 20160228-3-g37b3ded)

Inspect or clean up the working tree at ~/tmp/ruby-build.20160306143018.4483

I made sure I had the recommended build tools installed:
yum install -y gcc bzip2 openssl-devel libyaml-devel libffi-devel readline-devel zlib-devel gdbm-devel ncurses-devel
I checked the wiki and searched the issues but really couldn't identify anything.
Any suggestion on how to further debug this?
Thank you very much!

Found the error!!
# rbenv install 2.3.0 -v
Downloading ruby-2.3.0.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.3/ruby-2.3.0.tar.bz2
~/~/tmp/ruby-build.20160306145452.12998 ~
Installing ruby-2.3.0...
~/~/tmp/ruby-build.20160306145452.12998/ruby-2.3.0 ~/~/tmp/ruby-build.20160306145452.12998 ~
checking for ruby... /home/valuebal/.rbenv/shims/ruby

BUILD FAILED (CentOS release 5.11 (Final) using ruby-build 20160228-3-g37b3ded)

Inspect or clean up the working tree at ~/tmp/ruby-build.20160306145452.12998

I noticed the ~/~/tmp directory prefix. that was strange. It turns out in .bash_profile I had set:
export TMPDIR="~/tmp"
Changing to:
export TMPDIR="$HOME/tmp"
Solved the issue!!!


Can't checkout accessory

Context
I'm trying to checkout accessories to a user and getting an error.
set-snipeitaccessoryowner -id <accessory id> -assigned_to <user id>
Your Environment

SnipitPS Module version used: 1.10.227
Operating System and PowerShell version: Windows 11, PS 5.1
Snipe It version: v7.0.13 build 15514

Expected Behavior
Check the asset out to the user specified.
Current Behavior
The error below:
> set-snipeitaccessoryowner -id 1 -assigned_to 1
Invoke-SnipeitMethod :
assigned_user                                                                                assigned_asset                                                                                assigned_location
-------------                                                                                --------------                                                                                -----------------
{The assigned user field is required when none of assigned asset / assigned location are present.} {The assigned asset field is required when none of assigned user / assigned location are present.} {The assigned location field is req...
At C:\Program Files\WindowsPowerShell\Modules\SnipeitPS\1.10.227\Public\Set-SnipeitAccessoryOwner.ps1:69 char:27
+                 $result = Invoke-SnipeitMethod @Parameters
+                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Invoke-SnipeitMethod

-verbose messages:
VERBOSE: Performing the operation "Set-SnipeitAccessoryOwner" on target "ShouldProcess?".
VERBOSE: [Invoke-SnipeitMethod] Invoking method POST to URI
VERBOSE: POST with -1-byte payload
VERBOSE: received -1-byte response of content type application/json
VERBOSE: [Invoke-SnipeitMethod] Status code:
VERBOSE: @{status=error; messages=; payload=}
VERBOSE: [Invoke-SnipeitMethod] An error response was received ... resolving
Invoke-SnipeitMethod :
assigned_user                                                                                assigned_asset                                                                                assigned_location
-------------                                                                                --------------                                                                                -----------------
{The assigned user field is required when none of assigned asset / assigned location are present.} {The assigned asset field is required when none of assigned user / assigned location are present.} {The assigned location field is req...
At C:\Program Files\WindowsPowerShell\Modules\SnipeitPS\1.10.227\Public\Set-SnipeitAccessoryOwner.ps1:69 char:27
+                 $result = Invoke-SnipeitMethod @Parameters
+                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Invoke-SnipeitMethod

VERBOSE: [Invoke-SnipeitMethod] Function ended


Invalid CIDR address when creating Docker network using CNM plugin

What happened:
When I execute the command to create the docker network, I got an exception regarding a wrong CIDR address
What you expected to happen:
The docker network with azure-vnet driver is successfully created
Orchestrator and Version (e.g. Kubernetes, Docker):
Server: Docker Desktop 4.26.1 (131620)
Engine:
Version:          24.0.7
API version:      1.43 (minimum version 1.24)
Go version:       go1.20.10
Git commit:       311b9ff
Built:            Thu Oct 26 09:07:37 2023
OS/Arch:          windows/amd64
Experimental:     false
Operating System (Linux/Windows):
An Azure VM with Microsoft Windows 11 Pro as OS
Kernel:: 10.0.22621.2506 (WinBuild.160101.0800)
More details:
In order to spawn a docker container in an Azure VNet, I'm using the Azure Vnet CNM plugin.
I'm installing the v1.5.15 version (azure-vnet-cnm-windows-amd64-v1.5.15.zip downloaded from the release page).
I've also created an Azure Virtual Machine in an Azure VNet.
In that machine I've then installed Docker and downloaded the cnm plugin artifact.
I execute the .exe to start the plugin.
In another console application with administrative rights, I submit the command to create a docker network:
docker network create --driver=azure-vnet --ipam-driver=azure-vnet --subnet=<IP_ADDRESS>/24 azurevnet
But the creation fails because of this exception:
Error response from daemon: invalid CIDR address:
Here is the complete logs file:
azure-vnet.log
It seems it cannot find the address pool.
Could you please support me on this? Maybe I'm missing some prerequisites or configuration? Thanks

Fixed... configuration issue:)


Update tests to increase code coverage

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.8%) to 95.782%

Totals

Change from base Build<PHONE_NUMBER>:
0.8%

Covered Lines:
1483

Relevant Lines:
1517

💛  - Coveralls


fixing log send on linux and ripping out client log file code

This is an example PR showing what gets deleted if we decide the client isn't responsible for understanding where logs go anymore. Two big chunks go away: all the "split log file" code, and all the log rotation code.
It's unclear how we'll want to actually accomplish log rotation if we do this. I'll get some more thoughts from you guys tomorrow, @cjb @patrickxb .

Where does the log file go on auto fork? Chris ball and I just used that
feature the they day.
Also Steve really needs to look at this too because of Windows changes.
What problem is this solving?
On Monday, February 1, 2016, oconnor663<EMAIL_ADDRESS>wrote:

This is an example PR showing what gets deleted if we decide the client
isn't responsible for understanding where logs go anymore. Two big chunks
go away: all the "split log file" code, and all the log rotation code.
It's unclear how we'll want to actually accomplish log rotation if we do
this. I'll get some more thoughts from you guys tomorrow, @cjb
https://github.com/cjb @patrickxb https://github.com/patrickxb .
You can view, comment on, or merge this pull request online at:
https://github.com/keybase/client/pull/1863
Commit Summary

have run_keybase log to keybase.service.log
delete LogRotate from the protocol
delete a ton of log file rotation code

File Changes

M go/client/cmd_ctl.go
https://github.com/keybase/client/pull/1863/files#diff-0 (1)
D go/client/cmd_ctl_logrotate.go
https://github.com/keybase/client/pull/1863/files#diff-1 (43)
M go/client/fork_server_nix.go
https://github.com/keybase/client/pull/1863/files#diff-2 (15)
M go/client/fork_server_windows.go
https://github.com/keybase/client/pull/1863/files#diff-3 (15)
M go/libcmdline/cmdline.go
https://github.com/keybase/client/pull/1863/files#diff-4 (10)
M go/libkb/config.go
https://github.com/keybase/client/pull/1863/files#diff-5 (7)
M go/libkb/env.go
https://github.com/keybase/client/pull/1863/files#diff-6 (19)
M go/libkb/globals.go
https://github.com/keybase/client/pull/1863/files#diff-7 (3)
M go/libkb/interfaces.go
https://github.com/keybase/client/pull/1863/files#diff-8 (4)
M go/libkb/util.go
https://github.com/keybase/client/pull/1863/files#diff-9 (7)
M go/logger/logger.go
https://github.com/keybase/client/pull/1863/files#diff-10 (10)
M go/logger/null.go
https://github.com/keybase/client/pull/1863/files#diff-11 (3)
D go/logger/rotatelog_nix.go
https://github.com/keybase/client/pull/1863/files#diff-12 (34)
D go/logger/rotatelog_windows.go
https://github.com/keybase/client/pull/1863/files#diff-13 (12)
M go/logger/standard.go
https://github.com/keybase/client/pull/1863/files#diff-14 (18)
M go/logger/test_logger.go
https://github.com/keybase/client/pull/1863/files#diff-15 (7)
M go/protocol/keybase_v1.go
https://github.com/keybase/client/pull/1863/files#diff-16 (27)
M go/service/ctl.go
https://github.com/keybase/client/pull/1863/files#diff-17 (4)
M packaging/linux/run_keybase
https://github.com/keybase/client/pull/1863/files#diff-18 (2)
M protocol/avdl/ctl.avdl
https://github.com/keybase/client/pull/1863/files#diff-19 (1)
M protocol/js/flow-types.js
https://github.com/keybase/client/pull/1863/files#diff-20 (20)
M protocol/json/ctl.json
https://github.com/keybase/client/pull/1863/files#diff-21 (7)
M shared/constants/types/flow-types.js
https://github.com/keybase/client/pull/1863/files#diff-22 (20)

Patch Links:

https://github.com/keybase/client/pull/1863.patch
https://github.com/keybase/client/pull/1863.diff

—
Reply to this email directly or view it on GitHub
https://github.com/keybase/client/pull/1863.

I think that the log file on autofork goes to Env.GetLogFile(). But Env think the service log goes to "keybase.log" while install_osx.go thinks it goes to "keybase.service.log". It could be that Env.go's idea of where the logs go is only relevant on Linux and Windows, but @patrickxb's thought was that we could get rid of it entirely. I'm not sure about the whole thing yet, other than that it's unfortunate to have so many different sources of truth for this one value.

The original issue that sent me down this rabbit hole is that keybase log send has the wrong log file name on Linux. We could punt on all of this and just update LogSend to do the right thing (it already has os-specific code), but I figured it was worth untangling.

Urg, I was worried this was going to be an issue. @malgorithms couldn't believe that we couldn't figure out where the log files were, but as you say, you don't know where your log is going if you're launched with output redirection.
I agree it's turned out to be a mess.  @gabriel has often expressed displeasure about the --log-file parameter.  But it's needed for autofork, otherwise there's no way to figure out where the log goes. And all of our other parameters are configurable via file, flags, or environment.
Anyways, long term, maybe the service should get more involved.  You launch the service and tell it where to put its log, and then it's smart about how to rotate, etc.
But I disagree that --log-file or clt rotate are dead.  I think they're both needed for autofork.

Yeah I generally prefer convention over configuration. This is a core principle of certain projects (like rails), as a response to insane J2EE projects with config files everywhere :)

Abandoned in favor of https://github.com/keybase/client/pull/1880


Rework limits

I'm not sure about the interface but opening it for discussion.

/cc @andersjanmyr since you wrote the first version.

The table below describe the current limits, the previous ones and what are the limits in the Rusk SDK:

operation / version
Go 0.1.1
Go 0.1.2
Rust 0.9.1 (for reference)
changed in Go 0.1.2?

all header names (per header)
10240
8192
8192
Yes (lower)

all header values (per header)
10240
8192
8192
Yes (lower)

original header names (per header)
10240
8192
8192
Yes (lower)

single header value (unused in Go)
65536
8192
8192
Yes (lower)

method
1024
1024
8192
No

url
10240
1024
8192
Yes (lower)

tls cipher name
10240
16384
128
Yes (higher)

tls protocol
10240
16384
32
Yes (higher)

tls client hello
10240
16384
512
Yes (higher)

It looks good to me. I'm happy as long as I can tweak the sizes when needed.


fix issue 977

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible
This PR fixes issue 977
What does the code in this PR do / what does it improve?
n/A
Can you briefly describe how it works?
n/a
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:

[ ] Update the docstring(s)
[ ] Update the documentation
[ ] Tests to check the (new) code is working as desired.
[x ] Does it solve one of the open issues on github?

Notes on testing

Until the automated tests pass, please mark the PR as a draft.
On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

Coverage increased (+0.01%) to 93.797% when pulling 3fd89616be1bbf9bf1ba549405e2b2433a8f79fe on bayes_fix into ffcf06ad86471caf11cc831f2ff68d70b59464af on master.

@JoranAngevaare There is no need to bump version, it did not affect anything that has been processed, is only relevant for those runs with one peak on a given chunk


Doesn't work with commands from powercord.

It is not working when I sent a message client-side (i.e a command)
Can you fix it? It would help a lot for making new search requests etc.
Thanks in advance!

@Ozaxx I will look into it. Not sure if that is possible


fix: only add timestamp for osio

fixes: https://github.com/fabric8-launcher/launcher-frontend/issues/312

[test]

[test]


VSImporter should not include empty property groups in the vcxproj

Either remove these groups from the templates or have vsimporter remove them if they remain unfilled.
The two property groups most commonly left empty:
<ImportGroup Label="ExtensionTargets" />
<ImportGroup Label="Shared" />

Duplicate of #2054


build: migrate from github.com/golang/protobuf to google.golang.org/protobuf

Fixes: #2650

Codecov Report
Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (458db39) 36.12% compared to head (66a3a7e) 36.10%.

:exclamation: Current head 66a3a7e differs from pull request most recent head 5457ddb. Consider uploading reports for the commit 5457ddb to get more accurate results

Files
Patch %
Lines

infra/conf/jsonpb/jsonpb.go
0.00%
12 Missing :warning:

common/registry/registry.go
0.00%
11 Missing :warning:

common/serial/resolver.go
0.00%
8 Missing :warning:

infra/conf/v4/api.go
0.00%
8 Missing :warning:

infra/conf/v4/services.go
0.00%
8 Missing :warning:

infra/conf/v2jsonpb/v2jsonpb.go
0.00%
2 Missing :warning:

transport/internet/config.go
50.00%
1 Missing and 1 partial :warning:

app/observatory/multiobservatory/multi.go
0.00%
1 Missing :warning:

app/router/config.go
0.00%
1 Missing :warning:

common/net/address.go
0.00%
1 Missing :warning:

... and 3 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2844      +/-   ##
==========================================
- Coverage   36.12%   36.10%   -0.03%
==========================================
  Files         715      714       -1
  Lines       40949    40958       +9
==========================================
- Hits        14794    14788       -6
- Misses      24521    24537      +16
+ Partials     1634     1633       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Refactor pages into page component

There's a lot of duplicate logic in pages that can be consolidated into a single page component. I think this will be possible. Some state may have to move up to main.

One issue here is that global state can hold an array of the data actually returned from the api call and pass down string arrays to the generic page element. But then how does one map the page's cursor and filtered data back to the structured data on enter, e.g. to store the latest selected job ID?


OOP update_coefficients(...)

Objects like MatrixOperator which contain "actual data" need an in-place and an out-of-place update method. My initial thought was to pass an update function to MatrixOperator as in L = MatrixOperator(A; update_func = A_update_func) where update_func may have an in-place and an out-of-place method. However since the calling signature of both IIP and OOP is the same, update_coeffs(L, u, p, t)/ update_coeffs!(L, u, p, t) it would be impossible to distinguish between IIP and OOP methods.
Another solution is to ask for two separate functions: one IIP and one OOP. Eg. MatrixOperator(A; update_func = oop_func, update_func! = iip_func).  This is what I am going with unless other folks have better ideas. @ChrisRackauckas  @gaurav-arya

@ChrisRackauckas @gaurav-arya please review this PR. Thanks


fix(timezone-picker): list all IANA timezone options + prioritize controlled value

Description
User in Amsterdam reported that the timezone picker did not auto-select their zone. This was due to the component using a subset of timezone options that remove aliases. I've edited the code to import the larger list (17kb bundle increase), but it should now work for a larger audience.
Another bug highlighted in this code sandbox shows that the auto-selected timezone was overwriting a developer/state defined value prop. To fix, it only auto-selects if the value prop is falsy. Added a test to confirm this works.
Scope

[x] Patch: Bug Fix

I reported this in #1491 - good to see it's fixed, here's to hoping it does not break my custom override which auto adds the time zone if not found (which Amsterdam is not).


bug: Cant turn on the night variant of the tokyonight theme.

Did you check docs and existing issues?

[X] I have read all the tokyonight.nvim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of tokyonight.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
v0.10.0
Operating system/version
MacOS Sonoma 14.2
Describe the bug
I have setup the night variant of the theme, but when i apply that the background goes black/the background of my terminal. This issue is only for the night variant of the theme, other variants are just working fine.
Steps To Reproduce

Here is the ss of my config.
Expected Behavior
The background should be colored and not black
Repro
vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    -- add any other plugins here
  },
})

@folke help please sir.

As you can see, the themes guibg attribute is not there in the Normal highlight group

same problem here:

it seems that tokyonight-night defaultly enabled transparent...

return {
"folke/tokyonight.nvim",
config = function()
require("tokyonight").setup({
style = "night",
styles = {
functions = {}
},
})
vim.cmd("colorscheme tokyonight")
end,
}
For now this should work

Let @folke get back so that he can provide a permanent fix

return { "folke/tokyonight.nvim", config = function() require("tokyonight").setup({ style = "night", styles = { functions = {} }, }) vim.cmd("colorscheme tokyonight") end, }
For now this should work

it doesnt work for me:

Bro just delete whatever you have written in your colroscheme config and add the above one that I shared.

Bro just delete whatever you have written in your colroscheme config and add the above one that I shared.

still no effect, let folke fix it...


Special Thanks Update

This is to thank you Guy for the work you've been doing in this project.
Thank you for all the great work you've been doing to help with maintaining this project \o/
We really appreciate it 💯
cc @guykogus
Checklist

[x] I checked the Contributing Guidelines before creating this request.
[ ] New extensions are written in Swift 5.0.
[ ] New extensions support iOS 10.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+, or use @available if not.
[ ] I have added tests for new extensions, and they passed.
[ ] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[ ] All extensions are declared as public.
[ ] I have added a changelog entry describing my changes.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 663 tests, with 0 failures (0 unexpected) in 11.532 (14.244) seconds

:book:
tvOS: Executed 632 tests, with 0 failures (0 unexpected) in 3.021 (3.729) seconds

:book:
macOS: Executed 495 tests, with 0 failures (0 unexpected) in 0.827 (1.147) seconds

  Generated by :no_entry_sign: Danger

Thanks!!! ❤


Extract page name from block

Hi,
I would like to extract the title of a page from the :block/page id, is this possible?
Thanks

Hi. Yep. You can by drilling into the :block/page attribute using a map in a pull. For example, to pull every block in your graph with its page name: lq sq '[:find (pull ?b [:block/content :block/name {:block/page [:block/original-name]}]) :where [?b :block/content]]'

Hi,
Thanks very much for your quick response, this is exactly what I was looking for.


feat: add support for breakout rooms

Change also the message overlay in all the breakout rooms.

Adding a selector to change between:

All rooms.
Main room.
Breakout room 1
Etc.

Nice!
A couple more comments:

you can get rid of the breakoutRooms.ts file and you can just hold them in the index file and pass them as a prop to handleSubmitMessage as they are only used there
for the plugin.ts, you can just export let plugin and assign it in the index, and avoid the getters and setters, usually its a good practice but its a bit of an overkill here (IMHO)

@TsvetozarTsonev , I changed the part related to the breakoutRooms, but I cannot do the same with the plugin (or I don't know exactly how to do it). If I import the index.ts in another file, it's triggered twice.

@TsvetozarTsonev I modified the code and  now I export the plugin variable directly.


Make Identifiers generically, lazily composable

Previously, HttpConfig had logic for composing Identifiers. This is moved into the RoutingFactory so it may be used across protocols.
Furthermore, identifier composition was eager, identifying each request through all identifiers and then checking the results in order.  Now, identifiers are checked serially. This change is made under the assumption that Identifiers tend to be fast but incur allocation.

Are you sure that the previous implementation, based on foldLeft identified requests eagerly?  By my reading, that checked the identifiers serially until an identification was found.

You're right that it's not as eager as I thought:
      identifiers.foldLeft(HttpConfig.NilIdentification) { (identification, next) =>
        identification.flatMap {
          // the request has already been identified, just use that
          case identified: IdentifiedRequest[Request] => Future.value(identified)
          // the request has not yet been identified, try the next identifier
          case unidentified: UnidentifiedRequest[Request] => next(req)
        }
      }

This does eagerly create the future chain (i.e. we call f.flatMap for all identifiers), though identifiers aren't actually invoked until the future is satisfied and unidentified.
I find the combination of Seq.foldLeft and Future to be a bit mind-bendy.  This implementation definitely isn't bad, though I do find the recursive approach to be a it clearer (or, more idiomatic for future looping/iteration)


ldap_setting_key is undocumented

Describe the bug
Using the documented args, the following is returned during plan.
Error: Missing required argument

  on artifactory.tf line x, in resource "artifactory_ldap_group_setting" "ldap_group_name":
  x: resource "artifactory_ldap_group_setting" "ldap_group_name" {

The argument "ldap_setting_key" is required, but no definition was found.

ldap_setting_key is not listed anywhere in https://registry.terraform.io/providers/jfrog/artifactory/latest/docs/resources/ldap_group_setting

artifactory version: 7.41.12
terraform version: 0.14
terraform provider version: 7.4.3.

Expected behavior
Please provide documentation for ldap_setting_key

@autmwatl thanks for the ticket! I'll add the missing argument description in the next version.


ARROW-664: [C++] Make C++ Arrow serialization deterministic

Made a follow-up JIRA to make use of jemalloc features: https://issues.apache.org/jira/browse/ARROW-665


Sync Coveralls Repo

The coveralls repo needs to be synched after the repo was renamed. Coverage reports are not currently being run on commits or pull requests. We don't have permissions to the repo on Coveralls, so I assume this is something JJ can do.

/cc @jgeewax

/cc @silvolu
need to update https://coveralls.io/github/GoogleCloudPlatform/gcloud-ruby

I created a new project on Coveralls. It doesn't have all the history of the old project, but CircleCI is configured to push coverage data to it now.
https://coveralls.io/github/GoogleCloudPlatform/google-cloud-ruby


Added filter to docker list command

Closes #121 (maybe).
cc: @rgbkrk

Looks good. I take it filters get combined as ORs then?

Yep!


Error when removing checksums argument

When omitting optional argument checksums error being throw: Unsupported cryptographic algorithm
https://github.com/jaredcat/WiFiList/actions/runs/10190739186/job/28191021725

Try to use gh release upload command, see https://cli.github.com/manual/gh_release_upload


Fix columns layout update command

The current update command for the columns layout is broken when going to a lower column count. The current method instead of deleting, actually appends and gets the node in an invalid state. This fixes the update operation, so when going from 3 columns to 2, it will delete the last column and preserve the content as is in the first 2.

No objections but note that this changes the behavior - instead of transferring the children we now delete them

That's fine, this is the deletion method, we don't want to keep them.


Investigate iOS playback

Media not playing on iOS.
Please provide the following info to assist this:

iOS version
Media info (container, video codec, audio codec)
Browser
Browser version

Thank you!

IOS version : 15.0.1.
Model : IPad 2021.
Media info : any media, h264 or h265, all mkv.
Browser : tested on latest Safari and brave.

https://pastebin.com/NwhC0Ekq

Awesome thank you! I’ll look into this and get back to you asap

Thank you for your patience with this one. After some testing it seems iOS doesn't support mkv
mp4 play just fine.

https://pastebin.com/NwhC0Ekq

Logs look fine. It's the client (iOS) in this case that doesn't support the container (mkv)

Oh. So no way to enable it in the futur? At all? Such a shame... ☹

I do have an issue #210 to look into audio transcoding at the server level for next release. Maybe while I'm there I could also look into what it will take to remux or encode mkv to mp4 on the fly too?
That way you can set what the output container and audio will be from your sever settings.

#258
Tagged for next release v2.1.0 I'll keep you updated 😄

Hi @parer55
I'm happy to announce this is now in v2.1.0-beta.6
You'll find a new "Test" button, next to the "Play" button for your media.
Any feedback is appreciated 😄 thanks.

Hello,
Thanks for the new beta version. Doesn't seem to do the trick however. Below a paste of my logs. Ask if you want me to give you anything else.
https://pastebin.com/r9RL0gTD

This is what happens after a few seconds of loading.

Ok now i've managed to get sound on this file for a few minutes :
https://pastebin.com/t2GrusZZ

Awesome thank you for sending this through. I’ll look into it further and get back you.

If you need anything, knock on my door!

I’ve tracked down the issue. Aiming to have a fix up over the next few days. Thanks for testing this out!

This is exciting by the way! Up until now Midarr has only served media as is.
Remuxing on the fly opens up alot of new possibilities like on demand transcoding for example.
Super exciting, so thank you again for bringing this up and helping push this forward!

v2.1.0-beta.7
Give this build a go 😄

Ok now i've managed to get sound on this file for a few minutes : https://pastebin.com/t2GrusZZ

This is a 4K video too, which I'm not sure if iOS Safari supports. Remember this update is only allowing the container i.e. mkv, to be remuxed on the fly to a wider supported container i.e. mpeg-ts, for playback.
Could you also try a 1080p video?

https://github.com/midarrlabs/midarr-server/discussions/292
@parer55 special thanks for helping with this release.


Pipe operator breaks whitespace sensitivity

Prerequisites
Please put an X between the brackets as you perform the following steps:

[x] Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues
[x] Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries.
[x] Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)

Description
Consider this code:
theorem foo {g : True → False} : False := by
  exact
g <| trivial

theorem foo' {g : True → False} : False := by
  exact
g trivial

Lean accepts the first theorem but produces multiple errors on the second theorem. Given that tactic scripts should be indentation-sensitive, I think that both versions should produce an error.
Context
This is a minimization of a mathlib issue. In mathlib, the code looks like this:
lemma coeff_preΨ_ne_zero {n : ℤ} (h : (n : R) ≠ 0) :
    (W.preΨ n).coeff ((n.natAbs ^ 2 - if Even n then 4 else 1) / 2) ≠ 0 := by
  induction n using Int.negInduction with
  | nat n => simpa only [preΨ_ofNat, Int.even_coe_nat]
      using W.coeff_preΨ'_ne_zero <| by exact_mod_cast h
  | neg n ih => simpa only [preΨ_neg, coeff_neg, neg_ne_zero, Int.natAbs_neg, even_neg]
      using ih <| neg_ne_zero.mp <| by exact_mod_cast h

lemma natDegree_preΨ_pos {n : ℤ} (hn : 2 < n.natAbs) (h : (n : R) ≠ 0) :
    0 < (W.preΨ n).natDegree := by
  induction n using Int.negInduction with
  | nat n => simpa only [preΨ_ofNat] using W.natDegree_preΨ'_pos hn <| by exact_mod_cast h
  | neg n ih => simpa only [preΨ_neg, natDegree_neg]
        using ih (by rwa [← Int.natAbs_neg]) <| neg_ne_zero.mp <| by exact_mod_cast h

Reducing the indentation of the final line of the second theorem causes an error. This seems confusing because the analogous line of the first theorem works fine, but it can be argued that the required indentation in the second theorem is correct and the first theorem should error.
Steps to Reproduce

Copy the MWE above into live.lean-lang.org

Versions
4.11.0-nightly-2024-07-23 on live.lean-lang.org
Impact
Add :+1: to issues you consider important. If others are impacted by this issue, please ask them to add :+1: to it.

Could you say what the "it can be argued" is? I don't see it, and it occurs to me that I was also confused by this issue recently!


bug:  wagmi/cli generate Invalid ABI for contract: Invalid at [2].outputs[0].type

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.3.10
Current Behavior
I'm trying to generate abi using an hardhat project, it worked find but broken when I added SafeTransfer.sol library,
but generate fails with:
Invalid ABI for contract "SafeTransfer"
- Invalid at `[2].outputs[0].type`

the error (from zod)
ZodError: [
  {
    "validation": "regex",
    "code": "invalid_string",
    "message": "Invalid",
    "path": [
      2,
      "outputs",
      0,
      "type"
    ]
  }
]
    at get error [as error] (/home/sherpya/workspace/web3/chainraise-web/node_modules/zod/lib/index.mjs:537:31)
    at ZodArray.parseAsync (/home/sherpya/workspace/web3/chainraise-web/node_modules/zod/lib/index.mjs:659:22)
    at async getContract (/home/sherpya/workspace/web3/chainraise-web/node_modules/@wagmi/cli/dist/commands-IGLZ47TT.js:265:11)
    at async generate (/home/sherpya/workspace/web3/chainraise-web/node_modules/@wagmi/cli/dist/commands-IGLZ47TT.js:103:24)
    at async CAC.<anonymous> (/home/sherpya/workspace/web3/chainraise-web/node_modules/@wagmi/cli/dist/cli.js:15:3)
    at async file:///home/sherpya/workspace/web3/chainraise-web/node_modules/@wagmi/cli/dist/cli.js:32:5 {issues: Array(1), addIssue: ƒ, addIssues: ƒ, name: 'ZodError', stack: 'ZodError: [
  {
    "validation": "regex",
  …-web/node_modules/@wagmi/cli/dist/cli.js:32:5'}

Expected Behavior
generate the abi file
Steps To Reproduce
create any wagmi project:
import { defineConfig } from '@wagmi/cli';
import { hardhat } from '@wagmi/cli/plugins';

export default defineConfig({
    out: 'gen/abi.ts',
    plugins: [
        hardhat({
            project: '../chainraise'
        }),
    ]
});

Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
https://github.com/sherpya/chainraise
https://github.com/sherpya/chainraise-web
Anything else?
No response

Can you share what the SafeTransfer ABI? Once I have that I can look into it.

SafeTransfer.zip

SafeTransfer.json.txt
renamed .txt, github does not allow json

In the ABI, "type": "IERC20" is not a valid elementary type.
{
  "inputs": [],
  "name": "NATIVE_TOKEN",
  "outputs": [
    {
      "internalType": "contract IERC20",
      "name": "",
      "type": "IERC20"
    }
  ],
  "stateMutability": "view",
  "type": "function"
}

isn't the abi generated by solc?

so do I need to bugreport somewhere else?

I'd gather some info about why solc or another tool is generating that ABI, then come back here with the info.

@sherpya you can fix this by not having any public functions on the library.  you have IERC20 public constant NATIVE_TOKEN = IERC20(address(0));. public functions on a library imply that the library will be deployed to its own contract and thus gets its own abi.
You probably dont need SafeTransfer be an external library and you don't need a trivial value like address(0) to be a public.  Or, if you do, put that value on a contract instead of in a library.
If a library only has internal functions, then no abi file will be created and you will not have this wagmi problem.


Fixed issue of PR #1229 , Changed Tour of XOEditor.activity from bootstrap to Intro.js

Hey @llaske here is the fixed of PR No : https://github.com/llaske/sugarizer/pull/1229 please review my PR

The welcome screen popup is missing.

Ok @llaske I'm working on it

hey @llaske I have resolved the issue please review it

Nice. Thanks.


Re-design icon preview page

Our icon preview page needs some love.
It would be nice if:

able to copy token via simple click
be aligned with the styled used for illustrations, example sticky header for search-bar, quick filter regular/filled

https://github.com/AxisCommunications/fluent-components/issues/241


Incorrect Documentation

I believe that there is more than 100 users (not groups, users) that can be added.  Read this thread:
https://community.powerbi.com/t5/Service/Add-more-than-100-Users-to-App/m-p/2551721

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72ff3e88-8793-8e2b-bdb2-0e3d09372b93
Version Independent ID: 0e1245cb-d7af-c73c-39c4-39f5665ae51a
Content: Publish an app in Power BI - Power BI
Content Source: powerbi-docs/collaborate-share/service-create-distribute-apps.md
Service: powerbi
Sub-service: pbi-collaborate-share
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thanks for your comment, @collinq987. This issue has been assigned to the doc author for review.

Hi @collinq987, I have asked the product team for confirmation and will update the doc as soon as I get the answer. I'm going to close this issue here in the meantime. Thanks for your comment!


Policy on commits and pull requests

There should be a policy on how code commits should be contributed.

Also how the people with write access to the repository behave: should write access be solely for agreed pull requests after review (GateKeeper Model), or should writers treat it as a place to commit to without pull requests (CVCS Model). The fully DVCS model, people pulling directly from others repositories, is also possible but arguably not as consistent with using GitHub.  All three can work fine, but it is good to be explicit.


chore(p2p): move services into folders

Please read contributing guidelines and remove this line.

#10695
#10694  👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.


Issue with Example Project on iOS simulator

Safari cannot open the page because the address is invalid.
I get this error after giving permission to app for log in with facebook.

I'm finding the same, links with the dot in don't seem to be accepted

Did you configure your info.plist by copying and pasting?
<key>CFBundleURLTypes</key> <array>   <dict>   <key>CFBundleURLSchemes</key>   <array>     <string>fb397780500xxxxxx</string>   </array>   </dict> </array> <key>FacebookAppID</key> <string>397780500xxxxxx</string> <key>FacebookDisplayName</key> <string>App Name</string>
If so I ran into this problem too.
I would try doing it through Xcode instead. Keeping it very simple.

Target App > Info > URL Types and the click the +

Feel free to reopen if that suggestion doesn't work for you


TypeError: Cannot read property 'type' of undefined

Hi, I'm trying to use this plugin in X1011/X1011.github.io@cb87cf47ea7cba02a0195b37fb2f4ae870552629, but I get this error:
toc-and-anchor $ pug --obj pug-config.js experience.pug

/home/dan/drive/programming/X1011.github.io/node_modules/pug-filters/lib/handle-filters.js:54
        throw ex;
        ^

TypeError: Cannot read property 'type' of undefined
    at Array.<anonymous> (/home/dan/drive/programming/X1011.github.io/node_modules/markdown-it-toc-and-anchor/dist/index.js:102:36)
    at ParserInline.tokenize (/home/dan/drive/programming/X1011.github.io/node_modules/markdown-it/lib/parser_inline.js:135:22)
    at ParserInline.parse (/home/dan/drive/programming/X1011.github.io/node_modules/markdown-it/lib/parser_inline.js:163:8)
    at Array.inline (/home/dan/drive/programming/X1011.github.io/node_modules/markdown-it/lib/rules_core/inline.js:10:23)
    at Core.process (/home/dan/drive/programming/X1011.github.io/node_modules/markdown-it/lib/parser_core.js:51:13)
    at MarkdownIt.parse (/home/dan/drive/programming/X1011.github.io/node_modules/markdown-it/lib/index.js:519:13)
    at MarkdownIt.render (/home/dan/drive/programming/X1011.github.io/node_modules/markdown-it/lib/index.js:539:36)
    at filterWithFallback (/home/dan/drive/programming/X1011.github.io/node_modules/pug-filters/lib/handle-filters.js:46:38)
    at walk.includeDependencies (/home/dan/drive/programming/X1011.github.io/node_modules/pug-filters/lib/handle-filters.js:26:18)
    at walkAST (/home/dan/drive/programming/X1011.github.io/node_modules/pug-walk/index.js:13:26)

The offending line corresponds to this one in your source file, and it seems state.tokens.slice(-1) is empty when this occurs.
The same error occurred when i tried the other 2 toc plugins, markdown-it-toc and markdown-it-table-of-contents.

fixed in v4.2.0


Get error when importing this into latest ADK

Hey,  I install the Hello drone on the cell phone, and setted up SITL on windows with cygwin. how to connect them with usb or udp? can anybody give me some clues,,,thanks

Hi @1ee7
Please raise this question on the DroneKit Android forums.
As a general rule, best not to hijack a github issue with an unrelated issue.

This was fixed by #5


Usage of aws_mutex_init() vs AWS_MUTEX_INIT

There are cases in our code of AWS_MUTEX_INIT being used to initialize a mutex within a function.
Documentation for PTHREAD_MUTEX_INITIALIZER says that the macro is intended for use with static variables. Likewise with the SRWLOCK_INIT macro on Windows.
However, libc++'s implementation of std::mutex uses the macro in its constructor, and the constructor is noexcept.
Googling around, I found this blog post about implementing std::mutex for embedded systems, and how the author needed to remove the noexcept from the constructor because it could throw.
So should we:

Only use the macro for statically allocated mutexes?
Always use the macro, and simplify our codebase by removing the aws_mutex_init() and aws_mutex_clean_up() functions.

Reading the pthread docs, sounds like the static initializer is only useful for default settings/attributes, and it skips error checking.
Why not just use appropriate initializer functions, and avoid the initializer macro entirely?


Is heatmap4 = self.heatmap3(c4) a typo?

Should it be heatmap4 = self.heatmap4(c4) ?
ref: https://github.com/vignywang/AWDesc/blob/711d68395ad7a9557fe93725fbf4566f4ac2fa55/nets/network.py#LL77C31-L77C31

Thank you for your reminder and contribution. We will correct this error.


MainLoop: Remove deprecated methods

Moved out of #43240

For reference, I raised a concern for this a while back: #32335, but I have little concrete use cases to show, and whether they're valid in the first place.

Note that the C++ methods should also be removed if this is being removed.

Tried #7269, I haven't got to use those methods, only override them:
non_realtime_main_loop_test.zip

Thanks!


Call to an undefined pgsql_connection:database() in pgsql_pool:get_database()

At line 57 of pgsql_pool.erl a call to pgsql_connection:database() is made.
There's no such function in the current pgsql_connection.erl: http://github.com/wg/epgsql/blob/master/src/pgsql_connection.erl

Any ideas how to fix it?


Complex index

Close in favor of https://github.com/tmillenaar/GridKit/pull/62
The other implementation uses a i64 to represent two i32 numbers instead of a complex128.
The other implementation requires fewer changes to the code and keeps everything in integers.
The complex128 data type uses floats which does not fit the cell_index well.


[Event Request] Codeunit 423 Change Log Management - procedure LogModification - OnLogModificationOnAfterCheckSecurityFiltering

Please add the following existing Event OnLogModificationOnAfterCheckSecurityFiltering to procedure LogModification in Codeunit 423 Change Log Management
[Event Request] Codeunit 423 Change Log Management - procedure LogModification
var
    xRecRef: RecordRef;
    FldRef: FieldRef;
    xFldRef: FieldRef;
    i: Integer;
    IsReadable: Boolean;
begin
    OnBeforeLogModification(RecRef);
    if RecRef.IsTemporary then
        exit;

    if not IsLogActive(RecRef.Number, 0, 1) then
        exit;

    xRecRef.Open(RecRef.Number, false, RecRef.CurrentCompany());
    OnLogModificationOnBeforeCheckSecurityFiltering(xRecRef);
    xRecRef."SecurityFiltering" := SECURITYFILTER::Filtered;

    OnLogModificationOnAfterCheckSecurityFiltering(xRecRef); // <-- NEW EVENT

    if xRecRef.ReadPermission then begin
        IsReadable := true;
        if not xRecRef.Get(RecRef.RecordId) then
            exit;
    end;
    ...

[IntegrationEvent(false,false)]
local procedure OnLogModifcationOnAfterCheckSecurityFiltering(var xRecRef: RecordRef)
begin
end;

This ask looks like security issue, please provide explanation why you need this?

@AlexanderYakunin  Our originally accepted event request was: https://github.com/microsoft/ALAppExtensions/issues/20724 and the event is now on the wrong line.
In our case, we overwrite the security filter in a special scenario for a Logging extension.
In the past there were scenarios in which the change log is not written correctly due to security filters. It's about writing the change log, where we want to log all changes, even if they may not have passed the security filter. The question here, wouldn't it make more sense to change the security filtering in the standard.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 15512.


Can't pass props in selectors

react-redux supports passing props to select. Currently reselect only passes state. Is it possible to add props to selector functions?

I'm not sure that the new react-redux api for the connect decorator is going to support this. Check out this PR

Huh. That would be unfortunate... Maybe @gaearon can clarify?

Seems that there will be an additional argument for @connect decorator for using props to further filter the state. So I guess that yes, this api will get deprecated.

Confirmed as gone in the release notes for react-redux v.0.5.0

It looks like this added back in react-redux. Can we get it back in this package?

Yep, I guess we should look into this now

Any time frame on this? Attempted to jump in on a fork, but didn't know if changes were coming soon for a 1.0.

Funnily enough, I was just looking at it. Did you have a plan? I'm wondering whether the dumb default memoize and its reference equality is going to work with the props. I don't recall how the props are handled inside react. I guess if the prop object is mutative and has a stable reference for the lifetime of the component or it is recreated entirely on each render then we might have problems?
I think that the API might change slightly in the next version, possibly allowing the user to specify a memoization function in createSelectorCreator and allowing variadic depencies. I just started exploring this in my fork here if you'd like to have a look.

I guess if the prop object is mutative and has a stable reference for the lifetime of the component or it is recreated entirely on each render then we might have problems?

Props object is new every time. It's considered immutable.

Okay, I just finally started using reselect in a project and ran into this one. So basically we want to parameterize the select expression with an additional object that should be passed down the select chain, right? And we should be able to express when we consider this object unchanged, so that we can make use of caching.

Take a look at #35. We've had a bit of a discussion about this there

Address in the 1.0.0 release


Will there be a support for Laravel 5?

It should be great as a replacement of Form class.

It seems to work perfectly with L5.

I haven't tested it with Laravel 5 yet but I would be really surprised if it didn't already work :) The only thing I'll really have to look into is if any CSRF token related things changed that I'll have to update in the service provider.
Going to test this afternoon and push out any changes necessary.

Double checked, all works great, no changes necessary :) Updated the docs a bit to reflect that.

I've found a bug: with input that have brackets in its name, errors are not shown. Not sure if it's laravel 5 only. I made a PR in adamwathan/form repository.


New option for changing ease type

The current method of changing ease type from 'create animation' isn't the most intuitive way.

True. Now there is three way to change it. Manually by writing it, creating new animation, or checking that checkbox there. And this is most intuitive of those :) I think this is something that belongs to the "Edit Animation" menu. Because you're editing exist animation. But this is something that left there for the reason how I've used those animations, if it's under edit menu it will limit editing to one layer by time. Another reason was that I wanted to change all easing types fast to random easing types while creating keyframes. Thanks for pointing this one.

Just to be clear, I was thinking of adding the option to change ease type here:

You're right though, changing it one by one is different from changing the whole thing.


path-like struct names for nested objects

This has nice synergies with #131 that makes structs basically never require numeric postfixes.
This depends on #128

Merged into #131 as there's not much benefit of having this without the other


Remove error screen when maintenance check fails

Show Start page as normal if maintenance check fails
Resolves:
BI-13481

PR closed as BI-13481 requirements have changed. Will create a new PR for a renamed branch


Illegal string offset error when saving form

Hello,
When I save or update a resource, I receive illegal string offset while I set
$casts = [ 'contact' => 'object'];
Please advice,

Hey! Can you provide a reproduction?

Hello,
I installed the nova-field library on a project with saved data in the database and the data was saved using $casts = ['contact' => 'array']
When viewed the data using JSON custom field, it was displayed correctly but when save / update the records illegal string offset error was displayed.
After tracking the error, i found out that the saved record in database was serialized, so I cleared the db and everything works fine now creating / update records.
Thanx,


Wrap long file names in explorer

I have some long file names (>80 characters) in some directories in my project. It would be good to see the entire filename in the explorer view.
For example:

Looks like duplicate of #155430 and issue linked in comment.
I doubt that devs decision changed since then.

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.
Happy Coding!


Page not responsive

The page becomes unusable in smaller screen sizes

I'd like to work on this.

@sounak98 Have you pushed yet?

Are you working on this? @sounak98

I like to Work on It

Closing as #167 fix this issue


A4000 failing to install still

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
gradient-utils 0.5.0 requires wheel<0.36.0,>=0.35.1, but you have wheel 0.37.1 which is incompatible.
pip install wheel==0.35.1 - Fails to work.

test
Steps: 50, Sampler: Euler a, CFG scale: 7, Seed:<PHONE_NUMBER>, Size: 512x512, Model hash: 3e16efc8
Time taken: 37.18s Torch active/reserved: 1730/2562 MiB, Sys VRAM: 3860/16118 MiB (23.95%)
It's resulting in 50 steps ( no highres ) taking 37 seconds with this wheel installed and only 12 seconds without it

I use you book daily so i don't mind testing stuff with each update ( discord - Creative Digitals#7215 )
Is it possible to build a dockerhub container with all the relevant stuff installed then the only the pip install wheel command needs to be done,

I use you book daily so i don't mind testing stuff with each update ( discord - Creative Digitals#7215 )
Is it possible to build a dockerhub container with all the relevant stuff installed then the only the pip install wheel command needs to be done,
!python webui.py {x_arg} {dd_arg} --gradio-debug --share # --gradio-auth me:password1234 ( --medvram ) was the issue with it slowing down, would it be worth # --medvram by default with the option to uncomment it,
everything is now working as it should

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. gradient-utils 0.5.0 requires wheel<0.36.0,>=0.35.1, but you have wheel 0.37.1 which is incompatible.
pip install wheel==0.35.1 - Fails to work.

Hey, how did you manage to fix this? I'm still getting that error on an A4000.

I've noticed this error but it doesn't seem to effect anything and the process succeeds. It's just packages complaining about their ideal dependency version not being installed.


Simplify hierarchy for CDK

I'd expect PolicyStatementGenerator and PolicyGenerator to be the same class, specialized for the CDK. There is always time to extract a CDK-agnostic library later on, if needed.
This way, the sample code will look easier and the source code will be much simpler to understand (for now).

Since you import from package, you could simply ignore PolicyFactory (new name) in favour of PolicyStatementFactory, then rewrite the example as

import {PolicyStatementFactory} from 'iam-policy-generator'

// your code defining a resource (i.e. a lambda function)

lambda.addRolePolicy(new PolicyStatementFactory().build())

Closing this issue by now.


CSS calc function not working correctly

I have a couple calc(100% - 60px) functions in my CSS attached to parent divs and works fine in my regular browser. However when I run my tests, they always fail do to all my child elements inside this div not being positioned correctly.
When I remove these calcs, and leave it at just 100%, everything work in the tests.
Spent a great deal of time trying to find a solution and came up empty.

You likely need to follow up with the PhantomJS project; Poltergeist is just an adapter between the PhantomJS VM and Capybara, and doesn't handle any of the rendering itself.

Ahh ok thank you


Benefit from mypy 0.930

Codecov Report

Merging #37 (3ea9e43) into main (6ec85dc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   64.09%   64.12%   +0.03%
==========================================
  Files          19       19
  Lines        1167     1168       +1
==========================================
+ Hits          748      749       +1
  Misses        419      419

Impacted Files
Coverage Δ

src/runboat/k8s.py
56.02% <100.00%> (+0.31%)
:arrow_up:

src/runboat/utils.py
60.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec85dc...3ea9e43. Read the comment docs.


Update scalafmt-core to 3.0.5

Updates org.scalameta:scalafmt-core from 3.0.4 to 3.0.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, semver-patch

Codecov Report

Merging #222 (9cbffe5) into master (03cdb58) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   38.46%   38.46%
=======================================
  Files           3        3
  Lines          91       91
=======================================
  Hits           35       35
  Misses         56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03cdb58...9cbffe5. Read the comment docs.


Repairing a unit test can not reproduce the problem with # 200

Now remove the https://github.com/denisenkom/go-mssqldb/blob/kardianos-dialer/token.go#L668 three lines to cause the unit test to fail and reproduce #200.
https://github.com/denisenkom/go-mssqldb/pull/208

Thanks


redundant Vias Insertion

It is not really an issue, but rather a proposal for an extension :
https://github.com/laurentc2/SKY130_for_KLayout/tree/main/redundant_vias_insertion
Laurent

@laurentc2 There is via stack generator that creates an array of redundant vias. You specify the starting layer and the ending layer and the size and it creates all the layers in between.


Removing all empty backbone tests.

Motivation:
Currently there are quite a few tests in
src/appforms/tests/tests/backbone that are empty which might cause some
confusion.
There are a few that are not empty and contain test code but that are
not included in modues.js hence they are not being run by testServer.
Modifications:
$ find . -type f -empty | xargs git rm
Result:
Project is a little cleaner.

Ok, can merge this.