[Image] Remove resizeMode from nativeOnlyProps to get rid of warning

@chirag04 pointed out in irc that he was getting warnings about using the resizeMode prop on Image. My understanding is that it should be used as a prop, and that using it in the style was slated to be deprecated.

This pull request gets rid of the warning message above, but stops short of adding a warning when using resizeMode via style - I would like to continue and add that warning if you agree @vjeux

@brentvatne  Anything on this? Now that react-native 0.6 is released i see this warning all over my app. :(

@chirag04 - this is fixed in 0.7.0 actually: https://github.com/facebook/react-native/commit/47508566a0635bd54e7c67f66ac883c97a14ced2
I'd wait until we merge in a fix for #1750 before using that version though

oh. Cool. Thanks.


Store instructions do not always raise RV32E exceptions

Store instructions will be decoded with alu_op_b_mux_sel_o = OP_B_IMM:
https://github.com/lowRISC/ibex/blob/1449ed5ea8f3d03127f7c3624e635e132830367d/rtl/ibex_decoder.sv#L778-L788
When RV32E = 1 an illegal instruction exception should be raised if any of the registers used by a given instruction are outside of the 0-15 range. In the case of the store instruction this should apply to both the storage address and the stored value.
The existing logic in ibex will not enforce this since alu_op_b_mux_sel_o = OP_B_IMM:
https://github.com/lowRISC/ibex/blob/1449ed5ea8f3d03127f7c3624e635e132830367d/rtl/ibex_decoder.sv#L179-L183
Therefore in RV32E mode a store instruction may attempt to store a value from registers 16-31, which is not well defined since the register file will not have those entries.
B-TYPE instructions, which have the same format, are likely unaffected since in their first cycle they do set alu_op_{a,b}_mux_sel_o = OP_{A,B}_REG_{A,B}.

Can you give me an example of an instruction that triggers this? I think the code that you quoted in the second snippet is trying to say "Don't read from a high register on A or B side, and don't write to a high register".
Is the problem that the RV32E spec doesn't allow immediate stores when the value is big? If so, I didn't know that was part of the spec.

The issue here is that for store instruction, both rs1 and rs2 are used. So if, say, we have sd 0(x10), x31, then it should be illegal instruction.
But since decoder sets alu_op_b_mux_sel_o to OP_B_IMM, the illegal_reg_rv32e check will pass because it doesn't check if rs2 is used, merely if the ALU uses rs2.

Oh, I see. Thanks for the explanation.


Some tests fail

Describe the bug
See log.
Version: 0.20.1
OS: FreeBSD 13 (installed from the package)

I can point out another problem is that the NWChem is not compiled with Python support.

I didn't realize that NWChem has Python support.
The Arch Linux port doesn't enable python support either.
Do you know how to enable python support in NWChem?

It should be pretty straightforward. I don't have my Makefiles on hand (filesystems at ALCF are down for maintence), but you should be able to set the PYTHONVERSION environment variable to the major.minor version of Python in your environment.
For further details: https://nwchemgit.github.io/Compiling-NWChem.html#setting-python-environment-variables

MPI was broken on  that machine.
I fixed MPI, added the PYTHON option to nwchem, and updated the test log in the URL in my OP.

0.21.0 test failures py38-qcengine-0.21.0-test.log


refactor(portal): 使用独立部署的novnc客户端

之前novnc客户端是和portal-web一起部署的，这就需要portal-web每次构建的时候去github上拉最新的novnc的文件，然后放到自己的public目录下。这会影响portal-web的构建速度。

Codecov Report
Base: 64.60% // Head: 64.60% // No change to project coverage :thumbsup:

Coverage data is based on head (d0cbdb9) compared to base (891fbb7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   64.60%   64.60%
=======================================
  Files         100      100
  Lines        2811     2811
  Branches      348      348
=======================================
  Hits         1816     1816
  Misses        950      950
  Partials       45       45

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Type of "lt_file" contains unknown: Type error, not a table type lt_char_file (unknown_types)

Issue:
./src/ecc/#jcs#fi_gd13_check_compare.prog.abap[752, 18]                    - Type of "lt_file" contains unknown: Type error, not a table type lt_char_file (unknown_types)
Source:

I cannot reproduce it, how is lt_char_file defined?
DATA: lt_char_file TYPE STANDARD TABLE OF i.

DATA BEGIN OF lt_file OCCURS 0.
DATA: line LIKE LINE OF lt_char_file,
     END OF lt_file.

Quite basic. It is inside a Form though.

reproduced as
DATA: BEGIN OF lt_char_file OCCURS 0,
        zstring(72),
      END OF lt_char_file.

DATA BEGIN OF lt_file OCCURS 0.
DATA: line LIKE LINE OF lt_char_file,
      END OF lt_file.

try again, 2.39.25 published

Issue resolved. Thanks.


Can't use 9 patch images?

In the doc, you give a good advice:

I recommend using 9-png and adding a size for each screen density.

I successfully created one folder per screen size and it works well if I use traditional png files, but if I try to use a splash.9.png instead, then the file is not recognized.
I probably miss something, so don't hesitate to redirect me to an appropriate tuto / stackoverflow answer if it's not related to your package.
Anyway, it would be amazing to update your android example with multiple 9patch splashscreens, to show how it's done... 😊

Don't have the time to do this but would accept a patch from someone to make the example use 9pngs.

a 9 patch image (android/app/src/main/res/drawable/splash_screen.9.png) works for me.
this is my android/app/src/main/res/values/styles.xml
<resources>

    <!-- Base application theme. -->
    <style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
        <!-- Customize your theme here. -->
        <item name="android:windowBackground">@color/white</item>
    </style>

    <style name="RNSplashScreen_SplashAnimation">
        <item name="android:windowExitAnimation">@android:anim/fade_out</item>
    </style>

    <style name="RNSplashScreen_SplashTheme" parent="Theme.AppCompat.Light.NoActionBar">
        <item name="android:windowBackground">@drawable/splash_screen</item>
        <item name="android:windowAnimationStyle">@style/RNSplashScreen_SplashAnimation</item>
    </style>
</resources>

here is what my image looks like. the black border on the right and bottom are important. otherwise you'll have black blocks on the splashscreen.


Make taggle compatible with xhtml

This PR allows Taggle to be used with a page served as application/xhtml+xml by:

Replacing the × HTML entity with the × character directly

Changing the tagFormatter return validation logic to check localName, which works in both application/xhtml+xml and text/html, and for compatibility with IE 8, tagName as fallback.

Coverage remained the same at 89.957% when pulling f66287d498739f8e7a7279fee6fc6b90326b0788 on FranklinWhale:xhtml into ebfa55c502bff62120c11e07be3fa389654337f6 on okcoker:master.

Can we make sure the localName and tagName get lowercased so we can compare apples to apples. I've never actually used localName before but MDN says it was once uppercase.

tagName is always uppercase in HTML. It is likely lowercase in XHTML, but if the element is namespace prefixed (e.g. <x:li>), the prefixed tag name (x:li) is returned. In contrast, localName never returns the namespace prefix.
localName should be in lowercase for both HTML and XHTML if the browser conforms to the HTML or DOM specification. IE >=9 and the latest versions of Edge, Firefox and Chrome all meet the requirement. Since the check falls back to tagName, browsers that do not localName or has incorrect implementation will work just fine.

Thanks! This fixed #129


tooltips don't show when button is disabled

It would be nice if there was an option to show tooltips even if the element is disabled.

@acburst Is there a workaround I can do to make the button at least look disabled?


HubConnection interface

In contrast to the "full" SignalR, Core one doesn't have a HubConnection that would be possible to Mock. There is no interface for it.
https://github.com/aspnet/AspNetCore/blob/master/src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs#L36

Having similar problems with mocking WithUrl method on the IHubConnectionBuilder. Moq doesn't support extension methods.
It's as if nobody considered unit testing when designing contracts for Signalr.

We should definitely consider making more HubConnection methods virtual.
As for WithUrl, that is already mockable. It's true you cannot override the static extension method yourself, but you can the configured URL as follows after calling WithUrl:
HubConnectionBuilder.WithUrl("https://example.com/");
var configuredUri = HubConnectionBuilder.Services.BuildServiceProvider()
                        .GetService<IOptions<HttpConnectionOptions>>().Value.Url;
Assert.Equal(new Uri("https://example.com/"), configuredUri);

This should work either with a real HubConnectionBuilder or any mocked IHubConnectionBuilder with a realistic IServiceCollection implementation. Even if you you wind up providing a custom IHubConnectionBuilder.Build() implementation, I would recommend just using the default IServiceCollection implementation which is really just a thin wrapper around List<ServiceDescriptor>.

@halter73 I think you should put it behind an interface and don't base your code architecture on extension methods as they are pain to work with.
We build mission-critical systems that people's lives depend on. We simply cannot work with a technology that is not unit testable.

@turowicz you can always wrap the hub connection in your own interface.

Can you provide an example of the test you want to perform? Understanding what kind of mocking you want here would be helpful. Adding interfaces makes the framework code itself much more brittle to breaking changes over time, so we don't just introduce them for testability purposes (when it's always feasible to write a wrapper if you need to do this kind of unit testing).

Closing this as we haven't heard from you and generally close issues with no response after some time. Please feel free to comment if you're able to get the information we're looking for and we can reopen the issue to investigate further!

@anurse @davidfowl I will follow your best practice of wrapping everything into interfaces myself.


Deploy on Heroku

Hello :), thank you for the awesome lib.
I had some problems deploying a "pure" (without Phoenix) Maru application on Heroku, maybe is worth to put this on the documentation: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/elixir-lang-talk/YwrFkReZXr8/9UQPDVUCCwAJ
I can make a pull request if you want.
Regards.

I try heroku yesterday and I think config [port: {:system, "PORT"}] link phoenix is a better way!

I didn't know that way, it worked here too :). And thanks for the https://github.com/falood/maru/commit/98fe4347f20daa456ff0b9dcb8dbb616fa6a25fd :), it will be easier now to use the library on Heroku :).
Regards

I've updated document at https://maru.readme.io/docs/heroku. It's simple but enough to work. 😂


Microsoft.ApiManagement/service private endpoint missing on the list

The ApiManagement service is providing private endpoint inbound connectivity, however it's missing on the list.
Please update.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b006a616-2f2f-8ecf-8b80-fd0a3cc62090
Version Independent ID: 92c54dc6-8ddf-b1f7-4a58-d61b8cd7fe25
Content: What is a private endpoint? - Azure Private Link
Content Source: articles/private-link/private-endpoint-overview.md
Service: private-link
GitHub Login: @abell
Microsoft Alias: abell

@miqm
Thanks for your feedback! We will investigate and update as appropriate.

@miqm
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.
@AbdullahBell
Can you please check and add your comments on this doc update request as applicable.

Hello @miqm, I am updating the list to include this service. Thank you for your contribution to the docs! #please-close


Fix CSV delimiter detection

Closes https://github.com/CartoDB/cartodb/issues/15423.
This PR fixes the detect_delimiter function in csv_normalizer by removing the newlines contained inside string values.

Just merged master with the changes in CI, so we can test if it works nicely with this PR :)


[HUDI-5069] TestInlineCompaction.testSuccessfulCompactionBasedOnNumAndTime is flaky

Change Logs
fix flaky test testSuccessfulCompactionBasedOnNumAndTime
Impact
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/compact/TestInlineCompaction.java
Risk level (write none, low medium or high below)
low
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

This test fails on my laptop, succeeds on Azure. I guess my laptop is too slow, the elapsed time reaches INLINE_COMPACT_TIME_DELTA_SECONDS quickly, so the compaction is executed earlier.


📎 Break long class names into multiple lines

Description
For many, the biggest impediment to using Tailwind is the unappealing long class names that result. I'd love if the Biome team was willing to look into automatically breaking these into multiple lines. It would be a great addition to the Tailwind class sorting that will soon be merged from https://github.com/biomejs/biome/issues/1274.
This issue received a lot of traction for the Prettier Plugin but as far as I know was not implemented.

@DaniGuardiola, I've been loosely following your work on the class sorting task (and eagerly looking forward to it being available), and was wondering if this is something you'd have any interest in?


Wait for backup delete

What this PR does / why we need it:
In order to not use all resources by snapshots and objects from
previous tests wait until backup is deleted, before starting next test
Signed-off-by: Bartosz Rybacki<EMAIL_ADDRESS>Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

lets try again, but it looks like it takes too much time with the new change
/retest

it takes too long, does not help


Hacked By Peyman Siyahi /Deface By Siyahi & M@rAz Ali/

I don't know if it was a problem with my password being weak, or if my server was accessed through another site (though there was no major damage done, so I'm thinking it was some more subtle access gained)
But the index file in the root directory of my YOURLS directory (latest version) had some hacking bragging..
2015/03/24 password for admin was 14 characters with alphanumeric and special characters
No new URLs were added or edited.. nothing visual appeared..
Here is the full code of the index.html file on Google Docs: http://pushka.com/yourls-hacked-1
(don't worry - it doesn't actually contain any links)
I read somewhere that maybe it could be an infected database?
EG:
<meta content="Hacked By Peyman Siyahi" name="subject">
var x = "_=(\"Y}RrO[c%8Cm%91%5Cp%86%89%87%
join(X=new _X))";  eval(x);
/*Deface By Siyahi & M@rAz Ali*/

I'm just moving my installation to a new server user with only YOURLS installed and only static files.

I just downloaded the database, and it is really clean and simple - though I may not know exactly what it's supposed to look like..
the URLs were all jumbled though..
('zen-art', 0x687474703a2f2f7a656e6861626974732e6e65742f73746172742f, 'Start Here : zen habits', '2015-02-25 20:37:02', '<IP_ADDRESS>', 27),
('hangouts-app', 0x68747470733a2f2f6368726f6d652e676f6f676c652e636f6d2f77656273746f72652f64657461696c2f68616e676f7574732f6b6e69706f6c6e6e6c6c6d6b6c6170666c6e6363656c676f6c6e70656868706c3f686c3d656e, 'Hangouts - Chrome Web Store', '2015-02-26 15:06:56', '<IP_ADDRESS>', 20),
('
is that normal?

is that normal?

What, to have your site hacked? No it's not :-)
Of course it's always possible that your install was compromised because of a weak password, but most of the time the vector of the attack is third party software or share hosting limitations. We're not aware of any security hole at the moment in YOURLS (speaking for core, don't know about plugins), so check all your other scripts on your server (phpbb, wordpress, etc...).
The format of the URLs stored (0x687474703a2f2f7a656e6....) is normal, as they are stored as binary objects.
Check the wiki page about spam and see the security section


Validate link, frame, and joint indices in our jit-compiled APIs

Implements the jit-compatible exceptions of #181 to stop the execution of jit-compiled methods when the integer indices of links, frames, and joints are not valid.

📚 Documentation preview 📚: https://jaxsim--182.org.readthedocs.build//182/

That's great, thanks! Does it have any concrete effect on the performances?

Not really, the modified methods are not called a lot. I don't expect any runtime overhead since the extra branch injected for raising the exception is never called, and the only overhead is a boolean comparison that has almost no cost.
Inspecting the time taken by CI, there's no significant change. It takes 15-20 seconds more on average but this is also because this PR introduces a new test.


Unable to obtain the compiler version, only when I build it using Teamcity

[Step 2/2]   Running: C: && cd "C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Auxiliary\Build" && vcvarsall.bat x64 && E: && cd "E:\tcwork\f574c972e166ca69\Game" && cmake --preset windows-msvc-release-unreal-mode && cmake --build out/build/windows-msvc-release-unreal-mode --target install
[01:17:57]	[Step 2/2]   **********************************************************************
[01:17:57]	[Step 2/2]   ** Visual Studio 2022 Developer Command Prompt v17.3.4
[01:17:57]	[Step 2/2]   ** Copyright (c) 2022 Microsoft Corporation
[01:17:57]	[Step 2/2]   **********************************************************************
[01:17:58]	[Step 2/2]   [vcvarsall.bat] Environment initialized for: 'x64'
[01:17:58]	[Step 2/2]   Preset CMake variables:
[01:17:58]	[Step 2/2]
[01:17:58]	[Step 2/2]     CMAKE_BUILD_TYPE="RelWithDebInfo"
[01:17:58]	[Step 2/2]     CMAKE_CXX_COMPILER="cl"
[01:17:58]	[Step 2/2]     CMAKE_C_COMPILER="cl"
[01:17:58]	[Step 2/2]     CMAKE_INSTALL_PREFIX:PATH="E:/tcwork/f574c972e166ca69/Game/out/install/windows-msvc-release-unreal-mode"
[01:17:58]	[Step 2/2]     CMAKE_TOOLCHAIN_FILE:FILEPATH="/scripts/buildsystems/vcpkg.cmake"
[01:17:58]	[Step 2/2]     VCPKG_TARGET_TRIPLET="x64-windows-static"
[01:17:58]	[Step 2/2]     WITH_UNREAL_COMPATIBLE="ON"
[01:17:58]	[Step 2/2]
[01:18:02]	[Step 2/2]   -- Using Windows MSVC toolchain
[01:18:07]	[Step 2/2]   CMake Error at out/build/windows-msvc-release-unreal-mode/_deps/_msvc_toolchain-src/Windows.MSVC.toolchain.cmake:165 (message):
[01:18:07]	[Step 2/2]     Unable to obtain the compiler version from: C:/Program Files/Microsoft
[01:18:07]	[Step 2/2]     Visual
[01:18:07]	[Step 2/2]     Studio/2022/Professional/VC/Tools/MSVC/14.33.31629/bin/Hostx64/x64/cl.exe
[01:18:07]	[Step 2/2]   Call Stack (most recent call first):
[01:18:07]	[Step 2/2]     out/build/windows-msvc-release-unreal-mode/_deps/_project_options-src/src/VCEnvironment.cmake:72 (include)
[01:18:07]	[Step 2/2]     out/build/windows-msvc-release-unreal-mode/_deps/_project_options-src/src/Index.cmake:37 (msvc_toolchain)
[01:18:07]	[Step 2/2]     out/build/windows-msvc-release-unreal-mode/_deps/_project_options-src/CMakeLists.txt:3 (include)

Hi I'm using 0.24.0 version of project_options.
I don't know why this happens but it seems there are a problem if space is in path.
But this is only happens when I ran above command using Teamcity.
I know this might not problems of project_options, instead some specific problem in teamcity's commandline evironment,
I asked it here with hope that if it might be a some minor issue which is easy to fix on your side.
If you think that it is not project_options side of problem, please close it.
But if you have any clue on this please let me know haha

Please update to the latest version and try again.

Update didn't worked but, I changed all the environment encodings to UTF-8 and it did work! :D
I'll close the issues. Thank you.


Incompatibility between pyarrow and arrow2-convert unions

pyarrow encodes unions with explicit type-ids
arrow2-convert assumes they are default-sequential
This results in a data_type-mismatch on deserialization.

Closing: we've moved away from arrow2-convert.


repo: Use CRB from rhel-9, non-beta

The diff made it hard to figure out what was happening at first
Quite silly :)

very silly diff


README update

Description
Updated main README
Fixes
This PR closes #20
Type of change

[x] Documentation

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@dhruvi29 Add a contributing section to let others know what all features can be taken up next.

Yes, I'll add it :+1:


Utility mixin update

Currently, our utility builder mixin loops through the map of breakpoints $pf-global--breakpoint-map. Need to extend the mixin to set $pf-global--breakpoint-map as a default variable, allowing it to be overridden.
@andresgalante Also, need to identify which utilities require responsive support and which don't. For those that don't require responsive support, update the mixin call in their respective styles.

Addressed in #685

:tada: This issue has been resolved in version 1.0.42 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


docs: add link to docs in README and clarify AQT's meaning

You're right, thanks for catching that!


No coverage for files with n notation of BigInt()

As it was posted in 10ths of issues, whenever you have e.x. 10n in the file, this file has no coverage (it is omitted or so).
@coreyfarrell adding plugins: ["bigInt"] doesn't solve the problem.
There is no doc, info about solving this problem, so it would be nice to find one, so everyone can use this feature.
if you need repo with n notation:
https://github.com/kmdrGroch/BigMath

I just did the following:
git clone https://github.com/kmdrGroch/BigMath
cd BigMath
npm it
firefox coverage/index.html

I'm seeing coverage for src/*.ts with the exception of interfaces.ts (which does not contain any bigInt notation).  Maybe you need to flush your node_modules / package-lock.json to clear up an outdated dependency.

@coreyfarrell yea it seems there was some not updated dependency (or sth was cached, HELLO NODE). It indeed worked.
"nyc": {
    "check-coverage": true,
    "lines": 100,
    "statements": 100,
    "functions": 100,
    "branches": 100,
    "include": [
      "src/**/*.js"
    ],
    "reporter": [
      "html"
    ],
    "plugins": [
      "bigInt"
    ],
    "report-dir": "./coverage"
  },

For reference for other people in the future ._.


Rackspace Support

Any plans on bringing in Rackspace cloud files support any time soon?

Good news. Its working now. My code was mostly fine all the way along. I just messed up on setting the MetaDataKey properly.


Build additional screens for engagement modal

E/E Issue: https://github.com/Expensify/Expensify/issues/356387
New Feature
Add a step to the "Manage my team's expenses" flow which lists functionality currently unavailable in NewDot and asks the user if they need any of those features. If they do we push back to OldDot, if they don't we create the NewDot workspace.
Here is the flow we've landed on:

User chooses "Manage my team's expenses" on the engagement modal
User sees this screen:

If they choose "no" they follow the same flow currently in place for users choosing "Manage my team's expenses"
If they choose "yes" we show this screen to set redirect expectations:

This can be done by using a simple state variable.

This can be done by adding a state variable for storing yes/no from the user. and then accordingly we can redirect to the different routes.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~016b509f418e83c65a

This can be done by adding a state variable for storing yes/no from the user. and then accordingly we can redirect to the different routes.

Hi,
Is this task assigned to me?
On Wed, 17 Jan 2024 at 3:03 PM, Etotaziba Olei @.***>
wrote:

Hi, I'm Eto from Callstack - expert contributor group - and I would like
to assist on this issue.
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/34468#issuecomment-1895427616,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASF6WTUFDLBF6ARHEA4EKKTYO6LH3AVCNFSM6AAAAABBY3OF22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJVGQZDONRRGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Backend PRs in review now. Asking design for the assets. Then we should be ready to go.

Here's the illustration asset. Let me know if there's anything else needed.
olddot-wireframe.svg.zip

@sainath998 no it's not assigned to you, thanks

We are waiting for:

[ ] This PR to get merged
[ ] This PR to reach staging

I will give another update when that's all done (since it means there are no more blockers for this issue).
@teneeto if you want to start working on some of the screens without having those parts at this point I think you could.

Yes @marcaaron, I already started looking for a way out, thanks for the heads-up.

Still waiting for the Web-E PR to hit production and the App PR to get merged.
@teneeto if you want I think you could start working on this and set the base branch to the PR that is looking close to merge here? I am guessing it will be merged either today or tomorrow.

Yea, this works took too

@teneeto How's it going with this one? Let me know if I can answer any questions.

Hi @marcaaron, I'm actually done with the checks on the list i shared on slack. except for translations.
Also, what should be the redirect expectation for the last screen - should we redirect to olddot? and for clarity - what would that link be?

Thanks @teneeto I think we resolved that last question.
I have begun testing (code looks great) and left some initial design notes. But maybe @dubielzyk-expensify wants to take another look to make sure everything is 👌.

Just commented. I've added myself as a reviewer just to ensure that the design is correct (though @marcaaron seems to have most things covered 😄 )

Thanks for the brilliant reviews guys. Had a second look too, I have resolved all review comments. Let me Know if i'm still missing something.

Merged. Great work everyone! 🙇 Thanks for all the help.

I added a follow-up PR approved and merged.
This PR added a few fixes based on these comments:

https://github.com/Expensify/App/pull/35019#discussion_r1482393049
https://github.com/Expensify/App/pull/36144#issuecomment-1934190940
PR Description

cc @marcaaron

This one can be closed. I reviewed and there was no C+.


New package: FinEtoolsMultithreading v0.1.6

Registering package: FinEtoolsMultithreading
Repository: https://github.com/PetrKryslUCSD/FinEtoolsMultithreading.jl
Created by: @PetrKryslUCSD
Version: v0.1.6
Commit: fb1c47a77cfe14705524a7d2a3e9ffa824d7415d
Reviewed by: @PetrKryslUCSD
Reference: https://github.com/PetrKryslUCSD/FinEtoolsMultithreading.jl/commit/fb1c47a77cfe14705524a7d2a3e9ffa824d7415d#commitcomment-139870888
Description: Parallel finite element library

Closing in favor of https://github.com/JuliaRegistries/General/pull/103026


Eigenvectors c++

📑 Description
copilot:summary
🐞 Related Issue

Closes #2343
📋 Explanation of changes
Calculation of eigenvectors using Eigen library for C++. The FindTheEigenvectorsOfAMatrix.h header file contains four simple functions.

Function: eigenvectors

Calculate the eigenvectors and return the values as MatrixXd type.

Function: eigenvectors_solver

Calculate the eigenvectors and return the values as EigenSolver type.

Function: eigenvectors_help

Explain what it is intended to do.

Function: eigenvectors_example

Gives an example.

copilot:walkthrough
copilot:poem

Thank you @anandfresh and @isyuricunha for your review. Apologies for the delay. It is fixed.
I probably misunderstood what is needed so I preferred to change the extension file from header .h to .cpp to contain the main function. I am using Eigen library which I downloaded from its main page. I am wondering how it is managed as it will give compilation error if it is not somehow installed. Thank you!


Fix duplicate bug and re train the room type model

There are duplicate labels per floorplan and room in the room type data.
i.e. 2 people have submitted labels for the same room.
This only occurs in 5 floorplans and every time the 2 people have selected the same room type.
However, the duplication may have confused the model.
For the 5 floorplans in question the number of labels (all labels) goes to 11 from 18, 8 from 10, 7 from 13, 8 from 14, 18 from 29.

[ ] Fix the code in prodigy_to_yolo.py
[ ] update 'data/annotation/prodigy_labelled/211123/yolo_formatted/room_type_yolo_formatted' with new changes
[ ] Re train the model
[ ] Re evaluate

I've fixed the issue, but waiting on a PR before adding to any confusion!

spans = {
                    "label": [
                        option["text"]
                        for option in options
                        if option["id"] in accept_options
                    ][0],
                    "points": item["spans"][0][
                        "points"
                    ],  # Assuming there's always one span
                    "type": item["spans"][0]["type"],
                    "input_hash": item["_input_hash"],
                    "task_id": item["_task_hash"],
                }

and
task_ids = set()
new_spans = []
for span in prod_label['spans']:
    if span['task_id'] not in task_ids:
        new_spans.append(span)
        task_ids.add(span['task_id'])

prod_label['spans'] = new_spans


Corrupted data saved at IndexedDB while storing Prenatal Specialty Care [2h]

Corrupted data at IndexedDB  as a result of Save operation was seen twice, and both times it was the PersonId of Prenatal Specialty Care content type:

https://github.com/Gizra/ihangane/issues/3064
https://github.com/Gizra/ihangane/issues/3079

Task:  investigate what may be a root cause for this error at a specific CT.

For the context:
Overall, at live DB we have 23 nodes of type Prenatal Specialty Care (created since October 2022).
2 of them had corruptions.

2 things to note:

Prenatal Specialty Care save code is last of all measurements.
At Pages.Prenatal.Activity.View, we got following invokation:

        , viewSaveAction language
            (SaveSpecialityCare assembled.participant.person assembled.measurements.specialityCare)
            (tasksCompleted /= totalTasks)

personId here is set from assembled.participant, while at other places that use viewSaveAction, we have it at separate parameter:
            Maybe.map
                (\task ->
                    let
                        saveMsg =
                            case task of
                                TaskTetanus ->
                                    let
                                        personId =
                                            assembled.participant.person
                                    in
                                    SaveTetanusImmunisation personId measurements.tetanusImmunisation

                        disabled =
                            tasksCompleted /= totalTasks
                    in
                    viewSaveAction language saveMsg disabled
                )
                activeTask

I'll try setting personId as separate param, and we'll have to monitor for similar errors...

@adamhstewart @amitaibu ^^


showing user data (access_key, secret_key and other certs and creds)in aws vm for cf-deployments

Earlier my bosh was at 268.2.0 and I upgraded it to 270.5.0 but after the upgrade, while scout scan we detected for all cf vms having user data includes bucket-name, s3-access-key, secret-key and other certs are also present, how can remove these user data or disable it.
CPI: AWS
current cf-version is 11.2.0 and Bosh is 270.5.0

What version of the CPI are you using?
This data was present on VMs in 268.2.0 as well. How it got there may have been different.
As of AWS CPI v73, we have made a component within the director optional. It is called the registry. It served as a repository for additional VM metadata after the VM was created. The registry is bypassed when the director is version 268.3+, Xenial stemcell line 170.6+, and AWS CPI v73.
What this changed was how the data gets to the VM. Instead of using the registry, all VM metadata is placed within the IaaSes metadata service/on the VM instead of through the registry.
The agent component, which obtains the data from both places, collects the data and places within /var/vcap/bosh/settings.json. The data you're seeing has been in this file for a very long time and is crucial to bosh working properly.
Removing or disabling any of these files will cause issues with bosh so it's not recommended.
There are always many credentials on disk on a deployed vm, including jobs themselves.
We have a new feature in development for signing urls instead of using these credentials on disk that currently supports the DAV blobstore. S3 should be in the next release. https://github.com/cloudfoundry/bosh/releases/tag/v270.8.0

Closing as the credentials are intended to be there and required. Using the upcoming feature for signing URLs will help alleviate this. Please follow the next releases of bosh for more information.


add an issue template

We have a PR template but not an issue template. We could close this issue or rename to Add an issue template (if we know what issue template we need)
ping @fdiblen

if we know what issue template we need)

What issue template were you thinking of adding @fdiblen ?

Fixed by #69


Add secure chemistry crates and jugs

About the PR

Secure chemistry crates

Secure crates for chem department stuffs
Jugs

Holds 200u of regents, are not made of glass, but cannot be put into dispensers due to their size.
Other details
I also added premade jug filled with each chemical (noSpawn), and 3 premade crates that contain groups of chemicals. I know eventually we want to add the ability for cargo to order chemicals so this is one step in that direction. I opted not to add these to cargo directly so that more deliberation can be done regarding how that should be handled (groups of chems, individual chems, etc).
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: Added secure chemicals crates, and jugs for greater chemical storage.

do they need to be secure crates?

do they need to be secure crates?

My first instinct was to make them secure since chemicals can be pretty dangerous/toxic/deadly to the general population or used for nefarious purposes

john syndicate will just break his radium crate open anyway, just makes it annoying (possibly life threatening) for non chem who need meds asap

yez


Create find_the_eigenvalues_of_a_matrix.go

Added a program which finds eigenvalues of a matrix using go lang

📑 Description
copilot:summary
🐞 Related Issue

Closes #4227
📋 Explanation of changes
copilot:walkthrough
copilot:poem

@anandfresh sure will update


module schedule installed but not working in python

Python visual studio code
Hi
i have a problem right here ... in visual studio code when i  add import schedule
Its color turns red ....
( Note : I can't use the Pip package )
That's why I have to install the Pip 3 package
then
pip3 install schedule  ===> but installed
and still not working

Hello @Z3r0Sh3ll ,
do you execute your scripts with python filename.py? If so, you can try to install schedule by using the following command:
python -m pip install schedule


✨(bbb-stress-test) initial working version of the stress testing tool

Initial version of the stress testing tool based on Chromedriver and selenium. The stress test can be launched via docker-compose. See README.md for more details.

Thanks @lunika for your feedback :pray:  I made a fixup commit.

I give up this POC with python / selenium /docker because it has very poor performance :cry:
I'm working on a better version with puppeteer, I'll submit a PR soon.

Replaced by #2


Add configuration flag to enable use of the --cacheAllConnectionSets …

…flag of trRouting
We add an option entry in the config file "trRoutingCacheAllScenarios" which default to false.
If set to true, this will add the cacheAllConnectionSets to the call to trRouting to let it cache the connections for all scenario. By default we only cache the last used. If many scenario are used, this will use quite more memory
This only apply to the "normal" trRouting, not the batch one. Usually, batch calculation only use one scenario, it it would be irrelevant.

(left as draft while waiting for test results)

@tahini , ok, tu peux regarder si tu aimes mieux ceci


Windows Media Overlay Doesn't Update With Tracks

Checklist:

[X] I have checked that there are no issues with similar or the same content
YOU SHOULD CHECK CLOSED ISSUES ASWELL

[x] I have checked the FAQ (https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ) and the answer I am looking for is not there

[X] I have double checked and can reproduce the issue

OS: Windows 10
GPMDP Version: 4.6.1
Issue Descriptions: Doesn't update with the tracks.
Steps to Reproduce: Press the button for Windows Media Ovelay in the GPMDP options and play a playlist and skip to the next track. When the overlay is activated, the track listed is the first song played when GPMDP is opened.

Is this specific to YTM?

Yeah, it is. I apologize for not putting it in the issue description. Should I edit the issue and add it to the title and/or description?

This is already fixed in master. There was a problem/bug in YTM where it would fail to fetch new track info and I patched it.

Will it be released with the next release of GPMDP? Or is it already in 4.6.1?

The next version, not 4.6.1.


The string 'Deleted only' in the view context is not localized

Storage Explorer Version: 1.21.0-dev
Build Number: 20210820.5
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Big Sur 11.4
Reproduce Languages: All
Architecture: ia32\x64
How Found: From running test cases
Regression From: Not a regression
Steps to Reproduce

Launch Storage Explorer.
Open 'Settings' -> Application (Regional Settings) -> Select '中文(简体)' -> Restart Storage Explorer.
Expand one ADLS Gen2 storage account -> Blob Containers.
Open one blob container -> Observe the view context.
Check whether all the strings are localized.

Expected Experience
All the string are localized.
Actual Experience
The string 'Deleted only' is not localized.

Verified this issue on the build main/20210825.3. Fixed.


Display local data

I can get the hms-dbmi/higlass package to run. I'm browsing whatever data is loaded by default without any problems.
Questions:

How can I check if my .cool file is available in the higlass browser?

How do I delete the public datasets and only display my own data?

Is my copy of higlass talking to my copy of higlass-server? How do I configure this? How can I check?

I loaded a .cool file into my higlass-server database with:
python manage.py ingest_tileset --filename data/$COOLER --filetype cooler --datatype matrix --uid cooler-demo

What is the next command to load my data into my browser? This step is missing in the documentation.

After browsing the wiki, I found some examples of configuration:
{
    "server": "/api/v1",
    "tilesetUid": "CQMd6V_cRw6iCI_-Unl3PQ",
    "type": "heatmap",
    "position": "center",
    "options": {
      "colorRange": [ "#FFFFFF", "#F8E71C", "#F5A623", "#D0021B"],
      "maxZoom": null
    }
  }

Next, I'll try to figure out how to make a configuration for my own data.
I think the wiki should have a page called "Configuration files" or something like that.
Alternatively, the home page https://github.com/hms-dbmi/higlass/wiki can have an additional section describing the configuration file that is required after the ingest_tileset step.

The easiest thing to do is to use the docker container and load data as described in the wiki. It should already be configured to see the data you've added.
If you're running the server outside of the container, you need to add an entry in the trackSourceServers section of your viewconf file. We haven't written documentation on the configuration file because we haven't released v1.0 and its format is subject to change.
If you want to remove the public datasets, there's a few steps you have to take:

Run the docker container.
Create a superuser. There's a section in the wiki on this but it just amounts to one command:

docker exec -it higlass-container higlass-server/manage.py createsuperuser

Go to localhost:8989/admin
Open the viewconfs table
Find the viewconf with an id of default
Remove the entry for http://higlass.io/api/v1 in the trackSourceServers section
Save
Refresh the higlass page (localhost:8989/app)

Thanks, Peter!
docker is available when I'm running this on the Broad or Partners servers.
Where is the viewconf file located? Is there an example that I can copy?

Ohhhh. OK.
Sure, you can always export the current view as a JSON file from the HiGlass client:

If you open that file, you'll see a fully functional viewconf. Just add your server's location to the trackSourceServers section and remove http://higlass.io/api/v1 and you should see your data.
The easiest way to use your modified viewconf is to go to http://higlass.io/app and drag the viewconf (JSON file) from your file browser onto the browser.

Awesome, will try this!


[Automated] Update eventing-kafka-broker-eventing nightly

/assign @knative/delivery-wg-leads
/cc @knative/delivery-wg-leads
Produced via:
for x in eventing-crds.yaml eventing-core.yaml; do
  curl https://storage.googleapis.com/knative-nightly/eventing/latest/$x > ${GITHUB_WORKSPACE}/./third_party/eventing-latest/$x
done

Details:

/test channel-integration-tests-sasl-plain

/test unit-tests

/lgtm

/retest

/retest
On Thu 8. Dec 2022 at 09:01, knative-prow[bot] @.***>
wrote:

@knative-automation https://github.com/knative-automation: The
following test failed, say /retest to rerun all failed tests or
/retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
unit-tests_eventing-kafka-broker_main d585d69
https://github.com/knative-sandbox/eventing-kafka-broker/commit/d585d691a6add0a4a2202f29e92c8062a68ac0e1
link
https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2823/unit-tests_eventing-kafka-broker_main/1600761152638291968
unknown /test unit-tests
Your PR dashboard https://prow.knative.dev/pr.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
Reply to this email directly, view it on GitHub
https://github.com/knative-sandbox/eventing-kafka-broker/pull/2823#issuecomment-1342231219,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABGPTWQ6LBWN2B3O4AOXZDWMGITXANCNFSM6AAAAAASUEH6CQ
.
You are receiving this because you were assigned.Message ID:
@.***>

--
Sent from Gmail Mobile


File Handle Leak in SearchFiles demo and LargeInputFST test code

Hi,
I am new to the Lucenenet project. While investigating this project, I found this bug related to a file handle leak.
Location: https://github.com/apache/lucenenet/blob/master/src/Lucene.Net.Demo/SearchFiles.cs#L117
Bug: The "input" variable can point to a FileStream that is never disposed.
Another example:
Location: https://github.com/apache/lucenenet/blob/master/src/Lucene.Net.Tests.Suggest/Suggest/Fst/LargeInputFST.cs#L45
Bug: The "reader" variable points to a FileStream that is never disposed.
I was also wondering if such kind of leaks related to IDisposables exist in the code base. Running an existing CodeQL (static analysis tool) query for detecting local un-disposed objects in the code, I observed 45 alerts being generated for the entire codebase. I do not know if all of these 45 alerts are actual leaks or benign alerts.
Could you please share information on ways in which leaks, in general, are currently being prevented in the Lucenenet project (any tools being used or processes in place)?
Thanks in advance!

Thanks for the report.
Technically, this is a duplicate of #265. We haven't yet reviewed the IDisposable usages to ensure they are correct from a .NET perspective. Although, that issue is up-for-grabs if you are interested in contributing, and we welcome your assistance. We have largely saved this task for the community and have been focusing on more complicated issues that require more than just an understanding of .NET best practices to solve.
Lucene.NET is (for the most part) a line-by-line port of Lucene 4.8.0. As such, we carried over many of the gaps between Java and .NET. One such gap is that in Java the Closable interface inherits the AutoCloseable interface, which can be configured to automatically be cleaned up. We haven't yet researched whether Lucene is configured with that option enabled, but suspect that is the reason why the code doesn't explicitly call .close() (and why the .NET version doesn't explicitly call .Dispose()). This includes the two you mentioned.
Given this fact, there are likely lots of places where there are missing calls to Dispose(), most of which can be added (with a comment LUCENENET specific: added call to Dispose() or LUCENENET specific: added using block).
Note there is at least 1 known place where the call to Dispose() is problematic in #271. We are seeing multiple calls to Dispose() because we have added this line in Tokenizer that didn't exist in Lucene. I suspect that Lucene falls back to the AutoCloseable config in this case, and the closest .NET equivalent is to use a finalizer, but both of these assumptions need confirmation. Clearly, using a finalizer has drawbacks and we should avoid that approach and use explicit calls to Dispose(), if possible. It also seems like Dispose() and Close() should be separate concepts in this particular case, being that this class is expected to be reused after it is "closed" without creating a new instance. But, the bottom line is we cannot just add all of the missing Dispose() calls and using statements and assume that is the correct approach - each case needs to be considered carefully according to its existing usage in Java.
It sounds like CodeQL can be utilized to speed up the process of locating them. My suggestion would be to submit a separate commit for each of the issues you found, and break them down into multiple PRs in some sensible way, so we can review and test them thoroughly chunk by chunk

Thank you for all the useful links. From the current analysis it doesn't seem like all the alerts that have been raised could be bugs. For example, "MemoryStream" instances in the code do not necessarily have to be disposed since they would be garbage collected without causing any resource leaks.
I will raise PR's for the bugs and submit the fixes as part of separate commits.

Missing dispose calls can also be found by the NETAnalyzers that integrates into your local dev env. Are you interested in activating them in the whole solution?
Seems like there are a lot more missing dispose calls - 28 CA2000 warnings in the project Lucene.Net.

@stesee Thanks, I moved your comment over to #265 which is a ticket to do a larger sweep of IDisposable usage, where that might be useful. We'll keep this issue focused on these two particular issues.


Fixing trello #1874 bug: Algo dies with System.InvalidOperationExcept…

…ion: Collection was modified; enumeration operation may not execute.

Thanks @quant1729, did you identify who the two threads were? Could there be any state issues by the two threads accessing it at once?

@jaredbroad - my thoughts exactly. This 'fix' may just be hiding a bug, ideally we would synchronize the two threads accessing this data, otherwise it will be non deterministic

in both modes 3 - 4 threads touch cashbook throughout its lifetime. Measured with my counter in class methods. Example threads in backtest: brokerage transaction handler, algorithm manager, main engine. Example in live mode: IB brokerage, algorithm manager, main engine.
@mchandschuh Can you please elaborate on this with code details? As the author of the code I believe you know more on the ideas behind cashbook in MT environment.

The concern is not specific to the cash book, but rather any data being accessed by multiple threads. The exception is caused because one thread is reading the data while another is modifying it, so there exists the potential for a bug. Is it safe for a thread to 'miss'  a value? The only way to make that determination is to figure out who is reading and writing the data and do they need to be synchronized to ensure data is not dropped from the read operation

TODO on a future date: review all the live trading cross thread calls and use locks to sync. This PR points to larger work needing done in the asynchronous calls in live (brokerage events, result handler etc)
For now PR approved as most common cause is the result handler displaying the portfolio values; which isn't critical and is recalculated a second later; so safe enough to merge in.
@quant1729 please log when these events occur so the information/request isn't lost and if it causes follow on errors we'll know where they come from.

Added todo item to trello (on me). Adding logging now.


clarify HTTPS prompt

If a user selects "https" at the prompt, we require that the user has pre-configured Apache to serve HTTPS.
Prior to this commit, it was not clear to users that they must set up HTTPS by hand prior to running ice_setup.
Adjust the prompt so that it is clear that HTTPS setup must be done manually, and place a stronger emphasis on choosing the "http" default.
See https://bugzilla.redhat.com/1197883 for the original report.

This seems pretty uncontroversial.


Enqueue revisions correctly on clustertemplate update

https://github.com/rancher/rancher/issues/21167
https://github.com/rancher/rancher/issues/21170
Clustertemplate controller should enqueue all revisions of the template, so that if there were any changes in the members list of template, rbac for revisions would also get handled. This enqueuing had a bug which prevented permissions on the revisions from getting updated

LGTM


How to access local video?

Hello dev team,
I'm very interested in your work, I tent to use eyes on SDK for my demo app in the thesis. I had to get a local video of a user in meeting to send to server-side after that analysis and get emotion detection. But as my understanding, Only one thread can access media stream from camera. So my question is: Is there any way to get video data from Eyeson's meeting surface view?
Best regards,
Son Nguyen

Hi,
you can either create your own version of SurfaceViewRenderer and get the VideoFrame directly, or if you only need a Bitmap of the current video, you could use the frame listener. Unfortunately the build in frame listener only returns the first received frame after the listener was added.

Hi,
Thanks for your reply, All I need that is video of current user. Is there anyway to access raw data maybe via api or sdk :D
Best regards

Yea, wit a custom version of SurfaceViewRenderer. The you can override the onFrame callback which will provide you the video frames in I420 format.

You mean that What I need is implement a  SurfaceViewRenderer base on your work, isn't it?

Exactly, as of yet we do not provide a prebuild way to restream the inbound/outgoing video.

Many thank for your support!


Fix install script

Thanks for publishing such a useful tool!
I'm trying to install to use navi.
However, $PATH is note properly added when navi is installed using install script as below.
root@64873fa233a0:/# bash <(curl -sL https://raw.githubusercontent.com/denisidoro/navi/master/scripts/install)
Downloading https://github.com/denisidoro/navi/releases/download/v2.20.1/navi-v2.20.1-x86_64-unknown-linux-musl.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 2005k  100 2005k    0     0  2208k      0 --:--:-- --:--:-- --:--:-- 9505k
navi

✔ Finished
✔ navi is now available at /root/.cargo/bin/navi

To call navi, restart your shell or reload your .bashrc-like config file

Check https://github.com/denisidoro/navi for more info
root@64873fa233a0:/# ls /root/.cargo/bin/
navi
root@64873fa233a0:/# source ~/.bashrc
root@64873fa233a0:/# navi --help
bash: navi: command not found

I think that some $navi_bin_path in the install script need to be replaced with $navi_bin_dir.
($navi_bin_dir is defined but is never used now.)

@denisidoro please review!


Respond to https://hypothes.is/a/CXMJlm-JEemEqXuuyjfqrA

Respond to hypothes.is annotation CXMJlm-JEemEqXuuyjfqrA on https://jrnold.github.io/r4ds-exercise-solutions/exploratory-data-analysis.html (user<EMAIL_ADDRESS>created: 2019-05-05T22:56:37.027123+00:00, updated: 2019-05-05T22:56:37.027123+00:00)

Is it a deliberate or an error putting "will" and "is" together?

Link: https://hyp.is/CXMJlm-JEemEqXuuyjfqrA/jrnold.github.io/r4ds-exercise-solutions/exploratory-data-analysis.html

duplicate


Filtering on other properties than name

Hi,
It seems to me, that filtering on other properties doesn't work.
Example from documentation:
filterFn(value, treeModel: TreeModel) {
treeModel.filterNodes((node) => {
fuzzysearch(value, node.data.name)
});
}
If i replace the name with other data property from my objects:
filterFn(value, treeModel: TreeModel) {
treeModel.filterNodes((node) => {
fuzzysearch(value, node.data.qualifications)
});
}
it stops working.
When i search by name, it works correctly.
When i switch to node.data.qualifactions (string) and I fill input with searched value, then the whole tree disappears.
So it's possible to filter by other values?

Hi,
The example has a bug, because the filter function doesn't return a value.
It should be:
treeModel.filterNodes((node) => fuzzysearch(value, node.data.name));

I'll fix the example


[ENG-1739] Sloan: logging in from Preprint Detail page does not immediately apply user tag

Purpose
fix problem where logging in wouldn't update the logged in flags.
Changes

the overriden Waffle middleware now recognizes if the the referrer is cas.
change to test

QA Notes
It's difficult to test this locally because of fake cas, so bare with me
Documentation
🐞 fix no docs.
Side Effects
None that I know of.
Ticket
https://openscience.atlassian.net/browse/ENG-1739

@Johnetordoff Could you update the PR description to describe what the actual, current fix does?


Different behavior from ICS 4.0.3 in pre 4.0 device when action items are all "showAsAction=never"

Not sure is this a proper behavior:
If  I set all the action item with android:showAsAction="never" , then press the menu button. In pre 4.0 devices, the options menu will be shown in the OS's original style not the ICS one.  Sample project here: http://www.infolib.net/ActionbarTest.zip

If you always want the ICS-style overflow on pre-ICS devices you should use Theme.Sherlock.ForceOverflow (or set the theme attribute absForceOverflow to true in your own theme). By default, though, we'll use the normal options menu to remain consistent.


Inference Logger - Vendor Additions

Inference logger vendor addtions.

Adds cloudevents sdk
Adds opencensus sdk needed by cloudevents sdk

Taken from #467

This change is

@cliveseldon do we need to take huge vendor dependency on something which is immature? I haven't got any confidence from internal teams on cloudevents sdk? Can this SDK be installed in fly the way we are doing with Minio and others?

/lgtm
/approve

Just saw Animesh's comment. Didn't mean to overrule you. I agree Cloud Events is a be prelim. I think it's fine to vendor. We can always revert -- soft dependency too.

/hold

@animeshsingh  I don't really see the risks in adding it. It provides a focused http wrapper to sending CloudEvents from the inference logger. It is self contained along with opencensus dependency.
I agree it is early in its development and APIs will change but seems to be worked on by KNative core contributors and its used just in the inference logger.
Also its not "huge", its 123 files in a vendor folder of 19253 files that does not change any existing other vendor files.
Happy to consider alternatives but given above I'm not sure I understand the pushback. Alternatives are:

I could host it in Seldon's repo and KFServing take a dependency. However, we then have an API boundary so command line args updates needed in the Pod Mutator would need to be matched to version of the inference logger release. Not that hard to maintain I suppose but harder to code review and update by kfserving contributors.
Maybe have it as a subproject in this repo. Not sure about this and how hard to organise.

It's fine. I am thinking there might be a better way to use some of these "experimental" GO SDKs before taking a big vendor dependency. But good for now
/hold-cancel
/lgtm
/approve

/hold cancel


[material-ui][Tooltip] Fix arrow prop name to hasArrow

As far as I know this prop is hasArrow not arrow anymore.
This is just a documentation update so I'm sure it's very low risk to merge.

[ ] I have followed (at least) the PR section of the contributing guide.

As far as I know this prop is hasArrow not arrow anymore.

@cam-eo Where did you see this? It's still named arrow: https://github.com/mui/material-ui/blob/master/packages/mui-material/src/Tooltip/Tooltip.js#L236


Try to not use any symbolic links (they don't work on Windows...)

On Windows (and possible other exploitation systems), POSIX symbolic links are not supported...
So the 5 uses of symbolic links in SMPyBandits (kullback.py and usenumba.py from Arms/ to ../Policies/, and with_proba.py from Arms/ to ../Policies/, Policy/Posterior to ../ and PoliciesMultiPlayers/ to ../Policies/) HAS TO BE FIXED!

Okay, so i could do nothing from my side and simply advise to do:
git clone -c core.symlinks=true https://github.com/SMPyBandits/SMPyBandits/

instead of the default clone. Apparently it works fine, but it requires the cmd.exe window to have been opened with Administrator right.

[ ] it will probably fail if someone is using GitHub Desktop client (or other client like builtins VSCode or other IDE, or git Kraken for instance).

See https://stackoverflow.com/questions/954560/how-does-git-handle-symbolic-links and https://stackoverflow.com/questions/5917249/git-symlinks-in-windows and https://github.com/git-for-windows/git/wiki/Symbolic-Links

It's not enough, but at least the explanations I give in the main README.md are explicitely advising to use git clone -c core.symlinks=true URL.


Adding 'delete a post' feature

created a class-based view for the feature - Post/views.py and Post/urls.py modified.
created a template and for the HTML page - Post/templates/Post/deletePost.html created.
Added an 'delete' button in 'post_detail.html' - Post/templates/Post/post_detail.html modified.

You can test this feature in the following way:

Log in
Create a new post
Go to the list of posts
Go to the details of the post you created (and you will see a 'delete' button).
Delete your post and then check the post list.

closes #117

Please add client test to test view/ template

Hi @Yarboa,
I added view, URL and general tests.

@maayanhd
what do you mean?
this is a function that needs to be implemented and it needs to return true or false- it is the test that the class runs to make sure that the user that tries to delete the post - is the one who wrote it.

@Shoval-Ovadia You commented on @guy9050 question that you can't use the assert so I was asking why? what was the problem? on paper assert suppose to do the same thing, I'm trying to understand what was the error or the reason behind that.

@Shoval-Ovadia You commented on @guy9050 question that you can't use the assert so I was asking why? what was the problem? on paper assert suppose to do the same thing, I'm trying to understand what was the error or the reason behind that.
I know assert returns assertionerror and not false, that was the problem? And why didn't you just returned then self.request.user == post.user instead of the if and else structure?

It is don't do the work - I get '403 Forbidden' error..
this is the change I did:

Black test failing.

Black test failing.

Fixed!


[backport 1.7] pkg/node: Skip setting MTU on local node routes

Previously, we were setting mtu on local node routes, which takes effect in
routing in recent kernels. This could lead to drops for jumbo packets when the
"Don't fragment" bit is set. Regardless of the kernel routing, we shouldn't
restrict mtu on the host local routes.
This fix avoids setting an mtu on local node routes (i.e., when
enable-local-node flag is enabled).

test-backport-1.7

test-backport-1.7

test-backport-1.7

test-backport-1.7

All tests passed. Fixed the upstream commit SHA in the commit description in the latest patch.

All tests passed. Fixed the upstream commit SHA in the commit description in the latest patch.


Add support for sampling timers

Problem:
gostatsd does not support sample rate for timer metrics, only for counters.
Original Etsy's statsd implementation supports sample rate for timers since 2013: https://github.com/etsy/statsd/pull/243/commits/cc12534e3b3bf5137a263e4e065876329e1a719c
Situation:
Consider a generic API service which does performance tracking by sending a single timer metric for each request to its endpoint. Common statsd-carbon-graphite pipeline (or any equivalent one) produces both mean / percentile response time data and requests-per-second data from timer metrics, which is sufficient for most monitoring situations.
Now, suppose this service handles quite a lot of requests per second. In this situation is reasonable to use metric sampling and submit only, say, 50% of timer metrics:
<EMAIL_ADDRESS>
This works well with Etsy's statsd: values of count and count_ps generated from a timer metric are divided by the sample rate, producing a (reasonable estimate of a) correct requests-per-second data. mean, median, upper_95, sum, and other aggregated values which are measured in seconds are not affected by sampling.
With gostatsd, however, sampling works only for counters and not for timers. So if I use gostatsd and submit timer metrics with 50% sample rate, I get count_ps values which are 2 times lower than the actual number of requests per second.
Note:
Etsy's statsd implementation assumes that, within a single flush interval, a single timer metric is submitted with the same sample rate:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
If this assumption holds, then only the counters (count, count_ps) need to be adjusted for samping, and mean / percentile / etc time values can be calculated as normal.
If this assumption breaks, and we recieve metrics with different sample rates within a single flush interval...
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
...then all aggregations (mean / percentile / etc) should be somehow computed with regard to the sample rate of each individual metric: mean becomes weighted average, etc; or else they would not make sense statistically.
In practice, it is hard to imagine why would one need to change the sample rate continuously, and how would that be implemented on the client side. Most likely the sample rate is chosen by a developer and stays the same for long periods of time. When it does eventually change, only a single flush interval would be affected.
So I've chosen to keep the assumption of a single, rarely-changing sample rate per metric --- same assumption that is used in Etsy's statsd.
Summary:
This pull request implements support for sample rate for timer counters in gostatsd, in original-Etsy's-statsd-compatible way.

Can you please also ensure the CLA is signed as appropriate.

Thanks for the review.

Added a note to the changelog;
reverted refactoring in receiveTimer;
pushed the changes as fixup! commits (will squash them if everything is ok).

Signed Atlassian Individual CLA.

I'll keep an eye out for the CLA on our side (unfortunately it's still a bit manual), but it looks good to me.
I'll get it released once that shows up.
Thanks!

Any news on CLA? If it helps, I've signed it on August 28, as Alexey Kryuchkov.
Not sure what can be done about the failing CI build --- make test-race consistently passes on my machine. Any way to restart it?

Sorry for the delays - finally came in overnight.  Not sure about the test, looks like a flake.  Trying to repro it locally.  If I can I'll raise an issue, otherwise call it cosmic rays from space.


\rangle error for inline LaTeX #mi

version: 0.2.4:
problem:
#mi("\langle{w_1}\rangle")
#mitex(`\langle{w_1}\rangle`)

is different, and #mi fail to generate \rangle.
by the way, could anyone tell me that how to present $\langle \rangle$ in typst?

You shouldn't use double quotes "" because you need to deal with escapes.
---Original---
From: "Yiran @.>
Date: Sun, Jun 2, 2024 15:58 PM
To: @.>;
Cc: @.***>;
Subject: [mitex-rs/mitex] \rangle error for inline LaTeX #mi (Issue #169)
version: 0.2.4:
problem:
#mi("\langle{w_1}\rangle") #mitex(\langle{w_1}\rangle)
is different, and #mi fail to generate \range.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

OK i see, thx


Translated README in English

I've tried to translate the README file into English with a google translator.

Thank you for helping me translate this. I will Merge this


Refresh JMX metrics using a background thread

After #52 is merged, it would be cool to improve upon that by refreshing JMX-gathered metrics in the background. This would prevent the BrokerViewCacheActor thread from blocking.

+1


added simple ompl benchmarking code

Basic support for OMPL benchmarking. How should I pass all the parameters in? Should I do an XML thing like there is elsewhere?

This pull request is very out of data and would need a significant refactor to merge cleanly. We can revisit this once the constrained planning changes are merged.


Question about MVVM like architecture and states

Hi, Lately I had the chance to see some example projects of ReSwift.
I noticed that part of the projects are implementing the MVVM like approach. Where the view model is a struct which get a state and then calculate some properties like: String, Bool and more which effect the view. I really liked this concept because it decouple the state from the view and view controllers.
A very good example is this project: https://github.com/cardoso/ReduxMovieDB
There inside the MovieListViewController.swift it init the state view model instead of subscribing to the state directly (like in ReSwift docs). The subscribe code looks like the following:
mainStore.subscribe(self, transform: {
            $0.select(MovieListViewState.init)
})

The MovieListViewState looks like the following:
struct MovieListViewState {
    let movies: [Movie]
    let searchBarText: String
    let searchBarShowsCancel: Bool
    let searchBarFirstResponder: Bool

    init(_ state: MainState) {
        movies = state.movies

        switch state.search {
        case .canceled:
            searchBarText = ""
            searchBarShowsCancel = false
            searchBarFirstResponder = false
        case .ready:
            searchBarText = ""
            searchBarShowsCancel = true
            searchBarFirstResponder = true
        case .searching(let text):
            searchBarText = text
            searchBarShowsCancel = true
            searchBarFirstResponder = true

        }
    }
}

As you can see from the code above. It gets a main state (or sub state) and then calculate and create only the relevant properties for the view.
Inside the view controller newState delegate the view controller now gets an instance of the view model and not instance of the state.
extension MovieListViewController: StoreSubscriber {
    typealias StoreSubscriberStateType = MovieListViewState

    func newState(state: MovieListViewState) {
        movies = state.movies
        moviesTableView.reloadData()

        searchBar.text = state.searchBarText
        searchBar.showsCancelButton = state.searchBarShowsCancel

        switch (searchBar.isFirstResponder, state.searchBarFirstResponder) {
        case (true, false): searchBar.resignFirstResponder()
        case (false, true): searchBar.becomeFirstResponder()
        default: break
        }
    }
}

I really love this approach because all the calculation of what need to present/hide or modify moved to the view model responsibility and are not being calculated on the reducer. This keeps the reducer very simple.
The issue with this approach
I tried to run and debug some projects which leverage this nice approach and found that the view model init function are being triggered each time that an action is being dispatched. The problem with it is that in mid-size of big projects a lot of actions are being dispatched for any kind of operations. I tried to use Skip Repeats by adding Equatable to the state view model but it still calling the init each time an action is being dispatched.
What I can do is to still subscribe to the state and inside the new state to create the state view model and continue from there, but I think the first option is much nicer and more flexible
So I wanted to know if somebody here face the same situation or maybe somebody have an idea on how to solve it.
Thanks!

Now that's a clever and not really intended use of select!
When you tried to skip repeats, how'd you write that? Did you try this?
mainStore.subscribe(self, transform: {
    $0.skip(when: { _ in true }).select(MovieListViewState.init)
})

... to verify that now the initializer is never called and the newState is always skipped?

Hi @DivineDominion  Will try it and will let you know

Hi @DivineDominion I am not able to skip. I get a syntax error when I am trying to do it. I tried with SkipRepeats() but it still calling the init method a lot of times

Well, we should find out why that doesn't compile, though. Details?

Hi @DivineDominion it looks like it is related to the StoreSubscriber type
See attached image:

Hey, @ranhsd. I don't see anything weird in your code, just make sure your MovieListViewState struct is indeed conforming to Equatable and that you're using the latest version of ReSwift (when in doubt, check using master).
This store.subscribe(self) { $0.select(MovieListViewState.init) } is the way I implement my subscriptions as well and it works ok for me (without having to call skipRepeats).

Hi @danielmartinprieto
this is the MoveListViewState:
struct MovieListViewState : Equatable {
    let movies: [Movie]
    let searchBarText: String
    let searchBarShowsCancel: Bool
    let searchBarFirstResponder: Bool

    init(_ state: MainState) {

        print("init")

        movies = state.movies

        switch state.search {
        case .canceled:
            searchBarText = ""
            searchBarShowsCancel = false
            searchBarFirstResponder = false
        case .ready:
            searchBarText = ""
            searchBarShowsCancel = true
            searchBarFirstResponder = true
        case .searching(let text):
            searchBarText = text
            searchBarShowsCancel = true
            searchBarFirstResponder = true

        }
    }

And the Podfile is:
# Redux pods
  pod 'ReSwift', :git => 'https://github.com/ReSwift/ReSwift.git'

And I still get the syntax error
Thanks!

Sorry, I was talking about your original code and the fact that your subscription was getting called even though that part of the state hasn't changed.

Can you figure out why the code doesn't compile? I think it was because it should be 2 underscores nowadays; try this:
mainStore.subscribe(self, transform: {
    $0.skip(when: { _, _ in true }).select(MovieListViewState.init)
})

Hi @DivineDominion now it is complied but the MoveListViewState init called only one time and it should be called multiple times (for every change but not for every dispatch of an action)

Yeah sure, the above code always skips. Now we know there's something fishy with your equatability.

Hi @DivineDominion. Actually it's not my code. What I can do is to try to integrate the same solution in one of my ReSwift projects there I know exactly how it should behave.

Any updates to this? @ranhsd

Hi @affbedran
I finally gave up on this approach and what I did is to create the view model inside the newState of ReSwift like this:
func newState(state: MyState) {
   let viewModel = MyViewModel(state: state)
  ...
}

With this approach I can use skipRepeats without any problem...
Ran.


Formatting and parsing support for RFC 7231 HTTP-dates

Add formatting and parsing support for RFC 7231 HTTP-dates, as used in HTTP headers (Expires, Last-Modified, etc) and cookies.
Advantages:
There's clear utility, as it's a ubiquitous format on the web, due to being used in many common HTTP headers and cookies. Currently the best way of handling in JS is to use the Date methods, but that's not ideal as Date is already being referred to as "legacy" in the Temporal documentation due to its many drawbacks. One could reasonably expect "no Date" to become a common linter rule once Temporal achieves widespread platform support.
Date also doesn't implement validation for the string parsing — arbitrary strings will never throw and may or may not return valid dates that may or may not be what was expected.
In addition, Date parsing fails to fully implement HTTP-date as specified in RFC 7231, as the two obsolete (pre-1995) formats aren't accounted for.
Concerns:
None that I can think of
Prior art:
Formatting:

Date.prototype.toUTCString

Parsing:

Date.parse, or by extension the Date constructor, which uses the same parsing logic

Implementations should correctly handle the string values generated by toUTCString
The two obsolete (pre-1995) formats mentioned by RFC 7231 are unspecified

Constraints / corner cases:

How strict should parsing be — for example, should Mon, 06 Nov 1994 08:49:37 GMT throw due to that date being a Sunday not a Monday?
Should the two obsolete (pre-1995) formats mentioned by RFC 7231 be included in the parsing logic? I have no idea how common these are in-the-wild as of 2023.
Names/locations of the new methods — maybe something like Temporal.Instant.toHttpDateString and Temporal.Instant.fromHttpDateString? Logically, Instant seems to make more sense than ZonedDateTime, despite the IMF-fixdate and rfc850-date formats specifying "GMT" (it's always GMT).

I would say that parsing this format was one of the bigger drawbacks of Date and there's strong reasons for implementers and other folks to be skeptical of the format. The current plan is to stick to the ISO 8601-like formats for interchange and serialization in JavaScript and all other formats (both parsing and formatting) could be done using light userland helper libraries.

The current plan is to stick to the ISO 8601-like formats for interchange and serialization in JavaScript

ISO 8601 is definitely "better" for interchange for various reasons, but it's not the format used by various standard HTTP headers or cookies, whether those originate in JS or any other language. Given the wide usage of this format by core web technologies, it seems this would be a useful thing to have a standard web/browser API for, even if it wasn't collocated with Temporal. Arguably it's more of a standard library concern, but of course JS doesn't have a standard library.

I completely agree with you that while ISO 8601 (and friends) is generally more suitable for interchange, other formats are prevalent across the web such as this one. One thing it has in its favor is that it will continue to be supported via Date forever and while you raised concerns about lint rules disallowing the use of Date, I believe that since it can still be overruled, it's not as big of a problem, atleast not compared to JavaScript exposing this functionality from two different API surfaces.

Sure, makes sense. I'll leave the issue open for now, but feel free to close if this is definitely considered out of scope.

Let's leave it open for others to comment. Perhaps I'm in the minority here and others are more open to the idea.

Given how common HTTP-dates are, I would suggest supporting this out-of-the-box with Temporal. Not doing it would make a sizeable proportion of the web rely on 3rd party libraries, which could be avoided in this case. Common operations on standardised formats such as this one should not require additional dependencies.

Not doing it would make a sizeable proportion of the web rely on 3rd party libraries

@TheOneTheOnlyJJ To clarify, this is already supported by Date.prototype.toUTCString and Date.parse, so there's no need for third-party libraries. The reason I'm suggesting adding it to Temporal is that Temporal can largely replace Date once it achieves widespread support; having certain essential functionality that's only available via Date complicates that story somewhat. But in any case, Date will still be around forever to avoid breaking the web, so there won't be any need for third-party libraries (except for cases like stricter RFC 7231 compliance/support for obsolete formats).

After giving this some more thought, I think I've found an optimal solution.
Maybe we could expose this functionality through a predefined string we pass to the format/strftime function suggested in #5. To me, this makes the most sense, as it would remove any specific custom logic for this specific format. The need for using the to-be-deprecated Date will be removed.
There's great support in the community for #5 to be adopted, and by approaching the issue in this way we cement support for it even further. Even if not looking at it through the lens of a #5 supporter, this still is the best logical approach to use. No string format should have its own custom logic in the library. All formats should leverage a common formatting core ability of the library for the best extensibility.
There could also be other predefined format strings besides this one, for popular & widely-adopted formats. As they would all be just constant format strings, we could expose as many of them as we see fit. Users could freely define their own as well, but the most common formats should be provided out-of-the-box to avoid any potential common errors and improve DX.
I'm looking forward for your feedback on this approach.


Merge branch 'master' of https://github.com/brwilkinson/azure-docs

@brwilkinson : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Resume still viewable & public even if the account is deleted

Hi,
I believed the same concern was raised in the past https://github.com/AmruthPillai/Reactive-Resume/issues/253
This is still not fixed, I've tested only with anonymous login. The steps to reproduce are same.
Proof of concept:
The account with ID fqwtkm has been deleted but the resume is still viewable and public
https://rxresu.me/r/fqwtkm
Thank you!

Will look into this. I believe this issue is with the cloud function itself, where I'm trying to delete all resumes (https://github.com/AmruthPillai/Reactive-Resume/blob/develop/functions/index.js). Instead of using a forEach array, refactoring it to a Promise.all array should help.
Thank you for bringing this to light, will raise a PR fixing this as soon as I get the time :)

@AmruthPillai Hi Amruth, in case you are short of time, I would be happy to help with this.

@gianantoniopini That would be very helpful, thank you!

 I will try to reproduce the issue and debug/test the cloud function. Hopefully I can raise a PR soon.


Sprint 4: Backend Development

Crossover Score: 2.7/3.0

[x] Boolean Lesson
[x] Focus / Habits
[x] Deployment on AWS

Crossover Grade: 2.7 / 3.0

Boolean/control structures lesson is informative and meets requirements
Completed notes on focus and habits
Successful AWS deployment


Add Grayscale image preprocessor

The Grayscale image preprocessor is missed in KotlinDL.
Convert image to grayscale.
The main question is: should we keep the ImageShape with 3 channels or with 1 channel? Or support the difference via parameter like in PyTorch
The desired PR addressing this issue should include:

[ ]  Implementation (you can take inspiration from the implementation of Cropping  as reference)
[ ]  Documentation
[ ]  JUnit tests in dataset module
[ ]  An example with usage of this image preprocessor

P.S. If you want to take this ticket, please leave the comment below
P.P.S Read the Contributing Guidelines.
The reference implementation could be taken from torchvision.transforms

should we keep the ImageShape with 3 channels or with 1 channel?

Since currently BufferredImage is used for image preprocessing, in my PR I use BufferedImage.TYPE_BYTE_GRAY and return images with one channel. If we migrate to something else, we could think about supporting 3 channels for grayscale images.


Generate a man page for bpfman

Can we use https://crates.io/crates/clap_mangen?

Yep. We would use an xtask instead of build.rs.

Hi @weiyuhang2011!
Yes it would be awesome to have manpages.
Since we only have one binary called bpfman now, we'd just need the manpage for that one. I'll update the issue title appropriately.

Hi @weiyuhang2011! Yes it would be awesome to have manpages. Since we only have one binary called bpfman now, we'd just need the manpage for that one. I'll update the issue title appropriately.

Hi @dave-tucker , the problem I found is that it is hard to import bpfman cli struct dependency in xtask because it is a bin crate. Including the whole mod.rs file from cli doesn't look right because the dependency issue of that file need to be solved. Shall we refactor the cli part into a lib crate?

Hi @dave-tucker , the problem I found is that it is hard to import bpfman cli struct dependency in xtask because it is a bin crate. Including the whole mod.rs file from cli doesn't look right because the dependency issue of that file need to be solved. Shall we refactor the cli part into a lib crate?

I don't think we need to go that far. I'll try moving all the structs that clap uses into args.rs and then you should be able to simply include!("../../bpfman/src/cli/args.rs) and then generate the manpages using clap_mangen. It's not an easy refactor, so leave it with me and I'll get a PR done in the next few hours - I'll tag you here when it's done so you can carry on with the manpage generation.

@weiyuhang2011 ok now #870 has merged you should be unblocked 🎉
I had a quick try with include!(../../bpfman/src/cli/args.rs) from an xtask and I was able to get manpage generation to work.
A couple of pointers:

You'll want to use the module attribute !#[allow_dead_code] since some of the included code isn't used and this is the easiest way to suppress those warnings.
We'll need to generate, bpfman.1, bpfman-load.1 etc.. - one manpage for each command/subcommand
let cli = Cli::command(); is what you need to pass into clap_mangen, which requires using the clap::CommandFactory trait.

I'll also go ahead and generate an issue for completions since these should also be easy enough to add.

@dave-tucker Thank you for your quick response! I'm working on it.


hmtrp: Initial implementation

This was tested on the Grove Serial RF Pro.
Signed-off-by: Jon Trulson<EMAIL_ADDRESS>Signed-off-by: Zion Orent<EMAIL_ADDRESS>

Thanks!  Merged and closing.


No tab titles

I have the macos-ui-theme installed (not sure if that's the problem) and the tab titles are missing:

This might be because there was no label rendered in HTML:

This is the source:
type: custom:tabbed-card
tabs:
  - label: Täglich
    card:
      type: custom:weather-card
      number_of_forecasts: '5'
      current: true
      details: false
      forecast: true
      hourly_forecast: false
      entity: weather.bremen_daily
  - label: Stündlich
    card:
      type: custom:hourly-weather
      entity: weather.bremen_hourly
      num_segments: '8'
      icons: true
      label_spacing: '2'
      name: Stündliches Wetter
      show_precipitation_amounts: true
      offset: '0'
      show_precipitation_probability: true

Check docs for a correct placement of the “label” option.

Ah thanks!
This is the fixed code:
type: custom:tabbed-card
tabs:
  - attributes:
      label: Stündlich
    card:
      type: abc
  - attributes:
      label: Täglich
    card:
      type: xyz


Site is slow

We should do a pass for obvious caching opportunities/don't do insane amounts of work.

I think the site IS slow, although not unbearably slow. It probably wouldn't take TOO much to make it snappy. I wonder how fast sqlite is. I managed to call Munch.init 324,840 times in my short test. Given that there's only ~200 decks and 15,000 cards in the database I suspect this bottleneck could be improved by caching.
$ python -m cProfile -o /tmp/prof.dat run.py decksite
# Visit a few pages
$ python -m pstats /tmp/prof.dat

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
       20    0.726    0.036    0.726    0.036 {method 'execute' of 'apsw.Cursor' objects}
        2    0.426    0.213    0.426    0.213 {method 'recv_into' of '_socket.socket' objects}
   324840    0.299    0.000    0.299    0.000 /opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/munch/__init__.py:130(__setattr__)
       20    0.266    0.013    0.338    0.017 {method 'fetchall' of 'apsw.Cursor' objects}
        2    0.198    0.099    0.198    0.099 {built-in method _socket.getaddrinfo}
    16242    0.188    0.000    0.732    0.000 /Users/bakert/pd/magic/card.py:119(__init__)
   326240    0.167    0.000    0.466    0.000 {built-in method builtins.setattr}
        1    0.113    0.113    0.113    0.113 {method 'do_handshake' of '_ssl._SSLSocket' objects}

We have 368 decks in the database.  These inefficiencies are starting to become noticeable. (Especially after today's tournament, where an additional 30-something were added)

The slowness is caused almost entirely by deck loading in deck.load_decks.
The initial load_cards takes .5-1s and the loop starting for d in decks: takes another 1s or so depending on the number of decks involved.

A lot of the stuff we calculate there could probably be cached

In c3b8660 I added rudimentary response caching. It's grrrrrreat if you're not the first person to request a page in the given window but otherwise does nothing. We might get away with just this although making everything more efficient at a lower level still makes a lot of sense and will speed up all the first requests for pages (which might be the majority or even almost all the requests issued to the site).

commit 2aca239b6c5be1df806ee9c24dc0e811a60c24f3 (HEAD -> needforspeed2)
Author: Thomas David Baker<EMAIL_ADDRESS>Date:   Mon Jul 3 19:14:03 2017 -0700
Make deck loading 5-10x faster.

Specifically via:

- Storing some expensive-to-calculate values in a table called deck_cache.
  deck_cache Will be populated at insert time but to renew the cache for all decks (takes a few seconds) visit /admin/cache.
- Load card names and numbers in the same query as deck details.
- Only sort cards into a "deck sort" in the individual deck view rather than as a default.
- Move legal icons and other view-ish stuff out of deck and into view.
- Use the CARDS_BY_NAME global that we generate on startup to load card details much faster.

Some things that came up while doing this that I didn't yet look at:

In memory cache of card and deck details.
Broader use of CARDS_BY_NAME instead of load_cards. load_cards should probably be renamed init and only called when CARDS_BY_NAME is empty.
Add a LIMIT to similar decks after ordering by date
oracle.deck_sort is pretty expensive - why? can we get the sort value onto card during generation so it's always available and doesn't have to be generated?

On local (compare the 2.5-3s number above) loading deck and all its details takes 0.01-0.7s now.

Site can always be faster but I'm closing this for now. I'll have another go-around when I've made it noticeably slower again :)


support chat-7b-8k

support chat-7b-8k,otherwith it will be cut to 2048,unable to match the long sentence ability
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:

[ ] Pre-commit or other linting tools are used to fix the potential lint issues.
[ ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

Hi @LYMDLUT ,
Thanks for your kind contribution. Simply change the context to 8k will cause the InternLM-Chat model fail to process long context window. Thus, I suggest we enhance the web_demo.py to make it allow to load different models with different configs. Would you like to do that?

Hi @LYMDLUT , Thanks for your kind contribution. Simply change the context to 8k will cause the InternLM-Chat model fail to process long context window. Thus, I suggest we enhance the web_demo.py to make it allow to load different models with different configs. Would you like to do that?

Hello, Dr. Wenwei！I have made some attempts, but I am not sure if it meets your expectations. If there are any areas that need improvement, I will work hard!

This PR looks good to me now. Can be merged after resolving the conflicts.

There is no check, please commit new content to add checks before merged.


Using an env var to load the API url

I didn't really like having the API root hard coded where it was. I change the docker-composer to include a env var to the store the URL of the API. @hermzz let me know what you think.

I agree. I'm also looking at using docker in production as well.


Unable to load resnext-101-kinetics.pth model

I run following command:
python main.py --input ./input --video_root ./videos  --output ./output.json --model_name resnext --model_depth 101 --model ./models/resnext-101-kinetics.pth --mode score
and got following error:

Traceback (most recent call last):
File "main.py", line 24, in
model_data = torch.load(opt.model)
File "/home/saurabhr/.local/lib/python3.5/site-packages/torch/serialization.py", line 303, in load
return _load(f, map_location, pickle_module)
File "/home/saurabhr/.local/lib/python3.5/site-packages/torch/serialization.py", line 459, in _load
magic_number = pickle_module.load(f)
_pickle.UnpicklingError: invalid load key, '
'.

Python version: 3.5.2
torch version: 0.4.0
torchvision version: 0.2.1
cuda : 9.0

The shortcut parameter is missing from your command. It may be the cause of the error. Try to add "--resnet_shortcut B" in the command.

@thanasisDr I didn't help. Same error. I think pretrained model file has some problem.

@saurabhhjjain Did you try loading any of the other resnext models? There's six of them.

No, I didn't

The shortcut parameter is missing from your command. It may be the cause of the error. Try to add "--resnet_shortcut B" in the command.

thank you, it helps.


scripts

I'm currently using Helmet but I do prefer the hooks approach you offer.
One thing I'm missing is <script> support. It's nice to be able to encapsulate trackers and other scripts that have to go in <head> for technical reasons so they can be placed where they make sense in the application.
Helmet's support for <script> is very rudimentary IMHO - it just adds the tag without regards for SSR-rendered previous tags, and if you put in an inline script, it won't run it, so that will only work for SSR.
So, ideally, hoofd would:

support script tags
mark SSR-ed script tags in a way they can be recognized after hydration
only add script tags once, also after hydration
eval inline scripts when run in the browser, but add them to <head> when run during SSR

But, I would already be happy with simply supporting the tag.

Hey,

eval inline scripts when run in the browser, but add them to  when run during SSR

Honestly, I don't really feel comfortable allowing arbitrary evaluation or injection of scripts
The other things should be possible

The problem is that most trackers require an inline script as well as a regular script. So this solution would not be enough.
Furthermore, you are already allowing arbitrary evaluation of scripts, only they are in the form of hosted scripts instead of inline scripts...
Also, since you're adding the script elements via DOM manipulation, I believe there's no need to eval, the browser will honor the script tag anyway?
Other than that, the PR looks great!

I wonder if the inline use-case could be adequately addressed using data-uris, like:
useScript({ src: 'data:application/javascript,alert("yolo")' });

Great idea!

Closing and pushing #35 and #31 in a 1.2.0 release

@JoviDeCroock, should type be marked as optional in ScriptOptions?

Ah damn, forgot about that 😅


rclone keeps deleting my OneDrive config

rclone version: 1.34
Ubuntu server: 16.04..1 LTS
OneDrive and Amazon Drive
I have both Amazon Drive and OneDrive setup in rclone. However, rclone keeps wiping out my OneDrive configuration completely! It happens very randomly. I also do have my OneDrive mounted too. The mount stays active and I can pull files from it. But, the configuration for OneDrive is all gone.
If I do rclone config or look at .config.conf in my home directory, I only see Amazon Drive there.
Why does it keep forgetting my OneDrive? Will it help if I get rid of Amazon Drive and only keep OneDrive?

Ok, this is weird! I removed all of my configured accounts and started over. Only this time, I didn't add anything else beside OneDrive. It worked good for about an hour then all of the sudden, it removed my OneDrive config and added Amazon back all by itself! Is this even possible? Could there be another config file somewhere else overwriting my config in my home directory?

This is almost certainly #682 - that is you've got one rclone running while you are configuring it.
Does that make sense?

Oh got it! Makes more sense. THANK YOU so much for working on a fix for this. Once everything is configured, it shouldn't be a problem anyways. I was just thinking it had something to do with my OneDrive.


We need to escape other characters

https://github.com/alphagov/govuk_frontend_toolkit/blob/c88df4977fbb1d63950e8d19cc7dfbd02ede0709/javascripts/govuk/show-hide-content.js#L18
In a service I am working on, a back-end (Scala Play) naming convention for grouped elements uses a period (.) in field names e.g. contactAddress.line1
The existing showHideContent escapeElementName() method does not handle this and we see the module failing when invoked with errors due to the presence of periods. The use of periods in field names is valid HTML so we are working with a solution to expand the characters escaped. What we found was using CSS.escape() with a polyfil for unsupported browsers works well for us. Is this something being worked on or should I propose a PR?

Hey! We're currently rebuilding this for the new GOV.UK Frontend project, but that's in private beta for now.
Feel free to propose a PR, but the minimum might be to give us an example code snippet we can use to make sure the new version covers this use case.

Thanks for raising, @nubz.
I believe this is a duplicate of #402, so I'm going to close this. (I also think it would be fixed by #403)