[RESTEASY-1922] Exclude interfaces

@mkouba this is what you were suggesting to do, right?

Yep, exactly. Thanks!


mangojuice: fix GTK4 paths

Fixes issues finding GTK4 dependencies, e.g:
GLib-GIO-ERROR **: 15:02:46.139: No GSettings schemas are installed on the system
GLib-GIO-ERROR **: 15:05:00.514: Settings schema 'org.gtk.gtk4.Settings.ColorChooser' is not installed

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

easy to miss! noticed it while i was running it, so figured i'd throw a fix up :)

This double wraps the binary. We should set dontWrapGApps = true and modify the current wrapper like so in order to reuse the arguments from the hook

ah, good catch @getchoo, thanks! pushed a fix


Support rootBundle and/or fail gracefully in "flutter test"

(This is at Flutter 1.0.0 Stable)
Related (closed) issue: https://github.com/flutter/flutter/issues/23466
Related (closed) S/O: https://stackoverflow.com/questions/49480080/flutter-load-assets-for-tests
Currently, when you have a widget that loads an asset, for example using Image.asset, and you try to test that widget (flutter test test/my_icon_test.dart), you get the following bizarre error message:
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following assertion was thrown running a test:
Unable to load asset: AssetManifest.json

When the exception was thrown, this was the stack:
#0      PlatformAssetBundle.load (package:flutter/src/services/asset_bundle.dart:221:7)
<asynchronous suspension>
#1      AssetBundle.loadString (package:flutter/src/services/asset_bundle.dart:67:33)
<asynchronous suspension>
...
#376    AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:897:35)

After reading the above issues, I realized that relying on the rootBundle in widget tests is unsupported, and the suggested alternatives is to basically implement the bundle yourself for a test. That seems ... pretty rough for what (I expect) most users want to do, for example take golden tests of various widgets.
A more short-term fix might be handling this error case better in flutter test (i.e. the feedback of the error shouldn't leak some mysterious AssetManinfest.json file).
Doctor
[✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.14 18A391, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[✓] Android Studio (version 3.0)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] IntelliJ IDEA Ultimate Edition (version 2018.3)
[✓] VS Code (version 1.30.1)
[✓] Connected device (1 available)

• No issues found!

Oops, closing as a duplicate of https://github.com/flutter/flutter/issues/12999.


Update HttpAjaxContext.cs

Support for multiple refresh executions for the same grid instance
THIS PR REQUIRE GENERATION UPDATE (check required rev by issue id at SVN prolog)

If possible, keep the previous signature of void ajax_rsp_assign_grid also, so it is compatible with previous binaries (for example GAM binaries).

ok, done


samples: Bluetooth: peripheral_hr and central_hr extended advertising support

Update peripheral_hr sample to support using extended
advertising and hence be long range compatible on SoCs
that support Bluetooth Low Energy Coded PHY.
Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>

@cvinayak how are we doing in this PR? Having some coverage for coded phy in CI would be very nice

@cvinayak how are we doing in this PR? Having some coverage for coded phy in CI would be very nice

I think these samples are pretty common to run for first-time users - It would be great to have them tested in BSIM in CI :)

@cvinayak how are we doing in this PR? Having some coverage for coded phy in CI would be very nice

I think these samples are pretty common to run for first-time users - It would be great to have them tested in BSIM in CI :)

Using these samples (Extended Scanning) on target has reveal an assertion and its analysis has caused the delay, hope to rework on this PR as soon as possible.


Insiffucient Liqudity Message in wrong situation

My situation:
LP Reserves:
USDC<PHONE_NUMBER>
XLM 2000
My Balance 2M+ each, is enough
I want to swap XLM for USDC.
If I start typing 4 digits, says "Insufficient Liquidity", even if the expected output amount is less than the USDC reserve

Price impact can be higher than 100%
What are the rules for Insufficient Liquidity in this case @abstract829 ?

@esteblock
was not validating the reserve token vs the input address
added this and should be fine
    if (reserves?.token0 === currencyA?.address) {
      reserveA = formatTokenAmount(reserves?.reserve0 as BigNumber);
      reserveB = formatTokenAmount(reserves?.reserve1 as BigNumber);
    } else {
      reserveA = formatTokenAmount(reserves?.reserve1 as BigNumber);
      reserveB = formatTokenAmount(reserves?.reserve0 as BigNumber);
    }

    const insufficientLiquidity =
      Number(inputA) > Number(reserveA) || Number(inputB) > Number(reserveB);

Hola @abstract829
const insufficientLiquidity =
      Number(inputA) > Number(reserveA) || Number(inputB) > Number(reserveB);

Sólo es necesario Number(inputB) > Number(reserveB);, porque es sólo el B que será output.
el token A es lo  que el usuario va a insertar

lo cambiè a Number(inputB) > Number(reserveB);


Cant make requests on app share extension

Hello, I have a share extension, and when i try to make the requests, it responds with nil immediately and no call is made.
the code is:
let configuration = NSURLSessionConfiguration.backgroundSessionConfigurationWithIdentifier(kAppGroup)

var manager = Alamofire.Manager(configuration: configuration)

...

manager.request(.POST, WS_URL_SHARE.stringByReplacingOccurrencesOfString("{type}", withString: type),
            parameters: [
                "name" : username!,
                "email" : email!,
                "message" : message,
                "file" : file //base64 string
            ],
            encoding: .JSON,
            headers: headers)
            .responseJSON { response in
                print(response.request)  // original URL request
                print(response.response) // URL response
                print(response.data)     // server data
                print(response.result)   // result of response serialization

                if let JSON = response.result.value {
                    print("JSON: \(JSON)")
                    self.delegate?.reportDidFinishLoading()
                } else {
                    self.delegate?.reportDidFinishLoadingWithError()
                }
        }

Is there something wrong?

As mentioned in our documentation you need to keep a reference to manager you've created around somehow. If you don't it will be deallocated once it leaves scope an you'll see your observed behavior.


Adding without scroll action, Deleting records

If I add records on the object on modelPath, how can I trigger them to be rendered without having to push them individually? I'd like it to be able to just listen for changes and refresh the contents.

How do I get it to update when I remove a record?

Hi @Diodeus !

This is unrelated to ember-infinity - just use pushObjects and the list should update automatically

using removeAt or removeObject/s should do the trick

Essentially - just use the MutableArray methods on the infinityModel (usually at controller.model), and the template will update.
http://emberjs.com/api/classes/Ember.MutableArray.html

closing - let me know if you need further help


Discord for iOS/iPadOS Bluetooth Keyboard Support

As of right now, ⌘ + K is the single functioning keyboard shortcut in the Discord for iOS and Discord for iPadOS applications.
Related Correspondence
Keyboard shortcuts on iOS – Discord


Add social proof verification to gaia-hub

This is supported (and configurable) in gaia hubs now. It checks the 0th ordinal profile for verifications, no additional headers required.


Fix tag construction in ForwardDiff

DI extensions

Tags were not properly constructed in ForwardDiff extension: we need to use the Tag(f, R) constructor to increment the global tag counter. Examples of correct tag construction: here, here

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 6.46%. Comparing base (454f312) to head (c21a3a1).

Files
Patch %
Lines

...xt/DifferentiationInterfaceForwardDiffExt/utils.jl
0.00%
1 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (454f312) and HEAD (c21a3a1). Click for more details.
HEAD has 49 uploads less than BASE

Flag
BASE (454f312)
HEAD (c21a3a1)

50
1

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #357       +/-   ##
==========================================
- Coverage   96.89%   6.46%   -90.44%
==========================================
  Files         101      66       -35
  Lines        4830    2584     -2246
==========================================
- Hits         4680     167     -4513
- Misses        150    2417     +2267

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Next on empty iterator in BroadcastRegionJoin

Not sure why this is happening, but I'm getting this:
java.util.NoSuchElementException: next on empty iterator
        at scala.collection.Iterator$$anon$2.next(Iterator.scala:39)
        at scala.collection.Iterator$$anon$2.next(Iterator.scala:37)
        at scala.collection.IndexedSeqLike$Elements.next(IndexedSeqLike.scala:64)
        at scala.collection.IterableLike$class.head(IterableLike.scala:91)
        at scala.collection.mutable.ArrayBuffer.scala$collection$IndexedSeqOptimized$$super$head(ArrayBuffer.scala:47)
        at scala.collection.IndexedSeqOptimized$class.head(IndexedSeqOptimized.scala:120)
        at scala.collection.mutable.ArrayBuffer.head(ArrayBuffer.scala:47)
        at org.bdgenomics.adam.rdd.BroadcastRegionJoin$$anonfun$4.apply(BroadcastRegionJoin.scala:114)
        at org.bdgenomics.adam.rdd.BroadcastRegionJoin$$anonfun$4.apply(BroadcastRegionJoin.scala:114)

It is coming from this line:
// each element of the left-side RDD should have exactly one partition.
    val smallerKeyed: RDD[(ReferenceRegion, (ReferenceRegion, T))] =
      baseRDD.map(t => (regions.value.regionsFor(t).head, t))

I'm not sure exactly what's going on here. I've made a local hack to get my code to run that changes this to an optional flatMap, which lets things run forward; I'll take more of a look later this week. @tdanford do you have any intuition as to what the single-partition invariant is here? I'm thinking that this should be changed to either a flatMap with a log warning, or at least a more clear assert message (the stack trace isn't terribly helpful).

WAR code is at: https://github.com/bigdatagenomics/adam/tree/broadcast-join-bug

Could it be because of something similar to this:
http://stackoverflow.com/questions/28274165/scala-code-crashing-with-java-util-nosuchelementexception-next-on-empty-iterato

@pgrosu Sorry if things were unclear; that's not what I'm asking. There's an "exactly-one" invariant in the code that is being violated. There's no assert checking the "exactly-one" invariant, but the invariant is documented in the code. So yes, the exception is thrown because we're calling head on an empty iterator, but the bug is that the iterator is supposed to be guaranteed to have a single element in it.

Ah, okay - no problem :)
Thanks for the clarification,
~p

The section of code impacted by this bug was removed in https://github.com/bigdatagenomics/adam/pull/1234. Closing.


Timeout when doing gatsby develop

Instead of restarting the timeout for each of the request, it will add up for each request. It will cause the fail the develop task if the requests take longer than 30 seconds in total, but instead it should throw an error if one request takes longer than 30 seconds. You can see in the log how each call adds up the timeout counter:
> gatsby develop

success open and validate gatsby-configs - 0.041s
success load plugins - 0.583s
success onPreInit - 0.028s
success initialize cache - 0.017s
success copy gatsby files - 0.042s
success onPreBootstrap - 0.015s

success  gatsby-source-wordpress  ensuring plugin requirements are met - 13.650s

info  gatsby-source-wordpress

        This is either your first build or the cache was cleared.
        Please wait while your WordPress data is synced to your Gatsby cache.

        Maybe now's a good time to get up and stretch? :D

success  gatsby-source-wordpress  ingest WPGraphQL schema - 19.010s
success createSchemaCustomization - 32.689s
success  gatsby-source-wordpress  fetch root fields - 2.990s
success  gatsby-source-wordpress  Category - 6.193s - fetched 5
success  gatsby-source-wordpress  Comment - 6.200s - fetched 0
success  gatsby-source-wordpress  ContentType - 9.330s - fetched 3
success  gatsby-source-wordpress  Lesson - 13.258s - fetched 10
success  gatsby-source-wordpress  Course - 14.849s - fetched 15
success  gatsby-source-wordpress  MenuItem - 17.214s - fetched 4
success  gatsby-source-wordpress  Menu - 17.577s - fetched 1
success  gatsby-source-wordpress  PostFormat - 20.179s - fetched 0
success  gatsby-source-wordpress  Page - 21.808s - fetched 11
success  gatsby-source-wordpress  Tag - 25.091s - fetched 12
success  gatsby-source-wordpress  Post - 27.303s - fetched 8
success  gatsby-source-wordpress  Taxonomy - 27.799s - fetched 3
success  gatsby-source-wordpress  UserRole - 29.864s - fetched 0

 ERROR

timeout of 30000ms exceeded

 ERROR #gatsby-source-wordpress-experimental_111006

 gatsby-source-wordpress  It took too long for https://example.org/gql to respond (longer than 30 seconds).

Either your URL is wrong, you need to increase server resources, or you need to decrease the amount of resources each request
takes.

You can configure how much resources each request takes by lowering your `options.schema.perPage` value from the default of 100
nodes per request.
Alternatively you can increase the request timeout by setting a value in milliseconds to `options.schema.timeout`, the current
setting is 30000.

To bypass the issue, I increased the timeout to something ridiculously high in the gatsby-config.js:
      resolve: "gatsby-source-wordpress-experimental",
      options: {
        url: "https://example.org/gql",
        timeout: 3600000
      },

However, it does not work. How can I increase the timeout for now, until it's fixed?
My dependencies:
    "gatsby": "^2.30.1",
    "gatsby-image": "^2.9.0",
    "gatsby-plugin-react-helmet": "^3.8.0",
    "gatsby-plugin-sass": "^2.8.0",
    "gatsby-plugin-sharp": "^2.12.0",
    "gatsby-source-filesystem": "^2.9.0",
    "gatsby-source-wordpress-experimental": "^6.1.0",
    "gatsby-transformer-sharp": "^2.10.0",
    "node-sass": "^5.0.0",
    "react": "^16.13.1",
    "react-dom": "^16.13.1",
    "react-helmet": "^6.1.0"

Hi @martin-braun did you try the following from the error message?
You can configure how much resources each request takes by lowering your `options.schema.perPage` value from the default of 100
nodes per request.

Hi @martin-braun did you try the following from the error message?
You can configure how much resources each request takes by lowering your `options.schema.perPage` value from the default of 100
nodes per request.

Hi @martin-braun did you try the following from the error message?
You can configure how much resources each request takes by lowering your `options.schema.perPage` value from the default of 100
nodes per request.

@TylerBarnes Yes I tried that, but it did not work either, which makes sense. If you count up all those entries, they are not even 80 items in total and the perPage option is for each request.
Could you please tell me how I can increase the timeout properly to bypass this issue for now?

Hi @martin-braun did you try the following from the error message?
You can configure how much resources each request takes by lowering your `options.schema.perPage` value from the default of 100
nodes per request.

@TylerBarnes Yes I tried that, but it did not work either, which makes sense. If you count up all those entries, they are not even 80 items in total and the perPage option is for each request.
Could you please tell me how I can increase the timeout properly to bypass this issue for now?

It's also in the error message :)
Alternatively you can increase the request timeout by setting a value in milliseconds to `options.schema.timeout`, the current
setting is 30000.

It's also in the error message :)
Alternatively you can increase the request timeout by setting a value in milliseconds to `options.schema.timeout`, the current
setting is 30000.

https://github.com/gatsbyjs/gatsby-source-wordpress-experimental/blob/master/docs/plugin-options.md#schematimeout-int

https://github.com/gatsbyjs/gatsby-source-wordpress-experimental/blob/master/docs/plugin-options.md#schematimeout-int

https://github.com/gatsbyjs/gatsby-source-wordpress-experimental/blob/master/docs/plugin-options.md#schematimeout-int

Thank you, that link was helpful. I should've taking the message literally. I was assuming the timeout was for each request. If it's supposed to be for all requests then it's too low for my case. No wonder, my instance is small and has not much data, so it starts too many requests, because it won't hit the perPage limit even once.
I think it might make sense to increase the default value to at least 60 seconds to prevent this issue for new projects.
Anyway changing the timeout was successful.

https://github.com/gatsbyjs/gatsby-source-wordpress-experimental/blob/master/docs/plugin-options.md#schematimeout-int

Thank you, that link was helpful. I should've taking the message literally. I was assuming the timeout was for each request. If it's supposed to be for all requests then it's too low for my case. No wonder, my instance is small and has not much data, so it starts too many requests, because it won't hit the perPage limit even once.
I think it might make sense to increase the default value to at least 60 seconds to prevent this issue for new projects.
Anyway changing the timeout was successful.

Ahhh, makes sense :) that's a good suggestion, I'll put it in our backlog as a simple, non-breaking, enhancement. Thanks @martin-braun !

Ahhh, makes sense :) that's a good suggestion, I'll put it in our backlog as a simple, non-breaking, enhancement. Thanks @martin-braun !


general repo and src cleanup

This is one nasty diff...

consistent whitespace (indentation and trailing)
consistent quotes (single)
adds missing semicolons
fixes inadvertent global/undefined vars (or comments where the fix isn't clear)
refactors lodlive.utils, removing unused functions (and updating references in lodlive.core)
cleans up package metadata

I've built and tested these changes locally, and can find no regressions. There are no functionality changes. I'm making this PR now so that future refactoring PRs will have clean diffs ...
Let me know if you want style changes, squashed/split commits, rollbacks, etc.

Wow, thanks for cleaning that all up!


docs(c4model): add c1 and c2 models

Working on a template for C4 models on our handbook. I rewrote the models in Sepes to follow the "future" template

Fixed some wrong texts and a missing link from Study to study specific datasets. Also changed datasts to use the azure storage icons.


Replace DurablePromise union type with single type

Implements the proposed change in
https://github.com/resonatehq/resonate-sdk-ts/issues/126

Codecov Report
Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.44%. Comparing base (7bf23ef) to head (4a05b1a).

Files
Patch %
Lines

lib/core/stores/remote.ts
81.25%
3 Missing :warning:

lib/core/storages/withTimeout.ts
88.88%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   82.63%   82.44%   -0.19%
==========================================
  Files          22       22
  Lines        1399     1401       +2
  Branches      381      356      -25
==========================================
- Hits         1156     1155       -1
+ Misses        243      240       -3
- Partials        0        6       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

The slight reduction in code coverage is expected.


Refresh causes 404 on GH Pages

https://github.com/orgs/community/discussions/27676#discussioncomment-3297224


Handle undefined body when there's a response without one

This is the proper version of
https://github.com/plaid/plaid-node/pull/104 and should resolve https://github.com/plaid/plaid-node/issues/97

Thanks for the build @todoubled - I just enabled CI for fork'd PRs. Could you force push to this branch to trigger a run? My hunch is lint my fail with the equality check / quotes.

LGTM

@todoubled -<EMAIL_ADDRESS>was just published with this fix -- thanks!

Thanks @michaelckelly!


D-side: Watch hh.ru

D-side requests the watch of the watch_keyword hh.ru. See the Metasmoke search here

This was superseded by a watchlist addition with the same intent but correct escaping by Mithrandir. Closing as obsolete.


Fix doc vector average calculation (do not use spacy implementation)

average takes words into account that don't have a word vector
should rather only average over elements that have a non zero vector

https://github.com/explosion/spaCy/blob/master/spacy/tokens/doc.pyx#L276
https://github.com/RasaHQ/rasa_nlu/pull/92#issuecomment-340297739

also I think it should be an option to do max-pooling instead of taking the average

"option" is the good word. One might also want to exclude stop words

No I think this is still the same.


Variable Experience Rollout [Part 1]

Motivation and Context
Adds the core of the training code for VER.
See https://github.com/facebookresearch/habitat-lab/blob/ver-part-1/habitat_baselines/rl/ver/README.md for how this code is laid out.
Each component of the system (expect for the learner, which just the main process) is implemented via a Worker class that spins up the subprocess and has some methods for interacting with the process. The process then runs code in the corresponding WorkerProcess class.
The environment worker, report worker, and preemption decider all operate on an interface defined by their task enum. Tasks are given via a tuple in the form (task, data?) put into the appropriate queue. Each task corresponds to a method name to be called and the data is the arguments to this method (if any).
The inference worker receives tasks as simply the environment ID that is reporting a new step of experience has been generated.
When experience collection and learning aren't overlapped, the main process alternates between acting as an inference worker and learning. When they are overlapped, the main process just learns.
How Has This Been Tested
With the tests.
Types of changes

New feature (non-breaking change which adds functionality)

Minor nit: but are the PNGs available as vector graphic format?

BTW, if the really old version of Torch is complicating this, we have been discussing raising the minimum Torch version.

If we could go to 1.9.1 as the minimum version, that would mean no ugly backwards compatibility hack with DDP and some more efficient code due to torch.count_nonzero.


License

Hi what is the license on this code and can you please include it in the repo?

I have added an MIT license


Maintainer?

Are these repos being maintained any more?
I note that there have been no uploads to https://app.vagrantup.com/box-cutter in over a year.
I'd be willing to maintain the repos and provide CDN space if necessary.
Thanks

I'd personally recommend rebuilding systematically instead of using prebuilt boxes which might contain MitM...

@olberger Yeah, from a security standpoint you are right.
I'll close this out.


WAG:  try to preinstall 'grpcio' on appveyor.

See #1863.

Sorry for n00b question, what is WAG?

LGTM

@dhermes "WAG" -> "wild-assed guess".

Now we cross our fingers and think Good Thoughts(tm).

Horsefeathers.  My cmd.exe fu has withered away like the Marxist state.

@tseaver It failed https://ci.appveyor.com/project/dhermes/gcloud-python/build/1.0.432.master

%CMD_IN_ENV% if "%INSTALL_GRPC%"=="1" (pip install grpcio)
Using default MSVC build environment for 64 bit architecture
Executing: if ""=="1" (pip install grpcio)
'if' is not recognized as an internal or external command,
operable program or batch file.
Command exited with code 1

If we drop testing Python 2.6 on Appveyor, I think we can get away with installing grpcio and the gax-* packages unconditionally.

👍  Dropping Windows Python 2.6 testing is A-OK with me.


TFE should take the chain id from the request URL (vega capsule FE config)

Since getting the latest FE docker containers for vega capsule and re-testing vegacapsule using the frontends config I see the following issue:
When trying to change the URL that its pointing to to get data:

URL = http://<IP_ADDRESS>:3028/query
This then presents me with the following error:
This app only works on chain ID: 1440

It does however seem to work as expected on BE and console (however I have yet to use these dApps in anger).
The correct chain ID is set in the config, but that's for the ganache image. As far as I understand the FE should take the chain id from the request URL.
Originally posted by @gordsport in https://github.com/vegaprotocol/frontend-monorepo/issues/2252#issuecomment-1333795401

@pennyandrews @dexturr
Ive noticed this on mainnet too: This app only works on chain ID: 1
But clicking disconnect and it works OK.
noticed on:
Chrome Version 107.0.5304.110 (Official Build) (arm64)
I do not see the same on safari or brave (maybe a caching thing in the browser, however didn't go away with Apple+Shift+R)

It should be doing this already, we made this change months ago so likely something has gone incorrect during this.


More pending public keys, pretty output

Allow more possible words in the spreadsheet to indicate a pending wallet public key.
Use pretty_to_string for the JSON output, so we don't have to use jq or other beautifier post-hoc.
Tested with the latest spreadsheet.

!approved-for-mainnet


[4.2] Allow '@usableFromInline' on 'dynamic' decls

Explanation: In Swift 4.2 we allowed inlinable functions to reference dynamic declarations regardless of whether they were @usableFromInline, but that breaks assumptions elsewhere in the compiler. We're going to enforce that restriction in Swift 5, but it would break source compatibility at this point to do so in Swift 4.2. This patch allows @usableFromInline to be written on dynamic declarations in Swift 4.2 without requiring it, so that there'll be one spelling that works everywhere.
Scope: Only affects dynamic declarations, but unfortunately any @objc member in an extension is inferred to be one of those.
Risk: Very low. This change removes a diagnostic and does nothing else; all existing code paths should work for the newly-supported code.
Testing: Added a compiler regression test; more testing coming on master.
Reviewer: (pending)

See also #19522.

@swift-ci Please test source compatibility

@swift-ci Please Test Source Compatibility Debug

@swift-ci Please Test Source Compatibility Debug

@swift-ci Please Test Source Compatibility Debug

Build failed
Swift Test OS X Platform
Git Sha - 616d8aa836649a3989ddd094b4c28944382fdf41

Not fair, I grepped for that!

Source compat release build
@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 616d8aa836649a3989ddd094b4c28944382fdf41

Build failed
Swift Test OS X Platform
Git Sha - 616d8aa836649a3989ddd094b4c28944382fdf41

@swift-ci Please test

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 8c64bb5ef6be32a92234c6ff36fe941222d64163

@swift-ci Please test macOS

Build failed
Swift Test OS X Platform
Git Sha - 8c64bb5ef6be32a92234c6ff36fe941222d64163

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 8c64bb5ef6be32a92234c6ff36fe941222d64163

@swift-ci Please nominate

It sounds like at this point even small changes like this aren't being taken because they're not really high-reward. Oh well.


Fix iOS redirect loop

Some iOS users are not able to use the OTP link to log in. They are redirected to a page without any buttons to log in.
Acceptance criteria
1 - Implement a button that redirects the user to the app with the OTP query string.

Barry said it is working properly for him now. No other user reported this error, so I am closing for now.


Fix indexing related fields as FilterField in Elasticsearch

Fixes #4681
When looking in to #4681 I found that our support for indexing related fields by using FilterField directly on the field is a bit broken. All IDs are being coerced to strings by Elasticsearch (causing faceting on tags fields to break) and also Taggit tags fields were indexing the IDs of the through model rather than the IDs of the tags (causing faceting on tags fields to break some more).
This PR fixes these two issues. All related fields now find the actual underlying type of the foreign key and we I've added some extra logic to handle tags fields (note, other many to many fields were being indexed correctly already).

Thanks @kaedroho :)
Still one DB backend issue with the refresh method.

Thanks for improving that PR, Karl!
Unfortunately, it’s still failing on test_facet_tags :cry:

Damn, it works on ES6 now, but not the others...

Do you think we could now remove ES tests from allowed failures on Travis?

We switched them to allowed failure because of transient issues with ES. But yeah, I think we should try it as those issues might be fixed in recent versions.


min/max

Sorry this may be a dumb question, but how does one find the min and max values tracked by the T-Digest?  Is it simply the first and last centroids?   Some comments in other issues and in docs seem to refer to interpolating to a min and max, so it must be tracked somewhere, but there is no min/max method (at least in the Java implementation)

The min and max values are always tracked implicitly by t-digests if you
use a scaling function other than K_0 (default is K_2, used to be K_1). The
current version of the AVLTreeDigest and the MergingDigest actually retain
these values exactly as well. I believe that these values survive
serialization as well.
To get the best estimate of the min use digest.quantile(0), for max use
digest.quantile(1). It would be reasonable to set up min() and max()
methods as aliases for these calls in the AbstractTDigest class. Doing so
would make a very reasonable pull request if you are so inclined.
There has also been some discussion of adding more information to each
centroid, possible min and max, possibly some moment information. Having
this information might make better interpolation possible, for instance.
There has been no progress on that yet.
It has been a point of some interest to explicitly track min and max
On Thu, Jun 6, 2019 at 4:15 PM Evan Chan<EMAIL_ADDRESS>wrote:

Sorry this may be a dumb question, but how does one find the min and max
values tracked by the T-Digest? Is it simply the first and last centroids?
Some comments in other issues and in docs seem to refer to interpolating to
a min and max, so it must be tracked somewhere, but there is no min/max
method (at least in the Java implementation)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tdunning/t-digest/issues/132?email_source=notifications&email_token=AAB5E6S7EALKDD6UMN7PI7TPZGLCNA5CNFSM4HVL6MF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYEOSZQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB5E6WJ635PQ3AZ6F6CFD3PZGLCNANCNFSM4HVL6MFQ
.

The latest (unreleased) code keep the min and max as singleton centroids.
That means that quantile(0) and quantile(1) will return exact results.


support darwin-arm64 platform

@mmaxim

[ ] update release tool https://github.com/keybase/release/pull/45
[ ] update go-updater https://github.com/keybase/go-updater/pull/204


🐛 BUG (Pages): R2 Jurisdiction in wrangler.toml produces failed deployments

Which Cloudflare product(s) does this pertain to?
Pages, R2
What version(s) of the tool(s) are you using?
3.47.0 [Wrangler]
What version of Node are you using?
20.12.1
What operating system and version are you using?
macOS Sonoma 14.4.1
Describe the Bug
Hi @petebacondarwin,
following up to #5377, I tested it and now the bindings, compatibility flags and the compatibility date is set correctly 🎉 However, one little thing is missing:
Observed behavior
When adding a R2 binding to a Pages wrangler.toml specifying an R2 bucket with a jurisdiction and deploying that using npx wrangler pages deploy, I get This deployment failed in the dashboard:

When using a bucket without jurisdiction, the deployment works. Nowhere in the docs can I find that buckets with Jurisdicion cannot be used from Pages.
Expected behavior
It works in Pages like in workers ;-)
Steps to reproduce
wrangler.toml:
name = "my-app"
compatibility_date = "2024-03-04"
compatibility_flags = ["nodejs_compat"]
pages_build_output_dir = ".svelte-kit/cloudflare"

[env.preview]
r2_buckets = [
    { binding = "R2_ATTACHMENTS", bucket_name = "attachments", jurisdiction = "eu" },
]

Interestingly, the UI too has a bug there: When editing the settings of projects which are not configured using wrangler.toml, buckets with jurisdiction don't appear in the dropdown:

I'd expect to see my other buckets there, too. This has already been reported on discord, but I had hoped that the recent changes had fixed that ;-)
This is the only thing which is blocking me from migrating a couple of apps to Cloudflare Pages ;-)
Thanks for looking into this.
If you need anything else for testing, just let me know - happy to help.
Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
No response

This is a known issue with the Pages backend service, tracked with internal tickets WC-2034 and WC-2101
Tagging with "pages" label but since one of those tickets has been marked as done cc @GregBrimble @WalshyDev – can you confirm if this issue is still outstanding?


No results found

I think @Bars92 already create branch that fixes all sections, need to open PR from it, can you check this?


cifar10_model.pt file not found

When I try to open https://drive.google.com/file/d/1Mt_o6fZOlG-VDF3Q5ModgnAJ9W6f_av2/view?usp=sharing, I cannot find the file cifar10_model.pt.

I can not find both ptb_model.pt (https://drive.google.com/file/d/1Mt_o6fZOlG-VDF3Q5ModgnAJ9W6f_av2/view?usp=sharing)
and imagenet_model.pt (https://drive.google.com/file/d/1AKr6Y_PoYj7j0Upggyzc26W0RVdg4CVX/view?usp=sharing) as well😥

I also can not find these files. Did you find them......

I also can not find these files. Did you find them......
I also can not find these files. Did you find them......

the same problem. I wanted to reproduce the code and the results to study the possibility for running darts on tabular dataset. unfortunately


@include ltr(){} produce an error

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
[x] bug report
[ ] feature request
[ ] support request
Current behavior:

in my component.scss i'm trying to support ltr and rtl directions, so I did this:
myComponent {
@include ltr(){
.someClass {
text-align: right;
}
}

@include rtl(){
.someClass {
text-align: left;
}
}

}

then it shows me this error:

no mixin named ltr

Other information:

global packages:

    @ionic/cli-utils : 1.3.0
    Cordova CLI      : 7.0.1
    Ionic CLI        : 3.3.0

local packages:

    @ionic/app-scripts              : 1.3.7
    @ionic/cli-plugin-cordova       : 1.3.0
    @ionic/cli-plugin-ionic-angular : 1.3.0
    Cordova Platforms               : android 6.2.2 ios 4.4.0
    Ionic Framework                 : ionic-angular 3.3.0

Hello! Thanks for opening an issue with us! As this seems like more of a support question I will urge that you ask this question on our forum or on our slack channel. Thanks for using Ionic!


access conflict

When use the ManualLayout library, the view's x/y/width/height is conflict. and without origin/size/center/centerX/centerY.
https://github.com/isair/ManualLayout

Hey @tospery :)
I viable solution to that is to do adjust your imports in a way to disambiguate the use of the properties. Meaning, you choose one ManualLayout or SwifterSwift and add the specific import to get rid of the naming symbol conflict.
Example:
import var SwifterSwift.height

For more information, see the discussion on #645


Fix: Missing platform and description

Description

Fixes missing platform and description entries for cookies in the output csv file.
Relevant Technical Choices

Testing Instructions

Switch to branch fix/cli-output
Run npm install to install dependencies
Run npm run cli:build to build the tool
Run npm run cli -- -u <url> to analyze a website. This should create 2 csv and 1 json files in dir ./out with cookies and technology data.
Run npm run cli -- -s <url> to analyze a sitemap. CLI should output the number of pages in the sitemap and how many of them needs to be tested. This should create 2 csv and 1 json files in dir ./out with cookies and technology data.

Additional Information:

Screenshot/Screencast

Fixes #

@ayushnirwal Is this ready for review?


Why do the attached scripts run _process even though it is disabled? This is when _ready() is used in the scripts. Is it a bug?

Godot version
Godot 4-beta13
System information
Linux, KDE Neon, OpenGL3, Mesa Intel(R) UHD Graphics (CML GT2)
Issue description
Why do the attached scripts run _process even though it is disabled? This is when _ready() is used in the scripts. Is it a bug?
I would like to disable the _process completely even though _ready() has been used.
I have created a minimal example in which the problem is shown, if it is...
Steps to reproduce
I have made a short example of this... in the MRP
Minimal reproduction project
InheritedWithReady.zip

You are overriding _ready, so your base ready will no longer be called.
Use _init instead and don't override it.

Ohh thanks, I am going to try that

There is no need to await ready.

The process must be set inside ready, you are doing it correctly. Just call the base method in your inheriting class:
func _ready():
	super()
	print(name)

@KoBeWi According to the documentation, that only applies to the input related toggles.

Which documentation?

NVM, I was looking at set_process_internal


Gizmo renderer

Testing using this PG: #CN8VII#16
TODO:

[ ] Make gizmo meshes great to look at
[ ] Scale gizmo
[ ] Gizmo hotkeys
[ ] Utility layer render before/after post processing
[ ] Test it more real world scenarios

https://github.com/BabylonJS/Babylon.js/issues/4141

Closing for now as I add controller ray support


Migrate from com.intellij:annotations to org.jetbrains:annotations

What problem are you trying to solve?
The com.intellij:annotations package was relocated to org.jetbrains:annotations after v12 (2013)
This caused confusion and many teams are unaware and still using the old coordinates.
Describe the situation after applying the recipe
There are various examples, but here is one :
import com.intellij.annotations.NotNull

-import com.intellij.annotations.NotNull
+import org.jetbrains.annotations.NotNull

Good suggestion, and should be an easy change. Could even fold that under the existing efforts we have for nullability annotations

https://github.com/openrewrite/rewrite/issues/2838
https://github.com/openrewrite/rewrite/pull/3084

This would go beyond nullability as there are many other annotations within that package. I supposed that we can target nullability as a first step

So I'm seeing a number of different artifacts related to this:

https://mvnrepository.com/artifact/com.intellij/annotations v12
https://mvnrepository.com/artifact/org.jetbrains/annotations v24.0.1
https://mvnrepository.com/artifact/com.jetbrains/annotations v2022.3

The oldest and smallest 1 seems to have moved to 2, while 3 contains a smaller subset of 2.
All three seem to use org.jetbrains and org.intellij as packages though; didn't spot any com.intellij in any. Where did you see those?

Since there's multiple classes and artifacts involved here I'd suggest we start with a declarative recipe that changes GAVs and package names, such that users are able to switch from older dependencies to latest. Likely something that best fits into rewrite-migrate-java until we have a better place for these.
Should possible to mostly compose these through https://app.moderne.io/recipes/builder and add some tests for good measure.
I expect the use of

https://docs.openrewrite.org/recipes/java/dependencies/changedependency
https://docs.openrewrite.org/recipes/java/changepackage

Could you provide the details on what older GAV had the com.intellij package previously, and perhaps even a starter for the recipe replacements?


Fixes and introduction of additional variables

I looked through your dotfiles project and i am impressed. Nice work!
I tried to make it a bit easier for other developers to get into the project. The main change were to introduce USER_PATH and DOTFILES_PATH variables which allow the developer to circumvent the absolute paths.
Also i changed the brew installs since brew cask install is deprecated and replaced by brew install --cask.
I also updated the brew-install.sh script, since, as far as i could find out, the  brew search command is now expecting an argument.
Further questions that came up during my refactorings:
1. If i run man on any command i don't get the full man page, as i'm used to. In the cases i tests, only the examples are returned. Is this a wanted setting, and if yes, where can i change it?
2. brew-cask.sh is using fzf-tmux. I couldn't really fix this similarly to brew-install.sh since i didn't knew how it should exactly work. Could you maybe describe how it worked previously, or what the expected functionality is?
3. The settings.zsh is trying to execute a z.lua file which isn't included in the project. Is there a reason for this?

Added functionality for switching java versions with fzf


File not marked as resolved after using command palette to stage file

Does this issue occur when all extensions are disabled?: Yes/No
Yes

Version: 1.63.2
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:37:28.172Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 19.6.0
Steps to Reproduce:

Start a git action that causes file X to have conflicts
Resolve the conflicts
Use the command palette to do the git.stage command
Observe that the file is still displayed as having conflicts.

@Nokel81, apologies for not getting back to you on this until now. I was wondering if you are still able to reproduce this issue? Thanks!

I haven't noticed exactly the same bug I have noticed that I cannot mark files that I delete during a merge as "resolved" if they initially had some git conflicts. I have to fallback to use the git CLI.

@Nokel81, would you be able to provide a recording (https://gifcap.dev) so that I can further investigate the issue? Thanks!

Closing the issue as I was never able to reproduce this and investigate further.


initialize()/postInitialize() order between components wrong on initially disabled entity

I think I found a bug in the initialize()/postInitialize() order when later enabling an entity that was disabled when the app was started. To make matters worse, my app was still working with PlayCanvas 0.218.0 ded6028 and now isn't with 0.219.3 f5f75ce, so I assume it was introduced in the meantime. (I'm using the PlayCanvas editor so I can't roll back to check.)
When an entity has two scripts, I would assume the following on start:

Script A initialize()
Script B initialize()
Script A postInitialize()
Script B postInitialize()

And indeed that's what happens if the entity is enabled at start.
With PlayCanvas 0.219.3 f5f75ce, the following happens when the entity is disabled at start, but is enabled later:

Script A initialize()
Script A postInitialize()
Script B initialize()
Script B postInitialize()

I built a minimal example project to demonstrate the problem. Launch it, open the console and press space to enable the second object.

Thanks this was introduced with this commit https://github.com/playcanvas/engine/commit/294a2ce6b9ff3f2116471fb5abb089f0bd648fcb which is attempting to fix a bug when individual scripts are enabled. We will have a look at fixing this as soon as possible.

Hey Is this related to this issue ?
https://forum.playcanvas.com/t/entity-clone-not-deep-cloning-attributes/5374

I'm not sure but can you both check launching your application using this query parameter in the launch window URL:
?use_local_engine=https://code.playcanvas.com/playcanvas-latest.js
This will load the latest master branch where I've reverted that change. Let me know if this fixes your problems.

Yes, this seems to fix the issue

@afk-mcz I would appreciate it if you could provide a test case for what your problem is exactly because I'm not sure I understand exactly what's broken in your situation. That's so we can fix it :) Thanks

@vkalpias Yes, it fixes the problem I describe here.

I'm deploying a new version of the engine right now without the offending commit until we figure out what's wrong exactly.

@vkalpias I tried to replicate it on a new blank project but I couldn't. I think I have a post Initialization script around that triggers the object initialization, and maybe it's getting called in the wrong order, and that's why my objects are not getting initialized.
I changed a lot of files trying to figure out the initial problem, so right now it's a little bit hard to reproduce in another project, will try later if the bug continues.

I deployed engine v0.219.4 which does not have this bug - if you could PM me a link to your project in the forum I'd appreciate it so at least I can have a look at what might be wrong there.

@vkalpias PM'd you


Update definitions to nomad 1.4.3

I don't know if that's the kosher way to specify a different go version (newer nomad requires 1.19), but it seems to work for me with the changeScript now.
Leaving it as a draft, so you can have a point of comparison for the changes.

looks great, thanks!


Trigger animation from ViewModel

Is it possible to start the animation from the ViewModel?

@jsuarezruiz ?

You can create a trigger with a Command BindableProperty, bind the command and init the animation. Similar to https://github.com/jsuarezruiz/AlohaKit.Animations/blob/main/src/AlohaKit.Animations/Triggers/BeginAnimation.cs, but with one command. We can add it to the library.

Can you help us provide a small example?
We still don't understand what you are describing.

Cab you help us with an example, im also looking for a way to start an animation at the opening of a page without a trigger or a scroll.

@hiroian Take a look at the example below and give it a try!
https://github.com/jsuarezruiz/AlohaKit.Animations/assets/54387261/7c057dc2-ed8e-422f-91a9-305c8771d5c9
    <ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
             xmlns:alohakit="clr-namespace:AlohaKit.Animations;assembly=AlohaKit.Animations"
             x:Class="PageLoadAnimation.MainPage">
    <ContentPage.Resources>
        <alohakit:ScaleToAnimation
            x:Key="ScaleToAnimation"
            Target="{x:Reference ImageBot}"
            Duration="10000"
            Scale="2.0"/>
    </ContentPage.Resources>
    <ContentPage.Triggers>
        <EventTrigger Event="Loaded">
            <alohakit:BeginAnimation
                Animation="{StaticResource ScaleToAnimation}" />
        </EventTrigger>
    </ContentPage.Triggers>
    <ScrollView>
        <VerticalStackLayout
            Padding="30,0"
            Spacing="25">
            <Image
                x:Name="ImageBot"
                Source="dotnet_bot.png"
                HeightRequest="185"
                Aspect="AspectFit"
                SemanticProperties.Description="dot net bot in a race car number eight" />

            <Label
                Text="Hello, World!"
                Style="{StaticResource Headline}"
                SemanticProperties.HeadingLevel="Level1" />

            <Label
                Text="Welcome to
.NET Multi-platform App UI"
                Style="{StaticResource SubHeadline}"
                SemanticProperties.HeadingLevel="Level2"
                SemanticProperties.Description="Welcome to dot net Multi platform App U I" />

            <Button
                x:Name="CounterBtn"
                Text="Click me"
                SemanticProperties.Hint="Counts the number of times you click"
                Clicked="OnCounterClicked"
                HorizontalOptions="Fill"/>
        </VerticalStackLayout>
    </ScrollView>
</ContentPage>

Thanks @lukewire129 ! Exactly what i was looking for!
Already implementing it in my project! 😃


Change underscores in route paths to dashes

Context
Underscores can be confused with spaces if they are printed out with an underline beneath the URL.
Changes proposed in this pull request
Update the route paths.
Guidance to review
Should we set up redirects for the old URLs?
Link to Trello card
None.
Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

@steventux yes, that's what I was wondering about as well when I suggested redirects. All the involved URLs are fairly "transactional" however, one being a POST for example. I don't think strongly one way or the other, if someone else reading this could also chip in one way or the other?

Yeah, I'd just set up some redirects. It's a good habit to get into anyway. Also solves situation for when people view a page, then we deploy, and then they click a link.

Updated with 301s!


Spam Domain Submission

Duplicate Domains

[X] Yes, I checked that the domain is not currently in the list
[X] I read the wiki explaining each different categories and examples before submitting

(Required) Spam Comment Direct Link
https://www.youtube.com/watch?v=DdZBfuJYqpc&lc=UgyNULuTkvwhuEj2Qx14AaABAg
(I noticed that these scam videos have a lot of spam comments)
(Optional) Screenshot of comments using the domain

(Required) List of the spam domains
rr.fafa.bar

added


Remove overrides of isStreaming() and getAppName() in SparkPipelineOptions

isStreaming() is already default to false implicitly, since it is not set.
getAppName() defaults to the name of the class that constructs the PipelineOptions via the PipelineOptionsFactory.
I think both should work in Spark. And, I see no reason to override them.

R: @amitsela @lukecwik

Can also remove https://github.com/apache/incubator-beam/blob/master/runners/spark/src/main/java/org/apache/beam/runners/spark/SparkStreamingPipelineOptions.java#L40 in that case.

Done - removed getAppName in SparkStreaming options.

Default values based upon which interface you invoke is generally not a good idea as the value will be "set" based upon which interface you invoke. Thus we should remove isStreaming() from SparkStreamingPipelineOptions.

LGTM

Waiting for Jenkins/Travis and will merge.


added car prediction model in your repo

< Car Prediction model>
Description

Motivation and Context
<I made this project to help 2nd hand car diller>
How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ *] My code follows the code style of this project.
[ *] My change requires a change to the documentation.
[ *] I have updated the documentation accordingly.
[* ] I have read the CONTRIBUTING document.

hey @its-puneet can you please merge my PR under Hacktoberfest


req.ip gives the wrong ip when trust proxy is enabled

Using express 4.17.1.
According to the docs for req.ip, if trust proxy is enabled, then it should be "derived from the left-most entry in the X-Forwarded-For header."
https://expressjs.com/en/api.html#req.ip
Which is what I would expect, e.g. if I have
X-Forwarded-For: <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>
then I would expect req.ip to be <IP_ADDRESS>. But what I'm actually getting is the right-most one, <IP_ADDRESS> in this example. My goal is to get the real client ip, which is the left most one.

Thanks. I must be setting trust proxy incorrectly or something. I'm setting it this way:
app.set('trust proxy', true);
I'm debugging through it on my side and will let you know what I find.

I found the issue, one of my libraries is overriding the trust proxy I'm setting. I apologize for the noise. Thank you for your time.


Bringing tiny general docs fixes to all localisations in umbrella PRs

This is a Feature Request
What would you like to be added
Sometimes we bring tiny corrections in the original (English) docs, such as fixing an outdated link. The current workflow is to merge them there, and things seem to be done. It's only later and quite occasionally/randomly when such updates get to other languages one by one… and they probably, never land everywhere.
E.g.:

This is how we end up with:

#38534,
#38543,
#38585,
#38594.

This case: #38862 — is similar but a bit more tricky. It's not just a link, but also requires having dates written in the relevant language, so this approach should not include such kind of changes.

For me, it sounds more reasonable to a) get the change approved for the English version first and b) immediately after it's approved, bring it to all other localisation at once. We can do it in two PRs (one for English and another one for all other languages together) or maybe even in one, so one actual change will be presented in the only place.
Why is this needed
This approach will help us:

Reduce the number of small-sized, identical PRs and people involved in creating/reviewing them.
Make such documentation fixes more consistent throughout all localisations available.

Comments
The obvious drawback is that each localisation team might miss such changes getting into their localisation. However, if the change is so minor and doesn't affect the language itself (just an URL or some specific English term), it doesn't sound like an issue to me. Maybe, a simple way to notify all localisation teams' owners in such "umbrella PRs" will be helpful, though.

You'll need to get every localization team to agree to change their workflow to match what you're proposing here, @shurup. If we can do that, then this change is easy to make.

@shurup, exactly what @sftim said. To my mind, the main issue here is visibility and reviewing. Localizations are set up so only approved language reviewers are able to review/approve on content and merge PRs. This makes sure that folks within the localizations teams know about the changes and have the ability to raise any concerns about the change before the PR is merged into the docs.
In the case of an umbrella PR like you are describing, I think we need to figure out

Who is the reviewer/approver on the PR? If its multi-language, which language gets assigned to review by the bot?
Does the PR bot allow a reviewer of another language to review/approve PRs for different languages?

I think this is something worth investigating more to get feedback from other localizations, @shurup are you able to make it to the next localization meeting February 6th to talk more about this topic? We can also chat more async in this issue (and slack) :)
/area localization

In the case of Chinese localization, we treat each page a minimum unit for synchronization from en to zh-cn. Every time we update a page, we require a full resync of the whole page. We check if a page is out-of-sync by comparing the date of the latest commit. The detection is performed using the scripts/lsync.sh tool.
When a minor change A is merged to an English page content/en/docs/foo/bar.md, we need to check ALL the changes before the content/zh-cn/docs/foo/bar.md was last updated. In many cases, there could be other changes B and C merged to the English version, before A is merged. Next time when a PR is proposed to content/zh-cn/docs/foo/bar.md, we need to make sure that PR has incorporated A, B, and C. We will reject "partial update PRs", .i.e. PRs that only synchronize change A.

I agree with all the valid points Abbie, Qiming, and Time made. Adding my two cents below,

As a co-chair: I'd love for this to happen to reduce the number of incoming PRs. The only challenge is gaining consensus from all the localization leads.
As a localization approver/reviewer: The review/approve cadence, processes, and content consistency across localizations differ. In the case of trivial umbrella PRs, one of the manual overheads I foresee is the content consistency part. Every time we open such a PR, there will be a need to coordinate and figure out the localizations for which the file is present. If it is not present, we can, of course, leave it as-is. But suppose we explore the route of having the file created & associated content updated to improve consistency across localizations. In that case, we will need to discuss this in further detail.  Additionally, as @a-mccarthy correctly pointed out, we will need approval after all the localization leads sign off. Discussing who would be the POCs to do that might be of merit too.

We chatted about this a bit in our last localization meeting. Two concerns that were raised were

Some localization teams prefer to resolve these kinds of issues within their localization using the same processes they use for all other changes
The scope of these kinds of PRs could not include any word changes. If the PR contained any translated words, then it's best to keep the separate PR for each localization model that we have now to help make sure that translations are valid.

Based on the majority of the feedback we have gotten on this issue, I'm thinking that this is not something we will be adopting because it introduces too many non-trivial changes to established processes for what we would be gaining.
I'm happy to continue chatting about this if folks have different thoughts :)

First of all, I am incredibly sorry I brought this issue to wide attention and immediately disappeared :sweat_smile:
Many thanks to everyone for your input; it was super helpful! Based on it, I can see this idea doesn't seem to be reasonable enough. So I'm happy to close this issue with a better understanding of why we are where we are. Thank you for summing it all up, @a-mccarthy!
I also like very much the idea of full resyncs that is used by the Chinese team. Such practices are definitely worth sharing with other teams. It's quite off the original topic, but is the localisation experience of different teams documented anywhere? I know some issues are discussed during the meetings and in Slack, but having some kind of "localisation best practices knowledge base" would be amazing. I think it would be overkill for the existing https://kubernetes.io/docs/contribute/localization/ page since it focuses on more general things. Maybe we can start by creating one more "child" page to accommodate the approaches and techniques different localisation teams use to deal with different tasks? Not as a guideline, but as an existing experience you might consider trying in your team. Or maybe there is a better way to do it, and we'd better discuss it elsewhere.

There is a sig-docs-localizations Slack channel, and there is a community meeting for localization teams to gather and share experiences. However, some of the practices are not applicable to all teams because the practices are closely related to how the team tracks changes. For smaller/inactive teams, there could be a dedicated branch for batch translation/syncs. For larger/active teams, the localization may be even tracking the latest changes to the English content. For this and other reasons, each team may have their own protocols on managing terminology, content style etc. For example, the scripts/lsync.sh tool is heavily used by the Chinese localization team because it is closely tracking the latest changes, based on the timestamp of the last commit. It can handle different languages, but it doesn't mean it should be recommended to teams which are working on an older release that is behind the current one.

Thanks, @tengqm! I am aware of Slack and meetings. My idea was to create very basic documentation giving a brief introduction to those practices as a bit more formal way to share the experience. It could have become a starting point for those who are looking for ways to establish or improve their own workflows. Not even as a recommendation but just as an option to consider — it can be adopted/modified or not used at all, of course.

@shurup Thanks for raising this issue! I think we've had a lot of valuable discussions around this topic and it brought up some great points on different localization's processes.
I agree that sharing the ideas and processes from different teams can be very useful and it's one of the main reasons why the localization subproject was formed :) I'm not sure that putting them into the main kubernetes website is the best place, though, because there are a lot of variables to consider and reasons why a localization has adopted certain practices (as @tengqm pointed out). The website contribute section is usually a place where we describe set or prescribed processes everyone should follow.
These might be better as blog posts, where a localization can share their experiences and practices. Or some other place that talks about the sig practices, like the kubernetes/community repo, https://github.com/kubernetes/community/tree/master/sig-docs.
In terms of this issue, I think we are ok to close it. We can continue to chat about processes in Slack and in the meetings, and figure out the best way and place to collect these ideas as well

Thanks, Abigail! I'm closing the issue.
The kubernetes/community repo seems to be the right place for what I'm suggesting. Will investigate it more thoroughly a bit later.

If a change is very high value to the Kubernetes project, I hope we'd consider making an exception to our usual policy and consider having a PR that touches multiple localizations. This should not be the norm; rather, it'd be something we save for rare and important cases such as a high-impact security notice.

If a change is very high value to the Kubernetes project, I hope we'd consider making an exception to our usual policy and consider having a PR that touches multiple localizations. This should not be the norm; rather, it'd be something we save for rare and important cases such as a high-impact security notice.

Good point.


feat(tutorial): complete step 5 Hursley

https://carbon-tutorial-chrisdudley.mybluemix.net

:+1::skin-tone-2: Looks good - I have recorded your completion of this step!


minDate can't use state

<DateTimeField onChange={(x) =>{this.setState(d: moment(x,'x'))}}/>
<DateTimeField minDate={this.state.d}/>

This code can't normal use，change the this.state.d, minDate don't work

Same here the minDate is not working on my end as well


Define a data format for CEN reports.

These reports will be collected by the backend, randomized, and collected into a static file pushed to a CDN.  It's important to make each report as compact as possible, because it will be downloaded by every client.
Some of the details of the report data are set by the exact mechanism for CEN generation, but others seem less clear (to me).  In particular, if the protocol is supposed to be relatively application-agnostic, it seems important to have flexibility regarding the report contents built in from the beginning, because there will be no opportunity to change it later.
Should the report contents just be length-delimited binary data? What information is needed to distinguish symptom reports from infection reports? What if there are multiple entities (e.g., different health authorities) who produce infection reports?

Hamish Rodda has a very COVID-19 specific design (see data models repo) with a nested structure (temperature, spO2) to approximate the way a real doctor (as he is) would approach it.  There is no way a free text system is a good idea, but most of Hamish's approach can be mapped into language-independent "symptom concept" flags (where symptom space is approximated by integers that can be mapped back into a persons native language) and an expanding array of presumably genetically sequencable diseaseID (you can have rabies, you can have rabies A, or rabies B, or rabies C).    In a federated model of CEN servers, the CEN reports would then have a set of integer bits for both symptoms and diseases and the readers of the data would then query a dictionary to map symptom and disease concepts.
There are many health standards already and ideally we would just be able to shop for something but this is a novel corona virus so we would like a specific mechanism for it to be somehow have been creatable without a standards body by someone in Dec 2019-Jan 2019 rather than well after that.

The memo format in #20 can encode small chunks of arbitrary data, depending on the application, so that different applications can use different encodings, as works for them. In the worst case, if some application needs to encode a large amount of data for some reason, they can encode an ID into the broadcast that their client can use to fetch the body of the message.

Closing as resolved by the current report format.


Navbar UI

Description:
Navbar's look is not minimal and it's too thick and overlapped with Homepage background Image
Reason for Change:
To enhance the overall look of the website and improve the user experience.
Current Styling:
Working on padding and height of Navbar.
Also giving some space on top of image.
Please assign me this issues.
Gssoc Contributor.

I want to work on this issue of Navbar UI. Please, assign me this issue.


SpringFormEncoder is not well supported

I checked the documentation of feign-form.
It supports:
interface SomeApi {
  // Group all parameters within a POJO
  @RequestLine("POST /user")
  @Headers("Content-Type: application/x-www-form-urlencoded")
  void addUser (User user);
}

But the following code does not work properly:
@FeignClient(name = "test", url = "http://localhost:8080")
public interface TestFeign {
    @PostMapping(value = "/test", consumes = MediaType.APPLICATION_FORM_URLENCODED_VALUE)
    String test(TestEntity test);
}

Exception:
Caused by: feign.codec.EncodeException: Could not write request: no suitable HttpMessageConverter found for request type [com.example.demo.TestEntity] and content type [application/x-www-form-urlencoded]

But using SpringFormEncoder as Encoder can solve this problem:
@Configuration(proxyBeanMethods = false)
public class FormSupportConfig {
    @Bean
    public Encoder feignFormEncoder(ObjectFactory<HttpMessageConverters> messageConverters) {
        return new SpringFormEncoder(new SpringEncoder(messageConverters));
    }
}

I found that the code that caused the problem came from here:
https://github.com/spring-cloud/spring-cloud-openfeign/blob/58b0c7866c3675f8b6cece0746948dcf98f4ef64/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/support/SpringEncoder.java#L98-L101
Here only the type of mutipart is checked and the type of urlencoded is ignored.
But this type will be processed by the parent class FormEncoder of SpringFormEncoder.

Hi @Junzzzz ,
Did you check @SpringQueryMap annotation?
https://cloud.spring.io/spring-cloud-openfeign/reference/html/#feign-querymap-support

Thanks for your reply @cbezmen
I tried this annotation, and its function is to splice the parameters into the URL instead of putting them in the Request Body.
Actually:
[TestFeign#test] ---> POST http://localhost:8080/test?bar=456&foo=123 HTTP/1.1
[TestFeign#test] Content-Type: application/x-www-form-urlencoded
[TestFeign#test] ---> END HTTP (0-byte body)

Expect:
[TestFeign#test] ---> POST http://localhost:8080/test HTTP/1.1
[TestFeign#test] Content-Length: 15
[TestFeign#test] Content-Type: application/x-www-form-urlencoded; charset=UTF-8
[TestFeign#test]
[TestFeign#test] bar=456&foo=123
[TestFeign#test] ---> END HTTP (15-byte body)

Hi @Junzzzz
I don't know why you don't use 'Content-Type: application/json' and want to use 'Content-Type: application/x-www-form-urlencoded'. In your problem Spring encode can't find possible converter because You didn't put any annotation to your input. So It will think like @RequestBody and try to parse your object as body. In addition to this It can't find right converter so it throws "Could not write request: no suitable HttpMessageConverter found for request"
Anyway I figured out your request and example code should be like this. I think you should put @RequestPart annotation to your code and it will work like charm.
@FeignClient
public interface TestClient {
    @PostMapping(value = "/user", consumes = MediaType.APPLICATION_FORM_URLENCODED_VALUE)
    User test(@RequestPart User test);  // You should put @RequestPart annotation here
}

@RestController
@Slf4j
public class TestController {
    @PostMapping(value = "/user", consumes = {MediaType.APPLICATION_FORM_URLENCODED_VALUE})
    public User test(User test) {
        log.info(test);
        return test;
    }
}

@Data
public class User {
    private String name;
}

// Just call you
User user = new User();
user.setName("Can");
testClient.test(user);

Thank you for your enthusiastic help @cbezmen
I tried the following code, but still can't find a suitable HttpMessageConverter
@EnableFeignClients
@SpringBootApplication
public class DemoApplication {
    @Autowired
    TestClient testClient;

    public static void main(String[] args) {
        SpringApplication.run(DemoApplication.class, args);
    }

    @Bean
    public ApplicationRunner test() {
        return args -> {
            User user = new User();
            user.setName("Can");
            testClient.test(user);
        };
    }

    @FeignClient(name = "test", url = "http://localhost:8080")
    public interface TestClient {
        @PostMapping(value = "/user", consumes = MediaType.APPLICATION_FORM_URLENCODED_VALUE)
        User test(@RequestPart User test);  // You should put @RequestPart annotation here
    }

    @RestController
    @Slf4j
    public static class TestController {
        @PostMapping(value = "/user", consumes = {MediaType.APPLICATION_FORM_URLENCODED_VALUE})
        public User test(User test) {
            log.info(String.valueOf(test));
            return test;
        }
    }

    @Data
    public static class User {
        private String name;
    }
}

I looked through some documents and couldn't find a suitable annotation. Later, I found that SpringFormEncoder contains support for this type, and it doesn't need any annotations. However, this type is ignored in SpringEncoder, and this function is not well supported. I guess it may be ignored when encapsulating, so I submitted this issue.
I already have a solution, just mention this problem.

By the way, I use feign as an HTTP request tool, because the code is very concise and it is supported by Spring. However, the requested API is relatively old, so this type has to be used.
I don’t know if Google Translate clearly expresses what I mean, sorry.

Hey @Junzzzz, Sorry for late reply because of weekend.
I think I figured out your problem. You can checkout this link. https://stackoverflow.com/questions/35803093/how-to-post-form-url-encoded-data-with-spring-cloud-feign
I also commit my test repo to https://github.com/cbezmen/junzzzz.
import feign.codec.Encoder;
import feign.form.FormEncoder;
import feign.form.spring.SpringFormEncoder;
import lombok.Data;
import lombok.extern.slf4j.Slf4j;
import org.springframework.beans.factory.ObjectFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.ApplicationRunner;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.boot.autoconfigure.http.HttpMessageConverters;
import org.springframework.cloud.openfeign.EnableFeignClients;
import org.springframework.cloud.openfeign.FeignClient;
import org.springframework.cloud.openfeign.support.FeignEncoderProperties;
import org.springframework.cloud.openfeign.support.SpringEncoder;
import org.springframework.context.annotation.Bean;
import org.springframework.http.MediaType;
import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.RestController;

@SpringBootApplication
@EnableFeignClients
@Slf4j
public class JunzzzzApplication {

    public static void main(String[] args) {
        SpringApplication.run(JunzzzzApplication.class, args);
    }

    @Autowired
    private TestClient testClient;

    @Bean
    public ApplicationRunner test() {
        return args -> {
            User user = new User();
            user.setName("Can");
            User test = testClient.test(user);
            log.info("{}", test);
        };
    }

    @FeignClient(name = "test", url = "http://localhost:8080", configuration = CoreFeignConfiguration.class)
    public interface TestClient {
        @PostMapping(value = "/user", consumes = MediaType.APPLICATION_FORM_URLENCODED_VALUE)
        User test(User test);
    }

    class CoreFeignConfiguration {
        @Bean
        Encoder feignFormEncoder(ObjectFactory<HttpMessageConverters> messageConverters, FeignEncoderProperties feignEncoderProperties) {
            return new FormEncoder(new SpringEncoder(new SpringFormEncoder(), messageConverters, feignEncoderProperties));
        }
    }

    @RestController
    @Slf4j
    public static class TestController {
        @PostMapping(value = "/user", consumes = {MediaType.APPLICATION_FORM_URLENCODED_VALUE})
        public User test(User test) {
            log.info(String.valueOf(test));
            return test;
        }
    }

    @Data
    public static class User {
        private String name;
    }
}

Hey @OlgaMaciaszek,
His code not working because of the code below. It will automatically support if wee add MediaType.APPLICATION_FORM_URLENCODED_VALUE. Do you think it is logical? I can add and test it if you want?
https://github.com/spring-cloud/spring-cloud-openfeign/blob/280291ec93111fc690e8479c607c8615e61c5194/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/support/SpringEncoder.java#L210
private boolean isMultipartType(MediaType requestContentType) {
	return Arrays.asList(MediaType.MULTIPART_FORM_DATA, MediaType.MULTIPART_MIXED, MediaType.MULTIPART_RELATED)
				.contains(requestContentType);
}

@cbezmen yes, makes sense. Could you please verify if everything works correctly with that change and submit a PR?


Refactor new date picker

Details
This pull request introduces significant improvements to the Date Picker component by refactoring the codebase and implementing logic changes. The main objectives are to enhance reusability by removing navigation.
Fixed Issues
$ https://github.com/Expensify/App/issues/20630
PROPOSAL: https://github.com/Expensify/App/issues/20630#issuecomment-1597567254
Tests

Go to Date of Birth in Personal Details
Select the year (nothing changes in the input)
Select month (nothing changes in the input)
Click on the day (the date is changing in the input)
Change the month using right-left arrows (nothing changes in the input)
Click on the day (the date is changing in the input)

[x] Verify that no errors appear in the JS console

Offline tests
No offline tests needed.
QA Steps

Go to Date of Birth in Personal Details
Select the year (nothing changes in the input)
Select month (nothing changes in the input)
Click on the day (the date is changing in the input)
Change the month using right-left arrows (nothing changes in the input)
Click on the day (the date is changing in the input)

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/24796318/2905b43c-a216-41a7-9d90-7522a22d3c42

Mobile Web - Chrome
https://github.com/Expensify/App/assets/24796318/c4a646ef-7435-46d7-9590-14361c1b3550

Mobile Web - Safari
https://github.com/Expensify/App/assets/24796318/daef224d-66b7-4ddf-8a5a-e9b863950c97

Desktop
https://github.com/Expensify/App/assets/24796318/ef4d914b-15b1-4d29-a40e-e065badabd32

iOS
https://github.com/Expensify/App/assets/24796318/3a3bb5ff-d401-4474-a950-c46982101290

Android
https://github.com/Expensify/App/assets/24796318/10aa39da-71f5-4669-b648-d7ae2c74890e

@fedirjh Can you reproduce the issues with animations for the year picker which Arek mentioned? SWM was not able to repro
Also Arek is ooo so I have bumped Callstack and someone else will pick this up from tomorrow. @fedirjh lets please priotize this review and testing so we can ideally get this merge by EOW 🙇  thank you 🙇

Thanks for confirming hopefully we wont be blocked on hat then

Hey @fedirjh! Regarding this:

Hey there @ArekChr , We have some bugs :

When Selecting a Year or a Month, it doesn’t update the date

It's intended - please check this slack thread: https://expensify.slack.com/archives/C049HHMV9SM/p1687425911714009

Overall code looks good, I have only one concern raised here

@fedirjh's suggestion works great. So we can stop worrying about the animation issues since we're ditching ScreenSlideAnimation in favor of Modal (I couldn't reproduce the issue anyway). Left a video of the Modal implementation in the thread above

We are missing prop definition for this component.

Little prop fix

Same here

Fixed all propTypes pointed out

Extra horizontal margin for the years selector

Fixed. Also, in Phase 2 of the Selection Lists refactor (which I'll continue working right after we get this one merged), I'll be replacing OptionsSelector here for SelectionList, the new standardised component for selection lists

Text selected upon clicking arrows or calendar icon

Working on this last remaining issue ⬆

I believe I have everything ready now. We're contacting Arek to get me permissions to push to his branch, but if we can't until tomorrow morning I'll raise a new PR

@thiagobrez love this, thank you 🙇

@fedirjh Pushed the fixes, let me know what you think 🙌🏻

thanks for the reviews and testing so far. great job, lets egt this done on Monday 🎉

@fedirjh Sent fixes to all your latest comments! :)

I see that some unit tests failed and I'm working on it 👍🏻

Fixed 👌🏻

@fedirjh Great job on the review and thanks @thiagobrez for acting fast!

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.39-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Awesome work! Love the simplification.

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.39-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


'this' banned term conflicts with Typescript's function this-types

I'm finding that the function level this-type introduced by Microsoft/TypeScript #6739 is triggering the "noReservedKeywords" rule.
Using this example from the PR
interface I {
  n: number;
  method: (m: number) => number;
}
function futureMethod(this: I, m: number) {
  return this.n + m;
}
let o: I = { n: 12, method: futureMethod };

The this-type feature of TS declares the futureMethod has having one parameter (m) and that the
"this" object within its scope implements interface I.
But instead it has a tslint error:

[tslint] Forbidden reference to reserved keyword: this
(parameter) this: I

It feels like a special exception is needed for the this keyword, to allow for function this-types.

I see that this rule will interface with the Polymorphic this Type described here: http://www.typescriptlang.org/docs/handbook/advanced-types.html
I don't see any official documentation on the feature you mention. Is it a TypeScript 2.0 feature?

Now that TS 2.0 is out, I can confidently say that yes it is going to be included.
They're mentioned in the release notes under "Specifying the type of this for functions"


v1.8.0 bug cannot use "enter" keyboard

when i select the one item, and click keyboard "enter"
it cannnot change to Adapter or Device

Can you perhaps record a GIF/video to better highlight the issue?

Can you perhaps record a GIF/video to better highlight the issue?

i never use record video, i just use flameshot

Since you have not provided information about the issue clearly, this issue will be closed. You can reopen it after editing your issue description with more details, and supplement it with a recording.


Can this be used with an RPi Pico?

I'm not a fan of ESP32's. But I love RPi Pico's.  I havn't checked the pinout yet, so I'm asking if this board could be used with a Pico(W)?

Probably yes, but it will, of course, require rewiring of the extension headers. Also, if you want to use I²S, then the Pico must provide the I²S clock and I don't know if it can do that. And the software need to be adapted too, so it won't be super easy. Please let me know if you succeed.


wifi: specify password over stdin

I don't like having my passwords end up in bash_history. It would be cool if there would be an option to read password from stdin.

+1. Maybe a t2 wifi -i or --interactive option?

when passing the -p with no value, it should wait for password on stdin.

I think the default way to enter your password should be interactive input with no password printout, with a warning about clearing history if the user runs the command with the wifi password as an argument. The default way of doing things shouldn't compromise security.

@wprater @LinusU take a look to our discussion about the interactive solution

:+1:
I am in favor of @wprater's suggestion.

@sdaitzman are you working on this currently?

@johnnyman727 I'm not, but I might have enough free bandwidth to pick it up this weekend. I'm not at all familiar with the codebase in this repo but I do write a lot of js 😄

@sdaitzman t2-cli uses the inquirer module for interactive parts of the tool: https://github.com/SBoudrias/Inquirer.js/ so you can familiarize yourself ahead of time :)

It looks like @rwaldron may have fixed part of it by obfuscating command output in 928894c but I don't believe that the password can be submitted via stdin in yet (and don't have a Tessel with me to test). @rwaldron can you confirm?

@johnnyman727 is correct. There is no way submit a password via stdin yet.

Does this feature still need developing? I would like to take it


Gathering metrics in label-studio gui

Hi! Do you have a plans for add metrics to label studio ml backend?

What metrics do you expect ot see

i mean custom metrics. For example i want to append mAP50 from my training scripts to gui. So i can return model_path and custom_metric which will show in text blok or somthing like this.

We don't have this specific plans, but you can easily add TextArea to your labeling configuration and pre-fill it with values from ML backend with some metric values. Do you mean something like this?

@makseq yes i do

Does it solve your problem?

Yes i found your's examples, thank you.
May be somebody needs:
https://github.com/heartexlabs/label-studio-ml-backend/blob/master/label_studio_ml/examples/the_simplest_backend/model.py
return {
                'prediction_example': prediction_example,
                'also you can put': 'any artefact here'
            }


gitleaks - Add example tokens to allowlist

The problem:
There is a critical bug in gitleaks-action v1.3 - it will always green even it found leaks. For example, this.
This left the door open for a long time until recently we upgraded gitleaks-action from 1.3 to 1.6. To be precise, it fixed in v1.4.0.
Proposed changes:

A follow up fix for #9108
Instead of adding file to allowlist/whitelist, use regex to filter pattern under corresponding rules.

TODOs

[X] Scanned the current codebase
From rasa directory, scan the current context by:

$ gitleaks --path=. -v --no-git --config-path=$(pwd)/.gitleaks.toml

...

INFO[0027] scan time: 27 seconds 540 milliseconds 335 microseconds
WARN[0027] leaks found: 12

Note: all of the leaks are test tokens/example APIs. Nothing to worry about.

[x] Update rules for all fake credentials that should be allowed by gitleaks

Merge this PR should fix the failure in here.


Added parsing of images for RSS items

Content (or summary if no content) is analyzed for  tags, the URLs of images are then stored in MWFeedItem.images

Hi ,
First thanks for this Great open source
I begin Development iphone and maybe my question is for newbi so my question is :
i try to get a image to put in cell.imageview.image, this is my code :
    cell.imageView.image=[item.images objectAtIndex:indexPath.row];

But the application crach if you can help me
Thanks

item.images contains URLs of images, not images themselves, that's why it doesn't work.
To show image given its URL you for example can use Network Image from Nimbus framework – http://latest.docs.nimbuskit.info/group___nimbus_network_image.html

@vgrichina Thanks for this pull request. I'm going to be implementing image parsing soon but in a slightly different way. Check back soon!


analyzer: Support for historical aggregate data

SUMMARY
As of #132 we can collect time series data about blocks, transactions, and events. This is easy to do with materialized views since by storing blocks and transactions we are naturally persisting historical data from which aggregates can be constructed.
However, for other types of time series data such as:

total escrow at a given point in time
total number of delegators at a given point in time
total stake held by validator with the most stake at a given point in time

We are unable to do this as we store current data for staking, registry, governance, etc. backends. We must collect this data during the indexing process, and this can be done via a checkpointWorker that runs every k processed blocks and computes an aggregate data point for every additional time series we want.
ISSUE TYPE

Feature Idea

COMPONENT NAME
storage analyzer

For validator staking history this was done in https://github.com/oasisprotocol/nexus/pull/703
For other types of data this is currently not planned.


feat(fixtures): Hardfork Execution Test Fixtures

Description
With the opt8n tool successfully generating execution test fixtures in the fixtures/execution/ directory, the next step is to generate a bunch of test fixtures and document the process along the way.
This ticket is to generate execution test fixtures surrounding the various network upgrades aka hardforks.
To properly test hardfork execution behavior, we need test fixtures that assert correct behavior both prior to the hardfork and after it's enabled.
Hardforks (listed in specs.optimism.io)

Regolith
Canyon
Delta
Ecotone
Fjord

Currently blocked by https://github.com/foundry-rs/foundry/pull/8749
Will come back to this when that's merged in.


Annotations location

Accoring to http://nbviewer.jupyter.org/gist/santosjorge/f3b07b2be8094deea8c6
" Annotations can be added to the chart and these are automatically positioned correctly. "
Is it possible to set more attribution of the annotations like multiple-annotations  in plotly ?
https://plot.ly/python/text-and-annotations/#multiple-annotations
Because  the annotations can't positioned correctly sometimes

Thank @t0mst0ne , you are right this seems to happen with OHLC charts. I'll try go get a fix asap.

Thanks !

@santosjorge When would it be fixed? I was about to post annotation problems, but found out this post already dealt with it.

I am currently working on the new version of candlesticks/ohlc charts recently released by plotly (which don't use shapes). I will ensure this work in these new type. I should have it done next week.
Thank you.

You can now try the following
cf.datagen.ohlc().iplot(kind='candle',annotations={'2015-02-02':'Market Crash'})
cf.datagen.ohlc().iplot(kind='ohlc',annotations=[{'text':'Manual annotation','x':.2,'y':.5,'xref':'paper','yref':'paper'}])

Great !

Forgot to mention you can also customise how they look:
cf.datagen.ohlc().iplot(kind='ohlc',                         annotations=[{'text':'Manual annotation','x':.2,'y':.5,'xref':'paper','yref':'paper'},                                     {'text':'Another annotation','x':.5,'y':.7,'xref':'paper','yref':'paper'}],                        fontcolor='blue',fontsize=15,textangle=-45,ay=-100)


Template support over N rows expand next page

maybe it can cache worksheet first, if over page size then paste it


Add Selector option to Reliably Agent

This PR adds a --selector/-s flag to the reliably agent command allowing the user to select specific group(s) of objective(s) to be processed by the agent.

added label selector to getobjectives call
added --selector flog and parsing function

ref: #588

Hey @daidokoro
Thanks for this. I've made change internally (I will push today) where the selector is base64 encoded before being sent. The rationale is that the naive approach can lead to parsing failure of the query string (I have for instance a label which value contains = and , signs).
What selector should do now is actually as follows:

Create a k,v mapping (the labels type is good as-is that is)
Json encode it (json.Marshal)
Base64 encode the result (using base64.URLEncoding.EncodeString(labels)
Sent a query string like this: selector=<BASE64> so that

This prevents edge cases that aren't so uncommon.
wdyt?

Hey @daidokoro
Thanks for this. I've made change internally (I will push today) where the selector is base64 encoded before being sent. The rationale is that the naive approach can lead to parsing failure of the query string (I have for instance a label which value contains = and , signs).
What selector should do now is actually as follows:

Create a k,v mapping (the labels type is good as-is that is)
Json encode it (json.Marshal)
Base64 encode the result (using base64.URLEncoding.EncodeString(labels)
Send a query string like this: selector=<BASE64> so that

This prevents edge cases that aren't so uncommon.
wdyt?

Thanks @Lawouach , I'd say this is a good idea. There should also be some validation in place preventing special characters in label really, not sure we want symbols like = or , in labels.

WXe can't avoid it it. For instance, for objective results, the prometheus query is used in labels. Such queries can contain any sort of characters.