Commented PDFs

@ejmaginn @drroe @jrelliottoh @dcarls0n
Please upload a PDF with your suggested changes to the manuscript. After we have reviewed the suggestions, we will decide which ones to implement.

Great, thanks @drroe
OK, I have attached a PDF with my response to DRR's comments along with my own initiated comments. @ejmaginn  @drroe @dcarls0n @jrelliottoh please add your responses to our comments, either on this PDF or a separate one. Once we have all provided feedback we will start modifying the TEX file.
EMD_DRR_RAMcomments.pdf

I'll address minor comments in this Issue to avoid too many versions of the PDF flying around. I'll reproduce the existing comment and any responses to provide context.

Page 2: "Many codes such as LAMMPS [23] and GROMACS [18] have analysis tools that automatically estimate transport properties..."

DRR - Can add CPPTRAJ to this list (Roe & Cheatham 2018 JCTC, 10.1021/ct400341p

ram9 -  was going to include CPPTRAJ, pyTraj, MDTraj, etc. but those tools are strictly for post-simulation analysis. This sentence refers only to simulation packages that also have built-in analysis tools. If we include CPPTRAJ we probably want to modify this sentence to say, "Many analysis tools exist that automatically estimate transport... such as CPPTRAJ, MDTraj, pyTraj, and the built-in analysis tools for LAMMPS and GROMACS."

I think it's fine not to mention all the individual analysis tools, but if we mention LAMMPS and GROMACS we should at least mention Amber and CHARMM as well. Could also mention NAMD but since VMD is really more of a separate analysis tool and not "part" of NAMD this could go either way.

Table 1. Equilibrium molecular dynamics equations.

DRR - These equations should be generalized to N dimensions, i.e. 2nD = lim(t->inf) MSD/t, etc, since it is not uncommon to want diffusion in 1 or 2 dimensions as well (as is discussed later on in the document).

ram9 - If we generalize by dimensions we probably need to change the r_i notation so that it is alpha_i, since r denotes a three dimensional vector. Or we could say r_alpha,i to signify r in the alpha direction, since we already use that in our definition for tau.
What symbol is best for number of dimensions? We already use N and D. I think little n is not very descriptive. What about N_dim?

I think we should change N to M and then use N for number of dimensions

Page 8 - "The second approach is to estimate the infinite system self-diffusivity from a single simulation using an analytic correction factor proposed by Yeh and Hummer [37]."

DRR - It should be noted that the immersed boundary approach for correcting diffusion for PBC (ref 9, Camley et al) can reproduce Yeh & Hummer's results (discussed in Appendix C that reference) and may be more appropriate for condensed phase anisotropic systems like membranes. There is also a website available that provides corrections to D using this model: https://diffusion.lobos.nih.gov

ram9 - Do you want to add this to section 5.4 where we discuss membranes as a special topic?

I think that's fine as long as it is mentioned. Let me know if you'd like me to add it directly.

I'll address minor comments in this Issue to avoid too many versions of the PDF flying around. I'll reproduce the existing comment and any responses to provide context.

Good idea

I think it's fine not to mention all the individual analysis tools, but if we mention LAMMPS and GROMACS we should at least mention Amber and CHARMM as well. Could also mention NAMD but since VMD is really more of a separate analysis tool and not "part" of NAMD this could go either way.

I agree that we should mention Amber and CHARMM if we are mentioning LAMMPS and GROMACS. Maybe we just want to rewrite this sentence so that we do not need to mention any by name (although we will include a reference for them). We could say something like "Many simulation packages include built-in analysis tools that automatically estimate transport properties, while other post-simulation analysis tools also exist, e.g. Refs [x-y]."

I think we should change N to M and then use N for number of dimensions

I hesitate to use M for molecules, because that is somewhat inconsistent with using NVE, NVT, NPT ensemble notation. I don't think people want to use MVE, MVT, MPT, or even N_molVE, N_molVT, N_molPT. @ejmaginn @dcarls0n @jrelliottoh Any other options or opinions?

I think that's fine as long as it is mentioned. Let me know if you'd like me to add it directly.

Yes, you can add it directly. I would wait to push your changes until everyone has had a chance to read through the document though. Maybe on Friday?

I will try to get to this by Thursday morning. I am a little swamped today and tomorrow, but I have been following the exchange. One thing I would suggest is to let N = number of molecules. M is confusing, as Rich correctly mentions. People often use "d" for the number of dimensions. I recommend that.

Here are my comments / edits.
Ed

On May 1, 2018, at 11:40 AM, Richard Messerly<EMAIL_ADDRESS>wrote:
Great, thanks @drroe https://github.com/drroe
OK, I have attached a PDF with my response to DRR's comments along with my own initiated comments. @ejmaginn https://github.com/ejmaginn @drroe https://github.com/drroe @dcarls0n https://github.com/dcarls0n @jrelliottoh https://github.com/jrelliottoh please add your responses to our comments, either on this PDF or a separate one. Once we have all provided feedback we will start modifying the TEX file.
EMD_DRR_RAMcomments.pdf https://github.com/ejmaginn/TransportCheckList/files/1964261/EMD_DRR_RAMcomments.pdf
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/8#issuecomment-385702926, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXerQ7SXiEm5kOQAUopv3dKid5P5Uks5tuIHTgaJpZM4TtJql.

@ejmaginn
I don't see any comments. Did you mean to attach them to your previous post?

I thought I did attach but maybe not. I’ll try again in a bit.
Sent from my mobile device
On May 2, 2018, at 5:34 PM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn
I don't see any comments. Did you mean to attach them to your previous post?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ejmaginn/TransportCheckList/issues/8#issuecomment-386128708,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJKiXU9UjwvT9vLoawGnKaD-vTVwvczGks5tuiZpgaJpZM4TtJql
.

Can you see them now?
Edward Maginn
Dorini Family Professor and Department Chair
Department of Chemical and Biomolecular Engineering
University of Notre Dame
Notre Dame, IN 46556 USA
cbe.nd.edu
<EMAIL_ADDRESS>@ejmaginn
view my papers: https://goo.gl/kgMMBe

On May 2, 2018, at 5:34 PM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn
I don't see any comments. Did you mean to attach them to your previous post?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/8#issuecomment-386128708, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXU9UjwvT9vLoawGnKaD-vTVwvczGks5tuiZpgaJpZM4TtJql.

@ejmaginn
I don't see it anywhere. Are you trying to attach a PDF or upload it to the repository? To attach a PDF you should be able to just drag and drop it. When you click Preview do you see a link to the PDF?

I was just trying to send as an email. I uploaded it to the repository now. Hopefully you can now see it.
Edward Maginn
Dorini Family Professor and Department Chair
Department of Chemical and Biomolecular Engineering
University of Notre Dame
Notre Dame, IN 46556 USA
cbe.nd.edu
<EMAIL_ADDRESS>@ejmaginn
view my papers: https://goo.gl/kgMMBe

On May 3, 2018, at 9:29 AM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn
I don't see it anywhere. Are you trying to attach a PDF or upload it to the repository? To attach a PDF you should be able to just drag and drop it. When you click Preview do you see a link to the PDF?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/8#issuecomment-386295654, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXWZ0O2iWFDJsVFFgBRSBitHh7lniks5tuwY1gaJpZM4TtJql.

@ejmaginn
OK, I have moved your marked PDF to this issue (see attachment), since I don't think we want it in the repository.
EMD_DRR_RAM_EJM_comments.pdf

Thanks. I see. I am a newbie on how this works. Sorry about that!

On May 3, 2018, at 9:43 AM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn
OK, I have moved your marked PDF to this issue (see attachment), since I don't think we want it in the repository.
EMD_DRR_RAM_EJM_comments.pdf https://github.com/ejmaginn/TransportCheckList/files/1971091/EMD_DRR_RAM_EJM_comments.pdf
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/8#issuecomment-386300001, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXcxrz0RXb1HwEbuWFwwOnfFEDI83ks5tuwmHgaJpZM4TtJql.

@ejmaginn
That is totally fine. This is not standard protocol to begin with.
Alright, so we have comments from @drroe @ejmaginn and @ramess101.
@dcarls0n and @jrelliottoh are you going to provide some feedback before the end of the week? Specifically, could you opine on the comments raised in the EMD_DRR_RAM_EJM_comments.pdf?

Apologies! Classes have started again. I will finish my review and provide any feedback by the end of the day.

I added only a few comments (find them in the sections I've listed below):
Sec 6:
-Advocating @ramess101 's Einstein suggestion when replicate simulations are expensive
6.1.4:
-Quoted the section of the Daivis paper explaining the "os" superscript for clarity
-Raised some clarity concerns regarding the use of Figure 8 in showing the importance of using  all six independent components of the stress tensor vs three terms
6.2.1 (Model fit to running integral) :
-Pointed out a font inconsistency
6.3.1:
-Again commented on the Einstein recommendation to be made
EMD_DRR_RAM_EJM_DJC_comments_5-3-18.pdf

Alright, thanks everyone. I think this is all the feedback we are going to get for now. Next Monday I will provide the manuscript to the NIST reviewers. Then, if we get a quick enough turn around, it could be approved for submission by the following Monday (5/14), but no later than 5/21.
@drroe Is it alright if I go through and make all the easy changes right now? Specifically, the changes that I recommended or that were pretty simple fixes. And then I will notify you later today so you can add your changes directly to the LaTex file? I think I should be done in 2-3 hours.

Sounds good.

@drroe
As you probably noticed, this took longer than expected due to a myriad of different issues (mostly not related to this manuscript). However, I have now pushed my changes for the LaTex file and PDF. I have attached my response PDF for all of the comments mentioned previously. You will note that I left you most of the changes that your proposed. Let me know if you have any concerns or questions.
Also, I am still working on fixing the bibliography. Any suggestions are welcome.
EMD_v1_5_comments_addressed.pdf

@drroe
Could you give me a time table for when your changes will be completed? I would like to submit this article to the NIST interval review board as soon as possible, i.e. today or tomorrow. If that is unreasonable for you just let me know, because it is not a big deal to submit the manuscript even if some small changes are made after the fact. I just want to get the process started so we can submit to LiveCoMS by next week.
Thanks

@drroe
No problem. Tomorrow would be great. I hope you get to feeling better.

My changes have been pushed. Note that I only updated the .tex and .bib files - the software I'm using for PDF generation ran into some issues (maybe because I'm on Linux?), so I didn't try to update that as well.  Let me know if you see any problems or have questions.

@drroe
Looks great! The PDF and other files are now updated.
It is now with the NIST reviewers, Arno Laesecke and Alta Fang. We will hear back from them before the end of the week.


Handle PlaceOrders reply rsponse error

Hi guys,
I copy codes of handle_place_order_reply function from sei-tester, but it can't work in my project.
I got an error in my handle reply code:
Error parsing into type MsgPlaceOrdersResponse: failed to parse data)

I saw the sei dex module handle reply is not as same as cosmwasm-std，may i take a mistake or miss something?
how to fix it?
thanks

I found integration-tests in sei-tester with Cosmos::Custominstead ofSeiMsg::PlaceOrders, also don't use PlaceOrders in ExecuteMsg insei-tester`。
I'm curious why ExecuteMsg::PlaceOrders wasn't used directly. Can someone explain?

Hi Ishoo, are you still seeing this issue. Sei-cosmwasm was updated recently. What version of cosmwasm-std are you using? We use cosmwasm-std version 1.1 and haven't tested with later versions

There hasn't been any updates on this issue. If there are still issues here / concerns, please just re open another issue. Closing this.


wip: add snapshot

Now that we've moved all the datasets from archives.ipfs.io to Awesome IPFS, @Stebalien was concerned about the xkcd one where we only have an IPNS link. We can add an immutable version and the date of the snapshot too.
An idea:

Other idea could be to add a small history/clock-like button in the button with a link to an immutable version.
Thoughts?
/cc @koalalorenzo @Stebalien @olizilla

I'd have a separate icon but I'm fine with either.

I also would prefer a clock-like icon. I'll do that!


Add api for cerebrum to support dynamically configuring algorithm

Is your feature request related to a problem? Please describe.
refer to #60

Support complement algo replace
Add config algorithm API, CRUD, save in DB
DB > config file > default
refact post_processing

Describe the solution you'd like
fastapi
Describe alternatives you've considered
N/A
Additional context
N/A

已在 dandelion 添加算法 API
https://github.com/open-v2x/dandelion/pull/158


hero 7 black instruction

I have a hero 7 black and had an issue while firing up this cmd sudo gopro webcam it says  v4l2loopback could not be unloaded. There is maybe an ffmpeg(or similar) running that uses this module.
I indeed installed this v4l2loopback and used for droidcam to use my android device as a webcam but I also want to use my gopro as a webcam too.
Thanks.

This does not work for GoPros below Hero 8. GoPro 4-7 need a HDMI adapters and some kind of capture card.
Source: https://gopro.com/en/us/news/how-to-use-gopro-for-webcam

Hi @irowbin, unfortunately, the HERO7 will not be supported because it does not have the GoPro Connect/webcam mode feature.


Overriding with context manager (one and multiple providers)

I implement two little features for ease of use during tests:

overriding one provider with a context manager. Now you can use it like this:

# old way
some_provider.override(mock)
some_provider.reset_override()

# new way
with some_provider.override_context(mock):
    ...

overriding multiple providers with a context manager. Now you can use it like this:

mock_1 = ...
mock2 = ...

# old way
container.provider_1.override(mock_1)
container.provider_2.override(mock_2)
# do something
container.reset_override()

# new way
providers_for_overriding = {
    "provider_1": mock_1,
    "provider_2": mock2,
    # more providers...
}

with container.override_providers(providers_for_overriding):
    # do something

@nightblure looks great, thanks!

we lose coverage on this line after I removed omit. is it acceptable to add pragma no cover here?

we lose coverage on this line after I removed omit. is it acceptable to add # pragma: no cover here?

yes, it's ok

thanks for the review! corrected according to your comments, please take a look

hmm, there is still a question about updating the documentation. I can try to add the relevant sections myself if you allow, or you will do this

@nightblure would be great if you'll add docs as well, but it's up to you. Anyway, thank you for your contribution!

@nightblure would be great if you'll add docs as well, but it's up to you. Anyway, thank you for your contribution!

ok I'll try to do it. within the current MR or separate?

@nightblure better in separate, I'll merge this


Skip command unless, modified files match glob pattern

We are running static analysis on the code, in pre-push hook. This takes a few minutes to complete.
I want to skip running static analysis on PHP files, unless the modified files contains files matching the pattern {*.php,composer.lock,phpstan.neon}.
Is it possible to skip running a command, unless the modified files list matches a glob pattern? I tried setting the glob setting to the above pattern, but it did not skip the command.

Hey! Thank you for the issue! Could you provide your lefthook.yml?
The skipping happend when you provide {files}, {push_files}, {staged_files}, or {all_files} in run option. Otherwise lefthook just executes the run command.
Also if you provide a files option which is a git command to get the desired files, lefthook will skip execution if the result of this command is empty.
Anyway, you can send your lefthook.yml, and I will tell you more concrete ways to fix this. Of course, it can be a lefthook bug :)

Thank you for the explanation. Here is my lefthook.yml
pre-commit:
  scripts:
    pre-commit-hook:
      runner: bash

post-checkout:
  scripts:
    post-checkout-hook:
      runner: bash

pre-push:
  scripts:
    phpstan-check:
      glob: "{*.php,composer.lock,phpstan.neon}"
      runner: bash

I see! Indeed, lefthook doesn't skip execution for scripts if there is a glob. I think this is a missing feature. I will prepare a fix soon.

Hey! I recalled that scripts option does not have a glob suboption. It is only for commands. I guess you want to filter the files you are trying to push, and apply phpstan-check if there are matches. That's a quick fix for you case. Lefthook initially didn't support glob for scripts.


How to drop gorm-generated join tables

Your Question
I can drop a normal table like this:
db.Migrator().DropTable(model)

But I don't know how to drop join tables associated with a model without specifying it as a string like this:
db.Migrator().DropTable("users_x_workplaces")

The document you expected this should be explained
the site.

Expected answer
I want to be able to drop join tables associated with a model using the model itself instead of a string.

use this.
db.Migrator().DropTable("users_x_workplaces")

I'm asking it if there is a way to do it without specifying the tablename as a string.
Instead I want to be able to use the model object. Something like this:
db.Migrator().DropWithJoinTable(&User{})

or
db.Migrator().DropTable(&User{}).WithJoinTable()

or something like that.
I have a use case where I want to demigrate all the tables and join tables generated by Gorm without having the user specifying the auto-generated join tables.


Numbering of solutions doesn't work in drafts

Every solution has number 1.
https://adaptarr.naukosfera.com/drafts/3f3175f8-cfbc-4a8e-af4e-5bf0a7170f66

Do they stay at 1 after you focus (place cursor in) the editor?

@MartaSztuka Could you check if this issue still occurs?

Issue does not occur anymore.


Fix type stability issue with linear interpolation #113

The fast path for linear interpolation when no interpolation is needed (time point is provided in vector) returned a different type which caused issues with types/performance with higher level code.
I ran some benchmarks and see no difference in performance.

I'm not sure if I'm going about this the right way but it works.

Note this changes how the derivative works.  With the fast-path change the derivative of the LinearInterpolation at the exact time point is zero (from ForwardDiff) while previously it was the derivative of the current point and the next.

Note this changes how the derivative works.

Good point. Hopefully people don't rely too much on the derivative here. If they did then they should probably consider a different interpolation. However, you could also consider restricting the branches to when isnan(ret). That was your original motivation anyway and will leave the derivative the way it used to be.

The derivative at the exact point is but undefined but I think it is better to stay consistent with before and if they depend on the derivative they should probably use a better interpolation scheme.   I've seen other tools use the average slope from either side for this but that seems like a different/hack interpolation method to me.

Good point. Hopefully people don't rely too much on the derivative here.

They do more than they expect. For example, the ODE solver will differentiate at those points if using a stiff ODE solver, and it will step there if it's in a tstop. So this is actually pretty important. But, we already have frule and rrule overloads, it's just for ForwardDiff. This fixes potential ForwardDiff issues too, so it's a pretty good change.

I've seen other tools use the average slope from either side for this but that seems like a different/hack interpolation method to me.

The derivative on the right would be preferred due to the ODE solver context.

@GlenHertz can you do a patch bump?

@ChrisRackauckas I'm not sure what a patch bump is but I added another commit for the derivative fix.
I'm trying to get my code to work with NaNs and I ran into this odd case:
t = 0:3;
u = [0, -2, -1, -2];
A = LinearInterpolation(u, t);
dA = t -> ForwardDiff.derivative(A, t)
dA(NaN) # returns -1.0

It is because if NaN is given then the idx will be the second last one and it will load real points from the vectors and then it has a derivative.   I'll work on a patch.

The tests fail right now because using a NaN input for t with Integer vector doesn't compute....I'll get back to this tomorrow.

Test that the derivative at a point gives the derivative to the right?


public expandedRow = CustomRowComponent;

public expandedRow = CustomRowComponent;
not passed to let factory = this.componentFactoryResolver.resolveComponentFactory(this.type);
class GtExpandingRowComponent
this.type is undefined
this.row is correctely valued
in app.module i have defined
import module and entryComponents: [ CustomRowComponent ],

What's your markup for the component that uses generic table? Sounds like you might be forgetting to pass the custom row component to your table.


API redesign

Taking a stab at #52, I had the exact same API in mind before I saw that issue. Currently it's just a basic draft but it works for the most basic case.

AFAICT I've implemented all the features of the current library, and added a couple of things which could be moved into separate PRs to simplify review. Those are

the incremental running API which is shown in the progress.zig example test,
the getSystemInfo change which makes it use only stack (4KB though) and static memory so no need for an allocator,
and the writeJSON functions.

I made a Runner abstraction which does the job of the old run() function but its advantage is it removes all I/O from it, making it functional and much more easily testable, you can just pass in whatever nanosecond values you want in tests and the runner's responses will be deterministic. I think this is worthwhile but it could be removed and just stick with the one-shot run function which does its own time measurement I/O.
I can take out those three changes for now but I might hold off on making PRs for them to avoid needless conflicts if some version of this PR gets merged.
I'd love a thorough review, there's obviously a lot changed but I wasn't able to make small changes to get to the desired API. Reviewing the diffs probably won't be very helpful, best just to check out the branch and play around.

Ok, I've moved those three features to separate branches based on this api-redesign branch, so they can wait for later I think. The diff is a little less onerous now...

One last request, can you update the README. Since the config changes a bit 👍


feat(error-reporting): WARN user about batch source errors

Example:
WARN: Source t1 (table_id=A00213) skipped 12423 rows due to parse error:
  skipped 12342 rows due to: ParseError: numeric out of range
  skipped 103 row due to: ParseError: Error message suppressed
  skipped 42 rows due to: ParseError: Json syntax error
  skipped 1 row due to: ParseError: Json failed to parse at character 0
  skipped 1 row due to: ParseError: Json failed to parse at character 4
  skipped 1 row due to: ParseError: Json failed to parse at character 3
  ...

however, due to some practicalities of accumulating the warnings, we may possibly have:
WARN: Source t1 (table_id=A00213, actor_id=12) skipped 12423 rows due to parse error:
  skipped 12342 rows due to: ParseError: numeric out of range
  skipped 103 row due to: ParseError: Error message suppressed
  skipped 42 rows due to: ParseError: Json syntax error
  skipped 1 row due to: ParseError: Json failed to parse at character 0
  ...
WARN: Source t1 (table_id=A00213, actor_id=13) skipped 20423 rows due to parse error:
  skipped 20342 rows due to: ParseError: numeric out of range
  skipped 103 row due to: ParseError: Error message suppressed
  skipped 42 rows due to: ParseError: Json syntax error
  skipped 1 row due to: ParseError: Json failed to parse at character 6
  ...
WARN: Source t1 (table_id=A00213, actor_id=14) skipped 40423 rows due to parse error:
  skipped 40342 rows due to: ParseError: numeric out of range
  skipped 103 row due to: ParseError: Error message suppressed
  skipped 42 rows due to: ParseError: Json syntax error
  skipped 1 row due to: ParseError: Json failed to parse at character 3
  ...

This is actually an optional feature (optimization). Hence, it is set as a priority. The default behaviour for batch errors is to throw an error, including those originating in the source.

Not ideal but we will report in cloud portal instead; the engineering effort to support this may not be worth it.


Responsive grid

Hey!
I may not understand the "rework-flex-grid" properly.
.gridClass {
  /* ... */
}

.gridClass-rowClass {
  /* ... */
}

.gridClass-rowClass-columnClass {
  /* ... */
}

@media screen and (min-width: 32rem) {
  .gridClass-rowClass-columnClass--sm {
    /* ... */
  }
}

In this example where do the digits indicating the number of columns go?

Ah, sorry. That's a poorly concocted example on my behalf. More thorough stubs look something like (straight from the Furtive source which was generated by rework-flex-grid):
.grd {}

.grd-row {}

.grd-row-col-1-6 {}

.grd-row-col-2-6 {}

.grd-row-col-3-6 {}

.grd-row-col-4-6 {}

.grd-row-col-5-6 {}

.grd-row-col-6 {}

I kept the example in the rework-flex-grid documentation a bit ambiguous because things like columns, class names, and media query breakpoints are all configurable.  When I get a chance, I will update the documentation a bit to make things more clear.
I hope this sufficiently answers your question!

Totally!  I think I am getting how this all joins together.  I guess this is all so that you can render many grids to your CSS?
Is .grd-row-col-3-6--sm effectively equal to .grd-row-col-3-6?
Also I notice that furtive.co has no lg and md in the css... Is that something that has to be set?

Yeah, pretty much. I use the rework-flex-grid lib in numerous projects so I can generate a particular grid with the classes/columns/breakpoints that are appropriate for a project (allowing me to maintain the grid in one central location). Since my primary intention is to keep Furtive lightweight, a flex grid is the perfect fit. Using rework-flex-grid means I don't have to write the CSS. I'm lazy, :smile_cat: . Instead, all I have to do is configure a task:
gulp.task('rework-grid', function() {
  return gulp.src('scss/_grid.scss')
    .pipe(replace(/\.*/, ''))
    .pipe(clean())
    .pipe(rework(
      grid({
        numColumns: 6,
        classNames: {
          grid: 'grd',
          row: 'row',
          col: 'col'
        }
      })
    ))
    .pipe(gulp.dest('scss'));
});

This way, when there are updates to the grid system, I just need to upgrade the npm package and rerun the task. Down the road, I also intend on shifting all of furtive to a rework system with single use modules, I've begun some of the work already: https://github.com/furtivecss.
The furtive.co CSS has been run through gulp-uncss so those classes won't exist in the built CSS for the site. However, if you look in the main distribution CSS file, you will see all the grid classes.

Got it! I was just using the furtive.co version when playing.
Thanks!
On Jan 9, 2015 1:19 PM, "John Otander"<EMAIL_ADDRESS>wrote:

Yeah, pretty much. I use the rework-flex-grid lib in numerous projects so
I can generate a particular grid with the classes/columns/breakpoints that
are appropriate for a project (allowing me to maintain the grid in one
central location). Since my primary intention is to keep Furtive
lightweight, a flex grid is the perfect fit. Using rework-flex-grid means
I don't have to write the CSS. I'm lazy, [image: :smile_cat:] . Instead,
all I have to do is configure a task:
gulp.task('rework-grid', function() {
return gulp.src('scss/_grid.scss')
.pipe(replace(/.*/, ''))
.pipe(clean())
.pipe(rework(
grid({
numColumns: 6,
classNames: {
grid: 'grd',
row: 'row',
col: 'col'
}
})
))
.pipe(gulp.dest('scss'));
});
This way, when there are updates to the grid system, I just need to
upgrade the npm package and rerun the task. Down the road, I also intend on
shifting all of furtive to a rework system with single use modules, I've
begun some of the work already: https://github.com/furtivecss.
The furtive.co CSS has been run through gulp-uncss
https://github.com/ben-eb/gulp-uncss so those classes won't exist in
the built CSS for the site. However, if you look in the main distribution
CSS file
https://github.com/johnotander/furtive/blob/master/css/furtive.css, you
will see all the grid classes.
—
Reply to this email directly or view it on GitHub
https://github.com/johnotander/furtive/issues/39#issuecomment-69375020.


response authentication: fetch root key for dev instances

Fetch from the status endpoint.
dfx will need to control whether this is necessary (the "for dev instances" part)

This is done, isn't it?

Yes, this is done.


Prep release 3.0.3

Codecov Report

Merging #4845 (bd0a90d) into master (a94f72c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #4845     +/-   ##
=========================================
  Coverage   95.06%   95.07%
=========================================
  Files         589      594      +5
  Lines       62879    64038   +1159
=========================================
+ Hits        59779    60887   +1108
- Misses       3100     3151     +51

Flag
Coverage Δ

servertests
?

unittests
95.07% <ø> (+0.07%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/core/models.py
87.82% <0.00%> (-9.07%)
:arrow_down:

moto/core/responses.py
93.03% <0.00%> (-0.46%)
:arrow_down:

moto/apigateway/urls.py
100.00% <0.00%> (ø)

moto/apigatewayv2/exceptions.py
100.00% <0.00%> (ø)

moto/apigatewayv2/urls.py
100.00% <0.00%> (ø)

moto/apigatewayv2/responses.py
100.00% <0.00%> (ø)

moto/apigatewayv2/models.py
98.18% <0.00%> (ø)

moto/apigatewayv2/__init__.py
100.00% <0.00%> (ø)

moto/__init__.py
98.44% <0.00%> (+0.01%)
:arrow_up:

moto/apigateway/exceptions.py
99.20% <0.00%> (+0.02%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a94f72c...bd0a90d. Read the comment docs.


mono linux player not found

when i run the "craft.sh" i have encountered this error
cp: cannot stat '/home/ziyao/Unity-2018.4.10f1/Hub/Editor/2018.4.10f1/Editor/Data/PlaybackEngines/LinuxStandaloneSupport/Variations/linux64_withgfx_nondevelopment_mono/LinuxPlayer': No such file or directory
i have the latest version of hearthstone installed using ngdp and unity version Unity-2018.4.10f1
what seems to be the problem?

It looks like you are missing the engine files? After downloading the UnityHub.AppImage, do you have installed the engine files 2018.4.10f1?
I just tried it and it works for me like this:

Make the file executable
chmod +x ./UnityHub.AppImage
Start unity hub with the url
./UnityHub.AppImage unityhub://2018.4.10f1/a0470569e97b
You can ignore the licensing stuff that may show up, wait until the installation window appears. You don't need to install any of the additional modules.


[SPARK-11113][SQL] Remove DeveloperApi annotation from private classes.

Merged build triggered.

Merged build started.

Test build #43740 has started for   PR 9121 at commit c479385.

LGTM pending tests.

Test build #43740 has finished for   PR 9121 at commit c479385.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43740/
Test PASSed.


GitHub Actions: Don't run on push events for branches

Without this, CI is always run not only for pull_request event but also for push event, it's too wasted.


Fix modNumber memory leak not freeing memory

:+1:

@MindaugasJucius, please tag or mention somebody in this issue! :smile:

:+1:


Failed to download a model from Huggingface hub

Hello
How are you?
Thanks for contributing to this project.
I tried to run the demo code for speaker diarization.
import wespeaker
model = wespeaker.load_model('english')
embedding = model.extract_embedding('audios/english/121-121726-0000.wav')
similarity = model.compute_similarity('audios/english/121-121726-0000.wav',
'audios/english/1284-1180-0000.wav')
diar_result = model.diarize('6-speakers-english_16k_mono.wav')
But it is failed to download the model from Huggingface hub.
I think that it is because an access token to huggingface hub is not given in the script.

Oh, your model is not from hugginggface hub.


added feature to set custom laravel connection for database driver

Thanks for your contribution,
Feature is accepted.


Handle null version name when building envelope

Goal

Testing

Release Notes

WHAT:
WHY:
WHO:

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#706  👈
#705
#704
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on  Graphite


Recyclerview not scroling

I'm currently use this lib with the help of example ,  but not able to find why recyclerview not scrolling !
may be
compileSdkVersion 24
buildToolsVersion '24.0.0'
will be the cause?

solved , by mistake fragment called inside the Tool bar :D :dart:


WinGet manifest update for azctx version 2023.09.2: add version

[x] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

@microsoft-github-policy-service agree [company="{white duck GmbH}"]

@microsoft-github-policy-service agree company="white duck GmbH"

@microsoft-github-policy-service agree company="white duck GmbH"

/azp run


feat: add binary format to releaser

Description

Release directly binaries instead of tarballs to make it compatible with cosmovisor
The current goreleaser is going to generate an release like this: https://github.com/RafilxTenfen/umee/releases/tag/v3.1.1-rc0

closes: #1347

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] added appropriate labels to the PR
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

I am thinking how can I test that :thinking:

doc: https://goreleaser.com/customization/archive/?h=archives

Tested again against real release files (tarball and plain binaries)

https://github.com/umee-network/umee-infra/pull/263 only worked with plain binaries

For this PR and to maintain the tarballs I will set the goreleaser to generate 2 archives, the plain binaries which we should point to work with cosmovisor, and the tarballs to keep what we currently have

Tested again and now was able to make it work with tarballs (tar.gz or zip), the thing is we need to remove wrap_in_directory and in the cosmovisor set DAEMON_NAME=umeed as env
but, if we use the binary release link directly, there is no need to set  DAEMON_NAME


Several Feature Suggestions

Hi,
Thanks for making this extension. It's really helpful to leverage VSCode's testing UI with R. Here are some ideas
These might exist already, but I haven't found them:

Some way to view non-result output. Basically I'm only seeing the error message when the tests fails, not any print messages etc. generated by the test.
Way to view backtrace on failure.
Option to set environment variables and/or options for the test run. In particular, it would be nice to set how many tests testthat runs in parallel.

Bigger extensions:

Integration with R VSCode debugger so that run-with debug is possible
Integration with test coverage

Probably these are things you have thought of as well. I'm mostly curious to know whether they are in line with your vision and what you think the relative effort would be among them. I may be willing to do a bit of work on it if there is one that is relatively low hanging and more of an R than JS/typescript project.
I've also had some issues that might be bugs, but I will try to pull together an MRE before posting about them.
Thanks again!
Brock

Hey! Thanks a lot for the recommendations :) Interesting, I think it should be possible to view the non-result output in the output tab of VSCode, but I haven't coded in R in ages, so I need to double-check.
The environment variables part is a very good and straightforward idea, following the pattern of other extensions, e.g., Go. It should be implemented.
Debugger and test coverage would also certainly be charming, although as you noted, they are quite large efforts. I don't know whether the test adapter base that VSCode exposes easily extends to debuggers, and even then how we would connect it to R's adapter.
These days, I don't code in R much and am otherwise quite busy, so I am mostly fixing bugs whenever they come along to the repo. I will go over the features you recommended in the next couple of days and give a basic outline for each, so that you (or any others) can see if there's a way to give it a try. At first glance, the environment variable part should be the easiest; it just requires registering an extension setting to VSCode (similar to RscriptPath that this extension already registers) and using it in the test calls.
If you want to give any of them a try, I would be happy to assist, limited on the code side but surely on the ideas! Thanks again for your detailed write-up. I am happy to see other R people using VSCode as well :)

Interesting, I think it should be possible to view the non-result output in the output tab of VSCode

When I used it on my real project the reporter worked, but I didn't see any output in the output tab. Trying to make an MRE, by putting print statements in the tests themselves, the reporter totally failed. Reporter here: #30
I'm pretty sure the full backtrace is not getting passed from VSCode reporter methods in any way at all.

Another suggestion... I believe you are passing the location of the failure itself back from R to the typescript, but then ignore it and put the error at the start of the failing test rather than within the test where the failure actually occurred. Especially for failed expectations, it might be good to put it on the line of the expectation, rather than the test.
e.g. here:

put the error on line 8 instead of line 7 where it is currently.


Base Fee Floor (fixed) configuration

Configuration for the Base Fee Floor (Fixed)

Related issue: https://github.com/celo-org/celo-blockchain-planning/issues/478


Chaincode on multi-org error

Good afternoon, I'm carrying out studies in the minifabric tool and I'm having some problems. In the current environment I created a network with two networks, one with 2 organizations each with 2 peers and another with 1 organization with 2 peers. I used the command orgjoin, and nodeimport,join to make both part of the same channel. However, I'm having trouble installing chaincode. Initially, the site1 network has a chaincode that was created in the command: "minifab up -e 7000 -n chaincode1 -o site1.org.br", so I can install chaincode1 on site 2 that joined later. Despite this, I tried to do the reverse operation now, on site2 I tried to install chaincode2 in its definition with the commands:
site2
minifab install,approve,discover -n chaincode2 -v 0.1
Unfortunately discover is generating an empty "vars/discover/mychannel/chaincode2_endorsers.json". Even so, I tried to continue the process by approving the chaincode on site1.
site1
minifab approve,discover,commit -n chaincode2 -v 0.1 and I got the following error:

Is this a minifabric limitation? Do I need chaincodes to be defined and installed initially on the first site so others can join?

### create first university
####
## site 1
####
minifab up -e 7000 -n chaincode1 -v 0.1 -p '' -o site1.org.br
### site 2
minifab netup -e 7050 -o site2.org.br
cp vars/JoinRequest_site2-org-br.json ../site1/vars/NewOrgJoinRequest.json
#### site 1
minifab orgjoin
cp vars/profiles/endpoints.yaml ../site2/vars/endpoints.yaml
#### site 2
minifab nodeimport,join -c mychannel
# minifab profilegen
#### Install chaincode on site2
minifab install,approve -n chaincode1 -v 0.1 -p ''
#### site 1
minifab approve,discover,commit
# Works until here
### site 2
minifab install,approve,discover -n chaincode2 -v 0.1 -p ''
# Generate a empty file
#### site 1
minifab approve,discover,commit
# Layout errors```

@litong01 Do you have any suggestions for this error? I would greatly appreciate it.

Hi @LeoGCRocha - please join us on Discord in the #minifabric channel


Add RFC for Grid Product

This RFC proposes a GS1-compatible implementation of Product for Grid. The component is intended to initially serve as a base implementation of the product in accordance with the GS1 spec. The intention is to iterate on this product component and derive product types in the future (i.e. food item, clothing, furniture, etc)

Sent to some folks at GS1 for review as well.

Seeing a property that allows for availability of a product to be defined would be great - think seasonal products in retail or custom order products for food trade.

I propose this RFC be merged. After approval by the gs1 and core subteams, this RFC will enter its final comment period. After FCP has ended, the root team will make a decision.
Approvals required to enter FCP:
Core subteam
[x] Adeeb Ahmed
[] Andi Gunderson
[] Darian Plumb
[] James Mitchell
[] Jason Walker
[] Peter Schwarz
[] Shawn Amundson
GS1 Subteam
[x] Adeeb Ahmed
[] Dave Cecchi
[] Gena Morgan
[] James Mitchell
[] Matt Perron
[] Melanie Nuce

LGTM

Looks good to me. I put some reg comments in line on grid being Grid but not as blockers/changes-requested.
Nice work, @adeebahmed

FCP has ended without substantial new feedback. I propose this RFC be approved and merged. Both GS1 and core subteams must approve.
Core subteam:

[ ] Adeeb Ahmed
[ ] Andi Gunderson
[ ] Darian Plumb
[ ] James Mitchell
[ ] Jason Walker
[ ] Peter Schwarz
[ ] Shawn Amundson

GS1 subteam:

[ ] Adeeb Ahmed
[ ] Dave Cecchi
[ ] Gena Morgan
[ ] James Mitchell
[ ] Matt Perron
[ ] Melanie Nuce


Tests

Created some tests

I'd rather not have Machete.Tests referencing HL7, there is an HL7 tests...

Your suggested changes are checked in now. Please merge.

Also, if you could squash/rebase into a single commit and update the PR, that would be helpful.


Research & Fix Cookies Piling Up Issue

Research / Fix cookies issue that JupyterHub is encountering.
HTTP 401 error seen, with response size too large.

@ramesh-maddegoda Is this a U-ADS issue, or an underlying networking issue that U-CS needs to address?  Also, can you please comment on the recent findings and/or any work left to do?

@galenatjpl , I was unable to reproduce this issue with my previous attempts.

@mike-gangl @mcduffie @wphyojpl .  I think we have a workaround, where @wphyojpl was able to manually delete cookies to get this to work.  Others (including me) are unable to reproduce this as well.  I'm going to close this issue since at least there is a workaround.  We spent a significant amount of time on this already.


Is it possible to know when the user scrolled to the end?

Hello,
I wanted to add pagination to my charts.
Initially, the chart will receive recent data. But if the user scrolls to the end, it will run a function and ask for more data.
Is it possible to do?

Hi @MeloHenrique,
This is possible, but you will have to write pagination logic.
Example for scrollable chart can be found in here
Setting isScrollable in ChartBehaviour to true will make sure that chart ignores width of the parent. You have to wrap chart in scrollable widget, and from there you can attach scroll controller to the scrollable widget and manipulate data in the chart (to load more) when controller is near ar at the end.
p.s. when setting isScrollable to true you should define, min/max item width in ItemOptions, since that is the value items will use in that case.

Yeah, and I have tried the same, with scrolnotification property , metrices.extendbefore property can add condition for right scrolling & left scrolling, and can Identify give loadmore method can call by extendbefore conditioning.


protobuf: 3.15.2 -> 3.15.5

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I tried building python3Packages.google-cloud-kms because it uses protobuf and it fails with some strange error I couldn't solve
  adding 'google_cloud_kms-2.2.0.dist-info/top_level.txt'
  adding 'google_cloud_kms-2.2.0.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  Finished executing setuptoolsBuildPhase
  installing
  Executing pipInstallPhase
  /build/google-cloud-kms-2.2.0/dist /build/google-cloud-kms-2.2.0
  Processing ./google_cloud_kms-2.2.0-py2.py3-none-any.whl
  ERROR: Could not find a version that satisfies the requirement libcst>=0.2.5 (from google-cloud-kms)
  ERROR: No matching distribution found for libcst>=0.2.5
builder for '/nix/store/hy4jqw5m3c2jqmavgd2g1y1v17mzfdm4-python3.8-google-cloud-kms-2.2.0.drv' failed with exit code 1
error: build of '/nix/store/hy4jqw5m3c2jqmavgd2g1y1v17mzfdm4-python3.8-google-cloud-kms-2.2.0.drv' failed

Probably unrelated to this PR.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 115193 run on x86_64-linux 1

1 package built:

gnome3.gnome-terminal

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

gnome3.gnome-terminal:

warning: EvalError
Cannot evaluate attribute ‘gnome3.gnome-terminal’ in ‘/nix/store/vi05s3qxs8zdh9dx68y2y3a5c4agm86g-nixpkgs’.

google-cloud-kms fail seems to be unrelated


add pagination for project list api

Add pagination support for List projects API
request params:
page_size
page_num
Test:
Request -
curl --location '<>/v1beta1/users/self/projects?org_id=b449618d-7b9a-4793-9f12-8ae36937df19&page_size=1&page_num=2' \ --header 'Accept: application/json' \ --header 'Cookie:
Response -
{
    "projects": [
        {
            "id": "",
            "name": "",
            "title": "",
            "org_id": "",
            "metadata": {},
            "created_at": "",
            "updated_at": "",
            "members_count": 0
        }
    ],
    "access_pairs": [],
    "count": 2
}

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

1 of 22 (4.55%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 30.373%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/api/v1beta1/user.go
0
3
0.0%

internal/store/postgres/project_repository.go
1
19
5.26%

Files with Coverage Reduction
New Missed Lines
%

internal/api/v1beta1/user.go
1
48.6%

Totals

Change from base Build<PHONE_NUMBER>5:
-0.02%

Covered Lines:
7671

Relevant Lines:
25256

💛  - Coveralls


PRs created by backport-action should trigger the CI

Is your feature request related to a problem? Please describe.
PRs  created by the backport-action do not trigger the CI for the PR.
Triggering the CI, especially for backports, is important to verify the integrity of the PR.
Describe the solution you'd like
I do not know of a good solution on how to achieve that, but for starters, an entry in the README outlining examples on how to overcome this, would be great.
Describe alternatives you've considered
See https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs

That's a good point. Thanks for raising this @grische
I'll consider adding something about this to the README.
In the meantime, the solution depends on the type of event your workflow runs on. You can use a Personal Access Token and set it in the workflow for the:

checkout action using the token input so commits are pushed by the associated user (triggers a push event, example)
backport action using the github_token input so the pull request is opened by the associated user (triggers a pull_request event, example

The referenced example uses both and this works well.


404 for the cherry-pick link url in "Kubernetes Release Cycle" page

In the "Kubernetes Release Cycle" page, there are two places linking for cherry-pick https://kubernetes.io/contributors/devel/sig-release/cherry-picks.md which is 404.
It seems that it should be https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md.
snapshots:
1.

2. another one:

Hi, i would like to work on this issue!

/assign @himanshu007-creator


Add privacy and terms

URL: https://qurantalk.notion.site/Privacy-Policy-for-Starbook-Mobile-App-a8fb153c39dd45dfa5b2cb9a945e3c84?pvs=4

Copy the text from the above link and past it in here https://github.com/Blocship/star_book/blob/dev/PRIVACY%26POLICY.md And use this link in url launcher


instr function doesn't correctly account for non-ascii strings

Describe the bug
the instr function doesn't correctly return the position of the matched string, rather it returns the position of the matched byte index. The issue is in this code in string_expressions.rs
.map(|(string, substr)| match (string, substr) {
                    (Some(string), Some(substr)) => string
                        .find(substr)
                        .map_or(Some(0), |index| Some((index + 1) as i32)),
                    _ => None,
                })

See the documentation for the find function.
The expected result from the end users perspective is not the byte index but rather the index of the first matching unicode grapheme in the string.
To Reproduce
❯ docker run -it -v /tmp:/data datafusion-cli
DataFusion CLI v35.0.0
❯ select instr('实现这个函数', '函')
;
+----------------------------------------+
| instr(Utf8("实现这个函数"),Utf8("函")) |
+----------------------------------------+
| 13                                     |
+----------------------------------------+
1 row in set. Query took 0.002 seconds.
5 should be the correct position.
Expected behavior
The returned position should be the position of the first matching unicode grapheme in the string, not the first matching byte index.
Additional context
No response

@zy-kkk  - perhaps you could take this on as you submitted the original PR for the instr function?

@zy-kkk  - perhaps you could take this on as you submitted the original PR for the instr function?

Yes, @Omega359, I can take over this task. Thank you for bringing this issue to my attention. I will work on fixing it promptly.

Closing this issue as the function was removed.


Mutable methods in wit resources

I'm looking into using resources with the following .wit file:
resource aggregate {
  static new: function(id: string) -> aggregate
  apply-events: function(event: list<list<u8>>)
}

Which generates:
pub trait Aggregate {
    fn new(id: String,) -> wit_bindgen_rust::Handle<super::Aggregate>;
    fn apply_events(&self,event: Vec<Vec<u8>>,);
}

But using the online demo to see the generated rust code for export, the apply-events method takes &self. But what if I want to mutate self with &mut self, is this possible?

This is currently due to the assumption that components allow for being recursively entered. This means that if Rust handed out &mut T then it would be memory unsafe to recursively call the component. This means that there's no way to use &mut self and you need to use interior mutability such as Cell<T> or RefCell<T>.
I believe the most recent iteration of the component model disallows recursively entering a component, though, so a future iteration of wit-bindgen for the updated component model will likely define all methods with &mut self since you'll have exclusive access at all times.

Ok I'll leave this open so when we see this again I can confirm that this change was made or not.

Ok I'm going to close this in favor of https://github.com/bytecodealliance/wit-bindgen/issues/201 since this is part of the new canonical ABI updates.


Dev environment should be friendly to Windows users

In https://github.com/cucumber/cucumber-ruby/issues/915#issuecomment-142438357 @enkessler noted that Cucumber's build doesn't work on Windows.
This excludes Windows users from contributing to Cucumber.
Is anyone willing to help fix this? We can use https://ci.appveyor.com to add CI once we have a build that works.

I have the cucumber-ruby gem working on Windows, maybe I'm not understanding your problem

@tomatobrown this is about running cucumber's own build on Windows. Clearer?

@mattwynne @aslakhellesoy PR #1116 has added a Windows build to the CI process. There is some remaining work in getting that build green, however.
All specs pass but there are still failing features.

It looks that some (all?) of the failing features would be fixed if Cucumber-Ruby also on Windows understood that / in the feature path argument means the path separator. Luckily for Cucumber-JVM, Java on Windows understands that, therefore Cucumber-JVM always output the uri with / as the path separator and it works on all platforms (for instance uri's with / in the rerun.txt file).

@brasmusson Wouldn't that mean that we only use path separators in 1 in 3 of our tests? Additionally, several of those path errors go away when that command is invoked via backticks instead of through Aruba. Shouldn't the path error still be there if it were a Ruby on Windows problem?

We have an Appveyor build, it just isn't passing. Closing this in favour of #1215 which has a more specific acceptance criterion (make the build pass)


Ports capture script to go for windows

This ports the shell script to a real binary. This will allow more realistic tests and also things to work naturally on windows
See #105

I'm noticing we do a lot of unnecessary work that smells like we distrust go's exec package (ex writing back the cwd etc). I will remove that

ok simpler now

found more duplicated code.. pruning now..

glad you like @mathetake :)


Venue and Journal workflows: add invitation id and signature to post_message

Include invitation and signature into the post_message call, these fields are optional to keep backward compatibility
Use meta invitation to post messages as organizers
Create a message invitation for each submissions to ACs and SACs can remind reviewers of each assigned paper
Fix tests

This PR is ready to be reviewed and merged, thanks!


Duplicate priorities-update in certain circumstances

2.0.0-alpha.7

[x] I confirm that this is an issue rather than a question.

Bug report
Under certain circumstances a spurious priorities-update API response is generated.
Steps to reproduce

Subscribe to priorities-update (in one terminals):

$ echo '{"command":"serverinfo", "subscribe":["priorities-update"] }' | nc hyperion 19444

Set an effect (in another terminal):

$ echo '{"origin": "Home Assistant", "priority": 128, "effect": {"name": "Cold mood blobs"}, "command": "effect"}' | nc hyperion 19444

Observe the priority updates in the first terminal.

What is expected?
At most two priority updates (one priority becoming non-visible, another becoming visible).

A similar effect can be seen on clear:
$ echo '{"priority": 128, "command": "clear"}' | nc hyperion 19444
{"command":"clear","success":true,"tan":0}

... will then produce two identical updates ...
{"command":"priorities-update","data":{"priorities":[{"active":true,"componentId":"V4L","origin":"System","owner":"V4L2:/dev/video0","priority":240,"visible":true}],"priorities_autoselect":true}}
{"command":"priorities-update","data":{"priorities":[{"active":true,"componentId":"V4L","origin":"System","owner":"V4L2:/dev/video0","priority":240,"visible":true}],"priorities_autoselect":true}}

System

Hyperion Server:

Build:       master (GitHub-f719f0b/838092e-1597257777)
Build time:  Aug 19 2020 04:01:56
Git Remote:  https://github.com/hyperion-project/hyperion.ng.git
Version:     2.0.0-alpha.7
UI Lang:     auto (BrowserLang: en-US)
UI Access:   default
Avail Capt:  dispmanx,v4l2,framebuffer,qt

Hyperion Server OS:

Distribution: Raspbian GNU/Linux 10 (buster)
Arch:         arm
Kernel:       linux (5.4.51+ (WS: 32))
Browser:      Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/53

@dermotduffy
Can you please test my PR #1036 ?

@Paulchen-Panther Verified fixed in your PR. Thanks!

@Paulchen-Panther This still appears to be a problem.
Subscribe (in 1 terminal):
$ telnet hyperion 19444
Escape character is '^]'.
{"command": "serverinfo", "subscribe": ["priorities-update"]}

Send a color command (in another terminal):
echo '{"origin": "Home Assistant", "priority": 128, "color": [10,100,255], "command": "color"}' | nc hyperion 19444

Output I get (in the first terminal), two identical calls back:
{"command":"priorities-update","data":{"priorities":[{"active":true,"componentId":"COLOR","origin":"Home Assistant@::ffff:<IP_ADDRESS>","priority":128,"value":{"HSL":[0,1,0.5196154713630676],"RGB":[10,100,255]},"visible":true},{"active":false,"componentId":"V4L","origin":"System","priority":240,"visible":false}],"priorities_autoselect":true}}
{"command":"priorities-update","data":{"priorities":[{"active":true,"componentId":"COLOR","origin":"Home Assistant@::ffff:<IP_ADDRESS>","priority":128,"value":{"HSL":[0,1,0.5196154713630676],"RGB":[10,100,255]},"visible":true},{"active":false,"componentId":"V4L","origin":"System","priority":240,"visible":false}],"priorities_autoselect":true}}

@Paulchen-Panther This still appears to be a problem (brand new build from head):
Subscribe (in 1 terminal):
$ telnet hyperion 19444
Escape character is '^]'.
{"command": "serverinfo", "subscribe": ["priorities-update"]}

Send a color command (in another terminal):
echo '{"origin": "Home Assistant", "priority": 128, "color": [10,100,255], "command": "color"}' | nc hyperion 19444

Output I get (in the first terminal), two identical calls back:
{"command":"priorities-update","data":{"priorities":[{"active":true,"componentId":"COLOR","origin":"Home Assistant@IP","priority":128,"value":{"HSL":[0,1,0.5196154713630676],"RGB":[10,100,255]},"visible":true},{"active":false,"componentId":"V4L","origin":"System","priority":240,"visible":false}],"priorities_autoselect":true}}
{"command":"priorities-update","data":{"priorities":[{"active":true,"componentId":"COLOR","origin":"Home Assistant@IP","priority":128,"value":{"HSL":[0,1,0.5196154713630676],"RGB":[10,100,255]},"visible":true},{"active":false,"componentId":"V4L","origin":"System","priority":240,"visible":false}],"priorities_autoselect":true}}

No problem. I'll look again.

Could you please test PR #1062 ? Many Thanks.

Thanks @Paulchen-Panther . That works in that only a single color priority is produced (hurray!), however I notice that the problem of no priority update on effect is back again:
Subscribe (in 1 terminal):
$ telnet hyperion 19444
Escape character is '^]'.
{"command": "serverinfo", "subscribe": ["priorities-update"]}

Send an effect update (in another terminal):
$ echo '{"command":"effect", "effect":{"name":"Red mood blobs" }, "priority":50, "origin":"My Fancy App"}' | nc hyperion 19444
{"command":"effect","success":true,"tan":0}

I'd expect a priority update, yet I receive none.

thanks for the feedback. I hadn't tested the effect. take care of that.

@dermotduffy
Another test? PR #1062

Sorry to be the bearer of bad news -- now it works for effect, but is back to broken for color. The below is output from a single color set command:
{"command":"priorities-update","data":{"priorities":[{"active":true,"componentId":"COLOR","origin":"Home Assistant@::ffff:<IP_ADDRESS>","priority":12,"value":{"HSL":[0,1,0.5313801765441895],"RGB":[16,100,255]},"visible":true},{"active":true,"componentId":"EFFECT","origin":"My Fancy App@::ffff:<IP_ADDRESS>","owner":"Red mood blobs","priority":50,"visible":false},{"active":true,"componentId":"COLOR","origin":"Home Assistant@::ffff:<IP_ADDRESS>","priority":128,"value":{"HSL":[0,1,0.5313801765441895],"RGB":[16,100,255]},"visible":false},{"active":false,"componentId":"V4L","origin":"System","priority":240,"visible":false}],"priorities_autoselect":true}}
{"command":"priorities-update","data":{"priorities":[{"active":true,"componentId":"COLOR","origin":"Home Assistant@::ffff:<IP_ADDRESS>","priority":12,"value":{"HSL":[0,1,0.5313801765441895],"RGB":[16,100,255]},"visible":true},{"active":true,"componentId":"EFFECT","origin":"My Fancy App@::ffff:<IP_ADDRESS>","owner":"Red mood blobs","priority":50,"visible":false},{"active":true,"componentId":"COLOR","origin":"Home Assistant@::ffff:<IP_ADDRESS>","priority":128,"value":{"HSL":[0,1,0.5313801765441895],"RGB":[16,100,255]},"visible":false},{"active":false,"componentId":"V4L","origin":"System","priority":240,"visible":false}],"priorities_autoselect":true}}

I cannot reproduce the duplicate issues.
Here I am using the generated artifacts from PR:

Hmm. Thanks @Paulchen-Panther . That gif shows what I would have expected. Let me play around and make sure I'm not making some user error on my side. Report back shortly.

Fresh build, from head + PR1062. I get a single update, but only if the priority is lower than what is present. See gif:

(Same happens with effects -- it appears the correct number of updates are generated, but only if the new priority "wins").

Give it another try on PR #1062 ?

Same. See below:

Build verification:
Hyperion Server:
- Build:       fix-993-maybe-this-time (Paulchen Panther-65c45042/871ac095-1603649159)
- Build time:  Oct 25 2020 18:38:11
- Git Remote:  https://github.com/hyperion-project/hyperion.ng.git
- Version:     2.0.0-alpha.8
- UI Lang:     auto (BrowserLang: en-US)
- UI Access:   default
- Avail Capt:  dispmanx,v4l2,framebuffer,qt

871ac095ecb904bd483684c252c6c540aad59ba8 is your most recent commit on #1062

I cannot reproduce it. For me the background effect runs with prio 254 and the X11 grabber with prio 250. Here is the result:

Thanks @Paulchen-Panther . I have tried another fresh rebuild, and all sorts of various settings, priorities, removing my hyperion.db, etc.
Here is my main finding: It only fails to work if the new priority is the same as the old priority AND the new priority is the lowest/active priority. In all other cases it works correctly,
This still does not not match what your gif is showing (where you use priority 100, and don't appear to have a lower priority in the serverinfo output), so right now I have no explanation for the difference we are seeing.

I see exactly the same in your example as in my example. First a new priority 100 (color) is registered and an output appears. Then I overwrite the Prio 100 with a different color. The Prio 100 is also the currently active color for me.
If you can give me a reproducible order, I can look again.

Start hyperiond fresh.
Only System @ 254 on the remote control listings on the UI.
Send this (it will work):

echo '{"origin": "Home Assistant", "priority": 100, "color": [1,1,1], "command": "color"}' | nc hyperion 19444

Send this (it will not work -- no priority update):

echo '{"origin": "Home Assistant", "priority": 100, "color": [2,2,2], "command": "color"}' | nc hyperion 19444

[This was reproducible for me]

Thank you for the detailed description. Get in touch with you when there are improvements.

@Paulchen-Panther I dug into this a little this evening, and discovered the same thing it seems you did: an uninitialized variable. I'm guessing we were getting different values, and this was causing the different behavior we were seeing.
Either way: I've done a new build with your latest fix on https://github.com/hyperion-project/hyperion.ng/pull/1062 and it looks good to me!

@Paulchen-Panther Unrelated: Given the volume of fixes there's been on the API code (thank you!), would it be at all possible to get a new official Hyperion build after this change is in? (I have a number of parts of the Home Assistant integration work ready that depend on these fixes being in an official build).
Thank you for considering.

I will advise me internally with the other members.
Also a big thank you for the constant testing and feedback. 👍

@Paulchen-Panther Quick check: do you have any news on a release ETA? Just want to know roughly, so I can plan accordingly. Thank you!


Loss exploded when training WaveNet

I use GTA synthesis by Tacotron-2 to predict mel spectrograms  and then train the wavenet vocoder with default hparams. I have two problems:
1.The loss < 0
2.When iterating after 196k the training exited due to exception: Loss exploded.
Has anyone ever been in this situation?And what should i do?Thanks a lot!

I have encounter this problem: exploded.
Have you solved it?
Thanks!

@wjqkkky hi, can you share wavenet eval plot of waveform of both original and predicted from last saved checkpoint.


CI/CT/CD

Integration & Testing

We need library, CLI & Runtime (flatcc, flatcc-cli & flatccrt) built for Win64, MacOS, Linux with the flag -DFLATCC_OFFSET_SIZE=8 (store them as artefacts if they pass the tests).
PRs created to bring updates from upstream, same as XKCP & meshoptimizer
Coverage as per the others too

Deployment
Store binaries as part of the tagged Release artefacts.

For building on Windows,
Additional Prerequisites:

MSys2 (MinGW64)

Build Steps (from MinGW64 bash shell):
mkdir -p build/mingw64
cd build/mingw64
cmake -G "MinGW Makefiles" ../.. -DBUILD_SHARED_LIBS=ON -DFLATCC_OFFSET_SIZE=8 -DCMAKE_BUILD_TYPE=Release
cmake --build . --target flatcc_cli --config Release
cmake --build . --target flatccrt --config Release

StirlingLabs.flatcc-win64.zip

For building on other platforms,
mkdir -p build/mingw64
cd build/mingw64
cmake ../.. -DBUILD_SHARED_LIBS=ON -DFLATCC_OFFSET_SIZE=8 -DCMAKE_BUILD_TYPE=Release
cmake --build . --target flatcc_cli --config Release
cmake --build . --target flatccrt --config Release

Expect (most) tests to fail as they are still expecting 32-bit offsets.


Problem laravel.57

Famework : Laravel 5.7 (updated)
add: "rinvex/repository": "develop"
execute : composer update
Error: don't install illuminate/database 5.6.x-dev|don't install laravel/framework 5.7.x-dev (in others)
What commit or branch should I install?

"rinvex/repository" not found use "rinvex/laravel-repositories" in composer.json


[WIP] Inline mcmc methods and a few other cleanups

Submission Checklist

[x] Run unit tests: ./runTests.py src/test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary
I'm going through in another PR and using the require_* metaprogramming stuff to clean things up. Before I touch any of the mcmc things I wanted to clean the things below up first. There's a couple smallish things here which touch a lot of the mcmc stuff

A lot of the functions in mcmc are inline candidates so I went through and made everything inline

Instead of declaring defaults during the constructor

base_adapter() : adapt_flag_(false) {}

We remove that and use the braced default initialization scheme
bool adapt_flag_{false};

If a destructor is declared in a class, we also declare the move and copy assignments and constructors ala

  ~base_mcmc() = default;
  base_mcmc(const base_mcmc& other) = default;
  base_mcmc(base_mcmc&& other) = default;
  base_mcmc& operator=(const base_mcmc&) = default;
  base_mcmc& operator=(base_mcmc&&) = default;

Make const correct setters and getters for class methods that access or manipulate member values

  // accessor
  inline const std::string& param_name(int j) const { return param_names_(j); }
  // mutator
  inline std::string& param_name(int j) { return param_names_(j); }

In the same vein, I removed the a lot of the set_ and get methods such as for max_num_fixed_point. max_num_fixed_point was defined as
  void set_max_num_fixed_point(int n) {
    if (n > 0)
      this->max_num_fixed_point_ = n;
  }

Which seems odd. If n <= 0 is bad then shouldn't this throw a warning or error? I opted to just remove it and make a standard accessor and mutator
  inline int& max_num_fixed_point() { return this->max_num_fixed_point_; }
  inline const int max_num_fixed_point() const { return this->max_num_fixed_point_; }

I did the above for a lot of the set and get methods in mcmc. So now things like get_mu() and set_mu() just use mu() ala
// access
auto val = thing.mu()
// mutate
thing.mu() = 12;

Not really sure why but we were calling the operator= for ps_point explicitly in base_hmc, I just change that so it's

      this->z_ = z_init;

I h8 in/out params. The devils params as I personally call them. I fixed complete_adaptation() and learn_stepsize() so they do a return instead of an in/out

this->stepsize_adaptation_.complete_adaptation(this->nom_epsilon_);

becomes
this->nom_epsilon_ = this->stepsize_adaptation_.complete_adaptation();

Intended Effect
Just a cleanup
How to Verify
Running base tests, open to adding any additional tests if anyone things we need them from this PR
Side Effects
There should be no unintended side effects. Perhaps better inlining
Documentation
While I'm cleaning these up should I start writing docs or should that go in a separate PR?
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Steve Bronder
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

I can review this when it's passing tests.

ty! I'll ping you when it's ready for review. I still have to add docs to some things I added

Actually I think I'm going to break this up into multiple PRs because there's a ton of very teeny changes


https support + fetching SGF files from OGS

OGS redirects all users to their ssl site. Links are almost guaranteed to include the https://-portion, which gokibitz was unable to handle.

There's no easy-to-grab download link for SGF files on OGS. You can't copy&paste a link to gokibitz easily. This change adds a mapping from https://online-go.com/game/{gameid} to
https://online-go.com/api/v1/games/{gameid}/sgf. Thus, any (public) game link will now retrieve the SGF.

This looks great. Thanks for fixing the lack of https support--it's kind of an embarrassing oversight, since GoKibitz itself is served over https.
Your formatting follows the project's conventions and your PR description is really thorough, too--high fives all around! I'll merge this in and push it this morning.

Launched on gokibitz.com! Thanks again!


Remove the custom setting for file extension and rely on the builtin settings

Rider has a built-in way of associating file extensions to languages:

Removing the "custom way":

Will bring the plugin closer to standard and will keep us from trying to access project-settings from within CakeFileType. Performance-wise this is a much better idea and it will also solve #160 .

This has the additional benefit that everything PSI-related (gutter icons in and code inlays, as well as the structure view) works with file that are configured as Cake files but do not have the default extension of *.cake (Which obviously is not the case in the current version...)


Support customizable sasl mechanism in 'managed' kafka mode

Allows the SASL mechanism to optionally be set in the secret that clowder looks up when running the kafka provider in 'managed' mode. If the key is absent, PLAIN is used as the mechanism.

lgtm


No styles applied to ListItem with react-window

[x ] The issue is present in the latest release.
[ x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When using react-window, styles are not applied to ListItem using ListItemSecondaryAction.
Expected Behavior 🤔
Styles applied
Steps to Reproduce 🕹
https://codesandbox.io/s/material-demo-7j8bx?file=/demo.js
Your Environment 🌎

Tech
Version

Material-UI
v4.10.2

React
latest

Browser
chrome 83

in styles inspector div hasnt ListItemRoot style

Hey @popuguytheparrot,
I did some small adjustments to you demo and got it to work properly.
codesandbox

Hey @popuguytheparrot,
I did some small adjustments to you demo and got it to work properly.
codesandbox

Thank you very much. In the example, it is not obvious why the problems arise. I think, need to redo example so that other developers do not have such problems


[Feature Request] allow configuring what affixes can go on which equipment type

There are some legitimate use cases for this, such as boots that increase move speed, and some more whimsical configurations like shields that boost draw speed or helmets that increase crit rate (by having an attached scope or something to help with aiming, I presume), but it can help to stir up the armor affix meta a bit, since right now it's just piling on protection.

Technically speaking it would be neat.  Realistically speaking it would need another total rewrite of the affix system for this to be implemented.  I'll stick this here with an enhancement tag, but it likely will not come until the system is redone again.

This is possible as of the rewrite


Dynamically adding/removing workers

Hi, folks!
I apologize if this has been asked before, but I searched through the issues and only found two tangential ones (https://github.com/TimelyDataflow/timely-dataflow/issues/182 and https://github.com/TimelyDataflow/timely-dataflow/issues/319).
I'm curious about the possibility of adding and removing workers from a data flow cluster. More specifically, thinking about leveraging cloud where we might lose workers because nodes are replaced or we can add more to scale up. I've checked the documentation and it seems like the list of workers is static.
Is there any documentation about this? How would we manage to modify the cluster configuration?
Thanks!

Hello! It's a great question.
I think the short answer is "no". It is challenging to add and remove workers, as much of the shared state they use to coordinate relies on static assumptions about e.g. their number. There was some work at ETHZ (@antiguru or @utaal: do either of you recall details?) on dynamic workers, I think virtualizing the idea of a worker, and allowing with some interruption the reconfiguration. However, "losing" workers seems very problematic, as they are potentially indistinguishable from a very busy worker who needs to be awaited.
What I might suggest instead is to think of the workers and their operators as async tasks that can themselves farm out work, potentially to an elastic set of cloud workers, leaving the operators with the role of confirming and locking in completed work. This gives you access to timely dataflow's progress tracking, while allowing you to step away from its "exactly this many workers" threadpool model. The workers could shuttle resulting data around, or could shuttle references to cloud storage (e.g. S3 blob names) that the cloud workers could then pick up.

Thanks for the reply, Frank!
That's a very interesting idea! So basically have timely handle the core consistency and work scheduling based on the flow specified, while the bigger state and worker is farmed outside. This could make the timely clusters pretty thin, which makes failure (e.g. network partition) much less likely.
I imagine, as part of the dataflow, we could save the smaller timely state (e.g. S3 locations) pretty frequently and reload the state at boot time to continue work in case of failure. This could allow pretty ephemeral clusters that can be restored after "every" step.
Is there some place (timely docs or external) that you'd recommend to help me think about state saving and resume? I have a rough idea what that would look like, but I'm sure there are a lot of nuance that I haven't thought about yet.


Update environment.yml for windows and create file for linux

update the environment.yml for windows to the current version and create such a file for linux

created environment file for windows, linux still to be done


Start.bat not working???

I just downloaded the file edited the gameserver.ini then installed dependencies then tried opening the start.bat file. After the cmd prompt opened it said node is an incorrect or unknown command and didn't work. I decided to try messing with the file a little bit to see if I could fix it but could not. Please help. ;(
PS I was trying to fix it myself because I did not have an account on here yet.

Oh yeah and I've tried your guys new code aswell as the old one.

Try downloading & installing the current LTS version of node. If it still won't work, can you screenshot what's appearing in the command prompt?

 thats the screenshot link.

You don't even have node.js installed.
https://nodejs.org/en/

You don't have node.js installed. MultiOgar-Edited uses node.js.
https://nodejs.org/en/

thank you it works now! I guess I downloaded the wrong thing lol. You guys can close this now.


Improve I/O performance via buffering

This pull request combines a couple of changes made in order to measure their impact on overall performance in various environments. The changes include:

increasing the internal channel size in the connection router
adding a buffering layer to reads
adding a buffering layer to writes

NOTICE: write buffering is done in a rather convoluted way
due to the fact that Tokio does not yet expose write_all_vectored,
and its implementation of write_vectored does not fit our needs,
because it basically just sends one buffer at a time anyway.
Once write_all_vectored is solved, write buffering can be significantly
simplified, and memory copying can be elided.
Experiments show the following improvements:

local write workload to Apache Cassandra 4.0 is able to achieve 200kops for a single connection, compared to 70kops before the change
remote, shard-aware write workload to Scylla is able to achieve 200kops compared to 160k before the change

This set of improvements (particularly the last commit which buffers writes) makes the performance issues described in #338 go away. It's important to note however, that the only observable difference is on a very specific test environment, namely running a single Cassandra 4 node locally, communicating with it over loopback, and establishing exactly 1 connection to it. Tests performed with any of these changed, e.g.

comparing against Scylla
comparing against a cluster running on different machines (both within LAN and running in the cloud)
establishing more than 1 connection
did not show any observable difference in the particular scenario from #338.

It still doesn't mean that the fixes shouldn't be applied, but until the issue with write_all_vectored in Tokio is resolved, write buffering is a little controversial due to the fact that memory copying, which could have been avoided with vectored writes, is in place.
Regardless, we should perform more tests for mixed workloads, reads, different concurrencies, etc.

Ref: https://github.com/tokio-rs/tokio/issues/3679

v2:

rewritten the write buffering code to BufWriter with defined capacity in order to avoid reinventing the wheel

Flamegraphs from before and after the change on a local run - a vast difference in Tokio overhead is observed:
flamegraphs.tar.gz

Overhead is reduced in a remote test against Scylla too:
flamegraphs-remote.tar.gz

v3:

vastly simplify the loop according to @piodul's idea

I confirm it is better now than cassandra_cpp. Awesome! Thank you! Now I can do the switch to scylla driver.
BTW: I know this is a very specific and unrealistic worst-case test, however one of the purposes of the tool I'm building is being able to do quick and dirty benchmarking on a local machine during development. Sure, you need multiple machines, real network and realistic workload for doing final benchmarks, but they are more costly and take longer to run.

I confirm it is better now than cassandra_cpp. Awesome! Thank you! Now I can do the switch to scylla driver.
BTW: I know this is a very specific and unrealistic worst-case test, however one of the purposes of the tool I'm building is being able to do quick and dirty benchmarking on a local machine during development. Sure, you need multiple machines, real network and realistic workload for doing final benchmarks, but they are more costly and take longer to run.
After the change, latte+scylla takes less CPU time than latte+cassandra_cpp (and req/s numbers are very close, with scylla slightly on the winning side).

Thank you for the confirmation @pkolaczk. Please let us know if you have any ideas on improving the driver further.


Create pre-release and stable build pipelines

https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions


[EN] Add duration added or removed from timer

In addition to #2494 this PR also adds the duration added or removed from a timer when the respective intents are used.

Looks good. I had to do a sanity check because I was thinking that the slots would already have factored in the "half" > 30 logic since it even shows as the slot value in tests, but apparently not!

intent:
  name: HassStartTimer
slots:
  minutes: '3'
  seconds: half
details:
  minutes:
    name: minutes
    value: 3
    text: '3'
  seconds:
    name: seconds
    value: 30
    text: half
targets: {}
match: true
sentence_template: <timer_set> [a|the|my] timer for <timer_duration>
unmatched_slots: {}
source: builtin

It's included in the details but you can't use those in the response


Repetitive log entry: WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting

Home Assistant release with the issue:

Version 0.90.1
Last working Home Assistant release (if known):
Version 0.89.1
Operating environment (Hass.io/Docker/Windows/etc.):

Debian 9 stretch
Component/platform:

not sure engineio.client ?
Description of problem:
After upgrading to v0.90.1  my log shows these two lines every five minutes or so:
WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):
2019-03-22 12:07:38 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 12:07:38 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 12:12:39 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 12:12:39 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 12:18:39 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 12:18:39 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 12:28:35 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 12:28:35 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 12:33:36 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 12:33:36 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 12:38:37 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 12:38:37 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 12:43:38 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 12:43:38 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 12:50:36 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 12:50:36 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 12:55:37 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 12:55:37 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 13:00:38 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 13:00:38 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 13:05:39 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 13:05:39 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 13:11:37 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 13:11:37 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 13:21:35 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 13:21:35 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 13:26:37 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 13:26:37 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 13:33:35 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 13:33:35 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 13:43:35 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 13:43:35 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 13:48:36 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 13:48:36 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 13:55:36 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 13:55:36 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting
2019-03-22 14:00:37 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 14:00:37 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting

Additional information:

This is an artifact of aioambient, the package that powers the ambient_station component. More specifically, aioambient's use of python-engineio and python-socketio.
Long story short, this is a harmless warning: it is merely notifying you that the socket connection was dropped. Since logic is in place to automatically reconnect, no user-visible effects manifest; we just have to deal with tons of log entries...
Let me reach out to the author of python-engineio and python-socketio – perhaps he'd be willing to tone down his logs a bit.

Thanks for offering to follow up.  In case the author is unwilling, what component can I suppress in the logger tobget rid of the entries?

You can suppress ambient_station.

I've tried the following lines in my logger config to suppress the warnings:
homeassistant.components.ambient_station: error
homeassistant.ambient_station: error
ambient_station: error
and I still get the warnings in my log

@yang3535 To confirm, you tried a configuration like this:
logger:
  default: info
  logs:
    homeassistant.components.ambient_station: error

?

Yes.
default: warn   logs:                                 # ignore events less than levels defined below     homeassistant.components.ambient_station: error

Not sure what's going on there, unfortunately. That said, looks like the python-engineio author is willing to downgrade the log level. More soon.

Following up: python-engineio has merged a PR to downgrade the log levels. As soon as it's included in a release, I'll update this component.


Removed unreachable SystemExit check.

This check dates back to Python <2.5, before Python introduced BaseException to prevent exactly unwarranted catching of SystemExit (and others).
response_for_exception() is only called under except Exception or except Http404 so it's now impossible for a SystemExit instance to reach the branch.

@adamchainz Thanks :+1:

@adamchainz Thanks :+1:


Update README.txt

This is an inactive fork, closing.  Feel free to submit your changes to upstream.

@timabbott consider archiving the repo instead?


How to connect to a specific share like \server\share?

Hi,
I have a Linux box serving up Samba shares and I'm trying to connect to a share using the chrome extension (on a chromebook). There's nowhere to put the share name, just the server IP. This confuses me as in my experience (and in all the samba documentation) you have to specify a share. (i.e. \server\share). And since different shares have different logins I am stuck as to how to authenticate without specifying one.
Is the extension incompatible with this (standard) server configuration, or am I just confused?
Cheers
Naomi

@layerzerolabs The latest version has a feature to discovery servers which can talk the SMB Protocol. You can call the feature by clicking the rope icon on the bottom of left of the this app's screen. Could you use the feature? Then, I would like to hear your feedback.

(It took me some time to find and find out that what you call the "rope icon" is actually the magnifying glass icon, or in other words: the find icon. :)
But how does this work? Both my servers are set to "browseable = yes" and they are not visible. My streamer on the other hand does not have a specific setting and is visible when clicking the magnifying glass icon.

I have te same issue. Only my browsable folders are mountable. On windows it does work, I just have to enter the specific folder. When I view all the folders shared it is not visible.
What this extention needs is another input field to manually set the share since it is not listed when you're browsing the share.

I have the same issue; my linux box has specific shares, and no way to specify them in the app. It doesn't show up when I click the search button at the bottom left (but a printer on our network does...)

I have the same issue as well. Some of my personal shares have been set as intentionally invisible so that non power users on my network won't get confused by all the options.  I still need the ability to specify those shares directly for myself, however.  I haven't found a way to get to those using this tool at this time.

@layerzerolabs @hvdwolf @0xR @jdsemma @dblegend Yesterday, I have released a new version 1.5.0. This version has a textfield to enter a shared resource name you want to mount. If you want to mount a mount point which has a "browsable=no", try the field. I'm happy you feedback the feature to me.

Unfortunately still doesn't work. I continue to get NT_STATUS_ACCESS_DENIED. Under Windows, my mount is referenced as <IP_ADDRESS>\jds.  (Internal IP, obviously.)  Under the Android app ES File Explorer, it is a forward slash instead. In all cases there is no domain name.
In the "shared resource name" field, I've tried "jds", "/jds", "\jds", "<IP_ADDRESS>/jds" and its backslash variant, all with the same error message. If I munge the password, it gives me NT_STATUS_LOGON_FAILURE, so it's definitely trying to connect, just can't connect to the right share.

@jdsemma Oh... I want to know a command which returned the ACCESS_DENIED. Could you check the debug log on the DevTools Console log?

At the risk of sounding dumb, any way to do that without being in DEV mode in the first place?   I was able to get it working for my various
hidden shares...  It's likely that I have them configured in some way that
is different from that of jdsemma.  I'll keep you updated if I run into any
other issues and am happy to help with troubleshooting however I can.
 Thank you for the report!
@jdsemma Thank you for the log. However, there is no ACCESS_DENIED. Could you find the ACCESS_DENIED error in your log on the console tab?

I cannot find ACCESS_DENIED anywhere. I've cleared the log, retried the connection, gotten the same result -- the log ends with "Packet", after the TreeConnectAndxRequest line.

@jdsemma Hmm... I guess that your server should record some errors about my app. Could you take a look some errors in your Samba server's log file? I cannot know the reason, because my app did output the error code only from your server...

The only line in my samba logfile is:
[2015/08/10 17:24:02, 1] smbd/service.c:make_connection(1167)
make_connection: refusing to connect with no session setup

One further bit of info that may be useful: I'm running samba v3.0.33-3.39.el5_8.

@jdsemma I found a bug regarding authentication. I have already released a new version 2.4.0 including code to fix the issue. See the following post for more detail: https://plus.google.com/u/0/+YoichiroTanaka/posts/EEJyicfnSqK
Could you confirm whether or not the new version works on your environment?

Successful connection! However I get "Some operations are taking longer
than expected. Do you want to abort them?" notification quite a lot, and it
seems to freeze (regardless of whether I abort or not.)
On Wed, Oct 21, 2015 at 7:30 PM, Yoichiro Tanaka<EMAIL_ADDRESS>wrote:

@jdsemma https://github.com/jdsemma I found a bug regarding
authentication. I have already released a new version 2.4.0 including code
to fix the issue. See the following post for more detail:
https://plus.google.com/u/0/+YoichiroTanaka/posts/EEJyicfnSqK
Could you confirm whether or not the new version works on your environment?
—
Reply to this email directly or view it on GitHub
https://github.com/yoichiro/chromeos-filesystem-cifs/issues/62#issuecomment-150062892
.

Successful connection! However I get "Some operations are taking longer
than expected. Do you want to
@jdsemma https://github.com/jdsemma I found a bug regarding
authentication. I have already released a new version 2.4.0 including code
to fix the issue. See the following post for more detail:
https://plus.google.com/u/0/+YoichiroTanaka/posts/EEJyicfnSqK
Could you confirm whether or not the new version works on your environment?
—
Reply to this email directly or view it on GitHub
https://github.com/yoichiro/chromeos-filesystem-cifs/issues/62#issuecomment-150062892
.

At least, @layerzerolabs didn't provide me more information. And, this issue has some different topics, Therefore, I close this issue. If you have a problem, you can register a new issue. Thank you for all feedbacks.