Use array args instead of string args for system command

This PR has the following changes:

Replace the string command with array command to avoid spawning a subshell before execute the child process. This also remove the need of escaping command and arguments, because the array form is treated literally.
Add ruby interpreter to run ruby script, so that it works on windows where shebang is not supported.

Closes #41

@dhh I have added some comments explaining the changes here. Would you mind take a look when you get a chance? Thanks.

Looks good!


Add ttnctl to package managers

[x] Brew
[ ] Apt repository
[ ] Snapcraft

This one can be considered as well http://snapcraft.io/

Already looked into Homebrew. We need to set up our own Tap for this, which is not quite hard.

@dorianamouroux snap craft looks very polished. I'll look into all of them this week.

Brew doc was moved: https://github.com/Homebrew/brew/blob/master/docs/Formula-Cookbook.md

I can do https://github.com/Homebrew/brew/blob/master/docs/Formula-Cookbook.md but it might make more sense for @htdvisser or someone else who's working on ttnctl to do this?

@htdvisser could you self assign this issue? I can't, but since you're already on it.

references https://github.com/Homebrew/homebrew-core/pull/10918

Homebrew formula is now done. Currently in a separate tap but we might want to submit a PR for homebrew-core when we're sure the builds are good.
In the meantime, this is what you need:
brew tap TheThingsNetwork/ttn
brew install ttnctl

Here's an Arch Linux AUR package: https://aur.archlinux.org/packages/ttnctl-bin/

Great work! Do you think we can somehow automate updating the package when new versions of ttnctl are released?

@htdvisser people can flag the package as out-of date on the AUR, then I get a notification. that mechanism usually works well. alternatively an e-mail notification by TTN on new releases for packagers would be nice too.

Will you be able to maintain the package, otherwise it might be a good idea to publish the package from a TTN account?
You can subscribe to new releases using feed:https://github.com/TheThingsNetwork/ttn/releases.atom

Sure, you can take over if you want. Do you have someone who is familiar with the PKGBUILD system?
As for the build script itself, it's pretty simple.

@rvolosatovs maybe?

I could do that.
Why don't we also set up a ttnctl-git, which would build from master, such that users always use up-to-date version? I think many arch users would prefer that over binaries and it almost doesn't need maintenance.
On the side note, I also propose adding a package in https://github.com/NixOS/nixpkgs , which I can maintain.

Sure, a ttnctl-git would also be an option.
@rvolosatovs what's your AUR username? I think I can add you as a contributor.

I can imagine that many people just want to install ttnctl, not install Go+all vendors and spend several minutes building from source, but sure, we could add a git/master alternative if needed. Should not replace the bin of course

@dbrgn rvolosatovs
@htdvisser I will

@rvolosatovs added you as maintainer. I think you should be able to publish releases too now.

We will no longer do this for v2, but it will be done for v3: https://github.com/TheThingsNetwork/homebrew-lorawan-stack


HTML Comments

How do I get and remove HTML comments?

Filter by NodeType.Comment in document.Decendents()

Yes, or you use one of the pre-made structures / helpers. See http://code.tutsplus.com/tutorials/html5-mastery-tree-traversal--cms-24843 for a short tutorial on them.


undefined method `private?' for #IPAddress::IPv6:0x00000112b61648

Why is there no "private?" method for IPv6 addresses? - this is annoying because I have to manually check if the object responds to :private before calling it :(

There is no real definition of a 'private' address in IPv6, you have Global, Unique Local (ULA) blocks which could be thought of a 'private', or Multicast. In fact the IPv4 definition of 'Private' (RFC1918) is only private by the fact that no ISPs route them (although you do see them on the internet from time to time)

Not specific to this issue, but, I do see this as being a very important part of networking and SDN.
Taking a look at rfc5735 and rfc5156 for IPv4 and IPv6 respectively, these special-use addresses should have some sort of interface within the IPv4 and IPv6 classes.
Open to thoughts on implementation and benefits..

There is no real concept of Private in IPv6, there is ULA (fc00::/7) which are technically private (well Not Routable anyway),

On 17 Jan 2015, at 22:13, xanview<EMAIL_ADDRESS>wrote:
Why is there no "private?" method for IPv6 addresses? - this is annoying because I have to manually check if the object responds to :private before calling it :(
—
Reply to this email directly or view it on GitHub https://github.com/bluemonk/ipaddress/issues/54.

Agreed on the #private? method.
I'd like to solicit some feedback in regards to having methods like #is_ula? and if it would be beneficial?  Playing off this, we can also do #is_teredo?, #is_6to4?, #is_orchid?, #is_doc?, etc..

That would be a good idea, I did add to another gem an address_scope method that returned a document string based on the address type, but the addition of something like this would be beneficial to the gem I believe

On 24 Mar 2015, at 16:39, Mike Simkins<EMAIL_ADDRESS>wrote:
There is no real concept of Private in IPv6, there is ULA (fc00::/7) which are technically private (well Not Routable anyway),

On 17 Jan 2015, at 22:13, xanview<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Why is there no "private?" method for IPv6 addresses? - this is annoying because I have to manually check if the object responds to :private before calling it :(
—
Reply to this email directly or view it on GitHub https://github.com/bluemonk/ipaddress/issues/54.


update AppSync example integration with the latest schema changes

See https://github.com/apollographql/apollo-federation-subgraph-compatibility/issues/166 for details.

@flochaz could you help us out with updating AppSync test integration with the latest schema changes?

I can't make @requires  to work and looks like it's the same for a many other implementation: The first reason seems to be that the docker hub image used in docker-compose for users service (apollo-federation-implementations/users) does not implement new schema (especially yearsOfEmployment). But even using local implementation (https://github.com/apollographql/apollo-federation-subgraph-compatibility/tree/main/subgraphs/users) I end up with the following error, any suggestion ?
{
  "data": {
    "product": {
      "createdBy": {
        "averageProductsCreatedPerYear": null
      }
    }
  },
  "errors": [
    {
      "message": "invalid content: Missing key `_entities`!",
      "locations": [],
      "path": [
        "product",
        "createdBy"
      ],
      "extensions": {
        "type": "ExecutionInvalidContent",
        "reason": "Missing key `_entities`!"
      }
    }
  ]
}

👋 Make sure to pull in the latest main and rebuild it locally using npm run setup - apollo-federation-implementations/users does implement the latest schema.
In order to test averageProductsCreatedPerYear make sure to run your queries through the router, since it @requires(fields: "totalProductsCreated yearsOfEmployment") those fields will only be populated if request flows through the router.

will do this week


show relative Crate process CPU usage

and display number of cores per node
Note: this feature will require Crate 0.52.x

ack


Merge master into python-sdk

Changes Unknown when pulling f1b8679c4af283d1e751043e2e765b7f295af0b2 on aaltay:merger into ** on apache:python-sdk**.

R: @dhalperi

This did not apply using the rebase script, so I just, er, made something up. Not happy, but as I understand it the Python branch does not yet follow the contribution guide.

Hope it's not broken.

Thank you @dhalperi. First postcommit after the merge was successful, (https://builds.apache.org/view/Beam/job/beam_PostCommit_Python_Verify/1110/). Nothing seems to be broken.
How should I applied rebase script? I could not find the information on the contribution guide.


docs: add documentation page for nodata handling

I've summarised the options and my recommendation for how to deal with nodata going forward in this repo, would be great to get all your eyes on this!

Hi @LukeWeidenwalker, I don't know why the suggestions didn't include the closing parts of the code blocks which I added, probably it's a bug of GitHub.
Please add them at the end of every code block, you can see the preview here https://github.com/Open-EO/openeo-processes-dask/blob/add-nodata-docs/docs/decisions/handle-nodata-in-rastercubes.md

@clausmichele @ValentinaHutter @SerRichard I'm flip-flopping on this issue again. I'm just looking at the specification of is_nodata (part of the legacy core profile) and if we go with the xarray way I proposed yesterday, there's no way that we can ever implement this process, because np.nan and nodata will effectively mean the same thing. I talked to a colleague about this over lunch and his take was that the only way of properly representing this is to use masked arrays. This can't be done as and when needed, any array we load from STAC into an xarray DataArray would need to be converted into a masked array immediately. Every process would need to work on underlying masked arrays.
I shied away from this in the beginning because, well, changing the default array container is kind of a big change. We'll have to make extra sure that the operations defined on this actually work - also with dask. Plus there's the performance implication of operations on masked arrays being slower overall (sometimes by quite a bit). And, it's not entirely clear how this would interfere with my plans for UC8 using sparse arrays.
But at this stage I really don't see a better way of implementing this requirement correctly. Please let me know what you think, or whether I'm missing something.

As far as I know each xarray object could have a nodata value assigned to in the metadata, and np.nan is a common one. https://corteva.github.io/rioxarray/stable/getting_started/nodata_management.html
Additionally, openEO process definitions are not written in stone and are open to suggestions and edits if a developer thinks it's necessary. So, in my opinion I wouldn't worry so much if we can't be 100% compliant with the specs, especially if the effort that requires to do that is too high compared to other important functionalities for a normal user.
Probably you could open an issue on openeo-processes for the is_nodata process and ask to VITO and SentinelHub how they implemented it.

I think regardless of how VITO and Sinergise have "implemented" this (in quotes, because from VITO I've understood that nodata is natively supported for all datatypes in geotrellis, they don't need to think about), I still have no feasible way of doing this in xarray/dask land.
The only feasible way I see of supporting the concept of null in openeo is to follow xarray and treat np.nan as equal to nodata. This begs the question of what to do about the is_nodata and is_nan processes, especially with respect to the upcoming "core profile" of processes. If we go ahead with the current plan, then we will not be able to support these two processes, because there will be no distinction in our backend.
@m-mohr Tagging you for advice here. Would it be an option to exclude these two processes from the core profile for the federation? We should be able to provide is_valid though. I don't expect that treating nodata and NaN the same internally would make a big difference in terms of results and reproducability.

The core profile will be agreed on in SAP09 with participation of all infrastructures.
By the way, "null" in openEO was always meant to be a placeholder for a nodata value chosen by the infrastructure. This can be nan, null, NA, -1, 255, ... whatever is suitable. It should be exposed in metadata though. As it's controlled behavior with informed users, I don't see an issue with is_nan and is_null.

@m-mohr Thanks for this input! I assume by metadata you mean something like https://github.com/stac-extensions/raster on the results?

Yes, for example (alternatives are the old file extension or the new classification extension)


docs: update README

This updates README with:

sections splitting and formatting
badges in markdown over HTTPS
build badge for travis
comparison to OrderSet
example with boolean returned on insertion

Thanks for this! I hope you'll forgive me for maintaining my formatting style a little. I also added links and reworded the orderset comparison. Let me know if you're happy with it.

👍


update_approved_tags_usecases

Status
Ready

@bakatzir check the preview - the lists are duplicated

The approved_usecases and approved_tags are being rendered automatically, see details in this PR: https://github.com/demisto/content-docs/pull/382
Hence, we will just need to update the approved lists in the content repo, and it will update in xsoar pan dev automatically.


npm install failed

"npm install" failed with the following information:
npm ERR! Darwin 16.1.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install"
npm ERR! node v4.4.5
npm ERR! npm  v2.15.5
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>prepublish: `node ./prepublish.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prepublish script 'node ./prepublish.js'.
npm ERR! This is most likely a problem with the doppiojvm package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node ./prepublish.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs doppiojvm
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls doppiojvm
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/coolman/Development/doppio/npm-debug.log

The log file is attached
npm-debug.log.zip

96411 info<EMAIL_ADDRESS>Failed to exec prepublish script
96412 verbose stack Error<EMAIL_ADDRESS>prepublish: `node ./prepublish.js`
96412 verbose stack Exit status 1
96412 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:217:16)
96412 verbose stack     at emitTwo (events.js:87:13)
96412 verbose stack     at EventEmitter.emit (events.js:172:7)
96412 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:24:14)
96412 verbose stack     at emitTwo (events.js:87:13)
96412 verbose stack     at ChildProcess.emit (events.js:172:7)
96412 verbose stack     at maybeClose (internal/child_process.js:827:16)
96412 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)

The install procedure assumes that node is installed to your system's path. Are you on Debian? You may need to install the nodejs-legacy package.

I am on MacOS Sierra.
node is available at /usr/local/bin which is in $PATH.
For me it seems that "includes/JVMTypes.d.ts" is missing.
Some of my console output:
Running "ts:dev-cli" (ts) task
Compiling...
Using tsc v2.0.3
console/doppioh.ts(23,27): error TS2307: Cannot find module '../includes/JVMTypes'.
console/doppioh.ts(24,26): error TS2307: Cannot find module '../vendor/java_home/jdk.json'.
console/doppioh.ts(657,45): error TS7006: Parameter 'item' implicitly has an 'any' type.
console/find_invalid_natives.ts(15,27): error TS2307: Cannot find module '../includes/JVMTypes'.
console/find_invalid_natives.ts(17,26): error TS2307: Cannot find module '../vendor/java_home/jdk.json'.

…

Running "includes:default" (includes) task
Fatal error: Could not run doppioh (exit code 1): Error: /Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:14842
	Buffer.from = function (value, encodingOrOffset, length) {
	            ^

TypeError: Cannot assign to read only property 'from' of function Buffer(arg, encodingOrOffset, length) {
	  // Common case.
	  if (typeof arg === 'number') {
	    if (...<omitted>...	}
    at Object.<anonymous> (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:14842:14)
    at Object.exports.byteLength (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:16420:31)
    at _webpack_require_ (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:30:30)
    at Object.<anonymous> (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:14709:19)
    at _webpack_require_ (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:30:30)
    at Object.<anonymous> (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:14703:78)
    at _webpack_require_ (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:30:30)
    at Object.defineProperty.value (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:50:18)
    at /Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:53:10
    at webpackUniversalModuleDefinition (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:3:20)

/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:14842
	Buffer.from = function (value, encodingOrOffset, length) {
	            ^

TypeError: Cannot assign to read only property 'from' of function Buffer(arg, encodingOrOffset, length) {
	  // Common case.
	  if (typeof arg === 'number') {
	    if (...<omitted>...	}
    at Object.<anonymous> (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:14842:14)
    at Object.exports.byteLength (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:16420:31)
    at _webpack_require_ (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:30:30)
    at Object.<anonymous> (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:14709:19)
    at _webpack_require_ (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:30:30)
    at Object.<anonymous> (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:14703:78)
    at _webpack_require_ (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:30:30)
    at Object.defineProperty.value (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:50:18)
    at /Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:53:10
    at webpackUniversalModuleDefinition (/Users/coolman/Development/doppio/node_modules/browserfs/dist/browserfs.js:3:20)
/Users/coolman/Development/doppio/prepublish.js:13
    throw new Error("Program exited with code " + code);
    ^

Error: Program exited with code 1
    at checkCode (/Users/coolman/Development/doppio/prepublish.js:13:11)
    at ChildProcess.<anonymous> (/Users/coolman/Development/doppio/prepublish.js:27:5)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at maybeClose (internal/child_process.js:827:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)

Whoa! Okay, that's interesting.
Also, JVMTypes.d.ts is generated in that doppioh step as part of bootstrapping. The build system (correctly) ignores type checking errors in the dev-cli step during bootstrapping. The issue is that doppioh fails for a bizarre reason.

I just successfully ran:
git clone https://github.com/plasma-umass/doppio
cd doppio
npm install

I'm on a Mac, too (the version prior to Sierra; haven't made the jump yet!).
I have Node v6 installed, though. So does Travis. But I don't understand why that would cause an issue.
You're running this from an up-to-date clone of Doppio, right?

I did exact the same as you tried on your Mac - all from scratch. My node is much older (4.4.5). I will check how to switch to the latest stable version...

That's frustrating; 4 should still work. :(
That error message is completely nonsensical, though.

Updated to v6. Same missing include - BUT its created in a later step and npm installed finished. Is this now a good or bad news? ;-)

@cool2man this is intentional.
JVMTypes.d.ts is dynamically generated by Doppio itself. But it is also required for TypeScript to typecheck Doppio during compilation.
Rather than check that gigantic file in, we do the following the first time you compile Doppio:

Compile Doppio with TypeScript with type checking errors ignored (causing the warnings you see). TypeScript can produce JavaScript even if type checking fails, since TypeScript is JavaScript with type annotations.
Runs Doppio's doppioh script to generate JVMTypes.d.ts.
Re-compiles Doppio for type-checking. Now, if type checking fails, the build fails.


I got this error when build

Please see on images

You may want to update the dependencies in the build.gradle file, as they haven't been touched for quite a while. Chances are that a lot of things have been deprecated since the last time I've worked on this project.


Maintenance of SimulationReportComponent class that is component of UsageOfDynamicSystemsGuide

The goal of the issue is to review and/or improve the class that implements report component within guides.en.py module,

The code was checked with the following call:
from dynpy.utilities.documents.document import UsageOfDynamicSystemsGuide

UsageOfDynamicSystemsGuide()

and the content of SimulationReportComponent  was checked


Update JSON.js

delete extra blank line in the Json output file.

I signed it!
2017-10-16 23:34 GMT+01:00 googlebot<EMAIL_ADDRESS>
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data https://cla.developers.google.com/clas and verify
that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If your company signed a CLA, they designated a Point of Contact who
decides which employees are authorized to participate. You may need to
contact the Point of Contact for your company and ask to be added to the
group of authorized contributors. If you don't know who your Point of
Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have
the pull request author add another comment and the bot will run again.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/foam-framework/foam2/pull/739#issuecomment-337063500,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfI89-0VBN2kzaQ7W3Ttib6pgFjHStSrks5ss9n9gaJpZM4P7VfJ
.

--
Cordialement,
Choura Hassene.


Colliders do not affect clothing

Check the AutoCollider class, it may be the one being used, or we might need to call a method to "re-apply" the changes.

This should be solved with 2.0, to test.


pip install -q piper-tts==1.2.0 >> No matching distribution found for piper-phonemize~=1.1.0

SoniTranslate> pip install -q piper-tts==1.2.0
ERROR: Could not find a version that satisfies the requirement piper-phonemize~=1.1.0 (from piper-tts) (from versions: none)
ERROR: No matching distribution found for piper-phonemize~=1.1.0

I was able to get around this.
I am using WSL2 Ubuntu-20.04, but it 'should' work for you as well
Go into WSL instance, or regular linux terminal
git clone https://github.com/rhasspy/piper.git
cd piper/src/python
sudo apt update
sudo add-apt-repository ppa:deadsnakes/ppa
sudo apt install python3.8 python3.8-venv python3.8-distutils python3.8-dev
python3.8 -m venv .venv
source ./.venv/bin/activate
python3.8 -m pip install pip==24.0
pip3 install --upgrade wheel setuptools
sudo apt-get install espeak-ng
cd ~
sudo apt-get install python3-dev

I removed the piper-phonemize line from the requirements.txt file located at: ~\piper\src\python\requirements.txt
pip3 install -e .
pip install torchmetrics==0.11.0
pip install six
sudo apt update
sudo apt install build-essential
./build_monotonic_align.sh

This repo is for Piper recording studio, not Piper itself.


[1.0.1 Version] Serial reader problem

Hi,
I confirmed that both topic writer and reader work with UDP.
However, in the case of Serial, the topic writer works well, but the reader does not work well.
UDP works fine with the same code, but serial does not work well, so it raises the issue that the agent is having problems.
Below is the link of the code I used for the actual test. (This works with OpenCR, Arduino MKR Zero.)

Arduino subscriber example

Topic and Reader are created normally, but Agent does not send any data to the client even if I send correct data using publish of ros2. On the other hand, when using UDP, the agent sends data to the client, and the callback is normally executed.
Which part should I debug more? Is there a debugging point in the Agent code in this regard?

Hi @OpusK,
I'm going to debug this issue. I will create a feature/serialdebug branch, in both Client and Agent in order to test this example. I think the problem could be related to the custom serial_protocol that we use. I hope to give you an answer as soon as possible.

Thanks @julianbermudez ,
Still no data is transferred to Serial (USB).
However, when I test this, I use the publisher (writer) with ROS2, and I do not know if the same problem I mentioned in the issue below could lead to this phenomenon.

#28

@julianbermudez
As I mentioned in the following issue, I tried to change the version of rmw_fastrtps and fastrtps in ROS2 in the way @BorjaOuterelo told me, and then try to run the Agent.

[1.0.1 Version] Related to XML and entity deletion.

However, there were some problems in the compilation process, which was caused by the difference between the submodule commit information of the fastrtps currently used by the agent and the commit information of the fastrtps release/1.7.0 branch.
The first error I saw was that the compiler could not find the header file due to a change in the include file location.
The header file is ParticipantDiscoveryInfo.h.
The header file no longer exists in the include path in the Agent code (from the release 1.7.0 branch).
Compiling and installing through the THIRDPARTY flag works fine, but when I work with the FastRTPS library installed on ROS2, another problem occurs as shown below.
$ MicroXRCEAgent serial /dev/ttyACM0
Serial agent initialization... OK
Enter 'q' for exit
RTPS Participant unmatched 3c.7f.<IP_ADDRESS>.1.f.3c.d2.f9.33|<IP_ADDRESS>
Segmentation fault (core dumped)

@BorjaOuterelo,
You said uROS Agent also uses Agent 1.0.1, do not you have the same problem as me?
Is it correct to match the commit version of fastrtps on ROS2 with the agent's submodule commit?

Hi, @julianbermudez
I have now confirmed that the mechanism of the callback function has changed.
Previously, topic_id was received with object_id, and now reader_id is received.
Anyway, I confirmed that it works normally.
I'm sorry to bother you. Thanks for your support!


New Updated curl to 7.65.1

Updated curl to latest version 7.65.1

@shubham769 can you please resolve conflicts and address review comments.


Reword ref to detailed instructions slightly

... to refer people to the quick specific instructions below instead of implying that they need to read the long instructions in the link.

Thanks Rob! Quarto was having a day yesterday, but this looks good to me


No packets seen on MQTT

None of the nodes show mqtt topics they are seen on,
see this for example: https://meshmap.net/#3662844492
Last seen	via	on root topic
5min ago 	self 	msh/IN/Bir/Alft
5min ago 	[!da529480] msh/IN/Bir/BU
The same node:
https://meshtastic.liamcottle.net/?node_id=3662844492
Shows:
No packets seen on MQTT

Also observed here - it looks like MQTT might be connected again but neighbour info is not updating?

No packets seen on MQTT

This feature relies on the server collecting all service envelopes. At this time, this feature is disabled on my public map. The UI should actually hide this section entirely in this case, but I had not got that far...
Also, it was implemented in the inverse to the meshmap site. My map would show the topics your own node was publishing to, not the topics that other nodes published your packets to.
This is probably a feature that should be revisited, but would require more tracking/tables in the database to make it work without having to store all of the received service envelopes.


Custom domains improvements

Currently we need to update the snapshot-spaces submodule whenever we want to add a new custom domain, leading to a PR for that submodule repo and then the UI repo.
I think this list of domains should be considered configuration and not code and therefore does not necessarily belong in a repository.
We already store the custom domains in the space settings in the DB. The json file is redundant and only exists as a simple solution to a problem that could be solved more elegantly (hopefully).

The custom domain value in the DB is not enforced to be unique. Therefore multiple spaces can enter the same domain. When snapshot is now accessed through this domain, we wouldn't have a way to tell which space to load/show.
The custom domain is part of the settings json data and not an indexed column of the spaces table. Therefore it is not easily possible to do a quick lookup when the UI loads.
Another problem is that we recently changed the required DNS setting for custom domains (CNAME=cname.snapshot.org) and now need a way to update/inform 657 spaces.

I would like to suggest a solution that solves all of this, while also improving the UX by removing the need for manually updating a whitelist. I want to put some effort into this because I think the custom domain feature (after expressing some criticism :P) is actually a critical and important feature, not just a "nice to have". In combination with skins it's a first, easy to implement level of customization for DAOs to make themselves and their community feel more "at home". (The second level of customization would be re-usable UI components plus snapshot.js for completely custom integrations.) I would like this to be as simple and automated as possible, especially when we're not talking about 6k spaces anymore but a million.

Domains must be a table column and unique.

To avoid accessing json fields in DB queries I would like to move the domain to it's own column, so we can do fast lookups. For the (currently) 657 spaces with a custom domain, this migration can easily be done by a script, accompanied by a few changes in the hub/graphql api. This would require some work but the changes are rather trivial and the domain field in the settings json is (as far as I can tell) not used at all anyway.

Domains must already have the correct CNAME record set, when updating the space settings.

To prevent spaces from squatting a domain they don't own, by adding it in their space settings, blocking it for anyone else, we can check the CNAME record first and allow only domains that already point to cname.snapshot.org. This can easily done with node.js in the hub. A legitimate space would configure the domain, update the space settings and that's it.

Information in the UI

By providing the CNAME check as an endpoint in the hub, the UI can give early feedback on the settings page and show an info box for admins, on all existing custom domains that have not yet updated their CNAME record.

With this setup we would not need to whitelist domains anymore and we can safely let spaces configure their domain DNS and update the settings and that's it. Less work for everyone and it's not even that much work required to implement it. In a week from now it could all be done, especially because I already did some work to find some unknowns. Given the long-term benefit I think that's more than reasonable.

Yes! Bye bye snapshot-spaces repo :)

Well, that would not even be necessary. It also hosts categories, verified spaces, skins,... But yea I'm definitely for moving that stuff over to the UI repo and get rid of the submodule. I don't see any benefits in having it.

I share your view and admittedly it's a small but a pain point as we got much incoming from users who activated their domain but lead to the homepage of snapshot rather than their space destination. https://github.com/snapshot-labs/snapshot/issues/2205 @mktcode
At present the domain field in the settings seems serve little purpose besides all work done in the domain.json and DNS config.
Your improvements: Configure DNS → put it in the domain field of settings → Save, That's it!
On ux side: No need activation and manually whitelist
On snapshot's side: changes of domain no longer need extra PRs to make it effect.
It will definitely worth the effort!

That make lot of sense, we can do this

TODO:
Hub:

add domain column (unique)
write script to migrate existing domain settings
adjust saving/editing/graphql accordingly
implement CNAME check (internal function and API endpoint)

UI:

change logic to rely on DB info instead of JSON file

requires some work on useApp.ts and router.ts

check CNAME on settings page
add CNAME info on custom domains

Hey @mktcode, @bonustrack, shall we proceed with this implementation?

I could work on this again early next month I think but anyone shall feel free. I'm currently just keeping the hub PR branch in sync with master.


⚠ Turnos 24x7 has degraded performance

In 879936b, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 942 ms

Resolved: Turnos 24x7 performance has improved in 0d14d3c.


⚠ PrivateHD has degraded performance

In cb9966c, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 726 ms

Resolved: PrivateHD performance has improved in f2891c9.


Simplify image vastly, get rid of R

- Inherit from jupyter/scipy-notebook, so we can reuse all the
  work in terms of setting up jupyterhub, conda, base scientific
  packages, etc. In particular, this should also load the env
  variables set by conda packages (like pyproject), solving
  https://github.com/2i2c-org/infrastructure/issues/2479
- Install only extra packages we want on top, prefering conda wherever
  possible. Bump up versions to latest.
- Get rid of everything R related, as those must move to the R hub.

Fixes https://github.com/2i2c-org/infrastructure/issues/2479
Ref https://github.com/2i2c-org/infrastructure/issues/2583 to
reduce complexity of our images.

There is a build failure:

 ---> Running in 55e452c14302

  Looking for: ['websockify', 'python=3.10', 'networkx=3.1', 'nltk=3.8', 'spacy=3.5', 'geopandas=0.13', 'geopy=2.3', 'astroquery=0.4', 'astropy==5.3', 'galpy=1.8', 'libgfortran==3.0.0', 'tensorflow=2.12', 'nbgitpuller=1.1', 'jupyter-resource-usage=0.7', 'jupytext=1.14', 'rise==5.7.1', 'jupyter_contrib_nbextensions==0.7.0', 'jupyter-server-proxy=4', 'contextily=1.3', 'libpysal=4.7', 'esda=2.4', 'splot=1.1', 'xlrd=2.0', 'numba=0.57', 'python-graphviz=0.20', 'pip']

    Pinned packages:

    - python 3.11.4

  Could not solve for environment specs
  The following packages are incompatible
  ├─ python 3.10**  is requested and can be installed;
  └─ tensorflow 2.12**  does not exist (perhaps a typo or a missing channel).
  Removing intermediate container 55e452c14302
  The command '/bin/bash -o pipefail -c mamba env update -p ${CONDA_DIR} -f /tmp/environment.yml && mamba clean -afy' returned a non-zero code: 1

Current problem:
 Could not solve for environment specs
  The following packages are incompatible
  ├─ libre2-11 is installable and it requires
  │  └─ libabseil >=20230802.1,<20230803.0a0 , which can be installed;
  └─ tensorflow 2.13**  is installable with the potential options
     ├─ tensorflow 2.13.1 would require
     │  └─ tensorflow-base 2.13.1 cpu_py311ha0be21f_1, which requires
     │     └─ libabseil >=20230125.3,<20230126.0a0 , which conflicts with any installable versions previously reported;
     ├─ tensorflow 2.13.1 would require
     │  └─ python >=3.10,<3.11.0a0 , which can be installed;
     ├─ tensorflow 2.13.1 would require
     │  └─ python >=3.8,<3.9.0a0 , which can be installed;
     ├─ tensorflow 2.13.1 would require
     │  └─ python >=3.9,<3.10.0a0 , which can be installed;
     └─ tensorflow 2.13.1 would require
        └─ __cuda, which is missing on the system.

But idk what package actually requires   libre2-11

This builds if I get rid of tensorflow, and I suspect https://github.com/conda-forge/tensorflow-feedstock/pull/353 may fix that. In the meantime, I am just getting tensorflow from PyPI.
https://github.com/conda-forge/rise-feedstock/issues/43 is causing RISE to fail to install from conda-forge as well.

Merging so we can deploy to staging and test.


Wrong position at popper js at 1300 720 screen

Wrong position.
https://i.imgur.com/qaN0WYc.png

But when I zoom out my screen it's OK.
Despite of this I think It will be fixed.

https://i.imgur.com/Vx3ue3y.png

That's because the examples have the flip modifier enabled. If there's not enough space on a side that go on the opposite


Add config file templates in the distribution

Just like issue #9 , the goal is to add templates files for job descriptor and database properties that can be directly modified by the user.
This will avoid guessing database properties keys or job descriptor attributes.
Another credit goes to @nabilov for this suggestion 👍

config file templates added in 72ea521934f59e32e26969e1585a3b88db09f596


Feature Request: Edit URL

Hey Netlifiers,
It would be quite handy if we could edit the URL of a site / article / page we want to publish or that already has been published.
The current behaviour is that the URL is being generated from the headline of the article, while the desired behaviour is that we are actually able to edit the URL — ideally even the date slug if exisiting (like on Smashing).

[ ] Add Edit URL, including the date slug
[ ] In Edit mode, add OK and Cancel

This should definitely happen, probably as a part of a general metadata widget in the entry editor UI.

Note: Netlify CMS isn't capable of setting a URL - your that happens between your build and deployment. What the CMS can influence is the slug. Updating the title accordingly.
Slug editing support is mentioned in (and will potentially land in) #180.

Closing in favor of #445. @indysigner please comment there if you feel that issue won't fully capture your intent and we can expand.


DM-3212 Rescue

Greetings,
I did some wrong manipulations on  my DM-3212.
When i plug  the badusb, my os (Debian) doesn't recognize it through lsusb command.
No information in the kernel neither (dmesg command)
But when i press the reset button and quickly type lsusb, the system recognize it.
in the kernel i see the following :
usb 1-2: new full-speed USB device number 102 using xhci_hcd
usb 1-2: New USB device found, idVendor=2341, idProduct=0036, bcdDevice= 0.01
usb 1-2: New USB device strings: Mfr=2, Product=1, SerialNumber=0
usb 1-2: Product: Arduino Leonardo
usb 1-2: Manufacturer: Arduino LLC
cdc_acm 1-2:1.0: ttyACM0: USB ACM device
usb 1-2: USB disconnect, device number 102

sometimes (but not always) followed with
xhci_hcd 0000:00:14.0: WARN Cannot submit Set TR Deq Ptr
xhci_hcd 0000:00:14.0: A Set TR Deq Ptr command is pending.
xhci_hcd 0000:00:14.0: WARN Set TR Deq Ptr cmd failed due to incorrect slot or ep state.

Arduido IDE detect for a short moment the port.
The device quickly go off and I doesn't have the time to do anything.
(Device seems to be powered on for approximately 8sec with the red LED blinking)
I Suspect that i pushed some code in the wrong memory place, maybe I destroyed the firmware or the bios ?
Unfortunately i just started messing with this kind of hardware and my knowledge is limited in this area, i would greatly appreciate any advice.
any ideas ?
Best regards.

Try fixing the device with this:
1.- Connect the device without the jumper (your PC doesn't have to recognize the device)
2.- Open Arduino IDE
3.- Open the scketch Blink (basic sketch)
4.- Tools -> Board: Arduino Leonardo
5.- Upload sketch button
6.- When the Arduino IDE looked for the ttyACMX or ttyUSBX ports, press the reset button on the device
Thanks!


The -p option doesn't work on Windows (I think)

Given the following file, cmp_eq.laye:
// R %lcc --ir %s
// d b [a-zA-Z0-9\.]+

// * main : i32():
// +   $b:
// +     return i32 69
i32 main() => 69;

this doesn't work
D:/Programming/strema/2023/InterceptRewrite/fchk/out/fchk.exe "-p" "//" "-l" "." "-D" "lcc=D:/Programming/strema/2023/InterceptRewrite/bld/lcc.exe" "-P" "re" "-P" "nocap" "D:/Programming/strema/2023/InterceptRewrite/tst/laye/cmp_eq.laye"

with the errors seen above regarding not finding an R directive.
Given the following file, cmp_eq.laye:
// FCHK-PREFIX //
// R %lcc --ir %s
// d b [a-zA-Z0-9\.]+

// * main : i32():
// +   $b:
// +     return i32 69
i32 main() => 69;

this does work
D:/Programming/strema/2023/InterceptRewrite/fchk/out/fchk.exe "-l" "." "-D" "lcc=D:/Programming/strema/2023/InterceptRewrite/bld/lcc.exe" "-P" "re" "-P" "nocap" "D:/Programming/strema/2023/InterceptRewrite/tst/laye/cmp_eq.laye"

So I added FCHK_PREFIX // to a few of the laye test files, but it doesn't take precedence over -p (big sad), so I removed line 336 (PREFIX "//"), and it turns out now those work. So it seems to definitely almost certainly maybe but probably not be -p just isn't working. Or I dunno.

maybe it's aaaaaaaaaa string_view?

I fixed it. It's the moving into a string_view part that is probably UB and Windows handled it differently than Linux (as is always the case when UAF bugs are in question). I suggest making Context::preview member a std::string, not a std::string_view, as that worked to fix it on my machine, and I can't see it bollocking yours.


Clicking the 'quote' button on a single link crashes the editor

Describe the bug
Creating a quote over a paragraph containing a single link crashes the editor.
To Reproduce
Steps to reproduce the behavior:

Create a paragraph with some text
Click on the paragraph and create a 'link'
Click on 'quote'
The editor crashes

Expected behavior
The editor should display a quote containing the link

The error trace from Chrome:
Uncaught (in promise) TypeError: Cannot read property 'nodeRefs' of undefined
    at search (slate-react.es.js:2185)
    at search (slate-react.es.js:2186)
    at search (slate-react.es.js:2186)
    at findDOMNode (slate-react.es.js:2190)
    at onQuery (slate.es.js:9240)
    at next (slate.es.js:11164)
    at onQuery (slate.es.js:9239)
    at next (slate.es.js:11164)
    at Editor.run (slate.es.js:11198)
    at Editor.query (slate.es.js:11062)

Hi @jeromesimeon, it must have been fixed by now as I tried recreating the issue with whatever you've suggested but couldn't encounter it, here's the link to the video reference https://www.loom.com/share/89b49297903543e7a37572cd8f2323df
Thank you

@jeromesimeon this was fixed in markdown-transform 0.9.10 correct?

@irmerk I think so! Closing this issue.


Signed release

Hey @diafygi
I think it would be beneficial if you could create a signed git tag (git tag --sign) when you feel a version of acme-tiny can be released. This would allow projects which use your nice client to pin a specific version and check the OpenPGP signature.

Dupe of https://github.com/diafygi/acme-tiny/issues/140
Or do you really think two issues for signing commits & releases/tags are needed?
I think if one thing is done, the other thing is also done too.

Agreed, merging with #140


Cannot find block

Was porting my OC Autocraft script, when I saw that CC didn't support RS, and luckily you just release this mod.
But when I installed it in FTB Direwolf20 1.16 v1.2.0 pack, I cannot find the block.
Mod list ingame says the mod is loaded. Uses for an interface only shows Fluid Interface.
Any ideas?

Nevermind, mod wasn't loading on server for some reason, works now. Thanks for this mod!

Nevermind, mod wasn't loading on server for some reason, works now. Thanks for this mod!


Applying Sharp placeholder

Hello, I want to apply a sharp placeholder to the images generated by this plugin.
See this issue for the specific placeholder manipulation that we are after.
https://github.com/lovell/sharp/issues/1532
Is it possible to apply existing sharp placeholder options to this plugin or will an external library be required?
Thanks,

In the options, you can use sharpOptions to pass on options to Sharp.
Does that work for your use case?


Keys on an alternative layout

Thanks for this nice crate. I use an alternative keyboard layout on macOS. It seems that use_hotkeys! detects physical keys. Is there a way to detect a key on the alternative layout?

TLDR: No, we use code(). This is a selfish design choice, so we'll need to change this. Feel free to attack this issue!
Local development workaround: Use the debug feature flag to see the code of a given key press in your browser console. Use that as it's key id when you write your macros.
Yeah I've been thinking about this dilemma. I originally used key() as the key identifier, but I ran into issues.
This lead to a fork in design and I chose code() as the key identifier.
The MDN docs seem to point out why using code() might be a bad choice:

This property is useful when you want to handle keys based on their physical positions on the input device rather than the characters associated with those keys. Be aware, however, that you can't use the value reported by KeyboardEvent.code to determine the character generated by the keystroke, because the keycode's name may not match the actual character that's printed on the key or that's generated by the computer when the key is pressed.
For example, the code returned is "KeyQ" for the Q key on a QWERTY layout keyboard, but the same code value also represents the ' key on Dvorak keyboards and the A key on AZERTY keyboards. That makes it impossible to use the value of code to determine what the name of the key is to users if they're not using an anticipated keyboard layout.

So I guess this means anyone who isn't using QWERTY is SOL? This is pretty bad.

To determine what character corresponds with the key event, use the KeyboardEvent.key property instead.

We should revert back to key(). And handle this edge case.
Let me know if you want to work on this issue @rkimoakbioinformatics!
ccing: @JustBobinAround @zakstucke @maxbergmark on their thoughts

Thanks for the explanation. I have created a PR to solve both alternative keyboard layouts and the space bar. Would this work?

#127

Hey @rkimoakbioinformatics! I'm a bit late to the party, but from some local testing it seems that this has been a bit of a breaking change. From the links you posted above, the code() returns e.g. "KeyA", while key() returns "a". This isn't a major problem, but it will of course break any existing implementation that are using alphanumeric hotkeys (digits are changed from e.g. "Digit1" to "1"). This change needs to be documented, and probably needs a new version to avoid breaking existing projects.

Oh indeed. Sorry about that. I can think of two possible solutions:

Documenting this as a breaking change.
Convert "keya" to "a", "digit1" to "1", etc. when parsing user hotkey combinations. I guess this parsing happens only once and if so, performance hit by this may be negligible?

That sounds great. Thanks.


Removes/ revokes certs after success

Not sure if there is a flag I missed; I am seeing an issue where after a successful cert it then revokes and deletes the cert.

Could you provide the domains.conf and the container log to see what happened ? Some people saw a bug before, where in some cases my container would not see the first line of domains.conf, and would assume with a one line file that everything was removed from configuration, and so the certificates should be removed.
Normally it is corrected so be sure to use the latest version, but I will check the behavior with your log.

Thank you, I found the problem. File domains.conf was parsed correctly during certificates creation phrase, but not during certificates revocation phase.
Version 2.5.0 is on its way, and corrects this issue.

Just updated to 2.5.0 and looks to still be unresolved. Attached are latest log files.
LE-Log1.txt
dockerLog.txt

Hello, sorry for the delay, I am on hollydays...
Could you provide me your domains.conf? It needs to be the exact file you try to use, not a copy of its content, in order to allow me to check against encoding issues.

Hello, I made a new version for a similar problem (#26). Could you say to me if your bug is correct with the latest version (2.5.1) ?

looks like its still failing on 2.5.2

OK, I got it! In you domains.conf, you have declared your domains separated by a comma, while they should be separated by a space.
Even if it works for certbot because it accepts multiple domains separated by commas in a single
-d option, it will not work with my scripts when they verify if a certificate needs to be revoked.
Use spaces instead of commas to solve you issue.
I am quite aware that the weak formatting of domains.conf becomes a problem. I am working on a new version way more stable and modulable, using python scripts and yaml configuration files.

I assume the issue is closed. Do not hesitate to reopen if it does not work.

I encountered the same effect. Certs would be successfuly requested and stored and at the end got revoked again.
After reading here that the domains.conf may be the problem I checked it again.
Turns out that with coping through a windows system, the line endings had been turned into windows line entings (CR LF). So I converted the line endings to unix (LF) and that fixed the problem.
Note:
I used Notepad++ through WinScp to: Edit->EOL Conversions->Unix (LF) on domains.conf


Unable to run make serve: "celery" executable file not found in path

I’ve taken a clean checkout of the repository at commit f392327, but I’m unable to run the make serve command.
When I run make serve to start a local environment, it exits with an error. I’ve posted full output from a clean run in a Gist; below is the output when I run the command a second time:

alexwlchan at Alexs-iMac.local in ~/D/warehouse on git:master
$ make serve
docker-compose up
warehouse_redis_1 is up-to-date
Starting warehouse_app_1
warehouse_db_1 is up-to-date
warehouse_rabbitmq_1 is up-to-date
warehouse_static_1 is up-to-date
warehouse_elasticsearch_1 is up-to-date
Starting warehouse_worker_1
ERROR: Cannot start container 8b4f7a1476c15725720508ec5dc3ef5be82fb54942b55c6fcdb6b52ca583ed6b: [8] System error: exec: "celery": executable file not found in $PATH
make: *** [serve] Error 1
Before I blow away my environment and start over (which I’d rather avoid, because it took quite a while to get to this stage, and it could easily fail in the same way again), any suggestions for what I should do next?

Further, possibly useful info:
The container is definitely known to Docker, and trying to run a celery command:
$ docker ps --all | grep 8b4
8b4f7a1476c1        warehouse_worker    "celery -A warehouse "   6 minutes ago       Created                                                          warehouse_worker_1

If I look inside the warehouse_worker image for celery-name-like files, I haven’t found anything useful:
$ docker run -it warehouse_worker sh
# find / -name *celery*
/app/warehouse/celery.py
/app/tests/unit/test_celery.py
# python /app/warehouse/celery.py -A warehouse
Traceback (most recent call last):
  File "/app/warehouse/celery.py", line 13, in <module>
    import celery.backends
  File "/app/warehouse/celery.py", line 13, in <module>
    import celery.backends
ImportError: No module named 'celery.backends'; 'celery' is not a package

Software versions:

OS X 10.11.1 (15B42)
Docker version 1.9.1, build a34a1d5
docker-compose version: 1.5.1

Can you try with #809? Make sure you run make purge first to clear out any state and see if it works?

Indeed, running make purge and using the tip of dstufft:dont-rebuild (PR #809) seems to have got me past the celery issue. Thanks!

Should be fixed in master now. Sorry about that!


Difficult to override checkbox styling

The current bs-form HTML structure for form label & elements makes it difficult to override checkbox styling.
See: https://medium.com/claritydesignsystem/pure-css-accessible-checkboxes-and-radios-buttons-54063e759bb3
Currently the label element wraps the form element, instead, label & input element should be siblings (making use of the for attribute).
I'm happy to attempt a PR for this at some point in the near future.

You are right. I guess this originates from the old BS3 markup, where this was different by default: https://getbootstrap.com/docs/3.3/css/#forms-controls.
Should be pretty easy. The for attribute is already set, just needs to move the {{yield}} out of the label here, AFAICT:

https://github.com/kaliber5/ember-bootstrap/blob/master/addon/templates/components/bs4/bs-form/element/layout/vertical/checkbox.hbs
https://github.com/kaliber5/ember-bootstrap/blob/master/addon/templates/components/bs4/bs-form/element/layout/horizontal/checkbox.hbs

Cool, that looks easier than expected, I was looking at modifying the bs-form/element/label.hbs component directly, but your way seems better.
I'll take a look


Add LICENSE to repos across dotcom

james-dow created the following on Apr 26:
As a contributor I sometimes need to understand what license is used so I can confidently decide whether I can use your project or not
Including a detectable license in our repository, people who visit your repository will see it at the top of the repository page. This is an absolute must with our public repos like IBM/carbon-addons-dotcom, but for consistencies sake and communication purposes it might be a good idea to add to our projects across the board. This is important and potentially has legal implications.
Carbon, and our add-on is using Apache License 2.0

Resources for reference

GitHub Help: Adding a license to a repository
GitHub Help: Licensing a repository

Acceptance criteria

[ ] LICENSE.md file exists for v18 within .github folder.
[ ] LICENSE.md file exists for v18-starter-kit within .github folder.
[ ] LICENSE.md file exists for v19a within .github folder.
[ ] LICENSE.md file exists for patterns within .github folder.
[ ] LICENSE.md file exists for digital-design within .github folder.
[ ] LICENSE.md file exists for carbon-integration-poc within .github folder.
[ ] LICENSE.md file exists for northstar-external-website within .github folder.
[x] LICENSE.md file exists for IBM/carbon-addons-dotcom within .github folder.
[ ] [TBD: #726] LICENSE.md file exists for IBM/dotcom-services within .github folder.
[ ] [TBD: #743] LICENSE.md file exists for IBM/dotcom-bundles within .github folder.
[ ] [TBD: #695] LICENSE.md file exists for IBM/dotcom-website within .github folder.

Original issue: https://github.ibm.com/webstandards/digital-design/issues/752

On Apr 26, vladislav-saling commented:
@james-dow Do we need to run a license scan for vendor code? (e.g. with v18).

On Apr 26, james-dow commented:
Not sure, what do you mean by vendor code?

On Apr 26, vladislav-saling commented:
Select2, greensock etc. I spoke about these things with dev from knowledge center some time ago and he mentioned, that when they generate/make/create their licence it has to be aligned with licences or libraries, that their project is using (I think it was something along the lines, that you need to make sure that your own license doesn't contradicts license on vendor code). I am currently trying to confirm that.
However, this is only about v18 as far as I can tell.

Obsolete.


Fixed isSubscribe condition to support also producers

In the case when we have a producer, the mapOperation method is called with mapOperation(undefined, {..}).
As undefined is not null the condition subscribe !== null is always true.  This leads to an exception because we choose also the if path for the subscribe when subscribe is undefined (the case when have a producer).

Thanks! I am soon releasing support for producers and without this fix I would have probably wasted hours hunting this down.


boards: atsamd20_xpro: Add led/button info to DTS

Add on-board LED and button definitions to the Atmel SAM D20 Xplained Pro (atsamd20_xpro) device tree.

Codecov Report

Merging #10874 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10874      +/-   ##
==========================================
+ Coverage   53.32%   53.34%   +0.01%
==========================================
  Files         215      215
  Lines       25887    25887
  Branches     5705     5705
==========================================
+ Hits        13804    13809       +5
+ Misses       9763     9758       -5
  Partials     2320     2320

Impacted Files
Coverage Δ

subsys/logging/log_core.c
78.4% <0%> (+2.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34da1a...4cfb321. Read the comment docs.


merge-with-parent fails during the Set Git Identity step

Orb version
2.9.0
What happened
Set Git Identity step fails when there is no Git identity configured:
#!/bin/bash -eo pipefail
USER_EMAIL=$(git config --get user.email)
USER_NAME=$(git config --get user.name)

if [ "$USER_EMAIL" = "" ]; then
  git config user.email<EMAIL_ADDRESS>fi
if [ "$USER_NAME" = "" ]; then
  git config user.name "CircleCI"
fi

Exited with code exit status 1
CircleCI received exit code 1

The reason is that git config --get user.email returns non-zero return code. Example from SSH debug session:
circleci:~/project$ git config --get user.email
circleci:~/project$ echo $?
1

Expected behavior
Should successfully set default Git identity when there's no current identity configured at all.

FWIW my team is seeing the same issue.
ccing a few folks who might have worked on this: @gmemstr @iynere
Thanks!


docs: update README

Summary
Updated README with the latest setup steps. Closes https://github.com/tablelandnetwork/go-tableland/issues/539.
Context
The README was outdated and inaccurate, and we had internal docs already describing the newer steps required.
Implementation overview
N/A
Implementation details and review orientation
N/A
Checklist

[x]  Are changes backward compatible with existing SDKs, or is there a plan to manage it correctly?
[x]  Are changes covered by existing tests, or were new tests included?
[x]  Are code changes optimized for future code readers, commenting on problematic areas to understand (if any)?
[x]  Future-self question: Did you avoid unjustified/unnecessary complexity to achieve the goal?

I referenced everything from the Notion doc with some tweaks here and there, so lmk if there's anything missing or misinterpreted!

@avichalp adjusted the README with your feedback—lmk how it looks, and then i can also duplicate this on our docs site if it looks good.