Fix uninitialized constant issue

This PR modifies both LongLivedToken and LongLivedClient to prevent an uninitialized constant of OmniAuth::OAuth2::AccessToken

I've just switched back to the version currently in rubygems and hit this error.
Can we merge and bump version please? Thanks!

Fixed in v1.0.4. Thanks.


doesnt seem to work on EU zone

I have everything setup as described. Sending the email via US zone works. Sending it via EU doesn't work. I get the error :
FormatException: Unexpected character (at character 1) I/flutter (17973): Forbidden I/flutter (17973):
I saw online that there was suppose to be another parameter called host thats suppose to be set up like this : host: "api.eu.mailgun.net" but there is no such parameter for this package.

I believe there was a domain for mailgun. For example
import 'package:mailgun/mailgun.dart';

var mailgun = MailgunMailer(domain: "my-mailgun-domain", apiKey: "my-mailgun-api-key");

That domain param doesnt purtain to that. It refers to the email domain. For example mg.mydomain.com.
What i am refering to is the server zone u have to select when you first sign up to mailgun. US or EU.

Anyway, i was able to solve it by downloading the package code manually and literally changing the zone url to api.eu.mailgun.net which is great because now i can have null safety and dont have to add this extra package to pubspec

Thank you.


install

how to install ?

Instalation:
Download Sublime Text 4, there’s a portable option:
https://www.sublimetext.com/download_thanks?target=win-x64-portable
Extract the zip, let’s assume the extraction folder is SublimeText. Go to:
SublimeText\Data\Installed Packages and paste the AMXXEditorV4.sublime-package file.


KAFKA-4929: Transformation Key/Value type references should be to class name(), not canonicalName()

Changing getCanonicalName() references to getName() so that docs update with "$" instead of ".".  Also added a connect-plugin-discovery.sh CLI to list all of the transformations available.

cc @gwenshap

Huge props for making the error message and doc output include the right description. Current situation is very misleading.
Few comments:

The new CLI is exposing what looks to me like an internal method to users. I'm all pro helping discovery, but this may need a mailing list discussion / vote. @ewencp?
It will be nice to add few words about the new CLI to docs/connect.html. There's currently literally no description on what this does, how to use it, etc.
Can you post a sample output of the log messages in the JIRA, so people can see "before/after"?

Other than that, the change looks small and safe so +1, pending the possible short KIP for the new CLI and adding the docs. I'll also be happy to get this in if you remove the CLI and submit it in separate PR since it may require additional process. We can fix the errors faster this way.

Thanks.  The SMTs are pretty cool.  I've removed the connect-plugin-discovery.sh from this PR.

Tested by generating the docs. LGTM. Thank you for fixing this.


FNIRSI GC-01: Battery question and suggestions

Hello, I'm new to forums. Greetings to all.
I have a fnirsi gc-01 and I'm using this new firmware, which I'm really liking.
I changed the battery from 1100ma to a 3000ma battery for my gc-01, with the factory battery it lasted about 12 or 13 hours working, when I put the 3000ma it lasted about 24 hours.
I installed the firmware two days ago and this testing the autonomy of the gc-01 and it has been in use for 43 hours, with conservative configuration.
The battery indicator does not work according to the battery capacity. According to the battery indicator, it ran out after 24 hours or so and now it is still working but I don't have data on what's left of the battery, it's an uncertainty.
And if any suggestion is accepted, I would miss a text-style screen where you can see at a glance several parameters, such as instantaneous dose, average, cumulative and some maximum, since I consider this firmware beautiful and elegant, but too minimalist. I also echo the original screen or original firmware, at the top and bottom ends where it says current date and current time at the top and begindate and lifetime at the bottom. I consider important data. In the latest FirmaWare update I don't see the date anywhere.
Thank you and greetings.

Moving to discussions as this is not an issue (#32).


Best way to do DefaultRedirectRoute

My problem is exactly like this https://github.com/rackt/react-router/issues/622, DefaultRedirectRoute would be the idle way to handle this. Nearly 1 year has passed, cannot find DefaultRedirectRoute in the code base, what's the idle way to handle this in 2015?

the 1.0 matching algorithm removes the need for all of this, if you'd like to post a sample route config for what you're trying to do I can show you what it looks like in 1.0.
Also:
https://github.com/rackt/react-router/issues/1333#issuecomment-113165238

In our project we use DefaultRoute in the following style:
<Route path="users">
  <DefaultRoute name="AllUsersPage" component={AllUsersPage}/>
  <Route path="top" name="TopUsersPage" component={TopUsersPage}/>
  <Route path=":userId">
    <DefaultRoute name="UserProfilePage" component={UserProfilePage}/>
    <Route path="photos" name="UserPostsPage" component={UserPostsPage}/>
    <Route path="comments" name="UserCommentsPage" component={UserCommentsPage}/>
  <Route/>
<Route/>

And we handle all links and transitions by names.
Should we stop using nested routes in such manner with router-1.0.0?


Nothing happens after [improve] is pressed

There wasnt any text box of GPT response below the Original.
The suggestion papers are there instead.

Are you able to see if the OpenAI chat completion request completes successfully from DevTools?


Doc updates

Quick scanning, the following should be corrected:

"Does Dask have a SQL interface": yes it now does (if perhaps not fully featured)
paid support: add Coiled? others (saturn)?
main page Supported By: there was discussion on how to add logos here, but I would say Coiled, Saturn, CapitalOne, Prefect should be here. Also, an older page Funding should be the same with more details, or just removed.

#6823

(Disclaimer, I have a financial bias here)

paid support: add Coiled? others (saturn)?

My sense is that Quansight is still happy to provide Dask support.
Coiled certainly does this (we have active Dask support contracts today)
I don't think that Saturn currently offers this except for people who work on Saturn Coud (but I could be wrong)

main page Supported By

Agreed on Coiled, Saturn, Capital One, Prefect.  Maybe we want to drop HHMI.  I would suggest that we keep Quansight for a year, under the assumption that they may hire someone else to do this in that time.

https://www.quansight.com/dask
"For more help with Dask for your business, connect with us and we can give you a full systems evaluation to find out if you are getting the most out of your data science software."
cc @jsignell for the saturn view on paid dask support
Discussion on "supported by": https://github.com/dask/community/issues/44 and https://github.com/dask/community/issues/51 (but no action taken) for reference. But I will go ahead and change the list of logos, unless someone disagrees.

Yep I agree that Saturn belongs in "supported by" and not in "paid support". I'll also suggest listing the companies alphabetically.

slight follow on here
https://docs.dask.org/en/latest/support.html#paid-support
What that suppose to be updated?
Correct me if i'm wrong was it decided not to list the companies in the dask docs https://docs.dask.org/en/latest/ i.e. only https://dask.org/

What that suppose to be updated?

Not according to the discussion - there are several companies that provide services around Dask, but not of the kind of feature-for-cash contracts that Anaconda and Quansight have been involved in in the past.

was it decided not to list the companies in the dask docs

There was no concrete decision on this. The main page shows a different list of associated companies/institutes involved with dask development and maintenance, mainly by paying (some of) the salary of one of the team.

Thanks. I was after a link for the companies. Opened an issue here: https://github.com/dask/dask.github.io/issues/40


start a wiki page for open data portal team - how to screen for PIRs

here is a test comment

here is  another test comment... it's from Waffle!!!


K8S 1.7 is failing to start on RHEL 7.3 with Native Docker 1.10

Rancher versions:
rancher/server: v1.6.3
kubernetes (if applicable):  rancher/k8s:v1.7.0-rancher3
Docker version: (docker version,docker info preferred)
Native Docker 1.10.3 (docker-1.10.3-59.el7.x86_64)
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
RHEL 7.3 with SELinux enforced
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
AWS
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
single node rancher
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
kubernetes
Steps to Reproduce:

Deploy kubernetes 1.7

Results:
Addons and new pods won't start
Name:		tiller-deploy-737598192-dvwhq
...............
Reason			Message
  ---------	--------	-----	----							-------------	--------	------			-------
  5m		5m		4	{default-scheduler }							Warning		FailedScheduling	no nodes available to schedule pods

$kubectl get nodes
NAME                                           STATUS    AGE
ip-172-16-100-135.us-west-2.compute.internal   Ready     9m
ip-172-16-100-225.us-west-2.compute.internal   Ready     9m
ip-172-16-100-24.us-west-2.compute.internal    Ready     9m

Kubelet Logs:
7/14/2017 3:12:49 PME0714 12:12:49.565953   19341 kuberuntime_manager.go:618] createPodSandbox for pod "heapster-4285517626-x4xbx_kube-system(667efce8-688c-11e7-bb67-027b0bd08231)" failed: rpc error: code = 2 desc = failed to create a sandbox for pod "heapster-4285517626-x4xbx": Error response from daemon: cgroup-parent for systemd cgroup should be a valid slice named as "xxx.slice"
7/14/2017 3:12:49 PME0714 12:12:49.565979   19341 pod_workers.go:182] Error syncing pod 667efce8-688c-11e7-bb67-027b0bd08231 ("heapster-4285517626-x4xbx_kube-system(667efce8-688c-11e7-bb67-027b0bd08231)"), skipping: failed to "CreatePodSandbox" for "heapster-4285517626-x4xbx_kube-system(667efce8-688c-11e7-bb67-027b0bd08231)" with CreatePodSandboxError: "CreatePodSandbox for pod \"heapster-4285517626-x4xbx_kube-system(667efce8-688c-11e7-bb67-027b0bd08231)\" failed: rpc error: code = 2 desc = failed to create a sandbox for pod \"heapster-4285517626-x4xbx\": Error response from daemon: cgroup-parent for systemd cgroup should be a valid slice named as \"xxx.slice\""
7/14/2017 3:12:50 PMI0714 12:12:50.553239   19341 kuberuntime_manager.go:457] Container {Name:tiller Image:gcr.io/kubernetes-helm/tiller:v2.3.0 Command:[] Args:[] WorkingDir: Ports:[{Name:tiller HostPort:0 ContainerPort:44134 Protocol:TCP HostIP:}] EnvFrom:[] Env:[] Resources:{Limits:map[] Requests:map[]} VolumeMounts:[{Name:io-rancher-system-token-b0xns ReadOnly:true MountPath:/var/run/secrets/kubernetes.io/serviceaccount SubPath:}] LivenessProbe:&Probe{Handler:Handler{Exec:nil,HTTPGet:&HTTPGetAction{Path:/liveness,Port:44135,Host:,Scheme:HTTP,HTTPHeaders:[],},TCPSocket:nil,},InitialDelaySeconds:1,TimeoutSeconds:1,PeriodSeconds:10,SuccessThreshold:1,FailureThreshold:3,} ReadinessProbe:&Probe{Handler:Handler{Exec:nil,HTTPGet:&HTTPGetAction{Path:/readiness,Port:44135,Host:,Scheme:HTTP,HTTPHeaders:[],},TCPSocket:nil,},InitialDelaySeconds:1,TimeoutSeconds:1,PeriodSeconds:10,SuccessThreshold:1,FailureThreshold:3,} Lifecycle:nil TerminationMessagePath:/dev/termination-log TerminationMessagePolicy:File ImagePullPolicy:Always SecurityContext:nil Stdin:false StdinOnce:false TTY:false} is dead, but RestartPolicy says that we should restart it.
7/14/2017 3:12:50 PME0714 12:12:50.553349   19341 kubelet_network.go:139] Search Line limits were exceeded, some dns names have been omitted, the applied search line is: kube-system.svc.cluster.local svc.cluster.local cluster.local kubelet.kubernetes.rancher.internal kubernetes.rancher.internal rancher.internal
7/14/2017 3:12:50 PMI0714 12:12:50.557916   19341 kuberuntime_manager.go:457] Container {Name:grafana Image:gcr.io/google_containers/heapster-grafana-amd64:v4.0.2 Command:[] Args:[] WorkingDir: Ports:[{Name: HostPort:0 ContainerPort:3000 Protocol:TCP HostIP:}] EnvFrom:[] Env:[{Name:INFLUXDB_HOST Value:monitoring-influxdb ValueFrom:nil} {Name:INFLUXDB_SERVICE_URL Value:http://monitoring-influxdb:8086 ValueFrom:nil} {Name:GRAFANA_PORT Value:3000 ValueFrom:nil} {Name:GF_AUTH_BASIC_ENABLED Value:false ValueFrom:nil} {Name:GF_AUTH_ANONYMOUS_ENABLED Value:true ValueFrom:nil} {Name:GF_AUTH_ANONYMOUS_ORG_ROLE Value:Admin ValueFrom:nil} {Name:GF_SERVER_ROOT_URL Value:/ ValueFrom:nil}] Resources:{Limits:map[] Requests:map[]} VolumeMounts:[{Name:grafana-storage ReadOnly:false MountPath:/var SubPath:} {Name:io-rancher-system-token-b0xns ReadOnly:true MountPath:/var/run/secrets/kubernetes.io/serviceaccount SubPath:}] LivenessProbe:nil ReadinessProbe:nil Lifecycle:nil TerminationMessagePath:/dev/termination-log TerminationMessagePolicy:File ImagePullPolicy:IfNotPresent SecurityContext:nil Stdin:false StdinOnce:false TTY:false} is dead, but RestartPolicy says that we should restart it.
7/14/2017 3:12:50 PME0714 12:12:50.558005   19341 kubelet_network.go:139] Search Line limits were exceeded, some dns names have been omitted, the applied search line is: kube-system.svc.cluster.local svc.cluster.local cluster.local kubelet.kubernetes.rancher.internal kubernetes.rancher.internal rancher.internal
7/14/2017 3:12:50 PME0714 12:12:50.571159   19341 remote_runtime.go:91] RunPodSandbox from runtime service failed: rpc error: code = 2 desc = failed to create a sandbox for pod "tiller-deploy-737598192-dvwhq": Error response from daemon: cgroup-parent for systemd cgroup should be a valid slice named as "xxx.slice"
7/14/2017 3:12:50 PME0714 12:12:50.571184   19341 kuberuntime_sandbox.go:54] CreatePodSandbox for pod "tiller-deploy-737598192-dvwhq_kube-system(6683fadf-688c-11e7-bb67-027b0bd08231)" failed: rpc error: code = 2 desc = failed to create a sandbox for pod "tiller-deploy-737598192-dvwhq": Error response from daemon: cgroup-parent for systemd cgroup should be a valid slice named as "xxx.slice"
7/14/2017 3:12:50 PME0714 12:12:50.571196   19341 kuberuntime_manager.go:618] createPodSandbox for pod "tiller-deploy-737598192-dvwhq_kube-system(6683fadf-688c-11e7-bb67-027b0bd08231)" failed: rpc error: code = 2 desc = failed to create a sandbox for pod "tiller-deploy-737598192-dvwhq": Error response from daemon: cgroup-parent for systemd cgroup should be a valid slice named as "xxx.slice"
7/14/2017 3:12:50 PME0714 12:12:50.571222   19341 pod_workers.go:182] Error syncing pod 6683fadf-688c-11e7-bb67-027b0bd08231 ("tiller-deploy-737598192-dvwhq_kube-system(6683fadf-688c-11e7-bb67-027b0bd08231)"), skipping: failed to "CreatePodSandbox" for "tiller-deploy-737598192-dvwhq_kube-system(6683fadf-688c-11e7-bb67-027b0bd08231)" with CreatePodSandboxError: "CreatePodSandbox for pod \"tiller-deploy-737598192-dvwhq_kube-system(6683fadf-688c-11e7-bb67-027b0bd08231)\" failed: rpc error: code = 2 desc = failed to create a sandbox for pod \"tiller-deploy-737598192-dvwhq\": Error response from daemon: cgroup-parent for systemd cgroup should be a valid slice named as \"xxx.slice\""
7/14/2017 3:12:50 PME0714 12:12:50.571258   19341 remote_runtime.go:91] RunPodSandbox from runtime service failed: rpc error: code = 2 desc = failed to create a sandbox for pod "monitoring-grafana-3552275057-mn6bs": Error response from daemon: cgroup-parent for systemd cgroup should be a valid slice named as "xxx.slice"
7/14/2017 3:12:50 PME0714 12:12:50.571271   19341 kuberuntime_sandbox.go:54] CreatePodSandbox for pod "monitoring-grafana-3552275057-mn6bs_kube-system(667b4974-688c-11e7-bb67-027b0bd08231)" failed: rpc error: code = 2 desc = failed to create a sandbox for pod "monitoring-grafana-3552275057-mn6bs": Error response from daemon: cgroup-parent for systemd cgroup should be a valid slice named as "xxx.slice"
7/14/2017 3:12:50 PME0714 12:12:50.571281   19341 kuberuntime_manager.go:618] createPodSandbox for pod "monitoring-grafana-3552275057-mn6bs_kube-system(667b4974-688c-11e7-bb67-027b0bd08231)" failed: rpc error: code = 2 desc = failed to create a sandbox for pod "monitoring-grafana-3552275057-mn6bs": Error response from daemon: cgroup-parent for systemd cgroup should be a valid slice named as "xxx.slice"
7/14/2017 3:12:50 PME0714 12:12:50.571303   19341 pod_workers.go:182] Error syncing pod 667b4974-688c-11e7-bb67-027b0bd08231 ("monitoring-grafana-3552275057-mn6bs_kube-system(667b4974-688c-11e7-bb67-027b0bd08231)"), skipping: failed to "CreatePodSandbox" for "monitoring-grafana-3552275057-mn6bs_kube-system(667b4974-688c-11e7-bb67-027b0bd08231)" with CreatePodSandboxError: "CreatePodSandbox for pod \"monitoring-grafana-3552275057-mn6bs_kube-system(667b4974-688c-11e7-bb67-027b0bd08231)\" failed: rpc error: code = 2 desc = failed to create a sandbox for pod \"monitoring-grafana-3552275057-mn6bs\": Error response from daemon: cgroup-parent for systemd cgroup should be a valid slice named as \"xxx.slice\""

@sangeethah bug can be verified using rancher/k8s:v1.7.0-rancher3 k8s image, available in catalog branch corresponding to 1.7

@sangeethah ignore my comment, I was thinking another issue. Will work on this one.

Closing as we support only docker 1.12.x for k8s. @galal-hussein


Fix seg fault in scanner.c: Allocate the stack array if null

https://github.com/fwcd/tree-sitter-kotlin/pull/115 introduces a segfault in the following function in scanner.c. I noticed
(signal: 11, SIGSEGV: invalid memory reference in some of our tests after upgrading.
void tree_sitter_kotlin_external_scanner_deserialize(void *payload, const char *buffer, unsigned length) {
  Stack *stack = (Stack *)payload;
  if (length > 0) {
    memcpy(stack->contents, buffer, length); // <<< stack.contents can be null
    stack->size = length;
  } else {
    array_clear(stack);
  }
}

This PR fixes the segfault by adding a null check here.

Can you post the crashing tests?

It's not easy to reproduce it with a simple example. It's happening in our private repo and there are a lot of rewriting happening.

Can you at least run the fuzzer (on a Linux machine) using your repo's Kotlin files as the corpus?
make fuzz LANG_NAME=kotlin LANG_DIR=/path/to/tree-sitter-kotlin CORPUS_DIR=/path/to/corpus

Also, regardless of the example, under which circumstances stack->contents can be null here?

The built-in array API handles the contents field. You should ask @amaanq for details.

Just fyi, the fuzzer does actually work on macOS, you just need to use the Homebrew-installed version of LLVM (brew install llvm) since Apple Clang apparently does not bundle libfuzzer:
PATH="/opt/homebrew/opt/llvm/bin:$PATH" make LANG_NAME=kotlin LANG_DIR=path/to/tree-sitter-kotlin ...

Neat, thanks for digging into this and for the fix!


[Question]How to Import relational data?

Prerequisites
Versions

PHP version: 7.2
Laravel version: 5.6
Package version: 3.1

Description
How can i import relational  data with validation using  laravel-excel?  i have single csv file which contains relational data like user with shop.

If you have a CSV with multiple sheet and relations between the sheets, you should first import one sheet into your database. After that you'll have the ID that can be referred to by the data from the other sheet.

@GlennM how you get the referred id? there is not example how using relation data in different sheet I was try using the model example without luck

The data should already be in the dataset as he stated...
IE: If Sheet 1 = Customers
ID, FNAME, LNAME
1, John, Smith
2, Jane, Doe
and Sheet 2 has Clients
ID, CUSTOMER_ID, FNAME, LNAME
1, 1, Client to John, Smith
2, 1, Client to John, Smith
3, 2, Client to Jane, Doe
You should already have the referrer id?

That doesn't make any sense... He's asking about Importing (How would that data not exist in the sheets)... How would you tie the sheets to the models then if the data didn't pre-exist? You wouldn't know in his case, which "shop" goes to which "user" without that data existing already...

Im not mean the data dont exist in the sheet, what happen if the shops in the excel doesnt exists in the database? then its a new shop and need be added, after that you need asign the users of the shop.
how the shop is new then you don't have the shop_id to asign to user.
We are asking (i think atapatel too) is how you can assign that users to the new shop.

so would this be a M:M table ?
Because, if it's a 1:M then the shops should have the user_id in the shops table already ?

shop -> one to many -> users.
how can use this library to import an excel with these two sheets? one with shops and others with users.
example:
shop sheet
id, name, description
null, Maatwebsite, a shop for clothes
1, apple, mac & iphones

users
id, shop_id, name, lastname
null, shop_id?, Maganius, Test
1, 1, Seo, Roman

with that example how you get the shop_id for the user Maganius importing an excel with this library.

Once again, the key exists right there on the table? I don't see where you are getting confused... you import the shops, and you have the ID, there's no reason to associate it with the User Model Import, since it's listed right there on your USERS sheet...
Why would you have data like that at all, you wouldn't know that Maganius is assigned to Maatwebsite shop without referencing hte ID... so you would import those without any direct connections and then simply use your client gui to do the association later... if you don't know the relationship prior to importing, then it shouldn't exist on the import (because there is no way of knowing) with the example you supplied, there's no way to know that Maatwebsite shop should be associated to Maganius user...

you are right, my example is wrong because I write the example base on atapatel model.
sorry for misunderstanding and confuse it.
its my example
courses sheet

N#, id, name
1, null, Charla como iniciar mi negocio
2, 20, Another course

users sheet
n_course, name, lastname
1, Maganius, Test
2, Seo, Roman

N# is the relation with the user not with the database, then I need insert Charla como iniciar mi negocio and associate it with Maganius user with n_course

Can I have an example for this article?

The issue is, no matter which way you go, whether users have courses or courses have users, you have an association setup SOMEWHERE...
N# = what? id = course_id ?
n_course = what? ...
What I am saying is that if you are importing relational data, there should be somewhere that specifies what that relation is... else it's not relational "Yet" ...
It's just 2 separate sets of entities that don't have any relational mapping...
IE: If you did something like...
Courses:
1, Whatever
2, Other
Users:
1, Z3R0
2, Atapatel
// All you have are 2 sheets of independent entities with no relational mapping...
So either you have relational mapping and you can decide what to do with it, or you don't have relational mapping, and you can't import them directly with relationships and thus, you need to have the key nullable and map the relations at a later point "AFTER" the import... Because if the sheets do not know the relationships, how is the import supposed to know the relationships?

you are no understanding I know my english is bad sorry for that.
in these excel you have the an internal relationship, its N# and n_course in respectives sheets.
the user who is importing the excel write what user correspond to what course before importing then I need associate however if its new or an update.
if its new I need first insert the course and based on the n# and n_course I need fill the users of the other sheet.
its a full example with php without excel.
$ccourses = array(
            array('n#' => 1, 'id' => null, 'name' => 'Charla Cómo iniciar mi Negocio'),
            array('n#' => 2, 'id' => 20, 'name' => 'Basics of vue'),
        );

        $users = array(
            array('n_course' => 1, 'name' => 'Maganius'),
            array('n_course' => 2, 'name' => 'SeoRoman')
        );
        $mapping = array();
        foreach($ccourses as $course){
            $mapping[$course['n#']] = $course;
        }

        foreach($users as $user){
            $mapping[$user['n_course']]['users'][] = $user;
        }

        foreach($mapping as $course){
            if($course['id']){
                $Curso = Curso::find($course['id']);
            }else{
                $Curso = new Curso();
            }
            $Curso->name = $course['name'];
            $Curso->save();

            foreach($course['users'] as $user){
                $User = new User();
                $User->course_id = $Curso->id;
                $User->name = $user['name'];
                $User->save();
            }
        }

its the result at $mapping variable
array:2 [▼
  1 => array:4 [▼
    "n#" => 1
    "id" => null
    "name" => "Charla Cómo iniciar mi Negocio"
    "users" => array:1 [▼
      0 => array:2 [▼
        "n_course" => 1
        "name" => "Maganius"
      ]
    ]
  ]
  2 => array:4 [▼
    "n#" => 2
    "id" => 20
    "name" => "Basics of vue"
    "users" => array:1 [▼
      0 => array:2 [▼
        "n_course" => 2
        "name" => "SeoRoman"
      ]
    ]
  ]

I first make the mapping and after it insert or update the database with the information, how you can see in the foreach - users I need the course id =  $User->course_id = $Curso->id;
I hope i explain a little more my issue.

What you are doing doesn't make any sense whatsoever... I don't see why you would have users assigned to non-existent courses in the excel file... that seems like whoever is doing that data handling is doing it "VERY WRONG" and you should just have a frontend GUI handling this setup... Not the excel importing over and over...
I'll take a look at it later, when I have more time

Hi! I know this has been closed long ago, but I have the same problem. In my case, I'm developing an eshop. I want to be able to import products, categories, properties... all at once from a multisheet excel file. I structured the file like this:
Categories:

code
name

tshirts
T-shirts

jackets
Jackets & Coats

Products:

code
name
categories

tshirt_blue
Blue T-shirt
tshirts, outlet

jacket_red
Red jacket
jackets

I don't save the "code" field anywhere in the db, I don't need it after the import, so I don't think it's useful to have it just for this. What I'm doing right now is this:
`
class CategoriesImport implements OnEachRow, WithHeadingRow
{
public $imported_categories;
public function onRow(Row $row)
{
    $row = $row->toArray();

    $category = new Category([
        'code' => $row['code'],
        'name' => $row['name'],
    ]);

    $category->save();

    $this->imported_categories[$row['code']] = $property->id;
}

}
`
With this, I have a "map" of the categories that were created. But I need to access this property imported_categories and I don't have a clue about how can I do it. I tried to access it importing one sheet at a time (using onlySheets), and firing the afterImport Event, but I can't access CategoriesImport from there as it's inside sheetImports, a protected property of the event reader object. I feel like I'm almost there. Any clue?

I found it!
Using macros I can access the protected property sheetImports:
Reader::macro('getSheetImports', function (Reader $reader) {
    return $reader->sheetImports;
});

And then from the importer I use the afterImport event to save the imported categories in the session:
public static function afterImport(AfterImport $event)
{
    $sheet_imports = $event->reader->getSheetImports();
    if (isset($sheet_imports['categories'])) {
        Session::put('imported_categories', $sheet_imports['categories']->imported_categories);
    }
}

And then I can access the imported categories ids when importing the other sheets.
class ProductsImport implements OnEachRow, WithHeadingRow
{
    public $imported_categories;

    public function __construct()
    {
        $this->imported_categories = Session::get('imported_categories');
    }

    public function onRow(Row $row)
    {
        $row = $row->toArray();

        $category_id = $this->imported_categories[$row['category']];

        $product= new Product([
            'name' => $row['name'],
            'category_id' => $category_id
        ]);

        $product->save();
    }
}


Spark 2 support

Please excuse me if the issue is raised but I believe the night build already support spark 2.
Is there a way to download the build (.tgz) directly. If no can you publish the steps to build one for a novice.
Thanks

Hello, the spark 2 support is in another branch because this new version  offers us a better architecture, so it's very different from the master...
building steps can be found in the documentation folder
but you can also use http://spark-notebook.io and select master for the notebook version (important!...  the generator I'll use the correct future-master branch behind)

@andypetrella  thanks for reply but on spark-notebook.io it give me message like Build not available, but launched!. What am i missing

actually you should get a mail when the build will be finished


12805 Added support for geojson selection, and description for the provider

A geojson file is provided to mapproxy to cache tiles by the bounding box.  Feature services request the bbox and then during the Geopackage task if the geojson file is available, the file is clipped to the shape.
Additionally service_description was added to the provider model to display on the UI.

Coverage decreased (-0.2%) to 87.796% when pulling d218d23b6ade99a4f08e5259d37cffdca49c6f00 on 12805-AllowCachingByPolygon into 45d65c612298f2f005fb629a3f0909510902c674 on master.

Coverage decreased (-0.2%) to 87.796% when pulling d218d23b6ade99a4f08e5259d37cffdca49c6f00 on 12805-AllowCachingByPolygon into 45d65c612298f2f005fb629a3f0909510902c674 on master.

Coverage increased (+0.2%) to 88.139% when pulling 664cd90dedb967a49ed7cc742c6cd4c43d527d27 on 12805-AllowCachingByPolygon into 45d65c612298f2f005fb629a3f0909510902c674 on master.

Coverage increased (+0.2%) to 88.139% when pulling 02d496901e01b33747b87fde6a43d23c70235428 on 12805-AllowCachingByPolygon into 45d65c612298f2f005fb629a3f0909510902c674 on master.


There's no schedule section for the syllabus.

@decause do this

@jeid64 The file was listed, but the header got dropped :/
Fixed now.


Wishlist: backend without a port driver

https://github.com/Vagabond/erlang-syslog/issues/9
I don't understand the details of the C code involved in this issue, as I haven't had a close look, but it'd be nice to have a pure Erlang backend in any event, something that can talk to syslogd directly.

There used to be a syslog backend that used the syslog UDP protocol, rather than than syslog(3) C interface (which is why we need C code here).

https://github.com/abs/lager_syslogerl

Cool. Didn't know about that. Thank you. :+1:


Coerce null request bodies to empty

Avoids the exception thrown by OkHttp for empty bodies that was fixed in Retrofit 2 here: https://github.com/square/retrofit/commit/19ac1e2c4551448184ad66c4a0ec172e2741c2ee
Dunno if it's a bad idea to reference HttpMethod#requiresRequestBody because it's internal...I'd be glad to change it!

Copied over the internal method. Lemme know if there's anything else!


Control+A shortcut in new picture area

It would be nice to be able to use standard shortcuts like these

Hello, so Ctrl+a is for select all, from my knowledge, selection hasn't been added at all yet. :)

That's why I'm opening this issue 👍🏻


Set API keys per admin

Feedback from Brechy

Do we have any additional description / suggestion here?

Possible duplicate #245


Add pre-commit hooks

Closes #9
Added and ran a simple set of pre-commit hooks. I also added a github action to check that pre-commit has been run, otherwise you won't be able to merge PRs.
The biggest PITA will be that notebooks have to be executed in order to pass. Enjoy :D

__init__.py is a file that lets python know that a directory is a python package. If you have an __init__.py in a folder called my_project, you can write from my_project import .... See here for an explanation. You never need to touch it.
pre-commit is a script that runs every time you do git commit. It will automatically do some checks, including standardizing quotes, making sure your lines aren't too long, making sure you don't have unused imports, etc. Most of it is pep8 related style things, to make sure our code is readable and standardized. Like I said, it will happen automatically when you commit. If it makes changes, you'll get a message, and you'll have to re-add a file it fixed and commit again.
No, it assumes you already have it. Otherwise it's just the little EDA we did at the OECD office.


Always compile Ecto

ExMachina may be used in other environments.

I don't think this is the solution. We shouldn't require Ecto as a dependency, instead I think we want to change all the %Ecto...{} structs to %{__struct__: Ecto...}

Ah, yeah, that makes more sense. I see that now in the other PR. Doing a not so great job at multitasking...

Haha it's all good. Multitasking is hard :)

Merged.


WebUI Rearchitecture

New pull request that replaces PR https://github.com/mudrod/mudrod/pull/157
This PR is based off of branch https://github.com/mudrod/mudrod/tree/mudrod-117
If you have changes/updates please push them to https://github.com/mudrod/mudrod/tree/mudrod-117 and they will be included in this PR.
The intent of this PR is to get the new UI to the equivalent functionality of master before merging.

From previous PR:
Search results page

Could you please make the search box on the search results page a little wider? Part of the texts are blocked.
When click you a related search/query, could you also update the text in the search box?
It looks a bit strange that the background pic is duplicated a few times when there are many hits.

Dataset detail page

There are a few attribute values (e.g., abstract, temporalrepeat) that are missing here, but it was there originally.
The related search goes all the way to the bottom, which doesn't look very good.

@gxtchen @fgreg @lewismc @quintinali Someone mentioned this at the ESIP call today, https://www.ncdc.noaa.gov/onestop/#/
I think this is something we can reference, especially for the UI.

Are any of the classes in styles.css https://github.com/mudrod/mudrod/pull/165/files#diff-f88fdf888f5ebc88b06b71fcbff7ce63 actually used? It seems not; can they be removed?

@Yongyao

Someone mentioned this

Someone mentioned what?

The newest NOAA onestop UI was mentioned at the Discovery cluster call. Here is the URL, https://www.ncdc.noaa.gov/onestop/#/

SonarQube analysis reported 17 issues

 9 major
 8 minor

Watch the comments in this conversation to review them.
2 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 metadataResults.html#L29: Remove this commented out code.
 navbar-search.html#L39: Replace this  tag by .

@fgreg are the commits that @gxtchen is pushing here being pushed to the UAT server?

@lewismc @gxtchen Commit https://github.com/mudrod/mudrod/pull/165/commits/74a2ca2d2228e90a466223630332dc4001d55f0b has been pushed to UAT

Thanks @fgreg

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c6015ab). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master   #165   +/-   ##
=======================================
  Coverage          ?     0%
=======================================
  Files             ?     79
  Lines             ?   5017
  Branches          ?    640
=======================================
  Hits              ?      0
  Misses            ?   5017
  Partials          ?      0

SonarQube analysis reported 17 issues

 9 major
 8 minor

Watch the comments in this conversation to review them.
2 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 metadataResults.html#L29: Remove this commented out code.
 navbar-search.html#L39: Replace this  tag by .

services/ontology/synonym?query=ocean+ice&operator=And" returning empty
result, I don't know how to display this without seeing some results. Are
we planning to put the results in the side bar as well?
Gary
On Thu, May 18, 2017 at 3:45 PM Lewis John McGibbney <
<EMAIL_ADDRESS>wrote:

SonarQube analysis reported 17 issues

[image: MAJOR]
https://camo.githubusercontent.com/83e898978c86faa5ecccee6420bb48a239b0ee44/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e61722d6769746875622f73657665726974792d6d616a6f722e706e67
9 major
[image: MINOR]
https://camo.githubusercontent.com/06a016a2d242d6c1298506d0cd4cf175df84dcae/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e61722d6769746875622f73657665726974792d6d696e6f722e706e67
8 minor

Watch the comments in this conversation to review them.
2 extra issues
Note: The following issues were found on lines that were not modified in
the pull request. Because these issues can't be reported as line comments,
they are summarized here:

[image: MAJOR]
https://camo.githubusercontent.com/83e898978c86faa5ecccee6420bb48a239b0ee44/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e61722d6769746875622f73657665726974792d6d616a6f722e706e67
metadataResults.html#L29
https://github.com/mudrod/mudrod/blob/0e52674cf121b3480291a205702d2392d7ec3f5d/web/META-INF/resources/partials/metadataResults.html#L29:
Remove this commented out code. [image: rule]
https://sonarqube.com/coding_rules#rule_key=Web%3AAvoidCommentedOutCodeCheck
[image: MINOR]
https://camo.githubusercontent.com/06a016a2d242d6c1298506d0cd4cf175df84dcae/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e61722d6769746875622f73657665726974792d6d696e6f722e706e67
navbar-search.html#L39
https://github.com/mudrod/mudrod/blob/0e52674cf121b3480291a205702d2392d7ec3f5d/web/META-INF/resources/partials/navbar-search.html#L39:
Replace this * tag by . [image: rule]
https://sonarqube.com/coding_rules#rule_key=Web%3ABoldAndItalicTagsCheck*

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mudrod/mudrod/pull/165#issuecomment-302561834, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEXMpSt5-OMOJDBqCOiS7Y3zv9wzec_Nks5r7MnxgaJpZM4NVwyw
.

OK, nevermind with the Ontology portion of this work for the time being @gxtchen . I will coordinate with you on a separate ticket for that.

SonarQube analysis reported 17 issues

 9 major
 8 minor

Watch the comments in this conversation to review them.
2 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 metadataResults.html#L29: Remove this commented out code.
 navbar-search.html#L39: Replace this  tag by .

A few more minor enhancements:

Default search operator should be changed to "And"
When you type something in the search box on the homepage and the autocomplete list pops up, it pushes the "Search Operator: ..." radio buttons down below the popup list. Looks weird, probably the list should just cover the radio buttons.
Can the background image on the homepage start below the headers (the top portion of the image is hidden right now)?
On the search result page I think it would look better if the background image was 'fixed' instead of repeated
The "Related Datasets" don't seem to be working when you click on a result
Whatever term you searched for should be placed in the search box on the search results page

@lewismc Can you comment on Gary's question above?

@gxtchen sorry for late response... the issue will be resolved at https://github.com/mudrod/mudrod/pull/178, I'll ping you when it is done.

SonarQube analysis reported 18 issues

 10 major
 8 minor

Watch the comments in this conversation to review them.
2 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 metadataResults.html#L29: Remove this commented out code.
 navbar-search.html#L39: Replace this  tag by .

Commit https://github.com/mudrod/mudrod/pull/165/commits/48589f74d1477d16ef9b801c0d7a2fe78037cb23 is deployed to mudrod-uat.jpl.nasa.gov

SonarQube analysis reported 17 issues

 9 major
 8 minor

Watch the comments in this conversation to review them.
2 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 metadataResults.html#L29: Remove this commented out code.
 navbar-search.html#L39: Replace this  tag by .

Commit https://github.com/mudrod/mudrod/pull/165/commits/8275c151d045a13241bfae490b47e14ad56c6452 is deployed to mudrod-uat.jpl.nasa.gov

SonarQube analysis reported 17 issues

 9 major
 8 minor

Watch the comments in this conversation to review them.
2 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 metadataResults.html#L29: Remove this commented out code.
 navbar-search.html#L39: Replace this  tag by .

SonarQube analysis reported 17 issues

 9 major
 8 minor

Watch the comments in this conversation to review them.
2 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 metadataResults.html#L29: Remove this commented out code.
 navbar-search.html#L39: Replace this  tag by .

Hi @gxtchen an example of a query and a response is below
localhost:8080/mudrod-service-0.0.1-SNAPSHOT/services/ontology/subclass?query=Climate+Data+Record
["CDR","Climate Data Record"]

This is based upon use of branch https://github.com/mudrod/mudrod/pull/178... however I am going to merge this into master branch. If you see https://github.com/mudrod/mudrod/pull/178 closed when you view this ticket, then you can pull from master branch OK.

SonarQube analysis reported 34 issues

 1 critical
 13 major
 20 minor

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ESDriver.java#L239: Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.
 ESDriver.java#L120: Define and throw a dedicated exception instead of using a generic one.
 ESDriver.java#L131: Either re-interrupt this method or rethrow the "InterruptedException".
 ESDriver.java#L443: Rename "client" which hides the field declared at line 78.
 ESDriver.java#L451: Remove this expression which always evaluates to "true"
 metadataResults.html#L29: Remove this commented out code.
 ESDriver.java#L79: Remove the "node" field and declare it as a local variable in the relevant methods.
 ESDriver.java#L157: Use a StringBuilder instead.
 ESDriver.java#L304: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)
 ESDriver.java#L304: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

SonarQube analysis reported 34 issues

 1 critical
 13 major
 20 minor

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ESDriver.java#L239: Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.
 ESDriver.java#L120: Define and throw a dedicated exception instead of using a generic one.
 ESDriver.java#L131: Either re-interrupt this method or rethrow the "InterruptedException".
 ESDriver.java#L443: Rename "client" which hides the field declared at line 78.
 ESDriver.java#L451: Remove this expression which always evaluates to "true"
 metadataResults.html#L29: Remove this commented out code.
 ESDriver.java#L79: Remove the "node" field and declare it as a local variable in the relevant methods.
 ESDriver.java#L157: Use a StringBuilder instead.
 ESDriver.java#L304: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)
 ESDriver.java#L304: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

SonarQube analysis reported 37 issues

 1 critical
 14 major
 22 minor

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ESDriver.java#L239: Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.
 ESDriver.java#L120: Define and throw a dedicated exception instead of using a generic one.
 ESDriver.java#L131: Either re-interrupt this method or rethrow the "InterruptedException".
 ESDriver.java#L443: Rename "client" which hides the field declared at line 78.
 ESDriver.java#L451: Remove this expression which always evaluates to "true"
 metadataResults.html#L29: Remove this commented out code.
 ESDriver.java#L79: Remove the "node" field and declare it as a local variable in the relevant methods.
 ESDriver.java#L157: Use a StringBuilder instead.
 ESDriver.java#L304: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)
 ESDriver.java#L304: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

SonarQube analysis reported 37 issues

 1 critical
 14 major
 22 minor

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ESDriver.java#L239: Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.
 ESDriver.java#L120: Define and throw a dedicated exception instead of using a generic one.
 ESDriver.java#L131: Either re-interrupt this method or rethrow the "InterruptedException".
 ESDriver.java#L443: Rename "client" which hides the field declared at line 78.
 ESDriver.java#L451: Remove this expression which always evaluates to "true"
 metadataResults.html#L29: Remove this commented out code.
 ESDriver.java#L79: Remove the "node" field and declare it as a local variable in the relevant methods.
 ESDriver.java#L157: Use a StringBuilder instead.
 ESDriver.java#L304: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)
 ESDriver.java#L304: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

SonarQube analysis reported 30 issues

 1 critical
 14 major
 15 minor

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ESDriver.java#L239: Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.
 ESDriver.java#L120: Define and throw a dedicated exception instead of using a generic one.
 ESDriver.java#L131: Either re-interrupt this method or rethrow the "InterruptedException".
 ESDriver.java#L443: Rename "client" which hides the field declared at line 78.
 ESDriver.java#L451: Remove this expression which always evaluates to "true"
 metadataResults.html#L29: Remove this commented out code.
 ESDriver.java#L79: Remove the "node" field and declare it as a local variable in the relevant methods.
 ESDriver.java#L157: Use a StringBuilder instead.
 ESDriver.java#L304: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)
 ESDriver.java#L304: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

https://github.com/mudrod/mudrod/pull/165/commits/c233cbe4bc9563c505a198fc1a477e30c761e8d5 is deployed to UAT

SonarQube analysis reported 37 issues

 1 critical
 14 major
 22 minor

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ESDriver.java#L239: Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.
 ESDriver.java#L120: Define and throw a dedicated exception instead of using a generic one.
 ESDriver.java#L131: Either re-interrupt this method or rethrow the "InterruptedException".
 ESDriver.java#L443: Rename "client" which hides the field declared at line 78.
 ESDriver.java#L451: Remove this expression which always evaluates to "true"
 metadataResults.html#L49: Remove this commented out code.
 ESDriver.java#L79: Remove the "node" field and declare it as a local variable in the relevant methods.
 ESDriver.java#L157: Use a StringBuilder instead.
 ESDriver.java#L304: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)
 ESDriver.java#L304: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

SonarQube analysis reported 37 issues

 1 critical
 14 major
 22 minor

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ESDriver.java#L239: Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.
 ESDriver.java#L120: Define and throw a dedicated exception instead of using a generic one.
 ESDriver.java#L131: Either re-interrupt this method or rethrow the "InterruptedException".
 ESDriver.java#L443: Rename "client" which hides the field declared at line 78.
 ESDriver.java#L451: Remove this expression which always evaluates to "true"
 metadataResults.html#L49: Remove this commented out code.
 ESDriver.java#L79: Remove the "node" field and declare it as a local variable in the relevant methods.
 ESDriver.java#L157: Use a StringBuilder instead.
 ESDriver.java#L304: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)
 ESDriver.java#L304: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

SonarQube analysis reported 37 issues

 1 critical
 14 major
 22 minor

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ESDriver.java#L239: Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.
 ESDriver.java#L120: Define and throw a dedicated exception instead of using a generic one.
 ESDriver.java#L131: Either re-interrupt this method or rethrow the "InterruptedException".
 ESDriver.java#L443: Rename "client" which hides the field declared at line 78.
 ESDriver.java#L451: Remove this expression which always evaluates to "true"
 metadataResults.html#L52: Remove this commented out code.
 ESDriver.java#L79: Remove the "node" field and declare it as a local variable in the relevant methods.
 ESDriver.java#L157: Use a StringBuilder instead.
 ESDriver.java#L304: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)
 ESDriver.java#L304: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

SonarQube analysis reported 41 issues

 1 critical
 14 major
 26 minor

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ESDriver.java#L239: Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.
 ESDriver.java#L120: Define and throw a dedicated exception instead of using a generic one.
 ESDriver.java#L131: Either re-interrupt this method or rethrow the "InterruptedException".
 ESDriver.java#L443: Rename "client" which hides the field declared at line 78.
 ESDriver.java#L451: Remove this expression which always evaluates to "true"
 metadataResults.html#L63: Remove this commented out code.
 ESDriver.java#L79: Remove the "node" field and declare it as a local variable in the relevant methods.
 ESDriver.java#L157: Use a StringBuilder instead.
 ESDriver.java#L304: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)
 ESDriver.java#L304: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

SonarQube analysis reported 40 issues

 1 critical
 14 major
 25 minor

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ESDriver.java#L239: Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.
 ESDriver.java#L120: Define and throw a dedicated exception instead of using a generic one.
 ESDriver.java#L131: Either re-interrupt this method or rethrow the "InterruptedException".
 ESDriver.java#L443: Rename "client" which hides the field declared at line 78.
 ESDriver.java#L451: Remove this expression which always evaluates to "true"
 metadataResults.html#L52: Remove this commented out code.
 ESDriver.java#L79: Remove the "node" field and declare it as a local variable in the relevant methods.
 ESDriver.java#L157: Use a StringBuilder instead.
 ESDriver.java#L304: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)
 ESDriver.java#L304: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

@fgreg what are your thoughts on how close we are to merging into master? I am looking at Ed's spreadsheet... there are obviously a bunch of issues left to do. I am keen to hammer them and merge this into master ASAP. wdyt?

SonarQube analysis reported 1 issue

 1 minor

Watch the comments in this conversation to review them.

SonarQube analysis reported 30 issues

 1 critical
 9 major
 20 minor

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ESDriver.java#L239: Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.
 ESDriver.java#L120: Define and throw a dedicated exception instead of using a generic one.
 ESDriver.java#L131: Either re-interrupt this method or rethrow the "InterruptedException".
 ESDriver.java#L443: Rename "client" which hides the field declared at line 78.
 ESDriver.java#L451: Remove this expression which always evaluates to "true"
 ESDriver.java#L79: Remove the "node" field and declare it as a local variable in the relevant methods.
 ESDriver.java#L157: Use a StringBuilder instead.
 ESDriver.java#L304: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)
 ESDriver.java#L304: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
 ESDriver.java#L387: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)

SonarQube analysis reported 2 issues

 1 major
 1 minor

Watch the comments in this conversation to review them.

SonarQube analysis reported 42 issues

 15 critical
 9 major
 18 minor

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ESDriver.java#L122: Define and throw a dedicated exception instead of using a generic one.
 ESDriver.java#L133: Either re-interrupt this method or rethrow the "InterruptedException".
 ESDriver.java#L470: Rename "client" which hides the field declared at line 81.
 ESDriver.java#L478: Remove this expression which always evaluates to "true"
 ESDriver.java#L159: Use a StringBuilder instead.
 ESDriver.java#L414: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)
 ESDriver.java#L569: Immediately return this expression instead of assigning it to the temporary variable "docCount".
 ApiHarvester.java#L124: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
 ApiHarvester.java#L148: Remove this hard-coded path-delimiter.
 ApiHarvester.java#L151: Do something with the "boolean" value returned by "createNewFile".

SonarQube analysis reported 16 issues

 14 critical
 1 major
 1 minor

Watch the comments in this conversation to review them.

SonarQube analysis reported 40 issues

 15 critical
 7 major
 18 minor

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ESDriver.java#L122: Define and throw a dedicated exception instead of using a generic one.
 ESDriver.java#L133: Either re-interrupt this method or rethrow the "InterruptedException".
 ESDriver.java#L470: Rename "client" which hides the field declared at line 81.
 ESDriver.java#L478: Remove this expression which always evaluates to "true"
 ESDriver.java#L159: Use a StringBuilder instead.
 ESDriver.java#L414: Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.)
 ESDriver.java#L569: Immediately return this expression instead of assigning it to the temporary variable "docCount".
 ApiHarvester.java#L124: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
 ApiHarvester.java#L148: Remove this hard-coded path-delimiter.
 ApiHarvester.java#L151: Do something with the "boolean" value returned by "createNewFile".

SonarQube analysis reported 16 issues

 14 critical
 1 major
 1 minor

Watch the comments in this conversation to review them.


Added MetatranscriptomicTypeV10

@AmandaBirmingham @RodolfoSalido additional test is added. Thank you for your patience. Please feel free to continue reviewing!

@RodolfoSalido should be okay. Since we decided on this one being v10, I took our legacy MetatranscriptomicSampleSheet class and renamed it MetatranscriptomicSampleSheetv0. I thought zero’th version was somewhat appropriate.

On Feb 8, 2024, at 4:22 PM, RodolfoSalido @.***> wrote:
@RodolfoSalido commented on this pull request.
In metapool/init.py https://urldefense.com/v3/__https://github.com/biocore/metagenomics_pooling_notebook/pull/178*discussion_r1483731908__;Iw!!Mih3wA!FyQu3zjbXIQObqCUOXoXXNiKszGoxUWjtfDlzvKxoB6Y97-fRMW9UySexqReBW31aFtnj7Tf1AFGJSdNMsGhSuKf$:

@@ -5,9 +5,9 @@
from .sample_sheet import (sample_sheet_to_dataframe, make_sample_sheet,
AmpliconSampleSheet, MetagenomicSampleSheetv90,
MetagenomicSampleSheetv100, AbsQuantSampleSheetv10,

                      MetatranscriptomicSampleSheet, demux_sample_sheet,

                      MetatranscriptomicSampleSheetv0, demux_sample_sheet,

typo? Should be MetatranscriptomicSampleSheetv10
—
Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/biocore/metagenomics_pooling_notebook/pull/178*pullrequestreview-1871476319__;Iw!!Mih3wA!FyQu3zjbXIQObqCUOXoXXNiKszGoxUWjtfDlzvKxoB6Y97-fRMW9UySexqReBW31aFtnj7Tf1AFGJSdNMoZl9Ru1$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AKFU7E5TFFRI7ZN4F3N2T4DYSVT4RAVCNFSM6AAAAABC6XUBW2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZRGQ3TMMZRHE__;!!Mih3wA!FyQu3zjbXIQObqCUOXoXXNiKszGoxUWjtfDlzvKxoB6Y97-fRMW9UySexqReBW31aFtnj7Tf1AFGJSdNMhQsi86S$.
You are receiving this because you authored the thread.

Just as a reminder, there are lost of sample sheets (not sure about versions) that we need to recover from before the SPP so my guess is that the first version of the SPP is not the actual first version ...

Left a comment on sample_sheet.py to make sure we are passing along the columns ['total_rna_concentration_ng_ul','vol_extracted_elution_ul'] to the samplesheet.

Okay I'm going to circle back on this after I issue the PR resolving these columns that aren't making it from sample-sheet to prep-info file, just to make sure we implement it right here as well.

Hi @RodolfoSalido ! If you're okay with everything and approve this PR, I can merge it into master and we can test it against your use case. I don't expect any issues but if there is we can fix them.

Sounds good to me.

On Feb 12, 2024, at 12:02 PM, Charles Cowart @.***> wrote:
Hi @RodolfoSalido https://github.com/RodolfoSalido ! If you're okay with everything and approve this PR, I can merge it into master and we can test it against your use case. I don't expect any issues but if there is we can fix them.
—
Reply to this email directly, view it on GitHub https://github.com/biocore/metagenomics_pooling_notebook/pull/178#issuecomment-1939468739, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEVFI5JFBBYAJKNRZQOK2LYTJYLRAVCNFSM6AAAAABC6XUBW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGQ3DQNZTHE.
You are receiving this because you were mentioned.

I'll resolve the issue w/lint after the meeting.

resolved

Thanks @RodolfoSalido ! The new Metatranscriptomic type is merged in. If you want to pull down the latest version of master and give it a try, please feel free. Or if you want to meet or zoom and test through everything together I can do that as well.


Skip running param validators inside inactive given blocks (#1433)

This should address both the primary issue identified in #1433, which was related to the type coercer, and related issues with allow_blank.  In both cases, these validators were being run even when their scopes indicated they should not (since the associated given criterion had not been met).

Hat tip to @andrew13nguyen for the UT code that demonstrates multiple type validators for the same parameter.  I tweaked it to make the types different just to add another layer of chaos.

This is some excellent work @jlfaber & @andrew13nguyen. Merging.

Thanks @dblock for the merge!  Any chance we can get this tagged for release?

We try not to release too often, but I'll queue this up for myself for this/next week. Usually that involves running grape next against a very large API I am looking at over here.

Of course if @namusyaka @dm1try @marshall-lee @adamgotterer want to cut a release before that go for it!

👍 Great job!


Issue 102 added test to verify behaviour is correct

written test that currently passes, I feel that appropiate behaviour is already implmented

🤔 Which behavior do you try to write the test for though?

@kittinunf The tests recreates the behaviour raised in the issue, hence we get a  junction in the roads, as I see it
if the current behaviour is what we want, (handled as a fuel exception, which I think is correct) then we can either junk this pr as superfluous
or we decided this is not the desired behaviour and we change the test and implement changes.
as ever I am here to do whatever you ask!

Ah I see. Understood now. Sorry just need a bit more info. Approved!

I will merge on your behalf. :)


find_blob_index_by_name dis_pred_stride_8 failed     find_blob_index_by_name cls_pred_stride_8 failed

When running the demo_ncnn and using "nanodet_demo 1 ./*.jpg" in the cmd,I occured the problem:

When running the demo_ncnn and using "nanodet_demo 1 ./*.jpg" in the cmd,I occured the problem:

find_blob_index_by_name dis_pred_stride_8 failed find_blob_index_by_name cls_pred_stride_8 failed

anybody knows how to fix it?

问题解决了！在nanodet_m.param处找到Transpose的位置，然后改成右边第四个参数blob name即可


[FEATURE REQUEST] strip http.:// from the auth client onion options

Is your feature request related to a problem? Please describe.

currently you can only paste the address.onion, but it is possible to sed the http from the front and remove it.

done f71306305fc5af1265c61817fe85d03027fd01b0


Finish client-side support for partial responses.

Fixes https://github.com/googlegenomics/utils-java/issues/48
Also

Handle another type of non-variant segment.
Bump grpc dependency.

LGTM. Thanks!


Performance issue when open huge file

VSCode Version: Version 1.34.0-insider (1.34.0-insider), also can be reproduce in stable latest
OS Version: macOS Mojave Version 10.14.4. MacBook Pro (Retina, 15-inch, Mid 2015

Steps to Reproduce:

open a small avascript file. everything is fast and cmd+click works fine.
open a large react javascript file. imported bunch of files and 1500+ lines of code in 1 file.
you can see that cpu usage boosts up to 100%+. overall performance gets super slow. cmd+click is loading forever
after opening the large file. cpu 100% usage never gets down. and even no.1 small file doesn't work with cmd+click

this worked fine. before i update my macbook to 10.14.4

Does this issue occur when all extensions are disabled?: Yes

downloaded to 1.32.3 and works fine

I was thinking that auto-completion was broken, it seems I have the same issue as you… Using auto-complete write loading… and nothing complete
Version 1.33.0 (1.33.0)

Which process is that? Please run code --status while this is happening and share the output.
And does this still happen when you start with --disable-extensions?
My first guess is that this will involve the TS server, so if so is this a project that is on github or that you can share?

Looks like there is a TS perf issue: https://github.com/Microsoft/TypeScript/issues/30663
https://github.com/Microsoft/vscode/issues/71746
It looks like you can change the TS version away from 3.4.1 (in the status bar) to work around this


Refactor "Admission Webhook" configuration part in Helm chart.

Task description:
The current structure of the Helm chart's values.yaml file is misleading, as whitelistNamespaces is nested under .Values.scheduler.customWebhook, leading users to believe that they must enable .Values.scheduler.customWebhook.enabled to utilize this functionality.
Additionally, values.yaml lacks support for defining reinvocationPolicy for the Admission Webhook. This may need to be set to IfNeeded if users implement other webhooks that set nvidia.com/* resources in a manifest, which might be processed after HAMI's webhook. This, in turn, can cause HAMI's webhook to be "skipped", leaving processed pod's manifest unchanged (i.e., not setting HAMI's scheduler), resulting in an unschedulable pod.
Solution:

Refactor the Helm chart by moving the customWebhook group into a generalized .Values.scheduler.webhook key, renaming it to customURL. Keep whitelistNamespaces under the webhook key.
Extract the reinvocationPolicy parameter and place it under the .Values.scheduler.webhook key with the same name.

Who can join or take the task:
The good first issue is intended for first-time contributors to get started on his/her contributor journey.
After a contributor has successfully completed 1-2 good first issue's,
they should be ready to move on to help wanted items, saving the remaining good first issue for other new contributors.
How to join or take the task:
Just reply on the issue with the message /assign in a separate line.
Then, the issue will be assigned to you.
How to ask for help:
If you need help or have questions, please feel free to ask on this issue.
The issue author or other members of the community will guide you through the contribution process.

/assign

/assign

I have made some additional changes in helm chart to make it more intuitive (described in the PR).
I have removed draft status as it's ready for review.


360° playback possible improvements

We now support 360 video playback directly in SRG Media Player. There are still a few ideas which could be implemented:

Limit motions to +pi/2 and -pi/2 when moving up and down.
Disable pan gesture with cardboard and re-center.
Add inertia to pan gestures.
Implement camera reset to face the content.
Have camera orientation stable under device rotation.

None of those have been discussed or are mandatory, I just wanted to keep track of what could be possible if we want to go further.

Cool, is this already part of a new LB release? Would love to update to test out.

Moreover, there are a few issues on iOS 9, due to issues with SKVideoNode:

360° playback automatically starts, even if the media was only prepared. See for example the following post.
SKVideoNode leaks. See for example the following github issue.

These problems have been fixed with iOS 10. I mitigated the second issue since it can be quite annoying (playback is paused, but the leaks is not removed).I recommend we do not lose time fixing these issues further, though.

@vpdn This is part of the next LB release.

Note that currently:

Playback is paused when switching between normal and cardboard 360° playback. This is due to SKVideoNode being deallocated. Currently we let things as is, since this could make sense after all. If we get complaints we'll try to improve such transitions.
Until iOS 11, Split Over on an iPad stops the video frame (but not the playback itself) for 360° playback. This is not the case anymore with iOS 11: As for normal videos, playback continues. For the moment we won't write code to deal with this minor inconsistency, which will after all disappear when iOS 11 is the minimum version we support.

360° has been in use in our apps for quite some time and the improvements I suggested do not seem necessary at the moment.


feat(cli): new plugin platform

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copying my comment from the other commit:
What changes are coming/how should we update current plugins to support the new plugin platform?


No output

Hi
I am not having any luck getting this running. I have tried on a couple of Debian Jessie and a Ubuntu 18.04 and the result is the same on both.
If I simply type in aws_public_ips on its own or with -v , it simply returns with an exit code of 0. If I run:
aws_public_ips -v -s ec2 (or any other -s value)
I get:
/var/lib/gems/2.1.0/gems/aws_public_ips-1.0.2/lib/aws_public_ips/cli.rb:105:in 'rescue in run': undefined method '[]' for nil:NilClass (NoMethodError)         from /var/lib/gems/2.1.0/gems/aws_public_ips-1.0.2/lib/aws_public_ips/cli.rb:96:in 'run'         from /var/lib/gems/2.1.0/gems/aws_public_ips-1.0.2/bin/aws_public_ips:7:in '<top (required)>'         from /usr/local/bin/aws_public_ips:23:in 'load'         from /usr/local/bin/aws_public_ips:23:in '<main>'
with an exit code of 1

same here, running osx

@flantel @johnsmyth thanks for the issue, lets try and figure this out. Can you share:

how you're authenticating (via shared credentials file, environment variables, or metadata endpoint)?
what results or how many results you're expecting to see (i.e. do you have some known public ips in that account)?
what's the output of aws_public_ips --format prettyjson

@flantel @johnsmyth I believe I found the issue, can you try again with 1.0.3 and let me know if that resolves the issue? Thanks for beta testing :)

Works perfectly now, many thanks!!

Nice. Now I can automate my scanning to ensure nothing is open which shouldn't be.
for i in $(aws_public_ips -s ec2); do nmap -Pn --open  $i; done |mail -s "nmap aws" barryf

@johnsmyth I'd like the default to fail loudly but I'll add a CLI option to warn + continue
Thank you both for reporting this issue - going to close as resolved


Recommended installation

Personally, I recommend installing this project using pipx.
pipx install git+https://github.com/KraXen72/shira
If you get a missing dependency error, you can simply inject it.
e.g.
pipx inject shira pillow
pipx inject shira mediafile
This way you won't pollute your system packages, if you are on ubuntu for example.

Note:
Installing via a link also works with normal pip, e.g. pip install git+https://github.com/KraXen72/shira
But I wouldn't recommend doing that if you are on linux.

i have not heard of pipx before. i'll look it up and possibly add it to the install instructions if it proves to be simpler for users to install. my end goal would be publishing the package in pypi, but even then, it's still some extra setup due to ffmpeg.

From pypa

pip is a general-purpose package installer for both libraries and apps with no environment isolation.

pipx is made specifically for application installation, as it adds isolation yet still makes the apps available in your shell;
pipx creates an isolated environment for each application and its associated packages.

So really, the only difference is that with pipx you are not polluting your global packages.

can i provide a list of dependencies for pipx? would be better than having to install manually

hmm, i see there's this open pr, but there might be a better solution in the meantime - are you aware of one? thanks!

pipx uses the same build system as pip, so you only have to list your dependencies in pyproject.toml
https://github.com/KraXen72/shira/blob/master/pyproject.toml#L6
you are missing mediafile and pillow

okay, i added them. could you please test if it all works with pipx install git+https://github.com/KraXen72/shira? i'll test it later as well. then, if it works, you can open a pr which adds this way on top of the install instructions in README, keeping the old way as a fallback. if you don't want to open a pr, let me know, i'll change it later. thanks for tellling me about this.

Works

since you can get pipx off of scoop i'll change the recommended windows install method to first install scoop, then pipx & ffmpeg and then this. sounds like a nice way to kill 2 birds with one stone. i'll add a mention about linux as well, that you can just install ffmpeg & pipx from wherever and then use the same pipx command. i'll keep the current install instructions under some later section about contributing.


fix: user get balance

closes #49

can you address failing CI

Yeah sure

Should we move getBalance to getBalance.js then since it is not metadata ? and rename getErc20Data to getMetadata?
For some context, I think getErc20Data grouped everything together as a convenience to the rainbow-bridge-frontend, https://github.com/aurora-is-near/rainbow-bridge-frontend/blob/06ca162327e16288b389b8ee28843a48d22edecd/src/js/utils.js#L18 but since getAllowance was also added separately, it makes send to refactor it.

I think we can close this PR because the library is now using ethers and I will be making this refactor in this PR: https://github.com/aurora-is-near/rainbow-bridge-client/pull/58

I think we can close this PR because the library is now using ethers and I will be making this refactor in this PR: #58

Please close it if you feel that it doesn't add to main branch or the refactor you have in the PR #58 :)


ObjectId supports data mode

In view of the current root-state container mode, there are two formats, Map and Set, but the value is object_id, and the corresponding object needs to be stored in the local NOC. However, in many cases, the value may be just some simple information that is not long. Therefore, having to map objects will make the operation cumbersome and reduce performance, so consider introducing object_id itself to encode custom information
Currently ObjectId is an array of 32bytes in length, which defines three types:
pub const OBJECT_ID_STANDARD: u8 = 0b_00000001;
pub const OBJECT_ID_CORE: u8 = 0b_00000010;
pub const OBJECT_ID_DEC_APP: u8 = 0b_00000011;
The type occupies the highest two bits of the first byte, and a type with all zeros is left, which can be used as a related type of custom data. The design is as follows:
The highest bit of the first byte of ObjectId is 00, the remaining 6 bits are reserved, and the remaining 31 bytes are used to store any custom data

The highest byte of the ObjectId, the first two bits are 0 to indicate the Data mode, and the remaining 6 bits indicate the length of the data, which supports a maximum of 31 bytes

The 31 bytes except the highest byte of ObjectId are used to store custom data

ObjectCategory adds Data type, you can use object_id.category() to judge whether it is Data mode

Use ObjectIdDataBuilder to construct an ObjectId in Data mode

ObjectId in Data mode is generally used as the value of objectmap. For data less than or equal to 31 bytes, you can avoid relying on an additional object

The rust sample code is as follows
let data = "hello!!! first id";
let id = ObjectIdDataBuilder::new().data(data).build().unwrap();
assert!(id.is_data());
assert!(!id.is_standard_object());
assert!(!id.is_core_object());
assert!(!id.is_dec_app_object());

println!("len={}, {}", id.data_len(), id.to_string());

let data2 = id. data();
assert_eq!(data2.len(), data.as_bytes().len());
assert_eq!(data2, data.as_bytes());
assert_eq!(id.data_as_utf8_string_unchecked(), data);

let id = ObjectIdDataBuilder::build_empty();
assert!(id.is_data());
println!("len={}, {}", id.data_len(), id.to_string());
assert_eq!(id. data_len(), 0);
assert_eq!(id.data().len(), 0);

Complete at b5f344171182943c5c0121323276a81cd9c405f6


[feature]Support build image from source code (CI/CD pipeline)

We can follow knative tecton build

implemented by https://github.com/oam-dev/kubevela/pull/390


Fix breadcrumbs in EE detail page to make it consistent with nav

Before:

After:

Good catch :+1:,
we also have these...
src/containers/execution-environment-list/execution_environment_list.tsx
306:          title: t`Container registry type`,

src/containers/execution-environment-manifest/execution-environment-manifest.tsx
100:                  name: t`Container Registry`,


Initial API proposal (for merging proposed YAML of PR#9)

What type of PR is this?

enhancement/feature

What this PR does / why we need it:
This is the initial proposal from KDDI for the Number Recycling API
Which issue(s) this PR fixes:

Fixes #8
Special notes for reviewers:
This PR is for merging proposed YAML of PR #9.
Changelog input
 release-note

Additional documentation
None
docs

Hello @eric-murray , @grgpapadopoulos
I changed the format of specifiedDate parameter from RFC 3339[YYYY-MM-dd 'T'HH:mm:ss.SSSZ] to ISO 8601((YYYY-MM-DD). Because we are not considering use cases that specify time.

I changed the format of specifiedDate parameter from RFC 3339[YYYY-MM-dd 'T'HH:mm:ss.SSSZ] to ISO 8601((YYYY-MM-DD). Because we are not considering use cases that specify time.

So, a number of comments here:

Format "YYYY-MM-DD" is both a valid RFC 3339 and ISO 8601 format, so there is no reason to reference ISO 8601 rather than RFC 3339. The argument against referencing ISO standards is that obtaining the standard costs money. If it is not expected that the API consumer is required to consult an ISO standard, then don't reference it.
Making specifiedDate just a string makes parsing harder for API implementations. At the very least, add a pattern to simplify validation. But a simple pattern such as \d\d\d\d-\d\d-\d\d would allow invalid dates such as 2024-00-00, and so you end up requiring complex patterns and/or custom validation algorithms.
Far better just to make specifiedDate require format: date-time. Code generators (both for client and server implementations) know all about date-time, so generation and validation of the string becomes automatic. It is irrelevant that this allows a time to be specified as well as a date, as the time can be ignored if the API consumer specifies that.

So my recommendation is to make specifiedDate follow format: date-time, requiring the API consumer to follow RFC 3339. This also complies with the Commonalities guidelines for data types.

Hello @eric-murray
Thanks for your comment. We updated the YAML to use either specifiedDateTime or specifiedDate parameter.
oneOf:
- required: [specifiedDateTime]
- required: [specifiedDate]
I understand format: date-time is described on Commonalities guidelines. However, we are not considering use cases that specify time for this API. Format "YYYY-MM-DD" is also used for KYC API. Thus, we'd like to choose the data related parameter based on the use case.

Hello @eric-murray , @grgpapadopoulos
I'll prepare to propose an additional content to description. So please wait for your approval until I propose this.

@yamamoto0104
OK. I'm happy with the current proposal, so will approve after you update the field description.
In case you have not seen it, there is an useful online comparison of valid RFC 3339 and ISO 8601 date/time formats here.

Hello @eric-murray and @grgpapadopoulos
I update the description as follow:

True and false scenarios for API response were added.
The figures for True/Faise were added to /documentation/API_documentation/assets/ folder. If this PR is merged, the URL of the figures in the YAML file will be updated.

If this PR is merged, the URL of the figures in the YAML file will be updated.

We know in advance what the links will be, so can specify them now. I updated them both as suggested changes so you can see how links to your repository will be mapped to links in the CAMARA repository.

If this PR is merged, the URL of the figures in the YAML file will be updated.

We know in advance what the links will be, so can specify them now. I updated them both as suggested changes so you can see how links to your repository will be mapped to links in the CAMARA repository.

Thank you, @eric-murray.
You are right that we already know the links in CAMARA Repository.
On the other hand, as you can find in the last meeting minutes, I have asked all members to review the initial proposal (I assume) by the next meeting. My preference is to keep it as it is by the next meeting for reviewers. Please let us update it with your suggested changes on the links after the next meeting, and then merge it to the CAMARA repository.

@Masa8106
OK, I'll give my approval now. But note that, when you update the links, it will cancel existing approvals and you will need the PR to be re-approved before it can be merged.

@eric-murray
Thanks for your understanding. I see your note. Once we update the links, we will do re-approval.

Hello @eric-murray and @grgpapadopoulos
The links were updated.
During the meeting today, there was no additional comment.
Would you approve it again? Once either of you approve, I will merge this PR. Thank you.


Russian language and date

Can't change date format in Russian language. Menu doesn't open. Day names with small letters. Apk version 2.0.8.
App does not translate into Russian even after installing Russian apk from split. Even after installing from Play Market.
Android 9, Nokia 6 (TA-1021).

I'm looking forward to add the missing translations.


Update pages and add option to card for those pages

(no shadow and color of cards / passed down forom SubMenu Card to Card)

Intro pages for english mostly


Displaying the depth map

Thank you for this work,
How can I display the depth map images using this code?

This class https://github.com/chamorajg/pytorch_depth_and_motion_planning/blob/master/depth_prediction_net.py#L48 should give you the depth map as an output.


cmd/compile: use Node.Right rather than Node.RList for OAS2* nodes (cleanup)

Cleanup suggestion (per e-mail discussion between @griesemer and @mdempsky):
The nodes with ops OAS2FUNC, OAS2RECV, OAS2MAPR, OAS2DOTTYPE, and OASOP, use an RList, but (at least) in the documentation the RHS looks like a single node.
They could be (likely) switched to using the RList field, making that field access slightly more efficient.

Marking as "help wanted" since this is probably a reasonable task for folks modestly familiar with the Go compiler and wanting to contribute. It should mostly involve:

In typecheck.go, finding the places where Op==OAS2 is changed to OAS2FUNC/OAS2RECV/OAS2MAPR/OAS2DOTTYPE, and moving n.Rlist.First() to n.Right at the same time.
Finding all the rest of the compiler code that checks for those OAS2* nodes, and replacing n.Rlist.First() or n.Rlist.SetFirst(x) with n.Right and n.Right = x, respectively.
Update the documentation in syntax.go to reflect the new Node convention.

Make sure to update esc.go too and test that it works with -gcflags=all=-newescape=false, assuming it hasn't been removed yet.

I will take care of this one!

@mdempsky There is a lot of places like that https://github.com/golang/go/blob/master/src/cmd/compile/internal/gc/iimport.go#L976 where r.exprList() returns list of nodes, how should we assign it to n.Right? Take the first element from r.exprList()? Or what?

@Zyqsempai Thanks for volunteering to make this change.
Because this is a very low-priority issue (I filed this mostly as a reminder for myself for a future cleanup), please keep in mind that it may not make a lot of sense for a Go Team member to spend time tracking down a bug you have introduced in your change - there's simply too much higher-priority work to be done. Please do not send a non-working PR, we're not going to fix it for you. Hopefully this makes sense.
That said, in this specific case, the tricky part is to make this change only for nodes with the specified Op values. If the change is made for any other node, arbitrary things might happen. Perhaps you overlooked a case somewhere. I'd go back and manually double-check every single change and corresponding Node Op value.
If you're still stuck, perhaps a community member can help out. It may also be that we overlooked something and this change is more subtle than it looks like.
Thanks.

@griesemer Thanks a lot. Will check everything again.


refactor model.is_file and is_aml_model

refactor model.is_file and is_aml_model by using a consolidated model_type field.

Overall it looks good. Thanks for this change!

Looks good to me. Feel free to change olive package name back in yml file and dockerfile then I'll approve this PR.


[CIBUILD] Upload Dockerfiles.

Upload Dockerfiles including cuda 11.4.2 and cuda 11.6.1.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


add encounter location

small update to dtr bundle for dinner questionnaire tests

This is fine, though I'm not really sure I understand the text "observation2c" for a location.

In this case, it is a display-only reference, similar to what is in this example, so there won't be a Location instance. It is something specific to some DTR pre-population logic.


Typo: Pytorch Experiment Tracking Lesson

Thank you for the great resource! Just highlighting a small typo, that might save some minor confusion for others using it:
Section 8 [View Experiments in TensorBaord] of lesson 7.
Post running the experiments, the image highlights the experiment- efnetb0, 10 epochs, 20% data as the experiment with the lowest test accuracy.
Image - https://raw.githubusercontent.com/mrdbourke/pytorch-deep-learning/main/images/07-tensorboard-lowest-test-loss.png
But in the text following the image, the lesson mentions that the experiment - effnetb2, 10 epochs, 20% data has the lowest test accuracy.

Thank you for this!
Fixed: https://www.learnpytorch.io/07_pytorch_experiment_tracking/


README: docker compose readme improvements 2

This PR is for:

More controversial readme improvements
Problems that I found trying to set up my own env on a new mac according to the previous readme

@mtaran , I'm arbitrarily declaring you as the reviewer (but feel free to declare it's actually someone else) (just don't want it to be "each person thinks it's someone else")

@mtaran you said

I don't see any issues aside from the project name thing (see my comment on that thread)
So.. would you approve please?

I don't consider the project name thing to be blocking because it doesn't make anything worse, but please say if you disagree.
And this PR does contain imo important things, like this bug that someone spent a long time debugging yesterday. I mean, it's not just the project name thing

@mtaran ,

I acknowledge that putting in things to git is in some (important) sense acknowledging they are correct
I think that if we have something already-in-git that has 2 problems, then it is way better to accept a PR that fixing one of the problems without fixing the other, than rejecting such a PR until it fixes both. I think reducing friction to making gradual improvements matters.
I still accept this request of yours and I reverted my change to that part completely, except only I added a heading, so that readers can skip it more easily if they want to. But the text inside is unchanged. Does that sound ok?


Actions in Firebase Push Notification

Can i add actions like "Reply" in payload to show in firebase push notification?

Yes, but sooner all of this gonna change and you'll be able to implement it whatever you want to, the way you want to.


Fix indent issues with continaution indent

I don't know if I'm the only one that when there are some continuation indents in a file, if I autoformat them with IntelliJ they are indented with 8 spaces and when that code is pushed the ktlint rules complain about it.
This PR fixes that. It defines the desired indent so IntelliJ and ktlint are aligined.

You're not alone, I've also noticed this - but isn't this just changing the IntelliJ config to make ktlint happy? It should be the other way around. I think ktlint has problems with continuation indents so my preference would be to turn off that rule if it's not working correctly instead of changing the default IntelliJ code style.

You're not alone, I've also noticed this - but isn't this just changing the IntelliJ config to make ktlint happy? It should be the other way around. I think ktlint has problems with continuation indents so my preference would be to turn off that rule if it's not working correctly instead of changing the default IntelliJ code style.

Well, that depends if we want to have continuation indentation of size 8 or 4. I prefer them to be of size 4. And because, right now, all the code uses identation of size 4 (because of ktlint) I think that it's ok to continue with indent of 4.


Broken repo link

Hi,
The web page for this repo is broken:
http://inch-ci.org/github/Origen-SDK/origen_jtag
Thanks,
Stephen

Seems to be fixed now.


no module named googleapiclient.discovery

Expected Behavior
As this failed on line two, I have no idea what could have happened
Actual Behavior
Fails on line 2 of quickstart.py
Steps to Reproduce the Problem
1.Run quickstart.py
2.Wait 0.0005 seconds
3.Get error message above
Specifications

Python version (python --3.5.3)
OS (raspberian v 9)

I got the same issue. But noticed the below error for six happened before installing google's libraries.
  Downloading https://files.pythonhosted.org/packages/f6/25/66a49231b44409d7f07cfcf2506a8b070ce3c99fc47cc256bea833f24791/uritemplate-3.0.0-py2-none-any.whl
Requirement already satisfied, skipping upgrade: rsa>=3.1.4 in /Library/Python/2.7/site-packages (from oauth2client) (4.0)
Requirement already satisfied, skipping upgrade: pyasn1>=0.1.7 in /Library/Python/2.7/site-packages (from oauth2client) (0.4.4)
Requirement already satisfied, skipping upgrade: pyasn1-modules>=0.0.5 in /Library/Python/2.7/site-packages (from oauth2client) (0.2.2)
Requirement already satisfied, skipping upgrade: cachetools>=2.0.0 in /Library/Python/2.7/site-packages (from google-auth>=1.4.1->google-api-python-client) (3.0.0)
Installing collected packages: six, google-auth, google-auth-httplib2, uritemplate, google-api-python-client, oauth2client
  Found existing installation: six 1.4.1
Cannot uninstall 'six'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.

Let's follow up in #58 instead, since I've already started troubleshooting there.


Do counters reset when server changes in HA mode

Let's say I have three servers running in HA mode and the server is counting errors using a counter.
After leadership change, the new instance will start counting from 0.
I am trying to understand how will the counter show up in graphs. Will the counter drop to zero?

For usage questions/help, please use our community. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.


APP-2905: Datafeed Service V2 implementation

Datafeed Service V2 implementation
Enable Jacoco check on DatafeedServiceV2 with code coverage > 90%
Documentation already added in V1 PR

All classes must be well documented please. This is a SDK!!!

Can't agree more with Darlys. Documentation and naming of class/methods has to be crystal clear and consistent.

Of for instance in the beginning of start, let's say we messed up the authentication

@symphony-youri  We can wrap a simple start loop by a single retry, but I'm not sure that we expected the retry should be applied to which level (DatafeedService level or API call level). For instance, if we fail to delete a datafeed, do we expect to retry only the delete call or whole start method (retrieve, read...)?

And this discussion gives me an idea that we can now remove all the retry mechanism in DatafeedService class. In DatafeedService, we just simply call the api from DatafeedApi, don't care about retry at all, and we will implement the retry mechanism inside the DatafeedApi by templating it using swagger spec.
What do you think? @symphony-youri @symphony-thibault

Maybe it would be ok just restart the whole process, it could help to make the code easier to read
But no blocker for me on this, this is internal so we can test it further and improve it later

what!!! di

@symphony-youri we have a dedicated story for next Sprint to improve the retry mechanism. Actually, implementing retries shouldn't have been part of this PR to make review simpler and shorter. We decided with @symphony-hong to let it as it is and fix it on next Sprint

And this discussion gives me an idea that we can now remove all the retry mechanism in DatafeedService class. In DatafeedService, we just simply call the api from DatafeedApi, don't care about retry at all, and we will implement the retry mechanism inside the DatafeedApi by templating it using swagger spec.
What do you think? @symphony-youri @symphony-thibault

Isn't it going to the caller of the API that can decide of the retry mechanism to use?