Analyzer performance issues from Flutter plugin

There are several recent issues in the Flutter plugin for IntelliJ issue tracker that relate to poor performance of the Dart analyzer. I've asked them to create issues here, but that may not happen.
Here's a few of the recent issues:
https://github.com/flutter/flutter-intellij/issues/6373
https://github.com/flutter/flutter-intellij/issues/6379
https://github.com/flutter/flutter-intellij/issues/6385
https://github.com/flutter/flutter-intellij/issues/6388

Thanks for gathering these, @stevemessick  😁

Update: I have been unable to bisect today. I cannot figure out how to run our benchmark script locally. Filed #50382 and I'll continue tomorrow.

Update: I spent some time bisecting with the das-flutter-start benchmark metric locally (golem history here). It's time-consuming because of the compilation step, and tricky because it's very noisy. I've been tracking average time, minimum time, and std dev (to maybe identify when it got so much noisier).
In any case, the trouble seems to have started around 31 Oct. At first I was very suspicious of https://github.com/dart-lang/sdk/commit/925268bebed8e095871cb95cfd3f4123ea6af958, which is small, but introduces a while (true), but honestly, it looks innocent enough...
However, when I took a recent commit () and reverted 925268bebed8e095871cb95cfd3f4123ea6af958, I did not observe a das-flutter-start benchmark improvement... And after some more tests, the benchmark seems quick at 09c1722044177743b705d0faf5b26260a04c71df and at 5db6b482b07d0d4e67a45d95cce2f405bcf98b04, each are after 925268bebed8e095871cb95cfd3f4123ea6af958, so I'm going to continue benchmarking commits after that point.
Also, this bot uses flutter master so 🤷 it could be a flutter commit 😬 .

I may have spent that time on a wild goose chase. The benchmark seems to have largely stabilized back? Maybe there is some correlation with the weekend?

I don't know if it will help you but I can confirm that the issue flutter/flutter-intellij#6385 is still happening

What version of Dart are you running now, @mariusvn ?

Dart SDK version: 2.18.4 (stable) (Tue Nov 1 15:15:07 2022 +0000) on "windows_x64"

It looks like 2.18.4 is just 2.18.0 (released in August) + cherry picks related to the VM, so that would not be related to the performance regressions that started in October.

Oops, I may be under the wrong impression.
@stevemessick isn't this bug for recent regressions of the Dart SDK at HEAD? Or is it for Dart 2.18.2 as stated in https://github.com/flutter/flutter-intellij/issues/6385 ?

Sorry, missed this last week. @srawlins The author of https://github.com/flutter/flutter-intellij/issues/6385 mentioned having performance problems with Flutter 2.8.x. He also mentioned building a new PC to hopefully have a fast enough machine to eliminate performance issues, so I don't know if 2.8 is related.

@stevemessick @srawlins I want to note that the same project in vscode works without such friezes. Also, the same project in android studio on my macbook 14 pro(m1 pro cpu) works without friezes. I'm still inclined to believe that the problem is with jetbrains  dart | flutter plugin for windows. Maybe I'm wrong, but I think it's important for you to know.

Just to add something @ArZargaryan: I have this problem on a MacBook Pro (13-inch, 2019) too

@benjamincombes Okay, then this is my misconception, i'm sorry.

@benjamincombes Okay, then this is my misconception, i'm sorry.

@ArZargaryan actually, for the JetBrains part, that still could be possible as I only use Android Studio for development..!

Still happening if the project is big enough (in my case a flutter project). It got really slow and it's hard to work with. :(

Still happening if the project is big enough (in my case a flutter project). It got really slow and it's hard to work with. :(

https://github.com/flutter/flutter-intellij/issues/6385#issuecomment-1333782572
Here is the solution.


What changes in every update?

Hi, I tried to decrypt tdata file from latest version of telegram with this tool and it didn't work, and tried with older version and it worked and decrypted tdata file.
My question is what changes in every update in telegram desktop and what should I change in this tool to work?

I suspect the map file format has changed, but right now I don't have the time to figure out the details.

hi, for me not even the older version works... the last version always says for each file "expected 3 streams, got 1"... maybe it is possible do decrypt just the 1 stream if it is a media file?
If someday you have the chance or time to check that out or even update this library it would be helpful to a lot of people because i haven't found other updated libraries in internet that helps decrypt telegram tdata... thanks.

yeah im getting the 2020/09/11 18:25:49 expected 3 streams, got 1 error

What about now?


How to get classification based on this Euclidean distance ? what should be the threshold ?

I dont understand how to set a threshold, with which we can say if its the same person or not. Say if distance is > 0.5 apart, its different person ... less than 0.5 they are the same person.
Thanks in advance :)

You may decide to mask your tensor of predictions using a threshold value and convert them to torch.long
(predictions > threshold).long()
This will produce all values greater than threshold as 1 and those less than as 0. Hope this helps


DomainParticipant create_publisher

Add new create_publisher method following DDS standard
New unit test to check PIM create_publisher functionality
Implementation of PSM Publisher constructor
New unit test for PSM constructor

NOTE: This PR must be merged after #1073

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Failed tests not related. Known flaky tests.

This PR broke DDSSimpleCommunicationTypeDiscovery test. Isn't a flaky test anymore, is totally broken.
The publisher needs the QoS information from publisher_attributes (as PublisherQos I guess).
I'm not sure, but I think that the topic information is only needed by the datawriter.


History search not working as before/intended

General information

Basic examination

[x] I have read through the README page
[x] I have the latest version of zsh-vi-mode
[x] I have tested with another terminal program

Problem description
Searching using arrow keys no longer works.
The binds from "bindkey" do not differ for "^[[A" and "^[[B" which confuses me.
As per: https://github.com/jeffreytse/zsh-vi-mode/issues/12
I tried
zvm_after_init_commands+=("bindkey '^[[A' up-line-or-search" "bindkey '^[[B' down-line-or-search")
This works for the command key word but not the entire command.
For example using vi-mode:
ping 1.1

*up*

ping <IP_ADDRESS>

This searches for "^ping 1.1[.*]" and completes the command as well as the string after wards. Working as intended.
However while using zsh-vi-mode:
ping 1.1

*up*

ping <IP_ADDRESS>

This searches for "^ping[.*]". It does search for ping but for all pings. Removing functionality that was once had.
I have read the README.md and know about { /, n, N} to search and then navigate back and forwards. This gets back some functionality but not all as this instead searches for "[.*]ping 1.1[.*]" which is all history containing the string "ping 1.1".
I just want to search like I was doing before. This should be easily avoided by the code first checking for binds and then ignoring them if it detects previous binds instead of just assuming the user wants to use zsh-vi-mode binds.
This all works completely normally and expected with "vi-mode" plugin that this is supposedly better and should replace. Until this is fixed I cannot say this is better or improved. Just different.

I had the same issue, and It doesn't look like that this is currently possible with zsh-vi-mode.
Here's a useful post I found on the internet that accomplishes this without the plugin, all you have to do is paste the code snippet in the post into your .zshrc

This works for the command key word but not the entire command.
@yuannan I know it's been 2 years, but for this specific behavior, you need
zvm_after_init_commands+=("bindkey '^[[A' up-line-or-beginning-search" "bindkey '^[[B' down-line-or-beginning-search")


[BUG?] execute "objects_list SpearCarapace" -> server logs false & changing coordinates.

I used objects_list SpearCarapace to locate a single missing spear and found it at the location printed in the local F5 game console. thumbsup
The server logged this:
[Info   : Unity Log] <NonsenseEndianDATE> <TIME>: <SteamID>/<MyNickName> (2374, 4880, 65): objects_list SpearCarapace
[Info   : Unity Log] <NonsenseEndianDATE> <TIME>: <SteamID>/<MyNickName> (2383, 4905, 75): objects_list SpearCarapace
[Info   : Unity Log] <NonsenseEndianDATE> <TIME>: <SteamID>/<MyNickName> (2383, 4905, 75): objects_list SpearCarapace
[Info   : Unity Log] <NonsenseEndianDATE> <TIME>: <SteamID>/<MyNickName> (2449, 5001, 173): objects_list SpearCarapace

Note the changing coordinates and none of those were the right ones. The last line was closest I think but I only remember Y="4999,?"
I executed the command four times because I used the server log's information and didn't find anything there...

That is your position when executing the command.

lol, thx.
Guess I thought myself in a corner there.
seems so obvious now (doh). ;-)


Test 1 & 2 failed

Describe the bug
In my case, I see 'KO' for tests #1 & #2, when in my terminal I don't have any problem compiling.
Expected behavior
Tests 1 & 2 being OK
Desktop (please complete the following information):

OS: Windows 11 + WSL2

edit : replaced text with latest picture.

Hello,
it seems that the directory ../42-pipex does not exist from the tester point of view. Can you confirm you file hierarchy is as follow:
42Quebec/
├── 42-pipex/
└── pipex-tester/

Hello, no, the folder structure is not like that, as I got cloned pipex-tester from 42-pipex.
So the structure is :
42Quebec>42-pipex(where my pipex is)>pipex-tester
Should I got clone on 42Quebec instead ?

OK, I misread 'alongside pipex directory". All good. My mistake. sorry.


Update DefaultBeanIntrospection.java

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md

I don't think this is the aim of that statement.

I am getting an error at this line when using Java DSL and this log method gets called in each setProperty call for a property from PropertyBindingSuppot.setProperty.  So if the Endpoint is not fully constructed i.e. not all properties are set. The issue can come in hashCode() method of DefaultEndpoint.

Can you show a reproducer for this, because it looks like you're the only facing this problem.

Maybe open a JIRA issue about this with a reproducer somewhere. For the moment let me close this.


Update security-center-disk-encryption.md

change instructions to pass aadName as a parameter rather than waiting for prompt

@ejarvi : Thanks for your contribution! The author, @TomShinder, has been notified to review your proposed change.

#sign-off


rdf-toolkit discards information

testcase2.ttl:
@prefix ex: <https://ex.com/> .

_:b66 ex:a ex:Execution ;
   ex:produces _:b67  .

_:b67 ex:a ex:ContentExpression .

_:b0 ex:a ex:File ;
  ex:hasPart _:b67 .

java -jar ~/Downloads/rdf-toolkit-1.14.2.jar -tfmt turtle -sdt explicit -dtd -ibn -sni -s testcase2.ttl -t testoutput.ttl

produces:
@prefix ex: <https://ex.com/> .
@prefix owl: <http://www.w3.org/2002/07/owl#> .
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
@prefix xs: <http://www.w3.org/2001/XMLSchema#> .

[]
        ex:a ex:Execution ;
        ex:produces [
                ex:a ex:ContentExpression ;
        ] ;
        .

[]
        ex:a ex:File ;
        ex:hasPart [
                ex:a ex:ContentExpression ;
        ] ;
        .

which discards the fact that the blank node _:b67 is the same thing that is the part of the file.
rdf-toolkit makes it look like the part of the file could be the thing produced by the execution or not.
see how apache jena does not discard that fact:
$ ~/Downloads/apache-jena-4.9.0/bin/riot --formatted=turtle testcase2.ttl

produces
@prefix ex: <https://ex.com/> .

[ ex:a         ex:Execution;
  ex:produces  _:b0
] .

[ ex:a        ex:File;
  ex:hasPart  _:b0
] .

_:b0    ex:a    ex:ContentExpression .

see how it does not discard the fact that the file has a specific part _:b0
in this case, rdf-tool kit isn't wrong, but it is discarding information.
by that i mean the input data says "X is the case" and the output of rdf-toolkit says "X is or is not the case."

@justin2004, imho, jena does not consistently run our option -ibn because _:b0 is not formatted as an inline blank node in the last line of the output.
So running rdf-toolkit without -ibn parameter keeps the node identity - see also https://github.com/edmcouncil/rdf-toolkit/issues/55#issuecomment-1770417649.


Fix missing script link

Fix missing htmx-ext-transfer-encoding-chunked link
messages, cast obj to str
fix target post form

Sounds like you need to update your FastHTML to the latest version.


LibraryError: RPC: Invalid params: {"reason":"missing field simulation_flags}

Describe the bug
I try to use Starknet-js using Javascript on Visual Studio code. I want to set a number in my contract using Invoke, but I keep getting the error:
file:///Users/egeaybars123/Desktop/simple_storage_sdk/node_modules/starknet/dist/index.mjs:2655
throw new LibraryError(
^
LibraryError: RPC: starknet_estimateFee with params {"request":[{"type":"INVOKE","sender_address":"0x067981c7f9f55bcbdd4e0d0a9c5bbcea77dacb42cccbf13554a847d6353f728e","calldata":["0x1","0x1bb7d67375782ab08178b444dbda2b0c1c9ff4469c421124f54e1d8257f2e97","0x2f67e6aeaad1ab7487a680eb9d3363a597afa7a3de33fa9bf3ae6edcb88435d","0x1","0xf"],"version":"0x100000000000000000000000000000001","signature":["0xba4f9aad4ef7d012d58efa81c692aa83decaa13c460fe0b31ca9aa2087783c","0x2c53f24b46bf782bfc07de0b453f407634be319a381ecbf2218bd1a4c31652d"],"nonce":"0x6","max_fee":"0x0"}],"block_id":"pending"}
 -32602: Invalid params: {"reason":"missing field `simulation_flags` at line 1 column 532"}
    at RpcProvider.errorHandler (file:///Users/egeaybars123/Desktop/simple_storage_sdk/node_modules/starknet/dist/index.mjs:2655:13)
    at RpcProvider.fetchEndpoint (file:///Users/egeaybars123/Desktop/simple_storage_sdk/node_modules/starknet/dist/index.mjs:2671:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Account.estimateInvokeFee (file:///Users/egeaybars123/Desktop/simple_storage_sdk/node_modules/starknet/dist/index.mjs:4338:22)
    at async Account.getSuggestedMaxFee (file:///Users/egeaybars123/Desktop/simple_storage_sdk/node_modules/starknet/dist/index.mjs:4637:23)
    at async Account.execute (file:///Users/egeaybars123/Desktop/simple_storage_sdk/node_modules/starknet/dist/index.mjs:4446:49)
    at async file:///Users/egeaybars123/Desktop/simple_storage_sdk/index.js:29:13

To Reproduce
You can copy and paste my code to reproduce the problem:

import { Account, RpcProvider, json, Contract } from 'starknet';
import fs from 'fs';
import * as dotenv from 'dotenv';
dotenv.config();

const privateKey = process.env.PRIVATE_KEY;
const ApiKey = process.env.API_KEY;
//https://starknet-sepolia.public.blastapi.io
const provider = new RpcProvider({ nodeUrl: 'https://starknet-sepolia.g.alchemy.com/v2/' + ApiKey });

const accountAddress = '0x067981c7F9f55BCbdD4e0d0a9C5BBCeA77dAcB42cccbf13554A847d6353F728e';

const account = new Account(provider, accountAddress, privateKey, "1");

const compiledContractAbi = json.parse(
    fs.readFileSync('./abi.json').toString('ascii')
);

const contractAddress = '0x01bb7d67375782ab08178b444dbda2b0c1c9ff4469c421124f54e1d8257f2e97';
const storageContract = new Contract(compiledContractAbi.abi, contractAddress, provider);

storageContract.connect(account);

const getData = await storageContract.get();
console.log('Stored_data before set():', getData.toString());

const myCall = storageContract.populate('set', [15]);
const res = await storageContract.set(myCall.calldata);
await provider.waitForTransaction(res.transaction_hash);

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Browser & version [e.g. chrome, safari, webworker]
Node version: v22.1.0
Starknet.js version: 5.24.3
Network: Sepolia Testnet

Additional context
Add any other context about the problem here.

I fixed the problem. I was following along the Starknet-js documentation, and I found out that I needed to change the version to "Next" in the documentation. Then, I found out that rpc version was v0.6, so I bumped the Starknet-js version to 6.6.6. Then, the problem was fixed, and I could invoke a function in my contract.


dnf package resource version comparison failures, part 2

In PR #9847 I made a comment where I pointed out that we're still calling the broken versioncompare function with identical strings (so things were working by accident). Well, today someone asked me with an dnf resource :upgrade failure that I believe is being caused by these broken version comparison calls with non-equal strings. The resource in questions is:
package 'sudo' do
  action :upgrade
end

The currently installed rpm version is 0:1.8.29-6.el8, and the latest available version is 0:1.8.29-6.el8_3.1. Here's what we see in the chef debug logs:
INFO: Processing dnf_package[sudo] action upgrade (fbit_sudo::default line 35)
DEBUG: sending '{"action":"whatinstalled","provides":"sudo"}' to python helper
DEBUG: got 'sudo 0:1.8.29-6.el8 x86_64' from python helper
DEBUG: parsed sudo-0:1.8.29-6.el8.x86_64 from python helper
DEBUG: sending '{"action":"whatinstalled","provides":"sudo"}' to python helper
DEBUG: got 'sudo 0:1.8.29-6.el8 x86_64' from python helper
DEBUG: parsed sudo-0:1.8.29-6.el8.x86_64 from python helper
DEBUG: sending '{"action":"whatavailable","provides":"sudo"}' to python helper
DEBUG: got 'sudo 0:1.8.29-6.el8_3.1 x86_64' from python helper
DEBUG: parsed sudo-0:1.8.29-6.el8_3.1.x86_64 from python helper
DEBUG: sending '{"action":"versioncompare","versions":["0:1.8.29-6.el8.x86_64","0:1.8.29-6.el8_3.1.x86_64"]}' to python helper
DEBUG: got '0' from python helper
DEBUG: dnf_package[sudo] sudo 0:1.8.29-6.el8_3.1.x86_64 is already installed

In this case, since the EVRA parsing code in version_tuple() assumes that an architecture is always found after the first . after the first - in the version string the two version strings above will be parse to the same EVR tuple of (E = 0; V = 1.8.29; R = 6).

Looking at a chef run from a server, I also see we're still passing in EVRs and EVRAs into versioncompare, there by making it impossible know how to correctly parse the input (since we can't differentiate between the two). Here's a grep of log results removing EVRA to EVRA comparisons
# grep -a versioncompare chef.20210127.1815.1611800129.out | \
    sed -e 's/^.* sending //' | \
    egrep -v "\.x86_64.*\.x86_64|\.noarch.*\.noarch"
'{"action":"versioncompare","versions":["0:8.0p1-31.fb6.el8.x86_64","8.0p1-31.fb6.el8"]}' to python helper
'{"action":"versioncompare","versions":["0:8.0p1-31.fb6.el8.x86_64","8.0p1-31.fb6.el8"]}' to python helper
'{"action":"versioncompare","versions":["0:8.0p1-31.fb6.el8.x86_64","8.0p1-31.fb6.el8"]}' to python helper

Looking at a chef run from a server, I also see we're still passing in EVRs and EVRAs into versioncompare, there by making it impossible know how to correctly parse the input (since we can't differentiate between the two). Here's a grep of log results removing EVRA to EVRA comparisons
# grep -a versioncompare chef.20210127.1815.1611800129.out | \
    sed -e 's/^.* sending //' | \
    egrep -v "\.x86_64.*\.x86_64|\.noarch.*\.noarch"
'{"action":"versioncompare","versions":["0:8.0p1-31.fb6.el8.x86_64","8.0p1-31.fb6.el8"]}' to python helper
'{"action":"versioncompare","versions":["0:8.0p1-31.fb6.el8.x86_64","8.0p1-31.fb6.el8"]}' to python helper
'{"action":"versioncompare","versions":["0:8.0p1-31.fb6.el8.x86_64","8.0p1-31.fb6.el8"]}' to python helper

Fixed by #10951


Error when running pipeline for AppSource App with Preview template

I am currently using the preview template of the AppSource app AL Go, because of the local dev environment change. I am not sure what other changes are happening in there, but I am running in a new error, which happened only with this repo so far. The error is
Error: RunPipeline action failed. Error: An item with the specified name C:\github-01-1_work\repo\app\output already exists. Stacktrace: at , C:\github-01-1_work_actions\microsoft\AL-Go-Actions\preview\RunPipeline\runpipeline.ps1: line 229 at , C:\github-01-1_work_temp\1e0daef1-1c8c-4462-8dd7-a03b8481f69a.ps1: line 1 at , : line 1
Looking at the script, it fails at:
New-Item $buildArtifactFolder -ItemType Directory | Out-Null
The easiest fix would probably be to test, if it exists before creating it, but I don't know, if anything underlying is causing this different behavior.

Would it be possible to allow me read access to this repo so that I can have a look why this happens.
Thanks

I will change the folder to be named ".dependencies" - and will delete it after the run.
Also, I will add ,dependencies to .gitignore
Names like output should be allowed for people to use themselves - they should not be reserved,
Thanks again for reporting this.

This is fixed in the latest preview.

Please note this: https://freddysblog.com/2022/06/27/working-with-al-go-for-github-preview/
when working with preview versions.

Shipped in v2.0


add shortcuts for Upper and Lowercase functions on plugin/editor

I added shortcuts for the functionality on Plugins/editor
Now, I will work on Widget/sourcecode/codeeditor.py for add the logic.
In order to solve issue #1669 @goanpeca

@malliwi88 please remove all white space changes to this file, its very difficult to now what change if you added cosmetic changes in all the file

Closing, as this seems superseded by #3629.


Support system-installed yamlfmt

There is no need for the Go compiler to use a YAML formatting hook! Your tool could have already been installed in the system using various means. support -system like many other hooks.

Is there an example of a hook, either here or in some other source that has the pattern of support you want? You can make system-installed yamlfmt work with a locally defined system hook like this:
repos:
- repo: local
  hooks:
  - id: yamlfmt
    name: yamlfmt
    language: system
    entry: yamlfmt
    types: [yaml]

Maybe there is a way for a system hook to work from an actual pre commit repository, maybe by creating a mirror that tracks a build in source control, but if there is a way to make the hook in this repo work as a system hook I wasn't able to figure it out.

Here's the terraform-docs pre-commit hook, which supports 3 different methods of using/installing the binary: https://github.com/terraform-docs/terraform-docs/blob/master/.pre-commit-hooks.yaml
I understand I can create the hook myself, but it's always good to just source to your hook definition and just configure it locally.

I remembered the reason I didn't do this at the time. I wanted to submit it to the pre-commit.com website's list of supported hooks, but they will not accept system hooks to that list. I don't want to need to remove this repo from that list where I already put in the effort to get it added.
Best thing to do to get this functionality would probably be to create another repo to store a yamlfmt system hook rather than it living in this repo. If all a system hook in a GitHub repo does is assume that the binary is installed on the path, then realistically all the repo has to be is probably a .pre-commit-hooks.yaml with just this:
- id: yamlfmt
    name: yamlfmt
    language: system
    entry: yamlfmt
    types: [yaml]

Most likely that should be all that's required, given how the terraform-docs-system hook appears to work.

Okay. By the way, @braydonk, this is the error I get today (I'm on Go 1.21):
[INFO] Installing environment for https://github.com/google/yamlfmt.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/Users/[REDACTED]/.cache/pre-commit/repocme4j91k/golangenv-default/.go/bin/go', 'install', './...')
return code: 1
stdout: (none)
stderr:
    go: downloading github.com/mitchellh/mapstructure v1.5.0
    go: downloading github.com/braydonk/yaml v0.7.0
    go: downloading github.com/RageCage64/multilinediff v0.2.0
    go: downloading github.com/bmatcuk/doublestar/v4 v4.6.0
    go: downloading github.com/google/go-cmp v0.5.9
    error obtaining VCS status: exit status 128
    	Use -buildvcs=false to disable VCS stamping.
Check the log at /Users/[REDACTED]/.cache/pre-commit/pre-commit.log```

@braydonk I submitted a PR. Normally, the ID of the Go hook must have been yamlfmt-go, but this could break things for some, so, I didn't touch it.

The buildvcs failure seems to be an issue with precommit itself. I found someone was able to do this to resolve it.
I will open an issue in the pre commit dot com repo and ask if they will still accept a hook in their list if one of the hooks is system. If they are okay with that then I will accept the PR.

https://github.com/pre-commit/pre-commit.com/issues/888 confirms that I will not remain on the pre-commit.com supported hooks list if I add a system hook. In that issue, the pre-commit creator/maintainer suggests that you are able to use the yamlfmt hook but override your own settings locally to be system. I don't really know how that works, I'm not a pre-commit user myself. But if it works such that you can override the language to be system and provide an entrypoint, then I think it should work the way you're intending.
I will be closing this issue since I now know for sure that adding a system hook to this repo will mean I can't be on pre-commit.com.

You're wrong! First, you say you're not using pre-commit, but we do! Many hooks listed there also come with system language like terraform-docs, which I mention here, as an option.

https://github.com/terraform-docs/terraform-docs/blob/master/.pre-commit-hooks.yaml is not in https://pre-commit.com/hooks.html, which is the list that I am referring to. The maintainer of pre-commit has told me in https://github.com/pre-commit/pre-commit.com/issues/888 that system hooks aren't accepted to that list. Perhaps there are some that I'm not seeing in that list because they were added to the repo after being added to this list. But the general rule is that system hooks aren't supposed to be there. Since I want to be on that list, I will not add a system hook to this repo. A system hook for yamlfmt can be maintained somewhere other than this repo.

@braydonk Okay, my bad. The PR template also bans scripts, but the mentioned terraform_docs hook uses that extensively. You're operationalizing this. "Generally yes" and "Yes" in the response differ significantly in their meaning. If not, most hooks would have been long gone from that list!
And, honestly, which is more important to you: a) DX of your users or being listed in some repo nobody really cares about, which only serves vanity and has almost zero practical or marketing value?!

My understanding is that list is designed to be a list of supported hooks particularly for folks using pre-commit.ci. Maybe that's not exactly the point. But either way I would like to stay on that list. I had to do work to make sure I conformed to the rules of that list already. Just because others have snuck through with unsupported hooks doesn't mean I want to go now do the same thing when the maintainer has suggested that, generally, system hooks are not excepted (perhaps we fall under some exception, I am not sure if the "generally" there is carrying some extra context).
I tried the following to use the existing hook as a system hook:

Created a Debian 12 VM and installed pre-commit but not Go.
Create a temporary Git repository with one yaml file a.yaml that will definitely be changed by the yamlfmt hook due to being formatted different than defaults.

a:
 b: 1 # one space indent will be changed to 2 by default

Download the latest release of yamlfmt from Releases and put it in /usr/bin (or somewhere in the path).
Create a .pre-commit.config.yaml in the repo:

repos:
  - repo: https://github.com/google/yamlfmt
    rev: v0.10.0
    hooks:
      - id: yamlfmt
        language: system

Run pre-commit install
git add a.yaml
pre-commit run --all-files

braydonk@test-pre-commit:~/tmp$ pre-commit run -v --all-files
yamlfmt..................................................................Failed
- hook id: yamlfmt
- duration: 0.01s
- files were modified by this hook
braydonk@test-pre-commit:~/tmp$ git diff
diff --git a/a.yaml b/a.yaml
index 3092de1..28f410a 100644
--- a/a.yaml
+++ b/a.yaml
@@ -1,2 +1,2 @@
 a:
- b: 1
+  b: 1

As a result I was able to successfully use the yamlfmt hook from this repo and simply overrode it to use my system yamlfmt. This should pretty much accomplish the same thing as a separate system hook. I will document this in my pre-commit hook docs.

@braydonk Thanks! I didn't know it could be overridden. I didn't spend much time and only quickly browsed the hooks I've been using personally, but if I find a decent amount of other Git hooks in that official list, using system, will you reconsider the PR?

What does the additional hook get you that the override doesn't?

@braydonk Let's be honest here - it's a hack.

I think it's a pretty reasonable solution. The only thing that actually changes between a system yamlfmt hook and a go yamlfmt hook is the language. The other settings, such as entry and file types are all the same. So it's the difference between having an actual hook called yamlfmt_system and using the yamlfmt hook along with language: system. I'm not seeing the value of it being a separate hook when the functionality is identical unless I'm missing something.


Failed to start nameserver on port 53

Hello,
when i run evilginx2 with the ./main an error message appears "can not start the name server on port 53" and another one with "listen tcp: 443: bind: permission denied" do you know what it is is of ?
thank you for answering me if you can

Run as sudo

Thank you for the big work @kgretzky !
I have the same issue displaying :
[!!!] Failed to start nameserver on port 53
Even being Root. I searched a service listening on port 53 but the only one is 'systemd-resolved' in charge of ... DNS
Am I wrong somewhere ?


Issue with python module not loading when formatting any filetype

Error detected while processing function <SNR>15_TryAllFormatters..<SNR>15_TryFormatterPython:
line   26:
E887: Sorry, this command is disabled, the Python's site module could not be loaded.

I need some more information, as I do not experience this problem myself. I assume you get this when running :Autoformat, is that correct? Any other details?
What is your vim version (vim --version)?
Is vim-autoformat up-to-date? Which OS do you run?

Sorry about that, here are some more details
7.4.712
:Autoformat
OS X Yosemite (10.10)
Autoformat should be up to date, just updated again with Vundle just to make sure.

Do you have vim with builtin python support? Which version?
What python version do you run on your OSX system?

Python 2.7.10
Python 3.4.3
This is what shows plugin support yes?:
+python
-python3

Sorry, accidentally closed it.

It is probably the same issue as is raised here: https://github.com/powerline/powerline/issues/1385 (please confirm).
This cannot be fixed in vim-autoformat. A possibility is to downgrade to python 2.7.9. or follow some worksarounds named in the referenced issue.

Those workarounds don't seem to fix it for me, I'm guessing this bug lies on their end though and not yours.

I have run into this same issue. Here's how I fixed in case it helps anyone.
I use pyenv to manage multiple python versions. I had build vim with python support, and then months later, installed a new release of python with pyenv. After I had migrated to the newer python, I deleted the old instance, which caused this issue.
I guess I could have reinstall the old python, but I instead chose to rebuild a newer vim with the new Python.
In any event, this is not an issue with AutoFormat.


add how to use guide

Hi, can you please basic guide that how to use this library?
I was getting the following error irrespective of whatever command I run:
Uncaught Error: Request error | Code 404 | Message Not Found

How I tried to run it:
const VLC = require("vlc-client");

const vlc = new VLC.Client({
    ip: "localhost",
    port: 8080,
    username: "steve_aoki", //username is optional
    password: "edm"
});

await vlc.playFile("<path_to_the_file>");

The very last line throws the above error.

Hi, can you please basic guide that how to use this library? I was getting the following error irrespective of whatever command I run:
Uncaught Error: Request error | Code 404 | Message Not Found

How I tried to run it:
const VLC = require("vlc-client");

const vlc = new VLC.Client({
    ip: "localhost",
    port: 8080,
    username: "steve_aoki", //username is optional
    password: "edm"
});

await vlc.playFile("<path_to_the_file>");

The very last line throws the above error.

Are you already serving the VLC HTTP server?

Are you already serving the VLC HTTP server?

Yeah, I got the idea that what we need to do after checking out your tests. Got the idea that how to start VLC HTTP server using other libraries.


Chrome DevTools not showing network activity anymore

Environment
"@nativescript/angular": "^15.2.0",
"nativescript": "8.5.3",
"@nativescript/android": "8.5.1",
"@nativescript/core": "8.5.9"

Describe the bug
No network activity data is shown in the chrome devtools
To Reproduce
run nativescript app in debug mode with ns debug android --no-hmr --bundle
Expected behavior
Network activity to be recorded when opening chrome DevTool
EDIT: For anyone experiencing the same issue, intercepting traffic with HTTP Toolkit works as a workaround

@13dante04 As of<EMAIL_ADDRESS>the network tab doesn't work. This is currently being worked on, in the latest version of ios it is working.
If it is required to see the calls in android, and you can't check it in ios, download the android version to 8.4.0 as<EMAIL_ADDRESS>

any update?

This along with other dev tools updates like profiler improvements is set for 8.7 in Q1.


Luis Entity Resolution Data format

In Microsoft.Bot.Builder.Resolution.cs
public sealed class ResolutionParser : IResolutionParser
{
    bool IResolutionParser.TryParse(IDictionary<string, string> properties, out Resolution resolution)
    {
        string resolution_type;
        if (properties != null)
        {
            if (properties.TryGetValue("resolution_type", out resolution_type))

The last line of this code won't work because, in the current Luis output json, resolution_type is not part of the resolution dictionary object. Instead, it is stored as the "type" property on EntityRecommendation.
See example:
{
"entity": "tomorrow",
"type": "builtin.datetime.date",
"startIndex": 51,
"endIndex": 58,
"resolution": {
"date": "2016-12-07"
}
}
So the fix should be changing the input parameter from IDictionary to  EntityRecommendation.
I can create a pull request for this change, but I want to ask the team first to confirm if this is correct.

Is this the V2 version of the API?

Yes. It is V2.0.  https://api.projectoxford.ai/luis/v2.0/apps/....

I see the same thing. The dictionary it's trying to parse contains this for a date time entity (at my end at least):
{[date, 2017-01-21]}
I concur with @miaosenwang that the EntityRecommendation should be passed in for checking the resolution type.

When fetching this url:
https://api.projectoxford.ai/luis/v2.0/apps/c413b2ef-382c-45bd-8ff0-f76d60e2a821?subscription-key=6d0966209c6e4f6b835ce34492f3e6d9&q=can you set an alarm for 10 am
This is the response I see:
{
  "query": "can you set an alarm for 10 am",
  "intents": [
    {
      "intent": "builtin.intent.alarm.set_alarm"
    }
  ],
  "entities": [
    {
      "entity": "10 am",
      "type": "builtin.alarm.start_time",
      "resolution": {
        "resolution_type": "builtin.datetime.time",
        "time": "T10"
      }
    }
  ]
}

Based on this json, it looks like the existing code is correct (look at resolution_type instead of entity type, particularly since entity type is alarm-model specific).  Can you explain further?

Strange, you're right. I'm seeing the same directly calling the URL. Will investigate further and get back on this, this is not what I was seeing in my debug session.

Did some more research, not sure whats going on here. When I sent a query to the LUIS app I am using, I'm getting this in response:
URL: /luis/v2.0/apps/<>?subscription-key=<>&q=i%20want%20to%20book%20a%20holiday%20from%20today%20to%20tomorrow
{   "query": "i want to book a holiday from today to tomorrow",   "topScoringIntent": {     "intent": "LeaveRequest",     "score": 0.979348958   },   "entities": [     {       "entity": "today",       "type": "builtin.datetime.date",       "startIndex": 30,       "endIndex": 34,       "resolution": {         "date": "2017-01-26"       }     },     {       "entity": "tomorrow",       "type": "builtin.datetime.date",       "startIndex": 39,       "endIndex": 46,       "resolution": {         "date": "2017-01-27"       }     }   ] }
Note how there is no 'resolution_type' key in the resolution dictionary and so the ResolutionParser routine fails.
I expect this might be due to changes in LUIS. If I recall correctly one of the previous versions allowed you to rename a prebuilt entity. This is not possible in the UI any more (at least I can't find it). I'm guessing your LUIS app is based on such a definition where the "builtin.alarm.start_time" is a custom label and "builtin.datetime.time" is the prebuilt entity.
This invalidates my PR since the above won't be handled correctly.

I think we need the Luis team to comment on what is going on here

@miaosenwang Is this still a problem for you or has the issue been resolved?

@jameslew Any thoughts?

As far as I can read in LUIS official docs, the json format DOES NOT include "resolution_type" key inside "resolution -> values" object
https://docs.microsoft.com/en-us/azure/cognitive-services/luis/pre-builtentities


fix broken logo url in the readme page

Thank you :+1: I'm a bit behind on my todo list...

Actually looking at it - all the hashids repos have this logo issue :-1:  - and from the google cache I think its meant to be the test "hashids" and not the green round avatar...

Yep yep, the website used to be hosted on AWS S3, (not Github as it is now) and when I moved I forgot I had linked the logo to S3's now defunct bucket. Just gotta pick the right time, and update all. Thanks for the nudge, gets my butt moving faster... Will fix all sooner.

No worries - we all have todo lists longer than hours in the day :) just saw a quick win but on deeper scratching there appears to be a rabbit hole Im not getting sucked into - this time :) :)

Haha, that's funny. Pushed it up on my rabbit hole todo list :]


Doc for Data.StrMap.ST.Unsafe.unsafeGet is wrong

Looks like a copy/paste error from unsafeIndex.

This was fixed by #47, so we can close this.


[DELTASPIKE-1160] Enable other Entity types as return from native repository queries

At the moment native queries can only return the same entity type as of the repository.
A special flag exist on the @Query annotation to disable mapping, this enables the possibility to return unmapped types as String, Date or Integer.
This change uses the return type of the method with the @Query annotation.
If the type is java.util.List, it uses the generic type.
It should be checked if this behaviour is correct for all JPA providers and if some special logging is needed.
This change also removes the flag from @Query, I don't know if you want to retain it for backward compatibility reasons and mark it as deprecated.

Looks good to me.  If no one else gets to it, I'll merge this evening (EDT).  Thanks for the contrib!

Hi Danny,
Just ran your changes against wildfly 10.  Its failing for:
Tests in error:
  should_query_names(org.apache.deltaspike.data.impl.handler.EntityRepositoryHandlerTest): org.hibernate.MappingException: Unknown entity: java.lang.String

I think this is the difference between the original patch and the new changes.  I think the spec expects the class passed in to be an entity for a typed query.  By not using a typed query, it uses fallback logic to plain JDBC column mapping.

ah ok, I think one can check if the return type is a registered entity type with the entitymanager.
I will try this tomorrow.

Hi,
I think everything should be fine now with the code (tested it on wildfly 10 & used eclipse formatter).
A quick question about constributing. Should I upload a patch file to Jira or can you merge the changes directly from GitHub to the ASF repository?

Done, didn't notice that this was such recent code

Also, regarding your question, I'm fine with pulling the branch from GH into our repo.

Both TomEE 7 and Wildfly 10 fail on this test:
TomEE:
should_query_names(org.apache.deltaspike.data.impl.handler.EntityRepositoryHandlerTest): Column not found: 0

Wildfly:
should_query_names(org.apache.deltaspike.data.impl.handler.EntityRepositoryHandlerTest): org.hibernate.exception.SQLGrammarException: could not execute query

Hi,
I removed some formatting changes I commited from code I didn't touch. I also finally removed the  now unused Query paremter (forgot that).
On the point of failed tests. I'm sorry, but I can't reproduce them. I have run the following builds in './deltaspike/modules/data/impl':

mvn clean test -P wildfly-build-managed -Dwildfly.version=10.0.0.Final

mvn clean test -P tomee-build-managed

and both are successfull

Hi,
I removed some formatting changes I commited from code I didn't touch. I also finally removed the  now unused Query paramter (forgot that).
On the point of failed tests. I'm sorry, but I can't reproduce them. I have run the following builds in './deltaspike/modules/data/impl':

mvn clean test -P wildfly-build-managed -Dwildfly.version=10.0.0.Final

mvn clean test -P tomee7-build-managed

and both are successfull

I'm not sure what happened, but its passing locally now, and I didn't see anything wrong explaining why it would fail.  I've merged in, but had to rebase so if you wouldn't mind closing this PR.  Thanks for the contribution!


load function not running when changing searchparams via goto

Describe the bug
When changing the searchparams via links, the load function runs on each change.
If the parameter is changed via goto only the first goto triggers the load.
As a workaround, I could call invalidate manually.
Reproduction
https://codesandbox.io/p/sandbox/charming-einstein-yvkztt

click on each link is working fine
if switching page via button only the first button click triggers page load

Logs
No response
System Info
System:
    OS: Linux 5.15 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
    CPU: (2) x64 AMD EPYC
    Memory: 555.15 MB / 1.63 GB
    Container: Yes
    Shell: 5.1.4 - /bin/bash
  Binaries:
    Node: 16.17.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.15.0 - /usr/local/bin/npm
    Watchman: 20220528.183901.0 - /usr/local/bin/watchman
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.87
    @sveltejs/kit: next => 1.0.0-next.541
    svelte: ^3.46.0 => 3.53.1
    vite: ^3.1.0 => 3.2.3

Severity
annoyance
Additional Information
No response

Changing $page.url then calling goto() seems to exhibit buggy behaviour.
It works as expected if you simply call goto() without modifying the page store.
// calling goto() will change the $page.url.searchParams for you
await goto(`?page=${pageNumber}`);

Working example below:
https://stackblitz.com/edit/sveltejs-kit-template-default-c7qtfl?file=src/routes/+page.svelte
I'm wondering why $page.url isn't read-only, and if it is meant to be modifiable, why doesn't sveltekit sync those changes with the browser address bar?

Changing $page.url then calling goto() seems to exhibit buggy behaviour. It works as expected if you simply call goto() without modifying the page store.
// calling goto() will change the $page.url.searchParams for you
await goto(`?page=${pageNumber}`);

Working example below: https://stackblitz.com/edit/sveltejs-kit-template-default-c7qtfl?file=src/routes/+page.svelte
I'm wondering why $page.url isn't read-only, and if it is meant to be modifiable, why doesn't sveltekit sync those changes with the browser address bar?

Actually, I am not setting the store, I set the searchParams.
https://developer.mozilla.org/en-US/docs/Web/API/URL/searchParams

$page.url should be seen as readonly, so changing it should have no effects. Creating a readonly-version of the built-in URL object sounds cumbersome and would add needless bytes to the resulting bundle. I'm therefore inclined to close this.
Alternatives:

some kind of dev-time only check that the setter methods aren't called

I don't understand, is this a bad practice ?
// https://blabla.com?page=2
// +page.svelte

const addParams = (num) => {
   const newUrl = new URL($page.url);
   newUrl.searchParams.set(other, 'hello');
   goto(newUrl);
}

<button on:click={() => addParams()} />

I expected to go to https://blabla.com?page=2&other=hello but it's not the case

Mea culpa, it was a bug in my code ! Sorry for the confusion.


Implement Patron

Patron has a major sheet mechanic: you can select any number of other Character Perks (that don't require Patron) and gain them at a -1 CP discount.
This should probably be a "discount slot" that allows a perk to be purchased at lower cost, with unlimited perk entries, and excluding perks with the tag "no-patron". Should take a survey of other things that need slots before designing. This includes things like:
Classes: Often have "choose one of these subfeatures at 2nd level" mechanic
Skills: Extended Capacity has an "add an arcane OR divine spell at each rank" mechanic that might best be served by slots that can hold subfeatures.
Since slots can have a variety of different mechanics, it may be worthwhile to allow slot definitions to specify a controller class individually, or at least have a "slot type" selector.

A relatively recent addition to this perk is that it's limited to 10 CP worth of discounts. Update the perk to account for this.


Fix NavigationContainer ref type

Hello.
Looks like  NavigationContainer ref has NavigationContainerRef  type: packages/native/src/NavigationContainer.tsx#L47
These changes will make it possible to use navigation without navigation prop.

@MoOx  @Freddy03h any updates? :)

@MoOx  @Freddy03h any updates? :)

Sorry for the delay!
I've tried this change on my own codebase to test it and it look good, thanks!

Hi @MoOx ! I merged the PR because I've already approved it. What do you think about release a new version?

Published as 5.1.0 with rescript breaking changes!


st does not change background when compiled with transperancy

When compiled with the default pywal template for st, it changes background with the colorscheme as it should. When the template is changed as adviced in the third note of st customization, it only shows the background of the color-scheme in use during the initial compile.
Left terminal is pre-compile, and the right terminal is post-compile

The image above is before I change my color-scheme.

This one is after I change my color-scheme, you can notice that the background for the pre-compiled st is changed but the post-compiled is remaining the same.

This is most likely related to #445 and #446 as similar issues are presented there.


IP address alerts

The response shows "If IP do not exist - 404 Not Found." However, if the IP address is unknown but valid, it will return an empty set. If the IP address is invalid, e.g. 256.x.x.x, it will return HTTP 400.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6acd9b19-5308-1fb5-9e40-8d7d94e3b16f
Version Independent ID: 1a2508f0-8038-9ace-1dd9-c9923ec35130
Content: Get IP related alerts API
Content Source: microsoft-365/security/defender-endpoint/get-ip-related-alerts.md
Product: m365-security
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@MastaDisasta Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/5972
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @MastaDisasta Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Integrate Acute widget on website

DanF put this widget together that we could add to the website https://metamask.github.io/feedback/

This was proposed as a way to gather feedback from our userbase. Since this was proposed, we launched the community forum. The community forum serves this purpose for us today, so we can close this.


Great work but not elegant

love the project except the fact that is 100 times less elegant than inspinia theme. Am I the only one to have this review ?

Hey @amineparis, I would agree with @Tashaa78, this project is OS and we can make it as elegant as we need together :)

Close as out of date

Closed as out of date


Take a look at coqui

Apparently, coqui is, like, the thing nowadays—it's worth a look

Like, the frog? https://en.wikipedia.org/wiki/Coquí


MultilineOperationIndentation cop broken?

I'm on 0.46.0 version and I have configured:
Style/MultilineOperationIndentation:
  EnforcedStyle: indented

Yet, when having this:
GalleryImage.where(account_id: current_account.id)
  .order(id: :desc)
  .paginate(page: params[:page], per_page: PER_PAGE)

It reports:
Align .order with .where
Align .paginate with .where

RuboCop version
$ bundle show rubocop
 /.bundle/gems/rubocop-0.46.0

Could I be missing something obvious here?

Either run Rubocop with --display-cop-names or put this in your .rubocop.yml:
AllCops:
  DisplayCopNames: true

That way you get much more helpful output:
Offenses:

test/test.rb:2:3: C: Style/MultilineMethodCallIndentation: Align .order with .where on line 1.
  .order(id: :desc)
  ^^^^^^
test/test.rb:3:3: C: Style/MultilineMethodCallIndentation: Align .paginate with .where on line 1.
  .paginate(page: params[:page], per_page: PER_PAGE)
  ^^^^^^^^^

All that to say: MultilineOperationIndentation != MultilineMethodCallIndentation

I'm closing this as a configuration issue.

thx @mikegee 🙇. Indeed config issue @bbatsov, my bad.


HDDS-3824: OM read requests should make SCM#refreshPipeline outside BUCKET_LOCK

What changes were proposed in this pull request?
Refresh pipeline info does a call to SCM and it can be moved outside the BUCKET_LOCK, this would help to improve the performance of read/write mix workloads.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3824
How was this patch tested?
Using TestOzoneFileSystem unit test cases.

Codecov Report

Merging #1164 into master will decrease coverage by 0.13%.
The diff coverage is 79.59%.

@@             Coverage Diff              @@
##             master    #1164      +/-   ##
============================================
- Coverage     73.50%   73.36%   -0.14%
+ Complexity    10031    10025       -6
============================================
  Files           973      974       +1
  Lines         49663    49721      +58
  Branches       4881     4896      +15
============================================
- Hits          36503    36477      -26
- Misses        10846    10914      +68
- Partials       2314     2330      +16

Impacted Files
Coverage Δ
Complexity Δ

...ava/org/apache/hadoop/ozone/om/KeyManagerImpl.java
63.96% <79.59%> (-0.38%)
128.00 <7.00> (+3.00)
:arrow_down:

...otocol/commands/RetriableDatanodeEventWatcher.java
55.55% <0.00%> (-44.45%)
3.00% <0.00%> (-1.00%)

...hdds/scm/container/CloseContainerEventHandler.java
72.41% <0.00%> (-17.25%)
6.00% <0.00%> (ø%)

...hdds/scm/container/common/helpers/ExcludeList.java
86.95% <0.00%> (-13.05%)
19.00% <0.00%> (-3.00%)

...ozone/container/ozoneimpl/ContainerController.java
63.15% <0.00%> (-10.53%)
11.00% <0.00%> (-2.00%)

...ache/hadoop/ozone/om/codec/S3SecretValueCodec.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (-1.00%)

...e/hadoop/ozone/recon/tasks/OMUpdateEventBatch.java
75.00% <0.00%> (-8.34%)
6.00% <0.00%> (-1.00%)

.../transport/server/ratis/ContainerStateMachine.java
71.52% <0.00%> (-5.39%)
63.00% <0.00%> (-4.00%)

.../common/volume/RoundRobinVolumeChoosingPolicy.java
80.95% <0.00%> (-4.77%)
5.00% <0.00%> (-1.00%)

...apache/hadoop/hdds/server/events/EventWatcher.java
77.77% <0.00%> (-4.17%)
14.00% <0.00%> (ø%)

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eebf2f...3547106. Read the comment docs.

@xiaoyuyao @bharatviswa504,
Please review the updated changes when you get a chance. Thanks!

Thanks @xiaoyuyao for the comments. I have updated PR, kindly review it again.

Note:- TestWatchForCommit#test2WayCommitForTimeoutException failure is unrelated to my changes. It is passing in my local env.

Thanks @xiaoyuyao and @bharatviswa504  for the reviews and committing the PR.


Context menu display issue  in Mozilla Firefox

Hello myliang,
In Mozilla Firefox context menu will open on right click but close quickly without allow to select options. I am not able to select context menu options in Mozilla Firefox. Please help me solve this. My Mozilla Firefox version is 66.

i don't have this problem in Mozilla firefox(60.0.1)

Yes this issue is display in Firefox version above 65.

Hello myliang,
In Mozilla Firefox context menu will open on right click but close quickly without allow to select options. I am not able to select context menu options in Mozilla Firefox. Please help me solve this. My Mozilla Firefox version is 66.

update version to 1.0.11


add nyc and test:coverage, remove (unused?) test1

This gives us a command to check test coverage, as a step toward improving coverage. It also removes the test1 script. Looking at the commit history, I'm not clear why test1 was originally added, so using this PR to at least clarify that, if not remove it.

To remove test1 but retain the functionality, we could create a file test/mocha.opts with just
--recursive

and then you should be able to run one file using npm test -- path/to/file.js, which appends the argument

Thats fine for me. Can we document that in readme or contributing -- wherever appropriate

or actually we don't even need mocha.opts, we could just put --recursive on the test script (because looking into the /test dir is the default

Pushed my suggested changes


Plugin resetting API Key Source to HEADER

I'm using this plugin with an shared API Gateway and it resets the config of API Key Source back to HEADER
Main serverless.yml which defines and exports the root API:
provider:
  name: aws
  runtime: nodejs8.10
  stage: ${self:custom.config.env}
  region: ${opt:region, '${self:custom.config.region}'}
  stackName: ${self:service.name}-${self:custom.config.env}
  apiName: piximizer-${self:custom.config.env}
  endpointType: regional
  timeout: 30
  memorySize: 256
  versionFunctions: false
  logRetentionInDays: ${self:custom.logRetention.${self:custom.config.env}}
  role: { Fn::GetAtt: [ RoleDefault, Arn ] }
  apiGateway:
    apiKeySourceType: AUTHORIZER

resources:
  Outputs:
    apiGatewayRestApiId:
      Value: { Ref: ApiGatewayRestApi }

    apiGatewayRestApiRootResourceId:
      Value: { Fn::GetAtt: [ ApiGatewayRestApi, RootResourceId ] }

Deploying this one sets the API Key Source correctly to AUTHORIZER
The next service which uses serverless-apigw-binary:
plugins:
- serverless-apigw-binary

custom:
  apigwBinary:
    types:
    - 'image/jpeg'
    - 'image/png'
    - 'image/webp'

provider:
  name: aws
  runtime: nodejs8.10
  stage: ${self:custom.config.env}
  region: ${opt:region, '${self:custom.config.region}'}
  stackName: ${self:service.name}-${self:custom.config.env}
  apiName: piximizer-${self:custom.config.env}
  endpointType: regional
  timeout: 30
  memorySize: 256
  versionFunctions: false
  logRetentionInDays: ${self:custom.logRetention.${self:custom.config.env}}
  role: ${cf:piximizer-tenants-${self:custom.config.env}.roleDefaultArn}

  apiGateway:
    restApiId: ${cf:piximizer-tenants-${self:custom.config.env}.apiGatewayRestApiId}
    restApiRootResourceId: ${cf:piximizer-tenants-${self:custom.config.env}.apiGatewayRestApiRootResourceId}

When I deploy this one, the API Key Source is back to HEADER. Other services which share the same API Gateway don't have this behavior. Only with this plugin.

So I played a bit, and before issuing the putRestApi i validated it with a getRestApi call:
Response { id: 'xxxx',
  name: 'piximizer-dev',
  createdDate: 2018-07-04T07:42:50.000Z,
  binaryMediaTypes: [ 'image/jpeg', 'image/png', 'image/webp' ],
  apiKeySource: 'AUTHORIZER',
  endpointConfiguration: { types: [ 'REGIONAL' ] } }

The plugin sends the following config to AWS:
Swagger {"swagger":"2.0","info":{"title":"piximizer-dev"},"x-amazon-apigateway-binary-media-types":["image/jpeg","image/png","image/webp"]}

And AWS definitely sets the API Key Source back to HEADER when it is missing in the Swagger input...
Result { id: 'xxxx',
  name: 'piximizer-dev',
  createdDate: 2018-07-04T07:42:50.000Z,
  warnings: [ 'No paths defined for this API.' ],
  binaryMediaTypes: [ 'image/jpeg', 'image/png', 'image/webp' ],
  apiKeySource: 'HEADER',
  endpointConfiguration: { types: [ 'REGIONAL' ] } }

To clarify this issue, this may happen independently if used in a shared gateway scenario or not.


Add masked_fill under Tensor

This unifies the masked_fill implementations under Tensor.
Addresses #2370 .

I'm not sure we want to have this under Tensor, the goal there is not to replicate all the functions in pytorch but rather have a smaller subset of basic functions. Maybe put it in candle-transformers/src/utils.rs instead.
Also note that the tensor pre-allocation for some of the models was done on purpose as it avoids a sync point on cuda which was a problem for performance so we would want to keep the current implementation for these.

@LaurentMazare thanks for the comments. I will update the PR accordingly.


ThemePackage.getStylesheetsPath is deprecated.

Store package style sheets in the styles/ directory instead of stylesheets/ in the atom-soda-dark-ui package
ThemePackage.getStylesheetsPath (C:\Users\jmoakley\AppData\Local\atom\app-0.205.0\resources\app.asar\src\package.js:458:9)
ThemePackage.getStylesheetPaths (C:\Users\jmoakley\AppData\Local\atom\app-0.205.0\resources\app.asar\src\package.js:469:32)
ThemePackage.loadStylesheets (C:\Users\jmoakley\AppData\Local\atom\app-0.205.0\resources\app.asar\src\package.js:451:38)
<unknown> (C:\Users\jmoakley\AppData\Local\atom\app-0.205.0\resources\app.asar\src\theme-package.js:47:19)
ThemePackage.measure (C:\Users\jmoakley\AppData\Local\atom\app-0.205.0\resources\app.asar\src\package.js:163:15)
ThemePackage.activate (C:\Users\jmoakley\AppData\Local\atom\app-0.205.0\resources\app.asar\src\theme-package.js:43:12)

+1

:+1:

Hey guys, haven't had much time to maintain this unfortunately. Would love a PR!

Would this be alright? (check the last 3 commits)
If so, I'll submit a pull request.
I've got no means of testing my changes currently. :disappointed:

Looks good to me.

Check out #20.


DownloadId

My downloadId = -1 what is the reason please help me asap .
Fetch fetch = Fetch.getInstance(MainActivity.this);
Request request = new Request("http://androhub.com/demo/demo.mp4", Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS).toString();

final long downloadId = fetch.enqueue(request);

fetch.addFetchListener(new FetchListener() {
            @Override
            public void onUpdate(long id, int status, int progress, int error) {
                if(downloadId== id){
                    progressDialog.setProgress(progress);
                    Log.d("TAG",String.valueOf(progress));
                    if(progress>=100){
                        progressDialog.dismiss();
                    }
                }

            }
});

//Log.d("TAG",fetch.getFilePath(downloadId).toString());
fetch.release();

The reasons why you may be getting an ID of -1 when enqueuing could be the following:

Fetch could not enqueue your request because the device ran out of space.
Fetch already contains this request. A request with the same downloaded file path already exist and is managed by Fetch. Fetch does not override local files.
The file you want to download/enqueue is already located in the directory you wish to save it in.

For the example you provided above, you seem to be creating multiple requests with the same destination file path which is actually a directory and not a unique file. Each new request should have a unique file path.Your request should be similar to the following.
String url = "http://androhub.com/demo/demo.mp4";
String filePath = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS).toString()
+ "/demo.mp4";

Request request = new Request(url,filePath);
long download id = fetch.enqueue(request);

A great way to generate unique file paths is to add the date or time to the file name/path.
String dateString = new Date().toString();

String filePath = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS).toString()
+ "/" + dateString + "_demo.mp4";

OK got it , but how can I check if the file already exists or not ?
On Feb 16, 2017 10:15 PM, "Tonyo Francis"<EMAIL_ADDRESS>wrote:
The reasons why you may be getting an ID of -1 when enqueuing could be the
following:

Fetch could not enqueue your request because the device ran out of
space.
Fetch already contains this request. A request with the same
downloaded file path already exist and is managed by Fetch. Fetch does
not override local files.
The file you want to download/enqueue is already located in the
directory you wish to save it in.

For the example you provided above, you seem to be creating multiple
requests with the same destination file path which is actually a directory
and not a unique file. Each new request should have a unique file path.Your
request should be similar to the following.
String url = "http://androhub.com/demo/demo.mp4";
String filePath =
Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS).toString()

"/demo.mp4";

Request request = new Request(url,filePath);
long download id = fetch.enqueue(request);
A great way to generate unique file paths is to add the date or time to the
file name/path.
String dateString = new Date().toString();
String filePath =
Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS).toString()

"/" + dateString + "_demo.mp4";

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tonyofrancis/Fetch/issues/3#issuecomment-280395654,
or mute
the thread
https://github.com/notifications/unsubscribe-auth/ASVSa1DAyQ_yPxVk-7e17p5apdS4UJolks5rdIQbgaJpZM4MDJHb
.


req.body has set body as property

Hi,
i send a post with
fetch(url, {
            method: 'POST',
            mode: 'no-cors',
            redirect: 'follow',
            body: JSON.stringify({ hello:"world" }),
            headers: new Headers({
                'Content-Type': 'application/x-www-form-urlencoded',
                Accept: 'application/json',
            })
        })

to my (express) server:
 this.express.post(Routes.Login, (req, res, next) => {
            let request = req.body;
            console.log(request)
            res.sendStatus(200);

and console.log show this result

{ '{"hello":"world"}': '' }

the stringified object { hello:"world" } is a property of req.body.
Is this a bug, or what I am doing wrong?
Thx

It's been a while since I used express but what you've described doesn't seem unexpected to me.  What did you expect to happen in this case?


Internal Diamond proxy cleanup

Refactoring + comments

I don't know whether "slug" is the right terminology.

Looks good. Fully support the name changes and additional comments. Nice one.


show plus/minus signs for begin and end balance in Tx PDF export

Begin and end balance cannot be a negative number.


docs: add missing instrumentation-long-task to readme

Short description of the changes

Added missing instrumentation-long-task to Readme file

Closing this pr, adding the change to https://github.com/open-telemetry/opentelemetry-js-contrib/pull/827


Datamodel refactor

This PR incorporates changes to the data model as discussed in the last PyEED sprint meeting and closes #15.
Additionally, the performance for retrieving GeneBank entries was improved.


JSONDecodeError with shap and Flask

Environment info
Operating System: macOS Catalina 10.15.3
Python version: 3.8.1
LightGBM version or commit hash: 2.3.0
Error message
I am building an app on Flask to visualise the results of a LightGBM model and shap explainers computed in backend, with the following code:
self.model = LGBMRegressor() if self.task == 'regression' else LGBMClassifier()
...
X_train, X_test, y_train, y_test = data.split()
self.model.fit(X_train, y_train)
explainer = shap.TreeExplainer(self.model)
shap_values = explainer.shap_values(X_train)

While the standalone backend script works perfectly with the same data, it throws a JSONDecodeError when it is running within my Flask application:
explainer = shap.TreeExplainer(self.model)
  File "/Users/roberta/miniconda3/envs/app/lib/python3.8/site-packages/shap/explainers/tree.py", line 112, in __init__
    self.model = TreeEnsemble(model, self.data, self.data_missing)
  File "/Users/roberta/miniconda3/envs/app/lib/python3.8/site-packages/shap/explainers/tree.py", line 720, in __init__
    tree_info = self.original_model.dump_model()["tree_info"]
  File "/Users/roberta/miniconda3/envs/app/lib/python3.8/site-packages/lightgbm/basic.py", line 2313, in dump_model
    ret = json.loads(string_buffer.value.decode())
  File "/Users/roberta/miniconda3/envs/app/lib/python3.8/json/__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "/Users/roberta/miniconda3/envs/app/lib/python3.8/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/Users/roberta/miniconda3/envs/app/lib/python3.8/json/decoder.py", line 359, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 33 column 18 (char 1556)

This error is thrown when I run my Flask application (python app.py) on my Terminal. Curiously everything works fine if I run the Flask app on PyCharm terminal (within the same conda environment).
I compared the s parameter passed to raw_decode function where the error happens for both my Terminal and PyCharm. It seems that the error on the Terminal is due to some nan values:
 "leaf_index":13,

 "leaf_value":0.17676952844231311,

-"leaf_weight":nan,

+"leaf_weight":1.6563233849592498,

 "leaf_count":22

 },

 "right_child":{

 "leaf_index":17,

 "leaf_value":0.04893476889837476,

-"leaf_weight":nan,

+"leaf_weight":1.879201234318316,

 "leaf_count":20

...

Steps to reproduce

Create a simple Flask app, that receives some csv data files in the front-end.
In the backend, read the csv files and train a lightgbm model.
Use the shap explainer as follows:

explainer = shap.TreeExplainer(self.model)

shap_values = explainer.shap_values(X_train)

Any idea why I get this different behaviour on my Terminal + Flask?

I created again the conda environment and now it works.


Update Dockerfile

Change entry script call

Could you explain the rationale of this PR a bit?

@mergify backport humble rolling


Update zio-magic to 0.3.9

Updates io.github.kitlangton:zio-magic from 0.2.6 to 0.3.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.github.kitlangton", artifactId = "zio-magic" } ]

labels: library-update, semver-minor

Superseded by #57.


Anyone willing to share their detection setups that work well for HKSV?

Like some other users, I find that HKSV detection doesn't catch all the events that the native Wyze app does and I'm wondering if there are settings that seem to work well.  I've messed around in the Camera/VideoAnalysis with dwell time, sensitivity, and pixel/color difference but I can't seem to find the right settings.  Currently mine are:
Dwell Time: 60
Reset motion: 3
Sensitivity: 94
Pixel/color difference: 3
Thanks

I started playing with this just a few days ago. Still playing around with he setup but the HKSV works pretty well with the default settings. It seems to capture all motions, spitting out person, vehicle or occasionally a face recognition.
Dwell Time: 60
Reset motion: 3
Sensitivity: 75
Pixel/color difference: 5
I did notice that HKVS stopped working a few times. Once over night without touching the setup. I found that starting from scratch again was the best way get it working again. The first setup was on a RPI 3b which was clearly struggling on CPU. That caused camera.ui to miss motion completely. I'm now running on a Debian VM with Docker.
For my test I am using a single Hikvision 4K camera with the main stream reduced to HD (1920x1080). HKVS is set to Stream and Recording when at home or away. I'm highly surprised this works for me since my upload speed is close to nothing.
Overall I do experience choppy video recoding.

Played quite a bit with those settings and the best settings varies per camera type (i run two hikvision 4k cameras and a video doorbell)
For the two cameras high end cameras i have the following settings:
Dwell time: 75
Reset motion after: 0 (this works great, sometimes i missed some movement but i found out that the movement was overlapping and due to the reset timer some movement was not recorded by putting it on 0 the problem with missing movement is gone)
Sensitivity: 83 (not think that something went wrong in your settings if you see a recording with for example sensitivity 79, the number you give here is a maximum of sensitivity, it detects movement till 83 sensitivity and under that value, all above is not seen as "movement")
This setting is something to play with and simply works with trail and error.
Pixel/color difference: 4
To get a good speed of your streams check your camera settings directly at the ip of the camera, when you directly put it in that menu on h264 it will speed up the stream a lot because h264 is supported by homekit and it avoids complex decoding.
Put the following in front of your stream link helps also speeding up the stream (after of course performed the step above)
-rtsp_transport tcp -re -i rtsp://username:password@ipofcamera:554/Streaming/Channels/101/
Username:password - put here the username and password of the camera
Behind @ put the ip of the camera
After filling the missing information and using the links the stream should already been faster.


[Question] --keydump / -k no longer available?

It's mentioned in the nmail's github web page but not in nmail -h or man page.
I can get unused key codes by pressing an unused key and copying the error (ie Invalid input (0x109) when pressing F1). So not really a problem, just curious.

Indeed, I was on 3.89. I should adjust my github notifications, didn't receive any notice on updates. I've just updated, thank you for the fabulous TUI MTA!
On 2022-10-13 15:42 Kristofer Berggren @.***> wrote:

Which version of nmail to you have installed? The keydump
functionality was
added fairly recently in 2702be4 / v3.97 so I suspect you could be
running an older version.
--
Reply to this email directly or view it on GitHub:
https://github.com/d99kris/nmail/issues/113#issuecomment-1277549135
You are receiving this because you authored the thread.
Message ID: @.***>


Issue #1 - Allow user-provided custom themes via --theme flag

Changes Introduced

Adds support for defining theme in the header of a slideshow
Support for default,dark, and light themes
Adds theme header type and helper functions to read theme name but allow for more metadata if you'd like to add it later

The themes can be specified like this:
---
theme: "default"
---

---
theme: "dark"
---

---
theme: "light"
---

Adds support for issue https://github.com/maaslalani/slides/issues/1 with custom user themes

Hey! Thanks so much for contributing to slides. This looks good and I would be happy to add this to the project. However, one other way I was thinking (instead of a command line option) would be to have the config live directly inside the presentations.
For example:
---
theme: styles.json
---

# Slide 1
Stuff here

---

# Slide 2
More stuff here

This way we can keep the command line flags super minimal and lean towards placing the configuration inside the slides.md.
So that the user only needs to write
slides presentation.md

rather than:
slides --theme styles.json presentation.md

everytime.
What do you think?

I think that's a fun idea!
Another expansion onto that I feel like would be the ultimate is allow a minimal set of parameters for users to theme their slides directly in the markdown file.
You could leverage something sort of like Hugo frontmatter to specify your basic stuff at the head of the markdown file. That way people can exchange slides with a single markdown file and no need to share a separate theme.json.
Some references to that:

https://gohugo.io/content-management/front-matter/#front-matter-formats
https://github.com/gohugoio/hugo/blob/master/parser/frontmatter.go

Totally down to help pivot it whichever way you see fit though :smile:  This is your project! I'm just here to be a friendly passerby and help ya accomplish what you're lookin to do!

Ohhhh! Yeah, that could be great!
I think to start we can simply have the theme key as a config option:
We can simply forward this option to the glamour renderer that we use.
I believe glamour accepts any JSON file (path), as well as options like: ascii, dark, and light so we will also get those themes for free if we just pass the value along. By default we should use our theme.json.

I think it would be also dope to have a bunch of preset slide themes that users can submit and we can have them in this repo so that they come preloaded and users don't have to share the theme.json either.
---
theme: custom-user-theme.json
---

That might bloat the binary size, if we have too many though. So potentially a better solution would be to allow full URL links to json files that we could load on demand? Could be a fun idea:
---
theme: https://raw.githubusercontent.com/maaslalani/slides/main/styles/theme.json
---

theme: [filepath.json|ascii|light|dark]

Honestly, at the end of the day I think this is a great starting point and would serve most people's initial needs. Simpler to implement and lets people choose their flavor without having to think too hard about it.
Separate question: How are you breaking up each --- into a new page? I'm trying to find it in the repo but cannot for the life of me figure out where that is being performed. Since I'm assuming this is how we'd add the ability to parse the model from the "first page".

The action is here: https://github.com/maaslalani/slides/blob/main/cmd/root.go#L43
The delimiters are defined above. I assume we would check for if the document starts with a --- and consume until the next --- and assume that is all valid configuration, I'd suggest we don't fail too loudly if the configuration is invalid (since the user will probably be able to tell)

Alrighty, I've added support for the ability to specify the following themes in the front matter. I haven't made any changes to these theme.json files, since I figured you'd wanna be in control of the aesthetic :smile:.
Also, I didn't add the ability to specify a custom theme.json file since I wanted to get a feel for how you feel about this change before implementing that.
---
theme: "default"
---

---
theme: "dark"
---

---
theme: "light"
---

Nice this is looking great! Also we don't need to define theme_dark.json or theme_dark.json because these are already defined in https://github.com/charmbracelet/glamour/tree/master/styles/gallery and we can just pass the "dark", "light" string to glamour.

Updated the theme selector so now all of the following theme names are valid for Slides.
// SelectTheme picks a glamour style config based
// on the theme provided in the markdown header
func SelectTheme(theme string) ansi.StyleConfig {
	switch theme {
	case "ascii":
		return glamour.ASCIIStyleConfig
	case "light":
		return glamour.LightStyleConfig
	case "notty":
		return glamour.NoTTYStyleConfig
	default:
		return glamour.DarkStyleConfig
	}
}

This is looking super great! Coming together nicely!
So we have a couple options:

We can initialize the glamour renderer in the root.go and then store a reference to it in the model
We can also probably contribute this theme to glamour and then see what they say 😄 (this would probably be the cleanest option)
Since glamour can take a string for the path of a theme we can create a file in $HOME/.config/slides/theme.json and then the default behaviour would be for glamour to use this path and then a use could also simply write a different path for the theme

I kinda dig the idea of seeing if it could be added to the glamour set of themes but I'm not sure how long that would take to get a green light from them 🤔
The happiest path would be if the theme was defined as an ascii.StyleConfig or if you could load an ascii.StyleConfig from a filepath rather than only a termrenderer option. That way we could keep that super clean switch statement but also support custom themes from the file system.
Maybe that's a change worth adding to glamour??

Yea it would be nice to have the theme in glamour but I think it might not be good because if we ever want to update it, we will first need to update glamour, cut a glamour release, then update the dependencies in slides then cut a slides release. So maybe not the best option for now.
Personally, I think the best bet is to initialize the glamour renderer in root and store it in the model

I'm cool with that! Lemme take a crack at it real quick and let me know if looks like we're on the same page.

Alllrighty. You can now specify a theme with any of the following options, each of them should fall back to a default to prevent any nasty error messages.
---
theme: "default"
---

---
theme: "dark"
---

---
theme: "light"
---

---
theme: "somefolder/theme.json"
---

@maaslalani Sorry, just realized you made some changes on the main branch and I got confused :joy: I should really sleep more. I'll fix mine up so it doesn't conflict.

Themes! Let's go!

@brittonhayes Just confirming that if the user doesn't have a frontmatter config that the slides will still work right? I want to make sure everything is completely optional.

@brittonhayes Just confirming that if the user doesn't have a frontmatter config that the slides will still work right? I want to make sure everything is completely optional.

Good callout! Now it supports that! :smile: I added a couple tests to ensure this is the case.

If an user specifies no theme, it will default to your embedded DefaultTheme and treat the first slide as part of the slideshow.
If an user provides a custom theme, it will treat the first slide as frontmatter, apply their specified theme, and show slides[1:] for the slideshow.
If an user provides a custom theme but it isn't a valid theme name or a valid filepath, it will use the glamour.DarkStyleConfig, since that is set to the default for custom themes.

I'm just writing a couple more tests to cover some of the more unique use-cases to make sure I'm not incorrect here!

Those cases look correct to me. And thank you so so so much for writing tests! Makes me so happy to see tests haha, totally not necessary but very much appreciated ❤
I'll probably end up writing a full test suite and some point, which should be fun! 😄

Totally optional, but if you want to ship this github action https://github.com/maaslalani/slides/commit/cf7053ce1bca39650c65f290647180ed22cff6d1 as a separate PR with a dummy test would be happy to merge that quickly

Totally optional, but if you want to ship this github action cf7053c as a separate PR with a dummy test would be happy to merge that quickly

Yeah I can do that real quick!

@maaslalani Want me to push a dummy change here just to see if all the tests and lints pass for the hell of it?

If you rebase and force push it should do that

Uhhh woopssss. I definitely just messed up my rebase and didn't mean to close the PR :joy:

Oh no! Looks like a bad rebase or something. git reflog can hopefully help.

Uhhh woopssss. I definitely just messed up my rebase and didn't mean to close the PR :joy:

Yea haha I figured! 😂😂


Question about CAS platform dimensions/corrupted CAS

Hi! I wasn't sure where to post this question so I'm making an issue. We've been building exclusively with turbo-cache now for a few weeks and things mostly work great. We build a Chromium-based project with goma for Windows (cross on Linux workers) and Mac (on Mac workers), and sometimes attempt Mac cross builds on Linux (which works but has a non-RBE related issue). We build many very different versions based on the various upstream versions, several times a day.
After a while, builds will suddenly fail with linker errors, solved by wiping the CAS and doing a clean build. I was wondering if in the RBE spec there are enough 'dimensions' for what we're doing, or if we're meant to be running two RBE clusters?
Unfortunately there isn't a lot more debug info to go on at this point.

It sounds like there is some kind of corruption somewhere. If this happens, try wrapping the CAS store in a verify_store. This will see if there was some kind of upload/download/disk corruption.
If it is possible, I'd love to get in there and check it out, but not sure how realistic this is on your side. Feel free to reach out to me in email (see github user) and we might be able to negotiate a way to help resolve this.
(To clearly answer the question, no there should be absolutely no need to run two clusters, the digest hash naturally partitions the data)

@allada sounds good, let’s figure it out next week, I will drop you an email. Thanks!!


Qustion

is there a way to disable it on the phone application also?

With this filterlist no, online on the mobile website. If you use Android, you could use YouTube Revanced and apply the shorts filter.