Need some more implementation documentation on IFrameDialog

I cant seem to figure out how exactly to use the control following the specification in the documentation. I use it and i get promise errors with sp.dialog.js. I am using the control in the render as below and nothing pops up when its invoked and i cannot also use the property iframeOnLoad={this._onIframeLoaded.bind(this)} as it gives a compilation error for the {this._onIframeLoaded.bind(this)}. Do i have to explicitly implement the method ? Please clarify
public render(): JSX.Element {
        return (<IFrameDialog
            url={this.props.url}

            hidden = {false}
            modalProps={{
                isBlocking: true,
                containerClassName: "cs-dialog"
            }}
            dialogContentProps={{
                type: DialogType.close,
                showCloseButton: true
            }}
            width={'800px'}
            height={'800px'}/>);
        }

}

@AJIXuMuK can you help @kspranesh with this?

Hi @kspranesh
I've created a small sample for IFrameDialog here
There is an issue on how to reference the component from the library (I will fix it), but the component itself works as expected.
Regarding your concerns:

I use it and i get promise errors with sp.dialog.js sp.dialog.js is not used in IFrameDialog. Maybe these errors are posted from the page that you're opening in the iframe.
Do i have to explicitly implement the method?. Yes, you should implement this method. It's a handler to execute some code when the iframe's content is loaded. For example, you can access iframe page's HTML and change something there.

Here is a PR to address reference issue. It also adds IFrameDialog example to the web part we have in the project.

@AJIXuMuK can You please provide a string how You call IFrameDialog with different urls?.. For example I store links to display forms and want them opened as popups..
But
url={this.props.url}
as I understand - opens hard-coded property, but in my classic projects it was a function..
p.s.: sorry, I am newbie in React..
Best regards, Gennady


add preset for route=horse relations

Please add a preset for route=horse relations (Riding Routes = Reitrouten),
analogous to route=hiking (closed/merged issue https://github.com/openstreetmap/iD/pull/1785)-
The only difference seems to be that you need a new icon.
There are also different network values (ihn, nhn, rhn and lhn)
but this does not seem to be interesting to iD.
(Riding Routes were recently also added to JOSM,
see https://josm.openstreetmap.de/changeset/10086/josm
and https://josm.openstreetmap.de/changeset/10090/josm)

This was added in #3066

Thanks.
One question:
If I click on the 'i' right to "Riding Route" I only get the message

(The same happens with other route types (e.g. hiking, cycle).
What has to be done to let iD show some documentation or/and a link to the wiki page
(for Riding this would be http://wiki.openstreetmap.org/wiki/Tag:route=horse)?


Supports forced use of S3 virtual-hosted style

Add a configuration item to enable S3 virtual-hosted style (V2) to solve the problem caused by some S3 service providers not supporting path style (V1). #14991

Thanks for this PR! Could you also add the new config option to the docs (and app.ini example)? I'm on mobile, but if you need help finding where to add documentation for this please let me know and I can send a link when I'm at my computer:)

Okay, I added it to the documentation.

Unit test failure looks related:
--- FAIL: TestMinioStorageIterator (0.00s)
    storage_test.go:17:
        	Error Trace:	/home/runner/work/gitea/gitea/modules/storage/storage_test.go:17
        	            				/home/runner/work/gitea/gitea/modules/storage/minio_test.go:23
        	Error:      	Received unexpected error:
        	            	invalid minio bucket lookup type:
        	Test:       	TestMinioStorageIterator
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0xa1a441]

Ah, yeah that's my bad. getDefaultStorageSection doesn't do what I thought it did. It looks like instead it may be inside getStorageForMinio

https://github.com/go-gitea/gitea/blob/db578431ea5e8dc7347ba3dc10e82a01c5ba3ace/modules/storage/minio_test.go#L23-L30
It seems that the unit test directly assigns values to the minio configuration without going through the logic of assigning default values.


Edge functions for sign up, sing in and sign out

Basic implementation of the edge functions that are gonna be triggered when signing up/in/out
.env needed:
SUPABASE_URL =
SUPABASE_ANON_KEY =

I suggest changing the folder structure from ./supabase to ./backend/supabase as is implemented in ticket #37


Add iml-orm crate

Add a new crate iml-orm that can be used with
diesel to make working with the db much simpler.
The schema has been generated from the IML Db, and structs have been
generated to represent each table in the schema.
The model structs may be used in other contexts for example both the
iml-agent and iml-gui.
Signed-off-by: Joe Grund<EMAIL_ADDRESS>

What's the async story with Diesel?
I believe some time ago they wasn't async and weren't planning. Are we going to work with it via a thread pool?

What's the async story with Diesel?

They aren't async and there are some fundamental issues getting there.

Are we going to work with it via a thread pool?

yes


Readme.md clarifications

When I followed the Readme.md to setup a new event I encountered a couple small issues:

When I tried to follow the instructions "Click on 'Issues' over on the right sidebar of your repo", I couldn't find "Issues" in the sidebar right away. I had to click "Settings" and then select "Issues" under "Features" to be able to see "Issues" in the sidebar. Only then could I click Issues to create a new event.

When I was creating YYYY-MM-DD-word.markdown, I originally put a lot of info after location (e.g. location: Simon Fraser University, Burnaby Campus, SSB 6134). When I did this no location showed up in the events on the webpage, it just looked like this: "Introduction to tidyr/reshape2 package in R by Remi Daigle,, 14 July 2015".

To solve the problem, I had removed all by SSB 6134, but I imagine just not having commas would also solve it and let me keep the other text (since "Hacky Hour Stadium" works ;p)?
Maybe a couple notes in the Readme.md about how to see Issues in the sidebar and not using commas in YYYY-MM-DD-word.markdown could be useful?

Point #2 above could also be due to hard wrapping the text after location: as I normally do in an .md file to make it easier to read...

cool, thanks for the feedback! I've added a 'gotchas' section to the setup instructions, that point out the speedbumps people have had. Hopefully that gets people unstuck!


Feat: Convert jpg, png Images File Formats into webp File Format🌟🌟

Describe the feature
Purpose of Raising this Issue

WebP is a modern image format that provides superior lossless and lossy compression for images on the web. Using WebP, webmasters and web developers can create smaller, richer images that make the web faster. WebP lossless images are 26% smaller in size compared to PNGs.
I have taken An PNG File Format Image in Your Project Directory. Observe in Screenshot, It's almost 57% of File size Reduced while converting PNG File into WEBP File Format,
So, I want to work on those things in Codebase Files and Project Directory.

Add ScreenShots
Proof of My Issue

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'23 contributor
[X] I want to work on this issue

Hi @MonalikaPatnaik . Please Review on this Issue as soon as Possible. Thank You !


Send all email from NOREPLY_EMAIL_ADDRESS

Dear Zulip-Team,
thanks for your amazing software! We migrated from Slack nearly a year ago and really like it.
But we have an issue with sending email. We want that all outgoing emails are sent via the configured NOREPLY_EMAIL_ADDRESS =<EMAIL_ADDRESS>But for some emails Zulip seems to use the ZULIP_ADMINISTRATOR =<EMAIL_ADDRESS>email address.
As I read in another issue's comment this seems to be intended behaviour. But that doesn't work in our case, as the configured SMTP user only is allowed to send as noreply@ - and we cannot do anything about it (it is managed externally).
As a workaround we currently have set the ZULIP_ADMINISTRATOR config option also to the noreply address. Unfortunately all contact-links then use it too, e.g. on ourdomain.com/help:

We're here to help! Email us at<EMAIL_ADDRESS>with questions, feedback, or feature requests.

We would like to have support@ there.
Would it be possible to implement a configuration key like EMAIL_ALWAYS_USE_NOREPLY?
Greetings, Kevin

Seconding this. Much needed feature.

As a hack, one can modify this section of zerver/lib/send_email.py to make those variables have the same value:
class FromAddress:
    SUPPORT = parseaddr(settings.ZULIP_ADMINISTRATOR)[1]
    NOREPLY = parseaddr(settings.NOREPLY_EMAIL_ADDRESS)[1]

I'm open to having an option to support this, though I'm not sure what to call it (might be cleaner to just have an override for the displayed support email address, for example).  Might be worth trying to find another application that needs to solve this problem.

I suppose I'd be fine with having a SUPPORT_EMAIL_ADDRESS setting that defaults to settings.ZULIP_ADMINISTRATOR but we document can be changed to NOREPLY_EMAIL_ADDRESS.  Thoughts?
https://zulip.readthedocs.io/en/latest/subsystems/settings.html has some background.

@timabbott I'm not sure that would work exactly as @koelle25 would hope it would.
I think what he wants is to be able to send all outgoing emails from<EMAIL_ADDRESS>but still display<EMAIL_ADDRESS>where we link to the support addresses in various links in the web app. So we'd need a setting to "Send all email using NOREPLY_EMAIL_ADDRESS" and a setting for SUPPORT_EMAIL_ADDRESS whgich would be used for all the links in the web app.

@adambirds You're describing exactly what I thought of. Sorry for the late answer, this issue got buried under other stuff.

Perhaps the solution here is using the reply-to header? ie have an option in the settings that instead of using the administrator address the noreply address is used, but it sets the reply-to header to the admin email.

Hmm, maybe that could work better than the previous proposals.


conf_remap: demote 'Invalid configuration' to warning

When I added this in b4241b99d0d6017397acf92a2562898b7b5e57b4, I
miscategorized the log message. Since the plugin continues the loading,
this should only be a warning.

Cherry-picked to v9.0.x branch.
Cherry-picked to v9.1.x branch.

If we want this for 8.x can we get a backport?


chore(deps): update renovatebot/github-action action to 34.63.2

This PR contains the following updates:

Package
Type
Update
Change

renovatebot/github-action
action
patch
v34.63.1 -> v34.63.2

Release Notes

renovatebot/github-action
v34.63.2
Compare Source
See the the changelog for changes in all releases.
34.63.2 (2022-12-19)
Bug Fixes

deps: update renovate/renovate docker tag to v34.63.2 (17b0781)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@balena-ci I self-certify!


Create a search large form-1

One need to make this component using HTML and Tailwind CSS. I would suggest to use Tailwind Playgrounds to make things faster and quicker.
Here is a reference to the component.

After building the component please raise a PR with a screenshot of the component and add the component in form/form-search-large-form1.html.
If you need to use any icon please use it from Hero Icons
Good luck.

@hritikbhattacharya go ahead


Requirement of package needed for configuration is "hidden" in code.

In this doc:
http://docs.asp.net/en/latest/fundamentals/configuration.html#using-options-and-configuration-objects
the requirement of a particular package to make configuration work with binding is in the code snipped instead of being part of the document itself. I think a note box will be more appropiate. just my 2c.
// Configure MyOptions using config by installing Microsoft.Extensions.Options.ConfigurationExtensions
    services.Configure<MyOptions>(Configuration);

Thanks moved this to #829


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter pvoutputorg for common errors and appropiate suggestions to keep this adapter up to date.
This check is based on the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.pvoutputorg
   -
:thumbsup: No errors found
WARNINGS:

[X] :eyes: [W034] @iobroker/adapter-core 3.1.6 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json
[x] :eyes: [W508] attribute "xs" for checkbox should specify a value of "12" at admin/jsonConfig.json/items/tab-main/useWeatherAdapter
[x] :eyes: [W508] attribute "xs" for text should specify a value of "12" at admin/jsonConfig.json/items/tab-main/OID_WeatherConditions

SUGGESTIONS:

[X] :pushpin: [S522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
or
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 13 Dec 2024 05:25:34 GMT based on commit 7c24a9d7674ee2d1c9a726e49cd70d6702be987b
ioBroker.repochecker 3.2.2

@iobroker-bot recheck

@iobroker-bot recheck


Better modified detection

recursively convert dicts into CallbackDicts to better detect when values are changed

decided against this

@deforestg Why? Performance?

because I realized that it inherently modifies the data that is being stored in the session if it is a dict - so for instance if you have a line that says if type(session['thing']) is dict: then that will no longer work since its been converted to a CallbackDict instead

@deforestg And it doesn't apply to other mutable objects like list, so modified detection is still a problem.  Try to keep it simple, just do this:
data = session['key']
# modify data here
session['key'] = data


Adding CRD for RancherAlertRules and SupportConfig endpoint

Creates a CRD for RancherStatuses (statuses for rancher components)
Grants read-only permission to these resources for Restricted
Admin, Standard User, and User-base

Background
This introduces a new resource type - RancherStatus. The idea behind this resource type is to provide a mechanism for components of rancher to report a status which needs to be displayed to the user. In the case of the csp-adapter for aws, this can be used to inform users that they are out of compliance with the license.
Changes

Introduces a new CRD - RancherStatus
RancherStatus has the following fields:

ComponentName - the name of the component which this status refers to
ComponentStatus - if the status indicates an error (false) or standard operation (true). This could also be expanded to include more possible options if desired
Reason - the reason that this component is in this status

RancherStatus is not a namespaced resource
All typical types of users (base user, standard user, restricted admin) have permission to read these resources ("get", "list", "watch")
The admin user gets access to these resources by virtue of it's standard cluster role binding

Notes
A new CRD was chosen over using configmaps for the following reasons:

Configmaps are namespaced. Granting users access to these resources would require one of two changes:

In a controller, we map users who have access to one of the typical user roles to a rolebinding in the target namespace allowing them to read the status map. This has significant performance impacts (one new rb per user + controller overhead)
We grant access in a clusterrolebinding to configmaps in all namespaces with a specific name (to limit impact to only the results produced by the CSP adapter). This would create a potentially vulnerability if a configmap name was re-used unknowingly

This is set to DNM until the changes to the csp-adapter are nearing complete.

@cmurphy

From what I could see, the Alert objects were deprecated but they were replaced by the AlertRule objects (i.e. ProjectAlerts were superseded by ProjectAlertRules). If I'm wrong there please let me know.
As far as the purpose here - the overall goal is to allow the CSP adapter to signal to the end user that they haven't bought enough licenses and are out of compliance with their support contract. This has the requirement of being visible to all users (admin, restricted admin, standard user, and base user). I thought that the best way to support this would be a new CRD, which would be non-namespaced (and so we could easily add a read permission to the global roles). The reason that I thought about a generic CRD was that this could be useful in other areas of the code (i.e. a serviceAccount used for auth expired or was about to expire - throw an alert so users know to fix it).
As far as what this has to do with the SupportConfig endpoint - the endpoint does not interact with the alerts at all. Right now the SupportConfig stuff is closely tied with the csp adapter (and they have some interoperability as you can see in this PR). I can separate this out into another commit or another PR if you would like.

You are correct. I was told that I should not add another CRD if it can be avoided, and was told not to use norman as we are trying to move away from it to steve. Without the ability to create a CRD or add a norman action, I did not have anything that would allow me to control access to this endpoint outside of a non-resource url. Basically, I can either add a CRD/Action (I might be able to do this with Steve but I'm not 100% sure on that), or I can avoid adding a CRD but then authz has to use a non-resource url (at least that's what I see - open to other ideas). If you prefer the CRD route let me know and I can try to get a team discussion going - that's what I originally implemented before being told to not do that.

From what I could see, the Alert objects were deprecated but they were replaced by the AlertRule objects (i.e. ProjectAlerts were superseded by ProjectAlertRules). If I'm wrong there please let me know.

The only way I can see to create a v3.ClusterAlertRule is to enable the legacy feature, go to Legacy -> Alerts, and go to Add Rule, which calls /v3/clusteralertrules. So I assumed these were part of the deprecated feature. I could be wrong here. If there's some existing agreement on using AlertRules for CSP then I won't push back.

As far as the aggregation api goes I did look into that in the context of point 2 (support config), but not in the context of alerts. How were you thinking we could use that for alerts?
...
As far as what this has to do with the SupportConfig endpoint - the endpoint does not interact with the alerts at all. Right now the SupportConfig stuff is closely tied with the csp adapter (and they have some interoperability as you can see in this PR). I can separate this out into another commit or another PR if you would like.

Sorry, yes that was my confusion. We talked about the other CSP PR in the context of the supportconfig generator, so I thought this was tied in with that. If these are completely separate ideas then a separate PR would be very helpful.

You are correct. I was told that I should not add another CRD if it can be avoided,

Sorry again, my confusion was that this PR was adding a new type and also adding the supportconfig route and I thought they were related to each other. I agree it would be best to avoid adding a CRD for this supportconfig case if possible.
I had a quick look at some of the steve code and there are a couple of ideas there. The AdditionalAPIs code could be a good place for the new route to live, it seems to be a kind of home for misfit endpoints:
https://github.com/rancher/rancher/blob/c4d59fa88e2313e1446ba542a21c39e15a17f375/pkg/api/steve/additionalapi.go#L42
There are also some interesting authz ideas that could be borrowed from, where the existence of some token or secret authorizes the user for an action, and there's no need for a k8s-style SAR or Role:
https://github.com/rancher/rancher/blob/c4d59fa88e2313e1446ba542a21c39e15a17f375/pkg/api/steve/aggregation/auth.go#L50
https://github.com/rancher/rancher/blob/c4d59fa88e2313e1446ba542a21c39e15a17f375/pkg/api/steve/proxy/auth.go#L34
If you don't think those apply here then I'm in favor of the nonResourceURL SAR.

The only way I can see to create a v3.ClusterAlertRule is to enable the legacy feature, go to Legacy -> Alerts, and go to Add Rule, which calls /v3/clusteralertrules. So I assumed these were part of the deprecated feature. I could be wrong here. If there's some existing agreement on using AlertRules for CSP then I won't push back.

No existing agreement. Here's what I will do - I'll change the CRD to a "RancherUserNotification" crd, and with the following fields:
Component string // the component that was the source of the notification
Message string // the message for this notification

Let me know if you have any objections to the above.

Sorry, yes that was my confusion. We talked about the other CSP PR in the context of the supportconfig generator, so I thought this was tied in with that. If these are completely separate ideas then a separate PR would be very helpful.

Sorry for the confusion - the supportconfig has been tied in with the CSP adapter functionality from the start (same delivery timeline and CSP adapter needs supportconfig to work properly) even though they are separate. I should have been more clear about the separation.
For clarity's sake, I will open another PR. The current PR will be for RancherNotifications. The other PR will be for the supportconfig endpoint.

I had a quick look at some of the steve code and there are a couple of ideas there. The AdditionalAPIs code could be a good place for the new route to live, it seems to be a kind of home for misfit endpoints:

I originally intended to use these paths - however, they are not protected by rancher's auth system (the github endpoint has it's own custom method of auth). If I put it here I would need to re-implement our authn functionality to some degree, so I would prefer to avoid that.
I had not seen the other two examples before now. I need to give them a closer look - that being said, both examples seem to be using a different type of token (i.e. serviceAccount and clusterRegistrationToken) to grant access. That wouldn't really work here - I need to allow users to access the endpoint directly. I could proxy the endpoint through rancher and attach a service account, but that would probably require this to not be inside of rancher and would likely result in a more complex solution.

:+1: to everything

@cmurphy I've separated these out as requested and adjusted the CRDs as discussed. This PR now only adds the the RancherUserNotification Crd. I also took @cbron 's suggestion (thanks) to separate the commits into a non-generated and generated commit. I will update the description of the PRs accordingly.


bug: Error creating Subscription w/ Role Assignment on a new Service Principal

Versions

Please paste the output of terraform version command from within the initialized directory:
Terraform v1.3.7

Please enter the module version that you are using:
v2.1.1

Description
I have a reusable module where I am creating a Service Principal and Subscription together. The RBAC ID of the Service Principal is passed in the role_assignments variable for the LZ vending module. When I attempt to run this, I get an error as follows:
on .terraform/modules/lz.app.subscription/main.roleassignment.tf line 10, in module "roleassignment":
│   10:   for_each                     = local.role_assignments_map
│     ├────────────────
│     │ local.role_assignments_map will be known only after apply

It seems this is caused because the local var is generated with a unique id based off the contents of each map, but that isn't known until the Service Principal has been created. A workaround would be to -target the SP creation first and then the Subscription, but as this is wrapped in a module and called many times it becomes a bit of a pain to manage.
Steps to Reproduce

Create a Service Principal and Subscription, similar to below:

data "azuread_client_config" "current" {}

resource "azuread_application" "app" {
  display_name = "app"
  owners       = [data.azuread_client_config.current.object_id]
}

resource "azuread_service_principal" "sp" {
  application_id               = var.app_id
  app_role_assignment_required = true
  owners                       = [data.azuread_client_config.current.object_id]
}

module "lz_vending" {
  source = "Azure/lz-vending/azurerm"
  version = "v2.1.1"
  location = var.primary_location
  subscription_alias_enabled = true
  subscription_billing_scope = var.billing_scope
  subscription_display_name  = var.name
  subscription_alias_name    = var.name
  subscription_workload      = "Production"

  subscription_management_group_association_enabled = true
  subscription_management_group_id                  = var.mg_id
  subscription_tags                                 = var.tags
  virtual_network_enabled                           = false
  role_assignment_enabled                           = true
  role_assignments = [
    {
      principal_id   = azuread_service_principal.sp.rbac_id
      definition     = "Owner"
      relative_scope = ""
    }
  ]
}

Run a terraform plan

Hi @KashifSaadat
Good catch. We generate the map key guid for the role assignment based off the principal id, the definition id and and the scope.
Given you are creating the principal in the same plan this explains this error.
I'll look into fixing this with a patch release.

Hey @matt-FFFFFF, many thanks for the quick fix! I suspected there probably would be a breaking change due to the way the local was being generated, couldn't see any way around it.


Stylable as defaults attribute

Moved stylable from model attributes to defaults where it should be.

Good catch, thanks!


switchOnString doesnt restore created nodes on load

I have a local fix for this issue basically addign a postCreate function to switchOnString

@aspartamed  create pr please

closed in e7f477c77572c9498455a99fccd2a29e1d6f0e59


Soret isothermal wall fix

This PR addresses #389 . Happy to discuss any of the implementation, and let me know if you can see spots for improvement/clarity. Currently, I've not implemented the necessary changes required for EB.

Is it possible to check in the test case?

Sorry for the delay, busy month or so...
I've added in the changes so it is computed when computing divu, I've added in the same boundary input to the diffuse_scalar call when running with EB. Code also aborts on Isothermal+Soret+Efield. I am also still seeing some species flux in the species balance files, on the order of 3e-7 or so - any thoughts on this?

Sorry @ThomasHowarth, I know you've got a few big PRs in the queue waiting for review. I'm going to try to get to them this week.
I've dug into this one a bit and think I figured out the where the remaining conservation error is coming from. With the lagged correction approach, I was only thinking of the implicitly solved $\tilde{D}^{n+1,k+1}$ term in the update equation below, but, as you've now implemented the corrections must also be applied when computing $D^n$ and ${D}^{n+1,k}$, but those are explicitly computed and can't be lagged. Basically, the Soret and Wbar fluxes should be computed first in computeDifferentialDiffusionFluxes and those values should be used to set the inhomogeneous neumann conditions for the diffusive fluxes. For the Soret fluxes that should be easy with some code rearrangement. For the Wbar fluxes it's a little tricky because the Wbar fluxes at the isothermal boundary depend on the species gradients at the boundary, but also affect what the boundary condition needs to be for the species gradients, leading to an implicit definition of the boundary condition. I think it should be okay to compute the Soret terms first, use the boundary species gradients from the Soret terms in computing Wbar fluxes, then use the combined boundary gradients from both Soret and Wbar for the diffusive fluxes. Iterating around the Wbar flux computation would be the fully correct thing though.

Let me know if this makes sense. This is definitely a tricky problem and I'm not sure if I fully understand it. But I did hack a test for the Soret part of the fix (while turning Wbar fluxes off) and that did lead to correct mass conservation.
BTW, I also submitted #410 to make using temporals to track conservation a bit more user friendly.

Still working on this, and getting somewhere, but I noticed that in the addWbarTerm function that the flux doesn't match with what you have above. I looks like
$$\rho D_{k} Y_{k}\nabla \overline{W} / \overline{W}$$
rather than
$$\rho D_{k} Y_{k}\nabla \overline{W} / W_{k}$$
which is what I would expect. Just want to double check this here.

Based on what you said, I've made changes. The conservation error is now down at 10^-23 my run of the test case. I have also changed the wbar flux calculation based on the comment above. Additionally I removed an unnecessary rhoY edge calculation from the soret flux calculation.

Without the Wbar correction, I have also managed to eliminate the conservation error (Up to 10^-23). However, iterating around the wbar fluxes seems to blow up the gradients, and I'm not entirely sure why. I'll keep working on it, but I've also pushed the latest version so you can take a look if you like.

Nice progress a @ThomasHowarth. This has turned out to be much more involved than expected!
If a solution doesn't jump right out at you for the exploding wbar iterations, do you think we can merge this without the wbar iterations (or maybe hardcoding to 1 "iteration") and then have a separate PR for the final correction? There's a lot here that I don't want to risk falling out of date and even without the last bit it's more correct than what's in there now.

I think perhaps the best course is to just do the Soret correction for the conservation, disable the use_wbar for consistency (in these cases) and leave a warning/todo note. If this seems reasonable I can tidy things up and leave it like this for now? As you say, at least it will work, if not perfect yet.

So, I've done some more thinking about why things blow up. Since we have to do some portion of the solve explicitly rather than lagged, I think we revert back to the point I made in the discussion, and the Y coefficient of the Wbar term becomes a problem. As I say, I can either disable the Wbar corrections in this case and everything works, otherwise this is going to become even more complicated...

@baperry2 I have resorted to disabling wbar for this particular case - the boundary condition becomes very complicated otherwise. Some of the machinery is still left (e.g. filling boundaries for wbar and computing gradients of wbar using gradients of Y), but it should be bypassed. I'm leaving it there in case someone wants to try and figure this out down the line - I can also remove it. This way the solver is both conservative and consistent, even if the diffusion model isn't perfect.

@jrood-nrel any idea why the Docs workflow is not running? It seems to be not running since you updated the workflow ubuntu version.
This doesn't touch Docs, so i'm going to merge, but we should figure that out since it appears to be affecting other PRs

It requires certain files to have changed https://github.com/AMReX-Combustion/PeleLMeX/blob/b3d27d4d40943772bdd47a9be8335d91ff9f73a5/.github/workflows/docs.yml#L7-L9 . I would also be fine having it always run.

I think this is fine, I'll just remove it from the list of "required" checks then, otherwise it will show up as "expected" and prevent auto-merging for cases where it does not run.


Move phase out of the parameter list

It should be data in a scope, since it is specific to the App::hopen use case.

Fixed in v0.0.19.


Disable / Enable Swipe

Is it possible to disable all events until a certain another event?

just set
mSwipeStack.setEnabled(false);


Dropdown placement not align when using in table rows

Describe the bug
Dropdown misalign when using in table rows
To Reproduce
Steps to reproduce the behaviour:

When I click out the dropdown button in the table row
The dropdown menu item gets placed in top-end instead of bottom-end

Expected behavior
The dropdown menu should be shown in the correct coordinate.
Screenshots

Desktop (please complete the following information):

OS: macOS BigSur
Browser  Microsft Edge 89.0.774.76
Version 11.2.3

Server (please complete the following information):

Platfrom Version: 9.21.0
Laravel Version: 8.37.0
PHP Version:  7.4
Database:  [e.g. MySql]
Database Version:  5.7

@tabuna Already solved in > 9.21.0 orchid version.

Hi @leeliwei930, I don’t think this is resolved. It selects the position automatically.


update packaging for .net 5

This MR updates the packaging of this project (which is awesome, thanks by the way!) to support .net 5.  There are no breaking API changes, it just means that we don't hit the old netstandard2.0 pathway which drags in Aspnetcore dependencies that aren't the framework reference.

Hell yeah: I've been meaning to do this.  Any ideas what the build failure is?  Looks like there is just some issue finding the tests?

yeah, that was it exactly. I forgot the formatting of TargetFramework vs TargetFrameworks

Just a bit more work on making the netcoreapp3.1 sdk availble as well, then this should be good to go.

@baronfel, I'll be honest: I've been dabbling in a lot of Rust lately and have not kept up on the .NET 5 news as much as I normally would have.
Do we still need to keep the netstandard2.0 targets around?  Assuming yes for back compat?

Yep! Generally for a library like this I recommend:

netstandard2.0 - for .net framework 48+ folks
netcoreapp3.1 - for LTS support
net5 - for latest awesomeness

How's rust working for you? I'm mostly an F# guy myself and so knowing that it exists makes me more comfortable working on systems programming :)

There we go, green at last :)

Rust is fantastic: I highly recommend it. :)


KAFKA-7520: Possibility to configure versions in Mirror Maker ducktape test

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@smurakozi @viktorsomogyi @asasvari @andrasbeni
pls review


Cart LineItemCollection cant hold multiple non-stackable products

I stumbled upon the parameters in the twig block page_product_detail_buy_product_buy_info. Any client can change the stackable input to 0. That is a nice feature I want to use. When I add a product with stackable set to 0/false my cart crashes and this is not fixable in an easy way without some discussion so I start one :wink:
Facts:

You can't change the quantity of a LineItem if it is non-stackable. throw Exception
A LineItemCollection groups LineItems by their id and expects multiple LineItems to have same type if they share the id :+1:
The LineItemCollection sums just quantities (no children :warning:) if one add an a LineItem with an id already in the collection
A product LineItem has the product id as LineItem.id :thinking:
The CartService has no interface
The CartService dispatches an event on adding an item after the collection was changed

Problem occurs when you add a non-stackable product LineItem twice. This ends up in the LineItemCollection seeing the same LineItem and it is up to merge the quantities. This will fail as the LineItems are not stackable. Easy. Just use different ids. But then the product LineItems need to have someone to merge them as their ids now differ although they link to the same product.
What really grind my gears: Why are the product LineItems keyed with the product id when the product id is in the referencedId field? This means that two products in a cart are not allowed to be different. Shouldn't a LineItem have a unique id everytime you add it to a collection? Why should one add a LineItem to the cart and already know the primary key for it?
It is ok for me if you have to add it with a generated UUID because I still don't know it in before hand.

A product LineItem has the product id as LineItem.id

The core uses the product id as line item identifier, because all products which are added by the core can be stacked.

The CartService has no interface

It is not intended to decorate or replace this service

Problem occurs when you add a non-stackable product LineItem twice.

This runs in an exception because the line item is non-stackable ;)

Why are the product LineItems keyed with the product id when the product id is in the referencedId field?

The product processor uses the referenceId to update the product data (price, name, description, etc.).
The core uses the product id as line item identifier to display only one position for a product.

This means that two products in a cart are not allowed to be different

Thats right. The core adds a product as type:product and line-item.id=productId. This is important to validate which price is the current quantity price.
If you want to add a product as a single row, simply add generate a unqiue key and provide it as line item key.

The following example shows how to add the same product twice but as single row in the cart:
/** @var EntityRepositoryInterface $repo */
$repo = $this->get('product.repository');

$product = $repo->search((new Criteria())->setLimit(1), $context->getContext())->first();

$service = $this->get(CartService::class);
$cart = $service->getCart(Uuid::randomHex(), $context);

/** @var ProductEntity $product */
$lineItem = (new LineItem('test-1', LineItem::PRODUCT_LINE_ITEM_TYPE, $product->getId(), 1))
    ->setRemovable(false)
    ->setStackable(false);

$cart = $service->add($cart, $lineItem, $context);

/** @var ProductEntity $product */
$lineItem = (new LineItem('test-2', LineItem::PRODUCT_LINE_ITEM_TYPE, $product->getId(), 1))
    ->setRemovable(false)
    ->setStackable(false);

$cart = $service->add($cart, $lineItem, $context);

Can you provide an use case which is not possible with the current cart implementation?

The core uses the product id as line item identifier, because all products which are added by the core can be stacked.

So a product LineItem is doomed to be stackable by type? Is there a need to pass both information? Feels like any LineItem is doomed to be stackable. The stackable information isn't used elsewhere but the quantity change.
My current understanding: If I want to stack, I use the same id. That's it.

It is not intended to decorate or replace this service

Fine for me so far (although I stated differently on the q/a to the presentations this year :stuck_out_tongue:). Just wanted to point out that there is no real way to intercept the process before the collection manipulation happens.
In my case I want to customize a product with an uploaded file. So I store the uploaded file, track it in a table and want to connect that one to a line item id. I can't order two different configured products in the same cart as their quantities gets merged and my second file is sort of lost.
In my current attempt I am up to create children for this product so the products gets merged correctly (after I merged the children in as well) but still have multiple configurations on them. Is that a way to go? More properties of the product like price and delivery depends on that configuration as well.

Hey,
A product doesn't have to be stackable in the cart, as you can see in the above example source code.
For your special use case, I would simply generate a random uuid every time you add a product with an uploaded image to your cart and use it as line item id.
Unfortunately I can't tell you how to generate a uuid in twig that is not cached. I would rather write my own controller to put the product with the picture into the cart.

For now I've added an own controller. That really worked out quite well.

Hi @JoshuaBehrens,
thanks for the #174 ;).
If you have any further questions about the cart, please do not hesitate to contact me. We can also simply make a phone call, then I could also include the open questions in a FAQ.

:call_me_hand: ? That is new to me. Maybe I come back to it later. Thanks so far

I think I have to reopen this issue. I ran into a similar problem described by Joshua.
What happens if I would like to extend Joshuas Product with an gift package extension. I extend the product form with an selection of giftpackages. Do I also have to overwrite the product with an custom uuid like Joshua did, because I don't know if the product uses his plugin extension or not. If yes, does his extension still work, or must I look for his plugin and how he did change the uuid?
Another more real life example: The gift package extension has 3 options (No gift package, Flowers, Planes).
Every product should be stackable on his own. Because I would like to buy the product once with no gift package, one with plane packaging and one with flower packaging.
Then I found out uiii I forgot one birthday child and would like to add the same product once more with plane packaging. For now I have 3 times the same product inside the cart, with different gift packages.
I think this behavior is not uncommon.

I expect that our plugins would not be compatible at first. You have to reverse the tree. You add gift packages and their children are the gifted/wrapped products.

I expect that our plugins would not be compatible at first.
This already a problem now for me. I have 2 plugins which could add childs to the same product on different combinations. The current situation make it impossible to add different combinations and additionally it's incompatible to other developer extensions. The example of the gift package is just a simplification, so what should i do in the case described above with 2 plugins. Correct  me if I am  wrong. As far I understand you right I have to inverse the tree, but to which line item?

@OliverSkroblin any suggestions how to handle this behaviour. Specially if I as a developer don't want to break cart extensions from other developers?


Cannot run on ZNC 1.6.0 and Ubuntu 14.04

Error message while loading: undefined symbol: otrl_context_set_trust
Compiled from source using znc-buildmod.

@Cysioland Can you try compliling the module by running make in its source directory? IIRC znc-buildmod does not link the module with libotr, thus the error.
http://wiki.znc.in/Otr#Installing

That did the trick,


Initial Commit

PMDB Link: 26796
Enhancement:

Added 'Updated Start Date', 'Updated End Date', 'Records Offset' and 'Records Per Page' in 'List Alerts' operation.
Added the ability to configure data ingestion (using the Data Ingestion Wizard). The Data Ingestion Wizard also
supports multiple configurations specified on the Configurations tab of the SEKOIA.IO XDR connector, ensuring
respective global variables based on the selected configuration are used while ingesting data.

Invalid PR.


Token expiry does not seem to run

Can someone check the values in src/config.php   and check the web2 token is correctly there. There are loads of tokens open for me currently eg

They should be removed by the job which runs on login

Part the person is looking for
'oauth' => array(
'expirable_client_ids' => array(
// some clients, (e.g. web2) do not hold onto their token after the
// user logs out of the client, so we can expire their old tokens.
'web2',
),
),
Web2 should be in there. If it is in there the issue is likely dB permissions as there is no error handling


Erroneous user flow recommendations

Hi! This page seems to be erroneous as the only flows recommended are:
V1.PasswordReset
V1.ProfileEdit
V1.SignUpSignIn
V2.ProfileEdit
Are all the other flows really not recommended (ie. not production ready) or does the article need to be updated?
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aad1c40b-8340-81ed-2c25-b3029a54245a
Version Independent ID: aa276f5a-89dc-5fbc-b38a-b52988491aa2
Content: User flow versions in Azure Active Directory B2C
Content Source: articles/active-directory-b2c/user-flow-versions.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@vronzeur  Thanks for reaching out. We will investigate and update the thread accordingly.

Hello @vronzeur,
Thanks for bringing this up.
Any specific reason why you think that the article is not updated?

Well, if this is indeed true, then the only option to sign a user in is through the SignInSignUp V1 flow which I find an inadequate solution. For example, our company has a product which is not open to the general public. The target audience for our product need to be pre-registered and approved by us before they may use it, meaning that the SignIn flow would be ideal for us.
I assume there are multiple applications that require more variations of the available user flows than the ones currently recommended. Could you verify if this is indeed the current state? Since the page was also not updated since September, 2019, are the v2 flows also to be supported some time in the future?

@vronzeur, We completely understand your requirements.
Currently, as written in the documentation, SignIn Flow is not Recommended yet and is in Preview. And for all the User Flows, the current status is as mentioned in the documentation.
Please note that we're currently working on updates for User Flows (Functionality and Documentation), but we don't yet have details to share about that. But, I would suggest you to keep an eye on the documentation and you may soon see some updates.
Also, any feature moved from Preview to GA is documented at below links:

https://docs.microsoft.com/en-us/azure/active-directory/fundamentals/whats-new
https://docs.microsoft.com/en-us/azure/active-directory/fundamentals/whats-new-archive

We'll keep this issue open for now, and when the article is updated with the latest information we will update this thread.

I have assigned the issue to the content author to review further and update the document as appropriate.

Hello @vronzeur !
Just checking to see if you have had a chance to see the previous response. Kindly let us know if it answers your question and if you need further assistance on this issue.

Hello @HarshitaSingh-MSFT
Yes I saw the response. I cannot imagine that this would be the final selection of user flows available, so I am curiously waiting for future updates. We right now have switched to custom policies but hopefully Azure's default selection is soon enough for all combinations of authentication methods.
Thank you for your response :)

@vronzeur, We will now proceed to close this thread.
If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
Also, please do not forget to accept the response as Answer; if the above response helped in answering your query.

@vronzeur, If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion.
Also, please do not forget to accept the response as Answer; if the above response helped in answering your query.

Hi @vronzeur, thanks for your feedback. The previous replies are correct -- please keep an eye out for updates in this area. I'll go ahead and close this issue for now, but feel free to reach out if you have further questions. #please-close


chore(master): release 1.4.26

:robot: I have created a release beep boop
1.4.26 (2023-09-22)
Miscellaneous

deps: update actions/checkout digest to 8ade135 (1dd2351)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/docker-build-deps/releases/tag/v1.4.26 :sunflower:


UI Improvement - Section metadata

OVERVIEW
The following is from a list from the Chicago Sprint on Improvements that the group felt would be important to users:
In the section metadata area - the date should also include the day
https://salesforce.quip.com/JKMnAsPUEeDd
ACCEPTANCE CRITERIA
OUT OF SCOPE
BACKGROUND/REFERENCE

I'd like to review this. I believe the request was to edit the section metadata and I'm not sure how one would do that as a user.


[terra-tabs, terra-menu] copy classnames for menu icon on clone

Summary
The terra-menu now allows icons to be placed in the menu. This includes any icons, in particular, the themeable icons. However, if any styling is applied to the icon via classnames, those styles will not get carried forward.  When cloning the icon in the MenuItem.jsx, this will now append the start-icon styling to any existing classnames.
Closes #1599
Deployment Link

https://terra-framework-deployed-pr-#.herokuapp.com/
Testing
This has been tested locally via the dev-site
Additional Details

Thank you for contributing to Terra.
@cerner/terra

Fails

:no_entry_sign:
Please include a CHANGELOG entry for each changed package this PR. Looks like a CHANGELOG is missing for:

terra-framework-docs
terra-tabs

  Generated by :no_entry_sign: dangerJS against 1a3dade9bb476f4596db926289da2b57c91761e4

Fails

:no_entry_sign:
Please include a CHANGELOG entry for each changed package this PR. Looks like a CHANGELOG is missing for:

terra-tabs

  Generated by :no_entry_sign: dangerJS against 6e6147dc701675158978a05483b810ba584d3639

Fails

:no_entry_sign:
Please include a CHANGELOG entry for each changed package this PR. Looks like a CHANGELOG is missing for:

terra-application-navigation
terra-application-utility
terra-collapsible-menu-view
terra-date-picker
terra-date-time-picker
terra-dialog-modal
terra-navigation-side-menu
terra-notification-dialog
terra-popup

  Generated by :no_entry_sign: dangerJS against 768a03a87ae0db5ca038a3b3e0ec403f7bb588e9

Can you update the PR to have only fix for #1603  and remove the jest updates added to fix the build ?? we will create different PR for snapshot update so that we can do quick review on that and get it merged to fix the travis build.

Can you update the PR to have only fix for #1603 and remove the jest updates added to fix the build ?? we will create different PR for snapshot update so that we can do quick review on that and get it merged to fix the travis build.

@supreethmr I reverted those changes, now it just contains the changes I made for terra-menu only

Fails

:no_entry_sign:
Please include a CHANGELOG entry for each changed package this PR. Looks like a CHANGELOG is missing for:

terra-collapsible-menu-view
terra-tabs

  Generated by :no_entry_sign: dangerJS against 72d0ff4e0dff3f87ca4255bb89c439292dbd532d


Bitcode enabled version?

I found some old comments implying that you have a version of this library built with Bitcode enabled.
Where would I be able to find the Bitcode enabled version of the latest build?
Thanks
Rog

Hi,
The current version should support both bitcode and non-bitcode.

Thanks! For some reason the dynamic library was refusing to work but using the static one via cocoapods seem to have fixed it.

Hi there I take the comment above back, it actually doesn't work when I build with bitcode enabled. Here's the full xcodebuild error message
❌  ld: bitcode bundle could not be generated because 'Pods/MobFoxSDK/MobFoxSDKCore.embeddedframework/MobFoxSDKCore.framework/MobFoxSDKCore(MobFoxTagAd.o)' was built without full bitcode. All object files and libraries for bitcode must be generated from Xcode Archive or Install build file 'Pods/MobFoxSDK/MobFoxSDKCore.embeddedframework/MobFoxSDKCore.framework/MobFoxSDKCore' for architecture armv7

Ok, we'll upload a fix after testing this internally.

Hi,
I created a new project and MobFox integraton using CocoaPods works as expected in both cases of enabling and disabling bitcode. please use the attached project, verify by yourself that you can build it with bitcode enabled. let us know if you still encounter any issues.
MobFoxDemoBitCode.zip
Regards,
Shimi

Thanks for the sample project however I can still reproduce the issue.
Building works fine, it's when you try to archive that you will get the error.

ld: bitcode bundle could not be generated because 'Pods/MobFoxSDK/MobFoxSDKCore.embeddedframework/MobFoxSDKCore.framework/MobFoxSDKCore(MobFoxTagAd.o)' was built without full bitcode. All object files and libraries for bitcode must be generated from Xcode Archive or Install build file 'Pods/MobFoxSDK/MobFoxSDKCore.embeddedframework/MobFoxSDKCore.framework/MobFoxSDKCore' for architecture arm64

Hi,
Now core is built with full bitcode and 'Archive' invoked succefully after some changes in build settings for static lib. use the attached SDK core and let us know if there are still any issues. it should be fine.
MobFox-iOS-SDK-3.1.9c-binaries.zip
Regards,
Shimi

Thanks all, I'll try it out and report back shortly.

Ok just letting you know that the static library now works with bitcode enabled but the dynamic still returns the same error.
I'll stick with the static library for now but I see no reason why you guys are still offering the static library option since all iOS 8+ targets can use the dynamic version.
Thanks for the quick feedback loop, it is much appreciated.

Hi,
The dynamic core file is attached, please create a new project (without any pods files or definition in settings related to cocoa pods) and integrate it manually to your  project, make sure it defined under 'Embedded Binaries'. Archive is generated successfully by Product -> Archive.
Also a demo app with dynamic core is attached, to verifying all set as expected.
It can be tested from terminal by the command below that bitcode exist
in library, 'segname __LLVM' will appear in output if library contains bitcode.
$ otool -l libName.o | grep __LLVM
Let us know if there are still any issues.
Uploading MobFox-iOS-SDK-3.1.9c-binaries.zip…
MobFoxBitCodeDynamic.zip
Regards,
Shimi

SDK Core Dynamic:
MobFox-iOS-SDK-3.1.9c-binaries.zip

Fixed in 3.2.0


Add PYPI_PASSWORD secret to repository

The secret should be called PYPI_PASSWORD and it should be a PyPi API token with access to the Flask-Talisman repository.

Done.


Implements a strict-mode toggle for Function operations

This is a WIP PR for #241

Cool, thanks! So while I like the simplicity of this approach, I'm a bit worried about two things (specific to the MutationEngine):

The chance of a "use strict" being placed at the right point by a mutation is very low I think (it may even be impossible to place it at the start of a script due to the prefix), and so
A lot of "use strict" will be removed by the minimizer, and then probably never come back

But I also can't really think of a better way. Maybe we should keep the StrictFunctionDefinition, but then somehow allow the entire script to become strict mode through some other way, for example by adding an attribute or comment to the Program class? I don't really think we'd need to create new strict mode programs (i.e. don't need a mutation that turns an existing program into a strict-mode program), since we should cover the same functionality just through strict-mode functions. Alternatively, and maybe even simpler, when compiling a strict-mode JS program, maybe we could just wrap the entire code into a strict-mode function? WDYT?

Alternatively, and maybe even simpler, when compiling a strict-mode JS program, maybe we could just wrap the entire code into a strict-mode function? WDYT?

Yeah that's a good shout! Saves us the bother of having to track program attributes.

Maybe we should keep the StrictFunctionDefinition

Can we instead use a boolean flag to track whether a function should be lifted to strict mode? The reason being we would then have to define strict variants for all function definition ops. Iirc we had a boolean flag to track this in an earlier implementation of BeginFunctionDefinition before spliting them into BeginPlain* and  BeginStrict* version.

As we discussed, the strict directive op has now been replaced with a strict-mode flag for each Function operation.

@saelo any thoughts on this one?

It appears that the two most recent comments to main are causing build failures :(

changes incorporated and PR rebased

Thanks!


us_privacy vs usprivacy for cookie name

Is there a reason that the cookie is set with the name "us_privacy" here https://github.com/InteractiveAdvertisingBureau/CCPA-reference-code/blob/master/src/uspapi.js#L43 but that in the documentation in the v1 spec says the cookie should be named "usprivacy" without the underscore?

Agree that reference code should track with the spec unless there;s good reason to do otherwise.

Thank you for spotting this. I do a PR right away.

Change is committed to master.


Exception: 'The file is not a cloud file'

Hi,
I encountered an issue while running the code to register a sync root using StorageProviderSyncRootManager.Register(SyncRootInfo); The exception thrown is:
System.Exception: 'The file is not a cloud file. (Exception from HRESULT: 0x80070178)'
Steps Taken:
Verified that the folder exists and has the correct permissions.
Ran the application with administrative privileges.

Have you encountered this error in your implementation? Any insights or suggestions to resolve this issue would be greatly appreciated.
Thank you

Make sure the folder is on a NTFS drive. Did you manage to get any other folder working?

It worked directly on the C drive. At first, it worked using C:\Users[my user]\VirtualTest, but after several retries, it stopped working and never worked again. Now, it only works using the C drive.


git binary needs to be installed also

Issue
Git is not installed but yarn install tries to use it.
How to reproduce:
Fresh git clone
docker-compse up
The log shows the error
Step 5/14 : COPY ./package.json .
 ---> 58f5e723404f
Step 6/14 : COPY ./yarn.lock .
 ---> ff8e79f2ced8
Step 7/14 : RUN yarn install
 ---> Running in 8b8661f0c537
yarn install v1.22.5
[1/4] Resolving packages...
[2/4] Fetching packages...
error Couldn't find the binary git

Suggested fix:
add git to list of installable packages:
https://github.com/1inch/shieldy/blob/afb7e312cb95600ceb17cd2a8704eed1871f6f5b/Dockerfile#L15

@PeterDaveHello is there any chance you can help with this?

Well ... it's caused by 9378f0b26e9302e43fee3cb4c67acc9caac3d6b2 and the following 6b70ed74b5c4e0e0bfa5b98345f0f62f588fb5b5, 75d6523afb48d0c587cc462539cf8ad094f3b8c0, I'd send a pull request to add git into Docker image.

#142 should fix it

@PeterDaveHello thank you a lot for the fixes! :)

Many thanks, a really quick fix, awesome!


Update 400-nextjs-prisma-client-dev-practices.mdx

Make an example less confusing
Describe this PR

Changes

What issue does this fix?

Any other relevant information

Thanks for making the update! Everything looks good to me 🙂


Fix window functions to resolve.

After the window functions, we should always resolve the InternalFrame; otherwise the window will be applied later, causing a weird behavior:
>>> kdf = ks.DataFrame({"Col1": [10, 20, 15, 30, 45], "Col2": [13, 23, 18, 33, 48], "Col3": [17, 27, 22, 37, 52]})
>>> kdf
   Col1  Col2  Col3
0    10    13    17
1    20    23    27
2    15    18    22
3    30    33    37
4    45    48    52
>>> kdf['Col1'].shift().loc[kdf['Col1'] == 20]
1   NaN
Name: Col1, dtype: float64

This should be:
>>> pdf = kdf.to_pandas()
>>> pdf['Col1'].shift().loc[pdf['Col1'] == 20]
1    10.0
Name: Col1, dtype: float64

Resolves #2078.

Codecov Report

Merging #2090 (05063fa) into master (2e6094b) will decrease coverage by 5.52%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master    #2090      +/-   ##
==========================================
- Coverage   95.28%   89.76%   -5.53%
==========================================
  Files          57       57
  Lines       13223    13116     -107
==========================================
- Hits        12600    11773     -827
- Misses        623     1343     +720

Impacted Files
Coverage Δ

databricks/koalas/groupby.py
91.42% <ø> (-0.21%)
:arrow_down:

databricks/koalas/spark/accessors.py
94.04% <90.00%> (-0.93%)
:arrow_down:

databricks/koalas/base.py
93.46% <100.00%> (-4.07%)
:arrow_down:

databricks/koalas/frame.py
93.50% <100.00%> (-3.11%)
:arrow_down:

databricks/koalas/series.py
95.64% <100.00%> (-1.15%)
:arrow_down:

databricks/koalas/plot/plotly.py
15.78% <0.00%> (-81.06%)
:arrow_down:

...bricks/koalas/tests/plot/test_frame_plot_plotly.py
23.33% <0.00%> (-76.67%)
:arrow_down:

...ricks/koalas/tests/plot/test_series_plot_plotly.py
26.92% <0.00%> (-71.26%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
27.58% <0.00%> (-64.92%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
47.82% <0.00%> (-52.18%)
:arrow_down:

... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e6094b...05063fa. Read the comment docs.


upgrade clojure-future-spec to 1.9.0-beta4

The main thing is to migrate from referring to the old clojure.spec namespace to the new
clojure.spec.alpha namespace.

Thanks!


Check empty value options

In some fields we have '' (empty string) as an option. There are some problems with how the code currently handles these:

The option visually is very narrow, which makes it hard to even notice
the code for the editingcomponents may not work well with this
One solution could be to make a reusable option object like const noValue = { value: '', displayValue: 'No value' }
But is it different for the database to have empty string or null? Does this vary for different fields? Are there fields that cannot have null but can have '' as a valid value

Also,

this was removed from some options so check that it is where it should be (localitytab approx_coord maybe?)

make it "No value"

make something like optionDisplay which is displayed only in option, but in read mode we can show empty string

f47da17


Add Electro and Sparkled to Projects list

Added Electro by @jspear29, and Sparkled by yours truly :)

Thanks! Sparked looks awesome, btw!

Thanks, I'm pretty happy with how it turned out. I haven't worked on it in a while though. My plan was to use it to create a sequenced Christmas light display for this year, powered by an Arduino Due.
I ran into a roadblock, however. The cable length between the Arduino and the some of the strips was too long and the signal got degraded.
In order to progress, I need to use eight Arduinos that will sit right next to the strips, and communicate/sync wirelessly. Sounds like a real pain to get working, but I'll see how I go haha.


add image-minus icon

Preview

@ericfennis can you run the refactor icon script magic on this PR too.

@csandman worked on this. yarn optimize is fixing icons, if I'm right. If you experience any issues let us know.

It looks like the precommit hook worked and it's already formatted/optimized!  Glad to see it.

@csandman I don't think so, I had to manually run that yarn optimize build to refactor the icons.

@csandman I don't think so, I had to manually run that yarn optimize build to refactor the icons.

Did you try committing the file without running the script?  It should optimize during the commit process.

Did you try committing the file without running the script?

The first commit was without refactor, then I had the run the script manually and commit the changes.

It should optimize during the commit process.

Does this script will only run when using terminal instead of GUI app?

@mittalyashu it should be doing it either way, I'll take a look at it tomorrow.

@mittalyashu The change to add the pre-commit hook was recent however it should definitely be working.  can you please make sure your package.json file has the following at the bottom in your local version of the repo?
"husky": {
  "hooks": {
    "pre-commit": "lint-staged"
  }
},
"lint-staged": {
  "icons/*.svg": "npx babel-node ./scripts/optimizeStagedSvgs.js --presets @babel/env"
}

And if it does, make sure you run yarn install to get those dependencies set up?  I'm very curious if this ends up working!
@ericfennis We might want to add a note in the readme that people should update their local repo before committing any new icons, otherwise people might commit icons which are not consistent with the others and will require future optimization.


ES6 imports not working on v5.2.0

Since upgrading to v5.2.0, using ES6 imports is no longer working. Just get a ReferenceError saying swal is not defined.
This JSFiddle doesn't really illustrate the point.

This JSFiddle doesn't really illustrate the point.

Could you please make the jsfiddle that illustrate the point? :)

Sorry that was the wrong link. I have tried to recreate it, but not sure it's possible in JSFiddle.
JSFiddle

I have an angular 2 project that I'm trying to use this on. I installed it, then tried to import it, and typescript is saying it can't find the module.

Tried to recreate the issue with a bare bones project, and it no longer causes an error so must be something I have done wrong. Closing issue.

@limonte had the same issue today and the fix was binding to the window
import { default as swal } from 'sweetalert2'
window.swal = swal;

@limonte had the same issue today and the fix was binding to the window
import { default as swal } from 'sweetalert2'
window.swal = swal;


Get client real ip alb-ingress > ingress-nginx > app

Hello, i have alb-ingress-controller to serve as the first hop, plus nginx-ingress-controller for final routing.
How i can get real client ip in nginx logs and in app. Now i see only internal node's ip in ingress-nginx logs and in my app.
My alb-ingress:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: "rootalb"
  namespace: ingress-nginx
  labels:
    app: "rootalb"
  annotations:
    # trigger the alb-ingress-controller
    kubernetes.io/ingress.class: "alb"

    # set ALB parameters
    alb.ingress.kubernetes.io/scheme: "internet-facing"
    alb.ingress.kubernetes.io/target-type: "instance"
    alb.ingress.kubernetes.io/subnets: xxx,xxx,xxx
    alb.ingress.kubernetes.io/certificate-arn: xxx
    alb.ingress.kubernetes.io/listen-ports: '[{"HTTPS": 443}]'
    alb.ingress.kubernetes.io/target-group-attributes:
    stickiness.enabled=true,stickiness.lb_cookie.duration_seconds=60

    alb.ingress.kubernetes.io/healthcheck-path: "/"
    alb.ingress.kubernetes.io/success-codes: "200,404"

spec:
  rules:
  - http:
      paths:
      - path: /*
        backend:
          serviceName: "ingress-nginx"
          servicePort: 80

My app - ingess-nginx config
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: prom
  namespace: monitoring
  annotations:
    kubernetes.io/ingress.class: "nginx"
    nginx.ingress.kubernetes.io/whitelist-source-range: x.x.x.x/x
    nginx.ingress.kubernetes.io/rewrite-target: /
    nginx.ingress.kubernetes.io/affinity: "cookie"
    nginx.ingress.kubernetes.io/session-cookie-name: "route"
    nginx.ingress.kubernetes.io/session-cookie-hash: "sha1"
    nginx.ingress.kubernetes.io/configuration-snippet: |
      real_ip_header X-Forwarded-For;
      set_real_ip_from <IP_ADDRESS>/0;
spec:
  rules:
  - host: app1.domain.com
    http:
      paths:
      - backend:
          serviceName: app1
          servicePort: 3000
  - host: app2.domain.com
    http:
      paths:
      - backend:
          serviceName: app2
          servicePort: 9090
  - host: app3.domain.com
    http:
      paths:
      - backend:
          serviceName: app3
          servicePort: 9093

For example setup i'm use this article - https://medium.com/@dmaas/amazon-eks-ingress-guide-8ec2ec940a70

Hi,
The ALB will pass the real-IP in X-Forwarded-For header.
For nginx to use that header, seems the ngx_http_realip_module is not enabled by default.
I think it's better to ask this question in nginx ingress controller repo for how to enable ngx_http_realip_module module. (I'm not familiar with nginx ingress controller setup)


Allow decorator API to accept HOC-style wrappers

As per @shilman in https://gist.github.com/shilman/792dc25550daa9c2bf37238f4ef7a398:
We are moving to a "wrapper" style API for addons/decorators:
type story = (context) => renderable
type wrapper = story => story

Which can be used like:
.add('name', aWrapper(() => <story/>));

However, currently the decorator API takes something slightly different:
type decorator = (story, context) => renderable

It's conceptually the same, but different in practice.
Proposal:

In 3.3: Allow addDecorator to take both decorator and wrapper style functions.

In 3.4 (or sooner): deprecate the decorator style.

In 4.0: only allow wrappers.

Implementation.
Decorators are applied (in each app layer) in a line like this:
const fn = decorators.reduce(
  (decorated, decorator) => context => decorator(() => decorated(context), context),
  getStory
);

However, we can inspect the output of decorator(...) and see if it's

A renderable (an React Element or an object in vue). (the old decorator case)
Another function (the new story). (the new wrapper case).

In case 2, we can then just execute it.
So the new code looks like:
const fn = decorators.reduce(
  (decorated, decorator) => context => {
     if (decorator.length === 2) {
       // old case
       return decorator(() => decorated(context), context);
     }

     const newDecorated = decorator(() => decorated(context));

     // new case
     if (typeof newDecorated === function) {
       return newDecorated(context);
     }

     // old case, decorator doesn't consider context
     return newDecorated;
  },
  getStory
);

Phew! Confusing. But I think it works.

Yes, confusing as a transition path, but hopefully simple and uniform and powerful once we get through it! Thanks for putting this together!


scExpression Prod QA - Firefox filtering funkiness

Steps to reproduce:

Firefox
https://cellxgene.dev.single-cell.czi.technology/scExpression
Homo Sapiens, lung, genes: LAP3, CD99, AOC1, CTFR, SARM1
Ethnicity: African American

Notice blue box shows up around ethnicity filter.

Hmm can we got a screenshot or video/GIF please? I can't repro with Firefox locally 😆 Sorry!
Note that the blue box should show up when you use keyboard tabbing, since that's part of the a11y web standard. But it shouldn't show up if you select ethnicity filter using mouse click!
Thank you!

@tihuan it is happening to me on mouse click. See here https://images.zenhubusercontent.com/228681195/6ad1f4e7-8d13-452f-9a6a-006af6751cf9/firefox_filter_.mov

@hthomas-czi did you have anything additional to add here?

@tihuan it is happening to me on mouse click. See here https://images.zenhubusercontent.com/228681195/6ad1f4e7-8d13-452f-9a6a-006af6751cf9/firefox_filter_.mov

HMM! This is so weird 😆 I cannot reproduce 🤔
What's your Firefox version? Mine is the latest (v99.0)

@signechambers1

@tihuan ack i thought i was on the latest version but just updated and now i cannot reproduce! so sorry. closing.

Awesome thank you so much for confirming 🚀 !!


[Backport opendistro-1.12]Replace legacy template with index template (#1372)

Backport #1359 to opendistro-1.12

@cliu123 This change was backported to opendistro-1.13 and opendistor-1.11, but not to opendistro-1.12. I opened up a PR to backport it to the opendistro-1.12 branch.

Closing this PR for now. I do not have permissions to change the required checks on this old branch. This branch is not in sync with other opendistro branches and will remain different.


I need this for windows 10 is there a good alternative?

Wait I found a good one https://github.com/LGUG2Z/komorebi


Update to 100.0.0

Need to update app to ArcGIS Android 100.0.0.

[ ] Branch 10.2.8
[x] Merge beta branches to master
[x] Version/Tag release

Master branch is v100 and tagged.  10.2.8 release is tagged as well, branch will be removed.


Streaming modmail messages

The docs for modmail conversation streams say that they "[y]ield unread new modmail messages as they become available." However, they in fact yield new conversations.
Documentation aside, it would be nice to have a way to stream new messages as they come in.
System Info

OS: Ubuntu 20.04
Python: 3.8.2
PRAW Version: 7.0.0

What happens if you set state to inprogress?

Sorry, to clarify - when I say "new conversations," I'm not referring to the "new" conversation state. I'm just referring to conversations that are entering the stream for the first time. The issue is just about yielding messages vs. yielding conversations, regardless of which conversation state we're trying to stream.

Oh I see what you're saying now, sorry. I wonder if it could iterate all the states and then yield the new messages for each conversation for each state. I'll take a look.
Regarding the documentation, that was my bad on the wording. If you want, you can open a pr to fix it or I can it doesn't matter to me.

I think distinctions between states are orthogonal to this issue. If people want to see everything in the inprogress, new, and notifications states, they can just stream all, which is what they would have to do already in the case where they're streaming conversations. If they're also interested in mod conversations or whatever, then they're out of luck, but that's just a special case of #1513 .
I'll make a doc feature.

any progress on this?

What do you mean? This issue was referring to a documentation mistake.


added support for custompath for bufficons

for https://github.com/wurstscript/WurstStdlib2/issues/187

That doesn't rly change the buff issue?

why not?

createDummyBuffObject uses setIcon and you cannot access the buff object afterwards?

ah yeah, its cause i have custom function for createDummyBuffObject ,  not sure if you want to have another function for createDummyBuffObject  with overloaded paramters

Which is why I suggested the solution I did.

Yeah I know, just thought its not that clean. I mean its just a note, the whoel thing is not a big problem at all.

Sure.
function setIcon(string name) should just reference the new one then tough.

Not sure if you want to have it in a configurable member, or just as it is now, I do not really care^^

I think it's fine, but should be added to hotdoc and perhaps other places? 🤧

will you add this feature to the function's hotdoc?

yeah sure, sry was away a few days

Alright, this can't hurt imho. 👍


Small readme updates

Couple of small updates that came to mind while reading through the main readme.  Also updated examples/adder/adder.py to match the code in the readme.

@petergrossmann21 sounds good, just made those updates


Support for ILifetimeScope in addition to Container

The single way provided by Autofac to add new components after the container is built is by creating a new LifeTimeScope.
-> The use case is: build the container -> BeginLifetimeScope + additional registration -> test if the new registrations are in the new LifetimeScope.

Hi @RwSgxx , thanks for reaching out. Can you provide an idiomatic example on how the Api should look like?
If i understand correctly, your suggestion is adding/moving the already existing assertions from IContainer down to ILifeTimeScope so that something like this would be possibel
var myInstance = Substitute.For<IDisposable>();
using var scope = container.BeginLifetimeScope(builder => builder
    .RegisterInstance(myInstance).As<IDisposable>());
scope.Should().Resolve<IDisposable>().As<IDisposable>();

Sounds good!

Closed due to inactivity.


Awesome-book-plain JS with objects

implement all requirements
-Implement only a basic UI with plain HTML
-Create a collection that keeps a list of books
-Create a function to add a new book to the collection, with title and author.
-Create a function to remove a book from the collection
-Display all books saved in the collection in the top part of the page.
-Make sure that when a user clicks the "Add" button:
-A new book is added to the collection.
-The new book is displayed in the page.
-Make sure that when a user clicks the "Remove" button
-The correct book is removed from the collection.
-The correct book dissapears from the page.
Make sure that data is preserved in the browser's memory by using localStorage

Hello @fithamlak, since all the linter checks are now passing, I will proceed with your review


Question: Adding attributes to node via JSON data. TypeError: 'Node' object does not support item assignment

I am trying to assign to a node attributes looping through the key values of a JSON data.
but I get the following error:
 new_node = ipycytoscape.Node()

...
...
        # rest of the elements
        for key,value in json_row.items():
            new_node[key] = value.  # this is line 52

---> 52             new_node[key] = value
     53
     54         ipycytoscape_obj.graph.add_node(new_node)

TypeError: 'Node' object does not support item assignment

If I have data in JSON how can I assign this data to the node (to add later on to the ipycytoscape object)
Note: I am working on the pandas data frame implementation as I mentioned in:
https://github.com/QuantStack/ipycytoscape/issues/128#issuecomment-734487703
and originally in:
https://github.com/QuantStack/ipycytoscape/issues/149#issue-688554574

Hum... I think for this kind of user case you'd have to create a custom node @joseberlines.
I think @MridulS wrote an example of this at some point? You were doing something really similar to this right? @ianhi may know what I'm talking about.

@joseberlines are you trying to assign attributes that should be synced to the frontend or just generic attributes of the object? for the former everything that the frontend can handle is already present on the object. For the latter you can do something like set_attr(new_node, key, value)


UIHostingConfiguration

Any plans to backport UIHostingConfiguration added in iOS 16 would be great for the beginning to configure cells with SwiftUI.

I haven’t looked deeply into the UIHostingConfiguration yet but I imagine that might be difficult to backport actually. It requires a lot more understanding and access (I think) to the underlying SwiftUI components. But I’ll definitely explore it.
As for Lazy Stacks, its not obvious how best to achieve this, however I am looking at alternatives. For example I think it might be possible to provide a backport fo the new Layout APIs which would potentially open the door for creating this kind of thing, as well as any other layouts.
My other idea was to create a new type (not a backport) that wraps UICollectionView and provides a really nice SwiftUI API that would enable lazy stacks and other implementations. I’ve actually been working on this one prior to WWDC so I may explore this a little more. The API is really nice and its quite promising. This would be a separate library of course, but I’ll let you know when I’ve explored this a little more 👍🏻.

I'll strikeout the above as I completely mis-remembered what UIHostingConfiguration was.
I did actually see this mentioned at WWDC I recall now, and its pretty nice to make it easier for UIKit users to bring SwiftUI into their code. However, that's not exactly the purpose of this library. This feels more like I'd be back porting UIKit in order to support this.
That being said, I am (as mentioned above) working on something related to UICollectionView that does require me to wrap SwiftUI view's in cells. So if there is even a lightweight version of this that could be useful in this library, I'll include it and let you know 👍

Good news @K1NXZ, I managed to get most of this working already. I have intentionally left out much of the UIContentConfiguration APIs since they're only useful if we also backport the whole iOS 14+ API they introduced for configuring cells, which would be a lot of effort.
But I think this still provides a useful and familiar API that should make it just as easy to integrate SwiftUI into cells.

I will test this more thoroughly for a while, but it's looking quite promising. If you have time, I'd love if you could test it out on the branch hosting

Its looking good so far 👍

Merged and released #6 – v1.1.0

Looking great! Unfortunately I didn't have time to test it out yet. I will look into it ASAP.

Looking great! Unfortunately I didn't have time to test it out yet. I will look into it ASAP.

Just tested it, its working pretty well! Good job.

Good to hear! Any issues please raise so I can take a look. Thanks!

@shaps80 do you know how easy it would be to get this working with UITableViewCell too?

@shaps80 do you know how easy it would be to get this working with UITableViewCell too?

@lukeredpath I don't imagine it's very different at all. If you 'copy' the existing implementation I've provided for collection view you are welcome to contribute to the library.
I will eventually get around to it myself, but I don't have time atm.


Running PIGPIO on the new CM4

Is it an easy feature to add? Right now we get the error "Sorry, this system does not appear to be a raspberry pi. aborting." when running it on the new compute module 4.

My fault. Cloned the repo instead of apt-get. Now it starts, did not pass all the tests though.

My fault. Cloned the repo instead of apt-get. Now it starts, did not pass all the tests though.

For reference to other facing the same problem, cloning and compiling from v1.78 source works.
I tried installing 1.71-rpt from apt. Prompted the same Sorry, this system does not appear to be a raspberry pi. aborting. message.

Another note: apt-get install python3-distutils if make install threw ModuleNotFoundError: No module named 'distutils.core' when installing pigpio to python3


Tasks print "Terminal will be reused" even when presentation.panel set to "new"

VSCode Version: Code 1.16.1 (27492b6bf3acb0775d82d2f87b25a93490673c6d, 2017-09-14T16:26:20.018Z)
OS Version: Linux x64 4.13.4-200.fc26.x86_64

This is just a little nitpick. When running a task with
	"presentation": {
		"panel": "new"
	}

the terminal prints
Terminal will be reused by tasks, press any key to close it.

But that terminal will never be reused as I've disabled that in my tasks.json.

To verify under Windows. Tasks.json
{
	// See https://go.microsoft.com/fwlink/?LinkId=733558
	// for the documentation about the tasks.json format
	"version": "2.0.0",
    "windows": {
        "options": {
            "shell": {
                "executable": "${env:windir}/System32/WindowsPowerShell/v1.0/powershell.exe",
                "args": [ "-NoProfile", "-ExecutionPolicy", "Bypass", "-Command" ]
            }
        }
    },
	"tasks": [
		{
			"label": "dir",
			"type": "shell",
			"command": "dir",
			"presentation": {
				"panel": "new"
			},
			"problemMatcher": []
		}
	]
}

When executed the terminal prints
Press any key to close the terminal.

If I have a watch task, and kill it with ^C, it still writes "Terminal will be reused by tasks..." in this case. Is that by design?

@roblourens no it should not. Will reopen and have a look.

I retested it and it write Press any key to close the terminal. to the terminal which is expected. I will close the issue again.

The complaint is that the message should NOT be there.

This message is by design. Why would you not see it.

It is a problem for me to, because I would like to have some command to be executed with a shortcut key, so will busy, just type the key combination and go on. This way I have to close the terminal every time while the purpose was to automate tasks.

@NathanUr then you should not use 'new'. If you always want to use the same terminal simple use 'dedicated'

Long time reader first EVER GitHub comment so apologies in advance.
I would like to suppress (perhaps optionally) the terminal message(s) "Press any key to close the terminal." / "Terminal will be reused by tasks, press any key to close it." etc. for the following reasons:

Mixing a user's program’s output with the IDE’s output is inappropriate and like a "Separation of Concerns" issue.
Particularly in the cases of "panel": "shared" and "dedicated" the user has indicated the intent to continue to use the panel in the future. Hence a reminder to close then panel does not match the users intent i.e. use case.
It is redundant as there already is a "Trash Can" icon at the top of the terminal window to perform the same function.
There are many keyboard shortcuts in the IDE but apart from menu items, very few have a full sentence dedicated to them to remind the user i.e. not consistent with the rest of the IDE’s interface
"version": "0.1.0" of tasks.json did not have this behaviour.
Other people see https://stackoverflow.com/questions/47946868/how-to-get-rid-of-terminal-will-be-reused-by-tasks-press-any-key-to-close-it

Possible solutions:
a) Turn-off reminder message(s) completely – my preferred solution.
b) Turn-off reminder message(s) for "panel": "shared" and "dedicated" use cases - a compromise.
c) Add option to suppress reminder message(s) in the "presentation" group of tasks.json - flexible but adds unnecessary complexity.


fix: proper collapsing of long element

Motivation
There seems to be a regression after #5146
At least probably on sidebar items with large children the collapsing transition does not complete correctly.
You can see this now on the Redux site if you click on "Using Redux" in sidebar.  https://redux.js.org/introduction/getting-started

Actual
Expected

This is due to the fact that initially scrollable element height via scrollHeight is not calculated correctly with overflow:hidden. I don't really understand why this happens on some elements. For example, on the Docusaurus site this bug doesn't reproduce (https://docusaurus.io/tests/docs)
So in order to get a consistent behavior, we don't need to check collapsible element height after completing transition. However, considering that in #5146 we introduced extra requestAnimationFrame call, this will still mitigate issue with multiple clicks.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Try to apply this patch to Redux site locally.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Hey
I'm not sure to understand how to reproduce or test this fixed the Redux doc issue.

Redux is not using beta.6/canary, can this be reproduced with latest?
What I see is that the scrollbar is covered by some white rectangle, so this doesn't seem related to the collapsible component to me

Related to #5254? Would that be properly fixed... or is it only fixable with scrollbar-gutter?


[Rating] clearing rating is not possible with keyboard

On Rating component, you can clear (set rating to 0) by selecting same rating twice using pointer.
Setting rating to 0 is not possible with keyboard usage

[X] The issue is present in the latest release.
[X] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
On Rating component, you can clear (set rating to 0) by selecting same rating twice using pointer.
Setting rating to 0 is not possible with keyboard usage.

Expected Behavior 🤔

There is some way to clear rating using keyboard
Steps to Reproduce 🕹

https://codesandbox.io/s/nhstb?file=/demo.js:224-279
Steps:

Focus rating element by tabbing to it
Try to set rating to 0

Context 🔦

Your Environment 🌎

`npx @material-ui/envinfo`
  Don't forget to mention which browser you used.
  Output from `npx @material-ui/envinfo` goes here.

In the initial design of the component, the cleared state was only supported as an initial state. Later on, we added the click twice to clear interaction. I guess we could follow follow the direction proposed in this issue.

I would propose the following diff:
diff --git a/packages/material-ui/src/Rating/Rating.js b/packages/material-ui/src/Rating/Rating.js
index 34d70255fb..263e633bc2 100644
--- a/packages/material-ui/src/Rating/Rating.js
+++ b/packages/material-ui/src/Rating/Rating.js
@@ -441,17 +441,18 @@ const Rating = React.forwardRef(function Rating(props, ref) {
           checked: itemValue === valueRounded,
         });
       })}
-      {!readOnly && !disabled && valueRounded == null && (
+      {!readOnly && !disabled && (

           <input
             value=""
             id={`${name}-empty`}
             type="radio"
             name={name}
-            defaultChecked
+            checked={valueRounded == null}
             className={classes.visuallyHidden}
             onFocus={() => setEmptyValueFocused(true)}
             onBlur={() => setEmptyValueFocused(false)}
+            onChange={handleChange}
           />
           {emptyLabelText}

```

For the test, if the available testing-library fire event API isn't enough, we can leverage the work @eps1lon did in #25405.

Ideally we'd have an API that allows for various input methods to clear the Rating. Adding an extra button is the most obvious affordance but might be considered too excessive if targetted at power-users. Backspace or Del for clearing a rating might also be an idea (just guessing here. needs UX research). If we can show both affordances in a demo that'd be perfect :+1:

@eps1lon Backspace/Del sounds great. Should it replace the approach of allowing an empty radio option in the keyboard navigation (the diff that https://github.com/mui-org/material-ui/issues/25533#issuecomment-808889153 implements)?

I'm not that familiar with the implementation and I don't think we should discuss the implementation in an issue. The problem we're trying to solve is how an affordance for clearing might look. Not how we implement it. That should be decoupled generally and discussed in the actual PR.

@eps1lon I meant Should we allow an empty radio in the keyboard navigation as in https://www.w3.org/WAI/tutorials/forms/custom-controls/#a-star-rating?

@eps1lon I meant, Should we allow an empty radio option in the keyboard navigation as in w3.org/WAI/tutorials/forms/custom-controls/#a-star-rating?

That is what I'm referring to. We should make it possible to either add an affordance via an additional button or make it possible via custom keyboard shortcut.