DISCUSSION 1: ObserverSpy API - Methods vs getters

Following #12 by the amazing @ThomasBurleson we had a discussion and realized this PR could be separated into several PRs, and before that we need to discuss them.
This discussion is about the possible changes to the ObserverSpy API to make it more "getters" focused.
The suggested API changes to ObserverSpy -

private _state: ObserverState<T> = {
    values: [],
    errorValue: undefined,
    called: {
      next: false,
      error: false,
      complete: false,
    },
  };

get state(): ObserverState<T> {
    return {
      ...this._state,
      values: [...this._state.values],
    };
  }

  get values(): T[] {
    return this._state.values;
  }

  get hasValues(): boolean {
    return this._state.values.length > 0;
  }

  get isComplete(): boolean {
    return this._state.called.complete;
  }

  readFirst(): T | undefined {
    return this.hasValues ? this._state.values[0] : undefined;
  }

  readLast(): T | undefined {
    return this.hasValues ? this._state.values[this._state.values.length - 1] : undefined;
  }

The upsides (IMO) -

Read only values (that's a good idea to implement regardless of the api)

Reduces the need to call a method which might make it shorter and more straightforward to read the state of the spy

(probably more that I'm missing...)

The downsides (IMO) -

State object usage might make the expectation longer and requires remembering more of api.
For example:

expect(observerSpy.state.called.next).toBeTruthy();
// VS
expect(observerSpy.receivedNext()).toBeTruthy();

// AND

expect(observerSpy.getError()).toBe('OMG AN ERROR!');
// VS
expect(observerSpy.state.errorValue).toBe('OMG AN ERROR!');

I prefer to reduce the nesting, so If we'll decide to go for getters, I would suggest flattening the api of "state" to exposed from the root, something like observerSpy.errorValue etc)

Intuitively (for me), methods feel (at first glance) more "Read only" than properties, but maybe it's just me.

It's true that with TypeScript you'll see a compile time error if you try to assign values some other value, but with JS you'll get a run time error which is no fun.
It might be tempting for developers in some scenarios to try and do observerSpy.values[2] = 'some other value';, but then again, maybe I'm wrong here.

Because this is a BREAKING_CHANGE, I wanted to get as much opinions as possible about it, before we decide whether we should break it into it's own PR.

Well, that's a very interesting suggestion!
I like that the new API approach clearly hints that spy instances are stateful. That might benefit the readability of test specs where you want to go beyond checking basic behavior.
Maybe it would be helpful here to consider where this library will be heading to. What's your vision @shairez ? 🤩
If ObserverSpies should someday evolve to a comprehensive scheduler-free alternative to marble-testing, I would move forward with the new API suggestions.
Right now, I use ObserverSpies more like a supplement to marble-testing and like the simplicity of its API. That's why I rather prefer the current way of exposing only methods with prefixes (is/has/on/get). Each method has its decisive intention, and it feels somehow more consistent.
But that's just my opinion. I'm curious to see what's next. And if there is anything I can help with, let me know!

Thanks @katharinakoal for your feedback!
My aim for this library is to keep it small and simple.
That's why I like a more flattened API (vs nested).
And that's where Thomas wanted to take this library too - towards an API he believes is better and simpler than the current one.
I actually didn't plan to replace marble testing, just to make 90% of the every day app use cases easier to test :)
The question in this issue I believe comes down to - which is better - .getValues() or .values (and the rest of them)
I'm trying to find reasons other than "I like this style better because I'm used to it", but to actually show how it is saving time while reducing confusion.
So maybe something like "In the following test, look how this api is much cleaner and clearer" (followed by a code example)
I know my experience is just one man's experience, so I try to incorporate as many perspectives as I can to make sure we have an API that covers as much use cases while keeping it elegant and small.

Hey Guys!

Regarding the usage of methods or getters, I think it's a matter of preference. If we take a look at Sinon.JS, we'll see that most of its API are methods. One benefit of using methods is that they're scalable to changes without introducing a breaking change. For example, they can take additional parameters.
IMHO the API should be simple and thin. Most of the usage will be to check the current value that was emitted.

Good points @NetanelBasal !
Thanks for sharing your feedback 🙏

Hey everyone!
+1 for flat in favor of nested.
Concerning properties vs methods, I like how properties are shorter... but even if we ignore extensibility by adding parameters, the problem we get is the inconsistency between using props for values and methods for things like getValueAt().
I think that the most important thing here is consistency. For instance, hasReceivedNext() & getValues() vs receivedNext() & values().
I generally prefer the latest as it's shorted but we have to make sure that we'll never use any properties to be the least surprising.

Appreciate the feedback @yjaaidi !
I agree with your points and also that shorter is better, though getValues() feels better to me than values() (maybe it's a matter of being used to it or something)

Finally I had some time to get back to these issues 😅
I'm closing this issue as it seems like the majority thinks it's better to stay with methods.
Thanks everyone for participating!
BTW, You can view the latest release with @ThomasBurleson 's improvements here -
https://github.com/hirezio/observer-spy/releases/tag/v1.4.0


Problem: Cronos paymaster is facing "Touched unallowed storage slots" error

Solution:
Add the unallowed slot in the trusted token slot list

closing because not needed anymore

reopening because we are still facing the issue


Simultion -> Selection : context is in wrong div

The context view is not in the correct div.

The issue is still present; however, just the selected flow is outside of its div.


Fix copyright years

@yegor256
Studying the details of the project, I noticed that despite the fact that a check for years in the file copyright was added, there were still files with incorrect copyright, I suggest that you fix it
These files:

fixtures/jaxec/src/main/java/com/yegor256/Foo.java
fixtures/jaxec/src/main/java/com/yegor256/Jaxec.java
fixtures/jaxec/pom.xml

Original issue https://github.com/yegor256/cam/issues/189 and fix from PR https://github.com/yegor256/cam/pull/305

@yegor256
Please see PR #315

@yegor256
I solved this issue, details inside the same PR #315

@yegor256
Close this issue because PR #315 was merged


Azure Resource Graph queries in the runbook disregard hybrid compute details

The Azure Resource Graph queries filter specifically on type == 'microsoft.compute/virtualmachines/patchinstallationresults', however as a result you disregard all results coming from for example the type microsoft.hybridcompute/machines/patchinstallationresults.
You could change it the query to use :
patchinstallationresources
| where type == 'microsoft.compute/virtualmachines/patchinstallationresults' or type == 'microsoft.hybridcompute/machines/patchinstallationresults'

However this might bring in problems in the future if additional types are added. You are maybe better of with this:
patchinstallationresources
| where type endswith '/patchinstallationresults'

Thank you for the feedback @rvdhooff! checking now.

Fixed using @rvdhooff recommendation.


Cross-browser support

Feature Request
-->Will there be cross-browser support provided by Puppeteer?

@AmanDhembla there's an experimental Firefox support: puppeteer-firefox


stochastic adapter: fix infinite loop when run with -from :beginning:

Since :beginning: is actually an infinite moment, stepping forward ended up
causing an infinite loop.
Add a fix for this by explicitly checking for -from :beginning: and
implicitly converting it to start at the epoch instead.
Partially addresses #31.

@dmehra or @mstemm thoughts on this?

lgtm!

Late to the party but wondering whether it wouldn’t be better to disallow :beginning: here.
@bkutil What do you think?

Considering that JuttleMoment accepts negative arguments and 0 doesn't actually correspond to ':beginning:' (only to a certain interpretation of it), the choice seems kind of arbitrary.
If we'd want this to emit points, I'd suggest putting here a JuttleMoment w/ the smallest date parseable by Date - a beginning in the JS sense. Maybe JuttleMoment should itself define that - -8640000000000000 as a constant.
Otherwise, like @dmajda suggests, disallow :beginning: and just throw an error.


Added filename match type to download assertion

I was currently testing downloads for my application and I thought it was a good idea to test the name of the downloaded file as well. The assertDownload function however just checks whether the filename is exactle the same as expected. However, there might be functionality to lock to a given time but that's weird testing in my opinion.
In my case, I'm generating file names containing a username and the current date and time like someuser_2024-05-28_20-51-16.json. If a test for some reason takes a bit longer than expected, the exact check of a filename doesn't work anymore if the current time second had changed.
For this reason, and there may others, I've added a functionality to check whether the filename starts or ends with a given string. The original exact check is still present.
There're three checks by default:
exact: As before and default value
startsWith: To check whether the filename starts with the given string
endsWith: To check whether the filename ends with the given string
Example with filename someuser_2024-05-28_20-51-16.json and current time of 2024-05-28 20:51:16:
->assertDownload('someuser_'); = false
->assertDownload('someuser_', 'startsWith'); = true
->assertDownload('someuser_', 'endsWith'); = false
Example with filename someuser_2024-05-28_20-51-16.json and current time of 2024-05-28 20:51:17:
->assertDownload('someuser_'); = false
->assertDownload('someuser_', 'startsWith'); = true
->assertDownload('.json', 'endsWith'); = true

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Change Dockerfile syntax not to match "as" out of context.

AS is only a keyword when used as FROM image AS alias, but the current syntax matches it anywhere not already matched, including inside of words. (For instance, it maches as in RUN chpasswd.)

Please contact the syntax file maintainer.

I did. He asked me to open an issue; I thought that opening a pull request would be simpler, since I had a proposed patch.

If the maintainer is available, that one should send the patch. This avoids that the original and the version included with Vim drift apart. If random people start sending in patches, even when the maintainer says it's OK, I don't know what the right version is.

I am having this same issue so I set off to find the proper upstream for this file. I believe it is now unique in Vim.

If I understand correctly, the maintainer listed in the comments of this file is @honza.
They have a repository that looks similar, but the contents differ from Vim's:

https://github.com/honza/dockerfile.vim

That repository also contains a link to a Moby repository, but those contents differ from Vim's and @honza's:

https://github.com/moby/moby/tree/master/contrib/syntax/vim

@honza, is there a canonical upstream that you recommend?

Let's make a decision on where the canonical version should live. What do you think makes the most sense?
In my mind, the editor-supplied version should be canonical. You install the latest version of vim, and vim already knows how to properly display Dockerfiles. If this makes sense, then I'd add a note to my personal repository saying it's been integrated upstream (i.e. vim), and perhaps even archive the repo. I could also propose to the moby project that we direct their users to the vim-supplied version.

Here is what I have done:

New PR to moby to remove dockerfile syntax from their tree https://github.com/moby/moby/pull/40354
Archived my original dockerfile.vim repository and added a note about the new upstream https://github.com/honza/dockerfile.vim/commit/b8c574928e503c0e94ad06647cff28b7c566af29

Does that mean, you are no longer maintaining that file?

Maintaining project code in the project's code repository and utilizing the features provided by Git (e.g., merge commits) and GitHub (e.g., pull requests, issues, assignment of responsibility) seems better to me than having each maintainer manage an authoritative copy elsewhere and mail in the latest version to Mr. Moolenaar for manual inclusion.

that was not the question :)
The principle is a bit like for the subsystem maintainers of the linux kernel. They control what seems reasonable for each subproject before they send a PR to Linus. It's basically the same here. We don't have the knowledge to know each and every language to such an extent that we can review the PRs. So we depend on maintainers that send changes for inclusion with Vim and that can better handle the decisions whether a certain change makes sense or not.
The process as it currently is, has been proven to work well, even for people/maintainers that do not know (or do not want to know) git and even long before the existence of git.
Now we can of course change the process and add even more burden to @brammool but I am not sure that is helpful :/

Does that mean, you are no longer maintaining that file?

I'm happy to stay on as the maintainer within the vim project. I think my role will be more in the code review sense as @brammool is ultimately responsible for merging code. This means that the community will play a larger role. I'm not 100% sure what the preferred method is: I'm, however, happy to use both the GitHub workflow, and the git-send-mail workflow.

Vim files have been removed from moby. I'll work on reviewing pending patches here.


bug(GPU): nvidia-container-toolkit CVE

What version of the AMI has this CVE fix included for the nvidia-container-toolkit?
https://nvidia.custhelp.com/app/answers/detail/a_id/5582

Our last release is dated 9/24, the disclosure happened on 9/25. So not yet.
There's support in this repo for building the AL2023 GPU AMI(s) https://github.com/awslabs/amazon-eks-ami/pull/1924 if someone is in a rush.

Thanks, I'll expect next release to have it then (not on 2023 yet)

@sidewinder12s v20240928

closing this wi


Response endorsed state indication enabled

Fixes MA-2088
Indication enabled on the following screens:

Responses Screen.
Add Comments Screen.
View Comments Screen.

Responses
Add Comment
View Comments

@1zaman @BenjiLee plz review

Is this the same method that generates the "Answered" tag?

Is this the same method that generates the "Answer" tag?

Yup.

Other than a few nits 👍

:+1:


Storage needs to be above threshold value

@andresnava : Thanks for your contribution to the Azure documentation! The author, @rachel-msft, has been notified to review your proposed change.

@andresnava I think the original is correct. The alert will trigger once the given threshhold is reached (condition becomes true), then again when the condition becomes false. On/Off kind of thing.

#please-close


[WIP] - Fix Travis-CI build

Travis-CI has updated their YAML spec. Now, it's possible to define an "addon" and not use before_install which was causing the build to crash due to not finding flvtool2 in the ubuntu repository
Fixes #955

Actually, it seems that this line allows this to pass ...
https://github.com/fluent-ffmpeg/node-fluent-ffmpeg/blob/9cc9c4998d8f48414fbba19696f7f1afe6912dd9/test/capabilities.test.js#L536

Okay, gem install flvtool2 during before_install does successfully install flvtool2


Fixing form labels on GitHub index page

Adding IDs to the example input elements so that the labels work correctly for them

Thanks for doing this. I think you have a small typo in the password_confirm input. Can you fix this quick and then I will merge.

Ah, good eye. Fixed and actually previewed this time -- just wanted to get the point across before. Looks okay now.


Support extended room names

The fosdem schedule has a number of rooms with more than word, ie "K.1.105 (La Fontaine)" or "H.1302 (Depage)" and some of the commands were splitting the input args such that the second part of the name was being cut, meaning that the commands were unable to find the rooms.
This PR adds support for rooms with more than one word in them by changing how the args are parsed when the commands are run.
The other option for fixing this would be to strip all the rooms as they are parsed/stored - I considered that as well but this seemed faster - happy to change course if it's incorrect.

just as a note of interest, in previous years (or at least last year) these were 'slugified' into k1.1.05_la_fontaine etc or something like that and you'd refer to them by slug.


Implement player count setting

Closes #758, closes #751, draft as based on #661.
Implements a "total player" setting, instead of a "CPU count" setting, to avoid weirdness when interacting with multiplayer.
This also re-removes the CPUMode::None setting, as multiplayer can simply set the player count to the number of local players, or less, allowing it to supersede #841.

should this be called "total racers" instead? since i feel like "players" implies human players not CPUs
also "The minimum player count, padded by CPU players." why is it "minimum" isnt it total? and maybe im being weird but I feel like padded is a weird term. Maybe simpler to say "Total number of combined CPU and human racers"

"Minimum" is likely a reference to the fact that it's the lower bound of local players and total players.
"Racer Count" is a good name for the setting, and I think the description can be e.g. "Guarantees at least __ racers in a race."

"Minimum" is likely a reference to the fact that it's the lower bound of local players and total players.
"Racer Count" is a good name for the setting, and I think the description can be e.g. "Guarantees at least __ racers in a race."

ah yes, this is good way of phrasing it

Yeah, it's minimum as the setting could be set to 2 but with 4 local players, it would still have all 4 local players. That name and description does sound saner though.

Actually, looking at it, I'd have to duplicate the description 12 times to name the player count, or implement new logic in the settings system which I am very adverse to doing.

Actually, looking at it, I'd have to duplicate the description 12 times to name the player count, or implement new logic in the settings system which I am very adverse to doing.

I think there's a way to format the string with a numerical value.

Sure, but as I said, I'd then have to mess with the settings system for one setting.

Before anyone criticizes "Gamer Count", I would like to redirect blame to Vabold who came up with the idea and repeatedly told me in DMs to commit it.

Before anyone criticizes "Gamer Count", I would like to redirect blame to Vabold who came up with the idea and repeatedly told me in DMs to commit it.

Strange, I don't remember any of these DMs.
We can use "Player" due to the consistency with teams.

Fixed conflicts and comments.

Do we want to use "racer" and "player" separately? I'd like to hear more opinions before merge.

imo racer should be both human and CPUs, whereas player is just humans (since nintendo will refer to people as player 1, player 2, etc... and on the title screen you select "3P" mode for 3 player local for example)

I think it'd be more natural to use "player" even when not referring to physical humans, e.g. "Player Count" rather than "Racer Count". For instance, when we think of "24 player" mode, we aren't picturing 24 little screens as if the game were for a mosquito.

If I change to player, will this be merged?

I don't see any other issues--unless @MikeIsAStar has something to say.


Add ember-cli >=2.15 as a peer dependency

Addresses https://github.com/alexlafroscia/ember-cli-react/issues/6.

@alexlafroscia One thing to note is that this doesn't seem to actually "enforce" ember-cli >=2.15 during installation. I tried it on an Ember project that's using an older version of ember-cli, and it didn't prevent me from installing it or throw any warnings:
$ ./node_modules/.bin/ember --version
ember-cli: 2.14.2
node: 8.9.4
os: darwin x64

$ ember install file:../peterjmag/ember-cli-react
NPM: Installed file:../peterjmag/ember-cli-react
Installed addon package.

$ ember g ember-cli-react
installing ember-cli-react
  install package react
  install package react-dom
NPM: Installed<EMAIL_ADDRESS>NPM: Installed<EMAIL_ADDRESS>
Probably not a huge deal though — I imagine it's enough that it's called out in the README and in package.json, but let me know what you think.

If you run yarn (or node install) after adding it with the peerDependencies change, does it show a warning? I would expect it to... That'll certainly help. I don't believe either NPM or Yarn throws an error with incorrect peer dependencies these days, since you can end up fulfilling peer dependencies indirectly, but they should generate a warning.

Also, I've been using the "conventional commits" pattern for commit messages on this project -- would you mind changing you commit message to something like:
fix: add ember-cli >=2.15 as a peer dependency

Ah you're right, it does log a warning on subsequent runs:
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

And from yarn:
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>
I think that should suffice! 👍

Excellent! Thanks for helping with this 😁


Uncaught TypeError: webpack_require(…).context is not a function

Bug report

What is the current behavior?
When I am trying to import dynamically vue components using this code:
const components = require.context('./', true, '/^index.js$/');
I am getting this error:
app.js:9 Uncaught TypeError: webpack_require(...).context is not a function
at Module../asset/app.js (app.js:9)
at webpack_require (bootstrap:782)
at fn (bootstrap:150)
at Object.0 (app.293d5fe1d8a073fed37a.bundle.js:1747)
at webpack_require (bootstrap:782)
at checkDeferredModules (bootstrap:45)
at bootstrap:858
at bootstrap:858
Why is that? How to fix that? What have I missed?
If the current behavior is a bug, please provide the steps to reproduce.
Just open your empty js-file and add next line of code:
const components = require.context('./', true, '/^index.js$/');
The error which I was getting is located in the browser console.

What is the expected behavior?
The expected behavior is an absence of error. I have read the documentation and did everything as was wrote in the documentation.

Other relevant information:
webpack version<EMAIL_ADDRESS>Node.js version: v11.15.0
Operating System: Linux, Debian
Additional tools:

Please fill all fields in issue template

I have updated some info.

I have done a mistake. I have wrote:
'/^index.js$/'
but it should be witout quotes:
/^index.js$/

I also experienced this issue when using a variable as the first param.
FAILED
const path = './path/';
const components = require.context(path);

WORKING
const components = require.context('./path/');

Any explanation as to why this may be?

@minlare I just had the same issue. I was trying to pass the path via variable, but received the above mentioned error.
The trick is that the path parameter must be a literal.
And as far as I understand how the compiler works, the path must be a literal regex, because the compiler has to find these files to add them in the compiled code, as JavaScript doesn't have access to the file system.
Passing the path via variable wouldn't work, because the compiler can't know what kind of path will you give him and can't prepare the required files during compile time.

Thank you for explain the problem @papa-zulu , I getting this error too and I was trying to understand why.

I've just hit this same error, but I don't completely agree with the @papa-zulu given explanation, because - although I don't know Javascript very much - this works:
let ctx = require.context('.', true);

while this doesn't:
const x = true;
let ctx = require.context('.', x);

and in both alternatives the path is a literal.

I was resolve the error with this stack overflow answer.
https://stackoverflow.com/questions/74823633/testing-after-angular-15-update-throws-error-webpack-require-context/74886791#74886791

I was resolve the error with this stack overflow answer. https://stackoverflow.com/questions/74823633/testing-after-angular-15-update-throws-error-webpack-require-context/74886791#74886791

This also resolved my issue after I upgraded to 15.


Corrupted file system

Hi, I'm using LittleFS on an STM32F7 microcontroller along with a Quad SPI NOR Flash chip from micron all on a custom board. While doing some probing of the various signals between the 2 ICs, there was some file system corruption that happened and as a result, an LFS_ASSERT was tripping when trying to write to one specific file. My question is: what can I do to detect file system corruption before it hits an assert?

Hi @dburrell-mio, thanks for creating an issue. Unfortunately, cleaning up asserts on corrupted filesystems is an area of ongoing improvement.
If you still have the info, which line was the assert on that you hit?

Hi @geky I believe it was the assert at line 75 of lfs.c but I've since resolved the issue and didn't document exactly which line it was. It was my code not the LittleFS library that was causing the issue although it was the assert which was causing my system to hang.

Ah, the assert in lfs_bd_read did assert often on corrupted filesystems at one point. I believe his was fixed in https://github.com/littlefs-project/littlefs/commit/4677421ababf7be568d27167a51a211749329400 to return LFS_ERR_CORRUPT.


Unable to fetch pdf from wp content link

Attach (recommended) or Link to PDF file here:
https://ausometraining.com/wp-content/uploads/2023/11/AUSOME-Exploring-Being-Autistic-with-My-Child.pdf?fbclid=IwAR3wTlfpAmXrvVzNzyAjfTK-qs3g6s9xlYoyQ6mCyQaqa460Dr2B5LreTQw_aem_AUEPJPsIRkIDMltxzsSAGBGmSEEmtN1yG7NtN1QgslJ5XtmQwsxEKX-PTePUAxPtAXY

I don't own this document. I have a user that wanted to view this pdf.

Configuration:

Web browser and its version: Arc (Chromium)
Operating system and its version: MacOS
PDF.js version: v4.0.269
Is a browser extension: no

Steps to reproduce the problem:

Visit the official pdfjs demo link
Replace the URL with the one above. You will see the failed to fetch error.

What is the expected behavior? (add screenshot)
Can see PDF
What went wrong? (add screenshot)

https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-xhr


MyApp.Email vs MyApp.Emails in README

I noticed that README is using both MyApp.Email and MyApp.Emails - do you have a recommendation how to name the module? Obviously it's up to the user but I think it would be good to be consistent.
PS one merit of calling it MyApp.Emails is that it won't clash with MyApp.Email schema if one would ever need it (e.g. user could have multiple email addresses)

@wojtekmach As you said it is up to the user to decide.
However I agree with you, I think MyApp.Emails is a better name, and the README.md is indeed inconsistent.
If you happen to have a large number of emails I suggest splitting them by several modules , for example MyApp.CustomerEmails, MyApp.ProductEmails, and so on, always appending Emails to the name of the module.

@wojtekmach @paulcsmith Opened a PR to fix the inconsistency ^


ARROW-11724: [C++] Resolve namespace collisions with protobuf 3.15

Renames our alias to afpb to not clash with protobuf's definition.
Original error:
../src/arrow/flight/server.cc:63:11: error: redefinition of 'pb' as an alias for a different namespace
namespace pb = arrow::flight::protocol;
          ^
/Users/uwe/mambaforge/conda-bld/arrow-cpp-ext_1613940663852/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/google/protobuf/port.h:44:11: note: previously defined as an alias for 'protobuf_future_namespace_placeholder'
namespace pb = ::protobuf_future_namespace_placeholder;
          ^
1 error generated.

@github-actions autotune

The Homebrew formula patch that this PR obviates the need for is removed in https://github.com/apache/arrow/pull/9542


Question marks instead of medals

On Google Chrome I see question marks in the medal display.
In the example image there are medal images for the Gold, Silver, Bronze Podium Places.
The font used is "Source Code Pro", but my local font does not have these Unicode characters.

Thanks for the feedback! I can imagine how this bug would happen.
The extension relies on the font-family of the AoC website itself for consistency, and it is:
font-family: "Source Code Pro", monospace;

The Source Code Pro font does not contain the three medal unicode characters. On my system the monospace font in Firefox defaults to Courier New or in Chrome to Consolas which both do have those glyphs.
@rioj7 What OS are you on? Could you check in Chrome's settings what the monospace font is that Chrome uses? And if you have time, it would be perfect if you also could check if you do have some monospace font that does have the "🥇🥈🥉" (medal) characters. Then I could tweak my plugins' font-family for the medal html elements and insert your font.
Note to self, if really needed, the unicode-range css property may come in handy.

Perhaps Courier New is a decent fallback font after monospace (which defaults to a distro-specific font, I presume?)?

Asked a few colleagues with other OSes but so far not reproducible. I cannot reproduce it on my machine either, not even if I force the element via its style.fontFamily at only Source Code Pro: Chrome on Windows still manages to dig up the medal glyphs somewhere.
Really need a reliable way to reproduce this, or at least some help in testing a potential solution. If anyone cares to chip in, I think opening the dev tools and editing the font-family for medal elements to "Source Code Pro", monospace, "Courier New" or similar 3rd font should get this fixed. If I'd know that it does, it makes sense to change it.

@jeroenheijmans I use Windows 8.1 and Google Chrome.
Something strange, in your first comment you have the 3 medal Unicode characters, 3 days ago they showed as rectangles, now I see medal glyphs. Used devtools and they now show as png images.
I have made a pull request to replace the unicode chars with SVG images (stored in the extension).
With Photoshop I tried every font on my machine but none has the medal glyphs.
In CSS any font named after monospace is ignored because every browser must have a definition for monospace, serif and sans-serif.

Thanks for the PR at #61, much appreciated.
First up, a question: what is the source of the SVG's, and what is the license and copyright status? Are we allowed to add it into this repository under the current license?
 The added complexity comes with risk of breaking other things, while I have no clue yet of how many people are affected. I also don't know how many browser/OS combinations would actually break with using SVGs in browser extensions like this.
Related, I'm no expert at all with extensions and manifests, but do recall that including files and setting proper permissions was a major pain to get right just for the JS alone. I'd happily take this specific risk in november of a year, before AoC starts, but perhaps not halfway through December when the plugin is otherwise running stable. - Related, there's a manifest v2/v3 change going on, and Chrome/Firefox are out of sync here at the moment too.

I'd still hope that if we'd know the root cause (e.g. what the precise font situation is on a machine with this issue), a simpler solution would be apparent. You might be right that monospace must be available in either case, but I think that if a specific glyph is missing then it would still fall back beyond that font in the family? I'd prefer to try that kind of option first, it's a shame though that your OS is Windows 8.1 since I don't have access to such a machine at the moment.
In any case, I do want to thank you for taking the time and submitting a potential solution. But for now I'd like to think about it some more. Hope you'll understand!

@jeroenheijmans I found these SVG's on the Wikimedia site, they have taken them from the github site for the Emojione font, not available anymore on the link provided, so the license/copyright is not at Wikimedia. For other SVG's change the unicode point number on the url. (I added the color name because unicode points are hard to read.)
I have changed the SVG's a bit to match your background colors (gold and silver) and added a dark border around the medal for additional contrast.
I just found that istockphoto used these same SVG's, made an image of them and now sells this image for Eur 9.
My Google Chrome uses Consolas for Fixed width font and Arial for Sans-Serif font.
Every browser is supposed to render SVG, almost all Wikipedia images are SVG. At least the simple SVG paths with fill and stroke. AOC still supports IE9 but who uses that still.
The "web_accessible_resources" in the patch is the v3 to limit the probe scanning of extension installs, but I can make it v2 compliant, remove the matches property and just use a list of globs.
As a sidenote, I seem to have the Christmas tree used in Showing all participants but I don't have the glyph used with Showing only medalists but that is probably one of the medal characters. That uses font-family: Helvetica, Arial, sans-serif;. The Christmas tree is multi color, so it is not taken from the Arial font. If I change it to font-family: serif; the text changes but the Christmas tree stays the same. The browser must have some Emoji font that it uses for these glyphs.

Ok cheers thanks for giving the source, the CC license they use should be good enough since we'd share our remixed versions.
I'll still opt to hold this PR off until next year's event (and possibly also further investigate fallback font options). You make fair points that it should just work with the SVG's, but I'm super risk averse in December with work and puzzles and the AoC survey and whatnot, just don't want to be stuck with a broken plugin.
Thanks again for contributing, and hope you'll understand my reasoning.

@jeroenheijmans Using something graphical makes it hard to write unit tests for.
I will keep using my unpacked development version. If anybody has the same problem as I had they can use the branch in my fork and also use an unpacked extension.
According to emojipedia.org the medals are part of Unicode since 2016.
If you click on the Microsoft version you see that it started supporting it on Windows 10 Anniversary Update.
The Christmas Tree is part of Unicode since 2010. And is Black-And-White in Windows 8 but color in Windows 8.1
Looking at the Emoji-Frequency Windows 8.1 is missing a lot of Emoji support.
Emojipedia doesn't mention Linux as an Emoji supporter.
Currently in our leader board a player has 10 medals of one kind and the SVG version has a slight placement problem. I will investigate and update.

@jeroenheijmans The medal table total columns have a snap tag (with the medal character) that has a display style of inline. If you set it to display:block (like in the rest of the medal table) the span will fill the whole td tag and not only the width of the medal character.
By limiting the SVG to 16x16 pixels it behaves as a normal character and will not resize the td tag.

Once more, thanks for your interaction and suggestions! I spent a lot of time on the survey recently, and will have to pause tweaking the browser extension a bit. I'll try to revisit this and all other suggestions roughly November 2022, before the next edition. Hope you'll understand!

Thanks once more for the issue report, and the extensive interaction!
I finally made some time to look into this. I will accept the PR (the merge commits will come during 2023 I promise, working on a feature branch locally), but I will also give my own spin to it. Because it is such an extreme edge case (possibly limited to Windows 8 and lower) I don't think it's worth introducing SVG's and extra moving parts and assets. Instead I found that the AoC site uses a very limited font stack ("Source Code Pro", monospace) and I truly hope that if I extend that with several fallbacks for the medal html part, that even Windows 8.1 and other edge cases will be able to find medal emoji. Otherwise the background color will just have to do, I'm afraid.
Either way, thx, and happy puzzling!


rename dora_the_explorer to dora

rename dora_the_explorer to dora
docker image:  ethpandaops/dora:master

Could you pls rename here too: https://github.com/ethpandaops/ansible-collection-general/blob/master/roles/generate_kubernetes_config/templates/light-beaconchain-explorer.yaml.j2


Upgrade to golang 1.21

Clean up go.mod and upgrade dependencies.
Update all Go version to 1.21.
Changes made to accommodate linter for deprecation errors:

Update cmd/flush.go cmd/pubkey.go
Add a comment in server/import.go to suppress linter (because the new library doesn't support P226 yet)
Update launcher/auth.go

/gcbrun

/gcbrun

/gcbrun


How to boot into normal mode without PC?

Sometime, if anyhow my phone's battery dies or reboots, it gets stucked into recovery mode. It's too much painful when it happens when I'm outside. I can't even use my phone to call emergency. It's really a serious issue.
I found this command in postboot.sh
nvram auto-boot=false
Maybe this command is creating this issues. I have tried to set it to true, but still no luck. Everytime my phone reboots, gets stucked into recovery. No way to boot into normmal mode.
Thanks to all the developers for making this great script. I have waited for more than 1 year for this jailbreak.

I have SafeShutdown tweak purchased before. This tweak works great. But it will save the jailbreak when battery is dying. But What to do when phone is rebooted?

nvram auto-boot=true
command worked. now i can reboot to normal mode without PC.

That’s not an issue. It’s intentional.
If your device reboots into stock, the jailbreak gets reverted. That’s why the jailbreak is tethered in the first place, so you don’t lose your tweaks each time you reboot.

I’ve never experienced this. Palera1n is just like Checkra1n. It doesn’t get revert to stock when booted into normal mode.

That’s not an issue. It’s intentional.
If your device reboots into stock, the jailbreak gets reverted. That’s why the jailbreak is tethered in the first place, so you don’t lose your tweaks each time you reboot.

I’ve never experienced this. Palera1n is just like Checkra1n. It doesn’t get revert to stock when booted into normal mode. And also, nothing is removed. Everything will be kept.

I have no idea how you've managed to make your tweaks stay, but iOS 15 introduced sealed root. Even if root gets mounted as r/w, it gets reverted back to its original state on next boot. Which is why palera1n is intentionally tethered, so we can avoid booting normally and getting the tweaks reverted.
It's explained better here - https://github.com/itsnebulalol/ios15-tweaks
Also, I guess, that's the reason checkra1n wasn't updated to iOS 15 yet - because there's no way to get proper root and stay semi-tethered.

I have jailbroken my iPhone 7 before using checkra1n and also unc0ver. Maybe they have left some exploits.
As far as I remember, I have experienced that kind of issue when palera1n was released. Sileo, NewTerm everything was gone every time I rebooted into stock. Tips app were totally broken. Even if I re-downloaded. But having a full reset of my device, no more issues. Working just like the checkra1n. All files left intact except those tweaks running. Everything works perfectly when I re-jailbreak.
I think, palera1n can also work as an app. As like unc0ver before.

On Oct 28, 2022, at 4:15 PM, mineLdiver @.***> wrote:

That’s not an issue. It’s intentional.
If your device reboots into stock, the jailbreak gets reverted. That’s why the jailbreak is tethered in the first place, so you don’t lose your tweaks each time you reboot.
I’ve never experienced this. Palera1n is just like Checkra1n. It doesn’t get revert to stock when booted into normal mode. And also, nothing is removed. Everything will be kept.
I have no idea how you've managed to make your tweaks stay, but iOS 15 introduced sealed root. Even if root gets mounted as r/w, it gets reverted back to its original state on next boot. Which is why palera1n is intentionally tethered, so we can avoid booting normally and getting the tweaks reverted.
It's explained better here - https://github.com/itsnebulalol/ios15-tweaks
Also, I guess, that's the reason checkra1n wasn't updated to iOS 15 yet - because there's no way to get proper root and stay semi-tethered.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.

Exploits take advantage of system vulnerabilities. Even if "they have left some exploits", the vulnerabilities are patched, making them useless.
And no, palera1n can't ever be an app, because it exploits the device in DFU through USB. Literally physically impossible, and same reason checkra1n will never be an app. That's just not how checkm8 works.


Support for Swagger 2.0?

Are there any plans to move over to Swagger 2.0?

Not that I know of ;)
No objection, just that nobody done it yet...
On Tue, 20 Jan 2015 18:48 Kosta<EMAIL_ADDRESS>wrote:

Are there any plans to move over to Swagger 2.0?
—
Reply to this email directly or view it on GitHub
https://github.com/rantav/flask-restful-swagger/issues/70.

I guess this is a feature we all want, but nobody has started to do it yet. @Kosta-Github do you feel like you could start it?

not at the moment, since I am a complete Python newbie right now


Add Layer2 topology class

Short description:
Add Layer2 topology class to manage Layer2 network configurations in UserDefinedNetwork.
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

Summary by CodeRabbit

New Features

Introduced support for Layer2 network configurations with the new Layer2UserDefinedNetwork class.
Added a centralized definition for topology types with the TopologyType class.

Improvements

Enhanced error handling in network configuration to ensure mandatory parameters are provided.
Improved the to_dict method to better structure Layer2 network configurations, incorporating additional Layer2-specific attributes.

Report bugs in Issues
The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.

Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
Cherry-pick will be started when PR is merged

To build and push container image command /build-and-push-container in the PR (tag will be the PR number).

You can add extra args to the Podman build command

Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>

To add a label by comment use /<label name>, to remove, use /<label name> cancel
To assign reviewers based on OWNERS file use /assign-reviewers
To check if PR can be merged use /check-can-merge

Supported /retest check runs

/retest tox: Retest tox
/retest python-module-install: Retest python-module-install

Supported labels

hold
verified
wip
lgtm

/verified

/verified

/verified

/verified

/verified

/verified

/verified

/verified

/verified

/verified

/verified

/verified

/verified

/verified

/verified


Ubiquitous session favoriting

My most wished for feature: ajaxy buttons throughout the UI (session lists and schedule) for voting/unvoting! Now you can see your favorites on the schedule. Woohoo!
This is not quite done, but I have to run off and be a dad for a while. Anybody want to pick it up? Things to do right now:

Cross browser testing, testing, testing (I've done almost none)
~What is up with those two failing specs? I'm doing something dumb.~

Things to do in the future, but not in this PR:

Better testing
Revisit the “Yes! I’d like to attend” behavior, which still doesn't have an unvote ability … but is complicated because of the embedded login form.

Notes:

I also revamped how some things get cached, hopefully for the better. Entire schedule view is now served from cache — but uses session update times, so no more manual cache busting if you tweak a session!
I wrote the session favorite so that it does not break caching. There is one cached version of the schedule for everyone; a separate call from JS fetches your voted session IDs and highlights the appropriate sessions.

Changes Unknown when pulling fb8162bcdc66106809279ac3377a216b4605defd on ubiquitous-session-favoriting into ** on master**.

Changes Unknown when pulling 9e5e6714ea55e906f95b733925e856ccad203c49 on ubiquitous-session-favoriting into ** on master**.

Changes Unknown when pulling 6902cc03c6bbd1771372a34e334af1673018820e on ubiquitous-session-favoriting into ** on master**.


Build not start

What App Center service does this affect?
Build
Describe the bug
Manual Build not starts and only "*** Waiting for data from the build agent ***" only at the end I can see all log
Expected behavior
log scrolling down
Desktop (please complete the following information):

OS: WinX
Browser chrome
Version 75.0.3770.100 (Build ufficiale) (a 64 bit)

@mkgitalia  Thanks for reporting this! We indeed introduced a bug on Friday which regressed the behavior on this. A hotfix was just deployed. Please let us know if you still experience any issue.

Still seeing this issue today.

@voxoid0 Do you mind reaching out to support via App Center portal? Then we can look into your specific app. I just tried and log is streaming. So it's likely something unique is happening in your case.


added item box to Player

Finally got around to this. Not sure if I needed to add the item box update event.
I didn't test it with my plugin, but this is pretty straight forward. Those are the offsets between each section that I have in my notes. I'll use it in my plugin tomorrow if you want to wait.

Thanks! Also about this:
private void GetItemBox()
        {
            // I think this changes. I had a different value before the 12/2 update
            int offset = 0x38a08;
            [...]

That does make sense, maybe Capcom added something new to the player save, or maybe the offset changes depending on how far you are in the game and that changes the offset, so I'll try to find an actual pointer to make the item box 100% accurate.


chore(dist): Remove dist/ from repo, add prepublish

Remove the dist folder, gitignore it, and build it just-in-time via prepublish.

:shipit:


Invalid type Declaration for styled Props

I think that the line has an error.
https://github.com/mui-org/material-ui/blob/4a96d14dfbb0054775e914d5151ae28c0fbcc262/packages/material-ui-styles/src/styled/styled.d.ts#L15
TS2339: Property 'transparent' does not exist on type '{}'.
There should be like this Props extends {} = T

Duplicate of #19541


oracle join (+) vs. ( + ) fix #117

the problem is that this patch does not fix the (+ ) ( +) (     +  ) etc. forms. - I don't know how to do it in javacc

I will look into it.

I made the implementation myself. It will all the forms, you mentioned.

thank you


Split off Location data, remove Depot

This PR:

[x] Is a part of #640.
[ ] Adds and passes relevant tests.
[ ] Has well-formatted code and documentation.

Notes:
Please read our contributing guidelines first.
In particular:

You must add tests when making code changes.
This keeps the code coverage level up, and helps ensure the changes work as intended.
When fixing a bug, you must add a test that would produce the bug in the master branch, and then show that it is fixed with the new code.
New code additions must be well formatted. Changes should pass the pre-commit workflow, which you can set up locally using pre-commit.
Docstring additions must render correctly, including escapes and LaTeX.
Finally, it is essential that all contributions in this PR are license-compatible with PyVRP's MIT license.
Please check that this PR can be included into PyVRP under the MIT license.

This is a massive undertaking. I've mostly updated the C++ stuff now, but the Python side and all the tests still need to be looked at. That's for later; I'll leave this draft PR around for now.


Fetch all reviews instead of first 30

bot automerge+

bot noqa+

Pull request successfully auto-merged! (strategy: 'squash')
Beep boop, i'm a bot! :robot: (github-scbot 0.21.2)

bot noqa+

QA is marked as skipped by Srynetix.
Beep boop, i'm a bot! :robot: (github-scbot 0.21.2)


AllowedPattern for Parameter "Vpc" not compatible with longer VPC ID format

https://aws.amazon.com/blogs/compute/longer-resource-ids-in-2018-for-amazon-ec2-amazon-ebs-and-amazon-vpc/
VPC IDs can now be up to 17 characters
the AllowedPattern field on line 27 should be updated or removed to reflect this
https://github.com/aws-samples/aws-refarch-drupal/blob/master/templates/aws-refarch-drupal-02-securitygroups.yaml#L27

https://github.com/aws-samples/aws-refarch-drupal/pull/5


[Feature] Introduce seatunnel-backend module

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
This issue want to discuss do we need a seatunnel-backend module  that supports remote submission of tasks , currently we having to execute the submit command on the server side.
And we can discuss what feature we needed in seatunnel-backend module.
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Good idea to me, I hope we can provide seatunnel-backend module or a seatunnel-cli client, that can help use to manage the seatunnel jobs like submit job/ stop job or some other operation, user don't need to extra use  flink/spark client to do this work.
And furthermore, if the added module can provide the plugin information is better. Such as how many kinds of plugins have been packaged in the seatunnel jar, and what params is needed of the plugin.

Thank you for your feedback, I will design the initial version. Also I want to discuss which framework should we choose for providing HTTP services, Jetty or Spring Boot or others, WDYT? @CalvinKirs @wuchunfu @ruanwenjun

Jetty +1
IMO, jetty is light and springboot is heavy, backend module is more about forwarding work and state acquisition.

If we don't need to integrate with other framework, using Jetty is good to me.
If we still need to do some database operation, I think use SpringBoot is a better choose.


HTTP 500 error again

Describe the bug
Upon running stories.sh:
instaloader --filename-pattern {profile}-{shortcode} --dirname-pattern videos --stories --no-video-thumbnails --no-captions --no-metadata-json --no-posts --no-profile-pic --post-filter="is_video" --storyitem-filter="is_video" --login USERNAME --password PASSWORD :stories
I get this in the terminal (I already tried deleting the session file as shown):
./stories.sh
Only download posts with property "is_video".
Only download storyitems with property "is_video".
Session file does not exist yet - Logging in.
Logged in as fukkensaved.
Retrieving all visible stories...
JSON Query to graphql/query: HTTP error code 500. [retrying; skip with ^C]
JSON Query to graphql/query: HTTP error code 500. [retrying; skip with ^C]
:stories: JSON Query to graphql/query: HTTP error code 500.
Saved session to /tmp/.instaloader-user/session-fukkensaved.
To Reproduce
Using stories.sh
Expected behavior
Would normally download all Instagram story videos available. Failing today due to change in Instagram policy/API/instaloader h8.
Error messages and tracebacks
Given in bug description.
Instaloader version
Both 4.3 and 4.4.
Additional context
Twice-daily script to scan Instagram story videos for all followed accounts.

Addendum: If this can be explained as server side, that's good news. Sort of.

Oh well there you go. It works now. I guess admins can delete this if they want.


Exponential back-off

Proposal
Implement exponential back-off in Jenkins Mesos Plugin [JMP]
Expected behavior

Time X (in seconds)
Plugin
Mesos Master

0
Does Nothing
Mesos has resources requested

1
JMP requests for resources to build code
Mesos doesn't have requested resources to offer

2
Jenkins Mesos Plugin retries after 2 seconds
Mesos doesn't have requested resources to offer

4
Jenkins Mesos Plugin retries after 4 seconds
Mesos doesn't have requested resources to offer

8
Jenkins Mesos Plugin retries after 8 seconds
Mesos doesn't have requested resources to offer

16
Jenkins Mesos Plugin retries after 16 seconds
Mesos doesn't have requested resources to offer

32
Jenkins Mesos Plugin retries after 32 seconds
Mesos doesn't have requested resources to offer

...
Jenkins Mesos Plugin retries after ... seconds
Mesos doesn't have requested resources to offer

...
Jenkins Mesos Plugin Stops requesting, display a disposable JQuery banner on Jenkins Master
N/A

@nrshrivatsan, I need a few more details. What should be backed of? In 2.0 a client launch should time out in five minutes. There is no notion of an exponential back-off though. Should the plugin retry after the first launch failed?

Closing for lack of response.


forum or mailing list for bgfx?

I do not see any forum or mailing lists mentioned for bgfx.  Such should be useful for the community.

Yeah, there is no forum. You can use these issues, gitter if you have some short form questions: https://gitter.im/bkaradzic/bgfx


Issue with sub-wizards in case wizards are depending on each other

The example - issue - we see in our solution is this:
1.) Open edit wizard for DataSet say from ReportControl element.
2.) Change the name of the DataSet
3.) As the name of the DataSet is reference from the ReportControl element, we need to change the attribute datSet there
4.) When - in a subwizard based UI - we return to the edit wizard of the ReportControl it actually does not show the ReportControl in the SCL, but the "old" one that was replaced with the Update action.
I would say a solution would be to not use elements as the input for the function that return Wizard but to use our identity string.
For now, we have tom make sure to either not allow changing things that might affect the wizard before or to not use subwizards in such cases.

This is an issue with our Editing system. Specifically with our onUpdate function. What we do at the moment is to swap the old element with the new element. This function is very straight foreward and the undo does work in the same way, we just nieed to exchange old and new.
Me an @ca-d as well as @dlabordus were discussing how we could solve the problem. @ca-d and me are seeing a long term solution and a potentially long term solution that I will open a new issue for. But in short:
Potentially long-term:

do not use DOM objects at all for editing but objects and to identify the element in the DOM the identiy string we provide in the foundation

Advantage: We have automatically serializable actions that we can store in the SCD - e.g. Hitem.
Disadvantage: The SCL does not have native id's for their elements and the id is a reference build from configurable attributes. This means we would need something event that triggers when a identity string changes :(

Short-term:
We leave the Update API as is new:Element,old:Element but do not swap in the onUpdate but we exchange attributes using the functions removeAttributeNode and setAttributeNode. Then we only need to change the onUpdate and everything else can stay as is.

Advantages: clear reference through element, no big changes needed this can be implemented very fast
Disadvantages: we relay with our API on DOM from the beginning, we can not undo history before file open

@dlabordus @Flurb @danyill and others what do you think about that

For the short-term, how are you planning to do the undo history in this case?
Because that still means that you need to save a clone of the old element to make this possible.
And in the future it still could be possible to undo history from before opening the file, just replacing the attributes again...

What we thought of for the short-term is to not swap the element in the DOM but to swap the attributtes in the elements DOM objects. However, we still have DOM objects and those are not really serializable so far I know. An this is the crutial thing that is missing to push those to the Hitem elements in the SCL.

We have added a new type of editor action that allows to keep the referenced element in the DOM: Update


Make data anonymous

Hello,
is there an way to make data anonymous? To only log for example the randomised id of the target and not the mail address, browser agent etc?
Regards
lokem

No there is not. That data is all stored on the server, and because of the degree to which alot of the analysis code requires it I would not be comfortable making storage of it options.
You could forge or not provide the first and last names in the targets list, and not log passwords.
During our campaigns, we generally try to gather as much data as we can.


[Feature]: flink optimizer upgrade to 1.14.5

Description
flink 1.14.0 released from last year, now it because more and more stable, the new version is 1.14.5, and 1.14.x version support lots of features, such as back-pressure in Flink UI(introduced in Flink 1.13 https://nightlies.apache.org/flink/flink-docs-master/zh/release-notes/flink-1.13/#monitoring--debugging).
Use case/motivation
for better optimize debugging and resources evaluation, etc.
Describe the solution
No response
Subtasks
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The Optimizer support running in flink 1.14, but optimizer/pom.xml should be changed to 1.14 before package, like
Discussion: Optimize support 1.15.2
The Optimizer will support multiple flink versions with maven profile in the future.


Elliminate ExperimentsFactory, updates

Codecov Report

Merging #12 (5bdfc25) into main (5218104) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   99.63%   99.50%   -0.14%
==========================================
  Files          23       23
  Lines         827      808      -19
==========================================
- Hits          824      804      -20
- Misses          3        4       +1

Impacted Files
Coverage Δ

gimeltune/search/algorithms/algorithm.py
100.00% <ø> (ø)

gimeltune/storages/rdb/storage.py
100.00% <ø> (ø)

gimeltune/jobs/job.py
99.31% <100.00%> (+0.03%)
:arrow_up:

gimeltune/models/__init__.py
100.00% <100.00%> (ø)

gimeltune/models/experiment.py
100.00% <100.00%> (ø)

gimeltune/search/algorithms/bayesian.py
97.56% <100.00%> (-0.03%)
:arrow_down:

gimeltune/search/algorithms/grid.py
100.00% <100.00%> (ø)

gimeltune/search/algorithms/randomized.py
100.00% <100.00%> (ø)

gimeltune/search/algorithms/seed.py
100.00% <100.00%> (ø)

gimeltune/search/algorithms/skopt.py
100.00% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5218104...5bdfc25. Read the comment docs.


Unable to load the group/list subscriptions

Describe the bug
When opening the app, shown this error message. Subscriptions and feeds can'tbe displayed. Though I can still look at trends and saved tweets.
To Reproduce
Steps to reproduce the behavior:

open the app
shown this error

Screenshots
attached
![Fritter bug](Fritter bug https://imgur.com/gallery/Cg2RLYe)
Device
v 2.10.0
Samsung GalaxyS9+
Android 10

I think you can work around this by tapping the refresh button, but I'm not 100% what's actually causing this - it's another thing I can't reproduce (or find any useful reference to) so I think it's also something different in SQLite between devices.
I'm going to keep trying to find out what's causing this this week.

Thank you. Tapping the refresh button did the trick.

It looks like this was fixed in v2.11.2 already, so closing for now.
I left you a reply on #170 that should allow you to install the updated version, as F-Droid still hasn't built it yet!


iOS with PC browser use simpleWebRTC

when i use this iOS-demo to communicate with chrome browser, i use the simpleWebRTC in browser. and i can see the video in browser(both from pc camera and iphone camera) but i can not see anything on iphone

Hi @vanney9, what code did you use to get simpleWebRTC (was it from github?) in a PC Chrome browser working with ios-Demo? It had to be over an HTTPS connection on the PC to work correct?

@vanney9 can you share your code for the browser? I've been trying to get my iOS demo app to talk to the browser without any success.

So ... I don't have a solution yet, but it looks to me like the latest version of simplewebrtc using > 1.0 socketIO and azsocketio (what is used by this app) is still .9 which is a breaking change.
The biggest bummer of it all is AZSocketIO doesn't look like they are still working on since socket.io now has its own library. So as far as I see it, you either have to rewrite this using the socket.io stuff (which I have no idea,yet how much work that will be) or run a old version of simplewebrtc on your server


We don't know how to parse this version of SAST report

I tried using this against a gl-sast-report.json file from the latest Gitlab v14.8.2 and it was unable to parse it.
I've included the file for reference. It's getting tripped up on this line:
 "version": "14.0.4",
gl-sast-report.json.txt

@frakman1 - just comment out these lines and it still seems to work for me. Obviously it may miss some new features in the schema
        if StrictVersion(data['version']) >= StrictVersion("9.0"):
            print('We don\'t know how to parse this version of SAST report')
            sys.exit(1)

@frakman1 - just comment out these lines ...
Thank you for that idea, it helped.


Code_11_3.cs doesn't compile

I'm using VS 2019 and create console .Net Core application with target framework .net Core 3.0. The sample is giving me compilation errors
Severity	Code	Description	Project	File	Line	Suppression State	Suppression State
Error	CS1503	Argument 1: cannot convert from 'System.Collections.Generic.IEnumerable' to 'System.Collections.Generic.IAsyncEnumerable'	AsyncStreams	C:\Users\mohamed.abdelaziz\source\repos\AsyncStreams\AsyncStreams\Program.cs	13		Active
Error	CS5001	Program does not contain a static 'Main' method suitable for an entry point	AsyncStreams	C:\Users\mohamed.abdelaziz\source\repos\AsyncStreams\AsyncStreams\CSC	1		Active

Hi @zizo2006
Sorry for late reply. Not sure if you have already figured out the issue or not. From the error it looks like a type conversion issue.
cannot convert from 'System.Collections.Generic.IEnumerable' to 'System.Collections.Generic.IAsyncEnumerable'
Can you please check your code if you are using the correct type.
If still not working, please post your code here so that i can see.
Thanks

@zizo2006 - The error because method GetSumOfNums expects parameter of type IAsyncEnumerable but IEnumerable was supplied. I corrected the code. This code is working for both .NET Core 3.0 and .NET Core 3.1
AsyncStreamConsoleSample.zip


Pihole V6

What feature would you like added?
PiHole v6 has just been announced at the start of the month with quite a few changes, including the API and consolidated settings files as two notable (probably breaking) changes.
https://pi-hole.net/blog/2023/10/09/pi-hole-v6-beta-testing/
https://deploy-preview-338--pihole-docs.netlify.app/api/
May be worthwhile to have a look in case you haven't and use this issue as a staging ground to prepare or any questions that may be raised.

How is the progress looking for V6?

Gravity sync has been archived - given the different implementations ("acting on their admin interface" vs copying the databases / config files) this one does seem much easier to migrate.
In fact, given the move away from PHP to a new REST API, this project may become even easier!
I'm planning to do some testing on this project soon :)

Putting my comments on this discussion to avoid spamming notifications
https://github.com/mattwebbio/orbital-sync/discussions/391

just the configuration checkbox that causes the issue - but that's not super helpful

so dnsmasq is not installed, and I don't think it's supposed to be?

@mattwebbio It would be good to add a development-v6 branch we can use as a target I think.

@timtjtim Done! https://github.com/mattwebbio/orbital-sync/tree/development-v6
Also: thanks for taking the time to look at this. I'm in the process of moving, so my time is (temporarily) extremely limited. It's a huge help :)

Gravity sync has been archived - given the different implementations ("acting on their admin interface" vs copying the databases / config files) this one does seem much easier to migrate.
In fact, given the move away from PHP to a new REST API, this project may become even easier!
I'm planning to do some testing on this project soon :)

Already done the migraton and it works. Just now waiting for v6-support and v6 release of Pihole :)

I'm going to split this into two PRs - the first will just change more into a factory pattern, but still only support v5. If we're happy with the approach, I'll add in the V6 stuff. In the meantime - in case I have to go AWOL for some reason - I've also added the basic v6 work I've done to another branch.
PR with factory pattern for comment: https://github.com/mattwebbio/orbital-sync/pull/406
Extra branch: https://github.com/timtjtim/orbital-sync/blob/timtjtim/development-v6/v6-client-code/src/client/v6/index.ts


supply-chain centralization vulnerability in initial download of peers.json

When launching Skepticoin Client the first time, without a peers.json, the client downloads the initial peer list from https://pastebin.com/raw/CcfPX9mS
This is a vulnerability as we don't know who all control the contents of this URL and what would happen if they stop updating it, or even worse, the contents get maliciously updated due to a hack.
The Skepticoin Client should accept a list of trusted peers.json URLs which are maintained by the Skepticoin Community.

I noticed this too and wondered why the initial peers.json is not just included in the repo.

Including it in the repo is bad too. It should be a runtime parameter with defaults.

Also BTW, the one on pastebin appears to be currently broken. None of those peers are active.

@sashimi-houdini I believe you are in control of those peers, can you have a look please.

I've started publishing an updated peers.json here in case anybody needs a work-around:
http://skepticoin.s3.amazonaws.com/peers.json

The Skepticoin Client should accept a list of trusted peers.json URLs which are maintained by the Skepticoin Community.

I agree It's not super pretty, but it's an improvement over what we have now:

Everyone can suggest changes
When changes are made, we can see who did it and when
This satisfies the "maintained by skepticoin community" as mentioned above

Including it in the repo is bad too.

Could you elaborate on why this is bad and how precisely we should do it instead?

Firstly, it's about the pace of change. Imagine a future when the skepticoin code is very stable and we are not constantly making new releases. But the peers.json will still be constantly changing. Are we going to make new releases just to update this file?
Secondly, this file contains individual people's IP addresses. In some countries and some jurisdictions, this comes with legal requirements, for example the right to have it deleted. It could become a huge headache to have it permanently stored in git history.

Okay, the former is not the case, however the latter makes sense.
So how should we share this list of peers instead? Where should it be hosted? Who should be able to change it?

The client should accept a list of URLs and merge the contents on start-up. For now it could default to the original from pastebin plus the one given above. In the future, new URLs can be added to the default list. Keep in mind that security is achieved by having at least one correct file. If one of them is invalid or outdated it'll just be ignored. So it's not necessary to control who will be able to change the contents, beyond ensuring that they are sourced from more than one person.

Sounds reasonable to me. Do you want to implement this or should I do it?

I think this is an important change, especially if the bad pastebin contents is causing new users to be unable to get started. But I probably won't be able to work on the code again until the weekend, so please feel free to jump in if you have the time sooner.

Remember that the 5th principle of cryptocurrency is to betray your core principles, in this case decentralization. Note that many "real" cryptocurrencies have actual IP addresses hardcoded in the repo. Having said that, I'm happy to seriously look at any better solution than what we have now.

If we're talking security, and known peers, it should also be noted that, when requesting a list of peers, the current implementation basically takes any peer at their word as to the truthfulness of the answer. I'm sure "more serious" cryptocurrencies have checks and balances built in (and banscores) in that area too.

I support lk16's PR#55. It would be funny, and awesome, if skepticoin is in some ways more secure than established crypto.


macos 10.14 and later only allows control if Screen Sharing is enabled through System Preferences

Usage of theard resource in macOS Mojave results in the following message from macOS:
Warning: macOS 10.14 and later only allows control if Screen Sharing is enabled through System Preferences.

Additionally, there have been several reports that, when connecting to a VM or metal over VNC, observing works but controlling  does not.

Resolved by #147


Broken workflow

So I've got a problem with a broken workflow, and I suspect it's got to do with this extension.
It started after I restarted ComfyUI. The entire interface is unresponsive and looks like this:

I tried running the workflow fixer, it fixed 1 error, but that still didn't help.
I have this error message:
		"source": "window",
		"type": "error",
		"timestamp": "2023-12-08T17:51:34.084Z",
		"message": "TypeError\nCannot read properties of undefined (reading 'scale')\nTypeError: Cannot read properties of undefined (reading 'scale')\n    at RerouteNode.onDrawForeground (http://<IP_ADDRESS>:8188/extensions/rgthree-comfy/reroute.js:80:43)\n    at drawBadge (http://<IP_ADDRESS>:8188/extensions/ComfyUI-Manager/comfyui-manager.js:283:25)\n    at node.onDrawForeground (http://<IP_ADDRESS>:8188/extensions/ComfyUI-Manager/comfyui-manager.js:963:45)\n    at LGraphCanvas.drawNode (http://<IP_ADDRESS>:8188/lib/litegraph.core.js:8518:18)\n    at LGraphCanvas.drawNode (http://<IP_ADDRESS>:8188/extensions/core/snapToGrid.js:86:24)\n    at LGraphCanvas.drawNode (http://<IP_ADDRESS>:8188/scripts/app.js:1146:29)\n    at LGraphCanvas.drawNode (http://<IP_ADDRESS>:8188/extensions/ComfyUI-Custom-Scripts/js/snapToGrid.js:28:25)\n    at LGraphCanvas.drawNode (http://<IP_ADDRESS>:8188/extensions/ComfyUI-Custom-Scripts/js/snapToGrid.js:28:25)\n    at LGraphCanvas.drawFrontCanvas (http://<IP_ADDRESS>:8188/lib/litegraph.core.js:7801:22)\n    at LGraphCanvas.draw (http://<IP_ADDRESS>:8188/lib/litegraph.core.js:7716:18)\n"

and a bunch of these warnings:
	"source": "console",
		"type": "warn",
		"timestamp": "2023-12-08T17:51:34.145Z",
		"message": "LiteGraph addWidget(...) without a callback or property assigned"

Uninstalling the extension makes things work again.
Here's the workflow:
Simple SDXL.json
Update: I uninstalled, replaced all reroute nodes with regular reroute nodes and then reinstalled. Now it seems to be working again. So my guess the issue is there.

Same. After the last ComfyUI git pull, all my nodes, of all types don't render correctly on screen and the workflow is frozen (aka you cannot drag and drop to pan).
Removing the rgthree custom node folder loads the workflow correctly and the non-rgthree nodes appear as expected.
Differently from @Davikar, I'm not in the position of replacing all reroute nodes :)

Hmm.. did ComfyUI break us yet again? I'll take a look

@Davikar Oddly, I'm can't reproduce on my end with your workflow, butboth "Zoe - Depth Map" and "OpenPoseEditor" were causing errors in your workflow. 11c96b2 should fix the error you pasted, but since I can't repro I can't tell if something else is happening.  Cannot read properties of undefined (reading 'scale') at RerouteNode.onDrawForeground (http://<IP_ADDRESS>:8188/extensions/rgthree-comfy/reroute.js:80:43)? Obviously, pull and see if the recent commit fixes you, pls

It now seems to be working as expected. Thank you for the ultra-quick fix!

@rgthree Yepp, it seems to be working fine now. 👍
Have to look into those other nodes. It's strange cause the depth map is working as far as I can see, although that entire section is muted by default. The openpose editor I think just complains if it's empty.


⚠ sandbox-api.piste.gouv.fr healthcheck has degraded performance

In 6431cfa, sandbox-api.piste.gouv.fr healthcheck (https://sandbox-api.piste.gouv.fr/cassation/judilibre/v1.0/healthcheck) experienced degraded performance:

HTTP code: 200
Response time: 2795 ms

Resolved: sandbox-api.piste.gouv.fr healthcheck performance has improved in 999007b.


ISPN-6522 Cannot use @DateBridge with WildFly modules

https://issues.jboss.org/browse/ISPN-6522
https://issues.jboss.org/browse/ISPN-6699

I get a compile error.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project infinispan-query: Compilation failure: Compilation failure:
[ERROR] /home/adrian/work/infinispan22222/infinispan/query/src/main/java/org/infinispan/query/affinity/ShardIndexManager.java:[40,7] cannot find symbol
[ERROR] symbol:   method flushAndReleaseResources()
[ERROR] location: class org.infinispan.query.affinity.ShardIndexManager
[ERROR] /home/adrian/work/infinispan22222/infinispan/query/src/main/java/org/infinispan/query/affinity/ShardIndexManager.java:[62,13] cannot find symbol
[ERROR] symbol:   method flushAndReleaseResources()
[ERROR] location: class org.infinispan.query.affinity.ShardIndexManager.TopologyChangeListener
[ERROR] /home/adrian/work/infinispan22222/infinispan/query/src/main/java/org/infinispan/query/indexmanager/InfinispanBackendQueueProcessor.java:[32,7] org.infinispan.query.indexmanager.InfinispanBackendQueueProcessor is not abstract and does not override abstract method closeIndexWriter() in org.hibernate.search.backend.spi.BackendQueueProcessor
[ERROR] /home/adrian/work/infinispan22222/infinispan/query/src/main/java/org/infinispan/query/indexmanager/InfinispanBackendQueueProcessor.java:[107,4] method does not override or implement a method from a supertype
[ERROR] /home/adrian/work/infinispan22222/infinispan/query/src/main/java/org/infinispan/query/impl/ProjectionLoader.java:[34,59] cannot find symbol
[ERROR] symbol:   variable ENTITY_PLACEHOLDER
[ERROR] location: interface org.hibernate.search.query.engine.spi.EntityInfo

@anistor please ignore it for now, it needs a hibernate search release

right. I've built the hsearch snapshot and it looks good now.

@anistor it should compile fine now as Hibernate Search published snapshots regularly

Updated with the Hibernate Search ugrade to 5.6.0.Beta1

Looking ....

ops forgot the Lucene minor update

I'll wait then. CI also seems to be taking a break ... :)

Updated with  Lucene 5.5.0 =>  5.5.1

LGTM, but I'll wait for CI.

Pulling ...

Integrated in master. Thanks @gustavonalle !


Initial help pages supporting data service import.

created help page for data service file import
created help page for data service git import

Looks good


Tooltip VSSPerson is centered

Shouldn't it be left-aligned?

Is this happening in which browser? I was not able to simulate it on Firefox, Chrome or Safari.

Version 83.0.478.61 (Official build) (64-bit)

Plus, I guess it makes sense to add a badge for the required reviewer in the tooltip.


Sterling saving theme setttings between different runs

I often change theme settings for runs to make the visualizations easier to understand (e.g. making something display as an attribute, changing the color, etc.) It would be great if these settings could be saved when clicking the Next button or even between runs so I don't have to change it every time!

This issue is also related to preserving the location of notes between "Next" invocations. Graph src preserved locations, but srcnew does not.


"does [Verb]"  lumping support

Hey,
I know I have been reporting a deluge of bugs but I really want to help fix them. :)
Here's another one:
let text = new NLP.sentence("He does not care");
textB.to_present().text();  // -> He does not cares

hey this is great, i'm workin on this in a new branch, sentence_subclass.
should be a few days.

Sweet. Thanks for the update!

Oops. In 4.10.6 it says

new nlp.sentence("He does not care.").to_present().text()
'He does nots cares'

yeah, so the reason why this is failing is that does not care ought to be one big verb term, as opposed to "does not", "care", it's really a tokenization problem.
this is a great example, and something i'll gonna take a look at.

hey diwank, this situation has been improved in v7, though it could use some work still..
https://runkit.com/583f2a3dc534df0014136221/58c81ef1ee89c00015029109
@johnyesberg yours is fixed now too
https://runkit.com/583f2a3dc534df0014136221/58c81f2b4637b5001471db87
thanks!


fix: update sourceCriterion documentation

What does this PR do?
Fixes #8512
This pull request updates the sourceCriterion docs.
Motivation
This is my first contribution to Traefik as I'm learning Go and after some months studying it now I'm trying to do some real work.
Tasks

[x] Added/updated documentation

Hello @pmareke and thanks for your interest in Traefik,
As your pull request is fixing a documentation issue,
Can you rebase it to be merged onto v2.5 instead of master?

@pmareke you also have to rebase your branch with the something like:
git rebase --onto upstream/v2.5 upstream/master fix/get-source-extractor-doc


feat: add reminders plugin

Introduces the Reminders plugn allows to insert a list of today's reminders into a daily note, or use within a Template file

Also, the README says that the plugin requires configuration. But the DEFAULT_REMINDERS_CONFIG and minimumConfig are empty. Unless this is just a placeholder for future work you want to do, it would be better to get rid of the configuration steps altogether and just have the plugin "configured" through the template tag. The _configuration note is a placeholder until proper preferences are available in the app. I generally try to avoid it unless the user gets some important benefit from it.

We should revisit this plugin after the changes to NotePlan plugin settings have been implemented.  I like the idea of this plugin, we just need to wait at this point as configuration changes will be different in the very near future.
@weyert @dwertheimer Please review accordingly when the new API has been released.

Is quite stale now and has merge conflicts. I will close until @weyert wants to update.

Cool, yes, going to revisit it next week :)


Combining Efforts

Hey Matt,
First, I wanted to say thanks for posting this and the st_git programs; they definitely helped me to get a better understanding of how the Java API works.  Second, since you seem to be the other person doing a bit more work with Java in Stata I thought it might be helpful for us to pool our efforts?  A fair amount of what I've been doing lately is stored in https://github.com/wbuchanan/StataJSON, but I plan to refactor things a bit moving forward since I'll need to access some of the Java classes from other projects I've been working on. I think there's a ton of potential to expand what Stata can do and figured it might be good to see if anyone else was interested in things.  The three bigger things I'm planning on/working on are JDBC plugins, a Stata wrapper for jMetrik (https://github.com/jpmeyer3/jmetrik and https://github.com/jpmeyer3/psychometrics), and trying to build out something for data visualization (e.g., maybe using some type of embedded browser and using the gwt-d3 library, wrapping d3js myself, or creating non-web graphics using JavaFX).  If you're interested in trying to pool our efforts let me know and I can start pushing a bit more of my work into github (there are a few smaller things using the Java API that I don't have here but one was a proof of concept for one of the classes used by jMetrik (http://www.paces-consulting.org/stata is the net from address and the program is called raschjmle) and a recent update to one of my other programs that uses some Java classes to provide color interpolation).

Hi William!
I continue to be excited by the Stata-Java integration. I believe that it opens up powerful new options that the Stata community has yet to explore.
Last March I moved to a new role that is geared more toward web development than statistical programming. Most of the time that I spend coding these days is in Ruby.
However, you're welcome to add your own work to this repository. If more than one of your projects uses a relatively low-level Stata-Java library of yours, that's a great candidate for this repo: that way you don't have to worry about version conflicts, etc. I'm hopeful that adding classes for integrating Stata and Java to this repo will reduce the onboard cost of other Java early adopters. As the Stata community does more in Java, I don't want programmers to have to repeat the wheel.
I'm thinking about refactoring an existing mostly Mata project of mine: https://github.com/matthew-white/odkmeta. It's one of the few Stata/Mata projects I'm still involved in. The number of classes in the project makes development in Mata cumbersome, and I'm thinking about writing some general-purpose Mata utilities. I'd like to write classes for basic data structures: a stack class, a class wrapper for asarray(), and a better dynamic array. More ambitiously, I'd like to add some language features to Mata and write a compiler for that that converts the Mata-enhanced code to pure Mata. Think classes with constructors!
You're welcome to e-mail me to further discuss any of the above! matthew65536 at gmail.com

Hey Matthew,
I won't get a chance to push things into GitHub till tomorrow morning, but I tried to organize some of my existing java code a bit more.  The repo is at https://github.com/wbuchanan/StataJavaUtilities and currently is just focused on creating a representation of the data in Stata on the JVM.  Eventually I'll get around to building out something to hopefully read a .dta file and do some JDBC stuff, but figured this would be a start.  Thanks for the Mata suggestion on Statalist the other day as well.

Nice, thank you for sharing! Glad to hear the Mata suggestion was helpful. I don't do much Stata visualization myself, but the D3 library you're building looks useful.


Update readme.md

Hello, I just noticed a small error :)

Hey, thanks!

That file is already been re-written in the update I've been cooking.


HBASE-21946 Use ByteBuffer pread instead of byte[] pread in HFileBlock when applicable

Use StreamCapabilities.hasCapabilities() to determine if the pread is supported by the input stream. Use reflection to invoke the bytebuffer pread method when it is available (because the ByteBufferPositionedReadable API is not available until Hadoop 3.3). This way, we can maintain backward compatibility for any Hadoop version above 2.9.
Passed a few unit tests building with Hadoop 3.3.1 and 3.1.2. Open this PR to run through the whole precommit test.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 54s
master passed

+1 :green_heart:
compile
3m 57s
master passed

+1 :green_heart:
checkstyle
1m 27s
master passed

+1 :green_heart:
spotbugs
2m 45s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 35s
the patch passed

+1 :green_heart:
compile
4m  3s
the patch passed

+1 :green_heart:
javac
4m  3s
the patch passed

+1 :green_heart:
checkstyle
1m 23s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 13s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

52m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3434

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 992c1cda610a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 22ec681ad9

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 55s
master passed

+1 :green_heart:
compile
1m 25s
master passed

+1 :green_heart:
shadedjars
8m  7s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 42s
the patch passed

+1 :green_heart:
compile
1m 27s
the patch passed

+1 :green_heart:
javac
1m 27s
the patch passed

+1 :green_heart:
shadedjars
8m 23s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 48s
hbase-common in the patch passed.

+1 :green_heart:
unit
131m 11s
hbase-server in the patch passed.

165m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3434

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a08622e1855f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 22ec681ad9

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/1/testReport/

Max. process+thread count
3640 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 52s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 28s
master passed

+1 :green_heart:
compile
1m 37s
master passed

+1 :green_heart:
shadedjars
8m  7s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  8s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 18s
the patch passed

+1 :green_heart:
compile
1m 38s
the patch passed

+1 :green_heart:
javac
1m 38s
the patch passed

+1 :green_heart:
shadedjars
8m 11s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  2s
hbase-common in the patch passed.

+1 :green_heart:
unit
128m 37s
hbase-server in the patch passed.

171m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3434

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7598c6f678d9 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 22ec681ad9

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/1/testReport/

Max. process+thread count
3407 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 29s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
7m 51s
master passed

+1 :green_heart:
compile
7m 54s
master passed

+1 :green_heart:
checkstyle
2m 53s
master passed

+1 :green_heart:
spotbugs
4m 32s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 27s
the patch passed

+1 :green_heart:
compile
7m  1s
the patch passed

+1 :green_heart:
javac
7m  1s
the patch passed

+1 :green_heart:
checkstyle
2m 21s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
31m 19s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
5m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 47s
The patch does not generate ASF License warnings.

92m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3434

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 1c81363c6ab1 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 51ed95c0cb

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 25s
master passed

+1 :green_heart:
compile
1m 39s
master passed

+1 :green_heart:
shadedjars
8m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  7s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 19s
the patch passed

+1 :green_heart:
compile
1m 42s
the patch passed

+1 :green_heart:
javac
1m 42s
the patch passed

+1 :green_heart:
shadedjars
8m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  7s
hbase-common in the patch passed.

+1 :green_heart:
unit
138m 55s
hbase-server in the patch passed.

175m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3434

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux adcb2c0eaf1f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 51ed95c0cb

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/2/testReport/

Max. process+thread count
4129 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 48s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 10s
master passed

+1 :green_heart:
compile
1m 28s
master passed

+1 :green_heart:
shadedjars
10m 53s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 12s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 51s
the patch passed

+1 :green_heart:
compile
1m 49s
the patch passed

+1 :green_heart:
javac
1m 49s
the patch passed

+1 :green_heart:
shadedjars
10m 46s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 59s
hbase-common in the patch passed.

+1 :green_heart:
unit
152m  6s
hbase-server in the patch passed.

194m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3434

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 093dbe96d8b1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 51ed95c0cb

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/2/testReport/

Max. process+thread count
3732 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3434/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks @Apache9 . Took me a few days because I initially thought it's either impossible or requires lots of dirty hack to add a UT. But turns out it's quite straightforward. I'll merge later.


Draft: Add inconsistent schema validator

Closed as: https://github.com/thephpleague/openapi-psr7-validator/issues/222#issuecomment-2041074971


Add University of Chinese Academy of Social Sciences

Add University of Chinese Academy of Social Sciences

@kingdh Pull request merged. Thank you!