Getting the "Best" of all feasible solutions

Hi all,
I am using or-tools in an environment of ingredients and nutrients(SolveStigler). Basically you have some ingredients each one of them with a cost and with some nutrients. So, given some constraints about the minimum and maximum amount of each ingredient I have to get the specified nutrients with the minimum price.
The specified nutrients also have a constraint about the minimum amount (but the maximum amout is Infinite).
If I got it right, if the solver returns a Feasible result, means that no optimal solution has been found. So, in this case, means that I have got N solutions that accomplish the specified nutrients with the minimum cost.
Now, I would like to chose from all the Feasible solutions, the one with the maximum amount of nutrients.
Is it possible?

Change the objective to add a secondary term that is the amount of nutrients produced, or,
solve once, store the optimal value, change the mode to add a constraint that you cannot degrade the first objective (usually with a small tolerance), then resolve with a second objective that is the amount of nutrients.

model = cp_model.CpModel()
model.Add(sum([xi*pi for xi, pi in zip(x, p)]) >= min_value)
model.Minimize(sum([xi*int(pi*100) for xi, pi in zip(x, p)]))

this is my code ,why the sovler continue running even object value is already min_value and status is FEASIBLE not OPTIMAL

This makes no sense in this issue.


[nrfconnect] Added Lighting-Switch-App example

Problem

Add Lighting-Switch-App example for the nrfconnect boards.

Change overview

Added example of Light-Switch-App for nRF52DK and nRF53DK boards

Added documentation

Testing

Tested manually on nRF52DK and nRF53DK using the lighting-app example as a bound device.

/rebase


export error

dbeaver 4.0.1
SET @variable =	'X';
SELECT * FROM Table WHERE Field = @variable;
It produces result rows but the export wizard seems to only execute the SELECT command, forgetting the SET instruction. So the export fails with empty file.

Yes. Export from multiple queries is not supported.
It can be done in MS SQL (execute multiple queries as a single statement) but not in MySQL.

I need this function and It works in DBeaver 3.8.3 with MySQL, so I am still using it.
So I can't upgrade to DBeaver 4?

WOW!
On 4.0.2 this function works again.
Great job! Thank you so much!

This is a side effect of default config options change.
In 4.0 DBeaver open separate connection for each SQL editor by default. Now it uses the same connection for all editors (this can be changed in preferences).


Bug: Cannot create monitors

Describe the bug
When trying to create a new monitor or duplicate an existing monitor i get a "Server Error" - see the attached Screenshots
To Reproduce
Steps to reproduce the behavior:

Go to the tab "Monitors"
Click the button "+ Create Monitor"
Fill in all values you want the monitor to have
Click the button Next
Fill in all values for the Criteria you want the monitor to have
Click the button Next
Select the Monitoring Interval you want the monitor to have
Click the button "Create Monitor"

Expected behavior
A new created Monitor
Screenshots
See the attached Screenshots
Desktop (please complete the following information):

Browsers: tested with chrome and firefox

Deployment Type
self hosted docker images
last updated yesterday(12/06/2024)
current dashboard version: 7.0.2525

Can you please attach the logs from the app container.

oneuptime-app-1.log

Since this is self-hosted and you dont have a support contract with us, there's nothing we can do unfortunately.
Closing this issue.

@andreaswendlandt
After updating from 7.0.2380 to 7.0.2721, I experienced the same issue.
ALTER TABLE "Monitor" ADD COLUMN "incomingMonitorRequest" jsonb;
ALTER TABLE "Monitor" ADD COLUMN "serverMonitorResponse" jsonb;

did the trick for me.


Make company test deterministic

Issue number: N/A
Description of change
TestListCompanies.test_sort_by_name was using random data which was causing it to sometimes fail because of the way Postgres implements sorting.
Checklist
~* [ ] Have any relevant search models been updated?~
~* [ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?~
~* [ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?~
~* [ ] Has the admin site been updated (for new models, fields etc.)?~
~* [ ] Has the README been updated (if needed)?~

Codecov Report

Merging #1035 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1035   +/-   ##
=======================================
  Coverage     96.5%   96.5%
=======================================
  Files          212     212
  Lines         5887    5887
  Branches       564     564
=======================================
  Hits          5681    5681
- Misses         141     142    +1
+ Partials        65      64    -1

Impacted Files
Coverage Δ

datahub/core/admin.py
82.6% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13d8c40...b849a61. Read the comment docs.


[skip ci]

[skip ci]

/package

/package

/package

/package

/package

/package

/package

/package

/package

/package

/package

/package

/package

/package

/package

/package

/package

/package


opae.io: check for non-empty line

Coverage decreased (-0.04%) to 77.907% when pulling e959dd07546adef6c41e00ade11aa893f4984b99 on rrojo/opae.io-fixes into 58764387ec492e9d33a97ffca530d3f6d2b07dae on master.


Added ucwords to String helper

I needed to take an uppercase string, lower it then upper case the first letter of each word.
Currently i have to do this: ucwords((string)Str::of($value)->lower()),
Now i can do this: (string)Str::of($value)->lower()->ucwords(),

Would the title() method already cover this?
Str::of('MIXED case WoRdS')->title()->value()
// "Mixed Case Words"

Ah probably. I thought it must have been in there I just couldn’t find it. Thanks
On 25 May 2022, at 4:59 pm, Derek MacDonald @.***> wrote:

Would the title() method already cover this?
Str::of('MIXED case WoRdS')->title()->value()
// "Mixed Case Words"
—
Reply to this email directly, view it on GitHubhttps://github.com/laravel/framework/pull/42509#issuecomment-1136840140, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPOCCW4ZERDHVHWXDTHCG3VLXFUXANCNFSM5W34CFBA.
You are receiving this because you authored the thread.Message ID: @.***>


[Bug] Cannot get info of chain

Bug report
graphman chain info <name> does not seem to work and complains of a missing parent hash. I'm running v0.32.0.
Relevant log output
root@goldskyraw-indexer-0-graph-node-5dd9464b5b-26n7g:/# graphman chain info mainnet
Error: missing field `parentHash`
root@goldskyraw-indexer-0-graph-node-5dd9464b5b-26n7g:/# graphman chain info matic
Error: missing field `parentHash`

IPFS hash
No response
Subgraph name or link to explorer
No response
Some information to help us out

[ ] Tick this box if this bug is caused by a regression found in the latest release.
[ ] Tick this box if this bug is specific to the hosted service.
[X] I have searched the issue tracker to make sure this issue is not a duplicate.

OS information
None

Hey @paymog , is there any additional steps for reproducing this? Im not able to reproduce this.

Unfortunately I don’t know how to reproduce either 😕

Defenetly wierd, but i wonder whats happening. This was working before 0.32 right?

I never tried this in an older version so I'm not sure 🙁

@paymog are you using a Firehose or an RPC for the block ingestor?

@paymog are you using a Firehose or an RPC for the block ingestor?

I'm using firehose for the two chains in the original example

This bug can be reproduced on a chain synching entirely using Firehose.
graphman chain info matic
Error: missing field `parentHash`

graphman chain info mainnet
Error: missing field `parentHash`

It must be related to how the blocks are stored when using firehose ingestor: the graphman assumes there will be data that is inexistent.

thanks @sduchesneau - @incrypto32 do you know if we store the parentHash with a Firehose block ingestor, or might that be the source of the issue?


Updated upstream to 1.1.0

After the successful merge, please release a new docker hub image with an individual tag.

Thanks!

I precipitated in this merge. The master version is ahead of 1.1.0 (a23d13d). Please use that one instead.

I knew, but that has not been released yet. Do you want to be on the master?


Example 1 is missing Sprites.

The example project is missing the Sprites required to open funny_building.tscn, while not super import does give warning when opening the scene.

Issue has been fixed and the template is now updated


Census_Household: Show further guidance on add another person not working

Expected behaviour
Must allow user to expand the Show further guidance for person 2 onwards or remove that as we already have one.
Actual behaviour
When a additional person is added does not allow user to expand the guidance
Steps to reproduce the behaviour
Launch Census_Household survey
Navigate to Question 2 under who lives here
Click add another person
Click on 'Show further guidance' for person 2
Technical information
Browser
Operating System
Screenshot

Actually this is the issue: https://github.com/ONSdigital/eq-survey-runner/issues/737
Can we close this one?

Sure


Test Data Class

I use this library in many different orgs and as such I find that there are quite a few different instances where field requirements are put in place. Whenever I newly install this package or have to update it, I have to remember to manually update every place an account, contact, and activity are used rather than just updating a test data class.
Any thoughts on whether is makes sense or not to work on adding this functionality?

Can you elaborate more on what you mean by 'manually update every place an account, contact and activity are used rather than update a test data class' ? Is this because you have validation rules in your org on these objects that cause the tests to fail? If so, yes i get it, a single Test Data Class would be a good idea.

@tmowbrey For creating records, I've had great success using @dhoechst TestFactory

@afawcett As an example, in fflib_SObjectSelectorTest, there are multiple methods using the same account data setup information. When I install it in one org (or update), I have to add BillingCountry to each method, copy+pasting each time. In another org I have to add BillingState and Billing Country. While not a large issue, the copy+paste leads me to believe that this information should be consolidated into a separate class for data generation to make updating test data easier when required. I think adding in functionality similar to the package @daniel-huckins has mentioned would help enforce some best practices when using the library as well as help increase the usability of the library.
Thoughts?

Yeah got it, sounds good, though i think there are plenty of good libraries doing this, in this case, for better internally management of test data can we just factor into a single test data setup class perhaps, that would address your need and not add to much more bloat to the library (i'm hoping to get round to review thoughts elsewhere in this repo to modularising this at somepoint).

I am currently arguing with myself the pro and cons of:

Use the library "as-is", making it easy to maintain but leaving questions about long term implementation and extending functionality. I'll refer to this option as "Fostering"

Removing the fflib_ prefix and making the library our own. Allowing us to customize without some fancy extending of the classes, and also providing clarity in our repository (when using 3rd party library I'd like to refer to it as 3rd party package and not manage it in our codebase). I'll refer to this option as "Adopting"

This issue is actually one of the conflicts that has me feeling more confident about option 2 in the long run. We have validation rules that cause the DML operations in the test to fail, so I can't see around modifying the test directly use my Forge.cls which handles the org's validations rules when creating an object instance.
I guess in your opinion when is it valid to "Adopt" the library and maintain it manually verses "Fostering" it as a 3rd party library within our codebase?

@Xtremefaith i totally misunderstood your original question here. I now understand your issue about different org shapes and validations impacting the test for the library.
I think the best way to approach this is to use more mocking and/or making the tests more agnostic if possible. Can you get the ball rolling with like a top 3 most common test failures and why?
We can then come up with some ways to either avoid making changes (better more org agnostic tests) or at the very least make your code edits easier via some more centralised approach in the lib.
Hows this sound?

@afawcett Sounds great! So one of my first issues was just getting fflib into my environment. For example fflib_QueryFactoryTest.cls has multiple instances of inserting a new task. Because my org has a validation rule that requires a certain prefix on the Subject I now need to add a value to the Subject field prior to INSERT. At the moment I have resolved this by creating each object through my Forge class like so:
Task tsk = (Task) Forge.createSObject('Task');

This class then accounts for all org related validation rules. But the fact that I've now edited code from an external library/repository feels dirty. I feel  I either should adopt this codebase as my own and possibly drop the fflib_ prefix or I should just reference this from a managed package where perhaps FFLIB is the namespace.
At the moment I believe this is the only real conflict, as you mentioned I stub everything else through mocking. I still haven't established our domain model yet as I've just been working through the learning curve of these patterns (studying PEAA from Martin Fowler), ApexMocks, and the best approach to implementing this code base and its future with our own code base and its future.

Yep this helps, the requirement seems clear now. Some kind of abstraction or perhaps a test plugin means to customize the way standard objects are initialized in tests. So if there was say fflib_ITestHelper interface and the tests looked for a class called say FFLibTestHelper that implemented the interface. The interface would have methods like createTask. The framework could include base impl of the interface you could extend and override. Would something like this work?
NOTE: If you put fflib in a managed package, you will need to make all the classes global and the prefix will be fflib.fflib_SObjectDomain (for example). Also you will inhibit upgrades to the library, since global has constraints that are not neccessarly constraints when evolving the library.

I think this will work, not sure I completely understand what you have in mind but yes the ability to extend/customize the way objects are initialized in tests would be great!
Meanwhile I'm in the Salesforce DX pilot and attempting to package fflib in its own "app" to see if this is a more viable means of "packaging" it within our org's codebase. I think this will work in the long run just not 100% sure how it will all work together just yet but I'll keep you posted.

Excellent, thanks @Xtremefaith for the update. Yes we are also in the SFDX pilot and very keen to explore how libraries can be used in it. Keep us posted on your findings! 👍

@afawcett if you have a chance I posted some findings in the DX chatter group, one specifically on ApexEnterprisePatterns as a separate workspace, but unfortunately when it gets to dependencies questions within DX the forum seems to go stale. I currently have it setup as a workspace, with an AEP project, and ApexMocks and fflib as apps within the project. like so:

/ApexEnterprisePatterns/AEP/ApexMocks/default/
/ApexEnterprisePatterns/AEP/FFlib/default/

Again though no confirmation from anyone on their end to determine if this is inline with DX and more importantly Packaging 2.0 when it comes to deployment. I also started a #dx channel on the Salesforce Community Slack Team as a means to chat about some opinions  surround DX build outs and deployment strategy.
As of right now I feel really prepared to use this patterns but I'm struggling to force it into a segmented DX structure as I feel it should.

@Xtremefaith i need to check my access on the chatter group, as the link is not working for me. How is the discussion going since your last post above?

@afawcett Since our last post I have been able to put both what I refer to as "Apex Enterprise Patterns" (AEP), and ApexMocks into their own artifacts within my org's code repository like so:

As you can see as long as I define each package (or "artifact") within the sfdx-project.json like so then when I push to a scratch org or convert using the force:source:convert then it will compile the metadata accordingly and put it in the org properly (bar any name collisions, hence I keep the prefixes as they are).

Note: You can see that in this way I can separate the default files from the test without an issue, and I can maintain AEP and ApexMocks separately as you have or collectively if desired. When I put this in a new org I get 93% code coverage out of the box
As you can see from the first screenshot, I intend to separate regional development (US, UK, AU, etc.) in separate artifacts (possibly package 2.0 packages) that will depend on everything within core which includes FFLib. Hope that update helps some!

This is very cool! @phardakerffdc FYI

Has there any developments with this issue? I just came across the issue again in another org where a a specific field was set to required required on Task/Events and now I have 9 fflib_ classes failing. So naturally I'm again questioning the best practice for now.

I'll admit that I didn't read this whole thread but the gist is that integration tests fail in some orgs due to validation rules or other constraints applied to Standard Objects. We made improvements in prior years to mock away some raw DML in various test methods/classes and that has improved things .. but there will always be gaps. We can't mock away the database in every test case since this library is basically all about interfacing with the database


Add Kotlin DSL entry

Add Kotlin DSL from @mnbjhu . It is a standalone driver in addition to being a DSL.

@kearfy could you merge this please?

There you go!


ignore editor backup/dribble files in plugins directory, to avoid duplicate output

I edited one of my plugins with emacs, which leaves backup files like plugin.60m.sh~ lying around afterwards. Most programs have a list of suffixes to ignore, but apparently bitbar doesn't, because I saw the plugin's output appear twice on the menubar (once with the updated content, once with the old content from the backup file).
Debian's "run-parts" tool might be a useful model to follow: it only looks at names that consist entirely of ASCII upper+lowercase letters, digits, underscores, and hyphens.
thanks for the great tool!

While this doesn't solve the issue of BitBar running multiple instances, you can add this to your .emacs to move all temp files to your temporary directory. I've used this since I started using emacs and it's removed my frustrations with .gitignore rules and just random cruft files.
(setq backup-directory-alist
      `((".*" . ,temporary-file-directory)))
(setq auto-save-file-name-transforms
            `((".*" ,temporary-file-directory t)))

Is the ~ suffix common enough to have BitBar explicitly ignore that?

BitBar does currently ignore files prefixed with a dot, so I'm not against having a list of things to ignore.

@matryer AFAIK, any file ending in ~ is a backup of a file that was edited by emacs, vi, nano, et. al. On that note, if we were to implement a ignore list, we'd probably also want to add *.swp to that list.


elemMatch

Hi, I have some troubles to use elemMatch. Here is my array (or collection mongodb) :
var couples = [{
name: "SMITH",
person: [
{
firstName: "craig",
gender: "female",
age: 29
},
{
firstName: "tim",
gender: "male",
age: 32
}
              ]
          },
          {
              name: "JOHNSON",
              person: [
                  {
                      firstName: "emily",
                      gender: "female",
                      age: 35
                  },
                  {
                      firstName: "jacob",
                      gender: "male",
                      age: 32
                  }

              ]
          }];

I have two tests :
sift({"person.gender": "female", "person.age": {"$lt": 30}}, couples) => ok 1 result but a chance
sift({"person.gender": "male", "person.age": {"$lt": 30}}, couples); => KO
The mongodb commands are :
db.couples.find({"person": {"$elemMatch":{"gender": "female", "age": {"$lt": 30}}}}) => OK 1 result
db.couples.find({"person": {"$elemMatch":{"gender": "male", "age": {"$lt": 30}}}}) => OK no result
Can you add $elemMatch in sift ?
Thanks

Done! $elemMatch has been added to 1.1.0.

Hi ! Thanks for your reactivity. But I still have trouble :
sift({"person": {"$elemMatch": {"gender": "female", "age": {"$lt": 30}}}}, couples)
=> OK 1 result
sift({"person": {"$elemMatch": {"gender": "male", "age": {"$lt": 30}}}}, couples)
=> KO 1 result, should have 0 result
Furthemore, I tried 2 combined elemMatch (with a $and) and the result is wrong :
sift({"$and": [{"person":{"$elemMatch":{"gender": "male", "age": {"$gte": 32}}}},
{"person":{"$elemMatch":{"gender": "female", "age": {"$gt": 30}}}}]}, couples)
=> KO 2 results, should have 1 result

Hmm - seems like $elemMatch has introduced a new bug that requires some refactoring. Should be fixed here in a little bit.

+1 this is a very useful operator for what I'm implementing.

Currently working on this


Missing cached latent files for dexgraspnet_dataset.py

Thank you for your excellent work. However, when running the command python model/ugg/hand_vae.py --cfg experiments/ugg_hand_vae_train.yaml, we encountered an issue at line 154 of dexgraspnet_dataset.py. The error message is as follows:
FileNotFoundError: [Errno 2] No such file or directory: 'data/meshdata/core-bottle-10dff3c43200a7a7119862dbccbaa609/coacd/pc_norm_latent_LION_006.pk'

It appears that the cached latent file mentioned in the error needs to be generated in advance. However, we couldn't find any instructions on how to generate this file. Any guidance on this matter would be greatly appreciated.

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Try to set USE_PRECOMPUTE_PC: True to False in the config file.

thx, that resolves the issue


Not functioning

I've included this package and have published the mentioned configs and set up my API key in .env; I have extended my Exception Handler as instructed. I am not getting any exceptions in my BugSnag control panel, even when calling Bugsnag::notifyError('ErrorType', 'Test Error'); from tinker.

Hi @aewing, can you provide some additional information:

What version of Laravel are you using?
What version of PHP are you using?

Closing as we haven't heard back.


RegisterTask fails on windows 10 (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)

I am running the example given on https://taskscheduler.codeplex.com/ on my localPC.
CODE:
using (TaskService ts = new TaskService())
{
// Create a new task definition and assign properties
TaskDefinition td = ts.NewTask();
td.RegistrationInfo.Description = "Does something";
     // Create a trigger that will fire the task at this time every other day
     td.Triggers.Add(new DailyTrigger { DaysInterval = 2 });

     // Create an action that will launch Notepad whenever the trigger fires
     td.Actions.Add(new ExecAction("notepad.exe", "c:\\test.log", null));

     // Register the task in the root folder
     ts.RootFolder.RegisterTaskDefinition(@"Test", td);
  }

I see this Behaviour:

This fails on Windows 10 PC.
This works on WIndows 7 PC.
This works on Windows 10 PC if I start the application as "Run as administrator"

Error Details:__
Microsoft.Win32.TaskScheduler - Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))
at Microsoft.Win32.TaskScheduler.V2Interop.ITaskFolder.RegisterTaskDefinition
at Microsoft.Win32.TaskScheduler.TaskFolder.RegisterTaskDefinition
at Microsoft.Win32.TaskScheduler.TaskFolder.RegisterTaskDefinition
I want to run the application without using "Run as Administrator" on windows 10. Can you suggest a fix.
__
Originally posted: 2017-06-20T11:53:23

Same error in Windows Server 2016, version 1607.
I'm working with the last release version of the task scheduled managed wrapper, 2.5.27
Originally posted: 2017-06-27T05:22:34

From the documentation (http://taskscheduler.codeplex.com/wikipage?title=TaskSecurity):

By default, to schedule a task, you must be a member of the Administrators, Backup Operators, or Server Operators group on the local computer.
By default, when creating a scheduled task, you cannot enter a user who belongs to a group that has more rights than the group you belong to.
By default, a user who creates a task can read, update, delete, and run the task.
Members of the Administrators group or the SYSTEM account can read, update, delete, and run any tasks. Members of the Users group, the LocalService account, and the NetworkService account can only read, update, delete, and run the tasks that they have created.

Originally posted: 2017-06-27T08:19:37

The task is trying to be registered with an account who is member of the Administrator group.
Originally posted: 2017-06-29T03:48:56

See attachment, the user used is TestUser4.
Originally posted: 2017-06-29T06:03:20

Please try running the troubleshooter @ https://taskscheduler.codeplex.com/releases/view/622295
Originally posted: 2017-07-01T10:32:25

You can see the errors showed by the Troubleshooter, running with my user TestUser4 who belongs to the Administrator group. And also has full rights in the C:\Windows\Task folder. I don't understand why the troubleshooter is showing that.
Do you have an idea?
Originally posted: 2017-07-03T08:40:24

Please see the attachment TroubleShooter.jpg
Originally posted: 2017-07-03T08:41:51

Do you happen to know if, when run, the Troubleshooter either was run as Administrator or if they clicked the option to run as administrator in the first page of the wizard? Failing to do either could product the results you're seeing. Also, unless you are specifically calling the TaskService constructor with all 5 parameters and setting the last parameter to true (forceV1), then only the V2 related items in the Troubleshooter are relevant.
Also, is that happening with other accounts on other Windows 10 installations?
Originally posted: 2017-07-04T14:42:59

The Troubleshooter was running with an administrator account. I have tested to click the option to run as administrator in the first page of the wizard, and the troubleshooter advise me to give the right "Log on as a batch job". This right is enabled by default for the Administrator group, to which my account belongs.
The behaviour is reproduced in other Windows 10 installations? Just, to be clear, I am logged as administrator in the machine (with a domain account), but not with the default administrator.
Originally posted: 2017-07-06T01:54:25

Let's try this: I have uploaded a zip file with a small app that can run small code snippets against the Task Scheduler library (TestTaskLibConsole.zip). On an offending system, extract the files to a folder and then run TestTaskLibConsole.exe in the same account as your prior tests withing running the application as Administrator. Also in the zip file is a file "testcode.cs" that contains the snippet you have reported as failing. You can open this file from the console program or paste its contents into the console window and then click the Run button. If it fails, please send me a snapshot of the window.
I have tried this snippet in the console on Win 10 (1703 & 1607) and Server 2016 (1607) without any failures. I am running in a domain account that is a member of the local machine's Administrators group. In the zip file is a "capture.png" image that has a clip of the output from Win 10.
Hopefully this will help us narrow your problem.
Originally posted: 2017-07-06T16:49:04

It works. What have you changed?
Originally posted: 2017-07-10T09:14:39

It doesn't work if I add running the task with highest privileges.
As you can see in the attachment "highest.jpg".
Originally posted: 2017-07-10T09:24:04

So it appears this is a security feature of the Windows base library and not this wrapper. Let me know if I can close this issue now.
Originally posted: 2017-07-12T04:43:31

Yes, thanks for your help Dahall.
Originally posted: 2017-07-12T06:55:43

Originally posted: 2017-07-20T09:30:05


New stateful telnet base class that react to keys

It was impossible (or very hard) to make the StatefulTelnetProtocol react to a single character and that was needed for the upcoming fake DELL support.
The new class implements Telnet directly and handles data on a key basis, stating that the server will echo character (self.will(ECHO)) and will not wait for an "enter" (or "go-ahead") to act by supressing go-ahead (self.will(SGA))
Inheritors of the class can change the self.handler to change the state

:+1:

:100:


Merge next into main

Once we merge this, I will set the default branch to next until v7 stable is released.


audio: remove audio_srate and audio_channels

remove these config options:
audio_srate            8000-48000
audio_channels         1-2
these options has no practical usage, except to limit the
enabled audio codecs to the range of samplerate/channels
as specified.
if a module has multiple audio codecs, and you only want
to use one of them, this can now be done with the
"audio_codecs" parameter to the "accounts" file.

extra note: these config options were added a very long time ago, and is not really needed.
so I propose to remove them.
if someone is still using them, or disagrees with this PR, please state your opinion here :)
Alfred

Alfred E. Heggestad writes:

remove these config options:
audio_srate            8000-48000
audio_channels         1-2

How about ausrc_srate, auplay_srate, ausrc_channels, auplay_channels?
Are they too deprecated?
-- Juha

no, these config options are not deprecated. they are used to force the soundcard
to a specific sample rate/channels.
by default, the soundcard will be started with the same samplerate/channels
as the audio codec used, to get the best possible audio quality without latency.
if one of these options are specified, and it differs from the selected audio codec,
the audio resampler will be used.

Alfred E. Heggestad writes:

by default, the soundcard will be started with the same samplerate/channels
as the audio codec used, to get the best possible audio quality
without latency.
if one of these options are specified, and it differs from the
selected audio codec, the audio resampler will be used.

Thanks for the explanation, Juha


fix: make build args order and doc fixes

06fa1390 seemed to introduce an issue, when make build ends with
go build ./cmd/korrel8r -o _bin/korrel8r
malformed import path "-o": leading dash

Fixed in subsequent releases.


can't inspect external style sheets

If an element has its style included using a  tag from another file, the style sheet is not visible in the chrome inspector. It seems that it is read in programmatically and inserted as inline

Closing this issue due to age and the release of version 1 of Polymer - please feel free to re-open if this is incorrect.


CLI: syscall exec instead fork+exec (cmd.Run)

[ ] split app.App
[ ] split and turn on tests
[ ] check all TODOs

btw, say
go install github.com/michurin/systemd-env-file/cmd/xenv@syscall_exec

to play around this exec approach

Codecov Report

Merging #4 (3491880) into master (445d36f) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff            @@
##            master        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         2    -1
  Lines          222       153   -69
=========================================
- Hits           222       153   -69

see 1 file with indirect coverage changes


CUDA out of memory with hyena-1m on A100-80G

Hello,
Thank you for sharing such great work!
Based on the A100-80G, I tried to use hyena-1m on a species classification task but got the error "CUDA out of memory."
Here is my training command
python -m train wandb=null experiment=hg38/species dataset.species=[human,mouse,hippo,pig,lemur] train.global_batch_size=256 optimizer.lr=6e-5 trainer.devices=4 dataset.batch_size=1 dataset.max_length=1000000 dataset.species_dir=/data/species_cls/ model.layer.l_max=1000002 model.d_model=256 model.n_layer=8 trainer.max_epochs=150 decoder.mode=last train.pretrained_model_path=null train.pretrained_model_state_hook=null
I noticed that the A100-80G should be able to train 1m models. Is there anything extra I should be aware of?

Thank you!
See the README here for checkpointing, which you need to turn on.

Thanks a lot!
It works now, but the loss goes to nan after 3 epochs. Is this normal in train from scratch?

You also need to set the precision to bf16, and play with the learning rate.
train.precision=bf16

I see. BTW, have you tried hyena on LRA Benmarks? I went to the safari repo and couldn't find a corresponding config, and setting one up myself didn't work well. Do you have any suggestions?

No we did not, we focus on DNA here :)


Update expected ALPN output for recent versions of curl

Recent versions of curl have updated their ALPN negotiation logging.
This updates a gold file to accommodate that new output. The update
should be backwards compatible.

Cherry-picked to v9.2.x


[naver] Add support for live videos

@SeonjaeHyeon
https://github.com/ytdl-org/youtube-dl/pull/26610

This feature is working fine for me (in my country), but as I said in PR, there might be geo-restriction on live streams.
If you have no problem when you do test this, then you can merge PR. 😃

Thanks for your quick response. 😄


Contributor profile badges

The goal of this issue is to highlight developers who have contributed to the RailsDevs source code. To start, this will not integrate with GitHub in any way.  And the best part is, once a contributor always a contributor!
A PR addressing this issue should:

[ ] Add a new boolean (non-null) column, developers.source_contributor defaulted to false
[ ] If true, render a badge in the developer's card in search results
[ ] If true, render a badge on the developer's profile page
[ ] Add a new column to the table on /admin/users to toggle the status of that boolean

Note that the badge can follow the existing design patterns for "Featured developer" and "Recently active" but with the following colors classes: bg-gray-100  text-gray-800.
Also, the last item in this checklist will probably require a new route and controller for updating the status on the developer. Admin::DevelopersController with only the source_contributor param permitted could work!

I'd like to take this on

Sure thing, all yours @benmercerdev! Thanks for contributing.

Hi @joemasilotti can you add me as a collaborator or give me permission to push my branch with this work for comments and review, thanks!

I put up a draft PR https://github.com/joemasilotti/railsdevs.com/pull/677
Would love some advice on the UI to toggle the source_contributor attribute and also on the route and controller for that action

Closed via #677.


Question Regarding CAMPAIGNER/AGENT/FACILITATOR Labels

We are currently working on the Oppositional Analysis task but we are not sure about the difference between the labels: Campaigner, Agent, and Facilitator. Could you please provide some insight into how these categories were assigned?

check the newly added .pdf file with a conceptual overview


Add continue vide play after finish current

When current video finished playback next video will be presented

@oxozle sorry for the inactivity, could you fix the merge conflicts?

Fixed

Sorry . about this again, could you fix the conflicts. :( my fault.


Notebooks are saved with orig_nbformat attribute

Environment data

VS Code version: 1.81.1
Jupyter Extension version (available under the Extensions sidebar): v2023.7.1002162226
Python Extension version (available under the Extensions sidebar): v2023.14.0
OS (Windows | Mac | Linux distro) and version: Ubuntu 23.04
Python and/or Anaconda version: 3.11
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): poetry
Jupyter server running: Local

Expected behaviour
I belive the orig_nbformat should not be persisted in the ipynb file.
A similar discussion was found on jupyterlab 11005 in 2021. Indeed nbconvert documents that it should never be written to file:
"orig_nbformat": {
    "description": "Original notebook format (major number) before converting the notebook between versions. This should never be written to a file.",
    "type": "integer",
    "minimum": 1
},

It is apparently only an in-memory attribute.
Actual behaviour
The extension adds orig_nbformat this field for new notebooks.
Steps to reproduce:
Create empty.ipynb file in VSCode explorer, save and cat the file.
{
 "cells": [
  {
   "cell_type": "code",
   "execution_count": null,
   "metadata": {},
   "outputs": [],
   "source": []
  }
 ],
 "metadata": {
  "language_info": {
   "name": "python"
  },
  "orig_nbformat": 4
 },
 "nbformat": 4,
 "nbformat_minor": 2
}

This is a practical issue when trying to modify the notebook with nbformat in a round-trip fashion.
Since this removes the orig_nbformat:
import nbformat

with open("empty.ipynb", "r") as infile:
    notebook_content = nbformat.read(infile, as_version=4)

with open("out.ipynb", "w") as outfile:
    nbformat.write(notebook_content, outfile)

--- empty.ipynb 2023-09-02 23:50:20.121756145 +0200
+++ out.ipynb   2023-09-03 00:18:58.392848486 +0200
@@ -11,8 +11,7 @@
  "metadata": {
   "language_info": {
    "name": "python"
-  },
-  "orig_nbformat": 4
+  }
  },
  "nbformat": 4,
  "nbformat_minor": 2


Please add a license file

Hi everyone, thank you for a really neat solution that you have provided!
I am working on a project at the moment, and I want to leverage your solution.
Would it be possible to add a LICENSE file to the project? For example, I am always using MIT License for my projects.
This way I can make a proper attribution to your project and give you the credit that you deserve.
Thank you!

Hey, thank you for pointing this out! This repo contains result of project generation by AWS SAM CLI (which source is licensed under Apache-2.0, but I have no idea whether it is applicable to its, um, output) and my own work on top of it.
Declared this project as MIT licensed, as I also tend to use this license for open-source work.
P.S> You're also welcome to contribute to cookiecutter-aws-sam-typescript-layers which is a template to generate projects like this example, but from scratch.


update ng-datepicker.component, no works with slimscroll (now is updated)

{
"name": "project",
"version": "0.0.0",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e",
"dev:ssr": "ng run multikart-backend:serve-ssr",
"serve:ssr": "node dist/server/main.js",
"build:ssr": "ng build --prod && ng run multikart-backend:server:production",
"prerender": "ng run multikart-backend:prerender"
},
"private": true,
"dependencies": {
"@angular/animations": "~9.0.0",
"@angular/cdk": "^9.0.0",
"@angular/common": "~9.0.0",
"@angular/compiler": "~9.0.0",
"@angular/core": "~9.0.0",
"@angular/forms": "~9.0.0",
"@angular/platform-browser": "~9.0.0",
"@angular/platform-browser-dynamic": "~9.0.0",
"@angular/platform-server": "~9.0.0",
"@angular/router": "~9.0.0",
"@ks89/angular-modal-gallery": "^7.2.5",
"@ng-bootstrap/ng-bootstrap": "^5.2.1",
"@nguniversal/express-engine": "^9.0.0",
"@swimlane/ngx-charts": "^13.0.2",
"@swimlane/ngx-datatable": "^16.0.3",
"angular-count-to": "0.0.3",
"bootstrap": "^4.4.1",
"chart.js": "^2.9.3",
"chartist": "^0.11.4",
"classlist.js": "^1.1.20150312",
"express": "^4.15.2",
"feather-icons": "^4.26.0",
"flag-icons": "^2.0.0",
"font-awesome": "^4.7.0",
"hammerjs": "^2.0.8",
"mousetrap": "^1.6.5",
"ng-animate": "^0.3.4",
"ng-chartist": "^4.1.0",
"ng2-charts": "^2.3.0",
"ng2-completer": "^3.0.3",
"ng2-datepicker": "^3.1.1",
"ng2-google-charts": "^5.0.0",
"ng2-smart-table": "^1.5.0",
"ngx-ckeditor": "^8.0.0",
"ngx-dropzone-wrapper": "^8.0.0",
"ngx-owl-carousel-o": "^2.0.3",
"ngx-slimscroll": "^8.1.0",
"rxjs": "~6.5.4",
"screenfull": "^5.0.1",
"tslib": "^1.10.0",
"web-animations-js": "^2.3.2",
"zone.js": "~0.10.2"
},
"devDependencies": {
"@angular-devkit/build-angular": "~0.900.1",
"@angular/cli": "~9.0.1",
"@angular/compiler-cli": "~9.0.0",
"@angular/language-service": "~9.0.0",
"@nguniversal/builders": "^9.0.0",
<EMAIL_ADDRESS>"^2.9.13",
"@types/express": "^4.17.0",
"@types/hammerjs": "^2.0.36",
"@types/jasmine": "^3.5.3",
"@types/jasminewd2": "~2.0.8",
"@types/mousetrap": "^1.6.3",
"@types/node": "^12.11.1",
"codelyzer": "^5.1.2",
"jasmine-core": "~3.5.0",
"jasmine-spec-reporter": "~4.2.1",
"karma": "~4.4.1",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage-istanbul-reporter": "^2.1.1",
"karma-jasmine": "~3.1.0",
"karma-jasmine-html-reporter": "^1.5.2",
"protractor": "~5.4.3",
"ts-loader": "^6.2.1",
"ts-node": "~8.6.2",
"tslint": "~6.0.0",
"typescript": "^3.7.5",
"webpack-cli": "^3.3.10"
}
}
error:
when compile ,I got this error
I tried to fix it by downloading a version, but surely as the slimscroll version change was broken, the change was done locally, below I leave you the error.
ERROR in node_modules/ng2-datepicker/node_modules/ngx-slimscroll/dist/app/ngx-slimscroll/classes/slimscroll-options.class.d.ts:1:10 - error TS2440: Import declaration conflicts with local declaration of 'ISlimScrollOptions'.
1 import { ISlimScrollOptions } from './slimscroll-options.class';

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

When will the change be merged? Struggling with this problem atm.


[question] - more detailed classification

I am interested in more detailed classification of human pose, something like here:
https://github.com/ashafaei/dense-depth-body-parts
How hard would it be to customize this project to provide more details? I think better resolution will help with identification when some parts are hidden/out of camera view, etc.
Thanks for any comments, hints on how to do.

Ok, I am closing this as all tools are provided for custom training with even higher resolution. Anyway, super cool project.


Fix start time on schedule page.

9 AM PDT (UTC-7) is 4 PM UTC, not 2 PM UTC.

Thanks, sorry I messed up the timezone calculation.

@Mariatta No worries and thanks for the quick response! Timezone calculations for a global remote event is something that's new to most of us (definitely for me) :-)


Create a contact info block

Add links to social networks (LinkedIn, Facebook, Instagram), phone number, email, Telegram username, etc.

Added links to LinkedIn, Facebook, Instagram, phone number, email, and Telegram username. Issue resolved and closing now

All info have been added.


core happened using chain model

I was trying to repeat the 'Practical Example' with a nnet3 chain model(tdnn_7q exactly) instead. I use the yaml file from sample_chinese_nnet3.yaml(multi_cn). However, a core file generated when decoder dealing with the audio chunk. There was no clue from worker or master log. Did I miss anything ?

Seems the same problem when using multi_cn model and yaml

The worker log is like:
2020-03-11 07:26:14 -    INFO:   decoder2: 67a2f518-a6ca-425b-8626-325027fc1599: Initializing request
2020-03-11 07:26:14 -    INFO:   decoder2: 67a2f518-a6ca-425b-8626-325027fc1599: Setting caps to audio/x-raw, layout=(string)interleaved, rate=(int)16000, format=(string)S16LE, channels=(int)1
2020-03-11 07:26:14 -    INFO:   decoder2: 67a2f518-a6ca-425b-8626-325027fc1599: Connecting audio decoder
2020-03-11 07:26:14 -    INFO:   main: 67a2f518-a6ca-425b-8626-325027fc1599: Started timeout guard
2020-03-11 07:26:14 -   DEBUG:   main: 67a2f518-a6ca-425b-8626-325027fc1599: Checking that decoder hasn't been silent for more than 10 seconds
2020-03-11 07:26:14 -    INFO:   main: 67a2f518-a6ca-425b-8626-325027fc1599: Initialized request
2020-03-11 07:26:14 -    INFO:   decoder2: 67a2f518-a6ca-425b-8626-325027fc1599: Connected audio decoder
2020-03-11 07:26:14 -   DEBUG:   main: 67a2f518-a6ca-425b-8626-325027fc1599: Got message from server of type <class 'ws4py.messaging.BinaryMessage'>
2020-03-11 07:26:14 -   DEBUG:   decoder2: 67a2f518-a6ca-425b-8626-325027fc1599: Pushing buffer of size 5120 to pipeline
2020-03-11 07:26:14 -   DEBUG:   decoder2: 67a2f518-a6ca-425b-8626-325027fc1599: Pushing buffer done

segment fault  the same when use chinese test model

segment fault  the same when use chinese test model


release07: update kubernetes and trigger full rebuild

Issue #, if available:
Description of changes:
This is also triggering a full rebuild to fix the dev release.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/override cloudstack-cloudmonkey-tooling-presubmit
/override cluster-api-provider-cloudstack-tooling-presubmit
/override distribution-tooling-presubmit
/override harbor-helm-tooling-presubmit
/override harbor-tooling-presubmit
/override pbnj-tooling-presubmit


Can we add comments at a particular sentence in a paragraph?

For Example: if we have a paragraph like this:
Dolphin is the common name of aquatic mammals within the infraorder Cetacea. It is a marine animal. The term dolphin usually refers to the extant families Delphinidae (the oceanic dolphins), Platanistidae (the Indian river dolphins), named Iniidae (the New World river dolphins), and Pontoporiidae (the brackish dolphins), and the extinct Lipotidae (baiji or Chinese river dolphin). There are 40 extant species named as dolphins.
Now I want to add a comment " this is my comment " for the sentence It is a marine animal.

Perhaps WD_BUILTIN_STYLE and its COMMENT_TEXT and COMMENT_REFERENCE properties are what you're looking for.

Is it convenient for you to provide an example ？


client.get_collection(...) throws Pydantic validation error

When i run this code, i get a Pydantic Validation error:
from qdrant_client import QdrantClient
from qdrant_client.http.models import PointStruct, SearchRequest, Distance, VectorParams

client = QdrantClient(
    url="<IP_ADDRESS>",
    port=6333,
)

try:
    client.create_collection(
        collection_name="xyz",
        vectors_config=VectorParams(size = 512, distance=Distance.COSINE)
    )
except Exception as e:
    print("Collection already exists")
    print(e) # -> prints b'{"status":{"error":"Wrong input: Collection `xyz` already exists!"},"time":0.000045855}'
finally:
    collection = client.get_collection("xyz")

the last line collection = client.get_collection("xyz") throws this error:
https://pastebin.com/UwGsmijW
File "C:\Users\User\AppData\Local\Programs\Python\Python310\lib\site-packages\qdrant_client\http\api_client.py", line 74, in request
    return self.send(request, type_)
  File "C:\Users\User\AppData\Local\Programs\Python\Python310\lib\site-packages\qdrant_client\http\api_client.py", line 97, in send
    raise ResponseHandlingException(e)
qdrant_client.http.exceptions.ResponseHandlingException: 1 validation error for ParsingModel[InlineResponse2005] (for parse_as_type)
obj.result.config.optimizer_config.max_optimization_threads
  Input should be a valid integer [type=int_type, input_value=None, input_type=NoneType]
    For further information visit https://errors.pydantic.dev/2.6/v/int_type

So the error is from this line in qdrant_cleint/http/api_client.py -> class ApiClient.send():
    def send(self, request: Request, type_: Type[T]) -> T:
        response = self.middleware(request, self.send_inner)
        if response.status_code in [200, 201, 202]:
            try:
                return parse_as_type(response.json(), type_) #this line throws the error
            except ValidationError as e:
                raise ResponseHandlingException(e)
        raise UnexpectedResponse.for_response(response)

I tried debugging using print statements but i am too unfamiliar with the code base to fix this myself.
The extra weird thing is, that this code has worked before (like 1 month ago) before upgrading to a newer qdrant or pydantic version. However i dont know the previous version in which it worked.

Hey @MixoMax, please make sure that minor version of the client matches minor version of the server

that could be the problem:
server: Version: 1.8.3, build: acb04d5f
client: 1.8.0
when i run pip install qdrant-client==1.8.3 i get:
ERROR: Could not find a version that satisfies the requirement qdrant-client==1.8.3 (from versions: 0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.1.4, 0.1.5, 0.2.0, 0.3.0, 0.3.1, 0.3.2, 0.3.3, 0.3.4, 0.3.5, 0.3.6, 0.3.7, 0.3.8, 0.3.9, 0.3.10, 0.3.11, 0.3.12, 0.4.1, 0.5.0, 0.6.0, 0.6.1, 0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.8.0, 0.8.3, 0.8.4, 0.8.5, 0.8.6, 0.8.7, 0.9.0, 0.9.1, 0.9.2, 0.9.3, 0.9.4, 0.9.5, 0.9.7, 0.10.0, 0.10.1, 0.10.2, 0.10.3, 0.11.0, 0.11.1, 0.11.3, 0.11.4, 0.11.5, 0.11.6, 0.11.7, 0.11.8, 0.11.9, 0.11.10, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.1.0, 1.1.1, 1.1.2, 1.1.3, 1.1.4, 1.1.5, 1.1.6, 1.1.7, 1.2.0, 1.3.0, 1.3.1, 1.3.2, 1.4.0, 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.6.0, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.6.6, 1.6.7, 1.6.8, 1.6.9, 1.7.0, 1.7.1, 1.7.2, 1.7.3, 1.8.0) ERROR: No matching distribution found for qdrant-client==1.8.3
python version 3.10.11, newest version of pip
I also tried for python version 3.12.2 but that could anso not find qdrant-client==1.8.3.
so how do i either upgrade my qdrant client version to 1.8.3 or downgrade the qdrant server running in docker (docker pull qdrant/qdrant && docker run -p 6333:6333 qdrant/qdrant)

Hi @MixoMax
There is no qdrant-client==1.8.3, qdrant version 1.8.x should be used with qdrant-client 1.8.x, as of now qdrant-client latest is 1.8.0.
I tried to reproduce the issue
I was using python3.10.7
Here is my pip3 freeze output:
annotated-types==0.6.0
anyio==4.3.0
certifi==2024.2.2
exceptiongroup==1.2.0
grpcio==1.62.1
grpcio-tools==1.62.1
h11==0.14.0
h2==4.1.0
hpack==4.0.0
httpcore==1.0.4
httpx==0.27.0
hyperframe==6.0.1
idna==3.6
numpy==1.26.4
portalocker==2.8.2
protobuf==4.25.3
pydantic==2.6.4
pydantic_core==2.16.3
qdrant-client==1.8.0
sniffio==1.3.1
typing_extensions==4.10.0
urllib3==2.2.1

I launched qdrant as
docker run -it -p 6333:6333 -p 6334:6334 -e QDRANT__CLUSTER__ENABLED=true --name qdrant qdrant/qdrant:latest ./qdrant --uri "http://localhost:6335"

However, the code snippet you provided worked without an exception from pydantic
I ran it 2 times
First time it just created the collection
The second time I had the following output:
Collection already exists
Unexpected Response: 409 (Conflict)
Raw response content:
b'{"status":{"error":"Wrong input: Collection `xyz` already exists!"},"time":0.007603988}'

We've seen the error you encounters, it happened when qdrant-client was 1.7.x
Could you double-check if you are using the correct interpreter? And if you are using a virtualenv, then could you please check that it is enabled and you are actually activated the correct venv?

I fixed it by downgrading the server version to 1.8.0 by using docker run qdrant/qdrant:v1.8.0 instead of running qdrant/qdrant:latest


Feature slingshot

Fixes #564 - Test

[x] Create a CSS Slingshot shell
[x]  Add Popover Arrow
[x] Fix fill of icons
[x] Call out specific features/attributes of Slingshot
[x] Add real copy
[x] Add Grid view
[x] Add Category view
[x] Add Search view
[x] Animate between views
[x] Block pointer events on page buttons
[x] Animate grid view from the correct direction
[x] Animate in search characters
[x] Optimize SVGs
[x] Decide on a Canonical location for app icons (currently duplicating files in images/support)
[x] Add an initial set of search results and animate the "filter"
[x] Better copy

I don't like the way the Grid, Search, and Categories icons are out of alignment with the main text, and it causes issues when viewed on mobile. We at least need to stop them touching the edge of the page, even if the intention is to make them stand out (which should be accomplished with the typography).


pushfirst! missing for Pipe

There should be an equivalent to the method of IR, pushing a statement at the front of the pipe.  Currently I use
function pushfirst!(p::IRTools.Pipe, x)
    first_v, first_stmt = first(p)
    IRTools.insert!(p, first_v, x)
end

Is the following modification of push! correct, or is there even something simpler?
function pushfirst!(p::IRTools.Pipe, x)
         tmp = IRTools.var!(p)
         IRTools.substitute!(p, tmp, IRTools.pushfirst!(p.to, prewalk(IRTools.substitute(p), x)))
         return tmp
       end

Note that this wouldn't be more efficient on pipes, but it doesn't do any harm to add it. That looks right to me so would be great to have as a PR.


cmake: include atomic library for armv6 and armv7

Compilation failed on raspberry pi (#1296). Adding the atomic library in case we are on armv6 or amrv7 fixes the issue

Awesome, thanks a lot @Katawann!


Feature request: batch actions on messages

It would be great if some actions could accept several UID. copy, delete and move especially, but read could be interesting too.

Duplicate https://github.com/soywod/himalaya/issues/85. In summary: it already works for the delete and flag commands, but it does not for the others (mostly because of the read command that can not accept several UIDs by design).

Sorry I did not read the fabulous doc... will need to improve my completion though !

will need to improve my completion though !

What do you mean? The completion section from the wiki?

Yes, it does not fit well IMAP RFC sequence set syntax... Would be easier to give a whitespaced UID list.

Yes indeed. But there is other priorities like #109, #81, #49, #42... (in fact, all that is included in the v1 roadmap). My main goal is to consolidate this tool with tests (mostly integration ones) and include essential features. Once this objective reached, we will be able to take care of details :wink:

Totally agrees, no worry !

I gather all Himalaya issues to the same bug tracker, so I transfer your issue here.

The feature is ready on develop, it will be added to the next release #433. Commands that can be batched: read, attachments, copy, move, delete.


autocorrect_source test helper does not work if it is called multiple times in one example

autocorrect_source does not work if it is called multiple times in one example.
See. https://github.com/bbatsov/rubocop/pull/4648#issuecomment-320999689

Expected behavior

Make the helper to work well in this case

or

Add internal cop for this problem

Actual behavior
It does not work.
Steps to reproduce the problem
Apply the following patch
diff --git a/spec/rubocop/cop/style/string_literals_spec.rb b/spec/rubocop/cop/style/string_literals_spec.rb
index 562b1765..91d1a81e 100644
--- a/spec/rubocop/cop/style/string_literals_spec.rb
+++ b/spec/rubocop/cop/style/string_literals_spec.rb
@@ -6,6 +6,11 @@ describe RuboCop::Cop::Style::StringLiterals, :config do
   context 'configured with single quotes preferred' do
     let(:cop_config) { { 'EnforcedStyle' => 'single_quotes' } }

+    it do
+      expect(autocorrect_source('"foo"')).to eq "'foo'"
+      expect(autocorrect_source('"barbaz"')).to eq "'barbaz'"
+    end
+
     it 'registers offense for double quotes when single quotes suffice' do
       inspect_source(['s = "abc"',
                       'x = "a\\\\b"',

Run rspec
$ bundle exec rspec spec/rubocop/cop/style/string_literals_spec.rb:10
Run options:
  include {:focus=>true, :locations=>{"./spec/rubocop/cop/style/string_literals_spec.rb"=>[10]}}
  exclude {:broken=>#<Proc:./spec/spec_helper.rb:42>}

Randomized with seed 61978

RuboCop::Cop::Style::StringLiterals
  configured with single quotes preferred
    should eq "'barbaz'" (FAILED - 1)

Failures:

  1) RuboCop::Cop::Style::StringLiterals configured with single quotes preferred should eq "'barbaz'"
     Failure/Error: expect(autocorrect_source('"barbaz"')).to eq "'barbaz'"

       expected: "'barbaz'"
            got: "'foo'az\""

       (compared using ==)
     # ./spec/rubocop/cop/style/string_literals_spec.rb:11:in `block (3 levels) in <top (required)>'

Finished in 0.07491 seconds (files took 0.73822 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/rubocop/cop/style/string_literals_spec.rb:9 # RuboCop::Cop::Style::StringLiterals configured with single quotes preferred should eq "'barbaz'"

Randomized with seed 61978

RuboCop version
master ( 4abb67df0aa5b53cb42ceaae899636ef7cae2529 )
$ rubocop -V
0.49.1 (using Parser <IP_ADDRESS>, running on ruby 2.4.1 x86_64-linux)

I believe RuboCop RSpec actually has a "one assertion per it block"-cop, and this illustrates well why that's a good idea. 🙂 I'm sure trying to adopt RuboCop RSpec right now would be a huge undertaking though.

I'm sure trying to adopt RuboCop RSpec right now would be a huge undertaking though.

Luckily RuboCop is infinitely configurable ;) Just --auto-gen-config!

To be replaced with an auto-correct test DSL in #4507.


Generate CredScan baseline

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
The PR is to suppress track 1 credscan errors.
Aggregate-report: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1958983&view=results
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

/check-enforcer override


feat: deploy configuration daemon via reconcilation of the NicConfigurationTemplate

This change is required for OCP support.
OCP bundle cannot deploy multiple entities, thus we need to make config daemon deployment manageable from the operator itself. The daemon related helm chart parameters are propagated as env variables to the operator container, the manifest is injected into the docker image.
When NicConfigurationTemplate is being reconciled, the same controller will also synchronize the config daemon ds.
This PR only introduces changes to code and helm chart. kustomize and OCP bundle changes will come in a separate PR.
Questions for reviewers:

Currently the OwnerReference for the ds is set to the operator pod. Do we want to introduce a new entity (e.g. configMap with params or another CRD with ds config)?
Do we want a separate controller for reconciling the daemon set? (We can introduce it in the future to decouple the logic from NicConfigurationTemplate, e.g. when NicFirmwareTemplate is added)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

92 of 150 (61.33%)  changed or added relevant lines in 3 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.09%) to 58.877%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/render/render.go
56
70
80.0%

pkg/syncdaemon/syncdaemon.go
21
65
32.31%

Files with Coverage Reduction
New Missed Lines
%

internal/controller/nicconfigurationtemplate_controller.go
3
86.57%

Totals

Change from base Build<PHONE_NUMBER>9:
0.09%

Covered Lines:
1877

Relevant Lines:
3188

💛  - Coveralls


debug: Normalise value prior to right shifts

Due to the 32-bit WASM/64-bit wasmtime VM schism, the DW_OP_shr* operations end up with random bits frobbed from the upper portion of the 64-bit operand word.  The rationale is that this will clean out the upper portion, respecting 32-bit signedness.

needs squash, taking commit message from PR description


Fix withdrawal validation

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.78%. Comparing base (fbaacb3) to head (5e5af20).
Report is 6 commits behind head on develop.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #330   +/-   ##
========================================
  Coverage    35.78%   35.78%
========================================
  Files           23       23
  Lines        10026    10026
========================================
  Hits          3588     3588
  Misses        6438     6438

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Wait until the app is uploaded before enabling

This is to prevent the AppController from trying to deploy the
application before it has finished uploading.

https://ocd.appscale.com:8080/job/Daily Build/1586/
https://ocd.appscale.com:8080/job/Create-GCE-Image/135/
https://ocd.appscale.com:8080/job/Hawkeye-Test-GCE-Image/62/


Remove CFE_TBL_GetAddresses and CFE_TBL_ReleaseAddresses APIs

Is your feature request related to a problem? Please describe.
These two APIs are out of family, no others take arrays of handles.  Not a significant benefit to maintain this capability.
Describe the solution you'd like
Remove these two APIs
Describe alternatives you've considered
Could provide handle array API's for all the standard TBL calls (Register, Manage, etc), but really needs a use case since it's rare to see the existing APIs used in the wild.
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC

I actually consider these APIs to be fundamentally broken because if a failure occurs on getting address of one (but not all) of the tables, it continues on but does not set the output pointer, and does not indicate which pointer(s) were set and which were not in the end.   Calling "ReleaseAddresses" on the same array may induce undefined behavior as it may release a handle that was never gotten.
Basically, if "CFE_TBL_GetAddresses" returns non-success, the system is left in an indeterminate state.  It may have done a partial job but doesn't tell you which part, nor how to properly clean up/revert whatever it did.


Creative Commons licenses

Looks like the Creative Commons contrib module for Drupal 8 is stalled. CC licenses are something SFU needs to have before we can migrate out IR to Islandora 8, since we used the D6 version of the module extensively (our IR is a D6 site).
I am thinking it would be possible to implement the ability to use CC licenses (and maybe others) as a taxonomy (conveniently, each CC license has a URI - nice). I am happy to take a stab at a proof of concept.

I made this module for another project outside of Islandora but it might be something we can adapt for our needs here. One thing is that it attaches to media directly and not to nodes, which might be something we'd want to change
https://www.drupal.org/project/media_attribution

@alxp heh, great minds think alike. I agree, the node is the preferred entity, but it would be very useful to allow both types of entity to have licenses. I'll give the module a spin before next week (at a conference now and may not have net access over the next few eays).

We can extend that to any type of right statement.  However, we may need a way to qualify the type or source: https://rightsstatements.org/en/

@mjordan I can make you a co-maintainer if you like, it was specifically made to let you print an attribution below a media as it's used in e.g. an article, but it does a nice job of populating a taxonomy with the CC licenses with appropriate images which can be added to with other licenses.

@alxp thanks for the offer but I am overextended as it is.

I hope the interest for this hasn't stalled but I think this would be highly useful. I'm not sure how complete @alxp solution is but there's some interest from us on this.

@DonRichards
We simply use a Link field that includes the URI of the rights statement as the link value and the term for the link label.... but we batch load these records right now, so entering values isn't troublesome. We may create a widget with a drop-down list of available rights statements.
Another option is to create a rights statement taxonomy and then create a formatter that use's the term's field_external_authority, or whatever the URI field is, to create a link on the node's page:
<?php

namespace Drupal\islandora_local\Plugin\Field\FieldFormatter;

use Drupal\Core\Field\FieldItemListInterface;
use Drupal\Core\Field\Plugin\Field\FieldFormatter\EntityReferenceFormatterBase;
use Drupal\link\LinkItemInterface;
use Drupal\Core\Form\FormStateInterface;

/**
 * Plugin implementation of the 'LinkedEntityLink'.
 *
 * @FieldFormatter(
 *   id = "linked_entity_link",
 *   label = @Translation("Linked Entity Link"),
 *   field_types = {
 *     "entity_reference"
 *   }
 * )
 */
class LinkedEntityLink extends EntityReferenceFormatterBase {

  /**
   * {@inheritdoc}
   */
  public static function defaultSettings() {
    return [
      'link_field' => '',
    ] + parent::defaultSettings();
  }

  /**
   * {@inheritdoc}
   */
  public function settingsForm(array $form, FormStateInterface $form_state) {
    $settings = $this->getSettings();
    $link_fields = [];
    foreach (\Drupal::entityManager()->getFieldMap() as $entity_type => $fields) {
      foreach ($fields as $field_name => $field_info) {
        if ($field_info['type'] === 'link') {
          $link_fields[$field_name] = $field_name;
        }
      }
    }
    $element['link_field'] = [
      '#type' => 'select',
      '#title' => t('Link Field'),
      '#options' => $link_fields,
      '#required' => TRUE,
      '#default_value' => $settings['link_field'],
    ];
    return $element;
  }

  /**
   * {@inheritdoc}
   */
  public function viewElements(FieldItemListInterface $items, $langcode) {
    $element = [];
    foreach ($this->getEntitiesToView($items, $langcode) as $delta => $entity) {
      try {
        $field = $entity->get($this->getSetting('link_field'));

        if (!empty($field)) {
          foreach ($entity->get('field_project_site_url') as $delta2 => $item) {
            $link_title = $entity->label();
            $url = $this->buildUrl($item);

            $element[$delta] = [
              '#type' => 'link',
              '#title' => $link_title,
            ];
            $element[$delta]['#url'] = $url;
            if (!empty($item->_attributes)) {
              $element[$delta]['#options'] += [
                'attributes' => [],
              ];
              $element[$delta]['#options']['attributes'] += $item->_attributes;

              // Unset field item attributes since they have been included in the
              // formatter output and should not be rendered in the field template.
              unset($item->_attributes);
            }
          }
        }
        else {
          $element[$delta] = $entity->toLink()->toRenderable();
        }
      }
      catch (\InvalidArgumentException $e) {
        \Drupal::logger('islandora_local')->warning('LinkedEntityLink attempted to use an invalid field: ' . $e->getMessage());
        $element[$delta] = $entity->toLink()->toRenderable();
      }
    }

    return $element;

  }

  /**
   * Builds the \Drupal\Core\Url object for a link field item.
   *
   * Stolen from Drupal\link\Plugin\Field\FieldFormatter, which we don't extend.
   *
   * @param \Drupal\link\LinkItemInterface $item
   *   The link field item being rendered.
   *
   * @return \Drupal\Core\Url
   *   A Url object.
   */
  protected function buildUrl(LinkItemInterface $item) {
    $url = $item
      ->getUrl() ?: Url::fromRoute('<none>');
    $options = $item->options;
    $options += $url
      ->getOptions();

    $url
      ->setOptions($options);
    return $url;
  }

}

Note: if the target term doesn't have a value in the configured field this module will just build a link to the current node, which should be fixed, but I haven't gotten around to it...
We use this little plugin for a digital projects vocabulary where some of the digital projects have their own sites so users will be redirected to the relevant site instead of to the taxonomy term page. It would also work for rights statements if you want to direct people to the relevant rights statement page rather than to the rights statement taxonomy term page.

We use an entity reference field to a taxonomy for reuse permissions. The taxonomy contains fields for the link and an image. Then we're using a custom template to handle the display so it renders the CC image as a link to the CC license.

I made a module for attaching an attribution to media items you embed in to content via CKEditor. It includes a list of CC licenses in a taxonomy vocabulary that gets bulk-loaded on installation from a YML file.
We ended up making  use of the module without the media embed part for the RDM project just to have an easy way to bulk load licenses. You just need to specify the short  name, long description, image URL and license definition URL in the YML file to include it or create one when the module is installed.
https://www.drupal.org/project/media_attribution https://www.drupal.org/project/media_attribution

On Jul 10, 2020, at 4:13 PM, Eli Zoller<EMAIL_ADDRESS>wrote:
We use an entity reference field to a taxonomy for reuse permissions. The taxonomy contains fields for the link and an image. Then we're using a custom template to handle the display so it renders the CC image as a link to the CC license.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Islandora/documentation/issues/1234#issuecomment-656845980, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUD3FDE6BBDRWWR3LMWPLR25R5BANCNFSM4IIRCTUA.

FYI, I have a module at https://www.drupal.org/project/cca_rights that creates CC and Rights Statements terms useful to reference from a Repository Item rights field.


A light of motivation to shed

At least Yik Yak's dead practically.
You've done so much for this community and I would like to thank you again for all the work you've done, sucks that you've received a C&D but that also shows how good of a project this was!
I hope to see and maybe work with you again in the future!

Thank you so much for putting so much time and effort into this repository. It helped more than just users. Sorry to hear about the C&D, but your repo was a blueprint for more projects than just this one.
Thank you again. Best of luck!

@SuperSpyTX @ctrlaltdylan
No, thank you! Honestly, I'm not that upset about the C&D...my interest in Yodel had been waning for a while now, and it's a lot of work for one hobbyist to catch up/keep up with the development speed of a company worth many millions. I feel bad for my users, of course, but the app is in good enough shape as it is. Also, I really hate their awful API. They should be ashamed.
I'm lucky to have met all of the great, helpful developers, you two and everyone else who's helped me and vice versa over the last ten months. The entire reason I made Yodel a permissively-licensed FOSS project was to share back to the community and help other devs out with their own projects, and it's really awesome that it actually happened.
Now I'll be able to direct my efforts into making something better...probably nothing in the realm of social media, but yeah, I hope to work with all of you again too someday.

I'll be honest, my interest in Yik Yak died too.  It died after Yik Yak drastically changed it's API.

Thanks for your contributions, I learned a lot from both yodel and hack-yak, and both were the blueprint for one of my projects. I hope this frees up your time to do something else awesome!


DRUNet support

I'd like to ask for DRUNet model support, as an alternative denoising option. CUNet has troubles with very noisy images, something that DRUNet claims to overcome, as can be seen here:
https://github.com/cszn/DPIR
Thanks.

I'm gonna close this now, since SCUNet seems to be better in every way and (more importantly) actually used by the community.


I can't think of a reason why the developer would not be allowed to c…

…reate the builder first and pass it into the manager.  Right now the manager can only be built with the builderWithBlock call.
This will now throw a compile time error. Init not available:
// Initialize an Optimizely manager
OPTLYManagerBuilder * builder = [[OPTLYManagerBuilder alloc] init];
builder.sdkKey = @"NEKxQMdsx5Q8byiD2hmT5J";
self.optlyManager = [[OPTLYManager alloc] initWithBuilder:builder];
This is the only way to init properly in objective c
self.optlyManager = [[OPTLYManager alloc] initWithBuilder:[OPTLYManagerBuilder builderWithBlock:^(OPTLYManagerBuilder * _Nullable builder) {
builder.sdkKey = @"NEKxQMdsx5Q8byiD2hmT5J";
}]];

I thought we were deprecating init what does  marking it as NS_UNAVAILABLE do?

It causes a compile time error which will force you to use builderWithBlock.
I also added a logger so for instance if something goes wrong in the builder block, you can get the message.
That said, I need to add comments


[SPARK-7786][STREAMING] Allow StreamingListener to be specified in SparkConf and loaded when creating StreamingContext

Add SparkConf option spark.streamingListeners to implement similar functionality to spark.extraListeners defined in [SPARK-5411].
Also modifies StatsReportListener to have a zero-valued constructor and adds a simple test

Can one of the admins verify this patch?

Jenkins, this is ok to test.

Merged build triggered.

Merged build started.

Test build #33425 has started for   PR 6380 at commit e8506d4.

Test build #33425 has finished for   PR 6380 at commit e8506d4.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StatsReportListener(numBatchInfos: Int) extends StreamingListener

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33425/
Test FAILed.

Merged build finished. Test FAILed.

How can I run Scala style checks? By the way, thanks for writing the code that I essentially lifted for this :P

Merged build triggered.

Merged build started.

Test build #33445 has started for   PR 6380 at commit 6453c90.

Test build #33445 has finished for   PR 6380 at commit 6453c90.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StatsReportListener(numBatchInfos: Int) extends StreamingListener

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33445/
Test PASSed.

@His-name-is-Joof you can do dev/scalastyle locally

Merged build triggered.

Merged build started.

Test build #33612 has started for   PR 6380 at commit d92d55b.

Test build #33612 has finished for   PR 6380 at commit d92d55b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StatsReportListener(numBatchInfos: Int) extends StreamingListener

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33612/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #33625 has started for   PR 6380 at commit 00c0409.

Test build #33625 has finished for   PR 6380 at commit 00c0409.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StatsReportListener(numBatchInfos: Int) extends StreamingListener

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33625/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #33635 has started for   PR 6380 at commit c94982f.

Test build #33635 has finished for   PR 6380 at commit c94982f.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StatsReportListener(numBatchInfos: Int) extends StreamingListener

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33635/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #34479 has started for   PR 6380 at commit c94982f.

Test build #34479 has finished for   PR 6380 at commit c94982f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StatsReportListener(numBatchInfos: Int) extends StreamingListener

Merged build finished. Test PASSed.

Hey so, I thought about this feature a little bit. I am not this is an essential feature.The spark.extraListeners was added so that listeners can get added before SparkContext is started even in environments where the user does not explicitly start the SparkContext, e.g. spark shell. Since the SparkContext in the spark-shell is started automatically before the user gets any opportunity to attach their own listener, the extraListener conf was added to make sure the system automatically attaches them before creating any listener event.
But StreamingContext is really never started automatically like SparkContext in spark-shell.  One can always add listeners before starting the StreamingContext. So what is the usecase where this is really essential?

Any thoughts on this?

Sorry, been unusually busy for quite a while. You make an excellent point,
it doesn't seem essential. However it does provide a certain consistency
that may make it simpler to move from listeners to streamingListeners. A
sort of "expected functionality". That it was requested in the first place
(not by me) is some evidence of this. Perhaps ask on the JIRA the precise
motivation?
The downside being that streamingListeners must be formatted properly to
work (perhaps encouraging obsfucated zero-argument constructors) and extra
code maintained.
Any thoughts on this?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/6380#issuecomment-113315167.

@His-name-is-Joof I would like to revive this PR. I thought a bit about the usecases and I can see that it can be useful in managed streaming environments where the user gets limited control on creating streaming contexts. So I would like to have this feature merged. Mind updating the PR based on the comments?

Merged build triggered.

Merged build started.

Test build #36995 has started for   PR 6380 at commit 233335d.

Test build #36995 has finished for   PR 6380 at commit 233335d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Jenkins, test this please.

Merged build triggered.

Merged build started.

Test build #37027 has started for   PR 6380 at commit 233335d.

Test build #37027 has finished for   PR 6380 at commit 233335d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StatsReportListener(numBatchInfos: Int) extends StreamingListener

Merged build finished. Test FAILed.

your test is failing :)

Merged build triggered.

Merged build started.

Test build #37056 has started for   PR 6380 at commit 28e7f27.

Test build #37056 has finished for   PR 6380 at commit 28e7f27.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StatsReportListener(numBatchInfos: Int) extends StreamingListener

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #37069 has started for   PR 6380 at commit af41098.

Test build #37069 has finished for   PR 6380 at commit af41098.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StatsReportListener(numBatchInfos: Int) extends StreamingListener

Merged build finished. Test PASSed.

Can one of the admins verify this patch?

Merged build triggered.

Merged build started.

Test build #37157 has started for   PR 6380 at commit 9ec68c1.

Test build #37157 has finished for   PR 6380 at commit 9ec68c1.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StatsReportListener(numBatchInfos: Int) extends StreamingListener

Merged build finished. Test PASSed.

Couple of more comments to address and it is good to go.

@His-name-is-Joof ping!

Working on it now. In the middle of moving apartments. Thanks for your
patience!
On Wed, Jul 15, 2015 at 7:07 PM, Tathagata Das<EMAIL_ADDRESS>wrote:

@His-name-is-Joof https://github.com/His-name-is-Joof ping!
—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/6380#issuecomment-121794064.

Build triggered.

Build started.

Test build #37548 has started for   PR 6380 at commit fa8c752.

Test build #37548 has finished for   PR 6380 at commit fa8c752.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
class StatsReportListener(numBatchInfos: Int) extends StreamingListener

Build finished. Test PASSed.

@His-name-is-Joof I am not sure you realized, but the PR does not merge cleanly! It has conflicts, please update with the master branch

@His-name-is-Joof Mind updating this soon. Would be good to get this merged before the underlying code diverges further.

Hey @His-name-is-Joof if you are not able to update this PR, mind if I take over merging it?

Let's close this PR for now and reopen it later if needed. @tdas can take over.


Prisma Client: Opinionated Subscription implementation

Current problem
So far, client.$subscribe().type() isn't returning previousValues and node because they aren't scalars.
Proposal
Given the following datamodel:
type User {
  id: ID! @id
  name: String!
}

client.$subscribe.user(...) should generate the following GraphQL query:
subscription {
  user {
    mutation
    updatedFields
    previousValues {
      # ... scalars	(`id`, `name` in this case)
    }
    node {
	  # ... scalars (`id`, `name` in this case)
    }
  }
}

This feature is available in the current beta.

This is already available in versions after 1.23.0


Add Summary Row to Watchlist

Wondering if we could add a summary row to the Watchlist table (forgive the language ignorance):
...
import { watchListSummary } from "$lib/stores/userData";
...
          <tfooter>
            <Row {$watchListSummary}
          </tfooter>

I think this is a good idea and easily feasible :smile:


Support raw json fields

This is a port of @cameronbrunner fix to the original repo. See https://github.com/shurcooL/graphql/pull/41
It also contains fixes to quest_test.go

@hgiasac PTAL, I'd be very grateful to have this accepted.

LGTM. Let's solve @bclermont comments, then we can merge this

@hgiasac @bclermont sorry, I missed your review. Will fix this today or tomorrow.

Made changes. Unfortunately I can't re-request review. @bclermont @hgiasac

Also needed to adjust error message to meet #8 requirements.


Overview of Android Components

Description 📜
I have added a documentation file for the topic Overview of Android-Application Components
Fixes # <146>

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Android Dev (Flutter, Java, Kotlin)

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

INDRODUCTION SUB DIRECTORY
On Tue, 21 Sep 2021, 02:47 Sitam Sardar, @.***> wrote:

@Yugal41735 https://github.com/Yugal41735 in which directory you have
added your file?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/girlscript/winter-of-contributing/pull/1287#issuecomment-923318848,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARZOLN2RWW46VJYJD5GK5L3UC6QGTANCNFSM5EMAUNFQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@sitamadex11 could u tell me if there are any changes so that I could take up next issues

can you please squash your 2 commit into one

Thank you :) for the feedback, by the way could u tell me what is second commit for ?

what i mean is that i had added only 1 file but unable to understand why there is 2 commits

@sitamadex11

@VikasPandey121 please check it once.

Hi @Yugal41735!
Great work, Can you please add some infographic data as well so that the reader can find it more interesting and informative.
Thanks.

Hi @Yugal41735!
Great work, Can you please add some infographic data as well so that the reader can find it more interesting and informative.
Thanks.

ok like kind of adding some pictures to look it more eye catching right?

@VikasPandey121  could u please check it once.
Thank You.

LGTM, Thanks for the contribution.


Enhancement of CVL-controller

A big advantage of serialbattery-driver compared to a victron-system with a smartshun-system is, that the serialbus-driver sees every cell voltage and can react on bad balanced batteries.
Especially at the end of charging (close to 100%) the charging-current is usually controlled indirect by CVL (Charge Voltage Limitation).
Furthermore in Victron Systems with MPPTs and DC-Feed-In activated CVL is the only way to reduce charging current, because CCL (charge current limitation does only apply to Multis, but not to MPPTs.
So it is a very good feature of the driver, that CVL can be reduced if a single cell runs over MAX_CELL_VOLTAGE.
This is implemented today with a "penaltySum"-Method that is in fact a P-Controller.
I think an I-Controller fits better to the requirements of CVL-Controlling.
This is implemented with this PR.
With the switch CVL_ICONTROLLER_MODE the PenaltySum (CVL_ICONTROLLER_MODE=false) or a I-Controller (CVL_ICONTROLLER_MODE=True) can be choosen.
I made a test with each controller. With a power-supply I charged a single cell (cell no3) for 1.5h with 2Amps. So I got the cell3 about 3Ah higher than the rest of the 16s-Pack.

Then I charged the battery-pack to 100%. And the balancer got it right again.
Here is the result:

An I-Controller provides a calmer CVL and so gives the victron system time to adjust the charging-current to meet the CVL.

Unfortunately I have no possibility to test this now in winter, but based on the graph it looks very good! If many can test this, I would remove the current method with the penalty voltages.

I have been using it for about a week and have not noticed anything negative so far. Thanks for your work!

Hello @codeworkx, thank you a lot for your positiv reply. I am also using it for some time now on 2 Systems. Of cause i got only to 100% by planned charging in December. But for this I always see a much smoother behaviour.

This PR is now merged and will replace the penalty sum voltage after a few months of testing. In the meanwhile it will be available as option.

Hello @mr-manuel , thanks a lot. Happy to read this!

Thank you for your contribution!

@cflenker now I tested it with loading the battery from the grid. The battery never reached the SOC_RESET_VOLTAGE, but only MAX_CELL_VOLTAGE. This is done in this lines:
https://github.com/Louisvdw/dbus-serialbattery/blob/609342638c7d4958f7ff6cf5517c5aa62c22f21c/etc/dbus-serialbattery/battery.py#L269-L278
Checking your changes you did not consider that. Could you use self.max_battery_voltage or use the same logic as above?
The curve looks very clean! Great work!

Hello @mr-manuel, sorry. You are right. I did not consider that. I will make a proposal to fix it tonight or tomorrow  night. Thank you.

I already fixed it ;-)

Thank you very much!!!

with CVL_ICONTROLLER_MODE = True, will never be switched to float ?
I tried today, after successfull absorption to <10mV CVL stays at 3,43V (61,8V):

Same to me.. 4h absorb with <10mv celldiff. I will switch back to CVL_ICONTROLLER_MODE = False for Fürther testing.

Hello @mdkeil, hello @Becker884,
I do not think it has to do with the type of cvl-controller.
Maybe it has to do with: https://github.com/Louisvdw/dbus-serialbattery/pull/895
Please try to set CELL_VOLTAGE_DIFF_KEEP_MAX_VOLTAGE_TIME_RESTART to a higher value. Maybe 0.030V.

I will try it out.

Problem solved..  I had to setup a little voltagedrop, because with linear limitation enabled I never reached the maximum charge voltage.

can you show me please what you set up?

my config:
LOGGING = INFO

MAX_BATTERY_CHARGE_CURRENT = 100
MAX_BATTERY_DISCHARGE_CURRENT = 100

MIN_CELL_VOLTAGE   = 2.900
MAX_CELL_VOLTAGE   = 3.450
FLOAT_CELL_VOLTAGE = 3.375

VOLTAGE_DROP = 0.025

SOC_RESET_VOLTAGE = 3.500
SOC_RESET_AFTER_DAYS = 15

CVL_ICONTROLLER_MODE = True
LINEAR_LIMITATION_ENABLE = True
CVCM_ENABLE = True

CELL_VOLTAGE_DIFF_KEEP_MAX_VOLTAGE_TIME_RESTART = 0.015
CELL_VOLTAGE_DIFF_KEEP_MAX_VOLTAGE_UNTIL = 0.010
;MAX_VOLTAGE_TIME_SEC = 1800

BMS_TYPE = Seplos

; Exclute this serial devices from the driver startup
; Example: /dev/ttyUSB2, /dev/ttyUSB4
EXCLUDED_DEVICES = /dev/ttyUSB0

; Charge current control management enable (True/False).
CCCM_SOC_ENABLE = True
; Discharge current control management enable (True/False).
DCCM_SOC_ENABLE = True

CC_SOC_LIMIT1 = 98
CC_SOC_LIMIT2 = 95
CC_SOC_LIMIT3 = 91

CC_CURRENT_LIMIT1_FRACTION = 0.15
CC_CURRENT_LIMIT2_FRACTION = 0.35
CC_CURRENT_LIMIT3_FRACTION = 0.50

@cflenker for the purpose of completion could you explan what happens, if the value CVL_ICONTROLLER_FACTOR is changed to a bigger/smaller value?

@cflenker for the purpose of completion could you explan what happens, if the value CVL_ICONTROLLER_FACTOR is changed to a bigger/smaller value?

Yeah, I'd like to know this too, as it would be good to understand what is a slower/ faster/ or higher / lower ratio of voltage limitation.
Also, testing 1.3.20240417dev today (I have 2 runner cells) I see the ICONTROLLER lower the CVL from 28v to 27.2v on one battery, but this isn't picked up by batteryaggregator which still shows 28v, so the system still calls for 28v across the three batteries. - Maybe a batteryaggregator problem though?
The CVL keeps decreasing on Battery 1 whilst cell voltage differential also decreases which seems counter intuitive, unless it's still trying to lower the stsem voltage but that's not being aggregated back to Venus:

Battery 1:

BatteryAggregator:

Hello,
I'll try to explain the behaviour of CVL_ICONTROLLER_FACTOR. Most of it is already explained in config.default.ini:
;   2. I-Controller (CVL_ICONTROLLER_MODE = True)
;      An I-Controller tries to control the voltage of the highest cell to MAX_CELL_VOLTAGE + CELL_VOLTAGE_DIFF_KEEP_MAX_VOLTAGE_UNTIL.
;      (for example 3.45V+0.01V =3.46V). If the voltage of the highest cell is above this level, CVL is reduced. If the voltage is below, CVL is
;      increased until cellcount*MAX_CELL_VOLTAGE.
;      An I-Part of 0.2 V/Vs (CVL_ICONTROLLER_FACTOR) has proved to be a stable and fast controlling-behaviour.
;      This method is not as fast as the penalty_sum-Method but usually smoother and more stable against toggeling and has no stationary deviation.

So the CVL_ICONTROLLER_FACTOR controls how fast the CVL is lowered if one cell goes above MAX_CELL_VOLTAGE + CELL_VOLTAGE_DIFF_KEEP_MAX_VOLTAGE_UNTIL.
For example: If MAX_CELL_VOLTAGE=3.45V and CELL_VOLTAGE_DIFF_KEEP_MAX_VOLTAGE_UNTIL=0.01V and the actual highest cell voltage is 3.56V. Then the deviation is 0.1V. The deviation is multiplied with CVL_ICONTROLLER_FACTOR=0.2 V/Vs. So the CVL is reduced 0.02V per second.

This means:

The higher the value of CVL_ICONTROLLER_FACTOR the faster CVL is reduced with a given cell-voltage-overshoot.
Do not choose too high values for CVL_ICONTROLLER_FACTOR: this could make the controlling instable.

Thanks, that makes it much clearer, so in your scenario above CVL_ICONTROLLER_FACTOR = 0.4 will reduce the voltage 0.4 V/second.
I'll just have to test another driver release to see why it didn't aggregate with multiple batteries, and maybe test different factors to catch my runner cells early.

With CVL_ICONTROLLER_FACTOR = 0.4 and a cell voltage overshoot of 0.1V the CVL will reduced 0.4*0.1 = 0.04V per Second.
Take care: I think a bug crept in with a cleanup-commit: https://github.com/Louisvdw/dbus-serialbattery/issues/1038
I think this bug is fixed in the latest version of @mr-manuel repo. I am just about to test this latest nightly.

I made the experience that the I-Controller works not so good when you are off grid with a PV inverter. In this case multiple cells can have a bigger voltage then max voltage and the I-Controller does not correct this and the mess starts. In this case the P-Controller (penalty sum) works better. I will add this node in the confile file.


Improved layout and functionality of the select all box

Fixed the alignment for the select all checkbox
The select all box will be selected if all check boxes are manually selected
When filtering, the selections that are still in view will be retained.

Good call on keeping the selected items from the filtered view selected. I'll rebase this for the 25.01 update along with #65.


update mouse orbit sensitivity

based on having the mouse movement reflect the amount of pan, or rotation, 1-to-1 afaict.
zooming was also set very low.

I think this might be the kind of thing that is device-dependent.

Ah, yes. I was wondering about this as well.