On redhat Linux key map is incorrect (backspace -> [EQUAL], left ctrl -> ctrl-enter, etc)

VSCode Version:
OS Version:

Version 1.16.0
Commit 787b31c0474e6165390b5a5989c9619e3e16f953
Date 2017-09-06T16:19:37.192Z
Shell 1.7.3
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64
$ lsb_release -a
LSB Version:    :core-4.1-amd64:core-4.1-noarch
Distributor ID: RedHatEnterpriseServer
Description:    Red Hat Enterprise Linux Server release 7.4 (Maipo)
Release:        7.4
Codename:       Maipo
Steps to Reproduce:

Backspace and many other keys do not work
On keyboard shortcut, add a new shortcut to empty map
In the key press screen, backspace results in [EQUAL], left ctrl results in ctrl-enter, etc

Tested wit xev, and both key codes are correctly sent.
Works in embedded terminal, only broken in editor.

Reproduces without extensions: Yes

What keyboard do you have installed (e.g., US QWERTY, Dvorak, UK, French, German...), and how did you select that keyboard (GNOME GUI settings app, KDE GUI settings app, manually editing a config file (which one?), something else...)? Those seem like details the VS Code dev team will need in order to reproduce the problem.

I am in a corporate setting, and launching it throug X forwarding over an exceed on demand channel.
Even the keyboard is custom built.
On a Windows 7. Where can I find these information?
US  QWERTY, and it is mapped via X, I suppose.
It is weird that integrated terminal sees the keys correctly, but only the editor does not.

@potbunker There is a known issue with remoting. Please see https://github.com/Microsoft/vscode/wiki/Keybindings#troubleshoot-linux-keybindings


how we can use a tcp socket instead of a unix one in daytona

@hunnywar transferred the issue to this repo. You're right, we should support tcp as well


Baselines for ENH: Add vector legend.

@doutriaux1 Also take a look that the changed baselines and how the vector legend looks like. Note that for linear mapping we have two vectors in the legend for other scaling options only one vector is sufficient.

@danlipsa I think we shouldn't draw the legend's box.
Also, and it's a minor point, feel free to left unchanged, historically I think the arrow was left-aligned with the legend box, not centered.
I can't decide if your way (centered) is better or not.

I think we shouldn't draw the legend's box.
I used drawLinesAndMarkersLegend as a starting point, and that function draws a box - this way it is consistent. Thinking about this, I kind of like the box with an arrow inside, instead of just an arrow floating without any context.

Also, and it's a minor point, feel free to left unchanged, historically I think the arrow was left-aligned with > the legend box, not centered.
I can't decide if your way (centered) is better or not.
Note that you can also have two arrows which are drawn at 1/3 and 2/3, so I think centered fits well with this.

If you feel strongly we should change these we can get @aashish24 opinion as well. However, he might prefer something different than both of us and then we are stuck :smile:

I used drawLinesAndMarkersLegend as a starting point, and that function draws a box - this way it is consistent. Thinking about this, I kind of like the box with an arrow inside, instead of just an arrow floating without any context.

can we make it optional with default to no-box?

Note that you can also have two arrows which are drawn at 1/3 and 2/3, so I think centered fits well with this.

I like the center since there it is noticeable. If it is left aligned, i would have missed it. My vote is for center

@doutriaux1 @aashish24 I can just delete the box then.

No box by default as before can be useful, in case you already have a boxfill/isofill or some other gm legend, and you need to find some space to put all this on the canvas
btw, what happens if your template.legend box is higher than it is wide. Do you get a vertical arrow? Though I  think a vertical arrow may look strange...

@danlipsa i don't feel strongly about this. But as @jypeter mentioned it's easy enough to add a box, whereas we can't remove yours, so I'd vote for no box by default. I think isolines draw the lines left aligned, so maybe just for consistency we could have it left aligned.

@jypeter For now, I only have the horizontal layout. @doutriaux1 Do we have vertical layouts for other legends (color bar, line plots)?
@doutriaux1 OK, I'll remove the box. Should I still keep it as an option, or completely remove it?
Can you point me to some examples with an isoline legend?

@doutriaux1 @aashish24 I modeled my legend on
https://github.com/UV-CDAT/uvcdat-testdata/blob/master/baselines/vcs/test_drawLinesAndMarkersLegend.png

yes completely remove it.

@danlipsa I see that isoline does not draw a legend anymore... I'll dig the old vcs

@danlipsa @aashish24 this is the same plot in the latest vcs

@aashish24 it is not even close in quality 😿

@aashish24 @danlipsa latest png generate on mac/mesa with default settings

@danlipsa let's not worry about the legend as long as you removed the box. I need to get this release out!

@doutriaux1 Sounds good. I'll just remove the box and leave everything else as is.

@doutriaux1 @aashish24 Updating baselines is such a pain with the new testing framework =
while (forever)
run test script
update one baseline
Compare this with before =

run tests.
review all baselines
update all baselines.

We should really fix this:
https://github.com/UV-CDAT/vcs/issues/160

@aashish24 it is not even close in quality

this is the comparison with vector graphics and raster graphics. A fair comparison would be if you export both as vector format 😄. The underlying technology has its up and downs. Vector looks better by default because you get infinite resolution, raster is faster and hardware accelerated. If you export both as PDF they should look the same.

@doutriaux1 Sounds good. I'll just remove the box and leave everything else as is.

+1, I like the legend at the center since it is only one arrow but I think that should be a user option since this is really a matter of choice, nothing is right or wrong.

@danlipsa let's not worry about the legend as long as you removed the box. I need to get this release out!

@doutriaux1 I thought we may not get the legend in the release as discussed over the phone call. I guess since we had extra time now, are we planning to have it in the release? If that is the case @danlipsa you may want to add a notebook example after the branch is merged.

@danlipsa there is an update keyword now in the checkImage code, so if you know what you're doing you can force update all the blines.

@aashish24 this is a fair comparison, they're both pngs.

@aashish24 this is a fair comparison, they're both pngs.

@doutriaux1 yes they both are png's but one came from vector graphics and other from raster graphics (http://vector-conversions.com/vectorizing/raster_vs_vector.html). The output from vector graphics to png will have aliasing applied and that's why you do not see the sharp lines but rather a smooth looking plot. If you want to do the same, then enable the aliasing and it should get better. By default we turn off aliasing.

@doutriaux1 @aashish24 I agree the old vcs looks better. Things we can do:

aliasing for lines (as @aashish24  also noted)
seems that continents are drawn with thicker line and/or black line
isolines are drown with thinner lines and/or gray line
labels are better aligned in the old vcs - this is a vcs computation: take a look at a VTK graph:
http://www.vtk.org/files/ExternalData/MD5/fa2c3d87a180352afa623b0be3dff100 with better aligned labels.

We can file an issue and fix this.

+1 for what @danlipsa said. I also notes some other differences in defaults.
I think it makes sense to turn off aliasing for testing but we should have anti-aliasing on as default and that will ensure that our plots by default are pretty as @doutriaux noted

@aashish24 FYI antialiasing was return 8 I'm not sure why pngs are not antialiased any longer?

@sankhesh This is the anti-aliasing issue @doutriaux1 mentioned.

@doutriaux1 I think you see differences because of isoline linewidth. See the images below:

linewidth = 0.5
linewidth = 1.0

I'm sorry my comment has nothing to do with vector legend, but do you have anti-aliasing or not in the 2 figures above? And is it for the whole plot or just the data part (in this case the plotted isolines and continents)?
Because when I look at the text, even with the sun shining on my screen, I get the impression that is slightly different in both figures, ie the text on the 0.5 figure looks more anti-aliased than the text on the 1.0 figure
Is anti-aliasing something that can be selected by the user? I totally agree that it should be 'on' by default and I understand that it's probably better to have it 'off' for testing purpose if you need to compare images. What is the anti-aliasing setting for 2.8.0?

I'm sorry my comment has nothing to do with vector legend, but do you have anti-aliasing or not in the 2 figures above? And is it for the whole plot or just the data part (in this case the plotted isolines and continents)?

Yes, antialiasing is enabled for both the plots and is set to 8 MSAA samples for the whole plot.

What is the anti-aliasing setting for 2.8.0?

It is 8 samples by default:
https://github.com/UV-CDAT/vcs/blob/8293dd09eb798952da87cce4bce993a3ba6d8d3e/vcs/VTKPlots.py#L74
You can set it on the canvas as follows:
import vcs
x = vcs.init()
x.setantialiasing(8)  # 8 MSAA samples
# x.setantialiasing(0)  # disable antialiasing

@aashish24 @doutriaux1 @jypeter @danlipsa Please continue the discussion at UV-CDAT/vcs#190

@aashish24 nope did it from the command line and checked that antialiasing was 8


Doc describes features that don't exist

Regarding section : Subscribe to a feed
In the current version of RD client (linked in doc), there is no "Connection Center" and clicking + does not offer a Remote Resource Feed option.
Thanks for wasting my time.  There is no excuse for this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 671614a5-60a1-e453-1f3b-1c53fc6b670f
Version Independent ID: 6c47f487-ad60-c165-b7ef-3c27e583cc72
Content: Connect to Azure Virtual Desktop from Android - Azure
Content Source: articles/virtual-desktop/connect-android.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Closing the loop on this - the article was updated in November to correct "Remote Resource Feed" to "Workspaces".
#please-close


add initial voy implementation

This addresses #262
Hello, @nfcampos ! I added some initial implementation but still have a few questions:

Should the implementation be based on some specific abstract class? I saw VectorStore and SaveableVectorStore. I went with the first for now but I would be glad to hear some opinion here. Since voy-search is meant for browser env, I would say it doesn't make much sense to save the index data to drive.
What is the preferred approach for using external clients? I saw two different approaches: the first is to inject the client within the constructor (for example langchain/src/vectorstores/supabase.ts), and the second is to instantiate the class from the external library within the initializing code (for example langchain/src/vectorstores/hnswlib.ts). Which one should be used here?

Thanks for your help!
TODO: for now it's missing integration tests and docs for the newly added class

Hi @kwkr sorry for the delay in getting back to you here, in answer to your questions

Yes I agree SaveableVectorStore makes most sense for Node.js vector store
I think we prefer to have the client as a argument, and people instantiate outside, how you've done it here
This is looking good, with some docs and integration tests we can get this in, thanks!

I needed to patch the voy-search package in order to be able to import it within integration tests and provide a working example script:
https://github.com/hwchase17/langchainjs/pull/1181/files#diff-300cdd47b9511e809b968c658e0ea9e1267ec27afb73f50310bcead507ae07adR8-R9

This is awesome - thanks for following through!


try to hanldle the connection error

Pull Request Test Coverage Report for Build 98

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.154%

Totals

Change from base Build 97:
0.0%

Covered Lines:
88

Relevant Lines:
94

💛  - Coveralls


FIX: guess_stream_needs_encoding must return False when fileobj is an instance of io.TextIOBase

FIX: guess_stream_needs_encoding must return False when fileobj is an instance of io.TextIOBase
because fileobj.write needs a str as parameter, not bytes

rgd
https://github.com/crossbario/txaio/actions/runs/7251555425/job/19755043215?pr=185#step:4:202
it would make sense to upgrade CI
https://github.com/crossbario/txaio/blob/50a111a95b19168127681429bebd3827e1e2f6e5/.github/workflows/main.yml#L39
for testing against latest PyPy 3.9 and 3.10 instead of 3.7 / 3.9
https://www.pypy.org/download.html

thanks for bumping pypy!
now it runs into https://github.com/crossbario/txaio/actions/runs/7254104155/job/19763863038?pr=185#step:6:307
I'm not sure what's going on .. this seems to indeed change some deep-buried behavior
@meejah any clues or hints or caveats you see?

the test failure appears also on main branch
git checkout master
micromamba env create -n txaio python=3.11 tox
micromamba activate txaio
make

it works with last twisted version 23.10.0, it only fails with the Twisted trunk
py311-tw2210: OK (0.73=setup[0.36]+cmd[0.37] seconds)  py311-tw238: OK (0.72=setup[0.35]+cmd[0.37] seconds) py311-tw2310: OK (0.73=setup[0.37]+cmd[0.36] seconds) py311-twtrunk: FAIL code 1 (0.75=setup[0.35]+cmd[0.40] seconds)

works with last twisted version 23.10.0, it only fails with the Twisted trunk

this package does work as is
https://github.com/crossbario/txaio/actions?query=workflow%3Amain
what's not verified if it works with only moving to newer cpython/pypy still, and with current twisted trunk
so if you want this going forward, best would be 2 PRs: one with only the cpy/pypy bumping. I also assume setup.py needs adjustment to account for those new minimal version
if that works (on 1st PR), then I would relook into your actual change on a 2nd PR
if that 2nd PR does work, but does not work on twisted trunk, this must be investigated first, because this is quite unusual - but of course not impossible
sorry, I don't have time to work on this, hope above helps nevertheless

Sorry for the delay, rolled off my radar (ahem, github notifications ;)
Just looking at errors + code, it seems like possibly the BytesIO interface / API maybe changed, somehow? The messages override is "interesting" and it seems like that's what is failling in the test_logging...
Bigger picture, a bunch of this seems related to Python2 support -- if that's dropped (it is, right?), I think it could be simplified significantly in all likelihood.

thanks @meejah for chiming in and for your analysis & comments!

this seems related to Python2 support -- if that's dropped (it is, right?), I think it could be simplified significantly in all likelihood.

yes, Python 2 is dead and yes, if it would simplify things, we could definitely rip out anything that originally was only to make Python 2 fly from txaio (or autobahn or crossbar for that matter)


Update initialize for models

Will update the initialize function for AbstractModels
Goal:
Move towards a ClimaAtmos implementation that allows variables to have different types and spaces.
Additionally:
Removes the model_name nesting in prognostic and aux Field vectors for standalone models; need to resolve this w.r.t. the aux vector which is fully shared between models in LSM mode, which may require the model.var nesting at both levels to have consistent RHS.

@jb-mackay added in the variable type stuff. I thought it was working (works with FT type), and it seemed OK with MVectors, but when I actually tried it with the root model (Y.vegetation.rwc is an MVector{k,FT} where k = length(model.compartment_heights), it errors in the test files. so debugging this....
(this error is probably generic, i.e. doesnt matter that we are using the Root model in particular for it)
though, the nice thing is that then we can scrap the RootDomain! I stuck the compartment_heights and root layer depths in the model. Then we can have the domain be a Point, and have the variable be an array at the point (one index for each compartment).

A couple of things...
using ClimaLSM
using ClimaLSM.Domains: Point, Column, coordinates
using StaticArrays

FT = Float64

keys = (:a,:b, :c)
types = (FT, MVector{3,FT}, NTuple{2,FT})
coords = coordinates(Point{FT}(0.0))
Y = initialize_vars(keys,types, coords, :foo)
Y.foo.a[1] == 0.0
Y.foo.b[1] == zero(MVector{3,FT})
Y.foo.c[1] == zero(NTuple{2,FT})

col = Column(Float64; zlim = (-1.0, 0.0), nelements = 10)
field_coords = coordinates(col)
Y_col = initialize_vars(keys,types, field_coords, :foo)
## MVector leads to error, but NTuple may work:
keys = (:a,:b)
types = (FT,  NTuple{2,FT})
Y_col = initialize_vars(keys,types, field_coords, :foo)

Here is the carbon example. It is a matrix equation, Ydot = M*Y + B
https://github.com/CliMA/ClimaLSM.jl/blob/bm/initialize/carbon.jl
trying to set it up with Point domain, prognostic type = MVector. much simpler than the root example for debugging.


Need a sample test metrics config

Is it possible to have a testmetrics configuration which contain all the configuration .
We have currently limited documentation for the testing of the metric files .

The documentation has one example config file of job and metric

We'll add it soon to the code but for now:
# Path to metric file
metric: "some_metric.yaml"
# Paths to all the different mock inputs
mocks:
  # Name of the input to be used in the metric queries
- name: input1
  # Path to the mock file
  path: mocks/input1.jsonl
- name: input2
  path: mocks/input2.jsonl
  # Indicated this mocks a streaming input
  streaming: true
# Add variables
params:
  variables:
    var1: value1
    var2: value2
# List of assertions
tests:
  # Name of the step from the metric to assert
  step1:
  # Per row all different cloumns and their values
  - col1: val1
    col2: val2
  - col1: val3
    col2: val4
  step2:
  - col3: val5
  - col3: val6


UP-4519 Theme unified for normal and mobile views through portlet preferences

Issue UP-4519

@drewwills @bjagg Please, review this, we're trying to make it look more responsive.
Thank you.

@dmartign do you have time to make the suggested changes that James maded? Hoping to cut a release this week.

@bjagg let me talk with Daniela, we just rehired her for summer work on MySAIL.

@bjagg . We have been working on this and made new commits, but we'd appreciate some clarifications before continuing. We are confused about the meaning of the suggested changes, so could we take out Jquery altogether and only do Bootstrap instead? We'll appreciate any suggestion.
Thanks.

James is suggesting that the preference used to determine if the theme is 'respondr' be replaced with "respondr".equals(request.getProperty(THEME_NAME_PROPERTY))

Hi @dmartign.  In looking at this a bit deeper, I suggest the behavior your are looking for, always using the Respondr view even if you are on a mobile device, can be better handled by changing the default configuration of the bean ViewNameSelector (which should be viewNameSelector in Spring idiom) from UserAgentViewNameSelector to ThemeViewNameSelector.  See https://github.com/Jasig/AnnouncementsPortlet/blob/master/src/main/webapp/WEB-INF/context/applicationContext.xml#L117.
At this time (Respondr-age) there is not a strong need to default to the mUniversality view. Instead, a site using mUniversality instead of Respondr for mobile views can overlay a custom applicationContext.xml that uses the UserAgentViewNameSelector instead.
The way we usually handle that is we comment out the alternate configuration and add comments that it can be used in lieu of the default configuration.  To make it easier to overlay I suggest pulling that bean out to its own *Context.xml file (say siteConfigurationContext.xml) so someone desiring to select the mUniversallity behavior doesn't have to have the entire applicationContext.xml copied into their uportal-portlets-overlay/AnnouncementsPortlet/src/main/webapp/WEB-INF/context folder; e.g. have a file with something like
    <bean id="viewNameSelector" class="org.jasig.portlet.announcements.controller.ThemeViewNameSelector"/>

    <!-- Alternate view selector that will use the mobile view if the user's theme is UniversalityMobile (e.g.
         mUniversality)
    <bean id="viewNameSelector" class="org.jasig.portlet.announcements.controller.UserAgentViewNameSelector">
        <property name="userAgentMappings">
            <!- - Regexes of mobile device user agents - ->
            <util:map>
                <entry key=".*iPhone.*" value=".mobile"/>
                <entry key=".*Android.*" value=".mobile"/>
                <entry key=".*Safari.*Pre.*" value=".mobile"/>
                <entry key=".*Nokia.*AppleWebKit.*" value=".mobile"/>
            </util:map>
        </property>
    </bean>
    -->

As a note to anyone releasing a new portlet version, you should probably release as a new minor version since this is a behavior change and mention the behavior change in the release notes.

Thank you @jameswennmacher, @bjagg. Please see the changes made by @MichaelFrieze. Hopefully they address the issue.

Thanks for making the update.  I believe with the addition of siteConfigurationContext.xml, the changes to AnnouncementsPreferencesController, AnnouncementsViewController, UserAgentViewNameSelector, and portlet.xml are unneeded and can be reverted since the portlet preference is extraneous now.
Other than the artifactId version bump in pom.xml which is useful, what is the impact of the other changes in that file?  It looks to me like the old way (specify what you want to process) is more robust than the new way (specify a set of excludes).  What were you trying to add to or remove from the JAXB processing?

Thanks for replying @jameswennmacher. However, we chose to move on from this older commit we did last year and we're planning on doing something with Bootstrap instead to get rid of the need of multiple UIs. Please, feel free to close the merge if you don't feel it works with the existing Apereo Announcements codebase.

OK.  Thanks for submitting it though!

You're welcome.


Organize examples

#1286
I put observation_collection_for_imitation_learning.py and history_vehicles_replacement_for_imitation_learning.py under utility because they are used to support imitation learning(?). Please correct me if I am wrong. In general I think a README or comment description in each file describing what the example does would be useful, especially for examples like history_vehicles_replacement_for_imitation_learning, observation_collection_for_imitation_learning and dynamic_history_vehicles_replacement because from just the title I am not quite sure what they do

Search the entire project folder and replace any paths with */examples/* in the code to the appropriate */examples/<new_subfolder>/* path.
Merge the latest develop branch into this branch.

This was solved with a different PR.


Order data by partitions if available

I've stored a bunch of data partitioned by date, and written it to delta using the deltalake package like so:
for df in dfs:
    write_deltalake("mytable", df, partition_by="date")

(although actually this was done in parallel, and so things maybe got written out of order
├── date=2024-01-01
│   ├── part-00001-5c3d1646-6a8b-4511-87f5-3cd0acf1c0e8-c000.zstd.parquet
│   ├── part-00001-869909e1-1079-49db-83d6-77a43d67370a-c000.zstd.parquet
│   └── part-00001-eeb823e8-b9ed-49bd-86d9-9f28f0f444b7-c000.zstd.parquet
└── date=2024-01-02
    ├── part-00001-32e6c973-6d2a-4132-82dd-e6b431cf5343-c000.zstd.parquet
    ├── part-00001-426c2af2-6e86-4cfe-86c9-853f243c35e6-c000.zstd.parquet
    ├── part-00001-6fa10ba1-6b14-4908-b328-f8a8fdaec258-c000.zstd.parquet
    └── part-00001-79cd49d4-dee1-4957-8cdf-86b6f86f95f6-c000.zstd.parquet

When I go to read it I find that the data isn't sorted by partition
df = ddt.read_deltalake("mytable")
df.date.head()

0    2024-01-02
1    2024-01-02
2    2024-01-02
3    2024-01-02
4    2024-01-02
Name: date, dtype: date32[day][pyarrow]

df.date.tail()

1392523    2024-01-01
1392524    2024-01-01
1392525    2024-01-01
1392526    2024-01-01
1392527    2024-01-01
Name: date, dtype: date32[day][pyarrow]

We should order things if we can I think.  I propose the following:

If partitions are available, order by partitions
Maybe within that we can look at partition statistics?  These are stored within the "stats" attribute of the deltalake metadata
We could also think about setting an index with the partition value.

Probably both the effort and uncertainty increase as we go down that list.  The first item seems pretty straightforward to me though.

I'd also like to sort partitions by max value of the partition column, but couldn't find an easy way to get statistics out of the metadata

The min/max values are available through the deltalake.DeltaTable.get_add_actions API mentioned in this issue: https://github.com/delta-io/delta-rs/issues/2233#issuecomment-1971991963

I'm going to reopen this for now.  I think that we could probably do better by looking at the data coming out of the get_add_actions function.


Snowflake: When creating external tables, add an option to use database and schema

Describe the feature
Currently snowflake uses database and schema from the profile when it connects to the snowflake.
This prevents creation of external tables in a different database/schema than the default database/schema that snowflake connects to.
Describe alternatives you've considered
Manage multiple profiles for each database/schema neeed
Additional context
This is specific to snowflake
Who will this benefit?
Useful for creating external tables in multiple/different schemas at the same time

This is already possible, though I think I can understand your confusion. Ultimately, this package is just an extension of Sources. So this package (under-documented as it is) makes no mention of this feature.
Instead it's described as a feature of Sources (see Add Sources to your DAG: Declaring a source)
The constraint here is that you must use modify each combination of database & schema as a distinct source. In my opinion, that's a good thing, as it forces you to separate your concerns.
I'm closing for now, but feel free to open back up, if I'm mistaken here


doc: broken links to https://blog.golang.org/go-fmt-your-code

I followed a reference from a random go project's git hook to https://golang.org/misc/git/pre-commit and discovered a pseudo 404/"lstat $GOROOT/misc/git/pre-commit: no such file or directory" error. So I looked around some more and found another broken link to this URL from the go blog:
https://blog.golang.org/go-fmt-your-code
It seems that this file was removed back in January:
https://go-review.googlesource.com/c/go/+/158677
I wonder if it's worth making this link work again (either just on the website but not in the git repository, or re-adding the file to the repository with a "DEPRECATED, SEE ..." comment), or maybe editing that blog entry to point to the last commit where that file existed:
https://github.com/golang/go/blob/88da9ccb98ffaf84bb06b98c9a24af5d0a7025d2/misc/git/pre-commit

@agnivade ^

We should definitely fix the blog link. Perhaps we can ask users to run a git codereview hooks to install the hooks.
@andybons

Can I take a look at this?

@marcsanmi: I didn't realise the blog was on github until now. You could submit a PR to fix the link:
https://github.com/golang/blog/blob/master/content/go-fmt-your-code.article

Ok, tomorrow I am going to do it

Looks like this was fixed:
https://github.com/golang/blog/commit/0a405bc1dde109ab821285b20eb0b0d7506bb8fb


Isolated files with import / export statements are not being scoped.

TypeScript Version:  3.8.3

Search Terms:
TS2451 Cannot redeclare block-scoped variable
Code
import * as fs from 'fs';
import * as http from 'http';
import * as https from 'https';
import { EnvVariableReader } from '../../common/envVariableReader';

Expected behavior:
Expected files to be properly scoped.
Actual behavior:
When I try to run unit tests - I get this compile error:
TSError: ⨯ Unable to compile TypeScript:
src/api/app/app.ts:3:7 - error TS2451: Cannot redeclare block-scoped variable 'fs'.

3 const fs = require("fs");
        ~~

  test/unit/api/app.spec.ts:7:7
    7 const fs = require("fs");
            ~~
    'fs' was also declared here.
src/api/app/app.ts:5:7 - error TS2451: Cannot redeclare block-scoped variable 'http'.

5 const http = require("http");
        ~~~~

  test/unit/api/app.spec.ts:8:7
    8 const http = require("http");
            ~~~~
    'http' was also declared here.
src/api/app/app.ts:6:7 - error TS2451: Cannot redeclare block-scoped variable 'https'.

6 const https = require("https");
        ~~~~~

  test/unit/api/app.spec.ts:9:7
    9 const https = require("https");
            ~~~~~
    'https' was also declared here.
src/api/app/app.ts:13:7 - error TS2451: Cannot redeclare block-scoped variable 'envVariableReader_1'.

13 const envVariableReader_1 = require("../../common/envVariableReader");
         ~~~~~~~~~~~~~~~~~~~

  test/unit/api/app.spec.ts:11:7
    11 const envVariableReader_1 = require("../../../src/common/envVariableReader");
             ~~~~~~~~~~~~~~~~~~~
    'envVariableReader_1' was also declared here.

Somehow, Typescript thinks I am redeclaring block-scoped variables, but as you can see in the error logging, my actual code and the corresponding test files are being block-scoped together when they are completely isolated files. I am aware that files without import/export statements are scoped globally- but both my app.ts and app.spec.ts files do have import statements so they should be treated as independent modules.
Playground Link:
N/A
Related Issues:
N/A

You're showing errors here that don't correspond to any code in your repro

You're showing errors here that don't correspond to any code in your repro

It's only the import statements that are showing up in the error. What code should I add to add more context? Should I paste the whole app.ts file?

@RyanCavanaugh I have the exact same issue.  Here's the Stack Overflow question
and the code branch.
Maybe it is a mocha quirk.  The code builds the JS files just fine, but mocha complains when it (re?) builds the TypeScript:
TSError: ⨯ Unable to compile TypeScript:
src/frames/frame.ts:5:7 - error TS2451: Cannot redeclare block-scoped variable 'meta_frame_1'.

5 const meta_frame_1 = require("./meta-frame");
        ~~~~~~~~~~~~

  src/frames.ts:47:5
    47 var meta_frame_1 = require("./frames/meta-frame");
           ~~~~~~~~~~~~
    'meta_frame_1' was also declared here.

Is mocha doing something strange when compiling typescript?
Here's the mocharc:
{
    "extensions": ["ts"],
    "node-option": [
      "loader=ts-node/esm"
    ],
    "require": "ts-node/register",
    "spec": ["test/**/*-spec.ts"]
  }

I don't know how mocha handles this. There doesn't seem to be a TypeScript issue here.


[bug]: zero_conf_confirmed_scid is not populated after private channel confirmation

Background
When a private channel confirms and it is zero_conf true, it should populate its confirmed id within the zero_conf_confirmed_scid field but this remains at a nil value indefinitely
Your environment

lnd docker image daily-testing-20230312

Note, when using daily-testing-20230311 and prior the confirmed scid will be populated
Steps to reproduce

Create a private channel that has zero conf true and private true
Generate blocks to confirm the channel
Wait for the zero_conf_confirmed_scid attribute to reflect the confirmed id

Expected behavior

The confirmed id should be populated

Actual behavior

The confirmed id is never populated

Looks like the itest won't pass if we wanna check its confirmed SCID,
diff --git a/itest/lnd_zero_conf_test.go b/itest/lnd_zero_conf_test.go
index f2190bd2a..7a1f93b53 100644
--- a/itest/lnd_zero_conf_test.go
+++ b/itest/lnd_zero_conf_test.go
@@ -104,6 +104,11 @@ func testZeroConfChannelOpen(ht *lntest.HarnessTest) {
 	// assert that sending is still possible.
 	block := ht.MineBlocksAndAssertNumTxes(6, 1)[0]

+	// Once the private channel is confirmed, check that the confirmed SCID
+	// is populated.
+	channel := ht.AssertChannelActive(bob, fundingPoint2)
+	require.NotZero(ht, channel.ZeroConfConfirmedScid)
+
 	// Dave should still have the alias edge in his db.
 	err = waitForZeroConfGraphChange(dave, descReq, true)
 	require.NoError(ht, err)

// Once the private channel is confirmed, check that the confirmed SCID
+	// is populated.
+	channel := ht.AssertChannelActive(bob, fundingPoint2)
+	require.NotZero(ht, channel.ZeroConfConfirmedScid)

I think this should be carol instead of bob, then it passes, which I think means that this is not the right repro?


Add alert if validators change commission rate

It would be a good idea to have some type of alert in an event where validator change their commission rate from the one agreed upon when employing restake.app.
Supporting info: https://www.reddit.com/r/CosmosAirdrops/comments/wfgn9g/to_those_using_restakeapp/?utm_source=share&utm_medium=ios_app&utm_name=iossmf

Thanks for the suggestion, I like this idea and will consider it for the future.


[Deque Analysis] Avoid using "text_muted", as it has insufficient color contrast on a white background

Deque Analysis Summary
The text_muted style is used in a number of scenarios, and it's contrast is insufficient on a white background.  A few of the scenarios where it is used include:

Displays of objects in lists...often the displayed non-Title metadata (e.g. date, authors, etc) uses text_muted.
Placeholder text in input fields use text_muted.

The contrast error is common in all these scenarios:
"Element has insufficient color contrast of 2.99 (foreground color: #959595, background color: #ffffff). Contrast must be 4.5 or more."

Search Results (9 tickets)

https://demo7.dspace.org/search?spc.page=1&query=test&spc.sf=score&spc.sd=DESC
Locations:

Date/Author metadata displayed in results uses text_muted
Placeholder text in all input boxes (in filters sidebar & in search box itself) uses text_muted

Deque issue ticket IDs: 468512, 468513, 468514, 468515, 468516, 468517, 468518, 468519, 468520, 468521, 468522, 468928

Header Search box / Login module (2 ticket)

(on all pages)
Locations: Placeholder text in search box & in email/password of login field use text_muted
Deque issue ticket IDs: 469254, 469332

Browse by Comm/Coll (1 ticket)

https://demo7.dspace.org/community-list
Locations: Community/Collection descriptions use text_muted
Deque issue ticket IDs: 470068

Homepage (3 tickets)

https://demo7.dspace.org/home
Locations: Placeholder text in search box, and Community/Collection descriptions use text_muted
Deque issue ticket IDs: 469553, 469470, 469471

Submission (16 tickets)

https://demo7.dspace.org/submit
Locations:

Drag & drop files text (at top)
Hint text under all fields
Placeholder text in input fields
Labels/hints for edit file name/description (after uploading a file)
File size (KB/MB) text next to any uploaded files

Deque issue ticket IDs: 469504, 469507, 469509, 469511, 469513, 469515, 469517, 469520, 469522, 469523, 469525, 469527, 469529, 469530, 469977, 470000, 470006

Collection homepage (5 tickets)

https://demo7.dspace.org/collections/0f58a9e3-254a-4a38-a6ea-8c1922762475
Locations:

Date/Author information in all Item lists
Placeholder text in input fields (of Browse by Date, Title, Author, Subject

Deque issue ticket IDs: 469638, 469639, 469640, 469641, 469642

Community homepage (2 tickets)

https://demo7.dspace.org/communities/8b632938-77c2-487c-81f0-e804f63e68e6
Locations:

In the Settings dropdown, the "section header" for "Results Per Page" and "Sort Options"  (this same settings dropdown appears other places as well & was also reported in "Browse by Author")

Deque issue ticket IDs: 470092, 469381

Edit Collection (1 ticket )

https://demo7.dspace.org/collections/0f58a9e3-254a-4a38-a6ea-8c1922762475/edit/metadata
Locations: Text in the drag & drop box "Drop a Collection Logo to upload"
Deque issue ticket IDs: 470081

MyDSpace (18 tickets)

https://demo7.dspace.org/mydspace?configuration=workspace&spc.sf=score&spc.sd=DESC
Locations: "No Title" text in item list, along with date/authors in item list
Deque issue ticket IDs:  470125, 470126, 470127, 470128, 470129, 470130, 470131, 470132, 470133, 470134, 470135, 470136, 470137, 470138, 470139, 470140, 470141, 470142

Recommended Fix
As discussed in recent meetings, we may want to move away from using text_muted at all (and recommend against it in our style guide).

For text which is secondary (e.g. dates, author text), we may wish to use the secondary color & ensure it has proper color contrast on a white background (must be 4.5 or greater).  This means that if we want the secondary color to remain gray, it may need to minimally be #757575.  However, other secondary colors are welcome, provided it meets AA compliance (AAA is not required) using this tool: https://dequeuniversity.com/rules/axe/4.1/color-contrast?application=axeAPI
For placeholder text, Deque recommended considering making it italics rather than making it appear lighter via text_muted. However, obviously we should ensure once text is typed in the box, it is no longer in italics.

More Information / Tools

As necessary, see mentioned Issue IDs in our assessment results (requires login): https://axeauditor.dequecloud.com/test-run/0856438a-a19a-11eb-bc31-b7d5be387c86/issues
Consider using Deque's free Chrome plugin to check your work
Deque's color contrast tool: https://dequeuniversity.com/rules/axe/4.1/color-contrast?application=axeAPI

The default bootstrap has for $gray-600 (which is used for text-muted) does have enough contrast against a white background to pass. I propose we stick to bootstrap's default gray values at all in the base or dspace themes. That will fix this issue and likely a few of the other contrast tickets as well
This can be done in 1 hour.

Sounds good @artlowel and thanks for digging into that. That sounds like a clean solution.  Adding 1 hour estimate & assigning to you for your team to fix.


Add feature to read chaos parameters from aws ssm

add the feature to read chaos settings from aws ssm instead of using stream url parameters.
add lambdav2 to be able to run from aws lambda
update Dockerfile to make it smaller.

Awesome stuff! Thanks!
If you could just rebase with master and squash the PR commits I will have a look. I think perhaps the lambdav2 implementation could replace the existing one

@birme thanks for your feedback.
about lambdav2, i did it because i was not able to make it run using "v1".
Maybe do you know if still working using v1 ? i can replace with v2, at your convenience.

@birme thanks for your feedback.
about lambdav2, i did it because i was not able to make it run using "v1".
Maybe do you know if still working using v1 ? i can replace with v2, at your convenience.

I suggest you replace v1 with v2, it looked good!

@birme done ;)

Again, thanks for the contribution. I see that the linting, prettier and type check fails. It would be great if you could address these.

Hey! Cool stuff. I'm having some trouble getting your project to run, could you perhaps add some (more) instructions as to how to get it running locally and manage the corruptions?

@birme  @ShibireX build issue is caused by demo.ts, I don't understand the purpose of this file , should i delete it ?

@birme @ShibireX build issue is caused by demo.ts, I don't understand the purpose of this file , should i delete it ?

I'd rather see to adapt it to using the new lambda implementation instead. If possible. Thanks!

Thanks, you're almost there :)
Now just fix the lint and prettier issues. You can run it locally
npm run lint

and
npm run pretty

I get a compilation error now for some reason?
src/lambda.ts:4:22 - error TS2304: Cannot find name 'awsLambdaFastify'.

4 export const proxy = awsLambdaFastify(app);

Nice, thank you for this! Will merge it


Introduce support to "Connect from Github" at the CLI

Context: https://github.com/Shopify/shopify-cli/pull/2200#issuecomment-1115934030

Would be a huge time saver in our workflow!

Still relevant 👀


Build fails with spaces in home directory

Mainly just posting this in case anyone else runs into this problem. I'm not sure if it's fixable in the script.
When doing a Windows cygwin build, the OpenSC build failed because my user home directory had a space in it. I was able to work around this issue by changing the home directory by adding a HOME environment variable that pointed to C:\cygwin\home\namewithoutspaces

Scott,
Thanks for the feedback. I'll take a look. I can think of at least 1 possible source of the error: fortunately, it's easy to fix with double-quotes around an expansion. Will look for other places like that. Out of curiosity... Did it run to completion? Is authentication working for you?
Thanks,
Brett S.

After fixing that error, it ran to completion and authentication worked successfully!
Thanks for creating this.

Excellent! Glad to hear it. I appreciate the feedback.


Add wrapper library for confidential precompiles

This looks overall good. Thanks for adding it. When you mark this as ready for review, I'll add the linter configs and reformat.


Allow Bank and Inventory Tags for degradable (Barrows etc.) items to be set for all degradation levels

Having barrows items degrade after you've added a new tag to them makes it seem like they aren't added to the tag, as only one degradation level has the tag added. Would be nice to add an option to the bank tags plugin to have degradable items have shared tags amongst each stage, e.g. tag "Karil's Leathertop" with "bandos" and all degradation states are given that tag.
Also, having the inventory tag (coloured outline) set the same for all states would be nice.
This should be kept as an option and not made standard, as I'm sure some people who are rich enough have multiple sets and don't want to take nearly degraded sets PKing or wherever else.

put a * after the name when tagging, or shift drag it into a tag tab


Added a new rebus

Associated Issue: #
Summary of Changes

change 1
change 2

Pull Request Test Coverage Report for Build 760

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.143%

Totals

Change from base Build 514:
0.0%

Covered Lines:
158

Relevant Lines:
180

💛  - Coveralls


Gradle: Upgrade Kotlin to version 1.4.20

See https://blog.jetbrains.com/kotlin/2020/11/kotlin-1-4-20-released/.
Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>

The Travis build fails. Obviously, the new version generates new warnings related to temporary files.

Quite funny to issue a compiler warning here when the proposed alternative is still marked experimental 😨


Regeneration is not working for non ops

If a non op player is breaking the blocks they are getting the the blocks instead of replacing it, but If a op player is breaking the block it works perfectly, it regens the block, but it's not working for non op players,
I have a general ideas why it's happening, i think it's not working bc of bypass permission, but can you look into it.
And i have messed around some things and Found the solution. I just Removed  default: op in plugin.yml

actually the block replacement is only for players who have permission, so not just any player can do it

You can give them permission using additional plugins like PurePerms or |GroupsAPI`

Ok thankyou for the help


Screen depth artifacts on mobile (iOS / Android)

A simple shader that calculates depth height on a plane, using the screen to world depth difference, produces visible banding on mobile.
Here is on desktop:

Here is on Android 10, Samsung Galaxy S10:

Here is on an 2020 iPad, iOS 14.3:

The shader code is pretty simple:
varying vec2 vUv0;
varying vec3 vPositionW;

void main() {

    float waterDepth = getLinearDepth(vPositionW);
    float depth = getLinearScreenDepth();

    float depthDiff = clamp(pow(abs(waterDepth - depth) * 27.5 * 0.002, 0.5), 0.0, 1.0);

    gl_FragColor = vec4( vec3(depthDiff), depthDiff);
}

Project sample: https://playcanvas.com/editor/scene/1164740
It seems like a texel size / resolution issue, though we were unable to find the exact fix by overriding the internal screen depth chunk methods.

maybe it needs
#define GL2

maybe it needs
#define GL2

Added that to the top of the PS shader, but still the result is the same on mobile.

how about
precision highp float;
I suspect it might default to lowp if not specified

Added it but still the same. We thought it may be some precision issue, we even rendered to a render target on another example and messed with the texture formats to increase precision but still the same issue.

I tried the example on Google Pixel 3A, Android 11, and also iPhone XR on 14.5, and cannot see any banding there.

It seems to reproduce here on the following devices:
Samsung Galaxy S10, Android 10, Chrome

iPad 2020, iOS 14.2, Safari

So issue seems to persist, tested on the following devices:

iPhone iOS 14 (WebGL 2.0 enabled)
iPad 2020, iOS 14 (WebGL 2.0 enabled)
Samsung Galaxy S10, Android 11

All produce the same result, interestingly when switching to WebGL 1.0 the issue is resolved. Any idea why the same shader produces a different output?
We are about to release an open alpha of our open world game, it would be great if we could solve this. On the same device/OS/browser, WebGL 1.0:

WebGL 2.0:

Presuambly there is a bug in the GL2 code path for getLinearScreenDepth:
https://github.com/playcanvas/engine/blob/master/src/graphics/program-lib/chunks/screenDepth.frag#L36

Although then I would expect the bug to happen on desktop too under WebGL 2.

This may be related: https://github.com/mrdoob/three.js/pull/18696

Although then I would expect the bug to happen on desktop too under WebGL 2.

Yeah, I thought so. Initially I thought something with the screen size may be the issue but I wasn't able to reproduce the issue on desktop emulating mobile screen sizes ( pixel ration > 1).

I seem to be able to fix this by overriding the screenDepth.frag chunk and editing:
uniform sampler2D uDepthMap;

to:
uniform highp sampler2D uDepthMap;

Confirmed, that indeed fixes the issue. Many thanks @willeastcott for the find!

For anyone coming across this and until the fix is added to the engine, you can do the following before using the screenDepthPS shader chunk:
// --- fix precision of depth map on mobile
pc.shaderChunks.screenDepthPS = pc.shaderChunks.screenDepthPS.replace('uniform sampler2D uDepthMap', 'uniform highp sampler2D uDepthMap');

The fix for this is now deployed so you can remove the workaround from your application code. 😄


Users are banned no matter how /banUsers is set

No matter whether it was to kick or ban a user, users are always blacklisted.
Is this correct? Shouldn't banUsers: false allow users to try joining more times?

banUsers: false bans a user for 30 seconds. This is how you kick on Telegram.

banUsers: false case

User tries to join a group
Fails to answer captcha
Kicked/banned by Shieldy
Added to blacklist <- !!! indefinitely !!! (just checked, tested in the morning, still on blacklist)
When trying to access the same group user always gets 'Sorry, this chat does not seem to exist message'

Am I missing something?

You are, banUsers: false bans a user for 30 seconds. https://github.com/backmeupplz/shieldy/blob/fb346ef132acd42bd64aafa13a63170568d3efee/src/helpers/newcomers.ts#L297.
Make sure to set banUsers option in the group chat, not in the private messages with the bot. Changing this option only affects future user joins.


Was Working....Now It's Not

Before opening the issue, have you...?

[X] Searched for existing issues
[X] Read through the Monitor-Troubleshooting Wiki
[X] Updated MonitorControl to the latest version (if applicable)

Describe the issue
checked Better Display and Lunar out, they’re nice, but I like monitor control best.
I think I might have made some kind of mess, though.
When I removed the others I went to change the contrast in Monitor control of my Alogic monitor and it flipped to grayscale.
I rebooted and it was fine.
I removed MonitorControl and reinstalled it. It’s now not syncing between the two. The app launches and I can see both monitors, but the display brightness doesn’t pop up on the Alogic and it doesn’t change as well.
I tried to reset all settings - the same result.
Any suggestions?
Expected behavior
normal functionality
Anything else?
No response
Environment Information (please complete the following information)
- macOS version: 14.0
- Mac model: MBP 2021
- MonitorControl version: 4.2.0
- Monitor(s): Studio Display, Alogic 27"
- Monitor Cable(s)/Connection(s): USB-C, USB-c to HDMI
- Apple Silicon/M1 (yes or no): yes

I'll move this to discussions, maybe there are others with experience in Alogic monitors.


[Transitions] Increase minimal version of react-transition-group to 2.5.3

[x] I have followed (at least) the PR section of the contributing guide.

I want to update react-transition-group to version 2.5.3 because of a fix for setState while unmounting.
I don't think there are any breaking changes in the version history and I tested the documentation locally, all seems fine.

Hmm I just realized that with using material-ui in my project yarn already uses 2.5.3. So the issue is something else. Anyway wouldn't hurt to update the package I think.

Why force the use of the latest version? As a rule we should support the minimum version of a package that works with Material-UI and above.

Depends on the package. Usually it's better to propagate patches downstream. This way people can rely on bigger packages to vet updates and just have to update a single package to get improvements for various packages.
Whatever we decide on we should be consistent. The current state of having updated versions in the lockfile and earlier versions in the package.json quite dangerous. We might use features of a package introduced in 2.7.0 which is used via lockfile. But if we declare ^2.6.0 in the package.json then this is technically not correct. Any user installing our package might still be using 2.6.0 due to another dependency and now our package fails. Debugging those issues can be very frustrating.

@mbrookes Hard tradeoff. One could argue that it's better to have a site working and slow than not working, the version also have a bundle size reduction pull request by @TrySound.

So far the strategy has been to only update the dependency version when we need it (new features or bug fixes)

It might be worth adding that the fix above was applied in 2.5.1

Correct and 2.5.3 contains the bundle size reduction.

I see there was just a similar discussion here: https://github.com/mui-org/material-ui/pull/14602#pullrequestreview-206188615, so sorry for the distraction; but glad to know we're all on the sam epage.


chore(release): v0.5.0

Version bump in package.json for release v0.5.0

:tada: This PR is included in version 0.5.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix pie chart related bugs

Fix no entry pie chart bug
Fix sizing bug for list panel

Codecov Report

Merging #221 into master will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #221      +/-   ##
============================================
- Coverage     67.63%   67.53%   -0.11%
  Complexity      948      948
============================================
  Files           145      145
  Lines          3198     3203       +5
  Branches        352      353       +1
============================================
  Hits           2163     2163
- Misses          911      916       +5
  Partials        124      124

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/seedu/momentum/ui/PieChartCard.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 469dfdd...6a45e12. Read the comment docs.


Create a junit runner for PDSL framework

Now that we have some reporting features it would be useful to integrate with JUnit, aggregate all test run information and create PDSL reports.

A JUnit4 runner was created as of v0.5.0


Unnecessary preprocessing of geometries for Bokeh - Lesson 5

Bokeh can use the geometries of GeoDataFrames off the cuff if you first convert them to JSON, followed by creating a GeoJSONDataSource, and feeding it to it.
e.g. GeoJSONDataSource(geojson=GeoDataFrame.to_json())
Then you use the GeoJSONDataSource as you would a ColumnDataSource, as Bokeh does the conversions internally. The conversion to x's and y's or xs' and ys' occurs, so you are able to use those as column names.
P.S. Very informative course. Thank you!

@DmitriyLeybel Ah perfect! Thanks for sharing! 👍  Did not have time to check the latest changes on bokeh, hence, the materials were lacking behind a bit. A year ago this feature was not yet available (as far as I know). I will test and modify the materials accordingly. Thank you!

@DmitriyLeybel Added a hint about the possibility to use a GeoJSONDataSource at the end of the following page: https://automating-gis-processes.github.io/2017/lessons/L5/advanced-bokeh.html
Need to keep this (i.e. parsing the xs and ys with dedicated functions) now like they were for consistency with the lecture videos but will update all materials for the next year.


Subsidy

Pull request checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Build (yarn build) was run locally and any changes were pushed
[x] Lint (yarn lint --check) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Depends #30
Closes #66
Closes #67
Closes #68
Closes #69
What is the new behavior?
Does this introduce a breaking change?

[x] Yes
[ ] No

Other information

This needs some more tests, especially for negative rep proofs in the contracts, but should mostly be ready for review. Demo running here. Made a new task for building the negative rep proof into the ui #75

user cannot vote themselves (need UI hint)
go to etherscan error: originally it's kovan-optimistic.etherscan.io/tx/${post.id}, but I found that the post.id is not transaction hash now? (instead, it's data._id now, according to utils.ts in frontend
progress bar display has wrong number such as 108%
logout still not work
if the user sign out and re-login after epoch transition, won't do UST automatically. (but if reload page, will do UST)
user page is still full of bugs (1. not showing correct spent 2. not showing posts and comments with old epoch keys 3. click activities cause error)

The bugs can be fixed in other PR, for the core function of subsidy (use subsidy to post/comment/vote others, receive voted points after UST) is fine now :)


Missing selection of operation modes on Homekit for 1133.json (Mitsubishi Starmex)

Home Assistant version
2022.7.6
SmartIR version
1.17.6
SmartIR configuration
climate:
  - platform: smartir
    name: Living Room AC
    unique_id: living_room_ac
    device_code: 1133
    controller_data: remote.broadlink_rm4_pro_living_remote
    temperature_sensor: sensor.broadlink_rm4_pro_living_temperature
    humidity_sensor: sensor.broadlink_rm4_pro_living_humidity

Describe the bug
Homekit UI only shows a circle button that turns on/off the AC. I don't see options that I can scroll through. HA though has no issues and I can see all the available modes
Debug log
2022-07-25 22:33:40 WARNING (SyncWorker_2) [homeassistant.loader] We found a custom integration hacs which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2022-07-25 22:33:40 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration smartir which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2022-07-25 22:33:40 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration xiaomi_miio_fan which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2022-07-25 22:33:40 WARNING (SyncWorker_1) [homeassistant.loader] We found a custom integration webrtc which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2022-07-25 22:33:56 WARNING (MainThread) [homeassistant.components.generic.camera] Loading generic IP camera via configuration.yaml is

Additional context
I tried using the json file 1129 and saw that it can output the operation modes both on HA and Homekit properly but of course this doesn't work on my brand and model but I just wanted to see how other json file looks and compares to 1133

Hoping for a solution for 1133 too. In the Apple Hone app, cooling modes don’t show up and the fan slider doesn’t work (sliding it doesn’t change the fan speed). In the HA dashboard, all AC controls work well.


Prevent _allocate_placeholders crash if p_version->variants is null

Fixes the cause of crash of #83742. cc @clayjohn
However the situation which triggerred that crash is the wrong use of varying, which I suppose it can be prevented by better varying checking or at least better documentation? Not sure whether I should put that in this pr too (Ater I figured out how to fix it tmr).

Thanks!


[OFFICIAL] Generated Issue: InvalidArgumentException

Please fill out the details below.
Summary:
Using the API to get the anime occurring in a season results in a http 500 code a lot.
Steps to reproduce:
Request https://api.jikan.moe/v3/season/2020/spring
Additional Details
Jikan Parser Version: v2.18.13@d41c4535bb739824c61ae22192c41eb3b705399c
PHP: 7.4.23
Redis: Connected
Exception: InvalidArgumentException
Code: 0
Message: Status code must be an integer value between 1xx and 5xx.
Trace: /var/www/jikan/vendor/guzzlehttp/psr7/src/Response.php on line 152
Request: GET /v3/season/2020/spring

Okay so there's 2 issues here at play at this very moment.

There's currently a parser issue due to HTML change that's affecting endpoints like season, genres, schedule, etc.
You can track that here: https://github.com/jikan-me/jikan/issues/386

However, if you are getting specifically HTTP 5xx errors that's returning a message like Status code must be an integer value between 1xx and 5xx. and this has affected you from any other responses.
Please read: https://github.com/jikan-me/jikan-rest/issues/177

Just to update you that the # 1 mentioned parser issue has been resolved. You can read more about it here: https://github.com/jikan-me/jikan/issues/386
For the # 2 issue, please track it by the pinned issue I created #177 . I'll be closing this issue.


ion-rage does not update binded variable when using keyboard arrows on desktop browser (ionic serve)

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/driftyco/ionic-v1)
[ ] 2.x
[x] 3.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
So, I have simple ion-range:
<ion-range [(ngModel)]="singleValue" color="danger" pin="true"></ion-range>

and everything is fine when I'm using my mouse to move knob to change current value, but when I tab on it and use keyobard arrows value does not change at all.
Expected behavior:
Binded variable should change value when I tab on range (select range component) and use arrows to move knob.
Steps to reproduce:
Just create simple ion-range:
  <ion-item>
    <ion-label>{{singleValue}}</ion-label>
    <ion-range [(ngModel)]="singleValue" color="danger" pin="true"></ion-range>
  </ion-item>

tab on it (select) and try to use keyboard arrows to move knob in desktop browser - variable does not change its value.
Related code:
export class HomePage {
  private singleValue = 0;

  constructor(public navCtrl: NavController) {

  }

}

Other information:
My app has no other logic.
Ionic Framework Version: 3.1.1
Ionic CLI Version: 2.2.3
Ionic App Lib Version: 2.2.1
Ionic App Scripts Version: 1.3.7
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 8.1
Node Version: v6.10.3
Xcode version: Not installed

Hello, thanks for opening an issue with us! ion-range was not built with keyboard control in mind so this is something we would have to add. Because of this I am going to mark this as a feature request and move this over to our internal feature tracking repo.

This issue was moved to driftyco/ionic-feature-requests#229


coin select: add coin selection strategy option to all on-chain RPCs

Change Description
This PR adds coin selection strategy option to the following on-chain RPCs FundPsbt, SendOutputs, BatchOpenChannel, SendCoins, SendMany, EstimateFee and add coin_selection_strategy optional parameter to lncli equivalent commands (if any).
Fixes #8498
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[ ] Tests covering the positive and negative (error paths) are included.
[ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[ ] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[ ] Commits follow the Ideal Git Commit Structure.
[ ] Any new logging statements use an appropriate subsystem and logging level.
[ ] Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
[ ]  There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our  Contribution Guidelines for further guidance.

@mohamedawnallah can you please apply the fixup commits and rebase?

Okay, that makes sense I'm used to the monolith commits but I started to love the small commits with related changes that said I'm gonna update the commits individually so that it would be easier for review and let you know.

@guggero I've broken up the monolith commits into smaller commits please let me know if any feedback on the PR. Thanks 🙏

@guggero: review reminder
@ellemouton: review reminder
@mohamedawnallah, remember to re-request review from reviewers when ready

Thank you very much, @ellemouton, for your feedback! The idea of converting the CoinSelectionStrategy string to wallet.CoinSelectionStrategy only once simplified the code significantly. Thanks for this. I've addressed all of your feedback :)

The latest change after asking for a review is related to the lining error solved by adding //nolint:funlen to fundPsbtCoinSelect:
lnrpc/walletrpc/walletkit_server.go:1474: Function 'fundPsbtCoinSelect' is too long (201 > 200) (funlen)

The latest push after asking for a review is just rebasing!


chore(master): release odata-filter-to-ast 2.0.0

:robot: I have created a release beep boop
2.0.0 (2024-05-26)
⚠ BREAKING CHANGES

use single quotes for strings
use CamelCase for AST nodes

Bug Fixes

use CamelCase for AST nodes (bc5e76d)
use single quotes for strings (7e4cbd2), closes #3

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/petrzjunior/odata-filter-to-ast/releases/tag/odata-filter-to-ast-v2.0.0 :sunflower:


Add styles

In this branch I added styles for space-travelers project.

Hi @yodit93
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights
Used gitflow :+1:
Great effort in making the requested changes :+1:


[Feature/1722] - Change CAS3 assessment search by using status directly in DB query

Changes in this PR
Refere 1722 for more information.
This PR to overcome performance problem in searching CAS3 assessment.
Current:  the search is happening by selecting all assessment and then filter by assessment status.
Change:  This PR is to add the additional WHERE clause to an in existing query using 'status'(assement-status). Additionally merging existing 2 CAS3 assessment search query into single query.
Added indexes to applications(crn), temporary_accommodation_applications(probation_region_id) to improve assessment search query performance.
The status where clause is derived by following the existing logic as below
**Status**                                    **DB Query**
rejected                                          assessment.decision = 'REJECTED'
closed                                            assessment.decision = 'ACCEPTED' AND applications.completed_at !=null
ready_to_place                             assessment.decision = 'ACCEPTED' AND applications.completed_at =null
in_review                                       assessment.decision = null AND assessments.allocated_to_user_id !=null
unallocated                                   assessment.decision = null AND assessments.allocated_to_user_id =null

We may need to make changes in front end to search assessment with status whenever the user change the status view page.
Release checklist
As part of our continuous deployment strategy we must ensure that this work is
ready to be released at any point. Before merging to main we must first
confirm:
Pre merge checklist

[ ] Have all changes to any dependencies been deployed to both preprod and
production in a backwards compatible way? (This includes our API,
infrastructure, third-party integrations and any secrets or environment variables)
[ ] Has a required data migration been included in this change or been done in
advance?

Post merge checklist
Once we've merged we now need to release this through to production before
considering it done.
Find the build-and-deploy job in CircleCI
and work through the following steps:

[ ] Has the product manager asked to provide approval for this feature?

[ ] Has the product manager approved?

[ ] Manually approve release to preprod
[ ] Verify change released to preprod
[ ] Manually approve release to prod
[ ] Verify change released to production

Should a release fail at any step, you as the author should now lead the work to
fix it as soon as possible.

We are just holding this PR not to merge because we need to complete UI change to make sure of the performance improvement.


Import module could not be resolved from source

Issue Type: Bug
1- I installed the module "requests" using the command "pip install requests"
and checked that it is indeed exist on my machine using the command "pip
list".
2- I wrote a python file that contains the line "import requests".
3- when running the file using the command "python3 [file_name.py]", I recieve
this Error message in terminal :
"Import 'requests' could not be resolved from source".
I tried reinstalling the module and restarting VScode, I also tried selecting all different python interpreters, I basically tried all solutions I found when googling the issue; NON OF THEM WORKED !!
VS Code version: Code 1.68.0 (4af164ea3a06f701fe3e89a2bcbb421d2026b68f, 2022-06-08T11:44:16.822Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3720QM CPU @ 2.60GHz (8 x 2594)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.93GB (2.34GB free)

Process Argv
--crash-reporter-id 6fae18fc-cf86-44dc-8d9b-55dd72bba567

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

code-runner
for
0.11.7

python
ms-
2022.8.0

vscode-pylance
ms-
2022.6.10

jupyter
ms-
2022.5.1001601848

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.8

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
vscaac:30438847
vsclangdf:30486550

/extPython

It looks like this is caused by the Python extension. Please file the issue to the Python extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


Having an option to keep built-in attributes in the log

Hey, it would be great if there is an option that allows preserving built-in attributes (time, level, msg..) in the log.
So basically, instead of having logs like
2024-06-24T20:29:08Z INF this is a message key_1="1234" key_2=456

The log will looks like below with the new option.
time=2024-06-24T20:29:08Z level=INF msg="this is a message" key_1="1234" key_2=456

Let me know if this makes sense.
Maybe I can provide a PR if this looks ok.

That looks exactly like the format of the slog.TextHandler. Why not use that?

That looks exactly like the format of the slog.TextHandler. Why not use that?

Yes, you are right!
However, I still want to have some color in the log so it's slightly more readable.


apfsprogs: unstable-2021-10-26 -> unstable-2022-02-23

Description of changes
This update only adds a single commit: https://github.com/linux-apfs/apfsprogs/commit/5bce5c7f42843dfbbed90767640e748062e23dd2.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer


[MWC-QT-WALLET] UI Strange buttons and lacking info text when restoring from seed and connected to custom node

Seen on: OSX
Steps to reproduce:
Have a QT wallet connected to a custom node.
Close the wallet and recover from seed (any seed)
Enter the phrase and hit continue.

I thought this might have been related to my ttl changes, but looks like this is present in 1.0.22 too.

It was bug, I saw it, it should be fixed by now.


Unable to query API for 2C-B effects

I haven't been able to get the effects data for 2C-B using the API.
Example:
{
    substances(query: "2cb") {
    		name

        # subjective effects
        effects {
            name url
        }
   }
}

Returns this:
{
  "data": {
    "substances": [
      {
        "effects": [],
        "name": "2C-B"
      }
    ]
  }
}

It's able to query 2C-B itself but the effects are missing despite the wiki page containing them.

Thanks for reporting. I'll look into it.

We determined that parts of our semantic metadata infrastructure are currently having an outage. This is hopefully resolved soon. I will keep this thread updated.

Effects should be restored.


pull request for e2e test at 01/02/2017 09:45:14

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add listunspent RPC call

Returns a brief json summary of each utxo found by calling
ListUnspentWitness in the wallet. The only argument is the
number of confirmations (0=include unconfirmed), acting as
a filter.
Arguments: minconfs maxconfs (so filter functions as in Core).
moli on IRC suggested this might be a desirable thing, which is certainly understandable, for debugging/checking. It currently shows (address, scriptpubkey, txid:n outpoint and amount in satoshis) in the json output.
Adding the number of confirmations seems a little non-trivial as that's available in the call to the underlying wallet.ListUnspent ListUnspentResponse object but is not returned in the WalletController interface (which exposes ListUnspentWitness which returns objects of type Utxo, which don't contain the number of confirmations). That could be changed but it didn't seem enough of a big deal to address here.
I'll probably add a brief test function.

tACK!
This is awesome! I just compiled on a testnet node and here's the result:  http://paste.ubuntu.com/p/HGPs3bTKHG/
Would love to have this for LND.  Thanks, Adam.  :)

Squashed and rebased.

The message type ChannelPoint in the rpc is now reused for the Outpoint field in the lnrpc.Utxo message type. However this is a bit silly naming-wise since of course our spendable utxos are not channel points. As previously, just trying to avoid spreading code changes all over the place if it's not needed.

Yes, I agree that it should probably be renamed to OutPoint. Also, one could argue if the oneof is justifiable. It makes the interface wider while decoding hex bytes could easily by done by the caller too.

Needs a proto rebase (this happens quite often)!

(1) The message type ChannelPoint in the rpc is now reused for the Outpoint field in the lnrpc.Utxo message type. However this is a bit silly naming-wise since of course our spendable utxos are not channel points. As previously, just trying to avoid spreading code changes all over the place if it's not needed.

It doesn't seem like type aliases are supported, so I think it's probably better to just rename it or define a new OutPoint message to prevent the rename change.

(2) For the AddressType I factored out the enum so it was reusable (i.e. not restricted to the NewAddressRequest message), which required a couple of very minor edits. I presume that's OK/desirable

Indeed 👍

(3) There is an issue with casting the number of confirmations from int64 to int32 here, but as per comment it seemed it was OK ... note the origin of the mismatch is that what is returned from ListUnspent in the btcd codebase here is an int64, so that's what I've stored in the Utxo struct that ListUnspentWitness returns.

Yeah, I'd say just keep things as they are now. Modifying this to be int64 would probably be a  somewhat large diff.

After one final rebase (hopefully!?) that also squashes the commits, I think this is ready to land!

Rebased again. I removed the created change to go.sum; I actually don't know what it is, so let me know if that was the wrong thing to do.

tACK, just tested on my node; thanks a bunch @AdamISZ!
I have one minor cosmetic comment, which I think has an easy fix. Since we use the ChannelPoint proto object to serialize the outpoints, the json fields show "funding_txid_str":
            "outpoint": {
                "funding_txid_str": "b616b49afa2b724a71469e798c9dbff24f11f3bfddd38a3f3ef356e6a388926a",
                "output_index": 0
            },

I think it might be worth adding an OutPoint type to lnrpc and using it here. (IMO arguably ChanPoint should just use this as well, but that's out of scope). Idt this is a blocker on the PR though, as it would be an easy fix in a follow up and since we're in between releases it should be fine if the final API changes slightly.
Appreciate all the hard work on this feature. I know a lot people have requested it, so thanks again :)

Squashed + addressed nits, cheers.

May be an issue with this method when listing unspents after a seed restore


PIDS generate id automatically if not given one

look good. it would be nice to know the motiation for doing the change, though.

There was a long discussion on Discord about this. Most important change is that you can spawn an actor without specifying ID.

@perbu Couple things that made me do this.

It is very common to spawn more actors of the same "type/kind/domain" (player, inventory, db, lobby, connection). So spawning the same actor type over and over again would conflict with the registry, unless the user provides a custom ID. If the user does not provide an ID then we just create an unique one ourselves.

A PID should be very simple (address and id). WithTags was just a fancy term for creating a single string.

@tprifti This breaks stuff if you are using WithTags in prod. But like I mentioned. We are freezing the API very soon.


re-positioning nodes does not move hitbox.

Can you tell me how you saved the cancas?
This is a rare save Bug so I'd like to track it down.  You can just reopen the Canvas and it should be gone;)

I was using setPosition but InputKnob (x) with the index seems to resolve this.

Oh, I thought you meant the node, not the knob. There is indeed an error in the save system I believe to have fixed that sometimes make nodes duplicate where one node was functional and one would basically 'sit' there without receiving input.
Anyway, yeah the node knob position need atleast one redraw to appear correctly, can be observed when opening the canvas without the mouse cursor in it.
Not crucial though, maybe a Repaint command correctly set will fix this;)


added voting app

This PR adds an page to vote for todo items of the core team. There are two currencies:

Influence: granted to everyone depending on how long you are github member
Golden Influence: granted by donations (importing of the open collective data WIP)

It's in a prototype stage. It would be great if someone takes care of the design (I can't do that).
Here is a screenshot:

You authenticate with the Github API. This means login only works on webpack.js.org host. A developer emulated version is used if not deployed. See code comment in api.js for more info.
Other ideas:

Auction stuff
Distribute a part of the money to ecosystem authors
Add your own ideas

It would be great if someone takes care of the design (I can't do that).

@oliverturner or @NejcZdovc, either of you interested in helping to implement a nice design here?

Sure not a problem. Will you prepare some kind of design or should I create one by my self?

Feel free to lay it out how you'd like, or maybe @sokra has some ideas. Might be some good examples of voting app designs on dribbble to use as a starting point...

I have no specific idea.
Feel free to add more example data in the development app.
We could reduce the number of votes users get. This would reduce the number of buttons we need.
You can do a PR to my branch.

Guys sorry for a delay, but I will tackle this issue on the weekend.

What do you think about something like this?

Initial value would be 0. You could go in minus 100 up to plus 100. As you can see in gif you have a snap functionality, which means that if step in circle is set to 10, and you can only set 10*x value. All values can be reconfigured, which means that you can have different settings for different sliders.

I think this could work. But it need to be a bit smaller. There can be up to ~100 items on the page...

Of course, this is just a demo. In reality we can do it a lot smaller.

It would be great to have a very basic styling soon and delay the bigger styling work for later.
I'd like to publish this soon to test this with real users. (I'm not sure how well this works out)

Sure, I will start working on this first thing tomorrow.

@sokra Can user set only value between 0 and x, or is it possible to set negative number as well, for example between -100 and 100?

@sokra also can you provide me limits (max value and min value) for all three sections.

Thanks.
The limits depends on the kind of list and kind of vote. The limits are provided by the API at runtime.
This is the current configuration:

List
Description

Todo
The todo list for the core team. We try to do most voted items first.

Feedback
Give feedback to various topics. You can like or dislike them with a score from -3 to +3.

Money Distribution
For a part of donated money you can decide who deserve it. Note that you can't undo your distribution once it's paid to the party.

List
Currency
Minimum
Maximum

ToDo
Influence
0
30

ToDo
Golden Influence
0
no

Feedback
none
-3
3

Money Distribution
Thanks
0
no

Currency
From

Influence
You can more over time (probably 1 per day)

Golden Influence
You get a bunch of them for donations

Thanks
You get points equal to 50% of the donated money

But I'm thinking about lowering the values to make it more intuitive.
Note: The money distribution stuff will probably be renamed/rephrased, because it's difficult to give money to people without asking them. So they probably get points which can be used to get money or golden influence.

Thank you for the extensive explanation. How should we handle this infinity maximum. If you have 300 gold influence, it's quite hard to be very accurate with a slider.

Created a PR #328, based on this PR.

How should we handle this infinity maximum. If you have 300 gold influence, it's quite hard to be very accurate with a slider.

The more you have, the less you care about the accuracy... It's like real money... :smile:
At least we can try to assume this and check if people complain.

For now I set it to 100, but can be easily changed to remaining currency.

ok the prototype is live, if you want to play with it:
https://webpack.js.org/vote/


Update express.js to a more recent version

We're still using 2.5.x while upstream's latest is 3.4.8 ..

Not a problem anymore. Windshaft-cartodb responsible for this now.


C++ Builder Support

Describe the bug
I installed this into my RAD Studio IDE and it works fine for Delphi and C++. When I use Delphi files, then it shows I am using Delphi and when I use C++ files, then it says I am using C++.
But the issue is with the Editor. It says I am using Delphi for both Delphi and C++. It should say C++ Builder as my Editor when I'm using C++ files.
To Reproduce
Steps to reproduce the behavior:

Work on any C++ Builder Project

Expected behavior
I would expect my Editor to be C++ Builder, but I only see Delphi:

Nice catch, I will add a filter on the file type to change the editor to C++ Builder.  However I'm relocating to another country so I expect to get into this issue on next month.

I'm thinking now.
If you add this feature to show C++ Builder, then it probably makes sense to rename this repo to "rad-studio-wakatime" as it's not just Delphi anymore.

Hey @shaunroselt, I think it make sense. First we just have to check if creating just the filter will fix everything for C++ or if it will raise some new issues. If something like this happens it would be better to separate into two packages.
Lets test it as soon as I have a little more time to get this issue.

The editor displayed on your dashboard comes from parsing the heartbeat's User-Agent header or plugin json post value. For C++ Builder to be parsed I'll need to first add it to the list of supported editors.

The editor displayed on your dashboard comes from parsing the heartbeat's User-Agent header or plugin json post value. For C++ Builder to be parsed I'll need to first add it to the list of supported editors.

Can we perhaps get it added so long then, please?
It can probably have the same color as Delphi since its logos are pretty much the same in terms of dominant colors.

Added C++ Builder to the list of supported IDEs. The User-Agent header will need to be changed when the plugin detects itself running in C++ builder from:
https://github.com/wakatime/delphi-wakatime/blob/91461c9355bedca452abc04730f51273aa3db02f/src/WakaTimeSendHeartbeatThread.pas#L107
To:
UserAgent = 'delphi/' + DelphiVersion + ' cppbuilder-wakatime/' + PluginVersion;

Thanks @alanhamlett it's on my todo list now ;)

Hey @shaunroselt can you test the latest commit from the development branch to see if it works?

Hey @shaunroselt can you test the latest commit from the development branch to see if it works?

Ah. You beat me to it 😁. I wanted to add C++ Builder support this weekend 😂.
Thanks. I'll test the development branch over the weekend and get back to you.

I ended up never testing the development branch.
Is C++ Builder support still planned?
I'm still keen on this feature. It would be nice to have.


[DMP 2024]: HCX - Digitizing Insurance Plans: Encoding health insurance products for machine readability

README.md
Description
The project aims to understand different UI applications provided by Swasth for claim processing and outlines the design process for creating a core UI component library and integrating it into multiple applications. This approach promotes code reusability and maintainability across multiple projects. The common components library will be hosted on npm with comprehensive documentation.
Goals

[ ]  Create machine readable insurance plans as per the FHIR standards :
[ ]  Data Extraction & parsing : Extract and interpret data from health insurance product documents (primarily pdf or docs), including policy details and coverage information.
[ ]  Data Standardization and coding : Standardise and code extracted data into structured formats compatible with FHIR standards as prescribed by Open HCX platform, ensuring consistency for interoperability across insurance systems.
[ ]  Data Quality Enhancement : Identify and rectify discrepancies in digitised insurance plans, filling missing information and resolving ambiguities for completeness.
[ ]  Testing and validation harness for the coded insurance plans :
[ ]  Develop the testing and insurance plan validation harness for the digitised insurance plans created by other ecosystem participants.

Expected Outcome
Backend required to extract, process, and encode insurance product data.
The tool should generate standardised insurance plans with FHIR codes, enabling machine-readable formats for processes like auto adjudication.
Test & validate insurance plans against the finalised format.
Acceptance Criteria
Any human readable format such as PDF etc. are converted into FHIR Insurance profiles   https://ig.hcxprotocol.io/v0.7.1/StructureDefinition-HCXInsurancePlan.html
Implementation Details

Project requires a detail understanding of JAVA or Python and APIs
Setup HAPI FHIR server in local machine
Understand FHIR profiles https://ig.hcxprotocol.io/v0.7.1/StructureDefinition-HCXInsurancePlan.html
Use programming concepts to convert available insurance plans in PDF format into FHIR structures

Mockups / Wireframes

Not applicable (NA)

Product Name
Digitizing Insurance Plans
Project Name
Digitizing Insurance Plans: Encoding health insurance products for machine readability
Organization Name
Swasth Alliance
Domain
Healthcare
Tech Skills Needed

JAVA
HAPI FHIR
PYTHON

Mentor(s)

@saurabh-singh-17

Complexity
High
Category

Performance Improvement
Feature
PoC

Sub Category

API
Accessibility
Backend
Research

Weekly Goals
Week 1

[x]  Understanding the HCX protocol

Week 2

[x]  Researching and testing the FHIR API

Week 3

[x]  Examining FHIR bundles and analyzing their various components and resources

Week 4

[x]  Understanding about the insurancePlans profile
[x]  Testing various PDF libraries for extracting the data from Health Insurance

Week 5

[x]  Study insurance plan of PMJAY and one private companies.
[x]  Extracting valuable information from the PMJAY pdf.

Week 6

[x] Making a Demo script for extracting Exclusion data from PDFs

Weekly Learning & Updates
Week 1

Learning 1: Gained a comprehensive understanding of the HCX protocol, including its key components and functionalities.
Learning 2: Acquired knowledge about the Primary flow APIs, focusing on their usage, integration, and common challenges.

Week 2

Learning 1: Gained insights into the structure and functionality of the FHIR API through research and testing.
Learning 2: Developed a solid understanding of FHIR implementation for HCX, including best practices and potential challenges.

Week 3

Learning 1: Explored FHIR bundles in depth, understanding their structure and the types of resources they can contain.
Learning 2: Analyzed various components of FHIR bundles, gaining insight into how they are used to group and manage related healthcare information.

Week 4

Understoop about the insurancePlans profile
Testing various PDF libraries for extracting the data from Health Insurance

Week 5

Study insurance plan of PMJAY and one private companies.
found out the basic pattern being used by all the Health Insurance PDFs, there was only a minor changes in PDFs otherwise all of them were created in similar pattern.

Week 6

Made a Script which can extract Exclusion data from the PDFs.

Script was tested on PMJAY plan of Gujarat, J&K and Nagaland.
Along with PMJAY plans it can also extract Exclusion data from "Bupa Niva" health Insurance Plan.

Week 7

Changed the data Extraction script to extract both Exclusion and Benefits data from the Health Insurance PDFs.

Where is the source code for this project?? @SudoSu-bham Tell me where is the source code


examples/stocks should be moved to dev/

The application example located in examples/stocks is outdated, and should be removed. Alternatively, if still used for internal test purposes, it should be moved to dev/

cc @gspencergoog can you help with this? I had a previous attempt in https://github.com/flutter/flutter/pull/22422, but it now conflicts with your template changes

Removing milestone since nobody is assigned.

cc @kf6gpe who was looking at this

Thanks. I hadn't dove into specific sub-examples, but that would be next on my proposal. I'll have a look.

Thanks @kf6gpe, you should be able to base this on https://github.com/flutter/flutter/pull/22422/files (which I had to revert after we changed the default templates)

Closing as PR https://github.com/flutter/flutter/pull/49559 has landed.


BUG: volshow with too small array?

Hi
volshow works with an array of shape (45, 45, 45)
import ipyvolume
import numpy as np
ipyvolume.volshow(np.random.rand(45, 45, 45))

but not slightly smaller
ipyvolume.volshow(np.random.rand(44, 44, 44))

Not sure what to do..
Thanks!

Thanks for reporting!

I was checking this, but here is works without issues, what is the problem exactly?


⚠ Bofrost.de has degraded performance

In a09eb50, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 962 ms

Resolved: Bofrost.de performance has improved in e5e15df.


Update OAT Blazor to Net 7.0

An issue is presented here because the 7.0.0 packages seem to not support net 6.0 so we would need to drop support for 6.0 to upgrade dependencies to the 7.0.0 release.

I was able to do this by using conditional dependencies based on framework version.


Understanding ESRGAN model through IREE

I downloaded esrgan_fp32_linalg.mlir provided by @vivekkhandelwal1  in a teams channel, and ran
mkdir dispatches
/path/to/iree-compile --iree-hal-dump-executable-sources-to=./dispatches  \
                      --iree-hal-target-backends=llvm-cpu  \
                        esrgan_fp32_linalg.mlir  -o cpu_exec.vmfb

This dumps the dispatches as individual mlir files in the directory "dispatches".
How many dispatches are there?
find . -name "*.mlir" | wc -l

There are 360 distinct dispatches. This is more than expected, as there are not that many distinct layers in the mode. But some of these dispatches are identical except for weights. For example when I compare 2 dispatches as follows:
vimdiff module_torch-jit-export_dispatch_165.mlir module_torch-jit-export_dispatch_195.mlir

I see that the only difference is in the weights that are embedded in the dispatch. Is there a way to make the weights to function operands, so that the functions are unique?
$ diff module_torch-jit-export_dispatch_165.mlir module_torch-jit-export_dispatch_195.mlir
1c1
< hal.executable public @"torch-jit-export_dispatch_165" {
---
> hal.executable public @"torch-jit-export_dispatch_195" {
3c3
<     hal.executable.export public @"torch-jit-export_dispatch_165_conv_2d_nchw_fchw_1x32x250x250x96x3x3_f32" ordinal(0) layout(#hal.pipeline.layout<push_constants = 0, sets = [<0, bindings = [<0, storage_buffer, ReadOnly>, <1, storage_buffer, ReadOnly>, <2, storage_buffer>]>]>) attributes {hal.interface.bindings = [#hal.interface.binding<0, 0>, #hal.interface.binding<0, 1>, #hal.interface.binding<0, 2>]} {
---
>     hal.executable.export public @"torch-jit-export_dispatch_195_conv_2d_nchw_fchw_1x32x250x250x96x3x3_f32" ordinal(0) layout(#hal.pipeline.layout<push_constants = 0, sets = [<0, bindings = [<0, storage_buffer, ReadOnly>, <1, storage_buffer, ReadOnly>, <2, storage_buffer>]>]>) attributes {hal.interface.bindings = [#hal.interface.binding<0, 0>, #hal.interface.binding<0, 1>, #hal.interface.binding<0, 2>]} {
9c9
<       func.func @"torch-jit-export_dispatch_165_conv_2d_nchw_fchw_1x32x250x250x96x3x3_f32"() {
---
>       func.func @"torch-jit-export_dispatch_195_conv_2d_nchw_fchw_1x32x250x250x96x3x3_f32"() {
12c12
<         %cst_1 = arith.constant dense<[[-0.129037291, -1.422290e-01, -0.0807310119, -0.128244475, -0.0398165733, -0.119981401, -0.113069206, -0.126817971, -0.0444165319, -0.0474722497, -0.0828626826, -0.0859258696, -0.145084366, -0.15676716, -0.0708842278, -0.149930134, -0.0774273946, -0.0647515133, -0.0672570392, -0.165924489, -0.0497073941, -7.261850e-02, -0.0830464735, -0.0497843362, -0.0845366641, -0.106523126, -0.0766393915, -0.0538191646, -0.115074076, -0.0525894538, -0.340261906, -0.155870825]]> : tensor<1x32xf32>
---
>         %cst_1 = arith.constant dense<[[-0.0380056612, -0.0330086388, -0.0296086408, -0.0663379803, -0.121410556, -0.0711337253, -0.111735687, -0.0797394365, -0.0937284901, -0.094646424, -0.0800017416, -0.0950915217, -0.144881442, -0.0933115109, -0.0424141847, -0.0521149226, -0.0428891256, -0.126851648, -0.048052825, -0.0963224172, -0.0750880837, -0.027913332, -0.0797173604, -0.0918321759, -0.0825948789, -0.169388652, -0.17149733, -0.0586047694, -0.0869528278, -0.10293851, -5.990920e-02, -0.11020527]]> : tensor<1x32xf32>
14c14
<         %c51211008 = arith.constant 51211008 : index
---
>         %c48335616 = arith.constant 48335616 : index
17c17
<         %1 = hal.interface.binding.subspan set(0) binding(1) type(storage_buffer) alignment(64) offset(%c51211008) flags(ReadOnly) : !flow.dispatch.tensor<readonly:tensor<32x96x3x3xf32>>
---
>         %1 = hal.interface.binding.subspan set(0) binding(1) type(storage_buffer) alignment(64) offset(%c48335616) flags(ReadOnly) : !flow.dispatch.tensor<readonly:tensor<32x96x3x3xf32>>

Adding a flag suggested by @MaheshRavishankar to avoid weight inlining works excellently to reduce the number of dispatches, so now running the following compilation:
iree-compile --iree-flow-inline-constants-max-byte-length=0   --iree-hal-dump-executable-sources-to=./dispatches --iree-hal-target-backends=llvm-cpu esrgan_fp32_linalg.mlir  -o cpu_exec.vmfb

we have just 20 dispatches. 7 of these don't contain any linalg operations, they're just flow.dispatch.load and flow.dispatch.store ops. Of the remaining 13 dispatches, 12 contain linalg.conv_2d_nchw_fchw, and the other one is just a linalg.generic with all "parallel" dimensions.
I've stitched the dispatches back together in the following gist: https://gist.github.com/newling/6828571a28ac2a2c33cd35c355ac903b