I test your model and only get 0.385 mAP.

python tools/test_ins.py configs/solov2/solov2_r101_3x.py solov2.pth --show --out  results_solo.pkl --eval segm
loading annotations into memory...
Done (t=0.51s)
creating index...
index created!
[                                                  ] 0/5000, elapsed: 0s, ETA:/home/user/miniconda/envs/pytorch1.3/lib/python3.7/site-packages/torch/nn/functional.py:2494: UserWarning: Default ups
ampling behavior when mode=bilinear is changed to align_corners=False since 0.4.0. Please specify align_corners=True if the old behavior is desired. See the documentation of nn.Upsample for detail
s.
  "See the documentation of nn.Upsample for details.".format(mode))
[>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>] 5000/5000, 6.9 task/s, elapsed: 722s, ETA:     0s
writing results to results_solo.pkl
Starting evaluate segm
Loading and preparing results...
DONE (t=5.71s)
creating index...
index created!
Running per image evaluation...
Evaluate annotation type *segm*
DONE (t=49.41s).
Accumulating evaluation results...
DONE (t=5.83s).
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.385
 Average Precision  (AP) @[ IoU=0.50      | area=   all | maxDets=100 ] = 0.596
 Average Precision  (AP) @[ IoU=0.75      | area=   all | maxDets=100 ] = 0.416
 Average Precision  (AP) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = 0.163
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.430
 Average Precision  (AP) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = 0.579
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=  1 ] = 0.317
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets= 10 ] = 0.494
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.517
 Average Recall     (AR) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = 0.275
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.576
 Average Recall     (AR) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = 0.722

sys.platform: linux
Python: 3.7.7 (default, Mar 26 2020, 15:48:22) [GCC 7.3.0]
CUDA available: True
CUDA_HOME: /usr/local/cuda
NVCC: Cuda compilation tools, release 10.1, V10.1.168
GPU 0: TITAN Xp COLLECTORS EDITION
GPU 1,2,3: TITAN Xp
GCC: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
PyTorch: 1.3.1
PyTorch compiling details: PyTorch built with:
  - GCC 7.3
  - Intel(R) Math Kernel Library Version 2019.0.4 Product Build 20190411 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v0.20.5 (Git Hash 0125f28c61c1f822fd48570b4c1066f96fcb9b2e)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - NNPACK is enabled
  - CUDA Runtime 10.1
  - NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_61,code=sm_61;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_37,code=compute_37
  - CuDNN 7.6.3
  - Magma 2.5.1
  - Build settings: BLAS=MKL, BUILD_NAMEDTENSOR=OFF, BUILD_TYPE=Release, CXX_FLAGS= -Wno-deprecated -fvisibility-inlines-hidden -fopenmp -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -O2 -fPIC
-Wno-narrowing -Wall -Wextra -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Wno-stringop-overflow, DISABLE_NUMA=1, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, USE_CUDA=True, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON, USE_STATIC_DISPATCH=OFF,

TorchVision: 0.4.2
OpenCV: 4.2.0
MMCV: 0.5.1
MMDetection: 1.0.0+2fbf5e2
MMDetection Compiler: GCC 7.5
MMDetection CUDA Compiler: 10.1

@sxhxliang The result is test on test-dev instead of val


[BUG] - Docker container cannot start because of invalid entrypoint

Internal/External
External
Area
Other   Docker image
Summary
Startup of the docker container fails with ...

Node version: alonzo-blue1.0

docker run --detach \
  --name=testrl \
  -p 3001:3001 \
  -e NETWORK=testnet \
  -v test-data:/data/db \
  inputoutput/cardano-node:dev

docker logs -f testrl

/nix/store/0nw88b5amclpgwad495im7rk783xf8b1-entry-point/bin/entry-point: line 23: /nix/store/x6naknarkx2mdrmp8fzg43dp8r3fhfw7-cardano-node-testnet: Is a directory
/nix/store/0nw88b5amclpgwad495im7rk783xf8b1-entry-point/bin/entry-point: line 23: exec: /nix/store/x6naknarkx2mdrmp8fzg43dp8r3fhfw7-cardano-node-testnet: cannot execute: Is a directory

Additional context
I'd take a look

PR #2796

Merged


⚠ Samsung has degraded performance

In fbd9eee, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2306 ms

Resolved: Samsung performance has improved in d456055.


Clarify instructions

When I did this problem, I enclosed an evenIterable and a distinct oddIterable in the closure of generate(). Then I swapped between them when next was called with swap. This results in the following behavior:
$ var iterable = generate(true);
$ iterable.next(); // 2
$ iterable.next(); // 4
$ iterable.next(true); // 1; the program expects 5
$ iterable.next(); // 3
$ iterable.next(true); // 6; the program would expect 4 given the previous line
I am unclear about whether I misunderstood or the terminology is incorrect. These few words for an example may help other people who got confused like I did.
Thanks for the course!

Excellent addition, thanks!
Published in v2.1.0.


Fix Release script called by Makefile

Note that CS-ID.xcconfig has been moved into Scripts/Resources/

Will revisit/rebase this later


Allow to override domain

Summary
Describe the goal of this PR. Mention any related Issue numbers.
Requirements (place an x in each [ ])

[ x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[ x] I've read and agree to the Code of Conduct.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Vivek Kothari seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for updating this PR @vivekkothari! Since the API requests originate from client.py#api_call I think we may want to also allow the domain to be overriden from the client.py#init's args.

We no longer support version 1.x as described here. Allow me to close this PR now. It's possible to customize the API endpoint URL by specifying base_url in v2.


dx12: Descriptor array updates

Vulkan allows specifying the initial array element for update when updating descriptors, we currently assume that it will always be the first one.
Probably requires hal changes.

I'm pretty sure this has been fixed already some time ago.


Containerd mess with kbld

What steps did you take:
I am trying to build and deploy an application using ytt, kapp and kbld.
Kbld use kubectl buildkit to build the image which goes fine.
Then when kapp try to deploy the container, the container goes in a Back-off pulling image state.
What happened:
Kapp get stuck trying to retrieve the image.
Pending: ImagePullBackOff (message: Back-off pulling image "kbld:rand-1673529450859089537-1671522333694-sitepro")
Anything else you would like to add:
Final line of kbld building: final: sitepro -> kbld:rand-1673529450859089537-1671522333694-sitepro
I can find the image in containerd using: sudo ctr -n k8s.io i ls | grep sitepro
Which result in:
kbld:rand-1673529450859089537-1671522333694-sitepro
application/vnd.docker.distribution.manifest.v2+json
sha256:f5f935d85a6fdb9223cd8ab136f9822f61db7edd69dc72a23a5d25f0832167ca
26.7 MiB
linux/amd64
io.cri-containerd.image=managed

Environment:

kbld version 0.36.1
Not using registry
Debian 11

Buildkit:

Client:  v0.1.6
Builder: buildkitd github.com/moby/buildkit v0.11.0 830288a71f447b46ad44ad5f7bd45148ec450d44

Kubernetes version:

Client Version: v1.26.0
Server Version: v1.26.0
Kubeadm Version v1.26.0
Containerd Version 1.6.15

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

Hello, @pgossa thanks for reaching out.
Does the cluster have access to the containerd "registry"?
Usually, when you use kbld to build your image you can go with one of 2 approaches
1 - Give access to the daemon/local registry you build the images on
2 - You push the image to a registry that the k8s cluster that has access to.
We usually suggest that you do number 2 since it is a more "realistic" scenario and is not always easy or acceptable to share the daemon/local registry with the cluster. You can see an example https://carvel.dev/kbld/docs/v0.36.0/building/#pushing-images of how to push images


Unable to apply patch to AC core files - patch failed

Hey all,
After the recent change in the code, I was pulling the most recent core updates as well as the recent update for lfg-solo.
Unfortunately now I‘m unable to apply the patch anymore after the recent updates.
I pulled the core and the solo-lfg files this morning
From https://github.com/azerothcore/azerothcore-wotlk

branch                master     -> FETCH_HEAD
1c43e6ac6..e7743fbeb  master     -> origin/master
Updating 1c43e6ac6..e7743fbeb

From https://github.com/azerothcore/mod-solo-lfg

branch            master     -> FETCH_HEAD
307d9a7..af1365f  master     -> origin/master
Updating 307d9a7..af1365f

Error:
azerothcore-wotlk % git apply modules/mod-solo-lfg/lfg-solo.patch
error: patch failed: src/server/game/DungeonFinding/LFGMgr.h:532
error: src/server/game/DungeonFinding/LFGMgr.h: patch does not apply
error: patch failed: src/server/game/DungeonFinding/LFGQueue.cpp:285
error: src/server/game/DungeonFinding/LFGQueue.cpp: patch does not apply

Did I do something wrong or is the patch not working as intended?

Apologies on my end.
It seemed like the both mentioned files LFGMgr.h and LFGQueue.cpp had been outdated. This caused the issue to occur. I have recreated the files from the master branch on the Core and the patch applied properly now. Closing this as WAI.


Peer to peer review

Overall, your project is impressive and well-implemented 💯 . You have followed the design guidelines effectively and have created a solid foundation. However, I have identified a couple of minor issues that can be addressed to improve the overall user experience.

Broken Logo in README:
The logo displayed in the README file appears to be broken. This can negatively impact the visual presentation of your project and may confuse users. I recommend fixing the issue by re-uploading the logo or updating the image source URL.

Remove "Add a link to your deployed project":
You have already deployed the project successfully, and it is evident from the provided documentation. Therefore, there is no need to include the instruction to "Add a link to your deployed project" in the README. Removing this instruction will avoid confusion and make the documentation more concise and precise.

Aside from these minor issues, I am thoroughly impressed with your work 🥇 . The project demonstrates strong coding practices, adheres to the design guidelines, and functions as intended. Keep up the great work and continue building upon this solid foundation.

Congratulations on the excellent design work! You've done a great job, and I want to commend you on your accomplishments. 🍾
Review Highlights 🎯
👍 The design looks fantastic.
👍 No linter errors, indicating good code quality.
👍 Descriptive README, providing helpful information.
However, I agree with my colleague's suggestion that you could make a few changes to enhance the professionalism of your README.
Keep up the great work, and I'm confident that with these improvements, your project will shine even more!


Use the core-security account for SecurityHub and GuardDuty main reporting

We should centrally manage SecurityHub and GuardDuty findings in the core-security account.

Most of this has moved to be part of the wider MOJ effort to centralise GuardDuty for all members of the AWS Organization.
We should import filtered findings from that source (for Modernisation Platform member accounts only) into an ELK stack or otherwise for our team.

I'm going to close this one as we handle this through the organisation-security account.


No module named 'diffusers.pipelines.stable_diffusion.convert_from_ckpt'

I run SHARK from source on Windows 11. It was running fine a few weeks ago, it doesn't launch anymore after I pulled the latest changes:
C:\git\SHARK> .\setup_venv.ps1
Python version found is
Python 3.10.9
Installing Build Dependencies

...

Building SHARK...
Looking in links: https://llvm.github.io/torch-mlir/package-index/, https://nod-ai.github.io/SHARK-Runtime/pip-release-links.html
Obtaining file:///C:/git/SHARK
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... done
  Preparing editable metadata (pyproject.toml) ... done
Requirement already satisfied: numpy in c:\git\shark\shark.venv\lib\site-packages (from nodai-SHARK==0.0.5) (1.24.1)
Requirement already satisfied: PyYAML in c:\git\shark\shark.venv\lib\site-packages (from nodai-SHARK==0.0.5) (6.0)
Requirement already satisfied: torch-mlir>=20221021.633 in c:\git\shark\shark.venv\lib\site-packages (from nodai-SHARK==0.0.5) (20230111.715)
Requirement already satisfied: torch==2.0.0.dev20230106 in c:\git\shark\shark.venv\lib\site-packages (from torch-mlir>=20221021.633->nodai-SHARK==0.0.5) (2.0.0.dev20230106+cpu)
Requirement already satisfied: typing-extensions in c:\git\shark\shark.venv\lib\site-packages (from torch==2.0.0.dev20230106->torch-mlir>=20221021.633->nodai-SHARK==0.0.5) (4.4.0)
Requirement already satisfied: networkx in c:\git\shark\shark.venv\lib\site-packages (from torch==2.0.0.dev20230106->torch-mlir>=20221021.633->nodai-SHARK==0.0.5) (3.0)
Requirement already satisfied: sympy in c:\git\shark\shark.venv\lib\site-packages (from torch==2.0.0.dev20230106->torch-mlir>=20221021.633->nodai-SHARK==0.0.5) (1.11.1)
Requirement already satisfied: mpmath>=0.19 in c:\git\shark\shark.venv\lib\site-packages (from sympy->torch==2.0.0.dev20230106->torch-mlir>=20221021.633->nodai-SHARK==0.0.5) (1.2.1)
Building wheels for collected packages: nodai-SHARK
  Building editable for nodai-SHARK (pyproject.toml) ... done
  Created wheel for nodai-SHARK: filename=nodai_SHARK-0.0.5-0.editable-py3-none-any.whl size=12206 sha256=4b2640a6852022cd31270637ab0141a75b861d3345b981c65b21bbc1091616b6
  Stored in directory: C:\Users\vippy\AppData\Local\Temp\pip-ephem-wheel-cache-5j_o67hy\wheels\a5\3a\86\f8fbd3499b15eec74030ba8702e3e48d40a450029bc5af815a
Successfully built nodai-SHARK
Installing collected packages: nodai-SHARK
  Attempting uninstall: nodai-SHARK
    Found existing installation: nodai-SHARK 0.0.5
    Uninstalling nodai-SHARK-0.0.5:
      Successfully uninstalled nodai-SHARK-0.0.5
Successfully installed nodai-SHARK-0.0.5
Build and installation completed successfully
Source your venv with ./shark.venv/Scripts/activate

(shark.venv) PS C:\git\SHARK> cd .\apps\stable_diffusion\web\
(shark.venv) PS C:\git\SHARK\apps\stable_diffusion\web> python .\index.py
shark_tank local cache is located at C:\Users\vippy\.local/shark_tank/ . You may change this by setting the --local_tank_cache= flag
Traceback (most recent call last):
  File "C:\git\SHARK\apps\stable_diffusion\web\index.py", line 13, in <module>
    from apps.stable_diffusion.src import args
  File "C:\git\SHARK\apps\stable_diffusion\src\__init__.py", line 1, in <module>
    from apps.stable_diffusion.src.utils import (
  File "C:\git\SHARK\apps\stable_diffusion\src\utils\__init__.py", line 14, in <module>
    from apps.stable_diffusion.src.utils.utils import (
  File "C:\git\SHARK\apps\stable_diffusion\src\utils\utils.py", line 18, in <module>
    from diffusers.pipelines.stable_diffusion.convert_from_ckpt import (
ModuleNotFoundError: No module named 'diffusers.pipelines.stable_diffusion.convert_from_ckpt'

Found out the issue: my old environment had diffusers 0.11.1 but SHARK requires 0.12.1 now.
Solved it by upragind the package with pip (pip install --upgrade diffusers / pip install --upgrade -r requirements.txt)


[B12] Eldritch Crab is in 2 places at once and frozen

When an eldritch crab gets on your head it instead freezes in place and continues to deal damage no matter where you are. trying to attack above you does nothing, however you can hit the frozen one. if a projectile or something else travels above you head then it will deal damage to the frozen one despite there being nothing visible above you

Head.... crabs....?
I love this mod even more now and I have not encountered that yet.


service_identity: 17.0.0 -> 18.1.0

Newer version of Twisted requires newer version of service_identity for reasonable certificate subject checking.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build pythonPackages.service-identity pythonPackages.twisted pythonPackages.scrapy python3Packages.service-identity python3Packages.twisted python3Packages.scrapy magic-wormhole


Trigger alarmo manually - (alarm_control_panel.alarm_trigger)

Hi... I Installed Alarmo, it is very nice and easy to use. thank
but I'm facing some issues in triggering the alarm manually by using:alarm_control_panel.alarm_trigger" command
after checking the documentation, I got that this option is not available in alarmo , please try to include this feature.
in case of any emergency, some peoples have to trigger the alarm manually (even though it is not armed )

Please see here:
https://github.com/nielsfaber/alarmo/issues/67
It is basically the same request.
If needed, some extra function can be discussed, but so I think the behavior you are looking for can be made already.

Please see here:
#67
It is basically the same request.
If needed, some extra function can be discussed, but so I think the behavior you are looking for can be made already.

i have already go through the always-on function but my request is I want to make one trigger button to trigger the alarm even throw alarm is off.
the situation where I'm going to use

when I got a camera notification from the home assistant I want to have one option to trigger the alarm
want to configure one Zigbee button, when that button is pressed alarm will be triggered

I hope u understand my request


WIP (TODO: came back to use bingo)🌱 (fix): configure ENVTEST binaries for IDE execution and project-specific setup

Installs ENVTEST binaries in the project’s ./bin/envtest directory for isolation.
Configures setup-envtest binary to be downloaded based on the controller-runtime release version to ensure compatibility with the project’s dependencies.
Updates suite_test.go to dynamically locate and set the binary assets directory for seamless IDE debugging.
Introduces getFirstFoundEnvTestBinaryDir to detect ENVTEST binaries in the project directory when running tests outside the Makefile context.

Motivation

Ease of IDE Debugging:

By setting the BinaryAssetsDirectory dynamically, contributors can debug tests in their preferred IDEs (e.g., GoLand, VSCode) without requiring additional environment configuration such as setting KUBEBUILDER_ASSETS.

Project-Specific Binaries:

Installing binaries inside the project avoids conflicts with other projects or system-wide installations, particularly useful for contributors with restricted environments (e.g., corporate laptops).

Consistency:

Using setup-envtest from the matching controller-runtime release avoids compatibility issues, such as those outlined in #2744 and #2646.

Simplified Contributor Onboarding:

New contributors often face a learning curve to:

Understand ENVTEST and its dependency on binaries.
Configure KUBEBUILDER_ASSETS manually.
Set up their IDE for debugging tests.

This setup minimizes friction and ensures tests can be run consistently across different environments.

While setting KUBEBUILDER_ASSETS is sufficient for experienced contributors, this change makes it easier for newcomers and supports debugging directly in IDEs without additional configuration.

Hi @m1kola,
Thank you for catching that—really good observation! :raised_hands:
Your comment highlights an additional motivation for this change: addressing scenarios like those outlined in kubernetes-sigs/controller-runtime#2744 and kubernetes-sigs/controller-runtime#2646.
The required changes have been addressed, and we no longer use bingo here as intended. Please feel free to review this one.

I like the integration in TestMain to make envtest work for IDE-based test execution. Could we put that piece in its own PR?

The goal of the PR never was to remove BINGO

Still - it is related as it changes how we manage our tool dependency. If we merge this - we will have two ways: we will still have bingo managing a bunch of tools and there will be go install managing evntest in Makefile installing it into a custom location. I would like us to be consistent with this the approach, if possible.
If there are issues with what we have today - let's address them. But first we need to understand these issues. That's why I invite you to write down your feedback in one place so we ca discuss it in a more structured way.

Hi @joelanford, @m1kola, @perdasilva, @bentito,
Apologies for the confusion earlier!
This PR is NOT about Bingo. The main goal is to make debugging ENVTEST-based tests in the IDE simpler and more straightforward.

I suspect that some team members might think it’s not possible to debug with Ginkgo because the tests in question are actually ENVTEST-based. This change addresses that scenario and clarifies the process.

I’ve addressed all comments, closed all as done or outdated to avoid confusion, reverted the BINGO changes, and kept the suggestions.
@M1kola, could you please revert your block?
Thanks in advance! 😊

Thank you @perdasilva and @m1kola
I am moving forward with this one
I think all suggestions and etc are addressed
However, we can always to push enhancements in a follow-up as well.


Native Compile Option for New Build System

I integrated recent CMake changes to native compilation.

I accepted the pull request and merged to the master branch


error when try to request using parameters

it say "Cannot invoke 'responseJSON' with an argument list of type '((_, _, _, _) -> Void)'" when i try to request using parameter
request(.GET, "http://api.mymemory.translated.net/get", parameters:parameters)
                .responseJSON { (_, _, JSON, _) -> Void in

                    let translatedText: String? = JSON?.valueForKeyPath("responseData.translatedText") as String?

                    if let translated = translatedText {
                        self.translatedTextLabel.text = translated
                    } else {
                        self.translatedTextLabel.text = "No translation available."
                    }

            }

@masbenx  try to run this code without 'responseJSON' part, I'm almost sure the problem lies in the typing of 'parameters'.

Yep, i too face the same issue,
Alamofire.request(.POST, someUrl, parameters: ["accessToken" : accessToken, "UserEmail" : gUserEmail], encoding:.JSON)
.responseJSON(){ (request, response, JSON, error) in
}
Is anything wrong in my parameter?

Alamofire has a passing test with essentially the same input. I suspect that the error returned is not actually related to the actual underlying problem.
For any further questions, please try asking for help on Stack Overflow with the "Alamofire" tag.

I'm seeing this too with nullable parameters, but NSNull() works fine.

I also getting this issue.
Please help

I solve this marking the var like not nil (!)
let params = ["key":value!]
Alamofire.request(.GET, url, parameters: params)
.response { request, response, data, error in ...

same problem. framework is not good!!!


Dialog component not visible in IE11 after other tab open

Hi everybody.
I am using the Dialog component in IE11 browser. When the Dialog is visible, I switch to another tab and then switch back. The Dialog component becomes invisible (although it is still in the DOM tree and reacts to some events, for example, tooltips are shown). The dialog appears if you manually resize the browser window or open the developer toolbar. There is no such problem in Chrome.
Current Behavior 😯
The dialog component is not visible after switching to another IE11 tab and back
Expected Behavior 🤔
The dialog component is visible after switching to another IE11 tab and back
Steps to Reproduce 🕹
Steps:

Add Dialog component with prop opened == true
Start the app and make sure the Dialogue is open
Switch to other IE11 tab and back
Dialog is no longer visible

Your Environment 🌎

System:
OS: Windows 10 10.0.18363
Binaries:
Node: 16.1.0 - C:\MyProgramFiles\NodeJS\node.EXE
Yarn: Not Found
npm: 7.11.2 - C:\MyProgramFiles\NodeJS\npm.CMD
Browsers:
Chrome: 90.0.4430.212
IE11: 11.900.18362.0
npmPackages:
@emotion/styled:  10.0.27
@material-ui/core: ^4.11.3 => 4.11.3
@material-ui/icons: ^4.11.2 => 4.11.2
@material-ui/lab: ^4.0.0-alpha.57 => 4.0.0-alpha.57
@material-ui/pickers: ^3.3.10 => 3.3.10
@material-ui/styles:  4.11.3
@material-ui/system:  4.11.3
@material-ui/types:  5.1.0
@material-ui/utils:  4.11.2
@types/react: ^17.0.1 => 17.0.1
react: ^17.0.1 => 17.0.1
react-dom: ^17.0.1 => 17.0.1
typescript: ^4.1.3 => 4.1.3
tsconfig:
{
"compilerOptions": {
"target": "es5",
"lib": [
"dom",
"dom.iterable",
"esnext"
],
"allowJs": true,
"skipLibCheck": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"noFallthroughCasesInSwitch": true,
"module": "esnext",
"moduleResolution": "node",
"resolveJsonModule": true,
"rootDir": "./src",
"isolatedModules": true,
"noEmit": true,
"jsx": "react-jsx"
},
"include": [
"./src"
]
}

Closing as we don't aim to work on IE 11 see https://next.material-ui.com/getting-started/supported-platforms/#ie-11

@ksardas2008 I had a quick look, I couldn't reproduce the issue on https://next.material-ui.com/components/dialogs/. If you want to increase the likeliness of somebody working on the issue, I would recommend adding a reproduction. Unfortunately, codesandbox doesn't run on IE 11.


Expand if-expressions with leading and trailing comments

Summary
Black appears to expand if-expressions when they contain leading or trailing own-line comments, if they're the only expression in a set of brackets (parenthesized, or the only element in a list or tuple) -- see the playground.
This PR applies the same logic to our own if-expression formatting.
Closes https://github.com/astral-sh/ruff/issues/7066.
No change in similarity:

project
similarity index
total files
changed files

cpython
0.76083
1789
1632

django
0.99957
2760
67

transformers
0.99927
2587
468

twine
0.99982
33
1

typeshed
0.99978
3496
2173

warehouse
0.99818
648
24

zulip
0.99942
1437
32

This isn't quite right, we're now expanding in a few places that Black isn't. Here's the diff of diffs vs. main on Django:
diff --git a/django/core/management/commands/inspectdb.py b/django/core/management/commands/inspectdb.py
index 50d3226d67..5136842941 100644
--- a/django/core/management/commands/inspectdb.py
+++ b/django/core/management/commands/inspectdb.py
@@ -219,7 +219,9 @@ class Command(BaseCommand):
                     field_desc = "%s = %s%s" % (
                         att_name,
                         # Custom fields will have a dotted path
-                        "" if "." in field_type else "models.",
+                        ""
+                        if "." in field_type
+                        else "models.",
                         field_type,
                     )
                     if field_type.startswith(("ForeignKey(", "OneToOneField(")):
diff --git a/django/db/backends/postgresql/introspection.py b/django/db/backends/postgresql/introspection.py
index 97a26d908d..f1796c06d9 100644
--- a/django/db/backends/postgresql/introspection.py
+++ b/django/db/backends/postgresql/introspection.py
@@ -117,7 +117,9 @@ class DatabaseIntrospection(BaseDatabaseIntrospection):
                 line.name,
                 line.type_code,
                 # display_size is always None on psycopg2.
-                line.internal_size if line.display_size is None else line.display_size,
+                line.internal_size
+                if line.display_size is None
+                else line.display_size,
                 line.internal_size,
                 line.precision,
                 line.scale,
diff --git a/tests/postgres_tests/migrations/0001_setup_extensions.py b/tests/postgres_tests/migrations/0001_setup_extensions.py
index 8045610aef..d98a40b927 100644
--- a/tests/postgres_tests/migrations/0001_setup_extensions.py
+++ b/tests/postgres_tests/migrations/0001_setup_extensions.py
@@ -40,7 +40,9 @@ class Migration(migrations.Migration):
         # dash in its name.
         CreateExtension("uuid-ossp"),
         # CryptoExtension is required for RandomUUID() on PostgreSQL < 13.
-        CryptoExtension() if needs_crypto_extension else mock.Mock(),
+        CryptoExtension()
+        if needs_crypto_extension
+        else mock.Mock(),
         HStoreExtension(),
         TrigramExtension(),
         UnaccentExtension(),

It appears that this only applies when the if-exp is the only expression within the brackets (i.e., it's a single argument, or a single element in a list literal).
Black's preview style seems more consistent in that it always expands them, but it also parenthesizes whenever they expand (even if it's, e.g., a single function argument).

This probably needs a decision then as to whether we want to implement the preview style (always expand, as we are here, but also parenthesize) or the non-preview style (only expand like this if there are no other elements in the brackets).

Alright, I went with Black's non-preview style.

Here's the change that modified Black's handling in preview mode, to parenthesize these more aggressively: https://github.com/psf/black/pull/2278.

Yeah, you’re probably right and I don’t feel strongly, I just biased towards fixing a deviation. We can close.
Should we implement Black’s preview style to always parenthesize these when split? It seems like a significant improvement for default function parameters. (Can consider separately.)

Should we implement Black’s preview style to always parenthesize these when split? It seems like a significant improvement for default function parameters. (Can consider separately.)

Preview style formatting is tracked here https://github.com/astral-sh/ruff/issues/6935 and should generally be gated behind a preview flag.


Create the Code of Conduct

Discuss and adopt a code of conduct to define Sumé community standards.
We can describe on the website and link with every Sumé application.

I guess that we need some examples or at least starters, so I'm dropping some interesting links here:

https://miloslav.website/code-of-conduct/
https://opensource.guide/code-of-conduct/
https://i-sight.com/resources/18-of-the-best-code-of-conduct-examples/


Pass remounts => false to mount resources

As identified in #10, a refresh of a volume will attempt to remount the
volume but the FUSE client does not support this.  Set
remounts to false on the mount resource.
This means that any resource changes will cause the mount to be
unmounted and then mounted.

:+1:

:+1:


Text To Speech is missing

Doesn't port over "Text to speech" feature that exist in the holotoolkit. I don't see an example or tutorial how to implement this in this new toolkit. In the previous holotoolkit for Unity for example this existed.

Hi @nonlin . First of all, I'm so sorry for the delay replying here. We don't actively use this repo for development and notifications were not configured well so we just noticed your post. Did you manage to get a "Text to speech" solution working in UE?

Hi @nonlin . First of all, I'm so sorry for the delay replying here. We don't actively use this repo for development and notifications were not configured well so we just noticed your post. Did you manage to get a "Text to speech" solution working in UE?

Closing this as there has been no reply in a while. Please, do feel free to reopen.


Fix and test case for supporting members with dollar signs

Changes
Fixes #2177 by not escaping at the right time.

A new test case with members with dollar signs in the name has been added
Renamed sanitise to noEscape to make more sense based on the existing code logic

How to test this PR
Examples:

Run the test cases
Try creating and editing a member with a dollar sign

Checklist

[x] have tested my change
[ ] have created one or more test cases
[ ] updated relevant documentation
[ ] Remove any/all console.logs I added
[ ] have added myself to the contributors' list in CONTRIBUTING.md

It seems like there might be some contention between where the encoding actually happens. I am passing true to qualifyPath so it doesn't escape:
https://github.com/codefori/vscode-ibmi/blob/fix/dollars_in_names/src/api/IBMiContent.ts#L152
As I am expecting it to be escaped in the runCommand function: https://github.com/codefori/vscode-ibmi/blob/fix/dollars_in_names/src/api/CompileTools.ts#L681

@sebjulliand Not sure why I did that. Re-requested your review.


fixed bug: added fits to reffile basename when checking if file exits

@arminrest, what do you think about this?

Oops sorry, wrong window.


CI_JOB_TOKEN interferes with LAB_CORE_TOKEN

I am trying to use lab in the Gitlab CI but wanted to use a different token then the one found in CI_JOB_TOKEN.
So I set both LAB_CORE_HOST and LAB_CORE_TOKEN.
export LAB_CORE_HOST="https://gitlab.com"
export LAB_CORE_TOKEN="praritrocks!"

And attempted the following:
$ lab
Config saved to /root/.config/lab/lab.toml
<snip>
$ lab --debug mr list
2021/12/08 01:17:33 DEBUG: client.go:549: performing request
2021/12/08 01:17:33 DEBUG: 	method = GET
2021/12/08 01:17:34 ERROR: mr_list.go:67: GET https://gitlab.com/api/v4/projects/super/secret/project: 401 {message: 401 Unauthorized}

But when I did:
$ unset CI_JOB_TOKEN
$ lab mr list
!15 Draft: Testing lab

Yes, that indeed happens: when using lab within a CI the variables CI_JOB_TOKEN, CI_PROJECT_URL, CI_PROJECT_PATH and GITLAB_USER_LOGIN takes precedence over the LAB_* ones.
You can check our .gitlab-ci.yml file and see that we actually assign the real value to the LAB_* first, then assign the CI_* vars based on the LAB_* that we just set.

Yes, that indeed happens: when using lab within a CI the variables CI_JOB_TOKEN, CI_PROJECT_URL, CI_PROJECT_PATH and GITLAB_USER_LOGIN takes precedence over the LAB_* ones.

Okay. Well the the project README lists them in order and 1 is LAB_CORE_* which would seem to imply it has precedence over the others is how I read it.

You can check our .gitlab-ci.yml file and see that we actually assign the real value to the LAB_* first, then assign the CI_* vars based on the LAB_* that we just set.

Looking at https://github.com/zaquestion/lab/blob/e1100d31c32ecc9cdf9b469162dbbe4cc46eb9b5/.gitlab-ci.yml#L56-L58
Seems strange to me as someone unfamiliar with the project why CI_JOB_TOKEN gets set to CI_PROJECT_URL which was set to LAB_CORE_HOST which was set to https://gitlab.com if I am reading that correctly.
I'll be honest that confuses my little brain 😊

Ah! Farther down it makes more sense:
https://github.com/zaquestion/lab/blob/e1100d31c32ecc9cdf9b469162dbbe4cc46eb9b5/.gitlab-ci.yml#L68-L78

@bmeneg I created a PR with a documentation update #768 to close this issue.

You can check our .gitlab-ci.yml file and see that we actually assign the real value to the LAB_* first, then assign the CI_* vars based on the LAB_* that we just set.

Looking at
https://github.com/zaquestion/lab/blob/e1100d31c32ecc9cdf9b469162dbbe4cc46eb9b5/.gitlab-ci.yml#L56-L58
Seems strange to me as someone unfamiliar with the project why CI_JOB_TOKEN gets set to CI_PROJECT_URL which was set to LAB_CORE_HOST which was set to https://gitlab.com if I am reading that correctly.
I'll be honest that confuses my little brain blush

Ohh, it seems broken indeed! lol
But the exports solves it. But yeah, should be fixed I think. (and even removed if not being really used. I'll check it further).


Add RHOS support

Signed-off-by: Aswin Suryanarayanan<EMAIL_ADDRESS>

/assign @vthapar

@aswinsuryan Updated version with changes for dedicated gw node https://github.com/stolostron/submariner-addon/pull/298


device gufunc scheduling not handling output argument properly

For a gufunc foo(arg0, arg1, ret0) with this signature "(m,n),(k)->()", and the call with foo(a, b, out), there are two bugs:

out is incorrectly categorized as input shapes during scheduling;
the above issue can be workaround by using explicit out arg, but the scheduling is mishandling the scalar output argument when the input in a 1d-array.

Both bugs can be workaround by not specifying the output argument.

Is this still a bug?

Yes, still a bug


Ambience

-Added mall_ambience
-Added node script

Test: https://drive.google.com/file/d/1amHOIdPNW2HQkTrJDa37akBoKviQ74hq/view?usp=sharing


Make Loom and KEDA tests on demand tests

These 2 jobs don't need to run every time, devs can trigger them when it's actually needed.

/cc @Cali0707 @debasishbsws

/lgtm
/hold for the reviewers called out

/unhold


How to get the current total number of requests？

From where? Inside the process? Outside the process? Performance counters?
What do you intend to do with the information?


Set final version of path/slug.

Coverage remained the same at 100.0% when pulling ffb68e2c0d39669df6f6395038fc1c481414fb86 on paths into e5fd73308c6eda9667a13d0306406ec9b3041e5b on master.

Coverage remained the same at 100.0% when pulling 771498ebe1597cda8a1239193e54ba163b1f0e8b on paths into e5fd73308c6eda9667a13d0306406ec9b3041e5b on master.

Coverage remained the same at 100.0% when pulling a8546e6f923ef7490d99f7a1e3648e51080cfdf8 on paths into e5fd73308c6eda9667a13d0306406ec9b3041e5b on master.

Coverage remained the same at 100.0% when pulling 76dda9e44b00bbcb577540a2b142b14b0462703a on paths into e5fd73308c6eda9667a13d0306406ec9b3041e5b on master.


PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

I'm using CodeFormatter in sublime text 3, when I try press control+option+F to format the php code, it shows up the following error:
CodeFormatter

Format error:
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 6692
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 6692
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 7613
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 7613
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 7730
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 7730
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 7770
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 7770
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 7778
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 7778
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 7790
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 7790
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 7795
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 7795
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 8530
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 8530
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 9923
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 9923
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 9926
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 9926
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 11153
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 11153
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 12425
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 12425
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 12445
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 12445
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 12469
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 12469
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 12987
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 12987
PHP Deprecated:  The each() function is deprecated. This message will be suppressed on further calls in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 5386
Deprecated: The each() function is deprecated. This message will be suppressed on further calls in phar:///Users/bruce/Library/Application Support/Sublime Text 3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/phpf.phar/phpf.php on line 5386

OS: macOS Mojave 10.14.1 (18B75)
PHP:
PHP 7.3.0 (cli) (built: Jan  3 2019 10:08:00) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.0-dev, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.0, Copyright (c) 1999-2018, by Zend Technologies

Sublime: v3.1.1 build 3176

Yes, The formatter works for other languages but failing for PHP.

Any fixes for this?


v2.25.1 - Can't resolve './locale'

Describe the bug
When I build my React application, the build fails with an error.
./node_modules/moment/src/lib/locale/locales.js
Module not found: Can't resolve './locale' in '/Users/raravi/Programming/gitprojects/sudoku/node_modules/moment/src/lib/locale'

To Reproduce
Steps to reproduce the behavior:

Add moment.js to a React application.
Run npm start in the terminal
Should see error pasted above.

Expected behavior
The React application should build without any errors from moment.
Desktop (please complete the following information):

OS: MacOS 10.15.4
Browser Brave 1.8.86

Moment-specific environment

The time zone setting of the machine the code is running on
The time and date at which the code was run
Other libraries in use (TypeScript, Immutable.js, etc)

Please run the following code in your environment and include the output:
console.log((new Date()).toString())
Wed May 06 2020 03:57:24 GMT+0200 (Central European Summer Time)
console.log((new Date()).toLocaleString())
06/05/2020, 03:57:24
console.log((new Date()).getTimezoneOffset())
-120
console.log(navigator.userAgent)
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.129 Safari/537.36
console.log(moment.version)
2.25.1

We are having very similar problem since yesterday.  Nothing changed on our end but the release of moment-2.25.2. We know see warnings like
WARNING in ./node_modules/moment/src/lib/locale/locales.js
Module not found: Error: Can't resolve './locale' in '/app/node_modules/moment/src/lib/locale'
 @ ./node_modules/moment/src/lib/locale/locales.js
 @ ./node_modules/moment/src/lib/locale/locale.js
 @ ./node_modules/moment/src/moment.js

The real problem is our UI generates a lot of errors

I come back to version 2.24.0 to fix this error

@Jerome2606 I've done the same, for now.

I have the same issue with my vue app. Also moved back to. 2.24.x

I used moment @ 2.25.3 without warning.

I'm using NextJS and I had to downgrade to 2.24.0 because I was not able to load other locales.
I tried almost everything with the require("/moment/locale/xxx") and the webpack plugin ContextReplacementPlugin from this example. I don't see any errors but it just does not load with this code :
moment.locale(lang);
momentTZ.updateLocale(lang, moment.localeData()._config);
momentTZ.locale(lang);

Seems to work well in 2.25.3

Closing this issue, it's fixed in v2.25.3 !


API Properties

Codecov Report
Patch coverage has no change and project coverage change: -1.62 :warning:

Comparison is base (7c17831) 32.41% compared to head (7793f3d) 30.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1226      +/-   ##
==========================================
- Coverage   32.41%   30.79%   -1.62%
==========================================
  Files         376       80     -296
  Lines       43800    12154   -31646
  Branches    14200     1545   -12655
==========================================
- Hits        14198     3743   -10455
+ Misses      29352     8286   -21066
+ Partials      250      125     -125

Flag
Coverage Δ

adapter
23.89% <ø> (-0.19%)
:arrow_down:

admin-domain-service
54.61% <ø> (+2.20%)
:arrow_up:

backoffice-domain-service
57.51% <ø> (ø)

devportal-domain-service
?

idp-domain-service
?

runtime-domain-service
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 305 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[chip-demo] Print commit ID in builds

Problem
We are building and testing on several branches with several dev boards, it will be more convenient if we can identify which image is running on the board.
Summary of Changes
Write a python script (because gn uses it when using exec_script) to get the commit id and introduced a COMMIT_ID macro for commit id.
chip-tool will print commit id on start, and nrf examples will write commit id to jlink log output on boot.

@erjiaqing are you still working on this?

@erjiaqing are you still working on this?

Since I don't have any idea to printing commit ID without hacks and CHIP is not stable yet, close it now.


Some classes need to be introduced when the client SDK uses ACL

When the client SDK is introduced, the SessionCredentials and AclClientRPCHook class is required. Since SessionCredentials and AclClientRPCHook class is in the common directory of the rocketmq-acl module, the rocketmq-acl module needs to be introduced again.

May I be allowed to move SessionCredentials and AclClientRPCHook class to rocketmq-common module?
Or add rocketmq-acl module in rocketmq-client pom file.

Why not introduce rocketmq-acl module and rocketmq-client module together in your project?

Why not introduce rocketmq-acl module and rocketmq-client module together in your project?

ACL is more commonly used in the rocketmq-client module, so it is more convenient to put these two classes into the rocketmq-common module or introduce the rocketmq-client module to the rocketmq-client module.


DX: MethodChainingIndentationFixer - remove unneccesary loop

Fixes #4363

Thank you @Billz95.

very nice finding @Billz95
did you use some tool to look for this unneeded loop, or had to do it manually ?

very nice finding @Billz95
did you use some tool to look for this unneeded loop, or had to do it manually ?

thanks :D
I first realise this issue when profiling the time used by each fixer by modifying the Runner.
Then I manually profiled the top time consuming linters. And that leads me to this loop.


Proposal: FLIGHT MODES

Hello everybody,
I'm thinking how to explain the modes in the users manual with icon graphics since last week. And I try find a way to explain it to a person that does not have any knowledge on drones. And believe me I cannot figure it out how to do it. I think the system will become monster with thousand of modes and sub modes and sub modes and yes for me that is very good but for the novice it is not.
There is no Acro mode for fixed wing in the users manual. Actually Manual in FW = Stabilized flight, while we have to switch to Acro in order to have real Manual Flight.
Her is what it is now:
MANUAL
Fixed wing aircraft/ rovers / boats: The pilot's control inputs are passed directly to the output mixer.
Multirotors:
ACRO: The pilot's inputs are passed as roll, pitch, and yaw rate commands to the autopilot. This allows the multirotor to become completely inverted. Throttle is passed directly to the output mixer
RATTITUDE The pilot's inputs are passed as roll, pitch, and yaw rate commands to the autopilot if they are greater than the mode's threshold. If not the inputs are passed as roll and pitch angle commands and a yaw rate command. Throttle is passed directly to the output mixer.
ANGLE The pilot's inputs are passed as roll and pitch angle commands and a yaw rate command. Throttle is passed directly to the output mixer.
Which is not exactly what it is.
It is very perplexing and always overwhelming for the novice. So now my question is what is the default mode in Manual for the multicopters? If I don't program acro switch neither rat switch what is the mode i'm in? In FW I'm in Manual Stabilized flight if I don't have Acro switch.
I think that the current system of naming the modes is very contradictory thus hard to understand.
What is Assisted Flight? is it manual or auto mode?? In terms of user experience Assisted flight is Auto mode as well, because the computer automatically does things for me.
So when you have to understand the difference between Assisted mode and Auto mode you get confused because you perceive both as Auto modes, and they are in reality auto modes.
There should be simpler system for the modes convention and naming and explanation. I don't say change in the functioning and features but how they are called explained and experienced. Ease of use = larger user base. You can make a very complex system work in two ways, simple way and complex way depending on the user needs and experience.
So here is a simpler way of doing it:
Manual (without sub-mode switch, ie without Acro,Rat, Angle switch)
For all vehicles the default function should be Manual Stabalized. This way Manual = Stabalized and all sub-modes of Manual are not mandatory.
Assisted
In Assisted the default should be POSCTL by default. I never ever needed ALTCTL never used it nor i needed it. So ALTCTL can be invoked by missing GPS or other pos data, or if I have a sub-mode - posctl switch and I mandatory switch it to ALTCTL.
Mission
It is pretty explanatory. Just start mission execution.
AUTO_LOITER - should become just LOITER. It is my first line of defense, it is my yellow distress call. Especially if I'm beginner. I use it if I have to pause and take a breath in a situation, and then continue on. It is actually a PUSE button. So It should work in all modes! even in the Acro modes. (You can fly acro and still have GPS lock or pos data.)
AUTO_RTL should become RTL. It is my distress red call so you cannot make it as a sub-mode of Auto!!! Usually when i hit RTL I'm desperate... something is happening. It should work from every mode. Now it works from the assisted modes if GPS lock and from Auto mode and why is it then in Auto when it works from both Auto and Assisted?
That's it plain and simple. We have Mode switch with 3 modes Man / Ass / Miss, Manual switch, Assisted switch, Loiter Switch and RTL switch if I'm advanced.
If I'm novice I set Mode switch with 3 modes Man / Ass / Miss. And I can set up either RTL and Loiter switches or make an Emergency 3 pos switch with LOITER in the middle position as a first line of defense and RTL in on position as a second line of defense.
This way as a novice I will have just two switches. And with this two switches with the default sub-modes I gave above I will have pretty much all that I need from my drone being FW, Multi or VTOL. For the VTOL we have just Transition switch.
And also the modes should be consistent throughout the vehicles.
Now for the VTOL they are not!!!
The main success of DJI is not because of their machines but because of their simple 3 MODES for flight and you notice it the moment you get the white minimalist RC or program their Naza or A2.
GPS, Manual = Stabalized, , RTH. You need nothing more in 80-90% of the situations.
See their default mode is the GPS one! We wait a little for the GPS lock before flight, but it is not a problem neither for work neither for pleasure flying. If you have an urgent need to take off without GPS or you are in closed space, then you switch to Manual.
Of course Loiter is mandatory for the Airplanes. But for Multicopters you don't even need Loiter because POSCTL is the same as loiter in terms of dynamics. The only difference is the gimbals does not work in Loiter vs POSCTL.
I wrote this just to provoke discussion. I will start working on Flight Mode explanation in the Users Manual and will show you what I have in mind.

With the development of new features in the sub-modes it will be very easy to set the controls. Otherwise with time you have to create more and more and more switches and assigning them... crazy things for the novice. Even to some experienced people comming from other platforms.
So here is the convention.
Mode switch 3 pos Manual / Assisted / Mission
Manual Switch 2-3-4-5 postition you select how many positions and assign a sub-mode to it. You decide which ones. If there are 10 modes in manual no problem you choose the ones you want to use. The aasignment is done very very simple and elegant in DJI. We can borrow the idea. Here how it looks:

With a drop down you can assign a function to a segment of the scale. BTW you can see in reality how the slider is moving and where in real time. Very easy to trim and set.
Assisted Switch 2-3-4-5 position the same logic. for now just POSCTL and ALTCTL but in the future there might be more.
Mission Switch 2-3-4-5 the same logic.
Emergency switch - 3 pos No emergency / Loiter / RTL
Transition switch for the VTOL.
For the novice use just the Emergency and Mode switches. For the advanced users you can have a countless possibilities of combinations with just 5 switches, in an easy manageable WYSWYG way.

Much nicer visual way to do 6 position simple mode flight mode setup. I like it.

On Mar 9, 2016, at 5:52 PM, tubeme<EMAIL_ADDRESS>wrote:
With the development of new features in the sub-modes it will be very easy to set the controls. Otherwise with time you have to create more and more and more switches and assigning them... crazy things for the novice. Even to some experienced people comming from other platforms.
So here is the convention.
Mode switch 3 pos Manual / Assisted / Mission
Manual Switch 2-3-4-5 postition you select how many positions and assign a sub-mode to it. You decide which ones. If there are 10 modes in manual no problem you choose the ones you want to use. The aasignment is done very very simple and elegant in DJI. We can borrow the idea. Here how it looks:
https://cloud.githubusercontent.com/assets/12617619/13656782/abd32110-e672-11e5-9e0a-55242c6e6512.png
With a drop down you can assign a function to a segment of the scale. BTW you can see in reality how the slider is moving and where in real time. Very easy to trim and set.
Assisted Switch 2-3-4-5 position the same logic. for now just POSCTL and ALTCTL but in the future there might be more.
Mission Switch 2-3-4-5 the same logic.
Emergency switch - 3 pos No emergency / Loiter / RTL
Transition switch for the VTOL.
For the novice use just the Emergency and Mode switches. For the advanced users you can have a countless possibilities of combinations with just 5 switches, in an easy manageable WYSWYG way.
—
Reply to this email directly or view it on GitHub https://github.com/PX4/Firmware/issues/3967#issuecomment-194615837.

Sorry for the mess. I first posted this in https://github.com/PX4/Devguide/issues/67
Then I created this issue.
I made mistake in the modes explanations for the DJI which @GervaisK corrected in this post:
https://github.com/PX4/Devguide/issues/67
Another provoking question.
Why I'm not able to arm in Acro or Assited mode?

@tubeme I used to fly a NAZA F450 prior to move to PX4 (on a Tarot 680), and I used to land and takeoff in any mode offered by the FC (including GPS and Alt). Taking off in Stab Mode is somewhat ok though I would prefer to be able to take off in PosCtl as well. Landing on the other hand is a bit shaky in Stabilized mode and I would also prefer to be able and land in PosCtl Mode.
Despite in Auto Mission or RTL Mode take off an landing is possible, so why denying it to PosCtl?
With the current state landing in PosCtl is a dangerous thing to do, as I documented here: #3954

Thx for correction. As I already wrote @ #67, **AltCtl. is a mandatory FM **for me .
The DJI FM selection shown above is not actually the latest (a bit better at A2 assistant) but gets really confusing when its coming to the IOC modes (Simple and super simple @ APM stack)
Secondly DJI is calling it Failsafe, because there is a selection between Land and RTH (RTL) at another page of the assistant.
So I like the way its done now at latest master. Really superior to DJI, since this leaves the full freedom to choose the order (Switch Position) . DJI doesn´t offer this. (only for AUX @ A2)
I´m only missing LAND as a choosable fixed Failsafe option, because I know a lot of situations where I don´t need a climb (sts. dangerous) or GPS reception is very bad, just want to make sure that it doesn´t switch to RTL (when GPS Glitch is over).
And I´m missing LAND as an AUX function, where I´m able to terminate my testflight right away.  I even don't mention it here. It is a failure in terms of features.
In the convention I proposed we can have many sub-modes in the Mission mode. They could be Land, Take off, Follow me, Circle facing a spot or Orbit, Panoramic Selfie etc. We could then decide which ones we like to have on the Mission dial.

I would not like to loose flexibility on the PWM Range used. Your Proposal looks to me to work on fixed PWM Ranges. If one User only has limited amount of RC Channels mixing different switches to one Channel is one option. This usually causes problems to 100% reach certain values. To be honest I am personally very happy with the flight mode Assignement as it was up to QGC 2.9.4. Your Proposal would limit the amount of configurable Flightmodes to 6 per Channel?

I would not expose PWM range setting to the user (although it would be needed internally). I would just have them specify what type of switch they have: 2 position, 3 position, 6 position.
I’ve been thinking about this. I’ll send a picture from QGC sometime today folks can look at.

On Mar 10, 2016, at 7:55 AM, tops4u<EMAIL_ADDRESS>wrote:
I would not like to loose flexibility on the PWM Range used. Your Proposal looks to me to work on fixed PWM Ranges. If one User only has limited amount of RC Channels mixing different switches to one Channel is one option. This usually causes problems to 100% reach certain values. To be honest I am personally very happy with the flight mode Assignement as it was up to QGC 2.9.4. Your Proposal would limit the amount of configurable Flightmodes to 6 per Channel?
—
Reply to this email directly or view it on GitHub https://github.com/PX4/Firmware/issues/3967#issuecomment-194918963.

We are not loosing range. But we should take in mind that there are 2 conventions for the mid point. one is 1500us and the other one is 1520us which means that the scaling in both types of receivers is a little off.

I would not expose PWM range setting to the user
This is , at least in an advanced view, mandatory.

If the PWM is too close to the next mode, the user doesn´t even notice and you can´t help in a forum if s. happens.
Once everybody starts to use a one for all DJI RC gear´w/o the possibility of adjusting PWM , it doesnt matter anymore...but for now.

The live display on channel info should show that the switch position is too close to the edge of the range.

On Mar 10, 2016, at 10:21 AM, GervaisK<EMAIL_ADDRESS>wrote:
I would not expose PWM range setting to the user
This is , at least in an advanced view, mandatory.
If the PWM is too close to the next mode, the user doesn´t even notice and you can´t help in a forum if s. happens.
Once everybody starts to use a one for all DJI RC gear´w/o the possibility of adjusting PWM , it doesnt matter anymore...but for now.
—
Reply to this email directly or view it on GitHub https://github.com/PX4/Firmware/issues/3967#issuecomment-194987674.

Actually I never had a DJI RC I was just giving an example with it. This slider is from NAZA and the only thing that you have to do in order to fix some misalignment is push a little the output scaling. This can be done easily with probably all RCs. And is straight forward procedure that you learn in ABC of drones. For the guys that buy let say a RTF product based on PX4 and with RC, everything will be preset for them in the factory. But once they have the knowledge and ability to make their own settigns and upgrade their RC it will be pretty easy.
I started writing this issue, because I want to explain the whole thing for Novice and for Experts. And when you start explaining things you see some patterns that are not logical for explanation.
I already introduced about 10 people to PX4 and every time I do it, I see their faces when I show them the 5 switches  (i never even set acro switch for them) with probably 3-4 combinations they have to learn in order to fly their machine.

With the risk of becoming annoying I will say the last thing I have in mind about the Modes.
I come from the world of marketing communication and positioning. I did projects for some popular brands like Loreal, Nestle, Absolut. So I come from the world of Marketing, Sales and Profits. That is the way I perceive the world around me.
In the marketing positioning game, there is a very important principle if you want to establish your positioning ( or called dimension sometimes) for a certain product or a brand. It is called the Ladder principle. Which means that in order to ingest some NEW information to somebody's brain, you have to use the knowledge they have already.
Also everything is communication not only your brand! The brand name is very important positioning statement but it is comparably little part of the communication. We have to remember that everything is establishing the positioning (or the dimension), your packaging (the way it looks, the way it feels, the way it smells, what material it is made of etc.), your Users Manual (how you communicate in it, how you treat your users in it, how you thank them for choosing your product etc.), your product User Experience ( how they use it, is it the way you think they are using it or it is something that you did not expect when you created it, is it easy, is it emotional etc.), your Customer Service, your reaction to crisis etc. All this creates the dimensions around your brand and establish your positioning.
So looking at the name PIXhawk at this angle it is a Killer brand!. Perfect communication, it means Digital Bird. The moment you read it you almost on the spot recognize this as a DRONE brand.
I cannot say this for the Modes though for now and they are very important part of the marketing communication because they are related to the user experience and the ease of use.
ALTCTL What is this? This is just a jargon acronym.
POSCTL - the same...
RTL
Loiter
all the same... While the RTL and Loiter could be known from some experience users it is not true for the AltCtl and PosCtl. I cannot relate them straight forward to a knowledge I already have. No way...
So if we have to make the right communication we should call them
Positition Control, Hold or just - Position mode
Alltitude Control, Hold or just - Altitude mode or Assist mode or Attitude mode
Come Home  instead of RTL
Pause instead of Loiter
Acrobatic mode or Sport Mode (the DJI convention). not just Acro.
Mission
Selfie
Orbit
Follow me
Manual
All these are good names because almost everybody knows the first meaning of this words, and then buying your product they will attach another meaning to this words ie you will build a dimension to your product.
IPhone is not the most profitable phone because it is the smartest phone. Actually it is the dumbest phone but it comes with one button, it shines, it is expensive, it makes the best photos 200fps video and it feels good in your hand and it is a statement. I cold not stand my iPhone 6 when I got it as present and I sold it after a month, but I'm probably 1% of the people that will do this and prefer a little smarter phone and like Android.
DJI is the iPhone of the industry. And despite i don't like DJI I fly it as the most reliable controller that can carry my camera (pretty expensive one) and they do their communication by the book. Once the Pixhawk and PX4 become the Android in the industry I will put my camera under it. There is a some work for us to achieve this. We are not there yet...

Ok, thanks to reading through all of @tubeme comments. It got me thinking about a possible solution. Here is my clean slate proposal for flight modes:
First we need to think about what sorts of things can actually be assigned to a switch. After a while I decided there were only two types of thiings that can be assigned to a switch:

Flight Mode - The vehicle has a set of flight modes, only one of which is active at a time.
Functions - Each seperate function has two or more "modes" associated with it. For example: VTOL state is a function. It has two modes: Forward Flight, Hover. Another example is Landing Gear. It has two modes: Up, Down. Plenty of other possible functions out there to assign to a switch.

So you certainly need a Flight Mode switch and then you can have optional Function switches. But one single flight mode switch doesn't really cut it. There are too many modes to put them all on one switch. So you need the concept of Flight Mode "Override" switches. The flight modes you assign to these switches "Override" the setting on the main Flight Mode switch. Each Flight Mode has a priority, so if multiple overrides are active at the same time the highest priority one takes affect. So for example "Emergency Stop" would be the highest prioroty Flight Mode. Another important thing is that an Override switch always has to have an "Off" position, for when it is not overriding anything.
So how would you create a UI to make this work and can it be understand by users? In order to determine that I've prototyped this model in QGC. It's here in this branch: https://github.com/DonLakeFlyer/qgroundcontrol/tree/NewFlightMode. You can build it yourself if you want to play around with it. It works visually, but does not modfy params. In order to make this work firmware needs to change. The Default Configs correctly change thing. You can also manually tweak custom configs, but you may run into strangeness there.
Here is what it looks like:

At the very top right there is a dropdown which lets you pick from pre-configured options. We can add as many of these as wel like. I've built in 3 different one:

Multi-Rotor with a 3 position main Flight Mode switch
Multi-Rotor with a 6 position main Flight Mode switch
VTOL with a 6 position main Flight Mode switch and Transition/Landing Gear function switches.

This image above is showing a 3 position main mode switch. It also has three override switches. The first the get you extra Loiter/Mission modes. The other two are what I call "oh shit" switches to RTL or Emergency Stop. In this example the Vehicle would be in Mission mode since that "overrides"  Alt Control on the main Flight Mode switch.
Here is a 6 position Flight Mode setup:

It's has the same flight mode selection capability as the first example:
And last here is a VTOL example, which uses Functions:

The concept of a Function is completely standalone from a Flight Mode.

With the risk of becoming annoying I will say the last thing I have in mind about the Modes.

@tubeme As far as I'm concerned, you're preaching to the choir :) I agree with all you say and I too get glaze eyed when I see things like RATTITUDE. And I write software for this thing!
The though part is reconciling the need of the novice, casual user and the desire of academia, a group who is just as much a target.
@DonLakeFlyer Nice gauges! :)

here are 2 things going on here:

firmware needs an integer specifying the desired mode

Novice picks a default config. We can create default configs that match common radios. Next step is to modify a default config and tweak it a bit. Power user still has every possible combination available as well.

@DonLakeFlyer I support your proposal, just one more thing - in an Advanced Mode or via Parameters it should still be possible to adjust the active PWM Range for each Mode activation. As written before please think of RC-Channels and not of Switches as People owning only small RC Systems with less than 8 channels (as I do) will use Switch Mixing to allow multiple PWM Settings on one RC Channel. On certain Systems it is fairly hard to adjust all Positions to specific PWM values. So the NAZA Aproach with unchangable PWM Ranges to activate certain Flightmodes would make this rather hard to configure. If this could be kept in mind when changing the assignement I think this would be a very comfortable way of configuring the RC Channel / Mode Assignement.

@DonLakeFlyer The new setup page looks very very promising. And this

Novice picks a default config. We can create default configs that match common radios. Next step is to modify a default config and tweak it a bit. Power user still has every possible combination available as well.

was exactly my point. We have a simple default config for the novice, that would work almost right out of the box, and then experienced users have all the necessary tools to make a more complex setups.
Also your idea about the Modes and Functions was exactly what i had in mind too. We can assign modes and functions the way we want. We just need the priority in order to have the right overrides during flight.

@DonLakeFlyer I think some sort of slider on the bottom only at the "us" current setting would be better than the blue ribbon  starting from 1000us. Or it could be a blue arrow kind of triangle not a slider.

I'm looking at this today. Might need a call with Don to understand the details.

I will have time to flight-test this with my team of the month. Thanks Don!

I would like to add to this discussion a flight mode for fixed wings which is important. Something similar to APM planes FBWA mode. This should almost be the manual mode as a novice person has a high chance of crashing planes without pitch and roll being limited and a stall prevention active. If this already exists and I missed it then my apologies for the post.

I would like to add to this discussion a flight mode for fixed wings which is important.

You should put this in a separate issue

@LorenzMeier Any news on what you want do do here?

@DonLakeFlayer I like your new flight modes concept very much 😁. Can't wait for official implementation in QGC & PX4 firmware. Any date?

This is just a proposal at this point. Hasn't been approved.

@jcooper21 That mode you mention is what I'm looking for too for the novice. FBWA in my opinion is just like Manual - Stabalized but with stall prevention.
http://ardupilot.org/plane/docs/fbwa-mode.html

If this is the new convention for the flight modes @DonLakeFlyer summarized in:
@value 0 Manual
@value 1 Altitude
@value 2 Position
@value 3 Mission
@value 4 Hold
@value 10 Takeoff
@value 11 Land
@value 5 Return
@value 6 Acro
@value 7 Offboard
@value 8 Stabilized
@value 9 Rattitude
I don't understand what will be the difference between Manual and Acrobatic?
I suggest that Rattitude should be implemented for FW flight as well and be named 3D Sport mode for both MC and FW and VTOL in FW. In FW we will be able to fly stabilized, but just when we need it we can make 360's, rolls, loops etc and then when we need stabilization we could just release the sticks to just level the plane. It would be like gyro assisted 3D flying.
Probably Manual should mean Acrobatic. So Acrobatic is not needed, it is Manual.

@tubeme Acro is actually different from Manual on multirotors, Acro is your pure 3d flying mode there.
Crazy idea: Maybe we should have Stabilizied as default mode for fixed-wing AND multirotor, and Manual would be manual for FW as we know it and you would have to assign a switch to get into Manual. Acro for multirotor would still remain the same as it is, because if you rename Acro to Manual people will start crashing their copters within a day. But there will be no Manual anymore for multirotors and Stabilized would actually mean the same for both (attitude stabilized)
What do you think of that?
I agree on Rattitude, although maybe just call it Sport which is neat and simple :)
Later, Stabilized in FW could evolve to something like @dagar 's airpseed mode or similar.

@AndreasAntener That mode naming for multirotors sounds pretty nice. I had been meaning to bring that up sometime soon.

@AndreasAntener I see the problem with naming the modes arises because the current approach is to implement somehow similar modes for both types of vehicles the MC and FW. This way it becomes very confusing for the user, especially if he reads the current brief description of the modes: http://dev.px4.io/concept-flight-modes.html.
The approach I'm suggesting is to reverse the logic. See what each mode mean for the pilot of FW and MC independently. And name them correctly according to this logic.
You certainly got my point. Manual for MC means Stabalized. And Manual for FW means Acro. Not good idea especially for somebody is reading the manual.
So your idea is great. Just remove Manual (it is not definite description, Manual has a different meanings for different people). Stabalized means one and only thing for everybody.
So Stabalized is the default mode for MC. Stabalized is the default mode for FW. And then we have the sport modes:
Acrobatic (full rate controll) (The meaning of acrobatic implies sport) for both FW and MC.
3D Sport (Ratitude) (3D gives better spacial orientation about the posibilities of flying, and it gives marketing spice to just Sport). So Marketing wise 3D Sport is perfect.
If you implement Ratitude for airplanes that would be the craziest signature mode ever. Although it is popular with the MC bunch, it will be new to the FW flying and establish a good following. If I have the ability to fly my plane 3D but with the comfort of having assistance here and there that will be killer mode.
There is another issue with the description of the modes. I got different approach in the new manual, then the current descriptions. I structured the presentation arround the vehicle not arround the modes. THis way the descriptions for FW, MC and VTOL are totaly separated so you cannot read what Manual is for the three vehicles in one paragraph and get confused.
I made it here: http://px4.io/?post_type=docit&p=1738&preview=true but it is still a draft that has to be approved and released by Lorenz.
Stabalized flight should be stabalized. I get confused by the @dagar Airspeed mode. It does not follow the classical way of controlling plane, so I have to try it and then to see if I have an oppinion. It sounds good, it has logic arround the beginner, but Stabalized is fundamental mode. It should stay as is.
I would love Stall prevention in Stabalized. As I write about this stall detection and protection since 2 weeks two friend of mine crashed their Pixhawks with a stall in manual. One was begginer so when I asked him why he did not give enough throttle? He told me that he was afraid from the speed and not loosing his plane outside LOS, so he started flying it at 20% throttle to fly slow!!! I was stunned. But I realized that everybody that comes from a MC flying makes this mistake with the throttle. They think that if they decrease throttle they will slow things down, not realizing that we have a stall in the airplanes and this will crash your plane. The other guy was experienced, so he got in to conversation and just the plane slipped in stall, and neither he neither the PX4 managed to take it out of spin dive.
Because Lorenz just cut me on my suggestion to implement Stall detection and prevention in Stabalized i created this: https://github.com/PX4/Firmware/issues/4142 and I guarantee you it will be one of the most used modes here at my club.
Probably the argument is that the TECS are controlling the anti stall protection and they does not work in Stabalized, and the PX4 does not control the throttle in Stabalized. But I have 100 arguments that there are very simple things that can be implemented and work like a charm. For the real pilots Stall is the most important training you get during PPL course. And also having the stall warning is the N1 warning for all the pilots. Stall accounts to about 80% of the crashes of planes at my spot. The younger pilots crash everyday there with stalls. This is fundamental protection for FW flight it should be implemented everywhere, except Acrobatic Sport modes where you want to stall the plane on purpose and play with it.

All modes are Manual in a sense except Auto Modes. All the other modes you have some sort of manual input. Why use the term Manual then?

Acrobatic (full rate controll) (The meaning of acrobatic implies sport) for both FW and MC.

In my first attempt to respond here before I had the same thought. I have 2 issues I'd like to point out, both can be resolved:

for FW this is not actually rate controlled, but "real" manual (you're right, that's a technicality, pls ignore me)
VTOL: I would like to keep 2 separate acro/manual modes in MC and FW because although they are similar, a pilot who can fly FW in acro isn't necessary able to fly a MC in acro. So in the VTOL case I want FW acro but when I transition to MC I don't want MC acro (gets way to tricky for me ;)). This could be solved on a different level though for VTOL specifically, still worth to think about.

I would love Stall prevention in Stabalized.

This is actually why I mentioned it, I think if we do it right we'd come up with a mode that has a very manual feel but helps you not stalling the plane.

If you implement Ratitude for airplanes that would be the craziest signature mode ever

I'm pretty sure others have this as well but I would also find it very cool ;)

Any volunteers for FW acro mode? I think all we'd need to do is add rate setters to ECL - https://github.com/PX4/ecl/blob/master/attitude_fw/ecl_controller.cpp#L123 and cleanup the calls in fw_att_control to set the rate directly based on stick input, and skip control_attitude. From there it's pretty easy to get to rattitude.

@AndreasAntener I see then what the problem is. The most confusing thing is using Manual as a label for a group of modes and at the same time having a mode with that name. So we have Manual mode and then Manual Acro and Manual Stabalized. That is how it is organized now. In the new convention if accepted there will be no sections. We will have just different modes and choose which one to assign to a switch. This way there will be no more confusion for the Manual Mode. It will appear in FW and MC air-frames with a slightly different meaning.
From this explanation:

MANUAL
Fixed wing aircraft/ rovers / boats: The pilot's control inputs are passed directly to the output mixer.
Multirotors:
ACRO: The pilot's inputs are passed as roll, pitch, and yaw rate commands to the autopilot. This allows the multirotor to become completely inverted. Throttle is passed directly to the output mixer
RATTITUDE The pilot's inputs are passed as roll, pitch, and yaw rate commands to the autopilot if they are greater than the mode's threshold. If not the inputs are passed as roll and pitch angle commands and a yaw rate command. Throttle is passed directly to the output mixer.
ANGLE The pilot's inputs are passed as roll and pitch angle commands and a yaw rate command. Throttle is passed directly to the output mixer.

I cannot understand what is the difference between Manual and stabalized in MC? Or is there stabalized in MC?
So that is how I understand it:
MC
Manual = Angle control, returns to level flight ie. stabalized.
Acro = can make 360 flip, does not return to level flight when sticks in the middle. Direct input to the mixer.
Ratitude = Mixture between Manual and Acro depending on the sticks rate.
FW
Manual = direct commands to the mixer, direct response from the control surfaces and motor. Like you are flying it directly connected to the receiver. You can make 360 loops, when sticks are released the plane does not level itself. (Looks to me like analog to Acrobatic in MC)
Stabalized = Full manual control of the plane but in angle mode not directly to the mixer. Once the sticks are released the plane level itself.
So there are the modes as of now and how I understand them.
I will have some thought about VTOL. Until now we very rarely use transition in other mode than Stabalized FW to stabalized MC as well as Altitude Control and Position control transitions.  So the average user will use mostly these three modes in my opinion. Probably even only Alt and Pos Control in general if there is good way for landing and taking off in Alt and Pos control.

In the current mode naming a transition from Manual MC to Stabalized FW is the most logical thing as dynamics but it is really confusing me from general knowledge.
Probably if the modes are:
MC
Manual is renamed to Stabilized.
Acrobatic
Ratitude renamed to 3D Sport
FW
Manual is renamed to Acrobatic
Stabalized
This way the modes will function similarly in both MC and FW so will be easy to switch from MC to FW and vice versa.

@tubeme I was about to comment your earlier Post as confusing Names between FW and MC for Manual respectively Stabilized with different behaviour.
I support your renaming proposal so that same Mode Names behave the same FW and MC.
One may argue about Naming.
What is actuall called Acrobatic is called Manual in many popular Controllers (DJI, Tarot) but maybe it should not be reused after renaming the Flight Modes in order not to confuse existing users.
Maybe it would be a good idea to keep Ratitude, APM uses "Sport" for something a bit different.

@tops4u I think that Naming the modes is a big part of the marketing communication chain. So Having signature mode names is part of it all. Of course we can follow all the trends in the naming but I think for the intermediate to expert transition to PX4 will not be a problem to switch in the mode naming. Otherwise we have to use Attitude for Stabilized; Sport for Acro etc. If we use Manual instead of Acrobatic then we could use Acrobatic instead of Ratitude ( 3D Sport ). Just it needs clean up once and for all.

@tubeme Thanks Vasil! I think you're spot on with your observations and I expect to have more time to come back to this in the next few days.

@tubeme @DonLakeFlyer Happy to pick the discussion up again now.

@LorenzMeier @DonLakeFlyer In the latest master if I don't have Acro switch programmed I was not able to get Stabilized mode except from the QGC interface. It is especially inconvenient for VTOL.
For us the most used mode is Stabilized. In airplanes, in MC's and in VTOL. But we are not able to arm in Stabilized despite I perceive it as Manual mode.
Please explain to me in simple terms what is the difference what is the difference between Stabilized and Manual mode for MC?
And also what is the difference between Manual and Acro in FW?
What is the current Naming? I read somewhere @LorenzMeier explanation on the current new naming concept, but sadly could not remember where did i stumble on it.

MC manual and stabilized are the same thing (rates and attitude).
FW acro and rattitude aren't implemented. FW Manual is full manual control like flying RC.
https://github.com/PX4/Firmware/blob/master/src/modules/commander/commander.cpp#L3292

@tubeme I can not confirm your observation. I did flights with Pixracer and AUAV-X2 today both having Master FW from 22.5. On both Stabilized worked and I was able to arm. On AUAV-X2 there is no ACRO Mode programmed as well since this is a Foto-Hexa.
If you are not able to Arm there must be another Problem with your Configuration which prevents Arming.

On Apr 4 @AndreasAntener wrote:

@tubeme Acro is actually different from Manual on multirotors, Acro is your pure 3d flying mode there.

Crazy idea: Maybe we should have Stabilizied as default mode for fixed-wing AND multirotor, and Manual would be manual for FW as we know it and you would have to assign a switch to get into Manual. Acro for multirotor would still remain the same as it is, because if you rename Acro to Manual people will start crashing their copters within a day. But there will be no Manual anymore for multirotors and Stabilized would actually mean the same for both (attitude stabilized)
What do you think of that?
I agree on Rattitude, although maybe just call it Sport which is neat and simple :)
Later, Stabilized in FW could evolve to something like @dagar 's airpseed mode or similar.

@tops4u Probably my master is a month old. It could be VTOL related will try tomorrow.

@dagar then is it logical to say this?
MC
Manual could be renamed to Stabilized.
Acrobatic
Ratitude renamed to 3D Sport
FW
Manual could be renamed to Acrobatic
Stabalized
Is correct
OR we could have the following:
MC
Stabilized.
Acrobatic could be renamed to Manual
Ratitude renamed to 3D Sport
FW
Stabalized
Manual
Or even this:
MC
Stabilized.
Acrobatic
Ratitude renamed to 3D Sport
FW
Stabalized
Manual could be renamed to Acrobatic.
And it will still hold its logic right?

Manual in FW flight I understand it as if I connected the servos directly to the receiver right?

We need consistency between the modes because of the VTOL!!
If I make the transition with the VTOL the mode switch stays at the same position in both modes.
So The pilot expects consistent behavior.
So when I'm in Stabalized MC after the transition I want to be in Stabalized in FW.
If I'm very good pilot and I fly Acro MC after the transition I expect to be in Acro FW which is now called manual in FW.
From Altitude mode MC I want to go in Altitude mode FW.
So the consistency is very important for VTOL but it is important for people switching UAVs. Like people that fly Helicopters, MC's, airplanes as well. It will be much more easier to adopt the technology by pilots for all air frames. This is important for commercial use. And much more easier for explanation.

There are some good ideas here. Can we try to gather our thoughts in a google doc and establish a path forward? This includes potential short term fixes (mode renaming) and some things that would be medium to longer term.
@tubeme @LorenzMeier @tops4u
https://docs.google.com/document/d/1pi7YMKu9dhcq6HRAXQ_gMesn2gGrRa7cdNTYLEsNDjE/edit

Release 1.5 will handle flight mode cleanup.

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.
(This is an automated comment from GitMate.io.)


Add tests for ability to disable any Sidekiq worker via Flipper flag

This brings our test coverage back to 100%. 😄


:pushpin: Pin mozilla-django-oidc to <2.0.0

mozilla-django-oidc-db is currently not compatible with mozilla-django-oidc 2.0.0
TODO:

[ ] Fix compatibility with mozilla-django-oidc 2.0.0

Codecov Report

Merging #15 (b4d16c9) into master (f4e0171) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   93.45%   93.24%   -0.22%
==========================================
  Files          21       21
  Lines         474      474
==========================================
- Hits          443      442       -1
- Misses         31       32       +1

Impacted Files
Coverage Δ

mozilla_django_oidc_db/models.py
81.25% <0.00%> (-1.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e0171...b4d16c9. Read the comment docs.


Teleport-On-Entry not working in latest version

Hello, the latest version does not execute Teleport-On-Entry, I am on 1.8.8, I downgraded to older version of WGEF and there it works so its not error made by me.
There is nothing printed in console.

Having permissions to worldguard.region.bypass.<world> will prevent the flags from happening, also make sure you have use-player-move-event set to true in WorldGuard config


image and other icons are  not showing except bold, underline

Hii am not able to see other icons except bold, underline you can refer image :

the code which am using it like that this is in angular7 so option is like that ;
public options: Object = {     charCounterCount: true,     toolbarButtons: ['bold','underline','emoticons','insertLink','fontAwesome', 'insertImage','insertVideo']   }
I have also added scripts in angular.json like that
"styles": [               "src/styles.css",               "./node_modules/froala-editor/css/froala_editor.pkgd.min.css",               "./node_modules/froala-editor/css/plugins/image.min.css",               "./node_modules/froala-editor/css/plugins/video.min.css",=               "./node_modules/froala-editor/css/froala_style.min.css",               "./node_modules/font-awesome/css/font-awesome.css"             ],             "scripts": [               "./node_modules/froala-editor/js/froala_editor.pkgd.min.js",               "./node_modules/froala-editor/js/plugins/image.min.js",               "./node_modules/froala-editor/js/plugins/video.min.js",               "./node_modules/jquery/dist/jquery.min.js"             ]
can any one help me out why am getting this issue

Hey, got the same after updating the editor to Version 3.
First of all, check your Licence, they changed it for Version 3.
Read the Docs of Version 3, they changed a lot in the config.
You have to import your Plugins now
https://www.froala.com/wysiwyg-editor/docs/plugins
Hope i could help.


[Package ID Prefix Reservation] User can manage prefix subset from account page

We will decide if this feature is needed based on the amount of support requests we get with similar requests.

@diverdan92 , what do you think?

@skofman1 probably not needed


ldeep: 1.0.73 -> 1.0.75

Diff: https://github.com/franc-pentest/ldeep/compare/refs/tags/1.0.73...1.0.75
Changelog: https://github.com/franc-pentest/ldeep/releases/tag/1.0.75

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 358911

x86_64-linux

:white_check_mark: 2 packages built:

ldeep
ldeep.dist


Technic solder not unpacking correctly

Sorry if this is a duplicate be and my partner have been having an issue where technic solder doesn't download the mod correctly to the mod pack. Instead of being the original size of 10megs it ends up being 1,5. This is mainly happening with the mod PneumaticCraft-1.7.10-1.6.5-67-universal.jar

Then your zip file is incorrect
Take note of http://docs.solder.io/v0.7/docs/zip-file-structure
Your not transferring the complete zip to the required location for your repo
When I compress and have the required file structure within the needed zip this is what I have to upload http://imgur.com/9Ktw5EH

This was fixed during your time on our IRC I believe, please update the issue.