Code Llama can't find tokenizer

System Info
TGI 1.0.3, running on Azure "STANDARD_ND40RS_V2"
Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
I am running the following command:
docker run --gpus all --shm-size 1g -p 8080:80 -e HUGGING_FACE_HUB_TOKEN=... ghcr.io/huggingface/text-generation-inference:1.0.3 --model-id "codellama/CodeLlama-34b-Instruct-hf"
The container starts, downloads the model, tries to start it, but then fails with the following message:
Tokenizer class "CodeLlamaTokenizer" does not exist or is not currently imported.
Expected behavior
The model starts up and serves requests

CodeLlamaTokenizer is not in a transformers release, so you need to install directly from source

Ok, thanks, so I can't use the provided containers directly (1.0.3), but have to build my own?

Thanks for the reply. I am not sure if I fully understand:
I use the provided docker container ghcr.io/huggingface/text-generation-inference:1.0.3, so I just execute the docker run command as mentioned in my issue description. I do not install any pip packages or so, really just a plain, empty system with docker and cuda-support, then do the docker run command.
This for example worked with the Llama models, I then got an endpoint (in my case on port 8080) where I could get predictions from the model. However, it does not work with code llama, as the container does not even start because of the missing tokenizer.
So does this mean I cannot use the provided containers, but would somehow need to build my own, which has the latest release of transformers included?

@ArthurZucker for visibilty (this broke old transformers too, didn't it ?)

I don't think I understand the issue since:

CodeLlama needs the latest release of transformers. TGI needs to take this into account no?
You can still load some of the CodeLlama models with AutoTokenizer with a warning (in transformers) as we don't raise errors, so no breaks

Is this still an issue? I'm running this command on a g5 just fine:
docker run --gpus all --shm-size 1g -v /data:/data -p 8080:80 ghcr.io/huggingface/text-generation-inference:1.0.3  --model-id codellama/CodeLlama-34b-Instruct-hf --num-shard 4

I am facing the same error with ghcr.io/huggingface/text-generation-inference:1.0.3.
I am using a fine-tuned codeLlama 34b model and the command I am running is:
docker run --gpus all --shm-size 1g -e HUGGING_FACE_HUB_TOKEN=<Token>  -p 8000:80 ghcr.io/huggingface/text-generation-inference:1.0.3 --model-id $model --num-shard 8 --max-input-length 30000 --max-batch-prefill-tokens 32000 --max-total-tokens 32000 --rope-scaling=dynamic --rope-factor=2.0
Below are the detailed logs:

The tokenizer class you load from this checkpoint is not the same type as the class this function is called from. It may result in unexpected tokenization.
The tokenizer class you load from this checkpoint is 'CodeLlamaTokenizer'.
The class this function is called from is 'LlamaTokenizer'.
You are using the default legacy behaviour of the <class 'transformers.models.llama.tokenization_llama.LlamaTokenizer'>. If you see this, DO NOT PANIC! This is expected, and simply means that the
 `legacy` (previous) behavior will be used so nothing changes for you. If you want to use the new behaviour, set `legacy=True`. This should only be set if you understand what it means, and thouro
ughly read the reason why this was added as explained in https://github.com/huggingface/transformers/pull/24565
Traceback (most recent call last):

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/flash_llama.py", line 40, in __init__
    tokenizer = LlamaTokenizer.from_pretrained(

  File "/opt/conda/lib/python3.9/site-packages/transformers/tokenization_utils_base.py", line 1854, in from_pretrained
    return cls._from_pretrained(

  File "/opt/conda/lib/python3.9/site-packages/transformers/tokenization_utils_base.py", line 2017, in _from_pretrained
    tokenizer = cls(*init_inputs, **init_kwargs)

  File "/opt/conda/lib/python3.9/site-packages/transformers/models/llama/tokenization_llama.py", line 156, in __init__
    self.sp_model = self.get_spm_processor()

  File "/opt/conda/lib/python3.9/site-packages/transformers/models/llama/tokenization_llama.py", line 162, in get_spm_processor
    with open(self.vocab_file, "rb") as f:

TypeError: expected str, bytes or os.PathLike object, not NoneType

During handling of the above exception, another exception occurred:

Traceback (most recent call last):

  File "/opt/conda/bin/text-generation-server", line 8, in <module>
    sys.exit(app())

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/cli.py", line 81, in serve
    server.serve(

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 195, in serve
    asyncio.run(

  File "/opt/conda/lib/python3.9/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)

File "/opt/conda/lib/python3.9/asyncio/base_events.py", line 647, in run_until_complete
    return future.result()

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 147, in serve_inner
    model = get_model(

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/__init__.py", line 187, in get_model
    return FlashLlama(

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/flash_llama.py", line 48, in __init__
    tokenizer = AutoTokenizer.from_pretrained(

  File "/opt/conda/lib/python3.9/site-packages/transformers/models/auto/tokenization_auto.py", line 724, in from_pretrained
    raise ValueError(

ValueError: Tokenizer class CodeLlamaTokenizer does not exist or is not currently imported.```

@silvanmelchior were you able to resolve this at your end?

Right @OlivierDehaene , it was indeed a missing tokenizer.model file. Thank you for the quick resolution.


nixos-unstable release doesn't include nixos-install-tools package

To reproduce (as per documentation):
This doesn't allow running nixos-install.
curl -L https://github.com/nix-community/nixos-images/releases/download/nixos-unstable/nixos-kexec-installer-noninteractive-x86_64-linux.tar.gz | tar -xzf- -C /root
/root/kexec/run

This does:
curl -L https://github.com/nix-community/nixos-images/releases/download/nixos-23.11/nixos-kexec-installer-noninteractive-x86_64-linux.tar.gz | tar -xzf- -C /root
/root/kexec/run

Using nixos-anywhere on the nixos-unstable image fails with:

workaround: after nixos-anywhere errors out, you can ssh into the machine and nix-channel --update && nix-env --install nixos-install-tools, then re-run the nixos-anywhere command.

posting this here as it was a pain to find without the error listed in text format:
### Installing NixOS ###
+ ssh_ sh
+ ssh -t -i /tmp/tmp.1bbrgRzWQJ/nixos-anywhere -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no<EMAIL_ADDRESS>sh
Pseudo-terminal will not be allocated because stdin is not a terminal.
Warning: Permanently added '<IP_ADDRESS>' (ED25519) to the list of known hosts.
+ export PATH=/run/wrappers/bin:/root/.nix-profile/bin:/nix/profile/bin:/root/.local/state/nix/profile/bin:/etc/profiles/per-user/root/bin:/nix/var/nix/profiles/default/bin:/run/current-system/sw/bin:/run/current-system/sw/bin
+ PATH=/run/wrappers/bin:/root/.nix-profile/bin:/nix/profile/bin:/root/.local/state/nix/profile/bin:/etc/profiles/per-user/root/bin:/nix/var/nix/profiles/default/bin:/run/current-system/sw/bin:/run/current-system/sw/bin
+ mkdir -p /mnt/tmp
+ chmod 777 /mnt/tmp
+ '[' n = y ']'
+ nixos-install --no-root-passwd --no-channel-copy --system /nix/store/4fc0dgv4vwirbp36nn7dbrbzahmlbp5l-nixos-system-Eidolon-24.05.20240521.5710852
sh: line 20: nixos-install: command not found
+ rm -rf /tmp/tmp.1bbrgRzWQJ

nixos-install: command not found


Question about Calibration Data

Hi, I have a question about the calibration data:
In calib_data.py, you re-organize the calib data so that every batch has the same sequence length and there's no need for padding.  But will this affect the positional_embedding and further affect the data distribution during calibration? And furthermore, will padding tokens with attention mask affect the calibration process when I have to pad the data so that they can have the same length?

Same question and also does it matter to use 512 seqlen ? What if we have ram constraint will work the same way with 128 or 256 tokens ?

For small LM (7B) or NMT encoder-decoder models (< 1B) I found out that scaling / clipping was useless, it just worked only while quantizing directly. Does it make sense?

The scaling/clipping works for Llama-7B models. I am not sure about the smaller ones or enc-dec models.

I am not saying it does not work :) I am saying that WITHOUT it, it work too ....

Hi, is there any new progress on this issue? I also encountered the same problem.


web package into app service

Error logs:
when am deploying .net code into web app am getting following error
2018-10-04T13:15:49.6354214Z ##[error]Failed to deploy web package to App Service.
2018-10-04T13:15:49.6366518Z ##[debug]Processed: ##vso[task.issue type=error;]Failed to deploy web package to App Service.
2018-10-04T13:15:49.6366850Z ##[debug]task result: Failed
2018-10-04T13:15:49.6367224Z ##[error]Error: Error: Failed to deploy App Service package using kudu service : Internal Server Error (CODE: 500)

@MSidda , Can you share the task version?
If possible, please upgrade to 4.*  task version and rerun the deployment.

@MSidda , closing the issue as the above solution should fix the issue.

@vincentdass be good if the docs could be updated to reference v4 too -> https://docs.microsoft.com/en-us/azure/devops/pipelines/targets/webapp?view=azure-devops&tabs=yaml

@worldspawn , thanks for bringing the documentation to notice. Will change that!


Change to css timeline

Switched to a much better timeline using only CSS for rendering.
Javascript still used to load the data into HTML.

@rahulpatidar0191 Good eye for typos! Thanks!
Any feedback on the overall look?

The overall look is good. Grouping them with emoji is a clever idea.
One very minor thing I noticed is the single points are missing a bullet. For eg: John Cabot is missing a bullet but the next point has it. Again, minor thing

It's actually by design!  :sweat_smile:
I thought it'd be better to separate between one description and multiple but clearly it looks off since you thought it was a mistake.
I'll put a bullet point every time to make it consistent.


Exhibitor zookeeper ensemble with 2 leaders

We have 5 node zookeeper ensemble started by exhibitor. We have seen sometimes when a zookeeper restarts (due to machine failure) that there are 2 leader running for a transient time. Also, we have seen that  znode exists on 1 out of 5 zookeeper but not all during that time that exhibitor is restarting zookeeper.
Is there a way to force quorum on exhibitor/zookeeper so that it doesn't except writes.

Example:
[
{
"code": 3,
"description": "serving",
"hostname": "<IP_ADDRESS>",
"isLeader": false

},
{
"code": 3,
"description": "serving",
"hostname": "<IP_ADDRESS>",
"isLeader": false

},
{
    "code": 3,
    "description": "serving",
    "hostname": "<IP_ADDRESS>",
    "isLeader": true
}

]
In the 3 node cluster, 2 nodes are leader for very short period of time and then it goes back to 1. However, during this short time won't there be a problem as data can be inconsistent.

Unfortunately Exhibitor does support things like denying writes during certain failure scenarios.
This is really more of a zookeeper problem in terms of its handling of node failures.


Handle players running out of resources properly

Since the world has a fixed border, it may, however unlikely it may seem, run out of resources. The mitigations listed for that problem rely on statistical unlikeliness, which is not ideal. The problem needs to addressed with a sound solution.

I think if we want to solve this issue, we need to fully understand what it consists of. What resources people are going to run out of, exactly? I currently see:

ores
caves to search through
functional structures that players would want to visit again and use for something (villages, outposts, etc)
lootable structures that people might want to use again later (dungeons, mineshafts, nether fortresses, trial chambers, etc)
purely loot structures (ancient cities, shipwrecks, buried treasures, etc)
places to build
stuff like clay, podzol, specific types of wood that can be farmed, but annoying for a new player to obtain if none is present naturally
Anything else?


Spacer: Push lemmas in batches

During the check for inductive invariant, we were previously trying to push lemmas to the next level one by one.
Now,  we attempt to push them in batches, gradually dropping those that cannot be pushed to the next level.
We use activation literals to track which lemmas we already showed cannot be pushed to disable them from further considerations. We basically simulate check-sat-assuming, which OpenSMT does not support yet, with push and pop.
The idea is the following:
We maintain a record of all active lemmas, which could still be pushed.
At each iteration, we try to push all active lemmas. If this is not possible, we obtain a model, a counterexample-to-induction (CTI). We iterate over all active lemmas and disable those that are falsified by this model (we actually maintain the list of negation of lemmas, so we check if the negations are true in the model).
We update the activation literals to disable falsified lemmas from further consideration and repeat the whole process.
The process stops when we successfully push all remaining active lemmas or if we disable all lemmas.
This had overall very positive effect on both LIA-Lin and LIA-nonlin benchmarks.

LIA-Lin:

LIA-nonlin:


feat(sink): support deltalake sink with rust sdk

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
support deltalake sink with rust sdk.
resolve https://github.com/risingwavelabs/risingwave/issues/13152

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

In a new commit https://github.com/risingwavelabs/risingwave/pull/13600/commits/c890167eb4dbee6bff7750e85740272a1c5a3781, I just tried to introduce a separate arrow version for deltalake so that the arrow version of the current code will not be downgraded. This is achieved by manually setting the arrow version of icelake in Cargo.lock.
The current code of arrow datachunk conversion is moved to a macro gen_code, so that the conversion code can be applied to both versions.
The reason for delta-rs to depend on a older version (i.e. 48.0.1) of arrow is that its version of datafusion it depends on is 48.0.1. However, the latest version of datafusion is already using 49.0.0. So after the delta-rs upgrades their datafusion version to one that uses 49.0.0, we can then let both delta-rs to use the same version as our current code. FYI, I tried forked delta-rs and upgrades their datafusion version, but it cannot compile without some extra effort because there is some breaking changes in the upgrade. We can have a issue to track their version upgrade @xxhZs
@wangrunji0408 @xxchan Could you take a look whether the current hack looks good to you?

In a new commit c890167, I just tried to introduce a separate arrow version for deltalake so that the arrow version of the current code will not be downgraded. This is achieved by manually setting the arrow version of icelake in Cargo.lock.
The current code of arrow datachunk conversion is moved to a macro gen_code, so that the conversion code can be applied to both versions.
The reason for delta-rs to depend on a older version (i.e. 48.0.1) of arrow is that its version of datafusion it depends on is 48.0.1. However, the latest version of datafusion is already using 49.0.0. So after the delta-rs upgrades their datafusion version to one that uses 49.0.0, we can then let both delta-rs to use the same version as our current code. FYI, I tried forked delta-rs and upgrades their datafusion version, but it cannot compile without some extra effort because there is some breaking changes in the upgrade. We can have a issue to track their version upgrade @xxhZs
@wangrunji0408 @xxchan Could you take a look whether the current hack looks good to you?

Using macros to reuse two copies of code is acceptable, and we may need to keep it that way all the time. Because there will always be a time when icelack and delta.rs depend on an inconsistent arrow.
If we want to finally unify both of their dependencies on arrow, i.e. only one version of arrow exists in our system, I think we can totally use 48 in this pr, since there seems to be no component in our system that needs to work under 49, and after that we just need to wait for both to depend on one version (in fact, just need delta rs to upgrade to it, since icelake's dependency is >48, and the newer version is supported by default), and then update the arrow version.

Using macros to reuse two copies of code is acceptable, and we may need to keep it that way all the time. Because there will always be a time when icelack and delta.rs depend on an inconsistent arrow.
If we want to finally unify both of their dependencies on arrow, i.e. only one version of arrow exists in our system, I think we can totally use 48 in this pr, since there seems to be no component in our system that needs to work under 49, and after that we just need to wait for both to depend on one version (in fact, just need delta rs to upgrade to it, since icelake's dependency is >48, and the newer version is supported by default), and then update the arrow version.

Not only deltalake and icelake are using arrow, but also our internal udf. In the future if we upgrade the arrow version of udf, it doesn't make sense to be blocked by arrow version of some external connectors. I think it's acceptable to support several versions of arrow at the same time.

I just changed to reload the same arrow.rs for twice for different arrow version. Now we don't even need to use macro.
pub use arrow_impl::to_record_batch_with_schema as to_deltalake_record_batch_with_schema;
use {
    arrow_array_deltalake as arrow_array, arrow_buffer_deltalake as arrow_buffer,
    arrow_cast_deltalake as arrow_cast, arrow_schema_deltalake as arrow_schema,
};

#[allow(clippy::duplicate_mod)]
#[path = "./arrow.rs"]
mod arrow_impl;

In the outer mod we rename the arrow packages to arrow_xxx, and in arrow.rs we use super::arrow_xxx  to use arrow version specified in the outer mod.

Add some comments on arrow/mod.rs and/or above mod arrow_impl; about how this trick works.
Add some comments on arrow_* about where it is used. i.e., why do we have to pass arrow data around.

Comments added.

prefer using version number as the suffix, instead of common (this is especially confusing to me. What does "common" mean?) and deltalake.

I think using version number is too implicit. The conversion logic is implemented for where it is going to used instead of a fixed number. With a more meaningful suffix we can know more information about it. Besides, in the future when we bump up the version number, we don't have to rename the mod to the new version number.
The term common means the original default arrow version used in risingwave_common. Maybe arrow_default is a better naming, and I've changed to arrow_default to mean that this is the default arrow version to use in our system.

There seems to be so many Cargo.lock changes. Is this expected? Also, will this PR increase the compile time and binary size significantly given that many new dependencies are added.

This is expected because most changes are introduced by the delta lake libraries.
I had a test locally on the main branch and this branch to test building the risingwave_cmd_all in release mode.

# of deps
compile time
binary size

current commit
1222
19m 36s
381,807,328

current commit w/o datafusion
1204
16m 47s
340898016

current commit w/o datafusion + dynamo db
1178
16m 20s
332395424

main
1148
16m 05s
316,990,384

main + arrow 0.48
1154
16m 32s
317,187,120

It looks like the great number of changes in Cargo.lock are introduced by datafusion and dynamo db. The datafusion is introduced by accidence in the dev-dependency and can be temporarily removed. The dynamo db dependency is bundled in the delta rs sdk when we enable the s3 feature of it. I have forked the repo and support conditionally removing the dependency on dynamo db so that we can avoid introducing the dynamo db sdk dependency.
After removing the dependency on datafusion and dynamo db, the compile time and binary size is greatly reduced, which is slightly increases compared to the main.
Besides, I had a wired observation that the datafusion dependency is introduced in dev-dependency and only used in unit tests. However, the Cargo.lock still include datafusion as a dependency of risingave_connector, which causes the increase in compile time.


feat(connect):Support (min/max) constraints for DataGen connector

What's changed and what's your intention?
As title
Please explain IN DETAIL what the changes are in this PR and why they are needed:

Summarize your change (mandatory)
How does this PR work? Need a brief introduction for the changed logic (optional)
Describe clearly one logical change and avoid lazy messages (optional)
Describe any limitations of the current code (optional)
Add the 'user-facing changes' label if your PR contains changes that are visibile to users (optional)

Checklist

[x] I have written necessary docs and comments
[x] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)
Close #2747

rustdoc recommends /// to write doc comments and // to write normal comments.
https://doc.rust-lang.org/rust-by-example/meta/doc.html

Please resolve conflicts


Prometheus metrics

metrics
Chaps, I'm am trying to evaluate how to instrument Kong and to my honest surprise found that there is no native metric exporter for prometheus.
The only metrics plugins available are "paid for" things like data-dog etc...
I would actually like to politely suggest that someone makes this a priority, fact is that there are 0 open source metrics plugins I can see...

I'm currently instrumenting Kong for Prometheus using https://github.com/knyar/nginx-lua-prometheus

That being said, a native plugin would be super useful, although the customization and metrics would pose an interesting challenge.
My assumption is there would be a few "default" metrics exposed (upstream response times, connection counters etc.) with some mechanism of defining additional ones on your own.

@thenayr I had a quick look at the lib you mentioned, seems a lot like statsd on a first glance, maybe that plugin could provide some inspiration? see https://github.com/Mashape/kong/tree/master/kong/plugins/statsd

@Tieske   I had  enabled Kong`s statsd plugin,   I plan to send  kong metrics  to statsd_exporter, But I did not seen any data about kong,
I guess something wrong with statsd_mapping.conf

Any news?

hello, any changes in the work ?

Nope, sorry... Kong was literally the hardest thing to run inside k8s that we ever tried I'm afraid..

@starkers Wondering why that is the case? It works beautifully for us inside of k8s

Just had a quick look again, but looks to me that the statsd plugin should suffice if you use the official Prometheus Statsd exporter.
@JoshuaAndrew any luck in getting that to work?

Would be nice to have things in /cluster as metrics exposed via prometheus as welll

Have setup https://github.com/nijikokun/kong-plugin-prometheus and its going ok so far. I'd been keen to see 1) if there are any caveats or issues in usage of a kong plugin to provide a prom exporter; 2) related to that if it works fine when kong is horizontally scaled, and 3) what we can contribute to enhance the plugin. @coopr be good to get an update from Mashape.

@chris-scentregroup It looks like that plugin stores values in a shared dict, similar to the yciabaud/kong-plugin-prometheus plugin linked in the previous comment. If that's the case then I imagine it will be subject to the same caveats that yciabaud notes for their plugin, which are also noted in the underlying knyar/nginx-lua-prometheus#caveats library.
It looks like both plugins use gauges, counters, and histograms. If Kong were horizontally scaled then each server would only be able to observe its own metrics, but you'd be able aggregate them on the Prometheus server using avg/min/max/histogram_quantile, etc.

Thanks @cosmopetrich. In general I'm also wondering about data stores for metric like data in general in kong. Before looking at plugins/extras and the like; I noticed for example that wherever konga gets its metrics for kong in the dashboard this will reset if I replace the containers. I presume this may well be a global problem and currently there isn't any basic metric data stored back to the db?
 If none of its going back to the db, happy to use data containers/volumes to persist 'counts' if I can get some pointers where these are stored.

No worries at all. Prometheus' approach is a bit different to statsd/datadog/etc.
Both the plugins (and the underlying kynar/nginx-lua-prometheus module) store metrics in memory in a variable with a predefined maximum size. That's a pretty common approach for Prometheus metrics, since it's assumed that Prometheus will be retrieving and storing metrics approximately every 60 seconds. Kong will reset its metrics when it restarts, but Prometheus will miss 60s of data at most, and it will automatically detect that the metrics have reset.
The caveat is that Nginx will need to read the entire metrics variable whenever Prometheus retrieves metrics from Kong. Nginx won't the variable to be written to until it's finished reading it. That might not be a problem, but it depends on a few things. How often the variable is written to and how fast a write needs to be will depend on the amount of traffic Kong receives. Kong's client will already have received a response, assuming that metrics are updated during the log phase. However, a delay in this phase could still be detrimental  if Kong is receiving a large amount of traffic.
The amount of time it takes for the variable to be read will depend on the number of metrics that are stored, and how many values there are for each metric's labels. The nijikokun plugin appears to store quite a large number of labels. This will mean that its metrics provide a lot of granularity, but that they're more resource-intensive on Kong and on Prometheus itself. The presence of remote_addr as a label could easily generate tens of thousands of metrics on a Kong server that's exposed to the public internet.  The yciabaud plugin offers a much more conservative set of labels. These won't allow you to "drill down" as much as the other plugin, but they're far less likely to cause problems for Kong or Prometheus.
Storing metrics in the database could help, though that approach introduces problems of its own. Database read/writes are expensive compared to updating in-memory variables, particularly if there's a need to update tens of variables for each request that Kong processes.

There are multiple solutions out there now. I think we can close this.


[Candidate 2v2 Alterac Pass ZH v1] Units can be dropped on impassable area

Observed behaviour
Units can be dropped on impassable area.
Expected behavior
Units cannot be dropped on impassable area.
Screenshots

nice one ill fix and send u a new one via dc again


Making changes recommended by Mandy

@mandysack submitted a hotfix (two weeks ago, really late on this)
#46 and #47
#45
#48

Update to include fixes
#45
#48

It doesn't look like I have write access to the mandysack-patch branch to push my changes to, and the files are not attaching to the pull request.

Sorry, I didn't get an email from your PR (which is really weird since I'm 'Watching' the repository). I'll merge now.


Auto-Expand sub-folder when dragging over it. Issue #492

Auto-Expand for TreeViewAdv. Issue #492.
I went with the approach to extend TreeViewAdv and used the new class in both ProjectFolderView and SceneView. I tried to keep the changes as minimal as possible although the solution and csproj seem to have run away from a simple add existing file, let me know if I should remove them.
A few questions\comments:

Do you want to keep consistency of the type held by the SceneView\ProjectFolderView? I have currently kept the type as TreeViewAdv and just newed it to the new type (AutoExpandTreeView) which has a default of 1000 ms delay.

Is there a place to provide user\editor preferences, I would suggest putting the delay as an option for users.

Manual Tests:

Something else: All member access (fields, properties, methods) needs to be preceded with a this. - this is a code convention in the Duality repository.

Does this include inherited members? I.e this.PointToClient(...)?
Other than the above I believe all the code review changes have gone in, plus the following bug fixes\changes:

You can no longer open children of the node you are dragging or their children (You can't move a parent to it's children) - If this is expected behaviour let me know.
Dragging a node onto a valid 'auto expand' node and then off of the local client area no longer continues to expand the node you last dragged over.
If you have already dropped a node the previous node you dragged over will no longer expand afterwards.
Fixed crash when moving from project->scene view

There is one bug left to go when dragging project->scene view and vice versa. The behaviour is inconsistent on whether it will expand or not. Not sure if this is something I introduced but when drag and dropping a prefab from project to scene it is created with an empty name.

Something else: All member access (fields, properties, methods) needs to be preceded with a this. - this is a code convention in the Duality repository.

Does this include inherited members? I.e this.PointToClient(...)?

Yep! All of them.

Other than the above I believe all the code review changes have gone in, plus the following bug fixes\changes:

You can no longer open children of the node you are dragging or their children (You can't move a parent to it's children) - If this is expected behaviour let me know.
Dragging a node onto a valid 'auto expand' node and then off of the local client area no longer continues to expand the node you last dragged over.
If you have already dropped a node the previous node you dragged over will no longer expand afterwards.
Fixed crash when moving from project->scene view

Nice work 👍

There is one bug left to go when dragging project->scene view and vice versa. The behaviour is inconsistent on whether it will expand or not. Not sure if this is something I introduced but when drag and dropping a prefab from project to scene it is created with an empty name.

Hmm.. I wouldn't know how your changes should introduce that kind of Prefab dragdrop bug, but that's definitely not normal behavior - and I can't reproduce it in an unchanged build. This is how it should look like: https://gfycat.com/KaleidoscopicQuarrelsomeEarthworm
Can you verify whether this is a regression introduced by this PR? Maybe you are somehow accidentally interfering with something that may or may not trigger renaming-related code, leading to emptying the name of a newly instantiated node, but.. just wildly guessing here.
One more issue regarding code structure: Don't do empty lines between methods, except if the method above and the one below belong to different "groups" or "categories of methods. Which grouping you use is up for debate and your judgement, but there should be no empty line without reason. (Collapsed) example:
public AutoExpandTreeView(int autoExpandDelay = 1000)

private void StartAutoExpandTimer()
private void StopAutoExpandTimer()

private void OnAutoExpandTimerTick(object sender, EventArgs e)
protected override void OnDragOver(DragEventArgs dragEvent)
protected override void OnDragLeave(EventArgs dragLeaveEvent)
protected override void OnDragDrop(DragEventArgs dragDropEvent)

protected override void Dispose(bool disposing)

I'll let you address the last few issues, but I think we're making good progress here.

P.s Let me know if I should squash all these commits.

No need to, I'll use the GitHub Squash-Merge feature on this PR.

Okay that bug seems to be on master as well (on commit e94e8ca) if you create an empty prefab and drag it into the scene it creates a GameObject with an empty string as a name. Not sure if it's expected behaviour, here it is:

Latest commit employs recursion to go through parents of the hoveredNode to ensure the we aren't dragging a parent over it. I added an extension method for that functionality.

Okay that bug seems to be on master as well (on commit e94e8ca) if you create an empty prefab and drag it into the scene it creates a GameObject with an empty string as a name. Not sure if it's expected behaviour, here it is:

Ah - good find. I didn't test an empty one. Prefabs remain empty until an existing object is injected into them, but usually they're just created by dragging an object into the Project View. The behavior in your use case is expected, but admittedly not intuitive. Will have to figure out how to deal with this case better.

On top of that I believe all the stylistic changes are addressed.

They are. Thanks for your contribution and especially for being so positive about change requests! I'll merge this and you will find this update in the next binary release.


Issue #654 working on adding feature fs.watchFile()

Just putting a PR up of my current progress. Feel free to let me know if there could be improvements as I go.

Codecov Report

Merging #748 into master will decrease coverage by 0.87%.
The diff coverage is 10%.

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   86.88%   86.01%   -0.88%
==========================================
  Files          16       16
  Lines        1739     1759      +20
==========================================
+ Hits         1511     1513       +2
- Misses        228      246      +18

Impacted Files
Coverage Δ

src/filesystem/interface.js
84.23% <10%> (-9.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aae538...3fd3fb0. Read the comment docs.


Task should pickup CF CLI from PATH when used in a release definition

Currently it is only supported in build definitions.

Fix: https://github.com/Microsoft/vsts-cloudfoundry/pull/4

Released to the marketplace in version 0.115.0: https://marketplace.visualstudio.com/items?itemName=ms-vsts.cloud-foundry-build-extension


Fix ingress on arm64

Fixes: https://github.com/ubuntu/microk8s/issues/301

In addition to the ingress failure on arm this PR also disables addons and respective tests of fluentd and Jaeger that are not valid for arm64.


wip: add customizable metadata fetching params

Signed-off-by: Michele Zuccala<EMAIL_ADDRESS>What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
Not sure about the appropriate /area label here, could you please advise?
What this PR does / why we need it:
This PR adds support for customizable metadata fetching params that are going to be introduced with https://github.com/falcosecurity/libs/pull/40.
Which issue(s) this PR fixes:
Special notes for your reviewer:
WIP because I'm planning to set the correct libs version and checksum once https://github.com/falcosecurity/libs/pull/40 gets merged.
For now it's set to the feature branch name on https://github.com/falcosecurity/libs in order for this PR to be easily tested.
Does this PR introduce a user-facing change?:
new: add customizable metadata fetching params

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @zuc! It looks like this is your first PR to falcosecurity/falco 🎉

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

d012472 Merge branch 'feature/customizable-metadata-download-params' of github.com:zuc/falco into feature/customizable-metadata-download-params

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zuc: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: zuc
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Note for the reviewer(s): I chose to keep m_metadata_download_max_mb expressed in megabytes for user-friendliness reasons, and to convert the value in bytes only when calling sinsp. Happy to discuss if you have a different point of view here!

Since falcosecurity/libs#40 got merged, this is now ready for review.
Also, driver version has been bumped to https://github.com/falcosecurity/libs/commit/c415d577b79bef3b95028b1030ce42a5ec3c5c32.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: zuc
To complete the pull request process, please ask for approval from leodido after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido I added an upper boundary for the maximum download size, and a check to force frequency seconds to be higher than 0.
I don't think it would make much sense to cap the remaining params/boundaries given their meaning, but happy to discuss.

LGTM label has been added.  Git tree hash: c00805e2536f5eec28d37e342ad2867dba482c5e

/hold
to let other PRs get merged in

/hold cancel

New changes are detected. LGTM label has been removed.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

aaead11 Merge remote-tracking branch 'upstream/master'

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zuc: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LGTM label has been added.  Git tree hash: 4eed899dc909ede675e884898a16c386c212cd58

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr, zuc
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Lack bottom line of last row

Mostly, the rows is less than one page, so with hide the footer, but the bottom line of last row is not shown, and the space to below last row seems to large.
  <easy-data-table :headers="headers" :items="items" alternating border-cell
                               show-index hide-footer hide-rows-per-page
                               header-text-direction="center"
                               body-text-direction="center"
              >

@HC200ok , I'm experiencing the same. Could you look into this please.
I noticed that this css is being applied to the last row of the table.


Reduce compile time

Right now compile time is quite long, and we don't have that much code.
Use this issue to track possible performance gains.

I saw that lto was marked true, aka fat, in cargo.toml. Has thin been tested? https://doc.rust-lang.org/cargo/reference/profiles.html#lto

@jo3bingham Thanks for the suggestion. My main concern when opening this issue was mainly CI and not release, which happens less often and we can "pay" the time for better performance.

I have two thoughts on this:

There is a heavy usage of derive macros, specifically with thiserror:Error. I know that these things reduce the need for extra boilerplate code but with the cost of longer compile times. Maybe some of those errors in the error.rs files could be implemented by hand?
Another possibility (although I don't know just by how much this will affect the compile times) is to use dynamic dispatch in places where a static dispatch is applied. For example instead of <H: Hasher> we'll use <&dyn Hasher>, supposedly it should reduce compile times and generally it is better to use this in binaries (vs. libraries).
A lot of this stuff is based on some readings I've done over the course of my rust experience, nothing was actually tested by me personally.

@oren0e Thanks for your suggestions! We'd love to check this out. If you're willing it'd be great to test and see if it benefits compile time and then consider doing the changes.

@aviramha would like to take a stab at this in case nobody else is working on it

@abhirag Awesome! Let us know if we can help in any way :)

Thanks @abhirag for opening the issues, adding it at the original post so we can track (feel free to suggest more everyone :))


How to enable hot-reload?

Hiya! So you think it's broken or missing a feature eh?

[x] Issue does not already exist
Identify exactly what aspect your issue is about

[ ] ignite base application
[x] ignite the cli
[ ] ignite generated code

How to enable hot-reload or at least auto reload?

Press command + D on iOS or command + M on Android, then select hot-reload or automatic reload.
On device you can shake device to get the developer menu as well.

@GantMan Hey, where in the documentations does it tell you about the "command + M" on Android? I'm surprised I had to go into Github issues to find the solution, when this answer ought to be in the documentations, or maybe it is but I failed to find it.

Good question.  I'm sure everyone would take a readme update pull-request if you can identify where that should be stated.
It's one of those things people learn and then take for granted ☹

I'm actually in the process of selecting a react-native boilerplate to migrate our reactboilerplate app into, so I know just about as much as the next person who stumbled upon this repo.
Finding youtube tutorial videos was challenging too, as it seems there are two marketing names? Infinite Red? It's a bit overwhelming to a new user, with a lot of searching around to do.
Would highly suggest to update the README.md with updated documentations and perhaps youtube videos too, i.e. https://www.youtube.com/watch?v=lv00UOXxy0g ought to include the name Ignite in its title, and the video itself doesn't show how hot-reload is enabled, it sort of enabled itself through a pre-script in fast-forward.
Sorry for the rant. Just hoping to provide some helpful feedback.

Hot reloading is a react native feature and the keyboard shortcuts don't change in Ignite. That said, we should probably link to the React Native documentation somewhere in the readme so new users can learn the React Native basics directly from the source.

how to enlble hot-reload on real device not virtual device .. thank you

@Moji0098  on android adb shell input keyevent 82


User should send event when signup is  success

@sirpy There is the SIGNUP_SUCCESS event in the console

Checked on  QA V1.4.1-2
Desktop: Windows 10 // Google Chrome  85.0.4183.121


Requirements not defined

We came across this issue because the our library runs unit tests in the CI pipeline on php 7.1 up to php 8.0. When defining the requirement phpunit/phpunit with * it installs what ever is compatible to the current tested php version. But limedeck/phpunit-detailed-printer * always installs version 6.
In fact phpunit is not just a requirement for developement but also for production. In order to solve that every major version needs an update with the requirement of phpunit version.
If you want I can prepare some merge requests.

Please refer to the version compatibility table. We have a major release of our package for every related major PHPUnit release.

It is not about my ability to read it is about the ability of composer to chose the correct version. Defining a dependency as dev-dependency means that this dependency is only required when I develop phpunit-detailed-printer but this version of phpunit is required when I use phpunit-detailed-printer.
here are two example pull requests: #25 #24


Make FormModels for all forms

Blindly grabbing data from request.POST is not really a great practice. FormModels (which can be seen in the app.forms module) allow us to validate and clean the data we want from a form without having to write all the checks.
Django allows us to display a FormModel in a view as a form, which can make prototyping easier. Django's FormModels are kind of hard to style, though so displaying forms in this fashion in the end product might not be viable.

We can extend the built in form models, but you're using Bootstrap so extending everything is a lot of extra work. This is actually where using django-bootstrap might come in handy. Checkout the documentation: https://django-bootstrap-v5.readthedocs.io/en/latest/


Finish quick replies

Coverage remained the same at 100.0% when pulling fbccfedd02042c7d214a0b6b3ab504bfb937c1ad on feature/quick-replies into be8097c3bcede0f959ede63e100ffa0eace83bff on master.

Coverage remained the same at 100.0% when pulling de5a1366fc804ed6192fcf128b6a3f013e2c8217 on feature/quick-replies into be8097c3bcede0f959ede63e100ffa0eace83bff on master.


Mongo DB items limited to 50 rows

I Have created two different mondo databases with 3200 and 415 rows, respectively.  However the Girder view in candela seems limited to 50 items.

@curtislisle, could you be more specific about what you're seeing? (I'm not sure what "Girder view in Candela" means.)

sorry I wasn’t clear.  I meant when ResLab is showing a girder_db_item, all elements in the dataset aren’t being shown, just the first 50.
When I open the nanoparticles.json, for example, and map it to UpSet in ResLab, the “Dataset information” grey box in the UpSet interface shows “Elements: 50” when there are actually  3270 elements in the mongo collection.
A possible cause could be the mongo query returning with limit=50.

On May 31, 2016, at 8:16 AM, Roni Choudhury<EMAIL_ADDRESS>wrote:
@curtislisle https://github.com/curtislisle, could you be more specific about what you're seeing? (I'm not sure what "Girder view in Candela" means.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ronichoudhury/nci-nanoparticles-vm/issues/5#issuecomment-222671155, or mute the thread https://github.com/notifications/unsubscribe/ACDZ9v6vyFABuR3pfXbUzbpqnxgvPesNks5qHCaZgaJpZM4IqJws.

I had the same thought about the mongo query.
@alex-r-bigelow, is there an easy way to customize the limit parameter in this case?

Whoops! This was totally my bad. I've fixed it here: https://github.com/Kitware/candela/commit/671df6bdd60dc9793674a00c7b24366516d9ad5b
Should I branch / PR this repo as well?

This fix will allow the NCI demo to show all the data but setting limit to 0 doesn't seem like a viable permanent fix right? I just want to make sure that we'll generalize this via UI or something to make a true fix for Resonant Laboratory.
In the meantime, yes please do make a PR for this repo pointing to the fix.

Yes, absolutely—we're planning a filter-aware paging (+sampling?) interface that will do smarter things with limit and offset. But first we'll need to get the filters working :-)


Proposal: Transient

There's serializeonly and deserializeonly (which is the most similar), but maybe for semantics and clarity it would be useful to have a transient one that just exludes a field from any serialization.

Makes sense. I assume you want this for auto-value-moshi.

That annotation should have only method as a target since Moshi supports transient on member variables out of the box.


Identifiers validation failed for dataset Análisis del ictioplancton del ecosistema costero de Celestún, Yucatán, México

Identifier validation failed for the dataset Análisis del ictioplancton del ecosistema costero de Celestún, Yucatán, México:

Crawler attempt: 308
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 181
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 181 total records; 181 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3740099/step

New IDs sample:

Old IDs sample:

0a9993469fcc923023812382c103a5a8
0faf616bfb2fe28f580743a4c1fb78be
32d094440eec362ef2563b7fd4470fea
3852daca188f62f086afe48512c3eb34
4a52613e8296daf02ec098ed562cd389
4f46360ecad7dd228f55ff1fe3c32679
5100f82a95c97fe209cfed3c65e46b2f
6af4c16b7dc2d48b620c5e7c4edb3807
829f816ace9971d8f665e971d40f3c77
83109d8d766b3f10c9ab2e0c3ab14c14

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Análisis del ictioplancton del ecosistema costero de Celestún, Yucatán, México : https://doi.org/10.15468/xsdpdy.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Análisis del ictioplancton del ecosistema costero de Celestún, Yucatán, México:

Crawler attempt: 309
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 181
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 181 total records; 181 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3741061/step

New IDs sample:

Old IDs sample:

0a9993469fcc923023812382c103a5a8
0faf616bfb2fe28f580743a4c1fb78be
32d094440eec362ef2563b7fd4470fea
3852daca188f62f086afe48512c3eb34
4a52613e8296daf02ec098ed562cd389
4f46360ecad7dd228f55ff1fe3c32679
5100f82a95c97fe209cfed3c65e46b2f
6af4c16b7dc2d48b620c5e7c4edb3807
829f816ace9971d8f665e971d40f3c77
83109d8d766b3f10c9ab2e0c3ab14c14

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Análisis del ictioplancton del ecosistema costero de Celestún, Yucatán, México : https://doi.org/10.15468/xsdpdy.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Análisis del ictioplancton del ecosistema costero de Celestún, Yucatán, México:

Crawler attempt: 311
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 181
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 181 total records; 181 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3741673/step

New IDs sample:

Old IDs sample:

0a9993469fcc923023812382c103a5a8
0faf616bfb2fe28f580743a4c1fb78be
32d094440eec362ef2563b7fd4470fea
3852daca188f62f086afe48512c3eb34
4a52613e8296daf02ec098ed562cd389
4f46360ecad7dd228f55ff1fe3c32679
5100f82a95c97fe209cfed3c65e46b2f
6af4c16b7dc2d48b620c5e7c4edb3807
829f816ace9971d8f665e971d40f3c77
83109d8d766b3f10c9ab2e0c3ab14c14

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Análisis del ictioplancton del ecosistema costero de Celestún, Yucatán, México : https://doi.org/10.15468/xsdpdy.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


Call directly with any transform like below.
transform.Clear();

looks good to me, thanks for the contribution


Bump up version 0.1.3 for release

Codecov Report

Merging #218 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #218   +/-   ##
========================================
  Coverage      70.2%   70.2%
  Complexity      483     483
========================================
  Files            67      67
  Lines          2541    2541
  Branches        267     267
========================================
  Hits           1784    1784
  Misses          659     659
  Partials         98      98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31cf60e...791aacf. Read the comment docs.


'pathtimema' attribute in get_nhdplus()

Hey Dave, more of a question but curious what pathtimema is within the output in get_nhdplus()? Thanks!

Asked around and it sounds like that may be the same as the TOTMA as documented here: https://edap-ow-data-commons.s3.amazonaws.com/NHDPlusV21/Data/NationalData/0Release_Notes_NationalData_Seamless_GeoDatabase.pdf
Looking at the data, those two are all different values. So 🤷♂ Will keep asking.

Thanks. Yeah thought that was strange too…

@joshualerickson  -- I heard from a colleague that it is an oversight in the documentation.

PathTimeMA is the time in days it takes to get from your current location to the end of the network.

Ahhhh, ok that makes more sense. Thanks!

PathTimeMA is the time in days it takes to get from your current location to the end of the network. —The variable was added to the NHDPlusV2  somewhat last minute but not documented in the NHDPlusV2 users manual.
I just opened this issue to track this and will get it into some nhdplusTools documentation. https://github.com/DOI-USGS/nhdplusTools/issues/413
Dave L USGS


Consecutive Gateway Failure outlier detection ejects WebSocket endpoints on graceful connection close

Title: Consecutive Gateway Failure  outlier detection ejects WebSocket endpoints on graceful connection close
Description:
Consecutive Gateway Failure  outlier detection ejects WebSocket endpoints on graceful connection close.
Repro steps:

Enable Consecutive Gateway Failure  outlier detection for WS upstream cluster
Open a WS connection and gracefully close

echo foo | websocat ws://localhost/ws

Config:
lds.yaml
filter_chains:
  - filters:
    - name: envoy.http_connection_manager
      typed_config:
        "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
        stat_prefix: ingress_http
        upgrade_configs:
          upgrade_type: websocket

        codec_type: AUTO

        http_filters:
          - name: envoy.filters.http.router
            typed_config:
              "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
        route_config:
          name: ws
          virtual_hosts:
            - name: ws
              domains: ["*"]
              routes:
                - match:
                    prefix: /ws
                  route:
                    cluster: ws
                    prefix_rewrite: /

cds.yaml
resources:
  - "@type": type.googleapis.com/envoy.config.cluster.v3.Cluster
    name: ws
    outlier_detection:
      interval: 2s
      consecutive_gateway_failure: 1
      enforcing_consecutive_gateway_failure: 100
      base_ejection_time: 2s
      max_ejection_time: 2s
    load_assignment:
      cluster_name: ws
      endpoints:
        - lb_endpoints:
            - endpoint:
                address:
                  socket_address:
                    address: <IP_ADDRESS>
                    port_value: 9910

Logs:
app log
[159][debug][conn_handler] [source/server/active_tcp_listener.cc:147] [C3] new connection from <IP_ADDRESS>:58836
[159][debug][http] [source/common/http/conn_manager_impl.cc:306] [C3] new stream
[159][debug][http] [source/common/http/conn_manager_impl.cc:930] [C3][S7468752995169847881] request headers complete (end_stream=false):
':authority', 'localhost'
':path', '/ws'
':method', 'GET'
'connection', 'Upgrade'
'upgrade', 'websocket'
'sec-websocket-version', '13'
'sec-websocket-key', 'jj7EkpIJfFGA/Ycw7L1ZZw=='

[159][debug][connection] [./source/common/network/connection_impl.h:92] [C3] current connecting state: false
[159][debug][router] [source/common/router/router.cc:470] [C3][S7468752995169847881] cluster 'ws' match for URL '/ws'
[159][debug][router] [source/common/router/router.cc:678] [C3][S7468752995169847881] router decoding headers:
':authority', 'localhost'
':path', '/'
':method', 'GET'
':scheme', 'http'
'connection', 'Upgrade'
'upgrade', 'websocket'
'sec-websocket-version', '13'
'sec-websocket-key', 'jj7EkpIJfFGA/Ycw7L1ZZw=='
'x-forwarded-proto', 'http'
'x-envoy-internal', 'true'
'x-request-id', '83455f65-2ae3-4d79-a28e-14181fd1096b'
'x-envoy-expected-rq-timeout-ms', '15000'
'x-envoy-original-path', '/ws'

[159][debug][pool] [source/common/http/conn_pool_base.cc:78] queueing stream due to no available connections (ready=0 busy=0 connecting=0)
[159][debug][pool] [source/common/conn_pool/conn_pool_base.cc:290] trying to create new connection
[159][debug][pool] [source/common/conn_pool/conn_pool_base.cc:145] creating a new connection (connecting=0)
[159][debug][connection] [./source/common/network/connection_impl.h:92] [C4] current connecting state: true
[159][debug][client] [source/common/http/codec_client.cc:57] [C4] connecting
[159][debug][connection] [source/common/network/connection_impl.cc:924] [C4] connecting to <IP_ADDRESS>:9910
[159][debug][connection] [source/common/network/connection_impl.cc:943] [C4] connection in progress
[159][debug][connection] [source/common/network/connection_impl.cc:683] [C4] connected
[159][debug][client] [source/common/http/codec_client.cc:88] [C4] connected
[159][debug][pool] [source/common/conn_pool/conn_pool_base.cc:327] [C4] attaching to next stream
[159][debug][pool] [source/common/conn_pool/conn_pool_base.cc:181] [C4] creating stream
[159][debug][router] [source/common/router/upstream_request.cc:564] [C3][S7468752995169847881] pool ready
[159][debug][router] [source/common/router/router.cc:1371] [C3][S7468752995169847881] upstream headers complete: end_stream=false
[159][debug][http] [source/common/http/conn_manager_impl.cc:1551] [C3][S7468752995169847881] encoding headers via codec (end_stream=false):
':status', '101'
'upgrade', 'websocket'
'connection', 'Upgrade'
'sec-websocket-accept', 'vvzZD2L5yLMhIP/7YsDaw2W/jbc='
'date', 'Tue, 27 Dec 2022 11:48:10 GMT'

[159][debug][connection] [source/common/network/connection_impl.cc:651] [C4] remote close
[159][debug][connection] [source/common/network/connection_impl.cc:250] [C4] closing socket: 0
[159][debug][client] [source/common/http/codec_client.cc:107] [C4] disconnect. resetting 1 pending requests
[159][debug][client] [source/common/http/codec_client.cc:156] [C4] request reset
[159][debug][router] [source/common/router/router.cc:1212] [C3][S7468752995169847881] upstream reset: reset reason: connection termination, transport failure reason:
[159][debug][http] [source/common/http/filter_manager.cc:894] [C3][S7468752995169847881] Resetting stream due to upstream_reset_after_response_started{connection_termination}. Prior headers have already been sent
[159][debug][http] [source/common/http/conn_manager_impl.cc:212] [C3][S7468752995169847881] doEndStream() resetting stream
[159][debug][http] [source/common/http/conn_manager_impl.cc:1604] [C3][S7468752995169847881] stream reset
[151][debug][upstream] [source/common/upstream/cluster_manager_impl.cc:1179] membership update for TLS cluster ws added 0 removed 0
[151][debug][upstream] [source/common/upstream/cluster_manager_impl.cc:861] host <IP_ADDRESS>:9910 in cluster ws was ejected by the outlier detector
[159][debug][connection] [source/common/network/connection_impl.cc:139] [C3] closing data_to_write=0 type=0
[159][debug][connection] [source/common/network/connection_impl.cc:250] [C3] closing socket: 1
[159][debug][conn_handler] [source/server/active_stream_listener_base.cc:120] [C3] adding to cleanup list
[159][debug][pool] [source/common/conn_pool/conn_pool_base.cc:483] [C4] client disconnected, failure reason:
[159][debug][pool] [source/common/conn_pool/conn_pool_base.cc:453] invoking idle callbacks - is_draining_for_deletion_=false
[159][debug][pool] [source/common/conn_pool/conn_pool_base.cc:214] [C4] destroying stream: 0 remaining
[159][debug][upstream] [source/common/upstream/cluster_manager_impl.cc:1179] membership update for TLS cluster ws added 0 removed 0

outlier detection event log
{"type":"CONSECUTIVE_GATEWAY_FAILURE","cluster_name":"ws","upstream_url":"<IP_ADDRESS>:9910","action":"EJECT","num_ejections":1,"enforced":true,"eject_consecutive_event":{},"timestamp":"2022-12-27T11:48:10.950Z"}

I would think we're not observing the close socket frame and using it to recognize the graceful shutdown and just treating it as an abrupt connection termination, seems like something we should be able to do.
cc @alyssawilk
A short term solution might just be to increase your consecutive errors to more than 1 - that way you'd only trip the outlier detection if the connections repeatedly fails within a short period of time.

I looked at the events happening on the wire and a client sends ws opcode 8 (Connection close) to the server. The server sends TCP FIN which is interpreted as RemoteClose. It is local origin event and is mapped to HTTP code 503 which lands in outlier detector as gateway error. I will try to fix it.

It appears that Envoy does NOT parse websockets headers. The codebase contains websocket codec, which could be used to catch opcode 8 (FIN/Connection Close) coming from the server and "prepare" for TCP FIN coming from upstream, but that codec seems to be not used and not linked into the binary.

https://github.com/envoyproxy/envoy/issues/33398

Hi, we recently encountered this issue where a graceful WS close (code 1001) was detected as failed endpoint after the TCP socket was closed. Seems that envoy considers that the "http response headers" were not received before closing the tCP connection, thus the outlier.
Looking at the code I'm not sure how to fix this. Seems a bigger development than my C++ skills can handle.
Let me know if someone plan to fix this and if I can help. @cpakulski did you manage to have somth working ?
Thanks

@hypnoce It is still an issue. Fixing it requires adding websockets parser to detect that client requests server to close the connection and not interpret server's FIN as error.


Cats Build Deletes Master Documentation

This needs to be addressed before any changes are merged into the cats branch.
Area of problem is in Http4sGHPages
I am working on this at the moment, but any new builds on cats will delete master branch documentation.

The quick hack is in Http4sGhPages.  The cleaner solution, I think, is #972.

Closed By #1033 Hopefully cleaner implementation soon.


What if my source code is the root of the repo?

Do I use "." as the source code path or...?
I know it's not great practice, but I'm not redoing my file structure; it's bound to break something.

Using the path as . should work without any issues, let me know how it goes

I'll try it if I find the time.

I just tested this out and it does work but make sure you change actions/upload-artifact@v2 path as well!
- uses: actions/upload-artifact@v2
        with:
          name: package-name
          path: ./dist/linux

Yup, confirmed it works a few months ago, forgot to update the issue ^^"


View Formatting Applied to Grouped View Prevents Display of Grouped Documents In Library

Category

[x] Bug

Describe the bug
The mere presence of any JSON view formatting in a grouped view prevents the display of any of the items that are grouped!  How silly.

Steps to reproduce

Create a new view in a document library.
Ensure that it is grouped view.
Save the view.
Ensure the grouped view is working properly by navigating to that view.
add the following JSON formatting to the grouped view:

{
  "schema": "https://developer.microsoft.com/json-schemas/sp/view-formatting.schema.json",
  "hideSelection": true,
  "hideListHeader": true
}

Expected behavior
Expected behavior = the same behavior as a grouped view without JSON view formatting.
Developer environment

OS: Windows 10 (client),
Framework: none (JSON is not a framework)
Browser(s): Chromium Edge v80, Chrome v80, IE11
Tooling: [e.g. VS Code, SPFx v1.10.0, Visual Studio 2019]

Additional context
SharePoint Online Production Tenant.

@Freddy-Crypto We are unable to repro this locally, with the steps provided. Could you please check if you are able to repro this?


[New feature] Add support for motion and door sensors

Do you have any plans to start supporting sensors as well?
Looks like you have everything that is necessary to get it going.

i'll have a pull request for you this weekend to add support for the sensors. i got it working.

Awesome! I don't currently have any sensors to test with so no plans at the moment, but if you submit a PR I'll review it 😃

Hey Misen,
Great job with light bulbs! They work flawlessly.
I have submitted PRs for Wyze Sense and Wyze Cam :)
I will be more than happy to contribute to get the devices if required.

i will submit a PR for the 2 sensors soon.
also took the chance and implemented support for the 2FA. am just polishing
the error handling to provide better error messages.
On Sun, May 17, 2020 at 03:18 Sheikh Abdullah<EMAIL_ADDRESS>wrote:

Hey Misen,
Great job with light bulbs! They work flawlessly.
I have submitted PRs for Wyze Sense and Wyze Cam :)
I will be more than happy to contribute to get the devices if required.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/misenhower/homebridge-wyze-connected-home/issues/2#issuecomment-629754787,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB23T6LV5OP3CC3NQ6LQSBDRR6FUBANCNFSM4NAJV3CA
.

--
Pedro Carneiro

Sounds great, thanks for your effort on this!

i love the new integrations!


chore(master): release 2.7.14

:robot: I have created a release beep boop
2.7.14 (2024-09-30)
Dependencies

deps: update actions/checkout action to v4.2.0 (0b75e67)
deps: update docker/bake-action action to v5.9.0 (e7d8a5b)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.7.14
:sunflower:


results: Add Exynos 9820 results

taken from a beyond1lte

nvm it makes no sense it's drawing negative amounts of power


feat: Prepare volume for local git repo

Signed-off-by: yuchengde<EMAIL_ADDRESS>feat: Prepare volume for local git repo

This is coming soon as part of upcoming release


Remove set_STMF_CCSID from def_rules.mk

Tongkun has clarified that these are no longer necessary since all the source files are assumed to be utf8
https://ibmidevelopment.slack.com/archives/D022AT98HEF/p1664896442769039
https://ibmidevelopment.slack.com/archives/D022AT98HEF/p1666216957101949

addressed by commit https://github.com/IBM/ibmi-bob/commit/de90c3d767f847ff6817819f26bd4d5fe17eb759


Build(deps-dev): Bump @types/node from 16.11.10 to 16.11.11 (#2042)

Pull request opened by the merge tool on behalf of #2042

Merged in 5b27894eee8fa62466be068fb4f3aa52e35db721


MB-8493-add-search-to-offices-page

Description
Added a search feature to the offices page in the Admin console. An admin user can now log into the console and search for offices by name in the admin page.
Additionally an integration test was created to test the page.
Finally, offficeList.jsx was moved into the pages folder in the codebase to as was the convention for the other pages in the Admin console.
Setup
To run the cypress test
make e2e_test

Select the Offices folder in the popup window and watch the test run.T

To test the feature locally, run the server make server_run and the client make admin_client_run. Then login using the Local Login, and navigate to the Offices page.
References

Jira story for this change

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

Messages

:book:
:link: MB-8493

  Generated by :no_entry_sign: dangerJS against 696b64960b971da2651746ef385747355f31d9c7

LGTM! Thanks for making those changes!

Absolutely! I learned a lot because of your feedback. Thank you!


Code review

I noticed a few more things in #49.
Each of my commit messages explains the individual changes.
The before last commit is a bit bigger. I can remove it from the PR if appropriate.

Also, shouldn't the type choices be used to render the buttons? It's confusing that the human-readable name of each choice in forms.py isn't used in the template (the template hard-codes each choice, instead of looking over the choice options).

You're right. I think I chose to do it that way because I couldn't find a way at the moment to add Bootstrap styles to the HTML generated by Django. I'll change that so the readable names will be in a single place.

@jpmckinney can you please have a look before merging?

Perfect, thanks!


Fix edit leverage modal and dynamic fee updates

Fixes 1 & 3 here: https://github.com/Kwenta/kwenta/issues/1744

Only market is shows, I assume some tiny dynamic fee % still applying?


AMLOGIC-629 : DisplayInfo.displayinfo returns inverted 4K resolution

AMLOGIC-629  : corrected the height and width parameters

Can we have this patch on the master as well ?

Can we have this patch on the master as well ?

Created https://github.com/rdkcentral/rdkservices/pull/258


Support clang bootstarp use ninja

look https://github.com/llvm-mirror/llvm/blob/master/utils/release/build_llvm_package.bat

require test
See commit

https://github.com/fstudio/clangbuilder/commit/54fba64c29fb69a8295ff437bfdd91fde075d83a
https://github.com/fstudio/clangbuilder/commit/66a4b0d75fa4ced55d874720c4c17badcb587fc6

ninja check failed not exit， bootstrap success


Few feature requests..

Firstly, I’d love to see the ability to save the downloaded LLM’s to be saved on external drives. I tried to download an AI on my SSD but, when I loaded onto LLM Farm, it copied the file and placed it into On My iPhone >> LLM Farm >> Models. (In other words, I want it so I get to choose where the LLM is downloaded and saved instead of being fixed to LLM Farm >> Models). Secondly, I would love to see iOS Siri Shortcuts integration. Lastly, I couldn’t seem to get the Qwen AI model to work. No matter how hard I tried and how much I looked, it kept giving errors.

@guinmoon

Maybe someday I'll realize it all.
The Qwen models have been discussed here.

Maybe someday I'll realize it all. The Qwen models have been discussed here.

Thanks for the reply! I’ll take a look at the qwen thing.


Dynamically retrieve base module name

With this commit, we update operator_build role to dyynamically retrieve base module name, mod can be either /api or /apis. For ex. infra-operator have apis.
As a pull request owner and reviewers, I checked that:

[X] Appropriate testing is done and actually running

/hold
need further changes

/unhold
Content provider which was earlier failing on PR[1] passed with depends-on this parch.
[1] https://github.com/openstack-k8s-operators/infra-operator/pull/66

/assign @viroel

recheck
failed on tempest
https://logserver.rdoproject.org/28/328/7b6d4a6afec56f6399a0a8312b6435fd92a91eb7/github-check/cifmw-end-to-end/2539e88/job-output.txt

]$ git clone https://github.com/openstack-k8s-operators/openstack-operator.git

$ cd openstack-operator/

$ grep github.com/openstack-k8s-operators/infra-operator/api go.mod
	github.com/openstack-k8s-operators/infra-operator/apis v0.0.0-20230615131203-9a25d21f088c

$ basename github.com/openstack-k8s-operators/infra-operator/apis v0.0.0-20230615131203-9a25d21f088c
apis

~~~

Rebasing the patch to fix tempest issue on end-to-end job

recheck

/approve


Removing buddha bowl and fixing menuline, date changes. Closes #9

Awesome! Thanks! What does the "Removing buddha bowl" in the PR title mean? I don't see anything in the PR regarding the Buddha bowl...

Ah, I see. The Budda Bowl was removed from the fixture. Got it.


Compatibility with python 3

Are there any workarounds to make the package work with python 3?
Do you have any plans of building a version which works with python 3?

There is a branch with the needed changes, but it is not tested enough, and it includes some heavy rework on matlab parsing that is unfinished. I can try to split the branch into py3 and parser changes. Unfortunately I do not have much time these days, so it will need to wait for a while. Feel free to play with that branch though.

It would be nice to have support for python3. Im working on it but no success.
Do you guys have more luck ?

The branch with python 3 updates still doesn't work. I suppose nobody worked on it anymore. also it seems from matlab 2023 onward python 2.7 is not supported for matlab engine. I want to ask if anyone has any update on this, I might decide to work on it if nobody else has


Exception Handling for UrlRewrite, more tests, small bug fixes

Adds exception handling with position in file for format exceptions.
Adds tests for Server Variables and new Format Exceptions (just see if they are thrown).
Small bug fix on InputParser for closing brace
Fix for users that optionally add a leading slash for url attribute

Uncertain about how to format xml strings for test (what is the recommended way).
Also do I need everything in the Resources.resx file?

@Tratcher @davidfowl :tada:

/cc @Eilon for english review

:shipit: pending any feedback from @Eilon

:shipit:

:shipit:


Deserializing Tests to Examples

Depends on branch expectedValue being merged into plcte-2020
Add deserialization of basic tests and method tests

I created this branch from develop but should have done it from plcte-2020.
Will remove this PR and create it new


Rename counters to counters_path

Fixes #530.
SnabVMX's end-to-end.sh script was not regenerating counters correctly because the variable name that held the path to counters file was incorrectly named, thus snabbvmx check received nil as counters path and didn't regenerate counters.

This is a PR on your own repo; is it relevant @dpino ?


Added favicon in simulator

Fixes #Minor Issue
Describe the changes you have made in this PR -
Added favicon in simulator
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Coverage remained the same at 88.146% when pulling 923e5a8baf9950bf55ae96d6bf536577766c905a on nileshdas:favicon into f0728cef69d0e4b5f2c9968ee79cceb8539f85a9 on CircuitVerse:master.

Thanks 👍


Fixing 60 parameter limit error on graphql api create.

Issue #, if available:
https://github.com/aws-amplify/amplify-cli/issues/99
https://github.com/aws-amplify/amplify-cli/issues/11
Description of changes:
These changes stop the bleeding on issues https://github.com/aws-amplify/amplify-cli/issues/99 and https://github.com/aws-amplify/amplify-cli/issues/11. This reorganizes the transform so only 3 parameters are needed to configure the resolver s3 locations instead of (2 x the number of resolvers). This is still not a long-term fix and I suspect the next limit we hit will be the max of 200 resources per stack. I am also working on another solution that uses nested stacks but this will take a bit longer to finish.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mikeparisstuff  We should document these limitations.

@kaustavghosh06 We can document the CF limitations but ideally will get the nested stack stuff implemented so its not an issue.

if we have an older project that is hitting this limit will updating the cli solve this issue or do we need to create a new project ?


Added admission-webhook-k8s etc.

admission-webhook-k8s deployment and service added.
exclude-prefixes container added to NSMGR pod.
Forwarder reconciler is fixed.
Multi-forwarder scenario is implemented properly.
Updated samples to work with new variables.

Same issue here. I expect PRs to contain a minimal amount of commits or if possible just one with the key change that PR is doing. There quite some commits duplicated here. Can you clean this to the only commits necessary to this change? If needed you can rebase it with the recently merged #52

I marked this one as draft and will rebase when #53 will be merged on the master.
Next time I will create smaller PRs with minimal commits but this time there was too long time without merging and I added many things gradually based on each others.

Same issue here. I expect PRs to contain a minimal amount of commits or if possible just one with the key change that PR is doing. There quite some commits duplicated here. Can you clean this to the only commits necessary to this change? If needed you can rebase it with the recently merged #52

I marked this one as draft and will rebase when #53 will be merged on the master. Next time I will create smaller PRs with minimal commits but this time there was too long time without merging and I added many things gradually based on each others.

Got it! Thanks again! So #53 is merged now. You may cleanup the commits and I will review it.

Got it! @szvincze Thanks again! So #53 is merged now. You may cleanup the commits and I will review it.
@acmenezes: Now it contains only the needed 5 commits, however not small ones but hopefully not too chaotic.

I accidentally approved this. But check on the comments. There are some requested changes.
Sure, I will work on the changes and come back for review.

@acmenezes I sent another commit with the changes you requested. Please review it.


vue-template-compiler installed despite no reference to Vue

Laravel Mix Version<EMAIL_ADDRESS>Node Version (node -v): v11.4.0
NPM Version (npm -v): 6.4.1
OS: macOS 10.13.6

Description:
I suspect starting in 4.0.10 with the introduction to this commit, vue-template-compiler appears to be installing despite the project not using Vue nor having any reference to it whatsoever.

vue-template-compiler has always been included with Mix. You're just seeing it more directly now. mix.js() does assume a Vue application, even if it doesn't require it.

I do not want to have vue-template-compiler dependency in my package.json file. Can it not be forced to install?

I would like to see an option to turn this off. In #1891 @JeffreyWay mentioned that Laravel Mix was build with Vue in mind but the current documentation indicates that it's more a universal build tool to make configuration with Webpack easier. Getting vue-template-compiler force installed via Yarn even if I do not use any Vue and not using Yarn is irritating especially for starters.
If there is an option to turn this off or properly configure it, I would be pleased to get to know it. :)

A quick fix that I found that was especially helpful for me was to use the mix.scripts method. This assumes an array of files to combine and does not install any vue dependencies.
webpack.mix.js looks like this:
mix.scripts(['resources/js/app.js'], 'public/js/app.js')
   .sass('resources/sass/app.scss', 'public/css');

If you're writing ES6+ JS like I am you can also use the mix.babel() which works actually the same but will use plugins like babel-loader to transform ES6+ code.
Hope this helps :smile:

Unfortunately, if you want to use the import keyword, you need modules and you need webpack, so you need to use the .js function.
I did a PR as mentionned above, but if it's not merge soon, you can use this hack (I checked the code of the library. If you're not using vue, it should not cause any issue, if you're using vue why are you reading this issue first?)
const JavaScript = require('laravel-mix/src/components/JavaScript');

class JS extends JavaScript {
  dependencies() {
    return [];
  }
}

mix.extend('js', new JS());

It's not very pretty but at least it works, at least for laravel-mix:4.0.7. It's just ignoring the 'vue-template-compiler' dependency required by the JavaScript component (that is based on the Vue one), and which is the only current dependency of this components.

Laravel-Mix is great, That's why I used it for another non-laravel project. But the project doesn't need Vue, how to disable this when running yarn dev?

Normally it should have been removed in version 5 as this comment shows https://github.com/JeffreyWay/laravel-mix/pull/2339#issuecomment-700261567. So try to upgrade your version, otherwise I don't have any idea.

@paullaffitte I think it still there.
Now I'm using a new laravel scaffolding with "laravel-mix": "^5.0.1", inside the package.json and it still installing vue-template-compiler.

Yeah, looks like this still is the case with "laravel-mix": "^5.0.1" .. the first time you run yarn install it will add vue-template-compiler.

Sorry I meant version 6 actually, I just edited my answer.

Here is another approach for non Vue projects. Add below lines in webpack.mix.js before build steps.
Seems to work in laravel-mix 5.
mix.override(function (webpackConfig) {
    webpackConfig.plugins = webpackConfig.plugins.filter(plugin => plugin.constructor.name !== 'VueLoaderPlugin');
    return webpackConfig;
})


Bug command git

Hi,
For me, there is a bug when I run a git pull or push command on the ssh terminal. It is stopped and it is not possible to execute more commands, nor have ctrl + c to cancel. What can it be?
The: windows 10
Terminus version: 1.0.1

I have exactly the same problem on Windows 10 Terminus 1.0.65.

Duplicate of #496


Attempted to call an undefined method named "getStubPath"

when i try to make migration  php app/console eloquent:migrate:make create_flights_table

Thanks for the report!
You seem to have installed this bundle with Laravel 5.4. This is currently not yet supported. This will be fixed by: https://github.com/wouterj/WouterJEloquentBundle/pull/48 Please use 1.0@dev of this package. This will install Laravel 5.3 for now and Laravel 5.4 as soon as the other PR is merged.
After fixing #6 (which I hope to do today), I'll release 0.4.0.

Unfortunately, a BC break between 5.3 and 5.4 keeps this bundle from supporting both versions. I've now moved Laravel 5.4 support to 0.5.0 (hoping to release 0.4.0 this week).


keep the state of healthy

Before the final value for healthy was only being determined based off of the last item to be health checked. Now it will keep the state of healthy so if one of the services is unhealthy then the whole health check will fail.

When will you release an updated version of the package with this change?

On Aug 1, 2017, at 2:22 PM, Luis Ruiz Pavon<EMAIL_ADDRESS>wrote:
Merged #8.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@lurumad any idea when you will be releasing the newest version of this package?

Sorry! I'm on holiday :) As soon as I return to Madrid ;)

Next Tuesday, sorry.

Not a big deal just wondering! Thank you! :)

On Aug 11, 2017, at 2:42 PM, Luis Ruiz Pavon<EMAIL_ADDRESS>wrote:
Next Tuesday, sorry.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@lurumad any update on this? sorry to keep bothering you

Hi @rlm95
I've published a new version of the package.
I don't know if I'm going to maintain this package because Microsoft is thinking about to add this one https://github.com/dotnet-architecture/HealthChecks and maybe is better to participate.
Regards!


Add an ES2018 Target and Lib

This should include any features we support which are slated for the 2018 spec release (currently stage 4 proposals), or things we think are likely to be in it (ie, promising stage 3 proposals).

PRs welcomed if someone wants to get to this before @weswigham does.

I will provide a pull request for this. First contribution incoming ^^

thanks @benbraou!


Revert "Move some interactive prompt handling from the daemon to the client (#28146)"

This reverts commit e2ff64ec438f2cae05df39d5bd173ed0eb92557a, reversing changes made to 6a7d8106036c303962e12c70e1b925ae19dc9a52.
See https://github.com/gradle/gradle-private/issues/4131

The merge queue build has started. Click here to see all failures if any.


[Feature]: take control of es_key

What would you like to see added to NeuroConv?
RecordingInterface classes should manage their own es_key
Is your feature request related to a problem?
No response
Do you have any interest in helping implement the feature?
Yes.
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Have you ensured this bug was not already reported?

This issue requests removal of es_key from the call signature of all RecordingInterface.run_conversion methods, instead hard-coding the es_key passed to the neuroconv.tools.spikeinterface.write_recording to whatever the es_key happens to be set as for that interface's metadata
I don't think this would cause any issues with interface usage, but I wanted to check with @weiglszonja and @h-mayorquin to see if you guys might recall any times when you may have needed to use a custom override of that argument within a conversion script


Notifier fields in error messages should match field names in UI

Rancher versions: 2.0 master 2/22
Steps to Reproduce:

Go to Add Notifier
Click on OK without entering any info in fields

Results:  Names in error messages for Slack don't match field names.
Slack:

Fixed

Version - 2.0 master 2/23
Verified fixed


Thoughts on exec'ing Murmur process

I currently have a Cron job which blindly restarts my Murmur container the first Monday of each month in order to reload LetsEncrypt certificates.
Now that Murmur 1.3 is provided with support for SIGUSR1 to live-reload certificate information, I'd like to perform something simple like:
$ docker kill --signal SIGUSR1 mumble-server

Which will send the specified signal to PID 1. However, this image has the docker-entrypoint.sh as the first process which forks off murmur, having no effect.
Are you open to changing:
https://github.com/sudoforge/docker-images/blob/b15e058596f6dc4ac00217186841433766ccb5ea/mumble-server/docker-entrypoint.sh#L106
to:
exec /opt/murmur/murmur.x86 -fg -ini "${CONFIGFILE}"

Another option is to trap SIGUSR1 in docker-entrypoint.sh and it sending kill -s SIGUSR1 $(pgrep murmur) (or whatever other method is desired).

Great suggestion! In my opinion, exec-ing would be a bit cleaner. I sent up a patch to try this out (I don't foresee any issues).


flaky tests TestSyncLightWithTrustedPeers and TestSyncLightWithBridge

https://gist.github.com/liamsi/8ff1c98dde9ba39160b40124c96ab036

2022-04-11T08:51:31.688Z	ERROR	node	node/node.go:97	starting Full Node: listen tcp <IP_ADDRESS>:26658: bind: address already in use
    sync_test.go:262:
        	Error Trace:	sync_test.go:262
        	Error:      	Received unexpected error:
        	            	node: failed to start: listen tcp <IP_ADDRESS>:26658: bind: address already in use
        	Test:       	TestSyncLightWithTrustedPeers

This comes from the fact that an RPC server is started on every node on that exact port. We should make the port configurable so that it can be set randomly for testing + CI

Closed @renaynay ?

Fixed by #617


Dashboard prototype

I will pull out artifact_to_names into separate PR with tests.  Leaving this as a "draft" PR for the time being.

Thanks for starting this @marcopalmeri! I'm going to close this for now since it looks like there are a lot of conflicts, but I think we can take a look back at the last few commits when/if we add the dashboard.


Document the 'detail' option for skate.emit

Add a short section to document the detail option for eventOptions in skate.emit

Was asked how to do this and realised it was missing from the docs, so here it is.

lgtm


Steps to create phone (vertical layout) in PBI Service needed

The title leads us to believe that for reports, we can adjust and optimize for phone (vertical) layout in the service, but the directions only specify how to do this in the desktop app.  Can reports be optimized post deployment to the service, or is it only dashboard that can be optimized post deployment.
If phone view can only be defined for Reports in Desktop, the intro paragraph should be more clear.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2f3739d4-b66c-1e13-4c4a-35990764216c
Version Independent ID: 7c8e7cf4-4778-8871-bad0-452bb2edb36c
Content: Optimize reports for the Power BI mobile apps - Power BI
Content Source: powerbi-docs/create-reports/desktop-create-phone-report.md
Service: powerbi
Sub-service: powerbi-desktop
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Great feedback, @alwweb ! Yes, you can create a mobile layout for reports and dashboards in the Power BI service. I'll make that clearer in the article. Thanks!

Hi @alwweb , I've taken your suggestion and made a few changes to the article that I hope make it more clear that the mobile layout view is available in both Power BI Desktop and the Power BI service. The changes will go online soon.
Thanks for your input!


Init colors & selected position via XML

I added possibility to provide colors via XML. Also, made some changes depending on View.isInEditMode() (to prevent LineColorPicker from parsing defaults color array)

@noties  I will review your commit shortly


#1966 - Highlight games with friends

Closes #1966

Demo

Personally I am not really a fan of adding another check box to the top of the games table especially as it has a rather long name.

@Sheikah45 Any ideas or suggestions?

I wonder if just having it always been on as like a property of the game would be good or adding an icon that can just be displayed like the lock for private games

@Sheikah45 Maybe simply to paint current/max players label to green color?

I do not want to add the icons because the table is overloaded

Maybe or the title. But I don't mind the background highlighting you already have. Although it may not be apparent what it means when people first see it

Maybe or the title. But I don't mind the background highlighting you already have. Although it may not be apparent what it means when people first see it

The title and number of players with green color looked unethical. So I decided to leave the background highlighting unchanged.

Went ahead and changed it myself


Make links of the tag description in the tooltip clickable

Links of the tag descriptions (table.json file) are not clickable in the tooltip.
In the detail view the link (description for MIT) is clickable

but in the tooltip the link is not clickable.

Closed with commit on July 5th.