Patch diem-core 1.3.0

Info:
/// Dev. branch:
https://github.com/OLSF/libra/commits/v5
/// Upstream commit being patched:
diem-core-v1.3.0 - July 7, 21
https://github.com/diem/diem/commits/diem-core-v1.3.0
Next Actions:

[x] Merge v5_old_diem-1.2.0 into diem-core 1.3.0, resolve all conflicts
[x] cargo clean, cargo b --all and cargo b --all-targets
[x] Use cargo c instead of cargo b for quick iteration
[x] Resolve all Move modules/transaction scripts errors, build diem-framework -> ol\utils\build-stdlib.sh
[x] Resolve all Rust build errors for all packages ->  cargo b --all and cargo b --all-targets
[x] [9 remaining] Fix // 0L todos if possible
[x] [2 fails remaining] Get all move-lang-functional-tests build & pass -> PRETTY=1 cargo test -p move-lang-functional-tests -- 0L/ > /opt/27.jul.txt 2>&1 (start w/ chained_from_genesis or persistence)
[ ] Get move-lang-functional-tests changes reviewed
[x] [1 fail remaining] Get all e2e tests build & pass -> PRETTY=1 cargo test -p language-e2e-testsuite -- --nocapture ol_
[x] Get swarm working - with one problem -> https://github.com/OLSF/libra/issues/616#issuecomment-899442321
[ ] Get mining working
[ ] Pull latest changes from main
[ ] Fix remaining // 0L todos and tests
[ ] Final check - all 0L tests and swarm work
[ ] Update wiki and all other docs.

Notes:
//// swarm 5 accounts alice bob etc..
[language/tools/vm-genesis/src/lib.rs:405] owner_address = 4C613C2F4B1E67CA8D98A542EE3F59F5
[language/tools/vm-genesis/src/lib.rs:405] owner_address = 88E74DFED34420F2AD8032148280A84B
[language/tools/vm-genesis/src/lib.rs:405] owner_address = E660402D586AD220ED9BEFF47D662D54
[language/tools/vm-genesis/src/lib.rs:405] owner_address = 9E6BB3A75E9618FBA057E86E69338C94
[language/tools/vm-genesis/src/lib.rs:405] owner_address = 5709AFA1D0FBB40B171AA03D457DB72A

Next Actions:

[ ] Merge v5_old_diem-1.2.0 into diem-core 1.3.0, resolve all conflicts, commit/push
[ ] Solve ..

Remaining failing move-lang-functional-tests:
failures:
    functional_testsuite::0L/autopay/instructions_balance.move
    functional_testsuite::0L/autopay/instructions_inflow.move
    functional_testsuite::0L/autopay/autopay_escrow_percentage.move

Remaining/todo-later failing move-lang-functional-tests:
test_successful_upgrade_txs

Details:
Followings done, still fails:
https://github.com/OLSF/libra/wiki/Stdlib-Upgrade-payload
https://github.com/OLSF/libra/wiki/Stdlib-Upgrade-payload-(v5)
cargo test -p language-e2e-testsuite -- --nocapture test_successful_upgrade_txs

   Compiling language-e2e-testsuite v0.1.0 (/home/gsimsek/libra-fork/language/e2e-testsuite)
    Finished test [unoptimized + debuginfo] target(s) in 17.93s
     Running unittests (target/debug/deps/language_e2e_testsuite-980912f51ca17c5d)

running 1 test
OK create_and_initialize_main_accounts ===============
Initializing with env: test
0 ======== Create Owner Accounts
[language/tools/vm-genesis/src/lib.rs:412] owner_address = 06505CCD81E562B524D8F656ABD92A15
[language/tools/vm-genesis/src/lib.rs:412] owner_address = DE589EC6B85A4A1A58BE166C38551CC2
[language/tools/vm-genesis/src/lib.rs:412] owner_address = B000D8E1919132C664A36C0FDF986407
[language/tools/vm-genesis/src/lib.rs:412] owner_address = 3C36BD759B51F1C9B7F4258896FCFE6C
1 ======== Create OP Accounts
2 ======== Link owner to OP
3 ======== OP sends network info to Owner config
4 ======== Add owner to validator set
OK create_and_initialize_owners_operators ===============
OK Genesis subsidy ===============
created new validator accounts
registered new validator accounts
======== round is 0
minted tokens for validators
======== round is 0
created operator account
validators set their operator account
======== round is 0
registered validator configs
registered and reconfigured validators
======== round is 0
minerstate_helper_script executed successfully
minerstate_commit executed successfully
thread 'tests::ol_upgrade_oracle::test_successful_upgrade_txs' panicked at 'assertion failed: `(left == right)`
  left: `Ok(MISCELLANEOUS_ERROR)`,
 right: `Ok(EXECUTED)`', language/e2e-testsuite/src/tests/ol_upgrade_oracle.rs:243:7
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test tests::ol_upgrade_oracle::test_successful_upgrade_txs ... FAILED

failures:

failures:
    tests::ol_upgrade_oracle::test_successful_upgrade_txs

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 150 filtered out; finished in 54.01s

error: test failed, to rerun pass '-p language-e2e-testsuite --lib'

Swarm last account problem:
This is the expected accounts:
[language/tools/vm-genesis/src/lib.rs:405] owner_address = 4C613C2F4B1E67CA8D98A542EE3F59F5
[language/tools/vm-genesis/src/lib.rs:405] owner_address = 88E74DFED34420F2AD8032148280A84B
[language/tools/vm-genesis/src/lib.rs:405] owner_address = E660402D586AD220ED9BEFF47D662D54
[language/tools/vm-genesis/src/lib.rs:405] owner_address = 9E6BB3A75E9618FBA057E86E69338C94
[language/tools/vm-genesis/src/lib.rs:405] owner_address = 5709AFA1D0FBB40B171AA03D457DB72A

This is what we have, the 5th address is different:
OK create_and_initialize_main_accounts ===============
Initializing with env: test
0 ======== Create Owner Accounts
[language/tools/vm-genesis/src/lib.rs:413] owner_address = 4C613C2F4B1E67CA8D98A542EE3F59F5
[language/tools/vm-genesis/src/lib.rs:413] owner_address = 88E74DFED34420F2AD8032148280A84B
[language/tools/vm-genesis/src/lib.rs:413] owner_address = E660402D586AD220ED9BEFF47D662D54
[language/tools/vm-genesis/src/lib.rs:413] owner_address = 9E6BB3A75E9618FBA057E86E69338C94
[language/tools/vm-genesis/src/lib.rs:413] owner_address = 4E1F81F77024B56DBB853CE7ED8E1C7E

Mining error:
Running `target/debug/miner --swarm-path /opt/swarm_temp --swarm-persona alice start`
miner config file not existing: "/opt/swarm_temp/0/0L.toml"
Info: Got tx params from swarm
Fetching remote tower height: http://localhost:40697/, 4C613C2F4B1E67CA8D98A542EE3F59F5
Aug 16 14:34:26.958  INFO ureq::unit: sending request POST http://localhost:40697/
Aug 16 14:34:26.963  INFO ureq::unit: sending request POST http://localhost:40697/
Aug 16 14:34:26.965  INFO ureq::unit: sending request POST http://localhost:40697/
Aug 16 14:34:26.967  INFO ureq::unit: sending request POST http://localhost:40697/
Error fetching remote state:
  Error { inner: Inner { kind: JsonRpcError, source: None,
      json_rpc_error: Some(JsonRpcError { code: -32602, message: "method_not_found'",
      data: None }) }
}
Failed fetching remote state:
    Error fetching remote state:
    Error { inner: Inner { kind: JsonRpcError, source: None,
        json_rpc_error: Some(JsonRpcError { code: -32601, message: "method_not_found'", data: None }) }
    }
url: http://localhost:40697/
Block 752 Mining VDF Proof


Fixes to documentation and environment variables

Fixed URL to point documentation to the correct docker builds location
Added OPENTARGETS_DATA_VERSION to the docker run example command
Updated DATA_VERSION to latest release in config.py

Notify: @elipapa

👏  thanks!


BackendUnavailable while building the documentation

Details

Read the Docs project URL: https://readthedocs.org/projects/burp-ui
Build URL (if applicable): https://readthedocs.org/projects/burp-ui/builds/8509365/
Read the Docs username (if applicable): ziirish

Expected Result
The documentation used to build without any issue.
Actual Result
For a few weeks, every build attempt fails in an early step whereas nothing changed in my requirements.
Here is the failing step:
/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/bin/python -m pip install --exists-action=w --cache-dir /home/docs/checkouts/readthedocs.org/user_builds/burp-ui/.cache/pip -r requirements.txt

And here is the traceback:
Collecting trio==0.10.0 (from -r requirements.txt (line 1))
  Downloading https://files.pythonhosted.org/packages/e6/20/37be7b5f47db6a9fbf905b5de5386e5b7193c45d07becb750db6f03cd117/trio-0.10.0.tar.gz (402kB)
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
Exception:
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.6/site-packages/pip/_internal/cli/base_command.py", line 176, in main
    status = self.run(options, args)
  File "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.6/site-packages/pip/_internal/commands/install.py", line 315, in run
    resolver.resolve(requirement_set)
  File "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.6/site-packages/pip/_internal/resolve.py", line 131, in resolve
    self._resolve_one(requirement_set, req)
  File "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.6/site-packages/pip/_internal/resolve.py", line 294, in _resolve_one
    abstract_dist = self._get_abstract_dist_for(req_to_install)
  File "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.6/site-packages/pip/_internal/resolve.py", line 242, in _get_abstract_dist_for
    self.require_hashes
  File "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.6/site-packages/pip/_internal/operations/prepare.py", line 349, in prepare_linked_requirement
    abstract_dist.prep_for_dist(finder, self.build_isolation)
  File "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.6/site-packages/pip/_internal/operations/prepare.py", line 149, in prep_for_dist
    reqs = self.req.pep517_backend.get_requires_for_build_wheel()
  File "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.6/site-packages/pip/_vendor/pep517/wrappers.py", line 71, in get_requires_for_build_wheel
    'config_settings': config_settings
  File "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.6/site-packages/pip/_vendor/pep517/wrappers.py", line 162, in _call_hook
    raise BackendUnavailable
pip._vendor.pep517.wrappers.BackendUnavailable

The problem started with the commit 2618ba00be7ed7a2fa483dfc21bfb7bb46038d90 of my project. As you can see here there aren't any change in the requirements between the last known functioning commit (2c1b4bb7efeaeea2dbdef2e0c7096ac4f534b020) and this one.
During my early troubleshooting I found those issues that might be related: https://github.com/pypa/setuptools/issues/1644 and https://github.com/pypa/pip/issues/6164
Those issues are talking about both pip 19.0 and python <=3.6.5.
I noticed the readthedocs builder run python 3.6.4.
I'm using the following readthedocs.yml:
# https://docs.readthedocs.io/en/latest/yaml-config.html
build:
  image: latest
python:
  version: 3.6
  pip_install: true
  extra_requirements:
    - rtd

Let me know if you need further details.
Thanks

Can you try wiping the enviroment https://docs.readthedocs.io/en/stable/guides/wipe-environment.html?
Also, if this bug isn't present in python 3.5 or 3.7, you can use a different version https://docs.readthedocs.io/en/stable/config-file/v2.html#python
(note that is using the v2 of the config file)

Thanks for the hints.
The wipe trick didn't solve the issue. I'll have a look at python 3.7 then config v2.
I cannot try 3.5 though because I'm using format strings which were introduced in 3.6.
I couldn't use 3.7 because I had variables called async which is a reserved keyword since 3.7 but this issue should be fixed by now.

You can also use a previous version of pip that was working with that version of python. You can create a requirements file with pip only and put it before the requirements of your project https://docs.readthedocs.io/en/stable/config-file/v2.html#requirements-file

Also, we install the latest version of pip by default, so if the problem is solved in the pip side, it would be fixed here as soon as they make a new release.

I have updated my .readthedocs.yml to the v2 format and I'm now using python 3.7 instead of 3.6 but I am hitting a new issue still in the early build stages.
Config:
# https://docs.readthedocs.io/en/latest/yaml-config.html
version: 2
build:
  image: latest
python:
  version: 3.7
  install:
    - method: pip
      path: .
      extra_requirements:
        - rtd

Traceback:
Processing /home/docs/checkouts/readthedocs.org/user_builds/burp-ui/checkouts/latest
Collecting trio==0.10.0 (from burp-ui==0.7.0.dev0)
  Using cached https://files.pythonhosted.org/packages/e6/20/37be7b5f47db6a9fbf905b5de5386e5b7193c45d07becb750db6f03cd117/trio-0.10.0.tar.gz
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
  Complete output from command /home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/bin/python /home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmprmehga8o:
  Traceback (most recent call last):
    File "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py", line 207, in <module>
      main()
    File "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py", line 197, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py", line 48, in get_requires_for_build_wheel
      backend = _build_backend()
    File "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py", line 39, in _build_backend
      obj = getattr(obj, path_part)
  AttributeError: module 'setuptools.build_meta' has no attribute '__legacy__'

  ----------------------------------------
Command "/home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/bin/python /home/docs/checkouts/readthedocs.org/user_builds/burp-ui/envs/latest/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmprmehga8o" failed with error code 1 in /tmp/pip-install-y4lpxq8a/trio

It looks like this issue has been fixed in setuptools v40.8.0
I'll try to add another requirement forcing that version of setuptools prior to installing the rest of my dependencies.

Adding an explicit setuptools==40.8.0 seems to have fixed the above error for python 3.7.

Thanks, looks like we need to install the latest version of setuptools to play nice with the latest version of pip. I'll do a PR soon.

Awesome! Thanks for your hard work.


GUVNOR-2814: Guided Decision Table Graph: User is always prompted to save or discard data

See https://issues.jboss.org/browse/GUVNOR-2814
This PR ensures the "original" hashCode is correctly set when a graph (or individual table) is loaded. It does however highlight the status of https://issues.jboss.org/browse/GUVNOR-2262 that is related to the JIRA for this PR in that you are no longer prompted when closing a "dirty" guided decision table as the underlying model lacks a hashCode implementation (other than the default provided by the JVM).

@Rikkola @karreiro Could you please review at your leisure?

Thanks @manstis :-)


Adding a separate oidc version of the image

I was making my own image with oidc based on the instructions in the repo and I was thinking it would be simpler if the main build processes just also made that image.
I ran both images this builds and everything seems to work.
If everyone is happy with this approach, I can do the same for the metadata repo and update the helm chart too.

Codecov Report

Merging #352 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #352      +/-   ##
=========================================
- Coverage   76.29%   76.2%   -0.09%
=========================================
  Files         163     137      -26
  Lines        4083    2896    -1187
  Branches      516     407     -109
=========================================
- Hits         3115    2207     -908
+ Misses        931     681     -250
+ Partials       37       8      -29

Impacted Files
Coverage Δ

amundsen_application/api/metadata/v0.py

amundsen_application/log/action_log_callback.py

amundsen_application/api/__init__.py

amundsen_application/api/utils/request_utils.py

amundsen_application/api/mail/v0.py

amundsen_application/base/base_preview_client.py

...ndsen_application/base/base_announcement_client.py

amundsen_application/wsgi.py

amundsen_application/log/action_log_model.py

amundsen_application/api/search/v0.py

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e355bca...30947e3. Read the comment docs.

cc @verdan

@verdan If you are ok with this idea (even if there are some changes you want to see), I will go ahead and make the helm charts and metadata image. I have some time over the holidays to work on this again.

@lukelowery I am fine with the approach and the implementation 👍
(sorry for the delays in the review, somehow missed that in my emails.)


Shor

Quantum Fourier Transform and Phase Estimation. In gates.py I added two gates, swap gate (which can be further optimized) and control_U gate (apply U to auxiliary only). In sparse_matrix.py, I added function zero() for creating zero matrix.

Forgot to push the latest code


Combined support selection via friend name + preferred servants and CEs

Did you guys ever get the chance to make it so that when you set it to Friend Support, you can combine it with selecting a particular Servant or CE.
That way in case they change there CE/Servant it will stop and not keep going.

So why do you want this? Is preferred mode with Support_FriendsOnly = 1 not enough?

Huh I'd completely forgotten about this thread as it's been a few months.
Although I think you might be thinking of a different feature.
Support Friends List only is on for me but that just means it's not going to take someone I'm not friends with.
Awhile back a new mode was added that called
Support_FriendNames
After you take a screenshot of your friends username it will always pick them.  This is a useful feature as some friends may have a better Servant which has higher skills or NP Level.
Unfortunately there's always a chance a friend may move an Event CE off which means it will continue to auto without it.
I asked awhile back if it was possible to combine Username check's with CE checking.  I got told it was and that it wouldn't be to hard to implement.
I have no idea if they ever actually combined it as I haven't updated my auto in a bit and it's only really relevant during lotteries generally.  This thread was literally just me asking two months after being told it was possible if they ever got the chance to complete it.
Now that it's been more than 6 months since then I have no idea if they did combine them.


Feature Request: Add support for relative price-model endpoints

Would love to have support for the price model endpoint, which I've been using so far to get the real price value for Volume Pricing model.
"price-model": {
  "links": {
    "related": "https://api.lemonsqueezy.com/v1/variants/1/price-model",
    "self": "https://api.lemonsqueezy.com/v1/variants/1/relationships/price-model"
  }
}

Thank you for the feature request - this has been added to our to-do list!


Spring Boot support: use annotation processor org.springframework.boot.autoconfigureprocessor.AutoConfigureAnnotationProcessor in builds

See https://github.com/spring-cloud/spring-cloud-commons/issues/377

Seems like this is a bad idea ;)  We should add this to each module that needs it not globally.


How to enable typescript inlay hints in svelte

Describe the bug
Hi, I configured typescript-tools nvim and enabled the inlay hints, but can't enable the inlay hints for svelte
Reproduction
Install svelte language server in neovim
System Info
Operating system: Arch Linux
Neovim: 0.10

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Hi @GustavoJCL That would must be implemented with Svelte LSP to make it works. You should check the document there https://github.com/neovim/nvim-lspconfig/blob/master/doc/server_configurations.md#svelte

FYI - Found this recently https://github.com/MysticalDevil/inlay-hints.nvim/blob/master/README.md#svelte-language-server


Use virtual documents for function definitions

At present, function definitions are files stored on disk. The current liveshare implementation avoids this through virtual documents, which has the added benefit of marking documents as read only.
I realise that definitions are created and provided by the LSP, but I don't believe virtual documents are part of the spec. Please feel free to redirect @renkun-ken if you think this fits better in the LSP repo.
Describe the solution you'd like
I think it would be a lot cleaner if function definitions were virtual documents and not files in their own right

I agree. It is definitely much cleaner to view definitions in virtual docs. LSP uses document selector to provide features to editor documents. It would be nice if we could still use lsp features in the virtual docs but I'm not sure if it is the case?
Do you have any examples in mind such as other languages which opens a virtual doc but lsp is still functioning in it?

RIght, I see what you mean re: LSP. I don't think I've come across this before, but I'll have a look through some extensions and get back to you.
Also, I think this would be useful for the View() function with non-list or dataframe values (e.g. View(5), View(mean))


As a developer, I want the Pantry page to display text if there are no items rather than crashing

If there are no documents in the firebase Pantry collection, the app gives an error. This page should simply have text with something like 'No items in the pantry'.

Pantry now prompts that there is no items instead of crashing


Investigate possible RN63.3 incompatibility

The incompatibility is due to Facebook broken swizzling in Flipper. 🤦♂


rxcc token

freedom in the crypto world is important, the most important goal is to make a strong foundation in our tokens.
making tokens is easy, very difficult, how to achieve that goal can be made and realized real.
we have made a planning project that we have tested in a work simulation, and we believe our tokens are one of the future, which will make all happy.
We are a team that is experienced in the field of crypto trading and we see many tokens that are not too fast in market action, and we see that and want to realize our dreams so that everyone is free in crypto trading on some market crypto
(we are a team experienced in crypto trading, and created the crypto freedom project)
The main purpose
A. Creating crypto trading convenience (RXCC)
B. Crypto advantages that can be determined
C. All control is in the hand
team in the RXCC freedom project
1.Singapore
2. Malaysia
3.Indonesia
(DENNY, Founder) https://www.linkedin.com/in/denny-sp-freedom/
(RAMA, Investor Handling) https://www.linkedin.com/in/rama-freedom/
(BERY, Data manager) https://www.linkedin.com/in/bery-freedom/
official team and admin & RXCC service , RXCC Marketing
https://www.linkedin.com/in/rama-freedom/
(FAKHRY) https://t.me/RXcryptofreedom
(EDWIN)  https://t.me/edwinfreedom
(SAIZI)     https://t.me/saizifreedom
https://cryptofreedom.ml
<EMAIL_ADDRESS>https://twitter.com/RXCCrypto
https://t.me/cryptofreedomgroup
https://medium.com/@RXCCcryptofreedom
https://github.com/RXcryptofreedom
Contract  0xa8F952Daa2050aF448e2B6E8cCd2cD66E145F9Cc
https://etherscan.io/address/0xa8F952Daa2050aF448e2B6E8cCd2cD66E145F9Cc
gas limit: 60000

please add the RXCC logo to ImToken
Kontrak 0xa8F952Daa2050aF448e2B6E8cCd2cD66E145F9Cc
https://etherscan.io/address/0xa8F952Daa2050aF448e2B6E8cCd2cD66E145F9Cc
thank you

Incorrect information submitted, please go through our guide and check again.


Enable finding plugins in a user-selected directory

Fixes #1870.
This is a candidate fix based on my current understanding of the requirement.  If we validate that it meets the need, then I'll tidy it and put it ready for review.

This is potentially relevant to #2555, although I'm not sure the strategy of requiring an environment variable would fit with Rancher Desktop's needs.  That feels like it's closer to the Homebrew situation, which had a similar requirement to Rancher and for which we did a one-off fix: maybe we should explore a more wide-ranging, configurable equivalent to that.  cc @kate-goldenring

also cc @jandubois for visibility - looking at the issue, Rancher's needs are broader than just plugins, but it does sound like the environment variable approach would meet their needs

I'm not sure the strategy of requiring an environment variable would fit with Rancher Desktop's needs

I was hoping for a minimal addition to default_data_dir in crates/common/src/data_dir.rs.
I'm not a Rust person, so I'm just making up stuff, but I would hope for something like this:
/// Return the default data directory for Spin
pub fn default_data_dir() -> Result<PathBuf> {
    if let Ok(spin_appdata) = std::env::var("SPIN_APPDATA") {
        return Some(spin_appdata);
    }
    …
}

Don't care about the name of the variable, but it would disable all heuristics/rules and always return the path set in the environment. It would work for both plugins and templates (and everything else you will store in the data directory in the future).
I think the issue of having an additional plugin directory is orthogonal to this feature, but of course the way these features would interact should be considered (I have not reviewed the code in this PR in detail, nor the issue that is to be fixed by it).2

#2563


every tool or function should answer a question

we should be able to define regex-like questions for every function and program to help aid in documentation and automatically answering questions from people

but also, every question needs to be backed by a unit test so we can ensure that the answer is still correct


Can't type check with vue-tsc

报错的主要信息为  'cls' is declared but its value is never read.

的确现在 vue-tsc 常在还无法正常识别和检测。我们看一下怎么后续集成和跟进做支持。
Indeed, vue-tsc is often not recognized and detected normally. Let's see how to follow-up integration and follow-up support.

请使用 vue-vine-tsc
另外现在 vue-vine-tsc 报告的问题是全量、准确的。但在 IDE 中 .vue 文件上可能会有部分错误没有显示出来，这个我们在另一个 issue 中后续跟进。
——————
Translation:
Please use vue-vine-tsc
In addition, the problems that vue-vine-tsc reports are now full and accurate. But in VSCode there may be a part of diagnostics in .vue file that doesn't show up, which we'll track in another issue.


Select-DbaObject: Tests and documentation

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[x] Pester test is included
[ ] Nunit test is included
[x] Documentation
[ ] Build system

Changes

Add Pester tests for Select-DbaObject
Updated documentation significantly

awesome, thank you!


[Dtype refactor] Document access to pandas native dtype

In pandera 0.7.0, DataFrame.dtypes returns a dictionary Dict[str, pandera.DataType]. In 0.6.X it was a dictionary of string aliases.That behavior can be reproduced in 0.7.0 by applying str to a pandera.DataType. Most pandas dtypes can be constructed from a string alias. One notable exception is pandas.CategoricalDtype whose alias is "category" no matter the categories supplied.
There is an undocumented type attribute to pandera.engines.pandas_engine.DataType. It is similar in spirit to numpy.dtype.type and returns the boxed pandas dtype. I'm reluctant to document that attribute because the new pandera.DataType hierarchy was designed around hiding implementation details as much as possible.
import pandas as pd
import pandera as pa

schema = pa.DataFrameSchema(
    {
        "float": pa.Column(float),
        "default_cat": pa.Column("category"),
        "parameterized_cat": pa.Column(pd.CategoricalDtype(["a", "b"])),
    }
)

# get pandera.DataType
print(schema.dtypes)
#> {'float': DataType(float64), 'default_caa': DataType(category), 'parameterized_cat': DataType(category)}

# get string aliases
print({col: str(pandera_dtype) for col, pandera_dtype in schema.dtypes.items()})
#> {'float': 'float64', 'default_cat: 'category', 'parameterized_cat': 'category'}

# get pandas native dtypes
print({col: pandera_dtype.type for col, pandera_dtype in schema.dtypes.items()})
#> {'float': dtype('float64'), 'default_cat': CategoricalDtype(categories=None, ordered=False), 'parameterized_cat': CategoricalDtype(categories=['a', 'b'], ordered=False)}

# get list of categories
print(schema.dtypes["parameterized_cat"].categories)
#> ('a', 'b')

However, we could add a property DataFrameSchema.native_dtypes. Maybe I'm overthinking it and this property wouldn't be needed?

I think the schema.dtypes change breaks backwards compatibility, but I think that's okay. If I recall correctly this feature was introduced before coercion existed, so users can do something like dataframe.astype(schema.dtypes), but with coercion I don't think this use case is super common.
Let's revisit the native_dtypes idea if the use case comes up in the future. Closing for now!


[BUG] Kagami cannot access the cloned repo in the tmp dir

OS and Environment
macOS 13.4 (22F66)
GIT commit hash
2ebc38e0
Minimum working example / Steps to reproduce
Run the following in the repo root:

cargo build --release --bin kagami
./target/release/kagami validator

Actual result
Kagami fails with the following output:
Initialized empty Git repository in /private/var/folders/ft/3d510379563__2qpwn299g4r0000gn/T/.tmpfMMCcQ/iroha-cloned/.git/
remote: Enumerating objects: 734, done.
remote: Counting objects: 100% (734/734), done.
remote: Compressing objects: 100% (655/655), done.
remote: Total 734 (delta 83), reused 311 (delta 33), pack-reused 0
Receiving objects: 100% (734/734), 975.72 KiB | 294.00 KiB/s, done.
Resolving deltas: 100% (83/83), done.
From https://github.com/hyperledger/iroha
 * branch            2ebc38e051b90b8190b3795c7576094a9299982e -> FETCH_HEAD
HEAD is now at 2ebc38e [fix] #3445: make `POST configuration` work again
Error:
   0: Failed to canonicalize path: /var/folders/ft/3d510379563__2qpwn299g4r0000gn/T/.tmpfMMCcQ/iroha-cloned/default_validator
   1: No such file or directory (os error 2)

Location:
   wasm_builder/src/lib.rs:113

As you can see, initially it clones the repo into /var/folders/ft/3d510379563__2qpwn299g4r0000gn/T/.tmpfMMCcQ temporary directory. It comes from here:
https://github.com/hyperledger/iroha/blob/2ebc38e051b90b8190b3795c7576094a9299982e/tools/kagami/src/validator.rs#L25
Then, for some reason, this directory disappears before it is actually used by Kagami.
Expected result
Expected to build the validator successfully.
Who can help to reproduce?
No response
Notes
I think that it might be a specific behaviour of macOS. Maybe it could be fixed by tuning the usage of the tempfile crate.

Reproducible on Linux
System: Linux 6.1.29-1-MANJARO (x86_64)
Output:
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint:
hint: 	git config --global init.defaultBranch <name>
hint:
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint:
hint: 	git branch -m <name>
Initialized empty Git repository in /tmp/.tmpuFjnRa/iroha-cloned/.git/
remote: Enumerating objects: 734, done.
remote: Counting objects: 100% (734/734), done.
remote: Compressing objects: 100% (655/655), done.
remote: Total 734 (delta 85), reused 308 (delta 33), pack-reused 0
Receiving objects: 100% (734/734), 974.70 KiB | 1.27 MiB/s, done.
Resolving deltas: 100% (85/85), done.
From https://github.com/hyperledger/iroha
 * branch            2ebc38e051b90b8190b3795c7576094a9299982e -> FETCH_HEAD
HEAD is now at 2ebc38e [fix] #3445: make `POST configuration` work again
Error:
   0: Failed to canonicalize path: /tmp/.tmpuFjnRa/iroha-cloned/default_validator
   1: No such file or directory (os error 2)

Location:
   wasm_builder/src/lib.rs:113

after run a comand ./target/release/kagami validator
below you can see the output of the validator
validator_output.txt

commit ee60fc8
Environment macOs Ventura 13.3 m1
after run a comand ./target/release/kagami validator below you can see the output of the validator
validator_output.txt

Answered in the corresponding PR: comment


Why would this be a bad request?

-bash-4.1$ export PATH=$PATH:~
-bash-4.1$ hoverctl status
+------------+----------+
| Hoverfly   | running  |
| Admin port |     8888 |
| Proxy port |     8500 |
| Proxy type | forward  |
| Mode       | capture  |
| Middleware | disabled |
+------------+----------+
-bash-4.1$ telnet localhost 8500
Trying ::1...
telnet: connect to address ::1: Connection refused
Trying <IP_ADDRESS>...
Connected to localhost.
Escape character is '^]'.
GET / HTTP/1.1
Host: thecure.com
User-Agent: Mozilla/5.0 (compatible; Yahoo! Slurp; http://help.yahoo.com/help/us/ysearch/slurp) .default/1538949339-2
Accept: /
HTTP/1.1 500 Internal Server Error
Content-Type: text/plain; charset=utf-8
X-Content-Type-Options: nosniff
Date: Sun, 07 Oct 2018 23:33:21 GMT
Content-Length: 64
This is a proxy server. Does not respond to non-proxy requests.
^]
telnet> quit
Connection closed.
-bash-4.1$
https://github.com/SpectoLabs/goproxy/blob/master/proxy.go#L108-L110
Why does the url has to be absolute? If a Host header is provided

@tommysitu telnet is just to simulate a connection (incidently nc could be use instead) to hoverfly, once the connection is established (just like what a 1.1 browser does, I believe) be that a normal http connection or https connection with HTTP "CONNECT" handled by hoverfly + SSL negotiation is done, a 1.1 session is established, and supposedly one can request url without any specifying host nor port nor scheme in any subsequent request url.

@pnip I'm very interested in your use case. Are you trying to setup HTTP tunnel via hoverfly proxy to use telnet? What's your end goal in doing this, to capture and simulate the telnet session? It may not work as you have pointed out as it hasn't been tested for telnet before.
Maybe you have tried this out already, but if you haven't, have a look at proxychains, it should let you configure a proxy for telnet.

@tommysitu nah this is not for capture/simulate telnet session but for creating an repeatable integration testing framework for our server/client stacks.

From what I see @pnip you started telnet on the same port that is used by the http proxy. Telnet will use TCP/IP or similar, not http, so a http proxy will barf. If so it's a problem that has nothing to do with Hoverfly.

I'm persuaded this is a bug caused by the relative path not being processed correctly.

Revisited this issue again, and GoProxy is not working properly with telnet requests. It should be able to get the destination from the Host header for HTTP 1.1 request.

Revisited this issue again, and GoProxy is not working properly with telnet requests. It should be able to get the destination from the Host header for HTTP 1.1 request.

I am seeing similar issues, trying to use Hoverfly as a MITM (man-in-the-middle) proxy between an Envoy (reverse) proxy and our application server. The use case is for recording a bunch of requests down to .json files so we can then replay them using Gatling.
Requests like this work fine:
$ telnet <IP_ADDRESS> 8080
Trying <IP_ADDRESS>...
Connected to <IP_ADDRESS>.
Escape character is '^]'.
GET http://localhost/some-path HTTP/1.1
Host: localhost

HTTP/1.1 200 OK
Accept-Ranges: bytes
Content-Length: 10534
Content-Type: text/html;charset=UTF-8
Date: Tue, 07 Jan 2020 14:11:25 GMT
Hoverfly: Was-Here
Last-Modified: Mon, 09 Dec 2019 08:13:02 GMT
Server: Apache-Coyote/1.1
Vary: Accept-Encoding

<response-data>

If I retry this with relative URL, I get the same error:
$ telnet <IP_ADDRESS> 8080
Trying <IP_ADDRESS>...
Connected to <IP_ADDRESS>.
Escape character is '^]'.
GET /some-path HTTP/1.1
Host: localhost

HTTP/1.1 500 Internal Server Error
Content-Type: text/plain; charset=utf-8
X-Content-Type-Options: nosniff
Date: Tue, 07 Jan 2020 14:13:19 GMT
Content-Length: 64

This is a proxy server. Does not respond to non-proxy requests.

The problem is not in itself related to telnet per se; as @pnip described it's merely a tool that is commonly used (well, perhaps used to be more commonly used back in the days :slightly_smiling_face:) for debugging arbitrary TCP protocols. As long as you know the (basics) of the protocol, you can debug it with telnet or nc (netcat).
The problem is more specifically this code in the upstream goproxy lib; as @tommysitu suggested, it doesn't handle non-absolute URLs. In this case, "absolute" is presumed to mean a full URL with scheme://host/path and not just a /path.
This issue on the goproxy side indicates that this by design because goproxy is a forward proxy and not a reverse proxy.
OTOH, I get the feeling from reading this example in the goproxy repo that it could actually be made to work; it's at least possible to use goproxy as a transparent (forward) proxy by overriding the NonproxyHandler: https://github.com/elazarl/goproxy/blob/master/examples/goproxy-transparent/transparent.go#L36-L44 (more details: https://github.com/elazarl/goproxy/tree/master/examples/goproxy-transparent). Does that help us make it possible to make goproxy usable as a reverse proxy? Uncertain about that part.

@perlun, that's exactly what the problem is. Getting the host from the Host header should fix it.
Hoverfly already has a reverse proxy mode, check here https://github.com/SpectoLabs/hoverfly/blob/master/core/proxy.go#L109
You can do hoverctl start webserver to enable it. But under this mode, Hoverfly doesn't do capturing.
Feel free to submit a PR you'd like to contribute.

Thanks for the reply @tommysitu. :+1: Good to hear more about the reverse proxying mode. However, in our case, the capturing is the critical part, so we ended up opting for another solution for now (for reference, the Envoy tap filter described here: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/tap_filter#config-http-filters-tap). Since we already use Envoy, taking that into use was easy for our particular use case.
It would however be nice to be able to to use Hoverfly in this mode, so I will support someone trying to fix it. :slightly_smiling_face: However, will not spend time on it myself.


Can access and use project that is inactive

v0.20.4
Steps:

Authenticate
Create 2 projects and give member access to rancherdev
Log in on another browser as rancherdev and go to host page for 1st project
Go back and as admin deactivate the 1st project
As rancherdev, click around, create host, containers, anything you want.

Results:
Everything works fine for rancherdev even thou the project has been deactivated.
Expected:
Shouldn't be able to stay and create things in project that is deactivated.

hmm ill look into it.

Ping @hibooboo2 is this fixed now?  If so pls mark and assign back to @tfiduccia

0.23.0-rc5
Verified fixed


[FLINK-6139] [doc] Documentation for running Flink with MapR

Includes how to properly build Flink & setup job client to be able to run Flink on YARN with a MapR cluster.

I would propose to add a special "mapr" build profile to our maven files to do all the exclusions. Otherwise, the documentation looks pretty scary :)

@rmetzger that definitely makes sense, I'll try to include that with the PR.

Cool, thank you!

@rmetzger I've added the "mapr" build profile to our Maven build.
Now the build command is shortly: mvn clean install -Pvendor-repos,mapr. Much less daunting for users :) Currently, both mapr and vendor-repos must be used together.
We could perhaps shorten this further into a single profile, by also adding the MapR repo in mapr profile. What do you think?

I think its fine like this.

+1 to merge

Thanks for the review, merging to {{master}} and {{release-1.2}}.


Internal error. Please try again

Getting this error.  Perhaps it should silently retry?:
   trade_history_dict_raw = self.polo.returnTradeHistory(currencyPair='all', start=start_date_timestamp, end=end_date_timestamp, limit=10000)

  File "/opt/cryptocurrency_tools/lib/python3.4/site-packages/poloniex/poloniex.py", line 235, in returnTradeHistory

    start=start, end=end, limit=limit)

  File "/opt/cryptocurrency_tools/lib/python3.4/site-packages/poloniex/poloniex.py", line 50, in _fn

    raise PoloniexCommandException(respdata['error'])

poloniex.exceptions.PoloniexCommandException: Internal error. Please try again.

It might be useful for public APIs, I'm not sure that enabling this for private APIs would be a good choice. What's your opinion on this?

That's a good point.  Agreed for public APIs.  For private APIs seems like it would make sense if the call is readonly, like in this case (returnTradeHistory).  Maybe there's an adverse effect I'm not thinking of?  There could be a default number of tries, and if we hit that default, we raise an exception and give the stack trace.

What version of the API are you running? I ran into a similar error at one point I think but the error went away when I upgrade to 0.0.17 (and now it displays specifically what the error is)

I'm closing this since it has been 2 years without updates


gnark docs need love

I spent the last hour trying to run gnark, and have not yet succeeded. I'm sure I'll get there eventually, but it's pretty bad rn.
I kept a dev log.
https://gist.github.com/thor314/245e25d23eb1f9628f347162dea8d409

Yeah, we completely agree - docs.gnark.io is stale. The main issue there is that it is difficult to keep the documentation site and gnark consistent with each other, there are no automated tools.
We're now slightly taking a different approach - instead of separate documentation we implement example as Go doctests as they are testable in CI and when running Go tests. But we do not have sufficient number of tests and they are rather for more complex circuits (a la pairing, field emulation etc, see<EMAIL_ADDRESS>for example).
Now, the issue with this approach is that such examples look good only on pkg.go.dev/github.com/consensys/gnark and may be unintuitive to look for in the repo directly. So, we're also thinking about compiling godoc into a Markdown/RST which can be included in the repository directly. (see also issues https://github.com/Consensys/gnark/issues/460 https://github.com/Consensys/gnark/issues/525).
And finally, we should add a lot more examples in examples/ subfolder, maybe renaming the packages with increasing order of difficulty (01-install, 02-simple, 03-witness-assignment etc. etc) so that the users could do step-by-step and progress a little bit by learning only a few concepts at a time.
All this is known and planned, we're currently very busy with Linea zkevm, but will come back to general improvement topics soon.


Fix "pr-branches" and "remove-projects-tab" features

pr-branches: An alphanumeric string was being passed to Number() causing it to return NaN and eventually lead to failure of GraphQL query.

remove-projects-tab: Selector was renamed from HeaderMenu to Header.

Fixes #1935
Closes #1935

@HardikModha want to tackle this last one?
https://github.com/sindresorhus/refined-github/edit/master/.editorconfig
❌ branch-buttons
content.js:1880 TypeError: Cannot read property 'textContent' of null
    at getDefaultBranchLink (content.js:3760)
    at async Promise.all (index 0)
    at async branch_buttons_init (content.js:3783)
    at async features_run (content.js:1875)

@yakov116 I'm not seeing this error. The feature is working fine for me.

@yakov116 I'm not seeing this error. The feature is working fine for me.

It's there on the linked page

content.js:1880 TypeError: Cannot read property 'textContent' of null

This is because the feature runs on all isRepo pages, it should be reduced to where the required elements appear (without adding more ifs) like isRepoTree, isSingleFile, isCommit, etc

Damn...and here I was thinking of why @yakov116 has linked .editorconfig here. :sweat_smile:

Wrong direction, follow this:

This is because the feature runs on all isRepo pages, it should be reduced to where the required elements appear (without adding more ifs) like isRepoTree, isSingleFile, isCommit, etc

It's not specifically about "Edit File" but it's isRepo was too broad

@bfred-it  So we just add? 🤔

include: [
    features.isRepoTree,
	features.isSingleCommit,
	features.isSingleFile,
],

Yep, and maybe more that I don't remember

@bfred-it  I went through all the pages and only pages having .breadcrumb are getting covered in the two features namely features.isRepoRoot and features.isSingleFile.

I think this feature only makes sense when there’s a branch selector, because the feature is an extension of that, but we can probably detect this via page detects

Thanks @HardikModha 🕊
I dropped the changes related to my latest comment in the other thread as that requires a proper solution in view-markdown-source


replace panic to std::io::Error

This pull request replaces all occurrences of panic! with an appropriate io::Error return in order to improve error handling in the library. This change aims to provide better user experience and make the library more robust and reliable.

Thank you!


Unable to paste more than small snippets

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.56.2 (Current Stable)
OS Version: ChromeOS 91, VSCode running inside Crostini

Steps to Reproduce:

Copy more than small snippet of text
Cannot paste into other files

This may or may not be related to a similar issue raised today, but basically if I try to copy and paste more than a small snippet pasting fails entirely.
It isn't a problem with copy (or the OS paste) as I am able to copy from VSCode and paste into gedit or into Chrome as per usual. Only pasting into VSCode fails.
This might be related to the fact that ChromeOS 91 has just been released which integrates Crostini copy-paste support with the ChromeOS native clipboard. (Article on change)

Please check if the issue persists with latest stable 1.73

Please check if the issue persists with latest stable 1.73

No, this was fixed pretty quickly that I had forgotten I even submitted the issue.


Provide a way to get a browserWindow from a webView webContents

Ive worked around this but spent some time puzzling.. my webview sends an ipc message to the main process.. now i want to do something to the window containing the webview.. if i use fromWebContents I get undefined.
A similar issue occurs if i want to broadcast an ipc message to all webcontents and webviews, I must enumerate browserWindows, then write code in each browserWindow that receives the message and forwards to every webview.

Isn't that by the design of the webview? That it can't interface and manipulate directly with the parent? And that it is it's own process outside of your application? You need to send an IPC message to the parent with an instruction or event handle and then have the parent be the interpreter and manipulate itself based on that instruction. IE, the IPC message is doSomething and your capture in the parent calls a function doSomething() with or without arguments sent with the IPC.

I definitely want a webview in its own process and im fine with no direct manipulation of parent. I want the main thread to be able to work out what window a webview message is coming from.
When you send an ipc message from the webview, it goes to the main process, not the parent webview.. How do you send a message to the parent? I assume its postMessage on opener ?
Btw that link you provided is just to the webview documentation, where i cant see a mention pf parent.

(In my case the main thread is deciding what to do thats why i dont want to post to parent and have the parent do it)


Night CI 2023-08-19: Failed

action url: https://github.com/kdoctor-io/kdoctor/actions/runs/5913282632

Duplicate #141


"Error: Command failed: yarn prisma generate"

Happened on a fresh create-t3-app install with all 'yes' selected

Forcing it to re-install the packages seems to fix it

I think installing these two packages in a Promise.all causes the issue
https://github.com/nexxeln/create-t3-app/blob/8c9f0f2f33fb555109728341e9c628790728aa45/src/installers/prisma.ts#L12:L25
await Promise.all([
    installPkgs({
      packageManager,
      projectDir,
      packages: ["prisma"],
      devMode: true,
     }),
    installPkgs({
      packageManager,
      projectDir,
      packages: ["@prisma/client"],
      devMode: false,
     }),
]);

Instead doing it this way seems to fix the issue.
await installPkgs({
    packageManager,
    projectDir,
    packages: ["prisma"],
    devMode: true,
});
await installPkgs({
    packageManager,
    projectDir,
    packages: ["@prisma/client"],
    devMode: false,
 });

fixed in #32


Kong's interaction with binary nginx access modules

Hello,
I have a custom nginx access module. It executes before the lua module and sometimes it returns HTTP_UNAUTHORIZED. When this happens I get no response whatsoever from Kong (no headers, no body, the http connection is just closed). I get the following error in the logs:
failed to run header_filter_by_lua*: /usr/local/share/lua/5.1/kong.lua:218: attempt to index field 'plugin' (a nil value)
I suspect the following happens: the access_by_lua set by Kong is not executed any more => some ngx.ctx variables (ngx.ctx.api or ngx.ctx.stop_phases for example) are not set => they are checked/used later, for example in the {header|body}_filter_by_lua callbacks and, as they are not defined, those ngx.ctx variables cause errors in the lua interpreter.
I have replaced if not ngx.ctx.stop_phases then by if ngx.ctx.stop_phases ~= nil and not ngx.ctx.stop_phases then in the exec_plugins_{header|body}_filter in kong.lua and now I'm getting normal responses from kong, i.e. I'm getting the 401 Unauthorized header with the corresponding error message from nginx.
I propose that all kong lua callbacks check first for the existence of one ngx.ctx.api or ngx.ctx.plugin or ngx.ctx.stop_phases before taking action.

Thanks for bringing this up, I'll take a look at changing it, but you can also submit your changes via a PR!

I've created a pull request names "Issue 594" to address this issue.

May I ask how exactly are you exiting from your module? For example with lua-nginx-module, if you call ngx.exit, then other context handlers are not supposed to be executed. Basically I do not understand why you are entering the header_filter_by_lua context if you are exiting before the Lua module.

Here's a snippet of the code of my binary nginx module. It's really a binary handler, written in C and compiled into nginx. It has nothing to do with lua or ngx_lua_module, it does not "see" the ngx.exit function.
The handler is the only callback that my module sets. I have simplified the code, removed the conf directives and the conf creation and merging callbacks. I think the code below is sufficient for reproduction.
ngx_module_t ngx_http_check_digest_module = {
    NGX_MODULE_V1, &module_ctx, NULL, NGX_HTTP_MODULE, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NGX_MODULE_V1_PADDING
};

static ngx_http_module_t module_ctx = {
    NULL, &hook_setup, NULL, NULL, NULL, NULL, NULL, NULL
};

static ngx_int_t hook_setup(ngx_conf_t *cf) {
    ngx_http_handler_pt *h;
    ngx_http_core_main_conf_t *cmcf;
    cmcf = ngx_http_conf_get_module_main_conf(cf, ngx_http_core_module);
    h = ngx_array_push(&cmcf->phases[NGX_HTTP_ACCESS_PHASE].handlers);
    if (NULL == h)
        return NGX_ERROR;
    *h = &handler;
    return NGX_OK;
}

static ngx_int_t handler(ngx_http_request_t *r) {
   /* most of the time this function returns NGX_DECLINED */
   /* but sometimes it returns NGX_HTTP_UNAUTHORIZED */
   /* the function does not modify any field of the ngx_http_request_t structure */
   return NGX_HTTP_UNAUTHORIZED;
}

Here's a snippet of the code of my binary nginx module. It's really a binary handler, written in C and compiled into nginx. It has nothing to do with lua or ngx_lua_module, it does not "see" the ngx.exit function.

Yes, it was my understanding already.
I will see into this.

I've compiled nginx with debug symbols and I get the stack trace below. So the lua_header_filter callbacks are invoked when nginx tries to send the error response that was triggered by the binary module's HTTP_UNAUTHORIZED (ngx_http_finalize_request->...->ngx_http_send_special_response->ngx_http_send_header->...->ngx_http_lua_header_filter).
#0  ngx_http_lua_header_filter (r=0x18cd5e0) at ../ngx_lua-0.9.16/src/ngx_http_lua_headerfilterby.c:239
#1  0x00000000004963be in ngx_http_not_modified_header_filter (r=0x18cd5e0) at src/http/modules/ngx_http_not_modified_filter_module.c:61
#2  0x0000000000460f44 in ngx_http_send_header (r=0x18cd5e0) at src/http/ngx_http_core_module.c:1954
#3  0x0000000000469748 in ngx_http_send_special_response (r=0x18cd5e0, clcf=0x18e27c8, err=9) at src/http/ngx_http_special_response.c:662
#4  0x00000000004690fd in ngx_http_special_response_handler (r=0x18cd5e0, error=401) at src/http/ngx_http_special_response.c:474
#5  0x000000000046e3ff in ngx_http_finalize_request (r=0x18cd5e0, rc=401) at src/http/ngx_http_request.c:2327
#6  0x000000000045f338 in ngx_http_core_access_phase (r=0x18cd5e0, ph=0x1907790) at src/http/ngx_http_core_module.c:1121
#7  0x000000000045eb4d in ngx_http_core_run_phases (r=0x18cd5e0) at src/http/ngx_http_core_module.c:851
#8  0x000000000045eaba in ngx_http_handler (r=0x18cd5e0) at src/http/ngx_http_core_module.c:834
#9  0x000000000046d88a in ngx_http_process_request (r=0x18cd5e0) at src/http/ngx_http_request.c:1904
#10 0x000000000046c311 in ngx_http_process_request_headers (rev=0x190ec60) at src/http/ngx_http_request.c:1335

I have compiled OpenResty with a similar module, found the issue, and will provide a fix for it in the refactor/resolver branch. Thanks for the report, I will let you know when it's done so you can try it out before we push a hotfix release.

#708 now handles this properly, and I ended up refactoring kong.lua. Not sure it will be released in a hotfix, but definitely in the next version. If you need it for now I suggest sticking to checking the stop_phases variable for its initialization like you did.
Thank you for reporting this!


Remove example-ldap repo from the integration test

Since the data of example-ldap has been moved to cmd/kustomize. We don't need to checkout the example-ldap repo any more.
We can remove this repo from the checkout list.
As well as example-ldap-customized
https://k8s-testgrid.appspot.com/sig-cli-misc#kinflate-periodic-default-gke

The log from the test
I0507 15:46:17.557] Call:  git init github.com/kinflate/example-ldap
I0507 15:46:17.562] Initialized empty Git repository in /go/src/github.com/kinflate/example-ldap/.git/
I0507 15:46:17.563] process 251 exited with code 0 after 0.0m
I0507 15:46:17.563] Call:  git config --local user.name 'K8S Bootstrap'
I0507 15:46:17.566] process 252 exited with code 0 after 0.0m
I0507 15:46:17.566] Call:  git config --local user.email k8s_bootstrap@localhost
I0507 15:46:17.569] process 253 exited with code 0 after 0.0m
I0507 15:46:17.569] Call:  git fetch --quiet --tags https://github.com/kinflate/example-ldap master
I0507 15:46:17.929] process 254 exited with code 0 after 0.0m
I0507 15:46:17.929] Call:  git checkout -B test FETCH_HEAD
W0507 15:46:17.933] Switched to a new branch 'test'
I0507 15:46:17.934] process 263 exited with code 0 after 0.0m
I0507 15:46:17.934] Call:  git show -s --format=format:%ct HEAD
I0507 15:46:17.937] process 264 exited with code 0 after 0.0m
I0507 15:46:17.938] Checkout: /go/src/github.com/kinflate/example-ldap-customized master to /go/src/github.com/kinflate/example-ldap-customized
I0507 15:46:17.938] Call:  git init github.com/kinflate/example-ldap-customized
I0507 15:46:17.942] Initialized empty Git repository in /go/src/github.com/kinflate/example-ldap-customized/.git/
I0507 15:46:17.943] process 265 exited with code 0 after 0.0m
I0507 15:46:17.943] Call:  git config --local user.name 'K8S Bootstrap'
I0507 15:46:17.946] process 266 exited with code 0 after 0.0m
I0507 15:46:17.946] Call:  git config --local user.email k8s_bootstrap@localhost
I0507 15:46:17.949] process 267 exited with code 0 after 0.0m
I0507 15:46:17.949] Call:  git fetch --quiet --tags https://github.com/kinflate/example-ldap-customized master

The latest test passed https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kinflate-periodic-default-gke/632


References

How can I add other assemblies as reference to a module?
And how can I set the module kind?

You can load other assemblies through ModuleResolver.Load() or Resolve(), the assembly reference list will be automatically generated based on which members are referenced in the IR when saving the module.
Can you clarify on what you mean by module kind?
Sorry for delayed response, I missed this earlier

A dotnet assembly can be a dll, a windows executable or a console app.

I see. DistIL only supports generating .NET core modules and these are only in the form of Windows DLLs. The dotnet sdk can deploy an additional .exe for launching the runtime and DLL, which I believe is just patching a pre-built apphost.exe.
I'm not sure that is in scope for DistIL since it seems like that would have some versioning complications, but I haven't looked deep at this.


migrate this package to null safety

Description
Migrate this package to null safety.
Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

Is this expected output?

Hi @Abhishek01039 👋
Thanks for opening a pull request! Can you please change the target branch to be null_safety?

Is this expected output?
Yes there is a random chance of an error happening in the example app to illustrate the error handling/retry behavior.


Blog app - controllers specs

In this project, I did the following:

Add RSpec as a gem to my project.
Create a Request spec file for all my controllers.
For each action, I checked:

If the response status was correct.
If a correct template was rendered.
If the response body includes correct placeholder text.

I'm happy you noticed the issue and I'm happy that I have already fixed the issus


Decide whether to keep bind_dice()

Decided to remove it. It's cute, but I'm not convinced it's worth spending API on.


google_api_availability does not specify a Swift version and none of the targets

🐛 Bug Report
google_api_availability does not specify a Swift version and none of the targets (Runner) integrating it have the SWIFT_VERSION attribute set. Please contact the author or set the SWIFT_VERSION attribute in at least one of the targets that integrate this pod.

Expected behavior
Reproduction steps
Configuration
Version: 3.0.0
Platform: Both

[ ] :iphone: iOS
[ ] :robot: Android

Please update to version 3.0.1 of the Geolocator plugin. This takes a dependency on google_api_availability version 2.0.0 which is updated to use Objective-C instead of Swift. This should solve your problem.


polish up

Hey, I found your repo when looking for a hapi s3 proxy.
I'd like to use it in prod, but saw that some of your dependencies are out-dated and no tests are there. Also readme docu was kind of missing. So i polished up the code. I'm sorry that this is a rather big PR, but maybe if you have time you could check it. It contains a few changes that would require a major version upgrade.
changes

major key and and filenamefunctions should  return a Promise
minor bucket can now also be a function (means it's not passed to constructor but to every getObject call)
minor add s3Params to pass additional options to the s3 constructor
minor if filename not given but mode !== false -> take the key's filename
removed Makefile and put commands to package.json
update npm dependencies
apply eslint rules from airbnb/base
update readme
added tests

This looks awesome! I keep meaning to come back and clean this up and write some tests, but other stuff keeps coming up. I'll take a closer look at this over the weekend, but it looks great so far.

hey just a quick note. you might want to remove the npm postinstall script again. it's actually just necessary when working with a github depenedency, but since it will be build when publishing it, it;s not needed to build it after it was installed

btw. thanks for looking at it :+1:

Good catch. I'll update that and publish 1.0.1.
And no, thank you for contributing!


Step 9 contains incorrect "Espresso-Intents" subheadings

In Step 9, the "Espresso-Contrib" section, there are two subheadings for the test cases sections labelled "Espresso-Intents Test #". As this is the "Espresso-Contrib" section, the subheadings should be "Espresso-Contrib Test #".

Closing as this section no longer exists as of the latest update. Thanks for catching the mistake though!


Error [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string without null bytes. Received type object

here's my code
extract(bufferZip.buffer, { dir: `${__dirname}/assets`}, err => {
  if (err) console.log(err)
})

I throw buffer as the input arguments, thanks for helping.

I also have this issue, even with just a plain string literal.

Okay wait nevermind look at #56


Fixed: infinite scroll issue when used with searchbar(dxp-289)

Related Issues

https://github.com/hotwax/dxp-components/issues/289
Short Description and Why It's Useful
Removed the logic to re-render the infinite-scroll on queryString check that has been added in the previous PR.
Added a variable to check whether the scrolling can be enabled or not whenever users lands on the list page. For this, we have determined the height of the content part scroll and infiniteScroll component and if the height is less than 0 then only enabling the infinite-scroll component
Removed disabled as once the infiniteScroll is disabled it does not gets enabled again, hence removed the disabled property and instead used v-show to enable/disable infinite scroll.
Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

We need to handle the same for the parking page as well.

No issue in scrolling on parking page.


@applitools/eyes-storybook dependency is broken

The package @applitools/eyes-storybook seems to have just disappeared from npm, breaking the superset build as it's a dependency of eyes-storybook. This may need to be chased with the maintainer of that package or worked around.
How to reproduce the bug

Try to build superset

Environment
(please complete the following information):

superset version: 2.1.0

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional info
Raised in slack a few minutes ago: https://apache-superset.slack.com/archives/C015WAZL0KH/p1686660128238069 and it appears to be affecting the entire community.

Looks like the package has reappeared; I guess applitools spotted the mistake fairly quickly. Rerunning my build with the dependency back in place now and will close this issue once I see it pass. This was probably just a one-off.

Looks like it's fixed, my build passes now.


fix can't get latest offset in KafkaEightSimpleConsumerFirehoseFactory

when startOffset is null which means the first time coming in, the offset is set to 0
      PartitionConsumerWorker worker = new PartitionConsumerWorker(
          feed, kafkaSimpleConsumer, partition, startOffset == null ? 0 : startOffset
      );

This will cause the kafka fetch to start from 0 offset, which is a valid offset meaning earliest.
      FetchRequest request = new FetchRequestBuilder()
          .clientId(clientId)
          .addFetch(topic, partitionId, offset, FETCH_SIZE)
          .maxWait(timeoutMs)
          .minBytes(1)
          .build();

      log.debug("fetch offset %s", offset);

      try {
        response = consumer.fetch(request);
      }
      catch (Exception e) {
        ensureNotInterrupted(e);
        log.warn(e, "caught exception in fetch {} - {}", topic, partitionId);
        response = null;
      }

The offset can only be reset to latest by calling "getOffset(earliest)" when reponse is null
      if (response == null || response.hasError()) {
        short errorCode = response != null ? response.errorCode(topic, partitionId) : ErrorMapping.UnknownCode();
        log.warn("fetch %s - %s with offset %s encounters error: [%s]", topic, partitionId, offset, errorCode);

        boolean needNewLeader = false;
        if (errorCode == ErrorMapping.RequestTimedOutCode()) {
          log.info("kafka request timed out, response[%s]", response);
        } else if (errorCode == ErrorMapping.OffsetOutOfRangeCode()) {
          long newOffset = getOffset(earliest);

To fix this, we can just set startOffset to -1 if it is null to make the "response" to null to force calling getOffset()

@kaijianding this seems reasonable, have you verified that it works?
Also have you looked into the Kafka indexing service (http://druid.io/docs/latest/development/extensions-core/kafka-ingestion.html) at all? It has some advantages over the simple consumer firehose:

the Firehose/Plumber setup has design flaws that prevent exactly once ingestion, even with commitMetadata; the Kafka indexing service uses a new Appenderator setup meant to address those flaws.
the Kafka indexing service can scale up and down without losing metadata.

yes, I have verified that works.
I have read the "Kafka indexing service".
But We're still using 0.9.0, we have some modifications only for company inner usage on 0.9.0. We'd like to migrate to 0.9.2 when it is released.

Ok, fair enough.
👍  from me, this change looks good.

👍


Update EventMachine to 1.2.6 or newer

EventMachine 1.2.6 implements a fix for an incompatibility with newer compilers. This is currently affecting our FreeBSD 11 CI builds (https://github.com/sensu/sensu-omnibus/issues/270) and will likely break on other platforms as newer versions of compilers are added to package repositories.

Closed by #1912


Update Apps-Engine

Part of https://github.com/WideChat/Rocket.Chat/pull/774

Part of https://github.com/WideChat/Rocket.Chat/issues/742


dataset and datasetkey in gms.api relates to its model entity in metadata-models?

I am curious about the dataset and datasetkey in gms.api related to dataset entity in metadata-models.
The same questions applies to dataprocess and corpuser.
My understanding is that datasetkey in gms.api contains how an Urn is defined. dataset in gms.api contains those optional aspects. It seems working well for corpuser from this understanding. But for dataset in gms.api, it has information which is not related to aspects.
I also searched around, and it seems that generated classes for datasetkey and dataset in gms.api are never used anyway - I might be wrong .

You're correct that dataset](https://github.com/linkedin/datahub/blob/master/gms/api/src/main/pegasus/com/linkedin/dataset/Dataset.pdl) and datasetkey are used solely in the context of the datasets rest.li endpoint. Due to legacy reason we have some fields in dataset that are not proper GMA aspect. We're in the process of migrating those dependencies so hopefully in a few more releases it'll be as clean as corpuser.


Fix a stack overflow when an invalid block is encountered

A call to delete_block is present in verify_and_commit_block (which IMO is the superior callsite), so we can remove it from receive_block. This change allowed me to continue syncing past the point where a stack overflow would occur otherwise (while still encountering the invalid block).
Appears to fix https://github.com/AleoHQ/snarkOS/issues/1251, will run my node for a bit longer just to be safe.

@Protryon this change has been working for me just fine; are you OK with it being merged in this shape? and should we aim for a small release once it's in?


[bug] admiral.sh restart doesn't work on onebox install

https://github.com/Shippable/pm/issues/10352
This is happening because we have a check which tries to start the db container, if DB_IP and ADMIRAL_IP are same. If the container is not found, the restart script exits with the error that db container is not found. Since, db is now installed on host, we should continue with the flow if db container is not found if DB_IP and ADMIRAL_IP are same, like we do for multi-box install

this is done, closing


Changes to context do not propagate

I believe this is a problem with asyncConnect containers where updating context does not properly propagate updates to children. I had to create a wrapper around react-redux's connect to get context changes to propagate. Do I need to do something similar for asyncConnect?

It looks like this library directly uses react-redux's connect, how would I go about injecting my own connect function instead? Or somehow passing the {pure: false} setting so it knows to update child components on context changes...

Ended up making a similar wrapper for the asyncConnect decorator and context updates propagate once again:
import { asyncConnect } from 'redux-connect';

export default function myAsyncConnect(asyncItems, mapStateToProps, mapDispatchToProps) {
  return asyncConnect(asyncItems, mapStateToProps, mapDispatchToProps, null, {pure: false});
}

Feel free to close, might be cool to add this to FAQ or somewhere indexable by Google for "context updates don't propagate asyncConnect / redux". Thanks for the awesome lib!

There is no need to wrap like this, asyncConnect accepts exactly the same args as connect, and its actually documented ;)

https://github.com/makeomatic/redux-connect/blob/master/docs/API.MD#asyncconnect-decorator

Sure, but it's cleaner to just do
asyncConnect([
  Container.asyncConnect,
])

rather than
asyncConnect([
  Container.asyncConnect,
], null, null, null, {pure: false})

all over the codebase. Containers shouldn't have to remember to pass {pure: false} just to get context update to propagate... Seems like a bug in react-redux's connect tbh.

Thats not a bug, its a performance feature. Pure means it does shallow props check and if no props changed then it wouldnt rerender. Shallow means it doesnt check nested properties of the object, but merely checks their references. Because context itself doesnt change, but instead it has a changed prop inside it - your component doesnt see it, hence it doesnt update without the pure: false setting. So if you set it to false you are really killing a lot of CPU of your users

I'm not sure what you mean by context itself not changing though. My context changes from {obj: {foo: 'bar'}} to {obj: {foo: 'baz'}} and updates don't propagate to components who care about obj.foo and specify that in their contextTypes. How's that not a bug?

Read more here - https://github.com/reactjs/react-redux/blob/master/docs/api.md#connectmapstatetoprops-mapdispatchtoprops-mergeprops-options
Its a basic performance feature. Your context is not checked beyond the upmost references. It might be counter intuitive, but you have to understand that every time state changes - every connected component render will be called, and your state changes upon every action there is. So, effectively, when you set something to pure: false - this component will rerender every time your state changes. Literally on any action

I am changing context via Object.assign({}, obj, {foo: 'baz'}) so it should be completely changing the reference. Maybe React is being "smart" and changing keys on the underlying object under the hood? I'll take a look at the link.

So, effectively, when you set something to pure: false - this component will rerender every time your state changes. Literally on any action

You mean if a sub-component changes state then the whole tree will re-render? What else can I do to get context updates to propagate without that perf hit?

Not much, really. You are fine if you don’t have that many non-pure components. But if you rely on your context too heavily - you should pass that data as props instead

On Feb 7, 2017, at 4:45 PM, Andrew Rasmussen<EMAIL_ADDRESS>wrote:
I am changing context via Object.assign({}, obj, {foo: 'baz'}) so it should be completely changing the reference. Maybe React is being "smart" and changing keys on the underlying object under the hood? I'll take a look at the link.
So, effectively, when you set something to pure: false - this component will rerender every time your state changes. Literally on any action
You mean if a sub-component changes state then the whole tree will re-render? What else can I do to get context updates to propagate without that perf hit?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/makeomatic/redux-connect/issues/106#issuecomment-278193188, or mute the thread https://github.com/notifications/unsubscribe-auth/ABol0bmk4PMeeObOYkJcJib5uJUylx4Aks5raRAfgaJpZM4L6NRn.

Hmm. I use context for the current viewer and company (customer), pretty much everything else is passed via props. That being said, every single container I use that fetches data (14 of them) is set to {pure: false} to fix this context propagation issue throughout my app. I don't perceive any performance issues on desktop or mobile. Do you think this is a major issue? I don't really see another great workaround besides passing viewer/company down as props...

if they dont change often, that still should be fine, JS is obviously fast enough and would do hundreds of thousands of evaluations per second (modern CPUs 💃 ), so you wouldnt really notice it - all the underlaying components should still be pure and wont rerender

Yeah they pretty much only update when the user explicitly edits one of them and they get reloaded. Which is only on a few specific components (edit user, edit company, login, logout, etc). Cool man, thanks for your repsonsiveness and helpfulness!


Evaluate MH-11988: Change karaf Shutdown Command

With MH-11988 Opencast 2.3.1 now advises to change the karaf shutdown command. I would argue that this is not necessary for these Docker images as anyone, who has access to the shutdown port, is already within the container, probably as root.  But I would like to here other opinions.
cc @JanKoppe @lkiesow

Closing this because of the reasons mentioned above.


Availability of Rendered SST2 and Country211 datasets

Hi,
Thanks for the great work! In the paper, it mentions "we created two datasets that we call Country211 and Rendered SST2. The Country211 dataset is designed to assess the geolocation capability of visual representations. We filtered the YFCC100m dataset (Thomee et al., 2016) to find 211 countries (defined as having an ISO-3166 country code) that have at least 300 photos with GPS coordinates, and we built a balanced dataset with 211 categories, by sampling 200 photos for training and 100 photos for testing, for each country"
I wonder if it is possible to share those two datasets for reproducibility purpose? Thanks!

Hi,
i would also be interested in these datasets. Especially Country211 as i find this type of problem really interesting.
Thanks!

Added in efe8cbbdf3e594999706558de021de55e04cab5f !

@jongwook  Thanks for adding them!

Hi, @jongwook, btw, in CLIP paper, the number of training images is listed as 43200, which is probably a typo, as 200 * 211 = 42200.


Translation capabilities for user-defined fields

Kristijan had the idea to give the users the ability to provide fields (title, description, etc) in multiple languages.
I'd be up to look more into it when there is enough user need (e.g. when ~5 groups have expressed that they would need this feature).

In the interface - maybe something like left and right pane - left the source  language - on the right the target language to translate to. And dropdown box for the languages?

I think instead of implementing our own translation service, we could integrate one of the existing ones (weblate/pootle...)

There is no interest/discussion about this for some time now. Re-open if interested again!


Feat: Hover Effect on Nav Bar

As of now, when we go from home to experience or any other section of the nav bar there is no hover effect.

These are some examples, I can do something like that.
I would like to work on this issue under SWoC'21. Please assign this issue to me.

Now onwards, we are planning to create the navbar components from scratch instead of using bootstrap. @im-sakshijain if you wish to do it, could you please DM @anushbhatia over slack.
Remember: the navigation bar would be complete in 2-3 PRs over a week's time and requires commitment. Since we'll follow a particular color palette, use micro animations as well as transition effects each for dark and light modes

Now onwards, we are planning to create the navbar components from scratch instead of using bootstrap. @im-sakshijain if you wish to do it, could you please DM @anushbhatia over slack.
Remember: the navigation bar would be complete in 2-3 PRs over a week's time and requires commitment. Since we'll follow a particular color palette, use micro animations as well as transition effects each for dark and light modes

Okay Got it! I want to do this. I'll DM to @anushbhatia. Thank you.

Okay Got it! I want to do this. I'll DM to @anushbhatia. Thank you.

Sir is this issue still open??

Sir is this issue still open??

GO ahead with the 3rd one I would prefer that with colour palette specified in the pinned issue

GO ahead with the 3rd one I would prefer that with colour palette specified in the pinned issue

https://user-images.githubusercontent.com/62291788/105733306-6b2f7d80-5f57-11eb-90ac-72b2b1d5058e.mp4
Is this effect fine?

https://user-images.githubusercontent.com/62291788/105733306-6b2f7d80-5f57-11eb-90ac-72b2b1d5058e.mp4
Is this effect fine?

Refer #487 for the colour palette. The hove effect can be the same that you have done on the portfolio site

Refer #487 for the colour palette. The hove effect can be the same that you have done on the portfolio site

2021-01-25.21-50-53.mp4
Is this effect fine?

any updates?

2021-01-25.21-50-53.mp4
Is this effect fine?

any updates?

What exactly,  I've to do with color palette, like the hover color should be #f4f4f4 ? Or should  I change  the hover effect?

What exactly,  I've to do with color palette, like the hover color should be #f4f4f4 ? Or should  I change  the hover effect?

What exactly, I've to do with color palette, like the hover color should be #f4f4f4 ? Or should I change the hover effect?

@anushbhatia

What exactly, I've to do with color palette, like the hover color should be #f4f4f4 ? Or should I change the hover effect?

@anushbhatia


Open Transport Request popup on click

Open Transport Request popup on click
Added "praise" program (someone just does not want to be ZBLAMED =).
Added navigation to SE10 popup on "transport request" click (to the left of a source code line, and at the bottom "Requests" list)

This is my first PR =) so it might be not really conventional =) Sorry for that.

Hi @oisee,
Thanks so much for the PR! The first one :)
I'm quite busy right now so it will take me some days to give this the attention it deserves. I'm writing this just so that you know it's not being ignored.
Cheers!

Hi @oisee,
Thanks so much for the PR! The first one :)
I'm quite busy right now so it will take me some days to give this the attention it deserves. I'm writing this just so that you know it's not being ignored.
Cheers!

Thank you for such an amazing tool =)
(BTW, it is my first PR, so, feel free to reject and make me do it properly :D )

Hi there @oisee,
I finally found some time for this project. Long due.
Regarding your PR, I won't be able to merge it for 3 reasons:

You applied pretty printer to the code which yields lots and lots of differences. Any change you make must keep the current formatting so that we can easily see what was really changed
I found the PRAISE program funny, but I called it BLAME because this is a known git concept so it really makes sense to stick to the same name. Sorry :-)
You're right! A lot of fundamental links are needed! But actually I had already added links to the requests and authors several months ago. Unfortunately I was unable to submit those changes at the time (actually today I tried again to submitted and found that I am still getting an authentication error. I'll have to figure out what's wrong). I am sorry about this.

Your future PRs are more than welcome. I suggest, though, that you first submit an issue and propose to implement it. This way we can discuss it before you go along and implement it, to avoid wasted work.
Thanks again! And I'm glad you like this tool. I also find it quite useful!
Cheers!

@nununo, tnx for the feedback =)

I found the PRAISE program funny, but I called it BLAME because this is a known git concept so it really makes sense to stick to the same name.  (But I wonder if you are aware of sporadic attempts to add the "praise" alias to the GIT? I remember this kind of news since ~5 y ago or so. =) And yes, some of those who are not exposed to the GIT concepts feel a bit wounded when "BLAMED", so why not to PRAISE them (Snowflake feelings matter =)
Tnx for the suggestion to log the issue first, to be able to discuss. (Yes, I implemented the "feature" first (after pretty printing which cannot be undone) and only then realized that I can do PR =)
Tnx a million.
Best regards, Ilia.

Hi @oisee,
Oh, I didn't know that there had been a actual discussion about praise/blame lol. That makes your joke even more funny.
Regarding pretty printer, I'm also struggling with it because Eclipse automatically reformats the code and even reorders the method implementations. I still don't have a solution for it. I'll probably have to start editing things in SE24 again :p
I don't know if you saw my last commits but the links to requests and to the source code are now in place. The link to the author is already in there but it doesn't work and I still didn't figure out why. Probably a detail in how the FM is called.
Thanks again for your contribution and enthusiasm!
Cheers,
Nuno


Check for implicitly unwrapped relationships in getOptionalProperties

Quick, potential fix for #3768
Playing around in a playground I found that childMirror.displayStyle for a T! (where T: Object) is .enum while childMirror.displayStyle for T? is .optional using Swift 3.0. Haven't explicitly tested on any previous Swift version, but I assume this is what's causing the problem.
Also haven't verified that the specific implicitly unwrapped properties in my app works, but it does at least launch now.

Thanks for the PR, @Anviking! We'll need you to accept our Contributor License Agreement before we can merge your contributions.
Cheers,
The robots and humans at Realm

Hi @Anviking, thanks for doing this (and accepting our CLA, I just verified that). This would bring us back to the behavior in Swift 2.2, which I'm in favor of. Realm can never guarantee that an object property will always be fulfilled, but if the user (e.g. you) explicitly ignores that, we should continue to support that behavior IMHO.
We also had unit tests that verified this behavior in Swift 2.2 (source). Could you also re-introduce these in the Swift 3 tests please?

@jpsim done!

(And rebased against master yesterday)

Thanks for updating this @Anviking! Just had one last comment about the unit test.

Looks good. Thanks for your contribution @Anviking!


10.0.22000.2899 not supported

Hi there! Again, thanks as always for this great tool!
I got not supported for 10.0.22000.2899
Can you help out?
Best!
termsrv.zip

https://github.com/loyejaotdiqr47123/rdpwrap/commit/3d366d10d9e27e410b1c71ea2bbb22d3718236c9

I modified the ini with the change commited and the remote desktop service stops. If I remove the [10.0.22000.2899] section it starts working again.
I tried with the RDPWrap verstion 1.5, 1.6.2 and 1.8.2. Same things happens

I found the exact same behavior. The service stops without any clear explanation in eventsmgr. Hope someone finds a clou what to do with the newest update.

I get this instant crash of the RDP Service when I install RDP Wrapper:
Name der fehlerhaften Anwendung: svchost.exe_TermService, Version: 10.0.22000.2600, Zeitstempel: 0x86a2ea8d
Name des fehlerhaften Moduls: rdpwrap.dll, Version: <IP_ADDRESS>, Zeitstempel: 0x65d1bab3
Ausnahmecode: 0xc0000005
Fehleroffset: 0x000000000007d121
ID des fehlerhaften Prozesses: 0x2f4
Startzeit der fehlerhaften Anwendung: 0x01da8cab9369e347
Pfad der fehlerhaften Anwendung: C:\WINDOWS\System32\svchost.exe
Pfad des fehlerhaften Moduls: c:\program files\rdp wrapper\rdpwrap.dll
Berichtskennung: 7d4376f6-0100-461b-91a6-2de9119d3c91
Vollständiger Name des fehlerhaften Pakets:
Anwendungs-ID, die relativ zum fehlerhaften Paket ist:
termsrv.zip
The fact this refers to 2600 when the original is 2899 is correct I suppose? Anything I can try?

termsrv.zip

RDPWrap-v1.8.2.zip Try running uninstall.bat and install.bat You don't need to modify rdpwrap.ini

Results in same crash auf the service. As if MS detects the change now or maybe its gotta do with the recognition of unwanted software?

I modified the ini with the change commited and the remote desktop service stops. If I remove the [10.0.22000.2899] section it starts working again. I tried with the RDPWrap verstion 1.5, 1.6.2 and 1.8.2. Same things happens

RDPWrap-v1.8.2.zip Try running uninstall.bat and install.bat You don't need to modify rdpwrap.ini

I've already  tried that and it crashes.

I rolled back since no solution for 22000.2899 yet.

I get this instant crash of the RDP Service when I install RDP Wrapper:
Name der fehlerhaften Anwendung: svchost.exe_TermService, Version: 10.0.22000.2600, Zeitstempel: 0x86a2ea8d Name des fehlerhaften Moduls: rdpwrap.dll, Version: <IP_ADDRESS>, Zeitstempel: 0x65d1bab3 Ausnahmecode: 0xc0000005 Fehleroffset: 0x000000000007d121 ID des fehlerhaften Prozesses: 0x2f4 Startzeit der fehlerhaften Anwendung: 0x01da8cab9369e347 Pfad der fehlerhaften Anwendung: C:\WINDOWS\System32\svchost.exe Pfad des fehlerhaften Moduls: c:\program files\rdp wrapper\rdpwrap.dll Berichtskennung: 7d4376f6-0100-461b-91a6-2de9119d3c91 Vollständiger Name des fehlerhaften Pakets: Anwendungs-ID, die relativ zum fehlerhaften Paket ist: termsrv.zip
The fact this refers to 2600 when the original is 2899 is correct I suppose? Anything I can try?
 termsrv.zip

ACCESS_VIOLATION (0xC0000005)
This is caused by accessing an invalid memory address.

Fix the problem of automatic stopping after service startup。
RDPWrap-1.8.3.zip

Hi @loyejaotdiqr47123 , I've just installed 1.8.3 and it is not working.
Thank you for your efford

Should wrapper version be <IP_ADDRESS>?

Hi @loyejaotdiqr47123 , I've just installed 1.8.3 and it is not working. Thank you for your efford

Uninstall and reinstall?

包装版本应该是 <IP_ADDRESS> 吗？

Yes.This is just the version of rdpwrap.dll

Hi @loyejaotdiqr47123 , I've just installed 1.8.3 and it is not working. Thank you for your efford

Uninstall and reinstall?

Please check if your anti-virus software is blocking

Hi @loyejaotdiqr47123.  I disabled the antivirus and nothing changed.
I can try whatever you need.

I did uninstall and install btw

Can confirm same thing here,... Service not starting with 1.8.3. If I use the "legacy" version 1.6.2, service starts but it shows not supported.  Any help is appreciated.

@sashaqwert Do you have a way to fix it? Can you add the Label "bug"?

@loyejaotdiqr47123
I can't fix this.
I can add vug label. Vut I'm recommendcask @binarymaster for this.

Issues with "add build" label are not bugs and don't need a "bug" label.

Sorry if I missed something. No solution for this version, right?

Sorry if I missed something. No solution for this version, right?

RDPWrap-mod-v<IP_ADDRESS>.zip
Try this

Can't download. Brave intercepts it with no option to override.

Can't download but I can download previous versions.

Just FYI, my termsrv got updated to 10.0.22000.2960.
I got the RDP Wrapper working using v1.8.2 and https://github.com/loyejaotdiqr47123/rdpwrap/blob/master/res/rdpwrap.ini
Best,

Reopened. Not included in official INI by Stas'M


[SPARK-27636][MLLIB]Remove cached RDD blocks after PIC execution

What changes were proposed in this pull request?
Test steps to reproduce:

bin/spark-shell

val dataset = spark.createDataFrame(Seq(
                                    (0L, 1L, 1.0),
                                    (1L,2L,1.0),
                                    (3L, 4L,1.0),
                                    (4L,0L,0.1))).toDF("src", "dst", "weight")

val model = new PowerIterationClustering().
                           setMaxIter(10).
                           setInitMode("degree").
                          setWeightCol("weight")

val prediction = model.assignClusters(dataset).select("id", "cluster")

Open storage tab of the UI. We can see many RDD block cached, even after running the PIC.

In this PR, basically materializes the new graph before unpersisting the old ones.
How was this patch tested?
Manually tested and existing UTs.
Before patch:

After patch:

Can one of the admins verify this patch?

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10421/
Test PASSed.

Test build #105132 has started for PR 24531 at commit fa6465d.

Test build #105132 has finished for PR 24531 at commit fa6465d.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105132/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10422/
Test PASSed.

Test build #105133 has started for PR 24531 at commit 99396f7.

cc @srowen @felixcheung Kindly review

Test build #105133 has finished for PR 24531 at commit 99396f7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105133/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10423/
Test PASSed.

Test build #105134 has started for PR 24531 at commit c17a191.

Test build #105134 has finished for PR 24531 at commit c17a191.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105134/
Test PASSed.

Thanks @viirya , I will update

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10451/
Test PASSed.

Test build #105163 has started for PR 24531 at commit 7234a7c.

After the PR, only one RDD is getting cached after the execution of PIC.( This rdd caching happens in the GraphImpl class which calls during normalize.)

Test build #105163 has finished for PR 24531 at commit 7234a7c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105163/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10477/
Test PASSed.

Test build #105194 has started for PR 24531 at commit d4bb41b.

Test build #105194 has finished for PR 24531 at commit d4bb41b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105194/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10512/
Test PASSed.

Test build #105228 has started for PR 24531 at commit 78e18ee.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10513/
Test PASSed.

Test build #105229 has started for PR 24531 at commit 9fd2643.

Test build #105228 has finished for PR 24531 at commit 78e18ee.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105228/
Test PASSed.

Test build #105229 has finished for PR 24531 at commit 9fd2643.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105229/
Test PASSed.

Test build #105239 has started for PR 24531 at commit 598a7a2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10520/
Test PASSed.

Test build #105239 has finished for PR 24531 at commit 598a7a2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105239/
Test PASSed.

Merged to master

Thanks @srowen @viirya


[4.2] make default min_rows in repeatable zero

WHY
BEFORE - What was wrong? What was happening before this PR?
The admin goes to add an entry that has a repeatable field. But that repeatable field isn't so important, so they don't fill it in. In fact, they remove that one "empty" entry from the repeatable, click "Save and Edit".
My expectation as an admin is to get to a form that looks the same way I submitted it. But no, an item appears again inside repeatable - an empty one.
AFTER - What is happening after this PR?
No more empty repeatable item after submitting an empty repeatable.
HOW
How did you achieve that, in technical terms?
Set the min_rows default to 0.
Is it a breaking change or non-breaking change?
Breaking, because it's a change in default behaviour.
How can we test the before & after?
Before: Go to Dummies in the demo, remove everything but the required. Click submit. Afterwards you'll have an empty entry inside each repeatable again.
After: You won't. You'll see the form exactly like you submitted it.

@pxpm I know we've already talked about this, and you don't like this. But I think the scenario above is the most likely scenario. For the repeatable to be a non-required field, and this to be an issue for admins. But it's just my intuition and personal experience, since nobody else complained about this until now.
I feel like the repeatable right now is unintuitive from that point of view:

if the field is non-required
you submit an empty repeatable
and then get a repeatable with one entry

So I think this PR is needed to fix that.
Technically, what would be even better... would be for the min_rows to default to:

0 when not required
1 when required

Buuuut... that would be difficult to override for the dev. And difficult to code in practice.
So I think a simple min_rows = 0 solution here is better than nothing. After all, the devs can easily override this if it doesn't fit their needs.
What do you think?

Ok .. I get it I guess.
It makes more sense now since the repeatable relationships also force init 0 to don't create empty relationships.
Let's do it!


kubernetes: update to 1.0.3, fix module

Merging this as it work for us in production.

Note: the test fails to evaluate since this PR http://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.kubernetes but apparently it hasn't successfully finished since February...