Improve the Loan Builder API

Extend the API of the Loan builder to accept double value (with an encapsulated converting them to BigDecimal).

Hi @ArtyomPanfutov ,
I want to contribute in this and henceforth I made changes and tried pushing this, but getting following failure.
remote: Permission to ArtyomPanfutov/loan-amortization-calculator.git denied to Bhavikaso.
fatal: unable to access 'https://github.com/ArtyomPanfutov/loan-amortization-calculator.git/': The requested URL returned error: 403
Please, could you guide me how can I contribute here
Thanks
Bhavika

Hi @Bhavikaso!
Could you please describe the steps in more detail? What branch did you try to push?
I will check the repository settings for new contributors. It might be something wrong there since it is a new project.
As for the contributing guidelines - unfortunately,  they are still under development. But I can describe the steps here:

Create a branch for this feature.
Make the changes. Write tests if you think it is necessary.
Run tests. If some tests fail - find the reason and fix it.
Create a pull request to the master branch.

Thank you

Hi @ArtyomPanfutov
Thank you for sharing the steps. I'm able to create the Pull Request.
Thanks
Bhavika


Build commit distribution when necessary

Context
This fixes https://github.com/gradle/gradle-private/issues/1640 and partially fixes https://github.com/gradle/gradle-private/issues/1632 .
In https://github.com/gradle/gradle/pull/7337 we supported running performance tests against fork point commit, now we want to make 5.1-commit-1a2b3c4d a valid baseline version - users can specify this version in --baseline parameter. All PerformanceTest now depend on BuildCommitDistribution:

If commit baseline is set explicitly (like 5.1-commit-1a2b3c4d), then build the corresponding commit distribution.
Otherwise, if the current branch is not master or release, calculate the fork point commit then build the corresponding commit distribution.

This PR also publishes build scan to TeamCity build log: https://builds.gradle.org/viewLog.html?buildId=17261586&buildTypeId=Gradle_Check_PerformanceTestCoordinator&tab=buildLog&_focus=4311#_state=96 However it seems not recognized by our build scan url extractor.
This PR reuses RemoteProject logic and get rid of duplicate git clone code.

The problem I met is, the commitBaselineVersion dataflow is bidirectional:

The baselines can be configured in performance test via --baselines command, then be read by determineCommitBaselines task.
After determineCommitBaselines task determines the fork point commit, it needs to write baselines back to performance test.

To solve this problem, we have two ways:

Make the baselines a property instance which is visible to everyone. Everyone can read and write it, like I'm doing right now. You don't like this way, or you don't like the way the Property<String> is wired? I tried to pass this Property<String> in constructor to create performance instances, but this doesn't work for DistributedPerformanceTest which has a @Inject constructor already.

IIUC, you mean we should never leak Property<String> field outside an instance, right?

Make two baselines, one for reading and one for writing, as you suggested.

@blindpirate I don't like the bi-directional kind of thing (we read the property and then we set it again, maybe, depending on the original value). I like much more breaking the cycle by having two properties on the performance test task, one for the configured value and one for the calculated value.
I also think a Property object should belong to something. That something will in most cases be a Task, it may also be an Extension. In this PR there is currently no clear owner of the baseline property created in the plugin.

@wolfs I made some change, PTAL.

I did see this too many loose objects sometimes. I prefer to ignore them unless they become real problems.

Thanks @wolfs !


Add missing tracker events

The python tracker is missing functionality that is present in the JS tracker.
Ie. click event, link click event, performance tracking, search tracking, add to cart, remove from cart.
Some of these events are pretty important to us.
Are there plans to add support for these to the Python tracker?

If I were to use the custom context to send the same events, will the final data be the equivalent?

If you were to use t.track_unstruct_event(SelfDescribingJson(` it would be equivalent; if you used contexts it would be slightly different (because these would become contexts on another event type).

See #166

Hey @chuwy - I'm having an issue with the track_form_change event:
>>> t.track_form_change("form id 123", "element id abc", "input element", "input value", "text", None, None)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<decorator-gen-38>", line 2, in track_form_change
  File "/vagrant/pytracket-test2/local/lib/python2.7/site-packages/contracts/main.py", line 278, in contracts_checker
    raise e
contracts.interface.ContractNotRespected: Breach for argument 'node_name' to instance:track_form_change().
Value does not pass criteria of <lambda>()() (module: snowplow_tracker.tracker).
checking: callable()                        for value: Instance of str: 'input element'
checking: form_node_name                    for value: Instance of str: 'input element'
checking: non_empty_string,form_node_name   for value: Instance of str: 'input element'
Variables bound in inner context:
- args: Instance of tuple: ()
- kwargs: Instance of dict: {}
- self: Instance of Tracker: <snowplow_tracker.tracker.Tracker insta... [clip]

Looks like there's an issue parsing "input element" for the node_name argument. It looks from the documentation that this only needs to be a non-empty string?

Also an issue with the form submission event. According to the documentation only the first argument is required but:
>>> t.track_form_submit("form id 123", None, None, None)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<decorator-gen-39>", line 2, in track_form_submit
  File "/vagrant/pytracket-test2/local/lib/python2.7/site-packages/contracts/main.py", line 278, in contracts_checker
    raise e
contracts.interface.ContractNotRespected: Breach for argument 'elements' to instance:track_form_submit().
Could not satisfy any of the 3 clauses in list(dict[N](str:*))|tuple(dict[N](str:*),*)|None,N>=3,N<=4.
 ---- Clause #1:   list(dict[N](str:*))
 | Expected a sequence, got 'NoneType'.
 | checking: list(dict[N](str:*))   for value: Instance of NoneType: None
 | Variables bound in inner context:
 | - args: Instance of tuple: ()
 | - kwargs: Instance of dict: {}
 | - self: Instance of Tracker: <snowplow_tracker.tracker.Tracker insta... [clip]
 ---- Clause #2:   tuple(dict[N](str:*),*)
 | Expected a tuple, got 'NoneType'.
 | checking: tuple(dict[N](str:*),*)   for value: Instance of NoneType: None
 | Variables bound in inner context:
 | - args: Instance of tuple: ()
 | - kwargs: Instance of dict: {}
 | - self: Instance of Tracker: <snowplow_tracker.tracker.Tracker insta... [clip]
 ---- Clause #3:   None,N>=3,N<=4
 | Error while evaluating RValue VariableRef('N'): Unknown variable 'N'.
 | checking: N>=3             for value: Instance of NoneType: None
 | checking: None,N>=3,N<=4   for value: Instance of NoneType: None
 | Variables bound in inner context:
 | - args: Instance of tuple: ()
 | - kwargs: Instance of dict: {}
 | - self: Instance of Tracker: <snowplow_tracker.tracker.Tracker insta... [clip]
 ------- (end clauses) -------
checking: list(dict[N](str:*))|tuple(dict[N](str:*),*)|None,N>=3,N<=4   for value: Instance of NoneType: None
Variables bound in inner context:
- args: Instance of tuple: ()
- kwargs: Instance of dict: {}
- self: Instance of Tracker: <snowplow_tracker.tracker.Tracker insta... [clip]

I'm waiting to test the track_site_search on the documentation being updated with an example. The other new methods all seem to be working great!

This was fixed.


paginator translation strings dont work

The nextText,prevText etc pagination strings dont work. This is because they are being passed as props to Table.vue, but never sent to Pagination.vue which takes them as props.

I have the same problem and i saw the same thing into the code.

this is now fixed in v1.17.0 (Sorry for the delay)


Performance difference in calling GetEntity and QueryAsync for PartitionKey and RowKey

Library name and version
Azure.Data.Tables version 12.6.1
Query/Question
Want to understand the performance difference between the below mentioned 2 scenarios:
First:
await tableClient.GetEntityAsync(key.PartitionKey, key.RowKey)
Second:
tableClient.QueryAsync(filter: "PartitionKey eq 'partition_key' and RowKey eq 'row_key'" );
Does both have them will perform equally for one is better than the other?
Environment
No response

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Hi @yashpatel-iisc  - They should be roughly equivalent but, as with most performance specific questions, the best I can recommend is to test for your specific environment.


Cannot expand the parent-child hierarchy

We use TFS 2019
We have the Epics/Features/Stories linked in parent-child hierarchy.
And we have the config Parent = On.
However, when I click on the +/- sign, the Epic or Feature did not expand.
(I do have this working in another TFS 2019 env )
Is it because, on this env, I have lower access right ?
Or is there a config somewhere in TFS to enable this (in addition to the Parent=On)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7899d58b-c8eb-0ab4-9126-54cbf0de4dc6
Version Independent ID: ab4d7f52-536e-e3e2-77cf-47581f5cc2d6
Content: Organize your product backlog into a hierarchy of items - Azure Boards
Content Source: docs/boards/backlogs/organize-backlog.md
Product: devops
Technology: devops-agile
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@hongvu68  Thank you for the question.
I think permissions is of concern here as many correspond directly to Work Items access.
Please check with an administrator to see if the Expand feature is still missing.

If there are any further issues, please comment below.


Fix for ReScript 10

Yeah, I think the webview bindings are also partially outdated/incorrect, e.g., the event types. Will have a look at that and submit another PR when I have time.


Commands: show better error when executing on a UWP class library

One of my apps i was trying to upgrade from RC1 to RTM i hit a issue with a refence not set to an instance error when running "Add-Migration". I start to make a new project with the same structure to figure out what is going on, but before i was able to come to that state hitting another issue:
When doing "Add-Migration InitialDB" I get this exception:
Add-Migration : Exception calling "CreateInstanceAndUnwrap" with "8" argument(s): "Could not load file or assembly 'Microsoft.EntityFrameworkCore.Design.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' or one of its
dependencies. The system cannot find the file specified."
At line:1 char:1

Add-Migration initialdb

  + CategoryInfo          : NotSpecified: (:) [Add-Migration], MethodInvocationException
  + FullyQualifiedErrorId : FileNotFoundException,Add-Migration

I added a repro project. You need to set the EFTest.Model as startup project and default project
EFTest.zip

Confirmed this is an issue. It happens when a UWP class library project is marked as the "startup" project. MSBuild for UWP csproj does not copy dependencies into build target dir (bin/) so the powershell commands cannot execute.
Workaround
Set the UWP app as the Startup project (right click on project > Set as StartUp project) or use the -StartupProject option in PMC.

@natemcmaster this workaround doesn't work for me. I think it is because my data part is in this library. So when I try to run the command line with the UWP app as startup project, I get this error:

Cannot execute this command because Microsoft.EntityFrameworkCore.Tools is not installed in the startup project 'UWPProject'.

@SamuelLioult you will need to install Microsoft.EntityFrameworkCore.Tools into the startup project, not the class library project.

@natemcmaster I tried it but I get the error reported here #5471 but it works with the app.config as in the proposed workaround.

For future reference: I had the reported issue while trying to add migrations with the AnyCPU configuration selected (which happened to be default on opening the project and doesn't build the UWP app). Swithing to x86 fixed it.

@bartlannoeye In the next release (1.0.0-preview3), you'll be able to have any of AnyCPU, x64, or x86 selected.

Hi,
I am having this issue on a console application. The issue only exist on EntityFrameworkCore but not EntityFramewokr6.x.

Issue solved by creating a clean project. Also, the tutorial doesn't mention to install Microsoft.EntityFrameworkCore.Design, but it's apparently needed.

And this error is back on UWP with the latest tools (1.1.0-preview4-final). Our client's patient is getting really thin by the continued delays caused by EF Core. It's sad to see these tools are so fragile and lack a correct guide to follow.


Fix LTO engine calculations

Engine LTO calculations were broken since the removal of NPSS. LTO.jl has now been fixed to use tfcalc instead.
Also added a version variable in TASOPT.jl and fixed a misspelled "dictionary"

Codecov Report
Attention: Patch coverage is 82.45614% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 75.13%.  Consider uploading reports for the commit b940cdb to get more accurate results

Files
Patch %
Lines

src/mission/LTO.jl
82.45%
10 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   74.73%   75.13%   +0.40%
==========================================
  Files          69       69
  Lines       13089    13117      +28
==========================================
+ Hits         9782     9856      +74
+ Misses       3307     3261      -46

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[ ] Add a temperature range check that throws a warning if $T_3 \notin T_{3,limits}$


HadoopFileSystem load error

this is a build/installation issue.
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):

$ cat /proc/cpuinfo
processor	: 0
model name	: ARMv6-compatible processor rev 7 (v6l)
BogoMIPS	: 697.95
Features	: half thumb fastmult vfp edsp java tls
CPU implementer	: 0x41
CPU architecture: 7
CPU variant	: 0x0
CPU part	: 0xb76
CPU revision	: 7

Hardware	: BCM2835
Revision	: 0010
Serial		: 00000000
Model		: Raspberry Pi Model B Plus Rev 1.2
$

$ uname -a
Linux raspbari1 4.19.97+ #1293 Wed Jan 22 17:05:40 GMT 2020 armv6l GNU/Linux

Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
n/a

TensorFlow installed from (source or binary):

TensorFlow version:

Installing collected packages: tensorflow-estimator, protobuf, h5py, keras-applications, astor, termcolor, cachetools, pyasn1, rsa, pyasn1-modules, google-auth, google-auth-oauthlib, absl-py, grpcio, markdown, tensorboard, gast, google-pasta, opt-einsum, wrapt, keras-preprocessing, tensorflow
Successfully installed absl-py-0.9.0 astor-0.8.1 cachetools-4.0.0 gast-0.2.2 google-auth-1.11.0 google-auth-oauthlib-0.4.1 google-pasta-0.1.8 grpcio-1.26.0 h5py-2.10.0 keras-applications-1.0.8 keras-preprocessing-1.1.0 markdown-3.1.1 opt-einsum-3.1.0 protobuf-3.11.2 pyasn1-0.4.8 pyasn1-modules-0.2.8 rsa-4.0 tensorboard-2.0.2 tensorflow-1.14.0 tensorflow-estimator-1.14.0 termcolor-1.1.0 wrapt-1.11.2

Python version:

Python 3.7.3 (default, Apr  3 2019, 05:39:12)
[GCC 8.2.0] on linux

Installed using virtualenv? pip? conda?:
python3 -m pip install tensorflow

Bazel version (if compiling from source):

GCC/Compiler version (if compiling from source):

CUDA/cuDNN version:
n/a

GPU model and memory:
n/a

Describe the problem
2020-02-02 15:11:00.880396: E tensorflow/core/platform/hadoop/hadoop_file_system.cc:132] HadoopFileSystem load error: libhdfs.so: cannot open shared object file: No such file or directory
Provide the exact sequence of commands / steps that you executed before running into the problem
$ python3
Python 3.7.3 (default, Apr  3 2019, 05:39:12)
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow

Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

Duplicates #36141, hence closing. Please make sure in the future to search for similar issues.

I don't have any explicit need for Hadoop. Does your package need Hadoop libraries? If so please update your documentation accordingly.
Kind regards.


Add meetup

Compare #1178

Will do eventually, though which screenshots do you mean?

though which screenshots do you mean?

In this PR #1178

Is it just me or aren't there any comments with screenshots?

Could be just you:

I've tried removing the dots and increasing the size of the icon, but then the two lines of the 'm' still connect. So I changed it to 6px. Also, I've smoothed the edge you were mentioning.


Release notes : no easy way for users to find latest versions @ a glance

Given the alpha/beta/GA status, it would be good to provide a way to clearly state the client libraries part of a release.
Right now pom.xml lists versions of libraries and dependencies like gax without any consistent prefix to distinguish them from client libraries.

Could you make your request more specific?

<api-client.version>1.22.0</api-client.version>

    <api-common.version>1.1.0</api-common.version>
    <gax.version>1.5.0</gax.version>
    <gax-grpc.version>0.22.0</gax-grpc.version>
    <generatedProto.version>0.1.15</generatedProto.version>
    <google.auth.version>0.7.0</google.auth.version>
    <grpc.version>1.4.0</grpc.version>
    <guava.version>20.0</guava.version>
    <http-client.version>1.22.0</http-client.version>
    <protobuf.version>3.3.1</protobuf.version>

    <easymock.version>3.4</easymock.version>
    <objenesis.version>2.6</objenesis.version>

    <cloud.version>0.21.2-alpha-SNAPSHOT</cloud.version>
    <bigquery.version>0.21.2-beta-SNAPSHOT</bigquery.version>
    <compute.version>0.21.2-alpha-SNAPSHOT</compute.version>
    <contrib.version>0.21.2-alpha-SNAPSHOT</contrib.version>
    <core.version>1.3.2-SNAPSHOT</core.version>
    <core-http.version>1.3.2-SNAPSHOT</core-http.version>
    <core-grpc.version>1.3.2-SNAPSHOT</core-grpc.version>
    <datastore.version>1.3.2-SNAPSHOT</datastore.version>
    <dlp.version>0.21.2-alpha-SNAPSHOT</dlp.version>
    <dns.version>0.21.2-alpha-SNAPSHOT</dns.version>
    <errorreporting.version>0.21.2-alpha-SNAPSHOT</errorreporting.version>
    <examples.version>0.21.2-alpha-SNAPSHOT</examples.version>
    <language.version>0.21.2-beta-SNAPSHOT</language.version>
    <logging.version>1.3.2-SNAPSHOT</logging.version>
    <monitoring.version>0.21.2-alpha-SNAPSHOT</monitoring.version>
    <pubsub.version>0.21.2-beta-SNAPSHOT</pubsub.version>
    <resourcemanager.version>0.21.2-alpha-SNAPSHOT</resourcemanager.version>
    <spanner.version>0.21.2-beta-SNAPSHOT</spanner.version>
    <speech.version>0.21.2-alpha-SNAPSHOT</speech.version>
    <storage.version>1.3.2-SNAPSHOT</storage.version>
    <trace.version>0.21.2-alpha-SNAPSHOT</trace.version>
    <translate.version>1.3.2-SNAPSHOT</translate.version>
    <vision.version>0.21.2-beta-SNAPSHOT</vision.version>
    <video-intelligence.version>0.21.2-alpha-SNAPSHOT</video-intelligence.version>

No distinction from core dependencies and client libraries. Some kind of parseable prefix would be useful. We talked of creating a separate file for releases,  but if this is already available in the pom.xml, it might be worth just cleaning up to include a prefix tag on client libraries ?

But these will almost always be SNAPSHOT versions, and we want to publish non-SNAPSHOT versions that people can use in their own pom.xml files. So, we would need to generate some content off of these versions at release time. In a way, we do that already - there are maven/gradle snippets all over the place with the current version in them (updated during the release process). Do you want a file containing these snippets for all of the APIs for easy reference?

Wrong paste there, I meant picking them up from the release tagged version from the Release Notes, so they will not have the -SNAPSHOT.
https://github.com/GoogleCloudPlatform/google-cloud-java/releases/tag/v0.21.1

But to your question :  Do you want a file containing these snippets for all of the APIs for easy reference?
I think that would be really useful.

That would actually be really great, we could easily embed that in the cloud docs just like we do for snippets.


Updated CMake Min Version and Project

CI gfxreconstruct build queued with queue ID 26585.

CI gfxreconstruct build # 2443 running.

CI gfxreconstruct build # 2443 passed.


error training scala-engine-template

Hii I have installed predictionio and imported the data to event server using import script from github.but after building when I try to train the engine it gives error as "Exception in thread "main" java.lang.IllegalArgumentException: requirement failed: items in PreparedData cannot be empty. Please check if DataSource generates TrainingData and Preprator generates PreparedData correctly".the appname in engine .json is correct.my import script file looks like.
my import .py file is:
import predictionio
DELIMITER = ","
def import_events(client, filename):
count = 0
with open(filename) as f:
for line in f:
data = line.rstrip('\r\n').split(DELIMITER)
client.create_event(
event="view",
entity_type="user",
entity_id=data[0],
target_entity_type="item",
target_entity_id=data[1],
properties= { "rating" : float(data[2]) }
)
		count += 1

print "%s events are imported." % count

client = predictionio.EventClient(
access_key='u8FpnWAE4KkRavksxioTkBfhHxcdXjhrhqyN6uumNKUz2NfAxdAcQY5nALY4fICH',
url='http://localhost:7070',
threads=5,
qsize=500)
import_events(client, 'music.txt')
#Status API Training Shop Blog About Pricing

Did you also modify all the scala source code ?

@vikrant9311 , would you query event server and see if these view events are imported correctly?
and does the appkey correspond to the app name you specified in engine.json?


Update commands for SDK v0.50.0

There have been some CLI changes in SDK version 0.50.0 that break multisig.
Need to add code to handle these changes.

[x] explore adding modules for the major version of the SDK
[x] query the node for the SDK version
[x] use the appropriate module based on query result
[ ] start replacing binary commands with gRPC queries

gRPC queries will be left for a different issue.


Added Kubernetes resource yaml files for installation as a CronJob

These Kubernetes resource files will be included in the project and will be available for the developer to create using kubectl create -f install in order to deploy Kubernetes Deployment Crawler as a CronJob.
Note that we must push the project image to our att-cloudnativelabs Docker Hub.

Addresses issue #10


Makie spatial plotting maps color vector to each polygon in a multipolygon, leaving white polygons for unmapped shapes

The geometry data in a Domain's site data contains a mix of Polygon and Multipolygon types to describe the shape of reef sites/clusters. When plotting maps where a vector (of the same length as the number of sites in the sites data) is used to map to the color a polygon should be filled with, the current viz.map shows many blank polygons, for example:
cycs_2045 = ADRIA.viz.map(
  rs,
  cyclone_scens[timesteps=At(20)];
  opts=Dict(:color_map => Reverse(:lighttest)),
  axis_opts=Dict(:title => "Mean cyclone mortality 2045")
)

Note  any(isnan.(cyclone_scens[timesteps=At(20)])) = false.
Plotting instead with Plots.jl gives an error due to a mismatch in the number of polygons and the color mapping vector:
plot(dom.site_data[:,:geom],fill_z=Array(cyclone_scens[timesteps=At(20)]))
Error showing value of type Plots.Plot{Plots.GRBackend}:
ERROR: BoundsError: attempt to access 334-element Vector{Float64} at index [447]

Which is resolved if a sufficiently large colour mapping vector is provided:
plot(dom.site_data[:,:geom],fill_z=rand(1:20,(600,1)))

This suggests Makie compensates for the mismatched polygons by plotting with no colour fill.
Versions:
ADRIA = v0.11.0
GeoMakie = v0.5.10
GraphMakie = v0.6.5
GeoDataFrames = v0.3.9

I have a fix for this open (see linked PR above) but just noting that the GeoMakie version you have is pretty old now.
The latest version (v0.7.x) introduced some breaking changes so I'm currently using v0.6.5

I have a fix for this open (see linked PR above) but just noting that the GeoMakie version you have is pretty old now. The latest version (v0.7.x) introduced some breaking changes so I'm currently using v0.6.5

Thanks, I'll update


About device model

Hello, I am a novice who has just started studying visual SLAM, and I am more interested in panoramic cameras.
Did you device verify this package on insta one rs? It seems that this device doesn't have dual lens mode, only usb mode.
So I want to ask you this question. If it doesn't work, I will switch to the same equipment as yours.
Best regards,
Nick

We didn't test on One Rs. But theoreticaly it should also work as Insta360 SDK also supports that model.
Probably the only thing you need to change it the resolution and fps in this line.

@Gaaaavin @Abanesjo When we have more time, we should probably make this parameter something that can be easily configured in ros startup files, so people don't need to modify the cpp codes.


debug console cropping is way to aggressive and poorly done

debug something
try to log/inspect some values on the console, esp with JSON.stringify
🙄 note that only around 35 lines are shown...

This is hardly useful. I learned from @connor4312 that I can copy values to the clipboard but that's insufficient. Ideas

use a realistic limit, maybe something that respects the perf of the machine
show an indication that cropping happened (something like ...)
give me an easy way to open the whole thing inside a temp editor (this is what notebook long outputs do)

This is just a bad height calculation, has been an issue in the past

Had another issue for this: https://github.com/microsoft/vscode/issues/151768


[typescript-language-features] Add suggest.allowIncompleteCompletions and pass trigger kind to TS Server

Counterpart to https://github.com/microsoft/TypeScript/pull/44713

To discuss: how/whether to present suggest.allowIncompleteCompletions in settings UI

Thanks!


Updated docker-compose.yml to version 3.5

What has been done

Updated the docker-compose yml file to version 3.5, which works as of Docker 2017.12.0

How to test

Pull this branch
Run docker-compose up --build
See that with a sufficiently recent docker-ce (2017.12.0 or higher), this works great!

Notes

I picked version 3.5 so we can have a Docker-CE that's almost a year old right now. I felt that this was a close enough cut-off point. Keep the spirit of moving forward alive!
Migration was a breeze, as the complete file was forwards compatible.

Thanks!


Add Verily employees to whitelist

FYI @wnojopra: users need to log in to Terra with their @google.com email, since @verily.com is an alias of @google.com. Since I can't un-hash these emails, I trust that they are the @google.com version of their email addresses.

Thanks @katevoss! These are indeed @google emails.


DVR sets depth correctly

This PR modifies DVR to have depth value correctly set, thus DVR plays well with other renderers.
A demo is located at:
<EMAIL_ADDRESS>

Why isn't the annotation (white bounding box) visible when it's behind the volume rendering?

The white bounding box is invisible because it's drawn after every renderer, and it's got depth behind the DVR. Let me try if it's resolved by the rendering order PR this morning.

After syncing with the master branch, the white bounding box is still not shown... Is it rendered before the DVR?


Problem iterating through direct messages

Hi! Thanks for creating this, it helped me out a lot so far. However, I am experiencing an issue when trying to iterate through direct messages between me and another user. The error message I get tells me to only provide one destination in personId and personEmail, which I clearly do. Here's the code:
messages = api.messages.list_direct(PersonId=VACCELERATOR_ID)
testlist=[]
for r in messages:
testlist.append(r.id)
This is the error message I get:
webexteamssdk.exceptions.ApiError: [400] Bad Request - Provide only one destination in the personId and personEmail fields [Tracking ID: ROUTER_5FD10597-724E-01BB-58DA-AC12FAA058DA]

I also had trouble with that. I was able to get around the issue by using personEmail instead of personId.
That said, it would be nice to see why we can't select by ID.

I also had trouble with that. I was able to get around the issue by using personEmail instead of personId.
That said, it would be nice to see why we can't select by ID.

Closing this issue as it is more than three years old.
I note the provided code sample using a PersonId parameter, which isn't valid. The correct Person ID parameter is personId. The SDK isn't manipulating the contents of the personId parameter, so if there was an API bug with this request call, it would likely have been an API bug.


[WIP] Add hypothesis to some str methods

This is a WIP and not ready to merge, but I've been playing with hypothesis lately with help from @damedebugger (hi!).
I don't know if Str.java is the best place to start, but I keep finding new bugs for the existing methods so it'll take a little while for this to be ready.
It might make sense to split this into separate PRs, but as I also want to find a good way of reusing the strategies for other functions I'll continue working on this branch for now.
I hope this will be handy for ensuring quality of the patches, I know I'll be glad to not have to think so hard to cover the edge cases. :)

After thinking more about this, trying out things with @mistermocha and talking briefly with @freakboy3742, I now believe it will make more sense to limit the hypothesis usage for development and not on the regular Travis builds, for two reasons:

it would increase the build time greatly
it would find many problems that we have no clear solution yet, like the discrepancy between different versions of Unicode data

For reference, here are the Unicode data versions of CPython:
$ $(pythonz locate 3.4.4) -c 'import unicodedata; print(unicodedata.unidata_version)'
6.3.0
$ $(pythonz locate 3.5.3) -c 'import unicodedata; print(unicodedata.unidata_version)'
8.0.0
$ $(pythonz locate 3.6.1) -c 'import unicodedata; print(unicodedata.unidata_version)'
9.0.0

In the JVM land, Java 7 uses 6.0.0, Java 8 uses 6.2.0, Java 9 will be 7.2.0.
These causes differences some subtle differences of behavior for methods like isupper/islower and I believe isdigit as well.

While the issues noted above are real, I'd also like to note that you can choose how many examples Hypothesis will try - 2000 might be unacceptably slow, but what about 50?  You can also use it for some types but not others - Unicode is always tricky, but numeric and simple collection types could benefit enormously.
As noted on #580, I'd be happy personally and as a maintainer of Hypothesis to assist anyone who wants to take this on.

Hi there! It looks like this PR might be dead, so we're closing it for now. Feel free to re-open it if you'd like to continue, or think about directing your efforts to https://github.com/beeware/briefcase or https://github.com/beeware/toga. Both of these have more active development right now. 😄


MWPW-147158: adds support for footer divider at the collection level

Adds the ability to display the footer divider above the CTAs at the collection level
Resolves: MWPW-147158
Test URLs:

Before: https://main--milo--adobecom.hlx.page/tools/caas?martech=off
After: https://mwpw-147158--milo--adobecom.hlx.page/tools/caas?martech=off

After:

Failing nala tests are pre-existing, PSI check for CaaS can be disregarded


Update aws-lambda-java-log4j2

 Created from JetBrains using CodeStream

This affects only the pom.xml of our Java example. It should be merged, but not released during the code freeze.


Service helpers

Create service helper files to point to the custom start/stop files for this module. E.g. create a systemd aem.service.erb file. Populate it via value from resource attributes.

Completed with #35


Use latest tslint, typescript, and grunt-tslint

Fixes #503

Is there any way we can retrigger appveyor here?

not without @ashwinr, he has the login creds


nasa-veda: Add 'shared-public' to hubs

Requested in https://2i2c.freshdesk.com/a/tickets/1629

Self-merging per https://infrastructure.2i2c.org/contributing/code-review/#safe-configuration-changes-when-asked-for-by-the-community


fixed size instructions

Basically use fixed size instructions. (in 32bit or 64bit layout)

we decided 64bit as instruction size.

now instruction is folded.


reference.conf: Add SW360 scan results storage

See commit for details
Signed-off-by: Thomas Steenbergen<EMAIL_ADDRESS>

@bs-ondem  Thanks for the hint, first time writing Kotlin tests, hope I did it right.


Import products from amazon API

Hello,
Can we add import functionality using amazon API along with file import?.

This would be best done using the before_import_save hook since it looks pretty application-specific.


Why not export const?

There is no const enum  export at index.ts.
I must look the code when comparing the browser.
like,this.device.browser === 'ie'

@baihech Thanks for mentioning. It is a good idea. Will include this soon. Or you can do it and create a PR perhaps :)

@AhsanAyaz Thanks，export ng2-device.constants,what do you think?


Gradle 8.8 Deprecation - Configuration.files()

Deprecation in Gradle causes builds to fail when having the following gradle property set:
org.gradle.warning.mode = fail

Versions:

Gradle 8.8
Spotbugs Gradle Plugin 6.0.12

Running SpotBugs by Gradle no-isolated Worker...
The Configuration.files(Spec) method has been deprecated. This is scheduled to be removed in Gradle 9.0. Use Configuration.getIncoming().artifactView(Action) with a componentFilter instead. Consult the upgrading guide for further information: https://docs.gradle.org/8.8/userguide/upgrading_version_8.html#deprecate_filtered_configuration_file_and_filecollection_methods

Offending code (I believe):
https://github.com/spotbugs/spotbugs-gradle-plugin/blob/93a8aa105bb8fe9ef9422fad891592d238323d20/src/main/kotlin/com/github/spotbugs/snom/SpotBugsTask.kt#L368-L370

have you tried the latest that was updated for gradle 8.8?  Try 6.0.16.

That fixed it.  Thanks!


All translated C++ documents are unavailable

All translated C++ documents are unavailable.
To Reproduce

Go to https://docs.microsoft.com/cpp
Select a language which has a repository for translation.

https://github.com/MicrosoftDocs/cpp-docs.ja-jp
https://github.com/MicrosoftDocs/cpp-docs.zh-cn
https://github.com/MicrosoftDocs/cpp-docs.ru-ru
https://github.com/MicrosoftDocs/cpp-docs.es-es
https://github.com/MicrosoftDocs/cpp-docs.ko-kr
https://github.com/MicrosoftDocs/cpp-docs.de-de

Not translated for the selected language.

Expected behavior
It shows translated pages.

@chiastolite Thank you for reporting this issue. We are looking into this issue and will update.


config: deprecate fetching SSH keys from remote endpoints

lgtm
the convenience was nice but the network/user setup ordering problems are not.

Hi All,
just yesterday i implemented this nice feature in our environment. If this parameter is not deprecated what is the recommended way of getting SSH keys from a local/internal Github Enterprise system?

@Nosmoht the SSH keys for the machine should be injected directly into the cloud-config or managed by a proper configuration management tool.

@crawford Thanks for your answer. We are deploying CoreOS nodes using Ansible and Foreman. So the users/keys are already provided by a configuration management tool. The problem with the approach of putting public keys into cloud-config is that i need to have every single key. So i always have to talk to people and can't automate the infrastructure provisioning.
That's why, from my point of view, this "depcreated" feature is such nice. With it, i have only one single point of data (Github) instead of storing public key files in multiple repositories, keeping them in sync and so on.


Build successful but link not opening

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
arn:aws:amplify:us-east-1:931986214015:apps/d1ic0ej73uu16h
Region
us-east-1
Amplify Hosting feature
Build settings
Describe the bug
My React app successfully built, but the link does not work. I followed the tutorial, and this is what I am seeing. I am not sure why the app is not appearing.

Expected behavior
I expected to see my working website.
Reproduction steps
Building the app
Build Settings

Additional information
No response

Hi, what's the URL for your website? The screenshot you posted shows the Amplify dashboard, which looks correct to us.
Make sure you set the SPA redirect in your dashboard, if you didn't already:
https://docs.aws.amazon.com/amplify/latest/userguide/redirects.html#redirects-for-single-page-web-apps-spa

Can you also show us what you see when you click the link displayed?

My jekyll deployment have the same issue. The build and deployment ticks are all green, but my jekyll website cannot be displayed.   is displayed.

My jekyll deployment have the same issue. The build and deployment ticks are all green, but my jekyll website cannot be displayed.  is displayed.

The link of my deployment is beta.decatoncheir.net

It looks like the links are loading your website correctly now. If you run into this issue again please feel free to re-open.


Main Thread Checker: UI API called on a background thread

I'm seeing the following when using running the target on iOS 17+ with Xcode 15.4. Any suggestions on how to fix this?
Great blog post btw - it saved me so much time!
Main Thread Checker: UI API called on a background thread: -[UIView window]
PID: 25374, TID: 13219677, Thread name: (none), Queue name: com.apple.root.user-initiated-qos.cooperative, QoS: 25
Backtrace:
4   App                           0x000000010cf7f639 -[OIDExternalUserAgentIOS presentationAnchorForWebAuthenticationSession:] + 121
5   AuthenticationServices              0x00007ff91f3e9f64 -[ASWebAuthenticationSession _startDryRun:] + 157
6   App                           0x000000010cf7e8e6 -[OIDExternalUserAgentIOS presentExternalUserAgentRequest:session:] + 742
7   App                           0x000000010cf88107 -[OIDAuthorizationSession presentAuthorizationWithExternalUserAgent:callback:] + 167
8   App                           0x000000010cf8b125 +[OIDAuthorizationService presentAuthorizationRequest:externalUserAgent:callback:] + 197
9   App                           0x000000010cf7e19b +[OIDAuthorizationService(IOS) presentAuthorizationRequest:presentingViewController:callback:] + 219
10  App                           0x000000010d00de2b -[GIDSignIn authenticateInteractivelyWithOptions:] + 1851
11  App                           0x000000010d00e5c6 -[GIDSignIn authenticateWithOptions:] + 134
12  App                           0x000000010d00d3ce -[GIDSignIn signInWithOptions:] + 926
13  App                           0x000000010d00bbb0 -[GIDSignIn signInWithPresentingViewController:hint:completion:] + 192
14  App                           0x000000010d00bd94 -[GIDSignIn signInWithPresentingViewController:completion:] + 116
15  App                           0x000000010cf3740f $s9App14AuthenticationC11googleOauthyyYaKFTY8_ + 447
16  libswift_Concurrency.dylib          0x00007ffb1f869da5 _ZN5swift34runJobInEstablishedExecutorContextEPNS_3JobE + 325
17  libswift_Concurrency.dylib          0x00007ffb1f86addd _ZL17swift_job_runImplPN5swift3JobENS_11ExecutorRefE + 77
18  libdispatch.dylib                   0x000000010da5a3b4 _dispatch_root_queue_drain + 332
19  libdispatch.dylib                   0x000000010da5af9d _dispatch_worker_thread2 + 277
20  libsystem_pthread.dylib             0x000000010d4dfb43 _pthread_wqthread + 262
21  libsystem_pthread.dylib             0x000000010d4deacf start_wqthread + 15

I created a new app
This occurs when I click the "login" button that launches the Google Sign In flow

The app is pretty bare-bones. It still works even with this message.

Sorry for the late reply, but I just remembered where this warning originates.
It's from the GoogleSignInSwift library and the traceback does not reference the app's code, I don't remember many more details, but as it happens only the first time the button is pressed I think there may be some initialisation that is handled with a background thread.
If you have solved the issue or happen solve it in the future please let me know, I'll be happy to update the blog post.

Thanks, I haven't solved it but I do notice that the UI is sometimes unresponsive (delayed) and I suspect that this is the issue.

I spent some time looking at this, turns out the only change needed was to add @MainActor before the googleOauth function.
I'll push an update soon with the updated code


setTimeout and setInterval aren't detected as open handles

🐛 Bug Report
I would expect setTimeout and setInterval to be treated as open handles, preventing Jest from exiting normally and causing an error but timeouts are ignored, the process exists without waiting for them. This results in inability to detect that tested code is potentially buggy.
To Reproduce
Steps to reproduce the behavior:
function foo() {
  setTimeout(() => {}, 4000);

  new Promise((resolve, reject) => setTimeout(() => reject(new Error('unhandled rejection')), 3000));

  return 1;
}

it('should warn about open handles', done => {
  expect(foo()).toBe(1);
  setTimeout(done, 100);
})

PASS  tests/index.js
√ should warn about open handles (128ms)
Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        3.497s
Ran all test suites.

The problem persists with latest Jest release (24.1).
Expected behavior
A clear and concise description of what you expected to happen.
Link to repl or repo (highly encouraged)
A repo that replicates the problem.
Run npx envinfo --preset jest
  System:
    OS: Windows 7
    CPU: (8) x64 Intel(R) Core(TM)
  Binaries:
    Node: 10.13.0 - C:\Program Files (x86)\nodejs\node.EXE
    Yarn: 1.9.4 - C:\Program Files (x86)\nodejs\yarn.CMD
    npm: 6.4.1 - C:\Program Files (x86)\nodejs\npm.CMD

Do we have an update on this issue ? Seems like am facing the same issue when using setTimeout and jest doesn't wait for the timeout and exists with no errors .

I can confirm this bug. This is caused by jest-environment-jsdom. If you set testEnvironment to node, it works as expected. I've tried removing all of the error handler stuff from jest-environment-jsdom and bringing its usage of fake timers in line with that of jest-environment-node, but to no avail - it might even be caused by something in jsdom itself :/

@github-actions It's not stale, bot

As https://github.com/facebook/jest/issues/7933#issuecomment-474419143 states, this only happens when using JSDOM. JSDOM uses browser timers, which do not keep the process open - Jest exits cleanly in your example.
If you use node test env the process is kept open (and the handles are reported).

If you want jest (and not node, which is what where checking with open handles) to wait for your timers, you need to either return promises or use the done callback

@SimenB Why was the issue closed? It's still relevant and not fixed. It would be the problem of JSDOM if it were just a third-party lib that is used by developers at their own risk. But Jest has first-class JSDOM support and provides it as first-party environment, so it's expected to  its responsibility to take care of consistent and predictable behaviour. The explanation that you gave makes sense but this behaviour not documented and certainly not expected.
I personally strictly follow good practices regarding writing asynchronous tests. However, I explained the problem in the issue, "This results in inability to detect that tested code is potentially buggy", it occurred to me previously.

There are no open handles produced by setTimeout in a browser setting, so there's nothing to detect.

But JSDOM isn't browser setting, it only replicates it to some extent, it was never thoroughly described to which one. This happened to me in universal code and Node code that was tested in the same environment as the rest of the project, which was jsdom, one could only guess what could affected by the choice of environments besides the availability of browser API.
As I said, the reasons why it works like that make sense, but it's not documented and totally looks like a bug and not a feature. I'd suggest to reopen the issue and find an appropriate resolution for it if possible. If this is something that goes without saying, why is this not mentioned in the documentation?

There is nothing we can do to detect you are not waiting for the async work your test is doing, that's just how JavaScript works. Your OP talked about how --detectOpenHandles does not detect this case, and I've explained why it's detected in node env, but not jsdom env.
If you think the documentation can be improved in regards to how to test async code, we should have an issue for that (or even better, send a PR) - not a bug report about --detectOpenHandles.

As I said, the reasons why it works like that make sense, but it's not documented and totally looks like a bug and not a feature

The second sentence in the first paragraph of https://jestjs.io/docs/asynchronous is

When you have code that runs asynchronously, Jest needs to know when the code it is testing has completed, before it can move on to another test.

Not sure how it can be more explicit?

I filed #12522 earlier. That was mostly to lift promises above callbacks, but if you have any suggestions for how to reword this, that issue might be a good place to put it 🙂


Optimize KeyCombination

Use ImmutableArray and make itself a struct to minimize allocations and virtual calls.
Binary breaking change, with source compatible
Although ImmutableArray<T> implements IEnumerable<T>, the implicit cast requires instructions.
It's discouraged to call LINQ methods on it. It provides some LINQ-like methods.
Source will only break if you call ReferenceEquals or use for where T : class.

@bdach I think the main label should be perf. The hot path will only allocate the array of keys.

Need a design review here:

Keep using { } to represent nothing pressed, and { None } to represent should never be pressed. Add an assert for the one from input never contains None.
This choice will require least change. I'll use this one in this PR to let it merged ASAP (I have another branch depends on this).
Use { } for both, and special case when comparing { }. Prohibit None to appear in any KeyCombination.
This choice will need a whole to keep compatibility of string representation, which is used in database storage.
I'd like to refactor db to store byte[] instead of string too.
Split the types for keys should be pressed and keys actually pressed.
The former can be even standardized to "0-4 modifiers + 0-1 keys" for keyboard, which makes it fixed size. However, it's the code side, and other devices may have different capabilities.

I'd treat { } and None as the same. Either can appear but the functionality should not differ.

This should be the final state of this PR. I kept the exact behavior. Any behavior/design change will be seperated.


Some problems about window_info

In gen_data_info.py：
（1） line 63, what does len_df = frame_count - 9 mean? How do you determine parameter 9 ?
（2）line 73-74,
if is_train and n_window == 0:
        windows_start = [0]

when the frame_num < window_size, it will still put window_start=0 to window_info, when extract feature it cann't find the last few frames (window_size - frame_num), maybe I should change this for my dataset?
In config.py：
（1）line 55, self.overlap_ratio_threshold = 0.9, it filters out Windows that don't overlap very well, if I change this parameter smaller, what will happen? It will reduce accuracy or speed?

This is adopted from the original SSAD code. They want to align features. They use 9 because part of their features are extracted by C3D, where videos are split into non-overlapped 16-frame clips and 9 is about in the middle of a 16-frame clip.
Though I didn't use C3D feature, I simply adopted this line and forgot to change. Someone try with len_df = frame_count told me the performance will have little influence.
Yes I just repeat the last frame for short videos and since only several videos are shorter than window_size the performance will not be influenced.
I adopt the same value for the parameter self.overlap_ratio_threshold as the original SSAD code, which is 0.9. I think too small (the coverage ratio of action instances is too small in the selected windows) or too large (the training data is not enough) value for this parameter will worsen the results. I didn't finetune this parameter but you can try to get a better result. The speed is depend on the size of data so you can count the size of window to estimate speed.

I chang the code with len_df = frame_count - 5, because in my dataset the action is short(some just longer a little than window_size) and extract_feature need optical_flow_frames=5.
I trained decouple-ssad with NTU-RGBD dataset use window_size=64, thanks for your help and the result looks good.

But I still have a problem, extract_feature using TSN pretrained model is really slow, because it need optical_flow and the dense_flow is slow.If I can set the param optical_flow_frames (in TSN, it is 5) with other value, maybe I don't need to calculate every frame's optiacal_flow.  Have you try C3D or other model for feature-extracting before? Is there other way to extract action feature without TSN?

Glad to help and hear your suscessful try in other dataset : )
I didn't try other feature extraction methods because I read from papers that 3D extraction and two-stream extraction have similar performance. But I didn't compare their speed, maybe you can have a try. By the way, you can speed up optical flow extraction with more gpus and more processors in a gpu. Or you can sample videos with a bigger step (bigger interval between two frames) though the performance is expected to be worse to some extent.
Luckily, you only need to do feature extraction once and the following experiments would be very fast.


Build.sh will fail if wget is missing (curl missing output redirection).

The line at:
https://github.com/aspnet/Universe/blob/664d718398ab0d94ce14dc35d13509248d79f9fd/build-template/build.sh#L17
wget -O $cachedir/nuget.exe $url 2>/dev/null || curl -o $cachedir/nuget.exe --location $url /dev/null

is missing an output redirection for curl, so the command will fail with an invalid or missing URL if wget is not available on the system.
Also, since $cachedir may be expanded with spaces in the path, the parameter which includes the variable should be quoted.
Line should be:
wget -O "$cachedir/nuget.exe" $url 2>/dev/null || curl -o "$cachedir/nuget.exe" --location $url 2>/dev/null

Could you send a PR with the change to this repo - there's a copy of it in build-template\build.sh?

@pranavkm sure. Can you merge #228 with this issue for reference since it also references unescaped sequences in parameter expansion?

Closing because we are not planning to make changes to this or it is no longer needed.


Cut release for golang 1.18

The golang-1-windows was recently bumped to golang 1.18 here, could we get a new final release cut with these changes?
Thanks!

https://github.com/cloudfoundry/windows-tools-release/releases/tag/v73 has been released.


Bits

The commits are pretty independent of each other, but creating many MRs is a pain ;)
Note the last commit, we can probably just delete Pipeline.create() it looks like it never worked.

Thanks! Yeah currently we only do the old pipeline cancelling when a new commit is pushed. Up to you if you want to delete its create() or retry() method. I don't see a use case where we'd want to create/retry a pipeline unless we provide some commandline options for the user to do so.


v4-beta3 SVG inline linebreaking creating invalid markup

With inline linebreaking, mathjax generates mjx-linestrut elements inside svg element - which doesn't seem to affect layout but is invalid.
E.g. $a \overset{\text{hello world}}{=} b$ exhibits the problem for me.

In order to handle embellished operators when in-line breaking is allowed, I had to add a function to lay out embellished operators separately from normal ones.  It looks like I wrote the CHTML version first, then copied it for SVG and modified it.  The mjx-linestrut is needed for CHTML, but not for SVG, and I missed it when adapting the function to the SVG output.
I've made a PR to remove it.


error: patch failed: src/civetweb.c:101

-- FetchContent: civetweb
[ 11%] Performing update step for 'civetweb-populate'
-- Already at requested ref: 1fb204ecc630515d53291f58955c799785cb90c7
[ 22%] Performing patch step for 'civetweb-populate'
error: patch failed: src/civetweb.c:101
error: src/civetweb.c: patch does not apply
gmake[2]: *** [CMakeFiles/civetweb-populate.dir/build.make:118: civetweb-populate-prefix/src/civetweb-populate-stamp/civetweb-populate-patch] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:87: CMakeFiles/civetweb-populate.dir/all] Error 2
gmake: *** [Makefile:91: all] Error 2

When rebuilding the project, the git apply operation in FetchContent() errors.
Workarounds:

remove /build/_deps/civetweb-subbuild/ then rebuild
add UPDATE_DISCONNECTED true  to civetweb.cmake  {could be problematic if update civetweb in the future}
create commit of civetweb with patches already applied.

Probably other ways, too.
No big deal for me, I have been using a build script, but does affect downstream projects like CommandCenter

The best would probably be just a custom civetweb honestly but the solution I currently am using is removing the patching from FetchContent and doing it silently later on if needed.
# Function to apply patches silently
function(apply_patch_silently)
    execute_process(
            COMMAND ${patch_executor}
            WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/civetweb"
            RESULT_VARIABLE apply_result
            ERROR_QUIET
            OUTPUT_QUIET
    )
    if(NOT apply_result EQUAL 0)
        message(WARNING "Ignoring error while applying patch: ${patch_file}")
    else()
        message(STATUS "Patch applied successfully: ${patch_file}")
    endif()
endfunction()

and adjusted part of makeavailable
FetchContent_GetProperties(civetweb)
if(NOT civetweb_POPULATED)
    apply_patch_silently()

    FetchContent_MakeAvailable(civetweb)
endif ()

Hi @Nickrader , could you please describe in more details the workflow which leads to the patch failure?
Do you run clean checkout or use some previously created build folder?

Using previously created build folder is when error occurs.
Remedy is to 'clean checkout' or just remove the 'civetweb-subbuild' folder from build directory.
I'll have to investigate more for exact cause, but seems to be related to changes in sources in CMakelists.txt
Behavior wasn't noticed in the old method:  create commit with patches applied.
For example:

Build cpp-sc2
Make a change to sources
Build again

leon@Leon:~/bots/cpp-sc2$ git diff HEAD
diff --git a/src/sc2api/CMakeLists.txt b/src/sc2api/CMakeLists.txt
index b68c6a6..06734c9 100644
--- a/src/sc2api/CMakeLists.txt
+++ b/src/sc2api/CMakeLists.txt
@@ -48,6 +48,7 @@ set(sc2api_sources
     typeids/sc2_types.h
     "typeids/sc2_${SC2_VERSION}_typeenums.cpp"
     "typeids/sc2_${SC2_VERSION}_typeenums.h"
+    hoho.cc
 )

 add_library(sc2api STATIC ${sc2api_sources})
diff --git a/src/sc2api/hoho.cc b/src/sc2api/hoho.cc
new file mode 100644
index 0000000..e69de29

leon@Leon:~/bots/cpp-sc2$ cmake --build build -j $(nproc)
-- Target SC2 version: 5.0.12
-- FetchContent: civetweb
gmake[1]: Entering directory '/home/leon/bots/cpp-sc2/build/_deps/civetweb-subbuild'
gmake[2]: Entering directory '/home/leon/bots/cpp-sc2/build/_deps/civetweb-subbuild'
gmake[3]: Entering directory '/home/leon/bots/cpp-sc2/build/_deps/civetweb-subbuild'
gmake[3]: Leaving directory '/home/leon/bots/cpp-sc2/build/_deps/civetweb-subbuild'
gmake[3]: Entering directory '/home/leon/bots/cpp-sc2/build/_deps/civetweb-subbuild'
[ 11%] Performing update step for 'civetweb-populate'
-- Already at requested ref: 1fb204ecc630515d53291f58955c799785cb90c7
[ 22%] Performing patch step for 'civetweb-populate'
error: patch failed: src/civetweb.c:101
error: src/civetweb.c: patch does not apply
gmake[3]: *** [CMakeFiles/civetweb-populate.dir/build.make:118: civetweb-populate-prefix/src/civetweb-populate-stamp/civetweb-populate-patch] Error 1
gmake[3]: Leaving directory '/home/leon/bots/cpp-sc2/build/_deps/civetweb-subbuild'
gmake[2]: *** [CMakeFiles/Makefile2:87: CMakeFiles/civetweb-populate.dir/all] Error 2
gmake[2]: Leaving directory '/home/leon/bots/cpp-sc2/build/_deps/civetweb-subbuild'
gmake[1]: *** [Makefile:91: all] Error 2
gmake[1]: Leaving directory '/home/leon/bots/cpp-sc2/build/_deps/civetweb-subbuild'

CMake Error at /snap/cmake/1433/share/cmake-3.31/Modules/FetchContent.cmake:1918 (message):
  Build step for civetweb failed: 2
Call Stack (most recent call first):
  /snap/cmake/1433/share/cmake-3.31/Modules/FetchContent.cmake:1609 (__FetchContent_populateSubbuild)
  /snap/cmake/1433/share/cmake-3.31/Modules/FetchContent.cmake:2145:EVAL:2 (__FetchContent_doPopulation)
  /snap/cmake/1433/share/cmake-3.31/Modules/FetchContent.cmake:2145 (cmake_language)
  /snap/cmake/1433/share/cmake-3.31/Modules/FetchContent.cmake:2384 (__FetchContent_Populate)
  thirdparty/civetweb/civetweb.cmake:41 (FetchContent_MakeAvailable)
  CMakeLists.txt:85 (include)

Using a downstream project (i.e. blank-bot) will fail to find cpp-sc2 module (probably due to upstream build error)
leon@Leon:~/bots/blank-bot$ git diff HEAD
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 324afda..4ae3fcb 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -4,7 +4,8 @@

 set(bot_sources
     main.cpp
-    Bot.cpp)
+    Bot.cpp
+    hohoho.cc)

 add_executable(BlankBot ${bot_sources})

diff --git a/src/hohoho.cc b/src/hohoho.cc
new file mode 100644
index 0000000..e69de29

leon@Leon:~/bots/blank-bot$ cmake --build build -j $(nproc)
CMake Error at CMakeLists.txt:44 (include):
  include could not find requested file:

    cpp_sc2

-- Configuring incomplete, errors occurred!
gmake: *** [Makefile:1931: cmake_check_build_system] Error 1

@Nickrader thank you for the detailed info! Fortunately, this one is easy to fix.
Fixed.


[Coverity CID :189519]Error handling issues in /samples/net/sockets/echo/src/socket_echo.c

Static code scan issues seen in File: /samples/net/sockets/echo/src/socket_echo.c
Category: Error handling issues
Function: main
Component: Samples
CID: 189519
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

This looks intentional to me. I don't see why the arguments (SOCKET) can't be negative for bind and recv calls.
I think we can mark so in Coverity and close this. Same applies to #11086

@pfalcon please take a look at this issue and close ASAP

@galak or @nashif
This can be closed.

Fix already merged, so closed.


Bump version

Bump revision to release the OIDC configuration bug fix.
https://github.com/solid/oidc-op/pull/24/files

Thanks, I'm doing this with npm version minor in the master branch.

Thanks Michiel. Can you also update these dependencies in NSS?

Yes, done in NSS v5.5.1, see https://gitter.im/solid/node-solid-server

Great. Thanks a million!


Make it rollback when ImagePullBackOff error occurred

What would you like to be added:
When applying k8s resource to the cluster, sometimes ImagePullBackOff occurs but is not rolling back for now.
It would be nice to detect the error and do the rollback.
Why is this needed:

At first I'll try reproducing the error.

I successfully reproduced the error.
When I tried deploying a wrong container image: xxxxxnginx:1.17 by PipeCD,
kubectl get pods said the STATUS of the pod was ImagePullBackOff,
although the PipeCD saied the deployment was SUCCESS.

The cause:

PipeCD uses kubectl apply/replace/create to apply k8s manifests.

https://github.com/pipe-cd/pipecd/blob/ed8b54358a5a3cfd6c9d537048795b3b2371eb6f/pkg/app/piped/executor/kubernetes/kubernetes.go#L244-L258
apply: (replace, create as well) https://github.com/pipe-cd/pipecd/blob/ed8b54358a5a3cfd6c9d537048795b3b2371eb6f/pkg/app/piped/platformprovider/kubernetes/kubectl.go#L72

However, kubectl apply does not return an error even if the deployment fails.

One solution would be like this:  (If you have others, please suggest them!!)

Check the status of the deployment after kubectl apply by:
kubectl rollout status deployment/MY_DEPLOYMENT_NAME

Judge by the return (by the head error string?)
Success:

deployment "MY_DEPLOYMENT_NAME" successfully rolled out

Failure:

error: deployment "MY_DEPLOYMENT_NAME" exceeded its progress deadline

Rollback if needed

cf.

Deployment https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#complete-deployment
kubectl rollout status https://kubernetes.io/docs/reference/kubectl/generated/kubectl_rollout/kubectl_rollout_status/

One solution would be like this:

OMG, that's not enough...
We need to distinguish ImagePullBackOff from provisioning.
While deploying, kubectl rollout status would say Waiting for deployment "MY_DEPLOYMENT_NAME" rollout to finish: 0 of 2 updated replicas are available...,
even if ImagePullBackOff occured.
Or, just wait for timeout of applying. (timeout is not used now??)

kubectl describe deployment does not provide information about the pods' ImagePullBackoff. The only information we can use is the condition Progressing.
I think we can take 2 strategies.
One is to apply timeouts, as @t-kikuc said.
The other one is to retrieve the pods' condition directly.
The live-state view has information about pods controlled by the deployments, so we can already retrieve pods' conditions.


Release of Google.Cloud.Diagnostics.* 1.0.1

Catch all Exceptions in the TimedBuffer timer to avoid ever bringing down an application.
I ran all the integration and unit tests and all is good.  I'm going to have to release manually as I don't think the current deployment can handle the older scripts.

Will do


Version bump

It seems to me the very impressive and significant work in #59, which restored passing specs in current versions of Solidus after a long time, is worth at least a minor version bump!

I've also released the new version
https://rubygems.org/gems/solidus_virtual_gift_card
Thanks!


Automated gender detection

Script Title - automated gender detection
Brief - automated detection of gender of an user using their webcam
Instructions

Create a new folder for your script and file/folder name should be appropriate.
Create a README.md in your folder for program Instructions
add requirements.txt if needed

Programming Language

[x] Python

Happy Coding

@pawangeek can you please assign me this issue

@pawangeek please assign this to @abhishekchopra0907

Please Assign this issue to me.


Extract following/followers/friendship routines into standalone module

Many SSB apps have the need of finding out followers/following/friends for a given feed. As soon as the routines in patchfox stabilize a bit, I should extract them into their own module under the SSBC org.

I don't have the bandwidth to deal with this at the moment.


ViewPager is not working for (androidx.viewpager.widget.ViewPager)

Android refactored import android.support.v4.view.ViewPager to androidx.viewpager.widget.ViewPager
So we can't use it anymore.
Will you fix your CircleIndicator.java?
If so, please change it ASAP.
Best regards,
Josh

Sorry, androidx is still in beta version.
You can fork this project and change it.

Now it is live


Remove clients

Ability to select certain or multiple clients from the clients grid on the clients page and delete them with the delete button.
It might be nice to have a pop-up that says "Are you sure you want to delete (num selected) teams?" and the user says yes or no.

Modal still pops up on empty client selection, perhaps want to add validation for this in next sprint.


OpenVariant | fix docs build

ReadTheDocs now requires a yaml file with specs for the build of the documentation.

#24


SizeUnit needs to be extended for MibiBytes, KibiBytes, etc

Hi guys,
I noticed today that you added support for KiB, MiB, etc a couple of years ago (https://github.com/dropwizard/dropwizard/commit/9044d44857fc1c90424303732502536c84963968), but you didn't get the semantic meaning of your extensions right. For instance, see: https://en.wikipedia.org/wiki/Gigabyte#Definition.
SizeUnit.KILOBYTE should use 1000 as the multiplier, while (the currently missing) SizeUnit.KIBIBYTE should use 1024 as the multipler. Once these additional SizeUnit values are defined, they need to be used on the proper suffixes in Size.java.
See this (10 year) old post by Jeff Atwood for a more complete picture of the differences: https://blog.codinghorror.com/gigabyte-decimal-vs-binary/. Please don't listen to the negative attitude of this article - it's 10 years old. The storage industry really does use these suffixes correctly these days and enterprise customers know the difference and expect them to be accurate.

It should be easy to extend SizeUnitTest, SizeTest, SizeUnit, and Size with this.
Why don't you open a PR?

Good idea and I will. I have one concern. The change will break backward
compatibility because currently kilobytes represents a multiple of 1024 and
according to the OSI definition KB should be a multiple of 1000 and KiB is
1024. Thoughts?
John
On Fri, Sep 15, 2017 at 12:49 AM lutzhorn<EMAIL_ADDRESS>wrote:

It should be easy to extend SizeUnitTest
https://github.com/dropwizard/dropwizard/blob/master/dropwizard-util/src/test/java/io/dropwizard/util/SizeUnitTest.java,
SizeTest
https://github.com/dropwizard/dropwizard/blob/master/dropwizard-util/src/test/java/io/dropwizard/util/SizeTest.java,
SizeUnit, and Size with this.
Why don't you open a PR?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dropwizard/dropwizard/issues/2152#issuecomment-329697453,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADA8lPiwnqe23DxDDOy0SxdHtLPtjB9ks5sih4WgaJpZM4PW05_
.

Are there tests that will fail after this change? If not, tests for features that will be broken by such a change should be added first.

I doubt this is a breaking change from a drop wizard code perspective (things should still build and unit tests should still work). It may, however, break code referencing this library who are using these values to allocate buffers. If a program needs a 1 KiB buffer but is using the current Size.KILOBYTES this change will break that application as the buffer will be 24 bytes smaller.
I think this change is necessary. It may be worth pushing to 2.0 and posting a notice in the upgrade guide for migrating from 1.X to 2.0. I personally would love to see this change in 1.X series, however, I think the safer approach is called for in this instance.

The PR is open at https://github.com/dropwizard/dropwizard/pull/2154.

@dropwizard/committers Any strong opinions on this feature request (and the corresponding PR in #2154)?
I'm in principle for using the correct naming for units but I'm also afraid of unintended breakage in the applications of Dropwizard users.
If we decide to change the semantics of SizeUnit, we should do it now or we'll have to wait for Dropwizard 3.0.0.

I'm in principle for using the correct naming for units

Agreed.

I'm also afraid of unintended breakage in the applications of Dropwizard users

The risk, I feel here, is pretty minimal. I feel like someone who cares about the difference between kilobyte and KibiBytes (and the like) would have recognized the misnomer and coded their expectations directly using SizeUnit.bytes with (1000) or (1024) as the base.

@nickbabcock It's more about the case which @isaki outlined in his comment:

If a program needs a 1 KiB buffer but is using the current Size.KILOBYTES this change will break that application as the buffer will be 24 bytes smaller.

I also agree having proper terminology is important, but I think we should plan out this change a bit more to prevent breakage (maybe introduce new terms so we can properly deprecate the old ones).  I don't think this needs to go into 2.0.0 at this time.

I don't know if we should bend over backwards to support the use case of
public void abc123() {
    byte[] myBuffer = new byte[(int)SizeUnit.KILOBYTES.toBytes(1)];
    readSomething(myBuffer);
}

private void readSomething(byte[] myBuffer) {
    if (myBuffer.length != 1024) {
        throw new IllegalArgumentException();
    }
    // ...
}

Seems like we would need to expend a non-negligible amount of effort to try and seamlessly transition and deprecate everyone to new terminology.
I'm also fine not rushing to a decision

@nickbabcock I agree.  All I'm saying is I don't think #2154 is ready to be merged in right before we release 2.0.0 (hopefully soon™)

@nickbabcock @jplock I've given it a try in #2686. Maybe we could merge that one for Dropwizard 2.0.0.


Check OS version for cert location

In https://github.com/CosmiQ/cw-nets/blob/master/cw_nets/cw_generator/cw_generator.py#L29, it doesn't check OS version before setting cert location. Should be changed.

This is no longer relevant now that we're not using the old structure for cw_nets.


Geting undefined block should not corrupt

Tests produces different errors but they look related thus same PR
The second test is skipped due high CPU usage, by unskipping it locally you can reproduce
Later, to reproduce the final "Error: Could not load node: 4" the test can be adjusted after the CPU fix or it can be reproduced at the moment by running this script twice:
const Hypercore = require('hypercore')

main()

async function main () {
  const core = new Hypercore('./data-w')
  await core.append(['Hello', 'World']) // Two values is required for this

  const clone = new Hypercore('./data-r', core.key)

  const s1 = core.replicate(true)
  const s2 = clone.replicate(false)

  s1.pipe(s2).pipe(s1)

  await clone.update({ wait: true })

  console.log('0', await clone.get(0))
  console.log('undef', await clone.get(undefined))

  await clone.close()
}

When running it for the first time it will use 100% CPU, do CTRL-C, and re-run it again then error should happen
It seems that the writer is only left sensible after the first run because if you remove the .append before the second run then everything appears to be fine but it is not lol, just corruption or whatever waiting to happen

Fixed in 10.33.2 that asserts the uints that are passed to c. Note that passing anything other than uints is undefined behaviour but shouldnt crash your process ever (hence the current asserts)
Mind making this into a proper test? :)

For people listening, its also not corrupting, its simply throwing on get with an invalid index

Thanks!


PageView widget in platform of Windows  no mouse control

ScrollConfiguration(
        behavior: ScrollConfiguration.of(context).copyWith(dragDevices: {
          PointerDeviceKind.touch,
          PointerDeviceKind.mouse,
        }),
        child: PageView.builder(
          itemCount: 4,
          itemBuilder: (bc, i) => Stack(
            children: [
              Text(i.toString()),
            ],
          ),
        ),
      )

running in Android is normal
but in windows  no mouse control
unable to slide with the mouse
flutter doctor -v

[√] Flutter (Channel master, 2.5.0-2.0.pre.113, on Microsoft Windows [Version 10.0.17763.2061], locale zh-CN)
    • Flutter version 2.5.0-2.0.pre.113 at D:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 0abf02f855 (8 days ago), 2021-07-30 17:44:02 -0700
    • Engine revision 29f9df723f
    • Dart version 2.14.0 (build 2.14.0-368.0.dev)
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\autopMateBook\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: D:\androidstudio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Enterprise 2019 16.9.0)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise
    • Visual Studio Enterprise 2019 version 16.9.31025.194
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.1)
    • Android Studio at D:\androidstudio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] IntelliJ IDEA Community Edition (version 2021.2)
    • IntelliJ at D:\IntelliJ IDEA Community Edition 2020.3.2
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] VS Code
    • VS Code at C:\Users\autopMateBook\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.24.0

[√] VS Code, 64-bit edition (version 1.57.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.24.0

[!] Proxy Configuration
    • HTTP_PROXY is set
    ! NO_PROXY is not set

[√] Connected device (3 available)
    • PCRT00 (mobile)   • emulator-5554 • android-x86    • Android 7.1.2 (API 25)
    • Windows (desktop) • windows       • windows-x64    • Microsoft Windows [Version 10.0.17763.2061]
    • Chrome (web)      • chrome        • web-javascript • Google Chrome 92.0.4515.131
    ! Device <IP_ADDRESS>:5555 is offline.

! Doctor found issues in 1 category.

Hi @au-top
This is working as expected, mouse drags are disabled by default and this change is not yet on Flutter stable channel, read more here.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Okay, thank you for your reply, I tried to use ScrollConfiguration to make it work on the desktop, but to no avail
How do I use pageview on desktop

Try this on desktop
https://api.flutter.dev/flutter/widgets/PageView-class.html sample with custom scroll behavior from https://flutter.dev/docs/release/breaking-changes/default-scroll-behavior-drag#setting-a-custom-scrollbehavior-for-your-application

minimal code sample
/// Flutter code sample for PageView

// Here is an example of [PageView]. It creates a centered [Text] in each of the three pages
// which scroll horizontally.

import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';

class MyCustomScrollBehavior extends MaterialScrollBehavior {
  // Override behavior methods and getters like dragDevices
  @override
  Set<PointerDeviceKind> get dragDevices => {
        PointerDeviceKind.touch,
        PointerDeviceKind.mouse,
        // etc.
      };
}

void main() => runApp(const MyApp());

/// This is the main application widget.
class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  static const String _title = 'Flutter Code Sample';

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      scrollBehavior: MyCustomScrollBehavior(),
      title: _title,
      home: Scaffold(
        appBar: AppBar(title: const Text(_title)),
        body: const MyStatelessWidget(),
      ),
    );
  }
}

/// This is the stateless widget that the main application instantiates.
class MyStatelessWidget extends StatelessWidget {
  const MyStatelessWidget({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    final PageController controller = PageController(initialPage: 0);
    return PageView(
      /// [PageView.scrollDirection] defaults to [Axis.horizontal].
      /// Use [Axis.vertical] to scroll vertically.
      scrollDirection: Axis.horizontal,
      controller: controller,
      children: const <Widget>[
        Center(
          child: Text('First Page'),
        ),
        Center(
          child: Text('Second Page'),
        ),
        Center(
          child: Text('Third Page'),
        )
      ],
    );
  }
}

thanks !


MySQLI Server-side management of SSL encryption

Hello,
I think it's a good thing to have the possibility to choose server side encryption just by setting up the CI database.php 'encrypt' => TRUE, but also keeping the base possibility to choose cert, cipher, etc.. (client-side encryption). Just by modifying some line of MySQLI driver, everything become possible!
Tested on all my projects, if I choose 'encrypt' => FALSE, I have :
object(stdClass)[32]
  public 'Variable_name' => string 'Ssl_cipher' (length=10)
  public 'Value' => string '' (length=0)

Then if I choose 'encrypt' => TRUE, I have :
object(stdClass)[34]
  public 'Variable_name' => string 'Ssl_cipher' (length=10)
  public 'Value' => string 'DHE-RSA-AES256-SHA' (length=18)

Available for further informations
Regards
CI ❤

Would you kindly explain how this works? I remember the originally implemented feature was full of quirks and I'm not confident of just merging something like that.

@narfbg By default in MySQL clients can supply a CA certificate matching the one used by the server and enable host name identity verification. In this way, the server and client place their trust in the same CA certificate and the client verifies that the host to which it connected is the one intended. If CA certificate is not present in client side, but SSL flag given at the moment of the MySQL connexion, PHP will etablish secured communication between client and server without verifying the identify of client (but server must be configured for) and actually it's not possible with this configuration.
Without this, it's very easy to sniff all TCP traffic..

Not sure ... I understand you might mean that it's just a MySQL version of HTTPS.
But if that's the case, then disabling certificate verification is a bad idea.

@narfbg Sure but it's better to have encrypted traffic than nothing else ..

I don't disagree with that, but SSL isn't only about encryption.
What I'm saying is that ssl_verify should be enabled by default and being switchable. However, when you turn the array into a simple boolean, the switch disappears and there's no possibility to do that.
Also, what happens if the server doesn't support encryption? I'd assume silently continuing with unencrypted traffic, which isn't good.

Actually, that's my bad - I know we already do this, but assumed it wouldn't work for your feature.
But you're not addressing my comment on certificate verification.


Add mrshll.com to the webring, link in footer

You can find the webring link in mrshll.com's <footer /> on all pages.

The link to the latest blog post is broken, here from the homepage. The website looks good, fix your broken links and I'll merge it :)

The link to the latest blog post is broken, here from the homepage. The website looks good, fix your broken links and I'll merge it :)

@neauoire maybe someone had an "effective dream" that I never read Lathe of Heaven :)
It's fixed now. Thanks for noticing. Hopefully the Oscean-inspired program I started writing this weekend will be less error prone than the current tangle of js dependencies.

@neauoire maybe someone had an "effective dream" that I never read Lathe of Heaven :)
It's fixed now. Thanks for noticing. Hopefully the Oscean-inspired program I started writing this weekend will be less error prone than the current tangle of js dependencies.

welcome to the webring :)

welcome to the webring :)


[HUDI-1529] Add block size to the FileStatus objects returned from metadata table to avoid too many file splits

What is the purpose of the pull request
This PR fixes an issue we identified when enabling metadata table for SparkSQL queries, which cause a huge number of file splits to be generate, causing the spark driver to eventually run out of memory in the split generation phase itself.
Verify this pull request
(Please pick either of the following options)

Manual verification on EMR cluster, that driver does not run out of memory

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@umehrot2 the CI seems to be failing?

@umehrot2 the CI seems to be failing?

Codecov Report

Merging #2451 (3f7ff79) into master (749f657) will decrease coverage by 41.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #2451       +/-   ##
============================================
- Coverage     50.71%   9.68%   -41.03%
+ Complexity     3060      48     -3012
============================================
  Files           419      53      -366
  Lines         18796    1930    -16866
  Branches       1922     230     -1692
============================================
- Hits           9533     187     -9346
+ Misses         8488    1730     -6758
+ Partials        775      13      -762

Flag
Coverage Δ
Complexity Δ

hudicli
?
?

hudiclient
?
?

hudicommon
?
?

hudiflink
?
?

hudihadoopmr
?
?

hudisparkdatasource
?
?

hudisync
?
?

huditimelineservice
?
?

hudiutilities
9.68% <ø> (-59.80%)
0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #2451       +/-   ##
============================================
- Coverage     50.71%   9.68%   -41.03%
+ Complexity     3060      48     -3012
============================================
  Files           419      53      -366
  Lines         18796    1930    -16866
  Branches       1922     230     -1692
============================================
- Hits           9533     187     -9346
+ Misses         8488    1730     -6758
+ Partials        775      13      -762

Flag
Coverage Δ
Complexity Δ

hudicli
?
?

hudiclient
?
?

hudicommon
?
?

hudiflink
?
?

hudihadoopmr
?
?

hudisparkdatasource
?
?

hudisync
?
?

huditimelineservice
?
?

hudiutilities
9.68% <ø> (-59.80%)
0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

 Please review.

Project coverage is 50.72%. Comparing base (749f657) to head (3f7ff79).
Report is 4541 commits behind head on master.

Files with missing lines
Patch %
Lines

...rg/apache/hudi/metadata/HoodieMetadataPayload.java
0.00%
4 Missing :warning:

...va/org/apache/hudi/metadata/BaseTableMetadata.java
0.00%
1 Missing :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2451      +/-   ##
============================================
+ Coverage     50.71%   50.72%   +0.01%
- Complexity     3060     3061       +1
============================================
  Files           419      419
  Lines         18796    18798       +2
  Branches       1922     1922
============================================
+ Hits           9533     9536       +3
+ Misses         8488     8487       -1
  Partials        775      775

Flag
Coverage Δ

hudicli
37.26% <ø> (ø)

hudiclient
∅ <ø> (∅)

hudicommon
52.00% <0.00%> (+0.02%)
:arrow_up:

hudiflink
10.20% <ø> (ø)

hudihadoopmr
33.06% <ø> (ø)

hudisparkdatasource
65.90% <ø> (ø)

hudisync
48.61% <ø> (ø)

huditimelineservice
66.84% <ø> (ø)

hudiutilities
69.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

...va/org/apache/hudi/metadata/BaseTableMetadata.java
0.00% <0.00%> (ø)

...rg/apache/hudi/metadata/HoodieMetadataPayload.java
0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes