Issues/#540 improved cleanup thread

This PR addresses GitHub issue: #319  .
Briefly describe the changes proposed in this PR:

Only run cleanup when needed.
Frequently yield write lock.

Looks like a good improvement, but I don't see how it relates to #319.

It doesnt, it is for #540.
On Sunday, 18 September 2016, 0:09, Jeen Broekstra<EMAIL_ADDRESS>wrote:

Looks like a good improvement, but I don't see how it relates to #319. —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Running Hudson verify: https://hudson.eclipse.org/rdf4j/job/rdf4j-verify-pr/19/

When hudson ran tests, I noticed the following errors:
Running org.eclipse.rdf4j.sail.memory.MemoryStoreTest Exception in thread "MemoryStore snapshot cleanup" java.lang.AssertionError: index >= size 	at org.eclipse.rdf4j.sail.memory.model.MemStatementList.get(MemStatementList.java:61) 	at org.eclipse.rdf4j.sail.memory.MemorySailStore.cleanSnapshots(MemorySailStore.java:280) 	at org.eclipse.rdf4j.sail.memory.MemorySailStore$1.run(MemorySailStore.java:324) 	at java.lang.Thread.run(Thread.java:745) Exception in thread "MemoryStore snapshot cleanup" java.lang.AssertionError: index >= size 	at org.eclipse.rdf4j.sail.memory.model.MemStatementList.get(MemStatementList.java:61) 	at org.eclipse.rdf4j.sail.memory.MemorySailStore.cleanSnapshots(MemorySailStore.java:280) 	at org.eclipse.rdf4j.sail.memory.MemorySailStore$1.run(MemorySailStore.java:324) 	at java.lang.Thread.run(Thread.java:745)
These don't seem to affect the eventual outcome of the tests (everything still greenlines AFAICT) but it's still worth having a look. Either the assumption made for that assertion no longer holds, or there is some concurrency issue at play.

Hard to reproduce but is due to concurrent clear() on close(). Fixed.

Thanks. Running hudson verify again: https://hudson.eclipse.org/rdf4j/job/rdf4j-verify-pr/20


Swipe to Dismiss on CentrePopup?

Could it be possible to add swipe to dismiss for CentrePopup type as well?

Hey @praveenperera,
Good idea actually, I will add this to the backlog after I finally release version 3.0.0.
Have a good day,
Tomasz


Radix UI specific inputs

Describe the bug and the expected behavior
Hi! Radix UI is using a lot of custom logic for handling all kinds of different inputs. For example the issue I'm facing is with component RadioGroup.
If I'm using RadioGroup, bind conform to it and change a value, it goes to a function in conform called isFormControl. It returns false, because the element is div. However it has property role set to radiogroup.
Do you think it could be extended in some way to handle these kinds of inputs? I think semantically, role property should have its weight, not only tagName.
Conform version
v0.9.0
Steps to Reproduce the Bug or Issue

Install conform with Radix @radix-ui/react-radio-group
Create form with Conform

const RadioGroup = React.forwardRef<
  React.ElementRef<typeof RadioGroupPrimitive.Root>,
  React.ComponentPropsWithoutRef<typeof RadioGroupPrimitive.Root> & {
    label?: string;
    optional?: boolean;
    error?: string;
  }
>(({ className, label, error, optional, ...props }, ref) => {
  const { t } = useTranslation("ui");
  return (

      {label && (

          {label}
          {optional && (

               ({t("optional")})

          )}

      )}
      <RadioGroupPrimitive.Root
        className={cn("grid gap-2", className)}
        {...props}
        ref={ref}
      />
      {error && (

          {error}

      )}

  );
});
RadioGroup.displayName = "RadioGroup";

const RadioGroupItem = React.forwardRef<
  React.ElementRef<typeof RadioGroupPrimitive.Item>,
  React.ComponentPropsWithoutRef<typeof RadioGroupPrimitive.Item> & {
    label?: string;
  }
>(({ className, children, label, ...props }, ref) => {
  const inputId = React.useId();
  const labelId = React.useId();

  return (

      <RadioGroupPrimitive.Item
        ref={ref}
        aria-labelledby={label ? labelId : undefined}
        className="aspect-square h-4 w-4 rounded-full border border-primary text-primary ring-offset-background focus:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50"
        {...props}
        id={props.id ?? inputId}
      >
        <RadioGroupPrimitive.Indicator className="flex items-center justify-center">
          <Circle className="h-2.5 w-2.5 fill-current text-current" />
        </RadioGroupPrimitive.Indicator>
      </RadioGroupPrimitive.Item>
      {label && (

          {label}

      )}

  );
});
RadioGroupItem.displayName = "RadioGroupItem";

{/* And then render it like */}
<RadioGroup
                  className="mt-4 flex gap-4"
                  error={fields.layout.error}
                  ref={layoutRef}
                  {...conform.input(fields.layout)}
                  onValueChange={(v) => {
                    layoutInputEvent.change(v);
                    setSelectedLayout(v as SchemaData["layout"]);
                  }}
                >
                {/* Content */}
                </RadioGroup>

What browsers are you seeing the problem on?
Chrome
Screenshots or Videos
No response
Additional context
No response

Do you think it could be extended in some way to handle these kinds of inputs? I think semantically, role property should have its weight, not only tagName.

I am no expect on accessibility roles. Is it associated with an input through some sort of ids? If yes, i am happy to extends it. All Conform needed is the name of the input and a reference to the corresponding form element or form id.

If I'm using RadioGroup, bind conform to it and change a value, it goes to a function in conform called isFormControl. It returns false, because the element is div.

It seems like the Radix team prefer not to expose the form control element as it does on the Checkbox component. There are 2 solutions:

Do not rely on the hidden input created by Radix. (i.e. Don't set a name to the Radix component and make your own hidden input that you can access)

Try to access the element using a different approach like this one, e.g. document.getElementById(..) or form.elements.namedItem(inputName)?.[0] (Note: the extra ?.[0] is needed in case there is multiple elements with the same name)

I had a similar issue since I am using a Switch Radix component. When you use it inside a form the Radix renders a button alongside an input.
I couldn't use ?[0] , because I am using a similar implementation that @edmundhung mentioned
and for my page, is a list of many Switchs.
I resolve this issue using:
buttonRef.current?.nextElementSibling
Now, the ref is pointing to this closest radix input, therefore all conform's control... should point to the correct element input.


Stackoverflow searxng integration

I would suggest integrating a stackoverflow search option to the agent selection, as it is an extremely viable source for various programming-related issues.
It should be not too difficult, as searxng provides an endpoint for it already, so its mainly implementing to ./src/agents and handling the visual representation, which I am unable to.
I may do a PR for this as soon as I am familiar enough with the framework used in this project, but that may take time.

I tried to implement it, and the effect should be OK, but it has only been tested a small amount.


Fix a typo

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@Grisson : Thanks for your contribution to the Azure documentation! The author, @xerners, has been notified to review your proposed change.

#signoff


Running command from first .dpx file in directory

I've been making initial tests of RawCooked and had a test scan directory containing DPX files and a single WAV.  Using an older version of RAWCooked I attempted a MKV conversion on the /Scan01/ folder and received the error:
"Untested WAV FormatTag ChannelMask, please contact<EMAIL_ADDRESS>I managed to convert the directory by redirecting the rawcooked command to the first .dpx file in the /Scan01/ directory.  This MKV would not play in my Mac VLC player version 2.0.9, which I understand is too old a version now so I'll upgrade later today and test again. Upon re-expansion of the MKV I found that the WAV file was missing, and the resulting directory .01 GB smaller in size. The MKV was significantly smaller file size than the Scan 01 folder though, and a few random MD5 checksum tests of DPX files from original directory and MKV expanded directory were perfect matches.

I've been making initial tests of RawCooked

thank you!

"Untested WAV FormatTag ChannelMask, please contact<EMAIL_ADDRESS>
Is it fixed with this version?

Upon re-expansion of the MKV I found that the WAV file was missing,

Normal in that case that the WAV file is not used, as the DPX is explicitly requested.
I understand from your comment that you didn't expect that the WAV files (and any other sidecar file) are not compressed, this may be dangerous if the user expects that all is taken from the folder with this command, so I'll forbid the use of .dpx directly without explicit option indicating that this is wanted.

On a side note,Joanna I'm  doing some testing at the moment as well,and I
plan to write a blog on the tests too soon. I might drop you a line at some
point to share our findings?

Yep, sounds great Kieran. Please be patient with my 'newbie' status though.

I need the first KB of the file, would you mind to share it?
head -c 1000 FileName.wav > dump.wav would create a file dump dump.wav from FileName.wav (name to be replaced by the right one) with 1000 bytes only, so no copyright issue IMO.

Okay, thanks that's a better option. dump.wav created i'll email you with it now.

The WAV file contains a channelMask I filter (it is set to 0 = no mask instead of saying the channel position of the channel).
Note: I am very strict on the different configurations of the files because I want to test any element which could lead to a different behavior of FFmpeg e.g. channel reordering, this would break reversibility.
As decoding is fine with such config, I add them to the white list.

Will this be something that needs altering a point of capture of the WAV?

Will this be something that needs altering a point of capture of the WAV?

It is not important, especially for mono streams, it is just no explicit channel positioning.
Channel Mask documentation is not explicit about the need of filling it with the right count of bits set to 1 (1 bit set for mono, 2 bits set for stereo...), and on our side it is not an issue for reversibility.

"Untested WAV FormatTag ChannelMask, please contact<EMAIL_ADDRESS>
This part should be fixed with the latest snapshot.
I keep this ticket open for the other issue (avoiding "WAV file was missing" question by adding an explicit option for parsing a file or sequence of files instead of a directory)

Upon re-expansion of the MKV I found that the WAV file was missing,

Now parsing directly a DPX file is rejected by default, so it is more explicit that this is for parsing only the file and not the complete directory.
Snapshots are updated.
I think that now all indicated issues are resolved.


Leonid Station (third times a charm, now with Piras support)

making a new one at Piras' request since the map got reverted for not properly working
large station with sections of maints inside asteroid bits, worked on
I just copied the kettle prototype file and used the evac and cargo shuttle from fland, job counts will probably need to be adjusted
(looks a bit empty in spots as spawns are hidden)

Isnt there like 1 reinforced wall between tiders and [AA card, armored space suit, best laser gun]

Isnt there like 1 reinforced wall between tiders and [AA card, armored space suit, best laser gun]

yeah, it originally was 2 before I re did the bedroom very late into the mapping, I still find it preferable over captain's rooms with external windows that a few maps have. it is a very public hallway so easily noticeable if someone is trying to break in.
I could easily be changed by moving the locker and stuff into the office and then double thicking the left wall that goes into a hallway

Funny enough the other problem is exactly in the hallway being Wery Public
When you see a Caps room, you KNOW its gonna explode at some point. No matter how valid that is, people will in fact do it... And when they do... Its gonna be spessed...
Also the funny thing would be to set up singu, place magnet SOUTH of it, so that when it is released, singu goes directly to Caps room

okay being able to magnet a singulo to cap's room easily is literally not an issue at all lol

Funny enough the other problem is exactly in the hallway being Wery Public
When you see a Caps room, you KNOW its gonna explode at some point. No matter how valid that is, people will in fact do it... And when they do... Its gonna be spessed...

well its 2 thick now

I'm also going to adjust some APCs to be more friendly twords IPCs


Doesn't seem to be working

Installed the extension in the latest VSCode and could get very little of it to work.
Current Behavior

Created a file explore.literate.  This showed Plain Text as the mode (bottom right of frame) and none of the markdown was highlighted.
Markdown: Preview was not available as a command option.
Literate Process was available.  Running it produced a relatively unformatted but seemingly complete html file (except it didn't show the chunk names) but none of the code files.  I used ```js <<groupb.*>>= explore2.js` as the style for the block open.
Running Extensions does not show literate as running.
Extension Host view does not mention it.
EditorConfig show stuff like this (node-sqlight-test is my project name):

node-sqlight-test/explore.literate: {}
node-sqlight-test/explore.literate: {}
node-sqlight-test/explore.literate: {}
node-sqlight-test/explore.literate: {}
exthost: {}
exthost: {}
exthost: {}
node-sqlight-test/explore.literate: {}
undefined: {}

I didn't see anything else.
Previous Behavior/Installation
When I first installed the extension there were more errors and messages showing in the various logs, many looking like 6) above.  Extension Host mentioned activating the extension just before stack  traces from (probably) 3 attempts to active the extension. But when I restarted VSCode, I got just what's shown above.  I tried disabling and then reenabling the extension, but that didn't seem to produce any debug output at all.
Speculation
I took a look at the source, but am unfamiliar with the requirements for an extension.  So nothing jumped out at me.  Possibly something about the requirements for extensions has changed since this was written.  Or changes in versions of packages it depends on are creating clashes.  Possibly I have misunderstood something.
In particular, my test file explore.literate was trying to see if 2 source files could be generated from it; it wasn't clear to me if that should work.  However, my problems seem to be happening at an earlier step, like the extension isn't getting activated when I open a .literate file.
System Configuration
From VSCode Help | About:
Version: 1.84.2 (system setup)
Commit: 1a5daa3a0231a0fbba4f14db7ec463cf99d7768e
Date: 2023-11-09T10:51:52.184Z
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.17763
I recently installed Node.js 20; maybe there's a clash there.  But I expect VSCode has its own version it uses.

Thanks for your response.
I clicked on the bottom right where "Plain Text" showed and changed it to "Markdown", which gets the preview working.  Did you have something more permanent in mind when you said "make the association for .literate to be handled as markdown"?  That sounds more like something that would affect every file with that extension.
Also, I did not realize I needed the : between the language type and the fragment name until I saw the sample you put in your response (and noticed the fragment name wasn't in the preview without it).  It might be good to have that in the README.
Finally, when looking at the extension source my preview of literate.literate does not have a table of contents, though your screenshot shows one.  Anything I can do about that?

Thanks for the info.  I still don’t see anything in the README about the : after the language specifier at the start of the code fence.
From: Nathan Letwory @.>
Sent: Tuesday, November 28, 2023 2:30 PM
To: jesterKing/literate @.>
Cc: Boylan, Ross @.>; Author @.>
Subject: Re: [jesterKing/literate] Doesn't seem to be working (Issue #25)
The README has now a link to https: //jesterking. github. io/literate/ . This also explains how the fragments are supposed to be constructed. The TOC is generated by Markdown AutoTOC extension ( https: //marketplace. visualstudio. com/items?itemName=wibblemonkey. markdown-auto-toc
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
The README has now a link to https://jesterking.github.io/literate/https://urldefense.com/v3/__https:/jesterking.github.io/literate/__;!!LQC6Cpwp!vauabZ-BtMd6t1C6MrU3pwenbWWhRELTF4ZRtnlso0jt7uMo4HR-fcbleYArOYhAP6vUMF0yH0axVlQ8__khBTNzpS8$ . This also explains how the fragments are supposed to be constructed.
The TOC is generated by Markdown AutoTOC extension ( https://marketplace.visualstudio.com/items?itemName=wibblemonkey.markdown-auto-tochttps://urldefense.com/v3/__https:/marketplace.visualstudio.com/items?itemName=wibblemonkey.markdown-auto-toc__;!!LQC6Cpwp!vauabZ-BtMd6t1C6MrU3pwenbWWhRELTF4ZRtnlso0jt7uMo4HR-fcbleYArOYhAP6vUMF0yH0axVlQ8__khQRVDzz8$ ). Install that and you should automatically get a TOC. Eventually I want to add such functionality directly to this extension, though.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/jesterKing/literate/issues/25*issuecomment-1830861383__;Iw!!LQC6Cpwp!vauabZ-BtMd6t1C6MrU3pwenbWWhRELTF4ZRtnlso0jt7uMo4HR-fcbleYArOYhAP6vUMF0yH0axVlQ8__khcYAP41U$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AATGAMXETKK3IUIA6FLFSELYGZQWDAVCNFSM6AAAAAA7QUJGKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZQHA3DCMZYGM__;!!LQC6Cpwp!vauabZ-BtMd6t1C6MrU3pwenbWWhRELTF4ZRtnlso0jt7uMo4HR-fcbleYArOYhAP6vUMF0yH0axVlQ8__khGiDTMc4$.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


does scan api  only can get one row each time？

i found scan api has each method，does it mean scan api   only can get one row each time？but the java
api can get all the rows at the same time. does  this scan api is not the really scan ,just imitate the really scan?

Our scanner uses rpc Scan, so it is really a scan. This implementation gets 100 rows by default in each scan call, meaning that if you have a scan which matches 1234 results (for simplicity, let's assume only one region server) and you call each method on such scan, it will do 13 hbase calls to retrieve all the results.


[feature-wip] (memory tracker) (step5) Track track bthread, fix track vectorized query

Proposed changes
Issue Number: close #7196
Problem Summary:

fix track bthread

Bthread, a high performance M:N thread library used by brpc. In Doris, a brpc server response runs on one bthread, possibly on multiple pthreads. Currently, MemTracker consumption relies on pthread local variables (TLS).
This caused pthread TLS MemTracker confusion when switching pthread TLS MemTracker in brpc server response. So replacing pthread TLS with bthread TLS in the brpc server response saves the MemTracker.
Ref: https://github.com/apache/incubator-brpc/blob/731730da85f6af5c25012b4c83ab5bb371320cf8/docs/en/server.md#bthread-local

fix track vectorized query

Added track mmap. Currently, mmap allocates memory in many places of the vectorized execution engine.
Refactored ThreadContext to avoid dependency conflicts and make it easier to debug.
Fix some bugs.

Checklist(Required)

Does it affect the original behavior: (Yes)
Has unit tests been added: (No)
Has document been added or modified: (No)
Does it need to update dependencies: (No)
Are there any changes that cannot be rolled back: (Yes)

Further comments
1. Stability
1) mem_limit=10M
This means that the memory limit of the BE process is 10M. At this time, the BE process will still start normally, but cannot do anything, and the query will return an error:
This means that after BE is started, the process mem limit has left -156M.
ERROR 1105 (HY000): errCode = 2, detailMessage = Memory exceed limit. fragment=89c882f82fa74db1-b8010703e7974fed, details=PartitionedHashTableCtx::ExprValuesCache failed to allocate 53760 bytes, on backend=<IP_ADDRESS>. Memory left in process limit=-156100257.00 B . failed alloc=<Memory limit exceeded: ExecNode:Exprs:AGGREGATION_NODE (id=65): TryConsume failed, bytes=53760 process whole consumption=244424704 mem limit=10485760>. current tracker=ExecNode:Exprs:AGGREGATION_NODE (id=65) . If this is a query, can change the limit b

2) mem_limit=80% (default), set exec_mem_limit=10M
The query returns the error:
At this time, the query mem limit is 10485760B, 10464520B has been used, and the re-allocation of 32768B fails.
The memory application information reported when switching the MemTracker is aggregator, while execute get_next.
The tracker belongs to ExecNode:VAGGREGATION_NODE, and the consumption of the tracker in the TCMalloc Hook fails.
ERROR 1105 (HY000): errCode = 2, detailMessage = Memory limit exceeded: Memory exceed limit. fragment=, details=In TCMalloc Hook, aggregator, while execute get_next., on backend=<IP_ADDRESS>. Memory left in process limit=300.81 GB. failed alloc=<Memory limit exceeded: label=queryId=fdb6664525fe40f9-8bc275d2c86d2546 TryConsume failed size=32768, used=10464520, limit=10485760>. current tracker=ExecNode:VAGGREGATION_NODE (id=24). If this is a query, can change the limit by session variable exec_mem_limit.

3) mem_limit=99%, set exec_mem_limit=20G
(waiting for the test..., expecting BE will not crash)
2. Performance
Similar to #8669  test conclusion on row storage, the new memory statistics framework will also bring about a 2% performance loss on vectorized queries.
For POC performance testing, consider turning off the detailed memory track memory_verbose_track=false, which will avoid a 1% performance loss, and further completely turn off the memory track track_new_delete=false, which will further avoid a 1% performance loss.
1) TEST 1 - SSB 600w
Env: 1 FE, 1 BE;
Test Set: ssb LINEORDER 600w;
Default session veriables;
jmeter thread=20;

conf
Q1.1(qps, avg time ms)
Q1.2
Q1.3
Q2,1
Q2.2
Q3.1
Q4.1

track_new_delete=false
175.0/s, 110 ms
214.1/s, 90 ms
225.7/s, 86 ms
72.5/s, 268 ms
71.6/s, 272 ms
68.0/s, 286 ms
45.8/s, 424 ms

track_new_delete=true
170.1/s, 114 ms
211.6/s, 91 ms
222.9/s, 87 ms
72.1/s, 269 ms
71.3/s, 273 ms
67.5/s, 288 ms
45.7/s, 427 ms

2) TEST 2 - SSB 60003w
Env: 1 FE, 1 BE;
Test Set: ssb LINEORDER 60003w;
Default session veriables;
jmeter thread=1;

conf
Q1.1(qps, avg time ms)
Q1.2
Q1.3
Q2,1
Q2.2
Q3.1
Q4.1

track_new_delete=false
2.0/s, 490 ms
12.7/s, 77 ms
13.8/s, 72 ms
0.0/s, 28306 ms
0.0/s, 20577 ms
0.0/s, 41081 ms
0.0/s, 48236 ms

track_new_delete=true
1.9/s, 525 ms
11.8/s, 84 ms
13.0/s, 76 ms
0.0/s, 28531 ms
0.0/s, 20970 ms
0.0/s, 42959 ms
0.0/s, 48723 ms

3) TEST 3 - small query
Env: 1 FE, 1 BE;
Test Set: ssb LINEORDER 600w;
Default session veriables;
jmeter thread=20;

conf
select LO_EXTENDEDPRICE from LINEORDER2 where LO_EXTENDEDPRICE = 5273584 limit 1;

track_new_delete=false
8275.7/s, 11 ms

track_new_delete=true
8203.6/s, 11 ms

3. Observability
Env: 1 FE, 1 BE
Test Set: ssb LINEORDER 60003w
track_new_delete=true
memory_verbose_trace=true
set parallel_fragment_exec_instance_num=2;

Test SQL: SSB Q3.1
         SELECT C_NATION, S_NATION, D_YEAR,
          SUM(LO_REVENUE)  AS  REVENUE
          FROM customer, lineorder, supplier, dates
          WHERE  LO_CUSTKEY = C_CUSTKEY
          AND LO_SUPPKEY = S_SUPPKEY
          AND  LO_ORDERDATE = D_DATEKEY
          AND C_REGION = 'ASIA'
          AND S_REGION = 'ASIA'
          AND D_YEAR >= 1992 AND D_YEAR <= 1997
          GROUP BY C_NATION, S_NATION, D_YEAR
          ORDER BY D_YEAR ASC,  REVENUE DESC;

see: BeIP:HttpPort/mem_tracker
// The Level use to decide whether to show it in web page,
// each MemTracker have a Level less than or equal to parent, only be set explicit,
// TASK contains query, import, compaction, etc.
enum class MemTrackerLevel { OVERVIEW = 0, TASK, INSTANCE, VERBOSE };

mem_tracker_level=0 (default OVERVIEW)

init

query ing

query done

mem_tracker_level=1 (TASK)

query ing

mem_tracker_level=2 (INSTANCE)

query ing

mem_tracker_level=3 (VERBOSE)

query ing

query done

query ing,  set parallel_fragment_exec_instance_num=10;

ERROR 1105 (HY000): errCode = 2, detailMessage = Memory limit exceeded: Memory exceed limit. fragment=, details=In TCMalloc Hook, aggregator, while execute get_next., on backend=<IP_ADDRESS>. Memory left in process limit=293.08 GB. failed alloc=<Memory limit exceeded: label=queryId=5e72ea753ed5438b-89adf8b2a56f6bf1 TryConsume failed size=4096, used=2147853311, limit=2147483648>. current tracker=ExecNode:VAGGREGATION_NODE (id=7). If this is a query, can change the limit by session variable exec_mem_limit.

query ing,  set parallel_fragment_exec_instance_num=10, set exec_mem_limit=<PHONE_NUMBER>0;

cc @morningman @yangzhg


Error listing directory

its not working in any ftp clients.
the server is running but i get the following error in clients.
Timeout detected. (control connection)
Could not retrieve directory listing
Error listing directory '/'.

same error

maybe related to pasv_address=<IP_ADDRESS> .
FYI
https://stackoverflow.com/questions/43758580/filezilla-the-data-connection-could-not-be-established-econnrefused-connec

I can confirm that the pasv_address is the problem when behind a NAT or routing otherwise
For my own purposes I hotfixed the problem with a Dockerfile as follows..
FROM garethflowers/ftp-server

RUN sed -i -r "s/<IP_ADDRESS>/my_external_ip/g" /etc/vsftpd.conf

...and then running this newly tagged/built container instead
it would be better to create an ENV variable somehow to set this variable in an easier way

I also had a problem due to pasv_address=<IP_ADDRESS> being set by default.  My containers are in a VLAN and my security cameras created 0 size files because of this.  However I also had to remove the pasv_addr_resolve=YES line as well as I think that was setting it to expect a hostname instead of an IP address.
FROM garethflowers/ftp-server:0.7

RUN sed -i -r "s/<IP_ADDRESS>/<IP_ADDRESS>/g" /etc/vsftpd.conf && sed -i "/pasv_addr_resolve/d" /etc/vsftpd.conf

Duplicate of #14.


About other languages

Hello!!
Do you have plans to correspond to Japanese?
If you correspond, please tell me the time!

Hi there!
We don't have plans for it as we mostly focus on Russian and English languages, but we do accept contributions.
I feel that most of our models could work on Japanese texts but they would need an appropriate word tokenizer in their pipelines.


Can't send email from Admin and Admin.Api projects

Hi @skoruba,
as you know, current implementation of mail sending and mail sending configuration is in STS so it's not reusable.
Where would you put configuration and three interface implementations so all is reusable?
I am not really sure new project just for this is needed, can it be moved to some of already existing ones?
What do you think?
Thank you

Just to say if not clear, I am willing to implement it. Looking for your input, how and where...
Thank you

Hi @b0 - thanks for opening this issue.
I think it is connected to issue: #413.
My idea:
I would create new project called:
Skoruba.IdentityServer4.Shared
And this project will be for shared things like email service, maybe some shared configuration?
Please, tell me what do you think about it?
Or even we can create new project for email service, but I think one Shared project should be enough.
Thanks.

Yup. Definitely connected to #413.
I agree, new Skoruba.IdentityServer4.Shared project is fine.
I will create it, move mail sending and configuration there, make appropriate refactoring to STS and make a PR.
Thank you

Thank you, it would be great. 👍🏼

BTW: @b0 - can you send me your contact to my email - I'd like to discuss some details with you, if you agree. :) Thank you.

Hello, I have been looking that when a user register via the MVC an email get sends but when using the API no email get sends....

@ekjuanrejon You are correct, that functionality is not implemented in API project. Currently, mail is sent only when user register via MVC application(STS, GUI) .
Best regards

As of #671, mail sending is possible from Admin and API projects so I am closing this issue.
Thanks to everyone involved.
Best regards


CUDA Legacy CMake Compatibility does not follow list command rules

Describe the bug
cuda.bbclass appends a list of space-separated CUDA_NVCC_FLAGS to the EXTRA_OECMAKE for all recipes inheriting cuda.
The legacy FindCUDA that is provided by OE4T/tegra-cmake-overrides notes that for input variable CUDA_NVCC_FLAGS:
"NOTE: multiple arguments must be  semi-colon delimited (e.g. --compiler-options;-Wall)"
If the cmake file to be built uses the list(APPEND functionality in cmake to append to the CUDA_NVCC_FLAGS, those provided by the bbclass become one "megaflag" that is passed to NVCC in quotes which breaks nvcc flag parsing in very odd ways.
To Reproduce
Steps to reproduce the behavior:

Create recipe that utilizes both the cuda and cmake classes.
In CMakeLists.txt for test recipe, add list(APPEND CUDA_NVCC_FLAGS --compiler-options -Wall)
Build using machine from meta-tegra and note that flags passed to nvcc will be improperly quoted.

Additional context
Originally ran into creating recipe for ArrayFire. Sadly, I cannot share the recipe due to corporate rules.

If you change the line in cuda.bbclass that sets that CMake variable to be
-DCUDA_NVCC_FLAGS="${@';'.join(d.getVar('CUDA_NVCC_FLAGS').split())}"

does that fix the problem?  If you can give it a try and let me know, I'll queue up the fix, and you should be able to work around the issue in the meantime by overriding the EXTRA_OECMAKE setting in your recipe to use the above construct.

I've pushed the fix to mickledore and other branches where it applies.


New patch for master

This is the newest patch for master 0.8.9.
This will be pulled as soon as we have a consistent way of getting binary dists out there.

Current coverage is 50.32%

Branch #247 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.
Review entire Coverage Diff as of 5636de7

Powered by Codecov. Updated on successful CI builds.


Semester time unit

Feature Proposal
Today, there isn't this time unit (Semester). Why? 😅
I have asked, some time ago: https://github.com/chartjs/Chart.js/discussions/10776
Possible Implementation
No response

Did some quick googling, doesnt seem like the date libs support with a time format:
https://github.com/moment/moment/issues/3582
https://day.js.org/docs/en/plugin/advanced-format

This unit doesn't exist because the underly date libraries don't have a concept for it. Also, semesters are different for each school so it's hard to write something generic.
You can probably do this by making a custom date adapter and then using a custom format string that you handle internally. You can take a look at the luxon adapter to get a sense of how to implement something like this


EOS 1.2.4 docker build problem

Sending build context to Docker daemon  32.77kB
Error response from daemon: Bad response from Docker engine
Ted:docker ted$ docker build . -t eosio/eos
Sending build context to Docker daemon  32.77kB
Step 1/17 : FROM eosio/builder as builder
---> fddd618113d5
Step 2/17 : ARG branch=master
---> Using cache
---> 9133b32091ec
Step 3/17 : ARG symbol=SYS
---> Using cache
---> 27758656e9c1
Step 4/17 : RUN git clone -b $branch https://github.com/EOSIO/eos.git --recursive     && cd eos && echo "$branch:$(git rev-parse HEAD)" > /etc/eosio-version     && cmake -H. -B"/tmp/build" -GNinja -DCMAKE_BUILD_TYPE=Release -DWASM_ROOT=/opt/wasm -DCMAKE_CXX_COMPILER=clang++        -DCMAKE_C_COMPILER=clang -DCMAKE_INSTALL_PREFIX=/tmp/build  -DSecp256k1_ROOT_DIR=/usr/local -DBUILD_MONGO_DB_PLUGIN=true -DCORE_SYMBOL_NAME=$symbol     && cmake --build /tmp/build --target install && rm /tmp/build/bin/eosiocpp
---> Running in 4f122c3d55a3
Cloning into 'eos'...
Submodule 'contracts/libc++/upstream' (https://github.com/EOSIO/libcxx.git) registered for path 'contracts/libc++/upstream'
Submodule 'contracts/musl/upstream' (https://github.com/EOSIO/musl.git) registered for path 'contracts/musl/upstream'
Submodule 'externals/binaryen' (https://github.com/EOSIO/binaryen) registered for path 'externals/binaryen'
Submodule 'externals/magic_get' (https://github.com/EOSIO/magic_get) registered for path 'externals/magic_get'
Submodule 'libraries/appbase' (https://github.com/eosio/appbase) registered for path 'libraries/appbase'
Submodule 'libraries/chainbase' (https://github.com/eosio/chainbase) registered for path 'libraries/chainbase'
Submodule 'libraries/fc' (https://github.com/EOSIO/fc) registered for path 'libraries/fc'
Submodule 'libraries/softfloat' (https://github.com/eosio/berkeley-softfloat-3) registered for path 'libraries/softfloat'
Cloning into '/eos/contracts/libc++/upstream'...
Cloning into '/eos/contracts/musl/upstream'...
Cloning into '/eos/externals/binaryen'...
Cloning into '/eos/externals/magic_get'...
Cloning into '/eos/libraries/appbase'...
Cloning into '/eos/libraries/chainbase'...
Cloning into '/eos/libraries/fc'...
Cloning into '/eos/libraries/softfloat'...
Submodule path 'contracts/libc++/upstream': checked out '2880ac42909d4bb29687ed079f8bb4405c3b0869'
Submodule path 'contracts/musl/upstream': checked out '8a34536ac9764c90c86cc0b62d0cda07449fd5d8'
Submodule path 'externals/binaryen': checked out '16d641f62ab14df845c87a63efe4d991b508d19a'
Submodule path 'externals/magic_get': checked out '89fda1da702e6c76a22bfb6233e9e3d0641708ec'
Submodule path 'libraries/appbase': checked out 'fa0e7fd9aa8be6ddc0c2f620cae63e58fefafab2'
Submodule path 'libraries/chainbase': checked out '315ef1b8f973667599fc599695a50cb14eafcf58'
Submodule path 'libraries/fc': checked out '62a19a758682679e3de27d956986eaf8b016465d'
Submodule path 'libraries/softfloat': checked out '9942875eb704369db297eb289aa4e9912bddcfb8'
-- The C compiler identification is Clang 4.0.1
-- The CXX compiler identification is Clang 4.0.1
-- Check for working C compiler: /usr/bin/clang
-- Check for working C compiler: /usr/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/clang++
-- Check for working CXX compiler: /usr/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Secp256k1: /usr/local/lib/libsecp256k1.a
-- Using custom FindBoost.cmake
-- Boost version: 1.67.0
-- Found the following Boost libraries:
--   thread
--   date_time
--   filesystem
--   system
--   program_options
--   signals
--   serialization
--   chrono
--   unit_test_framework
--   context
--   locale
--   iostreams
-- Configuring EOSIO on Linux
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
-- binaryen building with -std=c++11
-- binaryen building for platform x86-64
-- binaryen building with -Wall
-- binaryen building with -Werror
-- binaryen building with -Wextra
-- binaryen building with -Wno-unused-parameter
-- binaryen building with -fno-omit-frame-pointer
-- binaryen building with -fPIC
-- binaryen building with -O2
-- binaryen building with -UNDEBUG
-- binaryen building with -fcolor-diagnostics
-- Using 'SYS' as CORE symbol name
-- Using 'EOS6MRyAjQq8ud7hVNYcfnVPJqcVpscN5So8BhtHuGYqET5GDW5CV' as public key for 'eosio' account
-- Found WASM: /opt/wasm/bin/clang
-- Using WASM clang => /opt/wasm/bin/clang
-- Using WASM llc => /opt/wasm/bin/llc
-- Using WASM llvm-link => /opt/wasm/bin/llvm-link
-- Found Secp256k1: /usr/local/lib/libsecp256k1.a
-- Found GMP: /usr/lib/x86_64-linux-gnu/libgmp.a
-- Configuring fc to build on Unix/Apple
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.a
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11")
-- zlib found
-- Configuring Builtins
-- Configuring SoftFloat
-- Using custom FindBoost.cmake
-- Boost version: 1.67.0
-- Found the following Boost libraries:
--   thread
--   date_time
--   filesystem
--   system
--   chrono
--   unit_test_framework
--   locale
-- Configuring ChainBase on Linux
-- Using custom FindBoost.cmake
-- Boost version: 1.67.0
-- Found the following Boost libraries:
--   thread
--   date_time
--   filesystem
--   system
--   chrono
--   program_options
--   unit_test_framework
--   locale
-- Configuring AppBase on Linux
-- Found Git: /usr/bin/git (found version "2.17.1")
-- Found bsoncxx headers: /usr/local/include/bsoncxx/v_noabi
-- Found bsoncxx library: /usr/local/lib/libbsoncxx-static.a;/usr/local/lib/libbson-static-1.0.a;-lgcc;-lgcc_s;-lc;-lgcc;-lgcc_s;/usr/lib/x86_64-linux-gnu/librt.so;/usr/lib/x86_64-linux-gnu/libm.so;-pthread
-- Found mongocxx headers: /usr/local/include/mongocxx/v_noabi;/usr/local/include/bsoncxx/v_noabi
-- Found mongocxx library: /usr/local/lib/libmongocxx-static.a;/usr/local/lib/libbsoncxx-static.a;/usr/local/lib/libbson-static-1.0.a;-lgcc;-lgcc_s;-lc;-lgcc;-lgcc_s;/usr/lib/x86_64-linux-gnu/librt.so;/usr/lib/x86_64-linux-gnu/libm.so;-pthread;/usr/local/lib/libmongoc-static-1.0.a;/usr/local/lib/libbson-static-1.0.a;-lgcc;-lgcc_s;-lc;-lgcc;-lgcc_s;/usr/lib/x86_64-linux-gnu/librt.so;/usr/lib/x86_64-linux-gnu/libm.so;-pthread;/usr/lib/x86_64-linux-gnu/libssl.so;/usr/lib/x86_64-linux-gnu/libcrypto.so;rt;/usr/lib/x86_64-linux-gnu/libz.so;resolv
-- Git commit revision: cc9decff
-- Git commit revision: cc9decff
-- Found Intl: /usr/include
-- Git commit revision: cc9decff
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
-- Doxygen not found.  Contract documentation will not be generated.

Please refer to latest code and documentation:
https://github.com/EOSIO
https://developers.eos.io/
If problem persists with latest version please raise new issue.


xset logfile

In many devices xset when used with --logfile /dev/stderr fails the clipmenu script because of lack of permissions. New users might not be able to debug this. It would be a better idea to altogether skip this argument and let the logfile remain in its default location.

What version of clipmenu is this? What does stat -L /dev/stderr say?
On a sane init system, /dev/stderr should be a symlink to /proc/self/fd/2, which should certainly be writable by xsel as launched by clipmenud.
If the issue is that /dev/stderr doesn't exist, we shouldn't write to it at all (see f576a116fd).

Closing due to no response.


Achievements not loading

As title says, I open a game and none of the achievements are loading.

same happens to me

Yeah, program is dead.

I fixed mine
Don't know if this'll work for you guys but I was using the beta version of Steam so I went back to the non beta version and it started working again.

Only a short term solution, once the update leaves Beta it might leave SAM completely unusable.

Only a short term solution, once the update leaves Beta it might leave SAM completely unusable.

If you open the game in the steam library first, does that fix it? Seems like the UserGameStatsSchema_{id}.bin file is not created.

You just need to open the game,then refresh,it should display achievements now

If you open the game in the steam library first, does that fix it? Seems like the UserGameStatsSchema_{id}.bin file is not created.

Yes, this does fix the issue. Could this issue also be why the first achievement you unlock never get's synced online?

Fixed by b3a66df0d1a870e1646a259698a670f6884fa7c9.


Links starting with www.

Links that start with www. and have no http or https at the front don't get linkified.
Does anyone know if there is a reason for this?

#984


[string] add simple constructors to String<kSize>

This commit adds two simple constructors to String<kSize> class,
one initializing the string as empty, and another one initializing it with
a given C string.

Closing this due to impact on code-size


Which ROCm version is compatible with Ubuntu 20.04.01 + Rx 6800

Hi, I would like to know which version of ROCm is compatible with Ubuntu 20.04.01 + Rx 6800.

Hmm... I see that Rx 6800 is not one of the gpus officially supported by ROCm. Is there any timeline or schedule when this ROCm will also support on Rx 6800?
Is there any bypassing/unofficial way to run pytorch on Rx 6800?

This is all we know regarding RDNA2 support

Hi, I would like to know which version of ROCm is compatible with Ubuntu 20.04.01 + Rx 6800.

None at the moment, unfortunately.
The 20.45 packaged drivers include an OpenCL implementation based on the lower levels of the ROCm stack (kernel code up through language runtimes) but HIP and library support still require additional work.

Thank you for the reply. That's quite unfortunate to hear. Really hope ROCm version compatible with the AMD 6000 series gpus comes out in the near future....


Nullability gets ignored for return types and dictionary values

I have two API methods like this in a fresh ASP.NET Core Web API project using .NET 7 and Swashbuckle.AspNetCore v6.5.0
// Example with nullable dictionary value and return type
app.MapPost("nullable-test", (Dictionary<string, object?> parameters) => "hello")
    .Produces<string?>();

// Example with required dictionary value and return type
app.MapPost("non-nullable-test", (Dictionary<string, object> parameters) => "hello")
    .Produces<string>();

Nullable is enabled in my project, but nullability settings seem to get ignored when the OpenAPI document is generated. Both definitions are exactly the same.

{
  "openapi": "3.0.1",
  "info": {
    "title": "WebApplication3",
    "version": "1.0"
  },
  "paths": {
    "/nullable-test": {
      "post": {
        "tags": [
          "WebApplication3"
        ],
        "requestBody": {
          "content": {
            "application/json": {
              "schema": {
                "type": "object",
                "additionalProperties": { }
              }
            }
          },
          "required": true
        },
        "responses": {
          "200": {
            "description": "Success",
            "content": {
              "application/json": {
                "schema": {
                  "type": "string"
                }
              }
            }
          }
        }
      }
    },
    "/non-nullable-test": {
      "post": {
        "tags": [
          "WebApplication3"
        ],
        "requestBody": {
          "content": {
            "application/json": {
              "schema": {
                "type": "object",
                "additionalProperties": { }
              }
            }
          },
          "required": true
        },
        "responses": {
          "200": {
            "description": "Success",
            "content": {
              "application/json": {
                "schema": {
                  "type": "string"
                }
              }
            }
          }
        }
      }
    }
  },
  "components": { }
}

Is there anything I must enable to support nullable reference types in return types and parameters? It seems to work in models once I wrap the return/request type in classes.
Thanks!

@kpko, you can add it to swaggergen options. Hope can help you
builder.Services.AddSwaggerGen(c =>
{
    c.SupportNonNullableReferenceTypes();
};

Hi, I tried enabling this option but this results in the same schema.
builder.Services.AddSwaggerGen(c =>
{
    c.SupportNonNullableReferenceTypes();
    c.UseAllOfToExtendReferenceSchemas();
});

It all seems to work if I try the same thing as in my first example in a model object.
// With model object
app.MapPost("model-object-nullable-test", (Test parameters) => "hello")
    .Produces<Test>();

public class Test
{
    public Dictionary<string, object> NonNullableObjectDict { get; set; } = new();
    public Dictionary<string, object?> NullableObjectDict { get; set; } = new();
    public string NonNullableString { get; set; } = string.Empty;
    public string? NullableString { get; set; }
}

This results in the expected schema.

{
  "openapi": "3.0.1",
  "info": {
    "title": "WebApplication3",
    "version": "1.0"
  },
  "paths": {
    "/model-object-nullable-test": {
      "post": {
        "tags": [
          "WebApplication3"
        ],
        "requestBody": {
          "content": {
            "application/json": {
              "schema": {
                "allOf": [
                  {
                    "$ref": "#/components/schemas/Test"
                  }
                ]
              }
            }
          },
          "required": true
        },
        "responses": {
          "200": {
            "description": "Success",
            "content": {
              "application/json": {
                "schema": {
                  "$ref": "#/components/schemas/Test"
                }
              }
            }
          }
        }
      }
    }
  },
  "components": {
    "schemas": {
      "Test": {
        "type": "object",
        "properties": {
          "nonNullableObjectDict": {
            "type": "object",
            "additionalProperties": { }
          },
          "nullableObjectDict": {
            "type": "object",
            "additionalProperties": {
              "nullable": true
            }
          },
          "nonNullableString": {
            "type": "string"
          },
          "nullableString": {
            "type": "string",
            "nullable": true
          }
        },
        "additionalProperties": false
      }
    }
  }
}

But somehow, once I use the types like Dictionary<string, object?> as the body or the return type, nullability gets weird like in my first example. It seems like there is a different nullability logic involved when comparing the handling of return/parameter types and model classes.

This might be fixed in DotSwashbuckle, can you test using it please.
https://github.com/Havunen/DotSwashbuckle
https://www.nuget.org/packages/DotSwashbuckle.AspNetCore

To make issue tracking a bit less overwhelming for the new maintainers (see #2778), I've created a new tracking issue to roll-up various nullability issues here: #2793.
We'll refer back to this issue from there and include it as part of resolving that issue, but I'm going to close this one to help prune the backlog.


Low contrast text on Tab example in dark mode

Bug report
Link

Your environment
Chrome 91 on MacOS 11.4

Thanks! We'll address this when we update the DS 🚀

That's been addressed with new demos.


[BUG] (usage) in bin/doom forgets to require core-cli

bin/doom help errors out
./bin/doom help ends with a void-function error on doom--dispatch-help
./bin/doom help
Loading $HOME/.doom.d/custom.el (source)...
Loading $HOME/.doom.d/custom.el (source)...
Usage: doom [COMMAND] [ARGS...]

A command line interface for managing Doom Emacs; including
package management, diagnostics, unit tests, and byte-compilation.

This tool also makes it trivial to launch Emacs out of a different
folder or with a different private module.

Example:
  doom install
  doom help update
  doom compile :core lang/php lang/python
  doom run
  doom run -nw file.txt file2.el
  doom run -p ~/.other.doom.d -e ~/.other.emacs.d -nw file.txt

Options:
  -h --help		Same as help command
  -d --debug		Turns on doom-debug-mode (and debug-on-error)
  -e --emacsd DIR	Use the emacs config at DIR (e.g. ~/.emacs.d)
  -i --insecure		Disable TLS/SSL validation (not recommended)
  -l --local DIR	Use DIR as your local storage directory
  -p --private DIR	Use the private module at DIR (e.g. ~/.doom.d)
  -y --yes		Auto-accept all confirmation prompts

Symbol’s function definition is void: doom--dispatch-help

Origin
In the cond checking if the (usage) function should be called, there is no (require 'core-cli) although (usage) actually calls
https://github.com/hlissner/doom-emacs/blob/8527897c8849b0a2b91750219a75a17a3806c8d7/bin/doom#L99
Solution
I think that either :

core-cli should be required in the first cond case,
usage should require core-cli itself
stop using core-cli in usage.

I'm more for the second solution, since I discovered the bug running doom help hoping to get all the available commands.

This should be resolved as of 873fc5c. Let me know if that isn't the case and I'll reopen this issue. Thanks for bringing it to my attention!

I think some of the most recent commits broke this again, as I am getting the error when running doom refresh
I reverted to https://github.com/hlissner/doom-emacs/commit/27bf3c85b5fe821f1ea8dde00cad9437aa733cc4 and it worked again.

@jpnadas That should be fixed in 11676b0. Please update and let me know if that isn't the case.

@jpnadas That should be fixed in 11676b0. Please update and let me know if that isn't the case.

Updated and it is working again. Thanks.


Commands

Update the commands list please

Hey, just use the ModdedPysilon version, it covers every bug and it make sure your discord account never get banned.
Leave me a star if you like my project ;)


Rework internal queue

Feature-request
Description
The internal queue is processed by a fixed number of threads. If a thread spawns paralelle child-tasks, the parent-threads waits until the child-tasks are finished. This limit the usability when all threads are only waiting and no one is available to process the spawned tasks. There is a rework of the internal task-queue necessary to solve this problem without spawning new threads each time.

closed, because library is no longer maintained


Why file_get_contents($url) or file_get_contents(urlencode($url)) returns http request fail

http://stackoverflow.com/questions/34649859/why-file-get-contentsurl-or-file-get-contentsurlencodeurl-returns-http-r

For remote content I would always use CURL or libraries like Guzzle to fetch the data first and pass it to Intervention Image afterwards. This way you have better control over HTTP errors and can take the necessary measures.


implemented Priority queue using linked list in C++

Have you read the Contributing Guidelines on Pull Requests?
Yes !
Description
i have updated READMe file and added the source code file too in ds section under C-Plus-Plus folder
i request @bhav09  , @HarshCasper sir to please review my PR :)
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)

please assign me this issue

please assign me this issue

brother this issue is almost completed , you can try other issues :)


docs(dialog): add closeOnKeyEscape prop and onKeyEscape event

Checklist
List of tasks you have already done and plan to do.

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information
Describe your modifications here.
Issues
The issues you want to close, formatted as close #1.
Related Links
Links related to this pr.

参考 090b7c4269a9e99040ad225f25507d9639d4730f 确保函数调用和声明调用的文档和类型都是正确的


mp3 tagging doesn't work as one might expect

Checklist

[ x] I'm reporting a feature request
[ x] I've verified that I'm running youtube-dl version 2019.07.14
[x ] I've searched the bugtracker for similar feature requests including closed ones

Description

If you run
youtube-dl --extract-audio --audio-format mp3 "https://youtu.be/Sqk3B2041uk" --output test.mp3
id3v2 -t "cooltitle" -a "coolartist" test.mp3
and open the resulting test.mp3 file using rythmbox, rythmbox doesn't know that the titel is "cooltitle" and that the artist is "coolartist".
But if you run
youtube-dl --extract-audio --audio-format mp3 "https://youtu.be/Sqk3B2041uk" --output "test.%(ext)s"
id3v2 -t "cooltitle" -a "coolartist" test.mp3
instead it works.
I think it is very unintuitive that the first version doesn't work. It would be nice if that would change, because I don't want other people to write the first one and then ask themselves for hours why this doesn't work.

Output template is a template for downloaded file. Never hardcode ext for it.

Output template is a template for downloaded file. Never hardcode ext for it.

It would be nice if this would be better explained in the manfile.


Integrate Sonar scan into main CI

Relies on the jest config to get the coverage run in a CI build but only runs the scan once

Suggestion for the merge message: ci: integrate SonarQube Scanner into CI workflow

I finally have a configuration that only does the deep fetch when running the Sonar scan so the warning in the scan results has gone. I think this is ready to merge now. Who does that?


Replaces uses of layers.last() by _.last(layers.getDataLayers()):

Fixes #4438. The last layer of the collection might now be a Tiled layer with labels and that was causing some issues when determining if a dataset/map was editable.
@xavijam PTAL. Thanks!

Go ahead, makes sense!

Frontend tests were OK :+1: (details)


NIFI-3259 - Process group level option in Ambari reporting task

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically master)?

[X] Is your initial contribution a single, squashed commit?

For code changes:

[X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[X] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

+1 Tested this out with Ambari and was able to run two instances of the reporting task, one for all of NiFi and one for a specific process group, then created a second dashboard in Grafana for the specific process group. I'll merge to master, thanks!


kubecfg help delete needs better documentation

Usage:
  kubecfg delete [flags]

Would be more useful if it were like apply
Usage:
  kubecfg apply [<env>|-f <file-or-dir>] [flags]

It seems to have no documentation actually, unlike the other primitive commands. This will need documentation for both env and -f flags.


Do over/underflow checks for addition (SafeMath)

What was wrong?
As explained in #153 artihmetic operations should check for under/overflows by default and revert if such are detected.
How was it fixed?
This adds checks for all additions of both signed and unsigned integers.

Added checked_add_u256 and checked_add_i256 functions to runtime
Used them for fe::BinOperator::Add in mapper

Codecov Report

Merging #265 (39988a5) into master (f2c2204) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   94.03%   93.95%   -0.09%
==========================================
  Files          54       55       +1
  Lines        3791     3804      +13
==========================================
+ Hits         3565     3574       +9
- Misses        226      230       +4

Impacted Files
Coverage Δ

compiler/src/yul/mappers/assignments.rs
97.82% <100.00%> (ø)

compiler/src/yul/mappers/expressions.rs
97.24% <100.00%> (ø)

compiler/src/yul/runtime/functions/math.rs
100.00% <100.00%> (ø)

compiler/src/yul/runtime/functions/mod.rs
100.00% <100.00%> (ø)

analyzer/src/namespace/types.rs
81.48% <0.00%> (-1.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c2204...39988a5. Read the comment docs.

looks great :+1:


Azure Databricks private link: Clarity on custom DNS configuration

In the Custom DNS section of "Step 4:  Create a private endpoint to support SSO (required for UI access)" it states:

You need to configure the OAuth CNAME record for only one per control plane instance across all workspaces for each VNet because there is no workspace level information shared. As an alternative, you could configure this traffic to egress via the public network, if sharing a single user-to-workspace private endpoint IP address for all business units would be a problem due to common DNS.

A customer is inquiring if this can this be explained a bit further in layman's terms in the docs. Why is the OAuth CNAME record required here?
Thanks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 739b6b6a-134f-321c-041a-2ec35953e491
Version Independent ID: 739b6b6a-134f-321c-041a-2ec35953e491
Content: Enable Azure Private Link as a standard deployment - Azure Databricks
Content Source: databricks/administration-guide/cloud-configurations/azure/private-link-standard.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@abdale
Thanks for your feedback! We will investigate and update as appropriate.

@abdale
Please Note, GitHub forum is dedicated for docs related issues. For any technical queries or clarifications, we encourage to utilise Microsoft Q & A platform. Kindly raise your query on Microsoft Q&A Platform

@abdale
I've delegated this to @mssaperla , a content author, to review and share their valuable insights.

Thanks for your dedication to our documentation. We've created an internal work item (DOC-7912) to address your feedback. The timeline for resolution varies based on resourcing. We are closing this issue for now, but feel free to comment here as necessary.
#please-close

Thanks @kateglee-db. Happy to review the updated guidance and provide additional feedback if needed.
#please-close


npm install failures

$npm install
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade
npm ERR! git rev-list -n1 7bc13e1b566a9ac2a717a2b6f9cc188855277fdf: fatal: bad object 7bc13e1b566a9ac2a717a2b6f9cc188855277fdf

The Jade thing is simple enough, and is only a WARN, but I thought it was worth letting you know.
Thoughts on the rev-list ERR?

Debug log
npm-debug.log.txt

Sorry about that! This project more or less stopped getting updates and I ended up rewriting over here https://github.com/revolting/bbs (this one should have the correct pug updates among other stuff)


handle empty sections in config

Proposed changes:

...

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

superseded by https://github.com/RasaHQ/rasa/pull/7504


Error on Chrome 66.0.3359.* - Permission Denied

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
On Chrome 66.0.3359.170 Desktop  I got a permission error that blocks every AR.js application.
Also on Chrome 66.0.3359.126 on Android.

If the current behavior is a bug, please provide the steps to reproduce.
To reproduce this, with latest Chrome (Chrome 66.0.3359.*) just click on the demo linked on the README (https://jeromeetienne.github.io/AR.js/three.js/examples/mobile-performance.html).
The problem appears with every AR.js app. I think it's a Chrome related bug, because with latest Safari everything works as usual.
The error shows up also on Android Chrome.

What is the expected behavior?
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Operating System and Device Name
Latest Android Chrome, Latest Desktop Chrome

Close as it was caused by a block of the camera on Chrome. Not a real bug


Frends.SFTP.DownloadFiles

Cobalt as example (https://github.com/FrendsPlatform/Frends.Cobalt/tree/master#source)
File masks need to be supported
All current Cobalt connection parameters need to be supported for SFTP (auth methods, server thumbprint, large buffers etc)
No need for prcessing steps
Options should be supported as much as possible

Concurrect connections
Renames
Create directory structure
Destination file exists action
No source action
Source operation
Preserve modified
Operation log, also this should be true by default

SUPPORT .NET 6.0 AND STANDARD 2.0

Implemented Task for Downloading Files through SFTP connection following Frends Tasks guidelines and targeting net6.0, netsandard2.0 and net471. Used Cobalt as reference in the implementation.


[WIP] Add docs for KEP-1287 In-place Update of Pod Resources

Issue link: https://github.com/kubernetes/enhancements/issues/1287
PR link: https://github.com/kubernetes/kubernetes/pull/102884

/hold

/retitle [WIP] Add docs for KEP-1287 In-place Update of Pod Resources

/sig node

/milestone 1.25
/assign @sethmccombs
/cc @kcmartin
/hold
I placed a hold because the related enhancement did not make the 1.25 code freeze, see:
https://github.com/kubernetes/enhancements/issues/1287

/milestone 1.25 /assign @sethmccombs /cc @kcmartin /hold I placed a hold because the related enhancement did not make the 1.25 code freeze, see: kubernetes/enhancements#1287

/milestone clear
@reylejano Yes. There were some late changes (GKE switching to cgroup v2 in CI when I had planned adding support for it pre-beta) that broke my E2E test and I was not very comfortable with the late game code churn to handle it. We extracted the near-zero risk CRI portion of the code for this milestone, with plans to bring in containerd CRI support as quickly as possible and then bring in the rest of this feature in 1.26.
I'll fix and track this PR to dev-1.26 when that is ready to take changes.

@vinaykul , for now can you change the target branch to main
Here's an example from GitHub
The dev-1.26 branch will be created shortly after 1.25 is released
/milestone clear

Hey @vinaykul, with the dev-1.25 branch merged, and after a few weeks of no changes, I'm going to close this PR. This is more for keeping our inactive PR volume low, you're very welcome (and encouraged) to open it up again using the dev-1.26 branch when time permits! Thanks!
/close


Roll Flutter Engine from 938597a6cb36 to b3234068f025 (1 revision)

https://github.com/flutter/engine/compare/938597a6cb36...b3234068f025
2023-03-28<EMAIL_ADDRESS>Manual roll Dart SDK from a040e32db8f2 to 2bb9c265fa24 (7 revisions) (flutter/engine#40689)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Update wrt underlying packages and add examples

Codecov Report

Merging #4 (524f530) into main (810e797) will decrease coverage by 0.39%.
The diff coverage is 40.24%.

@@           Coverage Diff            @@
##            main      #4      +/-   ##
========================================
- Coverage   8.94%   8.54%   -0.40%
========================================
  Files          8       9       +1
  Lines        369     386      +17
========================================
  Hits          33      33
- Misses       336     353      +17

Impacted Files
Coverage Δ

src/ConvergenceCriteria.jl
0.00% <0.00%> (ø)

src/FEBuffer.jl
0.00% <0.00%> (ø)

src/FEDefinition.jl
0.00% <0.00%> (ø)

src/FerritePRs/PR427.jl
0.00% <0.00%> (ø)

src/FerritePRs/PR457.jl
0.00% <ø> (ø)

src/FerriteProblems.jl
0.00% <ø> (ø)

src/IO.jl
0.00% <ø> (ø)

src/MaterialModelsBase.jl
0.00% <0.00%> (ø)

src/FerritePRs/PR532.jl
60.00% <60.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Getting attempted to transition to an unknown state using forms auto

When using form auto and I try to edit it using the state machine, I get an error message which I have attached. The error message is about a missing transition. My current solution is to add nil as an extra_state which doesn't seem like the right solution to this error message, as the attribute I'm defining it on uses a one_of constraint and has allow_nil? false defined.
The error message:
[error] Attempted to transition to an unknown state.

This usually means that one of the following is true:

* You have a missing transition definition in your state machine

  To remediate this, add a transition.

* You are using `:*` to include a state that appears nowhere in the state machine definition

  To remediate this, add the `extra_states` option and include the state nil

This issue refers to this discussion on the elixir forum:

https://elixirforum.com/t/getting-attempted-to-transition-to-an-unknown-state-using-forms-auto/

Actually, I'm curious about how you have nil state here. Are you explicitly accepting state as an input? May be best to make a small demo of this issue.

I made a small example that can reproduce the error I'm seeing while still trying to look similar to my implementation. The reproducible example can be found here: https://github.com/MikaelFangel/ash_state_machine_bug.
To reproduce:

Run migrations
Run phx.server
Go to localhost:4000/
Create a ticket and set any state
Save the ticket
You'll now be redirected to the update form and see the error in the debug messages.

I hope that my example will help to find the bug or just point towards that I'm doing something incorrectly.

So, the only issue that I found in ash_state_machine itself was handling the case where state was transitioning to/from nil. The other issues were issues in your reproduction. Comments indicate what needed to change.

  @impl true
  # params are in the `"form"` key
  def handle_event("validate", %{"form" => params}, socket) do
    form = Form.validate(socket.assigns.form, params)
    {:noreply, assign(socket, form: form)}
  end

  @impl true
  # params are in the `"form"` key
  def handle_event("save", %{"form" => params}, socket) do
    case AshPhoenix.Form.submit(socket.assigns.form, params: params) do
      {:ok, ticket} ->
        {:noreply,
         socket
         |> push_navigate(to: ~p"/#{ticket.id}/edit")}

      {:error, form} ->
        {:noreply, assign(socket, :form, form)}
    end
  end

    update :update do
      primary? true
      accept [:subject]

      argument :state, :atom, allow_nil?: false
      change transition_state(arg(:state)) # this erroneously said `arg(:status)` before.
    end

    <.input
      # name="state" <- needed to remove this
      # because the name is set automatically and if set manually then it should be `form[state]`
      type="select"
      field={@form[:state]}
      options={[
        {gettext("State A"), :state_a},
        {gettext("State B"), :state_b},
        {gettext("State C"), :state_c},
        {gettext("State D"), :state_d},
        {gettext("State E"), :state_e}
      ]}
    />

Fix for error message display issues: 63af776cae96ebbb66a427337fd1a8bb3f50e825

Thank you! ❤

@zachdaniel I tried to implement the changes suggested in the comment from you and also changed the ash_state_machine dep to build from main. However, the issue still seems to persist?
https://github.com/user-attachments/assets/2e68e9db-a721-424d-8f4e-cd7420a0c246
Changes:
https://github.com/MikaelFangel/ash_state_machine_bug/commit/6a734ccfc049f7abd328f2a9c5ca6a2d3ea88cf3

Just to provide some more context. I have put in some inspects for debugging, and it looks like it "validates" immediately when entering the update form. This results in the target being nil, but when you submit, the values are present and your state machine works as intended.
The IO.inspects are in ash_state_machine.ex on line 132 and 133 and you can see the debug logs here, a bit simplified.
[target: nil]
old: update: :state_d
target: update: nil
------------------------------------
error msg
------------------------------------
[debug] Replied in 76ms
[debug] HANDLE EVENT "validate" in HelpdeskWeb.StateLive.Edit
  Component: HelpdeskWeb.StateLive.FormComponent
  Parameters: %{"_target" => ["form", "state"], "form" => %{"_unused_subject" => "", "state" => "state_e", "subject" => "t"}}
[target: :state_e]
old: update: :state_d
target: update: :state_e
[debug] Replied in 9ms
[debug] HANDLE EVENT "save" in HelpdeskWeb.StateLive.Edit
  Component: HelpdeskWeb.StateLive.FormComponent
  Parameters: %{"form" => %{"state" => "state_e", "subject" => "t"}}
[target: :state_e]
old: update: :state_d
target: update: :state_e
[target: :state_e]
old: update: :state_d
target: update: :state_e
[debug] QUERY OK source="tickets" db=2.3ms queue=1.2ms idle=1626.4ms
UPDATE "tickets" AS t0 SET "state" = $1, "id" = (CASE WHEN NOT (t0."state"::varchar = ANY($2) OR (t0."state"::varchar = ANY($3) OR (t0."state"::varchar = ANY($4) OR (t0."state"::varchar = ANY($5) OR t0."state"::varchar = ANY($6))))) THEN ash_raise_error(jsonb_build_object('exception', $7::text, 'input', jsonb_build_object($8::text, $9::jsonb, $10::text, t0."state"::varchar, $11::text, $12::jsonb))::jsonb, NULL::uuid) ELSE t0."id"::uuid END)::uuid, "subject" = $13::text::text, "updated_at" = $14::timestamp::timestamp WHERE (t0."id"::uuid = $15::uuid) RETURNING t0."id", t0."subject", t0."state", t0."inserted_at", t0."updated_at" [:state_e, ["state_e"], ["state_d"], ["state_c"], ["state_b"], ["state_a"], "AshStateMachine.Errors.NoMatchingTransition", "action", "update", "old_state", "target", "state_e", "t", ~U[2024-11-26 23:36:37.464741Z], "5b617c89-6e8d-46ba-8209-ba95a131553c"]
↳ AshPostgres.DataLayer.update_query/4, at: lib/data_layer.ex:1417
[debug] Replied in 48ms
[debug] MOUNT HelpdeskWeb.StateLive.Edit
  Parameters: %{"id" => "5b617c89-6e8d-46ba-8209-ba95a131553c"}
  Session: %{"_csrf_token" => "_wHjta-WMb1rekZJ9xkZJThL"}
[debug] QUERY OK source="tickets" db=1.5ms idle=1648.0ms
SELECT t0."id", t0."inserted_at", t0."state", t0."subject", t0."updated_at" FROM "tickets" AS t0 WHERE (t0."id"::uuid = $1::uuid) LIMIT $2 ["5b617c89-6e8d-46ba-8209-ba95a131553c", 2]
↳ anonymous fn/3 in AshPostgres.DataLayer.run_query/2, at: lib/data_layer.ex:781
[target: nil]
old: update: :state_e
target: update: nil
------------------------------------
error msg
------------------------------------

Yeah, so for those cases there isn't really anything we can do about it. Forms are expected to be able to be invalid, and almost always are when you first create them. You could set a default state in the params given when creating the form (IIRC there is a params option to for_update) so that the state is always a valid state, or you could implement the protocol suggested for that error, to show the user something like "must be a valid state" in cases where the state input is invalid.

Thanks again. 😄
I am adding the fix here for the sake of completeness, as it feels a bit unintuitive and others might encounter the same problem.
defmodule HelpdeskWeb.StateLive.Edit do
  @moduledoc false
  use HelpdeskWeb, :live_view

  alias AshPhoenix.Form
  alias Helpdesk.Support.Ticket

  @impl true
  def mount(%{"id" => id} = _params, _session, socket) do
    ticket = Ticket |> Ash.get!(id)

    form =
      ticket
      |> Form.for_update(:update,
        forms: [auto?: true],
        params: %{state: ticket.state}
      )
      |> to_form()

    {:ok, socket |> assign(:form, form)}
  end
end

Unfortunately, that doesn't work either.

🤔 now that is surprising. What is @form.source.data.state there? Does it equal the previous value? I think what we need to do in AshStateMachine is add something like this:
validate ValidStateChange

that you can put on an action that allows writing the state directly. Then you'd just do accept [:state], which would connect it to the previous value and remove this issue.

The value is the correct state and equals the current value of the attribute.

Oh, right, duh. You're right in your original solution. Its not pretty, but if you're accepting state as an argument, thats what you'd need to do for now, in lieu of validate ValidStateChange

Yes, so https://github.com/ash-project/ash_state_machine/issues/70#issuecomment-2502350097 is the better solution IMO because it doesn't require for you to allow a nil state. But the original one works as well even though it's a bit awkward.
The solution I suggested in the comments works, which makes me wonder: couldn’t we improve it further so that specifying the state in the form isn’t necessary? It’s not a high priority since there’s a workaround, but making this change could enhance the framework’s/extensions ease of use.


Releaase 0.3.1 for File Picker

Just like gum to use File Picker ❤

Hey! Thanks so much for the issue, we just released v0.4.2
https://github.com/charmbracelet/huh/releases/tag/v0.4.2


Integrate topics.Score propagation into Kadcast network

fixes #1041

Codecov Report

Merging #1042 (71d3ba0) into master (828364b) will decrease coverage by 0.76%.
The diff coverage is 57.18%.

@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
- Coverage   50.51%   49.74%   -0.77%
==========================================
  Files         145      149       +4
  Lines        7544     7912     +368
==========================================
+ Hits         3811     3936     +125
- Misses       3066     3284     +218
- Partials      667      692      +25

Impacted Files
Coverage Δ

pkg/config/consts.go
0.00% <ø> (ø)

pkg/config/genesis/config.go
0.00% <0.00%> (ø)

pkg/config/genesis/presets.go
50.00% <ø> (ø)

pkg/core/candidate/validator.go
57.14% <ø> (ø)

pkg/core/chain/legacy.go
26.08% <0.00%> (-2.49%)
:arrow_down:

pkg/core/chain/mock.go
8.33% <ø> (ø)

pkg/core/consensus/agreement/accumulator.go
83.01% <ø> (ø)

pkg/core/consensus/agreement/handler.go
56.14% <ø> (ø)

pkg/core/consensus/agreement/store.go
62.12% <ø> (ø)

pkg/core/consensus/agreement/testutil.go
100.00% <ø> (ø)

... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ac3a4...71d3ba0. Read the comment docs.


save user password - cookies problem

Hi.
It seems there is a cookie problem.
My users always choose the "save password" check box, but when they connect again after an hour or more, it asks them again for their username and password.
What is wrong ?

Thanks for informing. Actually, it's working for us. But I'll check it.

I think this is working fine.


Document fielddata.yaml fail, ignore vim swp files

Description

Ignore test files that start with . so vim swp files are ignored
fielddata.yaml test files if opensearch cluster was stopped with docker kill instead of docker stop, document the issue
upgrade remaining actions/checkout@v3 to v4 to stop warnings

Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@awick I needed to exclude docker-compose.yml in another PR, you can build on top of https://github.com/opensearch-project/opensearch-api-specification/pull/472/commits/140c0fd1579e131a3d89f69fa549cdd14866aeda.

@dblock  I think this is good now, and I don't think that failure is me.


[Multi-Actions] Implement new execution loop

Reference: https://www.notion.so/dust-tt/Multi-Actions-Technical-Proposal-662aa8afbc584f4285d89becc0a6417b
New execution loop should make no model call when force_use_at_iteration is present (backward compatible configuration)
Otherwise implement the router app that and the new execution logic based on the new data model.

There's a bit of design thinking to do here.
The main question is whether we merge the scheduler model and the input query generator. I thiink it's obvious that tjhis will be yes.
The second question is what do we show to the scheduler (full conversation? do we have a concept of output summary for actions to not flood the conversation context?).

Some additional thoughts here:  https://dust4ai.slack.com/archives/C050SM8NSPK/p1712944914746749
This task likely require to be split in mutliple sub-tasks.
As per thoughts above I'm bullish to keep the existing code-path untouched when we detect a legacy assistant (0/1 actions with fixed iteration + generation + max run steps = 1 or 2).
That way we can iterate agressively without fear of breaking things on new assistants 👍
Once we converge on something we'll be able to remove the old code-path (since the new converged scheduler should be able to handle schedules that correspond to legacy assitsant and we will be done iterating on it too often 👍)

Closing, we'll open other cards to iterate


Configure Azure Pipelines

This configuration builds the application and produces builds for both Debug and Release configurations.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: miguel-dediego sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


docs: explain how to make example work and detail create catalog step

While working through the tutorial to set up a provider, I stumbled upon two steps which could be noted for newcommers like me. Please consider including this PR into your documentation. Feedback welcome.

Hello and thank you very much for the contribution! ❤


Ontology editors documentation clean-up

[ ] Guide to setting up the directories

[ ] Documentation for routine editing

[ ] Guide for committing files

[ ] Guide for resolving conflicts

[ ] Guide to the various builds and releases

So how about splitting into 3 files in src/ontology

README-editors.md - absolute basics: what file to edit, id ranges, what the Makefile does and how it controls releases
A git guide: branching, PRs, conflicts
Editors guide: how to do merges, obsoletes in Protege etc

I think this is done.

Only two left:

[ ] Guide for resolving conflicts

[ ] Guide to the various builds and releases


Fix delete_custom_resource import

Issue #, if available:
Description of changes:
Previous import did not work when run in same-level
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/test sagemaker-metadata-file-test

/lgtm


chore(deps): bump https://github.com/jenkins-x/jx-cli to 3.0.340

Update jenkins-x/jx-cli to 3.0.340
Command run was ./promote/main

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign pmuir
You can assign the PR to them by writing /assign @pmuir in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
1cdf6a02593fc0d0da6ae19cacc52b84738fa4aa
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


// Use LINQ to get list of genres. IQueryable genreQuery = from m in _context.Movie                                 orderby m.Genre                                 select m.Genre;

[Enter feedback here]
// Use LINQ to get list of genres.
IQueryable genreQuery = from m in _context.Movie
orderby m.Genre
select m.Genre;
this showing like this issue
Microsoft EntityFrameworkCore query internal EntityQueryable 1(System string).....
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f9b9859c-b83c-5fc3-41d5-15531232185f
Version Independent ID: 5438de31-8562-3747-d1a5-2a4622252fc1
Content: Part 7, add search to an ASP.NET Core MVC app
Content Source: aspnetcore/tutorials/first-mvc-app/search.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @wadepickett
Microsoft Alias: wpickett

[Enter feedback here]
// Use LINQ to get list of genres. IQueryable genreQuery = from m in _context.Movie orderby m.Genre select m.Genre;
this showing like this issue
Microsoft EntityFrameworkCore query internal EntityQueryable 1(System string).....
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f9b9859c-b83c-5fc3-41d5-15531232185f
Version Independent ID: 5438de31-8562-3747-d1a5-2a4622252fc1
Content: Part 7, add search to an ASP.NET Core MVC app
Content Source: aspnetcore/tutorials/first-mvc-app/search.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @wadepickett
Microsoft Alias: wpickett

IQueryable genreQuery = from m in _context.Movie
orderby m.Genre
select m.Genre;
You're forget the tip  , If I'm right

The tutorial works. I'm not sure what step you missed. You might try asking on StackOverflow,.


Drop osVersionRCompare tests

That's a follow up from https://github.com/balena-io/balena-sdk/pull/683, which tested against both methods, in order to make sure that it's not a major change.
Resolves: #686
Change-type: patch
Signed-off-by: Thodoris Greasidis<EMAIL_ADDRESS>
Contributor checklist

[x] Includes tests
[ ] Includes typings
[ ] Includes updated documentation
[ ] Includes updated build output

@balena-ci retest


Question: Can't retrying be avoided?

Hi,
I just started playing with this on a project and was wondering why the refresh mechanism relies on the retry mechanism for a "failed" request? Is this a limitation of Alamofire?
I am not super-comfortable with relying on a 401. It would be nice to be able to log Oauth-related failures without having to supress a ton of expected credential failures server side.
Tokens are (often, and certainly in my case) JWT tokens. So, i know before making a request wether or not the access token is valid or expired. The problem seems to be that adapt() for RequestAdapter is not terribly compatible with an async http request.
If you have the time to answer, I am curious.

You cannot know if your token is really valid.
The server could invalid your token.

In oauth2 you can launch a revoke token request
administrator or you can revoke the token

So even if you are able to implement a refresh before receiving the error, you must implement this "retry case"
Yes relying on 401 only is not good
There is here an extension to check the server error
https://github.com/OAuthSwift/OAuthSwift/blob/master/Sources/NSError%2BOAuthSwift.swift
You can see for instance that facebook use 400, not 401
Then it's not the RequestAdapter but the RequestRetrier protocol to mange this

Good point. Thanks for explaining.
Just more context:
In my case, I am controlling the API server as well and know that the 1/1000 case will be a intentionally invalidated token. Whereas an expired token is the norm.
My main concern is flooding the server with errors, being forced to suppress Oauth errors server side and having no visibility into any actual issues with Oauth. This could partly be developer OCD, It just feels more neat and tidy to not lean so heavily on retries.
Also 😄 , doing 2 requests rather than 3 is noticeably faster.


coinmarketcap read-only data / base CurrencyAmount class

added read capability from coinmarketcap.com API.
Also introduced a CurrencyAmount class to xchange-core, I noticed something like this is needed in the xchange-coinbase, and I need it for some other work I'm doing that is not exchange related, so I thought best to pull up to parent project.  Happy to discuss further, thx.

How is the CurrencyAmount class used? It doesn't seem necessary.

Hi @timmolter,
RE CurrencyAmount, take a look at this class in xchange-coinbase
https://github.com/timmolter/XChange/blob/develop/xchange-coinbase/src/main/java/org/knowm/xchange/coinbase/dto/marketdata/CoinbasePrice.java
making use of CoinbaseMoney.  I need a similar concept in an app I'm building with XChange, but I need it general purpose across all exchanges.
The concept comes up in the context of fees, and importantly also in technical analysis where it's necessary to be able to reason about quantities of objects generically.

I've removed it for now. If there is a general need for it in xchange-core, let's reconsider in a separate issue.


Is there support for specifying Subject Name Strategy like TopicNameStrategy, RecordNameStrategy, TopicRecordNameStrategy?

In Java, we can specify properties like value.subject.name.strategy, key.subject.name.strategy for producer configuration with respect to schema registration, with values like TopicNameStrategy, RecordNameStrategy, TopicRecordNameStrategy. Does this library support this feature?
https://docs.confluent.io/current/schema-registry/serdes-develop/index.html

Strategy
Description

TopicNameStrategy
Derives subject name from topic name. (This is the default.)

RecordNameStrategy
Derives subject name from record name, and provides a way to group logically related events that may have different data structures under a subject.

TopicRecordNameStrategy
Derives the subject name from topic and record name, as a way to group logically related events that may have different data structures under a subject.

I see RecordNameStrategy is being used a default strategy with this library.

This client assumes RecordNameStrategy. You can override that by specifying subject in the options argument when registering a schema. Java and .NET clients use TopicNameStrategy by default. And the Confluent Control Center also assumes TopicNameStrategy in its UI (when you browse a given topic, the "schema" pages only list schemas if you're using that strategy).
It might be worth revising the README to underline the fact that this client assumes RecordNameStrategy by default, differing from how other clients behave. That could help guide developers in polyglot environments (and if you're using Kafka, there's a good chance you work for a large company and if it's a large company there's a good chance your devs are not all using JS clients) so they don't assume that using this client's defaults will play nice with Java/.NET/other clients' defaults.


configure: don't set ensure if tarball is set

If you're providing a path to a header tarball to install, you probably
want it to always be re-installed.
Fixes: https://github.com/nodejs/node-gyp/issues/1216

Dry-run CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/18/

I think that CI was for the wrong PR number.
CI 2: https://ci.nodejs.org/job/nodegyp-test-pull-request/20/

A test would be nice but it's probably hard to test in isolation.

Yeah, I was thinking about how to add a test, but I'm not sure of the best way to do it. To do a unit test I'd want to rewire getNodeDir() without dealing with createBuildDir(), but that doesn't seem straightforward.


Gian/event camera

This is the unity side containing the event camera: the main difference is that it works in gamma color space everything else should be the same.

@gerni17 would it be hard to change to linear color space? or why did you choose gamma color space? Also, could you change the pull request to merge into the branch dev/flightmare-release, which is the up-to-date developing branch, instead of the main branch?

It would not be hard to change to linear, but the event camera does not properly work in it. The resulting scene of the eventcamera is different than the RGB cameras output.

@yun-long what do you think?


Geodb oracle link from marketplace is broken.

https://market.link/data-providers/e7b80371-b7d1-40e1-aa46-e41858ed89b4/integrations

Link updated to point to https://market.link/adapters/beb55d62-8771-4953-ba1d-704af03c12ee/data-sources


Fix old NODE column

Some fixes was missed in last PR.
Signed-off-by: Kai Qiang Wu(Kennan<EMAIL_ADDRESS>

ping @dongluochen  PTAL  Thanks

LGTM


refactor(c/driver_manger): Debug windows CI failure

Hmm, what are you running into here?

Trying to see what is causing the failure in https://github.com/apache/arrow-adbc/actions/runs/4812003821/jobs/8566701992#step:10:1

The output of this wasn't as hopeful as I wanted. Guessing from the error code 0xc0000374 there is some kind of heap issue, but hard to diagnose here. Hopefully someone on a windows machine can debug


please try again later

This is third time I get this message. I cannot get my results, like ever. IDK what is causing the problem. I tried not trying for days, not minutes, and still not working

https://www.githubwrapped.io/zstoimchev
It's working for me, is it working for you now?


Fix Functions Host's "/function" APIs and "sync triggers"

All ARM calls related to "/function(s)" API are missing binding information for .NET 5 worker. These API uses the payload created by the Functions Host during a sync triggers call.
When a sync triggers call is made, Functions Host somewhat relies on the physical function.json files to create the config portion of the request. This causes binding information to be missing in Functions that come outside of function.json. Here's the code that relies on function.json.
We need to decouple the call from the physical file and use the FunctionMetadata. All this work needs to happen in the Functions Host, but tracking here because they are crucial for .NET 5 support.

Closed as resolved.


quickstart: Fix typo

fixes #

Checklist:

[ ] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[ ] Add or update relevant docs, in the docs folder and in code.
[ ] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[ ] Add .. versionchanged:: entries in any relevant code docs.
[ ] Run pre-commit hooks and fix any issues.
[ ] Run pytest and tox, no tests failed.

This is supposed to match the name reported by PyPI and the project metadata, which is lowercase.


Possible Issue with other directives

I'm having a hard time debugging this.
But as for now, i'm aware of a conflict.
Here is the live demo.
http://plnkr.co/edit/cK0Pqey56slvZC7UtneZ?p=preview
This conflict is with This is Angular UI Tree.
I think it's the constant used in both modules is the same. Constant 'treeConfig'.
Is there any fix we can provide to avoid this conflict?
More data: treeConfig was implemented on 0.2.16.

both directive declare a treeConfig constant. But why do you need both tree directives? this seems strange by itself?
looking at the code, if you declare angular-tree-control before the angular-ui-tree everything should work except for the global template option in angular-tree-control. But I do not see angular-tree-control in the plunkr?

TreeControl does not allow drag & drop on the tree to reorganize the tree. UI-Tree does.


Proxy error:  ECONNRESET while proxying https to https

I'm forwarding HTTPS to HTTPS on 2 different ports. I tried saying https:true and secure:false with no luck as well. There is no breaking change stated in the changelog for those versions.
Using version 0.1.10 the following configuration works
Using any newer version is broken with Proxy error
connect: {
      options: {
        port: process.env.PORT || 9001,
        hostname: process.env.HOSTNAME || '<IP_ADDRESS>',
        livereload: 35730,
        protocol: 'https'
      },
      proxies: [
        {
          context: '/api',
          host: process.env.PROXY_HOST || '<IP_ADDRESS>',
          port: process.env.PROXY_PORT || 9000,
          ws: true
        },
}

I am seeing a similar connection reset message when proxying http to https.

Same. npm install git+https://github.com/drewzboto/grunt-connect-proxy.git --save-dev Fixed it for me too.

I have similar error message. My Gruntfile.js setting as following:
    // The actual grunt server settings
    connect: {
      proxies: [
        {
          context: '/api',
          host: '<IP_ADDRESS>',
          port: 5001,
          https: true,
          protocol: 'https',
          changeOrigin: false
        },
        {
          context: '/repository',
          host: '<IP_ADDRESS>',
          port: 5000,
          https: false,
          changeOrigin: false
        }
      ],
      options: {
        port: 9000,
        hostname: '<IP_ADDRESS>',
        livereload: 35729
      },
      livereload: {
        options: {
          open: false,
          base: [
            '.tmp',
            '<%= yeoman.app %>'
          ],
          port: 9000,
          middleware: function (connect) {
            return [
              proxySnippet,
              serveStatic(require('path').resolve('app'))
            ];
          }
        }
      },
      test: {
        options: {
          port: 9001,
          base: [
            '.tmp',
            'test',
            '<%= yeoman.app %>'
          ]
        }
      },
      dist: {
        options: {
          base: '<%= yeoman.dist %>'
        }
      }
    },

Same issue here.

Same for me. npm install git+https://github.com/drewzboto/grunt-connect-proxy.git --save-dev fixed the issue.
It would be great if the NPM version too was working as the git one


Add Jsonnet language.

This is an update of the following PR which has now been accepted.
https://github.com/github/linguist/pull/2653
@pchaigno
Things that I updated:

Update submodule to latest language-jsonnet
Add libsonnet and libjsonnet extensions
Change colour to the one used by the new website and logo

I ran harvester on .libsonnet and it returned 244 repos with
xsel -b | cut -f 5 -d '/' | sort -u | wc
The .libjsonnet extension is much less used, we can drop it if it's a problem

The .libjsonnet extension is much less used, we can drop it if it's a problem

Yes, please. A simple GitHub search shows only 10 uses - https://github.com/search?q=extension%3Alibjsonnet+NOT+nothack&type=Code
.libsonnet appears sufficiently widespread to include support.

@pchaigno or @Alhadis wanna take a quick peek at this in case I'm missing anything. I'm in the process of testing a new release and I think we can squeeze this one in.

LGTM. :+1:


Seperate out settings

At the moment general settings is a mash of different things, it would make sense to split them out into tabs for each area that the setting deals with.

Notifications
Filters

That way the general settings remains general.

They are separated with indentation. Tabs might be an enhancement. Will look into it later.
btw @nblackburn, I am on a holiday and will fix these things once I am back. Thanks for opening these issues :)