Run a single example

I'm trying to create a useful NUnit wrapper for NSpec. I have created an NUnit TestDataSource that discovers all NSpec examples and generates NUnit test cases on the fly. That part works.
However, I cannot run the examples during the discovery phase, because things like setup fixtures haven't run at that point. So in the actual "example realization" method, I want to run a single example.
My current approach involves wrapping the context of the example in a ContextCollection, but the problem is that the Context contains all examples, so I observe the same example being run multiple times.
Unsuccessful attempts so far:

Tweak each example by giving it a GUID tag, and then creating a tag filter with that GUID.
Setting HasRun on each example so that only the one about to run has true.

I will post some code later, but perhaps you have some idea right away?

I'm trying to create a useful NUnit wrapper for NSpec.

I think @BrainCrumbz is working on a wrapper.
That being said, here is how NSpec executes specifications:
//types that should be considered for testing
var types = Assembly.GetExecutingAssembly().GetTypes();

//now that we have our types, set up a finder so that NSpec
//can determine the inheritance hierarchy
var finder = new SpecFinder(types);

//we've got our inheritance hierarchy,
//now we can build our test tree using default conventions
var builder = new ContextBuilder(finder, new DefaultConventions());

//create the nspec runner with a
//live formatter so we get console output
var runner = new ContextRunner(
	     builder,
	     new ConsoleFormatter(),
	     false);

//create our final collection of concrete tests
var testCollection = builder.Contexts().Build();

//run the tests and get results (to do whatever you want with)
var results = runner.Run(testCollection);

//console write line to pause the exe
System.Console.ReadLine();

You could delete entries from the collection before var results = runner.Run(testCollection);.
Thoughts?

We created a Visual Studio Test Adapter for NSpec, NSpec.VsAdapter, so that a developer can list, group, select and launch NSpec specs directly from within Visual Studio. Here's a (tiny) screenshot, but generally people used to Visual Studio know how that works.
Actually, I did not get what should be a NUnit wrapper for NSpec.

Sorry for the delay. I just sat down to create a GitHub repo to illustrate the problem, but I got momentarily stuck at some changes between NUnit 2 and 3.
Anyway, my use case is that I have a project with around 10000 NUnit tests. Changing those to NSpec isn't feasible, but I'd like to start using NSpec here and there because I like it. My two requirements are:

It should be possible to run NSpec examples using ReSharper.
The NSpec examples should be included when the test suite is run using the NUnit console runner.

To accomplish that, I started from DebuggerShim and created a base class that uses a NUnit TestCaseSource method to generate one NUnit test case for each discovered NSpec example.
My first version ran the exampes (like DebuggerShim does) from inside the TestCaseSource method, but it's a bad idea since that method is called too early in NUnit's life cycle - before important setup fixtures have run.
Thus, I split discovery and running of example-derived test cases. It almost works, but because ContextRunner runs a ContextCollection I have to give it the context of the example. But that context refers to all its examples, so the effect is that all examples will run as part of the first test case.
I'll get back with a repo that demonstrates the problem more clearly.

Ok, here's a demo repo:
https://github.com/provegard/NSpecInNUnit
(Open with VS2015, enable NuGet package restore.)
When I run the a_spec class using ReSharper, I get three failing tests. They fail because the runner expects each test to run a single example, but the first test runs all three examples, and the subsequent tests run zero examples each.

Can you walk me through how run the repo? I have building in VS 2015, what do I do next?

The point is that I use ReSharper or NUnit console runner. With ReSharper installed, you get an icon next to the test class that you can use to run the class:

But I have updated the repo with a reference to NUnit.Runners, so if you pull and then rebuild to let NuGet install the new package, you can then run the following from the Windows command prompt:
packages\NUnit.ConsoleRunner.3.2.0\tools\nunit3-console.exe NSpecInNUnit\bin\Debug\NSpecInNUnit.dll

Both approaches result in the same thing: Three failing tests.

Perfect, let me give it a shot and see what I find.

Extremely hokey, but I think this worked. We need to make a change in NSpec that completely decouples the builder from the runner.
        [TestCaseSource(nameof(Examples))]
        public void RunExample(ExampleBase example, SpecFinder finder)
        {
            // Unsuccessful attempt to run one example per test:
            // var aTag = Guid.NewGuid().ToString();
            // example.Tags.Add(aTag);
            // ...and then `new Tags().Parse(aTag)` below.

            // A dummy ContextBuilder to get Tags into the ContextRunner
            var builder = new ContextBuilder(finder, new Tags(), new DefaultConventions());
            var runner = new ContextRunner(builder, new NoopFormatter(), false);
            var testSuite = builder.Contexts().Build();

            testSuite.AllContexts().Do(c =>
            {
                c .AllExamples()
                .Where(e => e.FullName() != example.FullName())
                .Do(e =>
                {
                    e.HasRun = true;
                    e.Pending = true;
                });
            });

            runner.Run(testSuite);

            if (example.Failed())
            {
                if (example.Exception != null)
                {
                    // Use ExceptionDispatchInfo to preserve the original stack trace
                    var edi = ExceptionDispatchInfo.Capture(example.Exception);
                    edi.Throw();
                }
                throw new Exception("It failed :-(");
            }
        }
    }

In currently avaliable package version, 1.0.4, ContextRunner still requires a ContextBuilder (code). But since this (unpublished ?) commit that dependency has been removed.

I can push an update of the Nuget package (if I'm reading what you're saying correctly). Do you want to merge in the "fail if async" stuff first?

Yep, PR just merged

1.0.5 has been pushed to Nuget. @provegard, you may be able to go back to your original approach with the new update.

Thanks, the HasRun approach worked. I could swear I've tried something like that before (minus setting Pending) and without getting it to work.
@amirrajan I'm not sure what you mean with "original approach". I upgraded to 1.0.5 and it was nice to get rid of the dummy builder. :-)

I upgraded to 1.0.5 and it was nice to get rid of the dummy builder. :-)

You should be able to manipulate the context collection and remove examples all together as opposed to having to set HasRun and Pending to true. I may be mistaken on this however.
Anyways, really glad that it worked for you. Wonder if @BrainCrumbz VS plugin could benefit from your NUnit wrapper.

@amirrajan I was going to close this issue for inactivity, but then there's quite a point in being able to run NSpec through a single spec/test-case, instead of a whole (sub)context as it is now.
Could you please elaborate further the reasoning started in previous comment ("We need to make a change in NSpec that completely decouples the Builder from the Runner."). Now that they are decoupled, what's after?

I think we're good. This commit decouples: https://github.com/mattflo/NSpec/commit/ccc5af0a78ebb55492f52762cab14528996c288e

Not sure how such codification of entire test structure would help, our main concern was to provide an API into nspec to run one or more selected its, while now one can "only" run all its within a context. The final purpose would be to expose such an API to NSpec console runner and VS test adapter.
It seems that such an API is not really about exact order of execution, but seems more about:

how to specify one or more its, potentially across several contexts (one can figure out this reasonably easy)

how to run just selected its in a context, without running all of them. Of course, the correct hooks should also run before and after (maybe this sounds somehow more complicated)

Gotcha. I think we've discussed this before, but I really do think that method level execution is sufficient (or at least a good starting point). Usually when the context nest too much, I "push everything up".
Not sure if you know this, but every test is Taged with the exact test name. So you could call the runner with that explicit test name and only that test will run.
Bad memory at this point, I'm sure we've talked through all of this before :-)

I don't think I knew that there's a Tag for every it, while I was aware there's one for every nspec-derived class. It must be memory then :)

Ah, I think you're right. Think it'd be a good idea to add a tag for every it (or at least context)?


Expose ExpansionTileState

Allows to programmatically expand or collapse an ExpansionTile
Fixes #60387
Example usage:
class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  final GlobalKey<ExpansionTileState> _expansionTileKey = GlobalKey<ExpansionTileState>();

  @override
  Widget build(BuildContext context) {
    return Column(
      children: <Widget>[
        ExpansionTile(
          key: _expansionTileKey,
          title: const Text('Collapsible menu'),
          children: const <Widget>[
            Text('Menu'),
          ],
        ),
        ElevatedButton(
          onPressed: () {
            ExpansionTileState expansionTile = _expansionTileKey.currentState!;
            if (expansionTile.isExpanded) {
              expansionTile.collapse();
            } else {
              expansionTile.expand();
            }
          },
          child: const Text('TOGGLE MENU'),
        )
      ],
    );
  }
}

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Hixie I rebased the branch.
I'm available to make any other requested changes.

+1 this PR

I've been reluctant to review this PR because it's generally not a good idea to turn a State object into public API, since State has many methods that aren't relevant in a case like this. Usually, we've dealt with this case by creating a class like ExpansionTileController that the developer can pass to a ExpansionTile and that exposes only as much API as is needed.

@HansMuller understood!
I went with the public State approach as it the obvious one used by Navigator, Scaffold etc...
I will try with the ExpansionTileController way, taking inspiration from ScrollController, TabController etc...

I'll close this PR and reopen a new one when I have time to work on the ExpansionTileController idea.

@xvrh - there are have been some additional requests for this feature so I'm going to try and land an ExpansionTileController version shortly. What I'm planning is very similar to what you've done, except that the controller's API will be limited to isExpanded, expand() and collapse():
class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  final ExpansionTileController controller = ExpansionTileController();

  @override
  Widget build(BuildContext context) {
    return Column(
      children: <Widget>[
        ExpansionTile(
          controller: controller,
          title: const Text('Collapsible menu'),
          children: const <Widget>[
            Text('Menu'),
          ],
        ),
        ElevatedButton(
          onPressed: () {
            if (controller.isExpanded) {
              controller.collapse();
            } else {
              controller.expand();
            }
          },
          child: const Text('TOGGLE MENU'),
        )
      ],
    );
  }
}

This really is the same thing under the hood, so an ExpansionTileController can only control one ExpansionTile.


Cannot use empty pump source

If I try to fill a database using .pumpSource(Iterator<Tuple2<K, V>) and the iterator is empty, I get an IndexOutOfBoundsException. Obviously not a big deal as it doesn't really make sense to use an empty pump source (I discovered this when implementing online backup using pump, and some of my tables were empty; just needed to add a check to skip backing those up).
Exception in thread "main" java.lang.IndexOutOfBoundsException
	at java.nio.Buffer.checkIndex(Buffer.java:532)
	at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:139)
	at org.mapdb.DataInput2.readUnsignedByte(DataInput2.java:74)
	at org.mapdb.BTreeMap$NodeSerializer.deserialize(BTreeMap.java:416)
	at org.mapdb.BTreeMap$NodeSerializer.deserialize(BTreeMap.java:288)
	at org.mapdb.Store.deserialize(Store.java:297)
	at org.mapdb.StoreDirect.get2(StoreDirect.java:475)
	at org.mapdb.StoreWAL.get2(StoreWAL.java:368)
	at org.mapdb.StoreWAL.get(StoreWAL.java:352)
	at org.mapdb.Caches$HashTable.get(Caches.java:245)
	at org.mapdb.BTreeMap.<init>(BTreeMap.java:541)
	at org.mapdb.DB.createTreeMap(DB.java:862)
	at org.mapdb.DB$BTreeMapMaker.make(DB.java:644)
	at MapDBEmptyPumpSource.main(MapDBEmptyPumpSource.java:30)

Test case: https://gist.github.com/mattwigway/a882c7ac360836df939b . This is with MapDB 1.0.6.

It is bug.  Thanks

Same problem already reported as #421

Fixed in both branches.


Stojanovic/fe 178 validation fe

In mobile view, clear all filters button purpose is not very clear judging from just the icon & should be aligned left , same with dashboard

@mirekys Thanks, do you mean it should go towards the menu button that opens the facets sidebar? Regarding the clarity, in the last iteration, we agreed it would be just an icon on tablet/mobile, so that it would be able to fit in the existing row with other items. Problem is if it contains text as well, it does not fit as you go smaller with screen size. Do you mean to add a popup on the icon, or do you mean that we need to display whole text please?


Download the pretrained model

Sorry to disturb you, I can not open the dropbox to download the pretrained model in my country.So can you share another URL to save the model such as google driver. Thank you very much!

I added the link to readme, please check now.


Fix dictionary key collision of test run parameters.

When 'Keep Test Execution Engine Running' in VS, the TestExecutionManager is reused and tests that contain TestRunSettings will encounter key collision when being added between runs and bleedover of properties will occur.

This is the type of errors this change fixes:
[11/3/2017 9:21:17 AM Informational] ------ Discover test started ------
[11/3/2017 9:21:17 AM Informational] ========== Discover test finished: 1 found (0:00:00.1785022) ==========
[11/3/2017 9:21:17 AM Informational] ------ Run test started ------
[11/3/2017 9:21:17 AM Error] An item with the same key has already been added.
[11/3/2017 9:21:17 AM Informational] ========== Run test finished: 1 run (0:00:00.1540039) ==========
That error can cause VSTS to fail the test step.
There are two existing unit tests to validate this area:
TestExecutionManagerTests.RunTestsForSourceShouldPassInTestRunParametersInformationAsPropertiesToTheTest
TestExecutionManagerTests.RunTestsForTestShouldPassInTestRunParametersInformationAsPropertiesToTheTest
I didn't create a new test as it required a larger change to the TestExecutionManagerTests for capturing the error text and instead validated it manually.

@CodeCyclone : Thank you for your contribution but I believe there is some confusion in the concept of Caching testsession parameters.
We cache testsession parameters in RunTests() rather than doing it in  ExecuteTestsInSource() because these parameters are constant for a run(as read from the settings file) and they do not change for each test/source. Hence, instead of re-reading the test run parameters for each source, we read them once and cache them for future use.
We have suggested some changes along with which you should also add UnitTests related to that change. Feel free to let us know if you need any assistance on this.

Fixed this issue in another PR. Punting this PR.


WIP:  FAQ

WIP to add a FAQ to the documentation, following up on https://github.com/mne-tools/mne-python/issues/1495 and https://github.com/mne-tools/mne-python/issues/1637.
CC @agramfort @dengemann
Is it possible to build the docs with Anaconda? I get
$ make html
...
plotting plot_bem_contour_mri.py
//anaconda/lib/python2.7/site-packages/wx-3.0-osx_cocoa/wx/_core.py:16674: ImportWarning: Not importing directory '//anaconda/lib/python2.7/site-packages/wx-3.0-osx_cocoa/wx/locale': missing __init__.py
  import locale
This program needs access to the screen.
Please run with a Framework build of python, and only when you are
logged in on the main display of your Mac.
make: *** [html] Error 1

Cov PR is merged, so this could be resumed. @christianbrodbeck do you have time to work on it and get it merged? Or @dengemann did you want to open a PR into his branch to add your covariance info? Maybe a stub is sufficient for now so this PR doesn't have to sit idle.

@Eric89GXL @dengemann I don't understand the new methods well enough to write about them, but if you want to provide me with the content I will integrate it (you're of course also welcome to take over the PR)

Hello folks. I'm taking over. I just can't do it now. See my comments on #1728 btw.

@dengemann now that you're done defending I assume you have time to take this over? :)

ping @dengemann do you have time in the next few days to take this over and finish it (with #1637 and #1728 and parts of #1495)?

@Eric89GXL I might have time for this yes. I'm a bit reluctant, because it seems the full list of recommendations is not yet complete. But maybe incremental is better than nothing.

yeah i think so, users just need help getting going, we can always revise later

@dengemann has taken over, closing


Improve flyout and icon native maps SDK doc

Add sample code for custom flyout
Fix typo and format issues

Docs Build status updates of commit 75e6969:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/sdk-native/map-control-api/customtilemaplayer-class.md
:warning:Warning
View
Details

BingMaps/sdk-native/map-control-api/mapelementcollection-class.md
:warning:Warning
View
Details

BingMaps/sdk-native/map-control-api/mapelementlayer-class.md
:warning:Warning
View
Details

BingMaps/sdk-native/map-control-api/mapflyoutcustomviewadapter-interface.md
:warning:Warning
View
Details

BingMaps/sdk-native/map-control-api/mapicon-class.md
:warning:Warning
View
Details

BingMaps/sdk-native/map-control-api/mapuserinterfaceoptions-class.md
:warning:Warning
View
Details

BingMaps/sdk-native/map-control-concepts/display-flyout.md
:warning:Warning
View
Details

BingMaps/sdk-native/map-control-concepts/handle-map-events.md
:warning:Warning
View
Details

BingMaps/sdk-native/map-control-concepts/map-icons.md
:warning:Warning
View
Details

BingMaps/sdk-native/map-control-api/customtilemaplayer-class.md

[Warning] Missing attribute: title. Add a title string to show in search engine results.

BingMaps/sdk-native/map-control-api/mapelementcollection-class.md

[Warning] Missing attribute: title. Add a title string to show in search engine results.

BingMaps/sdk-native/map-control-api/mapelementlayer-class.md

[Warning] Missing attribute: title. Add a title string to show in search engine results.

BingMaps/sdk-native/map-control-api/mapflyoutcustomviewadapter-interface.md

[Warning] Missing attribute: title. Add a title string to show in search engine results.

BingMaps/sdk-native/map-control-api/mapicon-class.md

[Warning] Missing attribute: title. Add a title string to show in search engine results.

BingMaps/sdk-native/map-control-api/mapuserinterfaceoptions-class.md

[Warning] Missing attribute: title. Add a title string to show in search engine results.

BingMaps/sdk-native/map-control-concepts/display-flyout.md

[Warning] Missing attribute: title. Add a title string to show in search engine results.
Line 14: [Warning] Invalid link: 'LightDismissEnabled property'. The file sdk-native/map-control-api/mapflyout-class.md doesn't contain a bookmark named 'LightDismissEnabled'.
Line 113: [Warning] Invalid link: 'Sequence extension for MSMapElementCollection'. The file sdk-native/map-control-api/mapelementcollection-class.md doesn't contain a bookmark named 'Sequence-protocol-in-Swift'.

BingMaps/sdk-native/map-control-concepts/handle-map-events.md

[Warning] Missing attribute: title. Add a title string to show in search engine results.
Line 31: [Warning] Invalid link: 'Sequence extension for MSMapElementCollection'. The file sdk-native/map-control-api/mapelementcollection-class.md doesn't contain a bookmark named 'Sequence-protocol-in-Swift'.

BingMaps/sdk-native/map-control-concepts/map-icons.md

[Warning] Missing attribute: title. Add a title string to show in search engine results.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


PYNE_DECAY_IS_DUMMY

I think you're right this should live in the pyne org though it might need a name change

Sorry to lurk, but just FYI the BASE var in the Makefile got ninja updated =)

Thanks for catching that @gidden!  We'll probably want to generalize that...


Remove cf recycle because of major bug

The current version of the cf recycle plugin has a major bug which can cause downtimes.
So its not safe to it till this issue is fixed.
As an alternative there seems to be a fork of the plugin which fixes this issue.
Maybe the comcast plugin should be removed and the fork added.
For more details see https://github.com/Comcast/cf-recycle-plugin/issues/3
thx

Hi @eloo thanks for reaching out, it looks like the administrators of the plugin made changes to update the plugin - we recommend you reach out to the plugin authors to get a update on the status of the fix. If they would like us to remove the plugin, then please have them reach out to us.

@abbyachau
looks like the maintainer has fixed the issue and created a new release.
so it would be great if you could update the plugin repo


Run a cron command on a specific file?

Hi and thank you for this amazing plugin!
i actually discovered this via this conversation:
https://github.com/ivan-lednev/obsidian-task-archiver/issues/82#issuecomment-2118099295
and im wondering if i can request an option to run the cron command on a specific file?
thx alot!
Z

Hi @zeltak 👋
At present this wouldn't be possible no.
There are a few problems I for see with this.
To activate the command on a specific file it has to be active with the current editor. This would result in a potentially pretty shitty experience for the user as periodically their Obsidian would just swap files randomly, regardless of if they were presently doing this.
There might potentially be ways around this but will have to investigate. I wouldn't have super high hopes.
Thanks!

thx for the update @cdloh !

@zeltak I've had a look at this and it isn't really possible. I have no way of controlling other commands etc.
If you need to run it against a specific file like in your example I would need to make the editor change the current file which would create a really bad user experience as periodically your editor would effectively be out of your control.
You would need to get the plugin to expose an API so you could do it periodically against specific files.


AccessDenied: Access denied: can't set typing activity for this peer

| 16.03.2017 (11:18:48) |
Traceback (most recent call last):
  File "library/utils.py", line 24, in execute
    result = handler(*list)
  File "modules/mod_msg_main.py", line 68, in message_handler
    user.vk.method("messages.setActivity", {"user_id": target, "type": "typing"}, True)
  File "./gateway.py", line 347, in method
    result = self.engine.method(method, args, notoken=notoken)
  File "library/vkapi.py", line 382, in method
    raise AccessDenied(eMsg)
AccessDenied: Access denied: can't set typing activity for this peer

Наверное лучше это просто игнорировать.


the view doesnt refresh in API 23 android studio 2.0

after i update my android studio and change
compile 'com.android.support:recyclerview-v7:23.3.0'
compile 'com.android.support:appcompat-v7:23.3.0'
when i use calendarview.refresh() it doesnt update the view. the events not appear in the calendar neither in the examples of the git.

Did you try version 1.2.1?

Using FlexibleCalender version 1.2.1 solved it for me.
PS: great library!

@JohanLight I'm closing this issue. Feel free to reopen if you are still facing the issue.

Thanks. The problem was solved with the update
El viernes, 22 de abril de 2016, Pratyush Verma<EMAIL_ADDRESS>escribió:

Closed #27 https://github.com/p-v/FlexibleCalendar/issues/27.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/p-v/FlexibleCalendar/issues/27#event-637332815


Added autorization header support to scaffolder-backend-module-http-r…

…equest

:heavy_check_mark: Checklist

[x] Added tests for new functionality and regression tests for bug fixes
[x] Added changeset (run yarn changeset in the root)
[ ] Screenshots of before and after attached (for UI changes)
[ ] Added or updated documentation (if applicable)

this is closed issue https://github.com/RoadieHQ/roadie-backstage-plugins/issues/558

@goququ you will need to run the following command and push up the result in order for the verification to pass.
yarn prettier --write plugins/scaffolder-actions/scaffolder-backend-module-http-request

Thanks 🙂


Left navigation bar - Add horizontal divider style (change won't be visible until someone adds the divider)

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6747e55186d4e8050661f1a1--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6747fd34b958141a1bb2806b--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6749c0cfcdc2ec8ba6f82741--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6749ce19e88c34b0cbe3fe4b--harness-developer.netlify.app

@lenasano Everything looks great! How about adding style for dark mode as well?

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://674c609dec488688ce5ce93a--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://674c6187e6d0f6848e6bdf61--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://674c6245cdc2ec85c4f82626--harness-developer.netlify.app


view in model

Please note although we can't commit to any timeline, priority will be given to those who are Contributors to the project.
If this is a question please ask on StackOverflow.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Describe suggestions on how to achieve the feature
A clear description to how to achieve the feature.
Additional context
Add any other context or screenshots about the feature request here.

Hi it doesn't seem to be any content? Closing.


Fix possible ignored JDBC tests

We might have lost part of JDBC tests result because some tables were not read correctly.

/run-all-tests

/run-all-tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c948d12). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #399   +/-   ##
=========================================
  Coverage          ?   55.21%
=========================================
  Files             ?      127
  Lines             ?     5812
  Branches          ?      864
=========================================
  Hits              ?     3209
  Misses            ?     2310
  Partials          ?      293

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c948d12...6331c8d. Read the comment docs.


Cannot find module 'lodash/isNAN'

gowthaman@gowthaman-i2i:~/ideas2it/Form IO/Render-Form/ngFormBuilder$ gulp
[11:09:07] Using gulpfile ~/ideas2it/Form IO/Render-Form/ngFormBuilder/gulpfile.js
[11:09:07] Starting 'build'...
[11:09:07] Starting 'clean'...
[11:09:07] Starting 'watch'...
[11:09:07] Finished 'clean' after 134 ms
[11:09:07] Starting 'scripts:basic'...
[11:09:07] Starting 'scripts:complete'...
[11:09:07] Starting 'scripts:full'...
1146089 bytes written (9.70 seconds)
[11:09:19] /home/gowthaman/ideas2it/Form IO/Render-Form/ngFormBuilder/dist/ngFormBuilder.min.js reloaded.
[11:09:19] Finished 'watch' after 12 s
[11:09:20] /home/gowthaman/ideas2it/Form IO/Render-Form/ngFormBuilder/dist/ngFormBuilder.min.js reloaded.
[11:09:20] Finished 'scripts:basic' after 13 s
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Cannot find module 'lodash/isNAN' from '/home/gowthaman/ideas2it/Form IO/Render-Form/ngFormBuilder/node_modules/ng-formio/src/directives'
    at /home/gowthaman/ideas2it/Form IO/Render-Form/ngFormBuilder/node_modules/browser-resolve/node_modules/resolve/lib/async.js:46:17
    at process (/home/gowthaman/ideas2it/Form IO/Render-Form/ngFormBuilder/node_modules/browser-resolve/node_modules/resolve/lib/async.js:173:43)
    at ondir (/home/gowthaman/ideas2it/Form IO/Render-Form/ngFormBuilder/node_modules/browser-resolve/node_modules/resolve/lib/async.js:188:17)
    at load (/home/gowthaman/ideas2it/Form IO/Render-Form/ngFormBuilder/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
    at onex (/home/gowthaman/ideas2it/Form IO/Render-Form/ngFormBuilder/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
    at /home/gowthaman/ideas2it/Form IO/Render-Form/ngFormBuilder/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:123:15)

below versions are installed
$  node -v && npm -v && bower -v && gulp -v

v6.11.2
5.3.0
1.8.0
[11:12:28] CLI version 3.9.1
[11:12:28] Local version 3.9.1

isNaN under lodash library is used by formioWizard script in ngFormio library which is used by ngFormioBuilder .Recent release of ngFormio using lodash version 4.17.4 ,which is not having isNAN.js ,To avoid this issue please use ngFormio version ,which is using lodash version having isNAN

I don't understand what version of nfFormio needs to be used on order to avoid this error. Can you specify?

It is enough to include lodash version in ngFormioBuilder having isNAN.js .Kindly refer lodash releases (for example: 4.17.3)


Move JSON parsing section to HTTP request page

Spliced out from refactor PR (https://github.com/R2Northstar/ModdingDocs/pull/134)

I'm curious about the reasoning for this, why should something useful outside of http requests be moved to the httprequests document? i'd much rather the httprequests document just link to the json parsing document instead.

Paging @NoCatt cause it's from their refactor

Closed due to 13ae709ec7b8295319efaeda1ec349c2e7435256 in #134


Add Taiwan welcome message

Including geojson of Taiwan, welcome message, the Taiwan welcome page
I'll add a zh-tw translation for the osm-welcome-tool latter.

Thank you @Supaplextw !
It will be deployed in the next few days, I'll keep you updated.

🚀 Deployed: https://welcome.osm.be/taiwan/list


Add function find_devices to core/lib.lua

This function can be helpful to set a PCI address by a pattern, so either finding a device by a full address "0000:01:00.0" or a shorter address ":01:00.0" are valid.
This code is part of snabb-lwaftr. We think it can be useful for other modules too. Function by @andywingo.

Public functions of core.lib should be documented in src/README.md.src. Refer to the documentation-guide for pointers.

Updated PR:

Moved function to lib/hardware/pci.lua.
Documented function in lib/hardware/README.md.src.

apparently this code is over at https://github.com/dpino/snabbswitch/compare/find_devices currently

Sorry, I closed this PR by mistake. I restored the dpino:add_find_devices branch but it seems this PR cannot be reopened. I can create a new PR if necessary.

PR rebased to master. I added a patch removing the constraint that limits find_devices search to intel devices.

Great initiative, Diego! We definitely need a shorter way to refer to PCI devices.
Zooming out to the overall idea rather than the code, I see two alternative ways to implement this:

Using Lua patterns to match PCI addresses.
Exactly defining a short/canonical form for PCI addresses.

Lua patterns are tempting. We are already using them in packetblaster too. Packetblaster accepts a pattern to name multiple devices, so you can write 0[123]:00.[01] to potentially match all of 0000:01:00.0 0000:01:00.1 0000:02:00.0 0000:02:00.1 0000:03:00.0 0000:03:00.1. Or you could simply write . to match all available devices. The downside I see is that this is a leaky abstraction (exposing Lua quirks to end-users of Snabb based applications) and it can be surprising too e.g. that . will be treated as a wildcard rather than a literal period (awkward since PCI addresses have a significant period character in them).
I feel like the principle of least surprise takes precedence here. I have come to think of the packetblaster command-line as a misfeature.
The alternative is to define (or find and reuse) a canonical shortening of PCI addresses. Like the way IPv4 and IPv6 addresses have lang/short forms via pton and ntop.
Here is an idea for some isomorphic address transformations:
1 <-> 01 <-> 01:00 <-> 01:00.0 <-> 0000:01:00.0

and the canonical representation could be the full address but omitting any leading 0000:.
What do you think? Would that work for lwAFTR too?

It's slightly awkward that it takes until the 3rd element of that to have a way to specify addresses like 01:00.1. I'm not sure that 1 and 01 are great abbreviations; they imply .0, making it more awkward to specify .1 in comparison, which I can imagine being annoying for people just starting to use Snabb (they'll get used to using 1, then have to scramble around how to figure out how to refer to a .1 address). And it's not obvious looking at a command line that you're referring to a PCI address at that point. '1' looks like it could equally be an overly-abbreviated non-canonical form of lots of different things.
I think 01.0 is ok (I'm not enthusiastic about it, but it'll save some typing), I like 01:00.0 as the canonical representation, and 0000:01:00.0 should be allowed (but never required), I'd say. (One thing I've wondered about, but never dug into, is whether the 0000 is always 0000, and why; do you know?)
I agree with you that exposing Lua patterns is the wrong approach.
All of the options you've mentioned could work for the lwAFTR.

@kbara The full syntax is DOMAIN:BUS:DEVICE.FUNCTION. Here is one documented convention.
On reflection I also like the idea of having a canonical form that simply omits any leading 0000:. So we would write 01:00.0 and expect to see PCI addresses printed in that same shortened format. If the domain is non-zero then the long format would be used. End of story.

Sounds fantastic.

I implemented the expansion in #660. It's slightly different to what @lukego suggested. IMHO the inconvenient of expanding "1" as "0000:01:00.0" is that there's not short form for device == 1. The only way to write such address is using the full form "0000:00:01.0". I think the schema should be similar to IPv6 abbreviation, where "::1" means "0:0:0:0:0:0:0:1". So, "0000:04:00.0" would be abbreviated as "4:". A single "4" gets expanded to "0000:00:04.0". There are more examples in the PR.

Honestly, that feels like way too many options. Documenting it, visually parsing what other people are using, and the increased use of things that look almost IPv6-like strike me as all richer sources of confusion this way. I'm all for convenience, but I think this goes so far that it's less convenient or practical.

I agree with @kbara. @dpino, I humbly apologise for suggesting the more complex scheme. The extra code and explanations are really not justified by the convenience (which in itself might even lead to confusing inconsistency in usage).

Is this obsoleted by #669 as well?

@eugenia Right. I close this PR :)


Fixes #73

Pull Request (PR) description
Fix issue where "The term 'IPAddress' is not recognized" occurs on Get-DhcpServerv4Reservation
This Pull Request (PR) fixes the following issues

Fixes #73

Task list

[ ] Added an entry to the change log under the Unreleased section of the
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Community Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[ ] New/changed code adheres to DSC Community Style Guidelines.

This change is

This PR is an incomplete duplicate of #77 which has been open since February. I'm getting the feeling that this entire project is abandoned / unmaintained?
Anyway, you only fixed the problem in one place - take a look at #77 for a better fix.


Changes in Acto for running tests on kubeblocks postgresql operator

Mainly 3 changes -

Added scope for running kubectl create -f file along with apply and wait commands.
Removed server-side flag while running kubectl apply since that prevented kubeblocks addon extensions from being deployed successfully
Added a folder with some useful data for the kubeblocks postgresql operator (similar to other operators present in the data folder)

@raunaks13 Thanks for the PR!
Could you break the PR into two or even three? Each PR should focus on a small thing and only one thing at a time.
#3 is apparently different from #1 and #2.
I'm not sure if #1 and #2 are correlated or not.

I met with the same issues caused by server-side flags. But there are cases in which a server-side flag is necessary.
Regarding 2, I have an idea of adding an option "server-side": true/false (default to true) to control the flag manually.


fix: bug 1661 - improved placeholder text for filters

Clearer placeholder text for entity and action filters

:tada: This PR is included in version 0.324.20 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Installing SAP HANA, express edition with Docker - create hxeadm and sapsys

After reading between the lines and back and forth a bit, I realized that I needed to create group sapsys and user hxeadm on my docker host server.
I am running on Debian 9 Stretch, so I used the commands
addgroup -GID 79 sapsys
adduser -UID 12000 -GID 79 hxeadm
These commands will work on Debian derived distributions but will vary for other linux distributions.
Cheers,
lbe

For CentOS,
$ sudo groupadd --gid 79 sapsys
$ sudo useradd --uid 12000 --gid 79 hxeadm

@andychoi - Thanks for the CentOS information here. I recommend adding these CentOS addgroup and useradd commands to a post on the Community (https://www.sap.com/developer/topics/sap-hana-express.community.html#community), if it's not posted already.


Enums don't correspond with the values in GMaps

Re-ordering these closes https://github.com/SebastianM/angular-google-maps/issues/1105

Thx! Landed as 6081e57a9ab7cedd1e6e727268ce7b09ab369b1f


python311Packages.google-cloud-websecurityscanner: 1.12.1 -> 1.12.2

Changelog: https://github.com/googleapis/python-websecurityscanner/blob/v1.12.2/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 241892 run on x86_64-linux 1

4 packages built:

python310Packages.google-cloud-websecurityscanner
python310Packages.google-cloud-websecurityscanner.dist
python311Packages.google-cloud-websecurityscanner
python311Packages.google-cloud-websecurityscanner.dist


when train ,how can i set the num epoches?

i can't find where to set num epoches for training,anyone knows please tell me,ths.

Close this issue for now


gRPC clients with connection problems will remain in the client pool

Suppose the port for the GRPC is not open (due to a firewall, etc.).
The nodes in the cluster are using the SWIM protocol on different listen port to check each other's survival, so they appear to be alive to each other in the cluster.
In the client pool, this Lazy gRPC client remains even though the gRPC port is closed, so every time a search request comes in, some splits are assigned to that gRPC client, and then the search fails.

Duplicate of #1017


vagrant fails

vagrant build fails due to missing tzdata=2014j-0wheezy1 dependency
==> default: Error: Could not update: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold --force-yes install tzdata=2014j-0wheezy1' returned 100: Reading package lists...
==> default: Building dependency tree...
==> default: Reading state information...
==> default: E: Version '2014j-0wheezy1' for 'tzdata' was not found
==> default:
==> default: Error: /Stage[main]/Main/Package[tzdata]/ensure: change from 2015f-0+deb7u1 to 2014j-0wheezy1 failed: Could not update: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold --force-yes install tzdata=2014j-0wheezy1' returned 100: Reading package lists...
==> default: Building dependency tree...
==> default: Reading state information...
==> default: E: Version '2014j-0wheezy1' for 'tzdata' was not found
==> default:
==> default: Notice: /Stage[main]/Elasticsearch/Anchor[elasticsearch::end]: Dependency Package[tzdata] has failures: true
==> default: Warning: /Stage[main]/Elasticsearch/Anchor[elasticsearch::end]: Skipping because of failed dependencies
==> default: Notice: /Stage[main]/Elasticsearch/Anchor[elasticsearch::begin]: Dependency Package[tzdata] has failures: true
==> default: Warning: /Stage[main]/Elasticsearch/Anchor[elasticsearch::begin]: Skipping because of failed dependencies
==> default: Notice: /Stage[main]/Elasticsearch::Java/Package[openjdk-7-jre-headless]: Dependency Package[tzdata] has failures: true
==> default: Warning: /Stage[main]/Elasticsearch::Java/Package[openjdk-7-jre-headless]: Skipping because of failed dependencies

and so on ..

Going to fix this by migrating to ubuntu

No longer occurring with ubuntu:
https://github.com/ongr-io/ongr-sandbox/blob/master/src/ONGR/DemoBundle/Resources/doc/index.rst
https://github.com/ongr-io/testing-vm


Suggestion

If possible a converter from las to Json to have this adopted

This tool exists and will be made available as freeware during Q1/2021.


Shadows too dark?

I do like the shadowmaps, models are bright on the lighted side, however the darker sides are pitch-black. Even if I set lighted to true on the object I don't see a difference. In older versions the shadowmap wasn't as advanced but models could be rendered with flat lighting and no shadows. I looked around the entire project but could not find a way to recreate this, disabling the shadow map simply renders the object black.

I figured out what my issue was, the problems were actually with the normals and the material file.


bazel: update to 4.1.0

Description: updates to bazel 4.1.0 by removing deprecated dependencies and bespoke build rules for swift.
Risk Level: low
Testing: CI
Signed-off-by: Jose Nino<EMAIL_ADDRESS>

Heavy inspiration from  https://github.com/envoyproxy/envoy-mobile/pull/797

Nice! Thank you @junr03!

Awesome! Green.


How to handle service configuration

In Meteor's accounts system the configuration for each service (keys, login style, etc) is stored in the database. @gadicc I see similar approach in your DBDriver interface with the fetchConfig function.
Using Grant the services are configured through JS/JSON and the data probably originates from environment variables.
My question is which implementation to go with? Or perhaps a hybrid of the two?
What are the benefits of storing the service config in the database?

Hybrid would be nice.  From a design perspective, as long as the Grant init is done async (or, that we can mutate the config post-init), it's pretty easy to offer both.
The Meteor guided config is great for less experienced devs and I think overall just more convenient, but I don't think essential.  Depending on how far we take it, we could (in the long term) allow to add new services all online without redeploying the app, or other runtime config options.  Would also be cool to leverage this data in existing Meteor installs, but we can always do that in a separate compatibility later.
In short, I think let's start off with JSON but try design the system in a way that accommodates DB config further down the line.

Sounds like a plan.


Some problem with labels. Please check.

Labels can take value between 0 and number of classes.
Some problem with labels. Please check.
unique_values=[  0   1   2   4   5   7   8  10  11  13  14 255]
Is it important？

Map 255 to 19.

@sacmehta
Traceback (most recent call last):
File "main.py", line 406, in
trainValidateSegmentation(parser.parse_args())
File "main.py", line 332, in trainValidateSegmentation
train(args, trainLoader_scale1, model, criteria, optimizer, epoch)
File "main.py", line 102, in train
loss.backward()
File "/usr/local/lib/python3.6/dist-packages/torch/tensor.py", line 93, in backward
torch.autograd.backward(self, gradient, retain_graph, create_graph)
File "/usr/local/lib/python3.6/dist-packages/torch/autograd/init.py", line 89, in backward
allow_unreachable=True)  # allow_unreachable flag
RuntimeError: CUDNN_STATUS_INTERNAL_ERROR
Torch v0.4.0   opencv 3.4
What causes it

Use PyTorch version 0.3.1

@sacmehta
/pytorch/torch/lib/THCUNN/SpatialClassNLLCriterion.cu:99: void cunn_SpatialClassNLLCriterion_updateOutput_kernel(T *, T *, T *, long *, T *, int, int, int, int, int, long) [with T = float, AccumT = float]: block: [9,0,0], thread: [960,0,0] Assertion t >= 0 && t < n_classes failed.
Traceback (most recent call last):
File "main.py", line 406, in
trainValidateSegmentation(parser.parse_args())
File "main.py", line 332, in trainValidateSegmentation
train(args, trainLoader_scale1, model, criteria, optimizer, epoch)
File "main.py", line 102, in train
loss.backward()
File "/usr/local/lib/python3.6/dist-packages/torch/autograd/variable.py", line 167, in backward
torch.autograd.backward(self, gradient, retain_graph, create_graph, retain_variables)
File "/usr/local/lib/python3.6/dist-packages/torch/autograd/init.py", line 99, in backward
variables, grad_variables, retain_graph)
RuntimeError: CUDNN_STATUS_INTERNAL_ERROR
Still exists

Seems like you still have 255 as a label. Did you change that in Transforms file?

@sacmehta Thank you for your helping. It works

@engineer1109 Hi. did you solve your problem well?
i encountered the same problem
i did already change the code
if 255 in unique_values:
label_img[label_img == 255] = 19
unique_values = np.unique(label_img)
like this in loadData.py
but it's not worked..
@sacmehta  told me that i should change the  Transforms.py's code too.
but i dont know how to i change the code. plz let me know how to i change the code of Transforms.py


PR: Speedup: don't use EVM if no EVM agents

For issue #51 .

Note: the first commit not only changed gitignore, but also added USE_EVM constant.

Concern: If some agents see OCEAN on EVM, and some don't, then OCEAN supply could get mixed up. Does this affects calculations in wsloop for mkt_cap / supply?
Answer: No. Wsloop tracks OCEAN supply not in EVM, but inside SimState.
Details...
In assets/netlists/wsloop/SimState.py:
    def __init__(self..):
    ...
        self._total_OCEAN_minted: float = 0.0
        self._total_OCEAN_burned: float = 0.0
        self._total_OCEAN_burned_USD: float = 0.0
    ...

    def OCEANsupply(self) -> float:
        """Current OCEAN token supply"""
        return self.initialOCEAN() \
            + self.totalOCEANminted() \
            - self.totalOCEANburned()

    def initialOCEAN(self) -> float:
        return self.ss.INIT_OCEAN_SUPPLY

    def totalOCEANminted(self) -> float:
        return self._total_OCEAN_minted

    def totalOCEANburned(self) -> float:
        return self._total_OCEAN_burned

    def totalOCEANburnedUSD(self) -> float:
        return self._total_OCEAN_burned_USD

In assets/agents/MinterAgents.py is the following. It's the only place in code that total_OCEAN_minted is changed from its initial value of 0.0.
    state._total_OCEAN_minted += OCEAN
...
    state._total_OCEAN_minted += OCEAN

In assets/agents/OCEANBurnerAgent.py is the following. It's the only place in code that total_OCEAN_burned is changed from its initial value of 0.0.
    state._total_OCEAN_burned += OCEAN


Update dependent library

SSIA

Codecov Report

Merging #50 (5c74d94) into master (596c8db) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   55.34%   55.34%
=======================================
  Files          10       10
  Lines        2105     2105
=======================================
  Hits         1165     1165
  Misses        755      755
  Partials      185      185


Expose the internal attribute of the ALB

In this PR I expose the internal attribute of the ALB as a variable in the ui module, and expose that variable in the main module. This allows a fully private UI which accepts only traffic from within the VPC.

@oavdeev same here, could you or someone take a look? Again can provide content if needed.


Implemented registry for digester

This will be used to handle custom digester histograms

@alecholmes Yes, there were a couple things I wanted to clarify before continuing. I was waiting until our wed meeting to do that.

Rebasing off Master should restore green CI builds.

If this PR is still relevant, then please fix conflicts, rebase and get a green CI build.
If the PR is no longer relevant please close.
This PR will be closed at the end of January 2021 otherwise.

If this PR is still relevant, then please fix conflicts, rebase and get a green CI build.
If the PR is no longer relevant please close.
This PR will be closed at the end of January 2021 otherwise.

Closing request as per previous announcement.

Closing request as per previous announcement.


How do I use this tool?

Ive tried using it though command prompt and through python, but niether have worked.  Am i missing something?

Maybe start by mentioning what OS you are running on and which Python version are you using. Also some examples of exact commands you are trying to run would not hurt.

Closing due to lack of response, thanks for the help, @UniverseDevel!


Add shadcn paths to .prettierignore and .eslintignore

Describe the feature in detail (code, mocks, or screenshots encouraged)
I think it could be cool to add aliases.components and aliases.utils to .prettierignore and .eslintignore at CLI install so they don't get modified by Prettier and ESLint when running the general prettier --write . command.
I have no problem with the formatting of my locally installed shadcn components, but it makes them "outdated" from the CLI's perspective. I also don't want to get notified by prettier --check . that some of my files are not formatted correctly, which is an opinionated format choice.
I'd understand if I get told it's not the library's responsibility, however, it could be a nice addition because of the uniqueness of shadcn's installation method. What do you think?
What type of pull request would this be?
New Feature
Provide relevant links or additional information.
No response

Appreciate you taking the time to make this request!
I get where you're coming from, however, I think having this as a default rather than peeps adding it themselves would be unexpected behavior, considering the idea of you owning the code. Additionally, this would introduce more complexity into the CLi before we even add things that will warrant the complexity (non-TS, CSS vars, etc.). We wouldn't be able to assume everyone is using eslint and prettier, so more checks would need to go in place, and then the topic of monorepos comes into the mix which makes things even more of a PITA.
So for now, I'm going to say this isn't going to be on the lib's area of responsibility, however, if this request comes up more frequently, it could be something we consider later down the line.
I'd like to improve the diff ability, which could involve some temp formatting so it doesn't matter what we/you use for your prettier config, but this is down the road on the roadmap!

Thanks for this detailed answer! I completely understand your point and I'm not surprised by your statement.
It's true that a diffing mechanism would be an even better solution, I'm stealing that idea to make it feature of my recently released shadcn IntelliJ extension!


add logger

@maidh91 I'm closing this as it's not the direction we need for logging, we can scope down pieces of this maybe but avoid adding complexity at all costs please


[3928][tiered-storage] Include java-xmlbuilder in tiered-storage-jcloud NAR

In the POM file for tiered-storage-jcloud, the dependency on
com.jamesmurty.utils/java-xmlbuilder was marked with test scope, but in
fact this dependency is needed during normal use. This commit changes
the POM file so that the java-xmlbuilder dependency is packaged in the
NAR file.
Fixes #3928.
Verifying this change
I am not sure how to test this change. I don't know the implications of changing this dependency. Maybe the java-xmlbuilder dependency was marked as "test" for a specific reason, and my change will break something else.
The NAR file builds when I run mvn package. When I deployed it to a test cluster running pulsar 2.3.0, I did not see the errors that were reported in #3928.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): yes
The public API: no
The schema: no
The default values of configurations: no
The wire protocol: no
The rest endpoints: no
The admin cli options: no
Anything that affects deployment: don't know

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Merged in 2.3.1 at
ec3d635


scrcpy close while vs code starts and if vs code already started then scrcpy not working

jarvis@debian:~$ scrcpy
adb server version (41) doesn't match this client (39); killing...
* daemon started successfully
/usr/local/share/scrcpy/scrcpy-server-...shed. 4.0 MB/s (19734 bytes in 0.005s)
INFO: Initial texture: 720x1280
jarvis@debian:~$

See #527.

See #527.

That's Not my solution, everything run find until vs code not start

The reason of this message is that there are two different adb running on your system. You need to use the same version for all your programs.
For scrcpy, you can set the environment variable ADB to the full path of the adb executable you want to use.

jarvis@debian:~$ scrcpy
INFO: scrcpy 1.11 https://github.com/Genymobile/scrcpy
adb server version (41) doesn't match this client (39); killing...
ADB server didn't ACK
Full server startup log: /tmp/adb.1000.log
Server had pid: 4088
--- adb starting (pid 4088) ---
adb I 12-08 15:25:53  4088  4088 main.cpp:57] Android Debug Bridge version 1.0.39
adb I 12-08 15:25:53  4088  4088 main.cpp:57] Version 1:8.1.0+r23-5
adb I 12-08 15:25:53  4088  4088 main.cpp:57] Installed as /usr/lib/android-sdk/platform-tools/adb
adb I 12-08 15:25:53  4088  4088 main.cpp:57]
adb I 12-08 15:25:53  4088  4088 adb_auth_host.cpp:416] adb_auth_init...
adb I 12-08 15:25:53  4088  4088 adb_auth_host.cpp:174] read_key_file '/home/jarvis/.android/adbkey'...
adb I 12-08 15:25:54  4088  4088 adb_auth_host.cpp:391] adb_auth_inotify_init...
adb server killed by remote request

failed to start daemon
adb: error: failed to get feature set: cannot connect to daemon
ERROR: "adb push" returned with value 1

@rom1v  please how do i set the environment variable ADB to the full path of the adb executable you want to use??


fix(auth)!: 认证系统查询已有用户的API归类到创建用户API中

#307 的设计不够全面。一些第三方的认证系统（例如学校的统一认证系统）一般都不会提供随意查询一个用户是否存在的接口。另外，此API也只会在创建用户的时候用到，用于查询用户是否已经存在，如果认证系统声明不支持创建用户，SCOW也不会主动去查询一个用户是否在认证系统中存在。
所以此PR修改了此设计，使GET /user接口从之前必须实现的改变为只有在支持创建用户的时候情况下才要求实现。
<EMAIL_ADDRESS>

Codecov Report
Base: 64.56% // Head: 64.38% // Decreases project coverage by -0.17% :warning:

Coverage data is based on head (4a62ef1) compared to base (5eb6c26).
Patch coverage: 68.85% of modified lines in pull request are covered.

:exclamation: Current head 4a62ef1 differs from pull request most recent head 36da41d. Consider uploading reports for the commit 36da41d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   64.56%   64.38%   -0.18%
==========================================
  Files          99       99
  Lines        2802     2802
  Branches      347      349       +2
==========================================
- Hits         1809     1804       -5
- Misses        948      953       +5
  Partials       45       45

Impacted Files
Coverage Δ

apps/auth/src/auth/ssh/index.ts
59.09% <ø> (-8.77%)
:arrow_down:

apps/auth/src/routes/getUser.ts
84.61% <33.33%> (-15.39%)
:arrow_down:

apps/auth/src/auth/ldap/index.ts
56.79% <65.90%> (ø)

libs/auth/src/createUser.ts
72.22% <84.61%> (ø)

apps/auth/src/routes/createUser.ts
83.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Make excessive uptime makefile parameterized

Other option to parameterize is in #5
Calling rpmbuild with EXCESSIVE_UPTIME_LIMIT_DAYS will change the value
of uptime check of the final RPM, e.g.:
make rpmbuild EXCESSIVE_UPTIME_LIMIT_DAYS=60

Add this info to readme and NOTE comment to the original actor file.

Better to provide the option to bake it into the build versus runtime env var. My vote is for this option over #5. Thanks!

Closing this PR in favor of #5

@swapdisk I think we can parameterize simple constants like the one in CheckRebootHygiene actor in this way going forward. Looks good to you?


Issues with googleservice_info_plist_path parameter

Issue Description
I cannot get googleservice_info_plist_path to work when using firebase_app_distribution on it's own lane.
I have lanes for provisioning, building and deploying separate and they are called at different times, thus not having a shared lane value for the Xcode archive location, so it doesn't matter what value I put into the plist path, the plugin will always fail to get the app id as it uses the shared lane values to get the archived path, and in my case it's always null.
Would be awesome if we could just pass the full path of the .app or for the actual plist file without depending on the archive path being there.
Configuration
	firebase_app_distribution(
      googleservice_info_plist_path: "GoogleService-Info.plist",
      service_credentials_file: "fastlane/credentials.json",
      ipa_path: options[:ipa],
      testers_file: "fastlane/testers.txt",
      debug: true
    )

Complete verbose output

Verbose Output
gmo@A0792-MS-GM app_dir % bundle exec fastlane deploy to:enterprise ipa:./build/app_staging.ipa
[✔] 🚀
+-------------------------------------------+---------+-----------------------------------------------------------+
|                                                  Used plugins                                                   |
+-------------------------------------------+---------+-----------------------------------------------------------+
| Plugin                                    | Version | Action                                                    |
+-------------------------------------------+---------+-----------------------------------------------------------+
| fastlane-plugin-aws_s3                    | 2.0.2   | aws_s3                                                    |
| fastlane-plugin-xcconfig_actions          | 1.4.2   | build_settings_to_flags, read_xcconfig, validate_xcconfig |
| fastlane-plugin-xcconfig                  | 2.0.0   | update_xcconfig_value, set_xcconfig_value,                |
|                                           |         | get_xcconfig_value                                        |
| fastlane-plugin-firebase_app_distribution | 0.2.9   | firebase_app_distribution_login,                          |
|                                           |         | firebase_app_distribution_get_udids,                      |
|                                           |         | firebase_app_distribution                                 |
+-------------------------------------------+---------+-----------------------------------------------------------+
19:15:45: --- Step: default_platform ---
19:15:45: ------------------------------
19:15:45: Driving the lane 'ios deploy' 🚀
19:15:45: -----------------------------
19:15:45: --- Step: setup_circle_ci ---
19:15:45: -----------------------------
19:15:45: Not running on CI, skipping CI setup
19:15:45: ipa: ./build/app_staging.ipa
19:15:45: dsym: output/gym/app_staging.app.dSYM.zip
19:15:45: ---------------------------------------------------
19:15:45: --- Step: Switch to ios deploy_to_firebase lane ---
19:15:45: ---------------------------------------------------
19:15:45: Cruising over to lane 'ios deploy_to_firebase' 🚖
19:15:45: path:  <<<<<<< path empty as SharedValues::XCODEBUILD_ARCHIVE is not present
19:15:45: ---------------------------------------
19:15:45: --- Step: firebase_app_distribution ---
19:15:45: ---------------------------------------
19:15:45: -------------------
19:15:45: --- Step: is_ci ---
19:15:45: -------------------
+------------------+------------+
|         Lane Context          |
+------------------+------------+
| DEFAULT_PLATFORM | ios        |
| PLATFORM_NAME    | ios        |
| LANE_NAME        | ios deploy |
+------------------+------------+
19:15:45: Missing app id. Please check that the app parameter is set and try again
+------+---------------------------------------+-------------+
|                      fastlane summary                      |
+------+---------------------------------------+-------------+
| Step | Action                                | Time (in s) |
+------+---------------------------------------+-------------+
| 1    | default_platform                      | 0           |
| 2    | setup_circle_ci                       | 0           |
| 3    | Switch to ios deploy_to_firebase lane | 0           |
| 💥   | firebase_app_distribution             | 0           |
| 5    | is_ci                                 | 0           |
+------+---------------------------------------+-------------+
19:15:45: fastlane finished with errors
Looking for related GitHub issues on fastlane/fastlane...
➡  DELIVER (2.150.0.rc3/4) always ask attribute whatsNew
https://github.com/fastlane/fastlane/issues/16700 [open] 91 💬
a day ago
➡  [iTunes Transporter]: Read Timed Out - unable to upload app to TestFlight
https://github.com/fastlane/fastlane/issues/16892 [open] 60 💬
2 days ago
➡  Fastlane produce fails with error, but appears to still create the app on App Store Connect
https://github.com/fastlane/fastlane/issues/18794 [closed] 8 💬
5 weeks ago
and 117 more at: https://github.com/fastlane/fastlane/search?q=Missing app id. Please check that the app parameter is set and try again&type=Issues&utf8=✓
🔗  You can ⌘ + double-click on links to open them directly in your browser.
Traceback (most recent call last):
36: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/bin/ruby_executable_hooks:22:in <main>' 	35: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/bin/ruby_executable_hooks:22:in eval'
34: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/bin/fastlane:23:in <main>' 	33: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/bin/fastlane:23:in load'
32: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/bin/fastlane:23:in <top (required)>' 	31: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/cli_tools_distributor.rb:122:in take_off'
30: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/commands_generator.rb:42:in start' 	29: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/commands_generator.rb:353:in run'
28: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/delegates.rb:18:in run!' 	27: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in run!'
26: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/runner.rb:444:in run_active_command' 	25: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:157:in run'
24: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:187:in call' 	23: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/commands_generator.rb:109:in block (2 levels) in run'
22: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/command_line_handler.rb:36:in handle' 	21: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/lane_manager.rb:47:in cruise_lane'
20: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:45:in execute' 	19: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:45:in chdir'
18: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:49:in block in execute' 	17: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/lane.rb:33:in call'
16: from Fastfile:167:in block (2 levels) in parsing_binding' 	15: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/fast_file.rb:159:in method_missing'
14: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:146:in trigger_action_by_name' 	13: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:204:in try_switch_to_lane'
12: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/lane.rb:33:in call' 	11: from Fastfile:181:in block (2 levels) in parsing_binding'
10: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/fast_file.rb:159:in method_missing' 	 9: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:157:in trigger_action_by_name'
8: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:229:in execute_action' 	 7: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:229:in chdir'
6: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:255:in block in execute_action' 	 5: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/actions/actions_helper.rb:69:in execute_action'
4: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:263:in block (2 levels) in execute_action' 	 3: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-plugin-firebase_app_distribution-0.2.9/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb:21:in run'
2: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-plugin-firebase_app_distribution-0.2.9/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb:82:in app_id_from_params' 	 1: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane_core/lib/fastlane_core/ui/ui.rb:17:in method_missing'
/Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane_core/lib/fastlane_core/ui/interface.rb:129:in `crash!': \e[31m[!] Missing app id. Please check that the app parameter is set and try again\e[0m (FastlaneCore::Interface::FastlaneCrash)

Environment

Library
Version

fastlane
2.191.0

fastlane-plugin-firebase_app_distribution
0.2.9

I'm going to close this issue for now, but please fill out a Firebase feature request (https://firebase.google.com/support/troubleshooter/report/features) if you are still interested in this functionality!

Hi, I came up with a simple solution using other Fastlane command line :
appID = get_info_plist_value(path: "./#{GEN_DIR}/../MyApplication/Configuration/GoogleService-Info.plist", key: "GOOGLE_APP_ID")
ipa_file_name = "#{file_name}.ipa"
dsym_file_name = "#{file_name}.app.dSYM.zip"

 appID = get_info_plist_value(path: "./#{GEN_DIR}/../MyApplication/Configuration/GoogleService-Info.plist", key: "GOOGLE_APP_ID")

  release = firebase_app_distribution(
      app: "#{appID}",
      testers<EMAIL_ADDRESS>      release_notes: "#{RELEASE_NOTE_CONTENT}",
      ipa_path: "./#{GEN_DIR}/#{ipa_file_name}"
  )

  upload_symbols_to_crashlytics(dsym_path: "./#{GEN_DIR}/#{dsym_file_name}",  gsp_path: "./#{GEN_DIR}/../MyApplication/Configuration/GoogleService-Info.plist", binary_path: "./#{GEN_DIR}/../Pods/FirebaseCrashlytics/upload-symbols")


update nuget 9 beta

Hi, would it be possible to push a new nuget with the latest PRs?  I'd like to update to 8 in https://github.com/dotnet/corert but want the DI stuff.  Thanks.

Sorry, mean 9 beta, not 8.

This has now been uploaded: https://www.nuget.org/packages/LLVMSharp/9.0.0-beta

Thanks!


build!: Monthly maintenance (Jun 2022)

Drop Python 3.6 support and introduce Python 3.11 support.
On top of that:

Use Python 3.10.5 as dev version
Bump dependencies to their latest versions
Use tomllib when available
Drop toml lib from tests in favor of tomli_w

Coverage increased (+0.02%) to 97.167% when pulling baf6fcfd461969d021af2974179ac84853849254 on build/mon-maintenance-2022-06 into 66288c24ec7dd7fc25dfad1793815fd7e6e788ac on master.


Parse rtype as the return type

Parse rtype as the return type. Example for the python kubernetes client:
    def metadata(self):
        """Gets the metadata of this V1Namespace.  # noqa: E501

        :return: The metadata of this V1Namespace.  # noqa: E501
        :rtype: V1ObjectMeta
        """
        return self._metadata

is this a docstring issue?

If you type ns.metadata. hoping to have vscode autosuggest the fields of metadata it will only suggest the generic python object fields.

You will need to add a return type annotation for the metadata method or a variable type annotation for the metadata instance variable.

According to python kubernetes it's auto generated by OpenAPI Generator.

I suggest log an issue with them, asking for a return type annotation

you could try generating  your own type stubs for the kubernetes package locally as well.
see https://github.com/microsoft/pyright/blob/main/docs/type-stubs.md#generating-type-stubs
# pyright: reportMissingTypeStubs=true


hidden attribute does not always work for shadow dom

Description
The 'hidden' attribute does not work on polymer elements inside other polymer elements when using shadow dom.  Works as expected with shady dom, tested on Chrome 51.
The browser inspector shows two important style selectors when using shadow DOM:
:host {
  display: block;
}
paper-input[Attributes Style] {
  display: none;
}

The :host selector is used over paper-input[Attributes Style].
CSS when using shady DOM:
[hidden] {
  display: none!important;
}
.paper-input-0 {
  display: block;
}
paper-input[Attributes Style] {
  display: none;
}

With shady DOM the [hidden] selector applies first, if that is disabled with the inspector then .paper-input-0 applies.
Live Demo
https://jsbin.com/tiyohitoxi/edit?html,output

To anyone who is having this issue, you can work-around by adding the following to a global stylesheet:
body /deep/ [hidden] {
  display: none!important;
}

Note that /deep/ is deprecated, but it works.

The root issue here is how the hidden attribute works in css. It has very low specificity and any other display setting will override it. It's unfortunate that iron-flex-layout addresses this issue in a way that is incompatible with Shadow DOM. There's a tracking issue for this with more information here: https://github.com/PolymerElements/iron-flex-layout/issues/86.
If you want the hidden attribute to enforce that an element is actually display none, you can include a style inside your element that does:
[hidden] {
  display: none !important;
}


Update to otel4s 0.5.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.94%. Comparing base (f6b880d) to head (0c654d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage   83.94%   83.94%
=======================================
  Files         138      138
  Lines        2136     2136
  Branches      243      243
=======================================
  Hits         1793     1793
  Misses        343      343

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


:bug: Fix arch detection for Mac arm in install-kcp-with-plugins.sh

Summary
Improve automatic arch detection to include the $HOSTTYPE reported by arm-based Macs
Related issue(s)
#971
#979
Fixes #
#971
#979

/lgtm

/approve


Drop node 0.10 and 0.12 from Travis tests

Fixes #64

I'm not sure why node 8 + npm 5 are having difficulty installing the github dependency on v8-argv on Travis... node 8 + npm 5 handle it fine locally for me


Improvements from #1776

Just noticed that I added some small improvements to #1776, which should make it to master quickly.

concretely type fields in Pattern
remove fxaa=false hack for transparency (should work now with OIT etc)
add propertynames for plot like objects (can't believe we haven't done this in all these years)

Compile Times benchmark
Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than master. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:
using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))

using
create
display
create
display

GLMakie
–
–
–
–
–

master
–
–
–
–
–

evaluation
–
–
–
–
–

CairoMakie
11.19s (10.34, 11.61) 0.55+-
22.66s (21.08, 23.42) 1.07+-
3.41s (3.14, 3.52) 0.17+-
18.86ms (17.37, 19.92) 1.03+-
23.63ms (21.56, 24.49) 1.39+-

master
11.18s (10.36, 11.54) 0.56+-
22.60s (20.94, 23.45) 1.11+-
3.43s (3.18, 3.63) 0.17+-
19.03ms (17.62, 19.41) 0.64+-
24.07ms (21.66, 24.60) 1.07+-

evaluation
+0.04%, 0.0s invariant (0.01d, 0.99p, 0.56std)
+0.25%, 0.06s invariant (0.05d, 0.93p, 1.09std)
-0.86%, -0.03s invariant (-0.17d, 0.75p, 0.17std)
-0.91%, -0.17ms invariant (-0.20d, 0.72p, 0.83std)
-1.85%, -0.44ms invariant (-0.35d, 0.52p, 1.23std)

WGLMakie
–
–
–
–
–

master
–
–
–
–
–

evaluation
–
–
–
–
–


Tailwind classes in Components

Hello,
changed everything from twind to tailwind.
Maybe it could be documented that currently all classes in components need to be named explicitly.
Let's say I have an encoded link component for mailto: or tel: links and it has
interface {
  type?: 'mail'|'phone'
}

This will not work:
  <a class={`redaktor-link-${type}`}>

but this would
  <a class={type === 'phone' ? `redaktor-link-phone` : `redaktor-link-mail`}>

Not sure if this could be done with the reflection API or if there are better ideas :)

Good point, compared to twind, tailwind analyses the source code instead of running it. It cannot detect split up tailwind class names. We should add a note for that in our docs.

If we have more class-choices than just two, one can also create a plugin, see
https://tailwindcss.com/docs/plugins#dynamic-utilities
Done that a lot, works fine, got e.g.: baseline solid typo and ui variants and all the colors and ActivityPub stuff.
Will keep you updated :)


README.md: More explicitly describe what this does

thx, I'm writing down a more detailed intro but this looks good now


Reduce motion estimation search step from 2 to 1

Implement motion compensation interpolation filters since chroma
may now require half-sample interpolation

PSNR
PSNR Cb
PSNR Cr
PSNR HVS
SSIM
MS SSIM
CIEDE 2000

-11.2091
-8.1693
-8.0315
-11.7122
-11.5181
-12.1632
-9.3109

Tested locally for -s 0 and 1, and all good.


Enhancement/docs and mvvm design

Description:

Closes #134
Fix #138
Resolves #141

Tasks:

Moved presentation logic to Views instead of ViewModels.
Updated view model states to reuse networking states while having context specific cases.
Improved replace root animation that looked weird.

Risk:

Medium

I vote to invalidate the two remaining code climate issues