Use label "deferred" instead of closing issues.

Hey @ariya I recently noticed that you are now closing most of the newly opened issues saying that if the project revives, they can be revisited later. However, if this project is revived later, it is highly unlikely that someone would go to the trouble of triaging already closed issues for issues that needed revisiting.
It would have been better if GitHub had natively supported a middle ground between open and cloed issues for such a usecase, but in the lack of such a feature, it makes more sense to instead create a new label names "deferred"/"to-revisit" and NOT close the issue so that it remains in the view of someone looking at open issues to solve.

Thanks @aero31aero! Do you have some examples of issues which should be tagged as Deferred?
Note that for a long time we already adopt the policy of not closing an issue if there is a remote chance it might be looked at. This doesn't help. Long story short: issues piling up, people complain even more, nobody volunteers to triage, the cycles continue (see #14541, and perhaps #14548).
Time to experiment with the opposite approach: unless it's actionable (i.e. there is a clear follow-up plan), let's close it. It's easy enough to reopen it if (1) someone cares, or (2) someone else steps up and offers help.
Either approach can't please everyone. But now, let's try an approach that is optimized for the maintainer's time.

I'll have to apologize for not being familiar with PhantomJS's codebase- I've only used it as a part of Casper for frontend tests or for playing around with headless browsing and the recent archiving news brought me here.
I'll try to give some examples of issues from the recently closed ones that could be looked at in the future, i.e., are candidates for keeping open:

#15337 is a bug report that, if the development continues from the current 'dev' branch, would be relevant. If the development continues from the current stable 2.1 then perhaps not relevant.
#15320 points out that build instructions for the current version are outdated. Perhaps a rename of the issue to "Update build instructions for current version" and reopening could be useful as this seems like an easy task for a contributor who regularly builds phantom to update the website/docs regarding this.
#15326 was tagged with "bug" and "confirmed" so it sounds like a TODO for when reviving the project later. This is kind of what I'm talking about. Unless this person reopens the issue or someone else files another issue, this bug report might go unnoticed by someone contributing to the project later.

I believe (and this is my own observation) that closing an issue is akin to permanently hiding it, so even if the number of open issues keeps piling up, its better to have a simple tagging system for the contributors to filter issues by and find something to work on. For example, someone could easily hide all issues labeled 'deferred' when looking for something to work on, and the count of open issues is just a number that is relevant perhaps at a first look only, not in long term contributing.
I would have liked to help triage some issues for you, but I'm unfamiliar with the codebase. I believe there might be others out there who could perhaps at least take up the job of just managing the issues if not managing the code.

Those three issues you mention only applied to version 2.1.3, which is abandoned (not to mention that it was done rather haphazardly, ignoring semantic version, no added tests, zero care for the multi-platform nature, etc). There is no point of revisiting that, see also #15344. If you think that it is not the case, please post your finding directly to each issue and I will take a look, that'll be appreciated.
Of course closing the issue means hiding it. It's just a flag anyway. Any serious contributor can search for issues they want to work on, ignoring this one-bit flag (open vs close). However, the high count of open issues proved to be demotivating for first-time helpers and incite negative drive-by comments. And I said, it's cheap enough to reopen an issue or recreating it.
Again, let's try to optimize things based on the past experience here, not an ideal hypothetical situation. I'm willing to reconsider the approach "keep the issue open" if you can write a more structured summary on the pros and cons, along with the user stories and such, and also based on what has happened in the PhantomJS land.
Take a look at #14543 and #13861 as well.

@ariya have you thought about starting an indiegogo campaign to get funds necessary to help with the progression of the project?
The JUnit team managed to raise 50,000 euros to fund development of JUnit 5.
Other potential options are donating the project to Apache, Eclipse, Linux Foundation, or other similar organizations.

@behrangsa To stay on-topic, perhaps add your suggestion to ##13861 instead? Thanks.

Closing this for now, since we're experimenting with reducing maintainer's burden. Thanks!


Set up process for tracking Q2 IBC work

Completed via:

This repo
These milestones: https://github.com/informalsystems/apalache-team-services/milestones
This project board filer: https://github.com/orgs/informalsystems/projects/30/views/20


[FLINK-29093][table] Fix InternalCompilerException in LookupJoinITCas…

What is the purpose of the change
This is a backport of PR 20734
Fixed unstable test LookupJoinITCase with Full cache
Brief change log

Avoided concurrent creation of Projection object from generated code
Fixed closing logic, so now close method waits until current reload is over+ there can't be another reload after closing
Reset resource counter in LookupJoin IT cases before each test, so if one will be failed, other ones will not be affected by that

Verifying this change
This change is already covered by existing tests, such as LookupJoinITCase.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented?  not documented)

The CI failed because of an unrelated issue FLINK-29315. Merging to release-1.16


Update scaling-deployments.md

Added quotes as a string is required instead of an integer

Ignore this. I made a booboo I was storing these values under metadata (spec.triggers.metadata.maxReplicaCount) of course this accepts a string. Works fine if I use the proper configuration(ScaledObject.spec.).
Apoligies!


Rename Laplace_diff to LMRF, library, demos and paper notebooks

Note by @amal-ghamdi
This update was implemented in CUQIpy library in PR #https://github.com/CUQI-DTU/CUQIpy/pull/229
in demos in PR #https://github.com/CUQI-DTU/CUQIpy-demos/pull/62
and in paper 1 notebook repository in PR #https://github.com/CUQI-DTU/Paper-CUQIpy-1-Core/pull/15
Also Laplace_diff is not used in paper 2.

@jakobsj, @nabriis
This issue was resolved in the merged PRs above. No need for code update here I believe. (changing status to in review)

LGTM

Sounds good, please close.


fix(chat): fix new conversations model selection (Issue #2684)

Description:
fix new conversations model selection
Issues:

Issue #2684

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review


Task Detail page - Basic navigation

On click of task in listing page, it should take to the task detail page. Detail page should be displaying

Title
Content
Expected timestamps
Actual timestamps
Status
Progress bar
Comments
Created time
Task type

Implemented


Write article about occurrences api

A blog article or VZG report would be nice because the API can also be of use indepenently. The article could also cover background of creating the data (PICA+ dump, k10plus-subjects...) or be about analysis of K10plus subject indexing in general. Requires #19 because people prefer UI and screenshots.

Start with a blog article about new APIs (Occurrences-API and Mapping-Inference) later extend to full article.


Move error and loading states into collection table body to make errors more recoverable

Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

Current dependencies on/for this PR:

master

PR #4251

PR #4363
PR #4305

PR #4361

PR #4395   👈

PR #4312

PR #4281

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

master

PR #4251

PR #4363
PR #4305

PR #4361

PR #4395   👈

PR #4312

PR #4281

This comment was auto-generated by Graphite.


Red video camera icon

Is there any way to run this code without the annoying flashing red video camera icon in the top left corner of my FOV?

I am testing the example with Hololens1 and there is no red video camera icon like this one.
This problem seems to be related to the MediaStreamType property according to camnewnham's post.
https://github.com/VulcanTechnologies/HoloLensCameraStream/pull/51#issue-219243602

I set it to VideoPreview because somebody said VideoRecord is much slower. I will try VideoRecord. Thanks.


RL model cannot apply this toolbox

Is your feature request related to a problem? Please describe.
The ART can only accept the classifier trained by ART itself?
Describe the solution you'd like
When I try to apply the attack algorithm on the RL policy, I got the error below:
TypeError: For FastGradientMethod classifier must be an instance of art.classifiers.classifier.Classifier, the provided classifier is instance of (<class 'stable_baselines.common.base_class.OffPolicyRLModel'>,).
Describe alternatives you've considered
Does this mean that ART does not accept the model trained from outside?
Additional context
Add any other context or screenshots about the feature request here.

Hi @QuXinghuaNTU Thank you for using ART!
ART does accept trained models as input to its classifiers. From the error message that you have shared above it looks like you are providing a model class 'stable_baselines.common.base_class.OffPolicyRLModel' directly to an attack FastGradientMethod. You have to first wrap your model inside an ART classifier (art.classifiers.classifier.*). The specific classifier type depends on your machine learning framework, e.g. art.classifiers.classifier.PyTorchClassifier for PyTorch, etc.

I use the code below to transfer the RL model to ART model. It works.
`
your_RLmodel.load_weights("your_model.hdf5")
this line change your model to ART model
classifier = KerasClassifier(model=your_RLmodel)`


bug on empty value seach to 'user' property

eg. assignee= results nothing.

Done by 9ddb1ec1bb24945640a698a5bd7cb3b0758d26fe


protonvpn-gui: 4.7.4 -> 4.8.0

Update protonvpn-gui and all it's dependencies to the latest released version.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I will leave this PR in draft until I can properly verify all functions.

I've added the correct platforms for proton-vpn-network-manager and proton-vpn-api-core.


doc: update doc of benchmark (#200)

@orangle https://github.com/iresty/apisix/blob/master/doc/benchmark-cn.md
need to update the Chinese doc too.

OK

https://github.com/iresty/apisix/issues/354
we can use the benchmark result of version 0.6 ^_^.


Mlp image classification port to backend agnostic

While moving these mlp based models to backend agnostic, I still faced the same error with with F-Net (Which includes fft layer ) as raised in #566 for PyTorch backends.

Thanks for the PR! The cross-backend compatibility issue was resolved by @guillaumebaquiast earlier.


refactor: separate format and encode in StreamSourceInfo

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

as title. But old version of StreamSourceInfo is still supported.
clean redundant code.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR contains user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

compatible with main branch.


Not able to sync with "latest" node

Hello,
Thanks for this project, it looks really good, and can help us to make this blockchain really scalable.
We have an issue with the "latest" node. When we try to start it, we have this kind of logs :
t=2021-11-08T16:07:35+0000 lvl=eror msg="header not found"                       peer=65b37e4e hash=0x826b4960ae94cbe207062b3a40c640f2d991ee1e7eec2b29cb9cf3ec59b50308 request=12,247,914
t=2021-11-08T16:07:35+0000 lvl=warn msg="Synchronisation failed, dropping peer"  peer=65b37e4e487ac686cf3cc4ac458fce9097951b865a2f45b65b71d02ba4e76c97 err="action from bad peer ignored: header no found (0x826b4960ae94cbe207062b3a40c640f2d991ee1e7eec2b29cb9cf3ec59b50308)"
t=2021-11-08T16:07:35+0000 lvl=eror msg="Ethereum peer removal failed"           peer=65b37e4e err="peer not registered"
t=2021-11-08T16:07:37+0000 lvl=eror msg="header not found"                       peer=6fae5c22 hash=0x7daf31669962d5f19cca502dc0f083a16ff1fd033acae633533ad1d6d3a14071 request=12,247,912
t=2021-11-08T16:07:37+0000 lvl=warn msg="Synchronisation failed, dropping peer"  peer=6fae5c226044bef3bd616aea57a23eb04a765339c2a3251af1578178ac81d367 err="action from bad peer ignored: header no found (0x7daf31669962d5f19cca502dc0f083a16ff1fd033acae633533ad1d6d3a14071)"
t=2021-11-08T16:07:37+0000 lvl=eror msg="Ethereum peer removal failed"           peer=6fae5c22 err="peer not registered"
t=2021-11-08T16:07:39+0000 lvl=eror msg="Snapshot extension registration failed" peer=af5dfeb7 err="peer connected on snap without compatible eth support"
t=2021-11-08T16:07:39+0000 lvl=eror msg="header not found"                       peer=baa7e4a5 hash=0x53e92acf3f98d7845d42320d3c1abe58a0d658c19842e10a3386ba5b4b362961 request=12,247,911
t=2021-11-08T16:07:39+0000 lvl=warn msg="Synchronisation failed, dropping peer"  peer=baa7e4a5b4297b9ab03afd839eb2347ba2032165cd543ddae3a45644a1304bab err="action from bad peer ignored: header no found (0x53e92acf3f98d7845d42320d3c1abe58a0d658c19842e10a3386ba5b4b362961)"
t=2021-11-08T16:07:39+0000 lvl=eror msg="Ethereum peer removal failed"           peer=baa7e4a5 err="peer not registered"
t=2021-11-08T16:07:58+0000 lvl=eror msg="Snapshot extension registration failed" peer=85f71f39 err="peer connected on snap without compatible eth support"

And the blockchain don't start to sync. All others nodes for others block ranges looks working well.
Do you have an idea ?
Regards,
Denis

Oops, looks like the last slice I created I made a mistake and it uploaded a bad file and didn't restart properly.
It does work locally, and I restarted it. It should be uploading now (it takes about 3-4 hours to upload the latest version).
Current block is 12329505 (~5d 8h behind). It'll probably take about 3-5 days to catch up again.
Thanks for letting me know!

This has been fixed.


WireMock 2.7.0 requires usage of Jetty on the client side

Hi!
I'm trying to bump SC-Contract to WireMock 2.7.0. We're excluding Jetty from WireMock from the very beginning so that people can use whatever server Boot provides. Much to my surprise it turned out that after bumping things blow up
java.lang.NoClassDefFoundError: org/eclipse/jetty/http/HttpStatus

    at com.github.tomakehurst.wiremock.client.HttpAdminClient.safelyExecuteRequest(HttpAdminClient.java:382)
    at com.github.tomakehurst.wiremock.client.HttpAdminClient.executeRequest(HttpAdminClient.java:368)
    at com.github.tomakehurst.wiremock.client.HttpAdminClient.addStubMapping(HttpAdminClient.java:110)
    at com.github.tomakehurst.wiremock.client.WireMock.register(WireMock.java:265)
    at com.github.tomakehurst.wiremock.client.WireMock.register(WireMock.java:260)
    at org.springframework.cloud.contract.stubrunner.provider.wiremock.WireMockHttpServerStub.registerHealthCheck(WireMockHttpServerStub.java:172)

It's kind of a breaking change to require that dependency isn't it? Also HttpStatus sounds like a class that you can copy and ditch the Jetty dependency fully.

Which version of Jetty are you running with? I did wonder about the wisdom of using this class, but it didn't seem all that likely it'd change frequently.
Agree it'd be better to pull out a copy of it for WireMock to own. I'll do that and push it out in a patch release.

Fixed in 4e7d5256437d9e546ca66d136f36813078e2eae3

That's the thing - I'm not running against any version of Jetty - it's excluded. I saw the fix - looks perfect :)

Doesn't SB pull in its own version of Jetty? I'm at a loss as to how you'd be able to run WM at all with it excluded otherwise.


docs: consumer-pull transfer README update

Setting up a data plane on the consumer is not required, both sink and source are on the provider side
Coherent case for paragraph titles

What this PR changes/adds
README for consumer-pull http transfer updated.
Why it does that
To provide a leaner setup configuration.

please fix the PR title and I will merge this

Fixed, thank you


csharp: Remove tests of generated code

These tests are broken due to changes in underlying generated code. We probably don't need tests for the generated code, anyway, so removing.

Added back in a couple application tests that weren't asserting calls to generated api.


Added support for a CHATBOT_UI_PORT env var.

This is particularly helpful when running locally and you have other next.js or ruby on rails projects running that also use port 3000 by default.  If CHATBOT_UI_PORT env var is not provided then it defaults to port 3000.

Agree that it's helpful, but it's a simple enough add that we'd prefer individuals users make that change on their own as we want to keep the env file uncluttered.


Cleanup: Added some logging and prevented checkpointing threads from quitting

Merging this since it's a small change that will help make progress on making tests pass (allows to run all tests even if some fail)


Marking Jenkinsfile as deprecated since it is no longer needed

@dcrossleyau could you please add SONAR_TOKEN var to the repo?

oh, probably it's because of @ryandberger created it from fork, @dcrossleyau please ignore request above

@ryandberger closing this request as https://github.com/folio-org/ui-plugin-query-builder/pull/7 opened instead


The method 'dispose' was called on null

Hi, thank you for that awesome library!
I have a bottom tab bar, as soon as I navigate to another screen I get the following issue. My motion widget usage is:
        Motion<Column>(
          durationMs: 1000,
          children: <Widget>[
            MotionElement(
              child: TrainingUnit(),
              interval: Interval(0, 1),
            ),
            MotionElement(
              child: TrainingUnit(),
              interval: Interval(0.3, 1),
            ),
            MotionElement(
              child: Center(
                  child: PrimaryButton('Zum Workout', () {
                Navigator.push(
                    context,
                    MaterialPageRoute(
                        builder: (_) => PreparationScreen(),
                        fullscreenDialog: true));
              })),
              interval: Interval(0.6, 1),
            ),
          ],
        ),

Error Log:
════════ Exception caught by widgets library ═══════════════════════════════════
The following NoSuchMethodError was thrown while finalizing the widget tree:
The method 'dispose' was called on null.
Receiver: null
Tried calling: dispose()

When the exception was thrown, this was the stack
#0      Object.noSuchMethod  (dart:core-patch/object_patch.dart:53:5)
#1      _MotionState.dispose
package:motion_widget/motion_widget.dart:152
#2      StatefulElement.unmount
package:flutter/…/widgets/framework.dart:4435
#3      _InactiveElements._unmount
package:flutter/…/widgets/framework.dart:1748
#4      _InactiveElements._unmount.<anonymous closure>
package:flutter/…/widgets/framework.dart:1746
...
════════════════════════════════════════════════════════════════════════════════

I just tried to provide a PR with a fix but was not able to find the soure codes. This seems to be the demo projet only..
My change was:
motion_widget.dart line 152:
widget.motionController?.dispose();

Hi @obrunsmann, thanks a lot for hunting down the bug. I'll soon replace the demo with the actual source code and then you can submit the PR. I'll be happy to accept it. Will let you know once I'm done making the required change.

I've replaced library dependency with its source code.


Incorrect severity score due to identical Reference URLs

When multiple distinct scores have the same reference URL, we end up overwriting the VulnerabilitySeverity.
See the SUSE example below, where different vulnerabilities have identical sets of severity.

The bug is in how we handle the VulnerabilityReference. Each VulnerabilityReference has a URL that is set to be unique. To store a severity for vulnerability, we create a VulnerabilityReference (using the source URL of score) and then create a VulnerabilitySeverity (with severity details and ForeignKey relationship to VulnerabilityReference created earlier). Since the URL field is set to unique, things get complicated in the case of SUSE as all the scores come from the same URL i.e. "https://ftp.suse.com/pub/projects/security/yaml/suse-cvss-scores.yaml." This results in a single SUSE VulnerabilityReference linked to all vulnerabilities, which leads to a same set SUSE severity score for all vulnerabilities.
This might not be limited to SUSE alone, there is a high chance that other severity scores were also overwritten.

Refrence https://github.com/aboutcode-org/vulnerablecode/issues/1592#issuecomment-2367567816

We should have severity on vulnerability and package-vulnerability relationship if we don't have severity on the package-vulnerability relationship then we should use only the vulnerability severity.

Start with tests to see what's breaking
Refactor VulnerabilitySeverity models, disassociate severity from reference. And attach severity on vulnerability and package-vulnerability relationship

Blocked by this https://github.com/aboutcode-org/vulnerablecode/pull/1612

Here are a few practical todos:

disable the the display of score ranges in the VCIO and DJCD web ui, remove it from the APIs
The "Package vulnerability risk" index designed in https://github.com/aboutcode-org/vulnerablecode/issues/1543 will be the way to go and is under review in https://github.com/aboutcode-org/vulnerablecode/pull/1593

@nnobelis Thanks for pointing this out. This has now been fixed in #1636. The correct SUSE score should be available on https://public.vulnerablecode.io/ after the next release.

Before
After

Before
After


Webpack integration

introduces webpack/babel/es6 workflows into the boilerplate
actually at this point we might want to create a separate boilerplate out of this. it's getting a little bit too complex for common needs
stuff missing so far:

[ ] docs
[x] tests setup
[ ] full blown npm integration (removal of libs/plugins that are now in libs)

Coverage decreased (-40.9%) to 56.25% when pulling 9082b25b91eb1afe54d7bf3da9a7614c195b7b1f on feature/webpack-integration into ca63eb3d318be7ed4274d44bd51551b4741fff1b on master.

Coverage decreased (-40.9%) to 56.25% when pulling 60606a0591882a257479c848716a3f1f7fcc18ce on feature/webpack-integration into c52f4aa130feac8940ed3b10f5f424204d7a5eb9 on master.

Coverage decreased (-40.9%) to 56.25% when pulling ceee02b55ebfa8e2addb3712a63001a49100e4ec on feature/webpack-integration into c52f4aa130feac8940ed3b10f5f424204d7a5eb9 on master.

Coverage decreased (-9.6%) to 87.5% when pulling c2f9131be32c3534af42a05cb04c1a797c03b660 on feature/webpack-integration into c52f4aa130feac8940ed3b10f5f424204d7a5eb9 on master.

Coverage decreased (-9.6%) to 87.5% when pulling 1a76ba0ceee2f94f9ceba2d1cf75a25d9548d082 on feature/webpack-integration into c52f4aa130feac8940ed3b10f5f424204d7a5eb9 on master.

This will be separate boilerplate


Update Publisher & PackageName for Nvidia.Broadcast (on RTX devices) to match Control Panel

Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-No-Executables


Add panos provider

This PR adds support for the PAN-OS Terraform Provider. It works only with firewalls for the moment, not Panorama. I didn't test it in an environment with VSYS.

@Trois-Six thanks!!!


workbox-window's getSW() should resolve with shift-reload

Library Affected:
workbox-window
Browser & Platform:
"all browsers"
Issue or Feature Request Description:
When there is an active service worker and a user does a shift  reload. the getSW() promise never resolves.  I would expect it to return the active (but not controlling) service worker.
The docs say:

If, at registration time, there's already an active or waiting service worker with a matching script URL, it will be used...

In the case of a shift reload with an existing active service worker, there is an active service worker at registration time with a matching script URL.
More specifically, in Workbox#register, _registration.active will be set to the worker.  At the same time navigator.serviceWorker.controller will be falsey. This combination is not handled by Workbox#register.
I'm trying to use Workbox#getSW() so I don't need to look at the installing, waiting, and active fields of the registration just to find the service worker. In order to handle this shift reload case, I need still need to check these fields.

A related issue happens when the page is reloaded while a first time service worker is installing. In the reloaded page navigator.serviceWorker.controller will be falsey, and _registration.installing will be set. Workbox#getSW() does not resolve for basically the same reason as above.
Additionally the registration updatefound event won't fire because the service worker was in the installing state before the page was reloaded. So the _onUpdateFound handler also won't have a chance to resolve getSW().

Regarding the first comment, yes, that makes sense, and sounds like a bug in our current implementation. I believe that we should resolve both getSW() and the active promise when there's already an active service worker associated with the current registration that isn't in control of the current page, i.e. because someone shift-reloaded. That matches the documented behavior, so I would categorize this as a bug fix, rather than a breaking change.
Regarding the second comment, this is a bit trickier, because it falls into the category of what workbox-window treats as an "externally triggered" update:
https://github.com/GoogleChrome/workbox/blob/2ddef47bbd8a44d3e1ce5e8b13598e022b0b99c7/packages/workbox-window/src/Workbox.ts#L377-L380
We've moved away for much of the special treatment around "external" service workers in Workbox v6, but this is still something that I think we'd need to put more thought into before changing, and if it did change, would be considered a breaking change.

Hi there,
Workbox is moving to a new engineering team within Google. As part of this move, we're declaring a partial bug bankruptcy to allow the new team to start fresh. We realize this isn't optimal, but realistically, this is the only way we see it working. For transparency, here're the criteria we applied:

For PRs, we closed everything that doesn't target the current v7 branch.
For Issues, we closed everything that was created before 2024.

Thanks, and we hope for your understanding!
The Workbox team


Document how to write autograd-supported PyTorch function with CuPy

It is a common use-case to define PyTorch autograd functions with CuPy's RawKernel. It would be nice to cover that in the interoperability docs.
Schenario: define torch.autograd.Function, implement forward and backward using cupy.RawKernel (zero-copy using cupy.from_dlpack(toDlpack(tensor.detach()))), and use it from torch.nn.Module.

@cako #5973 shows an example of how to do this!

Super! 💯


Fixed code smells

Pull Request Test Coverage Report for Build 910090835

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.245%

Totals

Change from base Build 910076730:
0.0%

Covered Lines:
1315

Relevant Lines:
1324

💛  - Coveralls


fix: various fixes

Summary
Various fixes, including support for:

[x] minIdLength
[x] serverZone
[x] batch API (currently without count/size limits)
[x] callback support

Available as version v0.0.3
Checklist

[x] Does your PR title have the correct title format?
Does your PR have a breaking change?:  Yes

@justin-fiedler In Ampli codegen Variadic Functions are used to emulate optional parameter:
func (a *Ampli) Track(userID string, event Event, eventOptions ...EventOptions) {
	var options EventOptions
	if len(eventOptions) > 0 {
		options = eventOptions[0]
	}
	...

Usage:
ampli.Track(userId, event)
ampli.Track(userId, event, options)


Prevent dataloss due to the concurrent RPC calls (occurrence is very low)

This PR includes series for commits for the following actions

Introduce in memory lock for NodePublish and UnPublish (we should not be dependent on the CO and make assumption that CO makes the calls serial for the same volID and the targetPath)
Use os.Remove instead of os.Removeall to remove the empty directory, os.Removeall ends up removing everything in the path

Thanks to @martin-helmich  @hensur and @Lucaber for the detailed analysis
fixes: #4966

/test ci/centos/mini-e2e/k8s-1.31

/test ci/centos/mini-e2e/k8s-1.31

@mergifyio queue


Microsoft.Sql/servers/{servername}/databases (2017-10-01-preview)

Describe the noise
Resource type (i.e. Microsoft.Storage/storageAccounts)
Microsoft.Sql/servers/{servername}/databases
apiVersion (i.e. 2019-04-01)
2017-10-01-preview
Client (PowerShell, Azure CLI, or API)
PowerShell
Relevant ARM Template code (we only need the resource object for the above resourceType and apiVersion, but if it's easier you can include the entire template
  {
                    "type": "databases",
                    "apiVersion": "2017-10-01-preview",
                    "name": "[parameters('databaseName')]",
                    "location": "[parameters('serverLocation')]",
                    "dependsOn": [
                        "[concat('Microsoft.Sql/servers/', parameters('serverName'))]",
                        "[concat('Microsoft.Sql/servers/', parameters('serverName'), '/elasticpools/', parameters('elasticPoolName'))]"
                    ],
                    "tags": "[parameters('databaseTags')]",
                    "properties": {
                        "collation": "[parameters('collation')]",
                        "elasticPoolId": "[resourceId('Microsoft.Sql/servers/elasticpools', parameters('serverName') , parameters('elasticPoolName'))]",
                        "sampleName": "[parameters('sampleName')]",
                        "zoneRedundant": "[parameters('zoneRedundant')]",
                        "licenseType": "[parameters('licenseType')]"
                    }
                }

Expected response (i.e. "I expected no noise since the template has not been modified since the resources were deployed)
I expected no noise since the template has not been modified since the resources were deployed
Current (noisy) response (either include a screenshot of the what-if output, or copy/paste the text)

Additional context
Add any other context about the problem here.
check #21 for full template

Fix has been committed and is waiting on deployment. [w17]

pls, close it if you think it's fixed.

The fix should be deployed. Please reopen the issue if you still see this noise.


Filter search for digital items only

Filtering by item type would be useful.

Closing and merging this and similar issues into a Discovery issue that I'll make soon.

Regarding discovery, there's now duosear.ch


Use correct data type in Unix for siglongjmp

While attempting to build a Linux-based extension with the latest revision, it failed as the _JBTYPE type didn't exist. PG has different naming in some types and functions between POSIX and Windows. I missed this having different naming when pushed the PR for Windows support. After changing this, building a FDW for PG10 in Linux compiles successfully.

Thanks for following up on that! I noticed it as well and was fixing it in a different pr. I’ll merge this now.


Email checkbox on profile page now a set size

The size of the email checkbox would change based on the size of the window. A checkbox like that is so small that it doesn't need to be responsive, so I just set the size to a fixed rem. It will always look the size shown in the picture.

Closes https://github.com/microsoft/pxt-arcade/issues/5687

Thanks port to stable.


"name" property fails required check

{
  'properties': {
    'name': {
      'type': 'string',
    },
  },
  'required': ['name'],
}

No 'required property' error messages returned
{
  'properties': {
    'notname': {
      'type': 'string',
    },
  },
  'required': ['notname'],
}

"required property" error message returned
Also, I wonder if you could squeeze some more speed out by checking for the existence of the property before the format? It seems like other required properties are returning "format of property should be XXX" instead of just "property doesn't exist"

Works for me: https://tonicdev.com/esp/57be3188f18f321300ea7763
Could you please submit everything I asked for (ajv version, ajv options, schema, data, code)?

Also, I wonder if you could squeeze some more speed out by checking for the existence of the property before the format? It seems like other required properties are returning "format of property should be XXX" instead of just "property doesn't exist"

I don't understand that. Please submit the example. Sounds like a separate issue - a potential improvement? Only existing properties are validated at the moment, ajv wouldn't validate format of the property that doesn't exist if that's what you mean.

@braco could you please clarify?

@epoberezkin : Sorry about that. I rm'ed my node_modules, ran npm install again with the latest version and the error seems to have vanished. Must have been user error. Thank you for being so thorough as always.


running backbone tests with backbone-super

fixes #47

@lukasolson what about this? It's just fixed tests: backbone now runs its tests with karma and we should clone backbone for running tests because tests folder is in .npmignore

@michaelBenin do you have rights to merge it? Or any objections?

Looks good to me.


models.py def daily_above_threshold

Line 67: I don't think it outputs a boolean but I am not entirely sure
Why add 0?

@Sterre26  You can reference line numbers directly by clicking next to the line number

Return flag should be updated


[Settings> Save]: Shortcut key should be defined for 'Save' and 'Discard Changes' control inside Settings page.

Windows Terminal version
1.12.3472.0
Windows build number
10.0.22504.1010
Other Software
Test Environment:
OS: Windows 11 Version Dev (OS Build 22504.1010)
App: Windows Terminal Preview
Screen Reader: Narrator
Tool: Accessibility Insights for Windows Version 1.1.1741.1
Steps to reproduce
Repro Steps:

Open Windows Terminal.
Open Settings page using 'Ctr+,'.
Make some changes inside given tabs.
Verify that whether shortcuts is given to save or discard changes.

User Experience:
UX will not be good if Users like Keyboard only, Screen Reader users are not able Save or Discard changes fast.
Attachments:
Shortcut key should be defined for 'Save' and 'Discard Changes' control inside Settings page..zip
Expected Behavior
Shortcut keys should be defined for 'Save' and 'Discard Changes' control inside Settings page. Shortcut keys should also be included with 'Save' or Discard' button Accessible Name & Tooltip.
i.e. 'Ctrl+ S' to Save Changes and 'Ctrl + D' to Discard changes.
Actual Behavior
Shortcut key is not defined for 'Save' and 'Discard Changes' control inside Settings page. Users have to navigate to Save or Discard button in order to save or discard changes.

This one's curious. It would involve specific keybindings that are SUI-specific. That's fine, that makes sense, there are other keybindings that are already TerminalControl-specific, so that's not unreasonable. Binding them by default does get a little dicey. Imagine that someone's got ctrl+s bound currently to "new tab with Some profile" (as example). If we bound ctrl+s as "saveSettingsUI", then their binding for newTab would override that one. That seems fine, since the explicitly added that setting. It would just be a little confusing that they couldn't have both saveSettingsUI and toggleRetroEffect (for example) bound to ctrl+s. Each only works in one context (SUI vs TermControl), but only the last one in the user's settings would get bound.

INB4 Dustin and "this is why we need contextual keybindings"

In general, this doesn't seem totally impossible, so let's just go for it.


⚠ Bofrost.lu has degraded performance

In a4c5ca3, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2280 ms

Resolved: Bofrost.lu performance has improved in c3beda9 after 6 minutes.


Allow to use native WebSocket API with the plugin

Currently the plugin does not support using the native WebSocket API. In order to support new projects, we need to investigate, how we can make it work with the native API.
Todos:

Find a way to make it work with the native WebSocket API
Documentation
Use native API in the Cypress tests

That one-line change from win.MockedWebSocket to win.WebSocket has the native web sockets working on my project. It could be that you can do both and have rxjs and native working on the same code base.


incorrect "value not returned" error when a function has try catch

this error here is incorrect, coz I am throwing.

Nice one.


fix bottlerocket node-labels merge in user-data

Fixes #
https://github.com/aws/karpenter/issues/4013
Description

Fixes Node Labels merging in Bottlerocket's user-data.
Fixes invalid toml in docs

How was this change tested?

tested manually by:

adding labels that should be overridden like karpenter.sh/capacity-type and observed it being properly overridden.
adding labels that should not be overridden and observing them properly merged

make test

Does this change impact docs?

[ x Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Seems like this was missed because our ...golden was wrong. Should we assert that we have valid TOML in our test cases so that this doesn't creep in with something else?

wdym? The golden was valid toml, the docs were not

wdym? The golden was valid toml, the docs were not

Ooop. I got it. I misread the original issue. Yep, makes sense and looks good 👍


time="2020-07-20T06:26:36Z" level=error msg="Error opening memory series storage: sync /prometheus/labelpair_to_fingerprints: invalid argument" source="main.go:192"

Promethus version : 1.8.2
Linux machine
using Azure NAS file and mounted in linux  . can support azure NAS

/prometheus/labelpair_to_fingerprints does not seem familiar. Are you actually using v1.8.2 or did you mistype it for v2.8.2? (but I don't see a v2.8.2)

We have looked at this during our bug scrub. NFS is not a supported filesystem for Prometheus, which would explain your error. We also recommend you to upgrade to Prometheus 2.x: https://prometheus.io/docs/prometheus/latest/migration/


⚖ Register Validator: patric

Network Choice
nemeton-1
Who are you?
I'm patric, I've been in the crypto ecosystem since 2017.
gentx
{"body":{"messages":[{"@type":"/cosmos.staking.v1beta1.MsgCreateValidator","description":{"moniker":"patric","identity":"","website":"","security_contact":"pvan6701@gmail.com","details":""},"commission":{"rate":"0.050000000000000000","max_rate":"0.200000000000000000","max_change_rate":"0.010000000000000000"},"min_self_delegation":"1","delegator_address":"okp41euw8kg79077usejvfg6dwyfnff6ja60y8cafev","validator_address":"okp4valoper1euw8kg79077usejvfg6dwyfnff6ja60yjldq8d","pubkey":{"@type":"/cosmos.crypto.ed25519.PubKey","key":"8DvT6z3fKox4iUxuhm5L+YsD56YgxbjCMzCFPM0mN+0="},"value":{"denom":"uknow","amount":"10000000000"}}],"memo":"6d48ea4b6202a86ea024e5247e4302382d3dd9da@<IP_ADDRESS>:26656","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"A0XUZgDAAoiYroF7tr8Z8ThBqkoe914VjgQLlro6yKc5"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"0"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["3p5WtnZxPDrycKoEWaUCSeJ1YQi07+inAY9TFdeOS7s0ArNR1O5wLDhlN9NlnhERSbZ70kQpsqH9MhJ7zrg76w=="]}

😉 Here is the corresponding PR: https://github.com/okp4/networks/pull/501


What if Keycloak instance is down ?

Hello,
Running the starter project as an app in local development, If the keycloak instance the app is trying to connect is not running, the app stays in white screen for about 5 seconds and then shows an error about the jwt_decode unable to parse the token (this is right because the token isn't actually there).
The problem i found is that if i print the oidcClient in the App.tsx component, after the white screen it shows the property isUserLoggedIn with value true, but this should be false by default because the keycloak instance is down.
Anyone has experienced this issue ? Any idea on how to solve ?
Thank you.

Hello @PietroFalcetti,
I didn't accomodate for the Keycloak server to be down in the example code I give in the starter project.
Keep in mind that the part related to managing autentication with Keycloak in a React app is out of scope for this project.
Keycloakify is about generating themes.
I figured, however that it would be nice to have very simple end-to-end example this is why I provided the src/App directory and https://github.com/keycloakify/keycloakify-starter/blob/main/src/App/oidc.tsx.
If this code dosen't fit your need feel free to change it so it returns isUserLoggedIn: false when keycloak is down.
I wont make this example any more sophisticated because I want the example code to remain readable and to the point.
Best regards


[AutoPR operationalinsights/resource-manager] Add gateways API

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5182

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/686


Add<EMAIL_ADDRESS>to Web Analytics for openfga.dev

https://github.com/cncf/toc/issues/921

@rhamzeh is this something you can help with? Do we have our own analytics account?

We do not have analytics beyond the anonymized ones provided by Cloudflare.
We do need to transfer the domain I assume? If we are transferring to Cloudflare, we have to re-setup analytics there, other registrars don't have that ability.
Are we required to setup analytics? If so, any preferred vendors?

We'll need to transfer the domain too.
If we don't have analytics let's close this one for now.


Designed Contact Us section and made it responsive

Added map to contact us section and added user details section.

/assign

Please assign me this issue.

I've already completed it. Pls assign me.

Please check I have created a pull request Designed Contact Us#534 #536
commit d7c7ba6

Not needed as already a contact page is present.


Exec tachikoma update<PHONE_NUMBER>3330

:hamster::hamster::hamster:   Strategy none
Powered by Interval Pull Request as a Service - Tachikoma.io Announcement: 2015-06-28 Updated permissions - Tachikoma.io

Coverage remained the same at 67.647% when pulling cd346df3c1090e8fa85dee55368354b797175862 on pazjacket:tachikoma/update-20170507163330 into 8adcad1ec54a7c518c29209245596a627c403fcb on sanemat:master.

Coverage remained the same at 67.647% when pulling cd346df3c1090e8fa85dee55368354b797175862 on pazjacket:tachikoma/update-20170507163330 into 8adcad1ec54a7c518c29209245596a627c403fcb on sanemat:master.

Coverage remained the same at 67.647% when pulling cd346df3c1090e8fa85dee55368354b797175862 on pazjacket:tachikoma/update-20170507163330 into 8adcad1ec54a7c518c29209245596a627c403fcb on sanemat:master.

Coverage remained the same at 67.647% when pulling cd346df3c1090e8fa85dee55368354b797175862 on pazjacket:tachikoma/update-20170507163330 into 8adcad1ec54a7c518c29209245596a627c403fcb on sanemat:master.


ColCount bug

Are you requesting a feature, reporting a bug or ask a question?
Reporting a bug
What is the current behavior?
Specifying colCount should change the number of columns used to display a long list of items. However, in my current setup setting colCount to any value gives the same response of a single linear list of my elements.
What is the expected behavior?
I expect the number of columns to change.
How would you reproduce the current behavior (if this is a bug)?
Hard to exactly reproduce, but it is irrelevant of my input data. The other js libraries that I use in the order that they appear are:
<script src="/static/inspinia/js/jquery-3.1.1.min.js"></script>
<script src="/static/inspinia/js/bootstrap.min.js"></script>
<script src="/static/inspinia/js/plugins/metisMenu/jquery.metisMenu.js"></script>
<script src="/static/inspinia/js/plugins/slimscroll/jquery.slimscroll.min.js"></script>

<!-- Custom and plugin javascript -->
<script src="/static/inspinia/js/inspinia.js"></script>
<script src="/static/inspinia/js/plugins/pace/pace.min.js"></script>
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/noUiSlider/10.0.0/nouislider.js"></script>
<script type="text/javascript" src="https://surveyjs.azureedge.net/0.12.3/survey.jquery.min.js"></script>

Provide the test code and the tested page URL (if applicable)
n/a
Specify your

browser: Chrome
browser version: Version 59.0.3071.115 (Official Build) (64-bit)
surveyjs platform (angular or react or jquery or knockout or vue): jquery
surveyjs version: 0.12.3

@willgdjones Could you please specify the question type, in which the colCount property is not working? I've just checked radiogroup and checkbox questions - colCount works fine for me. Or have I missed something?

Hi @tsv2013 ,
Answering for @willgdjones as I am working on the same project. The question type is checkbox. See code below:
            {                     type: "checkbox",                     name: "Disease",                     title: "Which of the following conditions have you been diagnosed with?",                     visibleIf: "{haveHistory}='Yes'",                     isRequired: true,                     ColCount: 2,                     choices:[ "Cancer","Heart disease", "Pulmonary/Lung disease", "Diabetes", "Immune disorders", "Neurological disease", "Psychiatric disorder", "Digestive disease", "Endocrine disease", "Gynaecological conditions", "Genetic condition", "Other"],                 },
The choices are still displayed in one single column no matter what value we put after ColCount. Are we missing anything?
Thanks for your help

@tsv2013 I will update to version 0.12.20 and see if that fixes.

@cguzzo Thank you for the provided JSON. I've checked it. You should write colCount: 2 instead of ColCount: 2.

Thanks @tsv2013 - updating the new version worked thanks!


Develop the API endpoints:  Create the required API endpoints for staff management, clock-in/clock-out, customer count, and other necessary functionalities.

This issue has been split into smaller issues #14, #16, and #17.


feat(rebrand): Change theme colors

:star2: What does this PR do?
Change theme colors to match the new TogglTrack colors
:bug: Recommendations for testing

Check the colors, they should match our new design

@rylek90 I think you'll have to make a fresh install. I had the same problem locally.

@dpsxp indeed! Sorry for messing around! 😅

No worries, I hope this a debug thing only tho 🙈

No worries, I hope this a debug thing only tho 🙈

🤞
We can always add some notification to reinstall, we're good at it lately 😂

Can you give us an option to change the color? I'm not a big fan of the pink theme.

@louiskirsch I am sorry at the moment we don't have plans on supporting additional themes (other than light and dark)
I'll update this thread if we plan on adding more color-schemes


remove dependency gopacket

don't you need to wait for https://github.com/netobserv/netobserv-ebpf-agent/pull/416 then update the agent instead ?

that's only a temporary PR (that's why it's a draft) .. it is not meant to be merged but I wanted to verify with perf tests if it helps or not, given that there seem to be several regressions


Suppression of warnings and messages

Looking at #83 I see in the code
  a <- suppressMessages(suppressWarnings(fd_seedling_sapling()))

Whatever's going on here, we don't want to do this. It's sweeping some issue under the rug that should be addressed.
Don't worry about it @mgrigri1 but reminding myself to follow up.

i am glad to help later, my R is occupied with TLS data at the moment.
On Wed, Apr 28, 2021 at 4:42 PM Ben Bond-Lamberty @.***>
wrote:

Looking at #83 https://github.com/FoRTExperiment/fortedata/pull/83 I
see in the code
a <- suppressMessages(suppressWarnings(fd_seedling_sapling()))
Whatever's going on here, we don't want to do this. It's sweeping some
issue under the rug that should be addressed.
Don't worry about it @mgrigri1 https://github.com/mgrigri1 but
reminding myself to follow up.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/FoRTExperiment/fortedata/issues/84, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB7XVVKWX5VNPJN3R4SXPPDTLBXM5ANCNFSM43XZWTYQ
.

--
Jeff Atkins
Post-Doctoral Scholar
Department of Biology
Virginia Commonwealth University
Visiting Scholar
Department of Environmental Sciences
University of Virginia

fixed.


Can't disable map drag (Windows IE11 only)

I'm trying to disable the map drag when a user clicks a layer. It works fine on Mac/Chrome, but on Windows/IE the map drag is not disabled.
It seems like the mousedown event handler on the map object is never actually removed.
See: http://jsfiddle.net/skalb/otwgyutn/3/
Any ideas?
Edit: using leaflet master

also cc @danzel

Variable scope problem. this is not set correctly when running map.dragging.disable() asynchronously.

Hm. Apparently disabling the map dragging works, but the order IE11 fires the events means it's disabled after starting the drag (in that fiddle's use case).

but the order IE11 fires the events

I'm curious about the details

Upon further testing, I'm seeing this issue on both iOS Chrome and Safari as well (using iPhone 6 and simulator).
Same fiddle: https://jsfiddle.net/skalb/otwgyutn/5/embedded/result/

This looks like a different issue so I opened #3825 instead.

Apparently this is reproducible in beta2 (as reported in #4157) - anyone up to git bisect the code?

I did some further testing and found that is works correctly in one (sub)version of 1.0beta2 and not correct in another.
There are also fiddles where you can check.
In current version from [www.leaflet.js] (http://leafletjs.com/2015/10/14/leaflet-1.0-beta2-released.html) it does not work:
Leaflet: Leaflet 1.0.0-beta.2 (954e83d)
http://cdn.leafletjs.com/leaflet/v1.0.0-beta.2/leaflet.js
http://jsfiddle.net/xu72htcy/7/embedded/result/
In version I found in one example fiddle it works correctly in IE:
Leaflet: Leaflet 1.0.0-beta.2 (08d655f)
https://s3.amazonaws.com/fieldwire-dev/leaflet-master/leaflet-src.js
http://jsfiddle.net/xu72htcy/4/embedded/result/

@amir-infsoft Does it work in the current master branch? (See https://playground-leaflet.rhcloud.com → "add library" → "Leaflet development version")

Unfortunately no.
Url: https://playground-leaflet.rhcloud.com/jix/1/edit?html,output

git bisect says that the regression is at c6d858775341667dceefd0f7b9f0718cf7d52c0e AKA «Don't use maxTouchPoints detection in IE11+ (or edge) either, matching our msPointer detection.»
Damn. :-(

I see. When I add '&& navigator.maxTouchPoints' part in current dev version then it works.
Can you add this in new version(s)?
I presume this was removed because it was causing some other issue/incorrect behavior?

Paging @danzel @yohanboniface - I have no idea how to fix this without breaking #3804/#3839.

I presume this was removed because it was causing some other issue/incorrect behavior?

@amir-infsoft Exactly. It's not the first time that fixing a very specific bug creates a tiny very specific bug somewhere else.

Adding && maxTouchPoints isn't a fix, that just means it'll only break on touch devices.
That change was sort of a follow up to afa0d1d87b4c522ca3cbeef785c829b886355982 too.
Gonna investigate this for a bit. What if we cancelled any existing drags when the draggable gets disabled?

Ok, so on mouse down if IE feels like it has a touch device, it will generate a pointerdown event first, which leaflet happily handles starting the drag.
Then IE makes a mousedown event, which you catch and disable the drag.
We could change Draggable.disable() to cancel any drags in progress which would make this work... I think that is probably better behaviour too?

@danzel Sounds good.


No horizontal scrollbar on network tab

There is no scrollbar to move from right to left on network tab when enlarge colums with a small windows.

Instead of having a horizontal scrollbar, somewhat dirty, let's shorten the pubkey.
https://github.com/ucoin-io/cutecoin/commit/fd66ac319abad228b2c041d29d98aa7d350affe9


CLI - Cannot successfully run "sift update" even after updating apt-get

Hello, I get 1 error when updating sift and another when updating apt-get. I am running both from the SIFT Workstation in VMWare Player 16.

i386 architecture...? Unsure - would appreciate any insights! Thanks!

Beginning of output lists a log file, please upload that.

saltstack.log

Looks like a single file was unable to be downloaded and installed. Most likely just a transient error you can try again, the SIFT tool will only install what's missing or configure what's not configured, it is idempotent.
Error: HTTP 599: Timeout while connecting
      reading http://mirrors.kernel.org/ubuntu/pool/universe/p/pdftk-java/pdftk-java_3.1.1-1_all.deb\n"


[ENH]: Client close (redo of #1792)

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

Ability to close and release resources for Persistent (open files) and Http (connections). This is a redo of #1792

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
TBD

#2581  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on  Graphite

latest testcontainers with Chroma won't work with py38


HA could not connect to vacuum

I have this error at log. Xiaomi home can control it and the IP is valid.
`Logger: homeassistant.components.vacuum
Source: custom_components/xiaomi_vacuum/miio/miioprotocol.py:75
Integration: Vacuum (documentation, issues)
First occurred: 20:03:14 (1 occurrences)
Last logged: 20:03:14
xiaomi_vacuum: Error on device update!
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 431, in _async_add_entity
await entity.async_device_update(warning=False)
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 684, in async_device_update
await task
File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/xiaomi_vacuum/vacuum.py", line 653, in update
state = self._vacuum.status()
File "/config/custom_components/xiaomi_vacuum/miio/dreamevacuum.py", line 205, in status
for prop in self.get_properties_for_mapping()
File "/config/custom_components/xiaomi_vacuum/miio/miot_device.py", line 65, in get_properties_for_mapping
return self.get_properties(
File "/config/custom_components/xiaomi_vacuum/miio/device.py", line 269, in get_properties
values.extend(self.send(property_getter, _props[:max_properties]))
File "/config/custom_components/xiaomi_vacuum/miio/device.py", line 178, in send
return self._protocol.send(
File "/config/custom_components/xiaomi_vacuum/miio/miioprotocol.py", line 162, in send
self.send_handshake()
File "/config/custom_components/xiaomi_vacuum/miio/miioprotocol.py", line 75, in send_handshake
raise DeviceException("Unable to discover the device %s" % self.ip)
custom_components.xiaomi_vacuum.miio.exceptions.DeviceException: Unable to discover the device <IP_ADDRESS>
`

After some reboot everything is working.


Support previous context and previous msgid with commands

#| msgctxt and #| msgid

See The format of PO files.

This just doesn't makes sense.


Misc css fixes

Coverage remained the same at 82.822% when pulling 1881e073c2d0d6e71035c528220595bf75d55937 on eatonphil:misc-css-fixes into 609c06a5b0566fb1c84d3c3dc70e3e1e2f3b1f04 on linode:master.

Would be nicer to merge #718 before this one.

Woohoo! No merge conflicts.

thanks!


when loadUI fails with FileNotFoundException it can not be caught

Describe the bug
When loadUI files because of a FileNotFoundException, it does not stop execution nor is there a way to catch it
To Reproduce
Steps to reproduce the behavior:

Inside of the initUI procedure, put this code

        UI fxmlUI;
        try {
            fxmlUI = getAssetLoader().loadUI(new URL("file:///D:/Projects"), controller);
        getGameScene().addUI(fxmlUI);

        } catch (MalformedURLException  e) {
            System.out.println("" + e);
            System.exit(1);
        }

Expected behavior
If the URL is properly formed but no existent, the file won't be loaded but the program will continue
Runtime info(please complete the following information):

OS and version:  Windows 10

Sorry for delayed reply, yes, this is by design. We will keep going until we encounter an error we cannot recover from. However, any exceptions should be correctly reported in the log, typically using the WARN tag.


Add pull request templates.

Just wanted to add this in here in order for pull requests to be tidy and maintainers can read the description without having to trawl through a few paragraph's worth of text.
(This should work.)

The check failed because of rate limit???

@yu-kiat This is a very good idea. Would be great to have one for Changes too. :)

@yu-kiat This is a very good idea. Would be great to have one for Changes too. :)

Alright, I'll add it soon.

@iinsertNameHere I added it,


Unmet peer dependency graphql

As said in self-closed #32:
 npm install --save koa-graphql
<EMAIL_ADDRESS>.../Desktop/app
├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>Execution:
module.js:341
    throw err;
    ^

Error: Cannot find module 'graphql'

You should install graphql as well:
npm install --save graphql
perrDeependencies will not be auto installed when using npm@3


Nova flavor purge

Create nova flavors
Use flavor name for tempest

This need the patch jiocloud/puppet-tempest#9 to be merged

Purge unmanaged nova flavors

This is a superset of PRs #401 and #396. The review and merge can be done on all individual PRs or only this PR.
Here are the dependant patches which need to be merged before this one.

jiocloud/puppet-tempest#9
JioCloud/puppet-nova#1
JioCloud/puppet-nova#1
JioCloud/puppet-openstack_extras#2
JioCloud/puppet-openstacklib#1

please test this

please test this

please test this

please test this

please test this

last test failed because of timeout - otherwise the validation tests were successful (running tempest tests there)

please test this

please test this

please test this

please test this

previous test failed because of timeout, I see validation tests were sucess there.

please test this

again timeout :(... checking why this is happening

I see ocdb took long time to complete puppet run, Ill try testing again.

please test this

there are three different patches here for flavors, can you clean it up and ensure that only the patch that I should review exists?

dup of #396

I reviewed everything and it looks fine.

replaced by #456


Fix namespace in sample

@eNeRGy164,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/use-the-token-validation-library.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks for the fix!


Improve naming of anonymous classes & fix GitHub CI

Aims to resolve (part of) #54 and make GitHub CI pass again.
Represents anonymous classes using the com.example.ClassImpl#method$Anonymous1 format.

Hey, @amousavigourabi! Are you still going to work on this one? It's a good MR, I just need to understand the extra dependencies there. They don't seem necessary. Shall we just remove them and get this MR merged?


[announce-sender] use trickle to limit number of announce tx

This commit updates and enhances the AnnounceSender feature. When
this feature is enabled, routers and REEDs periodically send MLE
Announcements (on all channels from the channel mask in the current
Active Operational Dataset). This commit updates the implementation to
use TrickleTimer such that a device monitors the number of received
Announce messages within a cycle and if the number is above a
redundancy threshold, the device skips sending Announcement in that
cycle itself. This helps limit the number of Announcement tx in cycle
in a dense network. The same mechanism is used by both routers and
REEDs.

Any CI test cases to verify MLE Announce frame?

@brianljt  Yes. I think multiple existing tests already cover it. One main example is test-603-channel-manager-announce-recovery.py which verifies that an orphaned node (on a different channel) is recovered through MLE Announcement.

Thanks @CiaranWoodward. We talked about this in the Thread Low-power WG meeting today. Just adding a quick overview here:

We have a cycle interval (~11.5 min).
We use a trickle timer and use the same cycle interval as both min and max trickle timer interval.
Trickle timer practically is running as a periodic timer with this interval.
In each cycle, the trickle timer picks a random point of time within the second half of the interval.
Up the randomly selected point, we listen and count the number of received Announce message from neighbors.
If the number is higher than the redundancy threshold, device skips sending Announce message in that cycle, and then wait till end of the interval and repeats the same process.
If the number is lower than the threshold, then device decides to send MLE annoucnemnt in this cycle

The first annoucne message is send within a short jitter delay after the decision and it is sent on the current PAN channel (being used by nodes).
This is then followed by sending Announce on all channels in the current channel mask (till we get back to PAN channel).
In the new pushed commit, I changed the logic to use half the interval for sending all channels (instead of full interval). So we divide half interval by the number of channels in mask and use it as period between two successive Announce Tx on different channels.
This way, we should always finish the tx from previous cycle, before we need to make a decision on the next cycle.


Investigate multi-layer overlayfs

It would be awesome to do root -> config -> rw_layer rather than dealing w/ tarballs

Bonus points if this can use keywhiz or similar to mount in a creds layer

Done for config, will revisit for keys when that exists


WIP: Drop Python 3.9 support

Description
Contributes to https://github.com/rapidsai/build-planning/issues/88
Finishes the work of dropping Python 3.9 support.
This project stopped building / testing against Python 3.9 as of https://github.com/rapidsai/shared-workflows/pull/235.
This PR updates configuration and docs to reflect that.
Notes for Reviewers
How I tested this
Checked that there were no remaining uses like this:
git grep -E '3\.9'
git grep '39'
git grep 'py39'

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Any file changes here that aren't just removing a "3.9" or changing it to a "3.10" were made automatically by ruff.
There are also these additional new ruff errors that weren't auto-fixed:
python/cucim/src/cucim/core/operations/color/jitter.py:38:10: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
python/cucim/src/cucim/core/operations/color/jitter.py:54:17: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/core/operations/color/jitter.py:55:15: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/core/operations/color/jitter.py:56:17: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/core/operations/color/jitter.py:57:10: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/core/operations/color/jitter.py:60:5: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/core/operations/color/jitter.py:61:5: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/core/operations/color/jitter.py:62:5: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/core/operations/color/jitter.py:63:5: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/core/operations/color/stain_normalizer.py:449:22: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/core/operations/color/stain_normalizer.py:454:19: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/core/operations/intensity/zoom.py:227:15: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/core/operations/intensity/zoom.py:228:15: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/core/operations/intensity/zoom.py:246:15: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/core/operations/intensity/zoom.py:247:15: UP007 Use `X | Y` for type annotations
python/cucim/src/cucim/skimage/_shared/utils.py:745:8: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
python/cucim/src/cucim/skimage/_vendored/_ndimage_util.py:46:10: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
python/cucim/src/cucim/skimage/_vendored/_texture.py:197:10: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
python/cucim/src/cucim/skimage/filters/thresholding.py:327:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
python/cucim/src/cucim/skimage/measure/tests/test_regionprops.py:1232:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
python/cucim/src/cucim/skimage/measure/tests/test_regionprops.py:1381:12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
python/cucim/src/cucim/skimage/measure/tests/test_regionprops.py:13[84](https://github.com/rapidsai/cucim/actions/runs/10498836421/job/29084514063?pr=766#step:6:85):12: UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`

(build link)
@grlee77 how would you like to handle these? I can do the work of either applying or ignoring those suggestions, but will defer to how you want the code to look.

Thanks @jameslamb,
I am in favor of accepting the suggestions related to UP007 unions for type hints.
I think we should add
ignore = ["UP038"]

to the ruff config in pyproject.toml. It seems that there is a performance penalty to using | instead of a tuple in isinstance calls (see here and here)

While updating pyproject.toml, it seems we should update the ruff section names to match current recommendations. Here is a patch including the suggested UP038 ignore:
diff --git a/python/cucim/pyproject.toml b/python/cucim/pyproject.toml
index 2df37c5a..c664659b 100644
--- a/python/cucim/pyproject.toml
+++ b/python/cucim/pyproject.toml
@@ -147,9 +147,6 @@ filterwarnings = [
 ]

 [tool.ruff]
-# see: https://docs.astral.sh/ruff/rules/
-select = ["E", "F", "W", "I", "UP"]
-fixable = ["ALL"]
 exclude = [
     # TODO: Remove this in a follow-up where we fix __all__.
     ".tox",
@@ -166,10 +163,16 @@ exclude = [
 line-length = 80
 fix = true

-[tool.ruff.per-file-ignores]
+[tool.ruff.lint]
+# see: https://docs.astral.sh/ruff/rules/
+select = ["E", "F", "W", "I", "UP"]
+ignore = ["UP038"]
+fixable = ["ALL"]
+
+[tool.ruff.lint.per-file-ignores]
 # "src/cucim/skimage/util/tests/test_shape.py" = ["E201", "E202"]

-[tool.ruff.isort]
+[tool.ruff.lint.isort]
 combine-as-imports = true
 force-single-line = false
 known-first-party = ["cucim"]

Thanks @grlee77 ! I've applied changes similar to that patch you provided. Using the new format of ruff configuration required updating ruff, so I updated it to its latest available version (0.6.1).
There's one class of new error that I'd like your opinion on. They look like this:
python/cucim/src/cucim/skimage/morphology/tests/test_misc.py:52:8: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
   |
50 |     expected_out = cp.empty_like(test_image, dtype=out_dtype)
51 |
52 |     if out_dtype != bool:
   |        ^^^^^^^^^^^^^^^^^ E721
53 |         # object with only 1 label will warn on non-bool output dtype
54 |         exp_warn = ["Only one label was provided"]
   |

python/cucim/src/cucim/skimage/segmentation/_chan_vese.py:417:8: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
415 |     float_dtype = _supported_float_type(image.dtype)
416 |     phi = _cv_init_level_set(init_level_set, image.shape, dtype=float_dtype)
417 |     if type(phi) != cp.ndarray or phi.shape != image.shape:
    |        ^^^^^^^^^^^^^^^^^^^^^^^ E721
418 |         raise ValueError(
419 |             "The dimensions of initial level set do not "

Are you comfortable with is / is not for those types of comparisons? Or are there cases where == is really desirable (e.g. because of some compatibility code in objects' __eq__() methods that we want to run)?
full list of those cases (click me)
python/cucim/src/cucim/skimage/_shared/tests/test_utils.py:94:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
   |
92 |         assert (
93 |             _validate_interpolation_order(dtype, None) == 0
94 |             if dtype == bool
   |                ^^^^^^^^^^^^^ E721
95 |             else 1
96 |         )
   |

python/cucim/src/cucim/skimage/_shared/tests/test_utils.py:101:10: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
 99 |         with pytest.raises(ValueError):
100 |             _validate_interpolation_order(dtype, order)
101 |     elif dtype == bool and order != 0:
    |          ^^^^^^^^^^^^^ E721
102 |         # Deprecated order for bool array
103 |         with pytest.raises(ValueError):
    |

python/cucim/src/cucim/skimage/_shared/utils.py:812:21: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
811 |     if order is None:
812 |         return 0 if image_dtype == bool else 1
    |                     ^^^^^^^^^^^^^^^^^^^ E721
813 |
814 |     if order < 0 or order > 5:
    |

python/cucim/src/cucim/skimage/_shared/utils.py:819:8: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
817 |         )
818 |
819 |     if image_dtype == bool and order != 0:
    |        ^^^^^^^^^^^^^^^^^^^ E721
820 |         raise ValueError(
821 |             "Input image dtype is bool. Interpolation is not defined "
    |

python/cucim/src/cucim/skimage/color/colorlabel.py:252:8: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
251 |     new_type = np.min_scalar_type(int(label.max()))
252 |     if new_type == bool:
    |        ^^^^^^^^^^^^^^^^ E721
253 |         new_type = np.uint8
254 |     label = label.astype(new_type)
    |

python/cucim/src/cucim/skimage/exposure/exposure.py:502:8: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
500 |         # pair of values: always return float.
501 |         return utils._supported_float_type(image_dtype)
502 |     if type(dtype_or_range) == type:
    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ E721
503 |         # already a type: return it
504 |         return dtype_or_range
    |

python/cucim/src/cucim/skimage/measure/_regionprops.py:141:63: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
139 | }
140 |
141 | OBJECT_COLUMNS = [col for col, dtype in COL_DTYPES.items() if dtype == object]
    |                                                               ^^^^^^^^^^^^^^^ E721
142 |
143 | PROP_VALS = set(PROPS.values())
    |

python/cucim/src/cucim/skimage/measure/tests/test_regionprops.py:1226:20: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
     |
1225 |         if col in OBJECT_COLUMNS:
1226 |             assert COL_DTYPES[col] == object
     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ E721
1227 |             continue
     |

python/cucim/src/cucim/skimage/measure/tests/test_regionprops.py:1244:17: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
     |
1242 |         if cp.issubdtype(t, cp.floating):
1243 |             assert (
1244 |                 COL_DTYPES[col] == float
     |                 ^^^^^^^^^^^^^^^^^^^^^^^^ E721
1245 |             ), f"{col} dtype {t} {msg} {COL_DTYPES[col]}"
1246 |         elif cp.issubdtype(t, cp.integer):
     |

python/cucim/src/cucim/skimage/measure/tests/test_regionprops.py:1248:17: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
     |
1246 |         elif cp.issubdtype(t, cp.integer):
1247 |             assert (
1248 |                 COL_DTYPES[col] == int
     |                 ^^^^^^^^^^^^^^^^^^^^^^ E721
1249 |             ), f"{col} dtype {t} {msg} {COL_DTYPES[col]}"
1250 |         else:
     |

python/cucim/src/cucim/skimage/morphology/tests/test_misc.py:52:8: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
   |
50 |     expected_out = cp.empty_like(test_image, dtype=out_dtype)
51 |
52 |     if out_dtype != bool:
   |        ^^^^^^^^^^^^^^^^^ E721
53 |         # object with only 1 label will warn on non-bool output dtype
54 |         exp_warn = ["Only one label was provided"]
   |

python/cucim/src/cucim/skimage/segmentation/_chan_vese.py:417:8: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
415 |     float_dtype = _supported_float_type(image.dtype)
416 |     phi = _cv_init_level_set(init_level_set, image.shape, dtype=float_dtype)
417 |     if type(phi) != cp.ndarray or phi.shape != image.shape:
    |        ^^^^^^^^^^^^^^^^^^^^^^^ E721
418 |         raise ValueError(
419 |             "The dimensions of initial level set do not "
    |

python/cucim/src/cucim/skimage/transform/_geometric.py:916:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
914 |             # combination of the same types result in a transformation of this
915 |             # type again, otherwise use general projective transformation
916 |             if type(self) == type(other):
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^ E721
917 |                 tform = self.__class__
918 |             else:
    |

python/cucim/src/cucim/skimage/transform/_warps.py:173:17: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
171 |     if anti_aliasing is None:
172 |         anti_aliasing = (
173 |             not input_type == bool
    |                 ^^^^^^^^^^^^^^^^^^ E721
174 |             and not (cp.issubdtype(input_type, cp.integer) and order == 0)
175 |             and any(x < y for x, y in zip(output_shape, input_shape))
    |

python/cucim/src/cucim/skimage/transform/_warps.py:178:8: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
176 |         )
177 |
178 |     if input_type == bool and anti_aliasing:
    |        ^^^^^^^^^^^^^^^^^^ E721
179 |         raise ValueError("anti_aliasing must be False for boolean images")
    |

Found 15 errors.

Thanks James! 🙏
Generally those suggestions sound reasonable. Would be interested in Greg's thoughts as well
With the dtype checks, unfortunately this might just be a case where ruff is leading us in the wrong direction. Please see this example
In [1]: import numpy as np
In [2]: np.dtype(bool) == bool
Out [2]: True
In [3]: np.dtype(bool) is bool
Out [3]: False

@jameslamb

Thanks @grlee77 ! I've applied changes similar to that patch you provided. Using the new format of ruff configuration required updating ruff, so I updated it to its latest available version (0.6.1).
There's one class of new error that I'd like your opinion on. They look like this:

Thanks, I think some of those suggestions may be unwanted. Can we just ignore these E721 errors for now in this MR? Then we can open an issue to remind me to take a look at them individually later on.

Yep absolutely! I'll ignore add that code to the list ruff ignores, and open an issue for you.

Put up #767 for you.

Skimmed through the changes. Generally these all look like solid improvements
If Greg agrees and CI passes, we should ship it
Thanks for all your hard work here James! 🙏

Thanks all! 🙏
Let's ship this :shipit:

/merge


[Safari iOS] Select inputs closes on fast tap since issue #226 fix

The fix for the issue #226 is breaking the select inputs on iOS7 (tested on both iPhone 5 & 5s) for "quick" taps (faster than the 100ms threshold) when the position of the select element on the screen is moved up because the dropdown pops up at the bottom of the screen. If the touchend is not preventDefault(), the element under the initial position of the element (if any) will get the focus, closing the select dropdown.
See video here: http://youtu.be/0J_RNTMzHyQ
Test file: http://pastebin.com/hqs3sDB4
If there are no focusable element under to initial on-screen position of the select input it will work fine, as well as if the select input in near the top of the screen and does not move when the dropdown pops up.
The only fixes I found are:

Reverting the fix for #226 , but no more VoiceOver. Apple should fix it anyway
Exclude selects from fastclick, but then it's super slow

You can use https://github.com/percolatestudio/fastclick/commit/9ac88ef4653cb1621644ce58080c0696ef9a6598
but return value should be false, as @optikalefx mentioned in that request

@contactmatts @oldboyxx Did you put either of your fixes up in a PR?

I did not.

+1 same issue. Made doubly worse it seems when using Angular or dynamicly added selects: the select was totally unselectable unless the user holds down on it for a second or so.

@oldboyxx fix worked for me:
https://github.com/ftlabs/fastclick/issues/268#issuecomment-65022184
Any reason this isn't taken in to the code as a patch (doubt anyone would care about a 300ms delay on selects on iOS)?

I'd like to add that the fix provided by @asselin (see pull request here) still is needed in 1.0.6. I added the code from that pull request to my local copy of 1.0.6 and everything is working great.

+1 to merging one of the fixes for this issue. Personally I went for the fix from @oldboyxx

This will be fixed in some version? I'm using this library but is really awful patch every update or new instalation.

As @laurentgoudet mentioned:
Just revert this changes (use "!deviceIsIOS4" in the IF-Statement instead of "!deviceIsIOS") and you will be fine again! =) According to the current version you need to make the changes in the line 584 in fastclick.js .
https://github.com/ftlabs/fastclick/pull/235/files
Or simply use my attached modified version =) .
But pay attention that this breaks VoiceOver again in some way.
fastclick.js.zip
The fix of @oldboyxx didn't work for me as it disabled fastclick.

Problem still occurs, @oldboyxx 's fix worked for me, thanks!

This isn't a fastclick issue. It happens in all browsers when RTL and the input is out of the viewport: See this: http://codepen.io/davidpelayo/full/jMjggy/
Tested on latest Firefox, latest Chrome stable and Safari on iOS 10.

+1 for fix by @oldboyxx

so this repo is broken and no plans to fix it i take it thne? this is still a problem years later

why would you use something that breaks any input on the page.. .stupid


Definition of "Today" is different between homepage and 'Top for Today'

The homepage has a very generous definition of "today" for the top for today section - stuff stays there longer than 24 hours, and when you click the link to explore further, they drop out (presumably because the definition in the explore part is more correct). The two should be consistent with each other and with the idea that only things <= 24 hours old should appear.

A note: Brendon is also in AU timezone, and he's seen different results based on that. Somewhere we may not be taking into account UTC vs local timezone.
Also, one of these queries may be looking further back than the other.

I'd like today to always be last 24 hours, which should be consistent from all places

I agree with Jeremy. Should be straightforward to make the claim search use
(local unix time - 86400) always
On Wed, Dec 16, 2020 at 7:16 AM Jeremy Kauffman<EMAIL_ADDRESS>wrote:

I'd like today to always be last 24 hours, which should be consistent from
all places
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-desktop/issues/5179#issuecomment-745472143,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMBKOVJM3LV7AEFEHW54STSU6RYHANCNFSM4U2AUMHQ
.

--
Dr Brendon J. Brewer
Phone: +64 27 5001336
https://www.brendonbrewer.com
https://odysee.com/@BrendonBrewer:3
https://keybase.io/brendonbrewer


Custom Access-Control-Allow Headers are not showing up

Describe the bug
I can not get my custom headers to show up.
I have tried several different things after my initial attempt failed:

In the build log I saw that having customHeaders in amplify.yml is deprecated so I moved them to customHttp.yml (the build found them and looks happy)
I thought maybe the order of the rules mattered, I tried putting the most "permissive" pattern at the bottom, that did not seem to help either.
I tried putting my customHeaders.yml in the web ui management console thing-y for Amplify too, no luck there either.

To Reproduce
Steps to reproduce the behavior:

Added customHeaders.yml
It looks something like:customHeaders:
- pattern: '*.woff'
  headers:
    - key: 'Access-Control-Allow-Origin'
      value: 'https://www.mydomain.name'
    - key: 'Access-Control-Allow-Credentials'
      value: 'true'
    - key: 'Access-Control-Allow-Methods'
      value: 'GET, HEAD'
- pattern: '*.woff2'
  headers:
    - key: 'Access-Control-Allow-Origin'
      value: 'https://www.mydomain.name'
    - key: 'Access-Control-Allow-Credentials'
      value: 'true'
    - key: 'Access-Control-Allow-Methods'
      value: 'GET, HEAD'
- pattern: '**/*'
  headers:
    - key: 'X-Robots-Tag'
      value: 'noindex'

Expected behavior
For the woff and woff2 (font files) have the custom headers, something like:
HTTP/2 200 OK
content-type: font/woff
content-length: 45516
last-modified: Fri, 12 Feb 2021 15:51:09 GMT
x-amz-server-side-encryption: AES256
accept-ranges: bytes
server: AmazonS3
x-robots-tag: noindex
Access-Control-Allow-Origin: https://www.mydomain.name
Access-Control-Allow-Methods: GET, HEAD
Access-Control-Allow-Credentials: true
date: Fri, 12 Feb 2021 20:06:13 GMT
etag: "82a9683860460a3aa1eadfc2e0180bc4"
x-cache: RefreshHit from cloudfront
via: 1.1 ac8301cb52f27894048b5f9019631931.cloudfront.net (CloudFront)
x-amz-cf-pop: MSP50-C2
x-amz-cf-id: YaST35fgSvBxnMXkARbJerHC1qPElCpDg75h349jGTYigWEiOG4vWw==
X-Firefox-Spdy: h2

But the responses are missing all the Access-Control-Allow-* headers

Hi @jachin , Can you try to change pattern to '/*.woff' and '/*.woff2' ?
Let me know have further question.

@VictorCcccc That worked!
In my case this worked out, but I feel like there's still a bug here, if customHttp.yml doesn't full support "globbing" (pattern matching) the docs should call that out.

@VictorCcccc Ok, so I said it worked... well... it worked on the branch "Preview". But I have sense merged that to master, and the headers are not showing up on the master build.
If I'm honest, it did not occur to me to test the preview builds for my other attempts so I'm sure if what I had before was correctly setting the HTTP Headers in the preview builds already.

Oh man... this is starting to feel a little bit like gas lighting, but here's what I think I'm seeing.
This is on a "preview" build using the wildcards (in customHttp.yml) that look like **/*.woff and **/*.woff2.
When I request the .woff font, the response does not have the custom headers, but when I request the .woff2 file that does have the custom headers.
However, when I hit the production URL, which has an identical customHttp.yml file, for both font file extensions, I am not getting the custom headers.

Oh man... this is starting to feel a little bit like gas lighting, but here's what I think I'm seeing.
On a "preview" build using the wildcards (in customHttp.yml) that look like **/*.woff and **/*.woff2, when I request the .woff font, the response does not have the custom headers, but when I request the .woff2 file that does have the custom headers.
However, when I request the same files in production (build off the master branch), which has an identical customHttp.yml file (as the preview branch), for both font file extensions, I am not getting the custom headers.

Found this same issue when I reproduced your bug on my end. Still investigating this problem.

Hey @jachin, Can you send me your App ID to me? The App ID is a string start with "d" in your App ARN(after "/"). It will be helpful for us to locate the issue. Thanks!

Hi @jachin, Can you send me your App ID? The App ID is a string start with "d" (after "/") in your App ARN. It will be helpful for us to locate the issue. Thanks!
The thing is that if there is a branch level config, that takes precedence over any app-level config. This may become the main reason why custom header show up "randomly". I'll check the config file for you on our back-end. And will request Docs updates!

It's d11ckvg2f5ptem, thanks for looking into it.

Hi @jachin, Can you send me your App ID? The App ID is a string start with "d" (after "/") in your App ARN. It will be helpful for us to locate the issue. Thanks!
The thing is that if there is a branch level config, that takes precedence over any app-level config. This may become the main reason why custom header show up "randomly". I'll check the config file for you on our back-end. And will request Docs updates!

It's d11ckvg2f5ptem, thanks for looking into it.

I've sent you<EMAIL_ADDRESS>an email with details, Thanks.

Update: Found correct custom headers showed up on different browser. The missing custom header issue might be caused by the internal bug of browser engine.

Update: Found correct custom headers showed up on different browser. The missing custom header issue might be caused by the internal bug of browser engine.

That's an interesting theory... I had not thought of that. I've tried a bunch of different "clients" though. Including Paw and curl. It's possible though these different clients are all using the same library or something...
Looking now though, at the production assets, I am seeing the correct headers! Hurray! I wonder if something did change on the Amplify side.
@VictorCcccc would you like me to try adding or editing a new custom header to see if the updated HTTP headers start working right away?

Update: Found correct custom headers showed up on different browser. The missing custom header issue might be caused by the internal bug of browser engine.

That's an interesting theory... I had not thought of that. When I was researching this bug I tried a bunch of different "clients" though. Including Paw and curl. It's possible though these different clients are all using the same library or something...
Looking now though, at the production assets, I am seeing the correct headers! Hurray! I wonder if something did change on the Amplify side.
@VictorCcccc would you like me to try adding new custom header or editing an existing to see if the updated HTTP headers start working right away?

I've sent you the details via email. Yes, you could add new header in customHttp.yml which is in your root folder. I tried to reproduce this error yesterday again and seems like that all the .woff2 file has correct header.

Just to close the loop on this. thanks again for all your help @VictorCcccc. The problem appears to be that the Cloud Front servers (The CDN that serves up the stuff on Amplify) doesn't actually know when a new build has happened and if they should refresh their http headers (they do seem to know when the file has changed, but not the http headers). The work around was to also set the Cache-Control header to something in the customHttp.yml file and the CDN servers should invalidate the cached data they use to make the http headers at least that often (there are docs about this I skimmed).
Hopefully this helps future travelers.
I suggested that the documentation for customHttp.yml in Amplify gets updated to explain this, and if possible. An even better solution would be to push to the CDNs something that told them to refresh their custom http headers when there was a successful build.
Anyway, I'm going to close this issue, I assume this is something the Amplify folks are tracking internally.


get program_name from attr first

in default, the program_name of attr from os.env::args[0], sometimes caller want to change it.
let opts = OptsBuilder::from_opts(&url);
let mut connect_attrs = HashMap::new();
connect_attrs.insert("program_name", "my_app");
let opts = opts.connect_attrs(connect_attrs);
let pool = Pool::new(opts)?;

Published as v19.0.1


Error on features/NullableReferenceTypes branch

error CS8618: Compiler required type 'System.Runtime.CompilerServices.NullableAttribute' cannot be found. Are you missing a reference?

Not sure I can think of a solution that wouldn't be specific to just that branch.
I suppose if there is a NuGet package that provides System.Runtime.CompilerServices.NullableAttribute I can link it for all branches, in the same way I link ValueTuple.

The obvious workaround for users is to include the type manually, e.g. (copied from the documentation):
using System;

namespace System.Runtime.CompilerServices
{
    [AttributeUsage(AttributeTargets.Event | // The type of the event is nullable, or has a nullable reference type as one of its constituents
                    AttributeTargets.Field | // The type of the field is a nullable reference type, or has a nullable reference type as one of its constituents
                    AttributeTargets.GenericParameter | // The generic parameter is a nullable reference type
                    AttributeTargets.Module | // Nullable reference types in this module are annotated by means of NullableAttribute applied to other targets in it
                    AttributeTargets.Parameter | // The type of the parameter is a nullable reference type, or has a nullable reference type as one of its constituents
                    AttributeTargets.ReturnValue | // The return type is a nullable reference type, or has a nullable reference type as one of its constituents
                    AttributeTargets.Property | // The type of the property is a nullable reference type, or has a nullable reference type as one of its constituents
                    AttributeTargets.Class , // Base type has a nullable reference type as one of its constituents
                   AllowMultiple = false)]
    public class NullableAttribute : Attribute
    {
        public NullableAttribute() { }
        public NullableAttribute(bool[] transformFlags)
        {
        }
    }
}

public class C {
    public void M() {
    }
}

Maybe that's acceptable?
I didn't find any existing NuGet package that would contain the type.

Making as external until there is an official package for this.
They'll do one eventually unless the feature moves into CLRvNext.


Code to grab the red lined polygon from Google Maps

Whenever we search for a region or a place on Google maps, a red lined polygon appears on the maps . This code will help grab only that red lined polygon separately . I believe this is a useful code .
I also have attached the input image and the output image along with the code , from my present branch.
Please use this command to run this code :
python findredlinedpolygonfromgooglemaps.py --image stanford.png
Thanks.

@bismoy2013, thank you for the contribution! looks nice. but since it's quite specific application, please, put it to http://github.com/itseez/opencv_contrib instead (opencv_contrib/modules/ximgproc/samples). Also, please, replace all the TAB's with spaces and remove trailing spaces in order to pass our buildbot.

Thanks very much for the info @vpisarev :)