Multiple lines are collapsed into one line in markdown preview

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:Version: 1.71.0 (Universal)
OS Version:OS: Darwin arm64 21.5.0

Steps to Reproduce:
1.Open a Markdown editor.
2.Enter the following code:
aa
bb
cc

3.Preview the Markdown, it's aa bb cc on the same line
I'm not sure if the expected behavior is intended to be displayed as multiple lines, if so I'm want to trying to fix it

Standard Markdown translates one line break into a space, and two line breaks into a paragraph.
Set "markdown.preview.breaks": true setting to enable soft break extension syntax.

Standard Markdown translates one line break into a space, and two line breaks into a paragraph.
Set "markdown.preview.breaks": true setting to enable soft break extension syntax.

thanks！


[minor] simplify Folder path logic.

just making this more readable, it was bothering me.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#909  👈
#908
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on  Graphite

Merge activity

Jun 20, 2:47 PM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.


Expo dependency error, "Cannot find native module 'ExpoCrypto'", in Non-Expo React Native Projects

I encountered an issue while integrating the cloudinary-react-native package version 0.2.0 into my bare React Native project. The problem arises due to the package's dependency on ExpoCrypto and other Expo modules, which are not available in a non-Expo (bare) React Native environment.
Steps to Reproduce

Create a new bare React Native project using npx react-native init MyProject.
Install the cloudinary-react-native package using npm install cloudinary-react-native.
Attempt to use the package according to the provided documentation.
Encounter an error related to the missing ExpoCrypto module when running the app.

Expected Behavior
I expected that the cloudinary-react-native package could be used in a bare React Native project without dependencies on Expo-specific modules, or that there would be clear documentation on how to handle such dependencies in a non-Expo environment.
import {Cloudinary} from '@cloudinary/url-gen';
import {upload} from 'cloudinary-react-native';

async function uploadImageToCloudinarySDK(payload: any) {
  const {folder, upload_preset, uri} = payload;

  const cld = new Cloudinary({
    cloud: {cloudName: Config.CLOUDINARY_CLOUD_NAME },
    url: {secure: true},
  });

  const options = {folder, upload_preset, unsigned: true};

  await upload(cld, {
    file: uri,
    options,
    callback: (error: any, response: any) => {
      if (error) {
        console.error('Upload Error:', error);
      } else {
        console.log('Upload Successful:', response);
      }
    },
  }).catch((error: any) => console.log('ERROR CLD UPLOAD', error?.message));
}

Actual Behavior
The application throws an error indicating that the ExpoCrypto native module cannot be found. This suggests that the package relies on Expo modules, which are not present in bare React Native environments. The exact error message is:
Cannot find native module 'ExpoCrypto', js engine: hermes
Environment

React Native version: 0.73.2
Cloudinary React Native SDK version: 0.2.0
Operating System: iOS
Device details: iPhone 15 Pro Max

Additional Context
I am not using Expo in my project and prefer to keep it as a bare React Native application. I noticed that the package-lock.json file lists several Expo-related dependencies, which might be causing this issue.
Given the package's potential utility for React Native developers looking to integrate Cloudinary, finding a solution to make it compatible with both Expo and non-Expo environments would be greatly beneficial.
Potential Solutions or Workarounds
I am seeking guidance on how to resolve this issue. Possible solutions could include:

Instructions on how to remove or bypass the Expo dependencies in a non-Expo environment.
Updates to the package to support bare React Native projects without requiring Expo modules.
Any other recommended approaches for using cloudinary-react-native in non-Expo React Native projects.

Thank you for looking into this issue. I appreciate any feedback or solutions you can provide.

@mighty6ft5max i'm afraid our react native sdk is supported with expo only, we will be updating our docs to make sure this is clarified soon as well (see: https://github.com/cloudinary/cloudinary-react-native/issues/17)

Cloudinary only supports Expo. Don't use it

Yes, we support only Expo for the moment.
Thanks!


[WIP] Raise error when registering after finalization.

I hit the Gitter room last night after spending some time confused about the silent dropping of registrations after ROM.env.finalize was called.
I poked in some code that I thought might raise an exception like @solnic described. It doesn’t seem to address my case (at least as I expressed it in my spec) and it does trigger a number of failures in other specs.
So please peek at this failing state of the code and provide guidance on where this could go. I’m happy to update this with improvements or a better approach. I can also update the other failing specs if it turns out that this is right and they’re wrong somehow.

Since we're planning a major cleanup in setup/finalize/env code so let's address it there. I'll close this one for now.


Sidekick config page does not behave as expected

Expected Behaviour
Clicking the Go button on https://www.hlx.live/tools/sidekick/ should successfully add the project.
Actual Behaviour
The go button does not seem to do anything. Instead you can click the Sidekick Configurator button above the form, which gives you a message "Your Sidekick is not configured for this project yet" but then clicking add project also does not seem to do anything.
Reproduce Scenario (including but not limited to)
Steps to Reproduce

new browser, google chrome on Mac OS, sidekick plugin installed but no projects configured.
navigate to https://www.hlx.live/tools/sidekick/
enter a repository url, e.g https://github.com/hlxsites/uhg-surest and click "go"
nothing happens

Notes and Thoughts

I was looking at trying to fix this via PR, but to be honest the full expected flow for this page is somewhat confusing to me, so thought I'd start with an issue.
I think the sidekick configurator button should not be a button but instead just a headline
I think ideally that repository url input could also accept an hlx.live or hlx.page url, and just parse out the gh url from there

Platform and Version
google chrome on Mac OS

Looked at this a bit more, and I think (could be wrong here) the go button was broken by https://github.com/adobe/helix-website/pull/206 which turned the h2 into a link, and thus made the selector used to find the go button get the h2 instead.


Disqus support

Disqus support or other similar function.

#12 Using Gitalk instead of disqus. Similar function.


tkinter switching page frames (if needed)

https://www.geeksforgeeks.org/tkinter-application-to-switch-between-different-page-frames/
https://stackoverflow.com/questions/7546050/switch-between-two-frames-in-tkinter

implemented


Bug on iOS devices when body is positioned relatively

When body element has style position: relative sweet alert assigns it's top property for iOS devices so when alert dissapers I can't scroll back to top of the page because content is cutted off. You can check it on the demo page by setting position: relative and enabling device mode.

Should be fixed if we reset document.body.style.top in undoIOSfix.

Thank you! Will be waiting for fix!


Unable to successfully call PETSc function

*** -------------------------------------------------------------------------
*** Error:   Unable to successfully call PETSc function 'KSPSolve'.
*** Reason:  PETSc error code is: 73.
*** Where:   This error was encountered inside /home/juanlu/miniconda/conda-bld/work/dolfin-1.4.0/dolfin/la/PETScKrylovSolver.cpp.
*** Process: unknown
***
*** DOLFIN version: 1.4.0
*** Git changeset:
*** -------------------------------------------------------------------------

This error was produced by the code below. I encountered other Unable to successfully call PETSc function-errors, too.
from dolfin import *
mesh = UnitSquareMesh(2, 2)
V = FunctionSpace(mesh, 'CG', 1)
u = TrialFunction(V)
v = TestFunction(V)
a = inner(grad(u), grad(v))* dx
f = Expression('x[0]*x[1]')
b = f * v * dx
p = a + u * v * dx

A = assemble(a)
B = assemble(b)
P = assemble(p)

class CompositeOperator(object):
    def __init__(self, A, B, C):
        self.A_mat = as_backend_type(A).mat()
        self.B_vec = as_backend_type(B).vec()
        self.C_vec = as_backend_type(C).vec()

    def mult(self, mat, x, y):
        self.A_mat.mult(x, y)
        a = self.C_vec.dot(x)
        y.axpy(a, self.B_vec)

    def as_petscmatrix(self):
        from petsc4py import PETSc
        mat = PETSc.Mat().createPython(self.A_mat.getSizes(), comm = mpi_comm_world())
        mat.setPythonContext(self)
        return PETScMatrix(mat)

# Apply boundary conditions
bc = DirichletBC(V, 1., "x[1]<DOLFIN_EPS")
bc.apply(A)
bc.apply(P)
C = B.copy()
bc.homogenize()
bc.apply(B)

A_B = CompositeOperator(A, B, C).as_petscmatrix()

solver = PETScKrylovSolver('gmres', 'hypre_amg')
solver.set_operators(A_B, P)

solution = Function(V)
solver.solve(solution.vector(), C)

There's definitely something happening if my paths appear in your computer. I'll have a look.

By the way @mthewissen, while I figure out how to fix the paths issue, would you also ask about the error in the fenics-support mailing list or http://fenicsproject.org/qa? Maybe if there's something wrong with the code itself we'll get some hint.

For reference, error 73 is "object in argument is in wrong state, e.g. unassembled mat".
http://www.mcs.anl.gov/petsc/petsc-master/include/petscerror.h.html

I encountered the problem in this qa question.
http://fenicsproject.org/qa/7954/apply-dirichlet-boundary-conditions-using-matrix-free-method
I also asked a new one:
http://fenicsproject.org/qa/8060/petsckrylovsolver-wont-solve-in-version-1-4-0
Thanks for looking into it

So it works on 1.6 and not on 1.4, right? Please ping me if someone else proves it right on FEniCS Q&A so I can focus on fixing the paths issue :) Thanks!

Correct. However, for 1.6 I use the FEniCS version from the ubuntu
repositories (no conda) so I am not sure if that is much help.
On 8 September 2015 at 18:42, Juan Luis Cano Rodríguez <
<EMAIL_ADDRESS>wrote:

So it works on 1.6 and not on 1.4, right? Please ping me if someone else
proves it right on FEniCS Q&A so I can focus on fixing the paths issue :)
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/Juanlu001/fenics-recipes/issues/28#issuecomment-138626971
.

If you check the second Q&A question, you will notice that a solution was posted to get rid of the error. Another Unable to successfully call PETSc function-error was also solved (mistake from me), so that leaves you with the question why your path appears.

Thanks for the update! I will change the title accordingly then.


Remove deadcode ISTIO_METADATA_DISCOVERY flag

This is not used at all

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


:sparkles:  prow: use image ghcr.io/kcp-dev/infra/build:1.23.4-1

Continuing with https://github.com/kcp-dev/infra/issues/78, this PR uses the newer tag of the build image that contains go1.23 toolkit.

/lgtm
/approve

golangci-lint is compatible up to the Go version used to compile it.
v1.58.1 we use is too old:
$ ./golangci-lint version
golangci-lint has version 1.58.1 built with go1.22.2 from dc281531 on 2024-05-08T18:53:57Z

The last commit I pushed bumps the linter to v1.62. Let me know if you prefer to do it in a separate PR.

/lgtm
/approve

/approve
@sttts I think I dont have approval in here

/ok-to-test


[CSS] Motion Path docs tasks, Fx 70

Trello: https://trello.com/c/Ef3V38Yh/212-css-motion-path-fx-70
Acceptance criteria

[x] [motion-1] Support <offset-anchor>

offset-anchor page created: https://developer.mozilla.org/en-US/docs/Web/CSS/offset-anchor

Note added to Fx 70 rel notes: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/70#CSS

MDN Group Name for "CSS Motion" changed to "CSS Motion Path", as I believe this more correct, and it stops the landing page links in the sidebar breaking: https://github.com/mdn/data/pull/388

Other updates:

compat data added: https://github.com/mdn/browser-compat-data/pull/4837
interactive example added: https://github.com/mdn/interactive-examples/pull/1442
group name fixed, to stop some links breaking: https://github.com/mdn/data/pull/388
aforementioned release note removed again because I then realised it is behind a pref!

One thing to note: for <position> value, we retire the 3 value syntax already (except for <background-position>), in Bug 1559276.
The resolved spec issue is https://github.com/w3c/csswg-drafts/issues/2140.

This means these examples:
offset-anchor: bottom 10px right;
offset-anchor: top right 10px;

may need to be updated.
For other parts, looks good to me. Thanks for the documentation.

Cool, thanks for the review @BorisChiou !
I've removed the 3-value examples, and added a note to https://developer.mozilla.org/en-US/docs/Web/CSS/offset-anchor#Values.
We are actually documenting that change separately, as part of https://github.com/mdn/sprints/issues/2084

Cool! Thanks!

Should have been closed a while ago


Saving an explainer as a pickle

Hi, I'm trying to save an explainer to disk, but I'm getting the following error:
/usr/local/Cellar/python/3.6.4_4/Frameworks/Python.framework/Versions/3.6/lib/python3.6/pickle.py in save(self, obj, save_persistent_id)
    474         f = self.dispatch.get(t)
    475         if f is not None:
--> 476             f(self, obj) # Call unbound method with explicit self
    477             return
    478

/usr/local/Cellar/python/3.6.4_4/Frameworks/Python.framework/Versions/3.6/lib/python3.6/pickle.py in save_global(self, obj, name)
    920             raise PicklingError(
    921                 "Can't pickle %r: it's not found as %s.%s" %
--> 922                 (obj, module_name, name))
    923         else:
    924             if obj2 is not obj:

PicklingError: Can't pickle <function BaseDiscretizer.__init__.<locals>.<lambda> at 0x1074dd840>: it's not found as lime.discretize.BaseDiscretizer.__init__.<locals>.<lambda>

Running the following:
from sklearn.externals import joblib
explainer = lime.lime_tabular.LimeTabularExplainer(train, feature_names=feature_names,
                                                  class_names=class_names,
                                                  categorical_features=categorical_features,
                                                  categorical_names=categorical_names,
                                                  kernel_width=3)
joblib.dump(explainer, 'explainer.pkl')

Are there any plans to support storing of explainers?

use dill. See also #126, #98, #61


Formfeed->Page

CLHS mentions Page as "The form-feed or page-separator character",
both ECL and ABCL don't recognize Formfeed, while in SBCL it's an
alias for Page. So changing Formfeed to Page in jzon makes it work
with ECL and ABCL in addition to SBCL.
(Tested with SBCL 2.1.8, ECL 21.2.1, ABCL 1.8.0 and HEAD of jzon)

Thanks !


Add as_awkward and as_pandas, etc

Fixes #96

Codecov Report

Merging #106 (8ba1def) into master (9df9476) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   97.25%   97.25%
=======================================
  Files          13       13
  Lines        1273     1277    +4
=======================================
+ Hits         1238     1242    +4
  Misses         35       35

Flag
Coverage Δ

unittests
97.25% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

func_adl/object_stream.py
98.93% <100.00%> (+0.04%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Drop experimental flag for Nitrokey 3 firmware update on Windows

Drop experimental flag for Nitrokey 3 firmware update on Windows

@robin-nitrokey Anything against?

As discussed, this will be dropped in the next release.
cc @daringer


Error when deploying on heroku, but not locally or on streamlit cloud

Hi,
I'm getting a weird formatting error when deploying on heroku:

Links are functional, but the rendering is completely off.
It does work on local or on streamlit cloud:

Have you run into this issue? Might be a configuration/permissions taks on heroku, but I haven't found a solution yet!

Now it's showing this:

Got an answer by twitter. Seems to be working now. Closing the issue.

got same internally. Usually, it is resource issue. bump up memory / cpu.


Non-fatal errors are suppressed in dev environments

Is there any way to display warnings in dev environments? Currently they seem to be logged but not reported: https://github.com/camspiers/silverstripe-loggerbridge/blob/master/src/Camspiers/LoggerBridge/LoggerBridge.php#L413

Fixed in f3d76be925764fbfcbc10c1e1092f97ac08dc3fb


replace the fourth quadrant to show how much a source country imports and exports to a target country

In 2020 did the United States import more to the Netherlands or export more to the Netherlands?

Leave for now.


[libconfig] update to 1.7.1

I just changed these libs ports to use the last version (dec2017).
Patches, dirent and scandir is unnecessary for libconfig 1.7.1; and shlwapi is now required.

Thanks!


repos#getContent doesn't expect the correct params ans returns an array of repos

It's me again, I'm having an issue with repos#getContent. It expects param org (user, repo, path, ref reading the doc) and return a array of repos, basically all of them (first page).

Where are you seeing the org param?
https://mikedeboer.github.io/node-github/#api-repos-getContent
https://developer.github.com/v3/repos/contents/#get-contents
This should work:
var GitHubApi = require("github");

var github = new GitHubApi({
  debug: true
});

github.authenticate({
    type: "oauth",
    token: <token>
});

github.repos.getContent({
  user: "mikedeboer",
  repo: "node-github",
  path: "README.md"
}, function(err, res) {
  console.log(err, res.content);
});

Oooops, my bad ... this is working very fine. I'm wrapping up the method calls into promises and I was just invoking the wrong one :/ sorry about that.


Native Client for NodeJS

Is there planned support for a native nodejs client utilizing libsiridb as a C addon?
I can make due with the HTTP interface for now, but you would love to have a native nodejs client to reduce the HTTP overhead.

I like the idea for creating a nodejs addon. Since nodejs is running on libuv it will probably not be very hard to write the addon. I will take a look at this soon.

Added the following repo: https://github.com/transceptor-technology/siridb-nodejs-addon
The concept already works but I still need to make the insert handler. In this concept the query data is returned as a json string which is a little inefficient since we could just as well return a JavaScript Object immediately. To Be Continued...

query handler now returns a Javascript Object. For example:
siridb.query("select * from 'aggr'", (resp, status) => {
    console.log(status);  /* 0 when successful, or a negative value
                             in case of an error */
    console.log(resp);  /* response data or in case of an error
                           resp.err_msg contains a description */

    /*
    Example response:

    { aggr:
       [ [<PHONE_NUMBER>, 531 ],
         [<PHONE_NUMBER>, 534 ],
         [<PHONE_NUMBER>, 535 ],
         [<PHONE_NUMBER>, 531 ],
         [<PHONE_NUMBER>, 532 ],
         [<PHONE_NUMBER>, 537 ],
         [<PHONE_NUMBER>, 530 ],
         [<PHONE_NUMBER>, 520 ],
         [<PHONE_NUMBER>, 54 ],
         [<PHONE_NUMBER>, 54 ],
         [<PHONE_NUMBER>, 513 ],
         [<PHONE_NUMBER>, 537 ],
         [<PHONE_NUMBER>, 528 ],
         [<PHONE_NUMBER>, 531 ],
         [<PHONE_NUMBER>, 533 ],
         [<PHONE_NUMBER>, 538 ],
         [<PHONE_NUMBER>, 534 ],
         [<PHONE_NUMBER>, 532 ],
         [<PHONE_NUMBER>, 533 ],
         [<PHONE_NUMBER>, 537 ] ] }

    Another example response (error):

    { error_msg:
        'Query error at position 9. Expecting =>, prefix, suffix, , or from' }

    */
});

Insert handler is created, for example:
siridb.insert([{
    type: 'float',
    name: 'some float series',
    points: [
        [1505118253, 5.4],
        [1505118307, 7.1]
    ]
}, {
    type: 'integer',
    name: 'some integer series',
    points: [
        [1505118253, 5],
        [1505118307, 7]
    ]
}], (resp, status) => {
    // status == 0 when successful
    // resp.success_msg contains a success message and in case of an
    // error resp.error_msg contains details about the error.
});

Hostname resolving is implemented. The address can now be an IPv4, IPv6 or a DNS name.
Release an initial version: https://github.com/transceptor-technology/siridb-nodejs-addon/tree/0.0.1

This is awesome thank you!
I will have some time in the next couple of week to give this a shot, but thank you so much for implementing this!


[Shadowrun 5th] fix warnings

Changes / Comments
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.

Hi there,
When clicking "modify", I cannot reorder the items in equipment list.
Tried this in Chrome and Firefox but no success.
A white arrow appears
but nothing can be moved. Is there a trick?
Also, the sheet seems to be unable to import Chummer contacts and Lifestyles.

Currently the sheet does not provide functionality for contacts and SINs. You can open separate issues for each.
I can reorder without problems on firefox. Drag and Drop the three lines in front.

I tried and re-tried drag and drop, as any typical drag-drop gesture, with no result,
Except that sometimes, when I try and try, an item "magically" moves elsewhere on the sheet (as on the attached jpeg). Weird...

A clip of the drag-drop problem. Nothing moves. I disabled all my add-ons and tried on Chrome and Firefox. Not working.

@Arkundar this is not the right place. Open an issue for your problem


changed www to a jsfile and added start and pre start scripts to make initialization easier

extension of #31

The pre and post start stuff is interesting, the rest (port change, the change of the name of the executable and adding you as a maintainer) isn't the direction I want to go with this. Happy to merge if you correct those things.

Hey @anders94
I've reverted the maintainers back to the original version and changed the port back to 3000.
Running the node server requires a .js file
I'll look into nodejs and docker integration to see if we can improve

I found this on Docker-Nodejs webapp

I tried remodifying binary to work with nodejs and instantiate the docker image but it fails to run
I shall try executing the binary from the package.json file itself
In the meantime, we can leave it as it is until we find a better alternative
My reference list:

Docker practice
Docker run
Running bin executable:feature req

This article talks abouts running binaries from inside the node_modules folder, what are your thoughts on that ? @anders94


How to reproduce your results?

Thanks for sharing your excellent work.
I downloaded your checkpoint, and run runner.sh without training, and got the following results:
Evaluating SVHN
Evaluating places365
Evaluating LSUN
Evaluating iSUN
Evaluating dtd
OOD detection method: SSD+
FPR    AUROC  AUIN
SVHN          93.04  47.28
places365     92.86  56.91
LSUN          84.43  56.97
iSUN          88.55  62.62
dtd           94.50  38.18
AVG           90.68  52.39
15.235417604446411
What did I do wrong?   Thanks a lot.

Could you please double check that the save model is successfully loaded to GPU? Since the time used for evaluation only shouldn't be that long. I'm able to reproduce the results using the shared checkpoint model weights.

I retrained and retested, got the following results,
23.542145490646362
Evaluating SVHN
Evaluating places365
Evaluating LSUN
Evaluating iSUN
Evaluating dtd
OOD detection method: SSD+
FPR    AUROC  AUIN
SVHN           2.77  99.42
places365     64.68  83.01
LSUN          18.75  96.56
iSUN          35.20  92.63
dtd           36.60  92.43
AVG           31.60  92.81
1.4728095531463623
So it  is good.  Thank you.


Token caching example needs some work for desktop bridge apps

RE: System.Reflection.Assembly.GetExecutingAssembly().Location in the example.
This doesn't work for packaged desktop apps (also called desktop bridge) since that location is read-only. To fix that you need to use Windows.Storage.ApplicationData.Current.LocalCacheFolder.Path + "\msalcache.bin" which is a per-app read/write folder for packaged apps.
https://developer.microsoft.com/en-us/windows/bridges/desktop/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7a27a93-a596-114e-6bc2-7a8ab5b20ef2
Version Independent ID: 54077d4d-6f1c-5a92-9d61-0533f85628fe
Content: Acquire a token to call a web API (desktop app) - Microsoft identity platform
Content Source: articles/active-directory/develop/scenario-desktop-acquire-token.md
Service: active-directory
Sub-service: develop
GitHub Login: @jmprieur
Microsoft Alias: jmprieur

@chitturs Thank you for your feedback . We will investigate and update the thread.


I am not receiving notification on iOS and can't run anyother code in the background when receiving notification

Hello
I am getting this error on iOS when I receive notification and it is breaking the code as no other code will run afterwards
flutter: type '_InternalLinkedHashMap<Object?, Object?>' is not a subtype of type 'Map<String, Object>'
flutter:
#0      ZPNsEventHandlerImpl.eventListener (package:zego_zpns/src/internal/zpns_event_handler_impl.dart:50:21)
#1      _RootZone.runUnaryGuarded (dart:async/zone.dart:1586:10)
#2      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#3      _DelayedData.perform (dart:async/stream_impl.dart:515:14)
#4      _PendingEvents.handleNext (dart:async/stream_impl.dart:620:11)
#5      _PendingEvents.schedule. (dart:async/stream_impl.dart:591:7)
#6      _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
#7      _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)

Is the 'Push type' for iOS Offline Push in the Zego Console not set to 'APNs'?

do you directly use Android Studio or Xcode to run the app for testing?
if you want to test the offline push notification feature on an iOS device, you need to publish your application to a testing platform (such as TestFlight or HockeyApp) and conduct the test, instead of running the application directly through Android Studio or Xcode. This is because iOS devices can only receive offline push notifications after the application has been published. Therefore, if you need to test the offline push notification feature, you must publish the application to a testing platform and invite testers to conduct the test.

the issue has been too long without a reply, so it is closed.


Generate code documentation (doxygen-like)

Got basic Sphinx setup and first sample files done. Now we just have to create the docs.

Documentation is online https://modelhub.readthedocs.io and build automatically by readthedocs.


Detect ghost text in PromptInputModel

Fixes #210662
Ghost text will show up in brackets in the devmode status bar:

I tested this on PowerShell but it should work on any shell that uses dim or italic as ghost text.
cc @cpendery

This is how I've been detecting ghost text since I've seen variation between zsh-autocomplete, atuin, xonsh, etc. Might be helpful to augment _isCellStyledLikeGhostText with
https://github.com/microsoft/inshellisense/blob/a7219b18355f444ba6ed5c4322121b01b8c18291/src/isterm/commandManager.ts#L200-L212


New version is unforgiving for trailing spaces

every '47 */6 * * * ' do
  # ...
end

produces error ArgumentError: Couldn't parse: 47 */6 * * *
My issue was resolved by removing the trailing space manually however it's a backward incompatible change with a misleading error message

The backward compatability is something we have to live with until we cut v1.0, but we can do a better job with the error message by calling #inspect on the value so it would read:
ArgumentError: Couldn't parse: "47 */6 * * * "
Is this something you would be prepared to submit a PR for?


Plugin breaks after a few whitelists?

The plugin breaks every now and then. When people try to whitelist, nothing happens. I look in console and see a bunch of errors, I can fix this temp by reloading the plugin but then it happens again after the second whitelist or something.

Do you have the log containing the errors you are getting? Without any info there is little I can do to help you.

Yes but how do I send it?

Yes but how do I send it?

@DocGoose49 Upload to https://paste.gg/ if the errors are a big one (if its less than 5 lines then copy and paste it like this)
ERROR INSERTED
I'd recommend making sure the log pasted DOES NOT contain sensitive information such as IP's/Usernames and so on


[3405] Add hesa_id field to trainees

Context
https://trello.com/c/9o6CJJ7d/3405-link-the-trainees-created-from-hesa-records-back-to-hesa
Changes proposed in this pull request

Add a new field hesa_id to trainees
Populate this field when we create Register trainees from DTTP

Guidance to review
Important business

Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

 Link the trainees created from HESA records back to HESA

Ahem... "Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?" 😆

Ahem... "Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?" 😆

I'm also concerned about the 77 failing tests 😂


Address verification via external API

Verifying addresses exist will come up as a feature to add into Customers. We would do this with several external API's as various customers will have existing deals with vendors and want to use them.
Edit: Lots of these services will support bulk API's, so would it be acceptable for Customers to check addresses in an async fashion? Does Customers need to re-check the address on some interval?

The top result I looked at was SmartyStreets

Pricing
Go SDK [GoDoc]

we use Smartystreets and its great, easy to use and robust ... the other thing you'll want to think about long term though is NCOA - just about every bank tracks change of address on their customer base and NCOA "APIs" are. much more of a pain ... this is something people would definitely love to have and need in the industry

I can't believe Smarty Streets dropped NCOA support. They had the best solution in the market.


Can't slide to the maximum value

<MultiSlider
values={[props.answerVal.duration]}
onValuesChange={(value)=>answer(value, 'duration')}
max={6}
min={2}
step={1}
// containerStyle={styles.stepContainer}
sliderLength={410}
selectedStyle={{ backgroundColor: 'rgb(37, 75, 135)' }}
unselectedStyle={{ backgroundColor: 'rgb(37, 75, 135)' }}
snapped
/>
I can't slide any further

after restarting Expo, It's worked fine.

Still having this issue. Is anyone else experiencing this?
In our example we have a single slider marker, and snapped is false.

Still having this issue.
Not using expo, and I have single slider marker, snapped is false
<MultiSlider
          sliderLength={metrics.screenWidth - 120}
          min={0}
          max={3}
          values={values}
          onValuesChangeFinish={onValuesChange}
          trackStyle={styles.sliderTrackStyle}
          selectedStyle={styles.sliderTrackStyle}
          snapped
          customMarker={() => <View style={styles.sliderMarker} />}
 />

The weird thing is that sliding to the maximum value at first is working. But when i slide to another value, from then it doesn't slide to the maximum value anymore

The workaround that worked for me was to use allowOverlap={true}

Yeah, allowOverlap={true} works when we only have one element inside values.


Reduce size of nested JSON test to 252 deep

I got confused running git on the tester with my last commit for #3101.
This should clean it up.

This passed on internal CI: http://manhattan.ci.chef.co/view/Chef/job/chef-test/54/

@chef/client-core if I can get a couple :+1: on this, it makes manhattan green. This fixes #3101 by doing the same thing as #3102 but better.

:+1:

:+1:

:+1:


error while trying https JSON request

hi Igor ,
Kindly assist in below error  , I had tried to run the server on 8080 based on your instructions
command 1:
node socketQueue.js --upstreamHost=<IP_ADDRESS> --upstreamPort=5000 --listenHttpPort=8080 --vv --logFile=log.txt
command 2:
curl -H "Content-Type: application/json" -X POST -d '{ "0": "0200",  "3": "0",  "4": 1000,  "7": "0818160933",  "11": 618160,  "12": "150820130600",  "22": "056",  "24": "200",  "25": "00",  "35": "4850781234567891=19082012232800000037",  "41": 992468,  "42":<PHONE_NUMBER>43,  "49": "810",  "55": "9f2608571f1e10d4fa4aac9f2701809f100706010a03a4b8029f37045bb074729f3602000c950500800010009a031508189c01009f02060000000010005f2a02064382023c009f1a0206439f03060000000000009f3303e0f0c89f34034403029f3501229f1e0835313230323831358407a00000000310109f41030000565f340101" }' http://localhost:8080
**the error i got :
curl: (3) [globbing] unmatched close brace/bracket in column 1
{"result":"","errors":["SyntaxError: Unexpected token ' in JSON at position 0"]}**

when i tried by POSTMAN  i got the below error:
{
"result": "",
"errors": [
"Packet is expired!"
]
}

Hi. I guess this is not the curl command you have actually used. The one you provided here is fine. There is no issue here.
Packet expiration is determined by the field 7 value.


add example:docker moderate-mysql-phpmyadmin-stack

I completed task 39: create MySQL and PhpMyAdmin containers and config them moderate-mysql-phpmyadmin-stack
volumes binding and using different networks is also taken into account

Check your code before making a pull request. It should completely work.
I solve it now. Thanks.


Prompt Optimization without CLIP Loss

Hello authors,
I was wondering the possibility of utilizing stable diffusion MSE loss instead of CLIP loss in PEZ's algorithm. Then, we can optimize the prompt directly through the generator's gradient. What is your take on this?

It just shows how versatile the algorithm is. https://arxiv.org/abs/2302.07121 In this paper, the authors use the predicted clean image x_0 (rather than x_t) to calculate the loss. Maybe this could be a way around the expensive computation. Thanks for sharing your opinion and for your work.

hey i wanted to add my 2¢ to this, mostly because i'd love to see it work under a more general setting :)
from what i can surmise @josejhlee's suggesting to find a gradient update which pushes the prompt to generate the ground truth image:
model($f_{clip}$ + $\Delta$) $\sim$ image
which is found via minimizing the loss wrt the difference between generated image and the ground truth, mse($gen-gt$).
however note the same prompt embedding can generate a different image with a different initial noise, which i deliberately omitted above, i.e., model($f_{clip}$ + $\Delta$, $noise_{init}$).
therefore, when you are optimizing above updated objective w/ the noise, you may need to optimize the noise as well, which of course is a more complicated task.
i know of a way to sorta get the noise used from the generated image by inversing the process, e.g., here: https://www.reddit.com/r/StableDiffusion/comments/xboy90/a_better_way_of_doing_img2img_by_finding_the/
~ having taking a look the paper jose referenced, it seems like there is some similarities w/ above:
"The key idea of backward guidance is to optimize for a clean image that best matches the prompt based on zˆ0, and linearly translate the guided change back to the noisy image space at step t."
i guess the clever bit is to come up with an equation that optimizes for the best prompt given a noisy image, next level of noise, where the error model $\epsilon$ is constant, and we find the prompt embedding which needs to be optimized for all noise levels, such as
$x_t=x_{t-1}+\epsilon$ for all t.

@ozanciga
Yes, either noise (the paper i linked) or the prompt embedding. In "Null-text Inversion for Editing Real Images using Guided Diffusion Models", they do exactly what u wished for: optimize the null token for every step. Definitely a feasible direction. Thanks for sharing ur take.

Hi @josejhlee, @ozanciga, apologies for my delayed response. I had a busy week.
I have updated the code and added an example of how to optimize for the hard prompt through the diffusion model here. While it is still a work in progress, I believe it is effective. The current implementation involves randomly sampling a time step for each optimization step and calculating the MSE loss between the reconstructed noise and the ground-truth noise added to $x_0$. Additionally, every 50 steps, the current prompt is fed to the stable diffusion, and the CLIP score between the generated images and the target image is calculated to choose the best prompt.
I will keep optimizing the code, and any suggestions and pull requests are welcome!
Note: the current code requires ~20GB of GPU memory and ~10 mins for 1000 steps.

Thanks for your hard work, the insight from this experiment is well appreciated!


Upgrade dependency versions

It's been a while, let's upgrade everything.

Note that JSON Jackson is kept on 2.15.4, and not upgraded yet due to what appears to be a regression bug in Jackson.

Bug noted: https://github.com/FasterXML/jackson-databind/issues/4233#issuecomment-2203683921
Caused by: https://github.com/FasterXML/jackson-databind/issues/3838
Caused by (PR): https://github.com/FasterXML/jackson-databind/pull/3868

Relevant Issue raised: https://github.com/FasterXML/jackson-databind/issues/4607
PR: https://github.com/FasterXML/jackson-databind/pull/4612


fix broken links: add .html route slugs to download, learn, community

https://www.scala-sbt.org/download.html currently has a 404, and then it seems a redirect.
With these changes we restore the original links, and it seems the new routes still work
fixes #1181

It seems like it only worked on local build, not on the live site


Add '$specifichide' modifier to disable specific element hiding and CSS rules

Details: https://github.com/AdguardTeam/AdguardBrowserExtension/issues/1514

Spec:
##### specifichide

Has an opposite effect to `generichide`. Disables all specific element hiding and CSS rules, but not general ones.

    @@||example.org^$specifichide — will disable example.org##.banner but not ##.banner.


Enable Synk Security Scanning

https://github.com/snyk/actions

We don't need to use GitHub Actions for this. There is a default snyk.io webhook that does all the work with pretty much zero setup.


multiple plural forms not supported?

I am trying to use the documented i18next() feature that forks single/plural based on varying levels of count. (see: http://i18next.com/pages/doc_features.html @ Multiple Plural Forms). My JSON includes the following:

{
"Title": "One Item",
"Title_plural_0": "No Items",
"Title_plural_2": "Two Items",
"Title_plural_3": "A Few Items [%s]",
"Title_plural_9": "Many Items [%s]"
}

I am calling this from a template with the following line, where itemcount is a template helper that returns the number of items in the returned document set:

{{_ "Title" itemcount count=itemcount}}

The translation only seems to work with simple singular/plural definitions. In the example above, I get the "Title" definition, independent of the number of items actually returned. Adding a plural JSON entry like the one below returns the correct plural text for any value > 1, as well as the correct value returned using itemcount:

{
"Title": "One Item",
"Title_plural": "%s Items"
}

Since tap-i18n uses "count=n" instead of the i18next "{ count: n }" format, I am thinking this might not be implemented, or that I need a workaround to correctly access the underlying library. Can't find it googling or in documentation.
Help?

Just waht I was thinking. I think the "zero" case is a must have!
Cheers!
JM

I was searching for the same thing, but I cannot find any solution yet.
Any update here?

i18next v1.11 don't have complete rules to all languages.
You'll have to clone this rep into your packages folder and add the rule for zero here:
https://github.com/TAPevents/tap-i18n/blob/master/lib/tap_i18next/tap_i18next-1.7.3.js#L1490
If you have an overall solution, please send PR.
Thanks

Thanks for reviewing this issue, theosp. I'll look into the way TAP has implemented this -- maybe there is a workaround available. At first glance, it looks as though a generalized and coded solution (in the i18n package) is being limited by the coded plurals in the section you highlighted for us. I was expecting more of a "pass-through" framework, where the JSON outlined above would allow me to supply plural forms myself, without them being enumerated in TAP directly.
Could you explain in a few words how that section of TAP code is intended to work? IT would help me avoid extra effort building (or rebuilding) an "any plurals" solution.
Many thanks!

The highlighted code isn't mine (3rd party lib), so, just like you I'll
have to study it to come up with solution.
-Daniel
On Tue, Jan 26, 2016 at 9:47 PM, thewaywest<EMAIL_ADDRESS>wrote:

Thanks for reviewing this issue, theosp. I'll look into the way TAP has
implemented this -- maybe there is a workaround available. At first glance,
it looks as though a generalized and coded solution (in the i18n package)
is being limited by the coded plurals in the section you highlighted for
us. I was expecting more of a "pass-through" framework, where the JSON
outlined above would allow me to supply plural forms myself, without them
being enumerated in TAP directly.
Could you explain in a few words how that section of TAP code is intended
to work? IT would help me avoid extra effort building (or rebuilding) an
"any plurals" solution.
Many thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/TAPevents/tap-i18n/issues/125#issuecomment-175021159.

I see, thank you.
It looks as though it needs to return something for "0", and for almost all languages that line is not present. Arabic would appear to handle this correctly:
        "ar": {
            "name": "Arabic",
            "numbers": [
                0,
                1,
                2,
                3,
                11,
                100
            ],
            "plurals": function(n) { return Number(n===0 ? 0 : n==1 ? 1 : n==2 ? 2 : n%100>=3 && n%100<=10 ? 3 : n%100>=11 ? 4 : 5); }
        },

While English does not:
        "en": {
            "name": "English",
            "numbers": [
                1,
                2
            ],
            "plurals": function(n) { return Number(n != 1); }
        },

I don't have time to meddle with that code at the moment, but it would seem that if languages include a zero-case, the rest might flow correctly. English would be rewritten as such:
        "en": {
            "name": "English",
            "numbers": [
                0,
                1,
                2
            ],
            "plurals": function(n) { return Number(n===0 ? 0 : n==1 ? 1 : 2 ); }
        },

There is probably a more generalized function that will be more efficient and look similar across languages. This is 3rd party but hard-coded into TAP, correct? I could send a rewrite for your testing if helpful...

... and actually, I hadn't expected the plural forms would be handled for me anyway, and would prefer to control them myself in the localized JSON (as described in the lead question). Is it possible to simply discard the 3rd party code (which is incomplete as it stands), or provide a workaround option for us? Thanks again for thinking about this.

Late answer, but I have a working solution without fork.
In both client/server side, you can add a rule directly to i18next:
TAPi18next.pluralExtensions.addRule("en", {
    "name": "English",
    "numbers": [ 0, 1, 2 ],
    "plurals": function(n) {
        return Number(n === 0 ? 0 : n === 1 ? 1 : 2);
    }
});

Then in the i18n files:
nb_jobs_running: "One job is running"
nb_jobs_running_plural_0: "No running job"
nb_jobs_running_plural: "__count__ jobs are running"

At this stage, it works only after a language switch, not when the page is loaded.
Calling TAPi18next.pluralExtensions.setCurrentLng explicitely after Meteor.startup seems to fix this issue.


403 Error when adding datasource

I get a Network Error: Forbidden (403) error when adding Flux as a datasource:

I'm using Grafana v6.1.6, InfluxDB v1.7.5 and the plugin version is v5.2.11. I've tried with and without Basic Auth but I still get the same error.
I can connect to InfluxDB using the default InfluxDB datasource with the exact same settings.
This is the InfluxDB log when trying to test the connection:
[httpd] ::1, ::1,<IP_ADDRESS> - admin [30/Apr/2019:12:35:11 +0100] "POST /api/v2/query HTTP/1.1" 403 100 "-" "Grafana/6.1.6" 03bcb689-6b3c-11e9-8053-0050b68e29b3 0

Interestingly, when I test the default InfluxDB data source, the end point is different:
[httpd] ::1, ::1,<IP_ADDRESS> - admin [30/Apr/2019:12:38:05 +0100] "GET /query?db=rb3043&epoch=ms&q=SHOW+RETENTION+POLICIES+on+%22rb3043%22 HTTP/1.1" 200 149 "-" "Grafana/6.1.6" 6b72a3ba-6b3c-11e9-8054-0050b68e29b3 2000

Apologies for my stupidity. I had enabled flux in the config file but hadn't specified the config file when starting influxd.exe.

Apologies for my stupidity. I had enabled flux in the config file but hadn't specified the config file when starting influxd.exe.

Hi, how do we specify the config file while starting the influxd.exe, I am facing the same issue network forbidden ( i have made http_enabled= true)


[$250] Negative amount displayed in Pay with Expensify Dropdown Button and Confirm payment amount Modal

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.74-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ikevin127
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1715813045792699
Action Performed:
Prerequisite : Have one existing account (A)  and one newly created account (B)

Login as new user (B) in a browser
On the “What do you want to do today?” modal choose “Manage my team's expenses” and Continue.
3, Input business name and Continue.
Input First and Last Name and Continue.
On the “Welcome” modal click Get Started.
Log in as an existing user (A) in incognito or in another browser
Click FAB > Submit expense > Manual > enter any amount and select the user B
Create one more IOU with user B to have 2 expenses report
Hold one of the expenses
Login to user B account and look for the IOU request from user A (If the report with the existing user does not show-up in LHN then click FAB > Start chat > Input existing user email and start a chat)
Once the chat opens, we should see the two report expenses requested by the existing user with the “Pay with Expensify” green dropdown button.
Click on the report preview showing “2 expenses” at the bottom in order to see the two expenses.
Notice that the report header “Pay with Expensify” green dropdown button shows negative amount like -$7.00.
Click on the “Pay with Expensify” green dropdown arrow button and notice that both options are showing negative amount.
After clicking on the dropdown arrow button > Select “Pay elsewhere”.
Click on the header “Pay elsewhere” button and notice that the “Confirm what to pay” modal also shows negative amount for both options.

Expected Result:
-Report header  “Pay with Expensify” green dropdown button shows  the amount as positive amount
-Clicking  on the header “Pay elsewhere” button “Confirm what to pay” modal also shows positive amount for both options.
Actual Result:

Notice that the report header “Pay with Expensify” green dropdown button shows negative amount like -$7.00.
Click on the “Pay with Expensify” green dropdown arrow button and notice that both options are showing negative amount.
After clicking on the dropdown arrow button > Select “Pay elsewhere”.
Click on the header “Pay elsewhere” button and notice that the “Confirm what to pay” modal also shows negative amount for both options.

Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/a9a56919-16d4-4320-b4d8-159d256cc0c5
https://github.com/Expensify/App/assets/38435837/3b939592-6fea-49b7-9310-ae0bd73ce4ab

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cc7f63f52440c4db
Upwork Job ID:<PHONE_NUMBER>798006347
Last Price Increase: 2024-06-17
Automatic offers:

alitoshmatov | Reviewer | 102858943
dominictb | Contributor | 102858945

Issue OwnerCurrent Issue Owner: @zanyrenney

To me this looks BE-related if we look at the transaction amounts (see C+ Slack 🧵) being a positive number, considering it should be negative as that's how we store it in BE and since we have logic here, here and other places in FE in order to make it positive.

[!note]
If this is BE related, I'd look at the “What do you want to do today?” Modal -> “Manage my team's expenses” flow.

But could also be some mix-up on the FE, not entirely sure 🤔

Thanks for adding these thoughts @ikevin127 !

checking here - https://expensify.slack.com/archives/C01GTK53T8Q/p1716227156290099

Seeing as this is a BE issue and noone has volunteered for it in slack. I think we should reopen if we encounter this via a real user flow rather than the slightly complex reproduction steps above.

Issue is still reproducible on the latest build 1.4.76-2
https://github.com/Expensify/App/assets/78819774/e76f33be-0243-4fbb-acac-f96aff6f879e

Been OOO, this reopened whilst I was out.

As it's still reproducible, assigning external.

@alitoshmatov please can you review the proposal?

bump @alitoshmatov please review the proposal?

bumped in open source: https://expensify.slack.com/archives/C01GTK53T8Q/p1718634671704649

This issue is reproducable without any additional steps. You just need to hold one of the iou transactions and receiving user sees total amount as negative
To expand more I do agree with @ikevin127 's take here
It looks like we are treating expense amount as negative numbers in multiple instances, also this comment indicates the same conclusion.
But this positive amount is working completely fine when using iou normally without holding any transaction.
Before we proceed we should make clear expected values here, @zanyrenney we internal engineer to look at this comments and answer to the following question:

Are total and unheldTotal values positive or negative values?

@dominictb Oh I see, I understand now. I confused iou and expense reports with each other. I was focused on 1:1 chats and testing iou report only. I forgot to test workspace chats where expanse reports are created.

We can go with @dominictb 's proposal
C+ reviewed 🎀 👀 🎀

This confused me for a minute and I had to read through the discussions and look at the code for awhile but it does make sense to me that this is a frontend issue. Appears that we overlooked this particular scenario when implementing the hold functionality for reports.

@blimpich Can you elaborate, which part you think we have a problem. Is this the fact that amounts are in negative when in expanse reports and positive in iou reports?
Should we pause PR or go on with proposed solution?

 When I say "we overlooked" I don't mean you and @dominictb, I mean the original implementors of this code that we are now fixing.
Please proceed forward with the proposed solution.

Did we ever pay out for this issue? @zanyrenney can you make sure we paid for the work done here? I think maybe the automation failed?

The PR was deployed to production on july 16th

We can complete the payment and close the issue
cc: @blimpich @zanyrenney

@blimpich @zanyrenney
Bump

Sorry for the delay @alitoshmatov!
@zanyrenney can we get payment completed and close out this issue soon?

Sure thing @blimpich - on it now.

Payment summary
paid @alitoshmatov  $250 via upwork
paid @dominictb $250 via upwork.


[V1] Breadcrumbs

User Story
As a Sanoma Learning Design System user, I want a user-friendly Accordion Component that can effectively handle various use cases across our educational products. This Accordion Component should be adaptable to convey:
Definition
...
Key Points

...

Acceptance Criteria

Elements

Name
Optional

Level Label
Yes

Separator
Yes

Overflow Menu
No

Panel Slot
No

Variants

Home Level
Link Level
Current Level

States

Idle
Hover
Active
Disabled

A11y

Keyboard Navigation.

Figma Links

Figma Breadcrumbs Component Research

Reference Links

### Tasks
- [ ] https://github.com/sl-design-system/components/issues/744
- [ ] https://github.com/sl-design-system/components/issues/781
- [ ] https://github.com/sl-design-system/components/issues/782
- [ ] https://github.com/sl-design-system/components/issues/783

@arecuenco-dsgn

 those element are more like items / elements of the breadcrumbs, than variants? I guess there will be only one variant here?

Should the current level not be a link (not clickable)?

What's the behaviour, when the link is too long? Adding ... at the end of the link or in the middle? Showing tooltip with the truncated link on hover/focus?

Do we want to have home icon always shown or it should be customisable or it can be other icon as well or icon and text?


Add Stingray talk

thanks for the addition!

Looks like you closed it without merging.

oops. sorry. clicked the buttons too fast


Invalid behaviour with pointers

Source code
package main

import "fmt"

var P = new(int)

func main() {
        fmt.Println(*P)
        *P = 32
        fmt.Println(*P)
        *P++
        fmt.Println(*P)
}

Scriggo output
0
32
4

gc output
0
32
33

Details
Note that this issue has been opened after closing https://github.com/open2b/scriggo/issues/916.

A simpler version of this issue:
package main

func main() {
	p := new(int)
	*p = 1
	*p += 5
	println(*p)
}

Note that this code:
package main

func main() {
	p := new(int)
	*p = 1
	print(*p)
	*p += 5
	println(*p)
}

works as expected. The only difference with the previous one is the addition of the call to print(*p).


Map/Set IteratorResults now always have a value

IteratorResults returned from map.keys(), map.entries(), and
map.values() used to return an object {done: true}, with no value
property, when they were done. However, that triggered a bug in
Array.from implementations that didn't conform to the spec. This bug
exists in native and polyfilled implementations--including this one!
The bug causes Array.from to convert an affected iterator into an empty
array, demonstrated here.
It IS a bug in Array.from and not in this implementation, in fact: the
IteratorResult interface specifies that the value property
"may be absent from the conforming object", but unfortunately, both
native and polyfilled implementations of Array.from don't respect that
(at least in Chrome, which is a popular browser, I'm led to believe.)

(I have access to a SauceLabs instance, so I was able to run a full suite, unlike our friend Circle here.)

It will be fixes for #816 and #844.

Can we use this fix in next version 3.13?

This is now live on http://qa.polyfill.io - would you be able to report back whether we have fixed your issue?

@JakeChampion Confirmed in IE11--your Array.from and Map polyfills work together like gangbusters. However, the Map polyfill still does not work with Chrome's native Array.from. I'm not sure why this is, and it's less of an issue because there are very few environments that support one but not the other. Nevertheless I thought I should mention it. Demonstration: http://jsbin.com/lefapefeje/1/edit?html,js,console
(Note that you'll have to accept the invalid SSL certificate for your QA host before the polyfill comes through at all.)

Seems like there are 2 problems.

Symbol.iterator is rewritten.
Some methods such as .values() return a not iterable value (not having a [Symbol.iterator]() method).

@zetlen Could you make a new issue which decribes the bug you are seeing?
Thanks for this work by the way :-)
Did you know we offer one month's free premium access to all FT content (normally $50) to anyone who has a pull request merged in this repository? If you want to claim it, there's one Google form to fill out :-)

@JakeChampion The work is its own reward, but I won't look a gift Financial Times in the mouth. Thanks a million! I'll open a separate issue.

@JakeChampion Just so you know, I just tried to produce a failing test for this within your existing framework. There's no browser environment which supports Array.from but not Map, so this is an extreme corner case. Still think it's worth a PR?

Hmm, probably not then, thanks for investigating :-)


Update commandbar.md

Fixed URL for command bar page

@scout208 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks for this update @scout208.


Fixed #29788 -- Added support for Oracle Managed File (OMF) tablespaces.

Ticket 29788.

buildbot, test on oracle.

@VackarAfzal Does this patch work for you? For me it works in both cases UMF and OMF.

buildbot, test on oracle.

buildbot, test on oracle.

Looks good!


Long server name cause layout problem.

Mi 5X, MIUI9.5, Outline 1.1.1
I try to parse multiple ss link like this:
ss://base64-1@ip1:port1#server1
ss://base64-2@ip2:port2#server2
ss://base64-3@ip3:port3#server3
ss://base64-4@ip4:port4#server4
ss://base64-5@ip5:port5#server5

Rename it to solved.

@studentmain Thanks for trying Outline and for reporting this. We probably should truncate extremely long server names.

@trevj i've just tested this issue and now server name is truncated to 100 symbols. I thinks it's fixed now.

https://developer.mozilla.org/en-US/docs/Web/CSS/word-break
I was choosing between: break-word and break-all and choose break-word because Cordova and Electron is based on Chromium(https://caniuse.com/#search=word-break)


Update requirements.txt

fix #41
Flair v0.4.3 is not maintained, so we must have it upgraded. Pytorch also should be upgraded too because of dependency problem.

Hmmm. I already signed CLA agreement, but somehow this bot don't recognize it. Sorry for that!

@HelloRusk Thanks for the fix!


emacs: Change to main download

Closes #3302
Might be a bit slower for some users, but should be more reliable.

For me this is approximately 24 times slower on 3 out of 4 regions, which i have for testing (Czech, Switzerland, Canada)

I could argue this is more of an issue in their side - if one of their mirrors is down then they should attempt the second nearest mirror instead (or just remove it from their list if this downtime is extended...)


GazeManager logs error messages for objects lacking OnGazeEnter / OnGazeLeave

Unity will spam the console error log with the text "SendMessage OnGazeEnter has no receiver!" if no method for OnGazeEnter or OnGazeLeave has been created for the object. This can be mitigated by using the SendMessageOptions.DontRequireReceiver option as the second parameter to the SendMessage method on the GameObject.

@pnolen thank you for filing.
@dotMorten thank you for fixing. Merged into master.


Accessing v-for loop vars from v-runtime-template

Is it possible to use the v-for variables inside the v-runtime-template along the following lines:

  <v-runtime-template :template="'
{{row}}
'" />

https://codesandbox.io/s/01l5j73k90

it doesnt work for me too

I don't think that's possible, since the row variable scope is created by the template as a "temporary" scope, but v-runtime-template has access only to the component scope.
A workaround, can be to create a component for the items on the list. In that way, the row would be in the component scope:
<Row :row="row" v-for="row in rows">

Or even to place the for loop within the template:
<template>

    <v-runtime-template :template="tmplt2" />

</template>


the title and text are not displayed after pressing the read more button

overview
as per the issue title.
reference information
none

fixed to transition to the correct page when clicking the read more button


feat: add code example for uform model

Add code example for image-to-text model
@cf/unum/uform-gen2-qwen-500m

Howdy @dalenguyen, updated your PR with the following:

Removed the curl example, which -- after checking with the team -- doesn't appear to be supported for this model yet.
Updated the TS example to match the formatting used for our other image input example.
Updated to account for the AI native binding


Doesn't work on Windows 8.1

Hello. To run the application required the following libraries:

api-ms-win-core-file-l1-2-2.dll
api-ms-win-core-file-l2-1-2.dll
api-ms-win-core-heap-l2-1-0.dll

I download them from dllme.com. But then another error appeared:

The procedure entry point GetDpiForSystem could not be located in the dynamic link library bt.exe

The GetDpiForSystem function appeared in Windows 10.
It seems to me that this is a very strange dependence on the version of Windows. Nothing specific that is necessary for its operation comes to my mind. And I couldn't find the minimum system requirements.
I tred 4.2.0 version.

Im sorry but windows 8 is not supported by Microsoft anymore so I can't even build a binary for it on github.

It just sounds a little strange to me - now people write mostly cross-platform software, and here even within one platform there are some restrictions. Do I understand correctly that the problem is not in the application itself, but in the fact that GitHub Actions does not support Windows 8.1?

Yes, github only provides not out of life oses. It's possible to add self hosted build agent but I personally won't be able to c9btribute time to support a dead os and host it. Of course you are welcome to build it yourself as all code and build pipelines are completely open.

Also keep in mind most modern dev tooling won't run on anything less than windows 10, which was released almost 10 years ago by the way.

It's understandable, it's just hard to wrap my head around the fact that modern software only works on 2 versions of Windows :) It seems that for the first time in history, the simplest software is so tied to the OS version (i'm not just talking about bt). I live in a world where the same software works on Windows, Linux, MacOS, Haiku, and some on Android and iOS, and I find it hard to understand.
Well, thanks for the answer.

If anyone googles this issue, I found a working alternative. If the author bt doesn't mind, I'll leave the link: https://github.com/stuartleeks/pick-a-browser

Sure feel free to share. There are many versions of windows 10 and 11. Probably the first version of bt will work with 8. But I would encourage you to upgrade.
As this is a system utility it heavily relies on windows internals hence not cross platform. The only cross platform part is user interface .


Add support for content warnings

Some of the works included in the archive are queerphobic, pathologizing, or otherwise hateful. While these works are included due to their historical significance, we have a duty to make sure we're not tacitly legitimizing hateful ideologies or spreading dangerous misinformation. Additionally, visitors to the site deserve to not be exposed to this kind of content if they do not wish to see it.
Here's what we're doing to do about it:

[ ] Add a general disclaimer on the main page of the site warning users about the kind of content they may find in the archive.
[ ] Reword the descriptions of artifacts in the archive to better contextualize them.
[ ] Provide content warnings alongside objectionable content.

Reword the descriptions of artifacts in the archive to better contextualize them.

Let's look at an example of how we might do this. This artifact has the following summary:

A paper in which the author attempts to categorize transgender people by their sexual orientation, including “analloerotics,” who can be subclassified as “automonosexual” or asexual

Blanchard's typologies of trans people are transphobic and lack scientific basis. We should provide that context to avoid spreading dangerous misinformation. Here's an example of how we might change the wording:

A now-discredited paper in which the author promotes an unsubstantiated typology of transgender people …

We should review the artifacts in the archive and think of ways we can provide this kind of context. If you want to make a suggestion for how we can reword one of these summaries, open an issue here.

Add a general disclaimer on the main page of the site warning users about the kind of content they may find in the archive.

That disclaimer should link to this issue so visitors can track the progress of this work.

Provide content warnings alongside objectionable content.

We should think about the best way to do this from a technical standpoint. We could:

Include the CWs inline in the artifact description
Add a separate field for CWs

Option #2 would involve significantly more work. Would that work be worth it? We should tease out the advantages and disadvantages of each approach.

As part of this work, we should update the best practices documentation to encourage adding content warnings alongside submissions.


Map does not render on Tor Browser

Describe the bug

Open https://streets.gl/ in Tor Browser.
The UI is visible, but the map is not.

Screenshots

System information

OS: Linux 6.6.15-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.6.15-2 (2024-02-04) x86_64 GNU/Linux
Browser with version: Tor Browser 13.0.12 (based on Mozilla Firefox 115.9.0esr)

Here's a log from the inspector.
streets.gl_Archive [24-03-21 01-12-43].har.zip

I get the same behaviour on plain Firefox 123.0.1 on Mac OS 12.6.5

FWIW Tor Browser is able to render demo.f4map.com and maps.jawg.io (both of which have 3D buildings) just fine.
This looks relevant - https://gitlab.torproject.org/legacy/trac/-/issues/16005

You're right, it turns out WebGL is enabled, but only WebGL 1.0. Visiting about:support shows a large list of enabled WebGL 1.0 extensions, whereas WebGL 2.0 is empty. And sure enough, streets.gl uses WebGL 2.0. Unfortunately I wasn't able to find anything about enabling WebGL 2.0 on Tor.


update Alien Base logo and description

What changed? Why? Updating Logo and description of Alien Base on Base Ecosystem page
Notes to reviewers
How has it been tested?

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/2

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
1

Sum
2

@darkalienlord
Since some time has passed without update, closing this PR for now. If you all would like to pursue this change in the future please open a new one. 🙏


Add user_info support

Also opened a PR on the source: https://github.com/rng2/ueberauth_oidc/pull/2
If user_info field is set in the provider config, it retrieves the user_info endpoint and uses the config value for the uid_field, instead of using the one in the id_token

Added two config values:
fetch_userinfo -> to indicate wether user info should be fetched, puts this in the additional Ueberauth params
userinfo_uid_field -> when fetch_userinfo is true, use this field in the userinfo as Ueberauth's uid_field
If not set, the uid_field option will be used to get a field from the id_token claims (aka previous behaviour)


M1 Build iOS/MacOS failed(4599)

Describe the bug
M1 Build iOS/MacOS failed(4599)
To Reproduce
Run all the steps, but failed when run 'python3 make.py run build-macos'
Screenshots
pdfium-lib git:(ec317c7) python3 make.py run build-macos

Validating data...
Building libraries...
Generating files to arch "x64" and configuration "release"...
ERROR at //third_party/zlib/BUILD.gn:506:1: Expecting assignment or function call.
}
^
Traceback (most recent call last):
File "/Users/zenghao/Git_Repos/Tools/PDF/pdfium-lib/make.py", line 243, in
main(args)
File "/Users/zenghao/Git_Repos/Tools/PDF/pdfium-lib/make.py", line 146, in main
macos.run_task_build()
File "/Users/zenghao/Git_Repos/Tools/PDF/pdfium-lib/modules/macos.py", line 161, in run_task_build
check_call(command, shell=True)
File<EMAIL_ADDRESS>line 373, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'gn gen out/macos-x64-release --args='target_os="mac" target_cpu="x64" use_goma=false is_debug=false pdf_use_skia=false pdf_use_skia_paths=false pdf_enable_xfa=false pdf_enable_v8=false is_component_build=false clang_use_chrome_plugins=false pdf_is_standalone=true use_xcode_clang=false pdf_is_complete_lib=true use_custom_libcxx=false use_sysroot=false symbol_level=0'' returned non-zero exit status 1.

System (please complete the following information):

OS: MacOS 12.0.1（M1）
Target [e.g. iOS、MacOS]

Additional context
here are some software version:
➜  pdfium-lib git:(ec317c7) ninja --version
1.10.2
➜  pdfium-lib git:(ec317c7) python3 --version
Python 3.9.6
➜  pdfium-lib git:(ec317c7) pip3 --version
pip 21.1.3 from /opt/homebrew/lib/python3.9/site-packages/pip (python 3.9)

Hi,
I launched a new version (4692).
To test, you can access:
https://pdfviewer.github.io/
Can you check the docs/code to see if your problem still happen?
You can donate, if you want, to help the project.
Thanks.

@paulo-coutinho it works with version 4592. Cool, thanks~~


What is the difference between abiTRUE.whl and abiFALSE.whl?

I don't know what the difference is between these two installation packages. Will installing different packages affect the model accuracy?

setup.py picks the right wheel for you
https://github.com/Dao-AILab/flash-attention/blob/23e8fa5a263d1c7122bc46a86ef32030ee7130f9/setup.py#L243


Reduce list of archives to supported enterprise versions

Docker Enterprise actively supports the 17.06, 18.03, 18.09 and 19.03 versions, with 17.06 and 18.03 reaching EOL soon.

@usha-mandya @Dawn-Wood PTAL


[Dribbblish] Theme is completely broken

Describe the bug
The Dribbblish theme is completely broken after updating to 2.10.1
To Reproduce
Steps to reproduce the behavior:

Upgrade to 2.10.1
Open Spotify

Screenshots

Specifics (please complete the following information):

OS: macOS 12.4
Spotify version: <IP_ADDRESS>7.g3751ee08
Spicetify version: 2.10.1

Please refer to #720 for help!

i am also using spicetify v 2.10.1 however for me the theme is working flawlessly

You're using Dribbblish Dynamic which is not maintained in this repository. Closing issue.


Migrate auto-resolve-done-jira-issue and create-jira-issues-for-community-activities to use API Key Manager for Jira  (OSOE-726)

This supersedes https://github.com/Lombiq/GitHub-Actions/issues/275.
Our auto-resolve-done-jira-issue and create-jira-issues-for-community-activities actions use the now unmaintained gajira* actions, so we need to do something to migrate away from them. Furthermore, they need an Atlassian API token to work, which allows you to do everything the user account corresponding to that token can do. This is a problem, because (until Jira guest users are available, if ever) you need to create a separate (paid) Jira user for every use case if you don't want to expose excessive access to your Jira instance.
The API Key Manager for Jira extension lets you manage more restricted API access, so we should use that:

Official API Key Manager for Jira docs are here.
You can contact their support for help here.
What uses the gajira* actions now should use plain PS HTTP requests. We already do this for adding an issue link to the affected GitHub resource here.
Most possibly the Login to Jira steps aren't needed at all.
Document the necessary setup under each workflows' section in the MD file.

Jira issue

For API Key Manager to be more secure overall than a standard API token created under a user account just for this (with access just to selected projects), we need the following features:

Wildcard pattern for API key endpoint: for "Post-pull request checks automation", we need to access /rest/api/3/issue/$issueKey/transitions with both POST and GET. Currently, we can only restrict a key to something like /rest/api/3/issue/ADHOC-, which allows the key to do anything in the given project. We can't use /rest/api/3/issue/ADHOC-*/transitions. Similarly, we'd need /rest/api/3/issue/ADHOC-*/remotelink-style patterns to restrict the key that adds GitHub issue (PR, discussion) links to Jira issues as part of "Create Jira issues for community activities".
Ability to restrict a key to create issues only in a single project. For now, /rest/api/3/issue restricted to POST is the only way. However, this allows anybody with the key not just to create issues in any project, but also to update any issue under our Jira.
Ability to have multiple endpoint-method pairs for a single key, not to have to maintain many keys, and ask our users to do the same. Currently, we need to have 3 separate keys for our use case, to be able to:

Transition issues in a given project (/rest/api/3/issue/- POST and GET).

Create issues in a given project and add remote links to them (/rest/api/3/issue POST; would like in a given project but this allows more).
/rest/api/3/serverInfo GET to be able to fetch the server’s public base URL, in order to build the user-facing URL of an issue.
Ideally, it would also be possible to restrict all issue updates to issues created via a given API key too, but this is less of an issue.

Updates from the developers:

Wildcard pattern for API key endpoint: "Wildcards are currently in testing, hopefully we’ll be able to release this by the end of the months."
Ability to restrict a key to create issues only in a single project: "Our current take is to add a specialized type of key that could only be used for issue creation and only for a specific project – which would be much easier to enforce. Even though, it’ll be a long time before that can become a feature – think many months." I'll have a follow-up question here, but I suspect this means that if we want to allow any issue write scenario, then API Key Manager will open up access to our Jira even more than the built-in API keys. This makes it completely unsuitable for us, since every use case of ours involves creating issues, and we want more restriction compared to the out of the box API keys, not less.
Ability to have multiple endpoint-method pairs for a single key: "This is still on the wishlist, but has been pushed further down for now. Technically, it is not too much of an issue, but it’ll take time to make the UI feel right." Without this, we'd need to use two API keys for create-jira-issues-for-community-activities, or keep the JIRA_BASE_URL parameter.
Restrict all issue updates to issues created via a given API key: not coming anytime soon.

"Ability to restrict a key to create issues only in a single project" is a deal breaker for us.

Re #2 above, yes, this is the case. Thus, we can't use API Key Manager. We thus need to table this and get back to https://github.com/Lombiq/GitHub-Actions/issues/275.


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v2.6.19 to before v5.4.125",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=9ec52099e4b8678a60e9f93e41ad87885d64f3e6",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2cd6eedfa6344f5ef5c3dac3aee57a39b5b46dff"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "9ec52099e4b8678a60e9f93e41ad87885d64f3e6",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "2cd6eedfa6344f5ef5c3dac3aee57a39b5b46dff",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "pid: take a reference when initializing `cad_pid`\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.4.125 by commit 2cd6eedfa6344f5ef5c3dac3aee57a39b5b46dff, it was introduced in version v2.6.19 by commit 9ec52099e4b8678a60e9f93e41ad87885d64f3e6. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1000752


Update clusterize.js when using existing markup

Hello !
I'm looking for a way to update my table after the user retrieves new data.
I'm using React v15.x.x to create the datatable with the data, but it seems there is no method for what I want to do. I might be wrong ^^

Do you mean update Clusterize data with the new rendered info in React? If that it is what you are talking about, I'm looking forward to do the same in Vue, i need to use the markup that I'm rendering because it contains directives that are unique to Vue.

@Marfa93 there are method called exactly ".update"
@hazzo I guess would be better to use vue specific version of clusterize https://github.com/vue-comps/vue-clusterize

@NeXTs that version of vue-clusterize just works with old vue 1.0. What we mean with update I think we refer to a method that updates if markup changes and there is no need to pass an array of data. In the method update an array of data seems to be needed. No?


complex_layout_srcroll_perf__memory diff_total_kb regression

It looks like 73518545e8036b8fda41e93781bb84756ef7d248 regressed this benchmark.

I'm going to close this since we haven't looked at it and it's been multiple days.


Add iskandar puteri in johor state

Pull Request Template
Description
Iskandar puteri is one more district in Johor

@JianLoong tq


Add setting to allow mouse navigation

I think Miro have the UX pretty nailed down for this with switching between Mouse and Trackpad based navigation. see here

If you use a mouse, you can also move around the board
while holding the right mouse button
with the left mouse button while holding the Space bar
with the left mouse button while holding the mouse wheel (available for some mice only)

also their other shortcuts for reference: https://help.miro.com/hc/en-us/articles/360017731033-Shortcuts-and-hotkeys

I've been looking into this issue and wanted to share an update. On this branch, I added a new checkbox to the General section of the visual editor settings as you can see below:

Enabling the checkbox allows users to navigate around the canvas by holding down the right mouse button.
To explain a bit better what is happening at the moment, when Use mouse based navigation is checked, the user can move around the canvas using the right mouse button or by holding Space and using any mouse button.
However, in order to zoom in, users must have either the option or command key pressed while scrolling with the mouse wheel. It feels like the wheel event should also be modified when the Use mouse based navigation checkbox is checked, so that the user can zoom in and out using the mouse wheel.
Any thoughts on this are appreciated!


tldr: 1.2.0 -> 1.3.0

Motivation for this change
Package update
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Now we have two commits. Please squash them!

Squashed.

I squash-merged anyway...


Made request-changes default to true

Current dependencies on/for this PR:

main

PR #180

PR #181   👈

This comment was auto-generated by Graphite.


Internal OneBranch Builds don't Like XDP Kit Test/Tool Binaries

A recent automated PR for MsQuic on our internal mirror exposed the following build errors:
##[error]1. BinSkim Error BA2007 - File: artifacts/bin/xdp/pktcmd.exe.
  Tool: BinSkim: Rule: BA2007 (EnableCriticalCompilerWarnings). https://github.com/microsoft/binskim/blob/main/docs/BinSkimRules.md#rule-BA2007EnableCriticalCompilerWarnings
  'pktcmd.exe' was compiled at too low a warning level (effective warning level 1 for one or more modules). Warning level 3 enables important static analysis in the compiler to flag bugs that can lead to memory corruption, information disclosure, or double-free vulnerabilities. To resolve this issue, compile at warning level 3 or higher by supplying /W3, /W4, or /Wall to the compiler, and resolve the warnings emitted. An example compiler command line triggering this check: -c -ID:\a\1\s\test\pkthlp -ID:\a\1\s\published\external -Zi -nologo -W1 -WX- -diagnostics:column -O2 -GL -DCODE_ANALYSIS -DUSER_MODE=1 -DPOOL_NX_OPTIN_AUTO=1 -DPOOL_ZERO_DOWN_LEVEL_SUPPORT=1 -DFNDIS=1 -Gm- -EHs -EHc -MT -GS -fp:precise -Zc:wchar_t -Zc:forScope -Zc:inline -external:W1 -Gd -TC -wd26812 -analyze:projectdirectoryD:\a\1\s\test\pktcmd -analyze:rulesetdirectory"D:\a\1\s\test\pktcmd\;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Team Tools\Static Analysis Tools\Rule Sets;" -analyze:ruleset"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Team Tools\Static Analysis Tools\Rule Sets\NativeRecommendedRules.ruleset" -analyze:quiet -analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86\EspXEngine.dll" -FC -errorreport:queue -I"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include" -I"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\atlmfc\include" -I"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\VS\include" -I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\ucrt" -I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um" -I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\shared" -I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\winrt" -I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\cppwinrt" -I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\Include\um" -external:I"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include" -external:I"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\atlmfc\include" -external:I"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\VS\include" -external:I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\ucrt" -external:I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um" -external:I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\shared" -external:I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\winrt" -external:I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\cppwinrt" -external:I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\Include\um" -X
Modules triggering this check: pktcmd.obj [warning level: 1]
pkthlp.obj (pkthlp_um.lib) [warning level: 1]

##[error]2. BinSkim Error BA2008 - File: artifacts/bin/xdp/pktcmd.exe.
  Tool: BinSkim: Rule: BA2008 (EnableControlFlowGuard). https://github.com/microsoft/binskim/blob/main/docs/BinSkimRules.md#rule-BA2008EnableControlFlowGuard
  'pktcmd.exe' does not enable the control flow guard (CFG) mitigation. To resolve this issue, pass /guard:cf on both the compiler and linker command lines. Binaries also require the /DYNAMICBASE linker option in order to enable CFG.

##[error]3. BinSkim Error BA2007 - File: artifacts/bin/xdp/xskbench.exe.
  Tool: BinSkim: Rule: BA2007 (EnableCriticalCompilerWarnings). https://github.com/microsoft/binskim/blob/main/docs/BinSkimRules.md#rule-BA2007EnableCriticalCompilerWarnings
  'xskbench.exe' was compiled at too low a warning level (effective warning level 1 for one or more modules). Warning level 3 enables important static analysis in the compiler to flag bugs that can lead to memory corruption, information disclosure, or double-free vulnerabilities. To resolve this issue, compile at warning level 3 or higher by supplying /W3, /W4, or /Wall to the compiler, and resolve the warnings emitted. An example compiler command line triggering this check: -c -ID:\a\1\s\published\external -Zi -nologo -W1 -WX- -diagnostics:column -O2 -GL -DCODE_ANALYSIS -DUSER_MODE=1 -DPOOL_NX_OPTIN_AUTO=1 -DPOOL_ZERO_DOWN_LEVEL_SUPPORT=1 -DFNDIS=1 -Gm- -EHs -EHc -MT -GS -fp:precise -Zc:wchar_t -Zc:forScope -Zc:inline -external:W1 -Gd -TC -wd26812 -analyze:projectdirectoryD:\a\1\s\test\xskbench -analyze:rulesetdirectory"D:\a\1\s\test\xskbench\;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Team Tools\Static Analysis Tools\Rule Sets;" -analyze:ruleset"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Team Tools\Static Analysis Tools\Rule Sets\NativeRecommendedRules.ruleset" -analyze:quiet -analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86\EspXEngine.dll" -FC -errorreport:queue -I"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include" -I"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\atlmfc\include" -I"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\VS\include" -I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\ucrt" -I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um" -I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\shared" -I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\winrt" -I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\cppwinrt" -I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\Include\um" -external:I"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include" -external:I"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\atlmfc\include" -external:I"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\VS\include" -external:I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\ucrt" -external:I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um" -external:I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\shared" -external:I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\winrt" -external:I"C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\cppwinrt" -external:I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\Include\um" -X
Modules triggering this check: xskbench.obj [warning level: 1]

##[error]4. BinSkim Error BA2008 - File: artifacts/bin/xdp/xskbench.exe.
  Tool: BinSkim: Rule: BA2008 (EnableControlFlowGuard). https://github.com/microsoft/binskim/blob/main/docs/BinSkimRules.md#rule-BA2008EnableControlFlowGuard
  'xskbench.exe' does not enable the control flow guard (CFG) mitigation. To resolve this issue, pass /guard:cf on both the compiler and linker command lines. Binaries also require the /DYNAMICBASE linker option in order to enable CFG.

I see two possible solutions here:

Remove/separate these test binaries from the kit, so consumers that don't need these binaries don't have to worry about this.
Follow the instructions above and increase the warning level on the tools' builds.

P.S. @mtfriesen I'm not quite sure how you'd like to label this issue. Probably feature request if we go for option 1, or a bug if we go for option 2.

@nibanks did the changes to support EWDK (#71) indirectly fix this?

At the very least we'll need a new release for us to try out.

Closing this as I don't see any warnings any more.


In custom component interface, move 'Update' button to the bottom right.

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡

In the current placement, it gets easily missed.

Closed via #671

That PR was closed without merging. Merging the new PR will automatically close this ticket


Problems parsing load_avg from gateway

Hello,
since 0.3.4 you get following error during parsing the gateway.
It seems, that the load_avg is not available every time.
TypeError: Cannot read property 'split' of undefined at /opt/iobroker/node_modules/iobroker.xiaomi-gateway3/lib/lumi.js:950:43 at /opt/iobroker/node_modules/iobroker.xiaomi-gateway3/lib/lumi.js:746:90 at Array.reduce () at /opt/iobroker/node_modules/iobroker.xiaomi-gateway3/lib/lumi.js:746:72 at LumiStateClass.normalizeLeft (/opt/iobroker/node_modules/iobroker.xiaomi-gateway3/lib/lumi.js:747:82) at LumiStateClass.decode (/opt/iobroker/node_modules/iobroker.xiaomi-gateway3/lib/lumi.js:769:63) at /opt/iobroker/node_modules/iobroker.xiaomi-gateway3/lib/gateway3.js:577:68 at Array.reduce () at Gateway3.processMessageLumi (/opt/iobroker/node_modules/iobroker.xiaomi-gateway3/lib/gateway3.js:577:14) at XiaomiGateway3._onMqttMessage (/opt/iobroker/node_modules/iobroker.xiaomi-gateway3/main.js:363:31)
kind regards

Hi.
This is strange, but all seems like you write and load_avg not always in message. I did fixes to master.

Hi,
thanks, I try to test your solution right now.
At the moment it seems ok but I'll give you feedback tomorrow.
kr

Hello,
it seems to be ok. Did not get the error anymore.
kr


Return the error that ReadDir returns in localSchemasClient.Paths

Fixes #75
If ReadDir returns an error except for fs.ErrNotExist, localSchemasClient.Paths returns the error with an additional message.

Thanks for your review.
I excluded fs.ErrNotFound.

Thanks @hiroyaonoe can you add unit tests ?

I added a unit test for the case where it is not a directory.
The ErrNotExist case is already tested in invalid {dir, fs} test cases.
I can test for permission-denied cases by setting the directory permission to r--, but it was difficult to manage in git, so I didn't add the case.

Thanks @hiroyaonoe and @eddycharly !
/lgtm
/approve


--exclude option doesn't work on Windows

Describe the bug
--exclude option doesn't work for nested files - we noticed it only on Windows(works on Mac and Linux)
In the example below, file directly under excluded folder is ignored whilst file in a subfolder is not.

To Reproduce
Create folder with subfolder and file in it.
Run sqlfmt . --exclude "./folder/**/*"
Expected behavior
All files in excluded folder should be ignored
Actual behavior
Files in excluded folder are formatted
Additional context
What is the output of sqlfmt --version?
see on screenshot
What is the output of pip list (or pipx list if you installed using pipx)?
see on screenshot

Agreed. Duplicates #440


Additional considerations

Once you change a dynamic disk back to a basic disk, you can create only partitions and logical drives on that disk, or add it to a Storage Spaces Pool.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 722fedef-d6a4-5ed6-526b-d6dd1a4d0642
Version Independent ID: 10f9b44a-5a88-cb84-293f-1baf62359299
Content: Change a dynamic disk back to a basic disk
Content Source: WindowsServerDocs/storage/disk-management/change-a-dynamic-disk-back-to-a-basic-disk.md
Product: windows-server
Technology: storage
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

Thanks for the feedback. Being able to add the disk to a Storage Spaces pool would be implied as that is type of type needed for Storage Spaces. I'm going to leave this article as-is to keep it clear.
#please-close


Lots of expired access tokens prevent server from starting

Issue Summary
When re-starting a server with a lot of expired access tokens, trying to destroy all of them can prevent the server from starting. We ran into knex timeout issues or memory issues.
To Reproduce

Generate a lot of expired access tokens (we had around 38680).
Restart your server

Expected results
Server smoothly comes online.
Actual results
Server takes a loooooong time or crashes.
Details from our debugging session
We saw one DELETE SQL query per token. We believe those were all wrap in a transaction so when the server crashes, the transaction is rolled back. And next attempt at starting up the server will probably fail again.
https://github.com/TryGhost/Ghost/blob/master/core/server/services/auth/oauth.js#L129 is where those queries are ran at startup. I'd suggest running that in a scheduled task or turn it into one query.
Technical details:

Ghost Version: 0.11.12
Node Version: 6.14

The knux error message we were seeing was Knex: Timeout acquiring a connection. The pool is probably full. Are you missing a .transacting(trx) call?.
This might be the root cause for https://github.com/TryGhost/Ghost/issues/7346 or https://forum.ghost.org/t/back-with-the-ghost-sites-failing-to-load-following-an-aws-rds-maintenance-backup-window/1983

@kirrg001 I've noticed the "needs info" tag. What kind of info would you like me to provide?

Hey @rik - there is nothing you can do right now - thanks for asking :)
I need to find some time to reproduce this - probably beginning of next week!

Hey @rik :wave:
I've tried to reproduce this locally using both SQLite & MySQL and 50000 expired access tokens, but it's not causing any issues for me.
I noticed you're running ghost 0.11.12 - Could you please update to the latest and let us know if you're still having the issue? Thanks!

We currently have no plans to migrate to 1.0 as we need to schedule some time to do that and 0.11 seems to still be the LTS version.
That being said, the underlying code seems to be the same in both versions so it should behave in a similar way.
https://github.com/TryGhost/Ghost/blob/lts/core/server/models/base/token.js#L33
https://github.com/TryGhost/Ghost/blob/master/core/server/models/base/token.js#L33

We've seen this bug in production where the DB is not on the same system as the application, introducing a lot of latency. I suspect trying to reproduce locally where latency is less than 1ms is not representative in this case.
Could we please re-open to try and reproduce in a system where app and DB are separated?

Having this issue using Ghost behind an nginx reverse proxy. I know the proxy isn't the issue because as soon as I told the proxy to wait longer for a response from the upstream client (ghost) I was able to see the knex timeout 500 error. Only fix is to restart the container which I assume clears all the hanging connections. I think what was causing all the hanging connection is I use Google Stackdriver Uptime monitoring to alert when the site is down. If the site goes down (which it does every day for a restart) Stackdriver will try to access the site looking for a response (pretty quickly, about once a minute). This action is what I think was filling the connection pool. I am running Ghost 3.7.0 with sqlite3. Any help on getting this to not happen would be great because I would like to have uptime monitoring on my site.

@andrefecto sounds like you have a different issue to the one you're replying to (tokens are not used in 3.7.0). I'd suggest posting on our forum where you can get community support for self-hosted install issues 🙂


feat: add cloudinary support

Adds netlify-cms-media-library-cloudinary with associated docs 💥

Deploy preview for netlify-cms-www ready!
Built with commit a039fa240b73784157e429745a35f92526680b6c
https://deploy-preview-1932--netlify-cms-www.netlify.com

Deploy preview for netlify-cms-www ready!
Built with commit 1f40e8524bbf3f9ab0f29dd4c009674be48e0132
https://deploy-preview-1932--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit a039fa240b73784157e429745a35f92526680b6c
https://deploy-preview-1932--cms-demo.netlify.com

Deploy preview for netlify-cms-www ready!
Built with commit 0c7354ae1ca65bd29161ebc2cf96fe396778039d
https://deploy-preview-1932--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit 0c7354ae1ca65bd29161ebc2cf96fe396778039d
https://deploy-preview-1932--cms-demo.netlify.com

Deploy preview for cms-demo ready!
Built with commit 54f024e4faf27fe5f6d62ec66fcf7fe915b0d833
https://deploy-preview-1932--cms-demo.netlify.com

Deploy preview for cms-demo ready!
Built with commit 6333ec748d8c9fbc6c1fd33cd2b1dc98acfcfc2e
https://deploy-preview-1932--cms-demo.netlify.com