robots.txt with multiple domains

Is there a way to configure robots.txt per domain? Sometimes we run multiple sites in one Umbraco instance and it would be great if we can configure the robots.txt separately. 😄

Hi @erikjanwestendorp
It currently isn't possible to configure multiple robots.txt per domain, but it is something that I am planning to add (along with other domain specific settings). I'll let you know when I have more, but you can always give it a start if you want!

@patrickdemooij9 Thanks for your reply! I want to work on this one but before I start I want to discuss a possible solution.
Of coure you don't want to introduce a breaking change (at least not in a minor version), so I was thinking maybe it's a good idea to add a setting, called MultiDomainSupport or so, and if this is set to true than it's possible to configure a robots.txt per domain. If it's false the behaviour will be the same as before.
The RobotsTxtTreeController can be updated like so:
public class RobotsTxtTreeController : TreeController
    {
        public const string TreeGroupAlias = TreeControllerConstants.SeoToolkitTreeGroupAlias;

        private readonly IDomainService _domainService;
        private readonly IUmbracoContextAccessor _umbracoContextAccessor;
        private readonly bool _multiDomainSupport;

        public RobotsTxtTreeController(
            ILocalizedTextService localizedTextService,
            UmbracoApiControllerTypeCollection umbracoApiControllerTypeCollection,
            IEventAggregator eventAggregator,
            IDomainService domainService,
            IUmbracoContextAccessor umbracoContextAccessor,
            IOptionsMonitor<GlobalAppSettingsModel> config)
            : base(localizedTextService, umbracoApiControllerTypeCollection, eventAggregator)
        {
            _domainService = domainService;
            _umbracoContextAccessor = umbracoContextAccessor;
            _multiDomainSupport = config.CurrentValue.MultiDomainSupport;
        }

        protected override ActionResult<TreeNode> CreateRootNode(FormCollection queryStrings)
        {
            var root = base.CreateRootNode(queryStrings);

            root.Value.Icon = "icon-cloud";
            root.Value.HasChildren = _multiDomainSupport;
            root.Value.RoutePath = $"{SectionAlias}/{TreeAlias}/detail";
            root.Value.MenuUrl = null;

            return root.Value;
        }

        protected override ActionResult<MenuItemCollection> GetMenuForNode(string id, FormCollection queryStrings)
        {
            return null;
        }

        protected override ActionResult<TreeNodeCollection> GetTreeNodes(string id, FormCollection queryStrings)
        {
            if (!_multiDomainSupport)
            {
                return null;
            }

            var nodes = new TreeNodeCollection();
            _umbracoContextAccessor.TryGetUmbracoContext(out var context);

            if (id != Constants.System.Root.ToInvariantString())
            {
                return nodes;
            }

            foreach (var domain in _domainService.GetAll(false).GroupBy(x => x.RootContentId).Select(x => x.First()))
            {
                var node = context?.Content?.GetById(domain.RootContentId ?? -1);
                if (node is null)
                {
                    continue;
                }
                var newTreeItem = CreateTreeNode(node.Id.ToString(), "-1", queryStrings, node.Name(domain.LanguageIsoCode), "icon-globe", false);
                nodes.Add(newTreeItem);
            }

            if (nodes.Any())
            {
                return nodes;
            }

            var firstRootNode = context?.Content?.GetAtRoot().FirstOrDefault(x => x.TemplateId > 0);
            if (firstRootNode is null)
            {
                return nodes;
            }

            var firstTreeItem = CreateTreeNode(firstRootNode.Id.ToString(), "-1", queryStrings, firstRootNode?.Name, "icon-globe", false);
            nodes.Add(firstTreeItem);

            return nodes;
        }
    }

What do you think about this?

Hi @erikjanwestendorp
Sorry for the late reply on this. I had wanted to write my thoughts about this earlier, but then totally forgot about the issue. So let me add them now.
I think what you have here is great, but I think it is currently a bit limited. I see this website-specific functionality being very handy for other functionalities like ScriptManager or future features. Therefore, I think we should have a tree with websites where you can see the website-specific settings like this:

The code for that is quite simple as of now. Probably needs some changes:
namespace SeoToolkit.Umbraco.ScriptManager.Core.Controllers
{
    [Tree("SeoToolkit", "ScriptManager", TreeTitle = "Script Manager", TreeGroup = "SeoToolkit", SortOrder = 2)]
    [PluginController("SeoToolkit")]
    public class ScriptManagerTreeController : TreeController
    {
        private readonly IMenuItemCollectionFactory _menuItemCollectionFactory;

        public ScriptManagerTreeController(
            ILocalizedTextService localizedTextService,
            UmbracoApiControllerTypeCollection umbracoApiControllerTypeCollection,
            IEventAggregator eventAggregator,
            IMenuItemCollectionFactory menuItemCollectionFactory)
            : base(localizedTextService, umbracoApiControllerTypeCollection, eventAggregator)
        {
            _menuItemCollectionFactory = menuItemCollectionFactory;
        }

        protected override ActionResult<TreeNode> CreateRootNode(FormCollection queryStrings)
        {
            var root = base.CreateRootNode(queryStrings);

            root.Value.Icon = "icon-script";
            root.Value.HasChildren = false;
            root.Value.RoutePath = $"{SectionAlias}/{TreeAlias}/list";

            return root.Value;
        }

        protected override ActionResult<MenuItemCollection> GetMenuForNode(string id, FormCollection queryStrings)
        {
            if (id == UmbConstants.System.RootString)
            {
                var menuItemCollection = _menuItemCollectionFactory.Create();

                var item = menuItemCollection.Items.Add<ActionNew>(LocalizedTextService, opensDialog: true, hasSeparator: false);
                item.NavigateToRoute($"{SectionAlias}/{TreeAlias}/edit");

                return menuItemCollection;
            }

            return null;
        }

        protected override ActionResult<TreeNodeCollection> GetTreeNodes(string id, FormCollection queryStrings)
        {
            return null;
        }
    }
}

And I think we can also introduce this without it being a breaking change this way. Instead of the websites being generated by domain, I think they should be added manually by the user. This way, we still keep the old items as a fallback functionality, but it also makes it clearer for users who only have a single website. If you then want specific settings for a website, you can add it to the website list and customize it the way you want to.
The root items could then be used as follows:

ScriptManager root item could have global scripts. This way, you don't have to go through each website to add a script if you want to do that globally.
Robots.txt could be the fallback if you don't have the specific site setup yet.

But this is mostly coming from my experiences. I would love to hear what you think of this and if this would also fit your websites. It will be a bit more work, but I could also help work on this one.

@patrickdemooij9 is there an update for this? Will it become an option in the next release?


README.md: fix dead Google Code links

Update links to framing_format.txt to Google's snappy GitHub project

Merged. Thanks!

:+1: You're welcome!


feat: ADMIN_PASSWORD env var & conditional setup

This PR:

adds (and supports) the env var ADMIN_PASSWORD and creates a prompt within setup
uses conditional prompting in setup depending on database selection (see below)

db = sqlite3

db != sqlite3

Thanks for the PR, I'll try to check it out tonight and get back to you!

very cool

hey @Pitu, just checking in :)

So sorry for how long it's taken me, I'll be sure to check it out this weekend, it's been a very wild couple of weeks.


Improve the Icons

The today icons was downloaded and other are made by my self, but would be more nice if we use something like Font-awesome.

I believe you forgot to close the issue.

Hi @hugohomesquita, actually we use some images as the icon, they are not "responsive", so in smaller resolutions they become pixelated, that should be nice if we have some sprite in svg or something like it.

I think this issue will be closed when you guys start to use some css preprocessor. I created #150 to propose this change.


Fix evictable_size when deleting leaf

I notice that the variable evictable_size is obtained by summing the values of all tree nodes, not the keys.

In our design, the lengths of the key and value are always the same.
Both the existing code and your PR are correct. Let us just use the existing one.


Docker instance keeps restarting

Current Behavior
The following errormessage makes node-red restart every few seconds:
docker logs -f nodered :
SyntaxError: Invalid or unexpected token at Object.compileFunction (node:vm:352:18) at wrapSafe (node:internal/modules/cjs/loader:1033:15) at Module._compile (node:internal/modules/cjs/loader:1069:27) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10) at Module.load (node:internal/modules/cjs/loader:981:32) at Function.Module._load (node:internal/modules/cjs/loader:822:12) at Module.require (node:internal/modules/cjs/loader:1005:19) at require (node:internal/modules/cjs/helpers:102:18) at Object. (/usr/src/node-red/node_modules/mime/index.js:4:27) at Module._compile (node:internal/modules/cjs/loader:1105:14) Failed to start server: /usr/src/node-red/node_modules/mime/types/standard.js:2

Expected Behavior
Running Docker instance with nodered
Steps To Reproduce
See 'Current behavior' description
Example flow
paste your flow here

Environment

Node-RED version: Image ID: ed58160c5a2e
Node.js version: ?
npm version: ?
Platform/OS:  Linux DietPi 6.1.11-meson64 #23.02.2 SMP PREEMPT Sat Feb 18 00:07:55 UTC 2023 aarch64 GNU/Linux
Docker version: 24.0.4, build 3713ee1

Also posted here: https://stackoverflow.com/questions/76686409/node-red-in-docker-keeps-rebooting

Please include all the information I asked for on Stack Overflow, including more context from the logs (and please try and format it with the line breaks so it is readable.
Also please check what happens if you explicitly pull the latest with
docker pull nodered/node-red:latest

And restart the docker compose project.

We should also move this to https://github.com/node-red/node-red-docker


AFter updating to Electron 27, JAWS screen reader does not read curly braces ({}) in the code editor

Type: Bug
AFter updating to Electron 27, JAWS screen reader does not read curly braces ({}) in the code editor evenn with the accessibility support enabled.
I tested from source code, and it starts failing after checking out the commit 12fece34ed49c972d85b1a9ff0f5b8532eea569c
VS Code version: Code - OSS Dev 1.85.0 (Commit 12fece34ed49c972d85b1a9ff0f5b8532eea569c, Date unknown)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 2995)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.85GB (6.69GB free)

Process Argv
.

Screen Reader
yes

VM
0%

Extensions: none

cc @isidorn

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.85.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

@kastwey thanks a lot for filling this issue and for finding the commit that breaks it. Thus it seems to be coming with latest Electron, thus also assigning @deepak1556
We should check if there is an issue in the Chromium repo that mentions something like this, and if not we need to create one.
Since regression assigning to this milestone.

@kastwey If you have time it would also be useful to check if you can reproduce with latest Chrome and TextArea.
For example if you go to this site in your Chrome browser can you repro the behaviour:
https://bocupp-microsoft.github.io/sample-code/textarea/setselectionrange-performance.html

Just to add to this, the problem specifically affects JAWS. It doesn't seem to impact any other screen reader. I'm reaching out to our point of contact at Vispero.

i! HI tried it with Chrome 120.0 and it works fine with JAWS (it reads
the curly braces correctly). So it seems that the problem is specific
to VS Code or Electron 27 and JAWS. I can try to create a simple
application with a textarea in Electron 27 to narrow down the cause if
that might help.
2023-12-15 15:26 GMT, Roberto Perez @.***>:

Just to add to this, the problem specifically affects JAWS. It doesn't seem
to impact any other screen reader. I'm reaching out to our point of contact
at Vispero.
--
Reply to this email directly or view it on GitHub:
https://github.com/microsoft/vscode/issues/200956#issuecomment-1858060068
Unsubscribe from this thread:
https://github.com/notifications/unsubscribe-auth/ABZ4HFGDUXFMX66PLCCGRT3YJRT3TBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZTCNRYGEZTGNRUURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2UMJRGU4DQNBRGEZTNJDOMFWWLKLIMFZV63DBMJSWZLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOKIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVA2DCOBYGE4TAMECUR2HS4DFUVUXG43VMWSXMYLMOVS2UMRQGQZTMNZRGMZDNAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTGMJWHAYTGMZWGSBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGEYTKOBYGQYTCMZWU52HE2LHM5SXFJTDOJSWC5DF
You are receiving this because you authored the thread
Message ID: @.***>

I can try to create a simple application with a textarea in Electron 27 to narrow down the cause if that might help.

Thanks for testing, this would be super helpful.

That may be helpful to share with Vispero as a reduced test case as well. They are already investigating on their end.
From: Robo @.>
Sent: Friday, December 15, 2023 11:11 AM
To: microsoft/vscode @.>
Cc: Comment @.***>
Subject: Re: [microsoft/vscode] AFter updating to Electron 27, JAWS screen reader does not read curly braces ({}) in the code editor (Issue #200956)
I can try to create a simple application with a textarea in Electron 27 to narrow down the cause if that might help.
Thanks for testing, this would be super helpful.

Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/200956#issuecomment-1858123934 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJH5KGTPEPKSTVLHDQ56TETYJRZBPBFKMF2HI4TJMJ2XIZLTTGBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZDKNRRGI4TSOJTURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SMRYGY4DQNRVGM3KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNJGMYTMOBRGMZTMNFENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDCMJVHA4DIMJRGM3KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGE3DENBUGE3DCNBRURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2UNRRGQ2TQNZSHEZTJJDOMFWWLKLIMFZV63DBMJSWZLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOMIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVA2DCOBYGE4TAMECUR2HS4DFUVUXG43VMWSXMYLMOVS2UMRQGQZTMNZRGMZDNAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTENJWGEZDSOJZGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNJGI4DMOBYGY2TGNUCUR2HS4DFUVWGCYTFNSSXMYLMOVS2SMZRGY4DCMZTGY2IFJDUPFYGLJLMMFRGK3FFOZQWY5LFVIYTCNJYHA2DCMJTG2BKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGE3DENBUGE3DCNBRQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRWGE2DKOBXGI4TGNFHORZGSZ3HMVZKMY3SMVQXIZI.
You are receiving this email because you commented on the thread.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I created a default app with Electron 27.1.3 (the version mentioned in
the commit), added a textArea, and was able to read the braces
correctly with JAWS. So, it seems that the issue only occurs with VS
Code. So weird.
2023-12-15 17:01 GMT, Roberto Perez @.***>:

That may be helpful to share with Vispero as a reduced test case as well.
They are already investigating on their end.
From: Robo @.>
Sent: Friday, December 15, 2023 11:11 AM
To: microsoft/vscode @.>
Cc: Comment @.***>
Subject: Re: [microsoft/vscode] AFter updating to Electron 27, JAWS screen
reader does not read curly braces ({}) in the code editor (Issue #200956)
I can try to create a simple application with a textarea in Electron 27 to
narrow down the cause if that might help.
Thanks for testing, this would be super helpful.

Reply to this email directly, view it on
GitHubhttps://github.com/microsoft/vscode/issues/200956#issuecomment-1858123934
or
unsubscribehttps://github.com/notifications/unsubscribe-auth/AJH5KGTPEPKSTVLHDQ56TETYJRZBPBFKMF2HI4TJMJ2XIZLTTGBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZDKNRRGI4TSOJTURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SMRYGY4DQNRVGM3KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNJGMYTMOBRGMZTMNFENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDCMJVHA4DIMJRGM3KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGE3DENBUGE3DCNBRURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2UNRRGQ2TQNZSHEZTJJDOMFWWLKLIMFZV63DBMJSWZLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOMIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVA2DCOBYGE4TAMECUR2HS4DFUVUXG43VMWSXMYLMOVS2UMRQGQZTMNZRGMZDNAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTENJWGEZDSOJZGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNJGI4DMOBYGY2TGNUCUR2HS4DFUVWGCYTFNSSXMYLMOVS2SMZRGY4DCMZTGY2IFJDUPFYGLJLMMFRGK3FFOZQWY5LFVIYTCNJYHA2DCMJTG2BKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGE3DENBUGE3DCNBRQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRWGE2DKOBXGI4TGNFHORZGSZ3HMVZKMY3SMVQXIZI.
You are receiving this email because you commented on the thread.
Triage notifications on the go with GitHub Mobile for
iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or
Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
--
Reply to this email directly or view it on GitHub:
https://github.com/microsoft/vscode/issues/200956#issuecomment-1858198294
Unsubscribe from this thread:
https://github.com/notifications/unsubscribe-auth/ABZ4HFHRGRPTNWIG5NHNTOTYJR65FBFKMF2HI4TJMJ2XIZLTTGBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZDKNRRGI4TSOJTURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SMRYGY4DQNRVGM3KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNJGMYTMOBRGMZTMNFENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDCMJVHA4DIMJRGM3KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGE3DENBUGE3DCNBRURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2UNRRGQ2TQNZSHEZTJJDOMFWWLKLIMFZV63DBMJSWZLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOMIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVA2DCOBYGE4TAMECUR2HS4DFUVUXG43VMWSXMYLMOVS2UMRQGQZTMNZRGMZDNAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTENJWGEZDSOJZGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNJGI4DMOBYGY2TGNUCUR2HS4DFUVWGCYTFNSSXMYLMOVS2SMZRGY4DCMZTGY2IFJDUPFYGLJLMMFRGK3FFOZQWY5LFVIYTCNJYHA2DCMJTG2BKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGE3DENBUGE3DCNBRQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRWGE2DKOBXGI4TGNFHORZGSZ3HMVZKMY3SMVQXIZI
You are receiving this because you authored the thread
Message ID: @.***>

Can you load https://vscode.dev/ in the electron app and see how it behaves.

after testing it. Loading vscode.dev using MSEdge 120, as well as with
Electron 25.9 and Electron 27.1.2, JAWS does not read the keys in the
editor. How curious!
2023-12-15 22:00 GMT, Robo @.***>:

Can you load https://vscode.dev/ in the electron app and see how it
behaves.
--
Reply to this email directly or view it on GitHub:
https://github.com/microsoft/vscode/issues/200956#issuecomment-1858539468
Unsubscribe from this thread:
https://github.com/notifications/unsubscribe-auth/ABZ4HFGLR7VA3FRQJADNWBDYJTCAHBFKMF2HI4TJMJ2XIZLTTGBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZDKNRRGI4TSOJTURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SMRYGY4DQNRVGM3KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNJGMYTMOBRGMZTMNFENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDCMJVHA4DIMJRGM3KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGE3DENBUGE3DCNBRURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2UNRRGQ2TQNZSHEZTJJDOMFWWLKLIMFZV63DBMJSWZLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOMIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVA2DCOBYGE4TAMECUR2HS4DFUVUXG43VMWSXMYLMOVS2UMRQGQZTMNZRGMZDNAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTENJWGEZDSOJZGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNJGI4DMOBYGY2TGNUCUR2HS4DFUVWGCYTFNSSXMYLMOVS2SMZRGY4DCMZTGY2IFJDUPFYGLJLMMFRGK3FFOZQWY5LFVIYTCNJYHA2DCMJTG2BKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGE3DENBUGE3DCNBRQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRWGE2DKOBXGI4TGNFHORZGSZ3HMVZKMY3SMVQXIZI
You are receiving this because you authored the thread
Message ID: @.***>

We have users reporting this issue to us as well, who also similarly reported that it works with other  inside Chrome tabs, but not in VS Code.

@Mingpan ok so this proves it is not Electron related. It is a combination of Chromium + how we use textArea in VS Code.

@jooyoungseo, this is the issue we just discussed. JooYoung said this began happening about 2 weeks ago.
@hediet or @alexdima were there any changes to the monaco editor's text area in that time frame that could explain this?

@meganrogge it looks unrelated to the changes on our side.
Since @kastwey narrowed down the commit to an electron update, which bring newer Chromium versions.

@isidorn the bisect might not be correct, https://github.com/microsoft/vscode/issues/200956#issuecomment-1858815882 contradicts it. I would suggest to perform the commit bisect again.

What I can tell you is that if I "git checkout" the commit before the Electron update, JAWS does read the keys. If I checkout the commit of the Electron update, it doesn't read them anymore. But it's also true that loading the vscode.dev website with the latest version of Edge (120)as well as with different versions of Electron (including 25.9), JAWS doesn't read the braces... So I'm totally confused 😵😕😕 😊

Update from our contact at Pispero.
If you add the below to the VisualStudioCode.JCF file the { } will be announced.
[RichEdit and Edit Control Options]
RequestMarkedUpContent=0

@rperez030 -- Yes, this works! Thanks for sharing the tweak. I assume this patch will be released soon to all the JAWS users?

I would think so.

@rperez030 is that a JAWS configuration change or one we can make on the VS Code side?

It is a JAWS issue, but for now they don't seem to fully understand what causes it. I asked them to keep us posted as they investigate on their end and to let us know in case there is something that we can do.

@meganrogge  our partners at Vispero are asking when this change is expected to hit production. I'm assuming it is not yet in the stable release.

Change will be released to production in first week of February.

Thanks. I'll let them know.
On Jan 7, 2024, at 7:44 PM, Robo @.***> wrote:

Change will be released to production in first week of February.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/200956#issuecomment-1880252300 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJH5KGSLDCKDCPIOLBUGDPTYNM6PZBFKMF2HI4TJMJ2XIZLTTCBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZDKNRRGI4TSOJTURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SMZRGY4DCMZTGY2KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNJGU2TAOBYGM2DEM5ENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWUTKNZYGA2DOMJSGOSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRRGE2TQOBUGEYTGNVENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZPAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUDIMJYHAYTSMBQQKSHI6LQMWSWS43TOVS2K5TBNR2WLKRSGA2DGNRXGEZTENUCUR2HS4DFUVWGCYTFNSSXMYLMOVS2SMRVGYYTEOJZHEZYFJDUPFYGLJLMMFRGK3FFOZQWY5LFVEZTCNRYGEZTGNRUQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKJVGUYDQOBTGQZDHAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTKNZYGA2DOMJSGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGEYTKOBYGQYTCMZWU52HE2LHM5SXFJTDOJSWC5DF.
You are receiving this email because you commented on the thread.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@meganrogge assigning this back to you based on https://github.com/microsoft/vscode/issues/200956#issuecomment-1877893833, let me know if there is need to address this issue in the runtime.

I currently am using the WA above. and I do not have the "Left Marjin" issue although I don't have the Jaws read me the indentations so probably it is why you have the "left marjin" effect.
however, we need a fix for the long term w/o the WA above even if we want the screen reader to read the indentations it should not have such a side-effect it does sound very annoying.
Note - I code in Python and GO currently (didn't try C/C++ w/ WA).

They are working on a fix right now but still has problems. I'll add you to an internal thread.
From: Juanjo @.>
Sent: Wednesday, February 7, 2024 9:35 AM
To: microsoft/vscode @.>
Cc: Mention @.>; Comment @.>
Subject: Re: [microsoft/vscode] JAWS screen reader does not read curly braces ({}) in the code editor (Issue #200956)
Hi,
I've been testing with the configuration that Vispero provided as workaround, but this configuration has a super annoying side effect, and that is that for every indentation change, JAWS reads at the beginning the text: "Left Margin".
As an example, here is a piece of a C function and how it is read with this configuration activated and deactivated.
Without adding the configuration:
void PartitionSize()
4 spaces struct statvfs buf;
if (statvfs(".", &buf) != 0)
8 spaces perror("statvfs");
return;
4 spaces
Left Margin
As you can see, no curly braces are read.
Adding the configuration:
Left Margin void PartitionSize()
{
Left Margin 4 spaces struct statvfs buf;
if (statvfs(".", &buf) != 0) {
Left Margin 8 spaces perror("statvfs");
return;
Left Margin 4 spaces }
Left Margin 1 space
As you can see it is super annoying. @rperez030https://github.com/rperez030 , has Vispero said anything else, have they explained the reason for this problem and what is the solution?
Thanks!

Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/200956#issuecomment-1932177668 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJH5KGWAOBMCHGQBOV6G3CTYSOGIHBFKMF2HI4TJMJ2XIZLTS6BKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZDKNRRGI4TSOJTURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SMZRGY4DCMZTGY2KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNJGU2TAOBYGM2DEM5ENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDCMJVHA4DIMJRGM3KI3TBNVS2S2DBONPWYYLCMVWKY43VMJVGKY3UL52HS4DFVREXG43VMVBW63LNMVXHJJTUN5YGSY3TS2BKI5DZOBS2U4TFOBXXG2LUN5ZHTJLWMFWHKZNIGQYTQOBRHEYDBAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDEMBUGM3DOMJTGI3IFJDUPFYGLJLMMFRGK3FFOZQWY5LFVEZDKNRRGI4TSOJTQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKJTGE3DQMJTGM3DJAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTKNJQHA4DGNBSGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGEYTKOBYGQYTCMZWU52HE2LHM5SXFJTDOJSWC5DF.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Braille display user perspective:
Curly braces are invisible on the braille display, too.
If I place the cursor of my braille display directly in front of an (invisible) curly brace and then press the spacebar, I can very briefly make the curly brace appear on the braille display before it goes invisible again.
Also, before changing the JCF file in the aforementioned manner, the cursor routing keys no longer worked, i.e., they did not move the cursor to the location where the key was clicked. After adding the setting, the cursor routing keys work as they should again.

It seems that Freedom Scientific has replaced the early February
release with a new release on 15 February, keeping the same version
number as the previous one, but resolving the VS Code issue. So, if
you didn't already have the February release, download the update and
you'll have the fix. If you downloaded the update after 15 February,
you'll already have it... And if you had updated to the February
release before 15 February, you will need to download the version
again from the FreedomScientific website and install it to get the
fix.
2024-02-19 22:10 GMT, Almost-Senseless-Coder @.***>:

Braille display user perspective:
Curly braces are invisible on the braille display, too.
If I place the cursor of my braille display directly in front of an
(invisible) curly brace and then press the spacebar, I can very briefly make
the curly brace appear on the braille display before it goes invisible
again.
Also, before changing the JCF file in the aforementioned manner, the cursor
routing keys no longer worked, i.e., they did not move the cursor to the
location where the key was clicked. After adding the setting, the cursor
routing keys work as they should again.
--
Reply to this email directly or view it on GitHub:
https://github.com/microsoft/vscode/issues/200956#issuecomment-1953214494
Unsubscribe from this thread:
https://github.com/notifications/unsubscribe-auth/ABZ4HFH4GWKPRRY76P6UMHDYUPETZBFKMF2HI4TJMJ2XIZLTS6BKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZDKNRRGI4TSOJTURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SMZRGY4DCMZTGY2KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNJGU2TAOBYGM2DEM5ENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDCMJVHA4DIMJRGM3KI3TBNVS2S2DBONPWYYLCMVWKY43VMJVGKY3UL52HS4DFVREXG43VMVBW63LNMVXHJJTUN5YGSY3TS2BKI5DZOBS2U4TFOBXXG2LUN5ZHTJLWMFWHKZNIGQYTQOBRHEYDBAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDEMBUGM3DOMJTGI3IFJDUPFYGLJLMMFRGK3FFOZQWY5LFVEZDKNRRGI4TSOJTQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKJTGE3DQMJTGM3DJAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTKNJQHA4DGNBSGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGEYTKOBYGQYTCMZWU52HE2LHM5SXFJTDOJSWC5DF
You are receiving this because you authored the thread
Message ID: @.***>

Thanks for verifying @kastwey

It is a JAWS issue, but for now they don't seem to fully understand what causes it. I asked them to keep us posted as they investigate on their end and to let us know in case there is something that we can do.

Yes, ultimately it is a jaws issue, but jaws works well with previous versions of vscode (worked well, I didn't try uninstalling vscode to try it if it works now). I tested it with narrator, and it also doesn't detect these characters, even though when reading the line character by character it detects them, because the reading (character by character) is done by virtual buffer (in narrator). If in virtual pc cursor, jaws also detects them. So, I think it has something to do with vscode. Now it's too late, but tomorrow I'll try reinstalling an older version of vscode and see if jaws (and narrator) detects these characters.

There is already a fix for this issue: https://blog.freedomscientific.com/download-new-software-builds-to-improve-accessibility-in-chrome-beta-and-visual-studio-code/
It doesn't manifest with any other screen reader that we know of, so I believe it is safe to close it.

Yes, ultimately it is a jaws issue, but jaws works well with previous versions of vscode (worked well, I didn't try uninstalling vscode to try it if it works now). I tested it with narrator, and it also doesn't detect these characters...

Narrator does detect the characters if you configure it to read all punctuation. It also works well with nVDA, and voiceover on the mac. I suspect that the issue in JAWS was the result of something related with the way they handle Unicode characters. They published the fix officially at: https://blog.freedomscientific.com/download-new-software-builds-to-improve-accessibility-in-chrome-beta-and-visual-studio-code/

What I did:

I tried reading it with narrator, it didn't work, but I realized that it was because of the way narrator reads text, so, not related to this problem.
I got nvda and tried reading them with it, and it read them perfectly, but this is not surprising, nvda always read web text fields better, I don't know why, maybe it has to do with the fact that nvda uses py libs to get the text field content.
I downgraded vscode to 1.69.1 (x64), and surprise it read "{}" characters without a problem.
Even with the newest vscode, when reading the code with virtual pc cursor (as a web content), jaws reads these characters.

What I propose:
Although always the easiest way forward for softwares is to leave the accessibility problems to the accessibility app (in this case jaws), this specific problem affects previous versions of jaws also, and it is known that jaws has some limitations when it comes to reading some types of content, so, in my opinion it would be better if - by increasingly updating vscode  and finding the specific update that caused the problem - the team would consider removing that feature (if it is not that important), or at least identifying it, so jaws users would have another option of solving this problem.
If I could pinpoint the problem (to help the team working on this), I'd say it has something to do with the colors of some new font effect possibly implemented in newer versions, however, without any more context, this is the best i can think of.
This jaws update is just a patch, I think jaws has a lot more of these issues and I think the vscode team identifying the problem would help them (the team) prevent similar issues in the future.

Yes, ultimately it is a jaws issue, but jaws works well with previous versions of vscode (worked well, I didn't try uninstalling vscode to try it if it works now). I tested it with narrator, and it also doesn't detect these characters...

Narrator does detect the characters if you configure it to read all punctuation. It also works well with nVDA, and voiceover on the mac. I suspect that the issue in JAWS was the result of something related with the way they handle Unicode characters. They published the fix officially at: https://blog.freedomscientific.com/download-new-software-builds-to-improve-accessibility-in-chrome-beta-and-visual-studio-code/

In my last comment I addressed this as well.

hello,
i can confirm the problem with latest NVDA2024.2 also.
narrator is not reading the text area at all. i'll try to downgrade my vscode.


Message Production from String

Every message defined by the user should be able to be instantiated by simply providing an appropriate string to a static method of the class.

Already implemented as the Message.from_data method.


[Bug]: Internally calculated luma value goes only as high as 93 even on a full white contents

Steps for reproducing the issue
Log luma values in wluma by opening a fullscreen white color here without any screen dimming software etc. running that might interfere with wluma's luma reading.
What is the buggy behavior?
It only goes as high as 93.
What is the expected behavior?
It should go as high as 100.
Logs
No response
Version
master
Environment
I am running https://github.com/YaLTeR/niri/.
_> lsb_release -a; uname -a; pgrep -l sway; pacman -Q | egrep "(wlroots|vulkan|sway|hyprland|clang|rust)"; dpkg -l | egrep "(wlroots|vulkan|sway|hyprland|clang|rust)"; echo
 "WLR_DRM_NO_MODIFIERS=$WLR_DRM_NO_MODIFIERS"
fish: Unknown command: lsb_release
Linux archlinux 6.12.4-zen1-1-zen #1 ZEN SMP PREEMPT_DYNAMIC Mon, 09 Dec 2024 14:30:31 +0000 x86_64 GNU/Linux
1539 swayosd-server
1591 swaybg
egrep: warning: egrep is obsolescent; using grep -E
clang 18.1.8-4
hyprland 0.45.2-3
lib32-vulkan-icd-loader 1.4.303-1
lib32-vulkan-intel 1:24.3.1-3
lib32-vulkan-mesa-layers 1:24.3.1-3
lib32-vulkan-radeon 1:24.3.1-3
lib32-vulkan-validation-layers 1.3.296.0-1
python-pywlroots 0.17.0-2
rust-analyzer 20241216-1
rustup 1.27.1-1
sway 1:1.10-1
swaybg 1.2.1-1
swayidle 1.8.0-2
swaylock-fprintd-git r314.ffd639a-2
swayosd-git 0.1.0.r0.gdbb8b72-1
vulkan-extra-tools 1.3.298-1
vulkan-headers 1:1.4.303-1
vulkan-icd-loader 1.4.303-1
vulkan-intel 1:24.3.1-3
vulkan-mesa-layers 1:24.3.1-3
vulkan-radeon 1:24.3.1-3
vulkan-tools 1.4.303-2
vulkan-utility-libraries 1.4.303-1
vulkan-validation-layers 1.3.296.0-1
wlroots 0.18.2-1
wlroots0.17 0.17.4-3
fish: Unknown command: dpkg
fish:
lsb_release -a; uname -a; pgrep -l sway; pacman -Q | egrep "(wlroots|vulkan|sway|hyprland|clang|rust)"; dpkg -l | egrep "(wlroots|vulkan|sway|hyprland|clang|rust)"; echo "WLR_DRM_NO_MODIFIERS=$WLR_DRM_NO_MODIFIERS"
                                                                                ^~~^
WLR_DRM_NO_MODIFIERS=

Helpful: https://github.com/maximbaz/wluma/tree/debug-pixels-on-white

@maximbaz Can you tell what it shows on your setup and what your setup is?

Ah sorry I should have said more explicitly 😊 run that branch using RUST_LOG=trace cargo run and open fully white screen, long list of numbers should be printed, if not adjust the condition in the latest commit of that branch - my list consists only of 255, which is the expected result on fully white screen.

With a small change on top the main branch:
-const BUFFER_PIXELS: u64 = 500 * 4;
+const BUFFER_PIXELS: u64 = 3840 * 2400 * 4; // 3840x2400 is my display resolution, the only display attached

I can see the luma value shown in new learning entries with [als.none] be a full 100. I think the bug is solved?

Impressive bug :joy: In fact 563 * 4 would be enough for your resolution. Very nice of me to test on my 4k screen 16:9 back in the days and think "ah who will ever buy a larger screen than me", let alone 16:10 :joy:
Thanks for catching this!

Should be fixed by https://github.com/maximbaz/wluma/commit/f6f0312941b32a92622cbdc94a3c34e3763b33e8 :pray:


Negative Binomial Distribution Calculator

I would like to add this calculator under probability section

Go ahead
Deadline 25 May,2021


cargo doc fails with  cannot find function bitwise_bin_op_simd_helper when using features=["simd"]

This was noticed by @ritchie46
cargo doc fails with cannot find function bitwise_bin_op_simd_helper when using features=["simd"]
To Reproduce
Create a new empty repo
$ cargo new --bin repro

Add
arrow = {version="4.0.0", default-features = false, features=["simd"]}

to Cargo.toml
Then try to build docs:
cd repro
cargo +nightly doc --all-features

The build fails:
    Checking arrow v4.0.0
error[E0425]: cannot find function `bitwise_bin_op_simd_helper` in this scope
   --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.0.0/src/buffer/ops.rs:258:9
    |
125 | / pub fn bitwise_bin_op_helper<F>(
126 | |     left: &Buffer,
127 | |     left_offset_in_bits: usize,
128 | |     right: &Buffer,
...   |
152 | |     buffer.into()
153 | | }
    | |_- similarly named function `bitwise_bin_op_helper` defined here
...
258 |           bitwise_bin_op_simd_helper(
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `bitwise_bin_op_helper`

error[E0425]: cannot find function `bitwise_bin_op_simd_helper` in this scope
   --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.0.0/src/buffer/ops.rs:369:9
    |
125 | / pub fn bitwise_bin_op_helper<F>(
126 | |     left: &Buffer,
127 | |     left_offset_in_bits: usize,
128 | |     right: &Buffer,
...   |
152 | |     buffer.into()
153 | | }
    | |_- similarly named function `bitwise_bin_op_helper` defined here
...
369 |           bitwise_bin_op_simd_helper(
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `bitwise_bin_op_helper`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0425`.
error: could not compile `arrow`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

Expected behavior
Documentation builds successfully, without error

I guess there was a similar issue for 3.0.0, for this version it worked only with the combination simd and avx512. I thought it was fixed and added to the CI, but it doesn't seem so.
Cf. https://issues.apache.org/jira/browse/ARROW-11387 and https://github.com/apache/arrow/pull/9337.

I just verified that this is still a problem with latest master from arrow-rs

Does this mean that enabling the simd feature when using arrow as a dependency did not work at all? That would explain why I did not see any performance difference in benchmarks when enabling that feature recently.

Ok, I did another test and now apparently this Cargo.toml works for $ cargo +nightly doc --all-features:
[package]
name = "foo"
version = "0.1.0"
authors = ["Ritchie Vink<EMAIL_ADDRESS>edition = "2018"

[dependencies]
arrow = {version="5.0.0-SNAPSHOT", git = "https://github.com/apache/arrow-rs", branch = "master", default-feature = false, features = ["simd"]}

And the published version on crates.io fails
[package]
name = "foo"
version = "0.1.0"
authors = ["Ritchie Vink<EMAIL_ADDRESS>edition = "2018"

[dependencies]
arrow = {version="4.0.0", default-features = false, features=["simd"]}

with:
error[E0425]: cannot find function `bitwise_bin_op_simd_helper` in this scope
   --> /home/ritchie46/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.0.0/src/buffer/ops.rs:258:9
    |
125 | / pub fn bitwise_bin_op_helper<F>(
126 | |     left: &Buffer,
127 | |     left_offset_in_bits: usize,
128 | |     right: &Buffer,
...   |
152 | |     buffer.into()
153 | | }
    | |_- similarly named function `bitwise_bin_op_helper` defined here
...
258 |           bitwise_bin_op_simd_helper(
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `bitwise_bin_op_helper`

error[E0425]: cannot find function `bitwise_bin_op_simd_helper` in this scope
   --> /home/ritchie46/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.0.0/src/buffer/ops.rs:369:9
    |
125 | / pub fn bitwise_bin_op_helper<F>(
126 | |     left: &Buffer,
127 | |     left_offset_in_bits: usize,
128 | |     right: &Buffer,
...   |
152 | |     buffer.into()
153 | | }
    | |_- similarly named function `bitwise_bin_op_helper` defined here
...
369 |           bitwise_bin_op_simd_helper(
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `bitwise_bin_op_helper`

So apparently this bug is already fixed, but do we know what fixed it?

This might have something to do with the crates.io releases. I am able to get a successful build from 4.4.0 tag (32b835e5bee228d8a520151) if I use git as the crate source. However, the 4.4.0 release in crates.io results in the same simd build error for me.


Use PORT instead of VCAP_APP_PORT

VCAP_APP_PORT is no longer supported in Cloud Foundry Diego architecture, VCAP_APP_HOST either.

fixed


Do not allow staff users to hijack superusers

This adds a check when staff users are hijacking to see if the users that is being hijacked is a superuser. If that is the case the request is denied. This also adds some additional tests that should pass.

Thanks @frwickst


A potential bug in RK2 solver in droplet

When the RK2 solver is used in droplet, the code fails for Intel compiler on CPU and NVHPC compiler on GPU, but somehow finishes for NVHPC compiler on CPU.
After some diagnostics, it turns out that the issue comes from the line https://github.com/george-bryan/CM1/blob/gpu-opt/src/droplet.F#L864. The rptmp value is somehow negative and thus makes Rep negative, which then makes the sqrt function invalid.
It seems a bug to me but I do not know how to fix it. May need to talk with David.

According to David's reply, the RK2 solver is unstable for the conditions set in the baseline namelist files.
This isn't a bug, just a limitation of the explicit silver.


SQLiteConnectionPool﹕ The connection pool for database [...] has been unable to grant a connection [...]

From @kombadzomba  https://github.com/couchbase/couchbase-lite-android/issues/289#issuecomment-216710117

I am sorry if waking up this zombie thread is wrong, but I am having troubles with the similar output that was mentioned in this thread. I've tried couchbase lite libs 1.1.0, 1.2.0 and 1.2.1.
The issue is reproducible on Nexus 5 all the time and the scenario is running a query with compound keys on a view that has around 5500 documents. I have only map function in the view:
emitter.emit(Arrays.asList(
    document.get("device_imei"),
    document.get("name")
), null);
And this is how I set start and end keys:
view.setStartKey(Arrays.asList(deviceIMEI, null));
view.setEndKey(Arrays.asList(deviceIMEI, new HashMap<String, Object>()));
The query never ends and on every 30 seconds I get output that was mentioned in the begging of this thread:

05-04 02:22:44.957 32550-2346/net.dzomba.termin3.stage W/database: SQLiteConnectionPool: The connection pool for database '/data/user/0/net.dzomba.termin3.stage/files/org_2.cblite2/db.sqlite3' has been unable to grant a connection to thread 5188 (RxNewThreadScheduler-3) with flags 0x1 for 360.01 seconds.
Connections: 1 active, 0 idle, 0 available.
Requests in progress:
executeForChangedRowCount started 359545ms ago - running, sql="INSERT INTO 'maps_9' (sequence, key, value) VALUES(?,?,?)"

Can you please try to reproduce this?

Hi @kombadzomba,
Could you please provide code snippet of entire query codes and sample documents? If you could provide us small sample app, it helps us to debug a lot.
Thanks!
Hideki

Hideki, thanks for fast actions!
Yes, I can provide some code snippets:

Sample documents - There are three of them shown but the rest is the same, just the name and phone_mobile fields are different.
CouchDbFacade - Entry point
ClientByNameTypeDeviceView & AbstractView - The view & the query
ClientEntity & CommonEntity - Document object
ClientOriginCode & DocumentTypeCode & Enums - Constants

I hope this can help.

@kombadzomba, Thank you for providing sample doc and codes. We will try to reproduce the issue. Thanks again!

Hi @kombadzomba ,
I wrote the test based on your inputs. However I could not reproduce the SQLiteConnectionPool issue with it. Could you please review the test I wrote?
Test codes:
https://github.com/couchbase/couchbase-lite-android/blob/feature/issue_1222/src/androidTest/java/com/couchbase/lite/ViewsTest.java#L3351-L3422
Thanks!
Hideki

Could be same problem: https://github.com/couchbase/couchbase-lite-android/issues/854

Hi @kombadzomba,
What version of Couchbase Lite are you using? If this issue's root cause is same with the issue, couchbase/couchbase-lite-android#854, the issue is already addressed with v1.2.1. Please try v1.2.1?
Thanks!

Hi @hideki,
Your test is perfect.
When I run your test peeled a little bit it passes.
However, I still have the issue in production although the code looks the same. It feels like the data content in the real database may be the cause. If I succeed to create a TestCase that reproduces the issue I'll put it here in this thread.
You've asked about couchbase-lite version I use. It is 1.2.1. Few more notes that may be interesting... My build.gradle contains:
compile fileTree(include: ['*.jar'], dir: 'libs')
// compile 'com.android.support:appcompat-v7:21.0.3'
compile 'com.couchbase.lite:couchbase-lite-android:1.2.1'
You may notice that I've commented appcompat. I am using supportLibVersion = "23.2.1".
Regards!

@kombadzomba,
In general, our library is independent from android libraries. I guess it is not appcompat issue.
Next time you encounter this issue, could you please take a thread dump?
Steps to take thread-dump:
https://github.com/couchbase/couchbase-lite-android/issues/854#issuecomment-217596694
Thanks!

Here is the Thread dump.
net.dzomba.termin3.model.couchdb.CouchDbFacade.getClientByNameTypeDevice() is the blocked method that calls the query on a view.

Here is another thread dump.

Hi @hideki,
I've noticed that you have used TransactionalTask for database inserts in your test case. I am not using any in my code for updates nor inserts. That is the reason I removed database inserts and updates in my second thread dump. However that didn't help. I see that index update for the queried view is running in both thread dumps. My index update mode is: Query.IndexUpdateMode.BEFORE.
Regards.

Hi @kombadzomba,
thank you very much for capturing thread-dump. It helps me a lot.
From both thread-dumps, one thread is holding SQLite connection and busy for updating index. Another thread waits for SQLite connection.
CBL SQLite storage opens only one SQLite connection for both read and write. In case of your app, updateIndex() takes long time to finish, and it holds SQLiteConnection. Other thread can not obtain SQLiteConnection.
We are considering to change to one SQLiteConnection for writer and one SQLiteConnection for reader. So reader will not be blocked by writer. If it works, next step could be one connection for writer, and multiple connections for reader.
Thanks,
Hideki

Todo:

Make SQLite one writer and multiple reader

Hi @kombadzomba,
We made SQLite one writer and multiple readers mode. Maximum SQLite connection is 4. Writer is only one connection. Reader could be 1-4 connections. Reading thread should not be blocked by writer thread.
Sorry for keep asking, could you please test 0.0.0-733 with your error scenario?
http://files.couchbase.com/maven2/com/couchbase/lite/couchbase-lite-android/0.0.0-733/


integrated terminal  is always full-width show

VSCode Version:
Version: 1.38.1
Commit: b37e54c98e1a74ba89e03073e5a3761284e3ffb0
Date: 2019-09-11T13:30:08.229Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 5.0.0-29-generic
OS Version:
Linux dwh-OptiPlex-7060 5.0.0-29-generic #31~18.04.1-Ubuntu SMP Thu Sep 12 18:29:21 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
OS Language:
LANG=zh_CN.UTF-8
LANGUAGE=zh_CN:zh
Steps to Reproduce:

1.Open VS Code
2.Open up the integrated terminal
3. ls

Does this issue occur when all extensions are disabled?: Yes/No
Yes.

/needsMoreInfo
Could you provide exact expectations and what's the problem?
Is it font/characters layout or anything else?

/duplicate https://github.com/microsoft/vscode/issues/35681


Prevent huge amount use of network data

I'm using K9 Mail for a long time and I noticed the new version as the UI changed a lot
The version I'm currently using and I'm writing for is 5.800
Phone : Samsung Galaxy S5 (SM-G920F)
Android 7 shipped by Samsung
Kernel 3.10.61
5 accounts set
While using my 4G data, my phone alerted me the limit usage was reach, after taking a look, K9 has used 5Go in less than a day
I took a look on the "what's new" and searched in issues what could make it so hungry for data, it looks it comes for push notifications
I'm french and my phone language set to french, the translations make it harder to understand what's happening with the settings
It would be nice to alert the user the feature can require a lot of data, and explain what is the feature and how it works, and the best would be to be able to set different behavior on wifi and 4G networks
I changed my settings in the app and looks it's not using data anymore as much as it was
If I'm not clear I can explain again

Please update to K-9 Mail 5.802 and check if there is still a problem. You're most likely experiencing a bug, not regular behavior of K-9 Mail. See #5487.


README issues

ocm

Setting up the OCM backend package 5 ii: codeblock title needs to be updated to packages/backend/src/plugins/catalog.ts
Setting up the OCM frontend package 2 2: codeblock highlighting should include isType function and the entirety of resourcePage

quay

Configuration 2: codeblock highlight should include <EntityPageLayout.Route /> closing tag

topology

The text above the third codeblock: customResources is missing a space before the inline codeblock

I'm planning to work on it.

@lokeshrangineni any update?


Many changes in addition to render selected.

List of changes.
-Fix detecting example files in the examples directory.
-Added UI for render selected objects only.
-Remove some unessacery calls to guess_rmantree()
-Added function to get folders in a directory (for examples sub-system)

That makes sense. Let me know if you see anything else that would be good to change.


Set zoom level programmatically

How can I set the zoom level in such a way that the canvas drawable items are visible on the screen, initially.

Did you find any solution ?


Added Support for M1 Mac

This fixes issue #112 by considering architecture as well when detecting the platform.

Thanks @henryhchchc, this is a much-needed fix!
Maintainers, any indication when this might become available in a release?

Thanks @henryhchchc, this is a much-needed fix!
Maintainers, any indication when this might become available in a release?

You would be much faster if you just take the code of this repo include this PR and build jar file, then simply add to your build.gradle.
buildscript {
  repositories {
    mavenCentral()
  }
  dependencies {
      classpath "org.javamodularity:moduleplugin:1.8.10"
    classpath 'com.google.gradle:osdetector-gradle-plugin:1.7.0'
    classpath files('libs/javafx-plugin-0.0.11-SNAPSHOT.jar')
  }
}
apply plugin: 'org.openjfx.javafxplugin'

the code of this repo include this PR and build jar file, then simply add to your build.gradle

The simpler thing to do is just depend on the latest snapshot from this repository, as can be seen at https://github.com/cbeams/bisq/commit/8546f59b12a58775e6bf7fa1852204cfcfdb9f8e#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R6-R12.
Naturally, however, we'd like to depend on an official release of the javafx-gradle-plugin from a non-snapshot repository.
@jperedadnr, any word on an upcoming release?

@henryhchchc As per the Contributions section, you will need to sign the CLA before we can integrate this PR once reviewed.
@cbeams Using a snapshot won't help, unless you fork, commit the proposed change, build and publish locally.

@cbeams Using a snapshot won't help, unless you fork, commit the proposed change, build and publish locally.

Right. That is in fact what I'm doing, as per the comment in the commit I linked to, but I forgot and wrote what I did above as if we were depending on a nightly build. Looking forward to seeing this in a release in any case, thanks.

@henryhchchc As per the Contributions section, you will need to sign the CLA before we can integrate this PR once reviewed.
@cbeams Using a snapshot won't help, unless you fork, commit the proposed change, build and publish locally.

I see. I signed the CLA just now.

Thanks for the suggestions. I made the updates accordingly.

This PR has been integrated now, and there is a new snapshot available (0.0.11-SNAPSHOT) at https://oss.sonatype.org/content/repositories/snapshots
Before doing a release, @henryhchchc, @cbeams, @norbertas-gaulia and others, could you please test it?

Before doing a release, @henryhchchc, @cbeams, @norbertas-gaulia and others, could you please test it?

I've upgraded to the snapshot published above (see https://github.com/cbeams/bisq/commit/abf86ac0a072a5131f9be3f872f0f4d8662fe6f1), and all works as expected. Thanks, @jperedadnr.

@jperedadnr What about doing a new release?

@jperedadnr What about doing a new release? Thanks!

It looks like a release containing this fix was shipped with v0.0.11 on Jan 17th, and 0.0.12 has been released since then. I have not tested either yet, but did test the patch itself as per https://github.com/openjfx/javafx-gradle-plugin/pull/113#issuecomment-997647044.


Bower install issue

Hey,
I would first like to thank you that you have taken the time to create this plugin.
However, I ran into an issue when trying to install it with Bower, and I hope you can help:
module.js:338
throw err;
^
Error: Cannot find module 'insight'
at Function.Module._resolveFilename (module.js:336:15)
at Function.Module._load (module.js:278:25)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at ensureInsight (C:\Users\Nikola\AppData\Roaming\npm\node_modules\bower\lib\util\analytics.js:24:23)
at Object.setup (C:\Users\Nikola\AppData\Roaming\npm\node_modules\bower\lib\util\analytics.js:41:9)
at Object. (C:\Users\Nikola\AppData\Roaming\npm\node_modules\bower\bin\bower:72:11)
at Module._compile (module.js:460:26)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)

I think, you need to check the version of npm, node and bower. Update them and try installing them again.

Actually, I downloaded the project manually. Great work btw. However, I was wondering how come the closing function needs to be added to the controller? Couldn't it be somehow solved without it, by placing the closing timeout into the plugin? I mean, I'm not complaining, just curious.

You can use the stick property mentioned in the repository description. If you set it to true, you will be able to see the close button in the toaster or else it will close after some time automatically. Even you will be able to give the time as one of the property.


Configure colours

It would be great if you could configure the colours for above and below the median separately, or all elements of the box (whiskers etc).

see also
https://github.com/sgratzl/chartjs-chart-boxplot/blob/388c3383907f1e10c2ad4385a0ac63982f22ff99/src/elements/base.ts#L6
and
https://github.com/sgratzl/chartjs-chart-boxplot/blob/388c3383907f1e10c2ad4385a0ac63982f22ff99/src/elements/BoxAndWiskers.ts#L6

Thanks - the docs could do with an update to make this clearer.

Thanks - the docs could do with an update to make this clearer.
I'm looking forward to your PR


Clemensgg/fetch all chains

This PR introduces the following changes:

uses github api
downloads full repo as zip
periodic caching
routes the /fetch calls to cache, if no cached data is found it fetches live
introduced GET /mainets & /testnets (calls cache)
number of workers can be set with env var NUM_WORKERS=x (default: 10)

rebased with main


Added g2p (grapheme to phoneme) problem

G2P (grapheme to phoneme) is a problem to convert the written word to phonemes, a very popular task in speech recognition. This initial PR adds a problem description based on CMUDict dataset.

I signed it!

@nshmyrev : are you back? We'd love to merge it, but some changes are needed on your side. Let us know!

Closing for now due to lack of activity.

@lukaszkaiser @nshmyrev so this has not been merged at the end?

I still hope to find the time to work on this, maybe this month.


Nuxt error scalar doesn't load correctly

What happens?
When I add scalar ad a module to the nuxt setting file. the webpage didn't load. Even the root path fail to load.
This error showed up in the console.
[nuxt] `#imports` should be transformed with real imports. There seems to be something wrong with the imports plugin.
[Vue Router warn]: No match found for location with path "/"

What did you expect to happen?
The root path should be what ever I put in the app.vue and /scalar or /doc should show the scalar doc page.
How can we reproduce the issue?
https://codesandbox.io/p/devbox/rough-resonance-46kd6c
Create a nuxt project, add the scalar module in the config file.
OpenAPI Document
No response

any update on this ?

Hey @Mdev303 theres a couple minor hydration errors, but it seems to be working for me, check out this repo
https://github.com/amritk/nuxt-test
bun i
bun dev

and visit http://localhost:3000/docs


null ridbag for delete vertex

i do have following error for 2.1-rc3. any idea?
this happen for simple query 'delete vertex class'
java.lang.NullPointerException: Impossible to add a null identifiable in a ridbag

Hi we are working on it right now.
Will fix it during couple of days .
On Wed, Jun 10, 2015, 09:44 martingg88<EMAIL_ADDRESS>wrote:

i do have following error for 2.1-rc3. any idea?
this happen for simple query 'delete vertex class'
java.lang.NullPointerException: Impossible to add a null identifiable in a
ridbag
—
Reply to this email directly or view it on GitHub
https://github.com/orientechnologies/orientdb/issues/4337.

sure thanks.

what is the method i can force to delete for now ?

We are creating tool to fix error in data structure please wait couple of
days .
On Wed, Jun 10, 2015, 09:56 martingg88<EMAIL_ADDRESS>wrote:

what is the method i can force to delete for now ?
—
Reply to this email directly or view it on GitHub
https://github.com/orientechnologies/orientdb/issues/4337#issuecomment-110619936
.

thanks.

hi @martingg88  do you have
the stack trace?

sorry. i didn't keep the stack trace for this issue.

Hi it is fixed in latest build but please feel free to reopen it if it will be reproduced.

sure. thanks.


api(sorting): builds/jobs sort order is confusing

Data displayed in Kashti appears in an odd sequence, and I think it's mapped to how the Brigade API is structured - sorting by the build ID hash.
See example builds at: https://example-api.technosophos.me/v1/project/brigade-9afa37b976ab4bd116557b613000959d24feb08dfac37fcf6ae3cb/builds
E.g. builds #1 and #5 were today, build #0 was yesterday. I would expect the output to be in a chronological order; though perhaps there is a reason for it being this way - I have a UI bias!

Related kashti issue #179.

You can see the unusual ordering in the API and also here in Kashti.

Closed by #526


feat: add validateBlueprintConfig and notifications in the rundown view

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This will make core validate that all the required blueprint config fields are defined for the rundown being viewed.

What is the current behavior? (You can also link to an open issue here)
It is up to the blueprints to do this check. This means that every segment in the show will end up logging a warning for each missing field.

What is the new behavior (if this is a feature change)?
Core now does the check at the same interval as checking if the configuration has changed since the rundown has been imported. It will then present up to 2 notifications to warn of the missing fields.

This is much less repetitive and easier to read then before. Additionally, any blueprint hooks wont log the same warnings to the core log, which will help clean those up a bit.

Other information:

The config missing isnt a major problem, as the blueprints do define defaults for them all, but it indicates that something has been configured wrong. For this reason it is a warning, and doesnt want to be too intrusive as the show will likely work just fine without.
Partner change in blueprints: https://github.com/nrkno/tv-automation-sofie-blueprints/pull/28
Status

[x] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

This sounds like a larger discussion for how we want to treat things like this in general. Because if the config is going to be strict and fail if something looks wrong, then we should start doing the same for mappings and other things.
But also then we should not allowing playing a rundown if the config has changed since rundown import, as again that could result in broken playout
But I dont think we should be hard failing for this. Ultimately this config belongs to the blueprints, so I think that if it should fail, then the blueprints should be explicitly deciding that instead of this minimal check in core, as one not being set is no worse than being set to a bad value. The blueprints can already do that if they want to.
So if we do a strong invalid check, it should be done completely by the blueprints and should take some steps to decide if the values also look ok (which will likely be hard, messy and error prone).
Additionally, a hard fail could make things worse. In the unlikely event that something is changed between rundown import and running the show, this would cause any metadata sending to fail as well as rundown updates, making a potentially incorrect show be very broken part way through.
I am open to emitting a warning if the config is invalid at the time of execution, but it should be done in a way that is not shown to the user. This will be easy as the check is run by core.
With the current version of this PR, the blueprints are already not validating the config they receive. They do the exact same processing for optional and required fields.
From all this, I propose that we do:

check-of-configs should affect systemStatus
the check-of-configs have to be made before executing blueprints and log it

I agree, let's do that!

@nytamin I have reworked this to cover the points proposed


convert setup.py to pyproject.toml

The following PR converts the old-style setup.py to a modern pyproject.toml, also replacing setuptools with hatchling (https://hatch.pypa.io/latest/config/build/).

Thanks for the PR @sim0nx ! Could you please briefly explain the benefits of moving from setup.py to project.toml? I'm not well versed in python packaging and distribution. Is setup.py deprecated or there is a timeline for the deprecation? Also, do we need the hatchling dependence?

Using setup.py is considered legacy (https://pip.pypa.io/en/latest/reference/build-system/setup-py/). Today packaging should use a pyproject.toml which is a flexible way of configuring project settings, dependencies, tools etc.
With the introduction of pyproject.toml (a long while ago), the build system, i.e. tools to use to build your package, was being made flexible. Meaning you could be using setuptools, but there are many other options.
Hatchling is just one of those and in fact the one by pypa (The Python Packaging Authority (PyPA) is a working group that maintains a core set of software projects used in Python packaging.) that is currently recommended for new projects (https://packaging.python.org/en/latest/tutorials/packaging-projects/).
The hatch-vcs module will allow you, if wanted, to automatically build a package with the version defined as your current git tag, which is a convenient way to help automate things.


Platform specific annotations for conversations

Currently all Intents have the same settings. You cannot configure actions, if a parameter is a list nor if a intent is a fallback.
Proposal
Event handling
Here we define a sign in event for Actions on Google.
@Event("actions_intent_SIGN_IN")
LoginHandler:
- Great!

Marking fallback intents
This should set the fallback flag on Dialogflow and change on Alexa the name to Amazon.FallbackIntent in a much more convenient way.
@Fallback
FallbackIntent:
- Sorry I didn't understand you. Can you say it different?

Marking parameters as list
This allows Dialogflow to match multiple ingridents at once. For Alexa it will be still just one.
@ListParameters("ingredient")
RecipeSearch:
! I'm looking for a recipe with {{ingrident:MyIngredient}}

Platform specific renamings
While YesIntent makes sense we need for Alexa the Amazon prefix which can be defined as above.
@AlexaName("AMAZON.YesIntent")
YesIntent:
! Sure
! Sounds great

Advanced example
Here we put all together, so that we can use the Konversation "exit" and have a speaking name on Dialogflow while Alexa has its correct name. It also marks the StopIntent as the cancle event handler for Dialogflow.
@DialogflowName("StopIntent")
@Event("actions_intent_cancle")
@AlexaName("AMAZON.StopIntent")
Exit:
!  Leave me alone
- See you soon

Added in cli-1.1.0-rc9


JS -- add support for page property in field

Page property is the page where the field is.
Currently the page is undefined which can lead to errors (see bug 1708641).

/botio test


Update documentation temporarily

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Solution selected by

This PR shows who selected an answer.

Can we revert the HasSolutions trait here to make the diff a bit smaller? That'll make reviewing the PR much easier. Thanks

@driesvints Converted to Pest 🚀

I had to push one extra commit here: https://github.com/laravelio/laravel.io/commit/cdb164c87892e7829cec9b43f539f010a3c7eba3


Add meeting notes from 2023-01 (January 2023)

Since I didn't see anyone else adding them, I figured I'd go ahead and do so. The meeting notes from January, removing the leftover bullet points we didn't get the chance to discuss, and with some light formatting cleanup (as a separate commit, for full transparency). I wasn't sure if I should add links to Petr's PR with the SVGs or updates on anything else, since that was well after the meeting.

Maybe worth implementing python/core-workflow#460 here for triagers and core devs? I can't tag @hugovk for review, which I suspect may be because he doesn't even have the Write or even Triage role here, despite being a core dev, PEP editor, docs team/proofreader member, etc.,

Thanks for getting to this!


MAINT: special: remove more npy_math.h usage

Cephes is now free of all npy_* and NPY_* symbols. This reduces usage down to the not-yet-replaceable typedefs and complex dtype functions.

This fixes an issue with the use of npymath that turned out to be a problem in numpy 1.24.0rc1 (use of npy_asinh, removed here). The symbol will be restored in numpy through a compat shim, but still we should get rid of it. I marked this for 1.10.0. The goal for 1.11.0 should be to stop using libnpymath.a and libnpyrandom.a completely.

Sorry I haven't been following the npymath issues closely.  Is there an "executive summary" of what is going on?  Is the idea that everything that we were using from npymath is now available in the standard C/C++ libraries, so npymath is obsolete?

Is the idea that everything that we were using from npymath is now available in the standard C/C++ libraries, so npymath is obsolete?

Close to it - whatever is in C99 and universally supported by compilers we care about is what we should use. The main exception is complex types, which aren't supported by MSVC, so we still need a little compat layer for that.

Is there an "executive summary" of what is going on?

The main issue is using a static library at all. This is bad, mainly for these two reasons:

It is not guaranteed that numpy and scipy are built with the same compilers. And that leads to potential issues that are hard to predict, as we've experienced multiple times already. Especially on Windows, where we build scipy with mingw and numpy with MSVC. That was the reason why using the vc142 instead of the vc141 toolchain in numpy 1.21.5-1.22.1 led to complex issues and that change had to be reverted.
Cross-compiling tends to break. We haven't officially supported that in the past, but even in the one case where we do it (macOS x64-64 to arm64) it goes pretty horribly wrong: we stuff the x86-64 libnpymath.a into the macOS scipy wheel. This silently worked, because the required symbols were already loaded by numpy itself. Now that they're being removed from libnpymath.a, we're all of a sudden loading them from libnpymath.a and they have the wrong architecture.

tl;dr we should vendor the sources for the few remaining things we need, rather than use numpy's static libraries.

There's a more complete summary in gh-17498 now.


[$500] Status-Set clear status & able to save status without selecting emoji or entering message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.35
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
Tap profile icon
Tap profile --- Status
Tap clear status
Tap custom
Select date, set time and save it.
Now without selecting any emoji and entering status message, tap save

Expected Result:
Without setting status emoji or message, tapping save must show error to select status emoji before saving it.
User sets clear status & must not be able to save status without selecting emoji or entering message.
Actual Result:
Without setting status emoji or message, tapping save not showing any error to select status emoji before saving it.
User sets clear status & able to save status without selecting emoji or entering message.
When there is no status message, allowing user to save clear status and empty status message has no point of use.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/4ceca9b6-5b9c-4fe0-9ba0-9eebf97fc382

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0161ec5a5613f04872
Upwork Job ID:<PHONE_NUMBER>702269440
Last Price Increase: 2024-02-02

Proposal
Please re-state the problem that we are trying to solve in this issue.
User can save an empty status with custom clear after
What is the root cause of that problem?
The issue happens because we do not check the text & emoji to not be empty here:
https://github.com/Expensify/App/blob/d5eba656251269b238797817df3cf84800b0039a/src/pages/settings/Profile/CustomStatus/StatusPage.js#L74-L94
What changes do you think we should make in order to solve the problem?
We should add handling for a case when neither emoji nor text are selected/entered. We should show the validation error in this case.
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
User can save an empty status with custom clear after
What is the root cause of that problem?
The issue happens because we do not check the text & emoji to not be empty here:
https://github.com/Expensify/App/blob/d5eba656251269b238797817df3cf84800b0039a/src/pages/settings/Profile/CustomStatus/StatusPage.js#L74-L94
What changes do you think we should make in order to solve the problem?
Even though the expected behavior says we should show an error in this case, I think it's a better UX to allow the user to clear their status by setting an empty value.
We just should handle the case when there is a clearAfter set, and reset this value if the user is saving an "empty" status. In other words, call clearStatus if !emojiCode && !statusText.
    const updateStatus = useCallback(
        ({emojiCode, statusText}) => {
            if (!emojiCode && _.isEmpty(statusText)) {
                clearStatus();
                return;
            }
...

What alternative solutions did you explore? (Optional)
We should add handling for a case when neither emoji nor text are selected/entered. We should show the validation error in this case:
    const validateForm = useCallback(({emojiCode, statusText}) => {
        const errors = {};
        if (!emojiCode && _.isEmpty(statusText)) {
            ErrorUtils.addErrorMessage(errors, INPUT_IDS.STATUS_TEXT, 'statusPage.statusRequired');
        }
        if (brickRoadIndicator) {
            errors.clearAfter = '';
        }
        return errors;
    }, [brickRoadIndicator]);

@hoangzinh how should this look UX-wise considering there is no such option as "do not set clear status setting" and the default value is automatically set to "Today"?
https://github.com/Expensify/App/blob/3ab4e6e12d9ff38e69493321f0d31f032481b373/src/pages/settings/Profile/CustomStatus/StatusPage.js#L111-L114

As the Today is also a value, we should show an error in this flow as well?

The user has no status set
Opens the "Status" page
The default value of clearAfter is set to Today
The User decides not to enter any value and clicks "Save"
Show the error?

Won't it be a bit confusing for the user considering they've not entered any value and try to save the "blank" state?

I actually don't think this is a bug anymore! When you click "clear status" the status saves automatically:
https://github.com/Expensify/App/assets/59587260/ea6e72fb-0230-4c56-9358-9237c45d8085
Please reopen if you disagree!

@kadiealexander please re-read the steps of the issue. It's not about the "clear status" button.
It's when you have cleared your status (or didn't have one), then set the custom time for "clear after" and click "save" — you'll be able to save an empty status with a defined "clear after" time, which is incorrect UX.

Right! I still don't think this is an issue. Like I said in my comment above: if you save an empty status, even with the clearAfter set to a specific date it will just remain with no status after the end date. It's slightly weird UX, but it's not necessarily incorrect and it's not causing a major error or blocking the user from using Expensify, so I vote to keep it closed. If you strongly disagree, please feel free to bring the conversation to Slack for more thoughts.


[Text] Align API of TextPredictor to TabularPredictor

Description of changes:
Add positive_class as the property. Also, add as_multiclass to predict_proba.
@Innixma
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-975-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-975/1/index.html

Job PR-975-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-975/2/index.html

Job PR-975-3 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-975/3/index.html

Job PR-975-4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-975/4/index.html

Job PR-975-5 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-975/5/index.html


Which Classes are valid in Profiles?

FHIR doesn't know anything about SHR class hierarchy. It doesn't know if an attribute can be a reference to class P, it could be a reference to class C, where C is a subclass of P (P=Parent, C=Child). We aren't taking that into account in our profiles. This will required some careful thought because some classes, like Observation, will have a ton of children.

While the FHIR doc isn't crystal clear on this, I think that when we specify a reference to class P (from your example above) -- that only indicates that the structure it points to must conform to class P.  So... if it actually points to a structure of class C, and class C is a subclass of P, it's still OK -- because any subclass of P should still conform to P.  So, from a validation standpoint, I don't see an issue.
That said, if someone is going on FHIR profiles alone, there isn't a clear way for them to know that class C is a subclass of class P.  So it would be difficult for them to read a profile that has a reference to class P, and know the full list of subclasses that are also viable.
It's possible we could have the profiles enumerate every viable sub-class as well (as a choice), but I don't think that's a feasible solution -- as it would be quite unwieldy when the reference is to something like Observation, which could have 100s (or 1000s) of viable subclasses.

BTW -- here's the part of the FHIR doc that discusses references that specify profiles:

ElementDefinition.type.targetProfile
Identifies a profile structure or implementation Guide that SHALL hold for the target of the reference this element refers to. Can be a local reference - to a contained StructureDefinition, or a reference to another StructureDefinition or Implementation Guide by a canonical URL. When an implementation guide is specified, the resource SHALL conform to at least one profile defined in the implementation guide.

It's not tremendously clear what "SHALL hold" means, but further on, in the context of specifying an IG, it says "SHALL conform".

Hmmm... Let's continue to track this and see if we're generating profiles that make sense. I'm not 100% convinced that we can rely of this. E.g., what happens if the class referred to is not an Entry Element, and there is no profile?

Moved to https://standardhealthrecord.atlassian.net/browse/CIMPL-45. Closing.


How to  Load input tensor using graph

Hello,
How do I migrate nongraph CNN model to graph model.
Specifically how / when to copy the source data to input layer
From Neon_cnn.cpp, first init src tensor, then configure, then allocate and then copy
  // Initialize src tensor
        constexpr unsigned int width_src_image  = 32;
        constexpr unsigned int height_src_image = 32;
        constexpr unsigned int ifm_src_img      = 1;

        const TensorShape src_shape(width_src_image, height_src_image, ifm_src_img);
        src.allocator()->init(TensorInfo(src_shape, 1, DataType::F32));

      graph << target_hint
              << Tensor(TensorInfo(TensorShape(28U, 28U, 1U, batches), 1, DataType::F32), DummyAccessor())

How to do the same using graph API ?
Regards,
Harsh

Tensors initialisation / allocations are automatically handled by the Graph API, you just need to pass the shape, format and an accessor.
The accessor will get called whenever the Tensor needs filling.
If it's a tensor containing weights it will get called only once, if it's a graph input / output it will get called every time the graph gets executed.
You can have a look at the PPMAccessor (implementation here)for an example of how to create a simple Accessor.
Please note, currently there is a known issue with graphs containing only a single node, so make sure your graph contains at least 2 layers when experimenting with the API.

Thanks Anthony.
Regards,
Harsh


Better description of repo-path

Fill out the section on repo-path to define exactly what it contains and define the difference between repo-path and remote-repo-path and how they interact.
Add instructions for setting up repo-path in the software installation section.

Documented in 65d9de4.


fizyr/keras-retinanet2ncnn

got KeyError: 'attr'
class UpsampleLike(keras.layers.Layer):
""" Keras layer for upsampling a Tensor to be the same shape as another Tensor.
"""
def call(self, inputs, **kwargs):
    source, target = inputs
    target_shape = keras.backend.shape(target)
    if keras.backend.image_data_format() == 'channels_first':
        source = backend.transpose(source, (0, 2, 3, 1))
        output = backend.resize_images(source, (target_shape[2], target_shape[3]), method='nearest')
        output = backend.transpose(output, (0, 3, 1, 2))
        return output
    else:
        return backend.resize_images(source, (target_shape[1], target_shape[2]), method='nearest')

this OP UpsampleLike is not support， Can you help me solve it,thanks!

Keras will insert the custom layer as a custom object, and the converter are not able to parse it.
I think you need to flatten your model (using the sequential layer with custom layer inside instead of a custom layer) in order to use the converter.
(or, you can try to implement this layer by your own, since it is just a nearest resize)

OK thanks！


Update firefox.json: v94.0.2

Updates to version 94.0.2.
Not fetched by checkver since Mozilla hasn't updated their release notes, but the news broke on the Neowin software page on nov 18th and it was added to the archive page used in the manifest in the evening of nov 19th.

/verify

Not fetched by checkver since Mozilla hasn't updated their release notes, but it was added to the archive page used in the manifest in the evening of nov 19th.

Should we switch to the archive page (https://archive.mozilla.org/pub/firefox/releases/) in checkver then?

That does sound like a good idea.
Do you mind fixing that change before merging?

I don't :)
Would you like to try that? In this PR itself.

Sure, just make it as a repository admin correction.

To be clear, I spent a couple of hours previously to try and wrap my head around regex, but I can't understand it.
If changing the checkver to the suggested URL requires that knowledge, which I suppose it does looking at the current regex code, it would be great if someone is able to make that correction in another commit based on mine as a baseline.

Try this:
"checkver": {
        "url": "https://archive.mozilla.org/pub/firefox/candidates/",
        "regex": "pub/firefox/candidates/([\\d.]+)-candidates",
        "reverse": true
},

/verify


fixed deprecation notices

Thanks @nicolas-grekas, that's ugly as I anticipated :(

My pleasure ;)


Is the example wrong?

Hello,
The example in the README file is maybe wrong.
import gleam/bytes_builder
import gleam/erlang/process
import gleam/option.{None}
import gleam/otp/actor
import glisten.{Packet}

pub fn main() {
  let assert Ok(_) =
    glisten.handler(fn(_conn) { #(Nil, None) }, fn(msg, state, conn) {
      let assert Packet(msg) = msg
      let assert Ok(_) = glisten.send(conn, bytes_builder.from_bit_array(msg))
      actor.continue(state)
    })
    |> glisten.serve(3000)

  process.sleep_forever()
}

This will throw
error: Type mismatch
  ┌─ /home/xxx/dev/gleam/xxx/src/xxx.gleam:9:21
  │
9 │     glisten.handler(fn(_conn) { #(Nil, None) }, fn(msg, state, conn) {
  │                     ^^^^^^^^^^^^^^^^^^^^^^^^^^

Expected type:

    fn() -> #(a, Option(Selector(b)))

Found type:

    fn(c) -> #(Nil, Option(d))

The on_init function takes no argument: https://hexdocs.pm/glisten/glisten.html#handler if I remove the _conn argument everything works.

Generally, the documentation (including the README) on hexdocs will be the valid reference point for the latest published version.  In this case, there were some changes made on the main branch that were not published yet.  The README was updated here to reflect that.
I have since published a new version, so this should not be an issue anymore.  Just giving context for the future 😃


Test for renaming

Try now to change the cntent of the renamed file please ... lets see if this is then same issue as with me

Now with content change in 2nd commit

grmppffff ... no idea why it behaved that way with my Webstorm :-( Ok ... as said ... I do rename in extra PR

Thank you for the test


can't export , python error

os : mac osx 10.9.5
im getting
Traceback (most recent call last):
File "command_line.pyc", line 288, in download_file_with_error_handling
File "/Users/rs324/Downloads/Web2Executable.app/Contents/Resources/main.py", line 393, in download_file
AttributeError: 'PySide.QtCore.QFile' object has no attribute 'error_string'
tried to export for windows only or windows and mac..
version :  0.1.16b
thanks.

I'll look at this when I get the chance. Thanks for filing the issue!

Also getting this same error. On a mac: 10.10.3

Do either one of you have write access to the folder that you are exporting to? There is a bug in there, but the reason you hit it is due to access issues of some kind.
Please try exporting to a folder that is maybe in your home folder or documents folder and see if that helps.
Cheers!

@jyapayne I've checked the permissions on the directory that I was writing to and everything looked okay there. I also tried writing to a dir in my documents folder. Still get the same error.

Yeah, I'm not sure about that...
It might be an issue with Yosemite, but I unfortunately don't have a system with that OS, nor the time to update right now.
I'm uploading a new binary, which may have an effect on this issue, so please download 0.1.17b when it appears in the readme.

Does this issue still persist? If so, please reopen the bug.


Checked the Schema.js and added a few changes

Changes noticed :
Double Declaration of dotenv
Database Connection Logic: You are connecting to MongoDB directly in index.js, which can be moved to db.js for clarity.
Schema Definition: You have the schema definitions inside index.js, which can be moved to schema.js.
Changes made:

Moved the Schemas: The user, product, and order schemas were initially defined directly in index.js. They have been moved to schema.js, making the index.js file cleaner and focused solely on application logic (setting up routes, middleware, and server).
Consolidated Route Imports: Made sure to import route modules for authentication, products, and orders to avoid defining them directly in the index.js.
Removed Duplicated Middleware Setup: The setup for express.json() and cors() was repeated; I've ensured it’s only called once.
Added more missing schemas to schema.js

detailed Schema.js updates

Added a schema for Offer (offerSchema) and its corresponding model (Offer).
Added a schema for Star Product (starProductSchema) and its corresponding model (StarProduct).
Modified the Hot Accessories schema (hotAccessoriesSchema) to accommodate the various accessory categories like music, smartDevice, home, etc., and created the corresponding model (HotAccessories).

Please let me know if there are any more changes to be incorporated!

@GLITCH-in-MATRIX9 great work!!
Happy Coding!

#156 resolved


Testing test refactor plus CI refactor

This PR is for testing purposes only - it is for testing whether/how the following two major PR work together:

the CI/CD refactor https://github.com/alan-turing-institute/sktime/pull/1620
the testing framework refactor https://github.com/alan-turing-institute/sktime/pull/1833

sth isn´t quite right here. I´m going to try this again.


Getting start in IBM Data Scientist Workbench

Brunel 1.2 is now supported in IBM Data Scientist Workbench.
Please provide a bit.ly url so that on clicking it, a usable example is available in user's own notebook. I don't know how it works, but that's how I'm getting all the demo samples. Here is an example, www.bit.ly/may2016python
Thanks.

Hello,
Can you clarify further what you would like to see.  When I click the link above it says the resource is no longer available.

Ops, try this instead http://bit.ly/svmlr, provided that you've already logged into the IBM Data Scientist Workbench.
What's exactly I want to see is just an example (say Clustered Bar Chart) as simple as possible to how to get Brunel work under IBM Data Scientist Workbench, because making it works is the hardest, and adopting and enhancing it will be much much easier.

That link still does not work for me.  I am logged in to DatascientWorkbench.

hmm... http://bit.ly/svmlr

OK.  I got it.
Try executing a cell like this:
import brunel
df = pd.read_csv("/resources/data/samples/olympic-medals/medals.csv")
%brunel data('df') x(Sport) y(#count) bar

This will work with a Python 2 or 3  notebook..   Essentially, Brunel is already installed and you just have to import it.  You may want to ask DatascieneWorkbench to include samples that uses Brunel or refer you to them.

oh, good. thanks,
Very strange that if I type "http://bit.ly/svmlr" into the url of my browser, will work, but clicking on it from github doesn't work. So please try typing (copy/paste) "http://bit.ly/svmlr" into you browser instead.

How was you able to create a folder structure as complicated as "/resources/data/samples/olympic-medals/medals.csv" on DatascieneWorkbench?
Can you share out your working sample url please? from DatascieneWorkbench there is an option under the notebook to share it...
Can you make that medals.csv available on the internet, say gist please?
Also, Can you make the  Clustered Bar Chart) .csv available on the internet as well please?

thanks

Here is what I did:

Followed the link you sent
This brought up a Jupyter notebook
I created a new cell in this notebook &  executed the above code.
The medals.csv data was already in there. They have a feature to the right to paste in the path of this data into the current cell.  I just clicked this & that path appeared.
US States.csv is here:  https://github.com/Brunel-Visualization/Brunel/blob/master/gallery/src/main/webapp/sample_data/US States.csv

Oh, thanks for the explanation, I got mine works as well now.
https://share.datascientistworkbench.com/jupyter/v1/<IP_ADDRESS>/ayTWEEkbvNSueoN/brunel-medals.ipynb
I've put into some comments, so as to make it easy for the next person.
Thanks again for your help!!

Hmm...
How can I make this works?
%brunel data('df') x(Sport,'Event gender') y(#count) bar

Use underscores when you have spaces in field names:
%brunel data('df') x(Sport,'Event_gender') y(#count) bar

oh, Thanks.
That didn't work, but this does:
%brunel data('df') x(Sport,Event_gender) y(#count) bar


Update UG DG PPP

Update UG DG PPP

Pull Request Test Coverage Report for Build 618

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.005%

Totals

Change from base Build 615:
0.0%

Covered Lines:
5445

Relevant Lines:
7164

💛  - Coveralls


Fix: Typo in metric name

:tada: This PR is included in version 0.23.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Link to Sierra stop after 7GB

I tried to download the box and all the time after some time it gets stop and I can't download more

Just downloaded with no issues. Maybe it's your network connection that is breaking up?


Maintenance Tunnel min distance between

Something to model is the min distance allowed between maintenance tunnels, maybe with a secondary circle that is a red line denoting the min distance?
Current min distance is 15m from another maintenance tunnel

Minimum distance between tunnels has changed in latest patch, 65m now