hub fork fails if fork (and remote) already exists

While attempting to replicate the issue I thought I was seeing for https://github.com/github/hub/issues/1411#issuecomment-311148349, I uncovered a teeny quirk with how hub fork behaves for existing forks.

If fork does not exist: hub fork creates the fork on github, adds the remote for the new fork, and fetches. Returns 0 status.

If fork exists but remote doesn't: hub fork adds the remote for the fork and fetches. Returns 0 status.

If fork exists and remote exists: hub fork errors out with fatal: remote jasonkarns already exists

Given that forking an already-forked repo safely adds the fork as a remote, I'd kinda expect the last scenario to just trigger a fetch. That is, I'd expect all three scenarios above to result in a local clone with:

named remote for the fork
remote recently fetched
successful return code

Right now, only the first two scenarios do this. (The third just needs to do a fetch and exit cleanly.)
I have a hard time describing the second scenario above (fork exists, but remote doesn't), but it's like a partially-idempotent command. If the third scenario were implemented as requested, the hub fork command would be fully idempotent.

What you're describing makes sense. I'd accept a PR that makes the command idempotent, since it's already half-idempotent.

It's odd that version 2.3.10 of hub behaves slightly differently than the release version. In this case, the pre-release version does not show an error message, but does exit with an error status.
# both fork and remote already exist

$ hub-2.3.10 fork
$ echo $?
128
$ hub-2.2.9 fork
fatal: remote e-beach already exists.
$ echo $?
128

The change in behavior occurs in d937d287037b9a24022e16337ea5e06ffdc726ab. It looks like the change to console file descriptors in that commit is somehow broken.

woot!, thanks @e-beach


Particular site does not work well with read it later but firefox reader view works

https://jrsinclair.com/articles/2022/whats-so-great-about-functional-programming-anyway/
When I have this link in the clipboard and choose read it later after pressing Ctrl-P a long vertical line of text is added to the right of the page

Closing due to inactivity.


Add blocking SinkActive|SinkInactive events

This kind of the same feature as PR #448, but in a blocking fashion. I'm putting it up for discussion as an alternative approach.
It addresses the issue mentioned in #406.
If activated, librespot emits events before the sink is opened and after it is closed. The events are blocking in the sense that the player waits for the handler to complete. This allows to write a handler that frees the sink before librespot attempts to open it.
From an API side, this is implemented as a callback. If a callback is registered, the player executes it blockingly.
From a binary side if --emit-sink-events is set, the usual --onevent script is used and librespot waits for the script's completion.
For simplicity, the events after closing are blocking, too. To make them non-blocking would require some more special handling to avoid race conditions if the sink is closed and opened in rapid succession.
The callback (and env variables) of the script convey three states: "running", "closed", "temporarily_closed". The latter is being used if the sink is temporarily closed between tracks while loading the next one. This allows the event handler to ignore such temporary closures.

I'll give this a whirl when I get access to my little players, thanks!

This PR has been sitting there for almost two months now. Just making sure it's not forgotten. From my side it's good to be merges.

LGTM


Fix setting zookeeper and servers in midolman.conf

There was no "else" so if the list of zookeepers or cassandras existed they would not be set.

Thanks @tbeckham !


Connection Tracking

Monitors all namespaces on network nodes, checks the number of flows against the
OS maximum, warning when close to exhaustion and fingering any significant flows
e.g. if 40% are outbound to SMTP you know you have a spammer to kill with maximum
prejudice.

Thank you for contributing to openstack/osops-tools-monitoring!
openstack/osops-tools-monitoring uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


BULK VALIDATION misc. issue fixes

Category

[x] Content fix
[ ] New article

Related issues
no issue number - part of the Validation clean-up efforts.
What's in this Pull Request?
The pull request fixes 36 issues across 25 files.

Docs Build status updates of commit 37aba0b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/schema/securitymodificationtype-simple-type-deploymentmanifest.md
:warning:Warning
View
Details

docs/schema/selected-type-definitions.md
:warning:Warning
View
Details

docs/schema/sequencenumber-element-event.md
:warning:Warning
View
Details

docs/schema/serializablesecurablenamevaluepairs-element-securableauthdata-complextypesps15xs.md
:warning:Warning
View
Details

docs/schema/settingspage-element-propertiesdefinition-complextypesharepoint-add-in-manifest.md
:warning:Warning
View
Details

docs/schema/sharepoint-add-in-schemas.md
:warning:Warning
View
Details

docs/schema/sharepoint-features-schemas.md
:warning:Warning
View
Details

docs/schema/similartype-element-sps15xsdsearchset5.md
:warning:Warning
View
Details

docs/schema/similartype-simpletype-sps15xsdsearchset5.md
:warning:Warning
View
Details

docs/schema/simplepropertydefinition-complextype-apphostwebfeatures.md
:warning:Warning
View
Details

docs/schema/site-definition-onet-xml-files.md
:warning:Warning
View
Details

docs/schema/site-deletion-confirmation-schema.md
:warning:Warning
View
Details

docs/schema/site-element-deploymentmanifest.md
:warning:Warning
View
Details

docs/schema/site-schema-elements-a-l.md
:warning:Warning
View
Details

docs/schema/site-schema-elements-m-z.md
:warning:Warning
View
Details

docs/schema/solutiondefinition-element-solutionmanifestdefinitions-schema.md
:warning:Warning
View
Details

docs/schema/solutionid-element-event.md
:warning:Warning
View
Details

docs/schema/solutionmanifestdeclarativeextensions-schema.md
:warning:Warning
View
Details

docs/schema/solutionmanifestdefinitions-schema.md
:warning:Warning
View
Details

docs/schema/solutionsettings-element-in-solutiondefinition-solutionmanifestdefinitions-schem.md
:warning:Warning
View
Details

docs/schema/sortable-element-managedpropertyinfo-complextypesps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/sortabletype-element-managedpropertyinfo-complextypesps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/sortabletype-element-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/sortabletype-simpletype-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/site-schema.md
:white_check_mark:Succeeded
View

docs/schema/securitymodificationtype-simple-type-deploymentmanifest.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/selected-type-definitions.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/sequencenumber-element-event.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/serializablesecurablenamevaluepairs-element-securableauthdata-complextypesps15xs.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/settingspage-element-propertiesdefinition-complextypesharepoint-add-in-manifest.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/sharepoint-add-in-schemas.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/sharepoint-features-schemas.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/similartype-element-sps15xsdsearchset5.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/similartype-simpletype-sps15xsdsearchset5.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/simplepropertydefinition-complextype-apphostwebfeatures.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/site-definition-onet-xml-files.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/site-deletion-confirmation-schema.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/site-element-deploymentmanifest.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/site-schema-elements-a-l.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/site-schema-elements-m-z.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/solutiondefinition-element-solutionmanifestdefinitions-schema.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/solutionid-element-event.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/solutionmanifestdeclarativeextensions-schema.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/solutionmanifestdefinitions-schema.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/solutionsettings-element-in-solutiondefinition-solutionmanifestdefinitions-schem.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/sortable-element-managedpropertyinfo-complextypesps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/sortabletype-element-managedpropertyinfo-complextypesps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/sortabletype-element-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/sortabletype-simpletype-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!


Added FlatMapper

Misc/FlatMapper - https://github.com/kappy/FlatMapper
FlatMapper is a library to import and export data from and to plain text files in a Linq compatible way.

@kappy Thanks.


PLAT-77054: Change components to allow disabled components to be focusable

Enact-DCO-1.0-Signed-off-by: Roy Sutton<EMAIL_ADDRESS>Checklist

[x] I have read and understand the contribution guide

[x] A CHANGELOG entry is included

[ ] At least one test case is included for this feature or bug fix

[x] Documentation was added or is not needed

[ ] This is an API breaking change

Issue Resolved / Feature Added
Resolution
Additional Considerations
Links
Comments

Few visual notes from sampler:

Input - Field is white with full opacity
ExpandableList/DatePicker/TimePicker - LabeledItem doesn't change
MediaOverlay - Focus ring appears to be full opacity

@ryanjduffy would you mind re-verifying that "ExpandableList/DatePicker/TimePicker - LabeledItem doesn't change"? I just checked again on my machine and it appears to be behaving correctly with yesterday's set of commits.

This is what I see with the latest. It shows the focused+disabled state okay but disabled+unfocused is the same as enabled+unfocused.

Ah! Focused+notDisabled. Thanks for clarifying! I'll get that sorted out too.

One more visual note: FormCheckbox's text becomes white when focused but it doesn't change when disabled and focused which is inconsistent with other components that still change color but are "muted" by the opacity change.

The above (previous 3) concerns were addressed, and a new knob was added to the MediaOverlay story.
I don't have a good answer for the FormCheckboxItem scenario. The white focus text is a recent change, and we've not received complete designs on exactly how those colors should be handled in every situation (like when it's disabled).
Several visual changes to FormCheckbox and Checkbox may be changing back to the 2.x style, which may affect this issue.
What do you want to do?

My opinion is to be consistent in the absence of specific designs but I will support whatever decision you make.

Also, please update the description of the PR to describe the changes.

I was not able to observe the VirtualList disabled 5-way navigation issue.  It seems like it's up to the app to pass in a isItemDisabled() function so it's possible the app you were testing supplied this.  I updated the joined pickers and the PR description.

I should have been more clear. You're right that the app must provide that function but I don't think the function should be supported since its purpose was to assist in focus management.

Hmm...  I guess we could still supply it for a spotlightDisabled sort of thing...  but...  I can remove it.

Removed.


Minor fix for cookbook

Fix for #3593.
@karlnapf It fixes the warning you suggested. Sorry for the late edit, it just slipped out of my mind.

Commit message: "Clean up markdown header"
"Minor fix for notebook" is not a good commit message. These should always tell you what has been done and maybe why

Super minor comment, but keep in mind for next time

Yeah. I'll keep that in mind.


[BUG] workload ownerReference field lost because rollout failed

Describe the bug
workload ownerReference field lost because rollout failed
To Reproduce

kubectl create ns rollout-trait-test
kubectl create -f application.yaml
kubectl apply -f application-v2.yaml

yaml file as follow:
# application.yaml
apiVersion: core.oam.dev/v1beta1
kind: Application
metadata:
  name: rollout-trait-test
  namespace: rollout-trait-test
spec:
  components:
    - name: express-server
      type: webservice
      properties:
        image: stefanprodan/podinfo:4.0.3
      traits:
        - type: rollout
          properties:
            targetSize: 5
            rolloutBatches:
              - replicas: 2
              - replicas: 3

# application-v2.yaml
apiVersion: core.oam.dev/v1beta1
kind: Application
metadata:
  name: rollout-trait-test
  namespace: rollout-trait-test
spec:
  components:
    - name: express-server
      type: webservice
      properties:
        image: stefanprodan/podinfo:4.0.3
        cpu: "0.2"
      traits:
        - type: rollout
          properties:
            targetSize: 5
            rolloutBatches:
              - replicas: 5
              - replicas: 0

and then will see rollout failed:
[root@vela app-upgrade]# kubectl get rollout
NAME      TARGET   UPGRADED   READY   BATCH-STATE         ROLLING-STATE   AGE
testapp   3        0          0       batchInitializing   rolloutFailed   12m

use kubectl get deploy -n rollout-trait-test -oyaml | grep ownerRef cannot get anything
Expected behavior
best expectation: generate 5 pod of v2 application.
even if rollout failed, ownerReference should not lost in workload, it will cannot be managed by app.
KubeVela Version
[root@vela app-upgrade]# helm list -n vela-system
NAME    	NAMESPACE  	REVISION	UPDATED                                	STATUS  	CHART          	APP VERSION
kubevela	vela-system	1       	2021-08-24 06:42:25.162278935 -0400 EDT	deployed	vela-core-1.1.0	1.1.0

Cluster information
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-12T14:18:45Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.15", GitCommit:"73dd5c840662bb066a146d0871216333181f4b64", GitTreeState:"clean", BuildDate:"2021-01-13T13:14:05Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}
WARNING: version difference between client (1.21) and server (1.18) exceeds the supported minor version skew of +/-1

Will fix, when rollout failed add ownerRef back.

in this case, old resourcetracker has already deleted, what resource should be used as the owner of "orphan" resources.
it seems that using rollout is not good.

The latest resourceTracker is fine.

The latest resourceTracker is fine.

in this case, old resourcetracker has already deleted, what resource should be used as the owner of "orphan" resources.
it seems that using rollout is not good.

I think the newest resourceTracker is fine


Unsupported handler extension for module

In serverless.yml (excerpt for brevity)
plugins:
  - serverless-middleware

custom:
  middleware:
    pre:
      - auth/authorize.handler

In auth/authorize.js
module.exports.handler = async (event, context) => {
  try {
    // authorization happens here
  } catch (e) {
    // error handling
  }
}

When I run sls deploy or sls package, I get "Unsupported handler extension for module ./auth/authorize. Only .js, .jsx, .ts and .tsx are supported"
This happened after upgrading to SLS 4 and serverless-middleware 3.3.0

What version were you using before that worked?
Are you sure that the file path is valid?
The error message indicates that there is no file namy in that location with one of the supported extensions.
Maybe you can you create a project to reproduce the issue?

I now found out that this happens when used in combination with serverless-compose; where I'd run sls deploy from a parent folder for multiple subfolders - each with their own serverless.yml


Update bundle, cloudwatch, sdk-core, ses, sns, ... to 2.29.41

About this PR
📦 Updates

software.amazon.awssdk:bundle
software.amazon.awssdk:cloudwatch
software.amazon.awssdk:sdk-core
software.amazon.awssdk:ses
software.amazon.awssdk:sns
software.amazon.awssdk:sqs
software.amazon.awssdk:ssm

from 2.29.39 to 2.29.41
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #3502.


Discussion Posts List Screen Accessibility

Description
MA-2799
Add a description of your changes here.
Notes
How to test this PR
Reviewers
If you've been tagged for review, please "Start a review" with the Github GUI.

 Last update db19dc2...10353d3

Are we using the image in the ticket as the guide?
The all posts filter does not read as "Show ..." and the other filter doesn't read as "Sort by ..."
Replies are read back twice. Once for the number on the right, and again for the subtext of the post.  The number on the right is not being read back as described in the ticket in the image. Instead of "99+ unread replies" it reads "99 replies".
Items are not being read as expected. It could be an ordering issue but when going over a thread, let's say an unread discussion, it will said "discussion" instead of "unread discussion".

@saeedbashir Done with pass.
It seems like fixing the order of which the icons and text are read are out of scope. The only thing I would fix is to better label the filters.
Something like:
"Filter by All Posts/Unread/Unanswered"
"Sort by Recent Activity/Most Activity/Most Votes"

@BenjiLee @danialzahid94 Ready for another pass. @BenjiLee I have also corrected ordering of voice over elements. Please let me know if I missed something.

Does not announce if a question/discussion is unread or read.

@BenjiLee New change commented on wiki


add fossa step

Description
adds fossa to the ci
Related Issue

Fixes OCIS-2401

Motivation and Context
have insights on dependencies and their licenses
How Has This Been Tested?

CI

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

closed in favor of https://github.com/owncloud/ocis/pull/3408


Download images alongside site files

Not ready to merge yet - right now it downloads images in the page sections and swaps out their URLs with the relative image url.


Mob filter not working in 1.20.1?

Hi there, I'm really not sure what to do, I set up the Filter, like I thought I should, but it seems everything is still spawning just like before. Is there something I missed about the syntax? I also don't seem to be getting any extra output, although I set the loglevel to TRACE, so no idea how to troubleshoot this at the moment.
This is my current mobfilter.yaml, I'm basically trying to disable every vanilla minecraft mob, except for the ender dragon and warden (I think):
#
# SAMPLE CONFIGURATION - uncomment and edit
#

 rules:

  - name: No Creepers Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:creeper]

  - name: No Allay Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:allay]

  - name: No Axolotl Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:axolotl]

  - name: No Bats Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:bat]

  - name: No Bees Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:bee]

  - name: No Blazes Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:blaze]

  - name: No Camels Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:camel]

  - name: No Cats Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:cat]

  - name: No Cave Spiders Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:cave_spider]

  - name: No Chickens Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:chicken]

  - name: No Cod Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:cod]

  - name: No Cows Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:cow]

  - name: No Dolphins Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:dolphin]

  - name: No Donkeys Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:donkey]

  - name: No Drowned Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:drowned]

  - name: No Elder Guardians Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:elder_guardian]

  - name: No Enderman Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:enderman]

  - name: No Endermite Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:endermite]

  - name: No Evoker Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:evoker]

  - name: No Foxes Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:fox]

  - name: No Frogs Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:frog]

  - name: No Ghasts Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:ghast]

  - name: No Giants Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:giant]

  - name: No Glow Squid Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:glow_squid]

  - name: No Goats Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:goat]

  - name: No Guardian Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:guardian]

  - name: No Hoglins Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:hoglin]

  - name: No Horses Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:horse]

  - name: No Husks Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:husk]

  - name: No Illusioner Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:illusioner]

  - name: No Llamas Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:llama]

  - name: No Magma Cubes Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:magma_cube]

  - name: No Mooshrooms Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:mooshroom]

  - name: No Mules Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:mule]

  - name: No Ocelots Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:ocelot]

  - name: No Pandas Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:panda]

  - name: No Parrots Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:parrot]

  - name: No Phantoms Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:phantom]

  - name: No Pigs Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:pig]

  - name: No Polar Bears Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:polar_bear]

  - name: No Pufferfish Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:pufferfish]

  - name: No Rabbits Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:rabbit]

  - name: No Ravagers Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:ravager]

  - name: No Salmon Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:salmon]

  - name: No Sheep Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:sheep]

  - name: No Silverfish Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:silverfish]

  - name: No Skeleton Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:skeleton]

  - name: No Skeleton Horses Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:skeleton_horse]

  - name: No Slimes Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:slime]

  - name: No Sniffers Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:sniffer]

  - name: No Spiders Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:spider]

  - name: No Squids Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:squid]

  - name: No Strays Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:stray]

  - name: No Striders Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:strider]

  - name: No Tadpoles Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:tadpole]

  - name: No Trader Llamas Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:trader_llama]

  - name: No Tropical Fish Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:tropical_fish]

  - name: No Turtles Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:turtle]

  - name: No Vexes Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:vex]

  - name: No Vindicators Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:vindicator]

  - name: No Witches Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:witch]

  - name: No Wither Skeletons Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:wither_skeleton]

  - name: No Wolves Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:wolf]

  - name: No Zoglins Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:zoglin]

  - name: No Zombies Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:zombie]

  - name: No Zombie Horses Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:zombie_horse]

  - name: No Zombie Villagers Ever
    what: DISALLOW_SPAWN
    when:
      entityId : [minecraft:zombie_villager]

#
# DOCUMENTATION
#

#
# The top-level 'rules' configuration element contains a list of filtering rules that are checked to see whether
# a new mob should be allowed to spawn.
#
#
# Each rule has three keys:
#     name - A human-readable name for the rule, useful for documentation and debugging.
#     what - Indicates what to do when the rule matches.  Must be DISALLOW_SPAWN or ALLOW_SPAWN.
#     when - A list of conditions that must be true in order for the rule to match.
#
# The 'when' section provides a set of conditions that must all be true in order for the rule to be a match.
# It may contain any of the following keys:
#
# spawnGroup
#     List of net.minecraft.entity.SpawnGroup values, such as MONSTER or CREATURE.  The condition is true when
#     the mob to be spawned is in one of the listed groups.
#
# entityId
#     List of entity ids, e.g. 'minecraft:zombie'.  The condition is true when the id of the mob to be spawned is
#     in the list.
#
# blockX
# blockY
# blockZ
#    List of two integers specifying a range.  True when the mob's spawning position on the given axis (X, Y or Z)
#    is within the provided range.  'MIN' may be used for the first value and 'MAX' may be used for the second.
#
# worldName
#     List of world names, e.g., 'My World'.  True if mob is spawning in a listed world.  Useful if you need
#     to limit mob filtering to specific worlds.
#
# dimensionId
#     List of dimension identifiers, e.g., 'minecraft:overworld'.  True if mob is spawning in a listed dimension.
#
# biomeId
#     List of biome identifiers, e.g., 'minecraft:ocean'.  True if mob is spawning in a listed biome.
#
# blockId
#     List of block identifiers, e.g., 'minecraft:cobblestone'.  True if mob is spawning on a listed block type.
#
# lightLevel
#     Two integers between 0 and 16.  True if mob is spawning in a lightLevel within the range.
#
# timeOfDay
#     Two integers between 0 and 24000.  True if mob is spawning at a timeOfDay within the range.
#

#
# NOTES
#
# Filter rules are processed in order and processing stops as soon as a matching rule is found.  This means you can
# put blanket exclusions at the top of your rules list, e.g.,
#
# rules:
#  - name: Always do normal spawning in Nether and End
#    what: ALLOW_SPAWN
#    when:
#      dimensionId: ['minecraft:nether', 'minecreate:the_end']
#
# ...more rules
#

#
# logLevel
#     This sets log4j logging level for the mod.  Set to 'DEBUG' to log each time a spawn is disallowed.
#     Set to 'TRACE' to see detailed logging on rule evaluation.  Be careful - this can quickly fill up your logfiles.

logLevel: TRACE

But I still see quids, rabbits, creepers and all sorts of stuff spawning on my server... Thanks in advance for the help

I realized my syntax was not exactly right, once I fixed that it seems to work now ^^*


DOM is not updated when shallow array is modified

Version
3.0.0-alpha.12
Reproduction link
https://jsfiddle.net/xjuamt5y/4/
Steps to reproduce

Open the reproduction case.
Open console
Click anywhere in the rendered part

You should see message "Adding to array"
What is expected?
To re-render the DOM with values from Array
What is actually happening?
Nothing is updated.

When I add another ref there and modify the ref, it will re-render whole DOM with proper values.
Used shallowRef because of https://github.com/vuejs/vue-next/issues/962

Comment
Even when shallowRef is not making value reactive, what should be the proper way to update array of components?

In the reproduction case there is structure with comp and id. That makes sense why it is not updated. (realized after opening the issue) But if we cannot use ref on component. What should be proper way to update: Array?

A shallowRef only tracks mutation of its own .value property. Mutating the array inside won't be reactive. If you want to track the mutation of the array you should be using shallowReactive([])


Class 'Vitalybaev\LaravelDkim' not found

Hi,
I've added provider into config/app.php, however still get Class 'Vitalybaev\LaravelDkim' not found error.
laravel 5.6
Thanks

When this message appear you must go to :
bootstrap/cache/services.php and update the provider array like:
'providers' =>
array (
01 => 'Vitalybaev\LaravelDkim\DkimMailServiceProvider',
I believe that the class is not caching

Thanks guys


A bug of Rasch Model-Based Embeddings, Please check it!

In line 83 of akt.py, the shape of qa_data is [BS, seqlen, 2], but in line 42,
self.qa_embed_diff = nn.Embedding(2 * self.n_question + 1, embed_l), the embedding input dims is inconsistent, is this right?
Please check it! Thanks!

Hi, I think, if self.separate_qa=True, qa_data shape is [BS, Seqlen] (line 72) with value from 0 to 2*n_question+1 (line 45) and self.qa_embed_diff = nn.Embedding(2 * self.n_question + 1, embed_l). When self.separate_qa=False, qa_data shape is [BS, Seqlen] (line 76) with value from 0 to 1 (line 48) and self.qa_embed_diff = nn.Embedding(2 * self.n_question + 1, embed_l).

When self.separate_qa=False, qa_data shape is [BS, Seqlen] (line 76) with value from 0 to 1 (line 48) and self.qa_embed = nn.Embedding(2, embed_l). But, if self.n_pid > 0, (line 83) qa_embed_diff_data = self.qa_embed_diff(qa_data), and (line 42) self.qa_embed_diff = nn.Embedding(2 * self.n_question + 1, embed_l), the shape of qa_data is inconsistent with "2 * self.n_question + 1".
Please check it again! Thanks!

When self.separate_qa=False, qa_data shape is [BS, Seqlen] (line 76) with value from 0 to 1 (line 48) and self.qa_embed = nn.Embedding(2, embed_l).
But, if self.n_pid > 0, (line 83) qa_embed_diff_data = self.qa_embed_diff(qa_data), and (line 42) self.qa_embed_diff = nn.Embedding(2 * self.n_question + 1, embed_l), the shape of qa_data is inconsistent with "2 * self.n_question + 1".
Please check it again! Thanks!
来自 Outlookhttp://aka.ms/weboutlook

发件人: Aritra Ghosh @.>
发送时间: 2021年12月2日 18:06
收件人: arghosh/AKT @.>
抄送: ICDATwang @.>; Author @.>
主题: Re: [arghosh/AKT] A bug of Rasch Model-Based Embeddings, Please check it! (Issue #8)
Hi, I think, if self.separate_qa=True, qa_data shape is [BS, Seqlen] (line 72) with value from 0 to 2*n_question+1 (line 45) and self.qa_embed_diff = nn.Embedding(2 * self.n_question + 1, embed_l). When self.separate_qa=False, qa_data shape is [BS, Seqlen] (line 76) with value from 0 to 1 (line 48) and self.qa_embed_diff = nn.Embedding(2 * self.n_question + 1, embed_l).
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/arghosh/AKT/issues/8#issuecomment-985153883, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJ4VC2CUZKI4ZOPGOGBONLLUPAQ3XANCNFSM5I6TLW3A.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Yes, you are right. only 0 and 1 is used, rest of them are not updated. You can change line 42 depending on the condition. It would be the same.


Support for GHC 8.6.1

Hi,
Any plans for supporting GHC 8.6.1?

#580 has been sitting in the pull-requests for some time.
You can use this in your stack.yaml to use it now:
extra-deps:
...
- git: https://github.com/janpath/intero.git
  commit: c32d87a170495d106744c3f7275a9d24ed0e3e42

@janpath thank you for the link to PR. For some reason I totally missed it.

Ping.. I see there were a bunch of releases early in the year but none since. Might there be a release soon to make intero usable with GHC 8.6-based projects ?

#580 has been landed in 0.1.34, @d12frosted please test

intero-0.1.34 installed fine with GHC 8.6.1 here. Thanks!

@develop7 thank you! I will take a look.

There is a test suite failure that looks trivial:
Failures:

  src/test/Main.hs:71:15:
  1) Basics :i Nothing
       expected: "data Maybe a = Nothing | ... \t-- Defined in \8216GHC.Base\8217\n"
        but got: "data Maybe a = Nothing | ... \t-- Defined in \8216GHC.Maybe\8217\n"

  To rerun use: --match "/Basics/:i Nothing/"

Randomized with seed<PHONE_NUMBER>

Finished in 24.9978 seconds
44 examples, 1 failure, 1 pending

https://github.com/commercialhaskell/intero/blob/4be2a4a5de81bae504654a6b3a5d8a340be00e7e/src/test/Main.hs#L73
I guess the location that Nothing is defined in changed with ghc 8.6.


Update to include datastoreusage grpc command

In the lightning repository a new grpc command was added.
This update makes it accessible in Greenlight

ACK https://github.com/Blockstream/greenlight/pull/306/commits/067f1297000e474252d5e6b3ccca296be0983449


WAGTAILADMIN_BASE_URL should be mentioned in "Integrating Wagtail" docs

Pertinent section of the Wagtail docs
The documentation on WAGTAILADMIN_BASE_URL says (emphasis mine):

This is the base URL used by the Wagtail admin site. It is typically used for generating URLs to include in notification emails.
If this setting is not present, Wagtail will try to fall back to request.site.root_url or to the request’s host name.

Yet if you do not configure it, Wagtail will issue a warning:
(wagtailadmin.W003) The WAGTAILADMIN_BASE_URL setting is not defined
https://github.com/wagtail/wagtail/blob/801eccc9304561ffe974b6e16bd977198910726d/wagtail/admin/checks.py#L175-L183
In addition, the "Settings" section of "Integrating Wagtail into a Django project", doesn't mention this setting.
Details
IfWAGTAILADMIN_BASE_URL should always be configured, then the docs should reflect this.

I ran into this on a multi-site Wagtail installation. Hadn't configured the base url before as there isn't a central wagtail url for all site, so I just picked one.

I don't think there's a contradiction here: the setting is not strictly required, but highly recommended because leaving it out is liable to produce unusable URLs in notification emails, in certain server configurations. Therefore, there's a warning, but not a hard error, and the documentation doesn't state that it's required.
I agree it should be mentioned in the "Integrating Wagtail" docs, though.

I am planning to work on this issue, my solution is that I will add the following lines into the 'Settings' section of 'integrating_into_django.md' file :
Add a WAGTAILADMIN_BASE_URL - This is the base URL used by the Wagtail admin site. It is typically used for generating URLs to include in notification emails :
WAGTAIL_SITE_NAME = 'My Example Site'

If this setting is not present, Wagtail will try to fall back to request.site.root_url or to the hostname of the request. Although this setting is not strictly required, it is highly recommended because leaving it out will produce unusable URLs in notification emails in certain server configurations and you will get this warning  :
The WAGTAILADMIN_BASE_URL setting is not defined


Add Enzyme deprecation linter

Before merging 156 occurences

Current status 121 matches

Current status 52 matches

34 offending lines

31 offending lines

23 offending lines

Just 4 offending lines left!

Enzyme is gone!


Invalid regex pattern of alb

ALB access logs have been ingesting into opensearch using the es-loader function for a while now. This morning they appear to have completely stopped due to a mismatch on the regex pattern.
I'm seeing this in the logs:
{
    "level": "ERROR",
    "message": "Invalid regex pattern of alb",
    "location": "convert_lograw_to_dict:70",
    "timestamp": "2023-10-06 14:05:08,603+0000",
    "service": "es-loader",
    "cold_start": false,
    "function_name": "aes-siem-es-loader",
    "function_memory_size": "2048",
    "function_arn": "arn:aws:lambda:us-east-1:<os_account_number>:function:aes-siem-es-loader",
    "function_request_id": "97134df9-54e7-4b06-9299-70843577211f",
    "s3_key": "AWSLogs/<lb_account_number>/elasticloadbalancing/us-east-1/2023/10/06/<lb_account_number>_elasticloadbalancing_us-east-1_app.<application_name>-load-balancer.70da16283c7eda86_20231006T1405Z_<IP_ADDRESS>_4bpu49ue.log.gz",
    "s3_bucket": "aes-siem-<os_account_number>-log",
    "message_rawdata": "https 2023-10-06T14:00:59.248747Z app/<application_name>-load-balancer/70da16283c7eda86 <IP_ADDRESS>:52200 <IP_ADDRESS>:80 0.000 0.008 0.000 200 200 42 5649 \"GET https://<IP_ADDRESS>:443/ HTTP/1.1\" \"-\" TLS_AES_128_GCM_SHA256 TLSv1.3 arn:aws:elasticloadbalancing:us-east-1:<lb_account_number>:targetgroup/<application_name>-group/628c165c575e7a7e \"Root=1-6520131b-540d1be4066ae74f1bbcb40a\" \"-\" \"arn:aws:acm:us-east-1:<lb_account_number>:certificate/7d5f2b2a-f6aa-4b3e-a924-ffa443662c60\" 0 2023-10-06T14:00:59.240000Z \"forward\" \"-\" \"-\" \"<IP_ADDRESS>:80\" \"200\" \"-\" \"-\"",
    "message_regex_pattern": "re.compile('(?P<request_type>[^ ]*) (?P<timestamp>[^ ]*) (?P<elb>[^ ]*) (?P<client_ip>[^ ]*):(?P<client_port>[0-9]*) (?P<target_ip>[^ ]*)[:-](?P<target_port>[0-9]*) (?P<request_processing_time>[-.0-9]*) (?P<targ)",
    "xray_trace_id": "1-65201414-1239605b5038d22a3bfe456e"
}

Any guidance you can give would be greatly appreciated!

it appears a rouge agent (a team member) disconnected this ALB from the logs bucket, which is why we suddenly had zero logs. So it seems a majority of the ELB logs are being ingested, however some are still facing this issue. I'm curious of the cause, but the main issue of NO logs at all has been solved 🤣

What SIEM version are you using?

ssl_cipher of logs seems changed
your sample log: ssl_cipher uses underscores
TLS_AES_128_GCM_SHA256 TLSv1.3

On the other hand, the sample log in the official documentation uses dashes.

https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-access-logs.html

workaround: Edit part of log_pattern in the [alb] section of aws.ini
Modification place
From:
(?P<ssl_cipher>[()A-Z0-9-]+)

To:
(?P<ssl_cipher>[()A-Z0-9-_]+)

https://github.com/aws-samples/siem-on-amazon-opensearch-service/blob/v2.10.2/source/lambda/es_loader/aws.ini#L801

Or please update SIEM version to v2.10.2a

Thanks so much for spotting that @nakajiak! It looks like in typical aws fashion, three of the TLS ciphers user underscores rather than dashes.
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/create-https-listener.html

I didn't know the three TLS ciphers. Thanks so much.


Typos and Rule 3.5 fixes

@OlegDokuka Please add yourself in the CopyrightWaivers.txt in this PR.

@viktorklang we should ensure that all Reactive Libs vendors are aware of those changes in the spec since the current implementation of libraries implemented differently and all external synchronization is done within Subscription itself.

@OlegDokuka The changes are not changes in semantics, only clarification of message/expectations.

@viktorklang I reread the description of serial(ly) again and looks like I misunderstood it a little bit. I rolled back notion thread-safe because it is needed in 3.5 and states that internals of cancel method should be thread-safe (which is separate from serial)

closes in favour of #449


Remove paged response wrappers

Move the three static inner classes from PagedResponseWrappers into their own separate public class files, and remove PagedResponseWrappers wrapping class.

Codecov Report

Merging #1833 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1833      +/-   ##
============================================
- Coverage      84.7%   84.66%   -0.05%
+ Complexity     4584     4576       -8
============================================
  Files           438      438
  Lines         18200    18218      +18
  Branches       1922     1922
============================================
+ Hits          15417    15424       +7
- Misses         2119     2131      +12
+ Partials        664      663       -1

Impacted Files
Coverage Δ
Complexity Δ

...m/google/api/codegen/transformer/SurfaceNamer.java
73.97% <ø> (-0.07%)
205 <0> (-1)

...api/codegen/transformer/java/JavaSurfaceNamer.java
82.41% <100%> (+0.19%)
41 <0> (ø)
:arrow_down:

...gen/viewmodel/StaticLangPagedResponseFileView.java
100% <100%> (ø)
3 <2> (?)

...degen/transformer/java/JavaSurfaceTransformer.java
97.91% <100%> (+0.06%)
72 <1> (+1)
:arrow_up:

...in/java/com/google/api/codegen/util/TypeAlias.java
87.5% <0%> (-12.5%)
7% <0%> (-1%)

...i/codegen/transformer/SchemaTypeFormatterImpl.java
27.77% <0%> (-5.56%)
3% <0%> (-1%)

...ain/java/com/google/api/codegen/util/TypeName.java
94.87% <0%> (-5.13%)
14% <0%> (-1%)

...pi/codegen/transformer/ModelTypeFormatterImpl.java
52.17% <0%> (-4.35%)
8% <0%> (-1%)

...om/google/api/codegen/util/java/JavaTypeTable.java
92.59% <0%> (-3.71%)
30% <0%> (-1%)

...google/api/codegen/transformer/ModelTypeTable.java
84.74% <0%> (-3.39%)
37% <0%> (-2%)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9976a...33b1d74. Read the comment docs.

This will still cause a name clash. I think we need to move the paged response classes to the individual client classes that they apply to.

PTAL
See https://github.com/googleapis/gax-java/pull/471 for the resulting generated LRO API.


updates buildkit to 0.12 in builder-base

Issue #, if available:
Description of changes:
We are a bit behind here. After this builds, we can test in eks-a first.
I will also make prow job PRs.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


Explanation is overdone

Dear Mendix Education,
It seems Mendix has the intention that every section of the Mendix documentation "how to's" should be executable by newbies, even for the advanced topics.  As a result the "how-to's" feel really overdone and don't come to the point quickly.
Nor it does really teach, the overall feels like a click-through with describing every little step (like explicitly stating how to add a new action to a microflow). Maybe it is targeted to newbies to give them the feeling they can achieve something quickly with Mendix?
The issue is that in general Mendix explanations become over-detailed, missing the real grab on the matter. When e.g. explaining  REST services one could assume the developer knows how to add a microflow, add a parameter to this microflow, add an action, etc ... this should not be needed to describe again and again if someone decided to work with REST services in the first place?
Maybe Mendix could consider a 'Newbies section' with step-by-step overviews and have a regular section where it is assumed a basis Mendix knowledge is present and more attention can be given to more advanced topics related to the matter,
Regards

Thanks @tvzanten for the feedback and ideas. We have these factors in mind and are planning review, updates, and overhaul of the how-to's. I have transferred your feedback to our backlog and we will examine it moving forward with this how-to work. Cheers.


Reaper warning message: S&M warning - no slot added to [path] empty directory

Hi,
I've just installed the plugin on my Windows 10 WS, and when from Reaper I open the Extensions -> resources menu, select the FXchain and click the first icon on the left inside the resources windows I get the following message:
No slot added from [the FWChains path on my WS, which is the defalut one]. Probable cause: all files are already present, empty directory, directory not fount.
In my case il the REAPER/FXChains direcotry which is empty.
How can i solve this one?
Thank you in advance for your help.

Hi,

Probable cause: all files are already present, empty directory, directory not fount.
In my case il the REAPER/FXChains direcotry which is empty.

This sounds like you haven't actually created (saved) any FX chains from within Reaper so the Resources window can't find any it can add (as the message is saying).
Try first saving an FX chain to default location, then click the first icon again.
!(https://i.imgur.com/6PrHUBx.jpg)
As this issue seems more like a 'how to' question than a feature request or bug report (what this issue tracker is intended for) I'm closing it (for now) and suggest to post for further help in the Reaper forum.
(If you think this is actually a bug please get back and we can reopen it.)


Dynamic tensors; TensorContainer refactor

Checklist

[ ] Confirmed that run-checks all script has been executed.
[ ] Made sure the book is up to date with changes in this PR.

Related Issues/PRs
I don't know of any related issues or PRs.
Changes
TensorContainer is a bit of a mess. It's code needs a refactor, and it's current design prevents some important things, such as deserializing and serializing it, which is needed for many applications, such as passing GradientsParams over the wire.
To do this refactor, this PR introduces DynRankTensor, as a foundational type for tensors with a rank not known at compile time, and implements the basic framework for this type to work. Its API is still subject to changes, according to the Burn norms.
In addition, some other code is refactored, and DataSerialize is renamed DynRankData.
Issues and todos

TensorContainer in the current PR can only store float tensors, as before. This should ideally change and be addressed in this PR, after discussion on the best solution.
I haven't implemented DynRankTensor on any backend yet, as I'm still unfamiliar with them, and as some backends, such as WGPU, are actively changing.
Some of the code might not be consistent with other Burn code, due to my inexperience.
This PR doesn't include tests yet, and no tests were yet made. This PR was mainly opened to instigate discussion.

Testing
See above.

Yeah, solving this issue was a main cause for the opening of this PR. I think the second solution is ultimately the better of the two. It would reduce code and allow us to rename the types to be DynX instead of DynRankX.
Unrelatedly, is there a good way to make changes in Gradients without having to refactor a bunch of 1kLOC files?
Finally, what should we do about the unary_different_backend function, from the autodiff module?

Yeah, solving this issue was a main cause for the opening of this PR. I think the second solution is ultimately the better of the two. It would reduce code and allow us to rename the types to be DynX instead of DynRankX.
Unrelatedly, is there a good way to make changes in Gradients without having to refactor a bunch of 1kLOC files?
Finally, what should we do about the unary_different_backend function, from the autodiff module?

For the Gradients struct in burn-autodiff, I'm unsure.
The trivial case is that the generic argument should be in the struct definition instead of in each function.
pub struct Gradients<B: AutodiffBackend> {
    container: TensorContainer<GradID, B::InnerBackend> // contains tensors of the inner backends.
}

But this doesn't work with mixed precision training where full precision tensors don't have the same backend as the normal half precision tensors.
The way we could solve this is by enforcing that the DynTensor is the same type for all backend types:
trait Backend {
    /// Current type
    type FullPrecisionBackend: Backend<FloatElem = Self::FullPrecisionElem, Device = Self::Device>;
    /// Updated type
    type FullPrecisionBackend: Backend<FloatElem = Self::FullPrecisionElem, Device = Self::Device, DynTensor = Self::DynTensor>;
}

Then the tensor container could be generic over the DynTensor type and not the backend, since multiple backends can read and write to the same container.
It also allows keeping the same signature as of now for each function; however, we can add a new trait bound:
impl<ID, TensorType> TensorContainer<ID, TensorType> {
    pub fn get<B, const D: usize>(&self, id: &ID) -> Option<Tensor<B, D>>
    where
        B: Backend<DynTensor = TensorType>,
    {
        // ...
    }
}

So for the unary_different_backend, it would be pretty much unchanged from my understanding.

I think enforcing this constraint is a good solution, and yeah, this seems to work. I'm going to work on implementing this.

Should I implement dynamic tensors for the JIT backend? Or is it still not ready?

Should I implement dynamic tensors for the JIT backend? Or is it still not ready?

I think the current JitFusionHandle is probably what is needed, but we should move it out of the fusion directory and rename it probably.

Btw looking at the diff it's progressing in the right direction, thanks a lot!

Thanks, but I have some big commits coming which might revert things a little, since I've found that due to the recent checkpointing changes, I'll have to redesign DynTensor to take a simple generic primitive type P, instead of a backend type.

Okay, I've finally finished the autodiff refactor. All that is left is implementing the backend ops. I'm kind of worried about this though, due to me being inexperienced in the design decisions behind each backend. In general though, reference counting isn't neccessary for DynTensorPrimitive, right? In other words, there's no need to use ArcArray for the Ndarray backend.

Finished the LibTorch backend, currently writing the Candle one. What should I do with the fact that u8s are used to represent booleans? Hypothetically, if one were to use a Candle<_, u8> backend, there would be no way to differentiate between boolean dynamic tensors, and integer dynamic tensors. This isn't necessarily bad... but I'd say it isn't ideal either.

This PR is nearing review readiness. A few more questions:

Why does burn-fusion not require that reading tensors from the client return tensors? Isn't returning Data less flexible? Reading tensors directly is needed for creating an impl for turning tensors into dynamic ones.
Should we add tests for roundtrip conversion between dynamic and regular tensors?

burn-fusion support appears to be done! I'm not super happy with solution used with the .server() method for FusionClient, and if it's an issue, do tell. The JIT backend is pretty much the only backend left before this could hypothetically, be merged. I'd like to ask, which solution seems like the better one?

Making JIT tensor not have parameters for element type and rank, so they'll also be the dynamic tensor type.
Making a new JIT tensor type, soley for dynamic tensors.

This PR is nearing review readiness. A few more questions:

Why does burn-fusion not require that reading tensors from the client return tensors? Isn't returning Data less flexible? Reading tensors directly is needed for creating an impl for turning tensors into dynamic ones.
Should we add tests for roundtrip conversion between dynamic and regular tensors?

Reading a tensor is actually into_data, if you want something else it should be a different method.

Making the JIT tensor not have a parameters for element type, I think, @louisfd

Currently working on this. It's going to take a while though... It's a really invasive change.

Currently working on this. It's going to take a while though... It's a really invasive change.

From what I can see, this solution actually won't be possible. I'll work on the other one.

Burn compiles! This is a great milestone for this PR. Here are what remains:

Fix the hacky way burn-fusion support was achieved. I'll probably make the read_tensor_X methods of the FusionClient trait return backend tensors, instead of readers into data.
Add tests for round-trip dynamic tensor conversion
Update the books about dynamic tensors, their use-cases, and methods relating to them.

Once the PR is actually ready for review, I'd suggest focusing on each crate exporting a backend, and checking their into/from_dyn methods, for each tensor type, and in the Backend definition itself. For burn-autodiff, also look at the Gradients/GradientsParams definitions. Finally, make sure the Record implementations in burn-core for TensorContainer and the gradient types are sound.
Most of the other changes are typo fixes, trait method reorderings, and renamings to fit the Rust naming guidelines (NodeID to NodeId).

I'm still not entirely sure how would the books best be updated, but this is something which should probably be decided on review end.

Thank you for the effort put into the PR for dynamic tensors. However, after reviewing it, I don't believe it's reasonable to merge it in its current state due to its size and the level of disruption it would cause. Nonetheless, the PR has been incredibly valuable in highlighting the limitations of our current abstractions.
I suggest breaking down the changes into smaller, more manageable chunks, particularly focusing on aspects like refactoring and renaming. While serializing the tensor container is valuable, I believe it's crucial to implement backend movements (improve mixed precisions) as well as our http backend before making gradients and tensor container serializable.
Our goal is to accommodate multiple tensors of different backends within the same autodiff graphs, enabling mixed precision training and executing different parts of a model on different backends. This objective may conflict with having a tensor container that enforces uniformity in tensor types.
Once again, thank you for your contribution.


Update plugin used to copy backend assets

Grigas noticed supplemental presentation rules were missing on GPB. After further investigation, it was apparent that none of the backend assets were getting delivered anymore.
Updated the existing CopyStaticAssetsPlugin to add a conditional arg for where to copy to, and use this updated plugin for BackendDefaultsPlugin
Notes:

In a separate PR we need to look into fixing CopyStaticAssetsPlugin so that it'll work internally in the monorepo (it currently is unable to resolve the assets we want to copy through all the symlinks).
Only DTA webpacks their backend in the monorepo, and even thats not by default (so this change shouldn't affect anyone in the monorepo)
Add Unit Tests

Will circle back to resolving symlinks in a monorepo in a separate pr

@mergifyio update

@aruniverse I'm a bit confused on what the root problem was here that caused an issue. Switching from using the directory name, how is that actually fixing it?

@aruniverse I'm a bit confused on what the root problem was here that caused an issue. Switching from using the directory name, how is that actually fixing it?

Note, we also changed what plugin we're using. iirc the one it was using before needs to get updated because it searches only in @pkgScope/lib/assets, and not @pkgScope/lib/cjs/assets or @pkgScope/lib/esm/assets/ . This new plugin will copy over assets from @pkgScope/pkgScope/**/assets. Not all pkg owners will create and output to lib directory, we're pretty inconsistent about that, so this should handle that. As long as you deliver your assets to an asset dir in your output those will get copied over.

@aruniverse just missing rush change and then should be good to know.


On closing the map section, the lesson section isn't  resizable

Issue Description
As you can see in the GIF below when the map section is not closed the lesson section gets resized easily. But when it is toggled-off the lesson section is not resizing to the left.

Browser Information

Browser Name, Version:  Chrome (latest release) & Firefox (57.0.2).
Operating System: Windows 10 Pro 32 bit.
Mobile, Desktop, or Tablet: Desktop.

@vkWeb Nice find! Yes - we definitely need to fix this.

I can take a crack at fixing this if nobody minds.

This would be a first-time contribution, so I'll take a look as well!

@abohannon You can start working on this issue. Please, go through our Contributing guidelines.
@meda123 I'm extremely sorry but there are a lot of outstanding issues which needs attention. We'll be looking forward to your PR.

@QuincyLarson This issue is being addressed by @abohannon.

Hi @abohannon Have you had time to make any progress on this?

Hey @QuincyLarson, took a look yesterday and plan to get back to it tomorrow (possibly tonight). Certainly a learning curve digesting the codebase for the first time. Is there anything I should know about how the panes and dividers are structured/work together? I think I've found the redux action that might be responsible, but will need to debug further. Thanks for the opportunity to troubleshoot this.

I tried to check on this. Actually, 2 files we need to udpate, I think. 1. \freeCodeCamp\common\app\Panes\Panes.jsx  &   2. \freeCodeCamp\common\app\Panes\redux\index.jsx . Code is working like whole 100% browser width is divided into totalNoOfPanels. bcz of that, Side-panel(Ques description part panel) getting its min & max width(or left-right values) which is increased to approx 33% after Map-Panel hide. (First timer,so, dont want to change anything r8 now in this project.) Please tell if I am wrong.

@sachinlamba thanks for the feedback. Your input and Redux dev tools helped me pinpoint what seems to be the problematic action, dividerClicked. Removing dividerBuffer from leftBound gets rid of the weird auto-resizing behavior and results in a semi-normal resizing effect, however the user still isn't able to collapse the leftPane all the way when the map pane is gone. If I get rid of both leftBound and rightBound, the user is able to resize normally, except the panes are able to resize beyond their neighbors, so not ideal.
Also, I'm not sure if this is intentional (maybe I'm not understanding the semantics for the pane state properties), but the leftPane and rightPane seem to be off by one index. In the attached screen shot, you'll see that map isn't visible, but it's logging as leftPane. Also, the dividerLeft for rightPane is 66.66 when one would assume it would be 0. Finally, when the map pane IS visible, leftPane

returns an empty object when you'd assume it should return map pane state.
I'll keep working on this.

@vkWeb I think I'm ready to submit a PR for this. Having an issue with the tests, though. Getting a ton of what appear to be linting errors in files I didn't edit. There don't appear to be any errors in my files. Should I submit the PR regardless?

@abohannon can you pull the latest version of staging and merge it into your branch, then try running the npm run lint command?

@QuincyLarson turns out I had a rogue eslint file conflicting. Deleted it and all tests passed. PR request submitted.


[bazel] Add support for generating python protos that include nanopb, use bazel-built protoc

This makes 2 changes:

Adds the ability for us to generate python protobuf code from protos that include nanopb.proto.
Modifies the PATH for the protoc plugin such that it invokes the bazel-built protoc instead of the system installed protoc in invoke_protoc.

Hmm, why is the PATH wrapper needed? When invoked as a protoc plugin, it shouldn't need to call protoc. At least unless nanopb_pb2.py needs to be rebuilt? Or is that exactly the purpose?

Hmm, why is the PATH wrapper needed? When invoked as a protoc plugin, it shouldn't need to call protoc. At least unless nanopb_pb2.py needs to be rebuilt? Or is that exactly the purpose?

Yeah it looks like that's it, I hadn't dug into exactly why before.
If I make nanopb_py_proto a dependency of protoc-gen-nanopb, then it should theoretically not need protoc itself. However, I then run into an issue with load_nanopb_pb2 in generator/proto/__init__.py because it assumes the protobuf will be located in the same directory, but bazel places generated code in a separate .runfiles directory and modifies sys.path to make the imports look the same.
Should the load_nanopb_pb2 code change instead to somehow detect that it's being run inside a bazel environment and not do any rebuilds or manual file checks, instead just relying on a try import of nanopb_pb2?

What I mean is that this patch on top of this PR will work, but I'm not sure how you'd prefer to fix __init__.py since I can see that check being useful outside a bazel environment
diff --git a/BUILD.bazel b/BUILD.bazel
index 69ac618..dfcb609 100644
--- a/BUILD.bazel
+++ b/BUILD.bazel
@@ -31,7 +31,7 @@ cc_library(

 copy_file(
     name = "protoc-gen-nanopb.py",
-    src = "generator/protoc-gen-nanopb-bazel",
+    src = "generator/protoc-gen-nanopb",
     out = "generator/protoc-gen-nanopb.py",
     allow_symlink = True,
 )
@@ -45,13 +45,12 @@ py_binary(
     ],
     data = glob([
         "generator/**/*.proto",
-    ]) + [
-        "@com_google_protobuf//:protoc",
-    ],
+    ]),
     imports = [
         "generator",
     ],
     deps = [
+        ":nanopb_py_proto",
         requirement("grpcio-tools"),
     ],
 )
diff --git a/generator/proto/__init__.py b/generator/proto/__init__.py
index cfab910..3aaacc4 100644
--- a/generator/proto/__init__.py
+++ b/generator/proto/__init__.py
@@ -72,27 +72,23 @@ def load_nanopb_pb2():
     tmpdir = os.getenv("NANOPB_PB2_TEMP_DIR")
     temporary_only = (tmpdir is not None)
     dirname = os.path.dirname(__file__)
+    # XXX this path is correct when run in bazel
     protosrc = os.path.join(dirname, "nanopb.proto")
+    # XXX but this path is not, so nanopb thinks this file doesn't exist.
     protodst = os.path.join(dirname, "nanopb_pb2.py")
     proto_ok = False

     if tmpdir is not None and not os.path.isdir(tmpdir):
         tmpdir = None # Use system-wide temp dir

-    if os.path.isfile(protosrc):
-        src_date = os.path.getmtime(protosrc)
-        if not os.path.isfile(protodst) or os.path.getmtime(protodst) < src_date:
-            # Outdated, rebuild
-            proto_ok = False
-        else:
-            try:
-                from . import nanopb_pb2 as nanopb_pb2_mod
-                proto_ok = True
-            except Exception as e:
-                sys.stderr.write("Failed to import nanopb_pb2.py: " + str(e) + "\n"
-                                "Will automatically attempt to rebuild this.\n"
-                                "Verify that python-protobuf and protoc versions match.\n")
-                print_versions()
+    try:
+        from . import nanopb_pb2 as nanopb_pb2_mod
+        proto_ok = True
+    except Exception as e:
+        sys.stderr.write("Failed to import nanopb_pb2.py: " + str(e) + "\n"
+                        "Will automatically attempt to rebuild this.\n"
+                        "Verify that python-protobuf and protoc versions match.\n")
+        print_versions()

     # Try to rebuild into generator/proto directory
     if not proto_ok and not temporary_only:
diff --git a/generator/protoc-gen-nanopb-bazel b/generator/protoc-gen-nanopb-bazel
deleted file mode 100755
index fc726ee..0000000
--- a/generator/protoc-gen-nanopb-bazel
+++ /dev/null
@@ -1,14 +0,0 @@
-#!/usr/bin/env python3
-# This file is used to invoke nanopb_generator.py as a plugin
-# to protoc on Linux and other *nix-style systems.
-# Use it like this:
-# protoc --plugin=protoc-gen-nanopb=..../protoc-gen-nanopb --nanopb_out=dir foo.proto
-import os
-
-from nanopb_generator import *
-
-if __name__ == '__main__':
-    os.environ['PATH'] = 'external/com_google_protobuf:' + os.environ.get(
-        'PATH', '')
-    # Assume we are running as a plugin under protoc.
-    main_plugin()

Yeah, having to build nanopb_pb2.py has always been a mess.
If importing nanopb_pb2 works, maybe it could use nanopb_pb2.__file__ instead of the hardcoded path for the up-to-date check? Though if it is out of date, it would then need to unload and reload the generated file, which I think doesn't work with Google's Python protobuf library.
Maybe there is some way in Python to look up where it would import nanopb_pb2 from, so it could get the path before importing?

Checking for the file turns out to not be sufficient, the source file could have a more recent timestamp but bazel won't necessary rebuild the file if the SHA of the contents didn't change.
Also, the import path is slightly different under bazel

@PetteriAimonen Friendly ping on this, would you like @tobithiel to review?

Sorry for the delay.
Looks good to me, except I think the environment variable could be useful for other builds than just bazel.
I made a small change in https://github.com/nanopb/nanopb/commit/0fb645b92dac00e5df574df599a50f0f8b53b61f , could you pull from there and test if it works correctly for you?
Would it be easy to add some kind of test that would be run by the existing .github/workflows/bazel.yml that would test the nanopb.proto import? If it seems complex, I don't think it is strictly necessary.

Tested fine on our repo. Hopefully this works for testing in CI

The existing CI tests cover this now that we're depending on the nanopb py proto in bazel, see https://github.com/nanopb/nanopb/actions/runs/7663874563/job/20887356939

Thanks a lot!


Team 5 player refactor

Description
The Player Factory has been significantly refactored, extracting the concept of a "PlayerFactoryFactory"
Fixes / Closes # (issue)
#410
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
The pre-existing tests were used as regression tests.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@IanP96 hey I've killed off player selection and moved it into a PlayerFactoryFactory and put an abstract PlayerFactory in the GameOptions, could you double check this works with your code.

@Jas2310 and @Magnius001 I have straight up moved items and weapons into their own folders, and re-gutted weapon responsibilities out of the inventory, can you double check this works with your changes?

@vsinh14 I've pulled Pets out into their own kind of collectible, can you double check this works with your changes?

There appear to be merge conflicts @SIN-Willett

I resolved the merge conflicts but load does not follow convention with main so currently still breaks in this branch.
Please resolve this issue before the merge will be accepted

Load can be temporally fixed by checking for null when getting the multiplier for difficulty in adjustForDifficulty() of PlayerConfig.java.
Regarding the changes to weapons, everything looks good.

Load can be temporally fixed by checking for null when getting the multiplier for difficulty in adjustForDifficulty() of PlayerConfig.java.
Regarding the changes to weapons, everything looks good.

@SIN-Willett I think the best option would be to have a PlayerFactory.create that takes no arguments and does no difficulty scaling. Realistically there shouldn't be any need to reapply the difficulty, the effect of the difficulty selection is applied when you start the game that you saved if that makes sense

Loading still breaks the game


Start 0.10.0-m2.1 shipyard release phase

Signed-off-by: Daniel Farrell<EMAIL_ADDRESS>

I'm not sure if we need this or if we can fix m2. See: https://kubernetes.slack.com/archives/C010RJV694M/p1623693057066400

Yeah, this would be only for the go code in a pre-release. The dapper image reference is not modified for pre-releases.

Not required, continuing with m2 here: https://github.com/submariner-io/releases/pull/161


Use cover position instead of tilt position

Wouldn't be better to use a cover position instead of a cover tilt position? For example, rename the current_cover_tilt_position' method to current_cover_position'. Currently it looks like you are controlling a blind:

With a cover position, it looks like you are controlling a window position:

Smarwi is designed to open the window on the ventilation, i.e. tilt it, so I think that cover_tilt is more appropriate here. I don’t know why it’s visually represented in this way though.

Okay, thank you. It's a Home Assistant problem. Let's close this issue.


[Fix-638][Alert]Fix problems about the email alarm notification, cannot customize the nickname.

[Fix-638][Alert]Fix problems about the email alarm notification, cannot customize the nickname.
Purpose of the pull request
Brief change log
[Fix-638][Alert]Fix problems about the email alarm notification, cannot customize the nickname.
Verify this pull request
This pull request is code cleanup without any test coverage.

"Please only merge the last commit into dev."
@aiwenmo done


DEPRECATION WARNING: alias_method_chain

Running the following code in Rails <IP_ADDRESS> will cause warning.
include SeamlessDatabasePool::ControllerFilter
DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super.
Is this problem fixed?

this should fix it https://github.com/bdurand/seamless_database_pool/pull/37 ✌


[SHIRO-661] Add check for the principal of subject whether is null

When session is based on servlet container(such as tomcat),if the subject is authenticated，the session will contains AUTHENTICATED_SESSION_KEY and PRINCIPALS_SESSION_KEY。
When servlet container closed, it may will be persist session.
But if the principal can not be serializable, it will not be persisted; when server restart, session will only contains AUTHENTICATED_SESSION_KEY info ,the PRINCIPALS_SESSION_KEY will be lost,
it means the subject is authenticated, but the subject does not has principal。If the user code is
User u = subject.getPrincipal();
// because the u if null, it will be npe
u.getName();

Recently, my project has happened such case, so I think add check for  principal of subject whether is null can make application more powerful.

Thanks @plx927!
I'm thinking we should probably update the current Subject impls isAuthenticated method too.

@bdemers as we have no update about the user, can I merge this and made the update in the Subject isAuthenticated method in another PR?

@fpapon i think we would want to figure out how/why a subject is authenticated without a principal.
Possibly making the default isAuthenticated() check for a principal.  But i think understanding what happened is our first step

@bdemers ok, if I understand the use case, this is about the serialization of the Principal. Sometimes it cannot be serialize and became null in the session after restarting the web container.
May be we can check why Principal is not serialized?

AHH!! maybe adding the null check to isAuthenticated() is the way to go then?

Yes I think so :)

I think we could add && hasPrincipals() here:
https://github.com/apache/shiro/blob/22a2612056485a06507b644f0d1a61b0ac437d04/core/src/main/java/org/apache/shiro/subject/support/DelegatingSubject.java#L297

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/78/


NPE while commiting unique index

iSingleValue is of type ORecordId
value==null
Caused by: java.lang.NullPointerException
at com.orientechnologies.orient.core.index.OIndexUnique.put(OIndexUnique.java:76)
at com.orientechnologies.orient.core.index.OIndexUnique.put(OIndexUnique.java:35)
at com.orientechnologies.orient.core.index.OIndexAbstract.putInSnapshot(OIndexAbstract.java:845)
at com.orientechnologies.orient.core.index.OIndexAbstract.applyIndexTxEntry(OIndexAbstract.java:1022)
at com.orientechnologies.orient.core.index.OIndexAbstract.addTxOperation(OIndexAbstract.java:706)
at com.orientechnologies.orient.core.tx.OTransactionOptimistic$CommitIndexesCallback.run(OTransactionOptimistic.java:98)
at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage.commit(OAbstractPaginatedStorage.java:1334)
... 43 more

Hi @vantonov1
Any hint on how to reproduce the problem? Do you have a test case that fails?
Thanks
Luigi

Sorry, right now I cant shorten my test enough (I test my own wrapper level). What I could see is that on commit where are two operations in index changes, one is PUT and one is REMOVE.  In OIndexUnique.put() iSingleValue is temporary record, getRecord() returns null, and we have NPE

But if I just trying to add and remove vertex and asge, where are no changes in index, and it works

Hi @vantonov1 , what version do you use ?

Hi!
Hmm... Most probably it was 2.2.0-beta
I gave up with Orient in December - too unstable for me (most probably because I need embedded mode with complicated transactions)

Sad to hear that in 3.0 we are going to introduce new transaction model, hope you will be back to us.

Ok, lets check, see you with 3.0-beta :)
Ah, one more stopper was https://groups.google.com/forum/#!topic/orient-database/MMVQAj3FlvE

Well @vantonov1 I have tried to reproduce your issue according to description but no luck.  Sad that we reacted so later. But we have new working schedule which allows to react on all issues much earlier. Also as I have wrote in 3.0 version we will have new transaction system.

I checked again, situation with lucene indexing is simple - all fields encountered in query have to be indexed in the same lucene index. So, if I query for fields from both class and superclass, I cant use index from superclass, all fields from superclass have to be reindexed again
I created issue https://github.com/orientechnologies/orientdb/issues/5868


Export task works incorrectly after editing db-db export on another output type

System information:

Operating system (distribution) and version Win10
DBeaver version 7.1.4

Describe the problem you're observing:
Export task works incorrectly after editing db-db export on another output type
Steps to reproduce, if exist:

Create db-db export task
Save/execute it
Open it again for editing
Change export to database to another type (e.g. CSV)

Expected: next wizard steps are changed accordingly
Actual result:

only half of step Settings is displayed

step Output dissapears

Most probably the reason is the same like in https://github.com/dbeaver/dbeaver/issues/9154. Closed as duplicate.


Follow redirection responses when refreshing stale cache objects.

[approve ci clang-format]

Thanks for this!

Fortunately turned out to be a simple fix.

Cherry-picked to v9.0.x branch.


fail to get ssh key from Github

dns at [::1] not work

I'm seeing the same thing. The boot screen says both eth0 and wlan0 are 'DOWN'. That is probably because they are at eno1 and .. something else for wlan that I've forgotten.
I don't know how to fix. I'm trying this on an Intel NUC with very vanilla hardware, booting from the ISO on USB without any config (other than specifying the drive, 'server', and my ssh key). So I can't even access the machine after install since the rancher password gets wiped.

progress:

set a password, so at least I can log in and diagnose now.
networking is at eth0, not eno1 for k3os. It has an IP from my DHCP server, and I can ssh in remotely (with the password).
The pre-login banner still says eth0 DOWN.
There's no ssh key (no files in ~/.ssh/)

I don't know how much confidence I should have in k3os given this. If I tail k3s-service.log it is full of "watch chan error: EOF" as mentioned in rancher/k3s/issues/463.

Same for me, installed K3OS from bootable USB to HDD.
When booting into K3OS I'm getting:

ERRO[0000] failed to authorize SSH key github:danopz: Get https://github.com/[…]: dial tcp: lookup github.com on [::1]:53: read udp [::1]:53466->[::1]:53: read: connection refused

https://github.com/rancher/k3os/pull/136

Same problem here trying to run from HDD on an Intel NUC. #136 did not seem to fix it. I've tried with the latest release which includes that change, with the same result. The machine has an IP from my DHCP server as well, so network is up but banner shows down (update-issue script) and the SSH pubkey pulling appears to be happening before network is ready still.

I'm having the same issue on v0.11.0 running on a physical device.

Same here. Just set up a new machine, same issue.

Same here. Just set up a new machine, same issue.

I am also still experiencing this issue. K3OS deployed on an Intel NUC and working fine other than the github-based ssh key feature has the exact same failure mentioned above.
Is there any way we could re-open this issue, as I don't believe this has been fully resolved?


[WFLY-18653] i18n of exception messages in ApplicationClientParsingDeploymentProcessor

Issue: https://issues.redhat.com/browse/WFLY-18653
i18n of exception messages in ApplicationClientParsingDeploymentProcessor

Thanks @soul2zimate


:update: make cms sync

WARNING: EXPERIMENTAL STUFF
make cms sync
If someone is loading the dashboard or anything, everything else (including the CMS) will be blocked.
CMS doesn't take any time to load by itself. Setup CMS to respond even if explorer and other parts of the API are running slow

Ready to push live, need observation for at least a day to make sure this works correctly


FileNotFoundError: [Errno 2] No such file or directory: "'./download/fc4.pth.tar'"

Hello, I want to reproduce the work, but I get this error when I run test.py. However, I indeed put it in this folder. And another question is that I can't unzip the package fc4 and fc7. Can you give me some advices? Thank you very much!

Hi, you don't need to unzip the model file, you just have to pass it as an argument to the command line: python test.py './download/papers_video' fcnet 7 './download/model_best.pth.tar' --save_videos='./output_videos' --gpu_id 0

Thank you for your reply! Indeed, I run the test.py as your instruction, but I got this error:FileNotFoundError: [Errno 2] No such file or directory: "'./download/model_best.pth.tar'"
What does this means? Where is the model_best.pth.tar come from? Could you please give me some advices again?

Thanks. My mistake, the name of the file when you download fc7 model is fc7.pth.tar and this is the name that you should use in the test.py and not the model_best.pth.tar. I will correct this in README

OK, thanks! However, another issue is waitting to be solved. When I run: python test.py './download/papers_video' fcnet 7 './download/fc7.pth.tar' --save_videos='./output_videos' --gpu_id 0.
I got this error: FileNotFoundError: [Errno 2] No such file or directory: "'./download/fc7.pth.tar'".
But I indeed put the fc7.pth.tar in this folder. I'm thinking wheather the model file has been destoried so that the code cannot find this file. Could you please give me some advices more?

what happens if you don't put the model file under the 'download' folder and you put it under the folder you put the other files?

what happens if you don't put the model file under the 'download' folder and you put it under the folder you put the other files?


add support for the get_transform analog to set_transform

given a set of scale and translation transforms, defined on both the group and individual individual images, each image will have a final scale and translation. These can now be conveniently retrieved with a little helper function that fetches all appropriate translations and applies them consecutively.
small test added to cover changes.

Re: CI failure: please refer to the contributing guide.

passed the precommit checks 👍

If get_effective_translation[or scale] returns a single transformation object would it be more friendly to return a tuple of floats or an array-like object?

If the dataset does not have all 5 axes, what should the length of the returned sequence be? I'm guessing that @pattonw's use cases are mostly 3D instead of 5D?

If get_effective_translation[or scale] returns a single transformation object would it be more friendly to return a tuple of floats or an array-like object?

If the dataset does not have all 5 axes, what should the length of the returned sequence be? I'm guessing that @pattonw's use cases are mostly 3D instead of 5D?

Isn't it as simple as returning the .scale or .translation property of the TransformationMeta? Isn't the length always equal to the number of dimensions in the array?

Isn't it as simple as returning the .scale or .translation property of the TransformationMeta? Isn't the length always equal to the number of dimensions in the array?

 I mistakenly thought that Position.scale behaves differently (I was thinking of this one).

Separated into 2 unit tests, return plain list of floats instead of TransformationMeta classes, and removed the error I introduced in scale property to fetch the effective scale of the first dataset instead of just the root.

fixed test docstring and fixed case that was failing testing

Ready to merge if @JoOkuma doen't have further comments.

@ziw-liu, I don't have any additional comments.
Thanks for the contribution @pattonw


Feature/resumable generate and load

Description TBD.
Start reading the code here:
https://github.com/SFDO-Tooling/CumulusCI/compare/feature/resumable-generate-and-load?expand=1#diff-8f454c91a54a0fcab96adfd4173aa84bR243

Do you mean that the programmer would need to refer to all persistent state
as self.state.xyz
Of do you mean that the base-class would override setattr/getattr to
transparently store its state elsewhere?
On Mon, Jun 22, 2020 at 7:05 AM David Glick<EMAIL_ADDRESS>wrote:

@davisagli commented on this pull request.
In cumulusci/core/tasks.py
https://github.com/SFDO-Tooling/CumulusCI/pull/1823#discussion_r443582234
:

   self._resume()

   self._run_steps()

   self._after_finished()

def set_nonpersistent_value(self, key, value):

   "Save a value to memory but not to persistent storage"

   self.__dict__[key] = value

   self.excluded_fields.add(key)

def dict(self):

   return {k: v for k, v in self.__dict__.items() if k not in self.excluded_fields}

def setattr(self, name, value):

   if name not in self.excluded_fields and not hasattr(self.__class__, name):

       raise AttributeError(f"Undeclared attribute {name}")

   self.__dict__[name] = value

Okay, I am on board with the argument for making it a bit more work to
store nonpersistent state in instance attributes. (It helps that there are
a number of existing tasks where I think instance attributes are overused.)
But you didn't answer the other part of my question, about the possibility
of keeping persistent state more explicitly contained in a separate state
object. My arguments for this are:

It makes it clearer which values are being persisted; instead of
having to keep track of which names are being stored which way, you can
just look at where the value is being set.
It would remove the need to manage a list of excluded fields for
each task, and clean up the ResumableTask implementation a bit since it
wouldn't need to filter based on what's in excluded_fields
It makes resuming more straightforward: The task can work with a
state object reconstructed in its entirety from the resumption file,
instead of needing to transfer specific state values to specific task
attributes.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SFDO-Tooling/CumulusCI/pull/1823#discussion_r443582234,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFMS5N3XKPLOWVD72FVSTRX5QJZANCNFSM4OC357DA
.

Closing since it's been more than a year since the last activity. Feel free to re-open as needed.


I get this error for no reason and it spams and takes a lot of resources of the server

This is not my error, it is SimpleLobby's, please use /sl setspawn to define a spawn if you want this error to not appear


Fix http4s version update by also updating scala version

Many current pull request with version updates fail, because http4s-core is built with newer scala3 version.
This PR updates the scala3 version in the project, so other PRs can be successfully built and merged

Thank you!


Failed GHA

https://github.com/LukePrior/nbn-upgrade-map/actions/runs/5249627749
https://github.com/LukePrior/nbn-upgrade-map/actions/runs/5248582460

I need to look into this further so that manual restarts aren't required

This should be improved here: https://github.com/LukePrior/nbn-upgrade-map/commit/5bdc4da81c79f88012bd8dd7a9513c14dc93416f

Haven't seen this in some time. This can probably be closed? @LukePrior


Content-Type is not recognized as a text type

Hi again,
I have another observation, however it's only a minor one and definitely not an issue.
Nevertheless: when using the http provider for sending JSON requests to a REST API, I am getting these warnings:
Content-Type is not recognized as a text type, got ""

I believe this is correct complaint about the server (incorrectly) not providing any Content-Type within response.
Would it be possible to add a bool parameter to the resource definition that would suppress these warnings, or even better a parameter with a default assumed response Content-Type when there is not any returned by the server?

only certain content types are allowed (and if blank, that warning shows up).
https://github.com/salrashid123/terraform-provider-http-full/blob/main/internal/provider/data_source.go#L261
and in terraforms' main http upstream provider here
https://github.com/hashicorp/terraform-provider-http/blob/main/internal/provider/data_source_http.go#L217
i suppose i can have a parameter that allows for a set of content-types or a bool flag to allow all (including empty)...i'll leave this open for now as its a warning...if more content types or allow all is requested more, we can add that in


Feature Request: UI Collections sort order

In the admin ui it would be helpful to choose how the list of collections should be sorted (created, a-z)

Thanks. It is already in my todo and I'll consider it when redesigning the collections UI in relation to #376.

@kymc At least for v1.0.0, I don't plan adding drag&drop order support for the collection records. We currently support only a "table view" for the records listing and this will not work well with the manual drag&drop sorting (with v0.8 there will be drag&drop sorting only for the collection fields, aka. columns).


Production App wont auth

Hi,
thanks for putting together this project, its very interesting.
I have deployed this locally to my machine and works well.
However, when i deploy it as an app service, it will not auth through to the chat app.
I have tried both GH and AAD for auth, and each time it will stay on the same screen with a URL similar to:
azurewebsites.net/api/auth/signin?callbackUrl=%2Fchat
It just wont go through to the /chat site after i've MFA'd through.

resolved after updating the NEXTAUTH_URL to full canonical name in the app settings.


Crash Report -1834632792

Link:
https://wowsims.github.io/cata/priest/shadow/#eJzFU01oE1EQ3nm727xMak1emyY+S4lB+7MlkL9t0hyabQ8iolLwEj2ZH4sUhWIueksFoS0IwZvBgx6UgkhLL4KgSC9WsVJ7KCIIUjz0UNDeChZ0920SYsG21oPfHubnzXwzb+YtdlFwgwFXYBLgAcArgI8AXwDWAUoEJgmUCcwRGPa5wQ9JM/IUZGAc5kScGcEkvkkrctPI1ezNy9dps1vlQZT2+oIuqoZ9I0pGKQNoTwlugbQrBg1bjhm7x9Ww37j/Dxb+24yUNOwaF/tqspawAk1cQULhOdGz8Xw4mcuGE9l8LBmPhvLx/nw+kUxGwtlwLBcvxPR8f64Q0gv9A4lYvJDTs3ouu0CkRaIsE9cnIq2R26pfRg8KTr8n6EAV5VCkiK1IeRMq9PFLpe5kHZyjW2uhMiMpyTpGEimKsIk7hHXx4ztPo0XuxhY61R74WQOwdt4m4tQGlmspiQ3wBIZ4H7ZrbRSYcwEs4kcfVG5WR9DRox2mCiOnJS4aiuqitHt1WxaUrqATHVHzgC4p3Basj/eybiRnTzKHcM3eYP5b4BUab9GaTT75LkhcXpElKxgDrBMPBV3onBfVn22ojebsZ6VG4+PeWkOpakORaNG8RTc/gR2MN6TsIBQM99MswXXs03rNcdEx62itTPjReeK37l4hNY+zotTUqmRBHkCf5jUTHWMWV8nHaUWparZgF3kGz7Ezv8/y/Ux9lpZfbSgstqAX0au1mv46b80tT4PYFN2cUZmTO2p3CPBObGMMnRVR4Mc2oPqWEGo3a5oMOa0/EM7/OPx1sgjfSc+EbL/5uPGwql0wpmUp+JU4hVUaNTy2f9A4Urln4U16wPYsp4+NCqymh5beWdhIR5+QQMavamXyzz/ubuiZMg6SViq83iPv/IF49wN7aC++GUO2vZW+BL8As1mzYQ==
RNG Seed: 0
runtime error: index out of range [7] with length 4
Stack Trace:
goroutine 6 [running]:
runtime/debug.Stack()
/opt/hostedtoolcache/go/1.21.10/x64/src/runtime/debug/stack.go:24 +0x6
main.computeStats.func1()
/home/runner/work/cata/cata/sim/wasm/main.go:49 +0x10
panic({0x1bd900, 0x305e378})
/opt/hostedtoolcache/go/1.21.10/x64/src/runtime/panic.go:914 +0x2c
github.com/wowsims/cata/sim/priest.(*Priest).applyImprovedMindBlast(0x3370000)
/home/runner/work/cata/cata/sim/priest/talents.go:403 +0x2e
github.com/wowsims/cata/sim/priest.(*Priest).ApplyTalents(0x3370000)
/home/runner/work/cata/cata/sim/priest/talents.go:133 +0x31
github.com/wowsims/cata/sim/priest/shadow.(*ShadowPriest).ApplyTalents(0x303bfa0)
/home/runner/work/cata/cata/sim/priest/shadow/shadow.go:72 +0x4
github.com/wowsims/cata/sim/core.(*Character).applyAllEffects(0x3370000, {0x3ee208, 0x303bfa0}, 0x32cf680, 0x3396780, 0x326fec0)
/home/runner/work/cata/cata/sim/core/character....

You have no talents selected.

I don't know how the link was generated but it's actually trying to deserialize a talent tree which puts 7 points into improved mind blast talent, hence the out of range exception when trying to access the different probabilities.
Should we add some additonal backend sanity checks for talents? 😁


Remaining the temporary image file

The image file in "tmp" directory isn't removed after sending it to Instagram app.
But if the deinitializer remove it, Instagram app doesn't start.

This library has the removeTemporaryImage method to remove it now.

Add the removeTemporaryImag method without completion paratemer.


Beta release to support angular2 - beta 12

@valorkin We recently updated our main application's angular version from beta 9 to beta 12. But the currently available ng2-bootstrap NPM package still need angular2 - beta 9 as the peer dependency.
Because of different peer dependencies between different beta versions of angular, it is difficult to try out ng2-bootstrap's latest code.
If we have a release may be like 1.0.8.beta, with angular 2 beta 12 as the peer dependency (I already see this in the package.json) we can start using this and contribute to ng2-bootstrap while working on our application.
Please see if this can be possible.

Make it beta.13 please.

Beta 12 in testing - will published today
Beta 13 has only one change, if not broken will published too

published

Thanks @valorkin

Seems like it was published for beta.12 only. Any issues if I just change the package.json to beta.13 ?

@Growiel update for beta.13 will be today
only breaking change in 12->13 is ng-content select
was changed