poc: recognizing when a dataset was unfetchable

Summary:
This PR is a proof of concept (POC) to identify when a dataset was not fetched, providing clearer information to the user about when and why a dataset was never fetched.
Expected Behavior:
Currently, the batch processing job attempts to fetch all non-deprecated feeds. Known reasons for a non-deprecated feed not being successfully fetched include:

Internal server errors (e.g., HTTP connection timeout because the URL is inaccessible).
Invalid ZIP file: If the dataset available at the producer's URL is not a valid ZIP file (e.g., the URL redirects to an HTML page), processing is skipped.

The goal of this POC is to enhance the UI by providing more information when a feed has no datasets. To achieve this, the existing dataset_trace GCP Datastore entity has been updated with an INVALID_ZIP status type. The status types are now as follows:

FETCHED: The dataset was successfully updated, stored in GCP, and added to the database.
NOT_FETCHED: There was no update; the latest stored dataset is still up to date.
FAILURE: An error occurred during processing (e.g., HTTP connection timeout due to an inaccessible producer URL).
INVALID_ZIP_FILE: The URL is accessible, but the response is not a valid ZIP file.

By having this status in Datastore, along with a timestamp and a stable_id corresponding to the feed's stable_id, it is possible to retrieve the latest status of retrieval for a given feed. Consequently, an element has been added to the API's GTFSFeed response to include information about the last fetch attempt. Here is an example of the object:
"last_fetch_attempt": {
        "status": "PUBLISHED",
        "timestamp": "2024-06-19T17:40:50.188550"
}

This information is now displayed on the UI's feed pages to show the latest status. Here are a few examples for different types of statuses (note that the results may vary if the API development is rebuilt or the batch processing jobs are run using the preview link):

Not covered by this POC:

In the final screenshot, you can see that the status is displayed as "in about 4 hours." This discrepancy is due to a timezone difference between the UI and the backend. The processing was completed recently on the backend, but the UI is operating in a different timezone, causing the time mismatch.

Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
[ ] Add or update any needed documentation to the repo
[x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
[x] Linked all relevant issues
[x] Include screenshot(s) showing how this pull request works and fixes the issue(s)

Nice work! Leaving here a few notes after connecting with @cka-y

We need to be aware of Datastore scanning all records as part of the queries(this is why the current POC tries to get a timestamp to filter out records as part of the query)
Having this information as part of the "common" GTFS entity will affect all endpoints to the detriment of performance.
If we implement a "generic" logging system, it will allow us to add additional "operations" like validator-runs, bounding-box extraction, etc.
We agreed that it's preferable to add this information as a separate endpoint rather than in the GTFS entity. Example proposed endpoint: v1/gtfs_feeds/{id}/operations_trace?operation=FETCH_DATASET.

Next steps:

[ ] Align UI layout design and create a UI issue
[ ] Create API issue to add the new endpoint

This is amazing! Thoughts on making this work a stretch goal as part of our August wrap-up of the Mobility Database UI? This is super high value, but I want to be mindful that we should start the Flex rules work next sprint and this isn't critical for beta or launch.

@emmambd, I believe we can include this task on the board as a low priority item. Implementing it shouldn't be too difficult if we break it down into separate backend and frontend tasks. If the current design doesn't meet your expectations, we would need your input on how and where you would like the information displayed in the UI.

Closing this
Follow up issues: #529 and #530


Invalid Scrope on PayPal.com Page in Chrome

When I run this code after cloned it. Then Change my Client & Secret Key Live after that on the Client Integration button click open create order page after filling all forms then Submit it redirect on Paypal.com page but showing invalid scope nothing performs. Please see a screenshot from the attachment.

Hi @Sidd-dev-android - You'll need to perform these steps in order for your ClientId and Secret to work in this demo app: https://developer.paypal.com/docs/business/native-checkout/android/#know-before-you-code
Going to close out this issue, but feel free to open a new one if you encounter any issues!


No Longer Can Create Test Files :(

Hey there,
Unfortunately it no longer appears that I can create test files for my projects.  Please see this SLN:
https://github.com/DragonSpark/Framework/blob/master/The DragonSpark Framework.sln
Note this configuration:
https://github.com/DragonSpark/Framework/blob/master/DragonSpark.Presentation/Properties/AssemblyInfo.cs
Attempt to hit Alt-Enter at this line:
https://github.com/DragonSpark/Framework/blob/master/DragonSpark.Presentation/Environment/Browser/IsBot.cs#L8
This is what I see:

I also tried using .editorconfig but that doesn't seem to do anything:
https://github.com/DragonSpark/Framework/blob/master/DragonSpark.Presentation/.editorconfig
Any assistance would be greatly appreciated!

Oh, sorry, early morning and I'm not reading text entirely 😖 Let me check your solution and get back in a moment

gosh, it took me 2 hours to understand the root cause.
That's because the .editorconfig file is wrong - you have to specify the scope of applicability. Also no need for quotes:
[*.cs]
resharperhelpers_tests_project_name = DragonSpark.Presentation.Testing

This one works like a charm 😊

Thank you so much @zvirja! That does work like a charm. 😁  I certainly appreciate all the assistance you have provided over the years.  Strange to think it's been that long!  Thank you nonetheless. 🙏

@zvirja just a quick note that after many many months of friction and obstacles, I have finally been able to get tests made for my components as desired and it is SO AMAZING!!!  The .editorconfig works like a champ and I have been copying/pasting/replacing as needed.
Thank you so very much for putting this together and sticking with it, as well as putting up with all my issues.  It's definitely such a relief to be able to slam ALT-Enter and get some tests made.
👍👍👍🙏🙏🙏

A little shout out here: https://twitter.com/Mike_E_angelo/status/1524798669509300227


Bug: [v5] fromPromise and actor causes machine to get stuck in state

Description
In V4, using a service with an async function, when double clicking, eventually the state returns to idle.
https://codesandbox.io/s/musing-framework-mqfnxr?file=/src/App.js
In V5, using an actor with fromPromise, the state gets stuck in loading.
https://codesandbox.io/s/awesome-currying-7yc6nz?file=/src/App.js
Expected result
State returns to idle
Actual result
State gets stuck in loading
Reproduction
See description
Additional context
No response

In v5 transitions are not reentering by default and you were relying on reentering in v4. You can still make that transition a reentering one by configuring reenter: true on it, like here: https://codesandbox.io/s/great-joliot-7w9vzd?file=/src/throttleFetchMachine.js:650-664

Thanks!

@Andarist Is there a possibility to allow setting this default at the machine level?
It would be nice to be able to set the default and then override at the transition level if needed.
The machines that I have that use reentering would have this on for all transitions. It has caught me out a couple times as I need to enable it for each transition.


Issue #34: Unify app framework with Android MVP implementation

Add Android MVP implementation
Update CI/CD workflows
Update documentation
Integrate build configurations

Tests
MacStudio-M1:RunOn garotconklin$ pwd
/Users/garotconklin/garotm/fleXRPL/RunOn
MacStudio-M1:RunOn garotconklin$ bash backend/scripts/format_and_lint.sh && bash android/scripts/setup.sh
Running Black formatter...
All done! ✨ 🍰 ✨
22 files left unchanged.
Running isort import sorter...
Running flake8 linter...
Running pytest with coverage...
=============================================================================== test session starts ================================================================================
platform darwin -- Python 3.9.18, pytest-7.4.3, pluggy-1.5.0
rootdir: /Users/garotconklin/garotm/fleXRPL/RunOn/backend
configfile: pytest.ini
testpaths: tests
plugins: asyncio-0.23.8, cov-4.1.0, mock-3.12.0, anyio-3.7.1
asyncio: mode=strict
collected 9 items

tests/test_basic.py .                                                                                [ 11%]
tests/test_conftest.py .                                                                                [ 22%]
tests/calendar_sync/test_calendar.py ..                                                                                [ 44%]
tests/config/test_environment.py ..                                                                                [ 66%]
tests/event_discovery/test_search.py ..                                                                                [ 88%]
tests/models/test_event.py .                                                                                [100%]

---------- coverage: platform darwin, python 3.9.18-final-0 ----------
Name                                    Stmts   Miss  Cover   Missing
---------------------------------------------------------------------
config/__init__.py                          2      0   100%
config/environment.py                      12      0   100%
docs/__init__.py                            0      0   100%
functions/__init__.py                       0      0   100%
functions/calendar_sync/__init__.py         0      0   100%
functions/calendar_sync/calendar.py        13      0   100%
functions/event_discovery/__init__.py       0      0   100%
functions/event_discovery/search.py         7      0   100%
models/__init__.py                          2      0   100%
models/event.py                            12      0   100%
tests/__init__.py                           2      0   100%
tests/calendar_sync/__init__.py             0      0   100%
tests/calendar_sync/test_calendar.py       23      0   100%
tests/config/__init__.py                    0      0   100%
tests/config/test_environment.py           13      0   100%
tests/conftest.py                           6      0   100%
tests/event_discovery/__init__.py           0      0   100%
tests/event_discovery/test_search.py       16      0   100%
tests/models/__init__.py                    0      0   100%
tests/models/test_event.py                 10      0   100%
tests/test_basic.py                         3      0   100%
tests/test_conftest.py                      9      0   100%
---------------------------------------------------------------------
TOTAL                                     130      0   100%
Coverage XML written to file coverage.xml

Required test coverage of 80% reached. Total coverage: 100.00%

================================================================================ 9 passed in 0.21s =================================================================================
🚀 Setting up Android development environment...
📝 Checking Java version...
📦 Installing required tools...
✓ Gradle already installed
✓ Kotlin already installed
Using Java from<EMAIL_ADDRESS>📱 Setting up Android SDK...
✓ Android Command Line Tools already installed
Warning: Errors during XML parse:
Warning: Additionally, the fallback loader failed to parse the XML.
Warning: Errors during XML parse:
Warning: Additionally, the fallback loader failed to parse the XML.
[=======================================] 100% Computing updates...
All SDK package licenses accepted.

Installing Android SDK components...
Warning: Errors during XML parse:
Warning: Additionally, the fallback loader failed to parse the XML.
[=======================================] 100% Computing updates...

Warning: Errors during XML parse:
Warning: Additionally, the fallback loader failed to parse the XML.
✓ Debug keystore already exists
🔧 Setting up Gradle wrapper...

BUILD SUCCESSFUL in 4s
1 actionable task: 1 up-to-date
🔑 Setting permissions...
🧹 Running formatting...
🧹 Running code formatting...
Running ktlint...

BUILD SUCCESSFUL in 1s
3 actionable tasks: 3 up-to-date
✅ Code formatting complete!
🏗  Running initial build...

[Incubating] Problems report is available at: file:///Users/garotconklin/garotm/fleXRPL/RunOn/android/build/reports/problems/problems-report.html

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.12/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 2s
92 actionable tasks: 2 executed, 90 up-to-date
✅ Setup complete! You can now run:
cd android
./scripts/format_and_lint.sh
📁 Creating project structure...

Unification of App Framework #34


Won't launch

https://i.imgur.com/rILpPuW.png
It seems to be related to localization from what I can see. My OS is in French.

Thanks for reporting, fixed


More German translations

This has been merged, thanks for your work on this! I updated the locale and last-updated data in each of the json files since I had previously forgotten to add that as a step to the translations guide.

Thank you for updating all the locale and last-updated metadata!

You're welcome, happy to help!


Noor Grewal Review Ticket Week 18

Individual review ticket

performance task scoring 2
model and OOP
team ticket

Model .85
View .95
CPT .9


Kafka consumers are not using the main application logger

As such, messages from librdkafka are only logged to the console, and do not end up in the log file.

This is not possible since these messages are logged from the underlying librdkafka C library.


Reload nav projects after restoring deleted project

Let vue manage the project list in the drop down.
TODO:

Pull out project list component
Have a refresh method that hits the server to get the current project list and repopulates

v0.9.9


I can control my roller shutter only in one direction

I agree to the following

[X] I have read the documentation right now
[X] I have read the FAQs right now
[X] I am aware of the latest release notes
[X] I am aware that an integration that was installed via HACS also needs to be updated via HACS
[X] The Backend (CCU/Homegear/...) is working as expected, devices are taught in and are controllable by its own UI.
[X] I am running the latest version of the custom_component (and Home Assistant)

The problem
I can control my roller shutter (HmIP-FROLL) with the ⬇-button of the Home Assistant card. It reacts and goes down. But after it is closed, the ⬇-button is still active and the ⬆-button is grayed out.
So it's not possible to control my roller shutter it with the UP and DOWN controls.
The only workaround I found is to open the control popup and switch to the slider mode. Here it always switches the mode, so it's possible to open it again.

The roller shutter is closed, but the ⬆-button is grayed out.

Also in the popup, the ⬆ control is disabled.

The  slider-mode shows the wrong state, but allows to open the roller.

I recognized the state was not updated ("opened 20 hours ago"). This is also shown in the history, that my close action was executed but not tracked:

Controlling the roller shutter in the CCU3 Webinterface always works, because both ⬆ and ⬇ buttons are always active.
Is there a way to ignore the last state and always show the buttons as active? For example, the 🟦-stop-button is always active. By pressing it, I can hear the actor executes the stop, even if the roller is not moving. So allowing it to execute an up command, even if it thinks it's already opened, should be possible.
Of course this is only a workaround. But it would solve my problem and should always be an option to control something, regardless of the current (wrong) state.
I can see some problems in the notification section:

And I also saw the info in the log:
1: You are running multiple instances of HA with the same instance name configured for this integration. Re-add one instance! Otherwise this HA instance will not receive update events from your CCU. Possible reason
2: Something is stuck on the CCU or hasn't been cleaned up. Therefore, try a CCU restart.Possible reason
3: Your setup is misconfigured and HA is not able to receive events from the CCU.

I already updated the CCU the latest: 3.77.7 and also the HmIP-FROLL to version 1.10.16.  I restarted the CUU several times. My PI5 is the only HA installation present in my LAN. The strange thing is, that the events seems to work sometimes (20 hours ago).
As mentioned, it would be nice to get a hint, if can use the widget without the events - simple and stupid.
But of course any help is welcome. And I'm already very thankful for this plugin which brings back my CCU to the 21th century.
What version of HomematicIP (local) has the issue?
1.65.0
What was the last working version of HomematicIP (local)?
No response
What type of installation are you running?
Home Assistant Container
What type of installation are you running for your homematic backend?
CCU3
Which version of your homematic backend are you running?
No response
What hardware are you running for your system?
Pi5
Which config details do you use

[ ] TLS
[ ] callback data (see)

Which interfaces do you use?

[X] Homematic IP
[ ] Homematic (Bidcos-RF)
[ ] Groups (Heating-Group)
[ ] BidCos-Wired (HM-Wired)

Diagnostics information (no logs here)
No response
Log file extract. Anything in the logs that might be useful for us? The log (Setting/System/Logs -> load full log) is the best source to support trouble shooting!
AttributeError: 'NoneType' object has no attribute 'color'
2024-09-07 21:58:09.817 ERROR (MainThread) [homeassistant.components.scene] Error adding entity scene.wohnbereich_nachtlicht for domain scene with platform hue
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/homeassistant/helpers/entity_platform.py", line 595, in _async_add_entities
    await coro
  File "/usr/local/lib/python3.12/site-packages/homeassistant/helpers/entity_platform.py", line 909, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/local/lib/python3.12/site-packages/homeassistant/helpers/entity.py", line 1366, in add_to_platform_finish
    self.async_write_ha_state()
  File "/usr/local/lib/python3.12/site-packages/homeassistant/helpers/entity.py", line 1005, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/local/lib/python3.12/site-packages/homeassistant/helpers/entity.py", line 1130, in _async_write_ha_state
    self.__async_calculate_state()
  File "/usr/local/lib/python3.12/site-packages/homeassistant/helpers/entity.py", line 1071, in __async_calculate_state
    if extra_state_attributes := self.extra_state_attributes:
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/homeassistant/components/hue/scene.py", line 189, in extra_state_attributes
    "is_dynamic": self.is_dynamic,
                  ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/homeassistant/components/hue/scene.py", line 133, in is_dynamic
    if self.resource.palette.color and len(self.resource.palette.color) > 1:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'color'
2024-09-07 21:58:09.821 ERROR (MainThread) [homeassistant.components.scene] Error adding entity scene.schlafzimmer_gedimmt for domain scene with platform hue
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/homeassistant/helpers/entity_platform.py", line 595, in _async_add_entities
    await coro
  File "/usr/local/lib/python3.12/site-packages/homeassistant/helpers/entity_platform.py", line 909, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/local/lib/python3.12/site-packages/homeassistant/helpers/entity.py", line 1366, in add_to_platform_finish
    self.async_write_ha_state()
  File "/usr/local/lib/python3.12/site-packages/homeassistant/helpers/entity.py", line 1005, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/local/lib/python3.12/site-packages/homeassistant/helpers/entity.py", line 1130, in _async_write_ha_state
    self.__async_calculate_state()
  File "/usr/local/lib/python3.12/site-packages/homeassistant/helpers/entity.py", line 1071, in __async_calculate_state
    if extra_state_attributes := self.extra_state_attributes:
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/homeassistant/components/hue/scene.py", line 189, in extra_state_attributes
    "is_dynamic": self.is_dynamic,
                  ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/homeassistant/components/hue/scene.py", line 133, in is_dynamic
    if self.resource.palette.color and len(self.resource.palette.color) > 1:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'color'
2024-09-07 21:59:06.381 WARNING (MainThread) [homeassistant.bootstrap] Waiting on integrations to complete setup: {('homematicip_local', '01J4Z9D5ZNAKXDJRX7VD11D6NS'): 1146063.472337438}
2024-09-07 22:00:06.463 WARNING (MainThread) [homeassistant.bootstrap] Waiting on integrations to complete setup: {('homematicip_local', '01J4Z9D5ZNAKXDJRX7VD11D6NS'): 1146063.472337438}
2024-09-07 22:01:06.546 WARNING (MainThread) [homeassistant.bootstrap] Waiting on integrations to complete setup: {('homematicip_local', '01J4Z9D5ZNAKXDJRX7VD11D6NS'): 1146063.472337438}
2024-09-07 22:02:06.624 WARNING (MainThread) [homeassistant.bootstrap] Waiting on integrations to complete setup: {('homematicip_local', '01J4Z9D5ZNAKXDJRX7VD11D6NS'): 1146063.472337438}
2024-09-07 22:06:41.590 WARNING (MainThread) [hahomematic.caches.dynamic] Pending PONG mismatch: There is a mismatch between send ping events and received pong events for HA instance ccu3-HmIP-RF. Possible reason 1: You are running multiple instances of HA with the same instance name configured for this integration. Re-add one instance! Otherwise this HA instance will not receive update events from your CCU. Possible reason 2: Something is stuck on the CCU or hasn't been cleaned up. Therefore, try a CCU restart.Possible reason 3: Your setup is misconfigured and HA is not able to receive events from the CCU.
2024-09-07 22:06:41.600 WARNING (MainThread) [hahomematic.caches.dynamic] Pending PONG mismatch: There is a mismatch between send ping events and received pong events for HA instance ccu3-BidCos-RF. Possible reason 1: You are running multiple instances of HA with the same instance name configured for this integration. Re-add one instance! Otherwise this HA instance will not receive update events from your CCU. Possible reason 2: Something is stuck on the CCU or hasn't been cleaned up. Therefore, try a CCU restart.Possible reason 3: Your setup is misconfigured and HA is not able to receive events from the CCU.
2024-09-07 22:06:41.605 WARNING (MainThread) [hahomematic.caches.dynamic] Pending PONG mismatch: There is a mismatch between send ping events and received pong events for HA instance ccu3-VirtualDevices. Possible reason 1: You are running multiple instances of HA with the same instance name configured for this integration. Re-add one instance! Otherwise this HA instance will not receive update events from your CCU. Possible reason 2: Something is stuck on the CCU or hasn't been cleaned up. Therefore, try a CCU restart.Possible reason 3: Your setup is misconfigured and HA is not able to receive events from the CCU.

Additional information
No response

Home Assistant Container

Please read the docs and search for Docker. Your CCU is not able to send events to HA.

Can this be closed?

I guess this can be closed.


Documentation section of Non-Software Licenses has no links.

https://choosealicense.com/non-software/#documentation
It states "Any open source software license or open Creative Commons license", however it offers no assistance in finding those.  Technically a couple of Creative Commons licenses were mentioned in the previous section (data/media), but only by short name (ex. CC-BY-4.0) so uninformed users likely won't even know they are Creative Commons licenses.  The result is that it is more effective to google "Creative Commons" at that point if you want to find licenses because there is no quick way to the Appendix which is the only place to get the information.
I think either more links or license details would be the solution, but I am not sure what the best implementation would be.

Thanks for the close read @adamvoss. Let me know if #522 helps.


Scrutinizer Auto-Fixes

@robiso requested this pull request.
It consists of patches automatically generated for this project on Scrutinizer:
https://scrutinizer-ci.com/g/robiso/wondercms/

Adding concatenation back. Thanks @NicolasCARPi!


Possible to read csv to nested data class hierarchy?

Is it possible to have something like this:
data class Parent(
  val child: Child
)

data class Child(
  val age: Int
)

val df = DataFrame
        .readCSV(inputCsv)
        .convertTo<Parent>()

Maybe there is some way to specify how the fields are nested using the headers =  parameter?

Hi! I would split the problem into two parts:

Read CSV into a dataframe with nested hierarchy. Here we have two options:
i) read flat CSV and use https://kotlin.github.io/dataframe/group.html to create nesting.
ii) if cells of your CSV contain JSON values, then dataframe will read them into ColumnGroup (value is object) or FrameColumn (value is array of objects). It's not mentioned in the current version of the documentation, i will publish an update :)
Get a list of a data class instances from the dataframe with nested hierarchy: https://kotlin.github.io/dataframe/collectionsinterop.html#interop-with-data-classes


(BRK-452) Use Platform To Get Code Name

The unix/pkg.rb had its own mapping of platform to debian code name. However, this is available through the Platform class. This commit removes the duplicate data in pkg.rb and uses self['platform'].codename in its place.

:+1:

Just waiting on test results.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/1367/
Test FAILed.

Failure unrelated to patch.


Fixed test of whether or not current session is interactive

Exisitence of a tty is not sufficient condition to determine whether a bash session is interactive or not.  Checking if shopts have emacs or vi turned on is a better test.

Thanks!


Guna Theme forces Sublime Text closed unless project file preloaded

I did not see anything about this in the docs or in the other issue reports, so forgive me if this is a known side effect, or there's a reason for this behavior that is intentional.  For the last two or three years, I have noticed Sublime shut down immediately every time I try to open it without an active project preloaded.  If I closed the last project I was working on via "close project" (as opposed to a hot exit), then next time I try to open the app as a single blank file, Sublime instantly closes.  And then continues on doing so until I eventually open it as a project file, a workspace file, or (if I recall) from a folder.
I remember thinking at some point that Sublime did not behave like this when I first got it.  But I could not recall that anything had changed and the behavior had followed me across operating systems (Windows 10, Ubuntu, Mint, and back to Windows). It was consistent, so I chalked it up to some weird quirk of Sublime.
But one thing I forgot to take into account is I have been using Guna almost religiously during that same time. Today, as I was reinstalling Sublime back on Windows (I am hard on my OS's), I finally noticed that adding Guna is what causes the issue, at least in combination with my other settings.
In the event that this is a new issue, I am pasting the state my system settings here, or at least the list of apps I had installed and my default settings that the error occurred in.  If that does not trigger it for you, just let me know what other information would be helpful and I will send it your way.
Package Control.sublime-settings (I had just added these apps in small batches so they would not error out. They seemed to work fine out of the above-referenced context):
{
	"bootstrapped": true,
	"in_process_packages":
	[
	],
	"installed_packages":
	[
		"A File Icon",
		"Agila Theme",
		"ayu",
		"Babel",
		"Bash Build System",
		"BracketHighlighter",
		"ClearConsole",
		"Color Highlight",
		"ColorPicker",
		"ColorSchemeEditor",
		"Colorsublime",
		"Compare Side-By-Side",
		"CSSLint",
		"DotENV",
		"Dotfiles Syntax Highlighting",
		"Expand Selection to Quotes",
		"FindKeyConflicts",
		"GoToPoint",
		"Gruvbox Dark",
		"Guna",
		"Gutter Color",
		"Jest",
		"JsPrettier",
		"LiveReload",
		"MarkdownLivePreview",
		"Naomi",
		"Notes",
		"Origami",
		"Package Control",
		"PackageResourceViewer",
		"PostgreSQL Syntax Highlighting",
		"RegReplace",
		"Select Quoted",
		"SideBarEnhancements",
		"SideBarTools",
		"SnippetMaker",
		"sublime-text-2-buildview",
		"Terminal",
		"Theme - Bamboo",
		"Toggle Words",
		"TypeScript",
		"TypeScript Syntax",
		"Wrap Plus"
	]
}

And here are my settings, without Guna.  They seemed to not cause any issues on their own.:
{
	"auto_complete": true,
	"binary_file_patterns":
	[
		".svn/",
		".git/",
		".next/",
		"node_modules/",
		"bower_components/"
	],
	"bold_folder_labels": true,
	"caret_extra_bottom": 1,
	"caret_extra_top": 1,
	"caret_extra_width": 1,
	"caret_style": "blink",
	"characters": ".",
	"close_windows_when_empty": true,
	"color_scheme": "Packages/User/Themes/1_oceanic-reef.tmTheme",
	"default_line_ending": "unix",
	"ensure_newline_at_eof_on_save": true,
	"fade_fold_buttons": false,
	"file_exclude_patterns":
	[
		"*.a",
		"*.class",
		"*.db",
		"*.dll",
		"*.docx",
		"*.dylib",
		"*.exe",
		"*.idb",
		"*.lib",
		"*.ncb",
		"*.o",
		"*.obj",
		"*.pdb",
		"*.psd",
		"*.pyc",
		"*.pyo",
		"*.sdf",
		"*.so",
		"package-lock.json",
		"*.sublime-workspace",
		"*.suo",
		".DS_Store",
		".floo",
		".flooignore",
		"desktop.ini"
	],
	"folder_exclude_patterns":
	[
		".svn",
		".git",
		".hg",
		"CVS"
	],
	"font_size": 9,
	"gn_hide_tab_dropdown": true,
	"gn_overlay_scroll_bars": true,
	"gn_sb_cnvx": true,
	"gn_sidebar_box": true,
	"gnwidg1": true,
	"highlight_line": true,
	"ignored_packages":
	[
		"AutoFoldCode",
		"Colorsublime",
		"Fold Comments",
		"MarkdownLivePreview",
		"SideBarEnhancements",
		"sublime-text-2-buildview",
		"Vintage"
	],
	"indent_guide_options":
	[
		"draw_active"
	],
	"indent_subsequent_lines": true,
	"indent_to_bracket": true,
	"line_padding_bottom": 2,
	"line_padding_top": 1,
	"margin": 2,
	"match_brackets": true,
	"match_brackets_angle": false,
	"match_brackets_braces": true,
	"match_brackets_content": true,
	"match_brackets_square": true,
	"overlay_scroll_bars": "enabled",
	"remember_full_screen": true,
	"show_full_path": false,
	"smart_indent": true,
	"tab_size": 2,
	"theme_accent_numix": true,
	"theme_bar_logo_atomized": true,
	"theme_grid_border_size_sm": true,
	"theme_icons_materialized": true,
	"theme_scrollbar_semi_overlayed": true,
	"theme_sidebar_close_always_visible": true,
	"theme_sidebar_folder_atomized": true,
	"theme_sidebar_font_lg": true,
	"theme_sidebar_heading_bold": true,
	"theme_sidebar_indent_top_level_disabled": true,
	"theme_sidebar_indent_xl": true,
	"theme_sidebar_size_xs": true,
	"theme_tab_font_lg": true,
	"theme_tab_selected_prelined": true,
	"theme_tab_width_auto": true,
	"theme_unified": true,
	"translate_tabs_to_spaces": true,
	"trim_trailing_white_space_on_save": true,
	"use_tab_stops": true,
	"word_wrap": false,
	"wrap_width": 0
}

I thought maybe color scheme and theme had to match, but swapping the following line out for the other color scheme above did not cause a problem.
"color_scheme": "Packages/Guna/themes/Guna.tmTheme",

But adding the following theme line did cause the problem consistently:
"theme": "Guna.sublime-theme",

I've never heard or seen that :-(. Is there any log for that ?

I tried to recreate it again in linux mint.  It happened, then stopped happening after I toggled the theme on and off a little bit.  Regardless, here is the log when it broke.  Anything in there look helpful?  If not,  I can poke around the Sublime on my Windows boot next week and see if I can get something more helpful for you.
Traceback (most recent call last):
  File "/opt/sublime_text/sublime_plugin.py", line 627, in on_activated_async
    callback.on_activated_async(v)
  File "C:\Users\pouco\AppData\Roaming\Sublime Text 3\Packages\Guna\core\engine.py", line 984, in on_activated_async
  File "C:\Users\pouco\AppData\Roaming\Sublime Text 3\Packages\Guna\core\engine.py", line 984, in <genexpr>
AttributeError: 'NoneType' object has no attribute 'endswith'
font face "Roboto Condensed" could not be found, defaulting to "Monospace"
reloading settings Packages/User/Preferences.sublime-settings
reloading settings Packages/User/Preferences.sublime-settings
reloading settings Packages/User/Preferences.sublime-settings
reloading settings Packages/User/Preferences.sublime-settings

...actually, that's weird.  Why is it saying "C:\Users\pouco\Appdata"?  That's not a directory on my computer.

The log above doesn't look like a crash log. When I testing, (open project, switch project, ...), sometimes Sublime suddenly quits and generates .dmp file, but it is hard to reproduce it. In the sublime forum, there are many crash reports related with project. - https://forum.sublimetext.com/search?q=crash project. I'm not sure it is Guna's problem. Could you summarize crash situation to reproduce in my computer ? Save Project > Close Project > Open Project ?

I think this issue is caused by a race condition, which can happen if a file is quickly opened and closed in a transient view.
If the view gets closed while the asynchronous event handler on_activated_async() loops trough any(view.file_name().endswith(p) for p in lock_file_path) the exception above is raised.
The reason is calling view.file_name() repetitively in the loop.
The current code is:
    def on_activated_async(self, view):
        if isinstance(view.file_name(), str):
            if any(view.file_name().endswith(p) for p in lock_file_path):
                view.set_read_only(True)
        check_status(prefs=None, view=view)
        return

To avoid that issue, you should cache the file name read via API. It would also reduce the number of API calls for better runtime efficiency. The view.file_name() always returns None or a string. So the isinstance() may not be needed as well.
    def on_activated_async(self, view):
        file_name = view.file_name()
        if file_name:
            if any(file_name.endswith(p) for p in lock_file_path):
                view.set_read_only(True)
        check_status(prefs=None, view=view)
        return

@deathaxe , How can you know that codes, did you decompile ?

Just familiar with python's byte code ;-)


Pre W10 support?

Is this library supposed to work on Windows 8 or Windows 7?

Yes, it should. Are you running into any issues?

We've focused on making Microsoft.Wpf.Interop.Directx.dll build with either the DirectX SDK (June 2010) or the Windows 10 SDK. Should run fine on those dev machines.
For runtime machines, the dll distributed in the NuGet package may have some dependencies that we need to describe. Please let us know details of any exceptions that you are seeing, that may point to the missing binaries. (We'll go test again as well.)

It was my fault. I used wpf interop dll that I compiled. When I replaced it with dll from your nuget package, all is fine.
Sorry for the false alarm...

Great. Closing then.


feat: base flow for the reviews tab

Still needs a fair amount of refactors and improvements, but it's a decent start.

Rebased to latest main and re-tested, appears to be working as expected still.


ImageDisposeTest.ImageReleasedAfterFrame flaking on Linux Fuchsia FEMU

Looks like it is timing out
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux Fuchsia FEMU/4124/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux Fuchsia FEMU/4115/overview
/cc @dnfield

This test will be removed once I finish more of the picture dispose work.
I'd be fine with disabling it for now on fuschia

@iskakaushik, @dnfield is out this week, could you take a look at disabling?
/cc @arbreng @chaselatta

Can we get a bug to re-enable or to remove whatever workaround is put into place?
Bugs are not being created for this and workarounds just remain in the code with TODO(ldap)

Bug is https://github.com/flutter/flutter/issues/81514

The AI seems to be to disable the test, reword this issue to reflect re-enabling it after https://github.com/flutter/flutter/issues/81514 lands.

Sure, it has been less flaky today. We can drop the priority and keep an eye on the tree.

This came up again this morning. Disabling here https://github.com/flutter/engine/pull/26686


[OTHER]: Links are not clickable in caption and post

What would you like to share?
In the past, it was possible to click on links embedded within post content and captions. Unfortunately, it appears that this feature has been unintentionally removed. If not removed intentionally, I would like to address this issue and work on reinstating the ability to click on links again.
Additional information
No response

yes exactly, glad you remembered, I was also going to raise the issue, can you add it back from pr #486 and test it again?
thanks


Error MSB3202 .. AspNet5DemoApp.xproj.metaproj not found

I tried deploying a completely unchanged version of this project to heroku and I get the following error upon deploying.
There is no metaproj file and I'm not sure if the build script is trying to create one and failing? What should this file contain? I don't understand the build process well enough to debug this further,.
Any help would be much appreciated.
remote: /tmp/build_bb0646bd8303182f6bd73ce264103dff/dotnet/sdk/1.0.0-preview5-00
4232/NuGet.targets(164,5): error MSB3202: The project file "/tmp/build_bb0646bd8
303182f6bd73ce264103dff/src/AspNet5DemoApp/AspNet5DemoApp.xproj.metaproj" was no
t found. [/tmp/build_bb0646bd8303182f6bd73ce264103dff/AspNet5DemoApp.sln]
remote:  !     Push rejected, failed to compile ASP.NET Core app.
remote:
remote:  !     Push failed
remote: Verifying deploy...
remote:
remote: !       Push rejected to ****.
remote:
Warning: Your console font probably doesn't support Unicode. If you experience s
trange characters in the output, consider switching to a TrueType font such as C
onsolas!
To https://git.heroku.com/.git
! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'https://git.heroku.com/.git'

@rolandh is It still actual? Can I help you?

Too long ago. I no longer am testing out heroku but thank you for the reply.


[Android] _receiveCallEvent function does not triggered when the app is in terminated state

I'm using flutter_callkit_incoming version 2.0.4 with Flutter 3.19.2 on android and this function does not triggered in terminated state
for more context, before I upgraded my project to Flutter 3.19.2, I use Flutter 3.7.3 and _receiveCallEvent were triggered even when the app is in terminated state

I faced only in one plus device


WIP JDK 21

https://issues.apache.org/jira/browse/SOLR-XXXXX
Gradle 8.4 supports JDK 21 https://github.com/apache/solr/pull/1997
ecj 3.35.0 doesn't support JDK 21 yet
> Task :solr:api:ecjLintMain FAILED
source level should be in '1.1'...'1.8','9'...'20' (or '5.0'..'20.0'): 21

@risdenk can this be closed? There is also https://github.com/apache/solr/pull/2804 for ECJ.

@risdenk can this be closed? There is also #2804 for ECJ.

yup closing


remove root's package.json @types/react and @types/react-dom

probably should do this with most @types packages for the sake of typescript users


Updated italian translation

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Fixed issues
Updated italian translation

@enricodetoma Could you re-open your PR here? https://github.com/dabilite/yii2-user/pulls so we can merge it? Thanks a lot for your effort.

Done!

Merged into https://github.com/dabilite/yii2-user/pull/8 - issue can be closed. Thanks a lot for the translation!


azure.identity.InteractiveBrowserCredential: good/bad token depends on calling order

azure-identity==1.2.0
azure-keyvault-secrets==4.0.1
Windows 10
python 3.6.10
After creating a credential object from InteractiveBrowserCredential(), if I immediately call credential.get_token(), then the returned token can successfully be used with Microsoft Graph API.
However, if I first use the credential for a SecretClient get_secret() call, and then do the credential.get_token() call, the returned token cannot be used with Graph API - the following error is returned:

"{'error': {'code': 'InvalidAuthenticationToken', 'message': 'Access token validation failure. Invalid audience.', 'innerError': {'request-id': '09fc35e4-56ba-4740-a993-a0379c5ca524', 'date': '2020-03-10T21:03:23'}}}"

My Graph API call:
    endpoint =  "https://graph.microsoft.com/v1.0/me"
    headers = {'Authorization': 'Bearer ' + token}

    graph_data = requests.get(endpoint, headers=headers).json()
    upn = graph_data["userPrincipalName"]

Expected behavior
I expect the Graph API to work, independent of when I call get_token().
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Not a blocking problem, but seems related to another problem where, when using
DeviceCodeCredential(), the call to get_context() requires a 2nd authentication.

Access tokens are scoped to resources. A token for Key Vault isn't valid for Graph. You're sending Key Vault tokens to Graph. Here's why:

get_secret provokes a request for a Key Vault access token
that access token is cached
you call get_token(), specifying no scope
the cache searches for an access token matching the requested scopes
You didn't specify any scope. By the cache's logic, any access token matches.
the cache returns the Key Vault token

It works the other way round, Graph then Key Vault, because SecretClient specifies the Key Vault scope every time it calls get_token. Also, when you call get_token() with no scope, the code which ultimately requests the token (it doesn't live in azure-identity) chooses default scopes for you. Those defaults evidently satisfy the Graph APIs you use.
Which is all to say you should be able to solve this problem by specifying the Graph scopes you need in your get_token calls.
Thanks for opening this issue. I hadn't previously considered the consequences of calling get_token(), because service clients in the SDK never do it (get_token was designed for them alone). I think default scopes are more confusing than helpful, so get_token should force callers to be specific about what they're requesting access to. It should raise an error when no scope is specified.

Thanks again for opening this issue. I'm closing it as resolved by #10366.


Bluetooth: gatt: allow the CCCD to be in any location

Per spec, the CCCD doesn't necessarily have to be located immediately after
the characteristic value. This commit fixes that assumption when checking
for subscriptions.
Fixes #48880.
Also introduces a Kconfig option to disable the subscription checking, since that is not mandated by spec.

@alwa-nordic @jhedberg please take a look


Ability to choose between banner and alert notifications

Right now all notifications on macOS are being posted as alert-style notifications, which means the notifications always show buttons and stay onscreen until dismissed. This should only happen for important events. It should be possible to post a banner notification without having the user change the app's notification permissions in System Preferences.

I think this is something that is needed from upstream in https://github.com/julienXX/terminal-notifier


[Feature] Make it possible to extend classes

First, thank you for the great package!
I am dealing with multiple database schemas (multiple tenants), and I want to run the scout:import command on multiple connections. I would usually extend from the base ImportCommand, change my connections and call the parent to handle the rest.
However, the ImportCommand class is final and I cannot extend it.
Is there any particular reason why the class is final?
I ended up making a custom command scout:import-tenant that internally calls the package's command. But it would be nice if I could just extend the command, add my options and call the parent.

Hello) Thanks for good question and kind words!
The reason for classes to be final is I don't think It's good idea to extend third party classes. Of course some times it have a place, sometimes no advantages in it but in general I make them final at first. Also I want to know what is the case to extend a class. Then I can to redesign the package to improve it.
In this case you can create a new command and call ImportCommand from the code. Does it solve your issue?

Hey @matchish
I was tinkering with this yesterday and I realize my use case is a bit more complex and I won't be able to use the ImportCommand out of the box anyways.
My use case is:
We have multiple database schemas - one for each customer. My strategy for indexing with elasticsearch for now is to use the same index across customers, providing an additional property with the customer id/slug, and then making an alias for the index that has the customer filter already applied, so I can just query with that.
This also means that in order to make the initial indexing, I need to run the scout:import command multiple times - once for each customer. So I want to loop over the database connections and import the data. However, the ImportCommand deletes the indexes before it imports. So on each new call for each customer, the previous customer's data would be overwritten and so on.
I don't want to write all this from scratch because you've done so much great work here! So I might do something dirty and use some of your internal classes to make what I want, locking my composer version to a commit :D
I did try to make my own Import class which uses less of the ImportStages for subsequent customers, but I somehow ended up only with having the data of the first and second customers indexed, and not all the rest. So I have to look a bit more into it to see what's happening.
In any case, back to my original issue - yes, I called your command from my own custom command, which meant I have to change the signature. So that's why it would've been nice if I extended your command, appended something to the signature, and had access to your command as a parent.
But I don't think that will even help in my case, because I need different functionality in the Import all together. So feel free to close this.
I also welcome any tips you might have on achieving what I described above 😃

Take a look in https://github.com/matchish/laravel-scout-elasticsearch/blob/f65731880ac8c2c42c6790e8917550cdca8e30ab/src/Searchable/DefaultImportSource.php#L49
You can combine your models with different connections there, and chunk all your models. Then it will be imported in the same index.

Here is example how to inject your ImportSource
https://github.com/matchish/laravel-scout-elasticsearch/tree/f65731880ac8c2c42c6790e8917550cdca8e30ab#eager-load

@matchish Oh, that might actually work! I'm gonna try to switch the connections in there. Don't know why I didn't think about it - thank you.
As for why I wasn't seeing some of my data - figured I need a custom scout key because of collisions across schema, so I'm adding me some uuid columns.
Thanks again!


Add Bahasa Indonesia Link

Issue #37

(Duplicate of #38)

I will close this PR first and fixed that typo, sorry

@mazipan please modify the open PR instead of making yet another PR to clutter the repo :-/


Option to choose begin/end time of the day

My problem is that since i usually go to sleep at 2am, if i want to track also the 0am-2am part of the day, i don't have their events at first glance, i have to scroll up in the weekly view, and change day in the day view, which is very inconvenient and uncomfortable since i have to do this every day.
I don't know how much work is this since i didn't see the code, but it would be useful to add an option to choose the time when each day begins/ends.

I'm not sure if it's possible to push the end of the day back past midnight. But if it is, it would be configured with slotMinTime and slotMaxTime settings (documentation here). Will require a bit of investigation.

I was able to achieve this effect by modifying calendar.ts, as you suspected @davish.

By setting the slotMaxTime to some length > 24 hours e.g. 28 hours, the extra ours are shown at the end of the day. Adding events seems to work fine and they are displayed in both the after-hours section they were added and also the morning of the following day. By setting the day length to 24hr but offset by some amount of time we could probably achieve what OP wants.
This could be worked up into a settings option relatively easily.


LogExchange.initStringCodecs shows up with about 10% in sbt startup time

That's for the akka-http sbt 1.0 build (commit https://github.com/akka/akka-http/commit/da0060d3bbf46efdb9e7727db590484db5bb763f on akka-http)
The code in question uses TypeTags which initializes scala.reflect.runtime.universe which takes most of the time. If that universe is not used elsewhere some time could be saved by not using TypeTag, maybe StringTypeTag could be made a macro and calculated at compile time instead of when sbt is run?

I'm guessing this has been addressed by https://github.com/sbt/util/pull/153.


fix: StoryblokBridge to be constructable

Updates the Type for StoryblokBridge to be constructable
meaning that now you can actually do new StoryblokBridge({ ...options })

It looks ok to me, what do you think @mmatheuspalma @thiagosaife ??


Client Allocation Request for: OGS

Client Allocation Questions
Core Information

Name: OGS
Website / Social Media: http://www.ogs.com.vn/
Region: Asia excl. Greater China
DataCap Requested: 10TiB
Addresses to be Notarized: f17puvt5i5vtxmryxw4yqthnv45wn6vrtsgkqdutq
Notary Requested: rayshitou

@dalicejor Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

@dalicejor Thanks for your application. Please answer the following questions to let me know you and your company.
1.What's your name and your position in your company?What's your company's business?
2.Could you show me your company's business license? And please show me your company searching consequence in the local business license searching website.
3.Have you/your company ever used cloud? Which platform do you use? What's your usage volume and frequency? Could you please show me your cloud usage evidence?


Invalid Upload Request on host web

my laravelFileManager works fine on local but when i upload project to my host its not work properly.
my host directory is this :
->home/
->laravelfiles
->public_html
when i upload image in filemanager makes folders but not upload image on my host.
my lfm.php :
'base_directory' => 'public_html',
'images_folder_name' => 'photos',
'files_folder_name' => 'files',
'shared_folder_name' => 'shares',
'thumb_folder_name' => 'thumbs',

Seems similar to #206

thank u  @mortza
its work fine, and upload image,create image in "public_html/photos/4" on my directAdmin.
but its not show....

???

What is the output of following command
$ curl -I yourdomain.com/photos/4/1.jpg -k

I guess above path from your comment and uploaded image, replace photos/4/1.jpg with path of an image you think uploaded via LFM

Where to enter the above command in directAdmin?
can i give you directAdmin access via email and check it?
image link in upload page is "/laravel-filemanager/photos/4/thumbs/1.jpg" but in DirectAdmin is "/photos/4/thumbs/1.jpg". when delete "/laravel-filemanager" in url shows image.

Where to enter the above command in directAdmin, @mortza ?

if you're using xampp on windows open %xampp_dir%/xampp_shell.bat and type command.

can i give you directAdmin access via email and check it?

you can find my email on github page link in my profile but solution to the problem should submitted here for other people facing this problem.

image link in upload page is "/laravel-filemanager/photos/4/thumbs/1.jpg" but in DirectAdmin is "/photos/4/thumbs/1.jpg". when delete "/laravel-filemanager" in url shows image.

in /laravel-filemanager/photos/4/thumbs/1.jpg /laravel-filemanager corresponds to lfm.url_prefix option, it isn't path to image.

hello I found solution for this problem that happen in DirectAdmin Shared host you can manually fix this problem with lfmHelpers just in getThumbUrl() and getFileUrl() method change to
return str_replace('laravel-filemanager/','',$this->getFileUrl($image_name, 'thumb'));
return str_replace('laravel-filemanager/','' ,url($this->composeSegments('url', $is_thumb, $image_name)));
now you can see thumbnails...

Thank you so mush, Solved problem.

Thanks @mortza and @saberap .

hello I found solution for this problem that happen in DirectAdmin Shared host you can manually fix this problem with lfmHelpers just in getThumbUrl() and getFileUrl() method change to
return str_replace('laravel-filemanager/','',$this->getFileUrl($image_name, 'thumb'));
return str_replace('laravel-filemanager/','' ,url($this->composeSegments('url', $is_thumb, $image_name)));
now you can see thumbnails...

Thank you so mush, Solved problem.

where do I put the return script?


The flutter project path in AndroidStudio contains Chinese characters, resulting in a compilation failure

11:02:22.645 499 info flutter.tools [+1088 ms] CocoaPods' output:
11:02:22.645 500 info flutter.tools            ↳
11:02:22.645 501 info flutter.tools [        ]       Preparing
11:02:22.645 502 info flutter.tools
11:02:22.645 503 info flutter.tools                Analyzing dependencies
11:02:22.645 504 info flutter.tools
11:02:22.645 505 info flutter.tools                Inspecting targets to integrate
11:02:22.645 506 info flutter.tools                [!] Could not automatically select an Xcode project.

Update the problem, not because of the Chinese path, but because the project external hard disk, but I have not found how to repair

Hi, sorry for the delay, I just want to check if you could solve this problem.

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


[BUG] AesStream Invalid Password exception for corrupted log/data file

Version
LiteDB version - v5.0.16
OS - Windows 11 (22H2 OS Build 22621.1992)
.NET version - .NET 6, .NET 462
Describe the bug
While creating a new data/log file, AesStream can potentially create a corrupted "hidden" page. Following is the corruption pattern in hidden page:

Byte 0 : 1
Byte 1-16:  salt
Bytes 17-8191: 0

The occurrence of this corruption is very rare, however, the data/log file becomes irrecoverable and always throws "Invalid Password" exception.
Code to Reproduce
Simple code to create a new database with a collection called "User" and perform Insert operation.
using (var db = new LiteDatabase(new ConnectionString("FileName=test.litedb;Password=Test1234!;Connection=shared")))
{
      var collection = db.GetCollection<User>();
      collection.Insert(new User { Name = "TestUser" });
}

Reproduction of this issue requires dev to add a breakpoint to AesStream ctor and terminate the program as soon as breakpoint is hit for the first time.
Breakdown of issue that happens while AesStream creates new "hidden" page, and application terminates abruptly:

Write bytes[0] as 1 - This is done to indicate that the stream is encrypted
Write bytes[1..16] with Salt
Fill bytes[17-8191] with 0 - This is done to add padding the stream to make the length equivalent to PAGE_SIZE
Set position to 32 for writing encrypted 1s to the stream.
Setting position of stream causes it to write to disk. This behavior was confirmed using Process Monitor tool.
Terminate the program at this point.
File of size 8KB is created, where bytes[17..8191] are empty.

Expected behavior

Should not fill bytes[17-8191] with 0 to make it a multiple of PAGE_SIZE. The code seems to be capable of handling scenarios where length of stream is less than PAGE_SIZE.
Should be able to recover itself from corrupted state.

Screenshots/Stacktrace
Stack Trace of Invalid Password Exception:
Unhandled exception. LiteDB.LiteException: Invalid password
   at LiteDB.Engine.AesStream..ctor(String password, Stream stream) in C:\stash\LiteDB\LiteDB\Engine\Disk\Streams\AesStream.cs:line 129
   at LiteDB.Engine.FileStreamFactory.GetStream(Boolean canWrite, Boolean sequencial) in C:\stash\LiteDB\LiteDB\Engine\Disk\StreamFactory\FileStreamFactory.cs:line 56
   at LiteDB.Engine.StreamPool.<>c__DisplayClass3_0.<.ctor>b__0() in C:\stash\LiteDB\LiteDB\Engine\Disk\StreamFactory\StreamPool.cs:line 29
   at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
   at System.Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.get_Value()
   at LiteDB.Engine.StreamPool.get_Writer() in C:\stash\LiteDB\LiteDB\Engine\Disk\StreamFactory\StreamPool.cs:line 35
   at LiteDB.Engine.DiskService..ctor(EngineSettings settings, Int32[] memorySegmentSizes) in C:\stash\LiteDB\LiteDB\Engine\Disk\DiskService.cs:line 53
   at LiteDB.Engine.LiteEngine..ctor(EngineSettings settings) in C:\stash\LiteDB\LiteDB\Engine\LiteEngine.cs:line 70
   at LiteDB.SharedEngine.OpenDatabase() in C:\stash\LiteDB\LiteDB\Client\Shared\SharedEngine.cs:line 63
   at LiteDB.SharedEngine.Insert(String collection, IEnumerable`1 docs, BsonAutoId autoId) in C:\stash\LiteDB\LiteDB\Client\Shared\SharedEngine.cs:line 214
   at LiteDB.LiteCollection`1.Insert(T entity) in C:\stash\LiteDB\LiteDB\Client\Database\Collections\Insert.cs:line 20
   at Test.Program.Main(String[] args) in C:\stash\LiteDB\Test\Program.cs:line 13

test.litedb file after performing the reproduction steps (all bytes are empty after the 17th byte):

PR #2344 contains the fix


[featureVars] don't overwrite FeatureVariations, append new records

Currently, addFeatureVariationsRaw always deletes existing GSUB.FeatureVariations and overwrites them with the newly built records.
https://github.com/fonttools/fonttools/blob/0b05cec0a345fc9d912170f1fa811215ae54579c/Lib/fontTools/varLib/featureVars.py#L352
It doesn't have to, though. If the features for which we are adding feature variations are not already "variable", we can simply append the new DS-rules-generated records to the existing FeatureVariations list.
We can raise an error if the existing FeatureVariations already reference the same feature tags used by the DS rules, as that could generate ambiguity/undefined logic.

Also note, feaLib itself is using addFeatureVariationsRaw method in a for loop, for each feature tag for which the FEA has conditionsets defined:
https://github.com/fonttools/fonttools/blob/0b05cec0a345fc9d912170f1fa811215ae54579c/Lib/fontTools/feaLib/builder.py#L972-L975
that means currently only the last one will prevail, since addFeatureVariationsRaw always resets the GSUB.FeatureVariations = None before creating the new records.
With this PR, it will no longer do so.

Thanks Just, I'm writing some tests now


feat(ApplicationCommands): attachment application command option type

Please describe the changes this PR makes and why it should be merged:
This pr adds the types for the ATTACHMENT application command option type

[x] update ApplicationCommandOptionType enum in both v8 and v9
[x] add ApplicationCommandInteractionDataOptionAttachment type to both v8 and v9
[ ] wait for https://github.com/discord/discord-api-docs/pull/4253 to be merged

Reference Discord API Docs PRs or commits:
this PR relies on https://github.com/discord/discord-api-docs/pull/4253

NOTE: this is my first time contributing to this project so if anything is wrong please do tell me

You may want to rerun the build:deno script

I get no output:

You're not gonna get output from the script, but you'll get changed files

You're not gonna get output from the script, but you'll get changed files

Oh ok, my commit was made after the command so I missed what changed. But ig as long as it didn't error it's fine right?

Upstream PR merged 🍕


SpotBugs nullness analysis interaction

Information at:

All NP_ bug patterns: https://spotbugs.readthedocs.io/en/latest/bugDescriptions.html?highlight=NP_
https://github.com/spotbugs/spotbugs/tree/master/spotbugs/src/main/java/edu/umd/cs/findbugs/ba/npe

I didn't find a concise summary of the SpotBugs behavior...

Kengo, just open specific issues when something comes up.


Use Vue.js for some complex features

Following #6493

It looks like Vue.js checks all the boxes:

no custom JSX nor build changes
injection via web components specified in JSX (.append(<dynamic-stuff/>))
access to multiple parts of the page from a single widget, via native selector support

See in the example:  https://codepen.io/fregante/pen/mdapqEo?editors=0011

We can append a <my-vue-element> element to the page that needs to be edited
The component can target any other part of the page, conditionally appending other elements to it
Everything is cleaned from the page once <my-vue-element> is removed 🤯

There should also be support for "slots" in order to inject external DOM elements (like icons) but I haven't found how to include them without using .vue files. Edit: This works, but not inside <teleport>
cc @kidonng

Feels like I'm going in circles. Web Components cannot be created from content scripts. 💀
The suggested code fails either at customElements.define or when instantiating the MyVueElement class.

https://bugs.chromium.org/p/chromium/issues/detail?id=390807

I still like Vue for its native teleport/portal support. Let's see if it can work…


Slack Connector: Can't send attachments using utter_attachment

Rasa Core version:
0.9.6
Python version:
3.6.4
Operating system (windows, osx, ...):
Windows Server 2016
Issue:
I have the following message to be sent by calling utter_attachment
        {
            "fallback": "Financial Advisor Summary",
            "color": "#36a64f",
            "title": "Financial Advisor Summary",
            "title_link": "http://tenfactorialrocks.com/",
            "image_url": "http://tenfactorialrocks.com/wp-content/uploads/2018/02/3-wise-summary.png",
            "thumb_url": "http://tenfactorialrocks.com/wp-content/uploads/2018/02/3-wise-summary.png",
 "actions": [
        {
          "type": "button",
          "text": "📈 Go to Dashboard",
          "url": "http://tenfactorialrocks.com/wp-content/uploads/2018/02/3-wise-summary.png",
          "style": "primary"
        },
        {
          "type": "button",
          "text": "📋 Download XL",
          "url": "http://tenfactorialrocks.com/wp-content/uploads/2018/02/3-wise-summary.png",
          "style": "danger"
        },
        {
          "type": "button",
          "text": "📧 E-Mail",
          "url": "http://tenfactorialrocks.com/wp-content/uploads/2018/02/3-wise-summary.png",
          "style": "danger"
        }

      ],
            "footer": "Powered by tenfactorialrocks",
            "footer_icon": "http://tenfactorialrocks.com/wp-content/uploads/2016/07/cropped-cropped-10-ava-page-001-e1468756708512-2.jpg",
            "ts": 123456789
        }
    ]

When I test the message using test for chat.postMessage It works like a charm with the image and links etc. I cant get the same to work in actions with the following code:
import json
import time
attachdata=json.dumps([{"fallback": "Financial Advisor Summary", "color": "#36a64f", "author_name": "TABE", "title": "Financial Advisor Summary", "title_link": "http://tenfactorialrocks.com", "image_url": "http://tenfactorialrocks.com/wp-content/uploads/2018/02/3-wise-summary.png", "thumb_url": "http://tenfactorialrocks.com/wp-content/uploads/2018/02/3-wise-summary.png", "actions": [{"type": "button", "text": "\ud83d\udcc8 Go to Dashboard", "url": "http://tenfactorialrocks.com/wp-content/uploads/2018/02/3-wise-summary.png", "style": "primary"}, {"type": "button", "text": "\ud83d\udccb Download XL", "url": "http://tenfactorialrocks.com/wp-content/uploads/2018/02/3-wise-summary.png", "style": "danger"}, {"type": "button", "text": "\ud83d\udce7 E-Mail", "url": "https://requests.example.com/cancel/r123456", "style": "danger"}], "footer": "Powered by 1010rocks", "ts":<PHONE_NUMBER>.0970402}])
dispatcher.utter_attachment(attachdata)

What am I doing wrong?
Content of domain file (if used & relevant): n/a

Could you post the error message you're getting? Or just the logs if there's no error message?


Fix CLI auto completion

Need to check why auto completion is not working.
It works when source lib/cli.zsh is done manually but when sourcing is done from the bol.plugin.zsh it doesn't.

It is working now. As it should.


Implement support for multiple simultaneous sessions

Description

Add support for multiusers (multiple simultaneous sessions).
One could consider doing this with a library to provide sessions, but as a non-core author, I aim to keep this PR as minimal as possible.
While I believe these changes to be correct, I do note that there it touches a lot of lines in important areas, so a bit of a warning that it might be recommend to take some time for review.
Related issues

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update (this needs a follow up PR)

Changes Made

Make sessions references indirect (accessible via session id,taken from cookie).
Change

Testing

[x] Unit Tests
[ ] Integration Tests
[ ] Tests do not apply
[ ] Needs testing (start an issue or do a follow up PR about it)

Mentions

a good library would be https://github.com/aio-libs/aiohttp-session/ which we considered, however similar functionality could be achieved without using that library (which i think is implemented with the current version), well there is a need to go redis.

with this AccessHandler methods _save_to_session and _get_session are obsolete do i understand it correctly ?

Correct, those are obsoleted (but were left as I thought they were still in use). Removed by 45a0112.


⚠ Mobitopup has degraded performance

In d2149d8, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 3791 ms

Resolved: Mobitopup performance has improved in 78ee927 after 415 days, 8 hours, 47 minutes.


new version of chef

got this error. can you check this.
Chef::Exceptions::ValidationFailed
Option action must be equal to one of: enable, disable!  You passed :nothing.
Cookbook Trace:                                                                                ---------------
/var/chef/cache/cookbooks/slack_handler/recipes/default.rb:47:in block in from_file'                                                                                /var/chef/cache/cookbooks/slack_handler/recipes/default.rb:42:in from_file'
Relevant File Content:
/var/chef/cache/cookbooks/slack_handler/recipes/default.rb:
40:  end.run_action(:create)
41:                                                                                42:  chef_handler "Chef::Handler::Slack" do
43:    source handler_file
44:    arguments [
45:                node['chef_client']['handler']['slack']
46:              ]
47>>   action :nothing
48:  end.run_action(:enable)
49:

chef version was Chef: 12.4.0.rc.2

In currently released versions, :nothing is common to all resources. It appears 12.4.0.rc.2 was released 6 days ago.

This appears to a bug in chef, but I've opened an issue upstream with them to confirm.

thanks for report to chef!

+1

I believe this has been fixed upstream in chef.


azure_postgresql_flexible_server does not appear to provide fullyQualifiedDomainName

Describe the bug
I am attempting to inventory VM and database resources in Azure using steampipe. One of the desired fields is FQDN, but this does not appear to be available in steampipe despite being trivially accessible with az postgres flexible-server list
Steampipe version (steampipe -v)
Steampipe v0.23.0-alpha.7
Plugin version (steampipe plugin list)
+----------------------------------------------+---------+-------------+
| Installed                                    | Version | Connections |
+----------------------------------------------+---------+-------------+
| hub.steampipe.io/plugins/turbot/azure@latest | 0.56.0  | azure       |
| hub.steampipe.io/plugins/turbot/net@latest   | 0.12.0  | net         |
+----------------------------------------------+---------+-------------+
To reproduce
steampipe query "select * from azure_postgresql_flexible_server"

Expected behavior
It would be ideal to be able to get the FQDN from steampipe for databases.
Additional context
Add any other context about the problem here.

It appears to be possible to derive the FQDN, which is the approach I have taken as a workaround:
    case
        when db.region like '%usgov%' then db.name || '.postgres.database.usgovcloudapi.net'
        else db.name || '.postgres.database.azure.com'
    end as inv_dns_name,

It would be nice to be able to query this directly however.


Pulling

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes

0 out of 2 committers have signed the CLA.

[ ] root
[ ] pradeeppaigit

root seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.


Game doesn't load after the most recent update.

Game just doesn't load after the most recent update. It's stuck on a loading screen.

Can confirm, same issue and isolated it to this mod.

They fixed Vital Strike, so maybe the ability changed?
I'm getting a different error tho 👍
` at System.Threading.Tasks.Task.ThrowIfExceptional (System.Boolean includeTaskCanceledExceptions) [0x00011] in :0
at System.Threading.Tasks.Task.Wait (System.Int32 millisecondsTimeout, System.Threading.CancellationToken cancellationToken) [0x00043] in :0
at System.Threading.Tasks.Task.Wait (System.Int32 millisecondsTimeout) [0x00000] in :0
at Kingmaker.EntitySystem.Persistence.SaveManager+d__55.MoveNext () [0x0021b] in :0
at Kingmaker.EntitySystem.Persistence.LoadingProcess.TickLoading () [0x00009] in :0
at Kingmaker.EntitySystem.Persistence.LoadingProcess.Update () [0x000b1] in :0
Rethrow as LoadGameException
at Kingmaker.EntitySystem.Persistence.LoadingProcess.Update () [0x00112] in :0
(Filename:  Line: 0)
Setting up 2 worker threads for Enlighten.
Thread -> id: 1570 -> priority: 1
Thread -> id: 2924 -> priority: 1
UnloadAsset may only be used on individual assets and can not be used on GameObject's / Components / AssetBundles or GameManagers
(Filename:  Line: 446)
`

This should be fixed in 1.0.7


[Event Request] Table 5965"Service Contract Header" - OnBeforeReturnNoOfPer

Hi
To be able to handle other invoice periods than the standard ones, we would need an event publisher which allows us to replace the calculation in ReturnNoOfPer on 5965 "Service Contract Header".
As a second request we would like to have the type of the the return value (RetPer) changed from Integer to Decimal, to accommodate for invoice periods > 1y.
procedure ReturnNoOfPer(InvoicePeriod: Enum "Service Contract Header Invoice Period") RetPer: Decimal
    var
    isHandled: Boolean;
    begin
    isHandled := false;
    OnBeforeReturnNoOfPer(IncoicePeriod, RetPer, IsHandled);
    if IsHandled then
        exit;
    //Standard Code of the procedure...
        end;
    end;

[IntegrationEvent(false,false)]
local procedure OnBeforeReturnNoOfPer(IncoicePeriod: Enum "Service Contract Header Invoice Period"; var RetPer; var IsHandled: Boolean)
begin
end;

Thank you for your consideration.
Best regards

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Input.is_action_just_pressed doesn't work.

Godot version
3.3.2 mono
System information
Windows 10, Acer Swift 3
Issue description
I made a platformer character controller, but I can reproduce this error outside of its code as well. When I use Input.is_action_just_pressed(), it takes multiple button presses for it to respond.
Steps to reproduce
Use Input.is_action_just_pressed.
Minimal reproduction project
Just load up a project and use input.is_action_just_pressed.

I can't reproduce on v3.3.2.stable
Does it work for you on this testing project?
Testing is_action_just_pressed.zip

You need to provide an actual MRP, @ch3rrypicked, otherwise we cannot help you.

Closing due to lack of response, if you provide the requested information this can be reopened


fix: gcp use project name for cloudprovider

这个 PR 实现什么功能/修复什么问题:
gcp use project name for cloudprovider
是否需要 backport 到之前的 release 分支:

release/2.13

/area region
/cc @zexi

Codecov Report

Merging #6068 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6068   +/-   ##
=======================================
  Coverage    7.02%    7.02%
=======================================
  Files         644      644
  Lines      110405   110405
=======================================
+ Hits         7754     7756    +2
+ Misses     102051   102050    -1
+ Partials      600      599    -1

Flag
Coverage Δ

#aFlag
7.02% <ø> (+<0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/appsrv/response.go
70.58% <0.00%> (+2.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74eef22...85119bb. Read the comment docs.


Name output files

[ ] When jobmode is "sge" the snakemake rule itself should only request 1 core and barely more than 4GB of memory.
[ ] The output directory current contains the sample identifier twice (see below)

results/cellranger_count/pbmc_1k_v3/pbmc_1k_v3/outs/raw_feature_bc_matrix.h5


enable fp16 for Batch Matmul

since there is relevant code in #18436, should be safe to enable it

Nagging Assignee @case540: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

It is fixed now with the following change: https://github.com/tensorflow/tensorflow/commit/cfdc46956574de703df2251ac52d30e593d8d417#diff-dacd84efa9d7e0ac640165c911203745
Please reopen if further changes are required.


Dockerfile: update to Go 1.13.8

Follow-up to https://github.com/docker/libnetwork/pull/2513, but keeping it separate so that we can cherry-pick the previous update to release branches if needed.
I'll rebase this one after https://github.com/docker/libnetwork/pull/2513 is merged

@arkodg @selansen rebased; this is ready for review

@selansen PTAL


Fix source pathing for code coverage

Description

Fixes code coverage output to more aptly point to the source file. This allows tools like intellij's code coverage to work without any other issues.
Should also allow java coverage that's pulled into a scala library.

I'm open to making changes here, but the main idea is that bazel / jacoco allows for a file in the jar that ends with -paths-for-coverage.txt and rather than stitching together a file name from its package it will leverage these source 'hints' we provide it.
Motivation

I wanted code coverage in intellij.

I want to see the failure and see that it makes sense but after that I’m good.
@johnynek, on honorable visitor 😉, any more issues on your side?

As mentioned in the other link: https://travis-ci.org/bazelbuild/rules_scala/jobs/654605424?utm_medium=notification&utm_source=github_status
That is the failing coverage test. Does that make sense to you? Otherwise curious what else you're looking for.

Also note that I changed the package in the test files to workaround a bazel bug. I've filed an issue here: https://github.com/bazelbuild/bazel/issues/10863 and opened a PR that should address that.


match leading slash imports with path mappings - fixes #13730

Checklist:

[x] There is an associated issue
[ ] The issue is labeled 'Bug' or 'help wanted' or is in the Community milestone
[x] Code is up-to-date with the master branch
[x] You've successfully run jake runtests locally
[x] You've signed the CLA
[x] There are new or updated unit tests validating the change

About the code changes: I can imagine you would like to have the code structured differently or have different traces. I just looked at what currently been implemented and took the most straightforward approach making the changes easy to diff. Feel free to make suggestions.
About the tests: I am missing information to provide the correct amount of tests, or actually I don't know what your policy is. I think the tests I added should cover all of the code I added and prevent future breakage.
About performance: I tried to minimize the performance impact. I am not sure how often this code is called in situations where high performance is required. That said, I noticed a lot of places where performance could be improved, so I am not sure how much you guys want to focus on that.
About caching: I noticed a few places where isExternalModuleNameRelative is used in relation to caching. We might want to add the 'is potentially an alias import' there as well. This however requires some extra thought. An example of such a place:
if (perFolderCache) {
  perFolderCache.set(moduleName, result);
  if (!isExternalModuleNameRelative(moduleName)) {
    // put result in per-module name cache
    cache!.getOrCreateCacheForModuleName(moduleName).set(containingDirectory, result);
  }
}

Fixes #13730

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: EECOLOR sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Question for the maintainers: do you guys want me to squash the commits once the code has stabilized?

@sheetalkamat I have made some changes:

Added a test to reflect the intent expressed in the result of the design meeting
Changed the names of the tests to better reflect the intent
Adjusted the code to more clearly communicate the flow: "if we have paths available and it is eligible for path mapping, try to load using the paths"

There is one potential problem left.
When thinking about this problem it is important to remember that the function isExternalModuleNameRelative means isExternalModuleNameRelativeOrRoot or isExternalModuleNameNotANodeModule'. And when you read !isExternalModuleNameRelative(moduleName)you could sayisExternalModuleNameANodeModule`.
Before this change, all !isExternalModuleNameRelative(moduleName) could potentially be mapped using paths. And, the other way around, mapped paths would always be non-root and non-relative.
With this change, all !pathIsRelative(moduleName) and all isRootedDiskPath(moduleName) || isUrl(moduleName) could potentially be mapped using paths (where the last case has the requirement that we have a potential mapping). And, the other way around, mapped paths would always be non-relative.
This is not necessarily a problem. However, in some code bases there is 'invisible' coupling between concepts. The coupling for this case would be the assumption that !isExternalModuleNameRelative(moduleName) is potentially mapped.
As far as I can tell (by tracing back the introduction of path mapping and the introduction of root path's as 'relative') any coupling that exist would be accidental. I can also imagine that if a developer used !isExternalModuleNameRelative(moduleName) to mean a node module he/she did not think about the possibility of it being a mapped path and thus potentially not a node module.
Looking at the uses of isExternalModuleNameRelative my domain knowledge is lacking to determine the following two things:

Did it contain a wrong assumption about the meaning of isExternalModuleNameRelative (in combination with paths) before this change?
Does this change impact correct assumptions about the meaning of isExternalModuleNameRelative (in combination with paths)?

My advise would be to create a separate issue to track down the uses of isExternalModuleNameRelative and:

investigate if it has any relation to node modules or rooted paths
determine if the fact that those paths might actually not be a node module or rooted path (once resolved) has any impact

I have squashed the commits.

@sheetalkamat What's next?

Also need changes in getStringLiteralCompletionsFromModuleNamesWorker and corresponding tests with module name completions..

Also need changes in getStringLiteralCompletionsFromModuleNamesWorker and corresponding tests with module name completions.

What kind of inputs would this fail on?

More than failing of completions, we need to make sure the path completions are correct when there is path mapping.

@sheetalkamat I have updated the code to reflect your comments (apart from the ones that still have questions). I also squashed my commits again and rebased on master. Could you please take another look?

@sheetalkamat I have made the required changes.

@sheetalkamat Those are really difficult to revert -- it happens when the submodule is updated by git. I think it's fine because we regularly update these anyway.

@EECOLOR thank you for contribution. This should be available in tonight's nightly build.

@sheetalkamat thank you and your team for your help

@sheetalkamat did something go wrong with the nightly build?

@weswigham @DanielRosenwasser would know.

Looks like for some reason the nightly publish job didn't get scheduled until I just went to go check on the task. Likely an azure devops issue - since I believe it just triggered, we'll probably publish a nightly in about 30 minutes.


range(x,y) malfunctions for values greater than 0x1000000

Godot version:
Godot_v3.1.2-stable_win64
Issue description:
Using range(x,y) with values greater than 0x1000000 (16777216), where x and/or y are odd, results in an incorrect array with one or two extra values (as if x were x-1 and/or y were y+1).
Here is a code snippet to show this:
   for i in range(16777213, 16777215):
      print(i)
   print("====")
   for i in range(16777217, 16777219):
      print(i)
   print("====")

Its output is:
16777213
16777214
====
16777216
16777217
16777218
16777219
====

The former is correct, the latter is wrong.
P.S. The bug is slightly more complex than I had described. Not only may it result in one or two extra values; it may also result in one or two missing values. For example, range(16777219, 16777221) returns an empty array.
P.P.S. This bug also affects the range(x,y,step) flavour.

They might have been converted to float, 16777219 is the maximum integer value they can accurately represent.

Updated OP with P.S. and P.P.S.

The problem is here:
	switch (args.size()) {
		case 1: tn->vtype = Variant::INT; break;
		case 2: tn->vtype = Variant::VECTOR2; break;
		case 3: tn->vtype = Variant::VECTOR3; break;
	}

For the sake of optimization gdscript parser stores small ranges in 'for' loops (but not in standalone expressions of 'range') in Vector: Vector2 for 2 iterations and Vector3 for 3 respectively. Vector in Godot stores float values (to increase performance) so we have this problem here.
The simple solution is to check if the values can be stored in 24 bits for integers and avoid this optimization they can not.

Another point for integer vectors to be added to the engine... unless there is a way to use some other data structure here? Vector2 sounds quite an overuse here.

@Zylann I can see Vector2i in the codebase, but no Vector3i. (Vector2i isn't exposed to GDScript.)

Turning off this optimization vanishes the bug:
	if (op->op == OperatorNode::OP_CALL && op->arguments[0]->type == Node::TYPE_BUILT_IN_FUNCTION && static_cast<BuiltInFunctionNode *>(op->arguments[0])->function == GDScriptFunctions::GEN_RANGE) {
		//iterating a range, so see if range() can be optimized without allocating memory, by replacing it by vectors (which can work as iterable too!)
	/* ... */

The solution for constant int 'range' arguments would be something like also checking (static_cast(0xFF000000) > value) && (value < static_cast(0x01000000)
Though this code for ConstantNodes is never executed, guess it's another minor bug:
	bool constant = false; // should be true

	for (int i = 1; i < op->arguments.size(); i++) {
		args.push_back(op->arguments[i]);
		if (constant && op->arguments[i]->type == Node::TYPE_CONSTANT) {
			ConstantNode *c = static_cast<ConstantNode *>(op->arguments[i]);
			if (c->value.get_type() == Variant::REAL || c->value.get_type() == Variant::INT) {
				constants.push_back(c->value);
				constant = true;
			}
		} else {
			constant = false;
		}
	}

But for int variables a larger iterable structure is needed.


pubRepFilter: Use .by to filter by multiple parameters

I need to stratify my dataset by multiple parameters with multiple variations with pubRepFilter:
pr.clonotypes <- lapply(immdata$data, head, 2000)
pr.clonotypes <- pubRep(pr.clonotypes, .col = "aa", .quant = "count", .coding = TRUE, .verbose = TRUE)
#Example 1
pr.clonotypes.status.day0 <- pubRepFilter(pr.clonotypes, .meta = immdata$meta, .by = c("status", Time = "Day0"))
#Example 2
pr.clonotypes.YES.Time <- pubRepFilter(pr.clonotypes, .meta = immdata$meta, .by = c(status = "YES", "Time"))
#Example 3
pr.clonotypes.day0 <- pubRepFilter(pr.clonotypes, .meta = immdata$meta, .by = c(Time = "Day0"))
#Example 4
pr.clonotypes.YES <- pubRepFilter(pr.clonotypes, .meta = immdata$meta, .by = c(status = "YES"))
For examples 1 and 2, I get the following error: "Check failed: '' not in the metadata table!"
Examples 3 and 4 work fine with no issues.
Does anyone have any thoughts on what I am doing wrong?
Thank you.

Hi @k-blenman
Thank you letting our team know about that!
pubRepFilter returns public clonotypes with any field value if you don't provide the metadata field in the .by.
Would you be open to tell what would you like to achieve with the following line
pr.clonotypes.status.day0 <- pubRepFilter(pr.clonotypes, .meta = immdata$meta, .by = c("status", Time = "Day0"))
Would the following line work instead for you?
pr.clonotypes.status.day0 <- pubRepFilter(pr.clonotypes, .meta = immdata$meta, .by = c(Time = "Day0"))

Hi Vadim
There are two parameters: status and time. I need to filter by both.
Can we schedule some time to meet to discuss?
Thank you.
Regards
Dr Kim RM Blenman
Department of Internal Medicine
Section of Medical Oncology
Yale Cancer Center
Yale University
School of Medicine
“The only way that we will prosper as a society is to love our neighbors as we love ourselves”
From: Vadim I. Nazarov<EMAIL_ADDRESS>Sent: Tuesday, August 11, 2020 8:47 AM
To: immunomind/immunarch<EMAIL_ADDRESS>Cc: Blenman, Kim<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [immunomind/immunarch] pubRepFilter: Use .by to filter by multiple parameters (#97)
Hi @k-blenmanhttps://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fk-blenman&data=02|01|kim.blenman%40yale.edu|e46416e987304c4084dc08d83df4b1bb|dd8cbebb21394df8b4114e3e87abeb5c|0|0|637327468454597858&sdata=L7wmMpFecElN09ly7MbdnWQkhbsSy6Rq1leVdMOPsBQ%3D&reserved=0
Thank you letting our team know about that!
pubRepFilter returns public clonotypes with any field value if you don't provide the metadata field in the .by.
Would you be open to tell what would you like to achieve with the following line
pr.clonotypes.status.day0 <- pubRepFilter(pr.clonotypes, .meta = immdata$meta, .by = c("status", Time = "Day0"))
Would the following line work instead for you?
pr.clonotypes.status.day0 <- pubRepFilter(pr.clonotypes, .meta = immdata$meta, .by = c(Time = "Day0"))
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fimmunomind%2Fimmunarch%2Fissues%2F97%23issuecomment-671925509&data=02|01|kim.blenman%40yale.edu|e46416e987304c4084dc08d83df4b1bb|dd8cbebb21394df8b4114e3e87abeb5c|0|0|637327468454607848&sdata=QHxxFVNck19YCYiAoqlrF3UgW%2FZreRhyu8QLP9mbxIs%3D&reserved=0, or unsubscribehttps://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGA53VMBHRLL6MFUYEJNWYLSAE4VVANCNFSM4PYAQREQ&data=02|01|kim.blenman%40yale.edu|e46416e987304c4084dc08d83df4b1bb|dd8cbebb21394df8b4114e3e87abeb5c|0|0|637327468454607848&sdata=2fM274qOHOLLbBdmfZu%2BIQsJERu1zND5pgzstnQHpgE%3D&reserved=0.


multi-accounting: hangs at Starting... instead of error message

Steps to reproduce:
0. GOG Galaxy 2.0 with Steam API integration downloaded is required, any Steam account should be bound through it. Steam installed, logged in with bound account + one more account at least once, shut down.

Clone Steam API integration from
C:\Users[username]\AppData\Local\GOG.com\Galaxy\plugins\installed\steam_ca27391f-2675-49b1-92c0-896d43afa4f8
to
C:\Users[username]\AppData\Local\GOG.com\Galaxy\plugins\installed\steam2
Clean pycache folders up from it
In
C:\Users[username]\AppData\Local\GOG.com\Galaxy\plugins\installed\steam2\manifest.json
change guid to any other valid value
Run Galaxy 2.0
Try to add a new Integration
At Community Integrations - Manually Added, in Steam row hit Connect

ER
assuming that multiaccounting is a no-go currently, an error message, at least
AR
hangup with Starting... prompt
Logs:
https://pastebin.com/jK9ZVCHN
(token value scrapped)

Thanks for your report.
This is a bug in the Galaxy Client, it shall only list a single plugin for a platform, giving preference to the Official and the Popular plugins.
I've reported this internally on your behalf, but not expecting it to be fixed soon, as multiple plugins for the same platform are not supported anyway.

I believe, multi-accounting for Steam (through Family Sharing) is not a problem anymore: with introduction of manual game adding + executable linking I can simply link the executable and Steam will handle the rest.
So only lack of adequate error message remains :)

Well, actually some of us have multiple legal accounts held by same person. I checked long time ago and Steam has nothing against it. Eg I have two, one is ment for my kid but it's still my account, has many dupes vs my main account (for multiplayer) but also some uniques.
It would be awesome if we could still have multiple accounts synced to same Galaxy somehow... Some day.

That would be great if galaxy can bind more steam account, at least display games belong to different accounts(not for show off XD).


Moble -donate page,  Donate module

The format is screwed so you cant See all the options

@jazbinda: To get the donations working with Paypal I had to drop the text entry for Monthly Donations and use pre-defined values. We can make this all better later, I just wanted to get something working 💃


no documentation for css classes clr-hidden-[size]-down / up

hello,
i just discover by browsing the issues page that clarity design has css classes for hiding/displaying  html elements bases on screen size as bootstrap does.
i didn't find any documentation about it and it would be really nice to have it.
can you take a look at it ?
thanks

any update ?

No longer an issue or resolved in the upcoming website work. Closing as resolved.


Fix appveyor.yml, removing user-specific notification settings

.# Discussion
Appveyor doesn't have partial appveyor.yml suppression. So, unless the
appveyor.yml configuration file is completely suppressed, non-primary devs
receive notification errors with every build/test of the application. By
removing the user-specific notifications, other devs can now build/test the
application code (via the recipe specified within appveyor.yml) without
receiving notification errors.
For any given developer, personalized notification settings can be added on
top of the repo appveyor.yml project settings via the "Settings / Notifications"
section.

So how do we keep Slack notifications for the Scoop team?

Just move the notification from the appveyor.yml to the "Settings /
Notification" section of the AppVeyor  project. The notifications there are
additive on top of the appveyor.yml file. Putting them there doesn't
create broken notifications for everyone else.
On Jul 23, 2015 8:38 PM, "Simon Hartcher"<EMAIL_ADDRESS>wrote:

So how do we keep Slack notifications for the Scoop team?
—
Reply to this email directly or view it on GitHub
https://github.com/lukesampson/scoop/pull/434#issuecomment-124288840.

Thanks :+1:


fit maps to boundary in config

Currently the maps center on a centroid in Detroit. Let's make the map center wherever the user has configured the instance boundary.

🚢 'd
Set the target of maps using the "center" attribute in your config (added to sample template for reference).


It didn't convert my jpeg

I enabled the option  "Uploaded jpeg images will be output in this format. " to webp and uploaded a new .jpeg but the webp file doesn't exist... does it take a while? Would be great if it can also convert existing files...
Will it keep the original file?
What about if the browser doesn't support webp?

@ayrancd I used the Regenerate Thumbnails plugin to generate my webp images for already uploaded images, settings as described by you (For jpeg images > webp). That worked for me.
Safari, Chrome, Firefox, Edge support webp on newer devices. I tested on a Macbook Pro (2020) , iPhone 13 Pro and iPhone 6. IPhone 6 does not support webp on any browser I tried. I understand that a fallback  is on the way, see: https://github.com/adamsilverstein/modern-images-wp/issues/25
Can't wait 🤩 until it is in place.
@adamsilverstein Thank you for this plugin.
--

Thanks for the feedback @ingereck - ios support depends on the ios version, according to https://caniuse.com/webp you need at least version 14. using the fallback method would work well for this use case, you could have both webp and jpeg.

@ayrancd thanks for trying the plugin

I enabled the option "Uploaded jpeg images will be output in this format. " to webp and uploaded a new .jpeg but the webp file doesn't exist... does it take a while? Would be great if it can also convert existing files...

does your server support WebP? Check Tools -> Site Health

Will it keep the original file?

Yes. WordPress always keeps the original image you upload. It only changes the sub-sized images WordPress generates.

What about if the browser doesn't support webp?

The image will not display in this case. Browser support is pretty good though: https://caniuse.com/webp. It is also possible to use a fallback method with both webp and jpeg as a fallback for browsers that can't display webp.

@ayrancd I used the Regenerate Thumbnails plugin to generate my webp images for already uploaded images, settings as described by you (For jpeg images > webp). That worked for me.

Thanks for confirming that works as expected!


Expose Configuration File paths as Environment Variables

Describe the feature
Add Environment Variables that designate where the Config files are mount in the filesystem.
Optional: Is your feature request related to a problem? Please describe.
When integrating Connaisseur with Hashicorp Vault through Pod annotations [1], I found out that there isn't a way to add Public Keys from Vault directly to the configuration, as Vault integration has a very tight way of only exporting Secrets to files. So, while it is possible to extract a templated configuration with Vault Keys to a Pod, it is impossible to point Connaisseur to that configuration file.
Having some Environment Variables that point to the Configuration files would enable Vault integration.
Optional: Implementation ideas
The filepaths where the Python app will find the configuration files are hardcoded [2]. They can be changed to be populated by Env Vars (in case they are not empty - leave current values as sane defaults)
Optional: Additional context
I know that Public Keys are not secrets and can be handled in various other ways, yet what I want to achieve is the ability of the Vault agent to hot-reload the secrets to the config files, achieving automatic key rolling through deployments.

[1] : https://www.vaultproject.io/docs/platform/k8s/injector/annotations
[2] : https://github.com/sse-secure-systems/connaisseur/blob/master/connaisseur/config.py#L21

@operatorequals I like the idea. Are you using Cosign for signing your images? In that case, it is actually possible to specify a kms link such as described here for the integration of the Connaisseur feature for Cosign: https://sse-secure-systems.github.io/connaisseur/v2.2.1/validators/sigstore_cosign/#kms-support
This technically just implements the Cosign URIs: https://github.com/sigstore/cosign/blob/main/KMS.md#hashicorp-vault
Can you check whether that works for you?

Beautiful!
You'll have a definitive answer one of these days as I'm into it.

@operatorequals issue seems to have gone stale as likely fixed. Will close the issue, feel free to re-open if the problem persists :slightly_smiling_face: