[$500] DEV: Web - Draft icon show even there is not any thing in input field

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to top most thread in LHN
Write something
Then go to second most thread in LHN
Here also write something
Then select all and erase that text
Then go to remaining draft message and erase all text from input field

Expected Result:
Draft icon not shows if not have any text in input field
Actual Result:
Draft icon is shows even input field is empty
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: Dev 1.3.57-5.
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/be5c6d75-b5cb-49f3-a4e6-a6662db63fd6
Expensify/Expensify Issue URL:
Issue reported by: @niravkakadiya25
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693199645599589
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e6da2ca5e140fdb7
Upwork Job ID:<PHONE_NUMBER>762148864
Last Price Increase: 2023-09-27

Proposal
Please re-state the problem that we are trying to solve in this issue.

Draft icon show even there is not any thing in input field

What is the root cause of that problem?

Report.setReportWithDraft(reportID, true) is called but the empty text is saved that leads to the bug "Draft icon show even there is not anything in the input field". But why is empty text saved? It will be shown bellow:
Currently, we are using the debounce function to save the draft comment:
https://github.com/Expensify/App/blob/1223e1e6d98d2bfc4daac70fd3de898ae90b94b7/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js#L206-L210
The debouncedSaveReportComment function is defined as below:

const debouncedSaveReportComment = _.debounce((reportID, comment) => {
    Report.saveReportComment(reportID, comment || '');
}, 1000);

Because all the reports share the same debounce function above - debouncedSaveReportComment, so when the user opens chat report A and types any message then quickly switches to report B and types any messages, the debouncedSaveReportComment will ignore all the calls made within that 1000ms (contains the call that made in report A). It leads to the empty draft message being saved with report A.

What changes do you think we should make in order to solve the problem?

We can create the new debouncedSaveReportComment that is used separately for each chat report and replace the debounce function mentioned in the root cause part by it:

    const saveReportComment = useCallback((reportID, newComment) => {
        Report.saveReportComment(reportID, newComment || '');
    }, []);

    const debounceSaveReportComment = useCallback(
        _.debounce((reportID, newComment) => {
            saveReportComment(reportID, newComment);
        }, 1000),
        [saveReportComment],
    );

What alternative solutions did you explore? (Optional)

NA

Result
Screencast from 06-09-2023 16:48:47.webm

Not overdue, please get your proposals in 📢

Proposal
Please re-state the problem that we are trying to solve in this issue.
In LHN, a draft icon shows when there is no text in the input field.
What is the root cause of that problem?
The ComposerWithSuggestions component, which is responsible for input text handling, saves a draft of input text with one second debounce:
https://github.com/Expensify/App/blob/e2a1343811f7c9378e39da8dd61f1268817872e9/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js#L206-L207
https://github.com/Expensify/App/blob/800057628b905f5dfa92ca19cceb00eab8c480ee/src/libs/ComposerUtils/debouncedSaveReportComment.js#L9-L11
The problem occurs when a user types in a message in one report chat, switches to another report and enters another message within one second. The new debounced function call happens, and the previous call becomes overridden, but a report menu item in LHN displays that it was edited.
What changes do you think we should make in order to solve the problem?
Move the debounced comment save function on the component level. So, every report will have it's own instance of that function. We need to do it in ReportActionCompose (parent component) because it has some use cases with canceling the debounce:
// ReportActionCompose.js
const debouncedSaveReportComment = useMemo(function () {
  return _.debounce((reportID, comment) => {
    Report.saveReportComment(reportID, comment || '');
      }, 5000);
   }, []);
    ...
 <ComposerWithSuggestions
   ...
   debouncedSaveReportComment={debouncedSaveReportComment} // new property
 />

@abdulrahuman5196 any thoughts on the above?

Bumped in Slack.

Reviewing now

@abdulrahuman5196 did you have any feedback for the proposals?

Checking again.

@DylanDylann @needpower @tsa321
Hi folks, thank you for the proposal. But I am unable to fully understand the root cause.
The display of draft icon is dependent on the hasDraft flag.
https://github.com/Expensify/App/blob/09a0118fcaa626b44b18739f372748cf25deae7d/src/libs/SidebarUtils.js#L299
But that flag is updated via setReportWithDraft function which is not present inside the debounce function. Then why is it getting affected?

@abdulrahuman5196  setReportWithDraft is just set: whether the report has draft or not. But the draft for each report is set in the debounce function debouncedSaveReportComment

@DylanDylann 's proposal here https://github.com/Expensify/App/issues/27362#issuecomment-1717803795 looks good and works well.
🎀 👀 🎀
C+ Reviewed

@tsa321 Please follow the steps to reproduce this bug which was reported by reporter. I not, maybe the above is another bug, and you can report it. Thanks

@abdulrahuman5196 PR https://github.com/Expensify/App/pull/28574 is ready for review

The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/25758

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://github.com/Expensify/App/pull/25758/files#r1352852646

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. Not beneficial for a minor bug

Payouts due:
Issue Reporter: $50 @niravkakadiya25
Contributor: $500 + $250 bonus @DylanDylann
Contributor+: $500 + $250 bonus @abdulrahuman5196
Eligible for 50% #urgency bonus? Yes
Upwork job


Update Django support claim in README

README.md claims that Django >=2.2 is supported. However the package install_requires django>=3.2, and older Django versions are not in the tox matrix.

Indeed, my past batch update must have somehow failed to update this repo.

Ah right it's because there was a typo in "supported": 800a4d5339ab807b1078a965be0fd3c48188be60 . I missed that the version number was wrong when correcting the typo.


Try React Headroom for the header

React headroom automatically hides and shows the page header https://github.com/KyleAMathews/react-headroom


Cannot get refresh-token

After adding .items() inside the _register_link function in lidlplus/api.py here:

I was able to navigate to the page, but after providing the e-mail and password, then hitting the next button nothing happened:

Hi, which country and language do you use? Than I try to reproduce it later, only tested german so far 😅

Hi there, I used the following setup:
lidl = LidlPlusApi(language="HU", country="hu")
It seems like the valid setup for Hungary.

Problem should be fixed now, I created a new release.
Sorry, v0.2.1 couldn't run, I had to test the releases more careful :facepalm:

Thx very much for the update!
May I ask you what should happen after you hit the submit button? I receive the following pop-up:

Even if I put a break point to avoid the TimeoutException with the "Wrong credentials" message, and accept this pop-up manually, the submit button doesn't do anything.
I am using ubuntu 20.04, with chrome. Tried it win 10, firefox, chrome as well, but it was the same.

Ahhh, got it! So basically you get the token from the latest request's header data and I just have to skip this part:

I was able to get the token and use it to get my tickets.
Checked my account on the phone, but I wasn't able to find anything related to 2fa. Maybe in Germany there are more options, e.g. online shopping and other functionalities that require more secure authentication. Thx for the help!!

Yes, that's it!
In Germany you can connect your bank account and automatically pay with it. I remember it was in the news that there was an abuse problem with this. Probably that's why 2fa is forced.
Thanks for your contribution :)


NOT IMPORTANT

i just wanted to ask if you plan to use avian JVM https://github.com/ReadyTalk/avian
it looked interesting in the fact that it is self contained per application (no java install needed)
and it claims to have optimizations of what sort i'm not shore anyway seemed like an interesting
idea to me also do you plain to optimize the code? from what i heard minecraft is poorly optimized
and lastly do you think you could make it compatible with nova renderer? or that it would just work
https://continuum.graphics/nova/

btw i know nova is a w.i.p and this is two but i'm still curious sense nova just replaces the renderer


update seedme client to 1.1.0

-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.
Ticket number: 2387
Status: Resolved
Project: VisIt
Tracker: Feature
Priority: Normal
Subject: update seedme client to 1.1.0
Assigned to: Cyrus Harrison
Category: -
Target version: 2.10
Author: Cyrus Harrison
Start: 09/22/2015
Due date:
% Done: 100%
Estimated time:
Created: 09/22/2015 06:41 pm
Updated: 10/08/2015 01:44 pm
Likelihood:
Severity:
Found in version: 2.12.3
Impact: 3 - Medium
Expected Use: 3 - Occasional
OS: All
Support Group: Any
Description:
Comments:
Hi Everyone,Updated to Seedme 1.1.0 client for VisIt 2.10 release.-Cyrus==========2.10RC: ==========third_party:Adding (bin) seedmepythonclient-v1.1.0.zipTransmitting file data .Committed revision r27346.src/Sending svn_bin/bv_support/bv_python.shSending svn_bin/bv_support/helper_funcs.shTransmitting file data ..Committed revision r27347.==========Trunk: ==========src/Sending svn_bin/bv_support/bv_python.shSending svn_bin/bv_support/helper_funcs.shTransmitting file data ..Committed revision r27349.third_party/Adding (bin) seedmepythonclient-v1.1.0.zipCommitted revision r27350.

2391_smime.p7s.zip


JavaScript vm broken (bad Proxy implementation?)

Describe the bug
When defining properties on a object returned by the vm, they behave differently than in NodeJS.
This breaks for example the testing framework Jest. (As you can see here: https://github.com/stackblitz/webcontainer-core/issues/293)
Example code:
const { runInContext, createContext } = require('vm');

const context = createContext();
const vmGlobal = runInContext('this', context);

Object.defineProperties(vmGlobal, {
  works: {
    configurable: true,
    value: 'This will work'
  },
  worksNot: {
    configurable: false,
    value: 'This will not work (in webcontainer)'
  }
});

console.log(vmGlobal.works); // success
console.log(vmGlobal.worksNot); // error
Object.keys(vmGlobal); // error

Link to the blitz that caused the error
https://stackblitz.com/edit/node-7mnp6x
Steps to reproduce

Open the linked stackblitz
run node index in the console
See the error

Expected behavior
Console should print:
This will work
This will not work (in webcontainer)

Screenshots

Platform
Browser name  = Chrome
Full version  = 92.0.4515.159
Major version = 92
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36
performance.memory = {
  "totalJSHeapSize": 96025376,
  "usedJSHeapSize": 90858908,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Hash = 8ffc536d8181e8b30c228dec423d18afae547c40

Additional context
I created this bug ticket as a result of this: https://github.com/stackblitz/webcontainer-core/issues/293

Thanks for reporting this issue. It seems to be a bug.

Also, this seems to work just fine for me locally:
console.log(runInContext('global', createContext()));

Good news, this has been fixed and it's now available. Here's an example.

You guys are awesome! It works, thanks!

@freehuntx Just a quick update that vm.runInContext('global', vm.createContext()) won't behave the same as on local. I had to change this again because the way I fixed it does not work in all cases and typeof global was also throwing a reference error. Unfortunately, this is a limitation of WebContainer's vm module. The closest I can get is to return undefined if you try to evaluate global and the context doesn't define it. It's a bummer but sadly a hard limitation. But I'd say this is an edge case, and the rest still works as expected.


Add vv /c/hover

Adds a vv path to examine the entity that the mouse is currently hovering over. This means if you can create a nice vv shortcut by adding the following to keybinds.yml:
- key: V
  mod1: Alt
  type: Command
  function: vv /c/hover

I know very little about the new VV path stuff, I largely just copied this from the existing vv /c/guihover path, I might be committing warcrimes without knowing it.
It might also be worth making it an "official debug keybind" by somehow injecting it in a #if DEBUG code block?

Maybe call it enthover for consistency and clarity?


SCP unreliable? Use Rclone (for Windows)

Is SCP unreliable? It's possible (see below).
so potentially Raspiblitz should stop using SCP.
We need help, Windows users to test alternate tools (listed below)

The blockchain sync failed for a 4th time.
I don't remember what the error was for the blockchain sync, but I went ahead and downloaded the torrent which worked without any issues. I'm still puzzled by why the "copy" with WinSCP didn't work even after reformatting the HD and downloading a new copy of the blockchain. Oh well, at least I'm up and running now. Appreciate the help.

SCP scp does not guarantee file integrity since it does not use file checksums like rsync does. So though unlikely it's possible you had some files corrupted when copying.
Originally posted by @fluidvoice in https://github.com/rootzoll/raspiblitz/issues/479#issuecomment-481335619

Since v1.1 RaspiBlitz already uses rsync instead of SCP for the Blockchain transfer process. But thats just if the user tells RaspiBlitz that the host compuer is OSX/Mac or Linux. Windows does not have rsync installed - so for Windows computers it defaults to SCP.
@fluidvoice Can I consider this issue closed, or is there anything to improve still?

Are there no client apps for Windows that talk rsync protocol?  There is cygwin, but that's prob a bit much to ask users to install?

1st of all: I dont have a Windows machine to test or dev this - so this would need to be a PR. I add a "Help wanted" lable.
I am open to let the user install some additional software on windows as long as that one is free. Bit this mean for windows there is a whole other process to follow then for Mac/Linux. The script of 50copyHDD.sh has already a selection if user is running Mac/Linux or Windows. So that can be done. But having a GUI tool on the windows side would also mean there is not "one line of copy" to instruct the user just to copy and run. So there needs to be some kind of detailed documentation on how to install the tool and all the single clicks and selections to make. That is maybe a bit much to have all in the shell text window. So maybe a link to a youtube video or a FAQ text with pictures to follow?

1st of all: I dont have a Windows machine to test or dev this - so this would need to be a PR. I add a "Help wanted" lable.
I am open to let the user install some additional software on windows as long as that one is free. But this mean for windows there is a whole other process to follow then for Mac/Linux. The script of 50copyHDD.sh has already a selection if user is running Mac/Linux or Windows. So that can be done. But having a GUI tool on the windows side would also mean there is not "just one line of code" to instruct the user just to copy and run. So there needs to be some kind of detailed documentation on how to install the tool and all the single clicks and selections to make. That is maybe a bit much to have all in the shell text window. So maybe a link to a youtube video or a FAQ text with pictures to follow?

Makes sense.  Command line even on Windows is better.  Perhaps RClone is the tool to use. It would be nice if it works since we could use for backing up to cloud providers too. But someone needs to test it.
Note on Rclone...

There are 3 main syncing methods
no flags - (size, modtime)
--size-only (size)
--checksum (size, checksum)
Then there are the modifiers
--ignore-size makes all of the above skip the size check
--ignore-times - uploads unconditionally (no checks)

I finally have my RaspiBlitz up and running with the torrent copy of the blockchain, so I don't want to start meddling with things again. However, I do have an extra Pi setup (Pi, microSD, HDD) that I could possibly test this out with. It would probably have to be later in the week though.

Is it documented anywhere to move the torrent files from one computer to a Raspiblitz node? I have the torrents seeding on a Windows computer and want to copy it locally to the Raspiblitz node using Rclone.

Is it documented anywhere to move the torrent files from one computer to a Raspiblitz node? I have the torrents seeding on a Windows computer and want to copy it locally to the Raspiblitz node using Rclone.

Did you search the main Raspiblitz page for words like "blockchain" and "copy"? your answer is there.

All the instructions I can see refer to copying over a fully sync'd
blockchain, not just the torrent files. An explanation on where the torrent
files should be copied so the node thinks it has performed the torrent.
On Thu., 25 Apr. 2019, 08:58 Brad<EMAIL_ADDRESS>wrote:

Is it documented anywhere to move the torrent files from one computer to a
Raspiblitz node? I have the torrents seeding on a Windows computer and want
to copy it locally to the Raspiblitz node using Rclone.
Did you search the main Raspiblitz page for words like "blockchain" and
"copy"? your answer is there.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rootzoll/raspiblitz/issues/502#issuecomment-486458147,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF3GO4FVIA3MXOAXNB6DRGLPSDQYTANCNFSM4HET67FA
.

@bitsam I added your question to the FAQs of v1.2 - see:
I have downloaded the torrents on another computer. How do I copy them to the RaspiBlitz?
https://github.com/rootzoll/raspiblitz/blob/v1.2/FAQ.md#i-have-downloaded-the-torrents-on-another-computer-how-do-i-copy-them-to-the-raspiblitz
You need both torrents to be downloaded on your laptop for that. You need merge both torrents files now to a full blockchain copy. Stop torrent app. Copy all downloaded data from update torrent into the directory of the base torrent. Not you have a copy of the full blockchain in one directory and you can continue like in the FAQ case above "I have the full blockchain on another computer. How do I copy it to the RaspiBlitz?"

Update:
Blockchain is using rsync
Lnd backup is using scp
Can this be close or something else to add to this discussion?

Closing. If still an issue or need for discussion - please reopen or comment.


Create resources page

Create a page with resources such as links to Privacy Badger, HTTPS Everywhere, VPN suggestions, and other resources as a reference that members can both use and refer others to.

+1, as well as links to papers, tutorials, etc. Thanks!


Add Rollback template to setup templates

TLDR; this PR implements an example script which shows that a rollback transaction should explicitly set the nonce returned by _getNonce() using an .env var. Hopefully this template will help avoid issues seen below.
Full context:
In executing mainnet/2024-03-05-pause-unpause-test we ran into an issue wherein the signatures were being incorrectly ordered by the execution call. This was leading to reverts since the Safe requires that signatures are arranged in address-ascending order.
The root cause was traced back to the fact that _getNonce was being overwritten by the following:
    function _getNonce(IGnosisSafe safe) internal override view returns (uint256 nonce) {
        uint256 _nonce = safe.nonce();
        console.log("Safe current nonce:", _nonce);
        console.log("Incrementing by 1 to account for planned `Pause` tx");
        return _nonce+1;
    }

This was fine for signing and simulating the transaction because these occurred before the preceding Pause transaction had been submitted. But when it came time to execute the transaction, this nonce increment was used in the execution context causing the hash used by ecrecover to differ from the correct hash. In turn, this lead to invalid addresses being returned which were then used to sort the signatures incorrectly.

Review Error for OKEAMAH @ 2024-07-13 21:31:35 UTC
User must have write permissions to review


Fixed AAD logic bug and add header parameter[versionId]

Fixed AAD logic bug and add header parameter[versionId]

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ci(release): remove carthage steps

Summary
Provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.
Other Information
If there's anything else that's important and relevant to your pull
request, mention that information here.
Thanks for contributing to the Watson Developer Cloud!

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Use print() function in both Python 2 and 3

print() is a function in Python 3 so these modifications are compatible with both Python 2 and 3.

I'm curious why you need this? Currently MacVim's dmg building doesn't create a EULA file in the output dmg file, and therefore it never calls this file (dmg-license.py). The Python code in it should never be invoked as far as I can tell. I would prefer not changing this repo's files (create-dmg) since it comes from an existing repo and we should try to pull from upstream if there are things we want to fix.

Can you please provide the URL to upstream?

It's in the README file near the file you were editing.
It's https://github.com/andreyvit/create-dmg
But can you provide more context whey you wanted to make this mostly unused script Python3 compatible?


Week select plugin

https://jsfiddle.net/2g3s56us/
Environment

flatpickr version used:4.6.2
Browser name and version:Chrome, 75.0.3770.142 (Official Build) (64-bit)
OS and version: Windows 10 enterprise

After selecting a week it's only showing the clicked date but trough function we can get no, which is fine but however it's should display clicked week range instead of a date.
for more https://flatpickr.js.org/plugins -> week select plugin. it's showing only  clicked date instead of week range.
is there any way to achieve same

You can use hooks to solve the problem. i.e:
onChange(date, dateStr, instance) {
    instance.input.value = [
      instance.weekStartDay,
      instance.weekEndDay,
    ]
      .map(d => instance.formatDate(d, 'd/m/Y'))
      .join(' to ');
  }

Overriding the onChange function you can modify the text of the input, and even change the value you want to get from the flatpickr.
I also think that the default behaviour of a weekSelector should be similar to the range mode: using the weekStartDay and weekEndDay as values and showing the range in the input.

I used this solution. Thanks @Gorzas

I found a gap in Gorzas solution and that is if the input value and selectedDates don't match (which they don't, selectedDates only contain one date) when the picker is closed without having selected a new week, the input value will be reset to it's weekDayStart. An ugly workaround is to do the same thing in the onClose-event as in onChange.
However I think the weekSelect-plugin should function the same as the range-mode, where value and selectedDates are automatically handled. I tried combining the two but it generated further issues and so I think this should rather be included in the source code than outside.
onClose: function (_selectedDates, _dateStr, fp) {     fp.input.value = [fp.weekStartDay, fp.weekEndDay]       .map((d) => fp.formatDate(d, 'Y-m-d'))       .join(' to ');   }


Bug: 2255499 [fusion-hci-4.14] Stop provider upgrade if client gets behind

manual cherry-pick of #2311

merge after #2347


[network] Fix flaky test in connectivity_manager

Motivation
This PR fixes #1045 by removing an unnecessary upper bound on linear backoff in
connectivity_manager test. The upper-bound was randomly chosen and in
reality makes the test flaky. It also does not add much value.

Have you read the Contributing Guidelines on pull requests?
Y

@bors-libra r+

:pushpin: Commit 3a8d824 has been approved by bmwill

:hourglass: Testing commit 3a8d824e80b8c36e2a211eeeb40cbd695968bd17 with merge 167c021e622a32f7765100bb96cb8cba90e6fd27...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: bmwill
Pushing 167c021e622a32f7765100bb96cb8cba90e6fd27 to master...


plugin can't load on Android

When I update to the latest version (both Obsidian and this plugin),it can't be loaded.
Does it use an API that isn't available on mobile?
DEVICE: Pixel 4 XL Android 12

What should I offer?

ohh I reinstalled the plugin and it worded!
sorry for disturbing

I'm very happy to hear that!


Inconsistent auto-complete behavior in Markdown

Type: Bug
A recent VS code version added (or enabled) an auto-suggest option as one types text in a Markdown editor. Unfortunately, this "help" makes typing harder: newlines are interpreted as a desire to select a choice, not the end of the line of typing.
It is not clear that auto-suggest has value when typing in Markdown. Perhaps there is an option to disable it, but I could not find it despite a bit of a search. It is not obvious what the option might be called.
Further, it seems that the suggestions are only those words that already appear in the text rather than words in English (or your language of choice). This means that the set of suggestions depends on the document, not the language, which is a bit odd.
In addition, the feature seems random. I have a large markdown document (about 500 lines). Each time I restart VS Code, I get the auto-suggest pop-ups as I type. But, after a while, they stop appearing. When trying to write up the reproduction cases for this issue, I found that the suggestions stopped appearing at some random time. Needless to say, a random feature a bit of a nuisance.
Reproduction
If, during reproduction, the feature turns itself off, the workaround is to exit VS Code and restart. The feature will work for a while until it somehow decides to turn itself off again. If it does, restart again.
Create a file, 'test.md'. Open it in VS-Code. Begin typing:
the quick brown fox<Enter>

A pop-up box will briefly appear for each word, but will contain only Python (?) suggestions. For example, type foo. You'll get a suggestion for a fenced codeblock which isn't actually common in Markdown. No actual word choices appear because the document is empty: it has no symbols to match. Now, type the same text in a second line:
the quick brown fox
the quick brown fox|

Now pop-ups should appear that shows existing words in the document that match the word typed thus far. Now we can get to the main problem. Type a third line and try to add a newline:
...
the quick brown fox<Enter>

When the cursor is just after "fox", and the auto-suggest pop-up appears. When we type <Enter> (the key, not the word), this accepts the current selection, "fox" in the pop-up. This leaves us with:
...
the quick brown fox|

That is, we just accepted the choice "fox" and are still on the same line. We have to press <Enter> a second time to actually get a new line. This is true only when the word you just typed is one that appeared before in the document, or happens to match one of the Python suggestions. You need to type <Enter> once if the word appears for the first time, twice if the word previously appeared.
While this may be convenient for poor typists, it is frustrating for fast typists: the <Enter> is randomly ignored leaving randomly joined lines.
Suggestions
Please provide an obvious option to disable this feature. A search for "Completions" found "Python: Completions Enable" and the same for Java, but nothing for Markdown. Searching for "Intelli" found a bunch of Editor "Suggest: Show X" options such as "Show Variables". Might the Markdown editor think that words are variables? A search for "Markdown" found 41 options, but none that seem to relate to auto-completion.
When the feature is enabled, have it work all the time. (Or, conversely, when it is disabled, have it work none of the time.) Random deactivation is a bit confusing. At present, once the feature is disabled, it is disabled across all Markdown sessions in the same session. Thus caused confusion when I tried to write up the reproduction above and found that, when I created a new document, the feature had turned it self off on that document and the original one. For now, however, the workaround seems to be to wait until the feature turns itself off before doing serious typing in a Markdown document.
For those who wish to use the feature in Markdown, provide an alternative to <Enter> to select a choice so that <Enter> is always read as a newline, not as a "select the current choice" some of the time.
Finally, note that Markdown is special: it is basically text. It is not a programming language, so helping pick out code structures and variable names isn't as useful as it is in actual code editors. That said, for poor spellers, showing word from a spell-check dictionary might be helpful, but not at the cost of having to double-type <Enter>.
 This is how the UI looks when the auto-complete feature is active in Markdown:

In my setup, the auto-complete feature is active when VS Code starts. However, as soon as I switch to another window, the feature becomes disabled. This gives us a workaround: for now, to avoid the hassle of double <Enter>, switch to another window, then back after restarting VS Code.

I think you've turned on editor.quickSuggestions here. By default this is enabled for programming languages but disabled for markdown
First make sure you not accidentally overridden this setting somewhere in your settings. You can also explicitly turn it off again for just for markdown using a language specific setting:
 "[markdown]": {
    "editor.quickSuggestions": {
      "other": "off"
      "comments": "off
      "strings": "off"
    }
  }

@mjbvz, thanks for your suggestion. This is not just a question: it is a bug report.
I had not modified this setting (I learned about it from your comment). Here is a screenshot of setting I found opening settings and searching for "quick":

Notice that it says "Modified elsewhere". It says this for both the User and Workspace settings. According to the docs, these are the only two sources of settings. So, where is the "elsewhere"? Should this be made clearer as to the actual source? I realize that tracking the source for each option is tedious; been there with previous systems. But, at least list the possible sources up the inheritance chain, if only in the documentation.
Your comment also does not address the odd behavior I reported: when I first open VS Code, the described behavior occurs. If, however, I switch editors, and then switch back, the suggestions no longer appear.
I played with the setting. Turning the above setting "off" does prevent the suggestions when I restart VS Code. So, thanks for that.
However, when I turn it back "on", the the setting takes effect only when I first restart VS Code, on the first editor. As described above, switching editors and switching back to Markdown disables the suggestions. Should the feature be consistent? If it is on, stay on.  The feature would be more useful, when I need it, if I didn't have to restart VS Code for each editor switch.


capabilities.json missing in alpha package (3.0a7)

install latest alpha build of the library
work in debugging
error when make exe with pyinstaller in raspberry pi
FileNotFoundError: [Errno 2] No such file or directory: '/usr/escpos/capabilities.json'

I have had the same problem this morning in development mode because I forgot to initialize the submodule for the capabilites. @patkan it is possible that you made the same mistake as me, forgetting to initialize the submodule before releasing the 3.0a7 version?

@MicroJoe thanks for reply
i dont understand. can you explane exactly what do i do?

@sajjadaemmi we have a file called capabilities.json which comes from https://github.com/receipt-print-hq/escpos-printer-db and is included as a git submodule.
If all ties break, you can add the json somewhere to your file system and pass it on as an environment variable: https://python-escpos.readthedocs.io/en/latest/user/usage.html#advanced-usage-change-capabilities-profile
@MicroJoe I am quite sure, that I have intialized the submodule, however, I made some slight changes. All in all I don't like this feature since it has been introduced. There is something broken with the packaging on some platforms (as I am symlinking it from the submodule into the python module and then hoping that setuptools grabs it). I will see how to rework this properly. (Maybe by implementing a hook in setup.py that moves the file into the package)

I just unpacked the 3.07 wheel and the capabilities.json is contained. For the packing process I will make another issue as I will have a look, but I am quite sure, that the json is in the 3.0a7 release.

@patkan i still dont understand what do you mean
in raspberry pi i use
sudo pip3 install python-escpos==3.0a7
then run pyinstaller for make executable file. and when run file. show this error:

What I mean is, that the installed python-escpos should contain the capabilities.json. You could check by having a look in the site-packages directory of your python-distribution or by trying it out in a local python script.
You can find your site-packages by running python -m site. In there should be a directory escpos and in this directory should be a capabilities.json. If this is the case everything is correct. I am not sure what pyinstaller is doing, maybe it is changing the way that the package is structured.
As mentioned, if your program cannot find the capabilities.json, then you can place it in a directory and set this path through an environment variable. Details on this are in the linked part of the documentation.

Can you do what I did?
it helps to find the bug Sooner

I am sorry, but I do not have the time to debug your pyinstaller setup. I am quite sure that the 3.0a7 should include the capabilities.json which is missing in the pyinstaller output that you sent. I am happy to search for the issue if you can show me, that this file is in fact really missing in the wheel install. (I checked on my system and there it is installed)
I am assuming that it might be an issue with pyinstaller not grabbing up the data file. I had a glimpse into the documentation of pyinstaller and it seems possible to explicitly mention data-files in order for pyinstaller to include it.
If you want to try an easier way, you can, as I said, set an environment variable pointing to a capabilities.json (like https://github.com/receipt-print-hq/escpos-printer-db/blob/3b5b35cfd35d297f9085ec16d47d1f77c3f1e768/dist/capabilities.json)
Apart from that I have created #397 which uses pkg_resources for retrieving this file. According to the documentation this should be more robust than searching for the file in the installation (as it is down at the moment). It might be the case that pyinstaller can handle this better.
I have created a wheel from the development version in #397:
python_escpos-3.0a8.dev19+gb9e3827-py3-none-any.whl.zip
If you download this file, remove the .zip file-ending (I just added it in order to upload it here) and install it with pip you can directly check it without waiting for a release of a new version.

Hi @sajjadaemmi, not sure if you have seen it, but a new version of the package is released since some time. It changes the way the json is referenced, and maybe your installer package can grab this more easily.

As there is a new release that might be fixing this issue, I am closing it. Feel free to open a new issue referencing this one, if it persists in the new release.

@patkan no new release founded!

@sajjadaemmi Please check again, on PyPi you can find https://pypi.org/project/python-escpos/3.0a8/ That is the one that I have mentioned in May.


Update samples because add_triplet_to_cachekey tag is deleted.

It seems add_triplet_to_cachekey tag has been deleted but the samples are still using it.
My workflow using that tag resulted in error.
So the samples should be updated, I think.
Best regards!

@crupest thanks for reporting this issue! Fixed in https://github.com/lukka/CppBuildTasks-Validation/pull/5


July 25th, 2022 Community Meeting

Please add a topic in this thread and add a link to the GitHub issue associated with the topic.
Please make sure you give folks enough time to review/discuss the topic offline on GitHub before coming into the meeting
(optional) Paste the image of an animal 😸

Documentation Review:

Documentation process
Discussion about the best approach to get documentation correct and reviewed (separate issue vs with the feature)
Conclusion:

when you open a pull request with a new feature or similar, then include Rolfe as reviewer
if Rolfe is on PTO (he is American = he is never, his joke ;-) ), then we can merge a change and open an issue for Rolfe to post-process

Status of move to adoc:

Website: one remaining issue with Syntax highlighting; need to get a gem installed for it, working with Adam on it; PR is https://github.com/shipwright-io/website/pull/84
How to get migrated things back to in synchronization?

Rolfe: ideally we would only have the documentation in one place (= website)
Sascha: not unreasonable but we need a solution to eventually be able to have versioned documentation
Rolfe: need to investigate that

Develop guidelines for docs:

Matthias: we something in internal projects
Rolfe: can put something together, there is tool that helps (newdoc), but that's likely overkill


QT: scrollable toggles panel, show description on click

Nice, does this look like the current UI?

Looks good :)

Tried it out on a device, and I like it! The scrolling doesn't feel quite right, but @iejMac is fixing that in https://github.com/commaai/openpilot/pull/20392. Waiting on fixing scrolling on QCOM2 to merge.


Update jmxtrans user ulimits + adjust nproc for hbase user

Per a suggestion from HWX, the jmxtrans user should have the same ulimit values, and hbase user should have the same nproc.

Did anyone have a good reason why JMXTrans would need 65k processes? We don't open that many JMX connections on a 1k node cluster.

For reference we have seen datanodes hit their ulimits which would some how cause JMXTrans to fail to reap threads and its small ulimit limited it from needlessly eating thread handles. I would like to keep JMXTrans bounded unless we see it failing when all things are running as expected or have a theory on why it would legitimately need more threads.

@vt0r Will revert by committing an update explaining we are limiting jmxtrans explicitly to our default ulimits as we have seen it hold open sockets and we do not want to allow it to eat all available ports.


Thymeleaf 3

Is there any plan for having a Thymeleaf 3 integration? We are currently migrate from Thymeleaf 2 to Thymeleaf 3 but the ff4j-web module is only working for Thymeleaf 2.

Hi,
I understand the issue, that this is one of the limit of an embedded servlet (dragging some dependencies not compatible with the host application...).
Thymeleaf 3 is out for 8 months now, we didn't notice this release. We are not against moving to thymeleaf 3, it make sense. Yet It is not easy to estimate the migration effort.
I can suggest 3 things.:

I let the issue opened and include it as soon as I can, maybe 1.7.x as it's a broken change. Il will definitively be part of 2.x in progress on dedidacted branch. We can expect to be ready for june.

You can have look here where all thymeleaf stuff are here, here and here. As you are in the middle of process of migration you may easily change this few classes and propose a PR

You may consider to create a small dedicated backend administration application hosting the  ff4j servlet, to decoupled from other applications. This application will point on the same FeatureStores are your applications (Databases, not in-memory).

Enjoy!

Hi,
thx for the comprehensive  answer. :)
I made a branch where I added the thymeleaf 3 dependencies and migrated the thymeleaf classes so that I can deploy a different ff4j-web module.
This branch contains only a few straight-forward changes as you can see here.
This will work for us by now but I don't think this is the kind of integration you want to have for everyone.
On the midterm it makes maybe sense to have a submodule for a thymleaf 2 integration and a submodule for the thymleaf 3 integration so that the user can decide what he wants to use since thymeleaf 2 is still pretty common.

We are using the Thymeleaf3 for some time now, specially with the spring boot starter


Patch for SNX address resolver

Automated SNX Issuer address
solution tested
successfully deployed on OP Kovan
needs user tests

Steps to apply:

upgradeStaking (script)
write/update address of AddressResolver on Staking

We need an upgrade proxy script that also sets the resolver address after the proxy was upgraded.

@kirilantevski please pull from main to resolve conflicts


releases: make releases of all modules prior to v3.1 release

Checked: Release PR created
Crossed-out: Released on PyPI

[x] invenio-admin: v1.1.1
[x] invenio-app: v1.1.0
[x] invenio-assets: v1.1.2 (inveniosoftware/invenio-assets#95)
[x] invenio-accounts v1.1.0 (inveniosoftware/invenio-accounts#275)
[x] invenio-access: v1.1.0
[x] invenio-base: v1.0.2
[x] invenio-i18n: v1.1.1
[x] invenio-logging: v1.1.0
[x] invenio-oauthclient v1.1.2
[x] invenio-indexer: v1.0.1
[x] invenio-oaiserver: v1.0.3 inveniosoftware/invenio-oaiserver#160)
[x] invenio-records: v1.0.1
[x] invenio-theme: v1.1.2 (inveniosoftware/invenio-theme#129)
[x] invenio-records-rest: v1.3.0
[ ] datacite v1.0.2 (inveniosoftware/datacite#42, inveniosoftware/datacite#45)
[x] flask-webpack: v1.0.1
[ ] idutils: v1.1.1 (inveniosoftware/idutils#45)
[x] pytest-invenio: v1.1.0 inveniosoftware/pytest-invenio#31)

Modules released


Fixed: TypeError: Cannot read property 'id' of undefined

Motivation and context
Resolved #2523
Also fixed a couple of React warnings
How has this been tested?
Manual testing + cypress tests are in progress
Checklist

[x] I submit my changes into the develop branch
[x] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[x] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Coverage increased (+0.009%) to 61.833% when pulling 355afcba7bab24d517dca6df6f18327594c9790b on bs/fixes into 76ff7eff03a2f16a72f84e8bc9f1e4862b91e6bb on develop.


Too many Twitter API requests are being made at runtime

Introducing Backstop in #326 has revealed rate limits on the Twitter API: 300 user lookups per 15 minutes. It views the same editorial community page with 29 followers, requesting it 3 viewport sizes * 2 environments, leading to 174 requests. So, running it twice within 15 minutes will break. Also, as the same key is used in prod and staging, they are also affected.
Real traffic to the site would also trigger the problem.

https://github.com/sciety/sciety/blob/64cc0c3e913c100dee8aff598eb4d939a84ca0af/src/user-page/index.ts#L52

We started getting alerts about this, given the number of errors being in the 50s probably the community page:
app_message
Request to Twitter API for user details failed
app_payload.data
Rate limit exceeded
app_payload.error.config.headers.Accept
application/json, text/plain, */*
app_payload.error.config.headers.Authorization
--redacted--
app_payload.error.config.headers.User-Agent
axios/0.19.2
app_payload.error.config.maxContentLength
-1
app_payload.error.config.method
get
app_payload.error.config.timeout
0
app_payload.error.config.url
https://api.twitter.com/2/users/1120053445552214017?user.fields=profile_image_url
app_payload.error.config.xsrfCookieName
XSRF-TOKEN
app_payload.error.config.xsrfHeaderName
X-XSRF-TOKEN
app_payload.error.message
Request failed with status code 429
app_payload.error.name
Error
app_payload.error.stack
Error: Request failed with status code 429
at createError (/app/node_modules/axios/lib/core/createError.js:16:15)
at settle (/app/node_modules/axios/lib/core/settle.js:17:12)
at IncomingMessage.handleStreamEnd (/app/node_modules/axios/lib/adapters/http.js:236:11)
at IncomingMessage.emit (events.js:326:22)
at endReadableNT (_stream_readable.js:1252:12)
at processTicksAndRejections (internal/process/task_queues.js:80:21)

Also another alert on timeouts, which are more likely with an high number of requests being performed:
app_payload.error.config.url
https://api.twitter.com/2/users/--redacted--?user.fields=profile_image_url
app_payload.error.config.xsrfCookieName
XSRF-TOKEN
app_payload.error.config.xsrfHeaderName
X-XSRF-TOKEN
app_payload.error.message
connect ETIMEDOUT <IP_ADDRESS>:443
app_payload.error.name
Error
app_payload.error.stack
Error: connect ETIMEDOUT <IP_ADDRESS>:443
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1145:16)
at TCPConnectWrap.callbackTrampoline (internal/async_hooks.js:129:14)


editing classes/objects

really like this project, was just wondering how do we edit classes and/or objects

Thanks Charles! Editing some data types still is not supported, such as pointers, relations and arrays, but for other basic ones left swiping on an object cell should bring up the option to edit or delete the value. I did add support so that if an object does contain a pointer you can easily tap the cell to view the object it is pointing too.


code release

When are you going to release the source code?

soon :) waiting for the paper to get published or accepted and I will release the code. I may also do it earlier if I find time to clean it !


Typo in Create a self-signed SSL certificate section

Typo in Create a self-signed SSL certificate section:
Currently:
python api-key-secret-manager-upload.py.py -s openAiApiKey
Should be:
python api-key-secret-manager-upload.py -s openAiApiKey

Thanks again , it is fixed - https://github.com/aws-samples/rag-with-amazon-bedrock-and-pgvector/commit/91c354c887866463293e825111aa86eb80553cd1


fix(51225): Go-to-definition on case or default should jump to the containing switch statement if available.

Fixes #51225

@microsoft-github-policy-service agree [company="IE Zaytsev Svyatoslav Vladimirovich"]

@microsoft-github-policy-service agree agree company="IE Zaytsev Svyatoslav Vladimirovich"

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

/////*c*/export default { [|/*a*/case|] };
////[|/*b*/default|];

Is it normal that b and goes to c? This is how it works now. It looks like a bug.

It's questionable, but I wouldn't get hung up on fixing that specific case.

hm Sorry, I thought I needed to request a review from everyone. But only one allowed.

@sandersn I change contextSpan to keyword + expression, but i can't find any examples for testing contextSpan with fourslash

Good to go @sheetalkamat?

Any progress? @sheetalkamat

@typescription pack this

@typescript-bot  pack this

I am working on framework to test contextSpan with goto def which we should merge and then rebase this PR so its clearer on what is the context that is being set for contextSpan. Will link PR here once i have it ready

@sviat9440 #52576 is up and once that is merged you should be able to update your PR with the baselines that verify context,
Having said that, i completely mis-read context Span to be first line of declaration. It is infact the complete declaration. With that in mind i think your earlier change of having contextSpan as complete switch statement was correct and you would want to go back to that behavior. Sorry for misdirecting you on that one.

#52576 is merged. Feel free to merge changes from main and baseline


Edit command - Nguyen

@Singa-pirate I have fixed the raised issues. However I think the error messages might have to be changed. Please advise.

@Singa-pirate I have fixed the raised issues. However I think the error messages might have to be changed. Please advise.

Looks great to me. The error messages are okay, I'll modify a little bit to accomodate the delete command in my PR later.
You can merge this PR if there are no more edits. Thanks!


On-Screen Keyboard

As arleady said in the user stories, I would like to create an on-screen keyboard. I'm working on the class key. The problem is figuring out how to instantiate about 60 object. Would it be advantageous to create an array? Is there another better way?

An array is a good choice. Your implementation until now is fine and I suggest you continue on this way.
Out of curiosity, other ways are:

ArrayList, useful for dynamically changing lists (not your case)
Dictionaries (for example StringDict, to access an element of an array using an user-defined String key instead of the integer index
HashMap, a generalization of dictionaries, where you can access an element of any type of array with any type of key


clean docs and publish

Description of the changes
References:

Manual test for the reviewer

Check list for the reviewer

[ ] best software practices

[ ] clearly named variables (better to be verbose in variable names)
[ ] code comments explaining the intent of code blocks

[ ] All the tests are passing
[ ] The documentation is up to date
[ ] code comments added when explaining intent

Check list for the pull request

[ ] source refactored/incremented
[ ] tests for my changes
[ ] updated the documentation accordingly

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.37%. Comparing base (6f1405b) to head (bf64a0d).

Additional details and impacted files
@@           Coverage Diff           @@
##             next      #97   +/-   ##
=======================================
  Coverage   35.37%   35.37%
=======================================
  Files          30       30
  Lines        6061     6061
=======================================
  Hits         2144     2144
  Misses       3917     3917

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix "prefer-const" issue in src/Service.js

history is never modified, use const instead.
https://codeclimate.com/github/janbiasi/vanage/src/Service.js#issue_57887ed54fb7650001070657

Service Class, Line 150

Should be fixed by the next release.

Fixed by commit 3bfd057


🐛 Bug Report: Techdocs Code block copy to clipboard text overlapped with code

📜 Description
It bugs out when we have long single line of code in code block. When I clicked on the copy button, the text 'Copy to clipboard' overlapped with the code behind.
👍 Expected behavior
not overlap with the code behind will be nice, maybe just show a 'copied' text on top once user clicked the copy button
👎 Actual Behavior with Screenshots

👟 Reproduction steps

Create a techdocs
Add a codeblock in that md file with long single line
Run techdocs-cli serve

📃 Provide the context for the Bug.
Small minor issue, but a lot of our users complaining about this issue.
🖥 Your Environment
OS:   Darwin 23.4.0 - darwin/arm64
node: v18.19.1
yarn: 1.22.19
cli:  0.26.4 (installed)
backstage:  1.24.2
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, I don't have time to work on this right now

Hi I'm interested to Work on this issue, please assign me this.

Sure, open a PR so that we can discuss 👍


Reduce memory usage

lens app  should Reduce memory usage in mac

Environment you are Lens application on:

Desktop OS: mac 2015

3.5.1
mycluster is 5

3.5.1 is no longer supported. If this is still an issue, please open a new issue.


Better Hyundai and Genesis Support, Better future model scaling

This includes https://github.com/commaai/openpilot/pull/481
So should be merged only after #481 is merged
Comments I will place in changes

This should have driver-torque-reduction modified, due to the different steering wheel torque value.
Can you test on your Santa Fe and suggest the setting you feel suits best?
I would prefer every model use the new message for steering torque, as it is present on all cars, where the one that was in use is not present on all cars.

I'm going to close this and revisit this when I have more time.


Cannot build the code

Missing timer.h, symbolic.h while compiling

Can you please show the complete 'make' output, especially the error part? Those files are in include/ and are included by makefile already

I made some modification in the Makefile as it was not detecting the cuda path. The missing file error is not coming now. However, I'm currently facing the error as below.
"/sw/summit/cuda/10.1.243/bin/nvcc" -O3 -arch sm_35 -Xcompiler -Ipreprocess -I../include -Inicslu/include -c numeric.cu -o numeric.o
In file included from /usr/include/c++/4.8.2/unordered_set:35:0,
from ../include/symbolic.h:4,
from numeric.cu:4:
/usr/include/c++/4.8.2/bits/c++0x_warning.h:32:2: error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support is currently experimental, and must be enabled with the -std=c++11 or -std=gnu++11 compiler options.
#error This file requires compiler and library support for the
^
make: *** [numeric.o] Error 1
The updated Makefile is below:-
Makefile
DEBUG = 0
CUDA_PATH = /sw/summit/cuda/10.1.243/
LU_INC = -Ipreprocess -I../include -Inicslu/include
CUDA_INC = -I$(CUDA_PATH)/include
CUDA_LIB = -L$(CUDA_PATH)/lib64 -lcudart -lcuda -lcublas -lcusparse
PREPROCESS_LIBS = preprocess/preprocess.o nicslu/lib/nicslu.a nicslu/util/nicslu_util.a
NVCC = "$(shell which nvcc)"
CPP = "$(shell which g++)"
EXE = lu_cmd
CFLAGS = -O3 -m64 -Wall -std=c++11 $(LU_INC) -DGLU_DEBUG=${DEBUG}
NVCCFLAGS = -O3 -arch sm_35 -Xcompiler $(LU_INC)
MAIN: $(EXE)
lu_cmd: Timer.o numeric.o symbolic.o lu_cmd.o $(PREPROCESS_LIBS)
$(CPP) $(CFLAGS) $^ $(CUDA_LIB) -lrt -lpthread -o $@
Timer.o: Timer.cpp
$(CPP) $(CFLAGS) -c $< -o $@
numeric.o: numeric.cu
$(NVCC) $(NVCCFLAGS) -c $< -o $@
symbolic.o: symbolic.cc
$(CPP) $(CFLAGS) -c $< -o $@
lu_cmd.o: lu_cmd.cpp
$(CPP) $(CFLAGS) -c $< -o $@
preprocess/preprocess.o:
make -C preprocess/
nicslu/lib/nicslu.a:
make -C nicslu/
nicslu/lib/nicslu_util.a:
make -C nicslu/
clean:
rm -f *.o *~ *.so $(EXE)
make -C preprocess/ clean
make -C nicslu/ clean
distclean:
rm -f *.o *~ *.so $(EXE)
make -C nicslu/ clean
make -C preprocess/ clean

I think adding -std=c++11 to the line of numeric.o rules would do the work. Anyways, I made an update to this makefile and it should be cleaner now. Can you try again with that?

With the updated code I'm getting following error.
make -C preprocess/
make[1]: Entering directory /autofs/nccs-svm1_home1/anil/GLU_public/updated/code/GLU_public-master/src/preprocess' gcc -c -g -O2 -Wall -Wextra -**msse2** -DNO_ATOMIC -DSSE2  -I../nicslu/include -I../nicslu/util preprocess.c -o preprocess.o gcc: error: unrecognized command line option '-**msse2**' make[1]: *** [preprocess.o] Error 1 make[1]: Leaving directory /autofs/nccs-svm1_home1/anil/GLU_public/updated/code/GLU_public-master/src/preprocess'
make: *** [preprocess/preprocess.o] Error 2
The code can compile in other servers. With the compilation error relate to SSE2, do you think there is some issue when we try compiling in Power9 based system?

I have no experience with Power9 machines. I guess it does not support sse2 instructions and thus the problem. This part of code is related to nicslu, which is another lu solver from which glu uses some functions.
It should be fixable by disabling sse2. Just comment out the -DSSE2 the 4th line of file src/nicslu/make.inc.

Can compile and run after commenting line 4 and 5 at the make.inc.
-Thank you!


Server won't start with arkmanager after latest update 180.2

Today I updated arkmanager via curl -s https://raw.githubusercontent.com/FezVrasta/ark-server-tools/master/netinstall.sh | sudo bash -s steam
then
$ arkmanager update
"Your server is already up to date! The most recent version is 673532."
That was 1 h ago, I knew there was an update, so I did it manually via steamcmd and finally got "Your server is already up to date! The most recent version is 674165."
This is my update.log:
08:30:17: update to 669428 complete
20:16:34: No update needed.
20:17:17: No update needed.
09:11:33: No update needed.
09:13:01: No update needed.
09:17:17: No update needed.
09:45:38: No update needed.
When I now start ShooterGame via "arkmanager start" with my arkmanager.cfg, I get a Signal11 crash.
[S_API FAIL] SteamAPI_Init() failed; SteamAPI_IsSteamRunning() failed.
Setting breakpad minidump AppID = 346110
Signal 11 caught.
I can start the server manually but can't get it to start via arkmanager. Worked fine until the last ShooterGame Update.
Can you point me in the right direction where to find some logs to the problem?

First things first;
:white_circle: What distro are you running?
:white_circle: Did you update your config files accordinly to the update of arkmanager?

We have added a variable inside the configuration of arkmanager 1.1 to fix this problem. If you have upgraded your ARK Server Tools but you have not updated your configuration then you'll have this problem.

Fresh Ubuntu 14.04 VPS.
Checked arkmanager.cfg and gameusersettings.ini. Problem seems when you update arkmanager it keeps the old .cfg file so I was missing the "steamcmd_appinfocache=". Sorry I missed that, it's running now.
Can you make it that the old .cfg will be kept but there is a copy of the new .cfg in /etc/arkmanager?

@tenten36 Thank you for your suggestion. I've added that in a PL now.


Track airTime

#84

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Nicolasdejean:x: nicolas-dejean


Gif or static screenshot in README.md?

Sounds like a good idea.. I'll add one as soon as I get this back into a proper working state ;)

I've added a screenshot in the entity branch which is the one I'm working on at the moment.
You can check it out there: https://github.com/tanis2000/minigame-rust/blob/entity/README.md
@coder543 the code itself works but it's a bit of a mess as I'm basically using this project to experiment with various design patterns and trying to build some tools.
I'm actually trying to find a good design architecture so that I could have a tool that takes care of creating a game template that uses this as the base engine and that can compile to all the different platforms. It's not that easy though as there are a lot of parts involved and I could definitely use some help.


[Feat:] Generate Random color cards on the audio section as Spotify

Description
A clear and concise description of what the PR does.

This PR does the following:

Adds ...
Fixes ...
Updates ... Generate Random color cards on the audio section as Spotify which is user experience

Related Issues
Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.

Placeholder: "Fixes #288"

Changes
List the detailed changes made in this PR.

Added a new feature to ...
Refactored the ...
Fixed a bug in ...

Testing Instructions
Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

Pull this branch.
Run npm install to install dependencies.
Run npm test to execute the test suite.
Verify that ...

Screenshots (if applicable)
Add any screenshots that help explain or visualize the changes.
https://github.com/Satyam1923/Spring-Music-Player/assets/121508628/82108bfe-c4d3-4ce5-ba13-1f0d5ec06c18
Additional Context
Any additional context or information that reviewers should be aware of.

This PR is based on the following...

Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.

[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[x] I am working on this issue under GSSOC

If it's not good, please assign me again I will do it better

@SrinivasDevolper dont push node modules and development is also failing.
As I can observe some color are looking good some are not do you have any suggestions regarding that.

Ok sure, I'll do it better and I'll do it after updating the I'll add


new release?

The current version on Hackage fails for GHC 8.2, looks like that's been fixed in master since November though.

It would be great to get a release of this out the door. Ping @mightybyte
It's now affecting my ability to upgrade too.
Cheers!

Hmmm, I was hoping I could sneak 8.4 support in at the same time since this is a major version bump.

Status update: still waiting on postgresql-simple support for 8.4.

Thanks for the update! A non-maintainer upload for postgresql-simple was requested here, but that will take at least two weeks to go through.

New version released as <IP_ADDRESS>.

Thanks a lot!


Update Navigation menu

Hide Grants and Submissions from non-logged-in users
Change "Home" to Dashboard
Will submitt a separate ticket to pull the latest submissions and grants to the dashboard page.

verified on rev. b0b535cb


Modify the language on the landing page

Update the language on the landing page to reflect changes in the attached document.

Here we go (with the background image):

Closing this ticket.


Implement RFC0044: Disable SBOM

Describe the Enhancement
This buildpack should opt-in to allowing users to disable SBOM generation. In doing so, it should conform to RFC044.

When BP_DISABLE_SBOM is set to true, buildpacks that allow SBOM to be omitted from their output should refrain from generating or attaching an SBOM in their outputs. This would apply to both new (Syft, CycloneDX, and SPDX formats) and old (label) SBOM outputs.
Additionally, when this variable is set to true a buildpack should set an image label of io.paketo.sbom.disabled to true. This label interface would allow downstream consumers of the image to understand that SBOM generation had been explicitly disabled.

Possible Solution

Motivation
SBOM generation can take substantial time. There may also be other reasons for wanting this functionality to be disabled.

https://github.com/paketo-buildpacks/java/issues/1074


Fix poll_db crash when notifications payload indeces is None

Every time poll_db() tries to process a notification payload that has indices set to None it crashes.
This can happen for several reasons, outdated triggers for instance, or due to other non-tracked changes in the DB pgsync listens to. For example a TRUNCATE in a table of the same DB that pgsync monitors but does not sync.
This PR fixes this by adding a simple check for a None value before trying to search the payload indices list.
Adding a test is challenging because the current code does not provide a way to control/exit the db_poll thread loop, hence you cannot exit the loop from a test once started. This requires a refactor that I think is out of the scope of this fix.
BTW, you should really think about having a stable branch with the latest release, main is currently broken and tests do not pass. This makes contributions much harder for other devs because there is no simple way to verify the fixes do not introduce secondary effects. You have to checkout the tag, cherry pick the fix commit, run the tests, and then make a PR against main.
Thanks for all your hard work and dedication to this project @toluaina, it's very useful and very much appreciated.

@toluaina is this project active?

@toluaina is this project active?

Apologies, I've had very important life commitments.
Yes it's is very much active.

Thank you again!


feat(dag): Revert pipeline changes and instead roll up expressions on the fly per query

Reason for Change

#3845

Previously, in #3889, I updated the processing pipeline to roll-up the expression counts. However, it's actually not possible to precompute the rolled up expressions while respecting the secondary filters. To accurately display rolled up expressions, we must first know which subset of the corpus we are looking at (where the subset is defined by the secondary filters and the tissue). The existing approach of naively rolling-up the expressions across all the unique groups in the expression_summary cube is not accurate because we will start double counting when the query aggregates according to the secondary filters & tissue.
As a result, the most straightforward strategy is to calculate the rolled-up expressions on the fly. For the small dataframes that are being returned by the query, the rollup computation time should be negligible.
In summary:

To accurately calculate rolled up expressions, we first need to know which secondary filters (if any) are selected.
Then, we can compute the rolled up expressions per tissue.
Thus, rolled up expressions cannot be precomputed and we must compute them on the fly.
The roll-up operation should add a negligible amount of time to the query.

Changes

Revert #3889
Add on-the-fly rollup to the query API.
Update the rollup function in rollup.py to accept a tidy dataframe and infer the dimensions across which the numeric columns will be aggregated.

Testing
RDEV STACK
Quick performance comparison

Go to lung
Find marker genes for ciliated cell
Add to dotplot
Query response time:

With rollup - 15.5s
Without rollup - 15s

The overall motivation for this and code updates make sense, but I haven't done a deep review, so not explicitly approving. Added a handful of nits to consider.
On the PR or issue you might want to provide a short before/after performance comparison for the affect endpoint(s), in case API request times are increasing too much.

thanks andrew! agree with all your feedback and made relevant updates. Also added a cursory performance comparison to the PR. Will do a bit more comparisons for different scenarios (e.g. many tissues selected) and report those shortly


glm-4 voice support?

when?

Sorry, this issue was lost for a very long time
I did some brief investigation and can't see if there're any developer-friendly ways to run inference for GLM-4-Voice, with OpenAI-compatible APIs. I'm open to the integration when any such service is available


Operation type directive is overriding directives defined in ancestor fields

In the following query, all directives declared in the ancestor fields are lost, only the ones in the leaf fields are parsed correctly from the AST:
query {
  ancestorField @thisDirectiveIsLost {
    leafField @thisDirectiveWorksWell
  }
}

For instance, in this query the @include directive is lost, and title is included when it should not:
query {
  post(id:1) @include(if: false) {
    title
  }
}

Inspecting the code, I found out that in Parser/Parser.php, function parseOperation, the operation type directive is being set into $operation:
$operation->setDirectives($directives);

However, the $operation already had its own directives, parsed through parseBodyItem. Hence, these are being overridden.
Merging the 2 sets of directives, instead, it works well:
$operation->setDirectives(array_merge(
    $directives,
    $operation->getDirectives()
));

Is that the right solution? Must directives defined next to the operation type be copied into all ancestor fields? And what about leaf fields, which currently have no problem with their own directives? (This solution seems to fix the bug, but I don't know if I may be creating another one? I can't find any reference in the GraphQL spec to what is the expected behavior for operation type directives...)

To clarify: this bug also happens if no operation type directives were defined in the query; in that case, the overriding $directives is an empty array

Ops, I closed by mistake.
This branch in my fork deals with this issue:
https://github.com/getpop/graphql-parser/tree/fix-overriding-directives

Can you make a PR?

Alright. I just added a test, will submit the PR now.

The bug happens only when adding "query" at the beginning of the query:
query {
  user @include(if:false) {
    name
   }
}

This query had no issue:
{
  user @include(if:false) {
    name
   }
}


Update zio, zio-streams to 2.0.9

Updates

dev.zio:zio
dev.zio:zio-streams

from 2.0.2 to 2.0.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #449.

Superseded by #465.


Calculator using html,css

Calculator using html,css #2304

Close #2304

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[] I have created a helpful and easy to understand README.md

Please review my pull request @pranjay-poddar

Project is already present

But it is using JavaScript. In this project I am using only html and css
Please review it
On Sat, 24 Jun, 2023, 1:24 am Tushar Kesarwani, @.***>
wrote:

Closed #2325 https://github.com/pranjay-poddar/Dev-Geeks/pull/2325.
—
Reply to this email directly, view it on GitHub
https://github.com/pranjay-poddar/Dev-Geeks/pull/2325#event-9621800018,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A44ABOYEBCITYEBLGYOOGY3XMXYBHANCNFSM6AAAAAAZKW55QQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Ocluder does not transform

Hello and thanks for the library!
somehow I am having issues with the transformations of the ocluder for face recognition.
for instance
position="1 1 1" rotation="0 0 0" scale="0.1 0.1 0.1"
if i remove the attribute "mindar-face-occluder" i can see the head and the transformations work. so after i position and scale it how I need it, i then re-add the "mindar-face-occluder" attribute and the head ignores the transformations. I can enter position="9 1 1" and it remains in the same location. if i remove the attribute again I can see that the head flew way out of the way. any ideas?

PS: i just removed the head model
<a-entity mindar-face-target="anchorIndex: 168">
        <a-gltf-model mindar-face-occluder position="1 1 1" rotation="0 0 0" scale="0.1 0.1 0.1" src="#headModel"></a-gltf-model>
</a-entity>

and still something is oclusing the hat! maybe that is the main problem?


fix for reading from views with relative path references

Fixes SD-1362

Current coverage is 79.49%

Merging #1075 into master will increase coverage by +0.16% as of 412fd63

@@            master   #1075   diff @@
======================================
  Files          167     167
  Stmts         9680    9684     +4
  Branches       316     316
  Methods          0       0
======================================
+ Hit           7680    7698    +18
  Partial          0       0
+ Missed        2000    1986    -14

Review entire Coverage Diff as of 412fd63

Powered by Codecov. Updated on successful CI builds.

:+1:


Whatsnew for users & sysadmins & CLI signposting

See https://trello.com/c/UloMh1fl/108-document-new-features-in-whats-new-pages-and-on-website
This adds content for Users and Sysadmins and also highlights the CLI docs from the top index page and the User index page ( @rleigh-codelibre pointed this issue out - the change to the 'About the OMERO Platform' heading dated from all the user docs being moved to help but now we have CLI docs here that are basically hidden unless you read everything really thoroughly!)
Still to do

[x] What's new for developers for 5.4.0 See https://github.com/openmicroscopy/ome-documentation/pull/1767
[x] Decide whether we are renaming the secvuln extlink or changing it to use the new website URL rather than /info/vulnerabilities  See https://github.com/openmicroscopy/ome-documentation/pull/1769

Closing this PR since @hflynn is away
I will re-open

Sorry if I am commenting on a wrong PR, but both here as well as on https://github.com/openmicroscopy/ome-documentation/pull/1765 I think I am missing a mention of a new feature in OMERO.web, where Full Admin or Administrator with Restricted Privileges with correct privileges ("Write data") can create P/D/S for others when in single-user view, as described in https://github.com/openmicroscopy/ome-help/pull/251/files#diff-cda682c7f7f039024b036b6a3c4186daR990
Also, there are some improvements on the CLI (chown all belonging to user, see https://github.com/openmicroscopy/ome-documentation/pull/1727/files#diff-b2d2c814858d6db577d2ea5539660db5R43 - note that we probably have to mention that this feature is advanced and might be potentially slow.
Both of these missing features metnioned here are kind of for sysadmins or light admins. It really depends how we define "user" (simple user or superuser) to decide in which What's new they should be mentioned. I would suggest to mention them in both Whats's news (admins and users)
cc @hflynn @jburel


Typo fix in docs. resorses -> resources

oh and by the way thanks for this awesome script :)

Thanks!


Final example doesn't show RadListView on iOS device

I am previewing this playground code on an iOS device: https://play.nativescript.org/?id=WhQU5V&v=341
When I log in and attempt to add items to the list, no items are displayed in the RadListView.
I was running through the tutorial myself, but started getting this error about the listview: Warning: When used inside StackLayout with vertical orientation, RadListView should have an explicit height.
It looks like an update to the codebase is now causing a problem with the tutorial example code.

I am also Facing almost the same problem.


Keyboard mode is unusable with keyboard

When I open timepicker popup and switch to keyboard mode I cannot change focus using Tab and Shift + Tab after focusing hours input. Also could we have ⇅? After Hour and Minute label to make it more clear for users to use up and down arrow key to change them?

Btw. why in dial mode things like hours and minutes are focusable if user cannot interact with them?

I also believe role="slider" should be used in keyboard mode instead of text input.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/slider_role

@dhutaryan here is small example how it could work https://stackblitz.com/edit/ng-slider-clock-as5izns?file=src%2Fmain.ts

Not sure about role="slider". I believe the usual input should work great. We should keep remember that we should follow material design as much as possible.
Tab key fixed in:
17.5.1
16.3.1
15.3.1
14.3.2
13.2.3
12.5.3

@dhutaryan native <input type="time"> have role slider.

@dhutaryan Anyway from spec of material design time picker user should be able to type there using keyboard https://m3.material.io/components/time-pickers/guidelines#14894e49-3cb0-49f0-80ad-932cdb00bb1c

@dhutaryan here are also new ideas how you can improve input behaviours https://stackblitz.com/edit/simple-timpe-picker-mz96hfs?file=src%2Ftime-picker%2Ftime-picker.component.ts


Support declarative DSL style

Explore the idea of adding a DSL stype API, using the builder pattern as other libraries do.
Here's an example of how it's done now:
def p1(R: Fs2Rabbit[IO]) =
  R.createConnectionChannel.use { implicit channel =>
    R.declareExchange(ex, ExchangeType.Topic) *>
    R.declareQueue(DeclarationQueueConfig.default(q1)) *>
    R.bindQueue(q1, ex, rk) *>
    R.createAutoAckConsumer[String](q1)
  }

By introducing a DSL we should be able to do it in this way:
def p1(client: Fs2Rabbit[IO]) =
  client.createConnectionChannel.use { implicit channel =>
    client
      .declareExchange(ex, ExchangeType.Topic)
      .declareQueue(DeclarationQueueConfig.default(q1))
      .bindQueue(q1, ex, rk) *>
    client.createAutoAckConsumer[String](q1)
  }

Both ways should be equivalent but probably the DSL style is more friendly.
Essentially any method returning F[Unit] could be added to the DSL.

I'd honestly rather see one way to do things. It'll be a smaller API to maintain, and it will be easier for consumers (who might be new to cats-effect etc) to figure out what code means and when to use what construct

Thanks for the feedback (and the remainder to look into this). It was more of an idea but I abandoned it as soon as the next day so it was never going to happen :smile:


Add a Web Dynpro ABAP App to Your Launchpad Site

Tutorials: https://developers.sap.com/tutorials/cp-portal-cloud-foundry-webdynpro-app.html
Hi,
I am at the Step 2.
--> Press App
--> Properties enter values
--> Navigation enter values
When I save, I have an error (in French, here the translation)
Error
An error occurred and your changes were not saved.
Try again or close and try again later.
If I do in two step2
--> Properties enter values
--> Save
--> Navigation enter values
--> Save
I got the error here.
The Check connection to the ES5 is ok:
Connection to "ES5" established. Response returned: "307: Temporary Redirect"
Best regards
Fred

Hi  - this has happened to me too before.  I think it's a glitch.  Please try again.  Sometimes it works second time around.  If not, you'll need to open a support ticket.
Thanks Lindsay

The error still occurs in Firefox (I use it because SAP BTP has some display bug with Safari), but when I switch to Safari for another test, it works.
So I close the "bug"


configuration/health_checkers/redis.md

原文：https://github.com/servicemesher/envoy/tree/master/configuration/health_checkers/redis.md

认领


Playtest - Luka!

I love the feel and concept of your game.
The dialogue is super engaging and humorous. There is pressure for every decision as you do not know the value of each of your resources when you start.
I also enjoy the freedom. The goal is sort of whatever you want it to be. You can help with the rise/fall of the empire.
Sadly, I couldn't play the whole game. After the third / fourth interaction, a bug occurs and the game freezes. I tried three times, it occurred every time. If you would like, I could send a video of what the bug looks like.
I wish I could've played more and bring the demise of the Empire!
Questions (answered from what I could play)
1. The game is meant to slowly feed the narrative to the player through these small dialogue interactions. From the limited amount that you’ve seen, do you think that a full-fledged narrative could be accomplished this way?
Yes! In fact, it would be a much more interesting approach.
2. Would this fare better as a 3D game with an actual shop environment? Or is the minimal UI a style of its own?
I like the existing, minimal style. I do not think 3D & crazy graphics would be necessary for this type of game.
3. Should the narrative stakes be lowered? In other words, is the story’s scope and worldbuilding too vast?
I couldn’t say, as I did not experience the full playthrough:(

I only wrote 3 dialogue trees, so that's why the game stops functioning after they have been completed. Ideally, there would be more in a future iteration of the game.


i was trying to uploading some file but it showing me that

https://github.com/mafaca/UtinyRipper#requirements


improvement: consistent false/true flags across settings

Currently most of the settings in the docker image use different ways to parse the true/false flags. Depending on the setting you need to try around with different versions of true and false, e.g. FALSE, false, "FALSE", "false", and the same for true.
To reduce configuration errors and friction when setting up the image, all variables should be able to parse as true or false regardless of their writing.

Agreed. I have been gradually switching to the utility methods in start-utils, but would be good to just make a sweep through all the scripts and unify on that.


Revert "Remove dependency on FSharp.LanguageService (#4108)"

This reverts #4108 until I can figure out what's up with legacy projects
Despite being convinced that I validated .NET Framework projects, source files are plaintext (though scripts aren't) with the change in #4108.

I'm leaning on not having this merged, but given that #4129 is still running CI and master will lead to plaintext source files for .NET Framework-based projects, I think it would be okay to merge this if #4129 needs more work

What about at least single test which checks that files in old style projects are not plane text? I’m surprised that missing of such a fundamental functionality has passed all the existing tests.

I'd have to do that in #4129, not this one. I can see if it's possible to do it in a sane way.  I don't trust the old tests very much. So much of it is about ensuring that dead code paths work.


[1.19 Fabric] My players break chests with dynamite.

How to make it so that the chests could not be blown up with dynamite? My players break chests with dynamite.

Fabric 1.19

Please fix this value in the Lootr fashion itself. So that it was impossible to blow up the chests with beds in hell/edge and dynamites in the ordinary world.

I appreciate your concern but whatever fixes are made will take place when I'm ready. There are a few considerations to make first, though, including things like the Desert Pyramid traps and similar, where the explosion is meant to destroy chests. I need to work out how to consider that properly.

I appreciate your concern but whatever fixes are made will take place when I'm ready. There are a few considerations to make first, though, including things like the Desert Pyramid traps and similar, where the explosion is meant to destroy chests. I need to work out how to consider that properly.

It's not a big deal. I just don't need them to explode there. It's not a big deal. I just don't need them to explode there. Make it so that you can't blow up these chests with anything at all, make them 99999 protection.

I really need it. Just output it as a separate function, many servers will need this theme.

@MrJorman Do you need this feature on custom chests or chests that are part of world generation?

lootr chest, lootr barrel, lootr shalkers, lootr minecarts.

Sorry, maybe I was unclear. Do you need the feature on chests you make yourself using /lootr custom, or chests that are made by replacing structure chests (like dungeons, mineshafts, etc) when a world is generated?

Option 2.

I personally want the first. So it's a item id different to the ones in structures.
If option2 would have to be implemented, then it is either all chests are blast resistant, or none at all. Which imo isn't practical due to your stated reasons about pyramid's chests

It'd be nice to avoid using additional IDs if possible because they are limited in 1.12 without additional extender mods. I'm not sure if it's possible to control explosion resistance with a block state property or not. In any case, I'll follow suit with whatever gets implemented for 1.18/1.19.

need 1.19 fabric really.

ossible because they are limited in 1.12 without additional extender mods. I'm not sure if it's possible to control explosion resistance

I thought we were talking about the current versions that LootR are available. Are there plans to backport to 1.12?

Lootr is available for 1.12.

Oh, Forge version backported

Please add Lootr explosion protection, set the value to 9999 protection, as chests can explode creepers, dynamites, and other things from mods.


suggestion: spell coefficient

is it possible to show the spell coefficient of the hero, like X7.4 atk

it is on the todo list, not a priority though.


Add logging support to s3 bucket to address CIS.2.6

Adds optional bucket logging to comply with CIS Benchmark for AWS item 2.6
Resolves #112 .

How do you avoid the logging bucket "turtles all way down" problem? Since this module creates a logging bucket for AWS logs and if you point the logs for the bucket this module creates at another bucket which then all needs to logs somewhere and etc etc etc.

How do you avoid the logging bucket "turtles all way down" problem?

The first level of logs need to be tamper evident particularly for Cloudtrail.


make renode is broken

Running make renode in proj/proj_template results in this error:
make[1]: Leaving directory '/usr/local/google/home/avg/src/CFU-Playground/proj/proj_template/build'
/usr/local/google/home/avg/src/CFU-Playground/scripts/generate_renode_scripts.py /usr/local/google/home/avg/src/CFU-Playground/soc/build/digilent_arty.proj_template/csr.json digilent_arty /usr/local/google/home/avg/src/CFU-Playground/proj/proj_template/build/renode/ --repl /usr/local/google/home/avg/src/CFU-Playground/proj/proj_template/build/renode/digilent_arty_generated.repl
Traceback (most recent call last):
  File "/usr/local/google/home/avg/src/CFU-Playground/scripts/generate_renode_scripts.py", line 154, in <module>
    main()
  File "/usr/local/google/home/avg/src/CFU-Playground/scripts/generate_renode_scripts.py", line 139, in main
    f.write(generate_litex_renode_repl(args.conf_file, etherbone_peripherals, args.autoalign_memor_regions))
  File "/usr/local/google/home/avg/src/CFU-Playground/scripts/generate_renode_scripts.py", line 47, in generate_litex_renode_repl
    result = litex_renode.generate_repl(csr, etherbone_peripherals, autoalign)
TypeError: generate_repl() takes 2 positional arguments but 3 were given
make: *** [../proj.mk:176: renode-scripts] Error 1

I have seen this error in hps_accel, too.

Hi Alan,
The line 47, result = litex_renode.generate_repl(csr, etherbone_peripherals, autoalign), was a recent change by me to match changes in litex_renode.   This was to get it to work in Github Actions, not interactively.   It may be that we now need to make another update so that it works interactively.
Although I think the interactive make renode was broken even before my change (#256).

@tcal-x Ah, thanks for chasing this down. Not sure if this is still relevant, but I ran scripts/setup again and can confirm that I still see the above error.

Hi @alanvgreen, I checked this on my machine and it works fine for me. I think you may be missing update of LiteX Renode submodule and you may be using version before this change. Please, make sure your submodules are matching submodules in this repo and let me know if there's still an issue occuring.

I ran ./scripts/setup again and got a new version of Renode portable.   This might be a factor.
In proj/proj_template_v/, make PLATFORM=common_soc renode worked.  (Why do I need to specify PLATFORM now?)
In proj/proj_template/, it didn't work.   BUT, if I created an empty subdirectory renode/, then it worked.

The action item is to fix the issue we see when ./renode/ isn't present:  either create it if it doesn't exist, OR, instead use ./build/renode/.    The latter choice seems better.


Citra: Washed out colors until custom layout is enabled

Running on Android 12, Daijishou 394.
When running Citra Antutu (downloaded from here: https://github.com/weihuoya/citra/releases/tag/20230627) stand-alone, everything works fine.
When using Daijishou to launch the same game with that Citra version, a transparent white overlay is shown on the whole screen, resulting in a hazy, low-contrast look with washed out colors.
The only fix is to customize the button overlay, which will make the haze disappear. After that, the custom layout can be disabled again and everything works from there on.
Launching Citra through Daijishou with a custom button overlay enabled still shows the issue. It's only when going into the menu and going to the "custom layout" screen that the issue fixes itself temporarily.
In addition to that, Citra always seems to crash immediately upon the first launch through Daijishou, before starting normally (aside from the issue mentioned here). I'm not sure if the two issues are possibly related.

Whilst investigating this, I came across a Reddit post that suggested disabling the "dark theme" for the system may resolve this. I tried that suggestion and it works: launching Citra MMJ from Daijishou does not show the white overlay. It is curious that launching Citra MMJ from the "Applications" tab never shows the white overlay, regardless of whether the system "dark theme" is enabled.
It's still not obvious whether this issue is caused by Daijishou, Citra MMJ, or a combination.
Test environment:

Anbernic RG405M running GammaOS (LineageOS 19.1/Android 12)
Daijishou 394
Citra MMJ 20230926_StorageAccess_Antutu

I've just confirmed that, when launching from Pegasus Frontend, the white overlay is not shown. I used the following launch configuration:
launch: am start
  -n com.antutu.ABenchMark/org.citra.emu.ui.EmulationActivity
  -a android.intent.action.VIEW
  -e GamePath {file.documenturi}
  --activity-no-history

Everything else was the same - device, system set to "dark theme", Citra MMJ app, ROM, etc.
It seems that the issue is caused by some interaction between Daijishou and Citra MMJ.


addProperty example #2, issue losing Parent property

Example code I am using in Azure Logic App "compose" step, which is supposed to add a child property to the parent "customerName" property:
addProperty(json('{ "customerName": { "firstName": "Sophia", "surName": "Owen" } }')['customerName'], 'middleName', 'Anne')
Should produce output of:
{
   "customerName": {
      "firstName": "Sophia",
      "middleName": "Anne",
      "surName": "Owen"
   }
}

But produces this output:
{
  "firstName": "Sophia",
  "surName": "Owen",
  "middleName": "Anne"
}

...losing the Parent property

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 03aa9e88-7fa0-56ab-f794-58f0c37b6d7a
Version Independent ID: 25c5ef5c-6ba4-f5ff-f94b-8f2818ec2feb
Content: Reference guide for functions in expressions - Azure Logic Apps
Content Source: articles/logic-apps/workflow-definition-language-functions-reference.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

Thanks for the feedback! We are currently investigating and will update you shortly.

@tommydogs Thanks for reaching out. Example 2 is incorrect and to get the desired output you need to use both addProperty and setProperty. I will update the document to reflect the correct example.
setProperty(json('{ "customerName": { "firstName": "Sophia", "surName": "Owen" } }'), 'customerName', addProperty(json('{ "customerName": { "firstName": "Sophia", "surName": "Owen" } }')['customerName'], 'middleName', 'Anne'))

@tommydogs You can use the below example to get your desired output as mentioned in Example 2. I have updated the document and it will be published once it is approved.
setProperty(json('{ "customerName": { "firstName": "Sophia", "surName": "Owen" } }'), 'customerName', addProperty(json('{ "customerName": { "firstName": "Sophia", "surName": "Owen" } }')['customerName'], 'middleName', 'Anne'))

Thank you for addressing the issue.
On Mon, Mar 22, 2021 at 6:50 AM MayankBargali-MSFT @.***>
wrote:

@tommydogs https://github.com/tommydogs You can use the below example
to get your desired output as mentioned in Example 2. I have updated the
document and it will be published once it is approved.
setProperty(json('{ "customerName": { "firstName": "Sophia", "surName":
"Owen" } }'), 'customerName', addProperty(json('{ "customerName": {
"firstName": "Sophia", "surName": "Owen" } }')['customerName'],
'middleName', 'Anne'))
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/72479#issuecomment-804076629,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATJ5RLNFB2GNK55U2V37YVLTE5DLHANCNFSM4ZPYOYNA
.


Add the Allegra and Mary eras to Cardano

At the moment these two eras are identical to the Shelley era. We will replace
them with the real era tags when cardano-ledger-specs has added them. This
will require conversions and translation.

bors merge


add retries to flaky test HeliosSoloIT.testServiceDiscovery

The test can fail because it tries to connect immediately to the socket of
the alpine container. Need to give the apk install being run as the
command of the container time to finish.

@spotify/helios-team

:100: if it works

The test failure is a different flaky test so I'll merge this fix.


AB#543 - Search results page design

Changed the design for facets filter and removed filter by 'repository'
Changed pagination style
Updated design for individual search result
Updated locales to match the nyc-core-framework design

Looks good.


fix in client : validate method

ctx
are you sure?
I've tried and I doesn't work
and I have not found on the page references about ctx
I hope this will help!

Codecov Report

Merging #515 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #515   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          11     11
  Lines         450    450
=====================================
  Hits          450    450

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1372d29...17db23f. Read the comment docs.

Nice catch, ctx is only on server-side.

you are welcome :)


Changed order of vars and minor stuff

I made it so the URLs for the updater are all together. I added mine in the comment so I can switch to them when/if I ever make an unofficial release again, so I don't have to go search for those URLs.

Of course this happens right after I make a release. eh? :stuck_out_tongue:
I'll merge it anyway, it doesn't change any functionality.

:P


Only run build and linter action once on a pr

Currently runs once for the push and once for the opening of the pr. Kinda messy

Solved in #77


Publish raw SWV stream to TCP port

This patch implements a raw SWO stream server for tools like orbuculum.
I introduced a new option tpiu_port that is set to 3443 by default. The TPIU raw server is started implicitly, when enable_swv is activated. (If this is not desirable, then the default could also be changed to zero and the user would have to set it explicitly to 3443 or whatever to enable it).
I tested it on a STM32 Nucleo board with pyocd gdbserver --target stm32l433rctxp -O enable_swv=true -O swv_system_clock=16000000 and a orbcat -c 1,"0x%08x\n" on the other side.
Fixes #1009

Thanks for the quick review. Updated the PR according to your suggestions and also added to the options.md (It looks a bit like it could have been auto generated from the options dict, however I didn't find generator code, so I updated it manually anyway).
By the way, there's still some additional magic that openocd "tpiu config internal ..." is doing to the target to enable SWO that pyocd is not doing yet. If I cold start the target and enable SWV from pyocd, then the STM32 gets stuck at while (ITM->PORT[TRACE_CHANNEL].u32 == 0) - if I run openocd "tpiu ..." then that is resolved.
Not sure if this SWO enable magic is something that is in the scope of pyocd or not, but I can imagine it creating some confusion if openocd handles it one way and pyocd handles it differently. WDYT?

Everything is finally coming together. The life of the embedded developer should soon be less frustrating.

Thanks. The options.md file is still manually updated at the moment (whereas command_reference.md is auto-generated).
Regarding the STM32, that's a good question. It probably should be handled by pyocd. There's a trace_start() method in SoCTarget that can be overridden. However, it's also a delegate method, so it can be implemented in a user script (pyocd_user.py). And I believe the STM32 CMSIS-Packs provide a debug sequence that enables the trace clock. Pyocd doesn't support debug sequences yet, but I'm working on it in the background. But handling this doesn't need to be part of this PR.

/morph test