MemoryError making SSL Requests, Complex, Consistently Reproducible

I have a Raspberry Pi Pico W running CircuitPython 9.0.5. I'm using the current version (HEAD) of Adafruit_CircuitPython_Requests, and the current HEAD of Adafruit_CircuitPython_ConnectionManager. The application files are compiled using mpy-cross 9.0.5. The size of the .mpy files is approximately 22K bytes and code.py is about 9K bytes.
My application is a thermometer with a LCD display. I'm using a TMP102, and an Adafruit ST7789 240x320 display. The display shows the current temp and time. Temperature readings are taken once a second, averaged, and once a minute, the program does a POST request to place the temperature data into an InfluxDB on a remote host. I'm also using Adafruit_CircuitPython_NTP at startup to set the RTC. Finally, I'm making requests to the OpenWeather API. The OpenWeather API call is made once per 10 minutes.  I ran into problems with SSL certificates. If I tried to make requests to more than one SSL site, I immediately ran out of memory. To work around that, I made a proxy for the OpenWeather API on the same server that hosts Influx. Also, I'm using a GoDaddy cert, so I load the GoDaddy CA certificate using this code:
def network_helper.init(xxxx,xxx,xxx)
    pool = socketpool.SocketPool(wifi.radio)
    ctx = ssl.create_default_context()
    ctx.check_hostname = False
    requests = adafruit_requests.Session(pool, ctx)
    with open('/godaddy.pem') as f:
        certs = f.read()
    ctx.load_verify_locations(cadata=certs)
    return True, requests

so I'm only calling one SSL http host. The requests session is created:
result, http_requests = network_helper.init_network(configuration_values.WIFI_COUNTRY, configuration_values.WIFI_SSID, configuration_values.WIFI_PSK, led=led)
influx = InfluxWriter(configuration_values.INFLUX_HOST, configuration_values.INFLUX_DB, http_requests)

        def _send_request(self, reqbody):  ## ReqBody is around 32 bytes...
            try:
                with self.parent._session.post(self.parent.target_url, data=reqbody, headers=InfluxWriter.request_headers) as r:
                    if r.status_code != STATUS_OK and r.status_code != STATUS_NO_CONTENT:
                        logging.error("making influx post request. Status code: {status_code} body={reqbody}\nContent=\n{content}",
                                      status_code=r.status_code, reqbody=reqbody, content=r.content)
                    r.close()
            except Exception as e:
                logging.error("InfluxWriter._send_request(body={reqbody}) Exception: {e} {etype}", reqbody=reqbody, e=e, etype=type(e))
                return False
            return True

This worked pretty well for a year or so using CircuitPython 8.x.
What's happening is that about 7 minutes after startup, I start getting memory errors.
0;���🐍Wi-Fi: No IP | code.py | 9.0.5[01/01/2020 00:00:08] INFO Connect result = None
[01/01/2020 00:00:08] INFO Connected to wifi mhsoftware!
[01/01/2020 00:00:08] INFO My MAC Addr ['0x28', '0xcd', '0xc1', '0x3', '0x2f', '0xc0']
[01/01/2020 00:00:08] INFO My IP Address is <IP_ADDRESS>
[01/01/2020 00:00:08] INFO Netmask: <IP_ADDRESS>
[01/01/2020 00:00:08] INFO Gateway: <IP_ADDRESS>
[01/01/2020 00:00:08] INFO DNS Server: <IP_ADDRESS>
[01/01/2020 00:00:08] INFO network_helper.set_time(ntp_server="<IP_ADDRESS>", tz_offset=-7)
[01/01/2020 00:00:08] INFO Setting RTC Clock to: struct_time(tm_year=2024, tm_mon=6, tm_mday=29, tm_hour=6, tm_min=58, tm_sec=57, tm_wday=5, tm_yday=181, tm_i)
[06/29/2024 06:59:03] INFO network_helper.set_time(ntp_server="<IP_ADDRESS>", tz_offset=-6.0)
[06/29/2024 06:59:03] INFO Setting RTC Clock to: struct_time(tm_year=2024, tm_mon=6, tm_mday=29, tm_hour=7, tm_min=59, tm_sec=2, tm_wday=5, tm_yday=181, tm_is)
[06/29/2024 08:08:07] ERROR InfluxWriter._send_request(body=tempmon,sensor=otext temp=71.57) Exception:  <class 'MemoryError'>
[06/29/2024 08:20:12] ERROR InfluxWriter._send_request(body=tempmon,sensor=otext temp=71.64) Exception:  <class 'MemoryError'>
[06/29/2024 08:22:11] ERROR InfluxWriter._send_request(body=tempmon,sensor=otext temp=71.57) Exception:  <class 'MemoryError'>

About every other call results in a MemoryError. After some time, failures become more prevalent.
[06/29/2024 15:03:05] ERROR OpenWeather API Exception:
Body=
Response=None
[06/29/2024 15:03:42] ERROR InfluxWriter._send_request(body=tempmon,sensor=otext temp=72.92) Exception:  <class 'MemoryError'>
[06/29/2024 15:04:42] ERROR InfluxWriter._send_request(body=tempmon,sensor=otext temp=72.95) Exception:  <class 'MemoryError'>
[06/29/2024 15:06:44] ERROR InfluxWriter._send_request(body=tempmon,sensor=otext temp=72.96) Exception:  <class 'MemoryError'>
[06/29/2024 15:08:43] ERROR InfluxWriter._send_request(body=tempmon,sensor=otext temp=72.94) Exception:  <class 'MemoryError'>
[06/29/2024 15:09:44] ERROR InfluxWriter._send_request(body=tempmon,sensor=otext temp=73.02) Exception:  <class 'MemoryError'>
[06/29/2024 15:11:43] ERROR InfluxWriter._send_request(body=tempmon,sensor=otext temp=72.89) Exception:  <class 'MemoryError'>

I added some dumps of gc value, and can see when I enter the loop there's some 60K bytes free. After the first http requests, free memory reduces to about 20 K Bytes:
[06/29/2024 14:42:25] DEBUG Top of while Loop. GC: Allocated: 61952  Free: 61440
[06/29/2024 14:42:28] DEBUG Post InfluxWrite and gc.collect() GC: Allocated: 93760  Free: 29632
[06/29/2024 14:42:29] DEBUG Post OpenWeather getCurrentTemp() GC: Allocated: 95248  Free: 28144
[06/29/2024 14:42:29] INFO network_helper.set_time(ntp_server="<IP_ADDRESS>", tz_offset=-6.0)
[06/29/2024 14:42:29] DEBUG time poll=3
[06/29/2024 14:42:29] INFO Setting RTC Clock to: struct_time(tm_year=2024, tm_mon=6, tm_mday=29, tm_hour=15, tm_min=42, tm_sec=27, tm_wday=5, tm_yday=181, tm_)
[06/29/2024 15:42:28] DEBUG Weather Current Temp=79.38
[06/29/2024 15:42:28] DEBUG Pre gc.collect() GC: Allocated: 108320  Free: 14508
[06/29/2024 15:42:29] DEBUG Top of while Loop. GC: Allocated: 100240  Free: 22588
[06/29/2024 15:42:30] DEBUG Post InfluxWrite and gc.collect() GC: Allocated: 100240  Free: 22588
[06/29/2024 15:42:30] DEBUG Post OpenWeather getCurrentTemp() GC: Allocated: 106512  Free: 16316

After a MemoryError, it looks like:
[06/29/2024 15:49:42] DEBUG Pre gc.collect() GC: Allocated: 102000  Free: 20048
[06/29/2024 15:49:43] DEBUG Top of while Loop. GC: Allocated: 100064  Free: 21984
[06/29/2024 15:49:44] DEBUG Pre gc.collect() GC: Allocated: 102000  Free: 20048
[06/29/2024 15:49:45] DEBUG Top of while Loop. GC: Allocated: 100064  Free: 21984
[06/29/2024 15:49:45] ERROR InfluxWriter._send_request(body=tempmon,sensor=otext temp=73.68) Exception:  <class 'MemoryError'>
[06/29/2024 15:49:45] DEBUG Post InfluxWrite and gc.collect() GC: Allocated: 69392  Free: 52656

You can see that AFTER a memory error, a great deal more of memory is freed. I've noticed that free memory and allocated memory are unchanged UNLESS I use the requests library. IOW, reading the TMP102 and updating the display DON'T change the free memory.
[06/29/2024 15:52:49] DEBUG Top of while Loop. GC: Allocated: 100064  Free: 21984
[06/29/2024 15:52:49] DEBUG Pre gc.collect() GC: Allocated: 102000  Free: 20048
[06/29/2024 15:52:50] DEBUG Top of while Loop. GC: Allocated: 100064  Free: 21984
[06/29/2024 15:52:50] DEBUG Pre gc.collect() GC: Allocated: 102000  Free: 20048
[06/29/2024 15:52:51] DEBUG Top of while Loop. GC: Allocated: 100064  Free: 21984
[06/29/2024 15:52:51] DEBUG Pre gc.collect() GC: Allocated: 102000  Free: 20048

Observations
So what seems to be happening is that calling the API library to make a request consumes around 40 K Bytes. When an error occurs, around 30KB is freed giving about 50K bytes free. A subsequent call consumes around 30K bytes. The call after that fails with out of memory.
Does anyone have any ideas on how to work around this? I feel like trying to follow conventional memory reduction techniques is just going to be useless since evidence shows the requests library consuming most of it.

Looking at adafruit_connectionmanager(), I'm not understanding how this will work without a call to gc.collect()
        try:
            socket = self._get_connected_socket(
                addr_info, host, port, timeout, is_ssl, ssl_context
            )
            self._register_connected_socket(key, socket)
            return socket
        except (MemoryError, OSError, RuntimeError):
            # Could not get a new socket (or two, if SSL).
            # If there are any available sockets, free them all and try again.
            if self.available_socket_count:
                self._free_sockets()
                socket = self._get_connected_socket(
                    addr_info, host, port, timeout, is_ssl, ssl_context
                )
                self._register_connected_socket(key, socket)
                return socket
            # Re-raise exception if no sockets could be freed.
            raise

Python will free memory when it can't find enough. When the sockets are freed, they can be gc'd when the system needs it.
Once everything is loaded into memory, you should be able to constantly make calls, unless you are holding onto data locally (like keeping the weather data). Are you making sure everything is freed?
Also, you could look at the json streamer as it can pull data in chunks (vs the whole string and the json conversation).

@justmobilize Thanks for replying.
I changed the openweather code to save just the keys out of the response dict that I'm using. It's about 6 or so. This didn't make any difference. I'm still seeing the memory error on every other request to influx. I never got any memory error while parsing the OpenWeather API.
The influx writer doesn't allocate any memory. It formats a string and calls .post(). You can see on the first run-through that the memory allocation ratchets up on the first call. to the .post() call.
[06/29/2024 14:42:25] DEBUG Top of while Loop. GC: Allocated: 61952  Free: 61440
[06/29/2024 14:42:28] DEBUG Post InfluxWrite and gc.collect() GC: Allocated: 93760  Free: 29632

So, calling request.post() immediately consumes 1/4th of the RAM of the system and doesn't free it.

If you want to make sure the sockets are fully cleared you can call:
adafruit_connection_manager.connection_manager_close_all()

Which will release all the open sockets. You could then do a gc.collect() as well.
The other issue is you need continuous memory. So if you have fragmentation it could slowly build until it's unusable.
I often do a soft reset when I get to a point of not needing anything that's loaded.
9.x did change how it managed memory, and for most it was helpful, but seems to have made the pico worse.

Please try the "Absolute Newest" build via the link on the board page. We turned off some things that will free up some RAM.

@dhalbert I tried with 9.1.0-beta.3-55-g95dbb18d22 and the issue still occurs.

Did you try adding the adafruit_connection_manager.connection_manager_close_all()?

@justmobilize I'm playing with this now. I made a small change (removed one object, and reduces outgoing POST requests by about 10%). I also re-compiled using the latest version of mpy-cross. It now seems to be working as expected. I'll take the device back to the deployment environment and see what happens.

I've run it for a few days now and updating to the latest python image, along with re-compiling with the latest mpy-cross seems to have resolved it.


Add auto-update and pre-release update user settings

Add settings in user preferences for auto-updating (default false) and
for allowing pre-release versions (default false)

Use in-Lens notifications instead of OS notifications as those were
found to be flaky

Add rudimentary main->renderer notification system.

Signed-off-by: Sebastian Malton<EMAIL_ADDRESS>a partial fix for #1768

And now you work?

And now you work?


Delete unnecessary Heroku Redis addons

Codecov Report

Merging #86 into master will decrease coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   77.69%   77.27%   -0.42%
==========================================
  Files          17       17
  Lines        1654     1571      -83
==========================================
- Hits         1285     1214      -71
+ Misses        369      357      -12

Impacted Files
Coverage Δ

nekoyume/models.py
74.75% <0%> (-0.75%)
:arrow_down:

tests/models_test.py
100% <0%> (ø)
:arrow_up:

tests/game_test.py
100% <0%> (ø)
:arrow_up:

nekoyume/game.py
89.41% <0%> (+0.9%)
:arrow_up:

nekoyume/items.py
77.65% <0%> (+1.98%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e896caf...e12313b. Read the comment docs.


Harp is not installed, please run npm install on styleguide/styleguide/structure/_node-files/

Hi
I'm getting this message during the install: "Harp is not installed, please run npm install on styleguide/styleguide/structure/_node-files/"
Thanks

Here is the full install log:
Styleguide. Welcome!
PROGRESS:50
Checking dependencies...
npm WARN deprecated<EMAIL_ADDRESS>this package has been reintegrated into npm and is now out of date with respect to npm
npm WARN deprecated<EMAIL_ADDRESS>cross-spawn no longer requires a build toolchain, use it instead!
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained. Upgrade to<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g

<EMAIL_ADDRESS>install /Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/node-sass
node scripts/install.js

Cannot download "https://github.com/sass/node-sass/releases/download/v3.4.2/darwin-x64-48_binding.node":
HTTP error 404 Not Found
Hint: If github.com is not accessible in your location
try setting a proxy via HTTP_PROXY, e.g.
  export HTTP_PROXY=http://example.com:1234

or configure npm proxy via
  npm config set proxy http://example.com:8080

<EMAIL_ADDRESS>postinstall /Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/spawn-sync
node postinstall
<EMAIL_ADDRESS>postinstall /Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/node-sass
node scripts/build.js

Building: /Users/mathiaslaurvig/local/bin/node /Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/node-gyp/bin/node-gyp.js rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
gyp info it worked if it ends with ok
gyp verb cli [ '/Users/mathiaslaurvig/local/bin/node',
gyp verb cli   '/Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/node-gyp/bin/node-gyp.js',
gyp verb cli   'rebuild',
gyp verb cli   '--verbose',
gyp verb cli   '--libsass_ext=',
gyp verb cli   '--libsass_cflags=',
gyp verb cli   '--libsass_ldflags=',
gyp verb cli   '--libsass_library=' ]
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| darwin | x64
gyp verb command rebuild []
gyp verb command clean []
gyp verb clean removing "build" directory
gyp verb command configure []
gyp verb check python checking for Python executable "python2" in the PATH
gyp verb which failed Error: not found: python2
gyp verb which failed     at getNotFoundError (/Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/which/which.js:14:12)
gyp verb which failed     at F (/Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/which/which.js:69:19)
gyp verb which failed     at E (/Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/which/which.js:81:29)
gyp verb which failed     at /Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/which/which.js:90:16
gyp verb which failed     at /Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/isexe/index.js:44:5
gyp verb which failed     at /Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/isexe/access.js:8:5
gyp verb which failed     at FSReqWrap.oncomplete (fs.js:117:15)
gyp verb which failed  python2 { Error: not found: python2
gyp verb which failed     at getNotFoundError (/Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/which/which.js:14:12)
gyp verb which failed     at F (/Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/which/which.js:69:19)
gyp verb which failed     at E (/Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/which/which.js:81:29)
gyp verb which failed     at /Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/which/which.js:90:16
gyp verb which failed     at /Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/isexe/index.js:44:5
gyp verb which failed     at /Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/isexe/access.js:8:5
gyp verb which failed     at FSReqWrap.oncomplete (fs.js:117:15) code: 'ENOENT' }
gyp verb check python checking for Python executable "python" in the PATH
gyp verb which succeeded python /usr/bin/python
gyp verb check python version /usr/bin/python -c "import platform; print(platform.python_version());" returned: "2.7.10\n"
gyp verb get node dir no --target version specified, falling back to host node version: 6.2.0
gyp verb command install [ '6.2.0' ]
gyp verb install input version string "6.2.0"
gyp verb install installing version: 6.2.0
gyp verb install --ensure was passed, so won't reinstall if already installed
gyp verb install version is already installed, need to check "installVersion"
gyp verb got "installVersion" 9
gyp verb needs "installVersion" 9
gyp verb install version is good
gyp verb get node dir target node version installed: 6.2.0
gyp verb build dir attempting to create "build" dir: /Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/node-sass/build
gyp verb build dir "build" dir needed to be created?  System Darwin 15.5.0
gyp ERR! command "/Users/mathiaslaurvig/local/bin/node" "/Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd /Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/node_modules/node-sass
gyp ERR! node -v v6.2.0
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
Build failed
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.
npm ERR! Darwin 15.5.0
npm ERR! argv "/Users/mathiaslaurvig/local/bin/node" "/Users/mathiaslaurvig/local/bin/npm" "install"
npm ERR! node v6.2.0
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>postinstall: node scripts/build.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'node scripts/build.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the node-sass package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node scripts/build.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs node-sass
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls node-sass
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/mathiaslaurvig/Downloads/styleguide-master/styleguide/structure/_node-files/npm-debug.log
PROGRESS:80
Let's start this thing...
Harp is not installed, please run npm install on styleguide/styleguide/structure/_node-files/
PROGRESS:100

It might be related to this issue on Harp: https://github.com/sintaxi/harp/issues/564
I had Node 6 installed, and had to change the Harp version to make it work.

We're also experiencing this issue, but haven't had much look with Node 6.2 yet and getting harp to work, did you find any solution to this one @mlaurvig

Nope :-(

@mlaurvig @sosheepster @fyllepo , have you had any luck with the latest version of Harp and Node?

I'm having the same issue. Has anyone found a solution to this yet?

Hi @ekfuhrmann ,
Are you using windows, mac or linux? Have you tried to install harp manually?

I managed to force harp to the latest version by changing package.json, and then used yarn to install instead of npm. it seems to work after that!

I'm having the same issue. Has anyone found a solution to this yet?

U have to install install harp@next with npm version 4 lts…

Updating the dependencies version solved for me. Just pushed to a separate branch. If you can please test, downloading a zip from this link: https://github.com/hugeinc/styleguide/tree/hotfix/dependencies-version

My solution was to use a lower version of node. I changed it with nvm to the version 5.1.0. I also installed the latest version of harp: npm install -g harp@next


CPU usage is too high

For 1920x1080 resolution.
The CPU is around 2 i7 cores.
May the pipeline configured with TCP/UDP connection will yield more efficiency.

Do you solve this problem?
i try to decode with nvidia accelerate by changing
 self.pipeline = Gst.parse_launch(
            'rtspsrc name=m_rtspsrc ! rtph264depay name=m_rtph264depay ! avdec_h264 name=m_avdech264 ! videoconvert name=m_videoconvert ! videorate name=m_videorate ! appsink name=m_appsink')

to
 self.pipeline = Gst.parse_launch(
            'rtspsrc name=m_rtspsrc ! rtph264depay name=m_rtph264depay ! nvv4l2decoder name=m_avdech264 ! nvvideoconvert name=m_videoconvert ! videorate name=m_videorate ! appsink name=m_appsink')

but there are some error like below:
TypeError: buffer is too small for requested array
Traceback (most recent call last):
  File "/data/vid_streamv3.py", line 78, in new_buffer
    arr = self.gst_to_opencv(sample)
  File "/data/vid_streamv3.py", line 73, in gst_to_opencv
    dtype=np.uint8)
TypeError: buffer is too small for requested array
Caught Keyboard interrupt


Fixes large tables on high-dpi monitors

The solution is to reduce the amount of rows a page can have. Previous value of 500,000 was too large for monitors with high DPI.
Fixes #862.
Signed-off-by: Rodrigo Pinto<EMAIL_ADDRESS>

I have a high dpi monitor, I confirm it works, I would like to have an explanation of why though.

Can we merge this one?

Can we merge this one?

I think @MatthewKhouzam was expecting a documented (yet potentially brief) explanation first. Ideally persisted in the git commit message, or so I propose.

Found the reason behind the problem. Updated the commit message and the PR post.

Good findings. There is a typo in the commit message and PR header; 'streching' should read 'stretching'.


A future improvement would be to properly serialize/deserialize when we write to a real database (not the sharedpreferences, but datastore)

A future improvement would be to properly serialize/deserialize when we write to a real database (not the sharedpreferences, but datastore)
https://kotlinlang.org/docs/serialization.html
Originally posted by @gdeluna-branch in https://github.com/BranchMetrics/android-branch-deep-linking-attribution/pull/1129#discussion_r1343371236

Hello @BornNk , thank you for your submission. Would you mind to clarify a couple of details about it?
It is unclear which code sample or Google Cloud service you mean. If you request is applicable to the specific code sample(s), please respond with the path(s) of the sample(s) and we will review them.
Also, this repository focuses on Java code samples. While Kotlin can be seen as a Java dialect, it is a different language. I see that the original thread about serialization comes from Android branch. Would you mind to check if this request is better fitted for https://github.com/GoogleCloudPlatform/kotlin-samples repository?
Thank you,
@minherz


Empty workflow list

I know that this is still in progress, but perhaps it's useful to already let @rkpasia know that https://github.com/fractal-analytics-platform/fractal-web/commit/d16ec352bbbf8235d72acc67b39b475b67f8ff8b is not yet working.

I create a project (say project_id=4 and add a workflow to it (via the command-line client).
I browse to http://localhost:5173/projects/4
The list of datasets is correct, but the list of workflows is empty.

Notice that the API call
INFO:     <IP_ADDRESS>:39126 - "GET /api/v1/project/4 HTTP/1.1" 200 OK

correctly return a non-empty list of projects (when triggered through the command-line client).

Which version of fractal server are you using?
Do you notice any errors printed in the browser console?

I was probably using some older commit. As of d16ec352bbbf8235d72acc67b39b475b67f8ff8b, it does work as expected.


Introducing load meta data option for load_certificate method

Experienced, that the option was missing to extract the metadata from a certificate. Merging this should not cause any compatibility issues and extends the usablity of certificate metadata.
NOTE: This is only compatible with Python >=3.8, since the Walrus Operator was used. If you wish more compatibility, I can push those changes to this PR too.

Since some checks did non pass in 74d2bba. Therefore, the Walrus Operator was replaced in 70a8177 to ensure backward compatibility for earlier python versions.


Remove need for CGO

Switch sqlite database driver to one that does not require CGO. This eliminates the need for dealing with dynamic and static compile options.

Build with CGO_ENABLED=0.
Update Go version in README based on go.mod version.

I guess I need to make some additional changes to the driver integration.

One thing that would be useful, it seems GH actions are disabled for forked PRs. So we don't see the failure result here.

Huh. I've set it so approval is required to run actions for people outside the organisation but I can't see any option anywhere to run the workflows for this PR.
Maybe a force-push will kick something off?

The failure cause seems to be twofold:
First off, the CGO sqlite3 library declares its driver name as "sqlite3". The modernc library declares its driver name as "sqlite". The fix for this is simple enough: change all occurrences of "sqlite3" to "sqlite" in cashier, including the migrations directory name.
The next problem is the sql-migrate library, which Cashier uses to execute migrations on process startup. That only supports the sqlite3 CGO library.

Boo, I guess we would need another migration tool, or to update the upstream library to support modernc.org/sqlite.


Show label/node in Behaviors table

I have quite a few behaviours in my keymap, but the list just shows the type of behavior and the binding. It would be nice if this table could also show the label or node, to make it a bit easier to see what's what.
Even nicer, but likely harder to achieve, would be if it could show the number of usages and/or where they're used. (I have an inkling that one of them is actually unused, but last time I removed a supposedly unused one, I broke one of my layers. 🤦🏻)

I like that idea! It shouldn't be too difficult to add, I think. Even better might be to also break it down by layer/combo/macro/etc but that can come later on.

I had a look today and seem to have reference counting working (not deployed), but I didn't actually absorb the first part of your idea. Do you have an example of that?
I wanted to build the editor with maximum flexibility (there may be multiple labels, label(s) may differ from the node name) but in practice I think most people just want to reference their behaviors by a consistent name which is why it defaults to keeping them in sync. Certainly if the values are different it's good to be able to see them in the list but I'm imagining common use will tend to look like duplicate columns.
As a side note, when I refer to "label" here I mean in the devicetree sense (e.g. label: node_name { ... };) rather than the property as indicated in the app. I haven't gotten around to cleaning things up but for quite a while now ZMK has made label properties optional in behaviors/macros and even renamed layer labels to display-name so they don't serve much purpose anymore.

In my list, every one of those behaviors has a different label and node - for example, the first one hra, node home-row-arrow, label Home Row Modifier (Arrow). Any of these pieces of information would be useful to show. I have no idea what htb, hth and htt do without clicking through to the config. 🙈 Pretty much any additional information would be useful.

Ok, yeah, that'd be a problem for sure. While I don't love the idea of adding the label prop front-and-center in another way (I checked and it is optional but it's also marked as deprecated*), I could still just show it and/or the node name conditionally when present and sufficiently unique from the bind code.
*This isn't the first time something has been deprecated in ZMK and there haven't been any plans I've seen to actually remove support for deprecated features (I suspect this may not happen before ZMK has versioning), but I'd still like to avoid giving a reason to continue using them.

I think the node name is perfectly fine and enough, especially if the label is deprecated. If users care about the readability of the list, they can edit/customise the node name. It does feel unnecessary to have both there, although it adds to the lack of ability to "describe" stuff in keymaps. But that tension is way beyond the scope of this feature request.


Support to base network

This completes support to base network.
It adds base to the deploy web app.
It adds base to CLI in wallet selection for sunodo send.
It adds base to documentation.

Isn´t there a base-sepolia network?

I wasn't aware until yesterday there is a base-sepolia network.
If we really want to deploy to base-sepolia we need to add it all the way from the solidity-util package, to the rollups-contracts package to here.
Do you think it's necessary?

Do you think it's necessary?

For consistency it's probably better to do it.

But I think we can merge this one, and then add base sepolia


Android: Introduce viewLayerTypeAndroid and deprecate renderToHardwareAndroid

React Native for Android supports the renderToHardwareAndroid prop which enables a developer to set a view's layer type to LAYER_TYPE_HARDWARE or LAYER_TYPE_NONE. Natively, Android supports 3 values for a view's layer type but only 2 of them are exposed to JavaScript.
This change introduces a prop called viewLayerTypeAndroid which is an enum which exposes all 3 possible view layer types to JavaScript:

LAYER_TYPE_NONE
LAYER_TYPE_HARDWARE
LAYER_TYPE_SOFTWARE

This change also deprecates renderToHardwareAndroid in favor of viewLayerTypeAndroid because viewLayerTypeAndroid is a superset of renderToHardwareAndroid.
Test plan (required)
Verified this prop works in a test app and my team is using this change in or app.
Adam Comella
Microsoft Corp.

cc @astreet

Thanks for reviewing @astreet!

@astreet Thanks for reviewing this. Here's the reason why we're using the software layer type in our app:
To avoid stack overflows on devices with a small stack size. KitKat and below use
the dalvik java virutal machine by default which has a main thread with an
unconfigurable stack size of 32k. The hardware accelerated flow requires two
additional stack frames per view so if you have a stack overflow issue, you may
consider using this view layer type as a workaround. Note that all subviews will
use software rendering as well.

I included this description in the documentation so others will understand why they might want to use it.
I pushed a commit to address your feedback and I rebased my branch on master.

Great, thanks!

@astreet is there anything else I need to do before this can be merged?

Some internal apps are failing to build with this change, I'm looking into why

@astreet did you have a chance to see why some internal apps are failing?

No, I haven't -- I'm actually not working much on RN in London anymore. Hopefully @AaaChiuuu can help direct it to someone on the team to look at?

This is failing to import. If it's alright, can you try opening a new PR with the same changes?

Closing in favor of #15021 as requested by @hramos.


Issue: can't block channel through right click.

When I try to block channel with right click through side bar video, the channel doesn't blocked and I get 'undefined' instead on channel list.

Case insensitive on channel blocking also doesn't work unless wildcard option enabled.


Add support for Markdown inline code sections

Encase Markdown ` code ` inline code sections into <code> tags.

Rules:

inline code separators ` can only be on the same line for this to work

Closed by merge commit https://github.com/devils2ndself/SSGo/commit/d6960f5ffa94796d39278955146d5caca3692cd4


Azure Blueprints (Preview) would never go into GA -

[Enter feedback here]
Azure Blueprints (Preview) would never go into GA - so you should not recommend anything using this in your docs.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c6b579d9-16cf-ca34-0242-8a5a3740ef03
Version Independent ID: 64c2e0a8-a179-56fc-bd13-344ae175a7db
Content: Standard enterprise governance guide - Cloud Adoption Framework
Content Source: docs/govern/guides/standard/index.md
Service: caf
Sub-service: caf-methodology-govern
GitHub Login: @martinekuan
Microsoft Alias: martinek

Thank you for submitting this issue and suggestion, @mailtogurvindersingh, and you're right!
We've got this on our roadmap and backlog to address in the new year.
#please-close


[NeedsReview] b07902131

A Pull Request (PR) should explain why we need this PR and how you implement it, so others could understand it quickly.
Since this is just a homework, you do not need to explain why and how.
Do NOT change the status to NeedsReview if you do not want to be graded yet.
Please fill in the following questions as feedback. It is totally optional and would not be graded.
What is the most challenging part in this homework?
Transfering byte data to PIL object.
But the bonus is more challenging, such as using PR and rebase.
Is this homework helpful for you?
Yes for practicing git.
Is there any suggestion?
It will be more exciting if this homework is more challenging problems like task 8.

PR readiness check list

[ O ] Did it pass the Flake8 check?
[ O ] Did you test this PR?
[ O ] Did you change the title of this PR to the correct format ([status] student_ID)?

Here are my PRs.
#54
#82


Docs(Scrollspy): minor changes to be aligned with new version of javascript

Changes:

first example: add proper root-margin
'nested nav' example: add more content to sections & enable smooth-scroll

closes #36198
@louismaximepiton please, you may take a look and feedback me

Zip

Thank you a lot for your help :smile:

when a spy is clicked on the third example, the component moves under the header

It was the default mode, ( I didn't like it either ) but I've changed it

there are still some issues with the scroll on the nested nav

I am aware of them, but as before, the same problem comes in front. As javascript itself is not so much clever to decide which visible point has to be active (plus the observer restrictions), all functionality sums up to developer thoughts and skills (in this situation, mine's :yum: )
So it would be great if anyone else take a look and come up with a more precise and of course minimalist solution. Ps: Passing the js tests is one more hidden challenge, in this specific component

@GeoSot I pushed a bunch of updates here to the docs to clean up some of the new copy, but also rewrite a lot of content to better explain how it all works up front. Should be good to go!


Intermittent Error

I get two different outcomes, seemingly at random, at times all go as planned, but other times i get the error Unexpected Error: Error Domain=WKErrorDomain Code=4 "Ocorreu uma exceção JavaScript" UserInfo={WKJavaScriptExceptionLineNumber=24, WKJavaScriptExceptionMessage=TypeError: Argument 1 ('target') to MutationObserver.observe must be an instance of Node, WKJavaScriptExceptionColumnNumber=13, WKJavaScriptExceptionSourceURL=http://com.btg.pactual.digital.mobile/, NSLocalizedDescription=Ocorreu uma exceção JavaScript}
tested on iPhone 6 and 6S, both on iOS 12.1.4, using the latest pod version

Hey @JulioBBL, this seems like it may be an error with the embedded HTML.
Do you have any way of reproducing it?

If i create the ReCaptcha object, setup the we view configuration callback and validate all in rapid succession, I get this error.
Upon further testing i figured if there is a delay before validating, no error is produced, so i made a executive decision to force a 2 seconds delay between calls
(Gambiarra e tal)
I can only assume there is a delay somewhere handled by another thread.

Are you using localhost as the domain, by any chance?
Btw, I'll close this because it seems to be a duplicate of #69.

nope, using my own domain.

i am sorry, i just now realised that i have provided you the wrong error message, this is the one i get:
ERROR: TypeError: undefined is not an object (evaluating 'document.getElementsByTagName("div")[4].outerHTML = ""')
only found out when you marked it as duplicate

@JulioBBL are you by any chance using ReCaptcha v3? That seems to be causing many issues with this library.
If that's your case, please try using a v2 Invisible key. I'll look into adding support for v3 keys soon


Job preparation analysis

Is your feature request related to a problem? Please describe.
Yes, the present code is only focusing on few questions . We can answer many more questions using the dataset.
Describe the solution you'd like
I want answer the questions like Remote Work Preference vs. Salary,  salary of a particular domain language in the future, Preferred Development Tools vs. Salary, Performance Ratings vs. Salary and so on by visualizations and different problems.
Describe alternatives you've considered
Apart from visualizations I even want to train the model for the main questions to be answered as well.
Additional context
I would like to make amazing visualizations and models for the analysis. I think I am good at visualizing and can actually draw an analysis or conclusion for that answers.
What problem is this feature trying to solve?
This feature would solve  job preparation analysis like we can conclude what all should we do to get a high paying job.
How do we know when the feature is complete?
As soon as I answer a particular question I will raise a pull request and I will also intimate If I am done with the issue. Please do assign me this sir.

In addition, I possess strong skills in creating compelling visualizations and models for analysis. I'm confident in my ability to translate data into meaningful insights and draw conclusions effectively.

Hi @Navyazitya , @sanjay-kv , I would like to work on this issue , can you please assign me this.

Sir @sanjay-kv ... This is done.. Like I made all the analysis and visualizations with all the conclusions that are needed ... Is this issue done or should I do anything else sir..

PR It

I already raised and you approved it as well sir.. @sanjay-kv


All builds fail with bazel >= 0.10.0

The io_bazel_rules_closure repo at tag 0.4.2 does a bazel version check using a tuple of string.
Need to use a new tag if they release one, or switch to an arbitrary version off master to fix.

Fixed in 41f0ee0ac460f0b91d49c7950628348f72c2af9f


Can I create a database in memory as I have no file storage

I need a light weight database engine for an Azure function I am writing.  As I have file storage I can't create a database in a file location.    Is it possible to just create a database in memory (Like SQLLite)
cheers
Greg

@GregObleshchuk Yes, you can create an in-memory database with var db = new LiteDatabase(":memory:") or var db = new LiteDatabase(new MemoryStream()).


Allow IDPs to be set dynamically by other plugs

I am working on an application that may have many IDP configurations, and they may need to be loaded dynamically.  I believe this small modification would enable me to set the IDP configuration dynamically via a plug that runs earlier than Samly.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


MicroProfile 7.0 Compatible webpage

What is needed:

specification box image
MP7 description
Compatible Implementations for MicroProfile 7 - @Emily-Jiang I will need this content
Blog post update

I created a draft page already and will add these sections when the correct info is put in this ticket. @Emily-Jiang

Compatible page:
Open Liberty - <IP_ADDRESS>-beta-cl240920240801-0303
Java version: Java 11, 17 and 21
Links: Certification Results   Download

Blog is here

done


Windows 11 10.0.22621.2134 not supported.

Please add offsets for Windows 11 10.0.22621.2134
Thank you very much for your time.
Windows 11 version 22H2, all editions
Latest windows 11 update - August 8, 2023—KB5029263 (OS Build 22621.2134)
https://support.microsoft.com/en-us/topic/august-8-2023-kb5029263-os-build-22621-2134-f8d4d3de-47c1-40e1-a2e6-97c2770ee2e8

Please add offsets for Windows 11 10.0.22621.2134

RDPConf screenshot, please!

Duplicate of https://github.com/stascorp/rdpwrap/issues/2290


Namespace ownership should be transferrable to other teams

In Portus, a namespace belongs to a team. Right now (i.e. in Portus 2.2), it is not possible to transfer this ownership to other teams.
What's more: Even if one might think that's feasible by deleting the namespace and re-creating it linked to the new team, there's also no possibility to delete an existing namespace.

I'll mark this as a feature even if it's a combination of features already scheduled for 2.4 and 2.5. Once we are done with those releases we can re-visit this one.


all: multiple packages fail go test when not in short mode

What version of Go are you using (go version)?
go version devel +be371edd67 Tue Mar 20 19:38:06 2018 +0000 linux/amd64
What operating system and processor architecture are you using (go env)?
linux/amd64
What did you do?
Test all packages via all.bash (in short mode) and then via go test ./... (not in short mode)
~/gotip/src$ ./all.bash && go test ./...
Inspired by #24436
What did you expect to see?
All tests pass (in short mode)
All tests pass (not in short mode)
What did you see instead?
All tests pass (in short mode)
Multiple packages fail go test (not in short mode)
FAIL	cmd/compile/internal/ssa (discussed here)
FAIL	cmd/doc (fixed in cl 101836)
FAIL	cmd/go (#24436)
FAIL	cmd/gofmt (#24472)
FAIL	go/types (fixed in cl 101815)
FAIL	net
Edit: i have added links to the fixes and other discussions so far

@rsc

go/types failure fixed in 041c5d83486fce4a1c8b549a3c6f9c1951b0aea8.

The failure in cmd/doc is because it may fail depending on your GOPATH. For example:
$ go test
2018/03/21 12:26:36 no buildable Go source files in /home/mvdan/go/land/src/github.com/gopherjs/gopherjs/compiler/natives/src/crypto/rand
exit status 1
FAIL    cmd/doc 0.119s
[mvdan@carbon:5] [1] [/home/mvdan/tip/src/cmd/doc]
$ GOPATH= go test
PASS
ok      cmd/doc 1.857s

The tests should be made more robust. Will give it a go, but there are many ways to fix this.

The cmd/gofmt failure is caused by gofmt not being idempotent on certain programs. I opened #24472 about this, with a small reproducer.

I can't get cmd/compile/internal/ssa to fail.
$ git checkout be371edd677abe6de310c9ffc225b9e8b052d2b8
$ ./make.bash
Building Go cmd/dist using /Users/khr/go1.4.
Building Go toolchain1 using /Users/khr/go1.4.

Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for darwin/amd64.
---
Installed Go for darwin/amd64 in /Users/khr/sandbox/readonly
Installed commands in /Users/khr/sandbox/readonly/bin
$ ../bin/go test cmd/compile/internal/ssa/...
ok  	cmd/compile/internal/ssa	71.866s

(same thing on linux)

I can (linux/amd64), here's the log:
--- FAIL: TestNexting (7.94s)
    --- FAIL: TestNexting/gdb-dbg-hist (2.37s)
    	debug_test.go:234: step/next histories differ, diff=
    		--- testdata/hist.gdb-dbg.nexts	2018-03-19 11:37:08.131407088 +0100
    		+++ /tmp/debug_test231459976/test-hist.gdb-dbg.nexts	2018-03-21 17:54:58.587602381 +0100
    		@@ -9,7 +9,7 @@
    		 61:		sink = dx + dy            //gdb-opt=(dx,dy)
    		 63:		hist := make([]int, 7)                                //gdb-opt=(dx/O,dy/O) // TODO sink is missing if this code is in 'test' instead of 'main'
    		 64:		var reader io.Reader = strings.NewReader(cannedInput) //gdb-dbg=(hist/A) // TODO cannedInput/A is missing if this code is in 'test' instead of 'main'
    		-hist =  []int = {0, 0, 0, 0, 0, 0, 0}
    		+hist = {array = <A>, len = 7, cap = 7}
    		 65:		if len(os.Args) > 1 {
    		 73:		scanner := bufio.NewScanner(reader)
    		 74:		for scanner.Scan() { //gdb-opt=(scanner/A)
    --- FAIL: TestNexting/gdb-opt-hist (0.95s)
    	debug_test.go:234: step/next histories differ, diff=
    		--- testdata/hist.gdb-opt.nexts	2018-03-19 11:37:08.139407145 +0100
    		+++ /tmp/debug_test577668668/test-hist.gdb-opt.nexts	2018-03-21 17:55:03.655623768 +0100
    		@@ -25,7 +25,7 @@
    		 76:			i, err := strconv.ParseInt(s, 10, 64)
    		 77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
    		 err = {tab = 0x0, data = 0x0}
    		-hist =  []int = {0, 0, 0, 0, 0, 0, 0}
    		+hist = {array = 0xc00003be98, len = 7, cap = 7}
    		 i = 1
    		 81:			hist = ensure(int(i), hist)
    		 82:			hist[int(i)]++
    		@@ -35,7 +35,7 @@
    		 76:			i, err := strconv.ParseInt(s, 10, 64)
    		 77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
    		 err = {tab = 0x0, data = 0x0}
    		-hist =  []int = {0, 1, 0, 0, 0, 0, 0}
    		+hist = {array = 0xc00003be98, len = 7, cap = 7}
    		 i = 1
    		 81:			hist = ensure(int(i), hist)
    		 82:			hist[int(i)]++
    		@@ -45,7 +45,7 @@
    		 76:			i, err := strconv.ParseInt(s, 10, 64)
    		 77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
    		 err = {tab = 0x0, data = 0x0}
    		-hist =  []int = {0, 2, 0, 0, 0, 0, 0}
    		+hist = {array = 0xc00003be98, len = 7, cap = 7}
    		 i = 1
    		 81:			hist = ensure(int(i), hist)
    		 82:			hist[int(i)]++
    		@@ -55,7 +55,7 @@
    		 76:			i, err := strconv.ParseInt(s, 10, 64)
    		 77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
    		 err = {tab = 0x0, data = 0x0}
    		-hist =  []int = {0, 3, 0, 0, 0, 0, 0}
    		+hist = {array = 0xc00003be98, len = 7, cap = 7}
    		 i = 2
    		 81:			hist = ensure(int(i), hist)
    		 82:			hist[int(i)]++
    		@@ -65,7 +65,7 @@
    		 76:			i, err := strconv.ParseInt(s, 10, 64)
    		 77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
    		 err = {tab = 0x0, data = 0x0}
    		-hist =  []int = {0, 3, 1, 0, 0, 0, 0}
    		+hist = {array = 0xc00003be98, len = 7, cap = 7}
    		 i = 2
    		 81:			hist = ensure(int(i), hist)
    		 82:			hist[int(i)]++
    		@@ -75,7 +75,7 @@
    		 76:			i, err := strconv.ParseInt(s, 10, 64)
    		 77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
    		 err = {tab = 0x0, data = 0x0}
    		-hist =  []int = {0, 3, 2, 0, 0, 0, 0}
    		+hist = {array = 0xc00003be98, len = 7, cap = 7}
    		 i = 2
    		 81:			hist = ensure(int(i), hist)
    		 82:			hist[int(i)]++
    		@@ -85,7 +85,7 @@
    		 76:			i, err := strconv.ParseInt(s, 10, 64)
    		 77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
    		 err = {tab = 0x0, data = 0x0}
    		-hist =  []int = {0, 3, 3, 0, 0, 0, 0}
    		+hist = {array = 0xc00003be98, len = 7, cap = 7}
    		 i = 4
    		 81:			hist = ensure(int(i), hist)
    		 82:			hist[int(i)]++
    		@@ -95,7 +95,7 @@
    		 76:			i, err := strconv.ParseInt(s, 10, 64)
    		 77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
    		 err = {tab = 0x0, data = 0x0}
    		-hist =  []int = {0, 3, 3, 0, 1, 0, 0}
    		+hist = {array = 0xc00003be98, len = 7, cap = 7}
    		 i = 4
    		 81:			hist = ensure(int(i), hist)
    		 82:			hist[int(i)]++
    		@@ -105,7 +105,7 @@
    		 76:			i, err := strconv.ParseInt(s, 10, 64)
    		 77:			if err != nil { //gdb-dbg=(i) //gdb-opt=(err,hist,i)
    		 err = {tab = 0x0, data = 0x0}
    		-hist =  []int = {0, 3, 3, 0, 2, 0, 0}
    		+hist = {array = 0xc00003be98, len = 7, cap = 7}
    		 i = 5
    		 81:			hist = ensure(int(i), hist)
    		 82:			hist[int(i)]++
FAIL
exit status 1
FAIL	cmd/compile/internal/ssa	93.549s

Hmm, might be a gdb version issue.  I'm running 7.9.
@dr2chase

I get the same failure, gdb version 8.1.

My system comes with gdb 7.12

Is that gdb version or presence/absence of Python scripts?
I'll try to figure this out, I could at least make it more picky about gdb version if that is the case.

I have gdb versions 7.9 and 8.0.1, seems to work for me.
I will try to figure out how to install a version that triggers the wrong printing (which I have clearly seen in the past, because of the "/A" following hist).
I am not super-fluent in Python, but this from runtime-gdb.py seems semi-relevant:
class SliceTypePrinter:
	"Pretty print slices."

	pattern = re.compile(r'^struct \[\]')

	def __init__(self, val):
		self.val = val

	def display_hint(self):
		return 'array'

	def to_string(self):
		return str(self.val.type)[6:]  # skip 'struct '

	def children(self):
		sval = SliceValue(self.val)
		if sval.len > sval.cap:
			return
		for idx, item in enumerate(sval):
			yield ('[{0}]'.format(idx), item)

i have added links to the fixes and other discussions so far to the main post

cmd/compile/internal/ssa fails for me with gdb 8.0.1, so the gdb version doesn't seem to be the issue.

The underlying problem here is #12508

@alexd765 the SliceTypePrinter code is really old, so that's probably the same.
My Python versions are 2.7.14 and 2.7.13.  Yours?

@dr2chase I can reproduce it and I only have versions 2.7.14 and 3.6.4 installed. I'm running Arch Linux, so I would assume that any somewhat recent Linux system should have this test failure.
I tried playing with that runtime-gdb.py file, but not even emptying the file changes the behaviour of the test.

I am on Ubuntu 17.10 with python 2.7.14

Except that I am failing to reproduce the bug on Linux....
I am learning a little Python.

@dr2chase I also started to look into this a little bit:
First observation: if i force the test to use delve with ~/gotip/src/cmd/compile/internal/ssa$ go test -d -v it passes.
Then i saw that there is an option to regenerate the testdata with ~/gotip/src/cmd/compile/internal/ssa$ go test -u. It changed some things in 2 testdata files and after that the tests are passing.
I can send the changes as a cl if that helps

Mucking with the testdata files w/o understanding why we have this difference isn't going to help -- you'll break it for me, for example.
Also, I have several CLs stacked up that will mess with the testdata in a big way, alleged positive.  (If you actually look at what's recorded there, there's plenty of room for improvement.)

Perhaps it is not autoloading runtime-gdb.py?
Are there any warnings at the beginning about auto-load and safe-path?
I definitely need to modify the test to be better about this.

@dr2chase all the TestNexting subtests are passing on my machine, so we can fairly safely assume that it's fixed for @alexd765 too :)
Out of the initial 5 issues, 3 have been fixed and 2 have been split into separate issues. So it seems like there's nothing else to do here. Thanks again @alexd765 for reporting them.

Thanks for verifying. I wasn't 100% sure, but I was hopeful.

yeah i can confirm that cmd/compile/internal/ssa is fixed for me as well


repos.halvm.org appears to be down

I am attempting to set up an environment following the instructions in HACKING.md, using Fedora Server 26 in VirtualBox 5.2.0.
I have reached step 3, but repos.halvm.org seems to be down:
[ht@localhost ~]$ sudo dnf install http://repos.halvm.org/fedora-26/x86_64/halvm-yum-repo-26-3.fc26.noarch.rpm
[sudo] password for ht:
Fedora 26 - x86_64 - Updates                                                                          15 MB/s |  16 MB     00:01
Fedora 26 - x86_64                                                                                7.8 MB/s |  53 MB     00:06
Last metadata expiration check: 0:00:04 ago on Sat 28 Oct 2017 09:54:00 AM EDT.
[MIRROR] halvm-yum-repo-26-3.fc26.noarch.rpm: Curl error (28): Timeout was reached for http://repos.halvm.org/fedora-26/x86_64/halvm-yum-repo-26-3.fc26.noarch.rpm [Connection timed out after 120002 milliseconds]
[FAILED] halvm-yum-repo-26-3.fc26.noarch.rpm: Curl error (28): Timeout was reached for http://repos.halvm.org/fedora-26/x86_64/halvm-yum-repo-26-3.fc26.noarch.rpm [Connection timed out after 120002 milliseconds]
Curl error (28): Timeout was reached for http://repos.halvm.org/fedora-26/x86_64/halvm-yum-repo-26-3.fc26.noarch.rpm [Connection timed out after 120002 milliseconds]

Other network operations are working fine inside the VM, and attempting to ping repos.halvm.org from both inside and outside the VM gives no response.

Our server room has been having heat issues, resulting in some non-essential services being turned off.  I'm not positive, but if halvm.org was hosted internally then this is likely the issue.

Looks like everything should be back up. As a positive side effect of our AC blowout, your issue prompted me to update my "even-numbered Fedora" build servers from 24 to 26. So there should be new, shiny Fedora 26 RPMs ready to go. I will warn you, however, that I have only built them, not tested them. The "Should Just Word" (tm, famous last work, etc.), though.

@acw: thanks!  I will give the new 26 RPMs a test and see how they go.
I did create a VM with the "stock" Xen and succeeded in running several of the examples.  There were a few little configuration bits I had to do to get Xen to behave nicely (for example, getting xenconsoled.service to launch and connect to xenstored required me to relax the SELinux policy on Fedora 26 to "permissive").
Do you think writing these things down somewhere in/around this repo is the kind of thing that would be helpful for prospective HaLVM users/contributors?

Absolutely! Indeed, if you'd be interested, updating HACKING.md in any places you think would be helpful would be great.
I'm going to close this ticket, since repos.halvm.org seems to be working, but feel free to open a new one with any other issues you find.


Filter By Clue Type

Would it be possible to add a filter for different types of clue scrolls?
I already have all the easy and medium STASH units filled, so I really don't need the indicator for those items anymore. It would be great if I could turn the indicator off for easy and medium items, but keep indicators on for Hard, Elite, and Master items.

Thanks for your suggestion!
It should be already possible to filter the corresponding items as follows:

In the plugin settings, make sure that items in stashes are not highlighted.
In the plugin stash unit panel, filter by easy, and set all stashes to filled by clicking the white squares next to the stash names.
Then, filter by medium, and again set all to filled.

Does following the steps above achieve what you are looking for?


feat: allow hooking on Dialog animation end

Resolves #878
Not sure this is the expected method, I'd love to have feedback on it

Thanks for the PR @noook . I'm thinking a more general solution for components that are using Presence. I did some test with dispatching custom event, and seems to work pretty well.
something like this
  const dispatchCustomEvent = (name: 'enter' | 'after-enter' | 'leave' | 'after-leave') => {
    const customEvent = new CustomEvent(name, { bubbles: true, cancelable: true })
    node.value?.dispatchEvent(customEvent)
  }

Then in the DialogIOverlay (or any components with Presence) can add listener as such
<DialogOverlay class="animation" @leave="" @after-leave=""   />

I get it, what do you think of it now @zernonia ?
I'm not sure all events can be fired, for example I haven't seen the leave event fired. Also, I am not sure I can detect after-enter either

No prob @noook ! I've pushed some dispatchCustomEvent to cater for after-X event.
I believe this feature fit your original request right? where you can hook into the animation state 😁

That looks fine ! And yes, I tested in the stories it fits the request 🔥

Right now it's not explicit that which component has the hook, but I'm planning to add them in docs soon 😁

I'm not seeing anywhere in the docs on how to do this? Was this removed in a later patch? I.e. this does not work (not events fired):
<DialogOverlay
    @leave="onLeave"
    @after-leave="onLeave"
    v-on:leave="onLeave"
    v-on:after-leave="onLeave"
>...

Am I missing something?


Tickets/1.6.x/11559

In Ruby 1.9.3 the RbConfig library deprecates the use of:
Config::CONFIG
in favour of:
RbConfig::CONFIG
This patch updates all the uses of this command, primarily in the
install.rb file and some facts, to select the appropriate usage using
code like:
Object.const_get(defined?(RbConfig) ? :RbConfig : :Config)::CONFIG

RbConfig is defined everywhere, so there's no need to check for its existence, or to fallback to Config.

Really? Then why is the user getting an error in the ticket?

The module was Config pre-1.8.5, and has been RbConfig since 1.8.5. Config is available for backward compatibility, but is being deprecated in 1.9.3. The user in the ticket is using 1.9.3, and so seeing a deprecation warning about Config. Simply replacing use of it with RbConfig will work everywhere we support.

It does raise the question - what do we support for facter? OS-wise I mean
... or maybe ruby wise which leads into OS support.
On Dec 23, 2011 9:49 PM, "Nick Lewis" <
<EMAIL_ADDRESS>wrote:

The module was Config pre-1.8.5, and has been RbConfig since 1.8.5. Config
is available for backward compatibility, but is being deprecated in 1.9.3.
The user in the ticket is using 1.9.3, and so seeing a deprecation warning
about Config. Simply replacing use of it with RbConfig will work everywhere
we support.

Reply to this email directly or view it on GitHub:
https://github.com/puppetlabs/facter/pull/124#issuecomment-3264963

Huh. Probably a side topic - but I can't actually see a notice anywhere as to which version of ruby we support for facter - perhaps we make a statement somewhere about Puppet. I did find this in the spec file however:
Requires: ruby >= 1.8.1
Which is misleading.
Anyway - if 1.8.5 is all we care about, then I suppose we should drop the need for the backwards compatibility.

I figure it matches Ruby support for Puppet (http://docs.puppetlabs.com/guides/platforms.html).

(I'll take the spec file change offline with Mike then - and possibly raise a ticket).
Feel free to amend your patch for 1.8.5 support only James :-). Sorry about the hassle.

@jamtur01 so I was talking to @daniel-pittman to see if there was another way to do this and he came up with monkey patching. I ran up a little test to see what hassles I might hit:
https://github.com/kbarber/facter/commit/2165b7806df3f1f5b88af6ce2f65a1071da1b92f
What do you think?

Replaced with:
https://github.com/puppetlabs/facter/pull/142


[Bug]: CREATE TYPE does not work with no ';' before '/'

ODC version
4.2.4-1712049785000
OB version
OceanBase <IP_ADDRESS>
What happened?
This SQL can not run (no ';' before '/')
CREATE OR REPLACE TYPE "TYPE_TEST" as object
(
  total  varchar2(4000)
)
/

This SQL can run (with ';' before '/')
CREATE OR REPLACE TYPE "TYPE_TEST" as object
(
  total  varchar2(4000)
);
/

What did you expect to happen?
Both should work
CREATE OR REPLACE TYPE "TYPE_TEST" as object
(
  total  varchar2(4000)
)
/

CREATE OR REPLACE TYPE "TYPE_TEST" as object
(
  total  varchar2(4000)
);
/

How can we reproduce it (as minimally and precisely as possible)?
run following sqls in ODC
CREATE OR REPLACE TYPE "TYPE_TEST" as object
(
  total  varchar2(4000)
)
/

CREATE OR REPLACE TYPE "TYPE_TEST" as object
(
  total  varchar2(4000)
);
/

Anything else we need to know?
No response

Need to modify the parser, the repair cost is high, later versions to fix.


(fix) incorrect reachability assumption in ResourceLeakDetector

As mentioned here, trackedObject != null gives no guarantee that trackedObject remains reachable. It is an expression that can obviously be moved around by the compiler. The recommended solution is to use synchronized blocks to ensure reachability, because they're never optimized out and releasing the monitor requires the reference to remain reachable. This is discussed in https://docs.oracle.com/javase/9/docs/api/java/lang/ref/Reference.html#reachabilityFence-java.lang.Object- However, I am not an expert with intimate knowledge of the JDK. (If you have one, ask them!)

@carl-mastrangelo @ejona86 @almson this may be an alternative fix for it: https://github.com/netty/netty/pull/8422

@ejona86 I agree that try { close() } finally { synchronized (trackedObject) { } } should work. Empty synchronized can't be optimized away because it sets up a happens-before relationship for the surrounding code (people use them: https://stackoverflow.com/a/31933260/1151521). I suppose we can even stick synchronized (trackedObject) { } into PlatformDependent.
I got as far as I could with the new commit. However, I do not know what I should do in PlatformDependent to reference the Java 9 method.

Use reflection to call it 👍

@carl-mastrangelo I'm not sure what you're asking. The bug is that the expression trackedObject != null is not a substitute for Reference.reachabilityFence. (it can be moved all the way to the top of the method.) The documentation for reachabilityFence says that synchronized is a substitute. A synchronized block cannot be moved because it creates happens-before semantics. A synchronized block keeps the object reachable because it uses its reference to call releaseMonitor. Optimizing out a synchronize is nearly impossible because the compiler would have to exclude any possibility that anyone else might synchronize on the object. (Actually, the GC can tell that nobody holds a reference to the object and therefore can't synchronize on it, but not the compiler.) In any case, this seems to be the recommended solution even in Java 9.
See: https://docs.oracle.com/javase/9/docs/api/java/lang/ref/Reference.html#reachabilityFence-java.lang.Object-

@almson good point... then lets just put the synchronised stuff in in the leak detector. no need to add something to PlatformDependent.

Well, it might be useful in other parts. Does any other code anywhere use finalizer or a weak/phantom reference? Does netty only do leak detection, or is there code somewhere that tries to clean up leaks?

@almson I think we only need it here.

I see WeakOrderQueue, HashedWheelTimer, PoolArena, and PoolThreadCache have finalizers. I also see other places where WeakReference and SoftReference are used. All of those places might require reachabilityFence. I haven't actually looked at them yet.

@almson from my understanding they need not... Let us just focus on the leakdetector in this pr and we can do another one if we really need more changes.

Well, the question was should we create PlatformDependent.reachabilityFence.

Ok, I'm going to save reachabilityFence together with its javadoc, but put it in ResourceLeakDetector.

From what I see so far:

PoolArena.finalize is useless. Its only purpose is to hurry up the GC. But because it's a finalizer, all it does is delay it! For correctness, PoolArena would need a reachabilityFence in every method. I'm guessing it hasn't yet caused problems because it's so long lived it only becomes unreachable at shutdown.
Recycler.WeakOrderQueue.finalize also seems useless. It's supposed to be a GC optimization--but, again, a finalizer delays GC. If clearing the references really is a good optimization, then it will be even better if invoked directly not through finalization. It's not clear how dangerous this finalizer is.
HashedWheelTimer.finalize seems to only be part of a logging feature, so is harmless.
PoolThreadCache.finalize ok if free is called (but then, it doesn't do anything). Will suffer from premature finalization if free is not called. It should be hooked up to the leak detector instead.
There is an ObjectCleaner, but I don't see it being used anywhere. If it is, it's going to cause problems.

The other uses of weak references don't use ReferenceQueues, other than the leak detector.

@almson let’s focus on the one case here and then we can open a new issue and discuss about the others there. I want to keep the focus on this change

@almson for now not... if we need it at the end we can easily do later on.

@normanmaurer I don't understand. Now not what?
Should I squash the commits?

@almson ignore my comment... I may have read an old comment and tried to answer 🤣
Just squash and thanks again for your help!

@netty-bot test this please

Np! This was my first github pull request, btw.

@almson please fix all the check style errors:
11:57:35 [INFO] Starting audit...
11:57:35 /code/common/src/main/java/io/netty/util/ResourceLeakDetector.java:466:13: '}' should be on the same line.
11:57:35 /code/common/src/main/java/io/netty/util/ResourceLeakDetector.java:468: Line is longer than 120 characters (found 121).
11:57:35 /code/common/src/main/java/io/netty/util/ResourceLeakDetector.java:475: trailing whitespace
11:57:35 /code/common/src/main/java/io/netty/util/ResourceLeakDetector.java:476: trailing whitespace
11:57:35 /code/common/src/main/java/io/netty/util/ResourceLeakDetector.java:484: trailing whitespace
11:57:35 /code/common/src/main/java/io/netty/util/ResourceLeakDetector.java:488: trailing whitespace
11:57:35 /code/common/src/main/java/io/netty/util/ResourceLeakDetector.java:489: Line is longer than 120 characters (found 128).
11:57:35 /code/common/src/main/java/io/netty/util/ResourceLeakDetector.java:492: trailing whitespace
11:57:35 /code/common/src/main/java/io/netty/util/ResourceLeakDetector.java:496:47: '(' is preceded with whitespace.
11:57:35 /code/common/src/main/java/io/netty/util/ResourceLeakDetector.java:499:37: '{' is not followed by whitespace.
11:57:35 /code/common/src/main/java/io/netty/util/ResourceLeakDetector.java:499:37: '}' is not preceded with whitespace.
11:57:35 Audit done.

Just run ./mvnw clean package to see if there are any left.

Updated. Thanks for your patience.

@netty-bot test this please

@almson you will need to change the name of the method to be able to compile on java9 and later. See the error message on the ci
https://ci.netty.io/job/netty-centos6-java11-prb/152/console

Wow, ironic.  That seems to be popular.

Yeah why not 😂

Am 23.10.2018 um 16:06 schrieb almson<EMAIL_ADDRESS>Wow, ironic.  That seems to be popular.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@netty-bot test this please

@almson this looks good now... One last thing can you please amend your commit message to match our commit template and force push ?
After this is done I will pull in:
https://netty.io/wiki/writing-a-commit-message.html

done

@almson thanks a lot for all your work here!


Miscellaneous improvements

Please have a look at the individual commit messages for the details.

@mnonnenmacher is this also ok with you? In Particular, I wonder whether
https://github.com/oss-review-toolkit/ort-workbench/pull/173/files#diff-2f2376c0396f630c4a0333ba05dd78ff1bec1bdaab8dd9b580e854f306edb437R79-R81
could be simplified now that the string representation of info.duration is used directly.

@mnonnenmacher is this also ok with you? In Particular, I wonder whether
https://github.com/oss-review-toolkit/ort-workbench/pull/173/files#diff-2f2376c0396f630c4a0333ba05dd78ff1bec1bdaab8dd9b580e854f306edb437R79-R81
could be simplified now that the string representation of info.duration is used directly.

Do you mean if remember is still required? Compared to the code before I would say yes, because duration.toString() should be on the same level of complexity as the previous code. In general, I don't know if there is a good rule for when a calculation becomes complex enough to be remembered across recompositions, so I tend to use it whenever something is more complex than simple math or a string concatenation.

Do you mean if remember is still required?

Yes. Thanks for the explanation.


When several players have answered correctly, the time will be looked at (the fastest answerer will be first, the second fastest second and so on).

https://github.com/sopra-fs23-group-28/sopra-fs23-group-28-server/actions/runs/4784348355


URL Response Decoding

Hey Florian - I had an issue with using munin-host.py. Since using urllib.request.urlopen() at line 312 under the VT API Requests, the response is in bytes and needs to be decoded or else an error "TypeErrorL the JSON object must be str, not 'bytes'" is given.
Currently
`              response = urllib.request.urlopen('%s?%s' % (URLS[cat],
urllib.parse.urlencode(parameters)), context=ctx).read()
            response_dict = json.loads(response)
            success = True

`
Fix
`              response = urllib.request.urlopen('%s?%s' % (URLS[cat],
urllib.parse.urlencode(parameters)), context=ctx).read()
            response_dict = json.loads(response.decode('utf-8'))
            success = True

`

Did you use Python 2 oder 3

Python3.4 in a virtualvenv. urllib.request would not work in python2.7 for me.


Add 7th saga children by chronamut

Song Name
7th saga children
Artist Name
chronamut
Source
Youtube
Youtube Link
TvE4p-IQUMs
Direct File Link
No response
Song ID
6666
Extra
Created from Auto Nong.
Created for level: 91595868

accept

Thanks!


Advanced Map no longer working on macOS 14.4 (23E214)

It seems that Apple changed more things under the hood. The 3D globe is no longer working on my Lenovo T490 after updating to macOS 14.4.

iGPU: Intel UHD 620, spoofed as Intel UHD 630

same, RX 6700 XT

Nuts. My hackintosh is still on 14.3, so I'll get it upgraded and try to work out what's changed. Fingers crossed it's something minor.

I won't be on my Intel machine until tomorrow (hopefully!), but I wrote a quick script that dumps values (+ some debug info) so we might be able to find a suitable replacement value.
If either of you have Xcode installed and want to compile a script, it's at https://gist.github.com/notjosh/01ea1f424c35ce6c423477b7b780a0f1. Would be interested if values have changed on 14.4.
For me on my M1, the output looks like:
$ cc dumper.m -o dumper -framework Foundation -framework Metal -lMobileGestalt -O3
$ ./dumper
2024-03-15 21:11:58.642 dumper[6607:179434] macOS version: Version 14.4 (Build 23E214)
2024-03-15 21:11:58.642 dumper[6607:179434] Architecture: arm64
2024-03-15 21:11:58.642 dumper[6607:179434] GPUs (
        {
        MTLGPUFamilyApple1 = 1;
        MTLGPUFamilyApple2 = 1;
        MTLGPUFamilyApple3 = 1;
        MTLGPUFamilyApple4 = 1;
        MTLGPUFamilyApple5 = 1;
        MTLGPUFamilyApple6 = 1;
        MTLGPUFamilyApple7 = 1;
        MTLGPUFamilyApple8 = 0;
        MTLGPUFamilyApple9 = 0;
        MTLGPUFamilyCommon1 = 1;
        MTLGPUFamilyCommon2 = 1;
        MTLGPUFamilyCommon3 = 1;
        MTLGPUFamilyMac2 = 1;
        MTLGPUFamilyMetal3 = 1;
        name = "Apple M1 Pro";
    }
)
2024-03-15 21:11:58.642 dumper[6607:179434] {
    DeviceSupportsActiveNFCReadingOnly = 0;
    DeviceSupportsAdvancedMapRendering = 1;
    DeviceSupportsCorrectedTemperature = 0;
    DeviceSupportsEnhancedMultitasking = 0;
    DeviceSupportsHeartRateVariability = 1;
    DeviceSupportsSideButtonClickSpeed = 0;
    DeviceSupportsSingleCameraPortrait = 0;
    DeviceSupportsStereoAudioRecording = 0;
    FrontCameraOffsetFromDisplayCenter = "<null>";
    FrontFacingCameraAutoHDRCapability = 1;
    RearFacingCameraMaxVideoZoomFactor = 3;
    RearFacingCameraModuleSerialNumber = "<null>";
    RearFacingLowLightCameraCapability = 0;
    RenderWideGamutImagesAtDisplayTime = 1;
}

2024-03-15 21:35:33.077 dumper[1024:9851] macOS version: Version 14.4 (Build 23E214)
2024-03-15 21:35:33.077 dumper[1024:9851] Architecture: x86_64
2024-03-15 21:35:33.077 dumper[1024:9851] GPUs (
{
MTLGPUFamilyApple1 = 0;
MTLGPUFamilyApple2 = 0;
MTLGPUFamilyApple3 = 0;
MTLGPUFamilyApple4 = 0;
MTLGPUFamilyApple5 = 0;
MTLGPUFamilyApple6 = 0;
MTLGPUFamilyApple7 = 0;
MTLGPUFamilyApple8 = 0;
MTLGPUFamilyApple9 = 0;
MTLGPUFamilyCommon1 = 1;
MTLGPUFamilyCommon2 = 1;
MTLGPUFamilyCommon3 = 1;
MTLGPUFamilyMac2 = 1;
MTLGPUFamilyMetal3 = 1;
name = "AMD Radeon HD GFX10 Family Unknown Prototype";
}
)
2024-03-15 21:35:33.077 dumper[1024:9851] {
DeviceSupportsActiveNFCReadingOnly = 0;
DeviceSupportsAdvancedMapRendering = 0;
DeviceSupportsCorrectedTemperature = 0;
DeviceSupportsEnhancedMultitasking = 0;
DeviceSupportsHeartRateVariability = 1;
DeviceSupportsSideButtonClickSpeed = 0;
DeviceSupportsSingleCameraPortrait = 0;
DeviceSupportsStereoAudioRecording = 0;
FrontCameraOffsetFromDisplayCenter = "";
FrontFacingCameraAutoHDRCapability = 0;
RearFacingCameraMaxVideoZoomFactor = "";
RearFacingCameraModuleSerialNumber = "";
RearFacingLowLightCameraCapability = 0;
RenderWideGamutImagesAtDisplayTime = 1;
}
2024-03-15 21:35:33.079 dumper[1024:9851] Platform: {
hardwareClass = Mac;
hardwareIdentifier = "MacPro7,1";
hardwareModel = "MacPro7,1";
isInternalInstall = 0;
mapsFeatureFreedomEnabled = 0;
osAndBuildVersion = "14.4.23E214";
osVersion = "14.4";
productName = macOS;
supportsAdvancedMap = 0;
supportsForceTouch = 0;
supportsNavigation = 0;
supportsRealisticTiles = 0;
}

Oh weird, RenderWideGamutImagesAtDisplayTime is the value I use as a substitute, which you still get as 1, so something else must be up. Hold that thought!
Thanks for getting onto it so quick :)

For reference later, here's how the output is on 14.3.1 (Intel)
2024-03-15 21:40:11.838 dumper[30239:78519] macOS version: Version 14.3.1 (Build 23D60)
2024-03-15 21:40:11.838 dumper[30239:78519] Architecture: x86_64
2024-03-15 21:40:11.838 dumper[30239:78519] GPUs (
        {
        MTLGPUFamilyApple1 = 0;
        MTLGPUFamilyApple2 = 0;
        MTLGPUFamilyApple3 = 0;
        MTLGPUFamilyApple4 = 0;
        MTLGPUFamilyApple5 = 0;
        MTLGPUFamilyApple6 = 0;
        MTLGPUFamilyApple7 = 0;
        MTLGPUFamilyApple8 = 0;
        MTLGPUFamilyApple9 = 0;
        MTLGPUFamilyCommon1 = 1;
        MTLGPUFamilyCommon2 = 1;
        MTLGPUFamilyCommon3 = 1;
        MTLGPUFamilyMac2 = 1;
        MTLGPUFamilyMetal3 = 1;
        name = "AMD Radeon HD GFX10 Family Unknown Prototype";
    }
)
2024-03-15 21:40:11.838 dumper[30239:78519] {
    DeviceSupportsActiveNFCReadingOnly = 0;
    DeviceSupportsAdvancedMapRendering = "<null>";
    DeviceSupportsCorrectedTemperature = 0;
    DeviceSupportsEnhancedMultitasking = 0;
    DeviceSupportsHeartRateVariability = 1;
    DeviceSupportsSideButtonClickSpeed = 0;
    DeviceSupportsSingleCameraPortrait = 0;
    DeviceSupportsStereoAudioRecording = 0;
    FrontCameraOffsetFromDisplayCenter = "<null>";
    FrontFacingCameraAutoHDRCapability = 0;
    RearFacingCameraMaxVideoZoomFactor = "<null>";
    RearFacingCameraModuleSerialNumber = "<null>";
    RearFacingLowLightCameraCapability = 0;
    RenderWideGamutImagesAtDisplayTime = 1;
}
2024-03-15 21:40:11.841 dumper[30239:78519] Platform: {
    hardwareClass = Mac;
    hardwareIdentifier = "iMac19,1";
    hardwareModel = "iMac19,1";
    isInternalInstall = 0;
    mapsFeatureFreedomEnabled = 0;
    osAndBuildVersion = "<IP_ADDRESS>D60";
    osVersion = "14.3.1";
    productName = macOS;
    supportsAdvancedMap = 1;
    supportsForceTouch = 0;
    supportsNavigation = 0;
    supportsRealisticTiles = 0;
}

DeviceSupportsAdvancedMapRendering being nil is weird, but the 3d globe still works. I'm guessing they've changed that to be more strict in 14.4.

2024-03-16 05:57:21.703 dumper[1113:81912] macOS version: Version 14.4 (Build 23E214)
2024-03-16 05:57:21.703 dumper[1113:81912] Architecture: x86_64
2024-03-16 05:57:21.704 dumper[1113:81912] GPUs (
        {
        MTLGPUFamilyApple1 = 0;
        MTLGPUFamilyApple2 = 0;
        MTLGPUFamilyApple3 = 0;
        MTLGPUFamilyApple4 = 0;
        MTLGPUFamilyApple5 = 0;
        MTLGPUFamilyApple6 = 0;
        MTLGPUFamilyApple7 = 0;
        MTLGPUFamilyApple8 = 0;
        MTLGPUFamilyApple9 = 0;
        MTLGPUFamilyCommon1 = 1;
        MTLGPUFamilyCommon2 = 1;
        MTLGPUFamilyCommon3 = 1;
        MTLGPUFamilyMac2 = 1;
        MTLGPUFamilyMetal3 = 1;
        name = "Intel(R) UHD Graphics 630";
    }
)
2024-03-16 05:57:21.704 dumper[1113:81912] {
    DeviceSupportsActiveNFCReadingOnly = 0;
    DeviceSupportsAdvancedMapRendering = "<null>";
    DeviceSupportsCorrectedTemperature = 0;
    DeviceSupportsEnhancedMultitasking = 0;
    DeviceSupportsHeartRateVariability = 1;
    DeviceSupportsSideButtonClickSpeed = 0;
    DeviceSupportsSingleCameraPortrait = 0;
    DeviceSupportsStereoAudioRecording = 0;
    FrontCameraOffsetFromDisplayCenter = "<null>";
    FrontFacingCameraAutoHDRCapability = 0;
    RearFacingCameraMaxVideoZoomFactor = "<null>";
    RearFacingCameraModuleSerialNumber = "<null>";
    RearFacingLowLightCameraCapability = 0;
    RenderWideGamutImagesAtDisplayTime = 1;
}
2024-03-16 05:57:21.710 dumper[1113:81912] Platform: {
    hardwareClass = Mac;
    hardwareIdentifier = "MacBookPro15,2";
    hardwareModel = "MacBookPro15,2";
    isInternalInstall = 0;
    mapsFeatureFreedomEnabled = 0;
    osAndBuildVersion = "14.4.23E214";
    osVersion = "14.4";
    productName = macOS;
    supportsAdvancedMap = 0;
    supportsForceTouch = 0;
    supportsNavigation = 0;
    supportsRealisticTiles = 0;
}

This id from my Lenovo T530 which uses Intel HD 4000 Graphics:
2024-03-16 13:25:25.536 dumper[889:9635] macOS version: Version 14.4 (Build 23E214)
2024-03-16 13:25:25.536 dumper[889:9635] Architecture: x86_64
2024-03-16 13:25:25.536 dumper[889:9635] GPUs (
        {
        MTLGPUFamilyApple1 = 0;
        MTLGPUFamilyApple2 = 0;
        MTLGPUFamilyApple3 = 0;
        MTLGPUFamilyApple4 = 0;
        MTLGPUFamilyApple5 = 0;
        MTLGPUFamilyApple6 = 0;
        MTLGPUFamilyApple7 = 0;
        MTLGPUFamilyApple8 = 0;
        MTLGPUFamilyApple9 = 0;
        MTLGPUFamilyCommon1 = 1;
        MTLGPUFamilyCommon2 = 1;
        MTLGPUFamilyCommon3 = 0;
        MTLGPUFamilyMac2 = 0;
        MTLGPUFamilyMetal3 = 0;
        name = "Intel HD Graphics 4000";
    }
)
2024-03-16 13:25:25.536 dumper[889:9635] {
    DeviceSupportsActiveNFCReadingOnly = 0;
    DeviceSupportsAdvancedMapRendering = "<null>";
    DeviceSupportsCorrectedTemperature = 0;
    DeviceSupportsEnhancedMultitasking = 0;
    DeviceSupportsHeartRateVariability = 1;
    DeviceSupportsSideButtonClickSpeed = 0;
    DeviceSupportsSingleCameraPortrait = 0;
    DeviceSupportsStereoAudioRecording = 0;
    FrontCameraOffsetFromDisplayCenter = "<null>";
    FrontFacingCameraAutoHDRCapability = 0;
    RearFacingCameraMaxVideoZoomFactor = "<null>";
    RearFacingCameraModuleSerialNumber = "<null>";
    RearFacingLowLightCameraCapability = 0;
    RenderWideGamutImagesAtDisplayTime = 1;
}
2024-03-16 13:25:25.541 dumper[889:9635] Platform: {
    hardwareClass = Mac;
    hardwareIdentifier = "MacBookPro10,1";
    hardwareModel = "MacBookPro10,1";
    isInternalInstall = 0;
    mapsFeatureFreedomEnabled = 0;
    osAndBuildVersion = "14.4.23E214";
    osVersion = "14.4";
    productName = macOS;
    supportsAdvancedMap = 0;
    supportsForceTouch = 0;
    supportsNavigation = 0;
    supportsRealisticTiles = 0;
}

2024-03-17 00:19:16.905 dumper[3372:23465] macOS version: Version 14.4 (Build 23E214)
2024-03-17 00:19:16.905 dumper[3372:23465] Architecture: x86_64
2024-03-17 00:19:16.905 dumper[3372:23465] GPUs (
{
MTLGPUFamilyApple1 = 0;
MTLGPUFamilyApple2 = 0;
MTLGPUFamilyApple3 = 0;
MTLGPUFamilyApple4 = 0;
MTLGPUFamilyApple5 = 0;
MTLGPUFamilyApple6 = 0;
MTLGPUFamilyApple7 = 0;
MTLGPUFamilyApple8 = 0;
MTLGPUFamilyApple9 = 0;
MTLGPUFamilyCommon1 = 1;
MTLGPUFamilyCommon2 = 1;
MTLGPUFamilyCommon3 = 1;
MTLGPUFamilyMac2 = 1;
MTLGPUFamilyMetal3 = 1;
name = "Intel(R) UHD Graphics 630";
}
)
2024-03-17 00:19:16.905 dumper[3372:23465] {
DeviceSupportsActiveNFCReadingOnly = 0;
DeviceSupportsAdvancedMapRendering = 0;
DeviceSupportsCorrectedTemperature = 0;
DeviceSupportsEnhancedMultitasking = 0;
DeviceSupportsHeartRateVariability = 1;
DeviceSupportsSideButtonClickSpeed = 0;
DeviceSupportsSingleCameraPortrait = 0;
DeviceSupportsStereoAudioRecording = 0;
FrontCameraOffsetFromDisplayCenter = "";
FrontFacingCameraAutoHDRCapability = 0;
RearFacingCameraMaxVideoZoomFactor = "";
RearFacingCameraModuleSerialNumber = "";
RearFacingLowLightCameraCapability = 0;
RenderWideGamutImagesAtDisplayTime = 1;
}
2024-03-17 00:19:16.909 dumper[3372:23465] Platform: {
hardwareClass = Mac;
hardwareIdentifier = "MacBookPro16,4";
hardwareModel = "MacBookPro16,4";
isInternalInstall = 0;
mapsFeatureFreedomEnabled = 0;
osAndBuildVersion = "14.4.23E214";
osVersion = "14.4";
productName = macOS;
supportsAdvancedMap = 0;
supportsForceTouch = 0;
supportsNavigation = 0;
supportsRealisticTiles = 0;
}

2024-06-18 15:45:51.194 dumper[3084:26292] macOS version: Version 15.0 (Build 24A5264n)
2024-06-18 15:45:51.194 dumper[3084:26292] Architecture: x86_64
2024-06-18 15:45:51.194 dumper[3084:26292] GPUs (
{
MTLGPUFamilyApple1 = 0;
MTLGPUFamilyApple2 = 0;
MTLGPUFamilyApple3 = 0;
MTLGPUFamilyApple4 = 0;
MTLGPUFamilyApple5 = 0;
MTLGPUFamilyApple6 = 0;
MTLGPUFamilyApple7 = 0;
MTLGPUFamilyApple8 = 0;
MTLGPUFamilyApple9 = 0;
MTLGPUFamilyCommon1 = 1;
MTLGPUFamilyCommon2 = 1;
MTLGPUFamilyCommon3 = 1;
MTLGPUFamilyMac2 = 1;
MTLGPUFamilyMetal3 = 1;
name = "AMD Radeon HD GFX10 Family Unknown Prototype";
}
)
2024-06-18 15:45:51.194 dumper[3084:26292] {
DeviceSupportsActiveNFCReadingOnly = 0;
DeviceSupportsAdvancedMapRendering = "";
DeviceSupportsCorrectedTemperature = 0;
DeviceSupportsEnhancedMultitasking = 0;
DeviceSupportsHeartRateVariability = 1;
DeviceSupportsSideButtonClickSpeed = 0;
DeviceSupportsSingleCameraPortrait = 0;
DeviceSupportsStereoAudioRecording = 0;
FrontCameraOffsetFromDisplayCenter = "";
FrontFacingCameraAutoHDRCapability = 0;
RearFacingCameraMaxVideoZoomFactor = "";
RearFacingCameraModuleSerialNumber = "";
RearFacingLowLightCameraCapability = 0;
RenderWideGamutImagesAtDisplayTime = 1;
}
2024-06-18 15:45:51.197 dumper[3084:26292] Platform: {
hardwareClass = Mac;
hardwareIdentifier = "MacPro7,1";
hardwareModel = "MacPro7,1";
isInternalInstall = 0;
mapsFeatureFreedomEnabled = 0;
osAndBuildVersion = "15.0.24A5264n";
osVersion = "15.0";
productName = macOS;
supportsAdvancedMap = 1;
supportsForceTouch = 0;
supportsNavigation = 0;
supportsRealisticTiles = 0;
}

@5T33Z0 can u confirm UHD 620 working for u?

@narcyzzo Yes, I checked it yesterday. That's why closed the issue.


Utility for examining diffims

Requirements:
specify visit on command line.
list possible diffims
Overlay masks
overlay dia sources -- red plus
overlay direct sources -- green circle
Display:
Frame 0: Direct
Frame 1: diff
Frame 2: Direct + diff

Somethings that we may want to do by adding to this:

Can we later access the template and Direct (I am assuming this is the science image)  at different stages of processing? I am guessing that the default will be the template and science images transformed by (preconvolution, warping, and kernel matching) so that a direct pixel by pixel subtraction gives the resultant difference image?
Can we change the threshold of detection?
Can we look at the difference image around a ra, dec value?

Can we later access the template and Direct (I am assuming this is the science image) at different stages of processing? I am guessing that the default will be the template and science images transformed by (preconvolution, warping, and kernel matching) so that a direct pixel by pixel subtraction gives the resultant difference image?

There are a couple of pre-defined data products that will help with this, but mostly this will require turning on the debugging output and running in the interactive debug mode.

Can we change the threshold of detection?

Not interactively in a tool like this.  We would have to rerun the data to get this.

Can we look at the difference image around a ra, dec value?

You mean other than using the built in utilities in DS9?  We could do this, but it seems like just using the display tools is the way to do this rather than building an ad hoc cutout service.

Can we change the threshold of detection?
Not interactively in a tool like this. We would have to rerun the data to get this.

More clearly, I meant that after running the diffim, can I find out unique locations of a residual which have different levels of significance than the default. If that requires re-running, I  am guessing that you mean re-running the difference image task rather than the previous image based steps.

More clearly, I meant that after running the diffim, can I find out unique locations of a residual which have different levels of significance than the default. If that requires re-running, I am guessing that you mean re-running the difference image task rather than the previous image based steps.

Correct.  There is no way to change the detection threshold interactively.  The diffim step needs to be rerun with another threshold.  There has been talk of allowing multiple detection thresholds, but I don't know how that translates into the mask layer.

Ok. But we can always run this looping through the diffim task at multiple thresholds if we really want to ...

Merged as part of #397


Updated dependency versions

dependencies version bumped to up to date values
update plugin versions to up to date values. This will help to

use jdk11 to compile project (jacoco)
start using junit5 later (surefire and failsafe plugin versions)

Removed all deprecations that are present due to migration to junit 4.13

This PR superseeds #176


Feature request: Make owner and repo configurable

Currently the action will only upload assets to a release in the current repo. My use-case is that i'd like to keep the app code in a private repo and use this action to upload assets to a release in a public repo that I configure (so i can have the app source in a private repo and the binaries in a public repo).
https://github.com/tauri-apps/tauri-action/blob/b2d9983822d6a0f20aaca7543a5e2fc314204159/packages/action/src/upload-release-assets.ts#L36-L37

Until the action's own upload mechanism supports this (if at all), you can use the last example from our readme which does support that already: https://github.com/tauri-apps/tauri-action#uploading-the-artifacts-to-a-release

Thanks for responding. The last example allows creating the draft release and publishing the release in another repo, but the assets upload part only happens inside tauri-action (which is hardcoded to context.repo.owner/repo)


gnomeExtensions: system-monitor settings UI crashed

Describe the bug
gnomeExtensions.system-monitor's upstream has fixed the problem  that the settings UI doesn't display in GNOME 40. But the UI is still broken in NixOS.
To Reproduce
Steps to reproduce the behavior:

checkout nixpkgs to commit https://github.com/NixOS/nixpkgs/commit/225b7514d871eebf8a7b97c913111889d6a52c96
install gnomeExtensions.system-monitor

Expected behavior
launch settings from Extensions normally.
Additional context
Exceptions throws:
Error: Requiring Clutter, version none: Typelib file for namespace 'Clutter' (any version) not found

Stack trace:
  @/run/current-system/sw/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com/compat.js:2:17
  @/run/current-system/sw/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com/prefs.js:14:14
  _init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:206:33
  OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
  asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22
  run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20
  main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
  run@resource:///org/gnome/gjs/modules/script/package.js:206:19
  start@resource:///org/gnome/gjs/modules/script/package.js:190:8
  @/nix/store/7wp9ji35hklpbpyi7c5jvknwwr769igz-gnome-shell-40.1/share/gnome-shell/.org.gnome.Shell.Extensions-wrapped:7:17

Notify maintainers

@jtojnar
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 5.11.21, NixOS, 21.05.20210516.9b92a81 (Okapi)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.4pre20210503_6d2553a`
 - channels(root): `"nixos-21.05pre289532.9b92a817238"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: gnomeExtensions.system-monitor
# a list of nixos modules affected by the problem
module:

Right, this is a known bug:
https://github.com/paradoxxxzero/gnome-shell-system-monitor-applet/pull/621#issuecomment-656788147
We would need to add Clutter to preferences using this method: https://nixos.org/manual/nixpkgs/stable/#ssec-gnome-common-issues-unwrappable-package-gnome-shell-ext
Or preferably change the extension so that it does not depend on Clutter in preferences.

I opened a PR with a fix upstream: https://github.com/paradoxxxzero/gnome-shell-system-monitor-applet/pull/693


Angular Formly with Kendo UI

What about best practices for intereacting Formly with KendoUI widgets? In particular Formly needs ng-model....kendo use k-ng-model....and using kendo is a very bad thing to use both!!!
HELP!!!

I think I saw functionality in formly source code to turn off the default handling for ng-model. You could possibly implement your own model watching & update the formy model when KendoUI model changes in a custom type http://docs.telerik.com/kendo-ui/api/javascript/data/model#events-change

Thanks a lot, I've implemented exactly this solution, but I'm looking for an "official" answer , particularly to adopt a best practice. Thanks a lot for your answer

This is a common software application pattern so I would recommend to create a jsbin / library for it and we can add it on the website either as an example or feature it on the integrations section.
This is as close to official as you'll get :)

@Gildissimo any chance you can share your solution? I'm hoping to create a Kendo UI template for Angular Formly and this would really help me get started. A JSBin or something would be great.


Add an overlaps_point method to Areas

Area nodes have an overlaps_area and an overlaps_body method. An overlaps_point(Vector) method would be very nice. Such a method exists in Unity (https://docs.unity3d.com/ScriptReference/Collider2D.OverlapPoint.html), Game Maker, and so on.

Physics/Physics2DDirectSpaceState has that method.
http://docs.godotengine.org/en/3.0/classes/class_physics2ddirectspacestate.html#class-physics2ddirectspacestate-intersect-point
Area do not have to know what a point is (is a trigger type made to interact with other CollisionObjects) so maybe it does not belong to that class.

Also, areas are not the only physics object that could be intersected with stuff, there is also static bodies, rigid bodies, kinematic bodies, both 2D and 3D.
Such functions are indeed all present in PhysicsServer, for point, ray and shape intersection.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


Updating testing and SSL ciphers for MySQL 8.0.xx changes

Making changes to MySQL image to build and update SSL Ciphers because of deprecations

Known that 5.6 and 5.7 will fail. This is due the repo changes. We will work on refactoring that site of the code.

Bypass approved


Add juno filter

Any updates? Would love to get this in!

Sorry for the delay. I've been really busy lately, but your suggestion is great. I just made the adjustment. :smile:


Kotlinx serialization support

A support library that contains bignum serializers. Needs to be separate as KotlinX Serialization doesn't support Linux ARM and MinGW x86 targets, and also JS legacy build errors out so it's not included in the library. This addresses #170 and #181.

Hey. Are there any docs for this? Should I use it like this?
@Serializable
class example() {
  val number: ByteArraySerializable = 0.toBigInteger()
}

This gives an error:
@Serializable
class example() {
  val number: BigInteger = 0.toBigInteger()
}

Serializer has not been found for type 'BigInteger'. To use context serializer as fallback, explicitly annotate type or property with @Contextual


Apply PSR2

Rather than manually applying the changes, what do you think about leveraging one of

friendsofphp/php-cs-fixer
squizlabs/php_codesniffer

?

It's on the todolist, but that would make lots of PRs conflicting.

It's on the todolist, but that would make lots of PRs conflicting.

Then there will never be a good time to do so.

Right, but the PHP 7 and PSR-18 upgrade will also be a huge upgrade, so I planned to time applying the PHP CS fixer to that date.

Having on CI (travis) the checks about codestyle wont this save you some review time from these huge upgrades? And as far as I know according to the public development that I see from PRs on github the progress for applying PSR-18 and PHP 7 is a not that big... maybe I am wrong.
Sorry if I push stuff... that's not my intention but I believe it would be better to have a set of rules and enforce them through CI, rather than having these huge upgrades and having more changes later on. Anyway I stop here.. your decision at the end of the day.

@sagikazarmark
Then let's get these PRs merged! Please let us know if we can help move forward! 🤓

Thanks @omarkdev @localheinz . This will be fixed when I get to #2239


fix(theme-classic): avoid rendering empty search box container

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[x] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

https://stackblitz.com/github/facebook/docusaurus/tree/starter
The search box should not be displayed when the search function is not enabled.
Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs

https://github.com/facebook/docusaurus/blob/main/packages/docusaurus-theme-search-algolia/src/theme/SearchBar/index.tsx#L268-L270
That can only be determined by the algolia configuration.

The problem is that we are trying to add an implicit search bar by default (ie not configured through themeConfig.navbar.items). When user does not want search, it does not make sense.
What I suggest is that in 3.0 we can do a breaking change:

stop automatically adding an implicit search-bar, force user to be explicit and always provide it as a navbar item
warn if user has no search navbar item but there's a an algolia config provided, eventually try to restore a retrocompatible behavior?
make sure it works nicely on mobile too!

Another possible solution: using CSS .myContainer:has(> *) but it's not supported enough unfortunately
In the future, we should allow search plugin authors to register their own Navbar item components. They would be able to create a type: "my-local-search" instead of overwriting @theme/SearchBar

Is it possible to use this method here?
children.type() === null

I read:
React component children detect if empty / null before render
Is there any way for Parent to know if Child rendered null?

There's no good solution to this problem in React. I don't want to introduce hacky workarounds in our theme when there's a clear elegant solution: be explicit and avoid rendering this parent search component in the first place

Looks like it can only be hack with CSS.

What about using the named Noop component and then before rendering SearchBar, checking the value of SearchBar.name !== 'Noop'? Maybe is a lesser of an evil?

will be fixed in https://github.com/facebook/docusaurus/pull/9385


Merge editor is always dirty

Testing #150389

Open merge editor

Bug
For me, the merge editor tab is always dirty

From the test plan item description, I believe it should only become dirty when you edit the result

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.
Happy Coding!

I think this was also fixed in the latest insiders too. Opening the file no longer shows it as dirty for me

👍 , same feelings. Instead of removing the merge markers, maybe we can hide them in some clever way so that they are not in the way when accepting one of the changes.

See https://github.com/microsoft/vscode/issues/152841#issuecomment-1172418009 - there will be an option to discard merge changes, basically restoring the initial state with the merge markers. Closing this issue as mostly duplicated by #152841