Failed to start connection with RustConnection

I get the following error message:
thread 'main' panicked at 'Failed to start connection: Error { error: SetupFailed(SetupFailed { status: 0, protocol_major_version: 11, protocol_minor_version: 0, length: 6, reason: [78, 111, 32, 112, 114, 111, 116, 111, 99, 111, 108, 32, 115, 112, 101, 99, 105, 102, 105, 101, 100, 10] }) }', src/libcore/result.rs:1188:5
stack backtrace:
   0:     0x55c3aa1fa86f - backtrace::backtrace::libunwind::trace::heb43798aede8bd30
                               at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/libunwind.rs:88
   1:     0x55c3aa1fa86f - backtrace::backtrace::trace_unsynchronized::had2ba7dec4bd2732
                               at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/mod.rs:66
   2:     0x55c3aa1fa86f - std::sys_common::backtrace::_print_fmt::hda61f46e822731b2
                               at src/libstd/sys_common/backtrace.rs:84
   3:     0x55c3aa1fa86f - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hfe37fa5de6572965
                               at src/libstd/sys_common/backtrace.rs:61
   4:     0x55c3aa1ef23c - core::fmt::write::h74887d18db27282c
                               at src/libcore/fmt/mod.rs:1025
   5:     0x55c3aa1f9d06 - std::io::Write::write_fmt::h6808f3d5eceed5e5
                               at src/libstd/io/mod.rs:1426
   6:     0x55c3aa1f992e - std::sys_common::backtrace::_print::hcc0fd4b3552039ef
                               at src/libstd/sys_common/backtrace.rs:65
   7:     0x55c3aa1f992e - std::sys_common::backtrace::print::h1c9c5c1c0505592d
                               at src/libstd/sys_common/backtrace.rs:50
   8:     0x55c3aa1f992e - std::panicking::default_hook::{{closure}}::hefb6085c1ab83a59
                               at src/libstd/panicking.rs:193
   9:     0x55c3aa1f90d3 - std::panicking::default_hook::h1b037d2bf0657ab3
                               at src/libstd/panicking.rs:210
  10:     0x55c3aa1f90d3 - std::panicking::rust_panic_with_hook::h787d7f532b084b9a
                               at src/libstd/panicking.rs:471
  11:     0x55c3aa1f8c4e - rust_begin_unwind
                               at src/libstd/panicking.rs:375
  12:     0x55c3aa1ed9fd - core::panicking::panic_fmt::h76b979c035808e69
                               at src/libcore/panicking.rs:84
  13:     0x55c3aa1ef7b6 - core::result::unwrap_failed::hca6a012bfa3eb903
                               at src/libcore/result.rs:1188
  14:     0x55c3aa1e9e9f - core::result::Result<T,E>::expect::hbb3cbfb104fec193
                               at /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libcore/result.rs:983
  15:     0x55c3aa1e9e9f - <crate>::main::h0dc740a6327e4770
                               at src/main.rs:63
  16:     0x55c3aa22ec73 - std::rt::lang_start::{{closure}}::hddbf673489d25cf9
                               at /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libstd/rt.rs:67
  17:     0x55c3aa1eae90 - main
  18:     0x7ff6ecb7a023 - __libc_start_main
  19:     0x55c3aa1e614e - _start
  20:                0x0 - <unknown>

The reason is "No protocol specified" (in ASCII). Will do some more troubleshooting later

Two things:

Yay, 88e1f0b3a35a7ca3c15efb5aaf4a4f22e6b1abd1 works. Before this commit, I would expect a useless ParseError instead, because a SetupFailed cannot be parsed as a Setup. When trying to test this against some X11 server, I never managed to make the server reject the connection.
This is a duplicate of #196. Right now, RustConnection never sends any authentication information. This is the empty Vecs here:
https://github.com/psychon/x11rb/blob/a1deb7e2940ce3c2c06650c7a03bddc15a250423/src/rust_connection/mod.rs#L45
This works for me, because according to /usr/bin/xhost, my X11 server just uses Unix socket magic to authenticate everything coming from my user account.

According to debian codesearch, the message comes from here: https://sources.debian.org/src/xorg-server/2:1.20.7-3/os/auth.c/?hl=222#L222
I'll close this since this is a duplicate, but I would be interested in hearing more. How did you "manage" to get the X11 server to reject the connection?
Today, I took a quick look at libXau. It seems more or less doable to reimplement this in Rust (but I do not understand this XDMsomething stuff). Can you run xauth list? Do not paste the output, does it say MIT-MAGIC-COOKIE-1? If so, I might be able to implement the necessary support on the weekend.

My application is a window manager and it crashes when I run startx with the given error message.
It either suddenly stopped working when I tried to test something (and continued to not work after I reverted), or I never actually compiled my program after I changed to RustConnection and it had never worked... (startx points directly to target/release/<application>, and I checked target/debug/ is empty)

Hm. I'm on debian testing. I just tried startx (starts my normal window manager) and inside of that session, examples/simple_window works without problems. xhost says that still everything from my user is allowed (and nothing else):
$ xhost
access control enabled, only authorized clients can connect
SI:localuser:psychon

Could it be that startx cleans up .Xauthority during shutdown? And that only while it is running, can some entries be found?
Anyway, my .Xauthority is empty, too (at least now, previously there was some content, but that must have been old, since deleting it didn't have any negative effects (so far)).
I also tried startx /path/to/simple_window and that works, too... :-/
Also, all my X servers are started with -nolisten tcp... I just started sudo X :2 manually, and that one does not have -nolisten tcp in its command line, but still does not listen on tcp. Sigh.
[A while later]
Yay! X -listen tcp :2 and then DISPLAY=:2 xterm& (so that the server does not reset when the last client disconnects) and DISPLAY=:2 xhost -INET:localhost (to remove the relevant entry from the access control list) works:
$ DISPLAY=<IP_ADDRESS>:2 cargo run --example simple_window --no-default-features --features vendor-xcb-proto                           rust_connection_thread:1
    Finished dev [unoptimized + debuginfo] target(s) in 0.00s
     Running `target/debug/examples/simple_window`
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: SetupFailed(SetupFailed { status: 0, protocol_major_version: 11, protocol_minor_version: 0, length: 6, reason: [78, 111, 32, 112, 114, 111, 116, 111, 99, 111, 108, 32, 115, 112, 101, 99, 105, 102, 105, 101, 100, 10] })', src/libcore/result.rs:1165:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This is the "No protocol specified" error message.

Oh, hey. The above is totally useless. I just managed to setup a server that rejects my connections, but instead I need a server that accepts connections when the right authentication data is provided.
Wikipedia explains more: https://en.wikipedia.org/wiki/X_Window_authorization
The (for me) relevent / eye opening part is.... gone. Anyway, I remember reading somewhere that I need to start my X11 server with -auth path-to-Xauthority-file. And I was looking for some way to do runtime configuration....

Okay, I figured out a working setup for testing this:
$ rm -f /tmp/file && xauth -f /tmp/file add :2 . 1234 && Xephyr -listen tcp -auth /tmp/file :2
$ DISPLAY=<IP_ADDRESS>:2 xterm
No protocol specified
xterm: Xt error: Can't open display: <IP_ADDRESS>:2
$ DISPLAY=<IP_ADDRESS>:2 XAUTHORITY=/tmp/file xterm
^C%


Two JIRAs around Paging and AMQP

These two JIRAs are related but I wanted to keep them separate as commits.
Both changes were part of the same testing.

If the few comments are being addressed (when makes sense) I'm ok with this, can you merge it your self?


Render to texture

Hi guys,
I want to create something like dynamic waves and need to generate the height map in a shader and store it in a render texture to be used later. I would rather not hack apart the framework to make this happen, if possible.
I have a terrifying feeling that the solution is really obvious and I'm just missing it.
Cheers

Hi. Is GVRRenderTexture what you are looking for? The gvr-vuforia sample app uses it.

I believe @roshanch was going to give a more specific answer.  We helped someone with this in a hackathon a couple months back.  If you just want to execute a bunch of opengl calls on your own rendertarget, then the flow would go something like this:
create a drawframelistener
in your drawframelistener
if this is your first frame, create your GVRRenderTexture (let's call that 'renderTexture')
query and save the currently bound FBO (let's call that 'oldFBO')
renderTexture->bind();
make opengl calls
glBindFramebuffer(oldFBO);
when doing 'make opengl calls', when changing any opengl state, you will probably want to query the current opengl state first, then restore it before exiting your drawframelistener
if you're looking to render a scene with a bunch of sceneobjects (as opposed to making your own gl calls) to a renderTexture, then we would need to expose a variant of renderCamera() up to the java level.

Thanks for that, I ended up using unity as time was a bit of a factor for the prototype.

@rsisaleh We made the whole thing more user-friendly. Also added a new demo app - gvr-rendertotexture, that shows how to do it.


Use the proper error message with caused exceptions

Type of changes

[x] Bug fix
[ ] New feature
[ ] Documentation / docstrings
[x] Tests
[ ] Other

Checklist

[x] I've run the latest black with default args on new code.
[x] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[x] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
When an exception is raised using "from", the chained exception goes into
cause, which results in a different message using Python's native traceback
handler. This patch properly replicates that error message.

Thanks!


update readme.md

AngularJS is in LTS mode
We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?

What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Fix/Feature: Docs have been added/updated
[ ] Fix/Feature: Tests have been added; existing tests pass

Other information:

Closing this PR as spam/invalid. It seems superfluous or not a meaningful, relevant change.
As it appears that you may have created this PR as part of your participation in Hacktoberfest, please review their note regarding quality before making additional PRs: https://hacktoberfest.digitalocean.com/details#quality


Add date (without time) type from redshift.

JIRA:
Overview:
Testing:
Roll Out:

[ ] Remember to deploy both s3-to-redshift and s3-to-redshift-fast

(Meatspace LGTM)


Update the integv2 README to match the latest changes

Description of changes:
README updates and adding a single-test option to the integv2 makefile.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2365 into main will increase coverage by 6.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2365      +/-   ##
==========================================
+ Coverage   81.29%   87.34%   +6.05%
==========================================
  Files         267      166     -101
  Lines       18294    14050    -4244
==========================================
- Hits        14872    12272    -2600
+ Misses       3422     1778    -1644


Tags

[ ] create a tag for a Docker image that can embed sources
[x] create multiple tags for Node.js 0.12.x/4.x/6.x

pm2 build step https://github.com/Unitech/pm2/issues/2320
multiple tags available via build automation mirrored to current branches


range_finder: parametrize range sensor quality hysteresis time

This will allow to adjust the hysteresis time based on the distance sensor performances.
For distance sensors that can't read high distances (i.e. >10m) waiting 1s or more before fusing the data might lead to hard landings during auto descends.

How low do you want to go? I'm wondering if the initial value of 1 second is arbitrary in the first place.
Another thing you could consider is adjusting it automatically, the EKF already carries the sensor metadata (min/max distance).
Wherever possible I'd like to try and avoid parameter bloat if we can get away with it.

The problem is that the quality of the sensor data does not correlate with its range. To solve @cmic0 's issue, we should lower the threshold given the short maximum distance, but there are also a lot of crappy range finders with short range that would need a longer hysteresis time. On the opposite side, there are also good range finder with a large max distance that don't require a large hysteresis.
So I think the other alternative to having a parameter for this in ekf2 is to move the check in the driver of each range finder, such that it is tuned for a specific sensor model.


feat: Add GTM data ingestion to wandbot

This PR adds GTM documentation and data ingestion pipeline to wandbot

Thanks @parambharat can you run 5 test questions about weave and launch that someone might as an an AE and post the results here?
Not super technical, more like “can it do X”, “I work in NLP pharma, what could I use it for” etc

@parambharat can you also include a refresh of all the other docs, examples etc too?

@parambharat do you think the system prompt should be tweaked to also incorporate a bit of a GTM tone?

Oh @parambharat can you also document which Artifact the raw text files are uploaded to?


Magic numbers in code

Hi @LimHyungTae,
Thanks for releasing the great work! I found that there are magic numbers in the code that can be effected the final extraction result as follow.

Could you please explain linearity?
https://github.com/LimHyungTae/patchwork/blob/93b493cb57d205dc3564229fd3f9d35977f39ecd/include/patchwork/patchwork.hpp#L460
Should I use a value larger than the sensor's mounting height?
https://github.com/LimHyungTae/patchwork/blob/93b493cb57d205dc3564229fd3f9d35977f39ecd/include/patchwork/patchwork.hpp#L525
What is the meaning of the size of the point cloud?
https://github.com/LimHyungTae/patchwork/blob/93b493cb57d205dc3564229fd3f9d35977f39ecd/include/patchwork/patchwork.hpp#L283

ping @LimHyungTae,

True:

If linearity is too large, it means that ground points are likely to be a single channel, which should be avoided when getting average height via ATAT
To reject some undesirable noisy points
Just for reserve mode to prevent inefficient memory copy & paste on the 0-th operation

Great. Thanks!


Call common function for bazel cleanup

Checklist before submitting

[ ] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Fixes # (issue).
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

A common comment for all the PRs - We should update the year in the copyright info of build.sh in all the PRs.

How come this commit shows Billy's name?


Fail e2e workflow if tests failed

Now that that we have basic test running, we want to fail the workflow if the tests failed. Without this  people assumes code changes are passed the tests.

Thanks for finding and fixing this issue.


PR: Migrate Files to the new API

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Migration of the explorer plugin to the new API
Issue(s) Resolved

Fixes #12195
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Steff456

Thanks @juanis2112 for your review. About your comments:

The state of the options "Show hidden files" and "Single click to open files" in the hamburger menu is not sync with the ones in the preferences dialog.

I fixed this last weekend.

After reseting spyder, by default the files opens in my user directory and when I click the "back" button it goes to the spyder directory. I'm not sure if this is desired since this was not really the previous directory that I opened. I think it might make sense to have it as it was in 4.x where the "back" arrow is deactivated by default when there has being no previous navigation.

Totally agree. Could you open am issue about that so we don't forget to fix it for Spyder 5? Thanks!

When the filename of some file is too long, the "date modified" column (Which is the one activated by default), moves a lot to the right and is not visible anymore without scrolling to the right

This is a very ugly behavior and I also agree we should fix it. Please open an issue for that too.

@steff456 @ccordoba12 after a quick check of the code this LGTM

Great! Thanks a lot for the review @dalthviz!

the only question I have is the change in the mainwindow regarding opening external files with the Mac application (the change from sys.platform == "darwin" to running_in_mac_app()), is that logic not needed for any instance of Spyder in Mac?

Nop, that is only necessary for our Mac app.


Image update automation: The key is read only

Hi everyone,
Is there a way to write a read/write key? Currently, I'm not able to use image update automation.
Thanks for the support,

Do you have this section in your config, from the GitHub docs:
resource "github_repository_deploy_key" "main" {
  title      = "staging-cluster"
  repository = github_repository.main.name
  key        = tls_private_key.main.public_key_openssh
  read_only  = true
}

Looks like you can change it there

Ideed, thank you @yebyen , that worked :)


[LiveComponent] Empty form data

Hi,
I am trying to make a Todo list with the live components.
I am using the form way described in the Live Component documentation.
The AJAX query runs when I click on the action button but it sends an empty text field.

Here is my Task entity: https://github.com/sandoche/Symfony-ux-live-component-todo-list/blob/main/src/Entity/Task.php
The create task component: https://github.com/sandoche/Symfony-ux-live-component-todo-list/blob/main/src/Components/CreateTaskForm.php
The related view: https://github.com/sandoche/Symfony-ux-live-component-todo-list/blob/main/templates/components/create_task_form.html.twig

The full repo: https://github.com/sandoche/Symfony-ux-live-component-todo-list/
As you can see below the task['test'] is empty even though I filled the form:

Also it's not well documented I had to use dehydrateWith maybe I haven't done correctly.
I am not very sure if it's a bug or if I did something wrong.

Hey @sandoche!
Excellent reproducer! The fix you need is inside of your component's template - create_task_form.html.twig:
<div
	{{ init_live_component(this) }}
+	data-action="change->live#update"
>

When you trigger a "live action" (like you're doing when the form submits), the component "sends" all the data from the component. Buuuut, this does not blindly submit, for example, all of the fields inside the form. The flow needs to go like this:

The user types into the input
Something (this is the part that was missing) like a change event or input event uses the text in this box to update that piece of data inside the component.
You perform the action (e.g. submit the form).

I think that your mistake will likely be fairly common... but I'm not sure yet what we could do to be more clear and avoid it.

Also it's not well documented I had to use dehydrateWith maybe I haven't done correctly.

You did a good job finding this :). What I've been doing so far - to avoid the problem of a non-persisted object from not being "dehydratable" - is to pass in null to the template... but it's not super smooth yet. To see what I'm talking about, you would:
A) Remove your dehydrateWith
B) Pass null as the task variable when rendering this component, something like:
{{ component('create_task_form', {
	task: this.task.id ? this.task : null,
	form: this.form
}) }}

This can be documented better - I'll open a PR!
Let me know what you think - and thanks for testing!

It does work thanks a lot for your time @weaverryan! One question what is the dehydrateWith for? in which case should it be used?

Also @weaverryan I have to other issues linked to this one:

When I add data-poll to the todo_list.html.twig
I get the following error:

Impossible to access an attribute ("id") on a null variable.

I managed to fix it using a workaround:
<div {{ init_live_component(this) }} data-poll>
	{% set task = null %}
	{{ component('create_task_form', {
        task: task,
        form: this.form
    }) }}

	{% for task in this.tasks %}
		<br>{{ task.text }}
	{% endfor %}
</div>

My second issue is that I don't find a way to update the parent view once the form is submited.
Basically thanks to your fix once the child form is submitted, the task is added to the database. But the parent is not reloading. I am not sure how to achieve this. I am using poll as a workaround for now.

Impossible to access an attribute ("id") on a null variable.

Change your code to:
{{ component('create_task_form', {
-	task: this.task.id ? this.task : null,
+	task: this.task ? this.task.id : null,
	form: this.form
}) }}


[Gardening] Mark a test as timing out on OS X.

kernel/test/baseline_type_propagation_test was flakily timing out on the
OS X bots.
See #28714

Replace this (or change it to) mark the test as slow.

Done.


Unverified HTTPS request is being made?

Not sure where to raise this issue.  I have searched through all the autopkg issues and have found similar, but not the same.
We have two repositories: one uses smb, the other afp. This is a new installation of autopkg, attempted on both 10.9 and 10.10 machines with the same outcome.  JSS is version 9.65.  Authentication with JSS and Repos is good.
When running recipes all goes well until:
26/02/2015 3:28:13.526 pm AutoPkgr[726]: (FULL AUTOPKG TRACEBACK)
  File "/usr/local/bin/autopkg", line 1469, in <module>
    sys.exit(main(sys.argv))
  File "/usr/local/bin/autopkg", line 1463, in main
    exit(subcommands[verb]['function'](argv))
  File "/usr/local/bin/autopkg", line 1287, in run_recipes
    autopackager.process(recipe)
  File "/Library/AutoPkg/autopkglib/__init__.py", line 466, in process
    self.env = processor.process()
  File "/Library/AutoPkg/autopkglib/__init__.py", line 295, in process
    self.main()
  File "/Library/AutoPkg/autopkglib/JSSImporter.py", line 674, in main
    self.handle_icon()
  File "/Library/AutoPkg/autopkglib/JSSImporter.py", line 559, in handle_icon
    icon.save()
  File "/Library/Python/2.7/site-packages/python_jss-0.5.5-py2.7.egg/jss/jss.py", line 1181, in save
    self.jss._error_handler(JSSPostError, response)
  File "/Library/Python/2.7/site-packages/python_jss-0.5.5-py2.7.egg/jss/jss.py", line 174, in _error_handler
    raise exception
jss.exceptions.JSSPostError: JSS Error. Response Code: 409	Response" Conflict
Unable to complete file upload.  File contents does not match file type.

Followed by:
26/02/2015 3:28:13.527 pm AutoPkgr[726]: [DEBUG] Error [1] Error running recipes
 /Library/Python/2.7/site-packages/python_jss-0.5.5-py2.7.egg/jss/contrib/requests/packages/urllib3/connectionpool.py:734: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html
  InsecureRequestWarning)

This repeats many times ending with :
A Python exception occurred during the execution of autopkg, see the console log for more details.
[ERROR] Unable to complete file upload.  File contents does not match file type.

That's where is all comes to a stop.  All ideas welcomed.

There are a couple of issues going on here:

The icon is failing to upload.
urllib3 is complaining that you're performing insecure web requests.

One of these is a problem, the other is just nagging.
More specifically, urllib3 and requests, the python modules which handle all of the API requests are complaining that you're not using HTTPS for your communications. Of course this requires a properly set up JSS with a valid certificate, which you may not have at the moment. So you've (I'm assuming) set JSS_VERIFY_SSL to false in your AutoPkg(r) preferences.
To suppress the nagging you need to add another key: JSS_SUPPRESS_WARNINGS = true. This may or may not be available in the current autopkgr version, so you may have to set it yourself, i.e.
defaults write com.github.autopkg JSS_SUPPRESS_WARNINGS -bool true
As for the icon uploading issue, see #34 also. I've never seen the JSS report this error before, and I wonder if it is an issue with the new JSS version 9.65 (or > 9.6, which is what we're using at the moment).
Some ideas:

Icons are only ever uploaded once. So if you've never run a recipe that uploads an icon, this is definitely what's going on. If you've already successfully uploaded this icon and it's failing, something else is going on.
I imagine you're using the recipes in my jss-recipes repo. Many people have been using these successfully, so I feel pretty confident that the files are indeed PNG files! Again, perhaps JAMF has changed the value for the file type or something. I'll need to update our testing server to fool around with this.

In the meantime, if you're wanting to just get recipes running, I suspect you could override the recipes to have a blank ICON value. This will skip icon upload and hopefully move on to the rest of the recipe.
Let me know how it goes, and I'll do some research on my end.

Wanted to keep you in the loop: JSS v9.65 is rejecting file uploads for me too. I just upgraded a test server and can see the same problems. I have submitted a support request with JAMF: Hopefully it will be something simple!

As predicted, suppressing those warnings killed the nagging.
Standing by for JAMF's response to the icon issue.

@stevehillnz , please manually update python-jss (or just reinstall JSSImporter, since it will run the manual shell command below) with
easy_install -U python-jss

and you should be able to upload icons again (which is the problem here).
When I get a chance, I'll also update the JSSImporter.
And when JAMF figures out the regression, I'll fix python-jss back up.


Design Meeting Notes, 7/28/2017

f# Readonly on Exports from Namespaces (#16720)
namespace N {
    export class C { }
}

N.C = class {};

Namespaces have had this feature for a while now

Breaking changes for something that's functioned that way this long seems strange.

Declined

Readonly & Variance

One thing that comes up quite a bit is strict variance.

If we enabled stricter variance, that would imply that Array becomes invariant.

To get a covariant array, you need a ReadonlyArray.
This means everything gets two declarations - T and ReadonlyT

Strict variance is easy to enable, but would be hard to make easy to use.

This leads us to start thinking about how to quickly make a readonly version of a type.

We've had an experimental type operator called readonly

Much like keyof T, you just write readonly T.

Like the Readonly mapped type, it makes all properties readonly as well.

However, the Readonly<T> mapped type doesn't eliminate mutating methods at all.

This means we needed to add a way to indicate that a method doesn't mutate its object.

Created the this: readonly syntax.

Example:
class Foo {
    name: string;
    getName(this: readonly): string;
    setName(value: string): void;
}

// This:
type ReadonlyFoo = readonly Foo;

// ... is equivalent to this:
type ReadonlyFoo = {
    readonly name: string;
    readonly getName(this: readonly): string;
}

What about deep readonly?

In other words, does readonly Foo[] give you a readonly Array<readonly Foo>?
Have thus far decided no.

Could create an immutable type operator

Q: Couldn't you implement that with mapped types?

A: Potentially

May be a bit confusing since state could be captured outside of current object

In --strictReadonly mode, this readonly operator would work as described above.

readonly T not assignable to T.
readonly props would not be assignable to mutable props.
readonly T removes mutating methods

Outside of strictReadonly, readonly T is just Readonly<T>

All of this means that library authors would need to enable readonly mode.

Would TypeScript be able to infer whether a method is readonly or not?

Kind of tricky, methods transitively call each other.

How bad are strict variance modes without this?

Need a super constraint for generics - otherwise many types stay invariant by virtue of taking a T as an input position.

Will people know how to use this: readonly?

Seems like people will always need to be mindful of this when they write .d.ts files.
How will we generate this for the DOM if the metadata isn't present? What about readonly HTMLElement?

How do this: readonly parameters work with overloads?

Currently, if any overloads are not declared with this: readonly, the property is eliminated.
That's not going to play well with libraries.

Example: Knockout.

Since there's no issues linked to 'Readonly & Variance' section (you may want to link #1394, #10717), I'll leave a few comments here.
I'm wondering why a connection mentioned between variance and readability in that way. My understanding is that a type may be co- or contravariant on some other type it uses. Like a function is covariant on its parameter argument types and contravariant on return type. In case of array, it may be covariant to type of its elements, but it does not imply that it must be read-only.
I claim that in some cases, it is not obvious or even impossible to be express variance with readonly T. Consider:
interface Transformer<I, O> {
  transform(value: I): O;
  transformArray(values: I[]): O[];
}

What would readonly Transformer<I, O> mean? How is that useful for variance? More importantly is that Transformer is covariant on I and contravariant on O.
In #10717 I was proposing both co- and contra- varainces on generic types for both declaration and use sites:
interface Array<T> {
  [index: number]: T;
  push(value: T): void;
  pop(): T;
}
type ReadonlyArray<T> = Array<out T>;
// is equivalent to this
interface ReadonlyArray<T> {
  readonly [index: number]: T;
  // push(value: T): void;
  pop(): T;
}
type WriteonlyArray<T> = Array<in T>;
// is equivalent to this
interface ReadonlyArray<T> {
  writeonly [index: number]: T; // no such syntax
  push(value: T): void;
  // pop(): T;
}

@Igorbek I've been thinking more about use-site variance recently as well. @ahejlsberg will be able to give more direct context, but I'll try answering your questions.
In general, the connection is that the readonly modifier removes every single method that isn't marked as this: readonly, which removes a great deal of methods that tend to make types invariant. While there's sometimes cases where generics in an input position don't necessarily modify contents of the containing type, this seems to be the case for a decent number of APIs.
In your Transformer example, you've made a good point that readonly can't really change the fact that in a world with stricter variance, the type would be invariant on I; (since Array is invariant as well) but I believe the intent is that for many cases, the readonly modifier would make it significantly easier to manufacture a type that acts covariantly on its type parameters, which comes up quite a bit. As an example, look at how we've had to create ReadonlyArray as a restricted counterpart for Array. You'd presumably want a ReadonlySet as well. Instead of declaring everything twice, we're exploring a more generalized mechanism.
To be clear, we are still experimenting with these ideas. It's not even clear whether stricter variance is something we're committed to.

By the way, I want to point out that for many containers, a Foo<out T> is not necessarily read-only (imagine a method named clear()).
So neither readonly-ing a Foo<T> nor passing an upper-bounded existential type argument (Foo<out T>) fully subsumes the other.

Just 🚲:house:ing, but while I know TypeScript has been sticking to any established JavaScript precedents, wherever available, when adopting type level syntax (extends/implements), C#'s in and out really are so much more expressive and easier to visually parse than <? super T> and <? extends T>, so if explicit variance annotations are ever added I think it might be nice to deviate and use in and out as @Igorbek does in his code examples above.

I propose that we continue the discussion of "Readonly & Variance" in #18770.


integration of plainsound hexatone isomorphic touch controller interface for scales

https://www.plainsound.org/hex
autoload scala file, select a logical layout, color scheme automatically
current codebase would need to be cleaned up and updated in typescript / vue
longer term goal: communicate with lumatone (send colors and layout automatically as MIDI sysex data) to immediately match desired mapping of MIDI / input channels to scale....

If by integration you mean having a hexagonal isomorphic keyboard inside Scale Workshop here are my thoughts:

Hexatone is written is Preact so pretty much everything would have to be re-implemented in Vue for full integration.
I highly recommend using SVG instead of Canvas for drawing the grid. You should be able to achieve a similar look but with better responsiveness when it comes to different screen sizes.
Utilities like extended Euclidean algorithm can be found in xen-dev-utils.
xen-midi could be extended to handle MTS and lumatone communication.
I like how Hexatone separates interval values, degrees, names and colors. We should do that for Scale Workshop 3.
The sample synth should probably be it's own repository under xenharmonic-devs and decoupled from the hexes.
The learning curve is steep. I suggest we start by implementing a hexagonal alternative to the Virtual Keyboard in SW 2. The lessons learned will inform how we want to approach the integration.


Question about the training parameters

Hi, thank you for sharing this great work.
I have a question about training parameters.
For the depth generation, the authors expand UNet input and output channels.
For the depth-guided multi-view attention, the authors add an additional depth-guided attention module.
So, are the trainable parameters only for the depth-guided attention modules or zero123 pre-trained + depth-guided attention modules?
Thank you.

Hello,
The trainable parameters are zero123 pre-trained + depth-guided attention modules because of the extra input and output channel required from the zero123 pre-trained weights. However we do another stage of finetuning where we freeze zero123 and only train the attention module so we can fit more images in the memory.


fix button constraints

HI, I'm an engineer in Japan. Thanks nice View Controller App.
I fixed upper left button constraints. Please check it. Thanks.

Changes Unknown when pulling 5a58403062e58fd103f8fa77ed324ce3fa83f6d6 on senseiphoneX:develop into ** on gelemias:develop**.

@senseiphoneX  Thank you for your contribution 👍


Fix workflow issue

Trying to solve the #193
It boils down to the workflow definition can use parameter in the same style as ARM templates, and if you use the same name for the workflow parameters as the ARM parameter, the current test fails.

Hi @bmoore-msft
Looking at the output from the checks / tests, it seems that you have some pester issues with the unit tests that should fail for the ResourceIds-should-not-contain

thx - I added a PR for the resourceId test fixes...
re: this test - it's not clear to me what the test is checking?  If I have this syntax in my template:
@parameter('testUri')
My understanding is that is referencing the workflow parameter and not the template parameter.
And then of course the template syntax:
[ ... parameters('testUri') ... ]
Would count as a reference to the template parameter.
If I have the right, I think we need more unit tests around it... and not sure I understand the edition of the @ in the regex - but let's make sure I understand this right first ;)

I'll see if I can make it clear.
The ARM template for the unit test: https://github.com/Splaxi/arm-ttk/blob/fix-workflow-issue/unit-tests/Parameters-Must-Be-Referenced/Pass/Workflow-Using-Same-Named-Parameters.json
It has an ARM template parameter called testUri:
https://github.com/Splaxi/arm-ttk/blob/6276251452a454a2e4e9e9f70a7812cd9b944ae6/unit-tests/Parameters-Must-Be-Referenced/Pass/Workflow-Using-Same-Named-Parameters.json#L11-L17

The workflow definition also has a parameter section, where is has a parameter the is named 100% the same:
https://github.com/Splaxi/arm-ttk/blob/6276251452a454a2e4e9e9f70a7812cd9b944ae6/unit-tests/Parameters-Must-Be-Referenced/Pass/Workflow-Using-Same-Named-Parameters.json#L40-L45

When the current Test-AzTemplate runs the Parameters-Property-Must-Exist.test.ps1 test case, the following is happening:

It parses all ARM parameters, and loops/iterates with every single one of them with the regex:
https://github.com/Splaxi/arm-ttk/blob/6276251452a454a2e4e9e9f70a7812cd9b944ae6/arm-ttk/testcases/deploymentTemplate/Parameters-Must-Be-Referenced.test.ps1#L26-L39

What this will yield, is 3 matches:

1 match for the logicAppName parameter

Groups   : {0}
Success  : True
Name     : 0
Captures : {0}
Index    : 736
Length   : 26
Value    : parameters('logicAppName')

2 matches for the testUri parameter

Groups   : {0}
Success  : True
Name     : 0
Captures : {0}
Index    : 1270
Length   : 21
Value    : parameters('testUri')

and
Groups   : {0}
Success  : True
Name     : 0
Captures : {0}
Index    : 1947
Length   : 21
Value    : parameters('testUri')

The match for index 1270 is:
https://github.com/Splaxi/arm-ttk/blob/6276251452a454a2e4e9e9f70a7812cd9b944ae6/unit-tests/Parameters-Must-Be-Referenced/Pass/Workflow-Using-Same-Named-Parameters.json#L40-L45

The match for index 1947 is:
https://github.com/Splaxi/arm-ttk/blob/6276251452a454a2e4e9e9f70a7812cd9b944ae6/unit-tests/Parameters-Must-Be-Referenced/Pass/Workflow-Using-Same-Named-Parameters.json#L58-L61

For each match found, we will run the next $exprStrOrQuote regex, which will look from right to left, for either [ or "
https://github.com/Splaxi/arm-ttk/blob/6276251452a454a2e4e9e9f70a7812cd9b944ae6/arm-ttk/testcases/deploymentTemplate/Parameters-Must-Be-Referenced.test.ps1#L19

So for the match at index 1270 that is not a problem, because the first character we encounter is [, which is what we want. The result from the $exprStrOrQuote is:
("defaultValue": "[parameters('testUri')]")
Groups   : {0}
Success  : True
Name     : 0
Captures : {0}
Index    : 1269
Length   : 1
Value    : [

For the match at index 1947, the story is different. The reason for that is that inside the workflow definition (Logic App - "language"/syntax ), we don't use the [] characters around parameters when we reference them (the internal ones, the ones that are declared inside the resource). So the result is:
("uri": "@parameters('testUri')")
Groups   : {0}
Success  : True
Name     : 0
Captures : {0}
Index    : 1945
Length   : 1
Value    : "

That yields the failed unit tests, because we should have a [ character and not a " character.
This is were the @ character comes into play. If our regex is looking for 3 characters [ " @, the last match will look like this:
("uri": "@parameters('testUri')")
Groups   : {0}
Success  : True
Name     : 0
Captures : {0}
Index    : 1946
Length   : 1
Value    : @

So stepping back a bit. Either we need to rewrite the big search regex that initially finds the match on index 1947, because it shouldn't be found in the first place. How to do that would be something with negative-lookback magic. Or we use this suggested solution (some would argue hack), were we recognize that we have a special case with workflow, that requires a special lookup regex for the validation.
I hope it makes things a bit more clear 🤞

It does help... To level set, the @parameters() syntax is only used for the logic workflow, not for the ARM template.  So that sytnax should be ignored or iow, not treated as a reference to the param.  So we don't actually what this change: https://github.com/Azure/arm-ttk/pull/212/files#diff-b6bd0934fae1999159cd89b86d3c57d9fd0b467be055e72d5bfd7352ed18294bR19
The problem seems to be when I find a not reference, we throw, even though we may also have a reference.  So the problem is more nefarious than I thought.  For example, this throws an error and it shouldn't.
{
  "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
  "contentVersion": "<IP_ADDRESS>",
  "parameters": {
    "testUri": {
      "type": "string"
    }
  },
  "variables": {
    "ref": "[parameters('testUri')]",
    "notRef": "parameters('testUri')"
  },
  "resources": []
}

This is also a bug in the variable test (I'm guessing) but that pattern is not common - you'd have to have a valid reference and a string match for invalid before it triggers, which is not common in the wild and usually indicative of something you do want to pay attention to... except in the case of a logic app.
Not immediately obvious to me how to fix, but I think we understand the problem better (or I do ;))

Let me ask it like this.
Should one reference for any given parameter be enough to not fail or shall/must all references for a given parameter be validated? The latter is what your current regex is enforcing.
Just remember that @parameter() can be anything like @float(parameter('')) and "dsafasdfasf@{string(float(parameter('')))}dfasdfaf"
It seems that the current regex is greedy on purpose, to make sure we catch all "maybe" references for a given parameter, to ensure that it is inside an expression. If we move away from that, by changing the regex (somehow), we would fix the issue - but might hit more edge cases were we don't catch all references for the parameter that we would want to.
So I would argue that this change is an improvement, worthwhile to implement, because it solves the edge case of workflow / logicapps, and lets us keep the remaining greedy logic to find all other references of parameters from the ARM template. And maybe someday we find an even better solution, but for now we can support ARM templates, with workflow / logicapps, where the inner parameter is named exactly the same.
But I fully understand if you want to close this PR - it is your call anyways. I'm just trying to help.

Ok, I think I see the disconnect.  The syntax of @parameters() or @something(parameters() should not be counted as a reference of an ARM template parameter.  It is a reference of a parameter in a logicApp workflow, but that's not what we're testing.  So adding @ to the regex is not the correct fix.
The problem described in #193 is that we throw on any invalid reference regardless of whether there is also a valid reference.  As long as there is at least one valid reference, the test should pass.  Also, it's not the regex that's causing that it's the loop in the references.
Now there is a discussion around whether we should flag any invalid reference, which has merit because it's an odd thing to do - and that's what caused the problem here, just not the way the test was designed.  If we were to do that, we'd have to special case scenarios like this...  because I would need to "discard" references that were not from the ARM part of the template, but are not invalid.
So I think we should close this and open a new issue now that there's a better understanding of #193


Access is Denied message when converting Ubuntu 18.04 to use WSL2

I'm receiving an Access is Denied message trying to convert my Ubuntu 18.04 environment to use the new WSL2. I was able to successfully convert a brand new 16.04 instance, but can't seem to convert my main environment.
PS C:\WINDOWS\system32> wsl --set-version Ubuntu-18.04 2
Conversion in progress, this may take a few minutes...
For information on key differences with WSL 2 please visit https://aka.ms/wsl2
Access is denied.

Let me know what logs would be required, since they aren't inside of ubuntu per say, just in Powershell where I'm attempting the conversion.

Could you collect the detailed logs for us and post them here? Instructions on how to do so can be found here. Thank you!

Hello, this is my response on Issue #6967:
Hi Stefan, thank you for your response. Interestingly, when I run this command from the Windows Terminal Power Shell instance, I see my Ubuntu instances and they claim to be version 2 WSL.

However, when I run the same commands from Windows PowerShell (as admin), I get an Access denied message similar to what is shown in Docker for Windows.

Do you think resolving this WSL issue will also resolve the problem where I am unable to switch back from windows containers to linux containers?
Also, my goal is to use WSL for development environment on a docker project which uses docker-compose. I am behind a corporate proxy which seems to have some impact.


doc: add a link to auth setup guide

Just an idea, how about issuing an instruction when GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET are not set? I think It reduces the feeling of emptyness after initial setup, and it will prevent users from getting lost in both the local environment and the Deno Deploy environment.
If these environment variables are not required, I think this PR is not appropriate and should be closed.
Feel free to rewrite the text if you like this idea.

I'm a little worried about seeing the environment variables only at startup, but I think Deploy probably restarted the instance after rewriting the environment variables. If Deno Deploy behaves strangely, please revert the last commit

Actually, doing this check at startup is a better idea. Nice!


[General UX] Users are having to hard refresh due to caching

Steps to reproduce the problem
When we release new features, users oftentimes report that they don't see the updates. It's only after clearing their cache or doing a hard refresh, that they see updates to the Textbook.
Not sure why this is the case, but it's not typical/ideal for our UX — I can't think of any other web app that I use, where I have to do hard refreshing, to get the latest update.
What is the current behavior?
Sometimes, users don't see our app updates unless they do a hard refresh or they clear their cache
What is the expected behavior?

Updates should automatically apply and appear
or, could there be an update experience? 🤷♂

This bug was also present in a call with a Professor. It's pretty easy to replicate whenever we deploy something

This repository is no longer maintained. It has been superseded by IBM Quantum Learning.


Error creating virbr when having 2 networks

Trying to create a environment with 2 Networks, 2 VMs with 2 NICs each connected to the respective networks.
This same environment, but with only 1 network doesn't give any problem.
System Information
Linux distribution
opensuse Leap 15.0
Terraform version
Terraform v0.11.13
+ provider.libvirt (unversioned)

Provider and libvirt versions
Compiled against library: libvirt 4.0.0
Using library: libvirt 4.0.0
Running hypervisor: QEMU 2.11.2
Running against daemon: 4.0.0

If that gives you "was not built correctly", get the Git commit hash from your local provider repository:
0.5.0+git.1542698041.34c84ded-lp150.1.1

Checklist

[ ] Is your issue/contribution related with enabling some setting/option exposed by libvirt that the plugin does not yet support, or requires changing/extending the provider terraform schema?

[ ] Make sure you explain why this option is important to you, why it should be important to everyone. Describe your use-case with detail and provide examples where possible.
[ ] If it is a very special case, consider using the XSLT support in the provider to tweak the definition instead of opening an issue
[ ] Maintainers do not have expertise in every libvirt setting, so please, describe the feature and how it is used. Link to the appropriate documentation

[X] Is it a bug or something that does not work as expected? Please make sure you fill the version information below:

Description of Issue/Question
Setup
provider "libvirt" {
     uri = "qemu:///system"
}

resource "libvirt_volume" "myvdisk" {
  name = "my-vdisk-${count.index}.qcow2"
  pool = "default"
  count = 2
  source = "/var/lib/libvirt/images/my_image.qcow2"
  format = "qcow2"
}

resource "libvirt_network" "my_net1" {
   name = "my-net-1"
   addresses = ["<IP_ADDRESS>/24"]
   dhcp {
        enabled = true
   }
}

resource "libvirt_network" "my_net2" {
   name = "my-net-2"
   addresses = ["<IP_ADDRESS>/24"]
   dhcp {
        enabled = true
   }
}

resource "libvirt_domain" "domain-sle" {
  name = "test-vm-${count.index}"
  memory = "1024"
  vcpu = 1
  count = 2

  network_interface {
    network_id = "${libvirt_network.my_net1.id}"
    wait_for_lease = true
  }

  network_interface {
    network_id = "${libvirt_network.my_net2.id}"
    wait_for_lease = true
  }

  disk {
   volume_id = "${libvirt_volume.myvdisk.*.id[count.index]}"
  }

  console {
      type        = "pty"
      target_type = "virtio"
      target_port = "1"
  }
}

Steps to Reproduce Issue
+ terraform init

Initializing provider plugins...

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

+ ip a
<removed eth0 info>
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever

+ terraform apply -auto-approve
libvirt_volume.myvdisk[1]: Creating...
  format: "" => "qcow2"
  name:   "" => "my-vdisk-1.qcow2"
  pool:   "" => "default"
  size:   "" => "<computed>"
  source: "" => "/var/lib/libvirt/images/my_image.qcow2"
libvirt_volume.myvdisk[0]: Creating...
  format: "" => "qcow2"
  name:   "" => "my-vdisk-0.qcow2"
  pool:   "" => "default"
  size:   "" => "<computed>"
  source: "" => "/var/lib/libvirt/images/my_image.qcow2"
libvirt_network.my_net2: Creating...
  addresses.#:    "" => "1"
  addresses.0:    "" => "<IP_ADDRESS>/24"
  bridge:         "" => "<computed>"
  dhcp.#:         "" => "1"
  dhcp.0.enabled: "" => "true"
  mode:           "" => "nat"
  name:           "" => "my-net-2"
libvirt_network.my_net1: Creating...
  addresses.#:    "" => "1"
  addresses.0:    "" => "<IP_ADDRESS>/24"
  bridge:         "" => "<computed>"
  dhcp.#:         "" => "1"
  dhcp.0.enabled: "" => "true"
  mode:           "" => "nat"
  name:           "" => "my-net-1"
libvirt_volume.myvdisk[1]: Creation complete after 4s (ID: /var/lib/libvirt/images/my-vdisk-1.qcow2)
libvirt_network.my_net2: Creation complete after 5s (ID: fb13ec53-1849-4e5b-ac77-5c4730213abe)
libvirt_volume.myvdisk[0]: Creation complete after 9s (ID: /var/lib/libvirt/images/my-vdisk-0.qcow2)

Error: Error applying plan:

1 error(s) occurred:

* libvirt_network.my_net1: 1 error(s) occurred:

* libvirt_network.my_net1: Error clearing libvirt network: virError(Code=38, Domain=0, Message='error creating bridge interface virbr1: File exists')

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

+ ip a
<removed eth0 info>
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
439: virbr1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default qlen 1000
    link/ether 52:54:00:23:c5:46 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global virbr1
       valid_lft forever preferred_lft forever
440: virbr1-nic: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast master virbr1 state DOWN group default qlen 1000
    link/ether 52:54:00:23:c5:46 brd ff:ff:ff:ff:ff:ff

This can be solved by adding  bridge = "my-bridge-1"  in the network resource. I guess the expected behavior is that he framework calculates the bridge names automatically.

There is a race condition between multiple network resources. Another workaround is to use depends_on between resources.
I believe the issue is with the code looking up next available bridge name, and multiple resources fetch the same bridge name in parallel.
Is there any proffered method to implement the locking mechanism? I can spend some time to try to fix this, but don't want to waste my time if there is already a standard way of implementing locking for providers?

@p0tr3c https://github.com/dmacvicar/terraform-provider-libvirt/blob/c573bc15f8db231415b150d295e0063465e96735/libvirt/resource_libvirt_pool.go#L90
https://github.com/dmacvicar/terraform-provider-libvirt/blob/b7dab08a9194e388a7f043a1ab7fe60d241b50e5/libvirt/config.go#L17


Fixed bad ruleset merge

The ruleset refactor and merge upwards discarded all the differences in the rulesets between 2.15 and 2.16. This PR fixes this.

// cc @SpacePossum

Thanks, there were/are more issues with the sets and the tests, I've fixed a bunch, lets see what still needs to be done by looking @ Travis on the branches

Looks good now.

thanks, seems all is fixed :+1:

@SpacePossum This PR is still needed to make that one remaining change?


Updating amLocal, see issue #122

This should fix issue #122. See my last comment.

Thanks!
That'd be a breaking change. How about adding a amFromUtc pipe that will call moment.utc() and then you will be able to compose it with amLocal?
e.g.
{someDate | amFromUtc || amLocal }}


Builder image name missing the organization configuration

Version: Camel-k main branch (2.x)
When installing Camel-k with a defined organization id/name with build strategy pod the builder image full name does not contains the organization id/name. I think it should (like with the kit image):
REPOSITORY                                               TAG               IMAGE ID       CREATED          SIZE
apache/camel-k                                           2.0.0-SNAPSHOT    abda4a06c8c4   15 minutes ago   637MB
<IP_ADDRESS>/myorg/camel-k-kit-cihsu2p5tpl20drnif60   <none>            a18953b17581   2 weeks ago      516MB
<IP_ADDRESS>/camel-k-runtime-quarkus-builder             2.16.0-snapshot   0a3d865dd0dc   2 months ago     1.08GB

The command used to install is:
kamel install --build-strategy pod --organization  myorg

I don't think the org should apply to the dynamic image builder. IMO we need the builder to be as much generic as possible and reused if we have several IntegrationPlatforms (hence, several organizations).

What will happen if we have non-compatible registry configurations (example with auth) in different IntegrationPlatforms ? Do we rebuild the builder image ?

What will happen if we have non-compatible registry configurations (example with auth) in different IntegrationPlatforms ? Do we generate a another builder image ?

Good point. In general we need to revisit the entire concept of the dynamic builder, which is something that may be just temporary. If we evaluate for now it requires some enhancement like the one you're proposing, probably it makes sense to do it. Thanks.

Trying to use a private registry we're getting some auth problems:
      message: 'HEAD https://index.docker.io/v2/library/camel-k-runtime-quarkus-builder/manifests/2.16.0-snapshot:
        unexpected status code 401 Unauthorized (HEAD responses have no body, use
        GET for details)'


Provide dark theme

Currently, the Matrix Public Archive only supports a light theme.
Hydrogen already supports a dark theme. It would be nice if the archive would provide an option with auto, light, dark too.

I'd be tempted to only support auto light/dark theme to avoid the flash of light theme on every page-load since we would have to read the preference out of local storage. Or maybe there is a better standard way people do these things?


[$500] Login - Two error messages appear simultaneously

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.8-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Open the app
Enter a random incorrect phone number (I use<PHONE_NUMBER>)
Tap Continue
Notice that an error message appears (The provided phone number belongs to a landline or VoIP, please use your email address instead)
Delete latest digit

Expected Result:
Only one error message displayed
Actual Result:
Two error messages appear simultaneously for a while
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/6233e844-2a8f-4ab3-b271-e7a53e5ad61a

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017dead7572ed3bc76
Upwork Job ID:<PHONE_NUMBER>152152064
Last Price Increase: 2023-12-06

Proposal
Please re-state the problem that we are trying to solve in this issue.
Login - Two error messages appear simultaneously
What is the root cause of that problem?
The main problem is that we use 2 fields for errors
https://github.com/Expensify/App/blob/bbe73efdfab056d5ab6d864941fc3da44ec1c084/src/pages/signin/LoginForm/BaseLoginForm.js#L272
https://github.com/Expensify/App/blob/bbe73efdfab056d5ab6d864941fc3da44ec1c084/src/pages/signin/LoginForm/BaseLoginForm.js#L295
What changes do you think we should make in order to solve the problem?
I think the best way to fix this is
Transfer the logic of one error message to another
So that the error display uses only one component
What alternative solutions did you explore? (Optional)
NA

Proposal
Please re-state the problem that we are trying to solve in this issue.
Two error messages appear simultaneously for a short time when we edit the phone/email input field after an unsuccessful signin attempt using invalid phone/email.
What is the root cause of that problem?
Upon failed sign-in attempt using invalid phone/email, the server error text gets displayed. Now, on editing the phone/email input field, we set the login variable and also perform validation here. However, this is done even before the session account messages are cleared here. As the input sanity check occurs first with an error, this gets rendered even before the session error messages are cleared and rendered. This is the root cause of the problem
What changes do you think we should make in order to solve the problem?
We can change the order and bring Session.clearAccountMessages first to solve this problem like this:
            if (props.account.errors || props.account.message) {
                Session.clearAccountMessages();
            }

            setLogin(text);
            if (firstBlurred.current) {
                console.log("Validate OnTextInput");
                validate(text);
            }

We may also want to set the input and validate after account closure message here so that both the messages are not shown for a short while.
What alternative solutions did you explore? (Optional)

@cubuspl42 what do you think about the proposals above?

From the provided proposals, I find the one by @ZhenjaHorbach the most convincing
C+ reviewed 🎀 👀 🎀

@cubuspl42 I thought the same before finding https://github.com/Expensify/App/pull/14627 – the selected proposal is basically straight reverting that PR. Maybe it's worth asking the author of that PR whether it's still relevant to split the server & form errors?

You're right; I missed this. It's important. I have to reconsider.

After reconsideration, I must agree with @paultsimura that the proposal by @ZhenjaHorbach directly conflicts with a direction established by the PR https://github.com/Expensify/App/pull/14627 from an internal engineer.
In such a situation, we should go with @paultsimura
During the PR implementation, we can discuss whether we can introduce a local discriminated union like EffectiveError, to achieve at least some "source of truth" unification.
C+ reviewed 🎀 👀 🎀 (again)

@paultsimura's proposal LGTM 👍!

Thanks. The PR is ready for review: https://github.com/Expensify/App/pull/32944

Left a comment in Slack, but I think this is the expected behavior.

@luacmartins It's not possible that the whole behavior as present in the video is expected.

@cubuspl42 there was further discussion in slack, we've agreed that it's not an expected behavior.

I will be OOO starting Monday, December 18, and will return Tuesday, January 2.
Current status:
The issue has been assigned. We're just waiting on a PR.
If this issue is open when I'm back from OOO, I'll take it back over. Thank you!

@johncschuster the PR has been merged already.
Also, I'm not sure if it was intentional, but you self-assigned this issue after the OOO message (instead of, probably, unassigning).

Current status: The issue has been assigned. We're just waiting on a PR.

Like Pavlo said, we're nearly done here. The state of this issue should be "hold on payment" soon.

Sounds good!

Per this, payment may be delayed a few days here because of the holidays. @cubuspl42 if you have time over the next week to handle the BZ checklist too, that'd be great!

The PR that introduced the bug has been identified. Link to the PR:

It's difficult or impossible to point to specific frontend PRs when backend errors are involved

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

No need for additional discussion

Determine if we should create a regression test for this bug.

Up to the QA team

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Go to the "Sign-in" page
Enter an incorrect phone number (e.g.<PHONE_NUMBER>)
Press "Continue"
Notice that an error message appears ("The provided phone number belongs to a landline or VoIP, please use your email address instead")
Delete the last digit

Verify that the error is instantly changed to the "Please enter a valid phone number" without displaying 2 errors at the same time

TY! I've been OOO for the holidays, but will take care of the remaining steps here and issue payment tomorrow.

BZ checklist is complete. IMO, this is a pretty niche error, so no regression test is needed.

All set to issue payment!

We need to issue the following payments:

@paultsimura - $500 for PR. Paid via Upwork.
@cubuspl42 - $500 for C+. Paid via upwork.

@paultsimura $500 sent and contract ended!

Upwork job closed.

This one's all set. Thanks everyone!


feat(vector,helpers): add more vector functions, add helper functions

Adds vector functions

subtract
scale
normalize
dot
length
distance
angle

Adds helper functions

degToRad
radToDeg
randInt

Coverage decreased (-0.1%) to 99.281% when pulling fb1f64eeffea29b29277a79d06100bcf1d6c31e6 on vectorFeatures into 5cc2041fe72c55b248570d901d9cc590f9e87734 on v7.


During a network partition, nodes can fail to redirect requests to the leader correctly

Under normal conditions, all Chronos nodes respond to requests to add jobs to the scheduler, perhaps by returning an HTTP redirect to the current leader. However, during a network partition, Chronos nodes may return an HTTP 400 response, complaining:
{:orig-content-encoding nil,
 :trace-redirects ["http://n3:4400/scheduler/iso8601"],
 :request-time 99445,
 :status 400,
 :headers {"Server" "Jetty(8.y.z-SNAPSHOT)",
           "Connection" "close",
           "Content-Type" "application/json"},
 :body "requirement failed: Cannot register a job with this scheduler, not the leader!"}

Interesting, so when network partition happens it doesn't forward to the leader since it most likely disconnected with ZK and not able to get the current leader then.
I'm thinking even when a partition happens if the n3 forwards you the leader than was last known to n3 it may not be the correct leader. What is your partition that you did? Is the leader in the majority qurom?

Partitions are randomly generated so it's a little tough to tell--I see this regularly on some fraction of nodes during Jepsen tests though.

Since the only place this message arises is https://github.com/mesos/chronos/blob/ff3fbdfc2e55ace2dc0b8cd3d45adf8853eea33a/src/main/scala/org/apache/mesos/chronos/scheduler/jobs/JobScheduler.scala#L131, it looks to me like Chronos has two paths for detecting that it's not the leader--perhaps a race where the first test which would result in a redirect passes, but the leader requirement fails? I'd suggest unifying those codepaths to cut down on the number of failure modes--maybe just catching the isLeader exception?
I'm not actually convinced that this is correct either, because isLeader seems to just check a local boolean instead of going through replication. There might be a third failure path where the node believes it's a leader but fails to replicate because some other leader has logically suceeded it--might be best to unify treatment for those as well.
 Or does this only occur during the re-election process? If the latter, that seems like the expected behaviour. The leader election may take a few seconds, depending on how ZK is configured.

Naw, it seems transient, but it's mixed in with successful leader operations on other nodes. Not necessarily the end of the world! It's just one of those things where the safety guard works most of the time, but not all the time, which could camouflage deeper problems.


sponsor adapter added

@creativepsyco One class was missing from the last commit. I am not sure why. So, I am merging this one.


All binaries always OFF

Dear community,
as title says, the binary sensor stiebel_eltron_isg_compressor shows always the same state: off. Same goes with all other binaries... All other sensors showing data as expected. Also the switches for SG-ready working just fine.
Running all updated: the integration itself, HA 24.3.3
Any other users experiencing the same issues and may have a hand on how to fix this?
Thanks in advance!
stiebel_eltron_isg-328b40abfa9e777b192c79f1d8ec65f1-Stiebel Eltron ISG-4cb2a8f436cc93a3b3923a5b6ff847ee.json

All digital statuses are bitcoded into modbus address 2501, so I wouldn't be surprised that if the register is faulty or buggy, all other digitals would not be working.
Have you got a WPL/HPA or a LWZ unit?
Anyone else can provide feedback or testing?

Thanks for the reply!
Its a WPL (Tecalor sub brand of Stiebel); strange also, when reading modbus with RMMS, I can see the bitcodes in the (correct) registers.. shall I post a quick dump of debugging of the addon - would that help?
thanks again!

Anything helps

gotcha - kindly find attached; as far as my low skills tell me, there are some tibber and some template errors, but nothing from the ISG-addon  :/
home-assistant_stiebel_eltron_isg_2024-03-30T10-05-41.129Z.log

Yeah, plenty of errors, but nothing helping us.

was hoping, there is smthg helpful..
maybe also strange, that all of the mentioned binaries are shown as 'online', even though carrying 'unknown' as value..

Are you familiar with modpoll software? Are you able to poll registers 2001 and 2501 via ethernet and post the results?

thank you!
I can offer values from modbus, if this helps?

yes, please

does that help?

Yes, can you please export data of ranges 2000-2010 and 2500-2510

when trying to read 2000, I get an error..

I'll look into it tonight or tomorrow.

I'll look into it tonight or tomorrow.

thank you so much!

Ok, can you please do it for 2501 when the compressor is running.
Bit n.7 need to be 1 when the compressor is running. Also please print the data in decimal, because counting the bits is complicated. For starting I don't understand why bit10 of 2503 is 1. It means the pump of buffer n.5 is running, but you don't have 5 buffers, do you?

Ok, can you please do it for 2501 when the compressor is running. Bit n.7 need to be 1 when the compressor is running. Also please print the data in decimal, because counting the bits is complicated. For starting I don't understand why bit10 of 2503 is 1. It means the pump of buffer n.5 is running, but you don't have 5 buffers, do you?

will do, as soon as its running again, currently a lot of warm water in the pot ;)
And no, dont have more than 1 buffer.

Morning,

looks unchanged, even though the compressor is running atm:

So now we now it's not a component bug, it's possibly an ISG bug.
For what concerns the component, we can close this issue as "won't fix", but we now have two possibilities:

I contact STE in Germany to double check it and hope for the best.
I have superAdmin access to all ISGs connected to servicewelt, and I can try update the firmware on your ISG.
Both are long shots, too long possibly. If you want me to update your ISG and try again, PM me with your name and city and I will command update from remote.

much appreciated - thank you for the offer, will send a PM asap!

/close

Sorry for the late answer
Although GitHub removed the private messaging feature, there's still an alternative.
Copy and paste the next line into your browser: https://api.github.com/users/xxxxxxx/events/public
Replace the xxxxxxx in the URL with my username. Hit Enter.
Press Ctrl+F and search for “email”.


Space after Function Name, Call Function.

Hi.
JS-Beautify does not supports indentation after after function names and called functions such as below:
After Function Definition:
function sample() {}
//             ^ Should be one white space.

Call Function:
console.log( "Example" );
//         ^ Should be one white space

Please add this option.
Thanks .
All the bests.

The first item is already filed as issue #940.
The second is already implemented as space-in-paren option.

Thanks.
I wish a successful attempt for you and whole team.


ZNC buffer playback messages are not picked up on

ZNC distributes messages like "Buffer playback started" to the channel using nickname ***. The parser doesn't like * in the nickname and therefore marks the message as invalid:
<EMAIL_ADDRESS>PRIVMSG #channel:Buffer Playback...

Adding * to the list of special characters works, but I'm not sure if this is a valid solution.

I think #34 is related.

I was looking at #34 as well, not really sure if related.
I did some googling, and it looks like * might not even be a valid character for a nickname. I'm not sure if ZNC does this intentionally or not, I'll have a chat with them.

[21:37:56] <NanoSector> heya, I was working with my bot today which was attached to ZNC, but noticed it wasn't picking up the messages sent out by ***
[21:38:11] <NanoSector> looking at the RFC for the protocol it seems * is not even a valid character for a nickname
[21:38:16] <NanoSector> is this done intentionally?
[21:38:28] <Zarthus> yes, it avoids name colissions
[21:38:42] <Zarthus> you can change the prefix, though
[21:38:50] * Pulec (~pulec@2a01:4f8:110:1463:127::2) joins #znc
[21:38:58] <NanoSector> oh it's fine, I was just wondering if it had a meaning :)
[21:39:12] <NanoSector> thanks :)
[21:39:12] <Zarthus> As long as the IRCD sends it to you it will be a valid nickname, or or less.
[21:39:19] <Zarthus> more or less*
[21:39:35] <Zarthus> there's no real need to doublecheck if the name is rfc compatible
[21:40:09] <NanoSector> yeah, i was using a parser component in my bot which flagged the message as malformed
[21:40:21] <NanoSector> i'll report this to them, thanks :)

I'm not sure what the parser component could do about this, since it doesn't know if the message came from ircd or not.

Resolved with #41


Minor fixes and added test to github actions

Two minor changes and added test to github actions.
Please help to review, thanks.

@iamniting Thanks for your input, I have updated them, could you have a look when available? Thanks.

@iamniting Thanks for your input, I have updated them, could you have a look when available? Thanks.

looks good to me


[markdown mode] fix escaped brackets in link def

Example: [foo\[bar\]foo]: https://example.com

Thanks! Looks good. Merged as c39008a


Dockerfile and cmake changes for ubuntu-20.04

Docker changes to build on Ubuntu-20.04
Changed grpc install to default location from user defined directory since the Cmake module in grpc searches only in default locations
Added git clone for grpc, krb5 and cmake.

@fordth
2 of the commits got named the same way, but the commits are distinct.
Please test the Dockerfile.
If it works for you, I will try to pull fordth:mainline into credentials-fetcher mainline.


Remove unused resource files

Description (required)
Removes unused resources.

The betaDebug variant of ic_launcher_background.xml was identical to normal one
The v14 variant of dimens.xml is redundant as the minSdkVersion is 19 so it always applies. It has simply been moved into the normal one

Tests performed (required)
Tested 2.10.1-debug-remove-unused-res~bbe8622aa

Codecov Report

Merging #2641 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2641   +/-   ##
======================================
  Coverage    2.77%   2.77%
======================================
  Files         259     259
  Lines       12373   12373
  Branches     1117    1117
======================================
  Hits          343     343
  Misses      12003   12003
  Partials       27      27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c6888...bbe8622. Read the comment docs.


GitHub secret is no longer displayed

[from forum]
The GitHub secret box is now blank, e.g.

I see this as well if I create a new Github WebHook from the template. On the file system no secret file is created.

Fixed in https://github.com/projectkudu/AzureFunctionsPortal/commit/95e72848cde216120fee841b92b3d093eec75a98


Files skipped while installing through PackageManager, due to errors in filename.

In the Troubleshooting section you mention:
"Package Control may get stuck while installing the library. If that happens you'd see the animation running at the bottom indefinitely ..."
"This seems to be a bug in Package Control. I'm not sure what causes it - perhaps the relatively large size of this package."
I tried to investigate what was causing the error, hitting Sublime Text -> View -> Show Console, and then I had this output while the Package Control got stuck:
Package Control: Skipping file from package named Unity Completions due to an invalid filename
Package Control: Skipping file from package named Unity Completions due to an invalid filename
Package Control: Skipping file from package named Unity Completions due to an invalid filename
Package Control: Skipping file from package named Unity Completions due to an invalid filename
reloading Packages/User/Package Control.sublime-settings

The last line was just the succesful exit, the package was finally installed (like 3 minutes after).
What files are causing this issue? It seems that it would be a lot faster if you fix those filenames.

I'm getting the exact same issue as @embicoin (using Sublime Text 3). Cleared and restarted multiple times. Been working 10 minutes this time. Going to try the light version.
Thanks for your work with these plugins, much love!

Thanks! it's love that's makes this possible.  :)
enjoy the light package. I've just recently updated both packages to the new Unity. enjoy.

Thanks for the hard work @oferei .
I also want to mention that the package does have invalid names, at least for Windows because it doesn't allow question marks (?) on file names, so all the following files are being ignored:
CS/Other Classes/Array(?).sublime-snippet
Boo/Other Classes/Array(?).sublime-snippet
JavaScript/Other Classes/Array(?).sublime-snippet
CS/Other Classes/Array(?)_lower.sublime-snippet
Boo/Other Classes/Array(?)_lower.sublime-snippet
JavaScript/Other Classes/Array(?)_lower.sublime-snippet
CS/Other Classes/Path.Combine(?,_?)_func.sublime-snippet
Boo/Other Classes/Path.Combine(?,_?)_func.sublime-snippet
CS/Other Classes/Hashtable.Add(?,_?)_func.sublime-snippet
CS/Other Classes/Hashtable.Remove(?)_func.sublime-snippet
CS/Other Classes/Path.Combine(?,_?)_class.sublime-snippet
CS/Other Classes/Path.GetFileName(?)_func.sublime-snippet
Boo/Other Classes/Hashtable.Add(?,_?)_func.sublime-snippet
Boo/Other Classes/Hashtable.Remove(?)_func.sublime-snippet
Boo/Other Classes/Path.Combine(?,_?)_class.sublime-snippet
Boo/Other Classes/Path.GetFileName(?)_func.sublime-snippet
CS/Other Classes/Hashtable.Add(?,_?)_class.sublime-snippet
CS/Other Classes/Hashtable.Remove(?)_class.sublime-snippet
CS/Other Classes/Path.GetExtension(?)_func.sublime-snippet
CS/Other Classes/Path.GetFileName(?)_class.sublime-snippet
Boo/Other Classes/Hashtable.Add(?,_?)_class.sublime-snippet
Boo/Other Classes/Hashtable.Remove(?)_class.sublime-snippet
Boo/Other Classes/Path.GetExtension(?)_func.sublime-snippet
Boo/Other Classes/Path.GetFileName(?)_class.sublime-snippet
JavaScript/Other Classes/Path.Combine(?,_?)_func.sublime-snippet
CS/Other Classes/Hashtable.Contains(?)_func.sublime-snippet
CS/Other Classes/Path.GetExtension(?)_class.sublime-snippet
Boo/Other Classes/Hashtable.Contains(?)_func.sublime-snippet
Boo/Other Classes/Path.GetExtension(?)_class.sublime-snippet
JavaScript/Other Classes/Hashtable.Add(?,_?)_func.sublime-snippet
JavaScript/Other Classes/Hashtable.Remove(?)_func.sublime-snippet
JavaScript/Other Classes/Path.Combine(?,_?)_class.sublime-snippet
JavaScript/Other Classes/Path.GetFileName(?)_func.sublime-snippet
CS/Runtime Classes/Joint.OnJointBreak(?)_func.sublime-snippet
Boo/Runtime Classes/Joint.OnJointBreak(?)_func.sublime-snippet
CS/Other Classes/Hashtable.Contains(?)_class.sublime-snippet
Boo/Other Classes/Hashtable.Contains(?)_class.sublime-snippet
JavaScript/Other Classes/Hashtable.Add(?,_?)_class.sublime-snippet
JavaScript/Other Classes/Hashtable.Remove(?)_class.sublime-snippet
JavaScript/Other Classes/Path.GetExtension(?)_func.sublime-snippet
JavaScript/Other Classes/Path.GetFileName(?)_class.sublime-snippet
CS/Runtime Classes/Joint.OnJointBreak(?)_class.sublime-snippet
Boo/Runtime Classes/Joint.OnJointBreak(?)_class.sublime-snippet
JavaScript/Other Classes/Hashtable.Contains(?)_func.sublime-snippet
JavaScript/Other Classes/Path.GetExtension(?)_class.sublime-snippet
CS/Other Classes/Hashtable.ContainsKey(?)_func.sublime-snippet
CS/Other Classes/Path.Combine(?,_?)_func_lower.sublime-snippet
JavaScript/Runtime Classes/Joint.OnJointBreak(?)_func.sublime-snippet
Boo/Other Classes/Hashtable.ContainsKey(?)_func.sublime-snippet
Boo/Other Classes/Path.Combine(?,_?)_func_lower.sublime-snippet

Thanks Ivanca. I will make it right.

fixed in v5.0.2


Bug report: Pipeline error in GitHub

Expected Behavior

GitHub Action should be able to run successfully.
Current Behavior

Error: Error parsing called workflow. -shared-templates/.github/workflows/cd-template.yaml@main: workflow was not found.
Both repositories exist.

Possible Solution

Steps to Reproduce

Note: Error occurs regardless of using typed inputs or steering YAML file.

New Terraform Accelerator using Deploy-Accelerator (ALZ version 3.0.1)
Solution deploys bootstrap successfully.
Attempt to run 02 CD pipeline.

My current config:

Using Complete Starter
starter_location: "australieast"
Using GitHub Organisation
use_self_hosted_runners: "false"
use_private_networking: "false"
use_runner_group: "false"

Context (Environment)

Operating System and version as reported by $PSVersionTable.OS:
PSVersion 7.4.4
Windows 11 23H2

PowerShell versions as reported by $PSVersionTable.PSEdition:

Detailed Description

Hi @richardf5, are you actually seeing the this file in your repo as well? shared-templates/.github/workflows/cd-template.yaml

Hi. I am.

I'm wondering if this is a GitHub org permissions issue stopping the main repo from accessing the templates repo. As a workaround, you could try setting the use_separate_repository_for_templates input to false.
It would be useful to see your GitHub org licensing level and settings for default repository access. I will attempt to replicate in a licensed org too.

Hi. Apologies, I've been on different work for a couple of weeks.
I'll try to replicate the issue today. Currently have another error relating to not being allowed to register a certain resource type. Will take a look and log an issue if required.

Thanks for the update @richardf5, please feel free to re-open you are able to replicate the issue again.


Add files via upload

@CosRox18 Please provide us with a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@CosRox18 You might miss my previous comment. Please react.

@CosRox18 I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!