Persist session properly on login with not cookies

Problem
When client do login with no cookies, server doesn't properly keep session because server track session by cookie only and don't store any session params for newley logged in user
Proposed solution

Introduce new api Request->setSessionId(string sessionId) which will be called at the same time when $response->addCookie("id", $sessionId) called
Modify Request->getSessionId() to return it local sessionId value if it exists

Have you tested this, or should I? Keeping session_id in the object may be problematic because as far as I can recollect, there is a new object created with each request.

Have you tested this, or should I?

I have tested it locally, but anyway I sure that you must do the same too

Keeping session_id in the object may be problematic because as far as I can recollect, there is a new object created with each request.

Yes I know, but it's enough to keep it in-memory till user_id will be flushed to session file.
The only reason why we need it because without it code $session->set($request, "id", $user["udid"]); make no sense, because internally it's check for session and if there is no one, it will not store $user["udid"] to session file


ValueError: num_samples should be a positive integer value, but got num_samples=0

I wanted to test trl using the code from the [doc] (https://huggingface.co/docs/trl/main/sft_trainer):
dataset = load_dataset("imdb", split="train")

trainer = SFTTrainer(
    "facebook/opt-350m",
    train_dataset=dataset,
    dataset_text_field="text",
)
trainer.train()

However, I encountered the following error. Any advice would be appreciated. Thanks!
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[8], line 8
      1 dataset = load_dataset("imdb", split="train")
      3 trainer = SFTTrainer(
      4     "facebook/opt-350m",
      5     train_dataset=dataset,
      6     dataset_text_field="text",
      7 )
----> 8 trainer.train()

File /opt/conda/envs/pytorch/lib/python3.10/site-packages/transformers/trainer.py:1664, in Trainer.train(self, resume_from_checkpoint, trial, ignore_keys_for_eval, **kwargs)
   1659     self.model_wrapped = self.model
   1661 inner_training_loop = find_executable_batch_size(
   1662     self._inner_training_loop, self._train_batch_size, args.auto_find_batch_size
   1663 )
-> 1664 return inner_training_loop(
   1665     args=args,
   1666     resume_from_checkpoint=resume_from_checkpoint,
   1667     trial=trial,
   1668     ignore_keys_for_eval=ignore_keys_for_eval,
   1669 )

File /opt/conda/envs/pytorch/lib/python3.10/site-packages/transformers/trainer.py:1676, in Trainer._inner_training_loop(self, batch_size, args, resume_from_checkpoint, trial, ignore_keys_for_eval)
   1674 self._train_batch_size = batch_size
...
    106 if not isinstance(self.num_samples, int) or self.num_samples <= 0:
--> 107     raise ValueError("num_samples should be a positive integer "
    108                      "value, but got num_samples={}".format(self.num_samples))

ValueError: num_samples should be a positive integer value, but got num_samples=0

Hi @naity
Thanks for the issue!
Indeed you need to pass a coherent value for max_seq_length as the SFTTrainer will discard all the samples that have a sequence length below the default one that is set to 4096.
I will update the docs.
from datasets import load_dataset
from trl import SFTTrainer

dataset = load_dataset("imdb", split="train")

trainer = SFTTrainer(
    "facebook/opt-350m",
    train_dataset=dataset,
    dataset_text_field="text",
    max_seq_length=512,
)
trainer.train()

Hi @younesbelkada,
Your suggestion resolved the issue. Thank you!

Awesome thank you very much!


Tag instances with their etcd or kubernetes version

Codecov Report

Merging #1611 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1611      +/-   ##
==========================================
+ Coverage   25.45%   25.46%   +<.01%
==========================================
  Files          97       97
  Lines        5040     5042       +2
==========================================
+ Hits         1283     1284       +1
- Misses       3613     3614       +1
  Partials      144      144

Impacted Files
Coverage Δ

pkg/model/stack_new.go
33.86% <50%> (+0.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e0226...2822e15. Read the comment docs.


Fetch and display data from multiple APIs in a GUI project

[x] Spotify- signed up already

Netflix- recommended
YouTube
Geographical databases
Instagram
OpenAI- signed up already
Pexels
Imdb
https://pypistats.org/api/
Plan:
Build on the success of using the Spotify API.

[x] Find the working function
[x] Connect it to a UI button.
[x] Combine it with the Qt tutorial templates.
[x] First mini goal: call the same function using a QPushButton
[x] Get the main window to launch

provide inputs for username and password before trying to make API request.

[x] 3. display something from the resulting HTTP response in the UI. Hardcode to Fire on the Cathedral for Now.
21 fields.

[x] Show them all.

[x] Show a definition of each field in the UI, at least on hover.

[ ] Add icons to each feature.

[x] instead of ms, convert to min and sec. S = ms / 1000. Minutes = s // 60. Seconds leftover = s % 60. Formatted song length = f”{min}:{s_leftover}”

[ ] There is a bug with the song duration: I saw 4:6 as the time. Needs to show as 4:06 maybe?

[x] Instead of an integer, display the actual key of the song, e.g. C#

[x] Need the ability to show text in a certain location.

[ ] For a consecutive search, make sure the UI clears before displaying the new results

[ ] A tree widget might be better for displaying tabular data like this, especially with alternating row colors

Discovered that I've been retrieving the track's audio features, whereas I can also make a GET request to retrieve a track object. This track object has more general information included.

[x] Use the Search endpoint to Get Spotify catalog information about albums, artists, playlists, tracks, shows, episodes or audiobooks that match a keyword string.
[x] Make it more general so that any track uri can be looked up- requires providing a text input to search for an artist.
[ ] Let the user hear the 30 second clip.
[x] Let the user see the album art.
[x] Let the user see the track name and artist (and album possibly)
[x] Allow clicking on the top result's track and artist to run and display the audio features for that track
[x] Turn the QLabel into a QPushButton
[x] Let the user search and get the track uri by typing the track name and/or artist

Use another API! At first just make it work for the second API as well. Later, Be able to use both without killing the app.

[x] Make it through all 6 steps of this Instagram user display tutorial. 1/3/2023
[x] https://developers.facebook.com/docs/instagram-basic-display-api/getting-started
[x] Get the ids and captions of all 3 of my posts through curl
[x] Used the returned image url to actually view the image
[ ] Convert the image to a format compatible with QPixmap and display it in GUI.
[ ] Convert the curl requests into python code
[ ] Convert the short-lived access token to a long-lived access token. Use https://developers.facebook.com/docs/instagram-basic-display-api/guides/long-lived-access-tokens

Integrate more functions
Clear the UI when the button for the second api is clicked, and vice versa- perhaps only add the labels when the "Get Audio Features Button is clicked" and remove them when a different button is clicked.

Maybe the top ten results should populate into a QComboBox, with a QPushButton attached
TODO: Connect to the song's audio
Even though the goal is to help listeners understand audio features of songs, letting them hear the song's audio is super pertinent
There is a bug with the song duration: I saw 4:6 as the time. Needs to show as 4:06 maybe?

Since we know we're searching for tracks, we can use the type=track filter, e.g. q=abacab&type=track.

Found the descriptions of the audio features! https://developer.spotify.com/documentation/web-api/reference/#/operations/get-audio-features

Notes about spotify's web ui:
When you search tracks in the spotify web player, you see the top four results
You get the track's icon which reveals a play button on hover, and a tool tip
You see the artist name small below the track; the artist's name has a URL for the artist's page
if you click on it.
You can click a heart icon to add it to your library
By default queries search all, but you can filter to song
If we filter to songs, we see a tabular view- 4 cols: result #, title, album, and duration
Title actually shows the artist and art as well


Walkthrough - ingest for contributors

User journey ingest
Miro

The rough list of features is available here: https://docs.google.com/spreadsheets/d/1h22Q1BTRVbkfcUvZ9cBXXXFoVpOCnwNM/edit#gid=1465090189
More triaging to be done.


1 time secret from server.

Hi, am kindly asking for advice here, say my storage will get a 1 time secret key from server, how am i supposed to store/secure it, keep using the storage, without asking server for the key again?

That is actually outside the use case for this particular module. Also OTP and other derivatives are best left unsaved as they are typically used to derive a stronger symmetric key from.
While both are recommended an OTP or One Time Pad used to derive a key should almost never ever be saved and or re-used.
References for this can be found in NIST SP 800-63B.
Now that I have that out of the way, I would recommend researching the following topics; Transport layer security and security of at rest data with regards to protections that this piece of code will assist with as it is almost certainly NOT to be used as a whole security solution.
Hope that helps.


[SPMLLBuild] Handle fatal errors from the build engine

We were not handling fatal errors from the build engine that can happen
in rare situations (such as the db being deleted while a build is in
progress). In those cases, llbuild returns an empty value for the
overall result and reports errors via the delegate. This implements the
delegate and throws the errors when this happens.

@swift-ci smoke test

@swift-ci smoke test linux

@swift-ci smoke test


Does the client reconnect if I restart datadog Agent?

Does the client reconnect if I restart datadog Agent or the Agent is down?
For example, I might do this to upgrade the Agent.

StatsD uses the UDP protocol. Since it's "fire and forget" the client has no concept of "connecting" with the agent. The client should act the same whether or not the agent is running, and shouldn't have any problems with an agent restart.

Closing this, feel free to reopen if you experience any issue with the agent restarting


User Preference, rephrase "Buy Train Confirmation Box"

The user Preference rephrase to:
Provide "Do Not Buy Train" Reminder Confirmation Box.

Adjusted wording on the Checkbox Text.
Modify each of the User Preference Checkbox to be consistent and extend the ConfirmDecisionPreference Class


[blocker] 'standard-minifiers' in api.use

Hi, I wonder why there is a standard-minifiers dependency in Orion. This is a real blocker for users who want to use similar packages but not standard-minifiers. I mean for example juliancwirko:postcss (autoprefixer usage and other postcss plugins).
standar-minifiers is default, but it could be replaced by other packages and there should be only one added at the same time (only one js and css minifier registered). So in my opinion there shouldn't be such dependency in community based packages because it will block Meteor app at startup. There will be no possibility to remove standard-minifiers.
Related discussion: https://forums.meteor.com/t/postcss-package-and-meteor-build-plugin-questions/12454/13

1

Can we just remove this dependency in the package.js? If yes, can you start a PR for this?

Yes, I think that there shouldn't be a dependency because every app will have standard-minifiers and if someone will want to replace it in the app it will be able to do it. Is there a need for PR? This is just one line deletion.

Any progress on that? That is really a big problem as you cannot use e.g. seba:minifiers-autoprefixer  :-(


Fix traceback for login after last report

Trying to log into the guests after showing report of the last run
could result into traceback because no completed step was found.
Fix the problem by using the last enabled step, add test coverage.

A bit of a late LGTM :)

Sorry, I wanted to have this fixed for the workshop. I was going to ask you for the review anyway :) So thanks for it!


Added composer command to README

I have spend like 20 secs trying to copy the package name so I've spend 2 more minutes creating this PR where there's whole command ready to be copied :). Is it ok?

No problem, thanks for the PR! ;)


Make a separate items page

instead of direct link create a page for items where all the foods are listed  with their names and location

Hi @sagnik3788
I'm interested in solving this issue. I'll make the following changes.

I can create a dedicated and organized page for all the food items and the details with proper layouts and icons.
Make the page responsive.
Add some additional features to make it user-friendly.

@muskan42 apart from that you also want to fetch and handle the images and name location from that food-api

Sure @sagnik3788
Thank you!

@sagnik3788 the project is showing too many errors on my device and not running properly. I would request you to kindly unassign me.


Fix the Blue in Desktop

Description
Change the utils of Desktop is type and action
Type of change
Utils/apps.js
[ ] Bug fix (non-breaking change which fixes an issue)

I have read the CLA Document and I hereby sign the CLA

thanks for the PR


Links to pg-safeupdate in documentation are broken

In documentation
* Hardening PostgREST - Block Full-Table Operations and
* Ecosystem - Extensions

a project named pg-safeupdate is referred. The project has now moved from Bitbucket to GitHub.
Expected behavior
Links in documentation point to https://github.com/eradman/pg-safeupdate
Actual behavior
Links point to deprecated page https://bitbucket.org/eradman/pg-safeupdate/

I'll update the links and make a pull request.

Pull request #337 is now available


Create a test case for an invalid single verse

See #47 for the valid case
Genesis 51:1 should return an empty object

Unassigned


Ability to replace special characters in localized strings

I'd like to be able to format a localized string like Sign{noBreakSpace}in, and then have BonMot automatically replace the text in curly braces with a non-breaking space (U+00A0). For speed, have an option to pass into BONChain the characters that I expect to have to replace, or have API for doing a single character, so we don't have to loop through all of BONSpecial if we know we're only going to be looking for a non-breaking space. But also have a way to look for all strings for cases where thoroughness or code cleanliness trumps speed.

Duping to #146


gradle 7.2: kotlin-gradle-plugin:1.5.21 breaks dependency locking when using mirrors

See https://youtrack.jetbrains.com/issue/KT-49010.
The POMs at https://plugins.gradle.org/m2/org/jetbrains/kotlin/kotlin-gradle-plugin/1.5.21/kotlin-gradle-plugin-1.5.21.pom and https://repo1.maven.org/maven2/org/jetbrains/kotlin/kotlin-gradle-plugin/1.5.21/kotlin-gradle-plugin-1.5.21.pom are different.  The first is the one that gradle will pick up by default; the second is likely to be used when a mirror is involved, and has a list of exclusions in it that the POM at the gradle plugin portal does not.  This creates build failures (see below).
Note that JetBrains have stated on that ticket that they will not fix the existing POM at the gradle plugin portal.  Given that, I assume this can only be fixed by either the workaround in the above ticket, or moving to a newer version of kotlin: with regards to that, is that likely for, say, gradle 7.2.1?
Expected Behavior
Running a gradle build when:

dependency locking is enabled for the buildscript;
the lockfiles are generated using the gradle plugin portal;
and we run the build using a mirror of maven central (by overriding the default plugin portal using an external ~/.gradle/init.d/ script).

...works correctly.
Current Behavior
It fails, with the error message:
FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'kotlin-gradle-plugin-bug'.
> Could not resolve all artifacts for configuration ':classpath'.
   > Did not resolve 'org.jetbrains.kotlin:kotlin-script-runtime:1.5.21' which is part of the dependency lock state
   > Did not resolve 'org.jetbrains.kotlin:kotlin-reflect:1.5.21' which is part of the dependency lock state

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s

Context
See the Expected Behaviour section
Steps to Reproduce
See  https://youtrack.jetbrains.com/issue/KT-49010, in particular the attachment which contains a full reproduction.

On checking, I see that the latest nightly of gradle 7.3 (7.3-20211003230145+0000) fixes this.  The bug remains in 7.2; I'm happy not to migrate to 7.2 and wait for 7.3, so this can be closed.


Create better idle behavior

When a turret is told to go idle, it should first recenter itself, and then once it's centered, should stop trying to rotate to save cycles.

Fixed in this commit:
https://github.com/brihernandez/GunTurrets/commit/5aa8f782e745c8ebb009bf64562bff99ba5d992a


[Bug]: Plugin does not send release MBID to ListenBrainz

Bug description
Listens on ListenBrainz do not match with the correct MBIDs.
Potentially related: #52
Steps to reproduce

Play track where the album has release MBIDs, but the track does not (I have tried refreshing metadata to see in the MB plugin would populate track IDs and it doesn't seem to - checking the codebase, I don't see a MusicBrainzTrackProvider either)

Album

Track

Observe the plugin does not send release MBIDs from the album

[2024-12-19 12:58:51.800 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz: Picking up playback start event for item "リボルバー"
[2024-12-19 12:58:51.801 +11:00] [INF] [3] Jellyfin.Plugin.ListenBrainz: Processing playback start event for item "リボルバー" associated with user "Zoe"
[2024-12-19 12:58:51.803 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz: Checking if item is in any allowed libraries
[2024-12-19 12:58:51.809 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz: Item is in at least one allowed library
[2024-12-19 12:58:51.811 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz: Checking if ListenBrainz submission is enabled for the user
[2024-12-19 12:58:51.811 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz: ListenBrainz submission is enabled for the user
[2024-12-19 12:58:51.812 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz: Checking item basic metadata
[2024-12-19 12:58:51.814 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz: Item has basic metadata
[2024-12-19 12:58:51.814 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz: All checks passed, preparing for sending listen
[2024-12-19 12:58:51.815 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz: Checking if MusicBrainz integration is enabled
[2024-12-19 12:58:51.815 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz: MusicBrainz integration is enabled
[2024-12-19 12:58:51.815 +11:00] [INF] [3] Jellyfin.Plugin.ListenBrainz: Getting additional metadata...
[2024-12-19 12:58:51.817 +11:00] [INF] [3] Jellyfin.Plugin.ListenBrainz: Additional metadata are not available: "Audio item does not have a track MBID"
[2024-12-19 12:58:51.817 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz: Additional metadata are not available
System.ArgumentException: Audio item does not have a track MBID
   at Jellyfin.Plugin.ListenBrainz.Clients.MusicBrainzClient.GetAudioItemMetadata(BaseItem item)
   at Jellyfin.Plugin.ListenBrainz.PluginImplementation.OnPlaybackStart(Object sender, PlaybackProgressEventArgs args)
[2024-12-19 12:58:52.029 +11:00] [INF] [3] Jellyfin.Plugin.ListenBrainz: Sending 'playing now' listen...
[2024-12-19 12:58:52.150 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz.ListenBrainzApi: Waiting for previous request to complete (if any)
[2024-12-19 12:58:52.150 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz.ListenBrainzApi: Sending request...
[2024-12-19 12:58:52.174 +11:00] [DBG] [3] Jellyfin.Plugin.ListenBrainz.ListenBrainzApi: Sending request:
Method: "POST"
URI: https://api.listenbrainz.org/1/submit-listens
Data: "{\"listen_type\":\"playing_now\",\"payload\":[{\"track_metadata\":{\"artist_name\":\"yonige\",\"track_name\":\"リボルバー\",\"release_name\":\"リボルバー\",\"additional_info\":{\"tracknumber\":1,\"tags\":[],\"media_player\":\"Jellyfin\",\"submission_client\":\"ListenBrainz plugin for Jellyfin\",\"submission_client_version\":\"<IP_ADDRESS>\",\"duration_ms\":186000}}}]}"
[2024-12-19 12:58:53.251 +11:00] [DBG] [24] Jellyfin.Plugin.ListenBrainz.ListenBrainzApi: Response status is OK, will not retry
[2024-12-19 12:58:53.254 +11:00] [DBG] [24] Jellyfin.Plugin.ListenBrainz.ListenBrainzApi: Got response:
Status: OK
Data: "{\"status\":\"ok\"}
"

Observe ListenBrainz matches the listen to the incorrect MBID

{
  "inserted_at":<PHONE_NUMBER>,
  "listened_at":<PHONE_NUMBER>,
  "recording_msid": "5a0599ba-c2ca-4768-af79-4d92b74ecb22",
  "track_metadata": {
    "additional_info": {
      "duration_ms": 186000,
      "media_player": "Jellyfin",
      "recording_msid": "5a0599ba-c2ca-4768-af79-4d92b74ecb22",
      "submission_client": "ListenBrainz plugin for Jellyfin",
      "submission_client_version": "<IP_ADDRESS>",
      "tags": [],
      "tracknumber": 1
    },
    "artist_name": "yonige",
    "mbid_mapping": {
      "artist_mbids": [
        "d473a353-c709-408d-b32b-cc4952bdf6d8"
      ],
      "artists": [
        {
          "artist_credit_name": "yonige",
          "artist_mbid": "d473a353-c709-408d-b32b-cc4952bdf6d8",
          "join_phrase": ""
        }
      ],
      "caa_id":<PHONE_NUMBER>4,
      "caa_release_mbid": "4c2a15fe-d71a-453c-bc81-3993f9bd1fe5",
      "recording_mbid": "df703ae9-430a-4d76-a451-e63208c20386",
      "recording_name": "リボルバー",
      "release_mbid": "4c2a15fe-d71a-453c-bc81-3993f9bd1fe5"
    },
    "release_name": "リボルバー",
    "track_name": "リボルバー"
  },
  "user_name": "redacted"
}

Expected behavior
The plugin should fallback to the release MBID from the album if it isn't set on the track.
OR
The MusicBrainz plugin should be adding release and artist MBIDs to the track.
Actual behavior
No response
Jellyfin logs
No response
Plugin version
<IP_ADDRESS>
Jellyfin Version
10.10.3
Additional info
No response

Hi @zliebersbach, thanks for the report.
This is correct behavior. In some cases there might be a recording without a release (MusicBrainz calls them standalone recordings). I'm not sure how this would be categorized in Jellyfin (probably a dummy album or something) but as these standalone recordings exist, the plugin can't always fall back to JF album metadata and so relies on sourcing the metadata from the track itself only.
I don't know how rare the standalone recordings are, but I guess most of the people will have Jellyfin set up with their own ripped albums, so the fallback could be probably a configurable option.

Thanks, @lyarenei
Just a bit confused, so since the MB plugin for Jellyfin does not populate MBIDs on any tracks, we are expected to manually populate MBIDs for all of our tracks in order for the LB plugin to send correct metadata?
Maybe there's room to improve the MB plugin to add correct metadata to tracks? What do you think?


[Versionable] Init

Inspired by

https://github.com/beberlei/DoctrineExtensions/commit/258fa3abeb1a907e827fce7e208fc04376712085 by @beberlei
https://github.com/beberlei/DoctrineExtensions/tree/v0.3.0#what-versionable-does
https://www.doctrine-project.org/2010/02/24/doctrine2-versionable.html
https://stackoverflow.com/questions/31563722/track-field-changes-on-doctrine-entity
https://stackoverflow.com/questions/28561434/doctrine-2-version-doesnt-work/28663975

Idea: Article - ArticleVerison[]

Hi, I'm going through old opended issues and PRs to cleanup too-long-opened items and close them. Thank you for your contribution and time.
We needs a feature with test and passing CI to be able to merge it without letting a bug in.
If this is still relevant for you, please add code with test and make CI pass first. Then we'll able to merge your feature without further waiting :+1:
Thank for understanding.


Model Observer not triggering on updated or saved

Hi,
I'm trying to add a model observer for a CRUD model:
namespace App\Observers;
use App\Admin;

class AdminObserver
{

    /**
     * Listen to the Admin created event.
     *
     * @param  Admin  $admin
     * @return void
     */
    public function created(Admin $admin)
    {
        dd('created');
    }

    public function updated(Admin $admin)
    {
        dd('updated');
    }
}

Created works fine and triggers when I add a new admin.
However the 'updated' listener never seems to get triggered when updating an entry. Nor does 'saved'.
I've noticed the Laravel docs say:

When issuing a mass update via Eloquent, the saved and updated model events will not be fired for the updated models. This is because the models are never actually retrieved when issuing a mass update.

Is this why the 'updated' listener doesn't get called? Is there any way around this?
Many thanks.

@tabacitu any ideas? I've just had a go myself and can confirm its not firing, unless we're both doing something wrong? Might need to manually trigger it if not?

Backpack update looks like mass update to me https://github.com/Laravel-Backpack/CRUD/blob/master/src/PanelTraits/Update.php

Hi guys,
@indra1 , actually the code you sent proves it is NOT a bulk operation :-) We do findOrFail() first. So events should work fine, I've used them in a few projects.
@Eminee , as far as I know the updating and updated events are only fired if an edit was made. If you submit the edit form without actually modifying anything, Eloquent will notice that and it will not execute an "UPDATE" sql command, so it will no longer trigger the event either. Please also test by editing something in the form. Does it fix it for you?
But it's very odd that saved doesn't work for you. I just tried all events again:

on the Create form, it triggered the events in this order: saving, creating, created, saved;
on the Edit form, it triggered: saving, updating, updated, saved when I modified a field;
on the Edit form, it triggered: saving, saved when I didn't modify anything;
on pressing the Delete button, it triggered: deleting, deleted;

Soo... seems to be working fine.
Are you sure you didn't have a typo when you tried saved? Can you try again and share the observer if it doesn't work?
Cheers!

Thanks for your reply @tabacitu, you are completely right - it was because we weren't editing any data. I'm not sure why saved didn't work though, must have been my mistake.
Thanks for your help!

Glad to help.
Cheers!

I'm really sorry to remark on such an old issue  @tabacitu but I honestly cannot understand how to properly set a field when updating a record.
Eg: On a Phrase model, combine/adjust text_a and text_b and save in text_full column.
I've tried the following:

Following the 4.1 docs precisely. $this->crud->request->request->add(['text_full' => ...]) results in Cannot access protected property Backpack\CRUD\app\Library\CrudPanel\CrudPanel::$request

Following a suggestion from the docs and here to use Eloquent events, the update event never seems to fire no matter what. (I've added a dd to the the updated method of a PhraseObserver and added this to the AppServiceProvider.

Following a suggestion from #51 results in Method App\Http\Controllers\Admin\PhraseCrudController::storeCrud does not exist.

I'm not sure how relevant these issues are as they refer to much older versions of Backpack, but a solution for problem 1 or a clearer documentation for how to implement the event observer would be really helpful, I'm so

Ok, finally, after a tip from a user in the gitter that you're not able to access the $request from CrudPanel class anymore and to inherit the variable $request = request(); which addresses points 1 and 3 from above.
Then, with all old examples pointing to parent::updateCrud which doesn't work, I finally found the solution in the 4.0 upgrade notes
It's particularly confusing that the documentation also changes between 4.0 and 4.1 thus feeling up to date/correct: $this->crud->request->request->add(['author_id'=> backpack_user()->id]); which, from what I can understand, is incorrect?
Can the documentation please be updated to reflect the correct way to do this?

Ugh. Sorry for the frustration this must have cause you @alancwoo - indeed, this is something that might not be clearly documented, I'll take some time to re-evaluate how we explain this, and update the docs. Thanks a lot!


[Bug]: Navigating back to first page of results never shows newer items.

Got to Submission History.
Navigate to 2nd page using Next
Add new items so they show up at the start of the Submission history.

May have multiple tabs open or API user has stuff submitted while they have this page open

Hit the Prev button to return to the first page.
Result: the new items don't show up.

Cause: the first page of results is using a starting cursor of the 2nd page with a limit of 10 (or whatever the pagesize is) in ASC mode.

A proposal for a general solution when designing for this cursor-based pagination is to grab our own "cursor" as an 11th item, rather than pulling 10 items only. While we still only display 10, the 11th is indicative of further data to pull and can be checked to show/hide the Next -> button.
In ascending order (clicking Previous), this 11th item would be the one prior to the first displayed item in descending order. With the addition of a stored timestamp as a means of checking our 11th item, we can ensure that the 11th item is indeed a new item that was not part of the original first page and show a "New Items" indicator that, when clicked, refreshes the table.
Steps to modify:

[ ] Modify API call to pull 11 items
[ ] Store original results[0] (1st item)
[ ] Check results[10] (11th item) before showing Next button when call uses DESC (navigating backwards)
[ ] Check results[10] (11th item) before showing Previous button when call uses ASC (navigating backwards)

Fixed with #4743


[Find My Mouse] Add crosshairs as an option

Description of the new feature / enhancement
Currently there are two helpful features to find your mouse cursor:

Find My Mouse: which highlights the cursor with a circle after shaking the mouse
Mouse Pointer Crosshairs: which draw crosshairs around the cursor and require a hotkey to activate and deactivate

While the first one certainly puts more attention on the cursor positon by darkening the background and highlighting the cursor, it is also quite jarring and may hide important information in the background that will be less visible because of the darkening.
I propose adding crosshairs as they are currently provided by Mouse Pointer Crosshairs as an additional option to Find My Mouse. The crosshairs can be easily followed to locate the cursor position and obstruct less of the view compared to the current animation of Find My Mouse.
Scenario when this would be used?
While playing games it happens quite frequently that I lose the position of my cursor because of bright colors and bad contrast which sadly cannot be changed.
Using Find My Mouse in its current state offers an option to quickly find the cursor, but the darkening of the background makes it harder to read vital game information while the animation is playing.
On the other hand Mouse Pointer Crosshairs makes it very easy to spot the cursor position by following the lines and obstructs less of the game. Sadly Mouse Pointer Crosshairs required a hotkey to activate (and subsequently deactivate). Shaking the mouse to locate the cursor feels very natural and is quicker to execute than pressing an additional hotkey.
Supporting information
No response

Hello and thanks for your message. Find my mouse is designed as a very quick way to find the pointer. It must disappear with a click or a key press. Also, there are several settings you could change, like (animation) duration and opacity.


Specify phpcs path inside .sublimelinterrc file

The phpcs linter works if I install the certain coding standard globally in my users/username/wpcs folder. But I am wondering when I set up a project and in the composer,  can I use the custom standard that is installed locally, per project?
I added .sublimelinterrc file in the root of my project with the following
{
  "SublimeLinter": {
   "paths": {
        "linux": [],
        "osx": [
          "/vendor/bin"
        ],
        "windows": []
    }
  }
}

But when I lint, the console says

SublimeLinter: phpcs output:
ERROR: the "Infinum" coding standard is not installed. The installed coding standards are PEAR, Zend, PSR2, MySource, Squiz, PSR1, WordPress-VIP, WordPress, WordPress-Extra, WordPress-Docs and WordPress-Core
SublimeLinter: No match for <_sre.SRE_Pattern object at 0x7fead17c9ac0>

It only picks up the standards that are in the users/username/wpcs folder.
Can this be done?

I think you're better of asking this in the repo for this particular linter?

Ok, will try that too.

Have you tried the {$project}  token in the linter setting?
Example:
{
    "SublimeLinter":
        {
            "linters":
            {
                "phpcs": {
                    "standard": "${project}/vendor/phpcs/MyPHPCS"
                }
            }
        }
}

@nkrh I tried it, but I got a bunch of errors.

Fatal error: Uncaught UnexpectedValueException: DirectoryIterator::__construct(vendor/wp-coding-standards/wpcs): failed to open dir: No such file or directory in /wpcs/vendor/squizlabs/php_codesniffer/src/Util/Standards.php:93

Try to put them in the project settings.
https://www.sublimetext.com/docs/3/projects.html
http://www.sublimelinter.com/en/latest/settings.html#setting-tokens


ucentral: Don't use batmand

batman-adv is a layer 2 implementation of the B.A.T.M.A.N. (IV/V) algorithm. The batmand is an old layer 3 implementation of the B.A.T.M.A.N. III algorithm. The latter is not really useful when already using batman-adv on top of the IBSS/meshpoint interfaces. And running layer 3 B.A.T.M.A.N. III on top of layer 2 B.A.T.M.A.N. IV might lead to all kind of unexpected behavior.

Maybe it is actually useful in your configuration. But this kind of installation often happens when people didn't notice that batmand is not neeeded/wanted when using batman-adv. So I just wanted to point this out.

@ecsv thanks !

Seems like this was applied in<PHONE_NUMBER>b4c93d8e117aeaccd0cc46d5af1309


IGNITE-9480  SQL: Introduce H2 LocalResult factory

IgniteH2BaseLocalResult is a slightly modified copy of org.h2.result.LocalResultImpl that was written by multiple authors and is dual-licensed under MPL 2.0 and EPL 1.0. (See also history of LocalResult that was renamed to LocalResultImpl earlier and replaced with an interface.)
Your copy is licenced under Apache License 2.0 and does not contain original copyright headers.
I think you need either to preserve original licence and copyright headers (MPL 2.0 is more or less compatible with Apache License), or rewrite this class from the scratch, or inherit it and override methods that you want to change without copying large pieces of code.


local operation

does the integration currently support local connection to LG devices or does it require internet connection to LG's cloud service?

It require internet cloud service. As I know is not possible to directly connect to LG  device.

Close this tread because the question is answered and there no action to do


Mac Support

This supports windows only.  Any chance of getting a version that works for both operating systems?

+1 for this

+1

+1

Yea, I'd like to use it on MacOS...

The real issue here is that they decided to use add-ons that Microsoft has said are/will be deprecated and thus this add-on is Windows only.  If they used the new Add-On approach for Office, they wouldn't have this issue.  So what we should be pushing for is Wakatime to use the new API for Office Add-ons so it will work on any implementation of Office, not just the Windows one.
https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins

If I'm not mistaken it doesn't have support for events like saving documents, opening documents and so on.

+1 for this feature.

adding another +1

+1 feature request

+1 feature request

+1 feature request
The fact that these plug-ins are Windows-only should be made clearer on the Github welcome page. This would avoid us having to download and attempt to install it to find out that it will not work.

+1 need it！

+1 feature request
The fact that these plug-ins are Windows-only should be made clearer on the Github welcome page. This would avoid us having to download and attempt to install it to find out that it will not work.

Can't agree more from a macOS user.

+1 feature request

Adding on to my previous comment. This repository needs a README.MD file which could provide such valid information as which versions of Office and which platforms are compatible with this plug-in.

+1

We can't support Mac because we can't use Microsoft's new JavaScript-based plugin framework, since it doesn't support running our extension code in the background on user events such as cursor moved or file saved.
I've added a note to the readme saying it only works on Windows.

Not good enough.  What percentage of your users use Mac? Got to be pretty high.

There are probably more of us developers who work on Mac than you may believe.
When I work on documentation in Word I have to calculate my time spent manually.
When I work on files to import in databases in Excel I have to calculate manually.
Luckily I use memtime which is, miraculously, able to automatically follow both my phpStorm usage and my Office usage on my Mac. I don't completely understand why they can and you can't.

You can use our Mac Desktop App as an alternative. We just need to know the bundleId of the office apps to enable tracking them.


Better error handling

die() is not the best option if the URL is missing.
Also, there is no error handlig (or logging) if the request fails.
Do you want some help with this?

@kbergha please feel free to add a pull request to the branch! thanks!


AM should be possible below 76MHz and in range 108-136MHz only

AM should be possible below 76MHz and in range 108-136MHz only.
Other bands do not use AM at all.

More or less duplicate of #10, see my comment there explaining other usage of AM in slightly higher frequencies than 136 MHz.

Seconded. Again, people have been using AM above 136MHz already.


Access data rather than rendered HTML

Hi, we are trying to write a completely custom frontend and was wondering if there was any way to tap into just the data object that is created to generate the html?

Looking like loadData is what I want

This is working for me:
const { loadData, resolveOptions } = require('spectaql');
await loadData(resolveOptions(spectaqlOptions));

Hi, we are trying to write a completely custom frontend and was wondering if there was any way to tap into just the data object that is created to generate the html?

Out of curiosity, can you provide some more context? You just like all the stuff that SpectaQL does regarding organization, converting to objects, metadata, etc, but you'd like to just do the HTML part yourself? Would love to hear what you like and don't like about the library, but you are of course welcome to use it however you see fit!


Delegations stopped working.

Not being properly accounted.

fixed

@vjrj @virgile-dev it would be interesting to get tests related to delegations.

Sure.
This remains me something simple I read recently:
You don't write tests to make sure your code works now: you write tests so that you can spot your code breaking in the future.

https://dev.to/ptrbrynt/my-testing-epiphany-4en2


app is bugged and literally undeployable

why are we using windows specific libs? why did we break the app by getting rid of /tmp in scheduler? pls someone fix this

App is deployable now, closing


CPU profiler outputs empty  .prof file on arm

Hello, I tried cross-compiling gperftools on a x86_64 machine for arm using
./configure --enable-frame-pointers --build=x86_64-linux --host=arm-linux CXX=arm-cortexa8-linux-gnueabihf-g++ CC=arm-cortexa8-linux-gnueabihf-gcc
and then compiled my application with gcc -fno-omit-frame-pointers. However, when running the application on arm with CPU profiling turned on, I always get an empty .prof file.
Anyone know how to solve this problem?

The issue is solved by enable libunwind feature when compiling. The latest libunwind 1.4 is used instead of libunwind-0.99 because 0.99 failed when being cross-compilied. With 1.4 “emergency malloc” cannot work but setting UNW_ARM_UNWIND_METHOD=4 let profiler works properly.
However in the result the call graph always dropped the call relations of some functions, leading to some single nodes which were not connected.

hello, dear tsukurudesktop
I was also working on some projects with ARMV8 which needed gperftools as a profiler tool. And I used your configure command referred above. However, would you please tell me how to enable the libunwind? Besides, is there any detailed documents about gperftools so that I can configure or install the gperftools according to the docs?

Just follow the instruction here, https://github.com/gperftools/gperftools/blob/master/INSTALL
To enable libunwind, you need to install the library of libunwind first, and then compile gperftools with a extra flag "--enable-libunwind". Gperftools will then link itself with libunwind. @staycalmstayfoolish

I had the same issue on an armv5 system, but resolved it by setting CPUPROFILESIGNAL=12 and sending kill -12 (pid) to the program to stop & start profiling. Didn't have to mess with libunwind compilation in my case.


PlanSys2 Execution Error

I am trying to use Plansys to create a problem file and then plan, but although the plan is found, it doesn't execute and shows the following error.
[plansys2_node-1] [INFO] [1709134273.981849473] [domain_expert_lc_mngr]: Node domain_expert_lc_mngr has current state active.
[plansys2_node-1] [INFO] [1709134273.981931494] [problem_expert_lc_mngr]: Node problem_expert_lc_mngr has current state active.
[plansys2_node-1] [INFO] [1709134273.982005331] [planner_lc_mngr]: Node planner_lc_mngr has current state active.
[plansys2_node-1] [INFO] [1709134273.982077971] [executor_lc_mngr]: Node executor_lc_mngr has current state active.
[plansys2_node-1] [WARN] [1709134282.023724726] [problem_expert.rclcpp]: failed to send response to /problem_expert/add_problem_instance (timeout): client will not receive response, at ./src/rmw_response.cpp:154, at ./src/rcl/service.c:402
[plansys2_node-1] [INFO] [1709134299.071028991] [executor]: Action floor_robot_pick_tray timeout percentage -1.000000
[plansys2_node-1] [INFO] [1709134299.072765212] [executor]: Action floor_robot_place_tray_on_agv timeout percentage -1.000000
[plansys2_node-1] [INFO] [1709134299.074954239] [executor]: Action floor_robot_change_to_part_tool timeout percentage -1.000000
[plansys2_node-1] [INFO] [1709134299.077864213] [executor]: Action floor_robot_pick_bin_part timeout percentage -1.000000
[plansys2_node-1] [INFO] [1709134299.080392185] [executor]: Action floor_robot_place_part_on_agv timeout percentage -1.000000
[plansys2_node-1] [INFO] [1709134299.082889348] [executor]: Action floor_robot_pick_bin_part timeout percentage -1.000000
[plansys2_node-1] [INFO] [1709134299.085713803] [executor]: Action floor_robot_place_part_on_agv timeout percentage -1.000000
[plansys2_node-1] [WARN] [1709134299.093758548] [rcl.logging_rosout]: Publisher already registered for provided node name. If this is due to multiple nodes with the same name then all logs for that logger name will go out over the existing publisher. As soon as any node with that name is destructed it will unregister the publisher, preventing any further logs for that name from being published on the rosout topic.
[plansys2_node-1] [WARN] [1709134299.120032914] [rcl.logging_rosout]: Publisher already registered for provided node name. If this is due to multiple nodes with the same name then all logs for that logger name will go out over the existing publisher. As soon as any node with that name is destructed it will unregister the publisher, preventing any further logs for that name from being published on the rosout topic.
[plansys2_node-1] [ERROR] requirement not met: [(tray_in_slot id_03 tray_slot1)]
[plansys2_node-1] [ERROR] requirement not met: [(tray_attached id_03)]
[plansys2_node-1] [ERROR] requirement not met: [(part_in_slot bin2_slot1 purplepump)]
[plansys2_node-1] [ERROR] requirement not met: [(tray_on_agv agv4 id_03)]
[plansys2_node-1] [ERROR] requirement not met: [(part_tool_mounted)]
[plansys2_node-1] [ERROR] requirement not met: [(part_attached purplepump)]
[plansys2_node-1] [ERROR] requirement not met: [(tray_on_agv agv4 id_03)]
[plansys2_node-1] [ERROR] requirement not met: [(part_in_slot bin6_slot1 bluebattery)]
[plansys2_node-1] [ERROR] requirement not met: [(tray_on_agv agv4 id_03)]
[plansys2_node-1] [ERROR] requirement not met: [(part_tool_mounted)]
[plansys2_node-1] [ERROR] requirement not met: [(part_attached bluebattery)]
[plansys2_node-1] [ERROR] requirement not met: [(tray_on_agv agv4 id_03)]
[ERROR] [plansys2_node-1]: process has died [pid 47657, exit code -11, cmd '/opt/ros/iron/lib/plansys2_bringup/plansys2_node --ros-args -r __ns:=/ --params-file /tmp/launch_params_u_1zt1wq --params-file /opt/ros/iron/share/plansys2_bringup/params/plansys2_params.yaml'].

However, if I take the problem domain and plan from the /tmp and run it using the Plansys2 Terminal, it works.
domain.txt
plan.txt
problem.txt
[Attached as text file for GitHub support]

The plan searches for instances in lowercase, but the problem had sentence case


Modernize property definitions in SplitText

This code was using old property syntax instead of @property decorators.
I also removed the comments, as they don't express anything that isn't already clear from the code itself.

To be fully backwards compatible I'm against removing methods (even if they are private) for the 4.5.0 release. Do we need to mention them in the change log?

To be fully backwards compatible I'm against removing methods (even if they are private) for the 4.5.0 release. Do we need to mention them in the change log?

These methods only exist to implement the property and were introduced at the same time as the property, in commit 85157347f1dd32676322ee2dd1c4ad6e65e6eddb. There was never a reason to call the private method over using the public property.
If you're thinking of subclasses that might override the method, that doesn't actually work: the property definition captures the method from the class scope. It doesn't do a lookup on self, so any overriding method will not be used by the property.


Add new task IS Mosaic to Flutter app

Closes #300

I didn't look up the sources for this page, but apparently we use some mapping from benchmark type to benchmark name instead of using name from the tasks file?
Maybe we should merge this and create a separate issue for incorrect naming.
@anhappdev what do you think?

Yes, currently we show only hard-coded name for 5 different tasks type: IC, IC(offline), OD, IS, LU.
https://github.com/mlcommons/mobile_app_open/blob/149b224fd5b19179bc6acd5418a243e4d7e89372/flutter/lib/benchmark/info.dart#L36-L68
I will make the changes to show the task name from the task.pbtxt instead in another PR.


Cleanup + generally avoiding nesting.

I did stuff, tested it on qb and it worked so heres the thing.

I stopped at removing the nesting, I do want to recommend to improve the resource you should move all vehicle locking/unlocking to server side though. Clientsided locks will not sync to people out of scope with the method you are using.

Thank you very much! Will add it soon


types(ui/space): add BasicAttributes

Checklist

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information

Codecov Report

Merging #634 (43dee40) into dev (7d421bc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #634   +/-   ##
=======================================
  Coverage   95.41%   95.41%
=======================================
  Files         217      217
  Lines        5255     5255
  Branches      982      982
=======================================
  Hits         5014     5014
  Misses        232      232
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d421bc...43dee40. Read the comment docs.


Add Custom, or different idle notification sounds

Is your feature request related to a problem? Please describe.
I've always drained out my pc's default notification sound and think it would be cool to have custom or in built Runelite specific sounds :)
Describe the solution you'd like
The option to change the idle notification sound
Describe alternatives you've considered
Or any other sound that's not the default windows sound

Duplicate of #2060


Allow DWARF column numbers beyond actual registers in libunwindstack

DWARF allows column numbers for the DWARF table for unwinding frames
that are larger than actual (general purpose) register numbers
(sometimes these are called virtual registers). So far, libunwindstack
would reject such column numbers. We now allow column numbers up to a
certain limit by expanding the vector that is storing the registers
during evaluation of DWARF expressions when unwinding a frame.
Note that an alternative would be to simply increase the maximum
number of registers present for all architectures (or the architectures
we care about), and this was also how this was initially done in our
unwinding prototype. However, the "column number larger than general
purpose registers" feature is a feature of DWARF and thus should be
handled and controlled by code related to DWARF.
A possible (but potentially larger) refactoring would be to disconnect
the columns in the evaluated DWARF table from the registers (including
copying the subset of the table that belongs to actual registers into
the registers vector after evalution).
Tested: Unit test added.
Bug: http://b/194768602

The code looks good on a line-by-line level. For a proper review I am honestly lagging some context about what gets evaluated and the connection between cfa and the columns.

That's fair, I honestly have to test this end-to-end when all pieces are there to make sure this actually works as intended. I did some testing on real world examples, plus unit tests, but the full integration is still missing.


Terminal "ansiBrightYellow" has very poor readability on light themes

Issue Type: Bug
The terminal color terminal.ansiBrightYellow has very poor readability on light themes. Terminal apps only uses yellow because they usually have a dark background. While the description calls it yellow, wouldn't be better if it defaulted to blue or some other color that's not yellow for light themes?

VS Code version: Code 1.31.1 (1b8e8302e405050205e69b59abb3559592bb9e60, 2019-02-12T02:20:54.427Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3632QM CPU @ 2.20GHz (8 x 2195)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.87GB (2.81GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

rainbow-brackets
2gu
0.0.6

code-runner
for
0.9.7

terminal
for
0.0.10

matlab
Gim
0.9.0

language-julia
jul
0.11.4

nim
kos
0.6.3

r
Mik
0.0.6

python
ms-
2019.1.0

cpptools
ms-
0.21.0

sublime-keybindings
ms-
4.0.0

r-lsp
REd
0.0.8

vscode-fileutils
sle
2.13.5

markdown-pdf
yza
1.2.0

(2 theme extensions excluded)

It has to be yellow as that's what powershell is telling the terminal to render. This is a tricky problem as the color needs to work as a background color as well. For now I'd say either override the color in your settings via workbench.colorCustomizations or switch themes.
This is the best solution for this: https://github.com/xtermjs/xterm.js/issues/1514


Multiple frontends: What is the workflow for pulling programmatically

Which Category is your question related to?
amplify pull and https://aws-amplify.github.io/docs/cli-toolchain/quickstart#multiple-frontends
Amplify CLI Version
4.12.0
What AWS Services are you utilizing?
Amplify, Cognito, Lambda, AppSync and more.
https://aws-amplify.github.io/docs/cli-toolchain/quickstart#multiple-frontends
I have three environments maintained in a separate repository. That repository only contains my back-end. When pulling my back-end into another front-end project, I discovered several limiting factors:

I cannot create a separate back-end via amplify init (to effectively only use what I need from the externalized back-end), because any future amplify pull will only attempt to pull from this new back-end, and not the externalized back-end. This seems to remove amplify as a hosting option, because this front-end cannot be turned into an amplify project. I have to choose between turning this project into an amplify project and the ability to pull a fresh externalized back-end config into this project. No big deal, I can just do the hosting myself, right?
aws-exports.js isn't meant to be committed, and every amplify pull, with a differing target environment, resets the file with the environment specific configuration. This means that I have to program a build step that detects the environment and pulls the correct environment. Not the worst situation, but 3 makes it difficult.
There isn't any documentation regarding pulling and generating the aws-exports.js programmatically. The documentation given here expects users to answer questions via the CLI. I'm not guaranteed that the CLI flow will remain the same. If I'd like to pull from an environment, during build, I'd like to know my build step won't break with an upgrade to the amplify CLI.

How can I checkout particular environments if this front-end project cannot be converted into an amplify project? Can I still use the amplify console, for hosting, when the back-end is externalized?
It would be nice if I could both externalize my back-end, and treat this front-end project as an amplify project.
If I have to do my own hosting, then some docs under the "multiple-frontends" section for pulling multiple environments programmatically (as opposed to answering questions via the cli) is needed. And I hope it works across major and minor version changes.

@dyangelo-grullon you can use pull headess as stated here: https://aws-amplify.github.io/docs/cli-toolchain/usage#headless-mode
This issue has now become something a little different from the original ask. @dylan-westbury do you think you could create a separate ticket as it is not related to this item?

It looks like this issue was originally in amplify-cli, which seems correct based on the initial request. I am trying to determine if the separate repo for shared Amplify managed aws resources is a good path. I'm now trying to add the read only (Do you plan on modifying this backend?: n) setup to a project repo and it looks like that generates the aws-exports.js file and then tells me to run amplify pull any time I need to sync changes. I was also surprised to see it asks the set of questions every time amplify pull is run again.
I see the suggestion above for headless mode, so I am going to look at that a bit to run for a prod build vs a dev build, etc. and get the correct config. I'm also wondering if it may be easier to mange manually with Amplify.configure and env vars. 🤔
Since this is a bit over a month later I'd be interested to hear if anyone determined a best workflow.
I also tend to agree with point number one, it would be nice to mix things from a separate repo with various other amplify managed projects. I suppose the question is if the cli should do it or if it should be manual.

I haven't been able to figure out how to add multiple backend as per the multi-frontend docs either. The documentation on that page is very short, and it was only by reading this issue I found the headless sample script.
I tried using that sample script as follows:

start with a working amplify project with react frontend and api backend
create a new react project (without amplify)
substitute the values for the existing amplify project in the sample amplify pull script
run the amplify pull script and answer No when asked Do you plan on modifying this backend?

I've been trying to set up a second frontend project on an existing amplify front & backend project as well. I got the same negative result  as @smakinson when running amplify pull in the new frontend project. I don't think the Multiple frontends page has enough information at the moment. I only found the amplify pull sample script by reading this issue.
However, when I followed the advice from the Multiple frontends page concerning the single source of truth about the backend configuration, and answered No to the o you plan on modifying this backend? prompt (I omitted the --yes option from the sample script) it printed a success message:
Added backend environment config object to your project.
Run 'amplify pull' to sync upstream changes.

but no changes were made to my project, the amplify folder was not created.
The only way I could get it to work was to reinstate the --yes option This pulls the whole backend config down into the 2nd project. This means that we'll need to be careful about where changes to the backend config are made. An unexpected(?) side effect is that amplify codegen works and I'm able to use the generated graphql classes in the 2nd project.

Was able to do the codegen with this approach, still trying to figure out how to add the Auth but this generated my graphql classes in the 2cnd project...
https://dev.to/applification/multiple-frontends-with-amplify-console-3nnj


1.4 Project Plan

Completed together as a team.

We delegated the workload for the team

This project plan is with respect to Sprint 1

Task are distributed for sprint 1.


push Artifacts on build success

Description

Makes AppVeyor upload file artifacts for easier user testing
Motivation and Context

Makes it easier to give people a build to test
How Has This Been Tested?

Did not test, should work though
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project (run $ yarn lint).

Could you please further explain what this PR does? We are currently only generating artefacts on tag builds as we exceed the AppVeyor storage otherwise (see #105) - how will this PR change this behaviour?
How does this PR give people an easier way to test builds? What improvement does this have over this development process?

It would generate a new Artifact on every push, can link the exe to every one if you want them to test a specific commit.

As already mentioned, we changed this behaviour to only push artefacts on tab builds as we'll exceed AppVeyor storage limits otherwise.


docs: Suggest cloning a fork [ci skip]

Ready to be merged.

Hi Jim - we don't need the "ready for merge" convention anymore - PRs signal that by themselves.
Note that we want Conventional Commit formatted commit messages, not just PR titles.

Got it: As you can see from my title edits, there was a little trial and error on this one. The semantic pull request checker says it's happy if one of the commits or the title of the pull request follow the guidelines, but apparently that is configured differently here. Maybe the CONTRIBUTING guide should be a little more specific on that; right now it just says "Consider starting the commit message..."

@jimfenton I updated the guide with clearer instructions and examples:
https://github.com/ietf-tools/.github/blob/main/CONTRIBUTING.md#git-commit-messages

That makes it clearer for me; thanks.
Also, it may be due to my GitHub security configuration (2FA, SSH keys) or the fact that I'm using Sourcetree, but I wasn't able to push to my forked repo when I used https://github.com/jimfenton/datatracker.git . I had to adjust my URL to git@github.com:jimfenton/datatracker.git to get it to work. I don't know how general this problem is though, so I don't know how it should be represented in the README.

This is normal, as https://github.com/jimfenton/datatracker.git is an HTTPS/Basic authentication format URI. When using SSH keys, you must use the git@github.com](mailto:git@github.com):jimfenton/datatracker.git format.
When clicking the Code button on a repo, you're presented with both the HTTPS and SSH options, each with their proper URI.


Dev/0.0.1

add disk advisor

Codecov Report

Merging #1 into master will increase coverage by 3.96%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   36.15%   40.12%   +3.96%
==========================================
  Files           5        7       +2
  Lines         130      162      +32
==========================================
+ Hits           47       65      +18
- Misses         78       90      +12
- Partials        5        7       +2

Impacted Files
Coverage Δ

advisors/disk/inode.go
47.36% <47.36%> (ø)

advisors/disk/disk.go
69.23% <69.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91d9294...ca986aa. Read the comment docs.


batch with scalar bounds

From the documentation:
batch: The preferred number of points to batch. This allows user-side parallelization of the integrand. If batch != 0, then each x[:,i] is a different point of the integral to calculate, and the output should be nout x batchsize. Note that batch is a suggestion for the number of points, and it is not necessarily true that batch is the same as batchsize in all algorithms.
That is not true for scalar bounds
using Quadrature
using Cubature
function f(x,p)
    x
end
function f_batched( dx_batched,x_batched,p)
    for i in 1:size(x_batched,1)
        dx_batched[i] = f(x_batched[i],p)
    end
    return nothing
end
prob = QuadratureProblem(f_batched,0.0,1.0,nout=1,batch=2)
sol = solve(prob,CubatureJLh(),reltol=1e-3,abstol=1e-3)

Ahh yeah, x[i] for scalar.

This is now properly documented.


Support registering listeners via JSX

Allow adding listeners like a property when using JSX syntax, i.e.:
<composite onResize={handleResize}/>

It is already was implemented in fork of tabris.js, you're free to implement from fork (tez-native on github).

Done except for documentation (which I will do tomorrow).


Modifying a flutter app and running it goes back to the old state

Steps to Reproduce

Create a Flutter app on Webstorm
Make some modifications to main.dart.
Run the app.
Expected: new changes take effect
Actual: The app goes back to the sample template that was provided on creation

I've attached a video showcasing the bug
bug.mp4.zip

Video as YouTube: https://youtu.be/JrEIbwRKNNk

Let's see if this is something with the IDE or in-general.
Please try this:

open a terminal
cd into your project
type flutter run
make a change to main.dart
type r in the terminal

What happens?

Is this in some sense a dup of #10684

marking this as a duplicate of #12300


build: enable easier local dev with Remote Habits

Related: https://github.com/customerio/RemoteHabits-Android/pull/37

:tada: This PR is included in version 1.1.0-alpha.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Amendment for January 2021

For me to do a future Amendment

activity/covid19/items/covid19_clinical_history:

We need to change "diagnosis" to "condition"
Amendment: add new conditions: https://www.cdc.gov/coronavirus/2019-ncov/need-extra-precautions/people-with-medical-conditions.html
It seems odd to ask if you’ve ever been diagnosed with diarrhea -- that’s a symptom, not a disease (or condition).  Maybe the questions should say “Are you experiencing or have you recently experienced” (NPS)

Rainbow passage normal: underline "one breath". What if they can’t read the entire passage on one breath?  I couldn’t, so I took a breath and kept reading anyway.  Should the instructions cue them to speak quickly so there’s a chance they’ll do it in one breath?    You will hear that I said mine pretty slowly and with little breaks between syllables because of the way it’s written.  Clearly, I can go A LOT faster than that!  I also know that we usually use a schwa, but I said a clear /a/ because of how it’s written.  How about these instructions:  Say the syllables “puh” “tuh” “kuh” together as fast as you can.  Then take a deep breath and say them over and over again until you run out of air. (NPS)

Breathing in for 4, out for 4.  Maybe add the comment “even if it makes no sound.”

Add:
Ethnicity
Race
Gender
What city did you mainly grow up in (please put only one city)? OR In which city did you spend most of your childhood?
Add geo location: java

   "en": "Date you were last tested. MM/DD/YYYY",
    "es": "Fecha en la que fuiste testeado por última vez. MM/DD/YYYY"

            {
            "value": 12,
            "name": {
                "en": "Cancer",
                "es": "Cáncer"

            }},
                            {
            "value": 13,
            "name": {
                "en": "Obesity",
                "es": "Obesidad"

            }},
            "value": 14,
            "name": {
                "en": "Pregnancy",
                "es": "Embarazo"

            }},

feedback "wasn't always clear if you wanted the inhale included or not in each recording. Also for relax and inhale, I breathed through my nose, but not sure if you wanted through the mouth or nose."

Ask about vaccine: it would increase confidence they don't have COVID

Ask about vaccine: it would increase confidence they don't have COVID

__ I consent to having my data shared only with the researchers of this study.
__ I consent to having my data shared with other qualified researchers as well.
__ I consent to having my data shared with qualified researchers and shared publicly.

Email 1, email 2, and social media invitations (twitter, facebook, instagram).

Someone laughed becuase they couldnt finish "When sunlight..." in one breadth and pataka. . This may happen often. SO remove ending? Or ask not to laugh?
Highest body temperature during COVID19 infection.
Current body temperture (or you can skip with the button below).

PHQ-9,PHq-2,GAd7:
Ningún día, Algunos días (instead of Varios dias).
Maybe add numbers like the form has: https://www.ons.org/sites/default/files/2017-06/PatientHealthQuestionnaire9_Spanish_0.pdf

Maybe requesting feedback: "Anything you would improve? Parts you liked? Parts you disliked? "

Submitted many of these items in an Amendment, which was approved. Opening new issue to incorporate them.


Performance improvement

Increased the performance by around 20%

@maditya, please review and merge.
@yukinying, you may like to use this for benchmarking. I got >0.65Mbps using my 11" macbook air.

CLA is valid!

Looks good.

:+1:


Using Range Requests - Do the first call as a a HEAD call

I would like to ask whether it's possible to tweak the pdf.js library calls for a range request environment. pdf.js currently seems to always do its first call as a GET call. The backend we use, however, can quickly return the file size, which is kept in a database, but takes its jolly time to start receiving the actual document from file storage. If it's a big document, say, 100 MB with 10k pages, the difference will be a few seconds. For HTTP standard compatibility, GET requests have to return the full document if they are not aborted, and with the framework/pipeline used it is not possible to first send the headers, then wait whether the request will be aborted, and if it is not, start requesting the document from storage and send it.
In https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests it is described that a HEAD http request for the resource does return the Content-length and the Accept-Range header for evaluation. I would expect a Mozilla library supporting range requests to at least allow me to configure it to work according to Mozilla's own range request documentation.

In https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests it is described that a HEAD http request for the resource does return the Content-length and the Accept-Range header for evaluation.

As can be seen in the relevant code, it's necessary to validate the Content-Encoding as well.
Furthermore, note that in all modern browsers the Fetch API will be used to load the PDF document (see src/display/fetch_stream.js) since that by default allows the data to be fetched using the initial (200) request rather than aborting and using range requests.
Using streaming, rather than range requests, is not only more efficient and faster in general, but it also prevents errors with servers that don't allow resources to be fetched more than once.
If you have "special" requirements, with regards to how the PDF.js library is fetching data, then it's recommended to utilize the PDFDataRangeTransport functionality since it allows completely custom data delivery; please find some additional information/pointers in https://github.com/mozilla/pdf.js/issues/11453#issuecomment-569347187.
All-in-all, I don't really think that any changes to the PDF.js library are necessary/desirable here.

@Snuffleupagus I think this issue is actually causing a lot of people headaches with streaming in PDF.js - I had a look around Stackoverflow and there are a lot of examples of people who could never get it working over the years, I suspect due to the assumption of their server technologies that a HEAD would have been issued to find the Content-Length header.
Any chance you can rethink this one?


release: Update manifests for 0.9

Update the manifests for the 0.9 release
/cc @elikatsis

/lgtm


Icons

The documentation says:

In order to show every service icon crystal clear within the Franz UI, we require a .svg and .png in 1024x1024px.

cc @mxstbr

Would you rather want rounded corners

Or full square

?

I'd say rounded, as other apps within Franz have rounded borders as well.
Thank you very much!

/cc @uberbryn can you export those icons quick? I dunno how to figma

http://c.bryn.io/nNdZ


Assert in Feature.createStyleFunction

There is an assert on the Feature function createStyleFunction, line 291.
I am using Ionic. This is the module import,
import Style from 'ol/style/style';
and this is the invocation,
const circle = new Circle({
     radius: 6,
     fill: new Fill({
       color: '#3399CC'
     }),
     stroke: new Stroke({
       color: '#fff',
       width: 2
     })
   });
   const style = new Style({
     image: circle
   })
   this.positionFeature.setStyle([style]);

If I use style as the parameter to the function, the assert condition fails that's why I pass a one element array and it works.
I am not sure why it fails because style instanceof Style should be true. Maybe is something with the import, that's the only difference with the examples.
Regards,
Manuel

Looks like a version mismatch of ol, probably caused by using dependencies that require different versions of ol.
What is the output of npm ls ol?

The output is -> ``-- @ol5.1.3`
You are right, It was my mistake on the import, with import Style from 'ol/style/Style it works.
The weird thing is that I actually check style instanceof Style in my code with import Style from 'ol/style/style'  before calling the function and it was true
One last thing, the url in the assert message it was not working.
Anyways, thank you very much.
Regards,
Manuel


Insecure instructions for yum and apt repository setup

I noticed that the setup instructions for the yum repository on bintray simply disable GPG verification. Wouldn't it be better to modify these to enable verification by default?
Also, the setup instructions for the apt repository include the following command:
sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv 642AC823

This is really not that good an idea, since collision attacks on short key IDs are really easy to pull off these days, which means adding a key to the package manager's trusted keyring only based on the short ID is a security risk. Instead, the instructions should be amended to use the full fingerprint.

I noticed that the setup instructions for the yum repository on bintray simply disable GPG verification. Wouldn't it be better to modify these to enable verification by default?

Could you link to the instruction so we can correct it?

This is really not that good an idea, since collision attacks on short key IDs are really easy to pull off these days, which means adding a key to the package manager's trusted keyring only based on the short ID is a security risk. Instead, the instructions should be amended to use the full fingerprint.

Thanks for letting us know.

Oh, sorry. I think this was what I had in mind: http://www.scala-sbt.org/download.html (the linked yum repo definition contains the line gpgcheck=0.

We followed the official instruction from Bintray, and Bintray happens to be using insecure instruction then.
$ curl https://bintray.com/sbt/rpm/rpm
#bintray--sbt-rpm - packages by  from Bintray
[bintray--sbt-rpm]
name=bintray--sbt-rpm
baseurl=http://dl.bintray.com/sbt/rpm
gpgcheck=0
enabled=1

http://blog.packagecloud.io/eng/2014/11/24/howto-gpg-sign-verify-rpm-packages-yum-repositories/

Unfortunately, signing and verifying RPM packages and yum repositories is tricky and there are a few bugs which can prevent clients from properly verifying signatures.

I would like to push this issue again.
Just stumbled upon it myself and at the current state I would not recommend anyone to include the rpm repo at the current state. (only talking about rpm! - didn't look into deb, but it seems fine).
To point out what the problem here is: When the rpm repo is enabled on a computer, basically everyone on the wire (or able to spoof a DNS record) can modify all packages, because nothing is encrypted or signed. Those packages would be installed as root, allowing to modify the system in every way imaginable with minimal effort.
So, this is... BAD! What to do about it?
Changing the baseurl to HTTPS seems to be a quick win and makes tampering with the data way harder. From my tests Bintray does support it and the repo still works.
repo_gpgcheck checks the metadata of the repository. I'm not sure about Bintray, but Artifactory does support signed repo metadata in its module. You would need to have a private key stored on bintray (or trust theirs!?). But I'm not sure about the details.
Lastly using gpgcheck might be a viable option if you could manage to sign the rpms. I'm not sure how you build them, but it should be as simple as calling rpmsign.
If there is any way I could help to push this issue forward, please let me know.

Our current instruction is
curl https://bintray.com/sbt/rpm/rpm | sudo tee /etc/yum.repos.d/bintray-sbt-rpm.repo
sudo yum install sbt

so we're good now?


is not a valid Win32 application [Solution Found]

[ x] I think my problem is NOT with youtube-dl
[x ] I've verified and i assure that I'm running youtube-dl-gui 0.4
[x ] I assure that i am using the latest version of youtube-dl
[x ] Searched bugtracker
[x ] I've read the FAQs file

What is the purpose of your issue?

[x ] Bug report

Bug report
Exception in thread Thread-2:
Traceback (most recent call last):
  File "threading.pyc", line 801, in __bootstrap_inner
  File "youtube_dl_gui\downloadmanager.pyc", line 599, in run
  File "youtube_dl_gui\downloaders.pyc", line 162, in download
  File "youtube_dl_gui\downloaders.pyc", line 337, in _create_process
  File "subprocess.pyc", line 390, in __init__
  File "subprocess.pyc", line 640, in _execute_child
WindowsError: [Error 193] %1 is not a valid Win32 application

What operating system do you use ?
Windows 8 64bit, I have used both the portable version and the setup version, both have failed, I even used the lated youtube-dl
List of actions to perform to reproduce the problem:

ran youtube-dl-gui, pasted the youtube url, chosen mp4 format
added the link
clicked start

What is the expected behaviour ?
To download
What happens instead ?
stuck in Queued 0%

@MrS0m30n3 I found the solution! When you run Youtube-DLG it creates a folder C:\Users\ [YOUR USERNAME] \AppData\Roaming\youtube-dlg
The problem was that this created folder contained youtube-dl.exe with a filesize of 0 bytes, so I corrected this issue by copying youtube-dl.exe to that folder.

@MrS0m30n3 it seems that Youtube-DLG doesn't look for youtube-dl.exe in it's current folder, instead it looks for youtube-dl.exe in the \AppData\Roaming\youtube-dlg

good.


Code Inspection: npm audit on headcommitsonly

marked:>=0.3.14 <0.6.2

(warn) Regular Expression Denial of Service Upgrade to version 0.6.2 or later.

marked:0.4.0:

typedoc>marked

[atomist:code-inspection:headcommitsonly=@atomist/atomist-sdm]

Issue closed because last code inspection problem was fixed by @slimslenderslacks when they pushed 82b5b98.


Refactoring Code

This shall clean a lot of redundant code.
Remaining:

Tests for models LeNe, ModLeNet, NIN and Shallow

@Het-Shah and @NeelayS should I remove the teacher and student from orignal.

@Het-Shah and @NeelayS should I remove the teacher and student from orignal

yea seems like we should remove it to me.

Maybe we should move it another independent class. It's a proper method in itself, though it primarily introduces a loss metric only.

Het, I see self.loss in BaseClass assigned but is not used except in orignal.

Het, I see self.loss in BaseClass assigned but is not used except in orignal.
Initially i was intending to keep original inside BaseClass then changed my mind. Doesn't matter i guess we can move it out of BaseClass.

@avishreekh is documenting the BaseClass, better if she changes, this will avoid merge conflicts if she has already started work.

Yea BaseClass we can change it easily later on.

Merging this.


wip: convert remaining legacy states

The migrations run through locally and look fine to me but when I run frontend locally the migrated content throws utf8-errors.

@MoeHome BTW I did a force push -> So you need to remove your last commit in order to be able to pull


Prepush Mocha Tests On Protected Branches

I don't fully understand from the docs how to make custom hooks so I may be missing something obvious. Ultimately I'd like to run npm run mocha on prepush on the protected branches (I'm not sure if this is supported?). ForbiddenBranches and Standard work as expected however I can't get mocha to work. I suspect it's because it's not one of the defaults provided by overcommit. Executing overcommit -r gives me the following error:
/Users/user/.rvm/gems/ruby-2.2.1/gems/overcommit-0.33.0/lib/overcommit/hook_signer.rb:39:in`hook_path': Hook must specify a `required_executable` or `command` that is tracked by git (i.e. is a path relative to the root of the repository) so that it can be signed

My package.json:
"mocha": "./node_modules/.bin/mocha --reporter spec",
"test": "npm run mocha"

My .overcommit.yml:
PreCommit:
  ForbiddenBranches:
    enabled: true
    required: true
    quiet: false
    description: 'Check for commit to forbidden branches (master, develop)'
    branch_patterns: ['master', 'develop']

  Standard:
   description: 'Check JS Standard Style...'
   enabled: true
   required: true
   quiet: false
   required_executable: 'standard'
   install_command: 'npm install -g standard'
   exclude: &default_excludes
      - 'server/node_modules/**/*'
      - 'vendor/**/*'

  Mocha:
    description: 'Running Mocha tests...'
    enabled: true
    required: true
    quiet: false
    required_executable: './node_modules/mocha/bin/mocha'
    install_command: 'npm install -g mocha'
    command: ['npm', 'run', 'mocha', '--']

Hey @AlexDar,
To clarify overcommit --run executes your pre-commit hooks, not pre-push hooks (though I think you meant pre-commit when you said "prepush").
Assuming that is the case, remember that required_executable needs to be the entire command, since in the context of a hook run we are passing any arguments/STDIN that are passed by git into your script.
Therefore you need to have a helper script (with executable permissions):
# script/my-mocha-script
#!/bin/bash
npm run mocha --

...and then in your .overcommit.yml:
Mocha:
    ...
    required_executable: './script/my-mocha-script'

Hope that helps.


[Chore]: Backfill tests for   /whoami

Background
We have some test coverage, but some test are missing
Action to take

When an empty auth header is padded It returns 401 Unauthorized

This one if a subset of #483


Clarification that Browser Version is needed for browserslist entry needed

It's not clearly stated, that every browser entry needs also either a percentage or a version to be included.
I thought of including Firefox only to have all possible -moz browser vendor prefixes included.

I can add note to Queries section.

BTW, why you need all -moz- prefixes?

The question isn't why, but why not? :)
In contrast to default > 1%:
Why should I exclude possible 0.5% of my visitors (which at 100.000 visitors might be still up to 500 people) from nicest experience -- just in order to save 2KB of a 70KB CSS stylesheet? It should be easily doable and an option for the devs.

Because main idea of Auutoprefixer is to add only actual prefixes. You should not need Can I Use data to insert all possible prefixes.

Why not? Because of unreliability of Can I Use data? Works well for me, if I use Firefox > 0% and saves me enormous amount of work.

Because your CSS is bigger without any logical reason.

Use Firefox > 0.
Firefox > 0% have no sense. Queries section doesn’t have this query.

I layed-out my reasoning above, 2KB in 70KB CSS file size. That's a trade-off I'm absolutely willing to make for 500 people. No worries, I'll save the 2KB at compressing my image files to the fullest.

This 2KB has no reason. Does any of this 500 users use Firefox 1? Does your JS even work with Firefox 1?

Look for example into CSS linear-gradients
You've got (Firefox only) 0.5% share of all browsers globally with -moz prefix (w. Chrome's prefixed it's already over 1% of all visitors). Why should I lock them out from better experience? Just to save 2KB? Especially if I don't have to invest work, because Autoprefixer with browserslist does that for me?
And yes, I try to provide a non-JS functional version with all the contend and maximized CSS-only design to be consumed by any browser (remember Any Browser campaign back in the days with sites just designed for IE).

@ai Do you still plan to put a note into queries section?

We already has a list of possible queries abd there is no version-less query.
But small note is not difficult, maybe I really should.

It might be an edge-case, but some (including me) would appreciate it.

Like this: 098a4d9
Maybe you can fix my English?


Support YOLOv9-T, YOLOV9-E

Feature Description
The original YOLOV9 code also supports YOLOv9-T and YOLOv9-E. When do you plan to support that as well for this repository?
Thank you very much for providing YOLOv9 and YOLOv7 with MIT licence!

Guten Tag!
I have already added this request to the to-do list in commit 1cee7621a6f8eaf26fe1c1d31790af5bbbe41b15. I will implement both models after we support the segmentation task.
Mit freundlichen Grüßen,
Henry Tsui


fix duplicate slash shopware icon font path

The default value in _variables/typography.less has a trailing slash, but another slash is concatenated in _components/icon-set.less.
Remove the trailing slash in _variables/typography.less For consistency with @OpenSansPath in the same file.

1. Why is this change necessary?
"Wrong" path in compiled css file.
In some cases, when the site is served via https, the double slash in the middle of the path triggers the protocol downgrade prevention (which seems to be a bug in some older chrome versions).
2. What does this change do, exactly?
Remove the trailing slash in @font-directory to fix the concatenated path in _components/icon-set.less
3. Describe each step to reproduce the issue or behaviour.
Search for the @font-face definition in the compiled css of any Shopware installation, e.g.: https://www.shopwaredemo.de/web/cache/1531139832_619fa108cec94b2467af3d2b6daf6eec.css
4. Please link to the relevant issues (if any).
/
5. Which documentation changes (if any) need to be made because of this PR?
It may be necessary to place a note in the upgrade instructions for people that use the @font-directory in their own themes derived from the Responsive theme and depend on the trailing slash.
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-22679
Please use this issue to track the state of your pull request.


Add missing Gemini logo

Test plan

having dot com account signed in
review the available llms dropdown
expected: Gemini models have the icon

Preview:

(cc: @danielmarquespt )


e2e: rte: avoid hardcoded data

Don't hardcoded data in the tests to make it easier
to consume them in other projects and to make them less fragile.
Signed-off-by: Francesco Romani<EMAIL_ADDRESS>

/lgtm


Make concise

Describe what this PR does / why we need it
Removes unnecessary words
Does this pull request fix one issue?
NONE

Codecov Report

Merging #401 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   38.95%   38.95%
=======================================
  Files         209      209
  Lines        5370     5370
  Branches      554      554
=======================================
  Hits         2092     2092
  Misses       3129     3129
  Partials      149      149

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc01277...b0c1eb3. Read the comment docs.


More intuitive URLs for search strings

This is a low-priority enhancement.
I love the linked searches found in item details for People. Example: https://patterns.smartchicagoapps.org/search/index?adv=1&device_description=iPhone+4
It would be nice if that URL was something like https://patterns.smartchicagoapps.org/search/device=iphone+4

Issue was accidentally closed due to a commit message from BlueRidge closing one of their issues. https://github.com/smartchicago/kimball/commit/764115872829e753b13f85fec3f268b4a00717b0


Turn restrictions layer

Turn restrictions are essential for a correct routing. Please, consider adding a new layer (like the "QA issues" or "Map features from Mapillary" ones) to allow visualizing all turn restrictions (or at least disallowed turns) on the map view, so the mapper can add the missing ones or correct the wrong ones.
This new turn restrictions layer could show the restrictions as icons in a similar way as the "Map of Turn Restrictions by Zartbitter" does:

Currently, to view the turn restrictions in iD the mapper must click on each intersection node, one by one, or leave the iD editor to search the area in a 3rd party tool (assuming the user know the existence of it).
Thanks.

Turn restrictions are already shown left of the map when you select the Node of a crossing:

Turn restrictions are already shown left of the map when you select the Node of a crossing:

Turn restrictions are already shown left of the map when you select the Node of a crossing
Hi @manfredbrandl , yes we can visualize restrictions clicking on each intersection node. But what I proposed is to add a new Layer (the same kind as the QA or Mapillary layers) that would show all turn restrictions on the map view. Something like as the "Map of Turn Restrictions by Zartbitter" does:

Turn restrictions are already shown left of the map when you select the Node of a crossing
Hi @manfredbrandl , yes we can visualize restrictions clicking on each intersection node. But what I proposed is to add a new Layer (the same kind as the QA or Mapillary layers) that would show all turn restrictions on the map view. Something like as the "Map of Turn Restrictions by Zartbitter" does:

But you already have them on this map. If you want to edit a specific restriction relation, you have click and copy its id and paste in iD.
A map screen in iD is very small and zooming it out will download more data and iD will become slow.

But you already have them on this map. If you want to edit a specific restriction relation, you have click and copy its id and paste in iD.
A map screen in iD is very small and zooming it out will download more data and iD will become slow.

But you already have them on this map. If you want to edit a specific restriction relation, you have click and copy its id and paste in iD.
A map screen in iD is very small and zooming it out will download more data and iD will become slow.

Hi @maro-21 , Turn restrictions are essential for a correct routing and not every iD user know the existence of this external "Map of Turn Restrictions" that help to visualize them on the map.
Also, the user experience of having an integrated layer en iD is a lot different from using external tools. Or do you think that it would be better to remove QA and Mapillary layers from iD because the have their own external maps?

But you already have them on this map. If you want to edit a specific restriction relation, you have click and copy its id and paste in iD.
A map screen in iD is very small and zooming it out will download more data and iD will become slow.

Hi @maro-21 , Turn restrictions are essential for a correct routing and not every iD user know the existence of this external "Map of Turn Restrictions" that help to visualize them on the map.
Also, the user experience of having an integrated layer en iD is a lot different from using external tools. Or do you think that it would be better to remove QA and Mapillary layers from iD because the have their own external maps?

Actually a iD turn restriction layer would be nice. Maybe for long run, and for short iD could maybe start with turn restriction validation, e.g. similar how user:Zartbitter's tool does it.

Actually a iD turn restriction layer would be nice. Maybe for long run, and for short iD could maybe start with turn restriction validation, e.g. similar how user:Zartbitter's tool does it.

Or do you think that it would be better to remove QA and Mapillary layers from iD because the have their own external maps?

I make a lot of edits in iD but I almost never use KeepRight, Osmose and Mapillary layers :)
It's much more easier to use QA tools on their websites. Switching them on everytime I run iD is annoying.

Or do you think that it would be better to remove QA and Mapillary layers from iD because the have their own external maps?

I make a lot of edits in iD but I almost never use KeepRight, Osmose and Mapillary layers :)
It's much more easier to use QA tools on their websites. Switching them on everytime I run iD is annoying.

Turn restrictions are essential for a correct routing ...

iD isn't used for routing, so turn restrictions would only need visualized to help users map, not route.

... not every iD user know the existence of this external "Map of Turn Restrictions" that help to visualize them on the map.

I don't think most iD users ever create a relation at all, much less care (for lack of better term) that turn restrictions exist.
iD is meant to be a simple OSM editor that is shown to all incoming potential editors, and (I think) isn't trying to merge all OSM tools in one place.

iD isn't used for routing, so turn restrictions would only need visualized to help users map, not route.

Of course! The idea is to help mappers find missing or wrong disallowed turns to fix them.

I don't think most iD users ever create a relation at all, much less care (for lack of better term) that turn restrictions exist.

iD users can create turn restrictions with a few clicks, without knowing what a relation is.
Due to its simplicity, I prefer to add turn restrictions with iD rather than JOSM.
In fact, I realized about the need of this layer while adding turn restrictions in the city where I live.

iD is meant to be a simple OSM editor that is shown to all incoming potential editors, and (I think) isn't trying to merge all OSM tools in one place.

This new layer would be disabled by default. So new editors wouldn't notice it until they explore the layers tab.

My point is that the vast majority of iD users do not create relations, intentionally or not, and so will not use this tool. It seems like it works great as a standalone site, so I don't think it's worth spending developer time to recreate something that a handful of people might use, but that already exists somewhere else. The devs may think differently, this is just my thinking.
An alternative might be to get Zartbitter to add an aerial imagery layer to the site.

#6616 proposes a “lenses” feature where you could select turn restriction highlights as one of several alternative ways to style the map canvas.

#6616 proposes a “lenses” feature where you could select turn restriction highlights as one of several alternative ways to style the map canvas.

Great idea! Thanks for pointing this out.


feat: multi-chain walletconnect v1

Description
Updates the wallet connect v1 implementation to support all EVM chains that Wallet Connect V1 and our Native wallet supports (Ethereum, Avalanche, BNB Chain, Optimism, and Polygon).
Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
N/A, though it might prove useful as a fallback for foxatars on mercle, if needed.
Risk
Testing
We can't currently test this on https://app.mercle.xyz/shapeshift due to an wagmi
issue in their implementation.
It also seems the current state of their app is a partial implementation of Wallet
Connect V2, so it can't be tested right now anyway.
We can, however, use OpenSea to confirm this works:

Go to https://opensea.io/
Connect via WalletConnect (it'll use a WalletConnect V1 URI), which means we ca
n only have one chain connected at a time
It'll be connected to Ethereum by default. Clicke the wallet balance in the top
right, click "Switch Chain", then select a chain that we support on the Native Wa
llet (Ethereum, Avalanche, BNB chain, Optimism, or Polygon)
Ensure that the connected chain in the ShapeShift app updated
Ensure that we can sign transactions on the new chain. For a cheap NFT to buy, try something like https://opensea.io/assets/matic/0xba6666b118f8303f990f3519df07e160227cce87/8 on Polygon.

Engineering
☝
Operations
☝
Screenshots (if applicable)
N/A

Current dependencies on/for this PR:

develop

PR #4590   👈

This comment was auto-generated by Graphite.


feat: borsh and json schemas support

ping @danlehmann.

Thanks for the contribution!
I'll work on reviewing this (have to learn about borsh first). Will try to get back asap

@danlehmann about tests. I tested that arbitrary ints work same as native primitive ints, minus some well know diff.
hence I tested layout, but in the way that I did not plug exact binary values.
this approach allows to extend these tests to property tests and doing meta tests over all serdes/schemas option.

I'd like to have full binary tests for these. Right now, there are many incorrect implementations that would pass those tests.
However, we can merge and I'll work on the test in a follow-up. Please give me a day or two

This patch didn't actually build (see https://github.com/danlehmann/arbitrary-int/actions/runs/10065181794/job/27823714420)
Working on a fix now

Reworked things somewhat: https://github.com/danlehmann/arbitrary-int/pull/45

@dzmitry-lahoda Please take a look at https://github.com/danlehmann/arbitrary-int/pull/45 . That adds a lot of test coverage, removes the allocation in deserialize and simplifies serialize.
Review appreciated.


Validate client authorized keys at ssh proxy

This validates client authorized keys at ssh proxy instead of at the host. It rejects "bad" clients on the server. It also moves session id generation to the server to avoid id collision.

cc: @staaldraad


[useSWRMutation] onSuccess is NOT triggered after reset()

Bug report
Description / Observed Behavior
In my scenario, I'm using useSWRMutation with onSuccess callback to update a post. If a specific error returns, I will show a Retry modal.
Closing this modal by Cancelling or Retrying will reset() the error and trigger() mutation again.
However, after reset -> trigger, the request is still sent but onSuccess is not called back.
If I don't reset error state, or call trigger asynchronously, everything works fine.
reset()
setTimeout(() => {
  trigger()
})

Expected Behavior
onSuccess should be called after a successful trigger
Repro Steps / Code Example
N/A
Additional Context
SWR 2.0.0.

Sorry, it only happens on my project, I will investigate the root cause first and re-open this if needed.