How to reuse flags/aliases in multiple commands

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
I want an easy way to share common flags and aliases across multiple commands with proper type checking.
Describe alternatives you've considered
I have tried the following, which seems to work pretty well, but only when I export the TypedCommandFlagParameters type (which is currently not exported).
Define the base flag interface and definition:
// common-flags.ts
export interface CommonFlags {
    myFlag: boolean;
}

export const commonFlagsDefinition: TypedCommandFlagParameters<Readonly<CommonFlags>, CommandContext> = {
    flags: {
        myFlag: {
            kind: 'boolean',
            brief: 'whatever',
            default: false,
        },
    },
    aliases: {
        f: 'myFlag',
    },
};

Then extend the common interface and spread the definition into the command builder:
// command.ts
import { type CommonFlags,  commonFlagsDefinition } from './common-flags';

export interface MyCommandFlags extends CommonFlags {
    myRealFlag: boolean;
}

export const myCommand = buildCommand({
    loader: async () => import('...'),
    parameters: {
        flags: {
            ...commonFlagsDefinition.flags,
            myRealFlag: { ... }
        },
        aliases: {
            ...commonFlagsDefinition.aliases,
            r: 'myRealFlag',
        },
    },
});

Is there a better way or a pattern to use to achieve the same?
Additional context
None

For your use case I think you could use the currently exported type FlagParametersForType to come up with a type of the config object for your CommonFlags.
export const commonFlags: FlagParametersForType<Readonly<CommonFlags>> = {
    myFlag: {
        kind: 'boolean',
        brief: 'whatever',
        default: false,
    },
};

But yes you're right that it would be easier to define this with the TypedCommandFlagParameters all at once but that isn't exported. We should change the library to export that type (along with the Aliases) type.

Yea, I've tried with the FlagParametersForType type before but that's only for flags and not aliases as well. I think there was also some kind of error when merging that into the final command, but I can't remember.
Exporting TypedCommandFlagParameters would be sweet. Thanks!
For now I just copied the type and other needed types to a local file and use that.


Saving Plivo's HTTP response.

Thanks for this repo!
I am thinking about upgrading my current custom plivo sms code in my Larvel app with this repo and Laravel 5.3 notifications. However one thing I currently do is record message ids that are returned by plivo's HTTP responses.
Can you think of a way to get the response out to a layer I can interact with it?
I was thinking about this:

In PlivoChannel.php around line 56 save the $response to a public property.
Using notification events https://laravel.com/docs/5.3/notifications#notification-events
I could access $event->channel->response;

Not sure if there are problems with this thought process I'm not seeing.
Thanks for your thoughts.

👍🏼  I can have a go when I get the chance. Alternatively, you can try it out and create a pull request if it works for you.

I would love the opportunity to contribute. I'm thinking I won't have time to work on this for a few days. I'll try to make a pull request within a week or so. :pray:

Turns out the channel property is a string not the actually channel object. Saving a property on the channel wasn't the right solution. However, the NotificationSent event already has a response property. Pull request #14 adds support for this.


loading icon/spinner placement and hide

I found two issues that affect my "inner" zoomType code.

The loading icon (spinner) does not appear on top of the image, instead it appears below. I had to add "top:0px;" to line 1278, for proper placement.

After switching between gallery images for several times, multiple loading icons appear underneath the images while they load. It seems like they are never removed. The line 1279 creates loading icons, but they are never remove()'ed from the DOM, they are only hidden at line 1490. To fix this, I added a class to the loading icon object, and use .remove() within donecallback.

Hi again, I have not really use the gallery besides the demo example, but the corrections makes sense, would you also like to create a PR?

I have added the code for the issue 1, and add a class for issue 2.
Please take a look a the commit: https://github.com/igorlino/elevatezoom-plus/commit/81a98a76520571da0fd0cbae5741048321a608f7
Could you please point where you are adding the jquery remove ? (the line and and its code)


Bottom navigation bar on mobile (PWA) doesn't stick to bottom when scrolling up

Not sure what happened but I wasn't able to reproduce it. No issue when scrolling down.

Hello, I have tried reproducing this bug and was not able to. Could you please share more details on your details, such as screen resolution, user agent, browser etc...?

I think only happens on Safari iOS but not sure. But I can say it does happen on Safari iOS.


[image_picker] pickVideo returns jpg

Description
Fixes issue when we pick a video using image_picker then instead of the file type from original path it return jpg
Related Issues
flutter/flutter/issues/52419
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the [Flutter Style Guide].
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the [CLA].
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Is this related to https://github.com/flutter/plugins/pull/2821? They seem similar?

Closing as duplicate of https://github.com/flutter/plugins/pull/2821. Thanks for the PR, @ponnamkarthik, keep them coming!


Maintain dockerized bosun working

Translate configuration in docker to toml
Send supervisord logs to stdout
Add more information to startup error messages when configuration or rules fail to be read

I have a PR at #1915 that includes other changes like updating HBase. I grabbed your other commits though and will try and merge that this afternoon.

Ok, thanks!


Add a vscode.TextEditorCursorStyle.None property or similar

This might sound strange, but I'd like to be able to programmatically hide the text cursor entirely.
I'm the author of an extension that provides a VIM/Helix -esque way of navigating a text file where the UI is based entirely on selections, and the additional presence of a cursor actually makes the UI more confusing, so I'd like to be able to hide it in certain modes.
I'm currently using vscode.TextEditorCursorStyle.UnderlineThin as it's the least visible cursor, but it's still rather distracting since it's usually blinking as well.
I'd appreciate the ability to explicitly set the cursor to "no cursor" or, alternatively, if anyone knows a way I can do this by other means I'd be grateful (perhaps setting the colour to transparent? I don't currently know of any way to set the CSS properties for the text cursor though).
Many thanks

Yep, I would like to see this too. Vim/helix modes creates a fake cursor during selection mode, but the real cursor remains visible which is really distracting:
Kooha-2024-04-26-23-09-36.webm
Is it possible to make the caret visible somehow? I tried to change the theme of the cursor to a transparent color via the extensions API, but this requires writing to the config file which is really non-ideal. Surely there's a hack for this right?

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


debug log level

Using stern to review all postgres-exporter logs - i can see little.
What is the best way to increase debug log level? can you add it to the README.md
Thanks
Chanan

adding to the deployment file:
command: [ "./postgres_exporter","-log.level","debug" ]


Add CSV output to analysis-stats

For easy diffing, to find changes in unknown types / type mismatches.

bors r+


"charCounter" error

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

set  charCounter to true

This issue is not reproduced.
Please explain more detail.

After importing dynamically and using the editor in my nextjs app, the moment I load the page, I get that error.
It only happens when you set "charCounter" to true or set "maxCharCount", which sets the former to true anyways.

Show us the code that created the editor like options

`import 'suneditor/dist/css/suneditor.min.css';
import type SunEditorCore from 'suneditor/src/lib/core';
const SunEditor = dynamic(async () => await import('suneditor-react'), {
ssr: false,
});
...
...
...
const [charCount, setCharCount] = useState(0);
const editor = useRef();
const getSunEditorInstance = (sunEditor: SunEditorCore): void => {
editor.current = sunEditor;
};
...
...
...
<SunEditor
autoFocus={false}
height="110px"
setOptions={{
maxCharCount: maxChar,
buttonList: [['bold', 'italic', 'underline', 'strike', 'align', 'list', 'lineHeight', 'outdent', 'indent']],
}}
getSunEditorInstance={getSunEditorInstance}
onChange={(content: string) => {
onChange(content);
}}
onInput={() => {
setCharCount(editor.current?.getCharCount() ?? 0);
}}
/>
`

Sorry for the late reply.
This issue is resolved maybe latest version.

@JiHong88 @Horlamedhey
i am facing same issue. any solution?


Is there a shared/managed app insights service?

Our team is finally looking into trying this out. Do you know if the pixel server require us to run our own appinsights service, or if there is a managed option we can use?
cc: @vizhur @rastala @danielsc

@weshaggard @chidozieononiwu Can you help answer this please?

@scbedd could you help with this question?

@j-martens AppInsights by it's very nature is the managed option.
Instructions on How to Create
Did you glance through the readme section talking about AppInsights? Which piece should I enhance so that this is clearer to the user?

@rastala - does this help? Can you set this up now?
Thanks @scbedd Scott. :-)

@swinner95

@swinner95 I'm closing this issue. You got it :)


Bounce back issue

Hi
This plugin works as expected, however, when a user submits a ticket etc he receives a bounce back email when on used the pipe feature in whmcs to import the ticket.
The ticket etc gets opened and the bounce back looks as following;
This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its recipients. This is a permanent error. The following address(es) failed:
pipe to |/home/user/public_html/whmcs/crons/pipe.php
generated by<EMAIL_ADDRESS>The following text was generated during the delivery attempt:
------ pipe to |/home/user/public_html/whmcs/crons/pipe.php
generated by<EMAIL_ADDRESS>------
{"status":1,"request":"4966731a-1965-4b27-b2e2-6e904ece3c61"}
Any ideas?

Hi @blogbytes
I believe this is caused by curl printing the Pushover API response by default. I've made a change in 835675ac5d356d3239d7ed6a10e84cb5d41a3ac3 which should fix this for you. Could you please apply the change and let me know?
Thanks
Mike

Thanks Mike, that did the trick.
Great plugin, works well :)


Minor grammar fixes

Great project! I've just fixed up a few typos / bits of grammar that stood out while I was reading through.

thank you so much @thomshutt your efforts are much appreciated! 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏


Fix/white spaces

Description
This Pull Request solves the bug of removing white spaces in the output
Checklist

[x]  I have reviewed and followed the project's CONTRIBUTING guidelines.
[x] I have tested my changes thoroughly.
[x]  My code follows the project's coding style and conventions.
[x] My commits adhere to the Conventional Commit format.
[x] I have added necessary documentation or updated existing documentation.

Related Issues
#20
Additional Context
Is there anything else that the reviewers should know? Any additional context or information that could be helpful.
Screenshots (if applicable)
Before:

Now:

Thank you for contributing @EusebioSimango


Add support for proxies and other requests parameters

HTTP / HTTPS proxies to use can be specified via config file
or when creating a Session. Other arguments recognized by requests can be
passed when creating a Session as well, and will be used with every request.

The code as-is will not use environment variables HTTP_PROXY and HTTPS_PROXY, as using prepared requests and send explicitly avoids that. We could just add a session.merge_environment_settings() and call it a day though.

I would think the best solution would be to drop prepare_request completely from our session.data_request, and just call res = self._session.request(...) to do everything?  That should both fix this and move us closer to the way the docs say we should be using the library?

@goranfr Can you review and merge if you agree?

Looks good to me.


Allow optional max_depth to error when RE is called in a function

This PR does not change the default behavior of the RunEngine.
But if RE.max_depth is set (say, in the beamline config), RE.__call__ will check the current stack depth and error out if it think it is being called from inside a function. The error message includes the URL of the specific docs section addressing why this is harmful and what to do instead.
There is no good non-null default for max_depth because Python and IPython operate with different base stack depths. And I would guess that different versions of IPython vary in this respect.
In the built-in interpreter:
>>> RE = RunEngine({})
>>> RE.max_depth = 2
>>> RE([])  # allowed
[]
>>> (lambda: RE([]))()  # disallowed
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 1, in <lambda>
  File "/Users/dallan/Documents/Repos/bluesky/bluesky/run_engine.py", line 527, in __call__
    raise RuntimeError(text)
RuntimeError:
RunEngine.max_depth is set to 2; depth of 3 was detected.

The RunEngine should not be called from inside another function. Doing so
breaks introspection tools and can result in unexpected behavior in the event
of an interruption. See documentation for more information and what to do
instead:

http://nsls-ii.github.io/bluesky/plans_intro.html#combining-plans

In IPython:
In [2]: RE = RunEngine({})

In [3]: RE.max_depth = 11

In [4]: RE([])  # allowed
Out[4]: []

In [5]: (lambda: RE([]))()  # disallowed
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
<ipython-input-5-d35a0876b5a7> in <module>()
----> 1 (lambda: RE([]))()

<ipython-input-5-d35a0876b5a7> in <lambda>()
----> 1 (lambda: RE([]))()

/Users/dallan/Documents/Repos/bluesky/bluesky/run_engine.py in __call__(self, plan, subs, raise_if_interrupted, **metadata_kw)
    525             if depth > self.max_depth:
    526                 text = MAX_DEPTH_EXCEEDED_ERR_MSG.format(self.max_depth, depth)
--> 527                 raise RuntimeError(text)
    528
    529         # If we are in the wrong state, raise.

RuntimeError:
RunEngine.max_depth is set to 11; depth of 12 was detected.

The RunEngine should not be called from inside another function. Doing so
breaks introspection tools and can result in unexpected behavior in the event
of an interruption. See documentation for more information and what to do
instead:

http://nsls-ii.github.io/bluesky/plans_intro.html#combining-plans

Closes #569

Current coverage is 82.94% (diff: 100%)

Merging #594 into master will increase coverage by 0.08%

@@             master       #594   diff @@
==========================================
  Files            20         20
  Lines          4154       4163     +9
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3442       3453    +11
+ Misses          712        710     -2
  Partials          0          0

Powered by Codecov. Last update 023719b...33f7fe9


Updated Initial setup

This updates the base template to have a few more defaults to make it easier.
It adds in babel to compiles the js to work with Node 6.10 since that's what Lambda functions support. This will prevent weird bugs from happening that would cause a skill to fail because of new syntax.
The majority of voice skills shouldn't try to fit all their handlers into 1 file so instead of showing a base example of having simple intents in 1 file I put them in separate files so users can see how to organize their intents.
Instead of having a index.js and a index_lambda.js I removed the index_lambda.js file and created a webhook.js file that pulls in the index.js file so it doesn't look like you have to duplicate your code to make this work.
Instead of using node index.js to run the webhook I added a npm start command which uses nodemon  to build the app folder and run the webhook for you.
Since ngrok is small I went ahead and added it as a dev dependency and added a npm run tunnel command that will run it for you.
I added zip support since Alexa supports uploading a zip file.

Hi @tjbenton, thank you, these are great suggestions and a very valuable addition to the Jovo Framework! We're also thinking about how to set up the structure for more complex voice apps. However, we believe that for someone building their first voice app, this might be a little overwhelming.
We're currently creating a repository with templates for getting started, and this would be a great starting point for more experiences Jovo developers. We'd love to have you commit these changes into our templates repo when it's available (will let you know!). Until then, we would love to link to your fork as a community contribution and point experienced developers to it.
Some of these features would also be very interesting additions to our jovo-cli. Could you maybe drop me a note to<EMAIL_ADDRESS>so I know how to reach you? Would love to set up some time to discuss some of the features. We're also looking to expand our network of experienced Jovo developers for client projects.
Thanks again, looking forward to hearing from you!
Jan

Thanks a lot @tjbenton! We just updated the Jovo Framework to 1.0 and added many things to the sample app that should solve the problems you had: one index.js for both Lambda and a Webhook, the jovo-webhook that replaces ngrok, and a $ jovo deploy --target lambda command which allows people to zip and deploy their code to AWS Lambda.


Align to the right instead of left

I'm trying to get the sidebar to appear on the right instead of the left. I have essentially changed all the css properties from left -> right and right -> left.
It works for the most part, but while in mobile view the content is not animated, and 'pops' to the left when the menu is opened. How could this be fixed so the animation works correctly?

Basically change the margin-left stuff to margin-right stuff and move the sidebar element below the the page content in the HTML.


/bin/sh: 1: ./build_mme: not found

When Build MME Image，Execute the command “docker build --target oai-mme --tag oai-mme:production                --file component/oai-mme/docker/Dockerfile.ubuntu18.04 .”
Prompt error：
Step 13/39 : RUN ./build_mme --check-installed-software --force
---> Running in 82ed5e2a5b1d
/bin/sh: 1: ./build_mme: not found
The command '/bin/sh -c ./build_mme --check-installed-software --force' returned a non-zero code: 127
How to solve it?

Me too
/bin/sh: 1: ./build_mme: not found
have you solved it ?

Me too
/bin/sh: 1: ./build_mme: not found
have you solved it ?

NO，you can try reinstall the system of ubuntu.

@WT4444 @lixiaofan182
I have the same problem.
Have you solved it?
Does reinstall Ubuntu system can solve the problem?

Me too
/bin/sh: 1: ./build_mme: not found
have you solved it ?

NO，you can try reinstall the system of ubuntu.

Hello sir, I met the same question too. Did you solved this problem? I feel very confused and trapped for serveral days.
Would you mind taking some time to help me or give some suggestions?
Thanks a lot!

I also have the same problem.
:~/openair-epc-fed/component/oai-mme/scripts$ /bin/sh -c ./build_mme --check-installed-software --force
Build type is Debug
Architecture is x86_64
git found: /usr/bin/git
NETTLE VERSION_INSTALLED  = 3.4
NETTLE_VERSION_MAJOR = 3
NETTLE_VERSION_MINOR = 4
CMake Error at /home/iristestbed/openair-epc-fed/component/oai-mme/build/CMakeLists.txt:870 (message):
LIB LFDS not found, please install it
Call Stack (most recent call first):
CMakeLists.txt:39 (include)

I have tried with a couple of different  UBUNTU low-latency images (all latest dist-upgrade), but I got the same error.
This looks like a bug to me as that library is missing.
To solve this particular problem i had to run the following steps:
wget https://liblfds.org/downloads/liblfds release 7.1.0 source.zip
mv 'liblfds release 7.1.0 source.zip' liblfds_source.zip
unzip liblfds_source.zip
cd ~/liblfds/liblfds7.1.0/liblfds710/build/gcc_gnumake
make
cd ../../bin
sudo cp liblfds710.a  /usr/local/lib/
This set of steps solved that particular error.

you also need to run the following steps:
sudo cp ~/liblfds/liblfds7.1.0/liblfds710/inc/liblfds710.h /usr/include
sudo cp -r ~/liblfds/liblfds7.1.0/liblfds710/inc/liblfds710 /usr/include/

Run the following commands by appending component/oai-mme (remove the --build-arg EURECOM_PROXY=".." if you don't need to)
docker build --target oai-spgwc --tag oai-spgwc:production \
               --file component/oai-spgwc/docker/Dockerfile.ubuntu18.04 \
               --build-arg EURECOM_PROXY="http://proxy.eurecom.fr:8080" component/oai-mme

Instead of
docker build --target oai-spgwc --tag oai-spgwc:production \
               --file component/oai-spgwc/docker/Dockerfile.ubuntu18.04 \
               --build-arg EURECOM_PROXY="http://proxy.eurecom.fr:8080"

Run the following command by appending component/oai-mme (remove the --build-arg EURECOM_PROXY=".." if you don't need to)
docker build --target oai-mme --tag oai-mme:production \
               --file component/oai-mme/docker/Dockerfile.ubuntu18.04 \
               --build-arg EURECOM_PROXY="http://proxy.eurecom.fr:8080" component/oai-mme

Instead of
docker build --target oai-mme --tag oai-mme:production \
               --file component/oai-mme/docker/Dockerfile.ubuntu18.04 \
               --build-arg EURECOM_PROXY="http://proxy.eurecom.fr:8080"

Run the following command by appending component/oai-mme (remove the --build-arg EURECOM_PROXY=".." if you don't need to)
docker build --target oai-mme --tag oai-mme:production \
               --file component/oai-mme/docker/Dockerfile.ubuntu18.04 \
               --build-arg EURECOM_PROXY="http://proxy.eurecom.fr:8080" component/oai-mme

Instead of
docker build --target oai-mme --tag oai-mme:production \
               --file component/oai-mme/docker/Dockerfile.ubuntu18.04 \
               --build-arg EURECOM_PROXY="http://proxy.eurecom.fr:8080" .

thanks a lot
It worked, I did the same for SPGW C and SPGW U

I am having the same problem, when building MME from dockerfiles:

I am having the same problem, when building MME from dockerfiles:


Downloading doesn't work after unlocking ports

I'm created software to updating content on some devices that basing on this library. There was no problems at all but when I delivered it to the clinet it turned out that their WIFI have some limitations. So they wanted to know what protocols and ports needs to unlock to makes it worked. So i give them respond that I need unlocked TCP and UDP protocols and 6881-6889 (BitTorrent traffic) and 6969 (tracker port). They unlocked it but it still doesn't work (downloading stuck on 0%). Am I missing something or this ports are wrong ?

The library uses these ports that you're mentioned. I don't know why the download can be stuck. Maybe some logs may be helpful.


{tor,mullvad}-browser: fix font config patch

Description of changes
Updates the sed command to patch the fontconfig, which didn't match after upstream changes in 13.0.14.
This in turn fixes #307095 that caused usage of the file picker to crash the browser.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Works great, thank you!

This does work, but can we use substituteInPlace instead (with --replace-fail)? This will both be easier to read and will help us catch if the file changes again.


release v0.2.1

style: add emojis for changelogs too
chore(release): reliabot v0.2.1

still wrong


fix(Icon): Icon does not appear

Steps to Reproduce

Import Icon from semantic-ui-react
Put Icon tag in the code with name='home'

Expected
The Icon should appear in the screen
Result
The Icon does not appear in the screen

Make sure that you imported CSS. If it will still not work, please make a codepen.


Automatic error report

Closing because this empty. Please paste the contents of your clipboard here on Github for the next time.

If you can describe in detail the circumstances in which the error occurred, and post the information listed in relevant subsection of the Spyder Troubleshooting Guide as a comment to this issue, then please re-open.


Azure Container Apps - outbound IP

Are the outbound IPs static ("az containerapp list" and outboundIpAddresses array) for the lifetime of my ACA environment?
We are integrating with an external system and need to provide IP(s) so they can whitelist it.
I came across this message https://github.com/microsoft/azure-container-apps/issues/355 and this comment https://github.com/microsoft/azure-container-apps/issues/355#issuecomment-1300619829.
Thank you!

@fritzfs
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!!

@PesalaPavan thank you!
https://learn.microsoft.com/en-us/azure/container-apps/networking?tabs=workload-profiles-env%2Cazure-cli#ports-and-ip-addresses
https://learn.microsoft.com/en-us/azure/container-apps/vnet-custom?tabs=bash&pivots=azure-portal

@fritzfs
Thanks for your feedback! We will investigate and update as appropriate.

@fritzfs
Thank you for bringing this to our attention.
I've delegated this to content author @cachai, who will review it and offer their insightful opinions.

@fritzfs Did you ever get an answer to this (here or otherwise)?
@PesalaPavan @ManoharLakkoju-MSFT I have the same issue-- our ACAs make requests to an external system and we need to whitelist their IPs (either a range, or somehow assign a static outbound IP).

Thanks for your feedback and your contribution to Azure docs.
Feedback for this repository is moving away from GitHub to a system specific to the Microsoft Learn platform. Issues for this repository will soon be disabled, and additional comments from GitHub will no longer be possible. However, we are now tracking and triaging this issue in the new feedback system.
To learn more about our feedback systems, please see Provide feedback for Microsoft Learn content.
#please-close


Tracing through KafkaChannel

Problem
A request made to the KafkaChannel should generate traces that link the request to the subscribers. It should either use an existing Trace if present, or create a new Trace if one isn't.
The trace from the Channel to any subscribers MUST be annotated with the subscription's name.
Persona:
System Integrator
Exit Criteria
Each of the following generate a trace that includes both the incoming request and the request to any subscribers. The trace from the Channel to any subscribers MUST be annotated with the subscription's name:

A request sent to an KafkaChannel without any trace information.
A request sent to an KafkaChannel with trace information in the HTTP headers (B3 format).
A request sent to an KafkaChannel with trace information in the Cloud Event's traceparent attribute, but not in the HTTP headers.

Note that this is very similar to knative/eventing#1757

I duplicated the issue here :smile: : https://github.com/knative/eventing-contrib/issues/1139

This is solved


Create release guide for kube-scheduler-simulator

/kind documentation
/assign
We want to create a guide for how to release scheduler simulator.
the guide on scheduler-plugins: https://github.com/kubernetes-sigs/scheduler-plugins/blob/master/doc/release-guide.md

/remove-lifecycle stale

/remove-lifecycle stale

/triage accepted
Not to mark as stale.

It's created.
/close


Instant API responsiveness

When starting siad, the api should start responding in under a second. The API is capable of adding routes after it starts serving them, so this can be pretty easily achieved by spinning up the /daemon api routes immediately, and then adding the routes for the other modules as their loading finishes.
Not sure how long this will take, but it seems like a reasonably important usability change.
It does mean that the daemon itself will no longer be calling the modules.New functions, the server in the api package would.

This is less important now that startup is instant most of the time.

off the short list - also likely to require some pretty significant structural changes with regards to the relationship between siad and the api package


2.0 - Create BottomSheet

This is a tracking issue for creating a new experimental package BottomSheet
Scope: BottomSheet

Not yet available


Error message when the body of toHaveFetched has a mismatch

I have a spec that looks something like this
      expect(fetchMock).toHaveFetched(`/my/cool/api`, {
        method: 'POST',
        body: { message: 'this is incorrect', rating: 'thumbs_up' },
      });

Where the body is incorrect - so the test correctly fails, but the error message when I ran the tests output this:
fetch should have been called with /my/cool/api

Implying the API was not even called - however, this is not the case, as when I fixed the body to match the actual output, the test started passing immediately

The issue is probably here:
https://github.com/wheresrhys/fetch-mock-jest/blob/master/jest-extensions.js#L20
The error message is a catch-all for any failure


Crash on "merge" branch

Description
As an Ethereum user, I want to run Besu on Kintsugi to help so that I can help test the merge.
Specifically, I'm drafting a write-up to help people run Besu-Teku at home against Kintsugi. My goal is to promote the Besu-Teku combo, because I think it's underrated and its success can help improve Ethereum client diversity.
Besu immediately crashes on launch.
Details here
https://gist.github.com/luisnaranjo733/81f4d5396d3f93352f93f0c3e16b9f49
Acceptance Criteria
Besu should run normally against the merge testnets
Steps to Reproduce (Bug)

Clone and build Besu on the "merge" branch
Run it with the flags listed here (copied from the official merge testnet documentation)

Expected behavior: Besu should run
Actual behavior: Besu crashes - something about a missing coinbase transaction and mining (which I'm not trying to do)
Frequency: 100%
Versions (Add all that apply)
All of these details are in this Github gist

Software version: [besu --version]
Java version: [java -version]
OS Name & Version: [cat /etc/*release]
Kernel Version: [uname -a]
Virtual Machine software & version: [vmware -v]
Docker Version: [docker version]
Cloud VM, type, size: [Amazon Web Services I3-large]

Additional Information

User was including MINER in the --rpc-http-api flags, so besu wanted --miner-coinbase and --miner-enabled as well and was crashing without them.

Update:  I just tried a fresh instance of besu and it refused to launch without --miner-coinbase, but if I include it while omitting --miner-enabled it just generates a warning and proceeds.
WARN  | Besu | --miner-coinbase has been ignored because --miner-enabled was not defined on the command line.

Can confirm that adding this flag showed the same warning, and then besu just started chugging along
--miner-coinbase=0x0000000000000000000000000000000000000000
Thanks @SeaMonkey82!

Great that you found the solution!


chore: update pull request template

This hopefully fits our current work better.

I've removed that line. Let's chock it up to 'common git sense' and see how that fares. If someone doesn't know the reviewer can always hit Update Branch, so it should be fine.


NNBD: Analyzer allows inherit two interfaces with incompatible type parameters: Object? vs FutureOr, Object?  vs FutureOr<FutureOr>

Dart VM version: 2.8.0-edge.40f23c735f04433e4fc334fbd674474bd3de0f8b (Tue Jan 28 01:14:48 2020 +0000) on "linux_x64"
This issue is similar with #40453, but dart and analyzer behave in the different ways here.
The following source code declares classes X1 and X2 which inherit classes with incompatible type arguments:
import "dart:async";

class A<T>{}
class B implements A<Object?> {}

class C implements A<FutureOr> {}
class D implements A<FutureOr<FutureOr<FutureOr>>> {}

class X1 extends B implements C {}
class X2 extends B implements D {}

main() {}

This code throws two compile errors with dart and passes with analyzer.
Seems like error should be thrown in both cases.
Sample output is:

$ dart --enable-experiment=non-nullable test.dart
test.dart:9:7: Error: 'X1' can't implement both 'A<Object?>' and 'A<FutureOr>'

'A' is from 'test.dart'.
'Object' is from 'dart:core'.
'FutureOr' is from 'dart:async'.
class X1 extends B implements C {}
^
test.dart:10:7: Error: 'X2' can't implement both 'A<Object?>' and 'A<FutureOr<FutureOr<FutureOr>>>'
'A' is from 'test.dart'.
'Object' is from 'dart:core'.
'FutureOr' is from 'dart:async'.
class X2 extends B implements D {}
^
$ dartanalyzer --enable-experiment=non-nullable test.dart
Analyzing test.dart...
No issues found!

Reading the spec, I believe the analyzer is correct if the code is null-safe. (I'm not so sure if it's legacy code, though).
The check for having the same instantiation of an interface uses NORM and NNBD_TOP_MERGE:

If a class C in an opted-in library implements the same generic class I more than once as I0, .., In, and at least one of the Ii is not syntactically equal to the others, then it is an error if NNBD_TOP_MERGE(S0, ..., Sn) is not defined where Si is NORM(Ii). Otherwise, for the purposes of runtime subtyping checks, C is considered to implement the canonical interface given by NNBD_TOP_MERGE(S0, ..., Sn).

The type NORM(FutureOr) is dynamic, as is NORM(FutureOr<FutureOr<FutureOr>>).
The NNBD_TOP_MERGE(Object?, dynamic) is Object?, which means it's defined and there is no error.

The same problem is reproducible for the dynamic vs FutureOr case.

Agreeing that there is no error here, note that dart-lang/language#824 aims to make an adjustment to the definition of NNBD_TOP_MERGE. This will not change the ability of an opted-it class to have superinterfaces that differ in the ways that NNBD_TOP_MERGE eliminates, but it will make them implement a superinterface that has type argument Object? or dynamic in some situations where the current rules would yield void.

Proposed fix: https://dart-review.googlesource.com/c/sdk/+/134842


Please show your license file at this repository

I could not find the license file of this repository.
But I found MIT License at the other place.
Please add LICENSE file for MIT Licese

I've recognized this issue. My intention is that this project is under the MIT License.
I will address this issue in a few days.
Thank you for posting.


Call to undefined method: Rinvex\Tenants\Models\Tenant::create()

I am trying to create a tenant with this code:
app('rinvex.tenants.tenant')->create([
'name' => 'ACME Inc.',
'slug' => 'acme',
'owner_id' => '1',
'email' =><EMAIL_ADDRESS>'language_code' => 'en',
'country_code' => 'us',
]);
But i keep getting Call to undefined method: Rinvex\Tenants\Models\Tenant::create(). Thank you.

Tested & seems to be working smoothly, that's not expected behavior as the create method is a default eloquent method, and the Tenant model extends eloquent natively, so that's really weird! I just tested the code above & it worked for me anyway..

Oh okay. I am using it with L5.5 by the way. Thanks.

I am not sure what is wrong because it is a new project that i just setup.

Yes, tested on Laravel v5.5. Try to create a new instance explicitely like that: $tenant = new \Rinvex\Tenants\Models\Tenant(); and let me know what happens..
P.S. All of our packages now require Laravel v5.5 and PHP v7.0 at least 😉

I created a new instance and did not get any errors. And yes i am using PHP v7.0.9. Thank you.

Then that's even stranger! Try to publish config file via php artisan rinvex:publish:tenants and try again the first code sample..

I dumped it and got the object.
Tenant {#291 ▼
#fillable: array:15 [▶]
#casts: array:14 [▶]
#observables: array:2 [▶]
+translatable: array:2 [▶]
#rules: array:15 [▶]
#throwValidationExceptions: true
#connection: null
#table: "tenants"
#primaryKey: "id"
#keyType: "int"
+incrementing: true
#with: []
#withCount: []
#perPage: 15
+exists: false
+wasRecentlyCreated: false
#attributes: []
#original: []
#changes: []
#dates: []
#dateFormat: null
#appends: []
#dispatchesEvents: []
#relations: []
#touches: []
+timestamps: true
#hidden: []
#visible: []
#guarded: array:1 [▶]
#slugOptions: null
#validationErrors: null
#validating: true
#validator: null
#validationAttributeNames: null
#cacheDriver: null
#cacheLifetime: -1
}

Can you please give me the steps to follow when setting it up? Maybe i'm not following the correct steps/instructions? Thank you.

As per the docs there's only two required installation steps:
composer require rinvex/tenants
php artisan rinvex:migrate:tenants

And optionally:
php artisan rinvex:publish:tenants

https://github.com/rinvex/tenants/tree/develop#installation

I'm not sure, does a user have to be logged in?

A user must be logged in for tenants to take effect, but that has nothing to do with the creation process itself. You still have the same method not found errors after publishing configure?

Okay cool. Yes i still have the same errors.

Is there anywhere i can add a dump to see where data should be writing?

Hi @Omranic ,
I hope you are well? Regarding this same issue, if i remove ValidatingTrait from TenantsModel and also comment out some lines of code from the TenantsModel it works. Please see code that was commented out below:
    $this->setRules([
        'slug' => 'required|alpha_dash|max:150|unique:'.config('rinvex.tenants.tables.tenants').',slug',
        'name' => 'required|string|max:150',
        'description' => 'nullable|string|max:10000',
        'owner_id' => 'required|integer|exists:'.(new $userModel())->getTable().',id',
        'email' => 'required|email|min:3|max:150|unique:'.config('rinvex.tenants.tables.tenants').',email',
        'phone' => 'nullable|numeric|min:4',
        'country_code' => 'required|alpha|size:2|country',
        'language_code' => 'required|alpha|size:2|language',
        'state' => 'nullable|string',
        'city' => 'nullable|string',
        'address' => 'nullable|string',
        'postal_code' => 'nullable|string',
        'launch_date' => 'nullable|date_format:Y-m-d',
        'group' => 'nullable|string|max:150',
        'is_active' => 'sometimes|boolean',
    ]);

    static::validating(function (self $tenant) {
        if ($tenant->exists && $tenant->getSlugOptions()->generateSlugsOnUpdate) {
            $tenant->generateSlugOnUpdate();
        } elseif (! $tenant->exists && $tenant->getSlugOptions()->generateSlugsOnCreate) {
            $tenant->generateSlugOnCreate();
        }
    });

Thank you.

Well, I hope we can help you. But this issue couldn't be reproduced on any project up until now, which makes us believe it doesn't exist or maybe related to your own setup. If you can provide detailed steps on how to reproduce this issue I'll be happy to followup & fix if confirmed 🙂

Hi @Omranic ,
Great thank you. There is no other detail to provide as the details provided above is the only details available. Just one thing, after commenting out the codes provided above, i am now able to use create method to save the a tenant.


Exclude some url's from basic authentication.

Hi, I have a service with basic auth and configures to use a domain:
com.df.serviceDomain=sitebuilderqa.vmaxcompass.com
com.df.servicePath=/
com.df.users=admin:password

There is a way to exclude some urls from basic auth in the same service?, for example I need the urls /foo* and  /bar/* in the same service to be excluded from basic authentication.

I can add users param to be indexable. In that case, your labels could be:
com.df.serviceDomain=sitebuilderqa.vmaxcompass.com
com.df.servicePath.1=/foo
com.df.servicePath.2=/bar
com.df.users.1=admin:password
com.df.servicePath.3=/
com.df.users.3=admin:password

That way there would be three possible paths. Since they are evaluated sequentially, the proxy would first look for foo, then bar, and finally for /. Since foo and bar do not have authentication, they would be excluded from it.
Do you think that something like that would work for you?

Sure, would be great!

The plan changed a bit from the original idea. I added the ignoreAuthorization parameter.
The labels you could use could be:
...
com.df.serviceDomain=sitebuilderqa.vmaxcompass.com
com.df.users=admin:password
com.df.servicePath.1=/foo
com.df.ignoreAuthorization.1=true
com.df.servicePath.2=/bar
com.df.ignoreAuthorization.2=true
com.df.servicePath.3=/
...

The result would be that any request with the path that starts with /foo or /bar would not require authorization. Anything else would.
Please let me know if that fits your use case. If it does, please pull the release 1.393, try it out, and let me know whether it works as expected. If it doesn't, please reopen the issue.


Change billing statement generation to not perform heavy postgres operations

At the moment, the queries needed for generating statements are heavy operations for accounts with many transactions. Since these queries lock the transaction table, this blocks our message processing (since inserting into the transaction table is a part of processing each message). It would help if we made smaller, chunked queries to postgres (similar to our archiving task) and aggregated on the client side.

Ready for review.

This is looking good to me. The Summary/Summaries classes were quite difficult to wrap my head around though. I'm wondering if there are some doc strings that we can place to make it a bit easier to understand?

I'm wondering if there are some doc strings that we can place to make it a bit easier to understand?

Sure, will add some docstrings. Summary and Summaries was my second attempt, and I'm not convinced they are the best abstractions. Would've liked a more functional approach, but couldn't really come up with a nice solution that way. My first attempt made use of groupby a bunch of other itertools and was maybe more readable, but then I realised that a groupby would require us to first sort, which isn't something we can't do.

Docstrings added, ready for re-review.

Docstrings look good, I think it's much clearer now. :+1: when travis is happy.


Google colab tutorial - minor cleanup

Import cirq and cirq_google up top
Remove outputs
Update "Cirq documentation" link

"Authenticate and install Cirq" -> "Authenticate with Quantum Computing Service and install Cirq"

I linked to the full URL of the Cirq landing page. Let me know if there's a relative path that's more appropriate - I couldn't find the source location.
@MichaelBroughton
cc @dstrain115

These changes look good, I think we might need to keep the saved outputs for the engine components (otherwise the infra will try to run those cells). @dstrain115 .

Ty for the review. For simplicity I reverted back all the output, since the only cell without engine references is Cirq installation.


Is this MPEG Audio really dual mono; why code commented??

https://github.com/MediaArea/MediaInfoLib/blob/5971e33598884f43eee55e2c338bbf9aab32663f/Source/MediaInfo/Audio/File_Mpega.cpp#L1549
Why this code is commented? I have a file and opened some issues https://trac.videolan.org/vlc/ticket/22392
The files is here https://trac.videolan.org/vlc/attachment/ticket/22392/dest.mka is it dual mono? If yes, why ffmpeg says it is stereo? I am so confused. And dual mono somehow in VLC plays only one channel in 2.0 channels.
Some reference that you still need to play dual mono in two different channels https://sound.stackexchange.com/questions/35545/if-a-track-contains-two-channels-is-the-track-stereo
https://sound.stackexchange.com/questions/25228/0db-mono-vs-0db-stereo

Why this code is commented?

For the reason indicated in the comment you cited. If someone is interested in improving this code, I may take it.
Generally speaking, please 1 issue per issue ticket.

The files is here https://trac.videolan.org/vlc/attachment/ticket/22392/dest.mka is it dual mono?

As indicated, yes.
Something I should do 1 day is to show 2 tracks in MediaInfo for such content, as I do for another format having several contents in 1 stream (namely Dolby E), it is actually 2 tracks coded in the same stream.

If yes, why ffmpeg says it is stereo?

FFmpeg does not handle well dual mono, and don't do the difference between "L R" (Left + Right channels) and dual mono ("M M" style), "stereo" here means 2 channels, not that the 2 channels are "L R".
Note that MediaInfo does not show "L R" channel layout from your file, there is a reason (it is not "L R").

And dual mono somehow in VLC plays only one channel in 2.0 channels.

And they do correctly, VLC does the correct job: playing back only the first mono track by default, having the 2 mono tracks played by default would be ugly to hear. 1 criticism could be that they should show Mono 1 then Mono 2 when you select the channel in "Stereo mode" (bad name too) instead of misleading "Left" and "Right".
If a player plays both contents at the same time by default, this is a bug from this player, you should open an issue ticket on its issue tracker.
An addition, about your comment in VLC tracker:

FFplay of FFmpeg thinks that it is stereo. And it IS stereo. What we are arguing about?

They didn't argue that it is not a 2-channel stream. They indicated that you imagine that "2 channel" (or "stereo" in FFmpeg) always mean "L R", this is usually the case but no always. In the case of this file, it is 2-channel dual mono content.
Closing, as it is not a MediaInfo issue (and we don't use the word "stereo"), but an issue about understanding the difference between "L R" (Left + Right, same content to be played at the same time) and "M M" (dual mono, 2 actual content, not to be played at the same time).


Create install media without download

:bulb: Description
Creating install media should be (additonally) possible without download, but with previously downloaded installers.
:white_check_mark: Proposed solution
A button to choose an installer file within the dialog of preparing the creation of the install media.
:adhesive_bandage: Alternatives Solutions + Workarounds
A way to copy already downloaded installers into cache directory.

@handarbyte Mist supports caching of macOS Installers, so you don't have to re-download everything you need to create an installer / disk image / package / USB installer.
You can enable Cache downloads via the app settings:

So when you go to create a bootable installer, it will just load from the cache 👍


Validate assignment target column existence for UPDATE statements

Which issue does this PR close?
Closes #5068.
Rationale for this change
Ensure that all assignment targets are actual columns of the target table, to prevent typos being silently swallowed up.
What changes are included in this PR?
During logical planning of the UPDATE statement try to fetch each of the referenced assignment columns.
Are these changes tested?
Yes, there is a new 3-case test now.
Are there any user-facing changes?
Not really; Datafusion is read-only, so the only difference is what error is shown (SchemaError(FieldNotFound from the logical planning as opposed to Internal("Unsupported logical plan: Dml") from the physical planning phase). The real user-facing changes will be in the projects that use Datafusion as a framework and also support writes.

@avantgardnerio on a related note, Seafowl will likely migrate to using the new LogicalPlan::Dml nodes internally pretty soon: https://github.com/splitgraph/seafowl/pull/281

Thanks @gruuya


Fix reactivity of the separator

This small change fixes the reactivity of the separator, if we don't do it like this if the separator is changed that will not be reflected in the component
Before

After

Changes added to #11


PERF-784 img.complete not detected correctly in Chromium

It seems like img.complete isn't exactly what you might expect in this edge case, in Chromium.

Oh, thank you!


Anyone else experiencing extremely slow chunk loading (Maybe due to EFS?)

I've been tweaking a number of parameters including minecraft version, java flags, data packs, and server specs. All seem to perform worse than what I'm used to for similar server specs in terms of chunk loading (both new and old chunks). I'm wondering if anyone else is experiencing this issue, and if it could perhaps be EFS at fault.

Just to make sure, are you basing anything on yesterday's aws outage?  Anything weird that happened yesterday would likely be related to that.

Na, that definitely did give me some down time, but this was before and after downtime yesterday. It’s not unplayable, but it’s definitely noticeable

Looks like it might have been a bug in 1.18 rc1, going to try out 1.18 rc2 tonight

@garrettjoecox it's also possible that your filesystem's burst credits have accumulated now over time. When I first launched EFS was indeed slow, but now chunk loading is pretty quick!

@Stealthii How long did it take your your loading to speed up? Was there any other issues like low TPS/lag before that happened?

@cggentry115 I tell a lie - it seems I was relaying performance of a running server that had clearly cached some loading. On any new task running, heading to/from Nether into unloaded chunks really shows the slow performance (about 8 seconds to load all chunks before transition)

Perhaps someone more familiar with the tools being used could try something like:
before the server starts up, copy the world directory to the local filesystem
Spin up the server with the world on the local filesystem
On server close, overwrite world directory on mounted EFS with the newer copy in the local filesystem.
This might help verify if it is indeed an EFS issue

With the above setup you'd likely be able to ditch EFS all-together and use S3 instead...


Add missing tag reference

Required to add this to bom, see https://github.com/jenkinsci/bom/pull/1228

Thanks @timja!


Added Conda environment support

Resolves #18
Conda environment files created
Tests for environments files created
Inserted into makefile setup develop install

let me know if these options are useful to pyopensci :)

I think this is a nice step forward, thanks for adding the templates as well as the test! We may want to change up how we recommend folks use environment.yml over time, but this is a good start. Thanks @esloch for the improvement :-)


Add input at intermediate layer

Is it possible to add an input in one intermediate layer? For example:
y = self.conv_block1(image)
y = self.conv_block2(y)
y = self.conv_block3(y)
y = self.conv_block4(y)
# fusion        y = y + encoded_state
y = self.conv_block5(y)
y = self.conv_block6(y)

You may consider loading the pretrained weights and wrapping each layer or block individually into a single nn.Module where you can play with the output of each intermediate layer/block.


Updated URLs

Case western has changed their website URLs, i updated them.

Thanks for the update!


added Rana

Related issue

What changes does this PR do?
    added Rana Muskan at line 1424

Screenshots (If any)

Questions

I really learned how to create a branch, edit, and raise a pull request Thank you @eddiejaoude ❤

It's great to know that you learnt a lot from this PR.
Wishing you the best for all your future learnings.

Thanks @aparna2071 for your kind words 😊

I really learned how to create a branch, edit, and raise a pull request Thank you @eddiejaoude ❤

It's great to know that you learnt a lot from this PR.
Wishing you the best for all your future learnings.

Recently I contributed to "LinkFree" planning to contribute more, Can you suggest me some more ??


Quality improvement

I tried to run through and fix any and all issues I could to improve the quality of our code. Overview of what changed:

conform to PEP8 style
better config structure
change how we use pid, see c29fdab commit message for details
moved some common code to a util library

Things we might want to do that I didn't cover:

remove main.py in favor of cli.py
remove gitSound_config.txt in favor of config.json
update/write more tests, and add python tests to travis
update docs

@719Ben @kyliedale @nicolele someone review and comment if anything looks off cause this was a lot of changes. If you guys agree it looks good feel free to merge it


How I disable basic authentication

When running Microsrof Bot Framework emulator for http://infovalutar.ro/bot/api/messages it says:
"You are using HTTP with basic auth, which is not a secure way to pass credentials. If you want to use an unsecured HTTP endpoint then you should disable basic authentication. We recommend you use HTTPS with basic auth to ensure your bot can only be called by trusted parties. Parameter name: Unauthorized - Using unsecure HTTP endpoint"
How I disable basic authentication ??

For C# you comment out the "[BotAuthentication]" attribute
For NodeJS There is a Verify() call that does the basic auth, just disable that.

is there any other Authentication type supported by Bots ?


Autocomplete as self closing tags when necessary

Right now, all tags are closed by autocompletion with closing tags:
`

This is fine with almost all HTML tags, but not with several of them (eg. img). React components should also be self closed:

`

I know closing tags are valid in JSX and React, however, it'd be nice if, at least, tags that start with upper case get self closed.
I'll try to look at the code and see if I can change it and send a PR.

Any and all tags specifically written as self closing should not add additional closing tag unless specifically whitelisted as needing a full closing tag. The list of tags that cannot be self-closed is very small, while the potential list of self-closable tags is basically endless (as emphasized by JSX).


Inter-person discriminator

Hi,
Kudos for the great work. I love the idea of the inter-person discriminator you describe in the paper. However, the following is not clear for me:

How does the discriminator capture interaction between people? How does the architecture of D2 looks like?
Does D2 only accept 2 people, could it accept more people if there is a 3 person interaction?
If there are 3 people in the scene do you use all possible permutations taking 2 people at the time?
Does the order of the inputs Pa and Pb matter?
In your adversarial loss you use the estimated joints Pa and Pb, and its corresponding GT. If you have the GT correspondences then why use a discriminator and not direct supervision?

I couldn't find any of this in the paper nor in the supplementary material. Could you elaborate on this, please.
Sorry for so many questions. Thank you in advanced.

Hello, any comments on this question?

Hi, do you have any answers to these questions? : )


Update quick start instructions

hello, thanks making this available !
It worked well for me, except that my dependency graph is horrible :(

I meant the graph itself is horrible with too many links between apps, not the representation