encoding/xml: handling of anonymous pointer fields is broken

This happens on both Go 1.10.4 and go version devel +c21ba224ec Sat Aug 25 23:59:43 2018 +0000 linux/amd64.
This playground link shows what encoding/json does when it encounters anonymous pointer fields which are nil: https://play.golang.org/p/FUox06lbRVn
As one can see, they're simply skipped. encoding/xml does something slightly different: https://play.golang.org/p/KWYc_IQR7p5
The XML package tries to print the zero values instead. Which seems fine in theory, but here's the first weird behavior - as you can see via the print statements, the encoded value has been modified in-place.
But here's an even worse problem - if the encoded value isn't addressable, encoding panics via reflect: https://play.golang.org/p/7ORK8Vw8o6Q
I think these two problems need to be fixed. I see two possibilities:

Behave like encoding/json, ignoring anonymous pointer fields which are nil.
Keep the existing behavior, encoding zero-values without modifying the anonymous fields in-place.

I personally strongly prefer option 1, as that would make encoding/xml consistent with encoding/json. Both are documented in the exact same way when it comes to anonymous fields, so I believe consistency should be important. Here are the relevant docs for JSON and XML respectively:

Anonymous struct fields are usually marshaled as if their inner exported fields were fields in the outer struct, subject to the usual Go visibility rules amended as described in the next paragraph.
an anonymous struct field is handled as if the fields of its value were part of the outer struct.

The only problem with option 1 is that this may break some existing programs, in which case option 2 may be better in Go 1.x. Although it would still be possible to achieve the existing behavior, if encoding/xml users changed their code to ensure that there aren't any nil anonymous pointer fields.
Whatever we settle for, the fix should be pretty simple - happy to put in the work.
cc @rsc @niemeyer @SamWhited @rogpeppe

Please also note that handling of these is broken in encoding/json at tip at the moment, which is how I ended up digging this bug. A fix for JSON is already up: https://go-review.googlesource.com/c/go/+/131376

Behave like encoding/json, ignoring anonymous pointer fields which are nil.

This is how I read the docs anyways and seems sane to me. It also makes the package more internally consistent: when the children of an anonymous field are promoted they're still behind a pointer so *T.A string is effectively promoted to A *string in my mind (which would be ignored if the pointer is nil).

Agreed. Moreover, trying to access the embedded field in plain Go would never give you an empty value - it would panic - so I think the current behavior is unexpected.

I ended up dropping the ball on this a bit. The good news is that I had a mostly working fix last year, which I'm going to rebase, clean up a bit, and send.
I still think that option 1 is the correct solution here, which is the fix I implemented. I'm not sure if this bug is worth fixing, or if it's the correct fix, but it's not really doing anything sitting in a local branch for a year :)


Configuration properties sections are case sensitive

Describe the bug
When i define my app configuration as per https://docs.steeltoe.io/api/v3/discovery/netflix-eureka.html it is not using the values I am supplying via my configuration layer. If i change the sections key to lower case they do correctly resolve.
Steps to reproduce
Steps to reproduce the behavior:

Have a configuration provider generate config as per below
Data.Add("Eureka:Instance:InstanceId", $"<IP_ADDRESS>:90");
Run the application register with a eureka instance
Observe that the instanceid received is "localhost:{{appName}}:{{port}}"
Change configuration key to be
Data.Add("eureka:instance:InstanceId", $"<IP_ADDRESS>:90");
Observe instanceid is now set correctly

Expected behavior
The configuration parameters are not case sensitive
Environment (please complete the following information):

Steeltoe Version 3.2.6
OS: Windows
.NET Version Net 8

I suspect there's something wrong with your app configuration layer, or it executes too late. I'm unable to reproduce this against Steeltoe 3.x. I've tried the following:

Open https://github.com/SteeltoeOSS/Samples/blob/main/Discovery/src/FortuneTeller.sln, set Fortune-Teller-Service as startup project
Add the following line to Program.cs, between .AddCloudFoundryConfiguration() and .AddAllActuators():ConfigureAppConfiguration(builder => builder.AddInMemoryCollection(new Dictionary<string, string>
{
    { "Eureka:Instance:InstanceId", "some" }
}))

Start Eureka docker container
Select the Fortune-Teller-Service launch profile, run the project, and navigate to http://localhost:8761/eureka/apps
The registered app shows up with Instance ID "some", see below:

Can you provide reproduction steps, so it can be reproduced and debugged?

i know that it is not an issue with config layer ordering as if I change the casing it correctly resolves it.
Would it be helpful if I make a basic repo branch rather than try an describe it?

Sure thing will do that

hmm, this is interesting. I have brought across my entire configuration layer and can't reproduce it.  Changing the casing still results in it working. Maybe some serialisation behaviour differs? But will need to look into this further.

Thanks for investigating. I'm closing this, as it doesn't seem to be a Steeltoe issue. Feel free to open a new issue when you've identified what's going on.


Support for Dark Theme

[ ] Distance Calculator text hard to read. Possibly just make it like the rest of the text
[ ] Properties dialog box for Save as
[ ] Properties dialog Coordinate dialog format

Things are moving forward. Issues with the toggle buttons are being addressed.

Current status:
The dark mode changes are completed in this branch
However, the toggle (MapPoint) buttons don't seem to work reliably/correctly in Pro (Can't toggle off, switching tool doesn't turn off, etc.) making these difficult to test so looking into these issues now.

The issue with the toggle buttons not toggling in Pro has also been resolved and this should be ready for QA/QC after https://github.com/Esri/distance-direction-addin-dotnet/pull/493 is reviewed/merged

This can now be tested.

Testing this I have found that our hover color for our buttons do not match the rest of the dark theme. When you hover over a button in ArcGIS Pro it is a gray color and ours is a blue. We will need to update this as well. @csmoore

Here is an example of how our buttons are different than the rest of ArcGIS Pro:

Talking with @csmoore he says that unless we seperate these two projects completely we will end up with this same issue. Also, he stated that if we try and overide any part of the style we will not be able to use the styles.  Currently we are overriding the sytles for ArcGIS Pro in some ways, but not sure what those examples are.
@csmoore plesae add to where you feel like I have missed or did not give enough information.

Here is the difference in colors:


Certificate expired

Hi, the letsencrypt certificate for https://officeleague.rocks/ expired on the 18th of August. Any chance you could update it?

Fixed now, thanks for notifying!

We've added check for valid certs now :-)


FR: Pure Swift Firestore Implementation using SwiftGRPCNIO

Pure Swift Firestore Implementation using SwiftGRPCNIO Pros:

Swift Package Manager Support
Server Side Swift Support

This would be pretty neat, but re-writing our SDK in swift isn't likely to be something we'd want to tackle any time soon. (We're trying to keep the number of implementations at a minimum, as much as possible.)


makefile.cson is incorrectly recognized as Makefile

While Makefiles can have any file extension, it's somewhat jarring to have all other CSON files have the CSON icon but makefile.cson to have the Makefile one :stuck_out_tongue:.

Is this a common occurrence?
I made Makefile a wildcard pattern because of the colossal plethora of various file extensions... I could make an exception for this particular extension, but I'd prefer to know if there are others I should consider too.

Is this a common occurrence?

Nope, pretty sure not.  I'm just working on language-make right now.

Gotcha.
Actually, I'll remove the wildcard matching for lowercase makefile, since it's really Makefile that it was added to fix.

Fixed, mate. =) This'll be included in the next patch release.


IllegalArgumentException to getDocument

Version: PyCharm 2020.1 Beta
OS: Ubuntu 18.04
BinEd Version: Latest from plugin market
When I open a new file in BinEd, I get these errors. I'm also completely incapable of editing the file. Full stacktrace attached.
stacktrace.txt

I was not able to reproduce this error, but it's possible I'm performing different method of opening. Can you clarify what method do you use to "open a new file"?
Version: PyCharm (tested also Community) 2020.1 Beta (201.6487.18 / Open JDK 11.0.6+8-b765.15 amd64)
OS: Fedora 31 x86_64
BinEd version: 0.2.2 (see about dialog via popup menu)
Also tested current development build (0.2.3.snapshot) which doesn't work, but due to different error.

Ah, so: If I double click a file named struct_test.bin, it opens in BinEd then I get the errors. If I right click it and open as binary, it works just fine

Association with .bin was suppose to be removed in issue #21 Not sure why it works again :-/ I'll take a look into it in next version.

Alright. I would like if it was possible to associate the plugin and have it behave automatically, but I understand if it's too much of a maintenance hassle / unexpected behavior. Thank you for the help.

Support for file type (Binary File) was added in 0.2.3. Hopefully it will work somehow, although file size is limited and performance may be affected in this mode.
And yes, it was quite a hassle :-)


Asynchronous versions of everything in the IDocumentSession API

Base async\await support
Closes #16

@ekulakov Hey, thanks so much for doing this. Everything looked fine from a cursory glance, but it'll be the Monday after New Year's before I can bring this in and push a new nuget.

@ekulakov I'm looking through this now.

I can try to add several more methods like SingleAsync(), SingleOrDefaultAsync(), etc

@ekulakov Do you want to do that as a separate PR, or add to this one? I don't see any reason not to take this in whenever you want. The code looks good to me and I like what you did in the internals.

@jeremydmiller if you don't mind let it be a separate PR

@ekulakov Cool, I'm pulling this in right now then. Thanks!


[Fix: issue 633] Component List don't support Var(list).

All Submissions:

[x] Have you followed the guidelines stated in CONTRIBUTING.md file?
[x] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

New Feature Submission:

[x] Does your submission pass the tests?
[x] Have you linted your code locally prior to submission?

Changes To Core Features:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

Desc
Component List supports Var(list).
Close #633

great. I'm realizing there seem to be no unit tests for this component. We could probably use some unit tests in a later PR

@ElijahAhianyo
Yes, we can add the unit tests in a later PR.


In Front end Order details, Order id is having a lot of space.

Bug Report
Unnecessary Space at the Order ID.
Issue Description
When we check the order details at the front end and there in the Order ID, there is unnecessary space is visible which looks slightly odd.
Bagisto Version
v1.3.3
Steps To Reproduce

Login with customer id.
Order a product and then check the order details on the customer's dashboard.
There we will be able to see the unnecessary space.

Actual Result
The Space Image is below.

Expected Result
It would be much better if the space will be reduced so that the Date and time format also get properly adjusted.

@deepaksinghgusain227 can you follow up this issue?


Chess: Move D2 to D3

Please do not change the title. Just click "Submit new issue". You don't need to do anything else :D

.


API : Hook to counter / tracker events

Use case:
Detect potentially dangerous situation when object enters area (area defined with polygon, using development branch version of Opendatacam). For instance, say you want to prevent workers from falling in an to be avoided area at a construction site, or from coming to close to dangerous equipment. In this case it would be helpful to have a feature to play a sound to alert the admin.

I renamed this to add some API to hook to things..
right now you can do this directly in the code here: https://github.com/opendatacam/opendatacam/blob/0f921e856e7746d07a412fab8a0f7136fb004f3e/server/Opendatacam.js#L307

this feature would also benefit from an API hook to counter events

let's see if we can make this happen for next release

@tdurand I can give you code that fires a NodeJS event on any counter change. What would be left is the part where it calls an external webhook. Let me know if this would be of help to you.

I guess any input can be nice to have.. honestly I didn't think yet the potential solutions to this...
The cheap solution would be just provide a endpoint that gives all the counting events .. and people need to ping it constantly... but I'm not super familiar with technical solution to "hook" to.. websocket ?

Actually I just saw the eventEmitter is already part of the development branch. So all you would need is to extend server.js to connect these to Webhooks.

Ok thanks, from user perspective what do you think ? provide the possibility to have a simple webhook endpoint declared on the config.json ?

Now that I think about it this might be bigger than I first thought.
We will need to consider

what kind of events and data need to be transferred.
Rate limiting?
Auth?

Before we can give a good estimate on the complexity and the best implementation.
We could of course make some choices but I would like to understand more how people want to use this feature to avoid wasted effort.

yep.. I mean, let's say if not ones gives input by the time I get on this, I will do just a super simple thing for now that can be improved later..

That's the point I'm trying to make. Not sure if the MVP is already too much work ;-)

That's the point I'm trying to make. Not sure if the MVP is already too much work ;-)

Somewhat unrelated / quasi-related.  I needed the ability to hook into the Jetson's GPIO pins when an object crosses a counter line.  I added a Node Python bridge so that way it just calls my Python file.  I also added a switch in the menu to turn it on and off as well as extended the Counters editor to toggle a line as an Alarm line.  So it can be done, probably not as neatly as what is being discussed here though.  In addition because I remembered seeing this thread, I went ahead and added in a node package to play configurable beeps without requiring external files.  So in short, I have an alarm that sounds on the browsers device speaker as well.  I don't think any of this code is worthy of a PR, but I do have it on the dev branch and can make a branch to contribute for review.

Most of the requests for Webhooks were for "live counter updates" (in some sort of dashboard)
The GPIO is new to me. I wonder if this could be implemented via the Webhooks as well? Would have the benefit to keep your fork closer to the main ODC. Or is timing an issue for you?

Its possible it could be done via a webhook.  Correct me if I am wrong on this, but we are saying add an endpoint in server.js to be called.  Thus it would be auto-documented in API documentation and then it can be called from any external program without bogging down ODC codebase.  For the work I am doing, that "possibly" would work but I am uncertain if all the data I need would be accessible.
In short, the current work is to call OpenCV natively in Python as I used the new polygon tool to create a quadrilateral that prompts for GPS lat/lons for known points in the camera view.  From this, we can leverage OpenCV's getPerspectiveTransform and covert any pixel coordinates into fairly accurate GPS lat/lons of the tracked item.  So what I am doing is hooking into the countItem functions to make my call, it gets the coordinates, and returns it back.  Because I have a coordinate now, we can update trackedItem with the actual coordinates and not the coordinates of the GPS receiver attached to a nano.  Additionally, if a trackedItem crosses a certain counter line, we send a PWM signal through the GPIO to attached hardware to do some downstream stuff, i.e. flash lights, activate a siren, or whatever (I can discuss this just not in a public forum)
That probably wasn't that short, but you are correct on timing may be an issue for this scenario.  Regardless of all of that, I am building on the development branch so once it gets released, my code "should" be able to merge and get all the benefits of the later work.
If that code could be of use to ODC, I have no issue putting it up, BUT its probably pretty hacky in terms of ODC standards, lol.

Actually I was thinking of doing it the other way around. Adding the option to configure a URL that gets called on every counter event and passes along details about the event (counter level, object coordinates, object type, ID etc)
That URL could of course be something like http://localhost:<some port> where you could have another Programm running on the same machine, receiving the counter events and doing your PWM or whatever you have in mind.

Ah, ok.  That would work too - not for what I want to do - but definitely for other projects.  That makes way more sense now with your comment above:

We will need to consider

what kind of events and data need to be transferred.
Rate limiting?
Auth?

To be honest, I am not certain the best path forward for that type of integration because you could make a call to that url with just the current recording ID and then get all the data from the db.  Otherwise, if you are wanting to do bi-directional transactions, i.e. call and response, would we need to do a pub/sub websocket style setup.  For what I am doing, I need to alter the countedItem data for display as well within ODC.  I fear the latency in any pub/sub setup - even on the same device - would cause issues.
I do agree, this is probably edge case and not an MVP.  ODC is amazing and has accelerated my work significantly.  I can say though, the Python bridge was super easy to implement and thats also a way to offload work to external processes.

I decided to remove this from v4.0.0 as there is already a lot of new things in development that we need to get out.


Type casting autocompletes as HTML tag in TS

VSCode Version: 1.14
OS Version: Win10

Steps to Reproduce:

Create TS file with any variable that needs to be casted, e.g. to string
Type <string, then >, after > is typed, it autocompletes as <string></string> tag.

I believe this is very surprising that we have HTML tags autocomplete in TS files.

I believe this expansion comes from emmet. Is the language mode typescript or typescript-react?
Also, can you please share your user settings?

Cant repro
@michaelchiche Can you share a gif?

@mjbvz Language mode is TypeScript.
@ramya-rao-a

Aha, bad extension had installed. Did not see it before. Sorry for that.


analysis_options.yaml "include:" not working for nested folders unless workspace root has a package config for the referenced package

I have an analysis_options.yaml using include:
include: package:dart_flutter_team_lints/analysis_options.yaml

And it looks correct because if I "dart analyze" I get findings:
   info • lib/generate_dart_model.dart:141:15 • Method invocation or property access on a 'dynamic' target. Try giving the target a type. • avoid_dynamic_calls

But I don't see any such info in VSCode. If I copy the config in place:
analyzer:
  language:
    strict-casts: true
    strict-inference: true

linter:
  rules:
    avoid_dynamic_calls

then I immediately see the finding in VSCode.
Any ideas please? I ran into this on the language repo and ended up giving up and just copying the whole config in
https://github.com/dart-lang/language/blob/main/working/macros/dart_model/analysis_options.yaml
and now I run into it again in the macros repo
https://github.com/dart-lang/macros/tree/main/pkgs/dart_model
with my pending PR that has some lint issues :)
@jakemac53 @devoncarew @DanTup any ideas please? :)

@davidmorgan can you confirm what commit I can use to repro this? I checked out your add-schema-and-codegen branch (346ae07) but I see different errors to what you mentioned above (and the same in VS Code + terminal):

Oh, I see you pushed a fix for it. I reverted that fix, but I do see the lint showing up in VS Code:

Can you confirm which folder you have opened in VS Code, and whether the package is correctly in tool/dart_mdeol_generator/.dart_tool/package_config.json? Mine looks like:
{
  "name": "dart_flutter_team_lints",
  "rootUri": "file:///C:/Users/danny/AppData/Local/Pub/Cache/hosted/pub.dev/dart_flutter_team_lints-3.1.0",
  "packageUri": "lib/",
  "languageVersion": "3.4"
},

I tried opening a simpler workspace that just has the macros folder
code --remote<EMAIL_ADDRESS>/usr/local/google/home/davidmorgan/git/macros

but no difference, the lint config still seems to be missing. Here's ~/git/macros/tool/dart_model_generator/.dart_tool/package_config.json:
    {
      "name": "dart_flutter_team_lints",
      "rootUri": "file:///usr/local/google/home/davidmorgan/.pub-cache/hosted/pub.dev/dart_flutter_team_lints-3.1.0",
      "packageUri": "lib/",
      "languageVersion": "3.4"
    },

It's possible I have a bad dart version, I'm using the SDK from main from the last time I happened to build it, I can try with a known-good SDK version if that helps. Thanks :)

I was using a new bleeding-edge build I just grabbed from https://gsdview.appspot.com/dart-archive/channels/be/raw/latest/sdk/
Can you reproduce it without the SSH? I doubt it's related, but since we're seeing different behaviour it'd be good to eliminate some variables.

Oh, interesting, local version works straight away
code /usr/local/google/home/davidmorgan/git/macros

both local and remote are on the same VSCode version
1.87.1
1e790d77f81672c49be070e04474901747115651
x64

and I don't see anything suspicious in the remote settings.
Ooookay it gets even more interesting! I downloaded an SDK from the link you gave, and with that both work. But that's quite an old SDK? It's from Nov 2023.
If I instead use a more recent one from https://gsdview.appspot.com/dart-archive/channels/main/raw/latest/sdk/ then again I see local VSCode works but remote doesn't.
So it looks like it is related to some change in the SDK.

I downloaded an SDK from the link you gave, and with that both work. But that's quite an old SDK? It's from Nov 2023.

Oh, I messed up here.. Firstly, I downloaded a new SDK but was actually still set to use the stable SDK. Secondly, I pasted a bad link here - I got the SDK from https://gsdview.appspot.com/dart-archive/channels/main/raw/latest/sdk/ (be changed to main in the URL some time ago) but I replied to you from another machine that had a stable bookmark.
So, I properly updated to the bleeding edge SDK I said I was using, and I do not see the lint. But I don't see it either in VS Code or dart analyze:

I don't know why your results are less consistent, but I can at least try looking into the cause of this.

It seems to be triggered by having another project in the workspace.
I've reduced it to this... two projects in the workspace. One has a violation for that lint and the other has no code. Both of them import the lints.
Analyzing the offending project on its own (both by opening it in VS Code itself, or dart analyze on it) results in the lint diagnostic. Analyzing the parent folder that also includes the other (empty) project results in no lint warning (again, from VS Code or dart analyze).
This is running on current bleeding-edge code.

Ah, I should have said, I was running "dart analyze" from inside tool/dart_model_generator, not from the top level.
I'm not actually sure what "dart analyze" is supposed to do if run from a folder enclosing multiple packages? From the "macros" folder:
dart --version
Dart SDK version: 3.5.0-edge (main) (Unknown timestamp) on "linux_x64"
dart analyze
--> no issues found
dart analyze tool/dart_model_generator
--> does find issues!

which matches: with bleeding edge Dart, if I open VSCode remote to "macros" which has two packages, no lint is reported; if I open it to "macros/tool/dart_model_generator" which is just one package, the lint is reported.

I'm not actually sure what "dart analyze" is supposed to do if run from a folder enclosing multiple packages?

I would expect it to analyze everything, though I'm not certain (@bwilkerson?). Though the behaviour is the same in VS Code and still broken - if I open the one project I see the lint failure, and if I open the parent I do not. It should definitely work in that case.
I think I've managed to reproduce this in a test, will continue debugging.

@davidmorgan I updated the issue title to match what I believe to be the issue here.

which matches: with bleeding edge Dart, if I open VSCode remote to "macros" which has two packages, no lint is reported; if I open it to "macros/tool/dart_model_generator" which is just one package, the lint is reported.

It turns out that you don't even need a second project to repro this (besides the one being imported). I reduced my repo to just this:

If you open the package itself, everything works - I believe .dart_tool/package_config.json is used to resolve package:dart_flutter_team_lints in the analysis_options. However, if you open the parent folder (even if that folder contains nothing else except this project), then package:dart_flutter_team_lints in the analysis_options does not resolve (because it's not using the package map from the nested project folder), and therefore the lint doesn't get included in the set for that projects context.
Let me know if you're seeing any behaviour that doesn't seem to match this, in case I discovered a slightly different bug to the one you're seeing 😄 (I did re-test with macros and that does seem to match for me though).

I'm not actually sure what "dart analyze" is supposed to do if run from a folder enclosing multiple packages?

I would expect it to analyze everything ...

So would I. Running dart analyze (without a file path) on the command line ought to be equivalent, in terms of analyzed files, to opening the working directory in an IDE.

Friendly ping, is this likely to be fixed soon please? @pq
There isn't really a nice workaround if you're working on multiple packages, you have to either write the precise lint config you want in full or open lots of editor instances. Or if someone has a better workaround, please share :)

Given the holidays next week, and the number of people taking vacation time around them, it probably won't happen until the week after at the earliest, but we are actively working to solve this issue.

Noted, thanks for the update :)

How we doing on this one, @pq?

@keertip took a look and I think is on to a fix 🎉

Verified this fixes the issue for me, thank you :)

Awesome. Thank you @keertip! And thanks @davidmorgan for the confirmation! 🙏

Yes, it's about multiple packages workspaces, i.e. your IDE has a workspace root that is not a package root, in combination with yaml imports. I agree it sounds common. I don't know which versions are affected precisely.
The most obvious workaround is to point your IDE at a different SDK version, since it's the analyzer version that's running in your IDE that matters. The only workaround I know if you are stuck on a broken analyzer version is to copy the yaml instead of using the import, which is not fun at all.
Hopefully someone from the analyzer team can fill in the rest :)

Adding this to the root of my repo appears to work as a workaround:
name: _
environment:
  sdk: ^3.5.0
dev_dependencies:
  very_good_analysis: ^6.0.0

FWIW there was a cherry-pick made for this fix at https://github.com/dart-lang/sdk/issues/56464 so it should show up in a future 3.5 hotfix release.


PlutoGridScrollbarConfig isAlwaysShown not used

The scrollbar does not display when entering for the first time。When I swipe horizontally, the vertical scrollbar will disappear, and when I swipe vertically, the horizontal scrollbar will disappear。

I think there should be a variable to control the horizontal scrollbar AlwaysShow, and a variable to control the vertical scrollbar AlwaysShow。


CVE-2007-4559 Patch

Patching CVE-2007-4559
Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.
If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

I think that you need responsibility to update patch until adjust for repository on GitHub.
If you do not have will to communicate on GitHub, you should not create pull request.


Latest commit isn't available through gradle version 1.0.3

can you please fix it.

We'll release on next version 1.0.4


MDX code blocks & more

https://www.notion.so/prismaio/Docs-MDX-Code-block-9af4545b78c6455aa70f2e596a639905

[x] Tabbed component for generic MDX content
[x] Line highlights: red, green, neutral
[x] File icons
[ ] Side-by-side code blocks
[ ] Show hidden lines (top, middle, bottom of file)
[ ] Include terminal outputs in code block

https://www.figma.com/proto/DChfqSLXxd77jJnG2xoM6d/Prisma-Docs-v2?node-id=452%3A1779&viewport=997%2C618%2C0.13714225590229034&scaling=min-zoom
^ This shows design for dark mode where the colors for terminal commands should come from.

I'm closing this issues in favor of smaller, more targeted ones which I'm going to create.


Felipe/fix 779

@felipecsl whoops, sorry about that, publishing my fix while I test the new fix in 778.


Unable to use output of one subworkflow as the input of another subworkflow

Describe the bug
Initially in attempting to use the list of outputs from a foreach subworkflow, the workflow fails with a validation error because the output object of the subworkflow is assigned a random ID that does not match the ID of the input schema of the second subworkflow.
2024-01-29T18:14:14+01:00	error	source=main	Invalid workflow (input validation failed for workflow step 'cpu_index_loop' stage 'execute' (Validation failed: error while validating sub-type of property Items with type *schema.ListSchema (Validation failed: validation failed for object schema ID IndexObject. ID qb5jeq63hl52vihbj04tnbwq0mem4ybj does not match.)))

I was advised to define an outputSchema for the first subworkflow in order to define its ID explicitly so that it matches the input of the second workflow. After adding this to the first subworkflow:
...
outputSchema:
  success:
    schema:
      root: IndexObject
      objects:
        IndexObject:
          id: IndexObject
          properties:
            pcp:
              type:
                type_id: list
                items:
                  type_id: any

outputs:
  success:
    pcp: !expr $.steps.pcp.outputs.success.pcp_output

After doing this, the workflow produced a new error, which may be a bug in the go SDK:
2024-01-29T18:16:15+01:00	error	source=main	Invalid workflow (invalid workflow (failed to load schema for step sysbench_cpu_loop (invalid workflow (Validation failed for 'outputSchema': Field cannot be set (reflect.Value.Convert: value of type map[string]*schema.StepOutputSchema cannot be converted to type map[string]interface {})))))

To reproduce
The WIP workflow that has this configuration is here: https://gitlab.com/redhat/edge/tests/perfscale/arcaflow-workflow-sysbench/-/tree/new-opensearch-plugin?ref_type=heads

Minimum reproducible example
subwf-1.yaml
version: v0.2.0
input:
  root: SubRootObject1
  objects:
    SubRootObject1:
      id: SubRootObject1
      properties:
        name:
          type:
            type_id: string
steps:
  example1:
    plugin:
      src: quay.io/arcalot/arcaflow-plugin-template-python
      deployment_type: image
    input:
      name: !expr $.input.name
outputs:
  success:
    name: !expr $.steps.example1.outputs.success.message

workflow.yaml
version: v0.2.0
input:
  root: RootObject
  objects:
    RootObject:
      id: RootObject
      properties: {}
steps:
  subwf_1:
    kind: foreach
    items:
      - name: "john"
      - name: "paul"
      - name: "george"
      - name: "ringo"
    workflow: subwf-1.yaml
  subwf_2:
    kind: foreach
    items: !expr $.steps.subwf_1.outputs.success.data
    workflow: subwf-1.yaml
  subwf_3:
    kind: foreach
    items: !expr $.steps.subwf_2.outputs.success.data
    workflow: subwf-1.yaml
outputs:
  success:
    step_3: !expr $.steps.subwf_3.outputs.success

config.yaml
deployers:
  image:
    deployer_name: docker
log:
  level: debug
logged_outputs:
  error:
    level: error

input.yaml
{}

output error
Unexpected error: invalid workflow (
  Validation failed for 'outputSchema':
    Field cannot be set (
      reflect.Value.Convert: value of type map[string]*schema.StepOutputSchema cannot be converted
      to type map[string]interface {}))


[W6.1h][T10-B2]Wong Zeng Feng

@zengfengw Some comments added. Please close the PR after reading comments.

Ideally the getPrintableString(Printable … printable) method should be used somewhere.


header title should be all SemiBold

Should be
Carbon Design System
Not
Carbon Design System

FYI @jeanservaas

Does this mean all UI Shell guidance + styles need to be updated as well?
https://www.carbondesignsystem.com/components/UI-shell-header/usage#anatomy

@tw15egan Just for the Carbon site. The guidance above is correct if [IBM] is in front. But in the case of Carbon Design System it should all just be the semibold and not a mix of regular and semibold.


Slider Input color problem

Input of type slider seems to have some trouble with its styling (if not provided any boundaries and values?). Styles should be evaluated again to check if the blue color works properly and also that the second slider is above the first one.

Slider styling in Firefox also seems off by a lot.


Python seed is not forwarded to Lua

https://github.com/deepmind/meltingpot/commit/449ac8b083c5bbb0d338404e7094d63c00beb5e3 introduced a bug where the random seed was no longer forwarded from Python to Lua, meaning that the Lua-controlled parts of the environment were no longer randomized.

Fixed in c009d0a601670c51107994e4bf63db6ed2f71c0a


Add META test to ndt-server

This change adds support to the META test for all client types.

This change is

Pull Request Test Coverage Report for Build 703

45 of 48 (93.75%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.3%) to 73.097%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

legacy/protocol/protocol.go
0
1
0.0%

legacy/meta/meta.go
36
38
94.74%

Totals

Change from base Build 699:
1.3%

Covered Lines:
1383

Relevant Lines:
1892

💛  - Coveralls


fix issue #2904

Codecov Report
Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (35e5f1f) 77.73% compared to head (5412051) 77.71%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3004      +/-   ##
==========================================
- Coverage   77.73%   77.71%   -0.03%
==========================================
  Files         642      642
  Lines       54400    54418      +18
==========================================
  Hits        42289    42289
- Misses       9978     9997      +19
+ Partials     2133     2132       -1

Flag
Coverage Δ

go-1.18-386
?

go-1.18-amd64
77.68% <4.76%> (+0.03%)
:arrow_up:

go-1.21-386
77.67% <4.76%> (-0.01%)
:arrow_down:

go-1.21-amd64
77.68% <4.76%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

net/ghttp/ghttp_server_service_handler.go
57.85% <4.76%> (-4.21%)
:arrow_down:

... and 5 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[All Hosts] (troubleshooting) update local copy of office.js frequently

Docs Build status updates of commit 91e3bb4:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/testing/troubleshoot-development-errors.md
:warning:Warning
View
Details

docs/testing/troubleshoot-development-errors.md

Line 105, Column 26: [Warning: file-not-found - See documentation] Invalid file link: '../develop/update-your-javascript-api-for-office-and-manifest-schema-version'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit cf4d6f6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/testing/troubleshoot-development-errors.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e449b5a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/testing/troubleshoot-development-errors.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


wip: adding updated scripts/terraform

Managed nodes... Great idea!

I think that the README after that will need to be updated with the new requirements (terraform and awscli binaries for sure for now) and maybe steps

I think that the README after that will need to be updated with the new requirements (terraform and awscli binaries for sure for now) and maybe steps

I agree, will add those in the PR too

/approve
/honk

Ops! No Prow here :(

Converged in main PR #188


Revert "fix!: change the instrumentation config to circumvent viper b…

…ug (#1143)"
This reverts commit f1dc8f7da7a8fc1e2fd1409c4200e095ac9ae547.
which is a breaking change to the config

damn we even had fix!. maybe we can get the backport bot or some CI to warn us when we try to backport anything with a !


Upgrade to gradle 6

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #15   +/-   ##
=========================================
  Coverage     86.48%   86.48%
  Complexity       81       81
=========================================
  Files            12       12
  Lines           185      185
  Branches          9        9
=========================================
  Hits            160      160
  Misses           23       23
  Partials          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba283bb...351a1fe. Read the comment docs.


Antis #Dont Work

What OS are you using?
bofa
VRChat Information
https://discord.gg/Stw39t5b3r
Legit bypasses to your mod publicly, with avatar ids rotating every 5 hours 0 / / / / 0
Bug Description
It died to AAXX, the only antis that worked were the ones spoonfed by azurilex. #rip my nigga
Reproduction Steps
get better
Expected Behaviour
getting better
Actual Behaviour
null should learn how to reverse engineer without relying on other people
Logs
https://hex-rays.com/ida-pro/
All of the following criteria must be met

[X] I have installed all the MelonLoader requirements.
[X] Full, unedited Latest.log is attached
[X] I have listed what, if any, clients I am using.
[X] I realize that the devs have other things going on and may take time to respond.

[X] I am not reporting a new/incorrect crasher, since github isn't the place for that.

Cool story bro
Also null contributed UI code, not reversing stuff.


feat: NumberControl stories

Add Storybook stories for NumberControl

Due to refactoring, I am moving these stories into another PR.


Add rule severity

Well this was annoying, but I don't see any other way than passing an extra parameter everywhere.
Every rule now allows specifying severity Error, Warning or Info, defaulting to Error.
I have yet to modify the outputs.

heh, yea, perhaps the key and severity can be combined into this, would probably need some other changes 🤷♂

maybe something like Issue.FromRule(rule, params) and make params a union of all the variants.
type params = RowRange | Position | Range | Token | ...

hmm
I'm okay with merging this as is

Yeah, I discovered that this is not as elegant as I thought. But I still need to adjust the outputs to have severity in them.

Hmm, now it's broken here, but it compiled for me after link local.
There also seems to be some kind of inconsistency with eslint, because marc's earlier commit passed and now locally I have errors about long lines:

there is a problem with running the linter on CI, https://github.com/abaplint/abaplint/issues/1031
just add a eslint ignore


Update extensions shipped with Gnome

This has a placeholder between the quotes to be replaced with whichever other extension you would like to highlight.

When this is committed, please add "Fixes #16" to the commit message. Thanks!

We ship a relatively stock gnome experience these days but with a few QoL tweaks:

System tray support by default via the appindicator extension from Ubuntu
Speedinator to speed up animations
Removable drive menu enabled by default

Noto Sans is the default font instead of cantarell
Paprius-dark is the default icon theme instead of adwaita-icons
adw-gtk3-theme is the default legacy theme for visual consistency with modern libadwaita applications


elasticsearch version

Hello,
you use elasticsearch 0.9, but in docker.hub is lowest version 1.3 (and latest 1.7)
if you see to documentation - api is changed (0.9 vs 1.3) and now failing cpan-api part
carton exec bin/metacpan mapping --delete
2015/10/24 22:53:55 I mapping: Putting mapping to ElasticSearch server
[ERROR] ** ElasticSearch::Error::NoServers at /cpan-api/local/lib/perl5/ElasticSearch/Transport.pm line 268 :
Could not retrieve a list of active servers:
    [ERROR] ** ElasticSearch::Error::Request at /cpan-api/local/lib/perl5/ElasticSearch/Transport/HTTPTiny.pm line 75 :
    Bad Request (400)

    With vars:{
      'request' => {
        'cmd' => '/_cluster/nodes',
        'qs' => {
          'http' => 1
        },
        'method' => 'GET'
      },
      'status_msg' => 'Bad Request',
      'status_code' => 400,
      'content' => 'No handler found for uri [/_cluster/nodes?http=1] and method [GET]',
      'server' => 'elasticsearch:9200'
    }

With vars:{
  'servers' => [
    'elasticsearch:9200'
  ]
}

solutions:

using new elasticsearch
change in documentation elasticsearch docker to barnybug/elasticsearch:0.90.13 (for example - this works)

thanks

@JaSei thanks for this.  The Elasticsearch is a work in progress with no foreseeable date of completion.  We'd accept a pull request which forces a downgraded version of Elasticsearch.


Discontinuity

In the video for Arroost, it says like the arrow of infinity can go into the future and past by powering it and stuff, but it doesn’t work, and in it, is the same universe

yes it is an unreleased feature. there is a branch sitting around somewhere for it !

what branch, what is a branch


Fix LUIS model ('Version ID cannot be null or empty' when importing JSON)

Fix for https://github.com/Microsoft/BotBuilder-Samples/issues/251

ID


OSError on launch

Hi, got the following error after running on Ubuntu Server 18.04. Installation was ok.
Uncaught error "OSError", exiting the app.

Hmm I suspect this has to do with the Stockfish engine binary — it might be only compatible with Mac OS.
I wonder if a good way to fix this would be to provide a variety of binaries and select the correct one based on OS detection

Yes, that is the issue. I'm implementing this, will commit soon.
Thanks
On Tue, Aug 6, 2019, 10:22 Nick Zuber<EMAIL_ADDRESS>wrote:

Hmm I suspect this has to do with the Stockfish engine binary — it might
be only compatible with Mac OS.
I wonder if a good way to fix this would be to provide a variety of
binaries and select the correct one based on OS detection
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nickzuber/chs/issues/1?email_source=notifications&email_token=AAMVTV67C6KJWS4LQXGS6TDQDF3I7A5CNFSM4IJNZ5DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3VDVQY#issuecomment-518666947,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMVTV5W4JIEKUPJ2E67CULQDF3I7ANCNFSM4IJNZ5DA
.

I'm having the same error on Linux. If there is a fix I'd be glad to try this!

Same issue on Debian Buster with Stockfish 11. Would be happy to help test a fix, or workaround.

This bug was patched in https://github.com/nickzuber/chs/pull/2 and I released the latest version of the project just now.
Things should be fixed — please let me know if you guys are running into the same issue

Currently having this exact issue on a Raspberry Pi 3 Model B+ running Ubuntu 18.04.6 LTS armv7l. Unsure whether it can run on Arm or the Pi for the matter, however, it seems to install just fine. I am currently running on version 3.0.0 of Chs, the latest at the time of sending this


Cloudfit/update pipeline for new split

Which issue this PR addresses:

Fixes
What this PR does / why we need it:

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

/azp run CI

/azp run E2E

Closing this PR until we're ready.  Will resubmit at a later time.


Update install-minikube.md

I try to use this manual on Ubuntu 18.04 and got executable /usr/local/bin file :)

/approve
/lgtm


indexer for the Search-Rework

Description
defined in https://www.notion.so/Search-Rework-c66bd1db9c9c49d8a5a4b22cff5244b7
with PoC Table Designs:
https://www.notion.so/matterslab/Search-Index-Cache-Table-Designs-ed28c67bdfe244d8b225886d457466c6
References

Product doc
Design

Close it since moved PRs to new repo, and its' done.


locales/es-US/ translations

@benwilhelm ,
Translations are updated, checked for site after the re-design work.
Thanks,
-R

Merged into the develop branch


[RichText] - Problem with edit mode

Category
[ ] Enhancement
[x] Bug
[ ] Question
Version
spfx : 1.9.1
sp-dev-fx-controls-react : 1.16
Sharepoint OnLine : Targeted and Standard release
Chrome/Edge : latest version
Windows 10 : latest version
Expected / Desired Behavior / Question
The edit mode don't work anymore
Observed Behavior
I'm use a richText editor in a WebPart to edit a simple introduction text. in edit mode, the richText do not switch to edit.
The problem started last week, and I didn't do any component-side updates (no update, the webpart was already installed and worked very well).
I updated to PnP SPFx Control 1.16, but I still have the problem.
I have tested on Chrome and Edge latest version with same problem.
I have tested with React DevTools. The condition pass a "isEditMode" attribut to true, but the "editing" state of component stay at false. (see screenshot)

I have tested with simple condition :
this.props.displayMode == DisplayMode.Edit
And state method, componentDidUpdate ... a lot of test.
Does anyone reproduce the problem?
Steps to Reproduce

Create a WebPart and add richText
Insert webpart to page (edit mode work on first insert)
Save the page
Reload the page
switch page to edit mode and try the edit of richtext

Thanks

Hi @PooLP!
I can reproduce that. It looks like SharePoint page lifecycle has been changed.
And the changes showed the error in RichText component.
I've committed the fix.
Could you please install the beta version and check if it works for you.
How to install beta version

After test, it's ok for me.
Thanks.
PS :
I tried to resolve this bug myself.
I created a fork of the repos (dev branch), installed dependencies by npm -i
But, after lanched the gulp serve command, the debug didn't worked on my SharePoint environnement, i have error message like if serve do not run, i have this error :

An error occurred while loading the debug script. Make sure the server is running and that the URL for the "debugManifestsFile" parameter is appropriate.
Error: Script error for: https://localhost:4321/temp/manifests.js http://requirejs.org/docs/errors.html#scripterror

Do we need to do something more (run on docker an env with 1.3.0 spfx version of generator, specific version of VSC ...) ?

Glad to hear it's resolved.
For the local development, you can do one of 3:

set no http2 as mentioned here
Use nvm and install node v6
use docker

I use nvm :)

Thanks, I will do that! ^^
I close the issue.


Pdf 1

Closes #204

@michaelavs I am having trouble generating a gamma distribution that matches the NCL one. I have the type and general shape, but the scale seems to be off, any thoughts?

@michaelavs I am having trouble generating a gamma distribution that matches the NCL one. I have the type and general shape, but the scale seems to be off, any thoughts?

I think the code you uploaded may be corrupted (It isn't displaying in normal format), do you mind re-uploading it to see if that fixes it on the GitHub side? Afterwards, I'll definitely take a look!

@michaelavs I am having trouble generating a gamma distribution that matches the NCL one. I have the type and general shape, but the scale seems to be off, any thoughts?

I think the code you uploaded may be corrupted (It isn't displaying in normal format), do you mind re-uploading it to see if that fixes it on the GitHub side? Afterwards, I'll definitely take a look!

Ahh, yeah that keeps happening to my commits, something about line break styles. I've fixed it here and am going to look into why it keeps happening.

@michaelavs I am having trouble generating a gamma distribution that matches the NCL one. I have the type and general shape, but the scale seems to be off, any thoughts?

I think the code you uploaded may be corrupted (It isn't displaying in normal format), do you mind re-uploading it to see if that fixes it on the GitHub side? Afterwards, I'll definitely take a look!

Ahh, yeah that keeps happening to my commits, something about line break styles. I've fixed it here and am going to look into why it keeps happening.

So this may not be the best work around, but if you define a range in the np.histograms() call for the gamma distribution, you can make the random numbers not exceed 18 (as they appear to be doing). By setting range=(0,10) you are able to make the graph look more like the NCL version and it will not jump around so much between each run. What is also interesting, and may be causing the issue, is that in the NCL version the x-axis is in the scale of 0 to 0.18. I tried setting the range to that and it makes the projection a low level, nearly flat line. Just something you may be able to play around with and see what the outcomes are

After a long pause, I think I've sorted out what to do with this PR. I don't want to force the data to fit the original axes, since the original axes are arbitrary and the data used to form the plots is meant to be random. I've added some axis magic to allow for variable axes upper limits on the bottom two plots while maintaining the original tick spacing. I've also added using matplotlib.ticker as a concept demonstrated in this script.

Just note while testing, the script may produce different axes from the ones on the original ncl plot.

A README.rst file should be added under the folder "ProbabilityDitributions" for this to be generated properly by Sphinx.
Other than that, the implementation and docs look great!

Thanks for catching this! The README.rst file is now included.


llama_7B does not exist in Hugging Face

trace.py tries to pull llama_7B (Model name) from Hugging Face. However that is not available. Please provide the correct model name for me to use trace.py.
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://huggingface.co/llama_7B/resolve/main/tokenizer_config.json
Thanks.

Hi Kowndinya,
Thanks for reporting. The original Llama 1 models were not officially distributed in Huggingface. There are two ways to access them:

request access from Meta filling this form. Then the downloaded model should be saved in MODEL_DIR specified in globals.yml
OR
Use unofficial huggyllama release, by providing flag --model_name_path huggyllama/llama-7b or a model with different number of parameters.

Please note that this is a solution for Llama 1. Tracing also works for newer Llama 2 models.


Add download data for June 2021

Summary

The good news: the Circe and Typelevel organizations hit a new record 🎉 20 million 🎉 total downloads in June!
The bad news: most of the new downloads were for Scala 2.11, a Scala release that debuted in 💀 April 2014 💀.

Details
The Circe organization had 7,272,043 Maven Central downloads in June, which is up 50% from May's 4.8 million, and a pretty big jump compared to the usual gradual upward trend. The number of unique IPs was only up 5% from May (171,038 to 179,619). Most of the change in downloads was for Scala 2.11, with the number of circe-core_2.11 downloads more than tripling.
Typelevel also saw a larger increase than usual in June, but less dramatically, with downloads up 14.5% from May (to 13,086,569 from 11.4 million), and again the change seems to be driven by (probably) a single large-ish Scala 2.11 adopter who isn't mirroring Maven Central (if this is you, maybe we should talk). Relatedly, the Sangria organization also saw a very big increase (+148%) in downloads in June, crossing the 1 million mark for the first time ever.
The number of Scala 3 downloads approximately doubled from May to June, but is still extremely low (6,006 downloads total for circe-core_3 and 9,616 for cats-core_3). As usual Scala.js downloads are a negligible fraction of total downloads (e.g. circe-core_2.13 has 32 times as many downloads as circe-core_sjs0.6_2.13 and circe-core_sjs1_2.13 combined).

Codecov Report

Merging #1793 (5ee2f58) into master (b6bfd9c) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1793      +/-   ##
==========================================
+ Coverage   86.07%   86.24%   +0.17%
==========================================
  Files          72       75       +3
  Lines        2499     2589      +90
  Branches      136      144       +8
==========================================
+ Hits         2151     2233      +82
- Misses        348      356       +8

Impacted Files
Coverage Δ

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
87.71% <0.00%> (ø)

.../main/scala/io/circe/jawn/JawnParserPlatform.scala
33.33% <0.00%> (ø)

.../main/scala/io/circe/jawn/CirceSupportParser.scala
95.16% <0.00%> (ø)

...ared/src/main/scala/io/circe/jawn/JawnParser.scala
84.21% <0.00%> (ø)

...re/shared/src/main/scala/io/circe/MapDecoder.scala
96.00% <0.00%> (+8.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6bfd9c...5ee2f58. Read the comment docs.


Fixed header on scroll

Hi Chris.
I'm running into some issues with a fixed header for a nav for which becomes fixed when it scrolls past the top of the viewport. It seems to cause the calculations to fail, as they don't seem to include the fixed header height because it's not fixed on page load.
Would the script be easy to modify to support this?
Thanks
Jason

Hi Jason - When the header scrolls into/out-of view, you could reinit gumshoe to redo the calculations. Alternatively, you could manually pass in an offset equal to the height of the eventual fixed header.
There's a huge performance hit on calculating heights and distances, especially while scrolling, so I deliberately avoid calculating the fixed header height through the scroll process.


Update modMagicEdits.lua

Updated magicmodsedits to have the non-boolean values use an Enabled field to turn on their function wrapping. Cleans up configuration to be more obvious.

Won't merge as-is but I'll see what from this merge I can utilise


Examples sse

Acts as manual validation for #55; relies on that patch to be merged first. Adds an example on how to do SSE with choo. def not greatest code ever, but it works. Thanks!

yay, fixed the linter

Welp, merging!


Bug:"Boost your productivity and take control of your life." written twice at homepage.

I will resolve it by either adding or removing it.

@sayan404 assignt this to me under JWOC.

I have assigned the issue to you. @rahat2134  . Happy Coding 🚀

thanks

@sayan404 please check pr .

Yea , have merged your PR. @rahat2134


stream_edit_subscribers: Remove unnecessary logging.

There is no need to log if the stream edit UI is not opened when an event for updating subscribers list is received and we should just return because this is not a bug. We do the same in other places where we just return early without logging because we do not need to make any updates.

Fixes:  https://chat.zulip.org/#narrow/stream/9-issues/topic/stream_edit_subscribers.20console.20logging

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @sahil839!


Review SVG implementation

At our Jan 22 meeting, we decided each developer would spend a little time investigating/reviewing some part of scenery.  I'm looking into SVG implementation (partly because this will relate to Pixi implementation), and adding documentation, questions, etc.  I created this issue to aggregate my commits so they can be reviewed and discussed.

Another commit in fbb7faad553bf43a8745c2cd86e8491d7a570544

I finished a cursory review of SVGBlock, tried to understand it and add some documentation where I felt it was missing.  I also marked the following 7 TODOs in the code (mainly as questions):
FittedBlock.js
      // TODO: I can't find documentation about forceAcceleration anywhere.  How is this used?  What is it for?  How does it work?
      this.forceAcceleration = ( renderer & Renderer.bitmaskForceAcceleration ) !== 0;

SVGBlock.js
  /**
   * Main constructor for SVGBlock.
   *
   * @param {Display} display - the scenery Display this SVGBlock will appear in
   * @param {number} renderer - the bitmask for the renderer, see Renderer.js
   * @param {Instance} transformRootInstance - TODO: Documentation
   * @param {Instance} filterRootInstance - TODO: Documentation
   * @constructor
   */

SVGBlock.js
      // TODO: Why are there such different ways of clearing the transform for this.svg vs this.baseTransformGroup?
      Util.unsetTransform( this.svg ); // clear out any transforms that could have been previously applied
      this.baseTransformGroup.setAttribute( 'transform', '' ); // no base transform

SVGBlock.js
    /**
     * Update the SVGBlock as part of a render step.  Called from Display.updateDisplay => BackboneDrawable.updateDisplay
     */
    update: function() {
      sceneryLog && sceneryLog.SVGBlock && sceneryLog.SVGBlock( 'update #' + this.id );

      // TODO: Shouldn't calling update on a disposed SVGBlock be an assertion error?
      if ( this.dirty && !this.disposed ) {
        this.dirty = false;

        //OHTWO TODO: call here!
        // TODO: What does the above TODO mean?
        while ( this.dirtyGroups.length ) {
          var group = this.dirtyGroups.pop();

          // if this group has been disposed or moved to another block, don't mess with it
          if ( group.block === this ) {
            group.update();
          }
        }
        while ( this.dirtyDrawables.length ) {
          var drawable = this.dirtyDrawables.pop();

          // if this drawable has been disposed or moved to another block, don't mess with it
          // TODO: If it was moved to another block, why might it still appear in our list?  Shouldn't that be an assertion check?
          if ( drawable.parentDrawable === this ) {
            drawable.update();
          }
        }

        // checks will be done in updateFit() to see whether it is needed
        this.updateFit();
      }
    },

I'm done reviewing this for the moment, reassigning to @jonathanolson for discussion.

Helpful review notes! Some had been handled over the years, I handled the remaining ones above. I believe the "call here!" note provided no value, it is working as intended. @samreid anything else to do here for now?

That's great, thanks! Closing.


New urls for sumstats documentation

We need a new location for sumstats documentation, so the old and new documentation can be made available in parallel.
The new urls should be in the format https://www.ebi.ac.uk/gwas/docs/gwas-ssf/
Here is a list of the document pages that need adding:
Format & validate https://www.ebi.ac.uk/gwas/docs/gwas-ssf/summary-statistics-format
Sumstats only form https://www.ebi.ac.uk/gwas/docs/gwas-ssf/submission-summary-statistics
Sumstats + metadata form https://www.ebi.ac.uk/gwas/docs/gwas-ssf/submission-summary-statistics-plus-metadata
We can then copy and paste the markup from the old pages.

@ljwh2
http://gwas-snoopy.ebi.ac.uk:9780/gwas/docs/gwas-ssf/summary-statistics-format
http://gwas-snoopy.ebi.ac.uk:9780/gwas/docs/gwas-ssf/submission-summary-statistics
http://gwas-snoopy.ebi.ac.uk:9780/gwas/docs/gwas-ssf/submission-summary-statistics-plus-metadata


Citing wrong paper for NEON tree data

I was just looking over the preprint and noticed that you're citing an outdated version of the wrong paper for the NEON Tree Data.
The NEON tree benchmark data is this publication https://doi.org/10.1371/journal.pcbi.1009180.

Thanks, we will do for camera ready.


infra cloud init fails, hanging stack-create

Does all of cloud init fail if a few of the scripts fail?    I'm running the latest rhel*.qcow2
May 13 17:38:00 localhost cloud-init: Loaded plugins: search-disabled-repos
May 13 17:38:01 localhost cloud-init: No package centos-release-openstack-liberty available.
May 13 17:38:01 localhost cloud-init: Error: Nothing to do
May 13 17:38:01 localhost cloud-init: 2016-05-13 17:38:01,254 - util.py[WARNING]: Failed running /var/lib/cloud/instance/scripts/part-010 [1]
Is the above failure fatal?  Is it because I'm indicating a pool-id that might not have a repo with the centos-release-openstack-liberty package in it?
May 13 17:38:01 localhost cloud-init: /var/lib/cloud/instance/scripts/part-011: line 102: os-collect-config: command not found
May 13 17:38:01 localhost cloud-init: 2016-05-13 17:38:01,285 - util.py[WARNING]: Failed running /var/lib/cloud/instance/scripts/part-011 [127]
is the above fatal as a result of the error in part-010?
The install is OK:
May 13 17:38:45 localhost cloud-init: + notify_success 'OpenShift node has been prepared for running ansible.'
May 13 17:38:45 localhost cloud-init: + curl -i -X POST -H 'X-Auth-Token: d70a0286a8344fa8a6c49d8712da512d' -H 'Content-Type: application/json' -H 'Accept: application/json' http://<IP_ADDRESS>:8004/v1/ad3598906ade4a15986530d2d518a77c/stacks/openshift-infra_host-qggq6xaqtdvy/2027bf0d-4f19-4f32-91c8-09aed34062de/resources/wait_handle/signal --data-binary '{"status": "SUCCESS", "reason": "OpenShift node has been prepared for running ansible.", "data": "OpenShift node has been prepared for running ansible."}'
May 13 17:38:45 localhost cloud-init: % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
May 13 17:38:45 localhost cloud-init: Dload  Upload   Total   Spent    Left  Speed
May 13 17:38:45 localhost cloud-init: 0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0#015100   157  100     4  100   153     13    505 --:--:-- --:--:-- --:--:--   506#015100   157  100     4  100   153     13    504 --:--:-- --:--:-- --:--:--   506
May 13 17:38:45 localhost cloud-init: HTTP/1.1 200 OK
May 13 17:38:45 localhost cloud-init: Content-Type: application/json; charset=UTF-8
May 13 17:38:45 localhost cloud-init: Content-Length: 4
May 13 17:38:45 localhost cloud-init: X-Openstack-Request-Id: req-916d33fa-1515-496b-b9d1-b1bfd6767d12
May 13 17:38:45 localhost cloud-init: Date: Fri, 13 May 2016 21:38:45 GMT
May 13 17:38:45 localhost cloud-init: null+ exit 0
but cloud-init still seems very sad:
May 13 17:38:45 localhost cloud-init: 2016-05-13 17:38:45,728 - cc_scripts_user.py[WARNING]: Failed to run module scripts-user (scripts in /var/lib/cloud/instance/scripts)
May 13 17:38:45 localhost cloud-init: 2016-05-13 17:38:45,733 - util.py[WARNING]: Running module scripts-user (<module 'cloudinit.config.cc_scripts_user' from '/usr/lib/python2.7/site-packages/cloudinit/config/cc_scripts_user.pyc'>) failed
May 13 17:38:45 localhost cloud-init: 2016-05-13 17:38:45,831 - templater.py[WARNING]: Cheetah not available as the default renderer for unknown template, reverting to the basic renderer.
May 13 17:38:45 localhost cloud-init: Cloud-init v. 0.7.6 finished at Fri, 13 May 2016 21:38:45 +0000. Datasource DataSourceOpenStack [net,ver=2].  Up 331.20 seconds
I'm going to run it again without a pool-id, to see if the code just magically does the right thing.

Hi Judd,
cloud-init runs all scripts even if some of them fail which is not optimal because then it might happen that the last script signals false-positive successful return code (https://github.com/redhat-openstack/openshift-on-openstack/blob/master/fragments/infra-boot.sh).
What I'm not sure about is why check didn't catch the missing os-collect-config:
https://github.com/redhat-openstack/openshift-on-openstack/blob/master/fragments/infra-boot.sh#L229
This check was added exactly for making sure that os-collect-config is present to avoid the situation you hit.

If you hit it again, could you please attach /var/log/cloud-init(-output).log?

Failed again.
Here are the params and cloud-init.log attached.  THANK YOU!  I'm totally blocked by this, and I'm actively trying to work it out so I can progress.
| links                 | http://<IP_ADDRESS>:8004/v1/c1b740d8571f4cb5aa66f8ddcfdec015/stacks/openshift/3e7ce435-7c5a-4905-a5d4-86bbf6a448f5 (self) |                           [22/1163]
| notification_topics   | []                                                                                |
| parameters            | {                                                                                |
|                       |   "OS::project_id": "c1b740d8571f4cb5aa66f8ddcfdec015",                                                                      |
|                       |   "node_docker_volume_size_gb": "25",                                                                                |
|                       |   "openshift_nodes_min": "1",                                                                                |
|                       |   "rhn_pool": "",                                                                                |
|                       |   "os_password": "",                                                                                |
|                       |   "flavor": "m1.medium",                                                                                |
|                       |   "master_server_group_policies": "[u'affinity']",                                                                           |
|                       |   "deploy_registry": "True",                                                                                |
|                       |   "rhn_password": "******",                                                                                |
|                       |   "os_username": "",                                                                                |
|                       |   "domain_name": "example.com",                                                                                |
|                       |   "loadbalancer_type": "neutron",                                                                                |
|                       |   "openshift_nodes_max": "5",                                                                                |
|                       |   "ssh_user": "cloud-user",                                                                                |
|                       |   "master_docker_volume_size_gb": "25",                                                                                |
|                       |   "os_tenant_name": "",                                                                                |
|                       |   "node_count": "4",                                                                                |
|                       |   "master_hostname": "openshift-master",                                                                                |
|                       |   "deployment_type": "openshift-enterprise",                                                                                |
|                       |   "OS::stack_name": "openshift",                                                                                |
|                       |   "autoscaling": "False",                                                                                |
|                       |   "master_count": "3",                                                                                |
|                       |   "os_region_name": "",                                                                                |
|                       |   "deploy_router": "True",                                                                                |
|                       |   "rhn_username": "dellcloudsol",                                                                                |
|                       |   "node_hostname": "openshift-node",                                                                                |
|                       |   "internal_subnet": "<IP_ADDRESS>/24",                                                                                |
|                       |   "skip_ansible": "False",                                                                                |
|                       |   "openshift_ansible_git_url": "",                                                                                |
|                       |   "infra_hostname": "infra",                                                                                |
|                       |   "skip_dns": "False",                                                                                |
|                       |   "OS::stack_id": "3e7ce435-7c5a-4905-a5d4-86bbf6a448f5",                                                                    |
|                       |   "extra_repository_urls": "[]",                                                                                |
|                       |   "os_auth_url": "",                                                                                |
|                       |   "external_network": "nova",                                                                                |
|                       |   "loadbalancer_image": "",                                                                                |
|                       |   "ssh_key_name": "key_name",                                                                                |
|                       |   "lb_hostname": "lb",                                                                                |
|                       |   "openshift_ansible_git_rev": "",                                                                                |
|                       |   "openshift_sdn": "openshift-sdn",                                                                                |
|                       |   "dns_nameserver": "[u'<IP_ADDRESS>', u'<IP_ADDRESS>']",                                                                              |
|                       |   "server_image": "rhel72"                                                                                |
|                       | }                                                                                |
| parent                | None                                                                                |
| stack_name            | openshift                                                                                |
| stack_owner           | None                                                                                |
| stack_status          | CREATE_IN_PROGRESS                                                                                |
| stack_status_reason   |                                                                                |
| stack_user_project_id | 9c985405ca194bc398eda5b9ff8c2241                                                                                |
| tags                  | null                                                                                |
| template_description  | Deploy Atomic/OpenShift 3 on OpenStack.                                                                                |
| timeout_mins          | 120                                                                                |
| updated_time          | None                                                                                |
+-----------------------+------------------------------------------------------------------------------------------------------------------------------+
2016-05-16 16:09:05 [openshift]: CREATE_IN_PROGRESS  Stack CREATE started
2016-05-16 16:09:05 [ansible_keys]: CREATE_IN_PROGRESS  state changed
....
Gist of the cloud-init.log:  https://gist.github.com/juddmaltin-dell/cc84f450e3778062abd8d257affcdcf3

The test here fails with a false positive:
https://github.com/redhat-openstack/openshift-on-openstack/blob/master/fragments/infra-boot.sh#L162
because it's called with --no-block
It fails because the os-collect-config service was installed without the os-collect-config package being installed.
os-collect-config lives in the rhel-7-server-openstack-8-director-rpms repo on another box of mine.  But it does not live in any repos available to my OpenShift NFR pool-id.
Ok, so I got to the root of my problem.  I was out of NFR subscriptions.  But those errors should be fixed, regardless.

Re-Opened because it's still maybe a bug.

Thanks for deep investigation. Yes, this is a bug and the "systemctl is-enabled os-collect-config" is insufficient - the reason is that the service file is not part of the package but is always created here:
https://github.com/redhat-openstack/openshift-on-openstack/blob/master/collect-config-setup/fragments/start_config_agent.sh#L13
Yum returns success event if some packages fail to install (https://github.com/redhat-openstack/openshift-on-openstack/blob/master/collect-config-setup/fragments/install_config_agent_yum.sh#L19) - this is not the first time I hit this "feature" which I really don't like :/. As a first step we should install os-collect-config in a separate "yum install".

Is it possible to include more than one pool?  The OpenShift NFR pool is not reliably responding with -director- repos which include the os-collector-config package.

Thank you, fixed.


Always show OpenGov suffix

#86938x68c

Task linked: CU-86938x68c Android. Governance selector. Always show OpenGov suffix


SyntaxError: Unexpected token only with PRETTY_PRINT

What's the issue?
Setting formatting to PRETTY_PRINT causes syntax error.
How do we reproduce the issue?
<EMAIL_ADDRESS><EMAIL_ADDRESS>Node v12.4.0
Linux Mint 19.1 64bit
import compiler from '@ampproject/rollup-plugin-closure-compiler';

export default {
	input: `/tmp/extension-util.js`,
	plugins: [
		compiler({
			languageOut: 'ECMASCRIPT_2019',
			formatting: 'PRETTY_PRINT',
		}),
	],
	treeshake: false,
	output: {
		file: `/tmp/output.js`,
		format: 'esm',
	}
}

input file: https://gist.github.com/mikob/acd7906db53ed5cf9e4178c853b951dc
Additional context
The actual issue seems to have nothing to do with the line in question:
      return (frame.functionName || '').indexOf('StackGenerator$$') === -1;

because when I move code around, it will happen on different seemingly arbitrary lines. Perhaps a memory issue?
src/modules/extension-util.ts → package/dist/modules/extension-util.js...
(node:27095) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected token (1945:15)
    at _class.pp$4.raise (/home/mikob/workspace/lipsurf/chrome-extension/node_modules/acorn/dist/acorn.js:2828:15)
    at _class.pp.unexpected (/home/mikob/workspace/lipsurf/chrome-extension/node_modules/acorn/dist/acorn.js:689:10)
    at _class.pp$3.parseExprAtom (/home/mikob/workspace/lipsurf/chrome-extension/node_modules/acorn/dist/acorn.js:2272:12)
    at _class.parseExprAtom (/home/mikob/workspace/lipsurf/chrome-extension/node_modules/acorn-dynamic-import/lib/index.js:75:117)
    at _class.pp$3.parseExprSubscripts (/home/mikob/workspace/lipsurf/chrome-extension/node_modules/acorn/dist/acorn.js:2091:21)
    at _class.pp$3.parseMaybeUnary (/home/mikob/workspace/lipsurf/chrome-extension/node_modules/acorn/dist/acorn.js:2068:19)
    at _class.pp$3.parseExprOps (/home/mikob/workspace/lipsurf/chrome-extension/node_modules/acorn/dist/acorn.js:2012:21)
    at _class.pp$3.parseMaybeConditional (/home/mikob/workspace/lipsurf/chrome-extension/node_modules/acorn/dist/acorn.js:1995:21)
    at _class.pp$3.parseMaybeAssign (/home/mikob/workspace/lipsurf/chrome-extension/node_modules/acorn/dist/acorn.js:1970:21)
    at _class.pp$1.parseExport (/home/mikob/workspace/lipsurf/chrome-extension/node_modules/acorn/dist/acorn.js:1433:33)
(node:27095) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:27095) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Took a look with the debugger enabled... this is going to take awhile to figure out.
Here's the output post closure compilation, and acorn is unable to parse.
https://gist.github.com/kristoferbaxter/88105027b3878eaabc4b752639ebd730

If you're interested in debugging, you can enable the debugger in debug.ts, and locally link the installation of @ampproject/rollup-plugin-closure-compiler.

Found the root cause here, several transforms assume they are running on minified code post compilation.
We should enable testing for all conditions with pretty printing to fix and keep regressions from occurring.

Resolved with 847bca7. Will release with 0.20.0.


Parent set to clip children with no children is drawn as completely black

Godot version
v4.0.beta14.official [28a24639c]
System information
Windows 10, GTX 1080. Tested in various render backends
Issue description
If a node is set to  Clip Children: Clip Only or Clip+Draw, and it has no visible children, it is drawn as completely black. The expected behavior is drawn normally for Clip+Draw, and made not visible for Clip Only.
Steps to reproduce

Create any node that is drawn in 2D (e.g. Polygon2D, Sprite2D)
Set its Clip Children to anything other than Disabled.
Optional: Create a child node for it that is either non-drawing (e.g. Node2D), or is hidden (i.e. Set Visible to false)

Minimal reproduction project
reproduce_clip_nochildren.zip

Duplicate of https://github.com/godotengine/godot/issues/69179


Switch to using the modified Zipkin exporter from OpenCensus

In order to reduce similar code, we need to identify and request/make changes to the OpenCensus implementation in order to use their (or most of their) code.
@dtillman Please leave a comment if you have more details on what needs to be done. Thanks.

This is done


Page tags cannot be resolved

Page tutorials/second.md contains tags that cannot be resolved by AEM tag manager

Fixed


Add new stable version to Microsoft.Security : 2018-06-01 with pricing configuration

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: amireluk sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-js

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-node

Automation for azure-sdk-for-java

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

@sergey-shandar - I've addressed your request with commit 911838c

@simonjaeger any progress on this one?

@amireluk are you working on the PR?

Closing the PR. @amireluk let me know if you need to reopen it.

@sergey-shandar please reopen the CR.
I want to push new changes.


Docs: fix duplicate CSS rule in _ie11.scss

This rule is already on line 8
Found via SonarQube: https://sonar.trimble.tools/project/issues?id=Modus.trimble%3AModusReactBootstrap&languages=css&open=AYPp9PzTx792aEMoXmPw&resolved=false

Failing build will be fixed by PR


Feat list insert and perf improvements rolled into a proper pr

potentially closes #360

after we settle on the implementation it will need tests but I'm not sure I will have the time to implement them I hacked this implementation together in abt an hour in my breaks from work :P

on a naive hand checking list->insert works as I would expect it to and has the following form
list->insert(idx, val)

Yup no worries about the tests, I can do those.

This all looks good to me, I'm gonna merge this into the repo, add tests, then merge to v0.11.3.
Thanks for the help on this!

One thing I noticed with my last pr my name in the commits went missing and I'm not listed as having contributed

Github pr sys can be a bit janky sometimes

Huh, I've been squash-and-merging commits to master for the past while to keep a cleaner history.
https://github.blog/changelog/2019-12-19-improved-attribution-when-squashing-commits/ says that should also keep your contributions but apparently not...
I'll try just merging this one and seeing if that does it.

Huh, I've been squash-and-merging commits to master for the past while to keep a cleaner history.
https://github.blog/changelog/2019-12-19-improved-attribution-when-squashing-commits/ says that should also keep your contributions but apparently not...
I'll try just merging this one and seeing if that does it.

it usually does, see SnowflakeOS a repo I made contribs for despite squashing it kept my name so idk what happened to github lol

Ok, then in that case I'll just squash and merge again?


ci(deps): update main workflow node.js to 20.13.1

Issue
The .github/workflows/main.yml workflow is intended to run with the same Node.js version as defined in https://github.com/actions/runner/blob/main/src/Misc/externals.sh in order to provide a representative CI test.
The workflow currently uses Node.js 20.8.1
https://github.com/cypress-io/github-action/blob/76647aab959ed8c5508c2a310420a36bb9bf3157/.github/workflows/main.yml#L21
whereas the GitHub runner has been updated to use NODE20_VERSION="20.13.1" in the meantime
https://github.com/actions/runner/blob/2a7f327d93fb79326c974f4858ce62c3b81c580a/src/Misc/externals.sh#L11
Change
Update Node.js in .github/workflows/main.yml from 20.8.1 to 20.13.1.

This PR fails with Node.js 22 picking up 22.5.0. This version contains a regression https://github.com/nodejs/node/issues/53902. The regression is fixed in 22.5.1 which was released in the last hour. GitHub will catch up and it should all be good soon. Nevertheless, I will leave the PR in draft state until all tests are passing. The PR is not urgent.


option to skip installing Python stuff

I don't need docker-compose or docker-py, so the pip installs of these packages are superfluous.  It'd be great to have an option to skip their install.

I'd happily take a PR for this, otherwise it will be some time until I get around to this.

done! https://github.com/angstwad/docker.ubuntu/pull/92


[SPARK-20883][SPARK-20376][SS] Refactored StateStore APIs and added conf to choose implementation

What changes were proposed in this pull request?
A bunch of changes to the StateStore APIs and implementation.
Current state store API has a bunch of problems that causes too many transient objects causing memory pressure.

StateStore.get(): Option forces creation of Some/None objects for every get. Changed this to return the row or null.
StateStore.iterator(): (UnsafeRow, UnsafeRow) forces creation of new tuple for each record returned. Changed this to return a UnsafeRowTuple which can be reused across records.
StateStore.updates() requires the implementation to keep track of updates, while this is used minimally (only by Append mode in streaming aggregations). Removed updates() and updated StateStoreSaveExec accordingly.
StateStore.filter(condition) and StateStore.remove(condition) has been merge into a single API getRange(start, end) which allows a state store to do optimized range queries (i.e. avoid full scans). Stateful operators have been updated accordingly.
Removed a lot of unnecessary row copies Each operator copied rows before calling StateStore.put() even if the implementation does not require it to be copied. It is left up to the implementation on whether to copy the row or not.

Additionally,

Added a name to the StateStoreId so that each operator+partition can use multiple state stores (different names)
Added a configuration that allows the user to specify which implementation to use.
Added new metrics to understand the time taken to update keys, remove keys and commit all changes to the state store. These metrics will be visible on the plan diagram in the SQL tab of the UI.
Refactored unit tests such that they can be reused to test any implementation of StateStore.

How was this patch tested?
Old and new unit tests

Test build #77362 has started for PR 18107 at commit 03f5bf3.

Test build #77362 has finished for PR 18107 at commit 03f5bf3.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class StateStoreId(
case class StateStoreStats()
case class UnsafeRowTuple(var key: UnsafeRow = null, var value: UnsafeRow = null)
trait StateStoreWriter extends StatefulOperator

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77362/
Test FAILed.

Test build #77363 has started for PR 18107 at commit d645b41.

Test build #3755 has started for PR 18107 at commit d645b41.

Test build #3755 has finished for PR 18107 at commit d645b41.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class StateStoreId(
case class StateStoreStats()
case class UnsafeRowTuple(var key: UnsafeRow = null, var value: UnsafeRow = null)
trait StateStoreWriter extends StatefulOperator

Test build #77363 has finished for PR 18107 at commit d645b41.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class StateStoreId(
case class StateStoreStats()
case class UnsafeRowTuple(var key: UnsafeRow = null, var value: UnsafeRow = null)
trait StateStoreWriter extends StatefulOperator

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77363/
Test FAILed.

Merged build finished. Test FAILed.

Test build #77386 has started for PR 18107 at commit 324fc24.

Test build #77386 has finished for PR 18107 at commit 324fc24.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77386/
Test PASSed.

Test build #77402 has started for PR 18107 at commit 3e49621.

Test build #77402 has finished for PR 18107 at commit 3e49621.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class StateStoreId(
case class UnsafeRowPair(var key: UnsafeRow = null, var value: UnsafeRow = null)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77402/
Test PASSed.

Test build #77546 has started for PR 18107 at commit baba63d.

Test build #77547 has started for PR 18107 at commit 5c0961c.

Test build #77549 has started for PR 18107 at commit fdfdcab.

LGTM pending tests.

Test build #77546 has finished for PR 18107 at commit baba63d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class UnsafeRowPair(var key: UnsafeRow = null, var value: UnsafeRow = null)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77546/
Test PASSed.

Test build #77547 has finished for PR 18107 at commit 5c0961c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77547/
Test PASSed.

Test build #77549 has finished for PR 18107 at commit fdfdcab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77549/
Test PASSed.

Merged build finished. Test PASSed.

Thanks! Merging to master.


Not able to pull publication title from Hashnode

Describe the bug
Not able to use astro-hashnode from the steps mentioned in the README.md
To Reproduce
Steps to reproduce the behavior:

npm create astro@latest
follow along the CLI prompts with TS enabled
npm run astro add @matthiesenxyz/astro-hashnode in the project
use the example URL it provided in README.md
wait for Astro-Hashnode Integration Setup Complete to appear
open the project on 4321 but it says not found title of the publication data

Expected behavior
It pulls the data correctly or shows a warning/steps of what to be done.
Screenshots

@rishi-raj-jain can you try taking the https:// off the domain url?(GraphQL really does not like http:// or https://... as well as add verbose: true to show the full output. in the first photo the vite warnings look like your local instance has been looping... if thats true those warnings can be ignored.

@Adammatthiesen
Would we able to enforce the removal of https?

https://github.com/MatthiesenXYZ/astro-hashnode/blob/main/package/src/schemas/user-config.ts#L12
we can update the zod configuration to throw an error if it doesn't matches the URL pattern the package requires.
what do you think?

The new PR I just setup, adds the ability to handle that, using functions to remove the http, or https from the string.

@rishi-raj-jain Newest update should resolve that issue!


fix misalignment

The old icon system didn't force any node size on the icons. This led to icons having a size related to the character size within them. This also made inconsistent vertical spacing between these lines. My fix specifies a certain font size for each character an a icon size of 16 pt.
All icons are now using the font awesome charset.

Hi Jérôme,
I tried this on overleaf (I have no way to compile on my local machine) and it looks good.
Thank you for your contribution!


Update to 10.13.4 and it be more unreliable

When update to 10.13.4 it show 3-rd wifi card in system preference and all the kexts are in good states.
It sometimes works but i dont find it regular when it will be fine and most time it show 3-rd wifi card.

Please backup these kexts before removing.
There are 3 drivers for Broadcom wi-fi in 10.13, and nobody knows why.

I have test when i reboot from Windows and it shows 3-rd
But when i boot macOS with cold boot and it works fine.
All the kexts works well so i dont know what happend with this.
Thanks.

The newest version test fine now and i will test more later.
Temp closed this issue and wait for feedback.
Thanks for this well kext!


Error on biding datepicker model value on edit mode

[ * ] bug

I have a sample code which uses dp-date-picker, everything is Ok and working except on editing form which has dp-date-picker is in. Value displayed in input is in Jalali format but value is't.
I have stackblitz whitch has this problem too.
Online:
https://angular-je2t9c.stackblitz.io/
Edit:
https://stackblitz.com/edit/angular-je2t9c
What is wrong?

As you see in document model object is moment instance which is use jalali-moment
so when you need to use its value as jalali date you have to format it as the following code
{{dataObject.date.format('YYYY/MM/DD')}}

I close this issue due to #83


Create dependabot.yml

Add a DependaBOT

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d5d58a5) 47.73% compared to head (a53f280) 47.73%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   47.73%   47.73%
=======================================
  Files          13       13
  Lines        2055     2055
=======================================
  Hits          981      981
  Misses        929      929
  Partials      145      145

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.