fix: updating last_log value in TripletLossPlain

Fix for existing bug: self.last_logs value in oml.losses.triplet.TripletLossPlain is never updates and always returns empty dictionary which was set in __init__ method.

@alexmelekhin Thanks, nice catch! We were not aware of this problem because this loss is not used in any pipeline since the implementation with a different signature is used instead.
PS. How did you find that problem?

PS. How did you find that problem?

I imported that loss directly and used it in my research.


etcher: remove

Description of changes
#295770
Also closes #261626, since the issue with Electron 25 (still EOL) was never fixed upstream.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

All 1.19 pre-releases use Electron 25 (EOL in Nixpkgs) and are subject to balena-io/etcher#4150, making the bump failing for users on every other Linux distro (which is why Etcher is at 1.18.14 on Repology, and even that doesn't work).
From my experience, building from source offline isn't possible since 1.18.12, due to the transition from package-lock.json to the incomplete npm-shrinkwrap.json, and even for 1.18.11, the source-built Etcher failed to flash any drives for obscure reasons.
I've also tried using the appimage, which succeeds at every step before flashing, which fails due to an unresolved issue: #205082. I think that's the only direction to go, if anyone wants to play around.
So as the maintainer, I basically found no way to bump this package but keep it at version 1.18.12. I'd suggest existing users (are there really any?) switch to better alternatives, such as rpi-imager.


debugger: Show progress message while flashing is in progress

Add basic support to show a progress message while flashing is in progress. The supports_progress_reporting  flag of the client is respected.
Currently, only a notification that flashing is in progress is shown. This could be enhanced with additional information, like a proper progress bar.

bors merge=yatekii


Improve 64bit elf support

Summary
Impact
Testing

@xiaoxiang781216 I don't know what is going on here.  I don't understand why it failed.  There is something odd with stm32f4discovery:module, but the output is not interpretable and does not seem to be an error.  I have restart the checks several time but they only do the Docs/doc then stop with no further messages.

@patacongo I believe it is triggered by this in testbuild.sh
  # Ensure nuttx and apps directory in clean state

  if [ -d $nuttx/.git ] || [ -d $APPSDIR/.git ]; then
    if [[ -n $(git -C $nuttx status -s) ]]; then
      git -C $nuttx status
      fail=1
    fi

If normalize changes a defconfig file all the remaining tests will fail.  We see this here
2020-05-31T19:11:30.8945191Z ====================================================================================
2020-05-31T19:11:30.8968015Z Configuration/Tool: stm32f4discovery/module,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
2020-05-31T19:11:30.9059881Z ------------------------------------------------------------------------------------
2020-05-31T19:11:30.9060022Z   Cleaning...
2020-05-31T19:11:36.8669871Z   Configuring...
2020-05-31T19:11:36.8817755Z   Copy files
2020-05-31T19:11:36.8971116Z   Select CONFIG_HOST_LINUX=y
2020-05-31T19:11:36.9096081Z   Refreshing...
2020-05-31T19:11:39.7550237Z   Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
2020-05-31T19:11:39.7573155Z   Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
2020-05-31T19:11:40.0977181Z   Building NuttX...
2020-05-31T19:12:04.9881712Z   Normalize stm32f4discovery/module
2020-05-31T19:12:05.5552111Z 51d50
2020-05-31T19:12:05.5552403Z < CONFIG_STM32_CCMEXCLUDE=y
2020-05-31T19:12:05.5555891Z Saving the new configuration file
2020-05-31T19:12:06.0344867Z HEAD detached at pull/1157/merge
2020-05-31T19:12:06.0345077Z Changes not staged for commit:
2020-05-31T19:12:06.0345223Z   (use "git add <file>..." to update what will be committed)
2020-05-31T19:12:06.0346145Z   (use "git checkout -- <file>..." to discard changes in working directory)
2020-05-31T19:12:06.0346233Z
2020-05-31T19:12:06.0346373Z 	modified:   boards/arm/stm32/stm32f4discovery/configs/module/defconfig
2020-05-31T19:12:06.0346469Z
2020-05-31T19:12:06.0346845Z no changes added to commit (use "git add" and/or "git commit -a")
2020-05-31T19:12:06.0506069Z ====================================================================================

@patacongo @xiaoxiang781216 Would you be open to a patch that causes testbuild.sh to echo out the error stats in a github actions format that allows for annotating the build with the actual errors instead of having to dig for them in the logs (especially with parallel runs)?  I know we want to keep the CI stuff out of this as much as possible, but this would be just some extra a little syntax around the message that github is able to pick up.
We can also define our out syntax and have github understand that, but I dont think it gains us much.
See this https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message

@patacongo @xiaoxiang781216 Would you be open to a patch that causes testbuild.sh to echo out the error stats in a github actions format that allows for annotating the build with the actual errors instead of having to dig for them in the logs (especially with parallel runs)? I know we want to keep the CI stuff out of this as much as possible, but this would be just some extra a little syntax around the message that github is able to pick up.
We can also define our out syntax and have github understand that, but I dont think it gains us much.
See this https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message

This is probably the wrong place to be having this discussion.  I am pretty open to changes to testbuild.sh.  There are only two "brick walls" that we must not cross:

testbuild.sh is a stand-alone program used by many people in their own test environments.  It is not inherently a part of the CI build tools; it is only used by the CI build tools.  No changes to testbuild.sh must effect the usability for people who use testbuild.sh in their own non-github, non-CI environment for testing.

I can't include in unconditional logic that depends on GIT.  It must be usable by the many NuttX users (the majority I think), who use their own CM which may or many not be GIT.  We must not break that.

Having said that, any of the above may be circumvented by simply adding command line parameters that are used only in the NuttX CI build.  If those parameters are not present, the legacy behavior is retained and no NuttX user is impacted.  There should be no change in the experience for those users who have build their own test harnesses around testbuild.sh.
There are already such specialized command line settings.  This one:
  -G Use "git clean -xfdq" instead of "make distclean" to clean the tree.
     This option may speed up the builds. However, note that:
       * This assumes that your trees are git based.
       * This assumes that only nuttx and apps repos need to be cleaned.
       * If the tree has files not managed by git, they will be removed
         as well.

If the changes that you want to make to testbuild.sh for CI usage diverge too much from the end-user expectation, we should consider an alternative version, perhaps in incubator-nuttx-testing that does not have these necessary restrictions.
Re-using code is a good thing.  But this is not such complex code that the sharing argument justifies an overly complex tool or a tool that cannot meet both needs.

@xiaoxiang781216 I think that refreshing the  stm32f4discovery:module config to remove that config flag makes sense.  Before it depended on CONFIG_ELF but that was not set but the config had LIBC_MODLIB enabled so it the CCM needed to be disabled.  Now this dependency is handled correctly.

I will took at this problem when I come to office.


Implement UI for CourseInfoActivity

UI for CourseInfoActivity containing a WebView has been implemented
@nasthagiri @rohan-dhamal-clarice - Please review.
JIRA: https://openedx.atlassian.net/browse/MOB-1446
SubTask of  JIRA: https://openedx.atlassian.net/browse/MOB-1443
Screen shot -

Otherwise seems fine.

Updated as per comments

Updated code as per comments and added offline mode messages.
@aleffert @rohan-dhamal-clarice - Please review

:+1:


No Webmention Support with Indirect Source Link In Post

TLDR: I believe the bridgy app is associating the wrong link to my actual post due to a successful server side redirect, but an unsuccessful client side redirect
This is a bit of an odd issue because I believe I am trying to do something with links in posts that was not intended, so I will try to explain this in a bit more depth:

I have a static website at https://slyduda.com
In an effort to shorten links for the sake of social media length limits I bought the domain https://sly.re
I have a double redirect that goes from sly.re/[id-of-post] -> slyduda.com/p/[id-of-post] -> slyduda.com/post/[SLUG-of-post]
The first redirect is a 301 directly from nginx, but the second redirect is from html headers
For clarity, I am using the following for a client-side redirect

As an example I have this successful Bridgy Twitter post: https://twitter.com/i/web/status/1581159763227787264
The last link is not a bridgy link, but a custom link that my static blog generates and makes invisible to the readers in the e-content of my website post located here: https://slyduda.com/post/7c9255e6-832e-4632-b7a2-978f30a9046b/
Clicking the link in the post will take the user from: https://sly.re/4thf0g -> https://slyduda.com/p/4thf0g -> https://slyduda.com/post/7c9255e6-832e-4632-b7a2-978f30a9046b/
This part of the Bridgy docs explains why syndication might be broken. Along with that in my Bridgy dashboard the responses show No webmention support for slyduda.com/p/4thf0g which tells me that it successfully redirected from point A to B but not B to C
I am under the assumption that Bridgy is unable to take into account a client side redirect (probably for good reason), but I am still wondering if what I have explained is accurate and if there are any alternative solutions!
If not, no worries, and thank you for the help in advance!

Hi! Thanks for all the details. You're right, the problem here is probably that Bridgy doesn't support client-side redirects: https://github.com/snarfed/bridgy/issues/253. It shouldn't be too hard to add that support though, I'd happily accept PR(s)!

Oh, btw, you might consider deprioritizing your URL shortening. Of the major social networks that limit post length, eg Twitter and Mastodon, they all switched to counting URLs at a fixed number of characters, eg 23 for Twitter, a long time ago. None that I'm aware of count the full length of URLs against you any more.
More background:

https://indieweb.org/permashortlink#Why ("Older reasons that apply less or not at all nowadays")
https://indieweb.org/shortlink#Criticism
https://indieweb.org/URL_design#Avoid (note that char counting isn't one of the reasons)

Awesome! I will do some work on this today and tomorrow then :)
The fixed link character is new information to me and I appreciate the resources. If it becomes too difficult to implement elegantly I will de-prioritize it like you are suggesting.

Great! You'll probably want to add it here:
https://github.com/snarfed/webutil/blob/9ed4fb34e1371f38374ba0bc1f5647a48090bb01/util.py#L1970-L1988
New test(s) would go into test_util.py.

Merging into #253 as a dupe.


Don't Work.  hash.md5() in Uppercase

Hello,
I'm testing the hash module in windows
I set up to detect yarac64.exe

import "hash"
rule test{
condition:
hash.md5(0,filesize)=="E0660C01E0F085407196F691E5B65092"
}
No error, but not detected.
Uppercase letters are not supported!!!
I want to know if uppercase is not supported in the original.

An easy solution would be to automatically convert the case of hashes to the preferred case during the rule compilation stage.
That way, rules could be written to use either lower-case, upper-case or a combination of those cases when comparing hashes and it'll always work with YARA without YARA having to check different case comparisons at run-time when scanning.

An easy solution would be to automatically convert the case of hashes to the preferred case during the rule compilation stage.
That way, rules could be written to use either lower-case, upper-case or a combination of those cases when comparing hashes and it'll always work with YARA without YARA having to check different case comparisons at run-time when scanning.

Good idea.


Show/Hide link showing when the content does not require truncation when type="html"

When passing html into text with type="html", I am seeing the Show/Hide link when there is nothing else to show. Clicking the link does nothing.
I believe this is because v-if="text.length >= length" naively includes the entire html string when type="html", so though the dependency html-truncate can safely truncate the html, vue-truncate-collapsed does not correctly calculate when it needs to truncate since it's including all the html and not just the text.

Solved by #17


ToolkitCleaner: CleanObjects operation times out after 300 seconds

I tried using the ToolkitCleaner construct in our staging environment which is shared by 5 or so developers for the past 2+ years.
Obviously, that account has accumulated lots of junk in terms of S3 artifacts and ECR images in the Bootstrap stack.
I use the construct in the following way:
new ToolkitCleaner(this, 'ToolkitCleaner', {
    // Use the dryRun prop to only output the number of assets and total size that would be deleted but without actually deleting assets.
    dryRun: true,
    // Do not delete assets created in the last 30 days even if unused
    retainAssetsNewerThan: Duration.days(30),
});

After invoking the State Machine manually, I get the following error:
RequestId: af66aa63-3b46-4385-ac8c-1077d3b9d14c Error: Task timed out after 300.00 seconds

Hi @Dzhuneyt,
Does it ultimately succeed if your rerun the state machine multiple times?

I've ran it with the Dry Run flag just to see how much space would be reclaimed, so I doubt a re-run will fix it in this case because it's just repeating the same operation.
I will try now without the dry run flag, which I suspect might get it to work after a few retries.

I tried re-running a couple of times even without the dryRun flag (so it actually deletes resources while it reaches the 300 seconds timeout). But it seems to timeout even with that scenario.
Is it possible that the Lambda for cleaning actually does some "data collecting" first, before going forward with deletions of these assets? If that's the case, it's possible that it times out during this first phase, so it never actually deletes anything, not making the job of subsequent re-runs faster.

Either case, allowing to configure the timeout to consumers of the ToolkitCleaner construct, or setting the default to 15 minutes, are both good solutions.

Is it possible that the Lambda for cleaning actually does some "data collecting" first, before going forward with deletions of these assets? If that's the case, it's possible that it times out during this first phase, so it never actually deletes anything, not making the job of subsequent re-runs faster.

It lists up to 1,000 objects versions, deletes the objects that satisfy the conditions to be deleted and then loops until there are no more objects versions to list (by listing again, etc.), see https://github.com/jogold/cloudstructs/blob/master/src/toolkit-cleaner/clean-objects.lambda.ts#L16. I expect that after 5 minutes some of your objects were deleted.

I also confirm that the total size of the S3 bucket drops by 2-5 GB after every run of the State Machine. This means it is actually deleting stuff, it's just too much stuff to delete. The total size of the bucket right now is 50GB+.
Just thinking out loud - rather than bumping up the timeouts of that Lambda, another option could be to float the loop to the State Machine itself, so it chunks the big array of S3 objects and passes them to a downstream Lambda that works on X items at a time, making the Step Machine split the big array and call that Lambda recursively.

Just thinking out loud - rather than bumping up the timeouts of that Lambda, another option could be to float the loop to the State Machine itself, so it chunks the big array of S3 objects and passes them to a downstream Lambda that works on X items at a time, making the Step Machine split the big array and call that Lambda recursively.

Will have a look at this. Reopening here.

I also confirm that the total size of the S3 bucket drops by 2-5 GB after every run of the State Machine. This means it is actually deleting stuff, it's just too much stuff to delete. The total size of the bucket right now is 50GB+

@Dzhuneyt how is it now with a 15 minutes timeout?

Unfortunately, I can no longer easily reproduce, because after plenty of re-runs of the State Machine, I was able to purge a lot of junk assets, so now the operation completes without any timeouts, even with the previous timeout configuration.


Running on Docker

Hello,
Trying to get bitsandbytes running on docker containers from Nvidia-container-registry has been an arduous experiment at best. Any tips to get bitsandbytes running on a container? I have tried installing from pip as well as from source to no avail

I had same problem: https://github.com/TimDettmers/bitsandbytes/issues/105
I was lucky with custom deepspeed docker image ( https://zzhou.info/2022/11/22/deepspeed_docker/ ) and even with nvidia/cuda:11.7.1-cudnn8-runtime-ubuntu20.04


Sending from Central System

So question I have setup a basic Central System it receives requests from the CP.
But how does one actually then implement calls from CS to CP. I have system where main thread starts two threads one flask HTTP thread for REST API calls and one for OCPP 1.6, the main thread also does some other tasks. The threads between each other communicate via a queue, so how would I send requests to the CP?
I think the documentation around sending from CS to CP is lacking.

This thread can provide you some good insight!!
https://github.com/mobilityhouse/ocpp/issues/86

This package is async and not thread safe. I wouldn't recommend to use this package in the setup you describe.
I guess it's not impossible, but it's tricky do execute correctly.


mapbox draw plugin

closes #59

[ ] Shiny
[ ] Ipywidget
[ ] Pass geojson to DrawControl
[ ] Get FeatureCollection from DrawControl


Documentation says Provider is synchronous, yet Marvel Example uses asynchronous method with Provider

It says "Provider is a powerful tool for caching synchronous operations when combined with [ref.watch](https://riverpod.dev/docs/concepts/reading#using-refwatch-to-observe-a-provider)."
Yet the marvel example uses a Provider however the object it is providing has an async method:
https://github.com/rrousselGit/riverpod/blob/2f03ee04f3176dced8cccd27678df03c27970085/examples/marvel/lib/src/marvel.dart#L36
This is conflicting. Can you please clarify?

I'm not understanding what your issue with fetchCharacters is.
This method isn't used by the provider. It's simply exposed for other providers to use
What exactly is conflicting here?

Bear in mind, I'm new to Riverpod.
"This method isn't used by the provider. It's simply exposed for other providers to use"
So what would be an example of a method that is used by a provider?
Also, its not clear why he is using Provider for this pretty complicated Marvel Repository as https://riverpod.dev/docs/concepts/providers says that StateNotifier is for complex states.


remove " " and "\n" in end of mysql statement name.

As your recommend, I look for index of new line and space both .
then we can get a span name without "\n" and " " in the end.

can you please add p6spy as this prevents same issue there also

@qinhang3 ps you can add commits to your branch instead of raising new pull requests. Adding new pull requests pollutes the issues list.


Allow Expanding Suggestions with Mulitline details

Fixes #18490
Bug
For completion items with no documentation but a long detail string, we currently do not allow expansion.
Fix
Allow expanding the item if it either has a documentation string or has new line characters in its detail string.

@joaomoreno is the suggest UI

@joaomoreno Here's what that looks like:

I think expanding everything results in an odd ux. It indicates that there is additional information when there is none.

True, I take it back.


[pulsar-broker] clean up producer/consumer result from connection-cache

Motivation
as discussed at : #4138
fixing: clearing producer/consumer result from cnx cache.

run integration tests


Git Pre-commit Hook Bug

If you do not have any .js changes, the precommit hook will error out, due to the part after the &&.

Fixed by #40


automatic discovery of tables and functions have error

this is my config.yaml

Can you help me resolve this issue?

Hi @CrazyBug-11
Could you possibly share the structure of your database here? Including some data would be helpful as well. You can easily export the database structure using pgAdmin. This would greatly assist in understanding the issue at hand.

sql.zip
Hi @sharkAndshark
This script describes the schema of my two schemas (public/ldx). I hope you can tell me if Martin supports publishing new tables after startup.

I hope that after Martin starts up, some of the new tables I create can also be in the request list of /catalog.


p2p-master cleanup

All commits compile
Simplified a lot of commits and squashed/fixup them together

This branch needs to be updated.


expanded text ad updates

Docs Build status updates of commit 531104e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/scripts/reference/ExpandedTextAd.md
:white_check_mark:Succeeded

Advertising/scripts/reference/ExpandedTextAdBuilder.md
:white_check_mark:Succeeded

Advertising/scripts/reference/ResponsiveSearchAd.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Sample of Set-ApplicationInsightsMonitoringConfig

Please double check the sample of Set-ApplicationInsightsMonitoringConfig since it just same as Enable-ApplicationInsightsMonitoring

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 055bda34-28d6-c32b-78ff-82e91353735f
Version Independent ID: e348c31a-06fb-512f-4e99-815b44d83eb6
Content: Azure Application Insights .Net Agent API reference - Azure Monitor
Content Source: articles/azure-monitor/app/status-monitor-v2-api-reference.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @TimothyMothra
Microsoft Alias: tilee

@ronikurnia1 , Thanks for brining this to our attention. We will investigate it further and update you shortly.

@ronikurnia1 -Thanks for bringing this to our attention. I have confirmed the same with PG and the doc stands accurate.
So at this moment, since there are no doc changes, I will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Do error checking before using embedded sdk API's

Existing pre-condition in embedded sdk requires caller to verify all parameters. Middleware needs to handle all the places where embedded sdk api's are used.

https://github.com/Azure/azure-iot-middleware-freertos/pull/169


Add database password used by Deloitte's HackerIQ Game

Found by @deletescape: https://twitter.com/antiproprietary/status/1324006900401426434/photo/3
Also, Ean said to say they sent me from BSides :)

Force pushed to put the password in alphabetic order


Data Privacy

[ ] Ameya to add

[ ] Masking PII and logging unmask requests - as planned
[ ] Data Flow Diagrams for all modules on DIGIT (similar to iFIX)
[ ] Recommended privacy policy has been drafted; to discuss how it will be used / operationalised?


Enable newly added M1 GHA CI

GitHub just released support for M1 runners for open source projects via GHA. It can be selected by using macos-14 OS to run on.
This is very valuable because until now, Luau wasn't tested in OSS CI on Arm64, despite the presence of a fairly large volume of AArch64 specific code courtesy of A64 codegen. This change fixes that.
In the future we could also expand codecov reporting as it seems to work well but it needs a little bit of cleanup for the build in question so let's start small.

You can check that the runner is selected correctly by inspecting the build logs:

From the absence of the "codegen tests disabled" warnings I also infer that codegen tests compile and execute correctly although this is a little harder to prove without breaking codegen on purpose :)

The macOS ARM build is noticeably faster than macOS x64 build, so this should not meaningfully increase CI times. The M1 agents advertise 3 vCPUs so we could also try -j3 later/separately (I'm not sure whether j3 would increase Linux build time or not since Linux runners are dual core I believe, and if it does then this would need to be conditional on runner).

Thank you.


Fixes for VEP

Hi Brad,
This PR goes with #1766 and should fix most of the issues.
I haven't put any work towards the --fields argument, seeing as I'd like to remove it completely and I don't really know your position on this.
I'll run some tests locally to make sure everything works like it should.
M

Hi @chapmanb,
I think this should be it as far as fixing VEP goes.
The only remaining issues here are

GeneSplicer still isn't included, although I hope this will be fixed be removing the trailing slashes
The use of the --fields  argument hasn't been dropped, even though I think it should.

I also noticed the dbNSFP annotations don't seem to work anymore. The header and CSQ tag have all the info, but no variants were annotated (tested on a giab sample).

Matthias -- thanks for all these improvements, happy to get these in. Have you been able to test the changes to the GeneSplicer directory to see if they work? Likewise, any insight into the dbNSFP annotation failure? It seems worth resolving these before making any other adjustments to the module. We typically use a SnpEff/GEMINI based annotation framework so I don't have a ton of experience here, so leaning on what is working in your workflows. Thanks again for testing and helping on this.

Hi Brad,
Unfortunatly, I haven't been able to test the modifications to Genesplicer (unless you can tell me where I can find the genome_resource config files post installation?) As for dbNSFP, this has always quite the annoying plugins, since it seems to be a bit hit and miss at times. I'll try rebuilding the dbNSFP file first and test it again.
Alternatively, perhaps we can collaborate with @brentp so vcfanno can handle the dbNSFP file, or even better, dbNSFP without the preprocessing.
M

Hi Brad,
your comment in my other PR gave me an idea. How about we put the extra plugins for vep under tools_on?
something like:
tools_on:
  - vcf2db_expand
  - vep_extras: [genesplicer, maxentscan]

although I'm not really sure tools_on supports nested options. What do you think? It fits the model of "tweaking defaults".
Thanks
M

Matthias -- thanks for the continued work on this. Are there cases where you only want specifically one of genesplicer or maxentscan? If we could get away with a single tools_on: vep_splicesite_annotations that would help reduce the number of parameters. Sorry for the pushback but trying to fight back too many configuration parameters is one of the hardest things to do. Thanks again.

Hi Brad,
No problem, I'll merge the two options! If you find the time, could you have a look at the genesplicer issue? I've tried identifying the problem, but to avail. the resource doesn't get included into the config dict.
thanks!
M

New PR with clean history #1784


Problem with preview: TypeError: ufunc 'invert' not supported for the input types

$ python3 ./print.py -b none -s ~/cat.png
Traceback (most recent call last):
  File "/home/user/build/catprinter/./print.py", line 83, in <module>
    main()
  File "/home/user/build/catprinter/./print.py", line 69, in main
    show_preview(bin_img)
  File "/home/user/build/catprinter/catprinter/img.py", line 143, in show_preview
    preview_img = ~bin_img.astype(float)
TypeError: ufunc 'invert' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

Seems like the refactoring in #51 broke the preview. @akx could you please take a look?

Actually I think that fixes it. Please let me know if it works for you @lachesis.

Sorry, I've been away on holiday for a bit :) Should've realized the precedence works like that, glad you got it fixed.


Swap languages on translate plugin

Added a button on view of the translate plugin to swap languages quickly

Thanks, @LaercioSantana, looks cool!


Modifed to work with input document

I needed this for my copy views workflow, so I modified it. If you would
rather not have this in your package, I am glad to host in mine, (with
credit of course).

That's a great idea @sixtysecondrevit . I've been meaning to review all revit nodes that need a document and do something similar to what Clockwork has done, where the document is extracted from each element in the iteration. However I wanted to see if that has a noticeable effect on the graph's performance first.

Sounds good! There is also probably some way to make the node realize there
is no input, so it uses the current doc.
On Mon, Jan 30, 2017 at 12:10 AM, Dimitar Venkov<EMAIL_ADDRESS>wrote:

That's a great idea @sixtysecondrevit
https://github.com/sixtysecondrevit . I've been meaning to review all
revit nodes that need a document and do something similar to what Clockwork
has done, where the document is extracted from each element in the
iteration. However I wanted to see if that has a noticeable effect on the
graph's performance first.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dimven/SpringNodes/pull/26#issuecomment-275993209,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APA-1NYz8m_5ZLdvG0_8Yf-kcNxdoO75ks5rXYzRgaJpZM4Luxvw
.


feat: faster span and trace id generation

Fixes #1334
/cc @anuraaga
Benchmarks
Noticeable performance improvements in the BasicTracerProvider benchmarks with small numbers of attributes.
Browser benchmarks: https://jsperf.com/opentelemetry-random-id-generation/1
New ID Generation
Beginning NoopTracerProvider Benchmark...
  5 tests completed.

  #startSpan                     x 902,557,527 ops/sec ±3.32% (20 runs sampled)
  #startSpan:parent              x 896,869,970 ops/sec ±3.00% (20 runs sampled)
  #startSpan with attribute      x 916,297,055 ops/sec ±3.43% (20 runs sampled)
  #startSpan with 30 attributes  x  11,340,599 ops/sec ±1.92% (20 runs sampled)
  #startSpan with 100 attributes x   3,670,278 ops/sec ±1.17% (20 runs sampled)

Beginning BasicTracerProvider Benchmark...
  5 tests completed.

  #startSpan                     x 340,802 ops/sec ±2.05% (20 runs sampled)
  #startSpan:parent              x 187,078 ops/sec ±1.77% (20 runs sampled)
  #startSpan with attribute      x 324,449 ops/sec ±2.44% (20 runs sampled)
  #startSpan with 30 attributes  x  76,231 ops/sec ±1.39% (20 runs sampled)
  #startSpan with 100 attributes x   5,920 ops/sec ±1.83% (20 runs sampled)

Beginning BasicTracerProvider with SimpleSpanProcessor Benchmark...
  5 tests completed.

  #startSpan                     x 247,847 ops/sec ±8.28% (20 runs sampled)
  #startSpan:parent              x 133,570 ops/sec ±1.88% (20 runs sampled)
  #startSpan with attribute      x 182,922 ops/sec ±17.35% (20 runs sampled)
  #startSpan with 30 attributes  x  52,325 ops/sec ±0.30% (20 runs sampled)
  #startSpan with 100 attributes x   5,396 ops/sec ±5.11% (20 runs sampled)

Beginning BasicTracerProvider with BatchSpanProcessor Benchmark...
  5 tests completed.

  #startSpan                     x 224,913 ops/sec ±1.11% (20 runs sampled)
  #startSpan:parent              x 117,169 ops/sec ±1.17% (20 runs sampled)
  #startSpan with attribute      x 183,762 ops/sec ±16.86% (20 runs sampled)
  #startSpan with 30 attributes  x  21,828 ops/sec ±20.00% (20 runs sampled)
  #startSpan with 100 attributes x   5,087 ops/sec ±2.23% (20 runs sampled)

Old ID Generation
Beginning NoopTracerProvider Benchmark...
  5 tests completed.

  #startSpan                     x 876,884,335 ops/sec ±3.21% (20 runs sampled)
  #startSpan:parent              x 883,984,177 ops/sec ±3.07% (20 runs sampled)
  #startSpan with attribute      x 900,037,749 ops/sec ±4.01% (20 runs sampled)
  #startSpan with 30 attributes  x  11,137,143 ops/sec ±1.61% (20 runs sampled)
  #startSpan with 100 attributes x   3,661,880 ops/sec ±1.34% (20 runs sampled)

Beginning BasicTracerProvider Benchmark...
  5 tests completed.

  #startSpan                     x 140,603 ops/sec ±3.06% (20 runs sampled)
  #startSpan:parent              x  88,120 ops/sec ±1.48% (20 runs sampled)
  #startSpan with attribute      x 140,540 ops/sec ±2.78% (20 runs sampled)
  #startSpan with 30 attributes  x  55,164 ops/sec ±2.19% (20 runs sampled)
  #startSpan with 100 attributes x   5,852 ops/sec ±1.26% (20 runs sampled)

Beginning BasicTracerProvider with SimpleSpanProcessor Benchmark...
  5 tests completed.

  #startSpan                     x 127,693 ops/sec ±2.09% (20 runs sampled)
  #startSpan:parent              x  75,054 ops/sec ±5.69% (20 runs sampled)
  #startSpan with attribute      x 126,848 ops/sec ±1.59% (20 runs sampled)
  #startSpan with 30 attributes  x  42,302 ops/sec ±7.81% (20 runs sampled)
  #startSpan with 100 attributes x   4,387 ops/sec ±20.72% (20 runs sampled)

Beginning BasicTracerProvider with BatchSpanProcessor Benchmark...
  5 tests completed.

  #startSpan                     x 122,387 ops/sec ±1.67% (20 runs sampled)
  #startSpan:parent              x  69,848 ops/sec ±3.11% (20 runs sampled)
  #startSpan with attribute      x 112,986 ops/sec ±1.78% (20 runs sampled)
  #startSpan with 30 attributes  x  40,048 ops/sec ±1.52% (20 runs sampled)
  #startSpan with 100 attributes x   5,384 ops/sec ±1.47% (20 runs sampled)

I'm not really sure if we should sacrifice the built in crypto with native support for random bytes towards the pseudo Math.random, I would rather expect the opposite.

Why would you expect the opposite? There is nothing in the spec which requires the generated ids to be cryptographically random (nor does it even require them to be random). I could see the code simplicity angle, where using built-ins results in simpler code, but I don't think the code here is particularly complex, and on the browser in particular the new code is significantly simpler and more direct.

With regards to benchmarks I would like to see the same benchmarks to be run on some benchmarking pages that compares many different browsers and then compare how much you can gain. But if the gain is couple % we have to think if it is really worth to drop crypto in favour of Math.random

The benchmarks collected here are on node, and you can see additional benchmarks in the linked issue, also collected with node. I would like to see tests across many browsers, but I think it is a fairly well-accepted fact that generating cryptographically secure random numbers is more expensive than random numbers without cryptographic guarantees. One additional thing to note aside from the performance improvement, is that this is also impervious to entropy depletion. If the system does not have enough entropy to generate cryptographically random numbers, it can pause.

the collision chance are really small and we aren't doing anything security sensitive with those ids so the performance gain is worth for me

This is not any more or less likely to collide. The only "loss" is that it may be now possible, but still likely very hard, to guess what the next generated ID will be.

/cc @Flarna since you helped me with the current id generation

@obecny I added chrome jsperf benchmark which does indeed show a 2x speedup, but I can remove the browser changes if you'd like.

@obecny I added chrome jsperf benchmark to the PR description which does indeed show a 2x speedup, but I can remove the browser changes if you'd like.

why would you remove the browser if the speed is 2x faster ?

@obecny I added chrome jsperf benchmark to the PR description which does indeed show a 2x speedup, but I can remove the browser changes if you'd like.

why would you remove the browser if the speed is 2x faster ?

Because I can only test on my platform (macos), and you asked for IE/edge. Speedup is consistent in chrome, safari, and firefox though.

webkit browser are 2 faster, cannot check IE, now but even though it is much better

Just had a coworker test on his windows machine. The old code does not even work on IE as the ArrayBuffer does not support slice. New code works fine.

I added version 2 with msCrypto but it needs some polyfills I guess

Thanks @dyladan!

On my machine there appears to be no measurable difference between not checking, setting the last bit to 1, or looping until a non-zero byte is found.
const Benchmark = require('benchmark');
const benchmarks = require('beautify-benchmark');
const suite = new Benchmark.Suite();

const SHARED_BUFFER = Buffer.allocUnsafe(16);

suite
  .add('without check', function () {
    for (let i = 0; i < 4; i++) {
      SHARED_BUFFER.writeUInt32BE((Math.random() * 2**32), i * 4)
    }
    SHARED_BUFFER.toString('hex', 0, 16);
  })
  .add('last bit always 1', function () {
    for (let i = 0; i < 4; i++) {
      SHARED_BUFFER.writeUInt32BE((Math.random() * 2**32), i * 4)
    }
    SHARED_BUFFER[15] = SHARED_BUFFER[15] | 1;
    SHARED_BUFFER.toString('hex', 0, 16);
  })
  .add('loop check', function () {
    for (let i = 0; i < 4; i++) {
      SHARED_BUFFER.writeUInt32BE((Math.random() * 2**32), i * 4)
    }

    for (let i = 0; i < 16; i++) {
      if (SHARED_BUFFER[i] > 0) {
        break;
      } else if (i === 15) {
        SHARED_BUFFER[15] = 1;
      }
    }

    SHARED_BUFFER.toString('hex', 0, 16);
  })
  // add listeners
  .on('cycle', function (event) {
    benchmarks.add(event.target);
  })
  .on('complete', function () {
    benchmarks.log();
    console.log('Fastest is ' + this.filter('fastest').map('name'));
  })
  .run();

  3 tests completed.

  without check     x 4,816,246 ops/sec ±0.89% (93 runs sampled)
  last bit always 1 x 4,790,933 ops/sec ±0.89% (94 runs sampled)
  loop check        x 4,776,446 ops/sec ±0.77% (95 runs sampled)

Fastest is without check,last bit always 1

@open-telemetry/javascript-approvers this is done being updated I think, and I would appreciate reviews so we can get this merged.

Any chance to get this merged?

@open-telemetry/javascript-approvers would really appreciate some ✅ here :)


efk_stack check: clean up per suggestions

check: run only on first master
fix Elastic Search => Elasticsearch
clean up init and es_curl

@juanvallejo some followup fixes

Thanks


Very small grammar issue

There are two 'that's in a row in the first paragraph.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f7a02dd4-7f59-96d5-2586-3331c43ead5f
Version Independent ID: 02324641-66cb-34e1-afc7-915e368b50f1
Content: Microsoft 365 for enterprise for the Contoso Corporation - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/contoso-case-study.md
Service: o365-solutions
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@avEggHead  Thank you very much for the contribution and updating the documentation with PR. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@avEggHead  Thank you very much for the contribution and updating the documentation with PR. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Document how to run this image on GKE

We should document it like this:
https://github.com/GoogleCloudPlatform/python-runtime#container-engine--other-docker-hosts

Readmes updated.


Folder organization

Description of the new feature / enhancement
I use this app Hazel on Mac OS that makes it so that whatever comes into my downloads folder (or any other folder of my choosing) gets moved according to its file type. I am requesting something similar
Scenario when this would be used?
I use this to organize a lot of my folders. For my Downloads folder ill send some files to sub-folders (Archives, Movies etc) and some stuff I send directly to the documents folder (Word files etc). I then have rules to sort the documents folder similarly. Keeps everything tidy!
Supporting information
No response

Closed in favour of #29793

/dup https://github.com/microsoft/PowerToys/issues/29793


NestedScrollView's SliverAppBar doesn't float when body scrolled by ScrollBar

Steps to Reproduce

Execute flutter run on the code sample
Scroll via ScrollBar

Expected results:
SliverAppBar starts floating just like it was dragged by touch or by mouse scroll wheel
Actual results:
SliverAppBar doesn't float

Code sample
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyScrollBehavior extends MaterialScrollBehavior {
  const MyScrollBehavior();

  @override
  Widget buildScrollbar(BuildContext context, Widget child, ScrollableDetails details) {
    // regardless of platform, always use a scrollbar
    return Scrollbar(
      controller: details.controller,
      child: child,
    );
  }

  @override
  Set<PointerDeviceKind> get dragDevices => const {...PointerDeviceKind.values};
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: MyHome(),
      scrollBehavior: MyScrollBehavior(),
    );
  }
}

class MyHome extends StatelessWidget {
  const MyHome({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: NestedScrollView(
        floatHeaderSlivers: true,
        headerSliverBuilder: (context, innerBoxIsScrolled) {
          return <Widget>[
            SliverOverlapAbsorber(
              handle: NestedScrollView.sliverOverlapAbsorberHandleFor(context),
              sliver: SliverAppBar(
                title: const Text('SliverAppBar'),
                pinned: true,
                floating: true,
                expandedHeight: 150,
                forceElevated: innerBoxIsScrolled,
                bottom: const PreferredSize(
                  preferredSize: Size.fromHeight(50),
                  child: Text('123'),
                ),
              ),
            ),
          ];
        },
        body: const MyScrollable(),
      ),
    );
  }
}

class MyScrollable extends StatelessWidget {
  const MyScrollable({super.key});

  @override
  Widget build(BuildContext context) {
    return CustomScrollView(
      slivers: <Widget>[
        SliverOverlapInjector(
          handle: NestedScrollView.sliverOverlapAbsorberHandleFor(context),
        ),
        SliverFixedExtentList(
          itemExtent: 48,
          delegate: SliverChildBuilderDelegate(
            childCount: 100,
            (context, index) {
              return ListTile(
                title: Text('Item $index'),
              );
            },
          ),
        ),
      ],
    );
  }
}

flutter doctor -v
[√] Flutter (Channel stable, 3.3.8, on Microsoft Windows [Version 10.0.19044.2251], locale hu-HU)
    • Flutter version 3.3.8 on channel stable at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 52b3dc25f6 (6 days ago), 2022-11-09 12:09:26 +0800
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at C:\Users\maRci002\AppData\Local\Android\sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.3.4)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.3.32901.215
    • Windows 10 SDK version 10.0.20348.0

[√] Android Studio (version 2021.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[√] VS Code (version 1.73.1)
    • VS Code at C:\Users\maRci002\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.44.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19044.2251]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 107.0.5304.107
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 107.0.1418.35

[√] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Attached video:

drag :white_check_mark:
mouse whell :white_check_mark:
ScrollBar :x:

https://user-images.githubusercontent.com/8436039/201914260-6b0e5356-779e-45ad-9d1b-5bd6d8bca3da.mp4

The issue is reproducible using the code sample provided above.

recording
https://user-images.githubusercontent.com/88313112/202119321-4cb288eb-f93b-4d2b-8ec2-1c14074dbba4.mov

flutter doctor -v
[✓] Flutter (Channel stable, 3.3.8, on macOS 13.0.1 22A400 darwin-arm, locale en-GB)
    • Flutter version 3.3.8 on channel stable at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 52b3dc25f6 (7 days ago), 2022-11-09 12:09:26 +0800
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9014738/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.0.1 22A400 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 107.0.5304.110

[!] HTTP Host Availability
    ✗ HTTP host "https://cocoapods.org/" is not reachable. Reason: An error occurred while checking the HTTP host: Connection reset by peer

! Doctor found issues in 3 categories.

[!] Flutter (Channel master, 3.6.0-3.0.pre.53, on macOS 13.0.1 22A400 darwin-arm64, locale en-GB)
    • Flutter version 3.6.0-3.0.pre.53 on channel master at /Users/nexus/dev/sdks/flutters
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 58728c6a92 (2 hours ago), 2022-11-16 00:50:28 -0500
    • Engine revision 21a572e4e4
    • Dart version 2.19.0 (build 2.19.0-404.0.dev)
    • DevTools version 2.19.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9014738/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.0.1 22A400 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 3 categories.


docs: add docs about how to change the build directory

It's often helpful to change the build directory from dist/ to another location.
For example, if you are integrating angular within an existing web application an easy
deployment method is to just change the dist/ folder to a build directory within the
parent application.

Closed as this PR was made obsolete by https://github.com/angular/angular-cli/pull/1455.

Actually, I misread your commit. Latest master commits made this obsolete, but I think there's value in documenting the new functionality. Can you update your PR?

Sure.. I'm about to go on vacation.  When I get back, I will take a look at the new functionality and update the PR.

We're doing a big docs sweep soon that will cover this as well in #2711, so closing it for now.


Add zod and yup support for creating default props

As much as I loathe zod, this needs to be done.
This is a placeholder issue for a task for jsx-email v1.6.0

Just in case throwing in here that I like (& use) valibot a lot.
Not sure how the current TemplateStruct works under the hood but probably a good idea to make it general so you can use whatever

How would I currently use valibot, isn't it running superstructs create behind the scenes or did I get your comment wrong?
1 option could be keeping the current behavior but if TemplateStruct (maybe with a different name) is set to a function just run that with some context data so within that function people can do what they want, but would be more boilerplate and also type inference will be harder, maybe via a generic.
I'm on my phone right now 😅

Have been playing with this idea a lot and the one thing that I've been struggling with is where the value is added - there's no real advantage to having builtin support for any validator libraries. There's no real time savings for the user, and there's no real complexity savings either. If anything, it potentially makes the templates more complex.
At the moment, we're going to remove the builtin superstruct support for the next major version, and table the idea for the meantime.


[Feature request] Minimize to Tray

Option to select "start with windows" and "minimize to tray on close"

The Best SPV Wallet is just hours away!
Waiting????


Make CopySheet evailable for cloud development

Hi,
is it possible to make the function CoipySheet in Excel Buffer evailable for cloud development?
    [Scope('OnPrem')]     procedure CopySheet(SheetName: Text; ClonedSheetName: Text; ReferenceSheetName: Text; PasteBefore: Boolean)     begin         XlWrkBkWriter.CopySheet(SheetName, ClonedSheetName, ReferenceSheetName, PasteBefore);     end;
We have some development in connection with Jet Reports where it is necessary to copy the sheet.
King regards
Michael

This is something to ask ij this repo:
https://github.com/microsoft/BCApps
The system app is open source and thus you can even work on it.
Closing as this repo is only for the AL language compiler and tooling


ARTEMIS-2669 Improve AMQPStandardMessage::reencode on depaging not durable messages

I've opened this for duscussion: @clebertsuconic and @tabish121 mates you're invited at the party :)

The test is failing on purpose: it is showing something that I suppose is a weak point of the current behaviour ;)

@franz1981 this is ready to merge now, right?

@clebertsuconic Yep :)
Now AMQP depage should be more correct and delivering a very nice performance & stability boost


Injected XML Comments are not Idempotent

While the organizing and sorting works correctly when ran multiple times, the XML comment injections keep stacking up. 😬
<?xml version="1.0" encoding="utf-8"?>
<Project>
  <!-- Compiled C# Files -->
  <!-- Published Files -->
  <!-- Compiled C# Files -->
  <!-- Published Files -->
  <!-- Compiled C# Files -->
  <!-- Published Files -->
  <!-- Compiled C# Files -->
  <!-- Published Files -->
  <!-- Compiled C# Files -->
  <ItemGroup Label=".cs files">
    <Compile Include="Bundling.cs" />
    <Compile Include="DashboardController.cs" />
    <Compile Include="HomeController.cs" />
  </ItemGroup>
  <!-- Published Files -->
  <ItemGroup Label=".cshtml files">
    <Content Include="Views/Dashboard/Index.cshtml" />
    <Content Include="Views/Home.cshtml" />
    <Content Include="Views/Index.cshtml" />
  </ItemGroup>
  <ItemGroup Label=".js files">
    <Content Include="croppie.js" />
    <Content Include="jquery.js" />
    <Content Include="jquery.validator.js" />
  </ItemGroup>
</Project>

Resolved in Release v1.0.3


ci: overwrite storage

:notebook: Overview
Creates a rogue staking implementation which overwrites rogue values to storage and tests that inflation contract returns expected errors.
:warning: Dependencies (optional)
Depends on #71

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

22 of 22 (100.0%)  changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.5%) to 51.286%

Files with Coverage Reduction
New Missed Lines
%

contracts/staking/StakingProxy.sol
1
58.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
524

Relevant Lines:
961

💛  - Coveralls


⚠ Samsung has degraded performance

In 4b1d2de, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2384 ms

Resolved: Samsung performance has improved in cc15b37.


ci_test

Why is this PR needed?
CI test
What changes were proposed in this PR?
Nothing
Does this PR introduce any user interface change?

No

Is any new testcase added?

No

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3315/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5096/

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5078/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5098/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3317/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5100/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3319/

retest this please

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3326/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5107/

retest this please

this is test for backup CI

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5089/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3328/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbonPRBuilder2.3/5107/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbon_PR_Builder_2.4.5/3345/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbon_PR_Builder_2.4.5/3348/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbonPRBuilder2.3/5110/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3296/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5059/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5059/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3301/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3301/

retest this please

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbonPRBuilder2.3/5345/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbonPRBuilder2.3/5345/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbon_PR_Builder_2.4.5/3584/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbon_PR_Builder_2.4.5/3584/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3318/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5076/

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5078/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3321/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbon_PR_Builder_2.4.5/3695/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbonPRBuilder2.3/5456/

retest this please

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbon_PR_Builder_2.4.5/3696/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3323/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbonPRBuilder2.3/5459/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5085/

retest this please

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbon_PR_Builder_2.4.5/3733/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbonPRBuilder2.3/5498/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3344/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5104/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5064/

retest this please

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3312/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5068/

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5110/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3359/

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5118/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3367/

retest this please

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3369/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5120/

retest this please

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3377/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5128/

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5139/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3388/


Question on Docking Multi-Ligands and DiffDock Dataset Splits

Hi Plinder Team,
Thanks once again for the great effort.
A few questions have come up as I've been looking into the data more:

Handling Multiple Ligands: For the test set, how should we approach rigid docking when multiple ligands are present? I've observed that in cases with multiple ligands, some have the ligand_is_ion flag set to True, and others have ligand_is_cofactor as True. Should we treat cofactors and ions as rigid and flexible-dock the remaining ligands simultaneously. Is it correct to assume that if a ligand is neither a cofactor nor an ion, in the test scenario, would it be treated flexibly as the ligand of interest for docking?

Clarification on DiffDock Split: I'm trying to understand the exact split used for the DiffDock evaluation. The repository mentions that "a non-redundant and single-ligand smaller subset of this version was used to train DiffDock in the paper and is available at 2024-04/v0." However, my analysis shows that only about 80% of the test set has system_pass_validation_criteria=True, which seems to differ from what was reported in the paper, e.g. in Algorithm 1 and Table 2. Could you clarify which exact split was used for the DiffDock evaluation, and whether it has changed since publication?
For reference, here's the analysis notebook: https://colab.research.google.com/drive/1AC0QlrlNRFoJjgTfZJXVWT1UKUROEwAN

suitable_for_ml_training tag: I noticed that the suitable_for_ml_training tag is included in the metadata but doesn't seem to be used. Are there any plans to filter datasets by this tag in the future?

Thanks for taking the time!

@danielzeng-gt , thanks a lot for your interest!
Please, find the comments below. If this answers your questions, please feel free to close the issue.

Handling Multiple Ligands:

We would like to enable the developers to come up with their own strategy when it comes to solving the problem of multiple ligand pose prediction rather than prescribe a particular flow or task. One could either consider predicting ligand pose one at a time or simultaneously.
Thus, if the trained algorithm does not have a feature to predict more than one ligand at once - one could predict poses sequentially or in parallel. Alternatively, one could choose to limit the training and predictions only to single ligand system applications, using the annotations table to filter the appropriate systems. We plan to provide an example for such queries soon in our example notebooks.
In terms of PLINDER system definition - we only consider as system holo, if it has at least one "proper" ligand (i.e. ligand that is not ligand_is_ion or ligand_as_artifact), otherwise the system is classified as apo. Thus, when dealing with multiple ligands, one could choose to not consider such ligand entries as part of prediction.
Keeping the ions or cofactors fixed - is also an option - but this would limit the general applicability of the tool due to the requirement of having these components specified in the receptor (ideally apo, for the realistic inference).
However, it may be considered useful for different tasks, eg. ligand optimization scenarios, where a similar ligand (eg. matched molecular series) binding structure is known.
It is important to note though that for multi-ligand system prediction - if the final structure of all ligands are part of evaluation - using fixed ligands would not provide an accurate assessment of the method performance.

Clarification on DiffDock Split:

We have used slightly different criteria (as specified in the paper) than the system_pass_validation_criteria=True when performing PLINDER splits, which explain the observed differences for the pl50 split.
We would like to highlight that we have now introduced (2024-06/v2) split that further refined the quality curation, notably now including filtering for ligand crystal contacts. We found that in our earlier version as many as around 17 percent of the systems in test had at least one ligand atom in crystal contact (within 5 A heavy atom distance with a lattice neighbour).
We strongly encourage to use (2024-06/v2) for further method development. We plan to use this split for the MLSB benchmark to compare different method performance.

suitable_for_ml_training tag:

Thanks for noting this. We have included this tag at the early iteration, and since then we have improved significantly the way our systems are being processed and saved. This tag will be retired in the future iterations to avoid confusion, as our intention is to make the entire dataset to be considered "suitable", albeit varied quality.

Thank you for the detailed response and for addressing my questions!
I have 2 followups:
Regarding #1: For the MLSB benchmark, will the performance be assessed on single-ligand predictions, multi-ligand system predictions, or both? If both tracks are included, will models trained on multi-ligand systems be eligible for the single-ligand prediction track as well?
Regarding #2: Based on this, is the Plinder team planning to retrain and evaluate Diffdock on the 2024-06/v2 dataset for comparison? If so, will it be on a subset of the 2024-06/v2 splits focusing solely on single-ligand systems?


ci: add simple release step on tagged branch

Uses the github.ref_name as the tag to push a tagged image into GHCR, e.g. v0.0.1.

The short ref name of the branch or tag that triggered the workflow run. This value matches the branch or tag name shown on GitHub.

I'm changing this, as I was looking at the completely wrong thing, incoming commits :rocket:

I hate CI release pipelines because they are so hard to test in a PR!

Tell me about it 😆


ARM Deployment Task - Error when spaces in template path for bicep files

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: ARM template deployment
list here (V# not needed):
https://github.com/microsoft/azure-pipelines-tasks/tree/master/Tasks/AzureResourceManagerTemplateDeploymentV3
Environment

Server - Azure Pipelines or TFS on-premises?

If using TFS on-premises, provide the version:

If using Azure Pipelines, provide the account name, team project name, build definition name/build number<EMAIL_ADDRESS>Deal Data Mart Team, Automation Account Build

Agent - Hosted or Private:

If using Hosted agent, provide agent queue name: Azure Pipelines, windows-latest

If using private agent, provide the OS of the machine running the agent and the agent version:

Issue Description
ARM Template deployment fails for bicep files when the path includes spaces. The same task succeeds for an ARM template json file. I've tried enclosing the Template file path argument in single quotes, double quotes, and using a variable for it. I am currently using an Azure PowerShell task instead as a workaround using New-AzResourceGroupDeployment.
Task logs
ReleaseLogs_170.zip
Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
tasklog_6.log

I just came across this issue as well. What's a timeframe for fixing this?

My workaround for the time being was to change the source artifact name in my release pipeline, as this is where the spaces where occurring, because of the git repo name.

Also seeing this issue (finally getting around to playing with Bicep).
Error: Command failed: az bicep build --file <path to file>
Seems Az CLI isn't passed the file path wrapped in quotes.

I've just continued to use the Azure PowerShell task and the New-AzResourceGroupDeployment cmdlet rather than the rather than the ARM Template Deploymne task.

+1, please. Everything was working fine when I used a JSON ARM Template. Decided to try Bicep today and everything blew up.

@DaleyKD if you're just getting into ARM conversion, I'd suggest you look at Pulumi or the Terraform CDK. It will take some effort to learn but blows bicep out of the water.

This tasks is still relevant it even has a PR… #19382

Yeah , its an issue I hope MS team will fix by merging my PR .

Yeah , its an issue I hope MS team will fix by merging my PR .

Looks like your PR has a merge conflict.  Any chance you can fix it so it can get pushed?  Would like this to get fixed so I can use the task instead of powershell gimmicks

Updated PR existing here with test cases implemented https://github.com/microsoft/azure-pipelines-tasks/pull/20048


proposal: html/template: add ability to modify FuncMap after template parse

Background
I have a bunch of templates that have a complex dependency structure like:
 A -> B, D, E
 B ->  E, F
 C -> E, G
 D -> F, H
 E -> H
 F -> nil
 G -> nil
 H -> nil

The contents of the corresponding files ('A.tmpl', 'B.tmpl', etc.) are static; however, the template.FuncMap that they reference contain implicit reference to captured state that varies by caller. That is, the FuncMap is created like so:
func createFuncMap(request *rpc.Request) {
   result := template.FuncMap {
     "Foo": createFooFunc(request),
     "Bar": createBarFunc(request),
      ...
   }
  return request
}

What I Want to Do
I'd like to be able to preparse all of the various files irrespective of the func map (or perhaps with a whitelist of functions that will be defined), and I'd like to parse the individual pieces separately (e.g. parse 'F' only once, even though it is a dependency of 'B' and 'D'), and then somehow combine the parsed templates together like:
   func getTemplate(name string) *template.Template {
     result := template.New(name).Funcs(getStubFunctionMap())
     for _, dep := range getDeps(name) {
        result.AddDep(getTemplate(dep))
      }
      result.Parse(getFileContent(name))
      return result
    }

I'd also like to trivially rebind the function map as in:
   func getBoundTemplate(name string, request *rpc.Request) *template.Template {
     cachedTemplate := getOrCreateCachedTemplate(name)
     boundTemplate := cachedTemplate.Clone().Funcs(funcMapFor(request))
     return boundTemplate
   }

Why I Can't Do It
The documentation of html/template makes it appear that parsing is context dependent and that parsing is linear (dependencies can be added linearly, but cannot be combined from multiple, already-parsed templates). This is a pretty major limitation of the interface.
Impact of This Limitation
This is a major efficiency problem; I want to parse a complex network of templates upfront before receiving requests and do very minimal work on each request. This structure is causing much more work to happen in the context of every request.
For more specifics of this use case, reach out to me directly from your @google.com account, and I can share more details of the specific code in question.

CC @robpike

I think I need a little bit more context.
Why do you need to closure some state in the funcs of your templates? Why can't you pass an additional map of data to process?
To use your example: "Foo" func would accept an additional parameter that depends on the request being processed, but its code would stay the same.
What kind of request-scoped data are you currently capturing in your functions that can't be a parameter?

Something like proposal #31107 would let you pass data into the functions via a context.Context.  Would that be another way for you to pass the data you need into the functions?
Can you explain why you want the ability to bind together parsed templates?  What would the API in html/template look like?
It sounds like you can do what you need by passing values through the template.  You say that making the input more explicit introduces needless cognitive burden to template authors.  But Go in general does prefer to make things more explicit.

A simple self-contained concrete example might help clarify this.  The description is somewhat abstract.

I've just sent a private email from my @google.com account to Ian's @google.com account with more detail concerning the original motivation.

@michaelsafyan It would be nice if you could say something publicly. We don't make decisions based on unpublished Google-internal motivations. Well, except "no, because it's too Google-specific".

The original comment says:

The documentation of html/template makes it appear that parsing is context dependent and that parsing is linear (dependencies can be added linearly, but cannot be combined from multiple, already-parsed templates). This is a pretty major limitation of the interface.

Yes, parsing is context dependent, so it is not really possible to reuse pieces the way you want. That is fundamental to the security analysis. I don't think what you are trying to do is sound with respect to the security analysis. We won't make unsound changes here.

Curious, could you elaborate on the security concern?
On Mon, Oct 21, 2019, 17:19 Russ Cox<EMAIL_ADDRESS>wrote:

The original comment says:
The documentation of html/template makes it appear that parsing is context
dependent and that parsing is linear (dependencies can be added linearly,
but cannot be combined from multiple, already-parsed templates). This is a
pretty major limitation of the interface.
Yes, parsing is context dependent, so it is not really possible to reuse
pieces the way you want. That is fundamental to the security analysis. I
don't think what you are trying to do is sound with respect to the security
analysis. We won't make unsound changes here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/34680?email_source=notifications&email_token=AABI65NN3LCF74LIHGUVWGDQPYMEXA5CNFSM4I5HYPN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB32FZA#issuecomment-544711396,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABI65INIIIUACX4K2NHTQTQPYMEXANCNFSM4I5HYPNQ
.

The html/template docs give as a simple example {{.}}. Those two substitutions need different escaping. In general those could be call-outs to other templates. So fundamentally the analysis of the template is context-dependent.
The original proposal here sounds to me like "don't make template analysis context-dependent". That's not possible (see example).
Is there a more limited proposal you were making, and I've misunderstood?

The html/template docs give as a simple example {{.}}. Those two substitutions need different escaping. In general those could be call-outs to other templates. So fundamentally the analysis of the template is context-dependent.

I agree and am not suggesting that this change.

The original proposal here sounds to me like "don't make template analysis context-dependent".

My apologies for being unclear. No, I'm not asking that parsing cease being context-dependent. I'm asking that parsing not make a distinction regarding whether parameters come from the global scope (via the FuncMap) vs from the local scope. There is currently this inconsistency where FuncMap parameters and parameters that are passed into the template get treated differently insofar as non-FuncMap parameters can be changed while keeping the template the same, while FuncMap parameters cannot be changed after parsing.
What I'd like is for it to be possible to replace the FuncMap (the values, not the keys) on each invocation of the template, without the FuncMap being a shared resource that needs to get locked, so that different requests / instantiations of the template can use different values of the FuncMap parameters. This would make member functions (of whatever is supplied as data interface{}) and global functions (supplied through FuncMap) roughly interchangeable.

I tried to retitle this issue to indicate my current understanding of the suggestion:
"add ability to modify FuncMap after template parse".
The original message says:

I'd also like to trivially rebind the function map as in:
  func getBoundTemplate(name string, request *rpc.Request) *template.Template {
    cachedTemplate := getOrCreateCachedTemplate(name)
    boundTemplate := cachedTemplate.Clone().Funcs(funcMapFor(request))
    return boundTemplate
   }

Now I don't understand "why I can't do it". As far as I can see that code should work fine. The "why I can't do it" talks about parsing, but there's no parsing in calling Clone and Funcs.
I'm sorry, but I'm still confused.

Per the documentation of func (t *Template) Funcs(funcMap FuncMap) *Template:
https://golang.org/pkg/html/template/#Template.Funcs

Funcs adds the elements of the argument map to the template's function map. It must be called before the template is parsed. It panics if a value in the map is not a function with appropriate return type. However, it is legal to overwrite elements of the map. The return value is the template, so calls can be chained.

In other words, one cannot call Funcs a second time after calling Clone. One can modify the existing map passed into Funcs before, but one cannot pass in a completely different map (which is important for thread-safety).
I'd like this to be relaxed; one should be able to call Funcs again with a new map, as long as the new map has all of the same keys as the previous one.
(And, yes, I am basing this on more than just documentation, but also trying it; when I tried the code above, the result was an error).

Out of curiousity:
Why do you want to call Funcs a second time after calling Clone?  If you do, why not just call Clone again?
Or, could you write the functions as redirectors, so that they test whatever condition you would use to call Funcs again to decide themselves which function to call?

Or, could you write the functions as redirectors, so that they test whatever condition you would use to call Funcs again to decide themselves which function to call?

Doing this would require the introduction of locking, which is what I'm trying to avoid.
To clarify:
Startup / shared thread:
- (Re)load template text files
- (Re)parse text files into templates (using dummy FuncMap)
(In parallel): request1 thread A:
- Clone (shared) parsed template, creating thread-local copy
- Set copy to use request1's function map
(In parallel): request2 thread B:
- Clone (shared) parsed template, creating thread-local copy
- Set copy to use request2's function map
[Also thread C, D, etc. up to N request-serving threads]
The same semantics can be achieved with a function that is a "redirector", but then this requires the function to reference an actual thread local variable that it resolves on each invocation. It should be possible to simply allow each clone to reference a separate, independent map.

It should be possible to simply allow each clone to reference a separate, independent map.

This works today and we're using it heavily.
What error are you seeing?

Per the documentation of func (t *Template) Funcs(funcMap FuncMap) *Template:
https://golang.org/pkg/html/template/#Template.Funcs

Funcs adds the elements of the argument map to the template's function map. It must be called before the template is parsed. It panics if a value in the map is not a function with appropriate return type. However, it is legal to overwrite elements of the map. The return value is the template, so calls can be chained.

In other words, one cannot call Funcs a second time after calling Clone. One can modify the existing map passed into Funcs before, but one cannot pass in a completely different map (which is important for thread-safety).

I think you are misreading the documentation. There are two maps in play.
Funcs copies entries from the map argument into a private map stored in the template.
If the caller modifies Funcs's map argument after the call returns, nothing changes in the template.
If you Clone the template, the clone gets its own private map initialized to be a copy of the original template (being cloned).
If you call Funcs again, more entries are added to the private map.
Have you tried to use Funcs after Clone and had it fail? @kaey says it works for them, for example, and I believe I've done this too. Can you provide a failing test case if it doesn't work for you?
Thanks.

@michaelsafyan, any response to my comment from last week? The code you are trying to write should work already. If not it would help to provide a simple test case. Thanks!

Sorry, I've not had an opportunity to confirm that it works. But, assuming that it works, this may then simply be a request to clarify/update the documentation than an implementation change.

Will repurpose this issue for updating docs that Funcs can be called multiple times to replace earlier mappings.


Make each TextSection its own entity.

Objective
This change makes each TextSection its own entity, which was discussed to be the next step for bevy_text in Discord.
Fixes #7714
Solution

Changed the Text component to hold no sections instead of a Vec of TextSection.
Made TextSection a component that should be added to children of a Text.
Adjustments to make the code compile again.

Testing
Tested out some of the examples that I ported to the new API, they all look fine.

Migration Guide
Any usage of TextBundle::from_section or Text::from_section should be replaced with something like this:
//old
commands.spawn(TextBundle::from_section("My Text", TextSection::default()));

// new
commands.spawn(TextBundle::default()).with_child(TextSection::from("My Text"));

Same goes for the from_sections methods.

Alice 🌹: So @Preon, currently, text is handled via the Text component, which is composed of multiple TextSection parts in a vec
[10:07 AM]
OP
 Alice 🌹: Both @DreamerTalin and @cart have independently found that this is very frustrating to work with in more complex workflows: you end up with two separate hierarchies that need to be managed
[10:07 AM]Preon: yeah that makes sense
[10:08 AM]
OP
 Alice 🌹: Instead, each TextSection should be its own entity, with a consistent TextStyle
[10:09 AM]
OP
 Alice 🌹: In 90% of cases, a chunk of text will have a single text style: we should optimize for making that case easy and ergonomic

Context for why this should be done, from Discord

This work was previously mentioned in https://github.com/bevyengine/bevy/discussions/14437. As discussed above, bringing text sections into the entity hierarchy is required to make them play nicely with scenes, and thus the BSN entity-spawning tools.

I think I will wait with porting over all examples for two reasons:

The API will probably change based on suggestions.
It is quite some work, that I don't want to re-do.

Marking this as ready for review, the main thing that we still need to do is find a way to prevent repeated allocations in the systems where the text is enqueued.

There are currently warnings about the children of a UI node not having UI components themselves, how do I fix these?
2024-08-22T08:10:22.518891Z  WARN bevy_ui::layout::ui_surface: Unstyled child `10v1` in a UI entity hierarchy. You are using an entity without UI components as a child of an entity with UI components, results may be unexpected.

There are currently warnings about the children of a UI node not having UI components themselves, how do I fix these?
2024-08-22T08:10:22.518891Z  WARN bevy_ui::layout::ui_surface: Unstyled child `10v1` in a UI entity hierarchy. You are using an entity without UI components as a child of an entity with UI components, results may be unexpected.

Not tested it but changing this query in ui_layout_system:
just_children_query: Query<&Children>,
to filter for the text bundle's marker  component
just_children_query: Query<&Children, Without<Text>>,
might be sufficient.

Can you do a pass on the comments and resolve those that are addressed to make this easier to review? :)

Is this the right time to rename sections to spans?

Is this the right time to rename sections to spans?

IMO yes.

Merging #15591, which continued this work.


Day49

Resolves #107 .

Pull Request Test Coverage Report for Build 238

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 236:
0.0%

Covered Lines:
24

Relevant Lines:
24

💛  - Coveralls


关于应用 NZ 响应表单的BUG

当文本框失去焦点的时候，预期文本框 不可编辑（但是disable 顺序在上起作用，disable顺序在下不起作用）
`  <form nz-form [formGroup]="validateForm" (ngSubmit)="_submitForm()">
<input id="email" name="email" formControlName="email" (blur)="onIdCardChange(validateForm.controls)" class="form-control">
`
`    ngOnInit() {
this.validateForm = this.fb.group({ // 初始化表单模型
email            : [ '', [ Validators.email ] ]
});
}
public onIdCardChange (form: any): void { // 当页面文本框失去焦点时
// this.validateForm.get ('email').disable (); // 如果写在这，那么文本框 disable 起作用
this.validateForm = this.fb.group({
  email            : [<EMAIL_ADDRESS>[ Validators.email ] ],
});

this.validateForm.get ('email').disable (); // 如果写在这，那么文本框 disable 不起作用

}`

bug confirm, thanks.

@myepoch It seems that you are using original angular input form, it has noting todo with ng-zorro.

Hi.
I think it should be a bug.
A custom form control with 'disabled' attribute should implement the setDisabledState method of interface ControlValueAccessor ', otherwise it can not be disabled when using a reactive form such as FormControl / FormGroup.
For example:
https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/src/components/input/nz-input.component.ts
export class NzInputComponent implements AfterContentInit, ControlValueAccessor {
  // ...

  // This function is called when the control status changes to or from "DISABLED".
  setDisabledState(isDisabled: boolean): void {
    this.nzDisabled = isDisabled;
  }
}

I search the components file. I found that many components are missing this hook.

If confirmed as a bug. My pleasure to help to fix other components that implement ControlValueAccessor to be a custom form control.

@deart1mer Yes, nz-input and all other components such as nz-datepicker have not implement the setDisabledState yet, but this is not associate with this issue since @myepoch used input other than nz-input.
It is great that if you want to help us to patch all components with  setDisabledState, thanks.


PRIVATE_IP is requested

$ cbd start

Post http:///var/run/docker.sock/v1.20/containers/create: dial unix /var/run/docker.sock: permission denied.
* Are you trying to connect to a TLS-enabled daemon without TLS?
* Is your docker daemon up and running?
!! Imported variable PRIVATE_IP must be set in profile or environment.

The user what you have used does not have permission to interact with docker.sock


Boxen Fails to Install on macOS 10.13

Hello,
Getting the following error when attempting to install boxen on macOS 10.13:
Jacobs-MacBook-Pro:repo jacoblamont$ ./script/boxen
--> Preparing to auto-update...
--> Complete! Nothing new from upstream.
GitHub login: |jacoblamont| alanbreck
GitHub password: ****************
--> You must be running one of the following OS X versions: 10.8 10.9 10.10 10.11 10.12.

Will support for 10.13 be coming?

@webflo has started work on this in #215 so feel free to follow along with that. If you want to bypass this check, you skip the OS check entirely but YMMV since it's not supported yet.


Indicate language server progress

Some of language servers take a long time to initialize. Most of them report progress and/or ready event. We need to indicate their progress somehow to prevent confusion like "why does 'go to definition' not work? is it broken?" during initialization.
I need help to understand what is the best way in Kakoune to communicate such kind of information. It should be non-intrusive and discoverable at the same time. Should it be echo or info (the former could be easily missed and the latter feels too noisy)? Ideal would be to show in status line (like echo) but persistent and update according to language server status change.

I think exposing a option for the user to put in their modeline is a good solution. It could be empty when idle and contain a simple indicator when something is in progress.

Another option could be to show an infobox when the user calls 'go to definition' command so it only informs in case of action.

Thanks, both tactics should work well together: option with current status for those who wants to put it into modeline or do any other custom notification and info which explains why actions couldn't be performed right now. For the latter introducing generic error reporting mechanism could be enough (need to double check what exactly language server responds when it's not ready, because it could be not an error but just empty list of declarations/references/etc. In that case we need to track ready event in kak-lsp itself and do smart guess).

I tried to use :lsp-references with no apparent success on a JavaScript project.
It turns out that:
May 30 12:20:52.463 ERRO Error response from server: Failure { jsonrpc: Some(V2), error: Error { code: MethodNotFound, message: "Unhandled method textDocument/references", data: None }, id: Num(4) }, module: kak_lsp::controller:212

So the problem is that flow-language-server does not support textDocument/references (yet).
No big deal, the feature will come in due time.
But the lack of error feedback on kakoune side was a bit disturbing.
Here are a few suggestions on top of the great ones in this thread:

add a line with something like kak-lsp: no support for lsp-references with flow-language-server in the *debug* buffer.
add a new command like lsp-capabilities to show what stuffs the current server support.

I've added reporting server errors (including unsupported methods) back to editor, both writing them to *debug* buffer and showing in info box (7ec2e8a9dc92cf8d0ad3d740bee0a53c95e185d8). For some of language servers (like cquery) it solves problem of indicating progress because they report an error if they are not ready to give proper response. For others (like rls) it doesn't, because when they are not ready they just give wrong empty response. Progress reporting itself is highly inconsistent across language servers and sometimes have no clear signal of when language server is ready.
I created #51 for lsp-capabilities.
I'm going to close this issue because problem is mostly solved for "good citizen" type of language servers, for others it should be solved on case-by-case basis. Feel free submit either issue with description how you see progress reporting for language server you use should look like or PR implementing that behaviour. Of course, any ideas about how to improve current "generic" error reporting are welcome as well.

ref https://github.com/ul/kak-lsp/pull/196


Do not offer to push to Git if malformed push URL is present in config

There seems to be no official way to prevent pushing to a remote in Git, but people often recommend setting the push URL of a remote to something invalid. (Can't clear it fully because Git would fallback to the fetch URL).
git remote set-url --push origin no_push
It would be good if the VS Code Git SCM provider could check for git:, ssh: and https: URLs and if it finds an unsupported URL format, hide the Push part of the Sync button in the bottom bar. Pulling should continue to work.
In case white listing protocols is deemed too potentially disruptive (maybe people are using custom protocols?), a black list approach could be considered where no_push (and other values?) would cause the push icon to be hidden.

I'd go for a blacklist of only no_push. PR welcome!

@joaomoreno Sounds good, I'll try to take a stab at that.

Should the action item dropdown be hidden or disabled too?