Allow Bot Initiation without Comments

You can't initiate the bot unless you type something on the "comments section" even when comments are disabled.
I need to type "a" and then click initiate even when the comments are disable.

Hi @ap0l0 ,
Thanks for pointing out this issue. It was a known bug, and I'm sorry for any inconvenience it may have caused. The "Enable Comments" button should have been controlling the need for comments and allowing the bot to initiate even when comments are disabled.
I'm happy to let you know that this problem has been fixed in both branches. Now, you won't need to type anything in the "comments section" when comments are disabled to initiate the bot.


Initial Draft of ASPA RTR PDU support

Contribution description

Testing procedure

Issues/PRs references

I'm going to move the byte order tests to the corresponding test function, byte order tests belong to test_pdu_to_network_byte_order and test_pdu_to_host_byte_order


lib: init and use mkFlake and evalFlakeArgs

Add general lib functions to create a devos flake. These functions do not enforce a file system structure, but just provide an api to create a flake.
The options that have types do not allow paths, see this comment for my reasoning.
Module system allows for type checking and storing all data about the flake within one comprehensive evaluated module. It also allows for adding defaults, so folders and files are no longer required. You can safely delete the userSuites or just not pass modules if you aren't using those features, and devos won't error out like it does now.
Then in devos's flake.nix we now call mkFlake and pass the arguments to enforce this template's file system structure.
I mentioned this in other places, but I do not want to change any of devos's api in this PR. So for example @blaggacao has brought up that extern might be somewhat necessary and could be changed. But I'm still going to keep extern in this PR since thats how devos works right now. Then after the result of #214 and/or #152 we can update mkFlake and devos's flake.nix appropriately in separate PR's.
Thank you @blaggacao for the great ideas! Credit goes to him for the idea of making mkFlake more general. It took a bit for me to understand, but this is way better.

Moved templates and devosOptionsDoc out of mkFlake, since they are devos specific. devosOptionsDoc is added to pkgs, I think that would be the best place to add it, following the devos api thats just been defined.

Dependent PR's:

#217
#216
#219
#215

I want to filter packages by system, but I don't think we actually need the flattentree funcitonality anhow, so perhaps we could make it simpler and invert the logic, so that if a system isn't explicitly specified, instead of being filtered out as it is now, it is automatically included in all systems. This encourages packages that should be systemed to do so, or CI won't pass, while allowing new tests and the like to automatically run on any system.

Added a doc section, 'use devos as a library!' which is an updated version of the 'use-mkdevos' doc from the other PR.

What's left to do here, before review?

I just went through a few cleanups today and improved the option descriptions. This should be ready for review. I don't plan on adding anything else in the PR.

running into the double importing core issue again. I thought ${devos}/profiles/core would be the same core in allProfiles. I'm confused as to why thats not the case, since devos == self

Oh wow, it's even stranger this time, since the hashes actually match exactly as well. I'll have to experiment a bit and see if I can find a workaround/solution.

bors try

More dependent PR's:

[] #229, this should help with path issue, but its not necessary
[] #228

With those PR's, the current "black magic" will no longer be necessary. lib only needs to be initialized once and self will just be self across lib, the flake that is calling each lib function. And devos isn't necessary.
The only remaining issues is tests and shell. I think we can just expect users of mkFlake to leave those folders for now. In future, shell should prob be moved to lib and only the compat part should be in the root folder. And we could add a tests argument for mkFlake - that will require more tests rework, so not planning to include here.

mostly implemented in #231


Cannot convert to png

I try to convert an image from JPEG to a PNG. I get this in the logs:
16:16:06
[PNGQUANT] running: cat /tmp/tmpbT3FLJ | /var/task/pngquant --speed 3 --quality=80 - > /tmp/tmpORRq75

16:16:06
/bin/sh: cat: command not found

16:16:06
error: Read error (libpng failed)

16:16:06
error: cannot decode image from stdin

Are you building this yourself, or are you using the pre-built version available here:
https://aws.amazon.com/answers/web-applications/serverless-image-handler/

I'm building it myself with build-s3-dist.sh script on an aws instance on Amazon linux.
@stevemorad Do I need anything extra?
The main issue is that I want to use gifsicle for GIFs and an updated pillow some wierd PNG images I have.

@stevemorad the pillow version in the pre-build is out-dated and many of our user uploaded PNGs simply don't convert or transform. After updating pillow, that's fine but now we have another problem. It seems like pillow then tries to feed pngquant either jpeg or broken data.
Perhaps the handler is incompatible with the latest version of pillow?

I found I needed to build pngquant statically against libpng.
See this commit: https://github.com/robinbowes/serverless-image-handler/commit/96bef2725ef13bb55d8358f9d05b7f1d78bc28d3
It probably won't just drop into the existing code as I've refactored the build script pretty extensively too.

We are testing a new update to support this request. Would anyone mind testing the following template and provide feedback if this is what you are looking for?
https://s3.amazonaws.com/solutions-test-reference/serverless-image-handler/latest/serverless-image-handler.template

Fixed in v2.2


parse json on background thread

you can feel it on the show view

fixes scrolling up and down

Shipped


ARROW-2201: [Website] Publish JS API Docs

Thanks @xhochy. Any objections to me going ahead and pushing this to arrow-site?

@TheNeuralBit no, this is fine. Feel free to deploy it.


"declare module" may need quotes

Thank you for all the work put into that great project, @englercj!
I currently develop jsdoc-tsd-webpack-plugin which generates tsd-jsdoc output and better-docs output through Webpack compilation.
array-to-object-keys is an example project from me. This is the important part:
/** @module array-to-object-keys */
// Removed for simplicity
/**
 * Converts an array to an object with static keys and customizable values
 * @example
 * arrayToObjectKeys(["a", "b"])
 * // {a: null, b: null}
 * @example
 * arrayToObjectKeys(["a", "b"], "value")
 * // {a: "value", b: "value"}
 * @example
 * arrayToObjectKeys(["a", "b"], (key, index) => `value for ${key} #${index + 1}`)
 * // {a: "value for a #1", b: "value for b #2"}
 * @param {string[]} array Keys for the generated object
 * @param {valueGenerator|*} [valueGenerator=null] Optional function that sets the object values based on key and index
 * @returns {Object<string, *>} A generated object based on the array input
 */
export default (array, valueGenerator = null) => {
// Removed for simplicity
}

tsd-jsdoc generates:
/** @module array-to-object-keys
 */
declare module array-to-object-keys {
    /**
     * Converts an array to an object with static keys and customizable values
     * @example
     * arrayToObjectKeys(["a", "b"])
     * // {a: null, b: null}
     * @example
     * arrayToObjectKeys(["a", "b"], "value")
     * // {a: "value", b: "value"}
     * @example
     * arrayToObjectKeys(["a", "b"], (key, index) => `value for ${key} #${index + 1}`)
     * // {a: "value for a #1", b: "value for b #2"}
     * @param {string[]} array Keys for the generated object
     * @param {valueGenerator|*} [valueGenerator=null] Optional function that sets the object values based on key and index
     * @returns {Object<string, *>} A generated object based on the array input
     */
    function default(array: string[], valueGenerator?: valueGenerator | any): {
        [key: string]: any;
    };
}

This looks fine, but the syntax highlighting in my VSCode looked suspicious.

The module name is not parsed correctly with those dashes. Semi-official sources like this one told me that module names need to be quoted.
Okay, I can fix this as long as JSDoc doesn't mind!
- /** @module array-to-object-keys */
+ /** @module "array-to-object-keys" */

It worked, the TSD output looks legit now, but... what is this abomination?

The underscores in the file name were one of many impacts that told me that the @module annotation is the wrong place to hack in a fix for that.
So what do you recommend? Is this a case that should be included in tsd-jsoc?
Like:
moduleName = moduleName.includes("-") ? `"${moduleName}"` : moduleName

Or did I understand something wrong on my side?

I got it done! :)

I would probably be fine for us to just always quote module names.

Why did you end up quoting only invalid identifiers?
For me VS code only recognizes quoted module names (doesn't matter if valid or not).

Turns out unquoted modules are actually just namespaces, so I need to quote them all. Will fix.

Hopefully that fixes it up, got some other work I want to do and will do a release at some point.

Thanks, looking forward to a release!  😃
We can finally use this again after I found at that the reason nothing worked was our use of @mixin.

Hi @englercj, would it be possible to release a new version soon-isch?
I don't like pushing stuff but I've got a pull-request that depends on the last commit.
Thanks and have a great day 😃

I had some water damage in my office that has prevented me from accessing my machine, and it has made me forget to do this. I will try to get on it from my chromebook sometime this weekend. Sorry!


Serverless Trace Mini Agent

What does this PR do?
This PR introduces the skeleton for a modular trace mini agent, as a standalone executable binary.
Description of new directories added:

serverless/

contains the main() function, runs when the binary is executed & starts up the mini agent with serverless trace processor + serverless trace flusher

trace-mini-agent/

contains the mini agent code, including spinning up the mini agent http server + trace flusher

trace-utils/

contains trace deserialization & conversion utils, as well as agent payload construction + function to send traces to the trace intake backend.

Overall flow of logic:

serverless bin is compiled and executed by a child process spawned by the tracer
serverless trace agent main creates a serverless trace flusher and trace processor, using them to create a new mini-agent
mini_agent.start_mini_agent() is called
the trace flusher is started up, listens over a tokio (mpsc) channel for processed traces
http server is started up, listening on <IP_ADDRESS>:8126
requests to the server on the endpoint /v0.4/traces are handled by the trace processor
trace processor de-serializes traces from the request body, converts them to protobuf traces/spans. These are then sent over the channel to the trace flusher
trace flusher appends traces to a buffer vec. when the vec is over a hard-coded size flush_traces is called which creates an agent payload + serialized it into protobuf, sent to the trace intake. The buffer vec is then emptied.

Motivation
This PR sets the framework for further features required in the Serverless mini-agent MVP. The serverless mini-agent is executed by a child process spawned within the tracers, to enable trace collection for Google Cloud Functions, and Azure Functions.
Further work includes:

Make agent payload header + trace chunk data construction more programmatic
Sending a signal to the parent process when the mini-agent is ready to receive traces
Smart trace buffering/flushing (instead of the current hard-coded buffer size to flush)
Reading configuration properties from a datadog.yaml file included in the gcp function / azure function
Integration of trace obfuscation + trace normalization crates
Serverless parent span
Trace sampling
Replace debugging print statements with a logger

Additional Notes
How to test the change?

This mini agent is tested by building the serverless-trace-mini-agent binary, including it within a node google cloud function, modifying dd-trace-js with the code below to spin up the mini agent in a child process, and running the function locally.

dd-trace-js code:
// within tracer.js, the following function runs when tracer.init() is called
function startMiniAgent () {
  try {
    const { spawn } = require('child_process');
    const { join } = require('path');

    const rust_binary_path = join(process.cwd(), 'serverless_mini_agent_macos');

    const mini_agent_process = spawn(rust_binary_path);
    ...

Spans:

Hey :wave:
I'm kinda curious about the choice of a separate binary -- is that a choice for prototyping, or is that the actual intended outcome?
My question derives from a more generic "if this is a binary that is going to be very independent of the client libraries -- does this belong in libdatadog"?
Note that I'm definitely definitely (believe me! lol) not trying to push anyone out if you think this is the best place to add the code :sweat_smile: :sweat_smile: :sweat_smile:!
Maybe the plan is for some libraries to deploy the mini-agent in-process at some point? On the other hand, if we don't think that's the case, I do wonder if it would be better to separate out both projects.

Hey 👋
I'm kinda curious about the choice of a separate binary -- is that a choice for prototyping, or is that the actual intended outcome?
My question derives from a more generic "if this is a binary that is going to be very independent of the client libraries -- does this belong in libdatadog"?
Note that I'm definitely definitely (believe me! lol) not trying to push anyone out if you think this is the best place to add the code 😅 😅 😅!
Maybe the plan is for some libraries to deploy the mini-agent in-process at some point? On the other hand, if we don't think that's the case, I do wonder if it would be better to separate out both projects.

The separate binary is indeed the intended outcome, as our goal is to start the mini-agent by spawning a child process from within the tracers, and executing the compiled binary from the child process. There are no current plans to start the mini-agent in-process.
I think that since the only standalone-binary specific code present is what lives in serverless/, keeping everything here would let other future applications reuse components used by the serverless mini-agent.

Thanks for the answer @thedavl! To be honest, I'm not entirely convinced that given that the current plan is for this to be separate, that it's worth keeping around "just in case".
Since you think it is, and given that it doesn't impact the rest of libdatadog, I'll trust you on it ;)


Committess at slot: subscriptions and duties

We've recently found that in order to avoid a BeaconState read we need to thread the get_committee_count_at_slot through the validator duties and up into the subnet subscription.
The reason is that the allocation of an attestation to a subnet is fork-dependant. I.e., two attestations with the same index and slot, but different beacon_block_root can be required to be published in two different subnets (only in rare circumstances). There's a more in-depth explanation here: https://github.com/sigp/lighthouse/pull/1257#issuecomment-645085765.
I'd be interested in hearing peoples thoughts on including this get_committee_count_at_slot value in:

/validator/duties/{epoch}/attester
/validator/beacon_committee_subscriptions

The reasoning being is that it prevents the BN from needing to know the active validator count for attestation.data.beacon_block_root when processing a /validator/beacon_committee_subscriptions request.
On our end, we've called the field committee_count_at_slot but we're open to change :)

In the API revamp we have a call /v1/validator/duties/attester/{epoch} which returns:
data [
  {
    public_key: byte[]
    committee_index: uint64
    committee_length: uint64
    validator_committee_index: uint64
    slot: uint64
  }
]

Is committee_count_at_slot the same as committee_length i.e. the number of validators in the committee, or is it something else?
(And in case you're wondering, validator_committee_index is the index of the validator inside the committee; it's a horrible name but we couldn't come up with anything else that sounded better, so suggestions appreciated.)

Is committee_count_at_slot the same as committee_length?

Unfortunately not. committee_count_at_slot represents the count of committees at a slot, whilst committee_length represents the size of a committee at a slot.
For example, if you wanted rougly the number of validators that will attest in a slot you would do: committee_count_at_slot * committee_length.

we couldn't come up with anything else that sounded better

Nor can I :(
I don't like committee_count_at_slot either, but also can't think of anything better.

Gotcha.  So i can think of three ways of doing this.  My preferred way would be to add this as top-level data, i.e.:
data {
  **committee_count: uint64**
  attesters: {
    public_key: byte[]
    committee_index: uint64
    committee_length: uint64
    validator_committee_index: uint64
    slot: uint64
  }
}

Alternatively we could put the committee count in each attester object (keeps the returned info as a simple array, but repeats ourself) or just put it in another endpoint (but that then requires the user to make multiple calls and most use cases for the endpoint will require this information so we're forcing the user to do more work than necessary.  @mpetrunic are you happy with the above solution?
Also, from the info in the comment you linked it sounds like this value won't change within a single epoch as its based on active validator count, but if that may not be the case let me know and we'll make it a per-slot array or similar.

I'm perfectly fine with top level data or including it in the attesters object.
I'd prefer not to have a separate endpoint since it's something we need for each attestation produced. It's nice to keep all the data required to produce an attestation in the same call to avoid race-conditions if the shuffling updates during a fork.

it sounds like this value won't change within a single epoch as its based on active validator count

Correct; on any given chain the value is consistent across all slots in an epoch. No need for a per-slot array :)

It seems like we are trying to make VC to be BN cache. Any reason why BN can't have simple cache with (epoch + fork) => committee_count_at_slot mapping and fallback in case of missing cache would be "expensive" state read?
If we do wanna go this route, I would put it inside every duty as it doesn't involve changing response type dramatically (endpoint is expected to return array)

I would put it inside every duty as endpoint is expected to return array and it would be nice to keep some conventions

the beauty of the data wrapper is we can put this outside that as 'metadata' kind of concept, and it won't break the return... This is why things got wrapped, for messages and other metadata, so i think it'd be a great use-case...

When you are processing /validator/beacon_committee_subscriptions request, you don't have info on
attestation.data.beacon_block_root.

It's debatable as whether or not you should have access to attestation.data.beacon_block_root. You shouldn't re-propagate an attestation unless beacon_block_root is known, but the spec does not define restrictions as to what should be initially broadcast AFAIK. The most obvious choice to me would be "don't publish anything you wouldn't have re-propagated", which means you would have access to beacon_block_root.
That being said, what I propose allows for always publishing the attestation on the correct subnet without needing to know beacon_block_root.

you can only rely on BNs head chain

Relying on the BNs head chain is what creates the risk of publishing on the wrong subnet.

In case of bug reorg that would change subnet, VC would have to get new attester duties and send another /validator/beacon_committee_subscriptions request.

The goal is to ensure that the subnet that is chosen is consistent with the attestation.
Just because a validator has published an attestation to a BN on a different fork doesn't necessarily mean that the attestation should be disregarded by that BN.

I had a chat with @mpetrunic out-of-band and he convinced me that I might be wrong here. I need to do some more digging on our end, I'll re-open if/when I figure out what we need.
Apologies if this turns out to be a waste of time!

I am following this up at #81


remove the hack for prandtl number of XZ plane

Purpose

To be merged after https://github.com/CliMA/ClimaCore.jl/pull/1584
To-do

Content

[ ] I have read and checked the items on the review checklist.

You can also use the new length scale stuff as well.

why ci, why 😭


NSight graphics unable to correlate Slang with SPIRV/SASS

I need to profile some high performance slang code, but it’s been difficult to understand the results I’m getting out of nsight compute.
The main issue I’m facing is that, even if I use “-g3” when I compile my slang code to SPIRV, nsight is unable to correlate the SPIR-V output with the slang source code.
I can see debug instructions in the SPIRV, as well as the original source code at the top of the SPIRV. I can also see an embedded filename which is correct. So I’m not sure why correlation isn’t working.
I can also use the flag to avoid mangling variable names, and then the SPIRV becomes a bit more recognizable, but it’s still really tough to understand bottlenecks after a certain point.
Ultimately, I’m looking to get a similar result with Slang and Nsight Graphics as I do with CUDA and —line-info in Nsight compute.
Is this expected to work today? Or are there still some features that needs adding for source -> disassembly correlation in nsight to work?

Just to document current behavior a bit more clearly,
In the screenshot below, I see that NSight is only able to determine a SASS to SPIRV correlation, but cannot correlate the SASS to Slang.

With DXC / HLSL, NSight Graphics produces direct HLSL to SASS correlation, which is indicated like this:

As a consequence, it's very difficult to understand the output from NSight when using Slang over DXC.
Here's a screenshot of what "-g" currently produces:

When I click the dropdown where I'd expect HLSL or Slang, all I see is SPIRV and disassembly, which is difficult to decipher.

We have reproduced this issue and created a repro package for the nsight team to investigate. Since this is not a Slang issue, we will close this for now. We will report back here if we hear any updates.

This has been fixed in top of tree nsight, and may be made available in the next nsight release.


Exporting list of articles

Is there a possibility to export a list of articles indicated per RSS feed ?  This list could be in .csv or other common list format, and would contain all the information mentioned in the overview list: subject, date, folder, author, link, if possible brief summary, attachments.  Is there any plug-in for this feature available ?

Not exactly, but…
1/ One of the lesser known feature of Vienna is that you can select multiple articles at once in the main tab. Just extend the selection by clicking on articles while pressing the Shift key or the Command key (so the selection can be discontinuous).
2/ You can then copy these articles and paste them in a third party app. Drag and drop might also be convenient. You will not get all the details you want, though…
3/ if you want to keep as much details as possible, you can print the selection to a PDF.
4/ Some people wanting to archive articles through PDF files were annoyed by relative dates ("Today", "Yesterday") in the output.
So we added a secret preference, which currently have to be activated in the Terminal :
defaults write uk.co.opencommunity.vienna2 DoesRelativeDateFormatting 0
will force Vienna to display absolute dates in Articles view.
You will have to quit and relaunch Vienna to activate the change.
To deactivate:  defaults delete uk.co.opencommunity.vienna2 DoesRelativeDateFormatting
Example :
Vienna - 3 articles.pdf

Thank you for the answer:
I understand point 1 and 2.  But putting these fields in a spreadsheet (LibreOffice) I get everything in column A, and that for the whole list.  We want to make a list for every calendar year, that is nog convenient at all.
Would it be possible to export the lines in a csv-format or other ?
Printing the selection is fully known by us, both continuous or a new page every article.  We already use that.
Point 4 is no  concern for us.  We do that for the past calendar year.  So the problem does not arise for us.
Would exporting the list be possible, eventually as a new feature ?  Thunderbird has such a feature already.  It is a very good example.
Kind regards.
André De Vleeschouwer.
ir. André De Vleeschouwer - AKMOS
Voorzitter Koninklijke Heemkring Hoghescote vzw
Secretaris-Bestuurder EKBRA vzw
Lid van IE-net Ingenieursvereniging
BTW BE 0821.893.668
Tel: +3236057989  GSM: +32473442675
@.***
https://www.akmos.be
https://www.heemkring-hoghescote.be
Op 20 jan. 2024, om 19:57 heeft Barijaona Ramaholimihaso @.***> het volgende geschreven:
Not exactly, but…
1/ One of the lesser known feature of Vienna is that you can select multiple articles at once in the main tab. Just extend the selection by clicking on articles while pressing the Shift key or the Command key (so the selection can be discontinuous).
2/ You can then copy these articles and paste them in a third party app. Drag and drop might also be convenient. You will not get all the details you want, though…
3/ if you want to keep as much details as possible, you can print the selection to a PDF.
4/ Some people wanting to archive articles through PDF files were annoyed by relative dates ("Today", "Yesterday") in the output.
So we added a secret preference, which currently have to be activated in the Terminal :
defaults write uk.co.opencommunity.vienna2 DoesRelativeDateFormatting 0
will force Vienna to display absolute dates in Articles view.
You will have to quit and relaunch Vienna to activate the change.
To deactivate: defaults delete uk.co.opencommunity.vienna2 DoesRelativeDateFormatting
Example :
Vienna - 3 articles.pdf https://github.com/ViennaRSS/vienna-rss/files/13998930/Vienna.-.3.articles.pdf
—
Reply to this email directly, view it on GitHub https://github.com/ViennaRSS/vienna-rss/issues/1720#issuecomment-1902239908, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIGCHSBVMJLZULSZ2T2MKGDYPQHR5AVCNFSM6AAAAABCDCEN6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGIZTSOJQHA.
You are receiving this because you authored the thread.


CI Performance Testing

🚀 Pull Request
Description
An MVP for CI performance testing PRs.
Things in this PR:
benchmarks/benchmarks/*
These are directly lifted from the offline metrics repository.  No edits made.
benchmarks/conda_lock_plugin.py
This is a low-touch change to asv.plugins.conda.Conda to use a lockfile as the environment source.
The trickiness here is that asv doesn't really have great support for per-commit environment changes.
It wants to make one environment and then run a whole load of commits in this same environment.
So this environment plugin moves the setting of environment packages to the build stage of testing
a specific commit.
This may have a poor interaction with parallel processing of environments.
.github/workflows/benchmark.yml
This workflow is configured to run on pull requests.
It runs asv on the head of the pull request and the head of the target branch.
The results are compared and output as an artifact from the run.  i.e. you can download the .asv/results
folder and interrogate in more detail if needed.
If the comparison finds performance degradation that hits ASV's criteria (currently default criteria)
then the run is marked as failed and will show up in the pull request checks section as a failed check.
See https://github.com/jamesp/iris/pull/9 for an example of this.
If there are no changes above the threshold, the check is a success.

Consult Iris pull request check list

Ok I think the checkout logic is way too naive, it will fail with branches and other forks.  I'll review it and come up with something better

ok @trexfeathers, I think this might be ready for final review.

I just took a look at compare.txt for the latest run. All the benchmarks for the 'previous' commit (main in this case) failed. Something to do with that checkout perhaps?
Benchmarks that have improved:

       before           after         ratio
     [149164ef]       [c1c7a17f]
           failed              n/a      n/a  aux_factory.FactoryCommon.time_create
           failed              n/a      n/a  aux_factory.FactoryCommon.time_return
           failed       14.6±0.1μs      n/a  aux_factory.HybridHeightFactory.time_create
           failed         81.4±2ns      n/a  aux_factory.HybridHeightFactory.time_return
           failed      16.2±0.05μs      n/a  coords.AncillaryVariable.time_create
           failed         82.8±5ns      n/a  coords.AncillaryVariable.time_return
           etc etc...

Should be resolved

Fancy adding this to the README?

Thanks for your persistence @jamesp


multiqc report in RNA-Seq workflow

Multiqc is a very nice addition for looking at many samples at once, thanks for adding. However, at least for RNA-Seq it seems as if the generated multiqc HTML report and associated data files are not copied to the output directory (even if multiqc is in tools_on). Could we get that enabled, please?

thanks yes sorry about that, i have a commit for that, will do it today.
thanks!
sent not from my computer

On Apr 5, 2016, at 05:27, Sven-Eric Schelhorn<EMAIL_ADDRESS>wrote:
Multiqc is a very nice addition for looking at many samples at once, thanks for adding. However, at least for RNA-Seq it seems as if the generated multiqc HTML report and associated data files is not copied to the output directory (even if multiqc is in tools_on). Could we get that enabled, please?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

I think it should work now. And now,multiqc runs by default since it is pretty fast.
thanks!

Thanks a bunch!

This is great! Thanks @lpantano, let me know if I can be of any help.


.NET API browser shows incorrect type descriptions

For example SequenceReader:
C++

generic <typename T>
 where T : value classpublic value class SequenceReader

Thank you for letting us know. We'll investigate this.

This issue was moved to mono/api-doc-tools#444


Backend - Store all games on the system as objects

The Pi will now take all of the games located in the Pi's game directory and store them in a dictionary accessible by the frontend. The games are stored as Game objects which have all of their necessary attributes.

@awb8593  Have you been able to confirm this works with a game already on the pi like minecraft???

@zmb6893 The new attributes have not been tested on the pi, only on my local machine, but the everything before the final 2 commits did get tested on it (launching it, getting the name and file path), so the changes that haven't been tested on it are the newly added attributes

Alright Mr. Burgos (@awb8593), it's your turn for code review now, part 2 👀

@awb8593 Looks good to me! The only think I would note is that in the json file, there is still your computer's file path, but we can change this in the future when we load the games up onto the console!
Feel free to merge this!

@zmb6893 Ah, games.json should be blank since its based on the pi's local directory. Committing a blank one now before merging


[STORM-1646] Fix Kafka unit tests

This fixes two unit test failures in external/kafka I saw when running tests repeatedly, especially on low resource VMs.
There was a race in the Exponential Backoff Manager that was fixed by switching the test to use simulated time.
The Kafka Utils Test was seeing failures on underpowered systems due to a timeout value that was too small. Added log4j2 properties xml to be able to change the log level printed in the output. Also changed metadata.fetch.timeout.ms to max.block.ms, as kafka 0.9 had deprecated the config. The test output had warnings like
39890 [main] WARN o.a.k.c.p.KafkaProducer - metadata.fetch.timeout.ms config is deprecated and will be removed soon. Please use max.block.ms

LGTM. +1

+1

There's also a metadata.fetch.timeout.ms here
https://github.com/apache/storm/blob/master/external/storm-kafka/src/test/org/apache/storm/kafka/bolt/KafkaBoltTest.java#L211

LGTM

Changed usage of metadata.fetch.timeout.ms in KafkaBoltTest as well.

+1

max.block.ms is not available for 0.8.x so IMO it would be not good to change storm-kafka module to strictly support 0.9 or higher. Users who use Kafka 0.9 or higher could use storm-kafka-client even though storm-kafka is not compatible with 0.9, but not opposite.

@HeartSaVioR,
I assumed that because storm-kafka already builds against kafka 0.9 and that the changes to max.block.ms were only in unit test code it would not affect any user compatibility.  Is that wrong?

Issue is that some users report that storm-kafka 1.0.0 with 0.9 is not working properly.
Please refer https://issues.apache.org/jira/browse/STORM-1755 and #1386.
When we adjust the version into 0.8.x, that option becomes useless for test codes, which could incur failures which seems hard to find.
But using metadata.fetch.timeout.ms wouldn't make any issues for Kafka 0.8 and 0.9. And I don't think storm-kafka can support Kafka same or upper than 0.10.0 clearly so no issue for using deprecated property. But this is just my 2 cents and I'd like to hear about other opinions, too.

storm-kafka will probably support 0.10.0, I believe the Kafka developers version their APIs so new clusters can talk to old clients. That shouldn't affect the choice of configuration parameters though, since any 0.8.x support in 0.10.0 would expect 0.8.x configuration parameters.
See https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/api/ApiVersion.scala and how it's used in https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala if you're interested. The way I understand it is the client indicates which version of the API it wants to use, and then the broker uses that version of the API for requests/responses.

Thanks for the explanation.  Will revert that change.

I might have been a bit quick on the trigger there. The Kafka coding guidelines target backward compatibility for one release only. So storm-kafka might not support 0.10.0.
(http://kafka.apache.org/coding-guide.html under backwards compatibility)

Yeah, I guess Kafka doesn't strictly respect semantic versioning, or their major version seems to 2nd number of the version at least before reaching 1.0.0.

Replaced by https://github.com/apache/storm/pull/1658


Using fix option on locked files

Hi,
using the fix option on locked files shows:
Found x vulnerable files
Fixed x vulnerable files
Completed in ... seconds
But it does not succeed, if the target file is locked / open file. At least for users running Windows OS.
Should return an error message. File locked instead.
Thanks

@fflo Thank you for suggestion. I will patch it later.

Thank you!

@fflo Use v1.2.3 release version. See also
https://github.com/logpresso/CVE-2021-44228-Scanner/blob/v1.2.3/src/main/java/com/logpresso/scanner/Log4j2Scanner.java#L112


⚠ Bofrost.lu has degraded performance

In e2eb9d8, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1010 ms

Resolved: Bofrost.lu performance has improved in d05ce64 after 24 minutes.


microblocks are not visible in the keyblock details page

Context information
application version:
device:
browser:
operating system:
Steps to reproduce

Navigate to https://aescan.io/keyblocks/921291 or any keyblock details page

What is expected?
A table with the microblocks inside of the keyblocks is displayed.
What is actually happening?

The table is not visible.

Already fixed in #705.


Provide dotfiles CLI

As a user, I want to be able to run common dotfiles tasks using a command line interface.
Acceptance Criteria

The command is named dotfiles
A rich and user friendly usage text is available

A short description is included
The currently used version is included
The location where dotfiles is installed is included

When executed without any options or subcommands, the usage text is printed
When executed with the option -?, -h or --help, the usage text is printed
When executed with the option -v or --version, the currently used version is printed
When executed with a subcommand, the corresponding script is executed

Arguments can follow the subcommand and are passed to that corresponding script

An add subcommand is provided

It takes a profile name <profile> as argument
When executed, the corresponding repository to that profile name is looked up on GitHub and cloned when available

The target directory for cloning is $DOTFILES/opt
When cloned, the profile is checked for an installer script

When an installer script is available, it is executed

A help subcommand is provided

It takes a subcommand name <command> as argument
When executed, the usage text of a specific subcommand is printed

A remove subcommand is provided

It takes a profile name <profile> as argument
When executed...

...the corresponding profile located in $DOTFILES/opt is checked for an uninstaller script

When available, that uninstaller script is executed

...the profile $DOTFILES/opt/dotfiles-<profile>-profile gets removed

An update subcommand is provided

When executed, it updates the dotfiles repository by checking out its master branch and pulling from the remote repository on GitHub

Pull Request: #1


Added an explicit type to items variable

The app I've been building for months has randomly started throwing this error: "error[E0282]: type annotations needed for Box<_>". I don't use this Crate directly and haven't updated any that I do use in a couple of weeks, so I'm not sure why the Rust compiler doesn't like this syntax now.

#681
#685
#689
#693
#695
#696
#697


Add BlackHole for modern audio routing

Project URLs

https://github.com/ExistentialAudio/BlackHole

Category

Audio

Description
Add BlackHole to applications.json, a modern MacOS virtual audio driver.
Why it should be included to Awesome macOS open source applications  (optional)
Anyone recording podcasts or screencasts on MacOS will at some point want to capture audio from another app, or setup background music of some sort. This works on the latests version of MacOS and is simple to use and install.
Checklist

[x]  Edit applications.json instead of README.md.
[x]  Only one project/change is in this pull request
[x]  Screenshots(s) added if any
[x]  Has a commit from less than 2 years ago
[x]  Has a clear README in English

@MarkBennett Thank you! 👍


Tag release

Please add a release tag, so that this repo can be referenced by release instead of 'master' or SHA. Release tags are the standard way that versions of terraform providers are managed.

@sadhasivam Can you please tag a release?


All Qiskit projects point to main CoC file

Pull Request Test Coverage Report for Build 370708127

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.601%

Totals

Change from base Build 370661665:
0.0%

Covered Lines:
2891

Relevant Lines:
3056

💛  - Coveralls


Gesture recognizer inside of a rn camera working only when background color is set to something

Hey, I was making kinda like a snapchat app and used rncamera to show the camera on the whole screen, I tried different configurations but gesture recognizer only works when its background color is set to some color, otherwise it does not.
Also when i try to place gesture recognizer above all the other elements then it only works on a small distance around the text which displays onSwipe callback recieved gesture
this is the rendered part :
``
<View style={{flex: 1, flexDirection: 'row', alignItems: 'stretch',backgroundColor: 'black'}}>
<RNCamera ref={ref=> { this.camera = ref; }} style = {styles.preview} type={this.state.cameraType}   flashMode={this.state.flash} autoFocus={this.state.autoFocus} mirrorImage={this.state.mirrorMode} permissionDialogTitle={'Permission to use camera'} permissionDialogMessage={'We need your permission to use your camera phone'} onGoogleVisionBarcodesDetected={({ barcodes }) => { console.log(barcodes) }} >
    <View style={{ flex: 1, flexDirection: 'row', justifyContent: 'center', alignItems: 'stretch', }}>
        <GestureRecognizer onSwipeLeft={(state)=> this.onSwipeLeft(state)} config={config} style={{ flex: 1, backgroundColor: None, }} >
            <Text>{this.state.myText}</Text>
            <Text>onSwipe callback received gesture: {this.state.gestureName}</Text>
            <View style={styles.blehh}>
                <View style={{flex: 1, flexDirection: 'row'}}>
                    <TouchableOpacity onPress={ this.changeCameraType.bind(this)} style={ [this.state.cameraType=='back' ?styles.backButton:styles.backButtonNew,{marginLeft: '1%'}]}>
                        <Icon name={ "camera"} size={16} color={this.state.cameraType=='back' ? "#ffff": '#000'} />
                    </TouchableOpacity>
                </View>
                <View style={{flex: 1}}>
                    <TouchableOpacity onPress={ this.takePicture.bind(this)} style={ styles.capture}>
                    </TouchableOpacity>
                </View>
                <View style={{flex: 1, flexDirection: 'row'}}>
                    <TouchableOpacity onPress={ this.changeFlashType.bind(this)} style={ [this.state.flashActive?styles.flashOnButton:styles.backButton,{marginLeft: '23%'}]}>
                        <Icon name={ "bolt"} style={{ color: this.state.flashActive? '#000': '#fff'}}size={28} />
                    </TouchableOpacity>
                </View>
            </View>
        </GestureRecognizer>
    </View>
</RNCamera>

``
Any help on how to make gesture swipe cover the whole screen without background color will be appreciated

I am currently having this same issue, were you able to figure out a resolution to this issue?

I am currently having this same issue, were you able to figure out a resolution to this issue?

Hey, so i am not sure entirely what is the issue but you can set the background transparency to an extremely small value making it appear transparent (in my case) :  backgroundColor: 'rgba(255, 255, 255, 0.15)'
Also the other difference i noticed was i set the gesture recognizer component directly inside the RNCamera one and the view component inside the gesture recognizer one. Like instead of code above you can do :
<RNCamera>
    <GestureRecognizer>
         <view>...
          .......
          </view>
    </GestureRecognizer>
</RNCamera>

Hope these help :) , again since there has been some time so I'm not sure which will help but these 2 were the major things i changed


willTransitionConfirm never called

Did ember install:addon ember-data-route, There is no complaining about the mixin or anything, it just doesn't work, silently.
import Ember from 'ember';
import DataRoute from 'ember-data-route/mixins/data-route';

export default Ember.Route.extend(DataRoute, {
  model: function () {
    return this.store.find('role');
  },

  willTransitionConfirm: function () {
    return window.confirm('You have unsaved changes that will be lost. Do you want to continue?');
  }

 // more code..
});

Ah, I have to create the record in the model hook.. Trying it now, since I have models I'm pulling in as well.


File upload

Hi,
I want to know whether file upload element can be generated using "json-editor" or not ?

+1

+1

+1

+1

Look out for hyper schema.
"imgData": {
            "title": "Simpsons Imaginary",
            "type": "string",
            "media": {
                "binaryEncoding": "base64",
                "type": "image/png"
            }
        }

Is it possible any how to get the filename in json? I want to add images into the json but need to save filenames too..


fix Fix read load profile failed

Profile ID of load task is a long string, DebugUtil.parseTUniqueIdFromString will throw exception instead of null when we pass long string to it. So we should handle the exception inside of parseProfileFileName.

run buildall

run buildall


chore(deps): Remove rimraf

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.67%. Comparing base (6893514) to head (b67e658).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   98.67%   98.67%
=======================================
  Files           7        7
  Lines        1432     1432
  Branches       52       52
=======================================
  Hits         1413     1413
  Misses         19       19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add Dovetail

Do you want to add or update the vendor? Adjust the title accordingly!
How to use? Fill the yaml file below!

name: Use the vendors name
base_pricing: Use the vendors cheapest available price suitable for teams/companies. A plan limited to less than 10 users may not be suited for companies.
sso_pricing: Use the vendors cheapest price that includes SSO.
scim_pricing: Use the vendors cheapest price that includes SCIM.
pricing_scheme: How is the pricing? Is it per user per month? Per month?
pricing_sources: Add a link or a note to where you got the pricing from. One per line.
notes: If you need to clarify pricing, please add a note.
free_sso_providers: Do they support free SSO providers like Google, Apple, Github etc.? One per line.
updated_at: yyyy-mm-dd of the day you filed this.
vendor_url: Use the vendors public website

---
base_pricing: 29
currency: USD
free_sso_providers: none
name: Dovetail
notes: SSO/SCIM only available at Enterprise tier
pricing_scheme: per user/month
pricing_sources:
  - https://dovetail.com/pricing/
scim_pricing: 175
sso_pricing: 175
updated_at: 2024-10-09
vendor_url: https://dovetail.com

Hey @lu3ke , did you get a quote or what's the source for the $ 175?


Refactor LigerFusedLinearPreferenceBase

Summary
This PR refactors the LigerFusedLinearPreferenceBase class to contain an abstractmethod corresponding to the calculation of the loss that needs to be implemented by all sub-classes.
It also adds a new function to the class called _compute_loss which is mostly the same as the _compute_orpo_loss function introduced in #362 but makes it generic to calculate the NLL/Cross Entropy Loss plus accepts a custom loss function that implements a new alignment loss function.
Most RLHF/RLAIF/Alignment algorithms state their final loss as NLL + Beta * (Alignment_Loss) so adding the NLL logic inside the base class reduces repeated code.
The _compute_loss function accepts
Testing Done
On A100-80G-SXM

Hardware Type:
[X] run make test to ensure correctness
[X] run make checkstyle to ensure code style
[X] run make test-convergence to ensure convergence

This was quick. Great refactor!


Introducing devenv Guru on Gurubase.io

Hello team,
I'm the maintainer of Anteon. We have created Gurubase.io with the mission of building a centralized, open-source tool-focused knowledge base. Essentially, each "guru" is equipped with custom knowledge to answer user questions based on collected data related to that tool.
I wanted to update you that I've manually added the devenv Guru to Gurubase. devenv Guru uses the data from this repo and data from the docs to answer questions by leveraging the LLM.
In this PR, I showcased the "devenv Guru", which highlights that devenv now has an AI assistant available to help users with their questions. Please let me know your thoughts on this contribution.
Additionally, if you want me to disable devenv Guru in Gurubase, just let me know that's totally fine.

Hi everyone,
Have you had a chance to check this out?
Additionally, I’d like to update you on the release of the Maintainer Panel feature on Gurubase. With this panel, you can add, remove, or update data sources, as well as change the logo and more. You can find the details about how to claim a Guru here.
In the near future, I’m planning to include analytics insights in this panel, such as the number of questions asked, the most frequently asked ones, and more. I’ll be sure to update this thread once it’s available. However, in case I miss it, I highly recommend joining our Discord channel to stay updated.
If you’d prefer that I don’t update this thread anymore, please let me know.


128 add 5 solutions for 63 a e

[✅] Add 5 solutions for A-E problems.
[✅] Cover the solutions with tests (100%).
[✅] Update README.

Although Codacy flagged a request-with-http issue, I am aware of it and can confirm that it does not pose any risk.


Walletconnect support

Hi Ian, do you know if it's possible to get walletconnect support? It seems like adapter was set up a month ago. I would be happy to create a PR but it seems that because it the adapter accepts nonstandard options such as a projectId field, it's slightly nontrivial to integrate (happy to take a stab). The use case I have is for fireblocks support.

We'd be happy to take a PR!

Can an admin trigger the Release workflow? Interesting in consuming the wallet-connect support.
cc: @michaelhly

@iulianbarbu released!


clj-http without slingshot

I think the less dependency is better. We could throw an ex-info exception using regular throw fn & let user choose to use Slingshot if they want. Thought?

I think I'm +1 on this, I'm just not sure whether this qualifies as breaking and thus should warrant a 4.0, or whether it can safely go in without breaking anything...

I think I agree about setting expectations by putting this in a 4.0 release.

I'll branch master into a 3.x branch and update master to be 4.x, then this can be merged.

I've merged this into the (now 4.x) master branch, thanks!


are there conflicting versions of isapprox in IntervalSets?

For my package HiQGA.jl, I keep getting this new error even on reverting to stable versions
[ Info: Precompiling HiQGA [01574e87-63b6-4466-925a-334cf7e21b6b]
WARNING: Method definition isapprox(IntervalSets.AbstractInterval{T} where T, IntervalSets.AbstractInterval{T} where T) in module IntervalSets at /blah/.julia/packages/IntervalSets/voJZA/src/IntervalSets.jl:146 overwritten in module DomainSets at /blah/.julia/packages/DomainSets/aafhp/src/domains/interval.jl:52.
  ** incremental compilation may be fatally broken for this module **

Could this perhaps be related to e3185fe73c7b67fcede158389499cf521a9d5522 ? I do not explictly use DomainSets or IntervalSets in my code.

Thanks for reporting. The issue arises because conflicting versions of isapprox have been defined. This isn't a problem in DomainSets v0.6 anymore, but I guess in your case you have no control over that as the packages you depend on would have to upgrade DomainSets.

Revert the change in IntervalSets, tag, Revert the revert, tag again as a breaking chagne

I'm understanding this was because of the type piracy in DomainSets.jl. Adding isapprox in IntervalSets.jl is just a new feature, so we don't need to update the minor version of IntervalSets.jl. If one wants to avoid this problem, just add IntervalSets.jl by the following command.
]add<EMAIL_ADDRESS>

Yes, but what about those who depend on IntervalSets but are not directly adding it in their packages? A breaking change release would be better in this case without requiring that I track down my entire package tree, no?

Maybe we can have a 0.5.x release in DomainSets that sets an upper cutoff on IntervalSets to 0.7.3? This isn't a full fix, as the resolver may downgrade DomainSets and upgrade IntervalSets, but it'll address the problem somewhat. Ideally we should create a PR in the general registry to limit the compat bounds on IntervalSets as well for all DomainSets 0.5.x releases. If all versions of 0.5.x are compatible with IntervalSets 0.7.3 at most, this problem won't arise

Maybe we can have a 0.5.x release in DomainSets that sets an upper cutoff on IntervalSets to 0.7.3? This isn't a full fix, as the resolver may downgrade DomainSets and upgrade IntervalSets, but it'll address the problem somewhat. Ideally we should create a PR in the general registry to limit the compat bounds on IntervalSets as well for all DomainSets 0.5.x releases. If all versions of 0.5.x are compatible with IntervalSets 0.7.3 at most, this problem won't arise

This looks like the simpler option - can that be done with the help of JuliaRegistrator or is this manual work? I have no experience with creating out-of-order releases.

We create a separate branch from the last 0.5.x release and push it to the repo, commit the changes to that branch, and tag that commit using JuliaRegistrator. The branch will need to co-exist with master, and will be a backport branch thereafter (may be neglected if no updates are necessary).

That seems to have worked and 0.5.15 is out, though I'm noticing some glitches. The Diff since 0.5.14 in the release page is fine, but the list of closed issues and merged pull requests on that page is not correct, as it shows commits not included into this release.

Yes, that's a bit unfortunate. Should we also update the compat limits in the general registry? This has to be manual PR. Perhaps all old versions compatible with IntervalSets v0.7 need to be capped to 0.7.3

seen this for a while as well, after upgrade this is gone.

seen this for a while as well, after upgrade this is gone.

BTW @a2ray does this resolve your issue? Could you try a package upgrade and check again?
Yes it does, on upgrading HiQGA I get

⌅ [5b8099bc] ↑ DomainSets v0.5.14 ⇒ v0.5.15

without the old incremental compilation error. Is fixed now, many thanks!

I think in retrospect we should of considered the removal of isapprox here and the changing behaviour a "bug fix" so it would have been a patch.....


docs: Fix path

✅ Checklist

[x] I have followed every step in the contributing guide (updated 2022-10-06).
[x] The PR title follows the convention we established conventional-commit
[ ] I performed a functional test on my final commit

Changelog

Keeping paths relative to root folder

💯

We use paths without src in a lot of places, for example https://github.com/t3-oss/create-t3-app/blob/next/www/src/pages/en/usage/trpc.md
Whatever we decide should be consistent across the whole docs, so I guess the question is so we want the explicit src nowhere or everywhere?

Whatever we decide should be consistent across the whole docs, so I guess the question is so we want the explicit src nowhere or everywhere?

Problem for a later day ;)


investigate alternative data used for third sound-data icon, or use alternative icon altogether

We should use different sound data for the third sound icon in the <SoundList /> component, or use a different <Ionicon /> altogether.

The third sound-data icon shows a play circle, which to me might imply the number of downloads, or the number of plays, but the actual data we show is the number of ratings, as we can tell from looking at line 86 of tide/src/SoundList.js, which says,                   {track.num_ratings}.
The Sound resources section of the Freesound API documentation says we can access the "Number of times the sound has been downloaded", which we already use, the "Number of times the sound has been rated", and the "Number of times the sound has been commented", among other things.
I haven't been able to find anything that says we can see the number of times a sound plays.
If we do want to use the "Number of times the sound has been rated", https://ionicons.com does have an <ion-icon> we can use.

Which approach do we want to take?

I think we should go with the star rating icon it is! What are your thoughts on that?

Sounds good to me! Maybe @akshara-sun will want to take on the implementation?

Star sounds like a great idea! Will get this issue in tonight!


feat: Rename cp4aiops to cp4waiops

Is your feature request related to a problem? Please describe.
The official name of the Cloud Pak is Watson for AIOps, and that carries to many resource and folder names in the actual product.
This repository uses only "aiops" instead of "waiops" in many places and that causes some surprises for people expecting that it would align with the product symbols.
Describe the solution you'd like

Replace all occurrences of aiops to waiops inside resource names.
Rename all occurrences of cp4aiops with cp4waiops in folder names.

Describe alternatives you've considered
None.
Additional context
Add any other context or screenshots about the feature request here.

:tada: This issue has been resolved in version 0.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore: better docker readme

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.055%

Totals

Change from base Build<PHONE_NUMBER>4:
0.0%

Covered Lines:
12117

Relevant Lines:
15865

💛  - Coveralls


Root object copy button and closing curly brace not respecting theme color

It seems like the built-in theming is missing for a few elements. In particular, the copy button and the closing curly brace for the root object don't receive any styling from base07 like the rest of the text.

released v3.3.1


change repr return value

the repr method of the object should return the syntax required to initialize said object.

You are totally correct about this, but I am going to (finally) merge a mostly rewrite replacement to the current code base. So I'm going to close this, but make the equivalent change in the new code base.


Correct doc of LSTMBlockFusedCell

The second return value of LSTMBlockFusedCell's _call_cell function is a LSTMStateTuple that represents the final hidden state and final output, not a 3D tensor.

Hey @sijunhe, thanks for the PR!
@ebrevdo do you know if that's the intended behavior? I expected the return value to be 3D for both outputs and states.

Can one of the admins verify this patch?

closing this PR as contrib folder will be depricated in 2.0, thank you.
CC @mihaimaruseac


Fix an error link

In the Chinese version of the document, we should use  “#准备开始” instead of “#before-you-begin”.

Ideally, we should use English word for anchors and links.
But in this case, the shortcode is making that a little tricky.
/lgtm
/approve

Ideally, we should use English word for anchors and links.
But in this case, the shortcode is making that a little tricky.
/lgtm
/approve

如果英文的标题是
##test
然后中文翻译成了
##测试
然后另一个页面英文的跳转到它是/xxx/#test，在中文##测试  这个后面加锚点是怎么加来着

### 测试 {#test}


Cherry-Pick: Updated eth_estimateGas bad input tests (#1175)

Description:
Cherry-Pick of PR 1175 into release/0.23 branch

Codecov Report
Patch coverage has no change and project coverage change: -0.53 :warning:

Comparison is base (094b1e4) 75.12% compared to head (277b3d2) 74.59%.

:exclamation: Current head 277b3d2 differs from pull request most recent head 529dbe9. Consider uploading reports for the commit 529dbe9 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           release/0.23    #1179      +/-   ##
================================================
- Coverage         75.12%   74.59%   -0.53%
================================================
  Files                18       31      +13
  Lines              1628     2169     +541
  Branches            330      427      +97
================================================
+ Hits               1223     1618     +395
- Misses              327      438     +111
- Partials             78      113      +35

see 14 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Snow not Accumulating.

Not sure if its a glitch or another mod might be interfering but no matter how long I wait for snow to pile up it just stays in the one layer like vanilla, I'm running the latest forge, mod version, opitfine and a few other mods. All updated playing 1.12.2 (example serene seasons, OTG, biome bundle ,dynamic trees...). I havent messed with any of the config files in any way, so I'm not sure whats going wrong?

Heres after waiting for an hour just full on snowing, its a normal new flatworld.

Sorry for the late response, the issue is likely due to either the biomes mods or a change in forge that prevented this mod from loading. The snow check is effectively the same as in vanilla, and this mod is extremely simple so there's not a whole lot of places for things to go wrong. That version was compiled for 1.12, but if I have time I may try porting it up to 1.12.2


Fix cstyle error in ./src/istgt_cmd_table.c #2056

Fixed ./src/istgt_cmd_table.c as mentioned in issue here

@payes fixed make file. Can i know output of Better Code Hub, to fix that.

Closing this PR due to inactivity. @krishnakarthik9 Feel free to reach out us.


grafana can't run up after upgrading to the latest version

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
After updating the grafana to the latest version, the container is always rebooting. The log shows "mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied".
Expected Behavior
No response
Steps To Reproduce
No response
Relevant log output
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied
mkdir: can't create directory '/var/lib/grafana-plugins': Permission denied

Screenshots
No response
Additional data
No response
Type of installation
Docker
Version
v1.28.1

Please share your full docker-compose.yaml

The yml is just copied from docs.teslamate.org only with change of the input of password. I tried to completely reinstall with the compose yaml, it shows " ⠿ Volume "_teslamate-grafana-data"  Error                                                                                0.0s
Error response from daemon: create _teslamate-grafana-data: "teslamate-grafana-data" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9.-]" are allowed. If you intended to pass a host directory, use absolute path".

Please copy the docker.compose.yaml as raw, it seems like you have unallowed caracters in there.

it might be that there is an existing volume from a previous grafana container that needs to be dropped. we simplyfied the grafana image.

Try to rebuild the container with yaml and it successed.

Thanks @swiffer for quick assistance!


Add Kanagawa theme

Added the Kanagawa theme based off kanagawa.nvim.

Is the code good then? Can someone approve it?

@DioEgizio It says there's still a workflow awaiting approval for the PR, any way to change that so the PR is approved?


Question - Is there any scope to include the windows base images

I was wondering if there is any scope for supplying .net framework images built on the windows base OS image (mcr.microsoft.com/windows)
I know the images are bigger than servercore but we have a use case to use the Windows:1809 image and installing .net 4.8 is causing issues

@andyfisher100, There are no plans for provide Windows based .NET Fx images.  The overwhelming feedback is for smaller images.  While there are use cases for Windows based images, they are limited.  There does not appear to be enough demand to justify the investment to produce and service them.  We expect users to create and manage their own images if they are needed.

@andyfisher100, There are no plans for provide Windows based .NET Fx images. The overwhelming feedback is for smaller images. While there are use cases for Windows based images, they are limited. There does not appear to be enough demand to justify the investment to produce and service them. We expect users to create and manage their own images if they are needed.

Makes sense, i only want to use servercore myself but ended up with a use case for windows unfortunately. Thanks for the feedback!


Revert "Make variables optional if skip is provided (#1926)"

Please see #2145 issue.
This reverts commit 6508ba45ff32608f353aaba0dc50c149a3ff1ad0.

Thanks @palindrom615 , I think we have a solution without reverting: https://github.com/dotansimha/graphql-code-generator/pull/2251


automatically book the next slot in auto booking mode

Here we have to press any key to continue, instead if the booking failed it should just keep automatically trying other slots without user input
+-------+-------------------+------------+-----------+-------------+------------+------------------------------------------------------------------------------+
|   idx | name              | district   |   pincode |   available | date       | slots                                                                        |
+=======+===================+============+===========+=============+============+==
============================================================================+
|     1 | APOLLO HOSPITAL 1 | BBMP       |    560076 |           1 | 07-05-2021 | ['09:00AM-11:00AM', '11:00AM-01:00PM', '01:00PM-03:00PM', '03:00PM-04:00PM'] |
+-------+-------------------+------------+-----------+-------------+------------+------------------------------------------------------------------------------+
AUTO-BOOKING IS ENABLED. PROCEEDING WITH FIRST CENTRE, DATE, and RANDOM SLOT.
============> Got Choice: Center #1, Slot #3
Booking with info: {'beneficiaries': ['xxxxxxxxxxxxxxxx'], 'dose': 1, 'center_id': 566035, 'session_id': '0ee65cd7-39de-463a-b86b-6e25c62f1a8e', 'slot': '01:00PM-03:00PM'}
================================= ATTEMPTING BOOKING ==================================================
Booking Response Code: 409
Booking Response : {"errorCode":"APPOIN0040","error":"This vaccination center is completely booked for the selected date."}
Response: 409 : {"errorCode":"APPOIN0040","error":"This vaccination center is completely booked for the selected date."}
Press any key to continue . . .

The script doesn't exit though, right? It goes back and shows the next set of options?

It doesn't exit, but needs a key input to proceed to the next.

you have to press enter.. and if u r not near the system you will loose out..

okay.. will remove that system pause

This has been implemented in the latest version


codebert-base.commons-lang.mid-122.idx-14626.3.buggy

Updated Indentation in Buggy Code

Closing due to conclifts. Sorry if we accepted some PR before yours.


No MacOS ARM64 wheels for Python 3.10 and 3.11

As shown here https://pypi.org/project/kornia-rs/0.0.8/#files
Also, a separate issue. On my Mac M1, when I run pip install kornia-rs, it tries to install 0.0.1 version from source (and fails). This is probably because only 0.0.1 version has source distribution (https://pypi.org/project/kornia-rs/0.0.1/#files, see the .tar.gz file), while newer versions don't have. When I run pip install git+https://github.com/kornia/kornia-rs, it can be built from source just fine.

That’s possibly a flag in here: https://github.com/kornia/kornia-rs/blob/main/.github/workflows/release.yml#L36
Beware about the project refactor though https://github.com/kornia/kornia-rs/pull/32

Yup, works for me now.
On a separate note, we probably should run tests for kornia-rs on various OS x Python combinations? I notice that currently only Ubuntu runs tests now. I think now GitHub Actions have free MacOS ARM64 runner for open source projects?

added here: https://github.com/kornia/kornia-rs/pull/52/files#diff-057cc96278abef7805c36e31271c952e066432c7be2c98b1b13e368ba3c557a8R34


some more menu tests

Codecov Report

Merging #489 into master will increase coverage by 1.17%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   69.61%   70.79%   +1.17%
==========================================
  Files          47       47
  Lines        3706     3725      +19
==========================================
+ Hits         2580     2637      +57
+ Misses       1126     1088      -38

Impacted Files
Coverage Δ

tests/test_menu.py
100% <100%> (ø)
:arrow_up:

vent/menus/start_tools.py
45.19% <0%> (+1.92%)
:arrow_up:

vent/menus/start_core_tools.py
44.66% <0%> (+1.94%)
:arrow_up:

vent/menus/stop_tools.py
34.78% <0%> (+2.17%)
:arrow_up:

vent/menus/stop_core_tools.py
34.06% <0%> (+2.19%)
:arrow_up:

vent/menus/clean_tools.py
36.36% <0%> (+2.27%)
:arrow_up:

vent/menus/update_tools.py
36.36% <0%> (+2.27%)
:arrow_up:

vent/menus/build_tools.py
36.36% <0%> (+2.27%)
:arrow_up:

vent/menus/update_core_tools.py
35.63% <0%> (+2.29%)
:arrow_up:

vent/menus/clean_core_tools.py
35.63% <0%> (+2.29%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 595838b...33bfa12. Read the comment docs.


[move framework] Simplify LibraConfig for verification

Remove capabilities as values to make verification doable.
This retains the use of the basic ModifyConfigCapability, which is
stored at the address of the signer who is authorized to modify the
capability (currently, that signer is always libra root).

Motivation
(Write your motivation for proposed changes here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
Three of the tests in language/move-lang/functional-tests fail. I'm not sure how to fix them all.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@bors-libra r=sblackshear

:pushpin: Commit eae06b6 has been approved by sblackshear

:hourglass: Testing commit eae06b6f9e8a0874e2692f17d92b1bd88394bbd7 with merge 01568d5e3958c3e070e2c3b854002c64a2ac1483...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sblackshear
Pushing 01568d5e3958c3e070e2c3b854002c64a2ac1483 to master...


dynamic query graphql apollo with java

The routine of working with the graphql apollo is that add file query .graphql
i would create dynamic query with java and i do not create file for each query
in fact, i would to get dynamic querys with Java
questions
is it possible?

By dynamic do you mean some sort of Java builder to construct the query? If yes than the answer no as the whole idea behind the Apollo is completely different,  for example dynamic query won't allow you to build queries with non null assurance.

@sav007
As I understand it, it does not make the following queries dynamically with Java right?
query EntryDetailQuery($repoFullName: String!) {
  entry(repoFullName: $repoFullName) {
    id
    repository {
      full_name
      description
      owner {
          login
      }
    }
    postedBy {
      login
    }
  }
}

next time just request full_name or other field...
query EntryDetailQuery($repoFullName: String!) {
  entry(repoFullName: $repoFullName) {
    id
    repository {
      full_name

    }
  }
}

Yes it static query, first you need to write GraphQL query probably give it a try in GraphiQL tool and then when it's ready you save it and Apollo will generate models for the query. You can later modify it and Apollo will re-generate models.

There is no current support planned for dynamic queries. You can explore creating a fork and implementing there.


web sockets and osc

Hi there,
I was wondering if there is a possibility to use ofxLibwebsockets in combination with osc. Now I have to admit that I am no expert on servers, but if I understand correctly the problem is that WebSockets can only connect to a web sockets server. So is there a way with the current library to bridge a server between OSC and ofxLibwebsockets.

Hello! Sorry for the delay.
There's not a built-in way to build the bridge; you'd have to do so yourself. It'd be really useful and interesting, for sure! One that'd be really interesting is to try to get it working with OSC.js.

Thanks for the reply! I will keep you posted when I have something running.


I can't install the extension Privacy Badger

Describe the bug
A clear and concise description of what the bug is.
I can't install the Privacy Badger extension from the Chrome store.
I press the "Install" button and nothing happens. An error appears at the bottom of the page (screenshot) - "An error occurred during the download".
To Reproduce
Steps to reproduce the behavior:

Open the Chrome Store.
https://chromewebstore.google.com/?hl=ru
Find the Privacy Badger extension.
https://chromewebstore.google.com/detail/privacy-badger/pkehgijcmpdhfbdbbnkijodmdjhbjlgp
Click the Install button.

Expected behavior
A clear and concise description of what you expected to happen.
I want the Privacy Badger extension to be installed normally.
Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

Device: [e.g. OnePlus 7]
Asus ZB602KL.
Android Version : [e.g. A11 ]
8.1.
Kiwi Browser Version [ e.g. 90.0.4577.17 ]
124.0.6327.4.

Additional context
Add any other context about the problem here.
The Privacy Badger extension was installed (version 2024.2.6) only from the Crx4Chrome website. Newer versions are not installed. It's not normal.

Same here.


Upgrade  WordPress Coding Standards to 3.0.0

Is your enhancement related to a problem? Please describe.
WordPress Coding Standards 3.0.0 has been released recently. Action currently uses version 2.3.0. As 3.0.0 is a major release, the expectation here is to make sure everything works fine with WPCS 3.0.0 before we upgrade to it.
Designs
No response
Describe alternatives you've considered
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

As mentioned here, as part of this work, we'll want to investigate switching from using git to install the standard and use composer instead.

Note that VIPCS also updated to 3.0.0 as well


Update stats in capture files as records are written

This will allow us to have an accurate count of records even in the case where a process is killed early by a signal.

Closing in favor of #128


gpt --config keeps prompting to update to newer version, even after updating

I did a fresh install of gpt following the directions from the README:
brew install deo
deno run -rA https://deno.land/x/shellgpt/install.ts

This message is kind of strange, not sure what the warning means
Warning Implicitly using latest version (0.3.6) for https://deno.land/x/shellgpt/install.ts
ShellGPT 0.3.5 installer

Newer version of ShellGPT is available: 0.3.5 -> 0.3.6

Please run the following command instead to update:
deno run -A https://deno.land/x/shellgpt/install.ts

Type 'skip' to continue with the installation of an outdated version.

Not clear what the right answer to the question at the end is, but it only installs if I type skip. Also the suggested command to update is the same as the one that I ran
After skipping, it installed
Skipping update...

What command should be used to invoke gpt?
(default: gpt, leave blank to use default)
> gpt

Would you like ShellGPT to check for updates?
Options:
(y)es - ask before installing [default]
(a)uto-update - install updates automatically without asking
(never) - never install or ask
leave blank to use default
> y

$ deno install -frA -n gpt https://deno.land/x/shellgpt/mod.ts
Would you like to run the above command to complete ShellGPT installation?
(y)es [default]
(n)o
leave blank to use default
> y

And now there was another warning about using the latest version
Warning Implicitly using latest version (0.3.6) for https://deno.land/x/shellgpt/mod.ts
✅ Successfully installed gpt
/Users/nico/.deno/bin/gpt
ℹ  Add /Users/nico/.deno/bin to PATH
    export PATH="/Users/nico/.deno/bin:$PATH"

Configure and update via:
$ gpt --config

But when running the command (gpt --config), it would always give this same output:
gpt --config
Newer version of ShellGPT is available: 0.3.5 -> 0.3.6

$ deno install -frA -n gpt<EMAIL_ADDRESS>Would you like to install the latest version of ShellGPT?
(Y)es / (n)o / (never) / (a)lways]: y
✅ Successfully installed gpt
/Users/nico/.deno/bin/gpt

# command for zsh-completions
autoload -U compinit && compinit

> Successfully updated! Please re-run `gpt --config`

ShellGPT seems to work, but I'm not sure which version I'm running or if the updates will work
gpt --repl
(No message passed)

> hello there
Hello! How can I assist you today?

>

Made a video where I go through the process, it's at 4:25 aprox here: https://www.loom.com/share/7f415a53cb404cb0a059a9a065addce8

Thanks very much for reporting with the thorough info @nicobrenner. I forgot to increment the version number correctly. Just fixed in 0.3.7.

(oops, actually, it's fixed in 0.3.8)


Don't execute code if it's a blank string.

Fixes #1491
I haven't run the tests yet.

I think I'd rather have the Python code check whether it's empty. That way when (if) we add a backend that can do something with an empty line, it isn't being blocked by VS.


🔩[feature request] - Add support to https://github.com/iancoleman/bip39

You guys have created a powerful tool, and integrating it into https://github.com/iancoleman/bip39 would allow for the broader crypto community to access it easily. Please do that when you get a chance!

This library is really just a thin wrapper around https://github.com/ipfs-shipyard/js-human-crypto-keys that exposes the minimum needed API needed to generate Arweave compliant RSA keys using mnemonics. I believe the bip39 library you referenced above is actually used within the human crypto keys library to generate the mnemonic that serves as the random seed for the keys created by the library. I don't have the technical chops at this point to add key generation to the bip39 library.


Scripts need to be fixed - they may not work under virtual environment

Hello @Tigge and all,
The scripts, for example 40-convert_to_tcx.py or 40-upload_to_garmin_connect.py, have #!/usr/bin/python as their firs line for invoking python.
If you run antfs-cli inside a python virtual environment this may cause the scripts not to pick the right environment. An example might help me to explain:
I installed antfs-cli and garmin_uploader inside the same python 3 virtual environment. My /usr/bin/python is python2.7. So when I run antfs-cli and it invokes the 40-upload_to_garmin_connect.py, the later run under a different python environment (and version) and thus fail to import garmin_uploader.
The way to correct this, which, IMHO, is the general correct way, is to use #!/usr/bin/env python in the scripts. This will use the correct python interpreter with the correct environment.
And thanks - this is a great tool.
--- Amit

Hi @amitramon. Agreed, using the env shebang is more correct! Could you prepare a pull request for this? If not I'll try to get some time next week to fix this.

Hi @Tigge , great. I've just created a pull request.


[Storage] Client side encryption with KeyVault

Depends on unmerged PR #7473.

Can one of the admins verify this patch?

Thanks a lot @tjprescott
Can you change the base branch to https://github.com/Azure/azure-sdk-for-python/tree/storage-samples-readme

Closing in favor of PR #8186.


publish callback in wrong place for QOS > 0

The user defined publish callback is set to be called when a message is successfully sent to the MQTT server. For QOS0 this is OK, but for QOS1 and QOS2 the rest of the publish transaction is being ignored.
In these cases the correct place to call the publishCb callback  in mqtt.c would be after line 388 for QOS1 and after line 406 for QOS2:
          case MQTT_MSG_TYPE_PUBACK:
            if (client->mqtt_state.pending_msg_type == MQTT_MSG_TYPE_PUBLISH && client->mqtt_state.pending_msg_id == msg_id) {
/********** QOS1 here ************/
              MQTT_INFO("MQTT: received MQTT_MSG_TYPE_PUBACK, finish QoS1 publish\r\n");
            }

            break;
          case MQTT_MSG_TYPE_PUBREC:
            client->mqtt_state.outbound_message = mqtt_msg_pubrel(&client->mqtt_state.mqtt_connection, msg_id);
            if (QUEUE_Puts(&client->msgQueue, client->mqtt_state.outbound_message->data, client->mqtt_state.outbound_message->length) == -1) {
              MQTT_INFO("MQTT: Queue full\r\n");
            }
            break;
          case MQTT_MSG_TYPE_PUBREL:
            client->mqtt_state.outbound_message = mqtt_msg_pubcomp(&client->mqtt_state.mqtt_connection, msg_id);
            if (QUEUE_Puts(&client->msgQueue, client->mqtt_state.outbound_message->data, client->mqtt_state.outbound_message->length) == -1) {
              MQTT_INFO("MQTT: Queue full\r\n");
            }
            break;
          case MQTT_MSG_TYPE_PUBCOMP:
            if (client->mqtt_state.pending_msg_type == MQTT_MSG_TYPE_PUBLISH && client->mqtt_state.pending_msg_id == msg_id) {
/********** QOS2 here ************/
              MQTT_INFO("MQTT: receive MQTT_MSG_TYPE_PUBCOMP, finish QoS2 publish\r\n");
            }
            break;

In addition, there would need to be a check for QOS0 in the current spot where it's called (line 463) but I can't see where the QOS value for the transaction can be accessed.

I discovered this little wrinkle because I'm deep sleeping my device regularly, and so have transaction counting in place to work out when the device has completed and can sleep. The publishCb function was being called too early for QOS1 and the unit was sleeping before the last transaction had completely finished.

OK I found where the pending QoS can be retrieved so line 463 would need to be:
	if ((client->connState == MQTT_DATA || client->connState == MQTT_KEEPALIVE_SEND)
			&& client->mqtt_state.pending_msg_type == MQTT_MSG_TYPE_PUBLISH) {
		if (client->publishedCb && client->mqtt_state.pending_publish_qos == QOS0)
			client->publishedCb((uint32_t*) client);
	}

So it turns out that mqtt_state.pending_publish_qos is never set in the code so it's always 0 (QOS0). This would need to be set just before sending the message at line 744:
			client->mqtt_state.pending_publish_qos = mqtt_msg_get_qos(dataBuffer);


[9.x] Cleanup request test

There are two things I try to clean up in this PR:

Request::create() sets the second parameter (method) as "GET" by default. If a test doesn't care about the method, we needn't to pass it explicitly.

prefers method test doesn't look good to read. Using data provider make it easier to read.

For example, Within the case ['application/json', ['json'], 'json'], we can describe it like this:

If the request has the header accept to be 'application/json', the prefers method that takes ['json'] as it's parameter will return 'json';

Any reason why you sent this in to master and not to 8.x?

Firstly, I think 8.x is the stable version and it avoids these MRs like this.
Secondly, I remember that Taylor often prevents these things from being merged into the current stable branch. I may be wrong.
Finally if it's not a bug and I am not sure which branch I should target, I will send to the master branch.

@seriquynh these are only changes to the test suite. Nothing will be broken by these. I think you're free to send this in to 8.x

@driesvints Thank you for you help! I will send this to 8x.
I'm sorry if I miss something. However, This MR is absolute not a minor or major change, it is not also a bug fix. Do you think Laravel should add one more a description to https://laravel.com/docs/8.x/contributions#which-branch  like this?

Improvements such as fixing docblock, clean up code/tests that do not introduce any behavior changes should be send to the current release (stable) branch.

(just an example)

@seriquynh this falls under "minor" imo.

@driesvints I am sorry! I click accidently the request review button.

@seriquynh no worries 👍


Only include the speechbrain package in setup.py

What does this PR do?
An empty tests package would get shipped both with normal and editable installs (even though the tests package is empty anyway in the .whl for some reason).
This PR stops discovering packages automatically and just specifies the "speechbrain" package alone instead.
Rerunning pip install --editable . is required for the changes to take effect.
Fixes #2491

Before submitting

[x] Did you read the contributor guideline?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified
[ ] Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
[ ] Review the self-review checklist to ensure the code is ready for review

Nevermind, the root-package-only approach does not work with non-editable installs.


@kanaabe => include background check in package json

Maybe related to https://github.com/artsy/force/pull/346, we're generally finding that these checked-in dependencies are problematic with babel.

Nice! Thanks.


ERROR 404 trying to load the translations in Angular 6 and NS 4.2

Sorry to reopen this, I'm using angular 6 and I have this issue, this is the output error, also if I change the json files url to something like './json/ I receive a no protocol error.
"@ngx-translate/core": "^10.0.2",
    "@ngx-translate/http-loader": "^3.0.1",

JS:   "name": "HttpErrorResponse",
JS:   "message": "Http failure response for (unknown url): 0 Unknown Error",
JS:   "error": {
JS:     "originalStack": "Error: java.net.MalformedURLException: no protocol: ./i18n/pt.json\n

Successfully synced application com.domain.mob on device emulator-5554.
JS: Angular is running in the development mode. Call enableProdMode() to enable the production mode.
JS: ERROR {
JS:   "headers": {
JS:     "normalizedNames": {},
JS:     "lazyUpdate": null,
JS:     "headers": {}
JS:   },
JS:   "status": 404,
JS:   "statusText": "ERROR",
JS:   "url": "/data/data/com.domain.mob/files/app/i18n/pt.json",
JS:   "ok": false,
JS:   "name": "HttpErrorResponse",
JS:   "message": "Http failure response for /data/data/com.domain.mob/files/app/i18n/pt.json: 404 ERROR",
JS:   "error": "Not Found"
JS: }
JS: ERROR {
JS:   "headers": {
JS:     "normalizedNames": {},
JS:     "lazyUpdate": null,
JS:     "headers": {}
JS:   },
JS:   "status": 404,
JS:   "statusText": "ERROR",
JS:   "url": "/data/data/com.domain.mob/files/app/i18n/pt.json",
JS:   "ok": false,
JS:   "name": "HttpErrorResponse",
JS:   "message": "Http failure response for /data/data/com.domain.mob/files/app/i18n/pt.json: 404 ERROR",
JS:   "error": "Not Found"
JS: }

My NS project doesn't have the structure sugested to place something in assets, I don't have that folder and If I place my json files in /app/i18n I get this error, or in /i18n/ I also got this error, my NS version is 4.2 and rxjs is also 6
this is my app.module.ts
import { NgModule, NgModuleFactoryLoader, NO_ERRORS_SCHEMA } from "@angular/core";
import {BrowserModule} from '@angular/platform-browser';
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
import { NativeScriptUISideDrawerModule } from "nativescript-ui-sidedrawer/angular";
import { NativeScriptHttpClientModule } from "nativescript-angular/http-client";
import { NativeScriptFormsModule } from "nativescript-angular/forms";
import { HttpClientModule, HttpClient, HTTP_INTERCEPTORS } from "@angular/common/http";
import { AuthenticationInterceptor } from "./shared/interceptors/authentication.interceptor";
import {TranslateModule, TranslateLoader} from '@ngx-translate/core';
import {TranslateHttpLoader} from '@ngx-translate/http-loader';

import { AppRoutingModule } from "./app-routing.module";
import { AppComponent } from "./app.component";

import { LoginComponent } from "./login/login.component";
import { MenuComponent } from "./menu/menu.component";

import { UtilsService } from "~/shared/services/utils.service";
import { APIService } from "~/core/api.service";
import { Configuration } from "~/core/configuration";
// AoT requires an exported function for factories
export function HttpLoaderFactory(http: HttpClient) {
    return new TranslateHttpLoader(http, "/i18n/", ".json");
}
// Maps
@NgModule({
    bootstrap: [
        AppComponent
    ],
    imports: [
        AppRoutingModule,
        BrowserModule,
        HttpClientModule,
        NativeScriptModule,
        NativeScriptFormsModule,
        NativeScriptUISideDrawerModule,
        NativeScriptHttpClientModule,
        TranslateModule.forRoot({
            loader: {
                provide: TranslateLoader,
                useFactory: HttpLoaderFactory,
                deps: [HttpClient]
            }
        })
    ],
    declarations: [
        AppComponent, LoginComponent, MenuComponent
    ],
    schemas: [
        NO_ERRORS_SCHEMA
    ],
    providers: [UtilsService, Configuration, APIService, {
        provide: HTTP_INTERCEPTORS,
        useClass: AuthenticationInterceptor,
        multi: true
    }]
})
export class AppModule { }

I'm a desperate man!!
this is my tsconfig.json file:
{
    "compilerOptions": {
        "module": "commonjs",
        "target": "es5",
        "experimentalDecorators": true,
        "emitDecoratorMetadata": true,
        "noEmitHelpers": true,
        "noEmitOnError": true,
        "lib": [
            "es6",
            "dom",
            "es2015.iterable"
        ],
        "baseUrl": ".",
        "paths": {
            "~/*": [
                "app/*"
            ],
            "*": [
                "./node_modules/tns-core-modules/*",
                "./node_modules/*"
            ]
        }
    },
    "exclude": [
        "node_modules",
        "platforms"
    ]
}

Simple solution, webpack copy:
new CopyWebpackPlugin([
                {
                    from: 'app/i18n',
                    to: `${dist}/i18n`,
                    context: projectRoot
                },
            ]),

@hackerunet did it work after tns build with --bundle --env.uglify --env.aot . Mine is not working for android (i did not test on IOS), the text printed out in the UI is the variables instead of the value of the variables as defined in the json.

@weijyewang same here..

I got it working following this inputs:
https://discourse.nativescript.org/t/ngx-translate-nativescript-angular-application/4096/7

This really worked for me. This is how we can keep our json files in customize path as follows-
return new TranslateHttpLoader(http, "src/_ui/custom/my-app/dist/assets/i18n/",  ".json");
And in angular.json file we can ask compiler to check assets for our custom path as well-
"assets": [
"src/favicon.ico",
"src/assets",
"src/_ui/custom/my-app/dist/assets"
],
Thanks Bro **Alessandro Santamaria ** and hackerunet for sharing.

This really worked for me. This is how we can keep our json files in customize path as follows-
return new TranslateHttpLoader(http, "src/_ui/custom/my-app/dist/assets/i18n/", ".json");
And in angular.json file we can ask compiler to check assets for our custom path as well-
"assets": [
"src/favicon.ico",
"src/assets",
"src/_ui/custom/my-app/dist/assets"
],
Thanks Bro Alessandro Santamaria and hackerunet for sharing.
Thank You @anmolkrai , Your solution worked for me : -

With your solution I added my asset pathj to angular.json
Like this:

Now Working absolutely fine. Thanks..
~ Cheers

I am using Angular 13 and getting the same error mentioned by @hackerunet. When I was using Nativescript 6 it worked fine but when I migrated my project to Nativescript 8 I got this error. I don't have an asset folder in my project, the i18n folder is placed inside "app" folder. Also, in NS8 the webpack 5 is used so I had to add this:
webpack.Utils.addCopyRule(
{
from:'src/app/i18n',
to : 'C:/Users/gkadam/Documents/myproject/src/app/i18n',
context : projectRoot
}
)
Am I missing anything?

@gayatri-kadam :
add translation file en.json or any other languge translation file in
app/assets/i18n
webpack.config.js
add following :
webpack.Utils.addCopyRule("assets/i18n/*");
set Default language in App.component.ts :
this.translate.setDefaultLang("en");
you can iniatialize Translate loader in App.module.ts
`// for AoT compilation
export function translateLoaderFactory(http: HttpClient) {
return new TranslateHttpLoader(http, "/assets/i18n/", ".json");
}
imports: [
TranslateModule.forRoot({
loader: {
provide: TranslateLoader,
useFactory: (translateLoaderFactory),
deps: [HttpClient]
}
})]
`
ns clean and rerun the project.


Add ability to use local fonts

There are some extensions with this kind of features like "Font Changer with Google Web Fonts™" which allows to upload .ttf files and use them, but those extensions change the font-family for entire page and cause error for sites that are using fonts like font-awesome for their images.
Please integrate this feature in Stylebot so we can use local fonts for specific elements.

You can achieve the same results by installing SkyFonts on your computer, using it to install your favorite fonts from Google Fonts, and then referring to them in your Stylebot CSS.
An added bonus is that SkyFonts only needs to run when adding or removing fonts.


Run Hardship and Means Assessment validations via WorkflowPreProcessorService

This PR updates the Hardship and Means Assessment workflows to use the WorkflowPreProcessorService for validating incoming requests, specifically to ensure that the application status and timestamp are valid, as well as to ensure that the user is authorised for the action that they're attempting to perform.
This validation is only triggered from the Hardship and Means Assessment workflows when the MaatPostAssessmentProcessing feature flag has been enabled and additionally, in the case of Means Assessment workflows, only when the Crown Court Contribution Service has been enabled.
The FeatureDecisionService has been refactored as part of this PR to consolidate common logic and the tests have been parameterised to try and ensure that duplication does not become an issue as the number of methods for checking various features increase.
This PR has not refactored the WorkflowPreProcessorService to consolidate Rep Order retrieval into a single method, as described in the story. The reason for this is that currently, only two services (hardship orchestration and means assessment orchestration) are calling the preprocessor; between them, one of the services is using the retrieved Rep Order elsewhere in, so a call to refactor retrieval of it in the preprocessor wouldn't remove the call to retrieve it elsewhere. The Rep Order is also used to calculate the appropriate UserActionDTO (in the respective calling services), which we would otherwise need to refactor for in the preprocessor. Overall, it feels like slight premature optimisation to refactor at this stage but I'm happy to hear the thoughts of others.
Note: will fix-up commits once folks are happy with the substantive changes.
Link to story

I agree with the plan to consolidate RepOrder — that’s something we can address later on.
Regarding the HardshipOrchestrationService, I see we’re passing RepOrder to the ATS to retrieve assessor names, but this doesn’t seem necessary since the ATS can already fetch that information independently. More importantly, I’m not sure we even need to track assessor names—it's unlikely this information is displayed in the UI for Crime Apply or eForms. This seems like a legacy holdover that warrants further consideration before making changes.

Thanks for the comments. Let me get back to you on what you describe about assessor names as this isn't something I've touched as part of this PR (to my knowledge).


[FLINK-28004][ci] Reduce heap memory consumption by 25%

The goal is to have a larger memory buffer for docker to work with. I've recently quite a few cases of docker itself crashing, which I hope to fix with this change.

The PR looks reasonable to me, but what do you think about the CI failure?

I don't think it is related; another instance of FLINK-28076.
@flinkbot run azure