Solution pushed and deployed, but modules Not Running on Device.

Hi,
I created the manifest and pushed the solution with both modules (classifier and cameracapture) to the container registry (I can see them listed on the repositories). Then I created the deployment for single device (a Microsoft Azure IoT Starter Kit camera) but I can't see them on the device if I check on VS Code explorer, and if I check on Azure portal, I can see the modules listed (along with the two custom modules installed origanilly with the camera) but they are not running.
Am I missing something to make the classifier module run in the camera?
Cheers,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d10bd923-e9e2-3958-a9b9-1baac169b308
Version Independent ID: f78bdb47-e841-b612-6964-9a6f1fce293f
Content: Tutorial - Deploy Custom Vision classifier to a device using Azure IoT Edge
Content Source: articles/iot-edge/tutorial-deploy-custom-vision.md
Service: iot-edge
GitHub Login: @kgremban
Microsoft Alias: kgremban

I'm including an image of how the modules look on the IoT Edge Device...

Thank you for your feedback @yguipsot .
This tutorial was tested and working if you fulfill the prerequisite "Linux device running Azure IoT Edge"
Since you are running Azure IoT Starter Kit camera as your edge device, I would like to move this discussion to a different forum so others facing similar issues can help as well.
Can you confirm that this is the camera you are using? https://azure.github.io/Vision-AI-DevKit-Pages/
Thanks

Thanks @asergaz
Yes, that is the camera that I am using. As soon as I got this device I ran the OOBE and it registered it as an IoT Edge Device including the four modules that it usually includes ($edgeAgent, $edgeHub, AIVisionDevKitGetStartedModule and WebStreamModule). I created a project on customvision.ai (the HardHat Detector) running a quick training and exporting to Vision AI Dev Kit, then I set the exported model into the AIVisionDevKitGetStartedModule and it worked on the camera.
Lastly, I created another project on customvision.ai running an advanced training and exporting to Dockerfile, I followed the "Tutorial - Deploy Custom Vision classifier to a device using Azure IoT Edge" including the prerequisite "Develop IoT Edge modules for Linux devices" but as I explain on my first message, the new modules (specially the "classifier" that is the one containing the model from customvision.ai) are not running and I don't know if this is becaus I should have done things on a different way since I already had created the IoT Edge Device previously.
Can you direct me to this different forum that you mention so I can get some help?
Thanks again,

Hi @yguipsot and happy new year!
Did a quick search under "Vision AI Developer Kit - Get Help" and found the tutorial to help you get started : "Create and Deploy a Custom Vision AI Module Using Azure Custom Vision Service and Azure IoT Edge". If that is not what you were looking for please leverage the other resources to get help on the right.

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
Happy coding ;)!

Hi @yguipsot and happy new year!
Did a quick search under "Vision AI Developer Kit - Get Help" and found the tutorial you followed initially: "Create and Deploy a Custom Vision AI Module Using Azure Custom Vision Service and Azure IoT Edge" . If you notice "in the right" there are other resources to get help (Gitter has many active users helping there) - you can point there that you started the discussion here

My experience on using Azure IoT Edge tells me that you may be having issues with starting the new containers created due to issues that can be related with permissions, network, proxy... (as described here). The best first step is to start by check container logs for issues, though as I don't have that camera with me I don't know the exact steps to do it.
Again, please understand that this doc targets  "Linux device running Azure IoT Edge" prerequisite. Therefore we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
All Best


feat: swaps out execa for nanoexec

swaps out execa for nanoexec to reduce deps tree as asked for in this tweet https://x.com/awkweb/status/1866200894078918744

Appreciate this! Decided to drop third-party packages entirely for this purpose https://github.com/wevm/wagmi/pull/4457


Add middleware.Multiple to all multiple http methods

Sometimes you want a handler to allow both GET and HEAD methods etc.
func Multiple(meths []string{}){
}

// AnyOf is a middleware that only allows any of the http methods listed in method and http OPTIONS requests.
//
// See the package documentation for the additional functionality provided by this middleware.
func AnyOf(wrappedHandler http.Handler, o Opts, methods []string) http.HandlerFunc {
	return allDefaultMiddlewares(
		anyOf(wrappedHandler, methods),
		o,
	)
}

func anyOf(wrappedHandler http.Handler, methods []string) http.HandlerFunc {
	if len(methods) <= 0 {
		methods = []string{http.MethodHead}
	}
	allowed := strings.Join(methods, ",")

	msg := "http method: %s not allowed. only allows http %s"
	return func(w http.ResponseWriter, r *http.Request) {
		// We do not need to allow `http.MethodOptions` here.
		// This is coz, the cors middleware has already handled that for us and it comes before the Get middleware.
		if !slices.Contains(methods, r.Method) {
			errMsg := fmt.Sprintf(msg, r.Method, allowed)
			w.Header().Set(ongMiddlewareErrorHeader, errMsg)
			http.Error(
				w,
				errMsg,
				http.StatusMethodNotAllowed,
			)
			return
		}

		wrappedHandler.ServeHTTP(w, r)
	}
}

Alternatively, people can use the middleware.All and reject any methods that don't want themselves.

The implementation https://github.com/komuw/ong/pull/279 does not pull its own weight.


hide the "Drag to Change Order" text if roworderdragging is disabled

If $config['system']['webgui']['roworderdragging'] is true, then dragging to reorder firewall rules is disabled. This simple change hides the header text saying that you can drag, if in fact, you cannot.

[ ] Redmine Issue: not needed?
[x] Ready for review

Patch doesn't work, as I immediately suspected "print" inside "gettext" will let the string be printer instead of processed for translation. Moreover when the option is enabled the order of the strings is  reversed and misunderstood.
Spanish, original:
Reglas (arrastrar para cambiar el orden)
Patched Spanish, original:

(Drag to Change Order)Rules1

I did not create the roworderdragging flag so I wasn't the one who named it. I agree it's "backwards" and should be named disable_row_dragging or something like that. But, I didn't want to change it since it was already in use elsewhere.
Not quite sure how to fix the translation issue, I would have thought the inner text would have been executed first and then the entire string evaluated by gettext() but I guess that's not how it works? Will try another method...

I changed my language to Spanish just to test this. I see that even on the General config page, there are translations missing there. I am not too familiar with adding translations, but if someone can point me in the right direction I can try to help. Is Zanata still the right method?

@NanoCaiordo can you try this now? I just pushed an update that should work.

@NanoCaiordo I have a new unified commit if you want to try, since I imagine it was a pain with the previous being split over 2 commits
try: fd4dc22e73a43c644e8972923c98abb86a27889c

closing this one and replacing with the squashed PR: https://github.com/pfsense/pfsense/pull/3990


Convert Animated classes to TypeScript

This pull request introduces 1 alert when merging 4f977f6a9fc0bdcbc93969baee31f0afedfaae8e into 0be1eebd9abfed1bb8351903c9738a328034482b - view on LGTM.com
new alerts:

1 for Useless assignment to property

Comment posted by LGTM.com


undefined is not an object (evaluating'(0,_reactNative.connect)(function(state){return{nav:state.nav};})')

Is this a bug report?
No

Have you read the Contributing Guidelines?
Yes
Environment

react-native -v:
react-native-cli: 2.0.1
react-native:0.47.2
node -v: v8.2.1
npm -v: 4.6.1
yarn --version:

Then, specify:

Target Platform: Andriod

Development Operating System: windows 7 ultimate version 6.1

Build tools: Expo

Code:
import React, {Component} from 'react'
import {Provider, connect} from 'react-native'
import {StackNavigator, addNavigationHelpers} from 'react-navigation'
import Routes from './config/routes'
import getStore from './store'
const Navigator = StackNavigator(Routes, {
headerMode: 'none'
})
const navReducer = (state, action) => {
const newState = Navigator.router.getStateForAction(action, state)
return newState || state
}
class App extends Component {
render(){
return(
<Navigator
navigation={addNavigationHelpers({
dispatch: this.props.dispatch,
state: this.props.nav
})}
/>
)
}
}
const store = getStore(navReducer)
const AppIndex = connect( state => ({ nav: state.nav }) )(App)
export default Index = () => {
return (
<Provider store={store}>
<AppIndex />
</Provider>
)
}

@facebook-github-bot stack-overflow


Sharing credentials between provisions of service instances

Feature:
UseCase
I have an Operator that will deploy a number of service instances from a namespace broker into a privileged namespace based on a custom resource. These services are intended to be shared and consumed by users of the cluster. Once provisioned, I want to tell the broker to use a  secret that contains the credentials and coordinates of a shared service with each subsequent provisions of that APB so that subsequent provisions can interact with the shared service without the need for the requesting user to know the credentials or coordinates of that service.
Currently, if you have perms, you can create a secret in the brokers namespace and have them mounted into a specific APB container using the broker-config https://github.com/openshift/ansible-service-broker/blob/master/docs/config.md#secrets-configuration
It would be useful to be able to define these secrets dynamically.

It would stop the need to redeploy the broker to pick up new secrets
It would mean you would not need to know all the details ahead of time.

Initial concerns

As the secret could change / be updated (for instance as one shared service became full and a new one was provisioned) , the broker will need to copy this credential for each provision or keep track of which service instances received which secret so that during a deprovision the APB would receive the correct values to interact with the same service again.

@eriknelson  @jmrodri  any thoughts on the concern of tracking which credential were given to which service instance.

/close


Static Sounds/Images. Don't delete this card it contains an important file

Static Sounds/Images
If there is a need to have a sound that is used only in the template but is not attached to any field of the note, then you need to set the correct name.
1-second-and-500-milliseconds-of-silence.mp3
_1-second-and-500-milliseconds-of-silence.mp3

thanks I added the change


add kubectl binary

Description of changes:
This is a tiny change to add kubectl binary as described in https://github.com/awslabs/amazon-eks-ami/issues/1557.

/ci


Adds ranker interface, remove normalized from Scorer and throws exception on non ERC721

RarityRanker to rank tokens
Scorer: Removal of normalized from scorer +handler interface, but set as a "config"/param for specific handlers that use that as a param in the init
Scorer: Throws exception for non ERC721

I realized I pushed the response to @theelderbeever 's comments in another branch lol :(
https://github.com/OpenRarity/open-rarity/pull/40


Support mulitline stringData secret

Details
What steps did you take and what happened:
Inject a x509 certificate as stringData for a secret. I tried multiple yaml formatters but failed (| or |-)
secrets:
  secret:
    enabled: true
    stringData: |-
      aldfaldflaf
      adfadfadf

What did you expect to happen:
That the secret just has a literal block with
stringData: |-
    aldfaldflaf
    adfadfadf

but instead it is rendered as
stringData:
  |-
    aldfaldflaf
    adfadfadf

Anything else you would like to add:
Additional Information:

Thanks for the bug report! I'll look in to it and see about fixing it

I took some time to look at this, and this isn't actually a bug... Kubernetes expects key-value pairs for the stringData field so the correct syntax for stringData would be this:
secrets:
  secret:
    enabled: true
    stringData:
      secret.crt: |-
        aldfaldflaf
        adfadfadf


local kernel and local python for web should not be available on Web

We always contribute local kernel spec and python env source on Web when using the new MRU kernel picker. These two sources will be empty as we don't have kernel finders for them on Web. Ideally they should be guard behind "isWeb".

Fixed in release branch.

I verified it here as @DonJayamanne did the fix.


Replace National Historic Trail shields with triangular color swatches

For compliance reasons, the shields introduced in #1115, #1116, and #1117 have been replaced with simple color swatches. Each color swatch is in the shape of a Reuleaux triangle, a shape that is common to many recreational trails, including U.S. Bicycle Routes. The colors continue to correspond to the primary color associated with each trail.

I'm afraid using plain shields for NHTs would be too confusing. A few of the NHTs are overlapping, so users would need to refer to a legend and be able to distinguish between similar colors to tell which is which. I suggest either making our own designs or removing these entirely until we figure out if we can use the official emblems.

These shields do appear in the legend, and I’ve seen maps that take the same approach to simplifying the shields. But if the concern is about potential color conflicts or colorblindness issues, I suppose we could stick a monogram inside each shield.

Yeah, I guess a solid color is better than nothing for now :)


Cleanup

Hi, Whenever I open a file from in project to read the code, the whole file becomes yellow (with warnings), the code is not pep8-compliant, and it really looks ugly.
You should really follow the style guide, this makes it a lot easier for possible contributors.
One more thing, The code contains a lot of unused imports and from foo import *, although this is valid code it makes the code difficult to reason about and it adds to the startup time.
maybe you should set-up a linter and a formatter for the project.
I have a WIP for this if you agree.

This project is a pretty rough work in progress and there is a lot more confusing and inconsistent things than formatting that need to be fixed before people can realistically contribute.
I don't think it really makes sense to put a diff on pretty much every single line to change spaces to tabs. It's why I put in the [pycodestyle] section ignoring most of the tab rules for people using it.

Okay then.


Assimp GetMaterialString binding can cause AccessViolationException

Summary
For certain overload of the Assimp.GetMaterialString, there is a code that copies managed string to global memory and passes the pointer to native method. However when it returns, it attempts to convert to string (SilkMarshal.PtrToString) which is useless since the resulting string is not use anywhere.
The aforementioned PtrToString (or rather Utf8PtrToString used for the used LPUTF8Str encoding) then can cause AccessViolationException because the way it is implemented is it scans for null-terminator in Span<byte>(ptr, int.MaxValue) which can use vectorization instructions and "look ahead". However when the pointer is near the edge of accessible memory, this can fail.
So technically there are two issues: unnecessary pointer to string conversion, and Access Violation risk when using Utf8PtrToString
Steps to reproduce

Platform: Desktop
Framework Version: .NET 8
Tested Nuget Versions: 2.13.0, 2.20.0

I wasn't able to create easy repro, but the bug was encountered after using Silk.NET.Assimp like this:
string GetMaterialName(Material* material)
{
    AssimpString materialName = new AssimpString();
    _assimp.GetMaterialString(material, Assimp.MaterialNameBase, 0, 0, ref materialName);
...

Fatal error. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
    at System.SpanHelpers.NonPackedIndexOfValueType[[System.Byte, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.SpanHelpers+DontNegate`1[[System.Byte, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](Byte ByRef, Byte, Int32)
    at System.MemoryExtensions.IndexOf[[System.Byte, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.Span`1<Byte>, Byte)
    at Silk.NET.Core.Native.SilkMarshal.Utf8PtrToString(IntPtr)
    at Silk.NET.Core.Native.SilkMarshal.PtrToString(IntPtr, Silk.NET.Core.Native.NativeStringEncoding)
    at Silk.NET.Assimp.Assimp.GetMaterialString(Silk.NET.Assimp.Material*, System.String, UInt32, UInt32, Silk.NET.Assimp.AssimpString ByRef)

Comments
In the following image, the highlighted code shouldn't be necessary at all.

Thanks, I've changed the codegen to no longer have this pointless reassignment (below is .NET Standard 2.0 code hence the StCall):

        public unsafe partial global::Silk.NET.Assimp.Return GetMaterialProperty(global::Silk.NET.Assimp.Material* pMat, string pKey, uint type, uint index, global::Silk.NET.Assimp.MaterialProperty** pPropOut)
        {
            global::Silk.NET.Assimp.Return n6;
            byte* n5;
            global::Silk.NET.Assimp.Return StCall(global::Silk.NET.Assimp.Material* arg0, byte* arg1, uint arg2, uint arg3, global::Silk.NET.Assimp.MaterialProperty** arg4)
            {
                if (Silk.NET.Core.Native.SilkMarshal.IsWinapiStdcall)
                {
                    return ((delegate* unmanaged[Stdcall]<global::Silk.NET.Assimp.Material*, byte*, uint, uint, global::Silk.NET.Assimp.MaterialProperty**, global::Silk.NET.Assimp.Return> )(CurrentVTable as _B)._DM)(arg0, arg1, arg2, arg3, arg4);
                }
                else
                {
                    return ((delegate* unmanaged[Cdecl]<global::Silk.NET.Assimp.Material*, byte*, uint, uint, global::Silk.NET.Assimp.MaterialProperty**, global::Silk.NET.Assimp.Return> )(CurrentVTable as _B)._DM)(arg0, arg1, arg2, arg3, arg4);
                }
            };
            n5 = (byte*)Silk.NET.Core.Native.SilkMarshal.StringToPtr((pKey), (Silk.NET.Core.Native.NativeStringEncoding)48);
            n6 = StCall((pMat), (n5), (type), (index), (pPropOut));
            Silk.NET.Core.Native.SilkMarshal.FreeString((global::System.IntPtr)n5, (Silk.NET.Core.Native.NativeStringEncoding)48);
            return n6;
        }

And I've also fixed the bug you uncovered in PtrToString on .NET 8.
These will be released in 2.21
Fixed in #1990


Bump lint-staged to v12

Change-type: patch
Signed-off-by: Josh Bowling<EMAIL_ADDRESS>

@balena-ci I self certify!


Zombie GCP Filestore Backups

Description

During extensive manual tests, I noticed that sometimes multiple backups are getting created for the same CR. The root cause was that, the status was not getting updated because of an error, and therefore in the next reconciler loop, backup was getting attempted again.
As we don't have a reference to these backups, they remain there  and won't get cleaned up and cause additional cost without being used.
In addition, if this can happen once, can happen multiple times and eventually we will end up with many unused resources.
And this can happen to all other resources that solely rely on the id of the resource getting updated on the status
Expected result

I expect only one backup resource to get created.
Actual result

Two backups were created on the GCP where only the later one (by few seconds) was referenced by the GcpNfsVolumeBackup CR.
Steps to reproduce

Manually running a test again and again. Please note that this was discovered during one of my manual tests, and could be related to the test conditions I had. But theoretically it can happen as long as we have one line that requests the backup creation and another one that updates the status with its id, which is the only way to reference it from cloud-manager.
Troubleshooting

I can think of two way to solve this:

update the id on the status before hand and use it to create the backup. This way if we already created the backup, the next attempt will error out by saying object already exists.
Add labels to the backup that can be used to find the backup if already exist before attempting to create it.

Setting .status.id first, and then using it for name resolution, is how we implemented other resources.
I am voting for the first option.


Add Solution to 4

Fixes #{Insert your issue number here}

My code sample is in :

[x] CPP
[ ] Java

Screenshot of working code sample  :

Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My code sample is formatted and works correctly

Add issue number in issue comment

#4


Error starting docker compose

=> ERROR [frontend 7/7] RUN pnpm run build                                                                                9.7s
------
 > [frontend 7/7] RUN pnpm run build:
0.201 ! The local project doesn't define a 'packageManager' field. Corepack will now add one referencing<EMAIL_ADDRESS>0.201 ! For more details about this field, consult the documentation at https://nodejs.org/api/packages.html#packagemanager
0.201
0.478
0.478 ><EMAIL_ADDRESS>build /app
0.478 > next build
0.478
1.010 Attention: Next.js now collects completely anonymous telemetry regarding usage.
1.011 This information is used to shape Next.js' roadmap and prioritize features.
1.011 You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
1.011 https://nextjs.org/telemetry
1.011
1.060   ▲ Next.js 14.2.3
1.060   - Environments: .env.production
1.060
1.110    Creating an optimized production build ...
9.509 <w> [webpack.cache.PackFileCacheStrategy] Caching failed for pack: Error: ENOSPC: no space left on device, write
9.549 uncaughtException [Error: ENOSPC: no space left on device, write] {
9.549   errno: -28,
9.549   code: 'ENOSPC',
9.549   syscall: 'write'
9.549 }
9.555  ELIFECYCLE  Command failed with exit code 1.
------
failed to solve: process "/bin/sh -c pnpm run build" did not complete successfully: exit code: 1

Do you know when it's going to be resolved yet?


HADOOP-18082.Add debug log when RPC#Reader gets a Call.

Description of PR
Log some information from the moment Call enters the RPC inside, which will help us understand more about Call.
The records here should be in the form of logs. The priority of the logs should not be too high, and debugging is the best.
Details: HADOOP-18082
How was this patch tested?
Corresponding to the test, the pressure is not large.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 16s

trunk passed

+1 :green_heart:
compile
22m 54s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 24s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 41s

trunk passed

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 26s

trunk passed

+1 :green_heart:
shadedclient
22m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 59s

the patch passed

+1 :green_heart:
compile
21m 30s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
21m 30s

the patch passed

+1 :green_heart:
compile
19m 30s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
19m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  8s

the patch passed

+1 :green_heart:
mvnsite
1m 40s

the patch passed

+1 :green_heart:
javadoc
1m 12s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 46s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 35s

the patch passed

+1 :green_heart:
shadedclient
21m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
28m  6s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

208m 25s

Reason
Tests

Failed junit tests
hadoop.ipc.TestIPC

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3891/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3891

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux f3b632853b25 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d3cc51309188487a173b84212a5fa3be9c08acd2

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3891/1/testReport/

Max. process+thread count
1267 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3891/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Here are some failed unit tests:
org.apache.hadoop.ipc.TestIPC
It doesn't look like it has much to do with what I'm submitting.
Would you like to help review this PR, @jojochuang  @virajjasani  @tomscut .
Thank you so much.

Thanks @tomscut .

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 23s

trunk passed

+1 :green_heart:
compile
22m 15s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 25s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 37s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 28s

trunk passed

+1 :green_heart:
shadedclient
22m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 58s

the patch passed

+1 :green_heart:
compile
21m 28s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
21m 28s

the patch passed

+1 :green_heart:
compile
19m 29s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
19m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  7s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 1 new + 166 unchanged - 0 fixed = 167 total (was 166)

+1 :green_heart:
mvnsite
1m 35s

the patch passed

+1 :green_heart:
javadoc
1m 10s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 43s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 35s

the patch passed

+1 :green_heart:
shadedclient
22m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
28m  2s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  0s

The patch does not generate ASF License warnings.

212m 43s

Reason
Tests

Failed junit tests
hadoop.ipc.TestIPC

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3891/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3891

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 17239c87beb5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 05f7c9e709329f2d928fbe57dcff35d324e6d9db

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3891/2/testReport/

Max. process+thread count
3160 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3891/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 44s

trunk passed

+1 :green_heart:
compile
24m  7s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
20m 43s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 35s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 28s

trunk passed

+1 :green_heart:
shadedclient
24m 51s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  4s

the patch passed

+1 :green_heart:
compile
23m 39s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
23m 39s

the patch passed

+1 :green_heart:
compile
21m 58s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  0s

the patch passed

+1 :green_heart:
mvnsite
1m 42s

the patch passed

+1 :green_heart:
javadoc
1m  9s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 46s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 58s

the patch passed

+1 :green_heart:
shadedclient
25m 54s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
24m 18s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

219m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3891/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3891

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 789312d80f47 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8554c43fe76773fa73414197e52fb5895126063e

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3891/3/testReport/

Max. process+thread count
2950 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3891/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Latest change looks good. +1(non-binding)

Thanks @virajjasani .

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 43s

trunk passed

+1 :green_heart:
compile
26m  0s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
22m 32s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 38s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 33s

trunk passed

+1 :green_heart:
shadedclient
25m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  3s

the patch passed

+1 :green_heart:
compile
24m 27s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
24m 27s

the patch passed

+1 :green_heart:
compile
21m 34s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 59s

the patch passed

+1 :green_heart:
mvnsite
1m 34s

the patch passed

+1 :green_heart:
javadoc
1m  6s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 38s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 43s

the patch passed

+1 :green_heart:
shadedclient
26m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
30m 33s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

232m 27s

Reason
Tests

Failed junit tests
hadoop.ipc.TestIPC

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3891/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3891

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux f0ccc6a61077 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8554c43fe76773fa73414197e52fb5895126063e

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3891/4/testReport/

Max. process+thread count
1246 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3891/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @ayushtkn .

Hi @ayushtkn , can this pr be merged into trunk branch or other main branch?
If not for now, I will continue to work hard.
Thank you very much.

Merged. Thanx Everyone!!!


Salsa preview doesn't seem to work

Setting export VSCODE_TSJS=1 in my .bash_profile and updating my project to use the latest Typescript@next doesn't work. I've noticed that sometimes I see the (Salsa) indicator show up very briefly when starting up the editor, but it disappears right away.

Do you install TypeScript@next locally or globally? Maybe Salsa will work after setting typescript.tsdk.

I install TypeScript globally.
VSCode Docs

Thanks @meritozh
Some additional things to observe:

The Salsa indicator shows up only when a .js file is open in the editor.
When hovering over the Salsa indicator you can see the path to the tsdk that is used. Verify that it is valide and that it is a tsdk > 1.8

Closing as cannot reproduce.

Ah, that was my error, I was expecting it to show for .ts files


Upgrading to  RS 0.36.2

Upgrading to Polars RS 0.36.2 tag

any update?

any update?

PR is done, just waiting to be merged by the maintainer. :)

any update?

PR is done, just waiting to be merged by the maintainer. :)

Ok, thx


ceskatelevize.cz is not working anymore

Checklist

[ x] I'm reporting a broken site support
[x ] I've verified that I'm running youtube-dl version 2021.01.03
[ x] I've checked that all provided URLs are alive and playable in a browser
[ x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x ] I've searched the bugtracker for similar issues including closed ones

Verbose log

ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 803, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 824, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 532, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/ceskatelevize.py", line 201, in _real_extract
    self._sort_formats(e['formats'])
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 1367, in _sort_formats
    raise ExtractorError('No video formats found')
ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

WRITE DESCRIPTION HERE
Download stopped working, I was able to download from the site approx. 2 weeks before.
https://www.ceskatelevize.cz/porady/11346647457-bozena/218512120070001/
This link doesn't work.

Hmm, the error is passing here:
https://github.com/ytdl-org/youtube-dl/blob/430c4bc9d02b49e180309dc55c62b96d5cada535/youtube_dl/extractor/ceskatelevize.py#L201
But i'm wondering that youtube-dl uses the CeskaTelevizeIE-Class
https://github.com/ytdl-org/youtube-dl/blob/430c4bc9d02b49e180309dc55c62b96d5cada535/youtube_dl/extractor/ceskatelevize.py#L22-L23
instead of the CeskaTelevizePoradyIE Class which maybe works:
https://github.com/ytdl-org/youtube-dl/blob/430c4bc9d02b49e180309dc55c62b96d5cada535/youtube_dl/extractor/ceskatelevize.py#L241-L242

Hmm, the error is passing here:
https://github.com/ytdl-org/youtube-dl/blob/430c4bc9d02b49e180309dc55c62b96d5cada535/youtube_dl/extractor/ceskatelevize.py#L201
But i'm wondering that youtube-dl uses the CeskaTelevizeIE-Class
https://github.com/ytdl-org/youtube-dl/blob/430c4bc9d02b49e180309dc55c62b96d5cada535/youtube_dl/extractor/ceskatelevize.py#L22-L23
instead of the CeskaTelevizePoradyIE Class which maybe works:
https://github.com/ytdl-org/youtube-dl/blob/430c4bc9d02b49e180309dc55c62b96d5cada535/youtube_dl/extractor/ceskatelevize.py#L241-L242


Release 3.0.0 cannot be build from Carthage

Dependency "Smile-Lock" has no shared framework schemes

If you use Carthage, please try version 2.0.1

2.0.1 works


Implement PlayerSpawnLocationEvent

Really hacky solution :(

I have some idea for it. Can I do it or do you want change something?

Sure, give it a try

@Paulomart https://github.com/GlowstonePlusPlus/GlowstonePlusPlus/tree/event/locationspawn could you test it? Today i don't have enought time :/

Preferring this pull because it's good to be dirty (sometimes).


ground true cIRM and est cIRM not pair

great job!
But I found that when training the cIRM will using drop_band=2, but the validating will not using drop_band? why?and how to fix this problem?

This drop_band is a continuation of the strategy in FullSubNet: during training, we can drop some subbands in order to reduce the computational and memory pressure on the GPU, which does not affect the performance of the final model too much.  At inference,  to get the complete speech， we do not use the drop_band strategy.
If you want to train without the drop_band strategy, just set num_groups_in_drop_band to 1.

Thanks for you reply! I had already reproduced your work, the result on validating dataset is really impressive. And I try my best to download the test dataset(noreverb/reverb) from official website of DNS challenge but it doesn't work, so could you please offer me the test data. Thank you so much.

Could you offer me your email? I will send the test dataset to you through the email.

ok, my email is<EMAIL_ADDRESS>Thank you so much!


[Issue 8138][pulsar-client] Improve timeout handling in ClientCnx to cover all remaining request types (GetLastMessageId, GetTopics, GetSchema, GetOrCreateSchema)

Master Issue: #8138
Motivation
Since one of the root causes for #8138 is that there isn't timeout handling for GetLastMessageId requests, this PR adds that.
The PR improves timeout handling in ClientCnx to cover all remaining request types that don't currently have timeout handling. The request types are:
- GetLastMessageId
- GetTopics
- GetSchema
- GetOrCreateSchema
Modifications
The existing requestTimeoutQueue solution to handle "ordinary" command requests has been extended to cover all the requests types.
Verifying this change
This change added tests and can be verified as follows:

Added unit tests in a new test class ClientCnxRequestTimeoutQueueTest to test request timeout handling.

cd pulsar-client; mvn test -Dtest=ClientCnxRequestTimeoutQueueTest

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


raidemulator: Convert Tooltip to typescript

Ran into a new (for me) issue with the custom <template> tag in the emulator's HTML not translating well directly to typescript. Worked around it as best I was able to figure out but there's probably a better way.

This revision feels much better overall to me. Apparently I hadn't run npm install before I started working on this originally, because HTMLTemplateElement does actually exist in Typescript proper.


Provide a drop-in zlib-compatible frontend for zopfli

https://github.com/google/zopfli

While Zopfli is nice, and somebody somewhere might want to do this, zlib-ng will not and cannot integrate zopfli.


Source BioScience - CSV Uploader Onboarding

Sender Info:

Sender:              Source Bioscience in CA
Type of Sender: Commercial Laboratory
Location/s: ???

Standard Tasks / Onboarding Steps:
Initial Interest & Follow Up:
Sender Setup:
- Create OKTA group & OKTA account
- Create Settings for Staging & PROD
Testing
- Prod/Test Internal
- Prod/Test External (if required by the STLT)
Implementation
- Plan & Schedule GO Live
- GO LIVE and Post LIVE Review

Closed this EPIC and all related Issues.  Moved all info to EPIC/Issue #4119.


Feature/project detail view

Changes

added project page
configured approutes and navigation from projects datatable
added test button to create project (links to project form)

this is temporary, as it will be moved to an admin dashbaord

added various Ts types and enums
various presentation components added
moved the Stack component to the components directory (from forms)
added migration for projects to include Domain string attribute (eg. 'Software', 'Electrical', etc.)
added various backend mappings + DTOS

Renders

TODO:

[ ] add create project form
[ ] backend mappings for create form
[ ] basic error handling of the above


simplify code using optional chaining in ZoneWizardLaunchZone view

Description
This PR is related to issue: ui: Simplify code #4956

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[x] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan ui

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_multiplication_x:
(SL-JID-833)

@blueorangutan ui

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5619 (SL-JID-837)


Identify mesages by unique ID instead of content

{
"_id": {
"$oid": "54a813059ecaa3082cbc77b5"
},
"hasPrinted": true,
"submitDate": "3rd January 2015",
"submitter": "Dan Hett",
"message": "Favourite thing about the Cornerhouse? COFFEE!"
}

No longer required.


Keep only external links checks

fixes #908

@veggiemonk @agebhar1
The last two commits contain the following changes:

move tests to subfolder ./tests
remove some not needed code in tests/pull_request.js
add tests/all.js for running tests with GitHub token locally via npm run test
move duplicate methods to helper.js

It would be great if you could give me feedback, especially on the naming of the files.

I'll have a look 😄

Thank you @mash1t and @agebhar1
Nice work 😄


qcow VM more elaborated instructions

In the informative readme, (so as to make it more informative / efficient) Can you please provide a link (or better yet, add your step by step instructions) demonstrating how to run  a qcow vm and which image you used? I’m having trouble running / logging into the VM using ssh so searching for a simpler way and/or something to save time here and concentrate on the ovs traffic part
Much appreciated

I managed, at last
I suggest you mention the virt-manager which simplifies (for instance along with http://archive.ubuntu.com/ubuntu/dists/bionic-updates/main/installer-amd64/20101020ubuntu543.19/images/netboot/) creation of a VM. And now one can continue with the Readme
I do see qemu-kvm instructions in the readme, so will try those as well
Closing issue
qemu-kvm -smp 4 -m 1024M \
    -boot c -cpu host -enable-kvm -nographic \
    -L /root/pc-bios -name VM1_TAP_DEV \
    -hda ./vm1.qcow2 \
    -object memory-backend-file,id=mem,size=1024M,mem-path=/dev/hugepages,share=on \
    -mem-prealloc \
    -numa node,memdev=mem \
    -chardev socket,id=char1,path=/var/lib/docker/volumes/shared/_data/vhost-user-0 \
    -netdev type=vhost-user,id=netdev0,chardev=char1,vhostforce \
    -device virtio-net-pci,mac=00:e8:ca:11:aa:01,netdev=netdev0 \
    -serial telnet::6551,server,nowait &

Can you please provide a link to a "Pre-built VM qcow2 image." per the readme instruction sin the traffic example section>

I think this website may help:
https://www.nongnu.org/pretest/downloads/

I see -name VM1_TAP_DEV on both VM run commands -> is that a typo?

Any Idea why the VMs stop after about 2 minutes?
[root@PT-DT0647 ubuntu1604]# /usr/libexec/qemu-kvm -smp 4 -m 1024M     -boot c -cpu host -enable-kvm -nographic     -L /root/pc-bios -name VM1_TAP_DEV     -hda ./vm1.qcow2     -object memory-backend-file,id=mem,size=1024M,mem-path=/dev/hugepages,share=on     -mem-prealloc     -numa node,memdev=mem     -chardev socket,id=char1,path=/var/lib/docker/volumes/shared/_data/vhost-user-0     -netdev type=vhost-user,id=netdev0,chardev=char1,vhostforce     -device virtio-net-pci,mac=00:e8:ca:11:aa:01,netdev=netdev0     -serial telnet::6551,server,nowait &
[3] 2955665
[root@PT-DT0647 ubuntu1604]# /usr/libexec/qemu-kvm -smp 4 -m 1024M     -boot c -cpu host -enable-kvm -nographic     -L /root/pc-bios -name VM1_TAP_DEV     -hda ./vm2.qcow2     -object memory-backend-file,id=mem,size=1024M,mem-path=/dev/hugepages,share=on     -mem-prealloc     -numa node,memdev=mem     -chardev socket,id=char2,path=/var/lib/docker/volumes/shared/_data/vhost-user-1     -netdev type=vhost-user,id=netdev1,chardev=char2,vhostforce     -device virtio-net-pci,mac=00:e8:ca:11:bb:01,netdev=netdev1     -serial telnet::6552,server,nowait &
[4] 2955671

[3]+  Stopped                 /usr/libexec/qemu-kvm -smp 4 -m 1024M -boot c -cpu host -enable-kvm -nographic -L /root/pc-bios -name VM1_TAP_DEV -hda ./vm1.qcow2 -object memory-backend-file,id=mem,size=1024M,mem-path=/dev/hugepages,share=on -mem-prealloc -numa node,memdev=mem -chardev socket,id=char1,path=/var/lib/docker/volumes/shared/_data/vhost-user-0 -netdev type=vhost-user,id=netdev0,chardev=char1,vhostforce -device virtio-net-pci,mac=00:e8:ca:11:aa:01,netdev=netdev0 -serial telnet::6551,server,nowait
[root@PT-DT0647 ubuntu1604]#

[4]+  Stopped                 /usr/libexec/qemu-kvm -smp 4 -m 1024M -boot c -cpu host -enable-kvm -nographic -L /root/pc-bios -name VM1_TAP_DEV -hda ./vm2.qcow2 -object memory-backend-file,id=mem,size=1024M,mem-path=/dev/hugepages,share=on -mem-prealloc -numa node,memdev=mem -chardev socket,id=char2,path=/var/lib/docker/volumes/shared/_data/vhost-user-1 -netdev type=vhost-user,id=netdev1,chardev=char2,vhostforce -device virtio-net-pci,mac=00:e8:ca:11:bb:01,netdev=netdev1 -serial telnet::6552,server,nowait
[root@PT-DT0647 ubuntu1604]#
[root@PT-DT0647 ubuntu1604]#

I had also problems getting more then one vm running and I just found out that it is related to the Hugepage setting in the qemu-kvm startup command. The readme is stating tu use mem-path=/dev/hugepages but the hugepage script is defining /mnt/huge 😢 When I changed it to mem-path=/mnt/huge everything worked as expected and now my VM's stay running.....
Hope this helps you too?? If so this need to be changed in the readme....

Take a look here for how I'm able to pull down some Xenial images. There is logic in there to enable a cloud-init ISO as well, which makes it nice.


Clicking on notebooks, after a search, returns to the home page

Repro steps:
Open pub.beakernotebook.com
search for some string that will return notebooks, e.g. "forms"
click a notebook title from the search results
instead of opening the notebook, the pub server will return the user to the homepage. Performing the same steps again will yield the correct results.

fixed in the latest app version


Question: How to send message from server-side?

I have implemented library and both client and server are connected fine. But I am wondering how I can send a message from server side to the client so that client can update HTML view in real time (like notification badge similar to Facebook).
I know we can send message from JS side like:
socket.send(...)
But how can I do the same from server-side ? So once server sends message, client reads it, parses it and updates the HTML view in realtime.
Scenario:

Save a record in database
Trigger socket event (send message from server-side) for the client side
Client side reads message (onmessage) and updates html

I have confusion in second point above.
Maybe Iam not thinking correct in terms of code but hope you get the point of what I am trying to do.
Thanks for the help

I'm not sure that I will have enough knowledge of my English, that would be in an accessible form to describe, but I'll try.
There are several options for behavior:

Dependence on the client, for example, the application "Chat", the initiator is the client and transmits data to his interlocutor.

(The one you are talking about) Depending on the server, for example, warning about the lack of space on the hard drive, then you must send a message using php to the working socket. I use Pawl for such purposes.

You need to define a model and add to it an observer that will send data to the web socket, listen to it and update the data on the page.

@tabuna Thanks for the update. I will look into Pawl. Any example of of how observer will integrate with Pawl will be really helpful if you have implemented somewhere. Otherwise you can close this :)

An example like this is used by me

Socket client facade

namespace App\Facades;

use Config;
use Ratchet\Client;

class SocketClient
{
    /**
     * Get the registered name of the component.
     *
     * @param string $route
     * @param array  $arg
     */
    public static function send($route, array $arg)
    {
        $config = config('socket');
        Client\connect('ws://' . $config['httpHost'] . ':' . $config['port'] . '/' . $route)->then(function ($conn) use (
            $arg
        ) {
            $conn->send(json_encode($arg));
            $conn->close();
        });
    }
}

Model Observer
namespace App\Observers;

use Illuminate\Support\Facades\Artisan;
use Symfony\Component\Process\Process;

class GameObserver
{
    /**
     * @param $game
     *
     * @return mixed
     */
    public function creating($game)
    {
            //
            SocketClient::send('game', [
                'type'    => $game->type,
                'command' => 'winner',
                'winner'  =>  $game->winnerUser,
            ]);
    }
}

When I create a model, I send an alert to all clients

@tabuna Thank you so much, I was figuring it out on Pawl but now everything is clear. Thanks once again :)

@tabuna How were you able to connect? when I try i get following error:
Could not connect: DNS Request did not return valid answer.
Code:
Client\connect('ws://' . $config['httpHost'] . ':' . $config['port'] . '/notification' )
    ->then(function ($conn)  {
        $conn->send('sarfraz');
        $conn->close();
    }, function ($e) {
        echo "Could not connect: {$e->getMessage()}\n";
    });

FYI I am on localhost not online. Any idea please ?

Change localhost

config/socket.php

localhost => <IP_ADDRESS>
'httpHost' => env('SOCKET_HTTP_HOST', '<IP_ADDRESS>'),

With that I get differnt error:
Could not connect: HTTP/1.1 404 Not Found X-Powered-By: Ratchet/0.3.6
:(

Sorry I restarted and it works now, thanks a million :)

Getting exception here App::getInstance()


pep8

Hello @amoh-godwin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tests/test_pseudo_ffprobe.py:

Line 12:1: E302 expected 2 blank lines, found 1


Issue 190

Mostly addresses #190
There are a few cases where I did not change mentions of hard_bounds. These are the apply_hard_bounds function and the hard_bounds parameter for thesimple_ea function. In the case of apply_hard_bounds, it seemed more descriptive to leave it alone.simple_ea uses hard_bounds as a flag to enable / disable enforcing bounds, so it felt appropriate to differ there.

@markcoletti Did we update the CHANGELOG for this one?

@markcoletti Did we update the CHANGELOG for this one?

Nope, but I'll fix that now.


Edit hdinsight-hadoop-script-actions.md

Edit complete.
The link  https://hdiconfigactions.blob.core.windows.net/ didn't work when I tried it.
I'm not sure about the term "script action." It doesn't appear in the Azure terminology resources. In this article, I tried to capitalize the term as "Script Action" when it seems to refer to a specific name (of a feature or a service) but use the lowercase "script action" for generic references. Please confirm that I made the right decisions--including in the article title.
The title of the article includes "Script Action development..." but the first heading uses "script development." This may be an inconsistency in both wording and capitalization, and it reflects a potential inconsistency throughout the article regarding whether the content is about developing and running a script action or developing and running a script.
Please confirm that the list of best practices toward the beginning of the article is accurate as edited. I tried to make them all begin with a verb for the sake of consistency.
Per naming guidelines, I changed instances of "PowerShell" by itself to "Azure PowerShell." Please make sure that all mentions are technically accurate and shouldn't be "Windows PowerShell" instead.

Hi @ShawnJackson, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (v-shawja). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Option to not make a floating window topmost

This used to be possible, but since sometime ago, when I updated, the option to choose not to make a floating window topmost was not available anymore. May I kindly request to bring back this feature, as it is useful when I need to view multiple windows at windowed full screen mode? Thank you in advance.

https://github.com/koekeishiya/yabai/issues/1929#issuecomment-1872581528

#1929 (comment)

Thank you!


Add link checker and linter

https://github.com/sindresorhus/awesome/issues/1810#issuecomment-1321607755

How can we run this action before merging it? I haven't found a way.


Feature request

How to set log channel in menuticket system someone know in clan bot public src

You need to code for that as it isn't done for menuticket, a ticket transcripting option is available at the moment though.

To get hold of the transcripting option, just press "transcript" button from the ticket start menu (the menu that comes when you create a ticket) before closing it.


fix cannot use this inside model

Cannot use this inside model because in Promise.try haven't passed context of model yet.

I think it wasn't the intention to allow this (not pun intended) as model was supposed to be just a plain object, but I like the change. The ability to use this would be really useful to implement a stateful model.

Closing due to inactivity.


Another crazy bug the automatic tester found

Hi Eemeli,
It's me again! :)
Just ran the autotester on 1.1.0 and it came up with the following:
{"key1":{"key1":{"key1":"","key2":""},"key2":[]},"key2":[[">####################################\"##########################'####\\P#"]]}
--[ roundtrips to ]--->
{"key1":{"key1":{"key1":"","key2":""},"key2":[]},"key2":[[">####################################\"##########################'####\\
#"]]}

Repro:
const YAML = require('yaml');
const assert = require('assert');

const input = {"key1":{"key1":{"key1":"","key2":""},"key2":[]},"key2":[[">####################################\"##########################'####\\P#"]]};

const stringified = YAML.stringify(input);
console.log("------------\n" + stringified + "\n-----------------_");
const parsed = YAML.parse(stringified);

console.log(JSON.stringify(parsed));

assert.deepEqual(input, parsed);

YAML output:
key1:
  key1:
    key1: ""
    key2: ""
  key2:
    []
key2:
  - - ">####################################\"##########################'####\\
      \P#"

I've been running it for about a day, and it hasn't found anything more since. So that's encouraging :).


Add more content in Web Development and DevOps

The directory structure to add more content is as follows
./docs/pages

May I handle this issue?

Go for it @edson-sooraj

I'll review the pr by tomorrow, will that be okay @edson-sooraj. Got stuck in some college work

no probs :)


how does one set this up on a galaxy watch?

it keeps crashing when I press Add Google Account and going into RVX Music opens a bunch of microG GitHub webpage windows on my phone

Unofficial patches/Wrong repository

Not wrong repository. The app provided by this repository crashes when I click Add Google Account.


Delete redundant parts

I don't think we need to create a README.md for Hindi.This is strange and irrational.

I hope you can quickly merge this pull request. There's no problem.

Well, now this pull request doesn't just delete READEME.md in Hindi, it also involves the description of Chemfig, so I changed the title.


[Feature Request] Right Click to Add Waypoint

Creating waypoints is super useful, but I find it kind of unintuitive to use the keyboard to create them. I feel like Right Click is much more intuitive, but unfortunately because Foundry does not let you add mouse buttons to the "Configure Controls" settings, it is not possible for us to add this ourselves. I wonder if you'd be able to add a setting to your module that adds this behavior, if not by default, then at least as a toggleable setting, similar to what "Drag Ruler" did.

Added in v0.9.5. I also split out the token ruler and regular ruler waypoint keybindings, to give you more options. FYI, I rather like setting "meta" for adding and "control" for removing waypoints. Depends on your keyboard/mouse setup, I suppose.


Possible incorrect trace and inconsistent EVC

Hi,
One of the EVCs is currently UP, current path seems correct and sdntrace-cp seems to report the expected result, however the customer is complaining about packet loss and indeed one of the endpoints does not forward to the other endpoint (collected statistics on the dataplace):
> cat /tmp/evcs | jq -r '.["65b45a3b2ea745"]| .id + " " + .name + " " + (.uni_a|tostring) + " " + (.uni_z|tostring)'
65b45a3b2ea745 Vlan_3008_xxxx {"tag":{"tag_type":"vlan","value":3008},"interface_id":"00:00:00:00:00:xx:xx:xx:15"} {"tag":{"tag_type":"vlan","value":3008},"interface_id":"00:00:00:00:00:xx:xx:xx:25"}
> cat /tmp/evcs | jq -r '.["65b45a3b2ea745"].current_path[]|.endpoint_a.id + " " + .endpoint_b.id + " " + (.metadata|tostring)'
00:00:00:00:00:xx:xx:xx:30 00:00:00:00:00:xx:xx:xx:4 {"s_vlan":{"tag_type":"vlan","value":2}}
00:00:00:00:00:xx:xx:xx:32 00:00:00:00:00:xx:xx:xx:32 {"s_vlan":{"tag_type":"vlan","value":2}}
00:00:00:00:00:xx:xx:xx:30 00:00:00:00:00:xx:xx:xx:32 {"s_vlan":{"tag_type":"vlan","value":2}}

Update: found the issue. The problem was with a local flow overlapping with Kytos flows (the local flows were configured with a cookie for ignore rance). I will leave this issue opened just for us to discuss possible improvement opportunities to identify such behavior (conflicting local flows with flow_manager flows)

We need Kytos to log when detecting overlaps but it can be complex to address this. Let's come back to this on the next release.


XML to JSON does not seem to finish

I'm trying to convert a small XML document to JSON. The progress does not seem to stop.

Fixed in: 42a7c5396774bb612ced6ec80d5d0a68fe9b255a


Matrix Wave Traversal

Is your feature request related to a problem? Please describe.
Basically question says we have to print all the elements of a matrix while travelling in a wave manner through matrix
Describe the solution you'd like
I will be using iterative method with some logic top implement this question
Do you want to work on it
CPP

@rudrakshi#2361  @vatsal kesarwani#2606  @Tanyx#7069  @Raksha#9246  @tarun_10#1663  @Nakul#7751  @shrey#7147

do it in O(1) extra space.


how to select the search list item ?

the  selected text value is getting empty in input box.
Demo

I have the same problem

the selected text value is getting empty in input box.
Demo

onSelect={value => this.setState({value})}


Some attributes do not work with vecty.Property()

Keys does not work:
aria-hidden
role
May be it's good to support a method like setAttributs(key, value) to handle customize attribute names.

Looks like there are certain attributes (like aria-hidden) which cannot be set using a DOM property.
I think we will need something akin to vecty.Property but for attributes (vecty.Attribute) to handle this case.

I've added this in 34ae770
In an ideal world we would also probably have an attr package and limit the scope of Attribute to just a few things that do not have a property, but that will be very involved I think (to determine which ones). Let's address that in the future once we get a better idea for which attributes people use in the wild.


Getting error on many channels in jio tv

Im using kodi matrix 19.3 nd 19.4 here im getting error in many channels..its steaming bt doens't seen the video nd no sound .....so devloper resolve this query

https://paste.kodi.tv/ovozuzovey
Here im sending log


Add FIPS support to the Agent

What does this PR do?
This PR adds FIPS mode into the Agent and to do so it

Uses new build images that include Microsoft Go
Compile with goexperiment.systemcrypto when FIPS mode is enabled (Linux and Windows)
Build and ship OpenSSL with FIPS Provider (fips.so)

Note that fips_mode refers to the fact that we compile using goexperiment.systemcrypto which allow to enable or disable FIPS at runtime. So the main Agent will be compiled to support FIPS, but it does not mean that it will be enable directly.
On Windows this is a host-level setting and on Linux you need to set GOFIPS=1 to enable FIPS.
Motivation
Supporting FIPS directly in the Agent
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs

This PR introduces pretty big changes, especially given that buildimages are now using microsoft go

Additional Notes
Buildimages PR

@gjulianm I think this would be interesting to run the tests at least once to make sure we're not introduce any bug that we could have caught earlier

close in favor of this branch


Update package-chunk-sort.ts

Maintain camel case

Thank you for the contribution.  For commit message guidelines, please see here: https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#commit


Dev inspector

In the electron-api branch I'm no longer able to right click on the webview to be able to Inspect it. The only option I get in the menu is "Reload". I'm not entirely when this started happening in the last few months. I'm not yet sure how to debug the cause so I figured I'd start here. Is this something you've made configurable in this branch? If not, is it working for you? If that's the case, I guess the issue is on my end.

some people are reporting the same: http://sketchplugins.com/d/665-sketch-49-webview-cannot-be-inspected-element-by-right-click
looks like its because of Sketch 49 even I have no idea what could have changed since it's not using any Sketch API...

I was confused as to how this could have happened but found the answer:

we use to set [[NSUserDefaults standardUserDefaults] registerDefaults:@{@"WebKitDeveloperExtras": @(YES)}]; by default all the time
now it is only set when the user shares analytics

I'll add the defaults write com.bohemiancoding.sketch3 WebKitDeveloperExtras -bool true command to the doc about setting up a dev environment


add mergeText plugin

Consolidate adjacent <text> elements and <text> elements with a single <tspan> child.
Resolves #964, resolves #1907

There are problems with the commits in my branch. Closing this PR, will reopen with a clean copy.

Thanks for opening and maintaining the pull request!
When you do have it open, I'll review it once SVGO v3.2.0 is released. Meanwhile, it will probably help if you update with a rebase instead of merge next time!
Assuming origin is your fork and upstream is this repository.
git fetch --all
git rebase upstream/main

Then if there are any conflicts, you can resolve them and do:
git add .
git rebase --continue

This results in a clean commit history, no merges required. 👍🏽
If you ever have trouble because of too many conflicts, it's simpler to squash your commits first and then rebase with upstream after.
git rebase -i HEAD~N # replace N with the number of commits you want to squash
# an interactive editor appears, replace "pick" in all lines except the first with "s"

// now rebase with upstream as normal
git fetch --all
git rebase upstream/main

Thing is that usually merges work fine and don't include upstream commits in the change view, but I think somewhere commit history got changed, resulting in discontinuity across past upstream and current upstream. I ran into this when rebasing another PR I made, and fixed it by git reset --hard HEAD~1ing before retrying the merge.

Interesting, I always use rebase, so I haven't run into that issue.

commit history got changed

In the past, some maintainers have done force pushes to main, however, that forcefully closes all pull requests that target it. That shouldn't be the problem.
I'm guessing it's because we use the "Squash and merge" strategy to merge pull requests.

Because this commit is only on the base branch and not the head branch, the common ancestor of the two branches remains unchanged. If you continue to work on the head branch, then create a new pull request between the two branches, the pull request will include all of the commits since the common ancestor, including commits that you squashed and merged in the previous pull request.
— https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits


React to SessionCollectionExtensions renames

React to aspnet/HttpAbstractions#280

:shipit: for me. @Tratcher can you take a quick look and merge?


This is a syntax for runtime types in JavaScript

It finally dawned on me what this proposal allows for. Consider this class, an evolution of one @rbuckton first mentions in https://github.com/tc39/proposal-extractors/issues/18#issuecomment-2040769594:
class Point {
  #x;
  #y;
  constructor(x, y) {
    this.#x = x;
    this.#y = y;
  }
  get x() { return this.#x; }
  get y() { return this.#y; }
  static [Symbol.customMatcher](subject) {
    return #x in subject ? [subject] : false;
  }
}

With that, I can write code like this:
function drawLine(Point(p1), Point(p2)) { … }

const Point(p) = getPoint(…);

const Point({ x, y }) = getPoint(…);

match (p) {
  when Point({ let x, let y }): …;
}

In other words, by returning a [subject] array from the custom matcher method, I'm effectively ignoring the "destructuring" part, and ending up with JS code that does runtime type checking. That's... really powerful.
And it makes me think that perhaps the code above could be clearer if it didn't include the parentheses:
function drawLine(Point p1, Point p2) { … }

const Point p = getPoint(…);

const Point { x, y } = getPoint(…);

match (p) {
  when Point { let x, let y }: …;
}

I would find that much more readable, and less confusing because it doesn't look like the value after the class name is an input.
We could also get a lot of the type-checking power of this by having a default matcher implementation that relied on an instanceof check (which is already customizable via @@hasInstance) returning [subject] on success. With that, the above code would also work even with this Point implementation:
class Point {
  constructor(x, y) {
    this.x = x;
    this.y = y;
  }
}

Yes, Asumu Takikawa made this point in committee in March 2023, here's a slide. I don't think this requires any removal of parentheses, though--the syntax is already very clear to me, and extending the JS grammar gets really complicated if we define Identifier Identifier to do something.

Extractors are not the correct feature to build runtime types on. While you can use extractors for runtime assertions, their purpose is to augment destructuring. IMO, a better feature upon which to build runtime types would be Decorators. For any runtime types implementation, I believe you need more than just input validation for them to be feasible, you also need introspection/reflection.
Extractors do not provide reflection. You cannot take a function f(Point(x, y)) {} function object and reflect that the first argument takes a Point, just as you also cannot take a const { p1: Point(x, y) } = obj to reflect over p1 being a Point.
Decorators do provide reflection via context.metadata and can intercept the outermost declaration (i.e., the parameter), but cannot be deeply nested in a binding pattern. Decorators and Extractors can overlap at that boundary, but Decorators face outward (describing information about the declaration to consumers), while Extractors face inward (breaking down inputs).
IMO, the following is a better basis for runtime types:
@Returns(Number)
function add(@Type(Number) x, @Type(Number) y) {
  returns x + y;
}

And it makes me think that perhaps the code above could be clearer if it didn't include the parentheses:
function drawLine(Point p1, Point p2) { … }

const Point p = getPoint(…);

const Point { x, y } = getPoint(…);

match (p) {
  when Point { let x, let y }: …;
}

The const Point { x, y } syntax was already proposed as part of this proposal, but has subsequently been rejected as it eats up too much syntax space in assignment patterns. For example, if foo{ bar } = obj were to be supported, we could never use identifier { for any other future syntax without an insanely complex cover grammar. This is immediately relevant because the following is already legal JS and would run afoul of an ambiguity:
class C {
  static {}
}

We could also get a lot of the type-checking power of this by having a default matcher implementation that relied on an instanceof check (which is already customizable via @@hasInstance) returning [subject] on success. With that, the above code would also work even with this Point implementation:

One of the reasons Pattern Matching uses Symbol.customMatcher and not Symbol.hasInstance is that hasInstance/instanceof doesn't work for primitives: 1 instanceof Number is false, while 1 is Number will be true. In addition, Symbol.hasInstance/instanceof does not work across realms, thus you must write Array.isArray(ar) instead of ar instanceof Array, while pattern matching will allow for ar is Array (using the new protocol).

Extractors do not provide reflection. You cannot take a function f(Point(x, y)) {} function object and reflect that the first argument takes a Point, just as you also cannot take a const { p1: Point(x, y) } = obj to reflect over p1 being a Point.

True; they do the more JavaScripty thing of allowing for Point to define for itself what's valid, so the argument could be a plain object { x, y } or a tuple [x, y] or anything else that Point.p[Symbol.customMatcher] is ok with.
Outside the function, you're right that the power of this is significantly reduced, unless Point doesn't customize @@customMatcher and uses a default one that's doing an instanceof check.

The const Point { x, y } syntax was already proposed as part of this proposal, but has subsequently been rejected as it eats up too much syntax space in assignment patterns. For example, if foo{ bar } = obj were to be supported, we could never use identifier { for any other future syntax without an insanely complex cover grammar. This is immediately relevant because the following is already legal JS and would run afoul of an ambiguity:
class C {
  static {}
}

I'm not sure that I see the ambiguity with AssignmentPattern in the above, but the case made in #8 that foo[bar] = baz is already valid applies as well; I hadn't thought of that when writing my previous comment.
So something like const Point p could only work if it was limited to BindingPattern, i.e. something like:
ExtractorBindingPattern :
  ExtractorMemberExpression Identifier
  ExtractorMemberExpression ObjectBindingPattern
  ExtractorMemberExpression ArrayBindingPattern

And even then, parsing const foo[bar][baz] = ... would be a bit messy, even though it could have only one valid meaning.
To allow for custom matching behaviour during assignment, the parenthetical syntax is required, so either we use that everywhere, or we do the same sort of thing as with import vs import(), where the same kind of operation uses different syntax in different places.

One of the reasons Pattern Matching uses Symbol.customMatcher and not Symbol.hasInstance is that hasInstance/instanceof doesn't work for primitives: 1 instanceof Number is false, while 1 is Number will be true. In addition, Symbol.hasInstance/instanceof does not work across realms, thus you must write Array.isArray(ar) instead of ar instanceof Array, while pattern matching will allow for ar is Array (using the new protocol).

I agree that there is a need for @@customMatcher, and that String, Number & co. should include definitions of it that resolve as primitive values. I don't understand how @@hasInstance "does not work across realms", but that's perhaps not really relevant.

I don't understand how @@hasInstance "does not work across realms", but that's perhaps not really relevant.

More specifically, the default implementation of @@hasInstance/instanceof does not work for built-ins for object/array/RegExp literals when the value comes from another realm/frame.
So if you write
<script>
function checkEach(obj, ar, re) {
  console.log("Object:", obj instanceof Object);
  console.log("Array:", ar instanceof Array);
  console.log("RegExp:", re instanceof RegExp);
}
</script>

in the outermost window and call top.checkEach({}, [], /./) inside an iframe it prints the following:
Object: false
Array: false
RegExp: false

Thus, instanceof for built-ins is unreliable across realms/frames.

Additionally, anything can use Symbol.hasInstance to lie, so it's generally not a good tool to reach for.

Additionally, anything can use Symbol.hasInstance to lie, so it's generally not a good tool to reach for.

I don't think that's relevant, the same thing applies to Symbol.customMatcher.

Extractors are not the correct feature to build runtime types on. While you can use extractors for runtime assertions, their purpose is to augment destructuring. IMO, a better feature upon which to build runtime types would be Decorators. For any runtime types implementation, I believe you need more than just input validation for them to be feasible, you also need introspection/reflection.

Returning to the deeper point here, I think it's important to not only consider what extractors are meant for, but also what capabilities they offer beyond that initial purpose. In particular when used in code like
function drawLine(Point(p1), Point(p2)) { … }
const Point(p) = getPoint(…);

the extractors look like, and are, providing assertions about values satisfying Point[Symbol.customMatcher]. Sure, those assertions are really only facing inwards, and they're user-definable, and they're not really at all what types mean in other languages, but this honestly feels like a very JavaScripty way to do runtime typing. It also feels like a solution for maybe 80% of the use cases that one might have for runtime types, and that's good, because it's being reached with a comparatively small addition to the language.
As a library developer, I would absolutely use this syntax on public APIs to ensure that e.g. my functions are being called with the expected arguments. I probably wouldn't use it internally until build tooling is good enough to strip it out from places where it's unnecessary, but that won't take too long. This one change would probably subsume a decent chunk of what I'm using TS for, actually.


no watermark

i think api2.musical.ly was down
so for no watermark error

I am looking into it. Thanks 🍺

I am looking into it. Thanks 🍺

nice.
btw, you have instagram scraping?

@thoriqazzikraa Fixed in 6a8bea4a7f537d324610663aad90bff8e87bf2be, Please update the library to the latest version


Proguard enabled in Android Expo project causes customerio to fail with error "HTTP request failed. Error: java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType"

SDK version:
customerio-expo-plugin: 1.0.0-beta.15 (latest in repostiroy)
customerio-reactnative 3.5.2
react: 18.2.0
expo: 50.0.13
<EMAIL_ADDRESS>Environment: Production
Are logs available?
from adb logs
03-28 15:40:04.779 10470 10551 D [CIO]   : HTTP request failed. Error: java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType
Describe the bug
When enabling Proguard for production builds customer.io fails to send events.
To Reproduce

Build expo project
Integrate with customer.io
see that it works with .apk version without proguard
see that it does NOT work with .aab version with proguard

Expected behavior

expect enabling of proguard to not break customer.io

Additional context
I have already had to add an extra proguard rule to the expo project in order for it to build. Are there further proguard rules that need to be included which it maybe is not able to copy from the customer.io plugin?
extraProguardRules: "-dontwarn org.slf4j.impl.StaticLoggerBinder",

Hey @kimdanielarthur-cowlabs thank you for reaching out and raising this issue, if there a sample project where its reproducible that would be great and speed up the process, otherwise we are going to try reproduce it and get back with more information.

Thanks!
I can see if there is time to set up a clean test project, but i doubt will find the time...
I guess i can try to check the source code here to see what proguard rules are in the android native code, as i suspect its the build process on expo that is somehhow not copying them over. Given the error I had on that org.slf4j.impl.StaticLoggerBinder

@kimdanielarthur-cowlabs Thank you for your patience here, even though we don't utilize it or add it in our SDK. SLF4J Android – is a Simple Logging Facade for Java (SLF4J) that adds a logger binding for the Android platform. So I believe, by having this rule in your extended proguard, should be enough.
-dontwarn org.slf4j.impl.StaticLoggerBinder

Please, feel free to reopen the ticket in case there is any other dependency that gives you an issue, nothing stood out while we tested.

Thanks,
My original issue is not related ot the StaticLoggerBinder, but
"03-28 15:40:04.779 10470 10551 D [CIO]   : HTTP request failed. Error: java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType"
This issue still persists and I believe it may be related to gradle v8 and how proguard R8 by default does the optimisation/obfuscation. If I add the rule:
-keep class io.customer.**  { *; }I get a different error message than earlier reported
``04-02 21:16:53.896  5326  5399 D [CIO]   : HTTP request failed. Error: Response must include generic type (e.g., Response)
04-02 21:16:53.896  5326  5399 D [CIO]   :     for method CustomerIOService.identifyCustomer

I am exploring further to try to figure out what classes are causing the problem.

I think the main point is that there seems to be issues with using Customer.io with expo 50 when proguard is enabled for release builds.

To be clear: The StaticLoggerBinder issue was another earlier problem with the SDK in latest expo and is not the main topic for this ticket

@kimdanielarthur-cowlabs thanks for adding this extra context, very much helpful and needed here. I suspect the same thing, gradle v8 enables R8 (obfuscation tool) full mode by default.
We are working on gradle V8 support as we speak and hopefully we should roll out a fix for it soon, I would recommend not moving to Gradle 8 if possible till then?

Thanks!
I'll check if we somehow can control this when building using expo EAS build service

Quick question: do you guys use retrofit2?

Yup we are do and absolutely, most of the R8 restrictions are indeed coming from them. With our Gradle 8 support release we plan to ship proguarding updates for retrofit too after testing them.

Ok great understand!
We are using Expo managed builds so I made a quick expo build pluging that sets the needed gradle property that disables R8 fullMode for now. That fixes the problem

module.exports = (config) => {
    return withGradleProperties(config, (config) => {
        config.modResults.push({
            type: "property",
            key: "android.enableR8.fullMode",
            value: "false",
        });
        return config;
    });
};```

@kimdanielarthur-cowlabs We just released a new version with the support for R8 rules for the internal dependencies.

@kimdanielarthur-cowlabs We just released a new version with the support for R8 rules for the internal dependencies.

Nice one, we can update and revert or disabling of fullMode


Can't build v1.0.0-beta.1 locally

While attempting to debug a crash (crictl ps will work, crictl pull busybox will cause cri-continerd to panic), I tried to install and build v1.0.0-beta.1, since that's the version I had the problem on.
While initially I built cri-containerd off of master, and it actually worked fine (+ seccomp and selinux tags), I realized I was on master and tried to go back and build v1.0.0-beta.1 and it failed, citing missing code -- I think this is due to the change of repo name (after graduating from Kubernetes incubator?)
go build -o _output/cri-containerd \
        -tags 'seccomp apparmor' \
        -ldflags '-X github.com/kubernetes-incubator/cri-containerd/pkg/version.CRIContainerdVersion=1.0.0-beta.1' \
        -gcflags '' \
        github.com/kubernetes-incubator/cri-containerd/cmd/cri-containerd
can't load package: package github.com/kubernetes-incubator/cri-containerd/cmd/cri-containerd: cannot find package "github.com/kubernetes-incubator/cri-containerd/cmd/cri-containerd" in any of:
        /usr/lib/go/src/github.com/kubernetes-incubator/cri-containerd/cmd/cri-containerd (from $GOROOT)
        /home/<user>/go/src/github.com/kubernetes-incubator/cri-containerd/cmd/cri-containerd (from $GOPATH)
make: *** [Makefile:81: _output/cri-containerd] Error 1

There might not be much you all can actually do about this outside of instructing people to copy/symlink $GOPATH/src/github.com/kubernetes-incubator/cri-containerd to $GOPATH/src/github.com/containerd/cri-containerd
The actual issue I'm having is pretty perplexing too but figured I'd report this sooner rather than later.
Workaround
ln -s $GOPATH/src/github.com/containerd/cri-containerd $GOPATH/src/github.com/kubernetes-incubator/cri-containerd

A follow up question (I don't think it's worth it's own ticket) -- Does cri-containerd require a custom build if seccompand apparmor are enabled? The problem I was having just went away with a custom build, but the pre-packaged binary had the panic I was trying to debug earlier
For context, I'm running Kubernetes v1.9.2 by way of the kubernetes the hard way guide, on an Arch Linux box (libseccomp (aur) and apparmor installed using the guide).

On master, we are in the middle of migrating from github.com/kubernetes-incubator/cri-containerd to github.com/containerd/cri-containerd and we retained git history.  Thus when you went back in time to before the start of the migration effort you necessitated that your source be github.com/kubernetes-incubator/cri-containerd based.  For me, I have an old git tree in my $GOPATH/src/github.com/kubernetes-incubator/cri-containerd and a new git tree in my $GOPATH/src/github.com/containerd/cri-containerd

A follow up question (I don't think it's worth it's own ticket) -- Does cri-containerd require a custom build if seccomp and apparmor are enabled?

Use make install.deps to build and install all your dependencies.
Cheers!

Thanks for letting me know @mikebrow , I suspected it might be something like that.
Sorry for the interruption!


Hyprland plays workspace switch animation for multiple monitors even if they're already open

Hyprland Version
Hyprland, built from branch makepkg at commit bb0933437f4602080a66cc877fee36dce8dcb3ff dirty (wlr-ext-workspace: remove protocol impl).
Bug or Regression?
Regression
Description
Before commit bb0933437f4602080a66cc877fee36dce8dcb3ff Hyprland didn't play the workspace animation when switching between workspaces on different monitors (that were already open!) when using the workspace keybind.
Starting from this commit, it always plays the workspace animation regardless.
(I should also mention that this ALSO happens on the latest commit as of writing this, 96d555e8e794627bfc561e294e148ab8a9961fcc)
How to reproduce

update hyprland to or past commit bb0933437f4602080a66cc877fee36dce8dcb3ff
open 2 workspaces on 2 different monitors (with windows on them)
switch between them using keybinds
observe the animation
downgrade hyprland to a version prior to this commit
observe no animation

Crash reports, logs, images, videos
video
Hyprland was supposed to play zero workspace animations in this video.

fixed in 5126bfab72ff0cf74ebd4c6346e19ac52ea7b00b


How to compare the pre-release version?

Why the result is false? I think<PHONE_NUMBER>15 <<PHONE_NUMBER>17. How can I make it return true.?
package main

import (
	"fmt"
	"github.com/blang/semver"
)

func main() {
	inRange, err := semver.ParseRange(">=4.3.0 <4.3.0-201912111117")
	if err != nil {
		panic(err)
	}

	version := semver.MustParse("4.3.0-201912060615")

	// Check if the version meets the constraints. The a variable will be true.
	fmt.Printf("within range: %t", inRange(version))
}

@jianzhangbjz:
Your range start >=4.3.0 demands the version to be at least 4.3.0. However, 4.3.0-201912060615 is a pre-release version so it is actually lower than 4.3.0.
https://semver.org/#spec-item-11:

When major, minor, and patch are equal, a pre-release version has lower precedence than a normal version:
Example: 1.0.0-alpha < 1.0.0.

@makkes Ah, I see now, many thanks!


Add Version Model+API

Resolves #681

Versions now have a model + API
Submission/Backups now use the version value sent by the client instead of a hardcoded value
Ok Client changes were made to account for the renaming of current_download_link to download_link

Design changes from v2: We don't store previous version info. We never really used that information.

Entirely unrelated changes (didn't want to make a separate PR for these)

Enrollment API is protected by some permissions now (this requires some minor changes to ok-client)
login links to testing login in dev mode
Quick Links on testing-login to login to staff/student accounts

LGTM, feel free to merge once the tests are fixed


Edits in "When to change dev/test sets and metrics"

There was a conflict, I've made this update manually