chore: update eip-7251 bytecode and address

Motivation
The bytecode of the system contract in EIP-7251 has been changed to add logging, see https://github.com/ethereum/EIPs/pull/8889
Solution
Closes #1340
PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

Please do not merge this upon approval, I'd like to merge the devnet 4 PRs in one go when necessary.


Disable doclint on JDK 1.8+

Temporary fix of #25

The build failed for an unrelated reason: https://travis-ci.org/ldp4j/ldp4j/jobs/177157794#L166

The build failed because of the way in which Travis handles builds for pull requests: for security reasons certain things cannot be done. And some of the are required by the current build mechanism :disappointed:

Eventhough the change would solve the issue, this is a 'quick and dirty' solution, as in the end this would just be sweeping the dirt under the carpet, that is, the JavaDoc would still be broken. Even worse, the problems could keep increasing without knowing.
Instead of accepting the request, I'll be just fix the JavaDoc failures instead and try to change the build to leverage a Java 8 JDK instead to avoid this sort of problems. However, the codebase will remain for now Java 7 as well as the binaries.


Error: Option "--root" is missing

Description
I am trying to upgrade my react native version from 0.60.5 to 0.67.3. After npm update and npx react-native upgrade. I am trying to run my project it giving this kind of weird. Even i searched in google i found very very few and git issues also i couldn't find anything. Please Help me to resolve. Thanks in Advance.

Version
0.67.3
Output of npx react-native info

Steps to reproduce
step 1
Upgrade 0.60.5 to 0.67.3
step 2
run this project(for me: react-native run-android --port=8088)
Snack, code example, screenshot, or link to a repository
No response

same issue

same

sme

That's an issue that you should report against the React Native CLI here:
https://github.com/react-native-community/cli


fix: update postgres image for ca certs

What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 62.706%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3805

Relevant Lines:
6068

💛  - Coveralls


user:vendelieu setMyCommands

Hello,
I've already tried .js implementations and nodejs http request to get some positive result when using setMyCommands. The request/response says O.K. but nothing was changed (tried several settings with @telegram‧botFather on my bot, as well).
If telegram-bot can show that setMyCommands works, I would have to switch to Kotlin.
P.S. clever, the interface BotWaitingInput

Hello, I do not often use the full range of Telegram API, so the interface of some commands may not be entirely convenient, but in any case, having checked now everything is quite working.
setMyCommands(
            null, null,
            BotCommand("/test", "test command"), BotCommand("/test2", "test command")
        )

Response: {
  "ok" : true,
  "result" : true
}

The first two parameters are scope and language_code, which are optional, so that's why there is null.
I think in a future release we should change the interface of the command.

I also checked with scope
works very well:
deleteMyCommands().send(bot)
setMyCommands(
        languageCode = null,
        scope = BotCommandScope.AllGroupChats,
        BotCommand("/test1", "test command")
).send(bot)

Bot Private chat after request:

In group:

While checking commands, I found a small bug on polymorphic deserialization of sealed classes, a fix for which I already committed in v1.1.2
In the process of manual testing, because it was implemented all the Telegram API was difficult to find all the possible bugs, but in the near future I plan to cover everything with the program tests.
If there will be any feedback or suggestions on the interface or anything else, I will be very happy to listen.

Commandy and Menu button are only a small aspect for our budget and client - rather a look and feel, compared to the main work processing. I cannot promise more than putting prototype up for discussion here.

Yes, I will wait with interest for your questions and if there are suggestions.

Hello, I mentioned the requirement for setChatMenuButton above; can we implement that ourselves by using existing functionality of telegram-bot, unchanged?
Depending on words (or other condition) sent in a message to the bot, it should set the menu button to {text: 'any', url: 'https:'+'//something'}, but only for use in chat with the sender (I think that is private chat in Telegram terminology).

Yeah, there's same function setChatMenuButton()
setChatMenuButton(
  MenuButton.WebApps("test", WebAppInfo("webappUrl"))
).send(1234, bot)

recently released version 1.2.2, where you can use a more user-friendly interface of setMyCommands() action
setMyCommands {
    botCommand("/test", "description, of command")
    botCommand("/test2", "another command")
}

Also, there are improvements in interface of some other functions.
plus, you can introduce your "magic object" via interface


tsc compiler fails after installing update 3 of visual studio

Hi,
I don't know if this is a TS bug or something else so i post it here too:
stackoverflow

can you share a project that reproduces the issue, or an msbuild log with `/verbosity:diagnostic"

This issue does not seem to be actionable at the moment. Closing for housekeeping purposes. Please reopen if this is still an issue or there is more information to share.

Thanks, it was project specific probably. TS was giving errors and didn't want to compile. (even though compileOnErrors=true). I needed to change

to

and compileOnSave true in tsconfig


feat(cli): Add a flag status to delete cmd like list cmd of argo cli

Motivation
For https://github.com/argoproj/argo-workflows/issues/11555. @tooptoop4 wants to filter workflows more accurately and flexibly by status.
There are two supported flags associated with it:

--field-selector: metadata.name=foo, metadata.namespace=bar
--selector: workflows.argoproj.io/phase=Succeeded

It is not feasible to use the --field-selector to filter workflows by status because of the well-known reasons.
Using -l(--selector) would satisfy the need, but the labels are too long with a common prefix workflows.argoproj.io/. It is not convenient to use.
Luckily, argo list has a directly related flag --status to filter workflows by status like argo list --status Running. It is more convenient to use. I think it could be taken a step further by exempting users from using the shell combination like argo delete $(argo list --status Succeeded | awk '{print $1}')
Modifications

Add a flag --status to argo delete to filter workflows by status. It's an existing field of struct listFlags and can be used directly.

Verification
There was no test code for argo delete before. I run it locally and it works as expected.

https://github.com/argoproj/argo-workflows/pull/11557 does something similar, but I don't think flag pending makes sense, there shouldn't be such a tiny, fine-grained flag.
Also thanks for his/her PR. 🙏

It is not feasible to use the --field-selector to filter workflows by status because of the well-known reasons.
Using -l(--selector) would satisfy the need, but the labels are too long with a common prefix workflows.argoproj.io/. It is not convenient to use.

Agreed with this rationale. After you brought up the inadequacy of --field-selector in https://github.com/argoproj/argo-workflows/issues/11555#issuecomment-1676990143, I thought label selectors could be a workaround as well, but I would agree that it is quite long to type out.
Moreover, argo list already supports --status, so this is just exposing that existing flag to argo delete.

#11557 does something similar, but I don't think flag pending makes sense, there shouldn't be such a tiny, fine-grained flag.

I would normally agree with this, but given that there are already --running and --completed flags, it's not altogether new either. If those didn't exist already, I would definitely prefer to not increase the surface area.
In any case, I think that discussion should be had in that PR. This PR does not technically preclude that PR

It is not feasible to use the --field-selector to filter workflows by status because of the well-known reasons.
Using -l(--selector) would satisfy the need, but the labels are too long with a common prefix workflows.argoproj.io/. It is not convenient to use.

Agreed with this rationale. After you brought up the inadequacy of --field-selector in #11555 (comment), I thought label selectors could be a workaround as well, but I would agree that it is quite long to type out.
Moreover, argo list already supports --status, so this is just exposing that existing flag to argo delete.

Yes. My implementation is reuse listFlags.

Thank's for your review, your analysis is very detailed and careful. 👍 💯


[Bug]: Consider pointing to the root of the dbt project in target-path using CLI option or env var

Package Version
0.1.0
Python Version
NA
Operating System
NA
Description
Starting with dbt 1.7, the dbt clean command fails for directories outside of the project root: https://github.com/dbt-labs/dbt-core/issues/8318.
Perhaps https://github.com/meltano/dbt-ext/blob/e445807dee6326ae8509a9c8239a489000797a0b/files_dbt_ext/bundle/transform/dbt_project.yml#L18-L24 should be updated to point to a path in the transform/ directory.

[!NOTE]
Setting target-path in dbt_project.yml is deprecated in favor of the CLI flag or env var: https://docs.getdbt.com/reference/project-configs/target-path#configuration

Code
No response

Shared by a community member in Slack:

fwiw i got things to work by specifying DBT_CLEAN_PROJECT_FILES_ONLY: false in my env (via docker compose file), which lives here

https://meltano.slack.com/archives/C01TCRBBJD7/p1699395032523659?thread_ts=1699309247.914179&cid=C01TCRBBJD7
https://www.linen.dev/s/meltano/t/16042194/hi-all-i-m-currently-trying-to-upgrade-my-meltano-managed-db#ae35e269-8ee4-4e72-8e2b-280801d81dc3

This issue has been stale for almost a year, and it really should be addressed.  This issue blocks dbt from being used at all, unless the user jumps through hoops to discover the problem and then jury-rigs some mechanism for injecting DBT_CLEAN_PROJECT_FILES_ONLY into the run.
If there are no plans to fix the underlying paths issue, this flag should be enabled by default in the plugin.


Support verbose flag for template installation

Changes
Support --verbose flag in template installations
Testing
Linking and running npx create-snowpack-app new-project-directory --template  @snowpack/app-template-react --verbose
Docs
Not yet

Make sense, +1 for this.
You'll need to run yarn test -u to update the failing snapshot tests.

Make sense, +1 for this.
You'll need to run yarn test -u to update the failing snapshot tests.

Make sense, +1 for this.
You'll need to run yarn test -u to update the failing snapshot tests.

Strange. Locally all my tests are passing
Test Suites: 2 skipped, 72 passed, 72 of 74 total
Tests:       11 skipped, 231 passed, 242 total
Snapshots:   205 passed, 205 total
Time:        100.589 s, estimated 103 s

Make sense, +1 for this.
You'll need to run yarn test -u to update the failing snapshot tests.

Strange. Locally all my tests are passing
Test Suites: 2 skipped, 72 passed, 72 of 74 total
Tests:       11 skipped, 231 passed, 242 total
Snapshots:   205 passed, 205 total
Time:        100.589 s, estimated 103 s

Hmm, can you tell why the tests are failing on CI?

Hmm, can you tell why the tests are failing on CI?

Hmm, can you tell why the tests are failing on CI?

Its passing now. I must have for to run yarn format/lint. Thanks

Hmm, can you tell why the tests are failing on CI?

Its passing now. I must have for to run yarn format/lint. Thanks

LGTM! Sorry for dropping this!


Suppress warnings from Qiskit Nature

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 89.375%

Totals

Change from base Build<PHONE_NUMBER>:
0.008%

Covered Lines:
2330

Relevant Lines:
2607

💛  - Coveralls

When I run this branch under pytest, all versions pass:
  py38: OK (105.50=setup[71.32]+cmd[34.19] seconds)
  py39: OK (129.52=setup[89.50]+cmd[40.02] seconds)
  py310: OK (138.50=setup[100.98]+cmd[37.52] seconds)
  py311: OK (135.71=setup[102.40]+cmd[33.30] seconds)
  congratulations :) (509.33 seconds)

When I run the tests again locally against current development versions, using python tools/extremal_dependency_versions.py pin_dependencies dev --inplace (this is destructive; it modifies pyproject.toml), then all tests pass again as well:
  py38: OK (878.60=setup[865.89]+cmd[12.71] seconds)
  py39: OK (161.98=setup[147.90]+cmd[14.08] seconds)
  py310: OK (152.29=setup[140.42]+cmd[11.88] seconds)
  py311: OK (152.60=setup[142.16]+cmd[10.44] seconds)
  congratulations :) (1345.72 seconds)

When I run notebooks from this branch, they fail on all versions of python:
  py38-notebook: FAIL code 1 (181.68=setup[73.70]+cmd[107.98] seconds)
  py39-notebook: FAIL code 1 (184.47=setup[74.37]+cmd[110.11] seconds)
  py310-notebook: FAIL code 1 (189.66=setup[75.84]+cmd[113.82] seconds)
  py311-notebook: FAIL code 1 (173.32=setup[75.39]+cmd[97.94] seconds)
  evaluation failed :( (729.22 seconds)

So, at the moment, it seems that the tests fail on the notebook(s) only regardless of python version.

The following line in pyproject.toml is preventing Qiskit Nature 0.6.0 from being used in the notebook tests, but I believe that using SparsePauliOp (this PR) requires getting rid of that upper bound.  (At least, there is no attribute setting.use_pauli_sum_op in earlier versions.) That might then cause a failure related to quantum serverless in one of the notebooks, but we can evaluate what to do about that (this is all related to #108).
https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/blob/4a0cd45c5f28b196800aefd843f380ba7136494c/pyproject.toml#L84
The dependency should also be updated at the following line in order for the minimum version tests to pass:
https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/blob/4a0cd45c5f28b196800aefd843f380ba7136494c/pyproject.toml#L31
The README badge should be updated to match that version, too.

Oh yes -- I forgot before approving: This certainly deserves a release note, too.


Allow poison 2.0.

Hi,
I just changed the requirement on poison as I had issue integrating this library in my project,
and it should work as well with poison 2.0.
It would be very nice if you could publish a release with this change.
Thank you.

Thank you.

@tuvistavie new release is on Hex.

@lexmag Thank you very much for the quick merge/release! :smiley:


[BEAM-860] Move Apache RAT license check out of release profile

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Move Apache RAT license check out of release profile. It runs quickly, so can run as a part of normal mvn verify phase. Will make it so missing licenses are caught locally more easily.
Tested this locally by removing the license from a file and running 'mvn clean verify' as well as 'mvn clean verify -P release'. Now both fail, whereas previously, only 'mvn clean verify -P release' failed.
See discussion at https://github.com/apache/incubator-beam/pull/1199#issuecomment-256802048
Would you mind looking @dhalperi ? Sorry to send 100% of my two PRs so far to you, but you do have context on this one...

Travis failures are pre-existing recurring ones related to Spark runner compilation and Spark runner test failure

R: @jbonofre

Spoke with some other folks in person. I think we want to keep the default mvn verify profile to only the subsets of commands that a Beam user wants to run. To that end:

we should leave RAT off
we should remove checkstyle and other similar things
we should document very concisely in the contribution guide what command Jenkins precommit runs (maybe it should be -Pprecommit ?) for contributors who want to test locally

+1, it makes sense to me.

Makes sense, closing this PR, some further commentary on the JIRA: https://issues.apache.org/jira/browse/BEAM-860


New package version for Ubuntu 16.04.1 LTS

Cookbook version
8.0.4
Chef-client version
12.15.19
Platform Details
Ubuntu 16.04.1 LTS - AWS EC2
Scenario:
Install mysql-client-5.7
Steps to Reproduce:
use the default mysql_client library from the cookbook to try and install the client
Expected Result:
mysql client 5.7 installs
Actual Result:
Chef client run fails on version 5.7.15.  looking in apt-cache for mysql-client-5.7 shows version 5.7.16 available.
STDERR: E: Version '5.7.15-0ubuntu<IP_ADDRESS>' for 'mysql-client-5.7' was not found
    ---- End output of apt-get -q -y install mysql-client-5.7=5.7.15-0ubuntu<IP_ADDRESS> ----

$ apt-cache policy mysql-client-5.7
mysql-client-5.7:
  Installed: (none)
  Candidate: 5.7.16-0ubuntu<IP_ADDRESS>

#485


Find substring within columns like SQLAlchemy's or_

I'm working on a project where I need to be able to search the database for a certain string in several different columns.
This was pretty simple with SQLAlchemy/SQLite (back before I started switching to RethinkDB):
results = Tickets.query.filter(or_(
            Tickets.issue.contains(search_term),
            Tickets.details.contains(search_term),
            Tickets.representative.contains(search_term),
            Tickets.who.contains(search_term)
))

However, I can't seem to find anything like this in remodel. Is this not a feature that exists, or is it just undocumented?
There's obviously the option of doing a raw RethinkDB call:
r.table('users').filter(lambda doc:
    doc['name'].match("(?i)^john$")
).run(conn)

but I have had no luck with that and I would prefer to do everything via remodel.

Remodel isn't very advanced and its aim isn't to provide a "native" way for all possible query combinations that RethinkDB offers. Instead, basic ODM features are provided and for the more complex ones, Remodel dispatches commands directly to RethinkDB. You can check this section of the README:
import rethinkdb as r

class Celebrity(Model):
    pass

Celebrity.create(name='george clooney')
Celebrity.create(name='kate winslet')
upper = Celebrity.map({'name': r.row['name'].upcase()}).run()
print list(upper) # prints [{u'name': u'GEORGE CLOONEY'}, {u'name': u'KATE WINSLET'}]

As you can see, map is a RethinkDB function which, if called on your model, adds some syntactic sugar behind the scenes for you to perform your queries with as little boilerplate as possible. Chaining is also possible since the RethinkDB Python driver is invoked.
Hope this helped you!


No autocompletion

local lsp_zero = require('lsp-zero')

lsp_zero.on_attach(function(client, bufnr)
  lsp_zero.default_keymaps({buffer = bufnr})
end)

require('mason').setup({})
require('mason-lspconfig').setup({
  ensure_installed = {},
  handlers = {
    function(server_name)
      require('lspconfig')[server_name].setup({})
    end,
  },
})

I have set up lsp-zero with the above configuration. While the diagnostics are working fine, I am not receiving any autocompletion suggestions. Here are a few additional details:

I have confirmed that the language server is installed and running.
Diagnostics are displayed correctly, indicating that the server is at least partially functional.
I am using the latest version of lsp-zero, mason, and mason-lspconfig.

Steps Taken

Verified the installation of the language server.
Checked the logs for any errors but found none related to autocompletion.

Request for Assistance
Could someone please guide me on what might be missing or misconfigured in my setup? Are there any specific steps I should take to troubleshoot and resolve the issue with autocompletion not working?
Thank you!

You can check the command :CmpStatus. If you execute that command after you enter insert mode and type a few character, it should give you this output.
# ready source names
- nvim_lsp:lua_ls

@VonHeikemen Thanks for the quick reply. But I have to say it was completely my stupidity. I didn't install the dependencies. I am using rocks.nvim for plugin management and thought for some reason it would all dependencies for lsp-zero. So after installing nvim-cmp it works fine.


[stable/rabbitmq-ha] set NODE_IP to ExternalIP rather than InternalIP for external access

What this PR does / why we need it:
When a rabbitmq-ha chart is deployed, helm prints an external URL to access the management UI
the external URL contains node's private IP rather than the external IP
jsonpath="{.items[0].status.addresses[0].address}"

addresses[0] is the private ip
I changed the query to
jsonpath="{.items[0].status.addresses[?(@.type=='ExternalIP')].address}"

If the intent was to access it via private ip, the documentation (imho) needs to tell the user the appropriate kubectl proxy command to execute

/assign @mattfarina

/ok-to-test
/lgtm

/lgtm


Converging DatArchive API with experimental FileSystem API?

I noticed the inconsistent casing in readdir verus readFile, too (https://github.com/beakerbrowser/beaker/issues/571). I understand the choice to use the Node.js fs module as a model at the time, but now Mozilla and others have published a spec for in-browser filesystem access as part of the libdweb project.
https://github.com/mozilla/libdweb/blob/a78b0a0c9a1f1d3d1e3343995de7d4a9b0cb000c/src/FileSystem/FileSystem.js#L8-L39
MDN article
At first glance it seems to be a more consistently designed API. Plus, it might make a natural fit for Dat to fit in if other browsers are already looking at adopting the FileSystem API.

Yeah this is a good thing to look into. We aren't afraid to deprecate APIs. We can do things like leave the old API for a time, and even put out new APIs by names like DatArchive2. We just want it to be well-warranted, and this is the kind of thing that might warrant it.
Let's see what adoption turns into with the new filesystem APIs.


Using extra argument properly for #title-slide

Hello,
Thanks for the package. I'm wondering how to properly make use of the extra parameter for #title-slide, specifically with the dewdrop theme.
The code below produces three slides:

A title slide missing the extra information, (which I don't want)
An outline slide
A title slide containing the extra information (which I do want)

Ideally, I'd just have slide 3, then slide 1.
#import "@preview/touying:0.3.2": *

#let s = themes.dewdrop.register(
  aspect-ratio: "16-9",
  footer: [Dewdrop],
  navigation: none,
)
#let s = (s.methods.info)(
  self: s,
  title: [Title],
  subtitle: [Subtitle],
  author: [Authors],
  date: datetime.today(),
  institution: [Institution],
)
#let (init, slides, touying-outline, alert) = utils.methods(s)
#show: init

#show strong: alert

#let (slide, title-slide, new-section-slide, focus-slide) = utils.slides(s)
#show: slides

#title-slide(extra: "Extra")

Sorry, I'm not very experienced with OOP!

Thank you!


add break & default logic for NettyDecoder.decode

What is the purpose of the pull request
We should always add break & default logic to SWITCH , if one method using switch doesn't need to use break & default actually , the logic will be so hard to understand !!!
Brief change log
add break & default logic for NettyDecoder.decode

Codecov Report

Merging #2969 into dev will decrease coverage by 0.20%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##                dev    #2969      +/-   ##
============================================
- Coverage     39.11%   38.90%   -0.21%
+ Complexity     2678     2671       -7
============================================
  Files           435      435
  Lines         20119    20126       +7
  Branches       2454     2454
============================================
- Hits           7870     7831      -39
- Misses        11514    11560      +46
  Partials        735      735

Impacted Files
Coverage Δ
Complexity Δ

...he/dolphinscheduler/remote/codec/NettyDecoder.java
58.53% <71.42%> (-26.76%)
7.00 <1.00> (+2.00)
:arrow_down:

...g/apache/dolphinscheduler/remote/command/Pong.java
0.00% <0.00%> (-87.50%)
0.00% <0.00%> (-2.00%)

...dolphinscheduler/remote/command/CommandHeader.java
70.00% <0.00%> (-30.00%)
4.00% <0.00%> (-3.00%)

...inscheduler/remote/handler/NettyServerHandler.java
23.40% <0.00%> (-25.54%)
3.00% <0.00%> (-2.00%)

...inscheduler/remote/handler/NettyClientHandler.java
20.40% <0.00%> (-22.45%)
2.00% <0.00%> (-3.00%)

...org/apache/dolphinscheduler/remote/utils/Pair.java
36.36% <0.00%> (-18.19%)
1.00% <0.00%> (-2.00%)

...pache/dolphinscheduler/remote/command/Command.java
37.93% <0.00%> (-17.25%)
7.00% <0.00%> (-2.00%)

...dolphinscheduler/remote/future/ResponseFuture.java
72.88% <0.00%> (-8.48%)
17.00% <0.00%> (-1.00%)

...phinscheduler/remote/utils/NamedThreadFactory.java
91.66% <0.00%> (-8.34%)
3.00% <0.00%> (-1.00%)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a7fd72...0687264. Read the comment docs.

@superScala Could you resolve the bad code smells ?

@superScala I think this PR is OK, we'd better invite owner of this file @qiaozhanwei to review . If he has not suggestions , I will merge this PR.

@superScala Thanks for your contributions . Since no others have an opposite options ,I merged this PR

hi ,@superScala , unfortunately @qiaozhanwei reverted this PR (https://github.com/apache/incubator-dolphinscheduler/pull/3035) and he gave a useful blog https://www.jianshu.com/p/1f27eaea611d to explain it,  you can get infos from the blog.
According to the blog 'break' is no needed, however I till think it's not the best practice to remove break from switch. I suggest that you refactor it using Chain of Responsibility Pattern, waiting for your new PR about this


Unintended log and heartbeat sharing when more than one DE is running

Open a Data Editor on port 9000, then open another Data Editor on port 9001, and suddenly you'll notice that the heartbeats are both saying that they are running on port 9001.  Also the logs are now all being written to the log file for 9001.  Both Data Editors appear to work just fine (they are communicating with their original servers), but the heartbeats and logs should be going into their respective locations.

The bug was addressed by only allowing a single Data Editor to be running at one time.  We plan to allow multiple Data Editors to share one server instance in an upcoming release.

Closed with merge of #509


getProperty can't get storyDifficulty variable using Lua

Describe your bug here.
I was making modcharting a mod made in Psych Engine and came across a bug in the getProperty function. When I tried to print getProperty('storyDifficulty'), it printed storyDifficulty, which isn't supposed to happen. The same thing occurs on Psych Engine 0.5.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No, I have made no changes to the build

'storyDifficulty' is a static variable, which means it's the same across all instances of PlayState. Due to this, you can't get it from one specific instance, you have to get it from the class ('PlayState' in this situation). Using:
getPropertyFromClass('PlayState', 'storyDifficulty')
(should return a number)

You can also use difficulty local lua variable for getting the difficulty number.

Check Lua Script API's "Variables" page for more info.

Oh, okay, I misunderstood. I thought I could get the variable by just using getProperty.


Look into Zotero support

It'd be great if Zotero supported CFF in that you could harvest the CFF metadata from a repository website (GitHub, GitLab, Bitbucket, etc.) via the "Save to Zotero" browser add-on (https://github.com/zotero/zotero-connectors/)!

May be possible if we're willing to use a cff retrieval service, for example using cffconvert like so:
https://us-central1-cffconvert.cloudfunctions.net/cffconvert?url=https://github.com/citation-file-format/cff-converter-python&outputformat=cff
If we'd go that route, maybe we should look into adding an export to cffconvert that produces a format that zotero can already ingest.

This is now partly (for GitHub) solved as Zotero supports CITATION.cff input.


iOS 13.3 Gallery open bug

Bug Report
Trying to open gallery on iOS Devices with iOS 13.3 gallery crushes
Problem
When trying to open the gallery on a device the popup window disappears immediately
What is expected to happen?
Open the gallery and select a picture
What does actually happen?
Gallery popup opens and disappears. It doesn't happen all the time, it's random
Information
Could reproduce it on iPad air 2 with iOS 13.3 by just trying to open a gallery popup.
Command or Code
Xcode throws the following error:
2020-03-02 06:50:12.596351+0100 Checklists[1879:631764] [lifecycle  ] [u 59E5BEF5-A44C-4649-9D69-B840E6B7DCAA:m (null)] [com.apple.mobileslideshow.photo-picker(1.0)] Connection to plugin interrupted while in use.
2020-03-02 06:50:12.598950+0100 Checklists[1879:631941] [lifecycle  ] [u 59E5BEF5-A44C-4649-9D69-B840E6B7DCAA:m (null)] [com.apple.mobileslideshow.photo-picker(1.0)] Connection to plugin invalidated while in use.
2020-03-02 06:50:12.603712+0100 Checklists[1879:630992] viewServiceDidTerminateWithError:: Error Domain=_UIViewServiceInterfaceErrorDomain Code=3 "(null)" UserInfo={Message=Service Connection Interrupted}
2020-03-02 06:50:12.603920+0100 Checklists[1879:630992] [Generic] -[PUPhotoPickerHostViewController viewServiceDidTerminateWithError:] Error Error Domain=_UIViewServiceInterfaceErrorDomain Code=3 "(null)" UserInfo={Message=Service Connection Interrupted}
Environment, Platform, Device
iPad air 2 with iOS 13.3
Version information
Cordova
engine name="ios" spec="~5.0.0"
cordova-plugin-camera

Checklist

[x] I searched for existing GitHub issues
[x] I updated all Cordova tooling to most recent version
[x] I included all the necessary information above

Is this reproducible in a new, plain Cordova app? A minimal reproduction repository would really help to debug and later fix this issue. More information on how to create one: https://github.com/apache/cordova-contribute/blob/master/create-reproduction.md

closing since there was no response and I can't reproduce on my own app

This is not specific to Cordova. I am seeing the same behavior from a native app on an iPhone 11 running iOS 13.6.1. I can't repro with any sim, and not with actual devices running iOS 14.


@swc/wasm delaying process shutdown

Describe the bug
@swc/wasm appears to delay the graceful shutdown of a node process once it's loaded.
Input code
node -e 'require("@swc/wasm"); console.log("done.  Should ideally terminate immediately but is somehow delayed by @swc/wasm")'

The node process remains running for about 5 seconds after the log statement.  I'm not sure if @swc/wasm is setting some sort of timer or why the process is staying up.
Expected behavior
node process gracefully terminates immediately after the log statement.
Version
The version of @swc/wasm: 1.2.45
OS: Ubuntu Linux
node: v14.15.3

I think this may be a wasm problem, wasm needs to be read, loaded and parsed asynchronously, and perhaps this process is not abortable

I think this may be a wasm problem, wasm needs to be read, loaded and parsed asynchronously, and perhaps this process is not abortable

I don't think that is the issue, because I can invoke transformSync to prove that the WASM is executable much earlier.  Also, if it were an issue with async compilation, that would mean that WASM takes a full 5 seconds to load, which I think we can agree seems very wrong.
Here is the updated reproduction.  It uses transformSync, then logs the date.  Then the process waits 5 seconds before terminating, at which point a subsequent process logs the date again.  This shows the magnitude of the delay.
node -e 'console.log(require("@swc/wasm").transformSync("const foo = 123", {})); console.log(new Date)' ; node -e 'console.log(new Date)'

Sample output:
2021-01-23T21:41:57.192Z
2021-01-23T21:42:01.869Z

I don't think that is the issue, because I can invoke transformSync to prove that the WASM is executable much earlier.  Also, if it were an issue with async compilation, that would mean that WASM takes a full 5 seconds to load, which I think we can agree seems very wrong.
Here is the updated reproduction.  It uses transformSync, then logs the date.  Then the process waits 5 seconds before terminating, at which point a subsequent process logs the date again.  This shows the magnitude of the delay.
node -e 'console.log(require("@swc/wasm").transformSync("const foo = 123", {})); console.log(new Date)' ; node -e 'console.log(new Date)'

Sample output:
2021-01-23T21:41:57.192Z
2021-01-23T21:42:01.869Z

It looks like it's been greatly improved in Node.js 18.3.0, so you can try it out.
https://github.com/nodejs/node/issues/36616#issuecomment-1338272684


Feature Request - OnLinkClick() event

Would be nice if there was an OnLinkClick() event callback so we can manually handle links to external docs or web pages in apps that use PDFiumViewer. For example, to open the link in another WPF or WinForms tab/window, which AFAIK the demo does not support.
Seems like a simple thing to add for a fairly common use case?

Good example of this functionality in DevExpress PDF control:
https://documentation.devexpress.com/#WPF/CustomDocument115891

This is already possible. On the PdfRenderer class there is an event LinkClick. If you're using the PdfViewer class, you can access the PdfRenderer class through the Renderer property.
If you handle the click yourself, please make sure to set e.Handled to true to suppress the default handling of the event.


Document global folder setting precedence

Update the nuget settings docs to include that NUGET_PACKAGES takes precedence over nuget.config settings.
See discussion:
https://github.com/NuGet/Home/issues/4810#issuecomment-347665093
https://github.com/NuGet/Home/issues/4810#issuecomment-347629004

Addressed in PR #770


Extend service discovery for multi-zone clusters

Fixes: https://github.com/kubernetes-sigs/federation-v2/issues/678
This PR adds additional zone level DNS record to take care of cross-cluster service discovery in case of multi-zone clusters

@shashidharatd If there is no doc change implied by this PR, that suggests the existing documentation for the feature could use some work.

/lgtm

@shashidharatd If there is no doc change implied by this PR, that suggests the existing documentation for the feature could use some work.
Agree, that the existing docs around the feature needs some more love. Would work on that in near future and thanks for the lgtm.


Fix to support multiple property sources auto refresh

Description
Fix to support multiple property sources auto refresh.
See more from:

https://github.com/Azure/azure-sdk-for-java/issues/26356
https://github.com/Azure/azure-sdk-for-java/issues/36164
https://github.com/Azure-Samples/azure-spring-boot-samples/issues/755

All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Add rusingh.com

Site: rusingh.com
GTmetrix: 500 KB (cutting it close!)

Whoops. Uncompressed is 750 KB. Got work to do. :)


Draw Polygon style not applying correctly

Describe the bug
If I apply a style to Polygon which is yet to be completed, the style is applied to the final and yet undrawn segment - thus making it visible. The style is not applied to the already drawn segments. See these images of two unclosed polygons. The red segment highlights the remaining unclosed part of the polygon.

To Reproduce
Steps to reproduce the behavior:

Draw interaction with a type: Polygon
Apply style after each click interaction (e.g.. line colour red)

Expected behavior
Only the previously drawn segments are styled and the undrawn "closing" segment is invisible.
Question, is there a workaround for this?

You should set the drawing style on the Draw interaction.  The default editing style described in https://openlayers.org/en/latest/apidoc/module-ol_style_Style-Style.html consists of only Fill for an incomplete Polygon geometry and blue stroke for the drawn sketch.  By setting a red stroke for the Polygon you are showing the imcomplete edge while the drawn edges remain hidden by the blue LineString style.  Here is an example updated to use a custom drawing style, and sets the finished style on the feature at the drawend event - as an alternative to doing that you could have the finished style as your layer style.  https://codesandbox.io/s/draw-features-forked-nb9nl?file=/main.js

Thanks @mike-000,
It looks like using the style function is the correct way to update the style whilst drawing. The style function gets called as the shape is drawn so I can validate as I draw.


{Core} Use semver for azure-mgmt-core

Description
Trying to package this for nixpkgs get:
ERROR: No matching distribution found for azure-mgmt-core==1.2.1 (from azure-cli-core==2.15.1)

when it's being given 1.2.2
Azure-sdk generally follows semver. No need to pin.
Testing Guide
History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Core

/azp run


Remove WSD support from 5.x

I propose we remove support for Web Sequence Diagrams from 5.x. WSD is a commercial platforms, and we currently have support for PlantUML already. Keeping multiple UML renderers will increase the maintenance load.

Closed in #261.


../utility/plot_path.py deprecation warning

Dear RAFFT makers,
I encountered some compatibility issues while running plot_path.py with the latest version of Pillow (10.4.0). Since the release of Pillow 10.0.0, the following changes are affecting the script:

Image.ANTIALIAS has been deprecated and replaced by Image.Resampling.LANCZOS. (https://pillow.readthedocs.io/en/stable/releasenotes/10.0.0.html)
FreeTypeFont.getsize() has been deprecated and replaced by FreeTypeFont.getbbox(). (https://pillow.readthedocs.io/en/stable/releasenotes/9.2.0.html)

If you are interested in upgrading plot_path.py for Pillow 10+, below the updates to consider :
Line 60 (add_grad_img) :
draw = ImageDraw.Draw(path_img)
#x_size, y_size = fnt.getsize("{:.1f}".format(max_val)) ## DEPRECATED
bbox = fnt.getbbox("{:.1f}".format(max_val)) # update
x_size, y_size = bbox[2] - bbox[0], bbox[3] - bbox[1] # update

Line 177 (main) :
#cur_str = cur_str.resize((n_fig_w, n_fig_h), Image.ANTIALIAS) ## DEPRECATED
cur_str = cur_str.resize((n_fig_w, n_fig_h), Image.Resampling.LANCZOS) # update

Line 208 (main) :
#cur_str = cur_str.resize((n_fig_w, n_fig_h), Image.ANTIALIAS) ## DEPRECATED
cur_str = cur_str.resize((n_fig_w, n_fig_h),Image.Resampling.LANCZOS) # update

Many thanks for this very nice tool,
Best
AS

Dear SchrammAntoine,
Sorry for the late reply, but thank you for the updates, I introduced them.
Best,
Vaitea


HTTPPollerSource is leaking deployments

The HTTPPollerSource component is leaking deployments.
As reported by @JeffNeff the deployment of an HTTPPollerSource will not be removed after the component is deleted.

I made an issue under 'triggerflow' ... perhaps I should delete that one?


After Updating code from InstanceID to Installation ID, my App is keep on Crashing [FBLPromise HTTPBody]  unrecognized selector sent to instance

After updating my code from InstanceID to Installation my code is keep on crashing with error message
[FBLPromise HTTPBody]: unrecognized selector sent to instance
Code Changes
From: [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(tokenRefreshNotification:)
name:kFIRInstanceIDTokenRefreshNotification object:nil];
To:     [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(tokenRefreshNotification:)
name:FIRMessagingRegistrationTokenRefreshedNotification object:nil];
From
[[FIRMessaging messaging] connectWithCompletion:^(NSError * _Nullable error) {
[[NSNotificationCenter defaultCenter] postNotificationName:FCMCONNECTED object:nil];
if (error != nil) {
NSLog(@"Unable to connect to FCM. %@", error);
} else {
NSLog(@"Connected to FCM.");
}
}];
To:
[[FIRInstallations installations] installationIDWithCompletion:^(NSString *identifier, NSError *error) {
if (error != nil) {
NSLog(@"Error fetching Installation ID %@", error);
return;
}
NSLog(@"Installation ID: %@", identifier);
self->_refreshedTokenString = identifier;
}];
Here is my Pod file for Firebase:
pod 'Firebase/Core'
pod 'Firebase/Messaging'
# Add the pod for Firebase Crashlytics
pod 'Firebase/Crashlytics'

@rizafran
Xcode Version = 12.1
Firebase = Installing Firebase (8.0.0)
iOS Version = 14.1
Is there any thing else you want to know ? I'm stuck over here from long time and tried multiples solution available on internet.
Thanks in Advance

@aleemrazzaq Thank you for the provided details. We haven't been able to reproduce it on our end yet. A sample project where the issue can be reproduced will significantly help the investigation.


favicon

updated favicon text and logo (on the right branch this time)

Added the apple touch and chrome icons
Tidied readme
Updated manifest.json
Hyperlinked logo


docs: update installation command

Refers https://github.com/eslint/eslint/issues/16050
We decided to use npm init @eslint/config.
Not sure if @ is clear in this font.

Hmmm yeah. I wonder if we can just Courier for the “@“ symbol?

I tried with @font-face but wasn't able to make it work 😕
This is how it looks with font-family: var(--display-font):


Code Function img_filter()

write the function body
update the documentation as required
include exception handling
- handles incorrect input and other errors
- the exceptions should have useful error messages
- all exceptions should be tested (ie. included in the function's unit test #21)

Implemented function code, updated documentation, and included exception handling with pr #36


Add admin security and management features

When releasing the image to the docker hub we ignore the .env file which eliminates the saved keys.
We want to add services to update the api default key and the admin default default key from the admin api:
https://github.com/intelligentnode/IntelliServer/blob/main/intelliserver/api/routes/admin.js
Expected changes:

Suggest a suitable approach to persist (store)  the api values.
Update router.put('/api-auth-flag', ..) to persist (store) the received value from the API. This should not contradict with current functionality, so if the user did not update the flag keep reading the .evn or default value. But if the user sets the flag the priority for the persisted (stored) value.
Add a function to update the API key and store the new key securely.
Add a function to update the admin key and store the new key securely.
Add a function to reset the admin settings to default and read the .env values.

This is resolved with simple approach to send the key when running the docker image. Keeping the key management outside the scope of the server, controlled based on each user environment.


refactor(leadspace): reorganize slots

Related Ticket(s)
Refs #4627.
Description
Changes <slot name="buttons"> to <slot name="action"> to align the naming strategy to <dds-cta-section>.
Changelog
Changed

Changes <slot name="buttons"> to <slot name="action">.

@asudoh can you add a note to breaking changes in our pinned issue?

@asudoh can you add a note to breaking changes in our pinned issue?

@jeffchew Done!

@jeffchew Done!


Firewalling between stacks

Rancher Version:
v1.0.1
Docker Version:
1.11.0
I have noticed that there isn't any kind on firewalling in the rancher network. All containers can connect all other containers without restrictions, even across stacks.
I'd like to see some kind of firewalling feature in rancher.
For example connections between stacks should be prohibited by default except for external_links.
Also connections inside the stacks should be prohibited unless explicitly opened by linking the services.
Firewalling could be also extended to public ports, allowing connections only from predefined IPs.

https://github.com/rancher/rancher/issues/3895


feat: 1ES Migration for Image Build Pipeline

Reason for Change:
Migration to 1ES

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.00%. Comparing base (b65dd2e) to head (1d26fee).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   61.09%   60.00%   -1.09%
==========================================
  Files          29       29
  Lines        2303     2403     +100
==========================================
+ Hits         1407     1442      +35
- Misses        828      887      +59
- Partials       68       74       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Chaos 5555 review

Doc review
Fault image

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: SahilKr24:white_check_mark: SmritiSatya:x: ispeakc0deYou have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://665e05084dcb482bea131aec--harness-developer.netlify.app


Menu items are sometimes excluded when being generated

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.83.1+extended linux/amd64 BuildDate=unknown

Does this issue reproduce with the latest release?
yes
Here's a recording of the repro. Essentially menu items are inconsistently included in the generation (including server command).
https://user-images.githubusercontent.com/16726210/119271679-64d4a980-bbb7-11eb-9bcb-1ca9a05a5414.mp4
Source code: https://github.com/binhonglee/blog
Specifically config.toml which has menu defined and the theme partial where .Site.Menu.main is referenced.

1. If you can build Hugo from source, please test again with https://github.com/gohugoio/hugo/commit/785a31b5b84643f4769f9bd363599cbcce86f098 or later.
2. Please provide a minimal reproducible example. Videos can be helpful to demonstrate a problem, but more is required to identify the cause.

In your config.toml file, change:
[Menu]

to
[menu]

Do the same with the other tables in your configuration.


Add maxLines parameter to FlowRow

Our team is looking forward to move from Android/IOS views to compose. Currently we have custom FlowRow views for each platform. Compose's FlowRow seems to have what we need except for maxLines setting. For now I just copypasted huge amount of FlowLayout code to implement this feature, but I want to see this option in upstream. I've checked https://github.com/JetBrains/compose-multiplatform-core repo and README.md and CONTRIBUTING.md say that compose/foundation folder is not the one to be contributed to via GitHub. However this comes from original androidx repo so I'm unsure whether this applies to compose-multiplatform-core
TLDR: Please help me understand what should I do to get maxLines implemented in upstream FlowRow (whether by myself or by someone from jb/google compose teams)

As it seems to be general enhancement that affects Jetpack Compose too, I would recommend to contribute it directly to AndroidX repository or create the same enhancement in Jetpack Compose issue tracker and discuss it there with the Google team.
Once it appears in Jetpack Compose, it will be merged to Compose Multiplatform as well one day.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


fix test_human_input

Why are these changes needed?
Fix test failure: https://github.com/microsoft/autogen/pull/2005#issuecomment-2004614796
Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.75%. Comparing base (ca506ba) to head (f21d6bb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2063      +/-   ##
==========================================
- Coverage   36.79%   34.75%   -2.04%
==========================================
  Files          66       66
  Lines        7060     7060
  Branches     1541     1541
==========================================
- Hits         2598     2454     -144
- Misses       4234     4390     +156
+ Partials      228      216      -12

Flag
Coverage Δ

unittests
34.75% <ø> (-2.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

it's still not clear to me how this test was passing before


module 'tensorflow_addons' has no attribute 'optimizers' (tfa-nightly)

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): MacOs M1 (12.0 Beta Monterey)
TensorFlow version and how it was installed (source or binary): 2.5.0 (pip)
TensorFlow-Addons version and how it was installed (source or binary): tfa-nightly 0.15.0 (pip)
Python version: 3.8
Is GPU used? (yes/no): NA

Describe the bug
After installing from nightly version, I got an error module 'tensorflow_addons' has no attribute 'optimizers'
Code to reproduce the issue
import tensorflow_addons as tfa
...
radam = tfa.optimizers.RectifiedAdam(lr=cf["lr"], clipnorm=clipnorm)
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

Hi @MR-T77
I tried to reproduce it:

tensorflow-cpu          2.5.0
tfa-nightly             0.15.0.dev20210922190150
Ubuntu 20.04.1 LTS

Everything seems to be ok.
Please check if you can run the following code:
import tensorflow_addons as tfa
print(tfa)
print(tfa.optimizers)
print(tfa.optimizers.RectifiedAdam)

What does it return?
If you're still getting an error then please attach the output from pip freeze.

Hi @szutenberg!
It seems something was broken with my conda environment (I tried so many things...). I uninstalled tensorflow-addons (0.14) and reinstalled tfa-nightly, and now I can import tfa without error. Just to be sure: whenever I update something on a conda environment, I immediately run code on top of it, I don't restart terminal or vscode (I'm not sure this is the best process or if I should restart something).
Nevertheless, although I can import addons, I cannot use them, I always get the following error (tried with other optimizers too but I get the same error):
Traceback (most recent call last):
  File "/Users/machine/miniforge3/envs/tf/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/Users/machine/miniforge3/envs/tf/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/Users/machine/.vscode/extensions/ms-python.python-2021.9.1246542782/pythonFiles/lib/python/debugpy/__main__.py", line 45, in <module>
    cli.main()
  File "/Users/machine/.vscode/extensions/ms-python.python-2021.9.1246542782/pythonFiles/lib/python/debugpy/../debugpy/server/cli.py", line 444, in main
    run()
  File "/Users/machine/.vscode/extensions/ms-python.python-2021.9.1246542782/pythonFiles/lib/python/debugpy/../debugpy/server/cli.py", line 285, in run_file
    runpy.run_path(target_as_str, run_name=compat.force_str("__main__"))
  File "/Users/machine/miniforge3/envs/tf/lib/python3.9/runpy.py", line 268, in run_path
    return _run_module_code(code, init_globals, run_name,
  File "/Users/machine/miniforge3/envs/tf/lib/python3.9/runpy.py", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/Users/machine/miniforge3/envs/tf/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/Users/machine/Projects/finetune-asp/src/ISMIR2020_v2.py", line 471, in <module>
    main()
  File "/Users/machine/Projects/finetune-asp/src/ISMIR2020_v2.py", line 466, in main
    new_train(dataset, 'TCNv2', cpu=False, addons=True)
  File "/Users/machine/Projects/finetune-asp/src/ISMIR2020_v2.py", line 329, in new_train
    history = model.fit(train, steps_per_epoch=len(train), epochs=cf["num_epochs"], shuffle=True,
  File "/Users/machine/miniforge3/envs/tf/lib/python3.9/site-packages/tensorflow/python/keras/engine/training.py", line 1183, in fit
    tmp_logs = self.train_function(iterator)
  File "/Users/machine/miniforge3/envs/tf/lib/python3.9/site-packages/tensorflow/python/eager/def_function.py", line 889, in __call__
    result = self._call(*args, **kwds)
  File "/Users/machine/miniforge3/envs/tf/lib/python3.9/site-packages/tensorflow/python/eager/def_function.py", line 950, in _call
    return self._stateless_fn(*args, **kwds)
  File "/Users/machine/miniforge3/envs/tf/lib/python3.9/site-packages/tensorflow/python/eager/function.py", line 3023, in __call__
    return graph_function._call_flat(
  File "/Users/machine/miniforge3/envs/tf/lib/python3.9/site-packages/tensorflow/python/eager/function.py", line 1960, in _call_flat
    return self._build_call_outputs(self._inference_function.call(
  File "/Users/machine/miniforge3/envs/tf/lib/python3.9/site-packages/tensorflow/python/eager/function.py", line 591, in call
    outputs = execute.execute(
  File "/Users/machine/miniforge3/envs/tf/lib/python3.9/site-packages/tensorflow/python/eager/execute.py", line 59, in quick_execute
    tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name,
tensorflow.python.framework.errors_impl.InvalidArgumentError: Cannot assign a device for operation model/conv_1_3x3_conv/Conv2D/ReadVariableOp: Could not satisfy explicit device specification '' because the node {{colocation_node model/conv_1_3x3_conv/Conv2D/ReadVariableOp}} was colocated with a group of nodes that required incompatible device '/job:localhost/replica:0/task:0/device:GPU:0'. All available devices [/job:localhost/replica:0/task:0/device:CPU:0, /job:localhost/replica:0/task:0/device:GPU:0].

@MR-T77 It looks that there are no issues with TFA but there are missing GPU kernels which breaks collocation.
You need to check what types do you use with Equal, Mul and FloorDiv. You can dump graphs (TF_DUMP_GRAPH_PREFIX + turn on vlog) and check it in pbtxt file.

@szutenberg I'm a newbie on this type of things, sorry. Could you please point me to more detailed description of what I need to do? Thanks in advance

Also, I'm not using any custom code here. It's a simple BLSTM (3-layer keras Bidirectional(simpleRNN) with a dense output)

@MR-T77 maybe the easiest would be to provide the code so that we can reproduce it locally.
İf you want to debug it on your own then set TF_CPP_MAX_VLOG_LEVEL to 10, and TF_DUMP_GRAPH_PREFİX=tmp. You should see tmp dir after running the script. Reading placer_input.pbtxt will answer to my question (simply grep -A 20 -rn FloorDiv). You'll see dtypes.
Anyway I'm traveling now so I'm not able to help you further until ~12th October.

@szutenberg thank you so much for your availability to help! I'll try to understand what's wrong until 12th October. If I'm unsuccessful, I'll contact again.

Have you already tried with https://www.tensorflow.org/api_docs/python/tf/config/set_soft_device_placement ?

@szutenberg Could it be a side effect of your introduced var.device?

Have you already tried with https://www.tensorflow.org/api_docs/python/tf/config/set_soft_device_placement ?

Yes, it's there in the code: "tf.config.set_soft_device_placement(True)"

@MR-T77 Yes sorry I missed, is that your code is not well formatted.

Hi @MR-T77 ,
I'm sorry but it seems that one more file is missing: definitions.py
Traceback (most recent call last):   File "problem_TCN.py", line 183, in <module>     simple_TCN(dataset)   File "problem_TCN.py", line 135, in simple_TCN     train_db = pickle.load(open('%s.pkl' % (dataset), 'rb')) ModuleNotFoundError: No module named 'definitions'
Could you make sure that it reproduces on google colab?

Hi @szutenberg,
I'm so sorry for that, the pickle file was saved in a module definitions.py, that's why it is requesting that file, although it does not need it.
I re-saved the pickle in "main", and I attach it as well as a more complete problem_TCN.py.
[traintest_smallsmc.pkl.zip](https://github.com/tensorflow/addons/files/7363832/traintest_smallsmc.pkl.zip
problem_TCN.py.zip
)

Hi @MR-T77 ,
Unfortunately now I have another error: AttributeError: Can't get attribute 'Dataset' on <module '__main__' from 'problem_TCN.py'>
Could you please prepare google colab which demonstrates your problem? Note that you don't need to provide real data - dummy training data is enough: you just need to make sure that shapes match.
Thanks!

Ok, I'm back to this after a while.
So, I've been getting spurious errors while doing model.fit with the Lookahead optimizer (I'm doing fine-tuning with big datasets, and my code just breaks while fitting to different files, and in a not-reproducible way, i.e. each time I run it it breaks on a different file, and on different operations).
I can see that these errors are undoubtedly related to the Lookahead optimizer.
Let me try to explain this new info in a clear manner.
I've tried with 2 different versions of tf+tfaddons (conda environments), but I got the same type of errors, probably more frequent with the pylast conda environment:

pylast:tensorflow-macos 2.9.0, tensorflow-metal 0.5.0, tensorflow-addons 0.17.0
py39deps26-source: tensorflow-macos 2.6.0, tensorflow-metal 0.2.0, tensorflow-addons 0.15.0.dev0

The base code is always the same, I use tf.config.set_soft_device_placement(True) and also with tf.device('/cpu:0'): in every call to tensorflow, otherwise I get errors. As explained before, in my code, I just load a model, and fine-tune it to each file of a dataset.
Here are a pair of example error outputs (obtained with the pylast conda environment):
File "/Users/machine/Projects/finetune-asp/src/finetune_IMR2020.py", line 138, in finetune_dataset_db
    history = model.fit(ft, steps_per_epoch=len(ft), epochs=ft_cfg["num_epochs"], shuffle=True,
  File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/utils/traceback_utils.py", line 67, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/tensorflow/python/eager/execute.py", line 54, in quick_execute
    tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name,
tensorflow.python.framework.errors_impl.InvalidArgumentError: Graph execution error:

Detected at node 'Lookahead/Lookahead/update_64/mul_11' defined at (most recent call last):

    File "/Users/machine/Projects/finetune-asp/src/finetune_IMR2020.py", line 138, in finetune_dataset_db
      history = model.fit(ft, steps_per_epoch=len(ft), epochs=ft_cfg["num_epochs"], shuffle=True,
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/utils/traceback_utils.py", line 64, in error_handler
      return fn(*args, **kwargs)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/engine/training.py", line 1409, in fit
      tmp_logs = self.train_function(iterator)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/engine/training.py", line 1051, in train_function
      return step_function(self, iterator)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/engine/training.py", line 1040, in step_function
      outputs = model.distribute_strategy.run(run_step, args=(data,))
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/engine/training.py", line 1030, in run_step
      outputs = model.train_step(data)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/engine/training.py", line 893, in train_step
      self.optimizer.minimize(loss, self.trainable_variables, tape=tape)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/optimizers/optimizer_v2/optimizer_v2.py", line 539, in minimize
      return self.apply_gradients(grads_and_vars, name=name)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/tensorflow_addons/optimizers/lookahead.py", line 104, in apply_gradients
      return super().apply_gradients(grads_and_vars, name, **kwargs)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/optimizers/optimizer_v2/optimizer_v2.py", line 678, in apply_gradients
      return tf.__internal__.distribute.interim.maybe_merge_call(
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/optimizers/optimizer_v2/optimizer_v2.py", line 723, in _distributed_apply
      update_op = distribution.extended.update(
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/optimizers/optimizer_v2/optimizer_v2.py", line 706, in apply_grad_to_update_var
      update_op = self._resource_apply_dense(grad, var, **apply_kwargs)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/tensorflow_addons/optimizers/lookahead.py", line 130, in _resource_apply_dense
      train_op = self._optimizer._resource_apply_dense(
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/tensorflow_addons/optimizers/rectified_adam.py", line 249, in _resource_apply_dense
      coef["r_t"] * m_corr_t / (v_corr_t + coef["epsilon_t"]),
Node: 'Lookahead/Lookahead/update_64/mul_11'
Incompatible shapes: [0] vs. [5,40,20]
	 [[{{node Lookahead/Lookahead/update_64/mul_11}}]] [Op:__inference_train_function_30821]

and
File "/Users/machine/Projects/finetune-asp/src/finetune_IMR2020.py", line 138, in finetune_dataset_db
    history = model.fit(ft, steps_per_epoch=len(ft), epochs=ft_cfg["num_epochs"], shuffle=True,
  File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/utils/traceback_utils.py", line 67, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/tensorflow/python/eager/execute.py", line 54, in quick_execute
    tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name,
tensorflow.python.framework.errors_impl.InvalidArgumentError: Graph execution error:

Detected at node 'Lookahead/Lookahead/update_26/mul_11' defined at (most recent call last):

    File "/Users/machine/Projects/finetune-asp/src/finetune_IMR2020.py", line 138, in finetune_dataset_db
      history = model.fit(ft, steps_per_epoch=len(ft), epochs=ft_cfg["num_epochs"], shuffle=True,
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/utils/traceback_utils.py", line 64, in error_handler
      return fn(*args, **kwargs)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/engine/training.py", line 1409, in fit
      tmp_logs = self.train_function(iterator)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/engine/training.py", line 1051, in train_function
      return step_function(self, iterator)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/engine/training.py", line 1040, in step_function
      outputs = model.distribute_strategy.run(run_step, args=(data,))
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/engine/training.py", line 1030, in run_step
      outputs = model.train_step(data)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/engine/training.py", line 893, in train_step
      self.optimizer.minimize(loss, self.trainable_variables, tape=tape)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/optimizers/optimizer_v2/optimizer_v2.py", line 539, in minimize
      return self.apply_gradients(grads_and_vars, name=name)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/tensorflow_addons/optimizers/lookahead.py", line 104, in apply_gradients
      return super().apply_gradients(grads_and_vars, name, **kwargs)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/optimizers/optimizer_v2/optimizer_v2.py", line 678, in apply_gradients
      return tf.__internal__.distribute.interim.maybe_merge_call(
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/optimizers/optimizer_v2/optimizer_v2.py", line 723, in _distributed_apply
      update_op = distribution.extended.update(
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/keras/optimizers/optimizer_v2/optimizer_v2.py", line 706, in apply_grad_to_update_var
      update_op = self._resource_apply_dense(grad, var, **apply_kwargs)
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/tensorflow_addons/optimizers/lookahead.py", line 130, in _resource_apply_dense
      train_op = self._optimizer._resource_apply_dense(
    File "/Users/machine/miniforge3/envs/pylast/lib/python3.9/site-packages/tensorflow_addons/optimizers/rectified_adam.py", line 249, in _resource_apply_dense
      coef["r_t"] * m_corr_t / (v_corr_t + coef["epsilon_t"]),
Node: 'Lookahead/Lookahead/update_26/mul_11'
Incompatible shapes: [0] vs. [1,40,20]
	 [[{{node Lookahead/Lookahead/update_26/mul_11}}]] [Op:__inference_train_function_1406468]

@MR-T77 Just to be sure that it is reproducible on an environment under control with linux can you test the same with Docker + TFA pip:
https://www.tensorflow.org/install/docker
So that we could exclude that is related only to tensorflow-macos.

@MR-T77 Just to be sure that it is reproducible on an environment under control with linux can you test the same with Docker + TFA pip:
https://www.tensorflow.org/install/docker
So that we could exclude that is related only to tensorflow-macos.

I'm afraid I can't really help. Installed Docker and tried to pull latest tensorflow and got this error
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested The TensorFlow library was compiled to use AVX instructions, but these aren't available on your machine. qemu: uncaught target signal 6 (Aborted) - core dumped

Yes probably they still not have added avx emulation support in QEMU for m1 or it is a  Docker specific issue on m1 like https://github.com/docker/for-mac/issues/6111.
If you can isolate the case and reproduce your error with a minimal code (e.g. like a test) we could try to run it on linux.
As tensorflow-macos and tensorflow-metal are closed source packages we cannot do anything here in the case we cannot reproduce on another platform.

Well, I was just trying to provide further details, to see if it would help.
The code I sent in October generates this bug, but it seems it only happens when using Lookahead in M1.

Ok try to post also on https://developer.apple.com/forums/tags/tensorflow-metal

Just to keep this info updated: I have a github repo with a stripped down version of my code (with the needed audio data) that does reproduce the issue (in a Mac M1). I also shared this with Apple, but unfortunately, they're not very responsive.

@MR-T77 maybe the easiest would be to provide the code so that we can reproduce it locally.
İf you want to debug it on your own then set TF_CPP_MAX_VLOG_LEVEL to 10, and TF_DUMP_GRAPH_PREFİX=tmp. You should see tmp dir after running the script. Reading placer_input.pbtxt will answer to my question (simply grep -A 20 -rn FloorDiv). You'll see dtypes.
Anyway I'm traveling now so I'm not able to help you further until ~12th October.

Hi again, I'm back at this as the problem remains (and it's even more frequent after I updated the conda environment), and Apple Developer Forums are not responding.
I was trying to generate some debug info (to see if I could figure out some way out of this), but I can't generate the pbtxt file.
I'm using this code:
from network_definitions import *
import tensorflow as tf

os.environ["TF_CPP_MIN_LOG_LEVEL"] = "10"
os.environ["TF_DUMP_GRAPH_PREFIX"] = 'tbdump'
#os.environ["XLA_FLAGS"] = "--xla_dump_to=/tbdump/generated"
tf.debugging.set_log_device_placement(False)
tf.config.set_soft_device_placement(True)
tf.debugging.experimental.enable_dump_debug_info(
    './tbdump',
    tensor_debug_mode="FULL_HEALTH",
    circular_buffer_size=-1)

if __name__ == "__main__":

    big_dataset = 'gtzan'
    small_dataset = 'traintest_smallsmc'
    dataset = big_dataset
    # data_aug='NODAUG'# to run without data augmentation
    finetune_db(dataset, data_aug='DAUG', load_pkl=True)

but after starting tensorboard --logdir /tbdump and accessing tensorboard on localhost, I always get the message "Debugger V2 is inactive because no data is available."
I can see that in tbdump folder there are being created the following type of files, but no pbtxt file:

tfdbg_events.xxx...xxx.graphs
tfdbg_events.xxx...xxx.source_files
tfdbg_events.xxx...xxx.execution
tfdbg_events.xxx...xxx.stack_frames
tfdbg_events.xxx...xxx.graph_execution_traces
tfdbg_events.xxx...xxx.metadata

Any idea on how to make this work?
This code and the needed data (as well as the pip freeze info is available at this github repo

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down
Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP


Unable to install monitoring charts as the CRDs are not getting installed.

While trying to migrate monitoring charts to be installed via operator (using template operator as an example ) we are facing currently an issue where the installation of charts is failing because CRDs required are not getting installed. The CRDs have been provided in the module-chart folder.
The operator while installing the charts throws following error message:
1.6675521909190896e+09	ERROR	error while installing resource default/monitoring-sample	{"controller": "monitoring", "controllerGroup": "operator.kyma-project.io", "controllerKind": "Monitoring", "Monitoring": {"name":"monitoring-sample","namespace":"default"}, "namespace": "default", "name": "monitoring-sample", "reconcileID": "dce9a363-90b6-4b71-8958-1999492dbb36", "error": "unable to build kubernetes objects from release manifest: [resource mapping not found for name: \"bar-custom-name-override-alertmanager\" namespace: \"kyma-system\" from \"\": no matches for kind \"Alertmanager\" in version \"monitoring.coreos.com/v1\"\nensure CRDs are installed first,

Troubleshooting

The k3d cluster has no CRDs from the monitoring chart installed even after the monitoring operator is trying to install monitoring charts.
When tried to install the same module-chart folder using helm client on and empty k3d cluster it would successfully install the  monitoring CRDs.
Debugging using the debugger shows error messages originating in helm client at here

The code can be found here

Verified as critical bug, Helm Charts with crds folder have their CRDs not installed and ignored due to our custom installation process and a regression that doesn't include the CRDs within the cached manifest. We will work on this with high priority and let you know once a fix is available.

/kind bug

I tried to install monitoring charts using module manager images from PR-180 and PR-189 but I still see the above error message again. So reopening the issue.

Waiting for feedback after providing a few hints async of this ticket. Please write if you still face issues here and We will put It back into progress. For now it will stay open until you provider further input.


Code HTML for User Input Dropdowns

Create user input dropdown using HTML and Bulma CSS framework

Dropdown Topics
Energy, Situation, Mood

completed successfully


Fixes race condition caused by billing client dereference

This needs more work. Reading the documentation for the iap library v3, I realized that we should guard the existence of the client instead of creating a new one when needed. This was likely implemented as such catering to older versions of t he SDK

@andresesfm Is this ready for review?

Hi, thank you @andresesfm nice catch ! I'm stuck on Android for all the tests related to purchasing (ios pass the tests (highfive) ) ;) @hyochan Hope you can review and validate the PR as soon as possible. Thank you for your time !


how to use perform_action

perform_action(self, WindowHandle::WindowAction.Close)

You could iterate over all toplevel windows as in the example get_window_infos.rs, filter any windows you like and then call perform_action on them.

@rkarp associated function perform_action is private
I want to close the specified window with one click
use std::io;
use winapi_easy::ui::{Rectangle, WindowHandle, WindowShowState};
#[derive(Debug)]
struct WindowInfo {
    caption: String,
    class_name: String,
    show_state: WindowShowState,
    restored_position: Rectangle,
}
pub fn run() -> io::Result<()> {
    WindowHandle::get_toplevel_windows()?
        .into_iter()
        .filter(|window| match window.get_class_name() {
            Ok(class_name) => class_name == "CabinetWClass",
            Err(_) => false,
        })
        .map(|window| {
            // window.perform_action();
            let placement = window.get_placement()?;
            Ok(WindowInfo {
                caption: window.get_caption_text(),
                class_name: window.get_class_name()?,
                show_state: placement.get_show_state().unwrap(),
                restored_position: placement.get_restored_position(),
            })
        });
    // .try_for_each(|info: io::Result<WindowInfo>| -> io::Result<()> {
    //     println!("{:#?}", info?);
    //     Ok(())
    // })?;
    Ok(())
}

@shijunti19
I remember now, this API wasn't quite ready yet since not all possible commands are implemented. But with non-exhaustive enums, it should be extensible. I've changed the names (e.g. send_command) and made the items public on master.


Redpajama 1t sample dataset issue.

hello
longlora has been a great inspiration to me.
I tried to reproduce longlora in my environment.
The redpajama 1t was too large for me, so I tried to test it using the redpajama 1t sample.
The radpajama dataset has a total of 930,514 items,
dataset = dataset.map(partial(tokenize_fn,tokenizer),batched=True, num_proc=128, remove_columns=["text", "meta"])
Afterwards, I thought that the output of the dataset should be the same, 930,514 cases.
But I
DatasetDict({
train: Dataset({
features: ['input_ids'],
num_rows: 84590
})
})
I got results.
Can I check if this result is wrong or just a result of batched=True in dataset.map?
I would really appreciate it if you could help me with an answer.

After several tests, we confirmed that this was the result of batch=True.
Thanks for your help.

Great. I will close this issue as it has been solved. Please feel free to re-open it if there are any others to discuss.


fix(runtime): 🐛  Remove another occurence of using RuntimeError

What is the purpose of this Pull Request?
See Changesets for details.
Type of this Pull Request

🐛 Bug fix

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

35 of 35 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 95.906%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
3249

Relevant Lines:
3345

💛  - Coveralls


Install fbthrift

Thrift library is required for the new native Parquet reader. This
commit installs fbthrift for Velox.

Note: I don't seem to have permission to create an archive snapshot of fbthrift in github, so I directly included the installation block in ()  in setup-circleci.sh:
+(
+  git clone https://github.com/facebook/fbthrift &&
+  cd fbthrift &&
+  git checkout $FB_OS_VERSION &&
+  cd build &&
+  cmake -DCMAKE_CXX_FLAGS="$COMPILER_FLAGS" -DBUILD_TESTS=OFF .. &&
+  make "-j$(nproc)" &&
+  make install
+)

@kgpai @mshang816 do you have permission to do that? Or is it ok to use the code in ()  block?

Hi Ying,
Just saw this, apart from the points that @Yuhta  raises. Installing of fbthrift (or apache-thrift) isnt required for VELOX MINIMAL. Both these libraries must only be installed if parquet is required and we shouldnt enforce installation of this for torcharrow etc.
I think something similar to S3 dependencies can be done and have these gated only for PARQUET .

@kgpai @Yuhta Thank you very much for your valuable feedbacks. The Thrift lib for Parquet reader doesn't have to be fbthrift, and apache thrift would also work. I just copied the fbthrift installation from presto_cpp library. I'll update this PR with your dependency comments addressed.

Hi Ying, Just saw this, apart from the points that @Yuhta raises. Installing of fbthrift (or apache-thrift) isnt required for VELOX MINIMAL. Both these libraries must only be installed if parquet is required and we shouldnt enforce installation of this for torcharrow etc. I think something similar to S3 dependencies can be done and have these gated only for PARQUET .

@kgpai Hi Krishna, I'm not sure if this is possible. The set up script would be ran before calling make. The user can set VELOX_BUILD_MINIMAL to true after running setup-macos.sh and then run make. Did you mean to make CMake install these dependencies? Shall we make apache/thrift as a submodule instead?

No longer needed as Arrow would include thrift


Restructure frontend and setup navigation

Restructuring the frontend to have the right directory layout. I also updated some things like README, package.json, tsconfig, webpack config, and added routes / navigation.
Most of this reflects how model registry is set up.

/lgtm thank you so much Griffin! Let's move forward and work on the next PR

/lgtm

@Griffin-Sullivan @ederign I think something about what you changed requires the front end test GitHub workflow to be updated:

https://github.com/kubeflow/notebooks/blob/notebooks-v2/.github/workflows/ui-frontend-build.yml

It's probably best if we try and get it to pass before merging, unless you have already started another PR based on this one.

Do I need to become a member of Kubeflow for the workflow to run without approval?

Do I need to become a member of Kubeflow for the workflow to run without approval?

@Griffin-Sullivan, no once you get your first PR merged on the repo it will be fine.

apparently no tests == fail..... I'll add back the Jest test I removed and then re-remove when I add Cypress in the next PR.

@Griffin-Sullivan it looks like the CI is still failing, cant you just add a nothing test, and ensure that all the other steps in the GitHub workflow succeed?
That will make it easier when we add new tests.

I could but I see that as pointless work when I could just fix the github action. Looks like I accidentally removed an npm command that should've stayed.

Ok fairly confident in this one :laughing:

@Griffin-Sullivan we can merge this for now, but please remember to re-add the test call in the github action in your next PR, otherwise we will probably forget.
/lgtm
/approve


Create a model linting module

This simple enhancer would check for each element some useful things

An element must have a description set
A container/component must have a technology set
A relationship must have a description set
A relationship should have a technology set (as well as an interaction style)

We should see with Simon Brown what would be interesting, and we should get more ideas from https://c4model.com/bingo/

An element and relationship have a technology string or a description. I don't understand the point of set.
Also, should I return a logger.error when they are missing?

When things are ok, there is no need to log anything

See also https://github.com/neuland/assertj-logging (which would need a java.util.logging implementation)

This Stackoverflow answer may help https://stackoverflow.com/a/1834789/15619


[Feature Request] Slider support for label formatting.

First of - thanks for this awesome library! It's a lot of fun to work with and it really improves the look of the Dash Apps it is used with 😃.
I have a feature request to add support for label formatting on slider elements, e.g., 40 °C for values of 40.
Background
This is supported in Mantine (see https://mantine.dev/core/slider/#control-label) and would be great to have in dmc. The docs hint at this being implemented already with the label argument (Function to generate label or any react node to render instead, set to None to disable label.), but I couldn't get it to work or find an example that explains this.
What I've tried
I guess from Python the most straight-forward way to implement this would be to support passing functions to the label argument of the Slider constructor. Currently, passing label=lambda x: x raises an Error loading layout error.
Thanks!

Hi @paulremo
Unfortunately, there is no easy solution or workaround for this one.
By default, Dash does not allow for passing functions as props.  I would love to implement a solution similar to how it's done with Dash AG Grid
I'll update the feature request to a broader request: Allow functions as props in Dash. This feature would be a great addition to  dash-mantine-components, as many of Mantine's components accept functions as props


Plot App: Added selector using React grid layout

This Pull request consists of resolving following 2 issues:

Configuring selector from config file to fetch data:

Currently, only one selector can be added, which will be presented as a dropdown menu. The data for this selector can either be sourced from a data array provided in the config file of plot app.

Configuring grid layout for selector from config file to decide the placement of the selector:

The primary objective of this task revolves around defining the properties related to grid layout configuration, as specified in issue #156. The grid_layout_config is an object designed to configure the "grid" component sourced from the ReactGridLayout library. Currently, our focus is on enabling layout customization within an individual plot (specifically, plots[0].grid_layout_config). Subsequently, we aim to expand this functionality to encompass a broader "global layout," enabling configuration of both selectors and plots within the grid as an enhancement.

Resolves :  https://github.com/informatics-isi-edu/deriva-webapps/issues/172
In Progress : https://github.com/informatics-isi-edu/deriva-webapps/issues/161

The variable names and types in the code should be general for the objects in the user_controls array. Please change names so that they aren't "selector specific" when they don't need to be. (for example, SelectorConfig => ControlConfig)


Remove ExperimentalDataPrefetch from system console

Summary
Removing the section about data prefetch from docs
Ticket Link
https://mattermost.atlassian.net/browse/MM-27989

@amyblais @justinegeffen how do we normally deal with config removes in the docs?

@esethna This PR looks good to me. I can then later add a note to changelog, upgrade notes, and deprecation webpage when we know which release this is going to.

Thanks for raising that, @esethna. I approved the deletion but should also have confirmed with Amy whether it needs to remain in the doc with a deprecation note as opposed to being deleted. Thanks for confirming, @amyblais. Going forward, is this the right process or should a note be added instead of the content being removed entirely?

@justinegeffen Ah yes, that makes sense. I think adding a deprecation note instead of removing the content completely sounds better. We can work on it when we know which release this will happen in.

I've re-added the content and we can add a deprecation note similar to the others in this doc once we know which release it's going out in.

Since it's missed 5.30, this'll be going out in 5.31 then. I can take over these PRs to finish them up

Changed the milestone and label for now so it doesn't go out with this release inadvertently.


kubefirst cli does not return on my mac

Which version of kubefirst are you using?
v2.3.5
Which cloud provider?
AWS
Which DNS?
Cloud ones (default)
Which installation type?
CLI
Which distributed Git provider?
GitHub
Which Operating System?
macOS
What is the issue?
If I run any command with kubefirst , e.g. kubefirst --help, the command call seems to not return / finish. Basically the cursor does not appear again even after the command has finished.
I have to us  +c to return.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for reporting, and so sorry about that @frank-bee. It has been fixed, but not released yet https://github.com/kubefirst/kubefirst/issues/1883 . We will release soon. For now, you can CTRL+C as you did, and it will have no effect on the command, just terminated it as it should.

If you ping me on our Slack community (I'm Fred), or send me an email at<EMAIL_ADDRESS>I would like to send you some swag as a small gesture to thank you for reporting this problem, and to apologize for the issue!

that was a quick reply... thanks @fharper
To slack com. I anyway wanted to connect ... one sec


Demos

Hello, What folder are demos going to? I think I saw somewhere it went into the folder "MatchZy". But mine is empty

Hey!
It should go in the "MatchZy" folder by default. Make sure that you have CSTV (tv_enable 1) on your server.
Thanks!


Don't give up when encountering lines/points/... in collision mesh data

Motivation and Context
Instead just skipping them. See this Slack thread for background info.
As this makes the isMeshPrimitiveValid() check obsolete, I removed the whole implementation of it (which, after all, was just a very verbose way to print the mesh primitive name originating back in the days when Habitat used glog and thus couldn't just call Magnum's builtin output operator for MeshPrimitive). Furthermore, a call to this function was also the only reason why addStage() too the collision mesh group parameter, so I removed it from there as well. Which is a documentation TODO:

[ ] The addStage() docs probably need to be updated as they mention collision data that are no longer passed there. I don't know what should be said there, tho.

The check is now moved to inside constructBulletSceneFromMeshes(), where it just skips unsupported primitives with a warning. If the code could access the originating Magnum Trade::MeshData instead of
CollisionMeshData, it could be easily extended to support also triangle fans and triangle strips (since there's a MeshTools utility for converting them to triangle lists), but right now it skips those as well.
Also contains a drive-by fix for viewer --help output and use of a deprecated Magnum API.
How Has This Been Tested
:warning: I have no idea what am I doing! The viewer doesn't assert for me anymore, but I don't know anything about the physics code, how it should / should not behave, and how to verify if the collision mesh is indeed generated correctly. So please test and give feedback. Making the PR as a draft due to that reason (and due to the doc TODO above).

Hey @mosra @aclegg3 , I just noticed that even though these changes are allowing the scenes to be loaded, the navmesh construction is still faulty.
I have identified a list of (at least) 28 scenes with this issue. Here are scene IDs of two of those: 102816627, 102344403. The habitat-viewer's navmesh visualization for these scenes shows how the navmesh is being created for some non-existent surfaces on the ceiling (and almost nothing for the actual floor):

This should be easy to reproduce using the habitat-viewer with the main branch:
./build/viewer --enable-physics --stage-requires-lighting --recompute-navmesh --dataset /path/to/hab-fp.scene_dataset_config.json -- 102816627

As I said above,

:warning: I have no idea what am I doing

unfortunately I know too little about this area of the codebase to be able to understand what's going on :sweat_smile: I only made a best-intention attempt to not discard everything when some of the meshes are not triangles, and that part, to my understanding, should be working. If it means some new meshes, which were completely skipped before, are now showing up in the navmesh generation, there's possibly some additional problem. But also I may have overlooked something important that the original code was doing and that the new code isn't anymore, which is why I'm deferring to people who actually know the navmesh generation code, such as Alex.
Scenes that loaded correctly before are loading correctly now as well? Or neither that? Do you see any

Unsupported collision mesh primitive , skipping

messages in the output for the scenes that load wrong?

Thanks @mosra.

Scenes that loaded correctly before are loading correctly now as well?

Yes!

Do you see any "Unsupported collision mesh primitive , skipping" messages in the output for the scenes that load wrong?

Yes, I do.

Hey @mosra @aclegg3 , I just noticed that even though these changes are allowing the scenes to be loaded, the navmesh construction is still faulty.
...

Sorry for the long delay here.
I've investigated the issue and confirmed that this bug is related to the interpretation of the non-triangle mesh components by the navmesh computation code. My hypothesis is that recast voxelization assumes triangles, so the indices are getting clobbered resulting in artifacts.
Quick fix is to again filter by primitive during the mesh join phase of navmesh re-computation. See PR #1951. Try this out and see if it works.


Image Problem

What was the image size should be?
Sometime I am getting error on Image size,

I didn't set any validation on the image size. I guess something small like 500x500 should work.


(maint) Extra quoting for Windows versions.txt

Adds quotes around the "if exist path type path" command passed to
cmd.exe, which also requires that quotes around filenames have
their quoting escaped

@glennsarti this should fix the issue we've observed when retrieving the 32-bit agents versions.txt inside 64-bit Windows.  Still not sure why the (x86) is causing problems....

Reference in MODULES-3449

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2584/

We should make sure that we trigger some manual runs against this PR prior to merging.  For whoever ends up doing that @puppetlabs/windows, please put the output from the runs here. We want all 3 combos:

64-bit agent on 64-bit OS
32-bit agent on 64-bit OS (this is the problematic one prior to this commit)
32-bit agent on 32-bit OS

Running with this change everything looks good now - this can be merged @glennsarti / @kevpl
32-bit agent on 64-bit OS
TEST_TARGET=windows2012r2-6432a BEAKER_VERSION=git://github.com/Iristyle/beaker#maint/master/log-windows-versions-fix bundle exec rake ci:test:aio TESTS=tests/resource/scheduled_task/should_modify.rb SHA=0ac41b7e5e8f6d810503dd516a588f7d5111a3d8

C:\cygwin64\home\Administrator>start /w msiexec.exe /i "C:\PROGRA~3\puppet-agent-x86.msi" /qn /L*V C:\Windows\TEMP\install-puppet-2016-06-21_16.47.42.log PUPPET_AGENT_STARTUP_MODE=Manual

...

q8yxgpx3vtxayyp.delivery.puppetlabs.net (windows2012r2-6432-1) 16:47:57$ cmd.exe /c "if exist \"%ProgramFiles%\Puppet Labs\puppet\misc\versions.txt\" type \"%ProgramFiles%\Puppet Labs\puppet\misc\versions.txt\""

  q8yxgpx3vtxayyp.delivery.puppetlabs.net (windows2012r2-6432-1) executed in 0.07 seconds

  q8yxgpx3vtxayyp.delivery.puppetlabs.net (windows2012r2-6432-1) 16:47:57$ cmd.exe /c "if exist \"%ProgramFiles(x86)%\Puppet Labs\puppet\misc\versions.txt\" type \"%ProgramFiles(x86)%\Puppet Labs\puppet\misc\versions.txt\""
    puppet_for_the_win 4.5.2-0-gae1821b
    facter 3.1.8-41-gfbc52a0
    hiera 3.2.0-5-g9c8b977
    mcollective 2.8.8-25-g65a2cae
    puppet 4.5.2-121-ga0f3f55
    pxp-agent 1.1.3-46-g90375dc
    sys <IP_ADDRESS>-x86-0-g096192b

  q8yxgpx3vtxayyp.delivery.puppetlabs.net (windows2012r2-6432-1) executed in 0.09 seconds

64-bit agent on 64-bit OS
TEST_TARGET=windows2012r2-64a BEAKER_VERSION=git://github.com/Iristyle/beaker#maint/master/log-windows-versions-fix bundle exec rake ci:test:aio TESTS=tests/resource/scheduled_task/should_modify.rb SHA=0ac41b7e5e8f6d810503dd516a588f7d5111a3d8

C:\cygwin64\home\Administrator>start /w msiexec.exe /i "C:\PROGRA~3\puppet-agent-x64.msi" /qn /L*V C:\Windows\TEMP\install-puppet-2016-06-21_17.10.43.log PUPPET_AGENT_STARTUP_MODE=Manual

...

ulb62qpcqblmqep.delivery.puppetlabs.net (windows2012r2-64-1) 17:10:55$ cmd.exe /c "if exist \"%ProgramFiles%\Puppet Labs\puppet\misc\versions.txt\" type \"%ProgramFiles%\Puppet Labs\puppet\misc\versions.txt\""
    puppet_for_the_win 4.5.2-0-gae1821b
    facter 3.1.8-41-gfbc52a0
    hiera 3.2.0-5-g9c8b977
    mcollective 2.8.8-25-g65a2cae
    puppet 4.5.2-121-ga0f3f55
    pxp-agent 1.1.3-46-g90375dc
    sys <IP_ADDRESS>-x64-0-ga5963ea

  ulb62qpcqblmqep.delivery.puppetlabs.net (windows2012r2-64-1) executed in 0.08 seconds

  ulb62qpcqblmqep.delivery.puppetlabs.net (windows2012r2-64-1) 17:10:55$ cmd.exe /c "if exist \"%ProgramFiles(x86)%\Puppet Labs\puppet\misc\versions.txt\" type \"%ProgramFiles(x86)%\Puppet Labs\puppet\misc\versions.txt\""

  ulb62qpcqblmqep.delivery.puppetlabs.net (windows2012r2-64-1) executed in 0.09 seconds

32-bit agent on 32-bit OS
TEST_TARGET=windows10ent-32a BEAKER_VERSION=git://github.com/Iristyle/beaker#maint/master/log-windows-versions-fix bundle exec rake ci:test:aio TESTS=tests/resource/scheduled_task/should_modify.rb SHA=0ac41b7e5e8f6d810503dd516a588f7d5111a3d8

C:\cygwin\home\Administrator>start /w msiexec.exe /i "C:\PROGRA~2\puppet-agent-x86.msi" /qn /L*V C:\Windows\TEMP\install-puppet-2016-06-21_17.15.06.log PUPPET_AGENT_STARTUP_MODE=Manual

...

yb04ohhb9g5krft.delivery.puppetlabs.net (windows10ent-32-1) 17:15:25$ cmd.exe /c "if exist \"%ProgramFiles%\Puppet Labs\puppet\misc\versions.txt\" type \"%ProgramFiles%\Puppet Labs\puppet\misc\versions.txt\""
    puppet_for_the_win 4.5.2-0-gae1821b
    facter 3.1.8-41-gfbc52a0
    hiera 3.2.0-5-g9c8b977
    mcollective 2.8.8-25-g65a2cae
    puppet 4.5.2-121-ga0f3f55
    pxp-agent 1.1.3-46-g90375dc
    sys <IP_ADDRESS>-x86-0-g096192b

  yb04ohhb9g5krft.delivery.puppetlabs.net (windows10ent-32-1) executed in 0.08 seconds

  yb04ohhb9g5krft.delivery.puppetlabs.net (windows10ent-32-1) 17:15:25$ cmd.exe /c "if exist \"%ProgramFiles(x86)%\Puppet Labs\puppet\misc\versions.txt\" type \"%ProgramFiles(x86)%\Puppet Labs\puppet\misc\versions.txt\""

  yb04ohhb9g5krft.delivery.puppetlabs.net (windows10ent-32-1) executed in 0.08 seconds


Blender simplify shapes script: "Info: Applied modifier was not first, result may not be as expected"

Running the blender script, I sometimes get the following messages on some files:
Info: Applied modifier was not first, result may not be as expected
Info: Applied modifier was not first, result may not be as expected
Info: Applied modifier was not first, result may not be as expected
Info: Applied modifier was not first, result may not be as expected

Can this be ignored?

Hi @claell , I think it can be ignored.

Alright, closing then.


[FR] Build documentation on-line

Description of feature
So far, the documentation is being done locally for which scripts are already available.
Is it possible to automate the doc build state using git actions?
Correspondence: @dorukaks
Potential solution
Git actions

I'll create a branch out from main for this FR, this should not interfere with any of the other development items. Once this branch is done, we can merge with main and rebase dev :+1:


Spatialcoinc

Single hit module latest version
https://indico.fnal.gov/event/64317/contributions/289124/attachments/176958/240726/LowEnergy_170424.pdf

And thanks for the performance note.