🔬🧪🧬 [Refactor + Bug Fix] (test) Add more verifying common functions and apply them to testing items.

Target

Add more verifying common functions and apply them to testing items.
Fix issue of heartbeat updating.

Modify Code Scope

Source Code

module crawler

Testing Code

Common Module

testing module _/verify

Integration Test

testing module crawler

Effecting Scope

Fix issue of heartbeat updating processing.

Description

Add more verifying common functions and apply them to implementation of testing items.
Fix issue of heartbeat updating process with incorrect value.

Update time: Heartbeat.update_timeout -> Heartbeat.update_time

Fix another issue of exception checking in multi-processes.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 2 (50.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 87.263%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

smoothcrawler_cluster/crawler.py
1
2
50.0%

Files with Coverage Reduction
New Missed Lines
%

smoothcrawler_cluster/exceptions.py
1
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
1014

Relevant Lines:
1162

💛  - Coveralls


Write a cheat sheet or quickstart guide

The current quickstart guide is good at explaining what param is for but does not do a great job introducing users to some of the most important concepts.
I'd love to have some kind of cheat sheet or short primer on Param that covered some of the most important APIs that people still don't seem to know. That might include some of the most important methods:

inst.param.update(): Setting multiple values
inst.param.values(): Return a dict of values
inst.param.watch(): Watch parameter(s) for changes
ParameterizedClass.parameter = 'default': Overriding default

Sounds great! Happy for such content to be in a new section at the end of Getting Started if it can be relatively short, or else in a separate page if it would double the current length of the Getting Started guide.


fix install error

webui/static/src would be considered as a file and cause install error, so limit to *.css and *.js files.

add missing fetcher/splash_fetcher.lua

Thank you! Merged!


runtime: panic on system stack during cgo callback

I upgraded from 1.4 to 1.5 to have #11907 fixed. And every several minutes I get "panic during panic". That's all that I can see. It always occurs on cgo callback.
Please, let me know which information could be useful, I'll provide it.
panic: runtime error: index out of range
fatal error: panic on system stack

runtime stack:
runtime.throw(0x81b8f0, 0x15)
        /usr/local/go/src/runtime/panic.go:527 +0x90 fp=0x7f133d7f6f38 sp=0x7f133d7f6f20
runtime.gopanic(0x7653c0, 0xc820010030)
        /usr/local/go/src/runtime/panic.go:354 +0xb6 fp=0x7f133d7f6fb8 sp=0x7f133d7f6f38
runtime.panicindex()
        /usr/local/go/src/runtime/panic.go:12 +0x49 fp=0x7f133d7f6fe0 sp=0x7f133d7f6fb8
runtime.gentraceback(0x44801f, 0xc820034a58, 0x0, 0xc820000600, 0x0, 0xc820034a98, 0x20, 0x0, 0x0, 0x0, ...)
        /usr/local/go/src/runtime/traceback.go:255 +0x1206 fp=0x7f133d7f7110 sp=0x7f133d7f6fe0
runtime.callers.func1()
        /usr/local/go/src/runtime/traceback.go:566 +0xa2 fp=0x7f133d7f7190 sp=0x7f133d7f7110
runtime.systemstack(0x7f133d7f7198)
        /usr/local/go/src/runtime/asm_amd64.s:262 +0x79 fp=0x7f133d7f7198 sp=0x7f133d7f7190
runtime.mstart()
        /usr/local/go/src/runtime/proc1.go:674 fp=0x7f133d7f71a0 sp=0x7f133d7f7198

goroutine 17 [running, locked to thread]:
runtime.systemstack_switch()
        /usr/local/go/src/runtime/asm_amd64.s:216 fp=0xc8200349e8 sp=0xc8200349e0
runtime.callers(0x4, 0xc820034a98, 0x20, 0x20, 0x4736b0)
        /usr/local/go/src/runtime/traceback.go:567 +0xb0 fp=0xc820034a58 sp=0xc8200349e8
runtime.mProf_Malloc(0xc820e96000, 0x96000)
        /usr/local/go/src/runtime/mprof.go:235 +0x7f fp=0xc820034bd8 sp=0xc820034a58
runtime.profilealloc(0xc820026000, 0xc820e96000, 0x96000)
        /usr/local/go/src/runtime/malloc.go:811 +0x98 fp=0xc820034c00 sp=0xc820034bd8
runtime.mallocgc(0x96000, 0x0, 0x3, 0xc820652140)
        /usr/local/go/src/runtime/malloc.go:699 +0x5d3 fp=0xc820034cd0 sp=0xc820034c00
runtime.rawstring(0x94fd0, 0x0, 0x0, 0x0, 0x0, 0x0)
        /usr/local/go/src/runtime/string.go:264 +0x70 fp=0xc820034d18 sp=0xc820034cd0
runtime.gostringn(0x7f13101325e8, 0x94fd0, 0x0, 0x0)
        /usr/local/go/src/runtime/string.go:330 +0x48 fp=0xc820034d78 sp=0xc820034d18
github.com/bioothod/elliptics-go/elliptics._Cfunc_GoStringN(0x7f13101325e8, 0xc800094fd0, 0x0, 0x0)
        ??:0 +0x37 fp=0xc820034da0 sp=0xc820034d78
github.com/bioothod/elliptics-go/elliptics.go_stat_callback(0x7f133d7f72a0, 0x380)
        /root/go/src/github.com/bioothod/elliptics-go/elliptics/stat.go:450 +0x240 fp=0xc820034ee0 sp=0xc820034da0
runtime.call32(0x0, 0x7f133d7f71c8, 0x7f133d7f7250, 0x10)
        /usr/local/go/src/runtime/asm_amd64.s:437 +0x3e fp=0xc820034f08 sp=0xc820034ee0
runtime.cgocallbackg1()
        /usr/local/go/src/runtime/cgocall.go:252 +0x10c fp=0xc820034f40 sp=0xc820034f08
runtime.cgocallbackg()
        /usr/local/go/src/runtime/cgocall.go:177 +0xd7 fp=0xc820034fa0 sp=0xc820034f40
panic: runtime error: index out of range
fatal error: panic on system stack
panic during panic

runtime stack:
runtime.startpanic_m()
        /usr/local/go/src/runtime/panic1.go:67 +0x141 fp=0x7f133d7f6b58 sp=0x7f133d7f6b30
runtime.systemstack(0x877230)
        /usr/local/go/src/runtime/asm_amd64.s:278 +0xab fp=0x7f133d7f6b60 sp=0x7f133d7f6b58
runtime.startpanic()
        /usr/local/go/src/runtime/panic.go:505 +0x14 fp=0x7f133d7f6b70 sp=0x7f133d7f6b60
runtime.throw(0x81b8f0, 0x15)
        /usr/local/go/src/runtime/panic.go:526 +0x83 fp=0x7f133d7f6b88 sp=0x7f133d7f6b70
runtime.gopanic(0x7653c0, 0xc820010030)
        /usr/local/go/src/runtime/panic.go:354 +0xb6 fp=0x7f133d7f6c08 sp=0x7f133d7f6b88
runtime.panicindex()
        /usr/local/go/src/runtime/panic.go:12 +0x49 fp=0x7f133d7f6c30 sp=0x7f133d7f6c08
runtime.gentraceback(0x47ee70, 0xc8200349e0, 0x0, 0xc820000600, 0x0, 0x0, 0x64, 0x0, 0x0, 0x0, ...)
        /usr/local/go/src/runtime/traceback.go:255 +0x1206 fp=0x7f133d7f6d60 sp=0x7f133d7f6c30
runtime.traceback1(0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0xc820000600, 0x0)
        /usr/local/go/src/runtime/traceback.go:550 +0xc8 fp=0x7f133d7f6dc0 sp=0x7f133d7f6d60
runtime.traceback(0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0xc820000600)
        /usr/local/go/src/runtime/traceback.go:527 +0x48 fp=0x7f133d7f6df0 sp=0x7f133d7f6dc0
runtime.tracebackothers(0xc820000480)
        /usr/local/go/src/runtime/traceback.go:664 +0xda fp=0x7f133d7f6e68 sp=0x7f133d7f6df0
runtime.dopanic_m(0xc820000480, 0x44f370, 0x7f133d7f6f20)
        /usr/local/go/src/runtime/panic1.go:104 +0x1f9 fp=0x7f133d7f6eb8 sp=0x7f133d7f6e68
runtime.dopanic.func1()
        /usr/local/go/src/runtime/panic.go:514 +0x32 fp=0x7f133d7f6ed8 sp=0x7f133d7f6eb8
runtime.systemstack(0x7f133d7f6ef8)
        /usr/local/go/src/runtime/asm_amd64.s:278 +0xab fp=0x7f133d7f6ee0 sp=0x7f133d7f6ed8
runtime.dopanic(0x0)
        /usr/local/go/src/runtime/panic.go:515 +0x61 fp=0x7f133d7f6f20 sp=0x7f133d7f6ee0
runtime.throw(0x81b8f0, 0x15)
        /usr/local/go/src/runtime/panic.go:527 +0x90 fp=0x7f133d7f6f38 sp=0x7f133d7f6f20
runtime.gopanic(0x7653c0, 0xc820010030)
        /usr/local/go/src/runtime/panic.go:354 +0xb6 fp=0x7f133d7f6fb8 sp=0x7f133d7f6f38
runtime.panicindex()
        /usr/local/go/src/runtime/panic.go:12 +0x49 fp=0x7f133d7f6fe0 sp=0x7f133d7f6fb8
runtime.gentraceback(0x44801f, 0xc820034a58, 0x0, 0xc820000600, 0x0, 0xc820034a98, 0x20, 0x0, 0x0, 0x0, ...)
        /usr/local/go/src/runtime/traceback.go:255 +0x1206 fp=0x7f133d7f7110 sp=0x7f133d7f6fe0
runtime.callers.func1()
        /usr/local/go/src/runtime/traceback.go:566 +0xa2 fp=0x7f133d7f7190 sp=0x7f133d7f7110
runtime.systemstack(0x7f133d7f7198)
        /usr/local/go/src/runtime/asm_amd64.s:262 +0x79 fp=0x7f133d7f7198 sp=0x7f133d7f7190
runtime.mstart()
        /usr/local/go/src/runtime/proc1.go:674 fp=0x7f133d7f71a0 sp=0x7f133d7f7198

/cc @rsc @aclements @dvyukov

@aclements This is crashing in this code in traceback.go, which I believe you wrote:
		if frame.lr == stackBarrierPC {
			// Recover original PC.
			if stkbar[0].savedLRPtr != lrPtr {

As you can see from the stack trace, cgo code has called into Go code, the Go code is allocating memory, the profiler has decided to jump in and get a stack trace, and getting the stack trace crashes.

I suspect this has something to do with the funny tricks cgocallback_gofunc plays with the frame. I'm trying to put together a reproducer, but probably won't have something until tomorrow.
@noxiouz, do you happen to know if the call from C to go_stat_callback happens on a thread that was created by C or by Go? (I suspect it doesn't matter, but might help me narrow down the reproducer.)
In the mean time, there are a few things you can do to work around this. The simplest is probably to set GODEBUG=gcstackbarrieroff=1. You can also disable memory profiling.

BTW, anything you can tell us about the caller of go_stat_callback would be useful. Based on the name, I assume this was a function pointer passed in to C?
I tried writing the obvious reproducer where I set stack barriers to be installed at every frame, and made a call from Go to C and back to Go, then invoked runtime.Callers() while stack barriers were installed, but that wasn't enough to trigger this problem.

@aclements yes, this callback is called from C thread.
The first argument of this function is uintptr to C.struct. The second argument is uint64 which is used as key to get go function from global map (it's a kind of context). Inside go_stat_callback I get a proper context from a map, cast it to go function and call it.
Should I attach any code links?

@aclements BTW, GODEBUG=gcstackbarrieroff=1 makes the program work without panic.

Thanks.

There are many such callbacks in the code, but the occurs only in that callback. I assume, that it's connected with the size of frame. All other callbacks receives small data, but stat callback receives megabytes of data.

It most likely is related to the size of the frame, but it may just be bad luck (stack barriers are inserted at exponentially-spaced points in the stack, so it's hard to predict where they'll fall, but they tend to fall in the same place). What do you mean by "stat callback receives megabytes of data"? It's all on the heap, not on the stack, presumably? Though, a large GoBytes allocation could be triggering the garbage collector, which could be part of why you're repeatably seeing the failure at this point.

Should I attach any code links?

No, thanks, though if this is happening in an open source application or tests, it would be great if you could paste commands to reproduce it.

I believe I'm able to produce a similar crash involving C->Go callbacks and stack barriers:
» go test -bench . -v
=== RUN   TestRealm
=== RUN   TestPrefix
=== RUN   TestLongestMatch
=== RUN   TestMatches
--- PASS: TestRealm (0.00s)
--- PASS: TestLongestMatch (0.01s)
--- PASS: TestMatches (0.01s)
--- PASS: TestPrefix (0.01s)
PASS
BenchmarkInsertions-4	at *0xc82004d520 expected stack barrier PC 0x4ebc70, found 0xc82004d5d8, goid=51
gp.stkbar=[*0xc82004d2e0=0x5d35c1 *0xc82004d520=0x4ed67c *0xc82004df18=0x50736a], gp.stkbarPos=1, gp.stack=[0xc82004c000,0xc82004dfc0)
fatal error: stack barrier lost

runtime stack:
runtime.throw(0x6bf330, 0x12)
	/usr/lib/go/src/runtime/panic.go:527 +0x90
runtime.gcRemoveStackBarrier(0xc820001980, 0xc82004d520, 0x4ed67c)
	/usr/lib/go/src/runtime/mgcmark.go:579 +0x245
runtime.gcUnwindBarriers(0xc820001980, 0xc82004d5d8)
	/usr/lib/go/src/runtime/mgcmark.go:610 +0xc1
runtime.heapBitsBulkBarrier.func1()
	/usr/lib/go/src/runtime/mbitmap.go:409 +0x29
runtime.systemstack(0xc82001e000)
	/usr/lib/go/src/runtime/asm_amd64.s:262 +0x79
runtime.mstart()
	/usr/lib/go/src/runtime/proc1.go:674

goroutine 51 [running]:
runtime.systemstack_switch()
	/usr/lib/go/src/runtime/asm_amd64.s:216 fp=0xc82004d430 sp=0xc82004d428
runtime.heapBitsBulkBarrier(0xc82004d5d8, 0x10)
	/usr/lib/go/src/runtime/mbitmap.go:410 +0x142 fp=0xc82004d4c8 sp=0xc82004d430
runtime.typedmemmove(0x612900, 0xc82004d5d8, 0xc820656cf0)
	/usr/lib/go/src/runtime/mbarrier.go:185 +0x59 fp=0xc82004d4e8 sp=0xc82004d4c8
runtime.assertE2T2(0x612900, 0x612900, 0xc820656cf0, 0xc82004d5d8, 0x0)
	/usr/lib/go/src/runtime/iface.go:242 +0x92 fp=0xc82004d508 sp=0xc82004d4e8
github.com/mattn/go-sqlite3.(*SQLiteStmt).bind(0xc820110050, 0xc82065a3c0, 0x4, 0x4, 0x0, 0x0)
	/home/dave/hack/go/src/github.com/mattn/go-sqlite3/sqlite3.go:793 +0x9de fp=0xc82004d790 sp=0xc82004d508
github.com/mattn/go-sqlite3.(*SQLiteStmt).Exec(0xc820110050, 0xc82065a3c0, 0x4, 0x4, 0x0, 0x0, 0x0, 0x0)
	/home/dave/hack/go/src/github.com/mattn/go-sqlite3/sqlite3.go:851 +0x7b fp=0xc82004d838 sp=0xc82004d790
github.com/mattn/go-sqlite3.(*SQLiteConn).Exec(0xc820110000, 0x6efae0, 0x83, 0xc82065a3c0, 0x4, 0x4, 0x0, 0x0, 0x0, 0x0)
	/home/dave/hack/go/src/github.com/mattn/go-sqlite3/sqlite3.go:515 +0x3b0 fp=0xc82004d938 sp=0xc82004d838
database/sql.(*Tx).Exec(0xc8200f3db0, 0x6efae0, 0x83, 0xc82004dcb8, 0x4, 0x4, 0x0, 0x0, 0x0, 0x0)
	/usr/lib/go/src/database/sql/sql.go:1267 +0x276 fp=0xc82004dac8 sp=0xc82004d938
github.com/danderson/gipam/db.(*Prefix).Create(0xc82004dee8, 0x0, 0x0)
	/home/dave/hack/go/src/github.com/danderson/gipam/db/prefix.go:34 +0x64c fp=0xc82004dd00 sp=0xc82004dac8
found next stack barrier at 0xc82004df18; expected [*0xc82004d520=0x4ed67c *0xc82004df18=0x50736a]
fatal error: missed stack barrier
panic during panic

runtime stack:
runtime.startpanic_m()
	/usr/lib/go/src/runtime/panic1.go:67 +0x141
runtime.systemstack(0x6ee2d8)
	/usr/lib/go/src/runtime/asm_amd64.s:278 +0xab
runtime.startpanic()
	/usr/lib/go/src/runtime/panic.go:505 +0x14
runtime.throw(0x6bd410, 0x14)
	/usr/lib/go/src/runtime/panic.go:526 +0x83
runtime.gentraceback(0x4ebb10, 0xc82004d428, 0x0, 0xc820001980, 0x0, 0x0, 0x64, 0x0, 0x0, 0x0, ...)
	/usr/lib/go/src/runtime/traceback.go:259 +0x1053
runtime.traceback1(0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0xc820001980, 0x0)
	/usr/lib/go/src/runtime/traceback.go:550 +0xc8
runtime.traceback(0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0xc820001980)
	/usr/lib/go/src/runtime/traceback.go:527 +0x48
runtime.tracebackothers(0xc820001200)
	/usr/lib/go/src/runtime/traceback.go:664 +0xda
runtime.dopanic_m(0xc820001200, 0x4bddc0, 0x7f32141b1e10)
	/usr/lib/go/src/runtime/panic1.go:104 +0x1f9
runtime.dopanic.func1()
	/usr/lib/go/src/runtime/panic.go:514 +0x32
runtime.systemstack(0x7f32141b1de8)
	/usr/lib/go/src/runtime/asm_amd64.s:278 +0xab
runtime.dopanic(0x0)
	/usr/lib/go/src/runtime/panic.go:515 +0x61
runtime.throw(0x6bf330, 0x12)
	/usr/lib/go/src/runtime/panic.go:527 +0x90
runtime.gcRemoveStackBarrier(0xc820001980, 0xc82004d520, 0x4ed67c)
	/usr/lib/go/src/runtime/mgcmark.go:579 +0x245
runtime.gcUnwindBarriers(0xc820001980, 0xc82004d5d8)
	/usr/lib/go/src/runtime/mgcmark.go:610 +0xc1
runtime.heapBitsBulkBarrier.func1()
	/usr/lib/go/src/runtime/mbitmap.go:409 +0x29
runtime.systemstack(0xc82001e000)
	/usr/lib/go/src/runtime/asm_amd64.s:262 +0x79
runtime.mstart()
	/usr/lib/go/src/runtime/proc1.go:674
exit status 2
FAIL	github.com/danderson/gipam/db	2.934s

This crash happens repeatably within 10s of starting this benchmark, on amd64. The crash does not happen in Go 1.4.2, or in Go 1.5.0 with GODEBUG=gcstackbarrieroff=1.
To reproduce, go get github.com/danderson/gipam; then install github.com/danderson/go-sqlite3 as github.com/mattn/go-sqlite3 (I'm pending a pull request, but my fork is essential because it implements the C->Go callbacks in question). Once that's done, go test -bench . -v on the db subpackage should reliably trigger the crash.
Note that the cgo code in my fork of go-sqlite3 is my first attempt at doing C->Go callbacks, so it's possible that I just messed that up and am corrupting memory. However, the fact that it doesn't crash in 1.4 and that this bug talks about bugs triggered by C->Go->C transitions makes me suspicious, as this benchmark is doing hundreds of thousands of those transitions.

Hi Dave!
 If not, I can work on debugging it, but I'd rather avoid debugging something in order to debug something. :)

sorry for not answering, @aclements. My case is not easy to reproduce. As it's a part storage system and requires a lot to do to install it. I'll try to find a way to reproduce it anyway.

@aclements I've seen that segfault as well now. I'm not sure what's causing it. AFAICT, it is necessary to have a Go->C->Go->C transition for it to happen, but that's all I know right now.
I'm trying to narrow it down to a small repro case that doesn't involve the entire sqlite library, I'll update if I manage to get one. Unfortunately this isn't my day job, so it may be slow going :(

To be clear: in my current codebase, the crash only happens with the new code I added to go-sqlite, which introduces C->Go calls to go-sqlite. Without a C->Go transition, I cannot trigger the crash.
I've walked through the call chain on a reduced test case that still involves go-sqlite, and afaict the code is well-formed and never calls any NULL C functions.
I'll get back to you with the smallest repro case I can produce - hopefully one that has no sqlite in it at all, but if not, then I can at least remove the intermediate layers in my benchmark to narrow things down.

@noxiouz, @danderson, I have a fix for what I believe is causing your crashes. Can you try applying https://go-review.googlesource.com/13944 and let me know if it fixes the crashes?

Checking now, I'll report back after some stress-testing.

LGTM++, I'm unable to cause a crash in any of the cases that trivially blow up with an unpatched 1.5. The change looks great.

Hmm I have a situation which probably is a Go -> C -> Go  -> C case, all calls to panic() from inside the Go callback function just freezes the application at that point instead of printing and exiting. I'll start by trying the patch..

Im checking now

@aclements my case has been working for more than 11 hours  already. Before the patch it breaks every several minutes. Seems it works.

@danderson, @noxiouz, thanks for testing!

For posterity, the program I used to reproduce this is below. The failure mode is somewhat different from the other reports in this issue, and it's timing-dependent, though it tries hard not to be too sensitive. It should be run with GODEBUG=gcstackbarrierall=1.
package main

/*
extern void GoCallback(int);
extern void GoCheckstack(void);

static void renest() {
  // Wait for GC to finish. We should have a stack barrier in our sched.pc.
  sleep(2);
  // Call back in to Go so we put sched.pc back as the return IP.
  GoCheckstack();
}

static void CNest(int n) {
  GoCallback(n);
  if (n == 10)
    renest();
}

static void CFunc(void) {
  while(1)
    CNest(20);
}
*/
import "C"

import (
	"fmt"
	"runtime"
	"time"
)

var garbage *tree
var x []*byte

//export GoCallback
func GoCallback(n C.int) {
	if n == 0 {
		fmt.Println("triggering GC")
		x = make([]*byte, 100<<20)
		fmt.Println("waiting for stack barriers")
		time.Sleep(100 * time.Millisecond)
		fmt.Println("unwinding")
	} else {
		C.CNest(n - 1)
	}
}

//export GoCheckstack
func GoCheckstack() {
	pcs := make([]uintptr, 100)
	runtime.Callers(0, pcs)
}

type tree struct {
	l, r *tree
}

func makeGarbage(depth int) *tree {
	if depth == 0 {
		return new(tree)
	}
	return &tree{makeGarbage(depth - 1), makeGarbage(depth - 1)}
}

func main() {
	garbage = makeGarbage(25)
	C.CFunc()
}

A similar issue : https://github.com/golang/go/issues/12582


fix small typo

Summary

Fixed a small typo boo to bool
Ticket Link

Not applicable.

Hello @dfun90,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

/check-cla

/check-cla

@dfun90 It seems like you entered the wrong user name when signing the CLA. Would you be open on signing it again with dfun90?

@dfun90 It seems like you entered the wrong user name when signing the CLA. Would you be open on signing it again with dfun90?

Hey, yea, I noticed it myself the other day and wrote an email to the Mattermost team asking them to fix it, but I just signed another CLA with the correct username.

/check-cla

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @aspleenic


[Feature request] Add support for more HTTP methods

As new HTTP methods arrive you may support them regurarly like PROPFIND
I suggest it may be useful in some scenarios

You may also support custom methods

@Sharaf5 Support for more HTTP methods has been added. Please update to the latest version v1.0.56 and let us know if you have any further requests or encounter any issues.

I could confirm it's working here on the stable vscode version after restarting vscode
Thanks a lot


FR: Not only dv.paragraph, dv.list but also an inline element like dv.span?

I use =this.something quite often, and would like to see an inline element in dataviewjs, too. It’s not always practical to use up a complete paragraph for maybe just a calculated value or link.
Maybe it could simply be a dv.span()?

dv.span() probably wouldn't work since the actual dataview codeblock is a paragraph itself (and I can't really change that; limitation of the Obsidian API for doing markdown post-processing). However, I can add an inline dataviewjs block with a customizable prefix - maybe == <jscode>?

Inline JS blocks via $= <jscode> added for next release; they render whatever the JS evaluates to by default.

Ok, let’s see what comes of it. :-)


(debug build only) Core dump as soon as I try to enable testnet delegates

This problem showed up after the Jan 13th commits and may be related to something here: https://github.com/BitShares/bitshares/commits/develop/libraries/blockchain/chain_database.cpp
This occurs on first startup with no blockchain history.
The problem can be re-created as follows:
cd ~/bitshares/develop/tests/acceptance_tests
rm -r tmp
./testnet.rb --create

...bt
default (unlocked) >>> wallet_delegate_set_block_production ALL trueOK
default (unlocked) >>> bitsharestestnet_client: /home/jcalfee/bitshares/develop/libraries/fc/include/fc/optional.hpp:192: T& fc::optional<T>::operator*() [with T = bts::blockchain::block_record]: Assertion `_valid' failed.

(gdb) bt
#0  0x00007f21b53a6bb9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1  0x00007f21b53a9fc8 in __GI_abort () at abort.c:89
#2  0x00007f21b539fa76 in __assert_fail_base (fmt=0x7f21b54f1370 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x21700a5 "_valid", file=file@entry=0x2170060 "/home/jcalfee/bitshares/develop/libraries/fc/include/fc/optional.hpp",
    line=line@entry=192, function=function@entry=0x2170aa0 <fc::optional<bts::blockchain::block_record>::operator*()::__PRETTY_FUNCTION__> "T& fc::optional<T>::operator*() [with T = bts::blockchain::block_record]") at assert.c:92
#3  0x00007f21b539fb22 in __GI___assert_fail (assertion=0x21700a5 "_valid", file=0x2170060 "/home/jcalfee/bitshares/develop/libraries/fc/include/fc/optional.hpp", line=192,
    function=0x2170aa0 <fc::optional<bts::blockchain::block_record>::operator*()::__PRETTY_FUNCTION__> "T& fc::optional<T>::operator*() [with T = bts::blockchain::block_record]") at assert.c:101
#4  0x00000000012e44f8 in fc::optional<bts::blockchain::block_record>::operator* (this=0x7f21945eede0) at /home/jcalfee/bitshares/develop/libraries/fc/include/fc/optional.hpp:192
#5  0x0000000001ce298a in bts::blockchain::detail::chain_database_impl::extend_chain (this=0x36e31f0, block_data=...) at /home/jcalfee/bitshares/develop/libraries/blockchain/chain_database.cpp:988
#6  0x0000000001cd6f49 in bts::blockchain::detail::chain_database_impl::switch_to_fork (this=0x36e31f0, block_id=...) at /home/jcalfee/bitshares/develop/libraries/blockchain/chain_database.cpp:680
#7  0x0000000001cf5c5b in bts::blockchain::chain_database::push_block (this=0x36e24b8, block_data=...) at /home/jcalfee/bitshares/develop/libraries/blockchain/chain_database.cpp:1658
#8  0x0000000001233787 in bts::client::detail::client_impl::on_new_block (this=0x368a0b0, block=..., block_id=..., sync_mode=false) at /home/jcalfee/bitshares/develop/libraries/client/client.cpp:822
#9  0x0000000001230758 in bts::client::detail::client_impl::delegate_loop (this=0x368a0b0) at /home/jcalfee/bitshares/develop/libraries/client/client.cpp:691
#10 0x000000000122e779 in bts::client::detail::client_impl::__lambda7::operator() (__closure=0x3829708) at /home/jcalfee/bitshares/develop/libraries/client/client.cpp:620
#11 0x0000000001247c94 in fc::detail::void_functor_run<bts::client::detail::client_impl::start_delegate_loop()::__lambda7>::run(void *, void *) (functor=0x3829708, prom=0x3829700)
    at /home/jcalfee/bitshares/develop/libraries/fc/include/fc/thread/task.hpp:83
#12 0x00000000013ad397 in fc::task_base::run_impl (this=0x3829710) at /home/jcalfee/bitshares/develop/libraries/fc/src/thread/task.cpp:43
#13 0x00000000013ad328 in fc::task_base::run (this=0x3829710) at /home/jcalfee/bitshares/develop/libraries/fc/src/thread/task.cpp:32
#14 0x00000000013a20ea in fc::thread_d::run_next_task (this=0x368b7b0) at /home/jcalfee/bitshares/develop/libraries/fc/src/thread/thread_d.hpp:498
#15 0x00000000013a24fa in fc::thread_d::process_tasks (this=0x368b7b0) at /home/jcalfee/bitshares/develop/libraries/fc/src/thread/thread_d.hpp:547
#16 0x00000000013a1c01 in fc::thread_d::start_process_tasks (my=57194416) at /home/jcalfee/bitshares/develop/libraries/fc/src/thread/thread_d.hpp:475
#17 0x0000000002079d0e in make_fcontext ()
#18 0x0000000000000001 in ?? ()
#19 0x0000000000000000 in ?? ()

I suspect that my build is somehow messed up.. I'm testing with a fresh checkout and will let you know.

This only appears when cmake -DCMAKE_BUILD_TYPE=Debug is used prior to a build.

Should be fixed now.

Finally, I can turn quicky on.  Thank you.. https://github.com/BitShares/BitShares-JS/blob/de05ec86ef38d65c2cc23ff144f7432f9104619d/test/lib/rpc_json.coffee#L2-L6


Show how to make a private pipeline public

I was not able to find any information online about changing the visibility status of an Azure Pipeline. Can a private one be made public? A public one private? How?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 38f7a23b-ebd4-af3e-68a2-275f7e45c33e
Version Independent ID: f552a18c-ba29-00d4-03b6-254d7556d319
Content: Create your first pipeline - Azure Pipelines
Content Source: docs/pipelines/get-started-yaml.md
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

@TomasHubelbauer I am assigning this to the author of this article for more feedback, but I believe that changing your Azure DevOps Services project from public to private is how you would change the accessibility of your pipelines in that project:
https://docs.microsoft.com/en-us/azure/devops/organizations/public/make-project-public?view=azure-devops&tabs=new-nav

@TomasHubelbauer -- Tomáš, you may find answers here:

Azure DevOps Support Bot
Azure DevOps on Stack Overflow

I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.
My apologies for the delay in responding.


Work in progress: alternative hovers

This introduces alternate hovers for type info/doc info, trying to extract what is needed from the returned IDE info of :docs-for/:type-of.
This is not complete yet - it's hard to extract and reformat it all correctly.
But, I was hoping to get your feedback on a couple things:

Are you interested in this change?
Do you have any suggestions in approach?

Thanks for your work!

Previous
New

(types only)
(types only)

I am not sure why the Appveyor one doesn't work, sorry

Hi @rhencke, I think it's just a random glitchy of the CI tool, I re-triggered it and everything is fine 😄

And yeah extract useful and correct information for hover from Idris executable is quite tricky in some scenarios, honestly I like your idea here, just show the most important information for the user.

But, I think it is better to deliver this feature as a configuration like others here https://github.com/zjhmale/vscode-idris/blob/master/package.json#L104

Maybe you are also interested on this https://github.com/zjhmale/vscode-idris/issues/117 😄

And sorry for the huge delay, since I'm quite busy with other things, and get offline for weeks.


feat: add elasticsearch 7 test framework

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[x] Docs related to the changes have been added/updated (if applicable)

Note: this is pretty much a copy and paste of the existing test framework, with minor differences to get it compiling / working with ES7.


[REQUEST] CONVERSION PROCESS

Hi! It is my first time working with these kind of files. I don't know how I can convert rdm files into obj. Can someone tell me the process once I open "Anno-1800-Model-Converter.sln". I think microsoft visual studio should be used.

Same here. I'd love to use this resource, but how? Once downloaded and unzipped, I have no idea how to start the process or open the application, etc.
Thanks in advance, and for sharing your work!


CI: add Ruby 3.2 to the test matrix

Ruby 3.2 has been released! Let's add it to the CI build matrix and ensure the project is compatible.

@albus522 what do you think of this proposal?


Fix stale clocked header references when making edits to headers

Hi all! Thanks for the development of such a useful tool! I've been a happy user of nvim-orgmode for quite some time now.
I use the clocking functionality frequently in nvim-orgmode, as I've written a custom plugin for exporting the clock reports as timesheets for my work. I noticed that after a substantial refactor change for nvim-orgmode got merged into master, I would frequently experience file corruption when trying to clock in a new header. I figured out after some experimentation that this was happening whenever I was editing a file such that the currently clocked in header moved positions in the buffer. It looks like the currently clocked-in header is stored in memory, but for certain conditions the actual position of the header would get out of sync (e.g., if I moved another header above the currently clocked-in one).
This was a pretty significant issue for my workflow, so I went ahead and patched it locally and put together a unit test case which exercises the issue. My fix for this issue was to force a reload of the relevant files when performing clock-in or clock-out to ensure the right header position was used.
You can apply just the first commit of the test case and see the test fail against master, then apply the fix and see the test pass.
I'm happy to follow up with requests for changes or feedback if necessary. Thanks!

@kristijanhusak thanks for your response. Sorry it took me so long to get back to you, but my son was recently born so I've had my hands full :) I've rebased onto the current master branch. I'll need to do a bit of tweaking to my tests after the removal of the orgmode.parser.files api, so I'll push that up when I have some time.

Would it work if there would be a BufWritePost *.org autocmd that would reload the clocked headline?

The issue I see with this approach is that things would still get out of sync if the buffer wasn't yet written to disk. In particular, this happens when you use the default <leader>oxi keybinding on a header to clock something in-- it will update the logbook with the clock, but it won't write the buffer to save. Even beyond this scenario, I would imagine that generally we want actions on the buffer to be consistent with the current state of the buffer, whether it's been written to disk or not.
One solution would be to update all clock-modifying actions (or any property-editing actions for that matter) to write the buffer to file after the update. However, if we're taking that approach, it seems like this solution would be just as heavy (or even a bit heavier) than the currently proposed solution-- we'd still be updating the clocked header every time, and we'd also be writing to disk every time.
Based on this, I think the proposed approach would probably be the lightest approach that still guarantees the clock actions are consistent with the current state of the buffer. Do you agree with this assessment, or would you like to take a different approach?

@kristijanhusak I've removed the refresh on the get_statusline function and updated the tests. Seems like the 0.10.2 test check is failing due to an updated clock timestamp (might have been a test execution on a minute boundary that caused that test to fail?), and a lot of stuff is failing on nightly that seems unrelated to these changes.

@kristijanhusak thanks for the feedback. I've moved the new test into the clock UI test module and removed the direct calling of OrgFiles:new. I believe this is ready for your review.

Thanks @ReeceStevens, this fixes a problem, which annoyed me for quite a long time! :+1:


Get all tags from branch

Hi there,
I've searched for different ways to get all tags, that are created from a specific branch. This is totally possible with the Golang library, but unfortunately not with the rust version.
Normally you can search in Git for branches, that contains a specific tag-id.
Does anybody have an idea how to solve this, since core functionality is still missing in this lib?

Thanks for the report! Unfortunately we don't have a ton of time to help debug issues like this, and this library is just a thin wrapper around libgit2 so I'd recommend reaching out to upstream libgit2 authors for questions like this who may also have better materials for answering it too!


Feature/add press dates

This addresses #28.
I couldn't find the date for the examples file.

Oh noes! There were the following issues with your PR

Commit: 399204c1b8b55fe437a48c7f72487f27d764b765

Your commit message does not contain a body

Commit: a6d0bd0180dfc7282bc4216d26bf703cc01271cf

Your commit message does not contain a body

Guidelines are available at https://github.com/ipfs/awesome-ipfs/blob/master/CONTRIBUTING.md.

This message was auto-generated by https://gitcop.com

:+1:


Use with_connection instead of calling release_connection directly

Reviving #320 under a different organization and on the latest version of master.
The call to release_connection, added in #263, might release a connection that was opened outside of has_closure_tree (if the caller is loaded dynamically in the middle of some other operation). This is especially problematic if the connection has an ongoing transaction, as that transaction will be lost.
This PR changes has_closure_tree to use with_connection instead, which only releases a connection if it was acquired. If a connection already existed prior to the call to has_closure_tree, it won't be released.
@seuros made a comment on the previous version of this PR about Databaseless setup, which I didn't understand. If someone could point me at a doc/readme/whatever I'll gladly add the necessary tests.

I recently rediscovered this PR. What can I do to help get this merged?

I recently rediscovered this PR. What can I do to help get this merged?

Can you please rebase on master branch? Thank you!

I recently rediscovered this PR. What can I do to help get this merged?

Can you please rebase on master branch? Thank you!

Unfortunately I no longer have access to instructure-bridge as I don't work for Instructure any more. Maybe @williamshupe can? I'm not sure if this will ping him, but unfortunately I don't have a better way of contacting him.

Unfortunately I no longer have access to instructure-bridge as I don't work for Instructure any more. Maybe @williamshupe can? I'm not sure if this will ping him, but unfortunately I don't have a better way of contacting him.

I no longer have access to the repository either, sorry.


Support https URLs

Captures that use an https URL are not being displayed in SWAP.
Example seed URL: 2hj.org
https://swap.stanford.edu/*/http://2hj.org/
http on 2020-05-15: https://swap.stanford.edu/20180515215226/http://2hj.org/
https on 2020-05-16: https://swap.stanford.edu/20180516053423/https://2hj.org/

Is this something that we can fix? We don't develop this software, it's a fork of the official repository (I'm guessing for branding).  Is it possible a new version of openwayback fixes it?

It's more likely a configuration problem rather than a bug. I've spend a little time trying to fix, but so far have been unsuccessful.

I've researched this extensively and cannot determine the cause. Given the highly legacy nature of SWAP, I recommend that we replaced with PyWB.

I've only used pywb to render WARCs in local VMs, but I've been impressed with it. It's how I look at my old Facebook account that I crawled with webrecorder before deleting the whole account back in 2016.
I don't know what level of effort it would take to implement it, though.

Example of an https seed that worked before with Stanford's wayback:
https://argo.stanford.edu/view/druid:wd621jt4618

This might be a solution: https://www.github.com/iipc/openwayback/pull/397 The underlying issue fixed there seems to come from upgrading Tomcat.

Test URL for stage: https://m.reddit.com/r/HistoricalBoardgames/comments/1azsid/great_review_on_combat_commander/

A better test URL: https://www.shpride.com/

Confirmed fix with stakeholders.


change utidc address to avoid conflict

Fixes  https://github.com/tariqkurd-repo/riscv-cheri/pull/new/utid_address

Shouldn't it have upper 2 bits 0b11 to make it read-only?

of course, I forgot that it was supposed to be read only - I'll reallocate


[OrderBookExchange] Simplify pricing calculation

Simplified the buy / sell pricing calculation since it seemed like the logic for both sides of the order book was identical.

I caught a bug in the implementation of this, so I'm just going to merge this as part of the Ethfinex tests to ensure these changes are properly tested.


basic-hls-rtmp-obfuscation.php need an update

Hi,
Your code has been bypass by web scrapers https://github.com/WMSPanel/paywall-code-samples-wmsauth/blob/master/php/basic-hls-rtmp-obfuscation.php.
These guys are scraping streams from my website.
https://github.com/Tempest0580/Temptv/issues/27
https://zynetv.net/ae.html
Can you put an update to fix this issue?
Thanks!

Hi,
The code you see there is an example which you can improve yourself with your own business logic. We might update it in future but no ETA yet,


[BUG] External payment page not working in payment page flow.

External payment page not working in payment page flow.

Here is the error at the end of the process (on the confirmation page).

Included in beta release <IP_ADDRESS>

Included in production release <IP_ADDRESS>


[issue #382][AIC-py] palm parser load env api key

[issue #382][AIC-py] palm parser load env api key

Stack created with Sapling. Best reviewed with ReviewStack.

-> #601
#600
#599

testplan?


HSEARCH-4944 Use correct project id to recompile for ORM 6.3 upgrade tests

https://hibernate.atlassian.net/browse/HSEARCH-4944

I think you need the -orm6 suffix on this branch, no

True! I've run the tests for hibernate-search-integrationtest-mapper-orm, the same I've done for main while testing the patch... but the main in 6.2 isn't ORM6 🤦🏻♂ 😃
thanks for noticing.
Now I've tested the correct artifact locally, so it should be better now...


Array.copyWithin() signature is incorrect - Part II

Bug Report
In https://github.com/microsoft/TypeScript/issues/53334 TypeScript's lib was updated to allow Array#copyWithins 2nd argument start to be optional, to match the MDN documentation at that time.
The MDN documentation has since been updated to match the spec, meaning TypeScript 5.1's types are incorrect.
To remediate: a reversion of https://github.com/microsoft/TypeScript/pull/53340 is needed. This might be a slightly breaking change for anyone that adopted TypeScript 5.1 and started (incorrectly) relying on the parameter being optional.
🔎 Search Terms
copyWithin
🕗 Version & Regression Information

This changed between versions 5.0 and 5.1

Should be a quick and easy PR if you want to fix it up.

I am going to pick this up

@DanielRosenwasser @tchetwin @Mburnand-tech I would also like to give it a try, if it's not against the community values!!!

@shubhamshd Go for it! I've struggled to correct the tests so they pass.

@DanielRosenwasser  please review the changes in pr and let me know, if anything needs to be corrected, thanks!!!

Apologies team, but is there any scheduled time for the pr to get merged?


Actually use blockTracker as part of indexing

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#284  👈 (View in Graphite)
#283
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Can't override datasource of extended resolver

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v16.18.1
Amplify CLI Version
10.8.1
What operating system are you using?
MacOS
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
Used override.ts
Describe the bug
When trying to amplify push after creating override I get the error:
Error: Skipping override due to TypeError: Cannot read property 'MutationupdateInspectionpostUpdate0FunctionMutationupdateInspectionpostUpdate0Function.AppSyncFunction' of undefined
Expected behavior
Expected override to change function datasource
Reproduction steps

Create extended resolver
create override.ts to change datasource name

Project Identifier
3d663de20f6e3c760dc987ad32595b72
Log output

Contents of override.ts
import { AmplifyApiGraphQlResourceStackTemplate } from '@aws-amplify/cli-extensibility-helper';
const functionName = "MutationupdateInspectionpostUpdate0FunctionMutationupdateInspectionpostUpdate0Function.AppSyncFunction"
export function override(resources: AmplifyApiGraphQlResourceStackTemplate) {
const model = resources.models["Inspection"];
model.appsyncFunctions[functionName].dataSourceName = "ActivityStreamTable";
}
# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Actually, if I continue with the push, the function is deployed with the correct datasource name which just leaves the question of why there is an error.


feat: header for bottom sheet

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


runtime: expose the Runtime structure

Expose the Runtime structure, so caller could explicitly create a
Runtime object and repeatly invokes block_on() on it.
Signed-off-by: Jiang Liu<EMAIL_ADDRESS>

Looking at this, if we are going to do this, we probably want to store the tokio runtime in the Runtime structure, rather than building it anew each time.

Sorry, I missed your point here.
The Runtime structure already has a field rt: tokio::runtime::Runtime.
Or do you mean to enhance tokio_uring::start() by using a scoped_thread_local(static CURRENT: Runtime)?
diff --git a/src/lib.rs b/src/lib.rs
index 5d675ea..cef1f10 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -140,8 +140,7 @@ use std::future::Future;
 /// }
 /// ```
 pub fn start<F: Future>(future: F) -> F::Output {
-    let mut rt = runtime::Runtime::new().unwrap();
-    rt.block_on(future)
+    runtime::CURRENT_RUNTIME.with(|rt| rt.borrow_mut().block_on(future))
 }

 /// A specialized `Result` type for `io-uring` operations with buffers.
diff --git a/src/runtime.rs b/src/runtime.rs
index 3d22bf2..23823de 100644
--- a/src/runtime.rs
+++ b/src/runtime.rs
@@ -6,6 +6,10 @@ use std::io;
 use tokio::io::unix::AsyncFd;
 use tokio::task::LocalSet;

+thread_local! {
+    pub(crate) static CURRENT_RUNTIME: RefCell<Runtime> = RefCell::new(Runtime::new().unwrap());
+}
+
 /// The tokio-uring runtime based on the Tokio current thread runtime.
 pub struct Runtime {
     /// io-uring driver

Sorry, I totally forgot about this PR!
I think we should take a step back before we implement this, and get an issue up for this. We should establish first the semantics of the Runtime structure, as well as a builder.

Hello folks! I came here from trying to use criterion to benchmark a weekend project I was playing with that uses tokio-uring. The criterion folks seem to need to be able to call your block_on method. At least, I think so. I don't really know rust, tokio, or iouring so I may very well be missing a lot here. At least, they need that if they're going to join an existing runtime. If I wanted the benchmark to include starting the runtime and opening files and such then I imagine I could just start a new runtime inside....

So..... Like I said, I don't know what I'm doing, but I was able to benchmark by setting up in a tokio_uring::start, returning a path, and doing a new tokio_uring::start inside the benchmark. The start and file opening didn't show up in the flamegraph but I presume that's because I shot for something in the millisecond range.
Like I said, all criterion really wants is something it can block_on the future.

@nik9000 I'd agree that we need this. Unfortunately, this PR seems to be dead. Maybe I or @FrankReh can open up another one to get this in, although we should first come up with an issue to scope out what we actually want the behavior to look like.

although we should first come up with an issue to scope out what we actually want the behavior to look like.

Is #91 ok?

I forgot we had that.

@Noah-Kennedy @FrankReh If I recreate this PR, is there an appetite for merging it? I find myself doing something similar constantly to enable bench marking with criterion.
I actually go further, and change the signature of block_on to be &Self rather than &mut Self

Yes, we should make it easy for at least the criterion use.
People using this crate know that APIs can still change right? So we are allowed to do something and then later change our minds about it, at least the API around it?
For example, seeing this issue just today, I realize I don't know much about tokio proper's block_on method and I find there are three. And a very interesting one is a Handle block_on and that the Handle public struct is going through a lot of changes recently but it is a per runtime type and it supports reference counting. So that's something to wonder about. Should this crate be following a similar design pattern? This crate already needs its own block_on method, which wasn't public yet - can it be made as flexible as the tokio version and if not why, and if so, should this crate also offer a Handle that is internally reference counted?
So yes, I think the block_on should be exposed.
@Noah-Kennedy Do you or anyone else want to chime in here? Also I'm wondering about this crate's version and the CHANGELOG.md file. Is there another crate that would make a good example of the kind of care that should go into the change log and when minor or patch numbers are incremented when the project is a major 0 version?
Back to an immediate question, block_on self being &Self or &mut Self? What are the possible pros and cons? Tokio has their's as &Self.

@FrankReh I tried reasoning about block_on self being &Self or &mut Self?. We're fixed on the current thread anyway, so parallel acces cannot happen. I guess you could do something odd with tokio_uring running under another executor. My rational is driven entirely by https://bheisler.github.io/criterion.rs/criterion/async_executor/trait.AsyncExecutor.html.

@ollie-etl That seems to be reason enough. Any complaints from the compiler when you make the referenced shared?

@FrankReh no, and the benchmarks run quite happily

@ollie-etl I assume you've used tokio_uring::start or pulled that apart to get at the block_on method. Have you looked at using the tokio_uring::builder() API which was added a little while back to allow more details about the uring setup to be exposed before calling start? That replaced the global start with a Builder start method. I wonder if that Builder start method should have been named block_on?
I think it's reasonable to make as minimal a change as possible to make the criterion user happy for now. We can go with a 0.3.1 version for it, even if it's not needed. (I don't know what triggers updates past my use of 'cargo update' once in a while.)
Would be nice if the commit message included a short example of a main that used criterion to save newcomers from having to figure that out too. The commit message could also point out that this isn't behind a config flag but we don't know what we don't know yet about future minor bumps to the API.
I'm going to continue my wanderings about this crate's runtime on #91.

I believe the issue this PR was addressing has now been handled by #148 so am closing. Thank you for the investigation and in getting the ball rolling.


Links to examples in documentation are broken

62bf56d5089e0f5b9eb0274ded3308957213f6dd removed the example directory but the documentation still links to: https://github.com/dart-lang/intl/tree/master/example/basic

https://pub.dev/documentation/intl/latest/intl/intl-library.html and https://pub.dev/documentation/intl/latest/intl/DateFormat-class.html (generated from lib/intl.dart and from lib/src/intl/date_format.dart respectively) still refer to example/basic.
Can we reopen?


Compile / parse error at if variable == definedType{} {...}

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.10.3 darwin/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
macOS 10.12.6
go env output:
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/az/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/az/gopath"
GORACE=""
GOROOT="/opt/go"
GOTMPDIR=""
GOTOOLDIR="/opt/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/3f/gwdj7r7x1g509q7d33ly8p0w0000gn/T/go-build071944107=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
https://play.golang.org/p/mGhUQgF1ybF
Compilation error on comparison inside if block.
package main

type structT struct{}

func main() {
	s1 := structT{}

	// compiles as expression
	_ = s1 == structT{}

	// does not compile with defined type
	if s1 == structT{} {
	}

	// compiles with underlying struct type
	if s1 == struct{}{} {
	}
}

What did you expect to see?
If a boolean expression compiles being assigned to a variable, it should also compile inside if block.
What did you see instead?
prog.go:12:21: syntax error: unexpected { at end of statement
prog.go:16:2: syntax error: non-declaration statement outside function body

Please see the spec at https://golang.org/ref/spec#Composite_literals:

A parsing ambiguity arises when a composite literal using the TypeName form of the LiteralType appears as an operand between the keyword and the opening brace of the block of an "if", "for", or "switch" statement, and the composite literal is not enclosed in parentheses, square brackets, or curly braces. In this rare case, the opening brace of the literal is erroneously parsed as the one introducing the block of statements. To resolve the ambiguity, the composite literal must appear within parentheses.


Add error reporting examples to rn-tester turbo modules

Summary:

This PR is adding examples of Turbo Modules functions throwing runtime exceptions and asserts. This should make it easier to collaborate and develop the error reporting for a new architecture that is being discussed in the React Native New Architecture Working Group -> https://github.com/reactwg/react-native-new-architecture/discussions/122.
I'm not sure what return type should be used for the JS function returning Promise<void> in Cxx, I used AsyncPromise<jsi::Value>, what would you use, I've not found void type to use?
Changelog:

[INTERNAL] [ADDED] - Error reporting examples in rn-tester turbo modules
Test Plan:

This PR doesn't change any RN behavior. Only shows the current state by adding an example to rn-tester.
I'm happy to add these examples to the unit/integration test, just point me to where would be a good place.

Can you summarize the current behaviour / add a video of the screen you added? That will be helpful to understand future changes.

@javache Thank you for the feedback.
I've added a table with the functions overview and I can add a video too.

Thanks for sending this over @krystofwoldrich, before we can import this we'll have to make sure CircleCI is all green 👍

@cortinico Yes, for sure, I didn't have Flow set up locally, so I missed some of the errors that showed in the CI.


fix(material): remove usage of form-field deep import path

Adding a bug fix for an error I had run into when using Material Formly where the import was one level too deep.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Please check if the PR fulfills these requirements

[x] The commit messages follow our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] A unit test has been written for this change.
[x] Running npm run build produced a successful build. (Unit testing can be done by running npm test;)
[x] My code has been linted. (npm run lint to do this. npm run build will fail if there are files not linted.)

Please provide a screenshot of this feature before and after your code changes, if applicable.
Other information:

Thank you @AmGarera!

This PR has been released as part of v6.0.0-rc.0 release.
Please let us know, in case you are still encountering a similar issue/problem.
Thank you!


ALYZ-2046 Made small change to load additional CLI modules into superset

This was done so the change may be viable for contribution to the official superset repo. We can use it internally to add our own CLI modules for the time being.

Opening these PRs to keep a history of changes for these tasks.


Socket

Hi,
I would like that this plugin was added to create a Socket
http://plugins.cordova.io/#/package/cz.blocshop.socketsforcordova
Thanks =D

If you write a PR that includes a wrapper for this; that'd ensure it'd get included much more quickly. Thanks!

Greetings @NestorAlbelo!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Add functionality to change collection view background color

Yeah, setting background color could probably be useful :p
The other parts you can tweak are a part of the BSImagePickerSettings protocol, could you move it there?
And drop collectionView from the property name, backgroundColor should be good enough :)

Okay perfect I have pushed the changes and added it to the
BSImagePickerSettings protocol instead!
Let me know if there is anything else needed?
Thank you :)
On Fri, Feb 17, 2017 at 12:42 AM, Joakim Gyllström<EMAIL_ADDRESS>
wrote:

Yeah, setting background color could probably be useful :p
The other parts you can tweak are a part of the BSImagePickerSettings
protocol, could you move it there?
And drop collectionView from the property name, backgroundColor should be
good enough :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mikaoj/BSImagePicker/pull/124#issuecomment-280333030,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGyv3xDR8dv79GMzbx61diJFmrwo402Sks5rdFI1gaJpZM4L86jK
.

Great, thanks! :)


[VS Code] Files missing from share due to incorrect .gitignore parsing

NOTE: I haven't got logs (I wasn't aware of the process when we hit the issue) - let me know if you need them and I'll recreate the issue and grab them tomorrow when my colleague is online.
Product and Version [VS/VSCode]: VSCode
OS Version [macOS/Windows]: macOS & Linux
Live Share Extension Version: 0.3.890
Target Platform or Language [e.g. Node.js]: Ruby
Steps to Reproduce / Scenario:

We have a folder called jobs/jobs/pipeline
And another folder jobs/pipeline
The .gitignore contains:

jobs/pipeline
Which git matches as the second folder but not the first.

It looks like both the folders gets filtered out by the live share when we connect with this line in .gitignore (if we comment out the line then both pipeline folders appear in the shared workspace.

Side Note
Assuming that files are getting filtered by what's in .gitignore - we could potentially hit a problem where a folder has been ignored after some files have been manually added (so they exist within the git repo but new files wouldn't get flagged for a git add)

Thanks for reporting this! We'll look into this issue ASAP.

So.. this is still an issue...

@jramsay could we check if this is something we can repro?

We’ve made improvements in this area since this issue was filed. We believe this may have improved your experience and are closing this issue. If this issue still persists for you, please comment on the issue and let us know. Thank you.


Upgrade to latest wazimap version for Python 2.7 end of life

Refer to the links below for more detail  ->
https://github.com/CodeforNepal/nepalmap_federal/issues/84
https://wazimap.readthedocs.io/en/latest/upgrading.html

Issue is resolved in https://github.com/CodeforNepal/nepalmap_federal.


Is it possible for the fhir-data-pipes to sink directly into a Data Warehouse e.g. Google BigQuery?

Instead of:
fhir-data-pipes -> Google Healthcare API FHIR Store -> Google BigQuery
It will be like:
fhir-data-pipes -> Google BigQuery
As also suggested in this diagram

"Data Loaders" includes fhir-data-pipes.

Actually this feature is the long standing issue #455, i.e., adding BigQuery as a sink option. It should not be too hard to add this and I think it is a useful feature. The main reason we have not implemented it yet is that we have not heard much demand for it from our partners. If this is a useful feature for you and you can contribute for implementing it, I am willing to help.
Side note 1: We have actually done some work in #454 to make the resulting schema similar to the BigQuery schema of GCP FHIR store -> BigQuery flow.
Side note 2: You can import Parquet files into BigQuery; that's how the comparisons in #454 was done.

@bashir2 I see. Initially I was thinking of using the JDBC driver for BigQuery and try and create a sample JDBC URL config for BigQuery in the DatabaseConfiguration
https://github.com/google/fhir-data-pipes/blob/dc70755848b2ea83390a2699ed05ed6088875eec/pipelines/common/src/main/java/com/google/fhir/analytics/model/DatabaseConfiguration.java#L58-L62
References

JDBC drivers for BigQuery
Magnitude Simba Google BigQuery JDBC Data Connector Installation and Configuration Guide

@muhammad-levi your JDBC based idea can work but since we use Beam for our pipeline, I would first consider BigQueryIO; it is usually better to rely on Beam IOs when it is possible. That said, there are reasons not to use them; for example, in some places, we don't use ParquetIO for creating Parquet files (mostly because of Flink's memory overhead in the single-machine mode).


Make style pointerEvents take priority over pointerEvents prop

Summary
Make style pointerEvents take priority over pointerEvents prop. Fixes requested changes in #34586

Changelog

[General] [Fixed] - Make style pointerEvents take priority over pointerEvents prop. FIxes requested changes in #34586
Test Plan
Will rely on green cli

Can we add test coverage for this? Are there existing unit tests we can expand upon?

Hi @necolas, I couldn't any existing unit tests for pointerEvents, although I've added examples for the same.


Webview Process Terminated when instantiating shared workers on IOS 16.1

Bug description:
Some of our users are facing crashes related to the webview when opening our app on IOS 16.1 devices. The only message we could get from the crash is "Webview Process terminated".
To Reproduce:
Clone this POC repository and follow the required steps, it should crash when testing the react-native-webview on ios 16.1 but should work fine with 16.0
We already have a check to make sure we only use shared workers if they are available (typeof window.SharedWorker === 'function') but it crashes when doing new SharedWorker.
Expected behavior:
We should get a javascript exception/error instead of the webview process crashing.
Screenshots/Videos:
Environment:

OS: IOS
OS version: 16.1
react-native version: 0.68.2
react-native-webview: 11.23.1

Hi!
We encounter a (very) similar issue with one of our mobile app since the release of iOS 16.1, but, in our case with a barebone WKWebView (no react-native involded). Not sure yet if there is a bug or a change introduced with this new iOS version...
@mauri870 Watch out that your POC uses the deprecated UIWebView instead of WKWebView.
Note: Safari on iOS 16.1 doesn't seam to be impacted.

Alright, some updates.
Seems like UIWebView is deprecated, I updated the poc to use WKWebView which seems like the same api that this project uses and now it crashes too when instantiating shared workers, this was introduced by IOS 16.1 because it works fine with IOS 16.0.
I know that shared workers are not quite supported by the webkit webview but that crashing the app all of a sudden after an update does not seems right, also there is no mentioned changes in the 16.1 changelog.

@pparidans Thanks for the feedback, I was already working on the migration to WKWebView. :)
To share our solution for now, seems like you cannot rely on just checking typeof window.SharedWorker === 'function' to see if the api is available, you need to blacklist 16.1 somehow, since we were already using detector-js we decided to simply disable shared workers and fallback to websockets (we only use sw for pusher events).

@mauri870 Yes, I agree that even if it affects react-native-webview, it's not their responsibility (but Apple's one).
I also dug into the release notes or what else and found nothing! I guess we could treat it as a WKWebView bug then...
You mentioned that SharedWorker are not quite supported by the WKWebView : do you have a source for that (try to document this issue) ?
About the workaround, we also blacklisted it for lack of a better solution...
Anyway, thanks for your feedback :hugs:

@pparidans Ended up creating an Apple Developers forum post.
This does not seems to be a Webkit issue at first, since it is the same version as in safari mobile.
I saw this ticket earlier about service workers, not sure if it is related https://github.com/react-native-webview/react-native-webview/issues/1086
Safari started supporting shared workers early this year, seems like it is not quite stable on mobile yet 😓

Turns out this is a webkit bug on iOS 16.1
https://github.com/WebKit/WebKit/pull/5872
The fix for now is to disable shared workers by  using injectedJavaScriptBeforeContentLoaded with  delete window.SharedWorker

I have tried injectedJavaScriptBeforeContentLoaded with delete window.SharedWorker
But the problem still there. (my case: source={{ html: ... }})
Then I found the post and tried to inject delete window.SharedWorker in native side.
https://developer.apple.com/forums/thread/718757
It works!

Based on https://developer.apple.com/forums/thread/718757
Try:
#if defined(__IPHONE_OS_VERSION_MAX_ALLOWED) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_16_1 /* iOS 16.1 */
      if (@available(iOS 16.1, *)) {
          NSString *deleteSharedWorker = @"delete window.SharedWorker; window.SharedWorker = undefined";
          WKUserScript *deleteSharedWorkerScript = [[WKUserScript alloc] initWithSource:deleteSharedWorker injectionTime:WKUserScriptInjectionTimeAtDocumentStart forMainFrameOnly:NO];
          [wkWebViewConfig.userContentController addUserScript:deleteSharedWorkerScript];
      }
    #endif

before html5HistoryAPIShimSource:
[wkWebViewConfig.userContentController addUserScript:script];
on RNCWebView
This is an IOS webkit issue so i don’t recommend patch this.


Update README.md with Homebrew installation instructions for macOS

Mac users can now install and keep their installation up to date using Homebrew. I need to repoint whenever there's a new version however so if anyone knows how to automate that I'm all ears 😄
brew tap chrokh/tap
brew install base16-manager

I'll take your word for it. 😉
As for automating the version of the package, I suggest updating this manually regardless of it being a pain, and creating a new base16-manager package for Homebrew that uses the master branch of this repository. I intend to make a seperate AUR package using this method as well.


Added EXPOSE directive to Dockerfiles

EXPOSE is used by projects like nginx-proxy in order to automatically detect which ports the container uses.

Didn't see this before a major refactor on the Dockerfiles. I've added the EXPOSE line in master now, though. Thanks!


My Discord bot is crushing

If I run my commands, it shows this error in Heroku.
2020-08-01T16:48:50.459408+00:00 app[worker.1]:     data = yield from self.http.static_login(token, bot=is_bot)
2020-08-01T16:48:50.459412+00:00 app[worker.1]:   File "/app/.heroku/python/lib/python3.6/site-packages/discord/http.py", line 262, in static_login
2020-08-01T16:48:50.459657+00:00 app[worker.1]:     raise LoginFailure('Improper token has been passed.') from e
2020-08-01T16:48:50.459914+00:00 app[worker.1]: discord.errors.LoginFailure: Improper token has been passed.
2020-08-01T16:48:50.477281+00:00 app[worker.1]: Unclosed client session
2020-08-01T16:48:50.477289+00:00 app[worker.1]: client_session: <aiohttp.client.ClientSession object at 0x7f60a8fe51d0>
2020-08-01T16:48:50.477575+00:00 app[worker.1]: Unclosed client session
2020-08-01T16:48:50.477613+00:00 app[worker.1]: client_session: <aiohttp.client.ClientSession object at 0x7f60a8fe5518>
2020-08-01T16:48:50.574796+00:00 heroku[worker.1]: Process exited with status 1
2020-08-01T16:48:50.618165+00:00 heroku[worker.1]: State changed from up to crashed

This bot is not designed to be hosted on Heroku or similar sites.  Use an actual POSIX-compliant host (e. g. a OSX or Linux host) or a Windows host with the correct requisites installed as described on the documentation on this GitHub page.

but I was using this from last 3 months

That error seems to be from a Python-based bot, so it's probably not this bot.

my one is a python based bot

It's runs and then like after 5 min got crushed.

Listen, DopeGhoti told you, go to the repo and open an issue on the bot you are using.

my one is a python based bot
@Skans21 Then this is not the place to ask help for it 😛
This repository is for a Node.js-based Modmail bot. You might be running kyb3r's bot or some other one.


ScaleLLM Roadmap

We're excited to present the features we're currently working on and planning to support in this roadmap document. Your feedback is highly valued, so please don't hesitate to comment or reach out if you have anything you'd like to add or discuss. We're committed to delivering the best possible experience with ScaleLLM.
Q1-Q2 2024
Efficiency

[x] Adding flash decoding with paged KV cache support [Done]
[x] Introducing attention kernel capable of supporting speculative decoding [Ongoing]

[ ] Exploring the feasibility of adopting the flashinfer library [Ongoing]

[x] Implementing speculative decoding [Done]
[ ] Enabling CUDA graph for decoding to improve performance [Ongoing]
[x] Implementing dynamic split-fuse for enhanced latency
[ ] Exploring lookahead decoding support
[ ] Implementing fused FFN (Feed-Forward Network) to enhance efficiency
[ ] Introducing a ring attention mechanism for handling long contexts

Cache

[x] Implementing stateful conversation to avoid recomputing for chat sessions

New Models

[x] Integrating Google Gemma
[ ] Incorporating the Mixtral MoE model

[ ] Implementing MoE (Mixture of Experts) kernels

[ ] Introducing the Mamba model
[ ] Introducing multi-modal models

[ ] LLaVA model

[ ] LoRA & QLoRA

[ ] S-LoRA: Serving thousands of LoRA adapters

New Devices

[ ] Adding support for Apple chips
[ ] Exploring other chips such as TPU, NPU, etc.

Usability

[ ] Developing Python wrapper for easier integration [Ongoing]
[ ] Enhancing documentation for improved usability

New GPU Architecture

[ ] Turing architecture (sm75)

Structural Decoding

[ ] Function Calling

Quantization

[ ] Supporting FP8 for both models and KV caches

Supported Operating Systems

[ ] Extending support to macOS and Windows platforms

Misc

[ ] Conducting benchmarking to compare performance with other open-source projects
[ ] Adding more bechmarks and unittests for kernels and dependencies [Ongoing]
[ ] Adding more Prometheus metrics and creating a Grafana dashboard for monitoring.
[ ] Loosening coupling with PyTorch for easy deployment

I think LLaMA 3 should be added as well, and probably should be high priority.

I think LLaMA 3 should be added as well, and probably should be high priority.

Yes, Llama3 is supported already, please check latest release.


Works on 8ch, not 4chan

Thanks for writing this plugin.
On safari 10.1 it works on 8ch but on 4chan it does not. The webm opens in a new window like normal and the superscript disappears from the active scripts list until the page is refreshed.

Ah! I forgot to test this without 4chan X.

Would you mind posting your 4chan x config? When I try it with 4chan x, it works simply throws the video at the top instead of the page below the blotter instead of the normal positioning.

Never noticed how badly 4chan runs on Safari without 4chan X. I'm going to just going to make 4chan X a requirement for this script as it fixes a lot of bugs.
I reset my config and got the same issue as you. Disable Image Hover in the settings and that should fix it.

Alright, thanks for the help!

Did that fix it for you? Thanks for reporting!

Yep. No problems. Great plugin BTW, I thought I would have to write something like this myself. Thanks.


A possible issue preventing the package from working with Filament?

Package version
versions : * v3.10.0
Package implicate
filament/filament: v3.2.62 (latest)
Describe the bug
A possible issue preventing the package from working with Filament
I wanted to create a resource for my model, and to my surprise, when I went to access the resource (List), I encountered the error
Exception
PHP 8.2.16

10.48.4
SSL CA bundle not found: ssl/http_ca_local.crt

Upon reviewing, the first test I performed was to go to tinker to check the status of Elastic's installation and its interaction with the package
> $wa = WorkAnalyzer::orderBy('datetime', 'asc')->first()
= App\Models\WorkAnalyzer {#10033
    _id: "qjPMSY4Bh1MJNmfqLuZ3",
    log_id: "01HQGZBVRAW7YQZXK4DGG0KB0V",
    datetime:<PHONE_NUMBER>,
    provider: "prilux",
    powrea_var: 2160.0,
    pa1_w: 0.0,
    pa2_w: 6740.0,
    pa3_w: 8720.0,
    pr1_var: 500.0,
    pr2_var: 960.0,
    pr3_var: 700.0,
    iac1_a: 40760.0,
    iac2_a: 28720.0,
    iac3_a: 37300.0,
    vac1_v: 240.9,
    vac2_v: 240.0,
    vac3_v: 237.1,
    pf1: 0.98,
    pf2: 0.97,
    pf3: 0.98,
    status_code: 200,
    modem_id: 3323,
    timestamps: [
      "job" => "2024-02-25T20:30:06+00:00",
      "delayed_at" => null,
    ],
  }

> $wa->datetime;
= "2024-02-25 19:26:43"

> WorkAnalyzer::count()
= 1698367

Exception
SSL CA bundle not found: ssl/http_ca_local.crt (View: /Users/abkrim/Sites/sitelight/vendor/filament/tables/resources/views/index.blade.php) (View: /Users/abkrim/Sites/sitelight/vendor/filament/tables/resources/views/index.blade.php)
vendor/pdphilip/elasticsearch/src/DSL/Bridge.php#579

It struck me as odd to see the file where the error was encountered,
public function _countAggregate($wheres, $options, $columns): Results
{
    try {
        $params = $this->buildParams($this->index, $wheres);
        $process = $this->client->count($params);

        return $this->_return($process['count'] ?? 0, $process, $params, $this->_queryTag(__FUNCTION__));
    } catch (Exception $e) {

        $result = $this->_returnError($e->getMessage(), $e->getCode(), [], $this->_queryTag(__FUNCTION__));
        throw new Exception($result->errorMessage);
    }

}

He buscado algo mas sobre el tema, peor no localizo nada. <
Best regards.
Screenshots:

Component Versions (Paste in the require section from your composer.json file):
  "require": {
  "php": "^8.1",
        "ext-pdo": "*",
        "ext-redis": "*",
        "ext-zlib": "*",
        "archtechx/enums": "^0.3.0",
        "babenkoivan/elastic-scout-driver": "^3.0",
        "babenkoivan/elastic-scout-driver-plus": "^4.2",
        "barryvdh/laravel-debugbar": "^3.13",
        "barryvdh/laravel-dompdf": "^2.0",
        "binarytorch/larecipe": "^2.5",
        "codeat3/blade-google-material-design-icons": "^1.18",
        "codeat3/blade-iconpark": "^1.5",
        "codeat3/blade-jam-icons": "^1.5",
        "dompdf/dompdf": "^2.0",
        "elasticsearch/elasticsearch": "^8.10",
        "filament/filament": "^3.0-stable",
        "geokit/geokit": "^1.3",
        "guzzlehttp/guzzle": "^7.2",
        "laravel-notification-channels/telegram": "^4.0",
        "laravel/framework": "^10.0",
        "laravel/horizon": "^5.17",
        "laravel/pail": "^1.0",
        "laravel/prompts": "^0.1.13",
        "laravel/sanctum": "^3.2",
        "laravel/scout": "^9.8",
        "laravel/tinker": "^2.7",
        "leandrocfe/filament-apex-charts": "^3.1",
        "livewire/livewire": "^3.0",
        "lorisleiva/laravel-actions": "^2.4",
        "maatwebsite/excel": "^3.1",
        "matanyadaev/laravel-eloquent-spatial": "^3.1",
        "novadaemon/filament-pretty-json": "^2.0",
        "owen-it/laravel-auditing": "^13.3",
        "pdphilip/elasticsearch": "~3.10",
        "predis/predis": "^2.2",
        "ramsey/uuid": "^4.7",
        "robinvdvleuten/ulid": "^5.0",
        "saade/filament-laravel-log": "^3.0",
        "silber/bouncer": "^1.0",
        "spatie/laravel-backup": "^8.4",
        "spatie/laravel-data": "^2.1",
        "spatie/laravel-health": "^1.27",
        "spatie/laravel-query-builder": "^5.1",
        "spatie/laravel-rate-limited-job-middleware": "^2.2",
        "spatie/laravel-ray": "^1.35",
        "spatie/laravel-settings": "^2.8",
        "spatie/laravel-translatable": "^6.1",
        "spatie/simple-excel": "^3.0",
        "vlucas/phpdotenv": "^5.4"
  },

Best regards.
Edit for more information
If I use in ES_SSL_CERT a fullpath works.
Well, the certificate problem passes but others appear.
And I have verified that it worked with the complete path both in the tinker and in my already-created commands.
But I think that is a problem that is not defined because, in principle, everything I have at the configuration level uses a path relative to the path of the app.

Relative to second problem
By taking as a solution to enter the full path, the action is executed but, I understand that during it, there are a series of jobs from the package, which use the _id field (aggregations?)
As I understand the use of _id for these issues, it was deprecated in version 7.6 and disabled by default in versions 8.X:
{
	"error": {
		"root_cause": [
			{
				"type": "illegal_argument_exception",
				"reason": "Fielddata access on the _id field is disallowed, you can re-enable it by updating the dynamic cluster setting: indices.id_field_data.enabled"
			}
		],
		"type": "search_phase_execution_exception",
		"reason": "all shards failed",
		"phase": "query",
		"grouped": true,
		"failed_shards": [
			{
				"shard": 0,
				"index": "analyzers-2022111701",
				"node": "dTTpCTBqRbSYbWfW4vyFUg",
				"reason": {
					"type": "illegal_argument_exception",
					"reason": "Fielddata access on the _id field is disallowed, you can re-enable it by updating the dynamic cluster setting: indices.id_field_data.enabled"
				}
			}
		],
		"caused_by": {
			"type": "illegal_argument_exception",
			"reason": "Fielddata access on the _id field is disallowed, you can re-enable it by updating the dynamic cluster setting: indices.id_field_data.enabled",
			"caused_by": {
				"type": "illegal_argument_exception",
				"reason": "Fielddata access on the _id field is disallowed, you can re-enable it by updating the dynamic cluster setting: indices.id_field_data.enabled"
			}
		}
	},
	"status": 400
}

When I wanted to activate it, I found literature on the issue, in the changes to version 8.0 of Elasticsearch.
Migrating to 8.0

Aggregating and sorting on _id is disallowed by default.
Details
>Previously, it was possible to aggregate and sort on the built-in _id field by loading an expensive data structure called fielddata. This was deprecated in 7.6 and is now disallowed by default in 8.0.
Impact
>Aggregating and sorting on _id should be avoided. As an alternative, the _id field’s contents can be duplicated into another field with docvalues enabled (note that this does not apply to auto->generated IDs).

For the cert issue, this would be environment-related. This value is passed directly to the elasticsearch PHP client. If you want to, edit the config in the database.php file to use the apps root for example.
I'm not familiar with FIlament, but that error is usually thrown when you try to chunk (which uses the _id) for sorting by default. See: https://elasticsearch.pdphilip.com/chunking
chunkById is the alternative.
Can you check further don't your stack trace to see the query that it was trying to run?

Thank you so much.
For the strange question of the certificate path, did I opt for 'ssl_cert' => env('ES_SSL_CERT')? base_path(env('ES_SSL_CERT')) : null, and it works perfectly across the board.
For the other, my apologies because I can't remember the chunking issue.
And if the real reason is how Filament works the construction of the tables, in which it works on a scan that, from what I see in its code, the use of Model::chunkById is quite unacceptable:
Even so, I have written on their Discord channel and I hope to make some progress. Otherwise, I will have to create my own table with Livewire directly.
Thank you very much for your answer.
![Castris400 Bad Request](https://github.com/pdphilip/laravel- elasticsearch/assets/1238625/2095e706-584c-47e4-8630-a17f6eec78f1)

Hello. Nothing. I investigated the matter and it is not a Filament issue itself but rather a Livewire issue.
The implication is harsh, since I did not find a way, since the chunkById and chunk methods do not work for mounting the Livewire (or Filament) instance.
So with both left out, the only thing left is to work with Blade and add certain functionalities with Alpine.js
Thanks for everything.

Thanks for the update. Can you give me a simple way to replicate this breakage using livewire?
Let's see if there's a way forward.

Your help appreciated.
I continued investing and I did not see the error, because I am untrained with Livewire.
And the truth is I'm surprised since one thing is the Filament system and another is Liviwire, where you put together the code with what you need.
So effectively in Livewire, you can perfectly create a page with the list, widgets for searches, etc.
Route::get('/work-analyzers', App\Livewire\WorkAnalyzers\ListWorkAnalyzers::class);

<?php

namespace App\Livewire\WorkAnalyzers;

use App\Models\WorkAnalyzer;
use Illuminate\Contracts\View\View;
use Livewire\Component;
use Livewire\WithPagination;

class ListWorkAnalyzers extends Component
{
    use WithPagination;

    public function render(): View
    {
        return view('livewire.work-analyzers.list-work-analyzers', [
            'workAnalyzers' => WorkAnalyzer::paginate(10),
        ]);
    }
}

    @foreach ($workAnalyzers as $workAnalyzer)

lod_id }}">

{{ $workAnalyzer->_id }}

    @endforeach

        {{ $workAnalyzers->links() }}

I found something but no matter how much I turned it over, it didn't work. But it nevertheless encourages me to think that I can click on Filament to see if it includes the facility to integrate your package. It would be great, since RAd with Filamente is brutal, compared to having to deploy tables and forms with Livewire dry.
Implement en Filament Laravel Socut
Best regards and happy weekend

@abkrim, I've reworked the chunkById method to work independently of the _id field. Currently on Dev branch: https://github.com/pdphilip/laravel-elasticsearch/tree/dev
Please can you try this dev version and let me know if that solved this issue. Once confirmed it will be in the next release.
Thank you

Oh my God.
This afternoon I will update my installation to test it. Sure.
A lot of thanks in advance.

Hello.
I opened a new project to leave only the theme in a row with the model resource that uses one of the indexes, and not have noise around it.
But I don't know if I have to do anything else.
I tried

Default model
Model indicating that my first field is a different log_id, which is an internal ulid that I generate in each doc when I send it.
I have not been able to apply the tip that exists for Laravel Scout because I cannot find the proposed methods.

❯ composer info pdfphilip/elasticsearch
name : pdfphilip/elasticsearch
description : An Elasticsearch implementation of Laravel's Eloquent ORM
keywords: database, elastic, elasticsearch, eloquent, laravel, model
versions: * dev-dev
type: library
license : MIT License (MIT) (OSI approved) https://spdx.org/licenses/MIT.html#licenseText
homepage: https://github.com/pdphilip/laravel-elasticsearch
source: []

I don't know if this information will contribute anything.
Best regards.

Hey @abkrim, were you not able to pull in the dev version, or is it that the problem is still the same even with the dev version?

Hello.
Yes I use a package based on laravel-elasticsearch\dev
And with this package used in a fresh Laravel 11 with only models extended eloquent with your package, get the same problem.
400 Bad Request: {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"Fielddata access on the _id field is disallowed, you can re-enable it by updating the dynamic cluster setting:

protected function _returnSearch($params, $source)

    {

        if (empty($params['size'])) {

            $params['size'] = $this->maxSize;

        }

        try {

            $process = $this->client->search($params);

            return $this->_sanitizeSearchResponse($process, $params, $this->_queryTag($source));

        } catch (Exception $e) {

            $result = $this->_returnError($e->getMessage(), $e->getCode(), $params, $this->_queryTag(__FUNCTION__));

            throw new Exception($result->errorMessage); // Here line

        }

    }

I'm sorry if I don't express myself correctly.

Ok, so it's not chunking. Can you look further down the trace to see what the eloquent query was that was being called? See if you're able to get the parameters as well.
My guess is that it's trying to order by _id somewhere...

I'm not able to recreate this in my testing with Filament - using ES models seems to work fine for me with Laravel 11.
Can you share a private repo with me so I can see exactly what you're seeing?

I'm sorry for not having responded sooner.
I have been sick, and I couldn't even get close to the team.
Since I cannot give private access to the project since it is not mine, and my client is very strict with the security of the project, I have opted for a clone, in which I only reproduce one of the indexes.
However, when I updated the dev today, I saw that there are new features and these do not seem to be in the documentation.
Since I wanted to adapt the repository to the problem, I created a seeder to fill the model a little in order to see the problem.
But my surprise is that the seeder throws me an exception:
a db:seed --class WorkAnalyzerSeeder

   INFO  Seeding database.

   TypeError

  PDPhilip\Elasticsearch\Connection::getIndexPrefix(): Return value must be of type string, null returned

  at /Users/abkrim/Sites/packages/laravel-elasticsearch/src/Connection.php:42
     38▕     }
     39▕
     40▕     public function getIndexPrefix(): string
     41▕     {
  ➜  42▕         return $this->indexPrefix;
     43▕     }
     44▕
     45▕     public function setIndexPrefix($newPrefix): void
     46▕     {

  1   /Users/abkrim/Sites/packages/laravel-elasticsearch/src/DSL/Bridge.php:42
      PDPhilip\Elasticsearch\Connection::getIndexPrefix()

  2   /Users/abkrim/Sites/packages/laravel-elasticsearch/src/Connection.php:229
      PDPhilip\Elasticsearch\DSL\Bridge::__construct(Object(PDPhilip\Elasticsearch\Connection))

I put this a public gitlab report in my own server. https://gitlab.castris.com/root/sitelight_v11

Have updated dev branch to allow null prefixes, or just edit the vendor directly for testing: https://github.com/pdphilip/laravel-elasticsearch/commit/3577bb31b766dee28f3148c6b2206bd8fd65ced8
Had a quick look at your sample repo, seems ok:

Am I missing something?

Oh... my God.
I've updated dev with changes and same problem.

400 Bad Request: all shards failed - Fielddata access on the _id field is disallowed, you can re-enable it by updating the dynamic cluster setting: indices.id_field_data.enabled
Run seeder (I updated for use createWithoutRefresh)
Go to https://sitelight_v11.test/admin/work-analyzers and get error.

400 Bad Request: all shards failed - Fielddata access on the _id field is disallowed, you can re-enable it by updating the dynamic cluster setting: indices.id_field_data.enabled

It is possible that in your test Elasticsearch has Fielddata access on the _id field allowed?
Best regards.

My bad! Try now, latest on dev

Oh... I feel happy.
Incredible your work.
Now works fine.

Your package and your work deserve a lot of stars.
Many thanks.

Thanks @abkrim, these are great upgrades for the package - glad you brought it to my attention.

Hey @abkrim, the latest release has this fixed

Laravel 10/11 v4.0.1
Laravel 9 v3.9.1

Thanks again


Look into why enabling low memory mode prevents group chat notifications from coming in

I have no idea - I looked into this and see no reason why it shouldn't be working.

I have no idea - I looked into this and see no reason why it shouldn't be working.

Did you try to replicate it?

Nope  but I've enabled it now if you wanna send notifications

Can we close this? This one seems like a stretch tbh


Align the semantic segmentation with Cityscapes

Hi,
Till now only 12 categories (road, lane-marking, traffic sign, sidewalk, fence, pole, wall, building, vegetation, vehicle, pedestrian, and other.) are supplied in Carla. I am wondering if it is possible or if it is in the plan to add more categories and align the semantic classes with Cityscapes which have more categories.

Hi @EthanZhangYi,
It is entirely possible to add your own tags.
By now it is a bit complicated and requires to modify the code. It is not well documented right now but you can find a clue in the docs.
I'll keep this issue opened until you are able to do it.

I close this issue for lack of feedback :(

Hi @marcgpuig , I'm trying to align the tag ID of Carla output segmentation to the Cityscapes classes, so I just need to edit the Tagger.cpp and Tagger.h? Is that correct?

@Nozomeister yes :)


UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf3 in position 1970: invalid continuation byte

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf3 in position 1970: invalid continuation byte
It is an old issue that remains with the last python and pip versions
Windows 10 pro 64 bits
pip version: pip 10.0.1 from c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip (python 3.7)
Same message installing and unistalling a local package
Exception:
Traceback (most recent call last):
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_internal\basecommand.py", line 228, in main
status = self.run(options, args)
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_internal\commands\install.py", line 335, in run
use_user_site=options.use_user_site,
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_internal\req_init_.py", line 42, in install_given_reqs
auto_confirm=True
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_internal\req\req_install.py", line 660, in uninstall
uninstalled_pathset = UninstallPathSet.from_dist(dist)
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_internal\req\req_uninstall.py", line 355, in from_dist
for path in uninstallation_paths(dist):
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_internal\req\req_uninstall.py", line 50, in unique
for item in fn(*args, **kw):
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_internal\req\req_uninstall.py", line 67, in uninstallation_paths
r = csv.reader(FakeFile(dist.get_metadata_lines('RECORD')))
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_vendor\pkg_resources_init_.py", line 1408, in get_metadata_lines
return yield_lines(self.get_metadata(name))
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_vendor\pkg_resources_init_.py", line 1405, in get_metadata
return value.decode('utf-8') if six.PY3 else value
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf3 in position 1970: invalid continuation byte
What can I do?

I don't know if this is the case, but Python 3.7 is not supported.

https://github.com/kennethreitz/requests-html/blob/master/README.rst
Only Python 3.6 is supported.

Thank you David for your comment.
I had the same error with Python 3.6 and thats because I tried Python 3.7
The error comes in the un-installation
pip uninstall vrt
Exception:
Traceback (most recent call last):
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_internal\basecommand.py", line 228, in main
status = self.run(options, args)
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_internal\commands\uninstall.py", line 68, in run
auto_confirm=options.yes, verbose=self.verbosity > 0,
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_internal\req\req_install.py", line 660, in uninstall
uninstalled_pathset = UninstallPathSet.from_dist(dist)
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_internal\req\req_uninstall.py", line 355, in from_dist
for path in uninstallation_paths(dist):
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_internal\req\req_uninstall.py", line 50, in unique
for item in fn(*args, **kw):
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_internal\req\req_uninstall.py", line 67, in uninstallation_paths
r = csv.reader(FakeFile(dist.get_metadata_lines('RECORD')))
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_vendor\pkg_resources_init_.py", line 1408, in get_metadata_lines
return yield_lines(self.get_metadata(name))
File "c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip_vendor\pkg_resources_init_.py", line 1405, in get_metadata
return value.decode('utf-8') if six.PY3 else value
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf3 in position 1970: invalid continuation byte
pip 10.0.1 from c:\users\vicen\appdata\local\programs\python\python37\lib\site-packages\pip (python 3.7)
Is there an other way to unistall the package?
Perhaps unistall and install again could solve the problem

Uninstalled deleting the vrt and  vrt-0.0.1.dist_info folders
Pip install ./ works well
but ...
pip uninstall vrt gives again the same error

I see that you are on Windows. At least on Debian I coudn't reproduce it. Is this process of uninstaling important to you?

(test-req-html-V7ulK-Id) david@debian64:~/dev/test-req-html$ pip uninstall requests-html
Uninstalling requests-html-0.9.0:
Would remove:
/home/david/.virtualenvs/test-req-html-V7ulK-Id/lib/python3.6/site-packages/requests_html-0.9.0.dist-info/*
/home/david/.virtualenvs/test-req-html-V7ulK-Id/lib/python3.6/site-packages/requests_html.py
Proceed (y/n)? y
Successfully uninstalled requests-html-0.9.0

I am closing this now. If someone brings new information, I can open it again.

What is vtr package? What is it relation with requests.html?


Made arg injection to be a hint.

Stack:

#6595
#6579 ⬅

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is

crates/cairo-lang-runnable-utils/src/builder.rs line 294 at r1 (raw file):

                    tempvar first;
                    const param_index = param_index;
                    hint ExternalHint::WriteRunParam { index: param_index } into { dst: first };

Are the parameters a list of felts or typed objects?
Code quote:
   hint ExternalHint::WriteRunParam { index: param_index } into { dst: first };

crates/cairo-lang-runner/src/casm_run/mod.rs line 90 at r1 (raw file):

    pub runner: Option<&'a SierraCasmRunner>,
    /// The user arguments for the run.
    pub user_args: Vec<Vec<Arg>>,

why not?
can you document it better?
Suggestion:
Vec<Arg>,

crates/cairo-lang-runnable-utils/src/builder.rs line 294 at r1 (raw file):
Previously, orizi wrote…
this allows us the flexibility of setting the values up one by one (as you can see - we don't get all the values and than send them to whereever required for the wrapped function.

What is the benefit of doing that?

crates/cairo-lang-runnable-utils/src/builder.rs line 292 at r3 (raw file):

            if *ty_size > 0 {
                casm_build_extend! { ctx,
                    tempvar first;

how many ap+=
instructions is this going to generate?
didn't we want 1
ap += {all_params_size}
Instruction?
Code quote:
                    tempvar first;

crates/cairo-lang-runner/src/casm_run/mod.rs line 92 at r3 (raw file):

    ///
    /// We have a vector of the arguments per parameter, as user defined may be composed of several
    /// user args.

Suggestion:
    /// We have a vector of the arguments per parameter, as a parameter type may be composed of several
    /// user args.

crates/cairo-lang-runnable-utils/src/builder.rs line 294 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
why wou

why wouldn't they be continuous?

crates/cairo-lang-runnable-utils/src/builder.rs line 294 at r1 (raw file):
Previously, orizi wrote…
currently - i think gas might not be right before the other params (and it is currently injected) - for other params - i guess not.

why is the gas injected from a hint?

crates/cairo-lang-runnable-utils/src/builder.rs line 294 at r1 (raw file):
Previously, orizi wrote…
So it won't change the program hash if it is provided.

does not seem correct to me, but I'm unblocking.