Add login requirement for API endpoint

Changes Made:

Secured the API endpoint by requiring login using Django's built-in authentication and permission system.
Fixed an error in app.tsx that caused a type mismatch issue by using conditional rendering instead of the logical operator.
Set up Tailwind CSS to enhance the UI and improve the visual appearance of the application.

Details:

Added the necessary authentication and permission classes to the API view to require login for accessing the endpoint.
Used the SessionAuthentication class for authentication, allowing users to authenticate using session-based authentication.
Applied the IsAuthenticated permission class to ensure only authenticated users can access the view.
Fixed the type mismatch issue in app.tsx by replacing the logical && operator with conditional rendering using the ternary operator.
Utilized the conditional rendering to display a loading message when the isLoading flag is true and render the authenticated content when the user is authenticated.
Configured and integrated Tailwind CSS to enhance the user interface, making it visually appealing and improving the overall UI design of the application.

These changes aim to enhance security, resolve errors, and improve the user interface of the application.

I sent you a gmail message about the changes you made :)


Implement diaper leakage

It's tricky because preferably you'd draw something or visualize leakage, I've done a particle system before so ask me about it. Alternative is to switch the diaper model or overlay something on the diaper but it might be unclear.


Refactor Top-Level Non-Closure Functions to Use Function Notation

Currently in the codebase, functions use a mix of the regular "function name() {}" and the arrow "const name = () => {}" function notation. I think it would be clearer if all top-level functions are refactored to use the regular syntax and arrow functions are reserved for closures, callbacks, and higher-order functions.


ZAP now has hooks for customizing scans

I just wanted to highlight that ZAP baseline scripts now have a hook system to add in your custom functionality instead of having to fork scripts & add your mods.
https://github.com/zaproxy/zaproxy/blob/develop/docker/docs/scan-hooks.md
Here is an example of fully using the hooks to customize scanning against Juice Shop.
https://github.com/rezen/zap-tutorial/blob/master/assets/hooks-goal.py

Hi, we already had a branch which implemented this. This branch is now merged to the master!


[IOTDB-3103] Implementation of NonOverlappedMultiColumnMerger

Coverage decreased (-0.004%) to 53.705% when pulling 824ef3434edc5a3c79745f8ff5191ee1f71d168e on stable-mpp into a67a260d23abec347801b0086131437c823cdf09 on master.


Using x-forwarded-proto instead of protocol if avaiable

Fixes issue with aws elastic load balancer.
The original request is https, and so the signature was generated using https, but with eb, the request from the load balancer to the ec2 instance is http. By checking x-forwarded-proto we can determine the protocol used to sign the request in this scenario.

https://github.com/omsmith/ims-lti/pull/28
https://github.com/omsmith/ims-lti/pull/43
https://github.com/omsmith/ims-lti/issues/55
Still think this is necessary?

Ok, I'll have to think about this. We are having a different issue related to being behind a load balancer with another part of our app, so probably addressing this at the server level is better. We are using koa. Thanks for the feedback


Remove -it option from update-actions target

Followup to #50
Summary
Remove unnecessary -it from the update-actions target which breaks the transitive-actions.yml workflow.

I confirmed this fixed the problem identified in https://github.com/ericcornelissen/tool-versions-update-action/pull/50#issuecomment-1642773134 with run<PHONE_NUMBER> which succeeded.


PC actor tab for bridge crew role ranks

Add a tab to PC actor sheets to manage and track current WJ bridge crew role ranks. Ranks do not function like 5e skills so it's probably best to just add a custom tab on the actor sheet.

No more new features


Update Developer Guide - Use Cases

More details

For reference (as per the CS2103 website @dillontkh linked above):

Use cases: Give use cases (textual form) for a few representative user stories that need multiple steps to complete. e.g. Adding a tag to a person (assume the user needs to find the person first)


OSError: [WinError 50] The request is not supported

Describe the bug
pygame 2.6.0 (SDL 2.28.4, Python 3.11.9)
Hello from the pygame community. https://www.pygame.org/contribute.html
[2024-06-29 11:46:39] [INFO    ] discord.client: logging in using static token
[2024-06-29 11:46:40] [INFO    ] discord.gateway: Shard ID None has connected to Gateway (Session ID: ed9c92f85116ce56b58810c36692de3f).
[2024-06-29 11:46:42] [ERROR   ] discord.client: Ignoring exception in on_ready
Traceback (most recent call last):
File "discord\client.py", line 449, in _run_event
File "source_prepared.py", line 156, in on_ready
File "subprocess.py", line 466, in check_output
File "subprocess.py", line 548, in run
File "subprocess.py", line 992, in init
File "subprocess.py", line 1407, in _get_handles
File "subprocess.py", line 1416, in _make_inheritable
OSError: [WinError 50] The request is not supported
To Reproduce
Steps to reproduce the behavior:
running exe

OS: Windows 11
Python Version: 3.11

i also hade this problem have you found a fix?


Lizard exclude parameter being generated incorrectly by the plugin

I tried to set a exclude parameter with multiple patterns but the plugin is incorrectly generating the command so lizard ignores the patterns.
Here's the plugin call on fastlane
lizard(
      source_folder: ".",
      exclude: "./Folder1/Subfolder1/*, ./Folder2/*",
      language: "swift",
      export_type: "xml",
      report_file: "sonar-reports/lizard-report.xml"
    )

The command generated is:
lizard -l swift --xml -x ./Folder1/Subfolder1/* -x ./Folder2/* . > sonar-reports/lizard-report.xml
But according to lizard documentation it should be:
lizard -l swift --xml -x "./Folder1/Subfolder1/*" -x "./Folder2/*":  . > sonar-reports/lizard-report.xml
Reference: https://github.com/terryyin/lizard/blob/master/README.rst
Don't forget to add "" around the pattern.

@Unknoob thank you for your contribution. I have approved and merged your fix.
You are now added as a collaborator for this plugin. Once again thank you


feat: add option to add helm cm-push args

This adds the options to pass extra arguments to the helm cm-push command. (#15)
Example usage:
[
    "semantic-release-helm3",
    {
        chartPath: './chart',
        registry: 'https://nexus.domain.tld/repository/department-helm',
        onlyUpdateVersion: true,
        isChartMuseum: true,
        cmPushArgs: `--context-path "/repository/department-helm"`
    }
],

I tested my changes via:

npm pack in this repo
referenced as file in my package.json in the application repo"semantic-release-helm3": "file://./semantic-release-helm3-2.5.1.tgz"
created a dummy commit for semantic-release
tested it without the extra configuration:  export REGISTRY_USERNAME=*** && export REGISTRY_PASSWORD=*** && pnpm -r exec semantic-release --ci=false
Result: `Method not allowed (405)
Added the config

cmPushArgs: `--context-path "/repository/department-helm"`

created another dummy commit for semantic-release
tested it with the new configuration:  export REGISTRY_USERNAME=*** && export REGISTRY_PASSWORD=*** && pnpm -r exec semantic-release --ci=false

The package got pushed 🎉
I am not sure what else needs to be considered for this change.
Closes https://github.com/nflaig/semantic-release-helm/issues/15

Published<EMAIL_ADDRESS>


Add example interaction with the server to chapter 10

This could be in lieu of a figure with the same information.

Hmm, I'm worried this will be hard to read and take up a lot of space. I think I would rather a figure.


Fix leaks

I need help with tracking down the last CanvasItem RID. I can't find it

Any way this is still in draft?

I haven't found the last leaked canvas item

The last leaked CanvasItem can be found later.

Thanks!


[Bug] upgrade zookeeper version to fix ZOOKEEPER-4377

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the bug
https://issues.apache.org/jira/browse/ZOOKEEPER-4377

Affects Version(s)
1.9.2
Kyuubi Server Log Output
No response
Kyuubi Engine Log Output
No response
Kyuubi Server Configurations
No response
Kyuubi Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?

[ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
[ ] No. I cannot submit a PR at this time.

do search before asking https://github.com/apache/kyuubi/issues/6496


TILA-1613 | Add capability for querying application events to gql

First part of the application event gql api - mutations coming after this.
TILA-1613

@kieferbonk @siren This renames ageGroupDisplay field to ageGroup from ApplicationEventType


Create/Deploy/Remove roles depend on Validate role

The validate role can be executed individually, however the create, deploy, and remove roles depend on the validate role which creates the service model. Executing these roles individually fails:
TASK [cisco.nac_dc_vxlan.common : ansible.builtin.fail] *********************************************************************************************
fatal: [marehler_vnd2]: FAILED! => {"changed": false, "msg": "Service Model Not Defined.  Role cisco.nac_dc_vxlan.validate Must Be Called First"}

For a CI/CD workflow integration it might be desirable to execute all roles in different stages, i.e. execute one role per stage. Running the validate role in a "Validate" stage, and again in "Create" and "Deploy" stages for re-creating the service model would be duplicate effort and time.

Indeed the validate role is a dependency as the rendered in-memory data model and subsequent massaging of the runtime model is rendered from the model validation. To make what you describe as achievable, the validate role has been added as an dependency to each role in the latest release (0.2.0). The validate role to-date only takes about ~1 sec to run.
I'm going to close this issue for now as this the current intended functionality. We can revisit if any complications are seen.

Verified. Works fine, if you execute the create and/or deploy role only, the validate role is now included automatically.


Add TCPC drivers for TCPCI and PS8815

Improve USB-C PD stack support for different TCPC drivers.
Add support for TCPCI compliant chips and add driver for Parade PS8815 using TCPC subsystem.

@sambhurst please take a look
@barnas-michal please rebase


base href: <script src="...">.... does it respect base href?

Using polymer version 2.
Using /, to go to the root of the server doesn't seem to work.
It goes to root without respecting the base href just set.
What happens is outputs#2 is selected instead of http://localhost/basePath/someFile.js as one would espect.
Is this a supported feature, if not I think it requires explicit mention.
Output of interest why do people continue to write all their JavaScript code inline? Although this isn't a valid reason, it just makes source code analysis and formatting more complicated.

index.html:
<base href="/basePath/">

in a different directory that is a child of the index.html:
someDir/someElement.html:
<some-element>
   <script src="someFile.js"></script>
   <script src="/someFile.js"></script>
</some-element>

ouputs:

http://localhost/basePath/someDir/someFile.js.
http://localhost/someFile.js.

Sorry for the delay on this. Polymer should not be changing the default browser behavior here.
Your setup here is not clear, would you mind clarifying or providing a reproduction of the problem. Thanks

Thanks for the issue.  Please see CONTRIBUTING.md for guidelines on filing issues.  Please fill out as many fields in the issue template as possible, and be sure to include a live reproduction so that the team can debug or understand your issue.  You can start from this jsBin template as a starting point and link it in the issue template under "Live Demo".
Feel free to file a new issue following these instructions.  Thank you!

works for me


Release v1.7.0

I've released an initial beta release of v1.7.0 to https://maputnik.github.io/releases/v1.7.0-beta/
There is a list of all the PR's included here https://github.com/maputnik/editor/milestone/5, as well as 2 pending PR's to be included in the next beta release.
Tasks

Identify improvements that need more than a 'changelog line' for documenting in the release blog post. Expressions initially come to mind, but there are others.
Test, test, test
Write release blog post
Celebrate 🎉

I found error after click map feature.

Thanks @Jinkwon fixed in https://github.com/maputnik/editor/pull/632

OSM Liberty style:
There are errors shown for fill-extrusion-base and fill-extrusion-heigth:

I have released v1.7.0-beta2 to https://maputnik.github.io/releases/v1.7.0-beta2
I also re-released v1.7.0-beta as it was missing the commit that actually tagged the release, it's not that important but just to be 'correct'.
Note that I'm aware that in v1.7.0-beta2 the logo/version overflows it's element, I'll fix that in v1.7.0-beta3 as it's just a styling issue it shouldn't stop us testing though.

Note: Link to Thunderforest blog posts from Maputnik release blog post, see https://github.com/maputnik/editor/issues/641#issuecomment-612587702

Now it's possible to edit a layers source field (https://github.com/maputnik/editor/issues/421) but the inline error is missing:

@pathmapper are there any more issues we need to fix before release of v1.7.0 that aren't in the milestone https://github.com/maputnik/editor/milestone/5 ? If so could you please add them to the milestone.
Note: I'll release a v1.7.0-beta3 later on tonight or tomorrow.

are there any more issues we need to fix before release of v1.7.0

@orangemug no, I think we are good to go. I'm not aware of any regressions which are causing any noticeable issues.

Almost there

I've release v1.7.0-beta3 with all the latest changes
I've written the release blog post over at https://github.com/maputnik/maputnik.github.io/pull/25 please leave any feedback in that PR

All going well with the latest release, I'll aim to release the official 1.7.0 release tonight/tomorrow

Released v1.7.0-beta4 with fix in #661

We need to resolve https://github.com/maputnik/editor/issues/662#issuecomment-617022729 before  release. If no other issues are raised I'll skip a new beta and release straight to v1.7.0

Just an update it'll now be tomorrow (probably evening) I'll release v1.7.0 I got a little busy with the day job yesterday/today.

v1.7.0 has been released 🎉
Thanks everyone, see the release blog post over at https://maputnik.github.io/blog/2020/04/23/release-v1.7.0


Integrate Proposal Discussion Forum Figma files into GovTool

The Proposal Discussion Forum is not a separate app but simply a part of GovTool. Having someone work on it in an external file makes it difficult or even impossible to see how it fits in with GovTool from a user perspective.
Moving the designs into GovTool makes a lot of sense.

This has not been done

Its already covered for work elsewhere.


ATM9 Occultism Dictionary of Spirits blocking Server Entry

Describe the bug
I cannot join my ATM9 server we JUST created because we get this error code every time.
To Reproduce

Attempt Join ATM9 server
Receive error code

Expected behavior
I just want to be able to join the new server
Screenshot
see attached

System (please complete the following information):

Occultism Version: 1.137.0

OS: Windows 11

Minecraft Version: 1.20.1

Modpack Link and Version, or list of mods: ATM9, loaded through prism launcher/curse forge

Additional context
Our server is bisect hosting, so I don't know if it is a problem with that? But it’s only this occultism message I receive, so I think it might be something I need to change within the mod

The occultism version on the Server was 1.137.0 so i changed the Prism Launcher version to 1.137.0 a well and it still happens. I just found the other report you mentioned and i tried changing both to the newest version, 1.139.0 and I get the same error report.

i see that i have 1.75.0 jar for modonomicon on the server and i have both 1.75 and 1.77 on the prism launcher. i can remove the 1.77 so there is no difference in versions and let you know if it works. I had no idea modonomicon handled the book, that's pretty neat

I just set up a local ATM9 server and joined it without issue.
I am on ATM version 0.3.2 without modifications, client installed from curseforge launcher, server downloaded from https://www.curseforge.com/minecraft/modpacks/all-the-mods-9/files/5682518/additional-files
Can you try with that version if you can join?
If it does not work, can you try to do it with the launcher and files I used with a local server?
(when downloading the server pack from ATM you just need to run "startserver.bat" and it does everything for you)

I just changed the prism launcher version to 1.77 and now i receive this message

I am not very familiar with how some of this works, I have a friend that I own the server with and he knows a lot more about what you are saying and the recommendations you have, so when he gets off work I will show him your responses and see if he can use that information to fix it and I can let you know which thing you recommended worked! I appreciate your help, thank you

I am not very familiar with how some of this works, I have a friend that I own the server with and he knows a lot more about what you are saying and the recommendations you have, so when he gets off work I will show him your responses and see if he can use that information to fix it and I can let you know which thing you recommended worked! I appreciate your help, thank you

Excellent! If you or your friend find any way to reproduce this without bisect (as in: Download server files, start server, start client, connect) please let me know, in that scenario I might be able to find out more

sounds great! I'll be sure to get back to you, thanks a bunch!

Closing as stale, please tag me if it pops up again.


fix: Correctly handle void elements

Ref: #54

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.94%. Comparing base (9ffa2c8) to head (97fa4eb).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   94.92%   94.94%   +0.01%
==========================================
  Files          42       42
  Lines        2583     2593      +10
==========================================
+ Hits         2452     2462      +10
  Misses        131      131

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Embedded web view user agents not parsed as expected on Ios and Android

Discussed in https://github.com/ActiveLogin/ActiveLogin.Authentication/discussions/375

Originally posted by span July  8, 2022
Question
How can I return the bankid:/// scheme BankID link as done in https://demo.activelogin.net when logging in through an embedded webview?
Describe the problem
When calling Initialize from Instagram embedded webview on Android and iOS (have not checked all versions), the App Link https://app.bankid.com... is received. The embedded views do not handle this link properly and cannot detect the device.
To solve this, it seems to me the bankid:/// link  should be returned, as it is on the demo site. I cannot figure out how to do it, and I cannot verify the demo site source code (although I presume it is mostly similar to the samples?).
I tried investigating the device detection and I ran the unit tests on the sample header below, and it correctly identifies it as Chrome and Android. Thus the App Link is resolved. However, when sniffing the traffic in a proxy to check what link is received from demo site, I get the bankid:/// link!
This is full response:
{
  "isAutoLaunch": true,
  "deviceMightRequireUserInteractionToLaunchBankIdApp": true,
  "checkStatus": true,
  "orderRef": "<redacted>",
  "redirectUri": "bankid:///?autostarttoken=<redacted>&redirect=null",
  "qrStartState": null,
  "qrCodeAsBase64": null
}

Request headers
METHOD: POST
URL
<redacted>/Api/Initialize
HEADERS
accept:
application/json
accept-encoding:
gzip, deflate
accept-language:
en-SE,en-US;q=0.9,en;q=0.8,sv-SE;q=0.7,sv;q=0.6
connection:
keep-alive
content-length:
1702
content-type:
application/json
cookie:
<redacted>
host:
<redacted>
origin:
<redacted>
referer:
<redacted>
requestverificationtoken:
<redacted>
sec-fetch-dest:
empty
sec-fetch-mode:
cors
sec-fetch-site:
same-origin
user-agent:
Mozilla/5.0 (Linux; Android 12; IN2013 Build/RKQ1.211119.001; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/102.0.5005.125 Mobile Safari/537.36 Instagram <IP_ADDRESS>.111 Android (31/12; 408dpi; 1080x2181; OnePlus; IN2013; OnePlus8; qcom; en_SE; 380288917)
x-requested-with:
com.instagram.android

What area is it related to
Device detection, BankID App Launching
Expected behavior
The bankid:/// url should be returned as it is on the demo site since that will work. But how and why when device detection identifies it as Android and Chrome :S
NuGet package version
5.0
Runtime version
.net 6
Smartphone (please complete the following information):

Device: iPhone, iPad, OnePlus 8

Workaround(s)

I implemented a custom launcher that checked the x-requested-with header. If it exists, I return the  bankid:/// scheme. Did not fix things for iOS.
Use the UA parser that is non default. Currently under testing. If this works, perhaps the default device detections can/should be replaced?

Related issues
#360
#339
https://stackoverflow.com/questions/60878744/how-to-open-an-android-app-link-from-a-webview

This was converted from a discussion, here is a summary:

On Android, the instagram webview is parsed as a Chrome web view, even when using firefox.
On Ios, the webview user agent is not recognised by the UAParserDeviceDetector.

Both these issues result the the "app link" received by /Initialize is incorrect. Ios always wants a "app.bankid.com" link and firefox on android needs a "bankid:///" link.

I found the most non-destructive way for us to solve this was to:

Use the UAParserDeviceDetector services.AddTransient<IBankIdSupportedDeviceDetector, UAParserDeviceDetector>();
A customIBankIdLauncher where the CanUseAppLink also responds true for unknown iOS browsers.

...
        private static bool CanUseAppLink(BankIdSupportedDevice device)
        {
            // Only Safari on IOS and Chrome or Edge on Android version >= 6 seems to support
            // the https://app.bankid.com/ launch url.
            //
            // We choose to default all ios devices with unknown browser to use the app link
            // though, since ios in-app webviews are detected as unknown but use safari rendering.

            return IsSafariOnIos(device)
                   || IsUnknownOnIos(device)
                   || IsChromeOrEdgeOnAndroid6OrGreater(device);
        }

        private static bool IsUnknownOnIos(BankIdSupportedDevice device)
        {
            return device.DeviceOs == BankIdSupportedDeviceOs.Ios
                   && device.DeviceBrowser == BankIdSupportedDeviceBrowser.Unknown;
        }
...

Hi!
Sorry for the late reply. I'm really away from the keyboard now during vacation. I will try to look at this in August.
Two inputs (if that helps your debugging):

https://demo.activelogin.net/ runs on ActiveLogin 6.0.0 (beta 1 at the moment)
https://demo.activelogin.net/ does not override any default implementation. It uses UA parser for UA detection.

If you ned a "debugger" tool, I've built one and released it here:
https://demo.activelogin.net/Debugger/Info
That page can help you understand how the current client is detected,.

Not surprised at all.
I've experienced so many issues with the universal link for BankId (https://app.bankid.com/). They shouldn't recommend us using it when it clearly doesn't work for the cases they say.
Glad you found a workaround

I had a look at this now using our "debugger".

On Android, the instagram webview is parsed as a Chrome web view, even when using firefox as main browser. Instagram is not able to open the App Link through the web view.
Mozilla/5.0 (Linux; Android 12; IN2013 Build/RKQ1.211119.001; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/102.0.5005.125 Mobile Safari/537.36 Instagram <IP_ADDRESS>.111 Android (31/12; 408dpi; 1080x2181; OnePlus; IN2013; OnePlus8; qcom; en_SE; 380288917)

https://demo.activelogin.net/Debugger/Info?UserAgent=Mozilla%2F5.0+(Linux%3B+Android+12%3B+IN2013+Build%2FRKQ1.211119.001%3B+wv)+AppleWebKit%2F537.36+(KHTML%2C+like+Gecko)+Version%2F4.0+Chrome%2F102.0.5005.125+Mobile+Safari%2F537.36+Instagram+<IP_ADDRESS>.111+Android+(31%2F12%3B+408dpi%3B+1080x2181%3B+OnePlus%3B+IN2013%3B+OnePlus8%3B+qcom%3B+en_SE%3B+380288917)&RedirectUrl=https%3A%2F%2Fdemo.activelogin.net%2FDebugger%2FInfo&AutoStartToken=afc686c2-7f36-40df-a973-3339e443c173&RelyingPartyReference=

On Ios, the webview user agent is not recognised by the UAParserDeviceDetector.
Mozilla/5.0 (iPad; CPU OS 15_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148 Instagram <IP_ADDRESS>.115 (iPad14,1; iPadOS 15_1; sv_SE; sv-SE; scale=2.00; 750x1334; 349031919)

https://demo.activelogin.net/Debugger/Info?UserAgent=Mozilla%2F5.0+(iPad%3B+CPU+OS+15_1+like+Mac+OS+X)+AppleWebKit%2F605.1.15+(KHTML%2C+like+Gecko)+Mobile%2F15E148+Instagram+<IP_ADDRESS>.115+(iPad14%2C1%3B+iPadOS+15_1%3B+sv_SE%3B+sv-SE%3B+scale%3D2.00%3B+750x1334%3B+349031919)&RedirectUrl=https%3A%2F%2Fdemo.activelogin.net%2FDebugger%2FInfo&AutoStartToken=afc686c2-7f36-40df-a973-3339e443c173&RelyingPartyReference=
From what I can tell it detects Android and iOS correct and an "Unknown" browser. The "Launch Url" is therefore set to:
Android: bankid:///?autostarttoken=afc686c2-7f36-40df-a973-3339e443c173&redirect=null
iOS: bankid:///?autostarttoken=afc686c2-7f36-40df-a973-3339e443c173&redirect=
Is this not what you experience @span?

Hi! We have the same problem as mentioned above. iOS app opens upp BankID, the user authenticates but then Safari is opened.
I have tried your debugger app through the webview in the app and launch url is "app.bankid.com".
Should this use case expect "bankid://" instead?
It doesn't state that the browser is unknown either.

I think this could n ow be solved by #339 / #414. Closing this issue.


Visual Representation for Enable All Extensions

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: (doesn't matter for this)
OS Version: (doesn't matter for this)

Version: 1.74.2 (Universal)
Commit: e8a3071ea4344d9d48ef8a4df2c097372b0c5161
Date: 2022-12-20T10:26:09.430Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.2.0
Sandboxed: Yes

Steps to Reproduce:

Open the Extensions Tab
Click on three dots of View More:

Technically this does enable "all" the installed extensions:
https://github.com/microsoft/vscode/blob/68efb6fe56bd1476e3642ba5752930ce021f5fad/src/vs/workbench/contrib/extensions/browser/extensions.contribution.ts#L697-L699
We could make this consistent & clear with the second option for disable.
Desired Change: Enable All Extensions -> Enable All Installed Extensions

This also enables any disabled built in extensions. Hence it is called like so


[error] public modifier for extensions with protocol conformances

Hi,
When I follow the installations steps and copy
'public extension RealmAdaptor : Adaptor { }'
to my project source, I get the error "Public modifier cannot be used with extensions that declare protocol conformances".
Am I doing something wrong?
Thanks.

Hey @oparinov thank you for pointing this out. It seems that I have documented this incorrectly, I'll update the documentation shortly.
For an example of how things should be implemented look in the tests here
Adaptor already has public as its access level, so any extension that inherits it will also have public access. Such as explained in the documentation.

Adding Protocol Conformance with an Extension
You cannot provide an explicit access level modifier for an extension if you are using that extension to add protocol conformance. Instead, the protocol’s own access level is used to provide the default access level for each protocol requirement implementation within the extension.

Just remove public and everything should be A'OK. Let me know if you have any more questions!

And please confirm if it worked so we may close the issue :)

Hi @rexmas  thanks for the help!
Now I'm having troubles trying to set up mapping.
When I try to map a property using external mapping like this:
'tomap.chapter                    <- .Mapping("chapter", chapterMapping) >*<'
I'm getting this error:
"Type of expression is ambiguous without more context"
Here is the code:
'import Foundation
import RealmSwift
import Crust
import RealmCrust
class Fact: Object {
dynamic var uuid: Int = 0
dynamic var textInDanish = ""
dynamic var textInEnglish = ""
dynamic var chapter: Chapter?
}
extension Fact: Mappable { }
class FactMapping : RealmMapping {
var adaptor: RealmAdaptor
var primaryKeys: Array<CRMappingKey> {
    return [ "uuid" ]
}

required init(adaptor: RealmAdaptor) {
    self.adaptor = adaptor
}

func mapping(inout tomap: Fact, context: MappingContext) {
    let chapterMapping = ChapterMapping(adaptor: self.adaptor)

    tomap.chapter                    <- .Mapping("chapter", chapterMapping) >*<
    tomap.uuid                       <- "uuid" >*<
    tomap.textInDanish               <- "textInDanish" >*<
    tomap.textInEnglish              <- "textInEnglish" >*<
    context
}

}
'

If this is an error thrown by the IDE before building, just try building and it may sort itself out (this is an issue with the compiler I've seen happen before).
Occasionally, if you have another symbol in your Module/App that has the same name of a symbol from another module you're trying to use, you'll need to provide more context to the compiler to know which of the two types you're referring to.
.Mapping is a member of KeyExtensions. So give KeyExtensions.Mapping a try and build again, this should provide enough context to the compiler to infer the correct type.

Did this solve your problem?

No response in over a week, closing.


Drop support for Python 2.7

It's possible we already have a ticket for this, but #1457 revived the idea. Here are my thoughts:
I'm interested in dropping support for new releases on Python 2.7. I can imagine maintaining support for Python 2.7 in a bugfix-only branch. My main worry would be breaking the expectation that the latest version of setuptools is generally viable in all supported versions. But there are features now that would mitigate that issue -- the python_version declaration and PEP 518 support in pip, I'm thinking systems admins and app developers would still be able to install the "latest" version of setuptools, even in Python 2.7, but they would only get the maintenance versions. Presumably the same thing happened for Python 2.6. I'd really like to drop support for Python 2.7 earlier than later if possible.

Hello @jaraco! Apologies if this is documented somewhere else. Are there any additional plans for dropping Python 2.7 support?

In the brief discussions I've had with others, I get the sense there are too many environments that would break if setuptools were to drop Python 2 support. In many ways, setuptools is at the base of the dependency tree so will have to be the last package to drop support.

Pip is in a similar boat, see https://github.com/pypa/pip/issues/6148 and for packaging in general see https://discuss.python.org/t/packaging-and-python-2/662.

I'd like to revive consideration for this issue, not because it's Jan 2020 as much as that I spent several hours yesterday addressing Python 2 support in this codebase.
Let's say we were to summarily drop support for Python 2.7 today - what impact would that have? Projects using pip 9 or later to install setuptools would not be affected (they'd continue to get compatible, if frozen, versions). Only projects using easy_install or some other mechanism (e.g. from GitHub master) for installation might be affected.
That seems perfectly reasonable to me.

@jaraco I tend to agree in some ways, but I think @dstufft's comment from the discourse thread is on point (as usual):

My general opinion is that the packaging toolchain needs to be conservative in dropping support for packaging and installing packages on Python 2 and use a usage based methodology for deciding when to drop support for that.
The main underlying reason is that I think it will hamstring our ability to continue to improve Python’s packaging. Obviously someone has to upgrade the versions of the relevant tools in order to get support for new features. However if a project is supporting 2.7 for one reason or another then they are going to be stuck using only the features that existed in the 2019 era toolchain unless we go to great lengths to make sure that all new standards degrade gracefully.

As much as I would love to say that we should drop it today, the natural consequence of us dropping Python 2 support is that projects still supporting Python 2 won't be able to use new features we support. What that means is that all the projects right now who aren't adding pyproject.toml support because it's missing some critical feature (e.g. editable install support) won't be able to adopt it without also dropping Python 2.
I see pyproject.toml and adoption of other modern packaging features as higher priority than dropping Python 2 compatibility at the moment. I say that we wait until a significant fraction of packages have dropped Python 2 entirely or until we are confident that pyproject.toml builds are sufficiently "feature complete" that we won't expect a feature freeze on the Python 2 branch to hinder adoption rates.

One other thing to note: when we do go for the Python 2 drop, we should probably advertise it with enough advance notice that it can be a meaningful driver of people's behavior. If we make big enough fanfare about it and give people 6 or 9 months' notice, we may be able to induce marginal holdouts to drop Python 2 entirely.
If we do it suddenly without prior announcement, I think people will scramble to get workarounds in place and then find that the workarounds are "good enough".

Hello we are using Python 2.7 and seeing a scary message every time we invoke supervisorctl which is 100s of times in our deploy process.   We are working feverishly to move our java application off Supervisor to containers, but in the meantime we need to understand the risk here - will our deploys stop working? We have the following versions of packages:
#!/usr/bin/python
# EASY-INSTALL-ENTRY-SCRIPT: 'setuptools==20.6.4','console_scripts','easy_install'
__requires__ = 'setuptools==20.6.4'
import sys
from pkg_resources import load_entry_point

if __name__ == '__main__':
    sys.exit(
        load_entry_point('setuptools==20.6.4', 'console_scripts', 'easy_install')()
    )

$ pip -V
pip 1.5.6 from /usr/local/lib/python2.7/dist-packages (python 2.7)

Warning message:
/usr/local/lib/python2.7/dist-packages/pkg_resources/py2_warn.py:19: UserWarning: ************************************************************
You are running Setuptools on Python 2, which is no longer
supported and
>>> SETUPTOOLS WILL STOP WORKING <<<
in a subsequent release. Please ensure you are installing
Setuptools using pip 9.x or later or pin to `setuptools<45`
in your environment.
If you have done those things and are still encountering
this message, please comment in
https://github.com/pypa/setuptools/issues/1458
about the steps that led to this unsupported combination.
************************************************************
  sys.version_info < (3,) and warnings.warn("*" * 60 + msg + "*" * 60)

scary message ... 100s of times in our deploy process

O_O

will our deploys stop working?

The short answer is yes, but it's possibly more complicated.
I see you have pip == 1.5.6, which was released on May 2014, suggesting you have a very old Python environment (stack) installing a much newer Setuptools. I would suggest a few options to investigate and prevent the breakage.

Search your stack for where setuptools is being installed/upgraded and change it to only install setuptools<45.
In your stack, upgrade pip to 9.x or later and only ever install Setuptools with that version of pip (you'll still need to downgrade setuptools for existing environments).
Push ahead with your migration to containers before Setuptools starts breaking on Python 2.7.

I'm not sure when Setuptools will start breaking on Python 2.7, but it will be at least a few months, and no sooner than Apr 20. If you are electing to just ignore the warning, you can suppress it with an environment variable PYTHONWARNINGS=ignore:::pkg_resources.py2_warn (perhaps there should be a better way to reference this warning).
Does that help?

This is helpful, thank you!

Hello , we are using python 2.7 , pip version  20.0.2 and setuptool version is 45.1.0 but getting the below warning message .
/usr/lib/python2.7/site-packages/pkg_resources/py2_warn.py:22: UserWarning: Setuptools will stop working on Python 2

You are running Setuptools on Python 2, which is no longer
supported and

SETUPTOOLS WILL STOP WORKING <<<
in a subsequent release (no sooner than 2020-04-20).
Please ensure you are installing
Setuptools using pip 9.x or later or pin to setuptools<45
in your environment.
If you have done those things and are still encountering
this message, please comment in
https://github.com/pypa/setuptools/issues/1458
about the steps that led to this unsupported combination.

pip -V
pip 20.0.2 from /usr/lib/python2.7/site-packages/pip (python 2.7)
As you can see the pip version is greater than 9.x but still i am getting the warning.
do we need to downgrade SETUPTOOL < 45.

@soumya-devops Maybe.
Here's the order of preference for how you should approach the issue:

Upgrade your application to run on Python 3. Although I recognize that this work may be impractical in the short term, it's the only long-term solution.
Make sure you're installing Setuptools with a late version of pip. It's not enough to have pip 9.x; you must also use that version of pip to install setuptools. If pip 9.x or later is installing setuptools 45, that's unexpected.
When building your environment, ensure that setuptools < 45 is installed in advance, so it's satisfied when it's installed by something else.
After building your environment, uninstall and reinstall setuptools to ensure a suitable version is installed.

If this advice doesn't solve your issue, please file a new bug describing what you've tried and how you end up with an unexpected (incompatible) version of setuptools. Please try to include any details will allow someone else to replicate the issue, such as the commands you ran and the output they gave.

I know nothing about python, but I have to use it like a chimpanzee right now.
How do I suppress this from within the script I'm using?
I really don't want to set up an evironment variable for this horsedookie.
Thanks.

How do I suppress this from within the script I'm using?

Essentially, ensure you're using setuptools<45. You can do this by only installing setuptools with a late version of pip (>9.x) or otherwise specifying pip install 'setuptools<45'.

Solution for now [is to suppress warning]

I wouldn't recommend suppressing warnings, as eventually setuptools will drop code compatibility for Python 2.7 and the error will become a crash.
If this isn't enough to help, please open a new issue describing the steps you use to create your environment where you're getting the incompatible version of setuptools.

I am using setuptools 45.2.0, at least that's the version of my distros (Slackware) package.

If you're getting python2-setuptools via your distribution package manager channel, you should probably ask the Slackware developers to roll back their build recipe. That is what we (Arch Linux) did for our distribution setuptools package. We have pinned it to 44.0.0

I am using pip==20.0.2 setuptools==45.2.0 and still got the following message:
app_1  | ************************************************************
app_1  | You are running Setuptools on Python 2, which is no longer
app_1  | supported and
app_1  | >>> SETUPTOOLS WILL STOP WORKING <<<
app_1  | in a subsequent release (no sooner than 2020-04-20).
app_1  | Please ensure you are installing
app_1  | Setuptools using pip 9.x or later or pin to setuptools<45
app_1  | in your environment.
app_1  | If you have done those things and are still encountering
app_1  | this message, please comment in
app_1  | https://github.com/pypa/setuptools/issues/1458
app_1  | about the steps that led to this unsupported combination.

Hallo, I was trying to run a shadow hand simulation. I am running Ubuntu 16.04, ROS Kinetic, pip 20.0.2 and setuptools-45.2.0and get the following error:
`************************************************************
You are running Setuptools on Python 2, which is no longer
supported and

SETUPTOOLS WILL STOP WORKING <<<
in a subsequent release (no sooner than 2020-04-20).
Please ensure you are installing
Setuptools using pip 9.x or later or pin to setuptools<45
in your environment.
If you have done those things and are still encountering
this message, please comment in
https://github.com/pypa/setuptools/issues/1458
about the steps that led to this unsupported combination.
************************************************************`

Hi @MarenRobers . Sorry to hear you're having trouble. In order to solicit better details about these issues, I've created https://bit.ly/setuptools-py2-warning and future versions of setuptools will direct users there to file a report about their Python 2 compatibility issues. Please follow that link (or simply complete the relevant template) to create a separate issue relating to your environment. I'm going to lock this thread so that others encounter this message.


Cynerio Remove V2 package

Required items, please complete
Change(s):

Removed v2 packge

Reason for Change(s):

Error when publishing v3 package: the package uploaded has older packages(2.0.0) in it

Version Updated:

No

Hi @v-rbajaj , the arm-ttk validations test fail even though I didn't change anything in the package content, just removed the old one(v2) and repackaged, can you please help?


App crashing on firestick 4K

Thanks for all your hard work!
After selecting an anime, while initializing, the app closes.

There is a fix at nightly on discord for it.

no follow up


Expose the WalletRead::validate_seed method via the FFI

See https://github.com/zcash/librustzcash/issues/1189

Completed in 70cce1272c26ed52fbe7bfa334be781373b64bfd


feat: extend pyxi's test to include SBOM validation

Description
This PR to add another validation to release e2e-test-pyxis to ensure the push sbom to Pyxis is working
as required, adding another component so the application contains two components now, this we can validate that release pipeline can handle multiple images
https://issues.redhat.com/browse/HACBS-1555
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/retest

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/test all

/test all

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

Ran test locally and it pass :

Ran 7 of 28 Specs in 1020.470 seconds
SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 21 Skipped

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/lgtm

/test redhat-appstudio-e2e

OK, so this was merged automatically 4 hours ago, but unfortunately Danny's comments were not addressed yet. I think it would be great if those suggestions could be addressed later. @kasemAlem maybe create a follow up story for these improvements? WDYT? That way this story and the parent sbom epic can still be closed now.

@mmalina Yeah, that works!


Is there a way to make diff-cover ignore whitespaces?

Hello.
We're using diff-cover in our CI pipeline for python and C#. And with C# it's perfectly safe to have code spaces/tabs reformatted. So if there is a diff that has lines with only whitespace changes which are not covered by tests, diff-cover shows those lines as not covered, which is correct for space-dependent languages like Python, but for C# it is not.
Git diff has several options to ignore whitespaces during comparison. Is there a way to make diff-cover ignore whitespace changes too? Or at least pass additional arguments to git diff command used to build diff (assuming it's git diff that has been used under the hood)?

In theory integrating these commands into diff cover would be fairly easy. Add an option, if option is present pass the required arguments to git.
However, I do wonder if it would make sense. Diff-cover works off of the coverage report passed into it. Is your coverage report marking these lines as not covered? Is there an option that should be passed to the coverage tool to ignore these lines?

I see your point. Well, strictly speaking you're right - everything should be covered. But in large code base spread over many microservices it's quite common to have parts that are not covered. We have DI pipeline that reacts to low diff coverage and stops the build. And it's a problem when someone formats legacy C# code that does not have unit tests coverage - strictly speaking the code hadn't been changed, so the diff should be empty. So it's more of the diff problem, not the diff-cover tool.

That being said. It should not be a hard feature to add. Ill look into it over the weekend.

Thank you. Would be great, if you have time.

Thanks! We will check.
Yeah, we're running python 3.

Sorry for delay. We've tested your changes and it seems they're working fine. They not rule out all possible formatting changes but it's a limitation of git I think.
We'll look into getting new package version from pip.
Thank you!

@MichaelLogutov https://pypi.org/project/diff-cover/4.0.0/ released


Eliah Kagan: Watch gyrojob.com

Eliah Kagan requests the watch of the watch_keyword gyrojob\.com. See the MS search here and the Stack Exchange search here.

gyrojob\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


Add Afshari and Stewart (2016) GMPE for significant duration

Migrate the Afshari and Stewart (2016) GMPE for significant duration from the Broadband Platform. Remove BBP dependencies and include unit tests to make sure code runs as expected.

This feature has been implemented and tested.


SplitLayout: Allow undefined secondary split

Working on an issue with query-less panels in core I've noticed  that SplitLayout does not allow empty secondary pane. I think it's a nice addition given that those split panes now become more dynamic and controllable.

📦 Published PR as canary version: 2.6.0--canary.568.7785237668.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

@dprokop dupe of https://github.com/grafana/scenes/pull/546 ?

@torkelo  - yes, didn't notice the other one.


Left utility buttons visible on first load

As described in this issue
https://github.com/CEWendel/SWTableViewCell/issues/353, on the first
load of the view, cells show the left utility buttons. This solve the
problem.

Pretty sure there were already pull requests opened for this issue. To me it just seems that this repo is no longer maintained, which really is a shame... Hope to be proven wrong... @CEWendel ?

I got the same problem on iPhone X only . (This problem only happens on iPhone X.)
@valeIT  Above fix does not fix this problem :)


Rename macOS/tvOS tests to satisfy Swift Package Manager

When I try to swift package generate-xcodeproj or swift build, following error shows up:

btw, I'm not sure how this is going to effect CocoaPods and Carthage

Should be fixed in 3.2.4


Better playlist support for The Daily Show

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2<IP_ADDRESS>. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[ x] I've verified and I assure that I'm running youtube-dl 2<IP_ADDRESS>

Before submitting an issue make sure you have:

[x ] At least skimmed through the README, most notably the FAQ and BUGS sections
[ x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ x] Site support request (request for adding support for a new site)
[ x] Feature request (request for a new functionality)
[ ] Question
[ ] Other

I'd like to get (better) playlist support for The Daily Show.
If I toss 'http://www.cc.com/shows/the-daily-show-with-trevor-noah' at youtube-dl, it fails.
If I toss the individual show URLs, it successfully finds all (usually 4) parts and downloads all of them.
Looking at the web page, it seems that there is only 1 or two episodes on the page itself, and the rest are fetched via javascript.
If I toss ":tds" (which I only found by looking at other reports from people with issues), then it fetches some, but not all, of the videos.
===
Separate Q: Where can I see a list of all the playlist shortcuts like :tds? (Real Time, Charlie Rose, PBS News Hour?)

And hoping youtube-dl can combine different clips into one whole episode automatically as well

So :tds only returns one episode (4 parts)?
keybounceMBP:Daily michael$ youtube-dl -v --get-filename :tds
[debug] System config: []
[debug] User config: ['-k', '--hls-prefer-native', '-o', '%(series)s/s%(season_number)02d-e%(episode_number)02d-%(title)s.%(ext)s', '-f', '\nbest[ext=mp4][height>431][height<=576]/\nbestvideo[ext=mp4][height=480]+bestaudio[ext=m4a]/\nbest[ext=mp4][height>340][height<=431]/\nbestvideo[ext=mp4][height>360][height<=576]+bestaudio/\nbest[height>340][height<=576]/\nbestvideo[height>360][height<=576]+bestaudio/\nbestvideo[height=360]+bestaudio/\nbest[ext=mp4][height>=280][height<=360]/\nbest[height<=576]/\nworst', '--ap-mso', 'Dish', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', '--write-sub', '--write-auto-sub', '--sub-lang', 'en,enUS,en-us', '--sub-format', 'ass/srt/best', '--convert-subs', 'ass', '--embed-subs', '--mark-watched', '--download-archive', 'downloaded-videos.txt']
[debug] Custom config: []
[debug] Command-line args: ['-v', '--get-filename', ':tds']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 3.6.2 - Darwin-13.4.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.3.3, ffprobe 3.3.3, rtmpdump 2.4
[debug] Proxy map: {}
WARNING: enUS subtitles not available for 895f5f12-3526-413e-9849-a6ff8f5882bc
WARNING: en-us subtitles not available for 895f5f12-3526-413e-9849-a6ff8f5882bc
WARNING: enUS subtitles not available for 1b0b7476-5ad1-4682-bd18-27256c85a8be
WARNING: en-us subtitles not available for 1b0b7476-5ad1-4682-bd18-27256c85a8be
WARNING: enUS subtitles not available for d5404225-1de5-4149-a0bd-f2281bc97f7e
WARNING: en-us subtitles not available for d5404225-1de5-4149-a0bd-f2281bc97f7e
WARNING: enUS subtitles not available for 0c55be7c-a413-417a-b062-99447fa8bb02
WARNING: en-us subtitles not available for 0c55be7c-a413-417a-b062-99447fa8bb02
keybounceMBP:Daily michael$

Episode was already downloaded, but apparently I need to do this automatically, daily, while everything else I can do weekly.


Unable to pass in host?

I'm getting a weird EADDRNOTAVAIL error when I try to run provider tests in my circle CI.
I asked the pact js slack channel, and they advised:
We spin up a local proxy server as part of the test infra. It looks like it's resolving that as an ipv6 address. Try changing localhost in your setup to something like <IP_ADDRESS> (edited)

The only option I see related to that is the providerBaseUrl option, which it looks like is excluded as part of nest's interface on top of pact js.
Am I misreading this?  Is there any way to configure the proxy address in nestjs-pact?

I'm really bust these days, but I'm planning to make an effort this week and try to close all the bugs (I've noticed you have opened another one).
So I will get back to you as soon as possible. BTW, will be nice if we can chat on slack and try to reproduce this one together.

@voinik @bewatts can you try this version<EMAIL_ADDRESS>

@omermorad Awesome, it works! 😁

Yay!

@voinik 2.2.1 (stable release)
Skipped on patch version in mistake

@omermorad Amazing stuff, thanks for the quick responses!


Link to OpenPhacts

This adds the OpenPhacts developers to readme.
Added .gitignore to keep autogenerated stuff out.
Added a pom to construct.

fixed the gitignore and unchaced the src-axis files.


fix some typo

Some typos  confuse the readability of the source code, so I fixed them.

Thanks! Can you please break this up into two PRs though? One for incubator/hnc/..., the other for tenancy/...? They're in the same repo but we're trying to keep their history more-or-less separate for now. Thanks!

awesome, let's me do it .thanks for your review!

@adrianludwin could you please review this PR again , thanks a lot!!

/ok-to-test
@jjmengze, can you please squash your three commits into one and then force-push it to the branch so that there's only one commit in this PR? Once that's done I'll approve. Thanks for making this change!

/retest

@jjmengze if you click the "details" link and check out the end of the build log, you'll see that there's a legit compilation error. Did you run make before submitting?
# github.com/kubernetes-sigs/multi-tenancy/incubator/hnc/pkg/validators
pkg/validators/hierarchy.go:274:13: ns.AncestoryNames undefined (type *forest.Namespace has no field or method AncestoryNames)
# github.com/kubernetes-sigs/multi-tenancy/incubator/hnc/pkg/controllers
pkg/controllers/hierarchy_controller.go:279:17: ns.AncestoryNames undefined (type *forest.Namespace has no field or method AncestoryNames)
# github.com/kubernetes-sigs/multi-tenancy/incubator/hnc/pkg/forest
vet: pkg/forest/forest_test.go:66:40: child.AncestoryNames undefined (type *Namespace has no field or method AncestoryNames)
# github.com/kubernetes-sigs/multi-tenancy/incubator/hnc/pkg/validators
vet: pkg/validators/hierarchy.go:274:14: ns.AncestoryNames undefined (type *forest.Namespace has no field or method AncestoryNames)

I am very sorry, I did not notice that other errors have occurred.
I fixed some of the dependency errors but there are other errors in the make process.
Can you please provide me with some comments so that I can continue to fix it thanks!
go get<EMAIL_ADDRESS>go: finding sigs.k8s.io v0.2.1
go: finding sigs.k8s.io/controller-tools/cmd/controller-gen v0.2.1
go: finding sigs.k8s.io/controller-tools/cmd v0.2.1
go: downloading golang.org/x/sys v0.0.0-20190922100055-0a153f010e69
go: extracting golang.org/x/sys v0.0.0-20190922100055-0a153f010e69
# sigs.k8s.io/controller-tools/pkg/webhook
../../../../pkg/mod/sigs.k8s.io/controller-tools@v0.2.1/pkg/webhook/parser.go:98:29: undefined: v1beta1.Webhook
../../../../pkg/mod/sigs.k8s.io/controller-tools@v0.2.1/pkg/webhook/parser.go:129:9: undefined: v1beta1.Webhook
../../../../pkg/mod/sigs.k8s.io/controller-tools@v0.2.1/pkg/webhook/parser.go:161:21: undefined: v1beta1.Webhook
../../../../pkg/mod/sigs.k8s.io/controller-tools@v0.2.1/pkg/webhook/parser.go:162:23: undefined: v1beta1.Webhook
make: *** [controller-gen] Error 2

/assign @adrianludwin
/assign @rjbez17
(me as backup).

/retest

/lgtm
/approve
Thanks for this fix!


Added Comasts University Islamabad Abbottabad Campus Domain Entry

Homepage -->  Link
Course Offered --> Link

@3ilal First stage of verification passed, official domain is cuiatd.edu.pk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.


Error:  failure(FaceLiveness.FaceLivenessDetectionError(code: 0, message: "An unknown error occurred.", recoverySuggestion: "Please open an issue...."))

Describe the bug
Hi Team,
We are using the Amplify SDK (AmplifyUiLiveness) version 1.2.16 and Amplify version 2.35.4. However we have encountered an issue where once the camera is initialized it does show the correct message - Move face in front of camera (when no face is in camera). As soon as I start scanning my face an error is returned as following.
failure(FaceLiveness.FaceLivenessDetectionError(code: 0, message: "An unknown error occurred.", recoverySuggestion: "Please open an issue...."))
I have attached the code sample as a screenshot.
Note: We are using custom credentials. We have tried to create a React sample project using the SDK and it seems to run perfectly fine with the same API endpoints used in our iOS App.
We believe that there might be an issue with the SDK. I have also tried to use an older version (1.2.9) but the issue still persists
Swift

React

Steps To Reproduce
Steps to reproduce the behavior:
1. Create new swift UI CustomView
2. Add FaceLivenessDetectorView in body
3. Add session Id
4. Add credential provider, including accessKey, secretAccessKey, expiration and sessionToken
5. Build app
6. Scan Face

Expected behavior
The camera feed should show all steps to scan face. Instead it is failing as soon as face is position within the camera frame.
Swift Liveness Version
1.2.16
Xcode version
15.4
Relevant log output
failure(FaceLiveness.FaceLivenessDetectionError(code: 0, message: "An unknown error occurred.", recoverySuggestion: "Please open an issue...."))

Is this a regression?
Yes
Regression additional context
No response
OS Version
iOS 17.5.1
Device
iPhone 14 Plus
Specific to simulators
No response
Additional context
No response

@harsh62 This is the only extra log printed with logLevel in verbose:
doUnloadModel:options:qos:error:: model=_ANEModel: { modelURL=file:///var/containers/Bundle/Application/22D35D3E-C5B9-410F-90B2-CF5343A50424/dua.app/AmplifyUILiveness_FaceLiveness.bundle/face_detection_short_range.mlmodelc/ : sourceURL= (null) : key={"isegment":1,"inputs":{"input.44_ctx_tx_default__0":{"shape":[8,8,1,96,1]},"input.40_ctx_tx_default__0":{"shape":[16,16,1,88,1]}},"outputs":{"1477":{"shape":[16,896,1,1,1]},"1011":{"shape":[1,896,1,1,1]}}} : identifierSource=0 : cacheURLIdentifier=E04A8B21D3B627656102DCC848F99119A0293BC2749FE59BF32E5F055A75690E_67072AFF8E9C1CF25FB32FD4D148D1CFD9A9EAE4E5B2DB2DD62BC5D9DEC8528B : string_id=0x00000000 : program=_ANEProgramForEvaluation: { programHandle=14709728524660 : intermediateBufferHandle=0 : queueDepth=127 } : state=3 : programHandle=14709728524660 : intermediateBufferHandle=0 : queueDepth=127 : attr={     ANEFModelDescription =     {         ANEFModelInput16KAlignmentArray =         (         );         ANEFModelOutput16KAlignmentArray =         (         );         ANEFModelProcedures =         (                         {                 ANEFModelInputSymbolIndexArray =                 (                     0,                     1                 );                 ANEFModelOutputSymbolIndexArray =                 (                     0,                     1                 );                 ANEFModelProcedureID = 0;             }         );         kANEFModelInputSymbolsArrayKey =         (             "input.40_ctx_tx_default__0",             "input.44_ctx_tx_default__0"         );         kANEFModelOutputSymbolsArrayKey =         (             "1011@output",             "1477@output"         );         kANEFModelProcedureNameToIDMapKey =         {             "net_1" = 0;         };     };     NetworkStatusList =     (                 {             LiveInputList =             (                                 {                     BatchStride = 90112;                     Batches = 1;                     Channels = 88;                     Depth = 1;                     DepthStride = 90112;                     Height = 16;                     Interleave = 1;                     Name = "input.40_ctx_tx_default__0";                     PlaneCount = 88;                     PlaneStride = 1024;                     RowStride = 64;                     Symbol = "input.40_ctx_tx_default__0";                     Type = Float16;                     Width = 16;                 },                                 {                     BatchStride = 49152;                     Batches = 1;                     Channels = 96;                     Depth = 1;                     DepthStride = 49152;                     Height = 8;                     Interleave = 1;                     Name = "input.44_ctx_tx_default__0";                     PlaneCount = 96;                     PlaneStride = 512;                     RowStride = 64;                     Symbol = "input.44_ctx_tx_default__0";                     Type = Float16;                     Width = 8;                 }             );             LiveOutputList =             (                                 {                     BatchStride = 57344;                     Batches = 1;                     Channels = 1;                     Depth = 1;                     DepthStride = 57344;                     Height = 896;                     Interleave = 1;                     Name = "1011@output";                     PlaneCount = 1;                     PlaneStride = 57344;                     RowStride = 64;                     Symbol = "1011@output";                     Type = Float16;                     Width = 1;                 },                                 {                     BatchStride = 57344;                     Batches = 1;                     Channels = 1;                     Depth = 1;                     DepthStride = 57344;                     Height = 896;                     Interleave = 1;                     Name = "1477@output";                     PlaneCount = 1;                     PlaneStride = 57344;                     RowStride = 64;                     Symbol = "1477@output";                     Type = Float16;                     Width = 16;                 }             );             Name = "net_1";         }     ); } : perfStatsMask=0}  was not loaded by the client. doUnloadModel:options:qos:error:: model=_ANEModel: { modelURL=file:///var/containers/Bundle/Application/22D35D3E-C5B9-410F-90B2-CF5343A50424/dua.app/AmplifyUILiveness_FaceLiveness.bundle/face_detection_short_range.mlmodelc/ : sourceURL= (null) : key={"isegment":0,"inputs":{"image":{"shape":[128,128,1,3,1]}},"outputs":{"input.6":{"shape":[64,64,1,24,1]}}} : identifierSource=0 : cacheURLIdentifier=E04A8B21D3B627656102DCC848F99119A0293BC2749FE59BF32E5F055A75690E_8A291746C8801B05A789F3BB8952C06985CE3DDF0823BA3740A385A08019BFC9 : string_id=0x00000000 : program=_ANEProgramForEvaluation: { programHandle=14709722325900 : intermediateBufferHandle=0 : queueDepth=127 } : state=3 : programHandle=14709722325900 : intermediateBufferHandle=0 : queueDepth=127 : attr={     ANEFModelDescription =     {         ANEFModelInput16KAlignmentArray =         (         );         ANEFModelOutput16KAlignmentArray =         (         );         ANEFModelProcedures =         (                         {                 ANEFModelInputSymbolIndexArray =                 (                     0                 );                 ANEFModelOutputSymbolIndexArray =                 (                     0                 );                 ANEFModelProcedureID = 0;             }         );         kANEFModelInputSymbolsArrayKey =         (             image         );         kANEFModelOutputSymbolsArrayKey =         (             "input.6@output"         );         kANEFModelProcedureNameToIDMapKey =         {             net = 0;         };     };     NetworkStatusList =     (                 {             LiveInputList =             (                                 {                     BatchStride = 98304;                     Batches = 1;                     Channels = 3;                     Depth = 1;                     DepthStride = 98304;                     Height = 128;                     Interleave = 1;                     Name = image;                     PlaneCount = 3;                     PlaneStride = 32768;                     RowStride = 256;                     Symbol = image;                     Type = Float16;                     Width = 128;                 }             );             LiveOutputList =             (                                 {                     BatchStride = 196608;                     Batches = 1;                     Channels = 24;                     Depth = 1;                     DepthStride = 196608;                     Height = 64;                     Interleave = 1;                     Name = "input.6@output";                     PlaneCount = 24;                     PlaneStride = 8192;                     RowStride = 128;                     Symbol = "input.6@output";                     Type = Float16;                     Width = 64;                 }             );             Name = net;         }     ); } : perfStatsMask=0}  was not loaded by the client.

@harsh62
I have created a quick video so you can see the full projects (both in React and Swift) -> https://youtu.be/oB2nq-EMXdo
Here is the sessionId, region and time sent:
{     "sessionId": "6be0fe48-adb3-4dde-b302-77376889e7c4" } {     "accessKeyId": "ASIA2P2BL6253QKZLQ56",     "secretAccessKey": "soZxVGZ3H2grDkLb8QVB/B6OtwTaiWRfMSZzH6ww",     "sessionToken": "IQoJb3JpZ2luX2VjEKn//////////wEaCWV1LXdlc3QtMSJHMEUCIQC91zHcCLKCYVgtK2NuSMEkR/Dr/wtp89CyHLCHcEi/dgIgIZ947GXDP8R3GIRtTpr6+/ECkJNfl8pPSM/n8XqOTLwq7QIIchACGgw3MjExNTQ3MzM3NTUiDNK1pW8U+ksxIqkJfirKAmGayfJOcnBxqZTksFUD7KCBeZX/7OE4Nu5CdyLFoAUAsEt7KjM2GWzqq3dS/yCXt/MGZMnTNiUe3pPHQuxaYl5ngC8/ELyT1za1myv5f3P+TT8cYtfB73wv/KQi5AZMOVFVxxHr6guA1xBLM4bcMRzSgEPIOcAmK1JcyejX4SfrplnyXaDvUCaKq1XAx17te8EuNL7SLeCELWyWYz7NNTg2MSAdKnsnZjX2vmq20KyZzXFhLW/uiJoHbaCH/E9OJooVMhMM79zNUhqY2ZnzLwnuPzLK7ONUm1HmvHfi3GnYfCoOUI0YejmdvCz7C64SH6z1gFefKy+jHUci6vei052qejQrEPY2lTPAXb7oCIRlpy6YPsZp+WrysRj6cwX/aAoWtNJBiMi/g5vvB2WuRAkIyLPZGUY/77DBQf3jWcaW7OG9KxZ7zldkwDCN1sO0BjqdAeGeUf03qvSPkUJhRvuzTKWrEVKyo6ybjDYJJtPo7tFaPyn8vaCqc0QAbUFjngDaYzztzLpSNgAkFEuigg3CqNXu3a/Gt/iZwWczrGx0EKWCrKFJ95n6pQff4a8YVNNN5MjspKgVHfQEyZnJ4v47DIj73ZqkfQMiEPTQ6pjKzwMA+MwMyOLuzTvKOrTx9cvVwldedklWziqquyYUvrc=",     "expiration": "2024-07-12T08:51:29.000Z" }

@harsh62
Any update on this?

@harsh62
After further investigation we have found that the difference between react and swift is that in react when the websocket is called X-Amz-Security-Token in react, meanwhile this is not sent at all in Swift. We have tested this with Fiddler in our mobile side and here are the results:
This is is iOS

This is in React

Here is the struct I have created for setting my credentials when initializing FaceLivenessDetectorView

I will close this issue as the fix was quiet simple. AWSCredentials protocol does not contain sessionToken, I had to use AWSTemporaryCredentials when creating my Credentials struct and everything seems to work now.

hi @lendk-dua
I would really appreciate if you could help me also.
I am trying to implement this in flutter using method channels. In android side it was pretty simple but in iOS i don't have any clue how to do it.
My particular scenario involves sending the required data from flutter as follows:
static Future<bool> startFaceLiveness(
      {required String sessionId,
      required String region,
      required String accessKeyId,
      required String secretAccessKey,
      required String sessionToken,
      required int expiration}) async {
    try {
      final bool result = await _channel.invokeMethod('startFaceLiveness', {
        'sessionId': sessionId,
        'region': region,
        'accessKeyId': accessKeyId,
        'secretAccessKey': secretAccessKey,
        'sessionToken': sessionToken,
        'expiration': expiration
      });
      return result;
    } on PlatformException catch (e) {
      print('Error invoking startFaceLiveness method: ${e.message}');
      // Handle error as needed, e.g., show a user-friendly error message
      throw e; // Re-throw the exception if needed for further handling
    } catch (e, stackTrace) {
      print('Unexpected error during startFaceLiveness: $e\n$stackTrace');
      // Handle unexpected errors
      throw e; // Re-throw the exception if needed for further handling
    }
  }

And in the AppDelegate.swift file i am handling it like this:
import UIKit
import Flutter
import FirebaseCore
import SwiftUI
import Amplify
import AWSCognitoAuthPlugin
import FaceLiveness
import app_links
import Foundation
import AWSPluginsCore
import Sentry

@main
@objc class AppDelegate: FlutterAppDelegate {

  override func application(
      _ application: UIApplication,
      didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
  ) -> Bool {
      FirebaseApp.configure()
      GeneratedPluginRegistrant.register(with: self)

      // Configure Amplify
      configureAmplify()

      // Set up method channels
      setMethodChannels()

      // Retrieve the link from parameters
          if let url = AppLinks.shared.getLink(launchOptions: launchOptions) {
            // We have a link, propagate it to your Flutter app
            AppLinks.shared.handleLink(url: url)
            return true // Returning true will stop the propagation to other packages
          }

      return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }

  private func configureAmplify() {
      do {
          try Amplify.add(plugin: AWSCognitoAuthPlugin())
          // Add other necessary plugins for your app
          try Amplify.configure()
          print("Amplify configured successfully!")
      } catch {
          print("Error configuring Amplify: \(error)")
      }
  }

  private func setMethodChannels() {
      let controller: FlutterViewController = window?.rootViewController as! FlutterViewController

      // Set up method channel for Face Liveness
      let faceLivenessChannel = FlutterMethodChannel(name: "face_liveness_plugin", binaryMessenger: controller.binaryMessenger)
      faceLivenessChannel.setMethodCallHandler { [weak self] (call: FlutterMethodCall, result: @escaping FlutterResult) in
          guard call.method == "startFaceLiveness" else {
              result(FlutterMethodNotImplemented)
              return
          }

          // Extract parameters from the method call
          guard let arguments = call.arguments as? [String: Any],
                let sessionId = arguments["sessionId"] as? String,
                let region = arguments["region"] as? String,
                let accessKeyId = arguments["accessKeyId"] as? String,
                let secretAccessKey = arguments["secretAccessKey"] as? String,
                let sessionToken = arguments["sessionToken"] as? String,
                let expiration = arguments["expiration"] as? Int else {
              result(FlutterError(code: "INVALID_ARGUMENTS", message: "Invalid or missing arguments", details: nil))
              return
          }

          // Print sessionId and region values
          print("Received sessionId: \(sessionId), region: \(region)")

          // Call Swift screen when starting Face Liveness
          self?.openSwiftScreen(sessionId: sessionId, region: region, accessKeyId: accessKeyId,
                                secretAccessKey: secretAccessKey,
                                sessionToken: sessionToken,
                                expiration: expiration, resultHandler: { resultValue in
              // Return the result to Flutter
              result(resultValue)
          })
      }
  }

  private func openSwiftScreen(sessionId: String,
                               region: String,
                               accessKeyId: String,
                               secretAccessKey: String,
                               sessionToken: String,
                               expiration: Int,
                               resultHandler: @escaping (Bool) -> Void) {
      // Create a new UIViewController with a hosting controller for SwiftUI view
      let hostingController = UIHostingController(
          rootView: MySwiftScreen(sessionId: sessionId,                                                                            region: region,                                                                            accessKeyId: accessKeyId,                                                                  secretAccessKey: secretAccessKey,
                                        sessionToken: sessionToken,
                                        expiration: expiration,
                                        resultHandler: resultHandler))

      // Present the UIViewController
      window?.rootViewController?.present(hostingController, animated: true, completion: nil)
  }
}

struct MySwiftScreen: View {
  @State private var isPresentingLiveness = true
  @State private var errorMessage: String?
  @State private var showError = false

  let sessionId: String
  let region: String
  let accessKeyId: String
  let secretAccessKey: String
  let sessionToken: String
  let expiration: Int
  var resultHandler: (Bool) -> Void

  func dismissNativeScreen() {
      DispatchQueue.main.async {
          if let appDelegate = UIApplication.shared.delegate as? AppDelegate,
             let window = appDelegate.window {
              window.rootViewController?.dismiss(animated: true, completion: nil)
          }
      }
  }

  var body: some View {
      VStack {
          if validateCredentials() {
              FaceLivenessDetectorView(
                  sessionID: sessionId,
                  credentialsProvider: createCredentialsProvider(),
                  region: region,
                  isPresented: $isPresentingLiveness,
                  onCompletion: { result in
                      switch result {
                      case .success:
                          print("Face Liveness succeeded!")
                          resultHandler(true)
                          isPresentingLiveness = false
                          dismissNativeScreen()
                      case .failure(let error):
                          print("Face Liveness failed with error: \(error.localizedDescription)")
                          errorMessage = error.localizedDescription
                          showError = true
                          resultHandler(false)
                          isPresentingLiveness = false
                          dismissNativeScreen()
                      }
                  }
              )
          } else {
              Text("Invalid credentials configuration")
                  .foregroundColor(.red)
                  .padding()
          }
      }
      // iOS 14+ compatible alert
      .alert(isPresented: $showError) {
          Alert(
              title: Text("Error"),
              message: Text(errorMessage ?? "Unknown error occurred"),
              dismissButton: .default(Text("OK")) {
                  showError = false
                  dismissNativeScreen()
              }
          )
      }
      .onAppear {
          logConfiguration()
      }
  }

  private func validateCredentials() -> Bool {
      // Validate all required fields
      guard !sessionId.isEmpty,
            !region.isEmpty,
            !accessKeyId.isEmpty,
            !secretAccessKey.isEmpty,
            !sessionToken.isEmpty,
            expiration > 0 else {
          print("❌ Validation failed:")
          print("sessionId: \(sessionId.isEmpty ? "empty" : "valid")")
          print("region: \(region.isEmpty ? "empty" : "valid")")
          print("accessKeyId: \(accessKeyId.isEmpty ? "empty" : "valid")")
          print("secretAccessKey: \(secretAccessKey.isEmpty ? "empty" : "valid")")
          print("sessionToken: \(sessionToken.isEmpty ? "empty" : "valid")")
          print("expiration: \(expiration)")
          return false
      }
      return true
  }

  private func createCredentialsProvider() -> MyCredentialsProvider {
      let provider = MyCredentialsProvider(
          accessKey: accessKeyId,
          secretKey: secretAccessKey,
          sessionToken: sessionToken,
          expirationEpochSeconds: expiration
      )
      return provider
  }

  private func logConfiguration() {
      print("📱 Face Liveness Configuration:")
      print("Session ID: \(sessionId)")
      print("Region: \(region)")
      print("Access Key ID: \(String(accessKeyId.prefix(10)))...") // Only log first 10 chars for security
      print("Session Token exists: \(!sessionToken.isEmpty)")
      print("Expiration: \(Date(timeIntervalSince1970: TimeInterval(expiration)))")
  }
}

// The rest of the code (MyCredentialsProvider and BasicSessionCredentials) remains the same
struct MyCredentialsProvider: AWSCredentialsProvider {
  let accessKey: String
  let secretKey: String
  let sessionToken: String
  let expirationEpochSeconds: Int

  func fetchAWSCredentials() async throws -> AWSCredentials {
      print("🔐 Fetching AWS credentials...")

      guard !accessKey.isEmpty, !secretKey.isEmpty, !sessionToken.isEmpty else {
          print("❌ Invalid credentials provided")
          throw CredentialsError.invalidCredentials
      }

      let credentials = BasicSessionCredentials(
          accessKey: accessKey,
          secret: secretKey,
          sessionToken: sessionToken
      )

      print("✅ AWS credentials created successfully")
      return credentials
  }
}

enum CredentialsError: Error {
  case invalidCredentials
}

struct BasicSessionCredentials: AWSCredentials {
  let accessKeyId: String
  let secretAccessKey: String
  let sessionToken: String?

  var expiration: Date? {
      return nil
  }

  init(accessKey: String, secret: String, sessionToken: String?) {
      self.accessKeyId = accessKey
      self.secretAccessKey = secret
      self.sessionToken = sessionToken
      print("📝 BasicSessionCredentials initialized")
  }
}

As i am not an expert of swift development so I was able to surpas the syntax error messages by getting help from AI-Bots like chatGPT and Claude. But every time The FaceLiveness Check View is presented, it exits with the error:
An unknown error occurred
In order to get a different error message i provided a dummy SessionId but the error i got was still an unknown error.
It would be great if anyone expert could point out what i am doing wrong or if there's anything missing in the configuration.

I know its lengthy code, but if you could just help me out here i would really appreciate that.


When setting a Boolean type by default, it does not add

exemple code:
@SubEntity()
class EditedEvent extends BaseEntity {
@Column({
type: Boolean,
defaultValue: false, //does not work
})
enable: boolean;
}

The lib can't handle defaultValue: false because it compares if (!defaultValue), or something likes this, it's truly a bug and will be fixed as soon as possible.


Unhandled exception when multi subscribers

under window 10 C# net6
version: 1.0.169
Created a simple publisher/subscriber test and working perfectly for 1P1C mode (P-producer, C- consumer)
however, when trying 1P2C mode, get the following exception after a short while in one of consumers
Unhandled exception. System.InvalidOperationException: This is unexpected and can be a serious bug. We take a lock on this message prior to this point which should ensure that the HeadOffset is left unchanged.
   at Cloudtoid.Interprocess.Subscriber.TryDequeueImpl(Nullable`1 resultBuffer, CancellationToken cancellation, ReadOnlyMemory`1& message)
   at Cloudtoid.Interprocess.Subscriber.TryDequeueCore(Nullable`1 resultBuffer, CancellationToken cancellation, ReadOnlyMemory`1& message)
   at Cloudtoid.Interprocess.Subscriber.TryDequeue(Memory`1 resultBuffer, CancellationToken cancellation, ReadOnlyMemory`1& message)

Hey @PeterLukAtPulsar , do you happen to have a repro? Thanks

There is a PR out to fix this issue, @PeterLukAtPulsar.


feat : add new svg icons for "xls", "zip" and "csv"

What does it do?
Adds three new icons ("xls," "zip," and "csv") from the Phosphor icon library to enhance file-type representation. The icons are named FileXls, FileZip, and FileCsv to standardize naming.
Why is it needed?
These icons are required for upcoming improvements in the Media Library, allowing users to better identify specific file types.
How to test it?
Storybook Verification : Check the Storybook instance for the icon library. The new icons should be visible along with other icons, as shown in the screenshot.

Related issue(s)/PR(s)
This update addresses part of the requirements outlined in Issue #1813

Hey @mukulpadwal, thanks a lot, it's all good from a design point of view!
I'll let @remidej approve the code part 🙂


Review dangling DNS

Background

We have identified some records that need to be tidied up. Create plan for changes.
Approach

Review list
Agree action for each record

Acceptance Criteria

[ ] All DNS records have an agreed action

Reference
How to write good user stories

I've gone over the initial spread sheet and investigated the DNS records. I've left those which can are dangling dns records and can be removed in.
I've also created a second sheet named potential dangling DNS, this sheet contains a list of records that weren't covered in the initial investigation due to requiring a more thorough analysis to confirm whether they are dangling records.
https://docs.google.com/spreadsheets/d/1wwJtkvsSHnBdaE3w3cYTNRMbbqrQ9vqghs0bfTIe9Y0/edit#gid=2130310055


Spelling

This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/opnsense-core/commit/4f5c97a72e7611777fcc2868d80b7a3dc140c219#commitcomment-78757570
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/opnsense-core/commit/e11b2e05e81d1b7f03b426789d99035d09edcdcb
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.
I'll annotate this shortly... I'm certainly happy to drop things. Note that I've made a similar PR to https://github.com/pfsense/pfsense

Thanks, squashing to indicate reviewed / reduce commit noise!


[WIP] Gamma partial collateralization: integration tests

Task: Gamma partial collateralization: integration tests
High Level Description
Code

[x] Unit test 100% coverage
[x] Does your code follow the naming and code documentation guidelines?

Documentation

[x] Is your code up to date with the spec?
[ ] Have you added your tests to the testing doc?

@haythem96 can you rebase this branch to v2.0.0
We should organize our commit messages better and now it's giving 0 clue about this PR.


State stuck at opening/closing

Under certain circumstance the state gets set to "opening" or "closing" and does not change. Under these circumstances everything locks up and you cannot open or close the door.
WORKAROUND: Either change the state in the DB or delete the docker volume to restore back to defaults.

Fix for this has been raised in https://github.com/michaelgambold/pi-garage/pull/40

Fix has been published in release https://github.com/michaelgambold/pi-garage/releases/tag/v1.4.0


Host Cannot Have Client-Side Mods

When host haves a client-side mod, my friend get this error;

But when i join him while having a client-side mod but he doesn't, i can join.
This tested in a minimal instance, there was no other mods added except Fabric API.

Hi, I just had the same issue... can it be this maybe?
I was trying to show a mod to a friend and I had 3D skin layers mod. For some reason he was not able to join mine, but I was able to join his world .
Later I found that removing my CLIENT side mod, fixed the issue.. why is e4mc like trying to send packets related to something only client side?

this is due to bad implementation of your client-side mod. not this mod's problem.

this is due to bad implementation of your client-side mod. not this mod's problem.

What proves this?

e4mc uses the exact same code path as vanilla LAN servers. it does not and will never touch vanilla packet handling/sending pipeline and any issue is due to the other mod's side.


SPOI-3926: Added kinesis properties in properties.xml file

why did you delete the feedMultiplier and the variance defaults?

Wrong property file. Details on ticket.
On Jan 28, 2015 11:41 PM, "chaithu14"<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/DataTorrent/Malhar/pull/1253
Commit Summary

SPOI-3926: Added kinesis properties in properties.xml file

File Changes

M demos/twitter/src/main/resources/META-INF/properties.xml
https://github.com/DataTorrent/Malhar/pull/1253/files#diff-0 (19)

Patch Links:

https://github.com/DataTorrent/Malhar/pull/1253.patch
https://github.com/DataTorrent/Malhar/pull/1253.diff

—
Reply to this email directly or view it on GitHub
https://github.com/DataTorrent/Malhar/pull/1253.


Generate new library version

First cut at generating a new version of the wrapper library using
code-gen tools.
@sambev

:shipit:


fix: cert-manager duration expects XhYmZs format

It accepts shorter format like Yh, but the mutating webhook, if
installed/enabled will convert it to the full format, causing potential
endless reconciliation loops with tools like ArgoCD
Fixes #190

if installed/enabled will convert it to the full format,  causing potential endless reconciliation loops with tools like ArgoCD

The reverse is also true, If there is a mutating webhook that converts to a shorter format, The change o this PR can cause endless reconcilation loop. I have checked and argocd works fine with both 87600h and 87600h0m0s descriptions. According to upstream's comment, the problem was fixed at v2.10 or later.
I think you should first review the mutating webhook settings, and if you can't avoid the problem, change it so that it can handle both formats.

The reverse is also true, If there is a mutating webhook that converts to a shorter format, The change to this PR can cause endless reconcilation loop. I have checked and argocd works fine with both 87600h and 87600h0m0s descriptions.

The issue isn't with ArgoCD itself, but rather with cert-manager itself, it requires durations to be in that format, and it's cert-manager's own mutating webhook controller that makes this conversion transparently.
So, technically, a Certificate spec.duration field needs to be in this format to be correct, this this PR

Thanks for letting me know.
I tried to check the output format of cert-manager for the review, but I could not see the above behavior in my environment. It may be a difference in versions, so please tell me which version you tested. Or do I need any options for cert-manager?

Thanks for letting me know.

No worries!

I tried to check the output format of cert-manager for the review, but I could not see the above behavior in my environment. It may be a difference in versions, so please tell me which version you tested. Or do I need any options for cert-manager?

The validating/mutating webhook portion of cert-manager is an optional component.
I've seen it with cert-manager 1.13.3 as of now.

I checked my environment, cert-manager is 1.14.4, and the webhook is enabled. Does your environment set additional options for webhooks?
I checked the cert-manager code, but could only find a webhook for the CertificateResuest custom resource and could not found logic for Certificate custom resource.
https://github.com/cert-manager/cert-manager/tree/master/internal/webhook/admission/certificaterequest

The validating/mutating webhook portion of cert-manager is an optional component.

Does this mean it is a external product?

@gozer I agree with your change, and I am also experiencing this issue when installing the chart via ArgoCD. One small suggestion: instead of hardcoding, it would be nice if we can call it via values.yaml, allowing people to modify it based on their requirements.

Thanks! I didn't have time to dig down precisely where it's coming from so I can offer a reproductible test case. At least I am not alone.
And yes, making it a value makes a whole lot more sense. I'll fix the PR.

@gozer
Please check and answer @llamerada-jp's question. We can not approve this unless it is reasonable.


Logger: add logrotate & reduce CPU load

Imlement a simple logrotate. If free space on the SD card falls below a threshold, old log directories are deleted. The threshold is conservative: 300MB or 10% of the disk capacity if that's less, to make it usable on all architectures (SITL, embedded Linux, Pixhawk & co).
Reduces the CPU load of the logger by ~1.5% to 5.3%.
Add a logs symlink to the SITL build root directory for more convenient access to the logs.

Can you please also add a function to keep N logs? The log download is impossible to manage with 200 logs onboard.

Added a parameter SDLOG_DIRS_MAX, to keep the last N log dirs. Default is 0=disabled, so that logs are never deleted unexpectedly.


‘openjdk-8u60b24’ upgrades to ‘openjdk-8u60b24-bootstrap.tar.xz’

When performing a:
nix-env --upgrade

the package 'openjdk-8u60b24' upgrades to a different package, 'openjdk-8u60b24-bootstrap.tar.xz', which is a different package.

This breaks the ability to have the bootstrap tested as being buildable as
part of the release. This expression should be alive and built regularly to
ensure its possible to rebuild the bootstrap when JAVA changes are made.
On Wed, Sep 9, 2015, 02:44 Eelco Dolstra<EMAIL_ADDRESS>wrote:

Closed #9743 https://github.com/NixOS/nixpkgs/issues/9743 via ee83598
https://github.com/NixOS/nixpkgs/commit/ee8359868831991f6cf3ca62d950d731c66796db
.
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/9743#event-404630833.


Showcase. Mobile experience. Search button

When user click on search button he'll see notification window on mobile device. Although on mobile we already has search field and search icon.
http://prntscr.com/l74pct

Related to issue https://github.com/RippleOSI/Showcase-Project/issues/6

Duplication of  https://github.com/RippleOSI/Showcase-Project/issues/6


UIScreen does not support nativeBounds and nativeScale properties

Looks like UIScreen interface is not complete. These properties are available since iOS 8.

This has been fixed in the last release.


apigeecli Create swagger

How do I change the location where the test.zip will be stored?
Is there any way to define where the .zip file will be?

At the moment there is no option to change the location of the zip file. It is created in a temporary folder (a subfolder in /tmp). After importing the zip into Apigee (i.e., create the API Proxy), the zip and folders are deleted.
Why do you want access to the zip file?

I'm working on an Azure DevOps pipeline and need to create a template repository in the cloud. To use this as a template for the golden path, I require the repository as a .zip file.

De: Srinandan Sridhar @.>
Enviado: sexta-feira, 9 de agosto de 2024 01:05
Para: apigee/apigeecli @.>
Cc: Carlos Henrique Gomes @.>; Author @.>
Assunto: Re: [apigee/apigeecli] apigeecli Create swagger (Issue #520)
At the moment there is no option to change the location of the zip file. It is created in a temporary folder (a subfolder in /tmp). After importing the zip into Apigee (i.e., create the API Proxy), the zip and folders are deleted.
Why do you want access to the zip file?
—
Reply to this email directly, view it on GitHubhttps://github.com/apigee/apigeecli/issues/520#issuecomment-2277057077, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASAX34AXQIBXYMMMAWGENILZQQWY7AVCNFSM6AAAAABMHC32Q2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZXGA2TOMBXG4.
You are receiving this because you authored the thread.

I suppose the flow could be:
apigeecli apis create swagger --name=myproxy
apigeecli apis fetch --name=myproxy
writes output to myproxy__1.zip where 1 is the highest revision.

I would recommend against storing zip files as golden paths or templates. As you know, templates require parameters/variables to be filled out before they are used. Storing the apiproxy folder itself as a template in a repo appears to be a better choice. Users can clone the repo, add the parameters and deploy the proxy.
Conversely, since you are working with Swagger, don't store any of the Apigee artifacts (zip or apiproxy folder). The golden path is the Swagger file. Users add/modify the Swagger file as needed.

I would actually use ./apiproxy, but I would still need to unzip the zip. I did it using python zipfile

Thanks for the update, closing this issue.


Saying that a deed is invalid leads to a 500 error on the staging server

On submit I get a 500 error.

@fgregg
I am not getting a 500 error when I replicate your form. What do you think might be going on?


chore: update swagger definitions for the ecommerce endpoints

Updated Swagger definition:

Thank you @edwardsmoses for that change 👍 Happy hacktoberfest


Set pirmary key with name other than 'id' ?

It is possible to set the primary key of a model with name other than 'id'? Every time I try to this, got an Exception:
 stdnet.exceptions.FieldError: Primary key must be named id

PK must be named id. Any reason you want to use a different name?

No, just my naive thought: if django orm can do this stdnet  may as well...

Simplicity.
If you need other unique fields you can specify the unique = True  attribute in the Field constructor.


bump 0.8.13

Problem Statement
What is the problem you're trying to solve?
Related Issue
Fixes #...
Proposed Changes
How do you like to solve the issue and why?
Checklist

[ ] I have read the contribution guidelines
[ ] All commits are signed with git commit --signoff
[ ] My changes have reasonable test coverage
[ ] All tests pass with make test
[ ] I ensured my PR is ready for review with make reviewable

/ok-to-test-managed provider=aws sha=cb43c9f

/ok-to-test-managed provider=gcp sha=cb43c9f

/ok-to-test-managed provider=azure sha=cb43c9f


(GH-1980) Add --env-var cli flag

This adds the --env-var cli flag, which accepts a string that contains
an equals sign and parses it into a key-value pair to set as an
environment variable on the target. This flag is only available when
running commands or scripts, and can be specified multiple times with
different environment variables. If the same key is specified multiple
times the last instance will take precedence. This doesn't interact with
_env_var specified in plans since the flag can only be used when
running commands and scripts.
Closes #1980
!feature

Specify remote environment variables using --env-var (1980)
Users can now set environment variables on targets when running
commands and scripts using the CLI flag --env-var.

FWIW, works on windows:
➜ be bolt command run 'echo $env:Foo;$env:BAR' -t localhost --env-var FOO=BAR --env-var BAR=woot
[DEPRECATION] Struct layout is already defined for class Windows::ServiceStructs::SERVICE_STATUS_PROCESS. Redefinition as in C:/Users/james/src/puppetlabs/bolt/.bundle/gems/ruby/2.5.0/gems/win32-service-0.8.8/lib/win32/windows/structs.rb:67:in `<class:SERVICE_STATUS_PROCESS>' will be disallowed in ffi-2.0.
Started on localhost...
Finished on localhost:
  STDOUT:
    BAR
    woot
Successful on 1 target: localhost
Ran on 1 target in 0.35 sec

However, the pwsh module building logic won't accept multiple env-var parameters. Will have to think on how to accept that. Maybe accept what I do for tasks with -params @{ FOO = 'bar'; BAZ= 'woot' } and unwrap it to multiple env-var statements before invoking

CLA signed by all contributors.


feat(data): add kishore data

Thank you 👍 formatting is a bit off, but I can fix after merging

my bad, will take care of it next time :)


Pylint cleanup

This PR contains changes to address warnings from Pylint. Right now this includes removing trailing whitespace and organizing the imports.

There are still some more warnings left. The current output of running pylint --rcfile ./pylintrc pywren is at https://gist.github.com/shivaram/039511355e726ea7a277f51d3032e1ac
Some of these warnings are simple to fix (like the print formatting).
The other warnings of relative import seem more tricky to fix as from my testing we rely on relative imports to get the lambda runner to work correctly.
Also @ooq @ericmjonas it would be good if you could look at the list of disabled checks at https://github.com/pywren/pywren/blob/pylint/pylintrc#L84 and see if something should be enabled.

Ok I enabled a bunch of more rules and fixed issues raised in them. https://gist.github.com/shivaram/5e297f237fabd268b860f367fb2f9331 is the latest remaining errors.
Some of the remaining ones are about unused variables which I am a bit hesitant to change in this PR as that will need more careful reviewing ?

You have more commits on this, right? @shivaram

I will rebase this with @Vaishaal's recently merged PR. I have some more commits to follow that make some more code changes -- Should we do this in this same PR or do it in a follow up PR ?

I think the idea of having a "safe" PR that requires minimal code change, and a follow up PR that finalizes lint, is pretty reasonable. We can pass the first one very quickly.

Great. Then I will stash the other commits. Can you take a look at the existing ones ? I'll just push one more commit with the rebase

Seems like a flaky test run - Value (pywren_travis_589_7_052493) for parameter iamInstanceProfile.name is invalid. Invalid IAM Instance Profile name - Re-triggering the tests

@ooq - tests pass now