[Bug] Go panic when syncing many dashboards

Describe the bug
Sometimes there is a go panic which crashes the pod. It only seems to occur when there is many dashboards to sync (>60). When the pod is automatically restarted, a number of the dashboards are already synced and the sync can be completed.

The panic log
2024-04-17T07:59:38Z	INFO	GrafanaDashboardReconciler	found matching Grafana instances for dashboard	{"controller": "grafanadashboard", "controllerGroup": "grafana.integreatly.org", "controllerKind": "GrafanaDashboard", "GrafanaDashboard": {"name":"xxxxxxxxxx","namespace":"f"}, "namespace": "xxxxxxx", "name": "xxxxxxxxxx", "reconcileID": "e616b68b-b337-468e-a3c1-57fe1b3052c2", "count": 1}
2024-04-17T08:01:53Z	INFO	Warning: Reconciler returned both a non-zero result and a non-nil error. The result will always be ignored if the error is non-nil and the non-nil error causes reqeueuing with exponential backoff. For more details, see: https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/reconcile#Reconciler	{"controller": "grafanadashboard", "controllerGroup": "grafana.integreatly.org", "controllerKind": "GrafanaDashboard", "GrafanaDashboard": {"name":"yyyyyyyy","namespace":"xxxxxxxxxx"}, "namespace": "xxxxxxxxxx", "name": "yyyyyyy", "reconcileID": "778ab291-2559-47e8-aa34-bf2b96f0f94f"}
2024-04-17T08:01:53Z	ERROR	Reconciler error	{"controller": "grafanadashboard", "controllerGroup": "grafana.integreatly.org", "controllerKind": "GrafanaDashboard", "GrafanaDashboard": {"name":"yyyyyyyy","namespace":"xxxxxxxxxx"}, "namespace": "xxxxxxxxxx", "name": "yyyyyyyy", "reconcileID": "778ab291-2559-47e8-aa34-bf2b96f0f94f", "error": "Operation cannot be fulfilled on grafanas.grafana.integreatly.org \"grafana-internal\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:227
2024-04-17T08:01:53Z	INFO	Warning: Reconciler returned both a non-zero result and a non-nil error. The result will always be ignored if the error is non-nil and the non-nil error causes reqeueuing with exponential backoff. For more details, see: https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/reconcile#Reconciler	{"controller": "grafanadashboard", "controllerGroup": "grafana.integreatly.org", "controllerKind": "GrafanaDashboard", "GrafanaDashboard": {"name":"overview.json","namespace":"xxxxxxxxxx"}, "namespace": "xxxxxxxxxx", "name": "overview.json", "reconcileID": "64637408-0770-44a9-a2ce-8e9b436787d5"}
2024-04-17T08:01:53Z	ERROR	Reconciler error	{"controller": "grafanadashboard", "controllerGroup": "grafana.integreatly.org", "controllerKind": "GrafanaDashboard", "GrafanaDashboard": {"name":"overview.json","namespace":"xxxxxxxxxx"}, "namespace": "xxxxxxxxxx", "name": "overview.json", "reconcileID": "64637408-0770-44a9-a2ce-8e9b436787d5", "error": "Operation cannot be fulfilled on grafanas.grafana.integreatly.org \"grafana-internal\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:227
2024-04-17T08:01:53Z	INFO	Observed a panic in reconciler: runtime error: invalid memory address or nil pointer dereference	{"controller": "grafanadashboard", "controllerGroup": "grafana.integreatly.org", "controllerKind": "GrafanaDashboard", "GrafanaDashboard": {"name":"daotimes.json","namespace":"xxxxxxxxxx"}, "namespace": "xxxxxxxxxx", "name": "daotimes.json", "reconcileID": "ad67afed-50b1-4992-a36d-28a2a94e18ff"}
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x194ada2]

goroutine 219 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
	sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:116 +0x1e5
panic({0x1bac840?, 0x33e1ad0?})
	runtime/panic.go:914 +0x21f
github.com/grafana/grafana-openapi-client-go/client/dashboards.(*GetDashboardByUIDOK).GetPayload(...)
	github.com/grafana/grafana-openapi-client-go@v0.0.0-20240215164046-eb0e60d27cb7/client/dashboards/get_dashboard_by_uid_responses.go:117
github.com/grafana/grafana-operator/v5/controllers.(*GrafanaDashboardReconciler).onDashboardDeleted(0xc0006b0800, {0x22762b8, 0xc003f25bf0}, {0xc000d04660, 0xb}, {0xc000d04650, 0xd})
	github.com/grafana/grafana-operator/v5/controllers/dashboard_controller.go:312 +0x2e2
github.com/grafana/grafana-operator/v5/controllers.(*GrafanaDashboardReconciler).Reconcile(0xc0006b0800, {0x22762b8, 0xc003f25bf0}, {{{0xc000d04660?, 0x5?}, {0xc000d04650?, 0xc000c55d08?}}})
	github.com/grafana/grafana-operator/v5/controllers/dashboard_controller.go:183 +0x2ef
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile(0x22798e8?, {0x22762b8?, 0xc003f25bf0?}, {{{0xc000d04660?, 0xb?}, {0xc000d04650?, 0x0?}}})
	sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:119 +0xb7
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc00043cdc0, {0x22762f0, 0xc0002d8c30}, {0x1c86260?, 0xc009584cc0?})
	sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:316 +0x3cc
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc00043cdc0, {0x22762f0, 0xc0002d8c30})
	sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:266 +0x1af
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
	sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:227 +0x79
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2 in goroutine 83
	sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:223 +0x565

Version
5.8.0
To Reproduce
It seems hard to reproduce, but having many dashboard helps. To trigger the problem I restart the grafana pod (to have it empty) and then restart the operator pod after a few seconds. Then there is a full sync of all the dashboards and datasources.
Expected behavior
Not a crashing pod. :-)
Suspect component/Location where the bug might be occurring
The panic points to github.com/grafana/grafana-operator/v5/controllers/dashboard_controller.go:312, but
I'd assume the problem is somewhere else, perhaps even in github.com/grafana/grafana-openapi-client-go
Runtime (please complete the following information):

Grafana Operator Version 5.8.0
Environment: Openshift 4.12
Deployment type: deployed
Grafana is running it's own deployement and grafana-operator thinks it's an external grafana

That's certainly something interesting to investigate, thanks for reporting!

The issue could be the error handling here : if the error is  GetDashboardByUIDNotFound, we don't return, but instead continue to run resp.GetPayload().
This happens in onDashboardDeleted, so if the dashboard isn't found, we can return without an error here.

Probably a stupid question, but as this occurred during the first population of the dashboards to Grafana, why is onDashboardDeleted being called?

@smuda Well, it's hard to say without seeing it in a lab, but it could potentially be in at least two cases:

dashboard uid got updated, then you should see a log message dashboard uid got updated, deleting dashboards with the old uid;
maybe some delays in synchronization of etcd if you have multiple replicas. When the dashboard controller receives an event, it tries to fetch a CR from API-server, and if API-server replies that the CR does not exist, onDashboardDeleted gets called to clean up the dashboard from Grafana instances. etcd has a concept of quorum read, and I'm not sure if API-server relies on it when interacting with etcd.


[Release 1.1] kfctl release

Opening this issue to track releasing kfctl as part of 1.1.

Ref: kubeflow/kubeflow#5022

We will need to

Cut a release branch
Publish updated binaries for kfctl

We still need to find an owner

Per the discussion in:  https://github.com/kubeflow/kfctl/pull/338 I will take care of this for 1.1.

/assign @crobby

@crobby Do you have the necessary permission to cut branches and do releases in GitHub?
Are we on track for 06/19 to do a branch cut and an RC?

@jlewi I doubt that I have permissions to cut branches and do releases.  This is my first rodeo, so any guidance you can give is greatly appreciated.
There are quite a few outstanding p0 items, but many of them seem to have been around for awhile, so I'm not sure how critical they might or might not be.  I will be going through them to see if there are any that I deem critical.

I have confirmed that I don't have permission for branches/releases.

@crobby please take a look at the links in
https://groups.google.com/forum/#!topic/kubeflow-discuss/pGflW6m9Xrg
To understand how github permissions are managed.

@jlewi (or anyone else who may know):  I have an rc.0 release up for the binaries.  I still need to see about adding some testing for the v1.1 branch, but one thing that isn't quite clear to me is how I get the operator image pushed to the desired location?  I see the Makefile has some targets that might help me with that, but they seem to do some "gcloud" commands.  Do I need an account of some sort for those things?  Any sort of special permissions?
Thanks

@crobby I don't think we've been publishing docker images for kfctl. I think the docker images were largely intended for developers.
What does the release guide for kfctl say? Do we need to update the kubeflow website docs to point to the latest kfctl releases?

Ah, that would explain why I wasn't finding any docs about releasing the container images.  The guide only mentions the kfctl binaries, so I will go with that.
There is a section about "versioning the website", but that seems to be something that would be done outside of the specific kfctl release and as a part of the whole KF release since it impacts "everything".
Thanks again

@crobby @jlewi @animeshsingh for the Kubeflow operator image, we will manually create one after the 1.1 release is out. In the longer term, we will seek the option to move the image to gcr.io and make it part of the release process. Thanks.

@crobby Could you please open up a PR to update the release guide to explain that we aren't doing a docker image for kfctl?
Should we create a kfctl specific release guide in kubeflow/kfctl and then update the uber release guide to just point to it for kfctl?
The website is a separate process.

@crobby  can we look to generate a binary for kfctl and post it here?
https://github.com/kubeflow/kubeflow/releases

This can be tagged as v1.1.0-rc.0.

@crobby any update?

@krishnadurai @jlewi Apologies, if it was also expected that I'd push the binaries up to:  https://github.com/kubeflow/kubeflow/releases  I did get rc-0 pushed up to https://github.com/kubeflow/kfctl/releases a couple weeks ago.
I do not have permissions to draft new releases in https://github.com/kubeflow/kubeflow/releases, so perhaps someone else can take care of that, otherwise, it will likely take me some time to track down the appropriate permissions to draft releases there.

@krishnadurai @jlewi Apologies, if it was also expected that I'd push the binaries up to: https://github.com/kubeflow/kubeflow/releases I did get rc-0 pushed up to https://github.com/kubeflow/kfctl/releases a couple weeks ago.
I do not have permissions to draft new releases in https://github.com/kubeflow/kubeflow/releases, so perhaps someone else can take care of that, otherwise, it will likely take me some time to track down the appropriate permissions to draft releases there.

Best I can tell, I'd need to be added the release-team in order to be able to create releases at https://github.com/kubeflow/kubeflow/releases I'm not seeing a lower-perimssioned group that would achieve that.  Am I correct, or am I missing something?

@crobby I think that's right as it exists today; although per the WG proposal I think we'd want to eventually create more narrowly scoped teams to admin the kubeflow/kubeflow repo.
That said; I think it makes sense to just publish the kfctl releases on the kfctl repo and make sure our docs point people there.

Any objections if I were to aim for cutting a new RC by the end of this week?

Ok, I have boxed-up rc1 for kfctl.  https://github.com/kubeflow/kfctl/releases/tag/v1.1-rc.1  I'll do some test driving.  Do let me know if you come across any issues.

Seems this is done, we have 1.0.0 out.


What's New 96

Rendered article for review:
https://review.docs.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools?branch=pr-en-us-1566

Docs Build status updates of commit 2a5d9fd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit eb0f077:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 99b0d53:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit cf5adc5:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools.md
:warning:Warning
View
Details

microsoft-edge/devtools-guide-chromium/experimental-features/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/help-icon-of-focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/settings-gear-icon-light-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-didnt-open-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-opens-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-displayed-when-elements-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-hidden-when-console-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-inline-issue-reporting-addl-red.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-simulated-iphone-red-boxes.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/source-map-not-found.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/sources-tool-versus-open-in-vs-code.png
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools.md

Line 82, Column 1: [Warning: file-not-found - See documentation] Invalid file link: './media/edge-devtools-for-vscode-toggle-screencast.png'.
Line 90, Column 48: [Warning: file-not-found - See documentation] Invalid file link: '../../../../visual-studio-code/microsoft-edge-devtools-extension'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e994f64:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/help-icon-of-focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/settings-gear-icon-light-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-didnt-open-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-opens-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-displayed-when-elements-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-hidden-when-console-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-inline-issue-reporting-addl-red.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-simulated-iphone-red-boxes.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-toggle-screencast.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/source-map-not-found.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/sources-tool-versus-open-in-vs-code.png
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit b37ae87:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/help-icon-of-focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/settings-gear-icon-light-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-didnt-open-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-opens-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-displayed-when-elements-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-hidden-when-console-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-inline-issue-reporting-addl-red.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-simulated-iphone-red-boxes.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-toggle-screencast.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/source-map-not-found.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/sources-tool-versus-open-in-vs-code.png
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 38210bb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/help-icon-of-focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/settings-gear-icon-light-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-didnt-open-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-opens-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-displayed-when-elements-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-hidden-when-console-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-inline-issue-reporting-addl-red.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-simulated-iphone-red-boxes.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-toggle-screencast.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/source-map-not-found.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/sources-tool-versus-open-in-vs-code.png
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Added a few more comments above on the experimental features page, but will go ahead and approve so this PR isn't blocked on me. Thanks!

Docs Build status updates of commit db4eda0:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools.md
:warning:Warning
View
Details

microsoft-edge/devtools-guide-chromium/experimental-features/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/experimental-features/focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/help-icon-of-focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/settings-gear-icon-light-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-didnt-open-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-opens-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-displayed-when-elements-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-hidden-when-console-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-inline-issue-reporting-addl-red.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-simulated-iphone-red-boxes.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-toggle-screencast.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/source-map-not-found-buttons.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/source-map-not-found.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/sources-tool-versus-open-in-vs-code.png
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools.md

Line 97, Column 1: [Warning: duplicate-alt-text - See documentation] Alt text 'The Sources tool now notifies you in the Issues tab when sourcemaps can't be loaded.' is duplicated. Within an article, alt text must be unique.
Line 101, Column 1: [Warning: duplicate-alt-text - See documentation] Alt text 'The Sources tool now notifies you in the Issues tab when sourcemaps can't be loaded.' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a11dbf7:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools.md
:warning:Warning
View
Details

microsoft-edge/devtools-guide-chromium/experimental-features/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/experimental-features/focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/help-icon-of-focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/settings-gear-icon-light-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-didnt-open-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-opens-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-displayed-when-elements-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-hidden-when-console-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-inline-issue-reporting-addl-red.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-simulated-iphone-red-boxes.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-toggle-screencast.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/source-map-not-found-buttons.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/source-map-not-found.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/sources-tool-versus-open-in-vs-code.png
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools.md

Line 97, Column 1: [Warning: duplicate-alt-text - See documentation] Alt text 'The Sources tool now notifies you in the Issues tab when sourcemaps can't be loaded.' is duplicated. Within an article, alt text must be unique.
Line 101, Column 1: [Warning: duplicate-alt-text - See documentation] Alt text 'The Sources tool now notifies you in the Issues tab when sourcemaps can't be loaded.' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1dfe506:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools.md
:warning:Warning
View
Details

microsoft-edge/devtools-guide-chromium/experimental-features/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/experimental-features/focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/help-icon-of-focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/settings-gear-icon-light-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-didnt-open-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/clicking-triangle-opens-dropdown.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-displayed-when-elements-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/console-hidden-when-console-tab-selected.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-inline-issue-reporting-addl-red.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-simulated-iphone-red-boxes.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/edge-devtools-for-vscode-toggle-screencast.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/focus-mode.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/source-map-not-found-buttons.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/source-map-not-found.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/media/2021/11/sources-tool-versus-open-in-vs-code.png
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2021/11/devtools.md

Line 97, Column 1: [Warning: duplicate-alt-text - See documentation] Alt text 'The Sources tool now notifies you in the Issues tab when sourcemaps can't be loaded.' is duplicated. Within an article, alt text must be unique.
Line 101, Column 1: [Warning: duplicate-alt-text - See documentation] Alt text 'The Sources tool now notifies you in the Issues tab when sourcemaps can't be loaded.' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


TS-4019: Validate header names and values before passing to FetchSM

https://issues.apache.org/jira/browse/TS-4019

Fixed. Should I squash the commits?

You don't need to squash.  I will use a patch to commit it.


Upgrade stackbrew, fix gitCommit, remove 32bit images

Removing support for old stuff seems like something that should involve dev/user list discussion...

That's fair, but this was kind of supported by accident. It's something that wasn't supported before, that we mistakenly added support for, and now have removed support for current and future versions. (9.0-9.4 still have those architectures, because they don't get updates).
But I agree this would be something to bring to the dev list in the future.

The history here is that right after the 9.6 release I upgraded a cluster on my M1 Mac to the new version, but got some strange errors, Solr would not start, but threw some weird low-level JDK IO exception.  Worse, even after the arm64 images became available, Docker would NOT pull those automatically until I deleted the faulty image or force-pulled the new.
I can imagine that the same would happen on some ARM based cloud server if it happened to auto upgrade immediately after a release announcement, but before the arm64 image was built (this can take 12+ hours).
I was not aware we even build a 32 bit image. And I cannot imagine what system would run Solr on such a chip. Some old RasPI perhaps, although nowdays even smaller systems are 64 bit, no?
Remember that Docker binary images is a convenience release and the supported architectures are clearly labeled on HUB, so we havent taken anything way or broken any promise, other than perhaps it is surprising to potential 32-bit users that support disappears in a minor release. Also, users can build whatever support they like using the Dockerfile we publish. Do you think we should do an ANNOUNCE type email about this?

I'd imagine such a user that expects/required 32 bit would find out relatively quickly; it's not a subtle thing.  It works or it doesn't.  So IMO no need to announce-to/warn users.


@types/markdown-it-emoji not match with markdown-it-emoji

I have the error who says me to install @types/markdown-it-emoji because I use typescipt but the @types/markdown-it-emoji doesn't export full.

@nethriis I had the same problem, I followed the instructions at https://medium.com/@steveruiz/using-a-javascript-library-without-type-declarations-in-a-typescript-project-3643490015f3 and created a file in the root of my project called markdown-it-emoji.d.ts with the contents:
declare module "markdown-it-emoji" {
    import MarkdownIt from "markdown-it";
    export const full: MarkdownIt.PluginSimple;
}


Only describes parameters in functions that are specified

Updates the swagger description to only include parameters that are actually annotated.
#95

Similar to the static parameter SwaggerAnnotationsConfig.ShowOnlyAnnotatedRoutes would it be appropriate to have a similar property that allows showing only annotated params? Could be useful for debugging....

Working on a fix for the build.
@theHurc
I could add that. But there is a difference between what is happening here and what was happening with the routes.
The routes would show a lack of data (indicating undocumented routes), but these parameters are showing wrong data (indicating malformed route descriptions).
For example, the POST /User route was showing User as a query parameter, which is just wrong.
So I see adding another config option as something that would mislead more than help debug.
A different solution I would be willing to do is to add your IgnoreInDocumentation or something - and add some automatic parameter documentation.
That way User would be detected as a BodyParameter, because it's not a primitive. And you could still hide your async parameters.

I see what you mean. Whatever you see as consistent with the rest of the code sounds good. I really don't know it that well.

I'm still learning about it myself!
For now, I'm going to keep this quick solution. And I think I will address the automatic generation when we start working on Swagger 3.

Excellent!

Uuuuh I don't understand why the build is failing. I'll look into it tomorrow

Appveyor works a little bit differently now, with different versions of the SDK installed.
I tried one of the solutions on this issue:
https://github.com/appveyor/ci/issues/1377#issuecomment-287644271
{
"sdk": {
"version": "1.0.0-preview2-1-003177"
}
}
This fixed the build issues on AppVeyor, but was annoying because then I'd have to have that specific version of the SDK on my dev machine.
I'm currently trying the approach of updating to Visual Studios 2017 tools.


start vm gives 200 ok but returns errors in response Body

The incorrect 200 status should be fixed by the same fix for https://github.com/zero-os/0-orchestrator/issues/1109

The incorrect 200 status should be fixed by the same fix for https://github.com/zero-os/0-orchestrator/issues/1109


No native support for apple silicon (macOS-arm64)

I tried to build the sample code from here :https://valvesoftware.github.io/steam-audio/doc/capi/getting-started.html
but I can't link the given lib (photon) because it is built for x86_64 and not arm64.
Adding support for arm64 on macOS should fix this issue.
OS version: MacOS Monterey 12.1
Chip: Apple M1
This is the error log I get after trying to compile it with g++(gcc).
[build] FAILED: SteamAudioLearning
[build] : && /opt/homebrew/bin/g++-11 -g -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names  CMakeFiles/SteamAudioLearning.dir/main.cpp.o -o SteamAudioLearning  -Wl,-rpath,[path_to_directory]/steamaudio/lib/osx  /[path_to_directory]/steamaudio/lib/osx/libphonon.dylib && :
[build] ld: warning: ignoring file [path_to_directory]/steamaudio/lib/osx/libphonon.dylib, building for macOS-arm64 but attempting to link with file built for macOS-x86_64
[build] Undefined symbols for architecture arm64:
[build]   "_iplAudioBufferAllocate", referenced from:
[build]       _main in main.cpp.o
[build]   "_iplAudioBufferFree", referenced from:
[build]       _main in main.cpp.o
[build]   "_iplAudioBufferInterleave", referenced from:
[build]       _main in main.cpp.o
[build]   "_iplBinauralEffectApply", referenced from:
[build]       _main in main.cpp.o
[build]   "_iplBinauralEffectCreate", referenced from:
[build]       _main in main.cpp.o
[build]   "_iplBinauralEffectRelease", referenced from:
[build]       _main in main.cpp.o
[build]   "_iplContextCreate", referenced from:
[build]       _main in main.cpp.o
[build]   "_iplContextRelease", referenced from:
[build]       _main in main.cpp.o
[build]   "_iplHRTFCreate", referenced from:
[build]       _main in main.cpp.o
[build]   "_iplHRTFRelease", referenced from:
[build]       _main in main.cpp.o

We could really use an macOS arm build as well.

Hi all,
I left a post about this on the Steam Audio forum as well, but I thought I would follow up here with more detail in case it helps with resolving the issue more quickly. Here are the errors I am getting when I import the Steam Audio 4.1.3 package into Unity on an M1 Max MacBook Pro running macOS 13.2:
Plugins: Couldn't open /Users/---/Desktop/Steam Test/Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon, error: dlopen(/Users/---/Desktop/Steam Test/Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon, 0x0002): tried: '/Users/---/Desktop/Steam Test/Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64')), '/System/Volumes/Preboot/Cryptexes/OS/Users/---/Desktop/Steam Test/Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon' (no such file), '/Users/---/Desktop/Steam Test/Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64'))
Plugins: Couldn't open Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon, error: dlopen(Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon, 0x0002): tried: 'Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64')), '/System/Volumes/Preboot/Cryptexes/OSAssets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon' (no such file), '/Applications/Unity/Hub/Editor/2021.3.8f1/Unity.app/Contents/Frameworks/Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon' (no such file), '/Applications/Unity/Hub/Editor/2021.3.8f1/Unity.app/Contents/Frameworks/Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon' (no such file), '/usr/lib/Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon' (no such file, not in dyld cache), 'Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64')), '/Users/---/Desktop/Steam Test/Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64')), '/System/Volumes/Preboot/Cryptexes/OS/Users/---/Desktop/Steam Test/Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon' (no such file), '/Users/---/Desktop/Steam Test/Assets/Plugins/SteamAudio/Binaries/macOS/audioplugin_phonon.bundle/Contents/MacOS/audioplugin_phonon' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64'))
Thanks for your help with this!

Thanks @kisak-valve for directing me to this thread. Are there any updates on when Apple Silicon support might be provided for Steam Audio users?

We've just released v4.1.4, which adds support for Apple Silicon in macOS builds: https://github.com/ValveSoftware/steam-audio/releases/tag/v4.1.4.


Ensure Scala file is a valid scala file.

This makes sure Metals doesn't attach to buffers that are opened up by
plugins like Fugitive where nvim-metals still thinks it's a Scala file,
but really shouldn't attach to it.
Fixes #181

@mergifyio backport next

Would it maybe have been better to just check if the path is an existent file using a function like:
local function path_exists(path)
  return vim.loop.fs_stat(path) and true or false
end

Or is it possible for metals to work on buffers which aren't on disk?

Ah of course, that's a much better idea. Everything we are working with should be on disk, so this should be fine.


UIMenu.BindMenuToItem does not works

See this modification of the example script that replaces AddItem with BindMenuToItem.
When you build and run the new modified script, there are no Items being generated for some reason.
The log file is clean.
(I don't have the time to diagnose and fix it, sadly)

It appears that you need to add the item first, and then bind it to a menu.
I'm going to keep this open to send a PR with a documentation fix.


HAProxy SPOA result message

Currently the variable returned by coraza-spoa to inform HAProxy to perform a waf block, is called fail. The term fail is confusing and should be replaced.

Additionally types.Interruption exposes more variables (Action, Data, RuleID & Status), which should also be exposed to HAProxy.

Other actions such as Redirect, Deny, Drop, could also be handled correctly in the example HAProxy configuration.

Looking at other modules:

haproxy/spoa-modsecurity originally exposed a 'code' and blocked if > 0:
https://github.com/haproxy/spoa-modsecurity/blob/master/README#L97

corazawaf/coraza/examples/http-server checks whether it.Action == deny (https://github.com/corazawaf/coraza/blob/v2/master/examples/http-server/main.go#L99)

corazawaf/caddy checks whether it.Status > 0
https://github.com/corazawaf/coraza-caddy/blob/master/coraza.go#L211

Redirect implemented in coraza v3, it.Action still needs exposure to haproxy. Note: Redirect status cannot be determined by it.Status because of HAProxy short comings, as retrieving the status code by looking up a variable results in a haproxy parsing error: http-request redirect code 302 location %[var(txn.coraza.data)] if { var(txn.coraza.action) -m str redirect }


Update Readme to add English&Chinese doc link

add d English&Chinese doc link
What is the purpose of the change
add English&Chinese doc link in readme
Brief changelog
add English&Chinese doc link in readme

Codecov Report

Merging #1448 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
- Coverage   31.59%   31.57%   -0.02%
==========================================
  Files         682      682
  Lines       33035    33035
  Branches     6592     6592
==========================================
- Hits        10436    10432       -4
- Misses      20748    20751       +3
- Partials     1851     1852       +1

Impacted Files
Coverage Δ

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
41.66% <0%> (-8.34%)
:arrow_down:

.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java
54.54% <0%> (-2.03%)
:arrow_down:

...bo/remoting/transport/netty/NettyCodecAdapter.java
55.22% <0%> (-1.5%)
:arrow_down:

...baba/dubbo/remoting/transport/mina/MinaClient.java
57.97% <0%> (-1.45%)
:arrow_down:

...ba/dubbo/rpc/protocol/hessian/HessianProtocol.java
63.07% <0%> (+3.07%)
:arrow_up:

...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java
88.88% <0%> (+5.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f22f56...9a91682. Read the comment docs.


Failure to execute script main

When trying to install the new version of valorant rpc v2.5, rpc fails to execute main script

same problem though it is installed but cannot run the app itself

I also have this problem

I have this problem too. I tried some things to fix this but nothing worked :

uninstall all versions of valorant rpc and install 2.5 version
install 2.5version while 2.4 version is installed
manually install the iso8601 package

When the error occurs, the command prompte automatically closes itself.
I also noticed that the installation of the 2.5 version doesn't create the config folder. I manually created it with the config.json file. Even with that the command prompt closes itself without letting me watch the error (i had to record my screen).

Can confirmed, same problem

oh shoot, i recently reinstalled python and forgot to install all of my modules before building the executable
i'll fix this very soon

Well done Moj kardi bete

resolved in v3.0.0


[v0.6.1] UI not displaying, SyntaxError: invalid property id  app.533abea1.js:1:49107

`Note: this is the technical bug tracker, please use other platforms for getting support and starting a (non technical) discussion. See the getting help page for details.
I'm submitting a ...
[x] bug report
[ ] question about the decisions made in the repository
Action taken (what you did)
git clone https://github.com/askmike/gekko.git
changed directory to ~/gekko and ran npm install --only=production
changed directory to ~/gekko/exchange/ and ran and ran npm install --only=production
henry@crunch:~/gekko (develop)$ npm install --only=production

><EMAIL_ADDRESS>install /home/henry/gekko/node_modules/websocket
> (node-gyp rebuild 2> builderror.log) || (exit 0)

make: Entering directory '/home/henry/gekko/node_modules/websocket/build'
  CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
  SOLINK_MODULE(target) Release/obj.target/bufferutil.node
  COPY Release/bufferutil.node
  CXX(target) Release/obj.target/validation/src/validation.o
  SOLINK_MODULE(target) Release/obj.target/validation.node
  COPY Release/validation.node
make: Leaving directory '/home/henry/gekko/node_modules/websocket/build'

><EMAIL_ADDRESS>install /home/henry/gekko/node_modules/sqlite3
> node-pre-gyp install --fallback-to-build

[sqlite3] Success: "/home/henry/gekko/node_modules/sqlite3/lib/binding/node-v57-linux-x64/node_sqlite3.node" is installed via remote

><EMAIL_ADDRESS>postinstall /home/henry/gekko/node_modules/relieve
> node links.js

added 556 packages in 7.204s
henry@crunch:~/gekko (develop)$ cd exchange/
henry@crunch:~/gekko/exchange (develop)$ npm install --only=production
added 130 packages in 1.854s

edited ~/gekko/web/vue/public/UIconfig.js to reflect correct IP address (<IP_ADDRESS> for api host and my machine's IP address for ui host) and set headless to "true"
ran node gekko --ui
	I'm gonna make you rich, Bud Fox.
Serving Gekko UI on http://my.ip.address.here:3000/

navigated to my.ip.address.here:3000 in web browser, see only blank white screen; nothing outputs in terminal when reloading the page.
Expected result (what you hoped would happen)
To see gekko UI in browser
Actual
result (unexpected outcome)
See only blank white page in browser.
In my browser console, I see SyntaxError: invalid property id  app.533abea1.js:1:49107
When I click app.533abea1.js:1:49107 I see
  [edited out]
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)
henry@crunch:~/gekko (develop)$ node -v
v8.11.3
henry@crunch:~/gekko (develop)$ npm -v
5.6.0
henry@crunch:~/gekko (develop)$ uname -a
Linux crunch 4.9.0-6-amd64 #1 SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux

Thanks in advance for any assistance!

Very strange, what browser is that? You shouldn't see minified stack traces (since the app comes bundled with sourcemaps).

I have the same on windows. Firefox and chrome works nicely. Internet Explorer and Edge stay blank. Even with compatibility mode.
Note: i do not see the "minified stack traces". I do see "We're sorry but gekko-vue-ui doesn't work properly without JavaScript enabled. Please enable it to continue" if i pull up the source of the page...
I do not bother IE or Edge anymore so i leave it at that..

@StevenHop I don't have access to a windows machine, so I am unable to test. Strange that it doesn't work on edge though.
As for @151henry151, you did mention linux so I am curious as to your browser. Also:

edited ~/gekko/web/vue/public/UIconfig.js to reflect correct IP address (<IP_ADDRESS> for api host and my machine's IP address for ui host) and set headless to "true"

Please edit the file located at gekko/web/vue/dist/UIconfig.js instead!

@askmike Thanks for taking a look; I am running  Firefox ESR 52.8.1 on my local system (thinkpad):
henry@thinkpad:~$ uname -a
Linux thinkpad 4.9.0-6-amd64 #1 SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux

henry@thinkpad:~$ apt list firefox-esr
Listing... Done
firefox-esr/stable,now 52.8.1esr-1~deb9u1 amd64 [installed]
N: There is 1 additional version. Please use the '-a' switch to see it

henry@thinkpad:~$ firefox-esr -v
Mozilla Firefox 52.8.1

Gekko is running on my remote system (crunch):
henry@crunch:~/gekko (develop)$ uname -a
Linux crunch 4.9.0-6-amd64 #1 SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux

henry@crunch:~/gekko (develop)$ node -v
v8.11.3

henry@crunch:~/gekko (develop)$ npm -v
5.6.0

I tried editing gekko/web/vue/dist/UIconfig.js instead of gekko/web/vue/public/UIconfig.js but didn't see any change in the behavior. Could you possibly help me to understand why there are two different UIconfig.js and what the appropriate usage for each of them is?
Thanks.

Henry,

Could you possibly help me to understand why there are two different
UIconfig.js and what the appropriate usage for each of them is?

This is an unfortunate consequence with the new Gekko coming with an
updated version of the frontend framework (vue), here is some context:
https://github.com/askmike/gekko/pull/2280
The gist of the story is:
The Gekko UI is a web frontend project, whenever your browser loads it
needs to know where the gekko server (backend process) is running (host +
IP) as to even start talking to the server. The UIconfig file was the
easiest way to do this: it is served directly to your browser so the
frontend can directly know where to reach the backend.
This is kind of hacky solution, a better one is to have the frontend ask
the user for this data (some kind of a installation wizard) and store it in
a cache. The current UI is very old and I am already working on a new one
where this will be managed better, read more (outdated info) here:
https://forum.gekko.wizb.it/thread-1429.html

As to your problem, I have not been able to reproduce it yet. When you
click on the error and it loads the minified code, does it highlight a
specific point in the long line (where it is complaining about an id)?
Column 49107 does not seem to be related.
On Sat, Jul 7, 2018 at 12:47 AM, Henry Romp<EMAIL_ADDRESS>wrote:

@askmike https://github.com/askmike Thanks for taking a look; I am
running Firefox ESR 52.8.1 on my local system (thinkpad):
henry@thinkpad:~$ uname -a
Linux thinkpad 4.9.0-6-amd64 #1 SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux
henry@thinkpad:~$ apt list firefox-esr
Listing... Done
firefox-esr/stable,now 52.8.1esr-1~deb9u1 amd64 [installed]
N: There is 1 additional version. Please use the '-a' switch to see it
henry@thinkpad:~$ firefox-esr -v
Mozilla Firefox 52.8.1
Gekko is running on my remote system (crunch):
henry@crunch:~/gekko (develop)$ uname -a
Linux crunch 4.9.0-6-amd64 #1 SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux
henry@crunch:~/gekko (develop)$ node -v
v8.11.3
henry@crunch:~/gekko (develop)$ npm -v
5.6.0
I tried editing gekko/web/vue/dist/UIconfig.js instead of
gekko/web/vue/public/UIconfig.js but didn't see any change in the
behavior. Could you possibly help me to understand why there are two
different UIconfig.js and what the appropriate usage for each of them is?
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/askmike/gekko/issues/2279#issuecomment-403087943, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA7MD2XURHD0eETQf2w9TLRhRpr7sNHlks5uD5SfgaJpZM4VExND
.

--
PGP key at keybase.io/mikevanrossum
https://keybase.io/mikevanrossum/key.asc

Thanks for your time;

As to your problem, I have not been able to reproduce it yet. When you click on the error and it loads the minified code, does it highlight a specific point in the long line (where it is complaining about an id)? Column 49107 does not seem to be related.

When I click the error it does not highlight a specific point in the line; it opens a new tab with a url like "view-source:http://my.ip.address.here:3000/js/app.533abea1.js" which has that big block of text as one line, and then on a second line it has //# sourceMappingURL=app.533abea1.js.map
Here are some screenshots of anything I could see in the inspector/web console that I thought might be relevant:
http://i.imgur.com/KJSjTvi.png
http://i.imgur.com/b7wVuqM.png
http://i.imgur.com/9uFJCXj.png
I thought when I saw something saying "noscript" that I maybe had the noscript plugin installed, but I checked and I don't. It does look like my browser is using IcedTea; in my "plugins" section under "add-ons" I've got an entry called IcedTea which when I click on it says "IcedTea-Web Plugin (using IcedTea-Web 1.6.2 (1.6.2-3.1))The  IcedTea-Web Plugin  executes Java applets." -- could that be related?
Thanks again for any help and for all you've done already, and for making this awesome program!
--Henry

Glad you were able to solve it. I am using Firefox myself as my main browser (but I'll be sure to test on Chrome as well). I have no issues whatsoever.

firefox-esr/stable,now 52.8.1esr-1~deb9u1 amd64 [installed]

Firefox version 52 was released over a year ago, that might explain it. The framework I updated as part of Gekko 0.6 (vue) has the following configuration related to browser versions:
{
  "...": "...",
  "browserslist": [
    "> 1%",
    "last 2 versions",
    "not ie <= 8"
  ]
}

(see https://vuejs-templates.github.io/webpack/babel.html). And Your version is ~10 versions behind (I am running version 62). You can try updating firefox to see if that solves it. I am closing this as I am unable to reproduce and it does not appear to be effecting anyone else. (but feel free to keep commenting).

Upgrading my firefox version resolved the issue. Thanks for the help Mike! :+1:


What's the point of this NPM module?

I don't get the point of this NPM package? It proxies 1:1 to os-homedir. Why not just require('os-homedir') instead?
I might be missing something, so thanks for any insights.
Cheers,

This module was made long before os-homedir. When Node.js decided to add a native method for getting the user's home directory, I made a polyfill matching its API and decided to depend on it here, so not to have duplicate code. The main reason this one is still around is that lots of modules depend on it and I see no reason to inconvenience dependents by deprecating this. This one also gets the home directory on startup and returns a string rather than exposing a method, so it's faster, and I prefer this API. Modules are cheap in Node.js, so doesn't matter. Use whichever you prefer. I'm going to continue using this.

(thumbsup)


should require a given version

should not provide the version on its own, this is outside scope

nope


simple summary stats

extract siteNotes as a directive and support simpleSummaryStats directive.

(screen shot with a different blockchain)

Merging into dev for the time being.

sorry about that.
the latest block height is docs[0].number
index af08a74..5d4f94d 100644
--- a/routes/stats.js
+++ b/routes/stats.js
@@ -52,7 +52,7 @@ var getHashrate = function(res) {
   hashFind.exec(function (err, docs) {
     var x = docs.reduce( function(hashR, doc) {
                             return { "blockTime": hashR.blockTime + doc.blockTime,
-                                     "blockHeight": doc.number,
+                                     "blockHeight": docs[0].number,
                                      "difficulty": Math.max(hashR.difficulty, doc.difficulty) }
                                  }, {"blockTime": 0, "blockHeight": 0, "difficulty": 0});
     var hashrate = x.difficulty / (x.blockTime / docs.length);


Refactor Entity Hierarchy

Summary
In this PR we split the concepts of EventPlayer and TransactionalEntity.
Motivation
Historically, all the entities which had transactions (such as Aggregates, Projections, and ProcessManagers) were able to play to events (handle events, change own state, and produce no response).
However, now the ProcessManagers are not able to declare any kind of such subscriptions. This is why the concept of ProcessManager.play(events) has lost its meaning.
Resolution
The EventPlayingEntity (which was previously the supertype of all the transactional entities, see above) is split into two parts:

TransactionalEntity is the superclass for all the entities capable of transactions;
EventPlayer is the common interface for components which play events.

Aggregate, Projection, and ProcessManager extend TransactionalEntity class but only Aggregate and Projection implement EventPlayer contract.
Implementation Details
The common functionality of playing event streams is extracted into a separate class - TransactionalEvenPlayer. It has a common contract with the event playing entities (declared in EventPlayer interface). See the diagram below for more details.

Other Changes

Commonly used List<Event> type is wrapped into the EvantStream value type.
@VisibleForTesting annotation is removed from getBuilder() method in Aggregate, Projection, and ProcessManager, as it causes warnings each time it's called in the client code.
From now on, Projection dispatches events though transaction instead of invoking the handler directly.

@armiol, PTAL.

@armiol, PTAL again.


Remove unnecessary extra wrapping of valtypes

There's no difference in functionality between f(::Type{Val{n}}) where n =... and f(::Val{n}) where n = ..., but the latter is both cleaner and the intended usage: you plug in the unique instance of the type Val{n} rather than plugging in the type. I'm not able to find any difference in performance between the two approaches but I wanted to clean this up anyway.

Have you done benchmarks? I'm not sure how it shakes out this case, but my understanding is that there is sometimes a reason to prefer ::Type{Val{T}} to ::Val{T}, namely that Val{t}, where t is a literal, is a constant available at compile time and can therefore be constant propagated, whereas Val(t) is value that is only constructed and dispatched at runtime.
At least at one time this was a meaningful distinction that could be detected in certain situations. Perhaps, due to compiler improvements, it is no longer relevant. I would suggest getting advice from someone who actually understands how the Julia compiler works.

This PR would make things much more idiomatic, but we do need the benchmarks, since this code is so critical to decapodes performance. A quick and dirty way to check, since you are touching such a large fraction of the codebase is to just run the tests before and after the change. If the tests take longer, then likely this is the culprit.

This PR would make things much more idiomatic, but we do need the benchmarks, since this code is so critical to decapodes performance. A quick and dirty way to check, since you are touching such a large fraction of the codebase is to just run the tests before and after the change. If the tests take longer, then likely this is the culprit.

Oh I definitely did that, it gets like 1-2% faster IIRC. Also tried some synthetic tests but wasn’t able to show the difference ever affects performance.


updates worker to allow CF instagram claim build to work

Updates the Worker's Instagram route to have more general completion text, adds the sig target allowing for different signatures in the future.

want to add the KV settings in the sample wrangler.toml as well?

Some how, I didn't realize, but this is a dup of #141, closing in favor of that PR.


Fix some scatter issues

Fix some issues with scatter plots:

Always use markersize widths for scatter.
Fix issue with .values_unique not returning the same values as .values

Unrelated to this PR but I noticed that typing of _Normalze was quite difficult because _unique_inverse can be a np.ndarray or DataArray, maybe you could clear that up a bit?

I've reworked _Normalize a little now. Hopefully a little easier to follow. Still not a fan of the optional None outputs, it adds too much extra code. Oh well, will save that for another rainy day.


Upgrade 121-service to Node.js v18

@elwinschmitz is this something you want to process? Because I was about to merge the nestjs-upgrade branch, and then saw this.

@jannisvisser
No I only 'parked' it here, to review/test some more later.


Avoiding rebalance on historical restart

High IO load on historical nodes during one of nodes upgrade/restart
Affected Version
31.0.0
smartSegmentLoading = true
Description
When changing the configuration or upgrading the version we restart historical nodes one by one, waiting until the node being restarted becomes available (become registered in Zookeeper). We have replication factor = 2. But it looks like coordinator immediatelly assigns load tasks on the remaining historicals which causes high IO load on almost all running historicals and deep storage (we use cephfs). In previous versions of Druid we didn't see such behavior, redundancy recovered much more slowly.
Is there a way to tell coordinator to make a delay with redundancy recovery ?
The only coordinator's parameter related to such sitiation that I see is replicationThrottleLimit, but it does not prevent the redundancy recovery load queue from appearing. There must be another setting to delay recovery completely (do not send load tasks to historicals).

Thanks for reporting this issue, @Z9n2JktHlZDmlhSvqc9X2MmL3BwQG7tk !
When smartSegmentLoading is set to true, the value of replicationThrottleLimit provided in the coordinator's dynamic is essentially ignored. Smart segment loading automatically calculates the value of replicationThrottleLimit to be 5% of the total number of "used" segments in the cluster.
So, if you have 1000 used segments in the cluster, replication throttle limit would be calculated as 50.
For the time being, you could try setting these:
smartSegmentLoading: false
maxSegmentsInNodeLoadingQueue: 0
replicationThrottleLimit: 10 (or any other value that suits you depending on the total number of segments in your cluster)

However, in the long run, we would like to improve the computation of replicationThrottleLimit performed by the Coordinator even when smartSegmentLoading is set to true.


[rest-explore] REST API Response Time

Please can you add the response time for the REST API , it helps to measure the performance of the APIs.

Will be part of 1.25 and in beta sooner


Add pre-commit hook for checkstyle

Add hook for Checkstyle, a style checker for Java.

Looks good. Merged in 75226de4f00a592cff591f09a4b580b2e2967264 and renamed to JavaCheckstyle in 4da8aa775e775416185d402f0925b4c6244f9a52, as the former was a bit too vague.


freebsd compile error

hysteria > go build -o hysteria -ldflags "-w -s" ./cmd
ld: error: undefined symbol: sys_now
>>> referenced by timeouts.c:299 (/root/.go/pkg/mod/github.com/eycorsican/go-tun2socks@v1.16.11/core/c/core/timeouts.c:299)
>>>               $WORK/b250/_x003.o:(lwip_init)
>>> referenced by timeouts.c:299 (/root/.go/pkg/mod/github.com/eycorsican/go-tun2socks@v1.16.11/core/c/core/timeouts.c:299)
>>>               $WORK/b250/_x003.o:(lwip_init)
>>> referenced by timeouts.c:299 (/root/.go/pkg/mod/github.com/eycorsican/go-tun2socks@v1.16.11/core/c/core/timeouts.c:299)
>>>               $WORK/b250/_x003.o:(lwip_init)
>>> referenced 15 more times
clang: error: linker command failed with exit code 1 (use -v to see invocation)
# github.com/eycorsican/go-tun2socks/core
In file included from /root/.go/pkg/mod/github.com/eycorsican/go-tun2socks@v1.16.11/core/c_core_6.go:8:
/root/.go/pkg/mod/github.com/eycorsican/go-tun2socks@v1.16.11/core/c/core/ipv6/ip6.c:1471:21: warning: format specifies type 'unsigned short' but the argument has type 'unsigned int' [-Wformat]
/root/.go/pkg/mod/github.com/eycorsican/go-tun2socks@v1.16.11/core/c/include/lwip/prot/ip6.h:97:22: note: expanded from macro 'IP6H_V'
/root/.go/pkg/mod/github.com/eycorsican/go-tun2socks@v1.16.11/core/c/include/lwip/debug.h:150:53: note: expanded from macro 'LWIP_DEBUGF'
/root/.go/pkg/mod/github.com/eycorsican/go-tun2socks@v1.16.11/core/c/custom/arch/cc_others.h:83:42: note: expanded from macro 'LWIP_PLATFORM_DIAG'
In file included from /root/.go/pkg/mod/github.com/eycorsican/go-tun2socks@v1.16.11/core/c_core_6.go:8:
/root/.go/pkg/mod/github.com/eycorsican/go-tun2socks@v1.16.11/core/c/core/ipv6/ip6.c:1472:21: warning: format specifies type 'unsigned short' but the argument has type 'unsigned int' [-Wformat]
/root/.go/pkg/mod/github.com/eycorsican/go-tun2socks@v1.16.11/core/c/include/lwip/prot/ip6.h:98:22: note: expanded from macro 'IP6H_TC'
/root/.go/pkg/mod/github.com/eycorsican/go-tun2socks@v1.16.11/core/c/include/lwip/debug.h:150:53: note: expanded from macro 'LWIP_DEBUGF'
/root/.go/pkg/mod/github.com/eycorsican/go-tun2socks@v1.16.11/core/c/custom/arch/cc_others.h:83:42: note: expanded from macro 'LWIP_PLATFORM_DIAG'

go build  without -ldflags "-w -s"  will lead to fail . Please update Doc @tobyxdd
go build -o hysteria1  ./cmd
github.com/tobyxdd/hysteria/cmd
/home/bhzhu/go/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/tmp/go-build3574215657/b001/exe/a.out: final close failed: Invalid operation
collect2: error: ld returned 1 exit status
successed:
go build -o hysteria -ldflags "-w -s" ./cmd
Env:
Linux   LFS
glib  2.26.20160125
gcc 10.2.0

It seems like go-tun2socks only supports Windows (with _WIN32 macro set), macOS (with __APPLE__ macro set), and Linux (with __linux macro set).
Please build the hysteria with CGO_ENABLED=0 to disable the dependency on go-tun2socks (as well as the tun support).

@haruue thx


editorconfig support

See http://editorconfig.org/ — it would be nice to make CSSComb somehow get some of the settings from the corresponding .editorconfig file.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

:+1: Yeah, would be great

Hi All!
I'm closing this because unless a PR is created it won't likely be addressed.
If you feel strongly about this request I encourage you to dig in and submit a PR 😸


add IFTTTTransformAnimation

IFTTTTransformAnimation
Add IFTTTTransformAnimation
IFTTTTransformAnimation Class can realize the animation with CGAffineTransform.
Background
I think -(void)setTransform is better than -(void)setFrame:.
When you use -(void)setFrame:, many subclass of UIView like UILabel or UIButton call -(void)setNeedDisplay;
As you may know, UIKit is based on Text Kit from iOS7.
Text Kit is grate. but, high cost.
https://developer.apple.com/library/ios/documentation/StringsTextFonts/Conceptual/TextAndWebiPhoneOS/CustomTextProcessing/CustomTextProcessing.html
Using IFTTTFrameAnimation with UILabel instance cause excessive drawing.

Thus, using many UIlabel makes scroll not smooth.
How do you think about it?

@hayashi311 Thanks for your contribution! JazzHands 2.0 has the three types of CGAffineTransform covered with IFTTTScaleAnimation, IFTTTRotationAnimation, and IFTTTTranslationAnimation. Would love your feedback on how those work for you!


Infer indentation of the current source file when expanding trailing closures 🚥 #1110

Depends on https://github.com/apple/sourcekit-lsp/pull/1110

rdar://123600798

@swift-ci Please test


Develop

Replace attributes ["key"] with attributes .get("key", None) to circumvent errors when "key" is not in the event attributes dictionary.

Hi @hbiermann95 , looks like a sensible fix. Would you mind refactoring so that it passes all checks?


Added 2 new functionalities.

Added a function that displays "Please enter some text" if there's no input text, also displays "No text found" if nothing matches the input text and finally if none of that happens it prints the search text.

This works well for me!


Increase minimum delay time in StereoDelay.cpp

When the delay time is set to 0 the observed delay time is 1 second. This PR prevents that value from ever going to 0 while keeping the AUParameter values unchanged.

I'm not even attempting to maintain this repo. Anyone who wants is welcome to fork it for their own use, but cannot spare any time to assist.

Removed @getdunne as a reviewer


Cannot find module

On node 14.5.0 when trying to switch to a folder with a .node-version folder the app throws the following error: Fatal Error: Cannot find module '/Users/verpixelt/.avn/plugins/avn-nvm'
Details

avn avn 0.2.4
node node 14.5.0
n n 6.5.1
zsh zsh 5.7.1

The output of __avn_debug in the directory with a .node-version file is:
Fatal Error: Cannot find module '/Users/verpixelt/.avn/plugins/avn-nvm'.
Require stack:
- /Users/verpixelt/.avn/lib/plugins.js
- /Users/verpixelt/.avn/lib/hooks.js
- /Users/verpixelt/.avn/lib/avn.js
- /Users/verpixelt/.avn/index.js
- /Users/verpixelt/.avn/bin/_avn

avn is loaded in my ~/.{bash|zsh}{_profile|rc} file with:
`[[ -s "$HOME/.avn/bin/avn.sh" ]] && source "$HOME/.avn/bin/avn.sh" # load avn`

Does /Users/verpixelt/.avn/plugins/avn-nvm look like a module?

There are no plugins inside the folder

Looks like you should try reinstalling.
rm -R ~/.avn

Then install.

This is what happens during setup:
avn setup
avn: profile setup complete (~/.zshrc)
avn: restart your terminal to start using avn
/usr/local/lib/node_modules/avn/node_modules/npm/node_modules/graceful-fs/polyfills.js:267
      if (cb) cb.apply(this, arguments)
                 ^

TypeError: cb.apply is not a function
    at /usr/local/lib/node_modules/avn/node_modules/npm/node_modules/graceful-fs/polyfills.js:267:18
    at FSReqCallback.oncomplete (fs.js:177:5)

That seems quite strange. Did that happen before when you ran the setup as well?
This is the type of thing I'd expect all users to experience if it wasn't something unique to your environment.
Any chance you can work on tracking down where the issue is coming from within avn?
Without more detail, I'm going to be honest, I doubt I'd be able to come up with a solution.

Thanks for your reply, @wbyoung. I've tried a few more things including switching from the latest node version at the time 14.5.0, to something lower. In my case I ran your avn setup with 10.0.0 and it worked 🎉
So I thought the node version might have been corrupted, removed it, re-installed 14.5.0 and it failed again, with the same error as posted above.
cb.apply is part of the polyfill.js in graceful-fs. Not sure tho why this would throw an error in my specific case. I've tried a fresh install on another machine. macOS 10.15.5, fresh n install, fresh node 14.5.0, same error on running avn setup.

Ok, could be part of a dependency issue and comparability. Perhaps upgrading all of the dependencies of the project would fix it.
I don't do much coding these days. If you want to give that a try, go for it & let me know or submit a PR.

Avn correct working with node version 10.0.0
When i first installed Avn i used node version 14.6.0 and getting error, this error i gen and with node version 12.18.3
`/Users/usename/.nvm/versions/node/v12.18.3/lib/node_modules/avn/node_modules/npm/node_modules/graceful-fs/polyfills.js:267
if (cb) cb.apply(this, arguments)
^
TypeError: cb.apply is not a function
at /Users/usename/.nvm/versions/node/v12.18.3/lib/node_modules/avn/node_modules/npm/node_modules/graceful-fs/polyfills.js:267:18
at FSReqCallback.oncomplete (fs.js:169:5)`

+1
Setting up a new mac today. First tried to install with Node@12 and got the exact same thing as @lobanovkirill. Switched to Node@10 and it worked.

Thanks for confirming, @tybro103.
PR welcome.

Closing this in favor of #106 which better represents the issue that @verpixelt had after reinstall.

I ran into the same issue when updating from node 10.13.0 to 14.15.1 using nvm
~ $ cd dev/web-pathfinder
Fatal Error: Cannot find module '/Users/konstantintieber/.avn/plugins/avn-n'
Require stack:
- /Users/konstantintieber/.avn/lib/plugins.js
- /Users/konstantintieber/.avn/lib/hooks.js
- /Users/konstantintieber/.avn/lib/avn.js
- /Users/konstantintieber/.avn/index.js
- /Users/konstantintieber/.avn/bin/_avn

Fixed it as suggested by @wbyoung with:
rm -R ~/.avn
nvm exec 10.13.0 npm install -g avn avn-nvm avn-n
nvm exec 10.13.0 avn setup

This seems to have stopped working for node 16


How to install?

Hi,
Sorry I was out of the swift/spm loop for two years, as I was still on Mojave, and a lot has changed, querying google gives various options none seems to work.
First of I'm under Catalina and using XCode 12.4 (AFAIK the last version compatible with Catalina).
My project is a basic SwiftUI macOS app.
In XCode I went to File >  Swift Packages > Add Package Dependency... and search for PixelKit.
In the version selection panel I tried a few things:

Exact == 2.0.4
Up to Next Major from 2.0.4

Both returned the following:

Very interesting project.
Thanks

Ok, I think this lib is macOS 11 only?

Yep, the library is using newer methods and is only compatible with Big Sur

Hi, sorry about that, I've now set the swift tools version to 5.3.
PixelKit 2.0.5 should now be compatible.

@heestand-xyz Awesome thanks!


Setup infrastructure with mloq

Codecov Report

Merging #39 (4228d1d) into main (d0dfffc) will decrease coverage by 4.16%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   60.18%   56.01%   -4.17%
==========================================
  Files          30       22       -8
  Lines        1841     1305     -536
  Branches      266      205      -61
==========================================
- Hits         1108      731     -377
+ Misses        694      536     -158
+ Partials       39       38       -1

Impacted Files
Coverage Δ

judo/data_structures/bounds.py
88.73% <ø> (ø)

judo/data_structures/memory.py
28.78% <0.00%> (ø)

judo/data_types.py
56.19% <ø> (ø)

judo/functions/api.py
81.81% <ø> (ø)

judo/functions/batching.py
44.44% <ø> (ø)

judo/functions/fractalai.py
21.42% <ø> (ø)

judo/functions/images.py
100.00% <ø> (ø)

judo/functions/numpy.py
66.66% <ø> (ø)

judo/functions/pytorch.py
26.02% <ø> (ø)

judo/functions/random.py
60.27% <ø> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0dfffc...4228d1d. Read the comment docs.


update to center icon font

Centring the icons of the font by manipulating the icons with icomoon before creating the font.

Fixed with https://github.com/DevTips/Artists-Theme/pull/57


[py2py3] Check unittests from Slice 1 in py3

Intro
We need to make sure that the work done in the migration slices
is py3 compatible. In particular, we should make sure that the
unittests that are involved in each slice do not fail.
The schedule for this validation / bug-fixing campaign is kept at #10422
Details
This issue is about checking that the unittests from Slice 1,
issue #10055 and PR #10057, do not fail.
A non-exhaustive list of the ut that need to pass is
test/python/WMCore_t/Database_t/ResultSet_t.py
test/python/WMCore_t/REST_t/Error_t.py
test/python/WMCore_t/Agent_t/Configuration_t.py
test/python/WMCore_t/Locale_t.py
test/python/WMCore_t/ThreadPool_t/ThreadPool_t.py
test/python/WMCore_t/REST_t/Auth_t.py
test/python/WMCore_t/Credential_t/Proxy_t.py
test/python/WMCore_t/Database_t/DBFormatter_t.py

In case we do not manage to catch the following error in the unit tests, here is one problem with Py3 reqmgr2:
Traceback (most recent call last):
  File "/data/srv/HG2106d-comp3/sw.amaltaro/slc7_amd64_gcc630/external/py3-cherrypy/17.4.0/lib/python3.8/site-packages/cherrypy/_cprequest.py", line 106, in run
    hook()
  File "/data/srv/HG2106d-comp3/sw.amaltaro/slc7_amd64_gcc630/external/py3-cherrypy/17.4.0/lib/python3.8/site-packages/cherrypy/_cprequest.py", line 65, in __call__
    return self.callback(**self.kwargs)
  File "/data/srv/HG2106d-comp3/sw.amaltaro/slc7_amd64_gcc630/cms/reqmgr2/1.4.9.pre6/lib/python3.8/site-packages/WMCore/REST/Auth.py", line 129, in authz_user
    cherrypy.request.user = user_info_from_headers(key, verbose)
  File "/data/srv/HG2106d-comp3/sw.amaltaro/slc7_amd64_gcc630/cms/reqmgr2/1.4.9.pre6/lib/python3.8/site-packages/WMCore/REST/Auth.py", line 48, in user_info_from_headers
    val = str(val, "utf-8")
TypeError: decoding str is not supported

Hello @amaltaro, I was not able to replicate yout error with the unittests alone, do you have a recipe to replicate it? Thanks in advance!

It's never easy to get cherrypy-related tests running, but here is a diff where you can reproduce this error:
http://amaltaro.web.cern.ch/amaltaro/forAlan/dario.txt
once you fix the string problem, I expect you to hit a different one (in the hashing call, if I'm not wrong) :-D

This patch works perfectly! thanks! :) do you want me to add it to the PR? or is better to leave it out of the dmwm/WMCore code and keep it in our dev envs?

I think it would be positive to add this extra unit test to this PR. Thanks Dario!


cuDNN >= 8 support?

Issue summary
-- Found cuDNN: ver. 8.3.1 found (include: /usr/local/cuda/include, library: /usr/local/cuda/lib64/libcudnn.so)
CMake Error at caffe/cmake/Cuda.cmake:240 (message):
cuDNN version >= 8 is not yet supported.
Is there an estimate on if/when cuDNN 8 or higher will be supported? I can't downgrade and don't know if I can have two versions installed to allow for compilation.
Thanks in advance.
Dale

It's a lot of effort to update to the new API and I haven't yet found the time to do it.  You can use cuDNN 7 with newer CUDA as workaround.


A more encompassing fix for offloading + ac

Context
What is the purpose of this PR? Is it to

[ ] add a new feature
[x] fix a bug
[ ] update tests and/or documentation
[ ] other (please add here)

Please link to any issues this PR addresses.
Fixes #1867
Changelog
What are the changes made in this PR?

Increase condition for calling record_stream to be whenever the storage count is greater.
Add a test case (fails before this PR) to make sure we fixed the issue. How does the test case work? See the notes I wrote myself when contriving:

Note: this uses a private storage use_count API. I'm working on a less sketchy looking API in core, but we don't want to halt this fix due to the progress there. We can always come back and change this to use the newer, nicer API.

Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

[x] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
[x] add unit tests for any new functionality
[ ] update docstrings for any new or updated methods or classes
[x] run unit tests via pytest tests
[ ] run recipe tests via pytest tests -m integration_test
[ ] manually run any new or modified recipes with sufficient proof of correctness
[ ] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

[x] I did not change any public API
[ ] I have added an example to docs or docstrings

Codecov Report
Attention: Patch coverage is 77.94118% with 15 lines in your changes missing coverage. Please review.

Project coverage is 68.43%. Comparing base (f560cbb) to head (3c9b33c).

Files with missing lines
Patch %
Lines

...s/torchtune/training/test_activation_offloading.py
80.30%
13 Missing :warning:

torchtune/training/_activation_offloading.py
0.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
+ Coverage   68.39%   68.43%   +0.04%
==========================================
  Files         311      311
  Lines       16901    16967      +66
==========================================
+ Hits        11560    11612      +52
- Misses       5341     5355      +14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


inventory cmd not working MongoDB

cmd output:
`[Blast][C:\Users\rpcdr\Desktop\Avarice]>python . run
Loading Cogs:

admin ✅
economy ✅
events ✅
fun ✅
inventory ✅
mainbank ✅
shop ✅

Created/modified tables successfully
Avarice is online !
Ignoring exception in on_command_error
Traceback (most recent call last):
File "C:\Users\rpcdr\AppData\Local\Programs\Python\Python310\lib\site-packages\discord\ext\commands\core.py", line 178, in wrapped
ret = await coro(*args, **kwargs)
File "C:\Users\rpcdr\Desktop\Avarice\economy with mongoDB\cogs\inventory.py", line 29, in inventory
if data[0] >= 1:
TypeError: 'int' object is not subscriptable
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "C:\Users\rpcdr\AppData\Local\Programs\Python\Python310\lib\site-packages\discord\client.py", line 378, in _run_event
await coro(*args, **kwargs)
File "C:\Users\rpcdr\Desktop\Avarice\economy with mongoDB\cogs\events.py", line 83, in on_command_error
raise error
File "C:\Users\rpcdr\AppData\Local\Programs\Python\Python310\lib\site-packages\discord\ext\commands\bot.py", line 347, in invoke
await ctx.command.invoke(ctx)
File "C:\Users\rpcdr\AppData\Local\Programs\Python\Python310\lib\site-packages\discord\ext\commands\core.py", line 950, in invoke
await injected(*ctx.args, **ctx.kwargs)
File "C:\Users\rpcdr\AppData\Local\Programs\Python\Python310\lib\site-packages\discord\ext\commands\core.py", line 187, in wrapped
raise CommandInvokeError(exc) from exc
discord.ext.commands.errors.CommandInvokeError: Command raised an exception: TypeError: 'int' object is not subscriptable
`

Thanks you for mentioning the issue.
The issue has been resolved ✅

v3.0.6


Add state cache basic metrics

Motivation
See https://github.com/ChainSafe/lodestar/issues/2153
Description
Adds basic metrics for the state cache. Total gets + hit, allows to compute frequency, total usage and hit ratio.
Closes https://github.com/ChainSafe/lodestar/issues/2153

:+1:
It would be (more) useful to have metrics in the regen module. We would calculate the same sorts of things (hit/miss) but be able to measure the cost/why of misses.

@dapplion I think we should close this in favor of suggestion above:
add metrics to regen module


chore: move GroupTheory.FiniteAbelian to GroupTheory.FiniteAbelian.Basic

In preparation of adding material, this creates a new folder Mathlib/GroupTheroy/FiniteAbelian and moves GroupTheory.FiniteAbelian to GroupTheory.FiniteAbelian.Basic. This is (as of now) a leaf file, so the move has no further downstream effects. The new material will need more imports, so is better added in a separate file.

Thanks!
bors merge


Clarify SMB Fileshare Support for Distribution

Based on RFC 14115619, this is supported. We are going to add support in SSMS for implementing SMB file share but is pending.

@JamesFerebee : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@MashaMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

thanks @JamesFerebee ! I made a slight shift in the language. Thanks! #sign-off


how to prevent breaking a word when the new line happens?

how to prevent breaking a word when the new line happens?

It comes from the "word-break: break-all;" rule that is added. It should be configurable in the plugin options IMO.
Currently the workaround is to override the word-break rule in css with an !important (😞)

this is very important to my application. I am a newbie web developer. Could you please give an example code for the configuration? Thanks

Thank you!!! I fixed it:
style="word-break: normal;"

You're welcome :)
BTW, I just noticed PR #28 would let us solve the issue within the options, we just need to be a bit patient


Improve bot script

Bump specific dependants.

swc-bump:
  - swc_ecma_lints
    - swc

Rerun pull_request check on pull_request_review

PRs for adding test should not require bump command.

Auto-rebase should work once auto-merge is enabled.

Try merging different PR if CI failed (hard)

Closing as partially done


Added env-dependent handling of pagination. Resolves #1032.

@MillenniumFalconMechanic can you fix the conflicts on this one? Thanks. D


[libatomic-ops] Update to v7.7.0-20220827

Describe the pull request

What does your PR fix?

Update to latest upstream, major changes are: atomic_ops_stack fix for arm, refined license terms

Which triplets are supported/not supported? Have you updated the CI baseline?
all

Does your PR follow the maintainer guide?

Yes

Let's wait till official 7.7.0+ release


Help getting app running on Heroku

I'm a little miffed how to proceed here.
I feel like all of the pieces are in place, but something is definitely missing.
Deployment happens automatically on successful builds from github, but for some reason, nothing gets installed python-wise on Heroku. Files are there though.
Any help would be appreciated!

Hi Patrick,
I was testing the Heroku deployment. Two things:
The local deployment test fails and I can't push a non-master branch to heroku. Let's chat about it tomorrow morning.

This
ImportError: No module named portland_python.config.settings.wsgi

seems to be the issue. via foreman start

I'm assuming python 3 for this app. I can run it locally without Heroku. But I too am getting an error (different) when running heroku local. I can run heroku local:run python manage.py runserver --settings=config.settings.local successfully however.

Update: I fixed the bad path to the wsgi file and redeployed. No change in the error at the domain, but I now have pip and things installed on Heroku (confirmed by heroku run bash).
I still can't run Heroku local however.
I tried changing the app structure to match their template, but that resulted in the same error. So I don't think that's an issue.
I also tried using virtualenv instead of virtualenvwrapper, but no dice.
I did notice that when I log into the Heroku shell, I can run syncdb using production settings but get an error on the database settings. This looks correct however...
Thoughts?

When Michelle initially created the app we pushed up some other code git push heroku master (that didn't work). When I do a heroku git:clone -a portlandpython I still get that original code. I wonder if this has anything to do with it.
I'm curious what would happen if we force pushed the new code to heroku master for this app.

Thanks @robotbill!
I did a force push to master; everything seemed to work as normal. I then made a small change to settings since I saw an error where DATABASES hadn't been declared. After that, I was able to do a migration and create a super user.
But I still can't get gunicorn to run.
The logs say ImportError: No module named 'config' but I don't see where this is an issue.

@robotbill @patrickbeeson @hanneshapke
I'm happy to help out here if #17 doesn't do it.

Go for it! I haven't had the time lately to go back into it.

Closed in #16.


[SLAVE] - Master server has to be an IP instead of domain?

Hi,
I noticed, that the master address has to be an IP for a slave zone, rather than a domain, otherwise the following error happens:
Unable to convert presentation address 'xxxxxxxxx'
Is this some sort of bug?

No this is as inteded. Powerdns requires the master to be an ip address.


Add Webex as an Alert Provider

I am happy to implement this myself based off the existing providers and open a PR if members of this community are okay with that.

I thought Webex is like Zoom, video meetings only. Does it have chat channels like Slack?

I thought Webex is like Zoom, video meetings only. Does it have chat channels like Slack?

Webex has a full chat client component that was called Webex Teams up until recently. I think they just brought it into the Webex suite and now it is being branded as Webex for messaging; it is essentially a chat client similar to Slack. For reference: https://www.webex.com/team-collaboration.html

Webex has a full chat client component that was called Webex Teams up until recently. I think they just brought it into the Webex suite and now it is being branded as Webex for messaging; it is essentially a chat client similar to Slack. For reference: https://www.webex.com/team-collaboration.html

The only issue I see with implementing this feature would be testing and debugging issues.

I understand your concerns, but Webex has free tier accounts that should have complete access to the messaging components just like MSTeams. I am happy to implement and test and attach all pertinent screenshots.

I added support for Webex on my end, and I am using the image for my notification-controller deployment currently. Before I open a PR here. I want to make sure the flux developers are okay with the content of the message and formatting of it. I initially wanted to use an Adaptive Card like the MSTeams integration, but Webex does not support Adaptive Cards via the Incoming Webhook integration yet so I am left with markdown options. Also, I couldn't get json to look very good on webex.
The screenshot is directly from the Webex client. Let me know what you think @stefanprodan @phillebaba

This is what the full json looks like. The user scrolls to the right to see the rest of the message.

Just so that I understand the screenshots correctly, will the user see the formatted text or the JSON? I think that even if Webex is not totally identical to the other providers it should use the same format in the messages.

Sorry my messages were not clear. I provided 2 separate options for what the user could see. The first one is a format that I thought would be good. The second is what the user would see if I instead sent json. I prefer the first option.

This screenshot is an updated version of the first option that also includes the metadata, which other providers were supplying.