@ApiModelProperty(allowableValues = "range[min, max]") not working

I am using springfox library to generate swagger documentation. @ApiModelProperty(allowableValues = "range[min, max]") does not seem to work as expected. Any ideas? Thanks!

No idea! May be some details would help. Please take a moment to look over our issue submission guidelines

We have a JSR 303 annotation @Size(min = 1, max = 10) that we want to represent in Swagger documentation in our project. We are using the annotation @ApiModelProperty(allowableValues = "range[1, 10]" but it is not reflecting the range in Swagger UI. Springfox version used is 2.1.2.

That is a limitation of swagger-ui


Inconsistent casing in CORS activity log messages

Storage Explorer Version: 1.22.0-dev
Build Number: 20211110.13
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Monterey 12.0.1
Architecture: ia32/x64
How Found: From running test cases
Regression From: Previous releases (1.21.3)
Steps to Reproduce

Expand one storage account -> Right click the 'Blob Containers' node.
Click 'Configure CORS Settings...' -> Click 'Save'.
Observe the activity log -> Check whether the first character of the word 'blob' is capitalized.

Expected Experience
The first character of the word 'blob' is capitalized.

Actual Experience
The first character of the word 'blob' is not capitalized.

Going to flip this issue around. We prefer the lowercasing!

This is already fixed for tables after table functionality was moved to the extension.

Verified this issue on the build 20220308.2. Fixed for tables.

Will verify this issue when there is a new build.

Verified this issue on the build main/20220315.1. Fixed.


Red Painting As Blue

I have color matched to get the Red from the tmp/board file and Red will continually paint as blue. My Red color code is 229 0 0 when I eye drop it (E50000) as is the same when going from the board

Looks like trying to place yellow places Cyan also.

Turns out that drawing blue will output red, and drawing cyan will output yellow.

I've been trying to reproduce it but I couldn't yet. Could you provide me the image that is failing?

Yepp, 100 percent sure. That and the fact that my image doesn't have any cyan or blue in it ;)
! target

Could you copy your config.js file here? Also, do you have the latest version?

Here is my current config.js
module.exports = {
BOARD_URL: 'https://www.reddit.com/api/place/board-bitmap',
BOARD_FILE: __dirname + '/tmp/board.bmp',
BOARD_H: 1000,
BOARD_W: 1000,
REMOTE_TARGET_URL: 'https://raw.githubusercontent.com/Zequez/placebot-argentina-target/master/official_target.bmp',
REMOTE_TARGET_FILE: __dirname + '/tmp/target.bmp',
LOCAL_TARGET_FILE: __dirname + '/images/target.bmp',
DRAW_URL: 'https://www.reddit.com/api/place/draw.json',
// Use the REMOTE_TARGET_URL file as target, otherwise it's gonna just
// try to read from target.bmp
autoupdateRemoteTarget: false,
// Wait until these amount of accounts are available
// and paint pixels at the same time
bundleAccounts: 2,
//Added Configs
targetStartX: 957,
targetStartY: 478,
drawMode: 'RANDOM',
// Do not send the painting to the server so you don't waste your pixels
// while testing something else
mockPainting: true //true for current color testing/debugging
}

Console Output
###############################################
######### CONFIGURATION (change on config.json)
Using Local Target:  /home/joshj5hawk/reddit-placebot/images/target.bmp
Accounts:  JoshJ5Hawk, RedditStreamBot, AngryGabbyBot, KuemperMooBot, CoachTorchettiBot, AngryYeoBot, WhyIsHeTheMilkmanBot, ahammsamich
Bundle Accounts:  8
Target Start Position:  X: 957  Y: 478
Target Draw Mode: RANDOM
Testing flag: mockPainting
###############################################
###############################################
Getting modhash and cookies for  JoshJ5Hawk
Getting modhash and cookies for  RedditStreamBot
Getting modhash and cookies for  AngryGabbyBot
Getting modhash and cookies for  KuemperMooBot
Getting modhash and cookies for  CoachTorchettiBot
Getting modhash and cookies for  AngryYeoBot
Getting modhash and cookies for  WhyIsHeTheMilkmanBot
Getting modhash and cookies for  ahammsamich
Running users  JoshJ5Hawk, RedditStreamBot, AngryGabbyBot, KuemperMooBot, CoachTorchettiBot, AngryYeoBot, WhyIsHeTheMilkmanBot, ahammsamich
Finding actions
Painting  { x: 983, y: 488, color: 13, name: 'blue' }
Mock painting!
Painting  { x: 987, y: 491, color: 13, name: 'blue' }
Mock painting!
Painting  { x: 981, y: 490, color: 13, name: 'blue' }
Mock painting!
Painting  { x: 965, y: 496, color: 13, name: 'blue' }
Mock painting!
Painting  { x: 996, y: 486, color: 13, name: 'blue' }
Mock painting!
Painting  { x: 987, y: 487, color: 13, name: 'blue' }
Mock painting!
Painting  { x: 991, y: 485, color: 13, name: 'blue' }
Mock painting!
Painting  { x: 987, y: 490, color: 13, name: 'blue' }
Mock painting!
JoshJ5Hawk 5s; RedditStreamBot 5s; AngryGabbyBot 5s; KuemperMooBot 5s; CoachTorchettiBot 5s; AngryYeoBot 5s; WhyIsHeTheMilkmanBot 5s; ahammsamich 5s
Next account in 5 seconds, at 8:42
0/8 accounts until update

Current Target File
http://i.imgur.com/sOTappq.png (target file is .bmp)

Version
Cloned from Git at 0839 April 3rd 2017

Closing as /r/place ended.


refactor: Migrate User Identities Persistence Methods (#869)

Instructions

PR target branch should be against development
PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Migrates Persistence methods for User Identities to Store

Testing Plan

[ ] Was this tested locally? If not, explain why.
Run through the automated tests
Smoke test a new, anonymous user session in a sample app, then attempt to add new user identities
Subsequent events should have updated user identities properties
Refreshing the app should retain the new identities
There should be no changes to expected behavior

Reference Issue (For mParticle employees only.  Ignore if you are an outside contributor)

Closes https://go.mparticle.com/work/SQDSDKS-6518

:tada: This PR is included in version 2.26.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Adding description on how to find docs

Currently there is no pointer on how to find a readme for a specific package. So until the new documentation is ready I am adding this to the main README file.

Thanks @tagrudev


[MB-4063] TIO frontend sorting of payment requests queue

Description
This PR adds the ability to sort the TIO payment request queue table columns.  The default sort on load should show the table sorted by age in descending order.  The Origin GBLOC column should be disabled and not sortable since for all TOO users this will have the same value except for the special Marine Corps transportation office.
Reviewer Notes
I added some flexbox styling because when filtering the queue to one row I noticed the height would cut off the date picker when expanded.  I made sure the queue and various containers were growing in the vertical direction to fix this bug.
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make db_dev_e2e_populate
make server_run
make office_client_run

Login as the TIO office user
View the queue sorted presorted by the age column in the descending direction
Clicking on the age column should toggle to the unsorted state or clicking on another column should sort them in the ascending direction.

Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

Messages

:book:
:link: MB-4063

  Generated by :no_entry_sign: dangerJS against d79fed88afe78dc6f8ae1f04f5b8166c48ce4be2

@noelledusahel @donaldthai Yea that is the default react-table behavior with the toggle unsetting the column.  I explored it but did not feel we had the time to implement our own toggleSort handler properly and test it.  It's definitely possible but there's a good bit going on in that TableQueue component already.

👋 hello! I am here, summoned by dangerJS because you have added a new eslint disable line. I left 3 related comments. the one I am requesting changes for is the new eslint line you've added re: unused variables. the other two I would also super appreciate if you fix now, but those fixes aren't blocking this PR since they are already known issues in the static analysis backlog.

Cthulhu has been awoken 🙈


If available, reuse existing GitHub issue when scheduling a meeting

Currently the scheduling app creates a new issue every time a meeting is scheduled. In the case of REST API meetings, if a service is coming back for a follow up, they use the original GitHub issue instead of opening a new one. This helps to keep track of the history, comments, etc.
Is this true for the other type of meetings? What will be the flow in the scheduler app for this?

Regarding the follow-up meetings, currently there's an implementation for this. If the meeting was not cancelled, and the scheduled date has passed, the app will show a button to schedule a follow-up. What this is actually doing is editing the meeting, and it will keep the following information:

Service
Subservice
GitHub issue

So, no new issue is being created if this is scheduled by clicking the button I mentioned before.
Should I add a new option when creating a new meeting, asking if this is a follow-up for a previous meeting? And then let the user provide the GitHub Issue? I wonder what repercussions this could cause in our current flow.

Also, I should mention that there are labels and messages we have to change so it is clear that the updated meeting is a follow up, and not an update.
Currently, the email and the app display the same messages (titles, emails, etc) as when editing a meeting. This could create confusion.

Is this true for the other type of meetings? What will be the flow in the scheduler app for this?

For SDK Review, there's an option to specify if the meeting type is either Introduction or Follow Up. It will create a new issue on GitHub every time, no matter if Follow Up is selected or not. In this case, I'm deciding how to prevent this and reuse the already existing issue. One option is to ask the user for it (in a textbox), another option is to let the user select a previous introductory meeting and get the GitHub link from our records.

We need to clarify what the behavior for this is for Informational and for SDK Review.  At this point in the development, I am hesitant to change any of those views until we hear explicit feedback from them. I do see how in a more advance stage we would like all meetings to behave similarly.
As for the API Review meeting, I would advise to go with because the follow-up flow you mentioned might not be easily discovered and it won't work for users that today have issues opened against Github:

Should I add a new option when creating a new meeting, asking if this is a follow-up for a previous meeting? And then let the user provide the GitHub Issue?

As for the schedule follow-up flow that is already in place, what do you think about disabling it until we have a clearer understanding of how and frequency it is going to be used? I want to avoid having too much logic or different behaviors to maintain

I opened issue https://github.com/Azure/azure-sdk-tools/issues/3803 to track the work on the other meetin types

@JonathanCrd  looks like the required information is done and we are ready to implement this.
Let me know if that is not the case

Done for API Review.
When scheduling a meeting, there's a new text field at the bottom that allows the user to provide a GitHub Issue. If this text field is not blank, first it is going to validate that the issue exists, and then it will not create a new tracking issue and use that one instead.


error while running with webpack bundle in nodejs

Getting following error while trying to run turndown. I am using esbuild to get the bundle for same.
/Users/mohitsingh/Documents/abc/dom-text-abc-function/dist/main.js:21918
        } else if (stack.top instanceof impl.HTMLTemplateElement) {
                             ^

TypeError: Right-hand side of 'instanceof' is not an object
    at insertElement (/Users/mohitsingh/Documents/abc/dom-text-scrapper-agc/dist/main.js:21918:30)
    at insertHTMLElement (/Users/mohitsingh/Documents/abc/dom-text-agc-function/dist/main.js:21906:19)
    at before_head_mode (/Users/mohitsingh/Documents/abc/dom-text-agc-function/dist/main.js:24842:27)
    at before_head_mode (/Users/mohitsingh/Documents/abc/dom-text-abc-function/dist/main.js:24859:9)
    at before_html_mode (/Users/mohitsingh/Documents/abc/dom-text-abc-function/dist/main.js:24822:9)
    at initial_mode (/Users/mohitsingh/Documents/abc/dom-text-abc-function/dist/main.js:24783:9)

Its due to this https://github.com/fgnass/domino/issues/146

Is there a workaround, anyone know of ?

Not familiar with webpack, so the workaround in general terms:

use the browser build as the dependency - the browser build does not contain domino (see package.js)
if your build is for a browser, you're done. If it is for an environment without DOM parser, you need to bring your own DOM parser (e.g. jsdom) and call turndown with a DOM object instead of string.

For reference, discussion about separating turndown and the DOM implementation: #265 .

@mohit-singh-pepper did you found a solution ?

For anyone still running into this problem, the following worked for me (based on the commit from @julienc91 above):
npm i jsdom
npm i --save-dev @types/jsdom
import { JSDOM } from "jsdom";
import TurndownService from "turndown";

const turndownService = new TurndownService();

const result = turndownService.turndown(
      JSDOM.fragment(your_html_content)
    );

I think this issue should be solved with the latest Turndown release 7.2.0. Can you confirm @mohit-singh-pepper ?

This should be solved with the introduction of custom domino fork in the latest release #461.


After pressing enter to create graphics all the input values are cleared from the pane - ArcGIS Pro

In Distance and Direction after entering all your parameters and pressing Enter to create your graphic, all the inputs you used are cleared out.  I would like to see those values stay there until you explicitly change them.This is a problem because after you press Enter you lose all information about your graphic until you export and get the information from the attribute table.
It looks like this behavior happens on all the tabs

[ ] Line tab
[ ] Circle tab
[ ] Ellipse tab
[ ] Rangs tab

@dfoll I feel that now we write directily to features in the addin we should be able to close this. Can you close this if you feel the same way or explain what work we would need to do to address this issue being that we currently have all actions writing to a feature class?

We are not going to do this based on the level of effort and it is the current design.


ha-nat-gateway example - document the need to have ssh-agent running.

Document the need to have  ssh-agent running and private key to be added to the authentication agent before issuing "gcloud compute ssh" command.

LGTM, thank you!


Syntax error in with-clause

Here's are some examples taken from an example in with.sql of the PostgreSQL Git repository that cause a syntax error:
with cte(foo) as ( values(42) ) values((select foo from cte));

select ( with cte(foo) as ( values(f1) )
          values((select foo from cte)) )
from int4_tbl;

WITH RECURSIVE t AS (
	INSERT INTO y
		SELECT * FROM t
)
VALUES(FALSE);

WITH RECURSIVE t(action, a) AS (
	MERGE INTO y USING (VALUES (11)) v(a) ON y.a = v.a
		WHEN NOT MATCHED THEN INSERT VALUES (v.a)
		RETURNING merge_action(), (SELECT a FROM t)
)
SELECT * FROM t;

WITH t AS (
	INSERT INTO y VALUES(0)
)
VALUES(FALSE);

This statement uses PostgreSQL 17 syntax:
WITH RECURSIVE t(action, a) AS (
	MERGE INTO y USING (VALUES (11)) v(a) ON y.a = v.a
		WHEN NOT MATCHED THEN INSERT VALUES (v.a)
		RETURNING merge_action(), (SELECT a FROM t)
)
SELECT * FROM t;

it will be fixed with #171 .
The other statements just a with_clause before the values_clause, which is not forseen. Fix is easy.


Android: using the native Android Game Development Kit (AGDK) directly for Android platforms

Android Game Development Kit  (https://developer.android.com/games)
The Android Game Development Kit (AGDK) is a full range of tools and libraries to help you develop, optimize, launch, and iterate on high quality Android games.
Maybe a wrapper around the AGDK is needed to have cross platform compatibility

Should be a large work

I agree with the implementation of the AGDK, I have a plan to analyze it soon.

Help for your development workflow
If you're working with game engine sources to create the best Android experience, or using an unmodified game engine as a turnkey solution, we can help.
https://developer.android.com/games#choose-your-workflow


Checking failed with rule 'resolution': pivot was not eliminated

Hi,
When trying to check the proof produced by cvc5 for the files in ex.zip, I get the following error:
[ERROR] checking failed on step 't7599' with rule 'resolution': pivot was not eliminated: '(not (or (not (>= E 1)) (not (and (>= E 0) (not (>= E 1))))))'
invalid

Checking the proof with carcara repeatedly yields different error messages, all mentioning step t7599. Two other error messages are below.
[ERROR] checking failed on step 't7599' with rule 'resolution': pivot was not eliminated: '(not (and (>= E 0) (not (>= E 1))))'
invalid

[ERROR] checking failed on step 't7599' with rule 'resolution': pivot was not eliminated: '(not (>= E 1))'
invalid

Unfortunately I was not able to reproduce the error with a smaller instance. I'm running cvc5 v1.0.5 and carcara v1.0.0, CLI commands below.
cvc5 --produce-proofs --proof-format=alethe --proof-granularity=theory-rewrite --flatten-ho-chains ex.smt2
carcara check --skip-unknown-rules --allow-int-real-subtyping ex.proof ex.smt2

After a lot of investigation, I am convinced that this is a bug in cvc5, and not in Carcara.
The proof fails on the t7599 step, which uses the resolution rule. Two of its premises are:
(step t7557 (cl (not (>= E 1)) (not (and (>= E 0) (not (>= E 1))))) :rule ...)
(step t7586 (cl (>= E 0) (not (and (>= E 0) (not (>= E 1))))) :rule ...)

If these steps, instead of concluding a clause of two terms, concluded a unit clause with an or term (like applying the inverse of the or rule), the proof would be valid:
(step t7557 (cl (or (not (>= E 1)) (not (and (>= E 0) (not (>= E 1)))))) :rule ...)
(step t7586 (cl (or (>= E 0) (not (and (>= E 0) (not (>= E 1)))))) :rule ...)

(the negations of these two or terms are introduced in t7599's first premise, t1035)


Table.from_csv fails on ragged rows

Opening ticket for tracking. See pull request #431.

Reopening because my fix was incorrect. Table.init should already handle ragged rows. Issue is in TypeTester. Will provide proper fix tonight and remove redundant check in Table.from_csv.


RowMap Stmt.Scan documentation

From the docs of Stmt.Scan

Scan retrieves data from the current row, storing successive column values into successive arguments. If the last argument is an instance of RowMap, then all remaining column/value pairs are assigned into the map. The same row may be scanned multiple times. Nil arguments are silently skipped. https://www.sqlite.org/c3ref/column_blob.html

I haven't been able to figure out where RowMap type is defined.
Please can you point me to it?
Thanks.

Thanks for pointing this out.  The reference to RowMap was left behind from the original project that go-sqlite-lite was forked from.  I've removed the reference.


It seems in the evalution part is uses label information.

Hi,
Thanks for the code!
I have a question. When evaluating some data, as one part of the input features in LSTM, the "lan_cont" uses the label information because of the "it" is derived from "seq". As in the code shows (model_svo.py line 424 439) :
#424 it = seq[:, token_idx].clone()
#439 lan_cont = self.embed(torch.cat((svo_it[:,1:2], it.unsqueeze(1)), 1))
And I also noticed there is "loader.has_label" before evaluating it. But I am confused why in the evaluation stage, we can see the labels (that are the captions of the videos)?
Thanks!

Hi, thanks for your question! Yes, but the label is used for loss calculation during evaluation. For actual inference, it conducts the sample function
https://github.com/SydCaption/SAAT/blob/6cf41781d5860455c17433486f1a84a26b6883de/train_svo.py#L355


How to generate "nonce" and add generated code to script and style tags?

Hi @BePsvPT, i have another trouble, how can i add a "nonce" key and add it to script an style tags?
I want to fix Content Security Policy on my Laravel App.

Hi @JohanMa4,
After setting add-generated-nonce to true in script-src and style-src directives, you can use SecureHeaders::nonce() to get nonce value and add to script or style tags.

@BePsvPT could you update doc to add 'SecureHeaders' => Bepsvpt\SecureHeaders\SecureHeaders::class in the for it to work on blade template

Hi @Zabanya,
Can you give an example that using it in blade template?

add aliases in config/app/php
'SecureHeaders' => Bepsvpt\SecureHeaders\SecureHeaders::class

blade usage
<script nonce="{{ SecureHeaders::nonce() }}"> ...

Hi @Zabanya,
I have updated the document, you can find it here.


fix(system-backup/restore): DR volume

Which issue(s) this PR fixes:

Issue longhorn/longhorn#9330
What this PR does / why we need it:
A DR volume doesn't need to have its volume data backed up and should retain and use the FromBackup field in the system backup.
Special notes for your reviewer:
None
Additional documentation or context
None

@mergify backport v1.7.x v1.6.x


Allow to reload application

In rails it happens that you need to restart your complete server, coming from pow I could do it "easily" by touching a file  tmp/restart.txt in my application folder.
It would be handy if hotel included a reload button to easily stop / start a service again and an additional CLI command hotel reload for example

I think Rails (or at least Rails 5) is handling it! So it should be working here. Try it.


F# support

After playing around with the C# implementation, I was thinking about what an F# implementation might look like using Myriad:
C#
[GenerateSerialize]
public partial class Person
{
    public string Name { get; set; }
    public int Age { get; set; }
}

public partial class Person : Serde.ISerialize
{
    void Serde.ISerialize.Serialize(ISerializer serializer)
    {
        var type = serializer.SerializeType("Person", 2);
        type.SerializeField("Name", new StringWrap(Name));
        type.SerializeField("Age", new Int32Wrap(Age));
        type.End();
    }
}

F#
[<GenerateSerialize>]
type Person =
    {
        Name: string
        Age : int
    }

Generated:
module Person

let toSerializable (person: Person) =
    { new Serde.ISerialize with
        member this.Serialize(serializer: ISerializer) =
            let type = serializer.SerializeType("Person", 2)
            type.SerializeField("Name", StringWrap(person.Name))
            type.SerializeField("Age", Int32Wrap(person.Age))
            type.End()
    }

Usage:
{ Name = "John"; Age = 100 }
|> Person.toSerializable
|> JsonSerializer.Serialize
|> printfn "%s"

It wouldn't be quite as user friendly as the C# generator version because:

User would be required to manually include generated output file in the .fsproj file
Possible .toml config file needed
Myriad NuGet package required

Or maybe:
Generated:
module Person

let serialize (serializer: Serde.Json.ISerializer) (person: Person) =
    { new Serde.ISerialize with
        member this.Serialize(serializer) =
            let type = serializer.SerializeType("Person", 2)
            type.SerializeField("Name", StringWrap(person.Name))
            type.SerializeField("Age", Int32Wrap(person.Age))
            type.End()
    }

Usage:
{ Name = "John"; Age = 100 }
|> Person.serialize (Serde.Json.JsonSerializer())
|> printfn "%s"

F# doesn't support partial classes, or source generators yet. https://github.com/fsharp/fslang-suggestions/issues/864

as an interim, maybe look at Chiron's combinator-based model and have a Chiron 'backend' for Serde.ISerialize and Serde.IDeserialize instances?

This issue was kind of DoA, but now I'm curious.

Wouldn't that still involve generating the Chiron FromJson and ToJson static methods?
If so, why not just generate using the SerializeField method as above and avoid the extra dependency?

Do you think there is enough interest in F# community (now that net8 is out) to warrant adding F# support for this library?

FWIW I'm still thinking about this and exactly how to implement it. The main hold-up is that I'm still iterating a bit on the Serde API itself.
For example, right now ISerialize implicitly uses the this parameter as the value, meaning that wrappers also require implementing the IWrapper type to be composable. This original API made sense in the context of languages with type classes (like Rust) because you could add support as an extension and the receiver would implicitly flow into your extension. But it's kind of obnoxious in C#. I've been bitten a few times by forgetting to implement IWrapper and then being stuck when trying to add composition.
So I think I might make ISerialize generic and add the value to the Serialize call. This will require changing the source generator, but that's not a big deal right now. When I add more F# support then I'll have to change Myriad as well, so there's a lot more iteration work. I'm waiting until I'm pretty sure the API's stable fore making more work for myself.


S3 bucket to store Kubernetes config

aws s3api create-bucket --bucket kubernetes-aws-io
gives
An error occurred (BucketAlreadyExists) when calling the CreateBucket operation: The requested bucket name is not available. The bucket namespace is shared by all users of the system. Please select a different name and try again.
You should advise users to suffix the bucket.

Also fixed in upcoming PR


Is it possible to set orientation for dialogs?

Firstly, thanks for library. I'm using some activities in landscape mode, but I need portrait orientation for dialog. Like this.

Material Dialogs version: <IP_ADDRESS>

MaterialDialog is just an android.app.Dialog, so if there is a way, it wouldn't be specific to this library.
However, I won't add a way to do it specifically.


Simplify HTLCs in ts client

PR follows work from #27 , where address payable was replaced with a designated owner/intermediary enum target.
Quirks in typechain allowed this to be ignored - it seems that both address payable and enum convert to TS BigNumberish.

In favour of #37


AppConfigurationPushTask: Handle null values in Configuration file

When null values are present in the json configuration file, the task will fail with the error "Cannot convert undefined or null to object"
We should have an update to handle null values

@MaryanneNjeri please add details to the issue.

Issue is resolved in the latest version of the AppConfigurationPush task version 7.0.0


Fair Squares W3F grant proposal

Think we are ready to soon to create a PR in the w3f repo, we just need proof-read the grant proposal and review the parts we write.
Parts that are missing still

Visualisation for milestone 5
ETH address for grant payments

@ndkazu when you have time can you please re-check the state-diagram and make it coherent with all the naming in the proposal.
@letodunc added all the sequence diagrams as links in text and please also proof-read and review it.

Added review Mahir

changed comments @letodunc


Upgrade Spring 6.2.0 -> 6.2.1

This PR contains the following updates:

Package
Type
Update
Change

Spring
import
patch
6.2.0 -> 6.2.1

Release Notes

spring-projects/spring-framework (Spring)
v6.2.1
Compare Source
:star: New Features

Implement toString() in TestBeanOverrideHandler #34072
Log alias removal in DefaultListableBeanFactory #34070
Log warning when one Bean Override overrides another Bean Override #34056
Introduce "unsafeAllocated" flag in TypeHint #34055
Cannot assert status reason phrase with MockMvcTester #34016
Improve toString for reactive ScheduledTask #34010
Optimize sending requests without a body in RestClient and WebClient with Reactor Netty #34003
Add missing @Contract annotation to ObjectUtils#isEmpty #33984
OptionalValidatorFactoryBean suppresses Hibernate Validator configuration failures too much #33979
Support Flux<ServerSentEvent<Fragment>> in WebFlux #33975
Update in FragmentsRendering to names of static methods #33974
Honor @Fallback semantics for Test Bean Overrides #33924
AdvisedSupport.MethodCacheKey should check for logical equality as well as identity #33915
Fail with full description for XML diff in XmlExpectationsHelper #33827
MapMethodProcessor should only resolve arguments of type Map or the ModelMap hierarchy #33160

:lady_beetle: Bug Fixes

Support binding from request headers via constructor args #34073
Unable to configure custom scheduler for @Scheduled annotation #34058
Identical Bean Overrides are silently allowed #34054
OOM due to NoTransactionInContextException in reactive pipeline #34048
Priority header causes binding exception after upgrade to Spring Framework 6.2.0 #34039
@MockitoBean incorrectly injects supertype into subtype field #34025
NestedPlaceholder are not recursively resolved if the fallback is a placeholder #34020
AOT no longer generates BeanInstanceSupplier signature for a CGLIB proxy with its public type #33998
Nested transaction support via savepoints is broken in Oracle database #33987
Proxy created with IntroductionInterceptor but without target always throws an exception #33985
ApplicationListener no longer invoked for generic ApplicationEvent with 6.2.0 #33982
Error handling override in DefaultResponseErrorHandler ignored after upgrade to 6.2.0 #33980
BeanCurrentlyInCreationException is thrown when multiple threads simultaneously try to create a FactoryBean #33972
HandshakeWebSocketService assumes jakarta websocket is present #33970
@Value cases SpringCGLIB$$0 required a bean of type java.lang.String that could not be found in Native compile when migrating to SB 3.4 #33960
PathMatchingResourcePatternResolver should not log directory-skip messages at info level #33956
Avoid infinite recursion in BeanValidationBeanRegistrationAotProcessor with recursive generics #33950
Skip runtime hint registration for validation constraint with missing dependencies #33949
Move Kotlin value class unboxing to InvocableHandlerMethod #33943
MockReset strategy is no longer honored for @MockitoBean and @MockitoSpyBean #33941
TypeDescriptor with recursive generics triggers infinite recursion in ResolvableType.equals/hashCode #33932
RestClient does not expose full URI template as attribute #33928
Bean Overrides like @MockitoBean and @TestBean should not be allowed on static fields #33922
Regression in duplicate beans with different method names #33920

:notebook_with_decorative_cover: Documentation

Fix link to MockMvcBuilders in reference documentation #34031
Fix a typo in the filters documentation #33959
Document visibility requirements for Bean Overrides #33923
Fix typos and link in Observability documentation #33910
SpEL documentation contains syntax errors #33907
Improve explanation of AOP advice classes that should implement MethodInterceptor #33901
Reflect well-known HttpHeaders intent in Javadoc #33886
Reflect well-known MediaTypes intent in Javadoc #33754
Document support for varargs invocations in SpEL #33332

:hammer: Dependency Upgrades

Upgrade to Micrometer 1.14.2 #34050
Upgrade to Reactor 2024.0.1 #34051

:heart: Contributors
Thank you to all the contributors who worked on this release:
@Boiarshinov, @CHOICORE, @KNU-K, @izeye, @ngocnhan-tran1996, @scordio, @sonallux, and @youabledev

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Spring 6.2.0 -> 6.2.1

See:
- https://github.com/spring-projects/spring-framework/releases/tag/v6.2.1
- https://github.com/spring-projects/spring-framework/compare/v6.2.0...v6.2.1


installing scann on osx

Hi, I'm trying to install scann on OSX 11.5.2 (20G95) in the context of Anaconda jupyter notebooks 6.1.4
❯ pip install -q scann
ERROR: Could not find a version that satisfies the requirement scann (from versions: none)
ERROR: No matching distribution found for scann

Here's all my current tensorflow related versions:
tensorboard                        2.4.1
tensorboard-plugin-wit             1.8.0
tensorflow                         2.4.1
tensorflow-datasets                4.4.0
tensorflow-estimator               2.4.0
tensorflow-hub                     0.12.0
tensorflow-metadata                0.29.0
tensorflow-recommenders            0.5.1

has anyone had any luck installing on OSX?  Any hints about what I might be able to fix this?

related to https://github.com/google-research/google-research/issues/779 ?


Bug(?) - Repeat flag is shown when launching miniplayer

I've notced that when I launch miniplayer, the repeat_string is displayed in the bottom left corner, suggesting that repeat has been toggled on. This doesn't appear to have any real effect, however. Any idea what might be causing this string to be displayed when launched?
Looking at lines 230-237 seem to suggest a check if repeat mode is enabled by the MPD client and to reflect as much in Miniplayer.
I've checked to see if changes are indeed being made to the client by having miniplayer and ncmpcpp open at the same time - if I have focus on ncmpcpp and press the 'r' key, nothing happens to miniplayer yet oddly enough, when I toggle the 'r' key on miniplayer, both windows indicate a message telling me repeat mode is active.
Not sure if this is a bug or a faulty configuration on my end, but I can't seem to narrow it down if it is the latter case.

This is a bug. Apparently MPDClient.status() returns a dictionary where all the values are strings not integers like I thought. This results in the repeat state to be initialized as true whether or not it is actually enabled.
In regards to the ncmpcpp thing, that is just lazy programing on my part. The repeat state is not checked/updated after miniplayer is launched unless the user issues the "repeat" keyboard command.
I will take a look at both these issues sometime next week when I'm off my vacation.


Use () instead of {} in ContractDeploymentData struct initalization to ensure all zeros

Description
Use () instead of {} in ContractDeploymentData struct initalization to ensure all zeros
Checklist:

[x] I have reviewed my diff in github, line by line.
[x] Every change is related to the PR description.
[x] I have linked this pull request to the issue(s) that it resolves.
[x] There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
[x] There are no circuit changes, OR specifications in /specs have been updated.
[x] There are no circuit changes, OR a cryptographer has been assigned for review.
[x] I've updated any terraform that needs updating (e.g. environment variables) for deployment.
[x] The branch has been rebased against the head of its merge target.
[x] I'm happy for the PR to be merged at the reviewer's next convenience.
[x] New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
[x] If existing code has been modified, such documentation has been added or updated.

Note
If you are updating the submodule, please make sure you do it in its own special PR and avoid making changes to the submodule as a part of other PRs.
 We've had prod problems in the past only because of some initialisation didn't correctly initiate everything to "0". So this is great. We should also make this fix in other places (if there are any).


vscode extension incorrectly autocomplete<EMAIL_ADDRESS>

When writing for a class in vscode using @, and accepting an autocomplete suggestion regarding class members vscode adds the redundant this. making the expression into an error.

I spent some time looking at why this happens. I notice two things:

connection.onCompletion gets called with the transpiled code with this in it, but no characters after (no .so). I believe there are a couple of reasons:

Our delayed scheduling of transpilation updates. Adding await executeQueue() seems to fix this.
The LSP model encourages clients to filter the original completion list instead of recomputing. I think this is only an issue when adding @ as a trigger key, which I was also testing. This can be fixed by returning { items: convertCompletions(completions), isIncomplete: true }.
So I think I can fix this issue, except:

The source mapping places the cursor at the position between h and i in this.s, so TS gives the wrong completion.

So ultimately this seems to be a source mapping issue.  I'm not quite sure how to debug this part.


Turn off "shine" in 2D?

I'm wondering how to turn-off the shine in 2D? It looks pretty, but probably not appropriate for publications.

shading = false


op requires element_shape to be static during TF Lite transformation pass :0: note: loc("StatefulPartitionedCall")

1. System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Macbook Pro
TensorFlow installation (pip package or built from source): pip package
TensorFlow library (version, if pip package or github SHA, if built from source):  version 2.7.0

2. Code
`from tensorflow import lite
converter = lite.TFLiteConverter.from_keras_model(h_model)
tfmodel = converter.convert()
open('model.tflite', 'wb').write(tfmodel)`
3. Failure after conversion
ConverterError: /Users/shahadsulaiman/opt/anaconda3/lib/python3.8/site-packages/tensorflow/python/saved_model/save.py:1315:0: error: 'tf.TensorListReserve' op requires element_shape to be static during TF Lite transformation pass
:0: note: loc("StatefulPartitionedCall"): called from
/Users/shahadsulaiman/opt/anaconda3/lib/python3.8/site-packages/tensorflow/python/saved_model/save.py:1315:0: error: failed to legalize operation 'tf.TensorListReserve' that was explicitly marked illegal
:0: note: loc("StatefulPartitionedCall"): called from
:0: error: Lowering tensor list ops is failed. Please consider using Select TF ops and disabling _experimental_lower_tensor_list_ops flag in the TFLite converter object. For example, converter.target_spec.supported_ops = [tf.lite.OpsSet.TFLITE_BUILTINS, tf.lite.OpsSet.SELECT_TF_OPS]\n converter._experimental_lower_tensor_list_ops = False
4. (optional) RNN conversion support
`
inputs1 = Input(shape=(2048,))
fe1 = Dropout(0.5)(inputs1)
fe2 = Dense(256, activation='relu')(fe1)
inputs2 = Input(shape=(max_length,))
se1 = Embedding(vocab_size, embedding_dim, mask_zero=True)(inputs2)
se2 = Dropout(0.5)(se1)
se3 = LSTM(256)(se2)
decoder1 = add([fe2, se3])
decoder2 = Dense(256, activation='relu')(decoder1)
outputs = Dense(vocab_size, activation='softmax')(decoder2)
h_model = Model(inputs=[inputs1, inputs2], outputs=outputs)`

excuse me did you solve it

excuse me did you solve it

Yes, by the following code >
`from tensorflow import lite
converter = lite.TFLiteConverter.from_keras_model(model_new)
converter.optimizations = [tf.lite.Optimize.DEFAULT]
converter.experimental_new_converter=True
converter.target_spec.supported_ops = [tf.lite.OpsSet.TFLITE_BUILTINS,
tf.lite.OpsSet.SELECT_TF_OPS]
tfmodel = converter.convert()
open('image_model.tflite', 'wb').write(tfmodel)
`

Thanks a lot. It works for me.


Title: Captcha Code Generator

@irshadmd, I want to add a Web App of Captcha Generation which is very useful logic for verification purposes.
Please assign this issue to me.
Consider this issue under hacktoberfest 2022 and please add tags related to it.

Go ahead 🚀


Add proxy support

What this PR does / why we need it:
This PR adds support for custom http proxies & custom image registries.
Both flags can be used independently.
The PR has been manually tested with CoreOS & Ubuntu - We don't have a test env for CentOS atm.
Add support for custom http proxies & images registries

/assign @alvaroaleman

Is there no image available w/o the architecture hardcoding? gcr does support the manifests at least.

According to the Makefile no.
Also that should not be scope of this PR as it does not change anything on that side.

@thz @alvaroaleman PTAL

/lgtm
/approve
/hold
in case @thz wants to have a look

/hold cancel


After training dreambooth once and testing in webui i cant train again when i stop webui

What i must do to train again immediately ? It wont run and errors out. You can easily try it by training for 100 steps and then trying to train again with same settings
by the way how i can control training repeat rate with your colab ?

Specify shat type of error, do a screenshot or paste the log

Here it is , closed webui, wanted to train on new images
The following values were not passed to accelerate launch and had defaults used instead: 	--num_processeswas set to a value of1 --num_machineswas set to a value of1 --mixed_precisionwas set to a value of'no' --num_cpu_threads_per_processwas set to1to improve out-of-box performance To avoid this warning pass in values for each of the problematic parameters or runaccelerate config`.
Traceback (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/transformers/configuration_utils.py", line 609, in _get_config_dict
user_agent=user_agent,
File "/usr/local/lib/python3.7/dist-packages/transformers/utils/hub.py", line 297, in cached_path
raise EnvironmentError(f"file {url_or_filename} not found")
OSError: file /content/stable-diffusion-v1-4/config.json not found
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/content/diffusers/examples/dreambooth/train_dreambooth.py", line 606, in
main()
File "/content/diffusers/examples/dreambooth/train_dreambooth.py", line 398, in main
args.pretrained_model_name_or_path, subfolder="text_encoder", use_auth_token=args.use_auth_token
File "/usr/local/lib/python3.7/dist-packages/transformers/modeling_utils.py", line 1776, in from_pretrained
**kwargs,
File "/usr/local/lib/python3.7/dist-packages/transformers/models/clip/configuration_clip.py", line 126, in from_pretrained
config_dict, kwargs = cls.get_config_dict(pretrained_model_name_or_path, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/transformers/configuration_utils.py", line 553, in get_config_dict
config_dict, kwargs = cls._get_config_dict(pretrained_model_name_or_path, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/transformers/configuration_utils.py", line 642, in _get_config_dict
f"Can't load config for '{pretrained_model_name_or_path}'. If you were trying to load it from "
OSError: Can't load config for '/content/stable-diffusion-v1-4'. If you were trying to load it from 'https://huggingface.co/models', make sure you don't have a local directory with the same name. Otherwise, make sure '/content/stable-diffusion-v1-4' is the correct path to a directory containing a config.json file
Traceback (most recent call last):
File "/usr/local/bin/accelerate", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.7/dist-packages/accelerate/commands/accelerate_cli.py", line 43, in main
args.func(args)
File "/usr/local/lib/python3.7/dist-packages/accelerate/commands/launch.py", line 837, in launch_command
simple_launcher(args)
File "/usr/local/lib/python3.7/dist-packages/accelerate/commands/launch.py", line 354, in simple_launcher
raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python3', '/content/diffusers/examples/dreambooth/train_dreambooth.py', '--pretrained_model_name_or_path=/content/stable-diffusion-v1-4', '--instance_data_dir=/content/data/tmnt', '--output_dir=/content/models/tmnt', '--instance_prompt=photo of tmnt', '--seed=11111', '--resolution=512', '--mixed_precision=fp16', '--train_batch_size=1', '--gradient_accumulation_steps=1', '--use_8bit_adam', '--learning_rate=5e-6', '--lr_scheduler=constant', '--lr_warmup_steps=0', '--max_train_steps=1800']' returned non-zero exit status 1.
Something went wrong`

I'll check that out shortly

fixed, update the colab and confirm

works! Thanks for fix


Missing release script

I was looking for your release script for reference, but all there is is a devDependency for atom-shell-installer-assets. You probably have a script using squirrel, that I was interested on.
Maybe you wont open source it, but why?

@chrisdias please chime in

Actually, thanks for this. We no longer use that package, since we moved to Inno Setup.

+1 for open sourcing the packaging scripts for all platforms.
Open sourcing the code for incremental build and debug of a Typescript Electron apps is awesome. It would be equally great to see which way you decided to do release builds!

Maybe this was made clear somewhere I just failed to find in my searching, but how do I build the OS X app/distribution from source? All I can figure out how to do from the docs is launch a generic Electron instance using scripts/code.sh.
Semi related, I see a lot of references to an alpha version of the app. Is that public? Where can I find more details about it?
cc @lukehoban

Just found https://github.com/Microsoft/vscode/issues/3793

@chrisdias ping

I play on writing up on packaging in vscode in June, closing in favor of https://github.com/Microsoft/vscode/issues/6893


Some method for specifying npm install system dependencies

eg using a native module which requires dbus requires that dbus is installed in the environment in order for npm ci to work

https://github.com/product-os/flowzone/pull/203
... look for package.txt and pipe it to apt-get install -y

@pipex @cywang117 @Page- do we still need this or is this adequate?

@ab77 The preinstall script for the Supervisor specifically works. The case may be different for repos that use Flowzone in general though. @klutchell has a vision for Flowzone last time I opened an issue here so I'm curious what he thinks.

I like @ab77's solution in #203 but it's even better if we don't need it. As far as I can tell, npm is the only project type that might require a pre-install of some kind and it already supports it natively via package.json?
I would think that docker(-compose) and balena packages would never have local dependencies. So maybe we shelf the package.txt solution until we find a need for it?

npm is the only project type

If we support Python, there may be system dependencies as well prior to running pip install -r ...

This can be handled by #216 using a flowzone-preinstall script in package.json

For reference a standard preinstall script does not work on npm 7+ because the preinstall script happens after dependencies are installed, which kind of scuppers things if the dependency is what requires the native module


Delisting ordinal inscriptions reveals uninscribed BTC

Perhaps this is caused by an API issue.
The users sees this:

One output shows an ordinal
https://ordinals-explorer.generative.xyz/output/870a65f88ad97abda08861122f1f4d6aa81703659edc098806cb52324e2fa086:2
The other output shows no ordinal
https://ordinals-explorer.generative.xyz/output/870a65f88ad97abda08861122f1f4d6aa81703659edc098806cb52324e2fa086:3
After unlisting some ordinals, more uninscribed UTXO's are displayed

Some of the inscriptions are showing three times.

While on another explorer this is shown for the same address: bc1pxtet4fqgm3mlw3f87322eqslmkwjkmujpsl2fps7j08gue6kd4lsyw6vjn

Restoring the wallet from seed (and clearing cache in the process) did change what is displayed in the wallet but it is still showing a specific inscription multiple times:

Investigating. @314159265359879 what do you mean by unlisted?

I think the user meant invalidating a prior PSBT's.
Although with hz' input I am not so sure that had anything to do with it. These two transactions seem to have been misinterpreted (showing uninscribed sats on both outputs while :2 in both cases held/holds an inscription).

https://mempool.space/address/bc1pxtet4fqgm3mlw3f87322eqslmkwjkmujpsl2fps7j08gue6kd4lsyw6vjn
The user believes: that was probably the "mint", or sale, of the inscription on https://www.twelvefrog.com/

To get the uninscribed sats out of the wallet the user used the following workaround:
Using sparrow wallet to freeze all the utxos that have ordinal inscriptions in them and then sending the rest out.

@314159265359879 can you QA the changes in https://github.com/hirosystems/wallet/pull/3519 ?
I think this might address the duplicate displaying of inscriptions (and them moving around in order), but I'm not 100% sure on the inaccurate check for non-inscribed TR utxos. While the initial check may be wrong, it's built with an additional double check of all UTXOs against a HTML explorer.
https://github.com/hirosystems/wallet/blob/089001662a120fd9b03c43a86000fccf9e688bef/src/app/features/retrieve-taproot-to-native-segwit/use-generate-retrieve-taproot-funds-tx.tsx#L51-L58
So it's likely users would've been stopped from actually being able to broadcast the tx.

Closing this for now as I believe it was an API glitch. Please reopen if you hear reports of this again @314159265359879


Score IDs might not be present in recent scores

Per https://github.com/ppy/osu-api/wiki it does not look like recent scores have IDs with them.
[{
    "beatmap_id"   : "987654",
    "score"        : "1234567",
    "maxcombo"     : "421",
    "count50"      : "10",
    "count100"     : "50",
    "count300"     : "300",
    "countmiss"    : "1",
    "countkatu"    : "10",
    "countgeki"    : "50",
    "perfect"      : "0",          // 1 = maximum combo of map reached, 0 otherwise
    "enabled_mods" : "76",         // bitwise flag representation of mods used. see reference
    "user_id"      : "1",
    "date"         : "2013-06-22 9:11:16", // in UTC
    "rank"         : "SH"
}, { ... }, ...]```

Also please target the branch feature/api-v1

I'm going to merge whenever I have a computer with me to push a new version in nuget (I should probably automatically push from the ci...)
Thank you!


Prompt to save changes on exit

I've lost work several times by forgetting to save before exiting.  It would be nice if AsciidocFX prompted to save unsaved work or at least warn when there are unsaved work before exiting.

We are thinking to implement it in further release.

This was implemented and will be available in 1.3.4 release.

Great work, but I noticed that it only works when you close a tab and not when you close the application itself.  Is there any chance you could add the same prompt when you try to close the application?

Yes it can be. That didnt fall in my mind :)


Incorrect date format pattern in DateGen

Describe the bug
https://github.com/apache/drill/blob/138563a55141b8844c99f5853894b1e63fcf9582/exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/DateGen.java#L47

m is 'minute in hour'; should probably be M
D is 'day in year'; should probably be d

To Reproduce
Date date = Date.from(Instant.parse("2024-10-26T22:00:00Z"));
// Bug: Prints "2024-00-301"
new SimpleDateFormat("yyyy-mm-DD").format(date);

Drill version
master (138563a55141b8844c99f5853894b1e63fcf9582)

ayyyy-MM-dda seems more correct alright - do you want to do a PR?

I am not sure if that could break something, in case parts of this project rely on this incorrect format. Or if DateGen is even used at all.
If possible, could you or some of the other maintainers fix it instead?
(It is not urgent for me though; I am not using the DateGen class, but just stumbled upon this issue in its source code.)


Consider "ConsentCookie" ?

In the default UI - similar to 2FA "Trust this browser"

I think the best/easiest place to implement this would be as a custom IPersistedGrantService with StoreUserConsentAsync and GetUserConsentAsync checking the DB as well as a cookie.

Yes, it's now possible.


Benchmark result of Ednet

Can you share the benchmark results of your experiments with the ednet dataset?
Still need to develop the data processing part for ednet experiments?

Can you share the benchmark results of your experiments with the ednet dataset? �Still need to develop the data processing part for ednet experiments?

Hi, thank you for your attention to our work. Exactly, we are running the experiments on ednet. The results would be provided as soon as possible. The data preprocessing of ednet has been released on ednet_preprocess.py.


Is there any pre-trained model?

Am studying Alexnet + BD-LSTM with your code!
in your code loaded pre-trained model with model.load_state_dict(torch.load("./data/crnn.pth")) that is not on Github
can i get it? or where can i get it?

Unfortunately, I did not made one.

알려주셔서 감사합니다!


fix external link check

fix #443

Codecov Report
Base: 65.11% // Head: 65.06% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (a78e3cd) compared to base (b157da8).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   65.11%   65.06%   -0.05%
==========================================
  Files          27       27
  Lines        1416     1417       +1
==========================================
  Hits          922      922
- Misses        494      495       +1

Impacted Files
Coverage Δ

contracts/sg721-base/src/contract.rs
51.95% <50.00%> (-0.30%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


importing serviceAccount results in serviceaccount and does not recognize as a serviceAccount

What happened?
When importing from a terraform state file, a GCP serviceAccount resource will try to import as a serviceaccount resource. This is just a casing difference but enough to cause it to be recognized as a different type of resource. As a result, it will try to delete the imported serviceaccount resource and create a serviceAccount resource. Please see the example below for excerpts from my use case.
Modifying the state file manually and importing the stack fixes the problem.
Example

pulumi import --from terraform terraform.tfstate
This creates a pulumi import file that I rename to pulumi-import.json
pulumi import --file pulumi-import.json --protect=false

     Type                                          Name                                          Plan       Info
 +   pulumi:pulumi:Stack                           gcp-bar-dev                                   create
...
 =   ├─ gcp:serviceaccount:Account                 gke                                           import
...

Select yes:

     Type                                          Name                                          Status               Info
 +   pulumi:pulumi:Stack                           gcp-forge-exp0-dev                            created (13s)
...
 =   ├─ gcp:serviceaccount:Account                 gke                                           imported (2s)
...

pulumi preview --show-sames
     Type                                          Name                                          Plan        Info
     pulumi:pulumi:Stack                           gcp-bar-dev                                          1 message
 +   ├─ components:index:Resources                 fooShape                                      create
 +   ├─ mynode:gcp:MyNode                          bar                                           create
...
 +   ├─ mynode:gcp:MyNodeGCP                       foo                                           create
 +   │  ├─ mynode:gcp:Network                      network                                       create
...
 +   │  ├─ mynode:gcp:Auth                         auth                                          create
...
 +   │  │  ├─ gcp:serviceAccount:Account           gke                                           create
...
 -   ├─ gcp:serviceaccount:Account                 gke                                           delete

pulumi stack export --file state.json
make the following changes:

find    gcp:serviceaccount/account:Account
replace gcp:serviceAccount/account:Account

pulumi stack import --file state.json
then you can check to see if your changes worked
pulumi preview --show-sames

     Type                                          Name                                          Plan       Info
     pulumi:pulumi:Stack                           gcp-bar-dev                                       1 message
 +   ├─ components:index:Resources                 fooShape                                      create
 +   ├─ mynode:gcp:MyNode                          bar                                           create
...
 +   ├─ mynode:gcp:MyNodeGCP                       foo                                           create
 +   │  ├─ mynode:gcp:Network                      network                                       create
 +   │  ├─ mynode:gcp:Auth                         auth                                          create
     │  │  ├─ gcp:serviceAccount:Account           gke                                                      [diff: +disabled-project~__defaults,provider]

As you can see, after manually fixing the casing error, it recognizes as the same resouce.
Output of pulumi about
Output of pulumi about
CLI
Version 3.99.0
Go Version go1.21.5
Go Compiler gc

Plugins
NAME VERSION
gcp 7.2.1
kubernetes 4.5.4
nodejs unknown
random 4.14.0
std 1.4.0
time 0.0.16

Host
OS darwin
Version 14.2.1
Arch arm64

This project is written in nodejs: executable='/usr/local/bin/node' version='v18.18.0'

...
Found no pending operations associated with dev

Backend
Name pulumi.com
URL https://app.pulumi.com/GeoffMillerAZ
User GeoffMillerAZ
Organizations GeoffMillerAZ
Token type personal

Dependencies:
NAME VERSION
@pulumiverse/time 0.0.16
@types/node 14.18.63
typescript 4.9.5
@pulumi/gcp 7.2.1
@pulumi/kubernetes 4.5.4
@pulumi/pulumi 3.95.0
@pulumi/random 4.14.0
@pulumi/std 1.4.0

Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

related/similar? #922

Hi @GeoffMillerAZ. Thanks for opening the issue. I think the current import behavior is correct vis a vis the imported resource, since gcp:serviceAccount/account:Account is an old alias for gcp:serviceaccount/account:Account. Is it possible that mynode:gcp:Auth is using an old version of pulumi-gcp?
If so, my guess is that the pulumi import is using the wrong version of pulumi-gcp to derive names.

Hi @GeoffMillerAZ. Thanks for opening the issue. I think the current import behavior is correct vis a vis the imported resource, since gcp:serviceAccount/account:Account is an old alias for gcp:serviceaccount/account:Account. Is it possible that mynode:gcp:Auth is using an old version of pulumi-gcp?
If so, my guess is that the pulumi import is using the wrong version of pulumi-gcp to derive names.

How old of a version are we talking about would make the difference? I have version @pulumi/gcp 6.66.0. That was the latest version when I coded this component in September, so it's not that old. I've destroyed everything and put this aside, but I can stand it all back up and test with the latest versions.

Updating appears to be working now. thanks!


feat: added hOCR exporter

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

In the description for this PR, (and the inline documentation) can you add context as to what hOCR is and how it's being used?

In the description for this PR, (and the inline documentation) can you add context as to what hOCR is and how it's being used?

Yes, will do this is just a draft to help finalize the design doc but when i make this not a draft i'll add the context.


Implement verbose mode

Implement -v/--verbose option.
WarShield needs to have less informations by default than now and a verbose mode to display every information.
Expected behavior without verbose:
Scanning files... Done!
Encrypting files... Done!
Elapsed time: 16.27s
Total encrypted files: 1653
Failed: 3 (read-only files)

Expected behavior with verbose:
Added file /etc/nginx/conf.d
Added file /etc/nginx/fastcgi.conf
Added file /etc/nginx/sites-available/default
Added file /etc/nginx/sites-enabled/default
Done encrypting file /etc/nginx/conf.d
Done encrypting /etc/nginx/fastcgi.conf
Done encrypting /etc/nginx/sites-available/default
Done encrypting /etc/nginx/sites-enabled/default
Finished encrypting files!
Elapsed time: 0.76s
Total encrypted files: 4
Failed: 0 (read-only files)

Hi, I want to pick this up. Is it available? I have not worked with CLI. It’s my first attempt. Can you provide info to get me going?

I just finished verbose option but if you want you can take #2 😃

@masihtamsoy I just finished verbose option but if you want you can take #2 😃


Google Speaker Group - TTS issues

What version of Music Assistant has the issue?
2022.7 BETA 3
The problem
All media players mentioned are mass media players.

When streaming on a Google speaker group and a tts message is played on another Google speaker group that contains members of the media group, the tts message plays but the media stream does not resume when tts has completed.

When streaming on a Google speaker group and a tts message is played a single media group member the tts message plays on all group members.

When streaming on a single Google speaker and a tts message is played on a Google speaker group that contains the media stream player, the media stream does not resume after tts.

How to reproduce
Play media and TTS calls as described above.
Relevant log output
None.
Additional information
No response
What version of Home Assistant Core are your running
2022.7.2
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
ODROID

Just tested it and I can confirm the TTS/announce is flaky, especially with cast groups somehow. I think this relates to the recent buffer changes. I will have a look.

Can you please check if this is fixed in the 2022.7 beta 4 ?

This is intended behavior. If the group is playing, that is the active "queue" and you can't send direct commands to the childs without first stopping the group.

Can you please check if this is fixed in the 2022.7 beta 4 ?

@jazzyisj
Since 2022.7b7, TTS seems to work robust for the simple use cases. Please verify yours if you have time before we come this issue. Best Eric

Oh shoot sorry guys!  Missed this somehow.
This still doesn't seem to be resolved for me.  Updated v2022.7b7, HASS is v2022.7.5
2022-07-16 16:13:02 WARNING (MainThread) [homeassistant.helpers.entity] Update of binary_sensor.wan_connected is taking over 10 seconds
2022-07-16 16:13:04 WARNING (SyncWorker_32) [pychromecast.controllers] Quick Play failed for http://<IP_ADDRESS>:8095/219b5510b0ce424a937017effb451a42.flac:audio/flac({'enqueue': False, 'stream_type': 'LIVE', 'title': ' Streaming from Music Assistant'})
2022-07-16 16:13:07 WARNING (MainThread) [homeassistant.components.media_player] Updating webostv media_player took longer than the scheduled update interval 0:00:10
2022-07-16 16:13:07 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/music_assistant/models/player_queue.py", line 451, in resume
    await self.play_index(resume_item.item_id, resume_pos, fade_in)
  File "/usr/local/lib/python3.10/site-packages/music_assistant/models/player_queue.py", line 526, in play_index
    await self.player.play_url(stream.url)
  File "/config/custom_components/mass/player_controls.py", line 525, in play_url
    await self.hass.async_add_executor_job(
  File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.10/site-packages/pychromecast/quick_play.py", line 77, in quick_play
    controller.quick_play(**data)
  File "/usr/local/lib/python3.10/site-packages/pychromecast/controllers/media.py", line 547, in quick_play
    raise PyChromecastError()
pychromecast.error.PyChromecastError
2022-07-16 16:13:08 WARNING (MainThread) [music_assistant.players.stream] Abort: client(s) did not connect within 10 seconds.

Playing on a single cast speaker, then TTS on google group speaker - no resume.
2022-07-16 16:16:27 ERROR (MainThread) [music_assistant.players] Error while playing announcement
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/music_assistant/models/player_queue.py", line 365, in play_announcement
    await self._wait_for_state(PlayerState.PLAYING, silence_item.item_id)
  File "/usr/local/lib/python3.10/site-packages/music_assistant/models/player_queue.py", line 867, in _wait_for_state
    raise TimeoutError(f"Timeout while waiting on state(s) {state}")
TimeoutError: Timeout while waiting on state(s) (,)
2022-07-16 16:17:05 WARNING (SyncWorker_21) [pychromecast.controllers] Quick Play failed for http://<IP_ADDRESS>:8095/880f698a310f46588e9c3a3a8f66874e.flac:audio/flac({'enqueue': False, 'stream_type': 'LIVE', 'title': ' Streaming from Music Assistant'})
2022-07-16 16:17:05 WARNING (MainThread) [music_assistant.players.stream] Abort: client(s) did not connect within 10 seconds.
2022-07-16 16:17:05 ERROR (MainThread) [homeassistant.core] Error executing service: <ServiceCall media_player.play_media (c:01G84AG81V11CYJW4KZF5GBNSS): entity_id=['media_player.mass_dining_room_hub'], extra=, media_type=audio/flac, media_id=media-source://mass/database://playlist/31>
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/core.py", line 1731, in catch_exceptions
    await coro_or_task
  File "/usr/src/homeassistant/homeassistant/core.py", line 1750, in _execute_service
    await cast(Callable[[ServiceCall], Awaitable[None]], handler.job.target)(
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 204, in handle_service
    await service.entity_service_call(
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 680, in entity_service_call
    future.result()  # pop exception if have
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 930, in async_request_call
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 717, in _handle_entity_call
    await result
  File "/config/custom_components/mass/media_player.py", line 427, in async_play_media
    await self.player.active_queue.play_media(media_id, queue_opt)
  File "/usr/local/lib/python3.10/site-packages/music_assistant/models/player_queue.py", line 272, in play_media
    await self.load(queue_items, passive)
  File "/usr/local/lib/python3.10/site-packages/music_assistant/models/player_queue.py", line 568, in load
    await self.play_index(0, passive=passive)
  File "/usr/local/lib/python3.10/site-packages/music_assistant/models/player_queue.py", line 526, in play_index
    await self.player.play_url(stream.url)
  File "/config/custom_components/mass/player_controls.py", line 525, in play_url
    await self.hass.async_add_executor_job(
  File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.10/site-packages/pychromecast/quick_play.py", line 77, in quick_play
    controller.quick_play(**data)
  File "/usr/local/lib/python3.10/site-packages/pychromecast/controllers/media.py", line 547, in quick_play
    raise PyChromecastError()
pychromecast.error.PyChromecastError
2022-07-16 16:17:41 WARNING (SyncWorker_24) [pychromecast.controllers] Quick Play failed for http://<IP_ADDRESS>:8095/f50aba92e80b4146bf1d4eb741665c6d.flac:audio/flac({'enqueue': False, 'stream_type': 'LIVE', 'title': ' Streaming from Music Assistant'})
2022-07-16 16:17:43 WARNING (MainThread) [music_assistant.players.stream] Abort: client(s) did not connect within 10 seconds.

@jazzyisj : thanks for your additional info! Marcel included this issue on the ambition list for the next official release 2022.7.0

I can't reproduce any of this with current version (2022.7 beta 10) so I'm assuming/hoping it is fixed.

Please reopen (or create a new issue) if you still may experience issues. Thanks!


Remove duplicate materials, techniques, programs and shaders

From the roadmap #1.
@lilleyse, could you look at this when you get a chance?

That's all my comments. Looks good @lasalvavida.

Are we sure this needs to be as verbosely coded as it is?  For example, see how removeUnused is implemented.

Updated. This is now merged with the new API and includes doc and is scoped more in line with the way RemoveUnusedProperties is done. name and extras are ignored on property comparison. I've elected to keep the name schema the same, but to make removing after merging not part of this function's contract. removeAllUnused is run after this stage in the main pipeline instead.

Updated. Unless anybody has anything else, this should be ready to merge

@lilleyse could you look at this when you get a chance?

Looks good to me. Are there any glTF models that I can test with?

You can test with the VirtualCity glTF sample model. For vertex shaders, VC2VS is a duplicate of VC0VC, VC5VS is a duplicate of VC3VS, and VC6VS is a duplicate of VC0VS. For materials, Vmtl06 is a duplicate of Vmtl105, and Vmtl08 is a duplicate of Vmtl03.

Looks good!


Better user-facing compile-time errors using #[diagnostic]

What problem does this solve or what need does it fill?
Currently, due to the heavy use of all_tuples (Bundling up generic types in tuples) in traits like Bundle, SystemParam, IntoSystemConfig, user-facing compile time errors can get very messy and uninformative.
For example (the actual problem was caused when forgetting to implement Component for some type):

But it's gonna be very hard for inexperienced users to understand what the problem is, and how to fix it.
What solution would you like?
Version 1.78 introduced #[diagnostic] attributes. We can use #[diagnostic::on_unimplemented] to make those errors more informative and readable.

Duplicate of https://github.com/bevyengine/bevy/issues/12377 :) Strongly desired though!


Ping_connection and much more

Fixed: filter for objects with no children rows (missing test)  (e02de47)

Added: lookup .filter(...__not_in=subquery)' and 'not_eq',
because of unsupported .exclude(...__in=subquery).  (988110c, 9dfb2de)

Added: command ping_connection that automatic called after every
longer inactivity to minimize timeouts. Fixed #174  (92fb900, 0117367)

Fixed: makemigrations works now also without db_table name e.g. for
simple standard objects.  (62245e5)

Fixed: bug .using('salesforce') in default database queryset.  (dd00e5e)

Added: salesforce.models_extend module with SalesforceModel with
varchar primary key that works also with default databases.
Fixed methods for it: save() and bulk_create() to can create a new
pk or to copy an object exactly. Fixed #231 (4d042e5, 79603b7)

Fixed: test setUpClass to can run tests on an empty Salesforce database.  (95ead69)

@hynekcer that's a false failure in the Travis tests because of some kind of issue with migrations or something. I'm not really sure what to do to clear it, though...

Hmm, a configurable SF_PK requires to use a corresponding migration. I removed the concrete migration and wrote a makemigrations command instead.
By the way, it can't be fixed by adding a new migration because:

Renaming the 'id' column while in a transaction is not supported on SQLite < 3.26 because it would break referential integrity. Try adding atomic = False to the Migration class.

That did the trick. Everything looks good to me now.


organize and publish repo

oh and this one:

Originally posted by @NidhiVinod in https://github.com/EcoClimLab/vertical-thermal-review/issues/125#issuecomment-1235820487
Moving this to a separate issue.

Here it is: https://zenodo.org/record/7050583#.YxXpkyHML7E


Unable to see any Non-Organic installs

Hi,
Have integrated SDK, made the app on appsflyer, and have tried it with 9Apps Channel for non-organic installs, but unable to see any of them.
Please help

It appears like the react-native SDK does not include the Broadcast receiver needed to track this.
The broadcast receiver should be in the libraries manifest by default, so react native developers don't have to manually add it. At the very least, it should be included in this repo's documentation on how to hook it up manually if its not included.
<receiver android:name="com.appsflyer.SingleInstallBroadcastReceiver" android:exported="true">
    <intent-filter>
         <action android:name="com.android.vending.INSTALL_REFERRER" />
     </intent-filter>
</receiver>

Hi @chris-feist, the react-native plugin uses [Google install referrer ] by default (https://github.com/AppsFlyerSDK/react-native-appsflyer/blob/master/android/build.gradle#L32)
So you don't need to implement com.android.vending.INSTALL_REFERRER receiver.


urllib3.exceptions.SSLError: Can't connect to HTTPS URL because the SSL module is not available

Centos7 报错  pythonm3.5
Traceback (most recent call last):
File "/usr/local/python3/lib/python3.6/site-packages/urllib3/connectionpool.py", line 589, in urlopen
conn = self._get_conn(timeout=pool_timeout)
File "/usr/local/python3/lib/python3.6/site-packages/urllib3/connectionpool.py", line 251, in _get_conn
return conn or self._new_conn()
File "/usr/local/python3/lib/python3.6/site-packages/urllib3/connectionpool.py", line 827, in _new_conn
raise SSLError("Can't connect to HTTPS URL because the SSL "
urllib3.exceptions.SSLError: Can't connect to HTTPS URL because the SSL module is not available.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/python3/lib/python3.6/site-packages/requests/adapters.py", line 440, in send
timeout=timeout
File "/usr/local/python3/lib/python3.6/site-packages/urllib3/connectionpool.py", line 639, in urlopen
_stacktrace=sys.exc_info()[2])
File "/usr/local/python3/lib/python3.6/site-packages/urllib3/util/retry.py", line 388, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='login.weixin.qq.com', port=443): Max retries exceeded with url: / (Caused by SSLError("Can't connect to HTTPS URL because the SSL module is not available.",))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/python3/lib/python3.6/site-packages/itchat/utils.py", line 125, in test_connect
r = requests.get(config.BASE_URL)
File "/usr/local/python3/lib/python3.6/site-packages/requests/api.py", line 72, in get
return request('get', url, params=params, **kwargs)
File "/usr/local/python3/lib/python3.6/site-packages/requests/api.py", line 58, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/python3/lib/python3.6/site-packages/requests/sessions.py", line 508, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/python3/lib/python3.6/site-packages/requests/sessions.py", line 618, in send
r = adapter.send(request, **kwargs)
File "/usr/local/python3/lib/python3.6/site-packages/requests/adapters.py", line 506, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='login.weixin.qq.com', port=443): Max retries exceeded with url: / (Caused by SSLError("Can't connect to HTTPS URL because the SSL module is not available.",))
You can't get access to internet or wechat domain, so exit.

the code is not compatible with python 3

reopened. I forgot that @Bestoa wrote a Python 3 version.


Archetype model value override

fix #879

There is a minor impact on current archetype v2. It concern database and the fix is straightforward.

Yes it will...


Add runtime type check for 'await' in DDC

This is a DDC part of https://github.com/dart-lang/sdk/issues/49396.
According to the spec, await e should check runtime type of e to be a Future<flatten(S)> where S is a static type of e before waiting for e (otherwise it should wait for Future.value(e)). See https://github.com/dart-lang/sdk/issues/49396 for details.
Kernel AST contains the type to check in AwaitExpression.runtimeCheckType.
@sigmundch @nshahan

Tests landed but contain unexpected compile time errors. It sounds like these should not be errors. Waiting on CFE work to accept the code in the test.

You can also use language/async/await_type_check_test which was landed in 66f1dee48cee1fe06699fb62d45f79d92f440293 until those compile-time errors are sorted out.

@alexmarkov and @nshahan, the definition of flatten turned out to be too aggressive (causing gratuitous loss of type information), so it was adjusted, cf. https://github.com/dart-lang/sdk/issues/49396#issuecomment-1344174457. Sorry about the inconvenience this may cause!


Connectivity working but not as expected.

Connectivity working but not as expected.
I installed Xamarin Essentials 1.01.  When testing the Connectivity I am finding the following.
When I switch to Airplane mode it will display local.  If check the status again it will show none.
If i put a 1 sec sleep at the top of the connectivity changed it works correctly. It looks like when I go into airplane mode the phone makes two changes.  It will go from internet to local and then local to none once airplane mode is turned on.  The first change to locaI is triggering a connectivity change so I see local, but the second change to none doesn't trigger the event again so even though its none I am not getting that response unless I recheck the values.  Am I doing something wrong or is the delay the only solutions?
private void Connectivity_ConnectivityChanged(object sender, ConnectivityChangedEventArgs e)
{
System.Threading.Thread.Sleep(1000);
Device is Galaxy s9+ android.

Thanks for your feedback @Swdvader. This sounds like a product issue, which you can raise by clicking Product feedback at the end of the Connectivity doc.


git pull from github.com directly? is this possible?

Feature Description
can git pull from github as backup repo
Screenshots
No response

Yes. Mirror repos can pull periodically from GitHub, but you can also do a one time migration from GitHub


Autonomous doesn't switch to Teleop?

After we run a command group in autonomous, we end up not being able to start our teleop commands unless we run killAllCommands in teleopInit(). What could be causing this, and what is the correct solution (if not killAllCommands)?

 Ideally, your command should finish naturally, but there's no harm in killing them. Another option is to call Strongback.restart() in teleopInit(), which kills commands and cleans up a few other things. Either way works.
IOW, this is not an issue with Strongback, but could bean issue with your particular commands.


Update training for exposure on site

Show only relevant modules in sidenav
Update training homepage
Add v2.0 pages

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/be4276daa30243488734dbcb13ce1d0842b2399f/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/6fedaace8c49a58513c7660cd5ac5cd8cb72536a/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a0e51abe1a1465fc9202b9a0adb280ce65472284/

Thanks, @jseldess ! Dropdown LGTM, we will drop the "events" from "Resources" very soon, so that will make the dropdown feels less crowded.

We talked about how the training nav on mobile isn't exposed properly. Are we going to try to fix that?
On the new training home, given the proximity of the Tips box to the feedback box, and the length of text on the page. I suggest to remove the styling for "tips" and make the copy standard body style instead. The appearance and the position of the Tips feel a bit jarring.

@jseldess per @kuanluo we're removing Events from the header under Resources too in the hugo-website PR  Would you be able to remove that on this PR?

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e4f1a85ccd1812f4bf543d186bda4c2414cc9bfb/

Please take another look, @kuanluo.
@j-low, I don't know how to fix the mobile nav problem @kuanluo has identified. When you're on the training home page on mobile, the docs menu doesn't show any of the other training sections. Would be great to get your help with that.

LGTM. Thank you, @jseldess !

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/883100d787c594174a84996881e48068b37ea825/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a038d8f8190ee6adb879c38a4ebea1b1eb91d96f/

@jseldess LGTM. This is awesome.
If you can get swap the survey from google forms --> survey monkey, it'll be a better phase 0 experience. Survey Monkey integrates with HubSpot. An extra 30 minutes effort here to save us hours in April. Then we can deal with HubSpot forms in Phase 1.

Done. Thanks, @jess-edwards.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/5a1040692b63bdf9e2d32a90882488e2bdb4fb8c/


CMakeUserPresets.json parsed incorrectly by "presetManager"

Diamond inheritance does not accepted by "presetManager", but parsed without errors.
CMake console is parsing same CMakeUserPresets.json successfully.

define preset1;

define preset2 and inherite it from preset1;

define preset3 and inherite it from preset1;

define preset4 with multiple inheritance, like:
{
"name": "preset4",
"inherits": [
"preset2",
"preset3"
]
}

preset4 will be successfully parser and verified by "presetManager":
"[presetController] Successfully validated presets in CMakeUserPresets.json"

But it won't be possible to select preset4 as nor configure preset, nor build preset;

[Window Title]
Visual Studio Code
[Main Instruction]
Visual Studio Code
[Content]
Version: 1.62.2 (user setup)
Commit: 3a6960b964327f0e3882ce18fcebd07ed191b316
Date: 2021-11-11T20:56:38.428Z (17 hrs ago)
Electron: 13.5.2
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043
[OK] [Copy]

/causedByExtension
VS Code doesn't work with CMakeUserPresets.json directly and functionality provided by an extension.
You should report this issue in extension's repo.
If you are sure that VS Code incorrectly works with JSON Schema for this file you should provide corresponding details.


[Do not merge][Dev] Apply prettier to the codebase

Set up a master version of prettier which has typescript support and ran it against Emission. Not mergeable really because I don't think others should be running a master version. Wanted to share the results though.

Fails

:no_entry_sign:

No CHANGELOG added.

:no_entry_sign:

Missing Test Files:

src/lib/components/artist/shows/__tests__/small_list-tests.tsx
src/lib/components/artist/shows/__tests__/variable_size_shows_list-tests.tsx
src/lib/components/artwork_grids/__tests__/generic_grid-tests.tsx
src/lib/components/buttons/__tests__/inverted_button-tests.tsx
src/lib/components/buttons/__tests__/navigation_button-tests.tsx
src/lib/components/consignments/components/__tests__/nav_button-tests.tsx
src/lib/components/__tests__/events-tests.tsx
src/lib/components/home/artist_rails/__tests__/artist_rail-tests.tsx
src/lib/components/home/artwork_rails/__tests__/artwork_rail_header-tests.tsx
src/lib/components/home/artwork_rails/__tests__/relay_fragments-tests.tsx
src/lib/components/home/__tests__/hero_units-tests.tsx
src/lib/components/home/__tests__/search_bar-tests.tsx
src/lib/components/home/__tests__/section_title-tests.tsx
src/lib/components/__tests__/load_failure_view-tests.tsx
src/lib/components/__tests__/opaque_image_view-tests.tsx
src/lib/components/related_artists/__tests__/related_artist-tests.tsx
src/lib/components/__tests__/switch_view-tests.tsx
src/lib/components/text/__tests__/headline-tests.tsx
src/lib/components/text/__tests__/serif-tests.tsx
src/lib/relay/__tests__/config-tests.tsx

If these files are supposed to not exist, please update your PR body to include "Skip New Tests".

Warnings

:warning:

Could not find stories using these components:

About

Artworks

Biography

Shows

Show

SmallList

ShowsList

Artwork

GenericArtworksGrid

InfiniteScrollArtworksGrid

WhiteButton

Info

ArtistCard

ArtistRail

HeroUnits

SearchBar

SectionTitle

LoadFailureView

OpaqueImageView

RelatedArtists

RelatedArtist

Separator

SwitchView

TabView

Notification

  Generated by :no_entry_sign: dangerJS

Time to update this? I think there’s been some updates.

Updated this PR to use prettier production  v0.14.2 - it's 100% determinate, I ran it three times and after the 2nd there were no additional changes 👍

Starting to look pretty pretty!

Warnings

:warning:

Missing Test Files:

src/lib/components/artist/shows/__tests__/small_list-tests.tsx
src/lib/components/artist/shows/__tests__/variable_size_shows_list-tests.tsx
src/lib/components/artwork_grids/__tests__/generic_grid-tests.tsx
src/lib/components/buttons/__tests__/inverted_button-tests.tsx
src/lib/components/buttons/__tests__/navigation_button-tests.tsx
src/lib/components/consignments/components/__tests__/nav_button-tests.tsx
src/lib/components/__tests__/events-tests.tsx
src/lib/components/home/artist_rails/__tests__/artist_rail-tests.tsx
src/lib/components/home/artwork_rails/__tests__/artwork_rail_header-tests.tsx
src/lib/components/home/artwork_rails/__tests__/relay_fragments-tests.tsx
src/lib/components/home/__tests__/hero_units-tests.tsx
src/lib/components/home/__tests__/search_bar-tests.tsx
src/lib/components/home/__tests__/section_title-tests.tsx
src/lib/components/__tests__/load_failure_view-tests.tsx
src/lib/components/__tests__/opaque_image_view-tests.tsx
src/lib/components/related_artists/__tests__/related_artist-tests.tsx
src/lib/components/storybooks/__tests__/section_browser-tests.tsx
src/lib/components/storybooks/__tests__/story_browser-tests.tsx
src/lib/components/storybooks/__tests__/styles-tests.tsx
src/lib/components/__tests__/switch_view-tests.tsx
src/lib/components/text/__tests__/headline-tests.tsx
src/lib/__tests__/metaphysics-tests.ts
src/lib/tests/__tests__/render_with_layout-tests.tsx

If these files are supposed to not exist, please update your PR body to include "Skip New Tests".

:warning:

Could not find stories using these components:

About

Artworks

Biography

Shows

Show

SmallList

ShowsList

Artwork

GenericArtworksGrid

InfiniteScrollArtworksGrid

WhiteButton

Info

ArtistCard

ArtistRail

ArtworkRail

ArtworkRailHeader

HeroUnits

SearchBar

SectionTitle

ConversationSnippet

Conversations

LoadFailureView

OpaqueImageView

RelatedArtists

RelatedArtist

Separator

SwitchView

TabView

Notification

  Generated by :no_entry_sign: dangerJS

OK, this is up to date and 🍏
I had to move a bunch of commands to npm run because of https://github.com/yarnpkg/yarn/issues/3595
Now to update all TS files in the project you can run: npm run prettier-project


Change Kana "memory" quiz type to "mega match" type quiz

My original thinking regarding the "memory" quiz type makes less sense to me on reflection.  I.e., it'd be exercising aspects of a person's memory that are not really related to language learning.  So instead, I want this quiz type option to be more of an extended/expanded match type quiz.
i.e., an even number of buttons arranged in an "n x m" grid; in the grid there are matching pairs of hiragana/katakana characters the user needs to find and "match".

This issue was cloned to the new GitHub repo as issue #9.


Adding Habitization - this PR supersedes PR#1416

This is the result of a tremendous team effort spent over the last couple of months. I'm just trying to drive it home with this PR. It is a branch copy of #1416; rebased and with all commits squashed and authors
attributed below. #1416 can be left intact for posterity and reference of original work with all the commits.
Habitat pkgs in this branch have been tested and are functional.
The vast majority of changes in this PR are for Habitat only and will not affect any current functionality.  The few exceptions to this are some minor changes to files in:

omnibus/files/private-chef-ctl-commands/
oc-chef-pedant/lib/

Co-authored-by: Elliott Davis<EMAIL_ADDRESS>Co-authored-by: Irving Popovetsky<EMAIL_ADDRESS>Co-authored-by: Mark Anderson<EMAIL_ADDRESS>Co-authored-by: Nolan Davidson<EMAIL_ADDRESS>Co-authored-by: Thomas Cate<EMAIL_ADDRESS>Signed-off-by: Jeremy J. Miller<EMAIL_ADDRESS>

@markan I've broken out the changes to omnibus/files/private-chef-ctl-commands/ into a different PR. Could you re-review please at your convenience?

Let's rebase and squash this down before merging...