Review HTML Standards documentation

User Story

As a [user role below]:
IBM.com Website visitor

I need to:
see relevant standards information regarding the application I am building with the IBM.com Library

so that I can:
build my application to standard

Additional information

Vlad and I have been working with Jon Wafer on updating the following documentation (which is currently super outdated now): http://g03zidbs001.ahe.boulder.ibm.com/transform/sas/as-web.nsf/0/D956B786993A24C585256B0D007D38AF

working draft from Jon here: https://ibm.ent.box.com/file/473204564559

Vlad mentioned that part of this documentation lives on the current standards site. We also had a conversation of where the updated documentation should live, and wasn't quite settled on having it be part of the digital design team or not.

For the documentation itself, we've been positioning us to link out to the corresponding SME documentation as much as possible so we don't have to maintain it (accessibility, SEO, etc). Though there are some things in there like what meta tags to include on the page, etc that we might have to have something on our cupcake site to include.

My inclination is to put as minimal as needed on our site, and then link out to any other resources.

Acceptance criteria

[ ] Review the HTML standards documentation
[ ] Determination on what needs to be included on the new cupcake website

@JennySanchez a heads up on this. I'm going to take a look a this and see what needs to be added on the tech side.
cc: @RobertaJHahn @ljcarot @wonilsuhibm @vlad-saling

Email sent out to Jon Wafer regarding this:
Hi Jon,
I took a look, and for the most part it seems like a combination of the standards site (old and new), as well as the official analytics documentation (https://ibm.biz/enable-analytics) cover what's needed. Scanning quickly, some of the documentation may be out of date anyway, but perhaps Vlad can provide a second pair of eyes to confirm.
As for page level content, I have proposed the following to be included in the new standards site for "Carbon for IBM.com":
https://ibm.ent.box.com/notes/541914909114
The idea is to provide an overview of what's needed, and any additional details link out to https://ibm.biz/enable-analytics. This link provides a ton of details around the DDO etc.
Let me know your thoughts.

I have already provided the content necessary for our site to @jacobottesen-dgc , so this story can probably be closed. I'm going to follow up with Jon Wafer separately to see if there's anything else needed from our team or if we're good to go.


[Suggestion] Game Event Listener

I would glad if you can add a Game Event Listener, it would help as learn how to make hitmarkers, on-kill/on-death messages, etc.

Added game events interfaces.


Inlay Hints for lifetimes

Inlay hints automatically display inferred types has made it significantly easier to see what is happening to what in a program.
This has also been very helpful to understand how some libraries are working.
Rust can most often infer the type of a variable within a function, so a plain source code does not need to be explicit at every corner, but hints provide a much needed insight to what can be done next.
However, types are only half of the story with Rust, as the borrow checker also relies on lifetimes to confirm correctness. Most of the time, those lifetimes are elided, making it easy to believe they are not there. This illusion breaks  when some refactors go outside the elision rules, requiring the programmer to explicitly annotate them.
Lifetimes in Rust are a tricky part that scares many beginners, as it is not a common concept found in other languages (even though the mechanics can be understood fairly easily), causing many cases to shy away from a much needed change.
I believe it would be helpful to see the elided lifetime information of the variable along with the type hints.
This could help learners in getting more familiar with the feature, and inform refactors of the actual lifetime that was in use originally.
As a downside however, adding lifetime information could also create a lot of noise, as it is expected they would be bound to the same scope most of the time. This might require setting a more fine-grained control of what to include in inlay hints to opt in or out of showing lifetimes.
I wouldn't be surprised there has been some discussion about this already, but couldn't find any information on the status of such a project.

We're still pretty far from being able to calculate this information. Apart from that, I don't think there's a good way to show lifetimes for local variables, since their lifetimes don't have names. The only place where I can imagine showing lifetimes in inline hints is for lifetime elision in definitions (but there's also the problem of naming; either we make up some name for the elided lifetimes, or we just show '_)

In polonius a "lifetime" is treated as a set of loans, not a region in code. I think it should be possible to show something like &'{a,b} u8 as type and &'a foo when creating the borrow. At least in the location insensitive variant of polonius.


Add misclassification demo

Adding a new demo for misclassification tests using design validation apis.
Demo is currently talking to the backend apis and will be updated when the APIM endpoints are made available. I added a fallback to a hardcoded results dataset as well until the issues with the scopes for the auth token are sorted out.
Trying to get this in before the sprint review on Wednesday morning, so if this could be looked at ASAP that would be great. Thanks!

Looks good mostly just mechanical changes requested.

The thumbnail looks a little wider and shorter than the others. Can you try to take a more square screenshot?

The thumbnails should be the following sizes:
1x = 370x225 px
2x = 740x450 px


newline after the end tag that was expected to formatted.

Input
The code looked like this before beautification:

    blah
head
blah

Expected Output
The code should have looked like this after beautification:

    blah

head

    blah

Actual Output
The  code actually looked like this after beautification:

    blah

head
blah

Steps to Reproduce

Write a tag that is supposed to be formatted. ( in the above case, the header 1 tag )
Surround the tag with plain text
Apply js-beautify

Environment
OS: http://jsbeautifier.org/
Settings
Any Settings
I was in the middle of testing vscode that I downloaded and noticed (personally) unexpected behavior. I'm not sure if this was intended or not.
I went through beautify-html.js and figured out that I could simply print newline after printing the tag_end, because unformatted tags or texts are considered to be comments.
I'm hoping I can request a pull. It will be my first GitHub contribution if I do.
Any thoughts are welcome.

Pulll requests are welcome.  I don't think that is for sure correct behavior.  If that was a  or an .  You would definitely not want a newline after it unless there was a space between the text and tag:

    blah head blah

Take a look at #841 for a discussion of the underlying problem.

@bitwiseman inline tags like  and  are defaulted to be "unformatted" and is inline. The link you provided me claims that "unformatted" and "inline" are different concept but I think they will end up with same behavior, unless we want all newline characters removed from the beginning of "inline" tags. However, if a user inserted a newline character, that should mean that the user wants it to be there.

If you manually insert a new line after the <\h1> tag, it will be kept there. If you don't, the code won't insert it for you. I think this is the best behaviour as any tag can be set as inline for the developer's particular use case, and adding white space could affect the presentation in that case.

@HookyQR @PYangDizzle
Inline elements are the name we've used for elements with phrasing content model in html.
See https://www.w3.org/TR/html5/dom.html#concept-html-contents
https://www.w3.org/TR/html5/dom.html#paragraph
Inline means the first two inputs produce the same layout in html, but the third does not:

Hello World!

    Hello

    World!

Hello
    World

    !

And all of the above differ from the concept of "unformatted" or "preformatted" elements.
To go back to something like the original example, these two produce the same output:
blah
head

hello
blah

    blah

head

hello

    blah

Heading tags flow content that contains phrasing content, but they are phrasing content themselves.
All this means this request is somewhere between a bug and an enhancement.  It's not correct behavior, but there are also some design and implementation details that make this a more involved undertaking to fix/improve.

While I agree with what you've said, the issue is around formatting the text after the tag:

World!

World
!

These two produce different output, and that is what I'm saying would cause a problem.

@HookyQR  That's what I said above. 😄


Add linting rule for untranslated string literals in JSX

Summary

Unintended string literals can potentially leak untranslated text into the application. This PR adds a linting rule to make sure they're intended. It also translate-converts any remaining string literals, or marks them as intended.
e.g.

Ticket Link
None
Checklist

Item
Y / N / NA [^1]

Telemetry updated?
N

Gated by experimental feature flag?
N

Unit/E2E tests updated?
N

[^1]: Yes / No / Not Applicable.

Nice!


Added Clarity

Added clarity to readme. Clarity is a testing framework (gherkin bdd inspired)

Very cool!

Very cool!


Update workflows to use Mambaforge

Let's see if this resolves #360

Based on https://ericmjl.github.io/blog/2021/12/30/better-conda-environments-on-github-actions/ , I updated the relevant workflows to use mamba from the get-go. That seems to have done the trick.

I'll merge this now, but it also occurs to me that we can avoid some of this extra maintenance burden by advancing #339 so this repo uses the same workflows as the Cookbooks.


fix: correct receive-side settlementAmount calculation for API

Description
This fixes the issue where in mongo satsAmount and centsAmount reflect receive amounts less fees which no longer matches with the credit value which includes fees when doing display price calculations.

Discovered that was only a bug that affected Dealer's transaction view


How to prove the topology  for BGPPeer

Installation config
apiVersion: operator.tigera.io/v1
kind: Installation
metadata:
  ....
spec:
  calicoNetwork:
    bgp: Enabled
    hostPorts: Enabled
    ipPools:
    - blockSize: 26
      cidr: <IP_ADDRESS>/16
      disableBGPExport: false
      encapsulation: IPIP
      natOutgoing: Enabled
      nodeSelector: all()
    linuxDataplane: Iptables
    multiInterfaceMode: None
    nodeAddressAutodetectionV4:
      firstFound: true
  cni:
    ipam:
      type: Calico
    type: Calico

I have 3 nodes
By default  node-to-node mesh , the topology may like this  connect by tunl0

And I can prove it from ip route
On A
blackhole <IP_ADDRESS>/26 proto bird
<IP_ADDRESS>/26 via B dev tunl0 proto bird onlink
<IP_ADDRESS>/26 via C dev tunl0 proto bird onlink

On C
<IP_ADDRESS>/26 via A dev tunl0 proto bird onlink
<IP_ADDRESS>/26 via B dev tunl0 proto bird onlink
blackhole <IP_ADDRESS>/26 proto bird

On B
<IP_ADDRESS>/26 via A dev tunl0 proto bird onlink
blackhole <IP_ADDRESS>/26 proto bird
<IP_ADDRESS>/26 via C dev tunl0 proto bird onlink

Then after I config C as route reflector
calicoctl patch node C -p '{"spec": {"bgp": {"routeReflectorClusterID": "<IP_ADDRESS>"}}}'

kubectl label node C route-reflector=true

cat <<EOF | calicoctl apply -f -
kind: BGPPeer
apiVersion: projectcalico.org/v3
metadata:
  name: peer-with-route-reflectors
spec:
  nodeSelector: all()
  peerSelector: route-reflector == 'true'
EOF

cat <<EOF | calicoctl apply -f -
apiVersion: projectcalico.org/v3
kind: BGPConfiguration
metadata:
 name: default
spec:
  logSeverityScreen: Info
  nodeToNodeMeshEnabled: false
  asNumber: 63400
EOF

On A
Calico process is running.

IPv4 BGP status
+--------------+---------------+-------+----------+-------------+
| PEER ADDRESS |   PEER TYPE   | STATE |  SINCE   |    INFO     |
+--------------+---------------+-------+----------+-------------+
| C  | node specific | up    | 06:32:50 | Established |
+--------------+---------------+-------+----------+-------------+

IPv6 BGP status
No IPv6 peers found.

On C

Calico process is running.

IPv4 BGP status
+--------------+---------------+-------+----------+-------------+
| PEER ADDRESS |   PEER TYPE   | STATE |  SINCE   |    INFO     |
+--------------+---------------+-------+----------+-------------+
| A  | node specific | up    | 06:32:40 | Established |
| B | node specific | up    | 06:32:40 | Established |
+--------------+---------------+-------+----------+-------------+

IPv6 BGP status
No IPv6 peers found.

BGPPeer config success
Except Behavior

But  the ip route hasn't any change  Why?
Context

Your Environment

Calico version
Orchestrator version (e.g. kubernetes, mesos, rkt):
Operating System and version:
Link to your project (optional):

Hey @631068264, if you want to look at the BGP peerings, calicoctl node status like you did is the best way to do it. You could also dig deeper and use birdcl on the calico-node pods themselves. But enabling route reflectors shouldn't change how the ip routes look on the nodes, they'll still have the same ones (the network topology is different from the BGP peerings, and that hasn't changed, has it?)


Provide detailed exception message in PublishTask

Hm, what's the point of putting exception stack trace into the message?


Document Component

Originated from newsfeed detail page ticket #10
Downloads/Links (Documents, Videos, Presentation)
! force download for downloadables

Closed width #10


Include teacher name & grade level to roster

Idea from Marian to include teacher name for communication & collaboration purposes:
"Could you have teacher names instead or in addition?? I was thinking that if a teacher (ie an ATP tutor or anyone other than the child's HR teacher) wanted to look up a child, they might only know the name of the child's HR teacher."
When the tool is used during the MTSS meetings --- as Uri envisions it --- it would be helpful for the MTSS team to know which teacher to contact / connect with regarding a student rather than a homeroom number.
@AmirHadjihabib: What do you think? Where would you envision putting the teacher name on the roster?

@alexsoble @AmirHadjihabib: At the MTSS & SST meetings, it became evident / was reiterated how the current way to find a student (SELECT homeroom >> wait for roster to load >> SORT name >> SCROLL down roster >> FIND student) is not efficient and actually quite difficult. Ideally, we need to build in a search so that students can be searched by name since teachers / staff know students by name, not by homeroom number.
As discussed with Jill & Uri and suggested by others:

attach teacher name to classroom number in dropdown list

e.g., "HEA 100 - Muraki" instead of "HEA 100"

add grade level view

https://github.com/codeforamerica/somerville-teacher-tool/issues/123
@ejegg: Missed your comment earlier on #123. Great feedback! Would love your ideas on this.

build in search

during the SST meetings, students were discussed one after the other and, as currently designed, the tool would have been stalled the flow given how long it takes to find a student.

Currently:

Searchbar: implemented and in production.
ATP tutor use case: out of scope.


Create quick_sort.php

Created quick_sort file

Closing this PR as it has become stale with no activity in a very long time


<IP_ADDRESS> - Dell G16 7630 - G mode issue

I have a Dell G16 7630. I am constantly stuttering in G mode on <IP_ADDRESS>. No issues with 8.6.1.

I need your SystemID, please. Open Admin CMD, run alienfan-cli getpower

I fix this bug into <IP_ADDRESS>. Check, please.

Thanks, it's fixed.


App crash when take a picture and press back button

Bug report
Summary
The app crash when i open the camera or image library and press back button.

Environment info
react-native info output:
System:
    OS: Windows 10 10.0.18363
    CPU: (4) x64 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
    Memory: 2.53 GB / 15.92 GB
  Binaries:
    Node: 10.17.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.19.1 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.11.3 - C:\Program Files\nodejs\npm.CMD
    Watchman: Not Found
  SDKs:
    Android SDK: Not Found
  IDEs:
    Android Studio: Version  <IP_ADDRESS> AI-193.69<IP_ADDRESS>14223
  Languages:
    Java: 1.8.0_221
    Python: 3.8.3
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.11.0 => 16.11.0
    react-native: 0.62.2 => 0.62.2
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 2.3.1
Steps to reproduce

Launch Camera or ImageLibrary
Press back button

Describe what you expected to happen:

Should not crash

Reproducible sample code
  ImagePicker.launchImageLibrary(
            {storageOptions: constants.storageOptions},
            response => {
                if (response.error) {
                    Alert.alert(
                        'Algo deu errado',
                        'Verifique se você permitiu que o nosso aplicativo usasse a sua galeria'
                    );
                    return;
                }

            }
        );

Any updates on this? Experience the same.

Any updates?

If possible can you migrate to using version 3.0.0-vnext.1 https://github.com/react-native-image-picker/react-native-image-picker/releases/tag/v3.0.0-vnext.1
Check if your issue is solved.
Check 3.x.x docs for installation and API changes.

Have you tried to handle response.didCancel state? I had the same issue (without camera) and it was a solution for my case.

ImagePicker.launchCamera(option, (response) => {
if (response.didCancel === true) {
return ''
}
const datatransfer = response.assets
var datas = {}
for (let d = 0; d < datatransfer.length; d++) {
datas = datatransfer[d];
}
ImageResizer.createResizedImage(datas.uri, 250, 250, 'JPEG', 100).then((response) => {
RNFS.readFile(response.uri, 'base64').then(res => {
{this  help full


Templating and other blog posts

Also added package metadata (tags and homepage) to our npm packages.
Fixes #3951
Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run


how does one execute a network with multiple outputs

Using the mxnet-cpp cpp interface to mxnet.
I would like a Conv network with multiple outputs.
    Input
      |
    Conv1
      |
    Conv2
      |-------------|
      |             |
ApplesConv     OrangesConv
      |             |
    output1      output2

I believe I have successfully set this network up.
But I do not understand how to create the executor which will then generate the outputs.
Obviously:

auto *exe = output.SimpleBind(ctx, args);

will not work, because there is no single output.
Suggestions?  Thanks!!!

it seems Symbol::Group(std::vector) is the key

Hi @timprepscius looks like the issue you have sent is more likely as a question! Please send this to: https://discuss.mxnet.io/. There will be members pick up this and answer that.
@mxnet-label-bot could you please add [question, c++] to this issue?

@timprepscius Hope your issue got addressed on the Discussion Forum.
@sandeep-krishnamurthy Can you please close this issue.
Thanks!


[Addition]: Location spoofing

Hotspot b58 Addresses
11huJXTdDgrkva6tdxH5PKJ6wHAqqrHwHmyaVWbj6wFkSnXXvSG
Discord Handle
No response
Reason(s)
IP does not belong to Taiwan.

What can I do to get the cheater's IP, please let me know. I will also report some cheaters.


Memory leakage issues in all SAE J2735 message will decoding

Hi ,
During the check of Heap memory using valgrind for map data decoding using uper_decode() there was some 264 bytes of leakage as the CALLOC memory was not freed.
Have also addressed the same issue with BSM and EVA message.
Please find the below valgrind report.
==5215== Memcheck, a memory error detector
==5215== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==5215== Using Valgrind-3.10.1 and LibVEX; rerun with -h for copyright info
==5215== Command: ./my-program
==5215== Parent PID: 2379
==5215==
==5215== Invalid read of size 4
==5215==    at 0x80520C0: populate_sae_to_map (BSM_SAE_conversions.c:409)
==5215==    by 0x8052336: Decode_SAE_MAP (BSM_SAE_conversions.c:604)
==5215==    by 0x80610B9: main (converter-sample.c:114)
==5215==  Address 0x41fe388 is 0 bytes inside a block of size 4 free'd
==5215==    at 0x402B3D8: free (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==5215==    by 0x806D32C: NativeEnumerated_decode_uper (NativeEnumerated.c:146)
==5215==    by 0x80599DE: SEQUENCE_decode_uper (constr_SEQUENCE.c:1181)
==5215==    by 0x807A5B1: uper_open_type_get_simple (per_opentype.c:116)
==5215==    by 0x807ACB4: uper_open_type_get (per_opentype.c:264)
==5215==    by 0x8078BE2: OPEN_TYPE_uper_get (OPEN_TYPE.c:333)
==5215==    by 0x805998D: SEQUENCE_decode_uper (constr_SEQUENCE.c:1178)
==5215==    by 0x8079BFC: uper_decode (per_decoder.c:83)
==5215==    by 0x8052207: Decode_SAE_MAP (BSM_SAE_conversions.c:566)
==5215==    by 0x80610B9: main (converter-sample.c:114)
==5215==
==5215==
==5215== HEAP SUMMARY:
==5215==     in use at exit: 278 bytes in 12 blocks
==5215==   total heap usage: 29 allocs, 17 frees, 1,174 bytes allocated
==5215==
==5215== 8 bytes in 2 blocks are definitely lost in loss record 1 of 9
==5215==    at 0x402C109: calloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==5215==    by 0x806E4D7: NativeInteger_decode_uper (NativeInteger.c:272)
==5215==    by 0x80599DE: SEQUENCE_decode_uper (constr_SEQUENCE.c:1181)
==5215==    by 0x807A5B1: uper_open_type_get_simple (per_opentype.c:116)
==5215==    by 0x807ACB4: uper_open_type_get (per_opentype.c:264)
==5215==    by 0x8078BE2: OPEN_TYPE_uper_get (OPEN_TYPE.c:333)
==5215==    by 0x805998D: SEQUENCE_decode_uper (constr_SEQUENCE.c:1178)
==5215==    by 0x8079BFC: uper_decode (per_decoder.c:83)
==5215==    by 0x8052207: Decode_SAE_MAP (BSM_SAE_conversions.c:566)
==5215==    by 0x80610B9: main (converter-sample.c:114)
==5215==
==5215== 102 (32 direct, 70 indirect) bytes in 1 blocks are definitely lost in loss record 8 of 9
==5215==    at 0x402C109: calloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==5215==    by 0x80595C1: SEQUENCE_decode_uper (constr_SEQUENCE.c:1096)
==5215==    by 0x80599DE: SEQUENCE_decode_uper (constr_SEQUENCE.c:1181)
==5215==    by 0x807A5B1: uper_open_type_get_simple (per_opentype.c:116)
==5215==    by 0x807ACB4: uper_open_type_get (per_opentype.c:264)
==5215==    by 0x8078BE2: OPEN_TYPE_uper_get (OPEN_TYPE.c:333)
==5215==    by 0x805998D: SEQUENCE_decode_uper (constr_SEQUENCE.c:1178)
==5215==    by 0x8079BFC: uper_decode (per_decoder.c:83)
==5215==    by 0x8052207: Decode_SAE_MAP (BSM_SAE_conversions.c:566)
==5215==    by 0x80610B9: main (converter-sample.c:114)
==5215==
==5215== 168 (32 direct, 136 indirect) bytes in 1 blocks are definitely lost in loss record 9 of 9
==5215==    at 0x402C109: calloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==5215==    by 0x805F3D2: SET_OF_decode_uper (constr_SET_OF.c:928)
==5215==    by 0x80599DE: SEQUENCE_decode_uper (constr_SEQUENCE.c:1181)
==5215==    by 0x807A5B1: uper_open_type_get_simple (per_opentype.c:116)
==5215==    by 0x807ACB4: uper_open_type_get (per_opentype.c:264)
==5215==    by 0x8078BE2: OPEN_TYPE_uper_get (OPEN_TYPE.c:333)
==5215==    by 0x805998D: SEQUENCE_decode_uper (constr_SEQUENCE.c:1178)
==5215==    by 0x8079BFC: uper_decode (per_decoder.c:83)
==5215==    by 0x8052207: Decode_SAE_MAP (BSM_SAE_conversions.c:566)
==5215==    by 0x80610B9: main (converter-sample.c:114)
==5215==
==5215== LEAK SUMMARY:
==5215==    definitely lost: 72 bytes in 4 blocks
==5215==    indirectly lost: 206 bytes in 8 blocks
==5215==      possibly lost: 0 bytes in 0 blocks
==5215==    still reachable: 0 bytes in 0 blocks
==5215==         suppressed: 0 bytes in 0 blocks
==5215==
==5215== For counts of detected and suppressed errors, rerun with: -v
==5215== ERROR SUMMARY: 4 errors from 4 contexts (suppressed: 0 from 0)

@Purnanandj, could you share the minimal reproducible example code ? thanks.

@brchiu Thanks for the reply .
The code is all SAE generated .c and .hfiles from asn file, the main code for above valgrind report is constr_SEQUENCE.c

@brchiu Thanks for the quick reply.
converter-example.txt
Above is the C code and the data in the buffer is encoded data, which i am decoding and the decoded result.
output is ;
value MessageFrame ::=
{
messageId 18,
value MapData :
{
timeStamp 100,
msgIssueRevision 10,
layerType curveData,
layerID 51,
dataParameters
{
processMethod "Hai Hello",
geoidUsed "Dear Naveen"
},
restrictionList
{
{
id 100,
users
{
basicType weightCompliant
}
}
}
}
}
And the valgrind report is attached
valgrind.txt
Even this has memory leakage issue.

@Purnanandj ,
You should change free(saeMap_decoded); to ASN_STRUCT_FREE(asn_DEF_MessageFrame, saeMap_decoded);.
Then you can have the following valgrind output :
$ valgrind --leak-check=full ./j2735-dump
==25419== Memcheck, a memory error detector
==25419== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==25419== Using Valgrind-3.13.0 and LibVEX; rerun with -h for copyright info
==25419== Command: ./j2735-dump
==25419==
DBG: MAP UPER DECODE SUCCESSFUL with 264 Bytes Consumed

  MAP_msg_Id = 18

  MAP_msg_MinuteOfTheYear = 100

  MAP_msg_MsgCnt = 10

  MAP_msg_Layer_type = 4

  MAP_msg_Layer_ID = 51

  rl_id = 100

  rl_users_basicType = 6
==25419==
==25419== HEAP SUMMARY:
==25419==     in use at exit: 0 bytes in 0 blocks
==25419==   total heap usage: 30 allocs, 30 frees, 2,578 bytes allocated
==25419==
==25419== All heap blocks were freed -- no leaks are possible
==25419==
==25419== For counts of detected and suppressed errors, rerun with: -v
==25419== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

I still get memory leaks and crashes.  I've thrown in the towel on this compiler.


[cloud_firestore] Retrieving a document from cache that doesn't exist throws an exception

Is there an existing issue for this?

[X] I have searched the existing issues.

Which plugins are affected?
Database
Which platforms are affected?
Android, iOS
Description
This is a continuation of this issue: https://github.com/firebase/flutterfire/issues/10887.
Instead of throwing an error, get should return an empty document.
Reproducing the issue

Install cloud_firestore version 4.14.0.
Install firebase_core version 2.24.2.
Ensure you have properly initialized Firebase before calling the get method.
Make sure that you have enabled Firestore persistence.
Ensure that the document you are fetching does not exist in the cache.
It doesn't matter if you are offline or online.
Run the code below.

try {
  final snapshot = await FirebaseFirestore.instance
      .collection('name')
      .doc('id1')
      .get(const GetOptions(source: Source.cache)); // throws the error

  // Unreachable code below:
  final json = snapshot.data();

  print(snapshot.exists); // should be false
  print(json); // should be null
} catch (e) {
  // [cloud_firestore/unavailable] The service is currently unavailable.
  // This is a most likely a transient condition and may be corrected by
  // retrying with a backoff.
}

Firebase Core version
2.24.2
Flutter Version
3.16.7

This is expected behaviour. If you try to get a document that does not exist in cache, it throws an exception. If you try to query a collection in cache that has no results, it won't throw an exception, it will return 0 documents.
Here is the android documentation stating this
apple documentation stating the same thing.


validation status test new/ignored/resolved: 1/0/0 count: 0 != expected: 1

Which jobs are flaking?
validator_basic
Which test(s) are flaking?
DM-IT
release-6.1
Jenkins logs or GitHub Actions link
[2022-06-01T12:44:23.324Z] command: validation status test new\/ignored\/resolved: 1\/0\/0 count: 0 != expected: 1, failed the 9-th time, will retry again

[2022-06-01T12:44:25.220Z] {

[2022-06-01T12:44:25.220Z]     "result": true,

[2022-06-01T12:44:25.220Z]     "msg": "",

[2022-06-01T12:44:25.220Z]     "validators": [

[2022-06-01T12:44:25.220Z]         {

[2022-06-01T12:44:25.220Z]             "task": "test",

[2022-06-01T12:44:25.220Z]             "source": "mysql-replica-01",

[2022-06-01T12:44:25.220Z]             "stage": "Running",

[2022-06-01T12:44:25.220Z]             "validatorBinlog": "(dm-integration-test-go1180-6422-lw0nb-fj74q-bin.000001, 2590)",

[2022-06-01T12:44:25.220Z]             "validatorBinlogGtid": "",

[2022-06-01T12:44:25.220Z]             "result": null,

[2022-06-01T12:44:25.220Z]             "processedRowsStatus": "insert/update/delete: 6/1/1",

[2022-06-01T12:44:25.220Z]             "pendingRowsStatus": "insert/update/delete: 0/0/0",

[2022-06-01T12:44:25.220Z]             "allErrorRowsStatus": "new/ignored/resolved: 2/0/0"

https://ci2.pingcap.net/blue/organizations/jenkins/dm_ghpr_integration_test/detail/dm_ghpr_integration_test/6422/pipeline/
Anything else we need to know

Does this test exist for other branches as well?

Has there been a high frequency of failure lately?

very often, PTAL @D3Hunter @buchuitoudegou
https://ci2.pingcap.net/blue/organizations/jenkins/dm_ghpr_integration_test/detail/dm_ghpr_integration_test/6547/pipeline


bugfix:API系统下无api数据仍无法删除

Codecov Report

Merging #620 (4d2b82c) into v2.6.x_develop (e07f10c) will not change coverage.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           v2.6.x_develop     #620   +/-   ##
===============================================
  Coverage           62.27%   62.27%
===============================================
  Files                 442      442
  Lines               27464    27464
===============================================
  Hits                17102    17102
  Misses              10362    10362

Impacted Files
Coverage Δ

itsm/postman/models.py
85.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07f10c...4d2b82c. Read the comment docs.


Added the ability to set custom package name in sentry dart plugin

:scroll: Description
Different namings between android package name or ios bundle id and pubspec's name.
When a developer uploads source mappings to the sentry dashboard by the current lib, there appears a new release with a package name, which is different from the android package name or ios' bundle id. But when a crash of the app happens, the sentry io of the native side sends a native package names or bundle id which is not the same as the pubspec's package (name@version).
So, the releases of uploading via plugin and crashed ones are different
The decision, add a name parameter of sentry config (configuration.dart -> 96 row)
name = config?['name']?.toString() ?? pubspec['name'].toString();

Blocked by https://github.com/getsentry/sentry-dart-plugin/issues/137#issuecomment-1641591960

Thanks @klnfreedom but this is now superseded by https://github.com/getsentry/sentry-dart-plugin/pull/139

Thanks @marandaneto for your quick response and actions!


use PrefShkDstn more widely in ConsPrefShockModel

fixes #641

Making this Work in Progress since standardizing this change across the library will require more work, see https://github.com/econ-ark/HARK/issues/641#issuecomment-618089969

Low priority -- wait until treatment of distributions and simulation has stabilized.


Fallback to direct read from memory in case of any error

We, at pyroscope.io, are using pyspy & rbspy which both are using this library underneath. For cases when process_vm_readv() is forbidden ( due to seccomp settings in Docker, or by disabling SYS_PTRACE capabilities for user ) the fallback to direct memory read is not working. Imo, it should be possible to do a fallback to direct memory read in case of any case when process_vm_readv() is failing.
Some of our users, who are using Docker, Podman or Heroku, don't have possibilities to change permissions on their platform to be able to use process_vm_readv(). For those cases, the only way is to read memory directly from /dev/<pid>/mem.

@benfred Please take a look at this change. I am open for discussion.

Creating new PR, this time for proper branch.


Lack of standards guide

Create a file for simple standards guide so other users can follow it without asking us

Some propositions:

Let's stop doing the FOLDER: ACTION commit so it's easier for newcomers to contribute
Lets just ask for a understable commit name and description
Understandable code and comments

#16 Adresses this issue


feat: upgrade api request registration

:tada: This PR is included in version 1.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Disable onnx tests and pipeline until we forward-port onnx work.

Description
Disable onnx pipeline and remove onnx unit tests until we can forward port the onnx work from v1.x branch.
The onnx tests in master were incorrectly running for every pipeline. We need to mark the onnx tests in a category and prevent them from running in all pipelines except for the onnx pipeline.

@mxnet-bot run ci [all]

@mxnet-bot run ci [all]

@mxnet-bot run ci [all]


Update dependencies and use keccak

The current version fails to build due to an error on the assertion since the function used as is is sha-256 which no longer returns the correct result.
To fix this, I updated the lib to use the latest version of pyhash lib and the correct function keccak-256.

Thanks @antonio-mendes, that PR worked for me.
@pipermerriam any chances to get it merged so we release a version.
Here's how I tested it:
pip install https://github.com/antonio-mendes/ens-namehash-py/archive/refs/heads/update_library.zip

>>> from namehash import namehash
>>> namehash('').hex()
'0000000000000000000000000000000000000000000000000000000000000000'
>>> namehash('foo.eth').hex()
'de9b09fd7c5f901e23a3f19fecc54828e9c848539801e86591bd9801b019f84f'

This was with 3.8.13

Thanks @antonio-mendes, that PR worked for me. @pipermerriam any chances to get it merged so we release a version. Here's how I tested it:
pip install https://github.com/antonio-mendes/ens-namehash-py/archive/refs/heads/update_library.zip

>>> from namehash import namehash
>>> namehash('').hex()
'0000000000000000000000000000000000000000000000000000000000000000'
>>> namehash('foo.eth').hex()
'de9b09fd7c5f901e23a3f19fecc54828e9c848539801e86591bd9801b019f84f'

This was with 3.8.13

Unfortunately @pipermerriam doesn't seem to be active these days. I've tried e-mailing a few times but got no replies 🥲

Any alternative on updating the package?

Thanks @antonio-mendes, that PR worked for me. @pipermerriam any chances to get it merged so we release a version. Here's how I tested it:
pip install https://github.com/antonio-mendes/ens-namehash-py/archive/refs/heads/update_library.zip

>>> from namehash import namehash
>>> namehash('').hex()
'0000000000000000000000000000000000000000000000000000000000000000'
>>> namehash('foo.eth').hex()
'de9b09fd7c5f901e23a3f19fecc54828e9c848539801e86591bd9801b019f84f'

This was with 3.8.13

Unfortunately @pipermerriam doesn't seem to be active these days. I've tried e-mailing a few times but got no replies 🥲

Any alternative to updating the package?

Thanks @antonio-mendes, that PR worked for me. @pipermerriam any chances to get it merged so we release a version. Here's how I tested it:
pip install https://github.com/antonio-mendes/ens-namehash-py/archive/refs/heads/update_library.zip

>>> from namehash import namehash
>>> namehash('').hex()
'0000000000000000000000000000000000000000000000000000000000000000'
>>> namehash('foo.eth').hex()
'de9b09fd7c5f901e23a3f19fecc54828e9c848539801e86591bd9801b019f84f'

This was with 3.8.13

Unfortunately @pipermerriam doesn't seem to be active these days. I've tried e-mailing a few times but got no replies 🥲

Any alternative to updating the package?

Not sure tbh, I can try to reach out to someone at consensys, maybe they'd be able to push this.

My apologies for the radio silence on my part.  I'm working to get my copy of this repository transferred to be managed under the Ethereum org's github, at which point the team that manages the rest of the python ethereum libraries will be able to get this merged and released.

Thanks for the update @pipermerriam

My apologies for the radio silence on my part. I'm working to get my copy of this repository transferred to be managed under the Ethereum org's github, at which point the team that manages the rest of the python ethereum libraries will be able to get this merged and released.

Sounds great, thank you for your work and the update!

Hey @pipermerriam any news on this?

I unfortunately retract my previous statement.  Looks like web3.py uses it's own implementation of namehash
https://github.com/ethereum/web3.py/blob/f55157195466e6b2554e24c4043d7228b770b4a5/ens/utils.py#L215
And thus, I don't see the Ethereum python team taking ownership of this repository (and I'm no longer going to be maintaining it either).


"Go" menu has disabled "Go to Definition" etc. commands

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.58.2 and the latest Insiders.
OS Version: Windows

Steps to Reproduce:

Open a TypeScript file and put the cursor over some variable (right-click to verify the Go to Definition command appears in the right-click menu).
Use the Go menu.

Bug: The Go to Definition command are disabled (along with others below it).
This caused a user of our C/C++ extension to believe Go to Definition was unavailable (see https://github.com/microsoft/vscode-cpptools/issues/7847).

@vscodebot Not a duplicate of those issues.

Looks like it may be an issue with the menus themselves since the command still shows up in other places

Using Developer: inspect context keys, I see editorHasDefinitionProvider === true inside the editor. However here:
https://github.com/microsoft/vscode/blob/ece433775144f6229f40e5d60b8fa9e98c1f32a2/src/vs/platform/actions/common/actions.ts#L408
editorHasDefinitionProvider evaluates to undefined, possibly because it's being evaluated in the global scope? Not sure what has changed here

@isidorn Adding you since I see you reviewed https://github.com/microsoft/vscode/pull/124726. I tried building VS Code one commit before the PR and still see the issue so I don't it caused the problem. However maybe you have some ideas on what else could be causing this

I do not have good ideas here apart from what you already mentioned. My best suggestion is to git bisect if you know this was working before.

I have not been around to break this :P but what @mjbvz says is correct that the context key is evaluated on the global scope for the global menu.

After investigation, this is not new even at 1.58. I went back several versions, and this has not worked for a good while. The issue is as @mjbvz says. The context key is scoped to the editor but the global menu can only handle globally-scoped context keys. So, I would recommend a separate key activeEditorHasDefinitionProvider that is globally scoped.
@alexdima or @rebornix I believe owns these keys


Zxing.Net.Maui: build & publish Zxing.Net package

Bulid and publish Zxing.Net.* packages under the names of Mali.Zxing and Mali.ZXing.Controls. This will create nuget packages that can be consumed by geewallet without relying on sources being available through maui submodule.
Reference readme from projects, because now we pack individual projects, and readme file from solution root is not referenced automatically.
Supersedes #38

@webwarrior-ws please rebase

rebased


Gsub for whitespace instead of empty string

Fixes issue where two word strings eg "Hello World" outputs image "H" instead of "HW"

@dakmau Would be great if you could add spec for this case so we avoid regression bug in the future.

BTW Could you fix build. I missed specs failed.

Closed since issue has already been resolved.


Update docker network api doc

Test results:

for connect:
HTTP/1.1 500 Internal Server Error
Content-Type: text/plain; charset=utf-8
Server: Docker/1.9.1 (linux)
Date: Mon, 04 Jan 2016 09:56:31 GMT
Content-Length: 50
container already connected to network testnework

for disconnect:
HTTP/1.1 500 Internal Server Error
Content-Type: text/plain; charset=utf-8
Server: Docker/1.9.1 (linux)
Date: Mon, 04 Jan 2016 09:45:24 GMT
Content-Length: 107
container e86cf50fde54217bfd72429fec5e7f7e3cfa2246cb30e842088ad3c1fdcf7f61 is not connected to the network

for remove:
HTTP/1.1 200 OK
Server: Docker/1.9.1 (linux)
Date: Mon, 04 Jan 2016 09:59:11 GMT
Content-Length: 0
Content-Type: text/plain; charset=utf-8

Signed-off-by: Wen Cheng Ma<EMAIL_ADDRESS>

Thanks! LGTM

ping @moxiegirl PTAL

Thanks @wenchma LGTM


[Android] Invalid cast exception on ItemTemplate instanciation

Hi,
I have a simple ItemTemplate like this:
public class AItemTemplate: ViewCell
{

  public AItemTemplate()
  {
    var gridLayout = new Grid() {
      RowDefinitions = {
        new RowDefinition() { Height = new GridLength(1, GridUnitType.Star) },
        new RowDefinition() { Height = new GridLength(1, GridUnitType.Star) }
      },
      ColumnDefinitions = {
        new ColumnDefinition() { Width = new GridLength(1, GridUnitType.Star) },
        new ColumnDefinition() { Width = new GridLength(2, GridUnitType.Star) },
      }
    };
    var sequenceLabel = new Label() { };
    sequenceLabel.SetBinding(Label.TextProperty, nameof(AViewModel.StringVal));
    gridLayout.Children.Add(sequenceLabel, 0, 0);
    View = gridLayout;
    //[snip]

Now, when I assign this to the Carousels ItemTemplate property I get an Invalid Cast Exception in CarouselViewRenderer.PageAdapter.InstantiateItem (line 337):
  var selector = Element.ItemTemplate as DataTemplateSelector;
  if (selector != null)
    formsView = (View)selector.SelectTemplate(bindingContext, Element).CreateContent();
  else
    formsView = (View)Element.ItemTemplate.CreateContent(); // this is the line causing the exception

After replacing the line with
    var fv = Element.ItemTemplate.CreateContent();
    if (fv is ViewCell)
      formsView = ((ViewCell)fv).View;
    else
      formsView = (View)fv;

everything works fine.
I didn't code a renderer by myself yet, so I just tried and wondered why such a workaround seemed to be neccessary. Is it, really, or am I wrong?

CarouselView doesnt support ViewCell. Use ContentView instead. Thanks

Sorry, this was my first comment in github, so I had some problems with formatting the code.
Well, seems that I have found a way to get ViewCell going :)
I'll try further. Would you be interested in results?

If my work is helping you, please help me back: https://xamarinhq.wufoo.com/forms/nominate-a-xamarin-mvp/
This is what i have done that is community visible:

Alex has been pretty active sharing his knowledge and answering questions in StackOverflow, GitHub and Xamarin Forums.
Alex has been open sourcing Xamarin components and plugin with the community, with more of 10 repositories being maintained on GitHub.
One of Alex's Xamarin.Forms plugin, the CarouselView, is currently being pulled into the Xamarin.Forms core (https://github.com/xamarin/Xamarin.Forms/pull/853). As an stable widget, this control has become the standard for Xamarin.Forms carousel screens with more that 16K downloads in NuGet and more than 100 solved and not open issues.
Another Alex's plugin, the SegmentedControl (https://github.com/alexrainman/SegmentedControl), is a big candidate to be also pulled into Xamarin.Forms core.
Plus Xamarin.Forms UI related plugins, Alex shares plugins to set app icon Badge, Google Analytics and KeyChain access.
Alex shares his knowledge about cutting edge technologies like Couchbase NoSQL and MobileIron integration with Xamarin Apps.


Banner message should be configurable

Describe the bug
The banner message Welcome to Red Hat Developer Hub! on the main screen should be configurable.  There doesn't seem to be a way to change it.

Versions of software used and environment
RHDH DP 0.1

Same with showcase which is hardcoded to:

We should parametrize this line:
https://github.com/janus-idp/backstage-showcase/blob/c798525099a59888d0ae329d69754cfc1996f77b/packages/app/src/components/home/HomePage.tsx#L85
To use app.title from the config or something like that. Thoughts @sonyccd @christophe-f ?

is app.title used in other places? Right now downstream has just "Red Hat Developer Hub" as the app.title https://gitlab.cee.redhat.com/rhidp/cpaas-rhdh-hub/-/blob/rhdh-1.0-rhel-9/distgit/containers/rhdh-hub/app-config.production.yaml#L3

Yes that would be great to parametize this.  Could also add input parameters such as username


Will you open source training or parameter methods and codes?

Hi, Due to certain constraints, we are currently unable to open-source the training-related code. Our experiments were primarily based on the litgpt framework, and the data and training details have been elaborated in our report. We welcome any questions or discussions regarding our work.


Eager realization

This fixes #4. Now, TIFF.jl will fully realize the lazily transformed images before returning them so access times are essentially the same as ImageMagick while preserving a lot of the speed/memory advantages:
Load benchmarking: This PR vs ImageMagick.jl v1.1.6

load time (lower is better)
memory usage during load (lower is better)

It looks like TIFF.jl beats ImageMagick both in load time and memory usage on every test except involving Packbits compression (capitol.tif) and bali.tif where TIFF.jl fails because of #8.
Access times
But now access times are much improved:
julia> using TIFF, ImageMagick, BenchmarkTools

julia> img = TIFF.load("house.tif");

julia> @btime img[1,1];
  17.500 ns (1 allocation: 16 bytes)

julia> img = ImageMagick.load("house.tif");

julia> @btime img[1,1];
  16.990 ns (1 allocation: 16 bytes)

Limitations
There are still some limitations with images with many planes since I lazily transform each plane and then realize them each round. These lazy transforms currently rely on if/else statements, which is not great. I need to explore offloading this work to compile time and dispatch on the TIFF structure.

Codecov Report

Merging #10 (de4d011) into master (751beb0) will increase coverage by 1.87%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   79.78%   81.66%   +1.87%
==========================================
  Files           9        9
  Lines         282      289       +7
==========================================
+ Hits          225      236      +11
+ Misses         57       53       -4

Impacted Files
Coverage Δ

src/TIFF.jl
100.00% <ø> (ø)

src/load.jl
94.64% <100.00%> (+1.02%)
:arrow_up:

src/types/dense.jl
83.33% <100.00%> (+26.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751beb0...de4d011. Read the comment docs.

Codecov Report

Merging #10 (de4d011) into master (751beb0) will increase coverage by 1.87%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   79.78%   81.66%   +1.87%
==========================================
  Files           9        9
  Lines         282      289       +7
==========================================
+ Hits          225      236      +11
+ Misses         57       53       -4

Impacted Files
Coverage Δ

src/TIFF.jl
100.00% <ø> (ø)

src/load.jl
94.64% <100.00%> (+1.02%)
:arrow_up:

src/types/dense.jl
83.33% <100.00%> (+26.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751beb0...de4d011. Read the comment docs.


Update java install instructions.

The documentation at https://voc.readthedocs.io/en/latest/how-to/contribute.html states that you need a Java 7 or Java 8 JDK but the install instructions states at least 7 which can lead people to install Java 10 JDK.

To be honest I have no idea. One reason Java 10 is not in the contribute documentation could be that there are a number of devices not using it but it is just a guess. Or it was not well tested yet with Java 10. Would like to have some input on that from people that are more familiar with it than me.

All we really need to verify this is to try and run a hello world app with Java 10 - it's very much a "it will either work, or break" situation. If it works, we can just say "install a >= 7 JVM".

Update done in the proper place.


German language support for default labels

After the example of @Priler.
Tried to convey original meaning where literal translation seemed insufficient.

Awesome, thanks a lot!


CopySheet() using reflect instead of encoding/gob

Use github.com/mohae/deepcopy (license MIT) to deep copy worksheets with package reflect instead of the internal deepcopy function that was using encoding/gob serialization and
deserialization.

Codecov Report

Merging #155 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   98.47%   98.53%   +0.05%
==========================================
  Files          15       15
  Lines        3219     3213       -6
==========================================
- Hits         3170     3166       -4
+ Misses         30       29       -1
+ Partials       19       18       -1

Impacted Files
Coverage Δ

lib.go
93.1% <ø> (+2.62%)
:arrow_up:

sheet.go
97.7% <100%> (-0.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90998bf...f2b98f0. Read the comment docs.

Could this PR get a review?

Sorry for my late reply, gob is based on reflect mechanism, I think it'is not necessary to introduce this third-party package to instead of gob.

1/ using encoding/gob is much slower than mohae/deepcopy
2/ When building an application this implementation of deepcopy drags the encoding/gob package into the binary which is otherwise not linked. And this package is much bigger than mohae/deepcopy (which only depends on time and reflect).
$ LC_ALL=C stat -f "%6z %N" $(go env GOPATH)/pkg/$(go env GOOS)_$(go env GOARCH)/github.com/mohae/deepcopy.a $(go env GOROOT)/pkg/$(go env GOOS)_$(go env GOARCH)/encoding/gob.a
 10508 .../pkg/darwin_amd64/github.com/mohae/deepcopy.a
541818 .../pkg/darwin_amd64/encoding/gob.a

Thanks for your pull request. As you said, I tested the deepcopy is 10x faster than gob.

Thanks for merging!


Ensure properly synced before marking pilot ready

For https://github.com/istio/istio/issues/24117
Very WIP, need to clean this up a lot

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
3838c7b3664f44c99dfebcdd3a21c43633809779
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
3838c7b3664f44c99dfebcdd3a21c43633809779
link
/test integ-ipv6-k8s-tests_istio

analyze-tests_istio
3838c7b3664f44c99dfebcdd3a21c43633809779
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

not stale


ClassName prop not passed through to nodes/links

Problem: Setting className attribute on nodes or links in data structure not propagated to graph objects.
We are setting the node/link attributes to include a className attribute which is not output on the graph. The assumption was that setting these would propagate to the Node & Link components created. Instead, they have fixed classes of node and link respectively.
Seems that graph.builder.js hardcodes these.
Is this the intent?
(Note: this was in an attempt to get around an issue when inserting new nodes/links into the data structure causes a duplicate key error - perhaps related to #183 )

Currently className property is hardcoded. But if you consume Link or Node then you only need to provide a className prop within the component props and the className is applied. If this is not clear take a look at the source code here graph.helper.js line 132

Thanks, yes we updated graph.helper.js to get around the issue.
Do you plan for the component to actually consume Link & Node components int he future rather than passing in the data prop?

I'm sorry @Codecross, I'm not sure if I understood the question. You're asking if the Graph component will consume Link and Node components? It already does that, check out the render method in Graph.jsx.

Thanks @danielcaldas. What I mean is that all nodes/links must be passed using the direct props (props.data). You can't pass a Node or Link as a child prop (props.children) where you could set the className.
e.g.:
`
<Graph ...>
<Node className='hidden' ... />

`

Hi @Codecross I currently don't have time to look into this issue. Please feel free to submit a PR 🙂


How about adding a Toast Component?

Hey there,
Been playing around with saga-ui and thought – why not have a Toast component? Toasts are like those pop-ups you see when something happens, like a heads-up or a quick "you did this" message.
Basic Ideas:
Variants: Thinking about the usual ones like Success or Error.
Position: Top-right corner seems cool.
Duration: Not too long, not too short. Just enough to read.
Dismiss: A little 'X' or a tap/click to make it go away?
Would love to take a shot at it and see how it goes. What do you think?

Hey there,
Been playing around with saga-ui and thought – why not have a Toast component? Toasts are like those pop-ups you see when something happens, like a heads-up or a quick "you did this" message.
Basic Ideas:
Variants: Thinking about the usual ones like Success or Error. Position: Top-right corner seems cool. Duration: Not too long, not too short. Just enough to read. Dismiss: A little 'X' or a tap/click to make it go away? Would love to take a shot at it and see how it goes. What do you think?

hey thanks for suggesting :)
we have the alert component https://vczb.github.io/sagu-ui/?path=/story/alert--default
maybe the Toast can implement the Alert, as children or something similar
feel free to experiment and figure out the best approach
thanks :rocket:


Check ~/.profile exists before sourcing it

What
Updated one of the commands a user needs to run to setup their environment when ssh-ing onto an instance to be more defensive.
The reason for the change is that bash complains that the file doesn't exist, which, although not a big issue, it could easily be avoided.
How to review

Copy and paste the new command after you ssh'd onto an instance to ensure that existing functionality didn't break.

Who can review
Anyone.

Thanks for this.


7.0.1 Executing script using @include hangs

System information:

Operating system (distribution) and version: Windows 7 Pro SP1 64 bit
DBeaver version: 7.0.1 x64
Additional extensions

Connection specification:

Database name and version Vertica 8.1
Driver name
Do you use tunnels or proxies (SSH, SOCKS, etc)? No

Describe the problem you're observing: SQL script hangs.
Steps to reproduce, if exist: Upgraded to 7.0.1 from 6.2.2.  From SQL Editor execute script from @include.  New tab opens displaying code to execute (normal behavior).  Nothing happens.  Worked prior to upgrade.
example:

from SQL editor execute the following command:  @include 'path name/sql script name'
new SQL editor tab opens displaying code from 'sql script name'
expecting script to begin running but it never does.  No messages of any sort displayed.

Include any warning/errors/backtraces from the logs

Thanks for the bug report

reopened
query execution is endless in case script that mentioned in path is already opened

Fixed

reopened
script isn't executed at first attempt (if tab with script is closed)

Fixed

Reopened.
Script that opens in new tab isn't executed automatically. It could be executed manually only

Hi.  Is there an ETA for fixing this bug?

Hi. Is there an ETA for fixing this bug?

hope, the issue will be fixed in the scope of #13180.
Close this issue


Warning in can_dbc_parser

I came across this warning in this Autoware.Auto CI job
--- stderr: can_dbc_parser
/builds/autowarefoundation/autoware.auto/AutowareAuto/src/external/new_eagle_raptor/can_dbc_parser/src/DbcMessage.cpp: In member function ‘void NewEagle::DbcMessage::SetFrame(can_msgs::msg::Frame_<std::allocator<void> >::SharedPtr)’:
/builds/autowarefoundation/autoware.auto/AutowareAuto/src/external/new_eagle_raptor/can_dbc_parser/src/DbcMessage.cpp:168:33: warning: ‘muxSwitch’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  168 |         if (muxSwitch->GetResult() == it->second.GetMultiplexerSwitch()) {
      |             ~~~~~~~~~~~~~~~~~~~~^~
/builds/autowarefoundation/autoware.auto/AutowareAuto/src/external/new_eagle_raptor/can_dbc_parser/src/DbcMessage.cpp: In member function ‘can_msgs::msg::Frame NewEagle::DbcMessage::GetFrame()’:
/builds/autowarefoundation/autoware.auto/AutowareAuto/src/external/new_eagle_raptor/can_dbc_parser/src/DbcMessage.cpp:122:33: warning: ‘muxSwitch’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  122 |         if (muxSwitch->GetResult() == it->second.GetMultiplexerSwitch()) {
      |             ~~~~~~~~~~~~~~~~~~~~^~
---

Please fix it and let us know when fixed so we can update our dependency in https://gitlab.com/autowarefoundation/autoware.auto/AutowareAuto/-/blob/master/autoware.auto.foxy.repos . Or has this warning been fixed already and we should just upgrade?
Thanks!

Thanks for pointing this out! I'm working on a fix right now, & will release it as soon as it's tested.

Thanks for your patience. Fix is released as tag foxy-1.1.1.

Merge request made to Autoware to update version of raptor-dbw-ros2:
https://gitlab.com/autowarefoundation/autoware.auto/AutowareAuto/-/merge_requests/1094


Fix for User Stories table in DG: Attempt 1

Currently, the table isn't being rendered properly.
I have no idea why.
So I'm going to conduct trial and error :D

Codecov Report
Base: 66.35% // Head: 66.35% // No change to project coverage :thumbsup:

Coverage data is based on head (1f466a7) compared to base (30086a3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage     66.35%   66.35%
  Complexity      568      568
=========================================
  Files            88       88
  Lines          1935     1935
  Branches        235      235
=========================================
  Hits           1284     1284
  Misses          567      567
  Partials         84       84

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


--no-extract doesn't work

--no-extract causes errors, because selection of individuals is still performed on the ind-file, but not on the genotype-file. I'll take care of it. Just a reminder to self.

Closed in #215


improve CanvasLinePlot API

CanvasLinePlot is a high-performance way of drawing multiple plots using CanvasNode.   Some issues with the API:
(1) The name is CanvasLinePlot (singular), when it's capable of drawing multiple plots. Rename to CanvasLinePlots (plural)?
(2) The style (stroke, lineWidth,...) of the plots is hardcoded, and all of the plots are rendered in the same style. The API needs a way to describe the style per plot. For example, Fourier uses a different stroke for each plot.
(3) Plot styles need to be mutable.  For example, Fourier changes the plot strokes to grayscale when you pointer-over one of the amplitude sliders.
(4) The current hardcoded lineWidth is 0.1.  That appears to be specific to DemoCanvasLinePlot, and is unlikely to be appropriate elsewhere.
Assigning to @samreid to discuss what needs to be included for "plot style".  Definitely stroke and lineWidth.
I'll be using this in Fourier immediately.

How about something like this?
// Default plot style
const DEFAULT_STYLE = {
  stroke: 'black',
  lineWidth: 1
};

  constructor( chartModel, dataSets, options ) {

    options = merge( {

      // {{stroke:ColorDef, lineWidth:number}[]} one per dataSet, unspecified entries are filled in with DEFAULT_STYLE
      styles: []
    }, options );

    assert && assert( options.styles.length <= dataSets.length, 'too many entries in options.styles' );
    for ( let i = 0; i < dataSets.length; i++ ) {
      options.styles[ i ] = merge( {}, DEFAULT_STYLE, options.styles[ i ] || {} );
    }

    // @public if you change this directly, you are responsible for calling update
    this.styles = options.styles;

I have a more general proposal that will be ready to share shortly.

@samreid and I discussed his more general approach on Slack.  Basically a ChartCanvasNode that extends CanvasNode, has the view bounds of the ChartModel, and can draw a set of CanvasPaintables (or whatever they were called :)  that implenment paintCanvas( context ).  This approach looks really nice, definitely superior to my above proposal, and @samreid will continue to flesh it out.

I committed a first draft of this, @pixelzoom can you please review and test at your convenience?

(1) The name is CanvasLinePlot (singular), when it's capable of drawing multiple plots. Rename to CanvasLinePlots (plural)?

@samreid your thoughts on this?

ChartCanvasLinePlot renders one data set.  ChartCanvasNode renders multiple CanvasPainter instances.

Got it, thanks for clarifying.

@samreid FYI, a few changes in the above commits.
ChartCanvasLinePlot had a broken dispose method, looked like a copy-paste from LinePlot, so I deleted it.
ChartCanvasLinePlot didn't seem like the correct name, so I renamed to CanvasLinePlot --- the Canvas version of LinePlot.
ChartCanvasNode doesn't strike me as the best name, but I haven't thought of a better one yet.  We want a name that says "responsible for drawing CanvasPainter instances" (assuming CanvasPainter is the best name).
Onward to integrating this into Fourier.

One more thing that I changed accidentally (playing around) and reverted...
ChartCanvasLinePlot does not support {ColorDef} for options.stroke.  In Fourier, the line plot colors are Properties, and are update dynamically.

Hmm... ChartCanvasLinePlot apparent doesn't even support {Color} stroke.   So I had to convert my colors to Color for PhET-iO, then convert them back to CSS for ChartCanvasLinePlot.
Which parts of {ColorDef} should ChartCanvasLinePlot support?

How about adding ColorDef.toCSS for starters?  I'm not sure about listening for changes if it is a property--doesn't seem the responsibility of CanvasLinePlot.

I had hoped to use this to improve performance in Fourier, especially while animating in "space & time" domain). But when adjusting amplitudes with sliders (for example) using CanvasLinePlot requires redrawing all of the plots that are managed by the CanvasChartNode. LinePlot allows me to redraw only the plot that is changing.  So I'm not sure that this is going to be a "win".

First of all, calling paintCanvas on many curves is much faster than changing a LinePlot path shape and re-rendering it.
Secondly, in Fourier (at least in Java), in the "space and time" harmonics chart, all curves are moving (not just one).

Indeed, it's not an issue when all of the curves are animating, because they all need to be redrawn. I said it's an issue "when adjusting amplitude with a slider", which requires updating 1 plot.   And to be clear, I'm still going down this path, just didn't realize that if any plot changes, I have to redraw all plots.

Indeed, it's not a problem when all of the curves are animating, because they all need to be redrawn. I said it's an issue "when adjusting amplitude with a slider", which requires updating 1 plot.   And to be clear, I'm still going down this path, just didn't realize that if any plot changes, I have to redraw all plots.  That's a significant change in the Fourier code, which is currently optimized to draw only the plots that have actually changes.

ChartCanvasNode + CanvasLinePlot is much faster than LinePlot in Fourier.
Fourier always has 11 plots (one for each possible harmonic).  Only the relevant ones should be drawn (based on numberOfHarmonicsProperty) and only if their amplitude is !== 0.
Thoughts on how to change the visibility of CanvasLinePlot specifically, and CanvasPainter generally?  Do I need to change ChartCanvasNode this.painters and call update?

This is all working nicely in Fourier, with very excellent performance on my MacBook Pro (MacbookPro16,1), iPad 6, and iPhone 11.
Remaining items for this issue:

[ ] Support for more than {string} stroke in CanvasLinePlot
[ ] Support for visibility in CanvasLinePlot/CanvasPaintable, or leave it up to clients, as I've done in HarmonicPlot?
[ ] A better name for ChartCanvasNode

I'm not sure that I like adding link, unlink, and toCSS to ColorDef for this.   @jonathanolson could you please weigh in?

I'm not sure that I like adding link, unlink, and toCSS to ColorDef for this.   @jonathanolson could you please weigh in?
And there's still the problem of calling ChartCanvasNode update when a CanvasLinePlot's stroke Property changes. I don't think that CanvasLinePlot should be responsible for that, but I'd like to hear what the recommended pattern is.

This looks like a case where PaintColorProperty could be used (similar to how baseColor is handled in buttons), then just link to that in one place.

I think that @jonathanolson is probably referring to the uses of PaintColorProperty in sun ButtonNode, see relevant definitions below. But I'm having a hard time apply this to CanvasLinePlot.
    // @private - Support baseColor being effected by enabled, while still allowing setting the base color.
    this._settableBaseColorProperty = new PaintColorProperty( options.baseColor );

    // @private
    this._disabledColorProperty = new PaintColorProperty( options.disabledColor );

I think that @jonathanolson is probably referring to the uses of PaintColorProperty in sun ButtonNode, see relevant definitions below. But I'm having a hard time relating this to CanvasLinePlot.
    // @private - Support baseColor being effected by enabled, while still allowing setting the base color.
    this._settableBaseColorProperty = new PaintColorProperty( options.baseColor );

    // @private
    this._disabledColorProperty = new PaintColorProperty( options.disabledColor );

I'm also not convinced that we want to introduce PaintDef into CanvasLinePlot.  Do we really want to support Gradients and other PaintDefs?

I followed @jonathanolson's recommendation, and it seemed straightforward and a good fit for CanvasLinePlot.

Index: bamboo/js/CanvasLinePlot.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/bamboo/js/CanvasLinePlot.js b/bamboo/js/CanvasLinePlot.js
--- a/bamboo/js/CanvasLinePlot.js	(revision 9c0ca2a6d47667fe94c905b6b22ea11502fa32f5)
+++ b/bamboo/js/CanvasLinePlot.js	(date<PHONE_NUMBER>033)
@@ -8,7 +8,7 @@
  */

 import merge from '../../phet-core/js/merge.js';
-import ColorDef from '../../scenery/js/util/ColorDef.js';
+import PaintColorProperty from '../../scenery/js/util/PaintColorProperty.js';
 import bamboo from './bamboo.js';
 import CanvasPainter from './CanvasPainter.js';

@@ -35,18 +35,7 @@
     this.dataSet = dataSet;

     // @private
-    this._stroke = null;
-
-    // @private {string|null} - cache values of CSS so they don't need to be recomputed at each paint
-    this._strokeCSS = null;
-
-    // @private
-    this.colorListener = stroke => {
-      this._strokeCSS = ColorDef.toCSS( stroke );
-      assert && assert( typeof this._strokeCSS === 'string' || this._strokeCSS === null );
-    };
-
-    this.setStroke( options.stroke );
+    this.strokePaintColorProperty = new PaintColorProperty( options.stroke );

     // @public if you change this directly, you are responsible for calling update on the corresponding ChartCanvasNode
     this.lineWidth = options.lineWidth;
@@ -54,12 +43,7 @@

   // @public - Sets the stroke. You are responsible for calling update on the associated ChartCanvasNode(s).
   setStroke( stroke ) {
-    assert && assert( ColorDef.isColorDef( stroke ), 'must be a ColorDef' );
-    if ( stroke !== this._stroke ) {
-      ColorDef.unlink( this._stroke, this.colorListener );
-      this._stroke = stroke;
-      ColorDef.link( this._stroke, this.colorListener ); // caches the new color CSS
-    }
+    this.strokePaintColorProperty.value = stroke;
   }

   // @public - see setStroke()
@@ -70,7 +54,7 @@
   // @public
   dispose() {
     assert && assert( !this.isDisposed, 'already disposed' );
-    ColorDef.unlink( this._stroke, this.colorListener );
+    this.strokePaintColorProperty.dispose();
     this.isDisposed = true;
   }

@@ -89,19 +73,16 @@
    * @public
    */
   paintCanvas( context ) {
-    assert && assert( typeof this._strokeCSS === 'string' || this._strokeCSS === null, 'stroke must be a CSS string or null' );
-    if ( this._strokeCSS !== null ) {
-      context.beginPath();
-      context.strokeStyle = this._strokeCSS;
-      context.lineWidth = this.lineWidth;
+    context.beginPath();
+    context.strokeStyle = this.strokePaintColorProperty.value.toCSS();
+    context.lineWidth = this.lineWidth;

-      for ( let i = 0; i < this.dataSet.length; i++ ) {
-        const point = this.chartTransform.modelToViewPosition( this.dataSet[ i ] );
-        i === 0 && context.moveTo( point.x, point.y );
-        i !== 0 && context.lineTo( point.x, point.y );
-      }
-      context.stroke();
-    }
+    for ( let i = 0; i < this.dataSet.length; i++ ) {
+      const point = this.chartTransform.modelToViewPosition( this.dataSet[ i ] );
+      i === 0 && context.moveTo( point.x, point.y );
+      i !== 0 && context.lineTo( point.x, point.y );
+    }
+    context.stroke();
   }
 }

This works great in the Bamboo demo for ?component=ChartCanvasNode.  However, in Fourier HarmonicsChart.js there is a place that sets a stroke value to be a property: plot.setStroke( plot.harmonic.colorProperty );, which fails at runtime.
@jonathanolson does PaintColorProperty support nested Property values like PaintDef and ColorDef do?

... However, in Fourier HarmonicsChart.js there is a place that sets a stroke value to be a property: plot.setStroke( plot.harmonic.colorProperty );, which fails at runtime.

I was thinking that it would be nice if CanvasLinePlot supported the same types of "color" values as LinePlot.  Since LinePlot extends Path, that includes stroke: someColorProperty.    But since CanvasLinePlot has no way to notify its associated ChartCanvasNode that a color Property has changed, maybe we don't want to support color Property in CanvasLinePlot, and require clients to manage changes to the color Property, like:
const plotColorProperty = new Property( Color.red );
const plot = new CanvasLinePlot( ..., {
  stroke: plotColorProperty.value
} );
const chartCanvasNode = new ChartCanvasNode(..., [  plot ], ...);

// When the plot's color changes...
plotColorProperty.link( plotColor => {
  plot.stroke = plotColor;
  chartCanvasNode.update();
} );

I think the recommendation from the preceding comment is good, I considered the alternative of making the CanvasLinePlot aware of its associated ChartCanvasNode(s) or vice-versa. I'm happy to apply the patch from https://github.com/phetsims/bamboo/issues/16#issuecomment-751163054.  Would you like me to update Fourier as described in https://github.com/phetsims/bamboo/issues/16#issuecomment-751910556 at the same time?

I'm happy to apply the patch from #16 (comment). Would you like me to update Fourier as described in #16 (comment) at the same time?

Sounds good. There will be some stuff removed from ColorDef too, correct?  Yes please update Fourier.

In the commits I converted CanvasLinePlot to use PaintColorProperty and updated Fourier accordingly.  I split up the update function so that the strokes could be updated independently.  It appeared to be working properly in my testing, but I am not fully familiar with this sim, so please test again.  These commits are ready for review.

There will be some stuff removed from ColorDef too, correct?

The additions made to ColorDef seem like they may one day be useful, even though they are unconventional.  Still, since we don't have an immediate need for them, I'll remove them for now.

In the commits I converted CanvasLinePlot to use PaintColorProperty and updated Fourier accordingly.  I split up the update function so that the strokes could be updated independently.  It appeared to be working properly in my testing, but I am not fully familiar with this sim, so please test again.  These commits are ready for review.

There will be some stuff removed from ColorDef too, correct?

The additions made to ColorDef seem like they may one day be useful, even though they are unconventional.  Still, since we don't have an immediate need for them, I'll remove them for now.

In the commits I converted CanvasLinePlot to use PaintColorProperty and updated Fourier accordingly. I split up the update function so that the strokes could be updated independently. It appeared to be working properly in my testing, but I am not fully familiar with this sim, so please test again.

If you're not familiar with a sim, it's generally not a good idea to change logic that you don't need to touch.
In this case, stroke and lineWidth are never to be updated independently, they always update together.  This change was unnecesary and undesirable. More importantly, it's making it difficult for me to identify what was actually necessary to change.

In the commits I converted CanvasLinePlot to use PaintColorProperty and updated Fourier accordingly. I split up the update function so that the strokes could be updated independently. It appeared to be working properly in my testing, but I am not fully familiar with this sim, so please test again.

If you're not familiar with a sim, it's generally not a good idea to change logic that you don't need to touch.
In this case, stroke and lineWidth are never to be updated independently, they always update together.  This change was unnecesary and undesirable. More importantly, it's making it difficult for me to identify what was actually necessary to change.

Are you saying that if a harmonicPlot.colorProperty changes, you would like to set the strokes to their current values?  I'm happy to recombine the updates if you think it's better for the sim, reassign me if you would like me to do something like that.

Are you saying that if a harmonicPlot.colorProperty changes, you would like to set the strokes to their current values?  I'm happy to recombine the updates if you think it's better for the sim, reassign me if you would like me to do something like that.

Yes. Reverted in the previous commit.
Reviewing the changes to CanvasLinePlot.

[ ] setStroke is missing doc for @param stroke.  What types are acceptable for stroke - ColorDef, PaintDef, some subset? Since you're using PaintColorProperty, I would have expected this to be OK:

 plot.setStroke( plot.harmonic.colorProperty );
but it fails, and you changed to:
 plot.setStroke( plot.harmonic.colorProperty.value );

Yes. Reverted in the previous commit.
Reviewing the changes to CanvasLinePlot.

[ ] setStroke is missing doc for @param stroke.  What types are acceptable for stroke - ColorDef, PaintDef, some subset? Since you're using PaintColorProperty, I would have expected this to be OK:

 plot.setStroke( plot.harmonic.colorProperty );
but it fails, and you changed to:
 plot.setStroke( plot.harmonic.colorProperty.value );

Are you saying that if a harmonicPlot.colorProperty changes, you would like to set the strokes to their current values?

Oh I see... You're saying that I need to call setStroke if colorProperty changes -- which can happen via colors.html or (perhaps) PhET-iO.   Yes, I need to handle that.

Are you saying that if a harmonicPlot.colorProperty changes, you would like to set the strokes to their current values?

Oh I see... You're saying that I need to call setStroke if colorProperty changes -- which can happen via colors.html or (perhaps) PhET-iO.   Yes, I need to handle that.

In the commit, I added PaintDef support in CanvasLinePlot.setStroke and added documentation.  I updated Fourier to call with plot.setStroke( plot.harmonic.colorProperty ); instead of plot.setStroke( plot.harmonic.colorProperty.value );.  The last part that's missing is a call to chartCanvasNode.update(); if a colorProperty value changes. Would you like me to add that part?

In the commit, I added PaintDef support in CanvasLinePlot.setStroke and added documentation.  I updated Fourier to call with plot.setStroke( plot.harmonic.colorProperty ); instead of plot.setStroke( plot.harmonic.colorProperty.value );.  The last part that's missing is a call to chartCanvasNode.update(); if a colorProperty value changes. Would you like me to add that part?

... Yes, I need to handle that.  ...

It was already handled elsewhere. I factored it out so that it's more obvious.

... Yes, I need to handle that.  ...

It was already handled elsewhere. I factored it out so that it's more obvious.

It was already handled elsewhere. I factored it out so that it's more obvious.

I see it now, thanks!

It was already handled elsewhere. I factored it out so that it's more obvious.

I see it now, thanks!

In the above commit, I chose to use colorProperty.value wherever setStroke is called.
I find this to be confusing:
      const colorProperty = new Property( Color.black );
      const plot = new CanvasLinePlot( ..., {
        stroke: colorProperty // this causes plot to listen to colorProperty
      } );
      const chartCanvasNode = new ChartCanvasNode( ..., [ plot ], ... );
      // CanvasLinePlot is observing colorProperty, so we only need to call update.
      colorProperty.lazyLink( () => chartCanvasNode.update() );

It suspect that developers won't totally understand what is going on with stroke and PaintColorProperty, and will tend to write of these dubious listeners:
      colorProperty.lazyLink( color => {
        plot.setStroke( color );  // this causes plot to no longer listen to colorProperty
        chartCanvasNode.update()
     } );

// or
      colorProperty.lazyLink( () => {
        plot.setStroke( colorProperty ); // this does nothing because useDeepEquality: false in CanvasLinePlot
        chartCanvasNode.update()
     } );

This feels clearer and less error-prone:
      const colorProperty = new Property( Color.black );
      const plot = new CanvasLinePlot( harmonic, this.chartTransform, [], {
        stroke:  colorProperty.value
      } );
      const chartCanvasNode = new ChartCanvasNode( ..., [ plot ], ... );
      colorProperty.lazyLink( color => {
        plot.stroke = color;
        chartCanvasNode.update();
      } );

So... And I'm thinking that we might want to revert PaintColorProperty, and restrict stroke to be {Color|string|null}.   And if not, I'll probably avoid passing a stroke Property to CanvasLinePlot, because imo it tends to obfuscate things.

In the above commit, I chose to use colorProperty.value wherever setStroke is called.
I find this to be confusing:
      const colorProperty = new Property( Color.black );
      const plot = new CanvasLinePlot( ..., {
        stroke: colorProperty // this causes plot to listen to colorProperty
      } );
      const chartCanvasNode = new ChartCanvasNode( ..., [ plot ], ... );
      // CanvasLinePlot is observing colorProperty, so we only need to call update.
      colorProperty.lazyLink( () => chartCanvasNode.update() );

It suspect that developers won't totally understand what is going on with stroke and PaintColorProperty, and will tend to write of these dubious listeners:
      colorProperty.lazyLink( color => {
        plot.setStroke( color );  // this causes plot to no longer listen to colorProperty
        chartCanvasNode.update()
     } );

// or
      colorProperty.lazyLink( () => {
        plot.setStroke( colorProperty ); // this does nothing because useDeepEquality: false in CanvasLinePlot
        chartCanvasNode.update()
     } );

This feels clearer and less error-prone:
      const colorProperty = new Property( Color.black );
      const plot = new CanvasLinePlot( harmonic, this.chartTransform, [], {
        stroke:  colorProperty.value
      } );
      const chartCanvasNode = new ChartCanvasNode( ..., [ plot ], ... );
      colorProperty.lazyLink( color => {
        plot.stroke = color;
        chartCanvasNode.update();
      } );

So... And I'm thinking that we might want to revert PaintColorProperty, and restrict stroke to be {Color|string|null}.   And if not, I'll probably avoid passing a stroke Property to CanvasLinePlot, because imo it tends to obfuscate things.

@samreid and I discussed the above comment, and agreed that constraining stroke to {Color|string|null} would be preferrable.  I made some good progress on that, then got bogged down in the inconsistencies of how "color" is handled by Color, ColorDef, PaintDef, PaintColorProperty, etc.   I briefly discussed with @jonathanolson on Slack, but he's not up to speed.  So I bailed.

@samreid and I discussed the above comment, and agreed that constraining stroke to {Color|string|null} would be preferrable.  I made some good progress on that, then got bogged down in the inconsistencies of how "color" is handled by Color, ColorDef, PaintDef, PaintColorProperty, etc.   I briefly discussed with @jonathanolson on Slack, but he's not up to speed.  So I bailed.

Here's an implementation that uses {Color|string|null} (full file, not a diff).  It also caches the CSS for high performance.

// Copyright 2020, University of Colorado Boulder

/**
 * CanvasLinePlot renders a {Array<Vector2|null>} dataSet on a canvas that is managed by a ChartCanvasNode.
 * Typically it is preferable to use LinePlot, but this alternative is provided for cases where canvas must be
 * used for performance. Like LinePlot, null values are skipped, and allow you to create gaps in a plot.
 * @see LinePlot
 *
 * @author Sam Reid (PhET Interactive Simulations)
 */

import merge from '../../phet-core/js/merge.js';
import Color from '../../scenery/js/util/Color.js';
import bamboo from './bamboo.js';
import CanvasPainter from './CanvasPainter.js';

class CanvasLinePlot extends CanvasPainter {

  /**
   * @param {ChartTransform} chartTransform
   * @param {Array<Vector2|null>} dataSet
   * @param {Object} [options]
   */
  constructor( chartTransform, dataSet, options ) {

    options = merge( {
      stroke: 'black', // {Color|string|null}
      lineWidth: 1
    }, options );

    super();

    // @private
    this.chartTransform = chartTransform;

    // @public if you change this directly, you are responsible for calling update on the corresponding ChartCanvasNode
    this.dataSet = dataSet;

    // @public if you change this directly, you are responsible for calling update on the corresponding ChartCanvasNode
    this.lineWidth = options.lineWidth;

    // @private - CSS for rendering the stroke
    this.strokeCSS = null; // updated in setStroke
    this.setStroke( options.stroke );
  }

  /**
   * Sets the stroke.
   * @param {Color|string|null} stroke - If you call setStroke, you are responsible for calling update on the associated ChartCanvasNode(s).
   * @public
   */
  setStroke( stroke ) {
    assert && assert( stroke instanceof Color || typeof stroke === 'string' || stroke === null, 'invalid stroke' );
    this.strokeCSS = stroke instanceof Color ? stroke.toCSS() : stroke;
  }

  // @public - see setStroke()
  set stroke( stroke ) {
    this.setStroke( stroke );
  }

  // @public
  dispose() {
    assert && assert( !this.isDisposed, 'already disposed' );
    this.isDisposed = true;
  }

  /**
   * Sets dataSet. You are responsible for calling update on the associated ChartCanvasNode(s).
   * @param {Vector2[]} dataSet
   * @public
   */
  setDataSet( dataSet ) {
    this.dataSet = dataSet;
  }

  /**
   * Intended to be called by ChartCanvasNode.
   * @param {CanvasRenderingContext2D} context
   * @public
   */
  paintCanvas( context ) {
    context.beginPath();

    if ( this.strokeCSS ) {
      context.strokeStyle = this.strokeCSS;
      context.lineWidth = this.lineWidth;

      let moveToNextPoint = true;

      // Only access the data set length once for performance
      const length = this.dataSet.length;
      for ( let i = 0; i < length; i++ ) {

        const dataPoint = this.dataSet[ i ];
        assert && assert( dataPoint === null || dataPoint.isFinite(), 'data points must be finite Vector2 or null' );

        // Draw a line segment to the next non-null value. Null values result in a gap (via move) in the plot.
        if ( dataPoint ) {
          const viewPoint = this.chartTransform.modelToViewPosition( dataPoint );
          if ( moveToNextPoint ) {
            context.moveTo( viewPoint.x, viewPoint.y );
            moveToNextPoint = false;
          }
          else {
            context.lineTo( viewPoint.x, viewPoint.y );
          }
        }
        else {
          moveToNextPoint = true;
        }
      }
      context.stroke();
    }
  }
}

bamboo.register( 'CanvasLinePlot', CanvasLinePlot );
export default CanvasLinePlot;

@pixelzoom does that look OK to you?  Will Fourier need to be updated if we go with this approach?

Here's an implementation that uses {Color|string|null} (full file, not a diff).  It also caches the CSS for high performance.

// Copyright 2020, University of Colorado Boulder

/**
 * CanvasLinePlot renders a {Array<Vector2|null>} dataSet on a canvas that is managed by a ChartCanvasNode.
 * Typically it is preferable to use LinePlot, but this alternative is provided for cases where canvas must be
 * used for performance. Like LinePlot, null values are skipped, and allow you to create gaps in a plot.
 * @see LinePlot
 *
 * @author Sam Reid (PhET Interactive Simulations)
 */

import merge from '../../phet-core/js/merge.js';
import Color from '../../scenery/js/util/Color.js';
import bamboo from './bamboo.js';
import CanvasPainter from './CanvasPainter.js';

class CanvasLinePlot extends CanvasPainter {

  /**
   * @param {ChartTransform} chartTransform
   * @param {Array<Vector2|null>} dataSet
   * @param {Object} [options]
   */
  constructor( chartTransform, dataSet, options ) {

    options = merge( {
      stroke: 'black', // {Color|string|null}
      lineWidth: 1
    }, options );

    super();

    // @private
    this.chartTransform = chartTransform;

    // @public if you change this directly, you are responsible for calling update on the corresponding ChartCanvasNode
    this.dataSet = dataSet;

    // @public if you change this directly, you are responsible for calling update on the corresponding ChartCanvasNode
    this.lineWidth = options.lineWidth;

    // @private - CSS for rendering the stroke
    this.strokeCSS = null; // updated in setStroke
    this.setStroke( options.stroke );
  }

  /**
   * Sets the stroke.
   * @param {Color|string|null} stroke - If you call setStroke, you are responsible for calling update on the associated ChartCanvasNode(s).
   * @public
   */
  setStroke( stroke ) {
    assert && assert( stroke instanceof Color || typeof stroke === 'string' || stroke === null, 'invalid stroke' );
    this.strokeCSS = stroke instanceof Color ? stroke.toCSS() : stroke;
  }

  // @public - see setStroke()
  set stroke( stroke ) {
    this.setStroke( stroke );
  }

  // @public
  dispose() {
    assert && assert( !this.isDisposed, 'already disposed' );
    this.isDisposed = true;
  }

  /**
   * Sets dataSet. You are responsible for calling update on the associated ChartCanvasNode(s).
   * @param {Vector2[]} dataSet
   * @public
   */
  setDataSet( dataSet ) {
    this.dataSet = dataSet;
  }

  /**
   * Intended to be called by ChartCanvasNode.
   * @param {CanvasRenderingContext2D} context
   * @public
   */
  paintCanvas( context ) {
    context.beginPath();

    if ( this.strokeCSS ) {
      context.strokeStyle = this.strokeCSS;
      context.lineWidth = this.lineWidth;

      let moveToNextPoint = true;

      // Only access the data set length once for performance
      const length = this.dataSet.length;
      for ( let i = 0; i < length; i++ ) {

        const dataPoint = this.dataSet[ i ];
        assert && assert( dataPoint === null || dataPoint.isFinite(), 'data points must be finite Vector2 or null' );

        // Draw a line segment to the next non-null value. Null values result in a gap (via move) in the plot.
        if ( dataPoint ) {
          const viewPoint = this.chartTransform.modelToViewPosition( dataPoint );
          if ( moveToNextPoint ) {
            context.moveTo( viewPoint.x, viewPoint.y );
            moveToNextPoint = false;
          }
          else {
            context.lineTo( viewPoint.x, viewPoint.y );
          }
        }
        else {
          moveToNextPoint = true;
        }
      }
      context.stroke();
    }
  }
}

bamboo.register( 'CanvasLinePlot', CanvasLinePlot );
export default CanvasLinePlot;

@pixelzoom does that look OK to you?  Will Fourier need to be updated if we go with this approach?

Looks good, but I would suggest one change:
- assert && assert( stroke instanceof Color || typeof stroke === 'string' || stroke === null, 'invalid stroke' );
+ assert && assert( stroke instanceof Color || ( typeof stroke === 'string' && Colorr.isCSSString( stroke ) ) || stroke === null, 'invalid stroke' );

I've confirmed that no changes to Fourier are required.

Looks good, but I would suggest one change:
- assert && assert( stroke instanceof Color || typeof stroke === 'string' || stroke === null, 'invalid stroke' );
+ assert && assert( stroke instanceof Color || ( typeof stroke === 'string' && Colorr.isCSSString( stroke ) ) || stroke === null, 'invalid stroke' );

I've confirmed that no changes to Fourier are required.

I made the change (with the CSS string test) and tested in Fourier.  No problems noted, closing.

I made the change (with the CSS string test) and tested in Fourier.  No problems noted, closing.


fix: testing code samples

Description
Noticed the code samples aren't working, submitting a quick fix.

For contributor use:

[x] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

Thank you for spotting those, @alxflw !


Fix mobile homepage jumping

Fixes

Fixes #1298 by @obulat
Description

This PR fixes the layout jumping on the mobile page:

it sets the min-height to the ClientOnly image row.
it sets the searchbar height to fixed value, and use h-full in child components.

Testing Instructions

Run the app, go to the homepage localhost:8443. The layout should not jump. Try different screen widths.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal and @dhruvkb could you review this PR when you get a chance?


Increase instance state timeout

especially when AEM is starting after creating sometimes if needs more time when dev machine is under more heavy load.

merged to develop


"Could not connect to the server" using Supabase in AppClip.

Describe the bug
I tried to fetch an object from my database in my AppClip but I keep getting a network error "Could not connect to the server"
The same fetch method works perfectly fine in my full app. I've had this problem before with Firebase so the solution was to use cloud functions instead to fetch objects in my appclip. So I wrote an Edge function to do the job, the same edge function works in my full app but fails in my app clip.
To Reproduce

Create an app clip in your xcode project
Fetch any object from your database using the client side sdk methods in the app clip (It will fail)
Fetch the same object by invoking an edge function in your app clip (It will fail)
But both will work in your full app.

Error Message

Error Domain=NSURLErrorDomain Code=-1004 "Could not connect to the server." UserInfo={_kCFStreamErrorCodeKey=65, NSUnderlyingError=0x301ec8000 {Error Domain=kCFErrorDomainCFNetwork Code=-1004 "(null)" UserInfo={_NSURLErrorNWPathKey=satisfied (Path is satisfied), interface: en0[802.11], ipv4, ipv6, dns, uses wifi, _kCFStreamErrorCodeKey=65, _kCFStreamErrorDomainKey=1}}, _NSURLErrorFailingURLSessionTaskErrorKey=LocalDataTask <6E5F83CB-4AC2-4597-AD9C-A2D80E1CB556>.<1>, _NSURLErrorRelatedURLSessionTaskErrorKey=(
"LocalDataTask <6E5F83CB-4AC2-4597-AD9C-A2D80E1CB556>.<1>"
), NSLocalizedDescription=Could not connect to the server., NSErrorFailingURLStringKey=https://[DATABASE ID].supabase.co/functions/v1/invite, NSErrorFailingURLKey=https://[DATABASE ID].supabase.co/functions/v1/invite, _kCFStreamErrorDomainKey=1}

System information

OS: iOS 17 Supabase 2.8.5, Xcode 15.4

Its working now, and I have no clue why.


[Discussion] Deactivating new-cap rule (Immutable.js user)

Hello!
I just tried out create-react app and it's pretty cool! However, I'm an heavy user of Immutable and the eslint new-cap rule does not behave well with it (activated by default).
For now, I'm deactivating the rule on a per-file basis so that's not such a big issue! But I can't seem to be able to deactivate it project-wide in the package.json (it actually works on my editor, but not on the dev server ...).
To tackle this issue, I see two possibilities:

Find a way to get the dev server reading the project's eslint configuration in package.json (that would be cool to have that working anyway! => I'll try to take a look myself 😉 if it's possible)
Have a discussion around the new-cap rule that isn't universally liked (and discouraged when used with immutable, I'll point to you one comment from @leebyron on this: https://github.com/eslint/eslint/issues/2023#issuecomment-80255655, not saying we should get rid of it because he said so but I'd like to see what others think about it too!)

Thank you again for this project, hope this discussion will help make it even better!

We should disable that rule. It shouldn't have been in our config in the first place.

Happy to merge a PR that disables it.

@gaearon Was planning to do that 😉, lemme just finish a small thing at work here…

@gaearon, that didn't took much time anyway so here it: #470

Why don't you add an exception for Immutable?
"new-cap": [2, { "capIsNewExceptionPattern" : "^Immutable\\.." }]

PS: About immutable new-cap convention: https://github.com/facebook/immutable-js/issues/10

We don't want to special-case Immutable here, IMO it would just be more confusing.


Need the notification but not in notification tray (IOS).

"react-native": "0.40.0"
IPhone ( In the android it is working fine )
App is running in foreground.
Description:
We are sending the message with this format:
"notification": {
"title": "hello",
"body": "yo",
"click_action": "fcm.ACTION.HELLO"
}
Everything is working fine. But I don't want the notification come in notification tray(popup) but need the notification for data update. How can I do this? What object I have to send for this?
Important: I am not using presentLocalNotification. @evollu please can you help in this matter? Is it all about body or anything else?

Hi,
We are sending custom data,  then we get the solution.
"data": {
"ABC": "ABC",
}


Auto refresh countdown feature for Swap view

reload transfer routes after x seeconds from the server to guarantee best swapping routes at all times.
similar to
https://app.1inch.io/#/1/swap/USDC/DAI

Transferred to Jira