[SPARK-9580] [SQL] [WIP] Replace singletons in SQL tests

A fundamental limitation of the existing SQL tests is that there is simply no way to create your own SparkContext. This is a serious limitation because the user may wish to use a different master or config. As a case in point, BroadcastJoinSuite is entirely commented out because there is no way to make it pass with the existing infrastructure.
This patch removes the singletons TestSQLContext and TestData, and instead introduces a SharedSQLContext that starts a context per suite. Unfortunately the singletons were so ingrained in the SQL tests that this patch necessarily needed to touch all the SQL test files.

Merged build triggered.

Merged build started.

Test build #40506 has started for   PR 8111 at commit 9395cfa.

Test build #40506 has finished for   PR 8111 at commit 9395cfa.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SQLTransformer (override val uid: String) extends Transformer
 implicit class StringToColumn(val sc: StringContext)

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #40512 has started for   PR 8111 at commit 997715e.

Test build #40512 has finished for   PR 8111 at commit 997715e.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)
case class EqualNullSafe(attribute: String, value: Any) extends Filter

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #40513 has started for   PR 8111 at commit 1400770.

Test build #1458 has started for   PR 8111 at commit 1400770.

Test build #1459 has started for   PR 8111 at commit 1400770.

Test build #40513 has finished for   PR 8111 at commit 1400770.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SQLTransformer (override val uid: String) extends Transformer
 implicit class StringToColumn(val sc: StringContext)
case class EqualNullSafe(attribute: String, value: Any) extends Filter

Merged build finished. Test FAILed.

Test build #1458 has finished for   PR 8111 at commit 1400770.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SQLTransformer (override val uid: String) extends Transformer
 implicit class StringToColumn(val sc: StringContext)
case class EqualNullSafe(attribute: String, value: Any) extends Filter

Test build #1459 has finished for   PR 8111 at commit 1400770.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SQLTransformer (override val uid: String) extends Transformer
 implicit class StringToColumn(val sc: StringContext)
case class EqualNullSafe(attribute: String, value: Any) extends Filter

retest this please

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #40528 has started for   PR 8111 at commit c92a3b0.

Merged build finished. Test FAILed.

Reviewed 28 of 131 files at r1, 1 of 2 files at r2.
Review status: 29 of 132 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

project/SparkBuild.scala, line 344 [r4] (raw file):
This is probably safe to remove given that we should inherit this from the global TestSettings.

project/SparkBuild.scala, line 363 [r4] (raw file):
Should still have something here to create the context and import its implicits. This will require manual testing before signoff.

sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java, line 46 [r4] (raw file):
Note that this is called on every test, not once per suite, so I think that we'll wind up re-loading the test data many times. If this turns out to be a perf. issue then we may want to use JUnit BeforeAll or BeforeSuite or whatever it's called.

sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala, line 49 [r4] (raw file):
As discussed offline, I think that SQLTestUtils should remain a trait that is mixed into SharedSQLContext and SharedHiveContext. This will allow its helper methods to be used in non-shared-context settings as well.

Comments from the review on Reviewable.io

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Review status: 9 of 132 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

project/SparkBuild.scala, line 0 [r4] (raw file):
Done.

project/SparkBuild.scala, line 0 [r4] (raw file):
Done.

sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java, line 0 [r4] (raw file):
ok, let's keep this one as is for now. We can fix it later if necessary.

sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala, line 0 [r4] (raw file):
Done.

Comments from the review on Reviewable.io

retest this please

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #40528 timed out     for PR 8111 at commit c92a3b0     after a configured wait of 175m.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build finished. Test FAILed.

Merged build started.

Reviewed 1 of 131 files at r1, 1 of 1 files at r4, 29 of 102 files at r5, 1 of 1 files at r6.
Review status: 33 of 132 files reviewed at latest revision, 5 unresolved discussions, all commit checks successful.

project/SparkBuild.scala, line 335 [r6] (raw file):
Alright, I tested this locally and it works

Comments from the review on Reviewable.io

Merged build finished. Test FAILed.

Reviewed 9 of 131 files at r1, 35 of 102 files at r5, 1 of 2 files at r8.
Review status: 78 of 132 files reviewed at latest revision, 12 unresolved discussions, all commit checks successful.

sql/core/src/test/scala/org/apache/spark/sql/sources/DDLTestSuite.scala, line 74 [r8] (raw file):
How are the before and after methods ordered here? I wonder if we should re-write this to override beforeAll() to make this more explicit, since the relative ordering of before { }  and beforeAll isn't immediately apparent.

sql/core/src/test/scala/org/apache/spark/sql/sources/FilteredScanSuite.scala, line 104 [r8] (raw file):
Same comment applies here RE: relative ordering of the before methods.

sql/core/src/test/scala/org/apache/spark/sql/sources/PrunedScanSuite.scala, line 59 [r8] (raw file):
Another before case.

sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala, line 48 [r8] (raw file):
As a general rule, do you think that we should wrap this in a try-finally so that the superclass's teardown is guaranteed to be called even if an error occurs in the subclass's teardown?

sql/hive/src/test/java/test/org/apache/spark/sql/hive/JavaDataFrameSuite.java, line 36 [r8] (raw file):
Import ordering?

sql/hive/src/test/scala/org/apache/spark/sql/hive/parquetSuites.scala, line 425 [r8] (raw file):
Why is this necessary?  Is the problem that ctx is a def?

sql/README.md, line 63 [r8] (raw file):
I suppose that we might want to update this to reflect the new output printed by build/sbt hive/console; might as well do so if we're going to have to manually test this anyways.

Comments from the review on Reviewable.io

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Review status: 78 of 132 files reviewed at latest revision, 12 unresolved discussions, all commit checks successful.

sql/core/src/test/scala/org/apache/spark/sql/sources/DDLTestSuite.scala, line 74 [r8] (raw file):
sure. I was just preserving what was here before but I agree.

sql/core/src/test/scala/org/apache/spark/sql/sources/FilteredScanSuite.scala, line 104 [r8] (raw file):
Done.

sql/core/src/test/scala/org/apache/spark/sql/sources/PrunedScanSuite.scala, line 59 [r8] (raw file):
Done.

sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala, line 48 [r8] (raw file):
Make sense

sql/hive/src/test/java/test/org/apache/spark/sql/hive/JavaDataFrameSuite.java, line 36 [r8] (raw file):
Ok, I put it at the end because it's "import static", but I'll move it up

sql/hive/src/test/scala/org/apache/spark/sql/hive/parquetSuites.scala, line 425 [r8] (raw file):
yeah, we want a stable type _ctx.catalog.QualifiedTableName for tableIdentifier below

sql/README.md, line 63 [r8] (raw file):
ah yes. I'll do so. By the way I already manually tested it and it worked.

Comments from the review on Reviewable.io

Review status: 78 of 132 files reviewed at latest revision, 12 unresolved discussions, all commit checks successful.

sql/core/src/test/scala/org/apache/spark/sql/sources/FilteredScanSuite.scala, line 104 [r8] (raw file):
By the way, not all of these are straightforward to convert. E.g. JDBCSuite has a ton of stuff in before { }. Do you think it makes sense to call an "ensureContextInitialized" in before { } in those cases? Or is it fine if tests pass? I ran JDBCSuite locally and it passes...

Comments from the review on Reviewable.io

Merged build triggered.

Merged build started.

Test build #1475 has started for   PR 8111 at commit c8f72d5.

Test build #1476 has started for   PR 8111 at commit c8f72d5.

Test build #1479 has started for   PR 8111 at commit c8f72d5.

Merged build triggered.

Merged build started.

Test build #40604 has started for   PR 8111 at commit 54848e2.

Reviewed 4 of 22 files at r9.
Review status: 68 of 133 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

sql/core/src/test/scala/org/apache/spark/sql/sources/FilteredScanSuite.scala, line 104 [r8] (raw file):
Both before and beforeAll() are still run before each individual test, so unless I'm overlooking something I don't think this is going to change test behavior. My suggestion here was mostly for clarity. I think we can just defer this cleanup until later, since fixing all of them at once is going to take a while.

Comments from the review on Reviewable.io

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

This test is failing even locally:
[info] Test test.org.apache.spark.sql.JavaDataFrameSuite.testSampleBy started
00:38:46.848 WARN org.apache.spark.metrics.MetricsSystem: Using default name DAGScheduler for source because spark.app.id is not set.
[error] Test test.org.apache.spark.sql.JavaDataFrameSuite.testSampleBy failed: org.junit.internal.ArrayComparisonFailure: arrays first differed at element [0]; expected:<[0,5]> but was:<[0,10]>
[error]     at test.org.apache.spark.sql.JavaDataFrameSuite.testSampleBy(JavaDataFrameSuite.java:238)
[error]     ...

Review status: 67 of 133 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

sql/core/src/test/scala/org/apache/spark/sql/sources/FilteredScanSuite.scala, line 104 [r8] (raw file):
Ok, let's defer it. I've changed it where possible

Comments from the review on Reviewable.io

retest this please

Merged build triggered.

Merged build started.

Test build #1479 has finished for   PR 8111 at commit c8f72d5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Test build #1480 has started for   PR 8111 at commit 94f9c77.

I killed the previous few test runs manually so they should start reporting test failures.

Test build #40607 has started for   PR 8111 at commit 94f9c77.

Test build #1482 has started for   PR 8111 at commit 94f9c77.

Reviewed 13 of 131 files at r1, 1 of 10 files at r3, 27 of 102 files at r5, 5 of 7 files at r7, 1 of 2 files at r8, 15 of 22 files at r9, 4 of 4 files at r10.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala, line 49 [r8] (raw file):
Done.

sql/README.md, line 63 [r8] (raw file):
Done.

Comments from the review on Reviewable.io

Merged build triggered.

Merged build started.

Test build #40611 has started for   PR 8111 at commit bec7d28.

Test build #40611 has finished for   PR 8111 at commit bec7d28.

This patch fails some tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

OK, that was a really weird error. Jenkins test this please.

Test build #1485 has started for   PR 8111 at commit bec7d28.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test build #1480 has finished for   PR 8111 at commit 94f9c77.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Test build #1482 has finished for   PR 8111 at commit 94f9c77.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Test build #1485 has finished for   PR 8111 at commit bec7d28.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Test build #40604 timed out     for PR 8111 at commit 54848e2     after a configured wait of 175m.

Merged build finished. Test FAILed.

Test build #40607 timed out     for PR 8111 at commit 94f9c77     after a configured wait of 175m.

Merged build finished. Test FAILed.

Nooo, merge conflicts :(

It's OK. I just realized from the jenkins log that there were actually a lot of unresolved logical merge conflicts causing NPEs everywhere.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test build #1503 has started for   PR 8111 at commit aac8f7f.

Test build #1504 has started for   PR 8111 at commit aac8f7f.

Test build #1505 has started for   PR 8111 at commit aac8f7f.

Alright, I just triggered a bunch of builds after fixing the obvious sources of test failures. Previously we had tests that completely overrode our beforeAlls and afterAlls, which could mean (1) the SQLContext was never started, leading to NPEs, or (2) the SQLContext was never stopped, leading to multiple SparkContexts in the same JVM. These cases are now both fixed.

Test build #1505 has finished for   PR 8111 at commit aac8f7f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Test build #1504 has finished for   PR 8111 at commit aac8f7f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class TaskSetFailed(taskSet: TaskSet, reason: String, exception: Option[Throwable])
 implicit class StringToColumn(val sc: StringContext)

Test build #1503 has finished for   PR 8111 at commit aac8f7f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class TaskSetFailed(taskSet: TaskSet, reason: String, exception: Option[Throwable])
 implicit class StringToColumn(val sc: StringContext)

Merged build triggered.

Merged build started.

Test build #1510 has started for   PR 8111 at commit aac8f7f.

Test build #1511 has started for   PR 8111 at commit aac8f7f.

Test build #40691 has started for   PR 8111 at commit 55d6624.

Test build #1512 has started for   PR 8111 at commit 55d6624.

Reviewed 4 of 4 files at r11, 12 of 12 files at r12, 1 of 1 files at r13.
Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

Comments from the review on Reviewable.io

Merged build triggered.

Merged build started.

Test build #40693 has started for   PR 8111 at commit 4ed58c8.

Test build #1518 has started for   PR 8111 at commit 4ed58c8.

Test build #1520 has started for   PR 8111 at commit 4ed58c8.

Test build #1519 has started for   PR 8111 at commit 4ed58c8.

Merged build triggered.

Test build #1518 has finished for   PR 8111 at commit 4ed58c8.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class TaskSetFailed(taskSet: TaskSet, reason: String, exception: Option[Throwable])
   * Set thresholds in multiclass (or binary) classification to adjust the probability of
 implicit class StringToColumn(val sc: StringContext)

Merged build started.

Test build #1520 has finished for   PR 8111 at commit 4ed58c8.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #1519 has finished for   PR 8111 at commit 4ed58c8.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class TaskSetFailed(taskSet: TaskSet, reason: String, exception: Option[Throwable])
   * Set thresholds in multiclass (or binary) classification to adjust the probability of
 implicit class StringToColumn(val sc: StringContext)

@marmbrus is it OK to rename them and deprecate them? Or do we have to keep the same name?

Merged build triggered.

Merged build started.

Test build #40703 has started for   PR 8111 at commit 9ea7f7c.

Test build #1521 has started for   PR 8111 at commit 451fa37.

Test build #1523 has started for   PR 8111 at commit 9ea7f7c.

Test build #1522 has started for   PR 8111 at commit 451fa37.

Test build #40691 has finished for   PR 8111 at commit 55d6624.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class TaskSetFailed(taskSet: TaskSet, reason: String, exception: Option[Throwable])
   * It is safe to add arguments modified by other methods in this class (such as
   * Set thresholds in multiclass (or binary) classification to adjust the probability of
class SQLTransformer (override val uid: String) extends Transformer
 implicit class StringToColumn(val sc: StringContext)
case class EqualNullSafe(attribute: String, value: Any) extends Filter

Merged build finished. Test FAILed.

Test build #1512 has finished for   PR 8111 at commit 55d6624.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class TaskSetFailed(taskSet: TaskSet, reason: String, exception: Option[Throwable])
   * Set thresholds in multiclass (or binary) classification to adjust the probability of
 implicit class StringToColumn(val sc: StringContext)

Test build #40703 has finished for   PR 8111 at commit 9ea7f7c.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
   * Set thresholds in multiclass (or binary) classification to adjust the probability of
case class QRDecomposition[QType, RType](Q: QType, R: RType)
 implicit class StringToColumn(val sc: StringContext)

Merged build finished. Test FAILed.

Test build #1523 has finished for   PR 8111 at commit 9ea7f7c.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #1521 has finished for   PR 8111 at commit 451fa37.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
   * Set thresholds in multiclass (or binary) classification to adjust the probability of
case class QRDecomposition[QType, RType](Q: QType, R: RType)
 implicit class StringToColumn(val sc: StringContext)

Test build #1522 has finished for   PR 8111 at commit 451fa37.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class TaskSetFailed(taskSet: TaskSet, reason: String, exception: Option[Throwable])
   * Set thresholds in multiclass (or binary) classification to adjust the probability of
case class QRDecomposition[QType, RType](Q: QType, R: RType)
 implicit class StringToColumn(val sc: StringContext)

Test build #1511 has finished for   PR 8111 at commit aac8f7f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #1510 has finished for   PR 8111 at commit aac8f7f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build triggered.

Test build #1527 has started for   PR 8111 at commit 9ea7f7c.

Merged build started.

Merged build finished. Test FAILed.

retest this please

Test build #1529 has started for   PR 8111 at commit 94cc3b5.

Merged build triggered.

Merged build started.

Test build #40718 has started for   PR 8111 at commit 94cc3b5.

Test build #40693 timed out     for PR 8111 at commit 4ed58c8     after a configured wait of 175m.

Merged build finished. Test FAILed.

retest this please

Test build #1531 has started for   PR 8111 at commit 94cc3b5.

Test build #1530 has started for   PR 8111 at commit 94cc3b5.

Merged build triggered.

Merged build started.

Test build #1533 has started for   PR 8111 at commit 7a0b1ef.

Merged build finished. Test FAILed.

Test build #1532 has started for   PR 8111 at commit 7a0b1ef.

Test build #40720 has started for   PR 8111 at commit 7a0b1ef.

Test build #1534 has started for   PR 8111 at commit 7a0b1ef.

Test build #1535 has started for   PR 8111 at commit 7a0b1ef.

Test build #1533 has finished for   PR 8111 at commit 7a0b1ef.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #1532 has finished for   PR 8111 at commit 7a0b1ef.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class TaskSetFailed(taskSet: TaskSet, reason: String, exception: Option[Throwable])
   * Set thresholds in multiclass (or binary) classification to adjust the probability of
case class QRDecomposition[QType, RType](Q: QType, R: RType)
 implicit class StringToColumn(val sc: StringContext)

Test build #40720 has finished for   PR 8111 at commit 7a0b1ef.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class QRDecomposition[QType, RType](Q: QType, R: RType)
 implicit class StringToColumn(val sc: StringContext)

Merged build finished. Test FAILed.

Test build #1535 has finished for   PR 8111 at commit 7a0b1ef.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #1538 has started for   PR 8111 at commit 7a0b1ef.

Merged build triggered.

Merged build started.

Test build #1539 has started for   PR 8111 at commit 828144f.

Test build #1541 has started for   PR 8111 at commit 828144f.

Test build #1540 has started for   PR 8111 at commit 828144f.

Test build #40737 has started for   PR 8111 at commit 828144f.

Merged build triggered.

Merged build started.

Test build #40739 has started for   PR 8111 at commit c4d44c9.

Test build #1543 has started for   PR 8111 at commit c4d44c9.

Test build #1544 has started for   PR 8111 at commit c4d44c9.

Test build #1545 has started for   PR 8111 at commit c4d44c9.

Test build #1540 has finished for   PR 8111 at commit 828144f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Test build #1539 has finished for   PR 8111 at commit 828144f.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Test build #1544 has finished for   PR 8111 at commit c4d44c9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait Identifiable
class VectorUDT extends UserDefinedType[Vector]
 implicit class StringToColumn(val sc: StringContext)

Test build #40737 has finished for   PR 8111 at commit 828144f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait Identifiable
class VectorUDT extends UserDefinedType[Vector]
 implicit class StringToColumn(val sc: StringContext)

Test build #1543 has finished for   PR 8111 at commit c4d44c9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait Identifiable
class VectorUDT extends UserDefinedType[Vector]
 implicit class StringToColumn(val sc: StringContext)

Merged build finished. Test FAILed.

Test build #1545 has finished for   PR 8111 at commit c4d44c9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait Identifiable
case class QRDecomposition[QType, RType](Q: QType, R: RType)
class VectorUDT extends UserDefinedType[Vector]
 implicit class StringToColumn(val sc: StringContext)

Test build #1541 timed out     for PR 8111 at commit 828144f     after a configured wait of 175m.

Test build #40739 timed out     for PR 8111 at commit c4d44c9     after a configured wait of 175m.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #40777 has started for   PR 8111 at commit 0606c82.

Test build #1554 has started for   PR 8111 at commit 0606c82.

Test build #1555 has started for   PR 8111 at commit 0606c82.

Test build #1554 has finished for   PR 8111 at commit 0606c82.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait Identifiable
class VectorUDT extends UserDefinedType[Vector]
class KMeans(JavaEstimator, HasFeaturesCol, HasPredictionCol, HasMaxIter, HasTol, HasSeed):
 implicit class StringToColumn(val sc: StringContext)

Test build #1555 has finished for   PR 8111 at commit 0606c82.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait Identifiable
class VectorUDT extends UserDefinedType[Vector]
class KMeans(JavaEstimator, HasFeaturesCol, HasPredictionCol, HasMaxIter, HasTol, HasSeed):
 implicit class StringToColumn(val sc: StringContext)

Test build #40777 timed out     for PR 8111 at commit 0606c82     after a configured wait of 175m.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #40791 has started for   PR 8111 at commit aed7fc7.

Merged build triggered.

Merged build started.

Test build #40793 has started for   PR 8111 at commit b8780a9.

Merged build triggered.

Merged build started.

Test build #1564 has started for   PR 8111 at commit d85a6d8.

Test build #1565 has started for   PR 8111 at commit d85a6d8.

Test build #1566 has started for   PR 8111 at commit d85a6d8.

Merged build finished. Test FAILed.

Test build #1569 has started for   PR 8111 at commit d85a6d8.

Test build #40791 has finished for   PR 8111 at commit aed7fc7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Merged build finished. Test FAILed.

Test build #1564 has finished for   PR 8111 at commit d85a6d8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Test build #40793 has finished for   PR 8111 at commit b8780a9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #1566 has finished for   PR 8111 at commit d85a6d8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait Identifiable
case class QRDecomposition[QType, RType](Q: QType, R: RType)
class VectorUDT extends UserDefinedType[Vector]
class KMeans(JavaEstimator, HasFeaturesCol, HasPredictionCol, HasMaxIter, HasTol, HasSeed):
 implicit class StringToColumn(val sc: StringContext)

Test build #1573 has started for   PR 8111 at commit 821ea67.

Test build #1574 has started for   PR 8111 at commit 821ea67.

Test build #1575 has started for   PR 8111 at commit 821ea67.

Test build #40820 has started for   PR 8111 at commit 821ea67.

Test build #1565 has finished for   PR 8111 at commit d85a6d8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Test build #1569 timed out     for PR 8111 at commit d85a6d8     after a configured wait of 175m.

I've merged this.

Test build #1574 has finished for   PR 8111 at commit 821ea67.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Test build #40820 has finished for   PR 8111 at commit 821ea67.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Merged build finished. Test PASSed.

Test build #1573 timed out     for PR 8111 at commit 821ea67     after a configured wait of 175m.

Test build #1575 timed out     for PR 8111 at commit 821ea67     after a configured wait of 175m.


Update trunk + use trunk tools install

The API changed

#290 should address the check failure you're seeing


Persistent callbacks macros

I have been having trouble implementing asynchronous callbacks. After checking out past issues, such as #15 and #23, I am still not confident enough.
After studying libui-node's source, I found out that it now uses preprocessor definitions for DEFINE_EVENT and IMPLEMENT_EVENT.
Are there any plans for nbind to have such an abstraction? Or maybe get a minimal working example in the examples as a solid reference?

Ideally, it would be nice to be able to avoid working with nbind::cbCallback altogether and just use std::function, but I don't think it's ready atm (I think I saw an issue about this: #38). In the meantime, cbCallback is a good enough replacement, and doesn't require much work to get to work (the one catch I've found is #52, which requires you to use pointers to store your callbacks).
You can find an example here:
https://github.com/arcanis/text-layout/blob/d1ec26a5193c16256165feda3420bad95c0e9cd1/sources/TextLayout.hh#L35-L45
https://github.com/arcanis/text-layout/blob/d1ec26a5193c16256165feda3420bad95c0e9cd1/sources/TextLayout.hh#L35-L45
https://github.com/arcanis/text-layout/blob/d1ec26a5193c16256165feda3420bad95c0e9cd1/sources/TextLayout.cc#L477-L480

@arcanis thanks for the response, will check your code!

Using only normal pointers for persistent callbacks shouldn't really work, since the callback may get garbage collected before using it through the pointer. std::make_shared and std::make_unique should be fine.

I am confused. How is it possible for code to be asynchronous without leveraging nan's  AsyncWorker, or something else equivalent?
For example I compared the behavior of setTimeout and nbind.init:
var nbind = require('nbind');

console.time('test timeout outer');
console.time('test timeout inner');
setTimeout((function() {
  console.log('timeout fired');
  console.timeEnd('test timeout inner');
}), 1000);
console.timeEnd('test timeout outer');

console.time('test nbind outer');
console.time('test nbind inner');
nbind.init(function(err, binding) {
  console.log('nbind native module loaded');
  var lib = binding.lib;
  // Use the library.
  console.timeEnd('test nbind inner');
});
console.timeEnd('test nbind outer');

Outputs:
test timeout outer: 6.589ms
nbind native module loaded
test nbind inner: 28.489ms
test nbind outer: 29.176ms
timeout fired
test timeout inner: 1008.726ms

Shouldn't test nbind outer be firing before test nbind inner and log less ms?
nbind.init appears to be blocking. But the callback seems to fire okish. Are my assumptions wrong?

nbind.init currently always calls the callback synchronously on Node.js and asynchronously inside web browsers... The point is to allow using CommonJS require() to load the addon and immediately start using it. However on browsers the asm.js code may decide to load a binary with initial heap contents, forcing it to work asynchronously.
Currently nbind doesn't really work asynchronously, because you cannot do the equivalent of setTimeout from the C++ side. Basically this becomes a problem if you'd want to create a thread in C++ code, since there's no API for another thread to send a message to the JavaScript thread.

Ok, now it makes sense why I was thinking my code wasn't working properly. I will close this, thanks for the swift clarification.


textDocument/completion return too many response

When using the textDocument/completion method for code completion, a large amount of irrelevant information is returned, including the documentation field. How can I solve this issue? The editor is a custom code editor implemented with Flutter. I have set "suggestFromUnimportedLibraries": false during initialization, but it has not had any effect.

Are you setting the resolveSupport client configuration data to indicate that these fields can be returned later? More generally, please let us know what client configuration data you're sending to the server.
@DanTup

Currently, resolve is only used for completion items that are not already imported. For all things currently in-scope, the documentation (and other fields) are included inline. This is one of the things noted at https://github.com/dart-lang/sdk/issues/53501 (I believe there was something that made it non-trivial, but I don't recall the specifics right now).
You can control the level of documentation that is included (here and in hovers) with the [dart.documentation configuration setting](https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/tool/lsp_spec/README.md#:~:text=supports willRenameFiles requests.-,dart.documentation,-(none%2C) and you can also reduce the number of items included with the "dart.maxCompletionItems" setting.

resolveSupport

yes, I have set the resolveSupport. My capabilities are as follows:

Map<String, dynamic> clientCapabilities = {
  "workspace": {
    "applyEdit": true,
    "workspaceEdit": {
      "documentChanges": true,
      "resourceOperations": ["create", "rename", "delete"],
      "failureHandling": "textOnlyTransactional",
      "normalizesLineEndings": true,
      "changeAnnotationSupport": {"groupsOnLabel": true}
    },
    "configuration": true,
    "didChangeWatchedFiles": {
      "dynamicRegistration": true,
      "relativePatternSupport": true
    },
    "symbol": {
      "dynamicRegistration": true,
      "symbolKind": {
        "valueSet": [
          1,
          2,
          3,
          4,
          5,
          6,
          7,
          8,
          9,
          10,
          11,
          12,
          13,
          14,
          15,
          16,
          17,
          18,
          19,
          20,
          21,
          22,
          23,
          24,
          25,
          26
        ]
      },
      "tagSupport": {
        "valueSet": [1]
      },
      "resolveSupport": {
        "properties": ["location.range"]
      }
    },
    "codeLens": {"refreshSupport": true},
    "executeCommand": {"dynamicRegistration": true},
    "didChangeConfiguration": {"dynamicRegistration": true},
    "workspaceFolders": true,
    "semanticTokens": {"refreshSupport": true},
    "fileOperations": {
      "dynamicRegistration": true,
      "didCreate": true,
      "didRename": true,
      "didDelete": true,
      "willCreate": true,
      "willRename": true,
      "willDelete": true
    },
    "inlineValue": {"refreshSupport": true},
    "inlayHint": {"refreshSupport": true},
    "diagnostics": {"refreshSupport": true}
  },
  "textDocument": {
    "publishDiagnostics": {
      "relatedInformation": true,
      "versionSupport": false,
      "tagSupport": {
        "valueSet": [1, 2]
      },
      "codeDescriptionSupport": true,
      "dataSupport": true
    },
    "synchronization": {
      "dynamicRegistration": true,
      "willSave": true,
      "willSaveWaitUntil": true,
      "didSave": true
    },
    "completion": {
      "dynamicRegistration": true,
      "contextSupport": true,
      "completionItem": {
        "snippetSupport": true,
        "commitCharactersSupport": true,
        "documentationFormat": ["markdown", "plaintext"],
        "deprecatedSupport": true,
        "preselectSupport": true,
        "tagSupport": {
          "valueSet": [1]
        },
        "insertReplaceSupport": true,
        "resolveSupport": {
          "properties": ["documentation", "detail", "additionalTextEdits"]
        },
        "insertTextModeSupport": {
          "valueSet": [1, 2]
        },
        "labelDetailsSupport": true
      },
      "insertTextMode": 2,
      "completionItemKind": {
        "valueSet": [
          1,
          2,
          3,
          4,
          5,
          6,
          7,
          8,
          9,
          10,
          11,
          12,
          13,
          14,
          15,
          16,
          17,
          18,
          19,
          20,
          21,
          22,
          23,
          24,
          25
        ]
      },
      "completionList": {
        "itemDefaults": [
          "commitCharacters",
          "editRange",
          "insertTextFormat",
          "insertTextMode"
        ]
      }
    },
    "hover": {
      "dynamicRegistration": true,
      "contentFormat": ["markdown", "plaintext"]
    },
    "signatureHelp": {
      "dynamicRegistration": true,
      "signatureInformation": {
        "documentationFormat": ["markdown", "plaintext"],
        "parameterInformation": {"labelOffsetSupport": true},
        "activeParameterSupport": true
      },
      "contextSupport": true
    },
    "definition": {"dynamicRegistration": true, "linkSupport": true},
    "references": {"dynamicRegistration": true},
    "documentHighlight": {"dynamicRegistration": true},
    "documentSymbol": {
      "dynamicRegistration": true,
      "symbolKind": {
        "valueSet": [
          1,
          2,
          3,
          4,
          5,
          6,
          7,
          8,
          9,
          10,
          11,
          12,
          13,
          14,
          15,
          16,
          17,
          18,
          19,
          20,
          21,
          22,
          23,
          24,
          25,
          26
        ]
      },
      "hierarchicalDocumentSymbolSupport": true,
      "tagSupport": {
        "valueSet": [1]
      },
      "labelSupport": true
    },
    "codeAction": {
      "dynamicRegistration": true,
      "isPreferredSupport": true,
      "disabledSupport": true,
      "dataSupport": true,
      "resolveSupport": {
        "properties": ["edit"]
      },
      "codeActionLiteralSupport": {
        "codeActionKind": {
          "valueSet": [
            "",
            "quickfix",
            "refactor",
            "refactor.extract",
            "refactor.inline",
            "refactor.rewrite",
            "source",
            "source.organizeImports"
          ]
        }
      },
      "honorsChangeAnnotations": false
    },
    "codeLens": {"dynamicRegistration": true},
    "formatting": {"dynamicRegistration": true},
    "rangeFormatting": {"dynamicRegistration": true},
    "onTypeFormatting": {"dynamicRegistration": true},
    "rename": {
      "dynamicRegistration": true,
      "prepareSupport": true,
      "prepareSupportDefaultBehavior": 1,
      "honorsChangeAnnotations": true
    },
    "documentLink": {"dynamicRegistration": true, "tooltipSupport": true},
    "typeDefinition": {"dynamicRegistration": true, "linkSupport": true},
    "implementation": {"dynamicRegistration": true, "linkSupport": true},
    "colorProvider": {"dynamicRegistration": true},
    "foldingRange": {
      "dynamicRegistration": true,
      "rangeLimit": 5000,
      "lineFoldingOnly": true,
      "foldingRangeKind": {
        "valueSet": ["comment", "imports", "region"]
      },
      "foldingRange": {"collapsedText": false}
    },
    "declaration": {"dynamicRegistration": true, "linkSupport": true},
    "selectionRange": {"dynamicRegistration": true},
    "callHierarchy": {"dynamicRegistration": true},
    "semanticTokens": {
      "dynamicRegistration": true,
      "tokenTypes": [
        "namespace",
        "type",
        "class",
        "enum",
        "interface",
        "struct",
        "typeParameter",
        "parameter",
        "variable",
        "property",
        "enumMember",
        "event",
        "function",
        "method",
        "macro",
        "keyword",
        "modifier",
        "comment",
        "string",
        "number",
        "regexp",
        "operator",
        "decorator"
      ],
      "tokenModifiers": [
        "declaration",
        "definition",
        "readonly",
        "static",
        "deprecated",
        "abstract",
        "async",
        "modification",
        "documentation",
        "defaultLibrary"
      ],
      "formats": ["relative"],
      "requests": {
        "range": true,
        "full": {"delta": true}
      },
      "multilineTokenSupport": false,
      "overlappingTokenSupport": false,
      "serverCancelSupport": true,
      "augmentsSyntaxTokens": true
    },
    "linkedEditingRange": {"dynamicRegistration": true},
    "typeHierarchy": {"dynamicRegistration": true},
    "inlineValue": {"dynamicRegistration": true},
    "inlayHint": {
      "dynamicRegistration": true,
      "resolveSupport": {
        "properties": [
          "tooltip",
          "textEdits",
          "label.tooltip",
          "label.location",
          "label.command"
        ]
      }
    },
    "diagnostic": {"dynamicRegistration": true, "relatedDocumentSupport": false}
  },
  "window": {
    "showMessage": {
      "messageActionItem": {"additionalPropertiesSupport": true}
    },
    "showDocument": {"support": true},
    "workDoneProgress": true
  },
  "general": {
    "staleRequestSupport": {
      "cancel": true,
      "retryOnContentModified": [
        "textDocument/semanticTokens/full",
        "textDocument/semanticTokens/range",
        "textDocument/semanticTokens/full/delta"
      ]
    },
    "regularExpressions": {"engine": "ECMAScript", "version": "ES2020"},
    "markdown": {
      "parser": "marked",
      "version": "1.1.0",
      "allowedTags": [
        "ul",
        "li",
        "p",
        "code",
        "blockquote",
        "ol",
        "h1",
        "h2",
        "h3",
        "h4",
        "h5",
        "h6",
        "hr",
        "em",
        "pre",
        "table",
        "thead",
        "tbody",
        "tr",
        "th",
        "td",
        "div",
        "del",
        "a",
        "strong",
        "br",
        "img",
        "span"
      ]
    },
    "positionEncodings": ["utf-16"]
  },
  "notebookDocument": {
    "synchronization": {
      "dynamicRegistration": true,
      "executionSummarySupport": true
    }
  },
  "experimental": {
    "supportsWindowShowMessageRequest": true,
    "snippetTextEdit": true,
    "dartCodeAction": {
      "commandParameterSupport": {
        "supportedKinds": ["saveUri"]
      }
    }
  }
};

@onism0106 have you tried changing the dart.documentation (or dart.maxCompletionItems) settings noted above?
For now, I think those are the only options that will help here, until we support resolve for the already-in-scope items.
Out of interest - what problem is the payload size causing you? (memory usage? time taken to deserialize json? time to send bytes between server and client?). Is your editor open source?

I started looking at why we didn't use /resolve for documentation generally and added some notes in https://github.com/dart-lang/sdk/issues/53501#issuecomment-2124332687. It was mostly that I was hoping that https://github.com/microsoft/language-server-protocol/issues/1802 would be implemented which would avoid us having to add so much to the payload in order to use /resolve here.

@onism0106 have you tried changing the dart.documentation (or dart.maxCompletionItems) settings noted above?
For now, I think those are the only options that will help here, until we support resolve for the already-in-scope items.
Out of interest - what problem is the payload size causing you? (memory usage? time taken to deserialize json? time to send bytes between server and client?). Is your editor open source?

Yes, I am worried about performance issues because there will be frequent interactions with the LSP, each time returning a large amount of data. I am concerned that this might cause performance problems，(memory usage? time taken to deserialize json).
I don't know if my  concern is unnecessary.
I'll try set dart.documentation (or dart.maxCompletionItems) later

If it helps, the payload sizes you're seeing here match what VS Code is dealing with today. I can't be sure the equivalent Dart code performs the same as VS Code's javascript, but hopefully it won't cause any real performance issues.
However, I have pinged on the LSP issue about this, and depending on the response (or lack of), may try to progress something in this area (because there is value in reducing payload sizes for some other situations, like when the extension host/LSP server is on a remote machine).


New Stat: Most Quit Maps

resolves: #611

If you run ./vendor/bin/pint - it'll take care of cs.

and to keep things in one place. It looks like the quitting behavior of Last Spartan Standing is screwing this. If LSS never has a ranked mode - we could just isolate this to ranked for now.

and to keep things in one place. It looks like the quitting behavior of Last Spartan Standing is screwing this. If LSS never has a ranked mode - we could just isolate this to ranked for now.

I don't have any test data for LSS games. But I found this one https://leafapp.co/game/53a82b44-089e-4534-9aae-80e91a61086d. Can't we just exclude that Gamevariant like gamevariant_id <> 99?

Okay, lets hardcode this hash for now - 3fdb396febedc607ddd3416aea2ff5a3. All the category/gamevariant stuff is a can of worms. If the gamevariant_id is 3fdb396febedc607ddd3416aea2ff5a3 skip it.

Okay, lets hardcode this hash for now - 3fdb396febedc607ddd3416aea2ff5a3. All the category/gamevariant stuff is a can of worms. If the gamevariant_id is 3fdb396febedc607ddd3416aea2ff5a3 skip it.

games.gamevariant_id looks to be an int. Do I join with the gamevariant table and match gamevariant.uuid?

games.gamevariant_id looks to be an int. Do I join with the gamevariant table and match gamevariant.uuid?

Yeah, unless that is so inefficient than you could make an env value for that internal id and we could use that.

I've ran this branch through test suite local 10 times and always gotten 100% coverage. So a bit lost why this failed a few of the 100% coverage at the moment.


tracing: dump tracing span into access log via metadata

Signed-off-by: Shikugawa<EMAIL_ADDRESS>
Commit Message: tracing: dump tracing span into access log via metadata
Additional Description: This feature enables to dump trace context into metadata to output them via access log.
Risk Level: Low
Testing: Unit
Docs Changes: Required
Release Notes: Required
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
cc @wu-sheng

FYI @kezhenxu94, one important chance to have ALS collaborating with tracing context.
This could be an important feature for mesh observability.

/retest


[6.x] Check if class is already prefixed with namespace to prevent duplication when creating a route

Added a check to prevent the namespace from being duplicated when the Router tries to prepend the group namespace to the class.
This conveniently allows to define routes using the fully qualified class name instead of just a string, which is always helpful:
use App\Http\Controllers\AccountController;
use App\Http\Controllers\UserController;

Route::get('/account', AccountController::class);  // Instead of Route::get('/account', 'AccountController');
Route::resource('/users', UserController::class);  // Instead of Route::resource('/users', 'UserController');

For this example, the AccountController class is supposed to be invokable.

Remove the namespace directive from your RouteServiceProvider.

That works as well, thanks!


grammer

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@mrlunar0 I have closed the PR because the changes you have made is does not improve anything and is effectively vandalism.


Starting character infromation read from settings.cfg

Closes #572.
Additions/modifications proposed in this pull request:

moved starting powers and inspirations to settings.cfg
added starting level and inf

Will pull down to test and merge on Monday when I'm back in town. Unless someone gets to it first.
Thanks Cyan!

Enjoy your trip, @broxen. I got this. Nice work, @cyanpill. I believe Appveyor is still borked. This PR builds fine using Clang and GCC and I've validated that the settings are properly read.


Feature Request

How about having something like an Energy Acceptor. Like the one from AE2

To do what exactly?

To convert energy from external mods to RF (IndustrialCraft uses EU, RotaryCraft uses Watts/Joules, etc) It would be nice to have something that converts it all  to RF so that I can store it all as my energy system doesnt accept certain mods

Well RotaryCraft already has its own system to convert to RF. And I believe that for IndustrialCraft there are also solutions already so I'm not sure this is really needed?


Add ThinKPress

Implementation of ThinKV following #18

@yuhuixu1993 here is a proposal for the implementation of ThinKPress based on our previous discussions in #18:

As in your proposal, I'm zeroing the pruned dimensions
I added support to optionally combine it with any press, and in my first experiments it worked great ! As you required, the inner press is applied before ThinK
I also ensured support for quantization

ThinKPress is the first press in this repo that compress the channel dimension, hence the code is bit more complex. If other similar presses are proposed, we will refactor the code to make the implementation easier (e.g. we can imagine a SequenceBasePress and a DimensionBasePress with options to compose them in one way or the other).

I think it looks awesome!!! Thanks for your hard work!!

I will update. Are you using 32 for the window size too ? (I've been using 64 as in the default of SnapKV).

Thanks. Yes, I use 32 in the paper, but 64 is definitely OK.

@yuhuixu1993 I tried with and without 0-ing the channels for the last 32 tokens and did not see any difference in the prompt I tried. May I keep the current version ? I'm asking because if other similar presses come, would be nice to have a uniform API and not very custom changes. Also to implement what you ask we need to slightly update the compression ratio to take into account the 32*n_pruned_channels elements that are not removed.

@SimJeg I think it is OK with current version， as the performance is OK， many thanks for the experiments！！


Add advection to the adaptive sparse contacts

Description of the problem

Periodic nodes were not properly handled with the last implementation: the periodic nodes had information on the mobility status on the coincident nodes. This was spotted when there has particles at one side of the periodic cells and the other periodic ones were empty. Those cells where not mobile, but this is one of the criteria for mobile.

Disabling contacts of particles was functional in CFD-DEM: cells with low granular temperature deactivated the contacts. However, it is possible for particles within a cell to have a low variance in velocity and a significant average velocity. This is frequent for CFD-DEM simulations where particles may be carried by the fluid by bulk.

Description of the solution

Periodic nodes:

Mapping periodic nodes was achieved with the constraints since we can identify the periodic nodes from it (so called identity constraints).
Some attempted as been done to apply the periodic constraints to the mobility_at_nodes, without any success. The main issue is that constraints force values at PB1 = values at PB2. In our case, we need to check of the prevailing value, so sometime it is PB2 = PB1, with was not compatible with straight constraints operations. "[...] it adds the DoFs of face_1 to the list of constrained DoFs in constraints and adds entries to constrain them to the corresponding values of the DoFs on face_2. " see Deal.II doc here

Disabling contacts with advection:

New mobility status has been added to the disabling contacts: advected and advected_active
The new algorithm doesn't detect when particles are advected, this is a user-defined parameter. It could be useful for DEM when particles are moving in bulk by gravity, but this is more practical for CFD-DEM. The first idea was to implement  advected particles auto-detection, but this results in more checks, also the average velocities threshold is not easly configurable.
The way to "apply advection" is that the average velocity and acceleration of the cells are calculated or updated everytime the mobile cells are integrated. The average values are calculated in the same loop than the integration and it allows to always have the last calculated velocity values. For advected cells, all particles of a cell are integrated with an cell-averaged velocity and acceleration * time step. This velocity is also updated with the a*dt values.

How Has This Been Tested?

List and describe the test(s) for the added code (if there is no test for the pull request, explain why (i.e. the test already exists but was changed))

[ ] Test A

[ ] Test B

Documentation

If applicable, list the documentation files changed and their changes

[ ] File A

Future changes

If applicable, describe future changes or features that will be added in subsequent pull requests

Comments

Anything that you want to add up that didn't fit in any other category can be written here

There's a bug, not ready for review. It will be closed then reopened when ready (also, not as draft)


Bind not Successfull

So, I'm using an LDAP URI based on the convention in the plugin. I have confirmed that this URI works fine in an LDAP browser, but it doesn't work in the plugin. This is the debug info:
[23-Jan-2016 21:38:03 UTC] [AuthLDAP] LDAP authentication failed with exception: bind was not successfull
[23-Jan-2016 21:38:02 UTC] [AuthLDAP] connect to LDAP server
[23-Jan-2016 21:38:02 UTC] [AuthLDAP] about to do LDAP authentication
[23-Jan-2016 21:38:02 UTC] [AuthLDAP] User<EMAIL_ADDRESS>logging in
Not sure how to debug this.

Hi @jftripp. Without having dug deeper I've got a question: Have you confirmed that the URI works in an LDAP-Browser on the webserver or on your local machine? Background is, that the network-structure often doesn't allow access to the LDAP-Server from external webservers. So it works fine from your local machine (inside the network) but not from the webserver (in the DMZ or outside the internal network). You can test that if you have access to a terminal on the webserver by trying to connect to that LDAP-URI.
If that does work, I will need a bit more information like the LDAP-URI, what LDAP-Server you are trying to connect to and whether anonymous binding is used and what filters you are using. But we'l come to that later :wink:
Cheers

Well, I know that the LDAP is allowing connections from the server because other plugins are binding. However, I’m not sure how those plugins are generating the URI, because the plugin does that from input fields on the form.
This is the URI that I’m using:
ldaps://CN=LDAPUser,O=Darwino:LDAPUserP00@playground.darwino.com:636/O=Darwino
I’ve also tried
ldaps://LDAPUser:LDAPUserP00@playground.darwino.com:636/O=Darwino
and
ldaps://CN=LDAPUser,O=Darwino@playground.darwino.com:636/O=Darwino
And
ldaps://CN=LDAPUser,O=Darwino:LDAPUserP00@playground.darwino.com:636
On Jan 24, 2016, at 2:23 AM, Andreas Heigl<EMAIL_ADDRESS>wrote:
Hi @jftripphttps://github.com/jftripp. Without having dug deeper I've got a question: Have you confirmed that the URI works in an LDAP-Browser on the webserver or on your local machine? Background is, that the network-structure often doesn't allow access to the LDAP-Server from external webservers. So it works fine from your local machine (inside the network) but not from the webserver (in the DMZ or outside the internal network). You can test that if you have access to a terminal on the webserver by trying to connect to that LDAP-URI.
If that does work, I will need a bit more information like the LDAP-URI, what LDAP-Server you are trying to connect to and whether anonymous binding is used and what filters you are using. But we'l come to that later [:wink:]
Cheers
—
Reply to this email directly or view it on GitHubhttps://github.com/heiglandreas/authLdap/issues/100#issuecomment-174266720.
Dr. John F. Tripp
Assistant Professor
Information Systems Department
Hankamer School of Business
One Bear Place #98005
Baylor University, Waco, TX 76798-8005
(254) 710-4097 (w)
(254) 292-8417 (c)

That LDAP-URI you are using should work. As you are using the default port for LDAPS would you mind ommiting the Port and use<EMAIL_ADDRESS>instead to see whether it works? That would then mean I have to check the URI-deconstruction, but I'll then take care of that....

This is not working…too bad - I also found another plugin that doesn’t work. I’m doing some debugging to see what is the difference between the plugins that DO work, and the plugins that don’t.
On Jan 24, 2016, at 10:37 AM, Andreas Heigl <notifications<EMAIL_ADDRESS>wrote:
That LDAP-URI you are using should work. As you are using the default port for LDAPS would you mind ommiting the Port and use<EMAIL_ADDRESS>instead to see whether it works? That would then mean I have to check the URI-deconstruction, but I'll then take care of that....
—
Reply to this email directly or view it on GitHubhttps://github.com/heiglandreas/authLdap/issues/100#issuecomment-174314568.
Dr. John F. Tripp
Assistant Professor
Information Systems Department
Hankamer School of Business
One Bear Place #98005
Baylor University, Waco, TX 76798-8005
(254) 710-4097 (w)
(254) 292-8417 (c)

In ldap.php replace line 154 with the following:
            throw new AuthLDAP_Exception('bind was not successfull: ' . ldap_error($this->_ch));

That should give the exact error-code from the LDAP-Server in the debug-messages.
I'll have to add that to the code! Thanks for raising this issue!

This error-message is now included in Release 1.4.15


Android / iOS - Attachment - User is not able to send video files when selecting gallery option

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app and login
Go to any chat
Tap + and select add attachment option in the compose box
Select "Choose from Gallery"
Select a video file and send it

Expected Result:
Video file is sent successfully. If file type is not supported user shouldn't be able to select mp4 files from the gallery or supported file types should be displayed when selecting the "Choose from Gallery" option
Actual Result:
When the user attaches the video, the video is not attached and is constantly loaded in iOS and in Android filet type not supported error message after sending the file
Workaround:
Unknown
Platform:

Where is this issue occurring?

iOS
Android
Mobile Web

Version Number: 1.1.44_2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/159777459-686bad81-60ef-450e-8699-41ee7cd5cb5f.mp4

https://user-images.githubusercontent.com/43996225/159777539-3d2b6ec0-d1f4-4bf6-ae18-5a922e559f5b.mp4
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
View all open jobs on GitHub

@kavimuru I can only reproduce this on iOS. What is the email of the account used in the tests?

@luacmartins User credentials<EMAIL_ADDRESS>/ Hateem123

@luacmartins You can check with<EMAIL_ADDRESS>/ Test1234
https://user-images.githubusercontent.com/43996225/159927019-79774d90-fe0b-49c9-ae22-c9f9eaa57c33.mp4

@kavimuru Thanks! It seems that those files don't have an extension in their name and that's why they are failing.
Some thoughts:

I put up a PR to update the image picker library. That doesn't fix the issue completely, but should help with video files in iOS. Right now we don't get any extensions from those files, so upload will fail. Updating he library fixes that issue.
I couldn't find any way to disable certain file types with the library. I'll keep looking.
We could add a fallback method in our API to try to infer the file extension based on its MIME type. We would probably just cover the extensions here though, which might be enough.

Opened a discussion in Slack. I also think that this is working as intended if a file does not have an extension in the name, but I'll leave the discussion open to see what other people think.


Maven build was failure beacuse of Bower installation failure

Build failure while run mvn clean install package
After pull down the latest package from github not able to build the package throw error on bower install
i installed bower manually also it's showing version by run the command sudo bower --version
1.8.0
i tried with sudo bower install --allow-root command also
Even i tried without sudo command also getting same issue.
Below ERROR Message
[INFO] Running 'bower install' in /home/ubuntu/Hygieia/UI
[ERROR] bower ESUDO         Cannot be run with sudo
[ERROR]
[ERROR] Additional error details:
[ERROR] Since bower is a user command, there is no need to execute it with superuser permissions.
[ERROR] If you're having permission errors when using bower without sudo, please spend a few minutes learning more about how your system should work and make any necessary repairs.
[ERROR]
[ERROR] http://www.joyent.com/blog/installing-node-and-npm
[ERROR] https://gist.github.com/isaacs/579814
[ERROR]
[ERROR] You can however run a command with sudo using --allow-root option
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] com.capitalone.dashboard:Hygieia ................... SUCCESS [  0.651 s]
[INFO] com.capitalone.dashboard:core ...................... SUCCESS [ 16.426 s]
[INFO] com.capitalone.dashboard:api ....................... SUCCESS [  7.289 s]
[INFO] com.capitalone.dashboard:artifactory-artifact-collector SUCCESS [  2.645 s]
[INFO] com.capitalone.dashboard:bamboo-build-collector .... SUCCESS [  2.904 s]
[INFO] com.capitalone.dashboard:jenkins-build-collector ... SUCCESS [  3.185 s]
[INFO] com.capitalone.dashboard:jenkins-cucumber-test-collector SUCCESS [  2.714 s]
[INFO] com.capitalone.dashboard:sonar-codequality-collector SUCCESS [  1.028 s]
[INFO] com.capitalone.dashboard:aws-cloud-collector ....... SUCCESS [  2.097 s]
[INFO] com.capitalone.dashboard:udeploy-deployment-collector SUCCESS [  3.347 s]
[INFO] com.capitalone.dashboard:xldeploy-deployment-collector SUCCESS [  2.771 s]
[INFO] com.capitalone.dashboard:jira-feature-collector .... SUCCESS [  6.315 s]
[INFO] com.capitalone.dashboard:versionone-feature-collector SUCCESS [  2.704 s]
[INFO] com.capitalone.dashboard:chat-ops-collector ........ SUCCESS [  0.792 s]
[INFO] com.capitalone.dashboard:bitbucket-scm-collector ... SUCCESS [  3.070 s]
[INFO] com.capitalone.dashboard:github-scm-collector ...... SUCCESS [  3.123 s]
[INFO] com.capitalone.dashboard:subversion-collector ...... SUCCESS [  1.021 s]
[INFO] com.capitalone.dashboard:gitlab-git-collector ...... SUCCESS [  2.895 s]
[INFO] com.capitalone.dashboard:UI ........................ FAILURE [ 13.080 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:18 min
[INFO] Finished at: 2016-11-22T10:11:46+00:00
[INFO] Final Memory: 113M/703M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.29:bower (bower install) on project UI: Failed to run task: 'bower install' failed. (error code 1) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :UI

bower ESUDO         Cannot be run with sudo

Bower is not meant to be run with sudo - if bower is owned by root, you'll continue to face this issue.


Can't install 1.22.0 version

Describe the bug
Auto update failed

Installation from dbm-1.22.0-windows-x64-nsis-installer.exe, also failed

Manual uninstallation from "C:\Program Files\dbm\Uninstall dbm.exe", also failed

To Reproduce
Steps to reproduce the behavior:

Install 1.21 version from github releases
Download 1.22 version from gjitub releases
Try to run dbm-1.22.0-windows-x64-nsis-installer.exe
See error

We need to adapt the automatic update problem. Thank you for your feedback


Fixing a build break in AsmJS file due to the removal of safethreadinit flag

@Cellule @MikeHolman Can you please take a look?

LGTM


fix-#159 : Configured Theme changes to light mode on page refresh in add blogs page

Summary
Fixed the issue of the theme changing to light mode on page refresh in the add blogs page by adding the class "dark" to the document if the theme is set to "dark" in local storage.
Description
The issue occurred because the class list did not include "dark" while in dark mode, so I added it when the theme is set to "dark" in local storage.
Issue(s) Addressed
Closes #159
Prerequisites

[x] Have you followed all the CONTRIBUTING GUIDELINES?

LGTM @Ritik-The-Dev I'll get this in, Thank you


Feat(web)/extra path to the open notifications and onboarding miniguide

PR-Codex overview
The focus of this PR is to enhance navigation and user experience by adding functionality related to tab navigation and URL fragments.
Detailed summary

Added initialTab prop to Settings component for tab navigation
Implemented URL fragment handling in Settings and MainStructureTemplate components
Added Onboarding component to DesktopHeader for user guidance

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@coderabbitai review


Update Makefile URLs

Hugging face urls had errors:

Results/Metrics isn't an existing directory, only Results exists
./Model was written twice

I ran the code again and it is working for me. So I am closing the pull request.

Hi there,
if you click your hugging face Repo on our Run you will see it has a 404
error, it's not loading the data to the space cause of the URL issues. I
had the same issue even though it wrote "successful", the Space was not
being populated
On Mon, Dec 2, 2024 at 4:12 PM Abid Ali Awan @.***>
wrote:

I ran the code again and it is working for me. So I am closing the pull
request.
—
Reply to this email directly, view it on GitHub
https://github.com/kingabzpro/CICD-for-Machine-Learning/pull/4#issuecomment-2511652123,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKJPH3FXYKANOIFKXHP4KRT2DRTE3AVCNFSM6AAAAABS2PUTKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJRGY2TEMJSGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

It is working https://huggingface.co/spaces/kingabzpro/Drug-Classification

Just letting you know as a user that I encountered that error after
following your tutorial on Data Camp. The URL link issues made my project
not get pushed to the Spaces even though the Run ran successfully. In the
tutorial you used different folder names, eg there was no "Metrics" dir.
Took me quite a while to find the issue , only trying to help. Have a good
day and great project!
On Mon, Dec 2, 2024 at 4:59 PM Abid Ali Awan @.***>
wrote:

It is working https://huggingface.co/spaces/kingabzpro/Drug-Classification
—
Reply to this email directly, view it on GitHub
https://github.com/kingabzpro/CICD-for-Machine-Learning/pull/4#issuecomment-2511772243,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKJPH3GDZ3XGF2AOPUSHPRL2DRYWRAVCNFSM6AAAAABS2PUTKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJRG43TEMRUGM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Data refresh

#692

data animation every 15s is not visible.

it seems that there is no update every 15 sec.
when we do have a change in data, it is so minor the animation is not visible.

i'll need to add another indication (will open this as a different task).
meaning, if this is too "heavy" on the site/performance, you can remove the animation every 15s (keep the initial load animation)


Reordering commits confuses spr

I had a small stack with commits A, B, and C like this:

C
B
A

Then I noticed a small issue that could (should?) have been commit D, but instead it was so obviously semantically part of A that I decided to change the two files and use git amend, which works splendidly:

C
B
A’

However, since the unit of PR is commit, not set of commits, each commit must be valid individually. Which is good, just sometimes uncomfortable. Problem was, my fix in A’ depended on something in C, so the Github checks on A’ failed. Instead of just skipping them or trying to amend again somehow and perhaps use that D commit after all, I decided on a nice and clean solution with git rebase --interactive, just reordering the commits:

B
A’
C

Well, I guess I did something forbidden here and just have myself to blame. Anyway, git spr update didn’t like that too well and spew out a stacktrace which I have to anonymize a bit:

$ git spr update
> git rev-parse --show-toplevel
> git fetch
> git rebase origin/develop --autostash
> github fetch pull requests
> git log --format=medium --no-color origin/develop..HEAD
> git branch --no-color
> git log --format=medium --no-color origin/develop..HEAD
> github update 647 : Commit message for A’
> git status --porcelain --untracked-files=no
> git push --force --atomic origin ac60c07cee3c8aceeab4c1573c8de6c540c76010:refs/heads/spr/develop/5fc9eaba 57e5fa9fde824c159e4dbf02520e49e0313f5ffd:refs/heads/spr/develop/6ce18307 8f612db3ae8be108308ebcef4c7f58eb05c5de52:refs/heads/spr/develop/c6bfa480
> github create 650 : Commit message for B
panic: createPullRequest: A pull request already exists for Organization:spr/develop/6ce18307.
goroutine 1 [running]:
github.com/ejoffe/spr/github/githubclient.check({0x995c20, 0xc00041a7f8})
     /Users/runner/work/spr/spr/github/githubclient/client.go:696 +0xf4
github.com/ejoffe/spr/github/githubclient.(*client).CreatePullRequest(0xc000122810, {0x999390, 0xcc85c0}, {0x9992b0, 0xc0001227f8}, 0xc00031dcc0, {{0xc00021b4f9, 0x8}, {0xc00021b417, 0x28}, ...}, ...)
     /Users/runner/work/spr/spr/github/githubclient/client.go:404 +0x599
github.com/ejoffe/spr/spr.(*stackediff).UpdatePullRequests(0xc00012a7e0, {0x999390?, 0xcc85c0}, {0xcc85c0, 0x0, 0x0}, 0x0)
     /Users/runner/work/spr/spr/spr/spr.go:216 +0xe66
main.main.func4(0xc0001e39e0?)
     /Users/runner/work/spr/spr/cmd/spr/main.go:161 +0x10f
github.com/urfave/cli/v2.(*Command).Run(0xc0001e39e0, 0xc00012d040)
     /Users/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.8.1/command.go:169 +0x5eb
github.com/urfave/cli/v2.(*App).RunContext(0xc000103a00, {0x999390?, 0xcc85c0}, {0xc00012e000, 0x2, 0x2})
     /Users/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.8.1/app.go:341 +0xb05
github.com/urfave/cli/v2.(*App).Run(...)
     /Users/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.8.1/app.go:247
main.main()
     /Users/runner/work/spr/spr/cmd/spr/main.go:230 +0x133b

(Interesting paths embedded in the Go binaries. Make mental note to look out for this when using Go myself.)
Also note “github update 647 : Commit message for A’” which updated the existing PR, and “github create 650 : Commit message for B” which tried a new PR instead of changing the existing 648.
So, could I have done it cleanly with spr? If not, would it be possible to implement? Or shall I submit a proposal for a warning in the README?

This sounds like a bug. SPR actually has logic to handle reordering of commits.
I will try to recreate this case and see what the root cause it.

Hi,
Today, I had 2 commits and reordered them.
After updating, git spr closed the PR's that where open before and created new PR's.
This is not beneficial, as the older PR's had some comments on them that I still wanted to address. Is this the way git spr works ?
I would be better to keep the PR's and just change the merge branch.


docs: Fix broken links of object_store_opendal README

Which issue does this PR close?
Fix docs typo.
Rationale for this change
Fix typo
What changes are included in this PR?
A typo fix
Are there any user-facing changes?
None

Sorry for submitting a broken link in README. Fixed now. cc @alamb for a review, thanks!

Thanks @Xuanwo


chore: use codspeed for benchmark

Current dependencies on/for this PR:

main

PR #67   👈

This stack of pull requests is managed by Graphite.


Embed JSON syntax between {% schema %} and {% endschema %}

Shopify uses the {% schema %} tag to define the "schema" of a theme section.
The schema is a JSON document that describes the section and its settings.
See https://help.shopify.com/en/themes/development/sections#using-section-schema-tags

Hi @braver,
Please have a look at this PR.
I have a few more changes I'd like to propose, but before I'd like to be sure this project is still active.
Best Regards,
Benoit

Oh, sorry, I must have missed this PR or clicked away the notification and didn't remember. It's alive in the sense that I'm active and reachable, but not currently super actively using Liquid. If you have anything else, wanna make all that into a single PR so that we can review talk about that as one big update?

Depending on the color scheme you use you probably have noticed that the {% schema %} tag itself is not highlighted like the other tags. Adding schema|endschema to the liquid tag schema doesn't do anything here because capturing the schema tags is handled completely in the block you added to Liquid-HTML. Because we want to highlight the contents as JSON, this is probably the simplest approach, but that also means you have to capture and scope all the parts of {% schema %}.
You put this on the right track though. I figured it would be easier to just give an example here. Check this commit: https://github.com/braver/sublime-liquid/commit/714fa6cdf113c91625454386978b981652056806

Thanks @braver.
I'll make more PRs.

Any plans to update Package Control with these commits? I needed to download this package from GH and install manually to get JSON highlighting inside {% schema %} tags working, as it seems the PC package hasn't been updated since this commit.

Oh, I guess I completely forgot about that. Release 1.3.0 is out right now!


Option to select sia executable and modify config.json when siad isn't found

Fixes #76 Option to select sia executable and modify config.json when siad isn't found
Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found Option to select sia executable and modify config.json when siad isn't found

typo in the post body

Looks good to me


#MessageBytes toString rollback

I think toString method should not change the object's status. Because this method is used for return a String. Most people think they can get object's stringValue from this method, and will not change the object's status.
The issue I found: After I integrate openTelemetry with my tomcat web services, the service always return 404. The openTelemetry use the toString method, then tomcat think it is a str not byte and return 404 error.

Hmm. A similar issue has been raised by other user before, look this https://lists.apache.org/list?users@tomcat.apache.org:2023-3:openTelemetry
Hope this helps.

Thanks a lot~. And I still have one question: Is the toString method changing object status a good behavior?

Thanks a lot~. And I still have one question: Is the toString method changing object status a good behavior?

No, not a good behavior. This Class has been refactored before to solve some issues, and I'm not familiar with this, you can post your question to user mailing list to discuss. ; )


How do I turn a pcap into a bagFile that is available

Hi,
I have some pcap files that were collected in velodyne VLP16, and I converted them into bagFile in the following way.
roscore
rosrun velodyne_driver velodyne_node _model:=VLP16 _pcap:=data.pcap _read_once:=true
rosrun rosbag record -O out.bag /velodyne_packets
After running them in a separate terminal, to generate the out.bag, but when I ran the following command, the rviz window did not show the point cloud image I wanted.
rosbag play out.bag --clock --topic /velodyne_packets /imu/data
I want to know is that I have a problem generating process of bag, or other place is wrong? Or is there a way to directly use the pcap file as input to the LeGO-LOAM?
I am a new user of ROS, looking forward to your reply. Thank you very much!

Ok, I've solved this problem, I left out velodyne_pointcloud for the steps above.It feels a little cumbersome, but it's useful. If you want to do real time processing should be use velodyne_pointcloud directly is ok.


Handle targetPort set to a name

The simple example (btw it is a popular guestbook k8s example in official k8s repo) I'm moving from k8s to Istio has the following in the service yaml:
type: LoadBalancer
ports:

port: 3000
targetPort: "http-server"

I had to change that to the targetPort... Would be nice to support this to simplify user's onboard experience onto Istio.

@linsun I just tried this configuration (with targetPort) and it's functioning correctly:
apiVersion: v1
kind: Service
metadata:
  name: productpage
  labels:
    app: productpage
spec:
  ports:
  - port: 9082
    targetPort: httpport
    name: http
  selector:
    app: productpage
---
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: productpage-v1
spec:
  replicas: 1
  template:
    metadata:
      labels:
        app: productpage
        version: v1
    spec:
      containers:
      - name: productpage
        image: istio/examples-bookinfo-productpage-v1:1.5.0
        imagePullPolicy: IfNotPresent
        ports:
        - name: httpport
          containerPort: 9080

with:
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: bookinfo
spec:
  hosts:
  - "*"
  gateways:
  - bookinfo-gateway
  http:
  - match:
    - uri:
        exact: /productpage
    - uri:
        exact: /login
    - uri:
        exact: /logout
    - uri:
        prefix: /api/v1/products
    route:
    - destination:
        host: productpage
        port:
          number: 9082

Is it the scenario you referred to?

I just ran into this and it took the majority of a day to troubleshoot. I know this is a stale issue, but both the above examples have merit.
Specifically, I ran into the same issue (using the same example @linsun did). I also confirm @ymesika 's example works as they pointed out.
Working through several permutations, it seems that the named "targetport" is not the underlying issue, but rather if you do not specify the "name" field in the Service spec ports, then trouble arises.
Also, and this is probably the most important part for me, I had no issues when using a VirtualService and no authentication. The issue arose when I added an Auth Policy (JWT). I could not get the origin authentication to work until the port name was added in the service spec.
Cheers!


fix(http.js): allow disabling trace id propagation in http

:tada: This PR is included in version 1.69.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[2201.1.1] Add github subscription

Purpose
Add github subscription via websub
Goals
Resolves https://github.com/wso2-enterprise/choreo/issues/14033
Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Related PRs
https://github.com/ballerina-platform/asyncapi-triggers/pull/74
Test environment
2201.1.1
Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Closing as per https://github.com/wso2-enterprise/choreo/issues/14033#issuecomment-2329033317


Should social accounts auto-link on email address?

Currently when logging in with a social account it will only allow login if the account is linked to a user. If a matching email is found it will not auto-link based on email address but advise the user should link their account in settings.
Similarly, When registering via a social account it will display an error if the user already exists and they're required to log in to link their account.
It would be a nicer user experience to simply always link on email address if possible.
Just wondering if anyone has any thoughts on the security of linking based on email address?
Really I suppose it comes down to the security of the oAuth service but if it's trusted for new registrations it might as well be trusted for linking to existing contacts?

Additional thought, By doing this some of the social auth code could be cleaned up quite a bit since the registration/login actions could essentially have the same logic.

My current thinking is that it could be circumvented by updating a random account on the OAuth provider side to the desired email address, and if that email address (despite it's pending verification status on the provider end), is passed to Bookstack, could be used to gain entry if auto-linking is enabled.
That being said, what I would like is the option to auto-create and auto-link for Google users that are in a specified G Suite organisation, as well as memberships based on G Suite groups so the user is just presented with a 'Log in with Google' button that works regardless of whether they've visited it before 🙃

I would also like to see this behaviour and a registration/login flow as described by @jordankueh. Combined with "remember me" working for social logins (#847), all the users of a linked domain would have to do is click "Log in with Google", once, to log in securely. The first time would require them to confirm their email address.

@ffub why confirming the email address is required when the email was already verified by Google? I think the email verification should be skipped for users authenticating with Google. i.e. you cannot use someone else's email to login with Google so there is no need to verify the identity (that was the purpose of the Google Auth).
Does it make sense?
Do you guys have an update on these automatic signup features for social login? That is a blocker on my side to fully use the tool.

Attempt of PR here #966
Let me know what you think :)

This flow is now optionally possible as described here: https://github.com/BookStackApp/BookStack/pull/966#issuecomment-423610250
Therefore I'll now close this.


October release notes

We need to publish October release notes article to give overview of changes made in Artipie during the month

@olegmoz could you please unload the list of closed issues for this month for me?

@olenagerasimova sure, here is list for last 30 days (may include some issues from late September):

#359 - use StorageHasRepoMd: https://github.com/artipie/rpm-adapter/pull/371
#359 - Verify repomd.xml: https://github.com/artipie/rpm-adapter/pull/370
#368 - Upgraded HTTP to 0.16.7, migrated to BasicAuthSlice: https://github.com/artipie/rpm-adapter/pull/369
#144 - Change docker image: https://github.com/artipie/npm-adapter/pull/146
#140 - HTTP upgraded to 0.16.7, migrated to BasicAuthSlice: https://github.com/artipie/npm-adapter/pull/145
#141 - NpmProxyITCase disabled: https://github.com/artipie/npm-adapter/pull/143
#141 - Use TestResource in NpmIT: https://github.com/artipie/npm-adapter/pull/142
#137 - Integration tests enabled, NpmCommandsTest renamed to NpmIT: https://github.com/artipie/npm-adapter/pull/138
#89 - Fix NpmProxyITCase: https://github.com/artipie/npm-adapter/pull/136
#89 - Use PublisherAs instead of Concatenation: https://github.com/artipie/npm-adapter/pull/135
#119 - Fix time field in meta.json: https://github.com/artipie/npm-adapter/pull/134
#119 - Add disabled test for time in meta.json: https://github.com/artipie/npm-adapter/pull/133
#129 - Fix NPM publish test: https://github.com/artipie/npm-adapter/pull/132
#127 - Use testContainer: https://github.com/artipie/npm-adapter/pull/131
#123 - Moved proxy docs to root README.md with some modifications: https://github.com/artipie/npm-adapter/pull/130
#123 - Moved proxy code to root: https://github.com/artipie/npm-adapter/pull/128
#122 - Fixed & refactored NpmCommandsTest: https://github.com/artipie/npm-adapter/pull/126
#124 - Removed codecov upload phase from maven.yml: https://github.com/artipie/npm-adapter/pull/125
#284 - cache impl to load from remote: https://github.com/artipie/asto/pull/285
#605 - Verify with authentication in npmIT: https://github.com/artipie/artipie/pull/721
#700 - Deprecated classes usage removed in SliceFromConfig: https://github.com/artipie/artipie/pull/720
#715 - pypi proxy IT: https://github.com/artipie/artipie/pull/719
#605 - Verify publish in NpmITCase: https://github.com/artipie/artipie/pull/717
#714 - pypi proxy: https://github.com/artipie/artipie/pull/716
#605 - npmInstall ITCase: https://github.com/artipie/artipie/pull/710
#700 - Deprecated classes usage removed in AuthAndPermissionsTest: https://github.com/artipie/artipie/pull/709
#694 - HTTP upgrade for fixed GroupSlice: https://github.com/artipie/artipie/pull/708
#692 - Extracted FileProxy and supported auth: https://github.com/artipie/artipie/pull/707
#693 - Updated Maven proxy cache config format: https://github.com/artipie/artipie/pull/705
#692 - Added FileProxyAuthIT: https://github.com/artipie/artipie/pull/704
#694 - Support for multiple remotes in Maven proxy: https://github.com/artipie/artipie/pull/703
#693 - Added cache method to ProxyConfig: https://github.com/artipie/artipie/pull/702
#690 - use CredsConfigYaml, correct Users.FromStorageYaml and readme: https://github.com/artipie/artipie/pull/699
#693 - Docker upgraded to 0.4.8: https://github.com/artipie/artipie/pull/698
#693 - Using proxy config in Docker proxy: https://github.com/artipie/artipie/pull/696
#690 - use CredsConfigYaml: https://github.com/artipie/artipie/pull/695
#690 - CredsConfigYaml created: https://github.com/artipie/artipie/pull/691
#608 - Updated docs for maven proxy configuration: https://github.com/artipie/artipie/pull/689
#677 - Add ctor with port in ArtipieServer: https://github.com/artipie/artipie/pull/688
#608 - Using RepoConfig in MavenProxy: https://github.com/artipie/artipie/pull/687
#633 - Response 404 to request not related to repos: https://github.com/artipie/artipie/pull/686
#608 - ProxyRepoConfig and YamlProxyRepoConfig: https://github.com/artipie/artipie/pull/685
#674 - Using GenericAuthenticator in MavenProxy: https://github.com/artipie/artipie/pull/683
#652 - Verify with authentication in pypiIT: https://github.com/artipie/artipie/pull/682
#680 - separate profile for IT: https://github.com/artipie/artipie/pull/681
#602 - NuGet tests disabled: https://github.com/artipie/artipie/pull/678
#660 - use RepoConfigYaml instead of RepoPerms: https://github.com/artipie/artipie/pull/676
#602 - Verify install nugetIT: https://github.com/artipie/artipie/pull/675
#338 - HTTP upgraded to 0.16.5: https://github.com/artipie/docker-adapter/pull/340
#338 - Using HTTP client auth: https://github.com/artipie/docker-adapter/pull/339
Update http to 0.16.2: https://github.com/artipie/docker-adapter/pull/337
#256 - Group slice error handling: https://github.com/artipie/http/pull/257
#253 - added header value regex to RtRule.ByHeader: https://github.com/artipie/http/pull/255
#253 - RtRule.ByHeader created: https://github.com/artipie/http/pull/254
#251 - StatefulResponse renamed to CachedResponse and fixed: https://github.com/artipie/http/pull/252
#249 - Authentication.Anonymous created: https://github.com/artipie/http/pull/250
#247 - created BasicAuthSlice: https://github.com/artipie/http/pull/248
#211 - Fix rsStatus of head, add disabled test for MavenProxySliceIT: https://github.com/artipie/maven-adapter/pull/218
Updated http and http-client: https://github.com/artipie/maven-adapter/pull/217
#215 - remove unused classes and update asto: https://github.com/artipie/maven-adapter/pull/216
#212 - HeadProxySlice unit test: https://github.com/artipie/maven-adapter/pull/214
#212 - HeadProxySlice fixed: https://github.com/artipie/maven-adapter/pull/213
#204 - Authentication support in proxy: https://github.com/artipie/maven-adapter/pull/210
#138 - Using UriClientSlice in proxy: https://github.com/artipie/maven-adapter/pull/205
#197 - Add MavenProxyITCase: https://github.com/artipie/maven-adapter/pull/203
#197 - fixed and tested RepoHead and MavenProxySlice: https://github.com/artipie/maven-adapter/pull/202
#135 - search fully implemented: https://github.com/artipie/pypi-adapter/pull/144
#135 - artifact was found on search: https://github.com/artipie/pypi-adapter/pull/143
#130 - added test for proxy auth: https://github.com/artipie/pypi-adapter/pull/142
#129 - headers for cached items in ProxySlice: https://github.com/artipie/pypi-adapter/pull/141
#135 - artifact not found branch: https://github.com/artipie/pypi-adapter/pull/140
#129 - test for proxy with pip: https://github.com/artipie/pypi-adapter/pull/139
#135 - read summary from metadata: https://github.com/artipie/pypi-adapter/pull/138
#135 - project name from xml: https://github.com/artipie/pypi-adapter/pull/137
#135 - test for search command: https://github.com/artipie/pypi-adapter/pull/136
#128 - added IndexProxySliceTest: https://github.com/artipie/pypi-adapter/pull/134
#128 - IndexProxySlice created: https://github.com/artipie/pypi-adapter/pull/133
#131 - update http: https://github.com/artipie/pypi-adapter/pull/132
#126 - proxy index request: https://github.com/artipie/pypi-adapter/pull/127
Enable logs for tests: https://github.com/artipie/gem-adapter/pull/80
Bumped http and ppom: https://github.com/artipie/gem-adapter/pull/75
#1 - Dependencies bump: https://github.com/artipie/vertx-server/pull/28
Resolve conflict between tf and cl headers: https://github.com/artipie/vertx-server/pull/27
#40 - Sending empty headers and body to remote in Proxy: https://github.com/artipie/files-adapter/pull/41
#37 - Authentication support in proxy: https://github.com/artipie/files-adapter/pull/39
#37 - HTTP client upgrade, UriClientSlice usage: https://github.com/artipie/files-adapter/pull/38
#72 - HTTP upgraded to 0.16.7, migrated to BasicAuthSlice: https://github.com/artipie/helm-adapter/pull/73
#25 - JettyClientSlices.client() method removed: https://github.com/artipie/http-client/pull/70
#51 - Bearer support in GenericAuthenticator: https://github.com/artipie/http-client/pull/69
#51 - Params and auth for token request in BearerAuthenticator: https://github.com/artipie/http-client/pull/68
#66 - Copying request body inside AuthClientSlice: https://github.com/artipie/http-client/pull/67
#51 - Added BearerAuthenticator: https://github.com/artipie/http-client/pull/65
#51 - Added TokenFormat and OAuthTokenFormat: https://github.com/artipie/http-client/pull/64
#51 - Authenticator changed to by async: https://github.com/artipie/http-client/pull/63
#50 - AuthClientSlice and UriClientSlice documented: https://github.com/artipie/http-client/pull/62
#50 - Anonymous Authenticator and it's support in AuthClientSlice: https://github.com/artipie/http-client/pull/61
#50 - Fixed issue with AuthClientSlice closing response before handled: https://github.com/artipie/http-client/pull/60
#50 - Added GenericAuthenticator: https://github.com/artipie/http-client/pull/59
#67 - Fixed stop order in HttpServer to prevent possible hang ups: https://github.com/artipie/http-client/pull/58
#33 - Added UriClientSlice: https://github.com/artipie/http-client/pull/56
#50 - AuthClientSlice added: https://github.com/artipie/http-client/pull/55
#33 - Added PathPrefixSlice: https://github.com/artipie/http-client/pull/54
#50 - Added Authenticator and Authenticator.Basic: https://github.com/artipie/http-client/pull/53
IT case with client slices and vertx: https://github.com/artipie/http-client/pull/49
#5 - september release notes: https://github.com/artipie/blog.artipie.com/pull/6


MATH: Analyze 3475 -> 3659

Findings can be reported at https://leanprover.zulipchat.com/#narrow/channel/458659-Equational/topic/Outstanding.20equations.2C.20v1

claim

disclaim

Analysis appears in https://github.com/teorth/equational_theories/pull/685 and also https://leanprover.zulipchat.com/#narrow/channel/458659-Equational/topic/Outstanding.20equations.2C.20v1/near/477917205 .

disclaim

Closed by #717


Update to kube v1.17

Signed-off-by: Humble Chirammal<EMAIL_ADDRESS>Describe what this PR does
Provide some context for the reviewer
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:

Kubernetes links that explain why the change is required
CSI spec related changes/catch-up that necessitates this patch
golang related practices that necessitates this change

Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.

@Madhu-1 PTAL .

@humblec I think we need to  close https://github.com/ceph/ceph-csi/pull/775 and update this PR template

@humblec I think we need to close #775 and update this PR template

Sure, closing the same.


Theedge 3683 fix select all

Description
For inventory list, implement the select all functionality.
Applying filters and pagination.
Fix enable/disable
Fix count
THEEDGE-3683.webm
Fixes # (THEEDGE-3683)
Type of change
What is it?

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I run npm run lint:js:fix to check that my code is properly formatted

Codecov Report
Attention: 44 lines in your changes are missing coverage. Please review.

Files
Coverage Δ

src/Routes/Devices/DeviceTable.js
33.11% <100.00%> (+0.43%)
:arrow_up:

src/components/general-table/createFilterValues.js
100.00% <ø> (ø)

src/api/devices/index.js
35.71% <0.00%> (-2.75%)
:arrow_down:

src/components/general-table/GeneralTable.js
61.53% <50.00%> (+0.33%)
:arrow_up:

src/hooks/usePromiseQueue.js
20.00% <20.00%> (ø)

src/hooks/useFetchBatched.js
10.00% <10.00%> (ø)

src/components/general-table/BulkSelect.js
5.71% <0.00%> (-9.68%)
:arrow_down:

:loudspeaker: Thoughts on this report? Let us know!


REVIT 2022

how to allow installation on REVIT 2022 ?

Hi
I can install for Revit 2022.
I have modified this files

Modify this file

PackageContents.xml

inside "Contents", copy folder 2021 to folder 2022
But i dont say how i can modify source code.
nice day

So far I see in the code, the installer has not been added to the solution. @vinnividivicci are you able to share the installer config files?

@Darkkrynn this works for R22 no problem, however for R23 not so much. It'll show up but when you try to export anything it just hangs. I emailed the devs and it looks like they've retired it and have made it available for the community to proceed.

I have change bimone by diroots sheetlink


Want to hide the first row values of the columns

STOP
We do not track feature requests through Github. Please use the Spectrum React Table Forum to talk about new ideas and features.

https://spectrum.chat/react-table