Media still looping with loop={false}

Hello again! I am working from the same setup that I described in #23. I swear this was working before I'd solved that problem, but now my media loops despite setting the loop prop to false. This was actually the problem we set out to solve by upgrading the package!
Here's the outermost container:
export class CallPlayerContainer extends Component {
  static propTypes = {
    ...
  };

  componentWillReceiveProps(nextProps) {
    const {
      displayOnly,
      callPlayer,
      media
    } = nextProps;

    if (!displayOnly && media.isPlaying !== !!callPlayer.get('active')) {
      media.playPause();
    }
  }

  isStale() {
    const { record } = this.props;
    const duration = record.getIn(['call', 'duration']);
    const occurredAt = moment(record.getIn(['call', 'occured_at']));
    return duration === 0 || occurredAt.isBefore(moment().subtract(90, 'days'));
  }

  render() {
    const toggle = () => {
      const {
        record,
        callPlayer,
        customPlayPause,
        actions: { playPause: defaultPlayPause }
      } = this.props;

      (customPlayPause || defaultPlayPause)(record, !!callPlayer.get('active'));
    };

    return (
      <CallPlayer {...this.props} toggle={toggle} isStale={this.isStale()} />
    );
  }
}

const Connected = withMediaProps(connect(
  ...
)(CallPlayerContainer));

export default props => (
  <Media>
    <Connected {...props} />
  </Media>
);

And here's the <CallPlayer />
export default function CallPlayer(props) {
  const { toggle, src, record } = props;

  const tooltipText = record.getIn(['call', 'duration']) === 0 ?
    I18n.t('lead.tooltip.duration_is_zero') : I18n.t('lead.tooltip.over_ninety_days');

  return (

        <Player src={src} loop={false} />

        <LeadTitle toggle={toggle} {...props} message={tooltipText} />
        <PlayBar {...props} message={tooltipText} />

  );
}

Any idea why it might be looping?

Ah dang 😞  sorry about that. I'll look at this ASAP. Hopefully tomorrow or later this week. If you want to take a look, this is where looping is handled. Wondering if something is preventing onEnded from being called.

Thanks for the link. I set a breakpoint in that handler and it does fire at the end of the call. loop evaluates to false so we're good there. Then when I get to the end of the handler, the onEnded prop is undefined. I tried passing in my custom toggle function:
        <PlayBar {...props} message={tooltipText} onEnded={toggle} />

but it remains undefined at execution time. Hope that helps narrow it down.

Actually I have to correct myself. The above only works if I pause at a breakpoint to inspect things. If I clear the breakpoints, the call continues looping and an error is raised.
Uncaught (in promise) DOMException: The play() request was interrupted by a call to pause().

Interesting.. I'm guessing somewhere onEnded is getting dorked. Thanks for digging in a little more! I appreciate the help. Still busy with other things right now. But this will be the first thing I look at when I get a chance.

@souporserious Just making sure this doesn't go stale. We might be revisiting this in the next couple weeks. I totally get that OSS doesn't pay the bills though.

Sorry, I've been trying to find time for this. I'm hoping to be able to fix this along with another bug we found in our app.
I was also going to start looking at allowing the library to play with Redux better. This is my initial sketch for what I thought it could look like:
const onPlayPause = (isPlaying) => dispatch(isPlaying)

<Media state={reduxStoreOrWhatever} callbacks={{ onPlayPause }}>
  <Player src={...}/>
  <PlayPause/>
</Media>

Does that makes sense and does it seem like it could work? Sorry if that's totally wrong haha, I don't have much experience with Redux yet.

Currently, react-media-player tells us whether or not it's playing. I think the key to having this work with redux is that we should tell it whether or not it's playing. So instead of relying on the media object to control play/pause behavior, maybe it would be something like:
<Media isPlaying={somePropFromMyReduxStore} onPlayPause={someActionBoundToDispatch}>

Your code could then use its own state & callbacks if the user hasn't provided any. If they have been provided, we would only use the media object for things like seekTo, etc, and allow the user provided props to control whether or not the media is playing.
Another option would be to do something like react-player has done, where simply attaching a ref to the ReactPlayer component gives you total control over its behavior. This would work fine with redux as well.
I'm not sure how well either one of these works with your current design. Maybe there are other ways.

 And based on what props it received, it would call the internal vendor methods like play, pause, etc. I just took a look at react-player and it seems like they do something like this.
Then you could add the Media component as a helper if you wanted or build your own if you needed Redux or something similar. I think doing it that way would avoid having to pass callbacks and state to Media and just get rid of it all together if you don't need it since it's somewhat acting like a store. Does that sound like it would work?
Thanks for the feedback! I appreciate it :)

Yes, I think you could render the Media component completely obselete. You could also expose hooks into the Player component that report the current time or any other data that the controls rely on.


lora_target_modules default wrong

Hi,
Thanks a lot for uploading DNABERT2.
I have noticed a small mistake when using lora, the default lora_target_modules ["query", "value"] do not seem to be correct. Through trial and error ["q", "v"] worked for me.

Hi,
Thank you very much for identifying this! This actually depends on the naming of layers in each model. The best way is to load and print model layer names before setting this parameter. Will update the README soon to explains more on this. Thanks!


Complemental k-mers are not handled correctly

input (the first k-mer is the reverse complement of the second):
>two_complemental_kmers
AAAAGCCTGAGAAGATATCTTCTCAGGCTTTT

command:
$ cuttlefish build -s test.fa -k 31 -t 8  -o test.cuttlefish.fa -w cuttlefish_tmp --ref -c 1

Constructing the compacted reference de Bruijn graph for k = 31.

Enumerating the edges of the de Bruijn graph.
**

Structural information for the de Bruijn graph is written to test.cuttlefish.fa.json.
Error: Cannot open temporary file ./kmc_01021.bin

Usage :
[...]

No output file produced. Expected output file e.g.:
>0
AAAAGCCTGAGAAGATATCTTCTCAGGCTTT

version:
$ cuttlefish --version
cuttlefish 2.2.0
Supported commands: `build`, `help`, `version`.
Usage:
	cuttlefish build [options]

Apparently, complemental k-mers are not treated correctly.

It seems there was an error opening the output file?
Error: Cannot open temporary file ./kmc_01021.bin

Hi @sebschmi:
It seems like a problem with opening enough temporary files in your platform. Please see the solution here: https://github.com/COMBINE-lab/cuttlefish#note.
Thanks.

Hi @sebschmi: sorry for the delay in reply! Due to the design of the algorithm, Cuttlefish 2, as is, is not able to construct the de Bruijn graph with thresholds on the k-mer frequencies instead of on the (k + 1)-mer frequencies.


how can run workerman on https .i have error

this is my code
<?php

use Workerman\Worker;

require_once __DIR__ . '/vendor/autoload.php';

// SSL context.
$context = array(
    'ssl' => array(
        'local_cert'  => 'server.crt',
        'local_pk'    => 'server.key',
        'verify_peer' => false,
    )
);

// Create a Websocket server with ssl context.
$ws_worker = new Worker('https://<IP_ADDRESS>:3000', $context);

// Enable SSL. WebSocket+SSL means that Secure WebSocket (wss://).
// The similar approaches for Https etc.
$ws_worker->transport = 'ssl';

$ws_worker->onMessage = function ($connection, $data) {
    // Send hello $data
    $connection->send('Hello ' . $data);
};

Worker::runAll();

but have error :
start in DAEMON mode
[root@*** ]# PHP Fatal error:  Uncaught Exception: class \Protocols\Https not exist in */vendor/workerman/workerman/Worker.php:2321
Stack trace:
#0 /*/vendor/workerman/workerman/Worker.php(2243): Workerman\Worker->parseSocketAddress()
#1 /*/vendor/workerman/workerman/Worker.php(679): Workerman\Worker->listen()
#2 /*/vendor/workerman/workerman/Worker.php(538): Workerman\Worker::initWorkers()
#3 /*/start.php(28): Workerman\Worker::runAll()
#4 {main}
  thrown in /*/vendor/workerman/workerman/Worker.php on line 2321

Fatal error: Uncaught Exception: class \Protocols\Https not exist in /*/vendor/workerman/workerman/Worker.php:2321
Stack trace:
#0 /*/vendor/workerman/workerman/Worker.php(2243): Workerman\Worker->parseSocketAddress()
#1 /*/vendor/workerman/workerman/Worker.php(679): Workerman\Worker->listen()
#2 /*/vendor/workerman/workerman/Worker.php(538): Workerman\Worker::initWorkers()
#3 /*/start.php(28): Workerman\Worker::runAll()
#4 {main}
  thrown in /*/vendor/workerman/workerman/Worker.php on line 2321

Change $ws_worker = new Worker('https://<IP_ADDRESS>:3000', $context); to $ws_worker = new Worker('http://<IP_ADDRESS>:3000', $context);.


How to migrate to v1?

Is your feature request related to a problem? Please describe.
I cannot find Jimp's docs on how to use it in > v1.0.0. Where's it ? :)
Describe the solution you'd like
I have the old code I don't know how to migrate:
async function optimizeBase64Image(base64Image: string): Promise<string> {
  const image = await Jimp.read(Buffer.from(base64Image, "base64"));
  const resizedImage = await image.resize(512, Jimp.AUTO).quality(80).getBufferAsync(Jimp.MIME_JPEG);

  return Buffer.from(resizedImage).toString("base64");
}

Describe alternatives you've considered
Tried to find docs, with no success.
Additional context

I've added a migration guide here
http://jimp-dev.github.io/jimp/guides/migrate-to-v1/
if you find anything else confusing feedback welcome!

Thanks so much! <3


Better example for UseLet rule

Fixes #6552
Added a better example for UseLet rule, that can't be rewritten in a shorter form.

Warnings

:warning:
It looks like this PR contains functional changes without a corresponding test.

:warning:

It looks like you're editing the versioned copy of our website. This affects only users on the 'current' version of detekt, and it's correct only if you intend to fix the documentation for an already released version of detekt. Most of the time you want to update also the docs inside website/docs/ as well, so this change will reflect also for documentation on future versions of detekt.

Messages

:book:

Thank you very much for making our website better :heart:!

  Generated by :no_entry_sign: dangerJS against 18f8cd2ff8b0156c5ea613c3db7ce50fa6fc6b40

Thank you!


Failed to pull v1.6.0 images on OCP 4.7 environment

Hi team,
On OCP 4.7 environment, I can see that OLM have upgraded the operator to v1.6.0, but the related PODs failed to be running due to ImagePullBackOff.
# date; oc -n ibm-block-csi get pod
Thu Jun 10 09:51:55 CST 2021
NAME                                     READY   STATUS             RESTARTS   AGE
ibm-block-csi-controller-0               5/6     ImagePullBackOff   0          26m
ibm-block-csi-node-cdtfk                 2/3     ImagePullBackOff   0          26m
ibm-block-csi-node-dgsth                 2/3     ImagePullBackOff   0          48m
ibm-block-csi-node-qrwfs                 3/3     Running            0          3d1h
ibm-block-csi-operator-c66f65b5c-bvj6f   1/1     Running            0          10h

Some details events as below:
  Normal   Pulling         27m (x2 over 28m)     kubelet            Pulling image "ibmcom/ibm-block-csi-driver-controller:1.6.0"
  Warning  Failed          27m (x2 over 28m)     kubelet            Error: ErrImagePull
  Warning  Failed          27m (x2 over 28m)     kubelet            Failed to pull image "ibmcom/ibm-block-csi-driver-controller:1.6.0": rpc error: code = Unknown desc = Error reading manifest 1.6.0 in docker.io/ibmcom/ibm-block-csi-driver-controller: manifest unknown: manifest unknown
  Warning  Failed          13m (x62 over 28m)    kubelet            Error: ImagePullBackOff
  Normal   BackOff         3m3s (x105 over 28m)  kubelet            Back-off pulling image "ibmcom/ibm-block-csi-driver-controller:1.6.0"

  Normal   Pulling    49m (x3 over 51m)    kubelet            Pulling image "ibmcom/ibm-block-csi-driver-node:1.6.0"
  Warning  Failed     49m (x3 over 50m)    kubelet            Failed to pull image "ibmcom/ibm-block-csi-driver-node:1.6.0": rpc error: code = Unknown desc = Error reading manifest 1.6.0 in docker.io/ibmcom/ibm-block-csi-driver-node: manifest unknown: manifest unknown
  Warning  Failed     49m (x3 over 50m)    kubelet            Error: ErrImagePull
  Warning  Failed     10m (x168 over 50m)  kubelet            Error: ImagePullBackOff
  Normal   BackOff    45s (x210 over 50m)  kubelet            Back-off pulling image "ibmcom/ibm-block-csi-driver-node:1.6.0"

I think the new release images didn't upload to the dockerhub docker.io/ibmcom. Could you help to fix it soon? Thanks.
Best Regards,
Bob

@lbscorpio,
Sorry on this, we had a faulty push of release candidate (OCP 4.7 pointed to latest image not version), the issue has been fixed 1 hour later and the latest images are back to be 1.5.0.
In order to fix your situation you will need to uninstall the driver CR and operator and than install the operator (should be 1.5.0).
Sorry for the inconvenience.

@roysahar-ibm Thanks for your update, I have used a workaround to use 1.5.0 only. You can close this issue if have fixed it, thanks.

@lbscorpio Thanks for the update - closing the issue.

@roysahar-ibm Seems that the issue was not fixed, I tried v1.6.0 again today and found different errors, have you tested on OCP 4.7 environment? Thanks.


Partial transparency and blur protocol

Description
I'm proposing you add a custom protocol (like KDE ones) that allows clients to specify a list of rectangles that should be kept opaque. I know you're a bit overwhelmed with requests and bug reports, this is a low priority suggestion that I think would be nice. It's questionable whether that many clients would support it though, so I guess you've got to add a "-1: when bored" label :smile:
Example usefulness: Code editor with transparent and blurred file tree but opaque text area and terminal.

Yeah the KDE protocol and linked ext- protocol won't cut it for my use case as I need to be able to control the transparency of the blur. Likely something similar but with a way to set the opacity would work for me. Having an alpha buffer available as another option could also be useful.
I'm also slightly confused about your use case @Caellian, as wouldn't leaving the rectangles opaque already stop a blur from being drawn there?

similar protocol for the hyprland- namespace.

KDE protocol and linked ext- protocol won't cut

I believed as much while proposing this. I did intend to propose hyprland- namespaced protocol because I can't see any which provide enough knobs and pulleys to cover hyprland features - that's why KDE has its own as well. In time fd might add some generic way to unify these for all compositors, but it could take a lot of time before that actually happens.
This has the benefit of allowing hyprland to add new decoration options in future and adding them to the protocol instead of waiting 3/4 years before being able to do so. A generic protocol might use some kv registry and region IDs to provide a way to set each value for some region ID separately, but that's just extra work and I don't see any benefits to it atm.

I'm also slightly confused about your use case @Caellian, as wouldn't leaving the rectangles opaque already stop a blur from being drawn there?

Having blur and transparency separate would allow removing blur on parts of the window while keeping them transparent. If you're putting in these options it might be little extra work to add support for both. There's definitely UI designs which could want to control them separately:

blur is necessary to make text legible
partial opacity without blur can be used for panels containing icons
mixing both can make very nice looking UIs

Ideally this would work with path regions instead of rectangles, but adding paths to this would be a lot of extra work which is why I'm only proposing rectangles. Adding corner radius to rectangles would be nice, but not necessary for v1 IMO, and can be added later without breaking previous functionality.
Basically something like
struct hypr_decoration_options {
  opacity: f32,
  blur_enabled: bool,
  blur_size: i32,
  blur_passes: i32,
  blur_noise: f32,
  blur_brightness: f32,
  blur_xray: bool,
  // etc., can be extended in future if new options are added
}

event set_region_decoration(region: wl_region, decoration: hypr_decoration_options);
event remove_region_decoration(region: wl_region);
event clear_region_decorations();
// commit and other events...

I'd state that behavior for overlapping regions as undefined, I don't see a sensible way to reason about it. If region is not specially configured by the client, it uses the default decoration values from hyprland.conf.

I was thinking about having two options.
The first option should work for all simple use cases, and mine specifically which is just fixing the opacity of popups as they fade out.

A region describing where the blur should apply
An alpha mapping that the blur alpha is clamped to from the surface alpha. (0.5 would cause blur_alpha = min(0.5, surface_alpha) * 2.0)

This second option should be a fallback for when the first is not enough:

An alpha buffer controlling the opacity of all pixels of the blur.

As for the blur options I'm not sure but if I remember correctly, changing those would force an additional blur with new parameters to be generated per region instead of being able to reuse existing blur, and I can't see it working well at a per-region level. @vaxerski is this correct?

correct, thats why options will not be accepted

changing those would force an additional blur with new parameters to be generated per region instead of being able to reuse existing blur

Ok, that makes sense.

@Caellian does my proposed protocol do enough for your use case?

@outfoxxed I don't have a use case :smile:, that's why I said "-1: when bored" priority initially.
I do think that storing pre-blur buffer and allowing clients to toggle between both transparency and blur would be cool though, but that's extra memory cost people might not be comfortable paying for. It could be a config setting as well I guess.


Delayed Pickup for crusher spirits

Is your feature request related to a problem? Please describe.
Crusher spirits have a bit of a habit of getting overly excited in their crushing. They will, for instance, pick up a diamond ore, crush it, then instantly pick up the diamond and crush it to dust.
Even when tossing them a large quantity, they'll inevitably pick up the last few items they crushed and re-crush them if possible. Makes it a bit difficult to work with things that have multiple crushing steps like gems or even cobble/gravel/sand.
Describe the solution you'd like
Implement a 3 second cooldown on all items dropped by the crusher spirits. During this 3 second period, no other crusher spirits can pick up these items. That should give plenty of time for a janitor or other collection system to pick up the items.
Additional context
Holy cow these guys are good at their job :D

Alternate solution: Give these guys a filter similar to the transporters.

Ah yes this totally should have been a thing from the start. I'll look into the cooldown first, because should be pretty simple - if not i'll go for the filter, as that has some merit in general (although, I think there is a certain charm in having to set up a chain of spirits and machinery instead of one thing that does it all [server admins generally do not appreciate that charm though :D ])


Adding Autosave feature after a successful combat

I am interested in giving a go at adding the functionality myself. What do you think the complexity of the task would be? I have only recently discovered this project and am still quite lost (mainly just playing it, it's a pretty good game!).
My current understanding is that it shouldn't be too hard to add the feature - saving is already there, just trigger it after a combat ends.
Further improvement could be adding some kind of settings checkbox to turn it on or off. I know some people wouldn't like the feature.

Thanks for opening a PR to support this issue. I'm glad you figured out how to update the save files after combat is over. I think we need to add a checkbox to toggle this feature on/off before I can accept it.
A big part of how I develop things for this is to load a save state and then do some stuff, then refresh to get back to the old state. So, this change would cause problems if I was testing something that required me to go through a few combats to verify it.
I think you could explore adding the checkbox by putting on next to the save/load buttons in the src/app/components/party-menu-component.html. You could have the checkbox write a value to localStorage and then read that value before saving when combat completes.

Closed by #27


Will this work with firmware v2.77 fan hack?

Hi,
will this HP-ILO-Fan-Control work also with 2.77 fan hack "ilo4_unlock (Silence of the Fans)" (https://github.com/kendallgoto/ilo4_unlock)? If not, are there any plans to bring support for it?
Thanks in advance!

Yes, it should work without any modifications!
The ssh commands used to manage the speeds are the same.

I'm running the 2.77 but I can't seem to get the fan ssh commands to work nor this.   I refresh the php and it goes back to 94% fan speed every time - I lower it and apply, and get a white screen of nothing.  when I refresh again it says 94%.
fans still deafeningly loud.  not sure where the problem is yet

I'm running the modified 2.77 from @kendallgoto  but I can't seem to get the fan ssh commands to work nor this.   I refresh the php and it goes back to 94% fan speed every time - I lower it and apply, and get a white screen of nothing.  when I refresh again it says 94%.
fans still deafeningly loud.  not sure where the problem is yet.  hp dl360p servers

Are you able to set the speeds from iLO ssh?
If yes, which commands do you type?

after further playing with this modified ilo, I see that I need to look at each individual sensor with ex. 'fan info a'  and 'fan info g' and find which sensor(s) are causing the fans to spin up high, and modify the hi/lo values for each sensor

So you can't use fan p X min Y and fan p X max Y to set the speeds?

Yesterday I've installed myself the 2.77 fan hack update, and I haven't encountered any issues so I think I can close this for now.


Regularise the config for plugins

At the moment the Config type is
data Config =
  Config
    { hlintOn             :: Bool
    , maxNumberOfProblems :: Int
    } deriving (Show)

As we add more diagnostic providers, we can add a specific config for each.
Or, we can make the config something like
data Config =
  Config
    { diagnostics :: Map PluginId  Bool
    , maxNumberOfProblems :: Int
    } deriving (Show)

This means that nothing has to change when we add a new plugin that does diagnostics, and we can filter out the disabled ones in requestDiagnostics already.
This can potentially apply for code actions, hover, and symbols. And be extended as new items arise.

I would like to also see an extensible point for custom plugin configs, so we can specify
"hlint": {
  "diagnostics": true,
  "maxNumber": 10
}

as a data type in Hlint.hs
data HlintConfig =
  HlintConfig
  { diagnostics :: Bool
  , maxNumber   :: Int
  }

This would help complete #772


How to change CocInlayHint colors?

Please excuse my naive question. I couldn't for the life of me figure out the right syntax to change the CocInlayHint colors. Here's what I have now, which has no effect:
return {
	{
		"projekt0n/github-nvim-theme",
		lazy = false, -- make sure we load this during startup if it is your main colorscheme
		priority = 1000, -- make sure to load this before all the other start plugins
		config = function()
			require("github-theme").setup({
				groups = {
					all = {
						CocInlayHint = { fg = '#ff0000', bg = '#0000ff' },
					}
				}
			})

			vim.cmd("colorscheme github_light_high_contrast")
		end,
	},
}

Hi. This was probably due to a bug, but it should be working correctly now:

Please update your plugin to the latest release/tag (or HEAD, whichever you are using) and restart nvim. Feel free to re-open this issue, or open a new issue, if you are still having problems after that. You may also leave additional comments here.

It works, thanks!


ImportError: /lib64/libstdc++.so.6

I encountered the following error while running the LJspeech TTS:
ImportError: /lib64/libstdc++.so.6: version `CXXABI_1.3.8' not found (required by /home/a.mohanta/20May2024/jabed/espnet/tools/python_user_base/lib/python3.9/site-packages/pyworld/pyworld.cpython-39-x86_64-linux-gnu.so)
I have used the GCC package 'gcc/13.1.0', but still getting this error. The error file is attached herewith for further reference.
error_file.txt
PLEASE HELP ME IN THIS REGARD. Thank you.

Make sure you update LD_LIBRARY_PATH.


An official docker image helps a lot!

As I searched out the docker hub, and found no results.  I think an official docker image is needed, so that we can code just with  VScode!

good suggestion
Can you help work on a pr? @qzylalala


execution halted

Hi there,
I have been using this program extensively. I get the following error repeatedly, is there any fix for it?
Error: Something went wrong while executing your query. This may be the result of a timeout, or it could be a GitHub bug. Please include `B532:514E:9D31833:9F4D8A8:652D0C6F` when reporting this issue.: {"response":{"data":null,"errors":[{"message":"Something went wrong while executing your query. This may be the result of a timeout, or it could be a GitHub bug. Please include `B532:514E:9D31833:9F4D8A8:652D0C6F` when reporting this issue."}],"status":502},"request":{"query":"query ($searchQuery: String!, $first: Int, $after: String) {\n  search(query: $searchQuery, type: REPOSITORY, first: $first, after: $after) {\n    nodes {\n      ... on Repository {\n        nameWithOwner\n        description\n        url\n        createdAt\n        assignableUsers {\n          totalCount\n        }\n        watchers {\n          totalCount\n        }\n        stargazerCount\n        projects {\n          totalCount\n        }\n        issues {\n          totalCount\n        }\n        pullRequests {\n          totalCount\n        }\n        diskUsage\n        licenseInfo {\n          spdxId\n        }\n        languages(first: 5) {\n          edges {\n            node {\n              name\n            }\n          }\n        }\n        primaryLanguage {\n          name\n        }\n        environments(first: 5) {\n          edges {\n            node {\n              name\n            }\n          }\n        }\n        submodules(first: 5) {\n          edges {\n            node {\n              name\n            }\n          }\n        }\n        repositoryTopics(first: 5) {\n          edges {\n            node {\n              topic {\n                name\n              }\n            }\n          }\n        }\n      }\n    }\n    pageInfo {\n      endCursor\n      hasNextPage\n    }\n  }\n}","variables":{"searchQuery":"query-string created:2021-01-06","first":50,"after":null}}}
    at GraphQLClient.<anonymous> (/home/bdr/src/GitHubMines/node_modules/graphql-request/dist/src/index.js:116:35)
    at step (/home/bdr/src/GitHubMines/node_modules/graphql-request/dist/src/index.js:40:23)
    at Object.next (/home/bdr/src/GitHubMines/node_modules/graphql-request/dist/src/index.js:21:53)
    at fulfilled (/home/bdr/src/GitHubMines/node_modules/graphql-request/dist/src/index.js:12:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  response: { data: null, errors: [ [Object] ], status: 502 },
  request: {
    query: 'query ($searchQuery: String!, $first: Int, $after: String) {\n' +
      '  search(query: $searchQuery, type: REPOSITORY, first: $first, after: $after) {\n' +
      '    nodes {\n' +
      '      ... on Repository {\n' +
      '        nameWithOwner\n' +
      '        description\n' +
      '        url\n' +
      '        createdAt\n' +
      '        assignableUsers {\n' +
      '          totalCount\n' +
      '        }\n' +
      '        watchers {\n' +
      '          totalCount\n' +
      '        }\n' +
      '        stargazerCount\n' +
      '        projects {\n' +
      '          totalCount\n' +
      '        }\n' +
      '        issues {\n' +
      '          totalCount\n' +
      '        }\n' +
      '        pullRequests {\n' +
      '          totalCount\n' +
      '        }\n' +
      '        diskUsage\n' +
      '        licenseInfo {\n' +
      '          spdxId\n' +
      '        }\n' +
      '        languages(first: 5) {\n' +
      '          edges {\n' +
      '            node {\n' +
      '              name\n' +
      '            }\n' +
      '          }\n' +
      '        }\n' +
      '        primaryLanguage {\n' +
      '          name\n' +
      '        }\n' +
      '        environments(first: 5) {\n' +
      '          edges {\n' +
      '            node {\n' +
      '              name\n' +
      '            }\n' +
      '          }\n' +
      '        }\n' +
      '        submodules(first: 5) {\n' +
      '          edges {\n' +
      '            node {\n' +
      '              name\n' +
      '            }\n' +
      '          }\n' +
      '        }\n' +
      '        repositoryTopics(first: 5) {\n' +
      '          edges {\n' +
      '            node {\n' +
      '              topic {\n' +
      '                name\n' +
      '              }\n' +
      '            }\n' +
      '          }\n' +
      '        }\n' +
      '      }\n' +
      '    }\n' +
      '    pageInfo {\n' +
      '      endCursor\n' +
      '      hasNextPage\n' +
      '    }\n' +
      '  }\n' +
      '}',
    variables: {
      searchQuery: 'query-string created:2021-01-06',
      first: 50,
      after: null
    }
  }
}
TypeError: result is not iterable (cannot read property undefined)
    at fetchAllResults (/home/bdr/src/GitHubMines/index.js:92:17)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
TypeError: Cannot read properties of undefined (reading 'map')
    at writeFiles (/home/bdr/src/GitHubMines/index.js:104:33)
    at /home/bdr/src/GitHubMines/index.js:290:5
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Hi Bachar
I will look into it today.

@badar-chachar
I think the fastest way to solve this is to set the batch size lower than 50 (try 10). This seems to be a GitHub problem. In my tests, it always works with 10 but sometimes fails with 50. It is likely because of the volume of information; some of the results are bigger and need too much time. It happens even in the GraphQL API Explorer from the GitHub site, depending on the results.
Look in the code for
const batchSize = 50; // Set the desired batch size. Maximum is 100
and set it to 10.
Let us know if it solved your issue. I will look into ways to keep a big batch size without running into this t
(There are also some possible improvements in the way we get the results. I will test and commit a more efficient version of the tool later today.)

@badar-chachar
You can find a newer version of this project here:
https://github.com/ksegla/GitHubMiner
It allows for batchsize as a parameter and is more efficient (in terms of the date range splitting that we use for queries with more than 1000 results.)

@badar-chachar I think the fastest way to solve this is to set the batch size lower than 50 (try 10). This seems to be a GitHub problem. In my tests, it always works with 10 but sometimes fails with 50. It is likely due to the volume of information; some of the results are bigger and need too much time. It happens even in the GraphQL API Explorer from the GitHub site, depending on the results.
Look in the code for const batchSize = 50; // Set the desired batch size. Maximum is 100 and set it to 10. Let us know if it solved your issue. I will look into ways to keep a big batch size without running into this t
(There are also some possible improvements in the way we get the results. I will test and commit a more efficient version of the tool later today.)

@ksegla I tried batchSize = 10 and it works fine. I tried it for a query returning 60k results in one go. Before I had to split for year range manually.

@badar-chachar You can find a newer version of this project here: https://github.com/ksegla/GitHubMiner It allows for batchsize as a parameter and is more efficient (in terms of the date range splitting that we use for queries with more than 1000 results.)

Hello, i used this and it doesn't terminate no metter how long the result size is.

@badar-chachar
Thanks for the feedback. Could you provide me with an example of a query that doesn't terminate. It terminates in all my tests.
(
For context, the newer version tries to be more efficient by scanning ranges of dates, instead of going one day at a time. To give you an extreme example, suppose you have a query for projects created between 2013-01-01 and 2023-01-01 and that the count of projects is 1001. The current version, in order to avoid the 1000 GitHub limit, would try every single day between those dates (around 3650 queries), which is longer and also consumes more of your rate limit. The newer version proceeds by iteratively splitting the date ranges in 2 and checking if there are more than 1000 results in the newer date ranges. So in an extreme scenario, to ensure you have less than 1000 results, you could need 3650+ queries for the first version but only 2 in the second version.
)

@ksegla I got 66K results for ethereum and 14K for cosmos. I just passed these strings as query without other parameters of date range or batchsize and program didn't crash.

@badar-chachar
Ah, I didn't understand at first. I thought you meant that GitHubMiner, the new version, was looping indefinitely (which was plausible since the new version uses trickier stop conditions) but it seems like you meant that the new version is working fine. Please note that batchsize is at 10 by default in GitHubMiner, so that's probably why you didn't have to set it. There<s still an issue with a batch size of 50.
Also, I just did a commit that fixed an issue about the default values. If you didn't set a start date, be aware that the tool was previously picking 2013-01-01 as a default date.  I changed it to 2008-01-01, just before GitHub got released.
For new issues, please use
https://github.com/ksegla/GitHubMiner
Thanks

@ksegla Thanks again, I just wanted to give feedback for the new version. I will put new issue on https://github.com/ksegla/GitHubMiner definitely. I will keep in mind the default date modification.


Remove version: CrystalDewWorld.CrystalDiskInfo.KureiKeiEdition version 8.15.2

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://osdn.net/frs/redir.php?m=ipconnect&f=crystaldiskinfo%2F76716%2FCrystalDiskInfo8_15_2KureiKei.exe
Response Error: The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel.
(Automated message - build 923)


authentication ui

this might sound like a stupid question but is it possible to use amplify for its prebuilt signup, signin, forgot password forms etc BUT hook them up to my own backend user management services rather than cognito sdk.
I have had to move away from cognito and create my own custom jwt tokens for security..

Hi @walshe
We are currently looking into supporting this use case soon, stay tuned.


Blazor - NavLink should also be able to navigate outside of app (i.e full page reload)

Is your feature request related to a problem? Please describe.
I am trying to use NavLink in a blazor app, to navigate to a URL outside of the SPA. In my case I want to redirect the user to the same spa but served up on a different subdomain. This should therefore bypass routing and do a full page reload (i.e request to the server).
However it seems when using NavLink (and I assume a plain <a> tag) the router intercepts the navigation and doesn't allow the request through to the server.
Ofcourse I can choose not to use NavLink or an anchor tag, and instead handle my Navigation click and use NavigationManager to do the redirect - but this is a lot more effort for rendering a simple link that it should be.
I thought that perhaps adding target="_blank" to the NavLink in order to open the url in a new tab would be enough to force a reload / request to the server - but that doesn't work, the router still intercepts the navigation.
<NavLink href="foo.localhost:5001" target="_blank"></NavLink> // opens in new tab but displays content resolved by router (i.e no match found)

Describe the solution you'd like
Perhaps allow an additional attribute to be specified that will indicate that the router should allow the request through to the server?
<NavLink href="foo.localhost:5001" target="_blank" skip-router="true"></NavLink></td>

Thanks for contacting us @dazinator.
You can use a plain a tag an set the target attribute to _self and that should prevent the link from being intercepted. I believe it should also work with NavLink
Let us know if that doesn't work.

@javiercn but I actually want to open the link in a new tab - therefore target = _blank is mandatory for that. There is no other way I can see of opening a link in a new tab with blazor - even navigation manager only does a redirect in the current tab?

@dazinator I'm not sure I understand. Adding "target=_blank" to your link/navlink should be the right thing to do. Are you saying that adding 'target=_blank' doesn't work?

@javiercn
Thank you and apologies. Yes it does indeed work - I thought you meant you had to use "target=_self" in order to bypass routing but "target=_blank" works equally as well and is the bahaviour I need. I had actually attempted this before opening this issue but the reason it wasn't working was a mistake in my href - the I was using href="foo.bar:5000" which was missing the scheme. Once I added the scheme to the href everything now works. Thanks for clarifying the bahaviour!

I would like to add my voice to this. It would be good to have a switch in NavLink that allows me to force an external link rather than an internal relative one. Would be nice if I could set the target too if I wanted.
My specific use case is to allow NavLinks to make use of external credentials managers such as Azure B2C, where the link must be external, even though it is to the same site.

Hi @simonziegler .
It looks like you are posting on a closed issue!
We're very likely to lose track of your bug/feedback/question unless you:

Open a new issue
Explain very clearly what you need help with
If you think you have found a bug, include detailed repro steps so that we can investigate the problem


Custodian rule wont execute.

Hi All,
I just started using custodian and was looking at
http://www.capitalone.io/cloud-custodian/docs/policy/lambda.html#cloudwatch-events

I created IAM role using this link
https://aws.amazon.com/premiumsupport/knowledge-center/start-stop-lambda-cloudwatch/

I created my rule as below and saved it as policy.yml

policies:
  - name: my-first-policy
    mode:
        type: config-rule
        role: arn:aws:iam::123456789012:role/lambda_start_stop_ec2
    resource: ec2
    filters:
      - "tag:custodiantest": present
    actions:
      - stop

Ran command from my machine
custodian run -s . policy.yml --region ap-southeast-2
I created an EC2 machine with tag "custodiantest".

Saw Logs in machine as below
ubuntu@ip-1xx-xx-x-xxx:~/custodiantest$ custodian run -s . policy.yml --region ap-southeast-2
2017-11-14 04:54:31,691: custodian.policy:INFO Provisioning policy lambda my-first-policy
2017-11-14 04:54:31,756: custodian.lambda:INFO Publishing custodian policy lambda function custodian-my-first-policy
Cloud watch error logs shown in below image.

Can you please let me know what is going wrong.
Is this an existing bug?
Thanks in advance
Vishnu

Most likely you are using python3 to run the custodian cli. Make sure you use '--python=python2' with virtualdev.

@whit537 this was one of the confusions we wanted to avoid with py3 afaicr

Thanks @fforloff . I had both python2 and python3 in my machine and even though I started virtualenv  using command "virtualenv --python=python2 custodian", I was getting the error.
So I uninstalled  python2.7 and 3,then installed python2.7 and tried. It worked.

@vishnuvpotti I am able to reproduce the SyntaxError from ipaddress.py in the cloudwatch logs by, as @fforloff said, running with Python 3 locally. That's a bug! Thanks for the report. :)

Since the py3 stdlib version of ipaddress.py is apparently not backwards-compatible to py2, I suppose our options are to:

remove the dependency on ipaddress
vendor in ipaddress
install the ipaddress backport even under Python 3

In any case we should have a test to catch this.

Note that pypi/ipaddress is not a straight repackaging of the py3 version, it's a port.

afaics in py3 we should be picking up the stdlib implementation, i added a pr recently to address one of the deltas between the two implementations, by ensuring our subclass of it has the supernet_of method. i think the issue is if we pickup the ipaddress.py module in py3 in preference to the stdlib module we run into issues, as its nots py3 compatibile.

i think the issue is if we pickup the ipaddress.py module in py3 in preference to the stdlib module we run into issues, as its nots py3 compatibile.

In my testing I'm seeing the opposite. The py3 stdlib version of ipaddress is not backwards-compatible to py2, because of the 3-only exception handling syntax on this line. If running py3 locally we end up pushing that 3-only version up to lambda w/ a py27 (default) remote runtime, hence the SyntaxError as reported.
The third-party ipaddress library advertises compatibility with both 2 and 3.

the issue w/ the third party (really first party ;-)  is that in py3 its quite possible we end up with the stdlib as first on the path before we get to the virtualenv site-packages.

@kapilt True ... so I guess let's try vendoring? https://github.com/capitalone/cloud-custodian/pull/1796

there's two issues here @whit537 .. unless a user explicitly specified py3.6 I'm not sure why we defaulted their lambda to it, they where trying with py2. second on the ipaddress module issue specifically, yeah vendor is probably the sanest option (sadness, I went with ipaddress over https://pypi.python.org/pypi/netaddr on the basis it was in the stdlib in 3).

they were trying with py2

They were trying for py2 remote, but with py3 local.

unless a user explicitly specified py3.6 I'm not sure why we defaulted their lambda to it

Don't worry, we didn't. :) We defaulted to py2-remote as expected, but since they are running py3 locally we uploaded the py3-stdlib-ipaddress, which is bad syntax for py2.

vendor is probably the sanest option

Cool, will clean up #1796 ...

(sadness, I went with ipaddress over https://pypi.python.org/pypi/netaddr on the basis it was in the stdlib in 3)

D'oh! Back pocket if vendoring doesn't work for some reason.

#1796 is ready for review.


feat(filters): support "true" as valid for frontmatter filters

See: (b3a02909ba74fff08cd3675707d1f4d782a24e98)

Thank you!  This has saved me a lot of work by allowing me to continue to use publish: "true" in my Obsidian files (until I get around to converting them all to booleans)


Ubuntu 14.04 install fails with error about prereleases

Following instructions on https://enigma.co/catalyst/#/getstarted/installation on Ubuntu 14.04.5 LTS.   Instruction #3
pip install enigma-catalyst
results in error
(catalyst-venv)jason@mouse:~/catalyst-venv/bin$ pip install  enigma-catalyst
Downloading/unpacking enigma-catalyst
Could not find a version that satisfies the requirement enigma-catalyst (from versions: 0.1.dev9, 0.2.dev2, 0.1.dev4, 0.1.dev5, 0.1.dev3, 0.2.dev1, 0.1.dev8, 0.1.dev6)
Cleaning up...
No distributions matching the version for enigma-catalyst
Storing debug log for failure in /tmp/tmpYSRuZa
Workaround is to run pip install with --pre switch.
(catalyst-venv)jason@mouse:~/catalyst-venv/bin$ pip install --pre enigma-catalyst
Downloading/unpacking enigma-catalyst
Downloading enigma-catalyst-0.2.dev2.tar.gz (687kB): 687kB downloaded
Running setup.py (path:/home/jason/catalyst-venv/build/enigma-catalyst/setup.py) egg_info for package enigma-catalyst
....
More errors results after this, will submit additional reports.

Thank you for reporting this. This has been documented in a revamped page on Troubleshooting at https://github.com/enigmampc/catalyst-docs/wiki/Troubleshooting-Installation


Debugged Properties panel close Animation Bug

Fixing Overflow Issue in EditPanel Component
Problem
While opening or closing the EditPanel tab, the content inside was overflowing beyond the boundaries of the panel. This caused the UI to break during animations.
Solution
We applied overflow-hidden to critical containers and added width/height constraints to prevent content from escaping during transitions. We also ensured smooth transitions with CSS adjustments.
Changes Made

Apply overflow-hidden to the Main Wrapper:

Ensures that the content stays within the panel boundaries during open/close transitions.

<div
    className={clsx(
        'fixed right-0 transition-width duration-300 opacity-100 bg-background/80 rounded-tl-xl overflow-hidden',
        editorEngine.mode === EditorMode.INTERACT ? 'hidden' : 'visible',
        !isOpen && 'w-12 h-12 rounded-l-xl cursor-pointer',
        isOpen && 'h-[calc(100vh-5rem)]',
        isOpen && selectedTab == TabValue.STYLES && 'w-60',
        isOpen && selectedTab == TabValue.CHAT && 'w-[22rem]',
    )}
>

@drfarrell @Kitenite here is the PR for that same, This has successfully debugged that issue and the text is now not coming out of the transition box. Please review it and let me know if any changes are required.

This was for #651 .

@Kitenite Please check now, Scroll is working now, and the tailwind class is also in size.

@Kitenite Any updates sir?

@Kitenite Any updates sir?

Sorry I was working on a different PR. Left some comments but thanks for the quick turnaround!

@Kitenite Any updates sir?

Sorry I was working on a different PR. Left some comments but thanks for the quick turnaround!

So I was not sure where the code was at first so was experimenting, So is it fine now ?

@Kitenite Did it for the layers too.

@Kitenite Can you please add the hacktoberfest-accepted label also, for it to get counted.

Ofc!


Update to 1.4.21, force to compile x64

Related MR: https://git.easy.cz/devel/devel/-/merge_requests/160857

A bit problems with dependencies when compiling on easy server. I will try to exclude unnecessary dependencies from xapian-bindings when we use maintainer mode

Can we test build/compilation by CI somehow? So for example try to compile gem in several docker containers?


Manual Assessment: Add internal assessment notes for tutors

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I documented the Java code using JavaDoc style.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[x] I followed the coding and design guidelines.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

[x] I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
[x] I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

Closes #1402.
Description

A new object AssessmentNote is added to results. This object has a OneToOne mapping with the creator, a createdDate and string to represent the note itself. The result has a OneToMany relationship with the AssessmentNote, which is in fact an artificial OneToOne relationship, but the other annotation is needed to make lazy fetching work. The assessment notes have no reference to their owning result.
Steps for Testing

Prerequisites:

2 Instructors
1 Student

Log in to Artemis
Navigate to Course Administration
Create a new programming exercise with

due date in the far future
manual assessment
online code editor enabled

Make a submission as a student
Change the due date to something like 3 minutes in the future
After the due date has passed, go to the assessment dashboard of the course
Start assessment for the exercise
Enter some text in the text box at the very bottom of the page
You should now be able to save, but not submit the assessment
Leave and re-enter the assessment view, the text should still be there after saving
View the assessment as another instructor, the text should also be visible

Review Progress

Performance Review

[x] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[x] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[x] Code Review 1
[ ] Code Review 2

Manual Tests

[x] Test 1
[x] Test 2

Test Coverage

Screenshots

@Strohgelaender Thanks for the review. Sorry it took me so long to get back. Great suggestion, will implement it this afternoon 👍

Thanks for testing! Interesting, I'll look into that.

@JanaNF The testing step could maybe have been worded better: To check the assessment, you have to go to the ‘Course Management‘ → ‘Exercise’ → ‘Scores’ button on the exercise details page, not via the assessment dashboard.
@chrisknedl Please check if that are indeed the intended steps, and update the PR description if necessary.

Manual test on ts1, lgtm

Tested in a testing session with @MaximilianJG on Test-3.
We have performed all mentioned tasks exactly as described in your testing checklists.
The note feature works as expected when only one instructor is involved, however the assessment is locked and cannot be unlocked. Even after submitting, other instructors cannot view the assessment. This means that if any other instructor can't view the assessment, the text area for the internal notes can't be viewed either.
Asides from that, it would probably theoretically work.

Tested in a testing session with @Ceiridge. Adding tutor notes to the exercise works.

However after saving these notes the exercise assessment is locked for some reason and it is not easily understandable how to unlock it. Consequently we were unable to view the tutor notes from an alternate instructor account. (We also could not see the exercise from the second instructor account, as the exercise is locked)

@Ceiridge @MaximilianJG Thanks for testing. You are both correct, the 11th testing step is wrong. This problem actually surfaced a while ago (https://github.com/ls1intum/Artemis/pull/7093#issuecomment-1773710587) and I thought I had updated the description, but apparently not. Anyways, it should be up to date again now.

Only changes since the last round of reviews: fixed tests due to merge conflict (commit 53b410674f7857a5c0b7f38e7d90795432535759).

@maximiliansoelch Thanks for testing.
For 1), submitting worked for you because you added a feedback before entering an assessment note. In this case, being able to submit is indeed intended, as otherwise you wouldn't be able to submit feedback when you haven't added a note. The "only save without submitting" part is there so that you can't send an otherwise empty result to the student who can't see the assessment note.
2) seems to be in fact an issue that I have to look into. Thanks for noticing.

This PR is open for a too long time. Please reopen it, when someone can work on this feature with a higher focus.

@R3dError Thanks a lot for the very thorough review, I really appreciate it. For the first point about storing the actual creator, I think it is enough to only store who last edited the note, because we also don't have a history on previous notes anyway. That way, the stored creator is really always the one who wrote the currently stored note.


feat: settings notifications

This PR implements screens for settings notifications, adds tabs for 'push' and 'email' notifications, and uses an input to store a preferred email address to receive notifications.
I used zod to validate the email address. I'll need design feedback on what to show for an invalid email address, rn I'm showing a toast but we only have a success and info types currently. I think I need to add a fail type?

Updated the toast types here cc @fabric-8, also the copy on the success was to wordy so I simplified to fit on screen better...


KAFKA-5611; AbstractCoordinator should handle wakeup raised from onJoinComplete

@ijuma Thanks for taking a look. I added a few comments in ConsumerRebalanceListener on the propagation of wakeups/interrupts. Let me know if they seem reasonable.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6365/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6350/
Test PASSed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6375/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6360/
Test PASSed (JDK 8 and Scala 2.12).

I will merge to trunk and 0.11.0 but leave the issue open to give the user a chance to confirm the fix.

after applied https://github.com/apache/kafka/pull/3571 on version <IP_ADDRESS>, we encountered an infinite loop occurs in ConsumerCoordinator.java:
java.lang.IllegalStateException: Coordinator selected invalid assignment protocol: null
at org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.onJoinComplete(ConsumerCoordinator.java:208)
at org.apache.kafka.clients.consumer.internals.AbstractCoordinator.joinGroupIfNeeded(AbstractCoordinator.java:339)
at org.apache.kafka.clients.consumer.internals.AbstractCoordinator.ensureActiveGroup(AbstractCoordinator.java:305)
at org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.poll(ConsumerCoordinator.java:286)
for some reason, the ConsumerCoordinator's resetGeneration() is called, and the protocol of generation is set to null.
then in method joinGroupIfNeeded() of org.apache.kafka.clients.consumer.internals.AbstractCoordinator.java ,onJoinComplete() method throws an IllegalStateException,
and the resetJoinGroupFuture() method will never has the chance to be call:

        if (future.succeeded()) {
            onJoinComplete(generation.generationId, generation.memberId, generation.protocol, future.value());

            // We reset the join group future only after the completion callback returns. This ensures
            // that if the callback is woken up, we will retry it on the next joinGroupIfNeeded.
            resetJoinGroupFuture();
            needsJoinPrepare = true;

the joinFuture is not clear to null, JoinGroupRequest will not be sent in the next loop
is this an issue?


[WIP] [SPARK-19538] Explicitly tell the DAGScheduler when a TaskSet is complete

**** This is not intended to be merged! (see note at bottom) Posting to facilitate discussion around #16620. ****
The pendingPartitions in Stage tracks partitions that still need to be computed, and is used by the DAGScheduler to determine when to mark the stage as complete. In most cases, this variable is exactly consistent with the tasks in the TaskSetManager (for the current version of the stage) that are still pending. However, as discussed in SPARK-19263, these can become inconsistent when an ShuffleMapTask for an earlier attempt of the stage completes, in which case the DAGScheduler may think the stage has finished, while the TaskSetManager is still waiting for some tasks to complete (see the description in this pull request: https://github.com/apache/spark/pull/16620). This leads to bugs like SPARK-19263. Another problem with this behavior is that listeners can get two StageCompleted messages: once when the DAGScheduler thinks the stage is complete, and a second when the TaskSetManager later decides the stage is complete. We should fix this.
Unfortunately, merging this would lead to a performance regression, as discussed in #16620.  Currently, the DAGScheduler may mark a Stage as completed "early", before the TSM thinks it's done, based on task completions from earlier attempts of the stage, and with this commit, that can't happen.

Test build #72663 has started for PR 16877 at commit b575e93.

Test build #72663 has finished for PR 16877 at commit b575e93.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Since #16620 has been merged, should we close this？


[Enhancement] Support full statistics collect with partition

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

[FE PR Coverage check]
:disappointed: fail : 158 / 584 (27.05%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/statistic/AnalyzeMeta.java
0
28
00.00%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeMetaStmt.java
0
26
00.00%

:large_blue_circle:
com/starrocks/http/rest/QueryDumpAction.java
0
1
00.00%

:large_blue_circle:
com/starrocks/service/FrontendServiceImpl.java
0
5
00.00%

:large_blue_circle:
com/starrocks/load/loadv2/SparkLoadJob.java
0
3
00.00%

:large_blue_circle:
com/starrocks/sql/ast/CreateAnalyzeJobStmt.java
0
1
00.00%

:large_blue_circle:
com/starrocks/sql/common/MetaUtils.java
0
4
00.00%

:large_blue_circle:
com/starrocks/statistic/StatisticUtils.java
0
3
00.00%

:large_blue_circle:
com/starrocks/load/loadv2/BrokerLoadJob.java
0
3
00.00%

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
0
9
00.00%

:large_blue_circle:
com/starrocks/journal/JournalEntity.java
0
6
00.00%

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
3
28
10.71%

:large_blue_circle:
com/starrocks/statistic/StatisticAutoCollector.java
13
64
20.31%

:large_blue_circle:
com/starrocks/persist/EditLog.java
2
10
20.00%

:large_blue_circle:
com/starrocks/statistic/StatisticsMetaManager.java
12
57
21.05%

:large_blue_circle:
com/starrocks/statistic/AnalyzeManager.java
6
28
21.43%

:large_blue_circle:
com/starrocks/statistic/StatisticSQLBuilder.java
18
70
25.71%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeJobStmt.java
14
47
29.79%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeStatusStmt.java
15
44
34.09%

:large_blue_circle:
com/starrocks/statistic/StatisticExecutor.java
29
78
37.18%

:large_blue_circle:
com/starrocks/statistic/AnalyzeStatus.java
13
32
40.62%

:large_blue_circle:
com/starrocks/statistic/TableCollectJob.java
11
14
78.57%

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
6
7
85.71%

:large_blue_circle:
com/starrocks/common/Config.java
3
3
100.00%

:large_blue_circle:
com/starrocks/statistic/Constants.java
2
2
100.00%

:large_blue_circle:
com/starrocks/statistic/AnalyzeJob.java
10
10
100.00%

:large_blue_circle:
com/starrocks/sql/parser/SqlParser.java
1
1
100.00%

[FE PR Coverage check]
:disappointed: fail : 158 / 585 (27.01%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/statistic/AnalyzeMeta.java
0
28
00.00%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeMetaStmt.java
0
26
00.00%

:large_blue_circle:
com/starrocks/http/rest/QueryDumpAction.java
0
1
00.00%

:large_blue_circle:
com/starrocks/service/FrontendServiceImpl.java
0
5
00.00%

:large_blue_circle:
com/starrocks/load/loadv2/SparkLoadJob.java
0
3
00.00%

:large_blue_circle:
com/starrocks/sql/ast/CreateAnalyzeJobStmt.java
0
1
00.00%

:large_blue_circle:
com/starrocks/sql/common/MetaUtils.java
0
4
00.00%

:large_blue_circle:
com/starrocks/statistic/StatisticUtils.java
0
3
00.00%

:large_blue_circle:
com/starrocks/load/loadv2/BrokerLoadJob.java
0
3
00.00%

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
0
10
00.00%

:large_blue_circle:
com/starrocks/journal/JournalEntity.java
0
6
00.00%

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
3
28
10.71%

:large_blue_circle:
com/starrocks/statistic/StatisticAutoCollector.java
13
64
20.31%

:large_blue_circle:
com/starrocks/persist/EditLog.java
2
10
20.00%

:large_blue_circle:
com/starrocks/statistic/StatisticsMetaManager.java
12
57
21.05%

:large_blue_circle:
com/starrocks/statistic/AnalyzeManager.java
6
28
21.43%

:large_blue_circle:
com/starrocks/statistic/StatisticSQLBuilder.java
18
70
25.71%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeJobStmt.java
14
47
29.79%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeStatusStmt.java
15
44
34.09%

:large_blue_circle:
com/starrocks/statistic/StatisticExecutor.java
29
78
37.18%

:large_blue_circle:
com/starrocks/statistic/AnalyzeStatus.java
13
32
40.62%

:large_blue_circle:
com/starrocks/statistic/TableCollectJob.java
11
14
78.57%

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
6
7
85.71%

:large_blue_circle:
com/starrocks/common/Config.java
3
3
100.00%

:large_blue_circle:
com/starrocks/statistic/Constants.java
2
2
100.00%

:large_blue_circle:
com/starrocks/statistic/AnalyzeJob.java
10
10
100.00%

:large_blue_circle:
com/starrocks/sql/parser/SqlParser.java
1
1
100.00%

[FE PR Coverage check]
:disappointed: fail : 158 / 581 (27.19%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/statistic/AnalyzeMeta.java
0
28
00.00%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeMetaStmt.java
0
26
00.00%

:large_blue_circle:
com/starrocks/http/rest/QueryDumpAction.java
0
1
00.00%

:large_blue_circle:
com/starrocks/service/FrontendServiceImpl.java
0
5
00.00%

:large_blue_circle:
com/starrocks/load/loadv2/SparkLoadJob.java
0
3
00.00%

:large_blue_circle:
com/starrocks/sql/ast/CreateAnalyzeJobStmt.java
0
1
00.00%

:large_blue_circle:
com/starrocks/sql/common/MetaUtils.java
0
4
00.00%

:large_blue_circle:
com/starrocks/statistic/StatisticUtils.java
0
3
00.00%

:large_blue_circle:
com/starrocks/load/loadv2/BrokerLoadJob.java
0
3
00.00%

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
0
10
00.00%

:large_blue_circle:
com/starrocks/journal/JournalEntity.java
0
6
00.00%

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
3
28
10.71%

:large_blue_circle:
com/starrocks/statistic/StatisticAutoCollector.java
13
64
20.31%

:large_blue_circle:
com/starrocks/persist/EditLog.java
2
10
20.00%

:large_blue_circle:
com/starrocks/statistic/StatisticsMetaManager.java
12
57
21.05%

:large_blue_circle:
com/starrocks/statistic/AnalyzeManager.java
6
28
21.43%

:large_blue_circle:
com/starrocks/statistic/StatisticSQLBuilder.java
18
66
27.27%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeJobStmt.java
14
47
29.79%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeStatusStmt.java
15
44
34.09%

:large_blue_circle:
com/starrocks/statistic/StatisticExecutor.java
29
78
37.18%

:large_blue_circle:
com/starrocks/statistic/AnalyzeStatus.java
13
32
40.62%

:large_blue_circle:
com/starrocks/statistic/TableCollectJob.java
11
14
78.57%

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
6
7
85.71%

:large_blue_circle:
com/starrocks/common/Config.java
3
3
100.00%

:large_blue_circle:
com/starrocks/statistic/Constants.java
2
2
100.00%

:large_blue_circle:
com/starrocks/statistic/AnalyzeJob.java
10
10
100.00%

:large_blue_circle:
com/starrocks/sql/parser/SqlParser.java
1
1
100.00%

[FE PR Coverage check]
:disappointed: fail : 294 / 581 (50.60%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/http/rest/QueryDumpAction.java
0
1
00.00%

:large_blue_circle:
com/starrocks/service/FrontendServiceImpl.java
0
5
00.00%

:large_blue_circle:
com/starrocks/load/loadv2/SparkLoadJob.java
0
3
00.00%

:large_blue_circle:
com/starrocks/sql/ast/CreateAnalyzeJobStmt.java
0
1
00.00%

:large_blue_circle:
com/starrocks/sql/common/MetaUtils.java
0
4
00.00%

:large_blue_circle:
com/starrocks/statistic/StatisticUtils.java
0
3
00.00%

:large_blue_circle:
com/starrocks/load/loadv2/BrokerLoadJob.java
0
3
00.00%

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
0
10
00.00%

:large_blue_circle:
com/starrocks/journal/JournalEntity.java
0
6
00.00%

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
3
28
10.71%

:large_blue_circle:
com/starrocks/statistic/StatisticAutoCollector.java
13
64
20.31%

:large_blue_circle:
com/starrocks/persist/EditLog.java
2
10
20.00%

:large_blue_circle:
com/starrocks/statistic/StatisticsMetaManager.java
12
57
21.05%

:large_blue_circle:
com/starrocks/statistic/AnalyzeManager.java
6
28
21.43%

:large_blue_circle:
com/starrocks/statistic/StatisticExecutor.java
29
78
37.18%

:large_blue_circle:
com/starrocks/statistic/AnalyzeMeta.java
16
28
57.14%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeJobStmt.java
36
47
76.60%

:large_blue_circle:
com/starrocks/statistic/TableCollectJob.java
11
14
78.57%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeMetaStmt.java
22
26
84.62%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeStatusStmt.java
37
44
84.09%

:large_blue_circle:
com/starrocks/statistic/AnalyzeStatus.java
27
32
84.38%

:large_blue_circle:
com/starrocks/statistic/StatisticSQLBuilder.java
57
66
86.36%

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
7
7
100.00%

:large_blue_circle:
com/starrocks/common/Config.java
3
3
100.00%

:large_blue_circle:
com/starrocks/statistic/Constants.java
2
2
100.00%

:large_blue_circle:
com/starrocks/statistic/AnalyzeJob.java
10
10
100.00%

:large_blue_circle:
com/starrocks/sql/parser/SqlParser.java
1
1
100.00%

Add some descripe plz

[FE PR Coverage check]
:disappointed: fail : 293 / 581 (50.43%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/http/rest/QueryDumpAction.java
0
1
00.00%

:large_blue_circle:
com/starrocks/service/FrontendServiceImpl.java
0
5
00.00%

:large_blue_circle:
com/starrocks/load/loadv2/SparkLoadJob.java
0
3
00.00%

:large_blue_circle:
com/starrocks/sql/ast/CreateAnalyzeJobStmt.java
0
1
00.00%

:large_blue_circle:
com/starrocks/sql/common/MetaUtils.java
0
4
00.00%

:large_blue_circle:
com/starrocks/statistic/StatisticUtils.java
0
2
00.00%

:large_blue_circle:
com/starrocks/load/loadv2/BrokerLoadJob.java
0
3
00.00%

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
0
10
00.00%

:large_blue_circle:
com/starrocks/journal/JournalEntity.java
0
6
00.00%

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
3
28
10.71%

:large_blue_circle:
com/starrocks/statistic/StatisticsMetaManager.java
11
56
19.64%

:large_blue_circle:
com/starrocks/statistic/StatisticAutoCollector.java
13
64
20.31%

:large_blue_circle:
com/starrocks/persist/EditLog.java
2
10
20.00%

:large_blue_circle:
com/starrocks/statistic/AnalyzeManager.java
6
28
21.43%

:large_blue_circle:
com/starrocks/statistic/StatisticExecutor.java
29
80
36.25%

:large_blue_circle:
com/starrocks/statistic/AnalyzeMeta.java
16
28
57.14%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeJobStmt.java
36
47
76.60%

:large_blue_circle:
com/starrocks/statistic/TableCollectJob.java
11
14
78.57%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeMetaStmt.java
22
26
84.62%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeStatusStmt.java
37
44
84.09%

:large_blue_circle:
com/starrocks/statistic/AnalyzeStatus.java
27
32
84.38%

:large_blue_circle:
com/starrocks/statistic/StatisticSQLBuilder.java
57
66
86.36%

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
7
7
100.00%

:large_blue_circle:
com/starrocks/common/Config.java
3
3
100.00%

:large_blue_circle:
com/starrocks/statistic/Constants.java
2
2
100.00%

:large_blue_circle:
com/starrocks/statistic/AnalyzeJob.java
10
10
100.00%

:large_blue_circle:
com/starrocks/sql/parser/SqlParser.java
1
1
100.00%

[FE PR Coverage check]
:disappointed: fail : 293 / 586 (50.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/http/rest/QueryDumpAction.java
0
1
00.00%

:large_blue_circle:
com/starrocks/service/FrontendServiceImpl.java
0
5
00.00%

:large_blue_circle:
com/starrocks/load/loadv2/SparkLoadJob.java
0
3
00.00%

:large_blue_circle:
com/starrocks/sql/ast/CreateAnalyzeJobStmt.java
0
1
00.00%

:large_blue_circle:
com/starrocks/sql/common/MetaUtils.java
0
4
00.00%

:large_blue_circle:
com/starrocks/statistic/StatisticUtils.java
0
2
00.00%

:large_blue_circle:
com/starrocks/load/loadv2/BrokerLoadJob.java
0
3
00.00%

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
0
10
00.00%

:large_blue_circle:
com/starrocks/journal/JournalEntity.java
0
6
00.00%

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
3
28
10.71%

:large_blue_circle:
com/starrocks/statistic/AnalyzeManager.java
6
33
18.18%

:large_blue_circle:
com/starrocks/statistic/StatisticsMetaManager.java
11
56
19.64%

:large_blue_circle:
com/starrocks/statistic/StatisticAutoCollector.java
13
64
20.31%

:large_blue_circle:
com/starrocks/persist/EditLog.java
2
10
20.00%

:large_blue_circle:
com/starrocks/statistic/StatisticExecutor.java
29
80
36.25%

:large_blue_circle:
com/starrocks/statistic/AnalyzeMeta.java
16
28
57.14%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeJobStmt.java
36
47
76.60%

:large_blue_circle:
com/starrocks/statistic/TableCollectJob.java
11
14
78.57%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeMetaStmt.java
22
26
84.62%

:large_blue_circle:
com/starrocks/sql/ast/ShowAnalyzeStatusStmt.java
37
44
84.09%

:large_blue_circle:
com/starrocks/statistic/AnalyzeStatus.java
27
32
84.38%

:large_blue_circle:
com/starrocks/statistic/StatisticSQLBuilder.java
57
66
86.36%

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
7
7
100.00%

:large_blue_circle:
com/starrocks/common/Config.java
3
3
100.00%

:large_blue_circle:
com/starrocks/statistic/Constants.java
2
2
100.00%

:large_blue_circle:
com/starrocks/statistic/AnalyzeJob.java
10
10
100.00%

:large_blue_circle:
com/starrocks/sql/parser/SqlParser.java
1
1
100.00%


fix aeu_env:schema() when started without epoch.yaml

See PT #160984234

I also tested it locally.


Fix quickstart examples in README

We hadn't updated those when we moved to vectorized data structures.
cc @allensctong

https://github.com/AI4OPT/OPFGenerator/blob/59d57e4b1d30b8614a7d37ba09397e912028c39a/README.md?plain=1#L303-L304
Should be kcl_p and kcl_q

I started to try and fix it and then realized it would be a lot of work... so I removed it 😅
To be included in the documentation though


.nz mistakenly marked as "withdrawn"

https://github.com/zonedb/zonedb/commit/e64e4596c6432ffd240d7481aad5f849fdd19b74#diff-19d58ce5ae5a95af9c909ee578396a0f2add807d651cfc103ea2cb44066d91aa

Some notes from Slack:

This looks like a failure to get dns for the whole NZ zone
It shouldn’t withdraw cctlds
I think we could add a safety feature where if all the zones under a TLD lose dns we emit a warning but don’t do the change automatically. And not withdraw TLDs automatically

Fixed in #881.


Upgrade python versions < 3.11 to 3.11

There are issues happening on the Mac with intermittent failures trying to install Python versions < 3.11. Thankfully, most of Java is using the Python version from globals.yml. Update spark.databricks.yml to use the version in globals.yml
I'm running java - template - ci against my PR to test this change. This pipeline ran into the Mac failure so I know that running this will hit those paths.
Also, the java - cosmos - spark pipeline has failures that are currently being fixed. That being said, the failure happens after their use of python. I'm running the pipeline to ensure their pip install still works with the upgraded version and it does

I'm going to squash and merge before core is done. The only run still running is the From Source run which isn't testing anything that the other runs, that completed, haven't already tested.


Vue router Back button leads to the wrong savedPosition

Version
4.0.13
Reproduction link
https://www.test.timetip.app/
Steps to reproduce

Scroll down a bit on the page
Click any Picture or Button that leads you to another route
Click the back button

What is expected?
Router should lead back to the exact same position
What is actually happening?
Router leads back to a slightly different position

My router configuration:
const router = createRouter({
history: createWebHistory(process.env.BASE_URL),
routes,
scrollBehavior(to, from, savedPosition) {
if (savedPosition) { return savedPosition }
else {return { top: 0, behavior: 'instant' }}
}
})
If I remove the part "else {return { top: 0, behavior: 'instant' }}" then the back button behavior works fine. But I need the instant scroll behavior if I click on a next page.
What could be the issue here?

Your reproduction is not minimal, please read and follow https://new-issue.vuejs.org/?repo=vuejs/vue-next#why-repro when reporting a bug. Most bugs should be reproducible with the SFC Playground.


Sync w/ upstream

Relevant changes

OTLP: Use PrometheusConverter directly
otlp: Prometheus to own its own copy of the otlptranslator package

These changes include a very significant performant boost to the conversion from OTel to Prometheus remote write format, as can be seen from the PR description.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 6 committers have signed the CLA.:white_check_mark: jesusvazquez:white_check_mark: aknuds1:x: komisan19:x: tesla59:x: ArthurSens:x: testwillYou have signed the CLA already but the status is still pending? Let us recheck it.


Adding Russian language

Hello. How can I translate the program into other languages? Including the Russian language?

I think this isn't supported yet, but see #308

Duplicate of #308


Option to disable default TLS certificate

I've been trying for a few hours upgrading to Traefik 2 and one major hurdle I am having is the lack of some hard errors.
In my case I've been battling to serve three certificates for three different domains, but Traefik insists in using its own default certificate. I can manually set a default certificate, but then all domains start using the same one, ignoring their own.
I've seen plenty of official blog posts about how to set up TLS but my certs keep getting ignored with no warning or error.
An option to disable the default TLS and force the user to clearly specify a valid/wanted certificate would be great. It would be even better if I could make Traefik crash on invalid config.
UPDATE: After a while I noticed that my current pain point is that I have not seen a clear way to force/set a cert file from the route configuration. Something like "for this route use this certificate or fail" but right now despite seeing my certificates per domain loaded (DEBUG log level) the routes for those domains insist in generating a new one

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.


Add benchmarks and compile_fail tests back to workspace

Objective

Our benchmarks and compile_fail tests lag behind the rest of the engine because they are not in the Cargo workspace, so not checked by CI.
Fixes #16801, please see it for further context!

Solution

Add benchmarks and compile_fail tests to the Cargo workspace.
Fix any leftover formatting issues and documentation.

Testing

I think CI should catch most things!

Questions
The reflection_types example is failing in Rust-Analyzer for me, but not a normal check.
error[E0004]: non-exhaustive patterns: `ReflectRef::Function(_)` not covered
   --> examples/reflection/reflection_types.rs:81:11
    |
81  |     match value.reflect_ref() {
    |           ^^^^^^^^^^^^^^^^^^^ pattern `ReflectRef::Function(_)` not covered
    |
note: `ReflectRef<'_>` defined here
   --> /Users/bdeep/dev/bevy/bevy/crates/bevy_reflect/src/kind.rs:178:1
    |
178 | pub enum ReflectRef<'a> {
    | ^^^^^^^^^^^^^^^^^^^^^^^
...
188 |     Function(&'a dyn Function),
    |     -------- not covered
    = note: the matched value is of type `ReflectRef<'_>`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
    |
126 ~         ReflectRef::Opaque(_) => {},
127 +         ReflectRef::Function(_) => todo!()
    |

I think it is because the following line is feature-gated:
https://github.com/bevyengine/bevy/blob/cc0f6a8db43581755bd84302072c7b97ea51bc0f/examples/reflection/reflection_types.rs#L117-L122
My theory for why this is happening is because the benchmarks enabled bevy_reflect's function feature, which gets merged with the rest of the features when RA checks the workspace, but the #[cfg(...)] gate in the example isn't detecting it:
https://github.com/bevyengine/bevy/blob/cc0f6a8db43581755bd84302072c7b97ea51bc0f/benches/Cargo.toml#L19
Any thoughts on how to fix this? It's not blocking, since the example still compiles as normal, but it's just RA and the command cargo check --workspace --all-targets appears to fail. cc @MrGVSV

I take it the RA bug you mentioned is now fixed?

I take it the RA bug you mentioned is now fixed?

No, not yet unfortunately, and it's also surfaced in the CI failure. There are a few solutions, but I don't like any of them:

Conditionally-compile function reflection benchmarks, no longer enable the feature by default in benches/Cargo.toml.
Enable function reflection by default and assume it's available in the example.
Don't add benches to the Cargo workspace.
Change how we detect function reflection in the example. I have no idea how we'd do this, but it would be preferable.

I chose to feature-flag the function reflection benchmarks. While not amazing, it's more desirable then the other solutions I thought of. @MrGVSV next time you want to benchmark function reflection, you will need to run this:
cargo bench --bench reflect --feature reflect_functions


How to debug this project

Hi!
thanks for providing stuff like this. I have problems to runs your script with my IDE.
https://i.imgur.com/dPNSYsd.png
Whats wrong? How to enable a file based log?

Using fopen('log') instead STDERR to get some logs:
[.] Testing PHP configuration in IDE? Disable logging first!
[.] Bash path: C:\WINDOWS\System32\bash.exe
[.] CWD: C:\Program Files\Java\jdk1.8.0_121\jre\bin
[.] ENV:
[.] Input arguments: -dxdebug.remote_enable=0 C:\Users\jan\AppData\Local\Temp\ide-phpinfo.php
[.] Linux arguments: -dxdebug.remote_enable=0 /mnt/c/Users/jan/AppData/Local/Temp/ide-phpinfo.php
[.] Linux command: php -dxdebug.remote_enable=0 /mnt/c/Users/jan/AppData/Local/Temp/ide-phpinfo.php
[.] Windows command: C:\WINDOWS\System32\bash.exe -c "php -dxdebug.remote_enable=0 /mnt/c/Users/jan/AppData/Local/Temp/ide-phpinfo.php"

Running the windows command via shell looks great.

Have the same issue.
Running script with IDE always failed.
When I modified script to write all output (STDERR and STDOUT) to files, I've got the following result: http://c2n.me/3IrXI2t
Setting up PHPUnit shows this text every time: http://c2n.me/3IrY6Fj
What PHP configuration you've used? PHP version, architecture, thread safety etc.

Same Problem here.
cmd works, bash works, PhpStorm Terminal works, PhpStorm Console Tools does not work.

With the current Windows 10 Creators update, everything is working properly ^(^.^)^

Yeah, I will close it.


HBASE-28562 Correct backup ancestor calculation

The ancestor calculation was wrong for incremental backups: when requesting the ancestors for an incremental backup X, the ancestors could include both full and incremental backups that predate the full backup on which X is built.
This caused a crash in incremental backup creation when data of old incremental backups was deleted through other means than the HBase API (i.e. without the HBase backup system table being updated).

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

I'll update the PR once https://github.com/apache/hbase/pull/5871 gets merged. Not sure how to handle the rebasing of these changes? Should I do a force-push of this branch, or simply create a new PR instead?

A rebase and force push should be good

@rmdmattingly rebased the PR after addressing the getAncestors concerns. The test failure in previous version is a flaky test, it also occurs in https://github.com/apache/hbase/pull/5876

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

Requested changes applied.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 22s
Docker mode activated.

Ping @bbeaudreault . I think this should be merged so we can start releasing 2.6.1?
Thanks.

Thanks for the ping @Apache9. It looks like this is ready, but I've asked @rmdmattingly and @ndimiduk to take one more like and handle committing if it's working for us internally.
In terms of 2.6.1, I want to make sure we've fixed as many of the known issues as we can. I've asked @rmdmattingly to compile a list of jiras that we're working on internally. Once I have those I'll setup fixVersions/blockers in jira so that we can track progress towards release.

In fact I'm going to send an email to the dev list so that @DieterDP-ng and his team can also list any jiras we want to try to get into that release.


timeout event

Is there any way you could add an event for timeout and also an event for when the notification is closed / dismissed just like node-notifier has ?

+1 to this. HTML5 notifications (at least as implemented by Chrome) call an onclose handler when closed (via the notification close button) or when the display times out and it closes automatically. I might look into PRing this...

Hey folks - I don't think the native macOS APIs expose this information. The actual display / dismissal of the notifications is super opaque, and you can't even tell from your app whether they have "Do Not Distrub" turned on, hiding your notification entirely. I think if it were possible, it would be part of this NSUserNotificationCenterDelegate protocol:
https://developer.apple.com/reference/foundation/nsusernotificationcenterdelegate

I'm pretty sure a closed/dismissed event is possible using the undocumented NSUserNotificationCenter didDismissAlert method. It seems to be working in my fork now (https://github.com/ccnokes/node-mac-notifier). When I have time I'd like to actually contribute it back here (needs improvement first). I looked at Firefox's source for direction on the implementation. Firefox implements the Notification HTML5 spec using the native NSUserNotificationCenter and it's friends, so it should be possible here to do that but offer even more flexibility (e.g. have dropdown menu in the notification).


added spacedock download

Hi there! Thanks for trying to help out with CKAN metadata. We certainly appreciate all the help we can get. Unfortunately, #kref stanzas don't belong in the .ckan files. They are used in the .netkan files in the NetKAN repository in order to automatically create these CKAN files. In this instance, the .netkan file we have, https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/BetterTimeWarp.netkan was submitted by the mod author themselves, so it seems they want CKAN to grab it from Github instead (which theoretically, could be slightly faster to update if the Spacedock zip is copied from the GitHub release one).


fix _remove_node_features from removing u_ref_relative

Description
Fix g.nodes['g'].data['u_ref_relative'] from being deleted during espfit.utils.graphs.reshape_conformation_size
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Status

[x] Ready to go

Test failure due to missing openeye-toolkit license.


SQL script changes/additions to populate production database

Fixes #262 : Populate real labman db with needed real equipment/etc records by adding the new equipment types identified by the wet lab (but NOT new equipment, given decision that users should make use of the GUI for that), adding two real users (one wet lab, one developer) with admin access (who are responsible for adding other users through GUI), modifying description of plate types to not conflict with the terminology the wet lab uses.
Issue #262 also bleeds over into (at least) two other issues, so this PR fixes #288 Add 18S and ITS primer plates to Prepare Amplicon Libraries (which is a subset of 262 that was raised by a wet lab user) by adding the 18S and ITS primer set plate maps.  It also extends and fills in the descriptive info about the amplicon primer sets (e.g. linker primer sequence), which lays some necessary groundwork for #301 Update generation of Preparation Sheets contain correct columns/values because some of the info needed to generate the Prep Info files previously didn't actually exist anywhere in the db.

@antgonza Ugh, you're very right.  I've regenerated the labman.html and labman.dbs files to reflect the table structure changes to marker_gene_primer_set, and updated the PR.


Does "Delete" also remove syncronization rules created by the AAD Connect Configuration Wizard

This page suggests that we can remove a forest from the synchronization server by using the miisclient.exe however it is not clear how this impacts synchronization rules created by the AAD Connect Config Wizard. Do we need to go into the rules editor to remove those manually?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 653f79c0-27ad-1c43-e78d-1db38feadb8c
Version Independent ID: a2c4ab07-2ab5-9172-89bb-e1776a135f79
Content: Connectors in the Azure AD Synchronization Service Manager UI
Content Source: articles/active-directory/hybrid/how-to-connect-sync-service-manager-ui-connectors.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@Mike-Crowley
Thanks for your feedback! We will investigate and update as appropriate.

Yes, deleting a connector from the Synchronizations Service Manager will also delete all the sync rules associated with it. One of our engineers just made a pull request to add this to the documentation.
Hope this helps!


Convert mel to audio

Hi, is there any thing I can do to convert the mel spectrogram back to audio? I am using librosa to covert it but it takes ages just to reform 8-10s audio. Thanks

Sorry @juunnn I don't have a great answer. Some people use GANs to produce audio from spectrograms: https://github.com/paarthneekhara/advoc


Cannot find namespace Proteomics.Utilities

When I am building this project, I encounter some problems about the reference.  The reference DLL must be agree with the project in processor architecture (X86, X64) and .Net framework. Could you share a suit of usable reference DLLs? Thanks!

The code for Proteomics.Utilities is here:
https://github.com/olivierlizotte/Proteomics.Utilities

Thanks for your help. The namespace of Proteomics.Utilities is OK.
However, I encounter one problem about PeptidAce.ISO: The function Ace.Start() is used in the "StatsMaker.cs" like this "Result SpikedResult = Ace.Start(options, samplesSynth, false, false);" .But the statement of  Ace.Start()  in "PeptidAce.Ace.cs" is "public static Result Start(DBOptions dbOptions, string fasta, Samples project, bool loadMS1 = true, bool filterMS2 = true, Queries queries = null);".
Please note that the second parameter in the statement is string, but the type of samplesSynth is Samples. Could you help me to solve this problem?

Can you add the fasta string?

I have changed your code to  run it. But I don't know if the project function is still OK.
Thanks for your help.


Update Mocha

Mocha caused Node 5 tests to fail (https://travis-ci.org/meanjs/mean/jobs/108313328)

Still erroring out:
http://puu.sh/n3e88/8cac83d59d.png
btw, they have the best error message ever.

Based on https://github.com/mochajs/mocha/issues/2102#event-546388074, it looks like mock-fs is the issue. I'll look into that.

@codydaig let's get this merged in after we merge in #1184 so we make sure it works on all OSes.

#1184 has been merged.

Awesome, closed an reopened so Travis will re-run.

@ilanbiala Passed. Squash and we can merge.

LGTM

@codydaig if LGTY, go ahead and merge once tests pass.

guys is this ready for primetime? I would like to bang on it.


default orphan delete option for read only update strategy.

ref: https://issues.redhat.com/browse/ACM-13118

/assign @clyang82

/ok-to-test


Bug fix for #4065. After base64 encoding username/password, properly escape characters =,+,/ before submitting auth details

For full details regarding the patch, please see: https://redmine.pfsense.org/issues/4605#note-1

Sorry, my commit message/pull request references the incorrect bug (#4065). This is a fix for #4605.
For the fix for #4605 please see this new pull request: https://github.com/pfsense/pfsense/pull/1712


Backport New Scikit-Learn Validation Methods

Pull Request Test Coverage Report for Build 138

110 of 164 (67.07%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-7.2%) to 87.85%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sliced/externals/sklearn_partial.py
106
160
66.25%

Totals

Change from base Build 134:
-7.2%

Covered Lines:
564

Relevant Lines:
642

💛  - Coveralls


Update builder docstring for deprecated/added arguments

This PR updates the builder docstring with deprecated/added directives for arguments name/config_name.
Follow up of:

#4414
huggingface/doc-builder#233

First merge:

#4432

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@mishig25 is investigating why deprecated/added do not affect the enclosed text format when used in args docstring.

@albertvillanova please check now 👍
https://moon-ci-docs.huggingface.co/docs/datasets/pr_4429/en/package_reference/builder_classes#datasets.DatasetBuilder

Just one question: is it expected to have the deprecated box right edge not filling all the page width (contrary to the added box)?

Yes, that is expected 😊 because the depreacted box is being bounded by its parent box (the box for name argument in the screenshot above)


AndroidPubSub Sample does not work!!!

Followed the instruction https://github.com/awslabs/aws-sdk-android-samples/tree/master/AndroidPubSub to set the parameter on the AWS cloud
Downloaded the whole code from https://github.com/awslabs/aws-sdk-android-samples
Used Android Studio 3.3.1 to open the folder AndroidPubSub
Changed the following part
PubSubActivity.java
// IoT endpoint
// AWS Iot CLI describe-endpoint call returns: XXXXXXXXXX.iot..amazonaws.com
private static final String CUSTOMER_SPECIFIC_ENDPOINT = "REPLACE_ME";
// Name of the AWS IoT policy to attach to a newly created certificate
private static final String AWS_IOT_POLICY_NAME = "REPLACE_ME";
awsconfiguration.json
"PoolId": "REPLACE_ME",
"Region": "Regions.US_EAST_1"
Sync, Build and Run App on emulator9.0 or Mobile Phone8.0, the result in Logcat is
com.amazonaws.demo.androidpubsub W/o.androidpubsu: Verification of com.amazonaws.logging.Log com.amazonaws.logging.LogFactory.getLog(java.lang.String) took 100.996ms
com.amazonaws.demo.androidpubsub E/com.amazonaws.demo.androidpubsub.PubSubActivity: onError:
java.lang.RuntimeException: Failed to initialize Cognito Identity; please check your awsconfiguration.json
at com.amazonaws.mobile.client.AWSMobileClient$2.run(AWSMobileClient.java:402)
at com.amazonaws.mobile.client.internal.InternalCallback$1.run(InternalCallback.java:101)
at java.lang.Thread.run(Thread.java:764)
Caused by: java.lang.IllegalArgumentException: Failed to read CognitoIdentity please check your setup or awsconfiguration.json file
at com.amazonaws.auth.CognitoCredentialsProvider.getRegions(CognitoCredentialsProvider.java:195)
at com.amazonaws.auth.CognitoCredentialsProvider.(CognitoCredentialsProvider.java:174)
at com.amazonaws.auth.CognitoCachingCredentialsProvider.(CognitoCachingCredentialsProvider.java:228)
at com.amazonaws.mobile.client.AWSMobileClient$2.run(AWSMobileClient.java:400)
at com.amazonaws.mobile.client.internal.InternalCallback$1.run(InternalCallback.java:101)
at java.lang.Thread.run(Thread.java:764)
Caused by: java.lang.IllegalArgumentException: Cannot create enum from Regions.US_EAST_1 value!
at com.amazonaws.regions.Regions.fromName(Regions.java:114)
at com.amazonaws.auth.CognitoCredentialsProvider.getRegions(CognitoCredentialsProvider.java:193)
at com.amazonaws.auth.CognitoCredentialsProvider.(CognitoCredentialsProvider.java:174)
at com.amazonaws.auth.CognitoCachingCredentialsProvider.(CognitoCachingCredentialsProvider.java:228)
at com.amazonaws.mobile.client.AWSMobileClient$2.run(AWSMobileClient.java:400)
at com.amazonaws.mobile.client.internal.InternalCallback$1.run(InternalCallback.java:101)
at java.lang.Thread.run(Thread.java:764)
Seems that the AWS modules do not work in the App.
How to deal with this problem?
Should there some other code be added?

Hi @iwwork@, sorry you are running into issues using our PubSub sample app. I've opened the following issue in the AWS Android SDK repo, and will close this PR, since it's really just an issue.
https://github.com/aws-amplify/aws-sdk-android/issues/719
Please watch the issue for updates.


What is PCPI base address?

Hi,
Does anyone know what is the base address of PCPI interface? I  am changing firmware to access my PCPI based co-processor from software but could not find its base address. I dont know if I am overseeing something basic here. Thanks in advance.

Hi gatecat, thanks for clearing my doubt, do you know any example where pcpi is controlled from software? that would be very helpful, I checked for the examples like fast_mul but I couldn't find any traces of pcpi  in firmware?

In this case, fast_mul is just implementating and handling the standard RISC-V multiply instructions.

Thanks for the clarification @gatecat , do you have any idea about the structure of opcode one must use to access pcpi?

You can get the base from the examples given for the pcpi, the bits where you cant find it..just make them 0...it will work


Image ALT elements

Image ALT elements
User Story
AS A marketing agency
I WANT a codebase that follows accessibility standards
SO THAT our own site is optimized for search engines
Acceptance Criteria
GIVEN a webpage meets accessibility standards
WHEN I view the image elements
THEN I find accessible alt attributes

Added alt attributes to all img elements


extend supported questionnaire features

each type of item except 'display' and 'group' can have children (closes #115 )
'boolean' questions now have dedicated yes/no input
input of items with 'regex' extension is validated

Codecov Report

Merging #116 (c592204) into main (6061405) will increase coverage by 0.73%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   76.04%   76.78%   +0.73%
==========================================
  Files          41       41
  Lines         977      939      -38
  Branches      190      167      -23
==========================================
- Hits          743      721      -22
+ Misses        114      105       -9
+ Partials      120      113       -7

Flag
Coverage Δ

unittests
76.78% <87.50%> (+0.73%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/components/questionnaireModal/progressbar.jsx
100.00% <ø> (+50.00%)
:arrow_up:

...components/questionnaireModal/input/basicInput.jsx
82.05% <81.81%> (-1.82%)
:arrow_down:

...omponents/questionnaireModal/questionnaireItem.jsx
79.16% <83.33%> (+5.48%)
:arrow_up:

src/services/questionnaireAnalyzer.js
72.78% <84.61%> (-0.22%)
:arrow_down:

...mponents/questionnaireModal/input/booleanInput.jsx
100.00% <100.00%> (ø)

...mponents/questionnaireModal/input/choicesInput.jsx
96.00% <100.00%> (+0.54%)
:arrow_up:

.../components/questionnaireModal/input/dateInput.jsx
87.50% <100.00%> (ø)

...omponents/questionnaireModal/input/sliderInput.jsx
100.00% <100.00%> (ø)

...mponents/questionnaireModal/questionnaireModal.jsx
94.44% <100.00%> (-0.30%)
:arrow_down:

src/store/questionnaire.slice.js
79.66% <100.00%> (+1.69%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6061405...c592204. Read the comment docs.