Allow safe functions with raw pointer arguments

With the current implementation, it looks like raw pointer arguments force functions to be marked unsafe. This arbitrarily restricts patterns that don't need to unsafely use the pointers.
extern "Rust" {
    fn log_address(ptr: *const ());
}
fn log_address(ptr: *const ()) {
    eprintln!("{:p}", ptr);
}
// A more realistic might be a datastructure that holds erased types. Either way, the Rust code
// shouldn't be `unsafe` if it isn't performing unsafe operations

If there are any unsafe blocks within the function (which would be necessary to dereference them), then Rust has always made it the developer's responsibility to document the invariants. I see no reason for this to be different in cxx, and the inconsistency implies that there's something unsafe about even passing pointers to a function in the first place.

See https://github.com/dtolnay/cxx/issues/164#issue-608611434 for dtolnay@'s comment which proposed this.
My opinion (as #689 was initially my work):

For extern "C++" blocks I think it's absolutely right that functions with pointer arguments are marked unsafe. Using a C++ function is likely to dereference the pointer, cxx can't know for sure, and it's right that code calling such functions has to think carefully about the pointer they're passing in.
For extern "Rust" blocks I agree with you. The Rust implementation of the function can have certain parts of the function potentially marked unsafe if it chooses to dereference the pointer, and otherwise, it shouldn't need to be unsafe. Even if we assume that 99% of such functions will dereference the pointer, it's nevertheless safer for specific parts of those functions to be marked as unsafe rather than the whole function. And marking it as unsafe doesn't make any difference to how it's called from C++ anyway.

We will need to wait to see what @dtolnay says but if he agrees with you for extern "Rust" functions, I'd be happy to be involved in reviewing a PR to relax this restriction on extern "Rust" functions.

I would prefer not to change this. FYI the implementation of the function does not need to be an unsafe fn, only the declaration in the bridge module. So you are still free to use internal unsafe blocks to delimit parts of the implementation which rely on the validity of the pointer, if any.


[stemcell] Missing library when building "bosh_micro_go"

If you try to generate a Ubuntu stemcell as following:
bundle exec rake stemcell:build_os_image[ubuntu,trusty,/tmp/ubuntu_base_image.tgz]
bundle exec rake stemcell:build_with_local_os_image[openstack,kvm,ubuntu,trusty,go,/tmp/ubuntu_base_image.tgz]

It will fail in the stage bosh_micro_go. I have around the full build log, but this is the relevant part of the log :
+ mkdir -p /var/vcap/bosh/blob
+ echo 'Starting micro bosh compilation'
Starting micro bosh compilation
+ cat
+ cat
+ agent_pid=21162
+ echo 'Starting BOSH Agent for compiling micro bosh package, agent pid is 21162'
Starting BOSH Agent for compiling micro bosh package, agent pid is 21162
+ /var/vcap/bosh/bin/bosh-agent -P dummy -M dummy -C /var/vcap/bosh/agent.json
+ wait_agent localhost 6969
+ for i in '{1..10}'
+ nc -z localhost 6969
/var/vcap/bosh/bin/bosh-agent: error while loading shared libraries: libgo.so.5: cannot open shared object file: No such file or directory

I assume this is because it's missing a dependency, and actually, after installing  apt-get install libgo5 in the chroot, the stage bosh_micro_go worked fine.

Did you modify stemcell building or bosh-agent in some way? Are building bosh-agent with gccgo?

I didn't modify anything yet, just trying to build a Ubuntu stemcell to understand all the process. That might be the issue (gccgo).. I'll try to reproduce this again in a clean environment.

I assume this problem was caused by my stemcell builder VM using gccgo. Closing.


Added .jshintrc to define jshint behavior, updated files accordingly

This looks like a lot in the diff, but its really not that much:

deletes stale /demos/demo1
renames demos/demo2 to demos/demo1
updates all files per new .jshintrc

One change makes it look like everything has changed, but it is for the most part indentation:
(function() {
    'use strict';
    // use strict is inside an iife so as not to affect global state & potentially break 3rd party non-strict
    // all code now indented indented
})();

@jwforres for review!

I will likely work off of this branch till it gets merged as I'll want the .jshint running correctly against new code.


Make RichText also honor DefaultTextStyle (at least, if a bit is set)

@abarth this would make stocks' use of RichText cleaner

I'm going to close this. If we need something like this we can create a new widget for it.


mqtt_client seems to not find ROS2 topics anymore if I use a sever based fastdds discovery mechanism

Let's assume I have two machines that I am running mqtt_client on, both have ROS2 Humble installed.
I now run a mosquitto broker on machine 2 and bridge some ros topics from machine 1 to machine 2 via mqtt_client and echo the respective ROS topics on machine 2. That works as expected and I see the data flowing on machine 2.
Now, I add a third machine (running ROS2 Foxy) as a fastdds discovery server and tell machine 1 that machine 3 runs the fastdds discovery server via a client (not super_client) configuration file. I then do not see (ros2 topic list) the ROS topics on machine 1 anymore (as one would expect from a simple client configuration) but, of course, all ROS nodes running on machine 1 can still access the necessary data and are running fine. However, I now run the mqtt_client on machine 1, the data is not arriving on machine 2 anymore.
It seems that the mqtt_client has somehow problems with the fastdds discovery client/server configuration.
Do you have any idea why this could be the case?

Interestingly, I have just tested it, the mqtt_client bridging works again when I configure machine 1 to be a "super_client" instead of being a "client".


Modified example AWS deployment config file

I modified the example AWS deployment configuration file to a better example: using a more modern AMI, a smaller AWS instance, EBS storage. I also changed the comments on the AMI. Those comments now point the reader to:
https://cloud-images.ubuntu.com/locator/ec2/
where they can find an Ubuntu AMI (created by Canonical) which suits their needs.

Current coverage is 95.84% (diff: 100%)

Merging #665 into master will not change coverage

@@             master       #665   diff @@
==========================================
  Files            21         21
  Lines          1155       1155
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1107       1107
  Misses           48         48
  Partials          0          0

Powered by Codecov. Last update 1ae0899...47108b2


CompileShader crash with XCode7 on iOS 9

Workaround for iOS 9.0 and XCode7
Original post : http://forum.cocos2d-objc.org/t/xcode-7-ios9-beta/17346/6
Thanx to Reid

Just used you fix.Thanks for this, but it now crashes on iOS7 because you use containsString. I changed it to:
 if ([sourceStr<EMAIL_ADDRESS>!= NSNotFound) {
And then it works on all iOS versions.


Default parameter is not leveraged when the variable that is assigned the function with the default argument is called

Description

There is a function that takes a default value for a parameter
Let's define a variable as a function type by assigning the function above to the variable
When the variable is called without a parameter, it does not leverage the default parameter

Steps to reproduce

func showNumber(num: Int = 10) {
    print(num)
}

var showNum = showNumber

showNum()    // throws an error ("Missing argument for parameter #1 in call")

// modified to take an optional Int? argument
func showNumber(num: Int? = 10) {
    if let num = num {
        print(num)
    } else {
        print("num is nil")
    }

...

showNum()    // still throws the same error

Expected behavior

Expected showNum() to print 10

Environment

Swift compiler version info : swift-driver version: 1.75.2 Apple Swift version 5.8 (swiftlang-<IP_ADDRESS>.2 clang-14<IP_ADDRESS>.100) Target: arm64-apple-macosx13.0
Xcode version info : Xcode 14.3 Build version 14E222b
Deployment target: : macOS

This is expected behavior, in swift values of function type do not have default values applied, showNum has type (Int?) -> Void

This is expected behavior, in swift values of function type do not have default values applied, showNum has type (Int?) -> Void

Since this is an expected behavior, do you suggest not assigning functions that take default parameters to variables of function type?

They can be assigned, just don’t expect that they can be called without providing arguments.

Okay. I will keep in mind that variables of function type that are assigned functions with default parameters have to be called with arguments. In other words, they don't take default arguments.
At one point, I was wondering if the type could look like this, but this is simply not a correct type defining syntax for variables of function type.
var showNum: (Int? = 10) -> Void

Thanks for clarifying this!


Show blocked info page in incognito

Fixes https://github.com/penge/block-site/issues/41

Awesome work!


iOS Distribution Certificate expiration - one year anniversary!

It's my one year anniversary with raix:push!  Thank you for the great work @raix et al! :dancers:
So Apple has kindly emailed me to say iOS Distribution Certificate will expire.  Has anyone else come to the same threshold?
To resolve this, is it just a matter of generating and replacing the keyData and certData .PEM files?  And would the new PEMs work straightaway or do I have to wait for the old one to expire first?

Thanks @Alveoli :)
You just need to create a new distribution cert and use that in the provision + generate new push certs...

Ok, I just did the Renew APN certificate dance, here's the difference from the first time:

Go to https://developer.apple.com/account/ios/identifier/bundle
Select your App
Edit. It should look like this:

Create Certificate
Continue
Choose your CertificateSigningRequest.certSigningRequest file from last year (You kept it handy, right? :) )
Continue
Download the .cer file
Follow the rest of the guide from Congrats, now click 'Download' at https://github.com/raix/push/wiki/iOS-Micro-Walkthrough

Ultimately, replace your two exisiting .pem files.  You don't need to expire the old ones, so these ones can be valid at the same time. Note that the validity date is 365 days from when you request these new certs, so every time you're bringing your expiry date forward a little.

https://github.com/Appuploader/applicationloader/wiki/application-loader-windows


Frontend: page to restore offer properly

Only possible if marketplace key is available.

Also if user is still logged in with random Full Access Key.


Projects where owner has changed will not play

I've just 'given' myself a project that belonged to another user through the management pages. It will now no longer play, preview or load in the editor as the xml doesn't load.
It's looking for a folder in user-files that doesn't exist as it's trying to use my username in the path rather than the original project creator's username e.g. USER-FILES/123-cczfc-Nottingham when it should be looking for USER-FILES/123-[original owner username]-Nottingham
This always worked previously so I guess there's something in the new release causing an issue

@FayCross Does this fix this for you?
I fixed the situation where you have already access to an LO and then get owner rights. Previously you ended up being both a creator and editor (or read-only) which doesn't work.
The folder should be renamed, I didn't change or add that functionality. So the code trying to open a folder with your username is correct.
If this works, I'll push it into the release.

No it doesn't work. I didn't realise it changed the folder name, I thought it just changed something in the database.
I'll keep this closed though as I suspect it's a permissions thing on our install. Apparently something's gone wrong with Julian's permissions as he reported a couple of days ago that he's not able to access the user files folder anymore. I can see that the change owner php file is owned by him so it'll be to do with that. If it's not working after he's back next week & has his access back I'll reopen this.

@FayCross @torinfo I just tested this on one of the installations I upgraded to 3.5.
I can confirm that with the 3.5 release prior to Tom's fix I got the same as Fay e.g. I changed ownership of a project via management and then tried to access the project as the new owner and although the project was showing in the new owner's workspace it wouldn't play or edit because the folder in USER-FILES still had the original owner's name. I applied the change Tom committed this morning to the 3.5 install and then the changing back and forth worked fine e.g. the project folder is renamed each time to the new owner.
So please do push that change into the release Tom as at the moment changing of ownership is definitely broken in the 3.5 release.
HTH
Ron

@FayCross @torinfo BTW I should have added that even if there is something awry specific to the UoN install my tests obviously indicate that this had become broken in 3.5.

Pushed to master

How strange that this hasn't worked for me too. I'll see what happens when Julian's access is reinstated and let you know if it starts working then


Searchbar input not clicable on iOS

I am using this with:
"react-native-router-flux"
Using "native-base": "^2.0.13", and "react": "15.4.2", "react-native": "0.42.0",
<Container>
       <Header searchBar rounded >
       <Button transparent onPress={()=>{Actions.pop()}}>
           <Icon name="arrow-back" />
       </Button>
         <Item>
               <Input keyboardType={'default'}  placeholder={translate.t('profile.searchIllness')} onChangeText={this.onTextChanged}   />
             </Item>
        </Header>

                {body}
                {spinner}

</Container>

Input looks like this and is not responsive at all:

However this is working on Andorid and not working on iOS

You have to set width of input othervise it wont work

@obykoo seems to work fine.even without width .

input not clicable on iOS but work on Android too here
         <Item inlineLabel>
            <Label style={{ color: '#979797' }}>姓名:</Label>
            <Input
              style={styles.input_name}
              onChangeText={this.props.onNameChange}
            />
          </Item>

@HyperSimon

it seem to work fine . Try out again .

@GeekRishabh Thanks.In my case is that the following layout covers the input box, causing the input box to be clickable.


save method creates a blank svg

The following code outputs the desired plot in Jupyter Lab, but the saved graphic is blank.
sc.Figure("18cm", "9cm",
    sc.Panel(
       sc.SVG("fig1"),
       sc.Text("A", 8, 18, size=14, font='sans')
    ),
    sc.Panel(
       sc.SVG("fig2"),
       sc.Text("B", 8, 18, size=14, font='sans')
    )
).save('test')

thanks @shervinsahba, it works with the examples that I have. It's probably something about the input files that causes the problem. Would you mind sharing fig1, fig2 and test (output file)? If you don't want to share them pubilcly, you can share it with my by a private message on gitter

Thanks for the reply @btel. Looks like it works overall! There may or may not be an issue with the default SVG encoding produced by svgutils, since several programs seemed to not render the image (see below). I experienced the issue with a variety of files including the example SVG logo.

Krita reads in the outputted SVG as a blank image but works fine with the originals.
Thunar file manager does not display a thumbnail for the outputted SVG but does for the originals.
Inkscape worked fine.
Firefox worked fine.

But, wow, now that this works I need to say thanks! This really helps with the figures workflow.

thanks @shervinsahba for reporting, we need to work more on standard conformity and compatibility with all the viewers. I am glad to hear that you find svg_utils useful!


https://<IP_ADDRESS>:5000 SSL_connect error

Hi @mwielgoszewski
After docker setup when hitting https://<IP_ADDRESS>:5000 gives error as curl: (35) LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to <IP_ADDRESS>:5000
No errors on docker-compose up,

m-c02qm1tbg8wl:doorman akailas$ docker-compose up
Starting doorman_doorman_1 ...
Starting doorman_postgres_1 ...
Starting doorman_doorman_1
Starting doorman_doorman_1 ... done
Attaching to doorman_postgres_1, doorman_doorman_1
postgres_1  | LOG:  database system was interrupted; last known up at 2017-07-19 02:27:10 UTC
postgres_1  | LOG:  database system was not properly shut down; automatic recovery in progress
postgres_1  | LOG:  invalid record length at 0/15CBDF8: wanted 24, got 0
postgres_1  | LOG:  redo is not required
postgres_1  | LOG:  MultiXact member wraparound protections are now enabled
postgres_1  | LOG:  database system is ready to accept connections
postgres_1  | LOG:  autovacuum launcher started
doorman_1   | [2017-07-19 02:40:20 +0000] [11] [INFO] Starting gunicorn 19.6.0
doorman_1   | [2017-07-19 02:40:20 +0000] [11] [INFO] Listening at: http://<IP_ADDRESS>:5000 (11)
doorman_1   | [2017-07-19 02:40:20 +0000] [11] [INFO] Using worker: sync
doorman_1   | [2017-07-19 02:40:20 +0000] [18] [INFO] Booting worker with pid: 18
doorman_1   | [2017-07-19 02:40:20 +0000] [19] [INFO] Booting worker with pid: 19
doorman_1   | [2017-07-19 02:40:20 +0000] [20] [INFO] Booting worker with pid: 20
doorman_1   | [2017-07-19 02:40:20 +0000] [21] [INFO] Booting worker with pid: 21
doorman_1   |
doorman_1   |  -------------- celery@3abb4b1f9deb v3.1.23 (Cipater)
doorman_1   | ---- **** -----
doorman_1   | --- * ***  * -- Linux-4.9.31-moby-x86_64-with
doorman_1   | -- * - **** ---
doorman_1   | - ** ---------- [config]
doorman_1   | - ** ---------- .> app:         doorman.tasks:0x7fe063b1ccd0
doorman_1   | - ** ---------- .> transport:   redis://localhost:6379/0
doorman_1   | - ** ---------- .> results:     redis://localhost:6379/0
doorman_1   | - *** --- * --- .> concurrency: 4 (prefork)
doorman_1   | -- ******* ----
doorman_1   | --- ***** ----- [queues]
doorman_1   |  -------------- .> celery           exchange=celery(direct) key=celery
doorman_1   |
doorman_1   |
doorman_1   | [tasks]
doorman_1   |   . doorman.tasks.analyze_result
doorman_1   |   . doorman.tasks.example_task
doorman_1   |   . doorman.tasks.learn_from_result
doorman_1   | [2017-07-19 02:40:20,850: INFO/MainProcess] Connected to redis://localhost:6379/0
doorman_1   | [2017-07-19 02:40:20,859: INFO/MainProcess] mingle: searching for neighbors
doorman_1   | [2017-07-19 02:40:21,868: INFO/MainProcess] mingle: all alone
doorman_1   | [2017-07-19 02:40:21,878: WARNING/MainProcess] celery@3abb4b1f9deb ready.

Also doorman container src/doorman/settings.py ProdConfig looks like below, Where I can see DOORMAN_ENROLL_SECRET, BROKER_URL, CELERY_RESULT_BACKEND are empty? Is this expected?
class ProdConfig(Config):

    ENV = 'prod'
    DEBUG = False
    DEBUG_TB_ENABLED = False
    DEBUG_TB_INTERCEPT_REDIRECTS = False

    ENFORCE_SSL = True

    SQLALCHEMY_DATABASE_URI = 'postgresql://doorman:pass@postgres:5432/doorman'

    DOORMAN_ENROLL_SECRET = [

    ]
    DOORMAN_MINIMUM_OSQUERY_LOG_LEVEL = 1

    BROKER_URL = ''
    CELERY_RESULT_BACKEND = ''

Issue Fixed


feat(multisrc/animestream/es): New source: AnimeYT.es and Anime.Tiodonghua.com and fix EnNovelas

Checklist:

[x]  Updated extVersionCode value in build.gradle for individual extensions
[x] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[x] Have not changed source names
[x]  Have explicitly kept the id if a source's name or language were changed
[x] Have tested the modifications by compiling and running the extension through Android Studio

thank claudemirovsky

pull ready for merger

#2533 Close  change domain base  for fix error 505

Also please delete all the foreground, background, monochrome and xml launcher files. Only the ic_launcher.png file is needed. (See other sources)

Ready 🗡

Please add the site and turn it into an extension
https://i-egybest.info/

https://i-egybest.info/[](url)


Issue while deploying Starter Kit V2 - fails after updating package it seems

##Category

[x] Bug

Describe the bug
I have followed the instruction to complete pre-requirements for installing Starter Kit v2 .
I ran the command Apply-PnPTenantTemplate -Path starterkit.pnp as per instruction and it does start processing the installation but after a while it fails with following error
Apply-PnPTenantTemplate : Exception while invoking endpoint https://login.microsoftonline.com/ff47ce9f-100c-4221-ae51-71e06b5edc04/oa
uth2/token.
At line:1 char:1

Apply-PnPTenantTemplate -Path starterkit.pnp

  + CategoryInfo          : WriteError: (:) [Apply-PnPTenantTemplate], ApplicationException
  + FullyQualifiedErrorId : EXCEPTION,SharePointPnP.PowerShell.Commands.Provisioning.Tenant.ApplyTenantTemplate

Expected or Desired Behavior
Successful installation of Starter Kit v2
Observed Behavior
Installation was able to create a site called "Contoso electronics"
Also following packages were installed successfully
react-recently-used-documents-client-side-solution
react-people-directory-client-side-solution
react-recent-contacts-client-side-solution
react-followed-sites-client-side-solution
react-application-portal-footer-client-side-solution
react-command-discuss-now-client-side-solution
react-lob-integration-client-side-solution
library-starter-kit-shared-client-side-solution
react-site-information-client-side-solution
react-recently-visited-sites-client-side-solution
react-application-collab-footer-client-side-solution
react-banner-client-side-solution
js-application-redirect-client-side-solution
react-personal-calendar-client-side-solution
react-personal-tasks-client-side-solution
outlook-2-sp-spfx-client-side-solution
react-links-client-side-solution
react-weather-client-side-solution
react-tiles-client-side-solution
react-personal-contacts-client-side-solution
react-personal-email-client-side-solution
react-application-alerts-client-side-solution
react-world-clock-client-side-solution
Steps to Reproduce
Follow the normal instructions, nothing special was done
Environment Details (Development & Target environment)

Starter kit version: v2
OS: Windows 10
Target Environment: SharePoint Online

Thanks for your contribution! Sharing is caring.

Duplicate #410


crash

static void __stdcall paintTraverse(unsigned int panel, bool forceRepaint, bool allowForce, UserCmd* cmd) noexcept
{
if (interfaces.panel->getName(panel) == "MatSystemTopPanel") {
Misc::lci(cmd);
Misc::drawBombTimer();
Misc::watermark();
Misc::spectatorList();
Esp::render();
}
hooks.panel.callOriginal<void, unsigned int, bool, bool>(41, panel, forceRepaint, allowForce, cmd);
}
my code it's good but i get crash, help me pls

Remove that code with (cmd)

but i must have with cmd

Post the code for Misc::lci(cmd);
Or find a way to separate the code, So that you call the cmd stuff in createmove and drawing stuff in paint traverse.


SpectatorView: Add stub frame provider for testing

Currently it is impossible to record a test video without having an actual camera connected to the PC.
This problem could be solved by adding an option to wrap the real IFrameProvider object with a stub.
When the real frame provider is not initialized (e.g. device is not present), the stub methods do nothing and return dummy values. In this case, user is provided with a statical background frame.
When the real frame provider initializes, stub delegates all method calls to the wrapped object.

Updated frame provider and video encoding logic in this PR to address this issue:
https://github.com/Microsoft/HoloLensCompanionKit/pull/168
In addition to the compositor changes, please note there is a small change to SpectatorViewManager.cs in the Unity addon to always update the compositor rather than blocking on the frame provider being initialized.


Seeds

Added seeds on main "Users" tab
Added hover tool-tip to users listed per-mod on the "Mods" tab (makes it easiser to see if a user with 1 bad mod has more bad mods)
Added "Seeds" tab
I didn't change the client version since this version is completely compatible with current operating servers, all just cosmetic changes/additions.

One thing I see of note is it squishes the action buttons. I may see what I can do to fix this though


[Request] Settings in user profile

Ace editor already supports alternative bindings such as Vim or Emacs modes. This is a request to enable choosing those bindings, so we can edit source code in our preferred way.

I'm quite interested in this. How would we present this to the users? Quite some time ago, someone floated the idea of a "Settings" menu item, along with "Help" and "About". In those settings, we could specify editor options and runtime limits, for example.

I envisioned a dropdown above the editor, allowing the user to select the editing mode.

However, I am unfamiliar with SA20/21 goals. A Settings page would make sense if cadet-frontend is intending to implement more user customizations. Additionally, keeping the option behind a Settings page would avoid confusion, as such editing modes are unrelated to the rest of the controls, which are all part of the module's learning goals.
Help and About are out of the scope of this request. I'd defer to cadet-frontend maintainers to decide those, in a separate issue.

Thanks for the mock-up!
I think such a drop-down menu would be much too prominent. Students would typically change their Ace mode three or four times max throughout the entire semester, and the majority of students (I estimate) would not touch the Ace mode at all. That's why I thought a less prominent and more global setting would be preferrable. I think local browser storage would be fine for this. (As opposed to saving this on the server.) This way the setting would also work for casual users of the textbook.
Not sure if you understood my comment about "Help" and "About". I only wanted to suggest a place for the "Settings" option. A good place might be here:

Settings
About
Help
in the dropdown for the button in the right upper corner.

Regarding the goals: I'm adding "online" to the SA tagline:
Immersive online experiential environment for learning programming
The editor plays a central role in this aspiration, so your comments and suggestions are very much appreciated!

Things are moving fast. We already have a profile page!
We could have the following items as "Settings" in the profile page:

Ace keyboard shortcuts, with the selection "default", "emacs" and "vi" (or whatever Ace allows)
Execution time (limit). This would allow us to remove this item from the playground and make it neater.

This could be part of the configuration: #1847


Install configuration upgrade script and improve testing

The main changes included in this patch set are the installation of the convert_config.py script as keylime_upgrade_config alongside other binaries and changes to the tests to make them to not install any binaries nor configuration files during execution.
The keylime_upgrade_config will use the /etc/keylime as the default output location when executed as root, otherwise it will use the current working directory as the output directory. The keylime_upgrade_config only performs upgrades when there is at least one configuration file that is not up-to-date. It compares each configuration version with the versions available in the templates directory (by default /usr/share/keylime/templates).
During startup of agent, verifier, registrar, or tenant, the respective configuration file version is compared with the latest upgrade template version available and will log a message in case an upgrade is available (it will not perform the upgrade automatically). When a minor upgrade is available, a message with INFO level is logged informing the available upgrade. If a major upgrade is available, a message with WARNING level is logged.
The configuration processing was modified to remove the quotes from strings obtained from the configuration files. This improves the compatibility with the TOML format used for the rust agent.
The tests were modified to not install keylime binaries nor configuration files during execution (the dependencies are still installed). A virtualenv and temporary files are used instead.
Superseds #1132

Codecov Report

Merging #1260 (fa1529e) into master (4720332) will decrease coverage by 64.43%.
The diff coverage is 0.00%.

Additional details and impacted files

Flag
Coverage Δ

packit-e2e
6.78% <0.00%> (-64.90%)
:arrow_down:

testsuite
2.26% <0.00%> (-53.48%)
:arrow_down:

unittests
0.96% <0.00%> (-12.11%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

keylime/keylime_agent.py
5.37% <0.00%> (-68.09%)
:arrow_down:

keylime/db/keylime_db.py
12.30% <0.00%> (-73.85%)
:arrow_down:

keylime/keylime_logging.py
18.18% <0.00%> (-54.55%)
:arrow_down:

keylime/cloud_verifier_tornado.py

keylime/cmd/registrar.py

keylime/config.py

keylime/tenant.py

keylime/revocation_actions/print_metadata.py

keylime/cli/policies.py

... and 90 more

/packit retest

/packit test

I could not re-run the PR code coverage measurement check. After the test changes (https://github.com/RedHat-SP-Security/keylime-tests/pull/284) are merged, and I rebase to drop the temporary commit that changes the tests reference, I believe it will re-run without issues.

I guess that the last commit will be dropped, but LGTM!

Yes, the last commit will be dropped before merge. But it is blocked by  https://github.com/RedHat-SP-Security/keylime-tests/pull/284

I just noticed that if you run it on an older installation of Keylime the upgrade script runs again because of the switch to quoting strings. E.g.:
 # The configuration file version number
-version = 2.0
+version = "2.0"

Is this intentional? In this case running the migration is fine, but it might be a little bit  confusing.
Otherwise this change LGTM.

I just noticed that if you run it on an older installation of Keylime the upgrade script runs again because of the switch to quoting strings. E.g.:
 # The configuration file version number
-version = 2.0
+version = "2.0"

Is this intentional? In this case running the migration is fine, but it might be a little bit confusing.

It is not :). Thanks for reporting this, I'll fix the bug

The linter issue seems to be addressed by #1267

/packit retest-failed

The failure in Fedora 36 is related with a regression introduced by an update from tpm2-tss from version 3.2.0 to 3.2.1, which was reported upstream. The tpm2_getekcertificate command cannot retrieve the EK certificate on the affected version.
The failure is unrelated with the changes introduced by this PR. After dropping the commit that changed the used tests branch this is ready to be merged.
See:
https://github.com/tpm2-software/tpm2-tss/issues/2537
https://bugzilla.redhat.com/show_bug.cgi?id=2158598


Add netlify attribute to form

Description
Add netlify attribute to contact form
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new errors

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Feat/get range

Codecov Report

Merging #223 (2ce61b1) into main (11b1b07) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   53.12%   53.12%
=======================================
  Files          37       37
  Lines        3070     3070
=======================================
  Hits         1631     1631
  Misses       1439     1439

Flag
Coverage Δ

rust
53.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add support for two-way binding (no ngModel)

Support two-way binding of editor content without the use of ngModel

👍


GLOBALS is not available on dedicated-thread page

It seems I can't create a Gmail reference on pages like the following:
https://mail.google.com/mail/u/0/?ui=2&view=btop&ver=dqujp3h61mgd&search=inbox&th=14d424827ebef4cb&cvid=1
You can access your own URLs by heading to your gmail and pressing Command+Click on one of your messages
Looks like the GLOBALS object doesn't exist here
Is there a way around this that you've run into?

having the same problem. any ideas here?
Error in event handler for extension.onRequest: TypeError: Cannot read property 'GLOBALS' of null

ok, i figured out what the problem is. you can't put gmail.js in a content page. it has to be injected into the gmail page itself: https://github.com/KartikTalwar/gmail.js/issues/36#issuecomment-36417505

Seems like this one is solved a long time ago. Closing.

Wow this was so helpful. rbpasker comment is exactly what I was looking for! If you don't understand, all you need to do is see how content.js is loading js files in the gmail-chrome-extension-boilerplate project. I put all my contents in a load.js file and used content_sripts to load it.
 "content_scripts": [     {       "matches": ["https://*.google.com/*"],       "js": [ "load.js"]     }   ],
Then it shows up in the main gmail page.


Remove need to register pending api tasks with Wendy.

Right now, I need Wendy to know about the existence of all pending API tasks in your application. It is a manual process that is annoying.
I would rather have this be more automated. I am thinking to have an annotation that you add to your class that tells Wendy that this is a pending API task. and I can create a Gradle build tool that lints your code and if it finds a class that is ___PendingApiTask (or extends WendyPendingApiTask) then I throw a compile time error for the user to fix it. Or I could have the Gradle plugin generate Kotlin code at compile time to register for me.

Check out https://github.com/levibostian/Wendy/issues/13 as a potential solution to this. I may not need to do this after all if I simply have Wendy take care of storing the wendy tasks to run.

I took this dependency out with the latest version of Wendy that I will update the code with shortly.
There is no longer the need to register pending API tasks.


Cannot search objects

SQL Operations Studio Version: sqlops 0.23.6 (8a3011756318a2ded1e6e84332230a2b2bf9c544, 2017-11-06T21:51:43.232Z)
OS Version: Windows_NT x64 6.1.7601

Steps to Reproduce:

click the magnifying glass to search
type in an object name
Program searches for files, not database objects

@gbritton1 Database search in Object Explorer / Search side bar is not implemented functionality yet. For the public preview, try Explore widget on Manage dashboard it has the database object search functionality.

Please use the Redgate SQL Search extension for searching SQL database metadata.


Formally introduce arguments[2] as newConfig

The 3rd argument (appropriately named newConfig) in the constructor is used when we are instantiating error from the error class returned by makeError(), which binds the first 2 arguments of ApolloError to the first 2 arguments of makeError().
newConfig should take precedent when merging with config

Sorry updated the PR to reflected the new changes.


polish: destination headsign paging fix

Notion task: No headsigns overflow 1024px / overlap with the following morning’s schedule time
An incorrect CSS class was causing text wrapping on some headsigns. Fixing this class fixed the paging issues.
I also went ahead and change v2 DUPs to use local Inter files.

[ ] Tests added?

👍 Lol, this solution is still funny

Glad you think so 😬


Swap preact-signal-store out for @deepsignal/react

Hi there! Github recently put a badge on my EthanStandel/preact-signal-store repo that said this was a dependent. I went to look at your project and saw that you were using React and not Preact which preact-signal-store did not support (it only integrated with @preact/signals which is a Preact specific package). However, last night I completed the rebranding of preact-signal-store to a series of packages under the @deepsignal/* organization on NPM.
So, if you want to use a fully Signal driven state management solution for React, you can now use @deepsignal/react which is based off @preact/signals-react! It should be a simple drop-in-replacement for anything you may have tried to do with it previously (and now it will actually work in your use-case). 🙂

Thanks,
It would be of great help
Sushant
On Mon, Oct 10, 2022 at 6:49 AM Ethan Standel @.***>
wrote:

Hi there! Github recently put a badge on my
EthanStandel/preact-signal-store repo that said this was a dependent. I
went to look at your project and saw that you were using React and not
Preact which preact-signal-store did not support (it only integrated
with @preact/signals which is a Preact specific package). However, last
night I completed the rebranding of preact-signal-store to a series of
packages under the @deepsignal/* organization on NPM.
So, if you want to use a fully Signal driven state management solution for
React, you can now use @deepsignal/react which is based off
@preact/signals-react! It should be a simple drop-in-replacement for
anything you may have tried to do with it previously (and now it will
actually work in your use-case). 🙂
—
Reply to this email directly, view it on GitHub
https://github.com/capitalch/bika/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFQUQY3MLZ4RMQ3VVAEVWQ3WCNVI5ANCNFSM6AAAAAARA5UKCE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Looks like this is good to go!


I am migrating my code from swift 3.3 to swift 4.1

I have migrated my code from Swift 3.3 to Swift 4.1. Everything is working fine. Its just that mj_object(withKeyValues:) returns nil object.
Please help me. As i am new to this library. Got the maintenance project.

You should ADD @objc attributes to your class and property since Swift 4.0. 🤝


Encoding "no physical parameters" in Trajectory files

How should we encode "no physical parameters" (no  variables) in the Trajectory files?  There will be cases where there is no "physical parameter" data to record in a Trajectory file but there is still other valuable information.
We have two options:

N_PARAM = 1; TRAJECTORY_PARAMETERS=  [" "]; no  variables
No N_PARAM, TRAJECTORY_PARAMETERS, or  variables in the file

Which would be more instructive to the user?
(They may not be mutually exclusive.  Could/should we allow both?)

PRES is a fundamental dimension of the trajectory file, 2nd only to TIME.  I would suggest PRES must be included (N_PARAM=1 minimum), and TRAJECTORY_PARAMETERS must include at least PRES, matching the N_PARAM definition.  The PRES variables can be empty.  Although it is hard for me to think that this is possible, even back in the earliest floats there was a few PRES data.  In any case, the lack of any PRES information supplies the user information on the validity of whatever remains from a sparse traj netCDF as is described here.

we had a handful of protoptype floats long ago that did not report any pressure data during drift. Because that makes it hard to use the trajectory for deriving currents at a known depth we did not make trajectory files for these floats.
In addition to that, they aslo had only one position per cycle, which limits the usefullness of trajectory files even more.

I agree with John's comment and that we should have PRES, even if it is empty.  This seems like a modified Option 1:
N_PARAM = 1; TRAJECTORY_PARAMETERS= ["PRES"]; PRES may be fillvalue


unique validator

hi
i want to unique validator in database
like this in laravel https://laravel.com/docs/5.6/validation#rule-unique

Hi. It looks like this is a question about how to use ASP.NET Core. We recommend posting your questions to StackOverflow using the asp.net-core-mvc tag for questions like these.


Add support for download reproducers by TestRun ID

Add support in squadutilslib and squad-create-reproducer for downloading the build or test reproducer by TestRun ID as an alternative to searching for the latest test reproducer in a given group and project.

@roxell if you are able to look over this PR when you have the opportunity that would be great.
I changed the input from the planned "job_url" input to the testrun ID since I discovered downloading the build reproducer requires the metadata file (which is accessible via the testrun).

This should probably be in its own script with its own parameters and then just call the common parts in squadutilslib to make it easier since the imput variables are so different or what do you think?

@roxell I have created a new script squad-create-reproducer-from-testrun and reverted the old script.
I also updated get_reproducer in squadutilslib.py to use the get_reproducer_from_testrun utility to do its download step.
Let me know what you think.
Also - I noticed the flake8 check only checks the .py files of the repo. I am not sure if it was intentionally set up this way, but I had some unused imports that it missed as a result. If we do want to run flake8 on the other Python files perhaps something like flake8 --exclude=dist/ --ignore=E501,W503 . squad-* could be used.

@roxell I have made the suggested updates and created a PR for fixing flake8 checks https://github.com/Linaro/squad-client-utils/pull/34

Latest pushes add support for fetching tux plan reproducers. Currently, the "test" side does not work as the new TuxSuite patch does not appear to expose the download URL for the tux plan test reproducer in the same way as the other test reproducer URLs. I have followed up on this with the Tux team.

@roxell I have added support for fetching tux plan reproducers - if you could have a look over this patch again that would be great

@roxell - I have now pushed an update which means the reproducer is only printed when --filename is not provided.

we do not need the yaml file to be exeutable...
maybe we just need to provide the url to the plan_file since tuxsuite can handle a url too what's your thoughts?

This is true - I think in both cases my only concern would be the number of code paths to maintain.

I have removed the feature of fetching TuxTest reproducers to improve maintainability and updated things so plans don't get marked as executable. I have updated the commit message and README to reflect these changes.
@roxell let me know what you think of these changes :+1:


Paginator: Customize the paginator to one mode

WHERE YOU CAN REPLICATE: tenant/application/DEVELOP
Steps to reproduce:
Go to the Applications and choose an appropriate entity application on the menu.
Actual result: System displays two different configurations to show item per page
DEVELOP:

The same behavior is on the Administration chapter for the following menu items as the Roles Management, Roles Matrix, User Management, etc.
Expected result: System displays paginator regarding Angular specification. See example here

also, roles inner tables should miograte on mat-tables...


Custom width of element

It would be great to have element taking the all width of the screen (MATCH_PARENT) instead of fitting the content (I'm thinking about the EditText especially) because it looks weird on tablet where there is plenty of space but the field is very short.
When I put the layout to match parent, some problems of apparition come.

In case that you are creating the EditText views programmatically, this is the code that you need to add in order to set their witdh to MATCH_PARENT:
...

ViewGroup.LayoutParams editTextParams = new ViewGroup.LayoutParams(
		ViewGroup.LayoutParams.MATCH_PARENT,
		ViewGroup.LayoutParams.WRAP_CONTENT);

yourEditTextView.setLayoutParams(editTextParams);

...

Here you can see that the code works:

In case that you are using an XML file, just set the width property as usual.

I am using an XML File, but in any case (I tried both), nothing is working.. My XML file looks like this (very classical) :
`
<EditText
    android:id="@+id/client_name_field"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:hint="Nom"/>

<EditText
    android:id="@+id/client_email_field"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:inputType="textEmailAddress"
    android:hint="Email"/>

`
If you have any clue, otherwise, I'll let it that way.

I am using an XML file and I already put the width as mentioned. I tried also creating it programmatically, none of them were working.
Here is how my XML looks (very classical) :
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"     android:orientation="vertical"     android:layout_width="match_parent"     android:layout_height="match_parent">
<EditText
    android:id="@+id/client_name_field"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:hint="Nom"/>

<EditText
    android:id="@+id/client_email_field"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:inputType="textEmailAddress"
    android:hint="Email"/>

</LinearLayout>
If you have any clue of that behavior, otherwise I'll let it that way!

I have the Same Problem and I use custom XML and inflate it to steps, now TextViews is getting wrap_content on run-time, what must i do?

When you inflate your custom layout you can add your params dynamically and it works. I've did this and it worked.
        LayoutInflater inflater = LayoutInflater.from(getBaseContext());
        LinearLayout glucoseTypeLayoutContent = (LinearLayout) inflater.inflate(R.layout.step_add_glucose_event_first, null, false);
        ViewGroup.LayoutParams glucoseTypeLayoutParams = new ViewGroup.LayoutParams(
                ViewGroup.LayoutParams.MATCH_PARENT,
                ViewGroup.LayoutParams.WRAP_CONTENT);
        glucoseTypeLayoutContent.setLayoutParams(glucoseTypeLayoutParams);


Maven Release?

Hi Udo,
This project looks great, thanks for your effort! We'd like to use EvalEx in one of our projects but see it hasn't been released to Maven central. Would you be able to release this?
The only alternative for us would be to download the source, build it, upload it to our own repository and work off of that. But that sort of defeats the dependency management feature of Maven and we'd opt to use a different tool.
I'd be happy to help you release this if you're new to the process.
Best,
Sean

Give me a few days to look into some options for this. This whole maven central administrative tasks are so complex and bureaucratic.

Great, thanks Udo.
Maven releases are a pain, lots of hoops to jump though to get started. I always go through sonatype, once you have everything set up it's pretty straightforward using the maven-release-plugin. Let me know how I can help.
Cheers,
Sean

I started a ticket for a new project on Sonatype, now I have to wait ...

Hi!
In the meantime EvalEx is already available on JitPack as a Maven artifact: https://jitpack.io/#uklimaschewski/EvalEx/f3b0f865b1 : )
Would be a bit easier with a GitHub release, btw.

Very cool, I had never heard of JitPack, what a neat idea. Let me know if you do get it released into Maven Central though as it would be one less repository in my pom.
Cheers,
Sean

Yes, jitpack looks cool. I have a Sonatype account/project set up now. I hope to find some time this weekend to try to get some artifacts up there.

Great, thanks for taking the time.

I plan to use Rultor for the Maven Central releases, which looks pretty neat. I though I had set up everything corerctly, but I am getting a gpg error now. I opened a new issue at https://github.com/yegor256/rultor/issues/853, I will have to wait to know what I did wrong.
You can see my tests with Rultor at https://github.com/uklimaschewski/EvalEx/issues/26

Hooray! I managed to built the relase artifacts and upload them to my sonatype staging area.
Now we have to wait until they get synchronized with maven central.
I commented on my initial ticket at sonatype, so they should hopefully enable synchronization soon.

That's great, thanks for taking the time Udo.

When I search for EvalEx in maven central it doesn't seem to be there yet. Is it available somewhere?

I still don't see it either. I was looking under the package com.udojava but find nothing. Usually it takes, at most, an hour to sync servers. Maybe you didn't close out the deploy repository with Sonatype?

There was a problem in verifying upon close, some parts were missing. I have to check it tomorrow.

I (hopefully) fixed all problems. Now it looks like we have to wait a bit longer than the usual hour or so, because it is the first release to maven central and it will need some manual administrator action.

EvalEx version 1.0 is now available through maven central.

Awesome, much appreciated Udo =)
Looking forward to working with your code.

Thanks Udo!!


Create another block for sb-starting-block: oik-sb/second-block

While converting oik, oik-bobbing-wide, oik-blocks, oik-css and other plugins to work correctly for multiple blocks registered from several block.json files and then to internationalize and localize, I discovered that I needed more code than originally developed for sb-starting-block.
Requirements

sb-starting-block to deliver more than one block: oik-sb/sb-starting-block and oik-sb/second-block
At least one should be server side registered ( oik-sb/sb-starting-block )
Each block to be registered with block.json using apiVersion:2
They should all be registered in the server
And have a reasonable number of supports attributes, including color and typography.
Each block should be internationalized, translated and localized for en_GB and bb_BB
Consider how easy it is to rename the following when cloned from the template:

plugin name
plugin slug
text-domain
block prefix
prefix for server functions

Code should be suitable for documenting the i18n / l10n approach.

Proposed solution

[x] Add oik-sb/second-block, originally built using npx @wordpress/create-block
[x] Update oik-sb/sb-starting-block
[x] Update sb-starting-block.php with i18n and l10n logic
[x] Add examples
[x] Change oik-sb/second-block  - removing CSS and adding several supports attributes - with slightly different values from oik-sb/sb-starting-block.

The src/README.md file is confusing. Unless you read it very carefully it's difficult to tell which npm command performs which task.
Update it then apply the changes to other plugins.

The src/README.md was updated in f101b48, tagged as #3 not #2


Latest version fails to compile

Steps to reproduce:
git clone https://github.com/GraphQLSwift/Graphiti
cd Graphiti
swift build

The build fails with:
.build/checkouts/swift-nio/Sources/NIO/CircularBuffer.swift:114:1: error: type 'CircularBuffer<Element>' does not conform to protocol 'MutableCollection'
extension CircularBuffer: Collection, MutableCollection {
^
.build/checkouts/swift-nio/Sources/NIO/CircularBuffer.swift:114:1: error: unavailable subscript 'subscript(_:)' was used to satisfy a requirement of protocol 'MutableCollection'
extension CircularBuffer: Collection, MutableCollection {
^

due to a breaking change in swift-collections.

Opened a PR with a fix here: https://github.com/GraphQLSwift/Graphiti/pull/74

Fixed by https://github.com/GraphQLSwift/Graphiti/pull/74
Thanks @icanzilb


Bob constructs invalid SAVOBJ comand

https://github.com/IBM/ibmi-bob/blob/9c0c41b19aff5db2f4cfb91d53e5ce460631f715/src/makei/crtfrmstmf.py#L199

Duplicate of https://github.com/IBM/ibmi-bob/issues/207


Add support for clipping to a Geometry. Fixes #359.

Fixes #359.

Awesome, thanks Jeremy! @danwalmsley you filed this bug, could you give the PR a try and see if it works for you?

@grokys @jkoritzinsky many thanks for implementing this. I will try and get time to test this out tonight.


Gather templating matters behind a specific part in the left menu

The left menu contains many items now, I think we should add part titles and part separators to improve readability, starting with templating matters (from Rendering to Custom helpers).

I was thinking the same thing this morning!

fixed. :)


findWithoutFail with withTrashed()

Hi
I'm trying to achieve something like this:
$menu = $this->menuRepository->withTrashed()->findWithoutFail($id);

But I cannot make it work.
Any ideas?
Thanks!

@dhcmega with new laravel 5.8 release, it should be possible as we have removed the dependency of prettus/l5-repository and base repository file is generated and published to code, so you can override all the CRUD functions as per your need. Check detailed post here.

This is the base repository published to app/Repositories folder, you can override find method into your MenuRepository.php file put withTrashed code there. Even you can do same for all method as well.
If it's global then you can do it directly in BaseRepository.php as well.


Correcting the endpoint URI link format to match the latest changes i…

…n Azure
Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type
What kind of change does this Pull Request introduce?
Corrects the placeholder for endpoint

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test
Run the python script with the suggested endpoint changes and check if the KB is created for your Azure QnA resource in Azure portal
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Check if the KB is created for your QnA resource
Other Information

@RohitMungi-MSFT Why are you going back to using a region name? Did someone from PG ask for this? It is against guidance from @ChrisHMSFT and central platform team. #hold-off

@diberry Thanks for the clarification. I was aware of the guidance from the team. In this case we can use the resource name <your-resource-name>.cognitiveservices.azure.com instead of <your-resource-name>.api.cognitive.microsoft.com as the latter does not work.

@RohitMungi-MSFT The domain is incorrect. That changes isn't in the PR. Were you intending to make that change?

@diberry Sorry for the typo in my earlier comment. I was actually not aware about the guidance from the PG. I will go ahead and raise a new PR to ensure the host is set to the following.
host = '<your-resource-name>.cognitiveservices.azure.com'


because of aws s3 buckets signed url images are not visible into gallery

this.galleryImages = [
{
small:"https://sal-ajp-intranet-dev.s3.ap-southeast-1.amazonaws.com/gallery/images/original/originalrzevqfvfio3389dk12berl005663maxresdefault.jpg?X-Amz-Security-Token=FQoDYXdzEBgaDHHdgrLZoFCfvDW4wiLBA22uAx1oBj7uyAu6BlECYCCo1GHMQ0ZX7XrKle8%2BExM4xUDekp6S13BA6St03rU67A6UddGIoLQEn1W4Pdn4N9kuWefyaRSD5ANlqkSJGi1c10SH1Wn66G2hjh8jVKdSVNdHvgClgXWGproheBw9QTxdEUdgefiuFGd6eo30OvNf8DAMpjaeeVcO0SIhALN8i2%2BibnWVu%2Fm1sRLqkFR%2Fn2NVJRMdAnYrmDj1QZDktujvo3tendlcT9%2BgeCiskM%2BdL9UTy7K524izW4%2FERK0yOqu2BY9hLXprbpftXz09b3Ha9L8%2FdutVV6%2FpcuaTjSPPRVh5%2FtlCiyO9BouI%2Bb1DmsVW8RQiCI2t3qVHL%2FWzJxkdZTY90K9sYWy%2B%2FL8GSMMomlFdlOO5jElBxNyj%2BnJhZjftp5wzI%2FfzNvHs%2BH1KxgEtUmL8JjYQnnPg4erZF7h4Kp9wNRanpLvCbsQ1jcBj01mwgBdMOHqInW9ylcl%2FXZlgEeFl%2FECKJ1mED%2Fu8RtvIHeTll5Nv4hWbhLScWWA7ibGANvLqaMi48%2FS8Ag8%2BUbFiSYW3EuEtXRABTbEJCdlLV%2FObSJN2br4YWURLyYMW8ccnKIuW1tAF&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20171122T151402Z&X-Amz-SignedHeaders=host&X-Amz-Expires=7199&X-Amz-Credential=ASIAJFDTDJCYPDXOROGQ%2F20171122%2Fap-southeast-1%2Fs3%2Faws4_request&X-Amz-Signature=e6b0b1237e90021dbcba7a6864139d347dd6273be3339b909aa96f6a46775779",
medium: 'assets/images/1.jpg',
big: 'assets/images/1.jpg',
description: "Image 1"
}]

Hi @santosh-more, which version do you use? Version 3.1.3 had a bug, but 3.1.4 works ok, example https://plnkr.co/edit/zGFwPs8SAVRzDoGGW24R?p=preview

I was using this version "ngx-gallery": "^3.1.3",
Ok man thats why I was facing the issue.
@lukasz-galka thanks a lot i'll check it and let you know.
Thanks once again

@lukasz-galka Thanks it works.


Update Java for format 2.4.0 changes

Reporter: Ryan Blue / @rdblue
Assignee: Ryan Blue / @rdblue
Related issues:

Release Parquet format 2.4.0 (is blocked by)

PRs and other links:

GitHub Pull Request #430
PR #430

Note: This issue was originally created as PARQUET-1143. Please see the migration documentation for further details.

Mark Marsh:
I'm also happy to test release candidates against my use case if it will help getting 1.10.0 out.
I'm currently developing against the master branch but it will be problematic to push that through QA...

Dongjoon Hyun / @dongjoon-hyun:
Hi, @rdblue. Could you set the Fix Version, please?

Yuming Wang / @wangyum:
@rdblue Should we update the Fix Version/s?

Ryan Blue / @rdblue:
Merged PR #430.


Add workflow to publish on PyPI

Scope of the pull request
The PR adds a workflow to publish on PyPI when a new release is published. In case of pre-release, the publishing occurs on TestPyPI. The workflow requires the definition of TEST_PYPI_API_TOKEN and PYPI_API_TOKEN secrets.
Solved issues
None
Added issues
None
Tests

[x] I manually tested
[ ] I added unit test
[ ] I ran the existing unit test and they do not fail

FYI, https://test.pypi.org/project/spid-compliant-certificates


Note functionality has been implemented you can now send a note to the API

WIP : Delete the note, error handler,

I might add this is highly experimental, any idea to optimize it is welcome !

Forgot to remove test account credentials my bad :/


Refactor the code

to remove one unused import
to add the label to mute the styling warning of the Crossfade

@simona-anomis just a gentle ping: if this pull request makes any sense, can you please give a review :)? Thanks~


⚠ Bofrost.be has degraded performance

In df4a9be, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1389 ms

Resolved: Bofrost.be performance has improved in bcf10ce after 13 minutes.


feat: add support to upload tshark to s3

Overview
Closes https://github.com/celestiaorg/knuu/issues/378

Summary by CodeRabbit

New Features

Introduced a test function to set up a test environment using the knuu package, configure Docker settings, enable Tshark collector, and execute commands.
Added functionality for handling Tshark data collection.

Bug Fixes

Fixed test environment setup by ensuring proper cleanup and configuration retrieval.

Improvements

Enhanced error handling for Tshark collector instance creation and configuration.
Improved methods for managing instances, including Docker image setting, resource allocation, and environment variable setup.

Thanks @mojtaba-esk for driving this home!


ECONNREFUSED when starting coordination tests

We have strange behaviour on CI when coordination test can't start because of ECONNREFUSED error. Looks like all devises are on the same wifi.
Logs:
https://github.com/ThaliTester/TestResults/tree/9953060646c88db_Add_listening_to_connectivity_events_when_app_starts_evabishchevich/
thali02 and thali04 devices

It seems that clients sometimes try to connect to coordination server before the server is started. Look at the timestamps from the logs above:
Coordination server start:
2016-12-28 10:52:58 - INFO HttpServer: 'listening on *:3000'

Device that didn't connect from node thali02 (it tries to connect 20 seconds before server is started):
,12-28 11:52:38.054  9061  9217 I jxcore-log: 2016-12-28 10:52:38 - INFO CoordinatedClient: 'Connecting to coordination server on http://***'
12-28 11:52:38.054  9061  9217 I jxcore-log:
,12-28 11:52:38.094  9061  9217 I jxcore-log: 2016-12-28 10:52:38 - ERROR CoordinatedClient: 'connection error: 'Error: websocket error', description: 'Error: connect ECONNREFUSED', stack: 'Transport.prototype.onError@/data/data/com.test.thalitest/files/www/jxcore/node_modules/engine.io-client/lib/transport.js:62:13

The fix is incorrect. The server waits for signal from node to start itself so the timeout for delaying node code execution is not helping. We need to prepare other solution.

Please verify server-address.js and ssid of wifi network for client.


New Labs

Hi Matt,
Hope you're well, here are the new labs Mai contacted you about. They will likely still need your eye over them, though, we have been careful to ensure the same feedback as last time was implemented.
Regards,
Elliot

:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/mr-azure-302b.md
:warning:Warning
View
Details

mixed-reality-docs/mr-azure-309.md
:warning:Warning
View
Details

mixed-reality-docs/images/AzureLabs-Lab302b-00.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-01.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-02.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-03.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-04.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-05.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-06.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-07.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-08.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-09.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-10.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-11.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-12.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-13.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-14.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-15.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-16.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-16a.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-17.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-18.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-19.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-20.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-21.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-22.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-23.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-24.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-25.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-26.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-27.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-28.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-29.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-30.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-31.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-32.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-33.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-34.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-35.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-36.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-37.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-38.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-39.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-40.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-00.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-01.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-02.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-03.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-04.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-05.png
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.

mixed-reality-docs/mr-azure-302b.md

Line 54: [Warning] Invalid file link:(~/Lab10_ComputerVision_Images.zip).

mixed-reality-docs/mr-azure-309.md

Line 0: [Warning] Text in the first line of Note/Section/Video is not valid. Will be rendererd to <blockquote>

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/images/AzureLabs-Lab302b-00.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-01.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-02.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-03.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-04.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-05.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-06.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-07.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-08.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-09.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-10.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-11.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-12.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-13.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-14.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-15.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-16.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-16a.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-17.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-18.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-19.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-20.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-21.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-22.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-23.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-24.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-25.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-26.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-27.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-28.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-29.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-30.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-31.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-32.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-33.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-34.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-35.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-36.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-37.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-38.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-39.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab302b-40.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-00.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-01.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-02.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-03.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-04.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-05.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-06.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/AzureLabs-Lab309-07.png
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Correctly serialize new CellValue(bool) (#1070)

The tests already detect that "True" and "False" are invalid, but since the actual constructor was never called (only the new CellValue(string) constructor is used) it was never actually testing this part.

Can you add a test to check this?

@twsouthwick since we are calling the constructor I can't really trigger the failed cases, but those are already handled by CellValidationTest:
        [InlineData("False", CellValues.Boolean, false)]
        [InlineData("True", CellValues.Boolean, false)]

The test does fail if it runs with the old code.

I haven't seen any test failures, though. The tests appear to be passing

/azp run


[CORS] Cors-anywhere is now in limited acces

When we use the plugin on a web environment, the proxy cors-anywhere.herokuapp.com/ is added in front of the Google Maps API link. This request returns an unauthorized error while cors-anywhere restricted their proxy.
I suggest that the proxyURL can be passed as an input or an ENV_VARIABLE.
I use
google_places_flutter: ^2.0.8
environment:
sdk: ">=2.12.0 <3.0.0"

I wrote exactly same suggestion about 2-3 months ago but they don't care I suppose. This plugin either doesn't updated or they don't care Flutter Web.
https://github.com/Shrutimahajan/Google-AutoComplete-TextField-Flutter/issues/7#issuecomment-2198373741


Fix Xcode prepare's logic to assume iOS target architecture

⚠ TODO: Verify test fails: https://github.com/flutter/flutter/pull/154589
⚠ TODO: Update SPM umbrella issue to remove the pre action test
⚠ TODO: Update this description to explain the new test.
Problem
Enabling the Swift Package Manager feature caused post-submit tests to fail on Mac x64 hosts:

Example error...
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios rrect_blur_perf_ios__timeline_summary/575/overview
♦ ... flutter --verbose assemble ... -dIosArchs=x86_64 ... profile_unpack_ios

Target profile_unpack_ios failed:
Exception: Binary ... build/ios/Profile-iphoneos/Flutter.framework/Flutter does not contain x86_64.

Running lipo -info:
Non-fat file: ... build/ios/Profile-iphoneos/Flutter.framework/Flutter is architecture: arm64

#0      UnpackIOS._thinFramework (package:flutter_tools/src/build_system/targets/ios.dart:351:7)
<asynchronous suspension>
#1      UnpackIOS.build (package:flutter_tools/src/build_system/targets/ios.dart:298:5)
<asynchronous suspension>
...

Background
As part of the Swift Package Manager project, an Xcode Scheme Pre-Action was added to unpack the Flutter framework. This ensures the Flutter framework is available before Swift Package Manager builds packages.
https://github.com/flutter/flutter/pull/150052 improved the performance of builds using Swift Package Manager:

When using SwiftPM, we use flutter assemble in an Xcode Pre-action to run the debug_unpack_macos (or profile/release) target. This target is also later used in a Run Script build phase. Depending on ARCHS build setting, the Flutter/FlutterMacOS binary is thinned. In the Run Script build phase, ARCHS is filtered to the active arch. However, in the Pre-action it doesn't always filter to the active arch. As a workaround, assume arm64 if the NATIVE_ARCH is arm, otherwise assume x86_64.

However, NATIVE_ARCH is the architecture of the host machine, not the target machine. As a result, Mac x86_64 hosts attempted to unpack the Flutter iOS framework using the x86_64 architecture when it is Arm64 only.
Solution
This updates the Xcode Pre-Action's logic: instead of using the host machine's architecture, it uses the build's SDKROOT. If the SDK root isn't a simulator, the pre-action assumes an Arm64 target build.
This change also adds a new ios_prepare_pre_action_test test project. This allows us to test the Xcode Scheme Pre-Action even if the Swift Package Manager feature is disabled.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

After further research, I found that the optimization is correct if build settings follow Apple's documentation. However, flutter run incorrectly sets ONLY_ACTIVE_ARCH=YES on x64 hosts targeting arm64 devices. Instead of switching which build settings we use to apply this optimization, I fixed flutter run to set ONLY_ARCHIVE_ARCH correctly. See: https://github.com/flutter/flutter/pull/154645


Raspberyy Pi 4 setup

Raspberry Pi Imager Installation Guide
Issue 1
In the initial step of downloading and installing Raspberry Pi Imager, keep in mind that it can be installed on both Windows and Ubuntu.
Ubuntu Installation
To install on Ubuntu, open a Terminal window and type the following command:
 sudo apt install rpi-imager
Windows Installation
For Windows users, download Raspberry Pi Imager directly using this link.
OS Selection
After installation, specify that in the "CHOOSE OS" section that the user should select the following options:

Raspberry Pi OS (other)

Raspberry Pi OS Lite (64-bit)

Issue 2
Extra setting
In the additional settings, ensure that SSH is enabled and configure the username, password, and the Wi-Fi network to which the Raspberry Pi 4 will be connected.

Finally, it is important to note that in order to establish an SSH connection, the user will need to provide the username, password, and IP address of the Raspberry Pi.
 ssh <username>@<IP raspberry>
Issue 3
Docker
During the installation of Docker, an error occurs with the following command.
sudo usermod -aG docker raspi
The correct approach is to use the username that was used during the Raspberry Pi configuration in the extra settings.
sudo usermod -aG docker <username>

Thanks for the suggestions. This PR adds the changes: #6


[runtime] Update CMake to use TARGET_SDKS (NFC)

The add_swift_library CMake function takes an optional TARGET_SDKS parameter. When used, only CMake targets for the specified SDKs are added.
Refactor stdlib/public/runtime to use this parameter. This also eliminates logic that determines additional flags or source files to include based on SWIFT_HOST_VARIANT, which makes it easier for hosts to add targets for different platforms.
This pull request was split out of https://github.com/apple/swift/pull/4972, which addresses SR-1362.

@swift-ci Please clean test

@gottesmm Looks like a clean test worked just fine here. Good to merge?

Looking now

LGTM!


Editor: Fix Jumping Cursor

:heart: Thank you for your contribution!
Description

Closes https://github.com/inveniosoftware/invenio-app-rdm/issues/2730
See https://www.tiny.cloud/docs/tinymce/6/react-ref/#initialvalue
Add the missing onEditorChange and initialValue props.
There was ambiguity between value and initialValue in the props consumption; this change also fixes that.
I intentionally kept the prop value={inputValue} as value={value} seems to conflict with the requests package.

Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

[ ] I'm aware of the code of conduct.
[ ] I've created logical separate commits and followed the commit message format.
[ ] I've added relevant test cases.
[ ] I've added relevant documentation.
[ ] I've marked translation strings.
[ ] I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
[ ] I've NOT included third-party code (copy/pasted source code or new dependencies).

If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

[ ] I've followed the CSS/JS and React guidelines.
[ ] I've followed the web accessibility guidelines.
[ ] I've followed the user interface guidelines.

Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

You license your contribution under the same terms as the current repository’s license.
You agree that you have the right to license your contribution under the current repository’s license.

LGTM!
I have only one concern, did you manage to check if any other usage (other than the subsequent PR in invenio-request solves) is affected by this change?


Not on same device error

I am doing some ablation study by trying to use VSD guidance in dreamfusion-sd. However there is a bunch of "not on the same device" error. These errors are not there if I use prolificdreamer instead.

Hi, @yankeesong. Could you please provide further information about this error, such as where it occurs, and details about your running environment?

Hi, @DSaurus,
I am running on a Linux PPc64le cluster, in my own conda environment with python=3.10, cuda=11.4, pytorch=1.12.1.
I am running the following (modified) config:
name: "dreamfusion-sd-test"
tag: "${rmspace:${system.prompt_processor.prompt},_}"
exp_root_dir: "outputs"
seed: 0

data_type: "random-camera-datamodule"
data:
  batch_size: 1
  width: 64
  height: 64
  camera_distance_range: [1.5, 2.0]
  fovy_range: [40, 70]
  elevation_range: [-10, 90]
  #light_sample_strategy: "dreamfusion"
  eval_camera_distance: 2.0
  eval_fovy_deg: 70.

system_type: "dreamfusion-system"
system:
  geometry_type: "implicit-volume"
  geometry:
    radius: 2.0
    normal_type: "analytic"

    # the density initialization proposed in the DreamFusion paper
    # does not work very well
    # density_bias: "blob_dreamfusion"
    # density_activation: exp
    # density_blob_scale: 5.
    # density_blob_std: 0.2

    # use Magic3D density initialization instead
    density_bias: "blob_magic3d"
    density_activation: softplus
    density_blob_scale: 10.
    density_blob_std: 0.5

    pos_encoding_config:
      otype: HashGrid
      n_levels: 16
      n_features_per_level: 2
      log2_hashmap_size: 19
      base_resolution: 16
      per_level_scale: 1.447269237440378 # max resolution 4096

  material_type: "no-material"
  material:
    n_output_dims: 3
    color_activation: sigmoid

  background_type: "neural-environment-map-background"
  background:
    color_activation: sigmoid

  renderer_type: "nerf-volume-renderer"
  renderer:
    radius: ${system.geometry.radius}
    num_samples_per_ray: 512

  prompt_processor_type: "stable-diffusion-prompt-processor"
  prompt_processor:
    pretrained_model_name_or_path: "stabilityai/stable-diffusion-2-1-base"
    prompt: ???

  guidance_type: "stable-diffusion-vsd-guidance"
  guidance:
    pretrained_model_name_or_path: "stabilityai/stable-diffusion-2-1-base"
    pretrained_model_name_or_path_lora: "stabilityai/stable-diffusion-2-1"
    guidance_scale: 7.5
    min_step_percent: 0.02
    max_step_percent: 0.98

  loggers:
    wandb:
      enable: false
      project: 'threestudio'
      name: None

  loss:
    lambda_vsd: 1.
    lambda_lora: 1.
    lambda_orient: [0, 10., 1000., 5000]
    lambda_sparsity: 1.
    lambda_opaque: 0.
  optimizer:
    name: Adam
    args:
      lr: 0.01
      betas: [0.9, 0.99]
      eps: 1.e-15
    params:
      geometry.encoding:
        lr: 0.01
      geometry.density_network:
        lr: 0.001
      geometry.feature_network:
        lr: 0.001

trainer:
  max_steps: 10000
  log_every_n_steps: 1
  num_sanity_val_steps: 0
  val_check_interval: 200
  enable_progress_bar: true
  precision: 16-mixed

checkpoint:
  save_last: true # save at each validation time
  save_top_k: -1
  every_n_train_steps: ${trainer.max_steps}

The first error happens here:
self.camera_embedding = ToWeightsDType(
            TimestepEmbedding(16, 1280).to(self.device), self.weights_dtype
        )

but it can be resolved by sending to self.device (which I already did)
The next error happens here:
noise_pred_est = self.forward_unet(
                self.unet_lora,
                latent_model_input,
                torch.cat([t] * 2),
                encoder_hidden_states=text_embeddings,
                class_labels=torch.cat(
                    [
                        camera_condition.view(B, -1),
                        torch.zeros_like(camera_condition.view(B, -1)),
                    ],
                    dim=0,
                ),
                cross_attention_kwargs={"scale": 1.0},
            )

with the following (truncated) error message:
│ /nobackup/users/yankeson/miniconda3/envs/DL/lib/python3.10/site-packages/torch/nn/modules/linear │
│ .py:114 in forward                                                                               │
│                                                                                │
│   111 │   │   │   init.uniform_(self.bias, -bound, bound)                                        │
│   112 │                                                                                │
│   113 │   def forward(self, input: Tensor) -> Tensor:                                            │
│ ❱ 114 │   │   return F.linear(input, self.weight, self.bias)                                     │
│   115 │                                                                                │
│   116 │   def extra_repr(self) -> str:                                                           │
│   117 │   │   return 'in_features={}, out_features={}, bias={}'.format(                          │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu! (when checking argument for argument mat2 in method
wrapper_mm)

I did check that all arguments in forward_unet are indeed on cuda, so I couldn't figure out why there's still error.
If it doesn't happen on other environments I don't want to bother you too much, but thanks though!

Will this happen using the default configurations?

No. It works for both default configurations for dreamfusion and prolificdreamer. I was just trying to test whether VSD can be conveniently applied to other systems.

Have you checked t? I remember I had the problem once too.

Sorry for the late reply. I ran your config and also encountered the problem. I dived into it and found that it is because both camera_embedding and lora_attn_procs are initialized on cpu. In addition, dreamfusion-system initialized the guidance and prompt_processor in the on_fit_start hook rather than in the system's configure method. So the pytorch-lightning will not move all the modules in the system onto GPU and you got the "not on the same device" error.
A quick fix is to move the construction of guidance and prompt_processor to configure method in dreamfusion.py. We will consider moving them or adding some manual device allocation in future updates.
Also, your config still cannot run because you need a material that includes normal to apply orient loss. So you may want to set  lambda_orient to 0 or switch to another material, e.g. the default one for dreamfusion: diffuse-with-point-light-material. Hope it helps! Feel free to post here once you find other bugs when running your custom config.


fix: the grumpkin curve ID in the blitzar_api should be unique

Rationale for this change
There is a typo in the blitzar_api related to the SXT_CURVE_GRUMPKIN curve ID. It was the same as the SXT_CURVE_BN_254 curve ID. This has not been a problem because blitzar-rs does not support grumkin yet.
What changes are included in this PR?

The SXT_CURVE_GRUMPKIN curve ID value is updated to be unique.

Are these changes tested?
No, there are only tests for SXT_CURVE_RISTRETTO255 curve elements. Future work should include tests for the other supported curves, including grumpkin,

:tada: This PR is included in version 1.85.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


NFC: Cleanups

This PR standardizes the C formatting using clang-format, and fixes a bunch of errors flagged by buildifier. It also removes some dead code. It is a non-functional change.
I was finishing  #52 but kept mixing up formatting changes with the actual changes so I figured I'd do the cleanups first and then rebase #52 on top of this.

conflicts due to my changes in previous PR. sorry :)

No worries, it wasn't hard to merge.


Resource artrifactory_ldap_setting forcing user_dn_pattern

Describe the bug
I try to define a LDAP setting like the one I configure in the UI.
But the provider forces us to give a user_dn_pattern which is not the case in the UI.
With no user_dn_pattern or with an empty string I've got an error.
resource "artifactory_ldap_setting" "ldap_server" {
  key = "ldap_server"
  enabled = true
  ldap_url = "ldap://ldapserver:389/dc=mycorp,dc=com"
  user_dn_pattern = ""
  email_attribute = "mail"
  auto_create_user = false
  ldap_poisoning_protection = true
  allow_user_to_access_profile = false
  paging_support_enabled = true
  search_filter = "(cn={0})"
  search_base = ""
  search_sub_tree = true
  manager_dn = "cn=artifactory,dc=mycorp,dc=com"
  manager_password = "xxx"
}

Error :
$ terraform plan
╷
│ Error: expected "user_dn_pattern" to not be an empty string, got
│
│   with artifactory_ldap_setting.ldap_server,
│   on ldap.tf line 5, in resource "artifactory_ldap_setting" "ldap_server":
│    5:   user_dn_pattern = ""
│

Artifactory version : 7.33.12
Artifactory TF Provider version : 2.22.0
Terraform version : 1.0.5
The fragment of system configiration for this ldap is :
<ldapSetting>
  <key>ldap_server</key>
  <enabled>true</enabled>
  <ldapUrl>ldap://ldapserver:389/dc=mycorp,dc=com</ldapUrl>
  <userDnPattern/>
  <search>
    <searchFilter>cn={0}</searchFilter>
    <searchBase/>
    <searchSubTree>true</searchSubTree>
    <managerDn>cn=artifactory,dc=mycorp,dc=com</managerDn>
    <managerPassword>xxxx</managerPassword>
  </search>
  <autoCreateUser>false</autoCreateUser>
  <emailAttribute>mail</emailAttribute>
  <ldapPoisoningProtection>true</ldapPoisoningProtection>
  <allowUserToAccessProfile>false</allowUserToAccessProfile>
  <pagingSupportEnabled>true</pagingSupportEnabled>
</ldapSetting>

Requirements for and issue

[X] A fully functioning terraform snippet that can be copy&pasted (no outside files or ENV vars unless that's part of the issue)
[X] Your version of artifactory (you can curl it at $host/artifactory/api/system/version
[X] Your version of terraform

Expected behavior
Have the ability to not give a user DN Pattern like in the UI
Additional context
Thanks

hi @jcoste-orange ... Does providing "" ie: empty string input for "user_dn_pattern" field makes sense?

I have a PR which makes the "user_dn_pattern" field optional.
Provider currently enforces non-empty input and a valid ldap string.

Hi @jcoste-orange  ... I have a fix in now in master(version 2.22.2).
Details: Made "user_dn_pattern" field optional.
For a valid "artifactory_ldap_setting" resource, please specify "user_dn_pattern" and/or "search_filter" with non-empty and valid value.
Note: empty value to "user_dn_pattern" and "search_filter" will fail validation.

Awesome, it works like a charm. Thanks.
Yes I known that both fields "user_dn_pattern" and "search_filter" can't be empty.


Editing politics.md

Grammar and flow improvements - Yee wins

Is the "build" check stuck in a loop? I can't see it performing any checks in the Checks tab above.

@Rascalov right now the workflow is configured to run the build on opening and reopening a pr
if you want to run the build close the pr and reopen again

@Rascalov right now the workflow is configured to run the build on opening and reopening a pr
if you want to run the build close the pr and reopen again

That makes sense, thank you.

Merged a larger pull request earlier, conflicts need resolution.


Constructing Texture/Font fails due to read-only fields

Examples like models/skybox and text/font_sdf can't be ported yet due to read-only *Count fields in Texture/Font. Either remove them and directly export the fields or create types TextureBase/FontBase that are public but Texture/Font are distinct.

related #6

actually everything in Texture is public and Font has a fromData constructor now. Closing.

Another idea is to make Texture2D distinct with field procs and a converter from Texture->Texture2D Leaving TextureCubemap an alias to Texture.

bad idea.


Beginning updates for policy sync

Description
[Describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] New functionality has been documented in CHANGELOG.MD

Danger has errored
[!] Invalid Dangerfile file: Please add a changelog. Updating the Danger gem might fix the issue. Your Danger version: 5.6.2, latest Danger version: 5.6.4
 #  from Dangerfile:10
 #  -------------------------------------------
 #  if (has_app_changes.length != 0) && no_changelog_entry
 >    raise "Please add a changelog"
 #  end
 #  -------------------------------------------

  Generated by :no_entry_sign: Danger


Fixes the misuse/mixuse of time.time()/time.monotonic()

I have noticed that there's some mixuse of time.time() and time.monotonic(), however, these two function cannot be used to subtract to compute the duration, e.g., self.metrics.time_in_queue = time - self.metrics.arrival_time.
The time.time() is preferred as it denotes the timepoint of events, e.g., arrive, scheduled, and finished.
After this PR, only the StatLogger uses time.monotonic() to decide when to print a log message.

The clock is not affected by system clock updates. The reference point of the returned value is undefined, so that only the difference between the results of two calls is valid.

I thought the point of monotonic clock is they can be used to compute time deltas?

We currently have:
@dataclass
class RequestMetrics:
    """Metrics associated with a request.

    Args:
        arrival_time: The time when the request arrived.
        first_scheduled_time: The time when the request was first scheduled.
        first_token_time: The time when the first token was generated.
        time_in_queue: The time the request spent in the queue.
        finished_time: The time when the request was finished.
    """
    arrival_time: float
    last_token_time: float
    first_scheduled_time: Optional[float]
    first_token_time: Optional[float]
    time_in_queue: Optional[float]
    finished_time: Optional[float] = None

I thought the point of monotonic clock is they can be used to compute time deltas?

Yes, monotonic clock is better for compute time deltas like time_in_queue (as well as in SequenceGroup.get_last_latency()), but intuitively it would to better to let user pass the epoch time (time.time() as arrive time when adding requests, and record epoch time for scheded, finished time as metrics (as the metrics may be further processed).
Should we add new fields like arrive_timepoint, last_token_timepoint for delta computation? Ideally monotonic clocks should only be used internally, and user APIs it is better to have epoch time arguments/properties/results. How do you folks think about that?

As an enhancement, you could also imagine adding an arrival_time_monotonic field in the future based on time.monotonic(), which could serve as a reference point for latency-oriented fields like time_in_queue.

Thanks for the comment!


toggle option in main menu mod panel does not respond visually

In the main menu mod option panel, the "toggle UUI button" option does not change its visual state when clicking. Only the visual feedback is broken, it toggles on click.
This broken behaviour does not happen at the ingame mod option panel, when a map is loaded.

fixed in #8


Add gitattributes to avoid merge conflicts associated with CHANGELOG

Upon merging a single merge request, all other unmerged PRs immediately have merge conflicts because of CHANGELOG.md. What I propose is to add .gitattributes file with CHANGELOG merge=union line inside. Instead of leaving conflicts the union merge option will resolve conflicts favouring both side of the lines.

👍


Cannot receive files from Android devices.

Hi, there.
I noticed that it seems unable to receive files from Android devices. The Mac is detected on the quick share screen on Android, however, it takes forever to connect and will end up failed.
The mac is on Sequoia 15.1, and Android devices on A14.

Yes, i install the app and this happens.

Please check that NearDrop is allowed to send notifications and that you don't have the "do not disturb" mode active.


skiff/core: use an init process for pid 0

https://github.com/krallin/tini
The --init option on docker run will start the container with PID 0 using the docker-init executable in the system path.

Working on adding docker-init to every container now.

Solved.


Dispose of Unnecessary OVERLAPPING Pragmas and Deprecated OverlappingInstances Extension

By the way, is it my setup or are the tests broken?

Hey, thanks for the PR. The tests pass for me locally but seem to be broken on Travis. Not sure why, I've been doing some work on master recently. You need to have npm installed for them to work.
I'm of two minds about this--I like how this avoids the need for OVERLAPPABLE/OVERLAPPING, but I'm not sure it's worth cluttering the core typeclass with getListTypeScriptType/getListParentTypes. Given the choice between the two I'd probably choose the abstruseness of the former over the complexity of the latter. Were the pragmas causing problems for you somehow?

@prednaz friendly ping on my question about the pragmas. I'm still not quite sure what to do about this PR -- I might rebase it on #17 after that lands but I wanted to better understand your reasoning for getting rid of the pragmas. Thanks!

The main thing is getting rid of OverlappingInstances, which is deprecated. the OVERLAPPABLE pragmas should be safe enough.

@hasufell well as the comment in the file mentions, OverlappingInstances is there only to support older GHCs (like <7.8.4). Maybe we can just drop support for those.

@thomasjm , I am very sorry for having kept you waiting. No, the pragmas were not causing me any problems. I opened the pull request just to demonstrate to me and a colleague that in some situations it is possible to avoid overlapping instances completely and to discuss the options.
I, myself, think that the option this pull request puts forward composes poorly because it requires changing the class in order to define instances which a library user could not do. On the other hand, overlapping instances entails a few dangers. One example is the incoherent behavior described in the warning section at the bottom of https://downloads.haskell.org/ghc/latest/docs/html/users_guide/glasgow_exts.html#instance-overlap . But as far as I can see, users of your library could never trigger and observe this one. But I have not looked very closely.

Thanks @prednaz ! From what I can tell, the warning you reference applies only to OverlappingInstances and not to the newer OVERLAPPING pragmas. So, it seems like all we really need to do is remove/contain the deprecated pragma. I'm thinking one of the following solutions:

Just get rid of OverlappingInstances and drop support for the older GHCs that need it.
Gate the OverlappingInstances pragma behind a CPP #if check so it's only active for said GHCs. I've never tried to gate a pragma before but it should work.
Land this PR after rebasing on #17 (which I'd like to land more urgently).

I'm leaning toward 1) or 2) but I'll revisit this after the other PR + a little research on what newer GHC adoption looks like.

From what I can tell, the warning you reference applies only to OverlappingInstances and not to the newer OVERLAPPING pragmas.

It applies to the pragmas too. Almost all dangers of OverlappingInstances apply to the pragmas too because they are strictly more powerful.
I personally do not think, using a deprecated feature is worse than losing the support of older GHC versions. But that is clearly your decision.


Update IFSC.json

Added IFSC SBIN0019101
Note :- Please follow the below points while attaching test cases document link below:
- If label Tested is added then test cases document URL is mandatory.
- Link added should be a valid URL and accessible throughout the org.
- If the branch name contains hotfix / revert by default the BVT workflow check will pass.

Test Case Document URL

Please paste test case document link here....

Added IFSC SBIN0019101


Additional Windows functions

Will be nice to have a button in the title bars like Chamaleon app and have this option list on right click app on task bar:

And some extra functions like:

Minimize to try
Transparency (0 to 100)
Trim windows (like OBS with Alt)

Hi @abealpha please open an issue and not a PR for feature requests.