Add optional broadcasting to kernel generator

Summary
Added optional broadcasting to kernel generator. It broadcasts the argument in specified dimmensionif it can be broadcasted. That is if size in that dimension equals 1. If not nothing is broadcasted.
Tests
Added tests for optional broadcasting.
Side Effects
None.
Release notes
Added optional broadcasting to kernel generator.
Checklist

[x] Math issue #1342

[x] Copyright holder: Tadej Ciglarič
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

I think I'm kind of confused on the usecase of this. Are there places where we won't know until runtime whether something should be broadcast? Feels a little dangerous. Is there an eigen equivalent to this?

There is no EIgen equivalent. But we are doing exactley this in existing GLM kernels for broadcasting of y, as we do not get any compile-time info on whether y is scalar or vector.

Alternatively we could add compile-time dimmensions to matrix_cl. Although I am not sure it those would be benefitial in any other case.

Alternatively we could add compile-time dimensions to matrix_cl. Although I am not sure if those would be benefitial in any other case.

Let me think about this for a teeny bit. imo I like that idea and it lines our API up with what Eigen does anyway. We could keep everything backwards compatible by setting the compile time rows to dynamic by default

Okay I actually like the row/col declaration as part of the template for matrix_cl. We can make it backwards compatible with
template <typename T, size_t RowsAtCompileTime = -1, size_t ColsAtCompileTime = -1, typename = void>
class matrix_cl { //...

Fine. I think to actually use this in GLMs we will need also a change in the compiler to create row matrix_cl objects.

Actually we should not need any backward compatibility. If we go into this we must make all GPU code support it and also return appropriate values. This would be a lot of work for little benefit.

idt it would be that much would it? I think it would be

Add the templates
Check the templates match up for the constructor called
Look through the functions and setup the rows/cols at compile time when appropriate

Everything by default can have -1, -1 and wouldn't get an optimization which is fine. Then for things like transpose, mul, the glm methods, etc. we would do the compile time rows and cols stuff

Everything by default can have -1, -1 and wouldn't get an optimization which is fine.

Nope. Its not just about optimizations. If we do things like that some things can only be done if a compile time dimension is 1 - like that example of GLMs broadcasting. So all the functions must return correct compile time dimensions.

@SteveBronder Do you still insist on adding compile time dimensions to matrix_cl? I would really prefere to avoid modifying all OpenCL code.

@SteveBronder Do you still insist on adding compile time dimensions to matrix_cl? I would really prefere to avoid modifying all OpenCL code.

Let me give this a shot this weekend and if it's way too much then we won't do it

I got the basic API up, though it still just assumes everything is -1, -1 defined. Ran into a few issues when working with matrices of different compile time sizes and local scoped data I need to sort out
https://github.com/stan-dev/math/tree/feature/opencl-compilesizes

I quickly looked over what you did. Looks fine, but that is only the first part. All other GPU functioins would need to be modified too. That would also make those functions accept templated matrices. This prevents automatic evaluations of kernel generator expressions. To make this work again we would need to generalize all these functions to accept expressions. This means we need a set of requires for working with matrix_cl.
Can we instead add optional broadcasting? If you get trough all this we can easily remove it later.

Okay yeah that's fine I'll review this today

Just posting to make sure this wait for after the feature freeze ends which should be later today.


Hot reloading takes too much time

Hot reloading takes too much time. When i change any file on server it takes two or three minutes to reload the content and start server again

Same here, already tried some isomorphic webpack packages to transpile seperately but couldn't succeed yet.

@mattlubner I suspect with the udpated webpack we don't have this issue anymore, did you see differently?

This strikes me as a possible duplicate of #153 ?

@mattlubner yes it is...closing


NullPointerException after plugin upgrade to v1.23.0

Describe the bug
java.lang.NullPointerException encountered after upgrading PyCharm plugin to v1.23.0.
To Reproduce
Code or Steps to reproduce the behavior:

Have previously installed older version of PS plugin (I presume the most recent prior version, but can't be 100% sure)
In PyCharm UI, accept prompt to upgrade plugin in notification balloon
Restart PyCharm
Open IDE fatal error dialogue box
See error (noted below)

Expected behavior
Expected plugin to upgrade w/out NPE
Screenshots
java.lang.NullPointerException: this.javaClass.classLoad…y-db/insecure_full.json") must not be null 	at security.packaging.SafetyDbChecker.<init>(SafetyDbChecker.kt:35) 	at security.packaging.PyPackageSecurityScan.checkPackages(PyPackageSecurityScan.kt:30) 	at security.packaging.PythonPackageVulnerabilityStartupTask$runActivity$1.run(PythonPackageVulnerabilityStartupTask.kt:16) 	at com.intellij.openapi.progress.impl.CoreProgressManager$TaskRunnable.run(CoreProgressManager.java:962) 	at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcessWithProgressAsync$5(CoreProgressManager.java:472) 	at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$3(ProgressRunner.java:235) 	at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$2(CoreProgressManager.java:178) 	at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:658) 	at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:610) 	at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:65) 	at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:165) 	at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$4(ProgressRunner.java:235) 	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700) 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) 	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:668) 	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:665) 	at java.base/java.security.AccessController.doPrivileged(Native Method) 	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:665) 	at java.base/java.lang.Thread.run(Thread.java:834)
Additional context

Plugin Version: 1.23.0
PyCharm Version (or IDE version): PyCharm 2020.3.1 (Professional Edition)
Build #PY-203.6682.86, built on December 23, 2020
Runtime version: <IP_ADDRESS>+11-b1145.37 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 10.14.6
GC: ParNew, ConcurrentMarkSweep
Memory: 1981M
Cores: 8
Python Version: 3.7

Same for me. How can I revert to previous version?

Oh no! Sorry about that. I've requested it to be removed from the Jetbrains store. You can revert back to a previous version in the plugin manager

Just shipped a fixed version. It should be out on the jetbrains marketplace.
I'd somehow removed the SafetyDB files from the package before publishing it.

Confirmed no NPE encountered upgrading to v1.23.1. Thanks for the quick fix!


Shutdown containers on isolated nodes

I apologize in advance if this issue is misplaced or a duplicate but I could wholeheartedly not find anything that relates to my description.
In the scenario a manager or worker gets isolated from the swarm due to network partition or similar there's is no way for the operator to configure what the desired outcome would be of such a failure.
The observed behavior right now is that services continue to run on the isolated nodes. We need an option to immediately shutdown the containers running on the isolated node after a grace period.
In my experiments it's quite trivial to corrupt Docker Volumes that is being served by a shared filesystem as whatever workload was running on the isolated node gets rescheduled on the Swarm.
There are of course ways to invent application level locking and fencing to prevent corruption but I would find it more convenient to disqualify isolated nodes that can't witness quorum in the Swarm to simply relinquish their services.
In most scenarios it would be desirable to keep running the service on the isolated node if it's just running an ephemeral service. Hence it would be desirable to have an option at service creation what to expect during isolation and keeping the default as-is.
Proposal:
--during-isolation    In the event of a node loosing visibility of the quorum, the service should (stop|continue) (default continue)

/cc @dongluochen @aaronlehmann
Hey @drajen, sorry for the slow response but we mostly check issues on docker/docker rather than here.
We'll look into it!

First thing that pops to mind is it's tough to know whether we're in a partition or the manager is simply down.
If the latter, with this proposal we'd kill all tasks in the cluster and affect perfectly good services.
Regarding volumes, I would have hoped that it'd be the storage responsibility. For instance when using EBS, if the volume is attached to a new container then it's forcefully detached from the other one if still running.
Also, even with this solution there will be race conditions. It might take more time to the worker than for the manager that we're in a partition. Until the worker converges and shuts down the tasks, there will be two of them running at the same time anyway, leading to the corruptions you mentioned
We'll tinker a bit more with the idea

I agree with @aluzzardi that we need to consider different scenarios. As cluster manager, Swarm can provide feedback on node reachabilities. But the logic to deal with the failure may be decided by system administrators, not Swarm.
A network partition case can affect a large part of your infrastructure. Managers can be not responding due to upgrade, bug, or attack. If an automatic evacuation is implemented, it may cause large scale service failure.
It's better to have a centralized control on infrastructure failure. When a node is unreachable, Swarm manager detects it and sends an event to an external controller. External controller may issue a repair on the failing machine, like system reboot. If external controller gets a large amount of machine failure, it should trigger alerts to infrastructure.

Thank you for looking into this. The current behavior, with the volume driver I'm working with, we're fencing the isolated node from the volume when a manager reschedules the container and mounts the volume elsewhere. It works. My desire is that we could be more graceful about it as the isolated node should understand it's isolated from the quorum and should shutdown the containers cleanly. That way the surviving managers could reschedule the container and mount the volume with a clean filesystem.
I've also done some more testing in my environment and swarm is very quick to judge and declare nodes dead in around 5 seconds and immediately try to fulfill the replica set on the service. It would be ideal if this heartbeat could have an extended grace period set per service.
If possible at all I want to propose these changes as options to not break the current behavior. I genuinely think that services that have volumes mounted should be treated differently and it should be a recommendation from the 3rd party storage vendor to suggest what these grace periods and isolation behaviors should look like.

It would be ideal if this heartbeat could have an extended grace period set per service.

Heartbeat is between the worker node and a manager which is not related to service. Do you want to add a per-service configurable delay to the rescheduling of the task?

Heartbeat is between the worker node and a manager which is not related to service. Do you want to add a per-service configurable delay to the rescheduling of the task?

I think there's separate needs for stateless containers and containers that carry persistence in volumes, therefor, having a grace period per service could be one solution. Another way to do it is to delay the mount if the volume driver is made aware that an unclean mount is in progress and could simply sit for grace period before attempting the mount. Then it would be up to the volume driver to determine its grace period if one is needed and it's intelligent enough to understand it's taking over a dirty mount. I can solve that on my end. I can't solve shutting down services cleanly on an isolated node though.

Another way to do it is to delay the mount if the volume driver is made aware that an unclean mount is in progress and could simply sit for grace period before attempting the mount.

I think this is best practice
"If the same volume_name is requested more than once, the plugin may need to keep track of each new mount request and provision at the first mount request and deprovision at the last corresponding unmount request."

I can't solve shutting down services cleanly on an isolated node though.

This PR https://github.com/docker/swarmkit/pull/1758 tries to remove the tasks on the node at swarm leave so that it can properly release networks or volume.

@drajen Could you clarify whether this is a test of partitioning or a planned decommissioning? If this is a planned decommissioning, you could drain the node before switching over or scale the service to 0. If this is a failure test, the behavior is more complicated.
It sounds like many of the problems here are arising from broken volume drivers. Upon having the second mount issued, the volume driver should either reject the mount or steal the mount away from the other party if having multiple parties write to same disk will result in corruption.
If the volume driver was working correctly, the service would run on the isolated node until a forceful unmount, which would likely cause the process to fail. When mounting the volume on the new task, this may cost a small recovery period but the new process should proceed just fine.
When it comes down to it, we can't actually guarantee a shutdown of services when there is a partition without sacrificing availability of a service. Even if consistency is favored here, there is no guarantee that the node will detect the partition and shutdown the service properly. There may be ways to make this less impactful, but this is a property of the problem. Tying service availability to quorum availability is a dangerous game and may result in awful cascade failures.
That said, a field on the task, configured per service, to control whether the task should be killed on extended session loss isn't unrealistic. The only problem is that people may use without understanding that it ties service failure to quorum failure.

Thank you @stevvooe for your input and suggestions. To answer your first question, this ask is targeted against unplanned failures and we're aware of the drain feature for planned node maintenance.
The volume driver I'm working with is working correctly. If a node becomes isolated, the service will be restarted by the swarm and the last node mounting the volume will fence the volume from the origin node. There's means to panic the isolated node on hung IO to get it out of the forever hung state and have it become healthy once the network split has been remedied.
What I'm looking for are means to be more graceful about the whole ordeal as of right now swarm is very aggressive restarting services (less than 10 seconds) with an abrupt loss of IO to the isolated node. I might be chasing a unicorn here as many storage HA solutions is designed just like how Swarm operates and that's what we should accept.

@drajen Thanks for bringing me up to speed! Good to hear the volume driver is working correctly.
Indeed, this is a tough problem. For these kind of IO switchover, the volume subsystem is likely in the best position to observe the switchover and act on failing the rogue process (by ruthlessly unmounting the volume). The model here almost treats the nodes as adversarial, which requires the ability to revoke resources without the node's compliance.
I wonder if this would be better addressed through tuning node heartbeat timeout for a network partition. That would make it less sensitive to momentary blips that aren't really a full quorum loss.
Do you have a full description of the sequence of events? I feel like we are speaking very abstractly.

@stevvooe We can be very specific :-)
In my setup, currently, the swarm communicates on one of the interfaces I run iSCSI traffic on. I have two of those iSCSI interfaces. Redundancy for the storage is provided by multipathd. If I ifdown the swarm interface on one of my nodes, the workload it was serving gets restarted in less than ten seconds on another node in the swarm. The origin node is fenced and the service will hang forever waiting for IO that will never happen, even if the network comes back, the initiator will be denied access to the iSCSI target.
As background, the environments I'm designing for is Enterprise-type on-prem solutions. That said, the recommendation I'm leaning towards providing is that the network Swarm communicates on need to be redundant to help mitigate false positives. A false positive I would categorize momentarily loss of a network link due to a switch reboot or similar. In these setups, the storage network will in 99% of the cases be redundant, not necessarily on L2/L3 with MLAG/VPC or similar, but provided with multipathd across block devices seen on two separate subnets.
Now, what I want to get to, that is unrelated to this issue, how to use the Linux bonding driver to borrow virtual interfaces (veth) on the iSCSI interfaces to create the same level of redundancy that iSCSI have. Once I get there, I'm hesitant to believe that a failure of a physical network interface will failover fast and gracefully enough for the swarm to not fail the node having the intermittent link issue. Hence, having a parameter to tune the grace period would be helpful in these experiments to dial in a sane grace period, which I would feel much safer off the bat with if that was in the 30-60 second range than less than 10 which it is at the moment.
Feature creep, it would be great if you could specify multiple IP interfaces the swarm communicates on as I wouldn't need to twiddle with bonding virtual interfaces and it would be a much more visible reliability factored in by having bi-directional communication on multiple subnets.

Thanks for the details!
Out of curiosity, what is the RTT time from the iSCSI initiator to target?

Hence, having a parameter to tune the grace period would be helpful in these experiments to dial in a sane grace period, which I would feel much safer off the bat with if that was in the 30-60 second range than less than 10 which it is at the moment.

This sounds like the happiest path. It really sounds like a tuning problem, without investigating further.
We could probably do something more extensive, but it would require more thought.

Linking https://github.com/docker/swarmkit/pull/1741 to this issue. There was some discussion about general NW partition, but not about volumes.

I wonder if this would be better addressed through tuning node heartbeat timeout for a network partition.

:+1: for the volume-related issue discussed in this #1743.
However, for issues that are not about volumes,  @drajen 's proposal about --during-isolation seems still attractive and needs more thought. (I wonder it should be implemented as a new --restart-condition flag. e.g. --restart-condition on-node-heal-blah-blah-blah?)

Out of curiosity, what is the RTT time from the iSCSI initiator to target?
This is normally in the lower 100s of μsec on 10GigE networks during normal operation.

I see three possible enhancements moving forward. Listed in most desired and, from my perspective, easiest to implement order:

Tune timeout for a service before declaring it dead and fulfill the desired service replica. This will help rolling upgrades of redundant switch infrastructure and won't disrupt services with external volumes. This could be a global setting but I'd prefer it to be a non-default behavior that you could tune with a service label or such.
The --restart-condition flag, which could be a service label as well that determines what happens to a service when a node detects loss of quorum to the Swarm.
A list of listen addresses that Swarm nodes may communicate with each other to provide redundancy for the raft protocol. This will help unnecessary complex network schemes and allow lowering (or use the default) timeout expressed in bullet 1.


URLs of file names containing # are not escaped correctly

Possibly hinting at other escaping issues.
Example:
WARC/1.0
WARC-Date: 2004-11-10T16:15:13Z
WARC-Source-URI: file://waste/images/17#.jpg
WARC-Created-Date: 2018-02-06T16:26:13Z
WARC-Type: resource
WARC-Record-ID: <urn:uuid:73015799-0b5a-11e8-9ac5-5ce0c57ec2e1>
WARC-Target-URI: http://heise.de/tp/kunst/waste/images/17#.jpg
WARC-Payload-Digest: sha1:GLC3CKKQ4LSVN4FD75TBXBOOAHA6WP6N
WARC-Block-Digest: sha1:GLC3CKKQ4LSVN4FD75TBXBOOAHA6WP6N
Content-Type: image/jpeg
Content-Length: 5222

Should be:
WARC/1.0
WARC-Date: 2004-11-10T16:15:13Z
WARC-Source-URI: file://waste/images/17#.jpg
WARC-Created-Date: 2018-02-06T16:26:13Z
WARC-Type: resource
WARC-Record-ID: <urn:uuid:73015799-0b5a-11e8-9ac5-5ce0c57ec2e1>
WARC-Target-URI: http://heise.de/tp/kunst/waste/images/17%23.jpg
WARC-Payload-Digest: sha1:GLC3CKKQ4LSVN4FD75TBXBOOAHA6WP6N
WARC-Block-Digest: sha1:GLC3CKKQ4LSVN4FD75TBXBOOAHA6WP6N
Content-Type: image/jpeg
Content-Length: 5222

Fixed by https://github.com/webrecorder/warcit/pull/2


Add cuda synchronize code to measure accurate inference time.

Firstly, thank you for opening this good job.
I found an issue about measuring inference time, so submit this PR.
When you measure the inference time in the paper and KITTI benchmark, you may use the below code.
https://github.com/anglixjtu/msg_chn_wacv20/blob/0d576482982fdb6859bee2ff383c2e7fdd194cad/trainers/DepthTrainer.py#L235
However, as the cuda operations run asynchronously, we should wait for the end of the cuda operations by using torch.cuda.synchronize() to estimate the accurate inference time.
In my machine, it takes about 0.0292 sec instead of 0.01 sec.
I recommend you measuring by your machine again and correcting the time logging at the workspace directory.

Hi @jaehyuck0103, thank you very much for your suggestion! The method you provided for measuring the runtime is right and I should report the correct runtime on my machine.


"DATA" feature on macOS

Describe the solution you'd like
I'd like to be able to access the data feature of AppCenter on a macOS app.  I'm hoping to be able to use this feature to keep user specific data that I could export to AZURE along with my analytics data to provide a link between my user's experiences (via analytics) and specific data that the user has put into the appCenter data area
Describe alternatives you've considered
I could use Apple's CloudKit data layer, but this wouldn't allow the level of integration that I'm hoping for.

@stevekellogg  Thank you so much for your feedback on App Center Data. We announced yesterday in a blog post that we’re retiring the Data service later this year and recommending customers transition to Azure Cosmos DB instead. Let me know if you have any additional questions about this transition and i'll make sure to get them answered! Closing this issue.


fix: task usercred should be utf8 charset

这个 PR 实现什么功能/修复什么问题:
修正：操作日志中文项目乱码（task的userCred字符集错误导致）
是否需要 backport 到之前的 release 分支:

release/2.8.0
release/2.9.0
release/2.10.0
release/2.11.0

/area region

Codecov Report

Merging #1667 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1667      +/-   ##
=========================================
+ Coverage    7.63%   7.65%   +0.01%
=========================================
  Files         412     412
  Lines       63096   63095       -1
=========================================
+ Hits         4820    4831      +11
+ Misses      57866   57855      -11
+ Partials      410     409       -1

Flag
Coverage Δ

#aFlag
7.65% <ø> (+0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/hostman/guestfs/fsdriver/drivers.go
0% <0%> (ø)
:arrow_up:

pkg/util/rbacutils/rbac.go
73.83% <0%> (+3.42%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91fbf2...5a272fd. Read the comment docs.

/lgtm
/approve


About confidence-based Active Retrieval

Hi, nice work!
I have a question about how to get a token's probability for confidence-based active retrieval. Can it be obtained from OpenAI's api? Or do we need another white-box model to calculate this probability?

Excuse me, how to get the probability of token through text-davinci-003.
There are too many bugs, could you re-upload a code that can run successfully.

@xiami2019 Same question.

Sorry for the late reply and thanks @jacksonchen1998 for the pointers!
To be more specific, completion models (such as text-davinci-003 which is the model used in the paper) returns probabilities of generated tokens if you specify the logprobs parameter in the request.
However, chat models (such as gpt-3.5-turbo) cannot return probabilities.


XpandSystemAspNetModule : Listview column missing node in editor

I just compare a web model that use XpandSystemAspNetModule from version 19.1.402 with version 19.1.503 and notice some nodes for listview column are missing (or no longer supported??).
See picture

Is this a bug or something we need to configure?
I specially used the OptionsColumnGridView\Settings attributes and when running my app, those settings are no longer apply by the module.

probably a conflict with #516

Is it possible the modelmapper map the option on class GridViewColumn ?

Because the missing attributes comes from class GridViewDataColumn. Maybe it simply miss a mapping?

BTW the visibility on the property is "Content", so not related to #516
[Category("Behavior"), PersistenceMode(PersistenceMode.InnerProperty), DesignerSerializationVisibility(DesignerSerializationVisibility.Content), NotifyParentProperty(true)]
public GridViewDataColumnSettings Settings
{
	get { return (GridViewDataColumnSettings)ColumnAdapter.Settings; }
}

The DevExpress.XAF repository includes commits that relate to this task:

ModelMapper: Map GridViewDataColumn instead of GridViewColumn #525

Please update the related Nuget packages and test if issues is addressed. These are nightly nuget packages available only from our NugetServer.
If you do not use the Xpand.XAF.Modules directly but through a module of the main eXpandFramework project, please wait for the bot to notify you again when integration is finished or update the related packages manually.
Thanks a lot for your contribution.

Any idea when the package 19.1.603.0 will be available to test?
I just test it with 19.1.602.6 and it is still not fixed.

Some clarification, the bot notifies about the DevExpress.XAF repo meaning that is available at the lab servers and will be available on the next minor of this repro. You can however install the package from the lab servers into your module and this should work. Also you most problably need to configure your binding but the next switches can help (in your csproj)
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
    <GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>

I have update ModelMapper to version <IP_ADDRESS> on nightly and using reflector, the PredefinedMap.cs still have to old map on GridViewColumn. I should be GridViewDataColumn when I looked at the changeset.
Something broken with the package?

I am not sure what happened it looks like the ModelMapper version was not bumped from the CI. Bumping it manually and let's keep an eye to it.

However still not intergrated with eXpand packages so it won't work unless u modify the eXpand sources manually and rebuild them

The DevExpress.XAF repository includes commits that relate to this task:

ModelMapper: Map GridViewDataColumn instead of GridViewColumn #525
Bump ModelMapper #525

Please update the related Nuget packages and test if issues is addressed. These are nightly nuget packages available only from our NugetServer.
If you do not use the Xpand.XAF.Modules directly but through a module of the main eXpandFramework project, please wait for the bot to notify you again when integration is finished or update the related packages manually.
Thanks a lot for your contribution.

The DevExpress.XAF repository includes commits that relate to this task:

lab-Pipeline uses wrong artifacts #525 #545

Please update the related Nuget packages and test if issues is addressed. These are nightly nuget packages available only from our NugetServer.
If you do not use the Xpand.XAF.Modules directly but through a module of the main eXpandFramework project, please wait for the bot to notify you again when integration is finished or update the related packages manually.
Thanks a lot for your contribution.

eXpand.lab release 19.1.602.7 includes commit that relate to this task:

Bump standalone packages #471 #525

Please test if it addresses the problem. If you use nuget add our LAB NugetServer as a nuget package source in VS.
Thanks a lot for your contribution.

This issue is now fixed.


Idea: Support children after attributes using getitem

This idea is inspired by htpy which I learned of in the same HN thread I learned of ludic 😄
htpy solves the "cant have attributes before variables number of child arguments" problem by some creative use of __getitem__ and return self.
Toying around it seems like it would be quite simple to introduce this same pattern to Ludic, if there was any appetite:
https://github.com/bessey/ludic/pull/1/files
Personally I think its worth introducing this entirely optional API, unusual as it is, as it brings the syntax closer to raw HTML where attributes always come first. What are your thoughts?

Hi, thank you for the issue, first I have to say I really like this idea. For some reason, I completely missed htpy until now. It has a very similar approach.
In fact, at first, I had a very similar idea to htpy. I implemented Ludic in a way that you would create elements like this:

Link(to="https://example.com)("Click here")

I did that by overriding __call__. I like the usage of div[div(id="test")[...]] even more. However, I learned this has a few flaws:

I cannot properly type-check this since I want to be able to define what kind of children an element can have - the problem is that TChildren TypeVar must be covariant. This is the biggest issue, mypy complains about "TypeVar is covariant but used as a parameter" in the __call__ method, the same happens for __getitem__.
It makes the way of working with elements as Python objects a bit less intuitive. In case I override __getitem__, I now cannot do page[0] to get the first child or page["id"] to get the ID of the element. This behavior is currently not implemented in Ludic but I was thinking about that a lot and I think I'll implement it like that.

I think the biggest issue is the first one. If I was able to solve that somehow, I would consider implementing it like in htpy. I am also afraid that in the future, this magic way of overriding the standard behavior of the __getitem__ method could lead to more problems with type-checkers.
Thank you very much for the showcase, I was testing it again with your solution to make sure there isn't a solution for the problems I described above. Unfortunately, I couldn't make it work.
If you have more suggestions or anything, I'll gladly hear them :)

I think htpy came out literally last week so not too surprising.
Both flaws make sense to me but I am not Python typings are not my strong suit, so I don't think I'll be much help suggestions wise 😅. I'm just a Ruby-ist considering a tech stack change and learning the SOTA elsewhere.
I guess I'll CC @pelme in case there's an interest in collaboration.

I have not tried to solve type checking attributes or children and cannot really help with that.  We get a lot of value from using typed Python with our components by creating typed component wrappers(functions) that accept more narrow types. And then having mypy check all of our internal objects used to construct htpy objects is very useful.
I did not have use case for accessing the children or attributes of an element yet. Attributes and children are "private" in htpy right now but that could be changed, so maybe using element.attrs["x"] or element.children[0] would be a nice way to get them. They can be found like this now:

>>> e = div('#hi')[("a", "b")]
>>> e._attrs["id"]
'hi'
>>> e._children[0]
'a'
>>> e._children[1]
'b'

(The idea for using __getitem__/[] for HTML elements has been around some 20 years since at least nevow.stan. Looked for existing libraries but mostly found a unmaintained projects. Created htpy to explore these ideas in our company. htpy has been around for ~6 months but probably only used internally in our company. :) Published the docs the last couple of weeks to make it usable for others too. Was really happy when I read about Ludic on HN that uses the same ideas for creating HTML without templates. Will be happy to explore ideas related to this more!)

Thank you @pelme for the answer. Yeah I noticed that the first point is probably not relevant for htpy. About the second point, there is also the need to optionally specify types of Table children, e.g.:
Table[PersonHead, PersonRow](
  PersonHead("Id", "Name"),
  PersonRow("1", "Joe"),
  PersonRow("2", "Jane"),
)

But I'm not sure whether this would be possible in htpy while overriding the __getattr__ method. htpy doesn't seem to care about types of children of elements/components that much while in ludic, I want to explore this possibility a bit more - but I'm still not sure it will be that useful.
BTW I think I've been thinking about similar library for quite some time, maybe I'm a bit surprised there was never really a popular library that does this. Perhaps together with HTMX.org, combined with Python's richer type system, writing HTML in pure Python offers a viable alternative for generating HTML within Python code. But who knows if it can ever at least partially rival Jinja2's established position.

I'll close this issue for now, if there are plans to change the behavior in future, I'll open a new one.
Thank you for the discussion and feel free to open new issues or share other ideas :)


Add note on whitespace between !include and :

I think it is convenient to add a note, because I also had a problem described in:
Https://github.com/treasure-data/digdag/issues/548
Best Regards,

Looks good 👍


[8.x] Remove redundant description & localize template

Screen readers will announce the type of role the landmark is, in this case screen readers would say "Pagination Navigation Navigation" -- this PR fixes that. This should be of benefit to accessibility.
See also "Redundant descriptions" @ mdn: developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/form_role
Off-topic: I'd like to thank the maintainers of Laravel. You guys rock!

Thanks for contributing to Laravel! ❤

@taylorotwell  @xanderificnl This actually introduces a bug that breaks Tailwind pagination out of the box, and it should ideally be reverted.
When attempting to use Tailwind pagination, I'm seeing the following:
htmlspecialchars(): Argument #1 ($string) must be of type string, array given (View: /var/www/html/vendor/laravel/framework/src/Illuminate/Pagination/resources/views/tailwind.blade.php)
The line causing the issue:
<nav role="navigation" aria-label="{{ __('Pagination') }}" class="flex justify-between">

This is due to Laravel shipping with a resources/lang/en/pagination.php file by default. This PR causes the array returned by the pagination language file to be passed into the __() method, which results in the parsing exception.

I'm using this exact template in my app, and not running into this issue. I doubt this PR is causing your issue.
The line you quoted is from the simple-tailwind.blade.php and the error describes tailwind.blade.php, are you sure you're looking at the right view?
You can easily test via tinker (php artisan tinker):
❯ sail art tink
Psy Shell v0.10.12 (PHP 8.1.0 — cli) by Justin Hileman
>>> __('Pagination')
=> "Pagination"

You really shouldn't be getting an array conversion when localizing strings.

As said, I'm not running into this issue, but I did check the docs and they do agree that __('Pagination') isn't a great idea when there's pagination.php.
I'll be submitting a PR shortly to resolve this matter by adding a new translation key for pagination.

@xanderificnl I did indeed paste the change from the wrong file. I was experiencing the issue in tailwind.blade.php.
I'm really not sure why it was triggering the error for us and not for your installation. We were just running a pretty standard Laravel app using Sail for testing, and ran into the issue after updating the framework.
Thanks for taking the time to check this out and submitting an updated PR!

Hi.
I was just looking through my source and I have a file called resources/lang/en.json. Considering the documentation, that may be the reason why I haven't hit this issue.
Currently in the train w/o access to a machine besides my phone so I can't actually verify it by trying it out.
Thanks again for bringing this to my attention!
Cheers,

Xander


DX: update composer-normalize

Thank you @keradus.

Coverage remained the same at 92.847% when pulling 7bba5c7ab229b2eca43e19dff51371e65acc142b on keradus:composer_normalise into 075082e586a21fbf9faf35a2e4257f1a18ece6fe on FriendsOfPHP:master.

extra note: looks like PRs started failing on new normaliser version. Was this change expected, @localheinz ?

@keradus
Apologies for the delay, I have quite busy these last months.
Thanks to some reordering of the original Schema as provided by composer/composer, these changes are expected.
See https://github.com/ergebnis/composer-normalize/issues/779.

delay? what delay? you are way faster than me ;)
thanks for context!


V2 Performace Improvements Part 1

This pull request makes performance changes across some of the highly used objects in math and geometry, as well as applying some 'known' performance improvements.
NOTE: Also removes an reliance on old code from api or core directories.

[X] code change complete
[X] test coverage complete
[X] reviews complete

Closes #72

I will stop here as these were the first and most serious improvements for performance.
@kaosat-dev please review these changes.

@z3dev I added a few other comments/ replies :)

Thanks for the review. All changes have been completed.
@kaosat-dev please merge


chore: add osp configuration

Description
Add configuration for the osp callback
Why
To be able to do the callback to the osp a technical user is needed for authentication.
Issue
N/A - Jira Issue: CPLP-2638
Depending Backend PR
#260
Checklist

[x] I have performed a self-review of my changes
[x] I have successfully tested my changes
[x] I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
[x] I have commented my changes, particularly in hard-to-understand areas

Before merging this, we need to set the clientId and secret for the technical user in the vault for all environments. need to clarify with @jjeroch  which roles the technical user needs

Looks good! Could please update the comment here as well? https://github.com/eclipse-tractusx/portal-cd/blob/0fd33b052c6d7190e7bbcf88dd970a226e58e2b6/charts/portal/values.yaml#L242C121-L242C121

Done :)

@evegufy since we changed the process logic from setting up a technical user for the osps to the osps setting the auth data in the portal, the config has changed


Why use TF32 Tensorcore Peak Flops for MFU calculation?

Hi, thank you for releasing this wonderful codebase.
I noticed that the MFU calculation in your code is using the TF32 Tensorcore peak FLOPs as denominator, as hard-coded here.
However, since FSDP uses --training.mixed_precision_param, does that mean the mix-precision training is using BF16 instead, and thus should use the BF16 Tensorcore peak FLOPs?
E.g., according to manual on H100 SXM, the BF16 peak FLOPs is about 2x TF32 peak FLOPs.
Thank you very much for your time and help! @lessw2020

Hi @LeoXinhaoLee  - wow, good catch!  You are right, we meant to be using BF16 given the default mixed precision, but somehow the TF32 numbers were copied in.
Let me make a PR to correct this, and thanks again for flagging.
Will update here with the PR shortly.

Thank you for your reply. I'm wondering if the MFUs reported here are also calculated with this problem?

It turns out that the BF16 Tensorcore peak FLOPs/s reported on H100 datasheet is with sparsity. It doesn’t say what’s the BF16 peak FLOPs/s. However, on A100, the non-sparsity peak FLOPs/s is 1/2 of sparsity’s. So extrapolating from this relation, the BF16 peak FLOPs/s should be 0.5 * 1,979e12 = 989e12.
Therefore, I think the codebase is calculating MFU correctly (without sparsity). Thank you again for your timely response, and it would be great if your team could emphasize this detail in the doc.

oh nice, I'm glad you caught that b/c I didn't follow the asterik with the very tiny "with sparsity" addendum when I looked a minute ago.  I don't believe they used to report it like that before - I believe they reported it as two sep numbers (dense and then sparse).
Anyway, as you note, that does mean our current MFU numbers are correct.
Will try and add the note that new Nvidia docs are reporting FLOPs with sparsity by default to help clarify this.
Thanks again @LeoXinhaoLee!

Is it possible to write code to measure the actual peak FLOPS (Floating Point Operations Per Second) under specific conditions?


Metric names containing spaces are not valid

Code like e.g. this suggests that this crate permits metric names containing spaces. The data model asserts that

The metric name. . . may contain ASCII letters and digits, as well as underscores and colons. It must match the regex [a-zA-Z_:][a-zA-Z0-9_:]*.

Names that don't meet these criteria should be rejected.

See also https://github.com/prometheus/client_rust/issues/52.


meshio .msh (from ANSYS fluent not gmsh) to .xdmf norworking properly

Hello,
I think the converter  from ANSYS fluent .msh files to .xdmf does not work.
It fails to write a boundary part out.
mesh.zip
fluent.zip
The attached files: fluent.zip contains ASYS fluent .msh file; mesh.zip contains the converted .h5 and .xdmf file.
Thanks in advance,
Jack

For me it works properly.

@tianyikillua, when you report that ‘it works properly’, do you get any information on the boundary?  I can also get a picture like yours but note that the original post specified:

It fails to write a boundary part out.

When I run
meshio-convert -i ansys fluent.{msh,xdmf}

I see on stdout
<meshio mesh object>
  Number of points: 81012
  Number of cells:
    triangle: 817512
    triangle: 864
    triangle: 965
    triangle: 530
    triangle: 40421

and do see in fluent.msh names like:

"Interior faces of zone CREATED_MATERIAL_1"
"Faces of zone OUTLETVEIN"
"Faces of zone INLETVEIN"
"Faces of zone INLETGRAFT"
"Faces of zone WALL"

suggesting five blocks of triangular cells; however, when I look into fluent.xdmf and fluent.h5, I see only 81012 points and 860292 triangles in a single block (represented, I regret to add, as ‘TopologyType="Mixed"’ rather than "Triangle", but I'll leave that for #568 or a successor).  Similarly, on repassing fluent.xdmf through meshio.read, I get only
<meshio mesh object>
  Number of points: 81012
  Number of cells:
    triangle: 860292

Whatever physically significant distinction was present in fluent.msh as six "Zone Sections" of type fluid, interior, outlet-vent, velocity-inlet, velocity-inlet, and wall, and read by meshio.read to give a .cells attribute of len 5 has been lost.  Distinguishing ‘OUTLETVEIN’, ‘INLETVEIN’, &c., might be essential in a computational fluid dynamics code for imposition of a mixed boundary value problem, so I think I can see what the OP might mean by

It fails to write a boundary part out.

but cannot quite agree that ‘it works properly’.  Perhaps meshio.read should not read Fluent .msh zones into the Cells of .cells since these are intentionally devoid of physical significance #685.

As it happens, I also find myself having to read a Fluent .msh today.  Like the OP, I need the boundary part.  I don't understand the Fluent .msh format myself, but both a workaround and potentially a guide to improving meshio.ansys._ansys.read is that the boundary part does seem to be parsed and preserved by the OpenFOAM utility fluentMeshToFoam; e.g. constant/polyMesh/boundary contains
4
(
    OUTLETVEIN
    {
        type            patch;
        nFaces          864;
        startFace       817512;
    }
    INLETVEIN
    {
        type            patch;
        nFaces          965;
        startFace       818376;
    }
    INLETGRAFT
    {
        type            patch;
        nFaces          530;
        startFace       819341;
    }
    WALL
    {
        type            wall;
        inGroups        List<word> 1(wall);
        nFaces          40421;
        startFace       819871;
    }
)

Note that the first startFace matches the size of the first cellblock parsed by meshio and the four nFaces match the rest.
Further the polyMesh can be run through foamToVTK which produces a directory VTK with one VTK file containing 419451 tetra and four directories (INLETGRAFT, INLETVEIN, OUTLETVEIN, WALL), each containing a single VTK file with POLYDATA which can't be read by meshio.
Still further, those four VTK files representing the boundary parts can be opened in ParaView (5.6.0 here); then 'Save data' to XDMF, giving, e.g. wall.xmf and wall.h5, which I include here in
wall.tar.gz.  This wall.xmf can be read by meshio and contains 40421 triangles in TopologyType="Triangle" (hooray, not "Mixed"!) and .cell_data['PatchID'] which looks like a ndarray of dtype=float32 with all 40421 entries equal to 3.0.
Hope this helps, both, as I say, as an immediate expedient not using meshio for those needing to read Fluent .msh, and to show what kind of data might be available in the original fluent.msh for potential future parsing by meshio.

@gdmcbain Thank your for the thorough and professional write up..I wasn't sure what the OP meant by "a boundary part"...I thought maybe there would be another "arm" attached to the "body" missing during conversion.
For the zone information, yes we need to translate them as cell tags just like cell_data['PatchID'].


msbuild ALL_BUILD fails on aws-cpp-sdk-transfer

I followed the instructions on the README.md where I first cloned the repo. Then I run the cmake for the sources. After that I tried to build for Visual Studio as instructed in README with the msbuild ALL_BUILD.vcxproj command (on the root where I ran cmake command) and it failed on the aws-cpp-sdk-transfer build. After that I separately tried to run ALL_BUILD.vcxproj only for aws-cpp-sdk-transfer and it failed with the similar warning & error.
Here is what the console printed out about it:

Build FAILED.
"E:\Developer\aws-sdk-build\ALL_BUILD.vcxproj" (default target) (1) ->
"E:\Developer\aws-sdk-build\aws-cpp-sdk-transfer\aws-cpp-sdk-transfer.vcxproj"
(default target) (107) ->
(ClCompile target) ->
E:\Developer\aws-sdk\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp
(133): warning C4244: 'argument': conversion from 'uint64_t' to '::size_t', pos
sible loss of data [E:\Developer\aws-sdk-build\aws-cpp-sdk-transfer\aws-cpp-sdk
-transfer.vcxproj]
"E:\Developer\aws-sdk-build\ALL_BUILD.vcxproj" (default target) (1) ->
"E:\Developer\aws-sdk-build\aws-cpp-sdk-transfer\aws-cpp-sdk-transfer.vcxproj"
(default target) (107) ->
(ClCompile target) ->
E:\Developer\aws-sdk\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp
(133): error C2220: warning treated as error - no 'object' file generated [E:\D
eveloper\aws-sdk-build\aws-cpp-sdk-transfer\aws-cpp-sdk-transfer.vcxproj]
1 Warning(s)
1 Error(s)

This is a bug on our end for 32 bit builds. We're fixing it now. In the meantime, if it works for you, you can build for 64 bit cmake -G "Visual Studio  Win64"

we just pushed out the fix for this, reopen if you still have problems.


Mrtrix hsvs ACT reconstruction - convert_fs_brain error

Hello,
after processing my data using Freesurfer and trying the ACT-hsvs pipeline, I get the following error:
[Node] Error on "qsirecon_wf.sub-xxx_mrtrix_singleshell_ss3_hsvst.anat_ingress_wf.register_fs_to_qsiprep_wf.convert_fs_brain" (/scratch/qsirecon_wf/sub-xxx_mrtrix_singleshell_ss3_hsvst/anat_ingress_wf/register_fs_to_qsiprep_wf/convert_fs_brain)
exception calling callback for <Future at 0x7fa6477c1340 state=finished raised FileNotFoundError>
concurrent.futures.process._RemoteTraceback:
"""
Traceback (most recent call last):
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/plugins/multiproc.py", line 67, in run_node
    result["result"] = node.run(updatehash=updatehash)
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/engine/nodes.py", line 527, in run
    result = self._run_interface(execute=True)
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/engine/nodes.py", line 645, in _run_interface
    return self._run_command(execute)
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/engine/nodes.py", line 722, in _run_command
    result = self._interface.run(cwd=outdir, ignore_exception=True)
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/interfaces/base/core.py", line 388, in run
    self._check_mandatory_inputs()
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/interfaces/base/core.py", line 275, in _check_mandatory_inputs
    raise ValueError(msg)
ValueError: MRConvert requires a value for input 'in_file'. For a list of required inputs, see MRConvert.help()

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/miniconda/lib/python3.8/concurrent/futures/process.py", line 239, in _process_worker
    r = call_item.fn(*call_item.args, **call_item.kwargs)
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/plugins/multiproc.py", line 70, in run_node
    result["result"] = node.result
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/engine/nodes.py", line 223, in result
    return _load_resultfile(
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/engine/utils.py", line 291, in load_resultfile
    raise FileNotFoundError(results_file)
FileNotFoundError: /scratch/qsirecon_wf/sub-xxx_mrtrix_singleshell_ss3_hsvst/anat_ingress_wf/register_fs_to_qsiprep_wf/convert_fs_brain/result_convert_fs_brain.pklz
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/miniconda/lib/python3.8/concurrent/futures/_base.py", line 328, in _invoke_callbacks
    callback(self)
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/plugins/multiproc.py", line 159, in _async_callback
    result = args.result()
  File "/usr/local/miniconda/lib/python3.8/concurrent/futures/_base.py", line 437, in result
    return self.__get_result()
  File "/usr/local/miniconda/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result
    raise self._exception
FileNotFoundError: /scratch/qsirecon_wf/sub-xxx_mrtrix_singleshell_ss3_hsvst/anat_ingress_wf/register_fs_to_qsiprep_wf/convert_fs_brain/result_convert_fs_brain.pklz

I'm on QSIPrep 0.18.1, data has been elaborated on Freesurfer 7.3.2 and all the files are there.

Sorry, turns out my freesurfer-input folder structure was wrong.
I still think this is a bug as you can use a freesurfer-input flag pointing to a valid Freesurfer output, but encounter issues if the folder doesn't have a sub-ID subfolder containing all the files. I believe letting the user choose the actual folder containing the derivatives would be better.

Are you working with multi-session data?

What do you mean?

One of the big problems with the hsvs workflow happens when you split up a subject into multiple sessions and process the sessions separately. We do this all the time with developmental data (where you can't make a rigid T1w space for a subject). If you have a different freesurfer result for each session it's not clear how to set up the --freesurfer-input generically

I am piping QSIPrep's processed T1w to FastSurfer, then I run the recon pipeline. Worked like a charm when I put FastSurfer's output in the derivatives/freesurfer/sub-ID folder and pointed QSIPrep to use --freesurfer-input derivatives/freesurfer. This should be either changed in the docs (explicitly say you need a subfolder named sub-ID) or the behavior changed to accommodate any folder, IMHO.

oh wow, that's very cool to hear that fastsurfer works directly with the hsvs workflow. It's been on my list to try that out. In the meantime I'll add to the docs to make it clear what to put as the --freesurfer-input

I mean I'm still trying the pipeline out, I have yet to inspect the actual result. But it went through without issues.
I had to change the aliases FastSurfer generates and use the original files, but as far as I am concerned, the hsvs pipeline completed without issues.

Works perfectly.
With ACT:

No ACT:

Detail with ACT:

Detail without ACT:


Add basic mini aepps for aeternity features

This will have to be broken into separate epics.

names
oracles
browsing aepps [part of browser]
proof of existence
redeem (?)
voting
state channels demo
etc

redeem is meant to be redeeming paper wallets generated using https://github.com/aeternity/tool-paperwallets


[5.1] Improvement of #10356

Making it case-insensitive we can have And or Or without bugs.

Duplicate of https://github.com/laravel/framework/pull/10361?

That said, this PR looks better than the original to me.

Oh, I really didn't see. Sorry @lucasmichot.

No worries @KennedyTedesco , anyway https://github.com/laravel/framework/pull/10361 has been refused (?)


adding Hireme button UI with hover property

I guess we don't need this components. @Aniket-011

Can u please suggest me which type of content i contribute.
Hope for positive rply.
On Sat, 11 Feb 2023, 11:55 am Rajdeep Sengupta, @.***>
wrote:

Closed #1770 https://github.com/Clueless-Community/seamless-ui/pull/1770
.
—
Reply to this email directly, view it on GitHub
https://github.com/Clueless-Community/seamless-ui/pull/1770#event-8495720159,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYMVNXWJHJC6LKQIVGWTRGDWW4WG5ANCNFSM6AAAAAAUYG26II
.
You are receiving this because you were mentioned.Message ID:
@.***
com>


train

Hello Sir,
While trying to replicate your work, I'm having some difficulties in training the model. The Adam optimizer is returning nan, and am not sure if its due to the wrong implementation of the loss function (tried implementing after reading your paper). It would be greatly helpful if you could share your training script. You could send it to my email id<EMAIL_ADDRESS>Thank you.

Hi,
Thanks for showing interest in our work. We've lost the training script, so I won't be able to share the same. However, I can advise you the following:

Make sure you are using the correct pytorch version.
We have linked the loss function repositories in "Useful Repositories" (check Readme).
We used an older version of MS-SSIM. Please undo this change: https://github.com/jorge-pessoa/pytorch-msssim/commit/ff882263779e94c29ec4e76a432d2ec80df8796b#diff-b583e4c6807ec522fa88e389e2245135a1686c73bbcdfa8baa8a7068288cf49f
You can start by training with a simple loss function (L1) to check if there is some other problem.

Let me know if these fixes work.

Closing. Feel free to open if needed.


Build scan adds significant overhead

Gradle version: 4.7
Profile information differs significantly when running with --profile and --scan.
Cleanup task is ./gradlew clean
Profiled task is ./gradlew :app:assDeb  -Pandroid.enableBuildCache=false -PdevBuild
Using the Robot-Scouter project (SHA: 9e73eaec4c5d52a8b0115d86f76aeae686b517fb), Gradle version has been updated to 4.7.
profile.zip has been generated with --profile. For the same project, using --scan produces https://scans.gradle.com/s/bjkerez4httoe/performance/execution.
In the first, dexing takes 9 seconds, while in the second one it takes 24 seconds.

@ldaley You might wanna take a look at this one.

I used https://github.com/gradle/gradle-profiler to profile this issue. See the results attached. From the profiling I cannot reproduce this significant difference in build execution.
However I see that the dex task is quite volatile in how much time it takes. On my machine when running with or without build scans I saw execution times of ~10 up to ~35 seconds.
I'm tempted to close this issue as not reproducible.
benchmarkResults.zip

@gavra0 As described in my comment above I struggle to reproduce the significant difference you experience. It would be great if you can help me and profile your build using the gradle-profiler project (https://github.com/gradle/gradle-profiler) and share your results?
my gradle-profiler scenario file looks like that:

clean_build_withNoScan {
    tasks = [":app:assDeb"]
    gradle-args = ["-Pandroid.enableBuildCache=false", "-PdevBuild"]
    cleanup-tasks = ["clean"]
    run-using = cli // value can be "cli", "no-daemon" or "tooling-api"

    warm-ups = 5
}

clean_build_withScan {
    tasks = [":app:assDeb"]
    gradle-args = ["-Pandroid.enableBuildCache=false", "-PdevBuild", "--scan"]
    system-properties {
        scan.dump = "true"
    }
    cleanup-tasks = ["clean"]
    run-using = cli // value can be "cli", "no-daemon" or "tooling-api"

    warm-ups = 5
}

you can run the benchmarking by executing
gradle-profiler --benchmark --project-dir <PATH TO ROBOT SCOUTER> --scenario-file performance.scenario
If your profiling demoes the problem you initially reported, it would be great to run the gradle-profiler with --profile jfr and share those profiling information here to help us narrow down the isue.
Thanks a lot.
cheers,
René

@breskeby When using gradle-profiler, numbers with and without --scan look similar, around 30 seconds. However, if I run a simple bash script, I see the difference.
# without --scan
./gradlew --stop

# warmup
for i in {0..3}
do
  ./gradlew clean && ./gradlew :app:assDeb -PdevBuild -Pandroid.enableBuildCache=false
done

echo "Timed runs without --scan"
./gradlew clean && time ./gradlew :app:assDeb -PdevBuild -Pandroid.enableBuildCache=false
./gradlew clean && time ./gradlew :app:assDeb -PdevBuild -Pandroid.enableBuildCache=false
./gradlew clean && time ./gradlew :app:assDeb -PdevBuild -Pandroid.enableBuildCache=false

# with --scan
./gradlew --stop

# warmup
for i in {0..3}
do
  ./gradlew clean && ./gradlew :app:assDeb -PdevBuild -Pandroid.enableBuildCache=false -Dscan.dump=true --scan
done

echo "Timed runs with --scan"
./gradlew clean && time ./gradlew :app:assDeb -PdevBuild -Pandroid.enableBuildCache=false -Dscan.dump=true --scan
./gradlew clean && time ./gradlew :app:assDeb -PdevBuild -Pandroid.enableBuildCache=false -Dscan.dump=true --scan
./gradlew clean && time ./gradlew :app:assDeb -PdevBuild -Pandroid.enableBuildCache=false -Dscan.dump=true --scan

On my laptop, without --scan takes 30 sec, with 50 sec. Can you please try to repro with this script? Also, do you have any idea why there is such a big difference when running with gradle-profiler and when running this bash script?
Thanks!

@gavra0 The Gradle profiler uses an isolated user home, so my hunch is that you have some init script that adds additional work when build scans are enabled? Can you check that?

@oehme Great idea, using a temporary GRADLE_USER_HOME makes builds with and without --scan completely the same 😀
I looked a bit more, and the issues was some state in ~/.gradle/build-scan-data/. After removing only that directory, overhead of running with --scan has disappeared (when using my default GRADLE_USER_HOME). Unfortunately I failed to save the content, but it contained: 1.12.1, 1.13,	1.13.1, 1.8 directories. Could this be some issue between different BuildScan versions?

@gavra0 whether that directory is empty or not should have no impact. Regardless, we'll do some stress testing and get back to you.

@gavra0 We are unable to reproduce the results, nor find any reason as to why a number of files in ~/.gradle/build-scan-data would blow out build times.
Have you experienced this again since?

@ldaley There were no issues since. Feel free to close the issue, and in case I managed to reproduce again, I'll update the bug. Thanks!

Thanks for the feedback, @gavra0. Closing this issue now.


Add PcapPlusPlus to the Docusaurus Site Showcase

Motivation
I'm the maintainer of an open-source project named PcapPlusPlus. I recently migrated its website to Docusaurus 2.0: https://pcapplusplus.github.io/
I'd like to add this website to the Docusaurus Site Showcase.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
N/A
Related PRs
N/A

I've signed the Facebook CLA:

Yeah, no problem, just wait for a few hours :)
As an aside, your navbar has multiple items lit up simultaneously:

My suggestion is to use multiple sidebars and use the docSidebar navbar item, or try the activeBaseRegex API

My suggestion is to use multiple sidebars and use the docSidebar navbar item, or try the activeBaseRegex API

Awesome, thank you for the tip, I'll fix that!


dev-cmd/tap-new: fix output on newer versions of Git.

Otherwise this prints to stderr to ask for configuration of the branch name:
https://github.com/Homebrew/brew/pull/10323/checks?check_run_id=1701105141#step:5:51

Review period skipped due to critical label.

Review period skipped due to critical label.

Review period skipped due to critical label.

Review period skipped due to critical label.

Doesn't safe_system "git", "branch", "-m", branch already handle the branch naming for us?

Doesn't safe_system "git", "branch", "-m", branch already handle the branch naming for us?

Doesn't safe_system "git", "branch", "-m", branch already handle the branch naming for us?

It does, yep. Unfortunately we need to handle this in a way that works on older and newer Git versions. It's a no-op if the branch is already named e.g. main on newer versions and the -c bit is a no-op on older versions that don't know about that configuration setting.

Doesn't safe_system "git", "branch", "-m", branch already handle the branch naming for us?

It does, yep. Unfortunately we need to handle this in a way that works on older and newer Git versions. It's a no-op if the branch is already named e.g. main on newer versions and the -c bit is a no-op on older versions that don't know about that configuration setting.


Apply Greg styling suggestions to orbit; use modules

UI changes:

Use fillable plot output for simulation plot
Tuck direction diagram into the bottom-right corner (and hide it on smaller screen sizes)
Use sidebar layout
Put earth, moon, planetx into accordion

Code change:

Use Shiny modules for earth/moon/planetx
Separate simulation logic from plotting logic

Before

After

I think this looks nice, but in some ways I think it's less usable...

All of settings panels for the bodies start collapsed, so you have to click on one of them to even know that there are settings that can be altered -- but the whole purpose of the app is to play with those settings. I think that when the app starts with those settings visible, it invites users to play with them; when it starts with the settings hidden, I think users are likely to just skip over the app. Or they'll start by clicking the "Simulate" button and all that will happen is that the plot will look exactly the same as before.
If both Earth and Moon are open, then on a non-big screen you need to scroll down to change the moon settings, and then scroll back up to click the Simulate button. Can the button be made sticky? (And maybe it would need to go above the sliders for duration and time step.)
Can the Earth, Moon, and Planet X headers be made bold and maybe a bit larger? As section headings, they sort of blend in with the rest of the content in the sidebar. Or maybe the header could have a different background from the body? (Also, I think that on touch devices, it think the expanding drop-down affordance may be non-obvious.)
Can a tab panel be put in the sidebar, similar to the old layout? That would address many of these issues.
I'm not sure if anything can be done about this here, but the focus outline on the accordion	headers only shows the horizontal bars, which I find a bit distracting. If all four sides of the outline were visible, that would be better.

I realize that some of these issues may be outside the scope of this app.

All good points. Does this help?

All of settings panels for the bodies start collapsed, so you have to click on one of them to even know that there are settings that can be altered -- but the whole purpose of the app is to play with those settings. I think that when the app starts with those settings visible, it invites users to play with them; when it starts with the settings hidden, I think users are likely to just skip over the app. Or they'll start by clicking the "Simulate" button and all that will happen is that the plot will look exactly the same as before.

I have to admit I always found the settings a bit overwhelming. With the above screenshot, it starts out empty so the "Simulate" button does have an effect. (It'd be really nice to disable the button after it runs, and only re-enable once a relevant parameter has changed.)
It might also be nice to have a non-primary "Randomize body settings" button, that would give a casual user an easy way to see quite different output.

If both Earth and Moon are open, then on a non-big screen you need to scroll down to change the moon settings, and then scroll back up to click the Simulate button. Can the button be made sticky? (And maybe it would need to go above the sliders for duration and time step.)

What do you think of the above treatment--with the button alone in the corner?

Can the Earth, Moon, and Planet X headers be made bold and maybe a bit larger? As section headings, they sort of blend in with the rest of the content in the sidebar. Or maybe the header could have a different background from the body? (Also, I think that on touch devices, it think the expanding drop-down affordance may be non-obvious.)

I agree, but simply making them bold/larger made them look kind of dumb when in the collapsed state. Probably worth discussing with @gregswinehart next week, since I don't think this problem is specific to this app.

Can a tab panel be put in the sidebar, similar to the old layout? That would address many of these issues.

I don't believe we have that, I think the old layout (tabbed card where a sidebar would be) was the closest we could do without more custom CSS than feels appropriate for an example.

I'm not sure if anything can be done about this here, but the focus outline on the accordion headers only shows the horizontal bars, which I find a bit distracting. If all four sides of the outline were visible, that would be better.

Agreed. It looks like the focus ring is being drawn via box-shadow here. Changing this to an inset box shadow, for accordions in a sidebar, is an improvement IMHO. (cc @gadenbuie)


Add second wave of jobs

[ ] Property Sales
[ ] Assessment
[ ] Crashes
[ ] Dogs
[ ] Asbestos Permits

@saylorsd I think that for this you might want to consider breaking this into two distinct projects.

The pipeline-generation code, which should have a cool name and be published to pip (happy to help out with this!)
The code for the actual pipelines.

@bsmithgall That sounds perfect!  What do you think would be the best way to go about it?  I was thinking I'll just make a branch where I remove the jobs and their tests and then push that to a new repo.

@bsmithgall Also... any ideas on a name?

I'd recommend doing something like this: https://help.github.com/articles/duplicating-a-repository/
For names, I have no idea. Something about pipes?

@bsmithgall Since were going to keep the history anyway, would it just make sense to remove the jobs from this repo and rename it when we come up with something?

@bsmithgall I'm planning on removing the WPRDC-specific jobs and there tests and their respective git histories a la this method.
I copied the jobs to this repo with only their histories intact.  I think I'll move the current job tests and their respective mock files to a test directory within jobs and setup a separate build checks for them.
Does this make sense?
I think this way, when developing jobs, I'll simply add wprdc-etl as a requirement for pip and refactor the tests and stuff to account for that if necessary.

Yeah. Ultimately we'll need to get the other thing installed up to pypi. I am out on vacation next week, but the week after that I can probably dedicate some cycles.

@bsmithgall Sounds good! That'll give us some time to come up with a name for it. Have a good time!


JsonPath.parse(json).read(path) not returning if array index is out of bounds

Hi all.
I'm having problems retrieving values in a nested array.
My test JSON is:
{
"numbers": [0,1,2]
}

and I'm fetching values using Object o = JsonPath.parse(json).read(path);, then converting o to the correct class.
However, while with Object o = JsonPath.parse(json).read("$.numbers[1]"); everything works fine, fetching Object o = JsonPath.parse(json).read("$.numbers[3]"); freezes the method, which does not return. I'd expect null or at least an error to be thrown.
This happens both using Configuration configuration = Configuration.defaultConfiguration().addOptions(Option.DEFAULT_PATH_LEAF_TO_NULL); and without.
Library version is 2.4.0.
Am I perhaps missing something?
Thanks

It seems to be solved in version 2.7.0, with Object o = JsonPath.parse(json).read("$.numbers[3]"); I got an exception as follows:
"Exception in thread "main" com.jayway.jsonpath.PathNotFoundException: No results for path: $['numbers'][3]".


various issues git push hangs, flynn create causes unknown_error: Something went wrong...

I'm working with a 3 node cluster in Azure. Installing flynn was a breeze; its great to be a able to deploy my own PaaS quickly and easily.
Everything worked fine for the first few pushes, but I'm now getting various intermittent errors, such as:

flynn create in new repos fails intermittently with unknown_error: Something went wrong.
flynn log hangs or returns GET https://controller.qj13.flynnhub.com/apps/kookaburas-amuse-caradoc/log?follow=true: httpclient: raw req: unexpected status 503
git push hangs on certain repos

repairing the cluster sometimes seems to improve things temporarily (but difficult to tell), here is the output of flynn-host fix --min-hosts 3:
INFO[11-19|16:48:30] found expected hosts                     n=3
INFO[11-19|16:48:30] ensuring discoverd is running on all hosts
INFO[11-19|16:48:30] checking flannel
INFO[11-19|16:48:30] flannel looks good
INFO[11-19|16:48:30] waiting for discoverd to be available
INFO[11-19|16:48:30] checking for running controller API
INFO[11-19|16:48:30] found running controller API instances   n=2
INFO[11-19|16:48:30] found controller instance, checking critical formations
INFO[11-19|16:48:30] checking postgres
INFO[11-19|16:48:30] found running postgres leader
INFO[11-19|16:48:30] found 2 running postgres instances
INFO[11-19|16:48:30] getting postgres status
INFO[11-19|16:48:30] postgres claims to be read-write
INFO[11-19|16:48:30] checking for running controller API
INFO[11-19|16:48:30] found running controller API instances   n=2
INFO[11-19|16:48:30] found controller instance, checking critical formations
INFO[11-19|16:48:30] scheduler looks up, moving on
INFO[11-19|16:48:30] cluster fix complete

Here is the debug gist:
https://gist.github.com/anonymous/f7d4d7cfcb8d2fcc9301
I noticed there appear to be some SQL errors in there to do with the blob store.
E..g
2015/11/19 06:25:01 discoverd: heartbeat blobstore (<IP_ADDRESS>:80) failed: unknown_error: Something went wrong
2015/11/19 06:25:11 error: ERROR: cannot execute INSERT in a read-only transaction (SQLSTATE 25006)

flynn version is: v20151104.1

This looks like a variant of #2027, I think the fix merged in #2145 will help, and this should be fully resolved when #2158 is done.


Add method for joining string reprezentations

@cobbzilla please review

does your join method do something that the various toString methods do not already do? They are here: https://github.com/cobbzilla/cobbzilla-utils/blob/master/src/main/java/org/cobbzilla/util/string/StringUtil.java#L204

Yes, looks like.


Ability to order versions list descending

While working on a big private plugin, I quite often go into the versions list of builder to create new manually migrations. After I edit those in an external editor, I have to re-open it in Builder to get new code before applying. When you have hundreds of versions, it's quite time consuming to scroll to the bottom every time you refresh. Example:

This could be easily fixed by adding a new button on version list to reverse the order. This is my PR esentially:

Order versions ascending or descening
Order is saved in session

After my changes:

Changes are welcomed before merging.

@filipac It's a good idea, however, I don't think the button to sort the versions should be in the orange section, as that's reserved for the plugin name. The conventional placement for that button would be next to the "Add" button, like it is for the "CMS" section of the Backend.

Would you mind moving it into there and styling it appropriately? Once done, feel free to send us a screenshot.

Made the change + code style you suggested.

done.

@LukeTowers @bennothommo any updates on this required? :D i did composer update and lost my local changes and i miss the order :))

@filipac css is missing, still 😄
Screenshot:

@filipac If you are still interested in getting this merged, please review @w20k's comment above.


Share image segmentation annotation tool

In your paper you mention that you had a tool based on GrabCut that took about 5s per image to annotate. I'd find this tool really helpful in building my own dataset - are you able to share the tool?

sry I could not find my original code as I have graduated for a long time...
I think I copied a lot of code from this repo
https://github.com/chocopoule/grabcutweb
I only added some func to read and save the results from/to the lab server.
Hope this helps


Ether driver receive handling

Describe the bug
If user would set descriptor num to 2 or more, receive process would be corrupted.
If user would set descriptor num to 1, receive process would not be corrupted.
This is just reported, SheltyDog has not understood this mechanism.
Expected behavior
No corrupting.
Screenshots or console output
None.
To reproduce

set descriptor num to 2 or more.

Code to reproduce the bug

no need. (current code can reproduce)

Additional context
None.

This may be because the receiving task processes only one packet per notification.
If two or more packets are received before the interrupt handler is activated and notified to the receiving task, the second and subsequent packets are delayed without being processed until the next notification occurs because receiving task  processes only one packets .

Thanks a lot. I will fix it.


Drop Node.js 6.x support

Node.js v6 will be the end of life on April 30th.
There isn't an issue to drop supporting Node.js v6 for me. Do you know any problem?

Then the debug options could be deprecated as well.

No problems for us in dropping support for Node.js v6 that I know of.

@juergba what you said means is --debug or --debug-brk could be deprecated. right?
https://mochajs.org/#-debug-inspect-debug-brk-inspect-brk-debug-inspect


Documentation - Mention collectstatic

In the quickstart guide, you mention making sure django's static file serving is working. But for some setups, you also have to run collectstatic for the static files to be visible. You might want to mention that there, unless you think it goes without saying.

Are you running your applications with DEBUG = False?

In a development environment, you shouldn't have to use collectstatic.

Hmm. Maybe I have my dev environment set up wrong. I didn't put a ton of
time into figuring it all out. But, I am running with debug = True.
Thanks, and sorry for the trouble
On Tue, Feb 3, 2015 at 10:07 AM, Tim Schilling<EMAIL_ADDRESS>wrote:

In a development environment, you shouldn't have to use collectstatic.
—
Reply to this email directly or view it on GitHub
https://github.com/django-debug-toolbar/django-debug-toolbar/issues/686#issuecomment-72702342
.

No problem. You should be able to run your project with python manage.py runserver then browse out to <IP_ADDRESS>/admin and it should have some sort of css styling without having to run collectstatic.

I ran into this issue too and I suggest we re-open this bug. The problem is that you might be running with DEBUG = True in an environment that uses Apache or that otherwise needs to run collectstatic.
I was struggling to get the toolbar working until I opened the browser console for something else and discovered that the files were returning 404's. At that point I ran collectstatic, and everything started working.
Can we add something to the docs that says:

If you are running in an environment that requires that you collect your static assets, run manage.py collectstatic after adding debug_toolbar to INSTALLED_APPS.

That'd go a long ways for people with setups like mine.

This isn't specific to the toolbar. You'd have the same behavior with any other application that uses static files e.g. django.contrib.admin. We don't want to duplicate Django's documentation -- in this case, the documentation of the staticfiles app.

It's a small thing to add a line about this and it'll save some people lots of time and trouble.
Your call, but in my experience very few Django apps require this step b/c most don't have static resources. At least for me, this wasn't something I was thinking about in the least.

I'm still reluctant to recommend a step that will be unnecessary for 99,99% of developers, given that runserver serves static files out of the box. There's enough confusion around staticfiles already.


gui editcommandtest + remove red color after wrong command

Coverage decreased (-0.04%) to 87.875% when pulling b477d436777300d11c0f403a384a0d95842fec5c on ashpa:master into a3d9d93bd3249d0ea4338c0f07f9bd76ebaaf24d on CS2103JUN2017-T4:master.


🚀 Feature: Add type guard for the error type

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
Essentially a function that returns isIntrinsicType(type) && type.intrinsicName === "error".
Additional Info
I'm not sure what the best name for the function would be. Possible names:

isErrorType

+ short and simple
- users may confuse with the JS Error object's type

isTypeError

+ short and simple
- inconsistent with other type type guards (other ones always end with "Type")

isIntrinsicErrorType

+ consistent with other intrinsic type guards
- users may think "Intrinsic Error" is a subtype of error

Hmm good question. I do like consistency - isIntrinsicErrorType makes the most sense to me... and the downside seems much smaller than the other two options'. Voting for isIntrinsicErrorType!


Loot Council in CLM directly

Is your request related to a problem? Please describe.
My guild cannot find a single addon that can handle both EPGP and Loot Council in a single interface like the old addon "EPGP Lootmaster" used to.
My guild runs a Loot Council but we have EPGP running as well, so that EP can be used as a rough numerical value corresponding with recent participation/attendance and GP can be used as a rough numerical value corresponding with recent gear awarded.
With two addons (one for loot council such as RCLC and one for EPGP like CLM), after players select whether they want an item, I and my officers would have to open CLM separately to look up each of the interested players' EP, GP, and PR. We would not be able to sort the players in the RCLC window by PR. We would have to keep going back and forth between the two windows and hope we don't accidentally mix up who has what PR. This is slow, difficult, and just not a feasible solution.
Describe the solution you'd like
Other addons seem to already use similar interfaces, such as RCLC, but these are addons strictly for Loot Council, not for EPGP or other point-based systems.
CLM could implement its own Loot Council interface, where you can do all the usual things, such as give raiders options for selection such as "Main Spec" and "Off Spec", allow the council to vote with an addon instead of text or voice, and track loot history. In addition, CLM could also display EP, GP, and PR point values for each raid member interested in a loot item, and allow for sorting and/or filtering using those values. CLM could allow items to get a flat or percentage-based amount of EP associated with different options, such as making items awarded to someone who selected Off Spec to be 50% off. There would no longer be a need for RCLC integration, and would allow for guilds to use a combination of Loot Council and EPGP with a single addon, as my guild has done and still wants to.

CLM will not introduce loot council. The rclootcouncil integration is however under constant development


added a notes website

Issue reference:
Fixes #<ISSUE_NUMBER>
Proposed changes:
added a notes taking website
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other (please specify)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@SahilS1G
There is already a note taking application present in this repository. But don't worry; you can contribute some other unique JavaScript projects that you have.


Webchat with DirectLine App Service Extension not rendering the SuggestedActions and activities onMembersAdded

Is it an issue related to Adaptive Cards?
No
Is this an accessibility issue?
No
What version of Web Chat are you using?
Latest production
Which distribution are you using Web Chat from?
Bundle (webchat.js)
Which hosting environment does this issue primarily affect?
Web apps
Which browsers and platforms do the issue happened?
Browser: Chrome (latest)
Which area does this issue affect?
Suggested action
What is the public URL for the website?
No response
Please describe the bug
I configured the azure bot with App Service. While initiating the bot in web app using webchat with directline app service extension, the initial activities received from bot service in websocket is not rendering properly.
If I use directline secret instead of token, it is rendering properly.
Do you see any errors in console log?
No response
How to reproduce the issue?

Create a simple bot using using nodejs, that sends some plain message onMembersAdded and some suggestedActions
Initialize directLine with token in web app and trigger renderWebChat method
See whether the plain text activity and suggested actions are rendering in the webchat container

What do you expect?
It should render the message and suggested actions whenever user connects with the bot.
What actually happened?
The initial message and suggested actions are not rendering while using token for DirectLine. whereas it works while using the DirectLine Secret.
Do you have any screenshots or recordings to repro the issue?
This is on using token for directline:

This is on using secret for directline:

Adaptive Card JSON
No response
Additional context
No response

is there any update on this issue?

@saravana-sk - Thank you for your patience. A few questions:

Have you observed any reported errors in the browser's dev console when using the token?
Could you try using the generated token in a non-App Service Extension Web Chat instance to verify there isn't an issue with the token? For example, in the Getting Started sample? To achieve this:

Console log the token value when attempting to run the ASE site.
Copy the value and paste it into the sample so that it is hard-coded, like so: createDirectLine({ token: "Eyj....7sd" })
Open the sample in a browser and test for a response.

Are you able to provide a copy of your code or a minimum reproducible example that I may test against?
Which version of Node are you running?
Which version of Chrome are you using? Have you tried in Edge or any other browser?

Closing due to inactivity.


Literal "\n" is output instead of newline characters

On windows (8.1 if it makes a difference) when I output sourcemaps they include the slash character followed by the letter instead of the newline character. Is this a know issue?
Cheers,
Ed

Is this really the literal characters, or is your editor rendering Unix style line returns as \n? I have no Windows computer to test this on.

Yes, it's really outputting them as \n rather than a newline character. I've opened them in my linux environment too.

And option to choose \n or \n\n is needed I think.

Same issue.
Show \n in file instead of real newline character.
It actually print text \n.
It isn't \n character.

Is this still a problem?

I don't think this is an issue any longer due to detect-newline.
If it is still a problem then yes.
@hzlzh is correct

And option to choose \n or \n\n is needed I think.

This can easily be added to util.getCommentFormatter from write.js. Feel free to PR it.


AttributeError: 'NoneType' object has no attribute 'reply'

Steps to reproduce the problem:

Run something like "mitmproxy --cert "example1.org=sslcerts/example1.org.pem" --cert "example2.org=sslcerts/example2.org.pem" --no-http2 --ignore devbox.com

What is the expected behavior?
No crash.
What went wrong?
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/mitmproxy/proxy/server.py", line 121, in handle
root_layer()
TypeError: 'NoneType' object is not callable
mitmproxy has crashed!
Please lodge a bug report at: https://github.com/mitmproxy/mitmproxy

Error in processing of request from <IP_ADDRESS>:38896
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/netlib/tcp.py", line 854, in connection_thread
self.handle_client_connection(connection, client_address)
File "/usr/lib/python2.7/site-packages/mitmproxy/proxy/server.py", line 64, in handle_client_connection
h.handle()
File "/usr/lib/python2.7/site-packages/mitmproxy/proxy/server.py", line 152, in handle
self.channel.tell("clientdisconnect", root_layer)
File "/usr/lib/python2.7/site-packages/mitmproxy/controller.py", line 68, in tell
m.reply = DummyReply()
AttributeError: 'NoneType' object has no attribute 'reply'
Any other comments? What have you tried so far?
None.

Mitmproxy Version: 0.17
Operating System: Centos 7

I cannot reproduce this on master anymore, I believe this should be fixed with the latest changes. Thanks for the report!


Kotlin documentation?

Porting the documentation, readme's, samples to Kotlin would be superb 😄

+1. It would be nice to have tabs for Java/Kotlin like on the Android developers website.

I second this!
I'm a recent convert to Kotlin so in between learning Kotlin and having to learn Apollo's new functions for Kotlin, I'm lost.
Is there an example repo or doc I can refer in regards to consuming kotlin code for queries and mutations?

@FernandoH-G for now you can take a look at the samples

Thank you @martinbonnin!
That is a good start for me.


Fix for setting default sort on filter reset

LGTM

This is a BC break and would cause unwanted behaviour. When you click the "reset filter" button, sort should be reset.


OsmAnd Protocol UTC-time

Would it be possible to add a UTC-enabled time field (e.g. 1994-11-05T13:15:30Z) to the OsmAnd Protocol? This would enable the use of other tracker Apps like mendhak/gpslogger.
I have no clue about Java, so bear with me, but something along these lines should/could work:
                case "timestampUTC":
                    try {
                        long timestamp = Long.parseLong(value);
                        if (timestamp < Integer.MAX_VALUE) {
                            timestamp *= 1000;
                        }
                        position.setTime(new Date(timestamp));
                    } catch (NumberFormatException error) {
                        DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'");
                        position.setTime(dateFormat.parse(value));
                    }
                    break;

You can use unix timestamp value in UTC. What formats does the other app support?

It is a UTC time string. The URL parsed from my log hex looks like this:
/?id=[...]&lat=[...]&lon=[...]&timestamp=2016-01-27T18:55:47Z&hdop=30.0&altitude=0.0&speed=0.0
Omissions [...] added by me. The transmitted URL results in the following error.
error - Unparseable date: "2016-01-27T18:55:47Z" - ParseException (... < OsmAndProtocolDecoder:78 < ExtendedObjectDecoder:39 < ...)

I have added support for ISO-formatted time values.

Thanks alot!


Fixing SB List endpoint body object issue

The list endpoints were missing the data attribute, so I added it to fix this issue.

Hi Hamza, where are you come from?

Hey, I'm from morocco what about you?

I am from Spain, may I ask you if you could collaborate on Sponsored Products endpoints version 3? How you use the Amazon Advertising Api? Self business?Enviado desde mi iPhoneEl 2 abr 2023, a las 23:59, Hamza @.***> escribió:
Hey, I'm from morocco what about you?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

Sure thing, I'll gladly help. I'll get started on it as I intend to use it also.


Make a same verb for all commands

Why is it "make" here

but "add" here?

I suggest replacing these verbs with the verb "create".

make_portal sounds better than create_portal :D
and add wrapping is better than create wrapping or make wrapping

?

Do you mean using the same verb for just the wrapping commands?

I am considering changing them to "create" except for "make_portal"

Yes


Optimizer logging

Added logging for optimized. It was commented out in the code. Now it can be configured by debug: true.
Disabled (debug: false) by default.
PR to Dev, as required, even that Dev is 2 commits behind master now :)

👍

Lol, I just changed base to master...


Updating page: Share

Editing the page to add ERIM related info

@nsunami I added the ERIM related info and hidden some extra information that is not too relevant.


Trish txt july6

minor text updates to the help pg.

/gcbrun

/gcbrun

Temporary Url for review: https://business-ar-dev--pr-265-vs3ccret.web.app

/gcbrun

https://business-ar-dev--pr-265-vs3ccret.web.app/en-CA