[gateway MFA] Authentication failures

Describe the bug
First off - apologies for the very general bug title. I've tried to find similar reports, but only one seems to come close: https://github.com/FreeRDP/FreeRDP/issues/5937
I'm trying to connect to my employer's remote desktop (I think on Windows Server 2019). The connection goes through a gateway and has MFA (OAuth2) enabled. The main problem: my connection very rarely goes through successfully, I'd guess about 1 in 20 to 30 times. Looking at logs I tried to take, it appears to fail in two different ways. First, it very often fails very soon, with the log (anonymised) ending as follows:
[15:03:09:893] [24350:24351] [INFO][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
[15:03:09:893] [24350:24351] [DEBUG][com.freerdp.core] - connecting to peer xxx.xxx.xxx.xxx
GatewayUsername<EMAIL_ADDRESS>GatewayDomain:
GatewayPassword:
[15:03:23:088] [24350:24351] [DEBUG][com.winpr.sspi] - InitSecurityInterfaceExA
[15:03:23:088] [24350:24351] [TRACE][com.freerdp.core.gateway.ntlm] - InitializeSecurityContext status SEC_I_CONTINUE_NEEDED [0x00090312]
[15:03:23:115] [24350:24351] [TRACE][com.freerdp.core.gateway.ntlm] - InitializeSecurityContext status SEC_E_OK [0x00000000]
[15:03:23:141] [24350:24351] [DEBUG][com.freerdp.core.gateway.rdg] - RDG_OUT_DATA authorization result: 200
[15:03:23:141] [24350:24351] [INFO][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
[15:03:23:141] [24350:24351] [DEBUG][com.freerdp.core] - connecting to peer xxx.xxx.xxx.xxx
[15:03:23:267] [24350:24351] [DEBUG][com.winpr.sspi] - InitSecurityInterfaceExA
[15:03:23:267] [24350:24351] [TRACE][com.freerdp.core.gateway.ntlm] - InitializeSecurityContext status SEC_I_CONTINUE_NEEDED [0x00090312]
[15:03:23:293] [24350:24351] [TRACE][com.freerdp.core.gateway.ntlm] - InitializeSecurityContext status SEC_E_OK [0x00000000]
[15:03:23:331] [24350:24351] [ERROR][com.freerdp.core.gateway.http] - http_response_recv: Retries exceeded
[15:03:23:332] [24350:24351] [ERROR][com.freerdp.core.nego] - Protocol Security Negotiation Failure
[15:03:23:332] [24350:24351] [ERROR][com.freerdp.core] - rdp_client_connect:freerdp_set_last_error_ex ERRCONNECT_SECURITY_NEGO_CONNECT_FAILED [0x0002000C]
[15:03:23:332] [24350:24351] [ERROR][com.freerdp.core.connection] - Error: protocol security negotiation or connection failure

Sometimes the connection does seem to authorise correctly, but then I get the same error about eight minutes.
Of note: I first need to enter my credentials, then I need to approve the connection on my phone with microsoft's authenticator app, then, after quite some time, I'm prompted again by the authenticator app, either nothing happens, or, very rarely, the connection goes through.
To Reproduce
I'm downloading a profile from my employers myapps page:
user@host:~$ WLOG_LEVEL=TRACE xfreerdp ~/profile.rdp
Expected behavior
I expect my remote desktop window to open up :-)
Screenshots
This is FreeRDP version 2.4.1 (2.4.1)
Build configuration: BUILD_TESTING=OFF BUILTIN_CHANNELS=ON HAVE_AIO_H=1 HAVE_EXECINFO_H=1 HAVE_FCNTL_H=1 HAVE_GETLOGIN_R=1 HAVE_INTTYPES_H=1 HAVE_MATH_C99_LONG_DOUBLE=1 HAVE_POLL_H=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK=ON HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL= HAVE_SYSLOG_H=1 HAVE_SYS_EVENTFD_H=1 HAVE_SYS_FILIO_H= HAVE_SYS_MODEM_H= HAVE_SYS_SELECT_H=1 HAVE_SYS_SOCKIO_H= HAVE_SYS_STRTIO_H= HAVE_SYS_TIMERFD_H=1 HAVE_TM_GMTOFF=1 HAVE_UNISTD_H=1 HAVE_XI_TOUCH_CLASS=1 WITH_ALSA=ON WITH_CAIRO=ON WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLANG_FORMAT=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CUPS=ON WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_RDPGFX=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF_AVAILABLE=0 WITH_DEBUG_URBDRC=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_DSP_FFMPEG=ON WITH_EVENTFD_READ_WRITE=1 WITH_FAAC=OFF WITH_FAAD2=OFF WITH_FFMPEG=TRUE WITH_FFMPEG=TRUE WITH_GFX_H264=ON WITH_GPROF=OFF WITH_GSM=OFF WITH_GSSAPI=OFF WITH_ICU=OFF WITH_IPP=OFF WITH_JPEG=ON WITH_LAME=OFF WITH_LIBRARY_VERSIONING=ON WITH_LIBSYSTEMD=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_OPENCL=OFF WITH_OPENH264=OFF WITH_OPENSLES=OFF WITH_OPENSSL=ON WITH_OSS=ON WITH_PAM=ON WITH_PCSC=ON WITH_PROFILER=OFF WITH_PROXY=ON WITH_PROXY_MODULES=OFF WITH_PULSE=ON WITH_SAMPLE=OFF WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY_AVAILABLE=1 WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD_AVAILABLE=1 WITH_SERVER=ON WITH_SERVER_CHANNELS=ON WITH_SERVER_INTERFACE=ON WITH_SHADOW=ON WITH_SMARTCARD_INSPECT=OFF WITH_SOXR=OFF WITH_SSE2=ON WITH_SWSCALE=OFF WITH_THIRD_PARTY=OFF WITH_VAAPI=OFF WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_WAYLAND=ON WITH_WINPR_TOOLS=ON WITH_X11=ON WITH_X264=OFF WITH_XCURSOR=ON WITH_XDAMAGE=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XKBFILE=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XSHM=ON WITH_XTEST=ON WITH_XV=ON WITH_ZLIB=ON
Build type:          Release
CFLAGS:              -O2 -fPIC -fPIC -Wall -Wno-unused-result -Wno-unused-but-set-variable -Wno-deprecated-declarations -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -fno-omit-frame-pointer -DWINPR_DLL
Compiler:            GNU, 11.2.0
Target architecture: x64

Environment (please complete the following information):
This is on Slackware64-current:

... and here's the log where the error occurs about eight minutes after approving the connection in the authenticator app for the second time:
user@host:~$ WLOG_LEVEL=DEBUG xfreerdp ~/profile.rdp
[14:16:12:201] [22595:22595] [DEBUG][com.freerdp.utils] - Registering signal hook...
[14:16:12:204] [22595:22595] [DEBUG][com.freerdp.client.common.cmdline] - windows: 0/0 posix: 0/0 compat: -2002/0
[14:16:12:204] [22595:22595] [DEBUG][com.freerdp.client.common] - This is Build configuration: BUILD_TESTING=OFF BUILTIN_CHANNELS=ON HAVE_AIO_H=1 HAVE_EXECINFO_H=1 HAVE_FCNTL_H=1 HAVE_GETLOGIN_R=1 HAVE_INTTYPES_H=1 HAVE_MATH_C99_LONG_DOUBLE=1 HAVE_POLL_H=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK=ON HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL= HAVE_SYSLOG_H=1 HAVE_SYS_EVENTFD_H=1 HAVE_SYS_FILIO_H= HAVE_SYS_MODEM_H= HAVE_SYS_SELECT_H=1 HAVE_SYS_SOCKIO_H= HAVE_SYS_STRTIO_H= HAVE_SYS_TIMERFD_H=1 HAVE_TM_GMTOFF=1 HAVE_UNISTD_H=1 HAVE_XI_TOUCH_CLASS=1 WITH_ALSA=ON WITH_CAIRO=ON WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLANG_FORMAT=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CUPS=ON WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_RDPGFX=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF_AVAILABLE=0 WITH_DEBUG_URBDRC=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_DSP_FFMPEG=ON WITH_EVENTFD_READ_WRITE=1 WITH_FAAC=OFF WITH_FAAD2=OFF WITH_FFMPEG=TRUE WITH_FFMPEG=TRUE WITH_GFX_H264=ON WITH_GPROF=OFF WITH_GSM=OFF WITH_GSSAPI=OFF WITH_ICU=OFF WITH_IPP=OFF WITH_JPEG=ON WITH_LAME=OFF WITH_LIBRARY_VERSIONING=ON WITH_LIBSYSTEMD=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_OPENCL=OFF WITH_OPENH264=OFF WITH_OPENSLES=OFF WITH_OPENSSL=ON WITH_OSS=ON WITH_PAM=ON WITH_PCSC=ON WITH_PROFILER=OFF WITH_PROXY=ON WITH_PROXY_MODULES=OFF WITH_PULSE=ON WITH_SAMPLE=OFF WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY_AVAILABLE=1 WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD_AVAILABLE=1 WITH_SERVER=ON WITH_SERVER_CHANNELS=ON WITH_SERVER_INTERFACE=ON WITH_SHADOW=ON WITH_SMARTCARD_INSPECT=OFF WITH_SOXR=OFF WITH_SSE2=ON WITH_SWSCALE=OFF WITH_THIRD_PARTY=OFF WITH_VAAPI=OFF WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_WAYLAND=ON WITH_WINPR_TOOLS=ON WITH_X11=ON WITH_X264=OFF WITH_XCURSOR=ON WITH_XDAMAGE=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XKBFILE=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XSHM=ON WITH_XTEST=ON WITH_XV=ON WITH_ZLIB=ON
Build type:          Release
CFLAGS:              -O2 -fPIC -fPIC -Wall -Wno-unused-result -Wno-unused-but-set-variable -Wno-deprecated-declarations -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -fno-omit-frame-pointer -DWINPR_DLL
Compiler:            GNU, 11.2.0
Target architecture: x64

[14:16:12:205] [22595:22596] [INFO][com.freerdp.core] - freerdp_connect:freerdp_set_last_error_ex resetting error state
[14:16:12:205] [22595:22596] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpdr
[14:16:12:205] [22595:22596] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpsnd
[14:16:12:205] [22595:22596] [DEBUG][com.freerdp.channels.drdynvc.client] - VirtualChannelEntryEx
[14:16:12:205] [22595:22596] [INFO][com.freerdp.client.common.cmdline] - loading channelEx drdynvc
[14:16:12:205] [22595:22596] [INFO][com.freerdp.client.x11] - No user name set. - Using login name: user
[14:16:12:209] [22595:22596] [DEBUG][com.freerdp.primitives] - primitives benchmark result:
[14:16:12:366] [22595:22596] [DEBUG][com.freerdp.primitives] -  * generic= 43
[14:16:12:519] [22595:22596] [DEBUG][com.freerdp.primitives] -  * optimized= 89
[14:16:12:519] [22595:22596] [INFO][com.freerdp.primitives] - primitives autodetect, using optimized
[14:16:12:521] [22595:22596] [DEBUG][com.freerdp.core.nego] - Enabling security layer negotiation: TRUE
[14:16:12:521] [22595:22596] [DEBUG][com.freerdp.core.nego] - Enabling restricted admin mode: FALSE
[14:16:12:521] [22595:22596] [DEBUG][com.freerdp.core.nego] - Enabling RDP security: TRUE
[14:16:12:521] [22595:22596] [DEBUG][com.freerdp.core.nego] - Enabling TLS security: TRUE
[14:16:12:521] [22595:22596] [DEBUG][com.freerdp.core.nego] - Enabling NLA security: TRUE
[14:16:12:521] [22595:22596] [DEBUG][com.freerdp.core.nego] - Enabling NLA extended security: FALSE
[14:16:12:521] [22595:22596] [DEBUG][com.freerdp.core.nego] - state: NEGO_STATE_NLA
[14:16:12:521] [22595:22596] [DEBUG][com.freerdp.core.nego] - Attempting NLA security
[14:16:12:529] [22595:22596] [INFO][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
[14:16:12:529] [22595:22596] [DEBUG][com.freerdp.core] - connecting to peer xxx.xxx.xxx.xxx
GatewayUsername<EMAIL_ADDRESS>GatewayDomain:
GatewayPassword:
[14:16:28:942] [22595:22596] [DEBUG][com.winpr.sspi] - InitSecurityInterfaceExA
[14:16:28:988] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - RDG_OUT_DATA authorization result: 200
[14:16:28:988] [22595:22596] [INFO][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
[14:16:28:988] [22595:22596] [DEBUG][com.freerdp.core] - connecting to peer xxx.xxx.xxx.xxx
[14:16:28:065] [22595:22596] [DEBUG][com.winpr.sspi] - InitSecurityInterfaceExA
[14:16:28:106] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - RDG_IN_DATA authorization result: 200
[14:16:28:127] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - Handshake response received
[14:16:28:127] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - errorCode=RPC_S_OK, verMajor=1, verMinor=0, serverVersion=0, extendedAuth=HTTP_EXTENDED_AUTH_SC|HTTP_EXTENDED_AUTH_PAA|HTTP_EXTENDED_AUTH_SSPI_NTLM [0007]
[14:16:28:147] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - Tunnel response received
[14:16:28:147] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - serverVersion=0, errorCode=RPC_S_OK, fieldsPresent=HTTP_TUNNEL_RESPONSE_FIELD_TUNNEL_ID|HTTP_TUNNEL_RESPONSE_FIELD_CAPS|| [0003]
[14:16:28:147] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - capabilities=HTTP_CAPABILITY_TYPE_QUAR_SOH||HTTP_CAPABILITY_MESSAGING_CONSENT_SIGN|HTTP_CAPABILITY_MESSAGING_SERVICE_MSG|| [000d]
[14:16:41:533] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - Tunnel authorization received
[14:16:41:533] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - errorCode=RPC_S_OK, fieldsPresent=HTTP_TUNNEL_AUTH_RESPONSE_FIELD_REDIR_FLAGS|HTTP_TUNNEL_AUTH_RESPONSE_FIELD_IDLE_TIMEOUT| [0003]
[14:16:41:563] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - Channel response received
[14:16:41:563] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - channel response errorCode=RPC_S_OK, fieldsPresent=HTTP_CHANNEL_RESPONSE_FIELD_CHANNELID||HTTP_CHANNEL_RESPONSE_FIELD_UDPPORT [0005]
[14:16:41:563] [22595:22596] [DEBUG][com.freerdp.core.nego] - Adding terminating CRLF to routing token
[14:16:41:563] [22595:22596] [DEBUG][com.freerdp.core.nego] - RequestedProtocols: 3
[14:16:41:609] [22595:22596] [DEBUG][com.freerdp.core.nego] - RDP_NEG_RSP
[14:16:41:609] [22595:22596] [DEBUG][com.freerdp.core.nego] - selected_protocol: 2
[14:16:41:609] [22595:22596] [DEBUG][com.freerdp.core.nego] - state: NEGO_STATE_FINAL
[14:16:41:609] [22595:22596] [DEBUG][com.freerdp.core.nego] - Negotiated NLA security
[14:16:41:609] [22595:22596] [DEBUG][com.freerdp.core.nego] - nego_security_connect with PROTOCOL_HYBRID
[14:16:42:670] [22595:22596] [DEBUG][com.winpr.sspi] - InitSecurityInterfaceExA
[14:16:42:670] [22595:22596] [DEBUG][com.freerdp.core.nla] - nla_client_init 411 : packageName=Negotiate ; cbMaxToken=12256
[14:16:42:670] [22595:22596] [DEBUG][com.freerdp.core.nla] - Client: Sending Authentication Token
[14:16:42:670] [22595:22596] [DEBUG][com.freerdp.core.nla] - NLA.negoToken (length = 40):
[14:16:42:770] [22595:22596] [DEBUG][com.freerdp.core.nla] - CredSSP protocol support 6, peer supports 6
[14:16:42:770] [22595:22596] [DEBUG][com.freerdp.core.nla] - Client: Sending Authentication Token
[14:16:42:770] [22595:22596] [DEBUG][com.freerdp.core.nla] - NLA.negoToken (length = 472):
[14:16:42:770] [22595:22596] [DEBUG][com.freerdp.core.nla] - NLA.pubKeyAuth (length = 48):
[14:16:42:871] [22595:22596] [DEBUG][com.freerdp.core.nla] - Client: Sending PubKeyAuth Token
[14:16:42:871] [22595:22596] [DEBUG][com.freerdp.core.nla] - NLA.authInfo (length = 103):
[14:16:42:971] [22595:22596] [DEBUG][com.freerdp.core.gcc] - Server rdp encryption method: NONE
[14:16:43:673] [22595:22596] [DEBUG][com.freerdp.core.info] - Client Info Packet Flags = INFO_MOUSE|INFO_DISABLECTRLALTDEL|INFO_UNICODE|INFO_MAXIMIZESHELL|INFO_LOGONNOTIFY|INFO_COMPRESSION|INFO_ENABLEWINDOWSKEY|INFO_FORCE_ENCRYPTED_CS_PDU|INFO_LOGONERRORS|INFO_MOUSE_HAS_WHEEL|INFO_NOAUDIOPLAYBACK
[14:16:43:674] [22595:22596] [DEBUG][com.winpr.timezone] - tz: Bias=-60 sn='W. Europe Standard Time' dln='W. Europe Daylight Time'
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] - flags: 0x0400, redirFlags: 0x00000B0D length: 194, sessionID: 0xE83524B5
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] - redirectionFlags = {
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] -    LB_TARGET_NET_ADDRESS
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] -    LB_USERNAME
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] -    LB_DOMAIN
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] -    LB_TARGET_FQDN
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] -    LB_TARGET_NETBIOS_NAME
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] -    LB_TARGET_NET_ADDRESSES
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] - }
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] - Username: rdpuser
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] - Domain: DOMAIN
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] - TargetFQDN: rdphost.example.com
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] - TargetNetBiosName: RDP-HOST
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] - TargetNetAddressesCount: 1
[14:16:43:076] [22595:22596] [DEBUG][com.freerdp.core.redirection] - TargetNetAddresses[0]: yyy.yyy.yyy.yyy.
[14:16:43:080] [22595:22596] [DEBUG][com.freerdp.core.nego] - Enabling security layer negotiation: TRUE
[14:16:43:080] [22595:22596] [DEBUG][com.freerdp.core.nego] - Enabling restricted admin mode: FALSE
[14:16:43:080] [22595:22596] [DEBUG][com.freerdp.core.nego] - Enabling RDP security: TRUE
[14:16:43:080] [22595:22596] [DEBUG][com.freerdp.core.nego] - Enabling TLS security: TRUE
[14:16:43:080] [22595:22596] [DEBUG][com.freerdp.core.nego] - Enabling NLA security: TRUE
[14:16:43:080] [22595:22596] [DEBUG][com.freerdp.core.nego] - Enabling NLA extended security: FALSE
[14:16:43:080] [22595:22596] [DEBUG][com.freerdp.core.nego] - state: NEGO_STATE_NLA
[14:16:43:080] [22595:22596] [DEBUG][com.freerdp.core.nego] - Attempting NLA security
[14:16:43:084] [22595:22596] [INFO][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
[14:16:43:084] [22595:22596] [DEBUG][com.freerdp.core] - connecting to peer xxx.xxx.xxx.xxx
[14:16:43:178] [22595:22596] [DEBUG][com.winpr.sspi] - InitSecurityInterfaceExA
[14:16:43:220] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - RDG_OUT_DATA authorization result: 200
[14:16:43:221] [22595:22596] [INFO][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
[14:16:43:221] [22595:22596] [DEBUG][com.freerdp.core] - connecting to peer xxx.xxx.xxx.xxx
[14:16:43:291] [22595:22596] [DEBUG][com.winpr.sspi] - InitSecurityInterfaceExA
[14:16:43:343] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - RDG_IN_DATA authorization result: 200
[14:16:43:394] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - Handshake response received
[14:16:43:394] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - errorCode=RPC_S_OK, verMajor=1, verMinor=0, serverVersion=0, extendedAuth=HTTP_EXTENDED_AUTH_SC|HTTP_EXTENDED_AUTH_PAA|HTTP_EXTENDED_AUTH_SSPI_NTLM [0007]
[14:16:43:455] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - Tunnel response received
[14:16:43:455] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - serverVersion=0, errorCode=RPC_S_OK, fieldsPresent=HTTP_TUNNEL_RESPONSE_FIELD_TUNNEL_ID|HTTP_TUNNEL_RESPONSE_FIELD_CAPS|| [0003]
[14:16:43:455] [22595:22596] [DEBUG][com.freerdp.core.gateway.rdg] - capabilities=HTTP_CAPABILITY_TYPE_QUAR_SOH||HTTP_CAPABILITY_MESSAGING_CONSENT_SIGN|HTTP_CAPABILITY_MESSAGING_SERVICE_MSG|| [000d]
[14:24:50:603] [22595:22596] [ERROR][com.freerdp.core.nego] - Protocol Security Negotiation Failure
[14:24:50:603] [22595:22596] [ERROR][com.freerdp.core] - rdp_client_connect:freerdp_set_last_error_ex ERRCONNECT_SECURITY_NEGO_CONNECT_FAILED [0x0002000C]
[14:24:50:603] [22595:22596] [ERROR][com.freerdp.core.connection] - Error: protocol security negotiation or connection failure

We're still experiencing the problem I reported in #5937 with FreeRDP 2.4.1, so I'm interested in this.
I never had the patience to retry the connection attempt 20-30 times before, but when I did that today, it still never connected.
For us, the work around is to change the gateway transport from http to rpc using /gt:rpc on the command line.  Does that help for your case?

I read that, so I tried that as well, but it failed pretty soon:
user@host:~$ WLOG_LEVEL=TRACE xfreerdp ~/profile.rdp /gt:rpc
[14:46:58:129] [23641:23641] [DEBUG][com.freerdp.utils] - Registering signal hook...
[14:46:58:132] [23641:23641] [DEBUG][com.freerdp.client.common.cmdline] - windows: 0/1 posix: -1000/0 compat: -1000/0
[14:46:58:133] [23641:23641] [DEBUG][com.freerdp.client.common] - This is Build configuration: BUILD_TESTING=OFF BUILTIN_CHANNELS=ON HAVE_AIO_H=1 HAVE_EXECINFO_H=1 HAVE_FCNTL_H=1 HAVE_GETLOGIN_R=1 HAVE_INTTYPES_H=1 HAVE_MATH_C99_LONG_DOUBLE=1 HAVE_POLL_H=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK=ON HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL= HAVE_SYSLOG_H=1 HAVE_SYS_EVENTFD_H=1 HAVE_SYS_FILIO_H= HAVE_SYS_MODEM_H= HAVE_SYS_SELECT_H=1 HAVE_SYS_SOCKIO_H= HAVE_SYS_STRTIO_H= HAVE_SYS_TIMERFD_H=1 HAVE_TM_GMTOFF=1 HAVE_UNISTD_H=1 HAVE_XI_TOUCH_CLASS=1 WITH_ALSA=ON WITH_CAIRO=ON WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLANG_FORMAT=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CUPS=ON WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_RDPGFX=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF_AVAILABLE=0 WITH_DEBUG_URBDRC=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_DSP_FFMPEG=ON WITH_EVENTFD_READ_WRITE=1 WITH_FAAC=OFF WITH_FAAD2=OFF WITH_FFMPEG=TRUE WITH_FFMPEG=TRUE WITH_GFX_H264=ON WITH_GPROF=OFF WITH_GSM=OFF WITH_GSSAPI=OFF WITH_ICU=OFF WITH_IPP=OFF WITH_JPEG=ON WITH_LAME=OFF WITH_LIBRARY_VERSIONING=ON WITH_LIBSYSTEMD=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_OPENCL=OFF WITH_OPENH264=OFF WITH_OPENSLES=OFF WITH_OPENSSL=ON WITH_OSS=ON WITH_PAM=ON WITH_PCSC=ON WITH_PROFILER=OFF WITH_PROXY=ON WITH_PROXY_MODULES=OFF WITH_PULSE=ON WITH_SAMPLE=OFF WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY_AVAILABLE=1 WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD_AVAILABLE=1 WITH_SERVER=ON WITH_SERVER_CHANNELS=ON WITH_SERVER_INTERFACE=ON WITH_SHADOW=ON WITH_SMARTCARD_INSPECT=OFF WITH_SOXR=OFF WITH_SSE2=ON WITH_SWSCALE=OFF WITH_THIRD_PARTY=OFF WITH_VAAPI=OFF WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_WAYLAND=ON WITH_WINPR_TOOLS=ON WITH_X11=ON WITH_X264=OFF WITH_XCURSOR=ON WITH_XDAMAGE=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XKBFILE=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XSHM=ON WITH_XTEST=ON WITH_XV=ON WITH_ZLIB=ON
Build type:          Release
CFLAGS:              -O2 -fPIC -fPIC -Wall -Wno-unused-result -Wno-unused-but-set-variable -Wno-deprecated-declarations -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -fno-omit-frame-pointer -DWINPR_DLL
Compiler:            GNU, 11.2.0
Target architecture: x64

[14:46:58:133] [23641:23642] [INFO][com.freerdp.core] - freerdp_connect:freerdp_set_last_error_ex resetting error state
[14:46:58:133] [23641:23642] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpdr
[14:46:58:133] [23641:23642] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpsnd
[14:46:58:133] [23641:23642] [DEBUG][com.freerdp.channels.drdynvc.client] - VirtualChannelEntryEx
[14:46:58:133] [23641:23642] [INFO][com.freerdp.client.common.cmdline] - loading channelEx drdynvc
[14:46:58:133] [23641:23642] [INFO][com.freerdp.client.x11] - No user name set. - Using login name: user
[14:46:58:138] [23641:23642] [DEBUG][com.freerdp.primitives] - primitives benchmark result:
[14:46:58:296] [23641:23642] [DEBUG][com.freerdp.primitives] -  * generic= 37
[14:46:58:449] [23641:23642] [DEBUG][com.freerdp.primitives] -  * optimized= 80
[14:46:58:449] [23641:23642] [INFO][com.freerdp.primitives] - primitives autodetect, using optimized
[14:46:58:451] [23641:23642] [DEBUG][com.freerdp.core.nego] - Enabling security layer negotiation: TRUE
[14:46:58:451] [23641:23642] [DEBUG][com.freerdp.core.nego] - Enabling restricted admin mode: FALSE
[14:46:58:451] [23641:23642] [DEBUG][com.freerdp.core.nego] - Enabling RDP security: TRUE
[14:46:58:451] [23641:23642] [DEBUG][com.freerdp.core.nego] - Enabling TLS security: TRUE
[14:46:58:451] [23641:23642] [DEBUG][com.freerdp.core.nego] - Enabling NLA security: TRUE
[14:46:58:451] [23641:23642] [DEBUG][com.freerdp.core.nego] - Enabling NLA extended security: FALSE
[14:46:58:451] [23641:23642] [DEBUG][com.freerdp.core.nego] - state: NEGO_STATE_NLA
[14:46:58:451] [23641:23642] [DEBUG][com.freerdp.core.nego] - Attempting NLA security
[14:46:58:470] [23641:23642] [INFO][com.freerdp.core] - transport_connect:freerdp_set_last_error_ex resetting error state
[14:46:58:470] [23641:23642] [DEBUG][com.freerdp.core.gateway.rpc] - VIRTUAL_CONNECTION_STATE_INITIAL
[14:46:58:470] [23641:23642] [INFO][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
[14:46:58:470] [23641:23642] [DEBUG][com.freerdp.core] - connecting to peer xxx.xxx.xxx.xxx
[14:46:58:558] [23641:23642] [DEBUG][com.freerdp.core.gateway.rpc] - CLIENT_IN_CHANNEL_STATE_CONNECTED
GatewayUsername<EMAIL_ADDRESS>GatewayDomain:
GatewayPassword:
[14:47:08:558] [23641:23642] [DEBUG][com.winpr.sspi] - InitSecurityInterfaceExA
[14:47:08:558] [23641:23642] [TRACE][com.freerdp.core.gateway.ntlm] - InitializeSecurityContext status SEC_I_CONTINUE_NEEDED [0x00090312]
[14:47:08:558] [23641:23642] [DEBUG][com.freerdp.core.gateway.rpc] - CLIENT_IN_CHANNEL_STATE_SECURITY
[14:47:08:559] [23641:23642] [INFO][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
[14:47:08:559] [23641:23642] [DEBUG][com.freerdp.core] - connecting to peer xxx.xxx.xxx.xxx
[14:47:08:636] [23641:23642] [DEBUG][com.freerdp.core.gateway.rpc] - CLIENT_OUT_CHANNEL_STATE_CONNECTED
[14:47:08:636] [23641:23642] [DEBUG][com.winpr.sspi] - InitSecurityInterfaceExA
[14:47:08:636] [23641:23642] [TRACE][com.freerdp.core.gateway.ntlm] - InitializeSecurityContext status SEC_I_CONTINUE_NEEDED [0x00090312]
[14:47:08:636] [23641:23642] [DEBUG][com.freerdp.core.gateway.rpc] - CLIENT_OUT_CHANNEL_STATE_SECURITY
[14:47:08:636] [23641:23642] [TRACE][com.freerdp.core.gateway.ntlm] - InitializeSecurityContext status SEC_E_OK [0x00000000]
[14:47:08:637] [23641:23642] [DEBUG][com.freerdp.core.gateway.rpc] - CLIENT_IN_CHANNEL_STATE_NEGOTIATED
[14:47:08:637] [23641:23642] [DEBUG][com.freerdp.core.gateway.rts] - Sending CONN/B1 RTS PDU
[14:47:08:637] [23641:23642] [DEBUG][com.freerdp.core.gateway.rpc] - CLIENT_IN_CHANNEL_STATE_OPENED
[14:47:09:653] [23641:23642] [TRACE][com.freerdp.core.gateway.ntlm] - InitializeSecurityContext status SEC_E_OK [0x00000000]
[14:47:09:653] [23641:23642] [DEBUG][com.freerdp.core.gateway.rpc] - CLIENT_OUT_CHANNEL_STATE_NEGOTIATED
[14:47:09:653] [23641:23642] [DEBUG][com.freerdp.core.gateway.rts] - Sending CONN/A1 RTS PDU
[14:47:09:653] [23641:23642] [DEBUG][com.freerdp.core.gateway.rpc] - CLIENT_OUT_CHANNEL_STATE_OPENED
[14:47:09:653] [23641:23642] [DEBUG][com.freerdp.core.gateway.rpc] - VIRTUAL_CONNECTION_STATE_OUT_CHANNEL_WAIT
[14:47:09:711] [23641:23642] [ERROR][com.freerdp.core.gateway.rpc] - error! Status Code: 302
[14:47:09:711] [23641:23642] [ERROR][com.freerdp.core.gateway.http] - HTTP/1.1 302 Redirect
[14:47:09:711] [23641:23642] [ERROR][com.freerdp.core.gateway.http] - Content-Type: text/html; charset=UTF-8
[14:47:09:711] [23641:23642] [ERROR][com.freerdp.core.gateway.http] - Location: https://myapps.eur.nl/rdweb
[14:47:09:711] [23641:23642] [ERROR][com.freerdp.core.gateway.http] - Persistent-Auth: true
[14:47:09:711] [23641:23642] [ERROR][com.freerdp.core.gateway.http] - X-Frame-Options: SAMEORIGIN
[14:47:09:711] [23641:23642] [ERROR][com.freerdp.core.gateway.http] - Date: Tue, 14 Dec 2021 13:47:08 GMT
[14:47:09:711] [23641:23642] [ERROR][com.freerdp.core.gateway.http] - Content-Length: 150
[14:47:09:711] [23641:23642] [ERROR][com.freerdp.core.gateway.tsg] - tsg_check failure
[14:47:09:712] [23641:23642] [ERROR][com.freerdp.core.nego] - Protocol Security Negotiation Failure
[14:47:09:712] [23641:23642] [ERROR][com.freerdp.core] - rdp_client_connect:freerdp_set_last_error_ex ERRCONNECT_SECURITY_NEGO_CONNECT_FAILED [0x0002000C]
[14:47:09:712] [23641:23642] [ERROR][com.freerdp.core.connection] - Error: protocol security negotiation or connection failure

Interesting.  Looks like your server is redirecting rpc to the http transport though I could be misinterpreting the log data.

@PJBrs can you get server side logs by any chance?
This looks like perfectly sound from a protocol point of view, but something policy wise is not met. (Maybe some custom/new/... HTTP option, ...)

@akallabeth They're probably confidential. But I'll send an email to my employer's service desk and see what happens.
What I can do, is test patches and compiler settings, etc. I'm not very tech-savvy, but compiling from source is easy for me by now, as is applying patches and such.

One more comment - my connection finally went through for once! Too busy to catch a log, but the next time I will. I did notice one thing though, my wifi connection wasn't going all too well, my desktop and email were crawling, and in my terminal I saw the FreeRDP connection trace slowly pass by. I can't escape the impression that FreeRDP normally goes too fast for my server, and that by being artificially slowed down, the authentication process was somehow smoothed out. Just a hunch...

@akallabeth I'm afraid that my employer do not have the time to help unearth server-side logs... Please let me know if there's anything else I can do. I did fiddle a bit with the timeout option, but didn't find anything that worked.

I am also having a similar issue in an environment that is using Microsoft Azure MFA with the NPS extension.  I can confirm that if I disable the MFA requirements my connection works but the moment the MFA requirement is turned on it breaks.
What server side logs would you need?

@johnshelton sorry for the delay.
I´d be interested in the connection/disconnect requests (and anything that is error/warning) you get. (I assume a gateway is required in this setup?)
It might be something simple like a connection timeout due to MFA and the client reconnecting (and the server dropping this attempt) or something more complicated, but can´t tell without some data.

@akallabeth I will see what logs I can pull for you.  I am using a Gateway with a pair of Connection Brokers in HA.  I do know that as part of the MFA implementation I have to extend the default time outs to between 30-60 seconds as there is a delay while waiting for the MFA process to complete.  (about halfway down https://docs.microsoft.com/en-us/azure/active-directory/authentication/howto-mfa-nps-extension-rdg ).  Is there a place to adjust the timeout for FreeRDP?

@johnshelton That is a starting point.
You can adjust the TCP timeout with /timeout:<time in ms> argument, but I think it does not influence the gateway related stuff (need to dig into code to verify, that was a long time ago)

@akallabeth Still fighting with this. I found that on the Connection Broker I am getting the following events under TerminalServices-SessionBroker -- Operational when coming from the HP ThinPro OS.
Event ID 800: RD Connection Broker received connection request for user <USER>.
Hints in the RDP file (TSV URL) = tsv://MS Terminal Services Plugin.1.Full_Desktop
Initial Application = NULL
Call came from Redirector Server = ..com
Redirector is configured as Virtual machine redirector
Then we get Event ID 801: RD Connection Broker successfully processed the connection request for user <USER>. Redirection info:
Target Name =
Target IP Address =
Target Netbios =
Target FQDN =
Disconnected Session Found = 0x1
Then after 5 mins we get Event ID: 819: This connection request has timed out. User could not log on to the end point within the alloted time. Remote Desktop Connection Broker will stop monitoring this connection request.
If I use the same user account but use a Windows/Mac/iOS device I am able to connect just fine. After the Event ID 801 I get Event ID 787 showing that the session has been created and added to the database.
I also found that in TerminalServices-SessionBroker-Client -- Operational that when connecting from the ThinPro I get EventID 1301:
Remote Desktop Connection Broker Client received request for redirection.
User : <USER>
RDP Client Version : 3
When I connect from my Mac using Microsoft's RDP Client it shows using RDP Client Version: 5
Any other thoughts?

We are also experiencing the same issue, we posted our issue on this page https://docs.microsoft.com/en-us/answers/questions/716557/mfa-with-nps-extension-for-linux-based-thinclient.html. But its similar to this one.
We noticed that a couple of scenario's work, but one specific doesn't and it looks like it has something to do with double authentication when using freerdp.

RDP direct to broker = Working
RDP via gateway to broker without MFA = Working
RDP via gateway to broker with MFA = Working
RDP via gateway through broker to RDSH without MFA = Working
RDP via gateway through broker to RDSH with MFA = Not working

When I wait for about 10 seconds, it is working.

My employer switched to a different authentication mechanism, I needed to update to 3.0.0-beta2 to make that work. (I also tried 3.0.0-beta4, but that one wouldn't connect :-( ). In any case, I can no longer verify fixes for this bug... Perhaps it might be better to just close it?

I have really no idea how to fix this, however, I can test things if needed.
In the latest version of Remmina on Pop_OS (with xfreerdp updated to the latest as well) I've stumbled upon the same issue and @josvlict helped me in the direction that got me logged on the RDS environment with waiting between every authentication step (fill in username / password, 10 second wait, accept first MFA challenge, 10 second wait, accept second MFA challenge, 10 second wait, fill in 2nd time username / password, 10 second wait, accept third MFA challenge, after 5 - 10 seconds my virtual desktop loads).
It got me thinking that a few years ago colleague's who were using a Mac book were complaining about this as well when we migrated to SSO on Azure AD with MFA for our Forti VPN client as well. They told me those days that a lot of the time the credentials weren't working. However, when they waited a few seconds after filling in their creds before approving the MFA challenge, their auth request was successful. Feels a bit like the same issue...
Fortunately I've got administrative rights on the RDS side as well but I'm not really familiar with large deployments (we host a few 1000 desktops). I think it is all about the MFA timeouts. Also admin rights on the Azure AD/MFA side and on my local system (Pop_OS based on Ubuntu 22.04 LTS)

this sounds a lot like too tight timeouts/ddos detection.
FreeRDP does gateway auth slightly different from mstsc so it might just be these few extra messages that trigger that.
(we do auth for both, in and out channel, mstsc only for one and uses the same auth for both)
so, while not really familiar with the configuration, you might check the timeout between authentication attempts and ensure you can do a few attempts (>2) in short succession, then that might be all that is required.


Remove cordova-progressindicator and switch to cordova-activityindicator

I've had to fork pbernasconi/cordova-progressIndicator to Justin-Credible/cordova-progressIndicator with the following changes:

Remove demo files whose paths were too long for Windows
Fix a crash on iOS

Unfortunately, my pull requests have not been accepted. I don't want to maintain my own version of this repo, so I will be removing it and switching to Crypho/cordova-activityindicator.
An added bonus here is that this new plugin supports Android, while the previous plugin did not.

As a side note, also test the scenario where multiple HTTP blocking requests go out at the same time. Currently, on iOS, this results in the indicator being hidden too quickly. This workaround can be used, but may not be needed with the new plugin:
// HttpInterceptor.ts in handleRequestStart()

// If this wasn't the first blocking HTTP request, we need to hide the previous
// blocking progress indicator before we show the new one on iOS because the iOS
// plugin will create a new instance and hide only operates on the last instance.
// If we don't do this here, it will result in being unable to hide progress
// indicators when multiple are shown.
if (this.Utilities.isIos && this.blockingRequestsInProgress > 1) {
    this.UiHelper.progressIndicator.hide();
}


setns binding

Why this was closed? There is no setns bindings for rust :(

@matklad unknown. Do you want to try to take this and submit a new PR? I'm not sure why the CloneFlags type has been changed. Could you check?

Do you want to try to take this and submit a new PR?

Unfortunatelly I am too busy at the moment


Add the Missing Descriptions of the File Module in API Docs

Description:
We need to add the below missing descriptions of the File Module in API Docs.
https://ballerina.io/v1-1/learn/api-docs/ballerina/file/objects/FileInfo.html (Constructor)
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Fixed via https://github.com/ballerina-platform/ballerina-lang/pull/21594.

Reopening as https://github.com/ballerina-platform/ballerina-lang/pull/21722 has sent the fix to the "master" branch and we need to send the fix to the "stage" branch to add it to the 1.2 release.

The fixes in this are sent to the "stage" branch for the Ballerina 1.2 release via https://github.com/ballerina-platform/ballerina-lang/pull/21897.


Network performance measurement: Implementing worker using CRD

What type of PR is this?
/kind feature

What this PR does / why we need it:
In the current implementation of network performance measurement, controller and worker communicates with each other using http, this change is for making the controller and worker communicate using custom resources. This PR contains the changes for worker portion.
Which issue(s) this PR fixes:

Fixes #1631
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/ok-to-test
This looks great - it's pretty close to mergable state. Thanks!

/ok-to-test
This looks great - it's pretty close to mergable state. Thanks!

LGTM
@VivekThrivikraman-est - please squash and I will approve

/lgtm
/approve


Fill MR with project metadata in stackdriver log adapter

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bianpengyuan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mandarjog
Assign the PR to them by writing /assign @mandarjog in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bianpengyuan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
678a0f5c2c9f5fc9e7c092e7c0cc8b940b885c32
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid Please take a look.

@bianpengyuan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
4715f85eb738a155bdc7449dffd24202963a850d
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bianpengyuan, douglas-reid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [douglas-reid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bianpengyuan, douglas-reid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [douglas-reid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
4715f85eb738a155bdc7449dffd24202963a850d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
4715f85eb738a155bdc7449dffd24202963a850d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
4715f85eb738a155bdc7449dffd24202963a850d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
4715f85eb738a155bdc7449dffd24202963a850d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-simple

prow/istio-pilot-e2e.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-simple

prow/istio-pilot-e2e.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-simple

prow/istio-pilot-e2e.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-simple

prow/istio-pilot-e2e.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e

prow/istio-presubmit.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@bianpengyuan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
2bf0020f1c40385ceab9e04258fa9760317895b7
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[Feature] Update for compiling

Is there an existing feature request for this?

[X] I have searched the existing issues

Describe the Feature
When starting on a brand-new schema, dbt compile fails, most likely due to this line. Possible solution is changing the relation on that line from a ref to a source.
Describe alternatives you've considered
No response
Are you interested in contributing this feature?

[X] Yes.
[ ] Yes, but I will need assistance and will schedule time during your office hours for guidance.
[ ] No.

Anything else?
No response

Closing this issue as it was effectively resolved in v0.11.0. Tested compiling today on a new schema, and works just fine!


some patches to support kernel 5.10

These patches can support 5.10, but only in part. See commit logs for details.

Figure out what $(OBJCOPYFLAGS_$(@F)) is for. The rest of the patches LGTM.

The "@F" variant returns only the file portion of the filename representing the target, for example, the target is kernel/sched/core.o, @F will return the core.o. The OBJCOPYFLAGS_$(@F) specifies some objcopy flag of a specific target file. In the scheduler module, all of them(OBJCOPYFLAGS_$(@F)) is null.


improve ut cases for package contrib/drivers/mysql

Codecov Report
Base: 76.57% // Head: 76.56% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (d03c7a7) compared to base (2598745).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2216      +/-   ##
==========================================
- Coverage   76.57%   76.56%   -0.02%
==========================================
  Files         580      580
  Lines       48272    48272
==========================================
- Hits        36964    36958       -6
- Misses       9291     9297       +6
  Partials     2017     2017

Flag
Coverage Δ

go-1.15-386
76.56% <ø> (-0.03%)
:arrow_down:

go-1.15-amd64
76.57% <ø> (-0.02%)
:arrow_down:

go-1.16-386
76.58% <ø> (-0.03%)
:arrow_down:

go-1.16-amd64
76.58% <ø> (-0.02%)
:arrow_down:

go-1.17-386
76.58% <ø> (-0.01%)
:arrow_down:

go-1.17-amd64
?

go-1.18-386
?

go-1.18-amd64
76.50% <ø> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

os/gfsnotify/gfsnotify_watcher.go
81.51% <0.00%> (-2.53%)
:arrow_down:

database/gdb/gdb.go
64.46% <0.00%> (-1.53%)
:arrow_down:

database/gdb/gdb_core_structure.go
68.85% <0.00%> (-0.88%)
:arrow_down:

os/gcmd/gcmd_parser.go
92.19% <0.00%> (-0.71%)
:arrow_down:

contrib/drivers/mysql/mysql.go
69.38% <0.00%> (ø)

os/glog/glog_logger_rotate.go
64.70% <0.00%> (+1.35%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Trust HTTPS certificate on SLES

Add instructions to trust HTTPS certificate on RHEL
SLES version of:

[ ]  Ubuntu trust the certificate for service-to-service communication
[ ] Trust HTTPS certificate on Linux using Edge or Chrome
[ ] Trust the certificate with Firefox on Linux

Partial instructions here
related #28278
parent: #27603

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c7ddfb2f-5dea-5e31-2a27-02a4dc16104c
Version Independent ID: 12ca0b9a-2638-a4ce-c45f-d4579c83dafb
Content: Enforce HTTPS in ASP.NET Core
Content Source: aspnetcore/security/enforcing-ssl.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Associated WorkItem - 62256

See #32842

@djgalvan  would you be able to help on this?
The SLES instructions are commented out as they are a copy of the RHEL instructions. I have a SLES anyone testing this can use.
cc @selvinfehric if you're interested.

@Rick-Anderson I can spend some time on it over the week. I spent some time on it and recorded coverage in the parent issue. SLES documentation will involve adjusting the package manager from dnf to zypper and the package-dependency naming. @selvinfehric It's up for grabs if you'd like, I've got safety meetings to attend through the week so I'd be helping after hours.

@djgalvan no hurry and any help appreciated.

Rick, I had submitted some changes using the web interface the morning after, I'm not seeing it anywhere. I'll check it out and try again some time this week.

@djgalvan no PR was created. Hopefully you still have the changes.

No, I did it in the browser. I must be missing a second prompt/confirmation, second time it's gotten me lol. It didn't take long, I'll go over it again.

Just change one character and do a PR, then it's saved and you can edit the file in the browser.


Update Composer dependencies (2022-01-29-00-08)

Visual regression test passed!
View the visual regression test report


fix(Combobox): render optimization

This is not done, but it has boosted performance. We still need to investigate how we can make the first render fater.
Subsequent renders are behaving better, though.
Related to, but does not finish #1765 #1516
See the "thousand of options" story, which has virtualization enabled. You can try disabling this as well.

Combined the calculation of optionsChildren and customIds - These both ran Children.toArray.
Added lookup for selectedValues to remove the use of .some().
Made options and selectedOptions an object, so we can look up with keys.
activeDescendant is now set by floating-ui's list navigation.
floating-ui now handles changing activeIndex when using arrow keys.
Added a higher context for activeIndex, since this was causing a re-render of everything when it changed.
Virtualization does not re-render everything on scroll anymore.
Added a missing test for pressing Enter on an item.
Added more hook to separate concerns.
Tweaked how we do filtering
Resolves #1860

Fixed by updating options checks to equal or greater than 0

Removed deprecated prop cleanButtonLabel
Remove focus state from ComboboxInput, solve this with css
Rework how value changing works, remove effect, everything now runs through one function

Note to self, found a bug with multiple select where closing dropdown with ESC key and typing again, no dropdown showed up in accordance with search value.


Cxzk add shell

This adds a converted version of the shell scripting guidelines that were developed internally on Confluence.
(It includes the foreword, principles and specific guidelines, but not the plan for the migration of legacy scripts, which will be a separate live working document as the migration proceeds, and does not form part of the guidelines themselves.)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Panic on Changing set_dst_pan_id Value in Packet Creation Example

Hello,
I encountered a panic when modifying the set_dst_pan_id value in the following packet creation example:
use dot15d4_frame::*;

fn main() {
    let frame = FrameBuilder::new_data(&[0x2b, 0x00, 0x00, 0x00])
        .set_sequence_number(1)
        .set_dst_pan_id(0xabcd)
        .set_dst_address(Address::Short([0x02, 0x04]))
        .set_src_pan_id(0xabcd)
        .set_src_address(Address::Extended([
            0x00, 0x12, 0x4b, 0x00, 0x14, 0xb5, 0xd9, 0xc7,
        ]))
        .finalize()
        .unwrap();

    let mut buffer = vec![0; frame.buffer_len()];

    frame.emit(&mut Frame::new_unchecked(&mut buffer[..]));

    println!("{:?}", frame);
    println!("packet = {:#04X?}", buffer);
}

This works fine and prints the packet as expected. However, if I change set_dst_pan_id to 0xabce, the program panics with the following error:
thread 'main' panicked at /home/aebrahimi/Projects/dot15d4/dot15d4-frame/src/lib.rs:469:40:
source slice length (4) does not match destination slice length (2)
stack backtrace:
   0: rust_begin_unwind
             at /builddir/build/BUILD/rust-1.83.0-build/rustc-1.83.0-src/library/std/src/panicking.rs:665:5
   1: core::panicking::panic_fmt
             at /builddir/build/BUILD/rust-1.83.0-build/rustc-1.83.0-src/library/core/src/panicking.rs:74:14
   2: core::slice::<impl [T]>::copy_from_slice::len_mismatch_fail
             at /builddir/build/BUILD/rust-1.83.0-build/rustc-1.83.0-src/library/core/src/slice/mod.rs:3685:13
   3: core::slice::<impl [T]>::copy_from_slice
             at /builddir/build/BUILD/rust-1.83.0-build/rustc-1.83.0-src/library/core/src/slice/mod.rs:3692:13
   4: dot15d4_frame::Frame<T>::set_payload
             at /home/aebrahimi/Projects/dot15d4/dot15d4-frame/src/lib.rs:469:9
   5: dot15d4_frame::repr::FrameRepr::emit
             at /home/aebrahimi/Projects/dot15d4/dot15d4-frame/src/repr/mod.rs:93:13
   6: test_app::main
             at ./src/main.rs:16:5
   7: core::ops::function::FnOnce::call_once
             at /builddir/build/BUILD/rust-1.83.0-build/rustc-1.83.0-src/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Analysis:
Based on the error, it seems that the buffer length mismatch occurs because frame.buffer_len() reports the wrong size. This results in an incorrect buffer length during the emission, leading to the panic.
Could you please confirm if this is the expected behavior, or if there's something else causing the issue?
Thank you!

Thank you for filing an issue! The problem was that the builder omitted the source PAN ID. It is fixed in #30 .


Quick Question: Code formatter?

Hey there!
What code formatter are you using? I'm looking to use the same one as I work that way I don't have to keep manually matching.

clang-format, and there's a make format command that runs it (and also black on the python tests).
Though I have no idea how clang-format works across machines, it's just the first one that came up when I googled "c formatter". If you notice any discrepancies let me know, I can add a config file if it's not matching

clang-format, and there's a make format command that runs it (and also black on the python tests).
Though I have no idea how clang-format works across machines, it's just the first one that came up when I googled "c formatter". If you notice any discrepancies let me know, I can add a config file if it's not matching

Doh don't know how I missed that in the Makefile 😅
Thank you!


Redirect on proxied server returns location with http protocol instead of https

In our configuration we use nginx-proxy to add SSL to the non secure backend. In our application we have some places, where redirect is sent. Currently our server configuration builds location sent in redirect as an absolute URL, which is producing URL starting with HTTP. This is causing problems on some browsers, that handle such redirects improperly.
Currently we have to override the whole nginx.tmpl to put:
proxy_redirect http:// https://;

just under "proxy_pass" declaration in SSL config, which is rewriting locations returned in redirects starting with HTTP.
It would be very good if you could fix this issue internally in the nginx-proxy.

Can you do a protocol relative redirect in your application? e.g. redirect to //domain.com/...

Not really, currently I am using Tomcat as a container and its internal implementation of redirect builds the absolute URL when sending 302 code.

proxy_redirect http:// https:// might be a bit heavy handed to include in the default image.  If I understand it correctly, that would replace all http:// with https:// for any redirects from the backend which could prevent redirecting to valid http:// locations on other domains.
If it's proxy_redirect http://domain.com https://domain.com that might be better but that would still prevent some possibly valid HTTPS to HTTP redirects.  Not sure.
Usually a proxy or load-balancer sets a X-Forwarded-Proto or a Forwarded header that you're backend can use to determine the protocol to redirect to.  This might already be passed through via nginx though.

@jwilder You mean like this? https://github.com/jwilder/nginx-proxy/blob/master/nginx.tmpl#L1-L6 :wink: :+1:

@md5 Aha! Yes, I forgot that was there.

@jwilder Just noticed that link to RFC 7239 in your previous comment. It might actually be good for nginx-proxy to start setting a Forwarded header in addition to X-Forwarded-Proto and X-Forwarded-For.

Our case is a bit more complicated, because on one environment we use nginx-proxy and on the other one we use different proxy, which has this redirect URL rewrite function enabled and we want to keep our application configuration simple and consistent. We were wondering whether this "proxy_redirect" option could become a configuration option in nginx-proxy if you don't want to enable it by default?

@montgomery1944 could solve it?

@jaimess, the issue should be resolved by using X-Forwarded-Proto in web server to build a proper Location header for redirect.

Proto header did the trick for just proxy calls. Redirections needed 2 more properties in connector tag in tomcat server.xml file: proxyPort="443" scheme="https"


The Angular CLI requires a minimum Node.js version of either v10.13 or v12.0

I have windows 10. I updated angular-cli to the laest recommended version trough npm. When i run "ng serve" in my project I get this error:
"Node.js version v11.13.0 detected.
The Angular CLI requires a minimum Node.js version of either v10.13 or v12.0.
Please update your Node.js version or visit https://nodejs.org/ for additional instructions."
I downloaded and installed the latest node.js version 12.6.3
When I run "node -v" I get 12.6.3 but when I run "ng serve" I still get the same error and angular clames that node.js v.11.3.0 has been detected.
There is probably something in the project that I need to change.

It is working if I create a new project and copy "app" folder from the old project.

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.


Add abort signal to model serving context calls

Closes https://issues.redhat.com/browse/RHOAIENG-2002
Description

Add abort signal to some of the custom hooks for Model Serving Global to allow cancelling requests between namespace selctions.

How Has This Been Tested?

For admin users

Log as an admin user
Go to Model Serving Global
Change project with the project selection tab
Check with the network inspector that the calls fetching inferenceServices, servingRuntimes and secrets are being cancelled

For regular users

Log as a regular user
Go to Model Serving Global
Change project with the project selection tab
Check with the network inspector that the calls fetching inferenceServices, servingRuntimes, secrets, and projects (this last one only in "all projects") are being cancelled

Test Impact

Add coverage to test that the calls are being cancelled
Request review criteria:

Self checklist (all need to be checked):

[X] The developer has manually tested the changes and verified that the changes work
[X] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/approve


Add default keybinding cmd+backspace=esc:w for macOS

regarding https://github.com/ghostty-org/ghostty/issues/3646

Looks good, I just want to study a bit more on which is correct.

\x15 seems to be universally accepted across terminals

Just updated to 1.0.1. and it doesn't seem to be working
I reverted back my config to keybind = super+backspace=text:\x15(working) which the code seems to be doing
Maybe something is missing?

This may have to be escaped. There's a discrepancy here. It worked on my system but I'll look into it.


Feat/typescript immutability

This PR adds a preset for our shareable eslint config : eslint-plugin-functional
For now, only plugin:functional/no-mutations has been enabled to prevent from mutability use.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[QUERY] `Azure.Security.KeyVault.Keys  CryptographyModelFactory seems to be in a wrong namespace

Query/Question
CryptographyModelFactory is under Azure.Security.KeyVault.Keys namespace while being in the Azure.Security.KeyVault.Keys/src/Cryptography/ folder. Shouldn't the correct namespace be Azure.Security.KeyVault.Keys.Cryptography ?  Seems like it is also the only class using that namespace in the  Cryptography folder.
namespace Azure.Security.KeyVault.Keys
{
    /// <summary>
    /// Model factory that enables mocking for the Key Vault Cryptography library.
    /// </summary>
    public static class CryptographyModelFactory
    {

Environment:

Name and version of the Library package used: Azure.Security.KeyVault.Keys v4.1.0-preview.1
Hosting platform or OS and .NET runtime version (dotnet --info output for .NET Core projects): NA
IDE and version :NA

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Thank you for finding this issue. It is an unfortunate mistake but moving it would be a breaking change and we feel copying it is not worth the increased assembly size or possible UX issues in the future.


[AutoPR cognitiveservices/data-plane/ComputerVision] Update ComputerVision API

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3338

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/2170


Updating ModalView to improve theming

Some simple proposed changes to the ModalView class to make its background_color behave more closely to the same variable in other classes in kivy.  Also, added overlay_color variable to allow independent setting of the 'fade out' color when a popup is activated.
Note that the doc string for background_color is copied from the Button class, hopefully they parse correctly, I do not know anything about the documentation format or how to test it.

i believe this will fix
https://github.com/kivy/kivy/issues/2198
as well, tho it is difficult to tell without the user's code available.

I had the oppurtunity to check this PR on a project I'm working on, on my side it's working fine.

Nice work @snuq, thanks for your patience in working through the issues.
I'm mildly concerned about this being a breaking change, but have no major objection to merging it if we're happy with that. @tshirtman how does the break look to you?

i think this change is indeed for the better, the current way certainly prevent some reusability of the widget, and the api is not clear, since this is a 2.0 i think i'm ok with such breaks. But i don't have a lot of kivy apps to maintain currently, so i'm not very impacted.


pull/clone should create & update local branches for any remote branches

To make gg update and other commands that would want to use remote branches work regularly, I want gg pull and gg clone to create local branches (refs/heads/foo) for any remote branch (refs/remotes/origin/foo) with the upstream pointing to the remote branch. If multiple remotes have the same branch name, the one for the "origin" remote wins, otherwise the branch is not created. After a successful pull, for every existing local branch that has an upstream pointing to the pulled remote and no diverging commits will be fast-forwarded. This includes the branch pointed to by HEAD: if this is the case, then the working copy will be placed in detached HEAD state at the same commit.

After more thinking about this, I don't like the behavior I described initially. Detaching HEAD makes Git lose track of the branch it's on and making "origin" special feels wrong. Let me try again:
For every branch in the remote, check for a local branch with the same name. If it exists:

If HEAD points to the local branch, do nothing. (The next gg update will move the branch forward.)
If the branch can be fast-forwarded to the remote branch, do so.

If the branch does not exist locally, create it at the same commit as the remote branch with the local branch's upstream pointing to the remote branch.

I'm liking the direction this is heading, because it removes the special-ness of FETCH_HEAD and makes random URLs more easily pull-able. One snag, though: the not-updating-HEAD element poses a trick for pulling an argument that isn't a remote, since there won't be any tracking branch patterns configured.
I propose that in the case where the pull target is not a named remote, the fetched branch refs are written to a new ref hierarchy: refs/ggpull/BRANCHNAME. This way, the local branch updating can be cleanly separated from the remote fetching, and the logic will mostly remain the same.

Work remaining: document new behavior and fix gg pull -u behavior in cases where changes are being pulled from not-the-upstream.


[R] Add auto layout selection to detect layout for rowmajor

c.f. #332
@pluskid Here is a proposed solution to specially solve for MLP row major case in R.

Thanks! It is cool to use shape inference to do auto selection in prediction time.


SSR build should use prod mode in build

Qwik Version
0.0.101
Operating System (or Browser)
all
Node Version (if applicable)
No response
Which component is affected?
Qwik Rollup / Vite plugin
Expected Behaviour
When building for production using the vite plugin, the SSR build executes in dev mode. While we still want the ssr build to not be minified by default, it's very costly to have qDev enabled.
Actual Behaviour
in prod mode qDev === false
Additional Information
No response

Fixed!

That was qwik @manucorporat ! 😀
great job! 💪👏


Unable to plug-in an OnAuthorizationCodeReceived event

https://github.com/aspnet/AADIntegration/blob/9e61d6bd982295bcd262a5d89fc510092fad747c/src/Microsoft.AspNetCore.Authentication.AzureADB2C.UI/OpenIdConnectOptionsConfiguration.cs#L41
This is required for getting the token to call the API as mentioned here: https://github.com/Azure-Samples/active-directory-b2c-dotnetcore-webapp

Similar issue: https://github.com/aspnet/AADIntegration/issues/17


I Want To Use

This website is nifty
http://www.iwanttouse.com/
However, looks like it has been unmaintained by @PaulKinlan and the reporting has gone inaccurate:
https://github.com/PaulKinlan/iwanttouse.com/issues/7

This is a cool one indeed, but as the data aren’t accurate (probably because unmaintained), it would be misleading to add it.
Closing this. Thanks for all the issues. 🙏


Fix Watermill effect repeating (#639)

Great point! I removed the reveal. Please take another look!


Error in compiling using dockerfile

#11 542.8 [ 73%] Building CXX object tests/CMakeFiles/tests.dir/FIO/EncryptionTests.cpp.o
#11 546.6 /wallet-core/tests/Ethereum/AbiStructTests.cpp:125:22: error: no matching function for call to 'sign'
#11 546.6     const auto rsv = Signer::sign(0, privateKeyCow, hash);
#11 546.6                      ^~~~~~~~~~~~
#11 546.6 /wallet-core/src/Ethereum/Signer.h:46:22: note: candidate function not viable: no known conversion from 'int' to 'const TW::PrivateKey' for 1st argument
#11 546.6     static Signature sign(const PrivateKey& privateKey, const uint256_t& chainID, const Data& hash) noexcept;
#11 546.6                      ^
#11 546.6 /wallet-core/src/Ethereum/Signer.h:36:22: note: candidate function not viable: no known conversion from 'int' to 'const TW::PrivateKey' for 1st argument
#11 546.6     static Signature sign(const PrivateKey& privateKey, const uint256_t& chainID, std::shared_ptr<TransactionBase> transaction) noexcept;
#11 546.6                      ^
#11 546.6 /wallet-core/src/Ethereum/Signer.h:28:33: note: candidate function not viable: requires single argument 'input', but 3 arguments were provided
#11 546.6     static Proto::SigningOutput sign(const Proto::SigningInput& input) noexcept;
#11 546.6                                 ^
#11 546.6 /wallet-core/tests/Ethereum/AbiStructTests.cpp:189:22: error: no matching function for call to 'sign'
#11 546.6     const auto rsv = Signer::sign(0, privateKeyCow, hash);
#11 546.6                      ^~~~~~~~~~~~
#11 546.6 /wallet-core/src/Ethereum/Signer.h:46:22: note: candidate function not viable: no known conversion from 'int' to 'const TW::PrivateKey' for 1st argument
#11 546.6     static Signature sign(const PrivateKey& privateKey, const uint256_t& chainID, const Data& hash) noexcept;
#11 546.6                      ^
#11 546.6 /wallet-core/src/Ethereum/Signer.h:36:22: note: candidate function not viable: no known conversion from 'int' to 'const TW::PrivateKey' for 1st argument
#11 546.6     static Signature sign(const PrivateKey& privateKey, const uint256_t& chainID, std::shared_ptr<TransactionBase> transaction) noexcept;
#11 546.6                      ^
#11 546.6 /wallet-core/src/Ethereum/Signer.h:28:33: note: candidate function not viable: requires single argument 'input', but 3 arguments were provided
#11 546.6     static Proto::SigningOutput sign(const Proto::SigningInput& input) noexcept;
#11 546.6                                 ^
#11 546.6 /wallet-core/tests/Ethereum/AbiStructTests.cpp:286:22: error: no matching function for call to 'sign'
#11 546.6     const auto rsv = Signer::sign(0, privateKeyCow, hash);
#11 546.6                      ^~~~~~~~~~~~
#11 546.6 /wallet-core/src/Ethereum/Signer.h:46:22: note: candidate function not viable: no known conversion from 'int' to 'const TW::PrivateKey' for 1st argument
#11 546.6     static Signature sign(const PrivateKey& privateKey, const uint256_t& chainID, const Data& hash) noexcept;
#11 546.6                      ^
#11 546.6 /wallet-core/src/Ethereum/Signer.h:36:22: note: candidate function not viable: no known conversion from 'int' to 'const TW::PrivateKey' for 1st argument
#11 546.6     static Signature sign(const PrivateKey& privateKey, const uint256_t& chainID, std::shared_ptr<TransactionBase> transaction) noexcept;
#11 546.6                      ^
#11 546.6 /wallet-core/src/Ethereum/Signer.h:28:33: note: candidate function not viable: requires single argument 'input', but 3 arguments were provided
#11 546.6     static Proto::SigningOutput sign(const Proto::SigningInput& input) noexcept;
#11 546.6                                 ^
#11 546.6 /wallet-core/tests/Ethereum/AbiStructTests.cpp:403:22: error: no matching function for call to 'sign'
#11 546.6     const auto rsv = Signer::sign(0, privateKeyDragon, hash);
#11 546.6                      ^~~~~~~~~~~~
#11 546.6 /wallet-core/src/Ethereum/Signer.h:46:22: note: candidate function not viable: no known conversion from 'int' to 'const TW::PrivateKey' for 1st argument
#11 546.6     static Signature sign(const PrivateKey& privateKey, const uint256_t& chainID, const Data& hash) noexcept;
#11 546.6                      ^
#11 546.6 /wallet-core/src/Ethereum/Signer.h:36:22: note: candidate function not viable: no known conversion from 'int' to 'const TW::PrivateKey' for 1st argument
#11 546.6     static Signature sign(const PrivateKey& privateKey, const uint256_t& chainID, std::shared_ptr<TransactionBase> transaction) noexcept;
#11 546.6                      ^
#11 546.6 /wallet-core/src/Ethereum/Signer.h:28:33: note: candidate function not viable: requires single argument 'input', but 3 arguments were provided
#11 546.6     static Proto::SigningOutput sign(const Proto::SigningInput& input) noexcept;
#11 546.6                                 ^
#11 546.6 4 errors generated.
#11 546.6 tests/CMakeFiles/tests.dir/build.make:1279: recipe for target 'tests/CMakeFiles/tests.dir/Ethereum/AbiStructTests.cpp.o' failed
#11 546.6 make[2]: *** [tests/CMakeFiles/tests.dir/Ethereum/AbiStructTests.cpp.o] Error 1
#11 546.6 make[2]: *** Waiting for unfinished jobs....
#11 555.4 make[2]: Leaving directory '/wallet-core/build'
#11 555.4 CMakeFiles/Makefile2:334: recipe for target 'tests/CMakeFiles/tests.dir/all' failed
#11 555.4 make[1]: *** [tests/CMakeFiles/tests.dir/all] Error 2
#11 555.4 make[1]: Leaving directory '/wallet-core/build'
#11 555.4 make: *** [all] Error 2
#11 555.4 Makefile:135: recipe for target 'all' failed
#11 555.5 make: Leaving directory '/wallet-core/build'
------
executor failed running [/bin/bash -o pipefail -c tools/generate-files    && cmake -H. -Bbuild -DCMAKE_BUILD_TYPE=Debug    && make -Cbuild -j12]: exit code: 2

Master currently has a test compile error, since last commit (d7f4953, 7 hrs ago).
Fix is prepared, here:  https://github.com/trustwallet/wallet-core/pull/1507

thanks

Fixed on master.


NDRS-440: Add information from the consensus protocol to accusations.

Add equivocators seen from a block to the accusations on finalization, even if they weren't included in the candidate block explicitly.
https://casperlabs.atlassian.net/browse/NDRS-440

So it's not invalid when a block doesn't mention equivocators properly?

Exactly. It's even a bit wasteful that it does, since you get slashed anyway if the vertex corresponding to the block can see you as faulty.

At the same time, all proposals will mention equivocators until the end of an era?

Even until the end of the unbonding period, yes.
This makes sure we don't miss any accusation, even though it's still a bit redundant.

I'm wondering now whether it's necessary to duplicate this information – at the level of FinalizedBlock and in the ConsensusValue. Do we need accusations in the latter?

We basically need the accusations in ConsensusValue so you can accuse someone for an equivocation in a past era. And we need the ones in FinalizedBlock to enforce that you accuse at least everyone you see as faulty in the current era.

But now that I think of it there's one more thing we should enforce: That unless this is a switch block, you accuse at least as many as your parent block, i.e. that accusations always accumulate over the course of an era.

We basically need the accusations in ConsensusValue so you can accuse someone for an equivocation in a past era. And we need the ones in FinalizedBlock to enforce that you accuse at least everyone you see as faulty in the current era.

Right, my idea was to get rid of accusations from the ConsensusValue and leave only the ones in the FinalizedBlock but I think we talked about it and it wouldn't work for equivocations in the era tail – finalizing the switch block.

Exactly. It's pretty ugly, but I don't see any elegant way to unify the two types of accusations.
(I created HWY-166 for the problem mentioned above.)

So, if accusations (from the ConsensusValue) may carry equivocators from past eras, does it mean that we may slash someone more than once or is it deduplicated somewhere?

It does, and we have an issue to fix that, too: NDRS-495

That issue is marked as Done though.

 I think that was by mistake. I'll recreate it…

For some reason, Jira still marks it as Done of some sort.

bors merge

Wait, it actually is done: https://github.com/CasperLabs/casper-node/pull/397
And you reviewed it! :sweat_smile:

Wait, it actually is done: #397
And you reviewed it! sweat_smile

Yeah, I vaguely remembered something like this but I wasn't sure that's why I asked if it's done somewhere else. Are you sure we won't introduce already-slashed validators with this PR?

You're right, it probably will. I need to think about that. Will create a follow-up PR.

bors r-

@goral09: Sorry for the confusion! I added a line to filter already-slashed validators.

bors merge


Naj 44 make sign and send transaction functionality public

Motivation
NAJ-44
Description
signAndSendBundledActions methods added to expose the functionality of protected signAndSendTransaction
Checklist

[✓] Read the contributing guidelines
[✓] Commit messages follow the conventional commits spec
[✓] Performed a self-review of the PR
[✓] Added automated tests
[✓] Manually tested the change

@AbdulBaseerKhan We have examples in the cookbook and tests that use signAndSendTransaction in the way you are describing e.g. batch-transactions.js. Why don't we just remove the access modifier and make this public.

@AbdulBaseerKhan We have examples in the cookbook and tests that use signAndSendTransaction in the way you are describing e.g. batch-transactions.js. Why don't we just remove the access modifier and make this public.

@esaminu It was mentioned in the ticket (NAJ-44) that do not make that method public. Write another method instead and will updated the documentations accordingly.

@AbdulBaseerKhan I saw that but I'm wondering whether there's any specific reason not to. I found this discussion from the reported issue https://github.com/near/near-api-js/pull/557#discussion_r624559026 that came to the same conclusion. Also can you review that PR, Maybe it has other stuff we want as well?

Closing in favor of #1002


Fixed the logout error when sending Logoutresponse against ADFS

This fix solves the problem affecting Logout Request against the Windows AD FS.
Without this fix, the LogoutRequest is sent with the SPNameQualifier set, while ADFS does not like it (ADFS behavior is correct according to the definition dictated by the Standard).

Coverage increased (+0.002%) to 95.154% when pulling 45df75ac9e1ceb3745bfd056831ccf1415d7cefa on albertogeniola:master into e5e25f0caa42f8c33665496839f92b014b01e93c on onelogin:master.

See https://github.com/onelogin/java-saml/commit/ba141697df4bb1cd670c61307e1de7767670bf8c


Fix CI errors

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@bdb8bd7). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #1   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         2
  Lines           ?       509
  Branches        ?         0
========================================
  Hits            ?       509
  Misses          ?         0
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb8bd7...b184a01. Read the comment docs.


Game Studio doesnt reload sub projects after changes

Release Type: Official Release/GitHub (please choose appropriate option)
4.1
Version: Version number and/or git branch
Any
Platform(s): Does the problem occur on Windows, Android...?
Game Studio
Describe the bug
Game Studio doesnt reload other assemblies besides the main one for refreshing the game studio.
Which means:
You have a second Project, it inherits from a interface and is a Datacontract then Gamestudio will not update it unless you restart it as sub projects are only loaded once.
As far as i could track it down:
https://github.com/stride3d/stride/blob/master/sources/editor/Stride.GameStudio/DebuggingViewModel.cs#L176C1-L181
This never Receives from the Buffer any DLLs besides the main one.
This is caused by
https://github.com/stride3d/stride/blob/master/sources/editor/Stride.Assets.Presentation/AssetEditors/ProjectWatcher.cs#L200
                if (needProjectReload == false
                    && (e.ChangeType == FileEventChangeType.Deleted || e.ChangeType == FileEventChangeType.Renamed || e.ChangeType == FileEventChangeType.Created)
                    && Path.GetExtension(changedFile)?.ToLowerInvariant() == ".cs"
                    && !UPath.Combine(new UFile(trackedAssembly.Project.FilePath).GetFullDirectory(), new UDirectory("obj")).Contains(new UFile(changedFile)))
                {
                    needProjectReload = true;
                }

this will be always true for the main project, so it will trigger the reload of the project here
https://github.com/stride3d/stride/blob/master/sources/editor/Stride.Assets.Presentation/AssetEditors/ProjectWatcher.cs#L229
So it will never reach the other dlls
Also swapping the order of the dlls wont help as it will create a endless loop

second project rebuilds
main project changes so it gets build
second project rebuilds
...

Expected behavior
It should behave like in the main project where i add a type in code and it properly reloads and i dont have to restart game studio
Additional context
The Assembly Registry and TypeDescriptorExtension work.
I managed to get it "working" by skipping hardcoded dlls to check if the other stuff works and it does.
the skip caused 3 times reloading the dlls as:

main project changed and gets rebuild
second project changed and gets rebuild
both projects get rebuild ( which would be expected )

the issue was that the reload gets triggered by the main assembly and it will be the first one that gets triggered, so it will always only reload the main project and not the subprojects
now the trigger fires off when the dll fits to the change so it triggers the reload and not always the main project

fixed with #1704


send Michael contact data (short bio, email, twitter)

for the CC Europe website

For reference so I don't need to dig through my mails:
John Weitzmann
<EMAIL_ADDRESS>Lawyer, journalist and activist based in Berlin, Germany, where he is also volunteer Legal Project Lead for CC Germany since 2007.

Working on the About page which also contains your contact info. I added a user setting 'coordinator' and I show all coordinators at the bottom of the about page.

The about page should be finished, see the bottom part with your info. The description is loaded from your user profile, as is the twitter name and mail address. You need to have an avatar on www.gravatar.com linked to your creativecommons e-mail address.
I can actually repeat that contact info per affiliate if you want.

@gwenfranck can you try setting you description yourself and check if everything is working?


update unit test for etl, add coverage, and remove validaition on packing manager for Jenis Pengiriman and Jenis Barang Jadi

Coverage increased (+0.06%) to 72.816% when pulling 900a5fb8d6fa06afbb5adf6f7a478f5435259686 on leslieaula:dev into<PHONE_NUMBER>e4282a7374ebce57ad19e141dbbab5 on danliris:dev.


Error exporting expenses

Array to string conversion

Can you please explain this?

This is a good one to look at. Go to the admin panel, and then try to export expenses, it'll give an error.
https://flareapp.io/share/OmV8Qjw7
This might take some figuring out. I export them in a certain format so it could be a problem with how that's being done

It does it on the demo site, too

Sure, I'll check it out. Thanks!


Create Site Issues....

I'm seeing two issues with creating new Site Collections using a template created via the Save Site as Template feature. We created a custom Site Collection, with a set of targeted Lists (News & Announcements, Calendar, Documents and Tasks),  and several "custom" Content Search Web Parts on the home page. We have Publishing turned on at both the site collection level and the site level. (Also some branding with custom logo and alternate css file.) Lastly, we enabled the Partner Pack Extensions for the custom Site Collection and successfully saved that as a Template.
However, when we attempt to use that template it fails on applying "Site Security" with errors like "The specified user Hierarchy Managers could not be found." or "The specified user Designers could not be found." I'm guessing that these "users" should be part of the Publishing Feature, which has not yet been enabled. Therefore shouldn't features run before Site Security?
If we rip out the whole Site Security Section, the update times out waiting for the Features Handler to finish. So far I have the time-out set for 10 minutes, and will be testing a longer time out (1 hour) out of curiosity.
While attempting to remote debug the web job (PartnerPack.ScheduledJob), it appears you can't remotely attach to a scheduled/on-demand web job. What is everyone else doing to debug ScheduledJob? Do you make it a continuous job in order to attach to it?
Has anyone successfully created a new site collection with a template saved from a Site Collection with publishing turned on? Or is the Best Practice to start empty and turn on all the features and upload any custom web parts separately, piece meal?

Hi,
Sorry for the delayed answer. We are currently working on a PnP Partner Pack v.2 in which maybe we will be able to properly support publishing features. Right now, the v.1.1 of the PnP Partner Pack mainly supports the Team Site template. Thanks for your feedback.

Paolo...
With v2, will the new Document Library Look and Feel be supported? There appears to be two features "missing" with the new Document Libraries, alternate style sheets and the user injection spots. Do you know if these Features are going to be returned? And how the Partner Pack is going to deal with them missing if they are not coming back?

Hi,
We are working on it and at the time of this message the only option we have is to revert the site back to the classic view. We will keep the community updated if there will be any news about this topic.


Allow fetching solutions from the Route Optimization API

This PR adds the ability to fetch solutions from the Route Optimization API and fixes #2.
Furthermore I performed a minor clean up, dependency update, etc.
Due to limitations of the Mapbox SDK solutions are limited to 25 addresses.

Why do we need sonatype repo?

Probably this is not necessary anymore. I added this because of the newly released java client and because it was immediately usable there after the release.

com.graphhopper.navigation.example instead with the underscores or is this the common naming schema under Android?

Ah yes sure, I changed it.

Thanks!


[storage-resize-images] Support for animated avif

[READ] Step 1: Are you in the right place?
Issues filed here should be about a feature request for a specific extension in this repository. To file a feature request that affects multiple extensions or the Firebase Extensions platform, please reach out to
Firebase support directly.
[REQUIRED] Step 2: Extension name
This feature request is for extension: storage-resize-images
What feature would you like to see?
Support for animated avif similar to animated webp. Animated avif is supported on all major browsers on all major platforms so it should be worth supporting.
How would you use it?
Use it the same way as animated webp.

Hi @saumyakswain!
Looking into Sharp documentation, it does not currently support animated AVIF. Since we are using Sharp to process images, animated AVIF cannot be processed with the extension.
Closing this issue for now.

Thanks @jauntybrain for taking a look. Hopefully sharp supports animated avifs soon 🤞


feat: support incomplete and other styles

This PR tries to implement the feature mentioned in #1.

The checklist has been expanded to accept more symbols for different styles, such as incomplete, cancelled, etc.
An imcomplete-sym is added. It is implemented as a box with the right half filled with stroke.
All prefixes are defined at the top.

Currently, I have implemented only the symbol of the incomplete item. The user is left to provide other symbols.
Questions and TODO:
There are many styles in minimal. Should we implement all of them? Or can we provide some basic styles and let the user choose the remaining ones?

[ ] Update README according to the implementation.

Thanks for contribution, but I think we can use marker-map to simplify the whole design.


Fix glpk

Remove stripped path prefix from paths in BUILD file
Fix include paths for Bzlmod

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (glpk) have been updated in this PR. Please review the changes.

@meteorcloudy could you please trigger the tests? Thanks!

@meteorcloudy could you PTAL? Thanks!


migrating scaffold articles

We needed to add the example doc as well.

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/cloud-adoption-guide/subscription-governance.md
:warning:Warning
View
Details

docs/cloud-adoption-guide/subscription-governance-examples.md
:white_check_mark:Succeeded
View

docs/cloud-adoption-guide/subscription-governance.md

Line 253: [Warning] Invalid file link:(~/cloud-adoption-guide/subscription-governance-examples).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/cloud-adoption-guide/subscription-governance-examples.md
:white_check_mark:Succeeded
View

docs/cloud-adoption-guide/subscription-governance.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/cloud-adoption-guide/subscription-governance-examples.md
:white_check_mark:Succeeded
View

docs/cloud-adoption-guide/subscription-governance.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.