Only use tf2_geometry_msgs library when needed

Basic Info

Info
Please fill out this column

Issue(s) this addresses
#316

ROS2 version tested on
Humble

Aerial platform tested on
-

Description of contribution in a few bullet points

Add dependency to as2_core package.xml
Removed include from as2_platform_dji_osdk, as2_behaviors_motion, as2_realsense_interface, as2_motion_controller, as2_state_estimator and as2_motion_reference_handlers
Using .hpp instead of .h library following deprecation warning suggestion

@pariaspe  I wouldn't change the .hpp now


cmd/prof: improve error messages

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Small changes to provide better errors when using brew prof.

Provide an error message when the command is unknown.
Suggest running the command again with -- if there is an invalid option which might have been meant for a subcommand.

Before
/u/l/Homebrew (master|✔) $ brew prof updat
Error: undefined method `extname' for nil:NilClass
/usr/local/Homebrew/Library/Homebrew/dev-cmd/prof.rb:30:in `prof'
/usr/local/Homebrew/Library/Homebrew/brew.rb:93:in `<main>'

/u/l/Homebrew (master|✔) [1]$ brew prof list -r
Usage: brew prof [--stackprof] command [...]

Run Homebrew with a Ruby profiler. For example, brew prof readall.

      --stackprof                  Use stackprof instead of ruby-prof (the
                                   default).
  -d, --debug                      Display any debugging information.
  -q, --quiet                      Make some output more quiet.
  -v, --verbose                    Make some output more verbose.
  -h, --help                       Show this message.
Error: invalid option: -r

After
/u/l/Homebrew (improve-prof-errors|✔) $ brew prof updat
Usage: brew prof [--stackprof] command [...]

Run Homebrew with a Ruby profiler. For example, brew prof readall.

      --stackprof                  Use stackprof instead of ruby-prof (the
                                   default).
  -d, --debug                      Display any debugging information.
  -q, --quiet                      Make some output more quiet.
  -v, --verbose                    Make some output more verbose.
  -h, --help                       Show this message.

Error: Invalid usage: `updat` is an unknown command!

/u/l/Homebrew (improve-prof-errors|✔) [1]$ brew prof list -r
Usage: brew prof [--stackprof] command [...]

Run Homebrew with a Ruby profiler. For example, brew prof readall.

      --stackprof                  Use stackprof instead of ruby-prof (the
                                   default).
  -d, --debug                      Display any debugging information.
  -q, --quiet                      Make some output more quiet.
  -v, --verbose                    Make some output more verbose.
  -h, --help                       Show this message.
Error: invalid option: -r
Try `brew prof -- list -r` instead.

Review period will end on 2023-02-17 at 02:28:36 UTC.

Review period ended.


Require is not defined (ooth-client-react)

This project worked this morning; however after no changes, I am getting this error being thrown in ooth-client-react. Any ideas?

can you post your setup?

I'll close this because of no activity, if you still have this problem let me know.


feat: documentation for linkwarden/#327

Documentation for linkwarden/linkwarden#327

You rock, thanks!
I'll be merging this soon.


Capsule proxy endpoint failing to list Priorityclass for tenant even with ProxySettings specifying List verb for PriorityClasses

Bug description
Filtering does not work for StorageClasses,PriorityClasses on querying the capsule proxy endpoint after setting up the resources with label name and explicitly allowing list verb in the tenant yaml.
CC: @bsctl
How to reproduce
Steps to reproduce the behavior:

Provide the Capsule Tenant YAML definitions

apiVersion: capsule.clastix.io/v1beta1
kind: Tenant
metadata:
  creationTimestamp: "2022-09-26T20:12:53Z"
  generation: 6
  name: tenantext
  resourceVersion: "1695546"
  uid: 98770539-8573-4dfb-b61c-5dfd16d22c1a
spec:
  owners:
  - kind: ServiceAccount
    name: system:serviceaccount:default:privtest
    proxySettings:
    - kind: Nodes
      operations:
      - List
    - kind: StorageClasses
      operations:
      - List
    - kind: IngressClasses
      operations:
      - List
    - kind: PriorityClasses
      operations:
      - List
  priorityClasses:      #tried without this allowed block as well
    allowed:
    - high-priority-mv
    allowedRegex: \w+priority
status:
  namespaces:
  - privtest-ns
  - privtest-ns-alt
  size: 2
  state: Active

Provide all managed Kubernetes resources

% k get PriorityClass
NAME                      VALUE        GLOBAL-DEFAULT   AGE
high-priority-mv          1000         false            3h41m
system-cluster-critical<PHONE_NUMBER>   false            202d
system-node-critical<PHONE_NUMBER>   false            202d

Priorityclass
apiVersion: scheduling.k8s.io/v1
description: high priority
kind: PriorityClass
metadata:
  creationTimestamp: "2022-09-27T16:13:24Z"
  generation: 1
  labels:
    name: high-priority-mv
  name: high-priority-mv
  resourceVersion: "1686153"
  uid: 6607252f-4e29-40e8-addc-1878475ff17f
preemptionPolicy: PreemptLowerPriority
value: 1000

SA: used is privtest
 k get sa
NAME       SECRETS   AGE
default    1         202d
privtest   1         24h

capsule proxy e/p
k get svc -n capsule-system
NAME                                         TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)                                        AGE
capsule-controller-manager-metrics-service   ClusterIP   <IP_ADDRESS>    <none>        8080/TCP                                       25h
capsule-proxy                                ClusterIP   <IP_ADDRESS>    <none>        9001/TCP                                       25h
capsule-proxy-metrics-service                ClusterIP   <IP_ADDRESS>   <none>        8080/TCP                                       25h
capsule-proxy-nodeport                       NodePort    <IP_ADDRESS>     <none>        9001:30855/TCP,8080:31621/TCP,8081:31892/TCP   22h
capsule-webhook-service                      ClusterIP   <IP_ADDRESS>     <none>        443/TCP                                        25h

Expected behavior
Made a curl call to the capsule-proxy endpoint <IP_ADDRESS>:9001 using the token of this SA system:serviceaccount:default:privtest - defined as the owner in tenant.yaml
Call to list PriorityClasses fails
curl -k https://<IP_ADDRESS>:9001/api/v1/PriorityClasses  --header "Authorization: Bearer <>"
{
  "kind": "Status",
  "apiVersion": "v1",
  "metadata": {},
  "status": "Failure",
  "message": "**PriorityClasses is forbidden: User \"system:serviceaccount:default:privtest\" cannot list resource \"PriorityClasses\" in API group \"\" at the cluster scope**",
  "reason": "Forbidden",
  "details": {
    "kind": "PriorityClasses"
  },
  "code": 403
}

List nodes /namespaces returns results as expected - 200 response
curl -k https://<IP_ADDRESS>:9001/api/v1/nodes --header "Authorization: Bearer <same token>"
curl -k https://<IP_ADDRESS>:9001/api/v1/namespaces --header "Authorization: Bearer <same token>"

Another issue observed here - /nodes fails with forbidden  note the case "N"
curl -k https://<IP_ADDRESS>:9001/api/v1/Nodes
"message": "Nodes is forbidden: User \"system:serviceaccount:default:privtest\" cannot list resource \"Nodes\" in API group \"\" at the cluster scope"

Logs
If applicable, please provide logs of capsule.
In a standard stand-alone installation of Capsule,
you'd get this by running kubectl -n capsule-system logs deploy/capsule-controller-manager.
Additional context

Capsule version: (capsule --version)
Helm Chart version: (helm list -n capsule-system)

% helm list -n capsule-system
NAME         	NAMESPACE     	REVISION	UPDATED                             	STATUS  	CHART              	APP VERSION
capsule      	capsule-system	1       	2022-09-26 11:34:20.249276 -0700 PDT	deployed	capsule-0.1.11     	0.1.2
capsule-proxy	capsule-system	1       	2022-09-26 11:48:58.208154 -0700 PDT	deployed	capsule-proxy-0.3.1	0.3.0

Kubernetes version: (kubectl version)
% k version

Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.5", GitCommit:"5c99e2ac2ff9a3c549d9ca665e7bc05a3e18f07e", GitTreeState:"clean", BuildDate:"2021-12-16T08:38:33Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"darwin/arm64"}
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-25T21:19:12Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"linux/arm64"}

Thanks for reporting this, @mathuvenkat.
Let me check this so I can evaluate if the fix must be addressed in the Capsule code base or, rather, in the capsule-proxy one.

I was able to replicate the issue you reported, and the main problem is that PriorityClass objects are not labelled as requested:

The name label reflecting the resource name is mandatory, otherwise filtering of resources cannot be put in place
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
  labels:
    name: custom
  name: custom
value: 1000
globalDefault: false
description: "Priority class for Tenants"

Please, note the label name matches the metadata.name value.
Since capsule-proxy is totally relying on the filtering capabilities offered by Kubernetes API Server, this labelling is required to avoid rewriting yet another Kubernetes API Server.
If you're able to get it solved, please, close the issue.

Thanks @prometherion for replicating this issue.
I had provided in my original comment the yaml of Priority class where metadata.name and labels.name is same, which is high-priority-mv. This should be sufficient right, but it did not work ? Is there anything I missed here ?
apiVersion: scheduling.k8s.io/v1
description: high priority
kind: PriorityClass
metadata:
  creationTimestamp: "2022-09-27T16:13:24Z"
  generation: 1
  labels:
    name: high-priority-mv
  name: high-priority-mv
  resourceVersion: "1686153"
  uid: 6607252f-4e29-40e8-addc-1878475ff17f
preemptionPolicy: PreemptLowerPriority
value: 1000

I had provided in my original comment the yaml of Priority class where metadata.name and labels.name is same, which is high-priority-mv. This should be sufficient right, but it did not work ? Is there anything I missed here ?

Correct, just the label name is required.

It did not work with the same yaml you provided above, when I made a curl call to the proxy endpoint as below curl -k https://<IP_ADDRESS>:9001/api/v1/priorityclasses
"priorityclasses is forbidden: User "system:serviceaccount:infra-admin-tenant-ns-abc:tenant-owner-admin" cannot list resource "priorityclasses" in API group "" at the cluster

I'm not getting the point here: in the tenant manifest the user system:serviceaccount:default:privtest is reported as the tenant owner, however, the last message is referring to the ServiceAccout tenant-owner-admin in the namespace infra-admin-tenant-ns-abc.

Also what is the clusterrolebinding that capsule creates that will allow this

Due to limitations of Kubernetes API which RBAC has been designed around resources rather than user ownerships, there's no role allowed to list those cluster-scoped resources: the proxy has to run as cluster administrator in order to perform the required user impersonation, and access all the required objects such as Storage Class, Ingress Class, Priority Class, etc.

Closing due to stale activity, feel free to open it back if you're still having the described issue.


Execute file size is too big, can sonic be optimized when compile?

Hi there,
Sonic is a great json library, high performance and very easy to use, thanks for your work.
But the execute file size is double, it is can‘t acceptable in my scenario. Can sonic be optimized when compile? for example: only compile source code for CPU/OS arch currently in use, maybe this will reduce execute file size.
Thank you.

Ok, I will try it. First investigate where the binary comes from. If you already have stats on it, it will help a lot

Those are my project execute files, two methods for json parsing, Windows 10, CPU Intel Core i7.
method1: json parse, execute file size: 48M
 if err := json.Unmarshal(msg, &account); err != nil {
 	log.Errorf("Unmarshal account failed, tenant: %s, platform: %s, error: %s, message: %s", tenant, platform, err.Error(), msg)
 	return
 }

method 2: sonic parse, execute file size: 97M
if err := sonic.Unmarshal(msg, &account); err != nil {
 	log.Errorf("Unmarshal account failed, tenant: %s, platform: %s, error: %s, message: %s", tenant, platform, err.Error(), msg)
 	return
 }

Can you try to use older version (<1.10) and give size? If it is still a lot, I doubt that the main cause it doesn't come from C asm files.

@AsterDY
There are three execute files size, the Sonic old version (<1.10) is normal, maybe version 1.10 changed something.

ok，It seem native codes need to be embeded on demands. Let me try

Hi there,
Any update for this issue?

Also, the compilation time is x2 for v1.10, on 1.9.2 it's two times faster.

Might be useful https://github.com/bytedance/sonic/issues/561#issuecomment-1886061319

Might be useful #561 (comment)

Seem it is due to v1.10 imported iasm as basic assembler, which is used to reslove #489 meanwhile improve C-Go intercall performance. At present, no better solution for this. cc @chenzhuoyu


Add Adhans (notifications sounds)

In addition to the notifications, we can add an option to have the Adhan.
Thanks to AlAdhan.com for providing us with adhans in MP3 format.
Here is the link: https://aladhan.com/download-adhans
Here's what we need:

a checkbox to enable/disable the sound
options to choose between the different Adhans.
The Adhan should be triggered at the same time as the notification

https://github.com/b0bdN/prayer-times-menubar-app/blob/066aa36761121d37cf1a29eef8242f2bde0b60f6/main.js#L150
See the documentation on Electron Notifications.

Hey can you assign me the issue if it is still active ???

Hey can you assign this to me? @b0bdN

The last post was almost one year ago. Is this still active?

Assalamu Alaikum, is there any update on this? By the way, electron's doc says sound on notification only works on MacOs. Do you have any other alternatives, @b0bdN ?


Validate undo behavior of all operations and transforms

First step would be to add validation when applying that the Before value in all the cases matches actual Before value and fixing all the tests that fail.
I have very high hopes that actual undo behavior works but the next step after this would be to change the core Apply() behavior in the test to also validate undo immediately.

This is done.  See #83


[📑 Docs]:

What Dev Docs changes are you proposing?
Regarding the Hello World example:
The description around this example confused me a little bit.
Why is this example written in the eyes of the subscriber? It starts with "Let's define an application that's capable of receiving".
Then the Async API document uses the word "publish:".
Normally I'd write a specification around the publisher and the messages it emits. I don't normally define the message that the subscriber expects to receive.
Wouldn't it be better describing it as "Let's define an application that's capable of publishing a message"......?
Code of Conduct

[X] I agree to follow this project's Code of Conduct

On reading the document again, I suppose I'm coming from a pub/sub perspective where the publisher documents the events that it publishes on topics and then one or more subscribers subscribe to them.
The Hello World example is more akin to a application is defining the commands that it expects to be sent on a queue.
In these scenarios the receiver would document specifications of the commands it would receive.

On reading the document again, I suppose I'm coming from a pub/sub perspective where the publisher documents the events that it publishes on topics and then one or more subscribers subscribe to them. In the pub/sub scenario subscribers don't specify the events they expect to receive as they have no choice over the matter; they are subscribing to another system's events.

it all depends on what is your use case for AsyncAPI. Is it only docs from consumer's point of view. Or maybe you are interested in code generation. Or maybe you have a WebSocket API where you send and receive messages. There is also a request/reply pattern in pub/sub, where you want to know what message you can sent to a services, and where you should specify where the reply should be sent. So yeah, it really depends on where you are coming from and what is your goal.

Should we convert the example into an application publishing an event?

what about we just provide another tutorial for publishing. So we keep the current one, Hello World, as Hello World for consumer application and add new Hello World for producer application?
@alequetzalli thoughts?

I mean... publish operation should refer to act of publishing a message in a channel.
I'm confused too.

@alequetzalli ping pong

Hey @derberg and @asos-andrewpotts, not sure how I missed this one!
First, thank you for sharing your thoughts with such detail, @asos-andrewpotts. I had to consider and process them.
Second, I must admit I align with Lukasz' recommendation. Let's keep the current one, Hello World, as Hello World for consumer application and add a new Hello World for producer application.

so yeah, this issue was created before v3 release
now, hello world document shows how to describe in AsyncAPI that app is receiving a message
would be still nice to have an example where app is sending a message
so Hello world - receiving a message and Hello world - sending a message and in the new document we could extent an example, that Hello world application drops a message to a broker every time the welcoming takes place

Got it, thanks for the reply @derberg !

@derberg, I have started the work here: https://github.com/asyncapi/website/pull/2981.
Do let me know what you think. 😸 💭


Header vertical align off when scrolling on 3-up breakpoint

Also, honestly, I have my browser windows at this breakpoint fairly often on a 1440-wide screen and (1) the text feels too small + (2) it's jarring transitioning between the two text sizes on the same device.


[Bug] Different Serializing Name

Search before asking

[X] I searched in the issues and found nothing similar.

Paimon version
since 0.8.0
Compute Engine
any
Minimal reproduce step
deletionVectorsRanges is given different serialization name as  _DELETION_VECTORS_RANGES In  IndexFileMeta and  _DELETIONS_VECTORS_RANGES in IndexManifestEntry. This is maybe only an unintentional spelling mistake, but would create potential inconsistencies
What doesn't meet your expectations?
Anything else?
Can we use the same name for serialization ?  Should reserve _DELETIONS_VECTORS_RANGES in  IndexManifestEntry  to keep the index manifest file consistent
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Reserve _DELETION_VECTORS_RANGES in IndexFileMeta might be better？ cc @JingsongLi

If this change not to affect future user upgrades, keeping the _DELETIONS_VECTORS_RANGES might be the best option.

If this change not to affect future user upgrades, keeping the _DELETIONS_VECTORS_RANGES might be the best option.

agree with you


Add feature menuSelectionCallback to pull updatedValues onClick of a ListItem

Fixes #112

Codecov Report

Merging #113 into master will decrease coverage by 0.39%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #113     +/-   ##
=========================================
- Coverage   40.97%   40.57%   -0.4%
=========================================
  Files           6        6
  Lines         205      207      +2
=========================================
  Hits           84       84
- Misses        121      123      +2

Impacted Files
Coverage Δ

src/types/index.js
33.33% <ø> (ø)

src/defaultProps.js
53.84% <ø> (ø)

src/SuperSelectField.js
38.21% <0%> (ø)

...terial-ui-superselectfield/src/SuperSelectField.js

...an/material-ui-superselectfield/src/types/index.js

...Sharlaan/material-ui-superselectfield/src/utils.js

.../material-ui-superselectfield/src/FloatingLabel.js

...ial-ui-superselectfield/src/SelectionsPresenter.js

...n/material-ui-superselectfield/src/defaultProps.js

src/utils.js
36% <0%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2782171...f146b4b. Read the comment docs.

I'm trying to write some tests for this but it seems almost impossible.
describe('menuSelectionCallback', () => {
  it('should return updatedValues', () => {
    const wrapper = shallowWithContext(<SuperSelectField showAutocompleteThreshold="always">{testChildren}</SuperSelectField>)
    wrapper.simulate('click')
    const firstChild = wrapper.find('ListItem').first()
    firstChild.simulate('click', {
      preventDefault: () => {
      },
    });
    expect( wrapper.instance().props.menuSelectionCallback ).toHaveBeenCalled()
  })
})

Keep getting an error
TypeError: Cannot read property 'focus' of undefined or undefined is not an object (evaluating '_this.root.focus')
I also just noticed #23
I didn't realize this was a hot button issue.
I do think setting the state based onClick rather than when the menu is closed is necessary.
Not only that, but the original docs were actually incorrect as it said the state was change onClick but that's not the case with onChange.

Unfortunately because of #105 I can't even run this on my project without published merges.
I'm open to discussing these changes as well as test coverage. Hopefully we can resolve this without breaking any backwards compatibility.

solved with #119


Sorting

The sorting doesn’t work

yeahh... i didn't really implement the feature, i just added the option. I'd be implementing soon


Add error message for missing interface argument and fix module import…

… issue
Summary
This PR improves the packet sniffer script by adding error handling for missing arguments and resolving module import issues.
Changes

Error Handling: Added a check to ensure the 'interface' argument is provided. If not, an error message is displayed and the script exits.
Packet Sniffing: The script now correctly captures packets on the specified network interface and saves them to a pcap file.

Hey cyb3r-h0bbit,
Thank you for your contributions! The improvements you've made are great, and the additions to error handling will definitely make the script more user-friendly and robust.


[Fix] Router - sceneStyle must be View.propTypes.style

Hey!
I am interested to use result of StyleSheet.create for Router sceneStyle property but it's object for now, but should be another
Unexpected warning:

Thank

Find strange comment on the network:

Warning: View.propTypes has been deprecated and will be removed in a future version of ReactNative. Use ViewPropTypes instead.

I will review..

@aksonov Please merge


nixos/mysql: fix mysql creation query for MySQL 8

Description of changes
Tried to deploy a MySQL Primary Replica with MySQL 8 and encountered with master failing as it cannot create the replication user
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

There is right now no integration test for a cluster. 🤔

What about nixos/tests/mysql/mariadb-galera.nix?

I guess a galera cluster is something different than just simple primary replica 🤔 . But yea I could copy some stuff to make a primary replica


across map fail when using condensed arguments

Hi,
the manpage says:

If you care about extremely short one liners, arguments can be condensed when it does not cause ambiguity.

But condensed arguments are not handled the same way.
Example:
$ echo '{"a":1,"b":[true,false,null,"none"],"c":{"d":4,"e":5}}' > sample.json
$ sample.json ./jshon -a -t
number
array
object

$ <sample.json jshon -at
number
bool
parse error: type not mappable

Regards.

my take on golfing: -at should always mean -a -t
-ename should therefore mean -e -n -a -m -e, not -e name

Not really useful anymore, I'm closing my golf issue.


Use attributes in Fake Feature Flags.

Added the attributes to the json feature flag variance. If the change make sense I can apply it to the rest of the variances: boolean, int.

What would be the use case for passing in attributed to a fake? For our usages, we only use overrideBoolean... etc type methods to induce the flag condition we're looking to test a class against.

I have a use case where I am using Attributes and depending on those values the app behaves differently. The mechanism you describe works, but I think it's just a stop gap because Attributes were not considered in the fake lib.

My impression is that the attributes are for use in targeting rules in LaunchDarkly, I'm curious what use case your service would have in introspecting the attributes directly. For example, in notifications we include attributes for a given notificationId in the LaunchDarkly flag such that we can turn on traffic on a per notificationId basis. The only place the service code cares about the attributes is in the feature flag call since the targetting rules in LaunchDarkly encompass the decision logic using the attributes.

My impression is that the attributes are for use in targeting rules in LaunchDarkly, I'm curious what use case your service would have in introspecting the attributes directly.

I am using attributes to provide a json payload. This is based on the name of the job that's about to run.

The only place the service code cares about the attributes is in the feature flag call since the targetting rules in LaunchDarkly encompass the decision logic using the attributes.

I think my case is similar. The code that consumes the json payload from LaunchDarkly is generic and it passes down the json payload to each job.
I think this is similar when you add an override at the key level. You still want to test that your code is passing the key and that it would do something different if launch-darkly returns a different value than the default one. In my case, I am not using key but attributes.

@swankjesse Let me share with you a test case to make sure we are on the same page:
    // Can be overridden
    subject.overrideJson(FEATURE, JsonFeature("overrideJson"))
    assertThat(subject.getJson<JsonFeature>(FEATURE, TOKEN)).isEqualTo(JsonFeature("overrideJson"))

This must be true because the override works at the FEATURE level, since there is not override for the key TOKEN.
    // Can be overridden with specific keys
    subject.overrideKeyJson(FEATURE, "bad-joker", JsonFeature("overrideKeyJson"), Attributes())
    assertThat(subject.getJson<JsonFeature>(FEATURE, "bad-joker"))
        .isEqualTo(JsonFeature("overrideKeyJson"))

This must be true because we are overriding the key, so instead of getting JsonFeature("overrideJson") we must get JsonFeature("overrideKeyJson").
    assertThat(subject.getJson<JsonFeature>(FEATURE, "bad-joker", Attributes(mapOf("no-override" to "for-me"))))
        .isEqualTo(JsonFeature("overrideKeyJson"))

Is the expectation that this call returns JsonFeature("overrideKeyJson") and not JsonFeature("overrideJson")? The current implementation returns JsonFeature("overrideJson"), and I think your point is that that is incorrect.

@swankjesse PTAL


Controller aware of its own version

Description

implements new String debug variable class in controller which can  store statically allocated strings. Unit tests added. Currently, the variable command handler makes the assumption that all debug variables are 32 bit variables or, recently, some arrays of 32 bit variables. There is endian conversion that happens assuming this chunking. Therefore, String instances should be initialized with padding, i.e. sizes multiples of 4. This is ok for now because all initialization should happen via helper macro anyways. This cruft should be addressed much more easily once we have a generated comms protocol (#1073) for the debug interface, which should actually take care of most type and endian conversion when (de)serializing
platformio uses a Python script for extracting git version information and time of build, all of which is forwarded to the compiler as definitions. Side effect is that every time you build the controller, it will want to recompile every file. But this is pretty fast anyways, so should not be a problem
version.h provides statically allocated string literals with above info, and main.cpp encases them into String debug variables
debugger CLI TestData class was updated to encode git-provided version information in a similar manner to how controller stores it, making them comparable; both also obtain branch name for user convenience; also, both display timestamps similarly, for better readability.
there is now a general sanity check for version, branch compatibility and dirtiness of either controller or debugger CLI. In case of problems, user will be nagged when starting debugger and when trying to run a test
all version variables and vent serial number are now prefixed with "0_controller_" so they may be seen together when sorted
TestData now also stores all the ReadOnly debug variables, in a separate category from settings. Main motivation is to record the version data, but the rest may also be of interest.
TestData unique identifiers and, therefore, filenames have slightly changed, underscore separating the date from the time, also for easier readability
TestData format changes are not backwards-compatible

NOTE: should first merge #1164
Closes #1132
General checklist:

[x] I have performed a self-review, including - looked through the Files changed tab, browsed repository in my branch
[x] I have made corresponding changes to the documentation - to reflect changes in code, electrical or mechanical design
[x] All new documentation or graphics follow the documentation style guide
[x] All new content is linked, easily discoverable, does not require too many clicks
[x] I have reviewed any other relevant parts of our contributor wiki to ensure that this PR conforms to the standards
[x] I have given the PR a descriptive name (prefixed with WIP if it is not yet ready for review)
[x] I have tagged relevant reviewers

Code checklist:

[x] All new code follows our code style
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have described tests I used to verify my changes, instructions for reproducing them and any relevant configuration details.
[x] I ran the unit test suite and verified that all tests pass - new and old, locally and on CI
[x] I performed a clean build and verified that there were no warnings
[x] I ran our static analysis tools and verified there were no warnings
[x] Any dependent changes have been merged and published in downstream modules
[x] All source files have license headers

So, what I thought was a rebasing problem turns out was something more fundamental for why this PR had a drastic fall in test coverage. Turns out pio instantiates a new environment for each gtest module, with a new timestamp and this was making gcov recreate report files instead of appending them, or something...   tracking this down actually drew me into rewriting even more of the controller.sh script and balooned into what must be an amendment to this PR:

because of the above, unit tests for version.h had to be cut, unless we want to make a separate pio environment just for it? It was pretty trivial, only checking for string length. We could instead make an integration test that makes use of the debug interface to actually check that the values propagate out?
script for generating local coverage reports is now part of controller.sh, thus eliminating an extra file, docs updated
debugger CLI can now also be called from controller.sh, making the other alias script obsolete, docs updated
controller.sh now takes subcommands directly without --. Less finger ballet...
controller.sh is no longer verbose by default, only if ENV variable VERBOSE is set, which we do in CI
unit tests can be run separately, without all the other tests with controller.sh unit
running of unit tests or of the entire test suite automatically generates local coverage reports
order of tests in controller.sh test is such that unit tests come last, because the gcov data will have to be "fresh" for the CI to take, not overwritten by other pio environments, thus avoiding having to rerun unit tests for only that purpose
CI no longer runs static checks nor generates local coverage reports like it used to. Those are not used by CI, but it is expected that users (and sometimes reviewers) will get to see those with controller.sh test. Static checks may be reenabled later when we clean them up and can enforce them. For now, it is nice to get CI results faster.


Make F# Interactive great again!

I made a Suave server similar to FsAutoComplete (see FsInteractiveService) that is spawned in the background and used for handling the requests. I expect we can transfer that to the ionide org too.
The server has a couple of commands - to run snippet, reset FSI, cancel FSI evaluation (wasn't possible in Ionide before!) It also adds an experimental feature for formatting results as HTML (yes, FsLab :-))
There might be some trickery related to what FSharp.Core.dll and what FSharp.Compiler.Service.dll is used there, but aside from that, it should be good to go. Some testing would be appreciated too!

Oh, and you can collapse/expand the blocks in the output too :)

Just amazing <3

Merging it so I (and maybe others) can easily test it, will release new version after I played with it enough.

I transferred the FsInteractiveService project to the ionide org (and I'll do a commit to change the path in paket.dependencies).
It definitely needs more testing, so please report anything that's not working as expected!

:heart:


LoadError: cannot load such file -- factory_bot/awesome_linter

Hey, I was trying to install the gem in our project and followed the instructions in the readme, but I get an LoadError: cannot load such file -- factory_bot/awesome_linter when trying to run the rake task.
I commented out the require "factory_bot/awesome_linter" line in the rake task and then it worked, but wanted to flag this here to make sure this is the expected behavior, and if the require is not necessary I'd be happy to remove that line from the rake task

You're right, the example is wrong.
We didn't use the line require "factory_bot/awesome_linter" in any of out apps.
Thanks for pointing it.


build tools

Hi there I am attempting to setup a build environment for version 5.6.4 what software is required to compile this item from the source code? I am currently running Ubuntu-16.04

sudo apt-get update
sudo apt-get install nodejs npm zip git
curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.6/install.sh | bash

Open a new shell an run ./build.sh

You might also want to check out this tutorial from Tim Roes regarding building Kibana plugins: https://www.timroes.de/2015/12/02/writing-kibana-4-plugins-basics/


Settings Fragment closes on Screen rotation

Is it a ?

[x] Bug Report

[ ] Feature Request

[ ] Chore

Actual Behaviour
When user is in Settings Fragment and rotate the screen, the settings fragment is destroyed and Events layout page is loaded.
Expected Behaviour
Settings fragment should withstand app rotation.
Steps to reproduce it
LogIn -> Select settings option from drawer -> Rotate the screen -> Event's page gets loaded.

LogCat for the issue

OkHttp: --> GET https://open-event-api.herokuapp.com/v1/users/327/events?page[size]=0 http/1.1
D/OkHttp: --> END GET
D/OkHttp: <-- 200 OK https://open-event-api.herokuapp.com/v1/users/327/events?page[size]=0 (664ms)
D/OkHttp: Connection: keep-alive
D/OkHttp: Content-Type: application/vnd.api+json
D/OkHttp: Etag: 46d23668535421f2fa7b891b628453eb264ca55f
D/OkHttp: Server: gunicorn/19.7.1
D/OkHttp: Date: Mon, 15 Jan 2018 05:07:39 GMT
D/OkHttp: Access-Control-Allow-Origin: *
D/OkHttp: Via: 1.1 vegur
D/OkHttp: {"meta": {"count": 0}, "data": [], "jsonapi": {"version": "1.0"}, "links": {"self": "/v1/events?page%5Bsize%5D=0"}}
D/OkHttp: <-- END HTTP (115-byte body)
I/DatabaseRepository: Saved items of type class org.fossasia.openevent.app.common.data.models.Event in database
I/Logger: List of items successfully loaded with count: 0
I/art: Starting a blocking GC Explicit
I/art: Explicit concurrent mark sweep GC freed 8173(497KB) AllocSpace objects, 0(0B) LOS objects, 40% free, 17MB/29MB, paused 660us total 61.718ms

Screenshots of the issue
Where-ever possible attach a screenshot of the issue.
Android version and Phone Model
Moto G4 Plus
Would you like to work on the issue?
Yes

Hi
I would like to look upon this issue

@Tilak-Shenoy Please go ahead.

I think this is solved now. Please confirm @Masquerade0097

@iamareebjamal The issue is still there. EventList, Event Settings and Device Settings on rotating opens Dashboard.

Yes, it is still there. Fixing it.


MockFileSystem construction throws ArgumentOutOfRangeException

Using version 4.1.6 from NuGet, Windows, xUnit

In an xUnit test I have a MockFileSystem field
In the test constructor I have a MockFileSystem(IDictionary, string) constructor call
This constructor throws:

System.ArgumentOutOfRangeException : Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: startIndex
Stack trace:

at System.String.IndexOf(String value, Int32 startIndex, Int32 count, StringComparison comparisonType)
at System.IO.Abstractions.TestingHelpers.MockFileSystem.AddDirectory(String path
at System.IO.Abstractions.TestingHelpers.MockFileSystem..ctor(IDictionary`2 files, String currentDirectory)

Relevant lines:
            _darkFile = Path.Combine("baseDir", "subDir", "darkFile");
            _brightFile = Path.Combine("baseDir", "subDir", "brightFile");
            _defectFile = Path.Combine("baseDir", "subDir", "defectFile");
            _correction = new Mock<ICorrection>();
            _fs = new MockFileSystem(
                new Dictionary<string, MockFileData>
                {
                    { _darkFile, new MockFileData(string.Empty) },
                    { _brightFile, new MockFileData(string.Empty) },
                    { _defectFile, new MockFileData(string.Empty) },
                }, "."); // When I use the default `""`, no exception is thrown

Although this clearly is a regression: What is the purpose of setting the working directory to .?

This is an older piece of code where I tried forcing MockFS to treat the paths as absolute.

This is an older piece of code where I tried forcing MockFS to treat the paths as absolute.

Thank you! As you say "I tried" I assume it didn't really work out well 😅
I consider using any kind of relative paths for this constructor parameter as invalid (relative to what should it be?) and would propose to just provide a better exception.

Well, I don't want anything prepended in front of those paths. If I don't pass that workdir argument, it's taking the working directory of the REAL file system and prepending it.
I've been digging through the exact same topic some time ago here: #350

Well, actually it now defaults to the root directory (C: on Windows, / on Unix):
https://github.com/System-IO-Abstractions/System.IO.Abstractions/blob/761c6e3d0acde7e36334369773f8822700a35c7d/System.IO.Abstractions.TestingHelpers/MockFileSystem.cs#L23


Do not use items/layouts (mutable identifier) as hash key

Document’s @identifier is mutable, and is therefore not a good candidate for use in a hash key.

[x] Add test case
[x] Remove invariant check

Alternative idea: Let the directed graph only contain references, e.g. [:item, '/foo.md'].

This breaks equality (two objects can be equal even if their hash is different)

The directed graph will now store only references, rather than objects themselves.


HLS Bounding Box Anti-meridian fix

Description

This branch addresses an issue in themetadata_utils.get_geographic_boundaries_from_mgrs_tile function for tiles that crossed the anti-meridian. The function has been updated with fixes that were applied to the PCM version of the function, which were originally provided by Gustavo Shiroma.

Affected Issues

Fixes #291

Testing

The following unit test has been added to validate that the anti-meridian case is now handled correctly:

    def test_get_geographic_boundaries_from_mgrs_tile_nominal_antimeridian(self):
        """Test MGRS tile code conversion with a tile that crosses the anti-meridian"""
        lat_min, lat_max, lon_min, lon_max = get_geographic_boundaries_from_mgrs_tile('T60VXQ')

        self.assertAlmostEqual(lat_min, 62.13198085489144)
        self.assertAlmostEqual(lat_max, 63.16076767648831)
        self.assertAlmostEqual(lon_min,<PHONE_NUMBER>0795243)
        self.assertAlmostEqual(lon_max, -179.06925552951074)

Note that the lat/lon values differ slightly from the test case provided in the original bug report. This is because as part of this fix, 4.9km of margin is now added to the bounding box footprint to bring it in line with the HLS standard.

@sjlewis-jpl I've updated the conditionals for lon_max/lon_min according to your feedback, and ensured that the numbers I get match what you've posted. Let me know if anything else still looks off.


Upgrade to Swift 3.

Hey there!
Thanks for the ParallaxAutoLayout project, it came in very helpful! In this PR I updated it to work with Swift 3 / Xcode 8 🤘

Awesome, thank you!


Toolbar covered up by Iphone text selection options

When viewing the editor on an iphone, highlighting any text will also bring up the native iphone text options, obscuring the toolbar. Making the toolbar appear below the selection on small screens instead of above could be an easy fix.

Hi @bpurtz ! First, sorry for the delay. Megadraft does not yet have full mobile compatibility (like Draft.js) yet, but we are planning to include it in nearby roadmaps. Keep an eye !

Hi @mogavin, any updates here?

Hi, @an2323 ! Megadraft does not yet officially support mobile devices. An alternative to using it on these devices is to disable the toolbar and rich text buttons (in native iphone text options):
const disableRichTextButtonsStyle = `.public-DraftEditor-content[contenteditable=true] {
      -webkit-user-modify:read-write-plaintext-only;
      user-modify: read-write-plaintext-only;
 }`

//inside component render
<Fragment>
 <style>{disableRichTextButtonsStyle}</style>
 <div style={{ marginLeft: 63 }}>
   <MegadraftEditor
     editorState={this.state.editorState}
     onChange={this.onChange}
     Toolbar={() => null}
   />
 </div>
</Fragment>


keras optimizer.iterations are not properly save & restored

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Any
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: NA
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.5.0rc2
Python version: 3.7
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
optimizer.iterations are not properly save & restored. After restoring iterations are reset as 0, which leads to wrong lr based on lr_scheduler
Describe the expected behavior
provide an option to either reset it or not, for backward compatibility maybe default to reset
Contributing - Do you
want to contribute a PR? (yes/no): - Briefly describe your candidate solution
(if contributing):
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
import tensorflow as tf

@tf.keras.utils.register_keras_serializable(package='Custom', name='MyScheduler')
class MyScheduler(tf.keras.optimizers.schedules.LearningRateSchedule):
    def __init__(self, **kwargs):
        super(MyScheduler, self).__init__(**kwargs)

    def __call__(self, step):
        return step

    def get_config(self):
        return {}

inputs = tf.keras.Input(10)
outputs = tf.keras.layers.Dense(10)(inputs)
model = tf.keras.Model(inputs, outputs)

lr_scheduler = MyScheduler()
optimizer = tf.keras.optimizers.Adam(learning_rate=lr_scheduler)
model.compile(optimizer=optimizer, loss="mse")

def get_dataset(repeat):
    inputs_data = tf.ones([16, 10])
    labels_data = tf.ones([16, 10])
    dataset = (
        tf.data.Dataset.from_tensors(inputs_data)
        .map(
            lambda x: (
                inputs_data,
                labels_data,
                None,
            )
        ).repeat(repeat)
    )
    return dataset

model.fit(get_dataset(3), epochs=1)
print(model.optimizer.iterations, lr_scheduler(model.optimizer.iterations))

path = "./foo/"
model.save(path)
loaded = tf.keras.models.load_model(path)
loaded.fit(get_dataset(4), epochs=1)
print(loaded.optimizer.iterations, lr_scheduler(loaded.optimizer.iterations))

the last print shows 4, but it should 3+4=7
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

@blackyang _ think this prints the number of individual batches where the updates have been performed, in your case if you are doing n iterations on your data then optimizer.iterations prints n.

@blackyang I think this prints the number of individual batches where the updates have been performed, in your case if you are doing n iterations on your data then optimizer.iterations prints n.

The problem is that OptimizerV2.iterations is exactly what gets passed to a LearningRateSchedule to determine the learning rate. If it reports 4 when it should be 7 then training isn't going to work properly when it saves and resumes.
https://github.com/tensorflow/tensorflow/blob/d05aa3b7d9ca3de1a44c6ca5354a3c859cda727b/tensorflow/python/keras/optimizer_v2/optimizer_v2.py#L1015

@sachinprasadhs thank you for your reply! yes I completely understand why it prints 4 instead of 7, I was saying that it should print 7 (or have an option to specify whether to print 4 by resetting or still print 7), otherwise the learning rate scheduler is wrong
another way is to update learning rate scheduler to not use this iteration
any thoughts? thank you!

I was able to reproduce the error in tf 2.6 . Please find the gist here.Thanks

https://github.com/keras-team/keras/blob/master/keras/saving/saved_model/load.py#L86-L91
/cc @k-w-w


Crashes under M1 Rosetta

macOS 12.3.1 (Monterey)
MacBook Air M1, 2020
Games will crash on macOS if running under Rosetta:
Application Specific Information:
assertion failed [library_fd != -1]: Failed to open /Library/Apple/usr/libexec/oah/libRosettaRuntime
(Init.cpp:342 load_runtime_library)

I'm happy to do some testing for this on my Mac, if needed.
Maybe we can just add /Library/Apple/usr/libexec/oah/ to policies/sandboxexec.go? It's possible that could be unsafe/lead to escaping the sandbox though. I can't find much documentation on this.


Add kafka log & metrics receiver support

Sample Log:

Windows 3rd party ran successfully previously, and shouldn't be affected by most recent changes. Seems something went wrong in the initialization though not a clear quota issue or anything in the logs.

Only failure on last 3rd party integrations run was for memcached --- FAIL: TestThirdPartyApps/sles-12/memcached (7043.24s) with a repository access error, shouldn't be relevant to this PR.

@qingling128 looks like those last few renames in sample/test yaml files were just in a local buffer and not saved & committed, oops! Running one last kokoro.

Only failing test at the moment is tomcat on debian
--- FAIL: TestThirdPartyApps (0.00s)
    --- FAIL: TestThirdPartyApps/debian-10 (0.00s)
        --- PASS: TestThirdPartyApps/debian-10/redis (151.56s)
        --- PASS: TestThirdPartyApps/debian-10/memcached (152.11s)
        --- PASS: TestThirdPartyApps/debian-10/couchdb (156.93s)
        --- PASS: TestThirdPartyApps/debian-10/apache (168.32s)
        --- PASS: TestThirdPartyApps/debian-10/mongodb (172.24s)
        --- PASS: TestThirdPartyApps/debian-10/postgresql (178.89s)
        --- PASS: TestThirdPartyApps/debian-10/kafka (196.12s)
        --- PASS: TestThirdPartyApps/debian-10/jvm (202.12s)
        --- PASS: TestThirdPartyApps/debian-10/cassandra (211.43s)
        --- PASS: TestThirdPartyApps/debian-10/nginx (216.01s)
        --- PASS: TestThirdPartyApps/debian-10/solr (220.03s)
        --- FAIL: TestThirdPartyApps/debian-10/tomcat (225.44s)
        --- PASS: TestThirdPartyApps/debian-10/elasticsearch (233.25s)
        --- PASS: TestThirdPartyApps/debian-10/mysql (265.26s)
        ```


Keymap updates

Added a Swedish keymap, and fixed the missing positions on Q-knob and status LEDs

Thanks for the PR!


Feature/line chart shadow

If I just upgrade to 0.9.2 we alsways get shadows? looks like a bug? I had a line with color transparent, and now it's showing... until i added a shadow property Shadow(color: Colors.transparent) Or is this expected behavior?

No, this is not expected behavior, please file an issue.
Thanks!


Add PageLoaded event for WebViewer

A suggestion from the power users was to add an event to report when the WebViewer finishes loading a page. The typical approach is to use a clock to check for some state. Android provides the WebViewClient class, with an onPageFinished callback, that should support adding this behavior to App Inventor. A rough sketch for completion is:

[ ] Add PageLoaded event to WebViewer
[ ] Extend WebViewer.WebViewerClient implementation to handle this callback and fire the associated event.
[ ] Increment WEBVIEWER_COMPONENT_VERSION in YaVersion
[ ] Add noUpgrader for new version in versioning.js
[ ] Update YoungAndroidFormUpgraded to update the version number

I will start working on this issue.

@ledeni56 Thanks for taking a look. I think I've already spelled out most of the steps you'll need to take to finish this task, but let me know if you have any questions.

@ewpatton Can you please check out my commit:
https://github.com/ledeni56/appinventor-sources/commit/a00b63f5d1508bb04a11b1b124464b39e0672070
I'm still trying to understand the code and how it all works.
What else do I need to add to have the event appear on the Web application as a block in WebViewer?

@ledeni56 The code you have written is sufficient for the block to appear in the AppInventor. Simply run the ant build again on your local machine, then run the server and open the AppInventor application via your localhost, and test to see if it works!

@ledeni56 Functionally it looks good, but one change I would recommend is including the URL of the page loaded as a parameter in the event. As @lightingft mentions, run the build again to update the blocks list for the web viewer. Don't forget per the other points on my checklist to update the version number in YaVersion.java and add upgrade paths in YoungAndroidFormUpgrader.java and versioning.js so that existing WebViewers are upgraded cleanly (in both cases, the operation is a no-op, but it's good practice).


Create directory for local only notebooks

Overview
I have some untracked local notebooks that probably don't belong in git but are still things I'd like to save. This PR creates a new directory called notebooks/local/ that only contains a .gitignore file so folks can stash old notebooks in their pudl directory but not have them tracked in git.
Testing
How did you make sure this worked? How can a reviewer verify this?
# To-do list
- [ ] Make sure full ETL runs & `make pytest-integration-full` passes locally
- [ ] For major data coverage & analysis changes, [run data validation tests](https://catalystcoop-pudl.readthedocs.io/en/latest/dev/testing.html#data-validation)
- [ ] If updating analyses or data processing functions: make sure to update or write data validation tests
- [ ] Update the [release notes](../docs/release_notes.rst): reference the PR and related issues.
- [ ] Review the PR yourself and call out any questions or issues you have

Ah yes I screwed that up. I added a README to notebooks/local and added a new local/** entry added to the notebooks/.gitignore.


Map pins lost their targets

The map pins that previously had targets no longer have them.

The import is creating notes as expected for me (PF1 on Foundry 11 and 12).
Could you provide the version of Foundry you're using, as well as what game system and the version of that system please.

Also, are any errors reported in your browser's console? (which can be opened with F12 on Windows O/S)

Foundry v12.331
D&D 5e v.3.3.1
I'm not seeing any console error either during import or when looking at the scene or pin.
I'm guessing it must have something to do with the journals being in a compendium. I'm trying to manually create links between map pins and journals in compendiums and I can't figure out how to make it happen.

Ah, that would be the issue.
It isn't possible to create Map Notes to journal entries which are stored in compendiums.
Only the "id" of the Journal Note is stored in the Map Note (but the full uuid, which would include the name of the compendium).

Core Foundry behaviour is that If a journal entry is dragged from a compendium onto the map, then the journal entry is imported into the Journal sidebar.

In the short term, I've added a NOTE into the README indicating that scene notes can't link to journal in compendiums. I will add a similar note into the module's settings panel in the next update.

Glad to know what the problem is, but dang is that Foundry limitation disappoiting! Now I can't really use that wonderful import to compendium feature, because a bunch of my journals and maps are linked into a giant web of content.

Yes, it's unfortunate.
At least the Item compendiums might be a useful feature - although perhaps less useful for world-building purposes.

I may investigate a solution in the future, so that directly linked journals are kept in the journal sidebar instead of a compendium, but it probably will make the foundry world look untidy.

Version 2.12.3 contains a work-around that will work in Foundry V12 upwards.
If journals are stored in a Compendium, then a local JournalEntry will be created for each note in the world which contains an @Embed of the actual journal entry stored in the Compendium.
This should still allow the world to remain a small(ish) size when a large number of journals are created in a Compendium.
(A future evolution might store all those local scene notes as pages in a single journal entry, rather than a separate journal entry for each scene note.)


Support for Touch Bar

Funny or not, maybe an idea would be to detect if Touch Bar is available and add something in there. 😂

Sure, if we know how to program that part and there are actually ideas what to show there. Until then, I'll close this one. Feel free to reopen, once you have more concrete ideas.


Questions on results of linear_vrnn

Excuse me,
When I process your Linear_vrnn model with params in params.py, I got Structure Euclidean Distance about 0.24 and SCE about 4, could please give some guidance on how to get better results?
I followed the process: train linear_vrnn -> decode without test_batch -> interpretion
Thanks a lot for your help.

Hi, I am not sure about your runtime details. Generally speaking, the bow-loss weight in hyperparameters has a significant impact on the performance.


Support langchain vectorstores

Goal
This PR aims to add support for Langchain Vectore Stores
For a list of vector stores currently supported by Langchain, please refer to here
Details

gpt-researcher currently generates embeddings via openai whenever we call it with scraped data from the web or local files.
For those that already use langchain with a corresponding vector store, this step is redundant as embeddings will have been generated (and stored)
We can use the vector store as the document store instead of re-generating embeddings every time we perform research.

TODO

[x] create unit test
[x] add example to documentation using FAISS memory vector store

Would appreciate some early reviews, comments, & questions.

Looks like an awesome contribution for the community! The vector store section of the backend is definitely a black box for me currently, so I'd love to see what's getting persisted on the backend across runs.
Initial questions:

how are you running the FAIS service? (It doesnt seem like the docker image is very popular or has simple docs)
have you considered the PGVector store or do you perhaps have an example of how the Vector store is selected & leveraged?

Looking forward 🙏

Unit test and documentation has been added.
@ElishaKay @assafelovic ready for review.

@hslee16, holy shnikes!
That's awesome
Cant wait to play with it over the weekend
@assafelovic, I'll pass you a Postgres connection string for the tests
Ideas for further down the roadmap:

when a user uploads documents, docs are embedded & added to the vectorstore
scraped webpages are inserted into the vectorstore
user queries & other user input can be stored in the vector store for personalization

Brilliant 👏

@ElishaKay while your ideas are great, they are unfortunately outside the scope of this PR.
I'll visit them once this one is merged.

@hslee16 agreed - let's keep the PR light.
P.S. for the faiss-cpu, we can move it directly into the docker-tests by editing docker-compose.yml of the the gpt-researcher-tests container to:
pip install pytest pytest-asyncio faiss-cpu &&
In that way, faiss-cpu will only be installed for tests - we're trying to keep the master requirements.txt as lean as possible.

@ElishaKay done


Minor refactoring in SqueezeNet

Removed FIXME
2) Changed the version style parameter to arch parameter as in ResNets to remove the arch = 'squeezenet' + version statement.

Closing following discussion. Once again, thanks a lot @ekagra-ranjan for the PR!


When no "Participants" segment is defined, do not show broken layout

There is no need to show a half-broken layout when the Participants segment is not provided.
Especially the role names "Chair", "Vice Chair" are all arbitrarily defined by the groups, there is technically no default.

BTW, I confirm that with the proper Participants clause is entered, the output is correct.
From P2874:

Disagree. When there are no participants present, we should be showing the dummy participants: that is the behaviour of the Word template. The problem currently is that the participants are in <...>; even with that escaped to <...>, they are being mistreated as tags.

Once again, Nokogiri .text is converting "<" to "<", and needs to be preempted with HTMLEntities.encode()


Form Validation - Validate File

https://github.com/twbs/bootstrap/blob/2f4e785a8c623fbe1b011edabecafe99b9f0817b/scss/mixins/_forms.scss#L53
I would like to add a file validation on the following form:
.form-control,
.form-control-file,

@mdo We can not change the style of <input type="file">, but how about adding support for validation feedback?
  .form-control-file {
    .was-validated &:#{$state},
    &.is-#{$state} {
      ~ .#{$state}-feedback,
      ~ .#{$state}-tooltip {
        display: block;
      }
    }
  }

This does seem like a bug.
For example, .invalid-feedback elements do not show up when they're immediately after .form-control-file.is-invalid elements, but they do when after .form-control.is-invalid elements.
In fact this was reported in #24831 but I think the fix there only fixed the situation for custom file inputs, rather than the standard ones.
Here's a demonstration (copied from that issue but with Boostratp v4.0.0): https://jsbin.com/vodacon/edit?html,output


2.0.0 Major refactoring

Changes

Create a cleaner lua module
Have custom log message formatting via template (#1) via template
Have custom message for duplicated warning message via template_duplicate
New formatting options :

time_format
renamed linebreak_treshold which was previously length_max (#2 )
added max_length to cut too large tables

Removed inline contexting
Added global context with the LLLOGGER_CONTEXT env variable

Closes #1


Understanding TARGETS

Hello,
Great job with this adapter! I've started playing with it and it's great; however, I don't get how should I interpret the TARGET column when doing a kubectl get hpa/...:
TARGETS
6262500m/30 (avg)

Would love some insights so I can understand this better. Thanks!

You can refer to the HPA docs for details about how HPA works. The TARGETS here shows current average value is 6262500m and the target average value is 30.

@chankh First of all thank you for this project it scale really well. However, I don't understand what this value means.
I tested it with scale-out event for several hours where constant number of 500 messages were in the queue. and my HPA show the following results:
sqs-consumer-scaler   Deployment/sqs-consumer   166667m/10 (avg)   1         15        15         11h
sqs-consumer-scaler   Deployment/sqs-consumer   133334m/10 (avg)   1         15        15         11h
sqs-consumer-scaler   Deployment/sqs-consumer   100/10 (avg)       1         15        15         11h
sqs-consumer-scaler   Deployment/sqs-consumer   66667m/10 (avg)    1         15        15         11h
sqs-consumer-scaler   Deployment/sqs-consumer   33334m/10 (avg)    1         15        15         11h
sqs-consumer-scaler   Deployment/sqs-consumer   0/10 (avg)         1         15        15         11h

What does those 'm's mean? Why they are different, although the number of messages in the queue is constant?
I understand what Targets means in HPA, however I don't understand how those numbers refer to 'ApproximateNumberOfMessagesVisible' metric in Cloudwhatch.
Thanks.


Avoid infinite recursion in Error.prepareStackTrace

Refs #9660
Previously, prepareStackTraceWithStackAssignment could end up calling itself when third-party code assigned Error.prepareStackTrace back to its original value. Now, we short-circuit this process if the rawStack property has already been assigned.
:pear:d on this with @maxbrunsfeld.

Also fixes #9860.

Working for me 👌

:heart:


CoxPH "general" model fit p-value

Sort of a question and suggestion combined -- comparing to output from R's coxph, the latter includes in its output the p-value of the fit as a whole, or more specifically likelihood ratio test=X  on Y df, p=Z (example below).
Does lifelines CoxPH fitter have a similar estimate attached to it? I couldn't find one, and can work out how to calculate it if not, but I thought it prudent to ask before assuming.
> require(survival)
> data(lung)
> res.cox <- coxph(Surv(time, status) ~ sex, data = lung)
> summary(res.cox)
Call:
coxph(formula = Surv(time, status) ~ sex, data = lung)

  n= 228, number of events= 165

       coef exp(coef) se(coef)      z Pr(>|z|)
sex -0.5310    0.5880   0.1672 -3.176  0.00149 **
---
Signif. codes:  0 ‘***’ 0.001 ‘**’ 0.01 ‘*’ 0.05 ‘.’ 0.1 ‘ ’ 1

    exp(coef) exp(-coef) lower .95 upper .95
sex     0.588      1.701    0.4237     0.816

Concordance= 0.579  (se = 0.022 )
Rsquare= 0.046   (max possible= 0.999 )
Likelihood ratio test= 10.63  on 1 df,   p=0.001111
Wald test            = 10.09  on 1 df,   p=0.001491
Score (logrank) test = 10.33  on 1 df,   p=0.001312

To be clear: is the Score (logrank) test the test that all coefficients are 0?
So lifelines doesn't have this, but it's not too hard to add in the next release.

Yes. In fact all three of the last lines in the summary are different score tests of just that, at least according to my understanding of John Fox's 2008 Cox PH paper:

"The likelihood-ratio, Wald, and score chi-square statistics at the bottom of the output are asymptotically equivalent tests of the omnibus null hypothesis that all of the β’s are zero."

I don't have the knowledge to say which of them would be preferable to implement in lifelines, though I can say that for my purposes the logrank is test is probably what I would use.
(Side note: my original description was misleading, as I mentioned the wrong output. I'll edit it for clarity in the future.)

The three tests are only comparable when the n is large. Wald performs poorly in situations of a low sample size. One other issue is that Wald is not invariant under reparameterization. Likelihood ratio and score statistics are
Ideally, all three would be implemented. Likelihood ratio or score would be better though

I added Likelihood ratio test to the most recent version of lifelines (0.14.4). I'm not sure if I want to add the other two statistics: Wald seems out of fashion.


Allow the VirtualDAC object to handle strings in the gate map

We should change the VirtualDAC to allow input like gate_map={'P0': (0,'DAC_0'), 'P1': (0,'DAC_1')}. This means that the VirtualDAC can be used with DACs other than the IVVI and SPI D5a.

Fixed by #481


Restore missing question mark in delete confirmation message

The dashboard name should be in bold to give it emphasis. In order to do this with internationalization, use the Trans component. The Trans component requires i18n in the context, so i18n was added at the root context (in App.js) so it will be available for any situations where Trans component is needed.

@edoardo @jenniferarnesen after release once #140 is merged we will only use 'd2-i18n' library for translations. I have removed react-i18next. Everything else is automated from there onwards.


Link markup does not recognize HTML Symbol entities

Describe the bug.
Link markup does not recognize HTML Symbol entities
To Reproduce:
Use an HTML Symbol entity in the text component of the link markup.
Expected behavior.
The symbol should be seen when the markup is rendered.
Instead, the characters comprising the symbol's name are shown.
Symbols are shown when the Link macro is used. Markup should show them too.
Screenshots.
for chrome w/sugarcube 2.36 and firefox w/sugarcube 2.37 are attached
Project details.

SugarCube Version: both 2.36.1 and 2.37.0 alpha 18
Included Add-ons: none
Included Libraries: none
Compiler & Version: Tweego 2.1.1

Desktop details.

OS & Version:  Windows 10 Pro x64 22H2
Browser & Version both Chrome 119 (64-bit) and Firefox 119 (64-bit)]

Smartphone/tablet details.
not tested
Additional context.
Zip containing test_symbol.tw is attached.
test_symbol.zip

From the link markup documentation:

SugarCube's link markup consists of a required Link component and optional Text and Setter components. The Link and Text components may be either plain text or any valid TwineScript expression, […]

The link markup's text component has never been treated as HTML, thus HTML named entities and numeric references will not work.
Changing that in v2 would be a breaking change for very little benefit.
If you need such characters in links, either:

Use the <<link> macro.
Use the HTML <a> tag.
Use the literal character—e.g., `[[Literal characters©™|…]]

The underlying issue for me is that I sometimes want multi-word text components not to be broken across multiple lines on the screen. I had hoped to be able to use   between them.
Fortunately, it seems that  using the HTML token pair... around the link markup does what I need.

From: Thomas M. Edwards @.***>
Sent: Tuesday, November 14, 2023 12:49 AM
To: tmedwards/sugarcube-2
Cc: Selden E. Ball, Jr; Author
Subject: Re: [tmedwards/sugarcube-2] Link markup does not recognize HTML Symbol entities (Issue #283)
From the link markup documentationhttps://www.motoslave.net/sugarcube/2/docs/#markup-link:
SugarCube's link markup consists of a required Link component and optional Text and Setter components. The Link and Text components may be either plain text or any valid TwineScript expression, […]
The link markup's text component has never been treated as HTML, thus HTML named entities and numeric references will not work.
Changing that in v2 would be a breaking change for very little benefit.
If you need such characters in links, either:

Use the < macro.
Use the HTML  tag.
Use the literal character—e.g., `[[Literal characters©™|…]]

—
Reply to this email directly, view it on GitHubhttps://github.com/tmedwards/sugarcube-2/issues/283#issuecomment-1809586328, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AACWNDDO4CM7MCJYDMXABELYEMA5LAVCNFSM6AAAAAA7KBMOWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBZGU4DMMZSHA.
You are receiving this because you authored the thread.Message ID: @.***>


[SGTM performance] Modify comment webhook to be have fewer mutations

Summary

issue comments have 3 supported actions: created, edit, and deleted. We lock on the issue id (pull request id) and to a full update_task on the pull_request body when we don't need to
instead of full updating, only upsert the comment and add followers if there are any
instead of locking on the pr id, lock on the comment id

Asana tasks:
https://app.asana.com/0/1200740774079340/1207209762057512/f]
https://app.asana.com/0/1200740774079340/1207209762057512/f
Relevant deployment:
CC: @prebeta @suzyng83209 @vn6 @michael-huang87 @harshita-gupta
Test Plan
Risks
Pull Request: https://github.com/Asana/SGTM/pull/179
Pull Request synchronized with Asana task

test comment


Error as "amount should be a number string"  with useOneInchSwap hook from react-moralis

Issue Description
Facing issue while using the useOneInchSwap hook from react-moralis
Steps + code to reproduce
Params:
{
"chain": "bsc",
"fromTokenAddress": "0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee",
"toTokenAddress": "0x55d398326f99059ff775485246999027b3197955",
"amount": "0.1",
"fromAddress": "0xc3cd0171dfdd36cb1d77efc07578b69252d65206",
"slippage": 1
}
Passing this object as param in "swap" function in "useOneInchSwap"
Error
{
"statusCode": 400,
"error": "Bad Request",
"description": "amount should be a number string",
"meta": [
{
"type": "paramNumber",
"value": "amount"
}
],
"requestId": "be597da9-171e-4001-a38c-74285704d32f"
}
Environment
Server

Moralis server version:  0.0.302

Client

react-moralis version: 0.3.11
Moralis SDK version: 0.0.183
Operating system: Mac OS
Browser: Brave Browser

This should be solved by updating server to 0.0.330, see more details or questions on this issue in: https://forum.moralis.io/t/1nch-getquote-function-type-def-error-amount-should-be-a-number-string/4354/43


So sorry these commits are not in stages

Would love to talk it over with you if you get the time Matt, upgraded to allow for umbraco 8 using the new migration... technique?
I can only apply this PR to the develop branch but maybe good to have a v8 version unless the previous nuget builds are fine to live as they are.
Initially the framework needed updates to 4.7.2 to allow for the new UmbracoCMS.Core
Updating Nugets:
UmbracoCms.core version - 8.0+
Microsoft.AspNet.WebApi.WebHost - <IP_ADDRESS>
After this, the next step was converting over how the code access's the database using the new Composer.Current...
Once this was complete you are able to run the /oauth/token endpoint successfully once you initialise the OAuth.ConfigureEndpoint("/oauth/token", ... method within a IComponent and register it using the IUserComposer.
This was the easy bit, although this was not able to use refresh token store or client store.
So I have removed the old migration runner and updated to use the new practice adopted by umbraco v8, which was good to learn. I have built 2 plans and included a helper to pull the state from the db. As it doesnt support Up / Down anymore I have included a remove as well as the initialise migrations.
I didnt expect to get where I was so happy to go over it and take some pointers from you about the code. Hope its useful for you, I will be using it actively in my current project and havent encountered any issues as of yet.
It could maybe do with a clean up or discussion over versioning the states as I know you used semver before, so it can either be removed now or states amended to use it.

Hey Marc,
This is awesome. I haven't looked through it all yet so I'll get back to you as soon as I can with feedback, but just wanted to say a big thank you in the meantime.
Matt

Ill change the DB context to use IScopeProvider, unless you know of a better way? I think registering this as a difference service may be good so we can use it in the AuthClientStore and RefreshTokenStore without the need to add the param to the constructor of each when calling them?

@qz2rg4 Hey mate, the changes I have implemented on this PR work for me on a prod project. There is one ailment I found relating to header being set twice for CORS but I can add that issue in. The changes are failing to build but @mattbrailsford will review when he has time. In the meanwhile happy to help you out if you need it. @marcD8 is an old account from a previous role so hit me up on @marccameron3d


Unable to Build from Source

E:\Forked Repos\DavincisVessels\MovingWorld\build\sources\test\java\com\elytradev\movingworld\common\experiments\mixin\MixinEntityPlayerMP.java:15: error: No obfuscation mapping for @Inject target onUpdate     @Inject(method = "Lnet/minecraft/entity/player/EntityPlayerMP;onUpdate()V", at = @At(value = "INVOKE"))     ^ E:\Forked Repos\DavincisVessels\MovingWorld\build\sources\test\java\com\elytradev\movingworld\common\experiments\mixin\MixinEntityPlayerSP.java:26: error: No obfuscation mapping for @Inject target onUpdate     @Inject(method = "Lnet/minecraft/client/entity/EntityPlayerSP;onUpdate()V", at = @At(value = "INVOKE"))     ^ E:\Forked Repos\DavincisVessels\MovingWorld\build\sources\test\java\com\elytradev\movingworld\common\experiments\mixin\MixinPlayerContainerEvent.java:17: error: No obfuscation mapping for @Inject target getContainer     @Inject(method = "Lnet/minecraftforge/event/entity/player/PlayerContainerEvent;getContainer()Lnet/minecraft/inventory/Container;", at = @At(value = "RETURN"))     ^ E:\Forked Repos\DavincisVessels\MovingWorld\build\sources\test\java\com\elytradev\movingworld\common\experiments\mixin\MixinWorldServer.java:22: warning: Cannot find method mapping for @At(INVOKE.<target>) 'Lnet/minecraftforge/common/DimensionManager;setWorld(ILnet/minecraft/world/WorldServer;Lnet/minecraft/server/MinecraftServer;)V'     @Redirect(method = WORLD_SERVER_CONSTRUCTOR, at = @At(value = "INVOKE", target = DIM_MANAGER_SETWORLD))     ^ E:\Forked Repos\DavincisVessels\MovingWorld\build\sources\test\java\com\elytradev\movingworld\common\experiments\mixin\MixinWorldServer.java:22: warning: No obfuscation mapping for @Redirect target <init>     @Redirect(method = WORLD_SERVER_CONSTRUCTOR, at = @At(value = "INVOKE", target = DIM_MANAGER_SETWORLD))     ^ E:\Forked Repos\DavincisVessels\MovingWorld\build\sources\test\java\com\elytradev\movingworld\common\experiments\mixin\MixinWorldServer.java:29: warning: Cannot find class mapping for @At(NEW.args[class]) 'net/minecraft/entity/EntityTracker'     @Redirect(method = WORLD_SERVER_CONSTRUCTOR,     ^ E:\Forked Repos\DavincisVessels\MovingWorld\build\sources\test\java\com\elytradev\movingworld\common\experiments\mixin\MixinWorldServer.java:29: warning: No obfuscation mapping for @Redirect target <init>     @Redirect(method = WORLD_SERVER_CONSTRUCTOR,     ^ E:\Forked Repos\DavincisVessels\MovingWorld\build\sources\test\java\com\elytradev\movingworld\common\experiments\mixin\MixinEntityPlayerSP.java:23: warning: Unable to locate obfuscation mapping for @Shadow field     @Shadow     ^

Move your information to hastebin or gist, and give more information like the branch you're on, whether you're using the gradle wrapper or an installation. Closing until that's been done.


missing semi-colon on last code line

final C# statement needs closing semi-colon
hint: this is going to be the easiest refactoring you do today!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4c51e06b-f665-e97c-0862-02a7c33402ad
Version Independent ID: b204adb3-855a-db49-a25c-71df4daf5988
Content: How to deserialize an object using XmlSerializer
Content Source: docs/standard/serialization/how-to-deserialize-an-object.md
Product: dotnet-fundamentals
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

@DickBaker Thanks for reporting that


Window ExtendClientArea Broken in 11.1-beta2

Describe the bug
It seems both ExtendClientAreaChromeHints and ExtendClientAreaToDecorationsHint have been broken in 11.1 beta2.

The app is not extending into the titlebar at first window load. It does however fix itself when the app is resized
~The system window buttons (minimize, maximize, close) never appear~ (duplicate of #15522)

To Reproduce
<Window
    ExtendClientAreaChromeHints="PreferSystemChrome"
    ExtendClientAreaToDecorationsHint="True">

Expected behavior

Avalonia version
11.1-beta2
OS
Windows
Additional context
There are recent PRs in this area. One of them broke this functionality.
Otherwise, on my end this code has worked fine since 11.0 previews and is unchanged since.

Duplicate of #15522?

#15522 is a duplicate of point number 2 above (no caption buttons). However, the first one appears to be different.

#14470 is an obvious candidate, but it was included in beta1. Was everything OK in that version?

https://github.com/AvaloniaUI/Avalonia/pull/14470 is an obvious candidate, but it was included in beta1. Was everything OK in that version?

@TomEdwardsEnscape Yes, 11.1-beta1 doesn't have these issues.

Also note that extend into client area does work again if the Window is resized. So another PR just broke the startup path that was applying this property on first load.
(The caption buttons are still broken reguardless)


feature request: Showing the git status of a file

Did you check existing requests?

[X] I have searched the existing issues

Describe the feature
It would be very helpful to show the git status of a file (modified, untracked, etc.).
A good starting point on how it should look is the following: https://github.com/tamago324/lir-git-status.nvim
Provide background
No response
Additional details
No response

Hi! This is a very reasonable request and, judging from its inclusion in some other popular file browsers, at least somewhat popular. Unfortunately, it is a moderate amount of work to implement in a mediocre way, and a significant amount of work to do properly. What do I mean by that?
The biggest issue is that git tends to slow down on large repos. Once you start working on a repo of sufficient size, your git status operation will start to take 5, 10, 20 seconds or more. The current way the column plugins are implemented requires all data to be fetched and loaded before rendering the files. We could implement the git status today using this system, but it would mean using this feature in a large repo could experience massive performance problems. I tried nvim-tree out at work once and it took me a while to figure out that the reason I was having terrible UI freezes was its git integration :/
The ideal is to do some sort of progressive rendering. Kick off the git status, but render normally. Then, once the git status is completed, finish filling in that column. The problem with this is that it's significantly more complex. Especially given that the nature of oil as a file browser is that these buffers are also mutable. I spent a bit of time thinking about this a few weeks ago, and couldn't come up with a design that I liked. It would be a large amount of work, significantly complicate the codebase, and introduce a lot of new surface area for bugs. All for a feature that I don't personally use or care for.
That's not to say that I'm completely against git status. If someone wants to create a PR that adds it using the current column plugin methods, I would review it. If someone wants to take a stab a progressive rendering be my guest, but I will most likely not merge (unless you can come up with a better design than mine that addresses my concerns). But this is not something that I will personally be working on in the near future.

Question:
I totally see you concerns. I had problems with slow git integrations as well in various shell prompts, so I see your concerns.
However, since this request is fairly popular (as most filebrowsers implement it), what about the following compromise:

Implementing the git status operation without any async (before rendering the files)
Make it configurable:

Don't show git status at all
Show only git status of files (should never be slow?)
Show git status of files and directories (could be slow, but can then be turned off)

That way everyone is happy and we still can think of a way to render it async in the future if we really want that.
Btw, a good way to implement only showing the git status of files is described in here: https://stackoverflow.com/a/60318286

Yep, if done via the current column system then it would function like you suggest. The columns are all opt-in, so if it's not selected it won't run.
I don't have any documentation written up for it yet, but you can look at the "size" column for an example of fetching data, rendering, and parsing.
https://github.com/stevearc/oil.nvim/blob/fb8b101d7cb4727d8719ab6ed141330eca997d3f/lua/oil/adapters/files.lua#L50-L73
You'll probably have to do something slightly differently to fetch the git status on a per-directory basis rather than a per-file basis.

As an additional point for using git, being able to use git mv instead of mv in the background when renaming files would be great as well imho.

Hi all - I had a go at this and ended up adding git status using extmarks/signs: https://github.com/refractalize/oil-git-status.nvim. The advantage being that the git status output can be added asynchronously, avoiding the performance issues mentioned above by @stevearc.
BTW @stevearc I'd be happy to make a pull request to add it to oil.nvim if you think it makes sense.

I actually like keeping this as a separate plugin for now. LMK if there are any additional autocmds or anything that would help make the integration smoother

@refractalize Just a thought: Wouldn't gitoxide offer an advantage in terms of performance for a plugin? Perhaps it would be worthwhile to see if an integration for lua <-> gitoxide could be made.

@refractalize Just a thought: Wouldn't gitoxide offer an advantage in terms of performance for a plugin? Perhaps it would be worthwhile to see if an integration for lua <-> gitoxide could be made.

I hadn't seen gitoxide before but having had a quick look I wonder if it would require additional installation instructions or compatibility issues. git itself is pretty much already installed everywhere. Perhaps something to revisit if performance becomes an issue?


Removed deprecated packages and updated some packages

Proof that wiki still works after doing our own QueryBuilder

Fixes #332


[BUG] Can't generate IntelliJ IDEA project

Describe the bug
Tried to generate the IntelliJ IDEA project using ant intellij.
To Reproduce
git clone git@github.com:rzwitserloot/lombok.git
cd lombok
ant deps
ant intellij

Actual behavior
ant intellij stops with an error message. The generated IntelliJ IDEA project does not work (at least not out-of-the-box).
BUILD FAILED
/home/christian.hujer/git/nelkinda/lombok/build.xml:395: java.lang.IllegalStateException: impossible to get artifacts when data has not been loaded. IvyNode = org.eclipse.platform#org.eclipse.core.filesystem;[1.3.0,2.0.0)
        at org.apache.ivy.core.resolve.IvyNode.getArtifacts(IvyNode.java:811)
        at com.zwitserloot.ivyplusplus.intellij.BuildIntellijProject.generateLibraryXml(Unknown Source)
        at com.zwitserloot.ivyplusplus.intellij.BuildIntellijProject.doExecute(Unknown Source)
        at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:271)
        at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
        at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
        at org.apache.tools.ant.Task.perform(Task.java:350)
        at org.apache.tools.ant.Target.execute(Target.java:449)
        at org.apache.tools.ant.Target.performTasks(Target.java:470)
        at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1388)
        at org.apache.tools.ant.Project.executeTarget(Project.java:1361)
        at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
        at org.apache.tools.ant.Project.executeTargets(Project.java:1251)
        at org.apache.tools.ant.Main.runBuild(Main.java:834)
        at org.apache.tools.ant.Main.startAnt(Main.java:223)
        at org.apache.tools.ant.launch.Launcher.run(Launcher.java:284)
        at org.apache.tools.ant.launch.Launcher.main(Launcher.java:101)

Total time: 23 seconds

Expected behavior
ant intellij completes successfully. The project is opened in IntelliJ IDEA if possible. If not possible, the project can be opened in IntelliJ IDEA manually. After indexing, src/* directories are recognized as source roots.
Version info (please complete the following information):

Lombok version: master 08faffdf836c8b8d0cca9824bfc32dc1d6a7c2e6
Platform: OpenJDK 13.0.1, IntelliJ IDEA 2019.3
OS: Linux (Kubuntu 18.04.3 LTS)

The lombok build is sufficiently complicated that, at this point, trying to support intellij as an alternate dev platform is not something we can meaningfully support at this time; none of the core devs work in intellij.
If someone wants to take ownership of the intellij task or some other workable way of hacking on lombok via intellij, we're definitely open to the idea, but I think we better spend our time on fixing bugs and adding features.
Updated build script to reflect this state of affairs. ant intellij no longer works and now tells you why.

Fixed (duplicate of issue 1956)


Enhancement: Use ini_file instead of a template for deploymentclient.conf and extend functionality

Use ini_file for deploymentclient.conf config instead of template to avoid overwriting potential existing files/other settings
Add support for phoneHomeIntervalInSecs in deploymentclient.conf
Add support for pass4symmkey under the deployment stanza of server.conf

Using ini_file leaves room for manual changes to persist on a server instead of making sure the config is managed by Ansible. If the goal is to support any configs, you could use a loop in the template over a two layer deep dictionary. i.e.
- deploymentclient_settings:
  - stanza1:
    - setting1: value1
    - setting2: value2
  - stanza2:
    - setting1: value1

Then in the template, a couple nested for loops to run through the dictionaries. I know you mention not overwriting other settings but if the goal is to manage it via Ansible, you'd want it to be declarative and avoid an engineer/admin accidentally leaving manual configs in the file.


meta examples: fixes for java & R

Aiming to fix the java meta example problems with static calls involving Math.
This does all imports in java explicit (cleaner anyways) and calls Math as org.shogun.Math
Running through travis to check whether old examples work. If green, anyone feel free to merge
@sanuj @OXPHOS

Added a fix for static calls in R

Fixed the last error, merging


Moved method implementations from header files to source files

Moved method implementations from header files to source files except for some template methods, and tested using UnitTests. Also updated the CMakeList to specify C++ 20 standard.
This PR should be able to close Issue #94.

This change is

Let's remove the merge commit, and just rebase onto master. There are a number of ways to do this, but in case you don't know how, here's one:
git checkout move-methods-to-source
git reset --hard 95ba2241233a6f1fa65477931101013003f66a00
git rebase master
git push origin move-methods-to-source --force

Make sure to make a backup branch before you do this, as your rewriting history and force pushing.
git checkout move-methods-to-source
git checkout -b move-methods-to-source-backup
git checkout -

Thanks for the direction! The branch has now been successfully rebased onto master and is ready to be reviewed.

Sadly 'develop' diverged too much to merge this.. we will have to redo as time goes on. this is a continuous effort anyways.


chore: revert to using ssm:GetParameter

Fixes #N/A
Description
Reverts to using ssm:GetParameter over ssm:GetParametersByPath to increase granularity on caching.
How was this change tested?
TODO
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

122 of 125 (97.6%)  changed or added relevant lines in 6 files are covered.
17 unchanged lines in 5 files lost coverage.
Overall coverage increased (+0.1%) to 79.405%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/providers/amifamily/al2023.go
28
29
96.55%

pkg/fake/ssmapi.go
25
27
92.59%

Files with Coverage Reduction
New Missed Lines
%

pkg/fake/ssmapi.go
1
90.24%

pkg/providers/amifamily/al2023.go
1
97.01%

pkg/fake/utils.go
2
94.56%

pkg/providers/amifamily/types.go
5
80.95%

pkg/providers/version/version.go
8
65.85%

Totals

Change from base Build<PHONE_NUMBER>9:
0.1%

Covered Lines:
5949

Relevant Lines:
7492

💛  - Coveralls


Improve CheckDashboardHasResourcesAsync in workload tests

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
CheckDashboardHasResourcesAsync has some improvements I'd like to see to make it less brittle to changes and improve the error message output.
Expected Behavior

Asserts are hardcoded to cell position and number. The test will break if the number or order of columns changes. I'd like the test to get cells using something other than position. Perhaps we can give each cell a class to look up. Or if that isn't possible, then embed content in divs with classes. I think it's ok to make some modest changes to the generated HTML to make testing better.
If a row's content doesn't match the expected content, then the test doesn't match the row and skips adding it to found rows. But that means the error message just says that the resource wasn't found. It doesn't say exactly what didn't match for the row (e.g. the wrong number of endpoints). Knowing why it didn't match would be useful.

Steps To Reproduce
No response
Exceptions (if any)
No response
.NET Version info
No response
Anything else?
No response

cc @radical

@adamint would you be interested in taking this up, since you recently worked on dashboard playwright tests?

@radical sure!

Also, queries such as //fluent-data-grid-row[@class='resource-row'] require the exact classes to match the query. It would be better if the query returned elements named fluent-data-grid-row with the class resource-row and any other classes.
Is there a better way to write this kind of query that isn't so brittle to HTML changes?
See https://github.com/dotnet/aspire/pull/4892#discussion_r1680435584

Also, queries such as //fluent-data-grid-row[@class='resource-row'] require the exact classes to match the query. It would be better if the query returned elements named fluent-data-grid-row with the class resource-row and any other classes.
Is there a better way to write this kind of query that isn't so brittle to HTML changes?
See #4892 (comment)

Yes, it is recommended not to use css classes or html elements where possible


jsx-max-props-per-line: different value for oneline tags and multiline tags

Hi, I write JSX like this.
// ok
<Component prop1="val" prop2="val" />
<Component
    prop1="val"
    prop2="val"
/>

// not ok
<Component
    prop1="val" prop2="val"
/>

Currently it is not possible to set jsx-max-props-per-line differently for multiline tags.

I would also be interested in this

this seems totally reasonable - i also require either all props + component on one line, or, never more than one thing on the same line.

+1 I'd like to see this, too

I've probably missed something, but I'm still not sure how to enforce this. jsx-first-prop-new-line makes sure that the first prop is on a new line, but doesn't enforce anything about later props. jsx-max-props-per-line still applies equally to single-line and multi-line tags.

+1 IMO this is a very reasonable rule to have, any multiline props with more than 1 is not scannable


Import "thop" could not be resolved

In classification_modelnet40/main.py  line 166
from thop import profile, clever_format
compile failed: Import "thop" could not be resolved.
Is there anything wrong with the code in this line?

pip install thop


checkbox-bindings

I basically copied all the existing bindings from here and only had to address the tintColors prop which was not present yet.
Is the binding for this prop correct? Here's how we use it:
<ReactNativeCheckbox
  tintColors={ReactNativeCheckbox.tintColor(
    ~true_=ReactNative.Color.aliceblue,
    (),
  )}
/>

Also what about the component name? Are we gonna prefix all the packages with ReactNative? Or is it only tempory until we remove the "legacy" ones?

poke @cknitt

I'd prefer<EMAIL_ADDRESS>and I'd also prefer the type and creation function to be named tintColors, not tintColor.

@tatchi @MoOx @cknitt
Sorry guys, I didn't notice this PR and pushed mine. Should I undo that?

Hello,
I pushed my changes to use bs.obj. Let me know if you prefer to merge @sgny's PR (which seems more complete) and I'll close mine :)