Make the commands tests robust against any working directory changes

This is a test-only change that makes the commands tests robust against any working directory changes done by the tool being tested in the same process (as for example --package-path does).
Motivation:
Tests are flaky on the local desktop depending on what order they run in.  Not sure why this doesn't happen more in the CI.  The symptom here is that the test fails when run as part of the test suite but succeeds when run individually.
In the particular case that kept hitting me, SwiftTools was run on a test fixture in a temporary directory, changed current working directory to that directory, and then after the temporary directory was removed again, new calls to SwiftTools failed with "cannot get current working directory".  Which makes sense, since it had been removed.
Modifications:

use a common specialization of XCTestCase for the command tests that saves and restores the current working directory

I don't love this change but changing SwiftTool to not use chdir anymore seems riskier.  And if there are other things that should be saved and restored in setup and teardown this provides a place to do it.  A lot of the custom test classes also have some variant of execute() that could be hoisted up to the shared parent test case class, so the case for this class might remain even if we have a better way of dealing with the current working directory later.

@swift-ci please smoke test

changing SwiftTool to not use chdir anymore seems riskier

In theory, we could have SwiftTool itself remember the initial directory and change it back? But that's pretty much the same as this, so either seems fine to me.


[core] PLATFORM_DRM rotate screen/window

Hello, I have set my raspberry to start so that the screen is rotated 90 degrees. boot and console are now found. Otherwise, I have a display that is made for mounting in a vertical position.
The console is displayed fine for me (horizontally), but the raylib window still appears the same, so it is now turned 90 degrees sideways... I read somewhere that the DRM setting has no effect on fbdev.? And now I'm not sure if it will be the team, @raysan5 , are you using fbdev here? I read somewhere that when writing directly to fbdev, the settings sent to cmdline.txt are not reflected...
Environment
RPI 2B, Rapberry OS LITE
Code Example
I added this to my  /boot/firmware/cmdline.txt:
video=HDMI-A-1:400x1280M@60,rotate=90

console good - gui rotated
console good - gui rotated
console good - gui rotated

@gabriel-marques
I'm sorry to bother you, but you already advised me once, so I want to ask if you know how to turn the LIBRAY output by 90°?

I tried to add video=HDMI-A-1:400x1280M@60,rotate=90 to /boot/firmvare/cmdline.txt but only the console rotates, the RayLib window has the order of the original rotations.
I tried echo 1 | sudo tee /sys/class/graphics/fbcon/rotate and echo 1 | sudo tee /sys/class/graphics/fbcon/rotate_all but still nothing. It only affects the console.

I was only able to rotate RayLib outputs 180˚ and flip the X or Y axis.
I tried adding different options to /boot/firmvare/cmdline.txt and came up with this:

panel_orientation - It can only rotate the screen 180˚.
rotate - It only affects the text mode
reflect_y a reflect_y - it can only flip in its axis.
fbcon=rotate - It only affects the text mode

I found this, Screen rotation with drm/egl rendering on Rpi4 and I think that this will be the end of my journey. Even though I learned elsewhere that someone had succeeded, but there wasn't enough information about it...
But to excuse the fact that I'm spamming here, I wonder if RayLib offers a way to rotate the rendered window by 90° so that I don't have to rotate the entire contents of the window manually?
If anyone is interested, the sources where I looked are:

Screen rotation with drm/egl rendering on Rpi4
modedb default video mode support
Raspberry Pi Documentation - HDMI Documentation
How to add hardware rotation, scaling etc to a DRM/KMS driver
Rotate display on startup
[TUTO] touchscreen rotations
Raspberry 7" Touchscreen Rotation Ignored By Kodi 20.2
Kernel Mode Setting (KMS)
Bookworm lite with official 7" display display regression
Accelerated video on rotated screen using cvlc on Buster

So why make displays of such a size...

I don't know if it is possible to definitively solve it somehow. But I'd like to note it here for future reference. Although these discussions are not related directly to RayLib, they are related to Raspberry PI and DRM/KMS.
Starting from https://forums.raspberrypi.com/viewtopic.php?t=361116&start=50#p2191569  and continuing through https://forums.raspberrypi.com/viewtopic.php?t=361116&start=75#p2191843, the KMS capabilities of the LINUX kernel 6.6 are explored.
And here he's trying to convince me definitively that I'll have to do it programmatically? https://forums.raspberrypi.com/viewtopic.php?p=2191429#p2191429

@colesnicov Thank you very for all the investigation work put into this issue. I'm afraid I'm not an expert on PLATFORM_DRM but I'm sure all the info posted will be really useful for other users facing this same issue! Thanks!

Good. Tanks.
Okay, but I don't want to close it yet. I'm wondering if I can rotate the entire contents of the window by 90° in some simple way. I mean both a 3D scene, which is not difficult to multiply matrices, and a 2D scene. In the PLATFORM_DRM mode, the title of the window is not displayed, so the rotation only concerns the contents of the window.

I have a display (it's my fault, I didn't know at the time what problems it would cause) with a resolution of 400x1280 (it's not 1280x400) which is mounted vertically. I turned it to a wide angle, and I want to keep it like that.
Here are screenshots of what I have on my laptop. this is the way I want it (horizontal):

And this is when I change the dimensions from 1280x400 to 400x1280.

I wanted to have a horizontal layout, but now it looks like it won't be possible.

@colesnicov I'm afraid the best option is redesign the application to render to 400x1280 framebuffer...
Still. you have another option. You can draw everything to a 1280x400 RenderTexture and draw the RenderTexture.texture rotated 90º to screen.
RenderTexture target = LoadRenderTexture(1280, 400);
...
BeginDrawing();
    BeginTextureMode(target);
         // Draw everything to RT at 1280x400
    EndTextureMode();

    // Draw RT.texture rotated 90º to screen (and flipped Y)
    DrawTexturePro(target.texture, (Rectangle){ 0, 0, target.texture.width, -target.texture.height }, (Rectangle){ 0, 0, target.texture.width, target.texture.height }, (Vector2){ 0, 0 }, 90.0f, WHITE);

EndDrawing();

But in this case is up to you to map inputs correctly...

That's exactly what I meant.
I once played a video on Billboard in a 3D scene https://youtu.be/NHFiAHJNFJE?si=qh8Lp_-PCkqW_6OS&t=68 . I thought about the inputs that they would have to be remapped, but probably on the dtoverlay layer.
In the future, I will buy another display, I have already checked which one will have a native resolution for landscape.
But I will change this layout to a new layout. And then I'll try to render it into a texture.

Hi,
Thought i would just share what we did to solve this, if anyone else is stuck with the same problem.
We also require rotating without X, and it's challenging. I spent countless hours trying but ended up rotating everything 90º in code instead.
We extracted raylib code into our own functions that in turn rotate the content 90º and handles X/Y conversions, so if it ever comes out an update to DRM, it's simple to revert to standard setting again. You could even take this a step further and define rotation, and then support both ways.

Was asking about this on the Reddit page as I couldn't figure out what would be the proper approach. I'm working on a display that is permanently mounted horizontally (a commercial product), but reports itself as portrait, so everything is drawn sideways.
I would suggest implementing a global rotation in Raylib itself as the view should be separate from the physical display anyways.
It could be one function that takes in 4 orientation enums and rotates the visual content as well as input OR as an option of having input coordinates rotate with the view content freely, aka follow one global transform. That would be available to all platforms and wouldn't require diving into the haystack of DRM drivers (did it, 1/7, would not recommend).

@Loadus I believe is better to do it in the DRM driver side, to just get the correct resolution. Redesigning all raylib functionality to accomodate to a random display orientation seems overengineering and not feasible. If required to reach this point, it's up to the user to manage it. I'm convinced that DRM device driver could report and set the desired orientation.

@Loadus I believe is better to do it in the DRM driver side

The view rotation on the DRM is one function call away, if one knows what to call. But the documentation of the DRM/KMS driver is assuming the reader knows exactly how it works. :D
And yeah, if one wants a complete global transform implementation, that would mean a lot of modifications in the input capture etc., but a 4 orientation option would be just handling the X and Y (and offset).
My personal problem - where I am 100% stuck right now - is that I have no idea where to start looking on how to rotate the mouse / touch X and Y coordinates as I can easily rotate the view but the input is still applying the original coordinates. It's the only thing preventing me from actually starting to program the actual app. :D
I would somehow need to capture the input coordinates before they arrive to the visual items on screen, I guess? And I'm doing this from the Go version of the library as I can't be allowed to poke C code without adult supervision.

While continuing poking around, I noticed that an actual, physical mouse has it's coordinates rotated along the view correctly and works nicely - it's the screen touch that has it's coordinates in the original portrait mode when rotating the view manually, which is problematic in my case.

I also had a problem with the screen orientation being reversed. You haven't done anything to the hardware if it can't do it natively. It has to be solved on the framebuffer side, manually turn the entire frame to the required angle...

manually turn the entire frame to the required angle

Yes, that's what I resorted to as I couldn't figure out where to inject commands to the DRM sufrace. I used BeginMode2D and then rotated the camera, which worked perfectly. Apparently, it was only the touch that didn't follow the rotation and I think it's a bug as mouse coordinates are correct.

I needed it for Raspberry and HDMI touch TFT panel. unfortunately, I bought the wrong display, oriented at height. I didn't want to rotate each frame before rendering it, so I simply changed the layout of the application and noted in the future that I have to be careful about the native orientation of the screen/driver. In the final, I completely abandoned the use of frameworks such as RAYLIB, SFML and SDL and wrote my own DRM wrapper for RPI that also works on my desktop PC (laptop). In addition, it can dynamically distinguish whether it is launched from a TTY terminal and opens a window in DRM mode or whether it is launched from a desktop and opens a window with the help of GLFW. Which makes development a lot easier for me. I can compile the program on the desktop and test it. I immediately switch to the TTY console and without a new build or any switches I run the application in DRM mode. Basically, it just checks the presence of the DISPLAY variable in the system and if it is found, it opens the GLFW window  :) .. I wrote, using libinput, a custom loop that captures mouse and keyboard events (With the possibility to set the keyboard layout, it was important because I use a non-English ASCII keyboard..) and provides them to my application. I ran under that IMGUI and already ported my project under it. I'm not bragging, I'm presenting an alternative way to solve the problem, it took me about 3 months to find the info and write it down. Unfortunately, I won't share the code then, it's very ugly and poorly tested, without documentation and without an example... But there are more projects like that, if you're interested, I'll throw you some links. RAYLIB and SFML are good, but I got 4FPS on RPI!! my DRM implementation then drags it to about 50 FPS friend. That's the main reason why I'm switching to native..

As a pearl, I looked for the official DRM website and found this https://github.com/robclark/libgbm. Here a project (I didn't look at the code at the time) that could be a good starting point. It should be useful to someone..

manually turn the entire frame to the required angle

Yes, that's what I resorted to as I couldn't figure out where to inject commands to the DRM sufrace. I used BeginMode2D and then rotated the camera, which worked perfectly. Apparently, it was only the touch that didn't follow the rotation and I think it's a bug as mouse coordinates are correct.

Maybe you could try installing some wayland server.. then the rotation is in charge of composer and it can do it better.. https://github.com/raysan5/raylib/issues/4648 Vivarium does not support rotation, but there are others that do.

@bonsaipanda

manually turn the entire frame to the required angle

Yes, that's what I resorted to as I couldn't figure out where to inject commands to the DRM sufrace. I used BeginMode2D and then rotated the camera, which worked perfectly. Apparently, it was only the touch that didn't follow the rotation and I think it's a bug as mouse coordinates are correct.

Maybe you could try installing some wayland server.. then the rotation is in charge of composer and it can do it better.. #4648 Vivarium does not support rotation, but there are others that do.

I have to keep it as minimal as possible. I'm currently looking into Clay (https://github.com/nicbarker/clay) to see if I can bolt that in and use it as the skeleton for the UI and have Raylib as the renderer. Looks very promising.

It looks interesting. I use ImGui but it's not satisfactory. ImGui  and CLay, lacks transitions and animations. I'm thinking about switching to something else.


what is the license here for netty-jssc?

Hi @jkschneider, what is the license for that project? Could you please add one? (Or maybe permit me to use it under some license).
By default github terms does not allow me to do anything except fork, basically.
Thank you.

Added an Apache license. Hopefully that is permissive enough, as I have no qualms with its use for any purpose.
I haven't had a need for this connector for some years, so you'll probably want to upgrade the underlying netty libraries.

Thanks a lot


"Compile On Save" is disabled VS2015 TypeScript Build options when tsconfig.json is present

I'm trying to achieve both "allowJs" and "Compile On Save" at the same time.  "allowJs" exists in tsconfig.json, but not the IDE's TypeScript Build options.  "Compile On Save" exists in the IDE (which makes sense, since it is really an editor concern), but is disabled if tsconfig.json is present.  What I think would be ideal is to allow "Compile On Save" to be lit up and active in the IDE regardless of whether tsconfig is present or not, even if the other options (which are passed through to to the compiler) are not available.

I rewrote the description of this to avoid duplicating issue https://github.com/Microsoft/TypeScript/issues/6879.

please see my comment in https://github.com/Microsoft/TypeScript/issues/6767#issuecomment-179483696
this should be handled by  #2326


Dashboard update

Add a new scatter plot that displays the frequency and duration and drugs used for selected cancer types, as requested in https://github.com/CanDIG/ga4gh-server/issues/52. The underlying logic of calculation was also changed, since the original way was very unreliable.

Add a "zoom" option for the timeline graph.

Codecov Report

Merging #54 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #54   +/-   ##
========================================
  Coverage    80.67%   80.67%
========================================
  Files           37       37
  Lines        14554    14554
  Branches      1439     1439
========================================
  Hits         11742    11742
  Misses        2335     2335
  Partials       477      477

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d26f4...df40987. Read the comment docs.


Resolve geniushub duplicate unique_id and add unique_id for issues

Breaking Change:
This PR changes the unique_id of climate and water_heater entities.
Description:
Due to a typo, geniushub zones (climate, water_heater) may share a unique_id with devices (other entities) within the integration.
This PR fixes that (see breaking change above), and also adds a unique_id for geniushub issues (errors, warning, information) so that all geniushub entities now have a unique_id.
Note that entity_ids are not changed.
Related issue (if applicable): N/A
Pull request with documentation for home-assistant.io (if applicable): N/A
**Example entry for configuration.yaml (if applicable): N/A
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[x] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

Please add to the breaking change paragraph what the user needs to do to cope with the breaking change. Eg clear out stale entities in the entity registry.


[Feat, Refactor] Decoding: logits handling, new decoding strategies, standardize masks

Description
Several refactorings and features made for decoding in RL4CO.
Note that this PR follows #152 but restructured - now working and tested!

[Refactoring] Now models return logits by default (e.g. here). We do so since logits represent the raw outputs from the model, and we would like to decouple the modeling part to how we sample distributions. The function handling the transfer from logits to log probabilities (hence the "log_p") is process_logits
[Feat] New decoding strategies!

We introduce nucleus sampling (i.e. top-p sampling) which discards from the distribution values under a certain threshold in the CDF before sampling. This can be used by simply passing a top_p  > 0 to the DecodingStrategy, i.e. to the model deooder. This is ubiquitous in LLMs and it is about time to have it!
Similarly we introduce top-k sampling which considers simply the top-k highest logits in the distribution to sample from

[Refactoring, breaking change] now by default any mask has the same behavior (example here), i.e., the value 1 means keep (i.e. feasible action) while 0 means to remove, i.e. infeasible. This is both similar to TorchRL's action mask and importantly to PyTorch's scaled_dot_product_attention: "A boolean mask where a value of True indicates that the element should take part in attention. " (ref). For this reason, masks that used to have inconsistent namings now have the same behavior
[Minor] Rename LogitAttention to PointerAttention (for consistency with the Pointer mechanism in Vinyals et al., 2015)
Transfer all decoding utilities (such as decoding strategies, log likelihood calculation and so on) under rl4co/utils here

Types of changes

[x] New feature (non-breaking change which adds core functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My change requires a change to the documentation.
[x] I have updated the tests accordingly (required for a bug fix or a new feature).

CC: @LTluttmann could you have a look if you spot some inefficiencies or if you have some ideas?
CC: @Furffico @cbhua (note: made several modifications compared to previous PR)

Awesome refractory! 🚀 I will try to create an UML graph for the overview pipeline. Could be helpful for users to understand.

Merging now!


ERROR: Permission to steemit/steem-js.git denied

Expected behavior
I've open Issue #495 and create a branch 495-webpack-example-update to solve it. I expect origin accept push 495-webpack-example-update local branch

Actual behavior
I'm able to clone & push normally from other public repositories. My push are being declined when:
git push --set-upstream origin 495-webpack-example-update
ERROR: Permission to steemit/steem-js.git denied to caiocesarbosco.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Sorry, if it is a trivial question. I know it is a common git error, however i'm getting this error only here at steem-js. So decided ask if should be something particular to steem-js pipeline, due commit messages or branch name formats maybe?.
Thanks by advance.

How to reproduce

Environment information

Not related to steem-js


If double-tap is combined with tap and chain, the double-tap line will disappear.

This is intended behavior.
Chains with no bonus do not have Sync Connectors to anything. Only R-Note chains have sync connectors.
I didn't create that inconsistency, marvellous did. I'm just being accurate to the game in the editor :V


SteamVR 2.1.5b2 is not compatible with PhysX upgrade in 2018.3.0f2

Two items used by the Interactions Example are not compatible with the upgrade to PhysX in Unity 2018.3 and result in the following Debug.LogError():

RigidBody::setRigidBodyFlag: kinematic bodies with CCD enabled are not supported! CCD will be ignored.

I was able to fix this for the TargetHitEffect prefab by going to the Arrowhead collider's Rigidbody and changing the Collision Detection setting to Continuous Speculative (the suggested mode for fast moving Kinetic rigidbodies per Unity's docs).
This also has to be done for the Arrow prefab for both the top level Arrow gameobject and the "ArrowHead collider" grand-child gameobject.

Thanks, I've believe I've fixed this in the next beta.

2.2b1 beta has been released and I believe it fixes this issue.

2.2b1 beta has been released and I believe it fixes this issue.

Not for me. I'm using now v2.2b3 and still got this error.

I do not understand why as a commercial software, unity3d has so many bugs and not compatible with lower version.


[feat] Allow to completely sandbox WebViews from network access

Describe the problem
I want to create Tauri windows (WebViews) that run user supplied code ("apps"). I enabled a custom protocol handler (via register_uri_scheme_protocol). However, currently the WebViews can still access the other by-default enabled protocols (e..g. http, https, and tauri) and, for example, change the window location or issue fetch requests.
Describe the solution you'd like
I'd like these WebViews to be completely sandboxed and disallow all communication but the custom protocol handler that I registered. Ideally, I want to allow-list protocols for the WebView and disallow everything that is not in the allowlist, for all means of communication (window.location, fetch, XmlHttpRequest, <script scr="..."> etc).
Ideally, I want a WebView that defaults to no protocols, then specifically allow protocols, and additionally have a simple hook (in rust) that is run for all network/protocol requests that can abort or disallow the request.
Alternatives considered
There are a few ways to reduce communication surface for a WebView currently:

Setting a strict CSP policy. This already, I think, allows to disallow most communication for a WebView.
The isolation feature provides a way to intercept and disallow IPC communication for WebViews
The WebViewBuilder in wry has a with_navigation_handler that, I think, would allow to disallow navigating away from the allowed protocol, however I don't think this is currently exposed in tauri?

It might be possible to completely sandbox a WebView this way. If that is a case, a documentation guide for a completely sandboxed and secured WebView would be useful. However, it feels a bit hacky to get a sandboxed webview by tying together multiple hooks to disallow things. I'd prefer to enable a "sandbox" mode or something once that would disallow all network communication by default, and then selectively enable things. This would, I think, be the better security primitive to run user-supplied code without having to fear information extraction attacks.
Additional context
No response

I like this idea, further restricting the available channels seems very reasonable. However, I don't think we can disable the default protocols. At least on macOS WKWebView ships a set of default protocols that you simply cannot override. It will actually trigger an objc exception if you try to override it, causing a rust panic.
I'm not aware of alternative constructors for the webview that create a "no defaults" Webview. But if there are this feature request would be very good to have!

What i had in mind when we talked about it on Discord was webkitgtk's PolicyDecision stuff


public key injections breaks the host ssh access

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What happened:
password is required for ssh access to the host, although pub keys are there
What you expected to happen:
access the host the vm is running on without issue
How to reproduce it (as minimally and precisely as possible):
launch a vm and inject a ssh key
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

@karmab do I understand that correctly?


Debugging

Here are the changes I made:
I added an exception handler for FileNotFoundError in the for item in fl loop. This will prevent the program from crashing if a file cannot be found.
I added an exception handler for OSError in the for item in fl loop. This will prevent the program from crashing if there is a permission error.
I added a check to the for item in fh loop to see if the file exists before reinstalling it. This will prevent the program from reinstalling files that are already installed.

Hey, thank you so much for your Pull Request :D I will review your changes and see what I can add. Im going to try to add most of your changes but it might take some time because of what I committed after your PR. Thanks for your time ;D

All of your changes have been submitted, if anything needs to be changed please let me know


support for v1.2.*

videojs 5 has some troubles with ads. So it's important to have a branch working with version 4.
I found a bug (Cannot read property 'setVolume' of undefined) you can see it on (http://fem-inc.com/uitest/viacom.html) and I'd like to make a pull request.

Has this issue been addressed? Did you go back to videojs 4?

Hey! Sorry for the late response. I've created a VJS4 branch you can do a pull request or report a bug.


Update the {touch, date} code to use parse_datetime 0.5.0

a lot of changes have been made to parse_datetime.
https://github.com/uutils/parse_datetime
The code of touch & date needs to be updated

To start, just update Cargo.toml to update the version
and to test:
$ cargo test --features=unix  test_touch
$ cargo test --features=unix  test_date

I tackled this and made the following patch which does pass the tests but I'm not quite satisfied.
https://gist.github.com/u8sand/f957ccf502007d068948193660736270
The main problem is that parse_datetime does not distinguish between relative/absolute datetimes, but touch has different behavior for relative/absolute (at least the tests suggest this). I think parse_datetime should be updated to allow you to make this distinction.
Maybe i'll get to it or someone else can pick it up from here, I figured I may as well share what was already done.

@philolo1 any suggestion ? :)

Nice @u8sand! The idea of the parse_datetime API is that the difference between absolute and relative is built-in. So you give it a reference time to parse from, and if the format is relative it will do the calculations from that date. If it is absolute that reference date will be ignored. So, in theory, it should be as easy as this:

get the atime and mtime,
parse the date format twice, once with atime and once mtime as reference,
use the time that parse_datetime returns.
If that doesn't work, please let us know, because that would be a bug in parse_datetime!

@tertsdiepraam you're right, perhaps it's just premature optimization that I hoped to run parse_datetime just once. PR pending


why input shape is (None, 512, 512, 1)?

I load the mod and print mod.InputLayers[0].input_shape and get the  (None, 512, 512, 1).
But the code in main.py indicates that the input shape should be [None, 512, 512, 3] or [3, 512, 512, None] depending on the data format.
When I feed [3, 512, 512, batch_size] or [batch_size, 512, 512, 3] to mod.predict, Exception is raised.
Can you help me ? What's going on here?

has been checked in group.


Build logs don't scroll until late steps

I was trying to understand the binder build for eclib and I noticed that the build log doesn't scroll for me until step 39/48 (in my build process). The ending binder builds just fine, but it takes a few minutes for the build to get to a step where it allows me to scroll the log. If after step 39 I click on hide/unhide, the log is scrollable.
I have this on both ChromeOS+(its chrome) and Ubuntu 18.04+chromium.
This may be related to #433 (and perhaps #233).

Thank you for binder (and jupyterhub). These are great!

Ah, I understand and this is not a bug. What actually happens is that the log doesn't scroll until it detects new input into the buffer, and through an interesting coincidence I repeatedly opened the buffer at the same (long running) input.
I am closing this issue.


Better highlight docs

After messing around for a while i still have no idea how to use the highlight groups for customizing leap nor do I know what group exactly highlights what. Maybe there can be some better clarification on how to customize the highlights

how to use the highlight groups for customizing leap

This is general (Neo)Vim knowledge, and does not belong to a plugin's documentation. That said: https://github.com/ggandor/lightspeed.nvim/issues/33 (Note that from 0.7 on, you can use vim.api.nvim_set_hl(0, ...) instead, see the built-in help.)

nor do I know what group exactly highlights what

On the screenshot:
https://raw.githubusercontent.com/ggandor/leap.nvim/media/quick_example_3.png

underlined: LeapMatch (note: as opposed to the screenshot, in the most recent version these are only shown if they cover a label)
green labels: LeapLabelPrimary
blue labels: LeapLabelSecondary
everything else: LeapBackdrop (nothing by default, but you can customize)

thanks


¿What is the function of Meteor.setLoggingEnabled(true);?

I need to know what is the real work for this line
Meteor.setLoggingEnabled(true);
Thanks

It shows you all the operations(in the Log of Android Studio) that appears in interaction of server and your application.

Exactly. If you have some problem with your client-server communication that you don't understand, you may use this setting to debug things. But otherwise, you won't need it. Anyway, only use it during development.

Ok guys, thank you :)


Provide a way to do a manual build for an environment given its conda.yaml

 Issue by fabioz
Tuesday Mar 14, 2023 at 10:46 GMT
Originally opened as https://github.com/robocorp/robotframework-lsp/issues/902

One action that I sometimes miss (but do not know where exactly to put it) would be a "build / rebuild the robot environment".
The environment builds automatic triggering is quite good but there are cases where I'd like the control.
Editing conda.yaml
..oops made a typo > cancel
back to editing conda.yaml
-> here before jumping back to .robot code I'd like to trigger the env. build manually and stay in that "mental context"

 Comment by fabioz
Tuesday Mar 14, 2023 at 10:49 GMT

Could be done as:

Action to be manually called (something as Robocorp: Build RCC enviroment).
Code lens at the top of the conda.yaml to build it (which calls that action).


[WIP] check proofs from resolve where appropriate (blocked by lbrycrd release)

depends on latest (unreleased) lbrycrd for all tests to be green

victor is gonna ask brannon if lbrycrd bug is fixed

brannon said he looked into it and couldn't find a problem on their end.

@shyba what's the status on this? can you sync with @BrannonKing

discussed with @shyba, we're going to close this for now until we have a better plan of using (or not using) lbrycrd as a python library in wallet server


Allow intro tutorial to be optional feature

Intro can now be disabled, if desired.
Defaults to enabled, so it is backwards compatible

Nice! Thank you again


Add support for switching between light and dark theme

I often want to test whether my components look good in both light and dark mode. This adds a switcher in the app bar, toggling between auto, light and dark mode. This might resolve #14. I had to make some changes to the background colors of the drawer and the default color of a story, to make them look good in light and dark mode.

Hi, thanks for your PR!
I've pushed some changes: extracted ThemeSwitcher widget and slightly updated the implementation and formatting. Can you please take a look?
Otherwise, your changes LGTM.

Looks good 👍

Just integrated this, thanks!

Thank you for the PR 😄


ci: Pass CODECOV_TOKEN in docker-compose.test.yml

Alternatively, we can modify .github/workflows/tests.yml to include PRs along with the main branch.

Alternatively, we can modify .github/workflows/tests.yml to include PRs along with the main branch.

The GHA is already configured to run on tests with pull_request trigger and this change makes sure CODECOV_TOKEN gets passed to the docker instance that runs tests and uploads coverage to codecov.

Update: After merging this PR, I rebased the main branch into the test/serializers branch here, https://github.com/ietf-tools/bibxml-service/pull/439.
However, I can see that that hasn't fixed the issue. https://github.com/ietf-tools/bibxml-service/actions/runs/9950576461/job/27488655210?pr=439#step:7:302


[DataFactory]Added new features into 6.4.0

Added GoogleSheets connector in ADF  https://github.com/Azure/azure-rest-api-specs/pull/20337

Added Synapse Spark activities in ADF  https://github.com/Azure/azure-rest-api-specs/pull/19769

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

/check-enforcer override


Repetitive assigned peaks to empCpd

also seen in asari output.
Will add peak shape check in asari or here.

Irrelevant after khipu


Fix table spacing

Ezhil's styling for tables at the moment leaves no padding around the content, resulting in rather unreadable tables. Perhaps we could add some padding and/or a light border around the cells?
For example, this:
| filesize |    time | memory  |
| --------:| -------:| ------ :|
|   100 MB |  0.64 s | 2060 KB |
|   100 MB |  0.62 s | 1816 KB |
|   500 MB |  3.13 s | 2084 KB |
|   500 MB |  1.98 s | 1852 KB |

Looks like this:

Even the demo page has poor  spacing between blocks in the header.

Thanks for reporting, added a default style for table. Here is the demo - https://ezhil-hugo.netlify.com/posts/post-5/#Tables


Fix blocking update dialog popup

https://github.com/electron/electron/pull/9404/commits/50057163c6d4a14034b945897fece05affa47835
Aka, pass a callback param

My branch


Read comment

Hi, very good job for your lib.
Is it possible to read the comments? I explain:
I want to write a generator of documentation for a collection of YAML files. All the file has some comments like this:
# list all the variables
# multiline comment
# bla blabla...
variables:
   # name of the docker images
   IMAGE_NAME: my-image
   # tag applied on the images
   IMAGE_TAG: latest

I want access to the comment for example with the node IMAGE_NAME, I would like to have something like: node.comment() . Is it possible with your lib, and how?

https://github.com/KmolYuan/yaml-peg-rs/blob/main/src/parser/base/grammar.rs#L410
There is a matcher function for comment.
But there is no rule to specify the comment on how to store in the nodes. (same behavior as rustfmt?)

Thanks for your quick answer.
I must confess that I don't really see how to use it. I am a beginner in rust.


Zane Barrier Action Skill not respecting window size.

When hovering over the skill, and using Firefox version 69.0.1 (64-bit)

I have this problem with many of the topmost skills too. But since the size of the window drives the size of the text and textboxes, you can get around this in a way by reshaping the window to be tall and skinny. This will scale the contents down and reveal the clipped text. This isn't a convenient solution, however.
@seigler Can vertical margins or a buffer space be added to ensure that there is enough "padding" at the top to prevent the text from leaving the screen when the window is at a normal browser size, e.g. roughly 1920x1080=1.777 ratio? Or change some of the flex properties?

I can change a style so the top skills have the box below the icon instead of above it.
On Mon, Jan 13, 2020, at 11:27 AM, chronofreak wrote:

I have this problem with many of the topmost skills too. But since the size of the window drives the size of the text and textboxes, you can get around this in a way by reshaping the window to be tall and skinny. This will scale the contents down and reveal the clipped text. This isn't a convenient solution, however.

@seigler https://github.com/seigler Can vertical margins or a buffer space be added to ensure that there is enough "padding" at the top to prevent the text from leaving the screen when the window is at a normal browser size, e.g. roughly 1920x1080=1.777 ratio? Or change some of the flex properties?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/seigler/bl3skills.com/issues/20?email_source=notifications&email_token=AATWU535N3ASVX4AKOX6UJ3Q5SI5RA5CNFSM4IYW4AJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZLNLI#issuecomment-573748909, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATWU54RHNMSSYQGF2KI45LQ5SI5RANCNFSM4IYW4AJQ.

The action skill description now pops up below the icon. Thanks for identifying this issue!


need to improve the paths section in config.js

The path section is this code
This continues to be a problem for many users (it is certainly for me) as it does not seem well defined (documented) nor is it stored in a safe manner (there are several scenarios where config.sys gets removed and this information is then gone.
In this specific article, I am dealing with the experiment I have not done before (bad adriatic as I should have): the folder skeleton-esnext-kendo-core is the aurelia kendoui application skeleton (not a slightly modified skeleton-esnext ), created to be used by monterey as described here.
The experiment is to make use of  kendo sdk as fetched from bower (see image below)

(previously, I always used the vendors folder approach being too lazy to do this the right thing). Trying to run this app (it is not complete yet, I only tried to verify that the code in the bridge can "see" kendo widgets), I get this
system.src.js:5123 GET<EMAIL_ADDRESS>404 (Not Found)Z @ system.src.js:5123(anonymous function) @ system.src.js:5123(anonymous function) @ system.src.js:5123(anonymous function) @ system.src.js:5123(anonymous function) @ system.src.js:5123(anonymous function) @ system.src.js:5123(anonymous function) @ system.src.js:5123(anonymous function) @ system.src.js:5123(anonymous function) @ system.src.js:5123(anonymous function) @ system.src.js:5123
system.js:4 Uncaught (in promise) Error: (SystemJS) Error: XHR error (404 Not Found) loading<EMAIL_ADDRESS>	Error loading<EMAIL_ADDRESS>as "kendo.data.min" from<EMAIL_ADDRESS>@ system.src.js:5123p @ system.src.js:5123(anonymous function) @ system.src.js:5123

The KendoUI bridge loaded by this app is<EMAIL_ADDRESS>(not visible in this repository as it gets added in the build process) and the specific missing references comes from the bridge's index.js file (see below)
define(['exports', './common/decorators', './config-builder', 'aurelia-templating-resources', 'jquery', 'kendo.data.min'], function (exports, _decorators, _configBuilder, _aureliaTemplatingResources) {
  'use strict';

  Object.defineProperty(exports, "__esModule", {
    value: true
  });
  exports.configure = configure;
  Object.keys(_decorators).forEach(function (key) {
    if (key === "default") return;
    Object.defineProperty(exports, key, {
      enumerable: true,
      get: function () {
        return _decorators[key];
      }
    });
  });

(code taken from the npm section of jspm-packages folder.
QUESTION: what am I missing here?

Answer:
paths: {
    "*": "dist/*",
    "github:*": "jspm_packages/github/*",
    "npm:*": "jspm_packages/npm/*",
    "kendo-ui/*"<EMAIL_ADDRESS>    "kendo.*"<EMAIL_ADDRESS>  },


Without #, how can I open flutter route via full address?

Let say I have named route /login. Now I'm using this url_strategy plugin so the URL would be:
https://f7dc-36-84-85-125.ngrok.io/login.
Then if I refresh the page, or if I open on the new tab. I suspect it'll be translated to:
https://f7dc-36-84-85-125.ngrok.io/login/index.html
which is of course non-existent on the server.
So it'll be dead 404 error, am I right?
So how can I open /login route via full address which is https://f7dc-36-84-85-125.ngrok.io/login?

That is not how it works. You need to simply route all paths to index.html. I have some more details in my StackOverflow answer, but in general, you should just try to find out how to rewrite all paths to index.html with your hosting solution (e.g. Firebase hosting).

I see now, my bad. So rerouting all addresses to index.html is doable on the server side. Sadly I'm a frontend human. Thank you for the direction. I'm closing it now.

just in case anybody need it, I have solved this on apache server with .htaccess file
RewriteEngine On
RewriteBase /
RewriteCond $1 !^(index\.html|assets|robots\.txt|favicon\.png)
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^.*$ index.html [L]


Automated cherry pick of #4676: fix: guest network default share scope should be system if non-default-domain-projects is off

Cherry pick of #4676 on release/2.12.
#4676: fix: guest network default share scope should be system if non-default-domain-projects is off

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@91af65c). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.12   #4679   +/-   ##
==============================================
  Coverage                ?   6.86%
==============================================
  Files                   ?     502
  Lines                   ?   85555
  Branches                ?       0
==============================================
  Hits                    ?    5877
  Misses                  ?   79184
  Partials                ?     494

Flag
Coverage Δ

#aFlag
6.86% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/networks.go
0.53% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91af65c...ce8c31c. Read the comment docs.


[Bug]: Harcoded partition on arn causes failures when deploying to govCloud

Welcome to Amazon EKS Blueprints!

[X] Yes, I've searched similar issues on GitHub and didn't find any.

Amazon EKS Blueprints Release version
4.0.4
What is your environment, configuration and the example used?
locals {
  cluster_name    = join("-", [local.tenant, local.environment, local.zone, "eks"])
  cluster_version = var.cluster_version

  vpc_cidr = "<IP_ADDRESS>/16"
  vpc_name = join("-", [local.tenant, local.environment, local.zone, "vpc"])
  azs      = slice(data.aws_availability_zones.available.names, 0, 3)
}

module "eks_blueprints" {
  source = "github.com/aws-ia/terraform-aws-eks-blueprints?ref=v4.0.4"

  cluster_version = local.cluster_version

  vpc_id             = module.vpc.vpc_id
  private_subnet_ids = module.vpc.private_subnets

  managed_node_groups = {
    mg_4 = {
      node_group_name = "managed-ondemand"
      instance_types  = ["m4.large"]
      min_size        = "2"
      subnet_ids      = module.vpc.private_subnets
    }
  }

  platform_teams = {
    admin = {
      users = [data.aws_caller_identity.current.arn]
    }
  }

  application_teams = {
    team-app-dev = {
      "labels" = {
        "appName"     = "sample-app",
        "projectName" = "proof-of-concept",
        "environment" = "dev",
        "domain"      = "poc"
      }
      "quota" = var.default_team_resource_quota
      users   = [data.aws_caller_identity.current.arn]
    }
  }
}

module "eks_blueprints_kubernetes_addons" {
  source = "github.com/aws-ia/terraform-aws-eks-blueprints?ref=v4.0.1/modules/kubernetes-addons"

  eks_cluster_id = module.eks_blueprints.eks_cluster_id

  enable_amazon_eks_vpc_cni           = true
  enable_amazon_eks_coredns           = true
  enable_amazon_eks_kube_proxy        = true
  enable_aws_load_balancer_controller = true

  aws_load_balancer_controller_helm_config = {
    version = var.software_versions.load_balancer_version
  }

  enable_karpenter = true

  karpenter_helm_config = {
    version = var.software_versions.karpenter_version
  }

  enable_tetrate_istio  = true
  tetrate_istio_version = var.software_versions.istio_version

  tetrate_istio_base_helm_config = {
    name    = "istio-base"
    version = var.software_versions.istio_version
    values  = []
  }

  tetrate_istio_cni_helm_config = {
    name    = "istio-cni"
    version = var.software_versions.istio_version
    values = [yamlencode({
      "global" : {
        "hub" : "containers.istio.tetratelabs.com",
        "tag" : "1.12.2-tetratefips-v0",
      }
    })]
  }

  tetrate_istio_istiod_helm_config = {
    name    = "istio-istiod"
    version = var.software_versions.istio_version
  }

  tetrate_istio_gateway_helm_config = {
    name    = "istio-ingress"
    version = var.software_versions.istio_version
  }

  enable_metrics_server    = true
  enable_aws_for_fluentbit = true

  aws_for_fluentbit_helm_config = {
    version                                   = var.software_versions.fluentBit_version
    namespace                                 = "logging"
    aws_for_fluentbit_cwlog_retention_in_days = 90
    create_namespace                          = true
    values                                    = [templatefile("${path.module}/fluentBitValues/aws-for-fluentbit-values.yaml", {})]
    set = [
      {
        name  = "nodeSelector.kubernetes\\.io/os"
        value = "linux"
      }
    ]
  }

  enable_prometheus     = true
  enable_argocd         = true
  argocd_manage_add_ons = false
  argocd_applications = {
    workloads = var.workload_repo
  }
}

module "vpc" {
  source  = "terraform-aws-modules/vpc/aws"
  version = "~> 3.0"

  name = local.vpc_name
  cidr = local.vpc_cidr
  azs  = local.azs

  public_subnets  = [for k, v in local.azs : cidrsubnet(local.vpc_cidr, 8, k)]
  private_subnets = [for k, v in local.azs : cidrsubnet(local.vpc_cidr, 8, k + 10)]

  enable_nat_gateway   = true
  enable_dns_hostnames = true
  single_nat_gateway   = true

  public_subnet_tags = {
    "kubernetes.io/cluster/${local.cluster_name}" = "shared"
    "kubernetes.io/role/elb"                      = 1
  }

  private_subnet_tags = {
    "kubernetes.io/cluster/${local.cluster_name}" = "shared"
    "kubernetes.io/role/internal-elb"             = 1
  }
}

What did you do and What did you see instead?
Tried to deploy to govcloud. Expected everything to deploy and the cluster to be created
Instead got errors indicating that "aws" partition is invalid, which is true since that is not a valid partition in govCloud:
 Error: error creating IAM Policy eks001-preprod-dev-eks-fluentbit: MalformedPolicyDocument: Partition "aws" is not valid for resource "arn:aws:logs:us-gov-west-1:551785593453:log-group:*:log-stream:*".
│       status code: 400, request id: 39985699-665c-47ad-941b-be31ccec3eaf
│
│   with module.eks-blueprints-kubernetes-addons.module.aws_for_fluent_bit[0].aws_iam_policy.aws_for_fluent_bit,
│   on .terraform/modules/eks-blueprints-kubernetes-addons/modules/kubernetes-addons/aws-for-fluentbit/main.tf line 17, in resource "aws_iam_policy" "aws_for_fluent_bit":
│   17: resource "aws_iam_policy" "aws_for_fluent_bit" {
│
╵
╷
│ Error: error creating IAM Policy eks001-preprod-dev-eks-lb-irsa: MalformedPolicyDocument: Partition "aws" is not valid for resource "arn:aws:ec2:*:*:security-group/*".
│       status code: 400, request id: b7a0906e-e185-4d77-803e-cc1a98b5cf0f
│
│   with module.eks-blueprints-kubernetes-addons.module.aws_load_balancer_controller[0].aws_iam_policy.aws_load_balancer_controller,
│   on .terraform/modules/eks-blueprints-kubernetes-addons/modules/kubernetes-addons/aws-load-balancer-controller/main.tf line 10, in resource "aws_iam_policy" "aws_load_balancer_controller":
│   10: resource "aws_iam_policy" "aws_load_balancer_controller" {

Interestingly enough, these appeared to have been fixed as part of issue #346 but either they were not addressed fully of there is a regression
Additional Information
No response

Hi @camba1 - it looks like you might be using an outdated version of blueprints. I would update to the latest and see if your issue is resolved because in the code for the errors you've provided, these are showing the correct partitions now.
There area few other places I've found where the partitions are still hardcoded to aws and I'll update those now. you'll see this issue closed with that PR but just know that once you update to the latest your issue should be resolved. If not, please feel free to report back here or open a new issue, apologies and thank you for reporting!


README tweaks

Just some minor tweaks. Most notably the gzip part...

Make it more obvious we support .gz files
Link to pypi in text
Updates on speed increase claims using the cache
Cache re-creation note in bold

Merged, thanks!


tweek management should cache rules text instead of object

Current implementation do json serialization for each request.
Since rules object can be large (tens of MB), we should cache the text representation as well.

https://github.com/Soluto/tweek/blob/master/services/management/src/server.js#L51
https://github.com/Soluto/tweek/blob/master/services/management/src/rulesCache.js#L77


[Accordion] Not able to change checkbox value while using screen reader

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
In Accordion with additional action, the checkbox value to checked/unchecked cannot be done by using Enter/Space key. When pressing the Space key, focus moves back to the panel.

Note: This is only happening when using screen reader, with both JAWS and NVDA.
Steps to Reproduce 🕹

Steps:

Turn on any screen reader (NVDA/JAWS)
Click on this Link
Try to check the checkbox by hitting the Space key

Context 🔦

Your Environment 🌎

Tech
Version

Material-UI
v4.11.0

React
v 16.14.4

Nested interactive elements are usually discouraged especially because they are so inaccessible. In this particular case you're nesting a checkbox within a button. You'll have a hard time getting this pattern accessible with native elements or custom ones.
Adding more information about the user story for this widget would help identifying how you could improve this. For example toggling the checked state with a dedicated key.
While the way this breaks is less then ideal it's probably better to not support this pattern out-of-the-box. We need more context to fix this problem without allowing too many inaccessible patterns.

@eps1lon This is the example from our Accordion docs page.
@rpsabarimani Which screen reader do you recommend to install, and how (a chrome extension?)? I'm on Ubuntu Linux. Could it be that this is a bug in the screen reader?

@rpsabarimani As per ARIA specs it is not allowed to have role=button inside role=button (note that button HTML element has an implicit role=button). https://www.w3.org/TR/html-aria/#allowed-aria-roles-states-and-properties
This also means that our demo shows something that is ARIA invalid.

@croraf is right button > input is not a valid markup. It's reported in https://validator.w3.org/nu/?doc=https%3A%2F%2Fnext.material-ui.com%2Fcomponents%2Faccordion%2F.

What about we drop the "Additional actions" section/demo/support?

Yes. I think I would drop that section.


Release Google.Cloud.ServiceManagement.V1 version 2.2.0

Changes in this release:
Documentation improvements

Update docs to existing services (commit 68f3129)

Created release for Google.Cloud.ServiceManagement.V1-2.2.0


cloud-nuke v0.36.0 binary release artifacts missing

Freshly released cloud-nuke v0.36.0 does not contain binaries in the release assets https://github.com/gruntwork-io/cloud-nuke/releases/tag/v0.36.0

Could you please add these?
Thanks for your awesome work!

Hey, @denis256, @james03160927, could somebody please confirm that the tag v0.36.0 was moved intentionally to a later commit despite good practice of not doing so?
We detected a hash change of 10.36.0 code in homebrew-core.

The git manual says re-tagging is "the insane thing" to do, so I hope that's not it.


Fix hardcoded file format in python materializations

resolves #803
docs dbt-labs/docs.getdbt.com/#

Problem
Solves the bug in #803

Solution
Maintains delta as the default file_format

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@ben-schreiber thanks can you add a changelog?

@colin-rogers-dbt ✅


Switch to GitHub Actions

Travis CI has been throwing up some bizarre timeouts, so this is an attempt to switch to GitHub Actions, which I've generally had good experiences with

Add a "clippy" job, too. See: https://github.com/rsmpi/rsmpi/pull/101#pullrequestreview-533343821

Alright, this passes with I think decent coverage. Thanks @AndrewGaspar for the groundwork, especially the Windows install.
I'm going to merge this now because there's presently no CI on main -- we can modify this in a future PR if there are comments.


Update client sdk

This contains a refactor of the abstractions of the client SDK.
Explanation of the new interfaces:

store.Store represents the main db where the configuration data are stored. Replaces the old config store
client.Client represents the client used based on transport protocol, either grpc or rest. Replaces old inner client
explorer.Explorer the old explorer interface has been moved to a dedicated folder and properly scaffolded to be ready to "host" the bitcoin implementation (very soon)
wallet.Wallet represents the wallet as a generic multi-key wallet, with methods for deriving new address and get all the derived ones for example . This is an evolution of the old wallet interface. The singlekey wallet is now basically an extremely simplified version of a (non) multi-key wallet. The interface definition should be ok for a future bitcoin HD wallet (built on top of btcwallet). Just so you know, this interface might be subject to changes in the future when we implement an HD wallet.*

Now setting up the SDK client is as simple as selecting the desired store type (json file, inmemory currently supported) or providing a custom store implementation - we'll get back to this in a few.
Example.
If the store is empty, it's necessary to initialize the SDK client - config data are persisted in store -, otherwise it is initialized with the data retrieved from the store, just like the CLI works to make a comparison.
The list of features of the SDK client has been maintained - beside some renaming - with the addition of 2 methods to Unlock/Lock the inner wallet. This way, it's not mandatory to always provide the password for the required methods if the wallet is already unlocked. It is something similar to an optional login/logout session.
In the WASM pkg, I added a local-storage implementation of store.Store and made it consumed by the SDK client - with a fallback strategy just for safety.
I successfully executed the wasm example in the browser! 🥳
Last but not lease, this adds unit tests for the implementations of the interfaces listed above - not all of them. The gh action has been updated to run unit tests for server and SDK modules.
In a later PR we will make the current alice-bob example a proper integration test. This is already huuuge, no need to make it even bigger.

The singlekey wallet makes uses of a walletstore.WalletStore that is an extension of store.Store in charge of persisting the wallet encrypted data. The json file impl of store.Store and walletstore.Store can write on the same file without risk of loss of information. This interface is needed only and exclusively by the singlekey wallet impl that needs a persistency layer. A future btcwallet impl will have all the db completely managed, so all this won't be needed at all.

Closes #206.
Please @louisinger @sekulicd  review.

Any comments? @sekulicd @louisinger

I have some general comments regarding this PR:
Firstly, while there are some improvements such as the addition of a local storage option for the browser (wasm), the refactoring introduces significant changes compared to the existing state. It would be very helpful to have a clearer explanation of the intentions behind these changes and the benefits they bring. For instance, could you please elaborate on the benefit of refactoring inner_client and making its methods public?
My primary concern is the use of the factory pattern. It feels like a premature optimization aimed at anticipating future scenarios like different types of wallets (HD, or different types of stores). As mentioned in the PR description, the Wallet interface "might be subject to changes in the future."
In the factory methods, we are attempting to cover all cases within a single New method. For example, here, I would suggest adding an additional factory method NewWithCustomWalletStore instead. The current implementation of the wallet factory method appears complex.
The logic for creating a wallet based on the type of store could be simplified by using separate constructors instead of a switch-case within a single function. I assume the single factory method will eventually be used for both liquid and BTC wallets. In general, I prefer the previous version where interfaces for wallet and store were passed directly, avoiding the need for switch cases in factory methods.
Additionally, variadic functions can be error-prone, and I believe the current function signatures are not user-friendly for clients. In the previous version, wallet and config stores were separated, which I think is a better design. The wallet doesn't need all the configuration information; it primarily uses network, aspPubKey, and UnilateralExit.
Furthermore, some configuration fields that were removed in the previous version because they could always be fetched from the ASP using the GetInfo API seem to have been reintroduced. I don't see the need for storing these fields.
Regarding naming conventions, exposed structs should not start with the same name as their package. For example:
store.Store
client.Client
explorer.Explorer
wallet.Wallet
Lastly, there has been a lot of code movement without clear benefits, such as the changes to inner_client. Additionally, there are now utils in both pkg/utils.go and internal/utils, which could lead to confusion.
I hope these points help in refining the changes and ensuring the refactoring brings clear benefits while maintaining the simplicity and usability of the codebase.

I do agree regarding having multiple factories instead a single one with lot of config options that can led to errors as we scale.
I do also agree that password should be abstracted as is not all the key signers will be protected by it (it can be a dedicated interface)
For the rest, can't speak much in terms of implementation details, but the current APIs are pretty user friendly (looking at the example)

For instance, could you please elaborate on the benefit of refactoring inner_client and making its methods public?

For development purpose, if somebody wants to develop a custom wallet he could make use of the rest or grpc or rest clients.
Also, there wasn't a real reason to handle rest or grpc in a dedicated struct with if/switch, they became 2 different impl of the same interface
This is the reason why we expose also the store, wallet, etc interfaces: we provide a our way of abstracting an ark client but if it doesn't fit somebody's need, he can make use of the "inner components" to build his own ark client

My primary concern is the use of the factory pattern. It feels like a premature optimization aimed at anticipating future scenarios like different types of wallets (HD, or different types of stores). As mentioned in the PR description, the Wallet interface "might be subject to changes in the future."

Not so premature since this abstraction comew after writing the actual cli, the bitcoin cli coming with the related pr, and the definition of other external services.
I said that the wallet interface might be subject to changes because i'm not 100% sure if it's ok for a later hd implementation. The current one is taylored for a single-key impl tho and 100% is not ok for the hd impl.

NewWithCustomWalletStore instead. The current implementation of the wallet factory method appears complex.

Agreed, seems much cleaner

The logic for creating a wallet based on the type of store could be simplified by using separate constructors instead of a switch-case within a single function. I assume the single factory method will eventually be used for both liquid and BTC wallets. In general, I prefer the previous version where interfaces for wallet and store were passed directly, avoiding the need for switch cases in factory methods.

That was the original idea but i had to add this factory to avoid circular dependencies

Additionally, variadic functions can be error-prone, and I believe the current function signatures are not user-friendly for clients. In the previous version, wallet and config stores were separated, which I think is a better design. The wallet doesn't need all the configuration information; it primarily uses network, aspPubKey, and UnilateralExit.

Can you make a list of the funca you consider error-prone? Better to review them together
Wallet and store are still separated! Wallet must take care of persisting only the keys, while store is meant to persist asp and config data.
I think the separation of concerns is more clear now than before.
Furthermore, Walletstore is the persistency layer for the singlekey wallet only.
An hd wallet like btcwallet doesn't need and won't use this inteface, it comes with a fully managed persistency layer for the keys.
Walletstore's exception is that it's meant to persist data in the same place where store does, exactly like we currently do in the actual cli. Take it as a poethic license :) but remember that at some point the singlekey wallet will be used only for dev purposes, so i think it's fine to take this license on a non-prod tool
The hd wallet will need a store, or either the store data becuase it need to acccess info like asp pubkey for things like address derivation. Or maybe even better to pass these required data as func args noe that i thing about it, i'll reson on this. I'll try to find the time to sync offline in the next days.

Furthermore, some configuration fields that were removed in the previous version because they could always be fetched from the ASP using the GetInfo API seem to have been reintroduced. I don't see the need for storing these fields.

Can you make a list of such fields? Consider just that some info like the asp pubkey are static so it's fine to fetch them only once. In a second moment would be nice to add cache invalidation in the ark client so we are sure the stored info are always up-to-date, but too soon now to reason about this.

Regarding naming conventions, exposed structs should not start with the same name as their package.

Do you agree on adding a Service suffix to those interfaces?

Can't we move the password logic outside of the Client interface and make it customizable (like either unlock 1 time or ask every time we need the secret keys etc..) ?

It should be already possible by making use of the client's Unlock/Lock methods wherever you need and pass an empty string as password in send because you already unlocked the wallet by yourself. If you don't need such "custom" scenario you can just let the send method to handle the unlock.
Basically you can choose whether managing the authenticated session or let it be managed by the client itself.
cc @louisinger

I do also agree that password should be abstracted as is not all the key signers will be protected by it (it can be a dedicated interface)

I agree but i thought it was too early for this as i don't have a clear vision of such component.

Consider that the current ark client is unauthenticated
cc @tiero

It should be already possible by making use of the client's Unlock/Lock methods wherever you need and pass an empty string as password in send because you already unlocked the wallet by yourself. If you don't need such "custom" scenario you can just let the send method to handle the unlock.

Most of "external" wallets like Hardware devices or browser extensions handle the authentication independently. So I'd revert this change if it's not necessary to have it. Let's assume the Wallet interface is handling the lock/unlock process when it's necessary ?

Can you make a list of such fields?

We use aspPubKey, network, round lifetime, unilateral exit
message GetInfoResponse {
  string pubkey = 1;
  int64 round_lifetime = 2;
  int64 unilateral_exit_delay = 3;
  int64 round_interval = 4;
  string network = 5;
  int64 min_relay_fee = 6;
}

Do you agree on adding a Service suffix to those interfaces?
For store i would do similar to prev stare store.Config store.Wallet interfaces, for client maybe transport.ArkClient or some combo of these words, for rest yeah i guess better to choose Service over same word for pkg and struct/interface.

Can you make a list of the funca you consider error-prone? Better to review them together

Its related to this factory pattern, that, i can see, u like to use :), for eg here.

FWIW check BDK who just release his v1 with extensive refactor after years of adoption among Bitcoin dev community
https://x.com/bitcoindevkit/status/1815412036723171501?s=46


Display the size of an image alongside its name

When viewing an image inside VSCode it'll be nice if we could've seen the image's size in pixels.
For example with the following image, the size will be displayed alongside its name -

logo.png (400x400)

Although being a minor addition I think that it'll be very useful

It's already there at the right side of the status bar between the size and zoom level.


productpage v1:1.15.0 wont run with different uid

Bug description
If you try to start productpage v1:1.15.0 with a different uid such as 1001 python will error with KeyError: 'getpwuid(): uid not found: 1001'
docker run -it  --user 1001 istio/examples-bookinfo-productpage-v1:1.15.0 sh
python productpage.py 9080
cat /opt/microservices/stderr.log
Traceback (most recent call last):
  File "productpage.py", line 379, in <module>
    app.run(host='<IP_ADDRESS>', port=p, debug=True, threaded=True)
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 943, in run
    run_simple(host, port, self, **options)
  File "/usr/local/lib/python3.6/site-packages/werkzeug/serving.py", line 751, in run_simple
    application = DebuggedApplication(application, use_evalex)
  File "/usr/local/lib/python3.6/site-packages/werkzeug/debug/__init__.py", line 258, in __init__
    if self.pin is None:
  File "/usr/local/lib/python3.6/site-packages/werkzeug/debug/__init__.py", line 268, in _get_pin
    self._pin, self._pin_cookie = get_pin_and_cookie_name(self.app)
  File "/usr/local/lib/python3.6/site-packages/werkzeug/debug/__init__.py", line 148, in get_pin_and_cookie_name
    username = getpass.getuser()
  File "/usr/local/lib/python3.6/getpass.py", line 169, in getuser
    return pwd.getpwuid(os.getuid())[0]
KeyError: 'getpwuid(): uid not found: 1001'

Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure
Expected behavior
Start productpage with different security context user (non-root) such as 1001 and it starts up correctly.
Steps to reproduce the bug
docker run -it  --user 1001 istio/examples-bookinfo-productpage-v1:1.15.0 sh
python productpage.py 9080

Version (include the output of istioctl version --remote and kubectl version)
istio 1.2.2
k8s 1.15.0
How was Istio installed?
Helm Chart
Environment where bug was observed (cloud vendor, OS, etc)
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

This may be fixed in Python 3.7.  https://bugs.python.org/issue31469


write small files into metadata storage

What would you like to be added:
Can files smaller than 4KB be written to metadata storage (tikv) instead of s3?
Why is this needed:
This may improve IOPS for small files.

This could potentially lead to exponential growth in the capacity demands of the metadata engine, which in many cases might prove to be counterproductive. We believe that it introduces additional complexity without delivering sufficient returns in most cases. Thus, for now we won't put it into our development roadmap.
Also we find that a similar feature in CephFS has been declared deprecated.


Make Verilator faster?

Just a suggestion.
Verilator seems to work but can easily be made faster:

change timescale in Verilog top  to timescale 1ns / 1ns (this will be one clock tick/ns)
use fasted possible clock in this case 2ns period cocotb.fork(Clock(dut.clk, 2, units="ns").start()) (no clock ticks that nothing is going on)

Done!  Well, for the tests here verilator vs. iverilog probably makes little difference as the simulator isn't really doing anything since there isn't any logic in the verilog files.


BitNet model performs wrose than Base Transformer

I use the train.py to train the BitNet model and Base Transformer Model and have a comparison with them, I found BitNet consumes more time and space while achieveing lower loss compared to base model, which is not consistent with what the BitNet paper clamins. What could be the reason for this?

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

Not sure if it is a bug...
In my understanding of BitNet, training BitNet will cost more space as both int1 weights and fp16 weights (if you go for mixed precision training else fp32) are stored. It will be slim and fast for inference. 🤔


Update route.js

Feat route.search
export default {
 ///... options
 watch: {
   '$route.search' () {
     // update data
   }
 }
}

What feature are you trying to add that Vue doesn't have?

Yes, but this submission seems to be a bug

What are you trying to add with that search property? It looks like the hash property
If you have a bug please, open an issue with a repro

It's the same thing as $route.query, but sometimes it takes the form of a string

Thanks for the pr, but we'll pass on this for the moment. You can open a new issue explaining the feature request if you want but I don't feel as if this is something we need.

Because $ruote.query is a reference type, when I store a $ruote.query, when I switch back different routes back, then I compare the stored $ruote.query with the current $ruote.query and return the false. When using $ruote.search, it won't fail because it is a string type comparison

In that case you can compare both queries converting them into strings
first. Just in case, you should not modify the query object because the
$route object is immutable
On Mon, 22 May 2017, 03:40 狼族小狈<EMAIL_ADDRESS>wrote:

Because $ruote.query is a reference type, when I store a $ruote.query,
when I switch back different routes back, then I compare the stored
$ruote.query with the current $ruote.query and return the false. When using
$ruote.search, it won't fail because it is a string type comparison
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/vuejs/vue-router/pull/1445#issuecomment-302979503,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoicdGrkeO09YPAGwbmR7MTFcOhZA01ks5r8OeagaJpZM4NhVyd
.

You should use an object comparison function in your case.


[Discussion] tests should be js or ts extension

I found all tests have ts extension now, it will lead to issues:
1、 vscode extension Jest will not work correctly
2、 Invalid test data provided to test case will report ts error in editor.

you can use type casting to workaround it
interpreter.import(2 as any)
interpreter.import(true as any)
interpreter.import(Symbol('hello') as any)

Any reason to use ts file extension?

no specific reason. you can use js for tests

closed.


net/devif: Remove the unnecessary net lock/unlock in devif_callback

Summary
since the caller already hold the net lock before. See the discussion here: https://github.com/apache/incubator-nuttx/pull/4575
Impact
No, remove the redundant lock/unlock
Testing

since the caller already hold the net lock before.

@xiaoxiang781216 can we be sure of this?   I tried to follow the calls, but in some cases I couldn't find a lock.


Fix plane model matrix calculation

This broke the clipping planes Sandcastle example.  I was correctly checking if up was parallel to the plane normal in the same direction, but forgot to check if they were parallel and pointing in opposite directions.
I also exposed createPrimitiveMatrix as a private function so I can re-use it instead of copy/pasting the function.

Thanks for the pull request @hpinkos!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

@lilleyse can you review and merge please?

Could this use the dot product instead?
Math.abs(Cartesian3.dot(up, transformedNormal)) > 1.0 - CesiumMath.EPSILON8)

Yes, that was a better solution.  Thanks @lilleyse, this is ready

Looks good!


[SPARK-28776] SparkML Writer gets hadoop conf from session state

What changes were proposed in this pull request?
SparkML writer gets hadoop conf from session state, instead of the spark context.

Why are the changes needed?
Allow for multiple sessions in the same context that have different hadoop configurations.

Does this PR introduce any user-facing change?

No
How was this patch tested?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@jkbradley you seem to have reviewed previous prs to this file like https://github.com/apache/spark/pull/18742. Would you be able to review this pr, or suggest another person to do so?

Just for my reference, does this make it consistent with other similar code? just want to understand the argument why this needs to change - what problem does the current code cause?

Hi @srowen
I believe the general convention is to use the session state's hadoop conf (see https://github.com/apache/spark/blob/39577a27a0b58fd75b41d24b10012447748b7ee9/examples/src/main/scala/org/apache/spark/examples/DFSReadWriteTest.scala#L115) . This also prevents correctness issues when multiple spark sessions are sharing the same context and they want to have their own hadoop conf (for example, that contains an authentication key that shouldn't be shared across users)

Test build #4837 has started for PR 25505 at commit 9c8f93c.

Test build #4837 has finished for PR 25505 at commit 9c8f93c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Thanks @srowen ! Now that the tests have passed, is this PR good to merge?

(I usually leave it open at least a day to catch any more comments)

Merged to master


Prefix for default language

I'm using this plugin for a long time using this tutorial:
https://mydnic.be/post/how-to-build-an-efficient-and-seo-friendly-multilingual-architecture-for-your-laravel-application
It's working fine, but I still haven't found a solution for removing the default language prefix.
Let's say I have two languages. German and English.
When the website has default set as German language , I got this URL:
www.mywebsite.de/de
Please anybody help to remove the prefix /de for the default language.
I've already checked the comments for this issue on the tutorial website, but still no solution for that.

The routing part is pretty bad. 🤔 Using segments and a hard route prefix ties you so hard to a given structure. So you can't do admin/de and app/de for example.
It's better to use a route group with a named variable as prefix. I haven't tried but it should be possible to flag it as optional.
In your middleware you only change the app local if it's present and matches a given one.
But this issue also doesn't belong to this package.

router:
Route::group([
    'middleware' => ['localized'],
    'prefix' => '{language}',
], function () {
    // all localized routes
});

middleware:
namespace App\Http\Middleware;

use Closure;
use Illuminate\Http\Request;

class Localized
{
    public function handle(Request $request, Closure $next)
    {
        $locale = $request->route('language');

        if (!in_array($locale, config('app.locales'))) {
            return redirect()->to(localized_route($request->route(), default_locale()));
        }

        app()->setLocale($locale);

        return $next($request);
    }
}

Hi, Gummibeer.
Yes, I know this issue is directly related with your plugin, but any help is useful.
So, your approach is to setup the Route group into routes/web.php and setup a new Localized middleware, right?
I've tried now by adding this route group into web.php.
Route::group([
    'middleware' => ['localized'],
    'prefix' => '{language}',
], function () {
    // all localized routes
});

I've created also your Localized middleware and setup in the Kernel.
I don't understand which routes should I set into?
..
function () {
    // all localized routes
});

By the way if I set any route inside, I'm getting this error:
in_array() expects parameter 2 to be array, null given
and it's related with this line from the Localized class:
if (!in_array($locale, config('app.locales'))) {

Sorry, forgot the custom config - it's just a simple list of locales:
'locales' => [
    'de_de',
    'en_us',
],

And yes, the route group belongs into the routes/web.php and inside of the group function you put all your routes which should be localized.
These functions are also custom ones localized_route($request->route(), default_locale()) you can replace them.
I also have an event listener for \Illuminate\Foundation\Events\LocaleUpdated:
namespace App\Listeners;

use Carbon\Carbon;
use Illuminate\Foundation\Events\LocaleUpdated;

class SetAppLocale
{
    public function handle(LocaleUpdated $event)
    {
        setlocale(LC_ALL, $event->locale);

        \URL::defaults([
            'language' => $event->locale,
        ]);

        Carbon::setLocale($event->locale);
    }
}

This custom listener sets the locale for all locale aware services which aren't set by laravel. The URL::defaults() allows to call any route/url generator without providing the current locale but get a localized url with the current locale.
At all I recommend to ask your questions in https://larachat.co , https://laracasts.com/discuss or any other general laravel help area. Because some of these things are always app specific - The major thing you have to get done is flag the locale url variable as optional.

Thank you for your explanation!
I hope I'll achieve this. :)


Rework ReadFile/QueryFile To Avoid Boxing

Currently, the More/Read cases in these algebrae produce Vector[Data], which requires hard-boxing into Data and ultimately indirection around what the final output format may be (for example, CSV).  A better approach would be to push down the rendering of data to the backend by rephrasing the whole algebra.  This is most easily seen with ReadFile, though QueryFile is analogous.
My proposed cases are the following:
sealed abstract class ReadFile[A]

object ReadFile {

  final case class Open(
      file: AFile,
      offset: Natural,
      limit: Option[Positive],
      mimeType: MimeType) extends ReadFile[FileSystemError \/ ReadHandle]

  final case class Read(h: ReadHandle)
      extends ReadFile[FileSystemError \/ Option[CharBuffer]]

  final case class Close(h: ReadHandle)
      extends ReadFile[Unit]
}

Where MimeType is something like the following:
sealed abstract class MimeType(override val toString: String) extends Product with Serializable

object MimeType {
  case object JSON extends MimeType("application/json")
  case object CSV extends MimeType("text/csv")
}

Give or take.
 Seems like we should leave these as separate issues.

@zeeiyerWork Did you attempt to link a ticket?  I created this ticket, as well as the only other ticket linked to this one.

yep -> #2592

I don't know if that issue has anything to do with value boxing specifically. For all I know, it could be fixed, but I couldn't run my test case due to that failure. I worked around the value boxing (still old mongo) another way.

Yeah I don't think this is related to Nate's issue.


Nested colorize objects disable all attributes

require "colorize"

foo = "foo".colorize.red

str = "hello #{foo} bar".colorize.underline

str => "\e[4mhello \e[31mfoo\e[0m bar\e[0m"

Because coloring/modes are reset via \e[0m all attributes are turned off, not just the one that is ending.  The correct code sequence should be like "\e[4mhello \e[31mfoo\e[39m bar\e[24m".  I.e. \e[39m only resets the foreground color and \e[24m only resets the underline.

That only solves part of the problem because you could still have:
foo = "foo".colorize.red
str = "hello #{foo} bar".colorize.green
str

and bar will not be colored, even when foo ends with \e[39. The #surround method might handle this correctly, but not string interpolations I believe.

Yeah and I don't think there can be a good solution really. To properly return to the previous colorize state, it would be necessary to keep track of the context.
This technically works, but the nested colorization needs to be actually nested inside the colorize surround context.
String.build do |io|
  Colorize.with.green.surround(io) do
    io << "hello #{"foo".colorize.red} bar"
  end
end # => "\e[32mhello \e[0;31mfoo\e[0;32m bar\e[0m"

Note that this is not concurrency safe because there is just a global @@last_color property.

I agree with @HertzDevil and @straight-shoota . The way these ansi codes work is not composable (unlike, say, html tags) because they are just toggles. And because of that, string interpolation won't work.
I think this is a "wontfix". Or, well, you can use surround.

I mean I don't think we can solve for all use cases so maybe this is more of an enhancement than a bug.  But is there any reason to not use the correct toggles instead of \e[0m?  At least then it'll be more correct than before in more cases.


Generate layout.ld from templates + data

Fix #329
Obvously, k20 is still a special case, but I think this gives a good base on which to build a generator that will work generically accross all supported MCUs. (We still have #109) to track the k20 layout in.
I would make an attempt, but I don't have a k20 board or anything, so maybe @bgamari could take a look at some additions to this generator?
I think the way forward is to have like flash_config: Option[McuFlashConfig] in McuLayout and then struct McuFlashConfig { ... } elsewhere... but that could be a naive  solution that I just came up with at first glance.

Coverage remained the same at 85.657% when pulling c3e54e6e96ce500fbb4714029cdac715f60bd825 on mcoffin:layout-mcu#329 into 64aa605167813f8e360ce6173109acb632dee33b on hackndev:master.

Coverage remained the same at 85.657% when pulling c3e54e6e96ce500fbb4714029cdac715f60bd825 on mcoffin:layout-mcu#329 into 64aa605167813f8e360ce6173109acb632dee33b on hackndev:master.

Looks like rebuilding everything for every example is starting to bit us in the butt a little. Might have to split each example in to it's own jenkins matrix now, which would... suck to say the least. Or at least provide a way to build example subsets until we could finally use cargo's [[example]] again.


fix(#4190): useLabels/useLabel consider reordering IDREFs so that aria-label comes before aria-labelledby

Closes #4190
✅ Pull Request Checklist:

[x] Included link to corresponding React Spectrum GitHub Issue 4190.
[x] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[x] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:
Adobe/Accessibility

@snowystinger Thanks for the commit, removing my over-engineering in the tests, and for your approval.


Folder color block is too high

Hi
Please change the green color of folder make readable

Its hard to read :(

Hi thank's fot the issue,
I will change it!

I changed the background color, please verify new feature!


Disabled invoice view and restirct no. of recipient emails

This changes are build on main branch code and not on develop branch code.
The reason is as the develop branch is not tested yet I'm using main branch code to implement this fix.
I will test this change in staging and deploy it to production.
Screenshot:

Need to refactor the spam-related changes from the user model, especially the spam errors

Sure will do that after deploying the fix to production


Tags form

@AlinaJahnes @Jguzik83 @ChristineSchatz Tags should be working! Let me know what you think or if it breaks.

Looks great. just tested everything and works awesome. Great Job! :bee:


try-with-resource support.

See 1.13 PngSizeInfo.

https://github.com/MinecraftForge/ForgeFlower/pull/21 Pulled


Update meshoptimizer

Description
Update meshoptimzier to the latest release
Issue number and link
N/A
Testing plan

Ensure unit tests pass.
Ensure all models in the models Sandcastle load.

Author checklist

[x] I have submitted a Contributor License Agreement
[x] I have added my name to CONTRIBUTORS.md
[ ] I have updated CHANGES.md with a short summary of my change
[ ] I have added or updated unit tests to ensure consistent code coverage
[ ] I have updated the inline documentation, and included code examples where relevant
[x] I have performed a self-review of my code

@jjhembd Can you please take look so this is ready for the release on Monday?


服务启动超时

Qinglong version
抱歉，忘记了，上个月中旬docker装的最新版
Steps to reproduce
刚装好时啥都正常的，也正常跑了一段时间，今天准备上去操作一下，发现进不去了，提示服务启动超时
What is expected?
希望能正常进入
What is actually happening?

PM2        | 2023-11-10T14:28:38: PM2 log: App [panel:2] exited with code [0] via signal [SIGINT]
PM2        | 2023-11-10T14:28:38: PM2 log: pid=16815 msg=process killed
PM2        | 2023-11-10T14:28:38: PM2 log: App [panel:2] starting in -fork mode-
PM2        | 2023-11-10T14:28:41: PM2 log: App [panel:2] online
/root/.pm2/logs/schedule-error.log` last 15 lines:
/root/.pm2/logs/public-error.log last 15 lines:
/root/.pm2/logs/schedule-out.log last 15 lines:
0|schedule | 2023-11-10T14:28:23: ✌ 定时服务启动成功！
/root/.pm2/logs/panel-error.log last 15 lines:
2|panel    | 2023-11-10T14:28:23: Server need close, singal SIGINT
/root/.pm2/logs/public-out.log last 15 lines:
1|public   | 2023-11-10T14:28:23: ✌ Sentry loaded
1|public   | 2023-11-10T14:28:24: ✌ DB loaded
1|public   | 2023-11-10T14:28:24: ✌ 公共服务启动成功！
/root/.pm2/logs/panel-out.log last 15 lines:
2|panel    | 2023-11-10T14:28:39: ✌ DB loaded
2|panel    | 2023-11-10T14:28:39: ✌ Init file down
2|panel    | 2023-11-10T14:28:39: ✌ Sentry loaded
2|panel    | 2023-11-10T14:28:40: ✌ Dependency Injector loaded
2|panel    | 2023-11-10T14:28:40: ✌ Express loaded
2|panel    | 2023-11-10T14:28:40: ✌ init data loaded
2|panel    | 2023-11-10T14:28:40: ✌ link deps loaded
2|panel    | 2023-11-10T14:28:40: ✌ init task loaded
2|panel    | 2023-11-10T14:28:41: ✌ 后端服务启动成功！
^C

System Info
root@qinglong:/ql $ npx envinfo --system --binaries --browsers
Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y) y

  System:
    OS: Linux 5.15 Alpine Linux
    CPU: (3) x64 Intel(R) Core(TM) i3-10105 CPU @ 3.70GHz
    Memory: 806.62 MB / 1.92 GB
    Container: Yes
    Shell: 5.2.15 - /bin/bash
  Binaries:
    Node: 18.17.1 - /usr/bin/node
    npm: 9.6.6 - /usr/bin/npm
    pnpm: 8.3.1 - /usr/local/bin/pnpm

Any additional comments?
最后一次正常进入面板后没动什么，莫名其妙就不能进入了，系统是 Ubuntu 22.04 x86_64，虚拟机，脚本还在正常执行

又重启了下容器，好了……此贴终结


[Suggestion] Editing the RPC via a config file

I would love to have the ability of being able to edit what is being shown. I'm not that big on showing the album name as it can look cluttered depending on the length of the title.

Added some configuration options when you compile it! These should be out pretty soon and allow you to customize the app to your liking.


Is this ready to share more widely?

We're looking at linking to this project in http://postgresweekly.com/ this week but due to it going out today, we haven't got time to test. Just wanted to check in if the project is ready to share (or not) :-) Thanks!

Hi Peter.
Honestly, I would hold-on until next week.
I created this project because the other vagrant boxes for PostgreSQL didn't handle the full lifecycle and would basically fall apart and/or destroy themselves and your data.
But it's not quite there yet, I need to make sure that people can entrust their data with this vagrant box and won't run into any surprises 6 months or a year down the line, and that it offers at least some easy & simple way of creating backups that can be archived & restored easily.
However, at the end of the day, it's your call.

No problem at all, that answer is totally why I wanted to check in :) Best of luck with the project!


Updating history independent of turbolinks

Hi,
First of all, thanks for this amazing library. I have a question though. How would you recommend updating the history manually (without turbolinks) but then make it play nicely with the rest of the navigation via turbolinks.
What happens right now is, that when you continue navigating after doing some history.pushState operations and then go back with the browser back button, the page stays the same but the URL changes. I understand also why, because my pushState calls didn't have the turbolinks key but when I add this information to the state when using pushState, it triggers page loads, where I don't want them.
I'm confused that there isn't any documentation for this case. I can imagine that this use case is quite frequent.
Thanks!

Hi @joker-777
Thanks for raising this. Yes, this has come up once or twice (#61, #219).
There is currently no official way to push or replace state. As I mention in https://github.com/turbolinks/turbolinks/issues/219#issuecomment-424817249, there are a couple of public methods that you may wish to try, although as they are not documented, they may not be available in future versions. (e.g. Turbolinks.uuid() is no longer public as of v5.3.0-beta.1, so you may need to implement your own UUID.)
Given that there is already an open issue and an open pull request, I'll close this for now.

Thanks a lot for your quick response. As far as I can see using
Turbolinks.controller.pushHistoryWithLocationAndRestorationIdentifier(location, Turbolinks.uuid())

has the same effect as
window.history.pushState({custom: turbolinks_state}, null, create_url(content_tags))

It kind of works but it has this very ugly loading and slow loading effect when using the browser back/forward buttons.


Does it work with Infuse player?

Hi, thanks for creating an awesome addon for Plex
I use Infuse player on Apple TV and it doesn't seem to work. I'm guessing it's due to it not "advertising as player" like official Plex apps but would like to confirm. I can't find anything online, even in Infuse's forums
Thanks

You are correct, infuse is a custom player that does not implement Plex Companion and therefore cannot be controlled via the API


Adding diagnostic functions

We should add functions that allow, given a config file and a raw object, to generate diagnostic figures for each of the steps. Representations shown in the first two figures of this paper https://pubmed.ncbi.nlm.nih.gov/33038417/ are probably a good starting point.

It actually might be helpful for us to have some form of this done by paper submission (so end of June)?

Sure. But I think this is still milestone 0.02 (i.e., not blocking 0.01).


Missing parameteres in declarations of generic types

Like here:
https://docs.microsoft.com/en-us/uwp/api/windows.devices.enumeration.devicewatcher#events_
DeviceWatcher::EnumerationCompleted event is declared like this:
public event TypedEventHandler EnumerationCompleted
But it should be:
public event TypedEventHandler<DeviceWatcher^, Object^> EnumerationCompleted
Also the description of parameters of generic type is missing. E.g. what does the Object^ parameter represent?
I can see this throughout the whole UWP documentation at docs.microsoft.com.
J.

Checking to see where we're at with this issue.

The fix for this issue will be rolled out in the next week.

Thanks for the fix :-). I'll check it in couple of days, because I still see the old version.


Create a Object Type Template Index View Wireframe

Child of #57
How can you visually see the list of Object Type templates in the system.

Should assume a fare amount of Knowledge from the user.


Create comments

Comments look like this:
# hello I am a comment
$a = i am a string

Added via b28ea9b80746db2e089c536ae8a68282b1470e37