Version 3.0 -- clicking on feed's name in a story doesn't open the feed

Hi,
I love the new look.
However, in the old look, when I was going through the "All" "feed", I'd often open an item and click on the feed's name under the item's title and it would bring me to feed's view. Similarly, clicking on the story title would open the URL.
In the new look, clicking anywhere on the item just opens or closes it. I can go the the story by clicking on the "Open link" button, but I can't reproduce the other behaviour.

There's another behaviour I use in the old look that I miss in the new: On mobile, I am a heavy user of swiping right on the story's title to toggle read/unread.
My use-cases:

I see a story that I'm not interested in reading ... I swipe right to mark it as read.
I see a story that I am interested in reading, but when I open it I see it's longer than I have time to read it, so I swipe right to mark it as unread to come back to.

On desktop, I use the 'm' key for these use cases.

Thanks for the feedback, I'll see what I can do! (and to be honest I completely forgot about the "swipe to mark as read" feature 😄)

I added a context menu to navigate to the feed if a category is displayed:


Sequencing of %i and %o seems off...

I had to change the 'launch timing' of the initial self.maxima_setup_command = "display2d:false$" command to get current maxima v5.43.2 to cooperate with this library.  If I don't do this, maxima_interface appears to hang waiting for its first '(%o' response.
Is this fix something that would be helpful as a PR?

Thank you for figuring this out! I would be delighted if you made a PR.


Possible implementation for a "quiet" flag

This was my quick attempt at a quiet flag.
Since you mentioned in #65 that you might prefer to instead tie these to the verbose flag, please feel free to discard/reject the pull request.
I'm opening it just in case you'd like to copy-paste parts or use the diff as a starting point etc.

Hi Chris,
Thanks for looking at this. As you mentioned I wasnt too sure on the best approach and I think actually just suppressing these messages other than verbose mode makes more sense than adding another mode. Thanks for taking a look though and sorry to not use it.


Filter to show all sprectrograms tagged "Unsure"

Stakeholders P and N wanted a page listing all spectrograms tagged unsure.
Additionally, stakeholder N mentioned that they want to be able to send this page to someone else to verify the ones they are unsure about.

Duplicate of #138


Keep the names?

The names Work, Expression, Manifestation, and Item were developed in a library catalog context. Are they:

sufficiently broad for openWEMI?
confusing?
well known enough that we should continue with them?

@kcoyle

well known enough that we should continue with them

To me, this is the most convincing reason. If openWEMI (or CWO) were to use different terminology, that could in itself be confusing, especially to people who might spot the resemblance to FRBR and wonder how (or whether) the two are related.

Great to see these ideas taking shape in a new vocabulary! I think the names are sufficiently broad, and also generic enough to be utilized in non-library contexts. I've also always thought that each term helped convey the level of abstraction, from the concept or idea of a "work" to a tangible "item".

Robin: keep the names; the terminology has a legacy, a culture
heather: start from what people know and show how it is different. an evolution of WEMI

Resolved: keep work, expression, manifestation, and item.


⚠ Bofrost.be has degraded performance

In 565927d, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2119 ms

Resolved: Bofrost.be performance has improved in 11f8d38 after 23 minutes.


Add mpv.net

A modern media player for Windows based on libmpv

Thanks for your contribution, I've renamed the package to mpv-net since we don't use dots in package ids.


Issue #52 Add comment funtionality.

Created a comment icon so that the comments will be visible only when user clicks on the icon.

Hey @kokilgupta, kindly create an issue for the Same, we need that for documentation

I have already created a issue https://github.com/avinashkranjan/Recess/issues/52

There are some conflicts, kindly resolve them. Rest LGTM.


Downloaded article from Google RSS News only return Google Images

For the last few days, the parser using
article.download('https://news.google.com/rss/articles/CBMiTmh0dHBzOi8vd3d3Lm55dGltZXMuY29tLzIwMjQvMDcvMjEvdXMvcG9saXRpY3MvdmFuY2UtdHJ1bXAtY2FtcGFpZ24tcmFsbHkuaHRtbNIBAA?oc=5&hl=en-ID&gl=ID&ceid=ID:en')
article.parse()
print('article.title')
print('article.top_image')

only return Google RSS Images which is
https://lh3.googleusercontent.com/J6_coFbogxhRI9iM864NL_liGXvsQp2AupsKei7z0cNNfDvGUmWUy20nuUhkREQyrpY4bEeIBuc=s0-w300

and the title
Google News

instead of original articles images and titles, any issue on this parser or any update from Google RSS News?

I just tried something with Linkedin newsetters and it doesn't capture anything :/

There was a update from Google's side, the ID after /article/ used to be a base64 string representing the original website.
Since July, that changed and is not real anymore (community doesn't seems to know how to parse it btw)
Here's a reference: https://gist.github.com/huksley/bc3cb046157a99cd9d1517b32f91a99e
There's some community's member implementation of this code in Python -> https://github.com/SSujitX/google-news-url-decoder/blob/main/googlenewsdecoder/new_decoderv1.py
This requests Google for the URL though, so it may hit some 429's (which are very annoying). But i found no other solution but to do that before sending the URL to newspaper3k.


Add aria attributes to interactive time tooltips.

Fixes #23645

Added describedby attribute to the reference element.
Eliminated aria-expanded attribute to the reference element in order to conform strictly with WCAG 2.1 rules.

ping lg-tm


Remove payment processor choice

Forces either Stripe or Paypal, depending on whether the user is in a country with regional pricing. Removes the extra UI for the choice between the two.

Coverage remained the same at 57.382% when pulling b8be1b4237148ceaa786ab344e89c7e4dfe2d1e7 on remove-payment-processor-choice into bca64d15398950ce3dc19c0577dd0763064c1a71 on master.

Coverage remained the same at 57.382% when pulling 31e2e98c564f8fc7264caf1d8b2379e1e789fc1e on remove-payment-processor-choice into bca64d15398950ce3dc19c0577dd0763064c1a71 on master.

Coverage remained the same at 57.382% when pulling 9d505c94f9b8165c113e5fd241646f1591ee9ce7 on remove-payment-processor-choice into bca64d15398950ce3dc19c0577dd0763064c1a71 on master.


logging for cloud-config operations?

RancherOS Version: (ros os version)
v0.7.1
Where are you running RancherOS? (docker-machine, AWS, GCE, baremetal, etc.)
baremetal @ packet.net
I'm having trouble getting rancheros to write files from my cloud config when booting a server on packet.net.
when I run the following cloud config, no files are written and running sudo ros config config export does not show any of the rancher configs set.
if I drop the write_files section in the cloud config the rancher config works.
I'd like to get some logging to find out whats going on but I don't see anything in /var/log where would I find the output of running the cloud-config?
#cloud-config
rancher:
  registry_auths:
    http://my.registry.com:
      auth: some_auth
  docker:
    tls: true
    extra_args: ['--insecure-registry', 'my.registry.com']
write_files:
  - container: console
    path: /home/rancher/.docker/config.json
    permissions: "0755"
    owner: rancher:rancher
    content: |
      { "auths": { "http://my.registry.com": { "auth": "some_auth", "email"<EMAIL_ADDRESS>} } }
  - path: /etc/rc.local
    permissions: "0755"
    owner: root
    content: |
      #!/bin/bash
      wait-for-docker
      docker pull my.registry.com/some/image
      docker run my.registry.com/some/image

I'll try to check that #1415 will help with this

thanks!


Add value checking on PrintType

If the user sets PrintType in config.txt to a garbage string you could easily catch it with an if statement and set it to a default value.

Enhancement tag was added as this is a small addition to prevent user error.

I would rather not do this one. Validating the print type would involve mirroring DoSOCS checks, when I would rather pass it to DoSOCS (as we are) and let it handle the bad types. The reason I would prefer this is because if DoSOCS adds a print type in the future (say, csv), then GitSPDX would have to be updated to remain compatible. If we don't do this enhancement, however, DoSOCS is able to add/remove print types without it affecting this script.


[WIP ]Intrusive shamap inner final

High Level Overview of Change
This PR finalises the work authored by Scott Determan (https://github.com/seelabs) and is based on the original PR (https://github.com/XRPLF/rippled/pull/4815).
Context of Change
There are two goals:

Synchronise this change with the most recent develop branch.
Address outstanding questions raised in the original PR.

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x ] Refactor (non-breaking change that only restructures code)
[ x] Performance (increase or change in throughput and/or latency)
[ ] Tests (you added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation update
[ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
[ ] Release

Intrusive thoughts
On Mon, 30 Sept 2024, 6:45 pm Valentin Balaschenko, <
@.***> wrote:

High Level Overview of Change
This PR finalises the work authored by Scott Determan (
https://github.com/seelabs) and is based on the original PR (#4815
https://github.com/XRPLF/rippled/pull/4815).
Context of Change
There are two goals:

Synchronise this change with the most recent develop branch.
Address outstanding questions raised in the original PR.

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing
functionality to not work as expected)
[x ] Refactor (non-breaking change that only restructures code)
[ x] Performance (increase or change in throughput and/or latency)
Tests (you added tests for code that already exists, or your new
feature included in this PR)
Documentation update
Chore (no impact to binary, e.g. .gitignore, formatting, dropping
support for older tooling)
Release

You can view, comment on, or merge this pull request online at:
https://github.com/XRPLF/rippled/pull/5150
Commit Summary

cd824f3
https://github.com/XRPLF/rippled/pull/5150/commits/cd824f3f7c339f12d733b13b21ec69bae54f27de
Split tagged cache into .h and .ipp files cc
574efd0
https://github.com/XRPLF/rippled/pull/5150/commits/574efd0fa8d83c8d8174563c6fb21fc08b5ae775
[remove] Scripts to measure and plot memory savings
86519c8
https://github.com/XRPLF/rippled/pull/5150/commits/86519c82084ea1651b7616d5cba388760d5e8cdc
Replace SHAMapTreeNodes with intrusive pointers:
d16f27c
https://github.com/XRPLF/rippled/pull/5150/commits/d16f27c1f752b4cdb7f5ddd7014476b85d8144a8
[fold] Replace jthread with thread (mac does not have jthread yet)

File Changes
(58 files https://github.com/XRPLF/rippled/pull/5150/files)

M Builds/CMake/RippledCore.cmake
https://github.com/XRPLF/rippled/pull/5150/files#diff-d78b251ca9d72908464ca6ad92a402f41d90c61ba41a63bb99c0660b57192ba9
(1)
A draft_pr_remove_me/README.md
https://github.com/XRPLF/rippled/pull/5150/files#diff-e48f1be46ed4d5d7abcfbfa73de9bcd141ab801a8e00b0c3e5e901c0a50a732a
(12)
A draft_pr_remove_me/memstats.py
https://github.com/XRPLF/rippled/pull/5150/files#diff-de65dc8a45948a733078eb47449d23a2ac01a4d457466fa1f77bc29864a6cabe
(126)
A draft_pr_remove_me/memstats2
https://github.com/XRPLF/rippled/pull/5150/files#diff-e3f3ac401536eed5ec1b46b88e6fbc6f46fa92878188bef54d5c009e545eb254
(73)
A draft_pr_remove_me/notes.md
https://github.com/XRPLF/rippled/pull/5150/files#diff-a34dc07aa9b57dfc1749d2f71e35fbf88413c68a0a4c51190be1571bc59f08b2
(12)
A draft_pr_remove_me/nov_5/data.raw
https://github.com/XRPLF/rippled/pull/5150/files#diff-39fe2e722621bd97606d67412fc9f9263fde17e4da31a0ab5344f6525762e96b
(2639)
A draft_pr_remove_me/nov_5/mem_diff_intrusive_ptr.png
https://github.com/XRPLF/rippled/pull/5150/files#diff-8b835a6c37fbe8ec892ad08485b90b1acfb0ba3e97413f2337846dcdbef8750b
(0)
A draft_pr_remove_me/nov_5/mem_percent_change.png
https://github.com/XRPLF/rippled/pull/5150/files#diff-afe92892a9087d8bfe62b862849378bc5c6f31069f0841cda4429bd064858ebd
(0)
A draft_pr_remove_me/nov_5/mem_usage_intrusive_ptr.png
https://github.com/XRPLF/rippled/pull/5150/files#diff-6075f201fe6abd3412697a6f6de18883b86ccf0e37c72beffdb35ec876a345a6
(0)
A draft_pr_remove_me/oct_25/mem_diff_intrusive_ptr.png
https://github.com/XRPLF/rippled/pull/5150/files#diff-88deb78448f2515f82808751e97b684bb3eef045d742302bd4358a57ee53a9cd
(0)
A draft_pr_remove_me/oct_25/mem_percent_change.png
https://github.com/XRPLF/rippled/pull/5150/files#diff-30bc7ca0622d9cc36a7beb81d3df687594fed93e5f84419efbe6e3400ef8c2aa
(0)
A draft_pr_remove_me/oct_25/mem_usage_intrusive_ptr.png
https://github.com/XRPLF/rippled/pull/5150/files#diff-a6626ff754984e965a689339e3f9fb5d3e687553864ba6981665102c862d7e09
(0)
A draft_pr_remove_me/oct_30/mem_diff_intrusive_ptr.png
https://github.com/XRPLF/rippled/pull/5150/files#diff-8a2de95f1ed31c59f91a6d7654e05609ec4669df1f39bf32c2fb549d3d001b95
(0)
A draft_pr_remove_me/oct_30/mem_percent_change.png
https://github.com/XRPLF/rippled/pull/5150/files#diff-dbe63c654d1e4fb4f44fcb0ccdd92e15b5804cf4d2d97304bd785aba256f6a16
(0)
A draft_pr_remove_me/oct_30/mem_usage_intrusive_ptr.png
https://github.com/XRPLF/rippled/pull/5150/files#diff-6ae35c09b23685ab28a500bea948572d12bfbe445db556b1557b8b0f1bf62fa4
(0)
M src/ripple/app/ledger/ConsensusTransSetSF.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-64c678da7ec8260b1f0010c0dcbbad099090e2c6f347c31f52323366aef6a497
(2)
M src/ripple/app/ledger/Ledger.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-641b34dd979168653c7a93b3e9ec84d9098dbfcce8d3badc0c7a6917c8d60817
(2)
M src/ripple/app/ledger/LedgerHistory.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-578404dfc869642d93cb4af585818d4e0cd47dc49589a52902e44c184caeab42
(2)
M src/ripple/app/ledger/impl/LedgerMaster.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-b6da8515364c9f4d6662db4caeebbaab01cefced2d87831529519b120eb0dda1
(5)
M src/ripple/app/ledger/impl/TransactionMaster.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-c903b181b92014b8dc15d841adb7901b5f5812b05a622b0354e065b9f4550ef8
(2)
M src/ripple/app/main/Application.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-0f8ea7c80a9fc793b9276fec0c494b6f95fc87b7b9602e8f30175a7b79c87af1
(4)
M src/ripple/app/main/Application.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-1aee4c2818b00460bce8b92f1a1e452a57b158939c45e1409e359fe1a49fa08c
(2)
M src/ripple/app/misc/NetworkOPs.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-86ea7ba43fce0b564af71cb3f2070ce71cb27d9ec9b9fd93ab5298960a3b36db
(4)
M src/ripple/app/misc/SHAMapStoreImp.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-fa0225ae5b5400c97cd68d88df3c3895731f66658286a02fc443f1454ab50586
(1)
M src/ripple/app/misc/SHAMapStoreImp.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-c4e6f8a489572866b265a35f5e7592bf85c76bedb454508d5456c55f377ccaa7
(1)
M src/ripple/app/rdb/backend/detail/impl/Node.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-fe255a501796a5e217d7662f844e131a61874f7c25434d517ff883eb317250e8
(4)
A src/ripple/basics/IntrusivePointer.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-17fc43f93c624a54202f387869d905b7ab1303795796d5e1fc8df03c71681eba
(494)
A src/ripple/basics/IntrusivePointer.ipp
https://github.com/XRPLF/rippled/pull/5150/files#diff-ddb773bf94badf84ad8c1395ee9f8bbefe92f68804da2a6fdb7e0304c701e64a
(720)
A src/ripple/basics/IntrusiveRefCounts.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-cd29fa1e9f7e8dfc07c4e49ee4fd6ce13104c26e6b734f955e4dbcb6780979c1
(466)
A src/ripple/basics/SharedWeakCachePointer.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-56243364bc665018438492f4db4c554fc091994ddb8fa678439bfba24bc72c45
(132)
A src/ripple/basics/SharedWeakCachePointer.ipp
https://github.com/XRPLF/rippled/pull/5150/files#diff-337454fd6acdcd8d3c7478c946de1069b62a7fecb56edc427eb3be45805cf45b
(190)
M src/ripple/basics/TaggedCache.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-70198bb2a24457cb7f20a00cff26af162fb206fa90bea96925a6ee9058b1fce5
(552)
A src/ripple/basics/TaggedCache.ipp
https://github.com/XRPLF/rippled/pull/5150/files#diff-e41044ea3f0f6449729e835c53f943707fc4521441db31aec76027fbc4d60bf0
(1118)
M src/ripple/ledger/impl/CachedView.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-c15921a794ad932791435980531923d183977d13ad537b9d4cc47e0dcbf2c70b
(4)
M src/ripple/nodestore/impl/DatabaseNodeImp.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-28f5330080429bff59c230717e0ae1f678adfad526e860d8ebcc56f85aaaba16
(4)
M src/ripple/nodestore/impl/Shard.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-278e50d2ad732d6dad8c334a825ec450487024ec9cf16ea0598fcb50f6419027
(4)
M src/ripple/rpc/handlers/GetCounts.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-0cf6a864bf247cd3592583311a6d3ba5dff4eb64bc7305d5a161d392f24980e4
(1)
M src/ripple/shamap/FullBelowCache.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-e844afd0edc01de56cf60c096e1347954c88dd5242c4c8e642fab50b035179e5
(1)
M src/ripple/shamap/SHAMap.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-f5ce0c73e50633b4a2d1a0c8d3ef3e0a1b5f4e99b23b8d40f74bd91cc4ec6e87
(69)
M src/ripple/shamap/SHAMapAccountStateLeafNode.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-0e1b9d15d6f000e163140e9e71be2fd4154e840707a4dde038e601f109eef37a
(4)
M src/ripple/shamap/SHAMapInnerNode.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-25b95956faf4fb3a99d2e6e179e517cd496e54cc436ce1b07ce379ad49f7fb9a
(26)
M src/ripple/shamap/SHAMapTreeNode.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-9ea2042f96f4c702c201f2f15583013ce34993a59fe8b9804f937c17a377cd01
(36)
M src/ripple/shamap/SHAMapTxLeafNode.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-f860416aa1f32ca822f30979db414f5cfea25fc51dfb17b6f3c42b083556079c
(4)
M src/ripple/shamap/SHAMapTxPlusMetaLeafNode.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-aba9d6b457ab67ebbbd021ba6f9ef152d1fa61201d01d73e09407a270ae9709d
(5)
M src/ripple/shamap/TreeNodeCache.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-f4feb24af918b07867d7b8fa7def6d3485d256029e67c90731535e8c5125081c
(9)
M src/ripple/shamap/impl/NodeFamily.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-ab4f4cf8475c183a7080da17d8acbbe882f50c5d01848e75ad72259e4906c213
(5)
M src/ripple/shamap/impl/SHAMap.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-2133457c3b122432a0fc910e3e92479016e48915ba1760e61bd0e0b8bfe34c99
(158)
M src/ripple/shamap/impl/SHAMapDelta.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-11259a9baf6ee929550096fa5c416def111cd45cc8ed0edd322c0ded025517d8
(34)
M src/ripple/shamap/impl/SHAMapInnerNode.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-3c5a1d9e3e0fdb1bdfe1390359169673cccb15076fd33a70d432e572cebc5758
(63)
M src/ripple/shamap/impl/SHAMapLeafNode.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-6ffd1cc3f5583ddf84f7382fa8af27f3a8723500c38d212e8192572df5c499b0
(1)
M src/ripple/shamap/impl/SHAMapSync.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-0c6076ee71943ae3100e4732d58afbf47be121d0d7747ddc0780b7f0cc7c6ebc
(26)
M src/ripple/shamap/impl/SHAMapTreeNode.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-12912aca4ee2d7bad3035f9245f7319caeef6dc0cb8791ac5505e1788c82aaa8
(26)
M src/ripple/shamap/impl/ShardFamily.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-cb018c5f6f83fc536c593dbd7e408c9a16ee34b7a89212e5f57805097e654f61
(2)
M src/ripple/shamap/impl/TaggedPointer.h
https://github.com/XRPLF/rippled/pull/5150/files#diff-defde44445791211494a6cc0b01bc1665cc9aadcade461226bb9ee1266e9c72a
(6)
M src/ripple/shamap/impl/TaggedPointer.ipp
https://github.com/XRPLF/rippled/pull/5150/files#diff-1754d5f522499c7d798358712128aa85433a378c3857d8680d1bb8b57143831e
(40)
A src/test/basics/IntrusiveShared_test.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-2ff622184615fab0f10d2de86dc678f0d47543a2e7ceee51bf63b1eca484d28f
(787)
M src/test/basics/KeyCache_test.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-2345b528bb132c9d7f7ff0e4cb87e1765cd9216c01f1b55d27f3811109c59fd1
(1)
M src/test/basics/TaggedCache_test.cpp
https://github.com/XRPLF/rippled/pull/5150/files#diff-d2058b828272edd56436e62a7e9bcd6ad152bf01a2a61dac8fe424341c5d5174
(1)

Patch Links:

https://github.com/XRPLF/rippled/pull/5150.patch
https://github.com/XRPLF/rippled/pull/5150.diff

—
Reply to this email directly, view it on GitHub
https://github.com/XRPLF/rippled/pull/5150, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEAHGZYLZXGXEGOR7OLUGLZZE2WJAVCNFSM6AAAAABPDDCVFSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2TMNBQGU4DCOA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


fix(Invoke): Fixed Windows Issue by shipping pre-built binaries for platforms

This PR moves away from the logic we used until now: spawning a container and invoking the cli within the container. Now we ship all the binaries with the extension itself and invoke the correct ones based on the host OS/architecture. This is made to circumvent an issue we currently have on Windows machines where the path for the LOCALSTACK_VOLUME_DIR env variable was being mixed with Windows and Unix pathing.
/cc @alexrashed
Closes #52

king in the CLI binaries to this repo - they are fairly large, and it would be preferable to not have

The problem with downloading them is that you cannot execute them on the host: the docker desktop sdk provides a way to execute script/binaries on the host but they have to be explicitly shipped with it. If we try to download them we would end up in the same problem as before, even if out in a volume. Plus I've looked at other extensions and could find some over 150MB so I don't think is much of an issue.
Let me know your thoughts @whummer

Could we download them from the Github releases page
Yes, I've added a little script that download and extract them when you build the extension :+1:


home-assistant-custom-components.solax_modbus: 2024.09.5 -> 2024.10.3

https://github.com/wills106/homeassistant-solax-modbus/releases/tag/2024.10.3
https://github.com/wills106/homeassistant-solax-modbus/releases/tag/2024.10.2
https://github.com/wills106/homeassistant-solax-modbus/releases/tag/2024.10.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Updated to the latest version, which was just released.


Feat: Styling improvement in 404 not found page

What feature?
Styling improvement in 404 not found page
add some gif or animated images
Add screenshots

Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

Hi @RamakrushnaBiswal we can add the gifs but make sure to add the which is responsive and optimized, assigning it to you

@Sanchitbajaj02 yes I can do this

can u please let me work on this issue? Please assign it to me

can u please let me work on this issue? Please assign it to me

Hi @Monalisha-Roy, the issue is already asked by @RamakrushnaBiswal. Please look iinto other issues or you can help assisting


Add support for ST7789

#109 Rebased over current master.
fixes #104

Glad you like it (-:
Let me implement review remarks.

OK, significant speedup is in progress (-:

examples/perfloop.py on Pi Zero has ~10.5fps with this version.

examples/perfloop.py on Pi Zero has ~10.5fps with this version.

And before?

<1fps

Love this!
Is it possible to install this with  pip ?
sudo python3 -m pip install --upgrade luma.lcd   seem to install the 2020 December release.

I think there has been no release yet, it should land in 2.9.0

Hm, can't find a release schedule...
Looks like I have to clone and install it..

release schedule is in CHANGES.md. It'll be released within a few days I expect.

no problem , I installed it locally.   Excited to test it out.  Been having this waveshare shield for some time and no easy way to use it.

I developed on waveshare shield to, let me share some commands...

Running examples from luma.examples:
python3 examples/bounce.py -i spi -d st7789 --gpio-reset 27 --gpio-data-command 25 --gpio-backlight 24  --backlight-active high --spi-bus-speed 52000000
Python:
from PIL import Image
import luma.core.interface.serial
import luma.lcd.device
image = Image.open("/home/pi/logo.png").resize((240,240))
serial = luma.core.interface.serial.spi(gpio_DC=25, gpio_RST=27, bus_speed_hz=52000000)
device = luma.lcd.device.st7789(serial, gpio_LIGHT=24, active_low=False)
device.display(image)

@matemaciek can you add that config to luma.examples/config/ ?

Sure! Also just testing on pi 4, ~21.5fps \o/

odd..   is there a discord where we can chat?  I don't want to pollute this closed issue..
pi@raspberrypi:~/luma.lcd $  python3 setup.py build
pi@raspberrypi:~/luma.lcd $  sudo python3 setup.py install
....

pi@raspberrypi:~/luma.lcd $  python3
Python 3.7.3 (default, Jul 25 2020, 13:03:44)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import luma.lcd
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'luma.lcd'
>>>

I install with sudo python3 setup.py develop

@thijstriemstra im trying to upload to pypi, but fails .. any ideas:
$ python3 setup.py clean sdist bdist_wheel upload -r pypi
running clean
running sdist
running egg_info
writing luma.lcd.egg-info/PKG-INFO
writing dependency_links to luma.lcd.egg-info/dependency_links.txt
writing namespace_packages to luma.lcd.egg-info/namespace_packages.txt
writing requirements to luma.lcd.egg-info/requires.txt
writing top-level names to luma.lcd.egg-info/top_level.txt
reading manifest file 'luma.lcd.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
no previously-included directories found matching 'doc/_build'
warning: no previously-included files matching '__pycache__' found under directory '*'
warning: no previously-included files matching '*.py[co]' found under directory '*'
warning: no previously-included files matching '*~' found under directory '*'
warning: no previously-included files matching '.coverage' found under directory '*'
warning: no previously-included files matching '.DS_Store' found under directory '*'
warning: no previously-included files matching '.ropeproject' found under directory '*'
writing manifest file 'luma.lcd.egg-info/SOURCES.txt'
running check
creating luma.lcd-2.9.0
creating luma.lcd-2.9.0/doc
creating luma.lcd-2.9.0/doc/fritzing
creating luma.lcd-2.9.0/doc/images
creating luma.lcd-2.9.0/doc/old
creating luma.lcd-2.9.0/doc/tech-spec
creating luma.lcd-2.9.0/luma
creating luma.lcd-2.9.0/luma.lcd.egg-info
creating luma.lcd-2.9.0/luma/lcd
copying files to luma.lcd-2.9.0...
copying .coveragerc -> luma.lcd-2.9.0
copying CHANGES.rst -> luma.lcd-2.9.0
copying CONTRIBUTING.rst -> luma.lcd-2.9.0
copying LICENSE.rst -> luma.lcd-2.9.0
copying MANIFEST.in -> luma.lcd-2.9.0
copying README.rst -> luma.lcd-2.9.0
copying pyproject.toml -> luma.lcd-2.9.0
copying pytest.ini -> luma.lcd-2.9.0
copying setup.cfg -> luma.lcd-2.9.0
copying setup.py -> luma.lcd-2.9.0
copying tox.ini -> luma.lcd-2.9.0
copying doc/HD44780.rst -> luma.lcd-2.9.0/doc
copying doc/Makefile -> luma.lcd-2.9.0/doc
copying doc/api-documentation.rst -> luma.lcd-2.9.0/doc
copying doc/conf.py -> luma.lcd-2.9.0/doc
copying doc/hardware.rst -> luma.lcd-2.9.0/doc
copying doc/index.rst -> luma.lcd-2.9.0/doc
copying doc/install.rst -> luma.lcd-2.9.0/doc
copying doc/intro.rst -> luma.lcd-2.9.0/doc
copying doc/python-usage.rst -> luma.lcd-2.9.0/doc
copying doc/references.rst -> luma.lcd-2.9.0/doc
copying doc/software.rst -> luma.lcd-2.9.0/doc
copying doc/fritzing/PCD8544 LCD.fzpz -> luma.lcd-2.9.0/doc/fritzing
copying doc/fritzing/RPi GPIO Header.fzpz -> luma.lcd-2.9.0/doc/fritzing
copying doc/fritzing/schematic.fzz -> luma.lcd-2.9.0/doc/fritzing
copying doc/images/IMG_2539.JPG -> luma.lcd-2.9.0/doc/images
copying doc/images/IMG_2540.JPG -> luma.lcd-2.9.0/doc/images
copying doc/images/IMG_2541.JPG -> luma.lcd-2.9.0/doc/images
copying doc/images/IMG_2544.JPG -> luma.lcd-2.9.0/doc/images
copying doc/images/IMG_2774.JPG -> luma.lcd-2.9.0/doc/images
copying doc/images/RPi_P5_header.png -> luma.lcd-2.9.0/doc/images
copying doc/images/clock_anim.gif -> luma.lcd-2.9.0/doc/images
copying doc/images/crawl_anim.gif -> luma.lcd-2.9.0/doc/images
copying doc/images/hd44780_20x4.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/hd44780_clock.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/hd44780_progress.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/ht1621.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/ili9341.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/invaders_anim.gif -> luma.lcd-2.9.0/doc/images
copying doc/images/pcd8544.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/pcd8544.png -> luma.lcd-2.9.0/doc/images
copying doc/images/pcd8544.svg -> luma.lcd-2.9.0/doc/images
copying doc/images/pcd8544_schematic_bb.png -> luma.lcd-2.9.0/doc/images
copying doc/images/serial_config.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/st7567.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/st7735.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/st7735_pin_outs.jpg -> luma.lcd-2.9.0/doc/images
copying doc/images/st7735_schematic_bb.png -> luma.lcd-2.9.0/doc/images
copying doc/images/uc1701x.png -> luma.lcd-2.9.0/doc/images
copying doc/images/wiring-diagram.png -> luma.lcd-2.9.0/doc/images
copying doc/images/wiring-diagram.svg -> luma.lcd-2.9.0/doc/images
copying doc/old/veroboard-schematic.diy -> luma.lcd-2.9.0/doc/old
copying doc/tech-spec/HD44780.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/HT1621.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/ILI9341.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/PCD8544.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/ST7735.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/ST7789.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/ST7920.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying doc/tech-spec/UC1701X.pdf -> luma.lcd-2.9.0/doc/tech-spec
copying luma/__init__.py -> luma.lcd-2.9.0/luma
copying luma.lcd.egg-info/PKG-INFO -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma.lcd.egg-info/SOURCES.txt -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma.lcd.egg-info/dependency_links.txt -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma.lcd.egg-info/namespace_packages.txt -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma.lcd.egg-info/not-zip-safe -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma.lcd.egg-info/requires.txt -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma.lcd.egg-info/top_level.txt -> luma.lcd-2.9.0/luma.lcd.egg-info
copying luma/lcd/__init__.py -> luma.lcd-2.9.0/luma/lcd
copying luma/lcd/const.py -> luma.lcd-2.9.0/luma/lcd
copying luma/lcd/device.py -> luma.lcd-2.9.0/luma/lcd
copying luma/lcd/segment_mapper.py -> luma.lcd-2.9.0/luma/lcd
Writing luma.lcd-2.9.0/setup.cfg
Creating tar archive
removing 'luma.lcd-2.9.0' (and everything under it)
running bdist_wheel
running build
running build_py
installing to build/bdist.macosx-11-arm64/wheel
running install
running install_lib
Skipping installation of build/bdist.macosx-11-arm64/wheel/luma/__init__.py (namespace package)
copying luma/lcd/device.py -> build/bdist.macosx-11-arm64/wheel/luma/lcd
copying luma/lcd/__init__.py -> build/bdist.macosx-11-arm64/wheel/luma/lcd
copying luma/lcd/segment_mapper.py -> build/bdist.macosx-11-arm64/wheel/luma/lcd
copying luma/lcd/const.py -> build/bdist.macosx-11-arm64/wheel/luma/lcd
running install_egg_info
Copying luma.lcd.egg-info to build/bdist.macosx-11-arm64/wheel/luma.lcd-2.9.0-py3.9.egg-info
Installing build/bdist.macosx-11-arm64/wheel/luma.lcd-2.9.0-py3.9-nspkg.pth
running install_scripts
adding license file "LICENSE.rst" (matched pattern "LICEN[CS]E*")
creating build/bdist.macosx-11-arm64/wheel/luma.lcd-2.9.0.dist-info/WHEEL
creating 'dist/luma.lcd-2.9.0-py2.py3-none-any.whl' and adding 'build/bdist.macosx-11-arm64/wheel' to it
adding 'luma.lcd-2.9.0-py3.9-nspkg.pth'
adding 'luma/lcd/__init__.py'
adding 'luma/lcd/const.py'
adding 'luma/lcd/device.py'
adding 'luma/lcd/segment_mapper.py'
adding 'luma.lcd-2.9.0.dist-info/LICENSE.rst'
adding 'luma.lcd-2.9.0.dist-info/METADATA'
adding 'luma.lcd-2.9.0.dist-info/WHEEL'
adding 'luma.lcd-2.9.0.dist-info/namespace_packages.txt'
adding 'luma.lcd-2.9.0.dist-info/top_level.txt'
adding 'luma.lcd-2.9.0.dist-info/RECORD'
removing build/bdist.macosx-11-arm64/wheel
running upload
Submitting dist/luma.lcd-2.9.0.tar.gz to https://upload.pypi.org/legacy/
Upload failed (400): Invalid value for blake2_256_digest. Error: Use a valid, hex-encoded, BLAKE2 message digest.
error: Upload failed (400): Invalid value for blake2_256_digest. Error: Use a valid, hex-encoded, BLAKE2 message digest.

@matemaciek   the develop install worked!!!!    Yesssss!!!

@rm-hull upgrade wheel and setuptools to latest and try again?

also looks like its trying to build for arm:
build/bdist.macosx-11-arm64/wheel

would be better to publish using pypi only to prevent these issues @rm-hull

also looks like its trying to build for arm:
build/bdist.macosx-11-arm64/wheel

ah yes ... that will be my shiny new macbook

Publishes ok on linux...
https://pypi.org/project/luma.lcd/2.9.0/ released


Can't find IsBatched

I have included Microsoft.Azure.WebJobs.Extensions.ServiceBus 5.5.1 in my azure functions project (.net 6.0) but I can't find IsBatched property for ServiceBusTrigger attribute

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d50399c-0873-e903-35ca-1845c84b6c6c
Version Independent ID: 1a3150b4-5eb9-0ac5-ee2b-d1bb6b6fd63e
Content: Azure Service Bus trigger for Azure Functions
Content Source: articles/azure-functions/functions-bindings-service-bus-trigger.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@sadiqkhoja
Thanks for your feedback! We will investigate and update as appropriate.

@sadiqkhoja , I will change the documentation as Isbatched property is not present for Isolated process. It will be reflected soon. Thanks for the feedback. I will close this issue for now. Feel free to reopen if you have any further questions

Here's the in-process extension source code: https://github.com/Azure/azure-functions-dotnet-worker/blob/main/extensions/Worker.Extensions.ServiceBus/src/ServiceBusTriggerAttribute.cs#L76


Add replica re-assignment e2e test.

This test causes a replica node to be faulted by IO packet rejection, and then waits for the control plane
to provision a new replica. The test requires 4 mayastor nodes.

bors merge

bors merge


Config client (eureka client) not able to discover itself in a zone when using discovery first bootstrap with retry policy

This is about spring config client.
I have three things running on my system.

Discovery
Spring Config Server
Spring Config Client/ Eureka Client

APPROACH: DISCOVERY FIRST BOOTSTRAP + RETRY
DOCUMENTATION CITED:
https://cloud.spring.io/spring-cloud-config/multi/multi__spring_cloud_config_client.html
Before: I was able to register spring config server and client on discovery and the client was able to get the properties well from the config server. The order is discovery first and then the config server and finally the client. using discovery first bootstrap and retry.
Problem : It is fine and no problem and the client is able to register itself in zoneXYZ.
Verified: org.springframework.cloud.client.discovery.DiscoveryClient#getServices and able to see the client as a service
After I change: I have introduced the retry functionality so that if in case the client gets started first and then the config server, the client will keep on retrying until it finds the config service and once it finds it , it fetches the properties.
Problem : Once the config client is waiting for the config server and after sometimes it gets the config service and registers itself in eureka, the client is visible on eureka dashboard but is not being able to register it self in zoneXYZ.
Verified: org.springframework.cloud.client.discovery.DiscoveryClient#getServices and NOT able to see the client as a service
END OF STEP 1
WORKS WHEN : The client is restarted
Verified: org.springframework.cloud.client.discovery.DiscoveryClient#getServices shows the client as a service`
END OF STEP 2
CONFIGURATIONS AS FOLLOWS:
CONFIG CLIENT (bootstrap.properties)
spring.application.name=my-application
server.port=8443

spring.profiles.active=local
spring.cloud.config.label=latest

management.endpoints.web.exposure.include=*

#Spring cloud configuration via Eureka Discovery
spring.cloud.config.discovery.enabled=true
spring.cloud.config.discovery.service-id=my-config-service

#Logging related
logging.level.org.springframework.cloud.bus=DEBUG
logging.level.org.springframework.retry=TRACE
logging.level.com.netflix.discovery=DEBUG

spring.cloud.config.fail-fast=true
#including retry maxInterval etc

#Eureka
register.with.eureka=true
eureka.client.instance.preferIpAddress = true
eureka.instance.leaseRenewalIntervalInSeconds=10
eureka.instance.leaseExpirationDurationInSeconds=15
eureka.instance.appname=${spring.application.name}
eureka.instance.hostname=${HOST:localhost}
eureka.instance.nonSecurePort=:${server.port}
eureka.instance.instance-id=${spring.application.name}:${server.port}
eureka.instance.ipAddress=${HOST:localhost}
eureka.instance.home-page-url=${HOST:${eureka.instance.hostname}}:${${server.port}}/${spring.application.name}
 eureka.client.preferSameZoneEureka=true
eureka.client.region=region-1
eureka.client.availabilityZones.region-1=zoneXYZ --> APP REGISTERED here without RETRY
eureka.instance.metadataMap.zone=zoneXYZ

CONFIG SERVICE(application properties)
spring.application.name=my-config-service
server.port=8888
spring.cloud.config.server.prefix=/config

#Spring Config Server
spring.cloud.config.server.jdbc.sql= SELECT KEY, VALUE from MY_CONFIG_PROPERTIES where APPLICATION=? and PROFILE=? and LABEL=?
spring.profiles.active=local, jdbc
spring.cloud.config.server.bootstrap=true

#Logging
logging.level.org.springframework.jdbc.core.JdbcTemplate=DEBUG
logging.level.org.springframework.jdbc.core.StatementCreatorUtils=TRACE
management.security.enabled=false
management.endpoint.health.show-details=always

#Spring Cloud Bus
management.endpoints.web.exposure.include=*
spring.cloud.bus.enabled=true
spring.cloud.bus.trace.enabled=true

#Discovery specific
register.with.eureka=true
eureka.client.instance.preferIpAddress = true
eureka.instance.leaseRenewalIntervalInSeconds=10
eureka.instance.leaseExpirationDurationInSeconds=15
eureka.instance.appname=${spring.application.name}
eureka.instance.hostname=${HOST:localhost}
eureka.instance.nonSecurePort=${server.port}
eureka.instance.instance-id=${spring.application.name}:${server.port}}
eureka.instance.ipAddress=${localhost}
eureka.instance.home-page-url=${HOST:${eureka.instance.hostname}}:${${server.port}}/${spring.application.name}
eureka.client.prefer-same-zone-eureka=true
eureka.client.region=region-1
eureka.client.availability-zones.region-1=zoneXYZ
eureka.instance.metadataMap.zone=zoneXYZ
eureka.client.prefer-same-zone-eureka=true
eureka.client.region=region-1
eureka.client.availability-zones.region-1=zoneXYZ
eureka.instance.metadataMap.zone=zoneXYZ

I'm afraid I don't understand the following statement.

the client is visible on eureka dashboard but is not being able to register it self in zoneXYZ.

DiscoveryClient#getServices Is not able to find the client or any micro service when that particular service is visible on eureka dashboard

DiscoveryClient#getServices Is not able to find the client or any micro service when that particular service is visible on eureka dashboard

I'm afraid I don't understand the following statement.

the client is visible on eureka dashboard but is not being able to register it self in zoneXYZ.

Actually DiscoveryClient#getServices Is not able to find the client or any micro service when that particular service is visible on eureka dashboard

Please provide a minimal, complete, verifiable example that reproduces the issue.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


cpu100

Issue Type: Bug
开启PHP IntelliSense扩展之后，通过top命令看到有个进程占用cpu100%

Extension version: 2.3.1
VS Code version: Code 1.23.1 (d0182c3417d225529c6d5ad24b7572815d0de9ac, 2018-05-10T16:03:31.083Z)
OS version: Darwin x64 17.3.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (7.83GB free)

Process Argv
/private/var/folders/px/n53xlzts2f18fr3_cp9422540000gn/T/AppTranslocation/12300724-5DE9-49CB-B105-98A137481BFD/d/Visual Studio Code.app/Contents/MacOS/Electron

Screen Reader
no

VM
0%

Is the language server still indexing? It's expected to use your CPU to do that

how to close this? my pc is so hot.

I get same problem on big project while small projects are ok.
What information do you want me to provide to help to fix the problem?

Thinks! i want to close this "langurage server" process and The IntelliSense still is used.Because it is so good to use.

5mins later，this process is closed


New site for "Built With" Page: http://www.ezgetone.com

How to fix Blocked Resources https://www.ezgetone.com > /cart.js
Rendering without this resource might impair the indexing of your web pages. Learn more.

@ezgetone I'm confused - is this a bug request for this JS library, or are you requesting that your site be added to our "Built With" page?


fix dep for jwt

Pull Request Template
Description
fix requirements.txt
Fixes https://github.com/OpenMined/PyGrid/issues/552
Type of change
Please mark options that are relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
bug no longer occures
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[x] I did follow the contribution guidelines
[ ] New Unit tests added
[ ] Unit tests pass locally with my changes

@IonesioJunior hey bauss... there seems to be some test failures that are not exactly related to this tiny change...
let me know if I can merge? or you can directly merge yourself if you also agree...
if you think this change is responsible plz ping me and I can try to sort that out.


Add Message Passing Neural Network (MPNN)

Proposed changes
This PR proposes a draft for the MPNN architecture, used as a basic block to build almost any GNNs using message passing paradigm. This abstract architecture is also used in PyTorch Geometric and DGL.
This is a draft, tests will come very soon.
For anyone willing to contribute to other GNN-based stuff, please tell it here!
Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING document
[x] I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have updated the necessary documentation (if needed)

As mentioned here by @gboduljak, an important question we may ask before diving into the implementation of various GNN implementations is:
Should we create a separate library specifically made for this purpose, or should we integrate these graph-related features directly within MLX?
I personally think that integrating everything within MLX (graphs + other specific fields) could lead to a very heavy MLX library, with plenty of specific features used by only a few people. What's nice with MLX is also its lightweight structure and understandable code. Adding too many features may impact the cool experience of the framework. On the other hand, I agree with @francescofarina that GNN libraries like PyG can quickly become hard to install and to maintain because of the many dependencies and varying versions.
We're lucky to be at the early stage of MLX to make this kind of decisions, which will shape its future direction! Any ideas @awni @angeloskath ?

I would like to add that an efficient MPNN layer implementation also depends on scatter_{op} and sparse linear algebra support.  In addition, popular graph attention layers such as GAT and GATv2 depend on  scatter_softmax, which can be either fused or implemented using scatter_add and scatter_mul/div.  Given the issues with scatter vjp implementation (https://github.com/ml-explore/mlx/pull/394), we might want to wait to first implement scatter operations.

I would like to contribute to implementation of MPNN layers, graph normalization layers, and graph utilities, such as graph (mini) batching.

Yes, implementing all scatter_* operations will be one of the main things to achieve. I plan to be working on that too.

Thanks for the contribution! This looks really nice so far. I'm thinking about the best way to incorporate it with MLX. At this stage my thought is it belongs better in either one of two places:

mlx-examples
A higher level mlx-gnn package which depends on mlx

My experience with these higher level models is they often work really well as a simple and hackable example which can be used as a starting point for people doing graph NNs and likely want customize it one way or another.
A higher level package could also work well but there one has to know more the users and usage patterns (which I do not really for this). Is there a reference package we could look at to base the API / usage on?
What do you think between those two options?

On the other hand, I agree with @francescofarina that GNN libraries like PyG can quickly become hard to install and to maintain because of the many dependencies and varying versions.

Can you say more about that @federicobucchi? It seems like maintaining a dependency on mlx should not be that bad?

I think that the mlx-examples option is a no go, as this PR goes beyond just releasing a new model. The MPNN is one of the fundamental basic blocks that will be used by many other features related to GNNs. We thus want to build an entire ecosystem that people would easily build on top of it, not just an example.
@awni I really encourage you to take a look at the torch geometric lib, as it contains all the features we want to implement also in MLX, and it has a nice API also built on top of MPNN. Basically, it's written in plain Python, with some parts of fast implementations written in cpp in different modules, like torch_sparse, torch_scatter. All these modules are hosted by its founder, Matthias Fey, and are not included by default in PyTorch. To use torch_geometric properly, it's thus necessary to import these modules, all with torch. This is why there are so many dependencies to rely on.
As you don't consider the option "integrate these features directly within MLX", it seems that it would be preferable to create a new dedicated module like for torch_geometric and other GNN libs. I'm not sure that using separate modules for every types of low-level operations is a good option though. I would say that we can integrate all these operations directly within the same mlx_graphs or mlx_geometric lib.
GNNs are a rapidly evolving field with a large community, I'm sure we'll find many contributors with some proper communication about this new lib. I'm willing to fully engage into it!

Just to add on the comment I made here https://github.com/ml-explore/mlx/pull/380#issuecomment-1879761512 .
It seems we're going down the road of implementing scatter and sparse ops in the mlx core, so maintaining an external library specific for GNNs shouldn't be too much of an extra burden. The open question I still have is whether it would make sense to have some basic GNN blocks as part of the mlx core and delegate more specific/high-level GNN architectures to an external library (and even mlx-examples could make sense at that point IMO).

It would probably be much easier for maintenance to have all GNN-related code within the separate mlx-graphs lib (MPNN, GraphNet, etc), and the basic operations (scattering, sparse operations) remain in mlx.core as they may be used in non-GNN scenarios.

It would probably be much easier for maintenance to have all GNN-related code within the separate mlx-graphs lib (MPNN, GraphNet, etc), and the basic operations (scattering, sparse operations) remain in mlx.core as they may be used in non-GNN scenarios.

I also think this is the best idea.

It would probably be much easier for maintenance to have all GNN-related code within the separate mlx-graphs lib

The fastest path to get this going is an external repo (outside ml-explore that is). If you all are interested in making one I think that is great and we will gladly support the features / encourage contributions in core needed to make it work.
If you're interested in it, we can look into including it as a repo in the ml-explore org but that will take a little more time to set up.
Any thoughts there? @TristanBilot @gboduljak @francescofarina ?
@francescofarina to address your question:

is whether it would make sense to have some basic GNN blocks as part of the mlx core

I assume the message passing base class is what you are referring to? Are there others you were thinking of?
Potentially the answer will be on a case-by-case basis, but I would also suggest we cross that bridge at a future time. No need to close the door now on including it but also no need to do it yet either. Having these in mlx-graphs could be a good way to refine the API a bit before merging them back.

@awni, I think this is a wonderful idea! And it is IMO the most logical and straightforward way to do.
I personally can allocate a lot of time on this project during my PhD so it will be a real pleasure contributing to this mlx-graphs package.
Although creating the new repo may take time, we can still think about the new API and core functions to develop beforehand.

So you suggest starting the development of the package locally in our repo, and then merge it within ml-explore later?

The fastest path to get this going is an external repo (outside ml-explore that is). If you all are interested in making one I think that is great and we will gladly support the features / encourage contributions in core needed to make it work.
If you're interested in it, we can look into including it as a repo in the ml-explore org but that will take a little more time to set up.

@awni no preference there, but I believe whether to start it inside or outside the ml-explore org may also be a question for you? I'm happy to allocate time and contribute in both cases.

I assume the message passing base class is what you are referring to? Are there others you were thinking of?

@awni yes I was thinking of the MPNN and the generic block I was working in https://github.com/ml-explore/mlx/pull/380. But as you suggest I think it probably makes sense to cross that bridge later in time.

I also will be able to allocate a lot of time on the project during my PhD and will be collaborating tightly with @TristanBilot :).

I'm considering to create a chat group to ease quick communication between us, @francescofarina @gboduljak do you use X?

@TristanBilot sure, handler in my profile.

I'm considering to create a chat group to ease quick communication between us, @francescofarina @gboduljak do you use X?

I do not use X :(. Please create the group using communication channel you like the most and let me know how to join :)

To be honest, I just installed X last week and it's very nice for sharing ideas with people from the open source community.
I'd encourage you to give it a try ^^

Ok it sounds like the immediate next step is to start a community lead repo mlx-graph (or something similarly named).. @TristanBilot may have a made the repo already.
I'm very excited to see how this develops! Thanks for the discussion everyone!!
For now I will close this PR since we will not immediately add anything from it.


Use @Data  and @Builder at same time cause compile error

Solution:
append @NoArgsConstructor and @AllArgsConstructor
Is this a bug?

I just created tests for this and cannot reproduce the problem. Can you have a look at our test files?
https://github.com/rzwitserloot/lombok/blob/master/test/transform/resource/before/BuilderValueData.java
https://github.com/rzwitserloot/lombok/blob/master/test/transform/resource/after-delombok/BuilderValueData.java
https://github.com/rzwitserloot/lombok/blob/master/test/transform/resource/after-ecj/BuilderValueData.java
What compiler do you use? Eclipse, mvn, javac? What version?
What happens if you try to compile the after-delombok file in your environment?

Closing as we cannot reproduce this, and no feedback has been given.


Reuse a release to append different platform sdk per same release tag

We'd like to set nightly builds deployment per platform
https://github.com/AdoptOpenJDK/openjdk-build/pull/291 .
Current publishRelease API option do not allow same tag( or release) being used again. We'd like each  release can be overidden with same sdk and be appended by different platform sdk as long as those sdk is deployed at same day.
Signed-off-by: Sophia Guo<EMAIL_ADDRESS>

@gdams @smlambert

Thanks @sophia-guo - and to be clear, I believe you have tested that this minor configuration change is all that was needed to be able to append new platform entries into the release.  Given that, I approve this change.


In Bundler 1.10.6 invalid gemspecs are magically hidden. Fixed (but yet to be merged) here: https://github.com/bundler/bundler/commit/5186b0fe31504491c335b3514d0306bf8ec1caf8
This gem's gemspec is invalid, so this fixes that.

Look at me go, PRing to the wrong repo. Hi @brycesch !


Firefox running simple BJS scene turns my laptop into a heat gun

Hello!
So, I assembled this simple scene -- http://dimous.github.io/babylonjs/
I get 3-4% of CPU usage in Chrome and 35-38% in Firefox 61.0.2 x64. I also tested it on a desktop computer and got the same results.
UE's action-rpg demo consumes less CPU, wtf?
Babylonjs version: v3.3.0-beta.1
My laptop's video hardware: Intel(R) HD Graphics 4000, NVIDIA GeForce GT 740M (I installed latest drivers for both cards)
about:config

setting
value

webgl.1.allow-core-profiles
false

webgl.allow-fb-invalidation
false

webgl.angle.force-d3d11
false

webgl.angle.force-warp
false

webgl.angle.try-d3d11
true

webgl.bypass-shader-validation
false

webgl.can-lose-context-in-foreground
true

webgl.default-no-alpha
false

webgl.disable-DOM-blit-uploads
false

webgl.disable-angle
false

webgl.disable-extensions
false

webgl.disable-fail-if-major-performance-caveat
false

webgl.disable-wgl
false

webgl.disabled
false

webgl.dxgl.enabled
true

webgl.dxgl.needs-finish
false

webgl.enable-debug-renderer-info
true

webgl.enable-draft-extensions
false

webgl.enable-privileged-extensions
false

webgl.enable-webgl2
true

webgl.force-enabled
false

webgl.force-index-validation
0

webgl.force-layers-readback
false

webgl.lose-context-on-memory-pressure
false

webgl.max-contexts
32

webgl.max-contexts-per-principal
16

webgl.max-warnings-per-context
32

webgl.min_capability_mode
false

webgl.msaa-force
false

webgl.perf.max-acceptable-fb-status-invals
0

webgl.perf.max-warnings
0

webgl.perf.spew-frame-allocs
true

webgl.prefer-16bpp
false

webgl.renderer-string-override

webgl.restore-context-when-visible
true

webgl.vendor-string-override

webgl.webgl2-compat-mode
false

could you ensure in http://webglreport.com/?v=2 that in Firefox you are using the discrete GPU ?

https://screenshots.firefox.com/XNP9KT1Ia0f2OMN6/webglreport.com

It looks like you are using the integrated gpu in firefox could you check if it is the same on Chrome ?
Might also be interested to see the perf profiler comparison between chrome and firefox just in case we are using an API that firefox does not like as much.

http://dimous.github.io/babylonjs/webglreport.com.png
SpectorJS capture for chrome -- http://dimous.github.io/babylonjs/capture 18_32_48.chrome.json
For some reason Firefox version does not save captured data, just nothing happens (it's a bug I suppose).

http://dimous.github.io/babylonjs/profile.chrome.json
http://dimous.github.io/babylonjs/profile.firefox.json

You are using the same GPU in both so we can get read of this possibility.
Could you run the profilers without Spector running ? it does add a lot of extra work that we show in them.
At a first glance it looks like you have a bit too much GC and update style.
The easiest for me to help would be to be able to access your app or working on a babylon playground. is it possible ?

https://playground.babylonjs.com/#DI8SXJ

I removed spector plugin and detached development panel to prevent resizing when I start profiler.
http://dimous.github.io/babylonjs/profile.firefox.v2.json
http://dimous.github.io/babylonjs/profile.chrome.v2.json

I can not repro the issue locally with the difference you have. Looking at your profiles now, it looks like gecko is spending all its time in the Graphics which might highlight an issue with your GPU on Firefox:

This also seems to be the case on Chrome:

Unfortunately it does not look like there is anything obviously wrong highlighting the difference.
What Firefox version are you using ?
Also could you try to force the usage of your nvidia card from the nvidia panel for those apps ?

61.0.2 x64
I also tested it on a desktop computer with only (probably integrated) card NVIDIA GeForce 8400GS. As I stated earlier with the same result. Would upload profiles if you need.

Yup I do definitely not see any huge diff between both browsers :-( it does not look to come from the BJS code.
You might try a report on the Mozilla team to understand why is there such a big diff across the browsers?

Ok. Thanks for your time.

@Dimous please do let me know if you have news on it I am always willing to fix such kind of issues. Sorry it did not help as much.

No worries! My previous comment sounds like a mute reproach, but it's not 😂
It's the same situation with https://armory3d.org/demo/animation/ It's definitely a Firefox issue.


VTOL Tailsitter instant transition to FW if airpeed is above transition/stall speed

I had a crash that would have been prevented if something like this had exist. I lost control flying the tailsitter at high speed in MC mode, 75º pitch, 15m/s, elevons active only for YAW (MC reference system) (maybe my fault for doing this, but under wind conditions being able to fly like that is needed). It ended flying upside down at high speed towards ground and the MC controller unable to control situation, I tried to change to FW flight but nothing happened and crashed. In that situation a fast mode switch to FW would have avoided the crash.
I've thought about a mode of flight wich takes advantage of wing dynamics for tailsitters. Flying in MC mode a tailsitter I've observed that is so much easy to yaw if you roll at the same time, since wing will turn into wind. What do you think?

On the switch problem: I thought about having a 3 position transition switch which would let you do the transition by putting the switch into the middle position, but also lets you switch right through to the other mode by moving the switch all the way. But this also requires you to finish moving the switch all the way after the transition happened.

It will be a solution.  From one side to center position will be auto transition and moving from side to side directly, direct switch from one mode to another. Since back transition is always direct you don't need to finish moving the switch.  It could be:
Positon_1/Position_2/Position_3
Flying in MC (switch in position_1):   Do nothing/Transition to FW/ Direct switch to FW
Flying in FW (switch in Position_2) :    Transition to MC/Do nothing/Do nothing
Flying in FW (switch in Position_3) :     Transition to MC/Do nothing/Do nothing
But it could be dangerous. If the switch is moved all the way right accidentally (in this diagram) flying in MC it will end in a crash.
Since transition to FW is a maneuver to gain speed over the stall speed of the wing, transition can be avoided if air speed is over stall.
It think that my solution will be safer.

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.
(This is an automated comment from GitMate.io.)

That would be a good enhacement...


doc_count already exists in parent class

as titled

Backported via https://github.com/elastic/elasticsearch-specification/pull/2869.


Generator dont check for query names for array type

I found very similar issue to this one https://github.com/Dreamescaper/GenerateAspNetCoreClient/issues/4
Lets say i have this. (Dont need to be enum, but any array type)
GetThing(string language, [FromQuery(Name = "language_types")] SomeEnum[]? languageTypes)

It generates
GetThing(string language, [Query] SomeEnum[] languageTypes = null);

It should be
GetThing(string language, [AliasAs("language_types")]  SomeEnum[] languageTypes = null);

I've published updated version to nuget, please check it out.
https://www.nuget.org/packages/GenerateAspNetCoreClient.Refit/


#4 Read me

User Story
As a boot camp student
I want the Urban Notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN the urban project repository
WHEN I view the README for the repository
Then I can see a professional README that provides information on the project and how to use it

Added Read me file


More time or shorter sentences to fight OOM-Exception

When using my GPU(GeForce GTX 960, 2GB VRAM), I need to set max_mel_frames to 80 for tensorflow to not throw an OOM-Exception. Then I get about 1 second per step and it runs in the background without interfering my work.
Using clip_mels_length = False and no GPU, I get no OOM-Exception but each step takes 70 seconds at best and my computer becomes unusable.
I read here, that you can use memory growing or avoid allocation of the whole GPU memory. Where would I need to put this into your code?

I don't think that's your problem here. From my experience a minimum of 6GB is going to be required to train even a reduced length model with a batch size of 16 (heavily not recommended by Rayhane-mamah as it may not align).


Fix V3 primer bedfile format

primer_schemes/nCoV-2019/V3/nCoV-2019.bed wasn't in standard 6-column format which breaks iVar. This fix sets column five to an integer, which then passes the format-testing built into ivar.

closing in favour of https://github.com/artic-network/artic-ncov2019/pull/41 - thanks though Matt!


vue upgrade does not work

Version
3.4.0
Environment info

Environment Info:

  System:
    OS: macOS 10.14.3
    CPU: (12) x64 Intel(R) Core(TM) i7-8700B CPU @ 3.20GHz
  Binaries:
    Node: 10.15.0 - ~/.nvm/versions/node/v10.15.0/bin/node
    Yarn: 1.13.0 - /usr/local/bin/yarn
    npm: 6.7.0 - ~/.nvm/versions/node/v10.15.0/bin/npm
  Browsers:
    Chrome: 71.0.3578.98
    Firefox: Not Found
    Safari: 12.0.3
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0-beta.2
    @vue/babel-plugin-transform-vue-jsx:  1.0.0-beta.2
    @vue/babel-preset-app:  3.4.0
    @vue/babel-preset-jsx:  1.0.0-beta.2
    @vue/babel-sugar-functional-vue:  1.0.0-beta.2
    @vue/babel-sugar-inject-h:  1.0.0-beta.2
    @vue/babel-sugar-v-model:  1.0.0-beta.2
    @vue/babel-sugar-v-on:  1.0.0-beta.2
    @vue/cli-overlay:  3.4.0
    @vue/cli-plugin-babel: ^3.4.0 => 3.4.0
    @vue/cli-plugin-eslint: ^3.4.0 => 3.4.0
    @vue/cli-service: ^3.4.0 => 3.4.0
    @vue/cli-shared-utils:  3.4.0
    @vue/component-compiler-utils:  2.5.2
    @vue/preload-webpack-plugin:  1.1.0
    @vue/web-component-wrapper:  1.2.0
    eslint-plugin-vue: ^5.0.0 => 5.1.0
    vue: ^2.5.22 => 2.6.0
    vue-eslint-parser:  4.0.3
    vue-hot-reload-api:  2.3.1
    vue-loader:  15.6.2
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.5.21 => 2.6.0
    vue-template-es2015-compiler:  1.8.2
  npmGlobalPackages:
    @vue/cli: 3.4.0

Steps to reproduce

vue create myproj
cd myproj
vue upgrade

What is expected?
Upgrade should work.
What is actually happening?
Even after following the instructions and globally installing @vue/cli-upgrade, I get the same message instructing me to install the package.

I have the same problem. No matter how you try, it will always told you to install @vue/cli-upgrade instead of upgrading.

And news on this? This is pretty frustrating....

The upgrde functionality was added unofficially to test it out. It's not a documented feature yet.
We will revamp it a bit, hopefully within March.

The same story. Nothing changed in that time?

not a solution ?

This still does not work. Vue-cli version 3.11.0, OS X. I get
Command vue upgrade requires a global addon to be installed.
Please run npm install -g @vue/cli-upgrade and try again.

@vue/cli-upgrade is installed and also at 3.11.0.

I have the same issue. I am using vue-cli v3.11.0 on Windows 10 (1903).  Vue has been installed globally with vue install -g @vue/cli.
Environment Info:                                                                                System:                                                                                OS: Windows 10                                                                                CPU: (8) x64 Intel(R) Core(TM) i5-9300H CPU @ 2.40GHz                                                                 Binaries:                                                                                Node: 12.9.1 - C:\nodejs\node.EXE                                                                                Yarn: Not Found                                                                                npm: 6.10.2 - C:\nodejs\npm.CMD                                                                                Browsers:                                                                                Edge: 44.18362.329.0                                                                                npmGlobalPackages:                                                                                @vue/cli: Not Found

I still don't know what stops vue upgrade from working properly in v3.
But anyway, in Vue CLI v3, it does nothing more than invoking npm update or yarn upgrade underlyingly for @vue/cli-service & @vue/cli-plugin-* packages. So I recommend you to use these commands instead.
BTW, yarn upgrade-interactive has a nice user interface.


brew install is an aws cloudformation tool?

❯ brew tap cenkalti/rain
brew install rain
==> Tapping cenkalti/rain
Cloning into '/usr/local/Homebrew/Library/Taps/cenkalti/homebrew-rain'...
remote: Enumerating objects: 172, done.
remote: Counting objects: 100% (172/172), done.
remote: Compressing objects: 100% (86/86), done.
remote: Total 172 (delta 43), reused 0 (delta 0), pack-reused 0
Receiving objects: 100% (172/172), 18.54 KiB | 451.00 KiB/s, done.
Resolving deltas: 100% (43/43), done.
Tapped 1 formula (26 files, 49.3KB).
==> Downloading https://homebrew.bintray.com/bottles/rain-1.1.1.catalina.bottle.tar.gz
==> Downloading from https://d29vzk4ow07wi7.cloudfront.net/f3ef06e12e92b1e196bdd77d9b1de8c9568494883ba1c6a24d3201151576920c?response-content-disposition=attachment%3
######################################################################## 100.0%
==> Pouring rain-1.1.1.catalina.bottle.tar.gz
==> Caveats
Deploying CloudFormation stacks with rain requires the AWS CLI to be installed.
All other functionality works without the AWS CLI.

zsh functions have been installed to:
  /usr/local/share/zsh/site-functions
==> Summary
🍺  /usr/local/Cellar/rain/1.1.1: 8 files, 42.9MB

❯ rain
Rain is a command line tool for working with AWS CloudFormation templates and stacks

Usage:
  rain [command]

Stack commands:
  cat         Get the CloudFormation template from a running stack
  deploy      Deploy a CloudFormation stack from a local template
  logs        Show the event log for the named stack
  ls          List running CloudFormation stacks
  rm          Delete a running CloudFormation stack
  watch       Display an updating view of a CloudFormation stack

Template commands:
  build       Create CloudFormation templates
  diff        Compare CloudFormation templates
  fmt         Format CloudFormation templates
  merge       Merge two or more CloudFormation templates
  tree        Find dependencies of Resources and Outputs in a local template

Other Commands:
  console     Login to the AWS console
  help        Help about any command
  info        Show your current configuration

?

Hey @NorseGaud,
I see that there is new Formula added recently to homebrew-core named rain. (See here)
Because there are two formulas named rain in the system. To distinguish them and install correct rain, you can specify full path of the brew Formula. That can be found under tapped folder (in your case /usr/local/Homebrew/Library/Taps/cenkalti/homebrew-rain/Formula/rain.rb - attention to /Formula/rain.rb)
So running this command should be enough => brew install /usr/local/Homebrew/Library/Taps/cenkalti/homebrew-rain/Formula/rain.rb
@cenkalti to get around this issue, modifying goreleaser config may work. Not sure though.

Hi @NorseGaud,
Name collision. You can tap & install with a single command: brew install cenkalti/rain/rain. I'll update the README. Thanks for reporting.


Addressed objections from Ben except for smartstack

@avadhutp @bplotnick This pull request addresses all the objections except for the smartstack config.
I wanted to ask about the smartstack - you want me just the read the services from /etc/nerve/nerve.conf.json and keep the rest the same or you want to move this whole collector out of diamond?

@bplotnick all fixed

@bplotnick @dichiarafrancesco Btw. do you know why travis is failing? Is it because of me?

@bplotnick @astyelp @dichiarafrancesco Looks like a problem with getting golint dependencies in 1.5(.x). Since we use 1.6 at Yelp, I think this is ok to merge though.


Online Readme.md doesn't have accurate flag descriptions

You cropped the important part of the script's output: The script version.
Your left half part of your image shows an older version of the syno_hdd_db script while the readme is up to date for the latest version of the script.
I can tell that you are at least 6 versions behind the latest version.

your right, i thought I ran the autoupdate flag prior to doing this, but apparently not. what happened to the M command?  Does the m2 flag not exist anymore?

I originally added the -m flag just in case people were worried that the script might mess up their existing NVMe volumes manually created in DSM 6 or 7.0.
But then I was getting too many questions about what the -m flag was for. I also suspected nobody used it, and did a survey on reddit asking if anyone uses the -m flag and got no replies.
So I removed the -m flag from the readme and help but left it in the script just in case anyone actually does use it.


Document libraries and external dependencies

Description

List all the libraries used in the project, including version number
List all the external non-PCS dependencies used in the project
Provide a concise description of what they do and why they are required

Save the information in the team wiki, following the template provided

done


no icons in font-awesome sets

Hello,
thank very much you for this great job.
For font-awesome sets i cannot see icons after import in inkscape et even if i open it online,
same for gnome.
Best regards

Since this is a symbol, you shouldn't be able to see anything online.
If you open the symbols in Inkscape it should be visible under the symbols panel.
Did you follow the readme instructions to import and use the symbols?


Update munit-cats-effect-3 to 1.0.6

Updates org.typelevel:munit-cats-effect-3 from 1.0.1 to 1.0.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "munit-cats-effect-3" } ]

labels: test-library-update, semver-patch

Superseded by #461.


feat(store-indexer): disable prepared statements

Should we do this for the indexer backend too? I imagine it can fail there as well


German Umlauts not working

I updated S22.Imap in my project after several months to the current build (16/03/13) in GIT and noticed that German umlauts don't seem to work anymore. When I create a MailMessage using
MailMessage message = imap.GetMessage(uid);
(when iterating over a list of unread messages), the Umlauts in message.Body are replaced by "?" signs.
Interestingly enough, the BodyEncoding seems to be detected correctly. If the message is sent using ISO-8859-1 I see System.Text.Latin1Encoding being set, or System.Text.UTF8Encoding if the message is sent in this format. But my Text (e.g. the word "Österreich" comes out as "?sterreich" for ISO-8859-1 or "??sterreich" for UTF-8.
I'm pretty sure, this used to work my previously used version (which was the one from nearly 7 months ago). Do I need to set something here or is it simply broken in the current version?
Thanks for your help,
Wolfgang

Looks like issue #79 is another version of the same problem.

There is a fork of S22.Imap which fixes the issue:
Install-Package S22.ImapWithUTF8


Question: Should we add ids to dom elements?

Is adding ids to dom elements makes turbolinks faster?
Or, it doesn't matter?
Thanks!

Your question is pretty broad (faster under what circumstances?), but, in general, Turbolinks will greatly benefit from CSS that is written with performance in mind.
Because Turbolinks replaces the entire body element on every navigation, the entire body has its styles recalculated, layout re-done, and finally must be re-painted to the screen. Unlike frontend solutions that use a virtual DOM, like React, the entire DOM must be replaced and restyled. This happens even if only 1 DOM element out of 4,000 is different. On large, 2,000+ DOM element pages, this can become a minor bottleneck. On my 4,000-element test page, style recalculation/layout/paint takes about 100 milliseconds. That's not the end of the world, but 100 milliseconds can be the difference in making Turbolinks navigation feel "native-like" or "instantaneous".
So, how can a Turbolinks application use CSS to make the style recalculation/layout/paint process faster?

Use smarter CSS selectors. As you mentioned, certain selectors are faster than others. The fastest CSS selectors tend to be just a single class or ID. Avoid child or descendant selectors. MDN has a complete article on the topic. Simply adding IDs to elements won't make Turbolinks any faster, though rewriting your site's CSS to use simple class and ID selectors will.
Use flexbox According to Google, flexbox is now a faster layout model for most websites than traditional, float-based layouts. Your mileage may vary, profile and benchmark to make sure.
Write less CSS Style and layout will be faster if there's simply less CSS to apply. Try and keep it under about ~100KB.
Keep DOM sizes under 1,000 elements Less complex DOMs are faster to style and paint. You can check the size of any webpage's DOM by putting document.getElementsByTagName('*').length into the console.

Google Web Fundamentals provides an in-depth introduction to rendering performance.
For small, simple webpages (~250 DOM elements or less), none of this is really an issue.


Translation/consistency issue with FancyZones in Swedish

ℹ Computer information

PowerToys version: 0.33.1
PowerToy utility: FancyZones
Language: Swddish

📝 Provide where the issue is / 📷 Screenshots
Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form

❌ Actual phrase(s)
"Öppen layoutredigeringsprogrammet"
✔ Expected phrase(s)
"Öppna layoutredigeringsprogrammet"
ℹ Why is the current translation wrong
"Öppen" is an adjective, "Öppna" is a verb.
To be consistent, the button above the translation issue says "Starta layoutredigeringsprogrammet", why would you use both "Starta" (Start) and "Öppna" (Open)? Are they different in the English version?

in english open can be used as a verb and an adjective but i asssume this is different in swedish
source: https://english.stackexchange.com/questions/141547/opened-vs-open#:~:text=6 Answers&text=The word open can be,%2C future%2C or present tense.&text=If you did the action,Or%2C you could run away.

@nmcc1212 that's likely the reason for the erroneous translation. And to my second point, even if the translation error is corrected, the two sentences next to each other, meaning the same thing, is using different wording (although grammatically correct) and you probably want to decide on one of them. I haven't looked at the english strings but as a comparison, the first sentence would say "Start layout editing program" and the second would say "Open layout editing program". Both are correct and sensible but not giving a sense of consistency.

@nmcc1212 I'm sure you noticed the typo that happened when you made the change? There's a "t" missing at the end.

fixed this, but i dont think it will update the pr now it's closed
English
FancyZones_HotkeyEditorControl.Header = Open layout editor
FancyZones_LaunchEditorButtonControl.Text = Launch layout editor
Swedish
FancyZones_HotkeyEditorControl.Header = Öppen layoutredigeringsprogrammet (Öppna layoutredigeringsprogrammet)
FancyZones_LaunchEditorButtonControl.Text = Starta layoutredigeringsprogrammet

Sorry, have to submit translation issues through a process.
I'll create the formal internal ask.

https://ceapex.visualstudio.com/CEINTL/_workitems/edit/402187

This will push in for 0.37 and in Monday's loc drop

This is now fixed in 0.37 https://github.com/microsoft/PowerToys/releases/download/v0.37.0/PowerToysSetup-0.37.0-x64.exe


fix tableRowConnected double click should trigger the link if defined

Codecov Report

Merging #1186 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1186      +/-   ##
==========================================
- Coverage   99.67%   99.67%   -0.01%
==========================================
  Files         350      350
  Lines        8860     8859       -1
  Branches     2099     2100       +1
==========================================
- Hits         8831     8830       -1
  Misses         29       29

Impacted Files
Coverage Δ

...por/src/components/table-hoc/TableRowConnected.tsx
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 206b301...f3c3fb4. Read the comment docs.


Replace Font Awesome symbol with SVG.

Closes #312

Signed-off-by: Bryce Reitano<EMAIL_ADDRESS>

Test runner was using some cached changes, fixing now.

Looks like there is a deprecated method that needs to be updated, causing the build to fail. Other than that, my build environment seems to be in place to avoid multiple builds in the future.

LGTM. The rubocop failure seems unrelated to this change.


ktemplates is ignoring \n

See PR: https://github.com/redhat-developer/odo/pull/1143
When using ktemplates, it is ignoring any newlines or \n at the end of the string. We shouldn't ignore this as some spacing is required for each example / description when using odo --help.

Closing as this was fixed in #1143


Can you please DEPRECATE this Github project?

Can you please DEPRECATE this Github project?
Many people who are starting out with Go and Proto use this - wrongly.
Please.

The github.com/golang/protobuf module is marked as deprecated (superseded by "google.golang.org/protobuf"):
https://github.com/golang/protobuf/blob/v1.5.2/go.mod#L1
Every package in this module is also marked as deprecated.
We still use this GitHub project's issue tracker for both modules, however.

This is already documented in several places:

https://github.com/golang/protobuf/blob/ae97035608a719c7a1c1c41bed0ae0744bdb0c6f/go.mod#L1
https://github.com/golang/protobuf/blob/ae97035608a719c7a1c1c41bed0ae0744bdb0c6f/proto/proto.go#L12

What else do you suggest?

If you still use this issue tracker {
forget it
} else {
deprecate the project with Github settings option
}

We do still use this issue tracker. (As documented here: https://github.com/protocolbuffers/protobuf-go#reporting-issues)


NFT Guideline

NFT Guideline
1: Immutable NFT : ARC-3
Immutable NFTs are digital assets that cannot be altered or modified once created. ARC-3 ensures that the data and information of the asset cannot be changed.
Characteristics:

MetaData off-chain (Any URL can be used, mostly IPFS.)

2: Mutable NFTs : ARC-3/ARC-19
Mutable URLs allow creators to modify the link's destination attached to an NFT, which can be helpful for updating information about the asset. ARC-19 and ARC-3 work together to provide mutable URLs.
Characteristics:

MetaData off-chain (Any URL can be used, mostly IPFS.)
Use the Reserve Address to update the url

3: On-chain (txn note) metadata NFTs : ARC-69
ARC-69 allows for the on-chain creation of metadata. This standard allows the creation of NFTs from an application and keeps everything on-chain.
4: On-Chain Mutable NFTs :  ARC-20
A ARC-20 "Smart ASA" is an Algorand Standard Asset (ASA) controlled by a Smart Contract that exposes methods to create, configure, transfer, freeze, and destroy the asset.
Links
MetaDatas:

ARC-16

ASA NFTs:
Smart ASA

ARC-20

Royalty enforcer

ARC-18

Immutable

ARC-3

Metadata Mutable

ARC-69

SoulBound Token

ARC-71 Draft

Discussions

Mutable data field on ASAs

URL - Mutability:

ARC-19

Smart-Contract NFTs:

ARC-72

ABI

ARC-4

Events

ARC-28

Interface Detection

ARC-73

Rest API

ARC-74

Moved here https://github.com/algorandfoundation/ARCs/wiki/NFT-Guideline


Make Docker work great

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1957
Originally created by @DouweM on 2020-04-21 15:51:13

View 2 previous comments from the original issue on GitLab


issues with TOC installation

Hi,
Just tried installing TOC extension on a mac book. didn't succeed. which custom.js file should I edit and where the TOC button should appear in the notebook?
I've added the line to the file in:
~/anaconda/lib/python2.7/site-packages/IPython/html/static/custom/custom.js
yet I see no TOC button.
Thanks!

To elaborate on what @andmalc said:
The TOC extension does not work as described in the README. When I load a notebook, I get this error in my browser console:
TypeError: IPython is undefined (toc.js:119)

However, downloading extensions/nbtoc.* from this repository to ~/.ipython/<profile name>/extensions/ and then executing the following in the notebook:
%load_ext nbtoc
%nbtoc

works for me. I'm running IPython 2.3.1.

I added to the README that the extensions should be loaded inside the app_initialized.NotebookApp handler. These extensions are only supported on latest master, and aren't supported on 2.x. They may still work, though.


fix fix bug in build.sh

Proposed changes
fix path for $(dirname $0)/generated-source.sh to enable docker build
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Events spanning multiple days do not render correctly

For example, create a single event that starts on 11/23 at 11pm and ends at 11/24 at 4am. The event will show on 11/23 and extend to the bottom of the calendar, but will not show on 11/24.
I have a codesandbox here, but you may need to edit the times in order to have it work for your timezone:
https://codesandbox.io/s/test-events-across-2-days-4o6gb4?file=/src/App.js

I think I missed this part in the differenceInDays doc, difference in days only if it's more tha 24h, which is not the case in your sandbox.
Check upgrade to v2.5.8, this sandbox similar to your example: https://codesandbox.io/s/test-events-across-2-days-forked-v8kxkq?file=/src/App.js


Support Arch Linux and related distros in install script

support Arch Linux (and related distros) in install script
rename script to install-linux.sh
symlink install-ubuntu.sh to point at script for backwards compatibility
script still works fine on Ubuntu and assumes Ubuntu if it can't auto-detect

It'd be easy to extend this to support RHEL-like distros (RHEL, Fedora, CentOS, Amazon Linux) if a future contributor wanted to.

Thanks for the PR and adding some support for additional distributions :)


separate out unit tests that don't require a browser

This puts all the browser specs inside watirspecs and moves all the unit tests into its own folder.
The need for this is more obvious in my next PR, but wanted feedback on this as I don't understand how Watirspecs work as well as I could. :)

merged 8e95051cc7cbb8c6e388ae3dd155dd3122b98018


Add 3-D animations and hovering effect.

To enhance the user's view and it's compatibility, I can add 3D buttons which will have 2 child buttons and gets on/off on the basis of the user's choice. Another thing, Hovering effect draws the attention of many people so Please assign me this issue. I can work upon it's improvement.

I could add 3d images and an interactive background as the front page which could click onto certain food recipes, please assign me this issue.


Allow to temporarily set the current registry even if it is not associated with a worker thread

Reproducing the issue in #1165.
Will into whether this can be changed without introducing deadlocks...

Will into whether this can be changed without introducing deadlocks...

While the change to temporarily stash a reference to a "foreign" registry in a TLS variable appears to pass the test suite, I am admittedly not confident about the implications of having such a current registry that is not associated with a worker thread in the first place.
I am also unsure about the performance implications of having the TLS access in Registry::current. I did try to mitigate this by at least also using it to fetch the global registry instead of doing that in separate step though.
@awused Could you give this a try whether that would work for your use case at least?

I am admittedly not confident about the implications of having such a current registry that is not associated with a worker thread in the first place.

But then again, this should be fine as for example the main thread is always in this relation w.r.t. the global pool, right?

@awused Could you give this a try whether that would work for your use case at least?

Here are tests I added to iter/test.rs. Based on the documentation I initially would have expected both of these tests to pass, but I don't think they've changed with this PR.
#[test]
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
fn scope_par_iter_which_pool() {
    let pool = ThreadPoolBuilder::new()
        .num_threads(1)
        .thread_name(|_| "worker".to_owned())
        .build()
        .unwrap();

    // Determine which pool is currently installed here
    // by checking the thread name seen by spawned work items.
    pool.scope(|_scope| {
        let (name_send, name_recv) = channel();

        let v = [0; 1];

        v.par_iter().for_each(|_| {
            let name = thread::current().name().map(ToOwned::to_owned);

            name_send.send(name).unwrap();
        });

        let name = name_recv.recv().unwrap();

        assert_eq!(name.as_deref(), Some("worker"));
    });
}

#[test]
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
fn in_place_scope_par_iter_which_pool() {
    let pool = ThreadPoolBuilder::new()
        .num_threads(1)
        .thread_name(|_| "worker".to_owned())
        .build()
        .unwrap();

    // Determine which pool is currently installed here
    // by checking the thread name seen by spawned work items.
    pool.in_place_scope(|_scope| {
        let (name_send, name_recv) = channel();

        let v = [0; 1];

        v.par_iter().for_each(|_| {
            let name = thread::current().name().map(ToOwned::to_owned);

            name_send.send(name).unwrap();
        });

        let name = name_recv.recv().unwrap();

        assert_eq!(name.as_deref(), Some("worker"));
    });
}

As you can infer from the assertion failure
---- iter::test::in_place_scope_par_iter_which_pool stdout ----
thread 'iter::test::in_place_scope_par_iter_which_pool' panicked at src/iter/test.rs:2387:9:
assertion `left == right` failed
  left: Some("iter::test::in_place_scope_par_iter_which_pool")
 right: Some("worker")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

the second does not pass because it makes the assumption that all work would end up on the worker threads, but for the parallel iterators (and rather for any join-based interface) this will not be the case and some of the work can be executed directly on the main thread (which is the test thread in this case).
The test as written does not check which worker pool ends up being used. Please have a look at the tests I added here which use the (global) spawn function instead of the parallel iterators exactly for this reason.

However, extending the tests to use more work and checker for either the main thread or the worker threads, still fails, so while the original test did not check this, the work does not seem to end up on the right pool after all. Will investigate...

I was missing more direct usages of global_registry, especially called via join and now both tests pass. Note that I used the following version of your second test case:
#[test]
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
fn in_place_scope_par_iter_which_pool() {
    let pool = ThreadPoolBuilder::new()
        .num_threads(1)
        .thread_name(|_| "worker".to_owned())
        .build()
        .unwrap();

    // Determine which pool is currently installed here
    // by checking the thread name seen by spawned work items.
    pool.in_place_scope(|_scope| {
        let (name_send, name_recv) = std::sync::mpsc::channel();

        let v = [0; 128];

        v.par_iter().for_each(|_| {
            let name = std::thread::current().name().map(ToOwned::to_owned);

            name_send.send(name).unwrap();
        });

        drop(name_send);

        for name in name_recv {
            let name = name.unwrap();
            assert!(name.contains("in_place_scope_par_iter_which_pool") || name == "worker");
        }
    });
}

which does end up submitting work into the pool. But I think I would still prefer to have a more targetted test case using join in rayon-core. Will work on that...

the second does not pass because it makes the assumption that all work would end up on the worker threads, but for the parallel iterators (and rather for any join-based interface) this will not be the case

That is the entire bug report in https://github.com/rayon-rs/rayon/issues/1165. The documentation is unclear on this point and makes it sound like it will be the case, which is why I suggested updating the documentation for clarity.

some of the work can be executed directly on the main thread (which is the test thread in this case).

I don't think that's the case, at least the documentation for rayon as a whole doesn't state that and I've never observed a parallel iterator using the current thread unless it's already in a rayon threadpool. I would only expect that behaviour if I deliberately set use_current_thread on the threadpool when it was built. If I run a bare par_iter with no scope/install/etc, I never see work execute on the main thread.

Huh, I guess it can do that, I have no idea what is different between my code and this test.

Expect for asserting multiple names to be one of two choice, the only real difference in the workload is that you used a vector of length one whereas I used one of length 128 to ensure that some of the work would end up on the worker threads (having None as their thread names for the default global pool).

That is the entire bug report in https://github.com/rayon-rs/rayon/issues/1165.

I tend to disagree. I think the bug here is that the when work is dispatched onto worker threads via global interfaces like spawn and join (and thereby ParallelIterator), they end up on the global thread pool and not on the one executing the scope, i.e. there is an inconsistency between scope.join and crate::join which this PR tries to remove.

Huh, I guess it can do that, I have no idea what is different between my code and this test.

Expect for asserting multiple names to be one of two choice, the only real difference in the workload is that you used a vector of length one whereas I used one of length 128 to ensure that some of the work would end up on the worker threads (having None as their thread names for the default global pool).

I was running it with enough items (even tried adding sleep to make sure all available threads were finding work). These asserts all pass when run against the current rayon release - with this PR the second run should assert "outer" instead.
    ThreadPoolBuilder::new()
        .thread_name(|u| format!("global"))
        .build_global()
        .unwrap();

    let stuff = vec![0; 50000];
    stuff.par_iter().for_each(|_| {
        assert!(std::thread::current().name().is_some());
        std::thread::sleep(Duration::from_millis(1));
    });

    let outer_pool = ThreadPoolBuilder::new().thread_name(|u| "outer".to_owned()).build().unwrap();

    outer_pool.in_place_scope(|_| {
        stuff.par_iter().for_each(|_| {
            assert_eq!(std::thread::current().name(), Some("global"));
            std::thread::sleep(Duration::from_millis(1));
        })
    });

I still can't figure out what exactly is different with the test being run compared to this code. Based on that test, my code should fail.

with this PR the second run should assert "outer" instead.

Exactly and with the currently pushed version, the code above does indeed fail with
thread 'outer' panicked at src/iter/test.rs:2352:13:
assertion `left == right` failed
  left: Some("outer")
 right: Some("global")

I still can't figure out what exactly is different with the test being run compared to this code. Based on that test, my code should fail.

I think I lost you on which test code we are talking about exactly. At least for the code posted in https://github.com/rayon-rs/rayon/pull/1166#issuecomment-2106288150, the problem was the vector length of one which meant there was no splitting at all and the single invocation happened directly on the main/test thread. Using more work meant join was called at least once which ended up on the global thread pool, i.e. had None as its thread name.

I think I lost you on which test code we are talking about exactly.
In the end I don't think it matters much really, it's a tangential issue that shouldn't make a material difference in program execution since the calling thread is still blocked until the parallel iterator ends anyway.

This PR does seems to address the issue.


Publish schema to PyPI via GitHub Release v10.5.4

We need a release of nmdc_schema so we can update runtime and test  ahead of the monthly release on June 24
cc @pkalita-lbl
Target completion: Monday June 17

@turbomam finished this today.

https://pypi.org/project/nmdc-schema/