[OpenCL] Cleans control_flow_ops.cc file

Mainly re-order code to follow general rule:

CPU Operation registration
GPU Operation registration
SYCL Operation registration

Can one of the admins verify this patch?

is there only reordering in this PR?
I think we can skip the reordering for now.
We can close the PR if there are no actual code changes.

Reverted ordering in 4691140
There are other changes in the file ( eg registration for Merge and RefMerge )

Jenkins, test this please.


Retries on GET against GHES

We've seen a few failures in integration tests when reading from GHES. They seem to be transient errors. For GET's we should pretty much always have retry logic.
The most recent failure we saw was
[2022-08-19T21:46:05.7112486+00:00] [INFO] Waiting for archive with id 5543 generation to finish. Current status: exporting
[2022-08-19T21:46:15.7075198+00:00] [DEBUG] HTTP GET: https://octoshift-ghe.westus2.cloudapp.azure.com/api/v3/orgs/e2e-testing-windows/migrations/5543
Error: 8-19T21:46:15.7655472+00:00] [ERROR] System.Net.Http.HttpRequestException: An error occurred while sending the request.
 ---> System.IO.IOException: Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host..
 ---> System.Net.Sockets.SocketException (10054): An existing connection was forcibly closed by the remote host.
   --- End of inner exception stack trace ---
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError , CancellationToken )
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource<System.Int32>.GetResult(Int16 )
   at System.Net.Security.SslStream.ReadAsyncInternal[TIOAdapter](TIOAdapter , Memory`1 )
   at System.Net.Http.HttpConnection.<CheckUsabilityOnScavenge>g__ReadAheadWithZeroByteReadAsync|44_0()
   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage , Boolean , CancellationToken )
   --- End of inner exception stack trace ---
   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage , Boolean , CancellationToken )
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage , Boolean , Boolean , CancellationToken )
   at Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.SendAsync(HttpRequestMessage , CancellationToken )
   at Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.SendAsync(HttpRequestMessage , CancellationToken )
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage , HttpCompletionOption , CancellationTokenSource , Boolean , CancellationTokenSource , CancellationToken )
   at OctoshiftCLI.GithubClient.SendAsync(HttpMethod httpMethod, String url, Object body, HttpStatusCode status)
   at OctoshiftCLI.GithubClient.GetAsync(String url)
   at OctoshiftCLI.GithubApi.GetArchiveMigrationStatus(String org, Int32 migrationId)

https://github.com/github/gh-gei/runs/7926309135?check_suite_focus=true#step:18:4847

Duplicate of #587


GotoDocs feature

Summary
Integrate Context Sensitive Help AHK script into plugin.
Motivation
I was using the aforementioned AHK script for a while and liked that it brought up the AutoHotkey help file -- as opposed to a webpage. However, I was annoyed by the fact that it would set a context-insensitive hotkey for my Sublime Text. While a could've parsed the title for a ".ahk" to obtain context, this felt very hacky to me.
Notes
This shares a commit with PR #22.

Hi. Your PR has conflicts and I don't know much about handling them. So will you please fix these conflicts and send a PR again (or update this one).

Fixed!
For the record, what I did was git rebase ahkscript/master to fix the divergence between your branch and mine. We both edited some files, which created conflicts, but that was easy: I just kept both, since they were unrelated changes.
Hope that made sense.

Thanks. I will definitely try it the next time...


Some ideas

I had a minecraft server hosted on Azure and got the idea of having it controlled by a discord bot. Within 5 minutes I bumped into this project. I had never created one before but it was really straightforward. In less than an hour I managed to set everything up and even host it in azure container instances but pointing mongodb to a free tier cosmos account (it just worked).
Have you thought about making the configurations be read from environment variables? This way this project could provide built images on hub.docker easily deployable on any cloud platform by passing simple env vars or an optional docker-compose file by the user.

@sombraSoft Do you have any ideas on how to easily set an array of object values? For the vms config key.

Okay I gave this a bit of through and I think it might be hard to not break existing deployments people are running. Due to the code importing configuration as a module (import cfg from "./config"). But I could see myself creating a special config.ts file which reads from env vars and publishing that to the Docker hub. So it is possible.


[Idea] A "longer" Next tab

Hello again!
I think it would be great if the "Next" tab showed more than just the top todo, or if this was perhaps configurable to show "top 5 per project" or "all in project", giving you a long view of each project and each todo in each project.
Thanks!

For future reference, I solved this by slightly modifying the NEXT tab. I made my own, so as to leave the plugin unmodified. To do this, I made two tiddlers named to fit my wiki and match the plugin (so that I can remember why I did this later)
title: $:/.dm/projectify/ui/AllActions
tag: $:/plugins/nico/projectify/tags/dashboard
<$list
  filter=<<py-has-active-projects>>
  emptyMessage={{$:/plugins/nico/projectify/ui/welcome/EmptyNextActions}}
>

    <$list
      filter=<<py-active-projects>>
      template="$:/.dm/projectify/ui/project/AllActions"
      />

</$list>

This is a copy/paste of the Next tab, where I've only replaced the tempalte used, giving my second tiddler:
<$list filter=<<py-has-open-todos>> variable="ignore">

    <$link to={{!!title}}><$view field="title"/></$link> {{||$:/plugins/nico/projectify/images/pie}}

    <$list filter=<<py-open-todos>> template="$:/plugins/nico/projectify/ui/todo/TodoItem"></$list>

</$list>

This is a copy/paste of the original template used, where Ive changed the macro to now be <<py-open-todos>>.

@NicolasPetton - just wanted to draw your attention to this closed list, in case you thought it would be a useful addition to the docs.


Bug: Issue with Blurriness when Switching Files View Modes

Description
I have encountered an issue with Files where, when switching from Column or Details view mode to Tiles, Small Icons, Medium Icons, or Large Icons view modes, only the first item appears sharp while all the other items appear blurry.
Steps To Reproduce

Navigate to a directory that is in either Details or Column view mode.
Switch to Tiles, Small Icons, Medium Icons, or Large Icons view mode.

Requirements
Investigate the cause of blurriness when switching view modes.
Files Version
Version : 2.4.81
Windows Version
Windows 11 22H2 22621.1702
Log file

Thanks for the report, Can you give the following information.

Does refreshing the folder fix it?

Thanks for the report, Can you give the following information.

Does refreshing the folder fix it?

Yes, but then I always have to update my files when I change the display

Is this folder by any chance in OneDrive?

Is this folder by any chance in OneDrive?

No, not necessarily because look at the image below, the elements are not in the Cloud


CAP: Capability negotiation ends immediately on NICK

This is a bug. It should wait for CAP END if the client legit does start negotiation.

Fixed by 0ccabead31e46a38a2111caa9745b3ad134df9ec


Allow healthcheck on different port

The http healthcheck will allow a path but not a port, which is problematic for existing Dropwizard-based services which by default to have the healthcheck endpoint on a separate admin port. There are also instances of proxies where a tcp check is being done to check the health of the proxy but the traffic is going over different ports.
Envoy would need a healthcheck_port in the static configuration and the SDS API to support being a drop-in replacement for HAProxy under these conditions.
http://www.dropwizard.io/1.0.6/docs/manual/core.html#health-checks

Please see linked PR for a first attempt at this. Needs cleanup.

I'd like to +1 this feature, we have a few cases where we'd like to be able to health check a port that's different from the "traffic port"

I looked through the previous PR. It sounds like the idea to add a "health check address" to each endpoint in EDS was uncontroversial but figuring out a clean design for specifying an alternate health check port when using strict or logical DNS (and probably static hosts) was difficult.
Would it be reasonable to add the "health check address" config option to EDS first, and then follow up with the other ways of specifying cluster membership later on?

@mpuncel yes, at this point I think it's reasonable to just make this happen for EDS only which I think would not be too hard. I would add alternate HC port information to https://github.com/envoyproxy/data-plane-api/blob/master/envoy/api/v2/endpoint/endpoint.proto#L19 most likely. If you want to tackle I would do a data-plane-api PR and we can discuss the details there.

@mpuncel, if you're not on this, may I try to propose a fix for this case?

@dio go for it!

@dio is there any reason this is not fixed by https://github.com/envoyproxy/envoy/pull/3007? I noticed you said "partially fixed." It seems fixed to me?

@dio OK fair enough we can keep it open to track.

Currently, for STATIC, STRICT_DNS and LOGICAL_DNS, a cluster member (a host of hosts) is defined as a core.Address. In order to accommodate alternative health check port for each host, could we have an alternative type (oneof?) of declaring host? Probably just core.Address + health_check_port just like what we have with endpoint (to allow defining host members as a collection of endpoints instead of core.Address-es). Thoughts?

@dio yes I think we can add oneof and not break wire compatibility. I think what you propose makes sense to me. @htuch @WDYT?

If we change https://github.com/envoyproxy/envoy/blob/master/api/envoy/api/v2/cds.proto#L158 to the following:
  message Host {
    oneof host_descriptor {
      option (validate.required) = true;

      core.Address address = 1;
      endpoint.Endpoint endpoint = 2;
    }
  }

  repeated Host hosts = 7;

will it break wire compatibility?
Since I guess repeated oneof is not a thing: https://github.com/google/protobuf/issues/2592#issuecomment-284540212

Yes I think it will break wire compatibility. You may need to add a new repeated hosts field and deprecate the old hosts addresses field or something like that. That is probably a better long term solution.

This is still an important one for our organization, fwiw.

@bobzilladev AFAIK this is implemented already for EDS, just not for non-EDS. Right @dio? Maybe we should change the title.

@mattklein123 do we even need this for non-EDS, given that we can embed ClusterLoadAssignment in Cluster now?

@htuch AFAIK implementation of that was never finished, right? I think just the config was added. @dio ?

@mattklein123 yes for EDS it is there.
While for the ClusterLoadAssignment inside Cluster the config is added https://github.com/envoyproxy/envoy/pull/3504.
Sorry for the delay in the implementation. I'll start again next week.

Update: https://github.com/envoyproxy/envoy/pull/3783 is part of this effort.

Update. I have submitted: https://github.com/envoyproxy/envoy/pull/3864 to fix this.


Spawn in bramble

Improvements

Allow spawning inside Bramble dimensions (and possibly on stock planets?)

stock planets does not work. i dont spawn where i say to spawn

ok cool so we just say that that doesnt work

actually why wouldnt that work, we can set spawn point in the base system to other planets, ok we should probably make that work then

will do stock planets later


Snapped Items - Build List of Snapped Lines to Points

Let's say I have (2) Lines snapped to (1) point.
Each time I snap a line to a point, can you push the Leaflet_ID of the line to the point Layer on the Feature Properties?
Example:
In the background, when I create a feature (let's say a point), I auto push in the feature.properties with the Leaflet_ID, Feature Type, etc. etc. At this same time, I'd like to add an array called "Snapped Lines" and each time a line is snapped to this point, add the Leaflet_ID from the line into this array.
Basically, building a relationship array on the point. That way I can reference all lines snapped to a point.
Then vice versa on the lines, I would like to see all points associated with the selected line.
Not sure if this already exists, but this would complete my project I'm working on if you can get that to work!
Thanks again for the awesome work

That’s a fantastic suggestion and would basically be the groundwork for #493 👌

Sweet! Let me know if you need any other suggestions/help. I work with massive geo databases and map applications for (can't say their name, but "Can you hear me now?")

@solutegrate I'm interested to learn more about your use cases. Would you contact me via email?

I sent you an email. Also I have another question (Hopefully easy!)
How do I add the footage to the line being drawn and edited? As I'm drawing/editing, I would like to see the footage/miles/etc on top of the line or in the popup.

Nevermind. I wasn't thinking when I asked that question. here it is:
`map.on('mousemove', function (e) {
var from = turf.point([vertexLatLng.lat, vertexLatLng.lng]);
var to = turf.point([e.latlng.lat, e.latlng.lng]);
var options = {units: 'miles'};
var distance = turf.distance(from, to);
	    	console.log(distance * 3280.8);
		});`

That’s a fantastic suggestion and would basically be the groundwork for #493 👌

ahh that's exactly what I'm working on right now. How did you implement what's in your screen capture? 😄

@eharason It will be a new mode where you can basically pin shared vertices. Then all layers with the same vertex will stay pinned to the edited one.
You can turn this on and off (just like snapping) whenever needed.

right on!

This is done now: #493
https://geoman.io/blog/pinning-now-in-leaflet-geoman-pro


feat: version negotiation between server and client

Yes, we should setup alpn for QUIC protocol which is the underlying networking protocol of YoMo.


Decky plugin desktop install toggle no longer there

Describe the bug
Silly one After reinstalling bazzite kde I lost the decky install toggle from the desktop and for some reason it didn't load whilst I was offline, maybe steam updated so I couldn't fix it I'm not sure that would have worked offline though.
What did you expect to happen?
If I'm being silly and this is a dum maybe explain a way around this.
Output of rpm-ostree status
No response
Hardware
No response
Extra information or context
No response

Decky is present in ujust, you can reinstall from there.


[BUG] longhorn manager can not start due to the engine image not ready

Describe the bug
longhorn manager can not start , crashloopbackk
Expected behavior
manager can start successfully
Log
time="2020-09-07T03:45:13Z" level=info msg="Start upgrading"
time="2020-09-07T03:45:13Z" level=info msg="No API version upgrade is needed"
time="2020-09-07T03:45:13Z" level=info msg="Finish upgrading"
time="2020-09-07T03:45:13Z" level=info msg="Upgrade leader lost: <IP_ADDRESS>"
E0907 03:45:13.283776       1 kubernetes_node_controller.go:256] Couldn't get nodes <IP_ADDRESS>: node "<IP_ADDRESS>" not found
time="2020-09-07T03:45:13Z" level=info msg="Start Longhorn Engine Image controller"
time="2020-09-07T03:45:13Z" level=info msg="Start Longhorn Kubernetes node controller"
time="2020-09-07T03:45:13Z" level=info msg="Start Longhorn engine controller"
time="2020-09-07T03:45:13Z" level=info msg="Start Longhorn Setting controller"
time="2020-09-07T03:45:13Z" level=info msg="Start Longhorn volume controller"
time="2020-09-07T03:45:13Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:45:13Z" level=info msg="Start Longhorn node controller"
time="2020-09-07T03:45:13Z" level=info msg="Start Longhorn websocket controller"
time="2020-09-07T03:45:13Z" level=info msg="Start Longhorn replica controller"
time="2020-09-07T03:45:13Z" level=info msg="Starting Longhorn instance manager controller"
time="2020-09-07T03:45:13Z" level=info msg="Start kubernetes controller"
time="2020-09-07T03:45:13Z" level=debug msg="Start monitoring instance manager instance-manager-r-8ddd8800"
time="2020-09-07T03:45:13Z" level=debug msg="Start monitoring instance manager instance-manager-e-be0a917f"
time="2020-09-07T03:45:19Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:45:25Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:45:31Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:45:37Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:45:43Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:45:49Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:45:55Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:46:01Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:46:07Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:46:13Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:46:19Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:46:25Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:46:31Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:46:37Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:46:43Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:46:49Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:46:55Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:47:01Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:47:07Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.2 to be ready"
time="2020-09-07T03:47:13Z" level=fatal msg="Error starting manager: failed to wait for engine image longhornio/longhorn-engine:v1.0.2: Wait for engine image longhornio/longhorn-engine:v1.0.2 timed out"
Environment:

Longhorn version:
Kubernetes version:
Node OS type and version:

Additional context
Add any other context about the problem here.

Can you check the log of pods engine-image-ei-xxxxxx-xxxx and the engine image object info? e.g.,
kubectl -n longhorn-system logs engine-image-ei-xxxxxx-xxxx
kubectl -n longhorn-system get engineimages.longhorn.io -o yaml


WIP: Try parsing CSV w/o sniffing first

Fix parsing of https://gist.githubusercontent.com/abulte/31b992ef353d6d72510cab6d956960e0/raw/7f79fca63dbe4036c88116ea64423288004cc9bd/export-reutilisation-mai-septembre-2018.csv

Nope, that won't work :-)

@noirbizarre if you want to have a look, this is a reproduction case with the code from the standard lib: https://gist.github.com/abulte/0c109fd09c98bd0be12b4a3a6d25b3a5.


macOS Catalina Compatibility Issues?

I recently updated my Mac OS to Catalina, and the first thing post-upgrade was getting my Python packages back up and running. Unfortunately, I was unable to get pysm3 to install via conda following the docs, though the pip install worked without issue. Perhaps that should have been a warning sign.
When I try to run the simple code:
import pysm3
import astropy.units as u

nside = 64
sky = pysm3.Sky(nside = nside, preset_strings = ['d0'])
test_map = sky.get_emission(250.*u.GHz)
smooth_map = pysm3.apply_smoothing_and_coord_transform(test_map, fwhm=5./60.*u.deg)

I get an ominous OMP error:

OMP: Error #15: Initializing libomp.dylib, but found libomp.dylib already initialized.
OMP: Hint This means that multiple copies of the OpenMP runtime have been linked into the program. That is dangerous, since it can degrade performance or cause incorrect results. The best thing to do is to ensure that only a single OpenMP runtime is linked into the process, e.g. by avoiding static linking of the OpenMP runtime in any library. As an unsafe, unsupported, undocumented workaround you can set the environment variable KMP_DUPLICATE_LIB_OK=TRUE to allow the program to continue to execute, but that may cause crashes or silently produce incorrect results. For more information, please see http://openmp.llvm.org/
Abort trap: 6

I will try the suggested workaround on my machine, but it's not an ideal fix. Any insights or suggestions would be greatly appreciated.

it must be libsharp, can you try uninstalling it?
if you are not using libsharp, then it must be healpy, in that case can you run something in healpy and check it works?

Yes indeed, I get the same error when running the following:
import healpy as hp
import numpy as np

nside = 64
test_map = np.random.rand(hp.nside2npix(nside))
smoothed_map = hp.smoothing(test_map,fwhm=0.2)

There is a specific issue with Catalina mentioned here:
https://healpy.readthedocs.io/en/latest/install.html
Have you tried that?

Thanks @zonca! I removed my pip installation and installed both healpy and pysm3 through conda using the instructions at the page you linked. This seems to have taken care of the problem.


USB queue FIFO overflows.

Describe the bug
Without the following PR which has been merged into the upstream repo,  the queue FIFO will overflow  because it relies on a rollover mechanism that doesn't work.
https://github.com/hathach/tinyusb/pull/655
To reproduce
Any USB example is doing it.  I actually don't know how the examples appear to work without this.

Can this be closed, now that we're using an updated TinyUSB?


Node project wont build because of TS dependencies

Environment details

OS:
Node.js version: 10.15.1
npm version: 6.4.1
@google-cloud/pubsub version: 2.6.0

Steps to reproduce

For me, include the pubsub library into a monorepo with a mix of typescript and javasript package/project. With typescript version: 3.3.3
Import the pubsub
Compile
See it fail

Extra information
diwala-api: $ tsc && yarn build-ssr
diwala-api: ../../node_modules/@google-cloud/pubsub/node_modules/google-gax/build/src/fallback.d.ts(119,10): error TS1005: 'from' expected.
diwala-api: ../../node_modules/@google-cloud/pubsub/node_modules/google-gax/build/src/fallback.d.ts(119,13): error TS1005: ';' expected.
diwala-api: ../../node_modules/@google-cloud/pubsub/node_modules/google-gax/build/src/fallback.d.ts(119,29): error TS1005: ';' expected.
diwala-api: ../../node_modules/@google-cloud/pubsub/node_modules/google-gax/build/src/fallback.d.ts(119,34): error TS1005: ';' expected.
diwala-api: ../../node_modules/@google-cloud/pubsub/node_modules/google-gax/build/src/index.d.ts(47,10): error TS1005: 'from' expected.
diwala-api: ../../node_modules/@google-cloud/pubsub/node_modules/google-gax/build/src/index.d.ts(47,13): error TS1005: ';' expected.
diwala-api: ../../node_modules/@google-cloud/pubsub/node_modules/google-gax/build/src/index.d.ts(47,29): error TS1005: ';' expected.
diwala-api: ../../node_modules/@google-cloud/pubsub/node_modules/google-gax/build/src/index.d.ts(47,34): error TS1005: ';' expected.
diwala-api: error Command failed with exit code 1.
diwala-api: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

That ts error Leads to this gooogle search: https://www.google.com/search?q=ts1005
I can solve this by using pubsub library version 1.7.3 instead

I can confirm that if I increase my Typescript version, which was 3.3.3, to the latest 3 version, 3.9, this error goes away. But then it should be some dependency notice.
It might be related to these issues:
https://github.com/googleapis/nodejs-pubsub/issues/1074
which leads to
https://github.com/googleapis/nodejs-pubsub/pull/1079

@vongohren it's great that updating your version of TypeScript seemed to solve this problem.  I think this is honestly a gap with TypeScript that we have no idea how to fix.
@bcoe another case of older versions of TypeScript giving us trouble.  Throwing an idea out there - could we list typescript as an optionalDependency, and then rely on downstream consumers using --engines-strict to surface these kinds of errors?  Otherwise, I honestly have no idea how we can ever what version of TypeScript our generated d.ts requires.

@JustinBeckwith I think having it as an optional dependency would be a heavy-handed for our non-TypeScirpt users, as I believe this will attempt an install of the dep (and just not fail if for some reason the install fails).
We could perhaps add a warning that attempts to detect the locally installed TypeScript, and recommends updating if we find an incompatible version.

Closing this out as it appears that this happens with older versions of TypeScript that are now even older (3.3.3 is circa Feb 2019, we're up to 4.8.4 now) since this issue is ~2 years old. :) If this is still causing problems, please open a new issue!


[UI] Add an entry for community handbook

Current State of the Meshery.io site
No link/handbook is there for handbook on site.
Desired State of the Meshery.io site
Add a menu option for community handbook  under Community as a mega menu. option.
It should redirect the user to https://layer5.io/community/handbook

Contributor Resources
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Can I work on this issue @Chadha93

@Chadha93  don't you think the drop down would become too long if we add another entry?

@Chadha93 don't you think the drop down would become too long if we add another entry?

you can suggest any other place in the website :) how's this(lots of space here) in the footer.

So the problem with adding the handbook here would be that it's the Layer5 community handbook while this is the Meshery website. We want people to know that Meshery is a Layer5 project but also want the 2 to be separate entities. So I think there's no need for anything to link back to the Layer5 website. @leecalcote what do you think?

I'm not sure that this is desirable.

I'm not sure that this is desirable.

Created this one because of this(we wan't community handbook link to spread across)?: https://app.clickup.com/t/1ydvcdq

Should I work on it ?  @Chadha93


Could the standard Grav variables like grav,config,assets etc be Twig globals?

More a discussion point at this stage rather a feature request.
If the site twig_vars (grav, config, site, assets, ...) would be added as globals to Twig rather as template variables this would have the benefit that they would be accessible from twig macros.
This can of course also easily be achieved using a user-specific plugin rather adding it to the core.

I always have had an aversion to 'global' variables of any kind, so that's why I tend to not consider them.  However for macros you do have a valid point and i've run into this a few times.  I would need to experiment with this as it could have other implications related to variable scope with existing themes/plugins.  Worth investigating though.

I would also not make everything global per se. But The grav objects like grav, config, assets et al are more an API than global variables.
Having to pass them all to a macro, is cumbersome.
I currently add them through a plugin so I can use them in macros:
    public function getGlobals()
    {
        return [
            'assets' => $this->grav['assets'], // Otherwise we can't use this in macros
            'config' => $this->grav['config'], // Otherwise we can't use this in macros
            'taxonomy' => $this->grav['taxonomy'], // Otherwise we can't use this in macros
        ];
    }

I think adding the grav object itself is a good option.  Most everything can be obtained from that.

I think too that's the best way forward. It would allow creation and publishing of self contained macros which do not depend on a global set by a plugin nor on passing down API variables.

Ok will make this happen.

The Grav object is now available as a global and has been removed as a template variable.


setup.py install problems...

Not sure what the implications or fix are for this...
python setup.py install
running install
running build
running build_py
copying src/python/init.py -> build/lib/pcmdi_metrics
copying src/python/version.py -> build/lib/pcmdi_metrics
copying src/python/io/init.py -> build/lib/pcmdi_metrics/io
copying src/python/io/base.py -> build/lib/pcmdi_metrics/io
copying src/python/pcmdi/seasonal_mean.py -> build/lib/pcmdi_metrics/pcmdi
copying src/python/pcmdi/init.py -> build/lib/pcmdi_metrics/pcmdi
copying src/python/pcmdi/meanabs_xy.py -> build/lib/pcmdi_metrics/pcmdi
copying src/python/pcmdi/annual_mean.py -> build/lib/pcmdi_metrics/pcmdi
copying src/python/pcmdi/io.py -> build/lib/pcmdi_metrics/pcmdi
copying src/python/pcmdi/rms_xy.py -> build/lib/pcmdi_metrics/pcmdi
copying src/python/pcmdi/bias.py -> build/lib/pcmdi_metrics/pcmdi
copying src/python/pcmdi/mean_climate_metrics_calculations.py -> build/lib/pcmdi_metrics/pcmdi
copying src/python/pcmdi/cor_xyt.py -> build/lib/pcmdi_metrics/pcmdi
copying src/python/pcmdi/rms_xyt.py -> build/lib/pcmdi_metrics/pcmdi
copying src/python/pcmdi/cor_xy.py -> build/lib/pcmdi_metrics/pcmdi
copying src/python/graphics/init.py -> build/lib/pcmdi_metrics/graphics
copying src/python/graphics/portraits.py -> build/lib/pcmdi_metrics/graphics
running build_scripts
creating build/scripts-2.6
copying and adjusting src/python/pcmdi/scripts/pcmdi_metrics_driver.py -> build/scripts-2.6
changing mode of build/scripts-2.6/pcmdi_metrics_driver.py from 600 to 755
running install_lib
creating /usr/lib/python2.6/site-packages/pcmdi_metrics
error: could not create '/usr/lib/python2.6/site-packages/pcmdi_metrics': Permission denied
[gleckler1@oceanonly pcmdi_metrics]$

@gleckler1 that makes sense when you are trying to install into the /usr/lib/ directory using the system Python2.6 and not the Python2.7 that we've been using for UV-CDAT for the last couple of years..

And use the option:
source /usr/local/uvcdat/2016-02-04/bin/setup_runtime.csh
...
> python setup.py install --user

Closing as a gleckler-error (as coined by @doutriaux1)


Dealing with regular pointers?

Hi,
I have some practical question. The manual  said:

When a regular pointer is wrapped inside a virtual pointer, it can be used as it were a virtual pointer.
 int *myptr = vptr.unwrap();

Can I e.g. increment a regular pointer myptr  in order to access the full range of data from the virtual pointer?  Like
myptr += 100;
int b = *(myptr);

It's been a while, but the manual suggests so :)

Ah, one should first wrap a regular pointer in to virtual one before starting to use?


More control over reference counts

Currently, incrementing a reference count cannot be done manually. The only user operation on a reference count is to decrease it with ospRelease. But when storing references to OSPObject's (in all their variations) outside of OSPRay's control this becomes quite limiting. For example, I'm storing a list of OSPInstance in a regular std::vector, which gets updated during program lifetime. At some point that vector gets passed to ospNewData to be used during rendering, but changes are happening to the list at other moments. As the data object might get released outside of my control I cannot guarantee those instance stay alive, other than by storing them in some sort of second "keep-alive" OSPData object. But when the list changes that object would need to be reconstructed every time, etc. My troubles would be much smaller if I could just have more control over the refcount to match the actual number of references kept.
So would it be possible to add an ospAddReference() call (or similar name)? And also a way to get the current reference count of an object, e.g. ospGetReferenceCount()?

We already thought of adding the pendant to ospRelease: ospRetain(OSPRObject).
If you pass the vector of instances in an OSPData (and keep that around), then the instances should not get released. So it may also be a bug in OSPRay.

Ok, great. I actually haven't tried the extra-OSPData-trick at this point.

I didn't mean the extra-ospData, but the original one; if that is alive, the instances should be as well (if not, this is a bug).

Ah, misunderstood. I'm indeed keeping it alive for now as a workaround. But it's not optimal, as that data doesn't contain the up-to-date list of instances, only the ones currently being used for rendering, while there are more that are cached until being used again in future.

So you create many Instances, but only a subset of them is used for rendering at a given time? And you did not call ospRelease on any Instance (currently used or not)? When you put some of those instances in a ospData, their refcount should increase, and be decreased again when that ospData is released. But then the refcount is still >=1 and the Instances should not get released.

Ok, I checked my code and was indeed inadvertently releasing the initial reference in a few places, causing unexpected deleted objects later on

So, can we close this issue? We track the ospRelease() feature-request independently.

Great! Yes, I'll close it


configurable settings

This is very simple fix to make the  ETC explorer more generic.
Site settings are lazy loaded by angular factory method.
for example. (site specific config.json)
{
    "gethPort": 9545,
    "blocks": [ {"start": 0, "end": "latest"}],
    "quiet": false,
    "terminateAtExistingDB": false,
    "listenOnly": true,
    "settings": {
        "symbol": "ESN",
        "name": "EtherSocial",
        "title": "EtherSocial Network Block Explorer",
        "author": "contact@blahblahblah"
    }

settings are served by /config url and loaded later.
further works are already done to customize header/footer/logo etc. (not committed yet publicly)

further work (not committed yet) screen shot.

summaryStats disabled
siteNotes disabled
simpleSummaryStats enabled
logo:"esn-explorer.png"
symbol:"ESN"
customCss:"gray.css"

Looks good to me at first glance. I'm away from my dev machine at the moment but promise to review this tomorrow.


Buttons initialize very slowly since beta.12

Bug, feature request, or proposal:
Since the beta.12 update it seems like mat-buttons take a long time to render.
What is the expected behavior?
Same speed or better as beta.11
What is the current behavior?
I have a paginated md-table with 50 rows and 3 buttons per row, since the last update switching pages takes significantly longer, it works fine if I remove the buttons.
What are the steps to reproduce?
Update to beta.12 and render many buttons at once
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
@angular/cli: 1.4.5
node: 8.2.1
os: darwin x64
@angular/animations: 4.4.4
@angular/cdk: 2.0.0-beta.12
@angular/cli: 1.4.5
@angular/common: 4.4.4
@angular/compiler: 4.4.4
@angular/core: 4.4.4
@angular/flex-layout: 2.0.0-beta.9
@angular/forms: 4.4.4
@angular/http: 4.4.4
@angular/material: 2.0.0-beta.12
@angular/platform-browser: 4.4.4
@angular/platform-browser-dynamic: 4.4.4
@angular/platform-server: 4.4.4
@angular/router: 4.4.4
@angular/compiler-cli: 4.4.4
@angular/language-service: 4.4.4
typescript: 2.5.3
Is there anything else we should know?

Does the same thing happen if you replace <button mat-button> with just <button>?

Yeah it seems to be significantly faster without mat-button @willshowell
I measured performance and the frame after the click takes 1.23s with mat-buttons and 0.46s without

This could be related to issue https://github.com/angular/material2/issues/4221.
For me the violation did not occur with previous versions of Angular Material 2 but suddenly started with beta.12.

Might be related to touch-based ripples that have since been reverted

I will try once the next beta comes @jelbourn
Assuming that's soon for ng5 as well ;)

I just filed #8838 which I think could be related?  It's a ripple issue as well.


Uncaught Error: ENOENT: no such file or directory, lstat '~/Documents/mybrickhouse'

[Enter steps to reproduce:]

...
...

Atom: 1.53.0 x64
Electron: 6.1.12
OS: Mac OS X 10.15.7
Thrown From: Atom Core
Stack Trace
Uncaught Error: ENOENT: no such file or directory, lstat '/Users/gregorius/Documents/mybrickhouse'
At fs.js:126

Error: ENOENT: no such file or directory, lstat '/Users/gregorius/Documents/mybrickhouse'
    at Proxy.realpathSync (fs.js:1470:7)
    at Proxy.fs.realpathSync (electron/js2c/asar.js:300:40)
    at Proxy.fs.realpathSync (electron/js2c/asar.js:300:40)
    at TreeView.moveEntry (/private/var/folders/4s/8v265vts2ds7y982qy8cpw4m0000gn/T/AppTranslocation/382F1B17-237E-40AC-A5E6-91B4A8BB11A7/d/Atom.app/Contents/Resources/app/static/<embedded>:14:996397)
    at TreeView.onDrop (/private/var/folders/4s/8v265vts2ds7y982qy8cpw4m0000gn/T/AppTranslocation/382F1B17-237E-40AC-A5E6-91B4A8BB11A7/d/Atom.app/Contents/Resources/app/static/<embedded>:14:1003622)
    at HTMLDivElement.<anonymous> (/private/var/folders/4s/8v265vts2ds7y982qy8cpw4m0000gn/T/AppTranslocation/382F1B17-237E-40AC-A5E6-91B4A8BB11A7/d/Atom.app/Contents/Resources/app/static/<embedded>:14:976612)

Commands
     -8:49.6.0 editor:indent (input.hidden-input)
     -7:52.6.0 tree-view:add-file (div.header.list-item.project-root-header)
     -7:33.4.0 core:confirm (input.hidden-input)
  2x -7:18.9.0 editor:newline (input.hidden-input)
  5x -7:17.2.0 core:backspace (input.hidden-input)
     -6:50.8.0 editor:newline (input.hidden-input)
     -6:49.6.0 core:backspace (input.hidden-input)
     -6:44.6.0 grammar-selector:show (atom-text-editor.editor.is-focused)
     -6:31 tree-view:remove (li.file.entry.list-item.selected)
     -5:39 tree-view:show-current-file-in-file-manager (div.title)
     -4:10.2.0 core:backspace (input.hidden-input)
     -4:07.7.0 autocomplete-plus:confirm (input.hidden-input)
     -3:57.1.0 core:save-as (ul.list-inline.tab-bar.inset-panel)
     -2:10.4.0 tree-view:show-current-file-in-file-manager (div.title.temp)
  3x -1:11.4.0 tree-view:remove (li.file.entry.list-item.selected)
     -0:50.4.0 tree-view:add-file (span.name.icon.icon-file-directory)

Non-Core Packages

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way 😀


"npm dist-add" instead of "npm dist-tag add"

Challenge Manage Packages with npm has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36.
In part 11 of the NPM challenge, the description asks us to use npm dist-add<EMAIL_ADDRESS>beta.  Running npm help dist-add comes up with no results.
I think it should say npm dist-tag add<EMAIL_ADDRESS>beta.

@NicksIdeaEngine freeCodeCamp does not oversee the how-to-npm project and it will soon be replaced with challenges that are controlled by freeCodeCamp. You're welcome to open an issue on their repo: https://github.com/workshopper/how-to-npm


Memory leak when recreate canvas

Hey, found one curious case on iOS (im not sure, but probably this problem on Android as well, still investigate)
We have screen with GCanvas, after some attempts to open this screen, we got crashes.
Test shows, after closing screen, memory doesn't clean, and i think GCanvas still remain in memory after close. So ios terminate process due overusing memory
https://user-images.githubusercontent.com/77698343/168065318-8256515a-72db-497d-be1d-0194435271bd.mov

The yellow page of "Just Canvas", is it:
a yellow image by ctx.drawImage()
or
ctx.fillStyle = 'yellow' then ctx.fillRect()
?

thats just a background of View
return (
                <View
                  style={{
                    flex: 1,
                    backgroundColor: "yellow",
                  }}
                >
                  <GCanvasView
                    onCanvasCreate={(r) => {
                      ref.current = r.getContext("2d");
                    }}
                    style={{
                      width: Dimensions.get("screen").width,
                      height: Dimensions.get("screen").height,
                    }}
                  />
                </View>
              );

I am meeting the same problem

fixed by<EMAIL_ADDRESS>

Still having the same problem in fixed version 2.3.22. Just 1 component with a button to switch to a render state with or without GCanvasView.
After 7 switches the app kills itself with a '' error.
My onCanvasCreate method:
  const initCanvas = can => {     can.getContext('2d').fillStyle = 'white';     can.getContext('2d').fillRect(0, 0, can.width, can.height);   };   Not using any local variables to make sure memory doesn't leak there.

2.3.22 just fixed the issue in iOS, because I test and found it's already OK on Android.
Please paste the code of your "switch to a render state with or without GCanvasView"

The memory leak is still here. :(
This happens when I unmount component with GCanvasView

Hi flyskywhy, I am working with Loovery (Grigory) here and we are not experts in objective c/ios code and these memory leaks.  If there is anyway I could inspire you to help us find the problem please let me know.  We love what you have done here.  We are a startup but still we have a commercial product that is making us some money, so I would pay you to help us.

@Loovery @avanlaningham , OK, I can try :smile:

Does the memory leak happen on Android or iOS?
How many Bytes leak every time unmount component(It's better to also offer a screen video record here)?
How many times unmount component will leak big enough to let the app kills itself?

@flyskywhy

Only iOS.
~15mb on empty project.
It all depends on the device and the amount of free memory.

https://github.com/flyskywhy/react-native-gcanvas/assets/9263868/b92d4c5f-7d7c-4182-b883-23984b66dc42

But Grigory normally it was about 6 times or something that it would crash after.  Giving rough number might help him better understand.

@Loovery , fixed by<EMAIL_ADDRESS>@avanlaningham , Donate link is in README.md as https://github.com/flyskywhy/react-native-gcanvas#donate , or if you want bank account transfer, please email me<EMAIL_ADDRESS>

`void GCanvasContext::UseDefaultRenderPipeline()
{
GShader *newShader = FindShader("DEFAULT");
if (newShader != nullptr && mCurrentState->mShader != newShader) // mShader > Thread 1: EXC_BAD_ACCESS (code=1, address=0xd8)
{
    SendVertexBufferToGPU();
    mCurrentState->mShader = newShader;
    mCurrentState->mShader->Bind();
}
SetTexture(InvalidateTextureId);

}`

@flyskywhy New problem
`void GCanvasContext::UseDefaultRenderPipeline() { GShader *newShader = FindShader("DEFAULT");
if (newShader != nullptr && mCurrentState->mShader != newShader)
{
    SendVertexBufferToGPU();
    mCurrentState->mShader = newShader;
    mCurrentState->mShader->Bind();
}
SetTexture(InvalidateTextureId);

}`
File: GCanvas2dContext Error: mShader > Thread 1: EXC_BAD_ACCESS (code=1, address=0xd8)

Have never meet such EXC_BAD_ACCESS in the past years, how to reproduce it?

@flyskywhy Once we have this fixed, I will see if I can figure out how to send crypto.  I have played with it a bunch but I am more of a beginner.   I have crypto in different places but I don't even know how to transfer it to you :)  I have not looked at it in a few years so I would have to figure out how to even access it.  But yes if we can't figure that out, I could do bank transfer.  Thanks for trying to help.

@flyskywhy New problem
`void GCanvasContext::UseDefaultRenderPipeline() { GShader *newShader = FindShader("DEFAULT");
if (newShader != nullptr && mCurrentState->mShader != newShader)
{
    SendVertexBufferToGPU();
    mCurrentState->mShader = newShader;
    mCurrentState->mShader->Bind();
}
SetTexture(InvalidateTextureId);

}`
File: GCanvas2dContext Error: mShader > Thread 1: EXC_BAD_ACCESS (code=1, address=0xd8)

@Loovery , If this only reproduced when you rotate the phone (e.g. from portrait to landscape or viceversa), so why don't you use onCanvasResize in GCanvasView ? I considered that Dimensions.addEventListener('change', onChange) in your code is only used to show me the memory leak by mount and unmount easily by just rotate the phone. Actually in real React APP product, no one will use so many mount and unmount when rotating phone, please use onCanvasResize as described in example in my README.md.

@flyskywhy I live in Europe but am American and so I have no way to open a crtypto account.  I used to have some but they blocked me because I am American.  Crazy.  I have some WAVES crypto in META MASK I could send you.  I could do bank transfer also.  Thanks for your help

@flyskywhy Wait.  I think I got a crypto account :)  Let me see tomorrow.  Need to wait 1 day

@Loovery , If this only reproduced when you rotate the phone (e.g. from portrait to landscape or viceversa), so why don't you use onCanvasResize in GCanvasView ? I considered that Dimensions.addEventListener('change', onChange) in your code is only used to show me the memory leak by mount and unmount easily by just rotate the phone. Actually in real React APP product, no one will use so many mount and unmount when rotating phone, please use onCanvasResize as described in example in my README.md.

This is suitable for a simple use case scenario. But we have too many appearance changes when the orientation changes. So a complete rebuild is used

@Loovery
I just test the new commit Rotate Remount to test Memory Leak: just copy from https://github.com/Loovery/gcanvas-memory-leak/commit/b69fce2 of my GCanvasRNExamples, and rotate iPhone quickly and no Error: mShader > Thread 1: EXC_BAD_ACCESS (code=1, address=0xd8) happens.
Maybe there is something else affect the error, e.g. my GCanvasRNExamples use<EMAIL_ADDRESS>, your gcanvas-memory-leak use<EMAIL_ADDRESS>please try them e.g. use<EMAIL_ADDRESS>and tell me the result.

@flyskywhy
EXC_BAD_ACCESS: context > reInitContext > resetGlViewport: >
KERN_INVALID_ADDRESS at 0xe4.
Sometimes I catch this error

@Loovery
I just test the new commit Rotate Remount to test Memory Leak: just copy from https://github.com/Loovery/gcanvas-memory-leak/commit/b69fce2 of my GCanvasRNExamples, and rotate iPhone quickly and no Error: mShader > Thread 1: EXC_BAD_ACCESS (code=1, address=0xd8) happens.
Maybe there is something else affect the error, e.g. my GCanvasRNExamples use<EMAIL_ADDRESS>, your gcanvas-memory-leak use<EMAIL_ADDRESS>please try them e.g. use<EMAIL_ADDRESS>and tell me the result.

I use RN 0.71.13 in main project

@Loovery , I just released<EMAIL_ADDRESS>, maybe you can have it a try.


Redundant NBD

Make myself redundant. Remote backups, GPG encrypted secrets for nixbitcoin.org and external project accounts, dev SSH keys authorized.

Fixups, extra commits.


adding system images

Added system pictures to the images file, and links to those images in the Hera, Jet, PPAN, Niagara and MSU-HPC user guide pages.

Why are many of the system images duplicated?  It looks like it's the same image twice in each case.

Long boring story.
The image source is the HPC OCIO page. Some of those images can be
downloaded directly; some cannot. Where I can't just download the image
file (which is a JPEG), I have to fool around with the image in Paint --
not a problem. By default I save in PNG format, and that should make no
difference.
However, I ran into a problem (literally, in the problems tab that I have
just started using) because in some instances the jpeg format worked,
sometimes not. Since I can't tell where the issue comes from and I can't
diagnose it even if I wanted to, I made some images available in both
formats, so that all pages would work and I could stop fooling with the
task. Storage is cheap.
However, if there's a good reason to do it, I'll go back and cull the
redundant images.
On Tue, Jun 25, 2024 at 12:36 PM Josh Eisinger @.***>
wrote:

Why are many of the system images duplicated? It looks like it's the same
image twice in each case.
—
Reply to this email directly, view it on GitHub
https://github.com/NOAA-RDHPCS/noaa-rdhpcs.github.io/pull/109#issuecomment-2189423437,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4T5JWYXX5ECXRY6KLFSQZ3ZJGL7DAVCNFSM6AAAAABJ4GTIBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBZGQZDGNBTG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Fair enough -- it's a small set of images, and they aren't giant.  Just wanted to make sure you aware / it was intentional....

It's done.
On Wed, Jun 26, 2024 at 11:40 AM Seth Underwood @.***>
wrote:

@.**** requested changes on this pull request.
Please remove the source/Hera.jpg file.
—
Reply to this email directly, view it on GitHub
https://github.com/NOAA-RDHPCS/noaa-rdhpcs.github.io/pull/109#pullrequestreview-2142260016,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4T5JW7RZZ4C6GG4XMN4TOTZJLOE3AVCNFSM6AAAAABJ4GTIBCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBSGI3DAMBRGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Enable running DWO workspaces behind a proxy

What does this PR do?

Add support for proxy configuration in DWO. Values are propagated as env vars to containers in workspaces
Add support for reading cluster Proxy configuration on OpenShift
Extend DevWorkspaceOperatorConfig CRD to include proxy configuration overrides

The git history for this PR is a little bit of a mess, so it may not make a huge amount of sense to go through it commit by commit, unless you want to follow my thought process.
What issues does this PR fix or reference?
Closes https://github.com/devfile/devworkspace-operator/issues/678
Is it tested? How?

Set up crc with a proxy (see below)

Start DWO and verify that proxy configuration is read from the cluster -- should have log Resolved proxy configuration with the current configuration

Update the DWOC to add proxy settings, check that in-controller configuration is updated

Revert DWOC proxy settings and check that defaults from cluster are restored

Check behavior on minikube; should be able to set proxy settings in DWOC and defaults should be empty as there's no proxies.config.openshift.io CRD

Setting up crc with a proxy

Click to expand
This is just the process I followed, there's likely a better way. This assumes that initially crc is not started (might also need to crc delete) and that crc is running locally (i.e. not remotely)

Start Squid proxy in docker:
docker run --detach \
  --name=squid \
  --restart=always \
  --publish 3128:3128 \
  --volume /srv/docker/squid/cache:/var/spool/squid3 \
  docker.io/sameersbn/squid:3.3.8-23

Note: if the container above is stuck restarting, you may need to run sudo chcon -Rt svirt_sandbox_file_t /srv/docker/squid/cache

Start following Squid access logs to verify it's being used:
docker exec -it squid tail -f /var/log/squid3/access.log

Configure crc to use proxy
IP_ADDR=<address of current machine on lan>
CRC_IP_ADDR=$(crc ip)
crc config set http-proxy "http://${IP_ADDR}:3128"
crc config set https-proxy "http://${IP_ADDR}:3128"
crc config set no-proxy ${IP_ADDR}/24,${CRC_IP_ADDR},api.crc.testing,canary-openshift-ingress-canary.apps-crc.testing,console-openshift-console.apps-crc.testing,default-route-openshift-image-registry.apps-crc.testing,downloads-openshift-console.apps-crc.testing,oauth-openshift.apps-crc.testing

(some of these no-proxy entries are probably unnecessary)

crc start

PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)

[ ] v8-devworkspace-operator-e2e: DevWorkspace e2e test
[ ] v8-che-happy-path: Happy path for verification integration with Che

I forgot to make DWO itself use the proxy, working on it.

Updated DWO to use proxy settings for its own HTTP clients. However, due to how the proxy is configured, these settings are only set once when the controller is being started, and changes to the proxy settings require a restart of the controller deployment. We can't restart the controller from itself easily, as the usual way of triggering a rollout (editing the pod's spec in the deployment) does not work in OLM, as the CSV owns the deployment and reverts changes.
I've updated the docs on the DevWorkspaceOperatorConfigs struct to reflect this.

I'm assuming that the proxy settings are just stored internally in the operator unless they're overridden by the devworkspaceoperatorconfig?

Yes -- in fact the DevWorkspaceOperatorConfig only stores manual overrides and does not need to exist at all for DWO to function. Its existence when testing changes is a side-effect of us wanting to automate config via env vars in the make rules resulting in it always being created even if defaults are used. If you check logs when starting DWO with the above DWOC, it should log something like Updated configuration to [(default config)].

/test v8-devworkspace-operator-e2e, v8-che-happy-path

/test v8-devworkspace-operator-e2e

/test v8-devworkspace-operator-e2e

/test v8-devworkspace-operator-e2e


add blt options for gtest and fruit

Adds:
ENABLE_GTEST (default = ON)
ENABLE_FRUIT (default = ON (also guarded by ENABLE_FORTRAN = ON)
Like ENABLE_GMOCK, these are guarded by ENABLE_TESTS.
gmock is also guarded by ENABLE_GTEST,
I think this makes sense b/c building gmock always builds gtest.

This it should help with #61.
This is a WIP (need to fix tests in example),

resolve testing issues, let me know if you have any suggestions

@white238, what do you think?


Forms-5839 remove wiki from code and add it to wiki section of the repo

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

Since this change is about docs, ignoring the test results and merging the PR.


Missing type declaration file.

This appears to be missing it's type declaration file which causes issues in typescript Docusaurus projects.

I was recently considering to add type declarations. Only that it wasn’t clear if they would be useful anyhow. Thanks for motivation to come back to the idea. Will do this soon.

Hm.. Is there any example of a plugin with useful type declarations?
I just looked at @docusaurus/remark-plugin-npm2yarn. The type of the default export is any. Is that enough? Adding // @ts-expect-error would give the same any. That does not look convincing, but is there a better example around?

Weirdly it seems that "any" is fine - the complaint we're getting is because there's no "explicit" type definition.
Examples:

https://github.com/remarkjs/remark-react/blob/main/index.d.ts
https://github.com/remarkjs/remark-html/blob/main/index.d.ts

Thanks for digging out the examples. A PR adding the .d.ts file is here: #212.


failed to produce bindings for RPM library

I'm looking into creating Rust bindings for the RPM libraries.
First I installed bindgen, but it seems to be somewhat inconsistent with what servo/rust-bindgen offers.  So my second attempt was to clone and build bindgen from servo/rust-bindgen:
$ git clone https://github.com/servo/rust-bindgen
$ cd rust-bindgen/bindgen
$ cargo build --release

after that I created a simple wrapper.h:
#include <rpm/rpmlib.h>
#include <rpm/rpmts.h>

and then run bindgen on it:
$ CLANG_PATH=/opt/clang+llvm-3.9.1-x86_64-linux-gnu-debian8/bin/clangLIBCLANG_PATH=/opt/clang+llvm-3.9.1-x86_64-linux-gnu-debian8/lib/ ~/bin/bindgen wrapper.h --output=rpm.rs

as the result I got these errors:
ERROR:libbindgen::ir::context: Valid declaration with no USR: Cursor(__va_list_tag kind: StructDecl, loc: builtin definitions, usr: None), Some(Cursor(va_list kind: TypedefDecl, loc: /opt/clang+llvm-3.9.1-x86_64-linux-gnu-debian8/bin/../lib/clang/3.9.1/include/stdarg.h:30:27, usr: Some("c:@T@va_list")))
ERROR:libbindgen::ir::context: Valid declaration with no USR: Cursor(__builtin_va_list kind: TypedefDecl, loc: builtin definitions, usr: None), Some(Cursor(va_list kind: TypedefDecl, loc: /opt/clang+llvm-3.9.1-x86_64-linux-gnu-debian8/bin/../lib/clang/3.9.1/include/stdarg.h:30:27, usr: Some("c:@T@va_list")))

Do I miss something?

Those errors are non-fatal, does the generated code compile? You can post it here if you want.
If it doesn't, I bet this is #361, and you need to blacklist the functions that use varargs until we do it automatically.

We might want to make all the non-fatal error!(...)s into warn!(...)s, because I expect most people get confused. I know I did when I first started using bindgen.
Thoughts @emilio ?

Sounds good to me.

right, since I had no rpm.rs after my previous attempts (for some reason my package installed clang 3.8 was used) I did not check whether the aforementioned file has any content: actually it does.
I tried to compile the produced rpm.rs and it failed: from my inexperienced look, the problems are not related to the issues that led to this issue.  A couple of errors from running rustc on the rpm.rs:
error[E0428]: a type named `poptOption` has already been defined in this module
...
error: unions are unstable and possibly buggy (see issue #32836)
...
error: aborting due to 14 previous errors

and the union related error is the 13 beside the first one.

I forgot to mention:
$ rustc --version
rustc 1.14.0 (e8a012324 2016-12-16)

Ok, so the unions one is that by default we generate rust unions, which are nightly-only right now. We probably should change that default behavior.
Can you call bindgen with --no-unstable-rust, and see if that makes things better? The poptOption error seems interesting.

As you suggested, I run bindgen with --no-unstable-rust option. The compilation of the resulting rpm.rs failed with
error[E0428]: a type named `poptOption` has already been defined in this module
    --> rpm.rs:1246:1
     |
1176 | pub struct poptOption {
     | - previous definition of `poptOption` here
...
1246 | pub type poptOption = *mut poptOption;
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ already defined

error: main function not found

error[E0391]: unsupported cyclic reference between types/traits detected
    --> rpm.rs:1246:28
     |
1246 | pub type poptOption = *mut poptOption;
     |                            ^^^^^^^^^^ cyclic reference
     |
     = note: the cycle begins when processing `poptOption`...
     = note: ...which then again requires processing `poptOption`, completing the cycle.

error: aborting due to previous error

main function not found is understandable, the rest is not that much.
poptOption comes from popt (#include <popt.h>) library and it has this:
struct poptOption {
...
};
...
#ifndef __cplusplus
/*@-exporttype -typeuse@*/
typedef struct poptOption * poptOption;
/*@=exporttype =typeuse@*/
#endif
...

Yup! passing -x c++ to bindgen like:
./bindgen wrapper.h --output=rpm.rs --no-unstable-rust -- -x c++

Should make it work.

That's... Interesting!
Do you have the definition of the struct that is causing those?

this comes from <bits/timex.h>, I believe, which means that bindgen tries to generate for all things system.
what I want is to generate bindings for rpm related headers only, is there an easy way to do that?
the code rustc complains about:

#[repr(C)]
#[derive(Debug, Copy)]
pub struct timex {
    pub modes: ::std::os::raw::c_uint,
    pub offset: __syscall_slong_t,
    pub freq: __syscall_slong_t,
    pub maxerror: __syscall_slong_t,
    pub esterror: __syscall_slong_t,
    pub status: ::std::os::raw::c_int,
    pub constant: __syscall_slong_t,
    pub precision: __syscall_slong_t,
    pub tolerance: __syscall_slong_t,
    pub time: timeval,
    pub tick: __syscall_slong_t,
    pub ppsfreq: __syscall_slong_t,
    pub jitter: __syscall_slong_t,
    pub shift: ::std::os::raw::c_int,
    pub stabil: __syscall_slong_t,
    pub jitcnt: __syscall_slong_t,
    pub calcnt: __syscall_slong_t,
    pub errcnt: __syscall_slong_t,
    pub stbcnt: __syscall_slong_t,
    pub tai: ::std::os::raw::c_int,
    pub _bitfield_1: u32,
    pub _bitfield_2: u32,
    pub _bitfield_3: u32,
    pub _bitfield_4: u32,
    pub _bitfield_5: u32,
    pub _bitfield_6: u32,
    pub _bitfield_7: u32,
    pub _bitfield_8: u32,
    pub _bitfield_9: u32,
    pub _bitfield_10: u32,
    pub _bitfield_11: u32,
}
#[test]
fn bindgen_test_layout_timex() {
    assert_eq!(::std::mem::size_of::<timex>() , 208usize);
    assert_eq!(::std::mem::align_of::<timex>() , 8usize);
}
impl Clone for timex {
    fn clone(&self) -> Self { *self }
}
impl timex {
    #[inline]
    pub fn at_offset_0(&self) -> ::std::os::raw::c_int {
        unsafe {
            ::std::mem::transmute(((self._bitfield_1 &
<PHONE_NUMBER>usize as u32)) >> 0u32) as
                                      u32)
        }
    }
    ...
    #[inline]
    pub fn at_offset_0(&self) -> ::std::os::raw::c_int {
        unsafe {
            ::std::mem::transmute(((self._bitfield_2 &
<PHONE_NUMBER>usize as u32)) >> 0u32) as
                                      u32)
        }
    }
    ...

Yes, you should whitelist the rpm stuff you want, using regexes.
For example: `--whitelist-function "rpm.*".

@sa2ajj are you still hitting this on master? If so, the best way to contribute to resolving this bug would be to create a reduced test case.

sorry for a slow follow-up: i'll check it during the coming weekend :/

I've managed to use bindgen to produce a Rust binding for librpm.so, librpmio.so, librpmbuild.so, and librpmsign.so (heads up @sa2ajj):
https://github.com/iqlusion-io/crates/tree/master/rpmlib-sys
I should start by noting that all of the issues being discussed in this thread, at least for me, have been fixed, and IMO the issue can probably be closed.
I ran into several other issues, most of which I've managed to address. Many of them were fixed by having bindgen build a C++ binding instead of a C one. If you want the gorey details you can read about them here:
https://github.com/iqlusion-io/crates/issues/11
https://github.com/iqlusion-io/crates/issues/12

Ok, I'll close this based on that, thanks @tarcieri!

iqlusion-io/crates#11 should be fixed with rust_target(1.25), since that supports repr(align).
iqlusion-io/crates#12 is kind of hard to fix without introducing more complex opt-in name namespacing, but it's tracked on #1252.

@emilio thanks for the pointers... looks like #1252 is about the same silly header fileI was having trouble with on https://github.com/iqlusion-io/crates/issues/12 ! Glad I found a workaround.


404 errors after changes with HMR

Issue Overview
After making changes to the .ts or .html file for a component and HMR running via npm start, get http://localhost:8080/component.html not found 404
Issue Description
Randomly after working in the project for a while and making saves and updates, the HRM will fail with an error on a Promise for polyfills.dll.js
GET http://localhost:8080/<component>.html 404 (Not Found)
scheduleTask @ polyfills.dll.js:8723
ZoneDelegate.scheduleTask @ polyfills.dll.js:7586
Zone.scheduleMacroTask @ polyfills.dll.js:7512
(anonymous) @ polyfills.dll.js:8746
send @ VM1008:3
ResourceLoaderImpl.get @ vendorDll.dll.js:39976
DirectiveNormalizer._fetch @ vendorDll.dll.js:20214
DirectiveNormalizer.normalizeTemplateAsync @ vendorDll.dll.js:20248
DirectiveNormalizer.normalizeTemplate @ vendorDll.dll.js:20228
CompileMetadataResolver._loadDirectiveMetadata @ vendorDll.dll.js:21474
(anonymous) @ vendorDll.dll.js:21715
(anonymous) @ vendorDll.dll.js:21630
CompileMetadataResolver.loadNgModuleMetadata @ vendorDll.dll.js:21630
RuntimeCompiler._loadModules @ vendorDll.dll.js:33055
RuntimeCompiler._compileModuleAndComponents @ vendorDll.dll.js:33025
RuntimeCompiler.compileModuleAsync @ vendorDll.dll.js:33015
PlatformRef_._bootstrapModuleWithZone @ vendorDll.dll.js:23869
PlatformRef_.bootstrapModule @ vendorDll.dll.js:23851
startApp @ main.ts:18
ZoneDelegate.invoke @ polyfills.dll.js:7573
Zone.run @ polyfills.dll.js:7455
(anonymous) @ polyfills.dll.js:7843
ZoneDelegate.invokeTask @ polyfills.dll.js:7606
Zone.runTask @ polyfills.dll.js:7495
drainMicroTaskQueue @ polyfills.dll.js:7742

polyfills.dll.js:7729 Unhandled Promise rejection: Failed to load <component>.html ; Zone: <root> ; Task: Promise.then ; Value: Failed to load <component>.html undefined
consoleError @ polyfills.dll.js:7729
_loop_1 @ polyfills.dll.js:7758
drainMicroTaskQueue @ polyfills.dll.js:7762
ZoneTask.invoke @ polyfills.dll.js:7680
polyfills.dll.js:7731 Error: Uncaught (in promise): Failed to load <component>.html
    at resolvePromise (polyfills.dll.js:7809)
    at resolvePromise (polyfills.dll.js:7794)
    at polyfills.dll.js:7843
    at ZoneDelegate.invokeTask (polyfills.dll.js:7606)
    at Zone.runTask (polyfills.dll.js:7495)
    at drainMicroTaskQueue (polyfills.dll.js:7742)
    at XMLHttpRequest.ZoneTask.invoke (polyfills.dll.js:7680)

Once this occurs, it's impossible to fix no matter how many times I rebuild the dlls or re-run npm start or empty the browser cache.
Reproducables
Very difficult to reproduce and have not been able to guarantee reproduction. Only solution has been to full re-clone the repo and start over with a new npm i. It works for a while and then will crash again and never come back.
Information

Operating System
OSX

Node version
6.9.2

NPM Version
3.10.9

Environment
Browser

@theentirety , Sorry, can you share your repo?
Also I assume you use ./ for all templateUrls right?

Sorry, but I can't share the repo. I'm not sure which version as I didn't create the repo, but it was within the last week. Yes, all of the paths use ./ for the templateUrls.

can you try on latest rc.1 starter? @theentirety

Yes, I'm fully up to date and just pulled in the latest changes (jit) and still having the problem. Here is the output from npm run stat:
Angular Webpack Starter  1.0.0
Environments:
- Loaded  13  values from  .env  file
- NODE_ENV:  undefined
- APP_ENV:  local

Dependencies:
- Main Dependencies:  73
- Dev Dependencies:  16

Application:
- module:  47
- component:  46
- pipe:  1
- directive:  0
- routes:  12
- spec:  2
- e2e spec:  1

As for the rc1 tag, I could certainly clone that and I'm sure it will run, but we've already pulled in a lot of code and I won't be able to repro. Unless there is a way to merge it in...

I see, so you local for APP_ENV, while by default, I use development for HMR activation, you can update it here, and try again
https://github.com/antonybudianto/angular-webpack-starter/blob/master/src/main.ts#L14

I think I've narrowed it down to an issue with typescript and the tsconfig file. Your environment suggestion is unrelated. I am trying to get local typescript development to work properly with node, but when I added/modified the tsconfig to change from:
{
    "compilerOptions": {
        "target": "es5",
        "module": "es6",
        "moduleResolution": "node",
        "sourceMap": true,
        "emitDecoratorMetadata": true,
        "experimentalDecorators": true,
        "removeComments": false,
        "noImplicitAny": false,
        "typeRoots": [
            "node_modules/@types"
        ]
    },
    "awesomeTypescriptLoaderOptions": {
        "useWebpackText": true
    },
    "exclude": [
        "node_modules",
        "coverage",
        "config",
        "dist",
        "report"
    ]
}

to:
{
    "compilerOptions": {
        "target": "es5",
        "module": "es6",
        "moduleResolution": "node",
        "sourceMap": true,
        "emitDecoratorMetadata": true,
        "experimentalDecorators": true,
        "removeComments": false,
        "noImplicitAny": false,
        "typeRoots": [
            "../node_modules/@types"
        ],
        "types": [
            "core-js",
            "node"
        ]
    },
    "awesomeTypescriptLoaderOptions": {
        "useWebpackText": true
    },
    "exclude": [
        "node_modules",
        "coverage",
        "config",
        "dist",
        "report"
    ]
}

My change allows for my IDE (atom) to properly handle the typescript, but it causes the missing files error (I think). However, upon reverting the file, the errors persist. I've tried cleaning the dll, but there is something that is not compiling properly. Still investigating...

No, it's related if you don't update https://github.com/antonybudianto/angular-webpack-starter/blob/master/src/main.ts#L14 to local, since it won't do hmrBootstrap at all if the env is mismatched

We changed the name of the variable in the .env file to match so it is APP_ENV=local in the .env file. If there are other hidden places where the environment is hardcoded, please tell me so that I can make sure this is updated, but the starter should allow for the environment name to be changed without failing.

i put environmental on main.ts and polyfills.ts

I'm confused on "../node_modules/@types", do you change around the starter structure?
If so, then I can't help much, sorry.

I'm fairly convinced this is an issue with Atom playing nice with TypeScript and Webpack. Atom is having problems dealing with the node modules and the webpack config is very specific and they don't work well. I think the bug is actually making the starter work with Atom properly. I think there are some configs that need to be set to make that happen, but I haven't had much luck yet getting it to work.


DNM: Error clustersync controller for backoff

Without this commit, the clustersync controller returns reconcile.Result{Requeue: true, RequeueAfter: 0}, nil when it fails to apply any syncset resource. I.e. "This is not an error, but requeue this request immediately". Per the referenced card, and from activity seen in SD aka HCM when a syntax error was causing a large number of syncset failures, we suspected that this was actually requeueing such requests immediately, resulting in thrashing. This commit was conceived to return a non-nil error in these cases, on the theory that this would cause the rate limiter to kick in and back off the requests exponentially.
However, it was discovered that the rate limiter is doing its thang anyway. So we don't need to do anything here.
HIVE-2585

See referenced card for "evidence".


DOC-34: Document search validation

The following validation is applied to document search requests:

Document type or metadata criteria must be supplied
Metadata property values must be non null or empty strings

In addition, document types that the client does not have permission to view, e.g. Subject Access Request Reports, will be filtered out of the results.

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (883afa3) 92.19% compared to head (61d6525) 92.34%.

Files
Patch %
Lines

...mentmanagementapi/service/DocumentSearchService.kt
66.66%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #25      +/-   ##
============================================
+ Coverage     92.19%   92.34%   +0.15%
- Complexity      139      159      +20
============================================
  Files            29       31       +2
  Lines           602      627      +25
  Branches         36       40       +4
============================================
+ Hits            555      579      +24
  Misses           41       41
- Partials          6        7       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Private GM roll not private :)

Hello,
There's a problem with your module Chat images.... when a player roll a private GM roll or Blind GM roll, a bubble say the result ... and if I turn your module off, I have not problem ...
It's a very good module, I like it but is it possible to fixe that ?
thx for your help !
S.

Oh... ok. Did not test enough with chat bubbles. I'm gonna fix that. I think I know the problem.

Fixed in v1.1.3.


OPNsense 24.7 - support unicast CARP announcements

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
FreeBSD 14.x support unicast carp announcements, which would be practical to offer in our gui as well.
Describe the solution you like
Add optional peer and peer6 values in Interfaces: Virtual IPs: Settings for carp type interfaces.
Describe alternatives you considered
none
Additional context
https://man.freebsd.org/cgi/man.cgi?carp

Nice, this saves a lot of headache when switches use igmp snooping or multicast storm protection.


bookkeeping: fix requestReponse_test.go

Test requestResponse does not take into account how golangs map's hash function distributes keys suedo randomly within the hash table.

solves #403


Parallel execution docs

Added for Document how to run tests in parallel issue. Added two new files - parallel-execution.md and parallel-timeline-report.png.
For java only but I think with some changes could be adapted for kotlin. Have used Maven only for dependencies and execution.  For Grade need to figure it out.
Maybe need a repository to store the source code files. Though it is pretty bare bones basic stuff.

Thanks @grasshopper7 - I'll have to have a look when I have a little more time, so I can try this out.

Quick remarks, sorry for being terse:

Don't use M versions. They're release mile stones and still unstable.
Listing all versions of all jars is unmaintainable and prone to change.
Don't use a features folder. Use java conventions and put the features in the same package as the runner. E.g. com.example.app.RunCucumberTest will automatically find all features in src/test/resources/com/example/app. This also removes some config.

Same for the glue. If its in a descendant package from the runner glue need not be configured.

Use Maven conventions and make sure the runner class ends with Test.java. E.g. RunCucumberTest.java. Maven will pick this up automatically. So then the config that references Runner.java can also be removed.

I would leave out the failsafe config all together. Just link the relevant maven documentation. This is Cucumber docs, not maven docs.

Looks pretty good!

Can you use hugo tags for versions? See the general cucumber-jvm install doc for examples

@mpkorstanje  Have updated the changes except for point 2.
Point 2 - Listing all versions of all jars is unmaintainable and prone to change. - Yep knew this one is gonna be a mess. Thought about mentioning latest version but the issue is with 4.3.0, it gets gherkin 5.1 and cucumber-expression 6.6.2, which are are not latest versions in repo.  Maybe mention something like - "Use the IDE to figure out transitive dependencies of cucumber-java8 to add in classpath". Any thoughts?
Point 6 - I would leave out the failsafe config all together. - Think it makes things clearer regarding failsafe configurations. Have kept the junit config and referred it from the testng part. Added links to community page of tools containing maven execution details inside the docs.
Point 3,4,5 - Done simplifies things a lot.
Point 1 - Don't use M versions. They're release mile stones and still unstable. - Updated.

@aslakhellesoy

Can you use hugo tags for versions? See the general cucumber-jvm install doc for examples

I added the version tags but it is showing 4.2.6 instead of latest 4.3.0. Any pointers how to fix this.
Even in installation page it is showing 4.2.6 but 4.3.0 for snapshot.

@grasshopper7 The versions are specified in data/versions.yaml. Whenever there is a new release, they should be updated, but sometimes we forget (as docs and code are separate projects). I' ve just updated the versions in this commit, so it should be ok now :)

@mlvandijk Version numbers are now updated.
I added the kotlin part. First time I tried anything in kotlin. Maybe there is a better approach.  Thanks.

This is a great start!
However, there are some points I want to mention (quickly read this document, I hope I will have more time later to do a more in-depth review) :-)

for the Maven dependencies it might be better to not specify concrete version numbers (in the document you use 4.2.6 but 4.3.0 is already available)
the thread IDs are not fixed (not always 13 and 14 like in the example) so this could be misleading
there is actually another way to run the tests by having the configuration directly inside of a JUnit runner like so:

import cucumber.api.cli.Main;
import org.junit.Test;

import static org.hamcrest.CoreMatchers.is;
import static org.junit.Assert.assertThat;

public class RestTest_IT {

    @Test
    public void test() {
        String[] arguments = new String[]{
                "--threads", "4",
                "-p", "json:target/json/test.json",
                "-p", "timeline:target/cucumber-parallel-report",
                "-p", "usage:target/cucumber-usage.json",
                "-p", "pretty",
                "-g", "your.glue.package",
                "path/to/features/"
        };
        int exitStatus = Main.run(arguments,
                Thread.currentThread().getContextClassLoader());
        assertThat(exitStatus, is(0));
    }
}

@laxersaz FYI: your first comment regarding Maven versions should be fixed by using the hugo tags (as mentioned above). @grasshopper7 - you might want to merge master into your branch ;)

@laxersaz Added my comments inline to your observations. Thanks.

This is a great start!
However, there are some points I want to mention (quickly read this document, I hope I will have more time later to do a more in-depth review) :-)

for the Maven dependencies it might be better to not specify concrete version numbers (in the document you use 4.2.6 but 4.3.0 is already available) -- Fixed it.

the thread IDs are not fixed (not always 13 and 14 like in the example) so this could be misleading -- Think it is a Java thing regarding thread ids. Also it is mentioned, that the results would be similar rather than exact

there is actually another way to run the tests by having the configuration directly inside of a JUnit runner like so: -- I think it belongs to a different guide dealing with cucumber-jvm execution methods. The run() method is called by the main() method (described in the CLI section), only the exit status is swallowed in the main() method. This can be used in a testng test method or in a java class also.

@laxersaz FYI: your first comment regarding Maven versions should be fixed by using the hugo tags (as mentioned above). @grasshopper7 - you might want to merge master into your branch ;)

My bad. Fixed it. Though the version needs to be updated again. Shows 4.3.0, though 4.3.1 is released.

Hi @grasshopper7 - this is a more elaborate addition than I expected; thank you! Sorry it took my longer than I would've liked to look into it in more detail. Overall it's really great. I do have some minor textual changes, and am wondering if we could make sure to limit duplication (i.e. not say the same thing in multiple places, but add links).

I committed the minor text changes. Will have a look into the others later today.

Just for continued / future reference @grasshopper7  (As this has gotten to be a heavily committed change), you're able to push up multiple commits in one go to the repo (Say 5 local commits in one go with a git push). Just so people monitoring don't need to check back as often

@luke-hill The multiple commits are probably due to @grasshopper7 accepting my suggested changes..

Just for continued / future reference @grasshopper7 (As this has gotten to be a heavily committed change), you're able to push up multiple commits in one go to the repo (Say 5 local commits in one go with a git push). Just so people monitoring don't need to check back as often

@luke-hill I accepted the changes suggested. Is there a way to avoid multiple commits for this? Thx.

@mlvandijk Made the changes other than the string templating and multiple runners.

@grasshopper7 Could you merge master into this branch again (I think the versions have been updated again). I'll try to create a parallel project from this guide to make sure I get actual parallel execution and have a look to see if I can think of a way to prevent duplication on the page (to keep it easy to maintain in the future).

@mlvandijk Removed the dependency addition for  JUnit and testng. Linked to existing documentatio. Updated kotlin string template. Removed duplication of timeline reporter to separate section. Tried to simplify multiple runners.

@mlvandijk Removed the dependency addition for  JUnit and testng. Linked to existing documentatio. Updated kotlin string template. Removed duplication of timeline reporter to separate section. Tried to simplify multiple runners.

@mlvandijk I found some issues in this. Just fixing them. Will create a new PR.

Sure, thanks!


fix endless loop with case in block

Codecov Report

Merging #93 into master will decrease coverage by 0.45%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   71.33%   70.88%   -0.46%
==========================================
  Files          39       39
  Lines        2962     2964       +2
  Branches       51       51
==========================================
- Hits         2113     2101      -12
- Misses        816      830      +14
  Partials       33       33

Impacted Files
Coverage Δ

src/tokentree/walk/WalkBlock.hx
90.19% <0%> (-3.69%)
:arrow_down:

src/tokentree/walk/WalkFieldDef.hx
84.09% <0%> (-11.37%)
:arrow_down:

src/tokentree/walk/WalkClass.hx
77.01% <0%> (-2.3%)
:arrow_down:

src/tokentree/walk/WalkTypedefBody.hx
81.91% <0%> (-2.13%)
:arrow_down:

src/tokentree/utils/TokenTreeCheckUtils.hx
43.23% <0%> (-0.5%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5caab0...175d348. Read the comment docs.


Kyrian-Unveiling the power of Celo Interoperability Solutions

Thanks for submitting this tutorial for Celo Sage
Before you hit "Create Pull Request", make sure you have read the Tutorial Contribution Guidelines and reviewed the Sample Tutorial Structure.
Please confirm the following before submitting your tutorial for review -

[ ] My tutorial follows the Tutorial Contribution Guidelines.
[x] The title of the Pull Request matches the title of my tutorial.
[x] I've followed the tutorial template structure.
[x] I've proofread the tutorial for spelling and grammar mistakes.
[x] I've thoroughly explained the code, with inline code comments and text explanations.
[x] I've run a linter & prettifier to format my code blocks.
[x] I've run the tutorial to test it and the code works.

NOTE: We cannot review your Pull Request if it does not meet the standard outlined above.
Reviewers - @joenyzio & @viral-sangani

Closing Celo Sage PRs


save and load

Hi, I'm trying to use torchpack to simplify my model, but I got confused while using the save and load part.
Now I can save the .pt file under the checkpoints dir using 'Saver()', but I don't know how to load the .pt file. Could you please give me some advice? Thank you!

You can simply load the saved checkpoint with torch.load() or io.load (from torchpack.utils).


False positive for error: TS2873: This kind of expression is always falsy.

🔎 Search Terms
"TS2873"
🕗 Version & Regression Information
Tested in 5.6.0-beta and 5.6.0-dev.20240801
⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.6.0-dev.20240801#code/DYUwLgBAbghsCuIBcEYDsCeEC8E32GAG4AoEgYwHs0BnS0AOmEoHMAKN2BECAH14jw0AExAAzAJZoQwgJQQAZAogBGCAHpocRLKIbNAWgB8gkeKkyK1Oo2bsuiRcrWaHIXfojG8BYCSA
💻 Code
let value: any = null;

console.log((value || undefined) && 1 / value); // -> undefined
console.log(value && 1 / value); // -> null

🙁 Actual behavior
"TS2873: This kind of expression is always falsy." is reported for undefined in the first log call.
🙂 Expected behavior
No error since undefined is affecting the behavior. Without undefined the expression evaluates to null.
Additional information about the issue
No response

@RyanCavanaugh still we can get for cases like
https://www.typescriptlang.org/play/?ts=5.6.2#code/C4TwDgpgBAyglgWzAGwgJQK6qgXigZ2ACc4A7AcygB8oAjAe3tQENTqoNSATCAMzIhd2pLMgBQYgMb1ShKLNxQAPGigQAHsAjd8sRCnRYIAPgAUGyJK1cAXAWJlyAGihEjdtAEpcxqAG8xKCgAemCoABUAeQARSLEAXwlZUwByFJdeZmR8aAAyXKgUm15GOmYiKBsAL3pgFM8xZJSEEAB9EvoyipbWmrqMrJzqGiKOrsq++sb8VPSoYgxoKhHi0tpyidqppp6x9e62yZcFvILRtY3qrYamuc4eflJBKHzC1c79zbqbmea2vY2PSOHG4fAEQmWbwBFSu32msxcImQyBeZ3e41h21+uwuB16W0RomGUNxXymQA

@piecyk no plans to change this. The type system isn't sound so there are many places where you might legitimately need to check a variable that the checker thinks is null but isn't. The check is only in place to detect syntactic errors, not semantic ones.


Grpc 1.10.1 C# may have some kind endless loop

What version of gRPC and what language are you using?
Grpc 1.10.1 C# from nuget
What operating system (Linux, Windows, …) and version?
windows server 2008 R2
What runtime / compiler are you using (e.g. python version or version of gcc)
.net 4.5
What did you do?
If possible, provide a recipe for reproducing the error. Try being specific and include code snippets if helpful.
I Wirte a simple server. After about 25 days normal run, It first occurred in my client, which use 100% of one of my cpu core. Then after few days, it occurs in server which use 100% of all my cpu core.
pretty sure, the endless loop is not in my code.
The client first said Deadline Exceeded, after few hours, It block and never return.
The server cost 100% cpu, and never service any client.
After restart, it becomes normal.
var options = new List<ChannelOption>()
                {
                    new ChannelOption(ChannelOptions.MaxSendMessageLength,16*1024*1024),
                    new ChannelOption(ChannelOptions.MaxReceiveMessageLength,16*1024*1024),
                    new ChannelOption(ChannelOptions.MaxConcurrentStreams,63),
                    new ChannelOption(ChannelOptions.SoReuseport,1),
                };

                string ip = "<IP_ADDRESS>";

                _server = new Server(options)
                {
                    Services = { HealthCheckService.BindService(new HealthCheckServiceImpl()),MonitorService.BindService(new MonitorServiceImpl()),ElectService.BindService(new SelfElectServiceImpl()),ConfigService.BindService(new ConfigServiceImpl()),},
                    Ports = { new ServerPort(ip,serverPort,ServerCredentials.Insecure) }
                };

                _server.Start();

What did you expect to see?
Client and server works normal

Thanks for reporting this. I'm not sure how to reproduce though - running a service for 25 days and hoping it's going to happen for me too doesn't seems like a good approach. Can you provide some additional info? (stacktrace, coredump, anything helps).

cc @sreecha - I think this sounds like the issue that is described and fixed in https://github.com/grpc/grpc/pull/14894

An interesting observation:   25 days in milliseconds in ~2.1 billion milliseconds  which is pretty close to  max_int for 32bit integers - 2,147,483,647 - and we are using milliseconds since process start internally to deal with deadlines in C core.
@luchunminglu to confirm this theory, are you running a 32bit version of the binary?  (if overflow is the issue, this would only happen with 32bit and 64bit would run normally).

@apolcyn  you were faster than me, I think this is really an instance of https://github.com/grpc/grpc/pull/14894

I run this as 32bit application on a 64bit OS

Pure Client seems work fine, It occured at server application and server&client application（it have a grpc server but also as a client to other grpc server）

I think this was fixed by https://github.com/grpc/grpc/pull/14894. Fix will be in the next release (v1.13.0).


fix: #1268 - add Invalidate button to the UI

Ticket #1268
Description
This fix adds an invalidate option to the UI for uploads. The Uploads page now has additional logic to show when something has been manually invalidated. A new download button was created. It looks identical to the smaller in-line version, but is a bigger button. Test cases have also been added.
A few pieces have been added to arpa reporting to show icons.
Screenshots / Demo Video

Testing
Upload two different templates with the same EC Code. Invalidate one, invalidate both, and revalidate.
Automated and Unit Tests

[x] Added Unit tests

Manual tests for Reviewer

[x] Added steps to test feature/functionality manually

Checklist

[x] Provided ticket and description
[x] Provided screenshots/demo
[x] Provided testing information
[x] Provided adequate test coverage for all new code
[x] Added PR reviewers

I'm still adding test cases and doing a little bit of touch ups, but I wanted to get the PR out for review.
The things remaining (that I am aware of):

Fix the Invalid Date in the Validation section when Invalidated
Add feedback from prior PR. There were a handful of comments
Add more test cases as I expect the test case coverage to fail given all the code I touched.

The test case failures are related to timezone. The UI takes the time and display it in the local timezone, which is different between my computer and the runner. I will see what I can do to fix the timezone on test cases.


Publish documentation for Application Insights

There are a few topics to cover:

Walk the user through how to set up Application Insights using the SDK elements.
Describe IBotTelemetryClient and how to overload the Dialog.TelemetryClient property.
Describe the telemetry being logged by the Waterfall Dialog.

Source material is here..

Telemetry content published.


ReadTheDocs build errors out on No module named 'myst_parser'

Describe the bug
Builds since 2 months ago on ReadTheDocs throw an error
ModuleNotFoundError: No module named 'myst_parser'

when building the pyenphase documentation
To Reproduce
Use Build on Readthe docs
Additional context
last successfull build.log
Last failed build.log
Failed log shows myst-parser is being installed
  - Installing myst-parser (2.0.0)

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/pyenphase/envs/latest/lib/python3.11/site-packages/sphinx/registry.py", line 447, in load_extension
    mod = import_module(extname)
          ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/.asdf/installs/python/3.11.6/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1140, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'myst_parser'

Pyenphase configuration files haven't changed to my knowledge.
Local build in my dev environment,fwiw, have no issue.

Log file shows myst-parser get's installed
Skipping virtualenv creation, as specified in config file.
Installing dependencies from lock file

  - Installing myst-parser (2.0.0)

python -m sphinx -T -b html -d _build/doctrees -D language=en . $READTHEDOCS_OUTPUT/html
Running Sphinx v7.2.6

Could not import extension myst_parser (exception: No module named 'myst_parser')

Installed but not available. Some issue with virtual environments?
Should we change
      # Tell poetry to not use a virtual environment
      - poetry config virtualenvs.create true

to false?

Setting virtualenvs.create true did not solve the issue. (https://readthedocs.org/projects/pyenphase/builds/24061834/)
poetry config virtualenvs.create true

is shown by the build, so it used the new one.
It installed myst parser
Creating virtualenv pyenphase-A-_cRjsQ-py3.11 in /home/docs/.cache/pypoetry/virtualenvs
Installing dependencies from lock file

  - Installing myst-parser (2.0.0)

but spit the same error
ModuleNotFoundError: No module named 'myst_parser'

Updated dependencies in #153 did not solve the RTD build issue. Leaves #152 to try.

#152 solved the issue :-).


hg38 to T2T v1.1 liftOver

Hello,
I am interested in changing some samples from hg38 to T2T v1.1, but in https://liftover.broadinstitute.org I see that it can only be done one at a time. Is there any way to pass more data together?
Thank you

liftover.broadinstitute.org works by running the UCSC liftover tool for each input (using this command ). The most efficient way to process many inputs would be for you to run the command-line tool directly on your data.
(If you want to convert intervals, the UCSC liftover tool is best - it can be downloaded from http://hgdownload.soe.ucsc.edu/admin/exe/. If you want to convert variants, I would use gatk LiftoverVCF. The chain files can be downloaded from the comment by slw287r
@  https://github.com/marbl/CHM13/issues/29 ).

Done! Thanks.


fix: merge schemas in allOf

anyOf elements in JSON Schema were handled, but allOf was not.  We use the existing _merge_object_schemas function to merge all of the schemas in allOf
Fixes #98.

Looks great! Thanks for the contribution!


fix: support node name and node output name not same

I hope https://github.com/gmalivenko/onnx-opcounter/pull/6 would solve this


Major Project - Timmie

In addition to the requested changes, could you bump the date up on this post (both filename and metadata)?


WIP: generate secrets for dynamic clients

Signed-off-by: Monis Khan<EMAIL_ADDRESS>

Will replace this soon with a new PR which uses the code and conversations from this PR as its starting point.

Replaced by https://github.com/vmware-tanzu/pinniped/pull/1273 (which is currently a work in progress PR).


top command does not reflect processes' memory usage

Please use the following bug reporting template to help produce actionable and reproducible issues. Please try to ensure that the reproduction is minimal so that the team can go through more bugs!

A brief description
The top command reports memory usage of 0 (zero) for VIRT, RES, & SHR memory for all processes. Note this seems to affect all processes launched from bash, but the example is a python script for convenience.

Expected results
I would expect top to produce relevant memory usage of all processes running under WSL, reflecting values as shown within Task Manager.

Actual results (with terminal output if applicable)
Example output with a long running python script:

  PID USER      PR  NI    VIRT    RES    SHR S  %CPU %MEM     TIME+ COMMAND
 1713 nernst    20   0       0      0      0 R  99.3  0.0   5:36.94 python3
    1 root      20   0       0      0      0 S   0.0  0.0   0:00.01 init
    2 nernst    20   0       0      0      0 S   0.0  0.0   0:00.54 bash
 1649 nernst    20   0       0      0      0 S   0.0  0.0   0:00.48 bash
 1731 nernst    20   0       0      0      0 R   0.0  0.0   0:00.18 top

Your Windows build number
Microsoft Windows [Version 10.0.14951]

Steps / All commands required to reproduce the error from a brand new installation
Create a python script with:

#!/usr/bin/env python3

data = " " * 10**8

while True:
        pass

Invoke it directly from bash, or by specifying the python3 interpreter. In Task Manager, you should be able to find a Python3 instance using ~98 MB of RAM. If you run top, VIRT, RES & SHR will report 0.

Strace of the failing command
Not applicable.

Required packages and commands to install
python or python3 (both should be available by default install)

See our contributing instructions for assistance.

Thanks for reporting the issue, a fix for this should be out for insider builds soon.


Add glob support for fragments

It would be nice to pass fragments into resolveGlob as well as sourceGlobs are processed:
"fragments": "/src/pages/**/*"

Wondering how many fragments the project where I needed this has nowadays 🙂 Closing.


navigation: make ShopDemo title a link to the entry place

There should be an easy way to get to the entry page, like in the widget browser.

Fixed on master (v1.7.0)