WatchOS App not reporting any fatal crashes

Description
Expected: fatalError() test crash should be reported to Crashlytics in a WatchOS app.
Actual: only non-fatals are reported
I setup a new iOS app and added a WatchOS companion app to it, then added Crashlytics according to the instructions using SPM. DSYMs are uploaded as they should and this is verified by using the record method and using a custom error. When triggering a crash using fatalError() no crash is recorded or sent to Crashlytics. The crash was done in the simulator and not attached to the debugger at the time. In another project testing was done on device with the same result.
The output of the sdk.log after starting in debug after the crash was:
When adding the same setup to the iOS app everything works as expected.
Reproducing the issue

Create a new iOS app
Create a WatchOS companion App
Add Firebase, DSYMs upload and the GoogleService-Info.plist according to instructions
Add setup of firebase in App

Expand App.swift
import FirebaseCore
import SwiftUI
import WatchKit

@main
struct CrashTestWatch_Watch_AppApp: App {

    @WKApplicationDelegateAdaptor(WatchAppDelegate.self) private var appDelegate

    var body: some Scene {
        WindowGroup {
            ContentView()
        }
    }
}

class WatchAppDelegate: NSObject, WKApplicationDelegate {

    func applicationDidFinishLaunching() {
        print(NSHomeDirectory())
        FirebaseApp.configure()
    }
}

5. Configure view to test crash

Expand ContentView.swift
import SwiftUI
import FirebaseCrashlytics

enum TestError: Error {

    case nonFatal(String)
}

struct ContentView: View {
    var body: some View {
        VStack {
            Button {
                fatalError("Good bye, cruel world")
            } label: {
                HStack {
                    Image(systemName: "exclamationmark.octagon")
                    Text("Fatal Error")
                }.padding()
            }
            Button {
                Crashlytics.crashlytics().record(error: TestError.nonFatal("This is fine"))
            } label: {
                HStack {
                    Image(systemName: "exclamationmark.triangle")
                    Text("Non-fatal")
                }.padding()
            }
        }
        .padding()
    }
}

struct ContentView_Previews: PreviewProvider {
    static var previews: some View {
        ContentView()
    }
}

6. Test crash according to instructions without debugger attached
Firebase SDK Version
9.6.0
Xcode Version
14.2
Installation Method
Swift Package Manager
Firebase Product(s)
Crashlytics
Targeted Platforms
watchOS
Relevant Log Output
WARN  [FIRCLSContextInitialize:208] Debugger present - not installing handlers
WARN  [FIRCLSFileReadSections:631] Unable to read file /Users/tobiasboogh/Library/Developer/CoreSimulator/Devices/356B6AFD-90EA-43A6-887D-6D18217730FF/data/Containers/Data/Application/4715F074-E603-47B4-9A9C-61940D5EDE4A/Library/Caches/com.crashlytics.data/com.boogh.CrashTest.watchkitapp/v5/reports/processing/fe1585df1ad148b5a9f759d1db991d7e/exception.clsrecord
WARN  [FIRCLSFileReadSections:631] Unable to read file /Users/tobiasboogh/Library/Developer/CoreSimulator/Devices/356B6AFD-90EA-43A6-887D-6D18217730FF/data/Containers/Data/Application/4715F074-E603-47B4-9A9C-61940D5EDE4A/Library/Caches/com.crashlytics.data/com.boogh.CrashTest.watchkitapp/v5/reports/processing/fe1585df1ad148b5a9f759d1db991d7e/signal.clsrecord
WARN  [FIRCLSFileReadSections:631] Unable to read file /Users/tobiasboogh/Library/Developer/CoreSimulator/Devices/356B6AFD-90EA-43A6-887D-6D18217730FF/data/Containers/Data/Application/4715F074-E603-47B4-9A9C-61940D5EDE4A/Library/Caches/com.crashlytics.data/com.boogh.CrashTest.watchkitapp/v5/reports/processing/fe1585df1ad148b5a9f759d1db991d7e/metric_kit_fatal.clsrecord
WARN  [FIRCLSFileReadSections:631] Unable to read file /Users/tobiasboogh/Library/Developer/CoreSimulator/Devices/356B6AFD-90EA-43A6-887D-6D18217730FF/data/Containers/Data/Application/4715F074-E603-47B4-9A9C-61940D5EDE4A/Library/Caches/com.crashlytics.data/com.boogh.CrashTest.watchkitapp/v5/reports/processing/fe1585df1ad148b5a9f759d1db991d7e/custom_fatal.clsrecord

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

{
  "pins" : [
    {
      "identity" : "abseil-cpp-swiftpm",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/firebase/abseil-cpp-SwiftPM.git",
      "state" : {
        "revision" : "583de9bd60f66b40e78d08599cc92036c2e7e4e1",
        "version" : "0.20220203.2"
      }
    },
    {
      "identity" : "boringssl-swiftpm",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/firebase/boringssl-SwiftPM.git",
      "state" : {
        "revision" : "dd3eda2b05a3f459fc3073695ad1b28659066eab",
        "version" : "0.9.1"
      }
    },
    {
      "identity" : "firebase-ios-sdk",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/firebase/firebase-ios-sdk",
      "state" : {
        "revision" : "7e80c25b51c2ffa238879b07fbfc5baa54bb3050",
        "version" : "9.6.0"
      }
    },
    {
      "identity" : "googleappmeasurement",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/GoogleAppMeasurement.git",
      "state" : {
        "revision" : "c1cfde8067668027b23a42c29d11c246152fe046",
        "version" : "9.6.0"
      }
    },
    {
      "identity" : "googledatatransport",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/GoogleDataTransport.git",
      "state" : {
        "revision" : "f6b558e3f801f2cac336b04f615ce111fa9ddaa0",
        "version" : "9.2.1"
      }
    },
    {
      "identity" : "googleutilities",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/GoogleUtilities.git",
      "state" : {
        "revision" : "0543562f85620b5b7c510c6bcbef75b562a5127b",
        "version" : "7.11.0"
      }
    },
    {
      "identity" : "grpc-ios",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/grpc/grpc-ios.git",
      "state" : {
        "revision" : "8440b914756e0d26d4f4d054a1c1581daedfc5b6",
        "version" : "1.44.3-grpc"
      }
    },
    {
      "identity" : "gtm-session-fetcher",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/gtm-session-fetcher.git",
      "state" : {
        "revision" : "5ccda3981422a84186387dbb763ba739178b529c",
        "version" : "2.3.0"
      }
    },
    {
      "identity" : "leveldb",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/firebase/leveldb.git",
      "state" : {
        "revision" : "0706abcc6b0bd9cedfbb015ba840e4a780b5159b",
        "version" : "1.22.2"
      }
    },
    {
      "identity" : "nanopb",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/firebase/nanopb.git",
      "state" : {
        "revision" : "819d0a2173aff699fb8c364b6fb906f7cdb1a692",
        "version" : "2.30909.0"
      }
    },
    {
      "identity" : "promises",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/promises.git",
      "state" : {
        "revision" : "3e4e743631e86c8c70dbc6efdc7beaa6e90fd3bb",
        "version" : "2.1.1"
      }
    },
    {
      "identity" : "swift-protobuf",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/apple/swift-protobuf.git",
      "state" : {
        "revision" : "ab3a58b7209a17d781c0d1dbb3e1ff3da306bae8",
        "version" : "1.20.3"
      }
    }
  ],
  "version" : 2
}

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

Thanks for reporting this, @tboogh. It looks like your issue is related to #6843. As mentioned on this https://github.com/firebase/firebase-ios-sdk/issues/6843#issuecomment-730557274, SwiftUI crashes are mach-exception crashes so they will not be detected on watchOS.

Thanks for reporting this, @tboogh. It looks like your issue is related to #6843. As mentioned on this https://github.com/firebase/firebase-ios-sdk/issues/6843#issuecomment-730557274, SwiftUI crashes are mach-exception crashes so they will not be detected on watchOS.

Thanks for info, missed that the issue was a duplicate.

Closing in favor of #6843


Remove unused features in syn

A lot of features in syn are enabled by default even though we don't use them. We should check which features we actually use and opt out all the others.

I opened https://github.com/gtk-rs/gtk-rs/pull/432 mostly for consistency.
I do not think there is much else we can do, since we depend from many other crates like futures-macro which also enable the full feature so even if we further customize the feature set, they would still get compiled:
https://github.com/rust-lang/futures-rs/blob/master/futures-macro/Cargo.toml

Why do we depend on futures-macro (except for the tests via dev-dependencies)?

Why do we depend on futures-macro (except for the tests via dev-dependencies)?

It comes from futures-util with the default async-await-macro feature. Do we need that one?

No we don't. But why do we depend on futures-util still outside of dev-dependencies for the tests?

Aha, it comes from the default features of futures-executor https://github.com/rust-lang/futures-rs/blob/master/futures-executor/Cargo.toml#L16

So should make that default-features = false too, but we also only use that from dev-dependencies too :)


Facebook and Twitter headlines - magic wand closes form if char count limit surpassed

If you use the magic wand in the recirc area to populate either headline, if the character count is over the limit, it’ll close the form

fixed in commit 6eb20f8


PSReadline crashes PowerShell when PSReadline is installed but not auto-imported when calling 'powershell -noprofile'

Environment data
PSReadline version: 1.2
os: 6.3.9600.16384 (winblue_rtm.130821-1623)
PS file version: 10.0.14409.1005 (rs1_srvoob.161208-1155)
> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.14409.1012
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14409.1012
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Steps to reproduce or exception report
On a WinServer 2012 R2 machine, PSReadline 1.2 is installed but does not get auto-loaded in the ISE.
I tried to do a powershell -noprofile and then PSReadline completely crashed PowerShell and it ended up in a hanging state:
PS >  powershell -noprofile
Windows PowerShell
Copyright (C) 2016 Microsoft Corporation. All rights reserved.

PS >
Oops, something went wrong.  Please report this bug with the details below.
Report on GitHub: https://github.com/lzybkr/PSReadLine/issues/new
-----------------------------------------------------------------------
Last 0 Keys:

Exception:
System.IO.IOException: The handle is invalid.

   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.Console.GetBufferInfo(Boolean throwOnNoConsole, Boolean& succeeded)
   at Microsoft.PowerShell.Internal.ConhostConsole.get_CursorLeft()
   at Microsoft.PowerShell.PSConsoleReadLine.Initialize(Runspace runspace, EngineIntrinsics engineIntrinsics)
   at Microsoft.PowerShell.PSConsoleReadLine.ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics)

This particular exception is just saying that stdin is redirected, 2.0.0-beta1 should handle this situation more gracefully.
If this is just in the ISE - then I think the hang is expected - it doesn't support an interactive console process, see this list:
#2 PS>$psUnsupportedConsoleApplications
wmic
wmic.exe
cmd
cmd.exe
diskpart
diskpart.exe
edit.com
netsh
netsh.exe
nslookup
nslookup.exe
powershell
powershell.exe

Ok. The reason why it only happened in the ISE was because PSReadLine already gets auto-discovered/loaded in powershell.exe
I would need to check what happened if I changed the auto-loading preference but if you say that the pre-releases handle it already better then that's OK.


Adds isin method to dask.dataframe.DataFrame

Fixes issue #2071. This PR adds an isin method to dask.dataframe.DataFrame (which is already implemented in dask.dataframe.Series). Also, the API documentation is updated accordingly through use of the derived_from decorator in dask.utils.

Thanks @jrbourbeau !


Windows Authentication Events

It would be nice if the AuthenticationHandler provided an event or events.
These are available on most, if not all, of the other AspNetCore authentication providers. This feature was also available in the old .NET: WindowsAuthenticationModule.Authenticate Event
This would enable you to perform one-time actions when authentication has occurred. The unsavory alternative is to add middleware that must check on every request to see if authentication has occurred and set/check a flag indicating that the desired actions have not been already been ran.

Interesting idea. Your comments about a one time action confuse me though. Windows Auth happens on every request*, it's not a one time event like OAuth or forms auth. What kind of action did you plan to take?

technically windows auth can happen once per connection and be recycled on each request, but that information isn't surfaced to us, we don't know if this is the first request or 10th on a connection. And the user authenticates again when they open another connection, even if the first is still open.

Note the description of the old WindowsAuthentication_OnAuthenticate method implies it's also invoked per request.

Well that's embarrassing! I apologize, I am in the process of porting something from WS-Federation to Windows Auth, and it's my first time working with it.
If there was an event, I would have quickly figured out how often it authenticates ;)
Having it per-request actually works fine with how I plan to use it. It could still be duplicated with custom middleware, but it would be more logical to be able to "finish out" my authentication within the actual authentication handler instead of creating a FinishAuthenticationMiddleWare to do it.

IClaimsTransformation is one way of doing this. It's run by the UseAuthentication middleware after authentication. @HaoK do you have a quick doc or sample for this?

https://github.com/aspnet/AuthSamples/tree/dev/samples/ClaimsTransformation

Thank you, @Haok. This seems to be what I'm looking for, but I'm having a little bit of trouble.
TransformAsync never gets called when Anonymous Authentication is enabled. If anonymous authentication is disabled, it will work.
Can you explain why that would be the case? I would expect TransformAsync to still be called on requests where [Authorize] is involved.

AnonymousAuthentication = true means don't do authentication so as a result claims transformation won't run since its run after a successful Authenticate

I don't know what issue I was having yesterday, but while fiddling with something else, it began working. I'm also able to get it to work fine in the ClaimsTransformation AuthSample. Sorry!
However, there's another quirk with IClaimsTransformation that is proving a bit problematic. I am injecting IHttpContextAccessor into the constructor in order to access Session. TransformAsync gets called 2-4 times per request (which is fine), but Session is not consistently available in every call.
The first call will always throw an InvalidOperationException "Session has not been configured for this application or request.".  The second call will have a working Session. Beyond that, sometimes the last call will have the same exception. I have not yet been able to put together a pattern for when the 3rd or 4th call will have Session available.
Due to this, I think I will have to rely on using custom middleware so I can be sure that it takes place post-authentication and has Session available.

That sounds like a Startup ordering issue. Session is not available until after the UseSession middleware. That said, beware of storing any auth information in session.
It's likely that the first call happens in the IISIntegration middleware, the second in the auth middleware. No idea about 3 and 4, are you sure those are the same request and not a parallel request for something like favicon.ico?
For Windows Auth you can either get rid of the auth middleware, or turn off auto-auth in the IIS middleware to prevent redundant calls.
            services.Configure<IISOptions>(options =>
            {
                options.AutomaticAuthentication = false;
            });

You're right about the further calls, they are for CSS/JS components. Those then get cached, which explains the inconsistency in number of calls. Don't worry, I'm not storing auth information into session. I just need to make use of the session ID.
As for the first two calls, I don't believe it's a startup ordering issue.
I am testing this using the provided sample. The only changes I have made were to add the Microsoft.AspNetCore.Session package, services.AddSession() and app.UseSession() in their respective places, then a singleton binding for IHttpContextAccessor, which is then injected into the IClaimsTransformation.
    public void ConfigureServices(IServiceCollection services)
    {
        services.AddSession();
        services.AddAuthentication(IISDefaults.AuthenticationScheme);
        services.AddMvc();

        // claims transformation is run after every Authenticate call
        services.AddTransient<IClaimsTransformation, ClaimsTransformer>();
        services.AddSingleton<IHttpContextAccessor, HttpContextAccessor>();
        services.Configure<IISOptions>(options =>
        {
            options.AutomaticAuthentication = false;
        });
    }

    public void Configure(IApplicationBuilder app, IHostingEnvironment env)
    {
       [ ... exception page stuff ... ]

        app.UseStaticFiles();
        app.UseSession();
        app.UseAuthentication();
        app.UseMvc([ ... default route ... ]);
    }

With this startup configuration, the first call to TransformAsync will be unable to use Session.
I realize I'm getting a bit beyond the scope of my original question. I don't want to waste anyone's time, so let me know if this is no longer an IISIntegration issue.

Yes, this is still an ordering issue but it might not be one you can fix. IISIntegration calls AuthenticateAsync before any other middleware in Configure.
https://github.com/aspnet/IISIntegration/blob/6e54256fca6f2ae25525bfbc0a7ca966e0d1780d/src/Microsoft.AspNetCore.Server.IISIntegration/IISMiddleware.cs#L133-L137
Hmm, AutomaticAuthentication isn't checked early enough to prevent this, nor can we move it because it really needs to run to make sure the handle gets registered and disposed properly.

@Tratcher What's the verdict here? Something we can fix in IISIntegration?

Adding events would be doable, but their value would be pretty limtied. You could add events for AuthenticateAsync, ChallengeAsync, and ForbidAsync, but I'm not sure how much you could do in those scenarios.
https://github.com/aspnet/IISIntegration/blob/3761667e3611dd07c1be9e2ea113a21a3df15e29/src/Microsoft.AspNetCore.Server.IISIntegration/AuthenticationHandler.cs
Recommend backlog for the events feature.
As for the ordering issue with session... https://github.com/aspnet/IISIntegration/issues/761#issuecomment-380120276
https://github.com/aspnet/IISIntegration/issues/761#issuecomment-380183841
We could restructure this if we really needed to so that IISIntegration loaded the user without calling GetUser. However, that would break anyone currently relying on IClaimsTransformation getting called without UseAuthentication.
Also recommending backlog for the initialization issue.
@norachuga or @shirhatti can you split these into two seperate bugs?

@Tratcher I'm assuming we won't be able to do it since it's a breaking change, right?


[SPARK-46698][CORE][3.5] Replace Timer with single thread scheduled executor for ConsoleProgressBar

-> This is the first commit for fixing SPARK-49479 in branch 3.5.
Second commit for fixing SPARK-49479 in branch 3.5: #47945
Third commit for fixing SPARK-49479 in branch 3.5: #47956
What changes were proposed in this pull request?
This PR propose to replace Timer with single thread scheduled executor for ConsoleProgressBar.
Why are the changes needed?
The javadoc recommends ScheduledThreadPoolExecutor instead of Timer.

This change based on the following two points.
System time sensitivity
Timer scheduling is based on the absolute time of the operating system and is sensitive to the operating system's time. Once the operating system's time changes, Timer scheduling is no longer precise.
The scheduled Thread Pool Executor scheduling is based on relative time and is not affected by changes in operating system time.
Are anomalies captured
Timer does not capture exceptions thrown by Timer Tasks, and in addition, Timer is single threaded. Once a scheduling task encounters an exception, the entire thread will terminate and other tasks that need to be scheduled will no longer be executed.
The scheduled Thread Pool Executor implements scheduling functions based on a thread pool. After a task throws an exception, other tasks can still execute normally.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
Manual tests.
Was this patch authored or co-authored using generative AI tooling?
'No'.

cc @beliefer


Add SITL testing for tailsitter VTOLs

Describe problem solved by this pull request
Since tailsitter vehicles have not been part of SITL testing, it is hard to identify regressions/issues. (e.g. https://github.com/PX4/Firmware/issues/16057)
Describe your solution
This enables SITL testing for Tailsitter vehicles
Additional context

This was mentioned on the dev call 28/Oct/2020

The SITL tests fail because it is slightly out of the mission waypoint corridor:
[mavsdk_tests] ../../../test/mavsdk_tests/autopilot_tester.cpp:540: FAILED:
[mavsdk_tests]   CHECK( distance_to_trajectory < corridor_radius_m )
[mavsdk_tests] with expansion:
[mavsdk_tests]   1.00713f < 1.0f
[mavsdk_tests] ../../../test/mavsdk_tests/autopilot_tester.cpp:540: FAILED:
[mavsdk_tests]   CHECK( distance_to_trajectory < corridor_radius_m )
[mavsdk_tests] with expansion:
[mavsdk_tests]   1.24893f < 1.0f
[mavsdk_tests] ../../../test/mavsdk_tests/autopilot_tester.cpp:540: FAILED:
[mavsdk_tests]   CHECK( distance_to_trajectory < corridor_radius_m )
[mavsdk_tests] with expansion:
[mavsdk_tests]   1.37518f < 1.0f
[mavsdk_tests] ../../../test/mavsdk_tests/autopilot_tester.cpp:540: FAILED:
[mavsdk_tests]   CHECK( distance_to_trajectory < corridor_radius_m )
[mavsdk_tests] with expansion:
[mavsdk_tests]   1.39157f < 1.0f
[mavsdk_tests] ../../../test/mavsdk_tests/autopilot_tester.cpp:540: FAILED:
[mavsdk_tests]   CHECK( distance_to_trajectory < corridor_radius_m )

@Jaeyoung-Lim I'm not surprized..

I will have a look if it can be easily improved with tuning.

Included in https://github.com/PX4/PX4-Autopilot/pull/16078


Update Dockerfile to run as non-root USER specified by UID.

The Checkov Dockerfile is currently running with default root privileges. It is good practice to user a non-root adds an extra layer of security.

docker docs & bitnami blog on dockerfile security.

$ docker run -it --entrypoint sh checkmarx/kics:latest-alpine
/app/bin # id
uid=0(root) gid=0(root) groups=0(root),1(bin),2(daemon),3(sys),4(adm),6(disk),10(wheel),11(floppy),20(dialout),26(tape),27(video)

Proposed Changes

Specification of the USER by UID not name.
Apply appropriate permissions to run.

This is the container after my changes have been applied
/app/bin $ id
uid=1000(Checkmarx) gid=1000(Checkmarx) groups=1000(Checkmarx)
/app/bin $ ls -la
total 53008
drwxr-xr-x    1 Checkmar Checkmar      4096 Aug 17 08:59 .
drwxr-xr-x    1 Checkmar Checkmar      4096 Aug 17 08:59 ..
drwxr-xr-x    5 Checkmar Checkmar      4096 Aug 17 08:59 assets
-rwxr-xr-x    1 Checkmar Checkmar  54263808 Aug 17 08:59 kics
/app/bin $ ls -la cd..
ls: cd..: No such file or directory
/app/bin $ ls -la ..
total 16
drwxr-xr-x    1 Checkmar Checkmar      4096 Aug 17 08:59 .
drwxr-xr-x    1 root     root          4096 Aug 17 09:38 ..
drwxr-xr-x    1 Checkmar Checkmar      4096 Aug 17 08:59 bin
/app/bin $ ls -la ../..
total 88
drwxr-xr-x    1 root     root          4096 Aug 17 09:38 .
drwxr-xr-x    1 root     root          4096 Aug 17 09:38 ..
-rwxr-xr-x    1 root     root             0 Aug 17 09:38 .dockerenv
drwxr-xr-x    1 Checkmar Checkmar      4096 Aug 17 08:59 app
drwxr-xr-x    2 root     root          4096 Aug  5 12:25 bin
drwxr-xr-x    5 root     root           360 Aug 17 09:38 dev
drwxr-xr-x    1 root     root          4096 Aug 17 09:38 etc
drwxr-xr-x    1 root     root          4096 Aug 17 08:57 home
drwxr-xr-x    1 root     root          4096 Aug  5 12:25 lib
drwxr-xr-x    5 root     root          4096 Aug  5 12:25 media
drwxr-xr-x    2 root     root          4096 Aug  5 12:25 mnt
drwxr-xr-x    2 root     root          4096 Aug  5 12:25 opt
dr-xr-xr-x  199 root     root             0 Aug 17 09:38 proc
drwx------    2 root     root          4096 Aug  5 12:25 root
drwxr-xr-x    2 root     root          4096 Aug  5 12:25 run
drwxr-xr-x    2 root     root          4096 Aug  5 12:25 sbin
drwxr-xr-x    2 root     root          4096 Aug  5 12:25 srv
dr-xr-xr-x   13 root     root             0 Aug 17 09:38 sys
drwxrwxrwt    2 root     root          4096 Aug  5 12:25 tmp
drwxr-xr-x    1 root     root          4096 Aug 17 08:57 usr
drwxr-xr-x    1 root     root          4096 Aug 17 08:57 var

/app/bin $ kics
Keeping Infrastructure as Code Secure

Usage:
  kics [command]

Available Commands:
  generate-id    Generates uuid for query
.....
....
....

By specifying USER by UID we ensure that this Dockefile is compliant with Openshifts SCC that specifies "mustRunAsNonRoot".
FROM golang:1.16-alpine as build_env
...
USER ${UID}
.....
....
USER ${UID}
#Healthcheck the container
.....
FROM alpine:3.14.1
...
...

USER ${UID}

I submit this contribution under the Apache-2.0 license.

The integration-tests are currently failing due to a permissions error by running as a different user.
Run docker image and generate results.json
Run docker run -v ${PWD}/assets/queries:/path \
Error: initialization error - open /path/info.log: permission denied

Usage:
kics scan [flags]

Flags:
--cloud-provider strings list of cloud providers to scan (aws, azure, gcp)
--config string path to configuration file
...
...
-t, --type strings case insensitive list of platform types to scan
(Ansible, AzureResourceManager, CloudFormation, Dockerfile, Kubernetes, OpenAPI, Terraform)

Global Flags:

--ci display only log messages to CLI output (mutually exclusive with silent)
-f, --log-format string determines log format (pretty,json) (default "pretty")
...
...
-s, --silent silence stdout messages (mutually exclusive with verbose and ciz)
-v, --verbose write logs to stdout too (mutually exclusive with silent)

Error: Process completed with exit code 126.

Archive test logs
Run actions/upload-artifact@v2

Warning: No files were found with the provided path: assets/queries/info.log. No artifacts will be uploaded.

This looks to be an issue with the workflow rather than the Dockerfile itself?
docker run -v ${PWD}/assets/queries:/path -it --entrypoint sh pandoraholladay/git-kics:4
/app/bin $ kics scan \
>     --silent \
>     --disable-full-descriptions \
>     --ignore-on-exit "results" \
>     --log-level DEBUG \
>     --log-path "/path/info.log" \
>     -p "/path" \
>     -o "/path/"
/app/bin $ ls -la /path/
total 12
drwxr-xr-x   13 Checkmar Checkmar       416 Aug 18 08:50 .
drwxr-xr-x    1 root     root          4096 Aug 18 08:55 ..
-rw-------    1 Checkmar Checkmar       403 Aug 18 08:57 .ash_history
drwxr-xr-x    5 Checkmar Checkmar       160 Aug 16 10:59 ansible
drwxr-xr-x   43 Checkmar Checkmar      1376 Aug 16 10:59 azureResourceManager
drwxr-xr-x  226 Checkmar Checkmar      7232 Aug 16 10:59 cloudFormation
drwxr-xr-x    4 Checkmar Checkmar       128 Aug 16 10:59 common
drwxr-xr-x   55 Checkmar Checkmar      1760 Aug 16 10:59 dockerfile
-rwxr-xr-x    1 Checkmar Checkmar      1075 Aug 18 08:56 info.log
drwxr-xr-x   82 Checkmar Checkmar      2624 Aug 16 10:59 k8s
drwxr-xr-x    5 Checkmar Checkmar       160 Aug 16 10:59 openAPI
drwxr-xr-x    8 Checkmar Checkmar       256 Aug 16 10:59 terraform
drwxr-xr-x    3 Checkmar Checkmar        96 Aug 17 16:23 “; cat
/app/bin $ cat /path/info.log
8:56AM | DEBUG | console.scan()
8:56AM | WARN  | KICS crash report disabled
8:56AM | INFO  | Scanning with Keeping Infrastructure as Code Secure development
8:56AM | DEBUG | Looking for queries in executable path and in current work directory
8:56AM | DEBUG | helpers.GetDefaultQueryPath()
8:56AM | DEBUG | helpers.GetExecutableDirectory()
8:56AM | DEBUG | Queries found in /app/bin/assets/queries
8:56AM | INFO  | Loading queries of type: ansible, azureresourcemanager, openapi, dockerfile, cloudformation, terraform, kubernetes
8:56AM | DEBUG | source.NewFilesystemSource()
8:56AM | DEBUG | storage.NewMemoryStorage()
8:56AM | DEBUG | engine.NewInspector()
8:56AM | INFO  | Inspector initialized, number of queries=1966
8:56AM | INFO  | Query execution timeout=1m0s
8:56AM | DEBUG | provider.NewFileSystemSourceProvider()
8:56AM | DEBUG | parser.NewBuilder()
8:56AM | DEBUG | resolver.Add()
8:56AM | DEBUG | resolver.Build()
8:56AM | DEBUG | service.StartScan()
8:56AM | DEBUG | service.StartScan()
8:56AM | DEBUG | service.StartScan()
8:56AM | DEBUG | service.StartScan()
/app/bin $ ls -la assets/queries/
total 64
drwxr-xr-x   11 Checkmar Checkmar      4096 Aug 17 17:01 .
drwxr-xr-x    5 Checkmar Checkmar      4096 Aug 18 08:49 ..
drwxr-xr-x    5 Checkmar Checkmar      4096 Aug 16 16:15 ansible
drwxr-xr-x   43 Checkmar Checkmar      4096 Aug 16 16:15 azureResourceManager
drwxr-xr-x  226 Checkmar Checkmar     20480 Aug 16 16:15 cloudFormation
drwxr-xr-x    4 Checkmar Checkmar      4096 Aug 16 16:15 common
drwxr-xr-x   55 Checkmar Checkmar      4096 Aug 16 16:15 dockerfile
-rwxr-xr-x    1 Checkmar Checkmar      1075 Aug 17 16:51 info.log
drwxr-xr-x   82 Checkmar Checkmar      4096 Aug 16 16:15 k8s
drwxr-xr-x    5 Checkmar Checkmar      4096 Aug 16 16:15 openAPI
drwxr-xr-x    8 Checkmar Checkmar      4096 Aug 16 16:15 terraform
drwxr-xr-x    3 Checkmar Checkmar      4096 Aug 17 16:47 “; cat

Hi @Homopatrol
Thank you for your pull request and investigation.
This same topic has been discussed in the past especially because we also have a query to flag this issue.
I've made some tests again to confirm the problem, first I've cloned your fork and built the image:

Secondly, I tried to run a scan using the docker image from another user and got permission denied:

The only way to keep using the Docker image with bind mount as we are right now would be to use the -u flag inside the run command.
docker run -u $(id -u):$(id -g) -v $PWD/assets/queries/dockerfile:/path -it kics:5e3369d1 scan -p /path -v -o /path/ --report-formats json

This could be an issue to break compatibility with pipelines that are already implemented using KICS inside a docker container, the other issue is to test how would this behave inside Windows systems.
We need to do more research if we can reduce the impact of changing the Dockerfile user without breaking the pipelines.


Fix getting matched count

Fix errors "unsupported operand type(s) for -: 'NoneType' and 'int'" at /collections
Available PR templates

Default
Version Release
Alternatively delete and start empty

Hello, I was trying out tipgstac but I got the above error when trying to access the /collections endpoint, even after enabling the context extension. Not sure if this is bug or wrong usage on my end


Retry sonobuoy only 3 times

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold

/unhold


add project contributor readme

[ ] set master branch--the deployed branch
[ ] work off a develop branch
[ ] issues + github board
[ ] creating branches based on issue #s
[ ] merge back

[ ] tests + possible code review
[ ] do we want 2 or 3 gatekeepers who can review pull requests?

probably yes

just added some notes to the README


Remove general purpose hive metastore code

Resolves #78

Not many changes here, Thrift clients seem to be WD specific, haven't seen them used anywhere else. Let me know if you know of them being used elsewhere


Recipes not displaying correctly on servers

Recipes showing all out of order on servers versus on single player worlds. Reference shot with pyrite:

and on singleplayer:

it seems to fill in the first two slots properly, but then starts at the next slot (2), instead of putting the 3/4 imbuing ingredients in slots 11 and 12. Everything kinda fudges up after that.

Fixed issue with my server packet serialization that was causing this.


[slick][javadsl] improve SlickSession.forConfig usage with idea

motivation
If the Companion object A of class A extend  a class B, the idea will report an error, because idea can't find the method include the class B

user need to use SlickSession$.MODULE$.forConfig("slick-h2");, this usage connot match the description on the official website.
Report it to idea,but idea may not be fixed or slowly, as they are mainly Java ideas and cannot fix such issues. Previously reported an error with the inline.
how to do
just wrapper the extend method
test
had test locally.

Let's wait for IDEA to get back. I don't believe it is up to us to hack our code due to issues in IDEA.

Let's wait for IDEA to get back. I don't believe it is up to us to hack our code due to issues in IDEA.

I think this is only an issue with the idea, and it is also a lack of comprehensive consideration by the slide API designer, without good abstraction.
Java DSL and Scala DSL are not asymmetric，and api should be included in  Companion object, just use Object.
The perfect Java API implementation should be
pekko-connector-cassandraSource
https://github.com/apache/incubator-pekko-connectors/blob/main/cassandra/src/main/scala/org/apache/pekko/stream/connectors/cassandra/javadsl/CassandraSource.scala
spark
https://github.com/apache/spark/blob/master/sql/api/src/main/java/org/apache/spark/sql/types/DataTypes.java

https://youtrack.jetbrains.com/issue/SCL-12670/IntelliJ-cannot-resolve-methods-from-companion-objects-of-sealed-traits-in-an-imported-library
this bug has existed 4 years

https://github.com/slick/slick is a designed for Scala users. Is it even that usable by Java users? Wouldn't you be better off with something like Hibernate?

Indeed, I don't use JavaDSL either, so I didn't make any major changes. But we provide JavaDSL.

https://youtrack.jetbrains.com/issue/SCL-21966/Cannot-resolve-method-which-extends-from-class-for-a-Companion-object
I has reported it to idea scala.


Fix for a problem with Agilent IMS data where fringe CCS and/or DT values cannot roundtrip through the CCS/DT conversion…

… (throws exception "Cannot solve cubic fit"). When we hit these, just stick with any measure DT value since the CCS conversion isn't useful.
Reported by user Alan

A new perftest to test fringe values seems a bit extreme (unless it's very fast to run?). Was there no practical way to just test those values standalone?

Fair question.
It takes 50 seconds exclusive of the time to download the data set. It's only in perf because of the data download issue, but the data is needed to reproduce the problem.  Possibly I could write some custom code to get that runtime down but for something that runs just once in a test suite it didn't seem worth the bother. I could be convinced otherwise, I suppose.

I'm not aware of a way to subset Agilent MIDAC data files. Can you get the fringe value failures from the other MIDAC perf data sets? (I.e. explicitly testing the problematic values on other datasets where those values might not occur in any of the spectra)

I'm not aware of a way to subset Agilent MIDAC data files. Can you get the fringe value failures from the other MIDAC perf data sets? (I.e. explicitly testing the problematic values on other datasets where those values might not occur in any of the spectra)

Conceivably, but it just doesn't seem like a good use of my time - but possibly I am underestimating the evilness of what I've done here?

How big is the new zip file?

How big is the new zip file?


module 'colors' not found

Hi,
I tried enabling the theme for galaxy line
require('vn-night.galaxyline')

both galaxyline and the theme is loaded before this and those work fine.
I get this error message when opening neovim
E5113: Error while calling lua chunk: ...k/packer/start/vn-night.nvim/lua/vn-night/galaxyline.lua:7: module 'colors' not found:
        no field package.preload['colors']

Thanks bro. Fixed. Just update with your plug-in manager


Fix compatibility matrix order issue  to sort K8s versions

Notes for Reviewers
This PR fixes #6873

In order to fix this issue I am using the sort_natural Liquid filter, which sorts strings in a natural order considering the numeric and non-numeric parts of the string.
Adding the jekyll-sort gem  to project's Gemfile
Updating project's _config.yml file with jekyll-sort in the list of plugins

Signed commits

[X] Yes, I signed my commits.

🚀 Preview for commit a3f78dab446136902403bb35f1f4c6ec042384d3 at: https://63d2fbeca0503802869d5ce8--meshery-docs-preview.netlify.app

@rudrakshkarpe , the solution still does not work 🥺.

Just to be sure have you built Meshery docs on your machine? If not I would advice you to do it so that you can see the changes on the docs after you change the code.

Oh! I'll set-up enviornment and try fixing it.

Any luck?

@rudrakshkarpe  Let's discuss this on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

@rudrakshkarpe it's been a couple weeks… What do you want to do with this PR? Close it out?

@rudrakshkarpe  Let's discuss the update of this PR on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

@rudrakshkarpe it's been a couple of weeks… What do you want to do with this PR? Close it out?

I apologize for my inactivity over the past two weeks. This was due to exams, preventing me from being active. I am now discussing my approach to development. I look forward to being actively involved in the future.

Hey, @leecalcote @rudrakshkarpe I am opening another pr related to this issue #6873. So we can close this pr

Fixed by #7331


mergedqa dictionary read from get_merged_qa_scalar_metrics

Just calling mergedqa  using the function get_merged_qa_scalar_metrics from helper.py.

Jenkins detected errors please fix them before I can review @felipeaoli


[WIP] Adds 'Lazy' type, so sampleData can be requested later

I'm having trouble getting the specs to run... also, if you think this PR is worthwhile, I would like to add some specs around this specific feature.  Let me know what you think!
Example:
let endpointsClosure = { (target: GitHub, method: Moya.Method, parameters: [String: AnyObject]) -> Endpoint<GitHub> in
    return Endpoint<GitHub>(URL: url(target), method: method, parameters: parameters,
        sampleResponse: .Lazy({ return .Success(200, target.sampleDataFromSomeExpensiveOperation) })
    )
}

I took an initial stab at this using @autocomplete on sampleResponse: (and called in the if stubbedResponses code), but that had an unfortunate side effect that sampleResponse: .Success(..) was not autodetected to be of type EndpointSampleResponse (e.g. it had to be EndpointSampleResponse.Success).  I figured backwards compatibility was preferred, and this syntax is explicit, which is a win.

@colinta Hey! Sorry I haven't reviewed this yet. I just moved from Amsterdam to New York and some things have fallen between the cracks. I'll get to it ASAP – thanks for contributing!

Looks great! Tests would be :+1: Let me know if I can help getting them running on your machine.

I like the "always lazy" idea.  For that to be backwards compatible we'd need to use an autoclosure, right?
public init(URL: String, sampleResponse: EndpointSampleResponse, method: ...
  =>
public init(URL: String, sampleResponse: @autoclosure () -> EndpointSampleResponse, method: ...

I attempted this and there were so many repercussions that I went with this more straightforward way instead.  I'll take another stab at it.
I'm down with s/Lazy/Closure/ if we go that route.

Btw when I run make or make test I get this error:
⌦ The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.

Ahh, right, OK I just reimplemented the autoclosure style locally, and here's the error that turned me off to the idea:
var endpoint = Endpoint<MyAPI>(URL: url(target),
  sampleResponse: .Success(200, target.sampleData),
  method: method,
  parameters: parameters)
🚫 '(@autoclosure () -> EndpointSampleResponse).Type' does not have a member named 'Success'

Right, so since this method expects a closure, it wouldn't support .Success.  This would be a breaking change.
If (()->EndpointSampleResponse).Type could be extended to include .Success and .Failure then we'd have a way of having this feature with backwards compatibility.

(O_O)
public enum EndpointSampleResponse {
    case Success(@autoclosure () -> (Int, NSData))
    case Error(@autoclosure () -> (Int?, NSError?, NSData?))
}

This is still not ideal.  With this autoclosure trick, the .Success / .Failure values now look like this - they have to be wrapped in a closure:
.Success((200, target.sampleData))

Hmm. To be honest, I'm totally cool with breaking changes, so don't worry about it. We're versioning the library so people can update if/when they want to.
I don't know if @autoclosure is going to work going forward. Swift 1.2 changes the semantics surrounding this construct such that these types of closures cant be stored for later – they must be executed immediately (as far as I understand it). I think moving to a pure closure would be OK.

Oh, and bundle exec pod install or just pod install should fix the error with testing.

Is there a Podfile I'm missing?
> bundle install --path vendor
...
Your bundle is complete!
It was installed into ./vendor
> bundle exec pod install
[!] No `Podfile' found in the project directory.

What folder are you running it from?

03:39 PM ~/Code/Swift/Moya ‹ master ›
> ls
CHANGELOG.md             Gemfile                  Makefile                 Moya.swift               docs
Demo                     Gemfile.lock             Moya+ReactiveCocoa.swift RACSignal+Moya.swift     vendor
Endpoint.swift           LICENSE                  Moya.podspec             README.md                web

(root project folder, same as Makefile)

Try it in the Demo directory, where the Podfile is.

Success!  I'll work on the specs.
Regardless, I'm unsure what style you like the most at this point:

new type, .Closure(), which returns an EndpointSampleResponse
autoclosure in init, which requires changing .Success => EndpointSampleResponse.Success because the type can't be detected
autoclosure in the enum initializer, which is backwards compatible but might not work in 1.2

I still like option 1 (the original patch) because if @autoclosure is a moving target, I don't feel much better about using it in Endpoint.init than using it in the enums.
Sounds like you're leaning towards option 2 - it just requires the sample response type to have the explicit EndpointSampleResponse. prefix.  Not as pretty, but not cumbersome.  And :+1: on the simple use of @autoclosure there.

I think the first option, adding a new case to the enum, would be awesome. Avoiding @autoclosure seems to be a good idea for now. Let me know if I can help!

OK, can do - and yeah, I agree, I think it's the most straightforward.
I'll push up that version soon with specs.
Are you hanging out with Eloy these days?  Tell him Colin says hi! :-D
On Tue, Mar 3, 2015 at 5:38 PM, Ash Furrow<EMAIL_ADDRESS>wrote:

I think the first option, adding a new case to the enum, would be awesome.
Avoiding @autoclosure seems to be a good idea for now. Let me know if I
can help!
—
Reply to this email directly or view it on GitHub
https://github.com/ashfurrow/Moya/pull/100#issuecomment-77074131.

@alloy? Only on Slack :) I've left Amsterdam, sadly.

👋😆

@ashfurrow OK, I was working on the specs, and I accidentally (i swear) did this:
.Closure(.Success(200, ...
But then I was like, WAIT a second... case Closure(@autoclosure () -> EndpointSampleResponse) would make this a very easy opt-in feature!  It supports the syntax I accidentally typed, and as far as I can tell, this syntax will still be supported in 1.2.
I thought it looked great, so I'm pushing it up for review here.  I can still revert to the non-@autoclosure code, e.g. Closure({ return .Success(200, ...

Looks awesome!


Make the enconding a optional parameter

With this PR, it will be able to choose a enconding when escaping. Default value is UTF-8.
This will fix issue #106

So it doesn't seem ideal to have to set this value each time you call escape(). And if we did do this, we'd also need to add it to the e() function. I feel like this is better done as a configuration setting. Something like this:
// Create new Plates engine
$templates = new League\Plates\Engine('/path/to/templates');

// Set charset
$templates->setCharset('UTF-8');

I'm going to look at adding this to the 4.x release, and will close this PR. Regardless, thanks for your interest in this library and for contributing this! 👍


Object not counted when going back to pick_up_position

A new feature in 12.4 introduce a way to move a object where he was picked up when you press escape.
The occupying table is not correctly updated when you use this new feature after pick it a object from a zone.

The fix for this is visibly glitchy if the object has been rotated from the the drop zones rotation (when auto rotation is enabled).
I suspect I'll need additional TTS APIs to resolve this, but will look into it further later on.

Actually, the current "fix" is a bit overzealous. I'll do a better job once I've got some more free time 😉

Figured I may as well just quickly get it done. It's not exactly optimal performance-wise, but does the job.


Feature Request: F# Razor "fshtml" support

Can you add support for F# HTML rendering with ".fshtml"?
Although currently dotnet core supports F# web apps, the html rendering still is "cshtml" but not "fshtml".

Thanks for contacting us, @hez2010.
@Eilon, @danroth27 can you please ping the F# team folks so they can comment here? Thanks!


Expose RSS-feed URL to browser

Introduces a new '%U' formatting option for the 'browser' config
variable, which exposes the RSS-feed's URL.
Closes #423
Note: The relevant parts of the documentation seem to be gitignored?

Coverage increased (+0.06%) to 40.238% when pulling 4f7f76e434e3c011c09bd975a09b37c1ebdc5b13 on foxdevilwild:feature/feedurl-format-option into ea7bdd97aad1d1e15017cd4ba7219b8ebfb77230 on newsboat:master.

Coverage increased (+0.06%) to 40.238% when pulling 4f7f76e434e3c011c09bd975a09b37c1ebdc5b13 on foxdevilwild:feature/feedurl-format-option into ea7bdd97aad1d1e15017cd4ba7219b8ebfb77230 on newsboat:master.

Coverage increased (+0.06%) to 40.238% when pulling 4f7f76e434e3c011c09bd975a09b37c1ebdc5b13 on foxdevilwild:feature/feedurl-format-option into ea7bdd97aad1d1e15017cd4ba7219b8ebfb77230 on newsboat:master.

Thanks for the feedback. I've implemented your suggestions to the C++ code. From a first glance I think I'll be able to convert quote_url_for_cmdline to rust, but I'm afraid I won't get around to it until the weekend.
I'm also having trouble coming up with an example macro usage. Personally, I use it to call into custom scripts, which are probably not a great fit to be added to the docs. The user who suggested the change wants to use it to remove lines from newsboat/urls, but I feel uneasy about adding potentially destructive commands to the documentation. What do you think?

I'm afraid I won't get around to it until the weekend

That's totally fine, there is no hurry. The next scheduled release is at the end of March, there are plenty of weekends until then :) (I plan a bugfix release soon-ish, but it is not blocked by this PR.)
Regarding the macro example: can't come up with a good one, either. Just a paragraph on the difference between %u and %U? If you don't understand it well enough, I can merge this as-is and write the docs myself, later.

Hey Minoru. Apologies for the delay, I haven't abandoned the PR. The docs are still unfinished, but I hope to get around to it tomorrow.

I've made the discussed changes to the docs, and it seems to be working for the most part. However, when building, there is a validation error checking doc/manpage-newsboat.xml, which I am unable to resolve.
The failing check is:
xmllint --nonet --noout --valid "doc/manpage-newsboat.xml"
It fails with:
element link: validity error : IDREF attribute linkend references an unknown ID "browser-format-table"
Looking at the file confirms that browser-format-table is indeed not defined there, however it is defined in doc/newsboat.txt and when looking at doc/xhtml/newboat.html the link works as intended.
Hopefully you can point me in the right direction?

doc/manpage-newsboat.txt is not included in doc/configcommands.dsv, so Asciidoc can't resolve the link. I believe our current practice is simply not to use links in doc/configcommands.dsv. That's quite lame, and that's one of the reasons why I filed #441. When that issue is fixed, we will include the DSV in the manpage, and will be able to cross-reference whatever we want.

Hey Minoru, just letting you know that I haven't abandoned the Issue. My HDD died and I'm currently left with only a mobile device until the replacement arrives (hopefully tomorrow). Apologies again for leaving this unresolved for the time being. I'll promise to get the PR ready as soon as possible.

 Hope you had a backup.
Don't rush it, and don't even worry about the PR—the next release is at the end of March, so you've got plenty of time. And thanks for checking in; I wasn't sure if I should ping you after a week or wait a bit more.

Hey @foxdevilwild, how is it going? Wanna push this over the finish line, or should I take over?

I still haven't gotten around to finishing this, so I'm un-assigning myself. This PR is now free for the taking; please push it over the finish line!


Fix/score

We can use a map instead of a slice for the seen variable. It would be more efficient and we will avoid to write our own function to check if the element is there or not.

I agree it's better not to code our own function, but about your performance thing, unless you plan having 100 words filenames, I doubt we will ever see the benefit.
http://www.darkcoding.net/software/go-slice-search-vs-map-lookup/

(by the way I compiled and tested, it works)

Thanks for the insightful link. I agree with you on the practical point of view.
However, efficiency apart, I still prefer the map-based implementation as it avoids to add a function.

👍
For your information, you can also checked the presence of an element in a map by using:
if _, ok := seen[k1]; ok {
    // Do something
}

Here you ignoring the value returned by using the _ (which is the 0 value of the type when the element is not found) and ok is a boolean that tells you if the key was found or not. In your case, since you're storing booleans, the 0 value that you're getting when the element is missing is false, which is fine.

actually it does not work, I misunderstood the output of the binary for a success, but it's only the output when it receives a command
on the merged version the score will always return 0


Break down application_form.yml file

Context
At the moment the application_form.yml file is too long, so we want to split it out.  We should break this down so that it is reflective of the folder structure we use (see the structure inside app/views/candidate_interface for an example)
Changes proposed in this pull request
Extracting big chunks of the application_form.yml to separate files, including the activemodel.errors code.
Guidance to review

Review commit by commit
There is a lot of copypasting here and so a higher than likely chance for human error. Have I dropped a line somewhere?
At the moment, everything is still scoped by application_form. Is that necessary?
The locales directory is starting to grow, is it worth collecting all of these new files and the application_form.yml into a nested directory?

Link to Trello card
https://trello.com/c/jviWkNFf/2830-break-down-applicationformyml-file
Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

There is a lot of copypasting here and so a higher than likely chance for human error. Have I dropped a line somewhere?

I believe we have raise_on_missing_translations enabled, which should cause errors where things have been missed out. If you're anxious you could probably parse and combine the YAML from all the separated files, sort it somehow, and compare that with the parsed YAML.

At the moment, everything is still scoped by application_form. Is that necessary?
The locales directory is starting to grow, is it worth collecting all of these new files and the application_form.yml into a nested directory?

IMO this namespace is useful as the nested objects also live elsewhere — eg there are contact_details in support, in Manage etc. If they're all going to have that key, putting them all into an application_form directory seems logical.

There is a lot of copypasting here and so a higher than likely chance for human error. Have I dropped a line somewhere?

I believe we have raise_on_missing_translations enabled, which should cause errors where things have been missed out. If you're anxious you could probably parse and combine the YAML from all the separated files, sort it somehow, and compare that with the parsed YAML.

At the moment, everything is still scoped by application_form. Is that necessary?
The locales directory is starting to grow, is it worth collecting all of these new files and the application_form.yml into a nested directory?

IMO this namespace is useful as the nested objects also live elsewhere — eg there are contact_details in support, in Manage etc. If they're all going to have that key, putting them all into an application_form directory seems logical.

I've created an emails directory inside locales since that seems like a clear distinction to make. I feel like there's another that could be pulled out, but I'm struggling for a name. It's for strings that aren't used for views (take a look in locales/reference.yml to see what I mean). There's less of them so I'm less sure than I was for the emails.

I've created an emails directory inside locales since that seems like a clear distinction to make. I feel like there's another that could be pulled out, but I'm struggling for a name. It's for strings that aren't used for views (take a look in locales/reference.yml to see what I mean). There's less of them so I'm less sure than I was for the emails.

Probably a separate commit, but looking at the emails, they use these keys:

chase_candidate_decision_email
candidate_mailer
reference_request
candidate_offer
provider_mailer

Not only do the file names not always reflect the key name, I’m not sure if these keys reflect the architecture of the app; should they fall under the following keys:

candidate_mailer
referee_mailer
provider_mailer

Good spot, I've tidied those up now.

Probably a separate commit, but looking at the emails, they use these keys:

chase_candidate_decision_email
candidate_mailer
reference_request
candidate_offer
provider_mailer

Not only do the file names not always reflect the key name, I’m not sure if these keys reflect the architecture of the app; should they fall under the following keys:

candidate_mailer
referee_mailer
provider_mailer

Good spot, I've tidied those up now.


Headers check is too strict

Given
---
---
 - name: Issue 42 is where extraneous headers sent will trigger a 404. It should ignore unknown headers
   request:
     uri: /test
     method: POST
     headers:
      content-type: application/json
   response:
     code: 200

If a request is sent with other headers, such as Content-Length it is seen as not matching.
This is because mockingjay/request.go hopes that the two header arrays match (deepEqual). https://github.com/quii/mockingjay-server/blob/master/mockingjay/request.go#L95
Instead it should see if the incoming requests just contains all the ones we expect, ignoring others.
Automated tests are in server_test.go . The test for this should probably go in request_test.go

Fixed in 1.5.10


Fix a race condition when two upload happens at the same time

Fix #105

These seem to be some conflicts preventing this PR from being merged. Could you resolve those?

rebased


Rsync authentication by username and password.

Why is there only one way to connect to a server? It would be great, if somebody implements this feature.

Either private key, or no-pass... or you could tackle something like
expect script, or whip some sshpass wrapper... there are couple
possible solutions but none are universal and all fails due to ssh way of
handling things.
2016-10-03 18:42 GMT+02:00 Boyko Alexey<EMAIL_ADDRESS>
Why is there only one way to connect to a server? It would be great, if
somebody implements this feature.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/deployphp/recipes/issues/66, or mute the thread
https://github.com/notifications/unsubscribe-auth/AKMVFXQwa-79P4WQSWgYejOCQxFBGL3Xks5qwTBwgaJpZM4KMySW
.

--
Pozdrawiam,
Hubert Kowalski

Yes, of course I can handle it by hands(and there is no better way than using keys), but this way makes this recipe meaningless for me. Anyway, I will try to look for another way to work it out.


[extractor/afreecatv] Fix extractor

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
As in a somewhat reversal of #6283 this uses fully JSON again as some necessary information are not provided in XML any more.
This code will not keep XML part for backward compatibility.
The code is tested with login and without, on adult and regular.
Fixes #9544

Template
Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

still is problem : ERROR: [afreecatv] 109615861: 109615861: Failed to parse XML (caused by ParseError

still is problem : ERROR: [afreecatv] 109615861: 109615861: Failed to parse XML (caused by ParseError

Are you sure you used the suggested changes? There shouldn't be anything to parse XML left.
Your example 109615861 works fine for me.

I deployed yt_dlp using
C:\Users\ZYZ.conda\envs\python3.8\python.exe -m pip install --force-reinstall "yt-dlp[default] @ https://github.com/yt-dlp/yt- dlp/archive/master.tar.gz"
Is it because the latest package was not downloaded? Thank you.

I deployed yt_dlp using
C:\Users\ZYZ.conda\envs\python3.8\python.exe -m pip install --force-reinstall "yt-dlp[default] @ https://github.com/yt-dlp/yt-dlp/archive/master.tar.gz"

Is it because the latest package was not downloaded? Thank you.
I think you should get yt-dlp from Tomoka1's branch first (because it's not in main branch yet)

While the aim of the PR is not to extract XML file, i think it nice if we could extract the upload_date (and perhaps other key) like #8862

What should be done, thank you

new probelm ERROR: [afreecatv] 109615861: 109615861: HTTP Error 502: Bad Gateway (caused by <HTTPError 502: Bad Gateway>)

While the aim of the PR is not to extract XML file, i think it nice if we could extract the upload_date (and perhaps other key) like #8862

I am not sure what you're referring to.
upload_date is retrieved from file_info_key as it was done before in similar fashion.
Using write_tm or broad_start wouldn't be an issue, if that's preferred.
[~]$ python -m yt_dlp https://vod.afreecatv.com/player/109615861 --print "%(upload_date)s %(title)s"
20231116 [클립]생)사랑스런 민영이 오늘은 시스루~ 검스 ㅎ ㅏㅏㅏ ㅀ

new probelm ERROR: [afreecatv] 109615861: 109615861: HTTP Error 502: Bad Gateway (caused by <HTTPError 502: Bad Gateway>)
Not replicable on my side. I assume you're sitting in some geolocked region.
Try curl https://api.m.afreecatv.com/station/video/a/view and if it's negative please open another issue.

C:\Users\ZYZ.conda\envs\python3.8\python.exe -m  pip install --force-reinstall "yt-dlp[default] @ https://github.com/Tomoka1/yt-dlp/archive/afreecatv-from_xml_to_json.tar.gz"
python -m yt_dlp https://vod.afreecatv.com/player/109615861 --print "%(upload_date)s %(title)s"
ERROR: [afreecatv] 109615861: 109615861: Failed to parse XML (caused by ParseError('no element found: line 1, column 0')); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U

I removed all the dead code and simplified/modernized what was left. Please test my changes and let me know what you think.
My previous review is no longer applicable except for this part:

Can you also update the tests and add an adult content test, since the current one is dead?

@bashonly Oh, i just wrote up-to-date tests myself before seeing the merge. Sorry i didn't have too much time this week. Thanks for your hard work!


forge verify-contract for mumbai not working

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (05e72b6 2022-05-19T00:04:24.552902Z)
What command(s) is the bug in?
forge verify-contract
Operating System
macOS (Apple Silicon)
Describe the bug
I can't verify a deployed contract on mumbai. Testing and building the project locally works. Also deploying the contract to mumbai works.
This project runs in an nx monorepo where /node_modules is at the root and  is /apps// in which forge init was done. Using remappings the /node_modules folder is found. This works as verified by being able to build and test the project.
Deploy command:
forge create --json --use solc:0.8.13 --root <path to project root> --rpc-url https://polygon-mumbai.g.alchemy.com/v2/<key> --private-key <key> --optimizer-runs 200 <path to project root>/src/<contractName>.sol:<contractName>

From this I get a response and I can see the deployed contract at the given address on mumbai.polygonscan.com.
Verify command:
forge verify-contract --root <path to project root> --chain-id 80001 --num-of-optimizations 200 --compiler-version v0.8.13+commit.abaa5c0e  <contract address> src/<contractName>.sol:<contractName> <etherscan/polygonscan api key>

From which I get an OK response.
Then doing a verify-check with:
forge verify-check --chain-id 80001 <GUID> <etherscan/polygonscan api key>

Giving as a response:
Waiting for verification result...
Contract verification failed:
Response: `NOTOK`
Details: `Fail - Unable to verify`

I've seen other issues with the same problem but the responses on those issues didn't help me.

I had the exactly the same issue but on Rinkeby. In my case I was using
forge verify-contract --compiler-version v0.8.14+commit.80d49f37 --chain-id 4 <address> src/Contract.sol:Contract <etherscan-api>
Which kept returning Ok and then after verify-checking failed each time.
I lowered my compiler version to 'v0.8.13+commit.abaa5c0e' and then it worked.
All the contracts I used were either using pragma solidity ^0.8.0; or pragma solidity ^0.8.9 <0.9.0;
I don't know if you can do anything with this information but figured it's better than nothing 🤷🏻

@enzoevers There's been a lot of changes to create + verify, is this issue still present?

I digress, I was the one using the wrong compiler version, sorry for that.

Closing with the assumption that it has been solved since no new reports have been made after the changes to forge create. Let me know if it is still present for you.

Hi, sorry for the late response. Indeed deploying and verifying contracts works (at least tested this on Goerli). But it seems that deploying upgradeable contracts doesn't work yet as expected.
When deploying a (UUPS) upgradable contract it looks at first as if it works.
FOUNDRY_PROFILE=gelato-resolver-poc forge create --rpc-url https://eth-goerli.g.alchemy.com/v2/<key> \
    --private-key <private key> projects/gelato-resolver-poc/src/Counter.sol:Counter \
    --etherscan-api-key <api key> \
    --verify
[⠊] Compiling...
[⠆] Compiling 10 files with 0.8.17
[⠰] Solc 0.8.17 finished in 195.95ms
Compiler run successful
Deployer: 0x9F9b3026d11DA9C37984460ae00e4c428616e1e2
Deployed to: 0x48CD4E4a4526D242F7B650a38e4845004bb0dfA0
Transaction hash: 0x80ec3a6b3de96f87584dc5d6f3981785aaa526320cd2e5ac9006f6d8be6c6a80
Starting contract verification...
Waiting for etherscan to detect contract deployment...
Start verifying contract `0x48cd4e4a4526d242f7b650a38e4845004bb0dfa0` deployed on goerli

Submitting verification for [projects/gelato-resolver-poc/src/Counter.sol:Counter] "0x48CD4E4a4526D242F7B650a38e4845004bb0dfA0".

Submitting verification for [projects/gelato-resolver-poc/src/Counter.sol:Counter] "0x48CD4E4a4526D242F7B650a38e4845004bb0dfA0".

Submitting verification for [projects/gelato-resolver-poc/src/Counter.sol:Counter] "0x48CD4E4a4526D242F7B650a38e4845004bb0dfA0".

Submitting verification for [projects/gelato-resolver-poc/src/Counter.sol:Counter] "0x48CD4E4a4526D242F7B650a38e4845004bb0dfA0".

Submitting verification for [projects/gelato-resolver-poc/src/Counter.sol:Counter] "0x48CD4E4a4526D242F7B650a38e4845004bb0dfA0".

Submitting verification for [projects/gelato-resolver-poc/src/Counter.sol:Counter] "0x48CD4E4a4526D242F7B650a38e4845004bb0dfA0".

Submitting verification for [projects/gelato-resolver-poc/src/Counter.sol:Counter] "0x48CD4E4a4526D242F7B650a38e4845004bb0dfA0".

Submitting verification for [projects/gelato-resolver-poc/src/Counter.sol:Counter] "0x48CD4E4a4526D242F7B650a38e4845004bb0dfA0".
Submitted contract for verification:
	Response: `OK`
	GUID: `nwvmbzzxifaawgbp6kragueghznkc6mvjzydir4lgzisvzcmk9`
	URL:
        https://goerli.etherscan.io/address/0x48cd4e4a4526d242f7b650a38e4845004bb0dfa0
Contract verification status:
Response: `NOTOK`
Details: `Pending in queue`
Contract verification status:
Response: `OK`
Details: `Pass - Verified`
Contract successfully verified

And indeed a proxy is deploy at 0x48CD4E4a4526D242F7B650a38e4845004bb0dfA0.
However, this deploys both the proxy contract and the implementation contract as one contract.

Hey, I am also having the exact same problem as described by @enzeve above. Either the contract has already been verified (proxy address) or the status is OK and submitted but the contract never is verified or updated on the blockchain explorer side..
I actually find working with proxies and foundry extremely tough and very frustrating but maybe it is because I haven't found the right tutorial. Does anyone have a way to verify the implementation contract for a UUPS proxy?


Intermittent Airflow Log went missing

Expected behaviour
Airflow Log will be in place unless someone delete it.
Actual behaviour
Intermittent Airflow task log went missing.
Information

Version: 1.10.4

Executor: Celery Executor

Single EC2 Instance with Docker Webserver and Scheduler + Multiple Celery Worker hosted on different EC2 + Single EC2 for RabbitMQ + RDS

I have configured a few of my DAGs to retry multiple times, for this case is 4 times. As you can see from the pictures, 3 retries has failed and the 4th is successful. I suppose I can see all the logs for every retry in Airflow Web UI.
But the log for second and third retries is gone and showing below error
Failed to fetch log file from worker. 404 Client Error: NOT FOUND for url: http://xx.xx.xx.xx:xxxx/log/xxx/xxx/2020-06-03T08:00:00+00:00/3.log
I also noticed this is not the only DAG has this behaviour, other DAG also has the same pattern just that some shows the logs on seconds and fourth retries and the missing one are first and third retries.
Steps to reproduce the behavior
Unable to reproduce since this is an intermittent issue.
Log exists

Log missing

I've been getting the same error and related ones. Sometimes logs just don't show up, or we'll get a "no hostname supplied" error. The cause seems to be a breakdown in communication between the workers, scheduler, and backend DB. But so far we haven't identified a solution for this.
Anyone else running into this or find a fix?


Linux Client phase one

This is the first phase pull request. The routing daemon is added to tools/outline_proxy_controller and the code for client UI is added in the same directory for Windows.
action scripts are under src/electron/linux/

Try again!

Try again!

I signed it!


Issue No. 2492

This PR Fixed issue no. #2492

Can one of the admins verify this patch?

@AppInventorWorkerBee ok to test


Bot not reacting to servers with channel categories

it just doesn't respond.

The reason of this is because the newer version of Nadeko fixed this issue.
There are only three options for you to solve this.

You have to remove the categories of all the servers.
You have to host the latest nadeko by yourself.
Kuro decides it's worth re-coding the project to solve this issue.

If i were you just go for option 1.

You can close this btw, it's known :P

Updated the bot and the guide


Add verbosity flag to erin_next_cli

[x] start a new branch
[x] enable parsing of --debug flag on command-line for apps/cli.cpp
[x] eliminate having the TOML input file spit back onto the command line
[x] make Simulation_Print(s) only print if debug is present
[x] pass the flag boolean called verbose into the Simulation_Run -- make it an optional parameter defaulting to true
[x] the flag should ultimately ground out in the call to Simulate (see erin_next.cpp) and set print to true/false
[x] ensure code builds and all tests pass
[x] create a PR against the develop branch

Note: we always will print error messages and warnings as well. This is just for "optional" print statements.
Currently, erin_next_cli prints a lot of valuable debug information on the command line. However, this printing out is detrimental to performance and not desired for production runs. Therefore, we would like to enable a flag to turn it on/off.
This is similar in spirit to #1 but is more pressing and should be a faster turn-around.
For now, we can just have a flag called --debug. If it is present, that should pass a true boolean into the Simulation_Run(.) functions to enable printing. Otherwise, we would not print.

This issue has been completed in other PRs.


Move Ivy support to its own package.

It's better to implement as much as possible using Emac's default completion interface.
Ivy (or any other) completion specific code should be it's own package. e.g. ivy-microfts or helm-microfts

If Emacs has a completion interface that can act like ivy does in the screencast, I'm happy to look at it. I didn't think Emacs had something that would display lines of text like this.

Checking out completion-at-point and its cousins...

Did this


" [$rootScope:inprog] $apply already in progress" errors

One of our users got this while using fileupload to upload a file. He says it wasn't a big file (it was a jpeg), but I'm not sure how not-big it was or how fast or slow his connection is. He gets the error consistently when he tries to upload today (he did manage to upload three files to the same table yesterday, though).
[$rootScope:inprog] $apply already in progress

http://errors.angularjs.org/1.5.5/$rootScope/inprog?p0=%24apply
https://www.rebuildingakidney.org/chaise/scripts/vendor/angular.js?v=ea03e809effc2b87cc7bd368e1740e84:17340:13

@jrchudy  To avoid these errors just wrap the $apply calls in try catch.
I added the timeouts because sometimes they won't pick the new data.

PR #1140 addresses this issue. I added a try/catch block around each $scope.$apply in upload.js. The catch currently logs a warning to the users browser console. I will update this on Monday with logging to a folder on the server for each deployment so we can track how often this occurs and more appropriately handle this in the future if it continues to be a recurring problem.

This issue is still not solved! The user just reported the same error on RBK.

It appears that the user was using Internet Explorer 11. Odd that it didn't work in this version. Maybe there's another compatibility issue with IE that I'm not aware of with AngularJS.
Closing this issue based on the response we got in the email thread and after talking to @hongsudt.


[Bug]: Possible Off-by-One Error regarding true page number

Bug Description
When entering the true first page number it is off by 1, e.g. the most recent paper I read starts with a title page which is followed by the first text page which is numbered 1. When I enter -1 in the dialoge I still get page 2 for highlights on page 1. This behaviour is consistent for every paper I had to enter a page number, so either I misunderstand how the feature works or there is an off-by-one error.
Relevant Screenshot
hooghe_2020_PostfunctionalistTheoryMultilevel.pdf
Bibtex entry:
@article{hooghe2009PostfunctionalistTheoryMultilevel,
title = {A Postfunctionalist Theory of Multilevel Governance},
author = {Hooghe, Liesbet and Marks, Gary},
date = {2009},
journaltitle = {The British Journal of Politics and International Relations},
shortjournal = {The British Journal of Politics and International Relations},
volume = {22},
number = {4},
pages = {1--23},
issn = {1369-1481, 1467-856X},
doi = {10.1177/1369148120935303},
url = {http://journals.sagepub.com/doi/10.1177/1369148120935303},
urldate = {2022-11-29},
abstract = {Multilevel governance describes the diffusion of authority away from the central state. In this contribution, we recount how an archaic term, governance, became part of the vocabulary of political science. We then outline three building blocks of a postfunctionalist theory of multilevel governance. The first is that multilevel governance is cooperation to provide collective goods at diverse scales. The second is that the form governance takes depends on the sociality of the participants. The third is that conflict over community enables or impedes multilevel governance.},
langid = {english},
keywords = {read},
file = {/Users/jan/Zotero/storage/EJTC87K5/Hooghe and Marks - 2020 - A postfunctionalist theory of multilevel governanc.pdf}
}
To Reproduce

Press shortcut to extract
Enter -1 as the pdf starts with a title page, followed by page 1.

Debugging Log
[10:03:19.688] PDF Annotation Extractor[Hotkey] Processing complete
[10:03:19.700] PDF Annotation Extractor[Hotkey] Passing output '' to Run Script
[10:03:23.697] STDERR: PDF Annotation Extractor[Run Script] rmdir: /Users/jan/Obsidian/0 Seedbox/attachments: Directory not empty
[10:03:23.705] PDF Annotation Extractor[Run Script] Processing complete
[10:03:23.706] PDF Annotation Extractor[Run Script] Passing output '' to Post Notification

Workflow Configuration

Checklist

[X] I have updated to the latest version of this workflow.
[X] If the extracted text is all jumbled up (special characters, spaces missing, etc.) then the issue is not with this workflow, but the underlying extraction engine, pdfannots2json. Upgrade it to the latest version with brew upgrade pdfannots2json and try again. If the issue persists, file a bug report at pdfannots2json.

Ah yes. The prompt to enter the first page number only appears if the entry is missing that information. That is intentional, since otherwise automatic page number identification is not possible, and there is little I can do about it on my end, I'm afraid, since there is no way for the workflow to detect if there is a title page or not.
What I do is either to remove the title page (all the relevant information is in my reference manager already anyway), or move that title page to the end of the document.


Update test.py

I highly suggest for simplifying and easier debugging and better readability and understandability of the codes, the environment creation gets it's own function and gets separated from the train and test functions.
One of the prominent advantages of FinRL-Meta is it's modularity and having different independent layers, which the proposed change helps going further in this direction.

@mhdmyz thanks very much! We will do a code review soon!


[red-knot] Support textDocument/didChange notification

Summary
This PR adds support for textDocument/didChange notification.
There seems to be a bug (probably in Salsa) where it panics with:
2024-08-22 15:33:38.802 [info] panicked at /Users/dhruv/.cargo/git/checkouts/salsa-61760caba2b17ca5/f608ff8/src/tracked_struct.rs:377:9:
two concurrent writers to Id(4800), should not be possible

Test Plan
https://github.com/user-attachments/assets/81055feb-ba8e-4acf-ad2f-94084a3efead

Nice! Do you also plan on changing didOpen and didClose to use apply_changes?

Yeah, that's done in the previous PR: https://github.com/astral-sh/ruff/pull/13041


ComposeMultipleContentEmitters check doesn't trigger in for loops

Hi :)
I noticed the following code doesn't trigger the ComposeMultipleContentEmitters warning:
@Composable
fun MultipleContent(otherTexts: List<String>, modifier: Modifier = Modifier) {
    Text("text 1")
    for (otherText in otherTexts) {
        Text(otherText)
    }
}

Or even this one:
@Composable
fun MultipleContent(texts: List<String>, modifier: Modifier = Modifier) {
    for (text in texts) {
        Text(text)
    }
}

Not sure if something can be done about it, but thought I'd report anyway.
Cheers!

We could do a trivial check for an enclosing for loop or forEach lambda, but yeah probably can only do so much here


Add "Uninstall and remove all data" option for removing extensions

Current observed behavior of VS Code (as of 1.38.1) is to keep extension folder and all its contents when extension is uninstalled (observed with ms-python.* extension specifically).
If an extension is subsequently re-installed, existing extension folders are simply reused (apparently without integrity checking).
If extensions folder becomes corrupt for whatever reason, uninstalling and reinstalling extension just preserves corrupted state of the extension, complicating the situation and frustrating the user (see https://github.com/microsoft/vscode-python/issues/7348 issue for additional details on user experience and observed behavior with extension uninstall/reinstall).
It can be argued, that "uninstall" behavior should be "uninstall and wipe out clean" by default, yet, having one more explicit option to "uninstall an remove all data" for an extension should suffice as well.

There is a command Developer: Reinstall Extension which does the same as you requested.


Filter instead of logger

IIRC, a LogFilter can actually modify the LogRecord objects. Perhaps instead of (inflexibly) hard-coding the log format, you could just define a custom filter that wraps parts of the LogRecord with the proper unicode color codes?

Hi @Hamilton and thanks for the feedback. Please try out version 3.0 (just released). I've changed the ColoredStreamHandler into a ColoredFormatter that supports user defined format strings just like logging.Formatter does. I did end up using a filter, but not to inject ANSI escape sequences (that's better done from a custom formatter), but instead to give log records a hostname attribute (this was one thing holding me back from using a formatter - the logging module doesn't natively expose hostnames).

Wrong Hamilton. But I got your back, @hamiltont

@hamilton: Sorry about the bogus notification and thanks for relaying it :-).

Nice! THis looks like a much better approach, I'll check it out when there's time
@hamilton thanks man, I'll get you next time thru when someone tags me instead ;-)


[BUG] [v1.5.4-rc2] V2 volume perform engine upgrade when concurrent-automatic-engine-upgrade-per-node-limit > 0

Describe the bug
Upgrade from v1.5.3 to v1.5.x-head, V2 volume will perform engine upgrade when concurrent-automatic-engine-upgrade-per-node-limit > 0
Did not see this happen when upgrade from v1.5.3 to v1.6.0
longhorn-manager
time="2024-02-15T09:50:31Z" level=error msg="Failed to run engine live upgrade" func="controller.(*EngineController).syncEngine" file="engine_controller.go:323" controller=longhorn-engine engine=pvc-f6524606-4251-4181-bad0-8a07c4e43534-e-0 error="failed to live upgrade image for pvc-f6524606-4251-4181-bad0-8a07c4e43534-e-0: proxyServer=<IP_ADDRESS>:8501 destination=<IP_ADDRESS>:20006: failed to get server version: rpc error: code = Unknown desc = failed to get version detail: rpc error: code = Unavailable desc = connection error: desc = \"error reading server preface: http2: frame too large\"" node=ip-172-31-36-118

instance-manager
[longhorn-instance-manager] time="2024-02-15T09:44:33Z" level=info msg="Started new process manager update watch" func="process.(*Manager).ProcessWatch" file="process_manager.go:359"
[longhorn-instance-manager] time="2024-02-15T09:44:33Z" level=info msg="Started new SPDK service engine update watch" func="spdk.(*Server).EngineWatch" file="server.go:638"
[longhorn-instance-manager] time="2024-02-15T09:44:33Z" level=info msg="Started new SPDK service replica update watch" func="spdk.(*Server).ReplicaWatch" file="server.go:363"
[2024-02-15 09:46:53.801294] tcp.c:2104:nvmf_tcp_pdu_ch_handle: *ERROR*: The TCP/IP connection is not negotiated
[2024-02-15 09:47:01.227900] tcp.c:2104:nvmf_tcp_pdu_ch_handle: *ERROR*: The TCP/IP connection is not negotiated
[2024-02-15 09:47:23.800482] tcp.c:1498:nvmf_tcp_qpair_handle_timeout: *ERROR*: No pdu coming for tqpair=0x22967a0 within 30 seconds
[2024-02-15 09:47:31.217207] tcp.c:2104:nvmf_tcp_pdu_ch_handle: *ERROR*: The TCP/IP connection is not negotiated

To Reproduce

Deploy v1.5.3, enable v2 data engine
Have v2 volume with data
Upgrade to v1.5.x-head (v1.5.4-rc2)
Set concurrent-automatic-engine-upgrade-per-node-limit > 0
Wait few seconds, V2 volume will perform engine upgrade automatically

Expected behavior
Do not perform v2 engine upgrade
Support bundle for troubleshooting
supportbundle_3daa3ce3-0c63-4d76-9f71-c4de4d0c6f46_2024-02-15T09-49-34Z.zip
Environment

Longhorn version: v1.5.x-head
Impacted volume (PV): pvc-f6524606-4251-4181-bad0-8a07c4e43534
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): kubectl
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: v1.28.5+k3s1

Additional context
N/A

We did not support engine upgrades for v2 in 1.5, but this should be supported in 1.7.


Support for SSL

Related:

https://github.com/dataops-tk/tapdance/pull/43
https://towardsdatascience.com/how-to-connect-to-a-postgresql-database-with-python-using-ssh-tunnelling-d803282f71e7#e325
Implementation in tap-mysql: https://github.com/transferwise/pipelinewise-tap-mysql/commit/2f1b0fd4c69a440350c2a92ad2fef8bd417c080e


Sparkle is placed on top of text when there would be good space on next line

open a file with 1 line of content
place cursor on next line
observe that the sparkle could appear below the cursor where it would not interfere with any content, but it now appears on top of the text above, interfering with the content there.

added some fixes to a draft PR! not sure if we want it to go in this late, but the idea and demo is in the PR and we can try it out in insiders next iteration


Updated documentation with current link to the JXCore

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


ocamlPackages.asai: 0.3.0 -> 0.3.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/RedPRL/asai/releases.
meta.description for ocamlPackages.asai is: Library for constructing and printing compiler diagnostics
meta.homepage for ocamlPackages.asai is: https://redprl.org/asai/asai/
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.3.1 with grep in /nix/store/5kl3fpkc9hq5m3xmw03b556wibr73mxz-ocaml5.2.0-asai-0.3.1
found 0.3.1 in filename of file in /nix/store/5kl3fpkc9hq5m3xmw03b556wibr73mxz-ocaml5.2.0-asai-0.3.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5kl3fpkc9hq5m3xmw03b556wibr73mxz-ocaml5.2.0-asai-0.3.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ocamlPackages.asai https://github.com/r-ryantm/nixpkgs/archive/88beeeb88dedb7092d233d4e5374a64bc6523f64.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/88beeeb88dedb7092d233d4e5374a64bc6523f64#ocamlPackages.asai

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5kl3fpkc9hq5m3xmw03b556wibr73mxz-ocaml5.2.0-asai-0.3.1
ls -la /nix/store/5kl3fpkc9hq5m3xmw03b556wibr73mxz-ocaml5.2.0-asai-0.3.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

ocamlPackages.asai

Maintainer pings
cc @vbgl for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Euh, but the update does fix string_of_text for OCaml >=5.2. Is setting minimalOCamlVersion = "5.2"; acceptable for the package? Or should we keep multiple versions of it in Nixpkgs?


✨ Add support for Poetry 1.2.0 and above (including 1.5.1), deprecate support for Python 3.6

The goal of this PR is to resolve issues documented in #27 and compatibility issues mentioned in #25.
This PR resolves:

a bad method reference to module_name in poetry.utils.helpers@module_name which is now only available via poetry.core.utils.helpers@module_name
invalid method exception encountered on set_version as it was recently removed and rewritten to handle hashing under poetry.core's ProjectPackage._set_version(version, pretty_version)

Additionally, this PR updates some dependencies to allow pytest  to execute under Python 3.10.
Tests are passing with the provided changes.
Related to #27 and #25 (probably fixes them)

@tiangolo @Gl0deanR Any chance this gets merged soon? All the new versions of poetry are simply not supported without this patch.

I think I understand why Tiangolo gave up on this project. importlib.metadata.version does this without any plugins required. Poetry uses it too.

Thanks a lot @mbeacom! 🚀
And thanks everyone for the comments here.
I updated a couple of extra packages to be able to run the tests locally and tweaked a couple of extra things.
I'm not sure why Codecov is reporting some lines as not reached despite the tests that check for that exact output are passing. But anyway, I plan on moving away from Codecov, so that's fine for now.


Update location of NSA RHEL 5 Guide

closes https://github.com/dev-sec/ansible-os-hardening/issues/227
Updates the URL to the NSA Guide to the Secure Configuration of Red Hat Enterprise Linux 5 (version 4.2)
I chose to not link directly to the PDF on purpose as 'Get File' seems to be setting a WpKes param that's required to get the file and seems to be unique. I figure interested folks can click Get File for now.

Thanks @jaredledvina!


Problems with adding an unary operator

I've found a problem when adding an unary operator '~' to an Expression.
exp.addOperator(new AbstractUnaryOperator("~",60,false) {
@Override
public BigDecimal evalUnary(BigDecimal bigDecimal) {
return bigDecimal;
}
});
unknown unary operator  '~' occured.
Did anyone have this problem?

@TotemGuo:  A bit late answer, but I fixed this in commit e5c164680b0b15e838b4dd5f338fec4b0d32fedb