Configuration Error:  Join-Path : Cannot bind argument to parameter 'Path' because it is null.

I am getting below error after installing and executing ember-cli-windows. Please suggest the solution.
Configuration Error:  At C:\Users*****\AppData\Roaming\npm\node_modules\ember-cli-windows\powershell\setup-search.ps1:23 char:26

Add-Type -Path (Join-Path <<<<  $PSScriptRoot "Microsoft.Search.Interop.dll")

CategoryInfo          : InvalidData: (:) [Join-Path], ParameterBindingValidationException
FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Microsoft.PowerShell.Commands.JoinPathCommand

Configuration Error:  New-Object : Cannot find type [Microsoft.Search.Interop.CSearchManagerClass]: make sure the assembly containing this type is loa
ded.

Hey Tarak, thanks for reporting this. I'm sure we can fix this, as the script is complaining about not finding the Windows Search DLL. Can you do me a quick favor and tell me about the following:

If you open up C:\Users*****\AppData\Roaming\npm\node_modules\ember-cli-windows\powershell, do you see a DLL?
Which version of Windows are you running?

Thanks!

I can see Microsoft.Search.Interop.dll exists in that directory. For a note, I do not have admin privileges to my system. Is this something to worry about. In my system, windows defender is OFF and we do have an antivirus client which we can configure at our end.

Hm, you shouldn't need Admin privileges. It's possible that your Admin locked down more rights, keeping you from even using the Search feature - which version of Windows are you running on?

Sorry I missed that part. I am using Windows 7 machine.

It might be that you have an older powershell than required to use $PSScriptRoot. Based on this SO answer $PSScriptRoot was introduced in Powershell 3 so if you have a version older than that it won't work and therefore we could fix that by using a different way of getting executing script path.
@tarak162 Would you mind checking your powershell version by invoking either Get-Host or $PSVersionTable.PSVersion and paste the output here in the comment? That would really help us in getting it working properly for you.

That said, a quick workaround for you would be to upgrade to newer Windows Management Framework by following a link in the WMF download matrix and in the meantime we might fix that for older versions.

Thanks for looking into this. I was on vacation and could not back to you. Here is my powershell info. Looks like I have version 2 installed.

I can even try upgrading newer powershell version but that needs installing other softwares along with new powershell. This needs sys admin's approval. Is there any work around in the code to get it fixed.

@tarak162 Could you please clone my fork, switch to issue-5 branch and try the script if it now works on Powershell 2? I have Powershell 4 and don't want to install the older version myself but it should work as is. Thanks. In the meantime I'll send a pull request.

@mareksuscak Looks like that error is gone now. But do we need admin privileges to run this? It is opening powershell window and asking for admin id, pwd.

Yes, you need admin privileges to change Windows Search settings - you anyway need them to make ember-cli builds faster because without admin privileges you probably don't have Create Symlink permissions (see here for further info) and also you cannot change the local computer policy to add this permission to your account without privilege elevation.
@felixrieseberg So my fix worked on both Powershell 2 (confirmed by @tarak162) and Powershell 4 (tested by me) - you can close this issue and accept my pull request I guess.

Along with above, I am also getting below error. Below is the complete process and logging
Configure Windows for Ember-Cli Performace
If you continue, this tool will automate the configuration of Windows Defender and Windows Search
Confirm: Do you want to proceed? (Y/N):  Y
Configuring Defender
Configuring Search
Removing file:///e:\workspace\em-cli\tmp* from Search Index
Configuration Error:  Exception calling "AddUserScopeRule" with "4" argument(s): "Value does not fall within the expected range."
Configuration Error:  At C:\Users****\AppData\Roaming\npm\node_modules\ember-cli-windows\powershell\setup-search.ps1:41 char:27

$crawlman.AddUserScopeRule <<<< ($tmpPath,$false,$true,$null)

CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
FullyQualifiedErrorId : DotNetMethodException

Done
Windows Search configured!
Finished Search Configuration.
*
Configuration Error:  Start-Process : This command cannot be executed due to the error: The operation was canceled by the user.
Configuration Error:  At C:\Users****\AppData\Roaming\npm\node_modules\ember-cli-windows\powershell\setup-defender.ps1:64 char:22
Configuration Error:  +         Start-Process <<<<  PowerShell.exe -Verb Runas -WorkingDirectory $pwd -ArgumentList $argList
Configuration Error:      + CategoryInfo          : InvalidOperation: (:) [Start-Process], InvalidOperationException
+ FullyQualifiedErrorId : InvalidOperationException,Microsoft.PowerShell.Commands.StartProcessCommand
Configuration Error:
Windows Defender configured!
Finished Defender Configuration.

Thanks, So what's the advantage of using this for a windows user who does not have admin privilege?

@tarak162 I believe you are on Windows 7. There's been this error in the script in previous versions but it should be fixed already in ember-cli-windows 1.3.1 so ensure you have the latest version.
Please note that if you are using ember-cli-windows-addon it hasn't been updated yet to use ember-cli-windows 1.3.1 - instead it is still using 1.3.0 which didn't have this issue fixed. So your best bet is to install ember-cli-windows globally and use it without addon for now. @felixrieseberg Could you update the dependency?
Regarding your question - there's this advantage that you don't have to configure Windows Search and Defender by hand each time you create new ember application. I recommend to ask your employer for admin privileges because usually developer cannot live without them - I know what I'm talking about, believe me.

Thanks @mareksuscak . Finally I am able to run ember-cli-windows with the help of admin privileges but I did not see any improvements in my build times. Below are my build times
Build successful - 315841ms.
Slowest Trees                  | Total
-------------------------------+----------------
TreeMerger (stylesAndVendor)   | 64257ms
ES6: App Tree                  | 37963ms
TreeMerger (appAndDependencies) | 30032ms
CustomStaticCompiler           | 29100ms
TreeMerger                     | 29070ms
file changed templates\member-benefits.hbs
Build successful - 267123ms.
Slowest Trees                  | Total
-------------------------------+----------------
CustomStaticCompiler           | 46051ms
TreeMerger (appAndDependencies) | 30124ms
TreeMerger (stylesAndVendor)   | 20078ms
TreeMerger (ExternalTree)      | 16821ms
ES6: App Tree                  | 13852ms
file changed templates\member-benefits.hbs
Build successful - 203747ms.
Slowest Trees                  | Total
-------------------------------+----------------
CustomStaticCompiler           | 18528ms
TreeMerger (appAndDependencies) | 15597ms
Babel                          | 12380ms
ES6: App Tree                  | 12063ms
TreeMerger (stylesAndVendor)   | 11882ms
ES3SafeFilter                  | 11230ms
TreeMerger (ExternalTree)      | 10753ms
file changed templates\member-benefits.hbs
Build successful - 221056ms.
Slowest Trees                  | Total
-------------------------------+----------------
Funnel: App JS Files           | 31896ms
ES6: App Tree                  | 27292ms
TreeMerger                     | 20733ms
CustomStaticCompiler           | 18259ms
TreeMerger (appAndDependencies) | 16584ms

Closing this issue since the error is fixed. But my build times are not affected.

@tarak162 make sure to run powershell in which you are running ember serve or ember build as an administrator. There's a good chance this is due to not being able to create symlinks which broccoli asset builder uses. Like I said check out this.

@mareksuscak I made symlink changes but did not see any improvement.
Your suggestion to run ember build/serve as an admin worked perfectly. Now it has reduced to nearly 10 times lower. This is really a good suggestion. Thanks a lot. Looks like all these are tightly related to admin privileges. It would be better to have admin account on windows or use linux machine.
Below are my new build times
file added templates\member-benefits.hbs___jb_bak___
file deleted templates\member-benefits.hbs___jb_bak___
file changed templates\member-benefits.hbs
Build successful - 36162ms.
Slowest Trees                  | Total
-------------------------------+----------------
Funnel: App JS Files           | 6596ms
TreeMerger (appAndDependencies) | 5113ms
ES6: App Tree                  | 4637ms
JSHint app- QUnit              | 2473ms
JSHint tests- QUnit            | 2076ms
Babel                          | 1893ms
file changed routes\application.js
Build successful - 42800ms.
Slowest Trees                  | Total
-------------------------------+----------------
ES6: App Tree                  | 6813ms
Funnel: App JS Files           | 6612ms
TreeMerger (appAndDependencies) | 4220ms
Babel                          | 3244ms
JSHint app- QUnit              | 2676ms
Concat: App                    | 2184ms
file changed routes\application.js
Build successful - 32240ms.
Slowest Trees                  | Total
-------------------------------+----------------
Funnel: App JS Files           | 5370ms
TreeMerger (appAndDependencies) | 4913ms
JSHint app- QUnit              | 3176ms
ES6: App Tree                  | 2325ms


Support setting auto scroll speed

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.SunQiang_DXM seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


İbax Coin Mining

Clear and concise description of the problem
How will it work to be a system mined coin, cloud mining or with graphics cards? If we take the example of ethereum where many blocks work together, it would be more useful for a real mining project.
Suggested solution
For inter-block transfers and coin supply, both burning and digging should start as soon as possible.
Alternative
No response
Additional context
No response
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

There is no need for advertisement for a real project, you do your job, everyone hears it.

minnig is storng

The innovation of the IBAX blockchain network is creation of the metaverse world. It is committed to mapping the real society to the metaverse world beyond the real-world nodes and space constraints. To maintain the long-term development of the metaverse, IBAX needs a network where a huge number of creators build a metaverse together. Therefore, 18.75% of all coins is reserved to reward creators of outstanding NFTs for the metaverse. An address of each creator may only own up to 10 NFTs. Each NFT has the Power of 1 to 100. The higher this value, the higher the possibility to get the metaverse rewards.
There are three ways to get NFTs:

New accounts can get a one-time metaverse bonus. Users who deposit coins to the account and lock them for staking for 1 month instantly get one freshly minted metaverse NFT.
Users can fuse two NFTs in their account into one new NFT. The resulting Power of the new NFT may be either greater or smaller than the sum of Power values of the two original NFTs.
Users can go to a decentralized NFT trading platform to buy NFTs with a high Power value fused by other users and transfer them to their account. The launch of IBAX mainnet will enable the reward mechanism for NFT creators. Its aim is to promote the metaverse development and reach the mature metaverse world as quickly as possible.

Rules:

Users can create an account in IBAX Network free of charge. Each account gets one NFT of 1.00 Power.
Users who stake 10,000 IBXC for 30 days can join IBXC mining using the NFT of 1.00 Power within these 30 days.
After 30 days of staking, the initial NFT of 1.00 Power can be transferred/exchanged (i.e., it becomes a free NFT).
Two free NFTs can be fused on IBAX Network according to the fusing rules to create a new free NFT with a different Power value.
One account can own up to 10 NFTs.

Please read IBAX Network Whitepaper: https://bit.ly/3pZHrj4


Path Worker prepends file:// only in paths starting with C:

The library works only if the project is in the root directory at c:.
original function present in monero-javascript/src/main/js/common/LibraryUtils.js
static _prefixWindowsPath(path) {
    if (path.indexOf("C:") == 0 && path.indexOf("file://") == -1) path = "file://" + path; // prepend C: paths with file://
    return path;
  }

my proposal for the fix
static _prefixWindowsPath(path) {
    if (/^[A-Z]:/.test(path) && path.indexOf("file://") == -1) path = "file://" + path; // prepend C: paths with file://
    return path;
  }

this way it is possible to have the project and the node_modules folder in a disk drive other than c, as happened in my thing.

Nice, thanks. It will be in the next release expected within a few days.

This is now supported in the v0.8.0 release. Thanks again.

Closing as resolved. Please let me know if you see any issue. Thanks.


Cannot get latest version: module contains a go.mod file, so module path should be github.com/github/hub/v2

I want to import the version v2.14.2 of github.com/github/hub.
First, I did this：
What did you do?
go get github.com/github/hub

What did you expect to see?
Correctly download latest version
What did you see instead?
go: finding github.com/github/hub v2.11.2+incompatible
go: downloading github.com/github/hub v2.11.2+incompatible
go: extracting github.com/github/hub v2.11.2+incompatible
go: finding github.com/mattn/go-isatty v0.0.12
go: downloading github.com/golang/crypto v0.0.0-20190829043050-9756ffdc2472
go: finding github.com/kballard/go-shellquote latest
go: finding github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: extracting github.com/golang/crypto v0.0.0-20190829043050-9756ffdc2472
go: extracting github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: finding gopkg.in/yaml.v2 v2.2.8
go: finding github.com/mattn/go-colorable v0.1.6
go: finding github.com/atotto/clipboard v0.1.2
go: downloading github.com/atotto/clipboard v0.1.2
go: extracting github.com/atotto/clipboard v0.1.2

Old version (v2.11.2) is pulled.
Then, I try like this:
What did you do?
go get<EMAIL_ADDRESS>
What did you expect to see?
Correctly download v2.14.2.
What did you see instead?
go: finding github.com/github/hub v2.14.2
go: finding github.com/github/hub v2.14.2
go get<EMAIL_ADDRESS><EMAIL_ADDRESS>invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2

It looks like the module path in go.mod isn't correct:
https://github.com/github/hub/blob/v2.14.2/go.mod#L1
module github.com/github/hub

According to https://golang.org/cmd/go/#hdr-Module_compatibility_and_semantic_versioning
Because the version is >= v2, I believe you need to have the major version at the end of the module path in your module directive in your go.mod file，like this:
module github.com/github/hub/v2

Related issue: golang/go#35732

@mislav  @kfcampbell

Thanks for the heads-up! I think /v2 would make sense. We discussed it briefly in https://github.com/github/hub/pull/2138#discussion_r284286819 and you are welcome to send a PR.
However, note that if you are importing our code in your own project, this repository hosts a CLI app written in Go, not a collection of reusable libraries—even though after adding /v2, nothing is stopping you from importing this into your app. Because we don't maintain anything in this repo as a library, we don't uphold a compatibility promise either. We might move/rename methods while we're still at v2.
Which part of this project are you aiming to import?
BTW I've just tried go get github.com/github/hub with go 1.14 and it correctly downloaded and compiled hub 2.14.2. 😕

I  tried go get github.com/github/hub with go 1.14, still not work.
go version
go version go1.14.2 windows/amd64
go get github.com/github/hub
go: github.com/github/hub upgrade => v2.11.2+incompatible
go: finding module for package github.com/mattn/go-isatty
go: finding module for package github.com/mattn/go-colorable
go: finding module for package gopkg.in/yaml.v2
go: finding module for package github.com/atotto/clipboard
go: finding module for package github.com/BurntSushi/toml
go: finding module for package github.com/mitchellh/go-homedir
go: finding module for package github.com/kballard/go-shellquote
go: found github.com/atotto/clipboard in github.com/atotto/clipboard v0.1.2
go: found github.com/kballard/go-shellquote in github.com/kballard/go-shellquote
 v0.0.0-20180428030007-95032a82bc51
go: found github.com/BurntSushi/toml in github.com/BurntSushi/toml v0.3.1
go: found github.com/mitchellh/go-homedir in github.com/mitchellh/go-homedir v1.
1.0
go: found gopkg.in/yaml.v2 in gopkg.in/yaml.v2 v2.2.8
go: found github.com/mattn/go-colorable in github.com/mattn/go-colorable v0.1.6
go: found github.com/mattn/go-isatty in github.com/mattn/go-isatty v0.0.12

Which part of this project are you aiming to import?

So, for us, we're not using it as a library, we're using the tools.go convention to pull hub in as a dep (replacing our older hacked-together convention). Obviously, gomod doesn't really have a way to declare a distinction between api compat and cmdline compat (kind of unfortunate) but we work around that by paying attention when we run go get -u :D

Thank you for your change. That helps a lot.
I'm not the only one who uses "github.com/github/hub" as a library.
I found 22 other repos in github.com who uses "github.com/github/hub" as a library and uses module.
https://github.com/search?q="github.com%2Fgithub%2Fhub"+extension%3Amod&type=Code

I‘m sorry.It still not work well.
I think you need to tag this commit (e50cc02)[https://github.com/github/hub/commit/e50cc02b1d4085928ef35302c3853f7be6d0923f] with the version (v2.14.3 or others), not just commit to the master.
>go get<EMAIL_ADDRESS>go: finding github.com/github/hub v2.14.2
go: finding github.com/github/hub v2.14.2
go get<EMAIL_ADDRESS><EMAIL_ADDRESS>invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2

> go get github.com/github/hub@e50cc02
go: finding github.com/github/hub e50cc02
go: finding github.com/github/hub e50cc02
go get github.com/github/hub@e50cc02: <EMAIL_ADDRESS>invalid version: go.mod has post-v1 module path "github.com/github/hub/v2" at revision e50cc02b1d40

> go get github.com/github/hub/v2
go get github.com/github/hub/v2: module github.com/github/hub@upgrade found (v2.11.2+incompatible), but does not contain package github.com/github/hub/v2

> go get github.com/github/hub/v2@e50cc02
go: finding github.com e50cc02
go: finding github.com/github/hub/v2 e50cc02
go: finding github.com/github e50cc02
go: finding github.com/github/hub e50cc02
go: downloading github.com/github/hub/v2 v2.14.3-0.20200418155404-e50cc02b1d40
go: extracting github.com/github/hub/v2 v2.14.3-0.20200418155404-e50cc02b1d40

@KateGo520 We will release at our own schedule. Until then, are you able to use github.com/github/hub/v2@e50cc02 to solve your case?

Yes, it solve my problem for now, I look forward to your release.


question about canonical smiles

Hello
Thanks for the great resource.
I found some non-standard smiles in the "ligand_rdkit_canonical_smiles" (please see attached image). I think canonical smiles are not supposed to be like this. I was wondering if I need to use "ligand_resolved_simles" instead? Is there some annotation that I can use to detect such non-standard smiles?
Thank you in advance
Ali

@AliSaadatV , the rdkit_canonical_smiles are exactly the smiles that are canonical to rdkit software, and are output by Chem.CanonSmiles:  https://github.com/plinder-org/plinder/blob/main/src/plinder/data/utils/annotations/ligand_utils.py#L866
Regarding what you think the canonical smiles suppose to be like - may I refer you to this comment by Greg Landrum:
https://github.com/rdkit/rdkit/issues/2747#issuecomment-547827421
Unless there are strong reasons why community needs multiple "canons" to be supported, we intend leave this to the user to make the conversion into their preferred standards.
Feel free to join the P(L)INDER user group Discord Server if you would like to discuss this or other ideas relating to the dataset further.


[FLINK-19810][CI] Automatically run a basic NOTICE file check on CI

What is the purpose of the change
For every release, we are manually validating the NOTICE files, according to this wiki page: https://cwiki.apache.org/confluence/display/FLINK/Licensing
The most time-consuming task is ensuring that all modules that deploy a shaded dependency to maven central are properly documenting this dependency in their NOTICE file.
I would like to add a tool to Flink that checks if all shaded dependencies are at least mentioned in the NOTICE file.
We will still need to perform a manual checks, but the tool should catch the most common, severe and difficult to find problems.
Verifying this change
The CI build should fail with a number of current licensing issues present on master. I haven't analyzed all of them to the fullest extend. Once the principle idea of this PR is approved, I will fix them.

I went through the issues the checker found, but most of them appear to be invalid:
Contradicting statement(similar instances exist for kinesis, flink-oss-fs-hadoop, and possibly others):
Could not find dependency org.apache.commons:commons-compress:1.20 in NOTICE file /__w/2/s/flink-formats/flink-sql-avro/src/main/resources/META-INF/NOTICE
Dependency com.apache.commons:commons-compress:1.20 is mentioned in NOTICE file /__w/2/s/flink-formats/flink-sql-avro/src/main/resources/META-INF/NOTICE, but is not expected there

The flink-dist warnings appears to be mostly incorrect.

Thanks a lot for taking a look. I believe the statement by the tool is correct: The notice file contains the following dependency: com.apache.commons:commons-compress:1.20, but the expected dependency is org.apache.commons:commons-compress:1.20. Notice the com. vs org.
Do you agree to how the tool is integrated into the build process in priciple? If so, I will check and fix all dependency issues found by the tool, so that we can merge it.

I'm still not a fan of automating the verification; people will see the tool as the source of truth (which it isn't, as you pointed out), and any attempt at automating the generation can now be shut down with "well we have a tool to check the correctness, so let's not spend time on it".
That said, it is obvious that it does find issues; particularly subtle ones that can easily be missed during a manual review, com vs org is subtle AF and not really the focus of such a review (as it is more concerned with anything being listed at all and the version being correct).
So I am, begrudgingly, fine with it.

Once I'm done with the license check for this release, I can make an assessment of how well the tool works.
If I'm confident that it can also handle edge-cases, I could look into automating it. What we need is basically a mapping from dependency --> license. We could make the build fail if this mapping doesn't exist for a dependency.
I will proceed with addressing the licensing issues I've found so far. I was planning to open separate PRs for different areas of Flink (python, table, connectors), or shall I add them all here to this PR? (this would be easier for me, but only works if you are willing to review them all at once)

Let's add them all here.

Having such a mapping was my idea as well; the explicit failure if a dependency was not found also serves as a reminder to check the license for compatibility.
I don't think this would be tooo difficult tbh.

How would you integrate such a notice file generating build step into the CI pipeline?

I've quickly looked at building our own shade resource transformer, but it seems that we won't have the necessary information available. We would probably need to go even further and change more stuff in the shade plugin.

The current approach depends on the maven build output. We could write the NOTICE file changes directly when the tool runs. Similar to the documentation generator, contributors would need to run the tool locally to keep the NOTICE files up to date. I guess this approach would be preferred.

Any other ideas?

There is no benefit in having the generated files in git, it could just be step of the release process.
On CI we would compile Flink and pipe the build output into a file, then run the generator with this file as input to ensure that the NOTICE files can be generated.

I've quickly looked at building our own shade resource transformer

FYI: Last time I tried it wasn't possible to write custom transformers, and even if you could it would interfere with other transformers touching the notice file (like the appender).

There is no benefit in having the generated files in git, it could just be step of the release process

One benefit would be, that our release process is less complicated
Second benefit is that it is easier to check that the generated NOTICE files are valid when you have to regenerate and commit them. With your approach, we would wait with that until the release, and it would only be done by a few "experts".
I'm undecided here, just discussing to understand our options.
I'll soon push an update that resolves all errors we have so far in our notice files.

One benefit would be, that our release process is less complicated

Doesn't really apply imo because this can be easily automated. While the (build) process is more complicated, it is not more complicated for the RM.

Second benefit is that it is easier to check that the generated NOTICE files are valid when you have to regenerate and commit them. With your approach, we would wait with that until the release, and it would only be done by a few "experts".

Realistically, only experts will look at the results anyway. Once something is generated people stop caring about correctness, and just go through the motions.

There are also downsides to having the generated NOTICE in the source; we've had it happen repeatedly with other generated content (REST API, config docs), that people simply missed generating it and merge things regardless of CI, breaking master.

Thanks a lot for your feedback.

Thanks a lot for your review. I addressed all outstanding comments.
Once you declare the changes so far to be good to be merged, I'll rebase to master. We might have additional licensing issues to address then .. let's see 😃

It seems like you missed this comment, but we can rebase anyway because I don't have concerns in terms of correctness.

I've addressed this comment a while ago. Maybe you are looking at old commits?

This is what I see in the dependencies section, and I don't see a compile scope.
<dependencies>
		<dependency>
			<groupId>com.google.guava</groupId>
			<artifactId>guava</artifactId>
			<version>30.0-jre</version>
		</dependency>
		<dependency>
			<groupId>org.apache.logging.log4j</groupId>
			<artifactId>log4j-slf4j-impl</artifactId>
		</dependency>
		<dependency>
			<groupId>org.apache.logging.log4j</groupId>
			<artifactId>log4j-api</artifactId>
		</dependency>
		<dependency>
			<groupId>org.apache.logging.log4j</groupId>
			<artifactId>log4j-core</artifactId>
		</dependency>
	</dependencies>

Ah, sorry. My comments have been confusing. I've initially had a scope there, then removed it (probably even before opening the PR, that's why I assumed you are referring to an outdated version of the PR).
Isn't the "compile" scope the default scope: http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope
The dependencyManagement section of flink-parent isn't changing the scope of the dependency.

I rebased the change to master, locally the license check has passed.
Once you give approval, I'll clean up the history, rebase & run it on CI one more time and then merge it.

We have explicit test dependencies on log4j in the root pom. They are not defined in the dependency management, so that not every module has to declare this stuff again.

This is also why flink-dist has explicit compile depencies on log4j ;)

I see. Thanks a lot for your patience and the explanations.

Thanks!


Custom value transform for all components

This PR enables all components to accept the "transform" prop and introduces breaking changes. I've attempted to maintain the same API for most components, but please note that alterations to component value types in this PR may result in type errors for some users.
Breaking Changes:

The transform.output prop in TextFieldElement now passes the event object to the callback instead of event.target.value or +event.target.value.
The types of value and options props have changed for some components. Consequently, some users may encounter type errors in their code.

@dohomi, if we can merge this in v7 branch and release this as a canary version for the package. I believe, that would be better. This way, more users can test this and provide their feedback to the changes in this PR.

Thanks for adding this @sadik-malik, I was going to raise a PR myself to add it specifically to the Autocomplete component to better support creating new items in a freeSolo Autocomplete.
Currently I'm letting it add a new string into the values and then using setValue to change the string into an option object, but with the transform I'll be able to always ensure an option object is set 🎉

@sadik-malik thank you for your efforts. Your current PR is only possible to be merged into the master branch (as you created it from there I think). Is that OK for you? I can still release it as v7-beta and if everything is OK we push the release further

Ok, we can release it as v7-beta. Also, I will updating the storybook example for this new prop as well in my free time.

Changed branch to v7

I released  7.0.0-beta.0 to npm


Main temp

migration from temp to main branch.
Api changes
Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Infrastructure change

Pull request checklist

[ ] I have added unit tests for new code that I have added
[ ] I have added/updated functional tests where appropriate
[ ] The code follows our coding standards

An exhaustive list of peer review checks can be read here

CI: Security warnings found!


Fix using author-date and author-name instead of commit-date and commit-name

When retrieving the date of the last commit the author-time is taken not the commit-time. This may be confusing when cherry-picking a commit. Same goes for the committer-name. This pull request is one possibility to fix it. Another would be to create a new command that takes the commit-time. Based on the current name of the command (local.branch.current.lastCommitTime) I expected the commit-time and not the author-time.

Thanks for pointing this.


Despawning rigidbody panics

Despawning an entity with a rigidbody causes the following panic:
thread 'main' panicked at 'Attempting to create an EntityCommands for entity 570v0, which doesn't exist.', C:\Users\USER\.cargo\registry\src\github.com-1ecc6299db9ec823\bevy_rapier3d-0.12.0\src\physics\resources.rs:240:26
I think the easiest fix would be to check if the entity still exists, and only remove the components if that is the case.

I ran into this as well.  It only seemed to happen when I was despawning an entity with both collider and rigid body components.

I ran into this as well. It only seemed to happen when I was despawning an entity with both collider and rigid body components.

My entities also have both.

I wasn’t able to reproduce the bug based on our despawn examples, but I think that @Alainx277’s suggestion to check if the entity exists is the right solution. Could you please test the [despawn-fix](https://github.com/dimforge/bevy_rapier/tree/despawn-fix branch) to see if it works for you?

@sebcrozet same error. You patch works.

Yes, fixes the panic for me.

Already reported in on Discord, but this fixes it for me as well. Thanks!

Thank you all for checking!


Specification for: Stepper

Related issues or relevant information?
No response
Design tasks

[ ] Design is fully specified in Figma

[ ] Design component with all relevant states
[ ] Do a accessibility test of the sketches
[ ] Functionality/animation is described and prototyped if relevant
[ ] If there are used any svgs in this component is it available for the developer? [Link]
[ ] Link to Figma design: [Link]
[ ] Pasted screenshot from Figma below :point_down::skin-tone-2:

Development Tasks

[ ] Implement in Storybook
[ ] Make sure all variants/properties is possible to turn on/off
[ ] Make sure the component is usable across different breakpoints/screen sizes

Accessibility tasks

[ ] WCAG-review

Duplicate


@rohit0337 You can find the recording in an S3 bucket named chime-meeting-sdk-<aws-account-id>-<region>-recordings. E.g. chime-meeting-sdk-1234567890-us-east-1-recordings

@rohit0337 You can find the recording in an S3 bucket named chime-meeting-sdk-<aws-account-id>-<region>-recordings. E.g. chime-meeting-sdk-1234567890-us-east-1-recordings
This is pointed out in the README section Stop the recording and view the recording artifact point number 2
Once the recording stops, open the AWS Console and navigate to Amazon S3. You will find a recording in the bucket chime-meeting-sdk-<aws-account-id>-<region>-recordings, with a key name YYYY/MM/DD/HH/.mp4.

Originally posted by @anuranduttaroy in https://github.com/aws-samples/amazon-chime-sdk-recording-demo/issues/30#issuecomment-663301030

hi
we are implementing the recording feature and wants the saved recording location/ name to save against the meeting in our own database. Hence the meeting attendees can access the recording from our portal.
so how can we achieve recorded video s3 name and path in the response of "stop recording api"

Here are the steps we are following related to storing the meeting recording.

We are creating the Recording Artifacts S3 Bucket here : https://github.com/aws-samples/amazon-chime-sdk-recording-demo/blob/master/templates/RecordingDemoCloudformationTemplate.yaml#L74-L79.
Passing this bucket name as an environment variable to the lambda function here: https://github.com/aws-samples/amazon-chime-sdk-recording-demo/blob/master/templates/RecordingDemoCloudformationTemplate.yaml#L120
The lambda reads the bucket name from the environment variable here: https://github.com/aws-samples/amazon-chime-sdk-recording-demo/blob/master/src/index.js#L13
It then passes the bucket name to the ECS Task as part of container overrides here: https://github.com/aws-samples/amazon-chime-sdk-recording-demo/blob/master/src/index.js#L105
That variable is received here in run.sh: https://github.com/aws-samples/amazon-chime-sdk-recording-demo/blob/master/recording/run.sh#L14
It uses that variable to pass it on to record.js which does the media capture & storing it to s3: https://github.com/aws-samples/amazon-chime-sdk-recording-demo/blob/master/recording/run.sh#L69
That is being used to initialize the s3 uploader here: https://github.com/aws-samples/amazon-chime-sdk-recording-demo/blob/master/recording/record.js#L77

As you can see, we need to pass it on to the recorder while starting it. If the bucket name is static, you can store it somewhere and return it as part of the stop recording API call which is constructed here: https://github.com/aws-samples/amazon-chime-sdk-recording-demo/blob/master/src/index.js#L147-L154
Currently, the stop recording API just stops the ECS Task and returns the response it gets from that.
If you have feedback or feature requests, you can get in touch with us through the AWS Customer Support portal.
Let me know if this helps. Feel free to re-open this issue if you have further questions about this.

hello @anuranduttaroy  where i find these run.sh and record.js in aws console . i know these files are avialable in recording demo of git, but in aws lamda function i am only able to see index.js file


After last updates nodes in JOSM become invisible.

The problem is in lines.mapcss. When I disable this Map Paint Style the nodes become visualized but of course not in lanelet style.

Ah, yes. That got commited accidentally. You would have to remove this entry from your sylesheet.
I'll fix in a week when I have access to our internal Git server.


Vendor maps not produced on @next

Hi, am testing your @next version which awesomely promised vendor source maps. My issue is though that they are not generated. I waited fair bit for them to generate.
Here is my config. Anything fishy there?
const { FuseBox, WebIndexPlugin, CSSPlugin, CSSResourcePlugin, JSONPlugin } = require('fuse-box');
const fuse = FuseBox.init({
  homeDir: 'src',
  target: 'browser@es6',
  output: 'dist/$name.js',
  sourceMaps: true,
  log: {
    showBundledFiles: false,
    clearTerminalOnBundle: false
  },
  plugins: [
    JSONPlugin(),
    WebIndexPlugin({ template: './src/index.html' }),
    [CSSResourcePlugin({ dist: 'dist/css-resources' }), CSSPlugin()]
  ]
});
fuse.dev({
  fallback: 'index.html',
  port: 3000
}); // launch http server

fuse.bundle('vendor').instructions(' ~ index.tsx');

fuse
  .bundle('app')
  .instructions(' !> [index.tsx]')
  .hmr()
  .watch();
fuse.run();

BTW the flag: showBundledFiles: false is completely ignored.

Oh you need to enable them ) read the changelog they are disabled by default. Pass and object and add vendor true


more validators for references, date selection for references

And some changes to handle dates in different components

Still requires some finetuning & rewriting tests but merging should be fine

Forgot to mention that the validator README should be updated to explain the new fields!


Add current and upcoming birthdays to the dashboard

I would like to see current and upcoming birthdays in the same way I can see upcoming national holidays.

https://www.youtube.com/watch?v=y8OnoxKotPQ


incorrect modal window placement

In the 2.0-wip branch, the placement of the modal window is incorrect.
To reproduce the error (tested in firefox only), open the documentation in a "smallish" window (I used 800x600) and open the modal example. You will notice the modal placement is completely arbitrary, it is not centered horizontally or vertically.

http://imagebin.org/193769
PS: As an aside, it would be nice to be able to specify the desired modal window size and placement.

Just resolved this in 2.0-wip—our negative left margin was off by 30px.

That was quick. It seems the horizontal centering is now working, unfortunately the vertical centering is still not there.
Screenshot is latest version of 2.0-wip in firefox.

http://postimage.org/image/odya7s2df/

Has this been resolved?  I'm looking for a fix.


05/07/2018 21:00 : Create Pull Request for branch master -> prTesting1_2018050720

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


implement provider for retrieiving cluster/server group data

@JargoonPard @milismsft PTAL

No tests? :-(

Tests coming in Rd 2

@JargoonPard @milismsft added updates based on CR feedback to date. PTAL

LGTM

@JargoonPard @milismsft  updates based on feedback from code review PTAL

other then the two minor file refactoring suggestions LGTM.

Ship it!


Function of AnnotationLayerBuilder in pdf.js

Hi
I am a beginner to pdf.js, I wonder  about the function of AnnotationLayerBuilder and pdf.js can any body help me out.

The annotation layer builder, as defined at https://github.com/mozilla/pdf.js/blob/master/web/annotation_layer_builder.js, makes sure that annotations in the PDF file are rendered in PDF.js. It is responsible for creating a separate layer (div.annotationLayer) that contains all annotation HTML element.

Thanks for help  timvandermeij


[MM-35926] CRT: Thread viewer long post Show More/Less background is broken

Summary
CRT: Thread viewer long post Show More/Less background is broken
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-35926
Related Pull Requests
None
Screenshots

before
after

Release Note
NONE

Thanks @AshishDhama
Tested, looks good to merge.

Verified long post Show more/less background in all themes.
E2Es report - verified failures are not related to this PR.


Use rake-compiler and rb-sys for build

This PR changes the build system to use rb-sys and rake-compiler to build the gem. With this change, it will be possible to publish native binaries of the gem so that consumers will not have to maintain a rust toolchain for deployment.
The actual publishing of the gem is not handled by this PR, but the cross-build Github action will build a bunch of *.gem files which can pushed to Rubygems.
❤

I hope this wonderful gem will be easy to install.

Hey @ianks, sorry for the delay. Switched to rb_sys + rake-compiler and the directory structure from https://github.com/rubygems/rubygems/pull/5613 in the commit above (wanted to do this separately from precompiling). Will hopefully try out the cross-gem-action soon.
Thanks again for all the work on rb_sys and driving this!

Hey @ianks,
Added precompiling for a few platforms in the commit above (it currently fails on aarch64-linux  since OpenSSL isn't available). It'd be nice if rb_sys provided a way to cross-compile locally as well (if it doesn't already, like rake-compiler-dock).
Thanks again for all the work you've done on Ruby + Rust!

Just released 0.2.0 with precompiled versions for Mac and x86-64 Linux.

🔥 🔥 🔥

Added precompiling for a few platforms in the commit above (it currently fails on aarch64-linux since OpenSSL isn't available). It'd be nice if rb_sys provided a way to cross-compile locally as well (if it doesn't already, like rake-compiler-dock).

Just literally published a fix for that today in v0.9.47. Hopefully that fixed it!

. It'd be nice if rb_sys provided a way to cross-compile locally as well (if it doesn't already, like rake-compiler-dock).

Ah yes, it is actually just rake-compiler-dock under the hood so it should work fine. Admittedly, I don't do it often because currently arm64 builds for rcd aren't published. And since I'm on an M1, they are slowwwwww. You can see how it's done here.

Thanks @ianks!
Tried v0.9.47, but think it may solve a different issue (the aarch64-linux failure is due to a missing header required by openssl-sys - need to spend more time on it).

Oof yeah that’s a bit of a doozy. Providing a cross platform version of OpenSSL should be possible in the setup of cross gem action, but ideally the dep on openssl-sys could be removed entirely in favor of rustls. I think this may be coming from the http feature of the tokenizers crate? Not sure though.


Suppress contentEditable warning

This will come into effect with the 15.0 release of React, see https://github.com/facebook/react/pull/6112

Note: I wasn't entirely sure if you want to specify the ={true}, since it can be omitted, and I couldn't find an example with/without it. Let me know if you want me to remove it

/cc @spicyj

With or without the true is fine, thank you. This seems good to me.

I actually ended up getting this as part of #179. Thanks for sending this in though!


feat: implement apply_exponent_factor function in precision.

Feature Request
precision functions have been implemented mostly but apply_exponent_factor is still pending. A non working implementation has been left in comment, maybe it can help. In solidity this function calls a function from an external math library (https://github.com/PaulRBerg/prb-math/blob/5959ef59f906d689c2472ed08797872a1cc00644/src/ud60x18/Math.sol#L481). We will probably need to re-implement it to obtain similar behavior.
Describe Preferred Solution
Implement apply_exponent_factor function. To verify it's working, you can test solidity function with arbitrary values and compare that your function is returning the same. It will be appreciated if you can write comparison results in your PR.

I can try this

Assigned 🔥

Seems that the function we want relies on these : https://github.com/PaulRBerg/prb-math/blob/5959ef59f906d689c2472ed08797872a1cc00644/src/ud60x18/Math.sol#L270 and https://github.com/PaulRBerg/prb-math/blob/5959ef59f906d689c2472ed08797872a1cc00644/src/Common.sol#L54
Should we also implement them? It seems that these functions also relies on sub functions, and that at the end we will re implement the whole library


CI/CD end-goal

Automated tests
Bundle dependencies with releases
Build binaries for the various platforms

Nearly implemented, still need binary releases.


Express "Duck-Typed Interface" as trait

Motivation
To be able to use traits witn wasm-bindgen as an alternative to "Duck-Type Interface"s.
pub trait Quacks {
    fn quack(&self) -> String;
}

#[wasm_bindgen]
pub fn make_em_quack_to_this(duck: impl Quacks) {
    let _s = duck.quack();
}

Currently, this produces two errors:

#[wasm_bindgen] can only be applied to a function, struct, enum, impl, or extern block

I'd love to here move about traits and wasm-bindgen. I've looked through several issues such as https://github.com/rustwasm/rfcs/pull/11 but seem to be missing some likely longer discussion.

the trait bound impl Quacks: wasm_bindgen::convert::traits::FromWasmAbi is not satisfied

Reading through https://docs.rs/wasm-bindgen/0.2.50/wasm_bindgen/convert/index.html it seems to as though implementing your own conversions is discouraged. It might be necessary to support traits like this but I am not sure.
I should note, is it possible to implement the various conversion traits for the example above? I'm wondering if it has been tried.
Proposed Solution
Enable the following example.
pub trait Quacks {
    fn quack(&self) -> String;
}

#[wasm_bindgen]
pub fn make_em_quack_to_this(duck: impl Quacks) {
    let _s = duck.quack();
}

The trait would generate a TypeScript interface called Quacks as well as a JavaScript object. This will likely need to leverage Closure.
Alternatives
Use the recommended "Duck-Typed Interface".
Additional Context
"Duck-Typed Interfaces" are defined in the docs as such:
#[wasm_bindgen]
extern "C" {
    pub type Quacks;

    #[wasm_bindgen(structural, method)]
    pub fn quack(this: &Quacks) -> String;
}

#[wasm_bindgen]
pub fn make_em_quack_to_this(duck: &Quacks) {
    let _s = duck.quack();
}

Thanks for the report here! I agree this would be pretty slick to support, but unfortunately I'm not sure how it would be possible to support. I think the best thing to do in lieu of it though is to use the duck-typed interface pattern, and does that work for your use case?

I'm able to use the duck-typed interface pattern for now 👍
In general, is a tricky for types like Box<dyn Quacks> to be supported in wasm? I'm curious about the future of traits and Box with WebAssembly.

Ok sounds good!
Unfortunately traits going back and forth aren't supported in wasm right now, and there's not a great way of passing in either a RUst argument or a JS argument to something like make_em_quack_to_this. For that you'd have to use a Rust-internal API which is trait bound, and use that from Rust instead.

I'm going to close this because we're unlikely to support trait objects going back and forth.


The logging trace forwarder plugin in the node is broken

Internal/External
Internal   if an IOHK staff member.
Summary
The node is crashing with the below error when RTView is enabled:
cardano-node: ExceptionInLinkedThread "ThreadId 1694" (ApiMisuse (ClosedDBError (Just (UnexpectedFailure (FileSystemError (FsError {fsErrorType = FsTooManyOpenFiles, fsErrorPath = /..../mainnet/db/volatile/blocks-5489.dat, fsErrorString = "No file descriptors available", fsErrorNo = Just (Errno 24), fsErrorStack = CallStack (from HasCallStack):
  prettyCallStack, called at src/Ouroboros/Consensus/Storage/FS/API/Types.hs:296:23 in ouroboros-consensus-<IP_ADDRESS>-L4jPE5sq1ep9SDO9KAnQ9h:Ouroboros.Consensus.Storage.FS.API.Types
  ioToFsError, called at src/Ouroboros/Consensus/Storage/FS/IO.hs:88:41 in ouroboros-consensus-<IP_ADDRESS>-L4jPE5sq1ep9SDO9KAnQ9h:Ouroboros.Consensus.Storage.FS.IO
  handleError, called at src/Ouroboros/Consensus/Storage/FS/IO.hs:84:23 in ouroboros-consensus-<IP_ADDRESS>-L4jPE5sq1ep9SDO9KAnQ9h:Ouroboros.Consensus.Storage.FS.IO
  rethrowFsError, called at src/Ouroboros/Consensus/Storage/FS/IO.hs:37:21 in ouroboros-consensus-<IP_ADDRESS>-L4jPE5sq1ep9SDO9KAnQ9h:Ouroboros.Consensus.Storage.FS.IO
  hOpen, called at src/Ouroboros/Consensus/Storage/FS/API.hs:152:43 in ouroboros-consensus-<IP_ADDRESS>-L4jPE5sq1ep9SDO9KAnQ9h:Ouroboros.Consensus.Storage.FS.API
  withFile, called at src/Ouroboros/Consensus/Storage/VolatileDB/Impl.hs:282:29 in ouroboros-consensus-<IP_ADDRESS>-L4jPE5sq1ep9SDO9KAnQ9h:Ouroboros.Consensus.Storage.VolatileDB.Impl
  getBlockComponentImpl, called at src/Ouroboros/Consensus/Storage/VolatileDB/Impl.hs:221:35 in ouroboros-consensus-<IP_ADDRESS>-L4jPE5sq1ep9SDO9KAnQ9h:Ouroboros.Consensus.Storage.VolatileDB.Impl
  getBlockComponent, called at src/Ouroboros/Consensus/Storage/VolatileDB/API.hs:61:7 in ouroboros-consensus-<IP_ADDRESS>-L4jPE5sq1ep9SDO9KAnQ9h:Ouroboros.Consensus.Storage.VolatileDB.API, fsLimitation = False}))))))

Steps to reproduce
Steps to reproduce the behavior:

configure the nodes as per https://github.com/input-output-hk/cardano-node/pull/2303 --> traceForwardTo
start nodes using 1.26.0 tag
after some time the nodes are crashing with the above error

Expected behavior
The node should not crash.
System info (please complete the following information):

OS: Ubuntu 20.04

$ cardano-cli --version
cardano-cli 1.26.0 - linux-x86_64 - ghc-8.10
git rev 1a25af8527f353fd0f2b863c27250b2990fec22a

$ cardano-node --version
cardano-node 1.26.0 - linux-x86_64 - ghc-8.10
git rev 1a25af8527f353fd0f2b863c27250b2990fec22a

Screenshots and attachments

Additional context
Some preliminary investigations:

the total number of open sockets is much lower (without traceForwarder configured), and also the number of sockets that are not in the established state is none, compared to before when it was lots.

Closing this. If this is still relevant please reopen.


OnAdd + OnRemove not reliably called

Please see latest in this repro for example:
https://github.com/mobyjames/colyseus-unity3d
Steps:

Start server
Start Unity project
Connect
Create Room
Send Message

This triggers the server to add a couple numbers to the array
Expected: OnAdd is called- it is not
A few seconds later, the server will remove these items
Expected: OnRemove is called for each- it's only called for one of them

Oddly, if I convert the field to ArraySchema<string> the onAdd method fires, but the issue with onRemove remains. It only fires for the first removed item.

The OnRemove() issue was a silly mistake during the remove loop: https://github.com/colyseus/colyseus-unity3d/commit/f8ec63558470fdf9a7a90532daa881561b557d82
Apparently the OnAdd() wasn't triggering because of the check for new keys in the Dictionary (https://github.com/colyseus/colyseus-unity3d/commit/c7f9cbcdedc0aef93e8c36d3026aeca8862a7276). The currentValue[newIndex] returns default(int) instead of null. So I've changed this check to use .ContainsKey(newIndex) instead.
I'm afraid MapSchema also has the OnAdd() problem with numbers, I haven't tested with it yet!


Get protofiles from SDK release. Remove Makefile.

Fixes #36.
Also compiles protobuf from sources on the Travis build since there aren't packages from it for Travis' Ubuntu 14.04. I'm not totally satisfied with it since it takes now 24 minutes to complete the build, I'll investigate options to upload a precompiled package somewhere and retrieve it on build.
Signed-off-by: Juanjo Alvarez<EMAIL_ADDRESS>

Yes, I'll look today into compiling it in an Ubuntu 14.04 VM or container and uploading it to google drive.

@abeaumont fixed the compiling kludge, I compiled a deb package for 14.04 and since it seem there isn't an easy/elegant way to download a file non interactively from gdriver, I uploaded the deb in a release in this same repository.


Remove "Data" suffix from consumerdata.TraceData and consumerdata.MetricsData

Instead of consumerdata.TraceData and consumerdata.MetricsData, simply consumerdata.Trace and consumerdata.Metrics

I think we use the suffix in a lot more places, if you really want to be consistent we need to remove TraceConsumer, TraceReceiver, TraceExporter, etc.

I'm starting to sour on this idea: "trace" can be interpreted as the trace of a single operation and "TraceData" captures better the idea that its a bundle of data related to traces. It also involves a large rename of parameters and locals.

If we want to proceed with this we will have to use something like consumerdata.SpanBatch ...

Completed soured in my mind...


 As far as I can tell we're not relying on effect priorities in osu! (cc @nekodex ).
We've had issues with FXSetPriority segfaulting the test runner in the past, but it has not been reported to be doing the same in-game: https://github.com/ppy/osu/discussions/27338
I haven't been able to repro this in osu!framework, but, under pipewire the game should segfault when entering PlayerLoader with the following diff applied:
diff --git a/osu.Framework/Audio/Mixing/Bass/BassAudioMixer.cs b/osu.Framework/Audio/Mixing/Bass/BassAudioMixer.cs
index 2605a84008..1ff9a69fbc 100644
--- a/osu.Framework/Audio/Mixing/Bass/BassAudioMixer.cs
+++ b/osu.Framework/Audio/Mixing/Bass/BassAudioMixer.cs
@@ -14,6 +14,7 @@
 using osu.Framework.Extensions.EnumExtensions;
 using osu.Framework.Extensions.ObjectExtensions;
 using osu.Framework.Statistics;
+using osu.Framework.Utils;

 namespace osu.Framework.Audio.Mixing.Bass
 {
@@ -272,6 +273,14 @@ protected override void UpdateState()
                 removeChannelFromBassMix(channel);
             }

+            foreach (var effect in ActiveEffects)
+            {
+                if (effect.Handle == 0)
+                    continue;
+
+                ManagedBass.Bass.FXSetPriority(effect.Handle, RNG.Next(0, 10));
+            }
+
             FrameStatistics.Add(StatisticsCounterType.MixChannels, activeChannels.Count);
             base.UpdateState();
         }

I considered the alternative of instead removing and re-adding the effects. This causes a short but noticeable glitch when player load finishes.
What's the cause of all of this? I don't know. Likely some sort of x86-register dependent behaviour in BASS (wouldn't be the first time). It's a bit too deep for the time being.

Incidentally... https://github.com/ppy/osu/issues/27466#issuecomment-1974845078
That's windows too by the way.

Hmm, while I don't believe we're using effect priorities in osu! (yet), I should mention that this change may result in unexpected behaviour whenever the order of effects are changed on a mixer.
Not all audio effects are transitive (e.g. compressor->reverb does not result in the same output as reverb->compressor), so if someone using framework reorders effects expecting the output to change and it doesn't (due to this PR), it may lead to some confusion.
I almost think the alternative of a "short glitch" would be preferable, as at least the resulting behaviour (effects processing in the correct order) would be as expected from a user's perspective.
Ultimately this is probably an edge-case that likely no-one will hit, but I could see it potentially happening for a DAW/DJ application for instance, or as a stretch, a game with dynamic effects applying and mutating realtime in response to... stuff.

For now I'm banking on mixers being unused by anyone other than us, so the important part for me at this point is whether that will have an effect on our existing usages of o!f. Effect prioritisation is pretty awkward right now, along with the whole replace-effect-at-index-to-update thing...
(not to mention in going through the code I found potential out-of-range indexing 🙈, it's all so bad)
I'm also considering that we're still lacking nested mixers. With nested mixers, wouldn't effect prioritisation either become a non-issue or become an explicit detail for special cases like you mentioned (due to performance, if anything)?

Yeah I agree, the effect handling in framework is a bit... not great... at the moment.
For the time being, removing FXSetPriority is probably fine because:

We're not even setting effect.Priority anywhere yet, let alone changing it.
We're only using low-pass/high-pass filters in osu! currently, and filters are effectively transitive meaning we're not gonna notice any issues if they're run out of order anyway. That may change in the future though if/when we start using other effects.

I'm not sure I see how nested mixers alleviates anything though? With each mixer having its own list of effects, we're just nesting the problem at that point? 😅
We could probably workaround this in the future by setting priority at effect creation time and then never changing it. Likely that'll be enough for our needs anyway.
Regardless, surely the correct solution here is to get the segfault in BASS_FXSetPriority fixed rather than trying to work around it? ...funnily enough, I came across this surprisingly relevant thread while briefly digging into this 😜 https://www.un4seen.com/forum/?topic=19592.0

Hmm, indeed it it would be nesting the problem... For that particular case I was imagining a structure like this:
Mixer
{
    Effects = { Compressor },
    Children =
    {
        Mixer
        {
            Effects = { Reverb },
            Children =
            {
                /* Tracks, samples, etc */
            }
        }
    }
}

Do you imagine changing priority to be a more common operation, or for it to only be global like my example there?

Honestly? I'm not sure we'll need effect priority changing for osu! itself at all. I imagine we'd be defining effect priority once (e.g. in a BackgroundDependencyLoader method) and then leaving it at that.
I can't really think of any scenarios for osu! off the top of my head where we'd need to alter effect priorities after the fact.


ovos_PHAL_admin doesn't start because of combo_lock.

OSError: [Errno 30] Read-only file system: '/run/shm/combo_locks/b3Zvc19jb25maWc=.lock'
Traceback (most recent call last):
  File "/home/ovos/.venv/bin/ovos_PHAL_admin", line 5, in <module>
    from ovos_PHAL.admin import main
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_PHAL/__init__.py", line 1, in <module>
    from ovos_plugin_manager.phal import find_phal_plugins, find_admin_plugins
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_plugin_manager/__init__.py", line 2, in <module>
    from ovos_plugin_manager.plugin_entry import OpenVoiceOSPlugin
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_plugin_manager/plugin_entry.py", line 1, in <module>
    from ovos_plugin_manager.tts import find_tts_plugins
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_plugin_manager/tts.py", line 3, in <module>
    from ovos_plugin_manager.templates.tts import TTS, TTSContext, TTSValidator, \
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_plugin_manager/templates/__init__.py", line 8, in <module>
    from ovos_plugin_manager.templates.audio import AudioBackend, RemoteAudioBackend
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_plugin_manager/templates/audio.py", line 6, in <module>
    from ovos_bus_client.message import Message
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_bus_client/__init__.py", line 14, in <module>
    from ovos_bus_client.client.client import MessageBusClient, GUIWebsocketClient
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_bus_client/client/__init__.py", line 14, in <module>
    from .client import MessageBusClient, MessageWaiter, MessageCollector
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_bus_client/client/client.py", line 17, in <module>
    from ovos_bus_client.conf import load_message_bus_config, MessageBusClientConf, load_gui_message_bus_config
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_bus_client/conf.py", line 10, in <module>
    from ovos_config.config import Configuration
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_config/__init__.py", line 1, in <module>
    from ovos_config.config import Configuration, LocalConf, RemoteConf
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_config/config.py", line 19, in <module>
    from ovos_config.models import LocalConf, MycroftDefaultConfig, \
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_config/models.py", line 54, in <module>
    class LocalConf(dict):
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_config/models.py", line 61, in LocalConf
    __lock = NamedLock("ovos_config")
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ovos/.venv/lib/python3.11/site-packages/combo_lock/combo_lock.py", line 125, in __init__
    super().__init__(path)
  File "/home/ovos/.venv/lib/python3.11/site-packages/combo_lock/combo_lock.py", line 33, in __init__
    self._init_plock_file()
  File "/home/ovos/.venv/lib/python3.11/site-packages/combo_lock/combo_lock.py", line 42, in _init_plock_file
    f = open(self.path, 'w+')
        ^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 30] Read-only file system: '/run/shm/combo_locks/b3Zvc19jb25maWc=.lock'

I'm running into this as well, not sure why

Delete the /run/shm/combo_locks directory and restart the service, this did the trick for me.
Not sure why this happened.


Very fast downloading for VOD, slow download for streams

Checklist

[ x] I'm reporting a broken site support issue
[x ] I've verified that I'm running youtube-dl version 2019.09.28
[x ] I've checked that all provided URLs are alive and playable in a browser
[x ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ x] I've searched the bugtracker for similar bug reports including closed ones
[x ] I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-f', '95', '-g', '--hls-prefer-native', 'https://youtu.be/L4Cr_S_SXK4']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.09.28
[debug] Python version 3.7.3 (CPython) - Linux-5.0.0-31-generic-x86_64-with-debian-buster-sid
[debug] exe versions: ffmpeg 3.4.6, ffprobe 3.4.6
[debug] Proxy map: {}

Description

Livestream downloading is very very slow - 1.9 FPS . VOD downloading is still very fast
ffmpeg -i $(youtube-dl -f 95 -g --hls-prefer-native https://youtu.be/L4Cr_S_SXK4) -c:v h264_nvenc -strict experimental -t 00:02:00 -f mpegts udp://localhost:8888

Address this to ffmpeg support.

Address this to ffmpeg support.

I should have mentioned that this issue still persists without using FFMPEG
youtube-dl -v -f 95 https://youtu.be/L4Cr_S_SXK4
VOD downloading is very fast.


Tarql outputs invalid RDF with URIs containing spaces

I have encountered several cases where I build a URI using code like:
bind(uri(concat("http://example.com/id/", ?ID)) as ?uri)

Where in the sample data all the values in ID column looked like usable identifiers. Only when the code is used to transform a complete dataset, it transpires that some of the values contain spaces.
In such cases, Tarql will happily output RDF where the spaces are not encoded in the URI, therefore invalid e.g. http://example.com/id/some text.
The issue is only discovered when some downstream tooling throws an error.
Preferably Tarql should throw an error when serializing the RDF so problems are discovered earlier.
Workaround: Always use ENCODE_FOR_URI function to properly encode any non-uri friendly characters.

This is a known issue with Jena. The URI/IRI functions don't do syntax checks. encode_for_URI is indeed the best workaround currently available. SPARQL has no concept of “throwing an error” during query execution, so we can't write a query the aborts with an error if we detect a problem.
If this were fixed in Jena, the fix would probably be that ?uri ends up being unbound. That makes sense with the way SPARQL expression evaluation works, but would arguably be even worse for Tarql because with an unbound ?uri, the CONSTRUCT template will simply not produce any triples where ?uri is used. So, the result would be a valid RDF file, but with some triples silently missing.
Maybe Tarql needs a tarql:assert(...) function that aborts the entire query execution if the argument is false or unbound. Then one could do tarql:assert(isIRI(?uri)) or simply tarql:assert(?uri) to force execution to fail early.

Would it be an option to pipe/stream the output through Jena riot to validate the output?

Would it be an option to pipe/stream the output through Jena riot to validate the output?

That would be possible, but might end up being a waste of time if Jena fixes the issue in the next version in the way I described. So it might be better to see first what way Jena goes with this. And that is difficult to anticipate because the SPARQL spec is unfortunately silent on what IRI/URI should do on invalid input.
I have previously mentioned the IRI/URI issue to @afs but I don't know if there's a Jena ticket for it.

Would be great if IRI/URI just automatically url-encoded the string argument.

That would be one reasonable behaviour. The advantage of treating it as an error would be that it would double as a way of checking whether a string is a valid IRI: isIRI(IRI(?x))


Info

@ilcato Please also add to the changelog of the next release information that if the device is displayed incorrectly or double, it should be removed from the cache first (Homebridge settings).
P.S.: When do you plan to release the next version?

@ilcato Please also add to the changelog of the next release information that if the device is displayed incorrectly or double, it should be removed from the cache first (Homebridge settings).
P.S.: When do you plan to release the next version?

@mkz212 please change the readme file directly with this info. I will manage versioning.

@ilcato Not sure what to do? I added PR with a change in readme. Should I do it differently?

@ilcato Not sure what to do? I added PR with a change in readme. Should I do it differently?

I mean modify the last part of the readme to track the changes. I will modify the version number for the next release.
I will release it after return home and testing with my devices.

@ilcato Maybe you should merge this and release an update so that the warning be already visible? And then we will think about how to solve the problem with double display?

@ilcato Undoing the introduced change is rather the worst way out because those who have already updated and have no problem will be disappointed with the loss of functionality. And it can cause them a problem even if they didn't have it before.
P.S. I'm really sorry. I remembered Apple's problem with dual devices a moment after you released the update and immediately informed about it.

@mkz212, I'm not able to compile

@ilcato But why?

@mkz212, not a problem of typescript compiler.
When I try to npm publish it says:
33 problems (0 errors, 33 warnings)
0 errors and 8 warnings potentially fixable with the --fix option.
ESLint found too many warnings (maximum: 30).

@ilcato I've never published any plugin, only PR so I don't know too much about this. But usually when there were warning, not errors it was through some space at the end of the line or something similiar. But I check this now and I cannot find anything like that.

@ilcato oh.. ok.. i know!

@ilcato Do you know which PR is affected by the problem? Maybe include only a part and see if it helps?

@ilcato Mayby this: https://github.com/ilcato/homebridge-fibaro-home-center/pull/160 ? I wrote that I am not sure about it. Especially as to || 0

@ilcato I completely do not understand the last message Damianod.. Nothing has changed regarding lights and icons.. Right? But recently there was a big update of the HC 3 and HC 3 Lite (to v. 5.150.15) so maybe it changed something?

@ilcato Once again, I am very sorry for this situation. I think that in order to avoid similar situations in the future, it would be good to release beta versions first. Also it will be good to enable automatic PR checking.

@ilcato Once again, I am very sorry for this situation. I think that in order to avoid similar situations in the future, it would be good to release beta versions first. Also it will be good to enable automatic PR checking.

See my last post in the issue

@ilcato Mayby this: #160 ? I wrote that I am not sure about it. Especially as to || 0

published 1.4.1

@ilcato I'm sorry to hear that you're ending up with this plugin. My adventure with Homebridge began only by the fact that the Fibaro application is hopeless and your plugin is the best that could happen to Fibaro.
As for this unfortunate mistake with dual devices, I completely forgot that Apple has such an problem. As I have already written, this is not the fault of this plugin, it applies to other plug-ins as well as other systems like Home Assistant.
I hope that apart from this one fact, I will somehow help someone with the additions / corrections introduced.

@ilcato I don't know what to do now? That pinned post will probably not be useful anymore because everyone who enters there will see a long discussion that will not help him in any way.


User is already a Stripe customer with ID, but it's been deleted

Cashier Version: 11.2.0
Laravel Version: 7.6.1
PHP Version: 7.4.3
Database Driver & Version: MySQL 5.5.5-10.4.11 MariaDB

Description:
I'm testing Cashier with Stripe to manage plans with subscriptions, but I have an issue when I want to subscribe to a plan:
Stripe HTML code (Angular) :
this.stripe.confirmCardSetup(
    this.intentToken.client_secret, {
        payment_method: {
            card: this.card,
            billing_details: {
                name: name
            }
        }
    }
).then((result) => {
    if(!result.error) {
        const payment_method = result.setupIntent.payment_method

        return this.http.post('/user/subscription', {
            payment_method: payment_method,
            plan: 'monthly',
        }).toPromise()
    }
})

Laravel API /user/subscription endpoint:
    public function store(StoreSubscription $request)
    {
        $user = Auth::user();

        $paymentMethod = $request->input('payment_method');
        $planId = $request->input('plan');

        $subscription = $user->newSubscription('premium', $planId)->create($paymentMethod);

        return $subscription;
    }

Here I have a first error:
Trying to get property 'default_payment_method' of non-object
So I tried to get the Stripe Customer by simply call $user->createAsStripeCustomer(), and then I got this error:
User is already a Stripe customer with ID cus_XXX.
The issue is this customer has been deleted from the Stripe Dashboard, and I can't recreate it. Cashier seems to find it, even if it's a deleted customer.

Raaah... 🤦🏻♂
Just after I posted it I found out the webhook has some errors, I resend them and now it's working... Sorry!

Beware that if you delete the stripe_id manually from the database, there is a difference between setting it to EMTPY or NULL. If you just delete it, the DB will set it to EMPTY, and Cashier will request Stripe details with the following payload {customer: "", ...} which results in the following error: 'User is already a Stripe customer with ID .'
Notice the ID and a space after it, that's where the Stripe ID would normally go.


Updating azure-storage in build

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.386%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
28403

Relevant Lines:
62522

💛  - Coveralls

Maybe I don't quite understand, but why is only the yarn.lock being updated and no package.json?

@aasimkhan30 Can confirm, but for a lot of these you don't need to update a direct dependency yourself if the package has a version range specified. So in this case updating from 2.10.3 to 2.10.7 should be non-breaking so most packages will have their dependencies set up to allow this (like we do with the use of ^ everywhere).
You see this all the time with dependabot updates - e.g. https://github.com/microsoft/azuredatastudio/pull/19931

@aasimkhan30 Can confirm, but for a lot of these you don't need to update a direct dependency yourself if the package has a version range specified. So in this case updating from 2.10.3 to 2.10.7 should be non-breaking so most packages will have their dependencies set up to allow this (like we do with the use of ^ everywhere).
You see this all the time with dependabot updates - e.g. #19931

Ah interesting. Thanks @Charles-Gagnon. I only ask because I see that https://github.com/microsoft/azuredatastudio/blob/main/build/package.json#L47 has ^2.1.0 listed. Curious if we could just change that to ^2.1.7 instead.
Anyway, no biggie. Just was curious more than anything 😄

Yes, you're right @Charles-Gagnon
So, if a there is a direct or indirect dependency to a library with ^ in front of the version number, just deleting the yarn.lock version and running yarn gets the latest minor update from npm.

Yes, you're right @Charles-Gagnon So, if a there is a direct or indirect dependency to a library with ^ in front of the version number, just deleting the yarn.lock version and running yarn gets the latest minor update from npm.

Ah, gotcha. TIL! Thanks @aasimkhan30


Applications complete the job with delay

Describe:
Sometimes it may take a time until the applications complete the job and exit. It is better visible when application runs with multiple threads and components. For instance, in the example 13, noticed that it may take seconds until application exists. It may take 10-30 seconds.
Action:
Investigate to figure out the reason of such delay.
Make refactoring if needed and fix the issue. The application should start and stop as fast as possible. The main reason of delay is because of waiting the threads to complete the job. So that, the exit procedure should be optimized.

The issue with delay has gone with one of fixes.
There is still slight delay, but it is not related with this original issue.


False Positive on html2pdf

False positive on library html2pdf.jar - reported as cpe:2.3:a:html2pdf_project:html2pdf:*:*:*:*:*:*:*:*
<dependency>
    <groupId>com.itextpdf</groupId>
    <artifactId>html2pdf</artifactId>
    <version>4.0.0</version>
</dependency>

This is mixing up two different html2pdf projects:
html2pdf-3.0.5.jar<EMAIL_ADDRESS>cpe:2.3:a:html2pdf_project:html2pdf:3.0.5:::::::*) : CVE-2021-45394
We use this one:
https://github.com/itext/itext7
com.itextpdf
html2pdf
The one affected by CVE 2021-45394:
https://github.com/spipu/html2pdf/

Exactly. The  CVE 2021-45394 vulnerability should be connected to the spipu/html2pdf project, but OWASP marks a com.itextpdf/html2pdf as vulnerable also.

I resubmitted it using the "False Positive Report" template, feel free to close both issues once this is resolved.


dark and Light theme

I would like to add Dark and Light theme to the website @apu52  can you please assign me this issue under GSSOC'24

hi,
I am GSSOC'24 Contributor. Could you please assign this task to me. I will add the Dark and Light theme to the website.

I would like to add Dark and Light theme to the website @apu52 can you please assign me this issue under GSSOC'24

i  would like to add dark and light theme, so plss assign me this issue under GSSOC 2024

@Syed0206 Theme change is already present in the website


Allow delaying kafka offset commits

We're currently checkpointing (committing Kafka offsets) as fast as possible. That might not be needed and some folks say that Kafka commits are an expensive operation (ref1, ref2)
Depending on how fast the lambdas are consuming, we may be committing dozens of offsets per partition per second - that might be overkill. So I want to try playing with batching for the commits.
By default, Kafka's built-in auto commit logic would have applied a 5 second delay for the commits (ref) - we are not leveraging that auto-commit logic so we have no such delay in our system. This new commitSuccessDelay property will allow us to artificially introduce a delay. I'm defaulting it to 0 so it's no-op when checked-in.

We're currently checkpointing (committing Kafka offsets) as fast as possible. That might not be needed and some folks say that Kafka commits are an expensive operation (ref1, ref2)
Depending on how fast the lambdas are consuming, we may be committing dozens of offsets per partition per second - that might be overkill. So I want to try playing with batching for the commits.
By default, Kafka's built-in auto commit logic would have applied a 5 second delay for the commits (ref) - we are not leveraging that auto-commit logic so we have no such delay in our system. This new commitSuccessDelay property will allow us to artificially introduce a delay. I'm defaulting it to 0 so it's no-op when checked-in.

For scribe and deli, we write the checkpoint state to the db followed by the kafka checkpoint. If we are batching only the kafka checkpointing, won't we end up writing the checkpoint info to the database a lot more often compared to the kafka checkpoint. Are there any implications of this? I guess we will end up replaying more ops on crashes but we will be able to noop the ops that have already been processed?

For scribe and deli, we write the checkpoint state to the db followed by the kafka checkpoint. If we are batching only the kafka checkpointing, won't we end up writing the checkpoint info to the database a lot more often compared to the kafka checkpoint. Are there any implications of this? I guess we will end up replaying more ops on crashes but we will be able to noop the ops that have already been processed?

Yes, that's right. The main implication of delaying the Kafka commits (from the consumer perspective) is that we would end up replaying a higher number of Kafka messages after a crash. However, this is not a problem because we have those checkpoint states in the DB. All lambdas already correctly handle processing of replayed messages.


Update dependency tslib to v2.8.0

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

tslib (source)
2.7.0 -> 2.8.0

Release Notes

Microsoft/tslib (tslib)
v2.8.0
Compare Source
What's Changed

Validate export structure of every entrypoint by @andrewbranch in https://github.com/microsoft/tslib/pull/269
Add rewriteRelativeImportExtension helper by @andrewbranch in https://github.com/microsoft/tslib/pull/270

Full Changelog: https://github.com/microsoft/tslib/compare/v2.7.0...v2.8.0

Configuration
📅 Schedule: Branch creation - "before 12am on sunday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: undefined
Command failed: ./nix/update-pnpm-hash.sh
GC Warning: Could not open /proc/stat
error:
       … while fetching the input 'git+file:///var/lib/private/renovate/repos/github/NuschtOS/search'

       error: cannot open connection to remote store 'daemon': error: reading from file: Connection reset by peer


/miners Show potential total share of activated Mining pools

On the Mining Pools overview page https://taproot.watch/miners please show at the top (or bottom) the total share of Taproot activated Mining pools.
Meaning: Currently there are 4 mining pools which have Taproot activated:

F2Pool
Poolin
Foundry USA
SlushPool
Add those shares together and we'd get roughly 35.55% of Taproot activated Hashrate.

thx

Thank you for the suggestion @bauslo!
This was fixed in 5665a68.


2/11 Publish

Docs Build status updates of commit be338ea:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/tobias-fenster.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


RefCounted version of levenshteinDistance

And refactoring & restyling.

This looks good but I'll mark as blocked for now. RefCounted!(T[]) is just a reference counted slice, not an actual reference counted array. We first need to add RefCountedSlice!T to be just like T[], but reference counted.

We first need to add RefCountedSlice!T to be just like T[], but reference counted.
Ok, I'll wait for this.


SEO: fix the metaTitles in the docs

metaTitles are important for Google SEO. We have some issues with the metaTitles in our docs:

We have four pages with a blank metaTitle: we should add one, even if it's the same as the title.
Some pages have no metaTitle - e.g. some style guide pages.

Update: I used the following command to search for files:
grep --include="*.mdx" -L -r  "metaTitle"
This returned the following list (it's pretty short - this will be an easy fix):

./400-reference/100-system-requirements.mdx
./200-concepts/100-components/02-prisma-client/000-working-with-prismaclient/115-connection-pool.mdx
./200-concepts/100-components/250-preview-features/050-client-preview-features.mdx
./200-concepts/100-components/250-preview-features/080-cli-preview-features.mdx
./200-concepts/100-components/01-prisma-schema/06-relations/300-many-to-many-relations.mdx
./200-concepts/100-components/01-prisma-schema/06-relations/100-one-to-one-relations.mdx
./200-concepts/100-components/01-prisma-schema/06-relations/400-self-relations.mdx
./200-concepts/100-components/01-prisma-schema/06-relations/500-troubleshooting-relations.mdx
./200-concepts/100-components/01-prisma-schema/06-relations/200-one-to-many-relations.mdx
./200-concepts/100-components/01-prisma-schema/08-features-without-psl-equivalent.mdx
./200-concepts/100-components/01-prisma-schema/07-names-in-underlying-database.mdx
./200-concepts/100-components/01-prisma-schema/09-indexes.mdx
./200-concepts/100-components/03-prisma-migrate/100-supported-types-and-db-features.mdx
./200-concepts/100-components/03-prisma-migrate/300-prisma-migrate-limitations-issues.mdx
./300-guides/050-database/820-multi-schema.mdx
./300-guides/050-database/800-production-troubleshooting.mdx
./300-guides/050-database/300-seed-database.mdx
./300-guides/050-database/100-developing-with-prisma-migrate/index.mdx
./300-guides/050-database/100-developing-with-prisma-migrate/150-team-development.mdx
./300-guides/050-database/100-developing-with-prisma-migrate/165-enable-native-database-functions.mdx
./300-guides/050-database/100-developing-with-prisma-migrate/050-add-prisma-migrate-to-a-project.mdx
./300-guides/050-database/100-developing-with-prisma-migrate/200-troubleshooting-development.mdx
./300-guides/050-database/100-developing-with-prisma-migrate/160-baselining.mdx
./300-guides/050-database/100-developing-with-prisma-migrate/170-customizing-migrations.mdx
./300-guides/050-database/100-developing-with-prisma-migrate/168-include-unsupported-database-features.mdx
./300-guides/050-database/400-prototyping-schema-db-push.mdx
./300-guides/050-database/700-patching-production.mdx
./300-guides/200-deployment/150-deploy-database-changes-with-prisma-migrate.mdx
./300-guides/100-performance-and-optimization/index.mdx
./300-guides/100-performance-and-optimization/100-prisma-client-transactions-guide.mdx
./300-guides/100-performance-and-optimization/150-connection-management/200-configure-pg-bouncer.mdx
./800-data-platform/850-billing/07-payment-method-and-billing-information.mdx

Files with a blank metaTitle:

/100-getting-started/02-setup-prisma/index.mdx
/200-concepts/100-components/05-prisma-cli/index.mdx
/200-concepts/200-database-connectors/index.mdx
/300-guides/600-general-guides/100-database-workflows/05-foreign-keys/index.mdx

What happens if a page has no metaTitle? Does it fall back to ues the title in the meta tag?

Resolved in Docusaurus docs


Adding Contributing.md

Motivation:

Started writing a contributing guide

Related Issues:

#36

Just a thought but it maybe nice to have issue templates for bug reports and feature requests we could link to...

@jules2689 @gwincr11 Just added issue templates. Thank you for the suggestion, these are awesome!


feat: reduce memory overhead in CUDA Graph

fix #267
With new pool layer:
time to warmup: 12.41min
Kernl speedup: 2.5X (0.5 VS 1.3 min)
# different outputs: 0/73 (0.00%)

memory footprint:
* allocated: 8.6GB
* reserved: 11.3GB
* max reserved: 13.6GB

before this PR:
time to warmup: 12.42min
Kernl speedup: 2.4X (0.5 VS 1.3 min)
# different outputs: 0/73 (0.00%)

memory footprint:
* allocated: 10.9GB
* reserved: 13.4GB
* max reserved: 13.9GB

test pass (local run 3090 RTX):
======================================================================= 2859 passed, 80 warnings in 342.38s (2:19:02) ========================================================================

test pass
=============================== warnings summary ===============================
test/test_model_optimization.py: 1 warning
test/test_torchdynamo.py: 79 warnings
  /home/geantvert/.local/share/virtualenvs/kernl/lib/python3.9/site-packages/torch/cuda/graphs.py:82: UserWarning: The CUDA Graph is empty. This ususally means that the graph was attempted to be captured on wrong device or stream. (Triggered internally at ../aten/src/ATen/cuda/CUDAGraph.cpp:191.)
    super(CUDAGraph, self).capture_end()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================ 2863 passed, 80 warnings in 8556.02s (2:22:36) ================