Error analysis

This PR runs some analyses to try to figure out what is causing the irreducible error in model performance so far (hint, it's always label imbalance)
Changes:

Add logic to sample split and tissue split experiments to record what predictions are made by each iteration of each model
Add an analysis notebook digging into which samples are hard to classify and why

In the confusion matrix in cell 14, is it correct that most placenta samples are being classified as lung tissue, and only 2 are classified correctly? I guess maybe that's an example of the label imbalance you're talking about (there are just so many lung samples in the dataset that your model tends to predict that very frequently).

Yep, that is correct! There are very few placental samples and they are consistently misclassified
I'm putting together another PR tomorrow that modifies this notebook to include the updated data, so I'll add the suggested improvements there


BUG make_fwd_solution is broken

I was trying to make a fwd solution and I got an error.
/Applications/packages/mne-python/mne/io/pick.pyc in pick_types(info, meg, eeg, stim, eog, ecg, emg, ref_meg, misc, resp, chpi, exci, ias, syst, seeg, include, exclude, selection)
    191     from .meas_info import Info
    192     if not isinstance(info, Info):
--> 193         raise TypeError('info must be an instance of Info, not %s' % info)
    194     nchan = info['nchan']
    195     pick = np.zeros(nchan, dtype=np.bool)

TypeError: info must be an instance of Info, not {'dev_head_t':...```

it's because the internal dict that is being generated is not an instance of Info, just a regular dict. this is a problem when you do pick_types on it.

cc: @agramfort, @Eric89GXL

Can you send a PR?

@teonlamont in fact I think you must be on my branch in order to have gotten this error -- I added that check in my PR. Please check the most recent version of my PR to see if it fixes your problem, and if it does, close your PR.

yeah, life living on multiple branches. yeah, this fixes the error I was having. I will close this issue and my pr, thanks


Channel URLs authentication

I don't if it possible,now or is would be a feature.  We have a case that we need to login in the channel url. But I couldn't find an easy way to do that.

+1 for this need.

+1

As a work-around, I've pulled together a simple HTTP proxy that can inject basic auth headers into a request. Another moving part but will get by until greenscreen supports it natively. https://github.com/CheggEng/basic_auth_proxy

thanks wjimenez5271! I will have a look ;)

+1

+1

+1


Mgmt schema consolidation

Consolidate CodeModel.Schema into InputType

I didn't see an on / off switch for this. Does that mean this is already on for everything and there are zero diffs?

Yes. With swagger input, we have CodeModel.Schema from M4 and then we convert all the schema related models into existing input types, which we apply with TypeSpec input. And then, this PR updates all the consumption of CodeModel.Schema to InputModel in all modules for the MPG generator.
There are some minor diffs, which I think are acceptable:

Description update
Another description update
Parameter anyObject renaming to unknown
Additional internal rest operation


New linter plugin: nginx-lint

Linter for nginx .conf files using nginx-lint.
https://github.com/irvinlim/SublimeLinter-contrib-nginx-lint

Done! Thank you :)

Should show up within an hour in Package Control. Thanks Again!
https://github.com/SublimeLinter/package_control_channel/commit/672fd28661eeb013043aa3e5643b58a26a3f5cdd


Update README.md

Thank you for fixing a typo.
However, you could have seen that we have a CONTRIBUTING.md file. That should be referenced. See also my comment at https://github.com/JabRef/blog.jabref.org/pull/35#issuecomment-541323733. It would have been nice if you checked the exiting PR (it was opened when you opened your PR).


Streaming support for python - release date

When the support for streaming ciphers in Python will be released? Is there any publicly available roadmap of upcoming features?

This should be part of 1.5.0. Should be easy, as the only missing pieces are the key managers.
@kste please keep me honest

When is 1.5.0 planned to be released?

@juergw has been working on this, but it looks like this is more complicated than we thought and likely won't make the cut for 1.5.0. After we finish the implementation, we also want to run it in production for awhile to squeeze out potential bugs, so at this point we can't tell for sure when it'll be ready for external users. My apologies!

I have no update on the release date, but there is now an example for using the streaming AEAD in Python if you can use the head version.

1.5.0 will be released early next week.

Tink Python 1.5.0 is out!
pip install tink==1.5.0


Support approximate color to name conversion

Closes #49

Codecov Report

Merging #57 (d93cca6) into master (c0bdc02) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           35        35
  Lines          441       459   +18
  Branches        96        99    +3
=========================================
+ Hits           441       459   +18

Impacted Files
Coverage Δ

src/plugins/names.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0bdc02...d93cca6. Read the comment docs.


Excause me!I create rtty ipk error,with follow error infomation,how to fix it?thanks!

CMake Error at /home/lzq/work/work2019/qsdk_201904/qca-networking-2017-spf-5-0-3_qca_oem.git/qsdk/staging_dir/host/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:97 (MESSAGE):
Could NOT find Libev (missing: LIBEV_LIBRARY LIBEV_INCLUDE_DIR)
Call Stack (most recent call first):
/home/lzq/work/work2019/qsdk_201904/qca-networking-2017-spf-5-0-3_qca_oem.git/qsdk/staging_dir/host/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:288 (_FPHSA_FAILURE_MESSAGE)
cmake/Modules/FindLibev.cmake:25 (find_package_handle_standard_args)
src/CMakeLists.txt:9 (find_package)
-- Configuring incomplete, errors occurred!

You need to install libev - depending on platform the command to do it will be different. There's instructions in the README.


SITEMAP_URLS

Hi,  i have multi hosts project. And i need one sitemap for current host.
When i open "example.com" i have "example.com/sitemap" - it's good, but when open "example2.com" i have "example.com/sitemap".
What do you can help me with it?

This is out of scope of this app, sorry.


Add GetConfiguration/SetConfiguration methods

This is meant to configure the connectivity software. This can include the following configurations:

Software lic download
Driver loading (e.g. Siemens S7, etc.)
Certificate/security settings download
Feature config, e.g. store & forward
Change management tracking

Should be accessible through GetConfiguration/SetConfiguration methods.

We could make this generic (e.g. provide key-value pairs) and move it over to the UA working group.

GetConfiguration()/SetConfiguration() with key/value pairs. UploadFile() for southbound driver certificates and licensing file.


Add a full stack blog feature

Need to start writing technical blogs on my own blogging platform. Add blog implementation with MDX format.


Trivial Autoconf cleanup

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1421/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1314/ for details.

Nice catch on AC_SEARCH_LIBS! Question, i wonder if we do this wrong in other places? Are we adding things to LIBS when we shouldn't?
There are several places where we do things like:
  AC_SEARCH_LIBS([lzma_code], [lzma], [lzma_have_libs=1])
  if test "$lzma_have_libs" != "0"; then
    AC_CHECK_HEADERS(lzma.h, [lzma_have_headers=1])
  fi
  if test "$lzma_have_headers" != "0"; then
    AC_SUBST(LIBLZMA, [-llzma])
  else
    enable_lzma=no
    CPPFLAGS=$saved_cppflags
    LDFLAGS=$saved_ldflags
  fi

In fact, taking a quick look, tools like traffic_top is getting all the "optional" libraries, even though they are highly unlikely to use 'em? Like, libhwloc.

Thanks for reviewing this @zwoop! I'm going to land it and see about fixing the issue you spotted in a separate PR.


FPS innaccurate for stage.frameRate

Haxe version: latest stable
OpenFL version: latest stable
Lime version: latest stable
Affected targets: desktop, others untested.
Make a basic project with openfl create
Make an openfl.display.FPS and add it in main.
In your Starting state, set stage.frameRate to your monitors current hz.
In your project.xml, make sure vsync is "true" for your target.
Compile. The FPS display will be accurate to your actual hz, sometimes with a difference of around 1 or 2.
In project.xml, change vsync to false.
Compile. The FPS display will be inaccurate.
144 stage.frameRate displays ~168, 60 does 64.
Test with whatever numbers you'd like. if you're skeptical, try 90 fps and then try 91. The display changes from 92 to 102. That's definitely not right.
Main.hx:
package;
import openfl.display.Sprite;
class Main extends Sprite
{
	public function new()
	{
		super();

		addChild(new openfl.display.FPS());
		stage.frameRate = 144;
	}
}

if You want to lock your framerate to your refresh rate, build with vsync enabled. This is not a bug, but a well known issue with the granularity of delta time in our main loop and a common issue in games or frameworks that rely on sdl. We can only measure time in whole milliseconds, which creates an issue where flooring prevents microsecond accuracy (60 fps would be ~16.6667ms per frame).
If we set the fps to 60, we end up with something like 62.5, which is 1000/16 instead of 1000/16.6667.
Fixing this ultimately requires modifying the main loop in lime. There is some discussion in regards to this here:
https://github.com/openfl/lime/issues/1569#issuecomment-2067654247

I wonder if it makes sense to cap the value displayed by openfl.display.FPS by checking it against stage.frameRate.

Issue is likely the SDL implementation in lime, because lime uses SDL_GetTicks in https://github.com/openfl/lime/blob/develop/project/src/backend/sdl/SDLApplication.cpp, where it uses ints instead of double for deltaTime, the higher the fps the less accurate the fps counter becomes, since theres not enough detail in the delta millisecond int value.


Update CGW startup environment variables

Changes

Add INFURA_API_KEY CGW configuration placeholder.
Add RELAY_PROVIDER_API_KEY_ARBITRUM_ONE CGW configuration placeholder.
Remove EXCHANGE_API_BASE_URI and EXCHANGE_API_KEY CGW configuration placeholders (not used anymore by the service).

@hectorgomezv please let @JagoFigueroa know when this is merged so he can test it 😃


Support for locally referenced packages in requirements.txt

As per issue https://github.com/CycloneDX/cyclonedx-python/issues/284 raised by @Jonas-vdb.
Some development teams add local references to other packages in their requirements.txt files. This is currently causing an exception:
Traceback (most recent call last):
  File "/home/jvdb/repos/venv-tmp/lib/python3.6/site-packages/pkg_resources/_vendor/packaging/requirements.py", line 98, in __init__
    req = REQUIREMENT.parseString(requirement_string)
  File "/home/jvdb/repos/venv-tmp/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 1654, in parseString
    raise exc
  File "/home/jvdb/repos/venv-tmp/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 1644, in parseString
    loc, tokens = self._parse( instring, 0 )
  File "/home/jvdb/repos/venv-tmp/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 1402, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "/home/jvdb/repos/venv-tmp/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 3417, in parseImpl
    loc, exprtokens = e._parse( instring, loc, doActions )
  File "/home/jvdb/repos/venv-tmp/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 1402, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "/home/jvdb/repos/venv-tmp/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 3739, in parseImpl
    return self.expr._parse( instring, loc, doActions, callPreParse=False )
  File "/home/jvdb/repos/venv-tmp/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 1402, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "/home/jvdb/repos/venv-tmp/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 3400, in parseImpl
    loc, resultlist = self.exprs[0]._parse( instring, loc, doActions, callPreParse=False )
  File "/home/jvdb/repos/venv-tmp/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 1406, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "/home/jvdb/repos/venv-tmp/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 2711, in parseImpl
    raise ParseException(instring, loc, self.errmsg, self)
pkg_resources._vendor.pyparsing.ParseException: Expected W:(abcd...) (at char 0), (line:1, col:1)

Root Cause: pkg_resources again does not support parsing requirements of this format (similar to requirements with hashes included) - see here.

I agree @jkowalleck - will remove the bug label.

@madpah
I was thinking about making a PR to replace pkg_resources with requirements-parser because the latter can parse all sorts of requirements. WDYT?

Hey @mostafa - thanks for getting involved.
This was absolutely my plan. However, since this ticket was created, the logic/classes that use pkg_resources now live in an upstream project cyclonedx-python - so I'll first relocate this issue (back) there.
Would be great to get a PR from you to make this change, but worth nothing we have a large(ish) release due to land probably next week now, so you might want to wait until that is merged before you branch.


Fix implementation of property_can_revert() in various classes

Similar to #88665

I noticed the same problem in some other classes.

Thanks!


Skip track1 perf projects from gulp pack

Skip all projects in @azure-tests org from gulp pack. These are perf test framework projects for track1 and should not be included in gulp pack

/check-enforcer override

@praveenkuttappan Please merge the PR if there are no changes you are planning here

@ramya-rao-a  @praveenkuttappan  this pr leads to all pipeline runs failed, and it has a bug:
.scripts/common.ts(111,9): error TS2532: Object is possibly 'undefined'.

I have created a pr to revert it: https://github.com/Azure/azure-sdk-for-js/pull/15636
thanks

@dw511214992 Sorry for the inconvenience and thanks for fixing it.


Autocat learning module

Adds a learning module with relevant ML components.

Removing the perturbations module for now. We can aim to get that merged in a separate module.


Revisit "Extending and embedding Spin" docs

These docs are going to be out of date with the upcoming Spin core refactor. We should think about how we want to update this docs page or whether we should delete it until we have a more cohesive trigger plugin story.

See linear.app's Developer Docs team for more information.


[GOBBLIN-267] Changed workunit creation policy to compare update time with maxLookBackDays

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-267

Description

[x] Here are some details about my PR, including screenshots (if applicable):
HiveSource#shouldCreateWorkunit() now compares update time with maxLookBackDays

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Very trivial change/fix

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@abti, can you please review this pr


Add codeAction/resolve and variable extraction refactoring

Motivation
Two changes are included:

Implement codeAction/resolve specification that populates the "edits" field for a given code action.
Use the new codeAction/resolve to implement a use case of refactoring: extracting variables.

Implementation
Limitation: Currently the use case of extracting variable does not allow customizing the new variable name, and will arbitrarily place the extracted text to the immediate line above, disregarding if it is a valid syntax.
Automated Tests
✅
Manual Tests

Select a chunk of length in the editor.
Right click to see the menu, choose Refactor... -> Refactor: Extract variable
Expected: The selected text will be extracted away into a new_variable variable defined in the line above the selected text.

This is great! One small optional suggestion: Once new_variable is added, can we have it selected that you can easily type a new name?

One limitation I noticed is that it doesn't yet work on single line blocks, e.g.
    [0..10].each { |i| 5 * 2 * i }

becomes
    new_variable = 5 * 2 * i
    [0..10].each { |i| new_variable }

but the i would not be in scope.
Maybe there's a more general design decision to be made: Do we prefer to generate potentially incorrect code, or to show an error if we can't be sure an operation is safe?

Disregard my comments above, I should have read the description first!

Disregard my comments above, I should have read the description first!

@andyw8

One limitation I noticed is that it doesn't yet work on single line blocks

Yes, and among others, it also does not work in cases where an expression spans more than one line. Example:
a = {
   x: 1  # Use Extract Variable on 1
}

becomes
a = {
  new_variable = 1
  x: new_variable
}

In other words, this refactor functionality is currently quite limited. This is aimed as more of a quick showcase of what is possible with the implementation of codeAction/resolve than a full-fledge feature. And, to make it more robust, the complexity deserves a pr of its own I think :)


Unrestricted data usage should be default ON for Intra

As with other core functionality apps such as Google Play Services, Carrier Services and Google Services Framework that have unrestricted data usage default togged on, Intra should also default toggled on for unrestricted data usage as DNS would be considered core functionality.

Have you noticed a problem related to this setting?  I would think that any app with an active VpnService would not be subject to this restriction.

I haven't had an issue as I'm on an unlimited plan and have never run my battery down that low.
On default when unrestricted data is toggled off the status shows:
UID=10214 state=3 (fg svc) rules=0 (NONE)
When I toggle it on to allow unrestricted data the status changes to:
UID=10214 state=3 (fg svc) rules=1 (ALLOW_METERED)
and then shows up under Policy for UIDs:
UID=10214 policy=4 (ALLOW_METERED_BACKGROUND)
Whether it's on or off the app still shows up under:
Power save whitelist app ids:
UID=10214: true

So it appears if a device goes into data saver mode data would be restricted if on a metered network. However, I'm not sure if the power save whitelist overrides that
https://developer.android.com/training/basics/network-ops/data-saver.html#request-whitelist


update file scanners-urls.data

There is no information on where this list comes from. We need to get some sources and update the list.
Could be some overlapping from #2638, or something there we can use.

See https://github.com/coreruleset/coreruleset/issues/2638#issuecomment-1353167402 for a thorough discussion that includes this list as well.

Fixed via #3235


Promote no-longer flaky tests to gce suite

cc @quinton-hoole @ixdy @davidopp

cc @gmarek

cc @zmerlynn

Ah, I wasn't here yet in my email and you didn't reference the bug.
But no, #10720. Flaky test still flaky.

Nor did you, as I asked in the original commit, CC me to take it off the GKE list.

@zmerlynn - sorry I missed the fact that should cc-ed you. Sorry for that.
Regarding flakiness - yes you're right it's still flaky.
@gmarek - since you wrote this test, can you please take a look?

@wojtek-t: No worries, it was buried in a random commit comment and not necessarily easy to see in "git blame". Not sure there's an easy way to broadcast, and we just need to move the GKE config in there, too.

Rebased - PTAL

Tests on Jenkins didn't started - I'm rerunning them now.

@k8s-bot ok to test

@wojtek-t can you clarify whether you think these tests are still flaky? Your last comment was "Regarding flakiness - yes you're right it's still flaky."

@davidopp - sorry, this comment was about MaxPods which I initially also wanted move out of flaky. However, since it's still flaky, we should leave it.
So I'm only moving "Addon" test to non-flaky (the Nodes network partition is not catching any test :P)

LGTM


Fix e2e to use v35 github

Signed-off-by: Chmouel Boudjnah<EMAIL_ADDRESS>

Codecov Report

Merging #145 (7106d41) into main (9a16289) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   76.73%   76.73%
=======================================
  Files          13       13
  Lines         834      834
=======================================
  Hits          640      640
  Misses        122      122
  Partials       72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9fd78...7106d41. Read the comment docs.


switching normal/off modes via API in master-slave configuration.

When I change modes between solar and smart (or other way around) on the master smartevse via API call it works as expected for the slave too. However when I switch mode to normal: both master and slave change but while switching back to solar or smart - master changes but slave stays on solar. When switching to off mode from solar/smart: master switches but state of slave is unchanged.
I know I can switch the mode separately on slave via its API endpoint: but apparently this disturbs bus communication between master and slave and as a result slave never starts charging after .. until both master and slave are power-cycled this is not recovering.

As I'm not using a slave myself, can you first try if this issue also exists in the original firmware?


Bumping odo version v2.2.4 -> v2.3.0

Signed-off-by: Mohammed Zeeshan Ahmed<EMAIL_ADDRESS>

timeout
/test psi-unit-test-windows

/test psi-unit-test-windows

/retest

/refresh


#469 broke CALEX lightbulb

The definition for Calex white led (modelID "EC-Z3.0-CCT "s missing an space at the ending of its definition. it was right but got changed in #469.
i just  updated my zigbee2mqtt and now the lightbulb dos not work and i get in the log
Jun 05 23:51:51 raspberrypi npm[12814]:   zigbee2mqtt:warn 6/5/2019, 11:51:51 PM Device with modelID 'EC-Z3.0-CCT ' is not supported.
if you look closly there is an space character after the T in the modelID

Can you make a PR to fix it?


HDFS-16043. Add markedDeleteBlockScrubberThread to delete blocks asynchronously

HDFS-16043

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1 :x:
mvninstall
31m 13s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
0m 29s
/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
0m 29s
/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-hdfs in trunk failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-0 :warning:
checkstyle
0m 27s
/buildtool-branch-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
The patch fails to run checkstyle in hadoop-hdfs

-1 :x:
mvnsite
0m 30s
/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in trunk failed.

-1 :x:
javadoc
0m 29s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
javadoc
0m 29s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-hdfs in trunk failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

+1 :green_heart:
spotbugs
3m 58s

trunk passed

+1 :green_heart:
shadedclient
21m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 28s

the patch passed

+1 :green_heart:
compile
1m 32s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
1m 32s
/results-compile-javac-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 502 new + 0 unchanged - 0 fixed = 502 total (was 0)

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
javac
1m 18s
/results-compile-javac-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 486 new + 0 unchanged - 0 fixed = 486 total (was 0)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  7s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 796 new + 0 unchanged - 0 fixed = 796 total (was 0)

+1 :green_heart:
mvnsite
1m 30s

the patch passed

-1 :x:
javadoc
1m  0s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 99 new + 0 unchanged - 0 fixed = 99 total (was 0)

-1 :x:
javadoc
1m 35s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
spotbugs
3m 30s

the patch passed

+1 :green_heart:
shadedclient
16m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
240m 57s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

328m 36s

Reason
Tests

Failed junit tests
hadoop.tools.TestHdfsConfigFields

hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion

hadoop.hdfs.server.namenode.TestNameNodeMXBean

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.TestReadStripedFileWithDecoding

hadoop.hdfs.server.namenode.TestMetaSave

hadoop.hdfs.server.namenode.ha.TestHASafeMode

hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 5dab7bc3b52c 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a8beeca02fa89e4050e9b9b118073b7542db2557

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/1/testReport/

Max. process+thread count
3292 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 8 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 53s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 26s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  7s

trunk passed

+1 :green_heart:
shadedclient
16m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 927 unchanged - 1 fixed = 931 total (was 928)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  5s

the patch passed

+1 :green_heart:
shadedclient
16m  5s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
240m 56s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

328m 26s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork

hadoop.hdfs.TestBlocksScheduledCounter

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux 7e43feeb60ba 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2db702b034d7b309083832c10347d793d0700f03

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/3/testReport/

Max. process+thread count
3251 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@zhuxiangyi  This PR has conflict to trunk now. Please rebase it first and check failed unit test if it is related to changes. Thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 8 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 55s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  3s

trunk passed

+1 :green_heart:
shadedclient
16m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 5 new + 924 unchanged - 1 fixed = 929 total (was 925)

+1 :green_heart:
mvnsite
1m 12s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 10s

the patch passed

+1 :green_heart:
shadedclient
16m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
237m 28s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

322m 13s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork

hadoop.hdfs.TestBlocksScheduledCounter

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux 6b448a798f41 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / eeeb6a78880151baebebab6b0f63900e8c953aac

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/4/testReport/

Max. process+thread count
3210 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 13 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 39s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  7s

trunk passed

+1 :green_heart:
shadedclient
16m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  5s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  2s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 957 unchanged - 1 fixed = 960 total (was 958)

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 12s

the patch passed

+1 :green_heart:
shadedclient
15m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
234m 46s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

318m 44s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux bb8085e5877d 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a92b0603dec223023a2e3ba2f311d579252fd954

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/6/testReport/

Max. process+thread count
3430 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 13 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 55s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 24s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 19s

trunk passed

+1 :green_heart:
shadedclient
19m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 956 unchanged - 1 fixed = 959 total (was 957)

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 22s

the patch passed

+1 :green_heart:
shadedclient
19m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
350m 28s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

442m 51s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux cb773f8af85e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3bee0e30df80949e1561dd3a28ec4b0f3ee30fcb

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/5/testReport/

Max. process+thread count
2086 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.TestDecommissioningStatus
hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
hadoop.hdfs.TestDFSShell
hadoop.hdfs.server.namenode.ha.TestEditLogTailer
hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

@Hexiaoqiao Thank you for your review, the above check failure seems to have nothing to do with this patch.

Please fix the checkstyle reported by Yetus first. Other looks good to me. I would like to give my +1 when fix that. Before commit to trunk we should wait for other guys give another reviews. Thanks @zhuxiangyi .

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 13 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m  2s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 11s

trunk passed

+1 :green_heart:
shadedclient
16m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 957 unchanged - 1 fixed = 959 total (was 958)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  5s

the patch passed

+1 :green_heart:
shadedclient
16m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
236m 21s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

320m 50s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux 3b3c0fa7e498 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f09d251c76d3c2ce51650311cb96e2abc1dd3e22

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/7/testReport/

Max. process+thread count
3119 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks for the work and sharing the flame graph, which makes it easy to validate the change.
However, I am still not able to understand why the change improves delete performance. The delete op is done in two steps, step 1 acquire lock, collect blocks, release lock. step 2 acquire lock, delete blocks, release lock.
The change essentially moves the step2 to another thread. IMO, this approach reduces client perceived latency, which is good. But deleting the blocks still requires holding namespace lock. Why does it avoid NN unresponsiveness?
Is it because instead of releasing the lock after a specified number of blocks, it releases the lock after an absolute time. I can image the absolute time is a better metric because deleting a block does take a variable duration of time, not constant.
A few minor comments changes requested:

@jojochuang Thanks for your comment and review, as you commented, the current modification is only to delete the block asynchronously. The QuotaCount calculation optimization described in jira can reduce the time to collect blocks. I plan to open a new problem to solve it.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 15 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 18s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  8s

trunk passed

+1 :green_heart:
shadedclient
16m  6s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 5 new + 1035 unchanged - 2 fixed = 1040 total (was 1037)

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 10s

the patch passed

+1 :green_heart:
shadedclient
15m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
235m 50s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

320m 14s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux 72a47efa626e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 53f1dfb56519fb087934ba86b7e2f07460ecaa73

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/8/testReport/

Max. process+thread count
3425 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

i'll review.
can you rebase the PR? it's got conflicts.

@jojochuang already rebase.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 15 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 44s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  8s

trunk passed

+1 :green_heart:
shadedclient
22m  0s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 17s

the patch passed

+1 :green_heart:
compile
1m 25s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 25s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 57s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 5 new + 639 unchanged - 2 fixed = 644 total (was 641)

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 32s

the patch passed

+1 :green_heart:
shadedclient
23m  5s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
521m 59s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

623m  5s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestViewDistributedFileSystemContract

hadoop.hdfs.TestSnapshotCommands

hadoop.hdfs.qjournal.server.TestJournalNode

hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeWithHdfsScheme

hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeHdfsFileSystemContract

hadoop.hdfs.TestViewDistributedFileSystemWithMountLinks

hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes

hadoop.hdfs.server.namenode.TestNamenodeStorageDirectives

hadoop.fs.viewfs.TestViewFSOverloadSchemeWithMountTableConfigInHDFS

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.TestHDFSFileSystemContract

hadoop.hdfs.web.TestWebHdfsFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux b05d229192d0 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 20633a58709de5d8cbeed196a6508d0ec1417e0e

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/9/testReport/

Max. process+thread count
2938 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 15 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 42s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  9s

trunk passed

+1 :green_heart:
shadedclient
21m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 41s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
compile
0m 42s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

-1 :x:
javac
0m 42s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

-1 :x:
compile
0m 39s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.

-1 :x:
javac
0m 39s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 57s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 639 unchanged - 2 fixed = 645 total (was 641)

-1 :x:
mvnsite
0m 41s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 29s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

-1 :x:
javadoc
1m 20s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

-1 :x:
spotbugs
0m 42s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
shadedclient
9m 34s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 45s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
asflicense
0m 31s

The patch does not generate ASF License warnings.

78m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux c6cf12821443 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 35ddddb2b518683a5d33ad5599c4b64b3da58526

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/10/testReport/

Max. process+thread count
546 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 15 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 36s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 26s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  9s

trunk passed

+1 :green_heart:
shadedclient
21m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 56s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 5 new + 640 unchanged - 2 fixed = 645 total (was 642)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 10s

the patch passed

+1 :green_heart:
shadedclient
21m  5s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
229m 57s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

325m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux a6ac88742d77 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e9999acf7848f2c3974f92a8961f0187fb8329eb

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/11/testReport/

Max. process+thread count
3205 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Can we update the subject of this PR? As mentioned in a previous comment this PR makes block removal asynchronous and does actually speed up delete. https://github.com/apache/hadoop/pull/3063#issuecomment-868476838

@jojochuang  Can it be merged into the trunk branch, and what else needs to be done?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 19s

https://github.com/apache/hadoop/pull/3063 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/12/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 22s

https://github.com/apache/hadoop/pull/3063 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/13/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 21s

https://github.com/apache/hadoop/pull/3063 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/14/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 21s

https://github.com/apache/hadoop/pull/3063 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/15/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Will commit to trunk wait for two days if no more other comments.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 15 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 18s

trunk passed

+1 :green_heart:
compile
1m 32s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 26s

trunk passed

+1 :green_heart:
shadedclient
30m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 56s

the patch passed

+1 :green_heart:
compile
2m  9s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
2m  9s

the patch passed

+1 :green_heart:
compile
2m  0s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
2m  0s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 23s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 641 unchanged - 2 fixed = 648 total (was 643)

+1 :green_heart:
mvnsite
2m  8s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m  4s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
5m 10s

the patch passed

+1 :green_heart:
shadedclient
37m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
396m  4s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

529m 42s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestNetworkTopologyServlet

hadoop.hdfs.server.datanode.TestDataNodeReconfiguration

hadoop.hdfs.server.datanode.TestLargeBlockReport

hadoop.hdfs.server.namenode.TestEditLogRace

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/17/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux ec3d04987ba4 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 108e96cf1b503c34e211d104c223c074aca1b984

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/17/testReport/

Max. process+thread count
1933 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/17/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 15 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 25s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 22s

trunk passed

+1 :green_heart:
shadedclient
25m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
1m 24s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 24s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 56s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 641 unchanged - 2 fixed = 648 total (was 643)

+1 :green_heart:
mvnsite
1m 20s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 25s

the patch passed

+1 :green_heart:
shadedclient
25m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
328m 59s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

437m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/18/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux c4e1d249c0ad 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 108e96cf1b503c34e211d104c223c074aca1b984

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/18/testReport/

Max. process+thread count
1968 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/18/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Will commit to trunk once jenkins completed.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 23s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 15 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 42s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 27s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 13s

trunk passed

+1 :green_heart:
shadedclient
22m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 16s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 56s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 5 new + 642 unchanged - 2 fixed = 647 total (was 644)

+1 :green_heart:
mvnsite
1m 18s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 21s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 13s

the patch passed

+1 :green_heart:
shadedclient
22m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
232m 46s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

344m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/19/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux 25a72eabe263 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0d1f846778d58a915b96a05494e35e81d8ea966c

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/19/testReport/

Max. process+thread count
3273 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/19/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@zhuxiangyi Do you mind to fix the checkstyle refer to https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/19/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt. Thanks.

@Hexiaoqiao resubmitted

Commit to trunk based on build result (https://github.com/apache/hadoop/pull/3063#issuecomment-1011295026) and checkstyle fix only(https://github.com/apache/hadoop/pull/3063/commits/f6f2793310eff7c0678d027c912c95dcc3482972).
Thanks @zhuxiangyi for your contribution. Thanks @jojochuang and @tomscut for you reviews.

@zhuxiangyi It is conflict when cherry-pick to other active branches. Do you mind to create another PR to branch-3.3?

ok, I will submit it later.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 15 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 27s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  3s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 25s

trunk passed

+1 :green_heart:
shadedclient
25m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 18s

the patch passed

+1 :green_heart:
compile
1m 24s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 24s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 55s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 641 unchanged - 2 fixed = 643 total (was 643)

+1 :green_heart:
mvnsite
1m 18s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 23s

the patch passed

+1 :green_heart:
shadedclient
25m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
332m  9s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

441m 50s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.mover.TestMover

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/20/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux 5e7a248247a4 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f6f2793310eff7c0678d027c912c95dcc3482972

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/20/testReport/

Max. process+thread count
2012 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3063/20/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


First attempt at Cache rework

[ ] Tests added for any new code
[ ] Ran make fmt-fix (or had formatting run automatically on all files edited)
[ ] Documentation added for any new functionality
[ ] Entries added to ./unreleased/ for any new functionality

First steps toward #2339.
There's a few notable changes from the current implementation:

Recoverable[_] is not used. While that trait served as a means to transition caches into arbitrary states, originally for multicore, such functionality is only needed in the presence of SolverContext as part of the cache data structure, since that class is internally mutable. If no such data is present, the functionality of recover() and snapshot() can be achieved by just passing around immutable Scala objects.
SolverContext removed from all concrete cache implementations. In this iteration, the plan is to decouple SMT completely from the caches, and delegating the concern of maintaining synchronization obligations between caches/arenas and SMT to some dedicated manager class, if need be (in the future). As such, SolverContexts appear only as arguments to public methods, to be invoked on demand.
Extra methods added to Stackable, to facilitate (potentially delayed) constraint generation (see above).

Codecov Report

Merging #2648 (6468095) into main (d201eba) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2648      +/-   ##
==========================================
- Coverage   78.53%   78.36%   -0.18%
==========================================
  Files         454      457       +3
  Lines       15771    15806      +35
  Branches     2558     2548      -10
==========================================
  Hits        12386    12386
- Misses       3385     3420      +35

Impacted Files
Coverage Δ

...ache/tla/bmcmt/stratifiedRules/aux/Stackable.scala
0.00% <0.00%> (ø)

...e/tla/bmcmt/stratifiedRules/aux/caches/Cache.scala
0.00% <0.00%> (ø)

...cmt/stratifiedRules/aux/caches/IntValueCache.scala
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


APT repository signing key needs to be manually updated on client side in order to extend expiration date

A few hour ago I had:
W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: http://dist.keybase.io/linux/deb/repo stable InRelease: The following signatures were invalid: EXPKEYSIG 47484E50656D16C7 Keybase.io Code Signing (v1<EMAIL_ADDRESS>W: Failed to fetch http://dist.keybase.io/linux/deb/repo/dists/stable/InRelease  The following signatures were invalid: EXPKEYSIG 47484E50656D16C7 Keybase.io Code Signing (v1<EMAIL_ADDRESS>W: Some index files failed to download. They have been ignored, or old ones used instead.

It seems the initial key was created with an expiration date of 4 years, expiring on 2017-11-19 and that the expiration date has been extended for 14 more years very recently (on 2017-11-13): see output of gpg --list-packets code_signing_key.asc here: https://haste.zertrin.org/raw/golotegofa
If the key was added by apt-key add prior to 2017-11-13, it will not have the new signature from the current published GPG key, thus requiring user to understand what's going on (it took me almost an hour to figure it out, including the time to figure out how to print details from gpg commend about the key) and take manual action:

download code_signing_key.asc
sudo apt-key add code_signing_key.asc

Suggestion: better communicate when manual action is required, for example on https://keybase.io/blog

Cc: @oconnor663 can you provide some details here?

@zertrin yes this is my fault. We wrote some guidance but I didn't get it online in time. Fixing now,

Ok we have a doc up at https://keybase.io/docs/the_app/linux_expired_key.

The document linked above is now a 404

The document linked above is now a 404

The document linked above is now a 404

There's an archived version: https://web.archive.org/web/20200105201931/https://keybase.io/docs/the_app/linux_expired_key

The document linked above is now a 404

There's an archived version: https://web.archive.org/web/20200105201931/https://keybase.io/docs/the_app/linux_expired_key


Correct handling of corner-cases involving custom iterators:

High Level Overview of Change
This commit, if merged, corrects the handling of corner-cases involving custom iterators:

Under some conditions, comparing ReadViewFwdRange::iterators for equality could result in derefencing an empty std::unique_ptr which will result in a crash.
The OpenView::txs_iter_impl::equal function could throw an std::bad_cast exception which was unexpected.

Type of Change

[X] Bug fix (non-breaking change which fixes an issue)

Merged as deea16e14fae35166ee1b9e39d333672e7b30761


New function: get_midpoint for mobject

Changelog / Overview
There are already a lot of coordinates one can obtain from an mobject (https://docs.manim.community/en/stable/reference/manim.mobject.mobject.Mobject.html#manim.mobject.mobject.Mobject.get_bottom)
But it would be nice to also have the possibility to easily get the middle point of a line of an mobject with get_midpoint.

This function is calling self.point_from_proportion(0.5).
As point_from_proportion is implemented in vmobject and I implemented get_midpoint in mobject, is this something that would cause problems? And is this the pythonic way to do it?
Checklist

[x] I have read the Contributing Guidelines
[x] I have written a descriptive PR title (see top of PR template for examples)
[x] I have written a changelog entry for the PR or deem it unnecessary
[x] My new functions/classes either have a docstring or are private
[ ] My new functions/classes have tests added and (optional) examples in the docs
[x] My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

[ ] The PR title is descriptive enough
[ ] The PR is labeled correctly
[ ] The changelog entry is completed if necessary
[ ] Newly added functions/classes either have a docstring or are private
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

Adding onto what @behackl wrote in #1198 about closing things preemptively, you can write Fixes #xxxx to link the PR and issue from the PR text/body.
Additionally, please don't delete the <!--changelog-start--> <!--changelog-end text-->. It's useful to keep around so I don't have to dig around for it for the changelog/release.


Optional integration of GitHub language colours

GitHub uses some colour encoding per language. So maybe it would be possible to integrate this?

Thanks for the suggestion, I will keep note of this until I figure out a way to implement it within the extension


Adding Validation Phase to Zookeeper Operator

What this PR does
This PR adds a Validation Phase to the Zookeeper Operator based on the existing Validation Plan. There were a few small fixes to the existing validation job but the behavior now encouraged for other Operator Developers is now that we add similar phases to the deploy plan.
What are the changes
The validation phase just completes as soon as the service discovery for Zookeeper works. When then e.g. using Kafka in combination with Zookeeper we can have a Plan that consists of the dependency phase with a step for the Zookeeper operator deployment and its task, followed by the step for the Kafka operator deployment and its task. Since the Zookeeper deploy plan has a validation phase it will just continue to deploy Kafka once this completed, ensuring that Kafka can connect to Zookeeper.
Why
When running this lego blocks I noticed that a lot of the time Kafka was failing due to unresolvable Zookeeper domains. CrashBackErrLoop then slowed down the deployment and so on...

to land this we would need to wait for https://github.com/kudobuilder/kudo/pull/551 and a new cut release so the tests won't fail.


Failed to sign in with github - token empty

Describe what happened:
Cannot sign in to liveshare.

it does not prompt any sign in after I select sign in with github...
What was your system configuration?
Product and Version [VS/VSCode]: VSCode
OS Version[macOS/Windows]: macOS Monterey
Live Share Extension Version: LTS
Target Platform or Language [e.g. Node.js]: Node.js
Steps to Reproduce / Scenario:

Sign in with github

Please attach logs to this issue:
You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue
attached above
Screenshots
attached above

found problem, my vs code was still in download folder(read only volume), so I had to move it out,
update VS code to proper version, and now all works. This problem wasn't shared on web surprisingly...


Fix percentage tick formatters

Description
This PR tweaks the percentage tick formatter to multiply its input values by 100.
Test cases included!
Checklist

~[ ] The changes have been tested to be backwards compatible.~
~[ ] The OpenAPI schema and generated client have been updated.~
~[ ] New models module has been added to api generator xtask~
~[ ] New types/fields are [well-documented and annotated]~(/CONTRIBUTING.md#adding-types-and-their-annotations).
~[ ] The CHANGELOG is updated.~

Please link any related PRs in other repositories that depend on this:

After merging, please merge related PRs ASAP, so others don't get blocked.

Can you update the Rust version too, or you prefer if I do it?

Can you update the Rust version too, or you prefer if I do it?

steph's gonna pick up my other thing i was gonna work on so i'll take a stab!


Helpers functions can now lookup by id or by keyname

General thought: If you have the Id, you would normally just use getObject on the particular service to get it. Rather than padding an object filter with the Id.
Are you looking to support when the conf user puts in Ids for these things?

I could use the getObject functions however they don't currently exist. I think it would be overkill to make getObject functions for datacenters, routing types, routing methods, and health check types when we only need to retrieve the name/id pairing.

As for the need for retrieving id based on name: I need to do a "reverse lookup" when performing a read (since the API call sends back id and the users tf code contains the name)


Improve Rust syntax highlighting

Resolves #56 and generally improves Rust highlighting.
Code snippet showcasing the changes:

Oops, forgot to pull upstream before creating new branch... I'll create another PR. Sorry!


Use jest for unittesting - standardize unit testing epic

Issue:
What I did

UPDATED a lot of packages
ADDED jest tested to the root
REMOVED unit-testing dependencies from packages
CHANGED tests to run in jest
MOVED examples out of packages

@aaronmcadam please review?

@ndelangen I see you're trying out yerna, what was the motivation there? The author himself says it's quite a hacky solution.

Ok, @shilman I agree, linting can be made much more strict then it is now. I will setup a new branch and PR for that. I think we can merge this and then start working on improving linting?

OK @ndelangen I agree with that solution, because we are doing heavy lifting on the monorepo transition and it's better to have these big changes merged. But FYI, I added a line in some source file that said only foo and the linter didn't throw any error. So I think it's a high priority change. I'm glad to see you're already working on it.