(todo-mvp-kotlin) dependency injection with Koin

Hello,
I work on Koin  - a Kotlin dependency injection framework that make DI very easy. I made a dedicated branch, from MVP-Dagger & MVP-Kotlin:
https://github.com/Ekito/android-architecture/tree/dev-todo-mvp-kotlin-koin
You can read my article on<EMAIL_ADDRESS>Don't know if it can interest you. Let me know :)

Hi Arnaud,
It looks interesting! If your framework gets community traction we'll add it to the main list.
In your article you say

The Dagger project has been written by Google team

That's actually not true. Those are written by experts from the community.
It's very cool to see Blueprints used this way, nice job!

Hi Jose,
Very cool! We will see if people begin to use Koin. I fixed my article, thanks.
Blueprints are a great reference! 👍

Hi guys,
Maybe this is not the appropriate issue for this but... I'm a mid-level android dev and I'm starting to use MVP so I was wondering, what are the benefits of creating a Fragment and Activity for every screen? Does it have to do with Activity lifecycles?
Sorry for polluting this @arnaudgiuliani

@kazijosh indeed not the place for that question. Google it or try Stackoverflow to read about the pros and cons of each solution.
We mention it in the todo-mvp readme

The use of both activities and fragments allows for a better separation of concerns which complements this implementation of MVP. In this version of the app, the Activity is the overall controller which creates and connects views and presenters.


"Internal Server Error" when trying to activate domain

Describe the bug
A clear and concise description of what the bug is.
Custom domain vote.gamium.world has been added to domain.json and approved. All steps instructed at https://docs.snapshot.org/spaces/add-custom-domain have been completed, but when calling to  https://ina9pk8175.execute-api.us-west-2.amazonaws.com/dev?domain=vote.gamium.world the server answers with {"message": "Internal server error"}
To Reproduce
Steps to reproduce the behavior:

Just execute https://ina9pk8175.execute-api.us-west-2.amazonaws.com/dev?domain=vote.gamium.world
See error

Hey! W are discussing possible improvements. I assume the issue right now is that we have an additional deployment step, so the updated domain list is not immediately "live". But not sure about this.


Support to Spark 1.4.1 and 1.5.2

Description
Changes to be compatible with multiple Spark versions using profiles. SPARKTA-207
Reviewer
@gserranojc
Test
All passed.
Coverage
No changes
Scalastyle
No info

+1

Please edit the documentation:
https://stratio.atlassian.net/wiki/display/SPARKTA0x8

https://stratio.atlassian.net/wiki/display/SPARKTA0x8/15.+Building+Sparkta

+1

+1


Update Composer dependencies (2023-06-15-00-09)

Visual regression test passed!
View the visual regression test report


chore: increase max call send&receive message size

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.759%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2167

Relevant Lines:
5591

💛  - Coveralls


Fix component reflection such as to not force the component to impl Default

Currently, the codegen'd component reflection always emit a call to C::default(), forcing the component to impl Default. Sometime this really is meaning less (e.g what's a default EntityPath or ComponentName?).
Funnily the ComponentReflection struct actually has an Option. The codegen should therefore emit None if the component doesn't have Default (which the codegen knows from the attr.rust.derive attribute).
Edit: the codegen doesn't always know about Default if it's manually implemented. So that should be controlled with a new fbs attribute attr.rust.no_placeholder

I ran into this myself when adding ShowLabels. ShowLabels is a component whose fallback value is always computed from other data, and does not have a default that is meaningful at all.

We discussed this internally quite a bit internally
https://rerunio.slack.com/archives/C041NHU952S/p1726669945999429
The gist of it that we do need guaranteed defaults for anything that's potentially ui editable (for the value to start out with). Overall, the force to default was introduced as a simplification so that anyone querying a fallback can rely on it being there and treat it as an hard error when it isn't.
It is a known issue that Default trait us such is slightly misleading semantically here. When we introduced this we discussed the possibility of a separate trait but discarded this because of the added overhead.

@kpreid ShowLabels would be a case where a default value is important. The reason is that one can edit it in the visualizer ui and the ui needs a value to start with.

Have some work in progress that allows to generate placeholders fully generically so we need lot less of those pointless looking defaults and can actually make use of the fact there's always a placeholder 🙂
https://github.com/rerun-io/rerun/tree/andreas/automatic-component-placeholders
since we still want to use Default for custom placeholders when available I think we'll have to make it opt-out as proposed in https://github.com/rerun-io/rerun/pull/7440
.. unless someone does a codegen thing where we check whether Default procmacro is used or there's a Default impl in the extension :)


Contact Us form handler

Add endpoint to handle contact forms, eg on the Minimal theme. Should probably incorporate a captcha to prevent spam.

I did add an endpoint and wired up on the minimal theme already. But good point with the Captcha. Will add that too

@shahthepro did this end up happening or should we move it to the backlog?

@micahalcorn Contact form is there but captcha is still pending. We could move this backlog or close this one and open a new one for that alone.

Thanks, I'll just keep this one open.


Feature: Add support for MarkDeep

Currently lexical doesn't support a way to use Markdown style diagram that can be edited on the fly. In Hugo, GoAT is an extremely useful and easy to learn diagramming tool, however, diagrams only generate at build time through Go. Markdeep is a JS implementation of the the same method of diagramming and can be used to generate the previews in real time.

As an alternative, I've considered diagramming in Draw.io and then linking to the file/image, however, that increases the number of steps in the process and defeats the flow of having a single more powerful editor.

Images taken from: https://casual-effects.com/markdeep/

I'm not sure if we want to add this to core, but this could be a potential separate open-source project someone who wanted to implement it separately. A lot of the logic could be copied from @lexical/markdown and then added as it's own plugin.


hyperv: Replace parseLines/SplitLines with getFirstLine

In the hyperv code, there are many occurrences of resp :=
os.SplitLines(stdout) if resp[0] == ...
This does not check if resp is empty before trying to reference it, which
recently triggered a panic in crc (
https://github.com/crc-org/crc/issues/3764 )
This code adds a getFirstLine helper which will return an empty string if
stdout is "".
This should fix https://github.com/crc-org/crc/issues/3764

/lgtm
/approve

Let's hold this for a little bit, I'll add some unit tests.

I've now added unit tests, and they made me wonder if it would not be best to change SplitLines("") to return { "" } instead of { }, as at the moment it's a bit weird that SplitLines("\n") returns { "" } while only "" returns an empty set.

I've now added unit tests, and they made me wonder if it would not be best to change SplitLines("") to return { "" } instead of { }, as at the moment it's a bit weird that SplitLines("a\n") returns { "a" }, SplitLines("a") also returns { "a" }, but we don't have the same behaviour if we use an empty string instead of "a"

with just "\n" its an empty line but with "" there's no line, so maybe not returning { "" } is better or we could decide to treat empty lines as no line and return {} for "\n" this will make it consistent

I've now added unit tests, and they made me wonder if it would not be best to change SplitLines("") to return { "" } instead of { }, as at the moment it's a bit weird that SplitLines("a\n") returns { "a" }, SplitLines("a") also returns { "a" }, but we don't have the same behaviour if we use an empty string instead of "a"

with just "\n" its an empty line but with "" there's no line, so maybe not returning { "" } is better or we could decide to treat empty lines as no line and return {} for "\n" this will make it consistent

The initial bug is that {} is not handled correctly by our code, if we never return {}, there is no bug :)
{} for "\n' would not be that consistent, as "\n\n" returns { "", ""}


Documentation

Write/improve documentation

Basic documentation system added, along with the CI integration for building documentation for all branches/tags.

Documentation added. There will be many improvements (e.g. all code examples will be sourced from the actual examples built on CI, or add in-source documentation to be picked-up by the doxygen) but they will target later releases.


With --experimental, traceur generates wrong commonjs output since version 0.8.2

hi,
since version 0.8.2 (up to current version 0.8.4) traceur prepends
"use strict";
$traceurRuntime.options.symbols = true;
in each output file when using the following commandline option :
traceur --experimental \
      --array-comprehension=true \
      --type-assertions \
      --type-assertion-module ../lib/assert/assert \
      --modules commonjs \
      --debug \
      --dir target src

this seems not correct, isnt it ?
now when i am trying to start such a transpiled file using
node file.js

the js file has'nt any chance to load the traceur runtime  because traceur prepends the reference to
$traceurRuntime.options.symbols = true;

right before the require statement to load the traceur runtime.
anyway - setting this traceur options again and again in every file cannot be the right way ...
up to version 0.0.81 everything was fine.

Work around. Don't use experimental.

Fixed by 67180b377559adeb330260e95b878afb99e826af


Use ResourceFlavor.metadata.labels instead of ResourceFlavor.labels

What would you like to be cleaned:
Since we are already thinking of v1beta2, we could consider deleting the field .labels and use .metadata.labels instead.
Why is this needed:
Users could be confused trying to use .metadata.labels which wouldn't give the results they want.
I can't think of a use case where a user would want to use metadata.labels without wanting them to match workloads' node selectors.

The ResourceFlavor struct field .labels is currently being referred/used by:

cache
Snapshot unit tests
Job controller
Scheduler and its unit tests
resourceFlavor webhook validation

The changes to resourceFlavor struct would require changes in the above places.

I would like to work on this
/assign

Thanks @thisisprasad

Any progress on this?

Working on the changes. Midway through. No blockers till now.

I think we should also update the documentation related to resourceFlavors as the labels field is repositioned. Changes would be required in /docs/concepts/ and /docs/tasks/ directories.
Will it be fine to update the documentation in the same PR as of code?

Yes, that's fine and I would encourage it :)

Any progress? Since pretty much everything else is ready for 0.2.0 and this is low priority, we can leave it for 0.3.0

I've raised PR for this.
Apologies for the delay.


Remove smallest allocation for flye, small jobs run with 8c/30m

I am using c and m for cores and mem here


Detail the architecture for the execute component and actuators

Define the architecture for the solution.

@nmsa for this issue, I worked on two repositories:

Knowledge Component/branch: https://github.com/eubr-atmosphere/tma-framework-k/tree/actuator-definition
Execute Component/branch: https://github.com/eubr-atmosphere/tma-framework-e/tree/jose-update-architecture

Let me know what other changes/definitions are needed.


Add ability to configure the test title when importing a scan

Is your feature request related to a problem? Please describe
When I import a scan, either through the UI or through the API, I cannot give the resulting test a title. Instead I need to perform an extra step, either edit the test in the UI or send a PATCH request through the API.
Describe the solution you'd like
Add an optional field to the /api/v2/import-scan/ endpoint that can be used to set the test title and add an optional field to the import scan form to set the title.
Describe alternatives you've considered
n/a
Additional context
n/a

I want to try to make this feature


PowerToys Run does not show vscode workspaces in WSL

Microsoft PowerToys version
0.35
Running as admin
No
Area(s) with issue?
PowerToys Run
Other Software
WSL2
Visual Studio Code 1.55.0
Steps to reproduce
Use PowerToys Run to search for VSCode workspaces.
SSH connections and other non-WSL workspaces will show up correctly
Anything inside WSL will not be shown
✔ Expected Behavior
All workspaces are shown
❌ Actual Behavior
Only non-WSL workspaces are shown

@Gameghostify
thanks for reporting the issue. The problem is tracked by https://github.com/microsoft/PowerToys/issues/10530


publish<EMAIL_ADDRESS>

Requested by: @flub
Quick links:

View changes
View check runs

Assign the accepted label to this issue to approve the release.
Targets

[x] crates
[ ] github

Targets marked with a checkbox have already been executed.  Administrators can manually tick a checkbox to force craft to skip it.

See https://github.com/getsentry/rust-debugid/pull/16

getsentry/release-bot was lacking permissions to create a release on rust-debugid. Rerunning.


Support beam parameters initialization and dynamic configuration

Beam centroids and envelopes are predefined before lattice definition in FLAME lattice file, features like changing these parameters should be able to implement in this package.

Resolved by 592222bd4a7b3ffc212ccb0a531d93df6e8f2a63.


Add stop-loss only for second order in trade

Need to add stop-loss mechanism for second order in trade. This can allow bot to close trades more quickly. Need research to understand optimal persnatege for stop-loss

Logic to discuss: Create two orders as second order on trade - STOP_LOSS/STOP_LOSS_LIMIT and LIMIT. Limit order - with profit from system(OrderService::53) and STOP_LOSS/STOP_LOSS_LIMIT with lowProfitThreshold from bots profit config.
In case price will be lover lowProfitThreshold value STOP_LOSS/STOP_LOSS_LIMIT order will be filled and system should cancel LIMIT order and finish trade. In case LIMIT order is filled system should cancel STOP_LOSS/STOP_LOSS_LIMIT order and finish trade.


Add some builder getEnv tests

In particular I want to make sure that calling getEnv() when the same
var name appears more than once in the env list that we only pick up
the first one.  PR #15182 counts on this
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

LGTM

LGTM


Version for zenphoto

Develop a version of the theme compatible for zenphoto.

OK, that one was really funny!

I do not want to break sugar on the back of the conccurents but ...


Question: dev kv support

💡 Feature request

Overview and problem statement
Now that wrangler dev is in beta, are there any plans to add local kv support?
It would be pretty useful to spin up locally the "full ecosystem" and develop against it, ideally with offline support. Unless I'm missing something, right now it kinda feels like coding in the dark unless you deploy/preview with the real kv which is not ideal specially in a team.

Hey @donifer - This is already (sort of) implemented.
wrangler dev is not offline (see #1093) and we are planning on creating a new preview KV namespace for you that you can use to test and it will not interfere with your production KV namespace (see #1032)


To expose directives APi to create a directive

Summary
The feature should expose something similar to plugins.RegisterAction to register custom directives.
Basic example
One should be able to add a custom directive with plugins.RegisterDirective(). There was something similar in v2 according to this plugin but seems missing in v3.
Motivation
This will help in extending the flexibility of creating plugins.
Current Issue:- Right now I am creating a plugin for rate-limit support for Coraza but I have to mention the configuration for rate-limit using an action called rate-limit (part of the plugin) for each rule. Once I have the capability to add directives I can add a directive that saves default rate-limit plugin configuration.

I agree.
I have been doing some research, and we have certain limitations:

Directives should only affect operators and actions
We can easily add values from directives into OperatorOptions, but what about actions? They receive RuleMetadata. Should we only implement it for operators?
Where do we store custom data from custom operators? The current implementation of directives has access to sensitive low-level stuff we want to avoid exposing, like rule parsing.

cc @corazawaf/core-developers

Relevant:

https://github.com/corazawaf/coraza-geoip
https://github.com/VermaShivansh/coraza-ratelimit-plugin


Fix lint issue in dispute_case_record.go

Coverage remained the same at 34.88% when pulling 5ddbe39f03afad1e6d385075d57b0513908629e8 on lint into badd5838e4a731105c7e614a23e76fcee61f58a3 on master.


Update imageapi extension/module for ImageAPI 0.2.0

Adds a bunch of new features, like NFS and iSCSI support

Resolved by #49


Do not localize deletion emails.

This fixes #909
r?

Fixed the PR in #936. Thanks @wagnerand for investigating this!


[REQUEST] In-Memory database

like memgraph (or as a different example sqlite) got
some sort of only-in-memory storage if persistence is not needed at all

Hi @LowLevelMahn thanks for raising the issue. This is a feature we're also looking into. Will make the design public once we get started on it.

I am also interested in an in-memory storage model.
My actual use case is rather than one global graph db, having one small graph db per "case", in S3 blob storage. Then quickly loading the small graph db into either an in-memory db or a temporary on-disk directory. And writing it back to S3 if there were any writes.
I can do this with Sqlite via the serialize/deserialize commands. It would be great with Kuzu to be able to serialise the catalog/metadata/data/index/wal files (per the physical storage described in https://github.com/kuzudb/kuzu/issues/1474) to a single binary blob, and then deserialise it to reload.

Hi @stevesimmons , thanks! That is a quite interesting use case. It makes sense to serialize/deserialize the whole database into/from a single blob, though we have to think a bit more how this can be done altogether with our on-disk storage changes. I'm adding that into our design for in-memory storage mode.

I'd love this feature too; my use case is very similar to the one described by @stevesimmons .
I know that you're working with an IMPORT/EXPORT command, which should facilitate importing/dumping the database into S3.
But when importing an existing database, I would like to keep it only in memory, as it is a temporary database instance used only for reading data from the graph.
ATM I'm forced to initialize the DB using the following code:
with TemporaryDirectory() as tmp_path:
   ...

But disk is way slower than memory.
Duckdb for example supports in-memory databases by default: https://duckdb.org/docs/api/python/overview#using-an-in-memory-database

just +1 on on this

+1

@dremekie Could you please upvote the topmost post so that we can use the stats in our sorting? Thanks!

In this regard: How could derived data be handled in Kuzu database?
For example, given some persistent data A stored in DB, and other data B derived from A, it makes more sense to ad-hoc generate B on each app startup and store it only temporarily until DB shutdown. Reason I'd like to store this derived data temporarily for the database session is leveraging Cypher queries on it.
What if we could have a separate "area" for in-memory, volatile data while being able to also access and write persistent data? So this would be rather a case-by-base decision than all or nothing for in-memory vs. persistent model. This derived data could look same as the normal one and from user's perspective (Cypher) use same tables. Only distinction would be passing certain flag at creation time.

Hi @sapalli2989: As I understand, you are thinking of a partially in-memory and partially on-disk database. This may be a good idea but I think it's a complicated one and I doubt we would deliver it, considering the complexities it would add to our use case. In case, we should first deliver a proper in-memory version at some point.
Two comments: First, if you want to avoid I/O and get an in-memory version of Kuzu, you should be able to do so by opening your database to a /tmp directory which is backed by tmpfs in-memory file system on many operating systems. Therefore you wouldn't actually do any I/O. By default when you start Kuzu, we set Kuzu's buffer manager to 80% of your available RAM. If you point your database directory to /tmp, you should decrease your buffer manager space to say 40%-50% of your available RAM when starting Kuzu because each page of your disk will be stored both in the tmpfs in-memory file system's buffer + Kuzu's buffer. We have not really tested this on our side but this should just work. The implication of this solution is that you can have in-memory databases that are at most ~40% of your available RAM. We want to eventually implement a proper in-memory version that does not have this problem of database pages being stored in RAM in duplicate manner. We can also do a few more optimizations to make this feature work better. But we're not there yet.
On the other hand, for the case of deriving temporary data B that you don't want to permanently store: I think you can do the following steps for now: EXPORT your database A somewhere persistent, say /persistent/foo. Then open a new database that points to  /tmp/in-mem/bar, so it's backed by the tmpfs in-memory file system. Then you can IMPORT /persistent/foo and then derive new data B etc. When you shut down your /tmp/in-mem/bar, you should rm -rf /tmp/in-mem/bar though because as I understand what you wrote there will not be deleted automatically (though this behavior might change between OS distributions) and could take from your RAM.

This in memory mode is added in #4012

great - thanks


Improve workflow and notification when cherry-pick has conflicts

Git cherry-pick can result in merge conflicts and the beginning of a conflict resolution workflow, like when rebasing. VS Code should treat conflicts during cherry pick similarly to rebase and provide the same features and functionality:

Change the status bar to indicate "Cherry picking" after the branch name.

Change the Source Control action button to Continue, enabled based on the conflict state.

Show the same merge conflict notification, as in a conflicting rebase.

Provide a "Git: Abort Cherry Pick" command.

As far as detection, there exists a .git/CHERRY_PICK_HEAD file containing the cherry-picked commit hash, but I don't see the same kind of apply or merge directory that was recently added for rebase detection.
Looks like we'd need a new operation, probably CherryPickContinue.
> git cherry-pick 4056c61a19c922850f6c44aa6188837a06170585
Auto-merging example.json
CONFLICT (content): Merge conflict in example.json
error: could not apply 4056c61a19... Updated example.json
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

https://git-scm.com/docs/git-cherry-pick#_description

Perhaps it's a separate issue, but it would be nice to see "Cherry Pick..." somewhere in the Source Control panel menu. I'm not sure exactly where. It might go nicely in the Branch sub-menu after Merge Branch and Rebase Branch. Right now, I have to find it in the command palette as "Git: Cherry Pick..."

There are opportunities for future improvements around cherry picking ranges, recording origin, and using no commit.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Disallow additionalProperties on the .metadata.labels object

Closes https://github.com/giantswarm/roadmap/issues/2582
For details, see the issue.
The pattern in .metdata.labels did not include a slash, which is frequently used in K8s labels. I added it.
For confidence, I'm adding a label to the CI test values.
Please check if PR meets these requirements

[x] Results of the diffs have been examined and no unintended changes are being introduced.

Trigger e2e tests

/run cluster-test-suites

/run cluster-test-suites


upgrade to react 18 and next 13

What is the purpose of the change
Upgrading React, Next,
ClickUp Task
ClickUp Task URL
Brief Changelog
Update React, Next
Testing and Verifying
This change has been tested locally by rebuilding the website and verified content and links are expected

@MaxMillington
Notice any improvements with the Rust-based webpack replacement?
https://nextjs.org/blog/next-13

@MaxMillington
Notice any improvements with the Rust-based webpack replacement?
https://nextjs.org/blog/next-13

Haven't noticed any improvements yet. I got a few errors but I've been having a hard time determining which if any are caused by the upgrade, that's why I want to try to fix those errors we are seeing in the console so I can isolate any errors that I missed.

@MaxMillington in the name of cleaning up PRs, would you consider this one stale?

@jonator No, let's keep this one open. We need to figure this out as every month we put it off it gets more difficult. A substantial portion of the work is just fixing all the type errors in our repo, and this PR fixes quite a bit of them.
That said, I am not going to deprioritize staking work for this nor should we deprioritize token info pages


Add shortcut for "git remote"

Something like "gg r" will do

What purpose do you intent this to solve? From my experience, git remote is mainly used to set configuration and manage remotes.

yes and thats why I'll like a shortcut for this. I'll be happy if this can be incoporated. But I totally understand if you don't find it important.

Could you give me any use-cases that aren't more efficient simple due to not having to type git remote but rather gg r?

I can't give you one. I taught that was the point of this tool (to help us type less)?

I think an interesting new feature, along with having to type less, would warrant adding a new command.
Do you have specific special new features for gg r in mind?


Do not append lines to the URL when nothing is selected

Currently when calling :OpenInGHFile the command will always append #LX to the URL which is not always wanted as sometimes you just want a link to the file not the specific line your cursor resides on.
This PR changes the behaviour in such a way that when you're not selecting lines when calling the command it won't append line numbers to the URL. If you are selecting something in visual mode it will append the lines to the URL.
An addition to this PR is that I've gotten rid of some camelCasing as well as a typo in a certain function.

Thank you @PlaiyTiziano for the PR I'll approve and merge


Fix detection of CRLF line endings

Corrects logic to check that the character before the last '\n' is '\r', and if so, correctly report CRLF ("\r\n") line endings.
The current logic is checking the same character position that '\r' was found in also contains '\n' which always evaluates to false.

Codecov Report

Merging #2357 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #2357   +/-   ##
=========================================
  Coverage     82.35%   82.35%
  Complexity     2134     2134
=========================================
  Files           349      349
  Lines          6058     6058
  Branches       1110     1110
=========================================
  Hits           4989     4989
  Misses          489      489
  Partials        580      580

Impacted Files
Coverage Δ
Complexity Δ

...lin/io/gitlab/arturbosch/detekt/core/KtCompiler.kt
85.18% <0%> (ø)
6 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7780548...afc26ae. Read the comment docs.


Correction for raw affiliation Brain and Mind Institute, Western University

Correction needed for raw affiliation Brain and Mind Institute, Western University
raw_affiliation_name: Brain and Mind Institute, Western University
new_rors: 02grkyz14
previous_rors: 00we1gw23;05cgtjz78
works_examples: W4366083753;W4389078325;W4372286277;W4386249051
contact: 519567cdc19774f7cffd369ab186e0cf:cd93ff0480557991 @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Update flow requires double update between v4 and v5

Issue Summary
When trying to update from v3 to v5 (latest), I came across a situation in which I need to double-update v4 in order to get the truly latest v4, before being able to finally upgrade to v5. I think this flow is a bit weird -
Steps to Reproduce

Update from v3 using ghost update
Get asked to update to v4 first, run ghost update v4
Try running ghost update v5 and ghost update but fail since latest v4 is not installed
Run ghost update v4 again to get (really) latest v4
Run ghost update to get latest ghost v5
Profit

Ghost Version
3.*
Node.js Version
16
How did you install Ghost?
Directly on Ubuntu
Database type
MySQL 8
Browser & OS version
Ubuntu 18
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

@TomGranot hey I am a beginner to open source can I contribute to this issue?

@TomGranot this is certainly not expected but I'm missing a few details to reproduce:

What exact version of Ghost v3 did you start on?
Which exact version of Ghost v4 did you upgrade to, and when?
When did you upgrade to v5 / how long was there between the two upgrades?

My best guess is that a new version of v4 was released in the middle of your upgrade process.

@yeshwantthota stay tuned, let's see what gives. Thank you for offering!!
@ErisDS Everything happened in the span of a few hours, so I assume that might be what happened.
Can't recall which v3 or v4 unfortunately. Feel free to close if this contains too little info

OK great - I will close this for now and move it over to the Ghost CLI repo. If we get more reports we can reopen and investigate further.


Require manual_builder in abstract_manual_service_registry

The absence of this specific require statement meant that we were
seeing the following error in the development environment:
NameError: uninitialized constant
  AbstractManualServiceRegistry::ManualBuilder

You could see this problem by either visiting
http://manuals-publisher.dev.gov.uk/manuals/new or by executing
AbstractManualServiceRegistry.new.new({}).call in the rails console.
We've investigated writing a failing test but it doesn't seem to be
possible because ManualBuilder is available in the test environment
but not in the development environment. This appears to be related to
the fact that cache_classes is true in test and false in
development.
We're fairly confident that this won't be a problem in production as
cache_classes is true.

Thanks @chrislo. I've rebased on master and force pushed in preparation for merging.


Fix coverage report

The update to use Lerna somehow broke the coverage reporting. Maybe now is a good time to finally move off of isparta, which is completely abandoned haha

Closing in favor of #56


[Windows VST] Keyboard input not being received by plugin in some hosts

Right now, the onKeyboard event is not necessarily called in Windows VST builds, depending on the host. For instance, it is properly called in FL Studio, but not in Carla and Renoise (even with the 'Enable Keyboard' option enabled).
The issue is present on both the master and develop branch.
It seems like calling getParentWindow().focus() temporarily fixes this in Carla.
Is it up to the host to relay keyboard events to the plugin, or is there something we can do in DPF to make sure that the plugin receives the events?

This is something the hosts need to handle.
If plugins try to mess around with things, we will get Linux in the same situation of Windows, where things are now too messy and out of hand.
When everyone fights for focus, nobody wins.
Please open a ticket against carla, reporting a plugin where it can be reproduced in.

by the way, which plugin are you testing this with?
not a lot of them have keyboard input...

I'm testing it with the MidiKeyboard plugin. I was planning on adding keycodes support to the plugin in a later PR.

ah okay, so it has keyboard input already.
one more reason for me to review it quickly then.

Well, it has keyboard input, but I haven't pushed it yet :) I figured it was better splitting this into two PRs.

Please push some barebones keyboard input, even if forced to qwerty layout for now.
That will make it handy, and I am fine with merging an initial version with just that.

Done.
Note that I've only tried this in the latest Carla release, not the latest Carla on the develop branch. I can reproduce the issue by running the keyboard example using the win64 bridge.


Could be a good idea change Magical Voxel (it is only free not floss) to other alternatives floss?

Hi.
I see that in the readme.md  you have a MagicalVoxel and it is only free price and only for windows. And there are some floss alternatives (yep, they are not mature projects or they haven't some features...but they are floss):

https://github.com/guillaumechereau/goxel : it is a good project from a good french guy and I added some code lines to it.
https://github.com/mgerhardy/vengi : only I know the project....I haven't play.

Regards.

Goxel is Open Source and fully available on Github but its features and updates are far from Magicavoxel and MV os free even for comercial use.

In the past I played with it and yes, it is a nice alternative, but a bit far from features and usability from MagicaVoxel.
Some months ago we created a state of the art research in: https://github.com/Voxelers/mcthings/issues/95


move config file to .config for a cleaner home directory

as i mention here #166

Thanks for the PR!
I'm definitely in favour of using the ~/.config/ folder, but this needs a fallback to still load ~/.tvnamer.conf for backwards compatibility with existing configs.
The ~/.config/... one would take preference, and the presence of the old config should output a warning. I imagine the logic would be:

Check for ~/.config/tvnamer/tvnamer.json - load this if present
If not present, check for ~/.tvnamer.json - load this
If ~/.tvnamer.json is present, output warning informing user of new location (this should happen regardless if ~/.config/... file exists to avoid confusion)

I'm happy to make these changes for the next release if you don't have time!

i don't write python code for a long time but i can try
i don't read  source code for completely but it should be https://github.com/dbr/tvnamer/blob/f3af5e17cb9ef77af0470abe3a2e3352c54e676b/tvnamer/main.py#L388 until line 432

Looks good to me! I think a single message if the old config file exists is fine - there's a minor typo in the message but easier for me to tweak that after merging.
Thanks! I think this is the last improvement I wanted to sort out before releasing v2.6, shall hopefully get to that in the next few days


introduce GadgetInstanceManager to run gadgets server side

This PR introduces the GadgetInstanceManager that can run gadgets server side (instead of interactive and connection-based, which is the current default) when used in client/server mode (ig-k8s + ig as daemon), based on a (stored) configuration.
This is especially useful if you want to use IG for observability (exporting metrics to Prometheus for example) and not as a interactive debug tool.
Overview
If a gadget is started server side, the context is held by the server - and only by shutting down the server or requesting a gadget to be stopped that context will be cancelled as well.
Gadgets are usually started on the server calling the client application (kubectl-gadget / gadgetctl) with a new flag (--detach currently). A new RPC call (InstallGadgetInstance) is called to store the gadget instance configuration on the server.
On the server (as part of the gadget-service), a Store will receive run requests and - depending on the environment - will either store the request inside a file (ig --daemon) or a ConfigMap ig-k8s. The store then tells the gadget-service to run the gadget.
Upon restart, the store will read all stored configurations and start the gadgets again.
New RPC calls for listing and deleting gadget instances are also implemented. gadgetctl list will for example return all currently installed gadget instances, a gadgetctl delete ID will stop and remove a gadget instance by it's ID.
Gadgets will automatically be assigned a new UUID and a random human-readable name upon start - the latter makes it easier to handle them. Additionally, a user can apply tags to gadget instances; this allows organizing gadgets for example from other interfaces (Headlamp, other Web-Interfaces).
When running a gadget, the server maintains an event cache (with a configurable size) that can be replayed to connecting clients. The process of receiving events from a gadget is called attaching. gadgetctl attach ID will attach to the gadget instance with the given ID and real-time events will be received. Note that multiple clients are able to connect to the same gadget instance at the same time, so that events will be broadcasted to every connected listener.
Configuration
Since the recent refactoring, all a gadgets needs is an image name and a map[string]string for parameters. The configuration (files) will also only support that plus the UUID, name and tags.
Example output
$ ./gadgetctl list --details
INFO[0000] Experimental features enabled
ID           NAME                                     TAGS                                     GADGET
b2ccc0211d20 thirsty_booth                                                                     trace_open
  operator.oci.ebpf.uid<PHONE_NUMBER>
  operator.LocalManager.host       true
  operator.cli.output              columns
  operator.oci.ebpf.trace-pipe     false
  operator.filter.filter
  operator.oci.ebpf.failed         false
  operator.cli.fields              runtime.containerName,pid,uid,gid,mntns_id,ret,flags,mode,comm,fname,timestamp
  operator.oci.ebpf.pid            0

$ ./gadgetctl run trace_exec --detachable --host
$ ./gadgetctl list
INFO[0000] Experimental features enabled
ID           NAME                                     TAGS                                     GADGET
b2ccc0211d20 thirsty_booth                                                                     trace_open
ea64efa71aa4 lucid_wing                                                                        trace_exec
$ ./gadgetctl delete ea

This PR
In this first of two PRs, support for the GadgetInstanceManager is introduced for the daemonmode of ig. Gadgets can be installed an
Future Work
The next PR will create another Store implementation that uses Kubernetes ConfigMaps to persist gadget instance information.
Later on, it should be possible to create local configuration files from a run command that then can be applied to the server. We could also think about file watchers on the server side in case of ig to be able to inject config files from other processes. The ig-k8s variant will automatically bring that support, as outside processes can also create ConfigMaps at any point in time.
Discussion Points

running a gadget server side: gadgetctl run --detach ...  (flag) or gadgetctl run-server ... (dedicated subcommand)
...

TODO

[ ] depending on the environment, gadget have to be installed on all or just one server (ig --daemon is file based without automatic replication, while ig-k8s automatically replicates configurations using the Kubernetes infrastructure)
[ ] tests
[ ] documentation

Calling InstallGadgetInstance():
flowchart LR
    gadgetctl1[gadgetctl] -->|"InstallGadgetInstance()"| gs1[gadget-service]
    store[(Store
/var/lib/ig/gadgets/)]
    subgraph Filesystem
    store
    end
    subgraph ig[ig process]
        gs1 -->|write| store
        store -->|monitor
& read| controller
        controller --> g1[gadget 1]
        controller --> g2[gadget 2]
        controller --> g3[gadget 3]
    end

My main concern is the lack of documentation for the format of the files saved in GadgetFilePath. I am not convinced using protobuf marshalling is a good idea. It makes it more complicated to prepare such files in the Helm template or rpm/deb package manager.

Happy to document the final format once we all agree on it.
Marshaling right now is done through protojson, which marshals it to JSON (not the protobuf wire format). But I agree, YAML seems to be an even better choice from the user perspective.

Marshaling right now is done through protojson, which marshals it to JSON (not the protobuf wire format). But I agree, YAML seems to be an even better choice from the user perspective.

Oh, I missed that. Then with JSON or YAML, my concern is addressed because it's possible to document how a user could use templates for this.

Thanks for the reviews!


Localize time on leaderboards

I'll have to figure out how to do this, but UTC time is confusing.  I think ASP.NET has some feature to allow me to use the player's local time instead.

If not, it's certainly possible to do it on the front end.  (Mind you, working with dates/times in Javascript is never fun...).


fix: MQTT credentials are always set

Problem
When authentication is disabled in EMQX, connection fails when username and password are defaulted to empty strings.
Description of Change

Default the MQTT credentials to undefined.
Check if username and password are truthy (non-null, defined, non-empty strings), if truthy apply username and password to MQTT options.
Check if username is truthy (non-null, defined, non-empty string), if truthy apply username to the clientId MQTT option.

Hi,
thank you for your interest and your PR.
I agree with you about passing undefined instead of empty strings for both username and password.
I'm not sure about passing username without password... that is really connected to a specific setup. Do you need it?
Let me just check that mosquito has no issues with that cause it is the 99% of uses.
Btw I cannot merge on the main... only on the dev. But wait that I check mqtt code and test mosquito before making a PR on the dev.
My best.

[2.2.2] - 2024-10-22
Added

[thermostat]: Added min_temperature_limit and max_temperature_limit converter.
[thermostat]: Added min_heat_setpoint_limit and max_heat_setpoint_limit converter.

Changed

[mqtt]: Username and password are passed like undefined unless set.
[readme]: Updated install script.
[readme]: Updated build script.
[package]: Updated dependencies.
[plugin]: Requires Matterbridge 1.6.1.

Fixed

[thermostat]: Fixed the case when instead of current_heating_setpoint the property is occupied_heating_setpoint.
[thermostat]: Fixed the case when instead of current_cooling_setpoint the property is occupied_cooling_setpoint.

Hi sorry for the late reply.
I made it differently.
If you have time to test it, would be nice.
I tested it with mosquitto and all is correct.
The tgz is in discord.
https://github.com/Luligu/matterbridge/blob/main/CHANGELOG.md#discord


Implementation as Integration instead of MQTT

Is your feature request related to a problem? Please describe.
I'm curious about the reasons to implement this as an extra service and connect it via MQTT to HA instead of implementing an integration. I assume there are good reasons, but normally i would prefer a direct integration to be able to implement services and get keep my list of add-ons as short as needed.
Describe the solution you'd like
I would like to use your code to implement a integration and contribute this. I'm curious if I overlook some issues with this idea and if there is any demand for it?

Feel free to build a direct component, but there is already something under development. Link


feat(tangle-dapp): Added Logic To Handle Ledger Signature

Summary of changes
Provide a detailed description of proposed changes.

Added logic to handle signature from Ledger on both EVM & Substrate

Proposed area of change
Put an x in the boxes that apply.

[ ] apps/bridge-dapp
[ ] apps/hubble-stats
[ ] apps/stats-dapp
[x] apps/tangle-dapp
[ ] apps/testnet-leaderboard
[ ] apps/faucet
[ ] apps/zk-explorer
[ ] libs/webb-ui-components

Reference issue to close (if applicable)
Specify any issues that can be closed from these changes (e.g. Closes #233).

Closes https://github.com/webb-tools/webb-dapp/issues/2273

How has this been tested?

How has this been tested?

I haven't tested it yet, just ask @1xstj to help me test it locally.


Revert "DBAAS-201 DBaaS Operator error handling enhancements"

This reverts commit 59a902f05e3b9757b9d21279cbf1e43c89624e35.
Description
causing https://github.com/RHEcosystemAppEng/dbaas-operator/issues/85
Verification Steps

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist (Definition of Done)

[ ] All acceptance criteria specified in JIRA or in issue number have been completed
[ ] Unit tests added that prove the fix is effective or the feature works
[ ] Documentation added for the feature
[ ] all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer

@tchughesiv Instead of reverting the whole PR, I submitted a quick fix: https://github.com/RHEcosystemAppEng/dbaas-operator/pull/88.


How is this method implemented in the code?

Are eight shape templates devised for each object class？How is shape modeling implemented in the code? Would increasing the number of shape template of each object class improve the segmentation accuracy?

Are eight shape templates devised for each object class？

Yes. The templates are constructed for each object class. Please refer to the supplementary materials for more visualizations.

How is shape modeling implemented in the code?

The implementation is in Code/Learn_mix_model_view_CA_it.py.
Please refer to L267-L306 for the construction of the shape prior. In essence, we apply a rough foreground-background binary segmentation in the feature space (L56) and compile the foreground and context probabilities across all examples within the cluster

Would increasing the number of shape template of each object class improve the segmentation accuracy?

Yes, it would be an efficiency-performance trade-off since adding more templates would improve disentanglement of varying poses, but also increase the search space at inference time


Improve admin filtering

Fix #304
Fix #298 (with fixes)

Coverage decreased (-0.3%) to 95.634% when pulling f0a5902fac341f252220c0f6c3072890ae32a4a8 on feature/improve_admin into 6bf6bdc1590431a1a0d16f4f5b7059afcc02d6cf on develop.

Coverage decreased (-0.3%) to 95.634% when pulling f0a5902fac341f252220c0f6c3072890ae32a4a8 on feature/improve_admin into 6bf6bdc1590431a1a0d16f4f5b7059afcc02d6cf on develop.

Coverage decreased (-0.3%) to 95.634% when pulling f0a5902fac341f252220c0f6c3072890ae32a4a8 on feature/improve_admin into 6bf6bdc1590431a1a0d16f4f5b7059afcc02d6cf on develop.

Coverage decreased (-0.3%) to 95.634% when pulling f0a5902fac341f252220c0f6c3072890ae32a4a8 on feature/improve_admin into 6bf6bdc1590431a1a0d16f4f5b7059afcc02d6cf on develop.

Coverage decreased (-0.3%) to 95.634% when pulling f0a5902fac341f252220c0f6c3072890ae32a4a8 on feature/improve_admin into 6bf6bdc1590431a1a0d16f4f5b7059afcc02d6cf on develop.

Current coverage is 92.09% (diff: 74.28%)

Merging #332 into develop will decrease coverage by 0.31%

@@            develop       #332   diff @@
==========================================
  Files            25         25
  Lines          1411       1443    +32
  Methods           0          0
  Messages          0          0
  Branches        176        181     +5
==========================================
+ Hits           1304       1329    +25
- Misses           57         63     +6
- Partials         50         51     +1

Powered by Codecov. Last update 6bf6bdc...f0a5902

Coverage decreased (-0.06%) to 95.9% when pulling 69c896d171d979ec053850bac18d41e18efa56a2 on feature/improve_admin into 6bf6bdc1590431a1a0d16f4f5b7059afcc02d6cf on develop.

Coverage increased (+0.06%) to 96.022% when pulling 74eeeb97306b941a410f2d0552a37edf67ef1777 on feature/improve_admin into 6bf6bdc1590431a1a0d16f4f5b7059afcc02d6cf on develop.


Public model documentation

Added documentation to rest public models. Descriptions are taken from list_topologies.yml.
Also, fixed naming for MobileNet V2 from TF

@eaidova please check input/output description

@alinaalborova please check

Jenkins please retry a build


Don't Merge! PR real time test for source branch full build

Docs Build status updates of commit 9828765:
:clock10: Full build: the average full build time is 7 min(s) 44 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 9828765:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Please put focus on the search input control when nuget.org loads

I frequently show up to nuget.org with a package name on my clipboard to paste. PLEASE set the focus to the search <input> element on the homepage so that when the page loads we can just paste (Ctrl-v) and hit Enter to get our package search results.

Makes sense. Similar to https://github.com/NuGet/NuGetGallery/issues/4458
Today the focus goes to the search bar the moment you start typing.
@joelverhagen can this be also enabled for Ctrl key (so that Ctrl+v can work) without hampering the accessibility requirements?

I see what u mean. Thing is tho ... about 99% of the time, I'm coming in with clipboard contents to paste. It's a package that I've snipped from an online source or from a project file.
The search element just needs an autofocus attribute. There shouldn't be a prob with accessibility, e.g., see: http://webaim.org/blog/future-web-accessibility-html5-input-extensions/. It wouldn't be implemented here in a way that would break or confuse a screen reader. The primary purpose of the nuget.org homepage IS to search for packages, so setting the focus on the search box makes perfect sense.
Thanks for considering this (and my mouse thanks you! :smile:)

This is a bit of a dupe of #4458, but imo that's doesn't fix the problem. :cry:

Whats the problem with autofocus? Worked quite well in the older portal.

Perhaps we can autofocus just on the front page. Would that improve the situation for you, @guardrex? By default autofocusing the search bar on all pages could be frustrating for pages that have forms.

I agree. I suspected your partial there was in use in other places; otherwise, you wouldn't have used a partial at all. I'll close and let u cats take over. Thanks for taking this into consideration.

@guardrex, mind if I leave this open? I think it's a good idea to autofocus the main page. We can use this issue to track that work. Concerning the partial view, we can add a parameter to enable/disable autofocus I think (or perhaps do it based off of page URL).

Sure.

do it based off of page URL

Can be unstable, of course, depending on how its implemented, which is why I think a lot of devs base it either on detecting the controller that fires or by, as you say, a parameter like ViewBag.IsHome. My gut feel'in: Probably most reliable (and simple) to go the parameter way.

FYI, if you are using Chrome, you can set up "Nuget package search" there like this:

Then while in address bar you just press n, then space, then paste your package name and press enter, and you'll get directly to search results page. No need to visit nuget.org home page.


CanvasRenderTask OOM

Yep, this is a thing. Probably not recycling bitmaps properly in the color picker. Meh.

Results so far look promising. This seems to have fixed it. Good work, me.


[go_router_builder] ShellRoute and ParentNavigatorKey in generated routes

Use case

There's no possibility to use go_router_builder to generate ShellRoutes.
No possibility to specify parentNavigatorKey in generated routes.

Proposal

I actually have no idea 🥲
Should be enough to add the field to the GoRouteData class.

Hi @codakkk, there's an issue tracking the implementation of ShellRoutes in go_router_builder in https://github.com/flutter/flutter/issues/111909
There's also an existing issue tracking adding parentNavigatorKey to go_router_builder being tracked in https://github.com/flutter/flutter/issues/119294.
Kindly subscribe to the issues listed above for updates.
Closing from here as duplicate.
Thank you


Update CONTRIBUTING.md

@arka9088 your contribution file have bug just resolve it or close that PR and make new one.
Form my side i tried to fix it but it won't get fix.
So just Close that and make new PR.
Will surely accept.

Raised again


[Feature Request] Add ability to specify metadata when adding customized checks & rules

When defining customized checks and rules, I cannot define metadata for checks (includes impact & messages for pass/fail) and rules (includes description, help, etc.), which can be defined when using straight from the 'axe-core' package. These messages are very helpful for debugging and would be a great help to developers.
Jest-Core's Check Interface:
interface Check {
  id: string;
  evaluate: Function | string;
  after?: Function | string;
  options?: any;
  matches?: string;
  enabled?: boolean;
}

Axe-Core's Check Interface:
interface Check {
    id: string;
    evaluate?: Function | string;
    after?: Function | string;
    options?: any;
    matches?: string;
    enabled?: boolean;
    metadata?: {
      impact?: ImpactValue;
      messages?: CheckMessages;
    };
}

Jest-Core's Rule Interface:
interface Rule {
  id: string;
  selector?: string;
  excludeHidden?: boolean;
  enabled?: boolean;
  pageLevel?: boolean;
  any?: string[];
  all?: string[];
  none?: string[];
  tags?: string[];
  matches?: string;
}

Axe-Core's Rule Interface:
interface Rule {
    id: string;
    selector?: string;
    impact?: ImpactValue;
    excludeHidden?: boolean;
    enabled?: boolean;
    pageLevel?: boolean;
    any?: string[];
    all?: string[];
    none?: string[];
    tags?: string[];
    matches?: string;
    reviewOnFail?: boolean;
    metadata?: Omit<RuleMetadata, 'ruleId'>;
}
interface RuleMetadata {
    ruleId: string;
    description: string;
    help: string;
    helpUrl: string;
    tags: string[];
    actIds?: string[];
}

Same issue here. Without the custom messaging, the output creates a less than helpful developer experience.

There are no restrictions in what you can pass to the underlying axe-core library in this package, I think your issue is one with the third-party Typescript interfaces that I do not maintain so you should find where that is and contribute there.


Support dynamic efSearch

In our use case, we need to make efSearch parameter a local parameter of the KNN query structure rather than a member of the HNSW index.

Hi @chenqi0805 do you have any suggestions how to implement such a feature in a generic fashion without attending just this specific query-time parameter?

@searchivarius Have not looked into the code architecture yet. Might do in free time. Proposals are welcome.

@chenqi0805 well, maybe let's have a discussion first. It's more a high-level arch question. One problem is that all the methods have parameters as class members. This is clearly not thread-safe, but it's not so easy to change. So, a good question is: Do we bite the bullet and pass all the parameters to the query method? The old setQueryTimeParams method should provide clearly defaults.

PS: it would have been clearly much more difficult some time ago, but now I removed nearly everything except for 2-3 methods. So maybe, not so horribly hard to do after all.

Do we bite the bullet and pass all the parameters to the query method? The old setQueryTimeParams method should provide clearly defaults.

Hi @searchivarius, I looked into the changes required to make it thread safe with respect to  query time efSearch.
Considering KNNQuery is used for algorithms other than hnsw, we can introduce HnswKNNQuery which inherits KNNQuery and we can pass in Hnsw specific parameters like efSearch. This way we can we use efSearch value from query if its present, if its absent we use the default
int efSearch = ef_;
if (//check to see if query type is HnswKNNQuery and if efsearch value is present in the query) {
efSearch = query.efsearch
}

How does this approach sound?


add favicon

Added the favicon: #68

Nice favicon! Is this going to be merged?

Sorry for the delay.
I've manually merged it for now (there were merge conflicts), thanks @math2001.


markAsRead is not marking thread as read

i tried to compare payload with facebook messenger running in a browser and payload seems to be the same except of the missing __dyn argument. can it be related?

In my experience, including __dyn makes no difference.

@actionless if you love reading minified code, feel free to log into FB, download the whole page and all JS and all, grep __dyn and figure out how it's generated. From my two past attempts, that baby's hard to figure out (though @Schmavery and I have figured out all of the other "encryption schemes" happening). As @Schmavery said, it doesn't seem to make a difference so far (let's not jinx it)

is markAsRead works for anyone here?
or it's something in my setup

@Schmavery does it works in your js implementation btw?

@actionless Did you also run "MarkAsSeen"? I'm not 100% sure on what the difference is, but there is one...

just for better understand, the test code:
client = fbchat.Client(FACEBOOK_ID, FACEBOOK_PASSWORD)
unread = client.getUnread()
user_ids = unread['unseen_threads'][0]['other_user_fbids']
if not user_ids:
    print("== No new messages")
    import sys
    sys.exit()

for user_id in user_ids:
    print("{}:".format(user_id))
    messages = client.getThreadInfo(user_id, 0)
    for message in messages:
        if message.is_unread:
            print((message.subject, message.body))
            client.markAsDelivered(user_id, message.message_id)
    client.markAsRead(user_id)
client.markAsSeen()

test case to reproduce the issue:

send a message to facebook account
execute that code snippet, it should print the new message
send one more message
execute code snippet once again

expected result:
only the latest message was printed to the console
actual result:
both message from pt.1 and 3 are displayed (message.is_unread remains True)
but after opening in the browser and running code snippet once again those messages are marked as read so not displayed

so can anyone confirm the issue?

@actionless hey, looking at our implementation (from which this is based on), this is what we do. I difference is the form sent to change_read_status.php contains a list of threadIDs instead of userIDs. Try calling it with a threadID and see what happens.

unfortunately it's still behave the same

in order to work markAsRead, please fix
" data["ids[%s]"%userID] = True " => " data["ids[%s]"%userID] = 'true' "
this value mast be in lowercase.

@override
class Client(fbchat.Client):
def markAsRead(self, userID):
data = {["ids[%s]" % userID]: 'true'}
r = self._post(fbchat.client.ReadStatusURL, data)
return r.ok

@thnkloud9 if you are still working on the project, see above

Assuming this has been fixed


Discover how to test client/server compatibility

The goal of this task is to have a clear path to design a testing mechanism for Scala client version X lakeFS server version after exploring different alternatives.

@itaiad200 we can close this one right?

Yap, it's a dup


Do you have an example on how to control the volume of an HTML5 Audio Element?

I would like to use it for both, the web and a phonegap ambient sound player
Thanks

I don't have an example doin this but it's definitely possible.
You only need to dynamically set the max attribute based on the duration and update the value based on the player state.

Not all that hard: https://jsfiddle.net/n3ch6dmo/19/
Scraping the audio example from MDN, with a few tweaks:
Markup:

  30 second sample from "Another Day in Paradise", by Phil Collins, from the Collins album, "...But Seriously".

  <audio id="t-rex-roar" controls volume="0.1">
<source type="audio/ogg" src="https://upload.wikimedia.org/wikipedia/en/9/9f/Sample_of_%22Another_Day_in_Paradise%22.ogg" />
        Your browser does not support the audio element.
    </audio>

<input type="range" min="0" max="1.0" step="0.01" value="0.5" id="volume-slider" />

JavaScript:
$('#volume-slider').rangeslider({ polyfill: false });

$('#volume-slider').on('change', function(e) {
  var volume = $(this).val();
  $('#t-rex-roar')[0].volume = volume;
})

All you need to do is read the current value of the range input, and then set the volume value appropriately. This is just reading the range value, so it's not really specific to rangeslider.js.

AWESOME PROJECT!!! I loaded it into an EXPO app and it works BEAUTIFULLY on Android Motorola Cellphone (KUDOS for THAT!!!) ... Now... On my iPhone 8, I hear the song (which I change to an MP3 filepath), but it does NOT affect the volume when sliding the RangeSlider tab/bar.
Any ideas on how to make it work.... This would be the equivalent to WEBVIEW....
I hope you guys can help tackle this issue!

If I recall correctly, iOS/Safari has some tighter restrictions with how they allow you to interact with media. You might not be able to change the volume on an iPhone.
I have no idea what has changed since it was published, but this seems to confirm what I was suspecting: https://www.ibm.com/developerworks/library/wa-ioshtml5/


loading time of ultrasound multiframe instance[Bug]

Describe the Bug
OHIF takes a long time to load an ultrasound multiframe instance
Steps to Reproduce
see https://discourse.orthanc-server.org/t/loading-time-of-the-ultrasound-sequence-file/4714 for steps to reproduce
The current behavior
Alain Mazy from Orthanc project mentioned: "each viewer loads data differently: StoneViewer frame by frame while OHIF loads the entire instance in one go".
The expected behavior
Would it be possible to make OHIF data loading a configuration option, e.g. frame by frame loading for multiframe instances? entire instance for single frame instances?
OS
Windows 11
Node version
16.x
Browser
Chrome 125.x

We load frame by frame for each instance, if you look at this study
https://viewer-dev.ohif.org/viewer?StudyInstanceUIDs=1.2.276.0.7230<IP_ADDRESS>.2723277605.10168.1676054414.178
and open network panel
and double click on different series

you will see above which is requesting each instance separately for wadors.
Wadouri is another topic


[TextServer GDExtension] Update build scripts and .gdextension files to use new target names and arch suffixes.

Fixes TextServer GDExtension build after the recent build system changes.

Thanks!


fix: reduce grounding for repeat_channel

by leveraging asymmetry.
I did try using --text and saw the difference between "!=" and ">".
Is there a way to check groundings within the tests?
I tried to search it in clingo python API, but couldn't find how to do it.

not sure why this pr contains old commits :sweat:

Great. What's the difference in number of lines in the grounded program?

85 lines.


Can't reopen pullrequest if associated branch was previously deleted

Describe the bug
Updatecli tries to always reuse the same temporary branch name.
Since version 0.15.0,updatecli try to reopen closed pull request.
If we manually closed a pullrequest and delete the associated branch then the github API returns an error
Steps to Reproduce

Run updatecli
Closed the newly generated pullrequest
Delete the associated branch
Re-run the same updatecli pipeline

Expected behavior
It should open a new pullrequest
Screenshots

Version

OS: linux
Updatecli version: 0.16.0

Additional context

Not sure of the status of this issue => no milestone target for now.
@olblak I'm challenging the label as "bug". For me that would be an enhancement as the current behavior is wanted: do you agree?

As far as I remember, we fixed this issue as we don't try anymore to reopen an old pull request. Instead we open a new one.

Oh good point. Let's close the issue then (we would reopen if we reproduce).


added language learning assistant

Fixes  #997
Description
Features of the Script:
Interactive Conversation Practice: The script allows users to engage in interactive conversations with the language learning assistant. It prompts questions and provides responses, enabling users to practice real-life conversational scenarios.
Vocabulary Quizzes: The language learning assistant offers vocabulary quizzes with a wide range of words and their meanings. Users can test their knowledge and expand their vocabulary in the target language.
Grammar Exercises: The script includes grammar exercises that cover various language rules and structures. Users can reinforce their understanding of grammar concepts through these exercises.
Pronunciation Error Detection: The language learning assistant can detect pronunciation errors made by users and provide feedback to help them improve their pronunciation skills.
The script's design promotes consistent learning and encourages users to immerse themselves in the language, thereby facilitating a more effective language learning process. It is intended to be a useful resource for self-study, making language learning enjoyable and accessible for learners of all levels.

Please review my pull request @Niketkumardheeryan

@samarsajad you have used only 1 cell for code and rest of cells filled with data that can be moved to other files and have error in last cell, Expecting better code ,more readable and improved


yolov5 result is better

Which type of YoloV5 are you using (tiny, small)? And which version?
nihui as used version 3.1 of ultralytics YoloV5.
Recently version 7.0 has been released. I'm planning to write the interface for ncnn as the topology is quite different.


[storage-service] hookup service-side with DiemNet interface

[storage-service] DbReaderWriter -> DbReader

The storage service is only expected to make read-only calls to DiemDB; using a DbReader also allows us to avoid an unnecessary RwLock around the DiemDB handle.

[bounded-executor] add spawn_blocking and try_spawn_blocking
[storage-service] hookup service-side with DiemNet interface
[storage-service] add storage service handler concurrency

:broken_heart: Test Failed - ci-test

/land


git2 OpenSSL breaking our Docker builds.

I'd wondered why our Docker build for 3.3.2 failed when 3.3.1 didn't. It turns out when we began to transition our Git interactions from using the Git CLI to using the git2 crate (a wrapper around the C libgit2), we accidentally brought back OpenSSL. In Alpine Linux, which we use in our Docker images, OpenSSL is not part of the system by default, but must be installed using apk. However, we'd previously opted to move from OpenSSL to Rustls, which introduces a challenge for us. We could either:

Set a feature flag on the git2 crate to use their vendored copy of OpenSSL, meaning we always have it at compile time.
Add an apk command to the Docker file to install it during Docker builds.
Avoid using git2, perhaps in favor of gitoxide, which appears to offer the option of using rustls.

I'm personally inclined to try to avoid having both OpenSSL and Rustls in our program, which means my preference is to try to pick one. Someone ought to explore the option space here and report back.

Thinking more, I am inclined to revert to using the Git CLI exclusively as our interface to Git, and to add a CI job that rejects PRs if the "openssl-sys" crate appears in Cargo.lock.

Fixed by #177


HOSTEDCP-1314: Ensure all e2e HCs use NLB for ingress controller

What this PR does / why we need it: Adds check to validate that e2e HCs use NLB for ingress controller
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #  HOSTEDCP-1314
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/test all

/retest-required

/retest

/retest-required

/retest-required

/retest

/retest-required

/retest-required

/test e2e-aws

/test e2e-aws


Add workflow to publish module for scubagear to test package repository

🗣 Description
Focus is on creating a private package repository to publish a catalog signed ScubaGear module for a nightly build.
💭 Motivation and context
A nighly build/test of the ScubaGear module will help uncover any issues early that might impact an official production publish to PowerShell Gallery.
closes #672
closes #674
closes #675
closes #676
🧪 Testing
The github workflow, run_publish_package, create a repo, build the module (i.e., update manifest, sign), publishes to repo, runs test on "Find-Module", installs/imports module from repo and test with simple "Invoke-Scuba -Version"
NOTE: AT this time the published module is not expected to be able to test actual products.  #677 refactors ScubaGear to work when installed as a module.
📷 Screenshots (if appropriate)

✅ Pre-approval checklist

[X] This PR has an informative and human-readable title.
[X] Changes are limited to a single goal - eschew scope creep!
[X] All future TODOs are captured in issues, which are referenced
in code comments.
[X] All relevant type-of-change labels have been added.
[X] I have read the CONTRIBUTING document.
[X] These code changes follow cisagov code standards.
[X] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[X] Tests have been added and/or modified to cover the changes in this PR.
[X] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

I would prefer to see a description for internal helpful functions (like 'Build-ScubaModule') in DeployUtils.ps1, just as there are descriptions for the public facing functions (like 'New-PrivateGallery'). Whenever someone else takes over this code, simple comments like this will be helpful to them.

@nanda-katikaneni Are you able to review this in near future or should I find an alternative?

@nanda-katikaneni  Ready for merge to Flipper.


Why use lodash instead of ImmutableJS

Seems like immutable is going to be the standard for React applications since those structures work best. I don't like including another giant library (lodash) that isn't needed just for drag&drop

If you look closely, lodash as a whole is not used in React DnD. Only a few individual functions are imported as separate modules. As far as I know, ImmutableJS as a whole is larger than those individual modules from lodash I am using.

Ok, thanks for the feedback, I appreciate your codes! :)


Update notifications?

Should the Plugin show an Update notification if a newer version is released?
Maybe this should be a feature of the Touch Portal SDK?

Seems to be in the backlog...
From the discord:
spdermn02 — 02/05/2021
I think a notification process is on the dev backlog.
And part of that was for plugin related updates I believe.


Determine if HUC 19030103 should be removed from HUC-8s

The following API endpoints do not return data for HUC 19030103:

Temperature
Precipitation
Permafrost
Relative Flammability (ALFRESCO)
Relative Vegetation Change (ALFRESCO)

This may be related to the fact that HUC 19030103 spans the antimeridian. If there is not an easy fix for this, we should remove HUC 19030103 from this repo.

In my opinion this "Western Aleutian Islands" HUC is not a useful "data cookie cutter" for our purposes. My preference would be to remove the HUC from our records. For the Aleutians in general point queries will be most representative vs. summarizing cross multiple different islands.


Pinecone service fails to start

Background:
I don't think the pinecone service can start as scripted in the CI tests.
I had to revert some simple changes in a PR because pinecone could not pass CI. (https://github.com/opea-project/GenAIComps/pull/762/commits/ba2bf103bb7fc6f1b59f7dee5adb49d0aa113919)
I think @lvliang-intel may have also reverted valid changes recently because of the same CI failure (but I'm not certain).
( https://github.com/opea-project/GenAIComps/pull/763/commits/d5533a8374e3189bb19a2ce4bd6287657666b41d )
Simple Reproducer
See: https://github.com/opea-project/GenAIComps/pull/810
The only change is setting a timeout in the test from 2m to 120s. This just forces CI to run this test.
The service fails to start:
https://github.com/opea-project/GenAIComps/blob/main/tests/retrievers/test_retrievers_pinecone_langchain.sh#L36
    docker run -d --name="test-comps-retriever-pinecone-server" -p ${retriever_port}:7000 --ipc=host -e HUGGINGFACEHUB_API_TOKEN=${HUGGINGFACEHUB_API_TOKEN} -e TEI_EMBEDDING_ENDPOINT=$TEI_EMBEDDING_ENDPOINT -e http_proxy=$http_proxy -e https_proxy=$https_proxy -e PINECONE_API_KEY=$PINECONE_API_KEY -e PINECONE_INDEX_NAME=$PINECONE_INDEX_NAME -e INDEX_NAME=$PINECONE_INDEX_NAME opea/retriever-pinecone:comps
https://github.com/opea-project/GenAIComps/blob/main/comps/retrievers/pinecone/langchain/retriever_pinecone.py#L92
vector_db = PineconeVectorStore(embedding=embeddings, index_name=PINECONE_INDEX_NAME)
Stack trace:
https://github.com/opea-project/GenAIComps/actions/runs/11446117010/job/31844626243?pr=810#step:4:942
More Convoluted Reproducer
This reproducer https://github.com/opea-project/GenAIComps/pull/767 replaces a deprecated API and updates the test with a better timeout mechanism.
Fails in the same place as above:
https://github.com/opea-project/GenAIComps/actions/runs/11444738367/job/31840299594?pr=767#step:4:879
https://github.com/opea-project/GenAIComps/blob/main/comps/retrievers/pinecone/langchain/retriever_pinecone.py#L92
vector_db = PineconeVectorStore(embedding=embeddings, index_name=PINECONE_INDEX_NAME)
Stack trace:
https://github.com/opea-project/GenAIComps/actions/runs/11444738367/job/31840299594?pr=767#step:4:917

It's fixed by PR #816


[eBPF] The eBPF socket data transmission size is configurable(#1398)

We divide the data processing and data output into two parts, and each has a different eBPF program for processing. The purpose of this is to prevent the problem of the number of instructions exceeding max limit.
Provide an interface set_data_limit_max(int limit_size), Set maximum amount of data passed to the agent by eBPF programe. If @limit_size exceeds 8192,it will automatically adjust to 8192 bytes.
This PR is for:

Agent

Affected branches

main

6.1.6 发布之后再 merge


Added summary stats for vnode queue length.

Adds summary statistics on vnodes running and their queue lengths for each application registered with riak_core.

+1 to merge


Can't run the example in my project. Babel problem

I just created the example and moved it to my project.
When i start, it throws error
`Error in multi admin
Module not found: Error cannot resolve module 'stack-source-map/register'

Module build failed: Error Cound't find preset "stage-2" relative to directory <my project path>`

Please help me.
Anyway, your project is so cool =D I really want to try to apply to my project soon. Love your concept and idea :+1:

Use NPM3. See: https://github.com/kadirahq/react-storybook/blob/master/docs/known_issues.md#potential-issues-with-npm-2

Please reopen if that's solve your issue.


Label item movement controls?

The < > etc arrows aren't immediately obvious. On the assumption that people would see the label when they need it (e.g. when they want to move a zoomed-in item around to access off-screen areas of it), a label might be one way to make the existence of the functionality clear.

I was actually thinking of arranging them into a more obvious layout, Project Mirador style

There is also a help modal where people can check what the controls mean.

This issue was moved to LibCrowds/libcrowds-viewer#106


Script editor: View jumps to the last line on opening

Godot version: 331a703f5
Issue description: Open a script, the caret and view go to the very last line. Scripts should open at the top.

Looks like duplicate of #29858

@KoBeWi How did you fix this? I still get the same behavior when changing "Scroll Past End Of File".


for IDE auto-complete with global Wrapper

R, D, Cal, Inst, FeatureD, ExpressionD, DatasetD, D

Description

qlib/data/data.py
import sys

if sys.version_info >= (3, 9):
    from typing import Annotated

    CalendarProviderWrapper = Annotated[CalendarProvider, Wrapper]
    InstrumentProviderWrapper = Annotated[InstrumentProvider, Wrapper]
    FeatureProviderWrapper = Annotated[FeatureProvider, Wrapper]
    ExpressionProviderWrapper = Annotated[ExpressionProvider, Wrapper]
    DatasetProviderWrapper = Annotated[DatasetProvider, Wrapper]
    BaseProviderWrapper = Annotated[BaseProvider, Wrapper]
else:
    CalendarProviderWrapper = CalendarProvider
    InstrumentProviderWrapper = InstrumentProvider
    FeatureProviderWrapper = FeatureProvider
    ExpressionProviderWrapper = ExpressionProvider
    DatasetProviderWrapper = DatasetProvider
    BaseProviderWrapper = BaseProvider

Cal: CalendarProviderWrapper = Wrapper()
Inst: InstrumentProviderWrapper = Wrapper()
FeatureD: FeatureProviderWrapper = Wrapper()
ExpressionD: ExpressionProviderWrapper = Wrapper()
DatasetD: DatasetProviderWrapper = Wrapper()
D: BaseProviderWrapper = Wrapper()

qlib/workflow/init.py
import sys

if sys.version_info >= (3, 9):
    from typing import Annotated

    QlibRecorderWrapper = Annotated[QlibRecorder, Wrapper]
else:
    QlibRecorderWrapper = QlibRecorder

# global record
R: QlibRecorderWrapper = Wrapper()

Motivation and Context

How Has This Been Tested?

[ ] Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
[ ] If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

Pipeline test:
Your own tests:

Types of changes

[ ] Fix bugs
[x] Add new feature
[ ] Update documentation

@GoooIce
I looks great. You are realy solving a issue that haunts me for a long time.
Thanks.

@GoooIce
I looks great. You are realy solving a issue that haunts me for a long time.
Thanks.


Make change to well known names for SRDS stats

Commit Message: Add new tag extractor for Srds Stats
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

/assign @adisuissa

/retest

Assigning @ggreenway for !Google senior-maintainer review.
/assign @ggreenway

/retest


updated README.md with link to LICENSE.md

This is initiated from https://github.com/lunchclass/absolute/pull/399.


filter pbsv calls

Hi,
I was using the default settings of pbsv for SV detection. In the VCF file, can I use the number in "AD" to filter the calls? If it is possible, which number in "AD" (there are two numbers) support the ALT allele?
Thanks!

We follow VCF standard: https://gatkforums.broadinstitute.org/gatk/discussion/1268/what-is-a-vcf-and-how-should-i-interpret-it


Reactivity breaks math.gl vector prototype methods

Version
2.6.10
Reproduction link
https://codesandbox.io/s/o1l2jk2j05?fontsize=14
Steps to reproduce

Go to https://codesandbox.io/s/o1l2jk2j05?fontsize=14
Press the button
You'll see and error that shouldn't have happened (the logs will show that the Vector3 instance doesn't have an 'add' method anymore. Even though new instances of Vector3 have them.

What is expected?
VueJS reactivity should be transparent
What is actually happening?
VueJS reactivity is not transparent, since it hides/removes methods of instances of classes of math.gl

I don't know if this is documented behavior, but I didn't see it here: https://vuejs.org/v2/guide/reactivity.html

you cannot use an arrow function for data

Please, next time consider using the forum, the Discord server or StackOverflow for questions first. But feel free to come back and open an issue if it turns out to be a bug 🙂

The problem happens if you use a regular function too: https://codesandbox.io/s/1zqwqmk2nj
The original issue happened without using a component with a plain object assigned to data.
I suspect that this issue happens due to the way math.gl builds Vector3 like an array.
I'm new to Vue, but I still think this is a bug.

Vue is currently hijacking the __proto__ of Array instances to the patched version: https://github.com/vuejs/vue/blob/1137e415c9e8701d1b0a25e5812f8c4dffeeeaaa/src/core/observer/index.js#L87-L91
So Vue's reactivity system can only work reliably with native Arrays. MATH.GL's Vector3 extends the native Array with custom methods so even Vue keeps those methods (eg. target.__proto__ = Object.create(target.__proto__, src)), the reactivity system won't work because Vue cannot patch those methods it's not aware of.