Team 01 VnV Plan Review: Missing Traceability Matrices

Marking TA: @CSchank
Your VnV Plan appears to be missing the traceability matrices in Section 4.3:

Having the traceability matrices are very important for development and testing and help to visually show that you're actually verifying and validating all your requirements. Ideally, the matrix should visually show that for all your requirements that are in scope, you should have some sort of test that meets those criteria for both FR and NFR. It would help both your team ensure that requirements are met but could also be proof for stakeholders as well that testing is complete.

Hi, it seems like there is a mistake of the Vnv we uploaded when copying over from Overleaf, it seems we copied the wrong version.
We are trying to fix it right now! The NFRs and Traceability Matrix will be up soon! Sorry for the inconvenience!


Fixed a require bug in graphlib.js

Fixed bug Uncaught TypeError: Cannot read property 'preorder' of undefined.

This would be a great fix, to avoid having to patch dagre in node_modules.

Is there an issue providing some context and repro steps?

Essentially we've a project compiling Typescript with Webpack + Babel, and without the /index it errors on the require statement.
@ctcarton Do you have any additional details that might help give more context?

After some investigation I've found that the module redirection that dagre is using here is confusing webpack. The simple solution I've found is to update webpack.config.js with a resolve alias which forces always using the version of graphlib in node_modules.
In module.exports in webpack.config.js:
    resolve: {
        alias: {
            "graphlib": "node_modules/graphlib"
        },
    }


UI doesn't consider "Local Sign-In" when disabled for certain features

Description
Some features in the UI do not consider the "Local Sign-In" settings when it is disabled.

In the user list, the "Create Local User" button is shown when setting is disabled.

We should hide the button when the setting is disabled

In the user profile settings (/users/:userId/settings), the email is required. This was added in #803 but does not check the setting.

The email should not be required when the setting is disabled

The Password tab in the user profile settings (/users/:userId/settings) is shown. The password in that tab is the password for "Local users".

We should hide the tab when the setting is disabled

Version
1.9.2
Steps to Reproduce

Go to the Jellyseerr setting page in the users tab (/settings/users)
Disable the "Local Sign-In" setting and save your changes
View the issues described in the description section above behave like the setting is still enabled

Screenshots
No response
Logs
No response
Platform
desktop
Device
all
Operating System
all
Browser
all
Additional Context
No response
Code of Conduct

[X] I agree to follow Jellyseerr's Code of Conduct

Whether you disable local sign in or not, every account is both. Every jellyfin user also is a local account. It's linked

Email will be required. We will remove the validation so Email can be jellyfin username/email (it was supposed to be this way but accidental)

Refer back to 1. Every user is still a local user  (it's all interlinked) which is why we don't hide these settings

Should be fixed by #900


Platform-independent process exit reasons

Some programs need to determine how another process terminated. For example, crystal run does this after running the temporary executable:
https://github.com/crystal-lang/crystal/blob/994c70b10e9939d73b561135b0822dea4f9979bb/src/compiler/crystal/command.cr#L277-L295
status is a Process::Status. On Unix-like systems, if status.signal_exit? && status.exit_signal.segv?, then the process exited because of a segmentation fault. Windows executables do not communicate POSIX signals through the exit status, so that wouldn't work there. Nonetheless, we can still detect segmentation faults on Windows as follows:
lib LibC
  # these constants are defined in `errhandlingapi.cr` but
  # they should actually be from `minwinbase.cr`
  EXCEPTION_ACCESS_VIOLATION = 0xC0000005_u32
  EXCEPTION_STACK_OVERFLOW   = 0xC00000FD_u32
end

status.exit_status.in?(LibC::EXCEPTION_ACCESS_VIOLATION, LibC::EXCEPTION_STACK_OVERFLOW)

(Minor note: this won't work on Crystal programs at the moment, because currently the crash handler does not preserve those exit statuses.)
Neither exit_status nor exit_signal is platform-independent, so we would like some abstraction that uses the former on Windows, but the latter on Unix-like systems. Additionally, segmentation faults are not the only way a process could terminate, and there are other mutually exclusive reasons that could all be determined from the exit status. This calls for an enum:
enum Process::ExitReason
  Normal
  Aborted
  Interrupted
  AccessViolation
  BadMemoryAccess
  BadInstruction
  PosixSignal # any reasons not covered above; unused on windows
  Unknown

  def abnormal?
    !normal? && !unknown?
  end
end

And this enum is returned from a new method, Process::Status#exit_reason:
{% if flag?(:win32) %}
  lib LibC
    # minwinbase.cr
    EXCEPTION_DATATYPE_MISALIGNMENT = 0x80000002_u32
    EXCEPTION_ILLEGAL_INSTRUCTION   = 0xC000001D_u32
    EXCEPTION_PRIV_INSTRUCTION      = 0xC0000096_u32
    CONTROL_C_EXIT                  = 0xC000013A_u32

    # winnt.cr
    STATUS_DATATYPE_MISALIGNMENT_ERROR = 0xC00002C5_u32
  end
{% end %}

struct Process::Status
  def exit_reason : ExitReason
    {% if flag?(:win32) %}
      case @exit_status
      when LibC::STATUS_FATAL_APP_EXIT
        ExitReason::Aborted
      when LibC::CONTROL_C_EXIT
        ExitReason::Interrupted
      when LibC::EXCEPTION_ACCESS_VIOLATION, LibC::EXCEPTION_STACK_OVERFLOW
        ExitReason::AccessViolation
      when LibC::EXCEPTION_DATATYPE_MISALIGNMENT, LibC::STATUS_DATATYPE_MISALIGNMENT_ERROR
        ExitReason::BadMemoryAccess
      when LibC::EXCEPTION_ILLEGAL_INSTRUCTION, LibC::EXCEPTION_PRIV_INSTRUCTION
        ExitReason::BadInstruction
      else
        @exit_status.bits_set?(0x40000000_u32) ? ExitReason::Aborted : ExitReason::Normal
      end
    {% else %}
      if normal_exit?
        ExitReason::Normal
      elsif signal_exit?
        case exit_signal
        when .abrt?, .hup?, .kill?, .quit?, .term?
          ExitReason::Aborted
        when .int?
          ExitReason::Interrupted
        when .segv?
          ExitReason::AccessViolation
        when .bus?
          ExitReason::BadMemoryAccess
        when .ill?
          ExitReason::BadInstruction
        else
          ExitReason::PosixSignal
        end
      else
        ExitReason::Unknown
      end
    {% end %}
  end
end

I would like to reach consensus on ExitReason and #exit_reason before moving on with a PR, because there might be subtle differences between the different POSIX signals that default to process termination.
See also #7339, #8381, and #9064.

#13052 defines ExitReason::Breakpoint and ExitReason::FloatException additional to the ones mentioned here.
I suppose it makes sense to have them and they seem to be clearly defined on all platforms.


drivers/can/mcp2515.c Fix Configure Spi Bus on every bus lock

Summary
Impact
Testing

Thank you @paolovolpi


show error message when server is not reachable on system start

Should I just show genoetet.error or block the front-end?

Yes please block the front-end on server down.

Done.


getUserMedia error DOMException: Requested device not found In face AR

Not working your Live Demo too How to Fix it...

Do you have a webcam connected?

yes have it and its mac inbuild  face camera ....


Measure-ParamBlock - New Check

Added check for param block.
This Pull Request (PR) fixes the following issues
Fixes #13

This change is

@johlju, next one.


Travis integration

Create .travis.yml and test travis builds.
https://docs.travis-ci.com/user/languages/go/

Basic travis.ci integration works. What we need is to build to all platforms + run all the tests as part of the build process.

Tests run on Travis but fail while locally running tests passes.
See: https://travis-ci.org/spacemeshos/go-spacemesh/builds/322268242?utm_source=email&utm_medium=notification


Remove console.log of geoPackageConnection

Is there any possibility to parameterize the console.log option of these lines so that it does not appear?
https://github.com/ngageoint/geopackage-js/blob/bfabe794f1dd6dbeac9d23def0051d5a35d00d34/lib/db/geoPackageConnection.ts#L10,L14
if (typeof process !== 'undefined' && process.version && !process.env.FORCE_SQLJS) {
  console.log('Better SQLite');
} else {
  console.log('SQL.js');
}

If it is not developed, I could do it and do a PR.
Something like options.silent in constructor of GeoPackageConnection.

Pull requests are welcome.


Self-referential fields for Collection

Closes https://github.com/hinto-janai/festival/issues/3.
This will either be implemented with raw pointers or by wrapping everything in Arc.
A & with a lifetime would be ideal but only if it were possible without unsafe.

Continued in https://github.com/hinto-janai/festival/pull/39.


Limit installation to fosslight_util 1.4.*

Description

Limit the installation of FOSSLight Util to 1.4.* and above, with a minimum of 1.4.27.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[x] Refactoring, Maintenance
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

@dd-jy , 보시고 이상 없으면 Merge 부탁드립니다.


Task - comprehensive specimen - Radial annotator

Missing radial annotator (sometimes I need to add alternative identifier).

Exists aready, just save the record.


PDF sharing failed.

[Tested on Android latest prod app version 1.3.1(164)]

An error was found "PDF Sharing Failed" while PDF was shared by sending an email.
-But immediately I tried the same option and it worked at that time.

-After that I uninstalled the app and again dowloaded it, now this time getting this "PDF sharing failed" error on all 3 options.

2.Print copy option is not working.
3.When we share the second personal copy after sending the first personal copy, the PDF is not being attached.

-Verified this issue on dev app version 1.3.2(168)


cmedb.py - export shares

Hello there,
cmedb.py is currently missing a share export function, here's one I did, and to insert here https://github.com/Porchetta-Industries/CrackMapExec/blob/44ec821fff6516a43560290fb4256d2d91b7da84/cme/cmedb.py#L84
          import csv
          elif line[0].lower() == 'shares':
            if len(line) < 2:
                print("[-] invalid arguments, export shares <filename>")
                return

            shares = self.db.get_shares()

            with open(os.path.expanduser(line[1]), 'w') as export_file:
                spamwriter = csv.writer(export_file, delimiter=";", quoting=csv.QUOTE_ALL, lineterminator='\n')
                csv_header = ["host_ipaddress", "host_domain", "host_hostname", "share_name", "share_remark", "domain_username", "share_readaccess", "share_writeaccess"]
                spamwriter.writerow(csv_header)

                for share in shares:
                    share_id, share_hostid, share_userid, share_name, share_remark, share_readaccess, share_writeaccess = share

                    share_writeaccess = "True" if share_writeaccess == 1 else "False"
                    share_readaccess = "True" if share_readaccess == 1 else "False"

                    user_id, user_domain, user_username, user_password, user_credtype, user_pillaged = self.db.get_users(share_userid)[0]
                    user_domain_username = '%s\%s' % (user_domain, user_username)

                    hostid,host_ipaddress,host_hostname,host_domain,host_opsys,host_dc = self.db.get_computers(share_hostid)[0]

                    csv_row = [host_ipaddress, host_domain, host_hostname, share_name, share_remark, user_domain_username, share_readaccess, share_writeaccess]
                    spamwriter.writerow(csv_row)

So you can now do export shares <filename>
Cheers !

Hello, can you make a PR ?

#638


Crawling websites using https through a proxy

We are using Crawljax through a proxy to gather some additional information. The website we are crawling uses https. The result is an certificate error in the browser. With the current state of Crawljax it would not be possible to crawl this site.
One solution is to add the command line argument "--ignore-ssl-errors=true" to the PhantomJS call and respective options for the other browsers. We are aware of the implications regarding the security and therefore wouldn't mind a switch to turn this option on and off. The version we are using at the moment has this option hardcoded to the command line arguments.

Use a proxy that generates a certificate and add it to your local trust store. Fiddler allows you to MITM HTTPS traffic via this method.


fixed target table in eventupdate (for issue #3)

for issue #3
under testing at landfill.

somehow related on this, 'cancelled' or 'canceled'?

todo: change search condition from 'canceled' to 'cancel', for matching with both


Use README.md instead of script.md

For the directory structure, instead of reading the script from script.md, if simdem used README.md, then the Github repo becomes a bit more self-documenting.
This is minor, but would make it so that if someone views the directory, then the README.md is rendered.

This is a good suggestion,
The "script.md" is a pointer to the original roots of this project which was about automating demo scripts (it's script as in you say this, you do that) as opposed to executable program scripts. README.md is more natural and I've been thinking of changing this for some time.
Of course we would need to ensure it's backward compatible - that is support both script.md and README.md.


Add support for variables

Users should be able to:

Declare variables
Assign values to variables

Supported types should be:

integers
booleans

Keyword:

var
Int
Bool

Support for non-array variables is now complete in the interpreter.


Create documentation for Objects

https://readthedocs.org/projects/objects/

Need to add following sections:

Installation
Examples
Issues and bug tracking


Revert "Backwards compatibility fixes"

Reverts Arduboy/Arduboy#126
This has not been properly discussed and all the implications thought thru.  @bateske once said I was in charge of the library... and while I'm not sure if he was joking or not obviously I've been given commit bits and I'm a core contributor.  If we are going to have a few people with such status then we do not just ignore their "Please Hold" tags or that an issue is still undergoing significant discussion.
That is disrespectful and makes me no longer want to be involved.  It was tagged for a reason.
Reverting this patch.

I have taken the master branch (before the rivert of the 105 stuff) and pushed it onto the "codebender" branch here.  Future codebender compatibility patches (and updates to keep the library current) should be pull-requests against that branch.

This is why github has branches.  Master is forever and does NOT need to be polluted with things that are still being actively developed and esp when a lot of contributors have concerns.


Trigger next fails

Hello,
In my code I try to trigger to the next step if an element is not visible, the trigger next executes and goes to the next element for less then one second, then it goes back to the previous element (which I wanted to skip).
Why is this happing?
Code:
HelpTour:function() {
        page.tour =new EnjoyHint( { } );
        page.tour.set([ {
            "next .area-card": 'Hello, In this short tour guide I\'ll show you
some features/components included in Altair Admin.
This is the main header.
Click "Next" to proceed.'
        }
        , {
            "click .btn-list": "Here you can activate fullscreen.", showSkip: !1
        }
        , {
            "click .open-valve": "Click this icon to show search form.", showSkip: !1,  timeout: 500
        }
        , {
            "next .valve-general": "This is the main search form.", showSkip: !1,  timeout: 1000
        }
		, {
            "next .valve-alarms": "This is the main search form.", showSkip: !1
        }
		, {
            "next .time-range-selector": "This is the main search form.", showSkip: !1
        }
		, {
            "next #valve-default-area": "This is the main search form.", showSkip: !1,
			onBeforeStart:function() {
				if ($('#valve-default-area').is(":hidden")) {
					page.tour.trigger('next');
				}
			}
        }
		, {
            "next #valve-vac-area": "This is the main search form.", showSkip: !1,
			onBeforeStart:function() {
				if($('#valve-vac-area').is(":hidden")) {
					page.tour.trigger('next');
				}
			}
        }
		, {
            "next #valve-aai-area": "This is the main search form.", showSkip: !1,
			onBeforeStart:function() {
				if ($('#valve-aai-area').is(":hidden")) {
					page.tour.trigger('next');
				}
			}
        }

        ]),
        page.tour.run();

    }

Triggering next during the onBeforeStart is essentially a race condition because the current step is still starting.  The best solution is to simply check while initializing the step list and don't add those steps if they won't be relevant.  Alternatively if you don't know if those elements will exist on tour initialization you should be able to set the onNext function to do your check and trigger next (it looks like this should get rid of one race condition, can't guaranty all).  You can get your current selector to search for by using var selector = tourSteps[tourInstance.getCurrentStep()].selector;.  Alternatively if all else fails a somewhat hacky solution would be to run your page.tour.trigger inside of a half second delay.

Hi everyone,
My steps are more complex so I really need trigger('next') method works correctly like what that RoelDeveloper mentioned. Is there anyone who solved that problem?


Disambiguating names

If you have an executable called "foo" and a testsuite called "foo", then "foo:name" currently refers to the executable and there is no way to get the name of the testsuite.
Best way to solve this is probably to add another optional prefix, so you can say (eg) "executable:foo:name" and "testsuite:foo:name".

Non-issue, names of sections must be unique as per https://www.haskell.org/cabal/users-guide/developing-packages.html


isPlaying

At the moment "isPlaying" is emulated by the widget. So it only works when using the widget API. It should be rewritten, to use the provider API or its Events


Overview Card > change VM name validation and set cloud-init hostname change

In the legacy VM edit page, changing a VM's name also includes a valid name check and updates cloud-init hostname depending on how it is set in the VM's template:
https://github.com/oVirt/ovirt-web-ui/blob/aff035eff23496834d34a7402497212459f86458/src/components/VmDialog/index.js#L241-L258
The current VM Details Overview card will change the VM name, but does not include the name check and does not update the cloud-init hostname.  I assume both of these behaviors should be added to the Overview card.

@sjd78 is this still relevant?


generate goal configuration violates DRY

I already have coded @javax.ws.rs.ApplicationPath("/api") on my javax.ws.rs.core.Application, the generate goal should not require me to specify <apiSource><basePath>/api</basePath></apiSource>.

DRY is a good principle but not easy to follow in real world, as you seen in @javax.ws.rs.ApplicationPath's doc:

When published in a Servlet container, the value of the application path may be overridden using a servlet-mapping element in the web.xml

Ok, I see that it is possible for it ot be overridden in some strange use cases, but why can't this be picked up as the default? Why make me do more work..?


Outgoing web hook don't detect github projects

When prompting for list projects (or any other command) in slack using the outgoing web hook, projects created with github-organization-folder isn't listed in the response.

My best guess is the github-organization-folder plugin creates jobs as either a Job or Item.
https://github.com/jenkinsci/slack-plugin/blob/master/src/main/java/jenkins/plugins/slack/webhook/ListProjectsCommand.java#L44
When listing projects, the plugin gets a list of all jobs subclassing AbstractProject, so if the Job is a superclass of Job or Item, it won't be found.

Also having problems detecting pipeline projects

Side question: Should I even report this here or in Jira? ;)


Adding more colour choices to Gridpaint Activity

Description
Currently, the grid paint activity offers a limited selection of colors for children to use while painting. To enhance creativity and engagement, it would be beneficial to add a wider variety of colors. Additionally, displaying the name of the color when a user hovers over it can help children learn color names and improve their vocabulary.
Proposed Changes
Color Palette Expansion:
Introduce a more extensive color palette, including primary, secondary, and shades (e.g., light blue, dark green).
Allow users to select colors from a color picker for even more customization.
Hover Color Name Display:
Implement a tooltip feature that displays the color name when the user hovers over a color in the palette.
Ensure the tooltip is clear and easy to read, providing a positive learning experience for children.

The GridPaint activity is for younger children. It should stay as simple as possible.
I don't think adding a color palette is interesting.
The Hover event is useless in Sugarizer because it's use most of the time on touch devices where there is nothing like Hover.
Plus writing color name is not appropriate for younger children that don't know how to read.

Yes i see your point, ill be closing this issue


Maven publishing should allow retrying on connection timeout

Expected Behavior
Maven publishing retries, possibly as an opt-in flag, when connection times out to the remote.
Current Behavior
Maven publishing fails if connection times out
Context
We publish to bintray in a massive build with dozens of projects.
https://github.com/open-telemetry/opentelemetry-java-instrumentation
The connection can be flaky, with "connection timed out" errors. This build scan illustrates the failures
https://scans.gradle.com/s/f7dwe46xtdv5s/failure
A connection timed out is safe to retry, in the case that the repository is actually available at all, because nothing is published yet. If Gradle didn't automatically do so, if there was at least an option to retry on connection timed out, it can make this sort of publishing more stable.

I fully agree with that. It is an especially big issue if you have multiple modules and you want to deploy all of them. When one of them fails, you need to delete partial publish from the maven repo and repeat the process.
I think that in the ideal world there should be a special protocol for publishing to the repo which will support publish in transaction mode, but it is a different story ;-)

I have the same issue.
I have project with many subprojects/sub-subprojects (~100). Project is being build on Jenkins then published to Maven repository. The more projects are introduced the higher chance that the gradle publish fails because of connection timeout. Its real issue. Will have to migrate to build in Jenkins publishing plugin as we see its stable.
Big downside is the necessary complex configuration part for publishing with Jenkins plugin, that is supported out of the box with default config in gradle maven-publish plugin.


Merge pull request #26547 from londoncalling/fix-links-in-overview

@londoncalling @sanscontext PTAL

LGTM

LGTM

LGTM


Add new articles

Scout for articles that people have written in the past about their "year in review"
Once you find an article, go into src/articles.js add a new article object. You can use the snippet below as a guide.
{
    title: 'title of the article',
    previewText: 'an excerpt from the article. You can decide to copy the first paragraph of the article, or the first three sentences",
    author: name of the author',
    readMore:
      'link to the original article"',
    date: new Date("Oct 19, 2021"),
    entry_id: 1,
  },

see my pull req.

Hi @oneamanish,
I'll take a look at your PR now. Kindly hold on.


'electron-packager' is not recognized as an internal or external command, operable program or batch file.

how to access 'electron-packager' command.
error="'electron-packager' is not recognized as an internal or external command,
operable program or batch file."

npm i electron-packager
./node_modules/.bin/electron-packager

can you describe your answer @MarshallOfSound

Either install Electron Packager globally, as described in the readme, or install it locally as @MarshallOfSound mentioned. On Windows, instead of ./node_modules/.bin/electron-packager, I believe it's node_modules\.bin\electron-packager.


Multiple @inherits not working with Blazor

I’m attempting to re-jig some layouts and following our ethos of splitting out the functions into components (and in this instance it makes good sense because I want to use one of the functions in more than 1 cshtml page).
The issue is you can only have 1 @Inherits on a cshtml page, which seems like a big draw back to me.
On our main Layout page we:
@inherits BlazorLayoutComponent.
This is required because in here is where the @Body is defined.
I want to have this page use some of our functions, but I cannot add:
@inherits MyMenuFunctions for example because I already have one. So the issue is we need to be able to do multiple inheritance.

Hi, as you know C# does not support mutliple class inheritance. You can implement an interface with the @implements directive. If you need something else please open an issue and provide a clear repro


RacingEffects docs code fixed

Corresponding to the race API change

Q
A

Fixed Issues?
Nothing

Patch: Bug Fix?
No

Major: Breaking Change?
No

Minor: New Feature?
No

Tests Added + Pass?
Yes

Any Dependency Changes?
No

update example code for new race api.

Actually both APIs are supported - you can pass an object or an array to race

oops did not notice...


Raise the RuntimeError message when some InteractiveRunner functions are misused

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@KevinGG Please take a look.

Run Python PreCommit

Run Python PreCommit

The failed test is caused by a crashed worker. Rerunning it to make sure the tests pass.


No provision for assigning values for categorical entity types

Using Version 2.1.
When entity is defined as categorical, Shouldn't it  ask for all possible values to be used by an entity type.
When domain.yml file is populated, it shows entity type as categorical with no possible values.
Rasa core training is completed without any errors ofcourse, but stories doesn't follow the required path.
Same goes with Boolean entity types

Thanks @pradeepmvn . Will it be available in next release? However, I my team has already started working on this.

@anupam20sep Will be glad to accept a PR if you still have it. :)


Bring Go version current

@meatballhat please review

What material impact does this have, why is it important to do this? I am not disagreeing that it's the right thing to do, but I wonder why people care about this.

IMHO keeping up with (patch and/or compatible) compiler/runtime releases helps with bugs and improves performance. For a library, compilation with the last three releases Go might be a good goal per https://golang.org/doc/devel/release.html


Implement Input for Option<Input>

This is motivated by this code snippet:
cmd_unit!(
  "foo",
  if hostname == "vagrant" {
    vec![Env("CARGO_TARGET_DIR", "/vagrant/target")]
  } else {
    vec![]
  },
);

If Input was implemented for Option<Input>, this could be:
cmd_unit!(
  "foo",
  if hostname == "vagrant" {
    Some(Env("CARGO_TARGET_DIR", "/vagrant/target"))
  } else {
    None
  },
);

which seems better. What do you think?

Good point by @soenkehahn that this could be confusing.
This would make this:
cmd_unit!("something", std::env::var_os("FOO"));`

Maybe pass an argument to something, or maybe not, depending on whether the variable is set, which is probably not the intent.

Yes. I think in general that input and return-type polymorphism can open up some disadvantages that are usually avoided in statically typed languages. For example you could imagine someone writing e.g. this code:
fn foo() -> String {
  ...
}

fn bar() {
  cmd_unit!("something", foo());
}

And then (maybe during an attempted refactor) they change foo to return an Option<String>. And then rely on the compiler to tell them about every place in the code where they need to make adjustments. But they miss bar, because of the impl<I: Input> Input for Option<I>.
I'll close this to be on the safer side.
(If anyone really wants this, please speak up.)


Added SocketIO.off() and SocketIO.once()

This would be useful, is it likely to be merged soon?

Thanks @stafyniaksacha!
once() and off() will be in 0.6.6.
I will not backport them to 0.5.7 unless someone requests it.


Support the PubSub emulator in the same way as other APIs

Currently we have a few APIs (Datastore, Firestore and Spanner) that use EmulatorDetection to make it easy to connect to the emulator.
We should apply the same pattern to PubSub (which is slightly complex due to having a wrapper layer) and then update the documentation around this.

Hi @jskeet I'd like to take this task.

@umitkavala: I'm happy for you to give it a try, but I should say that I've looked at this a couple of times hoping it would be simple, and it's really not... and that's despite me knowing the library infrastructure inside and out.
What I'm trying to say is that if you try but find it all too tricky/confusing, please don't feel any sense of inadequacy :) Of course, if you can sort it out, that would be brilliant :)

Its better to warm up before. Let me choose less difficult task :) Do you have any recommendations?

Not particularly, I'm afraid - where there are easy things to do, we tend to pick them off ourselves when we have little bits of time.
Having said that, https://github.com/googleapis/google-cloud-dotnet/issues/5578 would probably be a good starting place. I'd expect it to involve:

Updating dependencies
Creating an integration test
Productionizing the "currently somewhat prototype" code - and particularly thinking about performance
Writing more unit tests
Writing documentation

I'm in no way suggesting that one person has to do all of that :) But it's relatively decoupled from the rest of the library work, which makes it simpler to start on. (It does mean you wouldn't learn as much about how the API libraries work though, so if that's one of your goals it's less appealing.) Let me know what you think :)
(I may now have another look at the PubSub one today, because it's irking me...)

I think its a good start. I'm happy to work with you (that a big bonus for me :) )


Can't see tun0 on ifconfig command, also can't connect.

PiVPN Issue Template

Issue
I installed PiVPN without any problems. I've added a profile, same without problems. Then I transferred that profile to my phone, installed OpenVPN, I imported it, switched over to mobile data, and tried to connect. The only message I receive is: OPENVPN: Waiting for server. I've checked if the public IP is correct and it is. I've checked if the profile is valid, it is. Then I ran ifconfig command and figured out, that it's missing tun0. I posted the output of the ifconfig at the bottom. Hope we can solve this issue!

::: Copy saved to /tmp/debug.txt
:::

Console Output of sudo iptables -t nat -S

pi@raspberrypi:~ $ sudo iptables -t nat -S
-P PREROUTING ACCEPT
-P INPUT ACCEPT
-P OUTPUT ACCEPT
-P POSTROUTING ACCEPT
-A POSTROUTING -s <IP_ADDRESS>/24 -o eth0 -j MASQUERADE
-A POSTROUTING -o tun0 -j MASQUERADE

Console Output of sudo iptables -S
pi@raspberrypi:~ $ sudo iptables -S
-P INPUT DROP
-P FORWARD DROP
-P OUTPUT ACCEPT
-A INPUT -i eth0 -p udp -m state --state NEW -m udp --dport 2600 -j ACCEPT
-A INPUT -i tin+ -j ACCEPT
-A INPUT -i lo -j ACCEPT
-A INPUT -i eth0 -p icmp -j ACCEPT
-A INPUT -i eth0 -p tcp -m tcp --dport 22 -j ACCEPT
-A INPUT -m state --state RELATED,ESTABLISHED -j ACCEPT
-A FORWARD -i tun+ -j ACCEPT
-A FORWARD -i tun+ -o eth0 -m state --state RELATED,ESTABLISHED -j ACCEPT
-A FORWARD -i eth0 -o tun+ -m state --state RELATED,ESTABLISHED -j ACCEPT
-A FORWARD -i eth0 -o tun0 -j ACCEPT
-A FORWARD -i tun0 -o eth0 -m state --state RELATED,ESTABLISHED -j ACCEPT

output of sudo netstat -uanp | grep openvpn

pi@raspberrypi:~ $ sudo netstat -uanp | grep openvpn
udp    49152      0 <IP_ADDRESS>:2600            <IP_ADDRESS>:*                           13030/openvpn

Have you taken any steps towards solving your issue?

Console Output of ifconfig

pi@raspberrypi:~ $ ifconfig
eth0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        inet6 XXXX:XXXX:XXX:XXXX:ce6a:113c:XXXX:XXXX  prefixlen 64  scopeid 0x0<global>
        inet6 XXXX::XXXX:b38a:XXXX:b029  prefixlen 64  scopeid 0x20<link>
        ether xx:xx:xx:a6:12:xx  txqueuelen 1000  (Ethernet)
        RX packets 2063824  bytes 360036398 (343.3 MiB)
        RX errors 0  dropped 103  overruns 0  frame 0
        TX packets 10218842  bytes<PHONE_NUMBER> (2.3 GiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

lo: flags=73<UP,LOOPBACK,RUNNING>  mtu 65536
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>
        inet6 ::1  prefixlen 128  scopeid 0x10<host>
        loop  txqueuelen 1  (Local Loopback)
        RX packets 74706  bytes 4502945 (4.2 MiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 74706  bytes 4502945 (4.2 MiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

Nevermind, I've just fixed it! If anyone will have this kind of problems, just run iptables commands written on this page: http://www.instructables.com/id/Raspberry-Pi-VPN-Gateway/


IteratorResult should be a discriminated union

Suggestion
Current definition of IteratorResult demands value to be provided regardless of whether done is true or false.
Suggestion: Change IteratorResult to something like this
type IteratorResult<T> =
  { readonly done: true } |
  { readonly done: false, readonly value: T }

Use Cases
I am currently trying to build a custom async iterator that cannot be done with async generator, it is absurd that I had to provide some value when iteration is done.
Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

I think I just force cast to as any or sth

@AnyhowStep Yeah, that was my workaround too. But I think it shouldn't be, hence the request.

duplicate of #11375?

According to the spec and MDN the value property may (but is not required to) be present when done is true.
I think the proper typing should be
type IteratorResult<T> =
  { readonly done: true, readonly value?: T } |
  { readonly done: false, readonly value: T }

or even:
type IteratorResult<T> =
  { readonly done: true, readonly value?: any } |
  { readonly done: false, readonly value: T }

@rbuckton think we've got enough infrastructure in place to be able to try this lib change yet?

For reference, @KSXGitHub is talking about this: https://tc39.github.io/ecma262/#sec-iteratorresult-interface (emphasis added):

If the end of the iterator was reached done is true. If the end was not reached done is false and a value is available. If a done property (either own or inherited) does not exist, it is consider to have the value false.

There is, however, nothing that indicates done or value are read-only.

@rbuckton Although the spec does not demands the properties to be either writable or read-only, making them not read-only makes it impossible to use a read-only (e.g. frozen) object as an IteratorResult.


dailymotion: Unable to extract video info

$ youtube-dl http://www.dailymotion.com/video/x39ooog_le-grand-decryptage-du-14-10-2015_news
[dailymotion] x39ooog: Downloading webpage
[dailymotion] x39ooog: Extracting information
[dailymotion] x39ooog: Downloading embed page
ERROR: Unable to extract video info; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
petit@u2:/tmp$ youtube-dl --verbose http://www.dailymotion.com/video/x39ooog_le-grand-decryptage-du-14-10-2015_news
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', 'http://www.dailymotion.com/video/x39ooog_le-grand-decryptage-du-14-10-2015_news']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.02.28
[debug] Python version 2.7.9 - Linux-3.19.0-30-generic-x86_64-with-Ubuntu-15.04-vivid
[debug] exe versions: avconv 11.2-6, avprobe 11.2-6, rtmpdump 2.4
[debug] Proxy map: {}
[dailymotion] x39ooog: Downloading webpage
[dailymotion] x39ooog: Extracting information
[dailymotion] x39ooog: Downloading embed page
ERROR: Unable to extract video info; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 643, in extract_info
ie_result = ie.extract(url)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 275, in extract
return self._real_extract(url)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/dailymotion.py", line 118, in _real_extract
'video info', flags=re.MULTILINE)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 547, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract video info; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

You're using a out-dated version. Follow update instructions if you have problems on updating.

Ok.
I will update and try again.


Removing Target

The current behavior of the module is to remove the target after approving the action. This is causing compatibility issues with Midi-QOL for automating damage. Having an option to clear or not clear the target would solve the issue I believe. I tested a quick proof by commenting out the clearTargets() function in the developer window and Midi-QOL was able to correctly assign the damage as normal.

I'd like to second this if possible. A large draw to this module is to automate mook behavior, but if they break targeting before the rolls are complete, then often damage won't be applied to the correct targets.
Many modules also handle target selection/deselection already, so by opening this up as an option, it would make mookAI much more compatible.

Yep agreed, this module is super awesome but unusable if it stops targeting before the attack


add custom handlers for master / agent

Agent also can now check in with master on startup
Closes #11

Coverage decreased (-24.6%) to 46.457% when pulling 50405976b93312d2def1f47479b6173447f158b9 on register into 2a966bcde2d7369701e3d32e09f32f0de9ce1430 on master.


[bug]: Upgrade Logger depency

Describe the bug
Currently stacked_generator ^1.4.0 (latest version) depends on logger ^1.4.0. The logger package has released v2 with some api changes (see here. This ticket is to upgrade stacked_generator's logger dependency to the latest version and adopt the API changes.
To reproduce
If you have logger ^2.0.0 as a dependency in pubspec.yaml file then there will be a pub get conflict.
Expected behavior
Stacked generator should stay up to date with dependencies.
Screenshots
No response
Additional Context
No response

any update?

@FilledStacks can you have a look at this dependency upgrade as it is blocking quite a lot now?


Service does not work

URL to the linked Repo/Org:
Steps to reproduce the problem:

What is the expected result?
What happens instead?

Hi @HEBOS, Could you please send the URL of the affected Pull Requests because our service seems to be working just fine !.

@ibakshay I have the same problem, this one does not seem to be working: https://github.com/bpmn-io/tiny-svg/pull/7
I get:

Error
There is no CLA to sign for bpmn-io/tiny-svg

and sometimes a bunch of errors from Cloudflare when reloading the page

The connection to the origin web server was made, but the origin web server timed out before responding. The likely cause is an overloaded background task, database or application, stressing the resources on your web server. To resolve, please work with your hosting provider or web development team to free up resources for your database or overloaded application.

Service seems down at the moment - maybe overloaded?
Navigating to https://cla-assistant.io/ times out and github web hooks seem to be mostly failing with We couldn’t deliver this payload: Service Timeout

Going to the site now shows:
404 Not Found: Requested route ('cla-assistant.io') does not exist.

It seems down.

I am sorry for the inconvenience. We have seen some performance outages and long response time in the past 3 days. I will look into it.
@scudette Yes I believe It was overloaded.
However, CLA Assistant service is up and running without any issue now :) .

Thanks @ibakshay :-). Trying to redeliver the github web hooks still times out - maybe it will get better over time :-).

😄 @scudette  Could you give us the URL of the affected pull request ?

When I click redeliver it spins for a while and fails with a timeout.


MM-10160 - support interactive button styles

Summary
Supports the customization of interactive message buttons through the style property on attachments.actions objects. Dummy test actions used to achieve screenshot:
[
   {
      id:'gpc1tihowbfmmcizofm7zhr1to',
      type:'button',
      name:'dog',
      style:'danger'
   },
   {
      id:'gpc1tihowddto',
      type:'button',
      name:'cat',
      style:'primary'
   },
   {
      id:'gpc1tihowbfmmcizddo',
      type:'button',
      name:'moose'
   },
   {
      id:'gpc1tihowbfawemmcizddo',
      type:'button',
      name:'chocolate',
      style:'#166de0'
   },
   {
      id:'gpc1tihowfabfmmcizddo',
      type:'button',
      name:'rat',
      style:'onlineIndicator'
   }
]

Things to note:

I expanded the STATUS_COLORS object to define the "default" and "primary" colors, and picked the original default blue color. If you want those definitions changed, let me know.

I assume the server will send me a valid style property if it exists. If we don't trust the response, I can do some sort of validation.

Button default styles on the web app:

Notice on my own screenshot on button 3 "moose", the default style is a button with white text and blue background. If we want to change the default style to something like the web, something without background color, let me know.
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/13260
https://mattermost.atlassian.net/browse/MM-10160
Checklist

[x] Has UI changes

Device Information
This PR was tested on:
iPhone 11 Pro Max Simulator - 13.3
Screenshots
After:

Before:

@enahum what did you want me to review with this? I don't have much context or background.

@mattewbirtch the UI changes I guess (the buttons that reflect the options of the poll)... are we ok with them? Do they need anything else? It does not look very refined to me.

Also wondering if there is a limit to the amount of options, if there isn’t should there be?

@enahum can we open a UX ticket to look at this? I'd like to understand all the uses of these interactive buttons and how/why we're proposing custimization. I'd also like to look at the styles we're using here and provide a better default I think.

@matthewbirtch, see https://mattermost.atlassian.net/browse/MM-10160 for context, but this is largely an effort to expand our offering to match Slack's behaviour here. Their guidelines encourage plugin authors to use colours sparingly, but afford them the flexibility to pick whatever colours they want.

@RyanCommits until we figure out what to do with the UI, can you please make the requested changes on the code.
Thanks.

@matthewbirtch, to confirm, each button can be styled with a separate colour. Any concerns applying  the thrust of your changes that show the buttons all having the same colour?

I was hoping to avoid the ugliness of the rainbow effect, but if we don't want to impose any limitation here, it's fine. Here's how that looks

I also wanted to provide how this displays in the web app/desktop. This layout is also in the Figma file linked above.

cc @aaronrothschild @itao @esethna on above designs from product team

@RyanCommits until we figure out what to do with the UI, can you please make the requested changes on the code.
Thanks.

Unit tests added and the requested changes are completed. Code updated to match designs.

@RyanCommits @enahum is there a build I can test with?

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/3716
https://circleci.com/gh/mattermost/mattermost-mobile/3715

@matthewbirtch should be posted in the QA channel soon

Artifact links:
https://3716-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa
https://3715-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk

@matthewbirtch Answer to your questions:

This feature on the webapp is not implemented. We'll need someone to do that.
Testing the various colors on a pre-built app installed in release mode is not possible unless mattermost already supports customizing button colors on the server side. Maybe @lieut-data can confirm. The way I'm testing this is locally hijacking the response from the server, and injecting my own data. I don't know of any other way to replicate the colors. I can give you an updated screen shot if it helps:

Padding tweaks: done
Hard coded hex values: "good" and "warning" were properties that existed before. I didn't add them myself. I replaced the hardcoded values with constants from mattermost-redux

Here's the android screenshot: Pixel 2xl
If you look at the left padding of the buttons, you'll notice that it's a tiny bit bigger compared to the right. For some reason, the outer container's big blue border on the left side is pushing the entire content to the right. If I remove the blue border, the extra space goes away.
Not sure why this is a thing, perhaps a bug with android.

@matthewbirtch Thanks for the diligent review!
Addressing your concerns:

It seems like Android does not respect fontWeight: 600. I checked other elements that are 600 and they all show up thin. This may be a bigger issue that needs addressing. For example, "hey", which is the title of the poll, should be fontWeight: 600, but shows up thin on Android as well. This bug is in the production version of the app too.

Done. The buttons themselves were 38px rather than 36px as per the design. I updated them to be 36px in height.

ios:

android

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/3767
https://circleci.com/gh/mattermost/mattermost-mobile/3766

Artifact links:
https://3767-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk
https://3766-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/3817
https://circleci.com/gh/mattermost/mattermost-mobile/3816

Artifact links:
https://3817-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa
https://3816-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk


🐛 Issue #5: microbundle mangles the css class names

Description
This PR prevents the mangling of CSS class names and fixes a linting error in Heading.
Related Issue
#5
Motivation and Context
Since we are enhancing some spectrum css classes we can't have the class names mangled when we import this package into templates.
How Has This Been Tested?
npm linked this package in parliament-client-template to test the CSS overrides work properly.
Screenshots (if appropriate):
Mangled css classes:

Without mangled css classes:

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

+1 and unrelated I just noticed on your screenshot that the searchfield clear button is missing right margin or something like that.

@icaraps I'll double check that margin issue.


Increase Kokoro testing reliability

This PR increases the reliability of a few of the tests. Some are most likely still flaky, but I will address those as they appear.
It also removes leftover files from older testing and moves the GitHub templates into the .github folder.

@lesv - FYI


[SPARK-24697][SS] Fix the reported start offsets in streaming query progress

What changes were proposed in this pull request?
In ProgressReporter for streams, we use the committedOffsets as the startOffset and availableOffsets as the end offset when reporting the status of a trigger in finishTrigger. This is a bad pattern that has existed since the beginning of ProgressReporter and it is bad because its super hard to reason about when availableOffsets and committedOffsets are updated, and when they are recorded. Case in point, this bug silently existed in ContinuousExecution, since before MicroBatchExecution was refactored.
The correct fix it to record the offsets explicitly. This PR adds a simple method which is explicitly called from MicroBatch/ContinuousExecition before updating the committedOffsets.
How was this patch tested?
Added new tests

Test build #92838 has started for PR 21744 at commit 81e8955.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/835/
Test PASSed.

@arunmahadevan

Test build #92838 has finished for PR 21744 at commit 81e8955.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92838/
Test FAILed.

jenkins retest this

@tdas logically this is similar to https://github.com/apache/spark/pull/21673. Yes it makes the control flow better and LGTM.
Overall the progress reporter is still tightly coupled with the internals of StreamExecution and the complexity can be reduced by making the ProgressReporter orthogonal to StreamExecution (composition vs inheritance). Anyways that can be handled separately.

jenkins retest this please

@arunmahadevan I agree that this can be refactored later. I was trying to do that, and then realized that it does not make sense to do that in the same PR as this bug fix. thank you for reviewing.

Test build #92844 has started for PR 21744 at commit 81e8955.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/837/
Test PASSed.

Merged build finished. Test PASSed.

Test build #92844 has finished for PR 21744 at commit 81e8955.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92844/
Test PASSed.


chore: changed burma to myanmar

Description
The purpose of this PR is to change Burma to Myanmar everywhere on the application.
Ticket: https://trello.com/c/FYrB3oe8/1392-change-burma-to-myanmar

Does the DB need to change Burma to Myanmar as well?

This is a good point, I'll write a migration for that 💪

Does the DB need to change Burma to Myanmar as well?

Man, I feel like these are the sort of requirements that would be helpful to put in the ticket 😅


Scroll back to original location when clicking 'UP' inside folder

When in Folder View scroll down some distance,
open a folder,
click the up button
notice that the app resets the scroll to the top of the page

It would be nice if it went back to roughly where you were before clicking on the folder.
This feature was requested by a user. Seems useful when navigating using folders.
Feels like it may be easy to implement:

for simplicity the feature could be available only for the root folder
simply store the y-offset (or whatever number associated with it) in the component
make virtual scroller scroll to there

it may be possible to use scrollToIndex or scrollToPosition in virtual scroller to achieve this

Alternative solution to apply to any number of nested folders:

Scroll to the imageElement representing the folder containing the first (or any) video you just came up from.

See here in image-viewer for an example.
That method allows you to move up one folder, showing more images, but scrolls back to the top right image you were looking at. 😄

I discovered a bug in ngx-virtual-scroller 😅
The scrollToPosition does not accept 0 ms 😓
I'll try to fix it 😁
https://github.com/rintoj/ngx-virtual-scroller/issues/420

Thank you @cal2195 for the code reference 🤝 -- it was helpful 😁
I ended up using pixel offset because that maintained the scroll position more-exactly 👌

Does this only work for a single folder level? 🤔

Yeah -- it's a really rough implementation only aiming to handle the root level 😅
There is also breadcrumb navigation, so to handle all cases I'd have to keep track of depth (since up is not the only way to navigate).
Also I didn't add a reset when switching hubs, so it will navigate incorrectly the first time after using the folder navigation in one hub and switching to another if the user hasn't come back to root level 🤷♂
While it's a hack-y implementation, it will handle (I think) 95% of the cases without causing any more discomfort than before, and significantly improving the navigation experience otherwise.


Add list all Tables API spec and implementation

@zsxwing Please take a look.

Related issue: https://github.com/delta-io/delta-sharing/issues/64

Thanks for the feedback!
I'll update the python client list_all_tables in a separate PR


Allow defining custom archive URLs in a bulk import

A Site has many Mappings and user can bulk import mappings from a CSV.
One of the available types of Mappings is an Archive Mapping. An Archive Mapping has an Old URL and an Archive URL.
A Site has a National Archives timestamp and its Archive Mappings can either construct their Archive URL using that timestamp or they can specify their own custom Archive URL.
Until now we've ignored any custom Archive URLs that were defined in an imported CSV (and instead let the imported Archive Mappings default to constructing their Archive URLs from their Site's timestamp as described above).
These updates change that behaviour, so that we now respect custom Archive URLs in CSVs and persist them along with their Mapping.

Copy changes look good. It might be worth adding a line to https://github.com/alphagov/transition/blob/master/app/views/import_batches/new.html.erb#L24 to show an example of a custom National Archive.

As discussed in person with @fofr, we're gonna forget adding an example CSV entry for now.
The loooonngg National Archives URL results in the line wrapping and being a lot less readable than the other, existing examples.
And it's an advanced feature that's already explained on the page (https://github.com/alphagov/transition/blob/master/app/views/import_batches/new.html.erb#L17).

Lovely small commits with great explanations at every stage :sparkles: :cherry_blossom: :pizza: :small_blue_diamond:

:stars: :star2:


New master is not replicating after a failover

Info
Version: the latest operator and cluster chart from this repository.
Description
Our test environment consists of 3 nodes.

$release-mysqlcluster-db-0 (master)
$release-mysqlcluster-db-1
$release-mysqlcluster-db-2

We are simulating a master node failure by killing the mysqld process in db-0
In the event of a DeadMaster event, orchestrator automatically promotes db-1 to master, but the new master node is stuck at not replicating error.
What would be the correct recovery process?
Operator log
{"severity":"INFO","timestamp":"2020-10-15T21:21:41.371071513Z","logger":"orchestrator-reconciler","message":"cluster not ready for acknowledge","key":"$namespace/$release-mysqlcluster-db","threshold":600}

{"severity":"ERROR","timestamp":"2020-10-15T21:26:14.340158975Z","logger":"kubebuilder.controller","message":"Reconciler error","controller":"mysqlbackup-controller","request":"$namespace/$release-mysql-cluster-db-auto-2020-10-14t19-24-00","error":"MysqlCluster.mysql.presslabs.org \"$release-mysql-cluster-db\" not found","stacktrace":"github.com/presslabs/mysql-operator/vendor/github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/src/github.com/presslabs/mysql-operator/vendor/github.com/go-logr/zapr/zapr.go:128\ngithub.com/presslabs/mysql-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/src/github.com/presslabs/mysql-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:217\ngithub.com/presslabs/mysql-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1\n\t/go/src/github.com/presslabs/mysql-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:158\ngithub.com/presslabs/mysql-operator/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1\n\t/go/src/github.com/presslabs/mysql-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133\ngithub.com/presslabs/mysql-operator/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/src/github.com/presslabs/mysql-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134\ngithub.com/presslabs/mysql-operator/vendor/k8s.io/apimachinery/pkg/util/wait.Until\n\t/go/src/github.com/presslabs/mysql-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88"}

Dead master pod (db-0) log after restart
2020-10-15T21:11:23.994309Z 0 [Note] mysqld: ready for connections.
Version: '5.7.26-29-log'  socket: '/var/lib/mysql/mysql.sock'  port: 3306  Percona Server (GPL), Release 29, Revision 11ad961
2020-10-15T21:11:23.995177Z 3 [Note] Got an error reading communication packets
2020-10-15T21:11:23.995742Z 4 [Note] Got an error reading communication packets
2020-10-15T21:11:24.173001Z 6 [Note] Start binlog_dump to master_thread_id(6) slave_server(101), pos(, 4)
2020-10-15T21:11:28.133393Z 18 [Warning] Neither --relay-log nor --relay-log-index were used; so replication may break when this MySQL server acts as a slave and has his hostname changed!! Please use '--relay-log=$release-mysqlcluster-db-mysql-0-relay-bin' to avoid this problem.
2020-10-15T21:11:28.150677Z 18 [Note] 'CHANGE MASTER TO FOR CHANNEL '' executed'. Previous state master_host='', master_port= 3306, master_log_file='', master_log_pos= 4, master_bind=''. New state master_host='$release-mysqlcluster-db-mysql-1.mysql.$release', master_port= 3306, master_log_file='', master_log_pos= 4, master_bind=''.
2020-10-15T21:11:28.175401Z 20 [Warning] Storing MySQL user name or password information in the master info repository is not secure and is therefore not recommended. Please consider using the USER and PASSWORD connection options for START SLAVE; see the 'START SLAVE Syntax' in the MySQL Manual for more information.
2020-10-15T21:11:28.176719Z 21 [Note] Slave SQL thread for channel '' initialized, starting replication in log 'FIRST' at position 0, relay log './$release-mysqlcluster-db-mysql-0-relay-bin.000001' position: 4
2020-10-15T21:11:28.184056Z 20 [Note] Slave I/O thread for channel '': connected to master 'sys_replication@$release-mysqlcluster-db-mysql-1.mysql.$release:3306',replication started in log 'FIRST' at position 4
2020-10-15T21:11:31.551274Z 6 [Note] Aborted connection 6 to db: 'unconnected' user: 'sys_replication' host: '<IP_ADDRESS>' (failed on flush_net())

New master node (db-1)
2020-10-15T21:40:51.873465Z 576 [ERROR] Slave I/O for channel '': error connecting to master 'sys_replication@//$release-mysqlcluster-db-mysql-0.mysql.$namespace:3306' - retry-time: 1  retries: 1755, Error_code: 2005

Seeing more or less the same in our tests. We're testing how we're going to handle node drains. While testing this, I've realized that, no matter what kind of persistence (hostPath, local path PVC, SDS PVC, emptyDir) we configure the cluster is always broken in Orchestrator after the drain. The MySQL pods gets recreated correctly on another node, but it seems like the cluster isn't correctly set back to a fully functional state.

For me it looks like it's not really a problem, but rather misleading message from operator/orchestrator. Replication is still working in an async mode... And master doesn't have to replicate anything at all...
After I reset new master's replication via Orchestrator everything becomes normal again.
Looks like it's worth automating this inside the operator.

@ExiaSR @ynnt I am also running into the same issue. Did you ever resolve this?

I think PR #690 can solve this problem
cc @munjalpatel @ynnt @ExiaSR


Snowflake backend

Hello there! May I ask that whether there's any plans to add Snowflake as the backend storage? Or may I know whether there are any reasons why Snowflake is not considered as a backend? Thanks!

Hi @billstark! Currently dbcat is able to connect to schemas and databases in Snowflake. Do you mind clarifying your question on adding Snowflake as a backend storage? Thank you! :)


ESP-IDF-V5

Is this library also working with esp-idf v5.0.1 or only with v4.1.1, because I get several errors.

Is this library also working with esp-idf v5.0.1 or only with v4.1.1, because I get several errors.

In the file "esp32-idf-sqlite3/CMakeLists.txt" add 'spi_flash' to REQUIRES.
In the file "esp32-idf-sqlite3/esp32.c" add '#include <esp_random.h>'.
After these changes, this component is build without errors.
ESP-IDF v5.0.2-dirty


Add a comparison URL to version

In order to make a swift comparison between the currently-installed
version vs the latest commits on master, emit a clickable URL that
will show the user the exact changes.
Signed-off-by: Mike Fiedler<EMAIL_ADDRESS>

Good stuff - thanks!


socks.py - Error Handling SOCKSProtocol

I need to figure out how the protocol gets wound-down when various protocol errors occur, in particular, when malformed or unexpected messages come from the client. If nothing else, I need to add some logging when the errors are discovered. There are a few kinds of errors that may happen in the protocol's lifetime.
Also, I need to figure out how to kill the protocol if a timeout occurs.
I also remember from the SOCKS 5 RFC mentioning some context in which the SOCKS server is supposed to send a response within 10 seconds of some error occurring. I will need to look this up.

Implemented as of 508d6b9e9a


Last batch of javaharness lint/errorprone/style fixes

After these changes, should be tricorder free of errors.


Could you add the baseline Grad-CAM implementation?

Hi,
This work is really interesting. In the paper I saw that you had compared your approach with Grad-CAM among other approaches. However I was unable to find its implementation in the baselines folder. Is there any chance you could add this code?
Thanks in advance

Hi @ramprs, thanks for your interest in our work!
I refer you to:
https://github.com/hila-chefer/Transformer-Explainability/blob/main/baselines/ViT/ViT_explanation_generator.py#L59
this is the implementation of the Grad-Cam baseline.
You can also look at our segmentation tests to get an example of how to use this code with ViT:
https://github.com/hila-chefer/Transformer-Explainability/blob/main/baselines/ViT/imagenet_seg_eval.py#L217.
I hope this helps, and please feel free to ask for clarifications if needed.

Hi @ramprs, thanks for your interest in our work!
I refer you to:
https://github.com/hila-chefer/Transformer-Explainability/blob/main/baselines/ViT/ViT_explanation_generator.py#L59
this is the implementation of the Grad-Cam baseline.
You can also look at our segmentation tests to get an example of how to use this code with ViT:
https://github.com/hila-chefer/Transformer-Explainability/blob/main/baselines/ViT/imagenet_seg_eval.py#L217.
I hope this helps, and please feel free to ask for clarifications if needed.


Implement MleRouter::GetNextNeighborInfo() method

Current coverage is 68.83% (diff: 46.42%)

Merging #724 into master will decrease coverage by 0.55%

@@             master       #724   diff @@
==========================================
  Files           102        100     -2
  Lines         15373      15344    -29
  Methods        2100       2086    -14
  Messages          0          0
  Branches       1829       1830     +1
==========================================
- Hits          10668      10562   -106
- Misses         4128       4203    +75
- Partials        577        579     +2

Powered by Codecov. Last update aeba71b...f154978


Redirect to Propose page

Context & versions
https://dev-sanchonet.govtool.byron.network/dashboard
Actual behavior

Expected behavior
When user click on "PROPOSE" it should be redirected to the Propose page

@ValMBO This is a little complicated to implement at the moment, it is possible, but when we want to create a proposal, we have the first step with information about GA when we do not have a DRAFT or if we have a draft, we have a list of drafts that we can build on. Does this perhaps present a problem that in case we have drafts, we skip a step with them like this?

@ValMBO What is the status of this task, with the addition of the wallet verification screen, it is not possible to redirect here, because the verification screen will have priority

@teske00 @ValMBO Here are my observations:

Propose button points to the wrong route - /proposal_pillar/proposal_discussion
If you try the same from proposal discussion page it points to this one - /connected/proposal_pillar/proposal_discussion
In the case you already verified yourself (by visiting all proposals page) you should be able to jump to the correct link
In the case you didnt verify yourself, can we present the verification screen and then redirect to creating the proposal page like in 2 above upon successful verification?

@bosko-m @akruk93 @jdyczka After this latest version is imported into govtool, you need to set up a redirect by clicking this button to "/proposal_discussion/propose"

@kneerose It can be tested on dev with new version of pdf now.
CC: @bosko-m

@vpaunovic
I have tested this on the dev environment. When my wallet has more than 50K ADA, I can navigate the proposal creation step without issues. However, if my wallet balance is below 50K ADA, clicking the "Propose" button on the dashboard triggers an "insufficient balance" popup. Please look into this issue: Issue #1428.
CC: @bosko-m

In fact, the check should be removed, we do not submit that proposal to the chain, but only create it in our database


Handle the fact that in some cases, not entirely understood by me but reflected in the test case, the namespaces can come into XPathContext#register_namespaces with frozen UTF-16 keys

I ran into this via the roo test suite. I suspect the fix could be more targeted, to avoid the case reaching this point in the code, but this is my personal best effort, and the fix works.
The XML was found in the Pfand_from_windows_phone.xlsx file in the roo test suite. https://github.com/Empact/roo/blob/master/test/files/Pfand_from_windows_phone.xlsx
The error without the fix is:
test_namespace_encoding(Nokogiri::HTML::TestDocumentEncoding):
Encoding::CompatibilityError: incompatible encoding regexp match (US-ASCII regexp with UTF-16 string)
    nokogiri/lib/nokogiri/xml/xpath_context.rb:11:in `gsub'
    nokogiri/lib/nokogiri/xml/xpath_context.rb:11:in `block in
    nokogiri/lib/nokogiri/xml/xpath_context.rb:8:in `each'
    nokogiri/lib/nokogiri/xml/xpath_context.rb:8:in `register_namespaces'
    nokogiri/lib/nokogiri/xml/node.rb:152:in `block in xpath'
    nokogiri/lib/nokogiri/xml/node.rb:150:in `map'
    nokogiri/lib/nokogiri/xml/node.rb:150:in `xpath'
    nokogiri/test/html/test_document_encoding.rb:26:in `test_namespace_encoding'

This seems to only be an issue with Ruby 1.9.3 -- I can't reproduce it on 2.0 or 2.1. Since 1.9.3 is about to be EOLed, and it looks like no further research went into this, I'm going to close.
If someone can reproduce this with Ruby 2+, please open a new issue with a test case? Thank you!


[Backend] FDPS Backend

Add FDPS backend.

99b1090b5b2de818a7eb39efb6dc9671bfdf7e4c has a first implementation of an FDPS backend. At the moment it only supports per_particle operations (as needed for basic PIC implementation).
I need to test building the output tomorrow, and once that goes I can start tests & a PR for that.

Initial FDPS backend is completed. It needs to be extended to support pairwise operations and improve performance in the future.


If output, dont print passwords

If output file is used, disable printing passwords to stdout, should make output faster.

Replaced with batching and a basic #/# output

How to turn output to stdout?


DiscordSRV Staff-Chat is not showing the purple (Staff) prefix when sending messages or enabling the staff chat.

Here is the image.

List of my plugins

And what does your messages.config.yml look like?

https://pastebin.com/stjm6Kau

That's your DiscordSRV messages config. I need your DiscordSRV-Staff-Chat messages config. (plugins/DiscordSRV-Staff-Chat/messages.config.yml)

i don't have a message.config.yml file in my folder

Thank you for reporting this bug. It should not be fixed with 1.4.4.


Ability for templates to specify Dockerfile CMD

Is your feature request related to a problem? Please describe.
Currently, the final production Dockerfile is defined as part of the Appsody image - for example https://github.com/appsody/stacks/blob/46c6c8c73f35b0de794e74233bebc606e0aaeb01/incubator/nodejs/image/project/Dockerfile
This defines the CMD that is run when the production image is run via docker run:
CMD ["npm", "start"]

This means that the run CMD is fixed by the image and cannot be changed by the app.
The problem
Imagine a stack for C++ apps, that includes the C++ runtime (or Rust, or Go, or Swift...). The CMD should specify the C++ executable to be run, however the stack creator cannot know this as it could be anything. As we want users to be able to Bring Their Own App, different apps will need different run CMDs - there is no equivalent of npm start.
Describe the solution you'd like
A way for apps to specify the CMD or ENTRYPOINT for the final Docker image.  Here's an idea on how this could perhaps be done:
Extra metadata in .appsody-config.yml, provided by the app author, something like:
dockerfile-cmd: /path/to/myapp-executable

which Appsody would pick up and pass in via docker build --build-arg and could be used inside the Dockerfile via an ARG line.

Thanks @ianpartridge for raising this issue.
We will take a look and update some proposals here soon.


Add views and templates

Add a view and tempate for index, which will be the landing page and a list of all message threads. Each item in the list should link to a message thread.
Add  a view and template for message threads.

I have implemented a view for both index and thread. The views have the basic logic and database queries. The templates are barebones, just enough for testing. Putting this on the backlog for now.

Templates now have some layout and navigation. Need to decide whether the message index should have a standalone page or remain on the landing page.


Use cog for help and schema in README

Cogging the schema is hard because I need to mock the call to the boto API somehow.

Result: https://github.com/simonw/sqlite-comprehend/blob/ea90d18f5567ad9b0c9b16b9b9eb3583b62cbcea/README.md


Update requirements.txt

Feature or Bugfix

Refactoring

Detail

Relates

Security
Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?

Is the input sanitized?
What precautions are you taking before deserializing the data you consume?
Is injection prevented by parametrizing queries?
Have you ensured no eval or similar functions are used?

Does this PR introduce any functionality or component that requires authorization?

How have you ensured it respects the existing AuthN/AuthZ mechanisms?
Are you logging failed auth attempts?

Are you using or adding any cryptographic features?

Do you use a standard proven implementations?
Are the used keys controlled by the customer? Where are they stored?

Are you introducing any new policies/roles/users?

Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi @epalmiotti, thanks for opening a PR! Can you please provide some context on why AGiXT is required? Are you working on some sort of integration?


is there any documentation for the JSON evaluator?

I'm wondering if I can harvest Schema.org metadata?

Mmm do you have an example? I thought schema.org was to annotate content. Have not see it as a metadata structure.

It's being used in the EarthCube community to insert metadata into data set landing pages. For some reason, various NSF data facilities have found it easier to do that than generate harvestable metadata (e.g. a WAF....)  in one of the pre-existing standard metadata formats that geoportal already supports, so its seen more adoption (see GeoCODES).
We'd like to take advantage of the metadata those facilities is exposing by harvesting into the EarthCube geoportal we've been working on.   It looks like Geoportal might already have a handler for the project-open-data DCAT based JSON-LD?

Hey!! How did EarthCube GeoPortal manage to get the menu bar to be "sticky"?  For instance one can link directly to the Collection tab (http://datadiscoverystudio.org/geoportal/#collectionPanel). I would like to do the same thing.  Currently our portal  loads the whole app and always lands on the default page without going to the #bookmark.  (sad face)  It would be handy for us to direct clients to a specific page/panel.  It is exciting to see who others are using the App.

@smrgeoinfo would this be an example JSON-LD?
https://www.bco-dmo.org/node/3196/rdf/jsonld
I found this by starting from
https://www.earthcube.org/webapps/geocodes/discovery/ui/textSearch.html
then selecting one of the results:
https://www.earthcube.org/webapps/geocodes/discovery/ui/details.html?url=http%3A%2F%2Fwww.bco-dmo.org%2Fdataset%2F3196
then following the link to the BCO-DMO page for this dataset:
https://www.bco-dmo.org/dataset/3196
and then getting the JSON-LD encoding:
https://www.bco-dmo.org/node/3196/rdf/jsonld
I notice this also has an ISO encoding:
https://www.bco-dmo.org/dataset/3196/iso
Is there a place where I can find a full listing or some catalog service interface to this?

Hey!! How did EarthCube GeoPortal manage to get the menu bar to be "sticky"? For instance one can link directly to the Collection tab (http://datadiscoverystudio.org/geoportal/#collectionPanel). I would like to do the same thing. Currently our portal  loads the whole app and always lands on the default page without going to the #bookmark. (sad face) It would be handy for us to direct clients to a specific page/panel. It is exciting to see who others are using the App.

modified the App.js: https://github.com/CINERGI/geoportal-server-catalog/blob/master/geoportal/src/main/webapp/app/main/App.js
$("a[href='#collectionPanel']").on("shown.bs.tab",function(e) {
location.hash = '#collectionPanel';
});
Think this is in the 2.6.2 branch.

Martin-- that bco-dmo JSON-LD doesn't validate with the structured data testing tool from google )
If you try one of the 'schema.org' links in datadiscoverystudio search results panel (the last one on the right ,e.g. this), it will take you the structured data testing tool, and if you click on one of the content elemetns from teh metadata on the right, it will show the corresponding JSON-ld embedded in the html on the left.  the JSON-LD metadata is embedded in html inside a

Initial codedrop for converting JSON-LD dataset to an ES index is here:
https://github.com/CINERGI/geoportal-server-catalog/tree/feat/sdsc/jsonld
Still needs more work to support full ingest via extraction from an HTML page, but the basics are there.

closing due to inactivity


Random Reboots + Brightness

Using Dopamine 1.1.2 with iPhone 12 Pro on iOS 15.4.1
After a successful jailbreak and reboot of userspace, brightness is so low that I am unable to see the screen. I can sometimes manage to get to the Dopamine app to restoring and the brightness fixes itself, however I must mind a VERY dark room to see the screen.
After about 2-4 hours after a successful jailbreak, the phone will randomly reboot back to stock iOS. The phone can be playing media, browsing an app/internet, or simply in sleep mode, yet it will panic and reboot. This has been tested with and without tweaks installed. I'm averaging about 3-4 reboots a day.

Does this happen when on stock iOS (no jailbreak)

Does this happen when on stock iOS (no jailbreak)

Haven't tested stock, but I'll give that's go tomorrow and will report back.

First one is known bug on A14
For the second one, send a panic log???

So I'm guessing first one is duplicate of #123
Second one might be duplicate of #274, although the fact it happens without tweaks sounds weird.


wrong syntax highlighted for java code block.

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
wrong syntax highlighted for java code block.
Steps to Reproduce

input java code block:

A[] a = new A[4];
A[] b = {new A(), new A(), new A()};
A c = new A[]{new A(), new A()};

Expected behavior: hard to say.
Actual behavior:

Reproduces how often: Always.
Versions
Atom    : 1.17.0
Electron: 1.3.15
Chrome  : 52.0.2743.82
Node    : 6.5.0
language-gfm : 0.88.1

Please reopen this on the atom/language-java repository.


give the text of the legends top/left/bottom/right

Feature Proposal

as you can see the text is not vertically align to center and I dont find any way to do that
I want the text to have a "top" option to push several pixels lower
Possible Implementation
  legend.labels: {
      top: 3
  }

No response

I'm not sure I understand what needs to change here. The legend doesn't have extra padding from what I can see https://jsfiddle.net/8s5w910z/
To get those icons, it seems like an HTML legend was used. Are you using a wrapper around chart.js?


[Feature] Default randomize to true

This PR closes #47

Yes! Thank you so much

It seems like this doesn't work:
!'randomize' in {} // false

I think you want this instead:
!('randomize' in {}) // true

This seems a bit like a breaking change of sorts!


feat: update to latest SDK and use SSR for the context

I still need to get the SDK changes deployed

yessss, thank you!


belinda-nextjs-bug-239-loading-individual-product-page

Resolve #239
This PR will update the loading status. It will appear circular icon while getting the data.

@taylorpapke I also see this when I refresh the page but it does not happen when I am on the main branch.


Error: useSidebarItemContext should be used within the SidebarItemContext provider!

Describe the bug
I'm getting the in the title mentioned error while using the example code. Browsing the code, it looks alright to me.
To Reproduce
Steps to reproduce the behavior:

Create a new component
use the following code

import { Sidebar } from 'flowbite-react'

const TemplateSidebarNavigation = () => {
  return (

{'TemplateSidebarNavigation'}

      <Sidebar aria-label="Test DB">
        <Sidebar.Items>
          <Sidebar.Item href="#">Dashboard</Sidebar.Item>
        </Sidebar.Items>
      </Sidebar>

  )
}

export default TemplateSidebarNavigation

See error

Expected behavior
The component should render without any errors.
Screenshots

System information:

Device: PC
Resolution: 1440p
OS: Windows 11
Browser: Chrome
Version: latest

Project information:

Tailwind: ^3.1.4
Flowbite: ^1.4.7
Flowbite React: ^0.1.3
Type: Redwoodjs with React 18.2.0

Same issue here.

@valerius21 can you confirm that the solution above works?

@rluders Thank you for the response. I'll retry everything again when RedwoodJS finishes the React 18 upgrade officially. I did not see it initially. https://github.com/redwoodjs/redwood/pull/4992


Social Media icons should open in new tab on clicking

Describe the bug/feature
Social Media icons should open in new tab on clicking now it is opening in same parent frame
To Reproduce
I will add target="_blank" so that links will open in new tab

Please assign me

@abhijeet141 go ahead.


Feat : show diff between the two versions in versioning history.

Describe your changes :

I worked on the versioning page to show the diff between the two versions in versioning history.

Type of change :

[x] Improvement
[x] New feature

Frontend Preview (Screenshots) :

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have performed a self-review of my own.
[x] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers
@shahsank3t, @darth-coder00

Is it possible to show diff between two specific versions (eg: all changes between v9.1 and v10.3)
Similar to git diff abcd...efgh

Hi @mithmatt
For this release, we are not showing diff between the two specific versions but probably add the support in the upcoming releases.
cc: @harshach @darth-coder00

@darth-coder00 for field change we have this interface so newValue and oldValue would be any types that's why I have kept type as any wherever we have used FieldChange.
interface FieldChange {

  name?: string;

  newValue?: any;

  oldValue?: any;
}


Revise and rewrite database persistence logic

Description:
The database design should be revised according to the dashboard requirements.
Suggested Labels:
Type/Task
Suggested Assignees:
AsmaJ

The discussed ERD is as shown below:


bug in KSubset with k = 0

The 0-Subsets of a sequence should be a one item sequence, and this item should be an empty list.
Indeed there is always one subset of length 0 : the empty set.
  Enumerable.Range(1, 4).Subsets(0);  // [] instead of [[]]

It returns an empty sequence instead.
A call to Subsets() return a sequence that contains an empty list, as expected.

Thanks for reporting this. Unfortunately, since this is a breaking change and Subsets has been around for a long time, I am currently inclined to defer this to the next major version update.


Polish Azure.ResourceManager.Automation for GA

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.Automation

/check-enforcer override


Fix typo in the graph of document

Can one of the admins verify this patch?

jenkins test this please

@chezou Thanks for the fix. Will merge soon.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1764/
Test FAILed.


MS KB4499164 causes RDP Wrapper to fail

Having just installed the latest Microsoft updates I was no longer able to use RDP Wrapper.  I removed all the updates I installed and then tested each one separately...after installing May 14, 2019—KB4499164.  RDP Wrapper would no longer allow multiple user connections on Windows 7 Pro.  Once removed, RDP Wrapper worked again.

Yesterday, my PC, running Windows 10, did install his updates and now I have the same problem.
Searched the given KB number but didn't find it. Probably the number is different on Windows 10 versions.
But same problem, no possibility anymore to connect a second session to the same machine.

Confirm the problem.

Same here.

I newly installed RDPWrap to Win 10 x64 17763.503. I did not work, it did not allow me more than 1 rdp session.
After updating the rdpwrapper.ini file with the 437 and later addions from here it worked:
https://github.com/stascorp/rdpwrap/issues/744#issuecomment-485531249

On Windows 7 Pro Sp1 x64 with the KB4499164 the Version "6.1.7601.24402" is reported and this update for the rdpwrapper.ini file works for me with multiple users:
[6.1.7601.24402] SingleUserPatch.x86=1 SingleUserOffset.x86=1A675 SingleUserCode.x86=nop SingleUserPatch.x64=1 SingleUserOffset.x64=17F26 SingleUserCode.x64=Zero DefPolicyPatch.x86=1 DefPolicyOffset.x86=19E41 DefPolicyCode.x86=CDefPolicy_Query_eax_esi DefPolicyPatch.x64=1 DefPolicyOffset.x64=17CFE DefPolicyCode.x64=CDefPolicy_Query_eax_rdi
I didn't test the x86 Version.

I'm using windows 10 home edition, updated about 3 or 4 days ago, and after update, RDP wrapper doesn't work. maybe KB4497398 and/or KB4499167 affects with this issue.

I tested the proposed solution by modifying the ini file with the one from https://github.com/stascorp/rdpwrap/issues/744 (first topic comment) and I can confirm that it works in my case.

Thank you.
Sent from my iPad
On May 18, 2019, at 12:48 AM, EngelbertAnon<EMAIL_ADDRESS>wrote:
On Windows 7 Pro Sp1 x64 with the KB4499164 the Version "6.1.7601.24402" is reported and this update for the rdpwrapper.ini file works for me with multiple users:
[6.1.7601.24402] SingleUserPatch.x86=1 SingleUserOffset.x86=1A675 SingleUserCode.x86=nop SingleUserPatch.x64=1 SingleUserOffset.x64=17F26 SingleUserCode.x64=Zero DefPolicyPatch.x86=1 DefPolicyOffset.x86=19E41 DefPolicyCode.x86=CDefPolicy_Query_eax_esi DefPolicyPatch.x64=1 DefPolicyOffset.x64=17CFE DefPolicyCode.x64=CDefPolicy_Query_eax_rdi
I didn't test the x86 Version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

fixed, thanks!
I've to copy new ini with:
copy /y rdpwrap.ini "c:\program files\rdp wrapper\rdpwrap.ini"
in an elevated terminal

No file or rdpconf screenshot. It's not clear which version


Compiling a shader with an error causes shader tab of editor to disappear in Godot 3.2.alpha2 but not in 3.1.1.stable

Godot version: 3.2.alpha2.official win64 (Classical)
OS/device including version: Windows 10 Pro, Intel i7-4790K, integrated GPU only (Intel HD Graphics 4600), driver igdkmd64.sys version <IP_ADDRESS>58
Issue description: When the shader editor is open and the shader is compiled with an error, the Shader tab of the editor disappears. This did not happen in 3.1.1.stable, so it appears to be a regression.
Steps to reproduce:
In a new project, create a Node2D with a ColorRect child node with a ShaderMaterial with the following shader:
shader_type canvas_item;
render_mode unshaded;

void fragment() {float a=0.0;}

Play the project, nothing exciting, no problem.
Now, in the shader editor, change float a=0.0 to float a=0 and play the project again. As expected, this has caused an error. However, what is unexpected is that the Shader tab at the bottom of the editor has disappeared. Before the error, there were tabs for Output, Debugger, Audio, Animation, and Shader, but, after the error, there is no Shader tab.  The Shader tab also sometimes (but not always?) disappears after fixing a shader error and recompiling.
Minimal reproduction project:
Godot Bug Report 5.zip

Seems like the Shader resource gets folded in the inspector, which closes the Shader Editor. It is possible to keep it open when the error appears, but the behavior seems somewhat confusing.

CC @Chaosus @bojidar-bg


Update ios-install.md

Removed Duplicate steps on enhanced Anti-phishing capabilities,

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/7382

@mjcaparas Please merge this PR. Thanks


Optimize dbt execution on commands other than test

Fix for https://github.com/EqualExperts/dbt-unit-testing/issues/56
//Sorry for delay with this one

Hi @SOVALINUX, we think that the dbt select option should be enough as you mentioned. And thank you very much for your tip on the flags.WHICH, it can be handy sometime in the future 😄

Hi
Not sure I understand your point. Do you see any cases where it's harmful? Cause it by default improves performance of all commands where you don't need to run unit tests. But closing it looks for me like comment "we don't care about performance"

Hi @SOVALINUX
We might have underestimated it. Our rationale was since the users have the control with 'select' and 'exclude', we don't need to do it on our side.
Let me have another conversation with @psousa50, and we'll give you an update.
Thank you for the feedback.

Closing due to inactivity and community support for the specific improvement.
Thank you for the collaboration.


Disambiguate between snappy and python-snappy PyPi packages in test warnings.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.