Add dependencies audit

Codecov Report

Merging #38 into master will increase coverage by 1.89%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   93.47%   95.37%   +1.89%
==========================================
  Files           2        2
  Lines         230      238       +8
==========================================
+ Hits          215      227      +12
+ Misses         15       11       -4

Impacted Files
Coverage Δ

src/utils.rs
95.65% <87.50%> (-4.35%)
:arrow_down:

src/parser.rs
95.34% <100.00%> (+2.32%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150e0eb...f2f946c. Read the comment docs.


Interest in a lightweight Cygwin-based installer?

As part of my work for the Corps, I adapted @takluyver's pynsist package and leveraged hashdist to build a lightweight one-click binary installer of the Cygwin operating system to support the usual scipy-stack including the IPython Notebook.
It's an attractive alternative to msysgit in the sense that Cygwin is missing far fewer things (nano, man), but it puts a heavier maintenance burden on the Software Carpentry team.  I'm happy to explain the build system if somebody is interested in trying it out for themselves.  It's been tested on Windows 8 and Windows 7, but is not very well-documented or publicly hosted yet.

I'm reopen this issue after the discussion started at the discuss list, see http://lists.software-carpentry.org/pipermail/discuss/2017-March/005085.html for the first email.

I'm no longer maintaining this project - @embray & @wking are the current folks I believe, but I'll go ahead and reopen this. My concerns about using cygwin in the above comment, most notably (2), still stand.

it would only work for windows 10 64-bit, but there is now support for bash on windows: https://msdn.microsoft.com/en-us/commandline/wsl/about

it would only work for windows 10 64-bit, but there is now support for bash on windows: https://msdn.microsoft.com/en-us/commandline/wsl/about

I think this should definitely be plan for Windows 10 and that we should go ahead and develop those instructions for the installation page. Note that it's not all versions of Windows 10, only new updates, so that may cause some confusion, but it I think it's definitely the long-term direction to head.

We can offer this for Windows 10 users.  I also think a lot of users are still going be on 7 or 8  so we do need to have a working install we can offer.

I also think a lot of users are still going be on 7 or 8 so we do need to have a working install we can offer.

+100 and this will probably continue to be the case for several years.

The easiest way to get people set up with Cygwin is not to create an installer, but just have them download the standard setup exe, and give users the command line options to install everything they need.
For example (would have to be tested and explained more carefully):

go to Cygwin and download the setup_x86_64.exe, https://cygwin.com/install.html
move setup_x86_64.exe to a permanent location in your harddrive such as C:\cygwin
open cmd and switch to the directory.
enter the command setup-x86_64.exe -q -P git,make,sqlite3,wget,ninvaders

After entering the command the installer opens a window with status bars for downloading the package, but it requires no input. It will install Cygwin in the default location, C;\cygwin64

here is the installer's CLI options: https://cygwin.com/faq/faq.html#faq.setup.cli
here is the list of packages: https://cygwin.com/packages/package_list.html

What I like about this option is that it's an existing tool that does what we need, that we don't have to maintain ourselves. It has an existing tool to update and install further packages if necessary.
It is worth mentioning that the version of Nano the current SWC installer adds to Git Bash was compiled using Cygwin (years ago) and ships with the cygwin dll and other utilities to make it work. So in trying to get Nano to work with Git Bash, we are actually installing cygwin in a roundabout way.

@ethanwhite does the SWC installer reset the / path for Git Bash?
You mention the confusion over the weird fake root directory in Cygwin. However, the current default Git for Windows install also creates a fake root and home directory some where in your application files, something like C:\Program Files\Git\mingw64\. If you cd / you end up there.
In a recent intro to Shell workshop I used this difference to explain the Linux file system. I think it's really confusing if not explained to new users, but not a barrier to use since there is differences in the file systems and it will ultimately be just as confusing to have / or /home/ mounted to a Windows equivalent (since the contents will not match the Linux system at all).

@evanwill The issue isn't actually with the root directory, it's with the home directory. A default Git Bash install uses the users home folder C:\Users\username. This means that cd Desktop will take students to a location that all of them are familiar with and this works the same way across all operating systems. In contrast Cygwin creates it's own home directory that doesn't naturally tie in with the basic locations that students are used to thinking about, and it requires that Windows users due something different to get to the common location of the desktop. One of the most common issues that Windows users new to the terminal run into is getting lost in the file system and not understanding where they are and how the terminal relates to the ways they are used to navigating. My experience, and I think it's fair to say our collective experience in experimenting with Cygwin vs Git Bash ~5 years ago was that beginners were less likely to get lost/confused by this when home is in the standard location.

@ethanwhite I was confused by what you were saying (i.e. on Git Bash cd ~ goes to C:\Users\username) because I had only used it on a Windows 7 enterprise system with centrally managed users, and that isn't true on that computer--but I just tested a new install on Windows 10 and confirmed you are correct on a normal Windows setup.
None-the-less, I am not sure the bit of confusion getting started with the "fake root / home" location of cygwin is the deal breaker. That being said, I haven't used cygwin in a workshop, I have always just used default Git Bash when teaching Shell and Git.

One of the things we done in the past to figure out what stacks are best is to run experiments. Develop the full set of instructions/tools for the stack, run some workshops that way, see how the problems are compared to those experienced with the existing stack. That's what lead to the initial switch from cygwin to Git Bash. I'd certainly encourage ongoing experimentation to find the most stable, simple to setup, easy for students to use during the workshops, and easy to maintain stacks as possible.

Short comment for now since I'm on vacation, but FWIW - - I've been working on a Windows version of SageMath based on Cygwin, for which I've made a well-working (so far, based on feedback I've gotten) InnoSetup based installer.
For the most part it just unpacks a pre-made Cygwin installation with all the desires packages installed. It also sets up a directory under C:\Users\<Username> that it mounts as the home directory, with ACL-based permission support, plus a few other settings. I've found through personal experience that making C:\Users\<Username> itself the home directory makes a mess of permission handling. But a directory just under it typically works fine. One can also mount C:\Users\<Username> separately as a subdirectory of their home directory, but that's a bit confusing maybe. Otherwise it really works well.
The one thing I have not tried is mixing Anaconda with Cygwin, and that's the main reason I haven't made any more progress on this yet. But my plan for a while has been to adapt my SageMath installer for a Cygwin-based package for SWC.

In contrast Cygwin creates it's own home directory that doesn't naturally tie in with the basic locations that students are used to thinking about, and it requires that Windows users due something different to get to the common location of the desktop.

As I alluded to above this can be changed freely by customizing /etc/fstab or a user-specific /etc/fstab.d/ file. My SageMath installer has an /etc/profile (IIRC)  that automatically creates the latter if it does not already exist, so that a different path is mounted /home/username when the first log in.


Added SCRIPT_BEFORE_REQUIRED and SCRIPT_AFTER_REQUIRED flags

Added SCRIPT_BEFORE_REQUIRED and SCRIPT_AFTER_REQUIRED flags for error throwing when remote script errors
When new flags are enabled and remote script fails, action will fail.
Addresses #115
usage:
...
      SCRIPT_BEFORE: |
        whoami
        ls -al
      SCRIPT_BEFORE_REQUIRED: true
      SCRIPT_AFTER: |
        whoami
        ls -al
        echo $RSYNC_STDOUT
      SCRIPT_AFTER_REQUIRED: true
...

NOTE: When using SCRIPT_BEFORE/AFTER to run a shell script (e.g. some_script.sh), script should include set -e to fail script when a single command fails so that the exit code is returned. Source

Can't speak to the correctness of this PR, but would like to see this feature merged.

Does this feature work? The SCRIPT_AFTER_REQUIRED key is marked as unexpected in my action.

@leonard-pak Looking at your commit 914... that triggered it. It may be an ordering issue. SCRIPT_AFTER may need to come before SCRIPT_AFTER_REQUIRED would be my best guess here

@leonard-pak  Looking at your commit 914... that triggered it. It may be an ordering issue. SCRIPT_AFTER may need to come before SCRIPT_AFTER_REQUIRED would be my best guess here

I had the same problem
Unexpected input(s) 'SCRIPT_BEFORE_REQUIRED', 'SCRIPT_AFTER_REQUIRED', valid inputs are ['SSH_PRIVATE_KEY', 'REMOTE_HOST', 'REMOTE_USER', 'REMOTE_PORT', 'SOURCE', 'TARGET', 'ARGS', 'SSH_CMD_ARGS', 'EXCLUDE', 'SCRIPT_BEFORE', 'SCRIPT_AFTER']

      - name: Deploy
        uses: easingthemes/ssh-deploy@v4
        with:
          SSH_PRIVATE_KEY: ${{ secrets.SSH_PRIVATE_KEY }}
          ARGS: "-rlgoDzvc -i --delete"
          SOURCE: "./DockerEnv/Infra/"
          REMOTE_HOST: ${{ vars.REMOTE_HOST }}
          REMOTE_USER: ${{ vars.REMOTE_USER }}
          TARGET: ${{ vars.REMOTE_TARGET }}
          SCRIPT_BEFORE: >
            if [ ! -d "${{ vars.REMOTE_TARGET }}" ]; then mkdir -p "${{ vars.REMOTE_TARGET }}"; fi &&
            cd ${{ vars.REMOTE_TARGET }} && whoami && ls -al &&
            if [ -f docker-compose.yml ]; then docker compose down; fi
          SCRIPT_BEFORE_REQUIRED: true
          SCRIPT_AFTER: >
            cd ${{ vars.REMOTE_TARGET }} && whoami && ls -al &&
            chmod +x run.sh && ./run.sh prod &&
            echo $RSYNC_STDOUT
          SCRIPT_AFTER_REQUIRED: true


Keyboard override issue

while using splash screen from this plugin app faces keyboard override issue which don't adjust the screen according to space left after keyboard.
I tried using scroll view but its not working

What is your platform?
Do you mean that your app view should shrink to fit a smaller area when the keyboard appears?  So right now the keyboard covers part of your app?

What is your platform?
Do you mean that your app view should shrink to fit a smaller area when the keyboard appears?  So right now the keyboard covers part of your app?

Yes, after using the splash screen it happens

Yes, after using the splash screen it happens

Same thing happened with me also , i have also opened a issue issue_link

Same thing happened with me also , i have also opened a issue issue_link

Same happens to me, removing the code below in styles.xml located in android/src/main/res/values fixes this issue for me.
 <item name="android:windowFullscreen">true</item>
Solution and detailed issue description can be found here.

Same happens to me, removing the code below in styles.xml located in android/src/main/res/values fixes this issue for me.
 <item name="android:windowFullscreen">true</item>
Solution and detailed issue description can be found here.

Should be resolved by 48981828e831768c4ad89a35475e8f9f24e0aca5.

Should be resolved by 48981828e831768c4ad89a35475e8f9f24e0aca5.


[Enhancements] Consider shipping with a stable version of adapter.js or equivalent

The current samples only work best with chrome, and we had very little success testing with other browsers. One of the solutions we found was using adapter.js to improve cross-browser compatibility. We wonder if it is on the roadmap to improve cross-browser compatibility.

@lherman-cs : good to close this issue?

@lherman-cs : good to close this issue?

Yup


Android - Inconsistent full screen size

Hey,
Using a Nexus 5, Android 6.0 I get varying full screen sizes when opening my game:
Centered 1080x1776

Fullscreen 1080x1920

Bottom 1080x1776 - this one also causes MouseEvent X,Y issues

I'm using OpenFL 4.3.1, Lime 3.3.0 and Android SDK 22
Project's window is set to a fixed size and resizable="false"
It works fine with devices that have physical home buttons, or if I set fullscreen to false, so I guess it's an issue with the immersive mode?

I believe this was fixed when we updated SDL in Lime version 3.4.0, and subsequently in 3.5.0
https://hg.libsdl.org/SDL/rev/f7d8e9d871c5
Please let me know if you're still having issues :smile:


Hitting "Enter" always returns to top of scroll range

Running on Windows 10, Atom 1.19.3, quantum-shell 0.7.1. Every time I hit the enter key, the scroll bar jumps back to the top of the scroll range.

Same to me in OSX Sierra, this bug make unusable this plugin to test my script.

same here on ubuntu

Same here on MacOS 10.14.5, this makes the plugin useless.

Same thing on Arch Linux, Atom 1.49.0 x64.
The bug exists since 2017, will it be fixed?


Try adding a very basic lgtm.yml file, to prevent LGTM complaining about unused variables (issue 11965)

Please note: I cannot be sure if this actually helps, since we've not enabled LGTM for the PDF.js repository[1], however I hope that it should stop LGTM reporting things that we're already using ESLint to enforce.
(Even though we're currently not intending to integrate LGTM here, since #11965 was closed, this patch shouldn't hurt.)

[1] In case the patch does nothing, we can simply revert it and move on :-)

Thanks!


"OSC___ISO_module: Join Meeting" Does Not Resolve Internal Custom Variables

3.0.0+5742-beta-8b7281e3
I've built a 10-key entry screen to input Meeting ID's and Passcode's, and they get saved to Internal:custom variables in Companion. This is in preparation to be able to quickly hit the "Join Meeting" button.
When attempting to launch a meeting in this fashion it appears that the Internal Variables are not resolving before being passed.
I've attached log entries and screenshots.
23:44:14.935 - Info: received message /zoom/joinMeeting "$(internal:custom_MeetingID)" "$(internal:custom_MeetingPW)" "Jeff_ISO "
23:44:14.938 - Info: failed to join meeting with id $(internal:custom_MeetingID) user Jeff_ISO  pass xxxx with error 5

Companion Version 3.0.0 (3.0.0+5764-beta-665fc377)
This is now working. This ticket can be closed.


Possible to transition between multiple layouts?

I'm working on an application right now and would like to use different layouts for when the user is going through Onboarding steps or has completed them and are in the main application.
I noticed the docs have you specify a single MainLayout that will be used throughout the application. Is it possible to use transactions between multiple?
    <Found Context="routeData">
        <LayoutView Layout="@typeof(MainLayout)">
            <TransitionableRoutePrimary RouteData="@routeData" ForgetStateOnTransition="false">
                <TransitionableRouteView DefaultLayout="@typeof(MyViewLayout)" />
            </TransitionableRoutePrimary>
            <TransitionableRouteSecondary RouteData="@routeData" ForgetStateOnTransition="false">
                <TransitionableRouteView DefaultLayout="@typeof(MyViewLayout)" />
            </TransitionableRouteSecondary>
        </LayoutView>
    </Found>

If not, how can we approach using a mix of 'Transitionable' and non-transitionable layouts? One though was to get the page type and see if it implements some ITransitionableLayoutComponent interface through reflection, but wanted to check if there was a way already built-in to handle this.
Your help is much appreciated!

Many thanks for this suggestion. A new scenario indeed. Not sure how animation would suite transitions between different layouts. I will definitely find a solution, hopefully to your clearly defined example, but it may take a little time. Very interested in solving it though. Good news is most solutions end up quite elegant in the end.

Wow, thanks for the quick response! That would be incredibly useful for our use-case. Here's a bit more detail on what we are hoping to accomplish so you have more context:
Our application uses multiple sets of layouts such as AccountLayout / OnboardingWelcomeLayout / OnboardingQuestionLayout depending  on the page a user is on.
Ideally, we would like to be able to provide a transition from OnboardingWelcomeLayout -> OnboardingQuestionLayout after a user clicks a button.

Additionally, it seems right now the transition configuration in App.razor needs to be duplicated multiple times in order to work with multiple layouts. From the consumers perspective, this would be nice to only configure once generically and avoid a nasty switch statement with copy-pasted code.
Is there anything we can do in the meantime to help tackle this? We are very interested in using BlazorTransitionableRoute, hooking into routing seemed to be the most stable/configurable approach.
Thanks!

Here's also an example of the big switch/if-else code we are trying to avoid in App.razor to configure transitions:
            @if (routeData.PageType.IsAssignableFrom(typeof(IAccountPage)))
            {
                // Checking if page is an IAccountPage

                <LayoutView Layout="@typeof(IAccountPage)">
                    <TransitionableRoutePrimary RouteData="@routeData" ForgetStateOnTransition="false">
                        <TransitionableRouteView DefaultLayout="@typeof(TransitionLayout)"/>
                    </TransitionableRoutePrimary>
                    <TransitionableRouteSecondary RouteData="@routeData" ForgetStateOnTransition="false">
                        <TransitionableRouteView DefaultLayout="@typeof(TransitionLayout)"/>
                        </TransitionableRouteSecondary>
                    </LayoutView>

            }
            else if (routeData.PageType.IsAssignableFrom(typeof(IOnboardingPage)))
            {
                // Note: Would like to avoid having to copy-paste this if check for each type

                <LayoutView Layout="@typeof(OnboardingWelcomeLayout)">
                    <TransitionableRoutePrimary RouteData="@routeData" ForgetStateOnTransition="false">
                        <TransitionableRouteView DefaultLayout="@typeof(TransitionLayout)"/>
                    </TransitionableRoutePrimary>
                    <TransitionableRouteSecondary RouteData="@routeData" ForgetStateOnTransition="false">
                        <TransitionableRouteView DefaultLayout="@typeof(TransitionLayout)"/>
                    </TransitionableRouteSecondary>
                </LayoutView>
            }
            else
            {
                // Regular non-transitionable route

                <RouteView RouteData="@routeData" DefaultLayout="@typeof(MainLayout)" />
            }

I found this while searching for a solution, for your reference.
https://github.com/dotnet/aspnetcore/issues/26122
Also general guidance on layouts
https://docs.microsoft.com/en-us/aspnet/core/blazor/layouts?view=aspnetcore-5.0
They may help me identify a solution.

My initial thoughts looking at this are to first consider the nested layouts capability where your layouts would include a @layout yourTransitionableRouteView (in your case TransitionLayout) to specify a containing layout. This would also provide the optimality you need as well as keeping the original behaviour of RouteViews. It could also mean a simplification on the App.razor changes needed for this component library.

Here is the change to App.razor showing the MainLayout being redintroduced back at the RouteView level
<Router AppAssembly="@typeof(Program).Assembly" PreferExactMatches="@true">
    <Found Context="routeData">
        <TransitionableRoutePrimary RouteData="@routeData" ForgetStateOnTransition="true">
            <TransitionableRouteView DefaultLayout="@typeof(MainLayout)" />
        </TransitionableRoutePrimary>
        <TransitionableRouteSecondary RouteData="@routeData" ForgetStateOnTransition="true">
            <TransitionableRouteView DefaultLayout="@typeof(MainLayout)" />
        </TransitionableRouteSecondary>
    </Found>
    <NotFound>
        <LayoutView Layout="@typeof(MainLayout)">

Sorry, there's nothing at this address.

        </LayoutView>
    </NotFound>
</Router>

You can then add @layout TransitionLayout to MainLayout to complete the code changes.  This is following the nested layouts approach from the Blazor documentation.  I am also assuming that not adding the @layout TransitionLayout to your layouts that do not require transitions would result in them being rendered immediately without transitioning.
This does result in my demo full page transitions which may be what you want.  If this is not then you will probably need to move the usages of TransitionableRouteView component into your own pages or layouts.
I hope this will help you with this issue.  Please provide feedback on how it goes so I may close this issue.  Many thanks.

Thank you for the pointer on nested layouts. I was able to get full page transitions working by following your example and by specifying the layout desired on each page. Thank you for the help!

Closing until told otherwise.

One thing to note (not sure if you got this at all on your end), but I did see quite a considerable performance hit when using this full page approach. I spun the example up again with the blazor wasm template and was getting about a 400ms on input to switch back and forth from /count to /fetchdata

Let me know if it becomes an issue.

Using it this way, without using  in app.razor, leaves a one second gap between Loading and render.
Suggestions?


Need some example code

Can you post some example code, especially how to fetch message body? Thanks.

https://github.com/mxk/go-imap/tree/master/imap-demo
https://godoc.org/github.com/mxk/go-imap/imap#example-Client

Thanks for the reply. I got the code run and fetched the subject from the code from your second link. However, the example in the second link does not answer the question how to get the body of the mail.

You should have some understanding of the underlying protocol (RFC 3501) to use this package. The basic idea is that you would fetch "BODY[]" and then parse the response.

Thanks. I finally figured out how to get it by reading RFC 3501. Here is some sample code:
cmd, _ = c.UIDFetch(set, "RFC822.HEADER", "RFC822.TEXT")

// Process responses while the command is running
fmt.Println("\nMost recent messages:")
for cmd.InProgress() {
    // Wait for the next response (no timeout)
    c.Recv(-1)

    // Process command data
    for _, rsp = range cmd.Data {
        header := imap.AsBytes(rsp.MessageInfo().Attrs["RFC822.HEADER"])
        uid := imap.AsNumber((rsp.MessageInfo().Attrs["UID"]))
        body := imap.AsBytes(rsp.MessageInfo().Attrs["RFC822.TEXT"])
        if msg, _ := mail.ReadMessage(bytes.NewReader(header)); msg != nil {
            fmt.Println("|--", msg.Header.Get("Subject"))
            fmt.Println("UID: ", uid)

            fmt.Println(string(body))
        }
    }
    cmd.Data = nil
    c.Data = nil
}

Hi?
When I print the body as shown above it comes in parts that consist of headers and a base64 encoded string...how do I separate the two (headers and base64 encoded string) so that I can decode the contents?


labeler: Fix syntax

I broke it earlier.

Hm, it still errored out, but I think that's because the labeler action doesn't checkout, it runs on git main.


Release Code

Hello，when will you be releasing the code please?

Hi, thanks for your interest in our work. We'll release the code tomorrow.


Updates baseline year 2015 and other years to match PAGE-ICE

I have not updated the data or examples, just the code's representation of years.

To me, all changes seem to be correct.

@jkikstra Thanks for checking!  I may as well merge it in.
Issue #1


Can't debug into GAX NuGet packages

Our .nupkg files contain pdbs, but for some reason I'm not able to step into them in the debugger.
It's possible this is just with local package sources, but we should investigate.

Sample .NET 6 console app - I can't step into RetrySettings.FromConstantBackoff:
using Google.Api.Gax.Grpc;

var ts = TimeSpan.FromMinutes(1);
Predicate<Exception> predicate = ex => false;
var settings = RetrySettings.FromConstantBackoff(10, ts, predicate);
var backoff = settings.NextBackoff(TimeSpan.Zero);

Will investigate other packages we (or I) publish (which may have different settings). Packages to check:

NodaTime
GAPIC libraries
REST support libraries
REST generated libraries
Functions Framework
Event type library (Google.Events.Protobuf)
Protobuf

Interestingly, SourceLink does work when hitting F12 with the cursor on "FromConstantBackoff".
Just tested Noda Time as well with Instant instant = Instant.FromUtc(2022, 9, 16, 0, 0); - same behavior. The debugger just steps over the code. (I have "Just my code" unchecked in the debugging options.)

I can step into Json.NET code. But not:

Google.Protobuf
CloudNative.CloudEvents
Google.Api.Gax.Grpc
Google.Apis.Auth
Google.Apis.Storage.v1
Google.Cloud.Functions.V2
NodaTime

Hmm.

It's possible that this is due to not using Portable PDB files. See https://endjin.com/blog/2022/05/debugging-nuget-packages-understanding-debugging-symbols-and-using-source-link

I've tried publishing with portable PDBs (JonSkeet.DemoUtil) - no joy. It's really unclear to me what's going on here.

Aha - I think the problem is that dotnet build doesn't copy the pdb files into the output directory, and doesn't look for them from the package cache.
I suspect all of this is related to https://github.com/dotnet/sdk/issues/1458, which looks like it enables a workaround via a new project property (CopyDebugSymbolFilesFromPackages=true) but only as of  .NET SDK 7.0.100 RC2. I'm going to test that on my personal machine.
Assuming that doesn't become the default, we might want to consider publishing snupkg files instead, as it looks like that does already work out of the box.

(Ah - 7.0 RC2 isn't out yet. Only 7.0 RC1 is available right now.)

Publishing a snuget package, I can navigate to the code, but I still can't debug into it :(

Retested with .NET 7 and VS 2022 version 17.4.1 - still broken by default.
But, importantly, setting CopyDebugSymbolFilesFromPackages to true does fix this. Hooray! I think we can just document this for now.


Can you pass arrays to templates

Hi,
I understand that we cannot use mixins in this implementation of Jade, so I am trying to use templates, but I have hit a stumbling block.
As you can see here: http://stackoverflow.com/questions/31817073/meteor-passing-array-parameter-to-template I am trying to pass arguments to a template to avoid having to recreate the same code many times.
To do this, I need to be able to pass an array to the template.
Is there anychance that this Jade implementation could help me here? I have tried a number of things but no success so far.
Thanks in advance.
Seb

I know it's probably late to help you with the above, but I might leave some hint for future.
I am searching for the same thing and no luck as well. My workaround is to pass a string (concatenated array) and then split it inside onCreated function.


[SPARK-14440][PySpark] Remove pipeline specific reader and writer

What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/SPARK-14440
Remove

PipelineMLWriter
PipelineMLReader
PipelineModelMLWriter
PipelineModelMLReader

and modify comments.
How was this patch tested?
test with unit test.

Test build #55150 has started for PR 12216 at commit 3c66dd9.

Test build #55150 has finished for PR 12216 at commit 3c66dd9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55150/
Test PASSed.

Merged build finished. Test PASSed.

LGTM. Merged into master. Thanks!


feat(Palindrome Number)

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Improve layout and landing pages for guides

Contributions

[ ] I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates
https://docs.getdbt.com/guides/best-practices and other overview or landing pages under /guides.
What part(s) of the page would you like to see updated?

[ ] There are now three sections with 1 or 2 guides in them (Ecosystem, Advanced and Orchestration). Do we think that this is desirable? Should we try and consolidate?

[ ] ...wonder if we should swap the summary pages out to be the beautiful new cards we put together for the DevHub launch [in the guides directory].
image

To do this, we'd look at how we add these cards to  the Getting Started landing/overview page.
Additional information

Came up in this PR comment

@runleonarun : thank you so much for capturing this! this looks like a great candidate for phase 2 of the Guides project.

hey @runleonarun and @nghi-ly , looks like we can close this out based on the recent changes right? will close this issue but let me know if you think otherwise.


Statistics Calculator

Fixes Issue🛠

Closes #63
Description👨💻
Added a new statistics calculator that can take a dataset and calculate and show the statistics.

Type of change📄

[] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

How this has been tested✅
I tested with various dummy datasets.

Checklist✅

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[] I have commented my code, particularly in hard-to-understand areas
[] I have added demonstration in the form of GIF/video file
[X] I am an Open Source Contributor

Screenshots/GIF📷

Nice, Merged 🎉 @kom-senapati


Not working with latest Appimage

I followed all of the instructions to install this theme on Linux. It does not show up in the Appearance -> Theme dropdown menu. I have installed the required plugin and placed the userchrome.css and userstyle.css files in ~/.config/joplin-desktop.

It doesn't show up in the appearance section. Userchrome and userstyle files are used to override either dark or light themes which are the default installed in Joplin. This theme overrides the dark theme so enable the dark theme to enable this :-)

You may want to mention that in the installation instructions. I will give that a shot.

Sure I will. Thanks for bringing this to my notice!


Expect "text_field" for text fields instead of "text" in remote db

Fixes #759.
@scolsen Could you PTAL?

I'm not sure that I fully understand the root cause of the bug based on reading the issue (am I right in interpreting the problem stemmed from some call to text_field.toUppercase() resulting in the wrong type assignment? (Also wasn't aware of our Enums class and not entirely sure what that does either)), but otherwise the changes are sound on their own and lgtm.


Add support for traits in Query filters

In my particular use case, I would like the ability to be able to use traits in a With<> or Without<> filter in the query.
Example:
pub fn cleanup_status(
    mut commands: Commands,
    q: Query<
        Entity,
        (
            With<PawnStatus<pawn_status::Attacking>>,
            Without<dyn work_order::OrderItem>,
        ),
    >,
) {
}

The above return a compile error because

the size for values of type (dyn OrderItem + 'static) cannot be known at compilation time the trait Sized is not implemented for (dyn OrderItem + 'static)
the trait bound (dyn OrderItem + 'static): bevy::prelude::Component is not satisfied
the following other types implement trait bevy::prelude::Component

The definition for OrderItem is as such:
    #[bevy_trait_query::queryable]
    pub trait OrderItem {}

The desired behavior should be achievable with the results from #55 and #58 . Instead of using the native With and Without filters, you should be able to use WithOne and WithoutOne to get the same result. If I'm missing a case, let me know!

This feature is now supported as of bevy-trait-query v0.6.0!
Please see WithoutAny for details


Request permissions for @car-roll

Description

This PR adds @car-roll as a maintainer for the following repos:

https://github.com/jenkinsci/github-branch-source-plugin
https://github.com/jenkinsci/durable-task-plugin
https://github.com/jenkinsci/workflow-api-plugin
https://github.com/jenkinsci/workflow-basic-steps-plugin
https://github.com/jenkinsci/workflow-cps-global-lib-plugin
https://github.com/jenkinsci/workflow-cps-plugin
https://github.com/jenkinsci/workflow-durable-task-step-plugin
https://github.com/jenkinsci/workflow-job-plugin
https://github.com/jenkinsci/workflow-multibranch-plugin
https://github.com/jenkinsci/workflow-scm-step-plugin
https://github.com/jenkinsci/workflow-support-plugin
https://github.com/jenkinsci/pipeline-graph-analysis-plugin
https://github.com/jenkinsci/pipeline-input-step-plugin
https://github.com/jenkinsci/pipeline-milestone-step-plugin
https://github.com/jenkinsci/pipeline-stage-step-plugin
https://github.com/jenkinsci/pipeline-stage-view-plugin
https://github.com/jenkinsci/workflow-aggregator-plugin
https://github.com/jenkinsci/script-security-plugin
https://github.com/jenkinsci/structs-plugin

CC @dwnusbaum for confirmation from an existing member
Submitter checklist for changing permissions

Always

[x] Add link to plugin/component Git repository in description above

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] All newly added users have logged in to Artifactory at least once

Build failed; the context from the latest run is:
Expand to view
 in 'reader', line 15, column 1:

    ^

 at [Source: java.io.FileReader@41294f8; line: 13, column: 13]
	at com.fasterxml.jackson.dataformat.yaml.snakeyaml.error.MarkedYAMLException.from(MarkedYAMLException.java:27)
	at com.fasterxml.jackson.dataformat.yaml.YAMLParser.nextToken(YAMLParser.java:343)
	at com.fasterxml.jackson.core.JsonParser.nextTextValue(JsonParser.java:723)
	at com.fasterxml.jackson.databind.deser.std.StringArrayDeserializer.deserialize(StringArrayDeserializer.java:99)
	... 38 more
Caused by: while scanning a quoted scalar
 in 'reader', line 14, column 12:
    - "carroll""
               ^
found unexpected end of stream
 in 'reader', line 15, column 1:

    ^

	at org.yaml.snakeyaml.scanner.ScannerImpl.scanFlowScalarSpaces(ScannerImpl.java:1929)
	at org.yaml.snakeyaml.scanner.ScannerImpl.scanFlowScalar(ScannerImpl.java:1845)
	at org.yaml.snakeyaml.scanner.ScannerImpl.fetchFlowScalar(ScannerImpl.java:1029)
	at org.yaml.snakeyaml.scanner.ScannerImpl.fetchDouble(ScannerImpl.java:1011)
	at org.yaml.snakeyaml.scanner.ScannerImpl.fetchMoreTokens(ScannerImpl.java:396)
	at org.yaml.snakeyaml.scanner.ScannerImpl.checkToken(ScannerImpl.java:226)
	at org.yaml.snakeyaml.parser.ParserImpl$ParseIndentlessSequenceEntry.produce(ParserImpl.java:532)
	at org.yaml.snakeyaml.parser.ParserImpl.peekEvent(ParserImpl.java:158)
	at org.yaml.snakeyaml.parser.ParserImpl.getEvent(ParserImpl.java:168)
	at com.fasterxml.jackson.dataformat.yaml.YAMLParser.nextToken(YAMLParser.java:340)
	... 40 more
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Archive)
[Pipeline] archiveArtifacts
Archiving artifacts
[Pipeline] archiveArtifacts
Archiving artifacts
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Terminated

GitHub has been notified of this commit’s build result

ERROR: script returned exit code 1
Finished: FAILURE

Powered by the Comment Logger

No strong opinion. The referenced plugins have multiple maintainers, and I would prefer to have extra sign-offs from them. CC @rsandell @jglick @abayer @svanoort
This request is just another reason why we should add support of teams in this repository


add missing license

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Codecov Report
Patch and project coverage have no change.

Comparison is base (b011f1e) 54.37% compared to head (5b21d07) 54.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   54.37%   54.37%
=======================================
  Files          39       39
  Lines        2457     2457
=======================================
  Hits         1336     1336
  Misses        967      967
  Partials      154      154

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


chore: bdd-spring-1573127620 to 0.0.1

chore: Promote bdd-spring-1573127620 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add a pylint check for line width < 100 characters

@mpharrigan I don't think this exists yet?

#101
The formatter should handle this, no?

As an aside, the Cirq check infrastructure is really good. It would be nice to place it on pypi as cirq-check or something so that libraries like this can import them and sidestep check discussions that Cirq already solved. Of course this is assuming that Qualtran wants to adopt Cirq's style, but this issue is an example that it wants to adopt most of it.

Closing as duplicate and because I think this is low priority


fix(#1946): patients can also be related person

Fixes #1946.
Changes proposed in this pull request:

Current patient cannot show up in related person search

@alti21 I was able to fix the lint errors from master, so no need to worry about those.

Thanks for the contribution @alti21!


How to use with WinForms

Are there any examples of using Chromely with Winforms?

@EliasRenko
No, WinForms, WPF are not supported.
CefGlue has examples of using WinForms.
That may help.


proposal file

For the proposal file, we need to add tables & plots and check the citation, format, etc.

After editing an existing file in the main branch and pushing it, do I just make a new branch again? How can I merge?

wait but it shouldn't be able to push from the main branch. I think it is not possible to merge from jupyter notebook as well. Maybe the only way is to create a new branch from main in github, and copy the changes from your main branch in Jupyter manually to the new branch

oh umm, I got it... kinda... let me make a new branch and upload it there first.


(PUP-4854) Fix acceptance for module_working_dir

A prior commit for PUP-4854 changed the module_working_dir setting
default on Windows, causing the acceptance test to fail. Update the
test.

Passes with win2012r2-rubyx64.yaml, win2003r2x64-rubyx86.yaml, and redhat-7-x86-64.yaml, e.g.
$ bundle exec rake ci:test:aio SHA=54dc8157b0730b6b3f543897af3cd8372f876a45 \
  TESTS=tests/ensure_puppet-agent_paths.rb CONFIG=config/nodes/win2003r2x64-rubyx86.yaml


Add bz2 decompression support with compressjs

We already proved that compressjs works as a bz2 decoder in the rosbag.js tests: https://github.com/cruise-automation/rosbag.js/blob/68526faa242bb76943b6e42fa452f1eadb6cbc73/src/bag.test.js#L175-L178 But it wasn't imported in webviz, so bz2-compressed bags (such as the ones at https://vision.in.tum.de/data/datasets/rgbd-dataset/download#freiburg3_cabinet) didn't work by default.
It was almost very straightforward to add, except that a webpack/AMD module issue (https://github.com/webpack/webpack/issues/5316) prevents us from actually using compressjs in our webpack build. I worked around it by using a string-replace-loader to just remove the offending line. It's a pretty horrible hack, but it works...let me know if you have any better suggestions.

I'm not sure if there's a good structured way to do performance testing on this. But also I think slow bz2 support is probably better than no bz2 support. If you're happy with this without further testing, feel free to merge!

Cool I'll merge this when I also have time to pull this code into our internal version. 👍


ccmlib: stop passing auto_bootstrap

we stopped handling auto_bootstrap since
scylladb/scylladb@3b1ff90 and the behavior is like it's true, so stop passing this setting down.

see also https://github.com/scylladb/scylla-dtest/pull/3769

being tested at https://jenkins.scylladb.com/view/master/job/scylla-master/job/byo/job/dtest-byo/55

This change breaks Java Driver 4.x CI with Cassandra 4.x - in one test node bootstrap starts timing out and now requires a very large timeout (120 seconds)


Lack of multithreading and decorators.

Should separate the UI and connection threads and use a decorator instead of repeating the try/except block.

Fixed said issue with commit #37.


Can't install in L11

Thank you for the work on the package, when I try composer install I get this error, any ideas?
Problem 1
- Root composer.json requires renoki-co/l1 * -> satisfiable by renoki-co/l1[0.1.0].
- renoki-co/l1 0.1.0 requires illuminate/cache ^10.23 -> found illuminate/cache[v10.23.0, ..., v10.48.10] but these were not loaded, likely because it conflicts with another require.
You can also try re-running composer require with an explicit version constraint, e.g. "composer require renoki-co/l1:*" to figure out if any version is installable, or "composer require renoki-co/l1:^2.1" if you know which you need.

There is an open pr to update deps. Maybe @rennokki can check it when he can.
pr: https://github.com/renoki-co/l1/pull/58

thanks @yemilgr and @juliomrqz , has anyone tested D1 speeds in laravel? does it work well with eloquent and json columns?

@nam-co unfortunately i haven't test it, but after reading an article i decided to go with turso instead ;)

same issue facing i'm about to lunch a business and decided with my board to take it
but i'm facing the same issue

@nam-co unfortunately i haven't test it, but after reading an article i decided to go with turso instead ;)

Thanks @yemilgr I probably read the same article, but I believe CF will figure it out and make it better over time, also one strange thing I notice in Turso is that I see one thing on their dashboard and another in TablePlus for example, is not that simple as it seems

abandoned project, not compatible with laravel 11, what a shame


Brave and Chromium giving same ID

I'm using Ubuntu 22
Happening:
When testing on Chromium and Brave browser, both are giving same Identifier
Expecting:
This should return a different unique ID instead of the same one.
Please let me know if you need any further information in this regard.

Try the Usage with local storage option
https://github.com/successtar/browser-signature#usage-with-local-storage-implementation


Broken link for apoplexy

Current link for apoplexy is broken, the correct link is probably:
https://apoplexy.github.io/apoplexysite/
According to archive.org, the domain was suspended due to some verification issue, and now it has been parked by a different operator.
Related: https://github.com/oklemenz/PrinceJS/issues/6

Fixed with #12


Two-factor updates.

First - there are many authenticator apps out there - so change all references to google_authenticator to
simply 'authenticator' - in forms, messages, config. Tested with authy and lastpass.
Put in backwards compat code so that existing DB primary_method entries of 'google_authenticator' should still work.
Second - prior to this change - the QRcode uri was @<service_name>. According
to the passlib docs, and consistent with other sites handling of the uri - this has been changed to full email. The
service_name is sent as the issuer (as it already was). Likely this resulted when we converted to passlib.
This should have no backwards compat issues.
@Kishi85 would appreciate a quick look at this to see if it will cause any backwards compat issues or other thoughts.

Looking good so far, the only issue I can see (and have after testing in one of my applications) is that when the primary login attribute used is 'id' or something else with further customizing, and E-Mail is set to an empty string due to not being set by the user yet the qrcode and anything dependent on the E-Mail attribute will fail. It should respect SECURITY_USER_IDENTITY_ATTRIBUTES in some way or another at that point and use the values defined by the attributes there as E-Mail might not always be the preferred and enabled way to identify a user.

This could be a possible solution for the issue I mentioned before (for qrcode in this case):
diff --git a/flask_security/views.py b/flask_security/views.py
index 6a810b2..ed62afc 100644
--- a/flask_security/views.py
+++ b/flask_security/views.py
@@ -964,8 +964,15 @@ def two_factor_qrcode():
     totp = user.tf_totp_secret
     try:
         import pyqrcode
-
-        url = pyqrcode.create(get_totp_uri(user.email, totp))
+        identity_attributes = config_value("USER_IDENTITY_ATTRIBUTES")
+        if identity_attributes and len(identity_attributes) > 0:
+            primary_attribute = identity_attributes[0]
+        else:
+            primary_attribute = "id"
+        username = getattr(user, primary_attribute)
+        if username is None or len(username) == 0:
+            username = user.id
+        url = pyqrcode.create(get_totp_uri(username, totp))
     except ImportError:
         # For TWO_FACTOR - this should have been checked at app init.
         raise

I like it - the only small thing is that 'id' isn't a user visible field. However - I believe that USER_IDENTITY_ATTRIBUTES must be set to something or else a user can't log in.


Error out if we try to use a release image in a pull request from a fork

I found that this change is somewhat difficult to test. To reproduce the error I would need to use a pull request from a fork, but in that case the workflow changes will be ignored. I was able to confirm that at least this doesn't break existing test runs, though. To fully test this, I likely need to submit it first, and then temporarily add a workflow that tries to use a release image and verify that it fails.

LGTM, but please manually test on a branch to make sure this works :)


[Feature] [BanyanDB] Support field indexing but not stored

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
This is a very special feature of ElasticSearch @wankai123 found from Zipkin using ElasticSearch to save spans.
In saving traces, tags are indexed as query conditions to make users easier to locate important traces, but meanwhile, the whole trace segment is already stored as binary(base64 encoded) in the no-indexing field. So most indexed tags are actually duplicated from the data table perspective.
I hope we could have a way to define a field/column of a table indexing(by different index types) but also not stored. All fields in this type are not allowed in projection clearly because they are stored, OAP could read those values from the binary field directly.
@wankai123 is going to propose this in ElasticSearch storage implementation.
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

As I understood, this is what exactly BanyanBD is doing.
We only duplicate indexed tags which can be used in the projection. In the meanwhile, we store the whole binary data in non-indexed tags.


Problem with CMA acquisition optimizer type

This is probably not an issue but I currently want to try the CMA optimizer with the following search space :
[{'name': 'hidden_layers_number', 'type': 'discrete', 'domain': (1, 2, 3, 4, 5, 6, 7, 8, 9, 10), 'dimensionality': 1}, {'name': 'layers_size', 'type': 'discrete', 'domain': (5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20), 'dimensionality': 1}, {'name': 'activation', 'type': 'categorical', 'domain': (0, 1, 2), 'dimensionality': 1}, {'name': 'alpha', 'type': 'continuous', 'domain': (-8, 0), 'dimensionality': 1}, {'name': 'learning_rate_init', 'type': 'continuous', 'domain': (-8, 0), 'dimensionality': 1}]
However, every time i run "optimize", I get the following error :
CMA does not work in problems of dimension 1.
I went through the code and still doesn't get the problem. Could someone help me?
Thank you!

Please post the stack trace and a minimal example.
For now, CMA-ES does not, indeed, work with problems of dimension 1. Without a systematic investigation, intuition points to eliminating the 'dimensionality':1 entries in each of the dictionaries in your domain definition.

Actually, there is the following part of code in the file GPyOpt/optimization/optimizer.py around line 120:
def CMA_f_wrapper(f):
    def g(x):
        return f(np.array([x]))[0][0]
    return g

Switching return f(np.array([x]))[0][0] to return f(np.array([x]))[0] unlocked the situation for me.

I'll take a look to both of your recommandations and let you know what's going on.
Thank you!


Support three  ^r152 color space

Fixes https://github.com/tentone/geo-three/issues/67
Followed the migration guides:

https://github.com/mrdoob/three.js/wiki/Migration-Guide#151--152
https://discourse.threejs.org/t/updates-to-color-management-in-three-js-r152/50791
https://github.com/mrdoob/three.js/wiki/Migration-Guide#153--154

Hello
Please remove any build related code from the PR.
The build will be later built and published

@tentone , done :)

@tentone build seems to fail under Node 12. I can reproduce this from master too so I don't think is related to this PR.
If you are happy I can bump the Github Action Node version to 16, which seems to work fine. Couldn't test with v14 for some unknown reason.

Thank you code looks good!
Merged!


No way found to test the end to end functionality of a Component

No way found to test the functionality of a Component which uses @angular/core viewContainerRef , elementRef, componentFactoryResolver etc. Document does not specified it completely.
Also raised it before and was closed as code was not provided.
TEST CASE
import {TestBed, async,inject,ComponentFixture} from "@angular/core/testing";
import {HighlightDirective} from "../widgets/contact-widget/highlight.directive";
import {ContactState} from "../widgets/contact-widget/contactstate.component";
import { By }              from '@angular/platform-browser';
import { DebugElement }    from '@angular/core';
import { NO_ERRORS_SCHEMA }          from '@angular/core';
describe('Test a Directive', () => {
let fixture: ComponentFixture;
beforeEach(() => {
return TestBed.configureTestingModule({
declarations: [ContactState],
}).compileComponents().then(() => {
    fixture = TestBed.createComponent(ContactState);
    fixture.detectChanges();
});

});
it('the  tag is yellow',() => {
const de = fixture.debugElement.query(By.css('p'));
const bgColor = de.nativeElement.style.backgroundColor;
expect(bgColor).toBe('yellow');
});
});
COMPONENT
import {Component} from '@angular/core';
declare var module: {
id: string;
};
@Component({
moduleId: module.id,
selector: 'contact-state',
templateUrl: './templates/contactInfo.html'
})
export class ContactState extends CommonStateComponent {
//COMPONENT DATA
constructor(){}
}
TEMPLATE
template content has a p tag which has this directive and the background color is assigned to the p tag contents
PROBLEM
nativeElement of undefined
No way to assign value to elementRef so when running a test case it is undefined so further we test case fails.Similar issue with ViewContainerRef and ComponentFactoryResolver when used somewhere in the component.All test cases given in documentation dont specify any such case where these are used and no way given to resolve them in the test case.

This doesn't help me. You don't have an elementRef anywhere in this example and you aren't saying where the you're getting the nativeElement of undefined.
If you want help, please provide a real reproduction, preferably in plunker, and it absolutely must be small and focused. You have far more going on above than is necessary to make your point.

The elementRef is in HighlightDirective whose code is as given
import { Directive, ElementRef, Input } from '@angular/core';
@Directive(
{
selector: '[myHighlight]'
})
export class HighlightDirective
{
constructor(el: ElementRef) {
el.nativeElement.style.backgroundColor = 'yellow';
}
}

I cant provide you a real reproduction due to some security reasons.

Please explain how your case differs from the example of testing the HighlightDirective in the Testing Guide.
https://github.com/angular/angular.io/blob/master/public/docs/_examples/testing/ts/app/shared/highlight.directive.spec.ts
That has no trouble getting to the native element.
As you can see from that spec, one creates a test component at attaches the directive-of-interest to it. Then create the test component and probe.
If I was interested in the effect of the directive on a real application component, I'd substitute that for the  test component.
What am I missing?

In your case you are defining you template just at the place where you have spec. In my case we are using a place holder and dynamically replacing the templates. When we just run our test case the template is not loded as application has just compiled but not run so template is not ready yet so it don't get its refrence. Anything related to dynamic templates if you can demonstrate.

You realize that in your complaint you did not include the fact that you were dynamically replacing the component (the "component", not the "template", right?).  That's a critical bit of information to have withheld.
To be frank, this is an advanced use case that only a relatively small number of people will need.
That's why I find the title you gave this issue — "No way found to test the end to end functionality of a Component" — particularly irksome. That is simply not true ... as the Testing Guide clearly shows. I will give you the chance to re-title the issue. If you are unable to do so, I will do it for you.
When I have a moment, I'll look into your use case because it interests me. It is not something, however, that we feel deserves high priority and it may not make the guide at all.

We use composite component, where each stage of component is managed by a different template (e.g. something like User registration spanning across 2-3 pages). To take a sample example, a component has three diffrent states(UI stages) i.e in state one it shows a template 1, in state 2 it shows template 2, in state 3 it shows template 3.
Now we use state_mangaement services where we tell it the total no of states and current value of a state for a component during bootstrap and this service register its events.
Code will look like this -

import {Component, ComponentFactoryResolver, ViewContainerRef, OnInit, Injector,Attribute} from '@angular/core';
import {state1} from './state1.component';
import {state2} from './state2.component';
import {state3} from './state3.component';
import {SomeClass} from './someclass.component'; //It has the logic of assigning unique values and managing states
@Component({
template: '<div #placeholder>',
selector: 'common-state',
entryComponents: [state1,state2,state3]
})
export class CommonState extends SomeClass implements OnInit{
constructor(
@Attribute('id') id: string,
@Attribute('Keys') Keys: string,
elementRef?: ViewContainerRef
) {
super(
        id,
        Keys,
        elementRef
     );
}

ngOnInit(){
    super.pushComponent("State1",state1);
    super.pushComponent("State1",state1);
    super.pushComponent("State1",state1);
    super.ngOnInit("State1");
}

}

The supers ngOnInit has the following code
ngOnInit(defaultState:string) {
    this.uniqueId = this.generateUniqueId();
    this.elementRef.element.nativeElement["id"] = this.uniqueId;
    this.changeState({state:defaultState});
}

The state1 component has the following type of code and all three states have similar kind of code
import {Component} from '@angular/core';
@Component({
moduleId:module.id,
selector: 'state-1',
templateUrl: './templates/state1.html',
})
export class State1 {
subsharedstate:any={};
constructor() {
}

//some functions
}
We use the common state selector in a template of one commonStateMainComponent
import {Component} from '@angular/core';
@Component({
moduleId: module.id,
selector: 'service-setup-component',
templateUrl: './templates/commonStateMainComponent.html',
})
export class commonStateMainComponent{
}
CommonStateMainComponent has following template

Now we are using elementRef to check stuff from a specific state but elementRef get its value at run time(when angularjs replace #placeholder with actual state template) and our test spec fails as we are not actually running the application.
So we need some sort of way to get the replaced/updated elementRef value during our test case execution.

A gentle reminder for the same problem, if there is a solution regarding the same or anything more is required by you.

I have no trouble at all getting an instance of the viewContainerRef from within a test.
For example, in the testing sample inside bag.ts I modified the ParentComponent to inject its ViewContainerRef and make it a public property
@Component({
  selector: 'parent-comp',
  template: `Parent(<child-1></child-1>)`
})
export class ParentComponent {
  constructor(public viewContainerRef: ViewContainerRef) {
    const el = viewContainerRef.element.nativeElement as HTMLElement;
  }
}

I modified bag.spec.ts to inspect it.
  beforeEach( async(() => {
    TestBed.configureTestingModule({
      declarations: [ParentComponent, FakeChildComponent]
    })
    .compileComponents();
  }));
 ...
  it('ParentComp should have viewContainerRef', () => {
    const fixture = TestBed.createComponent(ParentComponent);
    fixture.detectChanges();
    expect(fixture.componentInstance.viewContainerRef).toBeTruthy();
  });

The test passes.
You're doing something wrong. It's not Angular's fault or a lack of documentation that stands between you and success. I suggest you simplify and work up from working tests until you discover your error.
This is a place for diagnosed issues. It is not the right forum for implementation questions. StackOverflow might be better.
It's also not a mainstream testing scenario that I feel merits documentation at this time. So I'm closing this comment.


platformio-atom-ide-terminal not working

[ ] I have reset Atom to defaults prior to submitting report.
[ ] I have not reset Atom to defaults prior to submitting report.

Description

Steps to reproduce

Expected behavior:
Actual behavior:
Reproduces how often:
Versions

> atom --version

> apm --version

OS name and version:
Platformio-ide-terminal version:
Additional Information

OS:Linux Ubuntu 20.04 with Deepin Desktop
same issue: platformio-ide-teminal (2.10.0) not working , just blink cursor.
platformio-ide(2.7.1)

apm --version
apm  2.5.0
npm  6.14.5
node 10.20.1 x64
atom 1.49.0
python 3.7.3
git 2.25.1

I used Python 2.7 (>>conda activate py27) and not changed , same issue....

atom --version
atom 1.49.0 x64

electron 5.0.13
chrome 73.0.3683.121
node v12.0.0

I have the same issue.
platformio-ide-teminal (2.10.0)
Ubuntu 18.04.4 LTS

Works well in windows
On Thu, Jul 23, 2020, 12:10 PM nazarlviv07<EMAIL_ADDRESS>wrote:

I have the same issue.
platformio-ide-teminal (2.10.0)
Ubuntu 18.04.4 LTS
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/platformio/platformio-atom-ide-terminal/issues/884#issuecomment-662843576,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIDLWZGVM5SJQJUU7R3II4LR47LOVANCNFSM4PCIWS5A
.

Using Lubuntu 20.04, just install Atom and platformio......... Same problem. Just a flashing cursor and can't type anything

Win10, Atom 1.49, term 2.10.0 - Window rolls up, spinning mouse wheel, nothing happens

I gave up trying to fix this issue between Atom and Platformio with Ubuntu. I don't like to use Windows 10 (even I tested it (atom-platformio) and works fine). I always use linux (Ubuntu 20.04). That I did was change to use VScode IDE and everything was fine working with platformio IDE(2.7.1) and platformio-IDE-Terminal(2.10.0) . So my advise is forget Atom by now in linux.

Yeah, seems like our posts here are going unanswered. Lot's of people having the issue. I just use Idle. My main reason for trying to get Atom working is so I could run code inside a SIMPLE IDE / text editor which Idle does (F5 key and boom!).

Is this abandoned?  Is there a maintained fork?

I don't know. I abandoned Atom and use Idle and PyCharm.

Same problem.
MacOS Catalina 10.15.6 (19G73)
Atom 1.49.0
platformio-ide-terminal 2.10.0

Please try https://github.com/bus-stop/terminus
Fork of platformio-atom-ide-terminal
https://github.com/platformio/platformio-atom-ide-terminal/issues/872#issuecomment-658743370

Same problem here ;(
The terminal tab opens, but no shell terminal appears in the session. I checked already the bash path in the plataformio-terminal settings and it points to /bin/bash in my Atom, as it should.
Atom version
1.49.0
plataformio-atom-ide
2.10.0

The solution I found was to use other terminal package, in this case, terminus. It works well in my machine setup (Ubuntu 18.04 + Atom 1.49.0 + plataformio 2.10.0).
Unfortunately terminus will works as a shadow IT for platformio-terminal unless this issue get solved.

Fixed in https://github.com/platformio/platformio-atom-ide-terminal/releases/tag/v2.10.1
Please update platformio-ide-terminal to the latest version.


Only buffer body when inspecting it

Summary
Right now we are buffering the body no matter we inspect it or not. This is not only an overhead for stream like requests (as we buffer the entire payload instead of streaming it) but also a burden of reading/copying body even when not looking at it.
Relevant: https://github.com/corazawaf/coraza-proxy-wasm/pull/58#discussion_r1012920150

I think it is more relevant to the connectors side rather than the Coraza side. Currently, the library is exporting the body buffers, it is up to the connectors to populate them in a smart way. Isn't it?
Related to it:

Porting this issue coraza-proxy-wasm side.
Opening https://github.com/corazawaf/coraza/pull/499 proposing to add RequestBodyAccessible and ResponseBodyAccessible. Making the connectors aware of these values could permit us to take more conscious decisions about buffering or not.

Still missing the implementation of IsRequestBodyProcessable

Makes sense @fzipi


adding champion xD

c version.
I tested this program on my local machine and it is actually very close to c++.
3.1 milliseconds
But test it yourself on your local machine and then update the results table in the md file

Thanks Ali.


Migrate from JSON to Protobuf as a serialisation format

Protobuf is a much more powerful format than JSON and allows things that JSON doesn't such as NaN values for floats (pre-JSON 5). One difficulty is that it makes ingestion into BigQuery more difficult.

Closing as won't fix


Improve components page

Fix the display of tags (allow wrapping)
Transform fix components category to dynamic (based on the search result)
Add tags filtering in the search result (UI to select tags is still missing)
Categorizing components (not finish)

Yes It can be merged, if the current state of src/pages/components/components.json (categorizations not finished, and a bit opinionated) is not an issue, neither the fact that tags selection is not done yet (I'm working on it).

@kevmodrome There aren't any design for the filter menu, I made this, is it ok?
When hovering the filter button:

When at least one tag is selected (Arrow is blue)

i mean it looks good to me :) definitely super appreciate that you picked up on this when neither of us have made the time yet


Show pass/fail status of declaration answers to Sourcing admins

https://trello.com/c/3AIJtJTX/224-highlight-wrong-answers-in-the-admin-declaration-view

Adds a column showing 'Pass', 'Fail', 'Discretionary' or 'Not Applicable' for each declaration answer. 'Not Applicable' means the answer is not assessed (for example, a supplier can't 'fail' on their contact email address).
Annoyingly the columns don't line up between sections. This is a known issue with this pattern anyway. However the Sourcing team users are not too worried about layout..
The Modern Slavery section contains a single 'multiquestion' type question with several nested questions - only one of these is assessed, so I haven't been particularly strict on how multiple results would be displayed here. Suggestions on a less messy Jinja approach very welcome.

As far as the jinja stuff goes, yeah it's a bit weird having the logic in jinja and we should probably make dmcontent able to do this for us. But for now it will probably do.


Integrate Maxopoly's fixes if appropriate

Regrettably max's changes are largely regressions (removing customization of message labels, moving away from plugin.yml-centered command configuration, etc.) so I won't be merging in his changes.
In fact I'll probably wind up just refactoring his release, adding back in the things he removed needlessly while preserving the few things he added that do have some value (UUID instead of string, a few naming convention things, etc. -- marginally adding CivModCore is an improvement although I'm not convinced.)


Failed to compile atom :TypeError: Incorrect value of args option

I'm on arch and I've tried many ways including installing from user repository , removing atom nodejs npm and again installing it, building it from source ,even I reinstalled my os still giving me same error.
first I thought may be node version and atom versions ar conflicting so I downgraded node and rebuild it but did not work.
then I try to build a older version of atom with older version of nodejs and it worked but above 1.11.* are not working.
Can you reproduce the problem in safe mode?

[x] Are you running the latest version of Atom?
[x] Did you check the debugging guide?
[ ] Did you check the FAQs on Discuss?
[x] Are you reporting to the correct repository?
[ ] Did you perform a cursory search to see if your bug or enhancement is already reported?

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.
Description
[Description of the bug or feature]
Steps to Reproduce

[First Step] Download source code from https://github.com/atom/atom.git
[Second Step] install all the dependencies and Prerequisites
[Third Step] try to script/build

Expected behavior: [What you expected to happen]
``child_process.js:145
throw new TypeError('Incorrect value of args option');
^
TypeError: Incorrect value of args option
at Object.exports.execFile (child_process.js:145:11)
at Object.exports.exec (child_process.js:108:18)
at Object. (/home/d-leo/gitty/atom/apm/node_modules/atom-package-manager/script/postinstall.js:10:16)
at Module._compile (module.js:573:32)
at Object.Module._extensions..js (module.js:582:10)
at Module.load (module.js:490:32)
at tryModuleLoad (module.js:449:12)
at Function.Module._load (module.js:441:3)
at Module.runMain (module.js:607:10)
at run (bootstrap_node.js:382:7)`
Actual behavior: [What actually happened]
Versions
You can get this information from executing atom --version and apm --version at the command line. Also, please include the OS and what version of the OS you're running.

This looks like a duplicate of https://github.com/atom/apm/issues/636. Feel free to subscribe there for updates.

thankx @Ben3eeE