Change the output of the artefact check test

The previous version suggested that you:

regenerate the checksums
run the test again
commit all the changes

However, as the test does a git status and checks for empty output you
actually have to commit the changes before you re-run the test, otherwise
the changes will still appear in the git status output.  So we change the
output of the test to suggest that you:

regenerate the checksums
commit all the changes
run the test again

Not 100% sure that this change reflects the intention of the test properly as it doesn't seem great that you have to commit a change before the test will pass.

Yo @h-lame. I just tried this locally to try to remind myself of the intention. I modified an ERB template in the check-uk-visa smart-answer and ran the regression tests:
$ RUN_REGRESSION_TESTS=check-uk-visa \
  ruby test/regression/smart_answers_regression_test.rb

Failure:
SmartAnswersRegressionTest#test_: Smart Answer: check-uk-visa should have up to date checksum data.  [test/regression/smart_answers_regression_test.rb:92]:
Expected /Users/chrisroos/Code/alphagov/smart-answers/test/data/check-uk-visa-files.yml to exist and to contain up to date data. Use the checksums:add_files[check-uk-visa] rake task to update it.
Expected: false
  Actual: true

# Update the checksums as prompted
$ bundle exec rake checksums:add_files[check-uk-visa]

# Re-run the regression tests
$ RUN_REGRESSION_TESTS=check-uk-visa \
  ruby test/regression/smart_answers_regression_test.rb

Failure:
SmartAnswersRegressionTest#test_: Smart Answer: check-uk-visa should zzzzzzzzzzz run me last and generate the same set of output files.  [test/regression/smart_answers_regression_test.rb:148]:
Changes in outcome page artefacts have been detected:
 M test/artefacts/check-uk-visa/check-uk-visa.txt

If these changes are expected then re-generate the checksums, re-run the regression test, and commit all the changes.

It makes me wonder whether the message you're modifying in this branch was written before we added the test to verify that the checksums were up to date (i.e. the failure I saw before I was able to see the message you're modifying). And I wonder whether the order of the steps in the message is still correct but that it's confusing because you've probably already updated the checksums (step 1), and run the tests (step 2) by the time you see this message. Maybe the message could read, "If these changes are expected then ensure the checksums are up to date and commit the changes"?
I don't think I've done a very good job of explaining what I mean so please follow-up if you think I might be able to help any further.

@chrisroos / @floehopper thanks for taking a look.  Sorry for dragging you back to smart-answers.
I am pretty sure I did update the checksums first, but as far as I can tell the test won't pass until the changes are committed because of how it's implemented.  @chrisroos what did you have to do to make the test pass?  I am fairly sure you have to commit before the test will pass, but if that's not the case then I can abandon this PR.

You're quite correct that you have to commit the updated artefacts in order to get the tests to pass, @h-lame. Apologies for any confusion.
I think the workflow we were using was something like:

Make a change to a smart answer
Run the tests

Update the checksum data if the tests indicate that they're out of date
Re-run the tests

Use the difference in the regression test artefacts to ensure a) nothing has changed, or b) they've changed as expected
Commit any changes from step 3.
Re-run the tests to ensure that they all pass after committing the changes in step 4.

Having typed that out, I now understand your change to the error message and so am approving this PR.
Sorry it's taken so long to review such a small change!

Thanks @chrisroos !


Fix 3d

fixes 3d, and updates the css on the way.

I actually planned to do this but finally decided to wait until 3D is supported in Desmos API 😅

I actually planned to do this but eventually decided to wait until 3D is supported in Desmos API 😅

oh lol

Do I have to update it every time when it is no longer supported?

the fix, weirdly enough, was to just add a "?" at the end of the url.
the updates are not related to the fix, but I though it would be nice to include them.
Eli also said that the API for 3d will release soon, so hopefully we can switch to that in the near future, avoiding the current somewhat-messy workaround.


[TW#12379] esp_ota_begin() runs into default 5s watchdog on large firmware binaries

hi, i am working on implementing OTA support and ran into this watchdog issue. I think the problem is that erasing the flash of large OTA partitions >1MB (i.e. 1280K) takes longer than 5s and then runs into the watchdog.
This issue can be worked around by increasing the "Task watchdog timeout (seconds)" from default 5s to 10s. So maybe thats good enough of a solution. However, since I dont like to deviate from defaults, I felt I report this back to you.
calling....
err = esp_ota_begin(mpUpdatePartition, OTA_SIZE_UNKNOWN, &mOtaHandle);
leads to...
I (32644) ota: Starting OTA example...
I (32644) ota: Running partition type 0 subtype 17 (offset 0x00290000)
I (32654) ota: Writing to partition subtype 16 at offset 0x150000
Task watchdog got triggered. The following tasks did not feed the watchdog in time:
 - IDLE (CPU 0)
Tasks currently running:
CPU 0: ipc0
CPU 1: IDLE
I (32674) ota: esp_ota_begin succeeded

with almost maximum OTA partition sizes...
# Name,   Type, SubType, Offset,   Size
nvs,      data, nvs,     0x9000,  0x4000
otadata,  data, ota,     0xd000,  0x2000
phy_init, data, phy,     0xf000,  0x1000
factory,  app,  factory, 0x10000,  1280K
ota_0,    app,  ota_0,   ,         1280K
ota_1,    app,  ota_1,   ,         1280K
data, 	  data, fat,  ,            192k

Hope that helps,
Best,
FG

Hi @flyinggorilla ,thank for your report,yes, it should let IDLE task feed task WDT,this is a loop in functions "spi_flash_erase_range", add a "vTaskDelay" in the loop will fix your issue,I think @igrr can give a perfect solution about it.

if (rc == ESP_ROM_SPIFLASH_RESULT_OK) {
for (size_t sector = start; sector != end && rc == ESP_ROM_SPIFLASH_RESULT_OK; ) {
spi_flash_guard_start();
if (sector % sectors_per_block == 0 && end - sector > sectors_per_block) {
rc = esp_rom_spiflash_erase_block(sector / sectors_per_block);
sector += sectors_per_block;
COUNTER_ADD_BYTES(erase, sectors_per_block * SPI_FLASH_SEC_SIZE);
} else {
rc = esp_rom_spiflash_erase_sector(sector);
++sector;
COUNTER_ADD_BYTES(erase, SPI_FLASH_SEC_SIZE);
}
spi_flash_guard_end();
}
}

It gives this error even when i try upload blink code via OTA

@blmhemu  as @tzxespressio mentioned, adding a vTaskDelay(1) inside the loop where you call esp_ota_write() should fix this problem.
It's worth noting that the Task Watchdog is (in default config) not fatal, so even though these warnings are printed the OTA should complete OK.
You can also adjust the Task Watchdog timeout in menuconfig (under Component Config -> ESP32-Specific Config) up from 5 seconds to a larger number. It's firing because the OTA process is monopolising the system while writing to flash. It probably won't happen if you're not on a high speed connection like a LAN, where packets are coming faster than they can be written to flash - meaning the task is constantly starting a new write, and never pausing.
All this said, it's still a bug we plan to fix so the default configuration doesn't print this error.
That said, it's still a bug

@liuzfesp please take a look (regarding wifi: pp.c 3125)

Im working with example ota right now and im not having issues with flashing 1,5MB app over internet.

Since this is a very old issue, I'm going to close it. Please feel free to reopen it if your problem is still unsolved. Thanks.


Guidance for using built-in components & helpers

I was playing around with this and ran into some cases where I wanted to use built-in helpers & components that I wasn't sure how to handle.
Built-in helpers
Trying to use the {{get}} helper but I wasn't sure where to import them from, if that's even possible yet.
Error in the devtools console if you try to use without importing it from somewhere:
opcode-compiler.js:499 Uncaught Error: Attempted to resolve a component or helper in a strict mode template, but that value was not in scope: get

Built-in components
Another case that came up was trying to use the built-in <LinkTo /> component. I tried import Link from '@ember/routing/link-component'; but that didn't seem to work, resulting in the following build error:
Build Error (broccoli-persistent-filter:Babel > [Babel: ember-octable]) in ember-octable/components/octable.js

/Users/ekelly02/code/open-source/ember-octable/ember-octable/components/octable.js: Attempted to invoke a component that was not in scope in a strict mode template, `<LinkTo>`. If you wanted to create an element with that name, convert it to lowercase - `<linkto>`:

|
|  <LinkTo @route="index">Foo</LinkTo>
|

(error occurred in 'an unknown module' @ line 7 : column 14)

This section of the strict-mode RFC covers both keywords and built-in helpers and components. In the case of built-in helpers and components, they will need to be imported, and referred to directly. Currently the imports have not been implemented, there is a PR out for adding them to the imports transform: https://github.com/ember-cli/ember-rfc176-data/pull/364
For the second case, the import should have worked because Link was exposed. Note that you have to import it with the same name that you use it with in your component, this would not work:
import Link from '@ember/routing/link-component';

<template>
  <LinkTo @route="index">Foo</LinkTo>
</template>

But this would:
import Link from '@ember/routing/link-component';

<template>
  <Link @route="index">Foo</Link>
</template>

You can name the component anything you want, strict mode templates don't care. It can be lower case, upper case, any valid JS identifier 😄
If it's still not working, then there may be a bug.

@pzuraq Thanks for the info, that makes sense.
I did try to use the link-to component again, making sure that the local name matched up and still couldn't get it to work.
import Component from '@glimmer/component';
import Link from '@ember/routing/link-component';
import { hbs } from 'ember-template-imports';

export default class TestComponent extends Component {
  static template = hbs`
    <Link @route="index">Test</Link>
  `;
}

So for the time being, we're actually completely rewriting Ember 2.27 to remove the modules API polyfill 😄 so that may fix this issue, we'll see. If it does not, we should definitely look into it, but if it does, I'd like to avoid trying to figure out what the ordering issue is, Babel plugin ordering is really very difficult to address

I'm not sure if this is the same issue, but I am getting a similar error with the 'on' modifier here: https://github.com/junyper/ember-playground/blob/main/app/components/button/index.js#L24
Is there any way to work around this?

How does one import {{on}}?

Here are all the imports: https://github.com/emberjs/rfcs/pull/496/files#diff-f1be2bfd87e50eff6f90cff8cf7ab910631693a7fa6bbc03bcae794824fd3a7eR477

Can we add these to the range, or a link to this section?

Yea, I'll put up a PR

PR: https://github.com/ember-template-imports/ember-template-imports/pull/27

Nice


fix: move ts to devDependencies

Description
Moving ts-node and typescript to devDependencies

I have no idea why the integration tests fails

@laat looks like random timeout, I rerun it
@magicmatatjahu can you have a look at this PR please

TS is needed to run hooks and nunjucks's filters written in Typescript, so it is a dependency and not a devDependency. Identically with the ts-node.


handle PIN with special characters for fido2luks-0.2.19

since my pin is containing special characters which printf will fail to process and pipe i fixed it with a small change in the script to use echo instead.
Also currently the skfde-cred script will not be working with >fido2luks-3 since the argument --pin-source was removed (for /dev/stdin)
//I also fixed that in the Rust code, so it's possible to pipe input, but it still needs to go through a review to ensure it's correct.

It might be necessary to adjust that for other skfde scripts as well since printf is used everywhere


Got error white coverting to IR using mo.py

I downloaded yolo-v4-tiny.weights and converted to pb using provided script. But got error in the next step:-
Model Optimizer version:
[ ERROR ]  Exception occurred during running replacer "TFYOLOV3" (<class 'extensions.front.YOLO.YoloV3RegionAddon'>): TensorFlow YOLO V3 conversion mechanism was enabled. Entry points "detector/yolo-v4/Reshape, detector/yolo-v4/Reshape_4, detector/yolo-v4/Reshape_8" were provided in the configuration file. Entry points are nodes that feed YOLO Region layers. Node with name detector/yolo-v4/Reshape doesn't exist in the graph. Refer to documentation about converting YOLO models for more information.
Please help

Hi @tarunmcom
That's because you still use yolov4.json.Please use yolo_v4_tiny.json instead

Hi @tarunmcom
That's because you still use yolov4.json.Please use yolo_v4_tiny.json instead

I have encounter a similiar error.when i use the yolo_v4_tiny.json,I got
[ ERROR ]  Exception occurred during running replacer "TFYOLOV3" (<class 'extensions.front.YOLO.YoloV3RegionAddon'>): TensorFlow YOLO V3 conversion mechanism was enabled. Entry points "detector/yolo-v4-tiny/Reshape, detector/yolo-v4-ti
ny/Reshape_4" were provided in the configuration file. Entry points are nodes that feed YOLO Region layers. Node with name detector/yolo-v4-tiny/Reshape doesn't exist in the graph. Refer to documentation about converting YOLO models fo
r more information.
thanks for your help!

@su26225
So which model are you using?
YOLOv4 or YOLOv4-tiny

I use yolov4-tiny.weights,after the train of darknet

So which model are you using?
I use yolov4-tiny.weights,after the train of darknet

@su26225
So which model are you using?

I use yolov4-tiny.weights,after the train of darknet

@su26225
check the .pb model you are using
The error means the .pb model isn't  converted by your yolov4-tiny.weights
OR you can list all commands here

This is the cammands I used:
./darknet detector train /data2/subo/darknet-master/build/darknet/x64/data/obj.data cfg/yolov4-tiny-custom.cfg /data2/subo/darknet-master/yolov4-tiny.weights -map
python convert_weights_pb.py --class_names cfg/coco.names --weights_file yolov4-tiny-custom_last.weights --data_format NHWC
python "C:\Intel\openvino_2021.3.394\deployment_tools\model_optimizer\mo.py" --input_model frozen_darknet_yolov4_model.pb --transformations_config yolov4.json --batch 1 --reverse_input_channels
If I use the yolov4.json,I will get the error:
[ ERROR ]  Cannot infer shapes or values for node "detector/yolo-v4/Conv_23/biases".
[ ERROR ]  Attempting to use uninitialized value detector/yolo-v4/Conv_23/biases
[[{{node _retval_detector/yolo-v4/Conv_23/biases_0_0}}]]
[ ERROR ]
[ ERROR ]  It can happen due to bug in custom shape infer function <function tf_native_tf_node_infer at 0x0000014FFAA861E0>.
[ ERROR ]  Or because the node inputs have incorrect values/shapes.
[ ERROR ]  Or because input shapes are incorrect (embedded to the model or passed via --input_shape).
[ ERROR ]  Run Model Optimizer with --log_level=DEBUG for more information.
[ ERROR ]  Exception occurred during running replacer "REPLACEMENT_ID" (<class 'extensions.middle.PartialInfer.PartialInfer'>): Stopped shape/value propagation at "detector/yolo-v4/Conv_23/biases" node.
For more information please refer to Model Optimizer FAQ, question #38.

@su26225
check the .pb model you are using
The error means the .pb model isn't converted by your yolov4-tiny.weights
OR you can list all commands here
This is the cammands I used:
./darknet detector train /data2/subo/darknet-master/build/darknet/x64/data/obj.data cfg/yolov4-tiny-custom.cfg /data2/subo/darknet-master/yolov4-tiny.weights -map
python convert_weights_pb.py --class_names cfg/coco.names --weights_file yolov4-tiny-custom_last.weights --data_format NHWC
python "C:\Intel\openvino_2021.3.394\deployment_tools\model_optimizer\mo.py" --input_model frozen_darknet_yolov4_model.pb --transformations_config yolov4.json --batch 1 --reverse_input_channels

If I use the yolov4.json,I will get the error:
[ ERROR ] Cannot infer shapes or values for node "detector/yolo-v4/Conv_23/biases".
[ ERROR ] Attempting to use uninitialized value detector/yolo-v4/Conv_23/biases
[[{{node _retval_detector/yolo-v4/Conv_23/biases_0_0}}]]
[ ERROR ]
[ ERROR ] It can happen due to bug in custom shape infer function <function tf_native_tf_node_infer at 0x0000014FFAA861E0>.
[ ERROR ] Or because the node inputs have incorrect values/shapes.
[ ERROR ] Or because input shapes are incorrect (embedded to the model or passed via --input_shape).
[ ERROR ] Run Model Optimizer with --log_level=DEBUG for more information.
[ ERROR ] Exception occurred during running replacer "REPLACEMENT_ID" (<class 'extensions.middle.PartialInfer.PartialInfer'>): Stopped shape/value propagation at "detector/yolo-v4/Conv_23/biases" node.
For more information please refer to Model Optimizer FAQ, question #38.

@su26225
check the .pb model you are using
The error means the .pb model isn't converted by your yolov4-tiny.weights
OR you can list all commands here

This is the cammands I used:
./darknet detector train /data2/subo/darknet-master/build/darknet/x64/data/obj.data cfg/yolov4-tiny-custom.cfg /data2/subo/darknet-master/yolov4-tiny.weights -map
python convert_weights_pb.py --class_names cfg/coco.names --weights_file yolov4-tiny-custom_last.weights --data_format NHWC
python "C:\Intel\openvino_2021.3.394\deployment_tools\model_optimizer\mo.py" --input_model frozen_darknet_yolov4_model.pb --transformations_config yolov4.json --batch 1 --reverse_input_channels
If I use the yolov4.json,I will get the error:
[ ERROR ] Cannot infer shapes or values for node "detector/yolo-v4/Conv_23/biases".
[ ERROR ] Attempting to use uninitialized value detector/yolo-v4/Conv_23/biases
[[{{node _retval_detector/yolo-v4/Conv_23/biases_0_0}}]]
[ ERROR ]
[ ERROR ] It can happen due to bug in custom shape infer function <function tf_native_tf_node_infer at 0x0000014FFAA861E0>.
[ ERROR ] Or because the node inputs have incorrect values/shapes.
[ ERROR ] Or because input shapes are incorrect (embedded to the model or passed via --input_shape).
[ ERROR ] Run Model Optimizer with --log_level=DEBUG for more information.
[ ERROR ] Exception occurred during running replacer "REPLACEMENT_ID" (<class 'extensions.middle.PartialInfer.PartialInfer'>): Stopped shape/value propagation at "detector/yolo-v4/Conv_23/biases" node.
For more information please refer to Model Optimizer FAQ, question #38.

python convert_weights_pb.py --class_names cfg/coco.names --weights_file yolov4-tiny-custom_last.weights --data_format NHWC
you didn't add --tiny

@su26225
check the .pb model you are using
The error means the .pb model isn't converted by your yolov4-tiny.weights
OR you can list all commands here

This is the cammands I used:
./darknet detector train /data2/darknet-master/build/darknet/x64/data/obj.data cfg/yolov4-tiny-custom.cfg /data2/darknet-master/yolov4-tiny.weights -map
python convert_weights_pb.py --class_names cfg/coco.names --weights_file yolov4-tiny-custom_last.weights --data_format NHWC
python "C:\Intel\openvino_2021.3.394\deployment_tools\model_optimizer\mo.py" --input_model frozen_darknet_yolov4_model.pb --transformations_config yolov4.json --batch 1 --reverse_input_channels
If I use the yolov4.json,I will get the error:
[ ERROR ] Cannot infer shapes or values for node "detector/yolo-v4/Conv_23/biases".
[ ERROR ] Attempting to use uninitialized value detector/yolo-v4/Conv_23/biases
[[{{node _retval_detector/yolo-v4/Conv_23/biases_0_0}}]]
[ ERROR ]
[ ERROR ] It can happen due to bug in custom shape infer function <function tf_native_tf_node_infer at 0x0000014FFAA861E0>.
[ ERROR ] Or because the node inputs have incorrect values/shapes.
[ ERROR ] Or because input shapes are incorrect (embedded to the model or passed via --input_shape).
[ ERROR ] Run Model Optimizer with --log_level=DEBUG for more information.
[ ERROR ] Exception occurred during running replacer "REPLACEMENT_ID" (<class 'extensions.middle.PartialInfer.PartialInfer'>): Stopped shape/value propagation at "detector/yolo-v4/Conv_23/biases" node.
For more information please refer to Model Optimizer FAQ, question #38.

python convert_weights_pb.py --class_names cfg/coco.names --weights_file yolov4-tiny-custom_last.weights --data_format NHWC --tiny

python "C:\Intel\openvino_2021.3.394\deployment_tools\model_optimizer\mo.py" --input_model frozen_darknet_yolov4_model.pb --transformations_config yolov4.json --batch 1 --reverse_input_channels
This is also wrong
python "C:\Intel\openvino_2021.3.394\deployment_tools\model_optimizer\mo.py" --input_model frozen_darknet_yolov4_model.pb --transformations_config yolo_v4_tiny.json --batch 1 --reverse_input_channels

python convert_weights_pb.py --class_names cfg/coco.names --weights_file yolov4-tiny-custom_last.weights --data_format NHWC --tiny

I got it . I used the convert_weights_pb.py in branch of v4-tiny-3l , it doesn't have the flag.tiny.
Howevey , when i changed to use convert_weights_pb.py in master
python convert_weights_pb.py --class_names cfg/coco.names --weights_file yolov4-tiny-custom_last.weights --data_format NHWC --tiny
python "C:\Intel\openvino_2021.3.394\deployment_tools\model_optimizer\mo.py" --input_model frozen_darknet_yolov4_model.pb --transformations_config yolo_v4_tiny.json --batch 1 --reverse_input_channels
I got the error :
[ ERROR ]  Cannot infer shapes or values for node "detector/yolo-v4-tiny/Conv_20/biases".
[ ERROR ]  Attempting to use uninitialized value detector/yolo-v4-tiny/Conv_20/biases
[[{{node _retval_detector/yolo-v4-tiny/Conv_20/biases_0_0}}]]
[ ERROR ]
[ ERROR ]  It can happen due to bug in custom shape infer function <function tf_native_tf_node_infer at 0x0000018D46807510>.
[ ERROR ]  Or because the node inputs have incorrect values/shapes.
[ ERROR ]  Or because input shapes are incorrect (embedded to the model or passed via --input_shape).
[ ERROR ]  Run Model Optimizer with --log_level=DEBUG for more information.
[ ERROR ]  Exception occurred during running replacer "REPLACEMENT_ID" (<class 'extensions.middle.PartialInfer.PartialInfer'>): Stopped shape/value propagation at "detector/yolo-v4-tiny/Conv_20/biases" node.
For more information please refer to Model Optimizer FAQ, question #38.
sorry to bother you again!

python convert_weights_pb.py --class_names cfg/coco.names --weights_file yolov4-tiny-custom_last.weights --data_format NHWC --tiny

I got it . I used the convert_weights_pb.py in branch of v4-tiny-3l , it doesn't have the flag.tiny.
Howevey , when i changed to use convert_weights_pb.py in master
python convert_weights_pb.py --class_names cfg/coco.names --weights_file yolov4-tiny-custom_last.weights --data_format NHWC --tiny
python "C:\Intel\openvino_2021.3.394\deployment_tools\model_optimizer\mo.py" --input_model frozen_darknet_yolov4_model.pb --transformations_config yolo_v4_tiny.json --batch 1 --reverse_input_channels
I got the error :
[ ERROR ]  Cannot infer shapes or values for node "detector/yolo-v4-tiny/Conv_20/biases".
[ ERROR ]  Attempting to use uninitialized value detector/yolo-v4-tiny/Conv_20/biases
[[{{node _retval_detector/yolo-v4-tiny/Conv_20/biases_0_0}}]]
[ ERROR ]
[ ERROR ]  It can happen due to bug in custom shape infer function <function tf_native_tf_node_infer at 0x0000018D46807510>.
[ ERROR ]  Or because the node inputs have incorrect values/shapes.
[ ERROR ]  Or because input shapes are incorrect (embedded to the model or passed via --input_shape).
[ ERROR ]  Run Model Optimizer with --log_level=DEBUG for more information.
[ ERROR ]  Exception occurred during running replacer "REPLACEMENT_ID" (<class 'extensions.middle.PartialInfer.PartialInfer'>): Stopped shape/value propagation at "detector/yolo-v4-tiny/Conv_20/biases" node.
For more information please refer to Model Optimizer FAQ, question #38.
sorry to bother you again!

How many classes your custom model has?
you should change number of classes in .json  which has been mentioned in FAQ

How many classes your custom model has?
you should change number of classes in .json which has been mentioned in FAQ

yes,I have changed the number of classes from 80 to 2 , but it still have the error .
I try to run the program in Linux , and then I get the .xml 、 .bin , although I don't know why

How many classes your custom model has?
you should change number of classes in .json which has been mentioned in FAQ

yes,I have changed the number of classes from 80 to 2 , but it still have the error .
I try to run the program in Linux , and then I get the .xml 、 .bin , although I don't know why

python convert_weights_pb.py --class_names cfg/coco.names --weights_file yolov4-tiny-custom_last.weights --data_format NHWC --tiny
you still use coco.names here

you still use coco.names here

I have chaned the content of coco.names . It has only two labels in it .
Now , I am still traped in the step of mo.py.
Should I follow this branch of tiny.3l exactly for deployment , or switch to the master?

It's clear that yolov4 and yolov4-tiny use master branch,yolov4-tiny-3l use tiny-3l branch
And all commands are listed in corresponding README  in detail.
I recommend you download yolov4.weights yolov4-tiny.weights and try official model first.
You should make sure you could run demo first
And then you  only need to change coco.names and .json for custom model.

It's clear that yolov4 and yolov4-tiny use master branch,yolov4-tiny-3l use tiny-3l branch
And all commands are listed in corresponding README in detail.
I recommend you download yolov4.weights yolov4-tiny.weights and try official model first.
You should make sure you could run demo first

Thanks . I have solved this issue through upgrading tensorflow version from 1.15 to 2.0


Safari: SyntaxError: Unexpected token '{'

Hi
Safari 14.1.2
macOS Catalina
kaboom 3000.1.12
using cdn<EMAIL_ADDRESS><script<EMAIL_ADDRESS>/> shows SyntaxError: Unexpected token '{' in the console.
Pease advice.

Weird, I cannot reproduce it. Do you have a full HTML code for me to paste and try?

https://salmon-lesya-53.tiiny.site/

https://salmon-lesya-53.tiiny.site/

You need to load the kaboom(); after you load the lib. Tested on safari mobile.
https://jsfiddle.net/1yxrz4c2/

Your code has another error: the <script> containing kaboom() needs to be put inside <body> instead of <head>, because kaboom() requires document.body. After fixing that, it runs well on my Safari mobile (iOS 16.6.1).
However I'm still unable to reproduce the syntax error you mentioned, which version of iOS are you on?

Updated: https://azure-harriott-9.tiiny.site/
It is not Safari mobile, It is on Desktop
Safari 14.1.2
macOS Catalina


Refactor nexus writer code to work with new versions of nexgen

In nexgen#220, a lot of the module names have been refactored, which means
src/hyperion/external_interaction/nexus/write_nexus.py and src/hyperion/external_interaction/nexus/nexus_utils.py
need to be refactored to reflect this change in order to keep working for versions of nexgen newer than 0.8.7.
Until this is done, we should keep the pinned version to nexgen==0.8.7.

The linked PR updates hyperion so that it will be compatible with a new release of Nexgen


Files greater than 50GB are attempted when uploading to Amazon Cloud Drive

When syncing up to ACD, files larger than 50GB (the limit) are attempted and then fail at completion (after some hours of copying). I think that they should be rejected with an error when discovered in the sync. Each time the sync is attempted the upload is attempted again.
And, thanks for a great utility, I've moved TBs with this tool already!

That is a good idea.  Do you have a link to a doc where Amazon state that 50GB is the limit - I can't seem to find a definitive answer.
Thanks for the suggestion and glad you like rclone!

Well, it's somewhere in the last three days of Googleing to find a good command line sync utility :-)
Here's what I know:
I was using GoodSync initially - a GUI based solution that was throwing errors on large files. I'm running that again to see if I can catch the exact error. I'm also testing a 68GB file on the Amazon Desktop App as well.
Here's the output from rclone at 99% copy complete on a large file of 68GB

Transferring:

                        BackupHistory.tgz: 77% done. avg: 3203.9, cur: 10436.1 kByte/s. ETA: 28m0s

Google Drive/Google Drive backup 2014-10.zip: 99% done. avg: 3549.0, cur: 8952.9 kByte/s. ETA: 20s

2015/11/14 00:42:00 pacer: Rate limited, sleeping for 430.193442ms (1 retries)
2015/11/14 00:42:00 Google Drive/Google Drive backup 2014-10.zip: Received error: HTTP code 500: "500 Internal Server Error", reponse body: {"message":"Internal failure"}

retrying 1/10

Here again after getting to 100% of another large file:

Transferring:

                        BackupHistory.tgz: 100% done. avg: 3678.5, cur: 3038.1 kByte/s. ETA: 0s

Google Drive/Google Drive backup 2014-10.zip: 39% done. avg: 11407.1, cur: 16208.0 kByte/s. ETA: 41m11s

2015/11/14 01:20:35 pacer: Rate limited, sleeping for 552.437724ms (2 retries)
2015/11/14 01:20:35 BackupHistory.tgz: Received error: HTTP code 500: "500 Internal Server Error", reponse body: {"message":"Internal failure"}

retrying 1/10

And again with the first file as it was tried again (some hours later):

Transferring:

                        BackupHistory.tgz: 41% done. avg: 8503.1, cur: 9268.1 kByte/s. ETA: 1h21m22s

Google Drive/Google Drive backup 2014-10.zip: 100% done. avg: 10798.5, cur: 10758.0 kByte/s. ETA: 0s

2015/11/14 02:24:46 pacer: Rate limited, sleeping for 1.579800709s (3 retries)
2015/11/14 02:24:46 Google Drive/Google Drive backup 2014-10.zip: Received error: HTTP code 500: "500 Internal Server Error", reponse body: {"message":"Internal failure"}

retrying 2/10
2015/11/14 02:24:47 acd: Saving new token in config file

It's a lousy error from Amazon!
I'm sorry to give you such a difficult, well, time consuming, issue as it takes a good hour to copy that amount of data.
I'll check back in with the results of the desktop app and GoodSync big file copy to see what they report.
MPT

Update: Amazon Cloud App: It did the same, copied 68GB then, just started again.

Here is the best statement from Amazon that I've found about the 50GB limit
You could use --max-size=50GB on the command line to get rclone to skip these files which would be a workaround.
Rclone can upload files bigger than 10GB but it has a problem downloading them at the moment -  see #204

Update: GoodSync failed to copy up a large file (128GB) with this error:
2015-11-14 13:35:02: == Sync Started by Analyze And Sync Command
2015-11-14 13:35:02: File Systems limited number of parallel threads to 4
2015-11-14 13:35:02: Start only 1 threads, limited by tasks to run
2015-11-14 22:08:31: Copy New '/Users/michael/tmp/bigfile128' -> 'amazoncd://drive.amazonaws.com/test/bigfile128'

ERROR: Copying file: Server says: Bad Request (status code 400): Cannot complete upload
2015-11-14 22:08:32: Reconnected Folders in the main Sync thread after >= 30 min of inactivity
2015-11-14 22:08:34: == Sync Complete. Time: 08:33:32, Speed: 4.3 MB/s, OK: 0, Errors: 1
2015-11-14 22:08:34:

What I can do is put a 50GB max size for transfer in the acd remote.  This will give an error when you try to upload/download a file of that size.  I'd probably control that with a flag --acd-max-size which defaults to 50GB.
To not see the error and have a clean sync you'd need to use the --max-size=50GB command line option (the error it returns could suggest that).
What do you think?
(See also my previous comment)

I'm getting nervous now as, there's supposed to be a 10GB max download size and I've been able to download bigger files and, reading the developer forum indicates that Amazon is constantly working to increase file size limits. Ideally, they should (we should lobby them to) include a max file size indicator in the API so that you can build to that.
Any flag you put in today could be invalidated tomorrow - especially since the Amazon app fails as well, it may be a legitimate bug. Perhaps, if an upload fails with a 500 error at the end, it should be marked and not re-tried - the issue that I had was that rclone would retry again, effectively wasting many hours.
For now, perhaps a warning in the release notes and I'll using your existing  --max-size=50GB flag. Thoughts?

FYI, I found the reference to the 50GB limit - https://github.com/yadayada/acd_cli

Btw. I tried to find the actual maximum today, but didn't find the exact value.
I tested:

50 GiB – 408 and never appeared (same amount of bytes as --max-size 50G)
49 GiB – 408 and never appeared
50 GB (46.566 GiB) – worked (408 and appeared after ~15min)
50 GB + 1 Byte – worked (408 and appeared after ~15min)
50,000 MiB (48.828 GiB) – worked (408 and appeared after ~15min)
50,000 MiB + 1 Byte – worked (408 and appeared after ~15min)

So the actual limit appears to be somewhere between 50 GB and 49 GIB.
I did give up after spending around 600 GB of intra region traffic…

@felixbuenemann nice one. Fancy sending a pull request to adjust the values in 4ce2a84?

Yes, I can do that. I should run at least a second test at the 50 GiB and 49 GiB values, to make sure it wasn't coincidence that those files didn't appear.

I checked with the Mac client and it limits the file size to exactly 50,000 MiB so we should use the same limit. I also had a failed upload when trying rclone copy with a 48.91 GiB file.
I'll open a PR shortly.


IP addresses and range restrictions is out of date

This table is out of date as IPs like <IP_ADDRESS> are now returned
ping vs-ssh.visualstudio.com
Pinging tfsprodeus2su1.eastus2.cloudapp.azure.com [<IP_ADDRESS>] with 32 bytes of data:

IP V4 ranges
IP V6 ranges

<IP_ADDRESS>/24
2620:1ec:4::/48

<IP_ADDRESS>/24
2620:1ec:a92::/48

<IP_ADDRESS>/24
2620:1ec:21::/48

<IP_ADDRESS>/24
2620:1ec:22::/48

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc5a4cfa-aa84-9f0f-55f4-71ec4861c070
Version Independent ID: d621620a-c924-03b1-8b43-f99c33e58bb8
Content: Add IP addresses and URLs to allow list - Azure DevOps
Content Source: docs/organizations/security/allow-list-ip-url.md
Product: devops
Technology: devops-security
GitHub Login: @chcomley
Microsoft Alias: ChComley

Hi @AceHack, Thanks for reaching out. Those IP addresses that you provided are for Azure Front Door to enhance availability and decrease latency. Most customers reach Azure DevOps via the Azure Front Door rather than directly to Azure DevOps devices. See detailed blog here:  https://devblogs.microsoft.com/devops/new-ip-firewall-rules-for-azure-devops/. tfsprodeus2su1.eastus2.cloudapp.azure.com [<IP_ADDRESS>] is our internal device and not the Azure Front Door., hence, you're seeing <IP_ADDRESS> address returned. Please @mention me if you have any further questions. Thank you!

We just need the list of all IP addresses so we can configure our firewall correctly to allow outgoing ssh to only Azure DevOps.

The IP ranges listed don't work because they don't allow us to hit the git repos.

@chcomley

With just the IP addresses listed, we get denied ssh to our git repos from our firewall because DNS is giving us the IP address I showed you.

Hi @AceHack, You can follow the directions here for SSH connections to Git repo. Thanks.

What I'm saying and the reason I created this bug is because those instructions absoutly do not work.  They leave out IP addresses like the ones I mentioned.  This bug should not be closed.  @chcomley This causes firewalls to block talking to ssh.

Hi @AceHack, I've circled back with the PM and they've requested that you submit a support ticket. Please go here, and then select Report a problem.  If you provide a link to this issue in your support request, I can be notified of whether a solution is determined which warrants an article update.  Since this issue isn't resulting in an article update at this time, I'm closing it. Thank you.


Missing Issue Template in Repository

Description:
I noticed that the repository does not have an issue template. Having an issue template can greatly improve the clarity and consistency of issue reports, making it easier for contributors and maintainers to understand and address the problems or feature requests effectively.

@Nishitbaria , you can work on this


Since today, any request gets "Redirected to login page. Use --login."

I have an algo that runs daily to get posts from a select number of accounts with about 1 minute delay between each request.
It has been working for a few months now with any hiccup using version 4.9
Today I first got faced with 'Could not find "window._sharedData" ' error which prompted me to upgrade the library to 4.9.2
Since then, I'm getting "Redirected to login page. Use --login." right away. I have seen it happen a few times in the past for very specific accounts or when I had a too short delay but relaunching the algo would be enough to get over those hiccups.
I would expect to get the posts linked to the account requested
instaPosts = instaloader.Profile.from_username(L.context, club["instagram"]).get_posts()
The "Error" I'm getting is "Redirected to login page. Use --login."
This looks like something systemic, as if Instagram had changed something in their system which is causing this issue.
Is this temporary? Is it due to a change with Instagram? Is there a solution besides logging in?
Thanks in advance

The error message says it all, you have to login to proceed. As a result of fixing the "window._sharedData" error, it is possible that you reach the anonymous limit earlier. See description at #1575 comment in similar context:

The fix partly switches to the iphone json, which maybe brings up other problems like faster reaching the rate limit, but currently no other solution is available.
Downloading without logging in is possible but requests are limited by Instagram. Downloading stories requires to login.

I have had the same issues as of yesterday.
If I use sessionfiles or stay logged in for multiple profile download triggers, no account will download and so I have to use --login for each account and then delete sessionfile for each account after download. And that usually trips out the account and I have to go in and click "this was me" like 10 times on each instances. They asked me to reset my password today. Wish insta would allow you to add trusted ips/connections.
My code is just a bat file that runs each morning.  Cringe if you must, but its on the edge of my ability right now. 1 main bat that deletes the previous session, runs instaloader + an args.txt for each profile, waits 5 mins and then loads the next:
@echo on
del c:\Users(myusername)\AppData\Local\Instaloader\session-(myusername)
instaloader +profile1.txt
TIMEOUT /T 300
del c:\Users(myusername)\AppData\Local\Instaloader\session-(myusername)
instaloader +profile2.txt
TIMEOUT /T 300
del c:\Users(myusername)\AppData\Local\Instaloader\session-(myusername)
instaloader +profile3.txt
TIMEOUT /T 300
...(a bunchmore profiles but you get the jist)
echo off
echo %date%, %time% >> DailyCollector_Lastrun.txt
echo Current date/time is %date%, %time%.
@pause
exit
The text files is for each profile and location on my server where I want things dumped:
--login=(myusername)
--password=(mypassword)
(profile I want)
--no-captions
--no-video-thumbnails
--no-metadata-json
--user-agent="Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36"
--dirname-pattern=//(UNC folder path).

The error message says it all, you have to login to proceed. As a result of fixing the "window._sharedData" error, it is possible that you reach the anonymous limit earlier. See description at #1575 comment in similar context:

The fix partly switches to the iphone json, which maybe brings up other problems like faster reaching the rate limit, but currently no other solution is available.
Downloading without logging in is possible but requests are limited by Instagram. Downloading stories requires to login.

It used to work with having the need to login.
So I did login.
I got to the checkpoint to confirm it was me....and it seemed to work fine but since I didnt need to do any scraping. I stopped it.
When I wanted to restart it, I once again got prompted to the checkpoint but this time, relaunching the scraping, led to another checkpoint....without never being able to get past it. I did try the firefox workaround. Since I run the algo on a remote server, I copied the cookie to it, ran the script which seemed to work fine...but running the procedure still wouldnt work
As things stand right now, and seeing that other users are facing the same issues as I am, it does look like a pretty harduous issue. I'd love to help but I dont think I'm good enough to help out. Hope you guys manage to resolve the issue and if you do, i'd be glad to contribute monetarily.


Would be great also to have a vw2libsvm converter

There is already a libsvm2vw, but sometimes the opposite way (from vw to libsvm and to other formats) is also needed. Suppose I've tried out vowpal wabbit on some dataset, and then decided to learn xgboost on the same dataset. Then having such converter would be very helpful, because xgboost can work with libsvm format directly.

In the most basic case conversion from VW to libsvm only entails removing "|namespacename" between the label and the rest of the row. Generally, I think that one first converts to VW from some other format like CSV, so CSV to libsvm would do the trick.

Not only to remove namespace names, but also to appending them to feature names, i.e. namespacename^featurename:1


Add static builder() methods to builders

Add static builder() methods to classes with nested builders. Affected classes are:

ClusterTopologyRefreshOptions
ClusterClientOptions
ClientOptions
DefaultClientResources
DefaultCommandLatencyCollectorOptions
RedisURI

Deprecate also the default Builder() constructor.

Excluded builder() from RedisURI as it follows a different builder scheme. RedisURI.Builder entrypoints are RedisURI.Builder.redis(…), RedisURI.Builder.socket(…) and RedisURI.Builder.sentinel(…)


[Draft - WIP] Dashboard: Maintain grid item focus on close preview dialog

Summary
Move preview dialog to show up with the grid behind it to allow grid to stay rendered so we keep state around. prevent default on click/enter to open preview. currently returns user to start of grid.
Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

Addresses #4205

Fixed in https://github.com/google/web-stories-wp/pull/4424


Support BLAS-like extensions

BLAS-like extensions,
e.g. mkl_?imatcopy and mkl_?omatcopy in Intel MKL
These functions support copy and transpose matrix.

These would be great to have. Also, would be nice to  have an in-place transpose.

Hi,
Thank you for the suggestion.
Xianyi

MKL's xgemmt is also worth considering. Computing A*diag(x)*A' is really common.


message DATE problem

I am using s22.imap library from NuGet to move messages from source IMAP server to target IMAP server. Everything is working fine except the library sets new/current DATETIME on the destination server instead of the date at the source IMAP.
e.g. message date is 18-Jun-2018 and when I move message on 20th of June then it will set the date as 20-Jun-2018 instead of 18-Jun-2018.
Here is the code.
MailMessage message = sourceIMAP.GetMessage(uid, FetchOptions.Normal, false, folderName);
var isSeen = seenUids.Contains(uid);
targetIMAP.StoreMessage(message, isSeen, folderName);

@haider001, the GetMessage() method does not support setting the date/time of the message.  This would probably be a great feature request.  Even better, you might code up the change and issue a pull request, especially after you see the solution.  ;-)
Until someone implements the feature you need, you will need to use the existing client methods to generate your own IMAP APPEND command.  Luckiliy, it's pretty simple.
The format of the command is defined in RFC 3501.  Here's a link to the page: https://tools.ietf.org/html/rfc3501#page-46
You can look at the implementation of ImapClient.StoreMessage() as a template for your new and improved StoreMessage().  Here is a link to the existing implementation: https://github.com/smiley22/S22.Imap/blob/master/ImapClient.cs#L1270
Notice that smiley22 calls client.SendCommandMessage() at line 1303 with the following string:
tag + "APPEND " + Util.UTF7Encode(mailbox).QuoteString() + (seen ? @" (\Seen)" : "") + " {" + mime822.Length + "}"
It may be a little hard to see, but this string maps to the parts of the APPEND command documented in RFC 3501.  All you need to do is insert a valid date/time string in between the "flag parenthesized list" and the curly bracketed MIME length:
string response = targetIMAP.SendCommandGetResponse(tag + "APPEND " +
        Util.UTF7Encode(foldername).QuoteString() +
        (isSeen ? @" (\Seen)" : "") +
        timestamp +
        " {" + mime822.Length + "}");

Then, all you need to do is generate a valid timestamp from your message.Date() and you are done.  (Of course, you'll need the rest of the code from the implementation from StoreMessage(), but I'm assuming you can do that.)  If it's not clear what you need to do, post a comment.
Now that you've got your new fangled, custom StoreMessage() working, you should see how you can update the existing implementation to add an optional DateTime? timestamp = null parameter to the method so anyone can just call it with message.Date() if they want to preserve the message's timestamp.


[5.9] Revert "[Macros] Set -external-plugin-path when the toolchain is not Xcode"

release/5.9 version of #1359

@swift-ci Please test

@swift-ci Please test Windows


KeeAnywhere extremly slow since w10 2004 ?

Hey,
thx for doing that great tool.
It seems on my pc that keeAnywhere has become very slow since 2004 update.
I unistalled completly keepass the plugin.
Re-installed 2.45 and 1.6.0.
Re configured the access to gDrive, re-authorized access (was very long too, each step).
Still, it takes up to 10 minuts to load the .kdbx from gDrive

I don't have any specific AntiVirus. Just basic default windows 10 configuration.
using keepass + keeAnywhere on other w10 1909 machines, Android. Works like a charm.
dunno if there is anything to do code wise. Hope that will not happen to everyone updating their Windows OS
Regards,
PF

I am also running into the same issue as pfoucray, anyone can help?

I also have the issue, but using KeeAnywhere with OneDrive. Saving/synchronizing the database takes about 6-10 seconds now. It used to be <1 second.

I can confirm the issue on Windows 10 2004 and Google Drive, although I don't know if its' caused by 2004. Saving is terribly slow as I mentioned in #242

I'm on KeePass 64bit ver 2.47, and using Windows 10 Pro Version 20H2 (OS build 19042.746), and still having the same issue.

Releases v2.0.0 today.
Is this problem gone with this update? If not: please re-open this issue.


Add example to Custom configuration doc

Hi,
I've never touched a C file before and it took me quite some time to figure out how to set compilation options in sqlite3.c so maybe adding a short example in the doc could help others.
Something like:
#define SQLITE_DQS 0
#define SQLITE_LIKE_DOESNT_MATCH_BLOBS 1

// ... the rest of the file

I've added an example to the documentation.


Support loading all svgs in a folder

Hey, first of all:
I love this plugin!!
It makes working with SVGs so much better.
Now I have a custom icon set with about 500 icons.
I'd love if I was able to get an array of all the filenames and be able to display the svgs based on the filename directly in the HTML as SVG.
Do you think something like this would be possible?
With Webpack I'd use require.context but with Vite I'm at a loss.
Any advice much appreciated.

This sounds useful. It would require returning multiple components from the same import statement, and since generating a valid unique name for each SVG file might be tricky, I agree it would probably need to return a filename map. I.e.:
import GreenIcons from "src/assets/icons/green/**/*.svg"
returns
export default {
    "tractor.svg": [green tractor component here],
    "house.svg": [green house component here],
    "cars/toyota.svg": [component for the toyota.svg under the cars subdirectory here]
}

You would have to name the component when you register it in your components object, since you wouldn't be able to rely on JavaScript's property shorthand notation.
export default {
  components: { GreenTractor: GreenIcons["tractor.svg"] }
}

This should allow for the option of tree-shaking by importing only specific SVG components, while also allowing you to bundle everything so you can dynamically use them (e.g., <component :is="GreenIcons[currentIconName]">).

I believe this usage is can be done easily with glob and dynamic import() but if you are looking for simpler solution check out that: https://github.com/luxueyan/vite-transform-globby-import
But looks like it not very active and have some issues:

Doesn't work in Windows for now.
Relative path handling doesn't work properly.
Doesn't work with


Use up to date IBM Plex Mono font with box-drawing characters

Update the font IBM Plex Mono to the latest Github version, which also includes the box-drawing unicode characters.
fixes #1256

Update the font IBM Plex Mono to the latest Github version, which also includes the box-drawing unicode characters.
fixes #1256

@Knorrke this is great! However, what do you think about loading it from Google Fonts instead: https://fonts.google.com/specimen/IBM+Plex+Mono? I would like to move towards using Google Fonts, if they are available, so we can have consistent APIs.
Can you push a follow up PR ?


Windows: Fix unit tests parsers\os

Signed-off-by: John Howard<EMAIL_ADDRESS>I'm going through trying to get unit tests running on Windows (make test-unit). There are several packages with compile errors on non-Linux. This fixes pkg\parsers\operatingsystem so that go test on Windows doesn't throw an error

Filename should be operatingsystem_unix_test.go, then you shouldn't need to docstring those tests.

@cpuguy83 Updated

LGTM

LGTM 🐰


Use more stable lookup method for logout element filter

Fixes #126
Considering the tests were already catching this regression (see below), I saw no need to modify them. I'm still unsure as to why I receive an element with label of Log out and others receive Log Out. At first I considered facebook could be sending different content based on country (I'm in Canada), but that turned out not to be the case.
><EMAIL_ADDRESS>test /Users/andyjbas/code/facebook-chat-api
> mocha

  Login:

    1) should log out

  0 passing (6s)
  1 failing

  1) Login: should log out:
     TypeError: Cannot read property 'markup' of undefined
      at src/logout.js:24:31
      at Array.filter (native)
      at src/logout.js:23:42
      at tryCatcher (node_modules/bluebird/js/main/util.js:26:23)
      at Promise._settlePromiseFromHandler (node_modules/bluebird/js/main/promise.js:507:31)
      at Promise._settlePromiseAt (node_modules/bluebird/js/main/promise.js:581:18)
      at Promise._settlePromises (node_modules/bluebird/js/main/promise.js:697:14)
      at Async._drainQueue (node_modules/bluebird/js/main/async.js:123:16)
      at Async._drainQueues (node_modules/bluebird/js/main/async.js:133:10)
      at Immediate.Async.drainQueues [as _onImmediate] (node_modules/bluebird/js/main/async.js:15:14)

I have a quick q about error handling - what is the use case for throwing non error objects over explicitly creating a new Error? The first downside that I noticed was that the mocha done callback will always complain when passed a non error, but also clients will not be receiving consistent err values in their callbacks. For example, when this TypeError, as shown above, is thrown, the client will get an Error, but in a case like this they will get an object.

Thanks for that! To answer your question, we mainly did this so we could support error codes later (and have the flexibility to add anything we want in the object being thrown). We started by throwing errors but those only accept a string as a message, and we needed more fields. The errors codes will help avoiding hacks like this.


Update MethodInvocationHelper.java

Fixes # .
Did you remember to?

[ ] Add test case(s)
[ ] Update CHANGES.txt

We encourage pull requests that:

Add new features to TestNG (or)
Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

private List errorCodes = Arrays.asList("ERR100909", "ERR100");
@Override
public void run(IHookCallBack callBack, ITestResult testResult) {
    callBack.runTestMethod(testResult);
    Throwable t = testResult.getThrowable();
    if (t != null) {
        t = t.getCause();
    }

    boolean shouldFail = (t instanceof LocationBDLException&& errorCodes.contains(((LocationBDLException) t).getErrorCode()));
    if (shouldFail) {
        testResult.setThrowable(null);
        testResult.setStatus(ITestResult.SUCCESS);
    } else {
        testResult.setThrowable(t);
        testResult.setStatus(ITestResult.FAILURE);
    }

}

@Test()
public void test1() throws LocationBDLException {
    throw new LocationBDLException("ERR100", "s", new Throwable());
}

But while calling runTestMethod, It is  catching the exception and setting the error variable in the catch block..
@Override
public void runTestMethod(ITestResult tr) {
try {
invokeMethod(thisMethod, testInstance, parameters);
} catch (Throwable t) {
error[0] = t;
tr.setThrowable(t); // make Throwable available to IHookable
}
}
So even if we are setting the test result as success,
testResult.setThrowable(null);
testResult.setStatus(ITestResult.SUCCESS);
It will throw exception and test is getting failure
protected static void invokeHookable(final Object testInstance, final Object[] parameters,
Object hookableInstance, final Method thisMethod, TestResult testResult) throws Throwable {
Method runMethod = hookableInstance.getClass().getMethod("run",
new Class[] { IHookCallBack.class, ITestResult.class });
final Throwable[] error = new Throwable[1];
IHookCallBack callback = new IHookCallBack() {
  @Override
  public void runTestMethod(ITestResult tr) {
    try {
      invokeMethod(thisMethod, testInstance, parameters);
    } catch (Throwable t) {
      error[0] = t;
      tr.setThrowable(t); // make Throwable available to IHookable
    }
  }

  @Override
  public Object[] getParameters() {
    return parameters;
  }
};
runMethod.invoke(hookableInstance, new Object[] { callback, testResult });
if (error[0] != null) {
  throw error[0];
}

}
So we can  avoid setting error[0] = t; and throwing exception from there class . .

That's strange it doesn't break tests. So I'm not opposed to the change. But it will break the backward compatibility.
private List<String> errorCodes = Arrays.asList("ERR100909", "ERR100");

    @Override
    public void run(IHookCallBack callBack, ITestResult testResult) {
        try {
            callBack.runTestMethod(testResult);
        } catch(Exception e) {
            t = e.getCause();
        }

        boolean shouldFail = (t instanceof LocationBDLException&& errorCodes.contains(((LocationBDLException) t).getErrorCode()));
        if (shouldFail) {
            testResult.setThrowable(null);
            testResult.setStatus(ITestResult.SUCCESS);
        } else {
            testResult.setThrowable(t);
            testResult.setStatus(ITestResult.FAILURE);
        }

    }

    @Test()
    public void test1() throws LocationBDLException {
        throw new LocationBDLException("ERR100", "s", new Throwable());
    }

should have the behavior you expect too.
@krmahadevan I let you take the merge decision.

@juherr -

That's strange it doesn't break tests.

Perhaps there is no tests that is currently checking this ? That perhaps explains why there are no build breakages.

But it will break the backward compatibility.

Perhaps yes. But I guess we should be fine, because this is a new major version.
@sainjalpolys - Thanks for elaborating the issue. Can you please help add a test in test.hook.HookableTest that vets out your change ?
We also would like to ensure that the contributors get credited for their contributions. The usual practice is that, one creates a new issue (or) refers to an existing issue, in the CHANGES.txt file with a reference to the github issue and also the contributors name. I would leave it to you if you would like to go through with that or not.
But as soon as you can please help add a test, we should be able to get this changeset merged.

@sainjalpolys Is my solution working for you?
I found one of my old answers too: https://stackoverflow.com/q/38784823/4234729
@krmahadevan In fact, my surprise is because of the thrown exception is not useful for the internal flow. It means that with or without it TestNG is still working as expected.
I didn't find anything in the documentation or javadoc talking about the expected behavior. So we can decide to apply the change if wanted. I have no opinion about the best choice :)

@Julien
On Sun, Mar 24, 2019 at 6:38 PM Julien Herr<EMAIL_ADDRESS>wrote:

@juherr requested changes on this pull request.
Tests are missing
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cbeust/testng/pull/2040#pullrequestreview-218081037,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZHBDAQtEwStC1xceQn-5EJUjI_S2Te8ks5vZ3i8gaJpZM4cEveW
.

@Julien Herr - Thanks for the follow up..
And Sorry..  your solution doesn't work for me..
On Sun, Mar 24, 2019 at 6:38 PM Julien Herr<EMAIL_ADDRESS>wrote:

@juherr requested changes on this pull request.
Tests are missing
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cbeust/testng/pull/2040#pullrequestreview-218081037,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZHBDAQtEwStC1xceQn-5EJUjI_S2Te8ks5vZ3i8gaJpZM4cEveW
.

@sainjalpolys

And Sorry..  your solution doesn't work for me..

Why? What is the behavior? The exception you removed is supposed to be caught now.


Chapter 8 Updates

I just finished playing chapter 8 and this PR contains a bunch of updates I have for it. It's best to review this PR by looking at each commit in sequential order.
Commit 1 - copy changes and a few style updates similar to previous PRs I've made:

Commit 2 - [building-blocks-5] Fix hashes in the challenge instructions. Prior to this change, the instructions did not match what is in
the pre-loaded code, and what the validation code is looking for.
Commit 3 - [building-blocks-5] Add a default return value to the preloaded code. The user eventually has to change this, but it at least fixes an exception that prevented the user from debugging with console.log() statements.
Commit 4 - [building-blocks-6] Add another custom (JavaScript) error message, this time for an incorrect solution that allows the subsidy to be a fraction of a satoshi. Can't remember how I ended up in this scenario but I think whatever I did, I missed the custom error message that the answer must be of type number. Also a few minor copy updates to this file.
Commit 5 - [building-blocks-7] This challenge is a little buggy. It asks you to make a validateBlock(block) function that, when used on a a list of blocks, prints the hash of the one valid block. It's unusual that this method, not whatever calls it, is responsible for printing the hash of a valid block. However, to change that would require a larger rework. For now, I want to point out that our validation code checks for a specific hash (88fd124d747cde1d8494d589ec6b82ce11356dd869823dfec8e84b111a72bc87) that has been hard coded into building-blocks-7.tsx (validate method on the javascript and python objects).
We tell the user that the validation code will loop through a list of blocks and execute the following if statement on each block. If the block is valid, the hash will be returned:
  if(validateBlock(block)){
    return bhash;
  }

That sample code we provide assumes validateBlock() returns a boolean, but the only requirement given to the user is that validateBlock() prints the hash of the valid block. I propose we update this check to explicitly look for a true boolean, because if validateBlock() returns a string like "peanuts", it would still be truth-y and pass the check.

That addresses the sample validation code provided in the instructions :) The actual validation code is slightly different:
  if(validateBlock(block)){
    console.log(bhash)
  }

In this, all validateBlock() has to do is return something truth-y and the block hash is printed. That "peanuts" example I gave before will pass the validateBlock() check and print the block hash. The validation code will loop over every block, all  the validateBlock() calls will evaluate to true, it will print them all, and the part that compares what is printed  with the hash of the valid block (88fd124d747cde1d8494d589ec6b82ce11356dd869823dfec8e84b111a72bc87) will find what it's looking for and the user will pass the challenge.
In the instructions we tell the user to print the hash of the valid block, so before leaving the validateBlock() method, if the block is valid, the user should print the hash. That means our actual validation code doesn't need to do any printing, it just needs to execute validateBlock(block).
In a follow up PR, I think it would be worthwhile to update this challenge so validateBlock() just needs to return a boolean, and the code that checks the answer can make sure that validateBlock(88fd124d747cde1d8494d589ec6b82ce11356dd869823dfec8e84b111a72bc87) returns true, while false for the other block candidate hashes.

Thanks for taking a look at that! It was one of those things that every time I thought I had the right solution, I noticed something that could have been done better :sob:
I just rebased to fix some conflicts and added that default return 0 statement to the matching Python challenge. I'm not sure if Python coders would run into the same problem I did in JS (I could not log anything until I made the method return something), but I like that the preloaded code for both languages is now consistent.


Allow nested objects to be used in logging context data

Is your feature request related to a problem? Please describe.
It does not appear to be possible to log a data object if that object contains Dart enum values.  For example, I have a data object where the class has been generated by the popular Freezed package, which includes attributes that are enum values.  If I try to log such an object then I get an error:

flutter: [Datadog 🐶⚠ ] ArgumentError when calling logs.info: parameter null could not be properly converted to a supported native type.

Here is a simplified example.
enum PlaceName {
  organisation,
  reception,
}

@freezed
class HomeSettings with _$HomeSettings {
  const factory HomeSettings({
    @Default(PlaceName.organisation) PlaceName placeName,
  }) = _HomeSettings;

  const HomeSettings._();

  factory HomeSettings.fromJson(Map<String, dynamic> json) =>
      _$HomeSettingsFromJson(json);
}

final settings = HomeSettings(placeName: PlaceName.reception);

// This won't work as the settings object contains a enum value
DatadogSdk.instance.logs?.info(
  'example',
  {
    'settings': settings.toJson(),
  },
);

Describe the solution you'd like
Add support for logging of values that can be encoded as JSON.

Hi @scopendo!
I tried to replicate your example and with freezed 2.0.3+1 and json_serializable 6.2.0 this works as expected so long as you do what's listed and convert the object to Json first, since json_serialziable converts those properly to strings.

Generally, anything that is valid JSON will work when passed as an attribute to any call that needs accepts context.
Can you take another look at the Map resulting from your .toJson call and see if there's another possible cause other than the enum? A nested object maybe?

@scopendo Agreed, I will look into that as a separate issue.

It looks like the issue isn't really to do with enums but more to do with nested (freezed) sub-objects.  I'm still to prepare an example, however, I've found a workaround to be encoding and decoding:
Datadog.instance.rum?.addTapAction('setup_done', {
  'settings': jsonDecode(jsonEncode(settings.toJson())),
});

I think this is just a weird behavior of json_serializable that it doesn't actually serialize nested objects by default. Here's a bit more detail:
https://docs.flutter.dev/development/data-and-backend/json#generating-code-for-nested-classes
It looks like if you add:
@JsonSerializable(explicitToJson: true)

above your class is will correctly navigate to children and serialize them to JSON with just the .toJson() call.
Let me know if that works and we can close this issue and I'll open a new one for properly logging these types of errors.

Closing in favor of #149


Add support for interaction terms in ml_linear_regression()

Currently Sparklyr only accepts simple formulas in ml_linear_regression(). Operators such as ':' should be supported following the convention of lm(). SparkR has this functionality. Interaction terms are crucial to econometric modeling and this addition will help pave the way for moving larger econometric analysis into Spark.

I don't mind working on this issue myself if someone wants to reach out to me at daniel.zafar at gmail.com so I can ask questions.

We could expand https://github.com/rstudio/sparklyr/blob/master/R/formulas.R or maybe leverage the Scala code here and here, though I'm guessing there was a reason to not wrap the latter to begin with.
@kevinushey thoughts?

One of the main benefits of having the formula parser live in R code is that we can rely on R's own formula parser (that is, stats::terms()), which would in the future allow us to use arbitrary expressions in formulas.

Ah, so what should be done next?

Unfortunately implementing this will require quite a bit of work yet -- the simplest interim solution would be to just manually generate interaction columns in your dataset, and use those in the model fitting routines.
The overarching issue is that Spark's model fitting routines at their base have no concept of interaction terms; they just have input columns and output columns. This implies that, to support interaction terms, we'd have to:

Generate a new column representing the interaction of the two input columns,
Pass that along to the associated model fitting routine (as a 'feature'),
Make sure we do all the book-keeping correctly in the various downstream methods (summary(), predict(), etc.)

Supporting this really implies having support for features as arbitrary transformations of the input columns. (Aside: since an interaction effect is really just a specialized kind of transformation of two columns, it would make sense to get the general framework right when getting this to work)
We actually already do something like this for categorical variables -- currently, this is done by generating dummy variables for each category (each as a new column in the input dataset) with the related housekeeping; it'd be nice if we could make this all a bit more generic.

Will keep an eye on these: https://issues.apache.org/jira/browse/SPARK-18569?jql=text ~ "r formula"
https://issues.apache.org/jira/browse/SPARK-18570?jql=text ~ "r formula"

This has been implemented in devel. We now use Spark's RFormula interface. https://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.ml.feature.RFormula


[feature] It takes a long time to load All Wallets for the first time. I hope it can be optimized and improved.

What problem does this new feature solve?
It takes a long time to load All Wallets for the first time. I hope it can be optimized and improved.
Describe the solution you'd like
When modal is opened when all wallets is not loaded, wallets will not be updated even after all wallets is loaded.
You need to close modal and then open modal to display all wallets.
When the list is not completely loaded
Three situations occur randomly, very unstable
Use the browser in incognito mode without caching for easy testing
Situation 1:

Situation 2:

Situation 3:

When the list is loaded
The picture below shows the normal display

We start pre-fetching initial data when modal is created, so it is usually in place when user clicks "connect" button. Requests are also cached across cdn, however given that you have custom configuration.
We've been experiencing degraded performance on api today (currently investigating), I think that's why your experience is slow right now. Closing this issue as all optimisations are already in place, you should see better performance as soon as we resolve ongoing issue.


pipelines: streamline codegen

Problem

The source code of Dagger includes some Dagger pipelines
Therefore our CI/CD pipelines sometimes process the source code of Dagger Modules - for example to lint them
This processing sometimes requires invoking Dagger codegen against those modules - the equivalent of dagger develop
So far our pipelines have done this on a case-by-case basis, but that makes the source code harder to read

Solution
We apply a blunt instrument:

all access to the Dagger source code from any part of the pipeline, is gated by DaggerDev.source() which always applies codegen on all dagger modules.
The list of modules is manually maintained for now, but should be made dynamic in a follow-up improvement
This can probably be optimized (not all pipelines that access the dagger source code actually need codegen, but they all trigger it). But for now I propose we pay the slight performance tax (which gets absorbed by caching), for the sake of much-needed simplification. Then we can gradually optimize.

Sorry, my bad, should have reviewed this one first - I left a couple comments in https://github.com/dagger/dagger/pull/7877.
https://github.com/dagger/dagger/pull/7877#discussion_r1678100351

Hm, I'm not sure about switching everywhere to use this - that feels like we're adding extra cost to places that don't actually need it.
Could we instead rename this method to GeneratedSource/SourceGenerated, and then keep Source as before?

I get that we can gradually optimize, but I would rather not add extra performance cost where we don't need it - I would rather we start with a faster pipeline, and then simplify from there.
Mixing up where the generated code is required from I think also adds additional complexity - just by looking at a function, it's not clear if the generated code is actually used or not. It's fine to be longer and more explicit here I think.

I'll add an optional codegen argument to Source()

I get that we can gradually optimize, but I would rather not add extra performance cost where we don't need it - I would rather we start with a faster pipeline, and then simplify from there.
Mixing up where the generated code is required from I think also adds additional complexity - just by looking at a function, it's not clear if the generated code is actually used or not. It's fine to be longer and more explicit here I think.

I'll add an optional codegen argument to Source()

I'll add an optional codegen argument to Source()

Done @jedevc

Now we just have false/true propagated everywhere. Can we either have a private method .source that takes an opts struct for it, so we don't need to explicitly write true/false, or just have a different method for Source/GeneratedSource?

Now we just have false/true propagated everywhere.

Only because  we don't have self calls yet, and Go doesn't have optional arguments. From a Dagger API standpoint this is transparent.

Can we either have a private method .source that takes an opts struct for it, so we don't need to explicitly write true/false, or just have a different method for Source/GeneratedSource?

No, this is a Dagger module so we should design with the Dagger API in mind. When we ship self calls we will be rewarded with code simplification.

I would significantly prefer to have something more readable and then do more refactoring after we actually ship self calls, instead of refactoring in anticipation of a feature that hasn't even really been started.
Users who are looking at dagger to see a good example of how to use it will get confused by the extra booleans hanging around - I understand we will remove them - but in the meantime, I think it just adds verbosity that makes our own dagger module harder to understand and read.
I don't really want to keep debating this though, so approving.

I would significantly prefer to have something more readable and then do more refactoring after we actually ship self calls, instead of refactoring in anticipation of a feature that hasn't even really been started.

OK let me find a way

@jedevc I changed the design, to avoid propagating true/false everywhere. Also fixed the other issue you reported, and rebased on the latest lint fix. This should be all good to go!


Feature/47 visualize latest pitest report

In the ToolWindow in the Tab "Latest Result" you can see the latest pitest result.
I tried to keep the original pitest layout as good as possible.

Now you shouldn't be able to edit the cells anymore. Thanks for pointing that out.


Upgrade rustls

Description
I am working to upgrade to the latest version of rustls in order to not be affected by the security advisory linked below.
https://github.com/rustls/rustls/security/advisories/GHSA-6g7w-8wpp-frhj
Resources

https://users.rust-lang.org/t/how-to-upgrade-break-change-rustls-0-21-to-0-22/103965/3
https://github.com/rustls/rustls/releases/tag/v%2F0.22.0
https://github.com/rustls/pemfile/releases/tag/v%2F2.0.0

Breaking Changes:

Incremented MSRV to 1.60 due to downstream dependency requirement

@gftea All tests passed on my end. Let me know if you would like any changes.

Regarding your comments, I tried what you said but it was constant fighting regarding lifetimes. With the rustls breaking changes it may be difficult to maintain backwards compatibility. I will try again tomorrow and get back to you.
I appreciate your fast review.

Regarding your comments, I tried what you said but it was constant fighting regarding lifetimes. With the rustls breaking changes it may be difficult to maintain backwards compatibility. I will try again tomorrow and get back to you.
I appreciate your fast review.

If there are multiple input reference, you would need to annotate which lifetime to bind

Regarding your comments, I tried what you said but it was constant fighting regarding lifetimes. With the rustls breaking changes it may be difficult to maintain backwards compatibility. I will try again tomorrow and get back to you.
I appreciate your fast review.

If there are multiple input reference, you would need to annotate which lifetime to bind

Thanks for the help. I try to stay away from lifetimes as much as possible. I think I got it working now. I have not run the tests yet, I will later tonight.

CI has clippy error and cargo check also fail in check_msrv

thanks @LockedThread for the changes. CI has clippy error and cargo check also fail in check_msrv, can you fix them?

I fixed the clippy and check_msrv errors. Additionally, I upgraded rustls-pemfile to 2.0.

@LockedThread thank you for taking the time to contribute!

@LockedThread thank you for taking the time to contribute!

I am happy too. This was my first real contribution to an open source rust project, it has been fun.

That is a weird error, it worked for me locally a few days ago... How would you like to proceed? Increment MSRV?

@LockedThread Nice work! it is almost there.
there is a new error regarding rustc version in ci

@LockedThread Thanks for the PR, and I add some fix to CI and lift msrv to 1.64.


done = 0 yields ZeroDivision error

The underlying ProgressBar class in urwid does not handle this case either. Fixing this requires more code and object state than is warranted. If it becomes important can open an issue and PR to fix in underlying class.


Optimisations

I notice there is a lot of room to optimize this module:

I rework all compendiums indexes calls to reduce them and exploiting latest api
I rework random spell scroll generation to avoid loop and indexes calls as much as possible

Result is a good improvement in roll table performance on big tables with multiple draws.

I notice there is a lot of room to optimize this module:

I rework all compendiums indexes calls to reduce them and exploiting latest api
I rework random spell scroll generation to avoid loop and indexes calls as much as possible

Result is a good improvement in roll table performance on big tables with multiple draws.

@Daimakaicho I merged the other pr first, was the other one older?

I did #93 first, but merging would have been easier by merging this one first. On this conflict, ignore createTableFromCompendium() method from this pr.


👏   Switch from structopt to clap for argument parsing

Addresses #190. All the tests are passing and I did some additional manual testing around the verbosity flag, since that one changed the most. Everything seems to work the same as before 👯

Note: this has changed the formatting of the help text slightly. I think it is functionally the same, though I do slightly prefer the aesthetics of the structopt help text. If there's anything specific we'd like to keep about it I can poke around a bit and see what options there are for that. The text-wrapping is the main thing that comes to mind for me. I also like that it printed the version.
before
viceroy 0.3.2
Fastly
Viceroy is a local testing daemon for Compute@Edge

USAGE:
    viceroy [FLAGS] [OPTIONS] <input>

FLAGS:
    -h, --help          Prints help information
        --log-stderr    Whether to treat stderr as a logging endpoint
        --log-stdout    Whether to treat stdout as a logging endpoint
    -V, --version       Prints version information
    -v                  Verbosity of logs for Viceroy. `-v` sets the log level to DEBUG and `-vv` to TRACE. This option
                        will not take effect if you set RUST_LOG to a value before starting Viceroy

OPTIONS:
    -C, --config <config-path>    The path to a TOML file containing `local_server` configuration
        --profiler <profiler>
        --addr <socket-addr>      The IP address that the service should be bound to

ARGS:
    <input>    The path to the service's Wasm module

after
Viceroy is a local testing daemon for Compute@Edge

Usage: viceroy [OPTIONS] <INPUT>

Arguments:
  <INPUT>  The path to the service's Wasm module

Options:
      --addr <SOCKET_ADDR>    The IP address that the service should be bound to
  -C, --config <CONFIG_PATH>  The path to a TOML file containing `local_server` configuration
      --log-stdout            Whether to treat stdout as a logging endpoint
      --log-stderr            Whether to treat stderr as a logging endpoint
  -v...                       Verbosity of logs for Viceroy. `-v` sets the log level to DEBUG and `-vv` to TRACE. This option will not take effect if you set RUST_LOG to a value before starting Viceroy
      --profiler <PROFILER>
  -h, --help                  Print help information

It also now emits escape codes for boldness and yellowness.

Ah sorry @pchickey I pushed a change to add the version option back in and that dismissed your review 😬. I'm done poking at this :)


Implement Admin Dashboard with Forms

Description:
This issue involves creating an admin dashboard with various forms:

Update/Post Vacation Balance Form
Update Set User Vacation Balance Form
Vacation Balance Adjustment Form
Add New Office Form
Add New User Form (or integrate with Auth Issue)
Update User Information

WIP:
Added dashboard layout and set vacations form. However, the date picker in the form has a bug as it increments the dates without removing any of them if they duplicate.

WIP:
All forms are implemented. However, I've faced an issue with update profile API as seen below. Also, added some styling and hints to the forms. There's one bug in the public holidays calendar, will look into it tomorrow.

Work Completed:
Worked on the following:

vacations typo
supervisor -> team lead
update office vacation balance (hide and in the future allow multiple users)
country -> autocomplete
Social insurance shouldn't be required
in Zee superivsisor object Object
the demo issues
routes keeping logging you out

Closed as fixed, please if you notice that the issue still exists open it again.


Correctly populate default property

We weren't correctly populating the property for requestBody
parameters which made some fields with a default being marked as
required.
Signed-off-by: Ruben Aguiar<EMAIL_ADDRESS>

Do you have an example of this? It seems like we could provide nothing and the fields could still be optional (defaulting to undefined)

The issue was that default was not present, so he believe it was required.
Previously LimitPagination was being considered mandatory while now it becomes optional. Forgot to update the tests it probably shows there, 1 sec.

I see, thanks


Add image flag to kpromo pr to allow filtering by images

What type of PR is this?
/kind feature

What this PR does / why we need it:
Allows specifying one or more images that should be promoted in kpromo pr to allow filtering by image. This relies on the pre-existing functionality of GrowManifests and simply exposes the option. It also makes kpromo pr closer to feature parity with cip-mm which will help deprecate cip-mm.
If no image is specified, the default behavior stays the same: all images matching the tag in the project are promoted.
Example PRs opened with this branch:
no image specified: https://github.com/kubernetes/k8s.io/pull/3259
specific images: https://github.com/kubernetes/k8s.io/pull/3262
Which issue(s) this PR fixes:

Fixes #479
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Add image flag to kpromo pr to allow filtering by images

/assign @puerco @justaugustus
/cc @fabriziopandini

ERROR: gcloud crashed (V2DiagnosticException)

hmm that doesn't seem related to my changes 🤔
/retest

Thanks @CecileRobertMichon! looking forward to using to tool in the next CAPI release!


Add Terraform to deploy WIndows system charts onto provisioned Windows clusters added to Rancher

Continuation of https://github.com/rancher/windows/issues/134, we need to be able to add system charts after provisioning a Windows cluster

Probably will tie in with work in https://github.com/rancher/windows/issues/198


chore: maintenanceScheduling diagrams architecture and class diagram

duplicate of https://github.com/TimefoldAI/timefold-solver/pull/459/files


DevOps Automation SIG Meeting - April 20, 2023

Date
Thursday,  March 16 2023 - 12pm ET; 5pm GMT
Untracked attendees

Name
Firm
Comment

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[ ] Convene, roll call, welcome new people
[ ] Approve previous meeting minutes (#79)
[ ] Working Group updates

[ ] Backstage - @cnygardtw
[ ] Automated Change Deployment - @rvema
[ ] OSS Supply Chain Risk Management - @johnmark

[ ] FINOS Hackathon in NYC - any appetite for a Backstage hack session? (#86)
[ ] Review DevOps SIG project board
[ ] Add Items Here
[ ] AOB, Q&A & Adjourn (5mins)

Decisions Made

[ ] Decision 1
[ ] Decision 2
[ ] ...

Action Items

[ ] Action 1
[ ] Action 2
[ ] ...

Zoom info
Join Zoom Meeting

https://zoom.us/j/95521041942?pwd=dHgwREU2TzBsS242ak1zYWZsUW9OUT09
Meeting ID: 955 2104 1942
Passcode: 443820
Find your local number: https://zoom.us/u/aesEqmNODb

Github Repo: https://github.com/finos/devops-automation/
Project Board: https://github.com/orgs/finos/projects/33
Mailing List: Email<EMAIL_ADDRESS>to subscribe to our mailing list

hello!

James McLeod / FINOS


Avoid partial repeats of the generated enum names

Check whether the start of the variant name is equal to the end of the enum name and if so, don't repeat it. For example, ImageFormat::Rgb8 instead of ImageFormat::FormatRgb8.

Originally created during survey of commented code (#377). Actually it appears that this has already been fixed: Format::RGB8
Closing as already solved.


ShirukaWorld.java:168: Implement...

The puzzle 1-4ff6cf4f from #1 has to be resolved:
https://github.com/shiruka/shiruka/blob/b919490cc5126de2137a0d4ad33a00ba94cabc70/src/main/java/net/shiruka/shiruka/world/ShirukaWorld.java#L168-L168
The puzzle was created by Hasan Demirtaş on 20-Apr-21.
Estimate: 10 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 1-4ff6cf4f has disappeared from the source code, that's why I closed this issue.


IFrame Injection UI Improvements

from @dougdeperry:

Bug Description:
E2E injects an iframe into the compose or read message body in order to display signed or encrypted contents. E2E determines when to inject this iframe based on the presence of standard PGP message blocks. For example:
-----BEGIN PGP MESSAGE-----
Charset: UTF-8
Version: Yahoo Mail E2E v0.3.1341
-----END PGP MESSAGE-----
Whenever E2E sees a message block that looks like this it will inject the E2E iframe regardless of whether the message is properly signed or encrypted. If an attacker spoofs the from email address and uses the ‘BEGIN PGP MESSAGE’ in the message body E2E will inject the iframe even if the message contains no legitimately signed or encrypted content. This can give the impression that the message is legitimate which can aide in phishing attacks.
Reproduction Steps:
Send an email with the following text:
-----BEGIN PGP MESSAGE-----
Charset: UTF-8
Version: Yahoo Mail E2E v0.3.1341
This is a legitimate message from Yahoo. Please goto http://www.downloadmymalware.com
-----END PGP MESSAGE-----
See appendix A for a screenshot of the received message.
Mitigation:
If an error is detected during decryption/display, remove the injected iframe and just display the plaintext message contents and/or create a smaller iframe (or one that somehow looks different than the correct one) and display an error message.

Case in point: the github notification for this issue was displayed in a frame. :)
I think in the case where the message is not a well-formed PGP signature, we should not show the iframe. However, if the signature is well-formed but invalid (because the signing key expired, for instance, or yahoo mail backend mangled the message body), maybe the current behavior makes sense. That way, users see an error message with "BAD signature from ..." in the frame, which looks pretty scary.

This is what Doug's test case (invalid message surrounded by valid PGP armor) looks like when rendered in ymail with end-to-end:

Do others think that this doesn't look "different enough" from a valid message? What are some UI suggestions?


Getting Response 400: Bad Request for new list_activity_events function

Describe the bug
New admin.list_activity_events returns BAD RESPONSE 400 error message.
To Reproduce
Steps to reproduce the behavior:

Log into Fabric with an account that as Power BI/Fabric Administrator privileges
Open new Spark Notebook
In first cell, run pip install semantic-link-labs
In new code cell, run the following code block:

  from sempy_labs import admin
  from datetime import datetime, timedelta

  endTime = datetime.utcnow() - timedelta(days=1)
  startTime = endTime - timedelta(days=14)

  startTime = startTime.strftime("%Y-%m-%dT%H:%M:%S")
  endTime = endTime.strftime("%Y-%m-%dT%H:%M:%S")

  print(f"Start Time: {startTime}")
  print(f"End Time: {endTime}")

  df = admin.list_activity_events(start_time=startTime, end_time=endTime)

  df.head(20)

Expected behavior
Data is returned to a pandas dataframe and displayed
Error message returned
FabricHTTPException: 400 Bad Request for url: https://wabi-west-us-redirect.analysis.windows.net//v1.0/myorg/admin/activityevents?startDateTime=%272024-09-30T22:45:43%27&endDateTime=%272024-10-14T22:45:43%27
Headers: {'Cache-Control': 'no-store, must-revalidate, no-cache', 'Pragma': 'no-cache', 'Transfer-Encoding': 'chunked', 'Content-Type': 'application/octet-stream', 'Strict-Transport-Security': 'max-age=31536000; includeSubDomains', 'X-Frame-Options': 'deny', 'X-Content-Type-Options': 'nosniff', 'RequestId': '772d911d-eced-474d-b0cb-e072c3b53b72', 'Access-Control-Expose-Headers': 'RequestId', 'Date': 'Tue, 15 Oct 2024 22:45:43 GMT'}

Desktop (please complete the following information):

OS: Windows 11
Browser: Edge
Version: 129.0.2792.89 (Official build) (64-bit)

Additional context
I noticed that the base url variable in the function definition for list_activity_events probably needs to remove the first character /, however I made that change in a custom defined version of this function and I am still not able to get it to return anything other than this error response.

Please see the example given in the documentation regarding start/end times.
https://semantic-link-labs.readthedocs.io/en/stable/sempy_labs.admin.html#sempy_labs.admin.list_activity_events


Add two packages for Debian

🗣 Description
This pull request adds the python3-distutils and python3-setuptools packages for Debian-based OSs.  These packages no longer get installed automatically as dependencies for Debian Testing (currently Debian Trixie) and therefore not for Kali Linux either.
💭 Motivation and context
This was noticed because of the GH Actions failures that suddenly appeared in cisagov/ansible-role-assessment-tool#55.  See #60 for more details.
🧪 Testing
All automated tests pass.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

Please see commit 1fca4a0.

Thanks for the fix 👍However, please update the README to mirror other changes in this PR around platforms no longer supported:
https://github.com/cisagov/ansible-role-pip/blob/7155d3c43bfcd2c808253036628bc860b5c0f382/README.md?plain=1#L18

Please see commit 1fca4a0.  I will amend cisagov/ansible-role-python similarly tomorrow.


Custom animation inside view

Hello! I'm so interested in your lib, but I've some doubts about it. Transition animations are so cool but I'm also interested in set an animation inside my custom view. I would like to show a screenshot of my app and then show a description changing the alpha value of a TextView. That's easy but I need to know when my view will be shown and then start the animation. So, is there any easy option to notify my fragment when it will appear?
Thanks for all your work.

I just came onto this project so @PaoloRotolo should be able to answer this...I'm still learning all the capabilities of the lib! I'll make sure this gets to him.

@MaSteve the latest version of the library (will be released sometime soon) has support for detecting when the slide is changed. You will be able to override what happens when the slide is changed and I believe this will solve your issue.


Fix: show loaded vendor logo

DESCRIPTION
N/A
USER STORY
As a
Mass Energize campaigns admin user
When I
add a logo to a vendor detail
I want to
see the logo displayed as part of the vendor information
Possible Scenarios
GIVEN
a mass energize campaigns admin user
WHEN
i edit, add and save a vendor logo to a vendor detail/description
THEN
** i should be able to view the vendor logo as part of the vendor information**
Required Permissions
admin users: should be able to edit vendor information, add and view vendor logo.
Acceptance Criteria

[x] vendor logo renders and is displayed as part of vendor information

UX Design
N/A
Technical Considerations
Insert technical considerations

Shouldn't there be a fallback image for the vendors' images?
Cos you can't tell from the image if the __Vendor 19009 is a text for New England Solar Hot Water


[fmt] update to 7.1.1

Describe the pull request

What does your PR fix? Fixes #14354

Which triplets are supported/not supported? Have you updated the CI baseline? No.

Does your PR follow the maintainer guide? Yes.

Thanks for your help!


coreos's etcd container images don't specify appc.io/executor/supports-systemd-notify

The coreos.com/etcd images do not contain the appc.io/executor/supports-systemd-notify annotation even though etcd does support sd_notify.
I'm not sure about the exact effects that this has; it would certainly depend on the container runtime -- with rkt, if you run in a coreos stage1, i.e. with proper namespacing and an intermediary in-container systemd that runs etcd in a dynamically created service unit, it seems that rkt creates that service unit with type=simple rather than type=notify (which would be used if the image declared the annotation properly), which leads to the inner systemd signaling the etcd service readiness "too early", i.e. immediately after the etcd process has been started rather than after it has send sd_notify.
I don't know how the coreos.com/etcd image is built, so I'm not sure how to fix this. If the scripts/build-aci script is used for this, it would be a one-line fix I suppose.

Seems like rkt added sd_notifysupport since 1.15.0? https://github.com/rkt/rkt/blob/master/CHANGELOG.md#1150
Isn't this rkt runtime issue?

appc is deprecated and we shouldn't be adding new features or fixing appc issues: https://github.com/appc/spec#-disclaimer-

@philips Yeah appc is deprecated but that annotation is not, afaict. It's still referenced in the docs: https://coreos.com/rkt/docs/latest/using-rkt-with-systemd.html#managing-pods-as-systemd-services . So if it is deprecated, there's a documentation issue :)

@gyuho I may be wrong, but it seems to be rkt and the container image (etcd in this case) working in concert, as I tried to explain in the ticket: Rkt (stage1-coreos.aci) checks whether the image has that annotation, and if it does, the in-container systemd waits for sd_notify from the container process (which it has wrapped in a dynamically created type=notify service) and when it received it, it passes it on to the host systemd. If the annotation is missing from the image, the container process is wrapped in a type=simple service instead and the host systemd is sd_notified as soon as the container service has started, i.e. potentially before it has sent its sd_notify. And that might be too early.
At least that's what I inferred from skimming the rkt source for half an hour or so.


style: run sqlfluff on action_network models

Ran SQLFluff on Action Network. The only changes im seeing on here are

Remove unused table aliases
Add as keyword when declaring an alias
remove empty lines at end of file

There were some other linting errors that were all of this kind:
 Keywords should not be used as identifiers.
But they were column existing column names that we probably shouldn't change, so i left it as is.

cool! does dbt still run ok without the empty line at the end of the files?

@kanelouise good point! I ran the dbt locally and it ran through successfully so im guessing the line or any of the other changes dont affect it!


Automatic logon with -pw password

See the attached screenshot for more details!

sp version: <IP_ADDRESS> / Windows 7 Pro. SP1

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 23 Nov 2012 at 2:19
Attachments:

sperror.png

Closing this issue but all hope is not lost! We still want to help.
See: https://github.com/jimradford/superputty/wiki/Legacy-Imported-Issues on how to help us to help you!


Too slow :(

The device is awesome. But it's just too slow. You can't run browsers etc on it as it even warns you about the lack of RAM for the job.
Have you tried any other single board computers the same form factor? like Radxa Zero 3 W

That's right, the biggest issue is rpi02w has only 512MB ram, it would be much better if it has 1GB ram. Also, are you running on 64bit OS? I found 32bit OS should be faster on rpi2w and you can try dietpi OS, which is more lightweighted. And for browser I would recommend web browser in terminal like w3m.
Radxa zero3w doesn't support the dpi interface. It's difficult to drive the screen

Does dietPi come in a 32bit flavour? Could not find it anywhere on their website.