[Suggestion] Start, Stop, And Restart Buttons

The title says it all. Can u add them? They would be extremely helpful! Thanks!

As the plugin requires the server to be online to function, a start and restart button likely wouldn't work, unless you've configured a restart server properly.

I don't think the start button wud be possible but i think the restart and stop buttons wud be possible correct?

Restart is only possible if you configure a start.sh or start.bat in the
spigot.yml, or if you have another script checking constantly to see if the
server is down. A stop button is possible, and start is not.
On Sep 29, 2016 7:49 PM, "Muhsinun Chowdhury"<EMAIL_ADDRESS>wrote:

I don't think the start button wud be possible but i think the restart and
stop buttons wud be possible correct?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rymate1234/JPanel/issues/11#issuecomment-250623869,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP_gqWH03cyggjWOKLB4uHXJN08u4Sofks5qvE6igaJpZM4KJdTA
.

A start button is completely impossible, you'd need the JPanel instance to run separately from the server, and as the whole point of JPanel is that it's implemented as a plugin for bukkit I will not be able to add a start button.
As @Bayside308 mentioned, Restarts are only possible if a start.sh or start.bat file is specified in the spigot.yml, and since not all servers will be running on Spigot, creating a restart button that relies on this is not something I intend to do.
There's already a way to stop the server from JPanel - the stop command in the console. If you want admins to be able to stop the server but not run all commands, I have some ideas on how to implement this, specifically a command whitelist so JPanel users can run some, but not all, commands.


使用命令python -m MMSA -d sims -m self_mm运行SIMS数据集报错

raise RuntimeError(
RuntimeError: Failed to import transformers.models.bert because of the following error (look up to see its traceback):
cannot import name '_sentencepiece' from partially initialized module 'sentencepiece' (most likely due to a circular import)

解决办法：把这个sentencepiece的版本降低一个就可以了


Unable to set up

Hi please can anyone help me out with the set up.
Been stuck at "An error has occurred: Could not open file
C:\Users\Administrator\AppData\Local\Temp\RarSFX0\stub\xeno rat
client.exe for reading. Error: 00000003"
And i followed a tut where 1414 port inbound rule was enabled but my rdp have a different port. Could that be the problem?

Hello... I need help to use this rat


Partial Gitpod fix: Add keytar (new Theia dependency)

This PR is only a partial fix because Gitpod breaks in two places right now:

[x]  The build fails because keytar is missing. Fixed by this PR.
[ ]  The frontend fails to connect to the server #488. @bhufmann will propose a solution to this by fixing #493

Details:

Both issues (build fail, server connection fail) aren't present before the Theia version was upgraded.
To observe the fontend not being able to connect to the server on Gitpod, you need to open this PR's branch (the extension doesn't build in Gitpod on the most recent version of master).

Commit a3a4002 "upgrade to Theia 1.17.0" in PR theia-ide#461 upgraded the version
of Theia used by the trace viewer extension. The new version of Theia
now requires keytar. This new dependency is missing in the gitpod setup
so the extension build fails in gitpod.
Update gitpod setup to install keytar (dependency) and fix gitpod
build.
Signed-off-by: Erica Bugden<EMAIL_ADDRESS>

Would it be better to put it in 1 commit ? thanks for your contribution

Would it be better to put it in 1 commit ? thanks for your contribution

The clarification isn't part of installing the package which is why I separated it. I'm in the habit of separating refactor changes from functional changes. Technically the cleanup commit could probably be a different PR, but we'll see what people say.

I was testing this PR and debugging the issue of #493 and I think I understand what happens. After a small hack, I was able to run the trace server successfully in GitPod with your this PR. So, I think this PR is fine and can be merged. I'll provide a proper fix for #493 (not just a hack). @ebugden please update this patch so it's not a draft and ready for review.

I was testing this PR and debugging the issue of #493 and I think I understand what happens. After a small hack, I was able to run the trace server successfully in GitPod with your this PR. So, I think this PR is fine and can be merged. I'll provide a proper fix for #493 (not just a hack). @ebugden please update this patch so it's not a draft and ready for review.

Is it related to this piece of code by any chance ?:
async getTraceServerUrl(): Promise<string> {
    if (!this._traceServerUrl) {
        const traceServerUrl = await this.environments.getValue('TRACE_SERVER_URL');
        this._traceServerUrl = traceServerUrl ? this.parseUrl(traceServerUrl.value || TRACE_SERVER_DEFAULT_URL) : TRACE_SERVER_DEFAULT_URL;
    }
    return this._traceServerUrl.replace(/{}/g, this.port ? this.port : TRACE_SERVER_DEFAULT_PORT);
}

I changed this part of the code which seems to not have the "correct" logic. It loads the TRACE_SERVER_URL only if the default is not defined. In my mind, it should always replace the traceServerUrl if the TRACE_SERVER_URL is defined. So I just removed the if condition.

@ebugden, @arfio  I uploaded a fix to be able to connect to the GitPod server #499. I temporarily added the keytar fix as well so that you can try it.

I'll merge this one and then rebase #499


Add OPFS (Origin Private File System) Support to the Latest Version of duckdb-wasm

Description:
This PR implements OPFS (Origin Private File System) support in the latest version of duckdb-wasm based on PR #1490.
This allows database files to be read and written to the OPFS.
API:
When opening a database file, you can now use the following API:
await db.open({
    path: 'opfs://test.db',
    accessMode: duckdb.DuckDBAccessMode.READ_WRITE,
});
const conn = await db.connect();

Changes:

Added support for OPFS.

Bug Fixes:

Resolved issues related to COPY TO functionality.
Fixed support for signed S3 URLs.

This is very very welcome, thanks.
I am in the process of releasing a new version of duckdb-wasm, connected to duckdb 1.1.0.
Once that is out, I will properly review this PR.

@carlopi
Thank you very much for your update and for taking the time to review this PR.
I look forward to your feedback once the release is out.
Please let me know if there's anything I can assist with in the meantime.

One comment would be if you could have a look at the failing test

@carlopi
I have merged the latest main branch and confirmed that the tests using DuckDB 1.1.1 pass successfully."

Thanks, I gave a proper look, this looks solid, thanks a lot for the contribution.
This PR does introduces some API changes that might be somewhat unexpected, so I think the proper way forward would be:

tag v1.29.0 (later today)
merge this PR / iterate
tag v1.30.0 in the next weeks

@carlopi
Thank you for reviewing my contribution. Regarding the API changes, I will carefully test them after tagging v1.29.0. Please proceed with the work as per your proposed plan. I appreciate your continued support.

@carlopi
I will be using the release version that includes this PR for my work. Therefore, I would like to ask when the PR will be merged. If there is anything I can do to assist with the merge process, please let me know. Thank you for your time and support.

@e1arikawa have you published your release version somewhere accessible while we wait? I'd love to kick the wheels on it in the meantime.

My above FileSystemSyncAccessHandles locking comments aside, the added complexity is totally worth it for the increased speed.
In our test product, using handle.createSyncAccessHandle() + DuckDBDataProtocol.BROWSER_FSACCESS instead of handle.getFile() + DuckDBDataProtocol.BROWSER_FILEREADER reduced one of our large query's execution time from ~32s to 8.6s!
(Querying ~24M records across two joins – won't fit in the browser's 4mb memory limit, so must be read from parquet files in OPFS).

@amiller-gh
Please make these adjustments after this PR has been merged.

@e1arikawa  Would love to make that call, but I'm not a maintainer – just a very interested party :)
Will let the maintainers chime in on the API callouts I made. For all I know the API thrash on registerFileHandler re: directory support and potential opfs:// protocol urls will be okay.
Just calling out though, if this library wants to implement it's own OPFS file access concurrency management down the line, exposing user-land control over FileSystemSyncAccessHandle registration may make this more difficult.

Maybe @carlopi can chime into this discussion? Thanks!

@amiller-gh
I completely understand what you're getting at.
However, this PR is simply to enable the use of OPFS.
If there are concerns, perhaps we can address them after merging this PR.
I’m not aiming to perfect OPFS functionality in a single PR.

Makes sense!
If that's the case, in order to keep this well scoped, it may be best to not expose any changes to the registerFileHandle method, and only add support for passing an opfs:// uri to db.open! That magic null or {} passed as a fake file handle feels odd.
Because it's currently hard coded to use OPFS (without directory traversal), the method is now a bit of a mis-nomer when invoked like: await db.registerFileHandle(local.parquet, {}, DuckDBDataProtocol.BROWSER_FSACCESS, true).
(Side note: because there are multiple ways to get FileSystemSyncAccessHandles in the browser to use for use with the DuckDBDataProtocol.BROWSER_FSACCESS data protocol, it's not exclusive to OPFS. However, because FileSystemSyncAccessHandles cannot be shared between threads, using registerFileHandle + BROWSER_FSACCESS is only really useful when using the blocking version of the library!)
Perhaps you can add a new private method called registerOPFSHandle(name: string, uri: string, directIO: boolean). This way registerFileHandle can remain clean, and will always require a real file handle when invoked with BROWSER_FSACCESS as expected. It's a little less "magic" that way.
Alt: Just augment registerFileURL to take opfs protocol URLs instead (see code example below). Same effect, different method. The downside here is the change will be public facing, and may require more scrutiny before landing.
But yeah, will let @carlopi chime in with thoughts on API design. I'm unsure what their intent / caution level is!
In a separate PR, I'd be happy to take a stab at adding opfs URL schema, inspired by the WASM flavored HTTPFS supprt. Having that dedicated private registerOPFSHandle method would be very helpful for the implementation.
E.g.
await db.registerFileURL('local.parquet', 'opfs://origin/local.parquet', DuckDBDataProtocol.OPFS, false);
await c.query(`SELECT * FROM 'local.parquet'`);

and more simply
await c.query(`SELECT * FROM 'opfs://origin/remote.parquet'`);

@amiller-gh
Passing null or {} in place of a file handle does feel a bit awkward, but please bear with it for now. We’ll make improvements after this is merged.

I am planning to submit a follow-up PR after this one is merged, which will address the following:

Support for the opfs:// protocol
Multi-tab and multi-worker support within the same domain
Compatibility with mobile browsers

@e1arikawa to build your branch I just need to clone your repo and build from source?
cd duckdb-wasm
git submodule init
git submodule update
make apply_patches
make serve

Then I imagine there's somewhere I can find something like https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>accept locally after I build that I can use in my web app?

@e1arikawa love to hear this! I made a fork of your feature branch where I've implemented #1 for our team, but including #2 and #3 is above and beyond.
Are you able to you share your working branch on your fork? I'd like to pull it down and test it with our use cases. Obviously no need to PR it yet, but I'd prefer to work off of a single fork while we all wait for maintainer approval.

I am planning to submit a follow-up PR after this one is merged, which will address the following:

Support for the opfs:// protocol
ex) FROM read_parquet('opfs://test.parquet');
Multi-tab and multi-worker support within the same domain With Web Locks
Compatibility with mobile browsers

These features are already implemented and are awaiting the merge of this PR.


[SPARK-40747] Support setting driver log url using env vars on other resource managers

What changes were proposed in this pull request?

This PR pulls out the getDriverLogUrls from StandaloneSchedulerBackend to superclass CoarseGrainedSchedulerBackend, to make it support setting driver log url by env vars w/ prefix SPARK_DRIVER_LOG_URL_ on other resource managers, especially for K8s.
Why are the changes needed?

Since it has such an ability for the executor on K8s mode, we want to align the ability for the driver.
The related code in CoarseGrainedExecutorBackend
  def extractLogUrls: Map[String, String] = {
    val prefix = "SPARK_LOG_URL_"
    sys.env.filterKeys(_.startsWith(prefix))
      .map(e => (e._1.substring(prefix.length).toLowerCase(Locale.ROOT), e._2)).toMap
  }

Does this PR introduce any user-facing change?

Yes, the user code set the log url by env vars.
How was this patch tested?

Existing UT, if it's not sufficient and the approach is accepted, will add more ut later

cc @HeartSaVioR, would you please take a look? BTW, it does not work on Yarn since YarnClusterSchedulerBackend/YarnCoarseGrainedExecutorBackend override the methods getDriverLogUrls/getExecutorLogUrls.

To make it flexible, I'm planning to add the variable substitution support to the log URL just like SPARK-26311 does, and let the cluster manager exposes some attributes.
For example, suppose exposing APP_ID, KUBERNETES_POD_NAME in K8s, then the user could integrate to external log service easily.
spark-submit \
  --master=k8s://api-server:1234 \
  --deployMode=cluster \
  --conf spark.kubernetes.driverEnv.SPARK_DRIVER_LOG_URL_log=https://spark-log-svc:8080/?app_id={{APP_ID}}&pod_name={{KUBERNETES_POD_NAME}} \
  --conf spark.executorEnv.SPARK_LOG_URL_log=https://spark-log-svc:8080/?app_id={{APP_ID}}&pod_name={{KUBERNETES_POD_NAME}}

Can one of the admins verify this patch?

@dongjoon-hyun @holdenk what do think about the plan? is it the right direction to support the external log service on K8s?

This PR seems to aiming only K8s because YARN is not using this and Mesos is not used in these days. May I ask why don't we have this in KubernetesClusterSchedulerBackend only?

I think it could be a generic way for all cluster managers, and if it's overkill, it's fine to support this feature in KubernetesClusterSchedulerBackend.

Hi @dongjoon-hyun, I implement the proposed idea in https://github.com/apache/spark/pull/38357, w/ the doc https://docs.google.com/document/d/1MfB39LD4B4Rp7MDRxZbMKMbdNSe6V6mBmMQ-gkCnM-0/edit?usp=sharing, would you please take a look when you have time?

I tagged @tgravescs on #38357, assuming that is the version that will get supported - or is this what we are looking at ?

@mridulm Yes, https://github.com/apache/spark/pull/38357 is the proposed version.
I opened this PR mostly for collecting feedback in case the community has another idea.


Bug: Incompatible Resource Block in iam-role-for-service-accounts-eks Module Prevents Use in AWS GovCloud Due to Hardcoded Partition

Description
We are encountering an issue with the module iam-role-for-service-accounts-eks in the policies.tf file. The issue relates to a change made in version 5.47, where the resource blocks were updated from [""] to ["arn:aws:ec2:::volume/"]. This change breaks compatibility when using any partition other than the commercial AWS partition, such as AWS GovCloud regions. We need the ability to pass in custom partitions to support AWS GovCloud. We're using this module in the downstream module terraform-aws-eks and attempting to set the partition to aws-us-gov using a data block of data "aws_partition" "current" {}.
✋ I have searched the open/closed issues and my issue is not listed.
Version
OpenTofu v1.8.3
on darwin_arm64

provider registry.opentofu.org/hashicorp/aws v5.72.1
provider registry.opentofu.org/hashicorp/cloudinit v2.3.5
provider registry.opentofu.org/hashicorp/helm v2.16.1
provider registry.opentofu.org/hashicorp/kubernetes v2.33.0
provider registry.opentofu.org/hashicorp/local v2.5.2
provider registry.opentofu.org/hashicorp/null v3.2.3
provider registry.opentofu.org/hashicorp/random v3.6.3
provider registry.opentofu.org/hashicorp/time v0.12.1
provider registry.opentofu.org/hashicorp/tls v4.0.6

Steps to reproduce the behavior:
Use the provided module and configuration
Initialize Terraform: terraform init
Apply the configuration: terraform apply
Encounter the partition-specific error when running in AWS GovCloud
Expected behavior
We expected to pass custom partitions for compatibility with AWS GovCloud regions and have the ebs csi driver addon build successfully.
Actual behavior
The module only allows the commercial AWS partition due to the hardcoded ["arn:aws:ec2:::volume/*"], which breaks the configuration for non-commercial regions like AWS GovCloud.
We also tested using version 5.46 and our code applies successfully.
Terminal Output Screenshot(s)

Additional context
The issue is related to the change in version 5.47, where the resource blocks in the policies.tf file were updated from [""] to ["arn:aws:ec2:::volume/"]. We need the ability to pass in custom partitions to maintain compatibility with AWS GovCloud.

This issue has been resolved in version 5.47.1 :tada:


ImageViewer. Add WindowsInsets.ime and update resources

Added new resources approach.
Add new WindowsInsets.systemBars

Included in #3400


Support/update vagrantfiles

Pull Request Test Coverage Report for Build 68

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 68.029%

Totals

Change from base Build 66:
0.06%

Covered Lines:
749

Relevant Lines:
1101

💛  - Coveralls


dart2js: void arrow functions should allow any rhs type

This is the dart2js issue for https://github.com/dart-lang/sdk/issues/28939.

Punting to 1.24 per dart-leads discussion.

Addressed by this CL.

Addressed in 9928c5cb805dedf73b83ab051069e7a2e8cb0e06, 935aeb43ce8993bb8ec6e48bce378149120c6618.


[Bug]: Telegram Bot notifications not working

Description
Telegram Bot notifications not working
Minimal Reproduction (if possible, example repository)
Go to /notifications/telegram and add the telegram bot api token and chat id
Exception or Error
success popup comes but nothing being sent to the chat
Version
v4.0.0-beta.323
Cloud?

[ ] Yes
[X] No

i have managed to enabled them but the dashboard gets unresponsive and needs to be refeteched. turning the notifications off fixes the problem

@yashkolambekar Did you try to send a Test Notification?

@yashkolambekar
Makes sure to include "-" sign to have something like -4504503876.
Test notification worked for me.

Also not working for me. Test notification works and I receive it well, but nothing is being sent on app redeploy for example (I turned on all notification types in settings).
v4.0.0-beta.323

Well, for me only the auto deploy notifications are working and the backup notifications every night at 0000 hours
My apps are deployed from the github app source, just to be more clear.

It was working until I enable topics in Telegram.


Decide on a path to stop stripping libapp.so and libflutter.so by default for android builds

Context https://github.com/flutter/flutter/issues/60240.
We currently strip debug symbols when building the the AOT snapshot and when building the engine. This means that when Flutter developers build an appbundle (flutter build appbundle) these debug symbols are not available to the Android Gradle plugin (AGP), and therefore they obviously can't be included in the appbundle, which results in the warning in the play store that we see in the linked issue.
Since AGP 4.1, AGP itself can handle both stripping the debug symbols from the native code, and automatically including it in the appbundle in a way that is available to app stores, but does not get delivered to end users* (see https://support.google.com/googleplay/android-developer/answer/9848633#upload_file). So ideally, we could simply stop stripping these files when building for Android, and instead let AGP handle the debug symbols.
HOWEVER - the Flutter Gradle plugin has for some time now vended a recommended version of the NDK (flutter.ndkVersion) that we use to specify the ndkVersion property in apps gradle files, and importantly, if an app specifies an ndk version, and doesn't have that ndk version installed locally, the app will build but silently fail to strip the debug symbols, meaning that they end up in the final app (greatly inflating the app size).
So before we can stop stripping the debug symbols from these files by default, we need to decide on a path that ensures we don't create a foot gun where developers build, unaware that they don't have the ndk version they are specifying installed, and end up with unnecessarily large apps.
In my mind there are two main options, but other suggestions are welcome:

Get rid of flutter.ndkVersion entirely via a migrator. If users don't specify an ndk version, apps will instead use the default version provided by AGP. This is option two in this section of the android docs - AGP will download the version by default. There is also a community issue suggesting we do this.
Keep flutter.ndkVersion around, and instead modify the flutter tool/flutter doctor to ensure that we check/enforce that users have the version of the ndk that we specify installed.

* More specifically, the symbols get stripped and included in a BUNDLE-METADATA subdirectory of the app bundle format, see this comment for more details.

What does happen when some used  plugins have a newer version then flutter.ndkversion inside gradle files ? Does the build fail in this case? No conflicts?

Potentially, for 1, write a migrator that instead of removing the line, replaces flutter.ndkVersion with AGPs variable that holds their preferred ndk version, if such a variable exists

I personally don't really like first option because, in my opinion, there should be 1 source of truth for things like that. At least because there are already warnings in android builds, alarming about different versions of NDK in plugins and app (example). Although I do not think that this warning is fixable only by specifying NDK version (it doesn't work already lol), I think that relying on standard AGP mechanism for NDK downloading is another step back from avoiding this kind of problems.
Plus, I believe that another teams on a path of solving similar problem, for example #144530
I think it would be create doctor validator and, to enforce, Gradle's warning for debug/profile and error for release builds respectfully, if there's no needed ndk version found.

Still no decision has been made, but adding some more info that according to my local testing and some internal info, apparently AGP will automatically download the NDK for every use case except for when it is needed for stripping debug symbols from prebuilt libraries.
So we can't rely on AGP to guarantee the availability of the NDK.

Still no decision has been made, but adding some more info that according to my local testing and some internal info, apparently AGP will automatically download the NDK for every use case except for when it is needed for stripping debug symbols from prebuilt libraries.
So we can't rely on AGP to guarantee the availability of the NDK.

If i recall correctly it's not that hard to know the ndk versions installed on a machine the problem is are they compatible ?
for instance if u opened a fresh project and add sharedPrefernces or some other package when running the app it will prompt that this project require newer ndk version for exemple 27 and flutter.ndkVersion is 26 , so some users may find it kinda deceiving


Updating state in hover of dragged component and hover component

I have a DropTarget and DragSource for the same component and I need to adjust the state on hover of the component being hovered on and the component being dragged.  Within hover() I need to update the state of the component being hovered on and the component being dragged.
I haven't quite figured out a good way to do this.  I can wrap this in another container component and pass props and update the state of the container being hovered on, but how do I update the state of the item being dragged at the same time?
Thank you

I should probably add that I'd really prefer to do this without actually mutating state, the performance of mutating state on hover seems quite bad.
However, I do need to make calculations within hover and adjust the properties used in drop() for the dropped component and also update styles for the targets being hovered on, based on the calculations in hover.

What kind of state mutation are you needing to make? Could you give some specifics?

I have (possibly) the same issue. I'm trying to update the styling of my dropTarget to reflect whether the cursor is over the left or right side of the element. I followed the example here, but it simply applies the changes in the hover menu. I'd like to change the style of the dropTarget to show an arrow or something pointing to the side where the dragSource will be inserted. Basically I have a prop on my dropTarget that I want to flip based on this calculation performed (for now) in the hover function:
const targetBoundingRect = findDOMNode(component).getBoundingClientRect();
const horizontalMiddle = (targetBoundingRect.right - targetBoundingRect.left) / 2;
const clientOffset = monitor.getClientOffset();
const hoverClientX = clientOffset.x - targetBoundingRect.left;
const onRightSide = hoverClientX >= horizontalMiddle; //Pass this bool to my dropTarget component.

I'm needing to do essentially the same thing here: I want to highlight the top or bottom border of the item in a vertical list as the user drags above and below its vertical midpoint, to indicate whether the dropped item would be placed before or after that item.
The Drop Target spec's hover method is called repeatedly - which is fine - as I've added some logic to short-circuit execution unless my position value actually changes from "above" or "below" (and vice versa). Unfortunately I don't have a clean mechanism to update the props for the component instance passed to hover. I can't modify the props argument nor can I set component.props - and I think that either would be a bit of a kludge even if possible.
The only way I've been able to make this work is

Pass a callback function as a prop down into my item component,
Invoke the callback function on props inside the hover function on the target spec
Update the state of my list so that the my list receives new props, such that the data object corresponding the hovered item has a flag to indicate whether above or below is active.

This isn't really ideal since it pollutes my data model with display-only concerns I'd prefer not to mix in there.
Is there some way that hover could support a return value which are one or more props to be merged into the props for the specified component? Then I could more easily apply the styling with a component composed around my actual item component.

@cliffmeyers If you check out #1096 I found a somewhat more elegant (but still hack-ish) way to do it.


Update description for step 40 of music player project

Describe the Issue
We should make the instructions a little clearer.
Let's go with this suggestion from this forum post.
https://forum.freecodecamp.org/t/learn-basic-string-and-array-methods-by-building-a-music-player-step-40/685519/3?u=jwilkins.oboe
updated description
You need to update the current song being played as well as the appearance of the `playButton` element.

Assign `song` to the `currentSong` property on the `userData` object

*Note*: You should not use the optional chaining operator `?.` in this step because `userData.currentSong` will not be `null` or `undefined` at this point.

Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-basic-string-and-array-methods-by-building-a-music-player/step-40
Your code
see explanation above
Expected behavior
see explanation above
Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
No response

I made a PR, but I can close it and let some else do it. It is a nice first time issue.

no worries.
I am currently auditing some of the projects so there will be more first timers only issues coming up soon 👍


FileExistsError when saving models

Hi. I am trying to train a CartPole agent. I run the following script
python -m baselines.deepq.experiments.train_cartpole
Everything works fine in the training phase. But a FileExistsError raised when saving a model.
Here is the error info

Saving model due to mean reward increase: None -> 82.4
Traceback (most recent call last):
File "/usr/local/lib/python3.4/runpy.py", line 171, in _run_module_as_main
"main", mod_spec)
File "/usr/local/lib/python3.4/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/home/abbo/workspace/baselines/baselines/deepq/experiments/train_cartpole.py", line 31, in
main()
File "/home/abbo/workspace/baselines/baselines/deepq/experiments/train_cartpole.py", line 24, in main
callback=callback
File "/home/abbo/workspace/baselines/baselines/deepq/simple.py", line 282, in learn
U.save_state(model_file)
File "/home/abbo/workspace/baselines/baselines/common/tf_util.py", line 277, in save_state
os.makedirs(os.path.dirname(fname), exist_ok=True)
File "/home/abbo/.virtualenvs/cm3/lib/python3.4/os.py", line 244, in makedirs
mkdir(name, mode)
FileExistsError: [Errno 17] File exists (mode 700 != expected mode 775): '/tmp/tmpr0zw_jrp'

I read through the related code. The tempfile moduel creates a temporary directory, then save_state function in tf_util.py calls os.makedir() to make a directory in the system. But the file mode isn't compatible.
Is this the case? How can I fix it?

Works for me. Please reopen if the bug is still there.


Migrate Task module into JVM types/values

Purpose

$Subject

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, releated PRs, TODO items or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #15347 into master will increase coverage by 35.46%.
The diff coverage is 4.96%.

@@              Coverage Diff              @@
##             master   #15347       +/-   ##
=============================================
+ Coverage        11%   46.47%   +35.46%
- Complexity        0     5108     +5108
=============================================
  Files            38      891      +853
  Lines          1163    34120    +32957
  Branches        191     5429     +5238
=============================================
+ Hits            128    15857    +15729
- Misses         1022    16491    +15469
- Partials         13     1772     +1759

Impacted Files
Coverage Δ
Complexity Δ

...va/org/ballerinalang/stdlib/task/service/Init.java
52.63% <0%> (ø)
8 <0> (?)

...a/org/ballerinalang/stdlib/task/actions/Pause.java
41.17% <0%> (ø)
3 <0> (?)

.../org/ballerinalang/stdlib/task/actions/Resume.java
41.17% <0%> (ø)
3 <0> (?)

...ava/org/ballerinalang/stdlib/task/utils/Utils.java
43.83% <0%> (ø)
14 <0> (?)

...a/org/ballerinalang/stdlib/task/service/Start.java
42.1% <0%> (ø)
3 <0> (?)

.../ballerinalang/stdlib/task/utils/TaskExecutor.java
45.83% <0%> (ø)
3 <0> (?)

...rg/ballerinalang/stdlib/task/service/Register.java
60% <0%> (ø)
3 <0> (?)

...llerinalang/stdlib/task/actions/DetachService.java
9.09% <0%> (ø)
1 <0> (?)

...a/org/ballerinalang/stdlib/task/objects/Timer.java
86.2% <0%> (ø)
13 <0> (?)

...lang/stdlib/task/utils/ResourceFunctionHolder.java
40% <0%> (ø)
2 <0> (?)

... and 859 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 206b270...a7418b6. Read the comment docs.


are there plans to generate puppet/master/remote/remotesync etc decorators?

are there plans to generate puppet/master/remote/remotesync etc decorators?
Is there any reason they haven't been done yet? Couldn't it be done with a call to rpc_config at least in the short term?

I added a few decorators to do the same thing using rpc_config in my code for now, I'll edit this once I've tested them.

looks like I'm definitely missing something :), my property decorators are being ran in such a way that they crash the system, I have some idea but I'll just wait for a response, and manually call rpc_config in my constructor for now.

I never using this kind of features in Godot.
I'd like to advice never touching theme as they are not battle tested features.
Fell free to implement them in script side. And pin me if anything is blocking you implement these features in the binding side.

I'll look into them more, I was getting some issues on the binding side but I can look into that too

What are the ramifications of this implementation?
export function makeRsetModeConfigDecorator<T extends godot.Node, Key extends string>(mode: godot.MultiplayerAPI.RPCMode) {
	// target is prototype of property class
	return function (target: T, property: Key) {
		const originalReady = target._ready;
		target._ready = function(...args: any[]) {
			originalReady.call(this, ...args)
			this.rset_config(property, mode)
		};
	}
}

export const puppet = makeRsetModeConfigDecorator(godot.MultiplayerAPI.RPC_MODE_PUPPET);

Manipulating the bound _ready method is a bit problematic, but I'm not sure how else to inject property modifying code on object creation, and I couldn't do it with the constructor that existed on the prototype. Any ideas? I'm also knew to using decorators in typescript (I've always wanted to but it's not popular in the communities in which I work that use typescript).
This implementation does seem to work, but it's probably better to set the rset config on object construction, not tree _ready. Even better would be to figure out how it's done in gdscript and do it there so I might want to look into that. This might work for a first-pass but I'm not sure I like it. Maybe once I've done some research this implementation won't seem so bad.

So indeed I can't really alter the constructor from a property decorator since that doesn't let me generate/replace the class. I could however use metadata to do something in the bindings probably.
https://stackoverflow.com/questions/9267157/why-is-it-impossible-to-change-constructor-function-from-prototype
The above solutions works for now, but I plan on contributing a better one eventually, once I start really battle-testing this one.

I see hints that there may be a convention of adding $onready: prefixed properties that the bindings automatically execute on ready. I'll look into this later and hopefully contribute a PR. Before I do so, I am rewriting a codebase I have into ECMAScript so I have a live application to test with.

I believe I have a decent solution, I'll make a PR soon, after more testing.

just an update, here's the temporary solution, I'll make a PR once I have finished converting my codebase to ecmascript without any bugs, and have tested a live multiplayer scenario.
function makeRpcModeConfigDecorator<T extends godot.Node>(mode: godot.MultiplayerAPI.RPCMode) {
  return function (targetPrototype: T, property: string, descriptor?: PropertyDescriptor) {
    const originalReady = targetPrototype._ready
    Object.defineProperty(targetPrototype, property, {
      value: function (this: godot.Node) {
        this.rpc_config(property, mode)
        originalReady.call(this)
      },
    })
    return descriptor
  }
}

export function makeRsetModeConfigDecorator<T extends godot.Node, Key extends string>(
  mode: godot.MultiplayerAPI.RPCMode
) {
  return function (target: T, property: Key) {
    const originalReady = target._ready
    target._ready = function (this: godot.Node, ...args: any[]) {
      this.rset_config(property, mode)
      return originalReady.call(this, ...args)
    }
  }
}

export const remote = makeRpcModeConfigDecorator(godot.MultiplayerAPI.RPC_MODE_REMOTE)
export const master = makeRpcModeConfigDecorator(godot.MultiplayerAPI.RPC_MODE_MASTER)
export const puppet = makeRsetModeConfigDecorator(godot.MultiplayerAPI.RPC_MODE_PUPPET)
export const slave = makeRpcModeConfigDecorator(godot.MultiplayerAPI.RPC_MODE_SLAVE)
export const remote_sync = makeRpcModeConfigDecorator(godot.MultiplayerAPI.RPC_MODE_REMOTESYNC)
export const sync = makeRpcModeConfigDecorator(godot.MultiplayerAPI.RPC_MODE_SYNC)
export const master_sync = makeRsetModeConfigDecorator(godot.MultiplayerAPI.RPC_MODE_MASTERSYNC)
export const puppet_sync = makeRsetModeConfigDecorator(godot.MultiplayerAPI.RPC_MODE_PUPPETSYNC)

Just plop that in decorators.ts.

Are you tested them in your project ?
Is fine to add it to the decorator.ts if you really want these features.

I definitely will as soon as I test them more. I tested them minimally a while ago. I can do some testing again tomorrow and submit a PR.

just an update, I delayed because of the codebase I'm using is still being converted somewhat, and I noticed there are some settings I missed. I can definitely do it this weekend unless someone beats me to it.

PR is up, everything looks good, solved some gotchas, still would be nice if someone else tries it (or not and I'll fix issues found later). A test project is attached to the PR thread

Resolved by #53


Update to Fairy Armor (and maybe other armors)

its kind of like a suggestion is i should do the same format change with other pieces of fairy armour and other armours

On the wiki, you can see the default tooltip. It shows 0 Fairy Souls as default, rather than 000.

On the wiki, you can see the default tooltip. It shows 0 Fairy Souls as default, rather than 000. Not sure if you want to display it like that instead, however.

It doesn't show 000 it shows the randomising sga characters

On the wiki, you can see the default tooltip. It shows 0 Fairy Souls as default, rather than 000. Not sure if you want to display it like that instead, however.

It doesn't show 000 it shows the randomising sga characters

This is how I would like stat dependent numbers to be shown


Update hacker-news extension

Description
Add functionality to summarize articles with OpenAI GPT-3.5 Turbo.
The OpenAI key is optional. If the user does not provide it, the summarize function will be unavailable.

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Seems like it doesn't work if you have Raycast AI, I didn't enter a OpenAI key and getting this

Seems like it doesn't work if you have Raycast AI, I didn't enter a OpenAI key and getting this

It should work now.

Still facing the same issue, I have Raycast AI and it still just gives me the error - it should work if I only had Raycast AI, right?

Collaborator

Hi, I'm checking the rayCast AI subscription with environment.canAccess(AI). I don't have a subscription, but in my case, I just debug it by changing it to a fixed value like 'true' and it works for me. So please check that branch is updated and could you check if environment.canAccess(AI) returns true in your case?
Thanks.

@pernielsentikaer  I just realized that PR wasn't up-to-date. I thought it was. I'm getting nothing new to publish, but actually, there is something to publish.
ready -  validate git repository ready -  getting fork ready -  preparing clone ready -  checking for new contributions error -  preparing extension seems like there is nothing new to publish

Please check it again
Hope this time will work :)

Hi @hakob8956! 👋
It works as expected now, but I think we can improve the user experience (UX). It feels wrong to have two hotkeys to retrieve the data, and it would also consume a lot of credits if it only summarizes the next item in the list.
Here's my suggestion: let's switch to a new markdown view where it performs its magic. This way, it will feel more like Raycast.
Do you need my assistance with this, or can you handle it on your own?

Hi @pern

Hi @hakob8956! 👋
It works as expected now, but I think we can improve the user experience (UX). It feels wrong to have two hotkeys to retrieve the data, and it would also consume a lot of credits if it only summarizes the next item in the list.
Here's my suggestion: let's switch to a new markdown view where it performs its magic. This way, it will feel more like Raycast.
Do you need my assistance with this, or can you handle it on your own?

Hi @pernielsentikaer , I would like to understand the concept of markdown view more. Will it no longer list items? What exactly do you mean by that? Could you give an example of a plugin or some mocks?

Sorry for the delay here @hakob8956 - Somehow I missed the notification regarding this PR
First opening the detail panel on an item and then running another command feels a bit heavy and is not a good UX, what would be is to push to a  pane with the data instead


Router navigate twice

Since I upgraded to beta 1.2 I have a strange behavior : when I navigate in my app, all of my views are loaded twice. If I set some console in activate method of controlleurs, I can see it two times. If I observe router.currentInstruction, event is fired twice :

It's hard to reproduce. I'm having the problem when loading a view with a child router. If I load the root view first, then, the rooter will works fine when I navigate child routes. Then, If I reload from a child route, I'll get the twice load.

App.js have this configuration:
config.map([{
      route: '/',
      name: 'home',
      moduleId: 'home/home'
    }, {
      route: 'login',
      name: 'login',
      moduleId: 'auth/login'
    }, {
      route: 'su',
      name: 'Super User',
      moduleId: 'su/su'
    }, {
      route: 'profile/:provider/:name',
      name: 'profile',
      moduleId: 'profile/profile'
    }]);

If I load my app on /, /su or /login, I'll get the double navigation but not on /profile/foo/bar. Then, if I replace route: 'profile/:provider/:name', for route: 'profile',, I'll get the bug too.

Can you re-create this on the nav skeleton for us and attach the src? I haven't seen this behavior with similar setups.

Closing since cannot reproduce and no repro from OP.


BUG: read_raw_bids and raw.save round-trip with splits

          ouch. it's really bad that `raw.save(my_bidspath)` generates filenames that can't be read by `read_raw_bids(my_bidspath)`.

Originally posted by @drammock in https://github.com/mne-tools/mne-python/issues/11870#issuecomment-1671754453

I started looking into this a bit. In principle I think we could fix this on the MNE-BIDS side for read_raw_bids, but we'd be stuck with the same problem for read_epochs in MNE-Python -- epochs.save(bids_path) can write a path that has effectively been .update(split='01')'ed so read_epochs(bids_path) will fail.
I also thought about trying to fix the BIDSPath.fpath to do some magic, but that was a non-starter because it doesn't know whether you intend to read or write, and that matters. If you want to write you want the nonexistent split=None filename sent to the .save method (otherwise you end up with split-01_split-01_ in your filenames if they get split!), and if you want to read you want the split='01' version (because it actually exists).
So I think in the end one way around this problem is to put a fix in MNE in read_raw_fif and read_epochs directly. These could detect BIDSPath instances, and if present, check for bids_path existence and if not found and split is None in the BIDSPath, also check split='01'. It's not perfect but it would at least allow the round-trip to succeed for both raw.save+read_raw_fif+read_raw_bids and epochs.save+read_epochs.


Plugin [id: 'org.jetbrains.kotlin.multiplatform', version: '1.4.255-SNAPSHOT'] was not found in any of the following sources:

Plugin [id: 'org.jetbrains.kotlin.multiplatform', version: '1.4.255-SNAPSHOT'] was not found in any of the following sources:

Hello, please try PR, it worked fine for me.

Hello, please try PR, it worked fine for me.


Self-healing : NBD server failure

Specs : https://github.com/zero-os/0-orchestrator/blob/master/specs/selfhealing/storage.md

after  killing  nbd server process, Ays still has no failure in nbd server

Software Version
967b777e18d52e8ce56737d5ac7ddf5682c65778

issue still exists
software version
master : 2043f538

blocked due to https://github.com/zero-os/0-orchestrator/issues/666

it doesn't work after migration
Steps

create vm in node1
migrate vm to node2
kill nbdeserver for this vm in node2

Error
traceback (most recent call last):
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/tmp/actions/nbdserver/ed1ccdc6bb5a843ef31d39df3c950018.py", line 195, in watchdog_handler
    vm_service = service.aysrepo.serviceGet(role='vm', instance=service.name)
  File "/opt/code/github/jumpscale/ays9/JumpScale9AYS/ays/lib/AtYourServiceRepo.py", line 349, in serviceGet
    (role, instance), level=1, source="", tags="", msgpub="")
JumpScale9.errorhandling.JSExceptions.NotFound: ERROR: Cannot find service vm:vdisks_vm2_248a07e3cc20 ((type:notfound)
[Mon07 08:52] - Job.py              :56  :j.core.jobcontroller.job.b0cd3dd4b8302ebe533c8ff55dba58cc - ERROR    - Traceback (most recent call last):
  File "uvloop/future.pyx", line 374, in uvloop.loop.BaseTask._fast_step (uvloop/loop.c:112704)
  File "/tmp/actions/node.zero-os/aac16753b7bb0b6f5c7f9f7004b95aef.py", line 233, in streaming
    await cl.global_stream(queue)
  File "/usr/local/lib/python3.5/dist-packages/zeroos/orchestrator/sal/Pubsub.py", line 97, in global_stream
    await self.callback(job_id, meta >> 16, line, meta & 0xff)
  File "/tmp/actions/node.zero-os/aac16753b7bb0b6f5c7f9f7004b95aef.py", line 215, in callback
    await srv.executeAction(handler, context=job.context, args=args)
  File "/opt/code/github/jumpscale/ays9/JumpScale9AYS/ays/lib/Service.py", line 707, in executeAction
    return await self.executeActionJob(action, args, context=context)
  File "/opt/code/github/jumpscale/ays9/JumpScale9AYS/ays/lib/Service.py", line 732, in executeActionJob
    result = await job.execute()
  File "uvloop/future.pyx", line 241, in __await__ (uvloop/loop.c:110786)
  File "uvloop/future.pyx", line 432, in uvloop.loop.BaseTask._fast_wakeup (uvloop/loop.c:113980)
  File "uvloop/future.pyx", line 101, in uvloop.loop.BaseFuture._result_impl (uvloop/loop.c:108900)
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/tmp/actions/nbdserver/ed1ccdc6bb5a843ef31d39df3c950018.py", line 195, in watchdog_handler
    vm_service = service.aysrepo.serviceGet(role='vm', instance=service.name)
  File "/opt/code/github/jumpscale/ays9/JumpScale9AYS/ays/lib/AtYourServiceRepo.py", line 349, in serviceGet
    (role, instance), level=1, source="", tags="", msgpub="")
JumpScale9.errorhandling.JSExceptions.NotFound: ERROR: Cannot find service vm:vdisks_vm2_248a07e3cc20 ((type:notfound)

Software Version
012719ca7375c9a5ba500bc403a61a15b0873b53

can't validate https://github.com/zero-os/0-orchestrator/issues/791

it doesn't work now as when u kill nbdserver process , ays doesn't recognize that so it doesn't restart again , may this error is one of reason of that
https://github.com/Jumpscale/ays9/issues/164
Software Version
3cb419bdbfc44dbc8cb9a43f67747738d9973821

Software Version
4608799aa49ff1f81154ef0f11a414df67e58797


Add option to customize the skrim color

It'd nice to be able to partially obscure the content behind the tooltip to communicate that tapping outside the tooltip will dismiss the tooltip.
Ideally, we'd also provide the option to not obscure the child widget with the colored skrim-but I honestly have no idea how to do that. We'd have to get the outline of the child widget and use it as a clip path on the skrim.
Leaving it to you to bump the version numbers and changelog should you accept this PR.

I like this. I would go one step further though and allow arbitrary content as the scrim. You can do this by defining a builder and letting the user pass through a function that builds their scrim widget. Maybe something like scrimBuilder? See here for another builder example I have.
It would then look like:
JustTheController(
  scrimBuilder: (context) {
    return Container(color: Colors.blue.withAlpha(.5));
  }
)

What do you think of this?
Also,

Ideally, we'd also provide the option to not obscure the child widget with the colored skrim-but I honestly have no idea how to do that. We'd have to get the outline of the child widget and use it as a clip path on the skrim.

I'm not sure what you mean by this? Does this happen? My immediate thought is that the tooltip is above the scrim no? I'm not a simulator to test though

Done! I made a couple value judgements, let me know if you think any of them should have been done differently:

Instead of replacing barrierColor, I added another argument for the builder. This way if a user just wants to change the color and that's it, they don't have to have deal with the added complexity of the builder.
I called the builder barrierBuilder instead of scrimBuilder to keep the external facing naming consistent with barrierColor and barrierDismissable.
Instead of putting the user-supplied barrier under the existing gesture detector for dismissing the barrier, I passed the _hideTooltip function into the barrierBuilder and left it to the developer to call the dismiss function as they see fit. This allows for arbitrarily customizable UX for dismissing the tooltip from the barrier.

Hmm after doing a lot more work on #49, I'm realizing this PR may not add much value. Namely, the example file in #49 shows how to trivially build a customizable barrier. If it's so easy to build one outside of the package, then I don't think we need barrierBuilder in the package.
barrierColor still seems useful for people who want good out-of-the-box behavior and don't want to go through the trouble of building their own barrier just to customize the color.
My vote is rollback the barrierBuilder argument and keep barrierColor. Let me know what you think.

I like your example you have in #49 but I'm still a little unsure. I think I prefer having both barrierBuilder and barrierColor.
The example you have relies on aligning an external _animation with the internal one and using that animation inside a stack (which some users might not like being a part of the tree if not required to) to drive a transition.
Instead, I think I'd prefer the barrierBuilder to just be passed the internal animation that we already have for fading in and out the tooltip. I don't see a lot of use cases requiring a separate animation with a different duration but if that is the case, I think down the line we can create arguments like barrierShowDuration, etc.
(I also think it's possible to remap an animation to a different duration or curve? not sure)
The signature for barrierBuilder would then be:
typedef BarrerBuilderCallback = Widget Function(BuildContext context, Animation<double> animation, VoidCallback dismiss);

and the example would then be:
JustTheTooltip(
  barrierBuilder: (context, Animation<double> animation, onDismiss) {
    return LayoutBuilder(
      builder: (context, constraints) {
        // Use the pythagorean theorem to get the diameter of the circle
        // that circumscribes the constraints.
        final double diameter = math.sqrt(
            math.pow(constraints.maxHeight, 2) +
                math.pow(constraints.maxWidth, 2));

        return ScaleTransition(
          scale: animation,
          child: OverflowBox(
            maxWidth: diameter,
            maxHeight: diameter,
            child: Container(
              decoration: const BoxDecoration(
                color: Colors.white30,
                shape: BoxShape.circle,
              ),
            ),
          ),
        );
      },
    );
  },
)

I think the default barrierBuilder should just be null so we could use the barrierColor instead when building the scrim.
Widget _createSkrim() {
  if (widget.barrierBuilder != null) {
    return widget.barrierBuilder(context, animation, _hideTooltip);
  }

  return Container(
    color: barrierColor, // defaults to Colors.transparent
    child: GestureDetector(
      key: skrimKey,
      behavior: barrierDismissible
          ? HitTestBehavior.translucent
          : HitTestBehavior.deferToChild,
      onTap: _hideTooltip,
    ),
  );
}

I really appreciate the work you've put into this too !

I like your example you have in #49 but I'm still a little unsure. I think I prefer having both barrierBuilder and barrierColor.
The example you have relies on aligning an external _animation with the internal one and using that animation inside a stack (which some users might not like being a part of the tree if not required to) to drive a transition.
Instead, I think I'd prefer the barrierBuilder to just be passed the internal animation that we already have for fading in and out the tooltip. I don't see a lot of use cases requiring a separate animation with a different duration but if that is the case, I think down the line we can create arguments like barrierShowDuration, etc.
(I also think it's possible to remap an animation to a different duration or curve? not sure)
The signature for barrierBuilder would then be:
typedef BarrerBuilderCallback = Widget Function(BuildContext context, Animation<double> animation, VoidCallback dismiss);

and the example would then be:
JustTheTooltip(
  barrierBuilder: (context, Animation<double> animation, onDismiss) {
    return LayoutBuilder(
      builder: (context, constraints) {
        // Use the pythagorean theorem to get the diameter of the circle
        // that circumscribes the constraints.
        final double diameter = math.sqrt(
            math.pow(constraints.maxHeight, 2) +
                math.pow(constraints.maxWidth, 2));

        return ScaleTransition(
          scale: animation,
          child: OverflowBox(
            maxWidth: diameter,
            maxHeight: diameter,
            child: Container(
              decoration: const BoxDecoration(
                color: Colors.white30,
                shape: BoxShape.circle,
              ),
            ),
          ),
        );
      },
    );
  },
)

I think the default barrierBuilder should just be null so we could use the barrierColor instead when building the scrim.
Widget _createSkrim() {
  if (widget.barrierBuilder != null) {
    return widget.barrierBuilder(context, animation, _hideTooltip);
  }

  return Container(
    color: barrierColor, // defaults to Colors.transparent
    child: GestureDetector(
      key: skrimKey,
      behavior: barrierDismissible
          ? HitTestBehavior.translucent
          : HitTestBehavior.deferToChild,
      onTap: _hideTooltip,
    ),
  );
}

I really appreciate the work you've put into this too !

All this sounds good, I'll make the changes now. And no problem!

One thing: the example in #49 is not achievable with barrier builder. Specifically, the example draws a barrier behind the button that generated the tooltip. With barrier builder, the barrier is displayed in front of the button.
Personally I dramatically prefer the former, but it seems fine to provide both options?

Ah sorry, I understand what you mean now when you said the barrier will be drawn above the child button and we should look into a clipper or similar.
Looking for other examples on the web, it doesn't sound reasonable to have the barrier obscure the child which is what we do now. Up till now it hasn't been a problem since the barrier was always obscured.

Honestly, I still think the barrierBuilder is the way to go as the alternative seems like a lot of work for a user to implement themselves that should be taken care of at the library level.
I want to hear your opinion first but what do you think about moving forward with what we currently have (current issue and all) and then creating a seperate issue the deals with the barrier being above the child.
Namely, one idea I have is that we'd need to make the child an overlay too and then place the overlay at the end of the overlay stack:
[   content overlay   ]
[   child overlay     ]
[   barrier  overlay  ]

That or some thing else involving a simple clip space with the option to provide a custom clipper but this seems like a big enough thing to be its own issue. Lemme know

I think proceeding as is and then trying to fix it after is a good approach-this isn't a world ending bug/UX issue.
Putting the child in an overlay doesn't really work because overlay operates in a separate context and developers using the API might have dependencies on context that are broken in overlay. I think the approach will have to be something painful like looking into shadermasks or something to see if we can clip the barrier to the inverse of the shape of the child.

Yah, it probably won't be fun but I'm sure someone must've tread this water before us. I know coachmaker does something similar to what we want so maybe they have an answer. Anyways, yah, we can move further discussion of this to #50 and refocus on getting this pr sent thru. Thanks for your patience with me too

Hey! I see that you both agreed on using implementation from this PR for now and work on not displaying the skrim over the child. A separate issue for the latter part has also been created. I'll merge this PR then.


Is there anyway to load settings in the client app?

I need to load some configuration settings in the React Redux template into the SPA app. I've tried a .env file which works in development but I think the environment variables have to be loaded at build time and are therefore not configurable on the live server. I've been playing with a custom FileProvider but have had no success there either. Is there any method someone can point me to?

No this it not about ASP.NET Core. This is trivial in ASP .NET Core using razor or whatever templating engine you use as you can easily inject server side variables into the HTML sent to the client. The issue is in this template which loads the static index.html page from disc without providing an entry point to modify it. create-react-app also supports this, it's only this template that does not.

Thanks for clarification, @chris-herring.
@rynowak, can you please look into this? Thanks!

It's still not clear to me what the problem here is. If you just want to programatically construct your page instead of having it be the same every time check out what we did on the Counter or FetchData page. After that it's just a matter of using the APIs available in React-Redux to load any information you need out of wherever it's stored.

Thanks for contacting us. We believe that the question you've raised have been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.


KAFKA-13452: MM2 shouldn't checkpoint when offset mapping is unavailable

MM2 checkpointing reads the offset-syncs topic to create offset mappings for committed consumer group offsets. In some corner cases, it is possible that a mapping is not available in offset-syncs - in that case, MM2 simply copies the source offset, which might not be a valid offset in the replica topic at all. This can cause issues when auto offset sync is also turned on.
Updated checkpointing logic to not create checkpoints for topic partitions without a valid offset mapping.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@mimaison would you please review this?

Thanks @viktorsomogyi for the PR. If I understand correctly, this an alternative to https://github.com/apache/kafka/pull/11748?

@mimaison yes, it is, if you see something, feel free to incorporate it into yours. Also I didn't want to ping you on this one but a different one :). Sorry. Once I have that up here you can expect me.


Fixes #464

Related Issues
#464
Closes #
#464
Short Description and Why It's Useful
It fixes bugs
Screenshots of Visual Changes before/after (If There Are Any)
N/A
IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Done
Contribution and Currently Important Rules Acceptance

[ X] I read and followed contribution rules

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This issue has been solved by: https://github.com/DivanteLtd/vsf-capybara/pull/463


Don't use doubles on the mac.

This avoid errors in the log about the wrong type on the mac.
What is the proper policy? Should doubles for the gpu be banned across the platforms? This pr only changes it for the mac. I am also unsure if it's correct.
vd.stride is also incorrect.

Don't use doubles on the mac. · V-Sekai/godot@0783409
What's the policy on GPU doubles? I thought it was no for any reason
clayjohn — Today at 17:27
Metal doesn't support doubles, so they can't be used on the GPU on macs
A lot of Intel chips don't support them either

Close due this being the incorrect fix for https://github.com/godotengine/godot/issues/78730


Login: Register User with IDP

As a developer I want to be able to register a user with idp through the default registration ui, so I don't have to build it myself.
Acceptance Criteria

[x] Ui is implemented in the package and used by the login ui
[x] I am able to send the org id or primary domain to the login ui
[x] If an org id or primary domain is sent, organization idps are shown
[x] If no org id or primary domain is sent, instance idps are shown
[x] User clicks on idp and is redirected to the provider
[x] After login in the provider user gets back to login
[ ] When the user exists already in ZITADEL a success page is shown / or redirect to the application if no further steps needed
[x] When the user doesn't exist, depending on the configuration the user will be created automatically or a register screen is shown or the user can choose to link with an existing user

When the user exists already in ZITADEL a success page is shown / or redirect to the application if no further steps needed
currently the error message is shown on the success page of the register. I think its the most generic way of handling this behaviour in an example app. Users can intercept the error there and do whatever they want.


Respect NS_REFINED_FOR_SWIFT importing anon enums

When an anonymous enum is imported, its imported name is under some circumstances derived from the type that it is backed by. NS_REFINED_FOR_SWIFT is a macro that produces a attribute((swift_private)) that when attached to a declaration, the imported name of this declaration should have two underscores prepended. When the name anonymous enum is derived from another declaration, and said declaration does not have the same swift private attribute, the __ is dropped. This patch fixes this.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

Thanks @NuriAmari !


Support for TS.RANGE's FILTER_BY_VALUE and FILTER_BY_TS parameters

Hello,
Awesome library, thanks for the work put into it. I noticed in Redis' TimeSeries documentation on TS.RANGE (https://redis.io/commands/ts.range) there is a parameter to filter results by their value FILTER_BY_VALUE. Am I mistaken in saying the current version of this package doesn't support that within its range function? https://github.com/palicao/phpRedisTimeSeries/blob/master/src/TimeSeries.php#L303
Is there a way for me to execute this, or add additional raw parameters to the end of a command?
Thanks again!
Edit:
Ah yes I now see this package is last tested against TimeSeries 1.4, and these things were added in 1.6, I'm going to review how you set this package up and try to follow best practice for adding these features, but it be great if this and LATEST, which was added in 1.8, could be implemented.

Not sure if this is best, but I implemented https://github.com/smcgovern/phpRedisTimeSeries/commit/314020621fc3da958e764cbd4a781f5269a3304c on my fork to get this working in my projects. I'm sure theres other pieces to this that are worth adding that I'll encounter while digesting the redis docs, but for now this is what I've needed.


[DO NOT MERGE] WIP: use scikit-build-core, PEP 517 builds

Notes for Reviewers
Just opening this to test things. I'll break off smaller pieces of it into separate PRs.
This should probably never be merged.

closing this in favor of #126


MAKE libifm3d_camera.so.0.10.0: undefined reference to `xmlrpc_c::...

I use the command to install XML:  sudo apt-get install libxmlrpc-c++8-dev
cmake

make

somebody can help me ? thank you very much !!

@HuDongAlex from the boost version I do expect that you are running a Ubuntu 18.10 version. Unfortunatly currently we do support Ubuntu 18.04 and 16.04 which are the latest LTR releases. So can you please be so kind and provide your full error log.  By the way GitHub provides a very neat feature to embed code snippets into issues. This will make things much easier on my side. Thanks in advance.

@graugans thank you for your reply in advance !
###this is my system infos. I just build the project——ifm3d, and I don't changge any code.

How can I get the full error log which you want ? thank you !

@graugans
The output of make.
"
Scanning dependencies of target ifm3d-camera-tests
[ 22%] Building CXX object modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/ifm3d-camera-camera-tests.cpp.o
[ 24%] Building CXX object modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/ifm3d-camera-err-tests.cpp.o
[ 26%] Building CXX object modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/ifm3d-camera-testrunner.cpp.o
[ 28%] Building CXX object modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/ifm3d-camera-version-tests.cpp.o
[ 30%] Linking CXX executable ifm3d-camera-tests
../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to xmlrpc_c::carriageParm_curl0::carriageParm_curl0(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)' ../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to xmlrpc_c::value_string::operator std::__cxx11::basic_string<char, std::char_traits, std::allocator >() const'
../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to xmlrpc_c::rpcPtr::rpcPtr(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, xmlrpc_c::paramList const&)' ../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to xmlrpc_c::value_string::cvalueabi:cxx11 const'
../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to xmlrpc_c::value_string::value_string(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' ../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to xmlrpc_c::value_struct::value_struct(std::map<std::__cxx11::basic_string<char, std::char_traits, std::allocator >, xmlrpc_c::value, std::less<std::__cxx11::basic_string<char, std::char_traits, std::allocator > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits, std::allocator > const, xmlrpc_c::value> > > const&)'
../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to `xmlrpc_c::value_struct::operator std::map<std::__cxx11::basic_string<char, std::char_traits, std::allocator >, xmlrpc_c::value, std::less<std::__cxx11::basic_string<char, std::char_traits, std::allocator > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits, std::allocator > const, xmlrpc_c::value> > >() const'
collect2: error: ld returned 1 exit status
modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/build.make:131: recipe for target 'modules/camera/test/ifm3d-camera-tests' failed
make[2]: *** [modules/camera/test/ifm3d-camera-tests] Error 1
CMakeFiles/Makefile2:473: recipe for target 'modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/all' failed
make[1]: *** [modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/all] Error 2
Makefile:151: recipe for target 'all' failed
make: *** [all] Error 2
hudong@ubuntu:/disk2/ifm3d-0.11.0/build$
"

Please use ``` to mark code.

😀，I am so sorry, this is my first to use issues.
hudong@ubuntu:/disk2/ifm3d-0.11.0/build$ sudo make
Scanning dependencies of target ifm3d_camera_shared
[  2%] Building CXX object modules/camera/src/libifm3d_camera/CMakeFiles/ifm3d_camera_shared.dir/camera.cpp.o
[  4%] Building CXX object modules/camera/src/libifm3d_camera/CMakeFiles/ifm3d_camera_shared.dir/err.cpp.o
[  6%] Building CXX object modules/camera/src/libifm3d_camera/CMakeFiles/ifm3d_camera_shared.dir/logging.cpp.o
[  8%] Building CXX object modules/camera/src/libifm3d_camera/CMakeFiles/ifm3d_camera_shared.dir/util.cpp.o
[ 10%] Building CXX object modules/camera/src/libifm3d_camera/CMakeFiles/ifm3d_camera_shared.dir/version.cpp.o
[ 12%] Linking CXX shared library libifm3d_camera.so
[ 12%] Built target ifm3d_camera_shared
Scanning dependencies of target gtest
[ 14%] Building CXX object gtest_bin/googlemock/gtest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
[ 16%] Linking CXX static library libgtest.a
[ 16%] Built target gtest
Scanning dependencies of target gtest_main
[ 18%] Building CXX object gtest_bin/googlemock/gtest/CMakeFiles/gtest_main.dir/src/gtest_main.cc.o
[ 20%] Linking CXX static library libgtest_main.a
[ 20%] Built target gtest_main
Scanning dependencies of target ifm3d-camera-tests
[ 22%] Building CXX object modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/ifm3d-camera-camera-tests.cpp.o
[ 24%] Building CXX object modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/ifm3d-camera-err-tests.cpp.o
[ 26%] Building CXX object modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/ifm3d-camera-testrunner.cpp.o
[ 28%] Building CXX object modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/ifm3d-camera-version-tests.cpp.o
[ 30%] Linking CXX executable ifm3d-camera-tests
../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to `xmlrpc_c::carriageParm_curl0::carriageParm_curl0(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)'
../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to `xmlrpc_c::value_string::operator std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >() const'
../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to `xmlrpc_c::rpcPtr::rpcPtr(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, xmlrpc_c::paramList const&)'
../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to `xmlrpc_c::value_string::cvalue[abi:cxx11]() const'
../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to `xmlrpc_c::value_string::value_string(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to `xmlrpc_c::value_struct::value_struct(std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, xmlrpc_c::value, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, xmlrpc_c::value> > > const&)'
../src/libifm3d_camera/libifm3d_camera.so.0.11.0: undefined reference to `xmlrpc_c::value_struct::operator std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, xmlrpc_c::value, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, xmlrpc_c::value> > >() const'
collect2: error: ld returned 1 exit status
modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/build.make:131: recipe for target 'modules/camera/test/ifm3d-camera-tests' failed
make[2]: *** [modules/camera/test/ifm3d-camera-tests] Error 1
CMakeFiles/Makefile2:473: recipe for target 'modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/all' failed
make[1]: *** [modules/camera/test/CMakeFiles/ifm3d-camera-tests.dir/all] Error 2
Makefile:151: recipe for target 'all' failed
make: *** [all] Error 2

Is this all right ？

I have just fired up a fresh Ubuntu 18.04 in my docker. But it builds fine.

@graugans In my pure ubuntu18.04 follow the steps in the docker you describe step by step to the "RUN/home/ifm3d/vim/bundle/YouCompleteMe/the py - clang - completer", but I find that I don't have YouCompleteMe bundle directory folder. I can't do the rest. What should I do? Looking forward to your help!

@graugans ok，How can I simply verify that my library and program are installed? I can get the depth image directly from ifm3d, the color one, okay? I really appreciate your help!

@HuDongAlex after installing ifm3d there is a command line tool called ifm3d with ifm3d dump you can check if you can establish a connection to the camera. But maybe you also have to adjust the command line to fit the IP address of the camera. Check this guide.

@graugans  yes. it worked !! 😀，thank you very much!!

@HuDongAlex can we close this issue? It seems you have solved the problem.

@graugans yes, you can close it.


remove .flat, fixing a bug for python 3.4

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   86.48%   86.48%
=======================================
  Files           8        8
  Lines         725      725
=======================================
  Hits          627      627
  Misses         98       98

Impacted Files
Coverage Δ

voropy/mesh_tri.py
96% <100%> (ø)
:white_check_mark:

voropy/mesh_tetra.py
89.47% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53727bb...34544d5. Read the comment docs.


[release-1.7] Add credential fetcher in istio agent

Manual cherrypick required.
#25614 failed to apply on top of branch "release-1.7":

https://github.com/istio/istio/pull/26047

https://github.com/istio/istio/pull/26047


Icclim prcptot

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #812

[x] Tests for the changes have been added (for bug fixes / features)
Maybe a bit weak on tests. Hopefully someone can jump in.
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion (major / minor / patch) has been called on this branch
[ ] Tags have been pushed (git push --tags)
[ ] The relevant author information has been added to .zenodo.json

What kind of change does this PR introduce?

,,,

Does this PR introduce a breaking change?
Other information:

@aulemahal Any idea why an sdba test would fail ?

Scheisse. Looks like #831 ...


[WIP] N46: Release

Ugh, I'm bad at this :(
Part of #1378

@ozkriff  Let me know if I can help

Merging in ~30m or so.


Moved project path into exec command

Improved command execution passing the path with the cwd param.
I think that this also fixes the #7 because the cd command was executed after the agvtools

thanks!


Pull all changes from origin

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@28b02b8). Click here to learn what that means.
The diff coverage is 85%.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   81.35%
  Complexity        ?       52
=========================================
  Files             ?        5
  Lines             ?      236
  Branches          ?       29
=========================================
  Hits              ?      192
  Misses            ?       30
  Partials          ?       14

Impacted Files
Coverage Δ
Complexity Δ

.../org/web3j/mavenplugin/JavaClassGeneratorMojo.java
85.71% <84.31%> (ø)
23 <9> (?)

...g/web3j/mavenplugin/solidity/SolidityCompiler.java
71.13% <88.88%> (ø)
11 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28b02b8...8b51a7b. Read the comment docs.


installation on macOS fail with error

sent 34405 bytes  received 638 bytes  70086.00 bytes/sec
total size is 132086  speedup is 3.77
[13:45:32] Running cordova compile osx   --
You have been opted out of telemetry. To change this, run: cordova telemetry on.
Error: xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
[13:45:32] Done

@choetin Apologies for not getting back to you until now. Did you ever have any luck getting Outline to build? You will need Xcode installed, as mentioned here:
https://github.com/Jigsaw-Code/outline-client#apple-macos-and-ios

Closing due to inactivity. Please do re-open if you want to discuss more.


How-to-setup instructions

Hey there, just wanted to say, that I appreciate this fork supporting the Rule keyword!
I was eager to try it out, and found several issues setting it up for my repo.
Below, I will just list what I have done to make this compatible.
(May or may not help someone else besides me)

Terminology:

Preprocessor [Pre] (this repo)
OrigPreprocessor [OrigPre] (repo of "TheBrainFamily")
MyProject [MP] (the project, that uses this Preprocessor)

MyProject

Install package
"@badeball/cypress-cucumber-preprocessor": "github:badeball/cypress-cucumber-preprocessor#master",
Make sure, that your tsconfig.json supports "downlevelIteration": true.

For completions sake, here is my `tsconfig.json` for Cypress

{
  "compilerOptions": {
    "strict": true,
    "baseUrl": "../node_modules",
    "target": "es5",
    "lib": ["es2020", "dom"],
    "types": ["cypress"],
    "downlevelIteration": true
  },
  "include": [
    "**/*.ts",
    "./support",
    "./integration",
    "./fixtures",
    "./plugins"
  ]
}

Change imports

- import { Given, Then, When } from 'cypress-cucumber-preprocessor/steps'; // [OrigPre]
+ import { Given, Then, When } from '@badeball/cypress-cucumber-preprocessor/methods'; // [Pre]

Preprocessor
Either fork and make changes, or directly change inside node_modules (I did the latter to just get it working for me)

Add to [Pre] tsconfig.json (just my preference)

"outDir": "dist // this affects step 7.

In lib/assertions.ts change

- import assert from "assert";
+ import * as assert from "assert";

Because I had troubles with
assert_1.default is not a function

In the root run
npm run build

(You can ignore the build errors, if there are any)
Back to MyProject

In your Cypress folder change plugins/index.js

          {
            test: /\.feature$/,
            use: [
              {
                loader:
-                  'cypress-cucumber-preprocessor/loader',
+                  '@badeball/cypress-cucumber-preprocessor/dist/lib/loader'

Done

This steps, are mainly for self-documentation.
Hopefully, I included everything.
Thx again @badeball for creating this.

Also thx @Igandecki for #1.
Without that, I was totally lost in the Cypress preprocessor world.

Hi, @hiaux0. I think you will have better luck installing the package from NPM, as shown below, rather than from the Github repository. The repository only contains the TypeScript source, which is not meant to be consumed without a build step, which you have experienced.
$ npm install @badeball/cypress-cucumber-preprocessor

You are right, worked out of the box now. Thanks


add new policy, for acceptance of terms

What is state of this PR????

Solved in by @martinhenningjensen: https://github.com/Energinet-DataHub/energy-origin/pull/1414
Therefore closing this issue.


UI is improved

These changes are implemented in the UI.

@niteshjitender Hey there!
We updated the UI from the previous pr.
How about adding a favicon? or a cool animations?


Table parsing omits last row/last cell if only whitespace

Given the following markdown:
|                       | Do not Want | Sometimes | Always |
| --------------------- | ----------- | --------- | ------ |
| Feature A |  |  |  |
| Feature B |  |  |  |

The following should be produced:

Do not Want
Sometimes
Always

Feature A

Feature B

Instead, the cells array omits the last column.
[ 'Feature A', '', '', '' ]
[ 'Feature B', '', '' ]

See #980


[tracking] SSZ containers (beacon chain)

To send and receive information we need to implement SSZ de/serialization for each container listed in the spec. For more information, there's a how-to in native/ssz_nif/README.md
Beacon chain spec containers
Misc dependencies

[x] #78
[x] #51
[x] #52
[x] #53
[x] #54
[x] #55
[x] #56
[x] #57
[x] #58
[x] #59
[x] #61

Beacon operations

[x] #62
[x] #63
[x] #64
[x] #65
[x] #66

Beacon blocks

[x] #67
[x] #68

Beacon state

[x] #69

Signed envelopes

[x] #70
[x] #71
[x] #72

Added in Altair

[x] #73
[x] #74

🎉


iOS: folder highlight does not deactivate upon return

It should fade out like feeds. Right now it doesn't fade out or even deactivate. https://user-images.githubusercontent.com/44229/157031173-3bcb9260-4a5d-45f9-bc0f-4f1aa47aa21a.MOV

I can't get that video to load. The folders are always deactivating for me on iPhone. I've added fading.


Add actionJsAfterModuleImport hook for 8.0.2

Questions
Answers

Description?
Adds a new hook added in https://github.com/PrestaShop/PrestaShop/pull/31285/

Type?
new feature

BC breaks?
no

Deprecations?
no

Fixed ticket?

Sponsor company

How to test?

@sowbiba 8.0.2 release started, I guess this change has to wait for 8.0.3 :(

No problem. We will wait for 8.0.3

@MatShir if we want to have original PR in 8.0.3, we have to accept this PR as well
cc @fabienvallon @WahbiPS


Add scheduling pass

When instruction ordering is fixed, memory coloring can only do a limited job to reduce memory footprint.    Add a pass to reorder instructions, which also has a potential to interleave computation and memory copy to improve throughput.

Scheduling pass added in MIGraphX release 0.2, closing the issue.


RP2040 interface - redo

@Intubun
Yeah I think so too... Its much easier, if all Libs of a person are standardised. Im currently on the MCP_DAC Lib. The changes are working so far, but I need to change a whole lot, if I want to use the RP2040, since the "SPIClass" of the Pico is called "SPIClassRP2040" which is defenetly not great... I will also edit the ESP32 Class, but since I dont have much experience nor the hardware, thats something you need to validate...
Originally posted by @Intubun in https://github.com/RobTillaart/ADS1X15/issues/46#issuecomment-1281849601

Issue moved from ADS1x15 thread.

Please try to keep the changes as local as possible. So don't change the ESP32 part except from putting it behind some #define guards, unless there is no other option. I used the same construction in (almost) all my SPI based device-libs and as you said, I like to keep them identical.
Furthermore additional testing is not planned in my agenda. With ~160 libs to maintain the agenda fills already up easily.
But if needed I surely will do the test.


_PropertyMixin.reload should clear _changes

Because _changes is only a set of changed keys (rather than a COW dict of changed values).


Group logs and show all task headers for plain output

Context
We would like to group output for CI and piped output. See commit messages for how this is achieved.
FIXME: ToolingApiIntegrationTest is broken because a JVM is held open too long due the the executor service.
Contributor Checklist

[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass locally: ./gradlew quickCheck <impacted-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation including proper use of @since and @Incubating annotations for all public APIs

It doesn't appear that ERROR messages are grouped.  I get the following output:
--This is logged at ERROR

:first:logAtEveryLevel
-----
-----
-----
Enumerating all error levels
Current log level is LIFECYCLE
isEnabled(DEBUG): false
isEnabled(INFO): false
isEnabled(LIFECYCLE): true
--This is logged at LIFECYCLE
isEnabled(WARN): true
--This is logged at WARN
isEnabled(QUIET): true
--This is logged at QUIET
isEnabled(ERROR): true
-----
-----
-----

It still groups properly when using rich console.

There seems to be a difference in behavior in the progress bar when running in rich console:
<========-----> 66% EXECUTING [7s]
> :second:logAtEveryLevel
> :second:logAtEveryLevel

This is different in both latest release and in the Daniel's long running output branch.  (Only one worker shows up.  For what it's worth the task logs some output, then sleeps for 10 seconds, and logs some more output.)

Task started and ended events not being grouped (#2044) is a bigger deal with this change.  Before, it was clear that output was not grouped.  Now when running in --console=plain it's difficult to determine if things are grouped incorrectly, or ungrouped.

We need to update the docs that Ben just added to call out that we do group tasks in parallel with --console=plain.

I already did that yesterday based on @eriwen's comment as he knew that it would change soon.

@bmuschko good, I didn't check if that had already happened.

Closing as it is not going to be included in 4.0.


Add a method to disable aws-chunked signing

Describe the feature
Currently all requests with a body larger than 1MB will be chunked and uploaded using aws-chunked encoding.
There is no way to configure this 1MB threshold or to disable chunked requests entirely. This should be added as a configuration option to the SDK.
Is your Feature Request related to a problem?
Related to: https://github.com/awslabs/aws-sdk-kotlin/issues/949
Proposed Solution
No response
Describe alternative solutions or features you've considered
No response
Acknowledge

[X] I may be able to implement this feature request

AWS Kotlin SDK version used

0.19.1-beta

Platform (JVM/JS/Native)
JVM
Operating System and version
MacOS Ventura 13.4

Implemented in https://github.com/awslabs/aws-sdk-kotlin/pull/1224


Default build does not work for 'html' module

When running a just created liftoff project and running html:superDev results in the exception below.
Task :html:draftCompileGwt FAILED
Loading inherited module 'com.virtual_hex.games.freeuniverse.GdxDefinitionSuperdev'
   Loading inherited module 'com.virtual_hex.games.freeuniverse.GdxDefinition'
      Loading inherited module 'com.virtual_hex.games.freeuniverse.Shared'
         [ERROR] Unable to find 'com/virtual_hex/games/freeuniverse/Shared.gwt.xml' on your classpath; could be a typo, or maybe you forgot to include a classpath entry for source?

The resolution is to update this block
task addSource {
    doLast {
        sourceSets.main.compileClasspath += files(project(':core').sourceSets.main.allJava.srcDirs)
        sourceSets.main.compileClasspath += files(project(':shared').sourceSets.main.allJava.srcDirs)
    }
}

in the html modules build.gradle.

I've never actually used the shared project and I'm not totally sure what it was originally meant for (I think code that is used by both client and server). I am guessing this affects more than html but only when shared is in use. This is more of a bug in shared than in html, because you can create a default build of the html module just fine without shared.


Update legend icons size

Summary

This PR updates the size of the icons in the legend so that the are larger when not paired with a line. This PR partially reverts the change made in https://github.com/cerner/carbon-graphs/pull/166 when an icon is used without a line. If an icon is used with a line then the size is unchanged.
Before:

After:

Closes #228
UXPLATFORM-6419
Deployment Link

https://terra-graphs-deployed-pr-#.herokuapp.com/
Testing

Additional Details

Thank you for contributing to Terra.
@cerner/terra
@cerner/carbon

NOTE: This PR also updates most wdio screenshots with updated legend icon size.


Create UTM Parameters (and track) for the How to Get Involved ..Web3 Blog

** Describe the use case**
Track the impact of the How to get Involed in Web3 with Prototol Labs Blog
** Describe the problem**
We want to see what impact the blog has, especially as we disseminate it during Lisbon Crypto month
Proposed Solution
Us plausible.io create tracking links (and a dashboard?) to track the amount of visitors and click to ALL the links in the blog: https://docs.google.com/document/d/1QSYd3i-8bX2JXVG1vdpAyi0tcn9I5YAppJLTaGXNYgQ/edit#

@mrodriguez3313 completion criteria:
I would like a report for the 1 week before, then during, then 2 weeks after lab week generated showing the engagement on all of the links in the blog post. I want to see how many people clicked on each link


Getting AUTH_NOT_AUTHORIZED  in version 13.0.0 and later

Is there an existing issue for this?

[X] I have searched the existing issues

Product
Hot Chocolate
Describe the bug
Starting with version 13.0.0-rc8/13.0.0 all type fields with a [Authorize(Policy = "SomePolicy")] annotation are now always returning an AUTH_NOT_AUTHORIZED error:
{
  "errors": [
    {
      "message": "The current user is not authorized to access this resource.",
      "extensions": {
        "code": "AUTH_NOT_AUTHORIZED"
      }
    }
  ]
}

Until version 13.0.0.-rc7 and without code changes everything works as expected.
Our implementation is very closed on what is described on the HC documentation.
I've checked both the release notes and migration guide on the website, but couldn't find an clue.
I would be very thankful for any hint. At the moment we have to stick at version 13.0.0-rc7.
Steps to reproduce
I've prepared two demo projects for both version 13.0.0-rc7 and 13.0.1 with instructions about how to reproduce the issue.
https://github.com/marcel-rudolph/hc13-issue-demo
Relevant log output
There are no further exceptions or log messages beside the above posted response example.

Additional Context?
No response
Version
13.0.1

I'm having the same problem. I also have a nice sample project created based on the documentation:
https://github.com/WalissonPires/HCAuthTest

@WalissonPires what is you issue exactly. I cloned the repro and works fine.

I think I know where you are stuck and its not a bug. I will have a YouTube episode next week on authorization where I will explain the new system.

@michaelstaib I need the HandleRequirementAsync method to be invoked, to access the IResolverContext. In no time he is called.
Watch the video: https://youtu.be/MH40NTQnFks

@michaelstaib, I'm seeing this same issue.  Can you share some of the context about the new system prior to the youtube video?  Is it still possible to have a custom AuthorizationHandler that has access to the IResolverContext?

@WalissonPires  I believe this is because the policy now by default runs on validation. So there will not be a resolver context and this is also why you get a HttpContext.
If you want to run it not on validation but BEFORE_RESOLVER then you have to specify it:
[Authorize(Policy = "SomePolicy", Apply=ApplyPolicy.BEFORE_RESOLVER)]

Actually ... we have now by default the AuthorizationContext which is available on validation.

For us, the query in in question has a tenant argument which is checked via custom authorization handler to see if the user has permission to that tenant.  It doesn't look like AuthorizationContext has the query deserialized in a such a way as to provide argument access.  Adding ApplyPolicy.BeforeResolver did the trick.
Task HandleRequirementAsync(AuthorizationHandlerContext context, TenantRequirement requirement, IResolverContext resolverContext) {
  if (!HasPermission(context, resolverContext.ArgumentValue<string>("tenant")) {
    context.Fail();
  }
  else {
    context.Succeed(requirement);
  }
}

@PascalSenn It was exactly what he needed. Thanks

Edit: I was wrong, when using ApplyPolicy.BeforeResolver or ApplyPolicy.AfterResolver my query is now executed, but the requirement is never enforced, the policy is bypassed, and HandleRequirementAsync is never invoked.

I believe I've figured out my problem.  Previously our outermost query class was decorated with the AuthorizeAttribute; this no longer invokes the AuthorizationHandler.  After moving the attribute to the query method it works as expected.
// v12
[Authorize(Policy="Stuff")]
public class Query {
public Stuff GetStuff() => new();
}
// v13
public class Query {
[Authorize(Policy="Stuff", Apply = ApplyPolicy.BeforeResolver)]
public Stuff GetStuff() => new();
}

yes and no :)
YouTube episode is coming tomorrow.
youtube.chillicream.com

Thank you for you work!
However...
A YouTube video is not a great way to document code. It is impossible to search, it is missing samples and code that one can copy, it is impossible to compare to previous versions.

Hello @michaelstaib, I'm looking for the youtube video you mentioned. Can you share it please?