Running GEOS CTM

I cloned GEOS CTM and was able to compile it. The ctm_setup script did not properly create the experiment directory because it was still referring to the old configuration (Linux/ instead of install/). I fix the ctm_setup file. The code is crashing during the initialization steps because it cannot create the grid. The code is failing on Line 9193 of MAPL_Generic.F90:
call ESMF_ConfigGetAttribute(state%cf,gridname,label=trim(comp_name)//CF_COMPONENT_SEPARATOR//'GRIDNAME:',rc=status)
VERIFY_(status)

I can quickly understand why there is a problem: the label should only be 'GRIDNAME:'.
I checked a couple of CVS tags I have and could not locate any MAPL version similar to the one in the git repository. I am wondering if MAPL has to be updated before GEOS CTM can run.

I have the CTM running with this version of MAPL. You just need to add something like this into GEOSCTM.rc
GEOSctm.GRID_TYPE: Cubed-Sphere
GEOSctm.GRIDNAME: PE360x2160-CF
GEOSctm.NF: 6
GEOSctm.LM: 72
GEOSctm.IM_WORLD: 360

Thank you. Very interesting. If it works, I will change the set up script...

Do you have by chance an experiment directory on discover I can look at? Thanks.

I do have an experiment located at: /discover/nobackup/kgerheis/experiments/ctm_test_experiment
I think there might be a few other small things you need to change to get it to run. If you run into any errors I can probably quickly diagnose them as I've gone through this process several times.

Kyle: Thank you. I will get back to you if I need more assistance.

Kyle:
It seems that I am still missing something as my code continues to crash. My working directory is:
/gpfsm/dnb32/jkouatch/GEOS_CTM/GitRepos/testTR
I believe that I have a rc setting issue that I cannot identify. I noticed that in my standard output file I have:
In MAPL_Shmem:
NumCores per Node =           96
NumNodes in use   =            1
Total PEs         =           96
In MAPL_InitializeShmem (NodeRootsComm):
NumNodes in use   =            1
That is not correct as there should be 4 nodes in use.

You need to register the grid for the GridManager before you can create the grid by adding this to AdvCore_GridComp.F90.
subroutine register_grid_and_regridders()
    use MAPL_GridManagerMod, only: grid_manager
    use CubedSphereGridFactoryMod, only: CubedSphereGridFactory
    use MAPL_RegridderManagerMod, only: regridder_manager
    use MAPL_RegridderSpecMod, only: REGRID_METHOD_BILINEAR
    use LatLonToCubeRegridderMod
    use CubeToLatLonRegridderMod
    use CubeToCubeRegridderMod

    type (CubedSphereGridFactory) :: factory

    type (CubeToLatLonRegridder) :: cube_to_latlon_prototype
    type (LatLonToCubeRegridder) :: latlon_to_cube_prototype
    type (CubeToCubeRegridder) :: cube_to_cube_prototype

    call grid_manager%add_prototype('Cubed-Sphere',factory)
    associate (method => REGRID_METHOD_BILINEAR, mgr => regridder_manager)
      call mgr%add_prototype('Cubed-Sphere', 'LatLon', method, cube_to_latlon_prototype)
      call mgr%add_prototype('LatLon', 'Cubed-Sphere', method, latlon_to_cube_prototype)
      call mgr%add_prototype('Cubed-Sphere', 'Cubed-Sphere', method, cube_to_cube_prototype)
    end associate

  end subroutine register_grid_and_regridders

and calling it in AdvCore SetServices (line 318)
if (.NOT. FV3_DynCoreIsRunning) then
         call fv_init2(FV_Atm, dt, grids_on_my_pe, p_split)
         call register_grid_and_regridders() ! add this line
end if

This register_grid_and_regridders routine duplicates code in DynCore and should probably be added to its own module that AdvCore and DynCore can call.

Kyle: That helps to go further. Thanks. The code still crashes. I am now running in a debugging mode...

Jules, keep reporting the problems you are running into since I had to go through these issues as well when getting GCHP to work with the new MAPL. I may be able to help.

One note of caution so that you do not make the same mistake I did. Regarding the earlier comment to add this to your config file:
GEOSctm.GRID_TYPE: Cubed-Sphere
GEOSctm.GRIDNAME: PE360x2160-CF
GEOSctm.NF: 6
GEOSctm.LM: 72
GEOSctm.IM_WORLD: 360

I made the mistake of adding the prefix (in my case GCHP. rather than GEOSctm.) to the existing lines rather than adding them. This caused a silent bug in AdvCore_GridCompMod.F90 since it expects entries for prefixes IM, JM, and LM in the file. If those lines are not found then the calculated areas get messed up since it uses default values.
My fix was to change AdvCore_GridCompMod.F90 to expect lines with the prefix rather than without.
-      call MAPL_GetResource( MAPL, FV_Atm(1)%flagstruct%npx, 'IM:', default= 32, RC=STATUS )
+      ! Customize for GCHP (ewl, 4/9/2019)
+!      call MAPL_GetResource( MAPL, FV_Atm(1)%flagstruct%npx, 'IM:', default= 32, RC=STATUS )
+      call MAPL_GetResource( MAPL, FV_Atm(1)%flagstruct%npx, 'GCHP.IM:', default= 32, RC=STATUS )
       _VERIFY(STATUS)
-      call MAPL_GetResource( MAPL, FV_Atm(1)%flagstruct%npy, 'JM:', default=192, RC=STATUS )
+!      call MAPL_GetResource( MAPL, FV_Atm(1)%flagstruct%npy, 'JM:', default=192, RC=STATUS )
+      call MAPL_GetResource( MAPL, FV_Atm(1)%flagstruct%npy, 'GCHP.JM:', default=192, RC=STATUS )
       _VERIFY(STATUS)
-      call MAPL_GetResource( MAPL, FV_Atm(1)%flagstruct%npz, 'LM:', default= 72, RC=STATUS )
+!      call MAPL_GetResource( MAPL, FV_Atm(1)%flagstruct%npz, 'LM:', default= 72, RC=STATUS )
+      call MAPL_GetResource( MAPL, FV_Atm(1)%flagstruct%npz, 'GCHP.LM:', default= 72, RC=STATUS )

Lizzie,
Thank you for your comments. I am wondering if it was necessary to make any change to my GEOSCTM.rc file as the AdvCore source coide has:
     call MAPL_GetResource( MAPL, FV_Atm(1)%flagstruct%npx, 'IM:', default= 32, RC=STATUS )
     call MAPL_GetResource( MAPL, FV_Atm(1)%flagstruct%npy, 'JM:', default=192, RC=STATUS )
     call MAPL_GetResource( MAPL, FV_Atm(1)%flagstruct%npz, 'LM:', default= 72, RC=STATUS )

In any case, my code is still crashing and I still trying to figure out why.

Something unusual that I mentioned before is the following print out at the beginning of the code:
In MAPL_Shmem:
NumCores per Node =           84
NumNodes in use   =            1
Total PEs         =           84
In MAPL_InitializeShmem (NodeRootsComm):
NumNodes in use   =            1
I went ahead in MAPL_ShmemMod.F90 and printed the name of all the processors (nodes) after the call:
call MPI_AllGather(name ,MPI_MAX_PROCESSOR_NAME,MPI_CHARACTER,&
names,MPI_MAX_PROCESSOR_NAME,MPI_CHARACTER,Comm,status)
All the entries of the variable "names" only had the name of the head node. Something is wrong but I do not know what. I am sure that that there is a new rc setting I need to add.

@JulesKouatchou This sounds suspiciously like calling MPT with mpirun. How are you running your executable? If you're using MPT (which you probably are), you need to use either mpiexec_mpt or use esma_mpirun (which autodetects MPI stack and will run mpiexec_mpt)

@JulesKouatchou Actually, I might need to work with you on the ctm_setup script. There are some changes we had to make to gcm_setup for the move to CMake that aren't reflected in that script as I see it on this repo. It's possible it's getting confused and picking the wrong MPI stack or the like.

@mathomp4 That is something I had to change in ctm_run.j, and why I asked you about MPT's mpirun. I changed RUN_CMD to mpiexec

@mathomp4
I made changes in my ctm_setup in order to have a complete experiment directory. The script was still referring for instance to the Linux/ directory.
In my ctm_run.j file, RUN_CMD is set to "mpirun" not "mpiexec". I will make a change and see what happens.

Things are moving in the right directing. I now have as expected:
In MAPL_Shmem:
NumCores per Node =           28
NumNodes in use   =            3
Total PEs         =           84
In MAPL_InitializeShmem (NodeRootsComm):
NumNodes in use   =            3
The code is still crashing but this time in:
GEOSctm.x<PHONE_NUMBER>8A9E47  fv_statemod_mp_co        3160  FV_StateMod.F90
GEOSctm.x<PHONE_NUMBER>868BAF  fv_statemod_mp_fv        2902  FV_StateMod.F90
GEOSctm.x<PHONE_NUMBER>4B2B6B  geos_ctmenvgridco         926  GEOS_ctmEnvGridComp.F90
It appears in the manipulations of U & V. My guess is that U & V are not properly read in or I am missing a rc setting somewhere.

@JulesKouatchou Can you tell me which branch of GEOSgcm_GridComp is being used?   Lines 3160 and 2902 don't seem right for this type of error.     (I wanted to check on an uninitialized pointer that crops up in FV_StateMod from time to time.)

@JulesKouatchou  Also - worth learning how to include references to code-snippets in tickets.   Easier to show you when you are here, but you can also find it by googling.   As an example, I'll show the sections around the line numbes you mentioned above:
https://github.com/GEOS-ESM/GEOSgcm_GridComp/blob/b4446a6504226c3933fd34f4a842a44ba8b7333b/GEOSagcm_GridComp/GEOSsuperdyn_GridComp/FVdycoreCubed_GridComp/FV_StateMod.F90#L3154-L3168

@tclune I do not know how to include references to code-snippets of external components/modules of the CTM. I will try to figure it out.

@JulesKouatchou Check this out: https://help.github.com/en/articles/creating-a-permanent-link-to-a-code-snippet. Thanks @tclune (I did not know about this).

Note - this used to work better.  Rather than a link  you would actually see the lines of code in the ticket (and the email).    I see that someone has raised the issue with GitHub.  Started working wrongly (for some users) 2-3 weeks ago.

Oh - it's because we are linking to text from a different repo.   For the same repo it works really nicely.  E.g.
https://github.com/GEOS-ESM/GEOSctm/blob/4b2ac7de41c4a34b0a04a36b9f5239a02a7b77db/src/Components/GEOSctm_GridComp/CTMdiffusion_GridComp/GmiDiffusionMethod_mod.F90#L305-L322

Very nice. Not sure if you guys use Slack, but it shows up nicely in Slack chats as well.

@JulesKouatchou
In fv_computeMassFluxes_r8 you need to initialize uc and vc to 0.0 at the beginning of the subroutine before they are assigned in lines 2916-2917 in FV_StateMod.F90.
  uc(is:ie,js:je,:) = ucI
  vc(is:ie,js:je,:) = vcI

I can reproduce the crash in tp_core with debugging turned off

I'm not sure what to make of this:
I added a print statement to tp_core where the crash is occurring (divide by zero) to check if the divisor was really small, and adding the print statement made the crash go away.

We seem to be accumulating a sizable number of mysteries in the FV layer recently.
Just yesterday  Rahul made a change to the model entirely outside of FV, but it produced a runtime error in a write statement.
I certainly encourage you to use aggressive debugging options under both gfortran and Intel in the hopes that it exposes something.   But if you've already done that ...   Valgrind?

There is the outstanding issue that the cat fvcore_layout.rc >> input.nml in the run fails on occasion….  This can produce inconsistent and undesirable effects in FV3.
-- Bill Putman
William M Putman
Global Modeling and Assimilation Office
NASA Goddard Space Flight Center
Cell:<PHONE_NUMBER>
Desk:<PHONE_NUMBER>
From: Tom Clune<EMAIL_ADDRESS>Reply-To: GEOS-ESM/GEOSctm<EMAIL_ADDRESS>Date: Wednesday, September 4, 2019 at 1:16 PM
To: GEOS-ESM/GEOSctm<EMAIL_ADDRESS>Cc: William Putman<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [GEOS-ESM/GEOSctm] Running GEOS CTM (#15)
We seem to be accumulating a sizable number of mysteries in the FV layer recently.
Just yesterday Rahul made a change to the model entirely outside of FV, but it produced a runtime error in a write statement.
I certainly encourage you to use aggressive debugging options under both gfortran and Intel in the hopes that it exposes something. But if you've already done that ... Valgrind?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_GEOS-2DESM_GEOSctm_issues_15-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAJ3CE6YUFCSDGC36K7UFKFTQH7UNFA5CNFSM4ILMJQY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD54J2EY-23issuecomment-2D527998227&d=DwMCaQ&c=ApwzowJNAKKw3xye91w7BE1XMRKi2LN9kiMk5Csz9Zk&r=z8dOdDWhHEg9eMypAGBSzN9nm21DGJm0jA6XVVJVjjw&m=I-yOkL6Q0iXQ8lB1MzEyXC4UJtxh9csLc4afvj8p3_E&s=zc4YovTlH63o4UdZMtWga6uSnzvyqhzy3gPtffS099M&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AJ3CE66BJLMUP4HWB4DXV2DQH7UNFANCNFSM4ILMJQYQ&d=DwMCaQ&c=ApwzowJNAKKw3xye91w7BE1XMRKi2LN9kiMk5Csz9Zk&r=z8dOdDWhHEg9eMypAGBSzN9nm21DGJm0jA6XVVJVjjw&m=I-yOkL6Q0iXQ8lB1MzEyXC4UJtxh9csLc4afvj8p3_E&s=rxXrbpxXeaUHZgub5JkLaY4zmu0zkPhgmnfTViys1g4&e=.

There is the outstanding issue that the cat fvcore_layout.rc >> input.nml in the run fails on occasion…. This can produce inconsistent and undesirable effects in FV3.

@wmputman,
Did you ever try using Rusty's INTERNAL_FILE_NML as seen in GEOS-ESM/GEOSgcm#34? Maybe it's just thousands of cores trying to open the same file that could cause issues?

The trouble is that sometimes the input.nml file is completely empty, before the executable even begins.
-- Bill Putman
William M Putman
Global Modeling and Assimilation Office
NASA Goddard Space Flight Center
Cell:<PHONE_NUMBER>
Desk:<PHONE_NUMBER>
From: Matthew Thompson<EMAIL_ADDRESS>Reply-To: GEOS-ESM/GEOSctm<EMAIL_ADDRESS>Date: Thursday, September 5, 2019 at 3:02 PM
To: GEOS-ESM/GEOSctm<EMAIL_ADDRESS>Cc: William Putman<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [GEOS-ESM/GEOSctm] Running GEOS CTM (#15)
There is the outstanding issue that the cat fvcore_layout.rc >> input.nml in the run fails on occasion…. This can produce inconsistent and undesirable effects in FV3.
@wmputmanhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_wmputman&d=DwMFaQ&c=ApwzowJNAKKw3xye91w7BE1XMRKi2LN9kiMk5Csz9Zk&r=z8dOdDWhHEg9eMypAGBSzN9nm21DGJm0jA6XVVJVjjw&m=4POwBSIGtkD8eV5LFoYo1uz9SjFu2nJFVDbBQ0ImsBA&s=4a_Pf6_xAbVX8NpzU9q21MfFftaKueNnWduu6_FGWJQ&e=,
Did you ever try using Rusty's INTERNAL_FILE_NML as seen in GEOS-ESM/GEOSgcm#34https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_GEOS-2DESM_GEOSgcm_issues_34&d=DwMFaQ&c=ApwzowJNAKKw3xye91w7BE1XMRKi2LN9kiMk5Csz9Zk&r=z8dOdDWhHEg9eMypAGBSzN9nm21DGJm0jA6XVVJVjjw&m=4POwBSIGtkD8eV5LFoYo1uz9SjFu2nJFVDbBQ0ImsBA&s=WOoXs3v-FXHYTP27olxJZC_Egho5g3mhVGFpYxef7Nk&e=? Maybe it's just thousands of cores trying to open the same file that could cause issues?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_GEOS-2DESM_GEOSctm_issues_15-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAJ3CE62CUZVATY5FRPPKJDLQIFJT7A5CNFSM4ILMJQY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6ALDSY-23issuecomment-2D528527819&d=DwMFaQ&c=ApwzowJNAKKw3xye91w7BE1XMRKi2LN9kiMk5Csz9Zk&r=z8dOdDWhHEg9eMypAGBSzN9nm21DGJm0jA6XVVJVjjw&m=4POwBSIGtkD8eV5LFoYo1uz9SjFu2nJFVDbBQ0ImsBA&s=-9QiXCZO8kcmt27rmDgJ45UrXzQ5qamY_y0qXmdlEYU&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AJ3CE64XWPO6UKSZTVUOQTTQIFJT7ANCNFSM4ILMJQYQ&d=DwMFaQ&c=ApwzowJNAKKw3xye91w7BE1XMRKi2LN9kiMk5Csz9Zk&r=z8dOdDWhHEg9eMypAGBSzN9nm21DGJm0jA6XVVJVjjw&m=4POwBSIGtkD8eV5LFoYo1uz9SjFu2nJFVDbBQ0ImsBA&s=fSePOJQnpG120cd-0BfFXBDXComTkLp-rtmzL-3QBbo&e=.

The trouble is that sometimes the input.nml file is completely empty, before the executable even begins.

That sounds like an issue in the scripting then. No matter what, we can never not do an append because the coupled model (@yvikhlya) actually has an input.nml file that controls all of MOM. Thus, we need to append the rc file to it.
I could belt-and-suspender it, with scripting. We could put in detection before GEOSxxx.x runs that if input.nml is empty, die, or try the append again? Hmm.

I was able to run the CTM version on github jules pointed me to with a few modifications outlined in the comments here. THis appears to be based on Jason-3_0. I too was only able to run the debugged version but I can confirm that there does appear to be a memory leak. After 4 days the at c90 with the tracer case he pointed me to the memory use went from about 18% to 50%. I also was able to update MAPL to the version on the development branch (which required other updates in other repos). I was once again able to run the c90 tracer case. The memory leak is much smaller. I'll edit this comment to report more detailed numbers tomorrow.

That's very encouraging on the memory front.
Might need to up the priority for investigating the no-debug failure now.

When I compile in a no-debug mode, the code crashes on Line 999 of:
       FVdycoreCubed_GridComp/fvdycore/model/fv_tracer2d.F90

It is:
if (flagstruct%fill) call fillz(ie-is+1, npz, 1, q1(:,j,:), dp2(:,j,:))
If I comment out the line, the code can run. I have not figured out yet why the code crashes in the subroutine "fillz" that is inside:
      FVdycoreCubed_GridComp/fvdycore/model/fv_fill.F90

It seems that something is happening in the code segment (Line 87-92):
  do i=1,im
     if( q(i,1,ic) < 0. ) then
         **q(i,2,ic) = q(i,2,ic) + q(i,1,ic)*dp(i,1)/dp(i,2)**
         q(i,1,ic) = 0.
      endif
  enddo

It crashes in fv_tracer2d? Based on your previous post, and from my testing it crashes in tp_core.

Here is what I am getting:
MPT: #6  0x000000000173a21e in fv_fill_mod::fillz (
MPT:     im=<error reading variable: Cannot access memory at address 0x14>,
MPT:     km=<error reading variable: Cannot access memory at address 0x4>,
MPT:     nq=<error reading variable: Cannot access memory at address 0x0>,
MPT:     q=<error reading variable: Cannot access memory at address 0x7fffffff3590>, dp=...)
MPT:     at /gpfsm/dnb32/jkouatch/GEOS_CTM/GitRepos/GEOSctm/src/Components/GEOSctm_GridComp/@GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSsuperdyn_GridComp/FVdycoreCubed_GridComp/fvdycore/model/fv_fill.F90:89
I read somewhere that one way to remove the "error reading variable: Cannot access memory" error is to change the compilation options. Perhaps it is why the code can run with debugging options turned on.

Looks like it might be MPT related. I was building with Ifort and Intel MPI. Maybe that's why I don't get that bug.
Right now I'm working on building with gfortran and OpenMPI in hopes that will expose some bugs.

@JulesKouatchou Do you know what MPT environment variables are set with the CTM? It's possible one of the many we set for the GCM are needed for the CTM?

Oh wow. I probably need the expertise of @tclune for my question with this code. So we have:
if (flagstruct%fill) call fillz(ie-is+1, npz, 1, q1(:,j,:), dp2(:,j,:))

and now the fillz routine:
 subroutine fillz(im, km, nq, q, dp)
   integer,  intent(in):: im                !< No. of longitudes
   integer,  intent(in):: km                !< No. of levels
   integer,  intent(in):: nq                !< Total number of tracers
   real , intent(in)::  dp(im,km)           !< pressure thickness
   real , intent(inout) :: q(im,km,nq)      !< tracer mixing ratio

Now q1 and dp2 are:
real ::   q1(bd%is :bd%ie ,bd%js :bd%je , npz   )! 3D Tracers
      real  dp2(bd%is:bd%ie,bd%js:bd%je,npz)

which means we are sending a weird 2d-slice of q1(:,j,:) to a 3-D q in fillz?
So does Fortran guarantee that q1(is:ie,j,npz) maps equally to q(ie-is+1,npz,1) when passed through the interface of a subroutine? They are the same size in the end (ie-is+1*npz), but ouch.  I created two temporary variables loc_q1(ie-is+1,npz,1) and loc_dp2(ie-is+1,npz). The code still crashed at the same location.

You can do that in Fortran. They are the same size, and the arrays are contiguous. So all you're really changing is how you index the memory. It's sort of like passing a pointer in C; you can index it as an array however you like (within its bounds). Only in Fortran this is all taken care of by the language/compiler.

@mathomp4 Unfortunately, this style is acceptable according to the standard.  (But I'd much prefer not to fix F90 and F77 array styles.)
As @kgerheiser explains,  the compiler is forced to make copies due to the explicit shape of the dummy arguments.      Without aggressive debugging flags, the sizes don't even have to agree.

I want to add that when I run the stand alone DynAdvCores, I do not have an issue. My guess is that the fillz subroutine is not called.

Runs fine in non-debug mode with Gfortran + OpenMPI

I'm seeing that if I run ifort+intel mpi with the initial testing branch Jules created, I am crashing in fillz with a floating invalid. I think this is a red herring as the optimized build is sending in negative tracers in the call to mapn_tracer which ultimately calls fillz! The debug build is not, the minimum tracer value is zero

I've found that if you remove the entries associated with "hord_*" that causes the crash to switch to tp_core.
I have been using TotalView and its memory debugger to catch the problem, but it yields nothing useful. I can see that memory is corrupted (at least according to TotalView), but if you add a print in the code the values are fine.
And due to the problem only being present when optimization is enabled when you step through the code it jumps around, so it's hard to see what's happening.

I have found that both crashes are during the vdivpd instruction, and that turning off vectorization using the -no-vec flag allows it to run.

@kgerheiser I'm slowly getting caught up now on missed stuff. Is it only one file that needs -no-vec? I'd prefer not to do all of FV without it since, well, vectorization gave us some speed up.


How to change the background colour from "orange" to something else :)

Thank you for the amazing work, I am wondering if there is a way to change the default "orange" colour to something else? Thanks

Hi @dunkarooftop, sorry for the slow reply!
I assume you mean the colour of the mode line highlight? These are controlled by the following faces,
'(
  ;; Active faces
  spaceline-highlight-face ;; The face that changes the highlighted part
  powerline-active1  ;; The face used for the second segment
  powerline active2  ;; The face used for the third segment
  mode-line  ;; The face used for the middle part of the mode line

  ;; Inactive faces
  powerline-inactive-1
  powerline-inactive-2
  mode-line-inactive
)

So if you want to change it from orange to a different colour, you could try
(use-package spaceline-all-the-icons
  :config
  (set-face-attribute 'spaceline-highlight-face :background "#3498db")) ;; For blue instead!

Hope this helps, if you have any more questions feel free to ask :)

Thank you... Those little icon you made possible make my eye happy.. :)

w


Create unit_test.yml

combined with hv_orgainze_test

(here it makes sense that the unit tests are failing, would need to wait on PR #163 to come through


Add Synapse homeserver.yml instruction to README

see #404
I'm not good at English language, so there is probably needed some grammar review by others.
Pull Request Checklist

[x] Pull request includes a sign off

Closing in favour of https://github.com/matrix-org/sliding-sync/pull/443


AMQP transporter

Add AMQP support with amqp.node

@icebob I'd like to take a shot at this. I will open up a PR once I'm a little further along.

Great! Thanks!


Ensure build version for shortcode asserts is explicit in the logs

Shortcodes can change from build to build. So on its own a shortcode may not be enough to indicate where the error occurred.
Furthermore, different parts of the code can be at different builds in a single session (e.g. loader v. runtime), and there's no indication of which layer a tagged line is in.
Proposal: Add an address space to the shortcodes that indicates which layer it's from, so we can coordinate with the build version property in the logs (e.g. loaderVersion v. runtimeVersion)

@vladsud, @anthony-murphy, @curtisman  - This feels really important for our GA release to me.  I think it's a quick fix - Implement assert in each "layer" (loader, runtime, driver?) and | in a tag like 0x1000, 0x2000 or 0x3000 for each layer so the shortcodes don't overlap across layers, and we know which fooVersion field to check in the logs.
Or would it work to import packageVersion in each implementation of assert and add a column assertVersion?

I thought short code are checked in and won't change version to version?   What does the work flow looks like right now?

I'll have to look again at how it works. I'm imagining a scenario where a tagged assert is deleted from one layer and an untagged assert is added somewhere else, and reuses that tag.  Maybe that can't happen.
Ok here's a more realistic scenario - some code gets copied from one layer to another, tags and all.

I do not think adding layer tag would help. It might scope the problem (if it exists) to smaller problem, but fundamentally it does not change the problem of moving code around or copying inside one layer.
If problem exists, I'd look into minimizing it in tagger, i.e.

for removed tags, do not reuse them for some time (this requires some kind of storage / database)
for duplicated tags, use prior data to resolve which tag stays and which one gets changed.

Overall, this is not unique problem - devmain has exactly same constraints (though it does use DB for tracking and minimizing impact of user operations), but one thing developer has at his/her disposal - using exact branch of code where assert originates from. It does mean that we occasionally need to slice data by versions, but in my experience that's not a big deal (especially if tooling attempts to do its best to preserve tags and resolve duplicates correctly).

We don't reuse tag in and they are globally unique. Currently we scan the code base to find the highest, and increment from there. if the n largest are removed we would end up reusing those. if we are worried about that scenario, we can start stamping the last number is file somewhere.

I'm personally not too worried about the highest code reuse problem. for it to happen a code would need to be added and removed before another code is added. this seems unlikely, and in that case the original code wasn't around very long

Ok.  I am willing to close this.  The scenario where we'd be stuck is if someone cuts and pastes and then changes the condition but keeps the shortcode.  We should keep an eye out for this in PRs - don't reuse shortcodes if you're materially changing the condition.
I'm trying to think about where dev docs for this should go.  Maybe the repo wiki...?


Remove double plotting of initial estimate in AllXY

The initial estimate was plotted twice, this is removed
Add dataset location to plot title

@eendebakpt We can add this one to the release if you rebase.


Building the project using the stable toolchain

Hi,
I have just found your project and am trying to use it with the stable toolchain but it won't build. This is because of the features in lib.rs:
#![feature(maybe_uninit_uninit_array, maybe_uninit_slice, try_trait_v2)]

I assume this is intended? It would be nice if it was possible to build the project with the stable toolchain as well. I created a fork where I removed the usages of the features and it seems to work. The changes are about 40 lines of code that are changed removed.
I think the maybe_uninit_uninit_array and maybe_uninit_slice features can be removed entirely. Maybe it is possible to wrap the try_trait_v2 in its own feature? This way I could opt out and use the stable toolchain to build.
Thank you for your work by the way works great :)

Its true that the uninitfeatures are not needed and are only used for a minor performance uplift. The try_trait_v2 stuff was mostly done as an experiment.
If you can put the code that uses these features behind a feature flag and make a PR i will merge it. Otherwise I will have a look on my own, when I come around to it.

Published in 0.8.0


Profiler information is not shown

From<EMAIL_ADDRESS>on 2014-05-28T07:20:51Z
Spyder Version:  2.3.0rc
Python Version:  3.3.5
Qt Version    :  4.8.4, PyQt4 (API v2) 4.9.6 on Windows
pyflakes >=0.6.0:  None (OK)
pep8 >=0.6      :  None (NOK)
IPython >=0.13  :  2.0.0 (OK)
pygments >=1.6  :  1.6 (OK)
sphinx >=0.6.6  :  1.2.2 (OK)
psutil >=0.3    :  2.1.0 (OK)
rope >=0.9.2    :  0.9.4 (OK)
matplotlib >=1.0:  1.3.1 (OK)
sympy >=0.7.0   :  0.7.5 (OK)
pylint >=0.25   :  1.1.0 (OK)
What steps will reproduce the problem?

Open a script and press F10 to run the profiler
The profiler runs and says "Profiling, please wait"
Nothing appear in the columns below, only the column headers

What is the expected output? What do you see instead?
One should see the list of functions and the corresponding execution times and number of calls
Please provide any additional information below
.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1835

From contrebasse on 2014-05-29T06:48:26Z
It may be a dumb question but as it says "Profiling, please wait", did you actually wait long enough ?

From contrebasse on 2014-06-02T08:44:19Z
Alright, point (ii) makes clear that the script is not stuck.
If you click on the Output button after running your script with the profiler, it will show a window with the script output. Check that there is no problems here.
Could you also have a look at the internal console (you may have to activate it first in the display menu) and report any error message that you see ?
Thanks.

From<EMAIL_ADDRESS>on 2014-05-30T03:12:06Z
Yes, the profiling information never appears, no matter how long I wait. Moreover (i) the "Profile" button, which is grey during profiling, becomes green and (ii) the "Profiling, please wait..." message disappears and becomes the date and time and (iii) the CPU usage drops near zero, all as expected when profiling ends. However no profiling information appear.
As additional information, if I repeat the very same steps in another window, using the same scriopt, but with Python 2.7.6 with Spyder 2.2.5, everything works as expected and the profiling windows shows the list of functions and corresponding times/calls (in all cases I am using a WinPython distribution).

From<EMAIL_ADDRESS>on 2014-06-02T12:36:34Z
The Output button shows the printed output from the procedure with no errors. The internal console shows the following, without error messages
Inspect Spyder internals:
spy.app, spy.window, dir(spy)
>>>
However I just realized this is different from what I get using the older version of Spyder, where profiling works normally. Namely I don't get the Python/Spyder version. I am attaching it here in case it matters:
Spyder 2.2.5 internal shell on Python 2.7.6 64bits [Windows]
Inspect Spyder internals:
spy.app, spy.window, dir(spy)
>>>

From<EMAIL_ADDRESS>on 2014-07-06T03:04:30Z
I made a clean install of Windows 8.1 64bit and Anaconda 2.0.1 64bit with Python 3.4. It comes with Spyder 2.3.0rc preinstalled.
I can confirm that issue #1835 is still present. Profiling with Spyder is not available in this configuration.

From<EMAIL_ADDRESS>on 2014-07-06T06:10:52Z
If you install from bitbucket it should be fixed, I made a pull request for issue #1628 which is a duplicate of this one, the pull request got merged into default 4 days ago.

From ccordoba12 on 2014-07-06T06:21:32Z
Yes, this was already fixed and will be released with the final 2.3.0 release. Sorry for not noticing that this was duplicate a issue #1628 .
Status: Duplicate
Mergedinto: 1628


Display warning banner when workspace lies within appRoot (#138815)

This PR fixes #138815.

/assign @bpasero

I just spotted the INativeEnvironmentService layer breaker. @bpasero maybe you can suggest the right way to resolve this.

Yes I am on it.

Thanks! Moved it into a place where we already show warnings.


228 add release information to README

This closes #228. Please let me know if the verbiage needs to be updated.

I believe that issue #228 has already been addressed by #230. @ina-stoyanova is that correct? If so, we should close issue #228.

@infraredgirl That's correct! Thanks for catching this!
@alvarodelvalle Thanks for your contribution here! It's a bit of a confusion, since I assumed this issue would be auto-closed, once the PR I raised & merged was closed. Turns out I forgot to link this issue to the PR 🙄 Sorry for the confusion!

I still had a look at your changes to the Readme and verified that we've got it all in the Readme currently. That was the case indeed, so I'll be closing this PR.


Invalid method used for initialising GlobalTracer in opentracing-shim example

The OpenTelemetry API was changed to use setGlobalTracerProvider(provider) instead of initGlobalTracerProvider(provider). The change made at the time appears to have broken the opentracing-shim example in the below two files as it also updated the opentracing.initGlobalTracer(shim) call to opentracing.setGlobalTracer(shim).
https://github.com/open-telemetry/opentelemetry-js/pull/839/files#diff-90edab116f366300c10d75d1152a0c90
https://github.com/open-telemetry/opentelemetry-js/pull/839/files#diff-91dfa22f1a98990b3bc83ba65bcdee0a

I'll have a PR for this shortly.


Request Access Does not Work

https://app.staging.crisiscleanup.io/request_access: "Volunteer with Your Org" does not work.

I just tried it and it worked. What are you seeing?

Nothing happens when you click "Volunteer with Your Org." FF.


Learn-from not working

Hi,
I am specifying a file to learn from with -l but nothing get classified even if transactions are similar.
How can I troubleshoot?

This should be fixed in #79 .  If not, please let me know.

Thanks for coming back to this issue. Sorry for the late reply. I don't use the software at the moment but it helped me a lot at the time. I will contact you via github issues in the future if I reuse in the future and encounter problems.


Integrate Rockset as a vector store

Description
Added Rockset as a vector store to llama index.

Rockset is a real-time analytics database which enables queries on massive, semi-structured data without operational burden. Rockset is serverless and fully managed. It offloads the work of managing configuration, cluster provisioning, denormalization, and shard / index management. Rockset is also SOC 2 Type II compliant and offers encryption at rest and in flight, securing and protecting any sensitive data. Most teams can ingest data into Rockset and start executing queries in less than 15 minutes.

Added example notebook and integration tests.
Ran black and mypy and everything's good.
Type of Change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Added new unit/integration tests
[x] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[X] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Thanks for the contribution! If you could resolve the merge conflict, would be happy to help merge this!

Thanks @Disiok. Merge conflicts are now fixed.

ah also, many tests are failing 👀

@logan-markewich thanks for your review. I have addressed your comments in my latest changes. Please take a look.
BTW no tests are failing now.

Thanks for the work on this @gadhagod ! Merging!


fix: default log level to debug

Since the stack already handle logs filtering itself.
Fixes #88

small question otherwise lgtm :)

That's it
On Fri, Feb 16, 2018 at 9:13 AM, Grégory Le Garec<EMAIL_ADDRESS>wrote:

@gregorylegarec approved this pull request.
Seems nice (and helpful) !
In libs/logger.js
https://github.com/cozy/cozy-konnector-libs/pull/89#discussion_r168694062
:

const env = (env2formats[NODE_ENV] && NODE_ENV) || 'production'

-let level = LOG_LEVEL || (DEBUG && DEBUG.length ? 'debug' : 'info')
+let level = LOG_LEVEL || 'debug'
Does that mean that by default, every konnector is at debug level, and
the log filtering is done by the stack ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cozy/cozy-konnector-libs/pull/89#pullrequestreview-97103649,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAN9V9LCqdazv7iQRNNHIp3BAifSuImfks5tVTi7gaJpZM4SHgdP
.


release-20.2: backup: revalidate restored indexes if added during inc backup

PR: https://github.com/cockroachdb/cockroach/pull/63314
From release notes:

RESTORE now re-validates restored indexes if they were restored from an incremental backup that was taken while the index was being created. [#63314][#63314] {% comment %}doc{% endcomment %}

cc @lnhsingh, @kathancox

Closing this issue as I think this was taken care of with #10498. Feel free to reopen, if otherwise.


Shift to Builder methods on svdparser temporarily

This is not currently a mainline feature, but once rust-embedded/svd#101 is merged it will be. Does currently cause builds of the SVD to fail as the builder methods check for name validity and some of the register names that idf2svd are generating are not valid due to including bracket characters.

Perfect, thanks!


compare_pams.Rmd produces an automated status report comparing two PAMS datasets

In this PR, I update the compare_pams.Rmd file to produce an automated status report, comparing two PAMS datasets.
Expectations are checked between the two datasets. Succesful expectations yield a blue message, failed expectations yield a red warning.
In certain cases, threshold values are required (e.g. we don't expect global production to change by more than X%). These threshold values can be updated in the config.yml.

Is this section supposed to look like this?


nodejs: cleanup files no longer needed

Motivation for this change
Things done

Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Fits CONTRIBUTING.md.

NodeJS 5.x is not maintained upstream anymore and thus should be removed.

Also backported the removal of nodejs-5_x from all-packages.nix by @grahamc: 9634155e3c5764b176e09b32bae8e3eec162c1df

This fails on 16.09: http://hydra.nixos.org/build/43456574/nixlog/1/raw

This is because node 0.10 (which had reached end of LTS) has been removed from master [1] but is still on the 16.09 branch [2].
[1] https://github.com/NixOS/nixpkgs/commit/162c65fc87d8e0fc450d2f95dda3f7b3b91987a2
[2] https://github.com/NixOS/nixpkgs-channels/tree/nixos-16.09/pkgs/development/web/nodejs


OpenAI content-filter example needed

Is your feature request related to a problem? Please describe.
There is an example in Python at https://learn.microsoft.com/en-us/azure/ai-services/openai/concepts/content-filter.
Can you provide an example in JavaScript, especially for the streaming situation, say, along with function listChatCompletions.
Thank you in advance,

Thanks @MRYingLEE for opening this report! We're adding a sample in https://github.com/Azure/azure-sdk-for-js/pull/27024 and I will reach out to the docs team to discuss adding it to the docs website.

Hi @MRYingLEE, The JS example has been added to the documentation webpage above. Please let us know if you have any more questions!


Add input param to set the check name where the results will be reported

Enhancement
Description
Adds an input param to set the check name where the rubocop results will be reported.
Why should this be added
For my use, I want to name the linting job "Rubocop", but would like the check that gets created with the results to be called "Rubocop Results".
Checklist

[ ] My code follows the style guidelines of this project
[ ] Actions are passing

Ah, yeah I see your work in PR #75! If you're okay adding this change, I can modify this to use that new config file once that's done.

@fusion2004 I went ahead and added this for you in #75 :)


removing all references to the Turbolinks integration

What kind of changes does this PR include?

[ ] Minor content fixes (broken links, typos, etc.)
[x] New or updated content
[ ] Translated content
[ ] Changes to the docs site code
[ ] Something else!

Description
Removing all references to the @astrojs/turbolinks integration

LGTM @tony-sull !


losslesscut-bin: 3.58.0 -> 3.61.1

Description of changes
This PR closes #286569 #315306
Cc: @jyothisv @TanvirOnGH
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Works fine. Merge please.

@TanvirOnGH Thank you!

From https://github.com/NixOS/nixpkgs
 * [new branch]                master                -> refs/nixpkgs-review/0
 * [new ref]                   refs/pull/317795/head -> refs/nixpkgs-review/1
$ git worktree add /home/user/.cache/nixpkgs-review/pr-317795/nixpkgs f7207adcc68d9cafa29e3cd252a18743ae512c6a
Preparing worktree (detached HEAD f7207adcc68d)
Updating files: 100% (41566/41566), done.
HEAD is now at f7207adcc68d Merge pull request #318858 from r-ryantm/auto-update/seaweedfs
$ git merge --no-commit --no-ff 56e05f27a3a9da27f74a03e0c7a5907f53c14d14
Auto-merging pkgs/applications/video/losslesscut-bin/default.nix
Automatic merge went well; stopped before committing as requested
$ nix build --file /nix/store/89ax6r73alrwx78yhlbnff1sdmqq886r-nixpkgs-review-2.10.4/lib/python3.11/site-packages/nixpkgs_review/nix/review-shell.nix --nix-path nixpkgs=/home/user/.cache/nixpkgs-review/pr-317795/nixpkgs nixpkgs-overlays=/tmp/tmpzdfqytvm --extra-experimental-features nix-command no-url-literals --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed --argstr system x86_64-linux --argstr nixpkgs-path /home/user/.cache/nixpkgs-review/pr-317795/nixpkgs --argstr nixpkgs-config-path /tmp/tmpudhtoawo.nix --argstr attrs-path /home/user/.cache/nixpkgs-review/pr-317795/attrs.nix

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/317795

1 package built:
losslesscut-bin

$ /nix/store/fwrdsdlpqfhm6p4z9dk19vniw14mmq3s-nix-2.18.2/bin/nix-shell --argstr system x86_64-linux --argstr nixpkgs-path /home/user/.cache/nixpkgs-review/pr-317795/nixpkgs --argstr nixpkgs-config-path /tmp/tmpudhtoawo.nix --argstr attrs-path /home/user/.cache/nixpkgs-review/pr-317795/attrs.nix --nix-path nixpkgs=/home/user/.cache/nixpkgs-review/pr-317795/nixpkgs nixpkgs-overlays=/tmp/tmpzdfqytvm /nix/store/89ax6r73alrwx78yhlbnff1sdmqq886r-nixpkgs-review-2.10.4/lib/python3.11/site-packages/nixpkgs_review/nix/review-shell.nix

@TanvirOnGH Thank you very much for helping test it!

Works fine. Merge, please.

You could formally approve this PR through GitHub code review to help the committers notice it.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1756


how to use？

not doc found

see http://staruml.io/extensions for more details.
By the way, do not use latest version if you use starUml 2.x.

which version support starUml 2.x. ?


[Java]: Add magnitudes to property files

This should fix half of #331. Namely, it allows you to specify byte based sizes with suffixes of k, m, or g.
I'll put together a pr for the other half (time units) if or once you're happy with this. Any other tests or anything you reckon this needs?

Looks good on initial review. I'll review in more detail tomorrow. Thanks!

So maybe a more general explanation of why I did it this way is in order.
I wanted to try and make the time units version more or less the same, even if code isn't shared between them. Imo it's nicer if you can just play spot the difference between the two bits of code.
Since the time units will be something like ms, ns, and maybe even s, it'll be matching on strings (although we could do something a bit sketch and just match on the first character?). Actually that suggests how we could keep it to a switch on char in that case as well.

Thanks. I made a couple of commits to refactor the code to be more in keeping.


provide enable/disable option for toolbar

We want to only allow a user to draw a single box on a map, hence, it'd be nice to set the toolbar to disable the draw-rectangle button after certain events, and then re-enable if the user, say, deletes the rectangle.  The edit and delete buttons seem to already have a similar option.

+1 – I'm looking for that exakt option too.
I found a possible workaround on StackOverflow but it looks quite bloated. And I think the edit button disappears completely here, instead of simply fading a bit, which might be confusing for users.

https://github.com/Leaflet/Leaflet.draw/issues/265 goes into more detail on how to modify the toolbar. I expect this to be easier in 0.4.0 release as I refactor how toolbars are created.

Possible duplicate of https://github.com/Leaflet/Leaflet.draw/issues/401

I have the same need to disable (grey out ) a button after certain events. Since the DOM of the toolbar is accessible via the draw control object I just wrote some jQuery to toggle a custom CSS class which achieves the same effect. Here is an example:
function toggleDrawing(drawControl) {
        let button = $(drawControl
            ._toolbars.draw
            ._actionButtons[0]
            .button
            .parentNode
            .parentNode
            .parentNode
            .childNodes[0]
            .childNodes[0]);
        if (button.hasClass('disabled-draw-control')) {
            button.removeClass('b-disabled-draw-control');
        } else {
            button.addClass('disabled-draw-control');
        }
}

.disabled-draw-control {
    cursor: default;
    opacity: 0.5;
    pointer-events: none;
}

I found a solution that might not be the cleanest but seems to work (in leaflet 1.4.0 and leaflet-draw 1.0.4):
First I copied spritesheet.svg into my own app, edited it and replaced all #464646 (dark grey) with #C0C0C0 (light grey). This will be the greyed-out spritesheet for when the buttons are disabled.
You can then disable the toolbar buttons with:
document.querySelectorAll(".leaflet-draw-toolbar a").forEach(function(elem) {
  elem.style.backgroundImage = "linear-gradient(transparent,transparent),url('/path/to/greyed-out/spritesheet.svg')"
  elem.style.pointerEvents = "none";
})

And re-enable them with:
document.querySelectorAll(".leaflet-draw-toolbar a").forEach(function(elem) {
  elem.style.backgroundImage = "linear-gradient(transparent,transparent),url('/leaflet-draw/stylesheets/images/spritesheet.svg')"
  elem.style.pointerEvents = "";
})


Add support for prometheus-operator

Is your feature request related to a problem? Please describe.
Prometheus-operator is now a very viable way to monitor an aks cluster. It works with CRDs and is necesary to add some custom jobs to scrape the metrics from annotations. Maybe good feature if the chart support the creation of the servicemonitor/podmonitor to scrape the metrics directly with prometheus-operator
Describe the solution you'd like
To add support in the chart to deploy the needed servicemonitor/podmonitor if the user specify it in helm values

If this feature is useful, I can make a PR with the needed changes

@JorTurFer I was just getting up to speed with prometheus-operator. Setting up prometheus, grafana and alert manager automatically will be a really nice addition to AGIC's observability.
We definitely want to add more metrics to AGIC's prometheus metric store like currently configured ingresses, hostnames, errors along with metrics coming from Application Gateway through AzureMonitor plugin like backend health and response codes.
Please let me know how you feel about the above and feel free to contribute.

Hi @akshaysngupta ,
Honestly, my knowledge with Golang is very low (I "learned it" to for contribute in this amazing project).
I feel that I am able add the changes in helm to deploy ServiceMonitor and I think that I can create also a specific dashboard to deploy to prometheus-operator's grafana. In the other side, I feel me low in go to create more metrics for prometheus now.
What do you think about if I make a PR with the support for current metrics and a basic dashboard, and when more metrics are created we update the dashboard?

@JorTurFer that sounds good. We can start with a foundation and later on add more metrics.

Hi @akshaysngupta ,
I will start with this then :). This month is bad with the holidays but I hope make the PR soon.

Hi @akshaysngupta ,
I started with this and I have some doubts that I want to share.

I was watching the current metrics that agic exposes and I am not sure if a grafana dashboard is valuable before add more metrics.

I want to add some alerts, but I feel that the current metrics don't give a lot of information so i don't know if now an alert is useful

I think that would be a good idea if at first step we add now the podMonitor that brings support to prometheus-operator and after the creation of more metrics, reevaluate the alert and grafana ideas.
I don't have strong opinion about the alert topic, maybe an alert that monitor the arm deployment errors in the last hour would be enought

Hi @akshaysngupta ,
Do you have any opinion about my doubts? The PR that I made related with this (#969) adds support for prometheus-operator CRDs and works fine.
Maybe I should "end" the PR and remove  the WIP tag in order to merge?


The character 'Archive' in the upload dialog of blobs is not translated

Storage Explorer Version: 1.15.1
Build: 20200904.2
Branch: main
Platform/OS: Windows 10/ Linux Ubuntu 16.04/ macOS High Sierra
Architecture: ia32/x64
Language: All
Regression From: Not a regression
Steps to reproduce:

Launch Storage Explorer.
Open 'Settings' -> Application (Regional Settings) -> Select 'Deutsch' -> Restart Storage Explorer.
Expand one GPV2 storage account -> Blob Containers.
Open one blob container -> Click 'Upload' to open one upload dialog.
Check the characters in the dropdown list of the 'Target Access Tier' option.

Expect Experience:
All characters are translated.
Actual Experience:
The character 'Archive' is not translated.

More Info:
The screenshot in ENU.

Let's make sure this gets translated by time we ship 1.16.

Verified this issue on build 20200924.2. Reproduces on French.

"Archive" is also a valid word in French which has the same meaning as "archive" in English.

@JasonYeMSFT There are two translations for the 'Archive' in French 'Archiver' and 'Archive'.
Does it need to keep a consistent translation?


[HUDI-4942] Fix RowSource schema provider

Change Logs
Default value being provided by schema provider is being lost since RowSource sets a RowBasedSchemaProvider for the InputBatch. This PR fixes it by passing the user-specified schema provider.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level: none | low | medium | high
Choose one. If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@nsivabalan Can you please review this? I am yet to add a unit test but I have tested with my local confluent schema registry setup. The main issue is that if a schema provider is overridden then RowSource does not take it into consideration. It simply fetched the schema based on Row.

@codope : whats the status of this PR. do we need this anymore. if not, do we still need to rootcause the original issue then ?

Closing the PR. We need to root cause the issue. Something more is happening here.


Container Registry Config View

Feature Description
In the container registry, it has the Layers Info, but it would be nice to see the configuration options like how crane-operator does it so that the user doesn't have to read through the layer info to find the most relevant info.
Screenshots

How it currently looks in Gitea:

Maybe the Labels card could be expanded to include other config options?

How do you use the information? Does it add that much benefit?

The main part that I would like is the EXPOSED_PORTS and ENTRYPOINT.
We have containers where we specify port values, then we also have containers where we omit that and let Docker choose an available port. It would be nice to see it upfront.
Not necessary by any means as it's visible from the layers, but sometimes the Layers just has a ton of extra info.

I'm sorry but how do we view packages in the container registry ? I added a couple in gitea via podman push but I'm unable to view them now.

Just visit the packages page of the owner where you uploaded the packages to.

Just visit the packages page of the owner where you uploaded the packages to.

I'm running gitea 1.18
Additionally when I deleted the package from site administration/packages. It says  Package Management (Total: 0, Total Size: 443 MiB) .
Why is it still using storage space. It just removed the listing without actually clearing up storage. How do I permanently delete it.

You have to visit the owner profile not settings.

Additionally when I deleted the package from site administration/packages. It says Package Management (Total: 0, Total Size: 443 MiB) .
Why is it still using storage space. It just removed the listing without actually clearing up storage.


Add marian model type support for ORTOptimizer

Feature request
The recent Optimum library enable to export marian model type to ONNX format. However, the optimization via ORTOptimizer seems not to support this model type.
Please find below, the code used:
from optimum.onnxruntime import ORTModelForSeq2SeqLM, ORTOptimizer
from optimum.onnxruntime.configuration import OptimizationConfig

model_id="Helsinki-NLP/opus-mt-fr-en"

# load vanilla transformers and convert to onnx
model = ORTModelForSeq2SeqLM.from_pretrained(model_id, from_transformers=True)

# Create ORTOptimizer
optimizer = ORTOptimizer.from_pretrained(model)

# Define the optimization strategy by creating the appropriate configuration
optimization_config = OptimizationConfig(optimization_level=1,
                                        optimize_for_gpu=True,
                                        fp16=True
                                        )

# Optimize the model
optimizer.optimize(save_dir=onnx_path, optimization_config=optimization_config)

And the error code on feedback:
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-8-0c22ffd4b88a> in <module>
     12
     13 # Optimize the model
---> 14 optimizer.optimize(save_dir=onnx_path, optimization_config=optimization_config)

~/anaconda3/envs/sts-transformers-gpu-fresh/lib/python3.8/site-packages/optimum/onnxruntime/optimization.py in optimize(self, optimization_config, save_dir, file_suffix, use_external_data_format)
    113         save_dir.mkdir(parents=True, exist_ok=True)
    114         model_type = self.config.model_type
--> 115         ORTConfigManager.check_supported_model_or_raise(model_type)
    116
    117         # Save the model configuration

~/anaconda3/envs/sts-transformers-gpu-fresh/lib/python3.8/site-packages/optimum/onnxruntime/utils.py in check_supported_model_or_raise(cls, model_type)
    110     def check_supported_model_or_raise(cls, model_type: str) -> bool:
    111         if model_type not in cls._conf:
--> 112             raise KeyError(
    113                 f"{model_type} model type is not supported yet. Only {list(cls._conf.keys())} are supported. "
    114                 f"If you want to support {model_type} please propose a PR or open up an issue."

KeyError: "marian model type is not supported yet. Only ['bert', 'albert', 'big_bird', 'camembert', 'codegen', 'distilbert', 'deberta', 'deberta-v2', 'electra', 'roberta', 'bart', 'gpt2', 'gpt_neo', 'xlm-roberta'] are supported. If you want to support marian please propose a PR or open up an issue."

Motivation
It would be greatly beneficial to be able to optimize the onnx models regarding the low inference speed of this kind of model.
Your contribution
I could be a test user if the library is updated with this new feature.

Hi @Matthieu-Tinycoaching,
Once the ONNX config has been implemented in transformers, adding the support of a new model in Optimum is very simple. There are two steps to follow:

Register the model in ORTConfigManager.
Also add it to our test to confirm that it works.

Check more detail in the very good first issue here #351.
I just opened a PR to add the support for Marian, feel free to test it and think of joining us as contributor the next time 😉 .

Hi @JingyaHuang,
Thanks for your contribution! I've just joined the OWG for next time :)
I saw on your PR the two steps you've modified, however I didn't see where you implemented the ONNX config in transformers?

Hi @Matthieu-Tinycoaching,
Being able to export a model to ONNX format means that it already has its ONNX Config implemented. As you can see here the ONNX config for Marian.
If it is not the case, you can open a pull request in Transformers to add it on(basically you need to precise the inputs, outputs, the opset and create a method to generate dummy inputs). You can find more details here, and more discussion here.

Hi @JingyaHuang,
Thanks for the detailed explanation!
Could I test directly the merge you made before optimum new release?

Sure, you can build optimum from source with the following:
pip install git+https://github.com/huggingface/optimum.git


Add primary shard balancing documentation

Fixes #2663
Checklist

[ ] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89  Could you review this PR for technical accuracy please?


Keep player's seek bar visible when paused (as implemented in YouTube)

This would improve user experience a little bit.

Hey, any comments on this?

Thanks! This sounds like a reasonable feature, I will have to look a bit more in depth later this weekend.

@mderrick This would be cool.
P.S. Sorry for my alternating personalities, LOL. Forgot to switch from my corporate account to a personal one.

Hi @jumasheff I've had more of a thought on this and I'm not sure I want to introduce this behaviour by default. One reason being that the overlay itself contains a big play button in order for users to click and when they do, the controls appear on hover.
However, there is a much simpler way of achieving this effect and that would be to do this in your own CSS:
.video--paused .video__controls {
    opacity: 1;
}

I'd recommend this is done on a per user basis as not everybody will want this behaviour by default.
Let me know what you think.

:+1:


Free pre-allocated value pointer in OTHERNAME before overwritting.

CLA: trivial.
Do the same as https://github.com/openssl/openssl/blob/270a4bba49849de7f928f4fab186205abd132411/crypto/x509v3/v3_alt.c#L552 does to fix memory leak from the overwritten pointer in function GENERAL_NAME_set0_othername.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Will update the comment style for CI issue.


[BUG]

Describe the bug
VERBOSE-2:ui_dart_state.cc(186)] Unhandled Exception: type 'double' is not a subtype of type 'int?' in type cast
#0      _HtmlEditorWidgetMobileState.build.
package:html_editor_enhanced/…/widgets/html_editor_widget_mobile.dart:294

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Device:
Add device details here.
Additional context
Add any other context about the problem here.

Fixed via cd823453d020a97ee9a401e1e67f28d596693035, thanks for reporting!


Hierarchies and Levels now have full_name and Query now supports union function.

I'm really curious how you've been able to get by creating queries with mondrian-olap that select data across two levels within the same hierarchy.  All examples I see create a basic cross-product of the levels to each other using a sub nesting of cross joins and unions.  For example in Foodmart selecting Promotion Sales by Country and City and Product Family:
SELECT
NON EMPTY Hierarchize(Union(CrossJoin([Customers].[Country].Members, [Product].[Product Family].Members), CrossJoin([Customers].[City].Members, [Product].[Product Family].Members))) ON COLUMNS,
NON EMPTY {Hierarchize({[Measures].[Promotion Sales]})} ON ROWS
FROM [Sales]

I think
Hierarchize(Union(CrossJoin([Customers].[Country].Members, [Product].[Product Family].Members), CrossJoin([Customers].[City].Members, [Product].[Product Family].Members)))

is equivalent to
CrossJoin(Hierarchize({[Customers].[Country].Members, [Customers].[City].Members}), [Product].[Product Family].Members)

or using mondrian-olap query builder
columns('[Customers].[Country].Members', '[Customers].[City].Members').hierarchize.
crossjoin('[Product].[Product Family].Members')

But anyway I will add union method as well as sometimes it might be useful when making union of sets with duplicate members (union will remove duplicates but {...} will not remove duplicates).


Compile error in release builds

It seems Swift 4.2 is failing to build xcodeproj in release mode for some reason.
This can be seen by running:
swift build -c release

The following error occurs
PHI node operands are not the same type as the result!
  %159 = phi %Ts23_ContiguousArrayStorageCySSG* [ %336, %328 ], [ %143, %481 ], [ %143, %470 ], [ %143, %454 ], [ %143, %438 ], [ %143, %423 ], [ %143, %146 ]
<unknown>:0: error: fatal error encountered during compilation; please file a bug report with your project and the crash log
<unknown>:0: note: Broken function found, compilation aborted!
0  swift                    0x000000010e76664a PrintStackTraceSignalHandler(void*) + 42
1  swift                    0x000000010e765dfe SignalHandler(int) + 302
2  libsystem_platform.dylib 0x00007fff7908df5a _sigtramp + 26
3  libsystem_platform.dylib 0x000000011b583600 _sigtramp +<PHONE_NUMBER>
4  libsystem_c.dylib        0x00007fff78e2b1ae abort + 127
5  swift                    0x000000010a9edaf7 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*)::$_1::__invoke(void*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool) + 519
6  swift                    0x000000010e71a278 llvm::report_fatal_error(llvm::Twine const&, bool) + 280
7  swift                    0x000000010e71a15b llvm::report_fatal_error(char const*, bool) + 43
8  swift                    0x000000010e6e17e6 (anonymous namespace)::VerifierLegacyPass::runOnFunction(llvm::Function&) + 54
9  swift                    0x000000010e68804e llvm::FPPassManager::runOnFunction(llvm::Function&) + 446
10 swift                    0x000000010e690363 llvm::legacy::FunctionPassManagerImpl::run(llvm::Function&) + 115
11 swift                    0x000000010e690258 llvm::legacy::FunctionPassManager::run(llvm::Function&) + 392
12 swift                    0x000000010abb4228 swift::performLLVM(swift::IRGenOptions&, swift::DiagnosticEngine*, llvm::sys::SmartMutex<false>*, llvm::GlobalVariable*, llvm::Module*, llvm::TargetMachine*, swift::version::Version const&, llvm::StringRef, swift::UnifiedStatsReporter*) + 4504
13 swift                    0x000000010abb8e0e ThreadEntryPoint(swift::irgen::IRGenerator*, llvm::sys::SmartMutex<false>*, int) + 206
14 swift                    0x000000010abb8e6f void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(swift::irgen::IRGenerator*, llvm::sys::SmartMutex<false>*, int), swift::irgen::IRGenerator*, llvm::sys::SmartMutex<false>*, int> >(void*) + 47
15 libsystem_pthread.dylib  0x00007fff79097661 _pthread_body + 340
16 libsystem_pthread.dylib  0x00007fff7909750d _pthread_body + 0
17 libsystem_pthread.dylib  0x00007fff79096bf9 thread_start + 13
Stack dump:
0.	Running pass 'Module Verifier' on function '@"$S9xcodeproj12PBXBuildFileC16plistKeyAndValue4proj9referenceAA15CommentedStringV3key_AA05PlistG0O5valuetAA7PBXProjC_SStKFTf4dxn_n"'
<unknown>:0: error: unable to execute command: Abort trap: 6
<unknown>:0: error: compile command failed due to signal 6 (use -v to see invocation)

This is a blocker for XcodeGen and there is an open issue here https://github.com/yonaskolb/XcodeGen/issues/391

Thank for opening it. I realised it the other day doing some tests with Xcode 10 but I haven't been able to work on it yet. I'll prioritize this :)

Thanks for reporting it. Do you have the link to the radar @fxcoudert?

@pepibumur radars don't have public links, do they?

🤔 I thought they had. Is there any way to see if they respond to the radar?

https://bugs.swift.org would probably be a better place to open a bug. I don't have time to file one right now if someone else could

Here is the bug. I tried several things but none of them worked :/

This trick seems to work with the version 6.0.0 https://github.com/tuist/xcodeproj/commit/386575111ee5d4cae7877b651b695e0e1c4e2740. However, I tried to do the same in 4.3.0 to release a hot fix release, but it doesn't work :/

Submitted a workaround as well https://github.com/tuist/xcodeproj/pull/307

I'll prepare a PR for the necessary 4.3.0 change

Is there going to be a 6.0.1 release as well?

Can I ask if this fix will be published to Cocoapods? It's still showing as 4.3.0 for me there.

Hey @KaneCheshire
I'll publish the 4.3.1 hot fix to CocoaPods but keep in mind that we dropped the CocoaPods support from the project.

@pepibumur good to know! I wasn’t aware of that. Appreciate you taking the time to make an exception in this case. I use the pod in PixelTest: https://github.com/KaneCheshire/PixelTest
Going forwards I guess I’ll need to try and find another way to have it as a pod.
Thanks!

No worries. We introduced the Swift Package Manager as a dependency from the version 5+, which doesn't support CocoaPods. I doubt we can tell Apple to support it :trollface:. What we could do though is providing an easy way to generate a dynamic framework with both, the x86 and the ARMv7, that you can integrate into your project using Carthage's approach. Would you mind opening an issue on this project where we can discuss this further?


feat: add README.md + Makefile + lint, test and generate coverage

Overview
Self-explanatory

Codecov Report

Merging #18 (cd2cb9e) into main (e40362f) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   65.63%   65.34%   -0.30%
==========================================
  Files          33       33
  Lines        2756     2756
==========================================
- Hits         1809     1801       -8
- Misses        792      798       +6
- Partials      155      157       +2

Impacted Files
Coverage Δ

p2p/helpers.go
78.26% <ø> (ø)

p2p/server.go
75.00% <ø> (-4.45%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add missing keywords for typescript mode

Nothing fancy, just a bunch of keywords that were missing: enum, module and namespace, the abstract modifier, the implements directive and the as operator.

So none of these (including the old TypeScript keywords) seem to be implemented in the parser. This will confuse the highlighting, since in many cases (local variables, template strings, regexps) that depends on the parser actually understanding the current context of the token.
Have you tried, instead of doing things like kw("implements"), which isn't something the parser is going to know what to do with, to actually use one of the existing syntactic roles (in this case C) that is close to how the keywords work?

Guess not. Merged as 026ad081b16c, followed up by 7cde7a70940e8

Hey sorry for the lack of an answer. I don't know much about CodeMirror's internals so I thought I'd take a look later and forgot. Thanks for taking care of it!


OSGI r6: Use of the @ObjectDefinitionClass configuration classes in the activate method

I found out that we have a lot of classes, which do have the @Designate(ocd=...)annotation but this class is not used in the activate method; instead the classic signatures are used (either ComponentContext or Map<String,Object>).
We should change this and use the class we configure for this class; I guess that the "old" signatures are still working correctly, but it makes sense to use the OCD class for it.
These 29 classes are affected by this:
HttpClientFactoryImpl.java
HttpCacheConfigImpl.java
ResourceTypeHttpCacheConfigExtension.java
HttpCacheEngineImpl.java
HttpCacheInvalidationJobConsumer.java
CaffeineStoreRegisterer.java
NamedImageTransformerImpl.java
NamedTransformImageServlet.java
JsonEventLogger.java
SyslogAppender.java
EnsureOakIndex.java
EnsureOakIndexManagerImpl.java
QuicklyEngineImpl.java
FlushRulesImpl.java
JcrPackageReplicationStatusEventHandler.java
ResourceResolverMapTransformerFactory.java
StaticReferenceRewriteTransformerFactory.java
TwitterAdapterFactoryRegisterer.java
EnsureGroup.java
EnsureServiceUser.java
DelegatingServletFactoryImpl.java
AemEnvironmentIndicatorFilter.java
AuthorUIHelperImpl.java
CQIncludePropertyNamespaceServlet.java
ComponentErrorHandlerImpl.java
FileImporter.java
PageRootProviderConfig.java
PagesReferenceProvider.java
SiteMapServlet.java
Update: If you want to contribute here, please reference your PR here and list the cases you handle there.

Closing due to revert back to SCR: https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1741


Update terragrunt.hcl

Ran Plan for dir: . workspace: default
Show Output
Initializing the backend...

Initializing provider plugins...
- Finding hashicorp/null versions matching "~> 3.0"...
- Installing hashicorp/null v3.2.3...
- Installed hashicorp/null v3.2.3 (signed by HashiCorp)

Terraform has created a lock file .terraform.lock.hcl to record the provider
selections it made above. Include this file in your version control repository
so that Terraform can guarantee to make the same selections by default when
you run "terraform init" in the future.

Terraform has been successfully initialized!

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # null_resource.example will be created
  + resource "null_resource" "example" {
      + id = (known after apply)
    }

  # null_resource.path will be created
  + resource "null_resource" "path" {
      + id = (known after apply)
    }

Plan: 2 to add, 0 to change, 0 to destroy.

:arrow_forward: To apply this plan, comment:atlantis apply -d .

:put_litter_in_its_place: To delete this plan and lock, click here
:repeat: To plan this project again, comment:atlantis plan -d .

Plan: 2 to add, 0 to change, 0 to destroy.

:fast_forward: To apply all unapplied plans from this Pull Request, comment:atlantis apply

:put_litter_in_its_place: To delete all plans and locks from this Pull Request, comment:atlantis unlock

atlantis apply

Ran Apply for 0 projects:

atlantis apply -d .

Ran Apply for dir: . workspace: default
Apply Error
Show Output
running "terragrunt apply --terragrunt-working-dir=. --auto-approve -no-color planfile.tfplan" in "/atlantis-data/repos/italorafaeltavares/Atlantis/43/default": exit status 1: running "terragrunt apply --terragrunt-working-dir=. --auto-approve -no-color planfile.tfplan" in "/atlantis-data/repos/italorafaeltavares/Atlantis/43/default":
null_resource.example: Creating...
null_resource.path: Creating...
null_resource.example: Provisioning with 'local-exec'...
null_resource.example (local-exec): Executing: ["/bin/sh" "-c" "echo 'Hello, I'm using Terragurna with Atlantis!'"]
null_resource.example (local-exec): /bin/sh: syntax error: unterminated quoted string
null_resource.path: Provisioning with 'local-exec'...
null_resource.path (local-exec): Executing: ["/bin/sh" "-c" "cd /tmp && pwd"]
null_resource.path (local-exec): /tmp
null_resource.path: Creation complete after 0s [id=2395599816818867306]

Error: local-exec provisioner error

  with null_resource.example,
  on null_resource.tf line 2, in resource "null_resource" "example":
   2:   provisioner "local-exec" {

Error running command 'echo 'Hello, I'm using Terragurna with Atlantis!'':
exit status 2. Output: /bin/sh: syntax error: unterminated quoted string

time=2024-10-26T10:54:59Z level=error msg=Terraform invocation failed in /atlantis-data/repos/italorafaeltavares/Atlantis/43/default/.terragrunt-cache/cfDMtfwp6v_wq2SwVzNgqbKr0nM/1xU125NCArm1swwRlXjDhW49dQI/module/null_resource prefix=[.]
time=2024-10-26T10:54:59Z level=error msg=1 error occurred:
	* [/atlantis-data/repos/italorafaeltavares/Atlantis/43/default/.terragrunt-cache/cfDMtfwp6v_wq2SwVzNgqbKr0nM/1xU125NCArm1swwRlXjDhW49dQI/module/null_resource] exit status 1

Ran Plan for dir: . workspace: default
Show Output
Initializing the backend...

Initializing provider plugins...
- Finding hashicorp/null versions matching "~> 3.0"...
- Installing hashicorp/null v3.2.3...
- Installed hashicorp/null v3.2.3 (signed by HashiCorp)

Terraform has created a lock file .terraform.lock.hcl to record the provider
selections it made above. Include this file in your version control repository
so that Terraform can guarantee to make the same selections by default when
you run "terraform init" in the future.

Terraform has been successfully initialized!

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # null_resource.example will be created
  + resource "null_resource" "example" {
      + id = (known after apply)
    }

  # null_resource.path will be created
  + resource "null_resource" "path" {
      + id = (known after apply)
    }

Plan: 2 to add, 0 to change, 0 to destroy.

:arrow_forward: To apply this plan, comment:atlantis apply -d .

:put_litter_in_its_place: To delete this plan and lock, click here
:repeat: To plan this project again, comment:atlantis plan -d .

Plan: 2 to add, 0 to change, 0 to destroy.

:fast_forward: To apply all unapplied plans from this Pull Request, comment:atlantis apply

:put_litter_in_its_place: To delete all plans and locks from this Pull Request, comment:atlantis unlock

atlantis apply -d .

Ran Apply for dir: . workspace: default
null_resource.path: Creating...
null_resource.example: Creating...
null_resource.path: Provisioning with 'local-exec'...
null_resource.example: Provisioning with 'local-exec'...
null_resource.path (local-exec): Executing: ["/bin/sh" "-c" "cd /tmp && pwd"]
null_resource.example (local-exec): Executing: ["/bin/sh" "-c" "echo 'Hello, Im using Terragurna with Atlantis'"]
null_resource.path (local-exec): /tmp
null_resource.path: Creation complete after 0s [id=5569507141976935090]
null_resource.example (local-exec): Hello, Im using Terragurna with Atlantis
null_resource.example: Creation complete after 0s [id=3933758687269700177]

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

Locks and plans deleted for the projects and workspaces modified in this pull request:

dir: . workspace: default


updating readme on example

updates
I updated readme file . Please review and and accept

I might think about it


Add Apache License 2.0

This package is imported by gocb.v1 but has no license information.
Closes #1

@brett19 can you please review this PR?


fix condition in register

The condition of registering is not correct.
That will be executed even if only one of cytoscape, jQuery and oCanvas is defined and cause undefined error.

@kimxogus I have merged your PR. Thanks for your help.


tooltip on test items provided by test extension

I'd like TestItem to have a tooltip property with MarkdownString so I can show info like-
CI status
Fixtures/mixins used in the definition of the test
Coverage
etc..

We should be showing the TestItem.description on hover.


Set Terraform Plugins Directory Cache

https://github.com/SPHTech-Platform/terraform-dns/pull/2
Got it working in that giant mono-repo for 409 workspaces. Initial runs ran out of space.


Application crashes after turn off permission from settings

Hi, I have an issue with the navigation component.
My application has 4 states and for each state I have navigation graph when user launch application my starter activity launching one of the navigation graphs depending on the app state.
Bug causing scenario
When the application starts with the "graph_A" and the user hides the application and goes to the application settings section on the phone and disables the camera permission, and then reopen the app and when  starter  activity of app tries to start the navigation graph, for example, "graph_B", the application crashes with this exception
java.lang.IllegalStateException: unknown destination during restore: graph_a
Navigation library version  -  '2.1.0-alpha02'

Have u applied any solution for it? and in which project: NavigationAdvancedSample or NavigationBasicSample


clash-verge-rev: build from source

clash-verge-rev: 1.6.6 -> 1.7.2-unstable-2024-07-04
Not tested by me Yet
@Guanran928 for test.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

https://github.com/NixOS/nixpkgs/pull/318525

Complete in https://github.com/NixOS/nixpkgs/pull/335998


added base16 seti theme

Hi,
I added the seti theme from base16 beacuse I use it on my workstation.
please consider also checking the other base16 themes for missing/outdated ones.

thanks. please add another PR that updates the documentation. thanks.


Make stretchable width scaling configurable

For non- stretch elements, clipping may not be the preferred behavior. May want to automatically stretch behavior based on node type and/or allow for a configuration options to totally clobber.

Only stretches <img> tags with v0.2.0+