Duplicated records on Phones PopUp

It looks like the table is duplicating records here. I don't know why, it looks fine on the DB.

Please take a look this task is done

Done... works perfectly


Order subscriptions by when they were created

This is needed as we are adding when subscriptions have been created on
the subscription management page in email-alert-frontend and it makes
sense to order by this instead of the title.
This specific action seemes to be only used for the subscription
management flow, from a git search and a local grep.
Trello:
https://trello.com/c/FGYU4NlN/92-differentiate-between-your-get-ready-for-brexit-results-in-subscription-management

@kevindew good point and done, the api is now super flexible in how you can order things, maybe even too flexible! 👀
The periods are also now in the correct place.


Use a soft object reference for cartographic polygons

Use a soft object pointer to store references to cartographic polygons in other level instances (#1544 ).

Thanks for the PR @KieranCoppins! We'll review it as soon as we can.

Thanks @KieranCoppins!


[CS2103T-T11-4] PeopleSoft

PeopleSoft helps companies which offer contractor services to manage how much each contractor is paid. Given that contractors work on an ad-hoc basis, it is a pain to track and calculate fair renumeration for each employee. PeopleSoft solves this by offering:

employee management
job management
salary calculation

Manage your contractors at light speed with PeopleSoft ⚡

Codecov Report

Merging #56 (76991f9) into master (4f7660a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #56   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7660a...76991f9. Read the comment docs.


Fix apiclient logging

This updates the apiclient logging to use the formatted logging introduced with #160.
In addition this changes the logging so that we only get one message per
API request (either successful or unsucessful) and the elapsed time is
added to both.

:+1:


nogil wrongly warns about boundscheck(False)

Tested on Cython master 177dbe8 and also 0.27.3 (numpy 1.13.3). CPython 3.6 on Fedora 27.
Have this example.
import cython
import numpy
cimport numpy

def foo():
    cdef numpy.ndarray[numpy.int8_t, ndim=2] array = numpy.zeros((1, 1), dtype='int8')

    with cython.boundscheck(False):
        array[0, 0] = 1

Cython does not warn:
$ cython -3 pyxwarn.pyx

Now add nogil:
import cython
import numpy
cimport numpy

def foo():
    cdef numpy.ndarray[numpy.int8_t, ndim=2] array = numpy.zeros((1, 1), dtype='int8')

    with cython.nogil:
        with cython.boundscheck(False):
            array[0, 0] = 1

Now, a warning emerges:
$ cython -3 pyxwarn.pyx
warning: pyxwarn.pyx:11:17: Use boundscheck(False) for faster access

But I am using boundscheck(False) for faster access.
cc @encukou

Thanks. The check was wrong here. The generated code was correct and as expected.

Thank you for quick fix. (I knew the result was OK, juts forgot to mention it. Sorry about that.)


Fix functional tests now that suppliers can remove services

Suppliers removing their services has changed pretty substantially, both visually and functionally.  As a result, the functional tests need some updates to the content they're looking for and a few new tests.

Removed the tests about changing a service from 'Public' to 'Private'
Added a test for a supplier changing a service to 'Removed'
Relevant tests look for the removed service notification banners where they exist
Added a new tag to stop the supplier service edit tests from being run (not sure if Jenkins needs updating)
In our preview environment, suppliers can remove their services but not edit them

My supplier and admin journeys are working whether on my local environment or on preview.

:+1:


flow-typed install hangs

• Found 117 dependencies in package.json to install libdefs for. Searching...
• rebasing flow-typed cache...

It'd be useful to show progress with more verbosity so we could know where it is failing.

fwiw i notices a pretty huge improvement by running rm -rf ~/.flow-typed/

you can do
flow-typed install --verbose
Then it'll show exactly what dependencies where found. But it still hangs at rebasing flow-typed cache with no further information...
I cannot install flow types anymore because of this.

Hello,
You can check out this issue: #909
Looks like that this issue appears on specific node version.
In my case Node 8.4.0 fixes the problem.

Closing as per the comment above (also not an issue on latest/8.6.0).


Update <CldUploadButton> component

This PR updates the example for the <CldUploadButton> component. The changes are as follows

Updated Dependencies
Added appropriate header and footer
Customized the CldUploadButton, wrapped the demo in a card
Added App Router example
Removed unnecessary code
Added Tailwind CSS
Added toasts to show error and success messages
Use CldImage and CldVideoPlayer to display the uploaded media

i appreciate you adding Sonner, great library, but generally i want to keep the examples as MVP as possible, avoiding dependencies where we can, i think in this example we can maintain just updating the page with state to show the image/url
the rest looks good to me!

@colbyfayock I opened #160 with the changes now


Expand non-voting replicas architecture docs to explain how they work with each multi-region table locality

When reading the great non-voting replicas docs for 21.1, this statement provoked some questions for me:

In order to provide better support for multi-region clusters, (including the features that make fast multi-region reads possible), a new type of replica is introduced: the non-voting replica.

"fast multi-region reads" links to the GLOBAL table locality pattern, which make sense. From what's written here and in the non-blocking transactions docs, I understood the relation of non-voting replicas to GLOBAL. However, the language above is not exclusive to that pattern. That led me to wonder how non-voting replicas are used for the REGIONAL patterns.
I asked @ajstorm and he clarified that we create non-voting replicas for regional patters, in the non-primary regions, by default, too, as long as a region doesn't already have a voting replica, which, from what I understand, can be the impact of survivability goals (whoa!).
Although I understand and agree with the desire to keep our multi-region explanation and guidance simple and intuitive for the vast majority of users, I think we need to go further in explaining the mechanics in our architecture docs, for both internal and external power users who want/need to go there. I know this isn't a priority for 21.1 GA, but I'd like it to be considered for the future. It goes hand-in-hand with updating the way we describe and visualize our replication and transaction models in presentations (and maybe Cockroach U).
The only thought I have for the multi-region user guidance (as opposed to architecture reference) is whether we should somehow call out that the regional patterns also get you good reads from non-primary regions. Right now, that's not emphasized anywhere. Is there a way to do that without adding too much complexity?
cc @rmloveland, @awoods187, @ajstorm

We will definitely want to cover doing follower reads from other regions of partitioned data (the reason we added non-voting replicas) as an enhancement to the existing tutorials. I'm supportive of including more detail in the architecture docs but as you noted its a bit lower on the priority for the moment.


[dotnet ] fix dotnet v3, redux

Motivation
Follow-up from #2962 to fix tests for .NET 3.x release
Changes

revert some changes from #2962

re-enable DD_TRACE_ENABLED test
remove unnecessary reflection meant for Datadog.Trace.Manual.dll
leave reflection for GlobalSettings.DebugEnagled

use Release configuration in dotnet restore commands to avoid using the Datadog.Trace nuget package (this has been an issue for a few months, but was only recently discovered when we released tracer v3)

Workflow

⚠ Create your PR as draft ⚠
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist

[ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
[ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
[ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
[ ] A docker base image is modified?

[ ] the relevant build-XXX-image label is present

[ ] A scenario is added (or removed)?

[ ] Get a review from R&P team

#2981
#2978  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lucaspimentel and the rest of your teammates on  Graphite


create helloword in php

please ACC my PR with label. thank you

Sorry to inform but this repository has been excluded from hacktoberfest. So inorder to make your PR count towards hacktoberfest, request you to make your contribution in this repository -> https://github.com/SR-Sunny-Raj/Hacktoberfest2022-for-all

Sorry to inform but this repository has been excluded from hacktoberfest. So inorder to make your PR count towards hacktoberfest, request you to make your contribution in this repository -> https://github.com/SR-Sunny-Raj/Hacktoberfest2022-for-everyone


Add new checks for slapd

This adds some initial metrics for slapd that come from the monitor backend.  I still haven't quite got this working yet, since we need to have python-ldap installed so DataDog's python knows about it.  I've been testing by just symlinking the system version into the right place (since we already have it installed on the system for nsscache).

Okay, I just tested this on a QA machine, and it appears to be outputting metrics correctly.

r? @gphat

Very cool!
Can you also update the README.md with an explanation of this check and it's metrics? Trying to keep this friendly toward anyone who finds it and well documented!
Code looks great though, just holding off approval until the README is there.

Okay, added some documentation in the README!  Let me know if you need anything else :-)

👍


AWS error references deleted file

I got an AWS notification email today:

CLI routine 'vph5_to_vpts --modified-days-ago 2' failed raising error: '<class 'ValueError'>: File name uva/hdf5/dbl/2008/02/17/nldbl_vp_20080217t0000_nl50_v0-3-20.h5 is not a valid ODIM h5 file.'.

It now includes the name of the file 👍. The mentioned file is however no longer in the repository. It was deleted August 21 or 22 (2 or 1 days ago). I'll see tomorrow if the issue resolves itself, i.e. the inventory is updated and the file is no longer listed there and no notification is generated.
@stijnvanhoey @TheJenne18 can deleted files linger in the inventory? Should this resolve itself automatically? Not sure we considered this when designing the architecture.
Note this error did not stop the creation of the daily and monthly files 👍

Glad the logging adjustments are working.
Up to now I did not consider this scenario of files no longer existing in the S3 bucket. Not sure what the inventory is doing with removed files and if these willl be no longer enlisted in a next inventory. @TheJenne18 ?

The inventory system in Amazon S3 provides a snapshot of the objects within a bucket at a specific point in time. When a file is deleted, it will not appear in the inventories generated after the deletion.
However, if the file was deleted recently (in this case on August 21 or 22), and the inventory with the CLI routine 'vph5_to_vpts --modified-days-ago 2' was performed during that time frame, it might still include the now-deleted file.

Ok, mystery solved: those notifications were send from the UAT environment, where those files are not deleted.


The wiki and API docs don't always explain the purpose or range of values/arguments.

When describing different properties, values, arguments, etc, the wiki here on GitHub, and API docs website, usually tell you things like a variable's type, but does not always give you a range, or explain the purpose of these things.
I've noticed two examples so far, which have confused me when learning how Babylon works.
One is the BABYLON.Color3 class. Currently, the docs say that it accepts the arguments r, g, and b, for 'red', 'green', and 'blue' values, and it defines these values as numbers -- but it does not say that they should be floating-point numbers between 0 and 1. Is this a typical notation for colors in JavaScript? I'm still new to writing JS, so I was expecting numbers from 0 to 255, like in CSS. Even if floating points between 0 and 1 was the standard in JS, I think it would be helpful to include the normal range for any number values, for all the classes, in the documentation.
Another thing that confuses me is I notice a lot of the classes for creating cameras and meshes have a string name as the first argument. The tutorials usually use a string value that is the same or similar to the name of the variable containing the mesh or camera. I assume if you ever need to call or modify a camera or mesh, you'd be calling the variable name. So I can't figure out what purpose the name string argument serves.

For first point, You are right. Hopefully contributors will help completing the wiki
For second point, you can find meshes or cameras or lights by name when for instance you loaded your scene from a .babylon file

You mean, if I created a scene in a .babylon file, I wouldn't be able to reference a mesh by the variable name in the game scripts, but I could reference the mesh using it's name string value?

If you load your scene from the .babylon, you will receive a scene object. This object will have a .meshes array. If you want to reach a specific object, you have to differentiate it from others by using its name.

*if you want to reach a specific mesh

Perhaps this example could be clearer:
http://www.babylonjs-playground.com/?16
The newMeshes array could be browsed to find a specific mesh by name

Hmm. Alright, I guess that makes sense, then. Thanks.
After I've spent more time working with Babylon, I might be able to contribute to the wiki by making edits based on the things that confused me the first time around.

Excellent:)

...If I can figure out how to work with Babylon in the first place. I'm finding very little that explains input controls for gamepad, and less for keyboard and mouse.

Please use the forum for question, we have a great community
Regular keyboard/mouse camera (freeCamera):
http://www.babylonjs-playground.com/
For gamepad:
http://www.babylonjs-playground.com/#2AUKG
Pretty easy, correct? You just have to switch between cameras to change inputs

Sorry, I mean controlling a character on-screen. I'm trying to make a fairly simple third-person game where players on desktop and laptop computers can use a gamepad if they have one, and a keyboard and/or mouse if they don't.
Thank you for your patience.

I would have originally brought my questions to the forum instead, but for a few days now, it's saying that my forum account is waiting on admin approval, and I can't post anything.


Feature/asyncio

Hi
having an issue running this
opt/vedirect/examples$ python vedirect_mqtt.py
Traceback (most recent call last):
File "/opt/vedirect/examples/vedirect_mqtt.py", line 8, in
from vedirect import VEDirect
File "/home/pi/.local/lib/python3.9/site-packages/vedirect/init.py", line 2, in
from .vedirect_asyncio import VEDirectAsyncio
File "/home/pi/.local/lib/python3.9/site-packages/vedirect/vedirect_asyncio.py", line 5, in
raise NotImplementedError("This is only for Micropython")
NotImplementedError: This is only for Micropython


Added a comment

Hello,
This is not a comment (not an HTML one, but you put it in an HTML section...)
Can you explain me why you want to add this comment or what goal you are trying to achieve? :)

sorry,
I'm not recommending you to merge this commit. As you told, I made a
mistake on the syntax of html comment.
Actually I've done this for participating on #hacktoberfestchallenge :)
On Mon, 7 Oct 2019 at 00:11, Fabien LOISON<EMAIL_ADDRESS>wrote:

Hello,
This is not a comment (not an HTML one, but you put it in an HTML
section...)
Can you explain me why you want to add this comment or what goal you are
trying to achieve? :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flozz/p0wny-shell/pull/14?email_source=notifications&email_token=ANMYI2R45EYBYXSBGDD2VMLQNIWNZA5CNFSM4I52MUP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAOQ7AA#issuecomment-538775424,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANMYI2QXLZBFHXCXOAHOZ33QNIWNZANCNFSM4I52MUPQ
.

Ok, thank you for the answer :)


Add "Official Website" For Twitchy Desktop Lite

At some point when everything is stable and ready for a public release, we should think about creating a website or using your existing one for better search engine recognition and simplification of the whole downloading process. Github might look too complex and difficult to people outside of coding.

We can already have a hosted webpage thanks to github pages
https://pages.github.com/
If I remember well, it support only static websites (without servers, raw pages) and also support website generators such as Jekyll

Everything that looks better than the default readme is great. Will check this out when the time comes.


maven badge for readme (replace bintray?)

https://github.com/jirutka/maven-badges

https://github.com/etaty/rediscala/commit/9132facf658773df0c8becffe86ef2b450347fca


Update badge links and use SVG heroku badges

The badges should now be correctly linked with this repo.
But some challenges/questions are pending:

The coverage badge for the production branch is currently not available, maybe a setting in coveralls is missing?
Is the Errbit link up to date? Does someone has the login credentials and is it in use? And should we link it there?

Coverage remained the same at 100.0% when pulling 6d6ce6bfeeb7cb2fd31550356663703fa0bb1cfa on update_badges into d05e0de2ed2e90527cab1b9f219510555cb01c65 on dev.

We currently have no production branch anymore, our dev branch is the standard one and the one we deploy to heroku. Thus, the link cannot work at the moment.
I think Errbit will be a separate issue regarding the final deployment and monitoring solutions, but I'd look into this when we get the final deployment inside of HPI working.

Coverage remained the same at 100.0% when pulling ac9f386e311855b272ced69bdd7dcf4f75b9a860 on update_badges into d4c2033d0c767f27d1d73606141e18b3f6b77527 on dev.


Can primary path detection implicitly based on nSequence conflict with anti fee sniping using nSequence? #45

          Can this become an issue if we start doing anti fee sniping using nSequence? #45

Originally posted by @darosior in https://github.com/wizardsardine/liana/pull/1172#discussion_r1665581347

From an initial look, yes I think so if there's only a single input, unless perhaps if we only set values that don't correspond to the descriptor's timelocks. For multiple inputs, my understanding is we would only set nSequence for the first and so we could check that not all inputs have nSequence to distinguish from a recovery transaction.
The GUI may need to use one of the suggestions from https://github.com/wizardsardine/liana/pull/1150#discussion_r1658694811 if implicit detection is not possible.

In case it is possible to do implicitly, we should check if it's possible to move the logic to the LianaDescriptor::unsigned_tx_max_vbytes() method and remove the use_primary_path parameter.

Needs to be done together with #45


Add support for conversion of ros2 db3 bagfiles

Adds support to the mcap CLI tool for converting ros2 db3 files to mcap.
This should work without arguments on a system where AMENT_PREFIX_PATH
points to /opt/ros/, which seems to be the default ROS install.
Otherwise the equivalent search directories must be supplied via
parameter.

I don't think these tools should be in libmcap. Maybe a separate folder in the go folder for such conversion tools (similar to mcap folder for info, etc).

The thinking is that libmcap shouldn't have to depend on more and more things as we add encoding and schema formats.


Use errors.Cause() when looking at storage errors

The storage library uses github.com/pkg/errors to wrap errors that it returns from many of its functions, so when passing them to os.IsNotExist() or comparing them to specific errors defined in the storage library, unwrap them using errors.Cause().

LGTM

@mrunalp @runcom We probably want to get this in before we release.

LGTM if I don't fully like this pkg/errors stuff (wrapping errors to make it incompatible to Go itself)

:+1: Waiting for tests.


Quad Overdraw not working in D3D12

Description
I have a D3D12 application, and I can't get quad overdraw to work, both the pass and draw versions. I've used this in the past in D3D11 and it looks to still be working. Is it just a limitation in the current implementation?
Steps to reproduce

Load any D3D12 capture
Select a geometry action
Select quad overdraw from the dropdown

Environment

RenderDoc version: 1.15
Operating System: Windows 10
Graphics API: D3D12
GPU: RTX 2060 SUPER

The feature is supported on all APIs and works fine for me if I test it on MS's ModelViewer D3D12 demo. It's also tested in the automated nightly tests.
Please provide a specific reproducible test case such as a capture or your application, so I can investigate further.

This was an annoying and silly requirement from D3D12 where the pixel shader input signature needs to match the vertex shader signature, even if there is no interpolated data at all (the quad overdraw replaces the pixel shader with one which reads coverage and pixel co-ordinate). That commit will graft the vertex shader output signature onto the pixel shader.


Allow double-hop for PowerShell on target machines task

Required Information
Question, Bug, or Feature?
Type: Feature
Enter Task Name: PowerShell on target machines v3
Environment

Server - Azure Pipelines or TFS on-premises?

If using TFS on-premises, provide the version: Version Dev18.M170.6 (18.170.30525.1)

Agent - Hosted or Private:

Private agent:

OS : Windows 2016 Std - 10.0.14393 N/A Build 14393
Agent Version : 2.170.1

Issue Description

When using PowerShell on target machines v3, double hop is not possible as it uses Invoke-Command. Invoke-Command requires to pass credentials to allow double hop (https://docs.microsoft.com/en-us/powershell/scripting/learn/remoting/ps-remoting-second-hop?view=powershell-5.1#pass-credentials-inside-an-invoke-command-script-block)
Using PowerShell on target machines v2, double hop is possible as it uses a specific deployer

Sample script to reproduce
whoami

[System.Reflection.Assembly]::LoadFrom("System.DirectoryServices.AccountManagement.dll")
$current = [System.DirectoryServices.AccountManagement.UserPrincipal]::Current

if($null -eq $current) { # In V3 UserPrincipal is $null
    Write-Warning "UserPrincipal is null"
    throw "UserPrincipal is null"
}
else {
    Write-Verbose $current.SamAccountName -Verbose
}

Task logs
see attached log file : ReleaseLogs_5584.zip
Error logs

Issue still here.

bump, still needed

I'm also having this problem.

Bumpp

BumpBump :)

@Nico-1705 I'm betting 2025 for an answer.

This is working intermittently for us in some of our environments; in others, there have been no problems at all. We're probably going to downgrade our Powershell On Target Machines tasks to v2.* to be on the safe side, though.

Also encountering this; sounds more like a bug than an enhancement to me, since V2 does support it.


Rosella Installation dependent on Repository Cloning

We are currently using Rosella in our Snakemake workflow. However, we have tried to run Rosella with an installation via conda and ran into the reported “Flight Error” (#34 & #37). It only works when the entire Rosella repository is cloned into our workflow. This creates redundancy and makes providing the correct version to our workflow complicated. Additionally, we want to ensure proper credit without creating any misconceptions by cloning your work into our workflow.
It would be more convenient and efficient if Rosella could be installed without the need for cloning the entire repository. We kindly request you to have a look into this installation issue.
Feel free to reach out for more information.
Thank you for your time and help. We highly appreciate your work and hope to include Rosella into our workflow.
Best regards,
Katharina

Hi Katharina,
Thanks for reaching out. I'd love to get this fixed up, what would be the best solution for you? I've tried conda recipes in the past but the underlying python dependencies always seem to cause issues. Would a docker container be more suitable for your needs?
Cheers,
Rhys

Hi Rhys,
Thank you for your quick reply. A docker container would be great.
Many thanks in advance!
Best regards,
Katharina

Hi @ka-block , Sorry this took so long but rather than creating a dockerfile I've created a new release with a lot of changes v0.5.0
It's dependency versions are locked pretty tight, and conda installation works from my testing


CanPerformActionWithSender called twice

I am trying to see if I can implement the "Copy" functionality in UIWebView, so I modified your code to insert "Can performActionWithSender" code. However, I noticed that it is being called twice for every potential action (Cut,delete, etc.) Is this something that just happens with UIWebView?

I'll have to look into this a little more to be sure, but I think UIWebView already provides a default copy functionality in the webview that works systemwide...

The copy functionality works OK. My problem is that "CanPerformAction" is called twice (even though I don't have to do anything in the call). The code I inserted into your code to test this was:

(BOOL)canPerformAction:(SEL)action withSender:(id)sender {
NSLog(@"can PerformActionWithSender %@",NSStringFromSelector(action));
}

Also, "wsPasteboardChangedNotification" is called twice when a copy is selected from the webView when I insert code to trap the notification.
On 2011-11-22, at 3:56 PM, Jeff Geerling wrote:

I'll have to look into this a little more to be sure, but I think UIWebView already provides a default copy functionality in the webview that works systemwide...

Reply to this email directly or view it on GitHub:
https://github.com/geerlingguy/JJGWebView/issues/5#issuecomment-2842184


Allow Users to Login, Create, and Update their accounts with UI

Changes:
Index.html now shows elements to post an account to logged in users,
otherwise it'll only show a login or create account link.
SetUserInfo.html is newly created, it allows users to edit an existing account,
or lets new users create an account on the site.
Purpose:
In the future Comments will show who posted them, so this will let users
create accounts and log in to post comments.
Concerns:
People need to create an account on the setUserInfo page, logging in is insufficent.
Users who have never created an account but "login" will not be recgonized as logged in.

Thanks, let me know if there is anything else you need from me here.  I am not totally clear on if this "change requested" flag requires something from my side, or if you can handle it all on your end.


writer.add_run_metadata() failure due to update_fac being zero

Describe the bug
Running PPO2 with low n_env or low nminibatches causes failure in recurrent PPO2 policies due to writer.add_run_metadata()
Code example
To reproduce:
import gym

from stable_baselines.common.policies import MlpLstmPolicy
from stable_baselines.common.vec_env import DummyVecEnv
from stable_baselines import PPO2

# Create and wrap the environment
env = gym.make('CartPole-v0')
env = DummyVecEnv([lambda: env])

model = PPO2(MlpLstmPolicy, env,
             nminibatches = 1,
             verbose=1,
             tensorboard_log='/tmp/tensorboard/',
             )
# Train the agent
model.learn(total_timesteps=10000)

produces the error "ValueError: The provided tag was already used for this event type" from the add_run_metadata() call in ppo2.py (line 250).
Additional context
The problem seems to occur because the generated string for the metadata tag is 'step%d' in the line
writer.add_run_metadata(run_metadata, 'step%d' % (update * update_fac))
will always be zero if update_fac is zero.  Since update_fac is defined as
        if states is None:
            update_fac = self.n_batch // self.nminibatches // self.noptepochs
        else:
            update_fac = self.n_batch // self.nminibatches // self.noptepochs // self.n_steps

then if say self.noptepochs = 8, self.noptepochs = 1, and self.n_batch = 4, then update_fac will be zero, causing the writer to try to write the metadata entry as 'step0' repeatedly.
Solution
I'm entirely sure what update_fac is supposed to represent, but a simple fix is to add +1 to update_fac, preventing it from ever being zero

Hello @amccaugh,
Thank you for reporting the issue, I'll look into that. From what I remember, update_fac (update factor) is only used for logging, in order to compute n_steps. I am also suspecting this variable to be responsible for weird graph in tensorboard...
Any thought on that @hill-a ?

@araffin
Hi,
I am receiving following errors, while trying to run PPO2 for a custom environment. Can you pls guide me how to fix this ?
File "train_agent_2.py", line 271, in
model.learn(total_timesteps=args.num_steps)# callback=callback)
File "/home/iiitd/.local/lib/python3.6/site-packages/stable_baselines/ppo2/ppo2.py", line 355, in learn
update=timestep, cliprange_vf=cliprange_vf_now))
File "/home/iiitd/.local/lib/python3.6/site-packages/stable_baselines/ppo2/ppo2.py", line 294, in _train_step
writer.add_run_metadata(run_metadata, 'step%d' % (update * update_fac))
File "/home/iiitd/.local/lib/python3.6/site-packages/tensorflow/python/summary/writer/writer.py", line 262, in add_run_metadata
raise ValueError("The provided tag was already used for this event type")
ValueError: The provided tag was already used for this event type"

@riz0410 This seems unrelated to this issue. Please create a new issue and follow the issue template (share the full code to replicate the issue and library versions you are using).


cli: reindex function addition

Signed-off-by: Leonardo Rossi<EMAIL_ADDRESS>Co-authored-by: Lars Holm Nielsen<EMAIL_ADDRESS>

+1

Please add tests. Also I'm not unsure about naming and the fact that we adding a dependency on PIDStore.
P.S. Please add Co-authored-by as the code was taken from Zenodo ;-)

I'm writing the tests.
for the Co-authored-by, of course! Sorry, I forgot.. :)
I'll add now.

ping @jirikuncar @lnielsen do you have time to review the PR? :)

Superseded by #10.


Improve condensed output for nested model objects

Codecov Report

Merging #386 (0e39fd0) into main (b697f81) will decrease coverage by 0.37%.
The diff coverage is 87.89%.

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
- Coverage   94.54%   94.16%   -0.38%
==========================================
  Files          56       56
  Lines        2751     2813      +62
  Branches      347      357      +10
==========================================
+ Hits         2601     2649      +48
- Misses        114      128      +14
  Partials       36       36

Impacted Files
Coverage Δ

pyinaturalist/models/message.py
83.33% <50.00%> (-16.67%)
:arrow_down:

pyinaturalist/models/project.py
94.04% <69.23%> (-4.61%)
:arrow_down:

pyinaturalist/models/life_list.py
68.08% <75.00%> (+2.12%)
:arrow_up:

pyinaturalist/models/observation.py
92.24% <75.00%> (-0.81%)
:arrow_down:

pyinaturalist/models/search.py
96.15% <75.00%> (-3.85%)
:arrow_down:

pyinaturalist/models/controlled_term.py
91.46% <85.71%> (-1.60%)
:arrow_down:

pyinaturalist/models/taxon.py
90.57% <87.50%> (-0.60%)
:arrow_down:

pyinaturalist/models/photo.py
92.22% <88.88%> (+0.26%)
:arrow_up:

pyinaturalist/models/taxon_meta.py
94.23% <92.30%> (+0.17%)
:arrow_up:

pyinaturalist/models/base.py
93.16% <96.29%> (+0.30%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b697f81...0e39fd0. Read the comment docs.


tokenizer option on text fastfield

allow to set tokenizer option on text fastfield (fixes #1901)
handle PreTokenized strings in fast field

Codecov Report

Merging #1945 (51fe21f) into main (9e2faec) will increase coverage by 94.49%.
The diff coverage is 91.62%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##           main    #1945       +/-   ##
=========================================
+ Coverage      0   94.49%   +94.49%
=========================================
  Files         0      313      +313
  Lines         0    57564    +57564
=========================================
+ Hits          0    54396    +54396
- Misses        0     3168     +3168

Impacted Files
Coverage Δ

src/fastfield/writer.rs
94.27% <73.33%> (ø)

src/schema/text_options.rs
96.90% <96.20%> (ø)

src/aggregation/mod.rs
93.73% <100.00%> (ø)

src/fastfield/mod.rs
100.00% <100.00%> (ø)

src/indexer/segment_writer.rs
97.66% <100.00%> (ø)

... and 308 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Customize Add Method dialog for interfaces

The Add method dialog for interfaces has some options and things non related to interfaces available which I think could be better for user guidance.:

Must call parent option should not be available

Also in the title is mentioned, by value, could be interface?

Could the add method somehow realize that an actor is inheriting from it and let's you create messages then?


Debt: Refactor deployments endpoint

Topic
Deployments endpoint needs to be updated. The deployment_dates key needs to contain an array, where each entry in the array is another array of length 2, containing data as follows: [unix datetime for that day, number of successful deployments for that day]. All days need to be included in this list, even if they have no deployments.
Service
Backend
Steps

[ ] Update endpoint with new data format

@willcbelcher add an example short array in the issue using code in the markdown... Like:
{
  [
    {
      "time":<PHONE_NUMBER>922,
      "val": 3
    }
  ]
}

That way they don't have to guess.

Example endpoint:
[   {     "project_name": "org",     "deployment_dates": [       [<PHONE_NUMBER>, 0],       [<PHONE_NUMBER>.0,, 1]     ],     "deployment_frequency": "Daily"   } ]

Typed the wrong issue number in another commit.

Added another task to this issue.

Added another task to this issue

closed and passing tests via d081eaa


Spend showing x1000 on y axis when not using denominators

When using the spend chart on the analyse page without denominators, the y-axis is showing a scale x1000 greater than it should.  For example this scale should read 0-2000, not 0-2m.

For the record this is the query in question

This issue now reported by a user
Also, if you zoom on the spending chart and then reset the zoom, the scale and the bars appear even more incorrect - here the bars appear the same size even though displaying different values on hover (link):

This is a bit similar to problems with chart encountered after playback of map (issue #681)
Show/hide outliers doesn't seem to have any effect.

This line in chart_utils.js seems to be the culprit, and removing it (on staging!) fixes the chart that @richiecroker reported.
However, it then seems to break other charts where the denominator is not "nothing", such as this one.
By analogy with the ratio_items calculation, I think we should only scale ratio_actual_cost by 1000 when the denominator is not "nothing", but I don't fully understand what's going on here, so would like @sebbacon's input.


User App notifications in notification bar  routing issue

When clicking ticket booking successful notification it's not routing to your reservations page simply opening the app from recent tabs

Hey, nice buddy considering my issues to improve the quality of the product.

Did you check Firebase Cloud Messaging is working fine? send the notifications to all users at a time
check in this link
https://console.firebase.google.com/u/0/project//notification

firebase notification is working a fine great job

nice to hear that


Symlink Icons are not shown after (un)compress

Problem
In the aftermath of #308 I stumbled about one detail we missed:
After (un)compress on a symbolic link the symlink icon is not shown anymore.
How to test
Download ln.exe from https://schinagl.priv.at/nt/ln/ln64.zip and place it in the same directory as the below .bat file.
Start TestCopyReparsePoint.bat  from an administrative command prompt in your e.g. temp directory.
It builds a structure like
├───1
└───sl
    ├───iLib
    │   ├───inc
    │   └───src
    ├───iLib_symlink
    │   ├───inc
    │   └───src
    └───zzz

Select sl/iLib_symlink and choose from the menu File/(Un)Compress. The symlink icon of sl/iLib_symlink is shown properly contrary to the original.
Comments on the code
There are two locations in the source where the attributes are fetched directly via GetFileAttributes() and thus bypass WFFind{First|Next} extended in #297

treectl.c/InsertDirectory()
wffile.c/RedrawAllTreeWindows()

The topic 1. was handled in #308 as a byproduct, but 2. is addressed in this PR.
Anyhow, the fix is simple and introduces a helper function SetNodeAttribs(), which is called from 1) and 2)

Glad you found this.  It is one of the perils of working on an old code base with some redundancy "built" in -- e.g. #define ATTR_DIR            FILE_ATTRIBUTE_DIRECTORY.


Add Travis CI

This adds the travis.yml file so we can get travis running on this repo.
However, I need to be made a full admin on the repo in order to get that setup.

travis-ci seems happy; will merge and test again

Nicely done--thanks, @dbouwman!


Removed unused libraries from ember example

If the example does not use ember-data or ember-ajax, it's good idea to
remove them. This  probably removes ~100k or so.

I signed it!

I signed it!

Thanks for the PR! I'm out on vacation atm, but wanted to acknowledge this, and say let you know I've not forgotten about it. I'll review it when I get back in January.
Thanks again!


Update tutorial-setup-lab-account.md

Fix typos.

@alexandair : Thanks for your contribution! The author, @spelluru, has been notified to review your proposed change.

@alexandair - Thank you for fixing the spelling errors. The step was added in a hurry in the morning. I appreciate your contribution.
#sign-off


Migrate using Oracle GoldenGate

https://cockroachlabs.atlassian.net/browse/DOC-8306

Thanks @cotedm ! Incorporated your review and some other improvements. Going to tag in Ryan as well.


fix duplicated usage in docs

this removes a copy/pasta whoopsie on my side, introduced in de64324109d2694b1525e62b5c0072267282a36c (https://github.com/docker/docker/pull/24705) :blush:

@thaJeztah annnhh :stuck_out_tongue_closed_eyes:
LGTM 👼

Noticed it after it was merged :smile:
Author LGTM


Increase horizontal padding in mobile search grid

Fixes

Fixes #2133 by @dhruvkb
Description

This PR increases the horizontal padding on the search grid on mobile to be px-6 instead of the previous px-4 for better alignment with the header.
Testing Instructions

Check out the PR and run the dev server.
Search for a term.
See that the header and search grid are aligned on both sides.
Turn on the new_header flag.
Search for a term.
See that the header and search grid are still aligned on both sides.

Checklist

[x] My pull request has a descriptive title (not a vague title like
Update index.md).
[x] My pull request targets the default branch of the repository (main) or
a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible
errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@panchovm could you confirm this is the correct approach to take? Alternatively, I could see us decreasing the space of the header to match the existing grid.

@zackkrida in the bug tracking sheet, @panchovm shared a screenshot with the text that the "purple lines should frame both sections", implying that the header is fine and the content should be narrower.

Coming here to confirm the request and congratule the improvement. It looks great ✨


ShopifyAPI::GiftCard balance and initial_value fail with a TypeError

ShopifyAPI::GiftCard balance and initial_value fail with a TypeError
After fetching a GiftCard through ShopifyAPI::GiftCard.find(id: id), I can see the balance and initial value are both strings
<ShopifyAPI::GiftCard:0x0000000114166b78 ... @balance="1.29" @initial_value="1.29">
Accessing those via gift_card.initial_value or gift_card.balance will cause an error. Sorbet (or whatever) expects them to be floats and raises
TypeError (Return value: Expected type T.nilable(Float), got type String with value "1.29")

shopify_api version: 12.3.0
Ruby version: 2.7.2
Operating system: MacOS

Expected behavior
I would expect to be able to access a gift card's balance or initial_value as either a string or float without an error
Actual behavior
Errors are raised
Steps to reproduce the problem

gift_card = ShopifyAPI::GiftCard.find(id: id)
gift_card.balance

The not-ideal workaround is converting to json and then parsing to get the values.

I can reproduce this issue in 12.4.0. The workaround (I used as_json) worked for me.

guh, this one was filed in May (!).
https://github.com/Shopify/shopify-api-ruby/issues/955
I wouldn't count on it getting fixed.

Fixed with https://github.com/Shopify/shopify-api-ruby/pull/1137


staging-next 2022-07-01

workflow docs: nixos.org/manual/nixpkgs/unstable/#submitting-changes-commit-policy
important job(s): hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
jobset: hydra.nixos.org/jobset/nixpkgs/staging-next
nix-review reports: https://malob.github.io/nix-review-tools-reports/
previous staging-next: https://github.com/NixOS/nixpkgs/pull/178690

[ ] tracker: perhaps one of its maintainers can look into one of its tests failing on *-linux? (I reproduced it locally, Hydra retried a few times, too)
@bobby285271 @hedning @jtojnar @dasj19
https://hydra.nixos.org/log/ydvy74551dsxb0gzg996r435g9jn7k0s-tracker-3.3.1.drv

Opened https://gitlab.gnome.org/GNOME/tracker/-/issues/370, will continue looking into it.

tracker: perhaps one of its maintainers can look into one of its tests failing on *-linux?

Can the sqlite bump (#179101) be one of the possible reasons? (Still looking into it)

Good spot, downgrading sqlite indeed fixes it:

Details
--- a/pkgs/development/libraries/tracker/default.nix
+++ b/pkgs/development/libraries/tracker/default.nix
@@ -59,7 +59,14 @@ stdenv.mkDerivation rec {
   buildInputs = [
     glib
     libxml2
-    sqlite
+    (sqlite.overrideAttrs (attrs: {
+      version = "3.39.0";
+
+      src = fetchurl {
+        url = "https://sqlite.org/2022/sqlite-autoconf-3380500.tar.gz";
+        sha256 = "sha256-WvB96YK6ZY/ZGgMXDJRfmclx9pVbx53zJmVENz45hpw=";
+      };
+    }))
     icu
     libsoup
     libsoup_3

So I skipped the tracker tests in f31f162.

[ ] google-auth python packages regressed: https://hydra.nixos.org/eval/1770126?filter=google-auth  Maintainer: @SuperSandro2000.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/how-to-know-which-package-in-my-hm-config-depends-on-another/20163/9

[ ] python3Packages.selenium regressed, maintainer: @jraygauthier.

#180518

proj_7: I propose simply disabling these tests: https://github.com/NixOS/nixpkgs/pull/180578

@SuperSandro2000 : #180518 looks fine to me for merge.


remote cache: improve http error checking

Assume success on HTTP 2xx (some blob providers will return 201 rather than 200)
Dump HTTP error body on failure, stripping away any URL path to avoid leaking pre-signed URLs

Just echoing a discord comment, we definitely want a change like this for debuggability, but I previously backed out of a similar change in the past when I realized it ended up sometimes printing parts of the pre-signed URL to engine logs. We can obviously find a way to deal with that, just something important to keep in mind before merging.

@sipsma Addressed pre-signed URL leakage, PTAL

@aluzzardi @sipsma Should we merge this PR now? It's been 2 weeks since it has been approved


Documentation update for sap-converged-cloud

Description
Changes proposed in this pull request:

Updates about new plan name replacing openstack

Related issue(s)

/test pre-kyma-environment-broker

/test pre-kyma-environment-broker

/test pre-kyma-environment-broker

/test pre-kyma-environment-broker


fix: instagramRipper, replaced Nashorn with GraalVM.js

Category
This change is exactly one of the following (please change [ ] to [x]) to indicate which:

[x] a bug fix (Fix #...)
[ ] a new Ripper
[ ] a refactoring
[ ] a style change/fix
[ ] a new feature

Description
This PR attempts to fix the instagramRipper, #1598 #1699 #1715 #1719 . I've replaced nashorn with GraalVM.js, which makes the binary a lot bigger. So I'm not sure how I feel about that.
Would appreciate your thoughts on this, perhaps a different way to reliably extract the qHash.
Testing
Required verification:

[x] I've verified that there are no regressions in mvn test (there are no new failures or errors).
[x] I've verified that this change works as intended.

[x] Downloads all relevant content.
[x] Downloads content from multiple pages (as necessary or appropriate).
[x] Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.

[ ] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

[ ] I've added a unit test to cover my change.

Actually getting some errors on the /tagged Rips now, going to need to fix that one later.

java15 removes nashorn anyway:
https://openjdk.java.net/jeps/372
i do not get errors for tagged, single download, album download. i did apply #1722 and the nashorn-graal switch from here.

Ah right, so I started testing a bit more and it seems to be a problem with authentication / private accounts.

Adding graaljs increases the size by 4x, but then again 15-20mb is not much.
I've tried a few different ways with nashorn, using babel polyfill, using IG's own Polyfill.js. Both did not work.
Using regex would be a dirty fix for now.
Graal seems like the right way to go about it, which should also help with other modern sites.
@cyian-1756 can his input on this.
I'll test this today/ tomorrow.

Thanks for this pull request.
I checked it out and created a build with Maven - everything working fine for me.

Thanks for this pull request.
I checked it out and created a build with Maven - everything working fine for me - both on Instagram & Reddit (haven't tested any other sites as for now, as I usually only use it for these 2.)

Oops... Noticed now that the config option "history.end_rip_after_already_seen" does not seem to properly work.
In the log it's clearly identifying files as already downloaded, but continues the rip of the URL long after the number defined in the config option has been passed. The reddit ripper still stops when it should.
The log is also looking different for Instagram compared to Reddit.
https://scontent-prg1-1.cdninstagram.com/v/t51.2885-15/e35/11378731_101577923523667_932705012_n.jpg?_nc_ht=scontent-prg1-1.cdninstagram.com&_nc_cat=107&_nc_ohc=ncyXRtvTUaUAX9y_cMB&oh=999ebcece3f0ad0dfba452022997a9f1&oe=5F5EB56D already saved as D:\RipMe\instagram_celinasmith\2015-07-08_21-13-07_448t4KyJLS_11378731_101577923523667_932705012_n.jpg
Compared to the message the reddit ripper gives:
Already downloaded https://i.redd.it/js9xcqr2zux01.jpg

@cyian-1756 I hope this can get pushed soon

@cyian-1756 what you think?

Looks good to me. I'll test it and merge it for 1.8.0

@cyian-1756 any update on when this well me merged?

@cariah The ripper seems to be returning null for the query hash

@cariah The ripper seems to be returning null for the query hash

currently it does not work at all, would it not be a better option to merge it and then fix bugs if somebody notices? i, for example, am not sure about the link you see this null?

@cyian-1756 ah, i understand, #1722 should fix this.

@cariah The ripper seems to be returning null for the query hash

Sorry for being a little inactive.
Instagram seems to use these query hashes to cache queries orsomething. Might be a better way to get rid of the JS parsing entirely and hardcode these query hashes and periodicly update them when/if they break (would also mean old instagram clients break). It also prevents people from getting random errors, because everyone is using the same hashes. Thoughts?

@cariah The ripper seems to be returning null for the query hash

Sorry for being a little inactive.
Instagram seems to use these query hashes to cache queries orsomething. Might be a better way to get rid of the JS parsing entirely and hardcode these query hashes and periodicly update them when/if they break (would also mean old instagram clients break). It also prevents people from getting random errors, because everyone is using the same hashes. Thoughts?

The current error after this merge is to do with the regex catching the wrong text as query hash.
I'll get the fix out in few days.
I don't think its possible to hardcode the query hashes. I think  they would be unique per request, profile or something.

@cariah @Tush-r @cyian-1756 you are saying despite merging  #1722 it fails? can you post a url where this is so?

@cariah @Tush-r @cyian-1756 cannot reproduce an error here. you are saying despite merging #1722 it fails for you? can you post a url where this is so?

Sorry. I previous reply mentions an error but there is an issue( and not error). The ripper now only rips the first page. This is due to the query hash regex catching the wrong text.
The issue is mentioned in latest replies for #1740
I do have a fix for it, just need to test it. I'll get it out latest by tomorrow.


Update brakeman version - maybe be more flexible?

The currently-specified version of brakeman is obsolete.
I think in this case, pronto would be better served by using ">=" instead of "~>" when specifying the version of Brakeman.  That'd be more flexible, and would avoid this problem in the future.
Thanks!

Done :smile:
https://github.com/mmozuras/pronto-brakeman/commit/0db7e4ee9aac2782a1abf969bb2b6e375364d4f1
Thanks :bow:


pact-broker needs to write logs to /tmp as AWS lambda doesnt have permissions to write anywhere else

fixed by https://github.com/pact-foundation/pact-broker-docker with new puma image


both cURL and the site are giving me a 500 Internal Server Error

I believe it's fairly self explanatory, however I tried to download the .vim file for my selected langs, and it gave me an internal server error. cURL'ing just filled a .vimrc file with the contents of the error, that being of an Internal Server Error.
-Stu

What languages you select?

JS, Ruby, Haskell, Elixir, Python, C, Lua, Ocaml, Go, Erlang, php, html
curl 'http://vim-bootstrap.com/generate.vim' --data 'langs=javascript&langs=ruby&langs=haskell&langs=elixir&langs=python&langs=c&langs=lua&langs=ocaml&langs=go&langs=erlang&langs=php&langs=html&editor=vim' > ~/.vimrc

Maybe a network restriction. I test here and I don't have any problems.


README has 404 reference

to https://github.com/poise/poise-service-monit in line 194

Yes, it hasn't been uploaded yet. This cookbook is unreleased for a reason.

alright, looking forward to put it in use.

An informational email will be going out to chef-dev later today.


About the chat template of llama3-instruct

Hi,
Thanks for releasing this interesting work! I want to ask for the llama3-instruct's chat template, why do you only use it in hh_rlhf dataset and and magpie dataset but not in all datasets? I suppose all fine-tuning datasets should follow the chat template by default. Thanks!

Hello, our forget datasets come from raw-text document datasets, e.g. the Pile. Since they aren't user-assistant conversation data, it wouldn't make sense to wrap the text chunks in a conversation template, as we don't have examples of model responses to those text chunks.
Generally instruction-tuned models can be still fine-tuned on raw-text to introduce new knowledge without affecting chat capabilities, but we found that including the magpie dataset as an additional retain set helped stabilize chat performance after TAR.


isJsx state should also consider the vue component with render method

the isJsx here should also consider the following scenario for making @babel/parser support jsx automatically, eg:
<script>
export default {
   render(h) {
      return h(tag, attribute, [
      <bTypography class="bButton-contents" variant={textVariant} component="span">
        {contents}
      </bTypography>,
    ])
   }
}
</script>

anyway, it is probably a edge case here that mixing usage of h and jsx syntax.

does it work if you make it <script lang="jsx"> ?

I don't want to parse everything as jsx all the time, because there's a typescript cast syntax that intersects with jsx, so I made it look for lang="jsx" or lang="tsx" in SFCs to support both cases

@UnrefinedBrain

does it work if you make it


Assertion failed: EventProvider.attachEvent: fnFunction must be a function

OpenUI5 version:
1.65.1
Browser/version (+device/version):
Chrome
Any other information? (attach screenshot if possible)
I just tried to switch my OpenUI5 library version. My old version was 1.63.1 an the new version I am currently trying is 1.65.1. With the new OpenUI5 version there seems to be already a bug in the app initialisation. During initialisation:
      sap.ui.getCore().attachInit(function() {
          // this is the relevant part of the single page app which loads the component
          app = new sap.ui.core.ComponentContainer({
            height: "100%"
          }).placeAt("content");

          var oComponent = sap.ui
            .component({
              name: "mnd",
              manifestFirst: true,
              async: true
            })
            .then(function(oComponent) {
              app.setComponent(oComponent);
            });
        });
      })
      // authentification failed
      .error(function() {
        alert("failed to initialize");
      });

I end up with the attached Assertion error. The user interface shows up, but the App does not react to events. There seems to be something wrong during Event System initalization. Unfortunately, I have no idea how I can further track this issue down.
Assertion failed: EventProvider.attachEvent: fnFunction must be a function
  | a | @ | sap-ui-core.js:187
-- | -- | -- | --
  | b.attachEvent | @ | sap-ui-core.js:319
  | (anonymous) | @ | sap-ui-core.js:473
  | k.applySettings | @ | sap-ui-core.js:342
  | (anonymous) | @ | sap-ui-core.js:335
  | constructor | @ | sap-ui-core.js:335
  | constructor | @ | sap-ui-core.js:951
  | constructor | @ | sap-ui-core.js:773
  | f | @ | sap-ui-core.js:555
  | p1 | @ | library-preload.js:832
  | (anonymous) | @ | library-preload.js:832
  | (anonymous) | @ | SyncPromise.js?eval:6
  | c | @ | SyncPromise.js?eval:6
  | S | @ | SyncPromise.js?eval:6
  | S.then | @ | SyncPromise.js?eval:6
  | K | @ | library-preload.js:832
  | J | @ | library-preload.js:832
  | I | @ | library-preload.js:832
  | l1 | @ | library-preload.js:832
  | s | @ | library-preload.js:823
  | l1 | @ | library-preload.js:832
  | s | @ | library-preload.js:823
  | K | @ | library-preload.js:832
  | J | @ | library-preload.js:832
  | (anonymous) | @ | library-preload.js:832
  | (anonymous) | @ | SyncPromise.js?eval:6
  | c | @ | SyncPromise.js?eval:6
  | S | @ | SyncPromise.js?eval:6
  | S.then | @ | SyncPromise.js?eval:6
  | F | @ | library-preload.js:832
  | G | @ | library-preload.js:832
  | h | @ | library-preload.js:832
  | X.parseTemplatePromise | @ | library-preload.js:831
  | X.parseTemplate | @ | library-preload.js:830
  | k.runWithPreprocessors | @ | sap-ui-core.js:341
  | i | @ | library-preload.js:1377
  | k.onControllerConnected | @ | library-preload.js:1377
  | F | @ | library-preload.js:1326
  | e._initCompositeSupport | @ | library-preload.js:1326
  | (anonymous) | @ | sap-ui-core.js:335
  | constructor | @ | sap-ui-core.js:335
  | constructor | @ | sap-ui-core.js:951
  | constructor | @ | sap-ui-core.js:773
  | f | @ | sap-ui-core.js:555
  | f | @ | sap-ui-core.js:555
  | u | @ | library-preload.js:1350
  | v | @ | library-preload.js:1348
  | c.createContent | @ | library-preload.js:751
  | (anonymous) | @ | library-preload.js:739
  | k.runWithPreprocessors | @ | sap-ui-core.js:341
  | (anonymous) | @ | library-preload.js:739
  | r | @ | sap-ui-core.js:590
  | o.runAsOwner | @ | sap-ui-core.js:604
  | c.init | @ | library-preload.js:739
  | init | @ | Component.js?eval:15
  | (anonymous) | @ | sap-ui-core.js:335
  | constructor | @ | sap-ui-core.js:335
  | constructor | @ | sap-ui-core.js:592
  | constructor | @ | library-preload.js:735
  | f | @ | sap-ui-core.js:555
  | e1 | @ | sap-ui-core.js:630
  | e | @ | sap-ui-core.js:626
  | (anonymous) | @ | sap-ui-core.js:626
  | r | @ | sap-ui-core.js:590
  | (anonymous) | @ | sap-ui-core.js:626
  | Promise.then (async) |   |
  | x | @ | sap-ui-core.js:626
  | sap.ui.component | @ | sap-ui-core.js:625
  | (anonymous) | @ | appLoaderBrowser.js:45
  | Core.attachInit | @ | sap-ui-core.js:841
  | (anonymous) | @ | sap-ui-core.js:331
  | (anonymous) | @ | appLoaderBrowser.js:38
  | setSuccess | @ | keycloak.js:1030
  | (anonymous) | @ | keycloak.js:133
  | setSuccess | @ | keycloak.js:1030
  | authSuccess | @ | keycloak.js:630
  | req.onreadystatechange | @ | keycloak.js:603
  | XMLHttpRequest.send (async) |   |
  | processCallback | @ | keycloak.js:612
  | (anonymous) | @ | keycloak.js:188
  | setSuccess | @ | keycloak.js:1030
  | iframe.onload | @ | keycloak.js:1087
  | load (async) |   |
  | setupCheckLoginIframe | @ | keycloak.js:1080
  | processInit | @ | keycloak.js:187
  | setSuccess | @ | keycloak.js:1030
  | req.onreadystatechange | @ | keycloak.js:721
  | XMLHttpRequest.send (async) |   |
  | loadConfig | @ | keycloak.js:728
  | Keycloak.kc.init | @ | keycloak.js:138
  | onDeviceReady | @ | appLoaderBrowser.js:11
  | initialize | @ | appLoaderBrowser.js:4
  | (anonymous) | @ | appLoaderBrowser.js:62

Hello @cjohn001 ,
Could you please provide an url to the application?
Regards, Diana

Hello Diana,
I am sorry, I do not have the app online yet.

(warning: this is just guess-work)
The stack trace suggests that

the core did initalize
it executed your sap.ui.component call
the component initializes by asynchronously creating its root view (presumably configured in your manifest)
within that view, a control is created which has an event handler defined in the XMLView
the control is at level 2 or 3 in the control hierarchy of the view
the event handler provided to the control (and derived from the XML) is not a function

From that, I would assume that one of the event handler attributes in a control is malformed and doesn't resolve to a function. In that case, you should also get a warning before the assert, something like
Event handler name 'some string' could not be resolved to an event handler function

If you don't get such a warning (or if it doesn't help to identify the root cause), could you paste the root view here or at least the event handler attributes from it?

Hello Frank,
I need to close the issue as I do not get the error anymore. I observed in the debug view that multiple component.js instances where loaded in the browser, not sure how this could happen. Since I restarted the browser, the issue does not appear anymore. Sorry for the inconvenience.
Best regards,
Christoph


Dataset inputs for measurements

The datasets currently do not have an input for; power minima, maxima or standard deviations, reference wind direction standard deviations, turbine availability count, and more than 2 shear measurements. It would be very useful, and would make analysis more accurate, if these could be added next to their current respective sections. Could they be made so that they could be added if necessary? For example, being able to add as many shear measurements as has been made could be done by being able to add in extra input boxes for the data gathered, instead of having a set amount.
There also currently isn't an option in the date formatting drop down menu for the format %d/%m/%y %H/%M/%S which some data is provided in. (However it can be added manually)

I have added the format to the drop down menu.
https://github.com/MVAppleby/PCWG/commit/0dcd2bcf0c126baac54e2a02db45b0994ec9ab8e#diff-a3803fe2234e186a0798f2820f406895L1394


Invalid optimization for out using BC

The "Pattern Based" optimization is potentially incorrect when the high byte is used for the out op.
Original Code
ld bc, 0x303b
out (c), a

MDL optimization
INFO: Pattern-based optimization in code.asm#1123: Replace ld bc,#303b with ld c,(#303b) & #00ff (1 bytes, 3 t-states saved)

Resulting code (B not loaded with 0x30)
ld c, 59
out (c), a

Thanks for reporting!
Quick question: did you try this on an MSX, Spectrum or Amstrad project?
This is an expected optimization in MSX, where the "in/out" addresses are 8bit (and just using C), but in Spectrum/Amstrad, "in/out" addresses are 16 bits (using BC). By default, MDL assumes you are using an MSX (sorry about that, haha), and hence it'll do this optimization. If you are targeting a Spectrum, use the "-cpu z80" flag, and if you are targeting an Amstrad, use the "-cpu z80cpc".
Let me know if that's the issue. Otherwise, I'll look to see where is the bug :)

You are welcome, and thanks for a very helpful tool.
I am targeting a ZX Spectrum, specifically the ZX Spectrum Next but for this I was not using any of the extended OP Codes so that should not have interfered.
I will test the -cpu Z80 flag this evening and let you know how that goes.

Cool!! Thanks!! I recently added ZX Nest support (with -cpu z80next), but I have only tested it with one project. So, I would not be surprised if I got something wrong in the extended op codes haha. If you encounter any issues, do let me know :)

Using the -cpu Z80 option cleared that right up. Thank you.

I did a quick test with -cpu z80next, the -so option sends the optimizer into an infinite loop, but I will work on a simple reproduction and get back to you.

Thanks!!! Any sample code that causes the issue is appreciated! :) (warning: the -so optimizer is quite slow, haha :) )


[hud] Display build time on dirty working trees

Due to popular request, here's a simple single commit to make debugging DXVK substantially easier based on what I'm currently doing in D8VK. If the working tree is dirty ('+' in the version on the HUD), the compile date and time of the current frontend are shown on the HUD. This helps us check if builds installed correctly and how long builds took, among other things.
Here is an example (looks similar for other APIs on DXVK 2.0):

This also allows changing the D3D9 API name if desired, which is useful for D3D8 and lower. It is included simply to avoid merge conflicts and because there are many use cases (9Ex vs. 9, DXVK Native, D3D8, etc.).

Exposing the API name thing is fine, but having date/time is bad because it breaks reproducible builds.

I recommend exposing the API name thing the same way we do for DX10.

Exposing the API name thing is fine, but having date/time is bad because it breaks reproducible builds.

I recommend exposing the API name thing the same way we do for DX10.

I have modified it so that the date and timestamp is only included if the working tree is dirty. I removed the SetAPIName thing from D3D9 as that was a leftover from d8vk.

I have modified it so that the date and timestamp is only included if the working tree is dirty.

Hey Alpyne, I think removing the date/timestamp  for dirty trees too, that didn't seem interesting, for I agree with what Josh said it breaks reproducible builds.

I have modified it so that the date and timestamp is only included if the working tree is dirty.

Hey Alpyne, I think removing the date/timestamp for dirty trees too, that didn't seem interesting, for I agree with what Josh said it breaks reproducible builds.

Non-timestamped builds can be reproduced by building with a non-dirty tree or by adding && 0  to line 5 of version.h.in. As far as I know there aren't usually cases where dirty tree builds have needed to be reproduced precisely, but correct me if I'm wrong.
If people want I can add a meson option for timestamping that's off by default too, or I can just close this PR. Up to the maintainers. I only made this PR at @K0bin's suggestion, otherwise I would probably have left it upstream in d8vk.

If people want I can add a meson option for timestamping that's off by default

Good idea, I like it, an option for that, I think I would even use :relaxed:

Added as an option :)
Run meson configure -Dbuild_date=true <build dir> to enable it or set it to always if you don't care if the working tree is dirty (although at that point you can just go by commit ID).

Sup @AlpyneDreams, did you build the DXVK with this modification you made?
GCC-Mingw and CLANG-Mingw do not build DXVK with your Patch..
GCC-Mingw:

CLANG-Mingw:

And you will have to Bump the required meson version to >=0.55


[Test coverage improvements] Test coverage improvement for aggregations & other search qeuries for field mapping types.

As of today, we have several types supported as a index field while creating index.
Like Int, Long, Float, half_float, sclaed_float, etc.
FieldMapper.java Gives idea about such field types. Search queries on those types have several hotpath and there are undercover paths which for which search query code path might not be exactly same. So modifying this code path might give some side effect for some data types while we improve/change some other data types.
For example, while introducing sort optimization for custom numeric types https://github.com/opensearch-project/OpenSearch/issues/10997, we got this nasty bug where half_float numeric type sort queries were completely broken.
Upon digging more, there aren't tests which were covering half_float basic sort queries validation.
As a part of this PR https://github.com/opensearch-project/OpenSearch/pull/11024, we have added that validation, but we do not have single test case for aggregation of half_float type.
I am creating this issue, to primary add integration tests for half_float aggregation search queries. But also validate for other field types and at least add basic search query tests for all field types.

@gashutos are you looking to pick this up or looking to help someone from the community work through this? If you want it, can you assign yourself please?


feat: upgrade to<EMAIL_ADDRESS>

:tada: This PR is included in version 1.34.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Doesn't work on local filesystem or subdirectory

BlogDown doesn't work on a local filesystem or a subdirectory because imports are loaded relative to the root or domain name.

This is impossible due to the way Polymer imports work. :(


add UDF error check in pipeline engine

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] others

Which issues of this PR fixes ：
Fixes #4427
Problem Summary(Required) ：

@Mergifyio backport branch-2.2


set a good default style

Replace the current default style by something less ugly :slightly_smiling_face:

As a first pass, what we could do is assign the same default symbology to points, lines, and polygons that we currently have in Builder.
When Voyager was released, we went through a significant exercise of testing a LOT of combos and coming up with default colors that could be "seen" over the three different basemap types and between each other. This will also keep things "familiar".
The basics:
Polygons
color: #826dba
EXAMPLE
Lines
color: #4cc8a3
width: 1.5

EXAMPLE
Points
width: 7
color: #ee4d5a
strokeWidth: 1
strokeColor: #fff

EXAMPLE
In terms of "smarter" behavior there are some things I'd like to explore when time permits:

Marker size depending on the density of data... more data = smaller points, less data = larger points

similarly, thinking about good defaults that could take advantage of zoom(). But the value we use would depend largely on the density of points... for example using something like the styling below, the points disappear at small zooms.

width:  0.001 * zoom()
color: #ee4d5a
strokeWidth: 0.0001 * zoom()
strokeColor: #fff

If/when we have the capabilities to detect the basemap

basemap dependent symbology (automatically do the inverse(cartocolor))
for light basemaps, use a light outline, for dark, a dark basemap

I think it is a good idea to use the same cross-basemap default style, and in the future add the logic for multiple default styles.
Since we are sharing properties for all the geometries we cannot have the same default styles:

color: points & lines & polygons
width: points & lines
strokeColor: points & polygons
strokeWidth: points & polygons

So... with this and the default Builder style in mind, what default values should we set in these properties? @arianaescobar @makella

Would it take too much time to stop sharing properties between all the geometries?

It's easy to implement, but the point is that this is a decision for the spec (https://github.com/CartoDB/carto-vl/issues/55).

But we could change the defaults based on the geometry type though.

But we could change the defaults based on the geometry type though.

That's what we want :)

are we all good here to set defaults based on geometry type?

Now that we have strokes for polygons (🎉) we can update the default to:
color: #826dba
strokeWidth: 1
strokeColor: #fff

EXAMPLE

OK. So the final default values would be the following (taking into account the opacity), right?
Points
width: 7
color: opacity(#EE4D5A, 0.9)
strokeWidth: 1
strokeColor: #FFF

Lines
width: 1.5
color: #4CC8A3

Polygons
color: opacity(#826DBA, 0.9)
strokeWidth: 1
strokeColor: opacity(#FFF, 0.5)

NOTE: I have seen that opacity in strokeColor for polygons doesn't look good because the line rendering for the stroke is too simple so we could use strokeColor without opacity instead.

@arianaescobar I looked at the current implementation in Builder: https://github.com/CartoDB/cartodb/blob/master/spec/lib/carto/styles/geometry_spec.rb

@Jesus89 that is a model that we followed that has always happened in builder (slight opacity to points and polygons)
for our purposes, don't worry, we can just assign the colors with no opacity

Perfect. I'm going to update the main ticket to introduce the final defaults :)

Closed by #373

@Jesus89
This might be known, but definitely something that we need everyone to look at for their maps.
If there has been no strokeWidth already defined, every point feature on maps are showing with a white outline.

I'm assuming the same for polygons
and the same for marker width
and anywhere else these properties aren't explicity defined

I can understand that this is complex, so maybe we can talk through a little.
In the meantime, everyone should add the strokeWidth:0 and other properties to their maps.
Some examples:
https://carto.com/developers/carto-vl/examples/#example-animated-dataset

great!


Benchmark LinkedList vs ArrayList for entities

Moved to https://github.com/AlmasB/FXGL/wiki/Issue-Feature-Question


Bike images

changed line 233 of server.js

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: andrehe001 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Regression test for support of 'extends' in array item type

Regression test for #1087

Thanks @unkish, you are a star!


Update Reactor, Netty, and Jackson Dependency Versions

Closing this PR as Netty and Jackson have been upgraded but Reactor is blocked on a new release of their library.


[BUG] join_test failed in integration tests

Describe the bug
failed list,
[2022-07-15T04:36:09.326Z] FAILED ../../src/main/python/join_test.py::test_broadcast_join_right_struct_as_key[LeftAnti-Struct(['child0', String(not_null)],['child1', Byte(not_null)],['child2', Short(not_null)],['child3', Integer(not_null)],['child4', Long(not_null)],['child5', Boolean(not_null)],['child6', Date(not_null)],['child7', Timestamp(not_null)])][IGNORE_ORDER({'local': True})]
[2022-07-15T04:36:09.326Z] FAILED ../../src/main/python/join_test.py::test_broadcast_join_right_struct_mixed_key[LeftAnti-Struct(['child0', String(not_null)],['child1', Byte(not_null)],['child2', Short(not_null)],['child3', Integer(not_null)],['child4', Long(not_null)],['child5', Boolean(not_null)],['child6', Date(not_null)],['child7', Timestamp(not_null)])][IGNORE_ORDER({'local': True})]
[2022-07-15T04:36:09.326Z] FAILED ../../src/main/python/join_test.py::test_sortmerge_join_struct_as_key[LeftAnti-Struct(['child0', String(not_null)],['child1', Byte(not_null)],['child2', Short(not_null)],['child3', Integer(not_null)],['child4', Long(not_null)],['child5', Boolean(not_null)],['child6', Date(not_null)],['child7', Timestamp(not_null)])][IGNORE_ORDER({'local': True})]
[2022-07-15T04:36:09.326Z] FAILED ../../src/main/python/join_test.py::test_sortmerge_join_struct_mixed_key[LeftAnti-Struct(['child0', String(not_null)],['child1', Byte(not_null)],['child2', Short(not_null)],['child3', Integer(not_null)],['child4', Long(not_null)],['child5', Boolean(not_null)],['child6', Date(not_null)],['child7', Timestamp(not_null)])][IGNORE_ORDER({'local': True})]

detailed logs,
failed.log
CPU and GPU out put mismatched
AssertionError: CPU and GPU list have different lengths at [] CPU: 260 GPU: 500

Could be related to new merged cudf commits (current jni jar targets to https://github.com/rapidsai/cudf/commit/ec761da7cb9a80efff2aa18a0f0039e4bf5581a6)
To reproduce,
integration_tests/run_pyspark_from_build.sh -k test_broadcast_join_right_struct_mixed_key

Seems it's related to cuDF commit: https://github.com/rapidsai/cudf/pull/11100
I reverted this PR, then the cases passed.
The cases get errors when doing left-anti-join on a struct column with a non-nullable sub-column in it.

I'm still debugging it. Caught the failed input data but can't reproduce in cudf test yet:
One of the failed test:
@ignore_order(local=True)
@pytest.mark.parametrize('data_gen', struct_gens, ids=idfn)
@pytest.mark.parametrize('join_type', ['LeftAnti'], ids=idfn)
def test_broadcast_join_right_struct_as_key(data_gen, join_type):
    def do_join(spark):
        left, right = create_df(spark, data_gen, 10, 20)
        # print("CPU OUTPUT: %s" % cpu)
        print("LEFT %s" % left.collect())
        print("RIGHT %s" % right.collect())
        return left.join(broadcast(right), left.a == right.r_a, join_type)
    assert_gpu_and_cpu_are_equal_collect(do_join)

LEFT [Row(a=Row(child0=-341142443), b=Row(child0=-100515324)), Row(a=Row(child0=20129910), b=Row(child0=1727289611)), Row(a=Row(child0=790204970), b=Row(child0=-282729822)), Row(a=Row(child0=-98742266), b=Row(child0=-2087175000)), Row(a=Row(child0=1578841898), b=Row(child0=1591161832)), Row(a=Row(child0=2008070098), b=Row(child0=1859007115)), Row(a=Row(child0=887174525), b=Row(child0=173016769)), Row(a=None, b=Row(child0=-236270331)), Row(a=Row(child0=324918642), b=Row(child0=-1345486411)), Row(a=Row(child0=-100798596), b=Row(child0=1618216427))]
RIGHT [Row(r_a=Row(child0=-341142443), r_b=Row(child0=-100515324)), Row(r_a=Row(child0=20129910), r_b=Row(child0=1727289611)), Row(r_a=Row(child0=790204970), r_b=Row(child0=-282729822)), Row(r_a=Row(child0=-98742266), r_b=Row(child0=-2087175000)), Row(r_a=Row(child0=1578841898), r_b=Row(child0=1591161832)), Row(r_a=Row(child0=2008070098), r_b=Row(child0=1859007115)), Row(r_a=Row(child0=887174525), r_b=Row(child0=173016769)), Row(r_a=None, r_b=Row(child0=-236270331)), Row(r_a=Row(child0=324918642), r_b=Row(child0=-1345486411)), Row(r_a=Row(child0=-100798596), r_b=Row(child0=1618216427)), Row(r_a=Row(child0=1338435109), r_b=Row(child0=1931725428)), Row(r_a=Row(child0=1259821658), r_b=Row(child0=558978567)), Row(r_a=Row(child0=994238642), r_b=Row(child0=1265224248)), Row(r_a=Row(child0=848988934), r_b=Row(child0=775624428)), Row(r_a=Row(child0=326215455), r_b=Row(child0=2063803297)), Row(r_a=Row(child0=-1615357958), r_b=Row(child0=-1031136222)), Row(r_a=Row(child0=-642982504), r_b=Row(child0=2096953985)), Row(r_a=Row(child0=994707147), r_b=Row(child0=741485586)), Row(r_a=None, r_b=Row(child0=1483587345)), Row(r_a=Row(child0=-1396639655), r_b=Row(child0=-613528857))]

CPU OUTPUT: [Row(a=None, b=Row(child0=-236270331))]
GPU OUTPUT: [Row(a=None, b=Row(child0=-236270331)), Row(a=Row(child0=-100798596), b=Row(child0=1618216427)), Row(a=Row(child0=324918642), b=Row(child0=-1345486411)), Row(a=Row(child0=887174525), b=Row(child0=173016769))]

Update: I have successfully reproduced the bug in cudf. The reason is still unclear - it is not due to corner cases and is more complicated to identify. I'm continuing to trace it down.

Tracked down to a bug in the cudf experimental row hasher: https://github.com/rapidsai/cudf/issues/11283
Still chasing down the bug. Will keep updated here.

Done. Should be fixed by this: https://github.com/rapidsai/cudf/pull/11284

Thanks! I just triggered the new plugin jni build, premerge CI should be back to normal after new jni artifact is online


Antlr parser errors

Currently antlr parser errors aren't handled. We need to add support for syntactic errors and notify the user in case they make one.
UPD: We might want to reuse the error format antlr uses for errors in ProgramDtoBuilder.js (search for TODO).
UPD: Look into antlr semantic predicates to check if an assignment statement has identica lvalues (probably won't work out, but still).

Closed by PR #23


fix: ios secrets

:tada: This PR is included in version 1.38.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Compatibility of legacy SM2 style in PHP 7.2.

Fix #69. No need to dynamically request service name, when its known that Navigation::class is one ultimately being requested in __invoke
Test will not run against 7.2 because #59 is against dev, while that branch is probably tested against SM3 making this less relevant. Although, test for general creation ability can be ported to improve coverage.

I've rebased this from current develop, which contains updates for PHP 7.2 compatibility; I'll merge if/when the tests are green.

Thanks, @alextech!


Caching / Offline mode?

Caching everything would speed up browsing by a ton. I understand there's no need for a desktop application, but it would be nice anyway.
I'm sometimes without connectivity for a day or two.
If it's too out of scope, I might try a high-availability setup, where it is hosted on my workstations.

Sorry, I'm not planning to implement an offline mode. This software is supposed to be installed on a server. Existing mobile clients might provide an offline mode.


Python support

That'd be great!

:+1:

:+1:

What are the preferred python linting tools?

I'd say pep8 is the standard, but flake8 wraps it and adds support for some other useful ones.

@srt32 flake8 does a pretty decent job out of the box

Thanks to @jmcarp Hound now knows Python!

Amazing! :+1:

@jmcarp @salbertson big stuff!


Game model added

Game model generated.
Game migration created.

@krzyszti take a look on those merge conflicts.


Color not visible anymore

Hi @Jorg3Lucas
after upgrading Jenkins to a newer LTS version (e.g. 2.346.1) the theme color and logo is not shown anymore.
The bug seems to be equal to upstream: https://github.com/afonsof/jenkins-material-theme/issues/194
It would be great if the issue could be fixed without having a local .css file on Jenkins.
Regards
Dominik

#70 should fix the issue.


Need to enable bluetooth

Are you 100% sure that the device must have fully activated Bluetooth (and thus broadcast its device name) under iOS as checked by ActionTableViewCell.swift?  Where did you get this information from?  The settings app is completely fine with me having contact tracing enabled (privacy -> health -> contact tracing) while Bluetooth is disabled and I couldn't find this requirement anywhere in the documentation of the framework. Is uncertainty the reason why you are warned about a "limitation" instead of a deactivation? If this is mistakenly seen as a prerequisite, it could have a massive impact on public acceptance.

I don’t though this too, because the API from Apple and Google does indeed not need a Bluetooth connection because it’s all over BLE. Therefore I wrote an Email to the CWA-Team, where they explained that Blietooth enabled in settings/ control center is a requirement

I also wondered why the app does not warn me that Bluetooth is disabled but shows "Exposure logging active".

I also wondered why the app does not warn me that Bluetooth is disabled but shows "Exposure logging active".

Thanks for the remark! Did "disconnect" bluetooth from the control center or did you completely disable it using Siri or the system settings? Because BLE stays on if you only disconnect bluetooth

It was completely disabled from the device settings when I installed the app.

@StephanGeorg You might want to open a new issue for that. I just didn’t read careful enough. While it isn’t mentioned in the documentation, it is mentioned under "more information" in the settings app.


bug: local plugin fails to load when bisecting

Did you check docs and existing issues?

[X] I have read all the lazy.nvim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of lazy.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
v0.11.0-dev+959-g4b9095285
Operating system/version
Fedora Linux 40
Describe the bug
A recent plugin update seemed to break something, so I wanted to troubleshoot with a git bisect of the plugin repo locally.
This seems to break Lazy, producing the following log message:
....local/share/nvim/lazy/lazy.nvim/lua/lazy/manage/git.lua:123: assertion failed!

This appears to be because the information fetched does not include a branch since we're in a detached HEAD state:
https://github.com/folke/lazy.nvim/blob/cf8ecc2c5e4332760431a33534240b0cbc6680ab/lua/lazy/manage/git.lua#L120-L122
Steps To Reproduce

Clone the repository of a plugin referenced in your config.
Start a git bisect between two commits.
Include dev in the table passed to lazy.setup, pointing path to the directory that contains the repository above.
Set dev = true in the configuration for that plugin.
Open neovim and open the Lazy window.

Expected Behavior
Ideally, Lazy should be able to handle a detached HEAD state for local plugins so we can do things like bisecting to troubleshoot plugin issues.
However, I realize this is an edge case, so I wasn't sure whether to label this as a bug or a feature request.
Happy to help work on this issue if there's interest.
The only other discussion I found about this was in https://github.com/folke/lazy.nvim/discussions/711.
Repro
vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    -- add any other plugins here
  },
})

Where do you see this error?
I don't see how this can be triggered by just starting Neovim.
The only code path that actually calls get_target sometimes after startup is the checker, but that uses pcall, so shouldn't trigger an error message.
I also did a bisect on a local repo plugin and that can still correctly find the branch in my case.

this may be user error, going to close this for now.
thanks for taking a look!


The "back" button in /core/tags doesn't work after creating a new tag

When creating a new tag, the "back" button doesn't navigate to the origin, where one has clicked on "Tags". Instead, one is redirected to the new tag page, because a history.back() is used. This is very irritating.

First, we should discuss it and think from user side.
@matakuka You implement the back button in #2183. What do you mean? Should we remove the button again?

A history.back() goes back to the last time the URL changed, which is not always the last time the state changed. For state changes, we have no memory yet.
Also, it is not always well defined where "back" is:
Most of the time, a "back" should send us upwards in the hierarchy. The hierarchy is modular, so Tag is top-level, but you may have been on Agenda before. There are also cases where I want to go back to where I came from, which might be tags <- agenda/item/#  <- motions/motion/detail, for example, not following a hierarchy at all.
I think the problem in the other issue was that we could not determine where the user came from, and instead of having no button, I inserted a history.back(), which made sense in this case. However, if the user went through state changes, "back" is different.
Possible solution:

A "memory" of where the user has been could be implemented as an array, so that each state appends itself, and the "back" button just works backwards through this. An array because we don't want only one step back, but several. Maybe limiting it to a certain amount of states.
Every state change needs to report to this function (best placed in core?), on every "back" trigger we need to modify this array and go to a state.
I'm not sure if we don't need to transport objects through state changes, which may be lost in the confusion.
Some state changes shouldn't be accessible through "Back", e.g. forms.
Some state changes can not be executed if the user's permissions change during the session.
A "upwards" button which always points to the upper level, if there is one (agenda/item/1 points to agenda). Here several pages must remain without that button, as there is no "up" for e.g. Tags.

Or is it somehow possible to save only for the tag page, where the user come from in one variable. So by clicking back, the user is sent to where he comes from. It should be a must, when entering the tag page, to give this as an argument, so the tag page always know where to go back. But coming from edit or new, the argument could be none so the last state does not get overwritten.
So you don't have to track every site and statechange, but only the important ones, namely where does the user come from, when he enters the tag page.

I think we should tackle this issue globally, not only on the Tag page, as there are other pages where the user could arrive from different places.

e.g. agenda list -> edit election: After updating the election you are on their assignments/# page, which leaves you with an all elections button, but you might want  "back" to be the agenda list, which is two or three states ago. history.back() should not work on this example, either.

+1 for global solution. But if it is easy and nobody has time to solve this problem globally I could live with a temporary partial solution.

Suggestion: Show tag form in ng-dialog, then the back button (from tag list view) works as expected.

Done in #2973


proposal: net/url: add RelativeURLPath

We have url.URL.ResolveReference, but nothing to perform the reverse calculation:
calculating a relative path that will transform one URL path into another.
The calculation is not hard but it's tricky to get right, and a function to
do this seems like it would sit well inside the net/url package.
In all the places we've needed this so far, both the base and target paths
are within the same host, so a path-only calculation seems to work well
and saves a bunch of potential edge cases.
So I propose this addition to net/url:
// RelativeURLPath returns a relative URL path that is lexically
// equivalent to targpath when interpreted by url.URL.ResolveReference.
// That is, for a path x returned by RelativeURLPath(basePath, targPath),
// and a URL u with path basePath, u.Parse(x) will return a URL
// with path targPath.
//
// It is assumed that both basePath and targPath are normalized
// (have no . or .. elements).
//
// An error is returned if basePath or targPath are not absolute paths.
func RelativeURLPath(basePath, targPath string) (string, error)

I assume your existing implementation is at https://github.com/juju/httputil/blob/master/relativeurl.go?
Also, since this func only takes paths, have you considered the path package instead? It wouldn't be paired with its counterpart ResolveReference, but I wonder if the func would be useful in any other context that would avoid having to import net/url.

@mvdan I'm fairly sure that this wouldn't be useful in any context other than HTTP. The logic is peculiar to the specific semantics used by relative URLs. For example, a trailing slash is significant.

ResolveReference takes two *URL and returns a *URL.
Why does this function work on strings instead of *URLs?
It seems like it should match ResolveReference if it is the inverse.
url.Relative seems OK to me.

Ping @rogpeppe; see @rsc's comment above.

Or if it's two *url.URLs as arguments, it could be a method named "Sub" like https://golang.org/pkg/time/#Time.Sub

We have
func (base *URL) ResolveReference(ref *URL) (abs *URL)

We could add
func (base *URL) Relative(abs *URL) (ref *URL)

or
func (abs *URL) Relative(base *URL) (ref *URL)

It's unclear to me which people would expect.
Filepath has
func Rel(base, targ string) (rel string)

Does anyone want to make a case for why this is important? We often want relative file paths, for example to display to users, but it's pretty rare to insist on relative URLs. Pretty much all URL uses are fine as absolute URLs.

We needed this because we have some HTTP services that are behind an apache gateway that rewrites URL paths to add a prefix (so we have several hosted services under the same virtual host).
The problem is that it's not possible for a service to form a link to an absolute path within that service, because that might be wrong (it's also possible to reach the service without going through the apache proxy).
So we need to use relative links - hence this function (which was non-trivial to get right FWIW).

Thanks for the context @rogpeppe. For now it seems like this would be best outside the standard library - the need seems very specific and rare.


added the first stage of github authintication

Before sending your Pull Request, be sure to check that you are making the pull request from your branch to the dev branch! Please do not try to push directly into branches on the main repo.
What changes have you made?
Added the first stage of github authentication:
-created the github app

created endpoints in api.js for the github app
changed the sign up link to direct  to the github app
created a reusable fileexchangeCodeForGithubUser.js  in the utils folder
created github_client_id and github_client_secret in the .env (look in to env.example)

All tasks completed @petemcfarlane could you please check this out,
thanks.


Repaint issues with image gadgets?

If you use the cap vocab to take a screenshot of the listener, the window that opens up with the screenshot doesn't paint properly (on Mac OS X, it stays gray until you force a repaint by dragging another window over sections of the screenshot window).
( scratchpad ) USE: cap
( scratchpad ) world get screenshot.

It could be related to #255.


There is load more click changes Url but not the containt of list view

I have use the pager and list view widget with your extension but while clicking on load more it changes the url but the containt remains the same not loading more items...
view code
 <?=
              ListView::widget([
      'dataProvider' => $listDataProvider,
       'itemOptions' => ['class' => 'item'],
      'options' => [
                    'tag' => 'div',
                    'class' => 'list-wrapper',
                    'id' => 'list-wrapper',
                    ],
       'layout' => "{items}\n {pager}",
       'itemView' => function ($model, $key, $index, $widget) {
        return $this->render('_list_item',['model' => $model]);

        // or just do some echo
        // return $model->title . ' posted by ' . $model->author;
    },
    'pager' => ['class' => \kop\y2sp\ScrollPager::className()]

              ]);

            ?>

The data provider in controller send data with below code
$pages = new Pagination(['totalCount' => $query->count()]);

        $dataProvider = new ActiveDataProvider([
            'query' => $query,
            'pagination' => [
                'pageSize' => 3,
                //'pageCount'=> $pages,
            ],
        ]);

Hi @hitesh2088, and sorry for late response.
Your problem is invalid usage. You changed list view container class from .list-view to .list-wrapper.
You now need to let ScrollPager know about this change:
'pager' => [
    'class' => \kop\y2sp\ScrollPager::className(),
    'container' => '.list-wrapper',
    'paginationSelector' => '.list-wrapper .pagination'
]


Fix ClangTidy

Internal ClangTidy balked about this during an import

This error specifically: http://clang.llvm.org/extra/clang-tidy/checks/readability-inconsistent-declaration-parameter-name.html
I wonder why our clang fmt sanity did not catch this. I guess internal ClangTidy is stricter?

The param was named status in the .h and status_code in the .cc and it did not like that

[trickle] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences


WrittenOn

All entities should have a writtenOn attribute that contains the date and time that the entity was created or updated.

Will use the option timestamps when defining a schema.  This will add createdAt and updatedAt.
var thingSchema = new Schema({..}, { timestamps: { c } });

Not using mongoose any more.  Change the POST and PUT data API handlers to always set writtenOn.

Use the more common name modifiedOn.