sonobuoy test plugin e2e failed

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
##############################################################
Hello,
i've run "sonobuoy run --wait" for an hour and the status is failed for plugin e2e
sonobuoy results $results
Plugin: systemd-logs
Status: passed
Total: 3
Passed: 3
Failed: 0
Skipped: 0
Plugin: e2e
Status: failed
Total: 1
Passed: 0
Failed: 1
Skipped: 0
Failed tests:
timeout waiting for results
Can you help me with that please
Here joint the log file
#####################################
What did you expect to happen:
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Sonobuoy version:
Sonobuoy Version: v0.20.0
MinimumKubeVersion: 1.17.0
MaximumKubeVersion: 1.99.99
GitSHA: f6e19140201d6bf2f1274bf6567087bc25154210
API Version check skipped due to missing --kubeconfig or other error

Kubernetes version: (use kubectl version):
-Client Version: v1.20.1
Server Version: v1.20.1

Kubernetes installer & version: 1.20

Cloud provider or hardware configuration:

OS (e.g. from /etc/os-release):
PRETTY_NAME="Debian GNU/Linux bullseye/sid"
NAME="Debian GNU/Linux"
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

Sonobuoy tarball (which contains * below)

sonobuoy_0.20.0_linux_amd64.tar.gz
202101081844_sonobuoy_049b2577-4551-44ff-82ed-e3c17dda4839.tar.gz

@GH-Djeff thanks for submitting the issue!
It seems that Sonobuoy aggregator failed to retrieve results from the e2e test runner. Can you please run it again and while the status is running, find the pod name with e2e (i.e. kubectl -n sonobuoy get pods and find the one with sonobuoy-e2e-<sha>) and look at the description to see if everything is operating normally (i.e. kubectl -n sonobuoy describe sonobuoy-e2e-<sha>).

@GH-Djeff thanks for submitting the issue!
It seems that Sonobuoy aggregator failed to retrieve results from the e2e test runner. Can you please run it again and while the status is running, find the pod name with e2e (i.e. kubectl -n sonobuoy get pods and find the one with sonobuoy-e2e-<sha>) and look at the description to see if everything is operating normally (i.e. kubectl -n sonobuoy describe sonobuoy-e2e-<sha>).

@wilsonehusin
I run it again, unfortunately it failed.
Here are the result on the commands you telle me to run
#####################################
21 [13:57:44] root@km1: /home/djeff  # sonobuoy run --wait
INFO[0000] created object                                name=sonobuoy namespace= resource=namespaces
INFO[0001] created object                                name=sonobuoy-serviceaccount namespace=sonobuoy resource=serviceaccounts
INFO[0001] created object                                name=sonobuoy-serviceaccount-sonobuoy namespace= resource=clusterrolebindings
INFO[0001] created object                                name=sonobuoy-serviceaccount-sonobuoy namespace= resource=clusterroles
INFO[0001] created object                                name=sonobuoy-config-cm namespace=sonobuoy resource=configmaps
INFO[0001] created object                                name=sonobuoy-plugins-cm namespace=sonobuoy resource=configmaps
INFO[0003] created object                                name=sonobuoy namespace=sonobuoy resource=pods
INFO[0003] created object                                name=sonobuoy-aggregator namespace=sonobuoy resource=services
ERRO[1204] error attempting to run sonobuoy: waiting for run to finish: Pod entered a fatal terminal status: failed
####################################################################################
Every 2.0s: sonobuoy status                                                                                km1: Sat Jan  9 14:21:19 2021
     PLUGIN     STATUS   RESULT   COUNT
        e2e     failed                1

systemd-logs   complete                1
systemd-logs    running                2
Sonobuoy has failed. You can see what happened with sonobuoy logs.
#################################################################################
Every 2.0s: kubectl -n sonobuoy get pods -owide                                                                                km1: Sat Jan  9 14:21:40 2021
NAME                                                      READY   STATUS    RESTARTS   AGE   IP              NODE   NOMINATED NODE   READINESS GATES
sonobuoy                                                  1/1     Running   0          22m   <IP_ADDRESS>   kn1
sonobuoy-e2e-job-f6d679d6afd44a5c                         0/2     Error     0          21m   <IP_ADDRESS>   km1
sonobuoy-systemd-logs-daemon-set-6d11ea3767484d37-htpzm   2/2     Running   2          21m   <IP_ADDRESS>    km1
sonobuoy-systemd-logs-daemon-set-6d11ea3767484d37-jqdr2   2/2     Running   2          21m   <IP_ADDRESS>    kn2
sonobuoy-systemd-logs-daemon-set-6d11ea3767484d37-rhxlb   2/2     Running   0          21m   <IP_ADDRESS>    kn1
################################################################################################
7 [14:18:35] root@km1: /home/djeff  # kubectl -n sonobuoy describe pod sonobuoy-e2e-job-f6d679d6afd44a5c
Name:         sonobuoy-e2e-job-f6d679d6afd44a5c
Namespace:    sonobuoy
Priority:     0
Node:         km1/<IP_ADDRESS>
Start Time:   Sat, 09 Jan 2021 14:00:14 +0100
Labels:       component=sonobuoy
sonobuoy-component=plugin
sonobuoy-plugin=e2e
sonobuoy-run=f6d679d6afd44a5c
tier=analysis
Annotations:  cni.projectcalico.org/podIP:
cni.projectcalico.org/podIPs:
sonobuoy-driver: Job
sonobuoy-plugin: e2e
Status:       Failed
IP:           <IP_ADDRESS>
IPs:
IP:  <IP_ADDRESS>
Containers:
e2e:
Container ID:  docker://f9aa62811d59efea231c7bbb22ebf2865b1d7dc9bc36533ece004bb5de2602de
Image:         k8s.gcr.io/conformance:v1.20.1
Image ID:      docker-pullable://k8s.gcr.io/conformance@sha256:9f165f5d6393246eae4ea77cfc99d7f39b7475bd7650c72759d44f1f2cd3bafe
Port:
Host Port:
Command:
/run_e2e.sh
State:          Terminated
Reason:       Error
Exit Code:    1
Started:      Sat, 09 Jan 2021 14:03:51 +0100
Finished:     Sat, 09 Jan 2021 14:14:03 +0100
Ready:          False
Restart Count:  0
Environment:
E2E_FOCUS:          [Conformance]
E2E_SKIP:           [Disruptive]|NoExecuteTaintManager
E2E_PARALLEL:       false
E2E_USE_GO_RUNNER:  true
E2E_EXTRA_ARGS:     --progress-report-url=http://localhost:8099/progress
Mounts:
/tmp/results from results (rw)
/var/run/secrets/kubernetes.io/serviceaccount from sonobuoy-serviceaccount-token-pdbj4 (ro)
sonobuoy-worker:
Container ID:  docker://ed4988baee372f93acbb9146842068dc69f21c6b5d5d3d83b95dff32d73560ae
Image:         sonobuoy/sonobuoy:v0.20.0
Image ID:      docker-pullable://sonobuoy/sonobuoy@sha256:ee14fd553315d41a72f705ad4e792809fa3c99f0fa73fec4c3af3d3da8d13ee5
Port:
Host Port:
Command:
/sonobuoy
Args:
worker
global
-v
5
--logtostderr
State:          Terminated
Reason:       Error
Exit Code:    1
Started:      Sat, 09 Jan 2021 14:04:07 +0100
Finished:     Sat, 09 Jan 2021 14:20:36 +0100
Ready:          False
Restart Count:  0
Environment:
NODE_NAME:                (v1:spec.nodeName)
RESULTS_DIR:             /tmp/results
RESULT_TYPE:             e2e
AGGREGATOR_URL:          https://[<IP_ADDRESS>]:8080
CA_CERT:                 -----BEGIN CERTIFICATE-----
MIIB8TCCAZegAwIBAgIBATAKBggqhkjOPQQDAjBgMQwwCgYDVQQGEwNVU0ExFjAU
BgNVBAcTDVBhbG8gQWx0bywgQ0ExDzANBgNVBAoTBlZNd2FyZTERMA8GA1UECxMI
U29ub2J1b3kxFDASBgNVBAMTC3Nvbm9idW95LWNhMB4XDTIxMDEwOTEzMDAxMFoX
DTIxMDExMTEzMDAxMFowYDEMMAoGA1UEBhMDVVNBMRYwFAYDVQQHEw1QYWxvIEFs
dG8sIENBMQ8wDQYDVQQKEwZWTXdhcmUxETAPBgNVBAsTCFNvbm9idW95MRQwEgYD
VQQDEwtzb25vYnVveS1jYTBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABHrdke33
BtrupJxltT/RwmO4d/J5T4bmVlmL6T2w7bPnw0+4Kei7jVLKLddz524aK6aaBmH5
PqjL8FTroXZ1ay2jQjBAMA4GA1UdDwEB/wQEAwICBDAPBgNVHRMBAf8EBTADAQH/
MB0GA1UdDgQWBBSOvhWM+YjWgWcpJNwJR6od5UBsdjAKBggqhkjOPQQDAgNIADBF
AiEA+WitgVQD52shXdJ8Ti7e6kPqAzCd8q21wp0TDhiKi18CIFyxIohyBIFVcvsp
6BEt0g5R8Svq9WS21FyGHAPeH+AG
-----END CERTIFICATE-----
  CLIENT_CERT:             <set to the key 'tls.crt' in secret 'sonobuoy-plugin-e2e-f6d679d6afd44a5c'>  Optional: false
  CLIENT_KEY:              <set to the key 'tls.key' in secret 'sonobuoy-plugin-e2e-f6d679d6afd44a5c'>  Optional: false
  SONOBUOY_PROGRESS_PORT:  8099
Mounts:
  /tmp/results from results (rw)
  /var/run/secrets/kubernetes.io/serviceaccount from sonobuoy-serviceaccount-token-pdbj4 (ro)

Conditions:
Type              Status
Initialized       True
Ready             False
ContainersReady   False
PodScheduled      True
Volumes:
results:
Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
Medium:
SizeLimit:
sonobuoy-serviceaccount-token-pdbj4:
Type:        Secret (a volume populated by a Secret)
SecretName:  sonobuoy-serviceaccount-token-pdbj4
Optional:    false
QoS Class:       BestEffort
Node-Selectors:
Tolerations:     CriticalAddonsOnly op=Exists
kubernetes.io/e2e-evict-taint-key op=Exists
node-role.kubernetes.io/master:NoSchedule op=Exists
node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
Type    Reason     Age   From               Message

Normal  Scheduled  22m   default-scheduler  Successfully assigned sonobuoy/sonobuoy-e2e-job-f6d679d6afd44a5c to km1
Normal  Pulling    20m   kubelet            Pulling image "k8s.gcr.io/conformance:v1.20.1"
Normal  Pulled     18m   kubelet            Successfully pulled image "k8s.gcr.io/conformance:v1.20.1" in 2m9.676360582s
Normal  Created    18m   kubelet            Created container e2e
Normal  Started    18m   kubelet            Started container e2e
Normal  Pulled     18m   kubelet            Container image "sonobuoy/sonobuoy:v0.20.0" already present on machine
Normal  Created    18m   kubelet            Created container sonobuoy-worker
Normal  Started    18m   kubelet            Started container sonobuoy-worker
############################################################################################
Here joint the sonobuoy lo fily
sonobuoy.log

@wilsonehusin
I run it again, unfortunately it failed.
Here are the result on the commands you telle me to run
#####################################
21 [13:57:44] root@km1: /home/djeff  # sonobuoy run --wait
INFO[0000] created object                                name=sonobuoy namespace= resource=namespaces
INFO[0001] created object                                name=sonobuoy-serviceaccount namespace=sonobuoy resource=serviceaccounts
INFO[0001] created object                                name=sonobuoy-serviceaccount-sonobuoy namespace= resource=clusterrolebindings
INFO[0001] created object                                name=sonobuoy-serviceaccount-sonobuoy namespace= resource=clusterroles
INFO[0001] created object                                name=sonobuoy-config-cm namespace=sonobuoy resource=configmaps
INFO[0001] created object                                name=sonobuoy-plugins-cm namespace=sonobuoy resource=configmaps
INFO[0003] created object                                name=sonobuoy namespace=sonobuoy resource=pods
INFO[0003] created object                                name=sonobuoy-aggregator namespace=sonobuoy resource=services
ERRO[1204] error attempting to run sonobuoy: waiting for run to finish: Pod entered a fatal terminal status: failed
####################################################################################
Every 2.0s: sonobuoy status                                                                                km1: Sat Jan  9 14:21:19 2021
     PLUGIN     STATUS   RESULT   COUNT
        e2e     failed                1

systemd-logs   complete                1
systemd-logs    running                2
Sonobuoy has failed. You can see what happened with sonobuoy logs.
#################################################################################
Every 2.0s: kubectl -n sonobuoy get pods -owide                                                                                km1: Sat Jan  9 14:21:40 2021
NAME                                                      READY   STATUS    RESTARTS   AGE   IP              NODE   NOMINATED NODE   READINESS GATES
sonobuoy                                                  1/1     Running   0          22m   <IP_ADDRESS>   kn1
sonobuoy-e2e-job-f6d679d6afd44a5c                         0/2     Error     0          21m   <IP_ADDRESS>   km1
sonobuoy-systemd-logs-daemon-set-6d11ea3767484d37-htpzm   2/2     Running   2          21m   <IP_ADDRESS>    km1
sonobuoy-systemd-logs-daemon-set-6d11ea3767484d37-jqdr2   2/2     Running   2          21m   <IP_ADDRESS>    kn2
sonobuoy-systemd-logs-daemon-set-6d11ea3767484d37-rhxlb   2/2     Running   0          21m   <IP_ADDRESS>    kn1
################################################################################################
7 [14:18:35] root@km1: /home/djeff  # kubectl -n sonobuoy describe pod sonobuoy-e2e-job-f6d679d6afd44a5c
Name:         sonobuoy-e2e-job-f6d679d6afd44a5c
Namespace:    sonobuoy
Priority:     0
Node:         km1/<IP_ADDRESS>
Start Time:   Sat, 09 Jan 2021 14:00:14 +0100
Labels:       component=sonobuoy
sonobuoy-component=plugin
sonobuoy-plugin=e2e
sonobuoy-run=f6d679d6afd44a5c
tier=analysis
Annotations:  cni.projectcalico.org/podIP:
cni.projectcalico.org/podIPs:
sonobuoy-driver: Job
sonobuoy-plugin: e2e
Status:       Failed
IP:           <IP_ADDRESS>
IPs:
IP:  <IP_ADDRESS>
Containers:
e2e:
Container ID:  docker://f9aa62811d59efea231c7bbb22ebf2865b1d7dc9bc36533ece004bb5de2602de
Image:         k8s.gcr.io/conformance:v1.20.1
Image ID:      docker-pullable://k8s.gcr.io/conformance@sha256:9f165f5d6393246eae4ea77cfc99d7f39b7475bd7650c72759d44f1f2cd3bafe
Port:
Host Port:
Command:
/run_e2e.sh
State:          Terminated
Reason:       Error
Exit Code:    1
Started:      Sat, 09 Jan 2021 14:03:51 +0100
Finished:     Sat, 09 Jan 2021 14:14:03 +0100
Ready:          False
Restart Count:  0
Environment:
E2E_FOCUS:          [Conformance]
E2E_SKIP:           [Disruptive]|NoExecuteTaintManager
E2E_PARALLEL:       false
E2E_USE_GO_RUNNER:  true
E2E_EXTRA_ARGS:     --progress-report-url=http://localhost:8099/progress
Mounts:
/tmp/results from results (rw)
/var/run/secrets/kubernetes.io/serviceaccount from sonobuoy-serviceaccount-token-pdbj4 (ro)
sonobuoy-worker:
Container ID:  docker://ed4988baee372f93acbb9146842068dc69f21c6b5d5d3d83b95dff32d73560ae
Image:         sonobuoy/sonobuoy:v0.20.0
Image ID:      docker-pullable://sonobuoy/sonobuoy@sha256:ee14fd553315d41a72f705ad4e792809fa3c99f0fa73fec4c3af3d3da8d13ee5
Port:
Host Port:
Command:
/sonobuoy
Args:
worker
global
-v
5
--logtostderr
State:          Terminated
Reason:       Error
Exit Code:    1
Started:      Sat, 09 Jan 2021 14:04:07 +0100
Finished:     Sat, 09 Jan 2021 14:20:36 +0100
Ready:          False
Restart Count:  0
Environment:
NODE_NAME:                (v1:spec.nodeName)
RESULTS_DIR:             /tmp/results
RESULT_TYPE:             e2e
AGGREGATOR_URL:          https://[<IP_ADDRESS>]:8080
CA_CERT:                 -----BEGIN CERTIFICATE-----
MIIB8TCCAZegAwIBAgIBATAKBggqhkjOPQQDAjBgMQwwCgYDVQQGEwNVU0ExFjAU
BgNVBAcTDVBhbG8gQWx0bywgQ0ExDzANBgNVBAoTBlZNd2FyZTERMA8GA1UECxMI
U29ub2J1b3kxFDASBgNVBAMTC3Nvbm9idW95LWNhMB4XDTIxMDEwOTEzMDAxMFoX
DTIxMDExMTEzMDAxMFowYDEMMAoGA1UEBhMDVVNBMRYwFAYDVQQHEw1QYWxvIEFs
dG8sIENBMQ8wDQYDVQQKEwZWTXdhcmUxETAPBgNVBAsTCFNvbm9idW95MRQwEgYD
VQQDEwtzb25vYnVveS1jYTBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABHrdke33
BtrupJxltT/RwmO4d/J5T4bmVlmL6T2w7bPnw0+4Kei7jVLKLddz524aK6aaBmH5
PqjL8FTroXZ1ay2jQjBAMA4GA1UdDwEB/wQEAwICBDAPBgNVHRMBAf8EBTADAQH/
MB0GA1UdDgQWBBSOvhWM+YjWgWcpJNwJR6od5UBsdjAKBggqhkjOPQQDAgNIADBF
AiEA+WitgVQD52shXdJ8Ti7e6kPqAzCd8q21wp0TDhiKi18CIFyxIohyBIFVcvsp
6BEt0g5R8Svq9WS21FyGHAPeH+AG
-----END CERTIFICATE-----
  CLIENT_CERT:             <set to the key 'tls.crt' in secret 'sonobuoy-plugin-e2e-f6d679d6afd44a5c'>  Optional: false
  CLIENT_KEY:              <set to the key 'tls.key' in secret 'sonobuoy-plugin-e2e-f6d679d6afd44a5c'>  Optional: false
  SONOBUOY_PROGRESS_PORT:  8099
Mounts:
  /tmp/results from results (rw)
  /var/run/secrets/kubernetes.io/serviceaccount from sonobuoy-serviceaccount-token-pdbj4 (ro)

Conditions:
Type              Status
Initialized       True
Ready             False
ContainersReady   False
PodScheduled      True
Volumes:
results:
Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
Medium:
SizeLimit:
sonobuoy-serviceaccount-token-pdbj4:
Type:        Secret (a volume populated by a Secret)
SecretName:  sonobuoy-serviceaccount-token-pdbj4
Optional:    false
QoS Class:       BestEffort
Node-Selectors:
Tolerations:     CriticalAddonsOnly op=Exists
kubernetes.io/e2e-evict-taint-key op=Exists
node-role.kubernetes.io/master:NoSchedule op=Exists
node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
Type    Reason     Age   From               Message

Normal  Scheduled  22m   default-scheduler  Successfully assigned sonobuoy/sonobuoy-e2e-job-f6d679d6afd44a5c to km1
Normal  Pulling    20m   kubelet            Pulling image "k8s.gcr.io/conformance:v1.20.1"
Normal  Pulled     18m   kubelet            Successfully pulled image "k8s.gcr.io/conformance:v1.20.1" in 2m9.676360582s
Normal  Created    18m   kubelet            Created container e2e
Normal  Started    18m   kubelet            Started container e2e
Normal  Pulled     18m   kubelet            Container image "sonobuoy/sonobuoy:v0.20.0" already present on machine
Normal  Created    18m   kubelet            Created container sonobuoy-worker
Normal  Started    18m   kubelet            Started container sonobuoy-worker
############################################################################################
Here joint the sonobuoy lo fily
sonobuoy.log

@GH-Djeff can you describe more about your cluster? From the logs it seems that Sonobuoy launched the jobs properly and your cluster is failing for Kubernetes conformance. In other words, at the moment I don't think this is a bug in Sonobuoy.

@GH-Djeff can you describe more about your cluster? From the logs it seems that Sonobuoy launched the jobs properly and your cluster is failing for Kubernetes conformance. In other words, at the moment I don't think this is a bug in Sonobuoy.

Hello,
it's a little 3 nodes Kubernetes cluster with 8GB and 8 vCPU per node.
The OS is Debian
The cluster is for testing purpose.
The cluster is not on the cloud but in my On premise virtual environment.
Maybe i don't have the minimum requirements.
Can you check that for me please ?
Regards,
Djeff

Hello,
it's a little 3 nodes Kubernetes cluster with 8GB and 8 vCPU per node.
The OS is Debian
The cluster is for testing purpose.
The cluster is not on the cloud but in my On premise virtual environment.
Maybe i don't have the minimum requirements.
Can you check that for me please ?
Regards,
Djeff

@GH-Djeff sounds likely that your cluster setup is not complete. I would probably start from checking if the nodes are acknowledging each other (i.e. kubectl get nodes -o wide should show 3 nodes as you described). I would also recommend looking into Kubernetes The Hard Way as a guide and joining Kubernetes Slack workspace and reach out to #kubernetes-novice 😃

@GH-Djeff sounds likely that your cluster setup is not complete. I would probably start from checking if the nodes are acknowledging each other (i.e. kubectl get nodes -o wide should show 3 nodes as you described). I would also recommend looking into Kubernetes The Hard Way as a guide and joining Kubernetes Slack workspace and reach out to #kubernetes-novice 😃


Hi my name is Leonardo and I'm trying to read a syslog file. I have just one trouble, follow:

Token 'Oct' doesn't match specifier '%h'
The "Oct" represent the month parameter and I don't know how can I setup this and also how parameter to use.
Originally posted by @lgomesrj in https://github.com/allinurl/goaccess/issues/1230#issuecomment-426313497

Closing this. Feel free to reopen it if needed.


7090 segmentnamegenerator accept input file parameter

Description
First cut at resolving #7090, to support generating segment names based on the input file path and a specified pattern/template.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
No
Does this PR fix a zero-downtime upgrade introduced earlier?
No
Does this PR otherwise need attention when creating release notes?

[X] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes
A new inputFile type is supported for the segmentNameGeneratorSpec section of a batch job file. This type supports naming the resulting segment file based on the input file name & path.
Documentation
To be added:
The inputFile type supports naming the resulting segment file based on the input file name & path. Two parameters must be specified in the configs section of the segmentNameGeneratorSpec section.:

file.path.pattern: A Java regular expression used to match against the input file URI.
segment.name.template: A string template that supports ${filePathPattern:\<match group>} substition.

For example, to set the segment name to be the same as the input file name (without the trailing .gz), use:
segmentNameGeneratorSpec:
  type: inputFile
  configs:
    file.path.pattern: '.+/(.+)\.gz'
    segment.name.template: '\${filePathPattern:\1}'

Note that $ in the yaml file must be escaped, since Pinot uses Groovy's SimpleTemplateEngine to process the yaml file, and a raw $ is treated as a template specifier.

Hi @Jackie-Jiang - a few things about this WIP...

The inputFilePath that I'm getting passed inside the SegmentGeneratorConfig, which is passed to SegmentIndexCreationDriverImpl (at least when running locally) is a path to a temp directory where it looks like the input file has been copied. So the real input path has been lost is that case, which means if the input file path pattern is matching anything other than the file name, it won't work. Any background on why the file is being copied?
I didn't want to hit the pom.xml files, but my build was failing without those changes to skip checks on Eclipse-generated files by rat and the apache license checker. I also had to do some dependency management to avoid a build failure due to pinot integration tests pulling in some local cloud test code which used a different version of AWS SDK jars. But I could try to separate those into a different PR.
I noticed a few other bits I should clean up when reviewing the committed files (e.g. Javadoc for InputFileSegmentNameGenerator).

Anyway, looking for input on items 1 & 2 above.

Codecov Report

Merging #7222 (2a0d0dc) into master (717940b) will decrease coverage by 8.19%.
The diff coverage is 84.37%.

@@             Coverage Diff              @@
##             master    #7222      +/-   ##
============================================
- Coverage     73.45%   65.26%   -8.20%
  Complexity       92       92
============================================
  Files          1508     1509       +1
  Lines         73939    73980      +41
  Branches      10682    10688       +6
============================================
- Hits          54309    48280    -6029
- Misses        16066    22278    +6212
+ Partials       3564     3422     -142

Flag
Coverage Δ

integration
?

unittests
65.26% <84.37%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...tion/batch/common/SegmentGenerationTaskRunner.java
62.71% <0.00%> (-2.21%)
:arrow_down:

...nt/spi/creator/name/FixedSegmentNameGenerator.java
80.00% <ø> (ø)

...eator/name/NormalizedDateSegmentNameGenerator.java
93.47% <ø> (ø)

...segment/spi/creator/name/SegmentNameGenerator.java
100.00% <ø> (ø)

...t/spi/creator/name/SimpleSegmentNameGenerator.java
100.00% <ø> (ø)

...pi/creator/name/InputFileSegmentNameGenerator.java
88.88% <88.88%> (ø)

...t/creator/impl/SegmentIndexCreationDriverImpl.java
82.48% <100.00%> (-3.96%)
:arrow_down:

...a/org/apache/pinot/common/metrics/MinionMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/BrokerQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/MinionQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 367 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 717940b...2a0d0dc. Read the comment docs.

Hi @Jackie-Jiang - I think all input is addressed, assuming there aren't any more questions about the dependency management I added to pinot-integration-tests/pom.xml.

Thank you all !

Hi @Jackie-Jiang Thanks for the careful review, and merging this...my client will be happy :)

@kkrugler My pleasure. Thanks for the contribution!


Have inner subscriptions allow Promise, Array, Iterable, Observable, and observable

This is a work in progress ATM.

@blesh I'm loving this PR

Merging in prep for alpha release.


Dead Project?

Appears no code changes in 3+ years. Is this effort a dead project. If so I will fork it and bring it up to current Kong 3.x levels

https://github.com/pantsel/konga/issues/760

I'd appreciate that. And I assume not only me :-)

I guess it is just bought not dead by Zuplo, check the read me


CSS arbitrarily does not recompute styles

Sometimes (Especially with fast delays) some bars do not get updated (Height / Color).
Even tough element.style values are correct, the computed style does not seem to update.
Even if you manually update these values in the dev console, they do not get recomputed

Found the issue. Occurred because we use tweakpane with a ill-configured slider:
With the following options for the transition time (CSS transition-time variable):
    this._sliderTransTime = visualParamsTab.addInput(this._model, 'transitionTime', {
      label: 'transition time',
      min: 0,
      max: 0.3,
      step: 0.01,
      value: 0.1
    }).on('change', () => this._visualizer.updateCssRule('transitionTime'))

tweakpane set the value of tranistionTime to something like -3.234234e17 - which probably resulted from the params not aligning with the slider steps.
Such a value as a transition time in CSS seems to break computing of some styles.
Fixed by using a set of preconfigured transition time values, selectable by dropdown


Ability to Filter out CAM and Telesynce (TS) files.

Kindly at the ability to Filter out CAM and Telesynce files. Would love to only see links for better quality files.

@jishnurk I saw you were working on this feature. So instead of adding into the resolution filter, add it separately for quality.  That way it would be easy and clean.
Also, here are the list of supported qualities in from PTT parser https://github.com/mhdzumair/PTT/blob/main/PTT/handlers.py#L105-L135 .

CAM
TeleSync
TeleCine
BluRay REMUX
BluRay
UHDRip
HDRip
BRRip
BDRip
DVDRip
SCR
DVD
PPVRip
HDTV
SATRip
TVRip
WEB-DLRip
WEBRip
WEB-DL
Unknown (for any other, see the unknown implementation of filter)

@mhdzumair Thanks for the hint. That was just a hack. So what's your expectation?

A new section in config. with checkboxes for selecting quality?
Should quality be an option for sorting streams?
What about number of streams returned?
I also had thoughts about grouping several quality types. So where shall the mapping be done?

@jishnurk i can handle the implementation. i started to work on sorting streams by preferred languages. Ill handle quality filter as well.

@mhdzumair OK. I have anyway pushed some changes (in my fork). Just have a look.

Thanks i like the quality map. Ill add my changes on top of yours.

Supported in v4.0.0


query ok when alter table and change nothing

Steps to reproduce the behavior (Required)
CREATE TABLE `t3` (
  `k1` int(11) NULL COMMENT "",
  `k2` int(11) NULL COMMENT ""
) ENGINE=OLAP
DUPLICATE KEY(`k1`)
COMMENT "OLAP"
DISTRIBUTED BY HASH(`k1`) BUCKETS 3
PROPERTIES (
"replication_num" = "1",
"in_memory" = "false",
"storage_format" = "V2"
);
alter table t3 modify column k2 int(11);

Expected behavior (Required)
Nothing is changed. please check your alter stmt.
Real behavior (Required)
Query OK, 0 rows affected (0.00 sec)
StarRocks version (Required)

You can get the StarRocks version by executing SQL select current_version()
6d8e035

This bug has already been fixed.


Update getFilteredRowModel.ts

Avoid mapping null columnFilters

Why would column filters ever be null?

We are already doing this in line 31
I'm not yet sure how, but I had this variable null in a real project already

So, it's undefined, not null


As members of Skyporter and Liberator, we want to agree on the best way to make website changes

Our new Skyporter team, which is business and customer focused, wants to make changes to public facing materials including the website - to ensure that our communication with customers is clear, compelling. Skyporter is new and Liberator has been responsible for designing these materials. Let's all get on the same page and figure out how we want to work on this together.

I'll put something on the calendar - most likely for the week of 8/15.

https://pages.18f.gov/lean-product-design/ seems useful for us to read before the meeting, as a documented process for product design used in some ways around 18F - to help us have a shared vocabulary.

Takeaways from our meeting:
Review Processes
Always need one person to review changes made. Liberator typically makes decisions by consensus but we’re not doing this with marketing-related content and design changes.
Content Review: Changes made to online content related to marketing:
If Bernd makes changes, he needs to get review from one person within Skyporter/Liberator → can get merged.
If anyone else makes content changes, get Bernd’s review before getting merged
Design Review: Changes made
Everyone is invited to sketch
Liberator merges pull request
“I need design help.” → slack it in the Liberator channel
Responding to Requests for Immediate help or review
For liberator, bring to Sprint review to discuss whether they’re able to prioritize new issue
Generally, try not to present emergency issues
For the Future:
What is the role of content design in this process? :D
What should be our process for working on print materials?
Responding to requests for immediate help


Too Many Connection error

Hi Team,
I am using mysql create pool method but still connection is opened status.
so after connection reached "Too Many Connection error"

Hi @bgobi1991, that's really weird, and haven't really hard of it before. I played around a bit today and couldn't reproduce. Can you provide the code you are using and the instructions for me to reproduce the issue? Alternatively, since you have access to an environment that is having the issue, would you be willing to put together a PR with a fix?

Hi @bgobi1991 since I haven't heard back in a few months, I'm going to close the issue.


Harden validation of untrusted inputs

/retest

Yeah, I don't know. I'll try to reproduce it locally.


No addAll in IntSet nor IntCollection

... but both implementations of IntSet (did not check IntCollection) have addAll().
Likely also applies to other collections.

Indeed, I see it now. I'll correct the interface, thanks for the tip.

addAll(KTypeContainer<? extends KType> container) is trivial. addAll(KType...) is not because it's a type-unsafe vararg and SafeArgs can't be applied at the interface level (it only applies to final or static methods). After some deliberation I've added just the first version to the interface. I'm not sure what to do about the latter.


Bug: Unable to Cycle Through Photos in Windows 11 Photos App

Description
When attempting to open an image file in the Windows Photos app directly from the Files app, there is a limitation in navigating through all photos within the same folder.
Operating System:

Windows 11 Home
Version 22H2
OS build 22621.3593

Steps To Reproduce

Open Files app.
Navigate to a folder containing multiple image files.
Select an image file and double-click to open it in the Windows Photos app.
Within the Photos app, attempt to navigate to other images within the same folder using the navigation controls (e.g., arrows or film strip).

Requirements
When opening an image in the Windows Photos app from Files, users should be able to easily navigate through all photos within the same folder using the controls (e.g., navigation arrows, film strip at the bottom).
Files Version
<IP_ADDRESS>
Windows Version
Edition	Windows 11 Home Single Language Version	22H2 Installed on	2024/05/14 OS build	22621.3593 Serial number	PF4JL4DL Experience	Windows Feature Experience Pack 1000.22700.1003.0
Log File
debug.log

I personally can't repro this, but you can try reinstalling Files to see if it helps.

Had the same problem and I recorded a gif.

Files: <IP_ADDRESS>
Windows: 10.0.22631.3672
Microsoft Photos: 2024.11050.29009.0

I'm able to repro this with the latest version of Photos. I also confirmed that the code responsible for this behavior in Files has remained unchanged, so it's possibly an issue with the Photos app. If that's the case, the question remains why this doesn't affect File Explorer.

Crud. I just posted something on this after doing a search. I don't know why I didn't see this in my search before posting it. But yep, I'm in the same boat. I spend a LOT of time in Explorer bouncing between images in Photos. I try from time to time to use Files as I am genuinely interested in switching, but between this and not having a live tree view to the left updating as I click through folders, this is what chased me away again this round. :(  I really want to dump File Explorer lol

This appears to be an issue with the Photos app (you can report to Microsoft via the Feedback Hub) but you workaround this by selecting all the photo files and then using the arrows to switch between them.

I can confirm this issue is not present on Windows 10. This confirms my earlier theory that this is a bug with the Windows 11 Photos app. I'd like to call on the community to report this issue to Microsoft in the Feedback Hub.
I'll be keeping this issue open for reference.

I installed Visum Photo Viewer on two of my Windows 11 computers and have encountered the same issue where I am unable to scroll through other photos in same folder when opening an image from Files.
Opening a file in Visum Photo Viewer from Explorer, I'm able to scroll through other images in the same folder in vaguely the same order that the folder's contents is sorted in Explorer, and in the same order that Photos has sorted them when opening the same file from Explorer.

@spinstartshere what about on Windows 10?

@yaira2 I don't have a Windows 10 installation that I can test this on. I can confirm, however, that scrolling through other photos is possible when opening in Visum Photo Viewer using the preview build of Files. It still isn't possible when opening in Photos, however.

I'm having the exact same issue on Windows 10, when I open an image file in the Windows Photos app, I can't navigate through the others within the same folder. The only workaround I have is to open the folder with the native Windows explorer or open the image with QuickLook.

A fix for the Windows 10 version is in 3.7.8 (Preview only right now) https://files.community/download


Git/Hg option flags shown when entering the "show commands" command

When the user types in "show commands", a list of all of the git and mercurial commands available are shown. I think it would be helpful to also show which option flags are available for each displayed command.
For example:
git commit | Options: --amend, -a, --all, -am, -m
I have done some digging and think that the change would not take much work. Every command that does have an option has that indicated as an object within the hg and git commands.js
I would be happy to begin work on the issue and send in a pull request but I wanted to see if this matched your vision for the project first.

I think that would be great to add! There might not really be a central place where all the options are defined but my memory might be hazy -- feel free to attempt a PR or comment back here if there's not an easy way to do it

I have been digging around the files and I have found where the options are defined:
Within both the commands.js files for Git and Mercurial each command that has options has an options object attached.
Following this chain, within the commands/index.js file found here the Hg and Git commands are brought in and added to a variable called "commands" which is then exported. This commands variable does contain a function called getOptionMap that gets options for a command if they exist.
I was able to also find how/where the commands are added to the screen. It seems to be the section of code from lines 107-109 found in this file. My problem, however, is I am not very experienced in React, and could not really figure out how to change or trace what is being put into the div:
Depending on how the react file is parsing the lists of commands, my thought is that the getOptionMap function referenced above could be used to grab the set of options for each command that DOES have options (with a simple if statement). The getOptionMap just needs the command name and vcs for each command it is called for (which is already found in what is being displayed). To me, this would be the easiest way to solve this, I just am not sure how the react is working. Any additional insihgt would be appreciated!

Yeah so CommandView just renders some markup that it's given in the data container of the command prop -- so its really just something that converts markdown to HTML in the view.
Where we actually prepare that output is over here:
https://github.com/pcottle/learnGitBranching/blob/main/src/js/sandbox/commands.js#L116-L129
using this method:
https://github.com/pcottle/learnGitBranching/blob/main/src/js/sandbox/commands.js#L164-L171
I think inside there you might have access to options? let me debug and see

Alright this is what I was able to get with the referenced PR

It's not great since there's no context for each option -- but is this what you had in mind?

Yeah that's exactly what I was thinking! To me it seems obvious from context that these are the available flags? But I suppose if someone were completely new to Git they might not understand that

ok cool, ill go land this then

Sorry to steal the PR from you but debugging how this would work was 95% of the implementation :P


Inline functions when loading the dictionary

The functions sourceCheck and sourceInline are more or less taken from Repl, so should probably be unified somewhere else.
This makes the virtual definitions the dictionary produces be "complete", in that they don't need any more actions performed on them before they be evaluated with the source evaluator or compiled to core.

groovy :purple_heart:


Buttons with Expiry block needs updating

The buttons with expiry block needs updating (misaligned settings in the WordPress Editor sidebar)
https://github.com/WordPress/gutenberg/tree/trunk/packages/block-library/src/buttons

New error for this one
[Warning] Block type "lf/button-with-expiry" must support API version 2 or higher to work correctly with "useBlockProps" method. (gutenberg.js, line 7577)

I’d like to work on this, is that okay? or Can I take this on?

I've added a fix for this in CSS. I'm not sure if that's the best way to fix it or if there is a deeper fix required.


Make the JMH plugin only regenerate and recompile on source changes.

Made the JMH scope inherit Test to automatically get the benhcmark code on the path to avoid the special compile step and not write to the same class files directory
Cached the generation of sources and resources
Use sourceGenerators and resourceGenerators
All interactions with JMH are now scoped to jmh:*

Test failure seems to be a real one; https://travis-ci.org/ktoso/sbt-jmh#L932
I'll have a look at it soon

The tests ran fine locally. Could it be an issue with the version number being 0.2.2 just like the published one?
This looks suspicious:
[info] [info] downloading https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/pl.project13.scala/sbt-jmh/scala_2.10/sbt_0.13/0.2.2/jars/sbt-jmh.jar ...

Seems so :) Thanks for the PR, awesome usability improvement :)

@bantonsson would you like a release of this right away? I can cut it asap

In no hurry. Release when you find the time. I'm writing tests with my local version right now.


Performance could be enhanced

We have some solutions here with a lot of projects inside. When using dotnet outdated on such a solution, the performance is poor. The reason could be that updating is done package by package, which means for every package each affected project has to be updated. Possibly performance could be much better if the strategy would be the other way round: For each project update all affected packages - so each project would only be updated once.

I think, the main reason for the slow performance is, that each package is added for each project using dotnet add package. So, for every (project, package) an external process is spawned. dotnet add package supports only single packages.


null byte in message's channel

FayeRails::RackAdapter::RoutingExtension#incoming uses File.fnmatch? to match channel name. If channel name contains null byte "\0" an ArgumentError would be raised. The exception will drop a server (checked with Thin and Webric).
faye-browser.js includes channels names at 928..932 lines, malefactor can add null byte to channel name here via fire bug.

Pull request https://github.com/jamesotron/faye-rails/pull/66 created

Better solution https://github.com/SoftSwiss/faye-rails/commit/d698e733c9383a4bc4ab7dd68848f422ef33728b

Some channel names that causes drop a server:
"\"/meta/handshake\\u0000'\\\"--></style></scRipt><scRipt>netsparker(0x00058F)</scRipt>\""
"\"../../../../../../../../../../boot.ini\\u0000.php\""
"\"http://r87.com/n?\\u0000.php\""
"\"php://filter//resource=http://r87.com/n?\\u0000.php\""
"\"../../../../../../../../../../windows/win.ini\\u0000.php\""

I guess this is default config in Netsparker Web Application Security Scanner.

We should probably catch all the exceptions inside the rack adapter and log them, should we not?


Method getJob with param: timeout always return null

method:
 public List<Job> getJob(long timeout, long count, String... queueNames)

always return null and not blocking at this point.

@yanghua plz provide a test scenario.


Campaign > http stage :  body input is not passed to http request

When using an Http stage as part of a campaign, if the body is specified as one of the inputs, its value is not then passed to the http provider.  This means that the http request is sent without containing the properties passed.
An example of this is when creating a POST to LogicApp as part of an approval stage in a campaign. Information such as instance, solution and target is not sent to the LogicApp be included as part of the email.

Version Seen: 0.48.25

@lirenjie95 please have a test on this.


remove deprecated setExpectedException

Hi, I'm actually working on updating the SymfonyConfigTest for newer versions of PHPUnit right now. So, I will close this PR for now. Expect an update soon!


Retrieving Plugins Fails When Diagram Can't Be Opened

Describe the Bug
When opening a broken diagram there's an uncaught error in the console:
AppParent.js:178 Uncaught (in promise) TypeError: this.getPlugins(...).getAll is not a function
    at Ci.hasPlugins (AppParent.js:178)
    at Ci.wi (AppParent.js:194)

Steps to Reproduce

Open broken.bpmn

Expected Behavior
No error in console.
Environment

OS: Windows 10
Camunda Modeler Version: 3.3.0

Closed via https://github.com/camunda/camunda-modeler/pull/1482.


Cropping Exception

com.canhub.cropper.CropException$Cancellation: crop: cropping has been cancelled by the user Exception arises when we try to crop an image and press back without actually cropping the image

Yeah that's wanted

it generates a report because of that is there a way to handle it?

try/catch


Do we actually use/need _get_base_points?

While reviewing #772, I realized that _get_base_points is doing the same as _get_points, a search of the codebase doesn't show anything calling _get_base_points: is it cruft? @typemytype @typesupply

I'm looking through the code now. I'm pretty sure that I know what is going on, just double checking...

Ah, I think it's tied to the dynamic property, sorry for the noise


Dispatch action from saga immediately

Hi, is it possible to dispatch action from saga immediately?
Currently runPutEffect "schedules the put in case another saga is holding a lock"

No, you shouldn't have to think about scheduling. What's your use case for wanting this to happen "immediately"?

Sorry for late response @Andarist . My case is that I am handling fetching data for each page (url) in redux-saga.
Let's assume user clicks on a button -> click handler dispatches SOME_ACTION -> redux-saga watcher in its turn dispatches CALL_HISTORY_METHOD action from some react-router-redux library
How it works now:
1. clickHandler() { dispatch({ type: SOME_ACTION })
 }
2. REDUX_SAGA_WATCHERS[SOME_ACTION] {
 yield put({ type: CALL_HISTORY_METHOD })
 }
3. inside redux-saga: exec(put({ type: CALL_HISTORY_METHOD })) task
4. reactRouterReduxMiddleware() {
      if (action.type === CALL_HISTORY_METHOD) {
        history[action.payload.method](action.payload.args)
      }
    }
5. history.listen((location, action) => dispatch({ type: LOCATION_CHANGE }))
6. **for some reason put({ type: CALL_HISTORY_METHOD }) task hasn't finished yet, so put({ type: LOCATION_CHANGE }) task is added to the queue**
7. rendering new page
8. put({ type: CALL_HISTORY_METHOD }) task is finished -> exec(put({ type: LOCATION_CHANGE })) task
9. REDUX_SAGA_WATCHERS[LOCATION_CHANGE] { yield fetchDataForNewUrl() }

How I want it to be:
I want fetchDataForNewUrl() to be called before rendering the new page
My original question was wrong. The question now is why exec(put({ type: CALL_HISTORY_METHOD })) doesn't run synchronously (there are no redux-saga watchers for this action)


Check IP Services

Configurable check IP services.
Used by Dynamic DNS services to check IP addresses.
Configure as many check IP services as desired.  The first (highest in the list) that is enabled will be used as the default.
A future possibility could be to add an option to the Dynamic DNS entires to use a specific check IP service.
Addresses bug #6493 by allowing additional check IP service to be added and selected as the default.

Merged for 2.4, thanks @NOYB

added feature ticket https://redmine.pfsense.org/issues/6591

Disappointed that it won't be available until 2.4.  But at least I have it.  :)

See #3071 for a backport PR of this to RELENG_2_3


"Node handle" in sidebar auto is reset all children nodes when collapse and expand their group node

Go to http://w2ui.com/web/demos/#/sidebar/13 check some children nodes and then collapse and expand group node. All check is clear.
"Node handle" in sidebar auto is reset all children items when collapse and expand their group item

The demo is fixed


Fixing Issue #2046 - Adding filter items needed for on-deploy-script to function

Adding items to get on-deploy-script up and working again. Based on PR #2045 by kwin (Konrad Windszus).

Please be kind - this is my PR to this repo! Let me know if there's anything I can do to help here.

Pull Request Test Coverage Report for Build 4993

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 54.405%

Totals

Change from base Build 4984:
0.0%

Covered Lines:
14375

Relevant Lines:
26422

💛  - Coveralls

This will be obsolete when #2045 is merged, so please be patient with that one.  If that one does not merge this week, I can review this smaller PR instead to get this fix in as you're not the only person waiting for this bug to be fixed.
Thanks!

This is resolved by the merge of #2032


Update scalatest to 3.1.1

Updates org.scalatest:scalatest from 3.1.0 to 3.1.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalatest", artifactId = "scalatest" } ]

labels: test-library-update, semver-patch

Pull Request Test Coverage Report for Build 135

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+1.08%) to 75.922%

Files with Coverage Reduction
New Missed Lines
%

scassandra/src/main/scala/com/evolutiongaming/scassandra/CreateClusterJ.scala
1
50.0%

Totals

Change from base Build 132:
1.08%

Covered Lines:
350

Relevant Lines:
461

💛  - Coveralls


Broken images at https://developers.google.com/web/updates/2015/03/push-notifications-on-the-open-web

All the images are broken in the article guys.

Eg. https://developers.google.com/updates/images/2015-03-04-push-on-the-open-web/enabled-disabled-push-ux-chrome.png
Should be:
https://developers.google.com/web/updates/images/2015-03-04-push-on-the-open-web/enabled-disabled-push-ux-chrome.png
You miss /web/ in the path.

Looking at it now.

@gauntface it looks like {{site.baseurl}} is not set and it is used quite heavily on the site.

@gauntface just fixing now WFBaseUrl

This PR has been merged (ta PK) so should be fixed in the next build - sorry it got through and thank you for the bug report :)

Thanks to you guys @PaulKinlan @gauntface


Resources: Add first-class support for combining canned conditions

There was some discussion on my last pull request about whether it could be useful to add extra scaffolding for combining canned conditions. It's a not-uncommon situation where tank busters don't always work terribly well with caresAbout canned conditions. While these conditions do notify anyone to mitigate, they don't include the "YOU are the target" component that's kind of necessary for busters.
One suggestion from quisquous was to add a conditionFunc base object to return a boolean from a canned helper, so that we could then return that in a condition like any other comparison. (That is, something like return condFunc.caresAboutMagical() || condFunc.targetIsYou().) This is of course the right way to do it, but I'm not sure whether it's really worth the effort.
Panic suggested adding physicalTankbuster and magicalTankbuster as conditions, mapping to matches.target || Conditions.caresAboutX(). This isn't as totally "correct", but it's not wrong, and it wouldn't require any actual work. (This has my vote simply because of these factors.)
Maybe the best thing is to specialize the tank buster conditions for now, and revisit this in 6.0 if Square adds new mechanics that necessitate new conditions?

Yeah, I think specializing tankbuster conditions for now sounds good.  It doesn't preclude helper functions later!
(And I think saying my proposal is the right way to do it is overstating the case!  I think there's lots of ways to do this.  My biggest concern in all of this is making it harder to do the deceptively incorrect condition: (data, matches) => data.something && Conditions.targetIsYou(), as Conditions.targetIsYou() always evaluates as truthy as it's a function.)

Closing since it's largely irrelevant now that caresAbout conditions aren't applied to busters/raidwides.


[MatTooltip] UI issue in differenet browsers

Bug, feature request, or proposal:
Tooltip Text isn't align to left in Chrome browser
What is the expected behavior?
Tooltip Text should be left align for long unbreakable string
What is the current behavior?
Incorrect behavior in Chrome: https://prnt.sc/iy2seu
Correct behavior in Firefox:   https://prnt.sc/iy2wn6
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
angular/material 5.0 and 5.2

Closing as this is something that is caused by the browser and not by the MatToolip.
A reproduction with only html and a style attribute shows this occurring as well.


show recently changed events as a special page in the schedule

Shown for favorites on home screen, could also be tagged on the cards?


Ability to draw horizontal grid lines?

Not an issue as much as a request: I have been looking without resolve for a way to add horizontal grid lines or possibly extend the exiting ticks to be the width of the graph.  Is this possible and if so can you direct me to the line number I might update that ability?

+1
I need that feature as well

I think you can just add a series with two data points as a workaround... But you'll have a tooltip on it, then. What about this syntax in the options :
{
  extra: {
    hLines: [{axis: 'y', color: 'red', value: 12}]
  }
}

?


404 for https://docs.microsoft.com/en-us/powershell/module/pkiclient/

Describe the bug
404 Not found on a link in documentation.
To Reproduce

Go to https://docs.microsoft.com/en-us/windows/msix/package/create-certificate-package-signing#prerequisites
Click on below link

Notice it redirects to a 404 not found page at https://docs.microsoft.com/en-us/powershell/module/pkiclient/

Expected behavior
Link to not be broken

Was already reported here: https://github.com/MicrosoftDocs/msix-docs/issues/80


Compiler goes into loop when encountering special characters

When starting a line with # or @ the compiler should throw an error,
instead it only loops

not only the start of a line its everywhere except in strings

Also when there is only a string without anything else

Issue is probably related to the parse_statement function:
while loop_control:

  self.__parse_identifier_statement()
  self.__parse_return_statement()
  self.__parse_loop_control_statements(Tag.BREAK)
  self.__parse_loop_control_statements(Tag.CONTINUE)
  self.__parse_while_statement()
  self.__parse_if_statement()

  if self.__lookahead(Tag.FUNC):
    self.__parse_block()

   elif self.__lookahead('}'):
     loop_control = False

We don't throw an Syntax error or exit the loop, when something else than expected is in the token_stream

Also when there is only a string without anything else

What do you mean with strings without anything?

func test(){    "Some string"; }
Thats what I mean by "without anything"

FYI: This compiles
func test(){      j: int = (1/0);       Some text that really should cause the compiler to break;      return j;   }


How to limit the dot indicator appear

Can you make the dot indicator just show maybe to 4 or 5 dot, if we have much photo
Show all dot here

Maybe you should try this
imageSlideShow.pageIndicator = nil
It will not appear anymore

Hi, this is unfortunately not supported on UIPageControl, but you can use label as a page indicator: slideshow.pageIndicator = LabelPageIndicator(frame: .zero). Font and position are configurable.
Or you can implement your own page indicator by implemeting the protocol PageIndicatorView.

Thank you @zvonicek

Can we update the documentation to provide an example with the minimums of :
     imageSlideShow.pageIndicator = LabelPageIndicator(frame: .zero)
     imageSlideShow.pageIndicator?.numberOfPages = imageURLArray.count


Add StockSCANsat from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of malah, to add StockSCANsat to CKAN.
Please direct questions about this pull request to malah.

Closed via #2227


Add unshare project from group

Add possibility to stop sharing a project with a group as described in Gitlab API Doc.

Thanks for the quick review @svanharmelen!


App runs with ADB but not as expected from apk

From @GoogleCodeExporter on May 31, 2015 11:31
What device(s) are you experiencing the problem on? Note-2

What firmware version are you running on the device? 4.1.2

What steps will reproduce the problem?
1. Create simple app which opens a webpage as an intent using droid.view()
2. Run the script via adb (opens the webpage)
3. Run the script as an app via apk. App closes when it starts

What is the expected output? What do you see instead?
Expected output is webpage. Nothing is seen and the app closes

What version of the product are you using? On what operating system?
I am using linux and sl4a r6

Please provide any additional information below.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 3 Oct 2013 at 4:53
Copied from original issue: damonkohler/android-scripting#698

This issue was moved to damonkohler/sl4a#20


Any way to use base64 icons with text at bottom instead of only text in the Tap bar?

Like in TapBarIOS is there a way to use icons with text at the bottom?

Sure, just implement your 'Icon' class and pass it to tabs.

icon and text

<Icon name="ios-person-outline" />  <Text name="ios-person-outline">Contact</Text>
I hope this works.


[Skia] TextBox: Grey caret doesn't match current caret with default FontSize (12)

MCVE
    <TextBox
        MinWidth="120"
        HorizontalAlignment="Center"
        VerticalAlignment="Center"
        TextAlignment="Center" />

        public static AppBuilder BuildAvaloniaApp()
            => AppBuilder.Configure<App>().UseDirect2D1().UseWin32().LogToDebug();

Result

Works fine with other FontSize. Behaviour doesn't occur with UseSkia.
Also, probably somehow related to VerticalAlignment="Center"

I was unable to reproduce the behaviour on latest preview.
Though I got another oddness. I will open a new one then.


fix: incorrect ID for Victor's Spoils

Had the same ID as KGB so was somewhat noticeable. What more errors could be in this file?

What more errors could be in this file?

Is that rhetorical?  It seems to me that some text processing could map elements of items.txt and ItemPool.java into a common format that could be compared.  Maybe every integer less than the maximum known item should have an ItemPool entry even if the constant is something like ItemPool.ITEM_12456?  Might even be a test that could be written or a debug command?  For extra credit it would be nice to have a parameterized test framework that understood ItemPool.TOMATO as the parameter instead of just 246.

It's somewhat of a real question. I ran a script to find other duplicates and didn't find any (non-deliberate, e.g. bang potions have both FIRST_BANG_POTION and MURKY_POTION). I'm not sure how we'd find errors while keeping reasonable UX like the ability to pick your own item names, though.


can't read issue from target repo.

index.html:
// Define
var config = {
    user:       'shnode',                                       // GitHub Username
    repo:       'trashy-notes',                                     // GitHub Repo
    token:      '2322a49be80'+'2d09bd95e3a1e3cd58776b31c584c',  // Github access_token
    info:       'Be cool, but also be warm',                   // About Yourself
    per_page:   9,                                              // Per Page Posts Number
    behance:    '',                                             // Behance URL
    dribbble:   '',                                             // Dribbble URL
    instagram:  ''                                              // Instagram URL
}

issue repo: link
with api link returns right response: https://api.github.com/repos/shnode/trashy-notes/issues
but there is no posts when access Mirror.
what happened...

sorry that the gh-pages branch not merge the master branch, now fixed
you can re-pull the branch or just replace the files assets/mirror.js, dist/mirror.js

make it!


Remove TaskGroup backDeployed annotation typo that included *

Fix typo on a single task group backDeployed annotation.

@swift-ci please smoke test


It would be good to have a checker for dead code in the project

Description
Since I submitted the issue (https://github.com/primer/react/issues/2992), I was thinking about the fact that there should be a checker for dead code or files in the project so that people can more easily find out when certain files in the src folder should be removed.
I looked it up and deadfile (https://m-izadmehr.github.io/deadfile/#/) seems to be a good resource to find dead files in JavaScript projects
Steps to reproduce
This is related to https://github.com/primer/react/issues/2992
Version
35.2.0
Browser
No response

👋🏻 Hi @ollie-iterators, thanks for the suggestion! While we're moving some files around right now, there is the potential to introduce some dead code but this is not a common situation so we'd rather not introduce a new CI check. Appreciate your input!


retry mechanism

1st, I think this change is so fundamental change, need time to prove it works correctly before push to other developers.
2nd, I only test the http part, the websocket part is not working in my machine(to be clear, I simply cannot make websocket works in my docker environment, not this change), and I got not enough time to diagnostic why it fails recently.
IMHO, don't merge for now. This PR is just let you know what I am working on and wish you could let me know your suggestion, I'll test it in my online service with users could test against these codes. Then I'll let you know it's ready (at least the http part).

interesting. I will take a look.
for the http bits, have you looked at all at what's built into the framework?
https://docs.microsoft.com/en-us/dotnet/architecture/microservices/implement-resilient-applications/implement-http-call-retries-exponential-backoff-polly
Since Websocket is a persistent connection retry, at lest for transient network issues is likely less important.

As I'm thinking more about this I don't know if retry belongs in this layer. There are edge cases that would need to be considered that might make more sense to reason about in the app layer. Are there ways for an RPC call to look like it failed but it actually succeeded? What's the best thing to do if a pushtx request times out?
Open to discussion for sure, but things that should be considered.

Retry in Http or WebSocket is one thing, and retry in Chia API Protocol layer is this thing. Here is for the later one.
Here is my considerations:

I got error "newer block .....(blabla)" error with success: false when calling GetCoinRecordsByPuzzleHashes time to time. As my service recently served ten thousands of requests each day, the failure rate are unacceptable.
I was switched from another library ChiaApi, which is not maintained and lack of websocket functionality, it works without this issue, I take a look at their source code, and find such retry mechanism: https://github.com/ByronAP/ChiaApi/blob/af8bcad90661468463368e3ff60910ac9e91e4f4/src/ChiaApi/Utils/HttpTools.cs#L129-L154
pushtx is also retried in that ChiaApi, as my service only serves up to 20 pushes each day, I'm not fully sure this retry mechanism is acceptable, that's why I isolated the pushtx without retry.

Got it.  You're going to retry only if you got a response with success equals false.  Right?
That makes sense and addresses what I was thinking.

Correct! 😊

Got it. You're going to retry only if you got a response with success equals false. Right? That makes sense and addresses what I was thinking.

Cool.  I can think of a way or two that it could be implemented somewhat generally so it can be reused between both http and wss. I'll dig a bit more.

Please have MaxRetries property default to 0 so that retry logic is opt-in, not opt-out (especially for current consumers)
Change uint? maxRetries = null parameter on SendMessage to uint maxRetries = 0. null is effectively zero making the nullable redundant

First one is done, for the 2nd one, null means using the instance default, while 0 means no retry, I deem it is necessary.

the 2nd one, null means using the instance default, while 0 means no retry, I deem it is necessary.

gotcha

I just pushed the NFT stuff for 1.4.0 to main. You may want to merge that into you branch (It includes you HeaderHash addition).

Although the code serves millions of requests(and then I migrated to a database backed solution), however, I'm thinking this should not be a default behavior, various API varied. I just discovered some other APIs also not the best candidate to retry.
Maybe another way outside this library or an extension method would be better.
Would take a look later, as I'm really busy recent months.😭

Maybe another way outside this library or an extension method would be better.

I do see retry as a cross cutting concern conceptually best handled by something external to the retry target. Like you, busy busy, but I'll see if I can come up with a pattern that might work,


Drop support for Python 2.5

Could we drop support for 2.5? 2.6 has already been available for 3 years.
Issues where dropping 2.5 would help:

Fix connection pooling behavior when maxsize > 1 (issue #13)
Ensure that the user-specified timeout is set before making a request (issue #17)

You know I'm reluctant but it I agree we'll have to do this eventually.
Seems every major third-party Python package I check still supports Py25: Django, httplib2, SQLAlchemy, etc.

It would also make Python 3 compatibility (#16) easier. It's not impossible to support older versions, but the code is cleaner if you can assume 2.6+.

@takluyver If you're willing to start work on Py3 compat, I'm willing to drop Py25 support. :-)

@shazow :cake:

Requests plans to drop 2.5 when the switch to 3 occurs as well (unless it's not a burden, of course)

I'm struggling to get the test suite to run without eventlet (just on Python 2.7). The dummyserver has a fallback to wsgiref's simple server (and I've done a bit of work to get that starting and stopping), but there are several test failures. Any ideas?
Current state is at: https://github.com/takluyver/urllib3/tree/py3

I've persuaded it to work with Tornado as the server for the tests (Tornado is compatible with Python 3).

@takluyver Thank you for your efforts so far! You're right that dummyserver is a bit fragile and not all the tests pass with wsgiref, specifically the ones that test SSL certs (since wsgiref doesn't support that). Perhaps we should remove wsgiref fallback altogether.
I'm happy to accept a port of dummyserver to Tornado. I'm not very strict about adding dependencies to the test suite, and eventlet is rather hacky on many platforms so this would be a good tradeoff.

See PR #35

Done since merging python3 into master.


Roialign fix and half_pixel mode support

Fix bugs in the implementation of ROIAlign operation which were found when attempting to run it with the half_pixel coordinate conversion mode, to include more thorough tests.  Some bugs are mode-specific and some are not.
The ROIAlign operation was first proposed in a paper at https://arxiv.org/abs/1703.06870v3 which introduced the Mask R-CNN model.  It was a variant of the ROIPool operation which was found to give significantly better accuracy.  In the implementations in Torch, Onnxruntime, and Migraphx, ROIPool and ROIAlign are implemented in the same op. with different choices for the mode attribute, with output_half_pixel for ROIPool and half_pixel for ROIAlign; thus, there is no ROIAlign op without fixing the half_pixel mode.
Note, by the way, that these same coordinate conversion modes are also attributes of the Resize op.
MIGraphX uses the Onnxruntime implementation of ROIAlign as its functional specification and should give identical results.
This change is prerequisite for torch-migraphx PR #143 but does not close it.

Don't review this yet!  It's very incomplete and I just created the PR to make it easy to visualize the changes so far.

The licensing check fail now occurring is for a file not related to this PR:
Error: The licenses for the following 1 file(s) either... do not match the year of commit, have a different copyright format or have not been synced from the latest roialign_fix branch:
['src/targets/gpu/kernels/include/migraphx/kernels/float8.hpp']

Looks fine, just a few small things. I haven't been able to fully wrap my head around all the math in the ref and gpu impl, the index changes look reasonable. Do we have a way to directly test against ORT (without maunally extracting gold outputs)? If so, I think it would be worthwhile to add a few more tests comparing with ORT

I think it would be possible to add a test following the model of the existing tests in test/py/.  With luck it wouldn't be very much extra work, half a day or so.  @pfultz2 what do you think?  The rationale for adding an op test here is that the ROIAlign op is defined in terms of the Onnxruntime implementation so it makes sense to have a specialized test with ORT as the reference.
Note my recent comment that I learned the ORT implementation of the max pooling option is buggy and can't be used for a test reference until the fix is released.  I don't know whether max pooling is widely used with this op or not.

Looks fine, just a few small things. I haven't been able to fully wrap my head around all the math in the ref and gpu impl, the index changes look reasonable.

Do you want me to go over it with you?  I can explain the intent of nearly everything but the indexing is still very difficult to unravel.

You should capture the onnxruntime results and just create a ref test.


Problem with setting post dates

I'm migrating a blog from another platform to Camaleon, and I want to preserve the dates on posts. I've activated the Visibility Posts plugin, but the Published Date setting doesn't have the effect that I want. The posts I import show the date I imported them as the post date, rather than the date that I specify. The same applies to the list of Latest Articles, as they're ordered by the date created rather than the dates that I've set.

Hi @briank-musichouse,
Visibility plugin "Published Date" is to indicate the date since this post will be visible for frontend visitors and not the created at date.
I created this plugin for that:
https://github.com/owen2345/camaleon_post_created_at
Please test it and let me know

That works great, thank you!


double opponents

Describe your problem here.
https://user-images.githubusercontent.com/87480185/200218095-b3980de5-492d-4c1e-990a-0fe50aeeb3c6.mp4

second opponent is't moving
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

Read the bottom of the screenshot, it only works with No Animation notes

Read the bottom of the screenshot, it only works with No Animation notes

i did't notice tnx


Add recombination current params to all bishop88 functions

The changes made in #163 incorporate recombination current into the bishop88() function.  Functions that build on the bishop88() function should likewise accept these parameters.

Thanks @cwhanse, @wholmgren and @mikofski!


Change comments style

Based on this array of strings, string or object should we add some special syntax for such cases, like
array<string> | string | object to separate it from other comments (optional, text etc) and not use commas everywhere?

Based on this array of strings, string or object should we add some special syntax for such cases, like
array | string | object to separate it from other comments (optional, text etc) and not use commas everywhere?

I like this idea, however, it's not possible if we have to maintain backward compatibility.

I don't think there is anything more to break =). If you are referring to https://github.com/metarhia/metaschema/pull/107#issuecomment-423511723 then it never supported multiple types (i.e. string or object) therefore the behavior will be the same from the point of view of guard(https://github.com/metarhia/metaschema/blob/master/lib/schema.js#L289).

This requires changes in createInstance which can be done, but I'd like to hear opinions, because now only string, number, boolean, undefined, function, object, null, symbol are supported. Also there are some functions which use capital-case Object and scalar.
BTW, I think this conversation should be moved to the appropriate pull request.

@tshemsedinov I'd like to hear your opinion about https://github.com/metarhia/common/pull/194#issuecomment-423983573. @lundibundi wrote:

Based on this array of strings, string or object should we add some special syntax for such cases, like
array<string> | string | object to separate it from other comments (optional, text etc) and not use commas everywhere?

Also, which theese long comments style is preferable?
//   arg - long description,
//     rest of long description

or
//   arg - long description,
//   rest of long description

The current style for multiline arg-comments is
//   arg - long description,
//         rest of long description

(aligned with the top line)

https://github.com/metarhia/common/pull/202

@burbokop There is no need to create another similar PR in this repository. Moreover, your changes were already fixed here.

Rebase on master, please.

fwiw, why do we need to put commas after the parameter type? Can we make that optional?
(I think this can be fixed with sed 's/>,/>/g' ./lib)

@SemenchenkoVitaliy have you deliberately omitted lib/auth.js?

:tada:


Durable functions support python yet?

Do we have durable functions supporting python yet? I see this Git here but don't see any documentation on it on this page.
https://github.com/kashimiz/azure-functions-durable-python

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b934ad1d-aabb-707d-d296-02cfbb22ec5c
Version Independent ID: 5d8f8cfb-be79-fac8-62ef-3a396a3be3e8
Content: Durable Functions Overview - Azure
Content Source: articles/azure-functions/durable/durable-functions-overview.md
Service: azure-functions
GitHub Login: @cgillum
Microsoft Alias: cgillum

Hi @svangeti Thanks for reaching out. We will review and update as appropriate.

Hi @svangeti Durable Functions 2.0 is GA for C# and JavaScript and contains new functionality in Durable Entities and support for consuming HTTP APIs in the orchestration trigger binding but no official information about Python.
https://azure.microsoft.com/en-gb/updates/new-version-of-durable-functions-available-now/

@svangeti Just following up here... Hope my previous comment helps.

Hi @DixitArora-MSFT - I see there is no support for Python Durable functions yet but have you checked the link I have sent https://github.com/kashimiz/azure-functions-durable-python
I am not sure if it's in preview feature or custom implementation. can you comment on it? The user seems to be from Microsoft.

@svangeti Yes, I think that is some of the work on this. The thread tracking this is at https://github.com/Azure/azure-functions-python-worker/issues/227 . Product group has alredy started working on this and based on current estimates it looks like we should be able to get a beta out sometime early next calendar year. So for now will proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.