Cause logic error by repeatedly applying "hard".

I'm adapting this for a tiny project of mine, and as far as I see, a logic error can consistently be caused by generating a few cards, and then only picking "hard" as an answer.
This seems to happen in applyToLearningCardState, with an end state of rating = "hard" and prev.consecutiveCorrect = 1.

I think I found it.
https://github.com/yodaiken/dolphinsr/blob/5a833fdb1d9d6b87ed48a9599ebb1ee17cc67ca8/lib/applyReview.js#L38
In pseudocode, it essentially boils down to:
if (isGood || isHard) && not isConsecutive:
    consecutive++
    repeat card

Looking at the anki flowchart in https://www.juliensobczak.com/inspect/2022/05/30/anki-srs.html, it seems what was meant may have been:
I think what was meant was:
if isHard || (isGood && not isConsecutive):
    consecutive++
    repeat card

In simpler words, if you remember the answer but are having trouble, it will treat it as a success (consecutive), but will make you repeat it until you're good at remembering it.

Note: this does fail the assumpition in types.ts, that in LearningCardState,
consecutiveCorrect: number; // 0 <= consecutiveCorrect < 2, int


Do not require authentication credentials for subcommands that don't need them

Subcommands such as ping or show hit unauthenticated endpoints, so they do not need to enforce users to provide them via the global -u/-a/-o options.
Resolves #92

Do you intend to release soon a version with this feature?

Do you intend to release soon a version with this feature?

Yes, next week ideally.


Update how-to-connect-sso-quick-start.md to include Microsoft Edge Ch…

…romium

@avaid96 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

We should add docs for the next version of Microsoft Edge on Chromium since it is Beta ready and users are requesting documentation. I've proposed some additions here based on customer requests in this issue - https://github.com/MicrosoftDocs/azure-docs/issues/37153.

@jborsecnik : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jborsecnik : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Checking with engineering.

@avaid96 Thank you for the feedback.  I am still waiting on engineering to get back to me on the SSO/Edge support status.  I have created a work item to track this.  I am going to go ahead and close this issue for now.  I will update it once I have gotten a definitive answer.  Thanks again!

#please-close

@jborsecnik : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Roll engine 31cd2dfca22a..429e56e97427 (29 commits)

git@github.com:flutter/engine.git/compare/31cd2dfca22a...429e56e97427
git log 31cd2dfca22a..429e56e97427 --no-merges --oneline
2019-11-12<EMAIL_ADDRESS>Roll src/third_party/dart 7ebc820ffc..5cce1e4acd (1 commits) (flutter/engine#13798)
2019-11-12<EMAIL_ADDRESS>Document the coordinate space of points in FlutterPointerEvent. (flutter/engine#13782)
2019-11-12<EMAIL_ADDRESS>implement radial gradient in canvaskit backend (flutter/engine#13796)
2019-11-12<EMAIL_ADDRESS>Adds missing comma in EngineParagraphStyle.toString() (flutter/engine#13795)
2019-11-12<EMAIL_ADDRESS>Roll src/third_party/skia ad21d47cfa8d..d860a78fd60c (2 commits) (flutter/engine#13794)
2019-11-12<EMAIL_ADDRESS>Roll src/third_party/dart 7408ed4730..7ebc820ffc (20 commits)
2019-11-12<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from TnTbF... to tZdOC... (flutter/engine#13791)
2019-11-12<EMAIL_ADDRESS>[web] Implement TextStyle.shadows (flutter/engine#13769)
2019-11-12<EMAIL_ADDRESS>Expose asset lookup from plugin binding. (#42019) (flutter/engine#13743)
2019-11-12<EMAIL_ADDRESS>Roll src/third_party/skia 3de645cbca78..ad21d47cfa8d (15 commits) (flutter/engine#13790)
2019-11-12<EMAIL_ADDRESS>Move Path and PathMetrics from canvas.dart into their own files. No delta (flutter/engine#13772)
2019-11-12<EMAIL_ADDRESS>Take devicePixelRatio into account when drawing shadows (flutter/engine#13786)
2019-11-12<EMAIL_ADDRESS>Add ImageFilter and BackdropFilter to CanvasKit backend (flutter/engine#13768)
2019-11-12<EMAIL_ADDRESS>Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13759)" (flutter/engine#13788)
2019-11-12<EMAIL_ADDRESS>Add Helvetica and sans-serif as fallback font families (flutter/engine#13784)
2019-11-12<EMAIL_ADDRESS>Roll src/third_party/skia 0fd4f01b9b83..3de645cbca78 (1 commits) (flutter/engine#13776)
2019-11-12<EMAIL_ADDRESS>Add line boundary information to LineMetrics. (flutter/engine#13727)
2019-11-11<EMAIL_ADDRESS>Fix RendererContextSwitch result check in Rasterizer::MakeRasterSnapshot (flutter/engine#13785)
2019-11-11<EMAIL_ADDRESS>[web] Fix path to svg for drrect (flutter/engine#13779)
2019-11-11<EMAIL_ADDRESS>Roll src/third_party/dart d45c3d15cb..7408ed4730 (20 commits) (flutter/engine#13778)
2019-11-11<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from RrTFI... to TnTbF... (flutter/engine#13775)
2019-11-10<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from 4JJNo... to RrTFI... (flutter/engine#13774)
2019-11-10<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from xC_an... to 4JJNo... (flutter/engine#13773)
2019-11-09<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from eq_Rz... to xC_an... (flutter/engine#13771)
2019-11-09<EMAIL_ADDRESS>Roll src/third_party/skia 4135cf0b57c2..0fd4f01b9b83 (1 commits) (flutter/engine#13770)
2019-11-09<EMAIL_ADDRESS>Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13759)
2019-11-09<EMAIL_ADDRESS>Point old plugin registry accessors to new embedding plugin accessors.  (#44225) (flutter/engine#13739)
2019-11-09<EMAIL_ADDRESS>Revert "[fuchsia] Temporarily disable intl provider (#13696)" (flutter/engine#13721)
2019-11-09<EMAIL_ADDRESS>Turn on RasterCache based on view hierarchy (flutter/engine#13762)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5445196308807680

Commit queue failed; closing this roll.


WeTransfer freezes on macOS

WeTransfer freezes on macOS 11.5.1 (Safari 14.1.2) when I try to upload a file. It's working fine with AdGuard for Mac (2.5.3) disabled and it's working fine on iOS.
AdGuard Social Media filter is causing the issue.

wetransfer.com -- this one, right?
Do we need to sign up there?
Does it depend on the file size?
What's exact AdGuard version?

@Chinaski1 that's probably about nighly

Still not reproduced on the latest Nightly

wetransfer.com -- this one, right? Yes
Do we need to sign up there? No
Does it depend on the file size? No
What's exact AdGuard version? <IP_ADDRESS>5 release (CL-1.7.200)

I have now tried to upload 1GB and have not encountered any issues.
AdGuard Social Media filter is ON.
Application version <IP_ADDRESS>5 release

My mistake, it's not the social media filter, I'm still trying to figure out what exactly causes the issue.

I have now tried to upload 1GB and have not encountered any issues.
AdGuard Social Media filter is ON.
Application version <IP_ADDRESS>5 release

It's the annoyance filter (sorry for the confusion):
https://we.tl/t-f1p0s3zaO7

It looks like a filters issue.
Could you please update filters and then check if issue still occurs?

@iDjay
Any updates?

yes, working :)


ugrep: 3.6.0 -> 3.7.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ugrep/versions.
meta.description for ugrep is: "Ultra fast grep with interactive query UI"
meta.homepage for ugrep is: "https://github.com/Genivia/ugrep"
meta.changelog for ugrep is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/h2sb0pnhj1ll3hxk6qq8w4l8i74qkq6y-ugrep-3.7.0/bin/ugrep had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/h2sb0pnhj1ll3hxk6qq8w4l8i74qkq6y-ugrep-3.7.0/bin/ug had a zero exit code or showed the expected version
0 of 2 passed binary check by having a zero exit code.
0 of 2 passed binary check by having the new version present in output.
found 3.7.0 with grep in /nix/store/h2sb0pnhj1ll3hxk6qq8w4l8i74qkq6y-ugrep-3.7.0
found 3.7.0 in filename of file in /nix/store/h2sb0pnhj1ll3hxk6qq8w4l8i74qkq6y-ugrep-3.7.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
ugrep

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/h2sb0pnhj1ll3hxk6qq8w4l8i74qkq6y-ugrep-3.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ugrep https://github.com/r-ryantm/nixpkgs/archive/9d2961629c29daa1d8e3254342de8c3a10ef5089.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/h2sb0pnhj1ll3hxk6qq8w4l8i74qkq6y-ugrep-3.7.0
ls -la /nix/store/h2sb0pnhj1ll3hxk6qq8w4l8i74qkq6y-ugrep-3.7.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

ugrep

Maintainer pings
cc @numkem for testing.

@ofborg eval


Host header includes port when making 80 request

Some servers will fail if the request Host header includes the port number when making a request on port :80. Now node-fetch (or rather the underlying Node.js module) includes Host header that includes the port.
I have fixed this using a wrapper.
https://github.com/gajus/xfetch/commit/3e8a7979df37e8a8b94e080e2145619aa90c6d03

I don't see this happening:
> fetch('https://httpbin.org/headers').then(r => r.json()).then(j => console.log(j.headers.Host))
Promise { <pending> }
> httpbin.org

Can you give a more specific method for reproduction?

You will need to intercept the request, e.g. using mitmproxy.

Right. Now I understand why I felt deja vu while working on this.
I have already raised an issue about this in the past with https-proxy-agent.
https://github.com/TooTallNate/node-https-proxy-agent/issues/22
Sorry, not related to node-fetch.


Write a program to create a class called COMPLEX and implement overloading functions ADD that return a COMPLEX number.

updated in q-6.cpp

updated in q-6.cpp with the use of the friend function.

is this question is removed from the main repo??


Entire File Path Used in Line Link

I am working using a remote workspace in VSC, but when I use either the copy/open commands it is actually considering the entire remote(and perhaps local) file path instead of the open file's relative path within the repository.

Hi @ascudes32! I'm surprised to find that someone else is using this, I mainly published it for my own use.
I also use remote VSC (over SSH), and the copy/open commands work as expected for me.
Could you share more about your setup? Maybe a screenshot/gif of it failing?


Replace new with R_GetRenderCommand()

Same as every other usage of it.

It's different for a reason. https://github.com/DaemonEngine/Daemon/blob/83244ed8442530e2776d4297b66dbb7a1ceacda6/src/engine/renderer/tr_cmds.cpp#L232

That makes sense. Closing this now.


Issue Running FastSpeech2 Model - FileNotFoundError: 'data/LJSpeech/valid.json'

Hi, thank you for developing this excellent project.
I am attempting to execute the FastSpeech2 model using the provided instructions at:
https://github.com/open-mmlab/Amphion/tree/main/egs/tts/FastSpeech2
Upon running the process command sh egs/tts/FastSpeech2/run.sh --stage 1, I encountered the following error: FileNotFoundError: [Errno 2] No such file or directory: 'data/LJSpeech/valid.json'.
Could you please provide guidance on resolving this issue? Your assistance is much appreciated.
Full log:
(amphion) root@5d89psego5dhs-0:/zhangpai21/workspace/cgy/1_projects/7_Amphion# sh egs/tts/FastSpeech2/run.sh --stage 1
/zhangpai21/workspace/cgy/1_projects/7_Amphion/mfa
Exprimental Configuration File: /zhangpai21/workspace/cgy/1_projects/7_Amphion/egs/tts/FastSpeech2/exp_config.json
Preprocess LJSpeech...
Prepare alignment LJSpeech...
13100it [00:01, 10765.15it/s]
MFA results are save in data/LJSpeech/TextGrid
Setting up corpus information...
Number of speakers in corpus: 1, average number of utterances per speaker: 13100.0
Creating dictionary information...
Setting up corpus_data directory...
Generating base features (mfcc)...
Calculating CMVN...
Done with setup.
Done! Everything took 1712.1863117218018 seconds
----------
Dataset splits for LJSpeech...

No Data Augmentation.
----------
Preparing metadata...
Including:
LJSpeech

  0%|                                                                                | 0/1 [00:00<?, ?it/s]Singer LJSpeech_LJSpeech: 1363.67 mins for training
----------

100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00,  4.77it/s]
Extracting acoustic features for LJSpeech using 4 workers ...
types:  ['train', 'valid', 'test']
Traceback (most recent call last):
  File "/zhangpai21/workspace/cgy/1_projects/7_Amphion/bins/tts/preprocess.py", line 250, in <module>
    main()
  File "/zhangpai21/workspace/cgy/1_projects/7_Amphion/bins/tts/preprocess.py", line 246, in main
    preprocess(cfg, args)
  File "/zhangpai21/workspace/cgy/1_projects/7_Amphion/bins/tts/preprocess.py", line 178, in preprocess
    extract_acoustic_features(dataset, output_path, cfg, args.num_workers)
  File "/zhangpai21/workspace/cgy/1_projects/7_Amphion/bins/tts/preprocess.py", line 44, in extract_acoustic_features
    with open(dataset_file, "r") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'data/LJSpeech/valid.json'

We will fix the bug as soon as possible.


Mouse Highlighter 'ghost' highlight

Microsoft PowerToys version
0.55.1
Running as admin

[ ] Yes

Area(s) with issue?
Mouse Utilities
Steps to reproduce
Unfortunately I can not reproduce. Here's what happened:
While using OneCommander and TeraCopy to transfer a file, OneCommander hung, I clicked a couple of times to check responsiveness, OneCommander crashed and the 'ghost' Mouse Highlight appeared.
It has persisted on my screen as shown below:
(the light grey circle near the bottom right)

Exiting PowerToys has removed the highlight. And restarting does not cause the highlight to return.
Bug report.zip
PowerToysReport_2022-02-04-21-22-20.zip
✔ Expected Behavior
Click and a highlight shows around the cursor after 100ms, then fade out for 250ms.
❌ Actual Behavior
Highlight does not fade out
Other Software
OneCommander <IP_ADDRESS>
TeraCopy 3.9
Windows 10 21H2 19044.1466

@PanoptesDreams this only happened the one time?

/needinfo
no clear repro steps here and i haven't seen this type of behavior in 53 or 55 timeframe.

I am experiencing the same issue.

It seems to go away if I restart PowerToys or disable the Highlighter. It´s pretty annoying

I am experiencing the same issue.
It seems to go away if I restart PowerToys or disable the Highlighter. It´s pretty annoying

I'm glad that this has popped back up, proves the bug exists and is still present.
That being said I have this feature turned off now.


Support for decimal scaling PV

Describe the bug
Cobrix should support the decimal scaling of character PV in copybook, getting error for S9(7)PPPV.
For usage click here
Expected behavior
It should parse the copybook file. Without below error:
ERROR ANTLRParser: Syntax error in the copybook: Line  no viable alternative at input XXXX:XX 'S9(7)PPPV'
Caused by: za.co.absa.cobrix.cobol.parser.exceptions.SyntaxErrorException: Syntax error in the copybook at line XXXX: Invalid input 'V' at position XXXX:XX

Copybook (if possible)
 05  Parent-Column                  COMP-3.
     07  Child-1   PIC S9V99.
     07  Child-2   PIC S9(7)PPPV.
     07  Child-3   PIC S9V99.
     07  Child-4   PIC S9(7)PPPV.
     07  Child-5   PIC S9(7)PPPV.
     07  Child-6   PIC S9(7)PPPV.
     07  Child-7   PIC S9(7)PPPV.
     07  Child-8   PIC S999.
     07  Child-9   PIC S9(11).

Hi @rjethure ,
Cobrix already supports integer and decimal scaling. It just does not support implicit comma 'V' at the and of the PIC. Please, try removing 'V' and let know if the behavior is as expected.

Hi @yruslan,
Thank you for quick response.
I tried by removing 'V' from copybook. After removing 'V' copybook is getting parsed without error.
But input data file's column are not getting correctly parsed. I am suspecting it is messing with START and END indices of the columns.

How exactly data is not correctly parsed? What is the expected and actual output?
You can use layout positions output from logs to determine if start and end offsets as as expected. Also you can use .option("debug", "true") to see raw values being decoded to spot mismatches.

Is it sorted?

The support for PIC S9(7)PPPV is implemented and now is in the master branch. The logic is the same as for PIC S9(7)PPP, according to this:
https://knowledge.informatica.com/s/article/109965?language=en_US

The feature is available in spark-cobol:2.7.0


add getters for Style props

This PR is to solicit feedback on another approach to address #619.
Basically, the idea is to define a getter for each type prop value, taking advantage of<EMAIL_ADDRESS>to restrict the keys to valid props.  We would have to list all relevant polymorphic variants for each getter but that's a manageable problem. We could add an unsafe getter to handle any values set by the unsafe methods already included in Style.
The main drawback is that we probably have to define functions to match getter output to values such as  `alignLeft but perhaps users can handle that themselves.

Since this kind of usage should be an edge case, I am not sure if going down this road worth it. I would go for something more simple, even if maybe less safe. I am thinking about maintenance & code involved for this "rare use case"

Then we can define one function unsafeGet or similar, which takes string for the prop name and returns string (and perhaps another which returns float) with which the user can deal themselves.

Yeah I was more thinking about something simple like that.

This change must have taken place somewhat recently, because it definitely was an int when I was adding examples for CameraRoll, etc. In fact it was you who had drawn my attention to that.
However, it was an int because it was more efficient to limit data exchanged over the bridge. Perhaps with the recent rearchitecturing, that is no longer as necessary.

Interesting approach, I wonder if it's worth the effort though.
I have written a lot of code based on these bindings and there was not a single time when I wanted to access props of a previously created style.
For a "dirty hack", something like
(style->Obj.magic)##fontSize

should suffice.

If we really want an "official" way to access the props, I think I would prefer having a getProps function (defined as an external using %identity%) that returns a Js.t object with all the fields. (With enum fields as strings, not polymorphic variants, but still better than nothing...)

@cknitt I wouldn't have though the compiler would consider the output of Obj.magic to be a Js.t object with a fontSize key. Nice trick!
@cknitt @MoOx
I have added a keys method to list keys included in a Style.t object. Making key an abstract type allows some safety so we can define the getters to return a value without having to wrap them in an option.
(float might need to be marked as unsafe as we cannot guarantee a float for just any key).
I have added a function to read a key as string so that users can determine which keys are included, I suppose we could also add a function to simply convert array(key) to a array(string) which might be more straightforward to use.
Users can always pass the getter functions anything as a key using a suitable function, but something a bit rigid might help users avoid hurting themselves.
We could also dial this back to simply adding
<EMAIL_ADDRESS>external keys: t => array(string) = "Object.keys";

which should still be a useful addition.

Sorry for chiming in but; I don't think all of this needs to be unsafe. Did you try adding some phantom types to it?

The pattern that’s been used for animated

@wokalski If you're thinking of defining key(float), etc which might have values like "fontSize", I don't see how that would be lower maintenance than listing all allowed polymorphic variants. Could you explain what you have in mind?

Sorry, I thought that part of the problem was that Style can be anything - obj, array, StyleSheet key etc. so Style.t(’a) would allow to only get value for Style.t(obj) for instance

@wokalski You are right, I wasn't thinking of that. Surely, these methods would not work with for example array(Style.t). Perhaps we can reasonably expect users would simply use these methods on Style.t objects they have created, I don't suppose the style of an element can be queried.
Still defining Style.t(simple) (which would the output of Style.style) and Style.t(array) or something similar to make it more rigorous would not actually cause inconvenience.

This approach feels too complicated to me.
Why not something simple like
type styleProps = {
  .
  "color": option(Color.t),
  "fontFamily": option(string),
  "fontSize": option(float),
  "fontStyle": option(string),
  // and many many more...
};

external getStyleProps: t => styleProps = "%identity";

@cknitt I agree, with the keys it’s a bit complcated but my thing is that the function that you suggested could be restricted to using on Style.t values which are objects and not arrays or smth else.

@wokalski Right. As far as I can see that problem exists with either approach though (my proposed function as well as the individual accessor functions proposed by @sgny).
Of course we could check at runtime whether the style is an object or an array, but that won't be zero-cost anymore.

@cknitt No conversion is needed. We can define
type t = {
  .
  "fontSize": option(float),
  "fontFamily": option(string),
  "color": option(Color.t)
  ...
};

and Style.style will happily output Style.t.
That was my first proposal, but it didn't seem to work. Now I tried it again, and it seems that I must have missed the interface file (Style.rei) then.
Anyway, it works as expected.

@sgny I would not do that, I would keep Style.t as an abstract type because, as @wokalski said, it might also be an array. So the type definition as a Js.t object would be incorrect.
With a getStyleProps function, this is not that bad because we can either call it unsafeGetStyleProps :wink: or check at runtime whether the style is an array or not.

@cknitt I've been trying to work around that, but as we can't use bs.unwrap with bs.obj for the style prop in components, I haven't arrived at a solution yet. I know that has been raised before for BuckleScript, but I don't think it's being planned.
I don't  suppose there is a way to define t(simple) as a Js.t and t(array) as everything else. Perhaps conversion is the only option.

Since bs.unwrapis unavailable with bs.obj, four approaches seem available to me. I think the last one is the most appealing.
Approach 1
Define t(simple) and t(complex) and define getters which only take t(simple) as argument.
Approach 2
While we cannot use @bs.unwrap, @bs.ignore works. We would need to define a new type as below:
type style(_) =
  | Single: style(Style.t)
  | Array: style(array(Style.t));
  | List: style(list(Style.t));

Then, the style prop can be specified as
    ~style<EMAIL_ADDRESS>style('a), 'a)=?,

The compiler complains with the The type of this module contains type variables that cannot be generalized: error, for the Animated.* components, but we can simply wrap the declaration with Obj.magic thanks to @jfrolich.
Style can be specified as
   style=(Single,someStyle)

or
   style=(Array,[|someStyle1, someStyle2|])

Admittedly, this is a bit ugly.
Approach 3
In Style.re, define
type simple = {
  .
  "fontSize": option(float),
  "fontFamily": option(string),
  "color": option(Color.t)
  ...
};

such that Style.style creates Style.simple and add functions to cast Style.simple or array(Style.simple), etc. as Style.t. Then the ## accessors will work only when they should.
Approach 4
In Style.re, define
type t = {
  .
  "fontSize": option(float),
  "fontFamily": option(string),
  "color": option(Color.t)
  ...
};

`style__array` and `style__list` as props to components, taking `array(Style.t)` and `list(Style.t)`, respectively. These will get rendered as `style`. Users can make mistakes and specify more than one among `style`, `style__array` and `style__list`, but I wouldn't be too worried about that. In that case, the one specified later prevails, so no runtime errors even if the style isn't quite what the user intended. Then, with multiple specifications, what would be the user's intention anyway.

We'd also remove functions such as `Style.array`.

I am not sure I like this ideas. Not that they are not good but I am thinking about DX & making things future proof.
None of this approach seems intuitive to me, and I am afraid this will be worst for new comers familiar with react native.
Also, in case RN StyleSheet decide to change the result provided by create (again) we will be in a weird situation where we will have to introduce others breaking changes (as all the solutions above will introduce breaking changes if I followed correctly).
Also, we are not sure that RN will returns us something defined in our type. JS is by nature unsafe, so if we want something safe, we can't really trust it (and for example that's why decoding json is such a pain lol). If for any reason RN decide for some reason to change a value provided to stylesheet.create, our layer won't be safe.
Since in the first place, the usage that would justify this changes is such a rare case (nobody asked for this in the first place, month after this bindings being out) it's probably doesn't worth such a big change in the DX we want to offer.
To make this simple, I would really go for a simple method that returns unsafe js that user should validate themselves. It's not a big deal & user will have to handle the mess if the value returned isn't what they expect.

Actually what StyleSheet.create returns doesn't matter because we have typed that as Js.t('a) and we do not actually have type safety there. We could have it return Js.Dict.t(Style.t) but then we cannot use the ## accessors.
I suppose anyone who has such a need, can handle it in an ad hoc manner.

I prefer to keep this simple as we can & "just" provide an escape hatch that will return some unsafe json a, as you said a dict(string).

Looks like this is an edge case nobody really seems to required (I am saying that because nobody asked for this).
Do we still want this?

I have a fairly large RN app and do not (yet) see the need for this. Better use a intermediate data structure for styles if you need to inspect it.

@sgny are you ok if we forget about this? This can be done in user land anyway right?

@MoOx Sure, it's been a useful exercise to investigate as it may translate to something else, but I haven't really needed anything like this either.


Doesnt work in low light or in background

When it's a little dark, the blink tracking fails. If the average luminance is low, i recommend normalizing brightness.
Also, it doesn't work while I'm switched to a different app. If there's some background or notification permission that needs to be set, please prompt the user!

Merged #25 , thanks! @Divide-By-0 @mdhsieh


Designer SDK Blog post

Work on this repo's ReadMe, which will ultimately become the .NET Blog Post for the Designer SDK.
We will also add this sample project to the .NET Samples repo.

@KlausLoeffelmann
Wow just noticed this PR. It sheds more light on the problem but questions still remain...

And yes, that’s a change from the previous .NET Framework-only Control Designers, and it involves indeed some refactoring of the design time code, but only if there is an actual UI which needs to be shown on top of the UI that is presented in the context of your actual control.

Very confusing sentence - this is not the only case when you will need much work to do :(

If you have type editors which are derived from existing type editors (like ColorEditor or FileNameEditor) for editing certain types of values for existing controls in .NET Framework, then you also need the client/server approach. That said, your control designer solution most probably doesn't need to have extra communication code to exchange data between the server and the client process. As long as you do not change the type the original editor is handling, the Designer should be able to handle the necessary communication behind the covers. But: That communication is still required to happen, and the modified (inherited) editor types still need to be run in the context of Visual Studio - which at this time is either the 32-Bit Framework process (VS 2019) or the 64-bit Framework process (VS 2022).

What will be the solution structure in this case? I mean it in terms of https://github.com/KlausLoeffelmann/NetControlDesigners/pull/9 - we need other more light template for this?
About editors...
ColorEditor and FileNameEditor are from System.Windows.Forms.Design namespace that simple unavailable when using  Microsoft.WinForms.Designer.SDK. Ok got it - we need to put them in .net framework. What about System.Drawing.Design.UITypeEditor (it's available)? The same technique?
What about System.ComponentModel.Design.CollectionEditor? The same procedure or we need to replace it with Microsoft.DotNet.DesignTools.Editors.CollectionEditor (even though I know it won't work)? Or something different?
We defiantly need an examples for these cases too.

I think 99% of editors have some classes reference from our control. And how we can use them in .net472 project (our control is .Net6+)? And this is not single property value that's we transferring with help of Protocol project. This is
lots of references to control's classes...

That's exactly the problem the SDK solves. It's what the whole effort is all about!
You have to - simplified - remote control the 4.7.2 UI from the .NET process.
If you take a look at the template demo, it also isn't able to access the property directly which the Type Editor for. That's why we 're sending requests to change the value to server, which then does it.

The same procedure or we need to replace it with Microsoft.DotNet.DesignTools.Editors.CollectionEditor (even though I know it won't work)? Or something different?

We need to make it work. We did it with every single collection editor in the WinForms runtime. Those are all part of the Out-Of-Proc Designer now. And yes, that's an additional effort, since you would need to define endpoints in the server for Add, Remove, Edit, and OK.
That will be part of an additional Blog Post next year. But there is a sample for that as well already. It's named Sophisticated Demo in the repo.

So, If I understand you correctly, then this statement is not true:

If you have type editors which are derived from existing type editors (like ColorEditor or FileNameEditor) for editing certain types of values for existing controls in .NET Framework, then you also need the client/server approach. That said, your control designer solution most probably doesn't need to have extra communication code to exchange data between the server and the client process. As long as you do not change the type the original editor is handling, the Designer should be able to handle the necessary communication behind the covers. But: That communication is still required to happen, and the modified (inherited) editor types still need to be run in the context of Visual Studio - which at this time is either the 32-Bit Framework process (VS 2019) or the 64-bit Framework process (VS 2022).

and in this scenario, if we have any reference to original control, we still need to do client/server communication manually?
P.s. I want to make at least one editor to work, and then will look towards CollectionEditor...

So, If I understand you correctly, then this statement is not true. [...]

It is true the way I meant and think I have written it:

You use stock-collection-editors, you don't need to use client-server separation.
You use your own Type Editor for a certain type, and that will be part of a collection (and an editor), you are already having a Client/Server separation (for the certain type), but then a simple collection editor would pick that type automatically up.
If you need however need to change the behavior for collection editors, you have to implement that yourself and most likely need more additional endpoints.

I somehow need totally rewrite it to obtain image by rpc (through json) in onpaint???
Well, the client-side does not know about the chart-control. The chart control is .NET, right? So, if the client-side needs to paint something, it can only paint what it knows. A picture sent back - yes, I guess that would be one approach that would work.

For the collection editors: Let's not get ahead of ourselves, though. We're about to finish the first part (everything BUT modified collection editors) which is covering 80% of the scenarios. And then let's take on the next step.

For the collection editors: Let's not get ahead of ourselves, though. We're about to finish the first part (everything BUT modified collection editors) which is covering 80% of the scenarios. And then let's take on the next step.

Totally agree. And whole my previous post is about single value property editor - not collection editor:

P.s. I want to make at least one editor to work, and then will look towards CollectionEditor...

/cc @KlausLoeffelmann
Please take a look at my previous post when you have time. I have a few ideas with some kind of proxy project (for example on netstandard2.0) for a less time-consuming port of the designer. But for now I'm stuck at a trivial step 😰

I am completely swamped this week to get the blog posts out.
And next week I am physically out-of-office.
Let me try again find some time over the weekend, but I can't promise anything. (Maybe Friday morning, let me try to schedule sometime.)
In the meantime - can you send me the link to the branch you're working in? Is it still the same branch we had before?

I scheduled some time for Friday morning.

In the meantime - can you send me the link to the branch you're working in? Is it still the same branch we had before?

Thank you @KlausLoeffelmann
I will pull my local branch where all done (in my opinion) and post link here.

Hmm. Just as a very quick idea, because I ran into that before: Can you try to also set the UITypeEditor base class not as a type but as string when you pass it?
I'll try to take a closer look on Friday morning.

Hmm. Just as a very quick idea, because I ran into that before: Can you try to also set the UITypeEditor base class not as a type but as string when you pass it?

I have tried these three variants with no result:
Editor("ImageValueEditor", typeof(UITypeEditor))
Editor("ImageValueEditor", "UITypeEditor")
Editor("ImageValueEditor", "FileNameEditor")

Can you include the namespaces to fully qualify the types?
Does that change anything?
Take a look at the template for guidance.
If that doesn't work, start with a Type Editor that doesn't inherit from an existing one (take the templates). And then modify how you need it until it breaks, so we know where to start.

Can you include the namespaces to fully qualify the types? Does that change anything? Take a look at the template for guidance.
If that doesn't work, start with a Type Editor that doesn't inherit from an existing one (take the templates). And then modify how you need it until it breaks, so we know where to start.

I've already tried everything I can :(
ImageValueEditor : UITypeEditor

doesn't work too :(
The funny thing is that in the test project - Medium - TypeEditor it works, no matter how I try to spoil it - with types and strings and with any namespaces...
Everything is complicated by the fact that you constantly have to restart the studio because of this bug:

I found a very nasty designer bug that cost me a couple hours of madness ))) If you write a new editor, or change something in the client side of the editor - no changes will be visible until the studio is restarted!!! Neither rebuilds nor closing / opening of the project doesn't help - only restart.

it works, no matter how I try to spoil it - with types and strings and with any namespaces...

It definitely shouldn't.
So, I think the problem is around the NuGet package pick-up. Please delete ALL the NuGet packages the get or got created in both repos, and see, if the compiler explains at one point. Make also sure, that in your test app, you only reference that NuGet and nothing else, so we can make sure, that the reference doesn't come from any other spot.

Projects (note I changed the names of the projects on purpose to change the names of the resulting dlls):

Sources:

Only one nuget package:

Result:

OK, I took a look, and experimented a bit myself:

I noticed, the server-part of the NuGet package is missing. I am not sure at this point, if we can have the/a control-lib and designer-server-part merged in one lib, but one way or the other: I would not recommend it, anyway. Folks might later want to ship a version without any SDK dependencies or design-time functionality, so I'd separate this in any case. To try to get this fixed: Could you approach the migration the other way around: Take a generated Solution from the Type Editor template, and copy anything relevant from the chart control in there.
I also messed a bit with the type names. While in the routing-definition and the editor attribute the types need to be stated as strings, the namespaces are indeed not relevant (and - I missed that - that's also not what's done in the template). It might be a different story for potential CodeDom Serializer, but that's not the issue at hand, and we come to that later.
In addition: When I pulled your branch, the NuGet in the test app pointed to the wrong directory, and I had to fix that (just one folder level up, so I changed "." into ".."). Can you double check, if you have set-up the whole package based on the template, that the NuGet package get pulled from the correct folder?
I also checked: When the NuGet is set-up correctly, there is no need to restart VS. What I need to do though, and (@merriemcgaw FYI) that also needs to go in the blog post: I explicitly deleted any build dependencies from the test-app to the Control Designer Library project, so I can decide, when a new NuGet version gets in. Also, we should add a paragraph which would explain, that during development, you should get the latest version ("*") from the just built NuGet package rather than a particular version. It is indeed correct, that the NuGet package does not get replaced, when there is a reference to a fixed version, even if that version gets updated. It's important to tell the test app, to always get the latest version during development. Take a look at the sample app (TileRepeater, dotnet version), which I will update so it reflects the latest changes we did based on recent feedback.

Please note, I'll be OOF this week (I am only here today to get this done, because I promised you! 😸). So let's take a break this week and continue Tuesday  in a week (Nov. 29th).

Thank you for your time @KlausLoeffelmann

I noticed, the server-part of the NuGet package is missing. I am not sure at this point, if we can have the/a control-lib and designer-server-part merged in one lib, but one way or the other: I would not recommend it, anyway. Folks might later want to ship a version without any SDK dependencies or design-time functionality, so I'd separate this in any case.

I totally agree with your here and that's why I did exacly like this:

To try to get this fixed: Could you approach the migration the other way around: Take a generated Solution from the Type Editor template, and copy anything relevant from the chart control in there.

BUT I ran into a huge number of problems because the design part is strongly related to the control itself and it will be very difficult to separate them. Perhaps this can be done through a certain proxy project...
And in order to understand whether this will work, I decided to try the simplest thing first. Especially since your test project works fine without server-part! See screenshots in my previous post. Also if you look at DataVisualization.Package.csproj there is a commented line (I also tried this option - it didn't help):
<_File Include="$(SolutionDir)\src\System.Windows.Forms.DataVisualization\bin\$(Configuration)\$(TargetFrameworkServer)-windows\System.Windows.Forms.DataVisualization.dll" TargetDir="Design/WinForms/Server" />

In addition: When I pulled your branch, the NuGet in the test app pointed to the wrong directory, and I had to fix that (just one folder level up, so I changed "." into ".."). Can you double check, if you have set-up the whole package based on the template, that the NuGet package get pulled from the correct folder?

In my opinion, everything is in order, one point is the current directory 🤷♂

In your projects, everything is exactly the same.

I also checked: When the NuGet is set-up correctly, there is no need to restart VS.

What you mean by correctly? In my tests, I rebuilt the projects, then the nuget package, then updated the package in the test app, then rebuilt that as well (test form is closed of course). I opened the form and saw no changes.. After that, I closed the solution and opened it again - it did not help, and only restart helped.

What I need to do though, and (@merriemcgaw FYI) that also needs to go in the blog post: I explicitly deleted any build dependencies from the test-app to the Control Designer Library project, so I can decide, when a new NuGet version gets in. Also, we should add a paragraph which would explain, that during development, you should get the latest version ("*") from the just built NuGet package rather than a particular version. It is indeed correct, that the NuGet package does not get replaced, when there is a reference to a fixed version, even if that version gets updated. It's important to tell the test app, to always get the latest version during development. Take a look at the sample app (TileRepeater, dotnet version), which I will update so it reflects the latest changes we did based on recent feedback.

I came to the same thoughts :) The only thing is that * reference also does not give 100% result, I had to call nuget.exe restore after building the package...
Currently it's:
<Target Name="CopyPackageD" AfterTargets="Pack" Condition="'$(Configuration)'=='Debug'">
<Copy SourceFiles="$(OutputPath)..\$(PackageId).$(PackageVersion).nupkg"
			DestinationFolder="$(SolutionDir)NuGet\BuildOut\"/>
<Exec Command="nuget.exe restore "$(SolutionDir)DesignerTest\DesignerTest.csproj" -ConfigFile "$(SolutionDir)NuGet.config"" />
</Target>

And package reference is:
<ItemGroup>
  <PackageReference Include="WinForms.DataVisualization.Debug" Version="$(MajorVer).*" />
</ItemGroup>

My bad, by the evening everything was mixed up in my head 😔
Of course, these problems are with the client side.
On the server side:

How can a serializer and a designer in a separate library affect the behavior of the editor?  I would understand if they didn't work, but they just work...
In your test project, everything works fine from a single file.
I tried adding the original dll as a server part - it didn't help.

Stunned, but at some point it worked!!!
Not working: https://github.com/kirsan31/winforms-datavisualization/tree/DesignerNotWork
Working: https://github.com/kirsan31/winforms-datavisualization/tree/DesignerTest
The only change is rename of main assembly from System.Windows.Forms.DataVisualization to WinForms.DataVisualization.
After this change we have side affect (two chart controls on the toolbox):

But with System.Windows.Forms.DataVisualization assembly name we hade only one control on the toolbox:

As I understand this one from project (not from nuget). This is exactly why designer not working!!!
And this is clearly a bug / flaw in the designer :(

@KlausLoeffelmann are you back? :) I've spend some time (lots :)))) on porting editors and I think now I can give a more concrete feedback.
I want to note that my task was to transfer the editors to the client library and get the maximum out of them without using cross-processor interaction and all this ViewModel staff.
Designer bugs.

We have serious bug with NuGet package pick-up due to assembly name (I think when this name crossing with .net framework) - see my two (mostly second) previous posts with explanations.
Some times ToolBox not populated with Nuget control version (the control from project is always here).

Even when we have not see control from nuget, when we drug project control version - all client/server staff are working, so it's only ToolBox problem.
Need to restart studio (sometimes many times) until it shows up.

Not a bug but very annoying. The client side of the control designer is loading and caсhing on first opening of the test project form in the designer. After that if you have modified client side, you need to restart VS to see this changes. I have test project with * reference to package and more of it with nuget restore before build - this not help. Designer populate and cache ToolBox only on first load (even close and reopen solution not helps). May be add some way to reload / repopulate ToolBox manually? It's also helps with previous bug :)

SDK questions / suggestions.

We have two (may be more?) internal classes: Microsoft.DotNet.DesignTools.Client.Proxies.ProxyPropertyDescriptor and Microsoft.DotNet.DesignTools.Protocol.PropertyData. It would very useful to make them public, I will explain with a concrete example from chart control (I think it's all clear from comments and code). The code from protected override void ShowHelp(). GetPropValue is my extension method to get property value with reflection:

GridItem item = grid.SelectedGridItem;
// Original code:
//_helpTopic = item.PropertyDescriptor.ComponentType.ToString() + "." + item.PropertyDescriptor.Name;

// We have a proxy object (Microsoft.DotNet.DesignTools.Client.Proxies.ProxyPropertyDescriptor) here as PropertyDescriptor.
// So to get real type we need get PropertyData (Microsoft.DotNet.DesignTools.Protocol.PropertyData) from PropertyDescriptor and then ComponentType from it.
// Because Microsoft.DotNet.DesignTools.Client.Proxies.ProxyPropertyDescriptor and Microsoft.DotNet.DesignTools.Protocol.PropertyData are internal we need to use reflection...
if (item.PropertyDescriptor.GetPropValue("PropertyData")?.GetPropValue("ComponentType") is Microsoft.DotNet.DesignTools.Protocol.Types.TypeIdentity typeIdentity)
    _helpTopic = typeIdentity.TypeName + "." + item.PropertyDescriptor.Name;

In Microsoft.DotNet.DesignTools.Client.Editors.CollectionEditor we have two private classes: DefaultCollectionForm and DefaultViewModel. I think it would helpful to make them public with ability to extend. This should make minor modifications to the default behavior easier. I find it very costly due to minimal modification to make your own dialog like in your BaseUI\DesignableCollectionEditor example.
Microsoft.DotNet.DesignTools.Client.Proxies.EnumProxy class have property Value with type of uint 🙄 Why uint? The default for enum is int🤷♂  But the most important is what to do with enums that derived from long / ulong?

Questions.
With single editors +- all clear.
With simple collections editors +- same with hope on point 2. in previous section.
The main problem now is collection editor with many different classes in it. For this purpose in old CollectionEditor we have:
protected virtual Type[] CreateNewItemTypes ();

If we override it, we will have NewItemTypes return our types and UI changed like this:

In new CollectionEditor we have no CreateNewItemTypes () at all, but we have NewItemTypes 🤔
How to achieve this functionality with new designer? And this again crossing with point 2. from previous section...
For the chart control this is main question for now. AnnotationCollectionEditor is the only one editor of such type  and it simple can't add elements because base (editing) type is abstract...
P.s. Can you some how ping some one from VS team? I have very specific bug with VS on my laptop: https://developercommunity.visualstudio.com/t/Net-local-variables-not-captured-by-deb/10216016 - local variables not captured by debugger at any projects any more :( I tried everything I could find on the Internet and came up with it myself - nothing helps. I really don't know what to do 😭😭😭
Thanks.

@KlausLoeffelmann
Done:
https://github.com/dotnet/winforms/issues/8348
https://github.com/dotnet/winforms/issues/8360
https://github.com/microsoft/winforms-designer-extensibility/issues/4
https://github.com/microsoft/winforms-designer-extensibility/issues/5
https://github.com/microsoft/winforms-designer-extensibility/issues/6


Update CHANGELOG format and parsing

Just added all of Dane's suggestions

Waiting on Issue: https://github.com/cyberark/summon-s3/issues/11


Set syslog facility to mail

Setting syslog facility to mail will redirect log output to /var/log/mail.log instead of the /var/log/syslog file

hi @kiekerjan, this looks fine to me, thanks!
with this setting, mail logging indeed goes to /var/log/mail.log. with all log levels, but that's expected mox doesn't do explicit syslog and syslog doesn't know the levels.
logging still also goes to /var/log/syslog on my machines. i may have changed the logging settings, or it may be the default. admins can change such settings themselves.

You're right of course, where the log ends up depends on the configuration of syslog. This only tells syslog that the log facility is mail.


Sort Out Configs

I want to allow environment variables to set the appropriate endpoints for things. Mainly so the frontend can connect to the backend.
I also want a initial.json file which can be loaded with all the initial records needed. These should then be able to be used for the other CRUD opperations.

Half this is done. Just need environment vars now


Remove go get for vet

Changes Unknown when pulling a7a7eb84786ea88fdf2a7d6900ac43570fd5ebca on travis-config-fix into ** on master**.


kqueue: Ignore EPIPE coming out of kevent

This commit updates mio to ignore EPIPE coming out of kevent. It
turns out that older versions of OSX (10.10 and 10.11 have been
confirmed) will return an EPIPE when registering one half of a pipe
where the other half has been closed. On other platforms this is an ok
operation which just returns that the pipe is readable/writable (to
return an error/eof), so this brings the OSX behavior in line by
ignoring the error and moving to the next event.
Closes #582

Closed by #584


Carousel - Error Pulling Images

Reported that the Slider component can't access images from Gatsby GraphQL queries. Need to validate this error and see how to fix it.

Jenny was working on this in #200


This Logic App run instance will not load. Displays spinners only

Describe the Bug with repro steps
This Logic App run instance will not load. Displays spinners only
What type of Logic App Is this happening in?
Consumption (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
Chrome
Additional context
No response
AB#25823460

Do you see any console errors or failed network requests? With just the description here there isn't much we're going to be able to do.


Some errors

When I use '-gff' the error is reported as follows：
File "/dev/hdd/soft/CentIERv3.0/CentIERv3.0.py", line 639, in
if gff:gff_gene_number=ex_gff(gff)
^^^^^^^^^^^
File "/dev/hdd/soft/CentIERv3.0/CentIERv3.0.py", line 141, in ex_gff
gff_gene_number[j]={}
^^^^^^^^^^^^^^^
NameError: name 'gff_gene_number' is not defined
When I don't use '-gff' I get the following error, but the result is produced：
File "/dev/hdd/soft/CentIERv3.0/CentIERv3.0.py", line 1078, in
else:s1,e1,seq1=st_range[ID]
NameError: name 'st_range' is not defined
Based on the code that had results produced, I added '-matrix1/2' and '-bed1/2' but again reported the following error:
Traceback (most recent call last):
File "/dev/hdd/soft/CentIERv3.0/CentIERv3.0.py", line 647, in
hic_dir = findPosition(gap, finer_diag, bed1, bed2)#hic_dir是收集hic信号的
File "/dev/hdd/soft/CentIERv3.0/CentIERv3.0.py", line 222, in findPosition
Lstart = int(bed2[(bed2["chr"] == chr) & (bed2["start"]==start)]["id"].iloc[0])
File "/home/anaconda3/envs/EDTA2/lib/python3.9/site-packages/pandas/core/indexing.py", line 879, in getitem
return self._getitem_axis(maybe_callable, axis=axis)
File "/home/anaconda3/envs/EDTA2/lib/python3.9/site-packages/pandas/core/indexing.py", line 1496, in _getitem_axis
self._validate_integer(key, axis)
File "/home/anaconda3/envs/EDTA2/lib/python3.9/site-packages/pandas/core/indexing.py", line 1437, in _validate_integer
raise IndexError("single positional indexer is out-of-bounds")
IndexError: single positional indexer is out-of-bounds

Ok, I will check the code in a few days. Please ensure that the required tools and computer environment are correctly installed
在 2024-08-15 11:57:16，"jinqiu wang" @.***> 写道：
When I use '-gff' the error is reported as follows：
File "/dev/hdd/soft/CentIERv3.0/CentIERv3.0.py", line 639, in
if gff:gff_gene_number=ex_gff(gff)
^^^^^^^^^^^
File "/dev/hdd/soft/CentIERv3.0/CentIERv3.0.py", line 141, in ex_gff
gff_gene_number[j]={}
^^^^^^^^^^^^^^^
NameError: name 'gff_gene_number' is not defined
When I don't use '-gff' I get the following error, but the result is produced：
File "/dev/hdd/soft/CentIERv3.0/CentIERv3.0.py", line 1078, in
else:s1,e1,seq1=st_range[ID]
NameError: name 'st_range' is not defined
Based on the code that had results produced, I added '-matrix1/2' and '-bed1/2' but again reported the following error:
Traceback (most recent call last):
File "/dev/hdd/soft/CentIERv3.0/CentIERv3.0.py", line 647, in
hic_dir = findPosition(gap, finer_diag, bed1, bed2)#hic_dir是收集hic信号的
File "/dev/hdd/soft/CentIERv3.0/CentIERv3.0.py", line 222, in findPosition
Lstart = int(bed2[(bed2["chr"] == chr) & (bed2["start"]==start)]["id"].iloc[0])
File "/home/anaconda3/envs/EDTA2/lib/python3.9/site-packages/pandas/core/indexing.py", line 879, in getitem
return self._getitem_axis(maybe_callable, axis=axis)
File "/home/anaconda3/envs/EDTA2/lib/python3.9/site-packages/pandas/core/indexing.py", line 1496, in _getitem_axis
self._validate_integer(key, axis)
File "/home/anaconda3/envs/EDTA2/lib/python3.9/site-packages/pandas/core/indexing.py", line 1437, in _validate_integer
raise IndexError("single positional indexer is out-of-bounds")
IndexError: single positional indexer is out-of-bounds
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


redirectOn: 'no prefix' does not redirect on the root URL

Environment
(Here's Stackblitz' environment information)

Operating System: Linux
Node Version:     v16.14.2
Nuxt Version:     3.5.2
Nitro Version:    2.4.1
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      ssr, components, modules, i18n
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/nuxt-starter-2yxmzd
Describe the bug
I added strategy: 'prefix' and redirectOn: 'no prefix' to nuxt.config.ts.
nuxt.config.ts
export default defineNuxtConfig({
  // ...
  i18n: {
    // ...
    strategy: 'prefix',
    // ...
    detectBrowserLanguage: {
      useCookie: true,
      cookieSecure: true,
      alwaysRedirect: true,
      fallbackLocale: 'en',
      redirectOn: 'no prefix',
    },
  },
});

If I understand correctly, with this config, if you open / (root URL), it should return 302 and redirect to /en or /ja. (Depending on your Accept-Language)
However, when you open / (root URL), it returns 404.
Additional context
No response
Logs
No response

This issue might be related to #2131.

I guess the following code causes this issue:
https://github.com/nuxt-modules/i18n/blob/8dc25cbd88212563b5f9709740246a4915b8462f/src/runtime/utils.ts#L297
isI18nRouteDefined(route) always returns false because route.matched[0]?.meta.nuxtI18n is always undefined (see isI18nRouteDefined()) on my end.
Therefore, detectRedirect() returns redirectPath (=== empty string ('')) and the following redirection process is not executed.
I'm stuck here because I'm unsure how to make route.matched[0]?.meta.nuxtI18n a non-undefined value...

Thanks!
You can workaround with dedefaultLocale option.
BTW, docs recommend that it is specified default locale
https://v8.i18n.nuxtjs.org/guide/routing-strategies#configuration

@kazupon Thanks for the information.
However, the app still does not work properly by setting defaultLocale.
In the following repro, I set defaultLocale: "en".
https://stackblitz.com/edit/nuxt-starter-aj1bpj
However, / returns 200 and shows the English content, while it should return 302 to redirect to /en.

@phanect Suffering the same issue.

I seem that this issue is degraded by https://github.com/nuxt-modules/i18n/pull/1902
I'll try to revered that PR.

@kazupon Thanks so much for working on this! I confirmed this issue is partially fixed in v8.0.0-beta.13.
Now if you open https://example.com/, it automatically redirects to https://example.com/en.
However, it does not redirect to https://example.com/ja when you open the root page with Accept-Language: ja. It always redirects to https://example.com/en.
Here's the repro.
https://github.com/phanect/repro-nuxt-i18n-redirection
Note: This sample code is available on Stackblitz too, but Stackblitz seems to have a bug as of now and it didn't work as expected. Please clone the repro and run it on your local machine.
Here's step to reproduce:

Run npm run dev at the project root of the repro.
Open your browser settings to set your primary language "Japanese" so that the Accept-Language header would be ja. This issue happens when Accept-Language is something like ja,en;q=0.9,en-US;q=0.8 too.
Open any page under http://localhost:3000/, open the browser developer tools (Chrome: Application panel, Firefox: Storage panel), and remove i18n_redirected cookie.
Open http://localhost:3000/ (root page)

Expected: The browser redirects you to http://localhost:3000/ja
Actual: The browser redirects you to http://localhost:3000/en
Let me know if you prefer to close this issue and open another issue for Accept-Language bug.


i18n(fr): remove jsconfig mentions in French guides and references

Description (required)

Remove all mentions of jsconfig in French guides and references (see #8818)

Note: src/content/docs/fr/guides/upgrade-to/v1.mdx is not included since it does not exist yet. I'll update the translation in #8772.

Related issues & labels (optional)

Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

fr
guides/imports.mdx
Localization changed, will be marked as complete.

fr
guides/typescript.mdx
Localization changed, will be marked as complete.

fr
reference/cli-reference.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Larger dataset for training control-net

Dear ControlNet team,
We know the initial intention of ControlNet is to use small dataset to finetune the original model. However, if the dataset of training ControlNet is larger than that of training the original model, is there any changes I have to make comparing to the classical training process of ControlNet? Thanks a lot !!!
Kangning.

The original Stable Diffusion 1.5 base model was trained on 5B+ images. You want to train a control net on more than 5B images?
You might run into an overfitting problem, see here:
Uncanny Faces tutorial: "We trained the model for 3 epochs (this means that the batch of 100K images were shown to the model 3 times) and a batch size of 4 (each step shows 4 images to the model). This turned out to be excessive and overfit (so it forgot concepts that diverge a bit of a real face, so for example "shrek" or "a cat" in the prompt would not make a shrek or a cat but rather a person, and also started to ignore styles)."
Although the original canny model was trained 3M images https://arxiv.org/abs/2302.05543 and than training was resumed in ControlNet 1.1 https://github.com/lllyasviel/ControlNet-v1-1-nightly#controlnet-11-canny without running into overfitting problems which I don't understand. Maybe they dropped enough prompts and randomized the canndy edge parameters enough.
@lllyasviel

https://arxiv.org/abs/2302.05543v1 (note V1)
"In this case, since the risk of over-fitting is relatively low, we can first train ControlNets for a large enough number of iterations (usually more than 50k steps), and then unlock all weights of the Stable Diffusion and jointly train the entire model as a whole. This would lead to a more problem-specific model."


Minio chart deprecated

Expected Behaviour
Based on the arkade documentation, installing minio application will invoke
ark install minio
and the behaviour would be installing minio in the default namespace.
Current Behaviour

Invoking ark install minio led to this issue
Node architecture: "amd64"
Access Key not provided, one will be generated for you
Secret Key not provided, one will be generated for you
Using Kubeconfig: /root/.kube/config
[Warning] unable to create namespace default, may already exist: Error from server (AlreadyExists): namespaces "default" already exists
Client: x86_64, Linux
2024/01/07 14:41:16 User dir established as: /root/.arkade/
Error: looks like "https://helm.min.io/" is not a valid chart repository or cannot be reached: Get "https://helm.min.io/index.yaml": dial tcp: lookup helm.min.io on xxxxx: no such host
Error: looks like "https://helm.min.io/" is not a valid chart repository or cannot be reached: Get "https://helm.min.io/index.yaml": dial tcp: lookup helm.min.io on xxxxx:53: no such host

Error: exit code 1

I tried to install it manually using simple helm command didn't work either
helm repo add minio https://helm.min.io/
helm repo add minio https://helm.min.io/
Error: looks like "https://helm.min.io/" is not a valid chart repository or cannot be reached: Get "https://helm.min.io/index.yaml": dial tcp: lookup helm.min.io on <IP_ADDRESS>:53: no such host

Possible Solution

Updated the minio chart repository to point to https://charts.bitnami.com/bitnami
Builded the arkade binary again and installed the minio app.
go build
./arkade install minio
./arkade install minio
Node architecture: "amd64"
Access Key not provided, one will be generated for you
Secret Key not provided, one will be generated for you
Using Kubeconfig: /root/.kube/config
[Warning] unable to create namespace default, may already exist: Error from server (AlreadyExists): namespaces "default" already exists
Client: x86_64, Linux
2024/01/07 14:44:11 User dir established as: /root/.arkade/
"minio" has been added to your repositories

Hang tight while we grab the latest from your chart repositories...
...Unable to get an update from the "truecharts" chart repository (https://charts.truecharts.org/):
        Get "https://charts.truecharts.org/index.yaml": tls: failed to verify certificate: x509: certificate is valid for *.github.io, github.io, *.github.com, github.com, www.github.com, *.githubusercontent.com, githubusercontent.com, not charts.truecharts.org
...Successfully got an update from the "metallb" chart repository
...Successfully got an update from the "portainer" chart repository
...Successfully got an update from the "trivy-operator" chart repository
...Successfully got an update from the "openebs" chart repository
...Successfully got an update from the "ingress-nginx" chart repository
...Successfully got an update from the "aqua" chart repository
...Successfully got an update from the "litmuschaos" chart repository
...Successfully got an update from the "vault-raft-snapshot-agent" chart repository
...Successfully got an update from the "klustair" chart repository
...Successfully got an update from the "harbor" chart repository
...Successfully got an update from the "netdata" chart repository
...Successfully got an update from the "cert-manager" chart repository
...Successfully got an update from the "signoz" chart repository
...Successfully got an update from the "openfaas" chart repository
...Successfully got an update from the "stakater" chart repository
...Successfully got an update from the "nicholaswilde" chart repository
...Successfully got an update from the "gabe565" chart repository
...Successfully got an update from the "grafana" chart repository
...Successfully got an update from the "prometheus-community" chart repository
...Successfully got an update from the "minio" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈

VALUES values.yaml
Command: /root/.arkade/bin/helm [upgrade --install minio minio/minio --namespace default --values /tmp/charts/minio/values.yaml --set secretKey=Dmn16/OygKW2yc6+d3QKm6jNUt9aewE7N++r+9V2 --set persistence.enabled=false --set accessKey=03yIAJ2484jPw4NaZ202]
Release "minio" has been upgraded. Happy Helming!
NAME: minio
LAST DEPLOYED: Sun Jan  7 14:44:18 2024
NAMESPACE: default
STATUS: deployed
REVISION: 2
TEST SUITE: None
NOTES:
CHART NAME: minio
CHART VERSION: 12.12.2
APP VERSION: 2023.12.23

** Please be patient while the chart is being deployed **

MinIO® can be accessed via port  on the following DNS name from within your cluster:

   minio.default.svc.cluster.local

To get your credentials run:

   export ROOT_USER=$(kubectl get secret --namespace default minio -o jsonpath="{.data.root-user}" | base64 -d)
   export ROOT_PASSWORD=$(kubectl get secret --namespace default minio -o jsonpath="{.data.root-password}" | base64 -d)

To connect to your MinIO® server using a client:

- Run a MinIO® Client pod and append the desired command (e.g. 'admin info'):

   kubectl run --namespace default minio-client \
     --rm --tty -i --restart='Never' \
     --env MINIO_SERVER_ROOT_USER=$ROOT_USER \
     --env MINIO_SERVER_ROOT_PASSWORD=$ROOT_PASSWORD \
     --env MINIO_SERVER_HOST=minio \
     --image docker.io/bitnami/minio-client:2023.12.23-debian-11-r1 -- admin info minio

To access the MinIO® web UI:

- Get the MinIO® URL:

   echo "MinIO® web URL: http://<IP_ADDRESS>:9001/minio"
   kubectl port-forward --namespace default svc/minio 9001:9001
=======================================================================
= Minio has been installed.                                           =
=======================================================================

# Forward the minio port to your machine
kubectl port-forward -n default svc/minio 9000:9000 &

# Get the access and secret key to gain access to minio
ACCESSKEY=$(kubectl get secret -n default minio -o jsonpath="{.data.accesskey}" | base64 --decode; echo)
SECRETKEY=$(kubectl get secret -n default minio -o jsonpath="{.data.secretkey}" | base64 --decode; echo)

# Get the Minio Client
arkade get mc

# Add a host
mc config host add minio http://<IP_ADDRESS>:9000 $ACCESSKEY $SECRETKEY

# List buckets
mc ls minio

# Find out more at: https://min.io

🚀 Speed up GitHub Actions/GitLab CI + reduce costs: https://actuated.dev

Steps to Reproduce (for bugs)

ark install minio

Context

Your Environment

What Kubernetes distribution are you using?

kubectl v1.28.4

Operating System and version (e.g. Linux, Windows, MacOS):

Linux xxxxx <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Thu Oct 5 21:02:42 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

PRETTY_NAME="Ubuntu 22.04.3 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.3 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

What arkade version is this?

arkade Version: 0.10.20

@alexellis can we speed up this fix?

Is there no upstream chart?
https://min.io/docs/minio/kubernetes/upstream/operations/install-deploy-manage/deploy-operator-helm.html
This is for the operator, but do they have an alternative for a more stand-alone installation, or is bitnami the only option for that now?

Given the changes Minio has made (we don't maintain and are not affiliated with Minio Inc) - if someone wants to contribute an update to arkade to switch to Bitnami's distribution of Minio I am fine with that.
Otherwise, feel free to install Bitnami's chart manually without arkade: https://github.com/bitnami/charts/tree/main/bitnami/minio

@nitishkumar71 do you have time to try and convert this over to the Bitnami chart? There may be different parameters to consider vs the older chart which apparently has been deleted now so have a think about how to map things and whether they exist in the new chart.

I am updating a course on arkade for the Linux Foundation and ran into this very issue. I am looking for clarification on when or whether this issue might be resolved.

I am updating a course on arkade for the Linux Foundation and ran into this very issue. I am looking for clarification on when or whether this issue might be resolved.

I would start looking into this and will try to finish asap.

Hi @eeganlf could you try out the change from @nitishkumar71 ?

@alexellis works great, thanks!

Glad to hear it @eeganlf

/lock: resolved


⚠ Jenkins Plugins Artifactory has degraded performance

In 04fcc24, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1082 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 0412e76 after 25 minutes.


Confluence: Fix additionalHosts

Previously the additionalHosts were not rendered in the range loop.
Pull request description
Allows the user to set hostAliases with the additionalHosts value. This did not work previously and now works.
Checklist

[ x ] I have added unit tests
[x] I have applied the change to all applicable products
[ ] I have added the change description to the changelog.md and Chart.yaml files

Hi
Can this one get merged and release please, we're switching to Data Center very soon and need to have the ability to run both Syncrony and Lucene, currently with the way the helm is set up we can't run both at the same time.
thanks

@SLetchSQ, could you please elaborate what is the use case you are trying to get working? By Lucene, do you mean separate Lucene instances outside of Confluence?

@l0wl3vel, thanks for the fix!
I have just fixed up the unit tests & added one java test for the change. Can you please accept the CLA and we are ready to merge, thanks again!

Internal tests are passing as well.

@l0wl3vel any chance you can please sign the CLA so we can continue with the merge? It is currently the only missing piece.
Thank you

Hi, sorry for the holdup. I am currently waiting on corporate cla from my employer. I will look into it.

Hi
Can this one get merged and release please, we're switching to Data Center very soon and need to have the ability to run both Syncrony and Lucene, currently with the way the helm is set up we can't run both at the same time.
thanks

@SLetchSQ, could you please elaborate what is the use case you are trying to get working? By Lucene, do you mean separate Lucene instances outside of Confluence?

Hi, yes, raised with Atlassian support and they acknowledged it as a bug, funny thing is this isn't merged but 1.3.0 is now out and magically both work so 🤷♂


Reduce callers of createEditorInput when not needed (#121098)

Part of #121098

From what I'm seeing here it looks like you're putting the options in the resource input you're passing in. I believe the options need to be separate from the input so you would want openEditor({resource: uri }, options, group)

@lramos15 the idea is to explicitly end up in this method overload that does not require to pass in any editor input. My understanding is that the override works fine then:
https://github.com/microsoft/vscode/blob/7164efa38e554e45a17437c4171062ea79c56cc8/src/vs/workbench/services/editor/common/editorService.ts#L183-L183


Gradient not applying correctly

Seems like the gradient is not applying correctly.
Instead of applying the 100% offset to the end of the circle(100%) it seems to be applied at 50% and then the colors repeat in inverse for the other half:
For example green is applied to 0% orange to 50% and red to 100%.

Below you can see that red is applied to the 50% and then the colors repeat from 50% to 100% in inverse

Hello @geobotsar81
i think, what are you trying to achieve is the green-orange-red gradient to follow along with the progress line, this could be possibly with the conical gradient (see #107 ).
What you observe is a linear gradient from bottom to top and this is the currently available behavior of SVG gradients in modern browsers. It becomes more clear with thicker lines like in this example. So far I haven't found a simple and elegant way to implement canonical gradients. I am open for any suggestions.
If you want to communicate the progress visually with colors. the work around could be just to change the progress line color depending on the progress value.

Thanks, that makes sense, wasnt aware of these limitations. Thanks for the suggestion, will give it a go!


do not upcast results to float64 when float32 scalar *+/- float64 array

[x] closes #12388
[x] tests added / passed
[x] passes git diff upstream/master | flake8 --diff
[x] whatsnew entry

can you rebase / update & move whatsnew to 0.18.2

can you rebase / update?

yes, I will try to find some time over the weekend to do this.

[Current coverage][cc-pull] is 84.22%

Merging [#12559][cc-pull] into [master][cc-base-branch] will decrease coverage by <.01%

@@             master     #12559   diff @@
==========================================
  Files           138        138
  Lines         50666      50680    +14
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          42672      42683    +11
- Misses         7994       7997     +3
  Partials          0          0

Powered by Codecov. Last updated by [ae2ca83...2346761][cc-compare]
[cc-base-branch]: https://codecov.io/gh/pydata/pandas/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/pydata/pandas/compare/ae2ca83d31ebc2f95bb4f71b504f454ec399ee41...23467612e159deaf0f4caaf3923e4564b297f6ad
[cc-pull]: https://codecov.io/gh/pydata/pandas/pull/12559?src=pr

@jreback green

actually, let me see if I can increase the code coverage

looks good. some style points. ping when change / green.

@jreback green

thanks @jennolsen84


Fix lint errors

close https://github.com/entando/entando-blueprint/issues/98

I wonder if we should remove this methor or not? https://github.com/entando/entando-blueprint/pull/99/files#diff-36160804c5d2c7b6b6ceff1226bc58bbR36
I basically ignore the lint error but if this method not used we should, definitively, remove it.


Add checkbox to use pre-trained weights

I accidentally implemented this yesterday for my own testing before realising it was part of fixing https://github.com/brainglobe/cellfinder-napari/issues/56!

Codecov Report

Merging #70 (391314a) into main (fee16f4) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main     #70      +/-   ##
========================================
- Coverage   1.11%   1.10%   -0.01%
========================================
  Files          9       9
  Lines        449     453       +4
========================================
  Hits           5       5
- Misses       444     448       +4

Impacted Files
Coverage Δ

cellfinder_napari/detect.py
0.00% <0.00%> (ø)

cellfinder_napari/input_containers.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fee16f4...391314a. Read the comment docs.

I'd suggest we have use_pre_trained_weights == True by default

Done

and leave the text box empty by default?

I'm not sure how to do this - magicgui seems to use Path.home() as the deafult value for Path-like attributes.

I suspect it's not magicgui but rather the fact that the widget values persist that makes you think that?
At least for me, I can set trained_model: Optional[Path] = Path("/") in the dataclass and, after hitting reset defaults that shows "C:/"?

But you're right, it doesn't look like pathlib has a sensible "NonePath" or something like that. Not sure whether Path("/") or Path.home() is better as default there?

I think I'm on the side of leaving it as Path.home() and @paddyroddy fixing or changing it when he tackles #56.
(p.s. sorry for opening this when you were assigned to that issue @paddyroddy, still finding my feet a bit!)

no problem, I hadn't had time to get around to it yet


[docs] Update functions-deploy.md

The pulsar-admin CLI lists --className as the correct option; this change will match the CLI. Also corrects --trigger-value; it should be --triggerValue

@abrahamsangha Would you please handle @wolfstudy 's comments regarding the className and
    --classname
       The function's class name

Hi @abrahamsangha any progress on this PR?

This PR is evidently stale or abandoned. Reopen if this is not so.


Supply an ergonomic way to quantize without taking up full range

Let peak_normalize take in a generic num trait (right now it's an &[f64])
Eg, to convert to the buffer type used by https://developer.mozilla.org/en-US/docs/Web/API/AudioBuffer [-1,  1] f32, we can't use quantize_samples<f32> as that will take up the entire f32 range.
Right now this can be done
make_samples(0.1, 44_100, sine_wave(440.0))
        .iter()
        .map(|f| *f as f32)
        .collect()

Even though this is more optimised, it will be nice to have peak_normalize handle things other than f64s as well.

Probably a non-issue for now.


Update vuln mgmt guidelines

Reference the excellent NCSC principles - https://www.ncsc.gov.uk/collection/vulnerability-management/guidance in our own documentation - https://soc.cyber.wa.gov.au/baselines/vulnerability-management/

https://www.cyber.gov.au/resources-business-and-government/maintaining-devices-and-systems/system-hardening-and-administration/legacy-ict-management/guidance-for-managing-the-risks-of-legacy-ict


Deployment: make it possible to override the pod selector

We moved the selector from component=speaker to app.kubernetes.io/component=controller
Since the pod selector in deploymnet/ daemonset won't work, upgrading to
the new operator will fail. Here we provide a handle to override the
selector, so existing users can upgrade smoothly.

what about here
https://github.com/metallb/metallb-operator/blob/main/test/e2e/metallb/metallb.go#L54
https://github.com/metallb/metallb-operator/blob/main/test/e2e/metallb/metallb.go#L60

what about here https://github.com/metallb/metallb-operator/blob/main/test/e2e/metallb/metallb.go#L54 https://github.com/metallb/metallb-operator/blob/main/test/e2e/metallb/metallb.go#L60

Good catch. That fell off my grep

/LGTM


Feature/custom accessor

Overview
This pull request builds on the work done in #6953 to support custom vertex data as supported in the glTF spec. In the previous work we were able to get accessor index, but didn't implement a method to access the underlying buffer or  to parse it.
This pull request adds the GetAccessor method which allows us to get an accessor by index, and also DRYs up the ConstructMeshPrimitiveAsync code. Additionally, the various GltfConversions methods have been made public to make parsing the buffer easy.
Verification
We've added a new GLB with both the accessor and underlying buffer data along with a Unit test that covers the getting and parsing of the buffer data.

/azp run

@keveleigh thanks for the review and the style updates!

/azp run


BOSH meltdown doesn't mention deployment

cc: @voelzmo
Currently, BOSH reports a meltdown as:
{"id":<redacted>,"parent_id":null,"user":"hm","timestamp":"<redacted>","action":"create",
"object_type":"alert","object_name":"<redacted>","error":null,"task":null,
"deployment":null,"instance":null,
"context_json":"{\"message\":\"We are in meltdown.. Alert @ <redacted>,
severity 1: We are in meltdown.\"}"}

Ideally, we'd like to know for which deployment the meltdown happened. As the thresholds set can be percentages, we might run in a situation that one deployment is in meltdown whereas others are not.

yup, in fact i was just changing prod director to show that as well as a test.

Story: https://www.pivotaltracker.com/story/show/144906309

Addressed by https://github.com/cloudfoundry/bosh/pull/1677

This was addressed in PR #1680, which superseded #1677. This was released in release version 262.


Integrate cordova

I'd ideally like a few things:

Builds add in cordova js library and mimic cordova file structure so they are plug and play. Maybe with a flag.
Can specify a target dir for builds, so you can one step build into your cordova app
Look at ionic/supersonic cordova enhancements. Would be nice to have promisified libraries.

Hi! Would you show the hints on how to migrate reapp starter app to cordova? I copy build/public/ to cordova www/ and do some file move, but iOS emulator show me a blank page!

Hi! I've the same behaviour as @titanjer.

I'm actually prepping the hacker news app for the app store as we speak. It also took me quite a while to get it to work and there are a number of weird things you have to do.
I've been documenting all of that for a blog post, but also want to achieve "plug-and-play" builds where you can just link your build directory to your cordova app and it "just works". So need something like keeping a config.xml in your assets, etc.
All of that should be out in the coming week.

Just hint ;)

Check out the hacker news app in the reapp repos and the build.ios.js

Ha! So silly I am!
I guess the problem was pushstate before and tried to fix that! but it does not work! @@
looking forward your blog! T^T

Here's some more.
My config.xml:
<?xml version='1.0' encoding='utf-8'?>
<widget id="io.cordova.hellocordova" version="0.0.1" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
    <name>rHN</name>
    <description>
        Hacker News Reader, powered by Reapp (www.reapp.io).
    </description>
    <author<EMAIL_ADDRESS>href="http://reapp.io">
        Reapp
    </author>
    <content src="index.html" />
    <access origin="*" />

    <preference name="DisallowOverscroll" value="true" />

    <preference name="SplashScreen" value="splash" />
    <preference name="SplashScreenDelay" value="1000" />

    <platform name="ios">

      <icon<EMAIL_ADDRESS>width="180" height="180" />

      <icon src="www/res/ios/Icon-60.png" width="60" height="60" />
      <icon<EMAIL_ADDRESS>width="120" height="120" />

      <icon src="www/res/ios/Icon-76.png" width="76" height="76" />
      <icon<EMAIL_ADDRESS>width="152" height="152" />

      <icon src="www/res/ios/Icon-Small-40.png" width="40" height="40" />
      <icon<EMAIL_ADDRESS>width="80" height="80" />

      <icon src="www/res/ios/Icon.png" width="57" height="57" />
      <icon<EMAIL_ADDRESS>width="114" height="114" />

      <icon src="www/res/ios/Icon-72.png" width="72" height="72" />
      <icon<EMAIL_ADDRESS>width="144" height="144" />

      <icon src="www/res/ios/Icon-Small.png" width="29" height="29" />
      <icon<EMAIL_ADDRESS>width="58" height="58" />

      <icon src="www/res/ios/Icon-Small-50.png" width="50" height="50" />
      <icon<EMAIL_ADDRESS>width="100" height="100" />

      <splash src="www/res/screen/ios/Default.jpg" width="320" height="480"/>
      <splash<EMAIL_ADDRESS>width="640" height="960"/>
      <splash<EMAIL_ADDRESS>width="640" height="1136"/>
      <splash<EMAIL_ADDRESS>width="750" height="1334"/>
      <splash<EMAIL_ADDRESS>width="1242" height="2208"/>
    </platform>
</widget>

My index.html:
<!DOCTYPE html>

    <title></title>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0">
    <link href="css/main.css" rel="stylesheet" type="text/css">

Notice the delayed loading of the bundle! That's what fixed my problem.

Thx a lot!
I'll try today.

There isn't build.ios.js file in hacker news app repo. So a copied config/build.js to config/build.ios.js and replaced require of ./build.ios.config.js with ./build.ios.config.js. Then I use npm run-script ios. Or should I use reapp build ios instead?

reapp build ios will look for the build.ios.config.js file and run that, so it should "just work" if you run that. Be sure you've updated reapp first and let me know if that works.

I'm on 0.6.5 reapp version. reapp build ios search for ./build.iosconfig.js instead of ./build.ios.config.js. Attempts are still unsuccessful.

And with this configuration I have Error: No template for dependency: TemplateArgumentDependency on reapp build ios

Should be fixed with the new version of reapp. The template dependency I haven't seen, later today I'll run through a fresh install.

Do you use any plugin for cordova? React router doesn't handle location properly within WebView. The application act as if started without a server.

Ah yea you need to build for iOS. Check the config folder of the hacker news app. I believe you could use reapp build ios and that would work. I'm on my mobile now but I can explain better in a bit.
Also be sure you're up to date with reapp-routes.

@olegpopadko could you paste in the output of reapp build ios -d?

I'd update reapp and reapp-routes to last versions from github and everything works like a charm. Awesome! Thanks!

I don't use ./build.ios.config.js because I still have Error: No template for dependency: TemplateArgumentDependency with it.

Hi! I followed the example-cordova-app steps on android device but needs these fixes below!

Modify "/main.css" in index.html to "main.css"
Library axn needs ES6 Promise support, please install cordova PromisePlugin.

@titanjer for promises you can require a promise library and export it as well. The reapp-routes/react-router (default) uses Bluebird already, which we are looking into a better way, but perhaps we could just do it for you.
Either way:
var { Promise } = require('bluebird');
window.Promise = Promise;

See if that works.

This has been pretty much completed. There are initial docs, but we'll add more as we go.


✨ gbridge: increase contrast

It was quite difficult to read small text with contrast of #b0b0b0 text on #404040 background.

Thanks!


Add a plugin store

There was a plugin called Plugin Browser for bunny, but that wasn't a built-in behavior. I'd like to see a built in plugin store in the client.

I'm unsure how much we can realize this because it conflicts with decentralization. At least the default source needs to be environment configurable in source.

it conflicts with decentralization.

You can just have list of repos to gather infos from, with the last in the list being the most preffered source, no?

No, because then we still have a central opinionated list that conflicts with with decentralization.


add missing polyfills and modules

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues,
Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the
changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.

Current dependencies on/for this PR:

main

PR #867

PR #868

PR #869   (this PR)

PR #870

PR #871

This comment was auto-generated by Graphite.


Error with metadata: Multivalued flags are not supported for INFO lines

Hello,
I have ran into an issue with one of the headers in my vcf file, where Adam throws the error: Multivalued flags are not supported for INFO lines: INFO=<ID=SNP,Number=A,Type=Flag,Description="Variant is a SNP">
I saw in VariantContextConverter on line 1272 where the error was getting thrown. Do multivalued flags cause problems? Is there any type of work around this issue? Can we skip the INFO metadata somehow when loading a variant rdd?

@dmmiller612 I don't believe multivalued flags are supported by the VCF specification.  There is a ValidationStringency parameter that you can use, try setting it to ValidationStringency.LENIENT, although I don't know if that allows processing to continue after this kind of error.

Interesting. This annotation came from SnpSift, so I figured it was okay. I can't find exactly what is multivalued about that flag. It just says that the number is alphanumeric, is that the problem?

Number=A is cardinality; it means there is one value for each [A]llele.
There is some discussion about the specification issue here
https://github.com/samtools/hts-specs/pull/123#r66714347
There is some draft doc on our VCF to bdg-formats mapping here, although it still needs cleanup and to find a home somewhere in ADAM docs
https://github.com/heuermh/bdg-formats/blob/docs/docs/source/variants.md

Per discussion between me and @heuermh, this VCF is out of compliance with the spec, and we are not able to patch this issue in ADAM. We'll close this as a won't fix. You should be able to work around this with validation stringency.


Julia interface

Hi and thank you for this package.
Is there any chance you will consider implementing a Julia interface?
We'd love to have access to your stuff!

Hi, it’s something we want to implement at some point, but there is no timeline. We are working towards a factory pattern API, which makes it much easier to expose shogun to other languages. But until that is complete we will probably not have great support for Julia. If you’re interested have a look at shogun-rust. We would probably use a similar approach.

We tried to connect with the Julia community a few times, propose a joint effort in building a swig backend for julia. But we didn't meet that much interest, presumably because the shogun API is not really julia-nic. It also was a few years back and things might have changed since then.
These days probably the approach that @gf712 mentioned above would be preferred over another swig binding ... but manpower is the issue here. If you know someone who is interested in contributing to this, send them in our direction :)

PS I guess you know that MLPack has a julia interface?


chore: add api test structure

Try out this version of the Hiro Wallet - download extension builds.

This PR creates a separate test build path and test directories to run browser automated test against the API network URL https://stacks-node-api-inactive.stacks.co/extended/v1/tx
There are 8 test added to the Test-Api directory that test functionality around

Balance
Adding a network
Sending STX
Funding the account

These test will be improved and updated as my main focus of this PR was making sure the framework was working as expected.
To run the test do the following:
yarn install
yarn build:test-api
yarn test:integration-api
cc/ @Eshwari007 @kyranjamie @fbwoolf @beguene @He1DAr @CharlieC3 @saralab @rafaelcr @zone117x
Next steps will be to put the URL https://stacks-node-api-inactive.stacks.co/extended/v1/tx into an environment variable and have the scripts read the environment variable. This will clear the path for when the API URL is created by Vercel and passed into an environment variable. Our goal is to build a script that can pick that variable up and use it for the test.
https://github.com/hirosystems/stacks-blockchain-api/issues/1002

I have some linting issues I need to address before I can merge this I will work on resolving these.

@timstackblock It might be a good idea for you to install prettier in your IDE, to catch linting issues before sending a PR. Most of the time it even auto-fixes them on save ✨

I have updated the remaining test only the settings test still need modifications.
To point these test against
yarn install
yarn build:test-api
APIEnvVariable=<some_url> yarn test:integration-api


runtime(skill): Update syntax file to fix string escapes

This caught the common case:
"string\""

But not the uncommon case:
"<key>\\"

Thanks. I had some troubles understanding your message, not sure if your change broke the un-common case. After testing your change, I believe what you were trying to say was:
The existing backslash escape in the syntax script allowed for the common case:
"string\""

But did not accomodate for the uncommon case:
"<key>\\"

Let's improve this in the syntax script and also skip a double backslash \\


Remove from whitlist whit x

Bug Report
System Information

Ubuntu 16.04
AMP Release "Hawking Starman" v<IP_ADDRESS>, built 17/01/2019 14:20
Mainline

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Symptoms
https://www.pic-upload.de/view-36330527/Removefromwhitlist.jpg.html
Unfortunately, the cross to remove does not work
Reproduction
I tested it on a fresh install and someone else tested it too

Whitelist management has been removed pending a rewrite. For now its done via console commands.