ios : duplicate symbol 'OBJC_CLASS$_TOActivityCroppedImageProvider'

ios build error after updating from 0.4.10 -> 1.0.0.
i tried all these steps
delete pod lock , remove pods and pod install
remove derived data
clean build
but no luck..
`duplicate symbol 'OBJC_CLASS$_TOActivityCroppedImageProvider' in:
/Users/saraf/Library/Developer/Xcode/DerivedData/UrduReader-hfoqbatrmtjnvkcmihfuiugtxjva/Build/Products/StageDebug-iphonesimulator/CropViewController/libCropViewController.a(TOActivityCroppedImageProvider.o)
/Users/saraf/Library/Developer/Xcode/DerivedData/UrduReader-hfoqbatrmtjnvkcmihfuiugtxjva/Build/Products/StageDebug-iphonesimulator/TOCropViewController/libTOCropViewController.a(TOActivityCroppedImageProvider.o)
duplicate symbol 'OBJC_METACLASS$_TOActivityCroppedImageProvider' in:
.......
.......
ld: 157 duplicate symbols for architecture x86_64`

Please try to refer to the solutions below. Hope it will be useful:

https://github.com/facebook/react-native/issues/27840
https://github.com/facebook/react-native/issues/32016
https://stackoverflow.com/questions/24298144/duplicate-symbols-for-architecture-x86-64-under-xcode

@baronha Thanks for the respons. I tried all these for the past 2 days, but nothing worked.

@baronha Thanks for the respons. I tried all these for the past 2 days, but nothing worked.

Have you tried this yet?
https://stackoverflow.com/questions/52536380/why-do-i-get-ios-linker-errors-with-my-static-libraries

@baronha  I already added the Swift file and headers.
the second link which u shared says add pod 'RNCharts', :path => '../node_modules/react-native-charts-wrapper',
do we have anything like this for CropViewController?

@baronha what should i try? adding what in place of RNCharts?

Wait. I think this error is mainly in your Flipper configuration. Show me your Podfile

`require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'
platform :ios, min_ios_version_supported
prepare_react_native_project!
project 'UrduReader', {
'StageDebug' => :debug,
'StageRelease' => :release,
'Debug' => :debug,
'Release' => :release
}
If you are using a react-native-flipper your iOS build will fail when NO_FLIPPER=1 is set.
because react-native-flipper depends on (FlipperKit,...) that will be excluded

To fix this you can also exclude react-native-flipper using a react-native.config.js
```js
module.exports = {
dependencies: {
...(process.env.NO_FLIPPER ? { 'react-native-flipper': { platforms: { ios: null } } } : {}),
```
flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled(['Debug', 'StageDebug', 'Release', 'StageRelease'], { 'Flipper' => '0.193.0' })
linkage = ENV['USE_FRAMEWORKS']
if linkage != nil
Pod::UI.puts "Configuring Pod with #{linkage}ally linked Frameworks".green
use_frameworks! :linkage => linkage.to_sym
end
target 'UrduReader' do
config = use_native_modules!
Flags change depending on the env values.
flags = get_default_flags()
use_react_native!(
:path => config[:reactNativePath],
# Hermes is now enabled by default. Disable by setting this flag to false.
# Upcoming versions of React Native may rely on get_default_flags(), but
# we make it explicit here to aid in the React Native upgrade process.
:hermes_enabled => flags[:hermes_enabled],
:fabric_enabled => flags[:fabric_enabled],
# Enables Flipper.
#
# Note that if you have use_frameworks! enabled, Flipper will not work and
# you should disable the next line.
:flipper_configuration => flipper_config,
# An absolute path to your application root.
:app_path => "#{Pod::Config.instance.installation_root}/.."
)
pod 'FirebaseCore', :modular_headers => true
pod 'FirebaseCoreInternal', :modular_headers => true
pod 'GoogleUtilities', :modular_headers => true
pod 'RNSVG', :path => '../node_modules/react-native-svg'
pod 'react-native-image-crop-tools', :path => '../node_modules/react-native-image-crop-tools'
pod 'RNGestureHandler', :path => '../node_modules/react-native-gesture-handler'
pod 'react-native-blob-util', :path => '../node_modules/react-native-blob-util'
pod 'react-native-camera', :path => '../node_modules/react-native-camera', :modular_headers => true
target 'UrduReaderTests' do
inherit! :complete
# Pods for testing
end
post_install do |installer|
react_native_post_install(
installer,
# Set mac_catalyst_enabled to true in order to apply patches
# necessary for Mac Catalyst builds
:mac_catalyst_enabled => false
)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
config.build_settings['APPLICATION_EXTENSION_API_ONLY'] = 'No'
end
end
end
target 'share' do
use_react_native!
pod 'RNShareMenu', :path => '../node_modules/react-native-share-menu'
# Manually link packages here to keep your extension bundle size minimal

end
react-native-permissions permission handlers
permissions_path = '../node_modules/react-native-permissions/ios'
pod 'Permission-AppTrackingTransparency', :path => "#{permissions_path}/AppTrackingTransparency/Permission-AppTrackingTransparency.podspec"
pod 'Permission-BluetoothPeripheral', :path => "#{permissions_path}/BluetoothPeripheral/Permission-BluetoothPeripheral.podspec"
pod 'Permission-Calendars', :path => "#{permissions_path}/Calendars/Permission-Calendars.podspec"
pod 'Permission-Camera', :path => "#{permissions_path}/Camera/Permission-Camera.podspec"
pod 'Permission-Contacts', :path => "#{permissions_path}/Contacts/Permission-Contacts.podspec"
pod 'Permission-FaceID', :path => "#{permissions_path}/FaceID/Permission-FaceID.podspec"
pod 'Permission-LocationAlways', :path => "#{permissions_path}/LocationAlways/Permission-LocationAlways.podspec"
pod 'Permission-LocationWhenInUse', :path => "#{permissions_path}/LocationWhenInUse/Permission-LocationWhenInUse.podspec"
pod 'Permission-MediaLibrary', :path => "#{permissions_path}/MediaLibrary/Permission-MediaLibrary.podspec"
pod 'Permission-Microphone', :path => "#{permissions_path}/Microphone/Permission-Microphone.podspec"
pod 'Permission-Motion', :path => "#{permissions_path}/Motion/Permission-Motion.podspec"
pod 'Permission-Notifications', :path => "#{permissions_path}/Notifications/Permission-Notifications.podspec"
pod 'Permission-PhotoLibrary', :path => "#{permissions_path}/PhotoLibrary/Permission-PhotoLibrary.podspec"
pod 'Permission-Reminders', :path => "#{permissions_path}/Reminders/Permission-Reminders.podspec"
pod 'Permission-Siri', :path => "#{permissions_path}/Siri/Permission-Siri.podspec"
pod 'Permission-SpeechRecognition', :path => "#{permissions_path}/SpeechRecognition/Permission-SpeechRecognition.podspec"
pod 'Permission-StoreKit', :path => "#{permissions_path}/StoreKit/Permission-StoreKit.podspec"
end
`
@baronha

@sarafhbk I think if you use this library it is not necessary to use additional pod 'react-native-image-crop-tools', :path => '../node_modules/react-native-image-crop-tools'

@baronha after removing the pod 'react-native-image-crop-tools', :path => '../node_modules/react-native-image-crop-tools'  also the error still remains. i use this package because i need a standalone image cropper for edit image feature.

@baronha after removing the pod 'react-native-image-crop-tools', :path => '../node_modules/react-native-image-crop-tools' also the error still remains. i use this package because i need a standalone image cropper for edit image feature.

standalone image cropper will be deployed in the future in react-native-multiple-image-picker@latest.
Back to the above error. You have deleted Podfile.lock & /Pod and re-installed pod-install

@baronha yes i did that. I think the issue might be both packages use TOActivityCroppedImageProvider in common.

@baronha do u suggest anything? im stuck with this issue for a very long time. everytime i had to change the version for ios and then make builds

this error say that you have duplicate class named like TOActivityCroppedImageProvider, let search and find another lib use this class.

If you does not tend to use this lib that have same class too, just remove it, then problem will gone
If you must do this, so you need to fork one lib as local library then modify the filename


Fix cache issue when depositing a submission

References

Fixes #2577
Fixes #1924

Description
This is a quick fix for the problems mentioned before. It's not resolving the general problem with reRequestOnStale mentioned here
Instructions for Reviewers
Check the mentioned bugs are fixed
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

@atarix83 : I tested this PR today, and I can still reproduce both bugs with this fix in place.   So, I'm not sure what this is doing?
In my setup, I'm running this PR in the UI in production mode (yarn build:prod, yarn serve:ssr).  I then tried to reproduce the bugs as described.  For example, for #1924, I followed the exact steps in its description:

Started a new "Publication" submission (collection selected doesn't matter)
Do not fill out anything on the form.  Immediately click "Deposit"
Wait for validation error to go away.  Immediately click "Deposit" again.
Entire page hangs.  If I watch the backend logs (dspace.log) I can see the UI page is requesting GET /server/api/submission/workspaceitems/[:id] over and over again (in an infinite loop)

I've rebuilt this PR twice in case something was cached.  I'm just not able to figure out how to test this.  Is it working properly for you when running in Production mode?

@tdonohue
i've tested it with SSR because i didn't previously and it works fine. Both bugs are fixed for what i can reproduce.
@artlowel  could you help us to verify if this PR is working for you ?

@atarix83 ; I re-tested quickly today and I can no longer reproduce the odd behavior I was seeing before.  This appears to work, but I want to do some further testing tomorrow before giving it a +1.
Apologies, I have no idea what I must have done wrong before.  Either I failed to pull down the PR code properly, or some sort of caching was getting in the way.  But basic tests on Chrome today show this appears to be working. I'll triple check things tomorrow just to be sure :)


Ensure that we stop the run if we get an uncaught error.

Without this change it was typically necessary for the harness
to timeout before the result would be reported. In some cases
e.g. with explicit_done set, this would never happen, leading
to the appearance of a hang.

This change is

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72909085ee09 to check this doesn't break anything

Better try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=9dabafb321c7c33d283b41d5aeec5f3d91982de2&selectedJob=76110104

@Ms2ger r?

LGTM


Clicking on image thumbnail sometimes returns to map

David says "Right now, when I click one of the images here, it returns me to the map."
I see this sometimes during development, though not consistently.

I haven't noticed this in a while. I'll re-open if it pops up again.


Newly added users not pulling up in SharePoint

Newly added users to EntraAD are not resolving with EntraCP.  Other users are being pulled up without issues.  Any idea where to look as to reason why?  The users are "enabled" and compared user that does pull of compared to newly created user and they appear the same.

Looking at ULS log, when I type the first name it acts like it finds one entry but when I put the period after that it says 0.  SharePoint always says No Results found.

I got this one figured out, they person created the new users was not putting the email address in the primary slot and putting it in the alternate email spot.


The highest the MANIQA score the better?

Hello,
Just to be clear. As highest the MANIQA score the better the perceptual quality of the image?
Thanks.

Yes.

Thank you.


prop-types not assigned via object literal do not work

The Airbnb styleguide recommends putting proptypes in a variable at the top of the file, and then assigning it into propTypes. This causes the linting of propTypes to fail.
The following does not cause any linting errors, despite not including the proptypes validation.
const propTypes = {};

class Test extends React.Component {
  render() {
    return (
      <div>{this.props.name}</div>
    );
  }
}

Test.propTypes = propTypes;

Ideally either the rule should require inline propTypes, or should be able to determine what they are when assigned via a variable.

This pattern is difficult to handle, and currently if you're using it the rule will totally ignore props validation for this component.

@yannickcr a silent failure is the worst possible way to handle it imo - if the rule can't handle it, then can it please raise an error, saying propTypes are unable to be validated?
If the rule can't handle this case, then it's useless, and I'd rather disable it completely than have it give false confidence :-/
(I recognize that if the object is imported or something it'd be difficult, but in this use case it's an object literal elsewhere in the file, so i'd think the info would be in the AST that esprima generates)

@ljharb since the patterns used in the React community are very diversified it is hard (impossible?) to cover everything. And I prefer have certain errors silenced than having some false-positive cases that can break a build because the linter does not understand the used pattern (which does not indicate that the code is not correct). But maybe this can be a configurable setting?
Also about this current issue, after investigation it seems not so difficult to do after all (at least for simple cases like in @kesne example). So i'll try to submit a patch for this :)

Awesome! Our use case at airbnb is just a straight object literal, that's referenced higher in the file, so hopefully that's achievable :-)
For me, a linter is a gate - i consider a pattern the linter doesn't understand to be forbidden, until the linter can be adapted to handle it (by allowing it or recognizing it). An option to enable this behavior would be great too!

Thanks, this is excellent! Please let me know when it's released :-D

Looks like this was out in 3.13.0 2 days ago. Thanks!

Right, it was released in v3.13.0, sorry for not having informed you earlier.


Can't run gremlins in drives different from temp directory

🐞Bug Report
Bug Description
When the system temp directory's drive is not the same as the current project's drive, gremlins unleash fails to run
To Reproduce
Steps to reproduce the behavior:

Create a project on another drive that is different from the one in the TEMP(C:) variable
Execute gremlins unleash on said project(D:) that happens to be in another drive
See terminal error with panic: error, this is temporary

Console Log
Starting...
Gathering coverage... go: no module dependencies to download
done in 1.4549877s
Executing mutation testing on covered mutants...
panic: error, this is temporary

goroutine 8 [running]:
github.com/go-gremlins/gremlins/pkg/mutator.(*Mutator).executeTests(0xc000156480, {0x739190, 0xc00005a680})
        /go/pkg/mod/github.com/go-gremlins/gremlins@v0.2.2/pkg/mutator/mutator.go:208 +0x88e
github.com/go-gremlins/gremlins/pkg/mutator.(*Mutator).Run(0xc000156480, {0x739190, 0xc00005a680})
        /go/pkg/mod/github.com/go-gremlins/gremlins@v0.2.2/pkg/mutator/mutator.go:147 +0xfb
github.com/go-gremlins/gremlins/cmd.run({0x739190, 0xc00005a680}, {0xc00001f700, 0x35}, {0x6936d0, 0x1})
        /go/pkg/mod/github.com/go-gremlins/gremlins@v0.2.2/cmd/unleash.go:155 +0x46c
github.com/go-gremlins/gremlins/cmd.runUnleash.func1.1({0x739190?, 0xc00005a680?})
        /go/pkg/mod/github.com/go-gremlins/gremlins@v0.2.2/cmd/unleash.go:104 +0x78
github.com/go-gremlins/gremlins/cmd.runWithCancel({0x739190?, 0xc00005a4c0}, 0x0?, 0xc00005a640, 0xc00004fa60)
        /go/pkg/mod/github.com/go-gremlins/gremlins@v0.2.2/cmd/unleash.go:128 +0xd2
created by github.com/go-gremlins/gremlins/cmd.runUnleash.func1
        /go/pkg/mod/github.com/go-gremlins/gremlins@v0.2.2/cmd/unleash.go:103 +0x43c

Found behaviour
Received an error panic: error, this is temporary
Expected behaviour
Gremlins should be able to work with different drives
Workaround
Set your TEMP variable to one which matches your project directory's drive letter. In this case set tmp=D:/tmp will do the trick
Operating System

OS: Windows 10
Version Gremlins 0.2.2

Additional Context
I have also created a custom build which includes error message into the panic. That gave me some more clue on what actually went wrong, I found the actual error to be The system cannot move the file to a different disk drive. and let me discover a workaround for it.

Console Log
Starting...
Gathering coverage... go: no module dependencies to download
done in 1.4664947s
Executing mutation testing on covered mutants...
panic: error, this is temporary: link D:\...\LICENSE C:\...\Temp\gremlins-2167308290\wd-1166897977\LICENSE: The system cannot move the file to a different disk drive.

While it's true I am using a custom build here for debugging, I have verified that both the error and workaround can be replicated on the official build.

Hi @Thunder33345, thanks for the bug report.
We faced the same issue when we worked on making Gremlins run in a Docker container. So, we have a clue on how to fix this, but we have to do it properly.
Since there is a workaround and the next minor is around the corner, I would plan this fix for v0.3 rather than a hotfix version on v0.2. Also, it'd be wise to first merge PR #127.
@giose86 I think we have two options here:

Completely abandon the hardlink approach and just make copies
Provide a flag to force "docker mode" even if not in a Docker container (changing name)

I think the first solution is the proper one, but I'd first do some benchmarks to se if and how much performance we loose. If it is too much, we can go with solution 2.
Also, let's not forget to fix that stupid temporary panic I left in the code! (sorry for that)

@k3rn31 let me try the first one solution by collecting some performance data. The second one is already there, more or less, if I go too long we can implement the latter by adding the flag you said :)

@giose86 if first approach works, we can optimise the mutations application by removing the removal of the file (to do after #127 merge).

Hello there, just checking this out after seeing it showcased in discord!
What about a fallback strategy? When it detect that it's not possible to make a hard link, just fallback to copying instead.
Or have a way to specify temp directory for gremlins to use (so i could just specify /tmp/) and it would make it, and clean up after use.

I think the fallback is a great idea.
Let's first see if switching to copying has impact on the performance. If the timings are comparable, it would be simpler to just copy.
If, instead, the loss of performance is significant, both falling back or specifying the temp dir are excellent solutions. We can even implement both of them.

Since I want to release v0.3 so that it can be tested, I'm moving this one to the next minor (v0.4). Cheers.

Hi guys, this is what i got by replacing the hard link with the copy:
PC info
goos: linux
goarch: amd64
cpu: Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
Benchstat
name          old time/op  new time/op  delta
DealerGet-12   9.33s ± 0%  17.75s ± 0%   ~     (p=1.000 n=1+1)
Running gremlins on gremlins itself:
Mutation testing completed in 20 seconds 108 milliseconds
Killed: 116, Lived: 22, Not covered: 9
Timed out: 3, Not viable: 2
Test efficacy: 84.06%
Mutant coverage: 93.88%
i think we can safely remove the hard link without loosing so much performance, what you think about it?

I’d say go for it. The difference is negligible and there will be less code to maintain and reason.   Il ven, set 2459825, PM alle 16:18, Giuseppe Campioni @.***> ha scritto:
Hi guys, this is what i got by replacing the hard link with the copy:
PC info
goos: linux
goarch: amd64
cpu: Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
Benchstat
name          old time/op  new time/op  delta
DealerGet-12   9.33s ± 0%  17.75s ± 0%   ~     (p=1.000 n=1+1)
Running gremlins on gremlins itself:
Mutation testing completed in 20 seconds 108 milliseconds
Killed: 116, Lived: 22, Not covered: 9
Timed out: 3, Not viable: 2
Test efficacy: 84.06%
Mutant coverage: 93.88%
i think we can safely remove the hard link without loosing so much performance, what you think about it?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

I’d say go for it. The performance difference is negligible and there will be less code to maintain and reason about.


How do i use?

@Zayelion

Honestly I dont know.
ask @Chen-YGOPro It's his software. But I think @IceYGO could tell you more seeing as its largely based off his work.

Nevermind i figured it out. Should i host outside of USA since nas took down dn?

^_^;; I think you are getting the wrong idea about me if you are asking that question.

?


Exit if there is no new_owner.

This change is heavily influenced by how browser based music players behave.
At least on chrome and firefox, players have random names and once they are terminated (either the browser stops / restarts or in the case of firefox if all playing tabs disappear) there is no guarantee that once it is started again it will keep the same name.
A bash script wrapper for i3blocks-mpris can work around a disappearing player by doing something around the lines of:
config_path="$1"
while [ true ]; do
    player="$(playerctl -l | head -1)"
    if [ -z "${player}" ]; then
        echo "No player (yet)" && sleep 1
	continue
    fi
    i3blocks-mpris -p "$player" -c "${config_path}"
done

But for that to work i3blocks-mpris needs to exit once the player has disappeared.
Note: Also tried subscribing to org.freedesktop.DBus.Local.Disconnected https://dbus.freedesktop.org/doc/dbus-java/api/org/freedesktop/DBus.Local.Disconnected.html but it was not being triggered when force-killing the browsers.

Thanks for the PR, it finally motivated me to add a proper mutli-instance player support.
Could you please install the blocket from the latest commit and check whether it works for you?

I like it! I did a few manual trials and it seems to handle gracefully when an instance "respawns" with a different bus name.
The one thing that seemed odd is that when the current player is disconnected, the blocket goes blank, a little message could be nice to let the user know what's going on.
I added a few suggestions in PR #14. Feel free to close this PR.


[5.3] JsonResponse : let setData support more implementations

Let \Illuminate\Http\JsonResponse::setData also support data implementing \Illuminate\Contracts\Support\Arrayable or \JsonSerializable
Targeting master, as \Illuminate\Http\JsonResponse::setData could be extended in a custom class.

Even if it's extended this wouldn't necessarily break it. I suggest sending this to 5.2.

Done Taylor: #12236


ng-selected in ng 1.4.7 doesn't respond

I'm using ng-selected like this:
<select class="form-control" ng-model="vm.newChannel" ng-change="vm.changeLanguage(vm.satelliteData.serialNumber, vm.newChannel)">
     <option value="{{a}}" ng-selected="a.channelId == vm.channelId" ng-repeat="a in vm.languages">{{a.languagePair}}</option>
</select>

This code worked in 1.4.5. I updated my NG lib to 1.4.7 and it stopped working. I tried to look up the docs to see if the implementation changed but it doesn't appear it did.

We fixed a bug in the option directive; it's possible that your code broke because of that fix. That said, you shouldn't use ngSelected together with option when the select has an ngModel, as the selectController will then select the correct option for you.
Can you put a demo in a plnkr.co or similar? I see you are assigning an object to the value attribute. This is also not recommended.

Thank you for replying so quickly. I'm not using the option directive. I am using ng-change directive though. Perhaps that may be conflicting?
Also, I have found a need for placing the object in the value which in all our testing appears to work like like a champ. I'll revisit it though.

You are implicitly using the option directive via the option element. It registers the option on the select element.

If the option directive is implicitly used by virtue of using the option element and it doesn't play nice with ng-selected, under what scenario is ng-selected appropriate?

The way I see it, ng-selected is only appropriate if you use a select element without ngModel. Only the combination of the latter two will bring the option directive into play.

Yes indeed. You are correct. No ng-model on the select element. So that begs the question, how would you bind to the selected value without using ng-model?

It looks like if I want to bind, I need to use ng-options.

Thank you Narretz! I appreciate you taking the time to help me understand it. I changed my code all around to use ng-options as you suggested.

Glad you got it working!


Prediction Visualizing

Hi, thanks for your great work!
I have tried the transfuser, and it works perfectly.
But I have a problem, how can I visualize the predictions like the gif image in transfuser github?

Looking forward to seeing your reply! Thanks again!

This particular video was cut together with a video editing software.
The individual components you can generate with https://github.com/autonomousvision/transfuser/blob/337957f9095a296aa7ab2ff1cea16eecca011848/team_code_transfuser/model.py#L935
You can look at
https://github.com/autonomousvision/transfuser/blob/337957f9095a296aa7ab2ff1cea16eecca011848/team_code_transfuser/submission_agent.py#L297
to see how it is used.


Document initial release process

NOTE: While testing goreleaser, please use separated repository!
Initial draft of release process documentation.
Refs #54.

Closing in favor of #147

mind deleting the branch @invidian ?

Done. I blame @iaguis :smile:

My muscle memory only works for merged PRs, not closed ones :(


Help with connection

I'm running an Unleash instance in Heroku and created and API Token.
The Client SDK also asks for an instance ID. Where can I get this info?

@ivarconr  can you give me any help on this? :)


Fixing unittests in WMCore_t/Services_t/pycurlFileUpload_t.py and WebTools_t/REST_t.py

Related to #10422
Status
ready, some discussion on some (hacky) solutions (or better: workarounds) is necessary though. I kept all the fixes in separate commits for the moment just because it may be easier to review, but i am planning to squash the commits before merging!
Description
Fixing unittests in

[x] test/python/WMCore_t/Services_t/pycurlFileUpload_t.py

ACHTUNG: in py3 we get bytes back, not unicode
[ ] the response contains bytes, not unicode. is this going to be a problem for us? (we should discuss)

[x] test/python/WMCore_t/BossAir_t/MockPlugin_t.py
[x] test/python/WMCore_t/WebTools_t/REST_t.py

[x] testGoodEcho
[x] testDAOBased
[x] testException

caused by https://github.com/dmwm/WMCore/blob/8c73e7073fd8928326884e3d32fd9c806dcb7429/src/python/WMCore/WebTools/RESTApi.py#L147 not picking https://github.com/dmwm/WMCore/blob/8c73e7073fd8928326884e3d32fd9c806dcb7429/src/python/WMCore/WebTools/RESTFormatter.py#L25, but picking xml instead
breakpoints: RESTApi.py: L115, L150. RESTFormatter.py L92, RESTModel.py L285.

[x] testList

(simply undoing some of the changes made in debugging)

[x] testListTypeArgs

ACHTUNG: in py3 we get bytes back, not unicode
[ ] the response contains bytes, not unicode. is this going to be a problem for us? (we should discuss)

[x] testSanitisePass
[x] testSanitisePassHTTP
[x] testPing: i run it 100 times on my machine and every time it passed. removing from unstable list

[x] test/python/WMCore_t/WebTools_t/RESTFormat_t.py

[x] WMCore_t.WebTools_t.RESTFormat_t.RESTFormatTest.testGenerator
[x] WMCore_t.WebTools_t.RESTFormat_t.RESTFormatTest.testNoArgMethods

[ ] hacky solution, but real solution would require much moer effort and i am not sure it is worth the time right now

[x] WMCore_t.WebTools_t.RESTFormat_t.RESTFormatTest.testReturnFormat

[ ] hacky solution, but real solution would require much moer effort and i am not sure it is worth the time right now

Is it backward compatible (if not, which system it affects?)
yes
Related PRs
nope
External dependencies / deployment changes
nope

I squashed the commits!
Just a quick comment: i updated the docstrings, for example in https://github.com/dmwm/WMCore/blob/4c4d2472d05fc4ec4ab4fab49ba2da4ddee1cb3f/src/python/WMCore/Services/Requests.py#L464 and by having a quick look at that method it is clear that the return value is in bytes so maybe changing the docstring is a bit redundant. We are getting the value of a BytesIO stream. If we want to change it, we can. But there is always my conservative side repeating "if aint broke dont fix it".

and by having a quick look at that method it is clear that the return value is in bytes so maybe changing the docstring is a bit redundant. We are getting the value of a BytesIO stream. If we want to change it, we can. But there is always my conservative side repeating "if aint broke dont fix it".

Hehe, indeed! I think it's safe to wait for the python2 code to be gone from WMCore, then it will likely be easier to start tackling all this bytes/string/unicode war.
Thanks for squashing these!


[firebase_core] Flutter Build APK: Unhandled Exception: [core/not-initialized] Firebase has not been correctly initialized

I have been facing this problem only in Release Mode in Debug mode its working fine.
I'm using firebase_core and firebase_storage plugins only
⚠ Exception

🩺 Flutter Doctor

Followed all the steps of integrating Firebase in Flutter:
Step 1:
Added in main.dart before runApp()

WidgetsFlutterBinding.ensureInitialized();
await Firebase.initializeApp();

void main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp();
  runApp(MyApp());
}

Step 2:
Added in build.gradle root folder

classpath 'com.google.gms:google-services:4.2.0'

buildscript {
    ext.kotlin_version = '1.3.50'
    repositories {
        google()
        jcenter()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:4.1.0'
        classpath 'com.google.gms:google-services:4.2.0' <-- // here it is
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
}

Step 3:
Added in build.gradle app level

apply plugin: 'com.google.gms.google-services'

apply plugin: 'com.android.application'
apply plugin: 'com.google.gms.google-services' <--- // here it is
apply plugin: 'kotlin-android'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

Step 4:

Updated the firebase_core
Updated the firebase_storage

Step 5:
Added the google-service.json to app level

I have already gone through the solutions available on Stack Overflow. Hence, whatever link you are going to shared, I might have gone through it already.
Please let me know if you need anything else :)

Hi @mhmzdev
Please flutter upgrade to the latest stable, use the recommended version of classpath 'com.google.gms:google-services:4.3.8' and flutter clean before trying again.
If the issue persists please file a new bug report and fill out the template. Closing because this sounds more like a bug report than a documentation issue.
Thank you


How do I fix domain sizes in a stencil?

When generating stencils, it would be beneficial to have a mode where all the sizes (and strides) are fixed in the generated code. It should especially help in the CPU case on stencils with many fields, which easily start spilling registers.
Thanks in advance!

When I asked this, I wasn't sure whether freeze also freezes the dimensions. I think it would be a good feature to be able to configure that requirement, rather than let the backend decide without involving the user. Thoughts?

I think it would be a good feature to be able to configure that requirement, rather than let the backend decide without involving the user

I'm not sure I understand the idea. The current way it works is that the user has to invoke the freeze method and pass it the domain and origins. How would you envision it working?

How I would envision it is that freeze would accept another optional parameter (e.g., domain_size=None). If it is not given, only the current elements would be frozen. If it is, the size would be frozen as well, which could be used by the backends to shape-infer the sizes and strides of the domain and fields.

Hi @tbennun, thanks for your message. I'm still a bit confused: What I'm gathering from your message is that you're asking about inferring sizes and strides from the overall compute domain.
What I thought you were going to get at (and is a nice idea for optimization) is to add a way to "freeze" not only the origin of each field and the compute domain size, but also the shape of each input ndarray. Is that what you're getting at? If not, let's VC tomorrow or soon to understand this better.

You are correct. What I (mistakenly) thought was that all array shapes can be inferred from the domain size and their use in the stencils.


showing only up to 20 pictures

Hi, i realised that the slideshow only shows up to 20 pictures of the hashtag. Is it meant to be this way? Are there ways to show more than 20 pics?

Hi @chyenw ,
It's a real time slideshow.
It only shows new photos that was published after the slideshow was started.


Removing unused class file

see: MQHelper

Nowhere  use this class, I think it should be removed.

@ni-ze @lizhiboo is there anything else we have to do alongwith removing this public class MQHelper {
public static void resetOffsetByTimestamp(
final MessageModel messageModel,
final String consumerGroup,
final String topic,
final long timestamp) throws Exception {
resetOffsetByTimestamp(messageModel, "DEFAULT", consumerGroup, topic, timestamp);
}

I think not.

the issues says remove class file ? do we have to remove whole file? or the above class only?

remove whole file.

@ni-ze can you please review this? i hope i did it correctly

MQHelper may be used by external users of rocketmq-client, you'd better also provide alternative solution after MQHelper is removed.

@RishiKumarRay @caigy I think we can add @deprecated on this class, then removed after several versions.

@ni-ze so do i restore the file and add @deprecated

ok, add @Deprecated is ok.

@ni-ze please check this PR , i had to close previous one due to some problem. Thanks


Import modal provider to studylist

Question
I'm adding a new column in the studylist, in this new column we have a dropdrown, I'm trying to add a modal provider in the studylist component, so the functions in the dropdown can open the modal. One example of the functions are to display the dicom information of that study, export the image or download the exam.
What is the correct way of implementing this provider?

Please review the latest code in the master branch. This issue might have been resolved. If it persists, kindly reopen the issue with updated details.
Try viewer-dev.ohif.org instead of viewer.ohif.org
Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master  branch
Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing


DUMMY: test trigger build by new authenticated user

Signed-off-by: amahussein<EMAIL_ADDRESS>testing amahussein user can trigger build.

build


Add legend to graph support?

Hey @danielcaldas ,
I was wondering if there is a way to add a legend to describe nodes added to graph?  Looking through documentation I did not see anything like this but was hoping either this could be a new feature or you could give me some pointers how this could be done?
Right now I'm looking into just displaying a div overtop or near the graph to display this data but it would be awesome if there was someway to integrate legend directly within the graph.
btw loving rd3g keep up the good work!
Thanks for your time in advance,
Michael

Hey there @michaelbdavid this is certainly a feature request, there's nothing similar today in react-d3-graph to what you've described.
Usually, I try to look at feature requests as the following:

Is this hard to achieve without react-d3-graph? Meaning, can the client figure out this thing on its own?

In this case, I think as you've mentioned it's possible to just add a custom element around the graph o display this data. So maybe it's better off outside of react-d3-graph itself, otherwise, it might extremely narrow down your options in terms of how you're going to display that extra data.

Would such a feature limit the design options of the client?

As mentioned yes, because react-d3-graph by nature would have to offer some kind of structured API and place the legend within the graph where the positioning might not be ideal, therefore becoming a bottleneck instead of actually helping developers.

Anyways I would like to keep this as a feature request and let's see if any other developers have a particular interest or different views on this.

Hey @danielcaldas,
Thanks for looking into this for me.  I was thinking about this more and was wondering if this could actually be added pretty easily by adding in another custom node configuration?  This would be similar to what you currently do with viewGenerator except made it has away to give it placement within the graph.  What do you think just a thought I had.  I also wanted to ask is there a way to have several different types of cusomNodes in a graph?
Thanks again,
Michael

Cool it looks like this will work.  Basically create a custom node specific to legend data and display it.

So just to follow up.  I was able to create a legend using custom node component and setting x,y.  For others interested,  take a look at the custom node example.  I basically have several different types of nodes with different viewGenerators.  One of the nodes that I create has no relationships and has a viewGenerator that creates my legend.

Hey there @michaelbdavid thanks for the update, glad you could make it work. Any screenshots you may be willing to share so that developers looking into this thread might get an idea of how this looks like? Thanks!


Postgres optimizations are not enabled correctly

While troubleshooting #1196, I found that although I was using Postgres, the MultiRowInsert option was disabled. It's therefore likely some other Postgres optimizations are disabled by default as well.
Seems to be fallout from moving database configuration around between core and firefly-common.

I've drafted PR https://github.com/hyperledger/firefly/pull/1197 to resolve this issue, but it will have to remain in draft until the pre-req PR https://github.com/hyperledger/firefly-common/pull/49 has been approved and we have a new firefly-common release.


fix(ToolbarRow): Includes validation to run active tool definition when mounting tool buttons

Includes validation to run active tool definition when mounting tool buttons
fix #704

I don't think this is solving the root of the issue outlined here: https://github.com/OHIF/Viewers/issues/704
Feel free to push back if you believe otherwise.


3.0 docs for pursuit

I tried to generate 3.0 docs for pursuit but I ran into this issue https://github.com/purescript/purescript/issues/3414/

How are other people dealing with it? Desugaring it manually or waiting for a fix?

Closing as 4.0.0 has been released.


Add Blazor First Look Course Banner

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Dedac sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@danroth27 This is the home page banner as discussed for the linked in learning course unlock

Took a few minutes for the stylesheet to come down, but it's live now ...
https://blazor.net/index.html


Update documentation for InputEventScreenDrag

Clarified InputEventScreenDrag, showing that it refers to drag actions on touchscreens, and not drag actions using a mouse.

It does involve drag actions when simulating touch from mouse though, so this might be confusing

Interesting, I was not aware of that. I found the documentation on what it refers to to be a little vague, all the same. Looking at those functions, it implies the use of a tablet, which feels like a whole other category.
I would still like to improve this, if I can. Is there a tutorial available anywhere online, so I can get used to using it properly?

Not that I know of, so let's see if the input team can give some instructions


[test] Set LD_LIBRARY_PATH if testing on OpenBSD.

LLVM binaries are built with rpath and dynamic libraries referenced
relative to $ORIGIN. However, on OpenBSD, ld.so resolves $ORIGIN
relative to the working directory, because on this platform there is no
mechanism available to generically and portably track the path of a
running executable[1].
Therefore, work around this by setting LD_LIBRARY_PATH to ensure that
LLVM executables running in unit tests can properly reference the
necessary LLVM dynamic libraries.
[1] See https://marc.info/?l=openbsd-misc&m=144987773230417&w=2

Hmm, what libraries are being referenced from that location?  I thought we were statically linking the LLVM libraries.  More a curiosity thing rather than an objection.

@swift-ci please test

@swift-ci please test

@swift-ci please test

Some tests invoke c-index-test, which links against libIndexStore.


Doc: Switch to Dokkatoo

Use https://github.com/adamko-dev/dokkatoo that is configuration cache compatible and cache relocatable
The workers use a lot of memory so depending the machine, we can't run too many in parallel. I set the number of parallel workers to 4 for now. 🤞 that it works on GA runners...

On hold for https://github.com/adamko-dev/dokkatoo/pull/64

Closing this one for now, will revist later


Investigate looping in buffered commands

On discord, there was a query from @jblang about performing loops with buffered commands, where a relatively simple loop was failing to work
the assembler in question was as follows:
Main:
    call InitBuffer
    ld de, DrawLoopBuffer
    call CallBuffer
    call NewLine
    ret

; upload vdp draw command
InitBuffer:
    ld hl, DrawLoop
    ld de, DrawLoopBuffer
    ld bc, DrawLoopLength
    call ClearAndSendBuffer
    ret

DrawLoopBuffer: equ 0
DrawLoop:
    ; Escape the character and output it
    defb VduEscapeChar
DrawLoopCharOffset: equ $ - DrawLoop
    defb 0
    ; Increment target offset by ScreenWidth
    defb VduCommand, VduSystemCommand, VduBufferCommand ; 23, 0, &A0
    defw VduBufferSpecial   ; &FFFF
    defb VduBufferAdjust    ; 5
    defb VduBufferAdjustAdd ; 3
    defw DrawLoopCharOffset ; 1
    defb 1
    ; Conditionally jump to the same buffer while byte at DrawLoopCharOffset is non-zero
    defb VduCommand, VduSystemCommand, VduBufferCommand ; 23, 0, &A0
    defw VduBufferSpecial   ; &FFFF
    defb VduBufferConditionalJump   ; 8
    defb VduBufferConditionNotEqual ; 3
    defw DrawLoopBuffer
    defw DrawLoopCharOffset         ; 1
    defb 0
DrawLoopLength: equ $ - DrawLoop

it is a simple loop intended to display all characters (from 0-255)...
at a cursory look this should work - this issue is filed as a reference to go back and investigate this further when time permits

Finally got around to properly looking into this @jblang
The issue with this program is the use of "jump to buffer &FFFF".  Rather than performing a jump to the beginning of the current buffer, this gets interpreted as "jump to the end of current buffer".  This is as per design, and the documentation reflects this behaviour.
The correct way to perform a conditional jump to the start of the same buffer as is being executed is to use the "jump to buffer with offset" command.  The command (in BASIC syntax) for this particular loop would be as follows:
VDU 23,0,&A0,&FFFF;&0A,0;0,3,&FFFF;1;0

(the command changes from 8 to &0A, and three zero bytes for a zero offset are added.  the condition arguments remain the same, although in this example is using &FFFF for the source buffer ID for the conditional data rather than explicitly referencing the buffer)

closing as this was not a bug - instead it's a feature of how jumps work


RNWeb preparation: JS Values implementation

Added JS implementation with toggle for RNSk***Values and animations.

This is awesome, I'm wondering what's the best practice to keep symmetry here. The issue is that on native these are interfaces and on web they are values? Maybe this could be refined. the file package/src/values/web/api.ts file for instance may be able to be done via the .web.ts extension?

No, they should be exactly the same as JS is concerned :)
All APIs is defined with interfaces and implemented in JSI/C++ for the native platforms and JS for the web-platform (or other platforms coming later). There is no difference in these types as far as Javascript is concerned.


Apache & c

First, thanks for this tool!
After some experimenting, I've got a sample application written in c (echos back what it's sent) and instructions for connecting to websocketd via Apache's modproxy_wstunnel.
If you want them, do I send them to someone or shall I add them to the Wiki myself?
Cheers
Chris

It's totally fine if you add wiki page describing your problem and solution. Thanks!

Let me know if I should change permissions for that. Not sure how it works.


HELP regex pattern

Hi,
thanks for this awesome tool.
I've one small question. Want to find all http 499 from nginx logs
nginx-public-ingress-6x7pb name <IP_ADDRESS> - - [08/Apr/2020:09:06:15 +0000] "POST /telemetry HTTP/1.1" 499 0 0.039 0.000 ."

this is a sample string.
stern -i "HTTP\/1.1\" 499"

is not working.
Can somebody suggest what should be the pattern?

It should be stern -i '"""HTTP\/1.1\"" 499"'. Because the option is parsed using golang CSV parser. :(

what I do now is stern -i 'HTTP.1.1...499' I think this is the easiest way


After updating 0.34.4 errors being reported in the log

16-12-08 14:38:01 homeassistant.core: Error doing job: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/lib/python3.4/asyncio/tasks.py", line 237, in _step
result = next(coro)
File "/srv/hass/hass_venv/lib/python3.4/site-packages/homeassistant/helpers/entity_component.py", line 335, in _async_process_entity
new_entity, self, update_before_add=update_before_add
File "/srv/hass/hass_venv/lib/python3.4/site-packages/homeassistant/helpers/entity_component.py", line 204, in async_add_entity
yield from entity.async_update_ha_state()
File "/srv/hass/hass_venv/lib/python3.4/site-packages/homeassistant/helpers/entity.py", line 226, in async_update_ha_state
device_attr = self.device_state_attributes
File "/srv/hass/hass_venv/lib/python3.4/site-packages/homeassistant/components/zwave/init.py", line 606, in device_state_attributes
battery_level = self._value.node.get_battery_level()
File "/srv/hass/hass_venv/lib/python3.4/site-packages/openzwave-0.3.1-py3.4.egg/openzwave/command.py", line 284, in get_battery_level
for val in self.get_battery_levels():
File "/srv/hass/hass_venv/lib/python3.4/site-packages/openzwave-0.3.1-py3.4.egg/openzwave/command.py", line 306, in get_battery_levels
type='Byte', readonly=True, writeonly=False)
File "/srv/hass/hass_venv/lib/python3.4/site-packages/openzwave-0.3.1-py3.4.egg/openzwave/node.py", line 440, in get_values
for value in self.values:
RuntimeError: dictionary changed size during iteration
Problem-relevant configuration.yaml entries and steps to reproduce:

Traceback (if applicable):

Additional info:

Look like a openzwave bug.


cant get it to work

ive tried manually installing and using the installer for foundry and both dont work the foundry install gives a error and the manual install just dont show up

Error: Cannot read properties of null (reading 'protected')
setup.js:5304:21

I can't install the module It get this error Error: Cannot read properties of null (reading 'protected') setup.js:5304:21

i think this is outdated and dropped sadly ;-;

I hope this addon will work again.


feature: close split view automatically

steps:

open preferences file
split view opens
click to close the brackets.json in the right pane, nothing else is remaining in the right pane

i believe, that the split view should now close automatically, given it was also automatically opened

Makes sense in the preferences scenario, I think that the preferences split view should be more isolated anyway. Auto-closing the panel when it's possible to modify the views while the preferences are open is a bit tricky too. Consider something like this:

Open preferences file
Split view opens
Drag another file to right panel
Close brackets.json -> Right view should stay open right?

But what if

Drag the file back to left panel
Close brackets.json - nothing stays in the right panel but it shouldn't auto close as it has been "dirty" - right?

Well, I'd implement it in a way that if split-view was automatically opened (forced on me) it also should automatically close. If it was opened manually, it should never auto-close. I don't really like split view and how it's forcing itself anytime I want to change something in preferences.

This was added in #11749 right?


Error in library(targets) : there is no package called 'targets'

couldn't submit jobs to openlava

the searching path is specified when calling module load.
load an old version which has the package installed solved this issue.


colours diff between mIRC and Hexchat

URL: I'm getting normal black in mIRC but grey in Hexchat

Thanks for bringing this to my attention, but I don't think this is a huge issue, is it?
Is this post #4 or not?


Cannot start a new asperatransferd process if one already exists on Linux. On Windows this works.

Hi Laurent
On windows, I can run an asperatransferd.exe even if an old process is visible in process explorer but on Linux this does not work for me, the child process is nor running.
Could it be related to the grpc port? or licensing?
Please help
Thanks
Kola

First, this repo is about ascli, not the transfer SDK.
Normazlly, use the IBM support for such questions.
asperatransferd (Transfer SDK) listens on a TCP port, if this port is already used, then it exits.
The value of the port itself is not very important, it can be any available port, and then the gRPC client must use it.
One way it to tell asperatransferd to use port 0 (zero), and then get the actual value from its log, but it is not very reliable (if log changes).
I have already opened a enhancement ticket on that aspect.

Thanks for Laurent for the quick answer.
Very useful
Please keep me posted when the enhancement is done.
Thanks
Kola

There is no enhancement planned so far.


lowercase placeholder.gif

Try more consistent capitalization for placeholder.gif (https://github.com/USGS-VIZLAB/water-use-15/pull/326#issuecomment-389001788)

Marty's slack dot says he's out at the moment (lunchtime in WI) and I want quick feedback so am merging this 2-line change myself.


Global command entity not fully working

Hello there,
awesome integration. I bow to you!! Thanks!
I've decided to create this issue because it feels to me as if one entity was missing in my system, or the main entity is not fully capable of commanding my environment. I have an Airzone system with 5 zones, and the zones are correctly recognized by this integration:
2020-12-12 16:53:25 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new climate.airzonecloud entity: climate.sistema_1_comedor
2020-12-12 16:53:25 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new climate.airzonecloud entity: climate.sistema_1_h_despacho
2020-12-12 16:53:25 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new climate.airzonecloud entity: climate.sistema_1_h_juegos
2020-12-12 16:53:25 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new climate.airzonecloud entity: climate.sistema_1_h_ninos
2020-12-12 16:53:25 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new climate.airzonecloud entity: climate.sistema_1_h_suite
2020-12-12 16:53:25 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new climate.airzonecloud entity: climate.sistema_1

I can command the individual zones just fine. However, when I attempt to command the whole system, I'm unable to turn it on or off globally; I can however modify the Operating mode just fine (which is a global setting as well), and I can modify individual zones just fine too, but I simply can't turn the whole system on or off.
This is what I did. Starting with a system in standby

I changed the Operating mode by switching Cool on the global widget in the frontend

I could see how the mode changed on my phone

I then tried to change the temperature, hoping that it would also modify the global temperature selector on the unit

but I did not see a temperature change on my phone

I then clicked on the switch on/off button on the widget in the frontend

nothing changed in the system
I then grabbed my phone and toggled the global switch to on and changed the global temperature setting

The system of course started working but global entity did not react, while the individual zones did.
The log file contains this:
config $ tail home-assistant.log -f | grep 'Sistema 1'
2020-12-12 17:33:45 INFO (SyncWorker_1) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=stop, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:33:55 INFO (SyncWorker_53) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=stop, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:34:05 INFO (SyncWorker_32) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=stop, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:34:09 INFO (SyncWorker_51) [AirzoneCloud.System] call set_mode(stop) on System(name=Sistema 1, mode=stop, eco=eco-off, velocity=None, airflow=None)
2020-12-12 17:34:13 INFO (SyncWorker_25) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=stop, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:34:17 INFO (SyncWorker_54) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=stop, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:34:25 INFO (SyncWorker_31) [AirzoneCloud.System] call set_mode(cool-both) on System(name=Sistema 1, mode=stop, eco=eco-off, velocity=None, airflow=None)
2020-12-12 17:34:25 INFO (SyncWorker_40) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=stop, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:34:35 INFO (SyncWorker_1) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:34:46 INFO (SyncWorker_13) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:34:55 INFO (SyncWorker_43) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:35:01 INFO (SyncWorker_0) [AirzoneCloud.System] call set_mode(stop) on System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None)
2020-12-12 17:35:01 INFO (SyncWorker_58) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:35:05 INFO (SyncWorker_16) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=stop, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:35:11 INFO (SyncWorker_12) [AirzoneCloud.System] call set_mode(cool-both) on System(name=Sistema 1, mode=stop, eco=eco-off, velocity=None, airflow=None)
2020-12-12 17:35:14 INFO (SyncWorker_33) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=stop, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:35:15 INFO (SyncWorker_8) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:35:25 INFO (SyncWorker_35) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:35:35 INFO (SyncWorker_50) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:35:46 INFO (SyncWorker_28) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:35:55 INFO (SyncWorker_42) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:36:05 INFO (SyncWorker_46) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:36:18 INFO (SyncWorker_47) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:36:25 INFO (SyncWorker_52) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)

2020-12-12 17:36:35 INFO (SyncWorker_25) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:36:46 INFO (SyncWorker_54) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:36:55 INFO (SyncWorker_55) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:37:05 INFO (SyncWorker_23) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id= xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)
2020-12-12 17:37:17 INFO (SyncWorker_57) [AirzoneCloud.System] Data refreshed for System(name=Sistema 1, mode=cool-air, eco=eco-off, velocity=None, airflow=None, id=xxxxxxxxxx, system_number=1, device_id= xxxxxxxxxx)

any idea about what may be happening? The line breaks above indicate when I commanded the system on my phone. If you check the logs, you will see that no attribute changes...
Am I doing something wrong?
thanks again!

Hi @max13fr , did you happen to get around to reviewing my case above? Is there any additional information I could provide?
thank you!!!

Please let me know if I can be of any help!

Hi @max13fr I'm sorry they programming skills are pretty poor. I would love yo contribute but I just don't feel I can tamper with the cose.
May I provide any additional information?
Thanks a million for such a great integration!!

Update: with the current version, global on/off and Mode do seem to work. Changing the temperature using the global entity still doesn't.


tag version 0.3.5

Please tag version 0.3.5 and future versions. Then tars become available under a deterministic url. That make lives of package maintainers easier. Thanks in advance.

Now available: https://github.com/jsvine/waybackpack/releases


Re-pin test-kitchen to latest version

Now that Test-kitchen 1.7.2 is released with the spec fix, we can go back to pinning to a released version.
@tyler-ball @jkeiser

:+1:

No longer needed


Merge master into develop

:tada: This PR is included in version 1.3.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Should we add a CI?

Do you think it will be worth adding a CI here? For testing on different archs... @bwesterb

It would be helpful to have to ensure that PRs do not cause regressions elsewhere, so 👍 for CI.
GitHub Actions supports Windows, Linux and macOS (https://docs.github.com/en/actions/getting-started-with-github-actions/about-github-actions). It also claims to support ARM, but I could not quickly find documentation about that.
circl does use GitHub Actions for arm64, an example can be found here: https://github.com/cloudflare/circl/blob/master/.github/workflows/ci-actions.yml

Yes, I think using  GitHub Actions might be the right way. I'll integrate it ;)

For ARM support, you need to provide self-hosted runners afaik.

Thank you @Lekensteyn


s390x updates

Changes include:

A new connect/platforms/s390x directory for s390x-specific files:

A docker-compose.yml that uses compose 3.7 instead of 3.9 & an IBM FHIR Server image for s390x
mkcert compiled for s390x
A Readme

Dockerfile updates

Tested on s390x with connect configured to transmit data to the FHIR server. Successfully transmitted data to the FHIR server and queried that data.


Report "pageInfo" telemetry once, rather than for each rendered page

Reporting telemetry, in Firefox, includes using JSON.stringify on the data and then sending an event to the PdfStreamConverter.jsm-code.
In that code the event is handled and JSON.parse is used to retrieve the data, and in the "pageInfo"-case we'll then proceed to ignore everything except the first such event; see https://searchfox.org/mozilla-central/rev/24fac1ad31fb9c6e9c4c767c6a7ff45d226078f3/toolkit/components/pdfjs/content/PdfStreamConverter.jsm#509-514
All-in-all, sending the "pageInfo" telemetry for each rendered page is thus unnecessary and this patch makes the viewer send it only once instead.

/botio-linux preview

Looks good to me!


Update "notifications language" setting to use the "Default language" picker modal

The settings UI for picking the "notifications language" (previously "Default language for new users"; see #20866) should use the much nicer language picker component that we have for an individual user's language setting (i.e. this, rather than the simple dropdown).

I haven't looked at how complex this is, but it seems clearly better to reuse that component.

@sahil839 I already did some work on it as part of #21977, let me finish this.


Show/Hide password icons interrupt input navigation

Just finished setting up a site and noticed that tabbing through the password fields will stop on the show/hide icons. Should those links have tabindex -1 or is that intended?

Not intended. Just checked it in Safari and Chrome, and it appears to only affect Chrome. If you want to make a PR for it and Chrome/Firefox/Safari all work as expected, I'll merge it in right away. Good catch @RDelorier!

Whew what a day, I'll get a PR open in just a few!


Add document deletion feature to dashboard (document detail)

What this PR does / why we need it?
Add document deletion feature to dashboard (document detail)
Currently looks like:

Links back to the documents list page once document is deleted.
Any background context you want to provide?
What are the relevant tickets?

Related to #110
Checklist

[ ] Added relevant tests or not required
[ ] Didn't break anything

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Currently, when the document delete button is clicked, the document is immediately deleted.
For a better user experience, we can consider adding a delete confirmation modal.
The modal can also provide warnings and information about what happens when the document is deleted.


Batch normalization acting weird?!

System Information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No custom code
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 7.1
TensorFlow version (use command below): 1.3.0
Python version: 3.6
Exact command to reproduce: See code below
Bazel version: Not building from source
CUDA/cuDNN version: Version 6
GPU model and memory: Nvidia Quadro k2200 with 4GB

Describe the problem
Hello everyone,
so theres the method tf.layers.batch_normalization and i am trying to understand what is Happening behind the curtains and in how far it is manually reproducible and in conformance of the paper by Ioffe&Szegedy. After running a small script which can only Train the two Parameters Gamma and beta to minimize the loss it appears that there is not normalization taking place(activation reduces by the mean over all activations of one Batch divided by the square-root of the variance of all activations of one batch). It is more or less always considering the Initial activation and simply multiplies this with Gamma plus beta. And that is especially interesting if the Batch size is reduced to one(not even remotely sure what is Happening then; yet it seems like this does not affect the computation at all)...
Thank you for your time and consideration!
Source code / logs
import numpy as np
import tensorflow as tf

test_img = np.array([[[[50],[100]],
                   [[150],[2000]]],
                   [[[0],[300]],
                   [[140],[5000]]],
                   [[[0],[300]],
                   [[140],[5500]]],
                   [[[0],[200]],
                   [[1400],[5000]]],
                   [[[0],[300]],
                   [[140],[5000]]]], np.float32)
gt_img = np.array([[[[60],[130]],
                [[180],[225]]],
                [[[60],[130]],
                [[180],[225]]],
                [[[600],[130]],
                [[1800],[225]]],
                [[[60],[100]],
                [[180],[205]]],
                [[[60],[100]],
                [[180],[205]]]], np.float32)
test_img_op = tf.convert_to_tensor(test_img, tf.float32)
norm_op = tf.layers.batch_normalization(test_img_op, momentum=0)

loss_op = tf.reduce_mean(tf.nn.softmax_cross_entropy_with_logits(labels = gt_img,
                                                             logits = norm_op))
count = 0
update_ops = tf.get_collection(tf.GraphKeys.UPDATE_OPS)
with tf.control_dependencies(update_ops):
    optimizer_obj = tf.train.AdamOptimizer(0.01).minimize(loss_op)
with tf.Session() as sess:
    sess.run(tf.group(tf.global_variables_initializer(),
                      tf.local_variables_initializer()))
    print(test_img)
    while True:
        count += 1
        if count < 100:
            new_img, op, lossy, trainable = sess.run([norm_op,
                                                      optimizer_obj,
                                                      loss_op,
                                                      tf.trainable_variables()])
            print(trainable)
            print(new_img)
        else:
            break

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
TensorFlow installed from
Bazel version
CUDA/cuDNN version
GPU model and memory

Nagging Awaiting Response: It has been 14 days with no activityand the awaiting response label was assigned. Is this still an issue?

Nagging Awaiting Response: It has been 14 days with no activityand the awaiting response label was assigned. Is this still an issue?

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 29 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 15 days with no activity and the awaiting response label was assigned. Is this still an issue?

We are closing this issue for now due to lack of activity. Please comment if this is still an issue for you. Thanks!


Add GitHub Action workflow to run benchmarks on CI for pull requests

It works:
https://github.com/Team-RADDISH/ParticleDA.jl/blob/ceec818fcd6ea3b07c6f9e5abfb63d68fd0ab582/2021/02/22/164051/result.md :partying_face:  As I suspected, benchmark/benchmarks.jl should be already committed to master for this to work

Of the benchmark results published yesterday, only the first and the last seems meaningful (no performance change between the baseline on master and this PR), while the other two report a 50% speedup (with no changes to the code...).
I'm not sure what's going on, I've run the BenchmarkCI code locally multiple times and always found consistent results between the target and the baseline.  I suspect that running benchmark on GitHub-hosted machines may not be the best idea possible (perhaps machine are randomly hit by other load?).  In the past I tried to run benchmarks on Travis and results were unreliable at best, but "totally meaningless" is a better depiction of my experience, performance was extremely poor overall.  Azure/GitHub machines are better than Travis, but may still be not always reliable.

Not sure this explains the issue (especially, not the difference between target and baseline), but the two "good runs" were using Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz, while the other two were on Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz.


Start modernizing Okta provider with Go SDK v5

This PR modernizes the Okta provider by introducing the Okta Go SDK v5 while maintaining backward compatibility with the existing v2 SDK.
The following generators have been updated to use the v5 SDK:

user
app_oauth
app_swa

Related to #1936
The code has been simplified by removing unnecessary type assertions and manual filtering, and the accuracy of the generated Terraform resources has been improved.
Further modernization of the remaining resources and the introduction of missing resources will be addressed in future PRs.

Can the okta terraform provider be upgraded as well?

it should not be needed as the wrapper gets the version dynamically - I will double check

yep it gets from your local, for example add this into a provider.tf
provider "okta" {}

terraform {
	required_providers {
		okta = {
                 source = "okta/okta"
	         version = "~> 4.11.1"
		}
  }
}

run terraform init then run your terraformer command to check

@sergeylanzman I'm waiting on your review to decide if I continue with this effort :)


Synthlock Invariant

Closes: #XXX
Description

For contributor use:

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

Codecov Report

Merging #841 (f7c4f3e) into main (1f8327e) will increase coverage by 0.00%.
The diff coverage is 41.66%.

:exclamation: Current head f7c4f3e differs from pull request most recent head eca99e6. Consider uploading reports for the commit eca99e6 to get more accurate results

@@           Coverage Diff           @@
##             main     #841   +/-   ##
=======================================
  Coverage   19.78%   19.79%
=======================================
  Files         189      190    +1
  Lines       24880    24891   +11
=======================================
+ Hits         4922     4926    +4
- Misses      19093    19100    +7
  Partials      865      865

Impacted Files
Coverage Δ

x/lockup/keeper/invariants.go
36.36% <36.36%> (ø)

x/lockup/module.go
55.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f8327e...eca99e6. Read the comment docs.


replay command

a command, and a little button on score embeds where it is applicable would be great.

this will have to go into limbo until bun fixes their web socket compatibility with ordr.js
https://github.com/oven-sh/bun/issues/10147


Is there a way to provide the file contents

When a module has been resolved as a file, there doesn't seem to be any plugin for providing the content.
The callback seems to only search valid paths but no content byte array/string option.
Or is there?

I'm looking at after-resolve, is that the place to provide the content ? It seems that resource might be the thing, but I see no documentation for that.

There is no way.

Ok, you could provide a custom inputFileSystem to the compiler...

That seems like an acceptable solution even if a bit of a workaround

This doesn't seem to work with watching
The build keeps being triggered.

you also need a custom watchFileSystem.

I made a simple modification to the new Watcher.
NewWatchingPlugin.prototype.apply = function(compiler) {
	compiler.plugin("environment", function() {
		compiler.watchFileSystem = new NodeWatchFileSystem(compiler.inputFileSystem.forWatching || compiler.inputFileSystem);
	});
};

This works except for having virtual entry files. It seems to work differently. I need to add a couple of require statements in addition to the main JS to kick off the application. Is there another way I might do that, perhaps with a loader.

It seems that the watching is relying on something other than inputFileSystem.stat
After looking around quite a bit I can't seem to find anything. Even so the rebuild gets constantly triggered.

@thepian Any luck with this?


We want to thank everyone for their review and feedback on the Privacy Statement Update. We appreciate and share your passion for developer privacy. GitHub remains committed to having the highest privacy standards and will continue to center the needs of developers in all of our platform decisions. We intend for this to be a minimally invasive change that will enable us to provide the best tools to our users. In response to your comments, we are providing the following changes and points of clarification:

          We want to thank everyone for their review and feedback on the Privacy Statement Update. We appreciate and share your passion for developer privacy. GitHub remains committed to having the highest privacy standards and will continue to center the needs of developers in all of our platform decisions. We intend for this to be a minimally invasive change that will enable us to provide the best tools to our users. In response to your comments, we are providing the following changes and points of clarification:

DNT and self-help browser extensions
Commenters raised questions about our language on DNT and self-help browser extensions. We've pushed a commit that:

Folds the existing DNT and browser extension information into a new section on disabling non-essential cookies.
Specifies there will be a user setting to disable non-essential cookies and provides additional details to clarify which cookies will be used and for what reasons.
Specifies that DNT will be honored on GitHub, and that if a DNT signal is sent, GitHub will not load third party resources which set non-essential cookies, so that we do not have to rely on third parties honoring DNT.
Browsers' built-in tracking protection has advanced significantly in recent years, so we've noted that configuring that built-in protection may block non-essential cookies.
Separated mentions of browser extensions designed to block tracking, and extensions designed to block unwanted content with the effect of blocking tracking, for clarity, though using either alone or in combination may block non-essential cookies.
Changed links with additional information on DNT and browser extensions to point to their respective Wikipedia articles for neutrality, currency, and to clarify that these are not GitHub products (though of course we're proud that many privacy protection tools are developed on GitHub).

Finally, some have asked why we’re explaining technical self-help tools. GitHub has a very broad user base, including new developers – and we want everyone to be informed about the scope of their options, including technical options.
Enterprise user experience
Commenters asked for clarification about how this change will impact the enterprise user experience. We are introducing cookies on GitHub’s Enterprise Marketing Pages (e.g. resources.github.com), not on Enterprise user accounts. We intend for this change to make it easier for our Marketing team to better understand the needs of users who are visiting Enterprise Marketing Pages and connect them with the solutions that will benefit them most.
Users who visit these pages will have the option to express their cookies preferences by navigating to the link in the footer of the page.
Stylistic change
Commenters have asked why ‘Personal Data’ was changed to ‘personal data’ in the Privacy Statement update. We made personal data lowercase because it is not a defined term in our Terms of Service, for consistency with “All capitalized terms have their definition in GitHub’s Terms of Service, unless otherwise noted here.” The stylistic change does not impact its definition.
Originally posted by @shellsmck in https://github.com/github/site-policy/issues/582#issuecomment-1234458256

WIRAPHAN yAOWALA


Feature/meteor1.2 babel

Please remove the blaze-html-templates package, otherwise you'll get errors about two plugins trying to use the same .html extension

Added Babel support to the script compiler plugin, as per pbastowski:angular-babel. The plugin first compiles the ES6 code with Babel and then imediately runs ng-annotate on the compiled code.
Bumped package version to 1.2.0-alpha-1

Awesome @pbastowski !
As per @netanelgilad suggestion today on the strategy doc, maybe it's better to imply a separate package, like in React and Jsx?
Second, the right way of versioning is 1.2.0-alpha.1

Sure, no problem. I like it.
If I understand it correctly, instead of including a babel-ng-annotate plugin in the angular package, we will imply a new package, say, angular-babel, which itself will implement the plugin, Right?
I've fixed the alpha naming in the PR.
... but, it would see that I need to create a new package called angular-babel.

yes that's the idea.
Thank you for that

I have removed the JS plugin support from angular-meteor and extracted it into it's own angular-babel package https://github.com/pbastowski/angular-babel. The angular-meteor package.js in this PR implies angular-babel, thus implementing the JS compiler plugin I removed in the first place.
For testing you'll need my feature/meteor1.2 babel angular-meteor branch and also clone my angular-babel repo into your packages folder.

Uri, I'm thinking if the imply is a good thing to do.
My concern is that once we do it, then others who might want to use TypeScript, for example, will unnecessarily have to also imply (include) Babel runtimes in their FE code.
What's your take on that?

And, yeah, I have to cleanup the files :) I wanted first to hear back from you about my imply question above.

@pbastowski yes that's a good point.
Maybe another package named angular-bundle or angular-pack that implies both angular and angular-babel can be a good idea.
What do you think?
@netanelgilad

My internal feeling says, let the people decide which packages they want to add.
However, for many people and especially new-comers to angular-meteor, it will make a difference if we have an all encompassing bundle, which is what you said you wanted to provide, right?
So, I vote for angular-bundle, which implies angular, angular-babel and 'angular2-now`.

Yes I think I'm with you on that.

But leave it open for a while, I want to think a bit more about it

@pbastowski did you update angular-babel to use regular .js files?
I want to release a new version and test it out

@pbastowski @netanelgilad @DAB0mB I vote against angular-bundle for now.
The developer will add angular and angular-babel and remove ecmascript.
That's easy enough.
Now let's just see that the angular-babel is ready, test with socially and release

@Urigo No, I did not. I was waiting for you to get back to me.
Good decision! Let the people add the packages they want. So, here's what I will do:

I will add in-memory caching for the compiler to speed things up considerably.

I propose to make one change to Babels generated ES5 code. I want to output SystemJS bundled ES5 modules instead of simple ES5 code. This will allow people to do

import { Feature2 } from 'client/Feature2/Feature2'

The above lazy-executes the imported Feature2. See my pbastowski:typescript package for another example.
I need to actually speak with you about this tonight and to vote on yes or now, if possible, as this is a potentially breaking feature, which would require that we modify the Socially app accordingly. But, it would also move us into the realm of ES6 modules and SystemJS.
BTW: My typescript package caches in-memory and also includes my SystemJS package. Tests on my own apps, where I used this package instead of Babel, show that everything works just fine. So, what I'm saying is that we could use TypeScript instead of Babel for most cases. No type annotations are required in any of my code and everything works, so, it's a viable alternative to Babel. And if you want to use types then you can.

@pbastowski I would prefer to wait with adding SystemJS as ES6 modules is really close to get into Meteor (version 1.3) - https://github.com/meteor/meteor/pull/5475
and I would want to be based on the Meteor solution and not another
About caching - I think it's important, but not enough to wait with the release, how long to you think it will take you to add and test it ?

I'm on it now. Hopefully in an hour or so it will all be working.

@Urigo It's done. However, I don't have rights to publish a root package called angular-babel. It is a root package, because it is not prefixed with pbastowski: So, do I prefix it or do I get rights to publish a root package or how do we handle the publishing on Atmosphere?
For testing, just clone this repo into your test project's packages folder and then
meteor add angular-babel

I used it in my socially app with angular2-now and it worked as expected.

Let's leave it under your name for now as the official ES6 is different

I already have a package called pbastowski:angular-babel for Meteor 1.1, so, this new one for Meteor 1.2 I will call pbastowski:ng-babel.

Won't it be easier to do a major version bump with the same package?

Sure, I'd love to, but... the code is too different. How do I maintain two very different code bases in the same package for two different versions of Meteor?
I don't know how to do this. Maybe you can help me with this?

Oh, I think I see what you meant. To bump the major package version and then publish the new Meteor 1.2 code to Atmosphere under the same package name. This will of course only run in Meteor 1.2, but that's the plan. Right?

Yes, then you can keep publish versions for the older versions, like Angular is doing

ok, done.
The pbastowski:angular-babel package is ready :)
Once again, I tested it with my angular2-now version of Socially and it works as expected.


Correcting admin fwlink

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/5005

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Implement SDL-0243 Manager Update for Display Capability

Fixes #1154
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Extend unit tests to confirm display capability/capabilities conversion is as expected.
Summary
This PR changes SystemCapabilityManager according to SDL-0243 to make new capabilities available and also convert DisplayCapability and DisplayCapabilities objects.
Changelog
Existing SystemCapabilityTypes are marked as deprecated hence will appear as deprecated if apps are using them.
Enhancements

Adds new capability to the manager
Adds conversion of display capability objects for developer's convenience

Tasks Remaining:

[x] [Add DISPLAYS to manager]
[x] [Add Conversion code]
[x] [Do the unit tests]

CLA

[x] I have signed the CLA

@theresalech The PR is ready for review.

@BrettyWhite we attempted the change in the library to use the new format but had issues to get it running stable. The risk of creating bugs is extremely high for actually just little to no benefit as the converted capabilities are compatible.

Closed as livio taking over implementation. Will open new PR


BUG: False negative CI-Test on androidx repo

Describe the bug
False Negative result in CI-Test scorecard check
Reproduction steps https://github.com/androidx/androidx/security/code-scanning/47
nothing merges w/o aosp tests
Expected behavior
CI-Test should not trigger alert on this particular pattern.
Additional context
Organization uses
GitHub as a mirror of one of our aosp repositories.
Copybara mirrors every merged CL from the AndroidX-main branch (AOSP) into GitHub.
When we receive a pr from external contributors, after approval, it gets mirrored into aosp (and needs another+2 and pass presubmit).
Contact Yigit Boyar

Thanks for the report. The check seems to be failing because scorecard is unable to detect pull request on the repo, because its done internally and pushed to GitHub via copybara
Can you tell us more about how we could detect CI for this repo?

I found something interesting. We can check for presence of CI-Tests on a merge SHA instead of a PR (i.e check runs that ran on push event) - https://api.github.com/repos/androidx/androidx/commits/289583a81c5a84f3ac4b14867f72dbf3021d0aaa/check-runs.
Maybe Scorecard should fallback on this if there is no associated PR found for a commit?


Break of compatibility with PHP 5.3.3 between 1.3.7 and 1.3.9 (Parse error: syntax error)

Hello,
Break of compatibility with PHP 5.3.3 between 1.3.7 and 1.3.9. And no update of the composer.json for PHP version requirement.
Best regards,
Rui

@ruifil can you explain where the compatibility issue is happening ?


Correlations stopped working

Current Behaviour
Trying to create a profile with default settings, correlations do not work for some relatively simple data sets with the below error:
I think this issue started with 4.6.3 and is still the case for 4.6.4.
EDIT: I can confirm that downgrading to 4.6.2 solves the issue.
/home/ubuntu/.local/lib/python3.10/site-packages/ydata_profiling/model/correlations.py:66: UserWarning: There was an attempt to calculate the auto correlation, but this failed.
To hide this warning, disable the calculation
(using `df.profile_report(correlations={"auto": {"calculate": False}})`
If this is problematic for your use case, please report this as an issue:
https://github.com/ydataai/ydata-profiling/issues
(include the error message: 'Function <code object pandas_auto_compute at 0x7f34bdca3260, file "/home/ubuntu/.local/lib/python3.10/site-packages/ydata_profiling/model/pandas/correlations_pandas.py", line 164>')

Expected Behaviour
Correlations work
Data Description
Standard boston data set
Code that reproduces the bug
import pandas as pd
df = pd.read_csv("boston.csv")

from ydata_profiling import ProfileReport

profile_report = ProfileReport(df, title="profile")
profile_report.to_file("test.html")

pandas-profiling version
v4.6.4
Dependencies
pandas==2.1.4

OS
Ubuntu 22
Checklist

[X] There is not yet another bug report for this issue in the issue tracker
[X] The problem is reproducible from this bug report. This guide can help to craft a minimal bug report.
[X] The issue has not been resolved by the entries listed under Common Issues.

I was looking into this a bit as I was running into the issue. It's something with pandas going from 2.0.3 to 2.1.x. For ydata-profiling v.4.6.4 it works fine with pandas v2.0.3 but once you upgrade to pandas v2.1.x the autocorrelation stops working. Won't claim to know what in pandas is causing the break, but if you downgrade to pandas 2.0.3 it'll work again.

@driscoll42 good catch. I can confirm that the reason 4.6.2 works is that it pins pandas < 2.1. The below pr relaxed pandas pin and thus broke correlations.
https://github.com/ydataai/ydata-profiling/pull/1512

@aquemy @ricardodcpereira is there anything I can help?

Could it be to the newer pandas datatypes.  There are now nullable datatypes for string, float etc. with pandas.NA as missing values.

include the error message: 'could not convert string to float: `'positive''

Maybe after pandas 2.0, we need to add numeric_only = True in pandas.Dataframe.corr()
Changed in version 2.0.0: The default value of numeric_only is now False.

I believe this line will also have to be updated to this or its equivalent:
        method = (
            _pairwise_spearman
           if col_1_name not in categorical_columns and col_2_name not in categorical_columns
            else _pairwise_cramers
        )

Setting numeric_only = True and making the above change ensures the report renders with both categorical an numerical features; otherwise it throws a TypeError on categorical columns if they show up as col_1_name.


Comment tag search in sherlodoc

Thanks for the neat service! I recently noticed the appearance of sherlodoc, which doesn't seem to have a separate repository, so I'm opening this issue here.
It would be nice to also search by tags in documentation comments, e.g. @raise Not_found. I guess right now it just tries to find that from function names and returns nothing.

Thanks for the suggestion! Sherlodoc is still a bit shaky at this point to be released, but I was looking for some early feedback on what needed to be improved :)
You're right that it only searches in the Module.value names and types, and ignores the documentation comment at this point... but I was thinking of doing stemming for this natural language bit because I didn't anticipate the need for @raise. It actually sounds useful and easier to support than the real docstring search, I'll take a look when I get some time to work on it :)


BUG: Item destruction and duplication.

Minecraft 1.12.2
XNET 1.4.1
I was trying to bulk automate Refined Storage Solderers, so I had a network of 16 solderers each with an advanced connector attached, a crate, and a controller with one channel set up to extract stacks of iron from the crate every 10 ticks, and insert it in the top of the solderers (with max dest inventory #4); and a second channel set up to extract the results from the bottom of the solderers (which should be 1 for 1) and insert them back in the crate. I dumped 4 stacks of iron in... and got 1 stack of results, the remaining 3 stacks of iron had vanished.
I then added a second connector to the crate and set it as a low priority destination, so that if iron was failing to be inserted into the solderer for some reason, it would go back in to the crate. This time I got less than a stack back for 4 stacks of iron in.
Then, to eliminate the solderers, I replaced them with crates, but I made a mistake and forgot to disable the extract channel. This time I dropped 4 stacks of iron in, and quickly ended up with 234 stacks of iron in the main crate, 4 iron (as expected) in 14 of the target crates, and 64 iron in two of the target crates.

Forge version 2515 and now 2537
It gets weirder. So on further testing, if I distribute to crates, then I get 4 ingots in each crate, but when I remove the ingots from one crate they disappear from most of the rest.
Going back to the solderers, I again get 4 ingots in each solderer, but they convert to only 1 (or occasionally 2) printed processors, and they do so in 1 (or occasionally 2) operations. where as if I shift click 4 ingots into the solderer I get 4 printed processors in 4 operations as I expect.
So I am now very confused.
Something is definitely broken though.

So it looks to me as though if count is non-null for the inserter, then we are basically inserting the same ItemStack into every destination, given which this code at line 335 in ItemChannelSettings.java seems suspicious:
if (count == null) {
// If we are not using a count then we restore 'stack' here as that is what
// we actually have to keep inserting until it is empty. If we are using a count
// then we don't do this as we don't want to risk stack getting null (on 1.10.2)
// from the insertItem() and then not being able to set stacksize a few lines
// above this
stack = remaining;
}
I'm trying to work out how to get setup to build and debug mods, so the above is conjecture based on code inspection, but I hope it helps.

Thanks for the detailed report. I'll check it out soon

This is a "me too":
I had some items disappearing too but unfortunately don't know how to reproduce this.
Duplication, though, looks pretty consistent:

extract stack-wise from a container (IE storage crate) with 20 tick interval
insert with a 1 item limit into N different containers (Botania open crates), channel set to "priority"
what ends up being dropped are stacks of the items, rather than singles.

Does this also happen if you replace either the open crates and/or the storage crate with a vanilla or different container? Trying to see if the bug is actually in XNet

I comprehensively tested with Refined Storage Solderers and Actually Additions Storage Crates. I did a smaller test with chests and saw the same results in each case.

I cannot reproduce this at all. I need VERY detailed information on how to reproduce this. Preferably using only vanilla blocks as that makes it easier to debug

BTW this is how I tried:
https://i.imgur.com/hRla7YI.png
https://i.imgur.com/80fLGNZ.png
all chests

Maybe, try to add some extra checks in the places where such thing could possibly occur. I think it caused issues like that with your modular storages. I do not remember crafting 2 drawer keys.

This is not really doable. There are too many places and this is too complex to test like that

That's something I would be afraid of :s
Can you make a version which logs everything?

That's not the easy way to debug this. I need to be able to reproduce this. As soon as I can reproduce it then the problem is practically solved

The only other idea I have, is to fire up a world, and start playing with it. if you use it as the primary storage solution, it sould show up after 2-3 hours.

I have tried that already. What I need is more detailed exact descriptions and setups that I can replicate

Have you tried doing small modifications to the network, between tests? (can't take a picture now)
One edge case I could think is when the player is not yet sure how the wireing is going to happen, so he's constantly breaking and replacing the blocks.

I'm going to wait with this until I get a reproducable scenario. I doubt it has to do with random breaking and replacing of blocks

Haven't filed a report yet (expect it the next few days), but I did found that sometimes I need to break and replace the controller to get things behave.
One thing I forgot to add: I was using the rftools storage integration. That should have been one the first things to mention.
My setup is on a server, I can show it to you there or we can get the world packed up.

Hi,
I can reproduce this issue like this :

1 input chest, 4 output chest, 1 controller
I connect everything with connector/cable (https://imgur.com/a/RT03i)
Set the input chest to Extract/Stack (RR channel) (https://imgur.com/a/nondi)
Set output chests to Insert/only 1 item (https://imgur.com/a/2uT72)
Insert 4 items in the input chest (https://imgur.com/a/RbB1A)
Each output chest receive 1 item (https://imgur.com/a/I6b3a)

To reproduce the problem: Remove 1 item from any chest.
You'll get 1 item from the chest and the 3 others will be empty (https://imgur.com/a/mJNNV)
Minecraft version : 1.12.2
Forge : <IP_ADDRESS>62
Mods :

Xnet : 1.4.1
McJty : 2.5.0
ExtraUtilities (for power) : 1.6.8

I hope you have enough details.

Thanks! I will try that out soon

Ok I can reproduce this but that's VERY weird

Ok.  I fixed it for next release (soon). Thanks for the detailed report. That helped


activity is not found in project or libraies AndroidManifest.xml

    </activity>

issue
Class referenced in the manifest, com.theartofdev.edmodo.cropper.CropImageActivity, was not found in the project or the libraries
Unresolved package 'theartofdev'

please read https://github.com/ArthurHub/Android-Image-Cropper/issues/858
And update to the new repository