[WIP] EVM univ2 loadtest

Describe your changes and provide context
Testing performed to validate your change

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.90%. Comparing base (1f607e7) to head (32a101a).
 Consider uploading reports for the commit 8735cbe to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##            seiv2    #1414      +/-   ##
==========================================
- Coverage   62.96%   62.90%   -0.06%
==========================================
  Files         350      350
  Lines       23895    23898       +3
==========================================
- Hits        15045    15034      -11
- Misses       7986     8006      +20
+ Partials      864      858       -6

see 7 files with indirect coverage changes


Integration with react-native

Please is it possible for this package to be integrated in react native, I really need the package to send SMS programmatically and verified if it was successfully delivered or failed due to insufficient airtime balance, bad cellular network coverage etc,
If it is possible to integrate with react-native can, you assist me with how it can be configured to achieve this. Thanks

As react-native is another way to create native apps a CapacitorJS Plugin will not work. You need sth React Native specific afaik.


upgrade and clean crashplan for small business

Motivation for this change
The package for crashplan 6.6.0 has been removed from its location, breaking the package unless it's upgraded.
Things done
Removed unneeded code from the crashplan for small business service and upgraded the crashplan pkg from 6.6.0 to 6.7.0

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

/cc @joachifm


hide hold for archived workspace

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/50352
PROPOSAL: https://github.com/Expensify/App/issues/50352#issuecomment-2397752400
Tests

Go to workspace chat

Submit an expense

Delete the workspace

Go to Search

Select the expense in Step 3 via checkbox

Click on the dropdown

Verify that there is no hold or delete option

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Go to workspace chat

Submit an expense

Delete the workspace

Go to Search

Select the expense in Step 3 via checkbox

Click on the dropdown

Verify that there is no hold or delete option

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

The issue is fixed, but while testing on smaller devices, I noticed that even when the expense is from an archived workspace, the hold and delete options are still visible for a short time. That's why the dropdown still shows the hold and delete options when selecting an expense on the search page. They disappear after a while.
https://github.com/user-attachments/assets/8ba3777d-9d66-4d0c-aabe-d64e6af50f45

@Gonals In this PR, we were supposed to hide the hold/delete options in search for expenses from archived workspaces. However, something recently changed, and these expenses are no longer marked as archived, which is allowing users to delete and hold them. Could you confirm the expected behavior?

Asking around to see if this change was on purpose and what the expectations are

@Gonals In this PR, we were supposed to hide the hold/delete options in search for expenses from archived workspaces. However, something recently changed, and these expenses are no longer marked as archived, which is allowing users to delete and hold them. Could you confirm the expected behavior?

Asking around to see if this change was on purpose and what the expectations are

It seems we stopped archiving them, but we were going to archive them again, so you may want to give it a try and see how it looks now


readme updated with proper documentation for running in linux

Can you please explain what changes you have made @nityanandagohain ?

i have added the prerequisites in the documentation which are need in linux .

You have just changed python benji.py to python 3 benji.py. That is just for python 3. I don't think we require this :smile:

plus i have add other things such as espeak,pyttsx3,libasound-dev, portaudio19-dev, libportaudio2, libportaudiocpp0 ,ffmpeg ,libav-tools

I understand that but the libraries you mentioned are already present in the requirements.txt. B.E.N.J.I. is working on that. I don't think we require any more libraries. :smile:

okey then  i am closing this pr ... :)

@nityanandagohain , you can solve other good first issues! They can help you get going

Sure thanks !


'Compiler Features' section overlaps with Unstable Book

The Unstable Book is going to document all the currently unstable features. Is it worth keeping the content in this section around? https://doc.rust-lang.org/nightly/reference/attributes.html#compiler-features
Relevant issue: https://github.com/rust-lang-nursery/reference/issues/9

I don't think it is. There was nowhere else to put this before, but now there is.


symfony 3.1 deprecations must be fixed

Remaining deprecation notices (3)
Not quoting the scalar "%doctrine_set_type.set_type_guesser.class%" starting with the "%" indicator character is deprecated since Symfony 3.1 and will throw a ParseException in 4.0: 1x
1x in AppKernel::boot
Not quoting the scalar "%doctrine.dbal.connection_factory.types%" starting with the "%" indicator character is deprecated since Symfony 3.1 and will throw a ParseException in 4.0: 1x
1x in AppKernel::boot
Not quoting the scalar "%doctrine_set_type.set_type.class_name%" starting with the "%" indicator character is deprecated since Symfony 3.1 and will throw a ParseException in 4.0: 1x
1x in AppKernel::boot

`diff --git a/Resources/config/services.yml b/Resources/config/services.yml
index f553d8c..5d5d5f4 100644
--- a/Resources/config/services.yml
+++ b/Resources/config/services.yml
@@ -4,7 +4,7 @@ parameters:
services:
doctrine_set_type.set_type_guesser:

   class: %doctrine_set_type.set_type_guesser.class%

   arguments: ["@doctrine", %doctrine.dbal.connection_factory.types%, %doctrine_set_type.set_type.class_name%]

   class: "%doctrine_set_type.set_type_guesser.class%"

   arguments: ["@doctrine", "%doctrine.dbal.connection_factory.types%", "%doctrine_set_type.set_type.class_name%"]
   tags:
       - { name: form.type_guesser }

`


API Remove reference HistoryControllerFactory.

Fix https://github.com/silverstripe/silverstripe-versioned-admin/issues/67 and https://github.com/silverstripe/silverstripe-cms/issues/2277

I'm not convinced that we should do this in the 3 branch. The 4 branch will be released soon(-ish) and we can remove it from that line (it has 4.3 as a minimum requirement), but the 3 line can still run with 4.2 that would benefit from this code.

It depends on the constraint in this module. 3.x will still work on SS 4.3

Yeah but people using the latest version of the 3 branch on 4.2 would no longer have the new page history viewer with this patch.

Cool ... I brought back the YML config and tweaked the logic to return void instead of false. I think we're better off waiting until the versioned-admin PR is merged before merging this one. Removing HistoryControllerFactoryExtension from 4 can wait until the 4.3 release is out the door.


Fixed test failing due to changes in AnnotationReader

Doctrine\Tests\ORM\Mapping\AnnotationDriverTest::testLoadMetadataForNonEntityThrowsException
Argument 1 passed to Doctrine\Common\Annotations\AnnotationReader::__construct() must be an instance of Doctrine\Common\Annotations\DocParser, instance of Doctrine\Common\Cache\ArrayCache given, called in .../tests/Doctrine/Tests/ORM/Mapping/AnnotationDriverTest.php on line 19 and defined

See: https://revive.beccati.com/bamboo/browse/PHP-DOCTR-PHP55-646/test/case/11813971

Thanks @mbeccati!


Upgrade to Pillow >8.1.0 for better security

Dependabot is complaining about a security hold in an older version of Pillow.

Pillow 8.2.0 is in for the next release.

We still have a problem with Pillow because it is used in the docs requirement at:
svmbir/docs/requirements.txt
Can we change:
Pillow~=8.1.0
to
Pillow~=8.2.0
without changing the version number of the code?
I think this should be OK since the docs requirements only effect the documentation and not the actual svmbir algorithm.

Implemented fix on svmbir/docs/requirements.txt

If possible, we should update the requirement.txt file to

Pillow~=8.3.2

I've been getting the following warning from Dependabot:
CVE-2021-23437
high severity
Vulnerable versions: < 8.3.2
Patched version: 8.3.2
The package pillow from 0 and before 8.3.2 are vulnerable to Regular Expression Denial of Service (ReDoS) via the getrgb function.


🐛 fixed error message code for HB translate helper

Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
#15500 - Ghost has a policy to never throw 500 Internal Server errors for theme issues. Updated error handing to return a 400 error and a better error message "Oops, seems there is an error in the template."
This change adds a check inside of ghost\core\core\frontend\helpers\t.js if text or options is undefined, to throw an IncorrectUsageError error within the function.
Messaging was borrowed from ghost\core\core\frontend\web\middleware\error-handler.js.

Steps to Reproduce

Open the default.hbs file of the current active theme
Paste in the example translate helper with smart quotes {{t “This causes an error”}}
Try to visit any page
See the 400 error in the logs

[ghost] [2022-10-05 03:02:34] ERROR "GET /" 400 401ms
[ghost]
[ghost] [default.hbs] Oops, seems there is an error in the template.
[ghost]
[ghost] Error ID:
[ghost]     28e7d1e0-445a-11ed-adf2-afe89389d316
[ghost]
[ghost] ----------------------------------------
[ghost]
[ghost] IncorrectUsageError: [default.hbs] Oops, seems there is an error in the template.
[ghost]     at Object.t (C:\projects\Ghost\ghost\core\core\frontend\helpers\t.js:23:15)
[ghost]     at Object.wrapper (C:\projects\Ghost\node_modules\handlebars\dist\cjs\handlebars\internal\wrapHelper.js:15:19)
[ghost]     at Object.eval [as main] (eval at createFunctionContext (C:\projects\Ghost\node_modules\handlebars\dist\cjs\handlebars\compiler\javascript-compiler.js:262:23), <anonymous>:54:92)
[ghost]     at main (C:\projects\Ghost\node_modules\handlebars\dist\cjs\handlebars\runtime.js:208:32)
[ghost]     at ret (C:\projects\Ghost\node_modules\handlebars\dist\cjs\handlebars\runtime.js:212:12)
[ghost]     at ret (C:\projects\Ghost\node_modules\handlebars\dist\cjs\handlebars\compiler\compiler.js:519:21)
[ghost]     at renderTemplate (C:\projects\Ghost\node_modules\express-hbs\lib\hbs.js:490:13)
[ghost]     at _stackRenderer (C:\projects\Ghost\node_modules\express-hbs\lib\hbs.js:519:9)
[ghost]     at renderTemplate (C:\projects\Ghost\node_modules\express-hbs\lib\hbs.js:499:5)
[ghost]     at render (C:\projects\Ghost\node_modules\express-hbs\lib\hbs.js:526:5)
[ghost]     at renderIt (C:\projects\Ghost\node_modules\express-hbs\lib\hbs.js:588:18)
[ghost]     at C:\projects\Ghost\node_modules\express-hbs\lib\hbs.js:598:11
[ghost]     at _returnLayouts (C:\projects\Ghost\node_modules\express-hbs\lib\hbs.js:124:7)
[ghost]     at C:\projects\Ghost\node_modules\express-hbs\lib\hbs.js:135:7
[ghost]     at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:68:3)
[ghost]

Ghost Version
5.17.x
I know the original issue stated v4.42.1, but I was consistently able to reproduce the issue in this version as well. If there is a need for that version as well, I am happy to investigate that as well.
When {{t “This causes an error”}) is used, text is coming into the t() function as undefined. I'm using Windows - unsure if that's causing something different as well, since someone else reported it was working fine in the issue.

[x] There's a clear use-case for this code change, explained below
[x] Commit message has a short title & references relevant issues
[x] The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!
Also, if you'd be interested in writing code like this for us more regularly, we're hiring:
https://careers.ghost.org

Hi @cweave thanks so much for this PR and I'm sorry for taking so long to review it - we got a bit inundated.
The PR has now been merged 🎉 and will appear in the next release of Ghost - usually Fridays.
I'm not sure if you found this through hacktoberfest, but I've added the accepted label to this PR to make sure it counts.
If you'd like to take this further, I'd love to see a unit test added here for the underlying bug to ensure this can't happen again.

Thanks, @ErisDS ! I did indeed find it via Hacktoberfest. I'll take a look at unit testing as well ☺


docs: fix invalid links

fixes links on http://docs.hood.ie/en/latest/api/client/hoodie.html page

no problem, thanks for merging


Periodical auto deploys.

It would be nice to have and Github action that would release the package with refreshed data every month.

wow, quite a backstory! anyway, closed as done :)


IDs fix

Destructuring React refs results in mutable ref values under some scenarios. This change fixes that.

This will do for now but there is an underlying issue with our approach that won't work for isomorphic or SSR application. I'll open a separate issue about that since I do not yet fully understand the issue.


Access content before rendering?

I need to be able to manipulate the raw content (in this case markdown) of an article before it's rendered. Normally this would probably be done at the markdown renderer level, but for a variety of reasons that's not possible/practical.
I cannot figure out where to hook into. after_configuration seems to be too early. before seems to be too late. Is what I want to do even possible?

Nevermind, I was able to figure out a better way to do what I wanted.


Add SETTINGS__SKYLIGHT__ENABLE env variable

Context
Add SETTINGS__SKYLIGHT__ENABLE environment variable in Arm template, which will enable skylight tracing
Changes proposed in this pull request
set SETTINGS__SKYLIGHT__ENABLE environment variable in Arm template
Guidance to review
Checklist

[x] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[ ] Tested by running locally

@felixtheflex I've set this in the code so we might not need it. https://github.com/DFE-Digital/teacher-training-api/pull/1593

Skylight is working in production so this PR is not needed.
@felixtheflex could you close this?

PR no longer required... functionality would be moved into application's config file.


Flat Textures

After updating to the most recent version (1.0.1), All items in my hands and in other players have become flat.

Reloading Textures or Changing Texture packs does not fix it.

Hello, did you update from 1.0.0 or 0.1.11? If you updated from 1.0.0 did you have the problem then? 1.0 has been taken down because I by accident shipped Optifine with the modpack so when you updated from 1.0.0 to 1.0.1 optifine may have been removed and you need to download it again.

Fixed in the 1.0.2 update. It was caused by FoemFix it is a mod that is supposed to lower memory usage but it looks like it makes the textures in your hand flat also. I have removed the mod for now.

I'm pretty sure the issue is caused by TexFix because it's still the case in the later version of the modpack.

I'm pretty sure the issue is caused by TexFix because it's still the case in the later version of the modpack.

Can you show pictures. I don't have a problem after I remove fomfix. Dose the texture get fixed if you remove texfix.

First is with the mod, and second is without it

Fixed in 1.1.3 removed texfix and readded FomFix.


feat: support Decompile in Dedaub on BSC

Dedaub already fully supports Binance Smart Chain (BSC). This commit adds the BSC pathname (binance) to the DEDAUB_SUPPORT_DIRECT_LIST, enabling direct redirection to https://app.dedaub.com/binance/address/*.
Before:

After:

Thanks a ton for your PR! Really appreciate your hard work. I'll check it out and get to it in the next few days.


Dead keys not being handled

Lapce Version
0.2.0
System information
Arch linux
Describe the bug
The key related to key code 48 is not being handled by text editor. It is also not being handled by builtin terminal.
The number 48 was extracted using the command "xinput test":
key press 48
key release 48

Additional information
In the keybindings settings dialog, when I press 48, I get the name "Dead" for the key:

If I assign the key 48 to the command palette command, when I press the key 48, the command palette does open.
Remarks: On my keyboard, which is english qwerty layout, key code 48 refers to double quote / single quote.

Upon further investigation I understand now that the problem is lack of dead keys handling. If a dead key is pressed, nothing happens. Nothing specific about "key code 48" but it being a dead key on my keymap.
Workaround: to change the keymap to a layout without dead keys.
Related issue: https://github.com/lapce/lapce/issues/530

More information, this seems to be related to the feature of dead key preview:
https://gitlab.gnome.org/GNOME/gtk/-/issues/3815

I have the same problem on MacOS with US keyboard + Dead Keys.

I have the same issue on Arch Linux with an US keyboard set to US intl.
It does seem like the editor is simply not handling dead keys at all, they don't even enter the characters on the key.

here with Lapce v0.2.1 over 5.19.0-2-amd64 #1 SMP PREEMPT_DYNAMIC Debian 5.19.11-1 (2022-09-24) x86_64 GNU/Linux hitting same issue with key `

Same here. Happening with single and double quotes, and tilde and backtick.
I'm currently using a 66% keyboard configured as En(intl)+deadkeys .
Love the idea of using Lapce as my main code editor, but it's plainly useless without the capability of typing a single or double quote.

The issue is in the Druid UI toolkit. Lapce inherited this issue.

I'm experiencing the same issue here, which is unfortunate as I really liked the overall experience of Lapce...
I hope Druid UI fixes this in linebender/druid/issues/1040. Subscribing here to get notified.

Is Druid still being used in the nightly builds, or is some kind of changed handling in Floem victim to the same problem as the old codebase?

Latest lapce release doesn't use Druid anymore, it's Floem and keyboard events are provided by Winit.

I was going to post an edit, but that was a surprisingly fast response.
A friend of mine that's much more knowledgeable about key handling than me is looking through Winit now and they're drawing the conclusion that Winit is breaking stuff here by calling ToUnicode a second time on dead keys. I'll try and see if this can be sorted on that end

Uh, false alarm there, the code I was looking at did call ToUnicodeEx, but turned out to be using it to inspect keyboard layouts rather than processing actual input. I haven't managed to find where the actual input processing is messed up (it appears to call TranslateMessage in the main loop, which should just work unless something else is calling ToUnicode somewhere)

ok, after installing lapce myself (i know, lazy), i observed the following:

contrary to my interpretation of reports, actual accented letters entered via the US-Intl layout dead keys on windows work fine
dead key + space enters nothing
dead key + other dead key enters nothing
dead key + letter with no corresponding accent enters only the letter.

All expected WM_CHAR messages do get generated (presumably by winit's call to TranslateMessage)

The above image is the event sequence from typing '''a'b, which results in only the text áb being typed in to the file [each on the respective letter keydown], not ''á'b as expected.
The WM_CHAR messages for the ' character do have the lparam flag 02000000 set, which may be an undocumented [other flags in this value are documented at https://learn.microsoft.com/en-us/windows/win32/inputdev/about-keyboard-input#keystroke-message-flags, 0x0200 is missing from this table] flag intended for this scenario, but the second one in the '' sequence and the one generated by '<space> does not have this set, but are still ignored.

I think I have finally figured out what is going on.
The keypress function https://github.com/lapce/lapce/blob/592cbc7b6f672d2ee56447668a25a271d05877bb/lapce-app/src/keypress.rs#L181 is discarding the text from the event, leaving its caller (key_down https://github.com/lapce/lapce/blob/592cbc7b6f672d2ee56447668a25a271d05877bb/lapce-app/src/keypress.rs#L201) to infer characters from only the key being a Key::Character or NamedKey::Space (I am still unsure why this means it discards doubled dead keys or why accented characters work, but this is the only thing that can explain a space character being entered when a dead key is followed with the spacebar) The entire key_down function will have to be rewritten.
It is worth mentioning that (assuming that winit supports it correctly) KeyUp events can also have text, in the case of the event corresponding to Alt being released after entering an alt+numpad code. Other event handlers further up the chain may need to be reworked to accommodate this, if support for windows native alt+numpad codes is desired.

I have a basic fix that seems to work, replacing the contents of the if mods.is_empty() block with
            if let EventRef::Keyboard(keyevent) = event {
                if let Some(text) = &keyevent.key.text {
                    focus.receive_char(text.as_str());
                    self.count.set(None);
                    return true;
                }
            }

[and into-ing the event at the top of the function, since otherwise it can't be used both here and in the call to keypress], but I only have the ability to test it on Windows, and it also seems like a bit of a messy solution since fundamentally the problem is that the KeyPress type does not retain the text from the winit/floem keydown event, and I am not sure whether it should or not or even why this KeyPress type exists at all.

Happens to me on Win11, too

This should be fixed via https://github.com/lapce/lapce/pull/3119

Which is part of 0.4.0 so please test this and report any issues


How to extract the .egg file in DIML dataset?

Hello, thanks for sharing the code.
I downloaded the DIML dataset., but I cannot open the .egg format file. How did you decompress this file format?
I tried the unzip command, but it didn't work

Hi, did you download the indoor data sample? It consists of two files "indoor_train.zip" and "indoor_test.zip", and there should be no .egg files. Let me know in case you don't get it to work!

Ah, I actually downloaded the content from these folders: https://drive.google.com/drive/folders/1OsuHBrtstN_lBhUHcpqqNEIo1rCUczYo?usp=sharing
I thought this was the complete dataset and your approach needed all those images. So, only the sample data is sufficient?

Exactly, we use the indoor sample subset for our project. All the images are contained within the "indoor_train.zip" and "indoor_test.zip" files.


Update psycopg2 patch version to update native library

Hi! Thank you so much for maintaining this great tool 😄 I ran into an issue running pgsync in my Mac with an M1 chip. It seems that version 2.9.5 of psycopg2-binary when precompiled for ARM includes an older version of libpq which creates problems when used with certain versions of Postgres. The issue I was seeing has been well documented here and should be fixed in 2.9.6. I've updated the version here to match that.
If there are any issues, please let me know!

Closing as it looks like this was addressed here


Saving fails when some of the nodes is not found

I'm having trouble saving different change sets. The browser launches a GET request to OSM API for the nodes I've edited, but apparently some of them is not found?
http://www.openstreetmap.org/api/0.6/nodes?nodes=3492811281,3492811281,3492811286,3492811286,3492811312 returns 404.
This prevents me from saving. ID-editor says "Errors occurred while trying to save: Server returned status code 404"
In one case I had over 50 changes that could not be saved. It turned out that only one building blocked the save, and once deleted I could redo the edits and save them successfully. It would have been nice if the other edits could have been saved without redoing them.

Actually now that I look at the GET request, it seems some of the IDs are duplicated. If I remove the duplicated IDs, the request works.

Thanks for the report and for figuring out the issue so quickly!  I'll push out a fix for this asap.

@bhousel: I'm curious if this could / should also be fixed in the API? I'm not 100% how a REST API should behave when asked same IDs multiple times in one request. My gut feeling is that it could return each unique element once, but I'm not sure if it would break something.

I'm curious if this could / should also be fixed in the API? I'm not 100% how a REST API should behave when asked same IDs multiple times in one request.

Yeah it's definitely not what I would expect the API to do :)
I'll put the quick fix into iD, and if I have time I'll fix it there too and reference this issue.

(see #2628 for temporary workaround that should allow saving)

regardless of the changes in https://github.com/zerebubuth/openstreetmap-cgimap/commit/0d62c3228a8bfa53b0c390cecfd5504d6ee3f53f it's probably best to keep de-duplicating in iD to cut down on the HTTP requests needed for long lists of nodes

regardless of the changes in zerebubuth/openstreetmap-cgimap@0d62c32 it's probably best to keep de-duplicating in iD to cut down on the HTTP requests needed for long lists of nodes

Yes, definitely agree.  I even think we should up the chunk size here for browsers that we know support longer urls.  I chose 150 conservatively to fit the url under 2MB. See also


Mobile responsive: Avatar doesn't show in comment conversation

Expected behavior
Avatar shows next to each comment.

Actual behavior
Avatar shows only next to the first comment in comment conversation for each user on mobile (screen/window width smaller than 768px).

How to reproduce

Go to<EMAIL_ADDRESS>or /utopian-io/@elear/utopian-now-pays-moderators-in-steem-power-profit-by-assuring-quality on mobile
See comments
Check on desktop that avatars show next each comment

Browser: Brave
Operating system: Android 7.1.2
Model: Moto G3 2015

This has been fixed in #969.


Cancel button shows Chinese characters, can we modify the text of the cancel button?

I found that "Cancel" button is always attributed with Chinese characters. What if we want to implement an international solution using LCActionSheet? At the present, I implemented it in this way:
- (NSString *)cancelText
{
    if (_cancelText) {
        return _cancelText;
    }

    _cancelText = NSLocalizedString(@"cancel", nil);
    return _cancelText;
}

Thus, I suppose that it's better to provide a function for modifying the text of cancel button.

I see, thank you! But I'm a little busy now (Spring Festival is coming you know, and the company work...), you could submit a PR to this project if you have time, thanks again :)

Sorry, I finally found that the lib provided a property 'cancelText', it's plausible to modify the text of cancel button. It's no need to PR. Anyway, thank you for your patience.
The issue can be closed now.


Bump org.apache.avro:avro from 1.11.3 to 1.12.0 in /plugins/repository-hdfs

Description
Bumps org.apache.avro:avro from 1.11.3 to 1.12.0.
Replacement for https://github.com/opensearch-project/OpenSearch/pull/15109 to fix failure in ./gradlew :plugins:repository-hdfs:thirdPartyAudit
Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks mind please backport manually? thank you!

Raised a manual backport: https://github.com/opensearch-project/OpenSearch/pull/15121


Only output number of executed instructions in swift-parser-cli on macOS

libproc.h is not available on iOS and I’m not sure how it behaves on Linux. Since swift-parser-cli is only a testing utility, take the safe approach and only output the number of executed instructions on macOS.

@swift-ci Please test


Help popup in Achievements: Link to tips

In each of the help popups, it would be great to have a link that a wiki page that explains things much more deeply.
For instance the help popup for "Featured Images" could link to https://commons.wikimedia.org/wiki/Commons:Featured_picture_candidates or https://commons.wikimedia.org/wiki/Commons:Featured_pictures

@nicolas-raoul I would like to work on this.

It is a simple enough change. Adding good-first-issue tag.
@yashk2000 assigned the issue to you.

@maskaravivek you can re-assign this issue to someone else. I think it will be better for a newcomer hoping to make their first contribution.

@maskaravivek may I work on this issue as well along with other achievements issue?
Both of them would be a good combo :p

Sure. Take it up @TejaswiKarasani. Make sure to create separate PRs for both the fixes.

Ok @maskaravivek :)

@nicolas-raoul @maskaravivek
Could you able have a look over the links that I have collected for resolving this issue?
Images uploaded:
https://commons.wikimedia.org/wiki/Commons:Upload
https://commons.wikimedia.org/wiki/Commons:First_steps/Uploading_files
https://en.wikipedia.org/wiki/Wikipedia:Image_use_policy
https://commons.wikimedia.org/wiki/Commons:Fair_use
Images that were not reverted
https://commons.wikimedia.org/wiki/Commons:Fair_use
https://en.wikipedia.org/wiki/Wikipedia:Image_use_policy
https://commons.wikimedia.org/wiki/Commons:Deletion_policy
https://commons.wikimedia.org/wiki/Commons:Deletion_requests
Images used
https://commons.wikimedia.org/wiki/Commons:Quality_images
https://commons.wikimedia.org/wiki/Commons:Featured_pictures
Images via "Nearby Places"
Couldn't find anything related
Featured Images
https://commons.wikimedia.org/wiki/Commons:Featured_picture_candidates or https://commons.wikimedia.org/wiki/Commons:Featured_pictures
Thanks Received
https://en.wikipedia.org/wiki/Help:Notifications/Thanks
https://meta.wikimedia.org/wiki/Research:Understanding_thanks

... may I also know about the number of links should be included in pop up?

IMO, in the the ideal case it would be great if we could just link to only one most relevant resource. That would make it easy for the users to quickly the related information.

... may I also know about the number of links should be included in pop up?

IMO, in the the ideal case it would be great if we could just link to only one most relevant resource. That would make it easy for the users to quickly the related information.

@sivaraam ok 👍

Hello! is this fixed? If not is possible to work on it?

@TejaswiKarasani Thanks a lot for finding all of these links! Are you still working on this? If not we can let @gerardolgvr continue the work :-)
I agree with sivaraam that one link per topic is best. I suggest the following:
Images uploaded: https://commons.wikimedia.org/wiki/Commons:Project_scope
Images that were not reverted: https://commons.wikimedia.org/wiki/Commons:Deletion_policy#Reasons_for_deletion
Images used: https://en.wikipedia.org/wiki/Wikipedia:Manual_of_Style/Images
Images via "Nearby Places": https://www.wikidata.org/wiki/Property:P18 (not great but best I have found)
Featured Images: https://commons.wikimedia.org/wiki/Commons:Featured_pictures
Thanks Received: https://www.mediawiki.org/wiki/Extension:Thanks

Please assign this issue to any other.
Thanks.

Thanks @TejaswiKarasani for your work and have a great weekend :-)
@gerardolgvr this task is yours from now on :-)

Thanks! I'm gonna work on it.
Have a great weekend! Any update or question I'm gonna post it here  :)

I added a new menu item in order to access the pop up. A list is used to show the item using the link you mentioned above. Before to continue I would like to ask about this:

Is ok the pop up is accessed via menu like the image?  (I was finding a good place and a menu item seems a well place and it not affects the semantic of UI elements). If this is approved I was thinking in create a new menu to no affect the other activities that uses the same menu.
Just to confirm, All the new strings that I'm gonna use must be accessed from String.xml, Am I right?
The last one, the intent for the link must be open inside the app?

These are the pictures to know if this is that you have in mind. If not to do the necessary adjustments

@gerardolgvr It would be easier to find if each link was inside the information popup attached to it.
For instance when you tap on the "i" at the right of "Thanks Received", it opens a popup. That popup would contain its current explanation, plus a "Read more" link at the bottom which opens the given web page.
Thanks! :-)

@nicolas-raoul ohhh, I got it! All makes sense now jeje.  Thanks for the explanation

Hello @nicolas-raoul  I'm trying to run the tests but I got this:

Is there a config or a setting that I'm not doing?

@gerardolgvr because these androidTests are not run on our CI or checked in any way it is very easy for them to get broken and for nobody to realize. The compilation is failing due in no way to your changes and it seemingly has 15 errors

Thanks @macgills , good to know about it.
I'm gonna try to research more about it and look for a solution

I would make a new issue "Fix Instrumentation tests", generally when we ask for tests what is meant is unit tests because those do get run on the CI. The functionality you added however is mostly in an Activity, a quite annoying to unit test class

ohh , good idea.
Yeah, it makes sense

Hi, @macgills @nicolas-raoul I would like to work on this issue. If It is still open. Can I?

@Ayan-10 No news from gerardolgvr for 10 months, so I guess yes. Thanks!

Hey @nicolas-raoul , Thanks for assigning me.
I make two buttons in alert dialogue which is "READ MORE" and "OK". If user clicks the "READ MORE" button. It will open a webpage and by clicking "OK" dialogue got cancelled. I am attaching a screenshot here.

I also thought about open the webpage in a custom chrome tab.
So, this is how I thougth to solve this issue. Let me know your thought about this solution. Should I go forward with that or Do you have any preference or any other recommendation? You can tell me.

"READ MORE"/"OK" looks good :-) You can go forward with a pull request.


cmd/link: bad debug_info on macOS 10.12.1 when using cgo (but only under very specific circumstances)

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.7.3 darwin/amd64

What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/vagrant/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rm/ywx69srx1kq_dtjz2ynznn000000gp/T/go-build432262881=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"

What did you do?
I can't figure out a simpler way to reproduce this:
$ go get github.com/derekparker/delve
$ cd $GOPATH/src/github.com/derekparker/delve/_fixtures
$ go build -gcflags='-N -l' ./cgotest.go
$ cd $GOPATH/src/github.com/derekparker/delve/proc
$ go build -gcflags='-N -l' ../_fixtures/cgotest.go
$ gobjdump --dwarf $GOPATH/src/github.com/derekparker/delve/_fixtures/cgotest | grep -B1 -A5 -e 'goid$'
$ gobjdump --dwarf $GOPATH/src/github.com/derekparker/delve/proc/cgotest | grep -B1 -A5 -e 'goid$'

(gobjdump is GNU objdump)
What did you expect to see?
The same output from both gobjdump | grep.
What did you see instead?
When I compile cgotest.go while I'm in the same directory cgotest.go is I get:
 <2><20313>: Abbrev Number: 11 (DW_TAG_member)
    <20314>   DW_AT_name        : (indirect string, offset: 0xc358): goid
    <20318>   DW_AT_data_member_location: 3 byte block: 23 c0 1 	(DW_OP_plus_uconst: 192)
    <2031c>   DW_AT_type        : <0x1f3e0>
 <2><20324>: Abbrev Number: 11 (DW_TAG_member)
    <20325>   DW_AT_name        : (indirect string, offset: 0xc35d): waitsince
    <20329>   DW_AT_data_member_location: 3 byte block: 23 c8 1 	(DW_OP_plus_uconst: 200)

When I compile cgotest.go by specifying ../_fixtures/cgotest.go I get:
 <2><20173>: Abbrev Number: 21 (DW_TAG_member)
    <20174>   DW_AT_name        : (indirect string, offset: 0xc353): goid
    <20178>   DW_AT_data_member_location: 3 byte block: 23 c0 1 	(DW_OP_plus_uconst: 192)
 <2><2017c>: Abbrev Number: 21 (DW_TAG_member)
    <2017d>   DW_AT_name        : (indirect string, offset: 0xc358): waitsince
    <20181>   DW_AT_data_member_location: 3 byte block: 23 c8 1 	(DW_OP_plus_uconst: 200)
 <2><20185>: Abbrev Number: 12 (DW_TAG_member)

Note how the DW_AT_type attribute of goid is gone. The output of -x is identical in both cases.

/cc @ianlancetaylor @randall77

I can't recreate this on amd64 GNU/Linux using either Go 1.7 or tip.

@aarzilli The DWARF generation is very different on tip than in 1.7, as it has moved from cmd/link to cmd/compile.  Would it be possible for you to reset this using tip?

I can't recreate this on amd64 GNU/Linux using either Go 1.7 or tip.

Yes, the macOS 10.12.1 part of the bug description is a necessary precondition.
I can't reproduce this on tip, looks like some of the changes to dwarf must have fixed it (or prevented it from triggering in this circumstance).


MAP_CLICK triggering when drag

@I'm submitting a ...  (check one with "x")

[ ] question
[X] any problem or bug report
[ ] feature request

If you choose 'problem or bug report', please select OS:  (check one with "x")

[ ] Android
[X] iOS

cordova information:  (run $> cordova plugin list)
com.googlemaps.ios 2.5.0 "Google Maps SDK for iOS"
com.phonegap.plugins.nativesettingsopener 1.2 "Native settings"
cordova-android-play-services-gradle-release 1.2.0 "cordova-android-play-services-gradle-release"
cordova-plugin-actionsheet 2.3.3 "ActionSheet"
cordova-plugin-apprate 1.2 "AppRate"
cordova-plugin-camera 2.4.1 "Camera"
cordova-plugin-certificates 0.6.4 "Certificate Plugin"
cordova-plugin-compat 1.2.0 "Compat"
cordova-plugin-datepicker 0.9.3 "DatePicker"
cordova-plugin-device 1.1.6 "Device"
cordova-plugin-dialogs 1.3.3 "Notification"
cordova-plugin-facebook4 1.9.1 "Facebook Connect"
cordova-plugin-geolocation 2.4.3 "Geolocation"
cordova-plugin-globalization 1.0.9 "Globalization"
cordova-plugin-googlemaps 2.2.4-beta-20180207-1925 "cordova-plugin-googlemaps"
cordova-plugin-inappbrowser 1.7.1 "InAppBrowser"
cordova-plugin-nativestorage 2.0.1 "NativeStorage"
cordova-plugin-spinner-dialog 1.3.1 "SpinnerDialog"
cordova-plugin-splashscreen 4.0.3 "Splashscreen"
cordova-plugin-statusbar 2.2.3 "StatusBar"
cordova-plugin-whitelist 1.3.2 "Whitelist"
phonegap-plugin-push 1.8.1 "PushPlugin"
russi-device-accounts 1.0.27 "Device Accounts"
russi-plugin-dialogs 1.2.7 "Notification"
uk.co.workingedge.phonegap.plugin.launchnavigator 4.0.7 "Launch Navigator"

Current behavior:
When I try to drag map to navigate in map, the MAP_CLICK is triggered
Expected behavior:
The map should to be dragged

Fix: Please reinstall the plugin from the multiple_maps branch.
For this time, please reinstall the maps iOS SDK plugin also.
$> cordova plugin rm cordova-plugin-googlemaps
$> cordova plugin rm com.googlemaps.ios
$> cordova plugin add https://github.com/mapsplugin/cordova-plugin-googlemaps#multiple_maps --variable ...

I am having this issue back again with the new update from multiple_maps branch. Thanks

@shrijan Please make an example, because the current multiple_maps branch does not use the same implementation as the master branch. So it should be impossible to reproduce the issue with the multiple_maps branch.

Sorry my mistake i was using wrong version of file.  Thanks


chore(deps): update docker/login-action action to v3.1.0

This PR contains the following updates:

Package
Type
Update
Change

docker/login-action
action
minor
v3.0.0 -> v3.1.0

Release Notes

docker/login-action (docker/login-action)
v3.1.0
Compare Source

build(deps): bump @babel/traverse from 7.17.3 to 7.23.2 in https://github.com/docker/login-action/pull/618
build(deps): bump @docker/actions-toolkit from 0.12.0 to 0.18.0 in https://github.com/docker/login-action/pull/616 https://github.com/docker/login-action/pull/636 https://github.com/docker/login-action/pull/682
build(deps): bump aws-sdk dependencies to 3.529.1 in https://github.com/docker/login-action/pull/624 https://github.com/docker/login-action/pull/685
build(deps): bump http-proxy-agent to 7.0.2 in https://github.com/docker/login-action/pull/676
build(deps): bump https-proxy-agent to 7.0.4 in https://github.com/docker/login-action/pull/676
build(deps): bump undici from 5.26.5 to 5.28.3 in https://github.com/docker/login-action/pull/677

Full Changelog: https://github.com/docker/login-action/compare/v3.0.0...v3.1.0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Improve disciplines API endpoint

Short description

Improve disciplines API endpoint
Proposed changes

Return all disciplines, not only leaf nodes
Filter by API key instead of given group id
Enable detail view to get single records

Resolved issues

Fixes: #307

Nice work :-) the disciplines endpoint was deprecated before. We eventually should update our readme before merging

Good point, I updated the README.


Depmap

Slightly simplifies code for DepMap creation; adds new utility function rx.cellToMap which creates a DepMap object.

use omnibus


//tensorflow/python:bfloat16_lib' failed (Exit 1),crosstool_wrapper_driver_is_not_gcc failed

ERROR: /disk/ccy/ROCm/TF/tensorflow-upstream/tensorflow/python/BUILD:455:1: C++ compilation of rule '//tensorflow/python:bfloat16_lib' failed (Exit 1): crosstool_wrapper_driver_is_not_gcc failed: error executing command
(cd /home/ccy/.cache/bazel/_bazel_ccy/3d2a9c8d528118f0815a98d1432af665/execroot/org_tensorflow &&
exec env -
PATH=/home/ccy/.local/bin:/home/ccy/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/opt/rocm/bin:/opt/rocm/profiler/bin:/opt/rocm/opencl/bin/x86_64:/opt/rocm/bin:/opt/rocm/profiler/bin:/opt/rocm/opencl/bin/x86_64:/home/ccy/bin
PWD=/proc/self/cwd
PYTHON_BIN_PATH=/usr/bin/python3
PYTHON_LIB_PATH=/usr/lib/python3/dist-packages
TF2_BEHAVIOR=1
TF_CONFIGURE_IOS=0
TF_ENABLE_XLA=1
TF_NEED_ROCM=1
external/local_config_rocm/crosstool/clang/bin/crosstool_wrapper_driver_is_not_gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections -fdata-sections '-std=c++11' -MD -MF bazel-out/k8-opt/bin/tensorflow/python/objs/bfloat16_lib/bfloat16.pic.d '-frandom-seed=bazel-out/k8-opt/bin/tensorflow/python/objs/bfloat16_lib/bfloat16.pic.o' -fPIC -DSQLITE_OMIT_DEPRECATED -DLLVM_ENABLE_STATS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DLLVM_BUILD_GLOBAL_ISEL -DTENSORFLOW_USE_CUSTOM_CONTRACTION_KERNEL -DTENSORFLOW_USE_MKLDNN_CONTRACTION_KERNEL '-DGRPC_ARES=0' -DHAVE_SYS_UIO_H -DTF_USE_SNAPPY -DCURL_STATICLIB -DPLATFORM_LINUX -DENABLE_CURL_CLIENT -DOPENSSL_IS_BORINGSSL -DEIGEN_MPL2_ONLY '-DEIGEN_MAX_ALIGN_BYTES=64' '-DEIGEN_HAS_TYPE_TRAITS=0' -D__CLANG_SUPPORT_DYN_ANNOTATION -iquote . -iquote bazel-out/k8-opt/bin -iquote external/local_config_python -iquote bazel-out/k8-opt/bin/external/local_config_python -iquote external/com_google_absl -iquote bazel-out/k8-opt/bin/external/com_google_absl -iquote external/eigen_archive -iquote bazel-out/k8-opt/bin/external/eigen_archive -iquote external/local_config_sycl -iquote bazel-out/k8-opt/bin/external/local_config_sycl -iquote external/nsync -iquote bazel-out/k8-opt/bin/external/nsync -iquote external/gif -iquote bazel-out/k8-opt/bin/external/gif -iquote external/libjpeg_turbo -iquote bazel-out/k8-opt/bin/external/libjpeg_turbo -iquote external/com_google_protobuf -iquote bazel-out/k8-opt/bin/external/com_google_protobuf -iquote external/com_googlesource_code_re2 -iquote bazel-out/k8-opt/bin/external/com_googlesource_code_re2 -iquote external/farmhash_archive -iquote bazel-out/k8-opt/bin/external/farmhash_archive -iquote external/fft2d -iquote bazel-out/k8-opt/bin/external/fft2d -iquote external/highwayhash -iquote bazel-out/k8-opt/bin/external/highwayhash -iquote external/zlib -iquote bazel-out/k8-opt/bin/external/zlib -iquote external/local_config_rocm -iquote bazel-out/k8-opt/bin/external/local_config_rocm -iquote external/local_config_cuda -iquote bazel-out/k8-opt/bin/external/local_config_cuda -iquote external/double_conversion -iquote bazel-out/k8-opt/bin/external/double_conversion -iquote external/snappy -iquote bazel-out/k8-opt/bin/external/snappy -iquote external/local_config_tensorrt -iquote bazel-out/k8-opt/bin/external/local_config_tensorrt -iquote external/curl -iquote bazel-out/k8-opt/bin/external/curl -iquote external/boringssl -iquote bazel-out/k8-opt/bin/external/boringssl -iquote external/jsoncpp_git -iquote bazel-out/k8-opt/bin/external/jsoncpp_git -iquote external/aws -iquote bazel-out/k8-opt/bin/external/aws -iquote external/aws-c-common -iquote bazel-out/k8-opt/bin/external/aws-c-common -iquote external/aws-c-event-stream -iquote bazel-out/k8-opt/bin/external/aws-c-event-stream -iquote external/aws-checksums -iquote bazel-out/k8-opt/bin/external/aws-checksums -iquote external/mkl_dnn -iquote bazel-out/k8-opt/bin/external/mkl_dnn -iquote external/llvm-project -iquote bazel-out/k8-opt/bin/external/llvm-project -iquote external/png -iquote bazel-out/k8-opt/bin/external/png -iquote external/lmdb -iquote bazel-out/k8-opt/bin/external/lmdb -iquote external/gemmlowp -iquote bazel-out/k8-opt/bin/external/gemmlowp -iquote external/icu -iquote bazel-out/k8-opt/bin/external/icu -iquote external/org_sqlite -iquote bazel-out/k8-opt/bin/external/org_sqlite -iquote external/com_github_grpc_grpc -iquote bazel-out/k8-opt/bin/external/com_github_grpc_grpc -iquote external/upb -iquote bazel-out/k8-opt/bin/external/upb -Ibazel-out/k8-opt/bin/external/local_config_cuda/cuda/_virtual_includes/cudnn_header -Ibazel-out/k8-opt/bin/external/local_config_cuda/cuda/_virtual_includes/cuda_headers_virtual -Ibazel-out/k8-opt/bin/external/local_config_tensorrt/_virtual_includes/tensorrt_headers -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/_virtual_includes/CallOpInterfacesIncGen -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/_virtual_includes/DialectSymbolRegistry -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/_virtual_includes/InferTypeOpInterfaceIncGen -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/_virtual_includes/OpAsmInterfacesIncGen -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/_virtual_includes/SideEffectInterfacesIncGen -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/_virtual_includes/AffineOpsIncGen -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/_virtual_includes/LoopLikeInterfaceIncGen -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/_virtual_includes/ControlFlowInterfacesIncGen -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/virtual_includes/StandardOpsIncGen -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/virtual_includes/ViewLikeInterfaceIncGen -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/virtual_includes/LoopOpsIncGen -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/virtual_includes/DerivedAttributeOpInterfaceIncGen -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/virtual_includes/ParserTokenKinds -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/virtual_includes/TransformsPassIncGen -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/virtual_includes/LoopPassIncGen -Ibazel-out/k8-opt/bin/external/llvm-project/mlir/virtual_includes/ShapeOpsIncGen -isystem external/local_config_python/numpy_include -isystem bazel-out/k8-opt/bin/external/local_config_python/numpy_include -isystem external/local_config_python/python_include -isystem bazel-out/k8-opt/bin/external/local_config_python/python_include -isystem external/eigen_archive -isystem bazel-out/k8-opt/bin/external/eigen_archive -isystem external/nsync/public -isystem bazel-out/k8-opt/bin/external/nsync/public -isystem external/gif -isystem bazel-out/k8-opt/bin/external/gif -isystem external/com_google_protobuf/src -isystem bazel-out/k8-opt/bin/external/com_google_protobuf/src -isystem external/farmhash_archive/src -isystem bazel-out/k8-opt/bin/external/farmhash_archive/src -isystem external/zlib -isystem bazel-out/k8-opt/bin/external/zlib -isystem external/local_config_rocm/rocm -isystem bazel-out/k8-opt/bin/external/local_config_rocm/rocm -isystem external/local_config_rocm/rocm/rocm/include -isystem bazel-out/k8-opt/bin/external/local_config_rocm/rocm/rocm/include -isystem external/local_config_rocm/rocm/rocm/include/rocrand -isystem bazel-out/k8-opt/bin/external/local_config_rocm/rocm/rocm/include/rocrand -isystem external/local_config_cuda/cuda -isystem bazel-out/k8-opt/bin/external/local_config_cuda/cuda -isystem external/local_config_cuda/cuda/cuda/include -isystem bazel-out/k8-opt/bin/external/local_config_cuda/cuda/cuda/include -isystem external/double_conversion -isystem bazel-out/k8-opt/bin/external/double_conversion -isystem external/curl/include -isystem bazel-out/k8-opt/bin/external/curl/include -isystem external/boringssl/src/include -isystem bazel-out/k8-opt/bin/external/boringssl/src/include -isystem external/jsoncpp_git/include -isystem bazel-out/k8-opt/bin/external/jsoncpp_git/include -isystem external/aws/aws-cpp-sdk-core/include -isystem bazel-out/k8-opt/bin/external/aws/aws-cpp-sdk-core/include -isystem external/aws/aws-cpp-sdk-s3/include -isystem bazel-out/k8-opt/bin/external/aws/aws-cpp-sdk-s3/include -isystem external/aws/aws-cpp-sdk-transfer/include -isystem bazel-out/k8-opt/bin/external/aws/aws-cpp-sdk-transfer/include -isystem external/aws-c-common/include -isystem bazel-out/k8-opt/bin/external/aws-c-common/include -isystem external/aws-c-event-stream/include -isystem bazel-out/k8-opt/bin/external/aws-c-event-stream/include -isystem external/aws-checksums/include -isystem bazel-out/k8-opt/bin/external/aws-checksums/include -isystem external/mkl_dnn/include -isystem bazel-out/k8-opt/bin/external/mkl_dnn/include -isystem external/mkl_dnn/src -isystem bazel-out/k8-opt/bin/external/mkl_dnn/src -isystem external/mkl_dnn/src/common -isystem bazel-out/k8-opt/bin/external/mkl_dnn/src/common -isystem external/mkl_dnn/src/cpu -isystem bazel-out/k8-opt/bin/external/mkl_dnn/src/cpu -isystem external/mkl_dnn/src/cpu/gemm -isystem bazel-out/k8-opt/bin/external/mkl_dnn/src/cpu/gemm -isystem external/mkl_dnn/src/cpu/xbyak -isystem bazel-out/k8-opt/bin/external/mkl_dnn/src/cpu/xbyak -isystem external/llvm-project/llvm/include -isystem bazel-out/k8-opt/bin/external/llvm-project/llvm/include -isystem external/local_config_rocm/rocm/rocm/include/hipcub -isystem bazel-out/k8-opt/bin/external/local_config_rocm/rocm/rocm/include/hipcub -isystem external/local_config_rocm/rocm/rocm/include/rocprim -isystem bazel-out/k8-opt/bin/external/local_config_rocm/rocm/rocm/include/rocprim -isystem external/png -isystem bazel-out/k8-opt/bin/external/png -isystem external/icu/icu4c/source/common -isystem bazel-out/k8-opt/bin/external/icu/icu4c/source/common -isystem external/llvm-project/mlir/include -isystem bazel-out/k8-opt/bin/external/llvm-project/mlir/include -isystem tensorflow/compiler/mlir/tensorflow/include -isystem bazel-out/k8-opt/bin/tensorflow/compiler/mlir/tensorflow/include -isystem tensorflow/compiler/mlir/xla/include -isystem bazel-out/k8-opt/bin/tensorflow/compiler/mlir/xla/include -isystem external/llvm-project/llvm/include/llvm/IR -isystem bazel-out/k8-opt/bin/external/llvm-project/llvm/include/llvm/IR -isystem external/llvm-project/llvm/lib/Transforms/InstCombine -isystem bazel-out/k8-opt/bin/external/llvm-project/llvm/lib/Transforms/InstCombine -isystem external/llvm-project/llvm/lib/Target/X86 -isystem bazel-out/k8-opt/bin/external/llvm-project/llvm/lib/Target/X86 -isystem external/llvm-project/llvm/lib/Target/AMDGPU -isystem bazel-out/k8-opt/bin/external/llvm-project/llvm/lib/Target/AMDGPU -isystem external/llvm-project/llvm/lib/Target/NVPTX -isystem bazel-out/k8-opt/bin/external/llvm-project/llvm/lib/Target/NVPTX -isystem external/com_github_grpc_grpc/include -isystem bazel-out/k8-opt/bin/external/com_github_grpc_grpc/include -isystem external/com_github_grpc_grpc/src/core/ext/upb-generated -isystem bazel-out/k8-opt/bin/external/com_github_grpc_grpc/src/core/ext/upb-generated -isystem external/com_github_grpc_grpc/third_party/address_sorting/include -isystem bazel-out/k8-opt/bin/external/com_github_grpc_grpc/third_party/address_sorting/include -w -DAUTOLOAD_DYNAMIC_KERNELS '-march=haswell' -Wno-sign-compare '-std=c++14' -fno-canonical-system-headers -Wno-builtin-macro-redefined '-D__DATE="redacted"' '-D__TIMESTAMP="redacted"' '-D__TIME="redacted"' '-DTENSORFLOW_USE_ROCM=1' -D__HIP_PLATFORM_HCC -DEIGEN_USE_HIP -no-canonical-prefixes -fno-canonical-system-headers -c tensorflow/python/lib/core/bfloat16.cc -o bazel-out/k8-opt/bin/tensorflow/python/_objs/bfloat16_lib/bfloat16.pic.o)
Execution platform: @local_config_platform//:host
tensorflow/python/lib/core/bfloat16.cc: In function 'bool tensorflow::{anonymous}::Initialize()':
tensorflow/python/lib/core/bfloat16.cc:636:36: error: no match for call to '(tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>) (const char [6], , const std::array<int, 3>&)'
compare_types)) {
^
tensorflow/python/lib/core/bfloat16.cc:610:60: note: candidate: tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>
const std::array<int, 3>& types) {
^
tensorflow/python/lib/core/bfloat16.cc:610:60: note:   no known conversion for argument 2 from '' to 'PyUFuncGenericFunction {aka void ()(char**, const long int, const long int*, void*)}'
tensorflow/python/lib/core/bfloat16.cc:640:36: error: no match for call to '(tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>) (const char [10], , const std::array<int, 3>&)'
compare_types)) {
^
tensorflow/python/lib/core/bfloat16.cc:610:60: note: candidate: tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>
const std::array<int, 3>& types) {
^
tensorflow/python/lib/core/bfloat16.cc:610:60: note:   no known conversion for argument 2 from '' to 'PyUFuncGenericFunction {aka void ()(char**, const long int, const long int*, void*)}'
tensorflow/python/lib/core/bfloat16.cc:643:77: error: no match for call to '(tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>) (const char [5], , const std::array<int, 3>&)'
if (!register_ufunc("less", CompareUFunc, compare_types)) {
^
tensorflow/python/lib/core/bfloat16.cc:610:60: note: candidate: tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>
const std::array<int, 3>& types) {
^
tensorflow/python/lib/core/bfloat16.cc:610:60: note:   no known conversion for argument 2 from '' to 'PyUFuncGenericFunction {aka void ()(char**, const long int, const long int*, void*)}'
tensorflow/python/lib/core/bfloat16.cc:647:36: error: no match for call to '(tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>) (const char [8], , const std::array<int, 3>&)'
compare_types)) {
^
tensorflow/python/lib/core/bfloat16.cc:610:60: note: candidate: tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>
const std::array<int, 3>& types) {
^
tensorflow/python/lib/core/bfloat16.cc:610:60: note:   no known conversion for argument 2 from '' to 'PyUFuncGenericFunction {aka void ()(char**, const long int, const long int*, void*)}'
tensorflow/python/lib/core/bfloat16.cc:651:36: error: no match for call to '(tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>) (const char [11], , const std::array<int, 3>&)'
compare_types)) {
^
tensorflow/python/lib/core/bfloat16.cc:610:60: note: candidate: tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>
const std::array<int, 3>& types) {
^
tensorflow/python/lib/core/bfloat16.cc:610:60: note:   no known conversion for argument 2 from '' to 'PyUFuncGenericFunction {aka void ()(char**, const long int, const long int*, void*)}'
tensorflow/python/lib/core/bfloat16.cc:655:36: error: no match for call to '(tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>) (const char [14], , const std::array<int, 3>&)'
compare_types)) {
^
tensorflow/python/lib/core/bfloat16.cc:610:60: note: candidate: tensorflow::{anonymous}::Initialize()::<lambda(const char*, PyUFuncGenericFunction, const std::array<int, 3>&)>
const std::array<int, 3>& types) {
^
tensorflow/python/lib/core/bfloat16.cc:610:60: note:   no known conversion for argument 2 from '' to 'PyUFuncGenericFunction {aka void ()(char**, const long int, const long int*, void*)}'
Target //tensorflow/tools/pip_package:build_pip_package failed to build
INFO: Elapsed time: 6.582s, Critical Path: 6.21s
INFO: 7 processes: 7 local.
FAILED: Build did NOT complete successfully

Please provide more details in regards on how to reproduce:

Which TF-rocm commit is it?
What command did you run to compile?

Ubuntu18.04 , gcc 7.5
vega10 card
Install bazel-3.0.0
git clone https://github.com/ROCmSoftwarePlatform/tensorflow-upstream.git
git checkout release-doc-rocm3.3-tf2.2-rc
./configure, and set ROCm support
bazel build --local_ram_resources=2048 --config=opt --config=rocm //tensorflow/tools/pip_package:build_pip_package --verbose_failures

note: when using the following command, the same error will appear.

bazel build --local_ram_resources=2048 --cxxopt="-D_GLIBCXX_USE_CXX11_ABI=0" --config=opt --config=rocm //tensorflow/tools/pip_package:build_pip_package --verbose_failures

bazel build --local_ram_resources=2048 --spawn_strategy=standalone --config=opt --config=rocm //tensorflow/tools/pip_package:build_pip_package --verbose_failures

bazel build -c opt --local_ram_resources=2048 --config=opt --config=rocm //tensorflow/tools/pip_package:build_pip_package

I want to build tensorflow2.xx based on ROCm, should choose stable branch or tag?

You have two options as workaround:

To compile by yourself, make sure to copy over the the workaround as indicated here.
To use a pre-built docker, start with below:
$ docker pull rocm/tensorflow-autobuilds:latest

@ccywxhn @jerryyin This complaints due to upstream change from numpy where

https://github.com/numpy/numpy/pull/15251

the const-ness of PyUFuncGenericFunction changed. The quick fix is to revert numpy before 1.19.0.


fix Issues 13

bug fix for it
https://github.com/franzsilva/flutter_launcher_icons/issues/13

LGTM. Needs @franzsilva to merge it in.


Dive into types in type test expressions in AST visitor traverse

Currently AstTraversal.Traverse goes into expr parts of type test expressions only and ignores type parts. This PR adds diving into type parts.
In the example below System.String will now be visited by VisitType.
"" :? System.String

Is it possible to add a test case for this?

@TIHan Thanks, I added a test.

It's green.

@auduchinok Is there an issue to link here? No worries if there's no, I just want to associate something with a milestone for traceability.

@cartermp No issue to link, sorry. I've pushed the fix right after discovered it.

Thank you


Highlight navigation bar?

Is your feature request related to a problem? Please describe.
I think the navigation bar isn't discoverable enough since 0.7.3
Describe the solution you'd like
like you show that a folder is selectable in the navigation bar, you could also highlight the whole navigation bar when hovering over it to make for the user visible that you can click on the navigation bar to edit the path

I think it should be a little smaller too

@szaimen How about changing the cursor when the mouse is moved over the navigation bar?

@szaimen How about changing the cursor when the mouse is moved over the navigation bar?

Yes, that could work but only if combined with the highlighting imo...

Do you have a concept for how this could look?

Maybe something like this: (just highlight the whole cliclable area when hovering over it)

@szaimen Thank you for the concept, that looks really good! I am going to keep this issue open for some time to give a chance for others to give their take on this but I am fairly certain we will end up going with this design.

I think at the very least it should have a reveal effect, maybe not necessarily a full solid colour. Just to show it's clickable. Maybe test a couple of designs and get feedback in this thread.

I think at the very least it should have a reveal effect, maybe not necessarily a full solid colour. Just to show it's clickable. Maybe test a couple of designs and get feedback in this thread.

Oh yes, reveal on the navbar would be really cool, like in the old Microsoft Edge

I think at the very least it should have a reveal effect, maybe not necessarily a full solid colour. Just to show it's clickable. Maybe test a couple of designs and get feedback in this thread.

Oh yes, reveal on the navbar would be really cool, like in the old Microsoft Edge

Actually my proposal was meant only as reveal effect and wouldn't be visible all the time: only if you hover with your mouse over it...

@yaichenbaum


Created a selectCell method in the PaintedGrid

Created a selectCell method in the PaintedGrid
Issue being fixed:
N/A
Changes proposed:

Since most of our selection differences only involve the rows and columns, creating a selectCell method in the PaintedGrid class allows us to abstract the selection model when we are trying to select some cells. This can be helpful in the future as if something needs to happen every time cells are selected. You can make this change in one place.

What if we took that same exact method and put it in our extension of the BasicSelectionModel, GhostSelectionModel (I think the class name could be improved). It feels a bit more intuitive to me that this would be the job of the selectionModel.

My thought was that for someone who was looking at the Datagrid from the outside, they would assume the grid has a select method. They wouldn't be aware that the Datagrid is broken down into the grid, datamodel, and selection model until a further dive into the code. We should discuss this more though.

Okay seems reasonable. Merging.


feat: implement home

I think this PR still has the 167256000 timestamp, change here or in a followup?
Also will home be auto integrated into passwd entry files? for users? Or is this something that needs to be created in addition to defining users and groups?

That’ll change in a follow up. Home will be used with passwd and flatten in a single tar for performance.


pull request for e2e test at 01/08/2017 22:15:14

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Revert "improve lock free flush_async and wait_flush in LoadChannel (#33389)"

This reverts commit 529260b82832e237c85867c783f410fc82a24627.
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Unable to add Gmail business account

fresh install on mac big-sur
Station version v2.0.9
Gmail auth error:
Error 400: invalid_request
Missing required parameter: client_id

Hello,
I get the same error with personnal Gmail account and windows new Station installation

I checked my personal account, and also completing the auth in incognito, all with the same failure message

Same problem here. All google Apps dont work with business and personal accounts providing the same error message :
Gmail auth error:
Error 400: invalid_request
Missing required parameter: client_id

Fixed in 2.1.0


feat: add image syncer for tiflow-engine and tiflow-operator

Why:

tiflow-operator and tiflow-engine need to synced as master and latest tag

/hold

Please make the SA name correct and simply the triggers, also keep the read orders for the yaml structs.

/unhold


Syntax to highlight the partial-ed callable

Related discussion: https://github.com/abersheeran/cool/discussions/6

Checks on MacOS are failing these days due to nonintrinsic factors. See https://github.com/actions/virtual-environments/issues/841

It's ok. Before the final merger, we will re-run CI.
Can you write some documentation to explain to others how to use it? Like #3. If you don’t have editing rights for this PR, I can close it and you will start another PR.

OK. I'll edit it.


[ENG-1876] Styling login Buttons

@yardz Why is the line padding/margin increased for code? Was there any change in linter/prettier config?

Probably prettier settings. My IDE applies the current prettier settings every time I save a file. Probably no one run prettier on this project/file.


13400730 Docs.ms.com June2017 Customer Feedback | MessageWebSocket Cl…

…ass | req for more info
Explaining the correct Close values by referring to IANA and MDN.  Note that MDN is now the preferred spot for Microsoft web documentation per this announcement: https://winbuzzer.com/2017/10/18/microsoft-samsung-google-choose-mozilla-mdn-web-docs-standard-home-browser-documentation-xcxwbn/

@PeterSmithRedmond: Thanks for your contribution. Going forward, CX asks that Microsoft contributors use VSTS to submit documentation changes. Future contributions via GitHub will be closed with a request to resubmit them via VSTS. More information is at http://aka.ms/windowsauthoring (see UWP instructions > UWP/WinRT API content). Thanks!
Cc: @mcleblanc

@mcleblanc: PR checklist issue:

Checklist item: Links to pages that do not require a locale code to render are coded as locale-agnostic (that is, do not contain "/en-us/" in the URL).

Link to MDN includes hard-coded locale identifier ("/en-us"), which may impede is localizability or use its as-is in other locales. Please remove the identifier from the URL.

When this issue is cleared, please evaluate the PR further as necessary.


Support a Google cloud-messaging Social network

Use normal google contacts, but do messaging via https://developer.chrome.com/apps/gcm

Closing as this is not currently a priority.


tests: Move configuration file count to constant

Signed-off-by: Ryan Northey<EMAIL_ADDRESS>Commit Message: tests: Move configuration file count to constant
Additional Description:
This makes it easier to update/document new sandboxes.
Ideally we set the var dynamically - possibly by setting the constant from an env var -  and maybe updating verify_examples.sh to get  the expected count of files
One bit of complexity not (yet) dealt with here is that it hardcodes -1 when running on windows or mac - we may want to somehow account for this dynamically too
See https://github.com/envoyproxy/envoy/pull/13200#discussion_r491994317 for discussion with @dio on reasoning for this
Risk Level: low
Testing: yep
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]  touch #13200
[Optional Deprecated:]

@envoyproxy/windows-dev

@phlax sorry, could you update this PR desc and commit message to reflect the actual change? Thanks!


[Redis Enterprise] az redisenterprise: Add new CLI extension

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[x] My extension description/summary conforms to the Extension Summary Guidelines.

Extension summary found in src/redisenterprise/azext_redisenterprise/manual/_help.py.  Results in the following:
> az redisenterprise --help

Group
    az redisenterprise : Manage dedicated Redis Enterprise caches for your Azure applications.

Subgroups
...

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

Redis Enterprise

Could you delete test code in manual folder and update generated tests in src/redisenterprise/azext_redisenterprise/tests?
Your CI gets failures because both tests are detected but you only record for manual folder.

I followed the conventions used for this service: https://github.com/Azure/azure-cli-extensions/tree/master/src/offazure/azext_offazure  .  What makes that service so different from mine where I cannot follow the same model?
If I update generated tests manually in src/redisenterprise/azext_redisenterprise/tests then that means they will get overwritten the next time I update with AutoRest, correct?
Why does the guidance shown here in the docs not apply in my case: https://github.com/Azure/autorest.az/blob/master/doc/04-scenario-test-configuration.md#customize-step-functions ?
Are you sure this is an issue with my code and not the CI checks?  I can run azdev test redisenterprise fine locally.

@Juliehzl This CI check is failing due to an issue with a different extension that appears to have been updated recently: azext_scheduled_query

/azp run


Rails 4.2.9 and Ruby 2.4 compatibility

Updated to Rails 4.2.9 from 4.2.7
Updated nokogiri because of a CVE
Updated webmock, resque, redis, therubyracer, uglifier, and posix-spawn for ruby 2.4 compatibility.

LGTM


Master => develop

Merge latest release back into develop

This change is

Builds ready [d00e73f]builds: chrome, firefox, opera
bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
dep viz: background
all artifacts


Documentation is not on par with feature

This document specifies that only the selected users will be downloaded, but the feature works based on the scope of the filters applied. Please, update documentation to reflect this.
Reach out to ermaciaf internally for more details.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7800fcb4-d251-f271-bc12-9377cd0407fa
Version Independent ID: 319b62fc-cea7-1add-559b-bb2a35b3a0ad
Content: Download a list of users in the Azure Active Directory portal
Content Source: articles/active-directory/enterprise-users/users-bulk-download.md
Service: active-directory
Sub-service: enterprise-users
GitHub Login: @curtand
Microsoft Alias: curtand

The doc currently says "The download file will contain the filtered list of users" under #4.

@ermacia91
Thanks for your feedback! We will investigate and update as appropriate.

@Leicham that is not accurate:

@Leicham I see it now, sorry. Still, that is a small aside to call out when the main feature of selecting the specific users does not seem accurate.

Thank you both for pointing this out! I've created a PR to update the documentation and it's currently waiting for the author to review and sign off.

I will now close out this issue. Please allow some time for the author to review and the changes to reflect.
Thank you for your time and patience!

@JamesTran-MSFT the point was to address this section:

Navigate to Azure Active Directory > Users. Then select the users you wish to include in the download by ticking the box in the left column next to each user. Note: At this time, there is no way to select all users for export. Each one must be individually selected.

As you can see, it states to select the users you want to download, which is not the correct statement. The correct statement is: "Navigate to Azure Active Directory > Users.  Then select the filters for which you want to select the users."

@ermacia91
Thank you for pointing this out! I've created a PR to update the documentation step and it's currently waiting for the author to review and sign off.
Please allow some time for the author to review and the changes to reflect.
Thank you for your time and patience!


Feature/responsive

Closes #2

Deploy preview ready!
Built with commit 0c99ec7035950702620ac2222e7e31540392b4d0
https://deploy-preview-15--blanket.netlify.com


[RFE] Include CAPI IPAM CRDs into Rancher

Is your feature request related to a problem? Please describe.
We are working to integrate the CAPI IPAM Provider in elemental-operator.
In order to install any IPAM Provider, for example the InCluster one, we need two CRDs to be included:

ipaddresses.ipam.cluster.x-k8s.io
ipaddressclaims.ipam.cluster.x-k8s.io

These CRDs are however excluded from the default list in Rancher.
Describe the solution you'd like
The IPAM CRDs should be included in Rancher, to allow usage of CAPI IPAM Providers out of the box.
Describe alternatives you've considered
It is possible to just install these CRDs on the Rancher cluster:
kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/cluster-api/main/config/crd/bases/ipam.cluster.x-k8s.io_ipaddressclaims.yaml
kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/cluster-api/main/config/crd/bases/ipam.cluster.x-k8s.io_ipaddresses.yaml

However this workaround is mistake prone, as there is no lifecycle of these manually installed CRDs, so they might conflict with the CAPI version included in Rancher.

@kkaempf - Going to kick this out of v2.10 since I think it's likely not going to make it.


[GLES3 - Android] WorldEnvronment with glow and canvas mode freezes the game

Godot version:
Godot 3.2.2 stable
OS/device including version:
Vivo Y51
Android 5.0.2 (Lollipop), Funtouch 2.5
Qualcomm Adreno 306 - GLES3
Issue description:
The WorldEnvironment node with a new environment, has glow enabled and set to canvas mode results to freeze on the software on my android.
Steps to reproduce:

Set Renderer to GLES3
Add WorldEnvironment node
Create a new environment
Set Background->Mode to canvas
Enable glow in the new environment
Run in android

Minimal reproduction project:
GLES3 Test for android.zip

Does this bug occur when using the GLES2 renderer?

Does this bug occur when using the GLES2 renderer?

No, and the glow effect on the WorldEnvironment node won't show on GLES2 renderer.


Streamline and extend documentation about declaring artifacts

If I want to publish custom artifacts, there are two APIs:
1
artifacts {
    apiElements(archiveTaskBuildingMyArtifact)
    apiElements(someTaskBuildingMyOtherArtifact.output) {
        builtBy(someTaskBuildingMyOtherArtifact)
        // ...
    }
}

2
configurations {
    apiElements.outgoing.artifact(archiveTaskBuildingMyArtifact)
    apiElements.outgoing.artifact(someTaskBuildingMyOtherArtifact.output) {
        builtBy(someTaskBuildingMyOtherArtifact)
        // ...
    }
}

There are some notations supported by the first API but not the second (to be confirmed)
There are some additional features in the second variant if you go into apiElements.outgoing.artifacts. For example, in a Java library project you can do apiElements.outgoing.artifacts. clear() to remove the standard jars.

There is also discussion about deprecating and removing 1 (#10797). As a first step, this should be properly documented.

Declaring artifacts should be added to "customizing components" in the publishing section
https://docs.gradle.org/current/userguide/publishing_customization.html#sec:adding-variants-to-existing-components
Sections like this one should be updated to use API 2 if that is what we want to recommend

Make sure use cases mentioned in #2529 are documented and then that issue can be closed.


Silence AWS config file import logs while running any aws commands

Overview

When any aws command is run, the shell plugin currently outputs some additional logs related to the config file reader/importer. With the changes proposed on this PR, we'd hide those logs for now, but a long-term effort would be to identify why those logs are appearing and not printing them in the first place.
I have used the same solution that @williamhpark outlined on the issue.
Type of change

[ ] Created a new plugin
[x] Improved an existing plugin
[ ] Fixed a bug in an existing plugin
[ ] Improved contributor utilities or experience

Related Issue(s)

Resolves: https://github.com/1Password/shell-plugins/issues/254

How To Test

Clone this branch
Run make aws/build
Set up AWS shell plugin with op plugin init aws
Run any AWS command, like aws s3 ls
Make sure that no additional logs appear before the aws s3 ls's output appears.

Here's how it looks for me with the proposed changes:

Changelog

Silence AWS config file import logs while running any aws commands

There is another place where you could see the logs, in the aws-vault importer. Let's handle that as well.

I have tested both the aws sts get-caller-identity --profile value and importer flows, and I can't see those logs on either anymore.

The error in second image encountered error while importing credentials automatically occurs even when the aws-vault importer flow is not dismissed, plus it seems to be tracked already here:

https://github.com/1Password/shell-plugins/issues/248

I haven't taken a look at that issue in detail yet, but all the logs outlined on this PR are handled now.


AWS EIP Allocation for NAT Gateway Fails

Terraform Version & Prov:
terraform_version = "0.15.5"
AFT Version:
1.6.2
Terraform Version & Provider Versions
Please provide the outputs of terraform version and terraform providers from within your AFT environment
terraform version
Terraform v1.2.6
on darwin_arm64
+ provider registry.terraform.io/hashicorp/archive v2.2.0
+ provider registry.terraform.io/hashicorp/aws v4.29.0
+ provider registry.terraform.io/hashicorp/local v2.2.3
+ provider registry.terraform.io/hashicorp/random v3.4.2
+ provider registry.terraform.io/hashicorp/time v0.8.0

terraform providers
      source                = "hashicorp/aws"
      version               = ">= 4.9.0"

Bug Description
The eip addresses for NAT Gateways fails to provision with an error message about Classic VPC no longer being supported.  This can be fixed adding in vpc=true as noted below in:  modules/aft/modules/aft-account-request-framework/vpc.tf
resource "aws_eip" "aft-vpc-natgw-01" {
  vpc = true
}

resource "aws_eip" "aft-vpc-natgw-02" {
  vpc = true
}

To Reproduce

Deploy AFT into a greenfield Control Tower Environment.

Expected behavior
EIP's for NAT Gateways should be provisioned without error.
Related Logs
n/a
Additional context
n/a

I am have the same issue. I am seeing the following error:
Do you want to perform these actions in workspace "tfcloud-ws-aws-aft"?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value:
module.aft.module.aft_ssm_parameters.aws_ssm_parameter.github_enterprise_url: Modifying... [id=/aft/config/vcs/github-enterprise-url]
module.aft.module.aft_account_request_framework.aws_eip.aft-vpc-natgw-01: Creating...
module.aft.module.aft_ssm_parameters.aws_ssm_parameter.github_enterprise_url: Modifications complete after 0s [id=/aft/config/vcs/github-enterprise-url]
╷
│ Error: with the retirement of EC2-Classic no new non-VPC EC2 EIPs can be created
│
│   with module.aft.module.aft_account_request_framework.aws_eip.aft-vpc-natgw-01,
│   on .terraform/modules/aft/modules/aft-account-request-framework/vpc.tf line 170, in resource "aws_eip" "aft-vpc-natgw-01":
│  170: resource "aws_eip" "aft-vpc-natgw-01" {}
│
╵
╷
│ Error: with the retirement of EC2-Classic no new non-VPC EC2 EIPs can be created
│
│   with module.aft.module.aft_account_request_framework.aws_eip.aft-vpc-natgw-02,
│   on .terraform/modules/aft/modules/aft-account-request-framework/vpc.tf line 172, in resource "aws_eip" "aft-vpc-natgw-02":
│  172: resource "aws_eip" "aft-vpc-natgw-02" {}
│
╵
Operation failed: failed running terraform apply (exit 1)

Hey @sirius-kris-leist @jodgey,
This for reporting this bug. We're working on a hotfix to resolve this issue.

We've just released AFT 1.6.3 which fixes this issue. Thanks again @jodgey @sirius-kris-leist!


feat: add flink module

Adding a module named flink
This will be used by dagger to resolve the following details:
a. kube cluster
b. kube ns
c. influx instance
d. sink kafka stream name

A dagger would have only flink module as its dependency.
Note: The dependecy would look like this
                         -> flink 1 -> multiple daggers
         -> namespace A
                         -> flink 2 -> multiple daggers
1 kube

         -> namespace B  -> flink 3 -> multiple daggers

Can you please add test cases for this?


fix(@angular/cli): add build-optimizer alias command

As stated on https://github.com/angular/angular-cli/blob/master/docs/documentation/build.md
build-optimizer option should also work with the -bo alias.
Current behavior:
The option '--bo' is not registered with the build command. Run `ng build --help` for a list of supported options.

The removal was intentional: https://github.com/angular/angular-cli/commit/92902c6094ab88f52949bd8c04e9ce9cf756e4fb
The documentation should be updated though.


Validation issue

we are not able to check if the image is edited or not

That is very vage @Shivang10169
What is the actual problem you are facing? You can keep track yourself whether an image has already been edited.
The response of the open method is a promise of a string

@filipef101 can you help me in ios version of this library ?

@prashant334434 I haven't used it in years. If you get stuck, build your own custom native module, it's easy nowadays! Cheers

@filipef101 how i can build my own can you please help me in it


Auto-refresh ability

Could it have the ability to auto-refresh a page using a defined interval so you can monitor for changes?

You can implement this by making the webpage auto-refresh. It won't be a feature in flobro for now.


Intermediate published/unpublished state for 6 studies in PMID 34006833

When I have unpublished/republished 8 entries for PMID 34006833 https://www.ebi.ac.uk/gwas/curation/publication/34006833 (to untick sumstats tick box), 6 of them have entered an intermediate published/unpublished status:

https://www.ebi.ac.uk/gwas/curation/studies/80754553/housekeeping
From previous experience, we know that this status stops the entries to be released, and therefore the problem should ideally be fixed before the next data release.

@sajo-ebi check that this is fixed in DR


Use preamble in filename generation

Additionally enable Psalm cache (this is expected to fail builds until vimeo/psalm#4789 is merged/released).

Build failures are expected.


Unencapsulate menu from anonymous function and allow manual init + submenu closing from external scripts

Example use cases:

Close header menu when toggling open a search drawer
Build a custom button to close submenus (#17)

Rough prototype

Remove anonymous function
Add new closeOpenSubmenu method on this in the class
Allow a way to opt menu out of automatic initialization so developer can manually do it and get menu object back to work with

Thanks to @jessesnyder for the consult! I consider a number of options and landed this one: a new clickyCloseMenu event that each instance of ClickyMenu listens for. Developers can trigger the event in any way and context they see fit. e.g.
const myMenu = document.querySelector('ul#my-menu'); // you can get this however you want. It's the DOM node with `.clicky-menu`
myMenu.dispatchEvent( new Event( 'clickyCloseMenu' ) );

That will close any open submenu in the ul#my-menu menu.
The keeps the script completely encapsulated. In the future, I can add support for additional events as needed.


Change link from GitHub to something else in the ramp-problem

While I solved the issue to get the starting kit directly from the server, we still have a link that point to github: https://dev.ramp.studio/problems/iris
It refers to the problem. A possible solution is to pack an archive when creating the problem initially and to make it downloadable as well.
Another solution is to remove the link directly and make it downloadable only for events.
ping @agramfort any thoughts?

this page https://dev.ramp.studio/problems/iris also contains a version of
the notebook. Can we download the kit version that matches this notebook?

Yep this will be the last zip file indeed
Sent from my phone - sorry to be brief and potential misspell.

Fixed in master.