fix: precision rounding error failing tests on different machines

Description

🐛 Bug Report: Tests failing in the following packages are failing likely due to precision/rounding errors:

github.com/vertgenlab/gonomics/maf
github.com/vertgenlab/gonomics/numbers/matrix
github.com/vertgenlab/gonomics/cmd/tfMatch

Below is the error message when cloning a fresh copy of gonomics:
ok      github.com/vertgenlab/gonomics/maf      1.167s  coverage: 66.8% of statements
diff
chr1    119     125     myMotif 0       -       0.15913872431596637     0.15913872431596623     1.3877787807814457e-16
chr1    119     125     myMotif 0       -       0.15913872431596654     0.15913872431596623     3.0531133177191805e-16
diff
chr1    16      22      myMotif 0       +       -0.2152125136398297     0.12136405222764843     0.33657656586747814
chr1    16      22      myMotif 0       +       -0.2152125136398297     0.12136405222764832     0.33657656586747803
diff
chr1    19      25      myMotif 0       -       0.15913872431596637     -0.6376256013017091     0.7967643256176755
chr1    19      25      myMotif 0       -       0.15913872431596654     -0.637625601301709      0.7967643256176755
diff
chr1    119     125     myMotif 0       -       0.15913872431596637     0.15913872431596623     1.3877787807814457e-16
chr1    119     125     myMotif 0       -       0.15913872431596654     0.15913872431596623     3.0531133177191805e-16
--- FAIL: TestMatchComp (0.00s)
    matchComp_test.go:121: Error: MatchComp output was not as expected.
    matchComp_test.go:121: Error: MatchComp output was not as expected.
    matchComp_test.go:121: Error: MatchComp output was not as expected.
    matchComp_test.go:121: Error: MatchComp output was not as expected.
FAIL
coverage: 77.5% of statements
FAIL    github.com/vertgenlab/gonomics/motif    1.187s
ok      github.com/vertgenlab/gonomics/numbers  (cached)        coverage: 62.6% of statements
ok      github.com/vertgenlab/gonomics/numbers/fit      1.351s  coverage: 84.0% of statements
ok      github.com/vertgenlab/gonomics/numbers/logspace (cached)        coverage: 88.6% of statements
⎡ 1.354025100551105  0.2554128118829954⎤
⎣0.2554128118829954   1.354025100551105⎦
--- FAIL: TestDenseLogSymmetric (0.00s)
    matrix_test.go:100: Error: DenseLogSymmetric output not as expected.
FAIL
coverage: 73.5% of statements
FAIL    github.com/vertgenlab/gonomics/numbers/matrix   0.966s
make: *** [test] Error 1

Solution
https://github.com/vertgenlab/gonomics/blob/cad1dd8ac6625ca65e6250e8ba6a9d288acf92a6/motif/compare.go#L11-L48
Relevant Links
Also seems like gonum has something similar for matrices a possible TODO is to implement EqualApprox into the existing tests

https://pkg.go.dev/gonum.org/v1/gonum/mat#EqualApprox

Testing

Implemented an AlmostEqual determines if two floating-point numbers, a and b, are equal within a specified epsilon level. (see code below):
https://github.com/vertgenlab/gonomics/blob/d441ad88f20da7b806d755c84975dc95edd21b86/numbers/numbers_test.go#L125-L143
Checklist before requesting a review

[x] I performed a self-review of my code
[x] If it this a core feature, I added thorough tests
[x] The command go fmt or make clean was used on all files included

Sorry @dasnellings, forgot to check in a small test for AlmostEquals function

Added a few more false test cases for better test coverage


Vulnerability roundup 85: librsync-0.9.7: 1 advisory

search, files

[ ] CVE-2014-8242 (nixos-20.03, nixos-unstable)

Scanned versions: nixos-20.03: a84b797b28e; nixos-unstable: 22c98819ccd. May contain false positives.

Removed in #131398, but it's still in 21.05.

21.05 is EOL now.


Low pass filters - Butterworth filter

I didn't seem to find the equivalent of scipy.signal.butter in the jax.scipy module as of now.
Would be great to have :)

To others that require a workaround: If all you require is a simply 2nd-order filter, one can simply "PD-Control" the signal, i.e. interpret the signal to filter, as the reference signal for a double integrator system where the acceleration at every timestep is proportional to the output of a PD controller that tries to track the signal to filter. Gains are relatively straightforward to tune.

This sounds to be a good feature. Is anyone implementing it? I was thinking to start on this project

Any updates on this thread?


[tool_crash] ArgumentError: Invalid argument(s): Cannot find executable for E:\flutter\bin\cache\dart-sdk\bin\pub.bat.

Command
flutter doctor

Steps to Reproduce

...
...
...

Logs
ArgumentError: Invalid argument(s): Cannot find executable for E:\flutter\bin\cache\dart-sdk\bin\pub.bat.
#0      _getExecutable (package:process/src/interface/local_process_manager.dart:124:5)
#1      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:40:30)
#2      ErrorHandlingProcessManager.start.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:638:33)
#3      _run (package:flutter_tools/src/base/error_handling_io.dart:532:20)
#4      ErrorHandlingProcessManager.start (package:flutter_tools/src/base/error_handling_io.dart:638:12)
#5      _DefaultProcessUtils.start (package:flutter_tools/src/base/process.dart:472:28)
#6      _DefaultProcessUtils.stream (package:flutter_tools/src/base/process.dart:491:35)
#7      _DefaultPub.batch (package:flutter_tools/src/dart/pub.dart:282:34)
<asynchronous suspension>
#8      _DefaultPub.get (package:flutter_tools/src/dart/pub.dart:222:7)
<asynchronous suspension>
#9      PubDependencies.update (package:flutter_tools/src/cache.dart:774:5)
<asynchronous suspension>
#10     Cache.updateAll (package:flutter_tools/src/cache.dart:562:9)
<asynchronous suspension>
#11     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1109:7)
<asynchronous suspension>
#12     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1009:27)
<asynchronous suspension>
#13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#14     AppContext.run (package:flutter_tools/src/base/context.dart:149:12)
<asynchronous suspension>
#15     CommandRunner.runCommand (package:args/command_runner.dart:197:13)
<asynchronous suspension>

[✓] Flutter (Channel stable, 2.0.6, on Microsoft Windows [Version 10.0.19042.867], locale en-US)
    • Flutter version 2.0.6 at E:\flutter
    • Framework revision 1d9032c7e1 (4 days ago), 2021-04-29 17:37:58 -0700
    • Engine revision 05e680e202
    • Dart version 2.12.3

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[✓] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 90.0.4430.93
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 90.0.818.51

! Doctor found issues in 2 categories.

Flutter Application Metadata
No pubspec in working directory.

Closing this as duplicate of https://github.com/flutter/flutter/issues/60880


Change the name of "Matrix" to something more unique

It's hard to ask someone, do you have a "matrix" account?
They're like "What do you mean? The movie?"
Matrix is a term that is used for a lot of things, and it gets awkward and confusing when asking someone such a question.

ma·trix  (mā′trĭks)
n. pl. ma·tri·ces (mā′trĭ-sēz′, măt′rĭ-) or ma·trix·es

A situation or surrounding substance within which something else originates, develops, or is contained: "Freedom of expression is the matrix, the indispensable condition, of nearly every form of freedom" (Benjamin N. Cardozo).
The womb.
Anatomy
a. The formative cells or tissue of a specialized structure such as a hair, nail, claw, or tooth.
b. See ground substance.
Geology
a. The solid matter in which a fossil or crystal is embedded.
b. Groundmass.

The principal metal in an alloy, as the iron in steel.
A binding substance, as cement in concrete.

a. Mathematics A rectangular array of numeric or algebraic quantities subject to mathematical operations.
b. Something resembling such an array, as in the regular formation of elements into columns and rows.
9. Computers The network of intersections between input and output leads in a computer, functioning as an encoder or a decoder.
10. Printing
a. A mold used in stereotyping and designed to receive positive impressions of type or illustrations from which metal plates can be cast. Also called mat2.
b. A metal plate used for casting typefaces.
11. An electroplated impression of a phonograph record used to make duplicate records.

We often compare decentralized services (such as matrix) to email, but the term "email" is much clever and unique. People either know what you are talking about (email) or they just get curious to know what that is while others can understand that it's made of e + mail so it must be some kind of mail.
Even "XMPP" is a little better than "Matrix" at least because it's unique.
TL;DR: Please change the name of "Matrix" to something more unique. How should we ask someone if they have a matrix account? I can't ask them if they have an Element acc, because Element is just a client.
I hope my suggestion will be heard. Thank you.

related: #3398


Filter window cannot fixed.

Problems summary
When using ddu-ui-ff to display a filter window, the window division is not fixed and the window width changes repeatedly.
Expected
Filter windows is fixed.
Environment Information

ddu.vim version (SHA1):
990b0c6d14a6be27682be73fdc3d9a835d62f765

denops.vim version (SHA1):
a104cbff7e47a63978cfb3921da4333465fc6d15

deno version(deno -V output):
1.22.2

OS: Windows11

neovim/Vim :version output:
GVim 8.2
patch 1-3438

Provide a minimal init.vim/vimrc with less than 50 lines (Required!)
if &compatible
  set nocompatible               " Be iMproved
endif

if empty(glob('/path/to/vim/autoload/plug.vim'))
  silent !curl -fLo ~/.vim/autoload/plug.vim --create-dirs
        \ https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim
  autocmd VimEnter * PlugInstall | source $MYVIMRC
endif

call plug#begin('/path/to/vim/plugged')
Plug 'vim-denops/denops.vim'
Plug 'Shougo/ddu.vim'
Plug 'Shougo/ddu-ui-ff'
Plug 'Shougo/ddu-filter-matcher_substring'
Plug 'Shougo/ddu-kind-file'
Plug 'Shougo/ddu-ui-filer'
Plug 'Shougo/ddu-commands.vim'
call plug#end()

 " ddu
 " Specify matcher.
 call ddu#custom#patch_global({
    \   'ui': 'ff',
    \   'sourceOptions' : {
    \     '_' : {
    \       'ignoreCase': v:true,
    \     },
    \   },
    \ })

nnoremap <silent> <space><space> <Cmd>Ddu
   \ -name=search mr -ui-param-startFilter=v:true<CR>

How to reproduce the problem from neovim/Vim startup (Required!)

Boot Gvim
Key type <Space><Space>

Screenshot (if possible)

Please fix the reproduce instruction.
And your screenshot is not same with minimal vimrc.
It is confusing for me.

I have tested it agein by nnoremap <silent> <space><space> <Cmd>Ddu       \ -name=search file -ui-param-startFilter=v:true<CR>.
But I cannot reproduce it.

This minimal vimrc is better:
set rtp+=~/work/denops.vim
set rtp+=~/work/ddu.vim
set rtp+=~/work/ddu-commands.vim
set rtp+=~/work/ddu-ui-ff

call ddu#custom#patch_global({
      \   'ui': 'ff',
      \   'sourceOptions' : {
      \     '_' : {
      \       'ignoreCase': v:true,
      \     }
      \   },
      \ })

nnoremap <silent> <space><space> <Cmd>Ddu
      \ -name=search mr -ui-param-startFilter=v:true<CR>

GVim 8.2
patch 1-3438

It seems old.  Please use nightly build instead.

Environment Information

ddu-ui-ff is the latest?  And please check ddu-ui-ff window is winfixheight.

@nekowasabi Please test it on the other environments.
In neovim and Linux.

OK.  I get it.  If winfixheight is not set, the problem is reproduced.

@Shougo
Update to nightly Gvim and update ddu-ui-ff.
So, it worked.
Thank you!!


[ci] make sure all config specify in designs dir elaboratable

This PR is based on #788, don't merge before it.


add extern "c" into sm2.h, sm3.h and sm4.h to make it can be called by c++ successfully

@mspncp is correct, these header files are internal.  If you are including them, you shouldn't.  Use the EVP APIs instead.

@cyjseagull these are internal headers and not meant to be included by external applications or libraries. AFAIK, none of the internal headers has C++ guards.

In some cases, we need calls sm2_do_verify or sm2_do_sign directly to support Chinese-Crypto-Suites, I think it's better to expose these interfaces to high-level applications.

The header files in include/crypto are not intended for third part use, they are internal to OpenSSL and will change.  They will never be updated so they can be #incuded by applications.
If there is some functionality missing, it will need to be added elsewhere.
Can you be more specific about why Chinese crypto needs this so we've got an idea what is missing?
@mattcaswell, give the "suites" mention it's possibly TLS related.

The header files in include/crypto are not intended for third part use, they are internal to OpenSSL and will change. They will never be updated so they can be #incuded by applications.
If there is some functionality missing, it will need to be added elsewhere.
Can you be more specific about why Chinese crypto needs this so we've got an idea what is missing?
@mattcaswell, give the "suites" mention it's possibly TLS related.

You are right, it maybe need to be placed in elsewhere.
The other cases are that we need sign, verify message using sm2 and calculate hash use sm3, or encrypt/decrypt message use sm4.

The header files in include/crypto are not intended for third part use, they are internal to OpenSSL and will change. They will never be updated so they can be #incuded by applications.
If there is some functionality missing, it will need to be added elsewhere.
Can you be more specific about why Chinese crypto needs this so we've got an idea what is missing?
@mattcaswell, give the "suites" mention it's possibly TLS related.

By the way, is the performance of openssl-1.1 higher than openssl-1.0.2 ?

The other cases are that we need sign, verify message using sm2 and calculate hash using sm3, or encrypt/decrypt message using sm4. It will convenient for us if you expose it to the app direclty.

EVP interface should fit these purposes. If not, please let us know what's the exact problem.

The other cases are that we need sign, verify message using sm2 and calculate hash using sm3, or encrypt/decrypt message using sm4. It will convenient for us if you expose it to the app direclty.

All of these things should be possible already using the EVP APIs.

Raw performance should be as good or better than 1.0.2, however there are additional overheads for setting up and tearing down algorithms.  This means the actual performance will vary depending on the specific application.
We'll need a lot more specific details (ideally, example code) to understand why the existing EVP APIs are not capable of doing what you require.


feat: Simplify Event Dashboard

Fixes #250

Move all analysis to TicketAnalyser
Remove unnecessary methods from contract
Simplify presenter
Modify tests

@mejariamol @arp95 @Shailesh351 @rohanagarwal94 Please review

@mejariamol Please review


AllReady.ScenarioTest not run as part of appveyor builds

Looking at the appveyor.yml file it appears that the AllReady.ScenarioTest are not actually run as part of the build.
I can see that they were  turned off back on Feb 20th as part of this commit.
Are they still useful or should we remove them along with the need for F#?

We had plans to implement scenario tests for common scenarios so we could test them as part of builds.  Not sure why they got turned off cc @BillWagner @MisterJames

These were turned off because they were taking enough time that they caused build failures.
We can look at AppVeyor config to see if our account lets us configure the failure timeout. Then, we could turn them on.

I would assume you have longer than 3 minutes for a process to run during the builds but maybe not.  The scenario tests run in about 3 minutes on my machine.  However, if the site changes and Canopy can't find an element on the page that it is looking for, then Canopy will throw a time out error.  It can be a little confusing to realize that the time out is an indication that it can't find an element more than it took too long to run a working test.
Also, I do expect the test running to get longer though as we add in other browsers.  Right now it is just running in Chrome but I would like to see them running in Firefox, Internet Explorer, and Edge as well.

The scenario tests by themselves aren't the issue, it's the total time:
. Start the VM
. Install pre-release .NET Core SDK (which may now be a standard image. If so we, can simplify the script)
. clone the repo
. restore all nuget packages.
. do the builds
. run the unit tests
. Run the scenario tests.
All up, it was often timing out.

actually in the recent past we have gotten tighter so all the overhead is < 3min 30sec, we should be good for scenario tests


Support both --stack and --cabal at the same time

I'm currently in a situation where a project is developed by a team. Some people use stack and others cabal. We use gen-hie as a pre-commit hook, so it would be nice if it can support both --cabal and --stack options to generate two cradles at the same time.
Taking the example from the README, the output would be something like this:
$ gen-hie --cabal --stack
cradle:
  cabal:
    - path: "indexed-profunctors/src"
      component: "lib:indexed-profunctors"

    - path: "optics-th/src"
      component: "lib:optics-th"

    - path: "optics-th/tests"
      component: "optics-th:test:optics-th-tests"

    - path: "optics-vl/src"
      component: "lib:optics-vl"

    - path: "codegen/./Subtypes.hs"
      component: "optics-codegen:exe:optics-codegen-subtypes"

    - path: "optics-core/src"
      component: "lib:optics-core"

    - path: "optics-sop/src"
      component: "lib:optics-sop"

    - path: "optics-extra/src"
      component: "lib:optics-extra"

    - path: "template-haskell-optics/src"
      component: "lib:template-haskell-optics"

    - path: "optics/src"
      component: "lib:optics"

    - path: "optics/tests"
      component: "optics:test:optics-tests"

    - path: "metametapost/src/Cli.hs"
      component: "metametapost:exe:metametapost-optics"

  stack:
    - path: "indexed-profunctors/src"
      component: "indexed-profunctors:lib"

    - path: "optics-th/src"
      component: "optics-th:lib"

    - path: "optics-th/tests"
      component: "optics-th:test:optics-th-tests"

    - path: "optics-vl/src"
      component: "optics-vl:lib"

    - path: "codegen/./Subtypes.hs"
      component: "optics-codegen:exe:optics-codegen-subtypes"

    - path: "optics-core/src"
      component: "optics-core:lib"

    - path: "optics-sop/src"
      component: "optics-sop:lib"

    - path: "optics-extra/src"
      component: "optics-extra:lib"

    - path: "template-haskell-optics/src"
      component: "template-haskell-optics:lib"

    - path: "optics/src"
      component: "optics:lib"

    - path: "optics/tests"
      component: "optics:test:optics-tests"

    - path: "metametapost/src/Cli.hs"
      component: "metametapost:exe:metametapost-optics"

Hi!
For my understanding, you do know that such a hie.yaml would be invalid? Is such a feature still useful in that case?
As another side-info, the simple cabal cradle:
cradle:
  cabal:

will work presumably for cabal projects (assuming cabal >= 3.4).

@fendor I didn't know that such a hie.yaml would be invalid 😮  I haven't found any documentation on this. Maybe you can point me to it if I missed it or maybe documentation can be improved?
At least it such a stack+cabal configj worked with my Cabal build but maybe it doesn't work with Stack. Or maybe something different happened.
It's a pity it's not supported. Unfortunately, having only cabal cradle isn't an option for me. So this issue can be closed if such a hie.yaml config is indeed invalid.

The only documentation we have is here: https://github.com/haskell/hie-bios
Essentially, the hie.yaml documents how you load a project into your IDE, it allows you to specify which tool you want to use, cabal or stack, having both does not make sense in its current interpretation. Then the IDE would still not know what you want to use.
Maybe it is some oddity of the yaml parser... But it will only use one of the two.
It is definitely invalid currently.


Someone is both God Member and Faraday Member at the same time

I thought you were one or the other.

Technically one could be a member of multiple groups, but this is clearly not what you want. I'll check if this is a problem of configuration or a real bug in the software.

It isn't a group, it's a ranking. As you make posts you progress up a ranking level. Or if that statement is incorrect perhaps you can explain what these membership groups are all about?

The software doesn't really distinguish from groups and rankings. In this case the primary group was assigned as God Member (and that's the case only for 2 members of the forum).
I fixed it.


Work with processes started by the scenario

Given a diagram like that

...how can I work with Process 2 using scenario?
Message correlation could happen by expression or by a JavaDelegate. I can verify that Process 2 is indeed started correctly and waiting at the user task by using processInstanceQuery(). Is there any way to perform scenario based testing on this instance just like with the main process?
Is this what is meant by #3 ?
Thanks in advance

Hi @Benjoyo I am excited about your interest. This is exactly what is meant by #3. It is not yet supported and kind of the last missing piece in the puzzle of testing complicated scenarios. Starting several instances, which interact at a later point, is already possible btw. The feature is probably not supertricky to implement, but you really never know before starting. :) As I am currently doing some serious work on the library, I am inclined to implement this ... would you be interested in this feature? If yes, would you be able to "acceptance test" some alpha version of it? Do you have interesting scenarios to use such a feature with? All the best, Martin.

Hey @martinschimak thank you for the quick reply.
To be honest, I am just starting with Camunda and have a toy project in which I use a construction similar to the above to spawn a user task that „survives“ the main process.
As part of my exploration I am trying out the different test libraries and compare „classic“ tests using bpm assert and bpm mockito with camunda-platform-scenario and found the scenario based testing to be very elegant for complete path tests. So I would love to use this library in future projects and would be happy about any additional functionality.
I can’t say yet how often this feature really would be required, I guess at least in my case it would be fine to test the flow in the second pool separately. But in other cases it would be cool to test cooperating processes together I think.
As I am just beginning I can’t test the feature in complicated scenarios yet, but I would be happy to try it out anyway if it helps :)
Thanks and best regards
Bennet

@Benjoyo It should already work. If you check out this branch https://github.com/camunda-community-hub/camunda-platform-scenario/compare/feature/work_with_processes_started_by_the_scenario and mvn install it locally, you can test it with the 2.0.0-SNAPSHOT dependency. Please not that the new group id is now org.camunda.bpm.extension.scenario and the artifact id is camunda-platform-scenario-runner.
Here is basically what you need:
Mockito.when(process.runsProcessInstance("OtherProcess")).thenReturn(Scenario.use(otherProcess));

If you have questions or feedback just get in touch with me here!

@martinschimak Sorry it took so long, I just tested it and it seems to be working just fine, thank you!
I have a question that is only partially related I guess. I have the following processes, similar to the above diagram, but with a return message and an event based gateway, that models a timeout for the newly started process:

I am testing the happy case when the refill stock user task is completed in time (<4h) and not in time (>4h), using the new feature. I am not sure how to stub the event based gateway correctly (waitsAtEventBasedGateway). In the first (happy) case, it seems to be fine to not stub it at all. In the second case I get:
java.lang.AssertionError: Process Instance {order:2:23, 20} waits at an unexpected EventBasedGateway 'gateway_stock_refilled_or_timeout'.
So then I just stub it with an empty body and it works. Note that I am using the actual correlation code in the delegates in my tests. Is this expected, or how should I handle event based gateways correctly?

Hi Benjoyo,
a design decision that I made with scenario is, that every "natural" wait state in a process has to be explicitly stubbed. The reaason behind it is, that a test should break when we do not have dealt with a waitstate at all, in other words we haven't even defined a "default, happy" way how to complete it successfully. If we add e.g. activities to a process, we should at least add this happy completion stub to our test case and all scenarios should work again.
Now, an event based gateway is also such a "natural" wait state, meaning it is no technical decision to make it async. It is always async in the sence that the process state is persisted and waiting for another trigger coming from outside. Therefore it also, like all other waitstates, has to be stubbed. At the same time the event based gateway is a bit different than normal task waitstates (user tasks, external tasks), in the sense that we do not necessarily need to do anything there, because the trigger comes from somewhere else in the scenario. Stubbing a waitstate with an empty body really just means: continue to wait at this waitstate. This can be legitimate because the trigger to move on comes from somewhere else, or just because we want to test just a part of the model. But we also have the possibility to model the trigger in the gateways stub itself, if we do not have any other possibility, like e.g. assume you test the first process "standalone", without adding the "Refill stock" process to your test scenario. Now you need to trigger the message "Stock refilled" coming from outside explicitely in your waitsAtEventBasedGateway stub.
A question remains: why does your error message (which is really the default error message reminding the developer to always stub every natural waitstate) just show up in the second scenario. I assume that the reason is that the scenario runner does not realize that the stub is missing, because it doesn't need it. The error message always only shows up when the runner tries to deal with a stub. In your first scenario it seems to trigger the outside message even before it looks for the waitsAtEventBasedGateway stub. This is a bit unfortunate, because it contradicts the design decision "always stub all your wait states explicitely" mentioned above. I am therefore thinking about validating this at an earlier point, but I am unsure whether it is feasible.
Anyway, thank you VERY much for your feedback. This is exactly one of the issues which can basically only pop up with the new feature in place, because so far we couldn't test such scenarios if collaborating processes interacting on eye level with messages, in other words, we had to mimic the message coming from outside instead of testing the real processes together.
Benjoyo, just in case you have more such scenarios or just more questions, please don't hesitate to get back to me. :-)
All the best,
Martin.

Thank you for the explanation, that does make sense! I will get back to you if I have any more problems or questions, thank you for being so kind. Right now, however, everything seems smooth :)

@Benjoyo It should already work. If you check out this branch https://github.com/camunda-community-hub/camunda-platform-scenario/compare/feature/work_with_processes_started_by_the_scenario and mvn install it locally, you can test it with the 2.0.0-SNAPSHOT dependency. Please note the new group id, which is now org.camunda.bpm.extension.scenario and the new artifact id, which is now camunda-platform-scenario-runner.
Here is basically what you need:
Mockito.when(process.runsProcessInstance("OtherProcess")).thenReturn(Scenario.use(otherProcess));

If you have questions or feedback just get in touch with me here!

Hi, @martinschimak! I also faced a similar problem - working with a process started from a script. I was pleasantly surprised that this issue has already been resolved, but why is there still no release of the library with this feature. I have already tested this solution locally, but I have a big wish for your to make a release with this feature, it is very useful and necessary for full coverage of collaboration processes with tests. Thank you in advance!


How to validate a checkbox array with a custom validator?

Versions:

VueJs: 2.5
Vee-Validate: 2.0.0-rc.19

Description:
I'm building a set of components, all of which have the same API, with value coming in and input being the model.
For each component, I mix in a the validation, which on creation does this:
  created () {
    this.$validator = new Validator()
    this.$validator.attach('input', this.rules)
  },

I then have a validate() function on the component which I call as needed:
    validate () {
      this.$validator.validate('input', this.input)
      const error = this.$validator.errors.first('input') || ''
      this.error = error.replace('The input field', 'This field')
      return error.replace('The input field', `The field '${this.name}'`) || null
    },

This all works fine, but I cannot get an input array (from multiple checkboxes) to validate all of them, it just validates with one field checked.

You can see the options I pass in here:

I've started looking into custom rules, trying to detach the original ones and add new ones, but I can't seem to make it work.
I essentially need to rewrite the required rule for this instance so that it compares the length of the options with the length of the input:
return this.input.length === this.options.length

And returns a meaningful error message, such as "All fields must be checked".
If anyone can show me what JS to write to have this component validate itself, that would be amazing.
Thanks,
Dave

OK, looks like I did it.
In the created method of the component, I overwrite the required rule:
    created () {
      const rule = {
        getMessage: (field, args) => 'All fields need to be checked',
        validate: (value, args) => value.length === this.options.length
      }
      this.$validator.extend('required', rule)
    },

Damn. Thought I had it, but all sorts of horrible errors when the component is destroyed / a new one is created.

OK, turns out it was the binding.
I got round it with this horrible contraption:
    created () {
      const validate = (value) => {
        return value && value.length === this.options.length
      }

      const rule = {
        getMessage: (field, args) => 'All fields need to be checked',
        validate: function (value, args) {
          return validate(value)
        }
      }

      this.$validator = new Validator()
      this.$validator.attach('input', this.rules)
      this.$validator.extend('all', rule)
    },

I'd love to find a better way of doing this.
Is there any way to bind values to the validator?

Rules are a global singleton shared by all instances. Meaning if you override one rule, it overrides the rule globally for all instances so you probably don't want to override the default rules.
Can you use the length rule for that? It was introduced recently.

Rules are a global singleton shared by all instances. Meaning if you override one rule, it overrides the rule globally for all instances so you probably don't want to override the default rules.

Hmmm. Surely if you override an instance, you want the rule to be only for that instance?
I'll check out the length rule, though I've actually updated the implementation of the checkboxes array now, so that the emitted value isn't an array of checked values, but a hash of boolean properties (as it makes more sense to send this to any back end, as props map better to DB columns)

OK, final piece of the puzzle solved tonight.
My checkbox array now ONLY takes an Object as values:
{
  foo: 'Foo',
  bar: 'Bar',
  baz: 'Baz',
}

This then makes it really easy to validate, with a new rule I'm calling "all":
Validator.extend('all', {
  getMessage: (field, args) => 'All fields need to be checked',
  validate: function (value, args) {
    return Object
      .keys(value)
      .every(key => !!value[key])
  }
})

Simples.

Great you figured that out 😄

still you could loop over the array value and do the same, right

You mean if I pass in an array? I've disabled that for the moment, but I'll reinstate it when I have some time.
I have come up against a related issue now - maybe you can help me?
So as part of my component set, I have <checkboxes> and <checkbox>:

Using my rule all works for checkboxes and passing a checkbox object, but the checkbox component, its value is a boolean, so the comparison / rule is different.
What I would like, would be to be able to specify a single rule checked which would work for both types:
Validator.extend('checked', {
  getMessage: function (field, args) {
    return 'All fields need to be checked'
  },
  validate: function (value, args) {
    return typeof value === 'boolean'
      ? value
      : Object
        .keys(value)
        .every(key => !!value[key])
  }
})

Whilst the validate() function works, the getMessage() function is unable to determine the passed values (object or boolean) and so can't vary its message depending.
Is there a way to solve this?

OK, I read a bit further in the docs and I can return an object from the validate() function which gets passed to the getMessage() as the third parameter.
Great stuff!

You can take a look at this merged PR #868
You can define how your component behaves with the false value with the required rule, setting the option rejectFalse to true will allow it to behave more like a checkbox.
There isn't a rule called checked since it is basically the same as required but rejects false as well, still can be solved by the mentioned PR.


RedissonRedLock & RedissonMultiLock lock method stuck

If more than 3 locks are supplied to RedissonRedLock or RedissonMultiLock instance then lock method could stuck

Fixed


Can i get another people follower and following list ?

Hi
Can i get another people follower and following list ?
for example Can i get the list of instagram user id follower ?
or just i access to my follower and following ?

Use the FollowedBy method

@fujiy but it just get 50 results ! and just get followers not following !

To get users who you are following you call Follows.
To get all users, you should call FollowedBy(long userId, string cursor), using cursor to get next pages, or FollowedByAll

@fujiy  thanks


[AMBARI-24557] Remove legacy storm sink module from ambari-metrics.

What changes were proposed in this pull request?
Remove obsolete storm sink version from ambari-metrics.
How was this patch tested?
mvn clean install

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3791/
Test PASSed.


[model_to_estimator] summary in keras loss/metrics function get duplicate scalars with same value in TensorBoard

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):  Linux Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.13.1
Python version: 3.5.2
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: CUDA 10.0
GPU model and memory:

Describe the current behavior
Using tf.summary.scalar in keras loss/metrics function, then use model_to_estimator to convert keras model to estimator, tensorboard get duplicate scalars with totally same value. (e.g., metrics/accuracy/train and metrics/accuracy/train_1)
Describe the expected behavior
It should only summary one scalar.
Code to reproduce the issue
A example here:
    ...

    model = tf.keras.Model(inputs=input_layer, outputs=[output_layer1, output_layer2])

    def accuracy(y_true, y_pred):
        y_pred, y_true = reshape_keras_tensor(y_pred, y_true)
        acc = tf.reduce_mean(
            tf.cast(tf.equal(tf.cast(y_true, tf.int64), tf.argmax(input=y_pred, axis=1)), tf.float32))
        # Where I summary, without this line, it will not summary anything during training
        tf.summary.scalar('train', acc)
        return acc

    def total_loss(y_true, y_pred):
        y_pred, y_true = reshape_keras_tensor(y_pred, y_true)
        loss =  tf.nn.sparse_softmax_cross_entropy_with_logits(
            labels=y_true,
            logits=y_pred)
        loss = tf.reduce_mean(cross_entropy)
        # Where I summary, without this line, it will not summary anything during training
        tf.summary.scalar('train', loss)
        return loss

    ...

    model.compile(optimizer=optimizer_builder.build(config.optimizer),
                  loss={output_layer1: total_loss},
                  metrics={output_layer1: accuracy})

    estimator = tf.keras.estimator.model_to_estimator(
        keras_model=model,
        config=run_config,
    )
    train_spec = tf.estimator.TrainSpec(
        input_fn=lambda: train_input_fn(config))
    eval_spec = tf.estimator.EvalSpec(
        input_fn=lambda: eval_input_fn(config))
    tf.estimator.train_and_evaluate(estimator, train_spec, eval_spec)

Other info / logs
TensorBoard with duplicate scalars:

You can just edit the tf.summary.scalar('train', ...) calls to pass in different string tags - right now they're both using train so the second one gets mapped to train_1.

Hi @nfelt, thanks for the reply, but I still get same problem after change scalar name train to train_acc and train_f1_score or something else without same name.

Looks like a bug of summary in custom loss/metrics function with model_to_estimator.


Minimizing Acceleration in Predictive Cycling Motion

Hello, I am trying to create a predictive model for steady state cycling. However, I am running into an issue with the acceleration of the crank. I am thinking that minimizing the crank acceleration is necessary to ensure steady state. I was attempting to use the MocoOutputGoal with the below lines of code. However, I am receiving a "bad dynamic cast" error in the solver line of the moco study.
CrankAccel = MocoOutputGoal('Crank_Acceleration',5);
CrankAccel.setOutputPath('bodyset/crank|acceleration');
CrankAccel.setDivideByDisplacement(false);
CrankAccel.setDivideByMass(false);
problem.addGoal(CrankAccel);
I do not have a lot of experience with the Opensim API so much of the above could be very wrong. Please let me know if there is a way to minimize acceleration of a particular bodyset of the model.
Error text:
Error using Cycle_Sandbox_File (line 216)
Java exception occurred:
java.lang.RuntimeException: Bad dynamic_cast!
at
org.opensim.modeling.opensimMocoJNI.MocoStudy_initCasADiSolver(Native
Method)

at
org.opensim.modeling.MocoStudy.initCasADiSolver(MocoStudy.java:229)

Hi @ChrisD1993, since you opened an issue here, I wanted first to make sure that you're using the correct version of OpenSim Moco. We've moved all development of the project to the OpenSim repo, and the latest versions of Moco can be found in the latest OpenSim downloads.
With that out of the way, I don't see anything in the code snippet you shared that would be causing a bad dynamic cast error. It looks like you have a custom model built in a sandbox file. Perhaps you could share some of that code to help debug.
If you are using the latest version of OpenSim (with Moco), then I would prefer moving this issue over to the main OpenSim repo.


Hide notification error if it's already shown

Description:

We should check if the error is the same as one of the others displayed before pushing the notification

at least, position absolute or fixed instead of relative

position absolute

sounds like an easy solution

duplicate from #1468


Fix typos in style.md

Fix typos found in style setters example comment

@jwmsft : PR passed review checklist. Please evaluate the proposed changes further. Thanks!


Index of test fix plan per module

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug

Power BI page
Click link in "report" field to view summary of one test run.
We have fixed lots of failed test cases including modules owned by service team to enable overall pass rate jump from about 80% to 90%. Others need service teams' help.
Issues to @ correct people and track progress of modules that have more than 5 failures:
acs: https://github.com/Azure/azure-cli/issues/15615
batchai: https://github.com/Azure/azure-cli/issues/15616
eventgrid: https://github.com/Azure/azure-cli/issues/15618
monitor: https://github.com/Azure/azure-cli/issues/15619
netappfiles: https://github.com/Azure/azure-cli/issues/15620
network: https://github.com/Azure/azure-cli/issues/15621
reservations: https://github.com/Azure/azure-cli/issues/15622
resource: https://github.com/Azure/azure-cli/issues/15623
security: https://github.com/Azure/azure-cli/issues/15624
sql: https://github.com/Azure/azure-cli/issues/15625
storage: https://github.com/Azure/azure-cli/issues/15626
To Reproduce

Expected behavior

Environment summary

Additional context

test fix plan


python312Packages.tencentcloud-sdk-python: 3.0.1278 -> 3.0.1279

Diff: https://github.com/TencentCloud/tencentcloud-sdk-python/compare/refs/tags/3.0.1278...3.0.1279
Changelog: https://github.com/TencentCloud/tencentcloud-sdk-python/blob/3.0.1279/CHANGELOG.md

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 364459

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.tencentcloud-sdk-python
python311Packages.tencentcloud-sdk-python.dist
python312Packages.tencentcloud-sdk-python
python312Packages.tencentcloud-sdk-python.dist


Fix capitalization in holiday message

Original: "The VS Code team wishes you a great Holiday season!"
Updated: "The VS Code team wishes you a great holiday season!"

Thanks for the PR.
However, I don't think that we are able to use this PR because the "Holidays" are over when the next build occurs...

Ok, no problem :)


MB-8825 Add reason crating service items

Description
This PR adds reason to the crating service item definition.
Reviewer Notes
Should we be able to update crating service items? I don't think we can currently
Setup
To run the server tests navigate to the mymove repo and execute make server_test
To test manually use postman and complete the following steps:

Start your local sever by executing make server_run in the mymove repo
Run fetchMTOUpdates in postman
Find a move that has an existing shipment
Copy the moveTaskOrderID and ID from the shipment
Run createMTOServiceItem with the following body

{
    "moveTaskOrderID": "<YOUR MOVE ID HERE>",
    "mtoShipmentID": "<YOUR SHIPMENT ID HERE>",
    "modelType": "MTOServiceItemDomesticCrating",
    "reServiceCode": "DCRT",
    "item": {
        "type": "ITEM",
        "length": 1000,
        "width": 1000,
        "height": 1000
    },
    "crate": {
        "type": "ITEM",
        "length": 1100,
        "width": 1100,
        "height": 1100
    },
    "description": "description",
    "reason": "reason"
}

The response should include the new reason field
Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Messages

:book:
:link: MB-8825

  Generated by :no_entry_sign: dangerJS against ac8d8335082e452f90daaba2de8ca55b82077538


getting error when run in emulator

on line :
global::Xamarin.Forms.Xaml.Extensions.LoadFromXaml(this, typeof(MainPage));
File:
MainPage.xaml.g.cs
Unhandled Exception:
System.Exception:

Hello @itcurves  try upgrading your xamarin.forms  vversion to the last one otherwise try on real device or another emulator !

I have the latest version. I tried both a different simulator and device but same error.

cleaning obj/bin folder and get last version of nuget package (+3.0)

ok I delete bin and obj folder from both projects. Update my NUGet packages. my Xamarin Form version is 3.3 but still getting the same error.
My simulator is Android Oreo 8.1 - API 27


Does array search support push down?

I'm trying to query an array in ElasticSearch
data: "names":[{"name":"allen"},{"name":"bill"},{"name":"dave"},{"name":"poter"}]
goal: "select names from table where array_contains(names.name, "bill")"
but spark won't do predicate pushdown if SQL statement use array_contains function.
hint: names.name = ["allen","bill","dave","poter"]
I've tried
select * from table where array_contains(names.name,"bill")
-- and
select explode(names.name) as name from table as t1;select * from t1 where name = "bill"
-- and
select * from table where cast(names.name as string) like '%bill%'
All failed to do pushdown, any other ways to do it?

Unfortunately, the array_contains function is not included in the list of expressions that are translated and sent by Spark to the connector for pushdown. This would be a very easy filter to pushdown in the connector, but sadly we are not given a choice to do so. This link references the Spark code that translates catalyst expressions into the filter requests that data sources can use. We support almost all of the listed expressions at this time, but array_contains is not one of them.

Thanks, is there a better way to query arrays in es?

When in doubt, you can always specify an elasticsearch query to your job by using the es.query property. I'll go ahead and close out this issue.

why es.query will ignore params like "size" and "from"?

es.query is strictly for specifying the matching criteria for documents. size and from are ignored during the parsing. They also don't make much sense to use since ES-Hadoop uses the scroll API for all read operations.

with this change in Spark 3 it might be possible to push down array_contains now?
https://github.com/apache/spark/pull/28366
possibly just add this elasticseach datasource to spark.sql.optimizer.nestedPredicatePushdown.supportedFileSources ?

@jbaiera


Cosmetic fix for Firefox is breaking grid?!

hello,
I used the unchanged download for version 1.1.2 and replaced the specific files with those from the fix for Firefox, but now any grid is showing incorrectly:

This also happens in Chrome.
What am I missing here?

It looks like you are missing some styles.  Did you replace the .scss files?

I checked version 1.1.2 before applying the fix on it and it displayed fine (except the usual issue in Firefox of course).
Cleared the cache, same result.
If there was a cached version of that site, it would display as before.
Are you sure all changed files are uploaded to GitHub?

Yes, all changed files are uploaded to Github.
You'll have to use the browser dev tools to try and find out why it's not working.  Have a look at the mud-cal-grid and mud-cal-grid-header classes.

I don't know what went wrong there.
When I did it a second time with the unchanged 1.1.2 the grid looked different (but still not correct, since it had no grid lines).
Maybe while comparing the files with WinMerge something got messed up.
Then I downloaded all files from the fix again and applied them again to the unchanged 11.2 and it worked.
The only problem I have now is, that I added a work week/5 day week, which is now being shifted like someone took out the weekends from the grid, but I basically only copied the 7 day week and changed some values. This change worked fine before the fix.
I am hoping the person in the other issue about the work week will provide a pull request which will work with the Firefox fix.
Thanks for your time.

I'm glad you got it working.
The change to using a css grid was a big change so I'm not too surprised that it broke the changes you made.  This is why the change is being released in a new major version number.


patch: Vertical stacking

Makes notifications vertically stack (downwards/upwards depending on corner config being top/bottom).
Uses System V shared memory to keep track of y-offset between processes.
Here's a demo
Download
https://patch-diff.githubusercontent.com/raw/dudik/herbe/pull/19.diff

This approach works badly on a multi-user system of course... perhaps X resources could be used to figure out position?


Added forgotten redirect/notFound fields into gsspWithNonce function

@nibtime @boennemann @alexturpin @Neki @renet @benhodgson87 @Shamilik @DuCanhGH @aheimlich Guys, are you able to look at this PR?
@miklosz @wpodgorski for some reason I've moved PR here.

@komw please stop @‘ing all contributors. People who previously had other contributions merged cannot do anything about this PR.


Remove switch tags from svg files

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[n/a] Did you make sure to update the docs?
[n/a] Did you write any new necessary tests?

What does this PR do?
Fixes #135.
Used the following command to remove the tags:
find ./course_UvA-DL/ -type f -exec sed -i -- 's|<switch><g .*<\/switch>||g' {} +

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Pasting one of the diffs in case reviewers can't see it in their browsers:


Use latest annotated git tag as build version

Fixes #71.
Running make uses the latest tag as the release version.

(Feedback welcome.)

Looks good to me. The only problem it has is that it expects the .git directory to be available in the container. That's fine in this case because it is a small project, but for other projects it may be big and slow down the bulid. Then, it's necessary to put the version number in a file with the go generate mechanism.

The only problem is that when I run make && ./hanoverd --version, I don't get the version number output. Any ideas?

On my machine, I see:
Removing intermediate container 3bcacf746cf8
Successfully built 030444f80551
docker run --rm hanoverd-buildtime cat /go/bin/hanoverd > ./hanoverd
chmod u+x ./hanoverd
iptables v1.4.12: unknown option "--wait"
Try `iptables -h' or 'iptables --help' for more information.
2015/10/21 12:01:39 Unable to find iptables, using fallback
hanoverd version v0.7.9

(This discrepancy was because .git was in .dockerignore; we used go generate instead.)


ConnectionFactory may change between creation of SqlString and use of its methods

Perhaps SqlString should store a reference to ConnectionFactory at the time of its creation?

The simple use case is to follow AsSql with a call to one of the SqlString methods. This may be an issue in multithreaded contexts, but otherwise it shouldn't be a problem.


Elbow jason/bug/fix spelling

I fixed the "Foudation" -> "Foundation" issue where I could find it in text. I didn't attempt to update the image though.
Cheers.

references #17


No instance is shown

When clicking on Instance for example on Line1, are there no instances shown and i guess therefore i can't select any ID (is empty when looking at view).

Already tried downgrading the Version to 1.0.2, did not help

Do yo have any RUNNING instance of history, sql or influxdb?


sign image and publish sbom

@trmiller can you please merge this? I don't seem to have the permissions to do so. Thanks.


Update tooling to use drop-in stub universe json format

Code for building stub universes is switched entirely to the json format. The release builder, meanwhile, still supports both old zips and new jsons for now. The json file now being produced is identical in usage to the prior zip file (dcos package repo add http://arrl.org/foo.json, etc...)
Other notable changes:

Fixes a nasty bug in release_builder which would allow always overwriting AWS data (bool('false') => True)
Adds support in publish_aws and publish_http for the bizarre universe content type that Cosmos requires for these json files.
Breaks out the universe version in universe_builder to allow easier switching to v4 later.
Misc formatting fixes that pylint complained about

Looks like there's a bug in the CLI's handling of binary CLI hashes. Debugging... In the meantime feel free to review.
E               dcos.errors.DCOSException: The hash for the downloaded subcommand [d9fa98944bfa1ded2b0b401d2365c25db94e14e94df3a1aeb9273f9b5c77c352] does not match the expected value [0131180f265dc6e206c67ec2344a616a57d95401ba09de8b1df9df386b974c7e]. Aborting...

(spoiler: when downloaded manually, the executable matches the expected hash)

retest this please

I only feel really strongly about a few hints about what things are doing (e.g. extract_json_file() is probably obvious to you but not me), and beginning to move away from empty string as a false sentinel.
I also, in general feel strongly about commands as vectors/sequences, and tuple unpacking vs thing[0] and thing[1], but not in this pull request.

Manually tested the release script as of 61f3459. Successfully reuploaded to prod and created the branch/PR. A side effect of moving to this new stub-universe.json is that it normalizes the JSON formatting in package files (WITHOUT reordering keys) so the release commit shows a bunch of whitespace fixes: https://github.com/mesosphere/universe/compare/version-3.x...automated/release_kafka_0.0.0-test_+qEvAw?expand=1


Implement N9 interface in eUPF control part

DoD

[ ] Support N9 FARs in PFCP connection
[ ] Write proper instructions in ebpf maps

@marknefedov  In order to support I-UPF functions GTP-2-GTP forwarding have to be implemented. eBPF maps are compatible if I'm not mistaken. Please verify valid tunnel params extraction from PFCP PDI during Session Establishment/Modification Request.
pfcp (1).pcap.gz

At a first glance I do not see any incompatible IEs. Should be fine.


WIP: add jupyter_sphinx_rel_repo_path, closes #26

This adds a new configurable variable jupyter_sphinx_rel_repo_path and solves the problem I brought up in #26.
For example, our repo structure is repo/docs/source/conf.py and the main __init__.py is in repo/adaptive/.
Now having jupyter_sphinx_rel_repo_path = '../' in conf.py will give the following output to import sys; print(sys.path)
['', '/Users/basnijholt/Work/adaptive', '/Users/basnijholt/miniconda3/lib/python37.zip', '/Users/basnijholt/miniconda3/lib/python3.7', '/Users/basnijholt/miniconda3/lib/python3.7/lib-dynload', '/Users/basnijholt/miniconda3/lib/python3.7/site-packages', '/Users/basnijholt/miniconda3/lib/python3.7/site-packages/IPython/extensions', '/Users/basnijholt/.ipython']

and before this was
['', '/Users/basnijholt/Work/adaptive/docs', '/Users/basnijholt/miniconda3/lib/python37.zip', '/Users/basnijholt/miniconda3/lib/python3.7', '/Users/basnijholt/miniconda3/lib/python3.7/lib-dynload', '/Users/basnijholt/miniconda3/lib/python3.7/site-packages', '/Users/basnijholt/miniconda3/lib/python3.7/site-packages/IPython/extensions', '/Users/basnijholt/.ipython']

A quick feedback: this feels wrong; the computational environment should be controlled by sphinx itself or by the jupyter kernels. We shouldn't be introducing a new way to do the same thing.
I'll think of an alternative solution.

I confirm, I rather believe the correct way around this is to document setting the correct PYTHONPATH.
There may be a need to also set the working directory, e.g. if the users need to process some external data. This is however uncommon in building documentation and I suggest to wait with introducing extra options before we have a clear use case.

I confirm, I rather believe the correct way around this is to document setting the correct PYTHONPATH

I concur; closing.


Available in Free Edition?

Are retention policies available in the free edition of Teams?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fb40cf43-557e-d443-578b-49edca4a3179
Version Independent ID: f78c9566-767f-bfae-7ba0-4e81d313034e
Content: Retention policies in Microsoft Teams - Microsoft Teams
Content Source: Teams/retention-policies.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@mcain1011 Thank you for submitting feedback and contributing to the docs. We are currently investigating this.


TypeError: client.on is not a function

Got this error when running example from readme...

Please post the exact code you ran here. I'll look into it

var MediaRendererClient = require('upnp-mediarenderer-client');
var client = new MediaRendererClient('http://<IP_ADDRESS>:4873/foo.xml');
console.log(client.on)

outputs undefined

I got the reason. I was using old version of package.

;) OK

BTW, @thibauts could you point the direction how to stream video from website (e.g. youtube or vimeo) on TV via mediarenderer-client ?


Update 0.4.11

Fix for a critical bug found in #266.

We found a better name for the Chainer v1 branch.


[Port] Add descriptions/validations for Arc connected mode deployment

Fixes https://github.com/microsoft/azuredatastudio/issues/13589 Fixes https://github.com/microsoft/azuredatastudio/issues/13590
See https://github.com/microsoft/azuredatastudio/pull/13676 for screenshots
Without this customers may get confused about what these values are and how to set them correctly.

Pull Request Test Coverage Report for Build 401804683

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 41.145%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/jupyter/serverInstance.ts
4
73.81%

Totals

Change from base Build 401719452:
-0.01%

Covered Lines:
21844

Relevant Lines:
48639

💛  - Coveralls


Fix pointer precedence  NSString * const is a constant pointer)

Fix pointer precedence. NSString const * is a pointer to constant string and we have a constant pointer to a string. Its fix compiler warnings too

Knocked off 10 compiler warnings for me.  Thanks.

Thanks!


Brand new release -Test please

I just released version 0.1.2 (master branch)
Can someone plz confirm it is working ?
Thanks

Not working :(
INFO [81032614] Running /usr/bin/env mkdir -p /tmp/my_prog/ as shims@localhost
INFO [81032614] Finished in 0.007 seconds with exit status 0 (successful).
INFO [77280bf3] Running /usr/bin/env chmod +x /tmp/my_prog/git-ssh.sh as shims@localhost
INFO [77280bf3] Finished in 0.007 seconds with exit status 0 (successful).
INFO [16fab3f3] Running /usr/bin/env mkdir -p /tmp/my_prog/ as shims@localhost
INFO [16fab3f3] Finished in 0.006 seconds with exit status 0 (successful).
INFO [c4386a19] Running /usr/bin/env chmod +x /tmp/my_prog/git-ssh.sh as shims@localhost
INFO [c4386a19] Finished in 0.007 seconds with exit status 0 (successful).
INFO [359d0a79] Running /usr/bin/env git ls-remote --heads config/../../my_prog.git as shims@localhost
INFO [359d0a79] Finished in 0.013 seconds with exit status 0 (successful).
INFO [1e908e68] Running /usr/bin/env git ls-remote --heads config/../../my_prog.git as shims@localhost
INFO [1e908e68] Finished in 0.015 seconds with exit status 0 (successful).
INFO [73130cd4] Running /usr/bin/env mkdir -p /var/www/my_prog/shared /var/www/my_prog/releases as<EMAIL_ADDRESS>INFO [73130cd4] Finished in 0.081 seconds with exit status 0 (successful).
INFO [ee8f474f] Running /usr/bin/env mkdir -p /var/www/my_prog/shared/log /var/www/my_prog/shared/tmp /var/www/my_prog/shared/public/assets /var/www/my_prog/shared/public/assets as<EMAIL_ADDRESS>INFO [ee8f474f] Finished in 0.087 seconds with exit status 0 (successful).
INFO [4b5111a0] Running /usr/bin/env mkdir -p /var/www/my_prog/shared/config /var/www/my_prog/shared/config as<EMAIL_ADDRESS>INFO [4b5111a0] Finished in 0.081 seconds with exit status 0 (successful).
INFO [1fb43d7d] Running /usr/bin/env mkdir -p /tmp/my_prog-repository as shims@localhost
INFO [1fb43d7d] Finished in 0.010 seconds with exit status 0 (successful).
INFO [c4a46aaf] Running /usr/bin/env git clone --verbose --mirror config/../../my_prog.git /tmp/my_prog-repository as shims@localhost
(Backtrace restricted to imported tasks)
cap aborted!
SSHKit::Command::Failed: git exit status: 32768
git stdout: Nothing written
git stderr: fatal: repository 'config/../../my_prog.git' does not exist
Tasks: TOP => gitcopy:create_release => gitcopy:create_tarfile => gitcopy:update => gitcopy:clone
(See full trace by running task with --trace)
The deploy has failed with an error: git exit status: 32768
git stdout: Nothing written
git stderr: fatal: repository 'config/../../my_prog.git' does not exist


Client does not work & gives error.

I don't really know what's the issue here

same problem

same

download the source
click on run.bat
then after it crashes (lmao) go inside \valorant-skin-cli-master\src and in startup.py change the region by yours,
Mine is EU so in line 44 replace the original text by this client = Client(region="eu")


Error fetching review time

I get the following error after a succesfull build, when running with the review time plugin:
Error fetching review time: undefined method `[]' for nil:NilClass

Stack:
fastlane 2.118.1
fastlane-plugin-review_time 0.1.0

Probably related https://github.com/timwredwards/fastlane-plugin-review_time/issues/5

Ah, I'm sorry. Yes, the site is now shut down and will not be coming back up. I didn't know this depended on it!


HDDS-9323. Better datanode exclude list handling for long-lived clients

What changes were proposed in this pull request?
Currently it is possible that a long lived client can add most or all nodes of a small cluster to its exclude list, and further writes using that client instance will fail. This PR add a timeout for RATIS key to remove datanodes from the exclude list so that they can be retried later.
(For EC key, this mechanism exists and is configured to 10 minutes by default.)
This improvement is especially relevant for S3 gateway, which uses a persistent Ozone client to connect to the cluster.
And there is another part of improvement that allows the write to fall back to datanodes in the exclude list if that is all available. This would be implemented as a retry from the client based on the server's initial error response.
This part of work is separated into another PR:  https://github.com/apache/ozone/pull/5514
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9323
How was this patch tested?
unit test

@DaveTeng0 please check integration test failures:
org.apache.hadoop.ozone.client.rpc.TestFailureHandlingByClient
org.apache.hadoop.ozone.client.rpc.TestFailureHandlingByClientFlushDelay

https://github.com/DaveTeng0/ozone/actions/runs/6818659142/job/18545006173

@DaveTeng0 please check integration test failures:
org.apache.hadoop.ozone.client.rpc.TestFailureHandlingByClient
org.apache.hadoop.ozone.client.rpc.TestFailureHandlingByClientFlushDelay

https://github.com/DaveTeng0/ozone/actions/runs/6818659142/job/18545006173

yup thanks attila! These two tests failure are on my radar!

note: there are unit test for ExcludeList.java already in https://github.com/apache/ozone/blob/master/hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/scm/container/common/helpers/TestExcludeList.java#L32

I think we should apply the same in streaming write:
https://github.com/apache/ozone/blob/2085ebeddb75def4a9ba4ce9ecf3c9d6b4d7584d/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockDataStreamOutputEntryPool.java#L86

oh yes you're right! updated.

@DaveTeng0 please merge master into your branch, it's 106 commits behind, and there is a conflict

@DaveTeng0 please merge master into your branch, it's 106 commits behind, and there is a conflict

oh sure! working on it!

Thanks @DaveTeng0 for the patch, @sumitagrawl for the review.


Create speech-bubble to contain About-Me Text

Adding to the design of the About Me page by creating a speech bubble in CSS.

Removed the blank lines


core[patch]: fix: Document should handle empty pageContent (fixes #5884)

Fixes #5884

This technically breaks the interface - why do we need to check for this?

Thank you! Generally against this kind of defensive check but since it's already there might as well fix it.


Bp exercise1

@bhpratt I'm going to bring in this review to our main forked review for consistency.


Missing classes in powerdata source

Hello,
It looks as if there are some missing powerdata classes in the source code.  The following

import com.powerdata.pd3.Column;
import com.powerdata.pd3.PDDB;
import com.powerdata.pd3.PDDBException;
import com.powerdata.pd3.View;

Are not available in the repository.

Sorry about that.
My guess is that those were included accidentally during internal testing.  I can review it later tonight and provide a fix.

The repository should now build properly.  Thanks.


Untyped access to docstore must be stopped

This covers predicates ds_get/2, ds_get/3 and ds_remove/1.

These will be provided by docstore 2.x

This was implemented with https://github.com/rla/blog-core/issues/113


openssl dgst -macopt hexkey not supported

The command
openssl dgst -sha256 -mac HMAC -macopt hexkey:FFFF -binary -out hmac.out

works on OpenSSL 1.1.1, but fails on 3.0.0 beta2 with
C00102FC167F0000:error:03000093:digital envelope routines:default_fixup_args:command not supported::0:[action:2, state:4] name=hexkey, value=FFFF

I came across this issue a couple of years ago (https://github.com/drwetter/testssl.sh/pull/1377). While I don't see anything at the moment saying that the above shouldn't work, the man page for dgst does say that the mac command is preferred. For OpenSSL 3.0.0, the above command may be replaced with:
openssl mac -digest sha256 -macopt hexkey:FFFF -binary -out hmac.out HMAC

Yeah, the trouble is that mac has been introduced in 3.0.0; it doesn't work with 1.1.1. The dgst should work with both, which is ideal for a migration period.

Yeah, the trouble is that mac has been introduced in 3.0.0; it doesn't work with 1.1.1. The dgst should work with both, which is ideal for a migration period.

Understood. This is an issue we deal with a lot in testssl.sh, since it needs to work with many different versions of OpenSSL and LibreSSL. In many places, such as for computing an HMAC, we check what version of OpenSSL/LibreSSL is being used and then make the appropriate call based on that. In other places, we test the OpenSSL/LibreSSL being used to determine what capabilities it has, and then use that information to tailor the calls that testssl.sh makes.

This was triaged at the last OTC call.  It's a bug, it needs to be fixed for 3.0.  It's a matter of when one of the fellows is able to prioritise it or someone else jumping in with a fix.

It looks like legacy paths are being used to set this without the legacy key being set up.


feat: Action redesign: Updating the config for SMTP plugin to use sections and zones format

Description
Action redesign: Updating the config for SMTP plugin to use sections and zones format
Fixes #35505
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10704929692
Commit: f58dfce0a2729442a0e1222762f97cc483e5459b
Workflow: PR Automation test suite
Tags: @tag.All
Spec: ``
Wed, 04 Sep 2024 15:35:30 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

New Features

Introduced a comprehensive email sending interface in the SMTP plugin, allowing users to input recipient addresses, subject, body type, and attachments.
Enhanced layout with a new DOUBLE_COLUMN_ZONE structure for improved organization of input fields.

Improvements

Expanded styling capabilities for the dynamic input text control, allowing for more flexible sizing and better responsiveness in the UI.
Updated existing configurations to streamline the email composition process and improve user experience.

Bug Fixes

Adjusted CSS rules to remove minimum height and width constraints for better adaptability of UI components.

/build-deploy-preview skip-tests=true

Testing completed on EE. Everything looks good.


Help with JFXPopup please! :)

Hello,
I'm trying to get the height of a pop-up but it is returning 0.
This is most likely because the pop-up hasn't been shown yet.
I've tried getPopupContent().getHeight() but that also returns 0.
Thanks,
Joshid
I'm trying to stop the pop-up from displaying off-screen; code:
    // Show the pop-up when the button is pressed
    colourBlockButton.setOnMouseClicked((event) -> {

        // Get the height of the pop-up
        double popupHeight = changeWorkPeriodPopup.getPopupContent().getHeight();

        // Get the current height of the scene
        double currentSceneHeight = ((Node) event.getSource()).getScene().getHeight();

        System.out.println("Pop-up Height: " + popupHeight);
        System.out.println("Mouse Height: " + event.getSceneY());
        System.out.println("Scene Height: " + currentSceneHeight);

        // If the mouse Y position added to the height of the pop-up is less than or equal to the size of the scene, then display the pop-up to the bottom right of the mouse
        if (event.getSceneY() + popupHeight <= currentSceneHeight) {
            changeWorkPeriodPopup.show(colourBlockButton, JFXPopup.PopupVPosition.TOP, JFXPopup.PopupHPosition.LEFT, event.getX(), event.getY());

            // Otherwise display the pop-up to the top right of the mouse
        } else {
            changeWorkPeriodPopup.show(colourBlockButton, JFXPopup.PopupVPosition.BOTTOM, JFXPopup.PopupHPosition.LEFT, event.getX(), event.getY());
        }

    });

Currently JFXPopup doesn't consider screen bounds, feel free to add your own contribution to JFoenix
Regards,


[Fix][Shell] Fix the issue where execution is not successful in source limit mode

Purpose of the pull request

Missing execution script.
The system does not recognize infinity.

Brief change log
Considering using 104857600M as a replacement for infinity, not sure if it's appropriate.

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d77bbcc) 38.53% compared to head (25635f9) 38.53%.

:exclamation: Current head 25635f9 differs from pull request most recent head 6248cda. Consider uploading reports for the commit 6248cda to get more accurate results

Files
Patch %
Lines

...sk/api/shell/BaseLinuxShellInterceptorBuilder.java
0.00%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15568   +/-   ##
=========================================
  Coverage     38.53%   38.53%
  Complexity     4772     4772
=========================================
  Files          1310     1310
  Lines         44880    44846   -34
  Branches       4808     4786   -22
=========================================
- Hits          17294    17281   -13
+ Misses        25704    25684   -20
+ Partials       1882     1881    -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New: Add connector-edge

This add the code from https://github.com/sonarwhal/connector-edge into the main repo.
To test this you need to manually do a npm install, otherwise yarn will complain on Windows (and this connector only runs on Windows).

This fixes: https://github.com/sonarwhal/connector-edge/issues/22.

Merged with some modifications in: https://github.com/sonarwhal/sonarwhal/commit/e57c089d348496cd15df375f709479e6e51f3701.
Also, for the time being I also made yarn ignore this workspace.


Fix jump at end of flights.

Fixes #1332
I wrote in the linked issue that I didn't think it was worth fixing the problem, versus porting the flight code from CesiumJS. But then I realized the fix is really easy: just scale the positions to the ellipsoid before computing the start and end directions. So here it is.

Thanks @kring !
Reviewed and tested out in 2 cesium-unreal-samples levels (sublevels, google tile).
Merging...


register agent rest and transport actions

Description
Register Agent rest action and transport action.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[ant:jacocoReport] Rule violated for class org.opensearch.ml.action.agents.TransportRegisterAgentAction: branches covered ratio is 0.0, but expected minimum is 0.7

[ant:jacocoReport] Rule violated for class org.opensearch.ml.action.agents.TransportRegisterAgentAction: branches covered ratio is 0.0, but expected minimum is 0.7

The new UT tests meet the bar.


Functional tests are too specific to default config values

If I try to run the functional (behat) tests on my local install for Lone Star PHP, tests will fail. The tests fail because they're looking for specific dates that are default values. I think the behat tests should be re-evaluated to avoid testing default values from the config and text that will most likely change from each install. I think if we put the emphasis on testing flash messages to verify expected outcome that those tests will yield a greater value.

Functional tests have been removed in favor of improving controller coverage through unit tests. Behat suite was completely intended to provide rough "coverage" over most important use-cases while a large refactor happened a while ago.
An abstraction providing information on whether or not the CFP is open is now available (CallForPapers->isOpen()) that is meant to be used as configuration dependency of service layer implementations. In this way, testing boundaries is easier as mocking that dependency (or simply new-ing it up with an intended date) is possible.


feat: add support for EV codesigning certs via azuresigntool

This feature adds support for EV code signing via azuresigntool.exe. The original method using using signtool.exe still works. But if the environment variables are set properly before running tauri build, the Tauri bundler will attempt to use AzureSignTool.
To use AzureSignTool, the user must have an EV certificate hosted in Azure Key Vault.

due to the complexity of the azuresigntool package, I removed it from the binary and it'll need to currently be preinstalled on the host machine. With GitHub runners, this should be possible by running  dotnet tool install --global AzureSignTool before executing the Tauri build command

@lucasfernog should we bump the rust min version on the main crate too? I had to bump it to 1.72 on the CLI crate because of the dependency for jsonschema -> aHash (aHash requires 1.72)
https://github.com/tkaitchuck/aHash/pull/196

if you want, that would be appreciated, otherwise we can fix it in another PR

cc @lucasfernog about https://github.com/tauri-apps/tauri/pull/8718#pullrequestreview-1870698873

I am not sure if we should support azuresigntool tbh since it is not an official tool (correct me if I am wrong), should we instead provide a generic option to specify a command to signing command, similar to this<EMAIL_ADDRESS>
It gets complicated when you think about how complicated it is to sign a Windows app.. we need a better solution, and this might be one (I still didn't run through it yet, hopefully when I get back from vacation).

@lucasfernog should we bump the rust min version on the main crate too? I had to bump it to 1.72 on the CLI crate because of the dependency for jsonschema -> aHash (aHash requires 1.72)
tkaitchuck/aHash#196

Yeah we should.. we need to do a better job on the msrv for the CLI

@lucasfernog should we bump the rust min version on the main crate too? I had to bump it to 1.72 on the CLI crate because of the dependency for jsonschema -> aHash (aHash requires 1.72)
tkaitchuck/aHash#196

Yeah we should.. we need to do a better job on the msrv for the CLI

@lucasfernog @amrbashir should we then bump both the CLI and Core, or just CLI?

if you want, that would be appreciated, otherwise we can fix it in another PR

I think we should do it in another PR, since it looks to be completely unrelated to this change

that's ok we can do that separately

@lucasfernog MSRV for cli is updated

I am not sure if we should support azuresigntool tbh since it is not an official tool (correct me if I am wrong), should we instead provide a generic option to specify a signing command, similar to this https://github.com/crabnebula-dev/cargo-packager/blob/ec1a3a12296275341fd59c083d98202de316805f/crates/packager/src/config/mod.rs#L1206-L1214?

+1. We just got our new digicert token and it would be nice to be able to just call our own signing script. Otherwise, I could see this just growing and growing.

I agree, @tr3ysmith would a generic command work for you as well?

thanks @tr3ysmith hope you're doing great, let me know if I can help with anything

Hi @tr3ysmith I have opened https://github.com/tauri-apps/tauri/pull/9865 to implement the custom signing command, gonna close this PR now in favor of that one

@amrbashir no problem, is this something that'll get merge into 1.x at all?

there is a PR to backport it in #9902


CheckMK Discovery failed

Hi
First thanks for that plugin!
It is working on my site pretty well but the discovery fails with this message:
no unmonitored services found, no vanished services found, no new host labels, Parsing of section pure_arraydetails failed

Sure, how can I get that trace? I don't find a crash report

Pls first try the 1.2 Version if possible. There was an recent incoming pull request for this plugin.

If you can send me the Agent Output<EMAIL_ADDRESS>I will build a fix.

Fixed


#86 Use Roboto Flex

Replacing Roboto with Roboto Flex seems to reduce the amount of data loaded into client browser.

+1, Roboto Flex seems to be the recommended font for Material Design 3: https://m3.material.io/styles/typography/overview#a489db76-91b3-427a-b1a2-4bce4c76be6a


Duplicate response when using Alamofire from 5.0.0.rc3

Try to request to server
Duplicate response from server
Issue not happen if I try to use Alamofire 5.0.5-rc2.
We also tried to check result from server by using ProxyServer.
We found the result from server is correct.
But data received by Alamofire was duplicated.
Alamofire Environment
**Alamofire version:After 5.0.0-rc2
**Xcode version:Any
**Swift version:4.2
**Platform(s) running Alamofire:iOS
Demo Project
I tried to reproduce this issue with demo project. But I can not.

Issue was fixed if I comment these lines
            if mutableState.state.canTransitionTo(.resumed) {
                underlyingQueue.async { if self.delegate?.startImmediately == true { self.resume() } }
            }

In appendResponseSerializer function in Request.swift file

Please update to the latest version and try again.

Hi
The issue still persist with latest release.
The issue not happen with 5.0.0-rc2 only.

Can you post any sort of example code that triggers the issue? What are you actually seeing? Is the response handler called more than once? What do you mean by "data received by Alamofire was duplicated"?

We can not reproduce this issue in demo project with the same code.
I mean we try parse data recieved from alamofire we see json was duplicated.

JSON was duplicated? You mean the response Data contained two JSON payloads?
Please provide directions to replicate your issue using the demo project.

Yes. The response Data contained two JSON payloads.
Sorry but we can not reproduce it using demo project with the same code.
We still checking it.
Have any other way that you can support us.
Note:
With Alamofire 5.0.0-rc3 the issue was fixed if I comment out these lines in appendResponseSerializer function in Request.swift file
                underlyingQueue.async { if self.delegate?.startImmediately == true { self.resume() } }
            }

But with latest release. It was stuck and alamofire never response data.

I'm sorry but that doesn't make sense: all that line does is resume() the request if the Session was created with a true startRequestsImmediately. And in the release versions of Alamofire 5, that won't happen until at least one response handler is attached. Perhaps that's your issue on the release versions? You need to add a response* handler to your requests for them to automatically start or otherwise call resume() on them.

This is example code show how we using Alamofire
       let request = AlamofireManager?.request(url, method: method, parameters: parameters, encoding: encoding, headers: cumulateHeader)

        request?.validate(statusCode: 200..<300).responseData(queue: self.queue, completionHandler: { response in
            completionHandler(source, response)
        })

Hi sorry my mistake.
With Alamofire 5.0.0-rc3 the issue was fixed if I comment out these lines in appendResponseSerializer function in Request.swift file
//            if mutableState.state.canTransitionTo(.resumed) {
//                underlyingQueue.async { if self.delegate?.startImmediately == true { self.resume() } }
//            }

We also need to reset this function
         request.withState { state in
-            switch (startRequestsImmediately, state) {
-            case (true, .initialized):
-                rootQueue.async { request.resume() }
-            case (false, .initialized):
+            switch state {
+            case .initialized, .finished:
                 // Do nothing.
                 break
-            case (_, .resumed):
+            case .resumed:
                 task.resume()
                 rootQueue.async { request.didResumeTask(task) }
-            case (_, .suspended):
+            case .suspended:
                 task.suspend()
                 rootQueue.async { request.didSuspendTask(task) }
-            case (_, .cancelled):
+            case .cancelled:
                 // Resume to ensure metrics are gathered.
                 task.resume()
                 task.cancel()
                 rootQueue.async { request.didCancelTask(task) }
-            case (_, .finished):
-                // Do nothing
-                break
             }
         }
     }

Use the 5.0.0-rc2 version help me fix the issue.

btw, do you have any version of Alamofire with the AlamofireLog.
We will try to run and show you the log.
Thanks

There is no built in logging. From the look of your changes, you're dealing with duplicate response handler calls, not duplicate Data, as those changes would have no effect on that. We've fixed a few state issues like that in the release versions of Alamofire 5, so you should update to the latest version and try again without your changes.

The issue still existed with release 5.1.0.
That's the reason we must check one by one release to find the root cause of this issue.
Thanks,

Please produce a test case that can produce this issue, as nothing you've posted so far makes it clear what you're talking about. Are you talking about the response handlers getting called twice, or there somehow being two JSON responses in a single response Data?

My issue is two JSON responses in a single response Data.

I’m sorry, but I can’t see how the code changes you’ve posted could affect something like that. Could you post your response body?

This is example of json response
Two json was merged in a single response.
{"_etag":"d41d8cd98f00b204e9800998ecf8427e","_items":[],"_range":{"limit":100,"offset":0,"hasNext":false},"_links":{}}\n{"_etag":"d41d8cd98f00b204e9800998ecf8427e","_items":[],"_range":{"limit":100,"offset":0,"hasNext":false},"_links":{}}\n

There’s nothing in Alamofire that can do that. I suggest you set a breakpoint inside the SessionDelegate’s didReceiveData and see the Data you’re receiving over the network directly.

I can not find function didReceiveData in SessionDelegate
Can you tell me more details.

But I'm sure that response from server is correct.
I check it by using ProxyServer and check the response.

Are you expecting the newlines in the original response? Even if there was an Alamofire issue here, it would add newlines. You can also set a breakpoint in DataRequest’s didReceive method to see Data as it comes in.

I tried log data receive from alamofire.
This is the result
Result log in DataRequest's didReceice
ALAMOFIRE Optional(https://...../localizations?appVersion=4.3.0&latest=true&limit=100&offset=0&platform=ios) didReceive: Optional("{\"_etag\":\"d41d8cd98f00b204e9800998ecf8427e\",\"_items\":[],\"_range\":{\"limit\":100,\"offset\":0,\"hasNext\":false},\"_links\":{}}\n")
ALAMOFIRE Optional(https://......./localizations?appVersion=4.3.0&latest=true&limit=100&offset=0&platform=ios) didReceive: Optional("{\"_etag\":\"d41d8cd98f00b204e9800998ecf8427e\",\"_items\":[],\"_range\":{\"limit\":100,\"offset\":0,\"hasNext\":false},\"_links\":{}}\n")

this is the result in Alamofire response call handler from our side
ALAMOFIRE Optional(https://....../localizations?appVersion=4.3.0&latest=true&limit=100&offset=0&platform=ios) handleResponse: Optional("{\"_etag\":\"d41d8cd98f00b204e9800998ecf8427e\",\"_items\":[],\"_range\":{\"limit\":100,\"offset\":0,\"hasNext\":false},\"_links\":{}}\n{\"_etag\":\"d41d8cd98f00b204e9800998ecf8427e\",\"_items\":[],\"_range\":{\"limit\":100,\"offset\":0,\"hasNext\":false},\"_links\":{}}\n")

This look like didReceice was called twice.

Yes. If you set a similar breakpoint in SessionDelegate you should be able to see where that Data is coming from. It seems like you’re getting two separate relies to the same request.

That really hard to debug because this issue not happen 100% for all API.
It randomly for all API.
But from log I see SessionDelegate's didRecieve also was called twice.

And I'm sure this issue totally not happen in alamofire 5.0.0-rc2

That would indicate that you’re getting two payloads from the server. Especially with the newline, it would seem to indicate the server is expecting to send multiple payloads over the same connection.

But we never see this issue if I use alamofire 5.0.0-rc2
We also use ProxyServer to check server response. The response is correct :(

And I'm sure with you that the issue can be fixed if I revert some code as mentioned earlier. Even if I use Alamofire 5.1.0

I’m sorry, that doesn’t make sense. Nothing in the code you posted would change how Data is processed.
Could you post the endpoint you’re using, if possible?

Sorry we can not post the endpoint,
Even if you have the endpoint you also need token before create request to our server .
Here is our test case
Create request with postMan. -> success
Create request with Alamofire 5.0.0.rc2 -> success
Create request with Alamofire 5.0.0.rc2 and newer -> fail
Create request with Alamofire 5.0.0.rc2 and newer (And revert some code) -> success
I'm not sure how it effect, but that is the results I can check.

Update:
We found that our request also was called twice with alamofire 5
We still investigate the issue.

Certainly sounds like a client or server misconfiguration. Feel free to open a new issue if you can find an Alamofire issue with a reproducible test case.

If you think that client and server misconfiguration.
Can you show us which config should be added since alamofire 5.0.0-rc3.
This issue not happen if I use alamofire before 5.0.0-rc2, also not happen if I use alamofire 4.
Thanks for you help.

I can reproduce this issue with demo project
But I can not post project as public.
Do you have any private channel, I can share with you.
Thanks,

Feel free to email it to me at the address in my profile.


Question: How is window.__data being set by the server (and where?)

I'm looking into storing the redux state in localStorage to be loaded initially, but it seems that the server is already doing this somehow? I'm a little confused as to where the data is setting window.__data and assume its some library call doing it. Thanks!
Additionally we've moved away from sessions and towards a RESTful API but I'm worried about performance in terms of server side rendering / redux model storage and how thats working. I appreciate any advice!

It's being set in the HTML.js. No magic tricks, just a straightforward serialization. Here is the line in HTML.js:

I'm not sure I understand the second question so if you can elaborate more I will try to answer.


Editing / Deleting Personas should be only allowed for the Autor and Admins

Hello :)
I would love to see a Feature, where we have some rights in place for editing Personas, because I think it's a good idea,
that editing and deleting Personas should be only allowed for the Autor and Admins.
I might want to implement it by my self and create a PR. Let's see if I find some time.
Thank you very much.

I think its already implemented, right?


Kamir patch 1

@kamir => https://github.com/apache/incubator-wayang/actions/runs/10523010386/job/29156852391?pr=464#step:7:747
There is a NullPointerException in a test, blocker or not?


Variables for energy storage

The NAVIGATE and ENGAGE projects had variables for storage as a sub-category of "Secondary Energy|Electricity|...", which doesn't seem quite right. This issue is to discuss better approaches for capturing that information.

Per a suggestion by @robertpietzcker and @Renato-Rodrigues, we should clearly distinguish between reservoir vs. generation (and charging) capacity, e.g.

Capacity|Electricity|Storage|Generation
Capacity|Electricity|Storage|Charging
Capacity|Electricity|Storage|Reservoir

Actually, I would think only the first and the last variable are necessary - I am not sure that there is any reliable data on the difference between generation and charging capacity (both in GW) (beyond the exception of electrolysis).
So before inflating the number of variables, I would be happy with only having

Capacity|Electricity|Storage|Power        [in GW]
Capacity|Electricity|Storage|Reservoir   [in GWh]

(or if you have a strong preference, I would also be fine with "Generation" instead of "Power", although I have a preference for "power" because often "generation" is the header used for energy output (in GWh))

Ok, now I am confused :-)
the first post by @danielhuppmann referred to energy flows from storage, but didn't exactly say about which variables he was unsure;
The second one, also by @danielhuppmann referred to capacity variables.
My reply above was only targeted at the capacity questions - and I would say there the answer is straightforward, namely implementing these two variables:

Capacity|Electricity|Storage|Power [in GW]

Capacity|Electricity|Storage|Reservoir [in GWh]

(or something similar, if there are specific wishes about the exact naming of these)
maybe we could use this issue to finalize the capacity question, and if there are further questions about energy flow variables we can discuss them in a different issue once a specific question comes up?
(To me, the variables "Secondary Energy|Electricity|Storage" and subclasses of that such as "Secondary Energy|Electricity|Storage|Batteries" or so seem reasonable and have been used in the past)


Add a script for expunging old releases from releases.nixos.org

Since releases are the main garbage collector roots, this is the first step in doing garbage collection of cache.nixos.org. Also, the releases themselves take up a non-trivial amount of storage (~32 TiB).
The policy implemented by this script is that it keeps all releases in the 23.05 series or newer. Below that, it groups releases together by parent directory and major release prefix (e.g. nixpkgs/22.11 or nixpkgs/19.03-darwin/19.03) and for each group, keeps the most recent release and expunges all the others.
Note: this script doesn't do anything yet, it just prints which releases/files would be moved to Glacier. To run:
$ aws s3 ls --recursive s3://nix-releases > bucket-contents
$ python3 ./expunge-releases.py > files-to-expunge

Current stderr output:
output.txt
Expunged 22188 releases, 208910 files, 23496.89 GiB.

Issue #282.

My current savings estimate for this data deletion would be $390/month, aka. 11% of the March 2024 bill which is primarily driven by bandwidth.
Unless we have a reason to think that these old releases represent a significant part of the data transfer costs? (I don't think they do, but I don't have access to the right logs right now to check.)

Sorry, because I came from the other bug (#408) I missed that this is suggesting moving stuff to Glacier and not straight-up deleting. I have no objection to that, I think it should be relatively free. But I also don't think it's a particularly significant amount of money saved, unfortunately. Probably about as much as we'd save by cleaning up the EC2 usage.
Not that I'm complaining, any savings are good.

Yeah, this is not primarily about cost savings directly, but about getting rid of GC roots for the cache.nixos.org cleanup.

OK, "The current plan is to reduce the S3 bill for releases.nixos.org by expunging old releases" as said on #408 gave me the impression that you were looking at this PR as the current plan to reduce the S3 bill for releases.nixos.org, sorry.


Microsoft.Azure.Services.AppAuthentication is deprecated

Serilog.Sinks.MSSqlServer is using Microsoft.Azure.Services.AppAuthentication which is deprecated by now.
MS suggests to switch to Azure.Identity library.
Is it possible for you to migrate this dependency ?

Hi @dandros!
Thanks for the input. I will take a look at migrating this. Although cannot promise when I will have time to do it. In the meantime a PR to help us with migration to Azure.Identity is always welcome. :)

Fixed with PR #424.


feat: add parser for powertech interact

:tada: This PR is included in version 3.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: