Issue 173 add lombok

Fixes #173 add lombok to entity classes.

Main Issue: #xyz
Motivation

Add lombok could significantly save coding effort, such as the getters , setters, no arg const, all arg const, toString, equials and  hashCode methods could be generated by Lombok.

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

[ ] doc
[ ] doc-required
[X ] doc-not-needed
[ ] doc-complete

Matching PR in forked repository

@zhajikun , main had it's history rewritten.  You will most likely delete your fork's version of main, pull it down from upstream, create a new branch of your fork's main, and re-add your changes.  I apologize for this inconvenience.
I also noticed the build is broken as well. Let me know if I can help in any way.

Sure. Will do as you suggested.

@joshfischer1108  Fixed PR as you suggested. Recloned your main branch, and PR back.

NOTE: Do not merge this PR.  It is being discussed here.


When DataFusion optimizer rewrites an expression, it should not change the expressions "name" / "identity" / "alias"

Background
Every expression in DataFusion has a name, which is used as the column name. For example, in this example the output contains a single column with the name "COUNT(aggregate_test_100.c9)":
❯ select count(c9) from aggregate_test_100;
+------------------------------+
| COUNT(aggregate_test_100.c9) |
+------------------------------+
| 100                          |
+------------------------------+

These names are used to refer to the columns in both subqueries as well as internally from one stage of the LogicalPlan to another. For example
❯ select "COUNT(aggregate_test_100.c9)" + 1 from (select count(c9) from aggregate_test_100) as sq;
+--------------------------------------------+
| sq.COUNT(aggregate_test_100.c9) + Int64(1) |
+--------------------------------------------+
| 101                                        |
+--------------------------------------------+
1 row in set. Query took 0.005 seconds.

Implication
DataFusion contains an extensive set of OptimizerRules that may rewrite the plan and/or its expressions so they execute more quickly. However, the optimizer rules must so
Because DataFusion identifies columns using a string name, it means it is critical that the names of expressions are not changed by the optimizer when it rewrites expressions. This is typically accomplished by renaming a rewritten expression by adding an alias.
Here is a simple example of such a rewrite. The expression 1 + 2 can be internally simplified to 3 but must still be displayed the same as 1 + 2:
❯ select 1 + 2;
+---------------------+
| Int64(1) + Int64(2) |
+---------------------+
| 3                   |
+---------------------+

Looking at the EXPLAIN output we can see that the optimizer has effectively rewritten 1 + 2 into effectively 3 as "1 + 2":
❯ explain select 1 + 2;
+---------------+-------------------------------------------------+
| plan_type     | plan                                            |
+---------------+-------------------------------------------------+
| logical_plan  | Projection: Int64(3) AS Int64(1) + Int64(2)     |
|               |   EmptyRelation                                 |
| physical_plan | ProjectionExec: expr=[3 as Int64(1) + Int64(2)] |
|               |   EmptyExec: produce_one_row=true               |
|               |                                                 |
+---------------+-------------------------------------------------+
2 rows in set. Query took 0.001 seconds.

If the expression name is not preserved, bugs such as https://github.com/apache/arrow-datafusion/issues/3704 and https://github.com/apache/arrow-datafusion/issues/3555 occur where the expected columns can not be found.
Problems
There are at least three places that we have rediscovered the issue of names changing when rewriting expressions such as https://github.com/apache/arrow-datafusion/issues/3704, https://github.com/apache/arrow-datafusion/issues/3555 and https://github.com/apache/arrow-datafusion/blob/master/datafusion/optimizer/src/simplify_expressions.rs#L316
I tried to consolidate this learning into https://github.com/apache/arrow-datafusion/pull/3727 but , as @liukun4515  has pointed out https://github.com/apache/arrow-datafusion/pull/3727#issuecomment-1269276333 , there are likely several other places that have similar bugs lurking

There are currently two ways to create a "name" for an expression in the logical plan.
    /// Returns the name of this expression as it should appear in a schema. This name
    /// will not include any CAST expressions.
    pub fn name(&self) -> Result<String> {
        create_name(self)
    }

    /// Returns a full and complete string representation of this expression.
    pub fn canonical_name(&self) -> String {
        format!("{}", self)
    }

I have seen that we sometimes use name when we should use canonical_name instead.

I have stolen the great content in this PR and included it in https://github.com/apache/arrow-datafusion/pull/3788

I believe this has been resolved for quite some time and there is an automated check that optimizer rules don't change the schema during rewrite


Initial implementation of session

Change Description
This PR contains a new set of types to hopefully replace the current undo stack implementation.  This version contains an iterator on the session type that will collapse the current state of the session list and iterator over that.  An alternative implementation will be presented in another PR.
Change Type
Select ONE

[ ] Documentation

[ ] Stability bug fix

[x] Other

[ ] Other - special case

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

Updated.

Updated.  This is ready for merging into feature branch.  Remaining comments will be taken care of in 2.1.


Scanlators & Authors included in the Dynasty Scans Source

Source name
Dynasty Scans
Source link
https://dynasty-scans.com/scanlators & https://dynasty-scans.com/authors
Source language
English
Other details
Much like the Dynasty Scans source already has Issues, Chapters, etc., include Authors and Scanlators as well.
Fetching the Scanlators work would be easiest, as not all have websites they post to (which would be preferred for a source to be made from), instead they post directly to certain sources.
Authors is less viable, but I think it would also be useful.
(I think both of these would be good for the MDex source as well, especially Scanlators for a similar reason. But I don't know if MDex is built in a way that makes it easy.)
For me, I see both being setup similar to how the Doujins part of the extension sorts things.
Acknowledgements

[X] I have checked that the extension does not already exist by searching the GitHub repository and verified it does not appear in the code base.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[X] I will fill out all of the requested information in this form.

Wrong issue template used, should have been a feature request.


Improve Error Handling and Readibility for downcasting Date32Array

Which issue does this PR close?

Part of #3152.
Rationale for this change

It is very clear in the issue but there are different schemas while downcasting an ArrayRef  to a related arrow array type. This is the first PR of improving downcasting to arrow array types. As it is seen, this PR is small but I am hoping to see what I am doing right and wrong.
What changes are included in this PR?

datafusion\common\src\cast.rs is created. Moreover, I think future downcasting functions will be written in it.
Refactor parts where following line is used:

as_any().downcast_ref::<Date32Array>().unwrap()

This commit passed related tests.

Are there any user-facing changes?

I am not sure about it.

what do you think @avantgardnerio ?

I 100% agree with the intent of the PR: even if they "never happen at run time" panics (and unwraps, etc) create cognitive load on the programmer to mentally statically prove that to themselves every time they look at the code, so we should just eliminate them to the extent possible.
As far as implementation, as I become more proficient at Rust, I increasingly see the importance of like this being discoverable... is it possible to make this change in arrow::ArrayRef? Or to do a Date32::TryFrom trait? In the sea of code I wade through every day, anything that autocompletes is a lot more likely to get used.

Thanks @retikulum -- looks neat. I left some suggestions but basically this is the right track I think
what do you think @avantgardnerio ?

Thanks for great feedback @alamb . Your recommendations generally improve my style to write Rust. I will make necessary changes.

what do you think @avantgardnerio ?

I 100% agree with the intent of the PR: even if they "never happen at run time" panics (and unwraps, etc) create cognitive load on the programmer to mentally statically prove that to themselves every time they look at the code, so we should just eliminate them to the extent possible.
As far as implementation, as I become more proficient at Rust, I increasingly see the importance of like this being discoverable... is it possible to make this change in arrow::ArrayRef? Or to do a Date32::TryFrom trait? In the sea of code I wade through every day, anything that autocompletes is a lot more likely to get used.

Hi @avantgardnerio. Thanks for the feedback and for joining the conversation. As far as I understand, We are on right track but we need to decide how to implement those changes. Also, this is discussed in #3152. @alamb what do you think about implementation? Should we continue creating functions in datafusion\common\src\cast.rs or create a different schema? If we will follow a different path, could you also help me out with how it is implemented?

Thanks for great feedback @alamb . Your recommendations generally improve my style to write Rust. I will make necessary changes.

We are all learning this together! Thank you for all your contributions so far

Since there were no more comments, I fixed the suggested parts.

I agree -- we are making progress -- I figured I would merge this PR in and we can continue to improve the code as follow on PRs


'Characters' in Statistics are counted incorrectly

Hi,
While testing Poedit's Statistics feature, I've noticed the Characters counting is incorrect.
Test case (though I don't think it matters): Poedit's Hebrew translation (from Crowdin).
STR:

Open the hebrew po file.
Select all strings > Ctrl+K to remove all translations.
Open Statistics, you'll see Characters = 0. It's OK up until now.
Take whatever string you like and enter one character (no spaces).
Although only one character was entered, Statistics counts it as 2!
Just for the fun, take another string and enter again one character.
Poedit will count it as 4.

Is that a bug or am I going crazy?
If you need more info tell me.
Thanks.

Confirmed reproduction 🙁
My guess is that it must be related to bidi control characters being counted as spaces (and hence included).

I don't suppose you would normally consider Unicode control characters (e.g. switching between LTR and RTL within text) as “characters” for billing purposes, would you?

My guess is that it must be related to bidi control characters being counted as spaces (and hence included).

Also tried entering english characters in the translation section and the results are the same.

I don't suppose you would normally consider Unicode control characters (e.g. switching between LTR and RTL within text) as “characters” for billing purposes, would you?

Sorry, couldn't understand the question.
I've tried entering many weird characters (such as ԅ, Ӎ, ֍, ۞, ₨ (this one is one character), ₦ etc (taken from charmap in Windows) and all are counted the same.

I think I know the reason for the bug.
Take any text, input whatever character you like. Now while you're focusing on that Translation field, select all text with Ctrl+A. You'll see there's a space after the character you typed, although you didn't enter any spaces.
In short, Poedit seems to enter space after any translation by it's own, thus counting it as 2 characters instead of 1.
Of course, that's just my theory :)
If that is the case and there's no easy direct fix for it, then an easy workaround is:
If SumOfCharacters = 0, Count == 0
else Count == SumOfCharacters-1
I'm no developer, but it seems reasonable for me :-P
Thanks.

Sorry, couldn't understand the question.

Never mind, that you have no idea that there are directional control characters in bidi text answers my question :)

there's a space after the character you typed,

Not true. There may, however, depending on your locale and the language of the file being edited be control characters in there.

then an easy workaround is:

The actual issue is a bit more involved than that… Don't worry, I'm on it.

Oh well. As long as you know what your'e doing :)

Should be fixed in this build: https://jumpshare.com/v/CuhDhrLDAQvYLigNG2sz

Yes, seems to work OK in this build :)
You can close this one out if you like.


Cleanup of branches

Would like to have clear picture which branches are still active to make sure that no open development thread is lost.
Generally:

let's delete all merged branches (removes already half of them)
look at the very old ones and decide if it is useful

What would be the best way to document open development in branches? Would it make sense to open a draft pull request describing for these branches to describe what the intention is?
Following branches are not ahead of master and I suggest to delete them:

[ ] https://github.com/gammasim/gammasim-tools/tree/testeff_table

Following branches are fully merged and I suggest to delete them:

[x] https://github.com/gammasim/gammasim-tools/tree/mongodb
[x] https://github.com/gammasim/gammasim-tools/tree/tunnel_username
[x] https://github.com/gammasim/gammasim-tools/tree/upload_files_to_db
[x] https://github.com/gammasim/gammasim-tools/tree/fix_db_doc_string
[x] https://github.com/gammasim/gammasim-tools/tree/remove_ssh_tunnel
[ ] https://github.com/gammasim/gammasim-tools/tree/psf-tuning

Following branches are in development (possibly stalled)

[ ] https://github.com/gammasim/gammasim-tools/compare/docs --> active
[ ] https://github.com/gammasim/gammasim-tools/compare/calc-nsb-camera-efficiency --> active
[ ] https://github.com/gammasim/gammasim-tools/compare/comp-resources --> active (requires some conflict solving)
[ ] https://github.com/gammasim/gammasim-tools/compare/trigger-rate-simulations --> I guess this is active?
[ ] https://github.com/gammasim/gammasim-tools/tree/fixing-bug-nectarcam-pulse-shape --> don't know what the status is?
[ ] https://github.com/gammasim/gammasim-tools/tree/sites --> some development on layout plotting?

Style editing only? Cannot be merged at this point - should we delete that, as we pick up style now with CI?

[x] https://github.com/gammasim/gammasim-tools/compare/simtel-cfg-location

I don't understand this branch?

[x] https://github.com/gammasim/gammasim-tools/tree/gh-pages

Deleted all of my merged branches (why is not done automatically like in Gitlab?).
The sites branch technically is waiting for you @GernotMaier since I implemented some layout plotting there that we said we will expand once you have a chance to look at it. Because we are always too tight with time, we kept the separate layout package instead.
The rest of the branches are Raul's, he should comment.

Do we have written up somewhere what we want to do with the site branch? I think we need to change something to better document what is the goal of branches.

No I don't think we need to do that. A branch should live a short life with a definite goal and deleted afterwords. The documentation of what we want to do development wise is in the issues.
The site branch case is an anomaly that I am happy to delete and forget about it. When the need rises again, we can go back to it.

[ ]  https://github.com/gammasim/gammasim-tools/compare/docs --> active
[ ]  https://github.com/gammasim/gammasim-tools/compare/calc-nsb-camera-efficiency --> active
[ ]  https://github.com/gammasim/gammasim-tools/compare/comp-resources --> active (requires some conflict solving)
[ ]  https://github.com/gammasim/gammasim-tools/compare/trigger-rate-simulations --> I guess this is active?
[ ]  https://github.com/gammasim/gammasim-tools/tree/fixing-bug-nectarcam-pulse-shape --> don't know what the status is?

These are mine and they are in principle active. I will try to merge or delete them next week.

Style editing only? Cannot be merged at this point - should we delete that, as we pick up style now with CI?

[ ]  https://github.com/gammasim/gammasim-tools/compare/simtel-cfg-location

This I can merge and delete.

I don't understand this branch?

[ ]  https://github.com/gammasim/gammasim-tools/tree/gh-pages

This is where the documentation is automatically built by the CI. We do not touch it, just let it there.

How does the documentation building works?
I guess this is
https://github.com/gammasim/gammasim-tools/blob/master/.github/workflows/CI-docs.yml
and it writes to a branch with all the html pages? That branch has otherwise no connection to the code base and our repository?

[ ]  https://github.com/gammasim/gammasim-tools/tree/psf-tuning

Why didn't you delete this one?

How does the documentation building works?
I guess this is
https://github.com/gammasim/gammasim-tools/blob/master/.github/workflows/CI-docs.yml
and it writes to a branch with all the html pages? That branch has otherwise no connection to the code base and our repository?

That is exactly it!

The gh-pages thing is a pattern in github. It was done like that before when we were using Travis CI and it is done similarly now with github CI.


Delete old README

I don't think the old README belongs in the project space anymore.  It looks cluttered and can be misleading to new users.

Any chance of merging this? I found it confusing to see two readme's...


Static login page

To make search engines like the login page more, we'd be better to make it static so that each languages would have their own urls.
English: station.ruuvi.com
Finnish: station.ruuvi.com/fi
Swedish: station.ruuvi.com/sv

enable indexing

White background for input field


configuration fails when using fallback

A couple of examples are here:
https://github.com/unicredit/shocon/tree/fallbackFail
one problem is probably in the parser that doesn't split keys on "." character.
the other is in the resolution of fallback ...probably...

will look into it

I think this is now fixed. We need more test cases, though (e.g. Arrays) but tests now pass.
I've split the test case you gave into two and added a few more.
Now:

fallback uses a stack of shocon.Config.Object
when a shocon.Config.Object is parsed the shocon.Config.Object.fromPairs() routine is used. This transforms flat keys of the form foo.bar.baz into nested trees of Objects and then merges the trees by key.

this should be closed


Text loses highlight after trying to change font.

When I highlight a text to change font, the text loses the highlight after I click on toolbar to select a font. Once I select the font, the text gets highlighted back.
Expected behaviour is, the text should be highlighted all the time.
Appreciate the help in advance. Thank you.

Plain Quill does this, too: https://codepen.io/alexkrolick/pen/awRxWz
I'd check upstream if there is a fix.


listenbrainz-mpd: init at 2.0.2

Description of changes
listenbrainz-mpd is a client for submitting your mpd listens to listenbrainz ("scrobbling").
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Build failing on darwin
= note: ld: framework not found Security

This can be normally fixed by conditionally adding the required frameworks  to buildInputs.


What is "Hotspot In Action"?

Hello, imkiva.
KiVM is inspired by Hotspot In Action.
Is "Hotspot In Action" a book or a blog? I can't find any information about it on the internet.
I am very interested in "Hotspot In Action".

If I recall correctly it is a Chinese book called 《HotSpot实战》.

Thank you🙏🏻


implement new Python 3.11 opcode: RESUME

With Python 3.11 a new Bytecode has been introduced: RESUME.
The documentation states that:
RESUME has been added. It is a no-op. Performs internal tracing, debugging and optimization checks.

And so, this is implemented as a NOP (no-operation) in Numba.

This would never be mergeable on it's own. Closing the PR, but the branch remains. See #8304


Spelling Mistake

"rrespective of whether they are using DHCP or static IP addresses " - Notice the "rrespective" is missing the "i" to make it "irrespective".
Found under Failover Timing header.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6ea27ad3-31a1-5893-a4f5-d9782c9b492b
Version Independent ID: 882d909a-ed50-f03d-302a-16e1b768e8a2
Content: Test failover to Azure in Azure Site Recovery
Content Source: articles/site-recovery/site-recovery-test-failover-to-azure.md
Service: site-recovery
GitHub Login: @rayne-wiselman
Microsoft Alias: raynew

@skmuzz Thank you for the valuable feedback,we are investigating the issue.

I submitted a pull request to fix the typo: https://github.com/MicrosoftDocs/azure-docs-pr/pull/46570
will close this thread now.


LI-8100A parsing - various error condition tests

Improves coverage of R/parse-8100A.R from 82% to 97% 🎉

Codecov Report

Merging #142 into master will increase coverage by 2.09%.
The diff coverage is 98.36%.

@@            Coverage Diff            @@
##           master    #142      +/-   ##
=========================================
+ Coverage   92.01%   94.1%   +2.09%
=========================================
  Files           8       8
  Lines         676     679       +3
=========================================
+ Hits          622     639      +17
+ Misses         54      40      -14

Impacted Files
Coverage Δ

R/parse-LI8100.R
97.84% <98.36%> (+15.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64fe05...cd82dd6. Read the comment docs.


Update test/end-to-end/README.md

https://github.com/xspec/xspec/blob/5565ad4913c5f761d49b214f10108dc3bc67275b/test/end-to-end/README.md#preparing-the-expected-report-files

Only the transient parts (href, id, datetime and file path) should be different.

CSS in HTML is also different. (https://github.com/xspec/xspec/pull/459#issuecomment-492746599)
This line should have been updated when CSS was made inline (#135).

fixed by #582


(feature request) way to specify a frequency for AKMandolin?

is there a way to specify a frequency (like oscillator) for mandolin to play? currently it seems to be using midi note to frequency.

if you play one string you can bend the note to the right frequency. There is only the polyphonic version of mandolin in AudioKit, but you could probably look at the source to make a mono version of one that takes frequency. Or hire one of us to do it for you.


GetUserInfoAsync returns only sub without other claims

Why does GetUserInfoAsync return only sub without other claims?
var discoveryResponse = client.GetDiscoveryDocumentAsync("some Authorization Url").Result;
var userInfoResponse = client.GetUserInfoAsync(new UserInfoRequest
{
    Address = discoveryResponse.UserInfoEndpoint,
    Token = token // access_token
}).Result;

After signed in I have in the response 'email' but when I call GetUserInfoAsync I don't have it. I pass to GetUserInfoAsync access_token maybe that? Because claims are in id_token but how I can return claims from GetUserInfoAsync in that case?
My code:
I have on the list of the IdentityResource 'email':
public static IEnumerable<IdentityResource> GetIdentityResources()
{
    return new List<IdentityResource>
    {
        new IdentityResources.OpenId(),
        new IdentityResources.Email()
    };
}

In the client I have 'email' and 'AlwaysIncludeUserClaimsInIdToken':
return new Client
{
    ClientId = clientId,
    AllowedGrantTypes = GrantTypes.Implicit,
    AllowAccessTokensViaBrowser = true,
    RedirectUris = { "some url" },
    PostLogoutRedirectUris = { "some url" },
    AlwaysIncludeUserClaimsInIdToken = true,
    AllowedScopes = new List<string>
    {
        IdentityServerConstants.StandardScopes.OpenId,
        "email"
    }
};

I pass scopes in the SignInAsync method:
await _accessor.HttpContext.SignInAsync(subject, new Claim(ClaimNames.Email, email));
In the requested scopes I have:
scope: 'openid email'

check the logs and see if that reveals more information.

Any update?


Added C# detector sample code

Based on JAVA detector code created by Martin Paljak

Thanks! Looks good


⚠ Jenkins Plugins Artifactory has degraded performance

In fa4d19f, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1138 ms

Resolved: Jenkins Plugins Artifactory performance has improved in da33783 after 32 minutes.


Feature/ch122 update startup process

Not part of the sprint but it could help.

Doesn't create Transactions DB, for some obscure reason.


reserved words in riot._tmpl

Since there's no Angular-like Filter,  I write this to debug
...

{ JSON.stringify(items) }

this.items = [ ... ]
...

but unfortunately I got nothing in the div element.
I found out that Riot evaluate this expression as
(function(v){try{v=d.JSON.stringify(d.items)}finally{return v}}).call(d)
which d.JSON is undefined.
Should we just add JSON in re_vars variable or you guys have better solutions?

@aurri I assigned this one for you.

Good catch. Instead of adding entire JavaScript vocabulary to the codebase, we chose to only exclude the words that might actually be used in expressions. This looks like a good candidate too. Thanks!

I don't think this is going to be an easy one to fix reliably with your current approach to compiling templates.  Using a list of known top-level keywords is prone to both false positives and negatives.  Here, @coolzilj hit a false negative, where 'JSON' wasn't in the keyword list.  I can think of others: parseInt/Float, isNaN, etc.  (And the current code will convert SI numbers like 1e6 into 1this.e6).  But if you expand the list too much, you run into false positives.  For instance, the current list makes it impossible to access a property called Date, which seems like a reasonable name for a field.  Other frameworks have solved this either by using a 'with' statement or by requiring explicit scoping (user must use this.foo, not just foo).

@curveship you are right. My feeling is that we continue using the current strategy and list the reserved words on our documentation. The logic needs to be moved from expressions to the javascript logic. For example:

 { val }

this.val = parseFloat(val)

I'm closing this one now. I'm sure we'll encounter more of these use cases and find a good balance or switch the strategy completely.

I seem to agree with what @tero said here.
It enforces you to keep complex logic from expressions, which is good. And it keeps riot lean too. Sounds like a win-win to me.
Makes sense to review that list of reserved words again:
https://github.com/muut/riotjs/blob/1ae9d4999e8151694a68fcbf9b27d1c290de991d/lib/tmpl.js#L44
Thinking of removing all global objects from it (just to avoid confusion on which ones are supported) and shortening it to just this|true|false|null|undefined. @tero, what do you think?
Also need to be clear about this in the docs.
I feel there actually might be some elegant solution for supporting global vars in expressions (without resorting to which, which is btw what we used initially). I also think I can imagine situations where I'd miss the access to global vars. Not to mention that having less things to explain and limitations to work around is generally better. So I guess I can still be convinced otherwise. But for now, this is how it works. If you need to do something more complex, do this in JS instead of a template.

Oops, apologies for misspelling your username @tipiirai ;)

What's the actual difference for the user if you remove the global objects from the list?

You just won't be able to use them in the expression. Lets say Date, a popular global object...
Currently this is possible:

{ new Date }

If we remove all global vars from the list, you'd have to work around this:

{ date }

this.date = new Date

So the question is: do we remove all global vars from that list, or hand-select and whitelist only the most commonly used ones, or think about supporting all global vars altogether.

I Wonder how big the global var list might be. Maybe we can utilize the compiler here?

That actually can be a really good idea! Thought about that too.
Would love to tinker with it.
Here's a complete list: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference

As for false positives mentioned by @curveship, seems that can be handled too with something like (either by tmpl or compiler):
this.Date || Date

Can all  properties handled that way? (this.x || x)

I think yes, it's just a matter of (this.x || window.x).
Can't wait to experiment with this. Looks like we can support about everything without much effort.

Awesome!

+1 for (this.x || window.x)

Global vars are now supported in expressions!
The fix was pretty simple actually: https://github.com/muut/riotjs/commit/c052d019bc449edd968b98e28c2bdb46edaba4e6

Awesome

Is there a way to disable the lookup in global variables? Now my templates start accessing global variables where I want a specific piece of data to be undefined within the tag :(

currently the global variables leak into the tag when the variable isn't available locally

I think that is the expected behaviour. navigator should not be undefined when working under browser environment. Maybe I don't understand everything here..

I was just assuming that within tag expressions everything is evaluated to the scope of the tag. But I see the need for accessing globals. In my case it's nicer to explicitly define the local variables to an initial state anyway.

Makes sense.
However, I think the current behaviour is what most developers expect.


yaml-style example

How do I get this to work using yaml-style actions please?
Should it be something like:
steps:
- uses: actions/checkout@v2
- name: Haskell Linter
uses<EMAIL_ADDRESS>with:
secrets: ${{ secrets.GITHUB_TOKEN }}

It seems using
env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

is the yaml usage. Would be nice to get further input/consensus if this is correct. I used the following as a reference/template to get haskell-lint-action working:
name: HLint

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

jobs:
  init:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses<EMAIL_ADDRESS>    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Source:
https://github.com/owestphal/HLintTest/blob/ffae7d8ac9fcc4d763770729b2a788db8b093e97/.github/workflows/hlint.yml#L1-L16

This now works on my repo, the fix as you say is:
env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}


[BEAM-816] Aggregators are now reported with full (prefixed) names

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @amitsela

Aggregators are now reported using the following hierarchical structure spark.[appId].driver.Beam.[appName].[aggregatorName].

Added some minor comments, ping me once ready and I'll merge. Thanks!

Let me know how it looks.

LGTM, I'll merge once Jenkins passes.

Jenkins failed on Dataflow IT test, unrelated to this PR. I'll merge.


Minor issue

If this is enabled it will nolonger compile.

it produces this  error

Was working fine up until latest commits.
Once disabled it will comile fine again.
Hope alls well your end BTW.

FM radio isn't working for on the me on 4040d04 fw either. It does the search and picks up the stations on correct frequencies but instead of the broadcast I can hear only constant noise.

Yes I think I broken the FM radio last night, I made a LOT of changes yesterday (all for the better - in the end), I'll find the problem.
Also, I've fixed the code_search compile bug.

Also is it possible to have a 64 to 108 setting for FM radio please?

I'll add the option, I just need to change the chips frequency band in real time, it covers only one band at a time ..

In my testing of compiling with ENABLE_FMRADIO_64_108 turned on, it takes the code size from ~59.4 Kb with ENABLE_FMRADIO_68_108 turned on to ~64.2 Kb. Does that sound about right with your testing, a 4.8 Kb addition for the

change the chips frequency band in real time

that OneOfEleven mentioned? I want the extra 4 Mhz too but I can't justify it at the cost of nearly 5 Kb of Flash.

FM Radio works ok now, just a minor issue - when bottom bar with signal parameters is displayed there is a audible clicking sound. Once the bar dissapears - the clicking sound stops. Not a big deal for me because it last only for a few seconds., I have just noticed it.

Yes I know about the clicking, it's caused by the digital stuff on the display lines, it causes a little RFI back into the RX with each display update.
That's why I only update and display the signal data for no more than 5 seconds, I then do one last display update without the signal data (to leave a tidier display text) then stop - in order to prevent the clicking.
Nothing can b e done about that I'm afraid, it's down to the hardware design.


collex to case pubsub communication changes

What and why?
How to test?
Trello
https://trello.com/c/LfRNodWI/528-s35a-replace-rabbit-with-pub-sub-collection-exercise-to-case

/deploy sinhaa

/deploy sinhaa

/deploy sinhaa

/deploy sinhaa


[TRACKING] Enable ObjectManipulatorGazeHover Unity-test in org.mixedrealitytoolkit.spatialmanipulation/Tests/Runtime/ObjectManipulatorTests.cs for XRI3 migration

Re-enable ObjectManipulatorGazeHover Unity-test in org.mixedrealitytoolkit.spatialmanipulation/Tests/Runtime/ObjectManipulatorTests.cs for XRI3 migration.
Note: Filing it as bug for easy reminder.
Related PR:
https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/pull/716
Branch:
https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/tree/feature/XRI3

@ms-RistoRK   This needs to be addressed before XRI3 support is released

Fixed in feature/XRI3 branch, closing this issue.


I can´t use the brush set - see no brushes

Hello ;D At first thanks for the great set of brushes ;D
But I have a problem with the set, under Win7 64 bit and Linux Mint 64bit, krita 3.0. I can´t see the brushes set. I have activate the bundle under resources. I wonder, that no more ppl has this problem or I make wrong.
Edit: The set bundle folder was empty, I have move the file in this folder and so is the problem fixed ;D
Greetings
Bogus

Hey,
Thanks for reporting the issue, and it's good to see you could solve the problem.
I'm closing this post, then. Enjoy painting/drawing ! :)


institution_id -- add homepage

The institution_id.json file contains a list of institution identifiers and associated postal addresses.  This file should / could contain more information such as homepage.
This would be useful in the further-info-url ES-DOC page.

@momipsl good suggestion, however not sure a format change will be something that is easy to implement, there may also be issues when there are consortia. Please add any additional suggestions to this thread

I have transformed CMIP6_institution_id.json and augmented it accordingly.  You can view the transformed file here.
It is used in the pyessv tooling chain.  So if CMIP6_institution_id.json changes then please let me know.

@momipsl :  The CMIP panel has been recently discussing how we might better provide status information about CMIP6 simulations.  One suggestion is to include a link to a "status" page from either the source_id or institution_id json files.  "homepage" wouldn't be appropriate.  Before we decide how to proceed, I need to understand what is being suggested here.   How did you get the "homepage" urls?  What is the pyessv tooling chain?  You say "if CMIP6_institution_id.json changes then please let me know", but aren't you here suggesting a change?  If so that will also impact lots of other folks.

@taylor13 has there been any update on this step? Or are we still awaiting guidance from the CMIP panel?

yes, the panel decided it would be good to be able to point folks to a url, when available, where they can find out status of CMIP6 simulations (or at least some information about a particular model's CMIP6 simulations (beyond what is available at ES-DOCs).
We need to decide what to call this URL (@momipsl has used "homepage" in his transformation of CMIP6_instituion_id.json, but that URL may apply to the institution, not the model's CMIP6 simulations).  We also need to decide whether the URL should be attached to "source" or "institution".
Finally, we have to make sure if this is added, it won't break anyone's software.  When we know how to proceed, the CMIP panel will contact the modeling groups asking for URL's.

@taylor13 there are situations like UKESM1-0-LL that will be run by 4 institutions, so we'll have to think about this and how we implement it, the institution_id/source_id pair is likely the only way to manage it.
I think what @momipsl has done will be fine for a generic institution_id based webpage, but this provides no real information, that a google search wouldn't provide

Good point.  Maybe for multiple institutions running a model, we could list multiple URLs.

@taylor13 pyessv is a (fairly) comprehensive vocabulary management library and web-service.  I presented it at the GO-ESSP meeting in Abingdon sometime in 2015 I do believe but there was little understanding of the problem and even less of the solution.  It is used across ES-DOC land wherever controlled vocabularies are in scope (i.e. pretty much everywhere).  I have written scripts to convert the WCRP CMIP6 CV's & ESG-F .ini files to the normative pyessv form.
It also support dataset and file id validation and facet extraction - features used in the dataset errata service.

@taylor13  The institution_id.json file that I linked to is designed to simply augment the WCRP CMIP6_institution_id.json file with some further information such as institutional homepage and consortia.   Basically pyessv is downstream from the WCRP CMIP6 files and at certain points pyessv simply augments WCRP CMIP6 vocabs.

@taylor13 Regarding linking to a simulation status page - the ES-DOC further-info page could be extended to expose such a link to the user.

@momipsl regarding your query above

if CMIP6_institution_id.json changes then please let me know

You may want to "watch" the repo for changes, so you can be notified when the institution_id.json file changes - see https://github.com/WCRP-CMIP/CMIP6_CVs/watchers
The latest change occurred 22nd May 4:49 AM PDT

@durack1 Actually I was considering writing a continuous deployment script that would 'watch' changes in the CMIP6_CVs repo.  Whenever a change occurred the script would update the pyessv normative vocabularies and reload the pyessv web-service vocabulary cache.
My main concern is being notified whenever one of the CMIP6_CV JSON files changes in the structural sense rather than content.  I.E. a schema change if you will.

@momipsl I believe such changes will be captured in the version tag, with the current version <IP_ADDRESS> and these components will change according to logic defined a while back and reproduced here:
Collection of reference CV’s (see https://github.com/WCRP-CMIP/CMIP6_CVs):
The reference CV’s build on information in the global attributes document.
The version number consists of 4 integers separated by “.” (e.g., “<IP_ADDRESS>8”)
The first digit is “6”, indicating the CV applies to CMIP6
The second integer is incremented when the structure/format of any of the CV’s changes or an entirely new CV is added to the CMIP6 collection.
The third integer is incremented whenever any change to existing content is made other than the addition or amendment of a “source_id” or “institution_id”
The fourth integer is incremented whenever a new source_id and/or institution_id is added or amended

@momipsl @taylor13 reviewing the content of this issue, it seems closing is a good idea. Please reopen if you believe further discussions are required


Attribute behavior should be improved

TL;DR: The module system in Snabbdom provides a powerful way to extend the core functionality, but it leads to conventions for vnode attributes that, as a newcomer to this project, I found counterintuitive and would like to improve.
Problem statement
For example, whereas with React.createElement, you would write something like createElement("a", { href: "/" }, "Home"), Snabbdom requires you to wrap attributes in an object called attrs so they can be handled by the attributes module: h("a", { attrs: { href: "/" } }, "Home"). I found this particularly unexpected when using JSX - a JSX snippet of Home will create an HTML element without an href: Home!
Proposal
I think the crux of the issue is that Snabbdom does not provide a mechanism for modules to specify a limited set of keys they will use to access data on a vnode. If a comprehensive list of these keys was maintained internally, any additional keys in the vnode data could be treated as attributes, rather than being disregarded. I think it would make the most sense to make this update in the h function, so both JS and JSX syntax would reap the benefits.
My preference would be for this to be the default functionality, but I suppose this might require a new major or at least minor release. If the maintenance team prefers, it should be possible to gate this functionality behind a configuration option in the init method to preserve backward compatibility.
It's worth pointing out that other projects like herp-inc/snabbdom-jsx provide functionality similar to what I'm describing. However, my point is the behavior of attributes is worth improving within this project, either by default or as a configuration option.
Barring this update, the readme should at least be updated to explicitly call out that JSX syntax still requires usage of the attributes module to assign attributes on elements.
Conclusion
I would appreciate feedback from a maintainer on these ideas. If an agreement is reached, I would be happy to create a pull request. Thanks for your time!

Besides the attrs, there is also the dataset:
https://github.com/snabbdom/snabbdom/blob/2e6ef1e3e8637c845dca3bed8e8b661b52b56cd4/test/unit/core.ts#L616-L619

Hi @bgradin. Thanks for sharing your thoughts. I definitely see where you're coming from. I like the separation between modules and think that one can get used to writing attrs. But what you're proposing definitely has advantages in terms of ergonomics.

I think the crux of the issue is that Snabbdom does not provide a mechanism for modules to specify a limited set of keys they will use to access data on a vnode.

Yes, that seems spot on. They do in practice operate on a limited set of keys (most just a single key) but this information is implicit in the code.
Here's an approach that anyone could use today to achieve the desired goal: Initialize Snabbdom with a module that handles any properties at the root of the data object as attributes unless they're used by other modules. To do this, the module could manually be told about the properties that it should ignore. Something like this:
const patch = init([
  classModule, // makes it easy to toggle classes
  propsModule, // for setting properties on DOM elements
  styleModule, // handles styling on elements with support for animations
  rootAttrsModule(new Set(["class", "props", "style"])) // it should also ignore built-in props like `hooks` an `key`
]);

The idea here is that rootAttrsModule ignores all properties in the set that it is given and handles all other properties as attributes. Of course this is a bit hacky as passing this list is a bit ad-hoc. Furthermore, for some modules (at least the thunks module, the properties they use internally is not documented. That being said, I think the approach would work just fine and could be a good way to achieve your goal and get some experience with how it pans out.
To make the above approach not hacky, each module could expose the properties that they operate on and the init function could support a special optional "fallback" module that is told about the properties used by all other modules and which is then allowed to handle all the remaining properties.
With that approach we wouldn't impose any "default" but would preserve the modular nature of Snabbdom.
Curious to hear you thoughts. If others are interested in this feature please do weigh in 😄

Thanks for the feedback @paldepind ! I love the idea of keeping the fallback behavior as an opt-in module. I'll work on a PR for that.

Howdy. I wrote a plugin a while ago to help compact the jsx features. I haven't tested it with thunks but it might work that way too.
https://github.com/geotrev/snabbdom-transform-jsx-props


Extend Results Link Expiration from 5 to 10 Days

After seeing a sharp uptick in the number of patients emailing into the support inbox with expired links, Tim Best reached out to our ISO to see if we could make some changes. We got the okay to up the expiration timer from 5 to 10 days.

will also change the failed attempt lockout number to 10 as part of this


Merci

I just wanted to say thank you for this little, wonderfully practical script!

Thank you for your feeback !


Random prompts to turn sync off

Issue Type: Bug
For a while now, I keep getting (seemingly) random prompts to turn sync off. Hitting "Cancel" in the dialog takes me through the flow to enable sync again.

VS Code version: Code - Insiders 1.44.0-insider (d7d1147d6b764a48b789000c03088ee9afabcd8a, 2020-03-31T08:22:34.682Z)
OS version: Darwin x64 19.4.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 2900)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
4, 3, 4

Memory (System)
16.00GB (0.14GB free)

Process Argv
-psn_0_7091907

Screen Reader
no

VM
0%

Extensions (67)

Extension
Author (truncated)
Version

vscode-base64
ada
0.1.0

vscode-browser-preview
auc
0.6.3

markdown-preview-github-styles
bie
0.1.6

LinkCheckMD
bla
0.3.1

better-toml
bun
0.3.2

solargraph
cas
0.21.1

npm-intellisense
chr
1.3.0

path-intellisense
chr
1.4.2

vscode-npm-source
dku
1.0.0

binary-plist
dni
0.4.0

gitlens
eam
10.2.1

EditorConfig
Edi
0.14.4

vscode-npm-script
eg2
0.3.11

prettier-vscode
esb
3.20.0

code-runner
for
0.9.17

vscode-pull-request-github
Git
0.15.0

rest-client
hum
0.23.2

customize-ui
ioc
0.1.34

monkey-patch
ioc
0.1.7

bats
jet
0.1.7

ReplaceWithNewline
jma
0.0.1

docthis
joe
0.7.1

vscode-peacock
joh
3.6.0

azure-pipelines
ms-
1.165.1

vscode-apimanagement
ms-
0.1.2

vscode-azureappservice
ms-
0.16.4

vscode-azurefunctions
ms-
0.21.0

vscode-azurestorage
ms-
0.9.0

vscode-docker
ms-
1.0.0

csharp
ms-
1.21.15

vscode-edge-devtools
ms-
1.0.7

vscode-aks-tools
ms-
0.0.4

vscode-kubernetes-tools
ms-
1.1.1

python
ms-
2020.3.69010

remote-containers
ms-
0.109.0

remote-ssh-edit-nightly
ms-
2020.3.42660

remote-ssh-nightly
ms-
2020.3.42660

azure-account
ms-
0.8.8

azurecli
ms-
0.5.0

Go
ms-
0.13.1

powershell
ms-
2020.3.0

vscode-node-azure-pack
ms-
0.0.10

vscode-typescript-next
ms-
3.9.20200329

vscode-typescript-tslint-plugin
ms-
1.2.3

vsliveshare
ms-
1.0.1847

vsonline
ms-
1.0.1889

team
ms-
1.161.0

azurerm-vscode-tools
msa
0.8.5

debugger-for-chrome
msj
4.12.6

color-highlight
nau
2.3.0

gremlins
nho
0.15.1

vscode-ts-markdown-to-playground
Ort
1.1.0

quicktype
qui
12.0.46

ruby
reb
0.27.0

vscode-yaml
red
0.7.2

vscode-sort-json
ric
1.18.0

vscode-hexdump
sle
1.7.2

code-spell-checker
str
1.8.0

code-spell-checker-german
str
0.1.4

vscodeintellicode
Vis
1.2.6

vscode-icons
vsc
10.0.0

gistfs
vsl
0.0.65

vscode-wakatime
Wak
4.0.0

vscode-todo-highlight
way
1.0.4

vscode-nginx
wil
0.7.2

vscode-ruby
win
0.27.0

material-theme
zhu
3.2.5

When auth failed on my linux box, than I saw the same

I think it might be due to 500 error responses? At least I saw logs related to that but wasn't able to establish a clear correlation.

Related to that, the issue seems to appear in multiple of my VS Code windows but not all of them.

Closing as a duplicate of https://github.com/microsoft/vscode/issues/94174 since there is more discussion there


include native node modules

I'm trying to use this plugin with the active-win module and having a problem. When I looked at the node_modules folder of the packaged app, I noticed that the iconv, ref-napi, and ffi-napi folders are empty.  If I include them in the packaged app, active-win will now work.
That's pretty much it, thanks.

@timfish, would love to hear some comments, thoughts or feedbacks. Thanks...


Including Windows.h in public header files causes numerous symbols collisions

Windows.h brings so many symbols into scope and that conflicts with other libraries consuming aws-c-common.
Please remove Windows.h from your public header files.

Closed by #178


Fixed bug to logging by day of week [Исправлена ошибка с логированием…

Fixed bug to logging by day of week.
Exemple config
<target name="testName" xsi:type="File" fileName="C:/log/${logger}.log"
			layout="${message}"
      archiveFileName="C:/log/${logger}_{##}.log" archiveNumbering="Date" archiveEvery="Monday" maxArchiveFiles="10" archiveDateFormat="yyyy-MM-dd-HH-mm"
			concurrentWrites="true" keepFileOpen="false" encoding="UTF-8"/>
<logger name="testLogger" writeTo="testName" levels="Trace,Debug,Info,Warn,Error,Fatal" final="true"/>

With this configuration, logs are archived every day, but I expect a new archive file every week.
I fix this bug.

fixes https://github.com/NLog/NLog/pull/2093

@RussianDragon
any idea how we could unit test this? So we won't break it in the future?

unit test could be later :)


fix: added a null check for datasourceConfiguration to refer url key

Description
Added a null check for datasourceConfiguration which was referring to url key and application was breaking if datasourceConfiguration becomes undefined.
Fixes #12513
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Manually tested
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=5c45f77


Darwin version doesn't map to a single macOS version

The Darwin kernel release number doesn't map 1:1 to a macOS release number in many cases.  For example, during Cheetah, kernel version 1.3.1 was used for macOS versions 10.0.1 through to 10.0.4; or more recently, 22.1.0 is used for both 13.0 and 13.0.1, and 22.3.0 is used for both 13.3 and 13.2.1.  But it's not just a micro version thing: during Big Sur, kernel 20.6.0 was used for 11.5 through to 11.7.4 (spanning 17 separate macOS releases).
It might be better to use the build number as the lookup key: there's only two releases in the history of macOS 10+ where the build number is not unique: according to Wikipedia, Mountain Lion build 12F45 was used for two macOS kernel versions: 12.5 on October 3, 2013 and 12.6 on January 27, 2015.  These do differ in their kernel build strings of xnu-2050.48.12~1 and xnu-2050.48.15~1 respectively.  I have not confirmed this personally.

@da4089 feel free to create PR


Up Nightly to 1.8

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

Good catch!


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter espresense for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.espresense
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E507] missing size attributes [xl] for checkbox at admin/jsonConfig.json/items/MQTTUseServer
[ ] :heavy_exclamation_mark: [E507] missing size attributes [xl] for number at admin/jsonConfig.json/items/MQTTServerPort
[ ] :heavy_exclamation_mark: [E507] missing size attributes [xl] for password at admin/jsonConfig.json/items/MQTTPassword
[ ] :heavy_exclamation_mark: [E507] missing size attributes [xl] for text at admin/jsonConfig.json/items/MQTTServerIp
[ ] :heavy_exclamation_mark: [E507] missing size attributes [xl] for text at admin/jsonConfig.json/items/MQTTUsername
[ ] :heavy_exclamation_mark: [E510] responsive check: maximum issues reached, please fix reported ones and recheck

WARNINGS:

[ ] :eyes: [W034] @iobroker/adapter-core 3.1.6 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json
[ ] :eyes: [W156] js-controller 4.0.24 listed as dependency but 5.0.19 is recommended. Please consider updating dependency at io-package.json.

:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
or
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
Note: This issue replaces issue #48
@mcm1957 for evidence
Last update at Fri, 29 Nov 2024 16:43:09 GMT based on commit 2fd8e8e4a3c953ed5506139c259e49b3eed82f75
ioBroker.repochecker 3.2.2

@iobroker-bot recheck

@ioBroker-Bot recheck


code cleanup: remove check on length

When len(taints) == 0, the for-loop will be skipped and return true directly.

/kind cleanup


first sorting column -- bug or feature?

I am trying sortable 0.8.0.  in the enclosed simple html file, the first column should start out sorted.  alas, it just appears in its default ordering.  even clicking on the sorting header only reverses it.  once I click on the second column, and then back on the first column, the sort on the first column begins to work, however.
is this a bug or a feature?
test-sortable.txt

I have the same issue. Upon page load, clicking on a column does not sort it, it just flips the order. Upon clicking on a second column, the sort works, and then works as intended on the first column when clicked.

How to make the default sorting? I need the feature to set the default column to be filtered.

I have the same issue.

Same issue here.


"Saved filters" invalid font

https://www.figma.com/file/ZkvysdRUmt9p2PDNU3a9WU/Kafka-UI?node-id=2536%3A10370&t=WBEoXbSrlD54Pnqw-4

Hi, @Haarolean  I would like to work on this issue. Can you please assign it to me?


Add 12h support, auto-cycle control to Rebble Clock

I was annoyed by the lack of 12h support and the inability to turn off the auto-cycling of the right bar, so I added those features.
I also ran into a bug with the settings app where the 's' variable was being overwritten by something else which caused issues. It must be a global variable or is used internally somewhere. Because it was only used for one setting and immediately saved, the desired settings were always saved there successfully (sometimes along with other stuff from the global variable), but with a second setting the pervious settings could be lost. Changing it to 'localSettings' fixed it.

could you also add the part relating to the location of the calendar?
(in order not to create 2 different pullrequests)
I tried the code and it should work (but double checking is always welcome xD)

let date = new Date();
let dy=require("date_utils").dow(date.getDay(),1).toUpperCase();
let dd=date.getDate();
let mm=require("date_utils").month(date.getMonth()+1,1).toUpperCase();
....
drawDateAndCalendar(w3, h/2, dy, dd, mm);

you should put this code in the drawSideBar.
in the future i was thinking about making the interface a little more modular:
give the possibility (via web Browser editor, or options directly from the clock) to choose what to display in the various areas ...
but I think that for the moment these changes are enough!

That would be great! But actually you don't need a separate pull request. It looks like this one was done off your master branch, so all you need to do is make the changes in your GitHub fork and they'll appear here automatically.


markdown-it v14 is not supported

Good afternoon team,
Usage of @diplodoc/transform causes errors. It's because the markdown-it v14 moved to ESM Modules bundle.
I think it makes sense to update markdown-it to version 14 in this package.

ESM is painfull.
We prepare manifest for next major version of transform. And publish in at 02.10.2024.
https://github.com/diplodoc-platform/transform/issues/519


Navigating to /posts/ throws uncaught errors

The publication postUsers is where the error comes from.

I'm not seeing this on the devel branch, so it probably got fixed in the refactor somehow :)


MediaQuery does not report correct orientation on Windows

Steps to reproduce
consider running this code on windows :
Expected results
The MediaQuery should correctly detect the screen orientation on both Android and Windows platforms
or the docs should mention that MediaQuery does not work normally.
Actual results
by playing with window u could notice that MediaQuery  does snot report the correct orrientation and instead does report based on the height and width of the window. if this is expected then section in the docs should mention this
Code sample
Code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: OrientationScreen(),
    );
  }
}

class OrientationScreen extends StatefulWidget {
  @override
  _OrientationScreenState createState() => _OrientationScreenState();
}

class _OrientationScreenState extends State<OrientationScreen> {
  @override
  Widget build(BuildContext context) {
    // Get the screen size and orientation using MediaQuery
    final Size screenSize = MediaQuery.of(context).size;
    final Orientation orientation = MediaQuery.of(context).orientation;

    return Scaffold(
      appBar: AppBar(title: Text('MediaQuery Example')),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Text(
              'Orientation: ${orientation == Orientation.portrait ? 'Portrait' : 'Landscape'}',
              style: TextStyle(fontSize: 24),
            ),
            SizedBox(height: 20),
            Text(
              'Screen size: ${screenSize.width.toStringAsFixed(2)} x ${screenSize.height.toStringAsFixed(2)}',
              style: TextStyle(fontSize: 24),
            ),
          ],
        ),
      ),
    );
  }
}

Screenshots or Video
No response
Logs
No response
Flutter Doctor output
Doctor output
[√] Flutter (Channel master, 3.26.0-1.0.pre.207, on Microsoft Windows [version 10.0.19045.4239], locale en-US)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 35.0.0-rc4)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.3.2)
[√] Android Studio (version 2024.1)
[√] VS Code (version 1.93.1)
[√] Connected device (3 available)
[√] Network resources

• No issues found!

This feature has not yet been implemented. See https://github.com/flutter/flutter/issues/74597
Closing in favor of the issue linked above.
Thank you

This feature has not yet been implemented. See https://github.com/flutter/flutter/issues/74597
Closing in favor of the issue linked above.
Thank you

Thanks for your reply but fom what i see the linked issue does propose adding a methode to get the current orientation, i'm reporting a bug in the MediaQuery

Hi @AbdeMohlbi, the actual issue is that the framework doesn't currently have a way to get the correct orientation, what we have with MediaQuery is just an approximation based on the height & width of the current screen (not the device) which is what you're also reporting. Since your issue will be fixed when the framework adds the correct orientation, this is a duplicate of the issue linked above


No output from wp-enforcer setup script

When running the install script on OS X 10.11.1 I get no output from the shell script. It also replaces the pre-commit hook file entirely without asking.

Here is a debug output of the script:
+ readonly VERSION=0.4.0
+ VERSION=0.4.0
+++ dirname ./vendor/bin/wp-enforcer
++ cd ./vendor/bin
++ pwd -P
+ readonly BIN=/Users/brandoncamenisch/Sites/Vagrants/vvv/www/ten/wordpress/wp-content/plugins/vehicle-data/vendor/bin
+ BIN=/Users/brandoncamenisch/Sites/Vagrants/vvv/www/ten/wordpress/wp-content/plugins/vehicle-data/vendor/bin
+++ readlink ./vendor/bin/wp-enforcer
++ dirname ../stevegrunwell/wp-enforcer/bin/wp-enforcer
+ readonly DIR=/Users/brandoncamenisch/Sites/Vagrants/vvv/www/ten/wordpress/wp-content/plugins/vehicle-data/vendor/bin/../stevegrunwell/wp-enforcer/bin
+ DIR=/Users/brandoncamenisch/Sites/Vagrants/vvv/www/ten/wordpress/wp-content/plugins/vehicle-data/vendor/bin/../stevegrunwell/wp-enforcer/bin
++ pwd
+ readonly PROJECT=/Users/brandoncamenisch/Sites/Vagrants/vvv/www/ten/wordpress/wp-content/plugins/vehicle-data
+ PROJECT=/Users/brandoncamenisch/Sites/Vagrants/vvv/www/ten/wordpress/wp-content/plugins/vehicle-data
+ vip=false
++ getopt -o h,v -l help,version,vip --
+ options=' -- h,v -l help,version,vip --'
+ '[' 0 -gt 0 ']'
+ echo 'Installing WP Enforcer...'
Installing WP Enforcer...
+ [[ ! -d /Users/brandoncamenisch/Sites/Vagrants/vvv/www/ten/wordpress/wp-content/plugins/vehicle-data/.git ]]
+ [[ ! -d /Users/brandoncamenisch/Sites/Vagrants/vvv/www/ten/wordpress/wp-content/plugins/vehicle-data/.git/hooks ]]
+ [[ -f /Users/brandoncamenisch/Sites/Vagrants/vvv/www/ten/wordpress/wp-content/plugins/vehicle-data/.git/hooks/pre-commit ]]
+ cmp /Users/brandoncamenisch/Sites/Vagrants/vvv/www/ten/wordpress/wp-content/plugins/vehicle-data/vendor/bin/../stevegrunwell/wp-enforcer/bin/hooks/pre-commit /Users/brandoncamenisch/Sites/Vagrants/vvv/www/ten/wordpress/wp-content/plugins/vehicle-data/.git/hooks/pre-commit
+ echo 'pre-commit hook already exists, skipping'
pre-commit hook already exists, skipping
+ [[ ! -f /Users/brandoncamenisch/Sites/Vagrants/vvv/www/ten/wordpress/wp-content/plugins/vehicle-data/phpcs.xml ]]
++ /Users/brandoncamenisch/Sites/Vagrants/vvv/www/ten/wordpress/wp-content/plugins/vehicle-data/vendor/bin/phpcs --config-show
++ grep installed_paths:
+ installed_paths='installed_paths: ../../wp-coding-standards/wpcs'
+ [[ installed_paths: ../../wp-coding-standards/wpcs != \i\n\s\t\a\l\l\e\d\_\p\a\t\h\s\:\ \.\.\/\.\.\/\w\p\-\c\o\d\i\n\g\-\s\t\a\n\d\a\r\d\s\/\w\p\c\s ]]
+ echo

+ echo 'WP Enforcer installed successfully!'
WP Enforcer installed successfully!
+ exit 0

The installation script only installs the Git hook and copies over the pre-commit hook, the actual execution is run on pre-commit (or optionally via ./vendor/bin/phpcs).
Overwriting the existing Git hook isn't good, however, so we'll take a look into that.

Overwriting the existing Git hook isn't good, however, so we'll take a look into that.

I don't see why this would be considered a bug. Current behavior shows that it will not overwrite existing pre-commit scripts and that's the behavior one would expect. There is clear output from the command showing when the file changes are skipped, and therefore I do not believe this should be a bug but perhaps instead a documentation or training issue.


Prevent in-context signup showing on local or invalid domain pages

Reviewer: @shakyShane @GioSensation
Asana: https://app.asana.com/0/0/1204038361216231/f
Description
Restrict in-context signup from running on local pages with valid TLD. This branch also updates the in-context signup tests to run on a real domain, mocked in puppeteer.
Steps to test

Build update into extension
Run local server and go to email-autofill.html integration test file
Confirm that in-context signup does not display
Go to https://duckduckgo.com/newsletter
Confirm that in-context signup does display

@GioSensation @shakyShane Integration test setup updated. Any other comments?


Add support for proto and protoset files in ghz backend

This change will break the LoadTestSpec compatibility with previous LoadTest resources to provide a more extensible way to work with test config and data files, allowing Ghz to receive .proto and .protoset files

Codecov Report

Merging #149 (bcb2119) into master (1ca4cf2) will decrease coverage by 0.16%.
The diff coverage is 77.50%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   59.84%   59.67%   -0.17%
==========================================
  Files          35       35
  Lines        2428     2470      +42
==========================================
+ Hits         1453     1474      +21
- Misses        873      891      +18
- Partials      102      105       +3

Impacted Files
Coverage Δ

pkg/backends/ghz/backend.go
41.93% <51.61%> (+0.50%)
:arrow_up:

pkg/proxy/request.go
76.71% <83.33%> (+0.76%)
:arrow_up:

pkg/backends/ghz/resources.go
91.91% <100.00%> (-8.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ca4cf2...bcb2119. Read the comment docs.


Error completing request when generating video

Discussed in https://github.com/thygate/stable-diffusion-webui-depthmap-script/discussions/354

Originally posted by vitalbuttering October 12, 2023
Anyone can diagnose why i am getting this error when i try to generate video on Depth?
Error completing request
Arguments: (None, '300', '40', 1, '-0.015, 0.0, -0.05', '0.03, 0.03, 0.05, 0.03', False, 'mp4', '3') {}
Traceback (most recent call last):
File "I:\stable-diffusion-webui\modules\call_queue.py", line 56, in f
res = list(func(*args, **kwargs))
File "I:\stable-diffusion-webui\modules\call_queue.py", line 37, in f
res = func(*args, **kwargs)
File "I:\stable-diffusion-webui\extensions\stable-diffusion-webui-depthmap-script\src\core.py", line 590, in run_makevideo
if len(fn_mesh) == 0 or not os.path.exists(fn_mesh):
TypeError: object of type 'NoneType' has no len()

It's so weird that that the last 3 issues are about NoneTypes but also seem unrelated.
TypeError: object of type 'NoneType' has no len()
Here
TypeError: must be real number, not NoneType
https://github.com/thygate/stable-diffusion-webui-depthmap-script/issues/352
cannot unpack non-iterable NoneType object
https://github.com/thygate/stable-diffusion-webui-depthmap-script/issues/353
Maybe an import dependency has recently changed.  fn_mesh path is so straightforward the only package that comes to mind is a bad gradio update, maybe try reverting to an older gradio? auto1111 will likely try update gradio during startup so this might be a little challenging.


Add lightning dependency

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (6dbe6d4) 100.00% compared to head (314ab50) 100.00%.

:exclamation: Current head 314ab50 differs from pull request most recent head da5b69b. Consider uploading reports for the commit da5b69b to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #231   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          313       313
  Lines         9678      9685    +7
  Branches       948       949    +1
=========================================
+ Hits          9678      9685    +7

Impacted Files
Coverage Δ

src/gravitorch/testing/__init__.py
100.00% <ø> (ø)

src/gravitorch/testing/_pytest.py
100.00% <100.00%> (ø)

src/gravitorch/utils/imports.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Discussion: Consider adding a debug mode to show all data in tiles

Maputnik uses a library to do this but the opinion of the team is that it isn't good enough:

We should consider

Is there a way to make the library Maputnik uses create a better view?
Is there another library we could use?
Should we do this ourselves?
Distinguishing between features that appear on the map and those filtered out by the style

To clarify, do we mean something specific by "all rendered feature data" as opposed to all feature data in the tiles?

Good point! Updated the name to be more open in that regard.

Here's it's also good to look at what https://stevage.github.io/vector-inspector vector inspector does well.

I'm doing some thinking about this now and would like to get a better sense of where the inspect mode in Maputnik fails so that we know how we might want this to work or whether something closer to https://github.com/stamen/map-compare/issues/43 might serve us better in this tool.
I'd also like to check in on the use case here: Do we think we'll use this mostly to compare a style to its own debug style to see how data is filtered or are we thinking we'd compare the debug styles of two separate styles to get a sense of how the data compares?

Distinguishing between features that appear on the map and those filtered out by the style

One thing to consider here is that, when looking at all source layers and all style layers here, it's likely that this view will be overwhelming. In Maputnik, we have the advantage of being able to show filtered vs unfiltered features/data based on a single selected layer. This is something we don't have in this compare tool. And it may result in this tool trying to do too much if we allow selecting a style or source layer.
Another potential issue with using the map style as the basis of our debug style is the number of sources. If we're concerned mostly with seeing two sources next to each other to see how they compare, maybe the right approach is to allow a dropdown option to insert a link to a tile json or pbf similar to the Vector inspector to create a style that isn't connected to a real map style that represents that data.
Lastly, regardless of path forward here, my inclination is to see how far we can get with a more scoped solution like https://github.com/stamen/map-compare/issues/43 before trying to implement this.
Curious to hear your thoughts @ebrelsford @almccon !

I'd also like to check in on the use case here: Do we think we'll use this mostly to compare a style to its own debug style to see how data is filtered or are we thinking we'd compare the debug styles of two separate styles to get a sense of how the data compares?

I'm also curious about this. I was mostly thinking the former (compare the rendered style to the source data to see what else is available in that source) but I could see the latter being interesting too.
If we think about this tool as part of a replacement for Maptunik (editing happens in a code editor, viewing happens in this tool), then I can see the argument for bringing more of the viewing and analysis features from Maptunik into this tool. I can see how making a separate tool for viewing source data could be cumbersome if your development workflow is:

edit in code editor
build with build system
view in this tool

One thing to consider here is that, when looking at all source layers and all style layers here, it's likely that this view will be overwhelming.

Agreed. And if we were to build a UI for doing layer selection, would that be useful in the tool generally or would it only be useful here? And at that point is this better off in its own tool?

If we're concerned mostly with seeing two sources next to each other to see how they compare, maybe the right approach is to allow a dropdown option to insert a link to a tile json or pbf similar to the Vector inspector to create a style that isn't connected to a real map style that represents that data.

I think this might be useful either way in terms of tile dev. Being able to compare the current tile source with a tile or two of dev tiles would be handy...

Lastly, regardless of path forward here, my inclination is to see how far we can get with a more scoped solution like #43 before trying to implement this.

The sounds good to me, let's start with #43.

I can see how making a separate tool for viewing source data could be cumbersome if your development workflow is:

edit in code editor
build with build system
view in this tool

Just to throw another idea out here if this is a blocker to creating a separate tool: In client projects, we could make this less cumbersome if we wanted (with a little more work) by threading tools together. If we had a separate tool for this functionality, structured similarly, we might be able to add a custom link between tools right in the HTML file to switch between them without restarting a server. There are likely some issues to work out here and we'd have to force the link to open a new tab so that we don't change the URL that persists state though.

I'm doing some thinking about this now and would like to get a better sense of where the inspect mode in Maputnik fails so that we know how we might want this to work or whether something closer to https://github.com/stamen/maperture/issues/43 might serve us better in this tool.

What fails for me with the data view mode in Maputnik is that you only see the data for features in whichever layer you have selected. Being able to see everything would be so much more useful in most cases

Distinguishing between features that appear on the map and those filtered out by the style

Mapbox Studio does a really nice job at this that we could emulate

Just to weigh in with nothing new, the number one use case to me is just seeing the data in the tiles. It's really helpful to see the data and all properties that we can use when creating styles. The actual "what's rendering" or "what's being filtered out" feature seems like it could be cool too!
Another potential use would be a focused tile view where I can look at the data in just a couple tiles and see all the features listed or grouped by tags/sources in a slightly different UI than something listing all of the layers. This aids in helping troubleshoot specific areas if something is appearing buggy in a certain area. So a focused tile view and a focused data view for those specific tiles would be helpful.

What fails for me with the data view mode in Maputnik is that you only see the data for features in whichever layer you have selected. Being able to see everything would be so much more useful in most cases

@kelsey-taylor I thought this was the case as well, but it doesn't appear to be that way for all styles? I'm kinda just finding this out now. I've only really used Maputnik for our stylesheets that we create for clients and it's true that you can only see the data in the layers you have selected. But if I look at the OSM Liberty map style (one of the default selections in Maputnik), I can see everything!

for context, here's the same area above just loading one of our own style jsons. Kelsey is right in that it's blank unless I select a layer, then it only shows that specific layer.

So maybe Maputnik can be a good candidate and we need to figure out why our style jsons don't show every layer when loaded into the editor, and if there's anything we could do on our json generation or could do in our Maputnik fork to better suit tile inspection with this method.
Maybe one or all of you already know why that is 🤷

@kelsey-taylor I thought this was the case as well, but it doesn't appear to be that way for all styles?

I was thinking the same thing! I don't remember it being so limiting when I worked on a set of styles with their own tiles last year, but we had a separate fork with some changes that I assumed explained the difference. Not sure what's going on there 👀

I dug into this a little by making the simplest version of one of our styles and it still didn't work. I imagine there's some debugging we could do around this part of Maputnik if we decided that was a possible avenue. Most of the work there is done by mapbox-gl-inspect.

Unlurking to shed some light on this. The difference is whether there is a tile.json file for the source, or if it points to tiles directly. A tile.json contains the usual source info plus a basic schema for the tiles, telling the inspect function things like what layers are present, data types, and what kind of geometry is included.
Here's the OMT file, which is especially detailed. I created tile.json files at Amazon that were simpler and didn't include all possible values, and those worked fine too.

Oh duh, that makes sense. Thanks @kateler!

Related: https://github.com/stamen/carto-tools/issues/16

Grooming discussion

Big missing piece from our workflow is having a debug mode
Maperture seems like a good place to implement this since it is already heavily used
Other tools already do this, like Maputnik (screenshots above) and Vector Inspector, but it doesn't quite work for our current styles
Question: do we spend the time to incorporate this into Maperture or do we find another tool that we're happy with using

Maperture or not

Feels like a natural extension of Maperture
Pairs nicely with https://github.com/stamen/maperture/issues/157
Using another tool would be cumbersome because you'd need to c/p URLs around to make sure your view is the same
Maperture would have compare panes which is highly convenient for viewing
Development time is a question mark, which makes us hesitant to pick this up
Tile.json vs a tile endpoint are very different tasks - doing this for a tile endpoint would be a much larger lift
Would be most useful to see both the rendered data and raw tile data to know what's available to be used
Note on building this: it is about creating a style on the fly; let's build in a modular fashion
Feels like we should have a list of layers for client tile endpoints anyway; is creating a tile.json something that we'd want to build into this tooling?
How many clients do we have that are using a tile.json instead of tile endpoints?

AWS does not use tile.json
Lyft does not use tile.json
Last Mile had a tile.json, but only because Kate created it for them

Advocating for us to push clients to expose this information to us

User story
As a user of Maperture, I want to be able to understand how tile data correlates to the style that I'm working on. The ability to do this in Maperture would be much less cumbersome than current solutions (which force us to jump between applications) and would speed up our style development work. This is the kind of tooling that is helpful when styling a feature for the first time in order to understand the frequency/density of that feature. This would also help find feature/tagging anomalies in tiles.
Acceptance criteria
Without leaving this tool, I can look at the data in a tile, see what features and layers are being used and not.
Note: we're still workshopping the user story and acceptance criteria. We'll pick this back up next week!


Add subscription buttons to nova custom mtl releases

@philipandag does this PR need a rebase? I see a lot of commits unrelated to the PR title, so I think a rebase might be needed

@mkopec Which branch are you comparing to? Comparing to master i see 25 commits.

Ah because https://github.com/Dasharo/docs/pull/870 was merged to this branch. All good then no problem


fix loop break

@maxtaco @songgao @patrickxb @oconnor663 r?
I need this to fix CI.

I made the comment to @mmaxim: seems like we need some more tests of the JSON API?

When written there were no end-to-end tests because it was impossible.  But @mmaxim's kbps-server test uses it so we can expand on that?


Fixes and shorthands for dataforms

I fixed the README so the examples work again and added shorthands for the constructor calls to the Objects used in dataforms.

Thank you very much for your effort!


not all the tweets are showing up

i need to show some 300 tweets with this widget , but only some of the tweets show up, some 5 or 6, im using the twitter rest api to get the tweet ids, is there a reason for this ? please help

need to use tweet.id_str , instead of tweet.id.


migrated Image and ProgressBar widgets

WIP, I need to add renderers to this PR, but I had a problem with running the example. It fails with #1

I fixed #1 in #3. Let me know if you have any further issues.

I fixed the issues and merged the PR manually.
Thank you again! :tada:


Update nebula-storaged-listener.conf.production

make it consistent with doc and storage.conf

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Is this PR ready?

Is this PR ready?

yes. just change the ports according to 2.0


BugFix/IIA-1150: Selecting the "Patterns" pane on the left makes the scrollbars in the desktop area disappear

Fixes https://ikmdev.atlassian.net/browse/IIA-1150
Actual Behavior
Selecting the "Patterns" pane on the left makes the scrollbars in the desktop area disappear.
Expected Behavior
Selecting the “Patterns” pane should have no effect on the desktop area
Steps to Reproduce
1 - double click a Journal to open a Journal Window
2 - click to open the Navigator tray pane
3 - select the “Patterns” toggle
The scrollbars on the desktop area will disappear (pictures attached show the before and after)

Looks good. Interesting to notice StackPane removal of minHeight attribute.
I will merge.

The Pane doesn't honor the min height but VerticallyFilledPane does that's why we need this fix.

I think something is still not working correct. The desktop area needs scroll bars to appear. The desktop (aka scalable desktop) should allow the user to pan around using the Control key + mouse moving (panning).

Hey @carldea I don't understand... It's working for me on my end (with this PR).
You mean you tried running Komet with this PR and it's still not working on your side?

Can you look why we cannot scroll to the last record of the pattern?

That’s one of the other things this PR solves

Looks good. Interesting to notice StackPane removal of minHeight attribute.
I will merge.

Yes, the Pane doesn't honor the min height but VerticallyFilledPane does that's why we need this change. 😊

I think something is still not working correct. The desktop area needs scroll bars to appear. The desktop (aka scalable desktop) should allow the user to pan around using the Control key + mouse moving (panning).

Hey @carldea I don't understand... You mean you tried running Komet with this PR and it's still not working on your side?
It's working on my end (at least I think it is). This is how it's working with the fix in this PR on my end:
Edit: I think I see where the confusion might be, the pictures that I attached to the description of the PR are describing the bug and are showing the bug happening. Those pictures are all from before the fix in this PR. I should have been clearer probably
2024-12-11.18-14-48.mp4

Oh sorry for the confusion! yes I must have looked at the wrong image. Super glad this works! Like what @swaroopsalvi  said, I am glad this ticket also fixes the listing of Patterns in the navigator.
Will merge. Thank you.

Looks good. Interesting to notice StackPane removal of minHeight attribute.
I will merge.

Yes, the Pane doesn't honor the min height but VerticallyFilledPane does that's why we need this change. 😊

I think something is still not working correct. The desktop area needs scroll bars to appear. The desktop (aka scalable desktop) should allow the user to pan around using the Control key + mouse moving (panning).

Hey @carldea I don't understand... You mean you tried running Komet with this PR and it's still not working on your side?
It's working on my end (at least I think it is). This is how it's working with the fix in this PR on my end:
Edit: I think I see where the confusion might be, the pictures that I attached to the description of the PR are describing the bug and are showing the bug happening. Those pictures are all from before the fix in this PR. I should have been clearer probably
2024-12-11.18-14-48.mp4

Oh sorry for the confusion! yes I must have looked at the wrong image. Super glad this works! Like what @swaroopsalvi said, I am glad this ticket also fixes the listing of Patterns in the navigator. Will merge. Thank you.

My bad actually, I should have written a better explanation in the issue description. I can see how that would have led to your confusion.
Thanks @carldea !