Cron dispatch workflows should send failure emails

There are two default github workflows that run on a nightly basis: smoke test and nightly benchmarks.
If they fail, they'll only alert the person who set up the workflow (and possibly anyone following all repo activity?). I think it's possible to have a workflow step that will send an email in the event of failure.
We're already capturing an email (either single person or group alias) as part of template hydration.

This seems related to #293 in that the alert about a workflow going into hibernation mode is only sent to the person who created the action.

Alternatively (or in addition to) the email approach, we could stub in the thing that will emit a failure message to slack.

How would you like to receive workflow failure notifications?
> email
  slack bot integration (additional configuration required)
  none


The doubled parenthesis causing error on line 14 has been removed

The parenthesis causing error on line 14 has been removed.

Great catch! Thanks 👍


Deserialize context event

Codecov Report

Merging #46 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
+ Coverage     98.03%   98.10%   +0.07%
- Complexity      114      120       +6
============================================
  Files            21       22       +1
  Lines           356      370      +14
============================================
+ Hits            349      363      +14
  Misses            7        7

Impacted Files
Coverage Δ
Complexity Δ

...entValueResolver/RequestArrayOfStructsResolver.php
100.00% <100.00%> (ø)
14.00 <0.00> (ø)

...umentValueResolver/RequestSingleStructResolver.php
100.00% <100.00%> (ø)
13.00 <0.00> (ø)

src/Event/DeserializeEvent.php
100.00% <100.00%> (ø)
5.00 <5.00> (?)

src/Event/SerializeEvent.php
100.00% <100.00%> (ø)
5.00 <2.00> (ø)

src/Facade/SerializerFacade.php
100.00% <100.00%> (ø)
3.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a88798...1fc32c9. Read the comment docs.

resolves #33


don't require callback for synchronous identify functions

Perhaps this is just a personal preference, but I believe that callbacks should only be required for functions that may perform asynchronous operations. For all synchronous functions, requiring a callback to be passed in may mislead devs into thinking that it's asynchronous and requires unnecessary consideration for control flow. Therefore, I made the callbacks optional for bot.identifyBot() and bot.identifyTeam().

It's a good approach when using yield on ES6, but if you're not using it, it gives a asynchronous feeling to a asynchronous function.

I will allow it! Thanks.


chore: clearer error message when project already initialized

What kind of change does this PR introduce?
With current error it may seems like the supabase cli needs to be reinstalled intead of the directory removed
What is the current behavior?
Current:
Error: Project already initialized. Remove supabase to reinitialize.
What is the new behavior?
New:
Error: Project already initialized. To allow reinitialization remove the directory ./supabase

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 25.767%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1276

Relevant Lines:
4952

💛  - Coveralls


setup.py now imports setuptools

Why is setup.py now suddenly using importing setuptools?  Setuptools is the source of many build problems and endless frustration.  I would really like to see it gone.  Thanks

setuptools makes development easier. i have had no problems building conda packages on all of linux, windows and osx.


Fix toml missing parser (issue #4)

Thanks to https://github.com/containous/flaeg/pull/19

fixes #4


Fix mapPropsOnChange

Change mapPropsOnChange so that propsMapper only receives the dependent props. Resulting object is combined with non-dependent props.
Closes #60

Current coverage is 99.50%

Merging #62 into master will not affect coverage as of 4d02d49

@@            master    #62   diff @@
=====================================
  Files           39     39
  Stmts          204    204
  Branches         0      0
  Methods          0      0
=====================================
  Hit            203    203
  Partial          0      0
  Missed           1      1

Review entire Coverage Diff as of 4d02d49

Powered by Codecov. Updated on successful CI builds.


doc / updated austostart script

Before submitting this PR, please make sure:

[x] Your code builds clean without any errors or warnings
[x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Updated autostart script

Tests performed by the developer:
Tips for QA testing:
┆Issue is synchronized with this Clickup task by Unito

Totally agree. Autostart with the password prompt is not an autostart anymore. However, the bug is still there (if I don't miss something).


FR: Don't jump to top on copy

Hey Erik how's it going?
Please consider adding a plugin setting to turn off the auto jump-to-top when a tag is copied.

Hey Chad! We'll take a look at this sometime this week. Thanks for the FR!

i wanna want to work on this


Publish to Modrinth instead of CurseForge

CurseForge has been very slow for a long time and recently it also started making me do captchas every few minutes. Modrinth is way faster & friendlier, I'd recommend also publishing there, at least in addition to CF.

Noted


Newznab module

Searches are currently performed on the movies category only.
How can enter be disable in the form? At the moment /?query=<term> gets loaded.

I just coded something similar to this! Wish I had seen this before as it took me a while to understand the request object from flask. Will review this later on, if mrk doesn't beat me to it.

Can pull request #20 be closed?

Yes, I closed it.

nice work

nice work

Thanks to spotweb, spotweb/details/xx page is now working in FireFox!
To enable it, add to following line to .htaccess of spotweb apache configuration file:
RewriteRule ^details/?(.*)$ /spotweb/?page=getspot&messageid=$1 [L,QSA]
Internet Explorer should use (as the cookie aren't working properly):
RewriteRule ^details/?(.*)$ /spotweb/?page=getspot&messageid=$1 [L,R]

Thanks to spotweb, spotweb/details/xx page is now working in FireFox!
To enable it, add to following line to .htaccess of spotweb apache configuration file:
RewriteRule ^details/?(.*)$ /spotweb/?page=getspot&messageid=$1 [L,QSA]
Internet Explorer should use (as the cookie aren't working properly):
RewriteRule ^details/?(.*)$ /spotweb/?page=getspot&messageid=$1 [L,R]

I like it! I don't use Newznab personally, but I tested it out using a public server and it seemed to work fine.
The interface needs some work though. Some things that I noticed:

Pressing enter in the search box reloads the page (something that should never be done in Maraschino as it's all AJAX)
The icons don't fit in with Maraschino's style, we're going for a simple, single colour (white) style
The styling needs work - the results are in a massive font size and the poster (is this useful information? what other information could be displayed?) is underneath and right-aligned

This definitely has potential. Would you be willing to make these changes?

I like it! I don't use Newznab personally, but I tested it out using a public server and it seemed to work fine.
The interface needs some work though. Some things that I noticed:

Pressing enter in the search box reloads the page (something that should never be done in Maraschino as it's all AJAX)
The icons don't fit in with Maraschino's style, we're going for a simple, single colour (white) style
The styling needs work - the results are in a massive font size and the poster (is this useful information? what other information could be displayed?) is underneath and right-aligned

This definitely has potential. Would you be willing to make these changes?

I like this too but I was hoping to develop a search plugin sometime soon. It will most likely have nzb.su search functionality as well along with others. Will probably be something like the MFP one I once made, until then this is pretty cool.

I was also thinking when looking at this that an all-emcompassing search module would be the way forward, long-term, as there doesn't seem to be a definitive search tool that people use (I use binsearch.info, for example).
As gugahoi said, perhaps this module (after appropriate UI changes listed above) could fill the void until then, or evolve into something larger.

I agree to you both, so one can extend this module or use this code into a new one that allows a user to select his search application.
Most icons are replaced by white one. Maybe some one can help me with fixing the enter issue.

Jeroenve, if you can take care of the rest then I can fix the enter issue when it comes to reviewing it.

Yes the enter issue is an easy one. There is code that does that already on index.js since I needed to do it with the Sickbeard Search as well (see here)
I thought we already had a ticket on lighthouse for a search module but can't find it anywhere. We can open this up for discussion and find ways to better implement it. Last time I spoke to @antant he mentioned he had started coding such a thing already but I have no idea what happened to it.

Made most of the changes:

Looks very nice, good job! Will check it out properly as soon as I get a chance.

love this module.. It would be awsome if clicking the links could import nzb directly to sabnzbd ;)

If there is an ability to check if the sabnzbd module is enabled then it should be possible to send a nzb to sabnzbd.

No need to check that. It definitely is possible to send to sab, even to choose the category, priority and everything.
If you happen to know any php, have a look at this. I coded that for MFP and it had a button where one clicked and the item was sent to SAB. You can also use this if you'd like to expand your module further as it has code to search both nzb.su, nzbmatrix and themoviedb (I know it's a messy coding, sorry)

No need to check if it's enabled. Just stick it in a try... except
On Jan 5, 2012 10:14 AM, "Jeroen van Emden" <
<EMAIL_ADDRESS>wrote:

If there is an ability to check if the sabnzbd module is enabled then it
should be possible to send a nzb to sabnzbd.

Reply to this email directly or view it on GitHub:
https://github.com/mrkipling/maraschino/pull/26#issuecomment-3367850

nzb.su is already possible as it uses newznab.

Who has a NZB matrix apikey for me that I can use for the development?

any progress on this module?
would be nice if this one could be used in maraschino :-)

There's another pull request for a search feature, which still needs some work, but is (in my opinion) the right way to go vs. a Newznab-only module:
https://github.com/mrkipling/maraschino/pull/63

k,thx for the info


api: dma: add api to retrieve pending data size

Some applications using DMA, such as UART RX, could
need to complete the current DMA transaction earlier than
predefined, based on other termination conditions,
like UART's IDLE interrupts.
In that case, the client needs to know how many data are
still left in DMA transfer buffer so that it can figure
out how many data has been transfered. However, the current
DMA API doesn't provide any information for the client
to learn the transfer buffer information.
So, added a dma API function to retrieve remaining
transfer data length to meet this kind of requirements.
And implemented the API for STM32F4's DMA while keeping
others unimplemented.
Signed-off-by: Jun Li<EMAIL_ADDRESS>

@avisconti  @cybertale can you help to review? Thanks!

How about a more generic API such as dma_api_status that can provide the pending data length as well as any other relevant status (busy/idle, total length, pending length, etc.)?

Sounds a good idea to use a status structure to make it general and easy to extend. However, with that I think I need to touch every DMA driver to implement the reasonable status, at least idle and busy.

No, I guess you should not populate the other drivers with dma_status, but leave it NULL.
In any case do you have the hardware for all the other DMAs to test them in case?

How about a more generic API such as dma_api_status that can provide the pending data length as well as any other relevant status (busy/idle, total length, pending length, etc.)?

Sounds a good idea to use a status structure to make it general and easy to extend. However, with that I think I need to touch every DMA driver to implement the reasonable status, at least idle and busy.

No, I guess you should not populate the other drivers with dma_status, but leave it NULL.
In any case do you have the hardware for all the other DMAs to test them in case?

No, I don't have all of them. So, I'll do this in the same way as what I did just now.

By the way, a client should know the total length, right?

Yes. The client can lookup the total length by using the channel number as an input. The suggestion was just so the information is readily available as part of this API.

By the way, a client should know the total length, right?

Yes. The client can lookup the total length by using the channel number as an input. The suggestion was just so the information is readily available as part of this API.

Hmm, the current DMA implementation doesn't store total length some where. The total length is written to the DMA register and then it keeps changing when DMA starts. Unless adding another variable in a specific stream internal data structure, the total length is not available.
I'd like to add direction as well.
Anyway, I'm going to use a structure dma_status which should be easy to be extended in the future as necessary.

Hmm, the current DMA implementation doesn't store total length some where. The total length is written to the DMA register and then it keeps changing when DMA starts. Unless adding another variable in a specific stream internal data structure, the total length is not available.

It was just a suggestion. No need to add unless someone really needs it.

I'd like to add direction as well.

OK.

Anyway, I'm going to use a structure dma_status which should be easy to be extended in the future if necessary.

OK good.

recheck

recheck

recheck

@Sizurka thanks for the reminder! I would remove ‘dma_get_status’ from the syscall list until it is really needed by the user space.

recheck

As a test, an implementation of this API for SAM0.  So it seems reasonable enough from the SAM0 DMA perspective: a bit harder because SAM0 stores inactive channels in main SRAM rather than dedicated registers for all channels, but not that much more complicated.
Nit: For consistency with the rest of the doc comments, you may want to note the units of pending_length (either specify bytes or note that it's implementation dependent), since some controllers (e.g. SAM0) work natively in blocks which may or may not be byte sized.    The other DMA APIs tend to note that their length fields are specified in bytes to avoid ambiguity.   Basically, just add "in bytes" to the comment to make it clear what the implementation should return.

As a test, an implementation of this API for SAM0. So it seems reasonable enough from the SAM0 DMA perspective: a bit harder because SAM0 stores inactive channels in main SRAM rather than dedicated registers for all channels, but not that much more complicated.
Nit: For consistency with the rest of the doc comments, you may want to note the units of pending_length (either specify bytes or note that it's implementation dependent), since some controllers (e.g. SAM0) work natively in blocks which may or may not be byte sized. The other DMA APIs tend to note that their length fields are specified in bytes to avoid ambiguity. Basically, just add "in bytes" to the comment to make it clear what the implementation should return.

Revised comments on the structure members. Thank you!


extend user agent metadata

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue, please leave a comment

Describe the Feature

#141 implemented most of the SEP but we left a few things todo including:
feat-metadata        = "ft/" name ["/" version] *(RWS additional-metadata)
config-metadata      = "cfg/" config "/" name
framework-metadata   = "lib/" name ["/" version] *(RWS additional-metadata)
appId                = "app/" name
We need to provide a way that customers can extend this metadata (e.g. so someone like amplify can set lib/amplify/VERSION) and we need to finish the implementation by detecting features and configuration settings (SEP calls out examples of these).

https://github.com/awslabs/aws-sdk-swift/pull/494

SEP - /seps/accepted/shared/sdk-user-agent-header.md

Released in AWS SDK for Swift 0.24.0


Optifine issues

Minecraft 1.12.2
When using Optifine with Dynamic Trees an issue with leaves occurs.
Savana leaves on mod changed trees seem to have the same/similar color of the forest ones (greener).
The change doesn't really make the game any worse, actually to someone it might seem that there's more natural details, but it would be nice if all leaves could have the same biomes color.
Example of leaves on modded trees and natural generated RecurrentComplex trees:

I use optifine and I don't have this problem.

Please reduce your mods to just Optifine and Dynamic Trees and create a test world.  If it does not occur with just those mods then do binary troubleshooting(add half of disabled mods at each testing cycle) with your mods.  If I can't reproduce this there is little chance it will ever be fixed.

The real issue is a combination of Optifine, DynamicTrees and Quark.
Using both Optifine and DynamicTrees together is completely fine, but adding quark in the mix causes this effect.
When using Quark and Optifine alone the colors are fine as well, all though adding DynamicTrees brakes it.
Also, removing Optifine made the leaves and grass look all the same, but not to its original color, but the greenish one.
A world pregenerated with Quark and Optifine alone and adding Dynamic trees after:
- greener bottom grass block
- greener leaves

The same world but with Optifine removed  afterwards:
- everything with the same greener shade

So it's Closed.


Android: "accessible" prop issues.

Description
On Android there are a number of odd irregularities with how accessible prop works.

Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible  with accessible  descendants), and sometimes it does not (e.g. accessible  with accessible  descendants).
A  with accessible={true} and accessibilityLabel="foo"` is not focusable.
Interaction between accessible prop and collapsable prop also causes strange behavior, while fixing the issues in some cases it causes incomplete labels in others.

With this many inconsistencies with focus behavior, it's unclear what is working as intended by design, and what is working by accident, and what isn't working by design, and what isn't working by accident.
React Native version:
v0.63
Snack
https://snack.expo.io/jv1U2thqq
Expected Behavior
On Android accessible={true} should simply map to view.setFocusable(true), and accessible={false} should map to setImportantForAccessibility("NO").  This will block elements with accessible="false" from ever being considered by the accessibility system, and force elements with accessibility="true" to be focusable by the system, even if they don't normally meet the requirements.
Android Details
I think these issues all stem from the fact that "accessible" is handled in the ReactViewManager class, so it's set correctly on 's, but is not set in the BaseViewManager class, so doesn't do anything at all for other components like , , etc.  This is counter to the fact that these components do allow you to set accessible="true" on them, so we should expect them to work correctly.

This one likely needs investigation from the React Native team, as the "collapsible" prop has some complex behavior trying to automatically reduce the view hierarchy, which can cause accessibility problems if a view that has accessibility properties on it is collapsed, as well as the issues with accessible lying fairly deep in the view manager classes.
Let me know if you need any help on determining what the proper behavior should be when this is used.

Hey @blavalla! Thanks for reporting this.
I think several of the issues you noticed are actually from the Views being completely removed because they have no "height" property. This is an optimization in React Native to avoid unnecessary renders. It's definitely worth clarifying this behavior in the documentation. I think this is also related to the issue where "invisible" accessibility Views are not able to be created - accessible things need to be backed by a real component with current implementation.
I've created a slightly updated snack to give the 3 previously unfocusable Views a small height. Those are now focusable. https://snack.expo.io/ksgL9sTHH
Nested Accessible Text Nodes
I did notice the same issues as you with Text, where these are focusable as a single element:
     <View accessible={true}>
        <Text style={styles.paragraph} accessible={true}>
          Text One
        </Text>
        <Text style={styles.paragraph} accessible={true}>
          Text Two
        </Text>
     </View>

I think what is happening here is that it is detecting the outer View as focusable. It then reads downward in the tree to put an "automatic" accessibility label which is all the Text within the View. The inner Text nodes are then completely ignored (even though they are marked focusable).
What is the expected behavior here? Should it focus 3 times, first on the outer View and then once on each of the inner Text nodes? Or should it ignore the outer View and focus on the inner Text nodes individually?
Nested Accessible Views
Second question - this is about the nested accessible Views:
    <View accessible={true}>
        <View
          style={styles.focusableViewRed}
          accessible={true}
          accessibilityLabel="Text One"
        />
        <View
          style={styles.focusableViewBlue}
          accessible={true}
          accessibilityLabel="Text Two"
        />
   </View>

Now that these are focusable (because I added height, I also added a background color to make it easier to see them when testing), the current behavior is to ignore the outer accessible View and instead focus twice - once on the View with label "Text One" and once on the View with label "Text Two". Is this expected? Or should it focus three times, or should it focus once and group both accessibility labels together (ex. by reading "Text One, Text Two")?

@kacieb , both questions here are highlighting a core difference between iOS and Android.
On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
Google on the other hand, has made things quite a bit more complicated.
On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example.  If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
However, as with many things on Android related to accessibility, there are a few catches.
Catch one, If instead the layout was like this:
     <View accessible={true}>
        <Text style={styles.paragraph} accessible={true}>
          Text One
        </Text>
        <Text style={styles.paragraph}>
          Text Two
        </Text>
     </View>

The default Android behavior would actually be that the outer view and first text element would be focusable.  Upon Talkback's focus evaluation of the outer view, it will automatically pull the "Text Two" text from the unfocusable child and use that text as the label. This will cause the confusing issue of the order of content being announced counterintuitively as "Text Two" (on focus of the parent) -> "Text One" (on focus of the first child).  Looking at this layout, I think that very few people would expect this to be the behavior.
Catch number two, if the layout was instead like this:
     <View accessible={true} accessibilityLabel="custom label">
        <Text style={styles.paragraph}>
          Text One
        </Text>
        <Text style={styles.paragraph}>
          Text Two
        </Text>
     </View>

Then Talkback looks at this layout, and only sees the parent view as focusable.  Knowing how it works from the previous example, you may expect it to announce "custom label, Text One, Text Two", since it has two unfocusable children now.  But in this case, since an explicit label was provided, the unfocusable children are simply ignored. That text is never presented to the user.  The assumption here is that by providing an explicit label, you are meant to describe that whole node, its children included, so the text of those children shouldn't be included. This is maybe expected if you come from an iOS background, but is also sort of a strange behavior.
Finally, the last catch relates to why these views are considered focusable.  We've been working with the assumption that they are only focusable because accessible="true", but this is not the only property that can make a view focusable on Android. Android also makes all elements with onClick listeners or onLongPress listeners focusable, as well as a bunch of other less-clear edge cases. If our layout looked like this:
     <View accessible={true} accessibilityLabel="a couple of text views">
        <Text style={styles.paragraph} onClick={some callback...}>
          Text One
        </Text>
        <Text style={styles.paragraph} onClick={some callback...}>
          Text Two
        </Text>
     </View>

Then all three elements would be focusable. The parent element due to accessible="true" and having an accessibilityLabel, and the child elements due to being clickable. The label on the parent does not force the children to become unfocusable if they are explicitly defined as being focusable via either the accessible prop or some other prop that causes implicit focusability like onClick.
On iOS, this pattern would not be possible, as even children with click handlers that are descendants of an accessible element are not themselves focusable. The click handlers would instead have to be moved to the parent, or accessible="true" should not be set on it at all, and rather set on the individual child elements instead.
I am probably a bit biased, but I think Androids behavior here is probably what users expect, and it's pretty strange that on iOS you can set a click listener on something that can't ever be clicked by some users simply due to one of its ancestors having the accessible prop (which you may not even realize is happening).

This was a very roundabout way of saying that there is no real "one size fits all" approach to focusability between iOS and Android, and often even within Android itself. I think we need to decide what React Native developers expect to happen when using these properties, make sure that happens (if possible), and then document it well so that when things work differently from the default system it's explained why that is the case.

@kacieb Another case that should be documented is when Text descendants of other Text elements are set to be accessible, but the screen reader will ignore them, see https://github.com/facebook/react-native/issues/32004
This pitfal is hitting consumers of react-native-render-html library pretty badly!

[ ] trigger setImportantForAccessibility("NO") if accessible prop is false}

accessible parent view and one not accessible child

The screenreader focuses on the parent view and announces Text Two as a label
The screenreader then focuses on the child Text One

 <View accessible={true}>
    <Text style={styles.paragraph} accessible={true}>
      Text One
    </Text>
    <Text style={styles.paragraph}>
      Text Two
    </Text>
 </View>

accessible parent view with accessibilityLabel over-rides child Text

screenreader focuses on parent view and announces ==> "custom label"

 <View accessible={true} accessibilityLabel="custom label">
    <Text style={styles.paragraph}>
      Text One
    </Text>
    <Text style={styles.paragraph}>
      Text Two
    </Text>
 </View>

parent view with accessibilityLabel does not over-ride childrens

the screenreader focuses on the parent view and announces ==> "a couple of text views"
the screenreader focuses on the first child Text and announces ==> "Text One"
the screenreader focuses on the second child Text and announces ==> "Text Two"

<View accessible={true} accessibilityLabel="a couple of text views">
  <Text style={styles.paragraph} onClick={some callback...}>
    Text One
  </Text>
  <Text style={styles.paragraph} onClick={some callback...}>
    Text Two
  </Text>
</View>

Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).

https://github.com/facebook/react-native/issues/30851#issuecomment-1194938293 https://github.com/facebook/react-native/issues/30851#issuecomment-1194944880 https://github.com/facebook/react-native/issues/30851#issuecomment-1194957300
Possible solution (already tested in https://github.com/facebook/react-native/issues/30851#issuecomment-1194938293)

I think these issues all stem from the fact that "accessible" is handled in the ReactViewManager class, so it's set correctly on 's, but is not set in the BaseViewManager class, so doesn't do anything at all for other components like Text, etc. This is counter to the fact that these components allow you to set accessible="true" on them, so we should expect them to work correctly.

Interaction between accessible prop and collapsable prop also causes strange behavior, while fixing the issues in some cases it causes incomplete labels in others.

<View style={{height: 0}} collapsable={false} accessible={true}>
   <Text>text to be announced</Text>
</View>

Tried the following solutions:

collapsable={false}
hitslop

[ ] debug logic included in comment

accessible prop not working on some components
https://github.com/facebook/react-native/issues/30851#issuecomment-790136790

I think what is happening here is that React Native is detecting the outer View as focusable. It then reads downward in the tree to put an "automatic" accessibility label which is all the Text within the View. The inner Text nodes are then completely ignored (even though they are marked focusable).

The original issue with the Text component accessible prop was fixed with the changes from PR https://github.com/facebook/react-native/pull/33076.

[ ] verify if the accessible prop does not work on some components
[ ] add accessible prop to BaseViewManager

parent view with accessibilityLabel does not over-ride children with onPress handler
adding onPress handler to a Text Component does not call setClickable(true) (test case)
Related https://github.com/facebook/react-native/issues/27333#issuecomment-646135349

[ ] verify that the functionality works on other components (Touchable)
[ ] change accessible prop to true if onPress handler available in Text JavaScript Component (VIDEO)
[ ] review existing use cases of setClickable() in ReactAndroid


LongMethod excludes functionality or global excludes config rule definition

Hello everyone 👋 , creating an issue here to encapsulate the global ignore / exclude functionality.
I found a specific use case for it (but I could imagine how it can be applied in many other rules).
The initial discussion happened in kotlinlang detekt slack which you can read here
Context
In short, it would be nice to have an ignore / exclude property in the yaml in which you can define to every rule to specify where you don't want the rule to be applied.
My specific case is for the LongMethod rule. I would like to avoid applying the LongMethod rule if the method is called getEpoxyController Epoxy is a library that helps create screens faster in a programmatic way instead of XML (defining your views on a linear list). Due to relation to UI and the linear nature of it some could argue that there is no need of creating methods (specially for simple screens).
Due to LongMethod being set to 60 (which we want it for the rest of the codebase) we are either:

Extracting into methods when it is not necessary
Adding @Suppress("LongMethod") in all of our epoxy controllers
Or just overriding the global baseline baseline every time

Expected Behavior of the rule
LongMethod:
    active: true
    threshold: 60
    excludeMethods:
        - getEpoxyController

The reason to suggest a global config rule instead just for LongMethod is that there are already several exclude / ignore options as seen here and I wanted to get feedback on the idea of having instead a set of predefined excludes global wise that all rules would understand. This way you could add to any rule something like:

excludePaths
excludeMethods
excludeClasses
excludeAnnotations

Thank you 🙏

In first rule that needs exludes do:
  excludes: &testPatterns
    - '**/test/**'
    - '**/androidTest/**'
    - '**/integrationTest/**'
    - '**/commonTest/**'
    - '**/jvmTest/**'
    - '**/jsTest/**'
    - '**/iosTest/**'
    - '**/*.Test.kt'
    - '**/*.Spec.kt'
    - '**/*.Spek.kt'

In other places do:
    excludes: *testPatterns

Does this exclude work for any rule?
How would that look for excluding LongMethod on specific method names like getEpoxyController?

There are a lot of options here: function name, class name, file name (already covered), package, source set, with annotation...
I agree that we need to unify the way to add exceptions to a rule but I don't see how to do it in a flexible way. The only way that I can think of is by using a dsl so anyone can write its own exclusion code. Obviously we should provide easy ways to archive usual use cases but this way we would be really flexible.
There's a similar proposal in #2581. It only stand for file path but it could be extended.

Agree on what @BraisGabin mentioned.
To get back to the specific rule/problem, I believe we should probably add an excludeMethods (or excludeMethodsNamed) to allow filtering based on the name of the function.
I can see how this config could be used in other scenarios (e.g. the onCreate on a Jetpack Compose based Android application).

Does this exclude work for any rule?
How would that look for excluding LongMethod on specific method names like getEpoxyController?

No it works in rules where it applied. Can you clarify on use case for excludes from all rules?
Unfortunately not all rules provide relevant excludes. E.g method centric rules should provide method name and annotation excludes at minimum. Than Yaml provides a way to reuse exclude lists between rules.

Can you clarify on use case for excludes from all rules?

Can't think of one for all rules but imagine you have a method name that you want to avoid from any detekt flag. Instead of adding @Suppress or baseline each time it would be good to have a global method exclude
Anyway, for my specific problem I just want to ignore all getController method names to be reported as a long method due to the nature of that method name used to draw epoxy views
How would the above look? @vladimirfx

@sanogueralorenzo, unfortunately LongMethod rule do not support exclusion by method name. We also suffer from this in our Android projects.
My first comment about patterns reuse in config and not about LongMethod specifically.
I think Detekt needs some common trait based mechanism used in all rules. Depending on scope and semantic of rule it may implement common exclusion traits:

excludePackages (seems useful for all rules)
excludeFiles (useful for most rules)
excludeClasses
excludeFunctions
excludeAnnotations
etc

This excluded may be implemented in common rule wrapper so particular rule is not invoked at all if configured exclude matched.

In first rule that needs exludes do:
  excludes: &testPatterns
    - '**/test/**'
    - '**/androidTest/**'
    - '**/integrationTest/**'
    - '**/commonTest/**'
    - '**/jvmTest/**'
    - '**/jsTest/**'
    - '**/iosTest/**'
    - '**/*.Test.kt'
    - '**/*.Spec.kt'
    - '**/*.Spek.kt'

In other places do:
    excludes: *testPatterns

Works from Detekt early days.

Cool! This is what I was looking for. I did not know about this notation. Maybe something to add to the detekt configuration file documentation.

This is what I was looking for. I did not know about this notation. Maybe something to add to the detekt configuration file documentation.

Absolutely 👍  Are you up for sending a PR @Whathecode ?

@cortinico Will gladly contribute if I find some downtime! :) I now learned these are basic YAML features, so probably it is simply a matter of referring people to that relevant documentation and giving an example.

This issue was partially done:

[X] excludePaths
[ ] excludeMethods (work in progress #4148)
[ ] excludeClasses
[X] excludeAnnotations

Excluding classes by its name could be next one but I would like to know a good use case for it first. So if you have one, please open a new issue so we can talk about it.
So I'm going to close this issue.


Extract page table registers

x86 has a series of special registers that we need to reconstruct the page table structure.
We need this to map virtual to physical memory

addressed in https://github.com/Mic92/vmsh/pull/50


[Accessibility] Unable to navigate between action buttons using Tab in confirmation dialog

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.81.1
OS Version: macOS Ventura 13.4.1

Steps to Reproduce:

Open a new editor tab with Cmd + N
Type some text
Close the tab using Cmd + W; a confirmation dialog appears, reminding you to save before closing
Navigate between the "Save," "Don't Save," and "Cancel" buttons using the Tab key

Hi VSCode team,
Thanks for all your hard work.
I came across this related to accessibility that I couldn't find in the known issues. As mentioned above, the action buttons in the confirmation dialog should be tappable.

I'd love to help with this if it's ok. Thanks!

thanks for the issue . this is working for me - maybe try insider's and/or see what program might be intercepting tab for you
https://github.com/microsoft/vscode/assets/29464607/56917319-4793-4a95-bfd5-dbf2ceeb2986

Hi, @meganrogge Thanks for quick response!
So, I've tried a few things – both on the insider and another laptop of mine. As you can see in the video, the tab key just doesn't seem to work only happens when the confirmation dialog pops up. I'm quite confident that no program is messing with the tab key for me. But well, I guess if someone else runs into this then tackle it.
Thanks again!
https://github.com/microsoft/vscode/assets/26245542/876d843a-ddbf-44a0-a7ea-98bbb7374edb


No module named 'PyTorchConv3D'"

when I run the mainfineaction.py,it report the error of "ModuleNotFoundError: No module named 'PyTorchConv3D'",but i don't know how to intall the package,could u pls help me with the issue

I think it's in this repo and you need to download it yourself. https://github.com/tomrunia/PyTorchConv3D

Hi @GUOGUO-lab, as @xjtupanda suggested, PyTorchConv3D is this repo https://github.com/tomrunia/PyTorchConv3D, we used it to extract I3D features for FineGym. But this repo is not used in our main experiments, so we removed them from the dependencies and provided the features instead. The code has been updated. Thanks!


Mobile Safari landscape zoom level (redux)

See issue #1015
I'm not sure about equally light, but there is a javascript solution by Scott Jehl that fixes the orientation bug while allowing the user full ability to zoom the page. It seems heavy to me but may be light to you guys.
https://github.com/scottjehl/iOS-Orientationchange-Fix

For now we'll leave this out of the toolkit. I don't want to add too many dependencies for responsive/mobile because we just need to provide a baseline there. If we go too overboard, it'll be too limited for folks.
Thanks for the link though!


Examples show wrong use of dcat:service

Examples add an instance of cpsv:PublicService to dcat:service. The range of the latter is to be dcat:DataService. Therefore examples must be fixed.

Depends on https://github.com/Informasjonsforvaltning/datacatalogtordf/issues/54


User login guard

Description
We added firebase guard to authenticate users.
Fixes/resolves #40
Screenshots
Please include any screenshots or media that illustrates the changes made
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Improvement (non-breaking change which improves existing functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:
Leave blank if not applicable
I have completed these steps when making this pull request:

[x] I have assigned my name to the issue
[x] I have moved the issue to the In Progress column
[x] I have labelled the PR appropriately
[x] I have assigned myself to the PR

Before opening the PR for review:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] I have moved the linked issue to the Review in Progress column

this happens when not logged in

 this happens when not logged in

This is fine, we expect an exception to be thrown if a protected endpoint is accessed while not authenticated.
Suggestion: Check if the token is falesy (empty, null, undefined) and throw with a special message (i.e. no token was provided).

 this happens when not logged in

This is fine, we expect an exception to be thrown if a protected endpoint is accessed while not authenticated.
Suggestion: Check if the token is falesy (empty, null, undefined) and throw with a special message (i.e. no token was provided).

I disagree, this is an expected input and should not through an exception (at least not without being caught so we can return 401). This exception is a byproduct of not being signed in and should be fixed

Nest states that it should be handled with an exception. But looking at that output I'm not actually sure its throwing the correct one.

Actually never mind it all works fine there is no unhandled error, it is just being console logged. The correct exception is thrown and it returns 401 to the client.

you are missing part of the spec:
If it is valid: 1. Check if the user exists in mongodb database 2. If they exist: let endpoint return as normal 3. Else create user and then let endpoint return as normal.

Actually shouldn't this be done in #45 since the user schema is not correct at this stage so #45 will have to change it anyway

you are missing part of the spec:
If it is valid: 1. Check if the user exists in mongodb database 2. If they exist: let endpoint return as normal 3. Else create user and then let endpoint return as normal.

Actually shouldn't this be done in #45 since the user schema is not correct at this stage so #45 will have to change it anyway

Yeah might be easier that way. 👍🏻


Bump EKS Anywhere Packages to v0.1.5

It appears the mirror in code build does not update the tag and although that works fine locally, it is ignored by the pipeline. I just created a new tag.

/lgtm

/lgtm


Add some GitHub actions to the projects

I'm thinking about:

typos
dependabot
ci that could launch tests and golangci-lint

I can easily add them


Uploads fail intermittently

I've been having trouble when using the bash uploader with Jenkins. I've output the upload logging to verbose and I keep seeing the same error over and over.
curl: (92) HTTP/2 stream 1 was not closed cleanly: PROTOCOL_ERROR (err 1)
I can't quite seem to reproduce it cleanly every time. My test suite runs and it seems to work sometimes and fails others. I have 4 targets that run and upload after each. The upload error occurs intermittently across all 4 targets, so it can't be an issue with the tests or the coburtera.xml file I'm uploading. Anyone else getting this issue.
Here is the upload command I'm using for Jenkins.
sh 'curl -s https://codecov.io/bash | bash -s - -v -f test-reports/cobertura.xml -t ${CODECOV_TOKEN}'

Here is some output from the very end of the failed upload.
++ curl -X POST --data-binary @/tmp/codecov.S2tjgu.gz -H 'Content-Type: text/plain' -H 'Content-Encoding: gzip' -H 'X-Content-Encoding: gzip' -H 'Accept: text/plain' 'https://codecov.io/upload/v2?package=bash-0b37652&token=****&branch=PR-46&commit=4eaa97a5557d1ecbdd2fcb74d1607bb054c7e816&build=101&build_url=https%3A%2F%2Fci.simpleinout.app%2Fjob%2Fsimpleinout-ios%2Fjob%2FPR-46%2F101%2F&name=&tag=&slug=simplymadeapps%2Fsimpleinout-ios&service=jenkins&flags=&pr=46&job='
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 76  187k    0     0   76  144k      0   663k --:--:-- --:--:-- --:--:--  660k
100  187k    0     0  100  187k      0   156k  0:00:01  0:00:01 --:--:--  156k
100  187k    0     0  100  187k      0  87298  0:00:02  0:00:02 --:--:-- 87296
100  187k    0     0  100  187k      0  60034  0:00:03  0:00:03 --:--:-- 60033
100  187k    0     0  100  187k      0  45746  0:00:04  0:00:04 --:--:-- 45746
100  187k    0     0  100  187k      0  36952  0:00:05  0:00:05 --:--:--  8980
100  187k    0     0  100  187k      0  30994  0:00:06  0:00:06 --:--:--     0
100  187k    0     0  100  187k      0  26690  0:00:07  0:00:07 --:--:--     0
100  187k    0     0  100  187k      0  23436  0:00:08  0:00:08 --:--:--     0
100  187k    0     0  100  187k      0  20889  0:00:09  0:00:09 --:--:--     0
100  187k    0     0  100  187k      0  18842  0:00:10  0:00:10 --:--:--     0
100  187k    0     0  100  187k      0  17160  0:00:11  0:00:11 --:--:--     0
100  187k    0     0  100  187k      0  15753  0:00:12  0:00:12 --:--:--     0
100  187k    0     0  100  187k      0  14560  0:00:13  0:00:13 --:--:--     0
100  187k    0     0  100  187k      0  13535  0:00:14  0:00:14 --:--:--     0
100  187k    0     0  100  187k      0  12644  0:00:15  0:00:15 --:--:--     0
100  187k    0     0  100  187k      0  11864  0:00:16  0:00:16 --:--:--     0
100  187k    0     0  100  187k      0  11174  0:00:17  0:00:17 --:--:--     0
100  187k    0     0  100  187k      0  10560  0:00:18  0:00:18 --:--:--     0
100  187k    0     0  100  187k      0  10010  0:00:19  0:00:19 --:--:--     0
100  187k    0     0  100  187k      0   9515  0:00:20  0:00:20 --:--:--     0
100  187k    0     0  100  187k      0   9066  0:00:21  0:00:21 --:--:--     0
100  187k    0     0  100  187k      0   8658  0:00:22  0:00:22 --:--:--     0
100  187k    0     0  100  187k      0   8284  0:00:23  0:00:23 --:--:--     0
100  187k    0     0  100  187k      0   7942  0:00:24  0:00:24 --:--:--     0
100  187k    0     0  100  187k      0   7627  0:00:25  0:00:25 --:--:--     0
100  187k    0     0  100  187k      0   7336  0:00:26  0:00:26 --:--:--     0
100  187k    0     0  100  187k      0   7066  0:00:27  0:00:27 --:--:--     0
100  187k    0     0  100  187k      0   6816  0:00:28  0:00:28 --:--:--     0
100  187k    0     0  100  187k      0   6582  0:00:29  0:00:29 --:--:--     0
100  187k    0     0  100  187k      0   6364  0:00:30  0:00:30 --:--:--     0
100  187k    0     0  100  187k      0   6160  0:00:31  0:00:31 --:--:--     0
100  187k    0     0  100  187k      0   5969  0:00:32  0:00:32 --:--:--     0
100  187k    0     0  100  187k      0   5789  0:00:33  0:00:33 --:--:--     0
100  187k    0     0  100  187k      0   5620  0:00:34  0:00:34 --:--:--     0
100  187k    0     0  100  187k      0   5460  0:00:35  0:00:35 --:--:--     0
100  187k    0     0  100  187k      0   5309  0:00:36  0:00:36 --:--:--     0
100  187k    0     0  100  187k      0   5167  0:00:37  0:00:37 --:--:--     0
100  187k    0     0  100  187k      0   5031  0:00:38  0:00:38 --:--:--     0
100  187k    0     0  100  187k      0   4903  0:00:39  0:00:39 --:--:--     0
100  187k    0     0  100  187k      0   4781  0:00:40  0:00:40 --:--:--     0
100  187k    0     0  100  187k      0   4665  0:00:41  0:00:41 --:--:--     0
100  187k    0     0  100  187k      0   4554  0:00:42  0:00:42 --:--:--     0
100  187k    0     0  100  187k      0   4449  0:00:43  0:00:43 --:--:--     0
100  187k    0     0  100  187k      0   4348  0:00:44  0:00:44 --:--:--     0
100  187k    0     0  100  187k      0   4252  0:00:45  0:00:45 --:--:--     0
100  187k    0     0  100  187k      0   4160  0:00:46  0:00:46 --:--:--     0
100  187k    0     0  100  187k      0   4072  0:00:47  0:00:47 --:--:--     0
100  187k    0     0  100  187k      0   3987  0:00:48  0:00:48 --:--:--     0
100  187k    0     0  100  187k      0   3906  0:00:49  0:00:49 --:--:--     0
100  187k    0     0  100  187k      0   3829  0:00:50  0:00:50 --:--:--     0
100  187k    0     0  100  187k      0   3754  0:00:51  0:00:51 --:--:--     0
100  187k    0     0  100  187k      0   3682  0:00:52  0:00:52 --:--:--     0
100  187k    0     0  100  187k      0   3613  0:00:53  0:00:53 --:--:--     0
100  187k    0     0  100  187k      0   3546  0:00:54  0:00:54 --:--:--     0
100  187k    0     0  100  187k      0   3482  0:00:55  0:00:55 --:--:--     0
100  187k    0     0  100  187k      0   3420  0:00:56  0:00:56 --:--:--     0
100  187k    0     0  100  187k      0   3360  0:00:57  0:00:57 --:--:--     0
100  187k    0     0  100  187k      0   3302  0:00:58  0:00:58 --:--:--     0
100  187k    0     0  100  187k      0   3246  0:00:59  0:00:59 --:--:--     0
100  187k    0     0  100  187k      0   3193  0:01:00  0:01:00 --:--:--     0
100  187k    0     0  100  187k      0   3189  0:01:00  0:01:00 --:--:--     0
curl: (92) HTTP/2 stream 1 was not closed cleanly: PROTOCOL_ERROR (err 1)
++ echo 'HTTP 500'
+ res='HTTP 500'
++ echo 'HTTP 500'
++ head -1
++ cut '-d ' -f2
+ status=500
+ '[' 500 = '' ']'
+ '[' 5 = 5 ']'
+ say '    \033[0;90m->\033[0m Sleeping for 30s and trying again...'
+ echo -e '    \033[0;90m->\033[0m Sleeping for 30s and trying again...'
    -> Sleeping for 30s and trying again...
+ sleep 30
+ '[' 4 -lt 4 ']'
+ say '    \033[0;31mX> Failed to upload coverage reports\033[0m'
+ echo -e '    \033[0;31mX> Failed to upload coverage reports\033[0m'
    X> Failed to upload coverage reports
+ exit 0

No activity since 5 months? This problem still happens.

I have been working directly with Eli on this issue. It’s moved to something else so you can close this ticket.
Bill

Bill Burgess
Co-Founder/Developer
Simply Made Apps
On May 21, 2019, 11:31 AM -0500, Anıl Anar<EMAIL_ADDRESS>wrote:

No activity since 5 months? This problem still happens.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I've been working with people on the team and haven't gotten to the root of the problem just yet. It seems to happen a lot more frequently on my larger runs. I've since broken my build into smaller components and upload coverage after each smaller run and it seems to have helped. I've had other unrelated issues, but those aren't relevant to this issue.

FWIW I too am having this problem under Travis CI. It seems to always work on the second attempt.
I've been wondering about decreasing the curl timeout and/or the 30 second sleep, just to make the builds a little more responsive (in my case, coverage uploading is responsible for 2m out of a 4m build), but it'd be good to know what's actually failing before hitting the server that little bit harder.

@jmalloc I've had better results since finding out that my codecov.yml wasn't formatted quite right. I ran it through yamllint.com and fixed some character that was in there causing problems and things improved quite a bit. It may not solve your issue, but helped mine.

bump...

Any updates on this issue? I'm continuing to have issues. It has something to do with the bash uploader. I use slather to generate the cobertura.xml file. That part works fine. I can run the uploader and it will time out retrying 1, 2, 3 times. But it will eventually work with the same file. Most of the time I run it, if it doesn't upload in the first 10 seconds, I'll kill the run, try again. Most of the time it works in about 8 seconds. But it still randomly fails for me when run locally or on CI. I'm not sure what is going on or why this is still happening. We are now on their free plan and no longer have support for this issue, so they aren't much help.

@billburgess, we hope to deploy a fix for this shortly, thanks for your patience.

So this is a known issue with a fix coming sometime soon?

@billburgess this fix is not in the bash uploader, but we have added some retry arguments here to help mitigate. If you are still seeing this, could you post a build URL from your CI/CD?

All of my projects are private repos hosted run on a private jenkins server. I can usually recreate this locally quite often if there is something you'd like me to send. But I'm not comfortable posting here.

@billburgess fair enough, could you share the Codecov output with redacted values?

@thomasrockhu Are you looking for the complete --verbose output, or just the error output I see when it is retrying and failing?

@billburgess Approximately from where the upload begins to the end of the output

/ |        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / ` |/ _ / / _ \ \ / /
| || () | (| |  __/ (| () \ V /
______/ _,|_|____/ _/
Bash-20200917-4e8f14b
x> No CI provider detected.
Testing inside Docker? http://docs.codecov.io/docs/testing-with-docker
Testing with Tox? https://docs.codecov.io/docs/python#section-testing-with-tox
project root: /Users/Brasky/Git/simpleinout-ios
Yaml found at: codecov.yml
-> Found 1 reports
==> Detecting git/mercurial file structure
==> Reading reports
+ test-reports/cobertura.xml bytes=1461544
==> Appending adjustments
https://docs.codecov.io/docs/fixing-reports
+ Found adjustments
==> Gzipping contents
==> Uploading reports
url: https://codecov.io
query: branch=PHONE-239-Fix-SMTWifiStatus&commit=57ac8fcd95f4a4d47e95c9760e17261fbc14a395&build=&build_url=&name=&tag=&slug=billburgess%2Fsimpleinout-ios&service=&flags=&pr=&job=&cmd_args=t,f,X,X,X
->  Pinging Codecov
https://codecov.io/upload/v4?package=bash-20200917-4e8f14b&token=secret&branch=PHONE-239-Fix-SMTWifiStatus&commit=57ac8fcd95f4a4d47e95c9760e17261fbc14a395&build=&build_url=&name=&tag=&slug=billburgess%2Fsimpleinout-ios&service=&flags=&pr=&job=&cmd_args=t,f,X,X,X
->  Uploading to
https://storage.googleapis.com/codecov/v4/raw/2020-09-29/F370D7856023D9B8D6A6A1722A4FB27B/57ac8fcd95f4a4d47e95c9760e17261fbc14a395/0a6e8132-0d99-41ed-90c9-4e45ef610d96.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=GOOG1EQX6OZVJGHKK3633AAFGLBUCOOATRACRQRQF6HMSMLYUP6EAD6XSWAAY%2F20200929%2FUS%2Fs3%2Faws4_request&X-Amz-Date=20200929T161916Z&X-Amz-Expires=10&X-Amz-SignedHeaders=host&X-Amz-Signature=fa91c7a35ed96c370b423a5212b008ad546237261045916a4da7f298d0133890
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100  206k    0     0  100  206k      0    585  0:06:01  0:06:00  0:00:01     0
curl: (22) The requested URL returned error: 408
X> Failed to upload
==> Uploading to Codecov
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100  206k    0     0  100  206k      0   3463  0:01:01  0:01:01 --:--:--     0
curl: (92) HTTP/2 stream 0 was not closed cleanly: PROTOCOL_ERROR (err 1)
HTTP 500

Hi @billburgess, we’ve made significant updates to our infrastructure to address the above issue. Please let me know if you are still experiencing this issue.

Seeing different errors now.

408 Request Timeout

Error: Request Timeout
Your client has taken too long to issue its request.

HTTP 200
https://codecov.io/github/mycompany/myrepo/commit/hash'
++ echo '

408 Request Timeout

Error: Request Timeout
Your client has taken too long to issue its request.

HTTP 200
https://codecov.io/github/mycompany/myrepo/commit/hash'
++ head -1
++ cut '-d ' -f2
+ status=
+ '[' '' = '' ']'
++ echo '

408 Request Timeout

Error: Request Timeout
Your client has taken too long to issue its request.

HTTP 200
https://codecov.io/github/mycompany/myrepo/commit/hash'
++ head -2
++ tail -1
+ say '    View reports at \033[0;36m\033[0m'
+ echo -e '    View reports at \033[0;36m\033[0m'
    View reports at
+ exit 0
Links to GitHub have been scrubbed.

@billburgess, would you be able to post more of the output?

@billburgess you can email<EMAIL_ADDRESS>and tag my name


Support custom root directory alias for imports

VSCode depends on being able to resolve imported references for intellisense. So when using something that rewrites import paths -- specifically: babel-plugin-module-resolver -- we lose intellisense.
 The aforementioned module lets you define an alias like "~=/src" and then just:
import 'thing-to-test' from '~/feature/subfeature/helper/thing
Atom and Webstorm are both capable of being configured with information about such aliases to enable them to resolve the paths correctly.
Is there any way this capability can be added to VS Code? I really want to be able to continue to use these, but the loss of intellisense is tough to swallow.

@waderyan IMO tsserver 2.0.3 is able to do this. They now support a rootPath. But you need to test.

@jamietre thank you for opening this issue. This fell through the cracks for me so apologize it took some time. We have done a fair amount of work here. Can you try again with VS Code Insiders? If it is still not working can you share a workspace with me to test out the issue.

@waderyan no problem - but how do I test it? I assume there needs to be some config to tell it what aliases e.g. ~ mean.

@jamietre apologize that my writing was unclear. Please test the situation you described in this issue. Do we still "[lose] IntelliSense" when import paths are rewritten? If you have a workspace that shows the issue can you share it with me.

I can create a workspace but it's quite simple really,
module 1:
import something from '~/module2'

where module might be `../../folder1/folder2/module2'
I think you might be unclear on the situation I am describing (or feature I am requesting) because import paths aren't being rewritten by VS Code, they are being rewritten during my build process by a babel plugin. VS Code would have no knowledge of this process or what the mappings meant, unless it actually did some analysis of the compiled code, or had specific knowledge of the plugin I mentioned and parsed .babelrc to use the same config.
The simple solution would be for some configuration in VS Codewhere I can tell it that for this workspace, ~/ in an import means {projectRoot}/src/. I don't see how anything would just start working unless I added config to tell VSCode what my alias means.

@jamietre thank you for your explanation. I looked around in Atom and WebStorm but couldn't find how to do this. Can you point it out for me? We may want to adopt something similar.
@mhegazy @bowdenk7 have either of you seen a request like this before? Is this something that could be done? Exploring the possible solutions right now.

WebStorm has a feature called "resource root" which lets you use path aliases:
http://stackoverflow.com/questions/34943631/path-aliases-for-imports-in-webstorm
This would be a very handy feature for developers using webpack.

@majomb thanks - sorry i totally missed this question.  I am not an Atom user but the 'babel-plugin-module-alias' website says "Atom: Uses atom-autocomplete-modules and enable the babel-plugin-module-resolver option."
An implementation of this feature that's compatible with babel-plugin-module-alias would allow you to specify a prefix and a replacement. Whenever VS Code resolves a path in an "import", if it starts with the prefix from my config, then the prefix is replaced with my substituation path, The replaced value should handled as if it is rooted at the project workspace root. I could see a regex based implementation also having added value too.
e.g.
 {
    "~": "./src",
    "~test": "./test"
 }

This would result in an import in file {root}/test/common/util,js
import { thing } from "~/common/util"

being mapped to
import { thing } from "../../../src/common/util"

as far as VS code is concerned. It would then be able to find the file and intellisense and everything else would work. This is exactly what the babel plugin does when you compile. Obviously the benefit of using this babel-plugin-module-alias in the first place is not having to deak with & refactor crazy relative paths :)

This is already supported using paths mapping. in your tsconfig.json/jsonfig.json add an entry to your path mapping rules to match the ~ to whatever root you need. e.g.:
{
    "compilerOptions": {
        "baseUrl": "./",  // all paths are relative to the baseUrl
        "paths": {
            "~/*" : ["*"]   // resolve any `~/foo/bar` to `<baseUrl>/foo/bar`
        }
    }
}

hope that helps.

@mhegazy thanks for quick response. Seems that those compiler options are only allowed in tsconfig.json files and are missing from jsconfig.json.
https://www.typescriptlang.org/docs/handbook/compiler-options.html (paths is marked with [2])
https://code.visualstudio.com/docs/languages/jsconfig (paths is not listed as available option)

The option is honored in the two files. the schema needs to be updated in https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/jsconfig.json. PRs are welcomed.

It doesn't seem to work for me. In my jsconfig.json:
"compilerOptions": {
	"target": "es6",
	"module": "commonjs",
	"allowSyntheticDefaultImports": true,
	"baseUrl": "./",
	"paths": {
		"~/*": ["*"],
		"~test/*": ["test/*"]
	}
},

I don't get intellisense when using the alias, and "go to definition" doesn't work.

Please provide some repro project we can use to diagnose. here is what i see:

That looks exactly like what I'd expect! I am using insider, though can't think why that would make a difference for this. Will try in the release just to be sure..
The project I've been playing with is pretty huge, I'll try it in something more trivial to determine if it's my project or the environment.

Also the ability to specify additional module directories would be extremely useful as webpack allows you to do so:
{
...
  resolve: {
    modules: [path.join(__dirname, 'js'), 'node_modules'],
    ...
  },
...
}

This allows for the ability to reference source files without direct path resolutions such as
// from js dir
import api from 'data/api';

// from node modules
import _ from 'lodash';

I'm attempting to get this working (in a similar setup as @weikinhuang) without any luck. Should this work already?
// jsconfig.json
{
    "compilerOptions": {
        "target": "ES6",
        "module": "commonjs",
        "allowSyntheticDefaultImports": true,
        "paths": {
          "*": ["src/*"]
        }
    }
}

Relevant webpack config:
const config = {
  resolve: {
    modulesDirectories: [
      'src',
      'node_modules',
    ],
    extensions: ['', '.json', '.js', '.jsx'],
   },
}

// src/components/TestComponent.js

import AnotherComponent from 'components/AnotherComponent'; // doesn't work
import TestComponent from './TestComponent' // works as expected

I'm attempting to get this working (in a similar setup as @weikinhuang) without any luck. Should this work already?

You are missing an * in your mappings:
// jsconfig.json
{
    "compilerOptions": {
        "target": "ES6",
        "module": "commonjs",
        "allowSyntheticDefaultImports": true,
        "baseUrl": "./",
        "paths": {
          "components/*": ["src/components/*"],
          "utils/*": ["src/utils/*"],
          "redux/*": ["src/redux/*"],
          "routes/*": ["src/routes/*"],
          "api/*": ["src/api/*"]
        }
    }
}

From these mappings, it seems that all you need is to set the baseUrl to src/.
all path mapping entries are relative to baseUrl. since all your path mapping entries are subfolders of the src directory, it would be easier to just not have path mappings.
you can read more about how path mapping works at: www.typescriptlang.org/docs/handbook/module-resolution.html#path-mapping

@mhegazy, thank you so much, basePath: "src/" did the trick! May your day be as awesome as you!

thanks 🌷. glad it worked.

Closing as it sounds like this issue has been fixed.

@mjbvz @mhegazy - I found this issue while looking for custom root directory, and with your explanations, I was able to also setup my project properly to have intellisense with custom paths.
But cmd+click is not working for these custom paths. Is there any way to have them working?

I'm actually still seeing issues with red squigglies and no go-to-definition for mapped paths. I'll try to get a minimum-reproducible repo up, but for now the two things that we're doing that might be unexpected are:

mapped path starts with an @ character
paths is set in a base tsconfig, while baseUrl is set in a child tsconfig (one that inherits from the base tsconfig

I am using Angular CLI
it divided the tsconfig in to /tsconfig.json and /src/tsconfig.app.json
however, I found that vscode only able to read the first one, /tsconfig.json only and ignore the later
my workaround solution:
/tsconfig.json
"baseUrl": "src/",
    "paths": {
      "@shared": [
        "app/shared"
      ],
      "@shared/*": [
        "app/shared/*"
      ]
    }

/src/tsconfig.app.json
"baseUrl": "",
    "paths": {
      "@shared": [
        "app/shared"
      ],
      "@shared/*": [
        "app/shared/*"
      ]
    },

https://code.visualstudio.com/docs/languages/jsconfig (paths is not listed as available option)

As @marianban pointed out, this feature is not documented. I've raised a PR to fix this at https://github.com/Microsoft/vscode-docs/pull/942.

This is still causing me issues. I've run through the various suggestions in this list, but can't figure out why it isn't working.
VSCode: 1.12.2
Typescript: 2.3.2
jsconfig.json
{
  "compilerOptions": {
    "checkJs": true,
    "target": "ES6",
    "baseUrl": "src/"
  },
  "exclude": [
    "node_modules",
    "lib",
    ".tmp",
    "build"
  ]
}

TypeScript definition file

Relevant Portion of the Directory

set "moduleResolution": "node".

Thank you! That got red of the squiggly and error, but I'm still not getting intellisense.

can you share a repro project?

Hi,
I'm trying to fix this in my project which has no Typescript dips but is just ES6.
My web pack moduleDirectories is setup like this
modulesDirectories: ['node_modules', 'src']
I'v amended this to my jsconfig.json
"compilerOptions": {
        "target": "ES6",
        "moduleResolution": "node",
        "baseUrl": "./src"
    }

When I try and cmd click on say removeProps
import {removeProps} from "utils/thing_type_utils";

I'm not able to jump to that function.
Works fine with full path imports ...
Any ideas?
/Stephen.

can you share a repro project?

I can try, I don't want share our prod code, but in short your saying it should work?
/stephen
Sent from my iPhone

On 7 juni 2017, at 16:59, Mohamed Hegazy<EMAIL_ADDRESS>wrote:
can you share a repro project?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

yup.

Hmm, I'll fiddle again, although one thing is that I get an unknown configuration property in jasconfig for compilerOptions (squiggly line).. which you don't? Wondering if an extension is mucking things up?
Sent from my iPhone

On 7 juni 2017, at 18:43, Mohamed Hegazy<EMAIL_ADDRESS>wrote:
yup.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@maitriyogin found anything? Seems I'm on the same boat as you. Module resolution as been working on and off for me, for the past year or so.

Heyas. Having a problem new'ing classes using the tsconfig/jsconfig approach with baseUrl and paths properties. I was able to fix the complaints of webpack not being able to resolve the relative paths, but now when I try to actually instantiate one of the classes, the webpack compiler says it can't resolve the module. For instance:
tsconfig.json:
"baseUrl": "./app",
"paths": {
    "components/*": ["components/*"],
    "lib/*": ["lib/*"],
    "models/*": ["models/*"]
},

My file:
import User from 'models/User';
public test() {
  let user = new User; // <-- compiler complains with 'Cannot resolve 'models/User'.
}

So you see, Visual Studio Code will allow it without errors, because of the correct baseUrl and paths properties, but the compiler can't see the modules. If I change the paths to relative, ie:
import User from '../models/User'
everything works fine.
Is there a way to get the compiler and VS Code to both work together? Has anyone else run into this problem?

FYI, to get webpack 3 to compile relative modules that are declared in tsconfig/jsconfig.json 'paths' property, you have to also add them to webpack config's 'resolve.modules' property, ie:
tsconfig.json:
"baseUrl": "./app",
"paths": {
    "~/*": ["./*"],
    "components/*": ["components/*"],
    "lib/*": ["lib/*"],
    "models/*": ["models/*"]
}

webpack.config.js:
resolve: {
    modules: [ 'node_modules', 'app', 'app/models', 'app/components', 'app/lib' ]
}

Hope it helps someone!

@mhegazy setting moduleResolution works for me, but now I have the warning:

Property moduleResolution is not allowed

You have that warning on demo screenshot too. Is there any way to avoid the warning message?

Having issues with this as well, it compiles fine in webpack, but I get the annoying red underline in vscode.

tsconfig.json
{
    "compileOnSave": false,
    "compilerOptions": {
        "allowSyntheticDefaultImports": true,
        "lib": [
            "dom",
            "es2015",
            "es2016",
            "es6",
            "es2017"
        ],
        "target": "es2017",
        "module": "es6",
        "moduleResolution": "node",
        "noImplicitAny": true,
        "noUnusedLocals": true,
        "noUnusedParameters": true,
        "removeComments": false,
        "baseUrl": ".",
        "paths": {
            "@base": ["."],
            "@community": ["src/vue/community"],
            "@components": ["src/vue/components"],
            "@src": ["src"],
            "@vue": ["src/vue"]
        },
        "preserveConstEnums": true,
        "sourceMap": true,
        "skipLibCheck": true
    }
}

webpack.base.conf.js
    resolve: {
        extensions: ['.ts', '.js', '.vue', '.json'],
        alias: {
            '@base': resolve('.'),
            '@community': resolve('src/vue/community'),
            '@components': resolve('src/vue/components'),
            '@src': resolve('src'),
            '@vue': resolve('src/vue')
        }
    },

Try to add the 'modules' property within resolve, ie:
resolve: {
extensions: ['.js', '.jsx', '.ts', '.tsx'],
modules: [ 'node_modules' ] // try to add '@src', 'src', 'src/vue', etc...
},
On Wed, Aug 9, 2017 at 4:42 PM, amritk<EMAIL_ADDRESS>wrote:

Having issues with this as well, it compiles fine in webpack, but I get
the annoying red underline in vscode.
[image: screenshot from 2017-08-09 13-40-00]
https://user-images.githubusercontent.com/2039539/29142921-47a6bf98-7d08-11e7-8cc8-a80bec6e1319.png
tsconfig.json
{
"compileOnSave": false,
"compilerOptions": {
"allowSyntheticDefaultImports": true,
"lib": [
"dom",
"es2015",
"es2016",
"es6",
"es2017"
],
"target": "es2017",
"module": "es6",
"moduleResolution": "node",
"noImplicitAny": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"removeComments": false,
"baseUrl": ".",
"paths": {
"@base": ["."],
"@community": ["src/vue/community"],
"@components": ["src/vue/components"],
"@src": ["src"],
"@vue": ["src/vue"]
},
"preserveConstEnums": true,
"sourceMap": true,
"skipLibCheck": true
}
}
webpack.base.conf.js
resolve: {
    extensions: ['.ts', '.js', '.vue', '.json'],
    alias: {
        '@base': resolve('.'),
        '@community': resolve('src/vue/community'),
        '@components': resolve('src/vue/components'),
        '@src': resolve('src'),
        '@vue': resolve('src/vue')
    }
},

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/14907#issuecomment-321375325,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWtmImaP2e832rU-wjVN3eGa2UfoPNcks5sWhmygaJpZM4KoVsB
.

@rw3iss would the webpack config affect vscode? I thought vscode was resolving the paths from tsconfig.json

Yeah, true. I don't know, I have the relative paths working within VSCode
on one of my projects. Here's the configs, if it helps:
(from within ./app/lib/Authentication.ts):
import User from 'models/User';
Here is my tsconfig.json:
{
"compilerOptions": {
"outDir": "./build/", // path to output directory
"sourceMap": true, // allow sourcemap support
"strictNullChecks": true, // enable strict null checks as a best practice
"module": "es6", // specifiy module code generation
"moduleResolution": "node",
"jsx": "react", // use typescript to transpile jsx to js
"target": "es2015", // specify ECMAScript target version
"allowJs": true, // allow a partial TypeScript and JavaScript codebase
"baseUrl": "./app",
"paths": {
"~/": ["./"],
"components/": ["components/"],
"lib/": ["lib/"],
"models/": ["models/"]
}
},
"include": [
"./app//*"
],
"exclude": [
"./node_modules//*"
],
"types": ["webpack-env"]
}
And my webpack config:
var webpack = require('webpack');
var path = require('path');
var BUILD_DIR = path.resolve(__dirname, 'build');
var APP_DIR = path.resolve(__dirname, 'app');
var config = {
entry: {
app: [
'webpack-dev-server/client?http://localhost:3000',
'webpack/hot/dev-server',
//'react-hot-loader/patch',
APP_DIR + '/entry.tsx'
]
},
output: {
publicPath: '/',
path: BUILD_DIR,
filename: '[name].js'
},
resolve: {
extensions: ['.js', '.jsx', '.ts', '.tsx'],
alias: {
components: path.resolve(__dirname, "app/components"),
lib: path.resolve(__dirname, "app/lib"),
models: path.resolve(__dirname, "app/models"),
},
modules: [ 'node_modules', 'app', 'app/models', 'app/components', 'app/lib'
]
},
module: {
loaders: [
{
test: /.(t|j)sx?$/,
include: APP_DIR,
exclude: /node_modules/,
loader: ['ts-loader']
}
]
},
plugins: [
new webpack.HotModuleReplacementPlugin(),
new webpack.NamedModulesPlugin()
],
devServer: {
hot: true,
contentBase: './',
publicPath: '/',
public: 'http://localhost:3000',
port: 3000
}
};
module.exports = config;
On Wed, Aug 9, 2017 at 4:47 PM, amritk<EMAIL_ADDRESS>wrote:

@rw3iss https://github.com/rw3iss would the webpack config affect
vscode? I thought vscode was resolving the paths from tsconfig.json
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/14907#issuecomment-321376665,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWtmD1s0QjId7yu4HOCwGn3jyRfcYv5ks5sWhrdgaJpZM4KoVsB
.

@rw3iss hey thanks for your help! turns out VSCode doesn't like them starting with an '@' symbol.

Sweet, yeah I was curious about that, seemed like it might not. Glad you
got it figured out!
On Wed, Aug 9, 2017 at 5:12 PM, amritk<EMAIL_ADDRESS>wrote:

@rw3iss https://github.com/rw3iss hey thanks for your help! turns out
VSCode doesn't like them starting with an '@' symbol.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/14907#issuecomment-321382660,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWtmLFiCwypYwpozNCx1K74fsADSRqnks5sWiCpgaJpZM4KoVsB
.

I'm using Inseider. Intellisense did not work in the React project.
I tried variously, if the extension is jsx,jsx: "react"is mandatory.
jsconfig.json OK
{
  "compilerOptions": {
    "jsx": "react",
    "baseUrl": ".",
    "paths": {
      "~/*": ["./*"]
    }
  }
}

jsconfig.json NG
{
  "compilerOptions": {
    "baseUrl": ".",
    "paths": {
      "~/*": ["./*"]
    }
  }
}

it's not ok in html,there is a snippets:
<script src="/static/jquery.js"></script>

but in fact the file is in '/www/static/jquery.js'.
when I press 'Ctrl' and click this path it tips:'file not found'

Can't get this to work, please help. Intellisense is still not working.

Inside index.ts I already get folder completion ('src/components'), but no .vue file completion :

Inside 'Hello.vue', there's no Intellisense whatsoever :

tsconfig.json :
"compilerOptions": {     "target": "es2015",     "lib": ["dom", "es2015", "es2017"],     "module": "es6",     "moduleResolution": "node",     "experimentalDecorators": true,     "strictNullChecks": true,     "removeComments": true,     "suppressImplicitAnyIndexErrors": true,     "allowSyntheticDefaultImports": true,     "allowJs": true,     "sourceMap": true,     "outDir": "./dist/",     "baseUrl": "./src",     "paths": {       "components/*": ["components/*"]     }   },   "include": ["./src/**/*"],   "exclude": ["./node_modules/**/*"]

jsconfig.json for vue-cli webpack template:
{
  "compilerOptions": {
    "baseUrl": "./",
    "paths": {
      "@/*": ["src/*"],
    }
  }
}

jsconfig.json located in the root of project

If you are running into problems related to import paths, please try asking on stackoverflow or posting a new issue


Close #82, pause audio when buttons or links are pressed. Adds try/ca…

…tch as that's now our practice. Refactoring seemed needed for one possible solution, but I can change most of it back since this went in another direction.
Also adds listening for the tap event. I thought jQuery covered taps with click, but I checked up on that and it doesn't seem clear that jQuery handles that.
Sorry I did so many things at once. If it's too much I can separate out the changes.
Closes #82.

would have suggested option 2

Sounds like a reasonable take. Do you want to add your thoughts in the issue itself just so we can have a better paper trail, @BryceStevenWilley?

What needs to happen next for this to move forward?


region lock does not work

hello I am posting this message because the region lock update part does not seem to work, when I move to a new region I lose all the items affiliated to the previous region. Is this normal or am I misunderstanding something?
thank you for your answers

Region Lock Updates [ID: 8]
Gear is tuned with local power of a region, so it is the strongest in that region and its power fades the further it gets from the region.
    For normal gear, every region away from the source region substracts 2 stars of weapon effectiveness.
    For + gear, every region away from the source region substracts 1 star of weapon effectiveness.

The regionlock update is not a removal of it, it changes he way it work to keep the same gamefeel while being less frustrating


Add hover information

Nice package! It'd be great if hover information was included

Hey @cpsievert thanks for opening this issue! I agree this is a good feature to add. It should even be the default behaviour.
Is this something you're interested in taking a look at yourself and maybe contributing to the project?

@cpsievert I'm implementing this in https://github.com/tpvasconcelos/ridgeplot/pull/174. What do you think of this as the default behaviour for the hover info displayed? I think it emulates Plotly's default behaviour close enough. Will merge and release this soon 👍

@cpsievert see some interactive examples here (PR docs): https://ridgeplot--174.org.readthedocs.build/en/174/getting_started/getting_started.html

@cpsievert just released this. If you upgrade (pip install 'ridgeplot==0.1.24') you should be able to see the hover info by default. Feedback is welcome!


[SPARK-21195][CORE] MetricSystem should pick up dynamically registered metrics in sources

What changes were proposed in this pull request?
MetricSystem picks up new metrics from sources that are added throughout execution. If you do measurements via dynamic proxies you might not want to redeclare all metrics that the proxies will create and you'd prefer them to get populated as they're being produced. Right now all sources are processed only onceat startup and metrics are picked up only if they have been registered statically at compile time. Behaviour I am proposing lets you not have to declare metrics in two places.
This had been previously suggested in #18406, #29980 and #31267.
Why are the changes needed?
Currently there's no way to access MetricRegistry that MetricsSystem uses to hold its state and as such it's not possible to reprocess a source. MetricsSystem throws if any metric had already been registered previously.
n.b. the MetricRegistry is added as a constructor argument to make testing easier but could as well be accessed via reflection as a private variable.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added tests

Can one of the admins verify this patch?


Add deprecation warning when 'mock_model' and 'stub_model' have been used.

My app is currently reporting "undefined method `stub_model' for many old specs. Searching around revealed that these methods were deprecated in rspec 3.0.
Would be much nicer to have rspec report that the messages had been deprecated and suggest the user use another approach or install 'rspec-activemodel-mocks' gem than just report NoMethodError as it does currently.
Something similar in nature to this message I found via Stackoverflow:
"mock_model and stub_model are removed since version 3.0.0 of rspec-rails. rspec mocks are externalized in an another gem rspec-activemodel-mocks . You should include it in your Gemfile and try it.".
ref: http://stackoverflow.com/questions/24059805/rspec-view-undefined-method-stub-model

Searching around revealed that these methods were deprecated in rspec 3.0.

No, they were deprecated in 2.99 and removed in 3.0.
Did you follow the 2.x -> 2.99 -> 3.x upgrade process? That provides detailed deprecation warnings about every single API that has a breaking change in 3.0.  Our upgrade guide provides detailed step-by-step instructions for the upgrade process.
We specifically don't want to continue providing the APIs for 2.99 deprecations in 3.x as that would obligate us to continue to support the deprecated APIs until RSpec 4 and the entire reason we put a ton of effort into creating 2.99 was to avoid that.


add authorization mode

I think I'd prefer we rename auth to authentication.  I know it's a breaking change, but RKE is still really in a "beta" status.


Adding Insights for Phishing Simulations

Adding Cofense insight
Adding tag "Phishing simulation"
Adding hoxhunt
Adding KnowBe4
Fixing name


LOC: Japanese: Translation change for "Flip this view to [[0]] pane"

Current  translation for "Flip" sounds a little awkward.
EN: Flip this view to [[0]] pane
Current JP: [[0]] ペインにこのビューを反転
New JP: このビューを [[0]] ペインにめくる

Translation fixed.

Tagging @vaamica and @walfgithub

Upload the screenshot with build 1.7.0-16733, please verify!

String not fixed on screenshot, correct in TM database. Please advise.

Upload the screenshot with build 1.7.0-16739, please verify!

Issue still not fixed.

Checked this issue on 1.6 refresh build 1.6.0-16692, It has been fixed.

Confirmed as fixed.

Confirmed as fixed.

Closed.


feat: add semantic release, lint and small fix

Signed-off-by: Nekotoxin<EMAIL_ADDRESS>

@leeqvip plz review


ENH: group_by for epochs.plot()

Any reason not to have it (other than no time to implement it yet)? It might be nice to have like we do for raw.plot.

+1 for nice to have

Can you please explain what you intend to perform (objective), I plan on trying it.
Or you can give some reference as well.

okay perhaps not as easy as I thought @thesujitroy.
@larsoner would you recommend this as a starter issue?

No it will probably involve too much refactoring

@larsoner Thank you. I am looking into it.
@jasmainak Do you want to look into something else?

yeah, pick one of the issues labeled as easy.


insert with unnest drops invalid rows but documentation doesn't mention this in the how-to guide

Documentation feedback

Page title: Insert methods
Page URL: https://crate.io/docs/crate/howtos/en/latest/performance/inserts/methods.html
Source: https://github.com/crate/crate-howtos/blob/master/docs/performance/inserts/methods.rst

Inserts done with unnest are one of crates recommended ways of handling big inserts. If only looking at this entry the biggest drawback of unnest is not mentioned and can be unexpected.
When doing insert with unnest, rows that produces errors when inserted will be dropped and there is no error indicating that an error happened see python example at the end. This is documented here:
https://crate.io/docs/crate/reference/en/4.1/sql/statements/insert.html?highlight=unnest#insert-from-dynamic-queries-constraints
I would expect that this is also mentioned (or linked) in the how-to guides.
conn = client.connect('localhost:4200')
cursor = conn.cursor()

cursor.execute("CREATE TABLE IF NOT EXISTS untest (payload OBJECT(DYNAMIC));")

stmt = "INSERT INTO untest (payload) (SELECT col1 FROM UNNEST(?));"
payload = [
    {"info": "this is a valid object"},
    {"": "this is a invalid object"},
    {"info": "this is another valid object"}
]

try:
    cursor.execute(stmt, (payload,))
except Exception as e:
    print(f"encountered exception: {e}")

using cursor.rowcount one could implement error handling themself but as this is not mentioned in the how-to guide i wouldn't expect it to be necessary.

thank you for the excellent suggestion, @kamejosh!


Particle drastically reduces FPS

Sometimes at random flux generates hardly visible white swirly particles that do damage to entities touching it (I would like to upload a screenshot but sadly that doesn't seem to work, so here's a dropbox link: screenshot ).
For whatever reason this particle absolutely kills my game.
My Laptop isn't the best and I usually only have about 20 FPS but this particle lets them drop to about 4 to 6.
Beta 24.
Edit:
Just noticed that the particles actually are a rift I simply can't see.
So rifts cause my FPS to drastically drop and I can't see rifts ...

Remove Optifine and see if it makes a difference. TC6 and Optifine do not always play nice with each other, this is known.

I'm not sure that particle you see is from TC - flux particles are purple clouds and they are purely cosmetic - they do not do damage to entities.

You can also try to disable shaders in the TC config and see if that improves your FPS.


Clean up the API of SourceGenFromSpec.generateSourceInDir

The signature and semantics of SourceGenFromSpec.generateSourceInDir() are a bit strange, I think it could be improved.
Some things I find strange:

The name of the method. I read generateSourceInDir() as "generate source, but do it in a specific dir". To do things in a directory, I would assume, means do it with a process that has it's current working directory (CWD) set to some specific directory. This does not make sense in this context.
The temporary directory to use for output seems to me like an implementation detail, and could be hidden away from the user.
RuntimeExceptions are not checked and don't need to be declared in the throws statement
The docs doesn't specify what the format of the output is, only that it will be written to a path

Solved at https://github.com/goldmansachs/crdtools/pull/21


Don't show anything for collapsed lines

If resource use is within a method (or anything) that is collapsed, do not attempt to add the adornment.

Will be in the eventual 1.3 release. Available in the CI build now.