fix(📦): skip co-authors selection with 0 options

SCOPE: Modules
WHY: No need to show it.
No field is built if the list of co-authors if empty.
🦔

Task linked: CU-8694521t6 bug: co-authors field is shown even with 0 options


Remove over-constraining assertion

Fixes #134

Codecov Report

Merging #135 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   93.90%   93.91%
=======================================
  Files          91       91
  Lines        7927     7937   +10
=======================================
+ Hits         7444     7454   +10
  Misses        483      483

Impacted Files
Coverage Δ

immer/detail/hamts/node.hpp
96.76% <ø> (-0.01%)
:arrow_down:

test/map/generic.ipp
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34af76...e765af2. Read the comment docs.


chore(main): release 0.0.33

:robot: I have created a release beep boop
0.0.33 (2024-12-08)
Build System

update @stone-js/core dependency (34374e6)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.0.33
:sunflower:


refactor Refactor S3 file writer's duplicate code into common function

Proposed changes

There were some duplicate code in S3 File writer, which might be error-prone, this pr tries to reduce code.

run buildall

run cloud_p0


feat: add unit tests for the template outcome

This issue is quite complicated to be addressed now
Need further investigation

[ ] Verify
[ ] Templates Testing Tooling
[ ] Diffengine


What should snapshot.engine return?

Alright, so while trying to continue simulations that crashed due to #892, I ran into some behavior that I wondered if it is intentional:
snapshot.engine gives back the engine in it's current state, without updating it (this can be an uninitialized engine after loading a ToyEngine and led to my position modifier crashing out (as it asks for the current potential energy of the engine)
Without thinking to much about it, I expected snapshot.engine to return engine with engine.current_snapshot = snapshot. There is probably some reason for the current behavior but I could not really think of one.
So therefor my question: should snapshot.engine update engine.current_snapshot before returning or should it just return the enigne in it's current state (even if it is an uninitialized ToyEngine)?

No, the expectation is that snapshot.engine has no side-effect on the engine itself. In most cases, snapshot.engine will be the same object in memory that is used elsewhere. Adding side-effects could therefore create confusion elsewhere. Keep in mind that snapshot.engine can be used as a trick to get to properties that are calculated by the engine. So you could probably construct a scenario using snapshot.engine in a CV that defines a volume in a sequential ensemble, where changing engine.current_snapshot would lead to you continuing dynamics from the wrong snapshot!
This is why the OpenMM instantaneous temperature calculation uses the old_snap variable to preserve the engine's state:
https://github.com/openpathsampling/openpathsampling/blob/26997b43745e197abb91cdb3f51916da0cfc1774/openpathsampling/engines/openmm/features/instantaneous_temperature.py#L27-L48
In general, I wouldn't recommend thinking of "the current potential energy of the engine" as having meaning. It should be "the potential energy of the engine's current snapshot." For OpenMM, there's a guarantee that the current snapshot returns the same object in memory if you ask for it more than once in a row. (If toy engine doesn't do that, it should; I would have to check the code.) That means that using it in a function is almost as fast as acting on the internally-stored data, and a lot more future-proofed.

thanks for the clarification. I see how changing the state of the engine can lead to undefined behavior.

In general, I wouldn't recommend thinking of "the current potential energy of the engine" as having meaning. It should be "the potential energy of the engine's current snapshot."

I think I got thrown for a loop where PES.V() works on an engine instead of a snapshot.
I will update my modifier to use a similar codeblock as you linked.
Closing, thank you for the fast response!

I think I got thrown for a loop where PES.V() works on an engine instead of a snapshot.

I can understand that. Somewhere in the toy engine is a comment about how I should create a separate "system" class for the state information (internal representation of the snapshot), rather than keeping that information in the engine object. I didn't do that when first developing the toy engine out of laziness (or too much other code to write), but this is exactly why I should have.


Invalid content /en/testnets/cardano/get-started/installing-and-running-the-cardano-node/building-the-node-from-source/

Where does the issue occur?
Short answer, here: https://developers.cardano.org/en/testnets/cardano/get-started/installing-and-running-the-cardano-node/building-the-node-from-source/
Long answer, with user flow: When on main page cardano.org I was one visitor following that track:

Developers (menu) > Stake Pool Operation : https://cardano.org/stake-pool-operation/
Mid nav bar > Set up Stake Pool: https://cardano.org/stake-pool-operation#set-up-stake-pool
"Interested in developing on the Cardano platform or running a stake pool?" clicked on the button Learn how > (new tab opens) https://developers.cardano.org/
Use the button on bottom of first page Find out more: https://developers.cardano.org/en/testnets/cardano/overview/
THen using the menu on side bar (left) to get on the install from source guide which is the link mentioned all above: "Getting Started" > "Installing and running a... node..." > "... form source": https://developers.cardano.org/en/testnets/cardano/get-started/installing-and-running-the-cardano-node/

Describe the issue
This installation from source there will not work, there are critical missing information about the necessary custom installation of libsodium (https://github.com/input-output-hk/libsodium) that includes verifiable random functions (VRF) not (yet :) ) in upstream.
As well as how to set cabal to use that externally installed library (libsodium).
Expected changes
Redirect to the correct documentation, which is git tracked and coherent with the node sources:
https://docs.cardano.org/projects/cardano-node/en/latest/getting-started/install.html
Additional context
I found out through the forum posts this happened to a lot of people and the developers.cardano.org might be misleading a lot of people, while docs.cardano.org should be the reference.
This would certainly solve following open issues:
#382
#338
#219
Unfortunately users there did not all mention the exact information page they tried to follow installation procedure but I can surely suppose it was on developers.cardano.org .

@nahern , @redsharpbyte is right. instructions on https://developers.cardano.org/en/testnets/cardano/get-started/installing-and-running-the-cardano-node/building-the-node-from-source/ are outdated.
We should pick instructions from https://docs.cardano.org/projects/cardano-node/en/latest/getting-started/install.html
We can close this issue once it is on your backlog.

resolved by https://github.com/cardano-foundation/testnets-cardano-org/pull/463


Client rejects server request when using "CA constraint" and "trust anchor" assertion certificate usage

If fact this affects all certificate usage case where Server Public Key (0/?/4) resource does not contain the end entity certificate.
Meaning it works only for  Domain issued certificate(3) and  Service certificate constraint (1) certificate usage.
For CA constraint (0) and trust anchor assertion (2) usage, servers will receive  :  error 500 INTERNAL_SERVER_ERROR unknown server for any request sent.
(Issue discovered at https://github.com/eclipse/leshan/pull/983#issuecomment-809246754)

What happens ?
The identity class aims to abstract identity of a foreign peer.
For PSK this is the PSK identity.
For RPK this is the Raw Public key.
For X509 that was the CN value of the certificate.
This identity is created from different way.
From data of the DTLS Layer to identify current foreign peer. (see EndpointContextUtil )
From Security Object to know the expected identity for a given server. (see CaliforniumEndpointsManager)
Client checks current identity with expected one to answer to a server : see DefaultRegistrationEngine.getServer()
For expected X509 Identity, we create from CN value of Server Public Key (0/?/4) resource.
That is OK when this resource contains the the server certificate (the end entity certificate).
But since LWM2M v1.1 with  CA constraint (0) and trust anchor assertion (2)  certificate usage,  Server Public Key (0/?/4) does not contains the server certificate but another one from the whole certchain.
So how to solve this :
1) Remove the identity check by an  IP address check
This is probably the simple way to fix the issue at first sight but with more consequence when look at it deeper.
In term of security, I'm not sure if this OK, I feel that with multi server support this could be an issue.
Even if this is OK, this means that we still create unusable identity for X509 for those specific use case which is not so good...
If we decide to remove identity check that means that the security Identity abstraction should maybe be removed or replaced by something else. (As we create 1 coap endpoint by server maybe we can use the coap endpoint as identifier :thinking:)
2) Find a better way than using Server Public Key (0/?/4) resource to create the expected CN.
The other solution which could be less impacting would be to create the right expected Identity.
But not sure how ? :thinking:
Maybe we can find the right CN (CN is maybe not the appropriate term) by using domain name or IP address in LWM2M Server URI (0/?/0)  or resource SNI (0/?/14) ?

About 1) I believe you cannot just check peer address -- you also need to check port.
So connection mapping is combination of peer address:port <-> local address:port.
I believe this is needed for supporting devices behind NAT that are in different ports (in NAT gw).

When DTLS is active on connection it remembers its communication partner -- if if there is a breakup in communication then we do not get COAP messages at all in upper layers -- thus we do not get called at all.
If this is combined with port mapping shouldn't it solve the problem?

From client point of view the picture is a bit cleaner as it has very few communication partners for CoAP seession. Often just one (or two when bootstrapping). So as long as we are sure that we can safely communicate we should be fine?

About 2)

2) Find a better way than using Server Public Key (0/?/4) resource to create the expected CN.
The other solution which could be less impacting would be to create the right expected Identity.
But not sure how ?
Maybe we can find the right CN (CN is maybe not the appropriate term) by using domain name or IP address in LWM2M Server URI (0/?/0) or resource SNI (0/?/14) ?

Also remember that Subject Alternative Names should be used in normal configurations and in theory one could have either IPv4 or IPv6 addresses also defined. I would recommend to try to avoid parsing X509Certificate objects for every UDP frame as that is going to slow down the system -- doing that once during DTLS session setup is OK.
Please note that we do have DNS and IP Address information available in InetSocketAddress which we can get from  Identity.getPeerAddress().

About 1) I believe you cannot just check peer address -- you also need to check port.

We agree. That was I have in mind.

When DTLS is active on connection it remembers its communication partner -- if there is a breakup in communication then we do not get CoAP messages at all in upper protocol layers -- thus we do not get called at all.
If this is combined with port mapping shouldn't it solve the problem?

As long as we support only 1 server at the time it's OK. (BS server and DM server is never active at same time)
But the LWM2M specification says that you could have several LWM2M server and I don't want to choose a design which closes this door.
In the case of several server, I can imagine a use case where this check is not enough:

you have 2 registered server , one with PSK and other with X509 with different rights (ACL)
you have 2  active CoAP endpoint .(1 for each servers)
The way it is coded, you can be sure that all traffic which is received to one endpoint come from the same server. but in DefaultRegistrationEngine.getServer() we don't check from which endpoint we comes.

So if PSK is compromised (or just if owner wih PSK server is  malicious), it can used its credentials and spoof the X509 ipaddress-port to send request like if it was the X509 server.

The other issue with solution 1) is that even if this fix this bug the current Identity for X509 still does not make sense and so we stay with a bad design ...  :thinking:

About 2) the more I thought about it the less I can imagine it could work.

I need to think more about it ...
Ideas I have in mind is :

using coap client endpoint (but not so good in term of separation of concern/layer abstraction)
OR maybe playing with californium ApplicationLevelInfoSupplier and set here a Server Short ID

#992 aims to fix the issue.

Some more explanation about #992.
To solve this problem, there was 4 different ideas :
[1] Replace the identity check by an IP address:port check
[2] Find a better way than using Server Public Key (0/?/4) resource to create the expected CN.
[3] Using  client coap endpoint  to identity the server
[4] Using ApplicationLevelInfoSupplier + use short server ID as identifier.
My understanding :
[1] it seems it doesn't work with multi server ( https://github.com/eclipse/leshan/issues/992#issuecomment-810094047)
[2] it seems there is no good way to do that (https://github.com/eclipse/leshan/issues/992#issuecomment-809724042)
[4] it could be the right way but it implies some redesign of Identity class which is largely used at Server side too. So I would prefer to have the big picture in mind before to go in this way.
So #992 is based on [3] which is maybe not so clean in term of separation of concern/layer abstraction but it should work because :
For DTLS we can rely on coap endpoint used because :

we use 1 endpoint by server
DTLS connector is configured in a way it accept only the expected server.
For UDP, checking coap endpoint is not enough we need to check ip address:port too (even if we don't care as this is an unsecured way anyway)

(I'm curious to see how we will deal with Idenity at server side for handling client using x509 and if current assertion to rely on certificate CN will be enough :thinking:)


Update how to use video

How to use video is updated.

Thank you for your attention to this matter!


Versioning

https://github.com/creek-service/creek-test/issues/30
Reviewer checklist

[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage remained the same at 99.615% when pulling 65bae6ba3cb7e33fe7740ad5652906b273ecd86b on version5 into e2c63cb6b3997708ab69349e715fa76845122aff on main.


node-gyp configure -> fail on Windows 7 x64

I don't know why.
Can you help me.
C:\Users\fperreault\Desktop\hid>node-gyp configure
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| win32 | x64
gyp ERR! configure error
gyp ERR! stack Error: Command failed:   File "<string>", line 1
gyp ERR! stack     import platform; print platform.python_version();
gyp ERR! stack                                   ^
gyp ERR! stack SyntaxError: invalid syntax
gyp ERR! stack
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:540:15)
gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:96:17)
gyp ERR! stack     at maybeClose (child_process.js:638:16)
gyp ERR! stack     at Process._handle.onexit (child_process.js:680:5)
gyp ERR! System Windows_NT 6.1.7601
gyp ERR! command "node" "C:\\Users\\fperreault\\AppData\\Roaming\\npm\\node_modu
les\\node-gyp\\bin\\node-gyp.js" "configure"
gyp ERR! cwd C:\Users\fperreault\Desktop\hid
gyp ERR! node -v v0.8.12
gyp ERR! node-gyp -v v0.7.1
gyp ERR! not ok

Python 2.7, not Python 2.6.
I can confirm node-gyp rebuild did not work on npm install java (https://github.com/joeferner/node-java) with python 2.6.6 for 'node 4.1.1`

node-gyp rebuild does not work for me too on node-java.
I am using Python 2.7.6.

node-gyp rebuild is not working for node-java.
I am using Python 2.7.8

have you checked you GCC version? It needs to be above 4.8, is what I remember.

@WarFox Is there a fix for this issue? I'm using Python 2.7.15 and facing the same issue.


[PORT] Added cancellation token to ContinueConversationAsync on Facebook adapter

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/3379

Fixes #3370
Also updates use of cancellation tokens in adapters for consistency.
Changed projects

Adapters

n/a


When using the make command and passing command line parameters, wsl will not choose to recompile certain files

Windows Version
10.0.22621.3296
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-2
Distro Version
Ubuntu-22.04
Other Software
No response
Repro Steps
1.Normal test situation
This is the directory structure of the project：

With make clean-all abstract-machine ahead of time it behaves correctly

It will recompile the c file under abstract-machine,The command line parameter passed this time is mainargs=uuusss

The results are as expected

2.Abnormal test situations
When I tested again and passed different mainargs parameters（mainargs=uuusssooo）, it did not recompile the trim.c file.

This is the result of the abnormal test. This is another result. Although it is the same as the above test result, there is another point to note. The compilation time of my statistics is the same

3. summary
When I type the make command in wsl and use it with the mainargs parameter to the project's c-file, I find that sometimes passing a different parameter doesn't cause that c-file that needs the command line parameter to recompile, when I test it under the VM, it does recompile that c-file。
There shouldn't be anything wrong with the makefile file, because I tested this situation under a virtual machine and it was fine
Expected Behavior
I'd like to see 2 different make commands (meaning carrying different mainargs arguments) that give results that print different mainargs arguments, rather than using the same ones as last time.
Actual Behavior
2.Abnormal test situations
When I tested again and passed different mainargs parameters（mainargs=uuusssooo）, it did not recompile the trim.c file.

This is the result of the abnormal test. This is another result. Although it is the same as the above test result, there is another point to note. The compilation time of my statistics is the same

Diagnostic Logs
No response

/question

Closing since there's no repro instructions and the issue doesn't come from WSL.
For context: WSL doesn't control make's behavior, but only runs it.


Bug 1001009 - Very long button text

Replaced the button with text with a link.

Thanks for getting this far, good work!

Giving it try again. Thanks for you valuable comments :)

You can keep the pull request open; if you push a new commit to the same branch in your fork, it will automatically update.
Thanks for the contribution!


separate constant value and model of database

separate constant value and model of database

too many changes in this MR, will separate it into many small MR.


Bind Ctrl-h to Colour Picker. Fixes #2

Description
No new dependencies. tkinter.colorchooser is now used (instead of merely imported).
There is the binding to the menu item (albeit with no use of the return value) and a binding to Ctrl+h, which can be used to modify the settings.json.
I noticed, that the last character gets cut off. My tkinter knowledge isn't good enough to tell, what I'm doing wrong here.
Also, for some reason, the first character before the selection is deleted.
Fixes #2
Replace issue_no with the issue number which is fixed in this PR
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes
[ ] No

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] My change works and is relatively clean.
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas (I adjusted to the previous code-style, i.e no comments)

On a side note, Hacktoberfest UI is telling me:

Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate. Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.

Would be great if you could handle that before merging :-)

@Ryuno-Ki Woops, sorry first time maintaining something on github/participating in hacktoberfest. I added the label and the PR looks good.


Description attribute remote prefix confusion on entity name with two words

Hi Elvis,
From the documentation:

Reserved attributes should be prefixed with the entityName (type becomes userType, description becomes userDescription and so on).

What if we have entity with name such as WeatherAlert. I would assume that description attribute is then weatherAlertDescription. Unfortunately, this is not the case - the mapping doesn't work. I realized that I'm making a mistake just after looking at the source code here.  For now I am using weatheralertDescription as attribute name.

@markosankovic this sucks! Thanks a lot for reporting it. I'll look into it. :heart:

Should be working fine.


SCT-1394 Add bitscore to output

Codecov Report

Merging #23 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master     #23      +/-   ##
===========================================
- Coverage      5.01%   4.89%   -0.12%
  Complexity       25      25
===========================================
  Files            34      34
  Lines           978    1002      +24
  Branches        197     199       +2
===========================================
  Hits             49      49
- Misses          927     951      +24
  Partials          2       2


Not working

Hello,
Webcam.setDriver(new NativeWebcamDriver());
List webcams = Webcam.getWebcams();
for (Webcam webcam : webcams) {
System.out.println(webcam.getName());
}
System.out.println("here 1");
System.out.println("here 2");
Webcam webcam = Webcam.getWebcams().get(0);
    System.out.println("here 3");

    System.out.println("here 4");
    webcam.open();
    System.out.println("here 5");

unfortunately it does not even print out the webcams i have. When not using the driver it works. Really looking forward to an answer.

i included the jars the dll since i am on windows.


Use 16-bit random value in validator filter

See: https://docs.google.com/spreadsheets/d/18VeMVLO1jbP8xHkT4faGEb5SyrWQhQLcU-BtsL9pTss
This fixes an oversight in compute_proposer_index and get_next_sync_committee_indices.
Currently, we use an 8-bit random byte to perform an effective balance filter. This was used to penalize validators with effective balances less than 32 ETH. But now that we have raised the maximum effective balance, this mechanism plays a more important role in validator selection.
One might expect a validator with a greater effective balance to have a greater chance of being selected as proposer or sync committee participant, but no. This is because the random byte can only represent 256 "buckets" of effective balance. So for example, currently, a validator with 33 ETH has the same likelihood of being selected as a validator with 40 ETH, because these validators are in the same bucket.
The solution is to use a bigger random value to allow more precision. I propose we use a 16-bit random value instead which provides enough precision (~65k buckets). Originally I wanted to use 32-bit values but it would require more complex changes because there would be an integer overflow when multiplying the max values together.

The change looks good and makes sense to me! 👍
I think we need more tests to ensure implementation compliance

Sounds logical... good writeup

I think we need more tests to ensure implementation compliance

It shouldn't be necessary to add extra tests. There should be several sanity tests which will check this.
For example, test_proposer_after_inactive_index and test_high_proposer_index would most likely error if get_beacon_proposer_index were implemented incorrectly.

https://github.com/ethereum/consensus-specs/blob/554189d105a8f4e0030a1293d73b370adb581e46/tests/core/pyspec/eth2spec/test/phase0/sanity/test_blocks.py#L669-L716

we should verify there is some difference in test output

Good call. I have a simple difference. In test_high_proposer_index, the state's slot will be different. This is because the following check will require more iterations.
https://github.com/ethereum/consensus-specs/blob/98cf01d22dbb1ce2deada5dd11a5d029e54cf6a4/tests/core/pyspec/eth2spec/test/phase0/sanity/test_blocks.py#L706-L708
See slot: 17 in the first test run (on dev) and slot: 20 on the second one (on this branch):


🚀 Roadmap

Description
This is a tentative roadmap, I will update it as things evolve. Some things might be discarded, others might be added later. I didn't want to make it fully public as it could raise expectations, but it seems it would be more beneficial for the community to know all the ideas and objectives.
Work on this is alternated (and sometimes mixed) with work on Typer, SQLModel, Asyncer, and others.
Answering questions, issues, and PRs is also intermixed with this, but as in some cases one of these features would solve several issues or questions, or potentially solve something done by one or more PRs, in many cases I focus on this a bit more than on answering specific issues, questions, PRs.
Maintenance
The word "maintenance" or "maintainer" doesn't have a very strict definition, and it probably varies a lot from perspective.
A lot of the work related to maintaining FastAPI is done by contributors by answering questions, reviewing PRs, etc.
You can help me ensure each existing PR is in shape (has tests, solves the problem, etc.). Make sure you filter out the translation PRs (most of them) unless you speak the language and can review them.
Security
When there are security issues, those are handled with the highest priority. Those are normally not handled in issues and PRs but in emails, it's not public until the security disclosure is made, in most cases (always, up to now) with the version that fixes them.
Roadmap
Now, here's the current high-level tentative roadmap:

[ ] Support for the latest SQLAlchemy before 2.0.
[ ] Support for SQLAlchemy 2.0.
[ ] Support for Pydantic 2.0.
[ ] Async tools and docs.
[ ] Integrated migrations (using Alembic).
[ ] Integrated CLI for migrations (using Typer).

All this is intermixed with reviews for PRs, issues, and discussions.

This is great news! So excited to start using these new features. I'm curious how you are planning in integrating Alembic?

Excited for these features!

Is the goal to support both Pydantic v1 and v2 and SQL Alchemy v1 and v2? Or only v1+v1 and v2+v2? The combination of both will become difficult.

@AntonDeMeester @tiangolo Only support SQLAlchemy  v1.4 with 2.0-style and v2.0?

Is there a branch of this project or a starter template for using FastAPI latest + SQLAlchemy 2 + Pydantic 2?
I'm starting a new project with FastAPI latest + SQLAlchemy 2 and I'm not sure what would be the right way to set it up? Should I just avoid SQLModel altogether?

@hyperknot Try https://github.com/tiangolo/sqlmodel/pull/632

Yes!

We are using fast API with SQL Model for our microservices. And planning to add Llama index which needs SQLAlchemy above 1.4.41.  But does not support by current SQL Model versions (required: >=1.4.17,<=1.4.41).
@tiangolo Need your kind help.

Are the items on the roadmaps features you plan to implement yourself, or are they open for PRs?
In any case, this is really exciting! I can't wait to be able to use a Pydantic v2 + SQLModel (with all the great SQLAlchemy 2 features) + FastAPI stack!

Fully agree.  Have other stuff already upgraded to pydantic 2.x.x and SqlAlchemy 2.x.x and cannot introduce SQLModel to the mix.
From: Matthieu LAURENT @.>
Sent: Tuesday, 24 October 2023 15:21
To: tiangolo/sqlmodel @.>
Cc: Subscribed @.***>
Subject: Re: [tiangolo/sqlmodel] 🚀 Roadmap (Issue #654)
Are the items on the roadmaps features you plan to implement yourself, or are they open for PRs?
In any case, this is really exciting! I can't wait to be able to use a Pydantic v2 + SQLModel (with all the great SQLAlchemy 2 features) + FastAPI stack!
—
Reply to this email directly, view it on GitHubhttps://github.com/tiangolo/sqlmodel/issues/654#issuecomment-1777192911, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AALUWECMEPO3K523RRZFZ3DYA66DLAVCNFSM6AAAAAA5TK2VBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZXGE4TEOJRGE.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>

Take a look at this.

Since the dev dependency, FastAPI, no longer supports Python 3.7 from version 0.104.0 onwards, will SQLModel also need to drop support for Python 3.7 in the future? If so, it would likely be a massive undertaking. It should be included in the roadmap together.

When dealing with relational models,sqlalchemy only needs to define relationships on one side,sqlmodel needs to define relationships on both sides, and the complexity of the model class is very difficult to deal with. The screen full of relationships makes my brain a little hot, especially the many-to-many relationships, even if the model class is written according to the documentation, it becomes extremely complex.

When dealing with relational models,sqlalchemy only needs to define relationships on one side,sqlmodel needs to define relationships on both sides, and the complexity of the model class is very difficult to deal with. The screen full of relationships makes my brain a little hot, especially the many-to-many relationships, even if the model class is written according to the documentation, it becomes extremely complex.

I am looking forward for SQLAlchemy v2 support. This should enable ClickHouse columnar storage.

Sorry if this is adding noise – just noticing the next items in the roadmap are somewhat achieved in #632 (open since August). Any chance we could understand the project's thinking wrt when something like that might be merged or reworked?

I'm curious what are the tricky parts in SQLAkchemy and pydantic 2.0.0 version for this library.

[x] Support for SQLAlchemy 2.0.

Now Ready for Pydantic 2.0  🚀

Since the dev dependency, FastAPI, no longer supports Python 3.7 from version 0.104.0 onwards, will SQLModel also need to drop support for Python 3.7 in the future? If so, it would likely be a massive undertaking. It should be included in the roadmap together.

Pydantic and SQLAlchemy have already dropped support for Python 3.7.
https://github.com/pydantic/pydantic/commit/0564c0d2c90c8dd98ac7cf88b7b6ab68fdef256c
https://github.com/sqlalchemy/sqlalchemy/commit/4da59c6f534371d8c76cd728e8a459018e9112b6
Additionally, Python 3.7 reached its End of Life (EOL) a few months ago, so it's time to say goodbye.
https://devguide.python.org/versions/

@tiangolo Could you please provide any updates on this? I've begun a new FastAPI project, and I'm uncertain whether I should build upon the SQLModel project or stay with SQLAlchemy. What are your long term plans with this project?

@cay89 This and the cookiecutter template are under development; from @tjeaneric, it looks like the sqlalchemy and pydantic support is done, but the alembic support hasn't been released yet.
You should be able to use sqlmodel== 0.0.14 and manually generate migrations for your fastapi project: alembic init --template async alembic. You will need to manually edit the generated alembic.ini and alembic/env.py to use sqlmodel's metadata object. This was possible in 0.0.8 before the sqlalchemy relationship support broke in ~sqlalchemy==1.4.x. Things are still sort of in limbo for official design patterns when considering the intersection of fastapi, sqlalchemy, pydantic, and alembic.

Are we going to get an update on the Async docs ?

Hello team, Amazing work, What is the ETA on Async milestone? Can we bump it up before pydantic? @tiangolo

@manish181192 I haven't seen an "ETA"; some of the remaining work is in the PRs:

https://github.com/tiangolo/sqlmodel/pull/689
https://github.com/tiangolo/sqlmodel/pull/512
https://github.com/tiangolo/sqlmodel/pull/635

Hi @tiangolo, are #689 and #635 ready to be merged?

I just came across #63 and I was surprised this would not work out of the box, is this kind of behaviour considered at any stage on the roadmap?

Hi @tiangolo, are https://github.com/tiangolo/sqlmodel/pull/689 and https://github.com/tiangolo/sqlmodel/pull/635 ready to be merged?

Integrated migrations (using Alembic).

use Index=True does not work in alembic😭

@tiangolo Any update for the roadmap?

Hey @tiangolo! Thanks again for your awesome work :).
Do you have any ideas on when you could have something done for

Integrated migrations (using Alembic).

?
I guess I am not alone waiting for this marvelous feature :).
All the best!!

Hey @tiangolo! Thanks again for your awesome work :).
Do you have any ideas on when you could have something done for

Integrated migrations (using Alembic).

?
I guess I am not alone waiting for this marvelous feature :).
All the best!!

it's already working

@tepelbaum I know it's two months later, but I wound up having to work on a minimal implementation, so I published it to github. I'd actually be interested to keep maintaining this example or something like it, if it's helpful.


unauthorized

I'm using this tool since a couple of years and it's excellent; anyway it's a couple of days that I am experiencing this problem (unauthorized error). I tried it from different places and with different ip addresses but still not solving the problem.
Might it be due to changes on Yahoo's policies? thanks

Also ran into this yesterday and today (3/9/20 - 3/10/20).  Using yqdownload (as recommended), here are my tests spread over two days:
3/9/20
9:20 AM PST
yqdownload -t MSFT -f test.txt -e 2020-02-28 -b 2020-01-01 -v 5
Downloading MSFT ...
 MSFT: Download unsuccessful!
12:15 PM PST
yqdownload -t MSFT -f test.txt -e 2020-02-28 -b 2020-01-01 -v 5
Downloading MSFT ...
 MSFT: Download unsuccessful!
3/10/20
12:43 PM PST
yqdownload -t MSFT -f test.txt -e 2020-02-28 -b 2020-01-01 -v 5
Downloading MSFT ...
 MSFT: Download unsuccessful!
I believe the authorization with Yahoo has changed.  BTW documentation on the beginning date needs updating to -b.  Thanks,
JJ

It looks like all download has stopped working since March 6, 2020.
I will take a look when I have some time. It may take a while as I have my day job that I need to take care of.

It has been fixed. For some reason, Yahoo does not respond to the original user agent string I used. Apparent this has starting to occur in the last couple of days. It has been fixed now in v0.3.1.
Please update to the latest version by
pip install --update yahoo-quote-download


I want disable cloudera navigator

Hi, my name is chu
A navigator_client error occurs when looking up a table in metastore.
so, i want disable cloudera navigator.
pls, give me a tip about navigator

neccessary logs
[18/Jun/2021 18:46:54 +0900] navigator_client ERROR    Failed to find entity: HTTPConnectionPool(host='localhost', port=7187): Max retries exceeded with url: /api/v9/entities?query=%28type%3ATABLE+OR+type%3AVIEW%29+AND+%28sourceType%3AHIVE%29AND%28originalName%3Acol2_tast%29AND%28deleted%3Afalse%29AND%28parentPath%3A%5C%2Fdefault%29&offset=0&limit=2 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f52ec73e668>: Failed to establish a new connection: [Errno 111] Connection refused',))

screenshot of the issue

the editor component you are using and so
apps\metastore

Hello, my name is chu
I found some information about navigator_client in metadata.
if you open the page ("http://ip:port/hue/metastore/table/default/col_test1?source_type=hive")

Call "metadata/urls.py" from front-end to back-end.
At this time, urls.py calls

databae(1 time) -> catalog_find_entity("metadata/catalog_api.py"."find_entity")
table(2 times) -> search_entities("metadata/catalog_api.py"."search_entities")
columns(2 times) -> search_entities("metadata/catalog_api.py"."find_entity")
and each method call "metadata/base_py"."get_api"
finally If the interface type is navigator, "metadata/catalog/navigator_client" is called.

so, If the interface is a navigator, each method of catalog_api.py is disabled.
There is absolutely no error, but it is questionable whether this is the right way to handle it
and I'm also curious where you call "metadata/urls.py".


Present the typography proposal with Fusion

Already coordinate with Fusion team and we will have a meeting on Friday (April 26) at 12:00 🎉

We had a meeting with Amplify team last Friday (April 19) where we presented:
1. Fonts: Inter + Equinor. We explained the current proposal for mobile apps and the reasons for it, and a potential usage on web apps letting them to analyze the case and giving us feedback about it in the next meeting.
2. Alignment: Optical alignment, Icons and Baseline grid. Explanation of current concepts to understand in order to explain the new proposal for typography and spacing.
3. Typography and spacing foundations: applied to Amplify. Showed them examples on how the proposal would look in their products and asked for feedback.
4. Density: Spacious, Comfortable and Compact. Showed them how density would look in their products and received feedback on how valuable is for them.
5. Roadmap: Expectations aligned and processes communicated by sharing our roadmap with them.
6. Final note: Comparison components between design systems. A quick update about the comparison file and future expectations for better collaboration.
Figma file here.
Action points:
We will discuss more in detail our proposal following their density feedback, which the needs are totally opposite to what Amplify teams needs. So we will need to build a proposal that covers both scenarios.

Exploration about density: following their feedback it seems that in some cases is necessary to apply the density only to spacing and in other cases to spacing and typography. Decisions about it to present in the meeting.
Definitions for spacing and typography Container level.
Exploration about density: following their feedback it seems that in some cases is necessary to apply the density only to spacing and in other cases to spacing and typography. Decisions about it to present in the meeting.
Fusion team members will send us Figma files with products or views they think are relevant to test. Those will be presented on the next meeting.


pluginZod: format generated code

What is the problem this feature would solve?
Currently, the generated z.object is written in one line. Please format the generated z.object to make it more readable by formatting it as follows:
// each prop will be in a new line
 export const userSchema = z.object({
    "id": z.string().optional(),
    "username": z.string().regex(new RegExp("\S")).min(2).max(20).describe("The username"),
    "email": z.string().describe("The email"),
..
})

By the way, other files generated by Kubb are also preformatted to make them more readable. It would be nice to preformat Zod files as well.
External documents/projects?
No response
What is the feature you are proposing to solve the problem?
No response
What alternatives have you considered?
No response

@nimo23 v3.3.0 will introduce a better internal formatter that will resolve your issue :)


⚠ ClamAV has degraded performance

In 0920e77, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 84 ms

Resolved: ClamAV performance has improved in 2e491cb.


⚠ Jenkins Plugins Artifactory has degraded performance

In 02eaf3e, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1078 ms

Resolved: Jenkins Plugins Artifactory performance has improved in bd7b584 after 14 minutes.


Widget closing by mistake

It seems like if the user clicks outside of the foreground widget window (for example anywhere else in the main webpage window), the widget closes (or maybe is just backgrounded?). This could confuse/discourage users-- fix it so the widget window remains in the foreground until the form is submitted?

This is very much intentional behavior and is typical for modals, should it be removed?

I agree with @mikemorris. Being able to click outside of a modal to close is an established web user experience and would likely cause user frustration if not implemented. That being said, would giving the developer a configuration option to disable background-click-to-close be a better compromise?

This sounds like a user issue and not a dev issue, so I don't think a dev option would help.


Added codeclimate configuration

This PR adds a configuration for the codeclimate CI integration.

Pull Request Test Coverage Report for Build 32

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-4.3%) to 91.477%

Totals

Change from base Build 26:
-4.3%

Covered Lines:
161

Relevant Lines:
176

💛  - Coveralls


Issue when including Pandas library 0.25.3 on Linux

I face to an issue similar to #557.
I have a simple script :
import pandas as pd
print("hello world")
I try to create an exe with the hinted approach:
python get-hints.py script.py
python nuitka-hints.py script.py
The compilation successes.
Here are the scripts used for the compilation: bug_pandas.zip
However, at runtime it crashes:
./hello.dist/hello

Traceback (most recent call last):
File "bug_pandas/hello.dist/hello.py", line 1, in
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "bug_pandas/hello.dist/pandas/init.py", line 30, in
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "bug_pandas/hello.dist/pandas/_libs/init.py", line 3, in
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "bug_pandas/hello.dist/pandas/_libs/tslibs/init.py", line 3, in
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "pandas/_libs/tslibs/c_timestamp.pxd", line 7, in init pandas._libs.tslibs.conversion
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "pandas/_libs/tslibs/c_timestamp.pyx", line 1, in init pandas._libs.tslibs.c_timestamp
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "pandas/_libs/tslibs/tzconversion.pyx", line 1, in init pandas._libs.tslibs.tzconversion
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "pandas/_libs/tslibs/c_timestamp.pxd", line 7, in init pandas._libs.tslibs.timedeltas
AttributeError: module 'pandas._libs.tslibs.c_timestamp' has no attribute '_Timestamp'

Here are some information about my configuration:
python -m nuitka --version

<IP_ADDRESS>
Python: 3.7.6 | packaged by conda-forge | (default, Jun  1 2020, 18:57:50)
Executable: anaconda3/envs/exe_pandas/bin/python
OS: Linux
Arch: x86_64

conda list

packages in environment at anaconda3/envs/exe_pandas:

Name                    Version                   Build  Channel
_libgcc_mutex             0.1                 conda_forge    conda-forge
_openmp_mutex             4.5                       0_gnu    conda-forge
ca-certificates           2020.6.24                     0
certifi                   2020.6.20                py37_0
ld_impl_linux-64          2.34                 h53a641e_7    conda-forge
libblas                   3.8.0               17_openblas    conda-forge
libcblas                  3.8.0               17_openblas    conda-forge
libffi                    3.2.1             he1b5a44_1007    conda-forge
libgcc-ng                 9.2.0                h24d8f2e_2    conda-forge
libgfortran-ng            7.5.0                hdf63c60_6    conda-forge
libgomp                   9.2.0                h24d8f2e_2    conda-forge
liblapack                 3.8.0               17_openblas    conda-forge
libopenblas               0.3.10          pthreads_hb3c22a3_3    conda-forge
libstdcxx-ng              9.2.0                hdf63c60_2    conda-forge
ncurses                   6.2                  he1b5a44_1    conda-forge
nuitka                    <IP_ADDRESS>            pyh9f0ad1d_0    conda-forge
numpy                     1.19.0           py37h8960a57_0    conda-forge
openssl                   1.1.1g               h7b6447c_0
pandas                    0.25.3           py37he6710b0_0
pip                       20.1.1                     py_1    conda-forge
python                    3.7.6           cpython_h8356626_6    conda-forge
python-dateutil           2.8.1                      py_0    conda-forge
python_abi                3.7                     1_cp37m    conda-forge
pytz                      2020.1             pyh9f0ad1d_0    conda-forge
readline                  8.0                  he28a2e2_2    conda-forge
setuptools                49.2.0           py37hc8dfbb8_0    conda-forge
six                       1.15.0             pyh9f0ad1d_0    conda-forge
sqlite                    3.32.3               hcee41ef_1    conda-forge
tk                        8.6.10               hed695b0_0    conda-forge
wheel                     0.34.2                     py_1    conda-forge
xz                        5.2.5                h516909a_1    conda-forge
zlib                      1.2.11            h516909a_1006    conda-forge

Please note that this problem happens only on my ubuntu session.
There is no problem when compiling on windows (with the same version of nuitka and pandas).

This is a duplicate of #775


Update CVE-2024-52269 CISA ADP SSVC

CISA ADP SSVC data is incorrect, requesting update to the correct metrics.

Thank you for the reports. An analyst has reviewed the information relating to these vulnerabilities. We were not able to locate a public PoC, and generally do not accept video-only evidence as PoC. However, our analyst has been able to independently re-create the PoC, and has reassessed the scores based on that work.  Due to differences in our reassessment from your suggestions and additional data that we added to the enrichment record, we are unable to merge this PR. If you have additional questions or information to share for further consideration, please feel free to cite it here or open issues as needed.

Let's at least also agree that it is also automatable, as they have an API. :)

An analyst has reviewed this and determined that user interaction is still required to trigger the exploit. As such, we have determined that this is not automatable.


Reuse cached entries if possible

When loading e.g. de_DE then use the already cached entries for de.

Implemented slightly different in #55


Material Button removes data attributes

Reproduction
Steps to reproduce:
Create a button with a data attribute (here: data-cy):
<button data-cy="loginBtn"  mat-raised-button type="button" (click)="submit()">Button</button>
Expected Behavior
Data attributes are not stripped
Actual Behavior
What behavior did you actually see?
Attribute data-cy is removed when serving/building the app
Environment

Angular: 8.2.10
CDK/Material: 8.2.3

It's most likely something different in your app. Here's an example that shows it preserving the attribute: https://stackblitz.com/edit/angular-2pcyar.


(DOCSP-31516) Changes listed values for --events to refer to API docs

Proposed changes
A user raised the issue that the listed event types for the --event description was not complete. We should point them to the OpenAPI spec for a more complete list of possible values that stays up to date with changes. I also adjusted the code so that commands for OM and CM point to those respective docs (dochub links created for all 3)
Jira ticket:
https://jira.mongodb.org/browse/DOCSP-31516
Checklist

[x] I have signed the MongoDB CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
[x] I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
[ ] I have updated test/README.md (if an e2e test has been added)
[x] I have run make fmt and formatted my code

@gssbzn It looks like this touched some MCLI CM/OM commands... would the values in the OpenAPI spec apply to them as well, or should I create a separate description for those to leave as-is?

A new description would probably be best linking to https://www.mongodb.com/docs/cloud-manager/reference/api/alert-configurations-create-config/ and https://www.mongodb.com/docs/cloud-manager/reference/api/alert-configurations-create-config/ (or doc hub equivalent)

Done! Ready for another look whenever you have time


OpenRouter breaks voice

Issue
If I use OpenRouter, the /voice command breaks, presumably because it uses the OpenRouter API base.
Version and model info
aider 0.45.1

Unable to reproduce. I'm using:
Aider v0.45.1
Models: openrouter/anthropic/claude-3.5-sonnet with diff edit format, weak model openrouter/deepseek/deepseek-coder
/voice is working fine here.
I assume you A/B tested and it works when you switch models? If so, please provide the chat logs.

Yes I did, it was working fine without the API base and breaking with it. I will try to reproduce again and post everything here.

Thanks for trying aider and filing this issue.
How you are you configuring aider to use openrouter? If you do it per the docs, it should not affect /voice.
https://aider.chat/docs/llms/openrouter.html

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


Ability to bulk edit episodes

[ ] Flair
[ ] Clear subtitles
[ ] Publish date
[ ] Set privacy
[ ] Set archive status
[ ] Episode art
[ ] Feedback prompt
[ ] Copyright
[ ] License
[ ] Explicit status

I keep thinking about this feature and I keep coming back to how easy it would be to mess something up. For now, customers can contact support if they need help bulk updating content. Otherwise, the usefulness of this feature is almost zero for the overwhelming majority of users.


CreateConversationAsync doesn't pass the tenantId

Version
4.4
Describe the bug
When use one of the overload method CreateConversationAsync  in   BotFrameworkAdapter, the summary says: Overload receives a ConversationReference including the tenant, but the tenantId is not used at all, then it will throw exception in the middleware TenantIdWorkaroundForTeamsMiddleware, I think it's a very simple case, or I didn't understand correctly?
And the code that parse the tenantId from ConversationReference is :
 var typeOfDynamic = reference.Conversation.GetType();                 var tenantProperty = typeOfDynamic.GetProperty("tenantId");                 var tenantId = tenantProperty?.GetValue(reference.Conversation, null);
shouldn't be
var tenantProperty = typeOfDynamic.GetProperty("TenantId");?
[bug]

I apologize this issue wasn't looked at sooner. Can you be more explicit about what the bug is? In the Teams context, Conversation.TenantId gets set via ChannelData.tenant.id. The lowercase "t" is because it will come in as JSON, which uses camelCase. Are you experiencing a bug because of this?

@searlin 	Is this still an issue for you?

Hi @mdrichardson thanks for your comments,  and yes, it's still an issue for us.
I don't think the property comes in as JSON, below are two screenshots you can check.

And even the tenantid's value is correct, the value isn't used at all, below is my change to make it work:

Aha! I see what you mean. I'll start working on a PR for this. Thanks for pointing it out!!


Account sign-out dialog "Sign out" button caption should be "Sign Out"

Issue Type: Bug

The item triggering it from the Account icon's menu is captioned "Sign Out".
VS Code version: Code - Insiders 1.63.0-insider (4e303fcc52269ab578affa6cb1eb455eacab445f, 2021-11-22T05:28:15.683Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

/assign @misolori

@TylerLeonhardt i believe this is related to the accounts sign in cc @sbatten for whether we sentence or capitalize buttons in dialogs

Purely based on "Don't Save", I suppose we are not using sentence casing.


kubernetes integration

The sanger is moving to some cloud service called openstack and using a kubernetes cluster https://kubernetes.io/ for job submission. It isn't fully set up yet so I can't test it, but they are initially creating support with nextflow pipeline management system. It is somewhat similar to martian, but I think martian still has some key advantages (not least of which is that nextflow uses groovy and I can't even run it from a head node here due to memory limits...). I don't know much about kubernetes, but how hard do you all think it would be to get working with that? Probably not terrible but I can't really test anything at the moment so blech.

At a very basic level, this is easy.  It looks like there are "manila" plugins offering shared nfs filesystems, which are a prerequisite for martian, and "sahara" looks like it supports shell jobs, which could be used to integrate with martian.  It might be nessessary to create a wrapper script to transform the job template which martian gives to the job manager binary's standard in into whatever command is required to make the job actually run.
This is definitely something we'll look into eventually, although I cannot promise a schedule.  I don't have easy access to an openstack cluster to test on.  If you would like to experiment with it on your own, I'd be happy to offer advice if you run into trouble.


Cannot read property 'hasOwnProperty' of undefined

The following code is supposed to be pasted in every page that uses amplitude:
(function(e,t){var n=e.amplitude||{_q:[],_iq:{}};var r=t.createElement("script");r.type="text/javascript";     r.async=true;r.src="https://d24n15hnbwhuhn.cloudfront.net/libs/amplitude-3.0.1-min.gz.js";     r.onload=function(){e.amplitude.runQueuedFunctions()};var i=t.getElementsByTagName("script")[0];     i.parentNode.insertBefore(r,i);function s(e,t){e.prototype[t]=function(){this._q.push([t].concat(Array.prototype.slice.call(arguments,0)));     return this}}var o=function(){this._q=[];return this};var a=["add","append","clearAll","prepend","set","setOnce","unset"];     for(var u=0;u<a.length;u++){s(o,a[u])}n.Identify=o;var c=function(){this._q=[];return this;     };var p=["setProductId","setQuantity","setPrice","setRevenueType","setEventProperties"];     for(var l=0;l<p.length;l++){s(c,p[l])}n.Revenue=c;var d=["init","logEvent","logRevenue","setUserId","setUserProperties","setOptOut","setVersionName","setDomain","setDeviceId","setGlobalUserProperties","identify","clearUserProperties","setGroup","logRevenueV2","regenerateDeviceId"];     function v(e){function t(t){e[t]=function(){e._q.push([t].concat(Array.prototype.slice.call(arguments,0)));     }}for(var n=0;n<d.length;n++){t(d[n])}}v(n);n.getInstance=function(e){e=(!e||e.length===0?"$default_instance":e).toLowerCase();     if(!n._iq.hasOwnProperty(e)){n._iq[e]={_q:[]};v(n._iq[e])}return n._iq[e]};e.amplitude=n;     })(window,document);
There is however this issue:
Cannot read property 'hasOwnProperty' of undefined
which can be found being called near the end of the amplitude code pasted above. If anyone else has run into this issue and knows how to solve it, any help would be appreciated.

It seems n._iq is undefined, except it should be defined at the beginning of the script: var n=e.amplitude||{_q:[],_iq:{}}; The only thing I can think of is you already have a window.amplitude defined that doesn't have _iq? Is that possible?

This problem is caused by include amplitude js code twice in one page.

Thanks for the tips @dingjb! Hopefully your problem is solved, @dudduss. This one has been opened for a while. Closing for now.

@blazzy and @dingjb
Looking at the code snippet which is also found here. It checks if window.amplitude exists before creating _iq. We still see this error in our js tracking system for some users and I was wondering if there is an important use case where window.amplitude should already exist before and should be used? Otherwise, I would just set window.amplitude = undefined before this script is executed. Any advice?

I have the same problem. It looks like something's happening asynchronously, because the error is not always showing up. Any suggestions?

Had the same issue, it was related to loading the script multiple times with turbolinks. I fixed it by wrapping the code with an "if" statement:
<script type="text/javascript">
  if (typeof amplitude === 'undefined') {
    (function(e,t){var n=e.amplitude||{_q:[],_iq:{}};...
     ...
  }
</script>


Combining GenericDistribution library with Reducer library

This is for #100
This PR hooks up most functions of the distribution library to the new reducer. The main file, ReducerInterface_GenericDistribution.res, outputs one function, dispatch, which is used to augment the reducer dispatch to accept functions that work on distributions.
The rest of that file is a bit messy, but I'm not that worried about it, because it's very contained. (None of that is publicly available.)
I added a bunch of relevant tests for this, but they're fairly spread out and not very well organized. I think the main place for us to test distribution math is in the GenericOperation library, so I want this to mostly be used to test different input formats and make sure they generally work.
There's clearly more work to do, but I think this could be a good foundation.

I'm going to merge this, because I want to do some work on top of it. If anyone wants changes, we could make them as new issues.


fix: makefile had an incorrect phony

fix: makefile had an incorrect phony

/lgtm

The bundle failure has been addressed in https://github.com/ComplianceAsCode/compliance-operator/pull/608 and the rosa e2e failures are unrelated.


Update AdjustableModPanel.netkan

apologies - still learning :octocat:

Looks like there's no change in the status of the conflict:
https://forum.kerbalspaceprogram.com/index.php?/topic/147463-112x-end-your-parts-list-nightmare-introducing-the-janitors-closet/

@linuxgurugamer, if that's out of date, ccould you please update the OP and let us know? Then we could re-open this and merge it.

LGG says that JC is incompatible with KAMP then put that in the JC listing not in KAMP. Currently it isn't in JC and I don't want it in KAMP's.


Better Handling for Multiple Users when Load Testing

Feature Request
In order to simulate a large number of unique users, hitting Dockstore, we need to have a large number of unique users with tokens.
Since users are normally created by individual users using OAuth with GitHub and/or Google, we should probably have a SQL script that generates users with Dockstore tokens.
┆Issue is synchronized with this JIRA Story
┆Issue Number: DOCK-142

https://github.com/ga4gh/dockstore/blob/develop/dockstore-integration-testing/src/test/java/io/dockstore/client/cli/AdvancedIndexingBenchmarkIT.java#L141 might be useful.


Can't figure out how to create a build system that will open any browser when editing files from a USB drive

Howdy.
I can't figure out how to create a build system that will open any browser when editing files from a USB drive. In fact, I can't get this to work under any scenario.
Any tips?
Cheers.

What do you mean when you say "build system"? Are you trying to make a build file? View In Browser plugin doesn't make use of the build system, so this is why I am asking.


(GH-15)(GH-12)(chocolatey/blog#20) Theme Updates to Support Blog

In this PR:

Adds missing custom container styles
Adds sizing utilities
Makes cookie notice entire width

Fixes #15 Fixes #12

@designxsteph thanks for getting this fixed up, and for showing how to reference an issue in another repository! Nice!


DEV 8483.1 add new contextTypeCode for releaseTag runs

https://github.com/Shippable/pm/issues/8483

this is done, closing


Document new APIs

Pull Request Description
Documenting new APIs
Fixed Issue(s)

Fixes #41
Fixes #64

Closed to #76


[retiarii] refactor of pytorch operators

[x] support more unit tests
[x] support shared module
[x] refactor of pytorch operators
[ ] write more unittest: pytorch models
[ ] write more unittest: basic operations
[ ] support control flow (v2.2)

I like this refactor, it seems everything is on the right way again. In order to find a good design pattern, I browsed some tvm repositories. Extracting and retranslating computational graphs is widely discussed, and they usually exist as part of the library. In fact, I guess a more perfect solution is not to create a calculation graph intermediate representation for the entire module, and just replace the parts related to nni, like nn.LayerChoice.

I like this refactor, it seems everything is on the right way again. In order to find a good design pattern, I browsed some tvm repositories. Extracting and retranslating computational graphs is widely discussed, and they usually exist as part of the library. In fact, I guess a more perfect solution is not to create a calculation graph intermediate representation for the entire module, but just replace the parts related to nni, like nn.LayerChoice.

thanks for your suggestion! it would be great if you can also provide the links of the discussion here :). I agree with your suggestion. we also thought about this design. the problem is that we have to convert graph back to code. if we only parse a submodule while keeping the top-level module unchanged, it is not easy to stitch the unchanged part and the generated part together. we will keep thinking about this. If you have good suggestions, feel free to tell us.


additional util to remove duplicated versions (non-latest)

Description of the Change
The code for removing the duplicated non-latest versions.
@confused-Techie DO NOT run it before making a database backup, please.

Since we chose another approach in #64, this PR is not needed anymore


Graph disconnected when training segmentation network

Hi,
Thank you for sharing the code.
I  run
python main.py trans --gpu 0 --data mri-100unlabeled --model flow-fwd
python main.py trans --gpu 0 --data mri-100unlabeled --model flow-bck

to get the spatial transform models, edit main.py then run
python main.py trans --gpu 0 --data mri-100unlabeled --model color-unet

get the appearance/color transform model.
I edit the code at line 265:276, and then train the segmentations network,
python main.py fss --gpu 0 --data mri-100unlabeled --aug_tm

but get Graph disconnected error.
After reading the code, I find that may be the problem in segmenter_model.py, line 417
self.color_aug_model = Model(
                        inputs=self.color_aug_model.inputs[:-1],
                        outputs=[
                            self.color_aug_model.outputs[0],
                            self.color_aug_model.get_layer('add_color_delta').output,
                            self.color_aug_model.outputs[2]],
                        name='color_model_wrapper')

here the input flow_srctotgt is dropped, but the outputs[0], which is transformed_out, still connect to flow_srctotgt by transformed_out = SpatialTransformer(indexing='xy')([transformed_out, flow_srctotgt]) in line 292 at file networks.py. So the program crashed.
According to line 576 in file segmenter_model.py,
color_delta, colored_vol, _ = self.color_aug_model.predict([source_X, X_colortgt_src, source_contours])

Line 417 in file segmenter_model.py should be
self.color_aug_model = Model(
                        inputs=self.color_aug_model.inputs[:-1],
                        outputs=[
                            self.color_aug_model.outputs[1], # edit 0 to 1
                            self.color_aug_model.get_layer('add_color_delta').output,
                            self.color_aug_model.outputs[2]],
                        name='color_model_wrapper')

After change code here, I can train the segment network.
So, is this the correct way to fix that problem?
Thanks.:thumbsup:
####
My enviroment is:
OS: Ubuntu 18.10 x86_64
Python version: Python 3.6.7 :: Anaconda, Inc.
tensorflow-gpu version: 1.12.0
Keras version: 2.2.4

@steermomo thanks for catching this. You should check the definition of color_delta_unet_model() in networks.py -- the latest version has the model outputs in the order outputs=[transformed_out, color_delta, x_seg], so it's possible that you might need to update line 576 in segmenter_model.py instead. I'll fix this in the main branch.

@steermomo Hi, I think you need to remove the [::-1] when defining the color_aug_model, like this:
self.color_aug_model = Model(
                        inputs=self.color_aug_model.inputs,
                        outputs=[
                            self.color_aug_model.outputs[0],
                            self.color_aug_model.get_layer('add_color_delta').output,
                            self.color_aug_model.outputs[2]],
                        name='color_model_wrapper')

Because the color_aug_model needs the 4-th input to output the augmented image, which is transformed both in spatial space and appearance.
And keep this line in the segmenter_model.py as it is:
colored_vol, color_delta, _ = self.color_aug_model.predict([source_X, X_colortgt_src, source_contours, flow])
Because the color_aug_model in color_delta_unet_model in networks.py ouputs [transformed_out, color_delta, x_seg] in this order.


FIX(Dashboard): fixed wrong artifact bug

Fixed bug where dashboard brooklyn entity was downloading the wrong artifact.
Also setting default values for config keys.

@rosogon @MicheleGuerriero @perezp Could any of you guys have a look? Thanks!

@mbarrientos : I don't understand the purpose of this file. Does it "receive" the values specified in the blueprint and set default values if not set in the blueprint?

@rosogon Thanks for the review.
The config keys default values are only used if there's nothing specified in the blueprint. In the way that the dashboard is built right now, all configuration values are mandatory so having default values gives a bit more consistency on built.

+1

+1


Add reindex API support (fix #436)

Coverage increased (+0.2%) to 56.138% when pulling ec48cdc2fda492d8fe86a085b908f3a7f759427f on fbaligand:master into b9da392290d110570b974225790d0d3ac25c13b0 on searchbox-io:master.

@searchbox-io
Could you review this PR ?

Hi @fbaligand
Is it possible to add an integration test ? So far LGTM.

Hi @ferhatsb,
Actually, I tried to.
But it requires to upgrade elasticsearch dependency to 2.3.0 at least.
And when I ran tests, it fails :(

@ferhatsb,
To be more clear, if I upgrade elasticsearch dependency version to 2.3.0 in Jest parent POM, some existing tests don't compile, some other fail at execution time.
That's why I abandoned the idea to make an integration test for reindex API.

I will check this next week to move 2.3-2.4 before going for 5.0

Nice news !

Hi @ferhatsb,
Do you still plan to upgrade Jest elasticsearch dependency to 2.3.0 ?
If so, when do you plan to do it ?

Just pushed with ES 2.4.3 with less hair.
You need to add reindex module as maven dependency( see groovy lang) and apply it as plugin at integration test (see scripted tests).

Hi,
it's strange, because you speak about ES 2.4.3.
However, in pom.xml, I see elasticsearch.version=2.4.1

well 2.4.1 it is, was aimed 2.4.3 though, anyway it is very simple change

OK.
Anyway, this is quiet the same :)
That said, I am annoyed : travis-ci build failed because of a bad version plugin dependency :
The project io.searchbox:jest-parent:2.0.5-SNAPSHOT (/home/travis/build/searchbox-io/Jest/pom.xml) has 1 error

[ERROR]     Unresolveable build extension: Plugin org.sonatype.plugins:nexus-staging-maven-plugin:1.6.7 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.sonatype.plugins:nexus-staging-maven-plugin:jar:1.6.7: Could not transfer artifact org.sonatype.plugins:nexus-staging-maven-plugin:pom:1.6.7 from/to central (https://repo.maven.apache.org/maven2): Access denied to: https://repo.maven.apache.org/maven2/org/sonatype/plugins/nexus-staging-maven-plugin/1.6.7/nexus-staging-maven-plugin-1.6.7.pom , ReasonPhrase:Forbidden. -> [Help 2]

Ensure, code is sync with origin, changed version from 2.0.5 to 2.4.0 at master

Coverage increased (+0.2%) to 56.799% when pulling b3f150b2f79d0580242ac6803775fc336852747a on fbaligand:master into 44f551353cbca64269aa6c4ddbd763536bb484ae on searchbox-io:master.

Ok, after a git rebase, it works better !

Hi @ferhatsb
I tried to add my integration test, but big surprise : the embedded elasticsearch instance for integrations tests don't recognize _reindex as an API but considers it like an index...
I get this error, while trying to call reindex :
{
   "error": {
      "root_cause": [
         {
            "type": "invalid_index_name_exception",
            "reason": "Invalid index name [_reindex], must not start with '_'",
            "index": "_reindex"
         }
      ],
      "type": "invalid_index_name_exception",
      "reason": "Invalid index name [_reindex], must not start with '_'",
      "index": "_reindex"
   },
   "status": 400
}

Of course, I believe first that was a bug in my code, but :

If I execute the same code on a standalone elasticsearch 2.4.1 instance, it works
I truly checked that started embedded instance is a 2.4.1 version
during the test, I tried to make the same reindex call from sense, and it raises same error.
endly, all other jest integration tests work

Have you any idea of how to make reindex API recognized by elasticsearch embedded instance ?

@ferhatsb
If you want that I commit integration test so that you can test for yourself, tell me.

Please commit to your branch, I can check it.

@ferhatsb
I just committed ReindexIntegrationTest class in jest module.
And travis-ci reproduce the error I get.
Thanks to check it ! That's much appreciable !

Please see my changes, merged.

Nice !
Thanks a lot for the fix !
I saw that the main problem is that elasticsearch embedded test server needed an extra dependency.

Indeed, embedded ES does not loading modules as regular distribution, also in tests it is required to override loaded plugins.
Well, now works like a charm, thanks for your contribution.

It was a pleasure !
And thanks for your help !
When do you plan to make next release ?

@ferhatsb
I detected a duplicate maven dependency in jest/pom.xml.
So I just created a PR to fix it : #445

I may need to work on issues overall and see if we can have quick wins.
Guess we can make a release by first week of 2017.


ua-parser-js fork is vulnerable

Summary
Please update @amplitude/ua-parser-js, the amplitude fork of us-parser-js, to at least 0.7.33, and update consumers of that library accordingly
Motivations
ua-parser-js versions >=0.7.30 <0.7.33 are vulnerable: CVE-2022-25927 SNYK-JS-UAPARSERJS-3244450
This seems to be similar to https://github.com/amplitude/Amplitude-JavaScript/issues/158 with a new vulnerability

PR in https://github.com/amplitude/ua-parser-js/pull/7

@jk-clarabridge  Thanks for your contribution. Do you mind merging the conflict on that pr?

I took the main ua-parser.js file from the original and this amplitude fork:
https://github.com/faisalman/ua-parser-js/blob/0.7.x/src/ua-parser.js
https://github.com/amplitude/ua-parser-js/blob/master/src/ua-parser.js
And then applied a common prettier formatter for uniformity, and then produced a diff: https://github.com/kevinyou/demo-ua-parser-comparison/blob/main/diff.diff
Most differences are strictly additive improvements - newer versions of ua-parser support more browsers.
This section is the security fix for the CVE
I don't know why amplitude originally decided to fork ua-parser-js but I'm not seeing any reasons with the latest 0.7.x version of ua-parser-js. It might be simpler to just archive the fork and use the latest ua-parser-js.

Just to echo what Kevin said, the conflicts are difficult to merge due to the formatter being applied, as there are dozens of changes detected, but the majority are caused by linting/formatting preferences. It doesnt look like there's any compelling reason for this to be its own package. Is it possible to update amplitude to just use the base package instead of this fork?
We could also just apply the fix for the vulnerability that Kevin referenced and skip all of the other updates, but that feels like it's just kicking the can down the road, and next time there's a reason to update from the base repo you'll run into this same issue again.

@yuhao900914 I merged the conflicts in a new PR, can you review this? https://github.com/amplitude/ua-parser-js/pull/8

@kevinyou , I left a comment on your pr and request the changes. Thanks.

@yuhao900914 Could you also publish 0.7.33 to npmjs?

@yuhao900914 Could you also update these two dependents from 0.7.31 to something like ^0.7.33?
https://github.com/amplitude/Amplitude-JavaScript/blob/main/package.json#L18
https://github.com/amplitude/experiment-js-client/blob/main/packages/analytics-connector/package.json#L31


Error while entering any system since patch .5972

Since today's patch I started getting this error whenever I enter any system.
Error: https://steamcommunity.com/sharedfiles/filedetails/?id=2429492752
Mod list: https://i.gyazo.com/5389672f7c76a65f1bd58a49fa6c848b.png
I can't tell if this is an incompatibility between mods, the mod or the game, or any combination. Do you think this could be related to your mod or is it something else?
PS Love your mod and can't play without it. Too bad max stars is kinda laggy so I sticked to 512.
PS2 Is it expected that some systems are empty? Have 2 black holes nearby (20 and 25ly) that have 0 planets.

Fixed in 1.3.2


Various errors related to "UnhandledPromiseRejectionWarning"

I've used Fiddler 4 to find both oath keys and inputted them correctly. Paired with my correct username and password, I get the following errors:
PS C:\Users\Adam\fort> node .\fortnite.js
Fortnite-API - Credentials Params OK
(node:11480) UnhandledPromiseRejectionWarning: Please enter good token
(node:11480) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not han
dled with .catch(). (rejection id: 1)
(node:11480) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Here is the code, leaking the tokens as they are the same for everyone:
const Fortnite = require("fortnite-api");

let fortniteAPI = new Fortnite(
    [
<EMAIL_ADDRESS>        "my_password",
        "MzRhMDJjZjhmNDQxNGUyOWIxNTkyMTg3NmRhMzZmOWE6ZGFhZmJjY2M3Mzc3NDUwMzlkZmZlNTNkOTRmYzc2Y2Y=",
        "ZWM2ODRiOGM2ODdmNDc5ZmFkZWEzY2IyYWQ4M2Y1YzY6ZTFmMzFjMjExZjI4NDEzMTg2MjYyZDM3YTEzZmM4NGQ="
    ],
    {
        debug: true
    }
);

fortniteAPI.login().then(() => {
    fortniteAPI
    .checkPlayer("PaulTrooper", "pc")
    .then(stats => {
        console.log(stats);
    })
    .catch(err => {
        console.log(err);
    });
});

$ node --version
v8.11.3

Resolved. This was because my account has 2-auth and it was failing there. Would have saved some time if the error would have printed.


Support CREATE EXTERNAL TABLE dt STORED AS DELTATABLE syntax with datafusion

Description
In datafusion, SQL users can use the create external table xyz stored as csv option to register CSV, JSON, and parquet data. It would be nice (essential in my company's case) to allow users to register deltalake tables in the same manner.

@avantgardnerio - this is awesome.  Can't wait to have Datafusion support!  I will definitely help update the docs / write blog posts when this functionality is added.

Thanks! Related datafusion PR if you'd like to follow along: https://github.com/apache/arrow-datafusion/pull/3907 . I've definitely seen it work in Datafusion, so I don't think support is far away for that. Ballista will be some more work as we'll need to do serde on the physical plan, and re-register the object store on the executors.


Added Scroll-Progress-Bar

This PR introduces a scroll progress bar feature to visually represent how far the user has scrolled through a page. The bar fills as the user scrolls down the page and decreases as they scroll back up, providing a more intuitive navigation experience.
Changes Made:
Added a scroll progress bar that appears at the top of the page.
The progress bar width dynamically adjusts based on the user's scroll position.
The progress bar is styled using CSS for smooth transitions.
JavaScript is used to calculate the scroll position and update the width of the progress bar.
https://github.com/user-attachments/assets/511cad86-349d-4376-b9fd-88b9d383e3eb

Hi @PriyaGhosal ,
I recently visited your website again and noticed that the scroll progress bar feature, which I implemented based on the previous web UI, no longer aligns with the current design. It seems like the UI has been updated, and the scroll progress bar color now feels out of place.
If you're okay with it, I’d be happy to modify the code to update the scroll progress bar color to better match the current UI and maintain design consistency. Let me know if you’d like me to proceed with this change!


Badge Component

Badge Component
Design
Refer Design here: https://www.figma.com/file/IZHRiuhZEG4GCIMpBKA7ar/Hover?node-id=1109%3A1580
Tasks

[ ] Component Spec
[ ] Component Code
[ ] Tests
[ ] Documentation

closed by #16


FIX: eloreta labels

What does this implement/fix?
eLORETA couldn't be applied to labels.
Additional information
I am not familiar with eLoreta, so someone who is needs to check this but it does make _assemble_kernel self consistent.

errors are unrelated. thx @bloyl


Wrong hightlight? Why this is happens?

why this is happens? pug  is strange work!  all is done well, i guess, but syntax  highlighting - is wrong...i try codepen - all is good

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:

hello again!  now  i tested this out...only this extensions is work very well with hightlighting pug sintax-  https://atom.io/users/leonschwanitz


Customize able device response

Right now the default response for any device would desktop page (index.cshtml). So if you have a index.cshtml & index.mobile.cshtml, then when you open the website via tablet the middleware would response with index.cshtml (desktop) default.
The goal is to make this customize able via UseResponsive() extension with ResponsiveOptions.

Working concept of customized able response is configure through UseResponsive().
app.UseResponsive(new ResponsiveOptions
{
      TabletDefault = Wangkanai.Detection.DeviceType.Mobile
});

Need unit testing before pushing to beta 3

feature completed


Update base64_encode.js

Much shorter and quicker algorithm, plus minifies nicely:
function R_B64Encode(V){if(!V)return V;V=unescape(encodeURIComponent(V));var A=new Uint8Array(V),i=A.length,b="ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=",D="",M=252,S=6,C=0,x=0;while(x<i){D+=b[(C<<S)|((M&A[x])>>(8-S))];if(!S){M=252;S=6;C=0;}else{C=((~M)&A[x])S-=2;M=(M<<2)&255;}if(S)x++;}if(C)D+=b[(C<<S)];return D}

Faster? Do you have before/after benchmarks?

Hi Scott,
I have tested it on a fairly large file(64MB), and yes it was around a 10% faster, I did a timing check on Chrome.
Regards,
Warren
From: Scott Baker<EMAIL_ADDRESS>Sent: Sunday, November 8, 2015 2:52 AM
To: kvz/phpjs
Cc: WarrenGardner
Subject: Re: [phpjs] Update base64_encode.js (#250)
Faster? Do you have before/after benchmarks?
—
Reply to this email directly or view it on GitHub https://github.com/kvz/phpjs/pull/250#issuecomment-154768192 .  https://github.com/notifications/beacon/AO-2kbTF4SNSa-ghafhMBC7NrfRQdCX-ks5pDpROgaJpZM4GeEVh.gif

Hey @sabbir1991, thank you so much for this PR. I am very sorry for the long wait after you put in this work. This project and my motivation were in a bad spot. I recently did a lot of work to breathe new life into it (http://locutus.io/2016/05/announcing-locutus/). As part of this I'm going over all issues and PRs now. Looking at this one, it seems to me that. Closing this for now but feel free to re-open.


Confirm data points with ack = true

Describe the bug
Hello and thanks for the cool adapter! But I have a question (I'm an adapter developer myself): Why don't you confirm your values with ack = true? I only respond to ack = true by default in scripts, since it is the default when an adapter writes its own values to datapoints.
Expected behavior
I think you should fix that with a future update.
Screenshots & Logfiles

Versions:

Adapter version: <0.5.1>

implemented in version 0.6.0 - thank you very much @Xenon-s


Show newlines in comments

Preserves newlines in comments
New test coverage to confirm

Closes #300

@william @migurski or @norrishung pls take a look and merge!

For bug fixes I think it's better to write the test first, as it's often easier to think of failure cases before you've solved the problem. But this generally looks good to me.


chore(deps): update terraform terraform-ibm-modules/key-protect/ibm to v2.4.1

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/key-protect/ibm (source)
module
patch
v2.4.0 -> v2.4.1

Release Notes

terraform-ibm-modules/terraform-ibm-key-protect (terraform-ibm-modules/key-protect/ibm)
v2.4.1
Compare Source
Bug Fixes

onboard module into IBM Cloud registry (#471) (bd394f9)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.17.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


remove 'No video for article' text

Describe the bug in current situation
When a help article is published without an mp4 file in help.foirequests.gov.bc.ca, a red text saying "No video for article" is included in prod frontend. This task is to remove the red text, as there are situations where help articles will be published without an mp4 file. See screenshot for an example.
Link bug to the User Story
Impact of this bug
All users impacted as all users see the red text, but functionality is not affected. The help articles function as they are supposed to without mp4 files.
Chance of Occurring (high/medium/low/very low)
high
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
production link: https://help.foirequests.gov.bc.ca/help-article/applicant-payment
backend link: https://foi-help-backend-test.apps.silver.devops.gov.bc.ca/admin/
Steps to Reproduce
Steps to reproduce the behavior:

Go to 'foi-help-backend'
Click on 'Content Manager', and then Help Article
Create new entry, then fill in body and slug.
Do not add media
Click Save
Access https://github.com/bcgov/foi-help/actions/workflows/web-deploy.yaml and front end deploy

Actual/ observed behaviour/ results
Red text saying 'no video for article'
Expected behaviour
No red text saying 'no video for article'
Screenshots/ Visual Reference/ Source

Update with bug template.

Updated with bug template

@richard-aot Thanks for completing this one!!


In the absence of other node subscription, should it send multicast packets?

I use the multicast channel, for my network switch limit multicast, I locate the subscription and publication on the same host. I read the code and found although no subscription on other host, it would send multicast packets. And the other host received and dropped it.

Can you please refine the question? It is not clear what you are asking.

I think he is saying that multicast traffic is published to all interfaces from the publishing host, even if the only subscriber is on the localhost loopback?

On 10 May 2017, at 12:57pm, Martin Thompson<EMAIL_ADDRESS>wrote:
Can you please refine the question? It is not clear what you are asking.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/real-logic/Aeron/issues/354#issuecomment-300459851, or mute the thread https://github.com/notifications/unsubscribe-auth/AJrpD6g4PspQse2X4pJe63vQTdpKjvEBks5r4aYRgaJpZM4NWjlZ.

Thank cesaref for your clarification.

No. IP Multicast does not go out all interfaces. It goes out only one. When sending IP multicast, the kernel looks at the sockets IP_MULTICAST_IF and then at the routing table and it goes out the indicated interface.
http://www.tldp.org/HOWTO/Multicast-HOWTO-6.html
However, there is no loopback only multicast interface.... unless you configure one for this explicit purpose in the OS and explicitly make it the default multicast interface.
So, what you are observing.... multicast traffic going out to a multicast address outside the machine, is the intended TCP/IP socket behavior for multicast. If a multicast receiver is listening to that multicast address and port, and a network switch supports multicast, then it will forward all traffic to that machine that matches that address and port.

@tmontgomery , I understand your meaning, but I just  unfortunately encountered the situation that the switch not support multicast well. But I thought under the situation, is it reasonable to give way to ip protocol stack? From the angle of the design, should we design more efficiently?

@tmontgomery, I have already changed my switch to support multicast well.

Well, Aeron is restricted to the IP multicast semantics of the kernel. Changing some of that is not possible. And in some cases, not really advised. It is simpler and cleaner to go with the IP multicast semantics that are well understood instead of hiding them, in my experience.
BTW, if you want only loopback behavior, you are much better served by using IPC than by using multicast.

@tmontgomery , I could not use IPC, for my case is one-pub and multi-sub on multi-hosts, for the reason of the switch, I temporarily adjust deployment.

@jordanxlj For the local to avoid loopback have you considered using a spy subscriptions?

@mjpt777 , In my mind, Spy Subscription is just not copy publication term buffer, without back pressure. It is transparent to the publication, so it is useless.

@jordanxlj Spies apply back pressure to the publication just as normal IPC subscriptions would.


Remove v1.0 from example filenames

Should be merged after https://github.com/AMWA-TV/nmos-network-control/pull/21 on which it is based.
Since specification versions are managed as tags (v1.0, v1.0.1) and branches (v1.0.x, v1.1-dev), it is much simpler to maintain examples if they do not contain the version number in the filename.
(Cf. AMWA-TV/nmos-discovery-registration#69, AMWA-TV/nmos-device-connection-management#50, etc.)

Rebased to make this PR independent of #21. Can it be merged, @vsachin33, @NEOAdvancedTechnology? Thanks.


Patch bundle for 1.4.3.patch2

1.4.3 wmagent version of the following PRs:

Only resolve RSE requires_approval for T0 data placement #10130
Fix JobAccountant missing parent dbsbuffer file #9997
Catch UnicodeDecodeError in JobAccountant #10152

 Fix #10162 - Patch bundle for 1.4.3.patch2


Allow to define config path via env

This PR allows to set the default config path via environment variable.

As only minor commit, I merge directly.


detekt 1.0.0

New Pull Request Checklist
Please mark the points which you did / accept.

[x] I read the Step Development Guideline
[x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

Thanks for the PR @misaelmt , we'll check it ASAP! :)

Note: as this is a new step it might take a longer time for us to review it. Once the first version is accepted subsequent updates will be faster to get accepted as we'll only check the diffs.

Thanks @viktorbenei ! No problem, I understand that you (and I, as a Bitrise user) want to maintain a high quality standard :)

Exactly! ;)
Note: you can already use your own step if you want to, by specifying its git clone URL directly! See: http://devcenter.bitrise.io/bitrise-cli/steps/#step-referenceid-format
specifically the git:: syntax. If you'd have any questions just let us know! ;)

Hi @misaelmt !
Thanks for the new step! I sent you a Pull Request with the requested changes, but maybe it would be better to recreate the repository to avoid storing a large binary file.


Example Ideas

Here is a list of some example ideas we could do for presentation:

[ ] CLI Tic-Tac-Toe (like this one I wrote 5 years ago)
[ ] Mandelbrot Set rendering with ASCII
[ ] grep
[ ] csv parser

please update with more ideas if you have some

I like the tic-tac-toe one!


switch to debug logs only

Description of Change
Changing the .error method to .debug for logging http errors because it looks really bad when doing bulk operations and depending on CLI output for progress, like we do in the CLI.
Here is what the output looks like (no -d was given for the CLI - this always happens no matter what)
Updating alerts:  [########################------------]   66%  00:00:01  2 succeeded, 0 failed out of 3Failure in HTTP call 404 Client Error: Not Found for url: https://alert-service-east.us.code42.com/svc/api/v1/update-state. Response content: {
  "pop-bulletin": {
    "Details": []
  }
}
Updating alerts:  [####################################]  100%  2 succeeded, 1 failed out of 3

Issues Resolved
No official issue
Testing Procedure
Use this in the CLI as its py42 dependency. Do something erroronous.  Rely on logs instead of stdout.
PR Checklist
Did you remember to do the below?

[n/a] Add unit tests to verify this change
[?] Add an entry to CHANGELOG.md describing this change
[n/a] Add docstrings for any new public parameters / methods / classes

I don't enjoy seeing pop-bulletin and a huge JSON blob for CLI errors.
If we really want this in our py42 scripts, I can try to come up with a way to parametrize silencing them.
I only wish to see these in the error log file, not in stdout, for scripts / CLI.


CI: Fix typo setting kubeconfig variable from registry

This caused some off errors, particularly around how we determine
whether we are in the CI or running with a custom kubeconfig.

This change is

test-me-please

test-missed-k8s

test-nightly

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

I can't approve "my own" PR, it seems, but +1 from me.
@ianvernon you seemed interested, as a 3rd party, you would be a great reviewer! :P

test-me-please


Added Create Category functionality

Solved issue #103
Category List Screen Before:

Category Create Screen:

Category Screen After:

Hi, @AyushTripathi-sketch Could you add a screen-recorded video of your work? Also, could you summarize what changes you have done? Have you formatted the code using prettier?

Yes, I can scree record my work. I have created a screen for creating category and updated the category action and reducers for deleting, updating and creating category. In the backend I have made a category controller for different for the same actions and added a admin/createcategory route. I have also formatted the code using Prettier..


Add --version

It'd be great to add a --version option to double check the installed version

triaged

https://github.com/uber/mockolo/releases/tag/1.2.5

Thanks! 🚀