Fix iOS touch mapping

iOS backend did not map touch coordinates to libGDX correctly. libGDX's GL View is stretched over whole screen, but libGDX draws only on a subset of that, because it excludes status bar, if present. Touch mapping was however completely oblivious to this fact - this worked well when the status bar was not visible, but was inaccurate when the status bar was indeed visible.
This PR rewrites rotation/resize handling and touch coordinate mapping to explicitly handle mentioned problems.
This is somewhat related to issues:
#2105 - although this seems to be the opposite issue, it is not present after this PR
#3278 - does not fix this, but allows it to be fixed in user code by overriding IOSApplication.getBounds and providing correct bounds
Note that I am not an iOS expert, but I have tested it and it works.

Any thoughts?

On which devices did you test it?

iPhone 4S and a few simulators. Testing on other devices with and without the fix to make sure that the problem is indeed present everywhere and this fixes it, is welcome.

Looks good, tested in iPad Mini as well.

Thanks!

Hey, I'm noticing some issues that I think are related to this on an old iPod 4 -- iOS 6.1.6.  It seems like touch coordinates remain in the portrait reference frame even after the display changes to landscape.  (I've never had the status bar visible in this app.)
There was certainly flakey behavior before related to orientation changes, but it generally worked.  After this, it seems like the display dimensions change more consistently/correctly on orientation change, but the touch coordinates are now consistently incorrect.
Any thoughts, or things I can check for?
Thanks.

This will be hard to test for, I don't have any iOS 6 device and I am not sure if I can get a simulator. So if you decide to debug it yourself I'll provide any help you need.
I guess that the problem will be in one of iOS methods called in getBounds() - Apple likes to change what some of the methods do, just slightly but enough to break everything between versions.

Ok, I've looked into this a bit further.  It appears that getBounds() is working correctly - the check for screenHeight > screenWidth there is catching the coordinate reversal.  (And this probably explains why the graphics do rotate correctly with this version.)
However, in IOSInput.toTouchEvents(), this line to get the touch coordinates
CGPoint loc = touch.getLocationInView(touch.getWindow());

seems to return the un-flipped version.  Or at least, if I touch the same part of the physical screen in portrait and landscape orientations, I get about the same x and y coordinates in loc.
It looks like this is maybe something that changed between iOS 6/7 and 8?
http://stackoverflow.com/questions/24150359/is-uiscreen-mainscreen-bounds-size-becoming-orientation-dependent-in-ios8
Any thoughts on the best way to resolve this?  I know it's probably not worth too much effort to keep supporting the older versions, but this is the only problem I've run across, and everything else is working well.
Thanks for the help.

Thanks for the investigation! Please try it with PR #3709 applied, if I am not mistaken it should fix it.
I can't get the simulator (only iOS 8 and 9) but I believe this issue applies to the iOS 6 and 7 (maybe later) so it is worth fixing. Too bad Apple tries so hard to break backwards compatibility.

Great, thanks for looking.  I'd like to try this out, but I'm not set up to build libgdx from source yet.  I should get that going...
These online docs seem a bit old, are they still accurate?
https://github.com/libgdx/libgdx/wiki/Building-libgdx-from-source
https://github.com/libgdx/libgdx/wiki/Running-Tests
In particular, is it still eclipse-only?  And is it known to be working on Mac?  (I know this shouldn't matter but it always seems to...)

Running (iOS) from source is somewhat complicated, I find it easier to:

Create your libGDX game project normally, with core and backend projects
Clone libGDX sources & apply PR
From game's iOS project, remove dependency on iOS backend (not natives!) and add transient dependencies of iOS backend explicitly (= robovm runtime)
Copy sources of RoboVM backend from libGDX repo to your game and compile it as part of your game, not as part of libGDX

I have found this easier than figuring out gradle, which I am not 100% familiar with, but you can try it if you are - if I remember correctly it should be possible to build libGDX via gradle only (or with maven and ant? that is what confuses me).

All right, I was finally able to test your commits in #3709.  It looks like this is on the right track, but it's not quite so simple.  The conversion isn't so easy as checking axesFlipped -- it depends on the actual orientation.  LandscapeLeft is different than LandscapeRight, and same with Portrait and PortraitUpsideDown.
To test I wanted to just get LandscapeLeft (home button on left) working.  I changed your code in toTouchEvents to the following:
{
    CGPoint loc = touch.getLocationInView(touch.getWindow());
    double x = loc.getX();
    double y = loc.getY();
    if (screenBounds.axesFlipped) {
        // note: this works for LandscapeLeft only!
        locX = (int)(screenBounds.x + screenBounds.width - y);
        locY = (int)(screenBounds.y + x);

        // LandscapeRight would be something like this:
        // locX = (int)(screenBounds.x + y);
        // locY = (int)(screenBounds.y + screenBounds.height - x);
    } else {
        locX = (int)(x - screenBounds.x);
        locY = (int)(y - screenBounds.y);
    }
}

With this code, I can confirm the touch events seem correct in both Portrait and LandscapeLeft orientations (although I don't fully understand the status bar stuff -- I'm not using it).  But they are still incorrect for LandscapeRight (because the transformation would be different as noted).
Let me know what you think!

I'm sorry to tell you but on my iPhone 3GS with iOS 6.1.6 everything was fine up to libGDX 1.8.0. When I upgrade to 1.9.x, x and y are flipped in my game (with landscape orientation).
My code looks like this:
Gdx.input.setInputProcessor(new InputAdapter() {
    public boolean touchDown(int x, int y, int pointer, int button) {
        Vector3 touchPos = new Vector3();
                touchPos.set(x, y, 0);
                camera.unproject(touchPos);
                x = (int) touchPos.x;
                y = (int) touchPos.y;
...

@MaxGyver83 I believe this is the same problem as reported by @rungkutta. I have been looking at the code and I understand how can it be broken now, but I don't understand why it wasn't broken before, the initialization of GLKView is pretty much the same and the touch coordinates are unmapped as before, only offsets are added, which does not explain the flipping.
Does anybody have any idea what happened/why did it break? I wanted to implement fix suggested by @rungkutta (thanks btw!) but now I am thinking that there is a different issue/easier fix to this and this would just band-aid it.

@Darkyenus , I've looked briefly at the changes, and I also don't see an obvious reason why this broke.  I wonder if it has to do with a change in RoboVM?
I first noticed this problem when upgrading my setup from libgdx 1.7.0 -> 1.9.1 and RoboVM 1.8.0 -> 1.12.0.  There seem to have been other changes related to orientation; in particular, switching from landscape to portrait and back is much smoother (looks like a normal iOS app) in the newer version.  And while the touch coordinates generally seemed to work before, it wasn't 100% consistent.  There were times that I had to rotate back and forth between landscape and portrait to get everything (including both touch coordinates and graphics coordinates) working right.

I don't think that this is caused by RoboVM, they provide just a wrapper around iOS API.
I have created a diff of things that have changed since 1.7.0 in RoboVM backend and there isn't anything that stands out as a culprit.
There is a change in how the backend is build near the top, which I don't fully understand but I doubt that this could cause this. GLES3 has been added but is disabled by default and the same codepath is taken for GLES2, so that can't be it. My bound calculation is just getters, so that should be fine.
GLKView creation has been changed slightly (the CGRect calculation) but I believe that the values actually passed are still the same, so that should be fine, but may be worth investigating. Rest are changes in input handling and stubs.
And finally, what I think has the biggest probability of being problematic, is that instead of didRotate we now override viewDidLayoutSubviews in IOSGraphics.java. Can you perhaps try moving the code from viewDidLayoutSubviews to didRotate and see what happens? Also note that the original didRotate had super.didRotate(), try it with and without that, maybe there is a default behavior, somewhere?
I have tried running old Xcode to be able to test on old simulators, but that didn't work, so I'll probably have to try it on a virtual machine. Thanks Apple.

Hey, check out this change in toTouchEvents that I noticed when browsing through your diff:
Old: CGPoint loc = touch.getLocationInView(touch.getView());
New: CGPoint loc = touch.getLocationInView(touch.getWindow());
If I switch this line back to use getView instead of getWindow, the touch coordinates seem to work fine again.
I'm not sure about all of the implications of this, and whether it was changed for a reason or not, but it seems to fix the problem at least on my old iOS 6 setup.

Good catch! So the axe flipping is not needed anymore after this?

Yeah, not in IOSInput.  Still needed in getBounds() though.

Ok, can you please try again with #3709 applied? I have amended the commits and it should be fixed, I don't know what it was using window instead of view, probably a mistake. And thanks for help!

Yes, this one works for me.  Thanks!


Training on own dataset

thanks for the great work, I wish to train the network on Berkeley deep drive dataset where we have 2d bounding boxes in json files.
what would be the steps? is there a data converter available? I am trying to get the dataset in pascal voc 2012 format
thanks

I am trying to do the same. Have you found a way to adjust the code?

What I did was convert the ground truth labels to .xml format, maintaining only the unique labels (not even including bounding box locations). Then, in the create cls_labels.py script, I changed the labels, but maintained the amount of 20 (just having empty labels). That worked for me.


Implement currentOp command

What should be done?
There are a lot of fields and information returned by currentOp.

https://www.mongodb.com/docs/manual/reference/command/currentOp/#currentop

See https://github.com/FerretDB/FerretDB-heliodb/issues/760


no volume plugin matched

kubelet logs :
103 06:53:29.806530  190354 desired_state_of_world_populator.go:293] Failed to add volume "ibm-ubiquity-db" (specName: "ibm-ubiquity-db") for pod "c07690ad-0f1d-11e9-8f3d-02460f1666cd" to desiredStateOfWorld. err=failed to get Plugin from volumeSpec for volume "ibm-ubiquity-db" err=no volume plugin matched
E0103 06:53:30.224316  190354 desired_state_of_world_populator.go:293] Failed to add volume "ibm-ubiquity-db" (specName: "ibm-ubiquity-db") for pod "c07690ad-0f1d-11e9-8f3d-02460f1666cd" to desiredStateOfWorld. err=failed to get Plugin from volumeSpec for volume "ibm-ubiquity-db" err=no volume plugin matched
E0103 06:53:30.799114  190354 desired_state_of_world_populator.go:293] Failed to add volume "ibm-ubiquity-db" (specName: "ibm-ubiquity-db") for pod "c07690ad-0f1d-11e9-8f3d-02460f1666cd" to desiredStateOfWorld. err=failed to get Plugin from volumeSpec for volume "ibm-ubiquity-db" err=no volume plugin matched
E0103 06:53:31.197135  190354 desired_state_of_world_populator.go:293] Failed to add volume "ibm-ubiquity-db" (specName: "ibm-ubiquity-db") for pod "c07690ad-0f1d-11e9-8f3d-02460f1666cd" to desiredStateOfWorld. err=failed to get Plugin from volumeSpec for volume "ibm-ubiquity-db" err=no volume plugin matched
E0103 06:53:31.610505  190354 desired_state_of_world_populator.go:293] Failed to add volume "ibm-ubiquity-db" (specName: "ibm-ubiquity-db") for pod "c07690ad-0f1d-11e9-8f3d-02460f1666cd" to desiredStateOfWorld. err=failed to get Plugin from volumeSpec for volume "ibm-ubiquity-db" err=no volume plugin matched
E0103 06:53:32.004693  190354 desired_state_of_world_populator.go:293] Failed to add volume "ibm-ubiquity-db" (specName: "ibm-ubiquity-db") for pod "c07690ad-0f1d-11e9-8f3d-02460f1666cd" to desiredStateOfWorld. err=failed to get Plugin from volumeSpec for volume "ibm-ubiquity-db" err=no volume plugin matched
and the kubelet-plugins
root@gpu05:/usr/libexec/kubernetes/kubelet-plugins/volume/exec# ls ibm-ubiquity-k8s-flex/
ubiquity-k8s-flex  ubiquity-k8s-flex.conf
root@gpu05:/usr/libexec/kubernetes/kubelet-plugins/volume/exec# ls ibm~ubiquity-k8s-flex/
ubiquity-k8s-flex  ubiquity-k8s-flex.conf
root@gpu05:/usr/libexec/kubernetes/kubelet-plugins/volume/exec#

hello @694982827
Could you please provide more detail?
Which version did you installed? on which storage system?  k8s version?  OS version?
In addition, please provide logs if you can.
Also please make sure you use the official documentation -> https://www.ibm.com/support/knowledgecenter/en/SSCKLT/landing/IBM_Storage_Enabler_for_Containers_welcome_page.html
Thanks
Shay

Hello @694982827
Could you please provide more details?

No activity for 3 months.
Closing this issue.


HA IP address to Owner Port ID association

Introduces the DB changes required to support this. Since this
is the first DB schema related addition to this repo, the alembic
DB migration related artifacts also are being added here.

Need to update the RPM/Debian packaging scripts to run the DB migration script as post-install step. For examples, see:
https://github.com/noironetworks/gbp-rpm-spec/blob/master/group-based-policy/rpm/openstack-neutron-gbp.spec.in#L42
https://github.com/noironetworks/gbp-rpm-spec/blob/master/group-based-policy/debian/group-based-policy.postinst
Are you going to do that as a separate change?

The RPM/Debian packaging script changes are in a different repo, and should be made only after this change is made. How can they be made part of this change? Am I missing something?

The packaging scripts for ml2 driver are in tree, see the directories named
'debian' and 'rpm'
On Oct 20, 2015 6:20 PM, "Sumit Naiksatam"<EMAIL_ADDRESS>wrote:

The RPM/Debian packaging script changes are in a different repo, and
should be made only after this change is made. How can they be made part of
this change? Am I missing something?
—
Reply to this email directly or view it on GitHub
https://github.com/noironetworks/apic-ml2-driver/pull/11#issuecomment-149751797
.

Okay added the packaging scripts' related changes as well. I read your earlier comment to mean that the packaging scripts are in a separate repo. Thanks for the pointer!


⚠ Bofrost.de has degraded performance

In 7b94737, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 997 ms

Resolved: Bofrost.de performance has improved in 3fec70f.


fix [GitHubIssues] service test

Fixes #6105
Seems the upstream repo and associated package have been yanked from the internet. I figured it would be easier to just create my own repo with a label to match the original case/bug report instead of perusing GH to find a repo that had the same type of label

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @calebcartwright!

  Generated by :no_entry_sign: dangerJS against e90da0b4fff03b093104ad8fc9aa696238b8fcd0

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @calebcartwright!

  Generated by :no_entry_sign: dangerJS against e90da0b4fff03b093104ad8fc9aa696238b8fcd0


Individual consumer groupIds

Question: Would there be a good way to pass a consumer groupId on each subscription? This would allow those who's connection was broken to reconnect and get missed events.
Similarly, is there a good way to specify a topic on publish and to consume from, such that we could publish and consume from multiple topics?

@cramhead I was actually forced to rewrite this library to support it couple times with different approaches. Using single topic seems to be antipattern etc. however multiple topics bring another set of challenge.
There is easy workaround for it which is to create different pubSub engine for each subscription for object. This however doesn't resolve problem of ignoring client side ids and reconnecting.
When we use multiple topics we will need to organise data around events we support. This might be something like:

topic per database model (debezium can create those)
topic per resolver group (app creates those)
event update topic

All of this has very strong correlation to implementation. For example if our subscription supports fetching relationships and we have topics per model we need to do stream processing - joins etc.
For context. I'm one of maintainers of https://offx.dev that gives offline support and delta queries. We have tried to build generic kafka solution that works but it is hard to not be opiniated - that is why we do not have upstream library like for mqtt https://github.com/aerogear/graphql-mqtt-subscriptions

@cramhead @ancashoria if we would come with generic solution for this problem together I'm happy to PR this repository or.. create separate library to cover it.

@wtrocki sound good. I'd like to contribute where I can.
I'm relatively new to the whole Kafka world so I'm sure it will be a learning experience.
It would seem that many of the wants around features like multiple topics and reconnection for missed events are really around managing mappings between clients and connections. I'm under the impression that the Kafka client does much of this and would really just need to make sure the inputs are appropriate such that it can perform its functions. For example, we need to provide the consumer group id and the Kafka client will take care finding the events that haven't been delivered

@cramhead I would love us to discuss which of the approaches I have pointed out to you above would be more appealing - contributing can come next.

For example, we need to provide the consumer group id and the Kafka client will take care finding the events that haven't been delivered

So each client (web) has their own consumer group and you have some topics structure that they can connect with. How about using plain SSE instead of GraphQL. It sounds like GraphQL would give us number of problems (as we cannot relatively mitigate reconnection offset and most of the client side subscriptions libraries doesn't handle that nice so we would not only need fix entire server but also rewrite some bits of the graphql-subscription libraires.

@wtrocki excellent idea. Better to understand the problem and approaches clearly, before implementing anything and choosing a single problem is much simpler than trying to solve all problems at once..
Thinking SSE vs GraphQL. I think that GraphQL is agnostic to the transport mechanism. I think there are implementations that use websockets (standard) and some that use SSE (new/prototypes). The user needs to be able to subscribe whether it's delivered by SSE or GraphQL. I think that SSE has a number of good advantage and the lack of options and standard approaches is the only thing holding it back. That could be changing https://wundergraph.com/blog/deprecate_graphql_subscriptions_over_websockets. At the end of the day I think that GraphQL provides a "standard" way for consumers to subscribe and builds on expectations that consumers have on around strong typing, setting boundaries of what needs to be fulfilled, but allowing the backend to do so it whatever way is best, ....
Regarding consumer groups and reconnection, I'm thinking that there is a connect and disconnect event can be used, https://www.apollographql.com/docs/apollo-server/data/subscriptions/#lifecycle-events. The connect would used to identify the user, as they would be passing in some sort of identity token, e.g. JWT. So by the end of the connect call you have an authorized user, but that user will have multiple subscriptions, this implies multiple consumer groups. I expect each consumer group is mapped to a specific topic. If the same user, i.e. identity, connects with independent subscription, e.g. the same user connecting from multiple devices, they would have the multiple consumer groups so some other info would be needed to identify their consumer groups. It may be best to deal with that topic separately.
I expect after the user is identified the client request continues to make call to the subscribe function. There could be many steps here, but I'm totally unaware. This function needs to be able to pass in consumer group information as well as topic information. I expect this is where graphql-kafka-subscriptions plays prime role. It would be taking care of passing that info the client so it could do something like below.
For example:
Sorry I don't know much node-rdkafka, but expect it can do all https://github.com/tulios/kafkajs  can do.
const consumer = kafka.consumer({ groupId: 'test-group' })
await consumer.subscribe({ topic: 'test-topic' })

I'm not entirely sure how that data would be passed in while still adhering to the interface provide by https://github.com/apollographql/graphql-subscriptions/blob/master/src/pubsub-engine.ts

Amazing response. I'm going to take look into this
I would start with some diagrams and see if there is easy and reliable way to do it


Sometimes the DOM is not ready for interaction after a rerender

This was observed for the incremental rerender of the Citepanel, which I just activated. In order to scroll to the selected targets I I call _scrollToTarget on didMount and on didReceiveProps. Maybe we hit a limit of our synchronous rendering... I hope not!
Reproduce:

Open Lens Writer
Click on a bibref (panel scrolls to the first target)
Click on another bibref (-> panel does not scroll to the target sometimes)

See: https://github.com/substance/substance/blob/7b31f182bcbce016c914989879efc936c8ee8bb2/ui/Component.js#L470-L473
And: https://github.com/substance/lens/blob/dev/packages/citations/CitePanel.js#L66-L73

Good news. Sync rendering works fine. Just once again the CSS messed it up. When working with scrollable panels we always have to make sure we have the following structure:
div.sc-panel
  div.se-panel-content (overflowing container)
    div.se-panel-content-inner (this has position: relative set, which is important to capture the position().top relative to that element.

Need to think of ways how we can make this more explicit. Maybe we really need some kind of wrapper panel ScrollablePanel that provides the markup instead of having that convention. It's really easy to overlook.

Closing in favor of #274.


HUD is upside down / inverted

So I've got a strange issue that I can't figure out: all the HUD UI is being rendered upside down.
The menu UI is correct, but the text on the loading screen is not formatted correctly.
The spawn menu is correct, but the spawn map is all distorted.
I'm running the latest 1.7.0 Shader Patch and have tried several options but none of them have fixed this issue, at least not without creating other aspect issues. I'm running a 32:9 display and everything is working and rendering correctly, except for the HUD.

Fixed (kind of) in v1.7.1.


add support for svc backend

Adds LoadBalancer service as part of the backend for K8GB. Relate Issue is: https://github.com/k8gb-io/k8gb/issues/147

HOW TO RUN CI
---
By default, all the checks will be run automatically. Furthermore, when changing website-related stuff, the preview will be generated by the netlify bot.
Heavy tests
Add the heavy-tests label on this PR if you want full-blown tests that include more than 2-cluster scenarios.
Debug tests
If the test suite is failing for you, you may want to try triggering Re-run all jobs (top right) with debug logging enabled. It will also make the print debug action more verbose.

Hi @tanujd11 ! Do you plan to finalize this PR?

Hi @tanujd11 , do you want to update this PR after we got #1557 implemented? Thanks a lot!

I will close this PR as the codebases progressed heavily since then. Thanks a lot for the contribution attempt, I really appreciate it!


Wrap unit tests where necessary in Act

Some tests are logging out errors saying that the unit test needs to be wrapped in Act (I thought this was implemented in React Testing Library by default), but having done a few locally it seems that wrapping the unit tests does fix this. With Enzyme I normally wrap these in Act and it fixes the issue, and it seems this is the case in React Testing Library too.
Since 16.9.0: https://reactjs.org/blog/2019/08/08/react-v16.9.0.html - await act(async () => { can now be used to fix these messages.

Closing.


Add descriptions for dictionaries.json

https://github.com/tyarkoni/pliers/blob/a8d675b15e232b0d9c4dbe39307ecc32aeab8a34/pliers/datasets/dictionaries.json#L11
Some of the Predefined Dictionaries don't have descriptions, and they are buried in the source. Adding descriptions would make these much more useful.
For valence, I found the following, which explains their nomenclature:

Every value is reported three times, one for each dimension, prefixed with V for valence, A for arousal, and D for dominance. For each word, we report the overall mean (Mean.Sum), standard deviation (SD.Sum), and number of contributing ratings (Rat.Sum). We also report these values for group differences, replacing the suffix .Sum with the following (.M = male; .F =
31 female; .O = older; .Y = younger; .H = high education; .L = low education). Words are presented in alphabetical order

For aoa:

For each word, we report the number of times it occurs in the trimmed data (OccurTotal). For most words,
34 the count is about 19. However, for the 10 calibration words and the 52 control words, this amounts to more than 1,900 presentations. Next, we provide the mean AoA rating (in years of age) and the standard deviation (Rating.Mean and Rating.SD). We also present the number of responders that gave numeric ratings to the word, rather than rated it as unknown (OccurNum). This information is useful, because it helps to avoid using unknown words in psychological experiments and indicates the degree of reliability of the mean AoA ratings. Finally, we add word frequency counts from the 50 million SUBTLEX-US corpus (Brysbaert & New, 2009). Words are presented in the decreasing order of frequency of occurrence. The 574 words that were not present in the SUBTLEX-US frequency list were assigned the frequenc

For concreteness:

he word 2.Whether it is a single word or a two-word expression
3.The mean concreteness rating 4.The standard deviation of the concreteness ratings 5.The number of persons indicating they did not know the word 6.The total number of persons who rated the word 7.Percentage participants who knew the word 8.The SUBTLEX-US frequency count


Really blocking calls?

I would love to have real call blocking, the way it worked many years ago. But does this app really stop callers from connecting, or does it only stop my phone from ringing?
The most obvious difference is that when a call is truly blocked, it's impossible for the caller to leave a message. It also means the caller will never know if my number exists, because they are rejected before being allowed to connect, not after.

The call is not truly blocked, it's just rejected, as if being manually rejected by pressing the "reject" button.

Bonjour davidpiano,
I'm surprised by your expectation based on an app.
As soon as the app filters calls that reaches the phone, you'll have no other choices than managing it manually or automatically with what your phone network provider delivers.
For my own culture, can you share how you were blocking phone numbers many years ago?
From my knowledge perspective, if you'd like a phone to be blocked before it reaches your device, it has to be filtered at network level not device level.
I remember very long time ago that we had such type of blocking feature using phone codes on fixed home phones but it wasn't ported on mobile services in my country.
There was very few service that were maintained on French mobile networks.
I remember I was able to disable/enable voicemail using a phone code, allowing me to never miss a call due to slowliness...
We still have such network level services active but they are very limited today (show phone number, call transfer, forbidden outgoing calls, etc...), however they're maybe still existing in you country area.
You can have a look on that from your phone by checking additional parameters.
They'll be listed in a very slow manner because it's a negotiation between your phone and the network provider to list all available ones and their setting options.
Additionally, I have an SIP phone number that I use when I'm foreign traveling or when I want to drop someone to a phone line that I never consult...
It can be managed at network level from a web interface and I can do everything from there.
For example, I can deactivate the phone line to react to any call or just some phone numbers and decide to not allow these numbers to end in a voice mail or make the phone ringing at all as if the phone number was wrong or not attributed.
You maybe have something similar as this configuration center available but for mobile phone lines?
Waiting for your answer as I'm interested in how things were managed from your side.
Thank you for your attention.

I think the way they used to do it was the filter app would answer the call and then immediately hang up, that way the caller never got sent to voicemail.

I think the way they used to do it was the filter app would answer the call and then immediately hang up, that way the caller never got sent to voicemail.

Interesting approach, I've been googling for a while, tried apps like AutoAnswer and MotoAnswer, none of them works, tested on Android 10 and 14, it's just ringing and not get answered.
Please let me know if there is any app that actually works, no matter opensource or not.

I was talking about much older forms of call blocking, which truly did stop unwanted callers from successfully dialing your number. The caller would get only a phone company's recorded message "We are sorry, your call could not be completed" or that type of thing.
I believe (at least where I am) this older and better kind of call blocking does not exist anymore, and it has probably been gone for a long time. But when I read the description here, it gave me hope - for a moment. :)

The best call blocker ever was the one built into the Cyanogen Mod roms. The next best was Calls Blacklist Pro. Both blocked anything not in your contacts from calls and texts. Calls would get rejected and you could have them sent to voicemail or just hang up. But either way, you didn't get notifications.

Now it's supported in the latest tag, the Silence Call has been replaced with Block Mode, with a new mode "Answer and Hang up", also available in the per rule setting.

It works perfectly on android 10 emulator, but on android 14 it behaves randomly, I'm trying to figure out why, plz use other block type for now.

Now it should work, but there are drawbacks:

the lockscreen will be turned on for a while
it plays a call end tone, some phones have options to mute this sound.
vibration, this can be disabled in system settings.

I can't find a way to solve them programmatically, this seems to be the closest to the "real blocking", I'm closing this for now.


feat: build ussuri release on core20

Building on core22 causes errors starting python-tempestconf
To be merged after #39

Test build on various archs.


Dashed line rendered solid in Chromium

Page 2 of this PDF contains dashed lines, which are rendered solid in Chromium 43 using this this online demo of pdf.js, but fine in Firefox 38.0.
How it is rendered in Chromium:

Same page in Evince:

According to #1012, a similar issue was going to be fixed with #2429, however I'm not sure if this is the same issue here.

I reduced the test case using the technique that I documented at https://github.com/mozilla/pdf.js/issues/5043#issuecomment-48972506.
This is a recent bug in Chromium (since version 43):
https://code.google.com/p/chromium/issues/detail?id=505912

This is a recent bug in Chromium (since version 43)

The linked bug affects versions starting from at least 34. It was marked as a duplicate of a bug that is from July 2013.
So shouldn't either earlier Chromium versions be affected as well (I haven't tried) or is this a different bug?

@pcworld The bug from my previous comment was filed 25 minutes ago by me. I only referred to the other bug at PDF.js to explain how I created the reduced test case (in case you want to create one yourself, in the future).

@Rob--W Sorry, I mixed up the issue tracker links then.

@Rob--W This seems to have been fixed upstream. Could you verify this and close the issue if it is indeed fixed?

@timvandermeij This has indeed been fixed upstream and merged back to 44, but not 43. I've verified that the bug has been fixed in 46.0.2455.0 (and therefore also in 45 and 44).
Within a few weeks, Chrome will upgrade to 44. Since there's nothing that we (as PDF.js devs) can do to fix this issue in 43 (except for patching the .save/.restore methods), I'll close the bug.


[Menu] Make Fixed Menu Collapsable

Hi,
Having a collapsable fixed menu is something of a must have with the rise of phones. Something similar to Bootstrap's collapsable navbar or Foundation's top-bar would be great.
http://getbootstrap.com/components/#navbar
http://foundation.zurb.com/docs/components/top-bar.html#

Is there a time frame when this might possibly be implemented?

I would say after #1571.

+1
I'm using the sidebar component in the meantime, but this is definitely a staple now.

+1

+1

:+1:

+1 Would also love to help in the implementation if needed.

+1

+1

+1

+1

+1

+1

really beautiful css framework !
much appreciate your work , thank you!

1 for this :)

This is something I would love to see as well. Do not want to load a separate menu just for this.

+1 framework good like this one deserves it

:+1:  I notice that when you use stackable menus in 2.0 with the tab feature on mobile the menu just makes the tabs not viewable making the whole site non mobile friendly.

+1

+1 for stackable collapse menu

+1

+1 for me too.

+1

Sad to be one more to add a +1 here, with the issue having almost hit its second aniversary. This seems such a mandatory feature for nowadays mobile needs. I tried to implement something similar using mobile only/computer only classes but they only work for rows/columns, and messed a lot with the menu classes. Please, take a look at this! :(

I use bootstrap navbar unfortunately

Isn't it too much overhead to use both frameworks? Or did you manage to
extract only the navbar from bootstrap?
On 18 Sep 2015 05:18, "Mahdi Majidzadeh"<EMAIL_ADDRESS>wrote:

I use bootstrap navbar unfortunately
—
Reply to this email directly or view it on GitHub
https://github.com/Semantic-Org/Semantic-UI/issues/157#issuecomment-141378624
.

At the core of this issue in my mind is - what is the architecture decision in Semantic to handle this using either - mostly responsive solution or event / JavaScript to handle it? I need to pour over docs to see if I can determine, identify that...
This is one example of something needed, there are plenty more like this - but, they all should follow the same core tenets of the Semantic UI way...
And should this be more of how you form a "recipe" to use many Semantic elements combined to form a more strict component like this?

yes, only bootstrap nabvar
[image: Restro Co] http://restro.ir/
Mahdi Majidzadeh / Web developer
<EMAIL_ADDRESS>/<PHONE_NUMBER>0
Restro Co
http://restro.ir
[image: Facebook]  https://facebook.com/mahdi.majidzadeh[image: Twitter]
https://twitter.com/mahdimajidzadeh[image: Google Plus]
https://plus.google.com/mahdimajidzadeh[image: Linkedin]
https://inkedin.com/mahdimajidzadeh[image: Instagram]
http://instagram.com/mahdimajidzadeh
On Fri, Sep 18, 2015 at 7:04 PM, Igor Santos<EMAIL_ADDRESS>wrote:

Isn't it too much overhead to use both frameworks? Or did you manage to
extract only the navbar from bootstrap?
On 18 Sep 2015 05:18, "Mahdi Majidzadeh"<EMAIL_ADDRESS>wrote:

I use bootstrap navbar unfortunately
—
Reply to this email directly or view it on GitHub
<
https://github.com/Semantic-Org/Semantic-UI/issues/157#issuecomment-141378624
.

—
Reply to this email directly or view it on GitHub
https://github.com/Semantic-Org/Semantic-UI/issues/157#issuecomment-141470412
.

+1

+1 for all +1s

+1

+1

+1

+1

+1

+1

+1

This is crucial deciding factor to use between semantic and bootstrap. +1 for this feature and hopefully it will get added to the framework.

Not relating to collapsing, but the "right menu" comment from @raniglas:
Inserting an empty "right menu" div prior to menu items I wanted to have on the right, ended up with a reasonable mobile stacked menu. Open to any suggestions on alternatives.

  Left Item 1
  Left Item 2

  Right Item 1
  Right Item 2

Hi, I found an implementation of this feature here http://codepen.io/anon/pen/zrBBoa
It will be awesome if you incorpore that in the sources.

+1, hacking my own collapsible menu makes Semantic-UI a much less attractive option.  I like Semantic's styling more than Bootstrap, but that collapsible menu is a crucial piece of any responsive, mobile-ready UI framework.

Any news according to this feature?
I still run semantic ui 1.x, waiting just for this for  upgrading the libs. The menu in 1.x is much more responsive than the one in 2.x.

+1

+1 This helped me: http://ehkoo.github.io/semantic-ui-examples/navbar/

agreed, but you can not expand and collapse the drop-downs in that solution when in mobile view.

I'm very surprised that after more than 2 years, this still isn't implemented... :+1: for this issue.

+1

+1

+1. Collapsable menu is a kinda must.

+1

+1

successfully migrated back to bootstrap, collapsible menu works very well there. thanks for the good time with semanic ui! will watch this issue to be informed when it will be done. hopefully it will not hit its 3rd anniversary. best regards.

:wink:

+1

+1

+1

+1

+1

+1

The amount of vitriol i've received about this particular issue...

Well it is the second most commented open issue on the repo, and the first one at least has a piece of quality code which just needs to get merged to master...

@jlukic  Have you considered using a checkbox to work around the javascript requirement? The checkbox could hold the opened/closed state and toggle CSS classes (example). I don't know if you're still against using javascript for the collapsible functionality (as per the original response to the issue).
There is a pure javascript solution(?) floating around in the internet, but I'm not sure this is the right way to go, has anyone else worked this out?
Btw, thanks to the devs for the awesome work! Consider all the guys asking for this feature as people who don't want to use other frameworks!

+1

I think an external plugin for a collapsible menu should be made available. Semantic UI beats Bootstrap for me - I was just about to redesign my whole site - but the lack of the menu has made me reconsider :(

Just use a separate menu for mobile and show it using media queries.

+1

+1

Check #1114

+1

+1

+1

@jlukic Isn't stuff like this kind of the point in using a framework? :confused:
For me this seems to be a strange response in light of my remark... would you be willing to let us know the reasoning here? :smile:

Just use a separate menu for mobile and show it using media queries.

+1

+1 (otherwise much nicer than bootstrap in my opinion)

+1

+1

Just use a separate menu for mobile and show it using media queries.

why can't you build this in like columns? where we can do for example
sixteen wide tablet twelve wide computer column
I want to show fixed menus on both mobile and desktop but when showing on mobile it cuts off any menu items which are too wide, I simply want the text labels to disappear on mobile so only the icons show, this way I can at least show 5-6 items...

:+1: +1

It's been more than 3 years and because of this task Semantic.ui seems the worst framework to work with.

That's an exaggeration.  A workaround exists.  Use a separate menu for mobile and show it using media queries.

It's possible to achieve but i'm more interested in getting the collapse/expand from this mobile version menu to animate instead of appear, similar to 'ui sidebar's bottom push'.
Any idea how to achieve this?

An UI Framework with 27k stars that doesn't support a basic collapsable menu is okay, but my response is an exaggeration.
Funny world.

Can this be achieved using an accordion and triggering it from the menu icon?
I cannot seem to get it working but maybe someone can give it a try. :-)

been 3 years...

It's really strange that Semantic UI don't offers a simple responsive menu.

http://ehkoo.github.io/semantic-ui-examples/navbar/ - here is an example of collapsable navigation bar, but it requires rendering menu items twice.

@ivantcholakov , All responsive design philosophy is do every thing once!!

+1

http://chineque.com.br/labs/navbeer/ - another example, the menu is to be rendered only once.

After a week of trying out Semantic UI I am ditching it and going back to Bootstrap. This issue coupled with lack of always open sidebar makes this a pretty painful framework to work with.

I'm sorry that you're leaving SUI. There is a collapsible menu but it is quite limited in scope. There is generally no way to support the full features of menu for mobile  in a consistent way without a large amount of css code duplication.
I do think however the downsides to including separate html to render your mobile menu is negligible. Generally you'll want to organize the links in a different way, use different styles and remove items for mobile.  The only downside to including it twice is 'lack of elegance' which I can understand how would upsetting for devs and a few more text over the wire.

"If Collapsable Menu is the answer, you're almost certainly asking the wrong question."
Bootstrap brings many bad practices and Collapsable Menu is one of it, it's actually a wrong design what you should do is use Sidebar instead.
By the way Google is using Sidebar instead of the "Collapsable Menu" most of the time.

If you really want to keep your menu then make it horizontally scrollable (Bulma did this in their UI Framework) with overflow-x: scroll;.

Confused about this.
Can there at least be a solution and explanation in the docs?

Is there any good practice using semantic UI to make menu good on mobile phone?

+1

@tarvos21
http://iridadesign.com/starter-public-edition-4/www/ - see the blue top menu, extract the HTML using your browser. This is what I am capable to have for now.

@ivantcholakov
good solution, I seems to work, thanks for sharing!

Still waiting for this

+1

+1

Please use GitHub reactions instead of just posting +1.
🥂

Just for those in need I have come up with a workaround, here is the code. It is simply a ui simple dropdown item that works on mobile and no JS required. I know it is not the same but this might help someone.
`

SITENAME

Menu

item

`

Since this feature obviously isn't going to be implemented (it's been over three years), can you perhaps include a section in the docs (menu maybe?) explaining how to create a mobile-responsive navbar with media queries?

👍

Dumbledore: "After all these years?"
 Double the effort for something that should ease the process.
+1 (Will revisit S.UI if added in future RCs)

+1

Here is a solution that behaves like Bootstrap and does not require a second set of menu items.  It requires just a tiny bit of JS and CSS.
The JS:
$(function() {
// Set up to handle wrapping of tab menu (tab actuator) items
    $(window).resize(function() {
      checkIfWrapped();
    });

    checkIfWrapped(); // Make sure the function is fired upon document ready
});

// Detect whether a Semantic UI tabular menu is wrapped
function checkIfWrapped() {
    var pos_top_1st = $('.tabular.menu .item').first().position().top;
    $('.tabular.menu .item:not(first-child)').each(function() {
        var pos_top = $(this).position().top;
        if (pos_top > pos_top_1st) {
            $(this).parent().addClass('wrapped');
            return;
        } else if (pos_top == pos_top_1st) {
            $(this).parent().removeClass('wrapped');
        }
    });
}

The HTML structure.  (Note that placing the .tabular.menu .item-s  inside a div within the overall .tabular.menu allows the use of a separate .right.menu within the .tabular.menu if desired) :

                   Add Job
                   Copy Item

The CSS:
#qj-tabs {
  display: flex !important;   /* Will not work unless defined as display: flex */
  flex-direction: row !important;
  flex-wrap: wrap !important;
}

#tabs-menu .wrapped .item {
  border-radius: 5px !important;
  border: 1px lightgray solid !important; /*  Just styling for the default theme here */
  margin: 0 2px 2px 0 !important;
}

Thanks to [Mr. Boris](http://stackoverflow.com/users/5246900/mr-boris) for the [answer here](http://stackoverflow.com/a/40017186/5548239) that got me started on this solution.

@jlukic
Would love to see a solution for this issue.
Thank you

Any working solution on this issue yet?

@andrewoko-odion Doesn't seem like there's much being done about this, it has been opened since 2013 and yet no solution right out of the box. Only shared code to try and imitate the behavior which i still refuse to make use of if i don't need to when something so simple and required this days should be already be implemented on the framework itself.

Absolutely agree with DualPixel
+1

As much as I like Semantic, I gotta say that this is a deal breaker for me. As soon as this gets fixed, I'm all in.
+1

+1

+1

@CanadianEngineer, @pierre-H You might want to look at the solution I posted on March 28th just above here.  It's really easy to implement.  I do agree that this needs to be implemented into the main library though.

Any working solution on this issue yet?

+1

Wow! I really don't understand why the core team of semantic ui don't want to consider a responsive menu. This should have been a great framework to compete well enough with Bootstrap but the lack of support for responsive menu is just so painful. @jlukic should see that this feature is one which everyone wants and then make it a priority, please!

@Pythonian totally agree! +1

Same for me, I really enjoy semantic ui but this function should be native since a long long time...

Waiting, please implement + 100000000

+1

+1

+1
It is a must nowadays

1 I'm not as vehemently opposed as some to having two separate layouts for a menu (using React makes creating that not too much of a chore and maintains just a single source location). However, I'd agree that this should really be consider a necessity for a modern, full-featured suite of styling tools such as Semantic.

+1

After 4 years getting "+1" mails from this thread I'll mute this now. Anyway, bye!

SUI newbie here:
Really, guys, if you don't want to complicate something in your code because of adding responsive menu, so just write and add some right example of responsive menu with semantic-ui to your docs. Why did you chose to confuse your community with such answers like "just add another menu". You could just explain your point of view in your docs. Tell to everybody why it's a goodness to have a two separate menus for mobile and wide-screens. Then add working good example and close this issue. What's a problem? Why did you prefer to have opened 4 year old issue?

+1

@finferflu @dawidsappich @AshleyMcVeigh @Gino @guihatano  Please use GitHub reactions instead of just posting +1

@nextgensparx I did use the reaction, but then I saw that a lot of people were doing it, so I assumed that was how it worked. Sorry about that.

any working sample repo? It's easy to make grids device visibility responsive but it's hard when you display icon and try to show/hide menus. tsk

+1

+1

+1


problem setting FFTWDIR

This env variable is supposed to be taken into account here
https://github.com/LSSTDESC/CCL/blob/6b8f0af672098e55c151b53c9a53789de46d7176/cmake/Modules/FindFFTW.cmake#L20
in order to let the user provide a path to an existing FFTW installation. I am using cmake 3.14.5 and this does not work : ENV(FFTWDIR) is not properly evaluated in the condition, as a result FFTW_INCLUDES is found as /usr/include which confirms that FFTWDIR was not taken into account. The following change (explicit evaluation of the env var) works for me:

[tanugi@cca001 build]$ git diff ../cmake/Modules/FindFFTW.cmake
diff --git a/cmake/Modules/FindFFTW.cmake b/cmake/Modules/FindFFTW.cmake
index f885438..d82ed98 100644
--- a/cmake/Modules/FindFFTW.cmake
+++ b/cmake/Modules/FindFFTW.cmake
@@ -17,7 +17,7 @@
\ #
include(FindPkgConfig)
#If environment variable FFTWDIR is specified, it has same effect as FFTW_ROOT
-if( NOT FFTW_ROOT AND ENV{FFTWDIR} )
+if( NOT FFTW_ROOT AND NOT "$ENV{FFTWDIR}" STREQUAL "")
set( FFTW_ROOT $ENV{FFTWDIR} )
endif()
# Check if we can use PkgConfig

Then of course ANGPOW compilation also fails as it downloads https://github.com/LSSTDESC/Angpow4CCL/blob/master/cmake/Modules/FindFFTW.cmake which has the same problematic line for me.

@johannct could you see if this happens again for you with the new CCL v2? Note angpow is temporarily deprecated in this version. Docs for installing v2 are here: https://ccl.readthedocs.io/en/v2.0.0/source/installation.html

@johannct any update on this?

OK, last chance! We'll close this in a few days unless someone tells us not to!

Closing this as stale/couldn't reproduce. Feel free to reopen if this problem ever appears again.

Closing this as stale/couldn't reproduce. Feel free to reopen if this problem ever appears again.


cleaner: add type specification to methods

cleaner: add type specification to methods

Completed and merged in PR #158 !


option to configure archetype (e.g. dbType)

For maven archetype we are currently support devon4j-template-server, but also others could follow. For convenience we are not passing the arguments 1:1 to maven but instead derive artifactId and package automatically if omitted, what makes life much easier.
However, this prevents to provide other custom arguments and currently dbType is even hardcoded:
https://github.com/devonfw/devon-ide/blob/3b098ce7188a137e7a1bd8a45455f4f10280c2f5/scripts/src/main/resources/scripts/functions#L487
Instead it should be possible to provide e.g. any "-Dkey=value" property and the bash function shall e.g. detect any arg starting with a dash/hyphen and consider it as an argument to pass 1:1. So in other words I could do:

devon java create com.example.demoapp
devon java create com.example.demoapp -DdbType=oracle -Dbatch=batch
devon java create com.example.demoapp com.example demo-app -DdbType=oracle -Dbatch=batch
Maybe we should even be tolerant and allow mixing:
devon java create -DdbType=oracle com.example.demoapp com.example demo-app -Dbatch=batch

Also the documentation and help should improved (and is not up-to-date anyway):
https://github.com/devonfw/devon-ide/blob/master/documentation/java.asciidoc

Fixed with PR #187


A question on square matrices

Hello there, I want to clarify whether the need for square matrices is strictly enforced. From the paper, I note that
"We turn to an expressive class of sub-quadratic structured matrices called Monarch matrices [12] (Figure 1 left) to propose Monarch Mixer (M2). Monarch matrices are a family of structured matrices that generalize the fast Fourier transform (FFT) and have been shown to capture a wide class of linear transforms including Hadamard transforms, Toeplitz matrices [30], AFDF matrices [55], and convolutions. They are parameterized as the products of block-diagonal matrices, called monarch factors, interleaved with permutation. Their compute scales sub-quadratically: setting the number of factors to p results in computational complexity of $O(pN^{(p+1)/p})$ in input length $N$ , allowing the complexity to interpolate between $O(N \log N )$ at $p = \log N$ and $O(N 3/2)$ at $p = 2$.", as well as:
"The convolution case with Monarch matrices fixed to DFT and inverse DFT matrices also admits implementations based on FFT algorithms [9]."
Furthermore, Proposition 3.2 in the original Monarch paper asserts that $\mathcal{MM}^*$ which can represent a convolution.
I thus want to find out whether the Monarch mixer operation enforces the requirements for having block-diagonal matrices, since (residual gated) convolution(s) intuitively does not usually output a block-diagonal matrix.
Thank You!

For the FFTs, we use square matrices. For the MLP layers, we actually use rectangular matrices to match the reverse bottleneck of the MLP.


Skip hidden build configurations in c_cpp_properties.json

When generating the c_cpp_properties.json file, skip the hidden configurations.

Fixed on 2023-02-14.


Add manifest digest annotation for snapshotters

Signed-off-by: Samarth Shah<EMAIL_ADDRESS>We leverage stargz-based snapshotter and have implemented our own Filesystem interface. We need the image digest to get some metadata for the image itself.
cc: @cpuguy83 @juliusl @northtyphoon @mikebrow

@dmcgowan

carry over from: https://github.com/containerd/cri/pull/1585 where derek had the following question...

shahzzzam: We leverage stargz-based snapshotter and have implemented our own Filesystem interface. We need the image digest to get some metadata for the image itself.

Derek: What sort of metadata? I ask because "image digest" can be an ambiguous term since it is interchangeably used to refer to a manifest index/list digest, manifest digest, or image config digest. Generally speaking I would like to figure out cleaner ways for stargz to operate with metadata rather than feeding it more metadata labels, not sure where to draw the line on how it is now.

@dmcgowan makes sense. I renamed it to "containerd.io/snapshot/cri.manifest-digest" to be more specific. Its the manifest digest that we need.

@ktock @dmcgowan Teleport snapshot uses the manifest digest to uniquely identify the image and pull the layers from azure container registry remote image store.

Any updates on this?

@ktock in the 1st solution the snapshotters will only have to parse the labels. In the 2nd solution, they will have to connect to containerd for ContentStore, right?

Ping

@shahzzzam

in the 1st solution the snapshotters will only have to parse the labels.

Yes. 1st one won't require any changes to the snapshotters. Users just add some filter expression (or label key names, etc) to the config.toml, based on the snapshoter they want to use. This improves the current default behaviour where many labels are appended to snapshots even if users don't use remote snapshots.

In the 2nd solution, they will have to connect to containerd for ContentStore, right?

Yes.

@ktock Sure, i can take a look at it later.
For now, can you please help approve and merge this change?

/ok-to-test

We'd like to backport this change since it's necessary for Azure's snapshotter.

@cpuguy83 Can you please help us backport this to 1.4?

this was cherry-picked in https://github.com/containerd/cri/pull/1609, but still needs a revendor of containerd/cri


script to add demo dataset

Please move to one folder and name folder specific to use case. Thanks.

Please move to one folder and name folder specific to use case. Thanks.

Done. Please lmk if this looks okay.


Apply Xcode 12 recommended settings to stop it showing warnings in issue navigator

XCode 12 shows "Validate project settings" warning in issue navigator and suggests a number of updates.
In fact it's enough enabling only the whole module optimization (see below) to make it happy.

since I've already done it, here is a PR that does just that : https://github.com/AzureAD/microsoft-authentication-library-common-for-objc/pull/827

@arangato, thank you for the contribution! We will review your pr.

The change is merged in dev.


Get data from another public API

The app relies on two free APIs: Random User Generator and Advice Slip JSON API. Why not add some more random data about the circle of friends or its individual members? Try this list of public APIs for ideas!

If I'm not late, I'd be interested in implementing this.

@nicolello-dev Sure, give it a whirl!


Graphics driver is broken with latest kernel firmware

If I do a sudo rpi-update and then enables the Graphic driver , black screen comes after reboot. If I disable the Graphic driver it works fine...

@abhisek-mishra is this still an issue? What is the 'Graphic driver'?

@abhisek-mishra this repro is only for rpi-update tool itself. This is the wrong place for this kind of issue. @popcornmix this issue should be closed due to wrong repro and lack of response for three months...


Data Sync Source Code Analysis of Etcd for the zh part.

can you add english document？

can you add english document？

sure.

@4zd Because the official website shows that you need to have the English document first, and then the Chinese document, so you also need to make up the English document, inside your pr this time~
thanks

hi，pls add my wechat xixy199195


[Hub Generated] Review request for Microsoft.Security to add version preview/2020-02-01-preview

If you are a MSFT employee you can view your work branch via this link.
Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk

will start a new request due to conflicts


Nested input types generate an error at introspection time

I have some types like this:
#[derive(InputObject)]
pub(super) struct EditDomainInput {
    domain: String,
    title: Option<String>,
    name: Option<String>,
    description: Option<String>,
    logo: Option<String>,
    contact_info: Option<ContactInfo>,
}

#[derive(InputObject)]
pub struct ContactInfo {
    address: Option<Address>,
    phone_number: Option<String>,
    payment_url: Option<String>,
    contact_email: Option<String>,
}

#[derive(InputObject)]
pub struct Address {
    country: Option<String>,
    region: Option<String>,
    city: Option<String>,
    postal_code: Option<String>,
    street_address: Option<String>,
}

This compiles fine and I can generate SDL  from it.
Expected Behavior
Introspection queries against this schema should work.
Actual Behavior
Introspection query fails; error from GraphiQL:

Introspection must provide input type for arguments, but received: ContactInfo.

Specifications

Version: 3.0.36
Platform: macOS
Subsystem: input  types

I can't reproduce it, can you provide a repository that reproduces this issue? 😁

Here's a full reproducer: https://github.com/djc/nested-input.
What I find really surprising about this is that introspection works okay as long as I comment out the _input argument to the _edit_foo() mutation.

Info is both an input type and an output type causing this error.
#[derive(InputObject)]
#[graphql(name = "InfoInput")] // Add this attribute to rename the input type name
pub struct Info {
    email: Option<String>,
}

This error cannot currently be reported at compile time, I will add a runtime check. 🙂

Why can't Rust types implement both the input and the output traits?

This is not allowed in the GraphQL spec, they need to have different names.

You can implement as input object and output object for the same Rust type, but for GraphQL they are actually different objects, so must have different names as well.

Would be nice if there was a way to do this similar to the way currently multiple names can be declared depending on any generic type parameters.

This should not be possible. 😂

Or I don't know how to do it. 😄

Yes, procedural macros can do it.

You mean, always automatically add the Input suffix?

Ah, sorry -- I didn't actually mean that the macros should implicitly add a suffix to input type names. I meant that there should be a way for me to reuse the same type under a different name, but it looks like that already exists.
I think it might actually be nice if there was a way I could opt in to add Input suffixes to all input type names on a per-crate basis to prevent this issue from happening, but I could understand that you might not want to enable this by default.

Well, I'm now going to add a runtime check that panics when the same Rust type has the same name.

Released in v3.0.37


update readmi

Codecov Report

Merging #7 (f84144b) into main (36299f0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   71.66%   71.66%
=======================================
  Files           4        4
  Lines          60       60
  Branches        3        3
=======================================
  Hits           43       43
  Misses         16       16
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36299f0...f84144b. Read the comment docs.


Test-SqlTempDBConfiguration - Improve output - Fixes #269

Tests

[x]  Test if it returns "All tests passed! tempdb is properly optimized." when all best practices were followed
[x] Test if it returns the proper values for -Detailed
[x] Test if it returns failed best practice if some exist

I already tested all of them and it worked. This should be an easy merge.

Fixed #269 but don't see any link here for that issue...


Is angular-froala not support event afterImageUpload?

i am using qiniu as my images upload server,because it return image url param name is "key" and not "link",so  i must handle the upload response by myself,but it didn't trig after image upload event,can there anyone help me,please? thank u very much!

@aci227 All the FroalaWysiwygEditor events need to be added to angular-froala manually so that the directive will know to listen for them. This commt (caaefed941f748fdb3cb06031858ae162b417450) should resolve the issue for you.


Explicitly test separator when checking nested paths - fixes #24

Currently vfsStreamDirectory::hasChild() and getChild() can give false positives in certain circumstances with nested paths.
The issue is that multi-level paths are not properly compared in vfsStreamAbstractContent.php so that characters within a directory name can be treated as though they were a directory separator.
For eg:
$root = vfsStream::setup('root');
$path = vfsStream::url('root/subdir1/subdir2/foo');
mkdir($path, '0700',true);

// This is true:
echo $root->hasChild('subdir1/subdir2/foo');

// But so is this:
echo $root->hasChild('subdir1.subdir2/foo');

// And this:
echo $root->hasChild('subdir1Xsubdir2/foo');

I only noticed this because I changed my folder naming strategy to move from www/foo/bar/com/page/path/data.html to be www.foo.bar.com/page/path/data.html and tests that should have failed still passed!

This is the pull request related to issue #24 - for some reason Github has created a duplicate issue rather than linking them up.


Update request: deno 1.41.3 → 1.42.3

Package name: deno
Latest released version: 1.42.3
Current version on the unstable channel: 1.41.3
Current version on the stable/release channel: 1.38.2
[x] Checked the nixpkgs pull requests

https://deno.com/blog/v1.42
Notify maintainers
@06kellyjac

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Hi @donovanglover
I'll look into why there hasn't been a PR opened yet by the bot.
The update will probably only go into unstable, just to be clear upfront.
There will be a new stable release in the next month or so for 24.05.
Also I can't edit your issue but your versions for unstable/stable are backwards :)

I'll look into why there hasn't been a PR opened yet by the bot.

https://r.ryantm.com/log/deno/2024-04-11.log, in case you didn't find it already.

Also I can't edit your issue but your versions for unstable/stable are backwards :)

Fixed.


NestedScrollView flutter_gallery Tabs Sample the Scroll state is not right when tab the tabbar

please run flutter_gallery  sample and open sample in Material - Tabs.
issue can be reproduced in dev/master branch, beta branch has no this issue but has crash issue.
Steps to Reproduce

tap APPAREL and scroll to bottom(Blush Sweats)
tap HOME and scroll the list up or down
tap APPAREL the Ginger Scarf will disapper in Screen bottom

and i made a demo based on NestedScrollView. it also has this issue.
i notice that SliverOverlapAbsorber can only used for SliverAppBar, no such thing for SliverPersistentHeader. i think it also effect the scroll behaviour.
more detail please see the gif and my demo code. it's kind of you can have a look for this issue.
thanks.
demo_code.txt

i have done some things to solve this thing, may be you have better solution 。please check it when you have the time.
i notice innerscrollcontrol is sync the crash scrollpostion, that the problem here.
may be we should only Focus on the active one
https://github.com/zmtzawqlp/Flutter_Candies/tree/master/extended_nested_scroll_view

@zmtzawqlp Awesome. i try your project. Fix the official NestedScrollView issue

@zmtzawqlp I can't use your plugin. The instructions are unclear for me, but thanks anyway.

@firatcetiner do as demo show

@zmtzawqlp I can't use your plugin. The instructions are unclear for me, but thanks anyway.

I didn't understand either how to use it...
Did you found another solution?

@firatcetiner @Cae2 Feel free to ask about the usage for this plugin at the repository. We don't discuss about the usage here.

This issue also happened when there's multiple scroll view provided, not just TabBarView.
@zoechi @Piinks Is there anyone can handle this case? Almost two year passed.

Encountered the same issues on my end, this feature is quite trivial for more complex apps. How come this hasn't been fixed yet? Tried on latest Master & Beta channels as of today but these issues are still the case for me:
Scaffold with as body a NestedScrollView that includes:

(HeaderSliverBuilder) SliverAppBar overlapping (part of the) content of the tabview body
(Body) TabView with 3 CustomScrollViews that are scrolling in sync for some reason, even if they all got their own controller.

same here.  it's a big issue, actually.

Persists with current master 1.21.0-6.0.pre.129

flutter doctor -v
[✓] Flutter (Channel master, 1.21.0-6.0.pre.129, on Mac OS X 10.15.6 19G73, locale en-GB)
    • Flutter version 1.21.0-6.0.pre.129 at /Users/nevercode/dev/flutter
    • Framework revision 30aef0a3b9 (14 hours ago), 2020-07-30 14:20:21 -0700
    • Engine revision a9910e409c
    • Dart version 2.10.0 (build 2.10.0-1.0.dev 24c7666def)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (6 available)
    • Redmi Note 7 (mobile)       • 6345c469                                 • android-arm64  • Android 9 (API 28)
    • Nevercode’s iPhone (mobile) • b668e524315069f3db3661ac11ff1f66afafebdb • ios            • iOS 13.6
    • iPhone 11 Pro Max (mobile)  • 55C8466B-5367-492B-8EFE-EC45D980571F     • ios            • com.apple.CoreSimulator.SimRuntime.iOS-13-6 (simulator)
    • macOS (desktop)             • macos                                    • darwin-x64     • Mac OS X 10.15.6 19G73
    • Web Server (web)            • web-server                               • web-javascript • Flutter Tools
    • Chrome (web)                • chrome                                   • web-javascript • Google Chrome 84.0.4147.105

• No issues found!

Bump. Issue still persists. Using TabView within a NestedScrollView

did anyone found the solution?  exteneded_nested_scroll_view documentation is not clear. and there is not full code.

I found the same problem. :neutral_face:

I found the same problem. 😐

I found the same problem. 😐

@zhaopingfu I found a solution in this video https://www.youtube.com/watch?v=ht76lDzPgUQ that they were adding a PageStorageKey to each ListView or GridView inside the tabs and to avoid using KeepAlive because it doesn't allow scrolling to be undone and redone when changing the page.

Same issue here.

I found the same problem. 😐

@zhaopingfu I found a solution in this video https://www.youtube.com/watch?v=ht76lDzPgUQ that they were adding a PageStorageKey to each ListView or GridView inside the tabs and to avoid using KeepAlive because it doesn't allow scrolling to be undone and redone when changing the page.

Unfortunately when using a PageStorageKey there is an other bug for tabs within a nested scroll view.
When I scroll up the scroll position is lost if floating is true: https://github.com/flutter/flutter/issues/81619#issuecomment-963579563

innerScrollController.addListener(() {     outerScrollerController.jumpTo(innerScrollController.offset);   });
solved ，do this

innerScrollController.addListener(() { outerScrollerController.jumpTo(innerScrollController.offset); });
solved ，do this

请问i这个代码写在哪里解决这个问题的

Can confirm that issue still exists in 2.8.1
The library suggested above (https://github.com/fluttercandies/extended_nested_scroll_view) helped to solve the problem.

Why does this problem still exist

The issue is still present on version 3.0.4

3.3.10 still ++

is there a solution to the problem

https://github.com/fluttercandies/extended_nested_scroll_view use version ^5.0 solved

https://github.com/fluttercandies/extended_nested_scroll_view use version ^5.0

i have done some things to solve this thing, may be you have better solution 。please check it when you have the time. i notice innerscrollcontrol is sync the cache scrollpostion, that the problem here. may be we should only Focus on the active one https://github.com/fluttercandies/extended_nested_scroll_view

Saved my life thx bro <3

is there a solution to the problem

@tanlianghao check this https://github.com/fluttercandies/extended_nested_scroll_view

I think this is another case of https://github.com/flutter/flutter/issues/40740. I have been scanning the issue tracker looking to consolidate all of these so we can see about a proper solution. I am going to close this since https://github.com/flutter/flutter/issues/40740 has the most upvotes, let's follow up there. :)
Thanks for providing test cases, updates and work arounds!


Type annotation for jax.lax.scan appears incorrect

Description
The annotation for jax.lax.scan appears to have a typo:
https://github.com/google/jax/blob/0ddbe76cba371c5290bfb7a317f83c89c2c2641d/jax/_src/lax/control_flow/loops.py#L103-L108
Currently, scan is annotated with same return type as the function f, but it seems like it should be a tuple of Carry and a collection of Ys, as in the Haskell type signature in the docstring. I'm not sure which is the correct way to annotate a collection here.
What jax/jaxlib version are you using?
jax v0.4.14
Which accelerator(s) are you using?
CPU
Additional system info
Python 3.10, Linux
NVIDIA GPU info
No response

The Python type system is not expressive enough to be able to annotate the shapes of array objects. So I think the idea of the type annotations here is that if f returns a scalar of type Array, then the scan function returns a vector of type Array.
Still I think you're correct that the annotation is flawed, because if f returns, say, a python float, it's not the case that the output will be a float. But I don't think there's any way to do that kind of casting in a type annotation... particularly since Y must capture the identical pytree structure of the inputs and outputs.
I think given the limitations of type annotation expressivity in Python, the only way we can really make the types accurate here is to use Any. What do you think?

Ah, thank you! I see now how this makes sense in the typical case where Y represents an array with an unspecified number of dimensions (maybe zero).
I agree that the annotation is incorrect when f returns a Python scalar type, since the result of the scan will then be an array. (This is the exact case I ran into, which I worked around by adding #type: ignore. I'm not immediately thinking of other cases where it would be incorrect.
After a bit of thought, I'm not sure I would argue for changing Y to Any, since it seems like the latter would be a regression for a lot of common cases.
(Possibly naive thought: would typing.overload be useful here to annotate the special cases where f returns a Python scalar?)

It would be hard to do this well with typing.overload, because Y may be an arbitrarily-nested container of arrays and scalars, and in this case the return value is a similarly nested container of Arrays. I don't think Python types are expressive enough to annotate that correctly.

I think Y is the correct type, at least until Python typing for ndarrays supports shape types. If the scanned function produces a Pytree, the output will be a Pytree of the same structure.

I think the problem is that Python's type checker doesn't know that tuple[int] and tuple[Array] have the same pytree structure, and therefore should be considered equivalent.

Like, we need some way to say that the input is Y[ArrayLike] and the output is Y[Array].

This seems like a case where this proposed feature would be useful:
https://github.com/python/typing/issues/548


Exception when unwinding a stack from a drawer item button push

I think there is a race condition in here where the drawer is deleting but the animation callbacks are still in progress.
2018-09-07 09:55:06.726874-0700 Runner[38977:6722533] flutter: 'package:flutter/src/widgets/framework.dart': Failed assertion: line 3436 pos 12:
2018-09-07 09:55:06.727150-0700 Runner[38977:6722533] flutter: '_debugLifecycleState != _ElementLifecycle.defunct': is not true.
2018-09-07 09:55:06.727322-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.727480-0700 Runner[38977:6722533] flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially
2018-09-07 09:55:06.727673-0700 Runner[38977:6722533] flutter: more information in this error message to help you determine and fix the underlying cause.
2018-09-07 09:55:06.727834-0700 Runner[38977:6722533] flutter: In either case, please report this assertion by filing a bug on GitHub:
2018-09-07 09:55:06.728010-0700 Runner[38977:6722533] flutter:   https://github.com/flutter/flutter/issues/new
2018-09-07 09:55:06.728156-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.728279-0700 Runner[38977:6722533] flutter: When the exception was thrown, this was the stack:
2018-09-07 09:55:06.728412-0700 Runner[38977:6722533] flutter: #2      Element.markNeedsBuild (package:flutter/src/widgets/framework.dart:3436:12)
2018-09-07 09:55:06.728586-0700 Runner[38977:6722533] flutter: #3      State.setState (package:flutter/src/widgets/framework.dart:1141:14)
2018-09-07 09:55:06.728727-0700 Runner[38977:6722533] flutter: #4      DrawerControllerState._animationChanged (package:flutter/src/material/drawer.dart:215:5)
2018-09-07 09:55:06.728852-0700 Runner[38977:6722533] flutter: #5      _AnimationController&Animation&AnimationEagerListenerMixin&AnimationLocalListenersMixin.notifyListeners (package:flutter/src/animation/listener_helpers.dart:109:19)
2018-09-07 09:55:06.728999-0700 Runner[38977:6722533] flutter: #6      AnimationController._tick (package:flutter/src/animation/animation_controller.dart:608:5)
2018-09-07 09:55:06.729120-0700 Runner[38977:6722533] flutter: #7      Ticker._tick (package:flutter/src/scheduler/ticker.dart:234:5)
2018-09-07 09:55:06.729264-0700 Runner[38977:6722533] flutter: #8      _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:990:15)
2018-09-07 09:55:06.729385-0700 Runner[38977:6722533] flutter: #9      _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleBeginFrame.<anonymous closure> (package:flutter/src/scheduler/binding.dart:906:11)
2018-09-07 09:55:06.729517-0700 Runner[38977:6722533] flutter: #10     __InternalLinkedHashMap&_HashVMBase&MapMixin&_LinkedHashMapMixin.forEach (dart:collection/runtime/libcompact_hash.dart:365:8)
2018-09-07 09:55:06.729614-0700 Runner[38977:6722533] flutter: #11     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleBeginFrame (package:flutter/src/scheduler/binding.dart:904:17)
2018-09-07 09:55:06.729773-0700 Runner[38977:6722533] flutter: #12     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleBeginFrame (package:flutter/src/scheduler/binding.dart:834:5)
2018-09-07 09:55:06.729899-0700 Runner[38977:6722533] flutter: #13     _invoke1 (dart:ui/hooks.dart:142:13)
2018-09-07 09:55:06.730045-0700 Runner[38977:6722533] flutter: #14     _beginFrame (dart:ui/hooks.dart:113:3)
2018-09-07 09:55:06.730268-0700 Runner[38977:6722533] flutter: (elided 2 frames from class _AssertionError)
2018-09-07 09:55:06.730422-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.730542-0700 Runner[38977:6722533] flutter: The AnimationController notifying listeners was:
2018-09-07 09:55:06.730645-0700 Runner[38977:6722533] flutter:   AnimationController#c0898(◀ 0.098)
2018-09-07 09:55:06.730805-0700 Runner[38977:6722533] flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════
2018-09-07 09:55:06.730932-0700 Runner[38977:6722533] flutter: ══╡ EXCEPTION CAUGHT BY ANIMATION LIBRARY ╞═════════════════════════════════════════════════════════
2018-09-07 09:55:06.731079-0700 Runner[38977:6722533] flutter: The following assertion was thrown while notifying listeners for AnimationController:
2018-09-07 09:55:06.731187-0700 Runner[38977:6722533] flutter: 'package:flutter/src/widgets/framework.dart': Failed assertion: line 3436 pos 12:
2018-09-07 09:55:06.731289-0700 Runner[38977:6722533] flutter: '_debugLifecycleState != _ElementLifecycle.defunct': is not true.
2018-09-07 09:55:06.731385-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.731513-0700 Runner[38977:6722533] flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially
2018-09-07 09:55:06.731632-0700 Runner[38977:6722533] flutter: more information in this error message to help you determine and fix the underlying cause.
2018-09-07 09:55:06.731750-0700 Runner[38977:6722533] flutter: In either case, please report this assertion by filing a bug on GitHub:
2018-09-07 09:55:06.731863-0700 Runner[38977:6722533] flutter:   https://github.com/flutter/flutter/issues/new
2018-09-07 09:55:06.731979-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.732101-0700 Runner[38977:6722533] flutter: When the exception was thrown, this was the stack:
2018-09-07 09:55:06.732221-0700 Runner[38977:6722533] flutter: #2      Element.markNeedsBuild (package:flutter/src/widgets/framework.dart:3436:12)
2018-09-07 09:55:06.732340-0700 Runner[38977:6722533] flutter: #3      State.setState (package:flutter/src/widgets/framework.dart:1141:14)
2018-09-07 09:55:06.732455-0700 Runner[38977:6722533] flutter: #4      DrawerControllerState._animationChanged (package:flutter/src/material/drawer.dart:215:5)
2018-09-07 09:55:06.732562-0700 Runner[38977:6722533] flutter: #5      _AnimationController&Animation&AnimationEagerListenerMixin&AnimationLocalListenersMixin.notifyListeners (package:flutter/src/animation/listener_helpers.dart:109:19)
2018-09-07 09:55:06.732703-0700 Runner[38977:6722533] flutter: #6      AnimationController._tick (package:flutter/src/animation/animation_controller.dart:608:5)
2018-09-07 09:55:06.732833-0700 Runner[38977:6722533] flutter: #7      Ticker._tick (package:flutter/src/scheduler/ticker.dart:234:5)
2018-09-07 09:55:06.733076-0700 Runner[38977:6722533] flutter: #8      _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:990:15)
2018-09-07 09:55:06.733210-0700 Runner[38977:6722533] flutter: #9      _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleBeginFrame.<anonymous closure> (package:flutter/src/scheduler/binding.dart:906:11)
2018-09-07 09:55:06.733406-0700 Runner[38977:6722533] flutter: #10     __InternalLinkedHashMap&_HashVMBase&MapMixin&_LinkedHashMapMixin.forEach (dart:collection/runtime/libcompact_hash.dart:365:8)
2018-09-07 09:55:06.733589-0700 Runner[38977:6722533] flutter: #11     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleBeginFrame (package:flutter/src/scheduler/binding.dart:904:17)
2018-09-07 09:55:06.733814-0700 Runner[38977:6722533] flutter: #12     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleBeginFrame (package:flutter/src/scheduler/binding.dart:834:5)
2018-09-07 09:55:06.733992-0700 Runner[38977:6722533] flutter: #13     _invoke1 (dart:ui/hooks.dart:142:13)
2018-09-07 09:55:06.734181-0700 Runner[38977:6722533] flutter: #14     _beginFrame (dart:ui/hooks.dart:113:3)
2018-09-07 09:55:06.734366-0700 Runner[38977:6722533] flutter: (elided 2 frames from class _AssertionError)
2018-09-07 09:55:06.734504-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.734749-0700 Runner[38977:6722533] flutter: The AnimationController notifying listeners was:
2018-09-07 09:55:06.734891-0700 Runner[38977:6722533] flutter:   AnimationController#c0898(◀ 0.051)
2018-09-07 09:55:06.735029-0700 Runner[38977:6722533] flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════
2018-09-07 09:55:06.735177-0700 Runner[38977:6722533] flutter: ══╡ EXCEPTION CAUGHT BY ANIMATION LIBRARY ╞═════════════════════════════════════════════════════════
2018-09-07 09:55:06.735421-0700 Runner[38977:6722533] flutter: The following assertion was thrown while notifying listeners for AnimationController:
2018-09-07 09:55:06.735571-0700 Runner[38977:6722533] flutter: 'package:flutter/src/widgets/framework.dart': Failed assertion: line 3436 pos 12:
2018-09-07 09:55:06.735753-0700 Runner[38977:6722533] flutter: '_debugLifecycleState != _ElementLifecycle.defunct': is not true.
2018-09-07 09:55:06.735936-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.736102-0700 Runner[38977:6722533] flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially
2018-09-07 09:55:06.736267-0700 Runner[38977:6722533] flutter: more information in this error message to help you determine and fix the underlying cause.
2018-09-07 09:55:06.736498-0700 Runner[38977:6722533] flutter: In either case, please report this assertion by filing a bug on GitHub:
2018-09-07 09:55:06.736697-0700 Runner[38977:6722533] flutter:   https://github.com/flutter/flutter/issues/new
2018-09-07 09:55:06.736887-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.737086-0700 Runner[38977:6722533] flutter: When the exception was thrown, this was the stack:
2018-09-07 09:55:06.737422-0700 Runner[38977:6722533] flutter: #2      Element.markNeedsBuild (package:flutter/src/widgets/framework.dart:3436:12)
2018-09-07 09:55:06.737664-0700 Runner[38977:6722533] flutter: #3      State.setState (package:flutter/src/widgets/framework.dart:1141:14)
2018-09-07 09:55:06.737886-0700 Runner[38977:6722533] flutter: #4      DrawerControllerState._animationChanged (package:flutter/src/material/drawer.dart:215:5)
2018-09-07 09:55:06.738078-0700 Runner[38977:6722533] flutter: #5      _AnimationController&Animation&AnimationEagerListenerMixin&AnimationLocalListenersMixin.notifyListeners (package:flutter/src/animation/listener_helpers.dart:109:19)
2018-09-07 09:55:06.738306-0700 Runner[38977:6722533] flutter: #6      AnimationController._tick (package:flutter/src/animation/animation_controller.dart:608:5)
2018-09-07 09:55:06.738497-0700 Runner[38977:6722533] flutter: #7      Ticker._tick (package:flutter/src/scheduler/ticker.dart:234:5)
2018-09-07 09:55:06.738769-0700 Runner[38977:6722533] flutter: #8      _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:990:15)
2018-09-07 09:55:06.738998-0700 Runner[38977:6722533] flutter: #9      _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleBeginFrame.<anonymous closure> (package:flutter/src/scheduler/binding.dart:906:11)
2018-09-07 09:55:06.739200-0700 Runner[38977:6722533] flutter: #10     __InternalLinkedHashMap&_HashVMBase&MapMixin&_LinkedHashMapMixin.forEach (dart:collection/runtime/libcompact_hash.dart:365:8)
2018-09-07 09:55:06.739535-0700 Runner[38977:6722533] flutter: #11     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleBeginFrame (package:flutter/src/scheduler/binding.dart:904:17)
2018-09-07 09:55:06.739839-0700 Runner[38977:6722533] flutter: #12     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleBeginFrame (package:flutter/src/scheduler/binding.dart:834:5)
2018-09-07 09:55:06.740050-0700 Runner[38977:6722533] flutter: #13     _invoke1 (dart:ui/hooks.dart:142:13)
2018-09-07 09:55:06.740174-0700 Runner[38977:6722533] flutter: #14     _beginFrame (dart:ui/hooks.dart:113:3)
2018-09-07 09:55:06.740305-0700 Runner[38977:6722533] flutter: (elided 2 frames from class _AssertionError)
2018-09-07 09:55:06.740440-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.740602-0700 Runner[38977:6722533] flutter: The AnimationController notifying listeners was:
2018-09-07 09:55:06.740750-0700 Runner[38977:6722533] flutter:   AnimationController#c0898(◀ 0.032)
2018-09-07 09:55:06.740915-0700 Runner[38977:6722533] flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════
2018-09-07 09:55:06.741072-0700 Runner[38977:6722533] flutter: ══╡ EXCEPTION CAUGHT BY ANIMATION LIBRARY ╞═════════════════════════════════════════════════════════
2018-09-07 09:55:06.741220-0700 Runner[38977:6722533] flutter: The following assertion was thrown while notifying listeners for AnimationController:
2018-09-07 09:55:06.741363-0700 Runner[38977:6722533] flutter: 'package:flutter/src/widgets/framework.dart': Failed assertion: line 3436 pos 12:
2018-09-07 09:55:06.741497-0700 Runner[38977:6722533] flutter: '_debugLifecycleState != _ElementLifecycle.defunct': is not true.
2018-09-07 09:55:06.741630-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.741761-0700 Runner[38977:6722533] flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially
2018-09-07 09:55:06.741920-0700 Runner[38977:6722533] flutter: more information in this error message to help you determine and fix the underlying cause.
2018-09-07 09:55:06.742051-0700 Runner[38977:6722533] flutter: In either case, please report this assertion by filing a bug on GitHub:
2018-09-07 09:55:06.742200-0700 Runner[38977:6722533] flutter:   https://github.com/flutter/flutter/issues/new
2018-09-07 09:55:06.742384-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.742558-0700 Runner[38977:6722533] flutter: When the exception was thrown, this was the stack:
2018-09-07 09:55:06.742717-0700 Runner[38977:6722533] flutter: #2      Element.markNeedsBuild (package:flutter/src/widgets/framework.dart:3436:12)
2018-09-07 09:55:06.742858-0700 Runner[38977:6722533] flutter: #3      State.setState (package:flutter/src/widgets/framework.dart:1141:14)
2018-09-07 09:55:06.742983-0700 Runner[38977:6722533] flutter: #4      DrawerControllerState._animationChanged (package:flutter/src/material/drawer.dart:215:5)
2018-09-07 09:55:06.743110-0700 Runner[38977:6722533] flutter: #5      _AnimationController&Animation&AnimationEagerListenerMixin&AnimationLocalListenersMixin.notifyListeners (package:flutter/src/animation/listener_helpers.dart:109:19)
2018-09-07 09:55:06.743266-0700 Runner[38977:6722533] flutter: #6      AnimationController._tick (package:flutter/src/animation/animation_controller.dart:608:5)
2018-09-07 09:55:06.743427-0700 Runner[38977:6722533] flutter: #7      Ticker._tick (package:flutter/src/scheduler/ticker.dart:234:5)
2018-09-07 09:55:06.743577-0700 Runner[38977:6722533] flutter: #8      _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:990:15)
2018-09-07 09:55:06.743705-0700 Runner[38977:6722533] flutter: #9      _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleBeginFrame.<anonymous closure> (package:flutter/src/scheduler/binding.dart:906:11)
2018-09-07 09:55:06.743833-0700 Runner[38977:6722533] flutter: #10     __InternalLinkedHashMap&_HashVMBase&MapMixin&_LinkedHashMapMixin.forEach (dart:collection/runtime/libcompact_hash.dart:365:8)
2018-09-07 09:55:06.743992-0700 Runner[38977:6722533] flutter: #11     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleBeginFrame (package:flutter/src/scheduler/binding.dart:904:17)
2018-09-07 09:55:06.744172-0700 Runner[38977:6722533] flutter: #12     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleBeginFrame (package:flutter/src/scheduler/binding.dart:834:5)
2018-09-07 09:55:06.744333-0700 Runner[38977:6722533] flutter: #13     _invoke1 (dart:ui/hooks.dart:142:13)
2018-09-07 09:55:06.744490-0700 Runner[38977:6722533] flutter: #14     _beginFrame (dart:ui/hooks.dart:113:3)
2018-09-07 09:55:06.744661-0700 Runner[38977:6722533] flutter: (elided 2 frames from class _AssertionError)
2018-09-07 09:55:06.744802-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.744970-0700 Runner[38977:6722533] flutter: The AnimationController notifying listeners was:
2018-09-07 09:55:06.745098-0700 Runner[38977:6722533] flutter:   AnimationController#c0898(◀ 0.003)
2018-09-07 09:55:06.745260-0700 Runner[38977:6722533] flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════
2018-09-07 09:55:06.745406-0700 Runner[38977:6722533] flutter: ══╡ EXCEPTION CAUGHT BY ANIMATION LIBRARY ╞═════════════════════════════════════════════════════════
2018-09-07 09:55:06.745573-0700 Runner[38977:6722533] flutter: The following assertion was thrown while notifying listeners for AnimationController:
2018-09-07 09:55:06.745695-0700 Runner[38977:6722533] flutter: 'package:flutter/src/widgets/framework.dart': Failed assertion: line 3436 pos 12:
2018-09-07 09:55:06.745839-0700 Runner[38977:6722533] flutter: '_debugLifecycleState != _ElementLifecycle.defunct': is not true.
2018-09-07 09:55:06.746008-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.746153-0700 Runner[38977:6722533] flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially
2018-09-07 09:55:06.746337-0700 Runner[38977:6722533] flutter: more information in this error message to help you determine and fix the underlying cause.
2018-09-07 09:55:06.746495-0700 Runner[38977:6722533] flutter: In either case, please report this assertion by filing a bug on GitHub:
2018-09-07 09:55:06.746646-0700 Runner[38977:6722533] flutter:   https://github.com/flutter/flutter/issues/new
2018-09-07 09:55:06.746783-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.746937-0700 Runner[38977:6722533] flutter: When the exception was thrown, this was the stack:
2018-09-07 09:55:06.747087-0700 Runner[38977:6722533] flutter: #2      Element.markNeedsBuild (package:flutter/src/widgets/framework.dart:3436:12)
2018-09-07 09:55:06.747226-0700 Runner[38977:6722533] flutter: #3      State.setState (package:flutter/src/widgets/framework.dart:1141:14)
2018-09-07 09:55:06.747368-0700 Runner[38977:6722533] flutter: #4      DrawerControllerState._animationChanged (package:flutter/src/material/drawer.dart:215:5)
2018-09-07 09:55:06.747508-0700 Runner[38977:6722533] flutter: #5      _AnimationController&Animation&AnimationEagerListenerMixin&AnimationLocalListenersMixin.notifyListeners (package:flutter/src/animation/listener_helpers.dart:109:19)
2018-09-07 09:55:06.747657-0700 Runner[38977:6722533] flutter: #6      AnimationController._tick (package:flutter/src/animation/animation_controller.dart:608:5)
2018-09-07 09:55:06.747807-0700 Runner[38977:6722533] flutter: #7      Ticker._tick (package:flutter/src/scheduler/ticker.dart:234:5)
2018-09-07 09:55:06.747935-0700 Runner[38977:6722533] flutter: #8      _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:990:15)
2018-09-07 09:55:06.748107-0700 Runner[38977:6722533] flutter: #9      _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleBeginFrame.<anonymous closure> (package:flutter/src/scheduler/binding.dart:906:11)
2018-09-07 09:55:06.748279-0700 Runner[38977:6722533] flutter: #10     __InternalLinkedHashMap&_HashVMBase&MapMixin&_LinkedHashMapMixin.forEach (dart:collection/runtime/libcompact_hash.dart:365:8)
2018-09-07 09:55:06.748431-0700 Runner[38977:6722533] flutter: #11     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleBeginFrame (package:flutter/src/scheduler/binding.dart:904:17)
2018-09-07 09:55:06.748601-0700 Runner[38977:6722533] flutter: #12     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleBeginFrame (package:flutter/src/scheduler/binding.dart:834:5)
2018-09-07 09:55:06.748739-0700 Runner[38977:6722533] flutter: #13     _invoke1 (dart:ui/hooks.dart:142:13)
2018-09-07 09:55:06.748853-0700 Runner[38977:6722533] flutter: #14     _beginFrame (dart:ui/hooks.dart:113:3)
2018-09-07 09:55:06.749003-0700 Runner[38977:6722533] flutter: (elided 2 frames from class _AssertionError)
2018-09-07 09:55:06.749170-0700 Runner[38977:6722533] flutter:
2018-09-07 09:55:06.749319-0700 Runner[38977:6722533] flutter: The AnimationController notifying listeners was:
2018-09-07 09:55:06.749467-0700 Runner[38977:6722533] flutter:   AnimationController#c0898(⏮ 0.000; paused)
2018-09-07 09:55:06.749629-0700 Runner[38977:6722533] flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════

Looks similar to #21537 just without the engine crash.


Can an ExpressionStatement start with using [ ?

If this proposal were to be accepted, can an ExpressionStatement start with using [?
Eg, how should the code below be interpreted?
function foo() {
  return {};
}

const a = 1;
var using = [];
{
  using [a] = foo();
}

There is currently nothing in the proposal that adds a restriction on ExpressionStatement to prevent an ExpressionStatement to start with using [. This implies that the line using [a] = foo(); can be interpreted as an ExpressionStatement and as a UsingDeclaration.

I just notice that there is a new parameter Pattern in BindingList that would prevent this from being interpreted as a UsingDeclaration. Sorry for the noise.


Use CSS Animations for entry and exit animations

This PR adds the use of CSS animations for Vaul entry and exit animations, making the code for managing the open state simpler.
I also refactored the logic of the scaleBackground function by changing

Taking advantage of the Content component to be mounted/unmounted when the dialog is open or closed
Created two utility functions assignStyle and chain that together facilitate the editing of styles and their cleaning

Fixes #292

Also closes #351

also it resolves #361

@emilkowalski ?

any update on this @emilkowalski ?

A fix inspired by this PR has landed in #408.


Update README and templates

[ ] All tests passed. If this feature is not already covered by the tests, I added new tests.
[ ] This pull request is on the dev branch.
[ ] I used gofmt for formatting the code before submitting the pull request.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 62.116%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
182

Relevant Lines:
293

💛  - Coveralls


dts: bindings: mcp320x: harmonize io-channel property

The rest of the ADC drivers use "input" as io-channel-cells property name, which is also assumed by the ADC DT macros. Use the same convention here to make mcp320x based devices work with the macros (and samples/drivers/adc).
Issue #67314

Already addressed in https://github.com/zephyrproject-rtos/zephyr/pull/67204

Already addressed in #67204

Thanks, didn't know you were working on this as well.

Already addressed in #67204

Thanks, didn't know you were working on this as well.

I wasn't actually sure how to solve the sample upgrade cleanly and most of my time went wondering why the device tree was blowing up in my face so figured I can chip in.


Issue with path params

https://github.com/APIDevTools/swagger-express-middleware/blob/30336ec7a12a2d2aa4dfda297ce2be1b9160e378/lib/path-parser.js#L139
The paramParser.parseParameter  is not called with the schema but with the whole parameter object.
Correct version:
req.pathParams[paramName] = paramParser.parseParameter(param, paramValue, param.schema);

BTW: would highly appreciate not to create an PR for this since you guys likely add unit tests as well and it is likely more easy for you ..... ;)

@Nomeasmo - Swagger Express Middleware currently supports Swagger 2.0, not OpenAPI 3.0, which is why the above code does not work.