Dependency build without added repos

When running helm dependency build or helm install --dep-up, I need to add a repository using helm repo add <repo_name> <url>. As far as I can think of, this makes sense for 2 situations:

Commands that depend on <name> (I.e. helm install <release_name> <repo_name>/<chart_name>
Chart repositories that require specific security requirements.

However, this seems like an unnecessary step when using helm dependency build or helm install --dep-up. For example, I have a chart with the following requirements.yaml:
dependencies:
  - name: postgresql
    version: 6.5.9
    repository: https://kubernetes-charts.storage.googleapis.com
    condition: postgresql.enabled

All information to download the chart is there. Still I need to run helm repo add thiscouldbeanythingreally https://kubernetes-charts.storage.googleapis.com first. On a development machine it’s no problem to add these repositories once, but it’s annoying having to run this step in CI every time.
I suggest to just use default repository settings the repository url isn’t registered. Worst case scenario Helm fails to download the dependency, which is the same as having wrong credentials defined.
Output of helm version:
version.BuildInfo{Version:"v3.0.1", GitCommit:"7c22ef9ce89e0ebeb7125ba2ebf7d421f3e82ffa", GitTreeState:"clean", GoVersion:"go1.13.4"}

@remcohaszing I tested this with Helm 2 and Helm 3. In both versions, you can install a chart with a dependency without adding the repo to the Helm repo list. Here is an example when using Helm 3 from master and a scaffold chart:
$ helm3 repo list
NAME     	URL
incubator	https://kubernetes-charts-incubator.storage.googleapis.com/

$ helm create chrt-7214
Creating chrt-7214

$ cat chrt-7214/Chart.yaml
apiVersion: v2
name: chrt-7214
description: A Helm chart for Kubernetes
[...]
dependencies:
  - name: postgresql
    version: 6.5.9
    repository: https://kubernetes-charts.storage.googleapis.com
    condition: postgresql.enabled

$ helm install chrt-7214 chrt-7214/ --dependency-update
install.go:159: [debug] Original chart version: ""
install.go:176: [debug] CHART PATH: /root/test/helm-charts/chrt-7214

Hang tight while we grab the latest from your chart repositories...
...Unable to get an update from the "local" chart repository (http://<IP_ADDRESS>:8879/charts):
	Get http://<IP_ADDRESS>:8879/charts/index.yaml: dial tcp <IP_ADDRESS>:8879: connect: connection refused
...Successfully got an update from the "incubator" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading postgresql from repo https://kubernetes-charts.storage.googleapis.com
Deleting outdated charts
client.go:101: [debug] creating 3 resource(s)
NAME: chrt-7214
LAST DEPLOYED: Fri Mar 20 09:46:51 2020
NAMESPACE: default
STATUS: deployed
REVISION: 1
USER-SUPPLIED VALUES:
{}

COMPUTED VALUES:
affinity: {}
[....]

NOTES:
1. Get the application URL by running these commands:
  export POD_NAME=$(kubectl get pods --namespace default -l "app.kubernetes.io/name=chrt-7214,app.kubernetes.io/instance=chrt-7214" -o jsonpath="{.items[0].metadata.name}")
  echo "Visit http://<IP_ADDRESS>:8080 to use your application"
  kubectl --namespace default port-forward $POD_NAME 8080:80

Can you try it and see if it works for you?

It doesn’t work for me.
I tried to use in in GitLab CI. The job output can be found here. All details can be found from there, but I’ll summarize the relative information:

The repository in which I encounter the issue can be found here
The chart want to deploy can be found here
I’m using Helm 3.1.2 from the Docker image found here
The diff which the changes I made to try and make it work, can be found here

@remcohaszing To help narrow this down, do you mind testing it as follows:

Use the latest release of Helm v3.1.2
Create scaffold chart, using command helm create
Add the dependency to the chart, in Chart.yaml
Test and see if it works

It appears to work for helm install --dependency-update, but not for helm dependency build.
$ helm version
version.BuildInfo{Version:"v3.1.2", GitCommit:"d878d4d45863e42fd5cff6743294a11d28a9abce", GitTreeState:"clean", GoVersion:"go1.13.8"}

$ helm create foo
Creating foo

$ grep -A 4 dependencies foo/Chart.yaml
dependencies:
  - name: postgresql
    version: 6.5.9
    repository: https://kubernetes-charts.storage.googleapis.com

$ helm install foo foo --dependency-update
Saving 1 charts
Downloading postgresql from repo https://kubernetes-charts.storage.googleapis.com
Deleting outdated charts
NAME: foo
LAST DEPLOYED: Mon Mar 30 14:51:54 2020
NAMESPACE: review
STATUS: deployed
REVISION: 1
NOTES:
1. Get the application URL by running these commands:
  export POD_NAME=$(kubectl get pods --namespace review -l "app.kubernetes.io/name=foo,app.kubernetes.io/instance=foo" -o jsonpath="{.items[0].metadata.name}")
  echo "Visit http://<IP_ADDRESS>:8080 to use your application"
  kubectl --namespace review port-forward $POD_NAME 8080:80

$ helm dependency build foo
Error: no repository definition for https://kubernetes-charts.storage.googleapis.com. Please add the missing repos via 'helm repo add'

@remcohaszing Thanks for details. I think in this circumstance the dep build should work as the dep update does and ignore that the repo that is not in the list.
$ helm dep build chrt-7214
Error: no repository definition for https://kubernetes-charts.storage.googleapis.com. Please add the missing repos via 'helm repo add'

$ helm dep update chrt-7214
Hang tight while we grab the latest from your chart repositories...
...Unable to get an update from the "local" chart repository (http://<IP_ADDRESS>:8879/charts):
	Get http://<IP_ADDRESS>:8879/charts/index.yaml: Get http://<IP_ADDRESS>:8879/charts/index.yaml: dial tcp <IP_ADDRESS>:8879: connect: connection refused
...Successfully got an update from the "incubator" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading postgresql from repo https://kubernetes-charts.storage.googleapis.com
Deleting outdated charts

@hickeyma I tried to reproduce this. Didn't get the same error.
➜  helm3test helm install chrt-7214 chrt-7214 --dependency-update
NAME: chrt-7214
LAST DEPLOYED: Sun Apr 12 00:44:33 2020
NAMESPACE: helm-test
STATUS: deployed
REVISION: 1
NOTES:
1. Get the application URL by running these commands:
  export POD_NAME=$(kubectl get pods --namespace helm-test -l "app.kubernetes.io/name=chrt-7214,app.kubernetes.io/instance=chrt-7214" -o jsonpath="{.items[0].metadata.name}")
  echo "Visit http://<IP_ADDRESS>:8080 to use your application"
  kubectl --namespace helm-test port-forward $POD_NAME 8080:80
➜  helm3test helm dependency build chrt-7214
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "incubator" chart repository
...Successfully got an update from the "storageos" chart repository
...Successfully got an update from the "bitnami" chart repository
...Successfully got an update from the "kubernetes-charts" chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading postgresql from repo https://kubernetes-charts.storage.googleapis.com
Deleting outdated charts
➜  helm3test helm dep build chrt-7214
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "incubator" chart repository
...Successfully got an update from the "storageos" chart repository
...Successfully got an update from the "kubernetes-charts" chart repository
...Successfully got an update from the "bitnami" chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading postgresql from repo https://kubernetes-charts.storage.googleapis.com
Deleting outdated charts
➜  helm3test helm dep update chrt-7214
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "incubator" chart repository
...Successfully got an update from the "storageos" chart repository
...Successfully got an update from the "kubernetes-charts" chart repository
...Successfully got an update from the "bitnami" chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading postgresql from repo https://kubernetes-charts.storage.googleapis.com
Deleting outdated charts

helm dep build behaviour is the same as helm dep update only if the repo is already added.
If it is not, the addition is not done. I will update the PR to fix this.

@remcohaszing @waveywaves I have retested this issue with the latest code from the master branch and it seems to be working now for helm dep build as well. Here is output of my investigation using a simple scaffold chart:
$ helm3 create issue-7242
Creating issue-7242

$ vim issue-7242/Chart.yaml

$ cat issue-7242/Chart.yaml
apiVersion: v2
name: issue-7242
description: A Helm chart for Kubernetes

# A chart can be either an 'application' or a 'library' chart.
#
# Application charts are a collection of templates that can be packaged into versioned archives
# to be deployed.
#
# Library charts provide useful utilities or functions for the chart developer. They're included as
# a dependency of application charts to inject those utilities and functions into the rendering
# pipeline. Library charts do not define any templates and therefore cannot be deployed.
type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
appVersion: 1.16.0

dependencies:
  - name: postgresql
    version: 6.5.9
    repository: https://kubernetes-charts.storage.googleapis.com

$ helm3 repo list
Error: no repositories to show

$ helm3 dep build issue-7242/
Saving 1 charts
Downloading postgresql from repo https://kubernetes-charts.storage.googleapis.com
Deleting outdated charts

$ cat issue-7242/Chart.lock
dependencies:
- name: postgresql
  repository: https://kubernetes-charts.storage.googleapis.com
  version: 6.5.9
digest: sha256:a718d7534c16fca9a803d8d026e22b50032fb9e6ddd4ac78072ad917381943ac
generated: "2020-04-15T10:25:31.584303777Z"

$ ls issue-7242/charts/
postgresql-6.5.9.tgz

$ helm3 dep update issue-7242/
Saving 1 charts
Downloading postgresql from repo https://kubernetes-charts.storage.googleapis.com
Deleting outdated charts

As far as I can tell, it is working without a repo added.

@hickeyma I can confirm that this is working with the latest code on master.
@remcohaszing can you confirm this as well ?

I didn’t test the latest master, since I don’t have a go development setup. Looking from the logs, you posted, the issue appears to be resolved. :smiley:

Ok, thanks for the feedback @remcohaszing @waveywaves. I am going to close this as resolved. We can re-open if you find the issue again when Helm 3.2 is released.

I think this is still happening in Helm 3.9.0, I can use unmanaged repos with helm dep update but I get an error message Please add the missing repos via 'helm repo add' when using helm dep build

This doesn't appear to have been fixed in any release so far! I've just tested every minor release of Helm since 3.2 still have the same issue.

This issue still appears to be present in 3.2 and 3.3, and the work done to fix it looks to be completely reverted in #8478.

we are on 3.9.2 and this is happening to us currently. If this was fixed before, it appears a later update broke it again.

This issue is present in 3.9.2 now. If this was fixed in a previous release, then a later update has broken it again.

Same thing happening with v3.14.1
version.BuildInfo{Version:"v3.14.1", GitCommit:"e8858f8696b144ee7c533bd9d49a353ee6c4b98d", GitTreeState:"clean", GoVersion:"go1.21.7"}

I'm facing the same issue with 3.14.4 while using it with docker image.

Can we please Reopen this issue? Because it is clearly not Fixed. We currently have 3.14.0 and 3.14.4 running and both show the same Problem in helm dep build. Its makes no sense if I have a dep file with the REPO and the Version and a Lock file for Verification that I still need to manual add every REPO inside the script.

@hickeyma @mattfarina Please reopen this issue. People have been complaining for 2 years here that the issue still remains in literally every version since it was supposedly fixed.
As the others said, helm dependency update works without helm repo adding each individual repo, but helm dependency build still does not.
I'm using v3.15.2, installed with brew.

same with helm 3.16.1


Basic and Demo should not see the TariffID

Site Admin must see the OCPI TariffID
Added TariffID in Projected fields in Site/Site Area lists for Admin, Site Admin -> Hide the tab OCPI in Site/Site Area

2 billing test failed - i'll check it in another branch


BucketLocationConstraint (S3) and Region.* (Core) are not coordinated

There are missing regions in both sets of files - Region.h does not have cn and BucketLocationContraint does, for instance. I'm not sure which version is correct.

We recently did a rework of region-related logic to support IPv6 but there are still discrepancies.  I'll check with Jonathan to see if there's anything further we can do here.


Slow startup using NAMD UCX

The NAMD application uses charm++ for process communication. charm++ has a native UCX implementation that greatly improves runtime scalability of NAMD, however, job startup scales inversely with process count. I have measured job startup at ~8 minutes when using ~2000 processes (48 nodes). Are you aware of any way to improve this situation?
My platform is x86_64 (skylake)
./build charm++ ucx-linux-x86_64 icc ompipmix --suffix xpmem --with-production $base_charm_opts --basedir=$HPCX_UCX_DIR -j12
ucx_info -v
# UCT version=1.9.0 revision fcd1255
# configured with: CC=icc CXX=icpc --enable-optimizations --disable-logging --disable-debug --disable-assertions --disable-params-check --without-knem --without-java --prefix=/xxxx/play/Mellanox/hpcx-v2.7.0-gcc-MLNX_OFED_LINUX-4.7-<IP_ADDRESS>-suse12.5-x86_64/ucx-icc-cuda-xpmem --with-cuda=/nasa/cuda/11.0 --with-mlx5-dv --with-rc --with-ud --with-dc --with-ib-hw-tm --with-dm --with-cm --enable-mt --with-gdrcopy --with-xpmem=/xxxx/XPMEM/hjelmn/xpmem/install

2000 processes is a lot for 48 nodes.  Is there a reason for not using the SMP build?  One could then launch one process per socket and address the cores with worker threads,

NAMD recommends against SMP due to poor multi-node scaling.  That is also my experience (poor SMP scaling compared with native UCX).

That runs counter to our usual experiences.  The large scale runs we are familiar with are almost always ucx-...-smp based. Could you provide a specific reference to that non-smp recommendation?  Note that the launch command has to be revised slightly to leverage the SMP based executable, otherwise you may experience poor scaling due to thread oversubscription.

Hmm, I was referring to MPI based SMP having poor scalability.  I haven't
tried UCX+SMP yet.  Still, this doesn't directly address that main concern
which is slow startup of the native UCX build.  For comparison, a pure MPI
build using MPT (HPE formerly SGI) starts in a few seconds on the same set
of nodes.
Dan
On Tue, Aug 25, 2020 at 3:07 PM Eric Bohm<EMAIL_ADDRESS>wrote:

That runs counter to our usual experiences. The large scale runs we are
familiar with are almost always ucx-...-smp based. Could you provide a
specific reference to that non-smp recommendation? Note that the launch
command has to be revised slightly to leverage the SMP based executable,
otherwise you may experience poor scaling due to thread oversubscription.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/UIUC-PPL/charm/issues/3035#issuecomment-680243148,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACODV2GETVC7ZANFYLYFWPTSCQKX3ANCNFSM4QK36CKA
.

Could you provide a sample of the launch command you are using that results in slow startup?

My startup command for the native UCX build is
mpiexec -np 1920 --bind-to core --map-by ppr:20:socket -x UCX_TLS="rc,xpmem,self" .........................
I'm following build instructions at
http://www.hpcadvisorycouncil.com/events/2020/APAC-AI-HPC/pdf/HPC-AI_Competition_NAMD_Benchmark_Guideline.pdf
Oddly, they don't have a section on UCX+SMP.

Please let me know if you would like any more information.
Dan


Alternative fix for #3947

This should not get merged when #3948 gets merged. See https://github.com/Leaflet/Leaflet/pull/3948#issuecomment-148707860

Just mentioning #3947 here in the comment again to have a reference in the issue itself.

This seems a regression since 0.7.x, a git bisect would be helpful to be sure we are not breaking something else or missing the right fix, imho (idem for #3948).

Bisecting point at 2191cfa8b035280215ab7dda0895e1abaa68e490 so I'm happy to leave it to @IvanSanchez :)

Thanks for the bisect. That was my guess in #3947 as well. '_animatingZoom' might get set too late to 'true' internally for a correct '_onZoomStart' behaviour.

Looks good to me :-)


Chat Announcer

New Chat Announcer Commands

/announcechat
/selfchat
/sendchat

Only for Paper:

/worldchat

Only for Velocity:

/serverchat

Resolves #11

Added wiki


Add size parameter to CustomPainter.hitTest

Please note that this is a backwards incompatible change.
Addresses #28206

I think this is a good change, but if we land it we should either provide a mechanism to automatically update people's code (we don't have the infrastructure in place to develop such a mechanism yet), or we should change Dart to allow this kind of change to be done in a non-breaking way.

Although there's agreement that this is a good change, we've decided to not go through with it because of the backwards incompatibility. I'm going to close it for now. If we can sort out how to make this change in a non-breaking way, the PR should be reopened.


Debug view

I would love the ability to preview the index which is generated before/without having to sync it off to Alogila

Neat idea @chrisrowe!
Two thoughts/questions:

Would you prefer this in browser/the CP or on command line?
The option to preview a specific entry might a useful as well?

I think the browser makes the most sense, there are extensions that format and search JSON nicely there, the CLI would require piping to jq for that and it’s not as nice. Maybe both though 🤔
Yes! Limiting to a single entry, perhaps define would help too.
Thanks for considering!


An Assertion triggered by Js::NumberUtilities::IsInSupplementaryPlane() in jitted code

Hello, running following code in ch 1.11.24(debug), an assertion will be thrown.
function opt(start) {
    ' ' == String.fromCodePoint(start);
}
for(let i = 0; i < 1000; i++)
    opt(0);

opt(2147483647);

output:
ASSERTION 13460: (c:\users\sunlili\documents\workspace\jsenginesfordebug\chakracore-1.11.24\lib\common\common\numberutilities_strtod.cpp, line 2711) codePointValue <= 0x10FFFF
 Failure: (codePointValue <= 0x10FFFF)
FATAL ERROR: ch.exe failed due to exception code c0000420

2147483647 is 0x7fffffff, which is an invalid code point value. String.fromCodePoint() should throw an Range Error when handling an invalid code point. It seems that the jitted code needs more checks before call GetStringForCharCodePoint().
ISec Lab.
2020.12.16

I can't reproduce this one - locally I get the expected range error. I think this may be already fixed, though would be good if someone verify what commit fixed it.


fix(reports): ignore transfers to other accounts also in the outflows report

GitHub Issue (if applicable): #3135, also partially fixes #3203 and #3233
Explanation of Bugfix/Feature/Modification:
Don't count outflows from transfers that target accounts that are already included in the outflows report; this was double-counting money and creating artificially high "outflows" for money that did not actually flow out; e.g. it'd count as outflows both the outflows on the credit card and the credit card payment.
As part of checking if everything worked I also fixed the transaction list modal, but it's only a partial fix; there are some potential glitches that depend on the current state of the Ember Router which I'm not sure how to avoid. If you first click in the Reports screen then click on Toolkit Reports all is fine, but if you click while the Ember Router thinks you're already looking at transactions it won't work.

I only added the types here because the original code already used it — but sure, I can port what this file uses to standard JS; will need to bump the tsconfig settings.

Feel free to update the tsconfig to whatever we need to allow using Object.entries and such


feat: implement persistent AxEffects updates

Description:
Stacked on #181.
This is the first step towards proper effect aggregation. Crucially, we don't use these updates in sym_n yet, as we need to integrate some form of CSE to make it actually usable
Testing:
What tests have been run? Did make all succeed for your changes? Was
conformance testing successful on an Aarch64 machine? Yes
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

@shigoel merged and ready for review
this is a pretty simple one, it just exposes some methods to update an existing axeffects


docs: add a unique page body class

So, the idea is that we get a unique page body class; something like page-<page-title> <page-layout>
https://github.com/twbs/blog/blob/e687b66fee2a4ebffed09c91279bb4f8a8c51fcf/_layouts/default.html#L23-L26
Any help is welcome!
Refs https://github.com/twbs/bootstrap/pull/29315#issuecomment-604911967

It seems I already have this in #28479.


fix(publish): use correct gemfile name when publishing prereleases

:tada: This PR is included in version 1.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Jade partials with references to parent (template)

With one of the last updates I have issues when I make a reference to a parents jade template file from inside an included jade partial. To better illustrate this my case is something like the following:
Index.jade (The template called with HtmlWebpackPlugin)
body
    - sections = ['one', 'two', 'three', 'four', …]
    for v, i in sections
        section(id= v)
            if i == 0
                include ./partials/sectionOne
            if i == 1
                include ./partials/sectionTwo

sectionOne.jade (The partial)
h1= 'This is section number ' + v + '!'
p= 'Section ' + v ' is definitely and totally the best section of all sections.'
button= v

Now v and i from the loop should get passed down to the include where it should be reusable. Instead they will both be undefined. I also tried #{v} rather than just v with no success. This worked fine before.
If I build another loop inside the include based on the attributes from the parents one, I even get a breaking error in the CLI because, well, undefined has no length. I'm watching all .jade files with module: { loaders : [ { test: /\.jade$/, ... } ] }. I tried to set the loader in the HtmlWebpackPlugin section with template: 'jade!./path/to/index.jade' which would throw an error about the includes not being exported because of a missing loader type.
I also tried this with the files from the jade-loader example with the same effect.
Do I have to deal differently with this since 2.x? Shouldn't have to, should I?

See the example which uses a jade partial:
https://github.com/ampedandwired/html-webpack-plugin/blob/master/examples/jade-loader/time.jade
Does the jade-loader threat all variables as globals?

Sorry I don't know if I get the question right. What do you mean with

Are all variables globals for the jade-loader?

What I can tell you is I've been playing around with the jade example and this is what I found:

Variable time gets passed down to the include if it is prepended locals.time in the parent. It can then be called with y= time or y #{time} within the include.
Variable time won't get passed down to the include if it is not prepended locals.time. It can then neither be called with y= time nor y #{time} within the include.

Variable time was getting passed down just fine to the include no matter the prefix like a month ago or even less. So for the example files if you change - locals.time = new Date(); to only - time = new Date(); in the template and then change p #{time.toISOString()} to only p= time or to only p #{time} and comment out all the frontend to make this not disappear immediately timewill not get displayed at all. This behavior is new! So something must have happened somewhere.

This plugin does nothing special about jade - it only allows to use the jade-loader.
Please ask the jade-loader team :)
If something can be fixed for the plugin feel free to open a pull request.

Will do! Gonna report back if necessary. Kudos.

Too bad. Jade-loader isn't maintained very well. Guess this will take quite some time to get resolved. Thank you for the moment.

Actually I think this could be related to this question on stackoverflow where compiling the includes itself apparently won't recognize the variable scope. Before 2.x with templateContent this somehow worked. I guess since now everything is done by the loader all the includes get compiled before getting called by the main jade file thus not inheriting the variable scope. Funny enough with locals.variable this ain't no problem.
I really wouldn't care much to make all my variables locals.x but this just won't do for loops. On the other hand if I exclude the partials from the loader then webpack will trace them and complain about the file type.
I rolled back version by version, first html plugin, then jade loader, then jade, then webpack. Do you still think this would be an issue about how jade-loader works? Because I'm telling you, this worked fine before 2.x using templateContent.

templateContent is node (without jade loader)
2.x uses the webpack way (with jade loader)

I did understand that bit. I guess what you're trying to say is that this is the responsibility of the respective engine, since 2.x in this case jade-loader. I totally agree, thank you for your time and close this, since it's not related. Kudos!


Help needed: Mapping bool is always nil

import ObjectMapper

struct TreatmentResponse: Mappable {

var id: String!
var isActive: Bool!
var isCompleted: Bool!

init?(_ map: Map){

}

mutating func mapping(map: Map) {
    id <- map["id"]
    isActive <- map["isActive"]
    isCompleted <- map["isCompleted"]
}
}

isActive and isCompleted is always nil.
I have tried changing them to
var isActive: Bool = false
var isCompleted: Bool = false

In that case, it is not updating to the actual values from API call.
Please suggest a solution to get this fixed. Thanks!

Can you please paste the JSON you are receiving from the API

[
{
"id":"31",
"added_by":"451",
"treatment_Id":"1",
"medication_id":"0",
"name":"TR 1",
"name_slug":"TR-1",
"provider_id":"91",
"start_date":"01-19-2016",
"end_date":"01-23-2016",
"isActive":"true",
"isCompleted":"false",
"date_created":"2016-01-20 08:31:29",
"date_updated":"0000-00-00 00:00:00",
"modified_by":"0"
}
]
Sorry for the delay in response, here is the JSON.

The reason your boolean values are not mapping correctly is because the JSON values are strings instead of booleans. A properly set boolean value in JSON is true not "true"


[TASK] Enable value at risk in template

Issue Description
Is your feature request related to a problem? Please describe.
The statistical metric used as the objective for optimization is currently expected value. The user should be able to specify another metric such as value at risk.
Describe the solution you'd like
Allow the user to specify in the input file which statistical metric will be used for the optimization objective. If not given, it should fall back to expected value.
Describe alternatives you've considered
none

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[ ] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

Approved to close via #137


Release 0.2.5

Any timelines?

Hi,
Is there something you're looking to have added?

Nothing much other than the few commits merged into master

OK, since you're asking, I'll get those pushed to a new release! Sometimes, it's hard to know who's watching and waiting!

0.2.5 is now available on bower.io


chore(TextArea): custom height and width

there is no way how to custom height and width of TextArea (not through rows count)

may be it have sense add new property - maxheight for cases height: 100%

@GermanVor Hey! Could you remove all the tests? We will add them a little bit later


z-index fixed to 1 produce bugs in some framework (vuetify)

BUG REPORT
Vue.js version and component version
vue-awesome-swiper 3.0.6
vue 2.5.13
I noticed the z-index of the swiper is fixed to 1.

That cause some problems (for example some css framework that inherit from z-index or have z-index auto or compute their own z-index based of the parent) (vuetify in my case).
I also noticed that
.swiper-container {
  z-index: auto !important;
}

.swiper-wrapper {
  z-index: auto !important;
}

Fix the problem and doesn't change anything in the slider. Is there a particular reason to set the z-index to 1 ?

This question is about swiper, I found similar answers in swiper's issues, it seems that your approach is right, just overwrite css to solve the problem, swiper allowed to do so.
https://github.com/nolimits4web/Swiper/issues/1385
https://github.com/nolimits4web/Swiper/issues?page=1&q=z-index&utf8=✓


[docs] Fix TextField demo layout

[x] I have followed (at least) the PR section of the contributing guide.

Fix #26703
Preview https://deploy-preview-26710--material-ui.netlify.app/components/text-fields/#layout

I would propose we significantly simplify the demo. We can start by only rendering the default variant of the TextField. The other ones adds nothing for the developers (maybe a bit for maintainers as a visual regression test, but adding margin is soo generic that I doubt we need to care).

@oliviertassinari Should we apply the same for similar demos of text field and keep only the default variant?

Should we apply the same for similar demos of text field and keep only the default variant?

I'm not sure. The reason why I proposed it here is because the outer margin is invariant to the style of the inner element.

I added fullWidth demo to preserve the info from the previous version.


Upgrade rush version to 5.40.7

Upgrade rush version to latest rush version to build all dependent packages. Latest version of rush identifies transitive dependency when --from flag is used.
I will wait until March release is over to merge this change.

Latest rush version finds nd include all dependent packages in all type of dependencies. So this makes ESLint plugin project also eligible to test and as @deyaaeldeen said, ESLint plugin cannot be tested on Node 8 and rush doesn't have an option to exclude a specific project(I can't find any such option) so it fails on Node 8. We will have to put this on hold until we either make eslint run on Node 8 or we drop node 8 testing or rush adds an option to exclude a specific project.


Hovering Effect

Is your feature request related to a problem? Please describe.
There is no Hovering Effect on the contributor's cards. It does not look good.
Describe the solution you'd like
I will add a cool hovering effect and animation on the contributor's cards.
Additional context

Can you please assign this issue to me under GSSOC'23.

Go Ahead @parthpathakpp1


instantiateImpl not resolved

Hello!
I wanted to try Room in KMP to replace my existing implementation with SQLDelight. It is working on Android correctly, but in my project and in the Fruitties Sample, I am not able to test on a iOS device, because instantiateImpl (described also here) is not resolved.
Am I missing something?
Thanks :)

Some confusing thing, I have this extension giving me an error too, yet this project builds and works as it should.

Yes, I saw that it is generated in build folder. I managed to run the sample.
I still have some issues in my personal project, on iOS only, but it might not by linked to instanceImpl directly.

Hi, thanks for reporting this! I could replicate the error in Jellyfish but I have no problems building the app and running the iOS emulator using xCode. Can you verify if you have issues running the app?

Hi!
I am currently trying to make a feature-multi-module app instead of the "classic" local - domain - app
So, I tried to create one module common-local with the RoomDatabase and a module feature-local with DAOs and entities related to the feature.
I was facing issued with the DI due to the internal visibility of instanceImpl. I fix that.
I think I have a problem with this configuration. I tried on this sample, if I have shared -> common-local, it works on Android and iOS. But if I tried something like this:
shared -> common-local -> feature-local, it's not working anymore on iOS (but ok on Android):

Is there sample for Room with a feature-multi-module approach (not in KMP)?

Hi again!
I made my repository public here. I can't figure out why on this repository, I still have an issue on iOS. The RoomGptDatabase_InstantiateImpl.kt is correctly generated but seems to be unresolved.

For iOS, this is the [actual method](See https://github.com/Berhug74/mygpt/blob/master/common/common-room/src/iosMain/kotlin/fr/hugobernardi/mygpt/common/room/RoomPlatformBuilder.kt) building the RoomDatabase.
The database is created from a Koin module. Might be related to this?
It's ok on Android, it's running perfectly.

Hi again x2!
After further investigation, I think it might be linked to K2/KSP2. I tested my configuration in a brand new project.
It works with following versions:
ksp = "1.9.23-1.0.19"
kotlin = "1.9.23"
But doesn't work anymore (on iOS only) with:
ksp = "2.0.0-RC2-1.0.20"
kotlin = "2.0.0-RC2"

@Berhug74 It did not work for me after using the mentioned kotlin and ksp versions. Did it work out of the box for you with these versions?
Kotlin - 1.9.23
ksp - 1.9.23-1.0.19
AGP - 8.4.0
Android studio version - Jellyfish | 2023.3.1

I use K2 because of Jetbrains Resources: https://github.com/JetBrains/compose-multiplatform/pull/4454
I tested on this branch in my repo and I downgrade Kotlin to 1.9.23 and ksp 1.9.23-1.0.20.
As expected, Jetbrains resources doesn't work anymore on iOS this time at runtime, but instantiateImpl is correctly resolved and the app is launched 🤯😅

I double checked the project builds and runs as expected after a clean check out. I'll follow why Android Studio shows an error on Factory.native.kt:38 but this doesn't affect building and running the project.


Submodules: don't reset on make

Git reseting the submodule on make is just not intuitive.
This would be what gets me every time:

I add and commit something in a submodule.
Now before I want to push it from the submodule and before commiting it in Firmware, I like to compile and test it one more time to make sure I don't push any rubbish.
I do make and run it.
I realize the bug I was trying to fix in the first place and start debugging again.
At some point I realize that my fix has gone from the source :facepunch:

Arrgh, I'm a developer, I know git, and I don't want make messing with it!
This being said, a warning is fine but it shouldn't magically change my files.
Also git status tells me perfectly fine that I still need to add and commit my updated submodule, it's like any other unstaged file.

Will setting [GIT_SUBMODULES_ARE_EVIL] (https://github.com/PX4/Firmware/blob/master/Tools/check_submodules.sh#L3)
Solve your problem?

It must be a corner case of the version check script. Its not intended to work that way and it does work great for the cases where you are missing commits by asking if you would like to update.

This just got me again.
I did:
make clean
cd src/lib/DriverFramework
git checkout some_pull_request_branch
cd -
make

And the checked out commit in src/lib/DriverFramework is gone.

The issue is the make clean step. If you do this the system has no way of knowing wether you did a fresh clone (requiring init) or not. It would need to keep its own registry which would never reset by anything the user does, which is also a risk.
I'm on the fence of calling this an usage issue just requiring a printout to remind you to not do this. Because if we don't wipe out all files on make clean, we get ourselves into the stale file problem.

I don't understand, I'm doing my changes after the make clean.

Yes, but your directory looks the same as a freshly cloned one.

Yes, but the submodules are already there, so no need to mess with them.

 :P.

Sure, I'm just wondering where the current check happens.
Is it based on this https://github.com/PX4/Firmware/blob/master/Tools/check_submodules.sh#L9 ?

No, the one biting you is in the Makefile:
https://github.com/PX4/Firmware/blob/d2041b0ef3ffec1fc606c1389b1b74f1cf51beb7/Makefile#L112

I was able to fix my issue using check_submodules. I don't know what the line in Makefile does.

I removed that line, so now I expect it to work.

This has been fixed, closing.


Tidy QPDFXRefEntry creation

I'm not really a fan of having lots of overloaded constructors like this. To me, it actually reduces clarity/understandability of the code. I'd rather see a single comment near the single constructor explaining what the fields mean under various conditions if the code is hard to understand without it.

To my mind, one of the roles of the constructor is to enforce the invariants, ideally at compile time. Having separate constructors enforce that only type 1 records have an offset, only type 2 records have a stream number and index and prevent at compile time the creation pf type 3 records.

Also, it improves run times on average by around 0.5%.

Upon reflection, I decided that what I didn't like was C++ constructors and overloaded functions, not your change. I'd rather see QPDFXrefEntry.newType1(), etc. but I'd have to pick a different language for that. Anyway, you've earned the right to have influence over the API even if you do it differently from how I would do it. I am grateful for your numerous contributions.


feat: add new unit tests

Description

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if applicable)

Additional context

I see linting errors in CI / Build like this:
Error: @shopware-pwa/composables-next:lint: src/mocks/LoginResponse.ts(6,3): error TS2322: Type 'null' is not assignable to type 'string'.
Error: @shopware-pwa/composables-next:lint: src/mocks/Menu.ts(42,7): error TS2322: Type '{ extensions: { search: { extensions: never[]; _uniqueIdentifier: null; translated: never[]; autoIncrement: number; }; }; versionId: string; translated: { breadcrumb: string[]; name: string; customFields: {}; ... 7 more ...; keywords: null; }; ... 35 more ...; apiAlias: string; }' is not assignable to type 'Category'.

So I guess this should be fixed before merging this PR.


feat(directives): Implements the "notIsolated" variant of directives with a child scope.

When declaring a directive definition object with a truthy notIsolated field, then whatever scope attributes the directive declares won't be bound to an isolated child scope, but a normal child scope. This is a necessary feature if Angular is to support directives that transclude their contents into the trascluded content of other transcluding directives, each of which may have bound directive scope attributes. Without this change, for a say high level directive with bound scope attributes whose template includes another say low level directive that transcludes its content, and the high level directive transcludes its content into the transcluded content of the low level directive in its template, then there's no way for the high level directive's transcluded content to have access to its desired scope as its scope will be a child of the isolate scope of the high level directive that transcludes into the transcluded content of the low level directive, which may or may not have isolate or notIsolated scope attributes. With this change, developers will be able to more richly develop hierarchies of transcluding directives that use other transcluding directives in their templates. It's a new feature that should be used sparingly as the transcluded contents of such a high level directive that doesn't isolate its scope will be able to modify values on that directive's scope, which frankly flies in the face of the philosophy behind directives as small, highly encapsulated pieces of markup and behavior. However, when you think of directives as an encapsulation tool that can scale to any extent of encapsulation, a feature such as this in the face of transclusion becomes quite necessary. Regardless, it's certainly one avenue of making Angular easily capable of truly high level encapsulation for the primary authors to take under consideration.

Actually here is a Plnkr, which I think proves that this now works: http://plnkr.co/edit/89kgx0CX785XlQodyVNM?p=preview

Closing due to lack of response

Fyi, there's been no response because it's no longer needed now that
transclusion works as intended. Namely, you can put an ng-transclude inside
an ng-if in a transcluding directive's template. It's been fixed for years
now.


Why is there a hardcoded value at line 129 in NetworkReachabilityManager.swift?

[x] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?
I updated the pod in my code and during review found a hardcoded value.
What did you expect to happen?
What happened instead?
line 129 of NetworkReachabilityManager.swift
self.previousFlags = SCNetworkReachabilityFlags(rawValue: 1 << 30)
Is it safe to use this hardcoded value as parameter?
Alamofire Environment
Alamofire version:5
Xcode version: 10.2.1
Swift version:5
Platform(s) running Alamofire:iOS 9 onwards
macOS version running Xcode:10.14.4
Demo Project

It was added as a source-safe way of indicating we hadn't received an actual value yet, rather than just using an optional. It's not a valid SCNetworkReachabilityFlags value, so we know to replace it right away.


Improve test coverage

Testing is currently very basic we should include more tests inline with obs standards including low memory test images for ingestion.

Moving to project issues


the error when fetching some json file

When using TRON to fetch the json file: "https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com/kindle.json", there is an error occurred but the response code is still 200. Nonetheless, if I used the URLSession.shared.dataTask() instead, the json file is  transmitted correctly.
Te-Jen Wu
<EMAIL_ADDRESS>

Can you give more specifics? What classes and methods of TRON you've used to fetch file?

Hi, there
Here are the source code and the error message. Hope these can give you enough info.
import Foundation
import TRON
import SwiftyJSON
struct Service {
let tron = TRON(baseURL: "https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com <https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com/>")

static let sharedInstance = Service()

func fetchHomeFeed(completion: @escaping (HomeDatasource) -> ()) {

    let request: APIRequest<HomeDatasource, JSONError> = tron.request("/kindle.json")

    request.perform(withSuccess: { (homeDatasource) in
        completion(homeDatasource)
    }) { (err) in
        print("Failed to fetch json...", err)
    }
}

class JSONError: JSONDecodable {
    required init(json: JSON) throws {
        print("JSON ERROR")
    }
}

}
Failed to fetch json...
Failed to fetch json... APIError(request: Optional(https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com/kindle.json), response: Optional(<NSHTTPURLResponse: 0x608000036dc0> { URL: https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com/kindle.json } { status code: 200, headers {
"Accept-Ranges" = bytes;
"Content-Length" = 5435;
"Content-Type" = "application/octet-stream";
Date = "Fri, 24 Feb 2017 14:28:36 GMT";
Etag = ""f20ccea4a6d3d5ab5d82bb65bb1410b8"";
"Last-Modified" = "Tue, 10 Jan 2017 04:55:47 GMT";
Server = AmazonS3;
"x-amz-id-2" = "RM7lSU+tXYiKJ72dsYEJceVqtaJkgLWWEYjgzMnN4VmrLSGhkOP5vjsd/zUZR0ypeQA8sui/Hho=";
"x-amz-request-id" = 608CC807B2C85B3E;
} }), data: Optional(5435 bytes), error: Optional(Alamofire.AFError.responseValidationFailed(Alamofire.AFError.ResponseValidationFailureReason.unacceptableContentType(["application/json"], "text/plain"))), errorModel: Optional(KindleLBTA.Service.JsonError))

Denys Telezhkin<EMAIL_ADDRESS>於 2017年2月24日 下午7:23 寫道：
Can you give more specifics? What classes and methods of TRON you've used to fetch file?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/MLSDev/TRON/issues/26#issuecomment-282269095, or mute the thread https://github.com/notifications/unsubscribe-auth/ARgzY0Zapp7UYLh6IA57JNhY9Q2Hmdhsks5rfr2zgaJpZM4MK8sm.

There's couple of things is noticed:

JSON you mentioned has Array in its root, not Dictionary. Does HomeDatasource object accept array?
Error is coming from Alamofire - Optional(Alamofire.AFError.responseValidationFailed(Alamofire.AFError.ResponseValidationFailureReason.unacceptableContentType(["application/json"], "text/plain")))

Make sure your request has appropriate headers that server expects.

the homeDatasource does accept array and work correctly.
I used the URLSession.shared.dataTask() instead to fetch the same URL and can get the json file without any errors. the source code is below:

static let sharedInstance = Service()
func fetchHomeFeed(completion: @escaping (HomeDatasource)->()) {

    let url = URL(string: "https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com/kindle.json")

    URLSession.shared.dataTask(with: url!) { (data, response, error) in
        if error != nil {
            print("failed to fetch data...")
            return
        }
        guard let data = data else {return}

        let json = JSON(data: data)
        do {
            let homeDatasource = try HomeDatasource(json: json)

            DispatchQueue.main.async(execute: {
                completion(homeDatasource)
            })

        } catch {
            print("ERROR")
        }
    }.resume()

}

the homeDatasource does accept array and work correctly.
I used the URLSession.shared.dataTask() instead to fetch the same URL and can get the json file without any errors. the source code is below:
static let sharedInstance = Service()
func fetchHomeFeed(completion: @escaping (HomeDatasource)->()) {
let url = URL(string: "https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com/kindle.json <https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com/kindle.json>")

URLSession.shared.dataTask(with: url!) { (data, response, error) in
    if error != nil {
        print("failed to fetch data...")
        return
    }
    guard let data = data else {return}

    let json = JSON(data: data)
    do {
        let homeDatasource = try HomeDatasource(json: json)

        DispatchQueue.main.async(execute: {
            completion(homeDatasource)
        })

    } catch {
        print("ERROR")
    }
}.resume()

}

吳德仁<EMAIL_ADDRESS><EMAIL_ADDRESS>於 2017年2月24日 下午10:41 寫道：
Hi, there
Here are the source code and the error message. Hope these can give you enough info.
import Foundation
import TRON
import SwiftyJSON
struct Service {
let tron = TRON(baseURL: "https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com <https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com/>")

static let sharedInstance = Service()

func fetchHomeFeed(completion: @escaping (HomeDatasource) -> ()) {

    let request: APIRequest<HomeDatasource, JSONError> = tron.request("/kindle.json")

    request.perform(withSuccess: { (homeDatasource) in
        completion(homeDatasource)
    }) { (err) in
        print("Failed to fetch json...", err)
    }
}

class JSONError: JSONDecodable {
    required init(json: JSON) throws {
        print("JSON ERROR")
    }
}

}
Failed to fetch json...
Failed to fetch json... APIError(request: Optional(https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com/kindle.json https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com/kindle.json), response: Optional(<NSHTTPURLResponse: 0x608000036dc0> { URL: https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com/kindle.json https://letsbuildthatapp-videos.s3-us-west-2.amazonaws.com/kindle.json } { status code: 200, headers {
"Accept-Ranges" = bytes;
"Content-Length" = 5435;
"Content-Type" = "application/octet-stream";
Date = "Fri, 24 Feb 2017 14:28:36 GMT";
Etag = ""f20ccea4a6d3d5ab5d82bb65bb1410b8"";
"Last-Modified" = "Tue, 10 Jan 2017 04:55:47 GMT";
Server = AmazonS3;
"x-amz-id-2" = "RM7lSU+tXYiKJ72dsYEJceVqtaJkgLWWEYjgzMnN4VmrLSGhkOP5vjsd/zUZR0ypeQA8sui/Hho=";
"x-amz-request-id" = 608CC807B2C85B3E;
} }), data: Optional(5435 bytes), error: Optional(Alamofire.AFError.responseValidationFailed(Alamofire.AFError.ResponseValidationFailureReason.unacceptableContentType(["application/json"], "text/plain"))), errorModel: Optional(KindleLBTA.Service.JsonError))

Denys Telezhkin<EMAIL_ADDRESS><EMAIL_ADDRESS>於 2017年2月24日 下午7:23 寫道：
Can you give more specifics? What classes and methods of TRON you've used to fetch file?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/MLSDev/TRON/issues/26#issuecomment-282269095, or mute the thread https://github.com/notifications/unsubscribe-auth/ARgzY0Zapp7UYLh6IA57JNhY9Q2Hmdhsks5rfr2zgaJpZM4MK8sm.

Maybe the problem is with default headers we are setting on HeaderBuilder class. Can you try following before creating request?
tron.headerBuilder = HeaderBuilder(defaultHeaders: [:])

And only after that:
let request: APIRequest<HomeDatasource, JSONError> = tron.request("/kindle.json")

After adding the setting, the json file can be transmitted correctly. Thanks a lot for your help!


Add priority on feature requests to pricing page

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
We need to add to our Enterprise and Business Critical offerings on the pricing page (just add to Enterprise since its included in Business Critical) that we also offer priority on feature requests. This is a top thing our Enterprise+ customers come to us for and want to highlight it,.
Affected area/feature
Pricing page
Under Enterprise
(checkmark) Priority feature requests

@meagancojocar do you need an triage on this? if not, can you remove the needs-triage label? thank you!

(I don't think this needs triage; but, I realised, it's not my call :-)


nicer parameters and command return type

The JSON for parameters really leaked our internal structure without being understandable. Changed it to something saner in my opinion.

I've added another thing: each ValidResponse instance must define a name. This name is used as the return type of the command in the command description, so that IDEs can decide what to do with the result. I've changed all of hare operation to return a RefactorResult, so that it's clear that they all return the same thing (the list of impacted files)

I like the return type name

I see you haven't merged the PR. Any concern?

Just made a comment. No real concerns, just did not have time to look in
detail.
On Fri, Nov 27, 2015 at 9:44 PM, JP Moresmau<EMAIL_ADDRESS>wrote:

I see you haven't merged the PR. Any concern?
—
Reply to this email directly or view it on GitHub
https://github.com/haskell/haskell-ide-engine/pull/105#issuecomment-160195082
.


Added ChatGPT-CodeReview workflow

As seen on https://github.com/anc95/ChatGPT-CodeReview.
Triggered by adding the gpt review label so its not too expensive and doesn't run every time.

This is so cool.

@dylanlott I updated the first suggestion but think we should ride on main as this thing is really new and I expect it to be improving quickly


Add an immutable String implements IndexedSeq

java.lang.String is already immutable but javaslang.collection.String will be feature-rich.
I expect, that this feature will be a magnet (similar to Try) because Strings are probably the most popular native language feature (of Java) > Hello world!.
Example:
// = {
//   'J' -> 1,
//   'a' -> 3,
//   'v' -> 1,
//   's' -> 1,
//   'l' -> 1,
//   'n' -> 1,
//   'g' -> 1
// }
final Map<Character, Integer> occurrences = String.of("Javaslang").countOccurrences();

hi @danieldietrich, so the future javaslang.collection.String will be very similiar to:
scala.collection.immutable.WrappedString ?

Hi @patrox, yes - exactly. It will be an IndexedSeq of Character that wraps a java.lang.String

Then we should name it WrappedString

I'll name it WrappedString right now

@ruslansennov are you working currently on the implementation? Because to be honest I like this project a lot and if it's possible I would like to help you somehow - and I was wondering if I can work on this one? :)

@patrox :+1: you're welcome!

@patrox It seems all ready, I'll finish soon

@patrox to start getting your hands dirty you could implement 1-2 euler tests. I like the Scala project of @shadaj as reference: https://github.com/shadaj/euler. The existing tests are located in src/test/java/javaslang/collection/euler

@ruslansennov so I was a bit late ... but it will be quite interesting to compare the implementations :)
@danieldietrich I'll have a look at these tests

Great! There will be more todo - much more :-)

@danieldietrich There is problem to make test for String. I see no other way except make it independent from AbstractSeqTest

Alright!

@ruslansennov @patrox Guys, I urgently need some high quality sleep - I will come back tomorrow...

@ruslansennov @patrox
Btw - Vector as return type in many places is the best choice because both, WrappedString and Vector, are of type IndexedSeq and therefore have similar performance characteristics (get, set, append, ...).
However, I'm not completely convinced about the name WrapperString. In Scala it is 'hidden', i.e. not instantiable. But I have no better name, yet.

I don't like String2 very much.
Also Str and Chars are not so good.
Maybe IndexedString - but that is redundant. Or shorter IString (sounds like a new Apple product o_O)
RichString is taken by formatted strings
Wikipedia: 'a string is traditionally a sequence of characters'. Maybe then CharSeq. Also CharArray or Word are possible.

class CharSeq implements IndexedSequence<Character> makes sense, doesn't it?

nah, String2 was just a product of a my very tired mind :)

I like CharSeq

I think it's the best name we have now currently, IString sounds like an interface in Microsoft parlance

in other side WrappedString assumes big list of java.lang.String methods and it is good

mmhh, yes, it would be good to see it is a String by just looking at the API...

StringOnSteroids :-)

Stringoid - like Monoid - sounds algebraic... ok, time to relax and make some coffee... :-)

I will rename it to CharSeq < IndexedSeq < Seq for now. It is lightweight and easy to remember. WrappedString sounds too bulky.

if you'll rename it, then can you please rename the test as well, to be consisten, as now it's StringTest, there is a bit of inconsistency in packages too, as the WrappedString is currently located in javaslang, but the corresponding test suite is located in javaslang.collection

yep, already done - thx! they reside in javaslang.collection

alright! I've to go get some sleep - found some interesting info regarding how String-like behave in the context of transforming functions like map ... I'll create some tests to capture the behaviour, so we can discuss if further. But for now - good night !

thanks for your help! good night!


Android(Google Chrome) print preview and print out are empty when printing large PDF (over 25 pages)

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: Google Chrome latest
Operating system and its version: Android latest
PDF.js version:2.2.171
Is a browser extension: NO

Steps to reproduce the problem:

View large PDF (over 25 pages)
Clicks on the print button
Preview  and print out sometime is empty

The solution for the issue is  the following (Open separate windows with the print content for the Android)
 performPrint: function performPrint() {
    var _this2 = this;

    this.throwIfInactive();
    return new Promise(function (resolve) {
      setTimeout(function () {
        if (!_this2.active) {
          resolve();
          return;
        }
        var printhtml = document.getElementById('printContainer');

        if (_this2.isPopPrintEnable && printhtml != null) {

          let popupWin = window.open("", "_blank", "top=0,left=0,height=0,width=auto");
          popupWin.document.open();
          popupWin.document.write(`

Please tap on the screen go back to application.

                      ${printhtml.innerHTML}

                  `);
          popupWin.document.close();
          if (activeService) {
            activeService.destroy();
            dispatchEvent('afterprint');
          }
        }
        else {

          print.call(window);
          setTimeout(resolve, 1000);
        }
      }, 0);
    });
  },

Web browser and its version: Google Chrome latest
Operating system and its version: Android latest

Note that "latest" is generally not helpful, which is why you should always provide actual version numbers.

PDF.js version: 2.2.171

That version is no longer supported, please find the latest releases at https://mozilla.github.io/pdf.js/getting_started/#download

Preview and print out sometime is empty

This unfortunately sounds like a platform and/or browser specific bug, rather than a PDF.js library/viewer one, especially since it from the description even sounds like it's intermittent; hence this unfortunately doesn't look like something that we can fix here.
Finally, note that code-snippets are generally not all that helpful; please see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.


fix chunk prefetch/preload

add connection type set to parent chunk group
use connection type in iterable by type methods

What kind of change does this PR introduce?
fixes #12393

Did you add tests for your changes?
use existing stats

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@sokra Need your attention, thanks

[ ] Rebase
[ ] Test Case
[ ] Follow-up verify on performance


Fix Error "Call to a member function augmentable() on null"

This error occurs if the anchor_navigation-Tag is called in a context without an id.

Thanks for fixing this error @doriengr. The changes are now available in the latest release.


KB Article

It's not clear if the LCS KB article referenced in this article also covers Platforms 16-20, or only Platform 20.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f38b490-1c3b-51fd-bcb0-d4fdac44b98f
Version Independent ID: 3ca286f6-7da8-798f-8fb4-b6ea57357109
Content: What's new or changed in Dynamics 365 for Finance and Operations platform update 20 (September 2018) - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/fin-and-ops/get-started/whats-new-platform-update-20.md
Service: dynamics-ax-platform
GitHub Login: @tonyafehr
Microsoft Alias: tfehr

The link to the LCS KB article covers only Platform update 20.

Can we get links to all the KB articles that cover platforms 16-20 in this article? Most users will be going from Platform 15 to 20.

I'm adding KB article links to each platform update listed in this topic. The updates will be published on Wednesday.


made dbNSFP fields modifiable, added dbNSFP for hg38

Hi Brad
I've tried to make some modifications to how dbNSFP was called with VEP. As I said in #1653 , It'd be nice I the users could modify which fields are used.
This PR aims to do just that. However, I haven't been able to test this (how should I go about that?).
Do you think this seems allright?
this goes together with chapmanb/cloudbiolinux#233
Thanks
M

Thanks for this. The approach looks great to me. Could you make the default dbNSFP annotations the same as previously so that folks upgrading get the previous behavior? It's great to allow people to adjust but would like to make the experience consistent for anyone who is currently reliant on the existing behavior. Thanks again.

Done!
Do you suppose this will work out of the box? I don't really have an idea how I should best test this before doing a PR.

I tried adding the dbscSNV plugin in the latest commit, I thinks that should do the trick, but I might have forgotten to make some other changes somewhere. This does depend on the upgrade to vep_86, since the plugin file isn't included in the vep_83 recipe.

Thanks for working more on this. I'm happy to merge the dbNSFP changes if you can separate out your branches again. No problem to close and re-open or whatever works best for you. For testing, you can install your development version of the code into your current installation (or a second development installation) and the details about how we typically are here:
http://bcbio-nextgen.readthedocs.io/en/latest/contents/code.html#development-infrastructure
Hope this helps.

Ok, I think I reverted everything that doesn't belong here. If you don't see any more issues, merge away!

Thanks, this looks great to me but I'm not able to cleanup the messy history of this because of the merges. Would it be possible to create a new clean branch submit a PR from that? You could do without any git magic with:
git checkout -b vep-dbnsfp
wget https://patch-diff.githubusercontent.com/raw/chapmanb/bcbio-nextgen/pull/1659.diff
patch -p1 < 1659.diff

and then submit from that new branch. I could do but wanted to give you credit for your work in the git history. I'll close this for now and can merge your new PR whenever ready.


Spelling Mistakes?

Find a spelling mistake in this doc https://github.com/open-source-for-science/TensorFlow-Course/tree/master/docs/tutorials/1-basics/variables。
Initializing Specific Variables part, the code I think is:
# The initializer
init_custom_op = tf.variables_initializer(var_list=variable_list_custom) # not all_variables_list

Is it right?

Please create pull request for this issues.
Thanks


Added UWP Sample and Target Framework

Description of Change

Added UWP Sample Project
Added UAP TargetFramework
Updated ImageResourceExtension to work with UAP target

Bugs Fixed
#220
API Changes
None
Behavioral Changes
Probably none, but since I've updated the CommunityToolkit.csproj to compile for UAP10.0, it will no longer be the NetStandard version loaded into UWP apps. I don't think this will have any practical impact.
PR Checklist

[ ] Has tests (if omitted, state reason in description)
[ ] Has samples (if omitted, state reason in description)
[ ] Rebased on top of main at time of PR
[ ] Changes adhere to coding standard
[ ] Updated documentation

I made a couple of changes thanks to suggestions from @pictos, thanks for your help.
The Target Frameworks are now only declared in one place, and will only include the UAP target if being compiled on Windows. It also now targets uap10.0.16299 explicitly which was the original intention of the csproj and matches Xamarin.Essentials.
@pictos can you please test out these changes and let me know if it builds on your system? You may need to delete the bin/obj from the toolkit, sample and UWP projects, my VS got confused when the UWP project changed target it was running off.


http://<IP_ADDRESS>:5000/

<!-- ⚠⚠ Do Not Delete This! These are comments and will not show up in Preview ⚠⚠ -->

Is your feature request related to a problem? Please describe.

Describe the solution you'd like:

Describe alternatives you've considered:

Additional context:

Closing as incomplete.


Prevented double require of model definition

The class definition was being included twice, which caused an issue with models which use enums.

Thank you, @bdunham!

Thanks @bdunham, we hit the same issue.  Looks like this should fix #34.


feat: configure prover as separate process

Update the aztec command to allow running as an independent prover connected to a prover pool

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5973  👈
#5972
#5971
#5970
#5969
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexghr and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

circuit_simulation_time_in_ms (base-rollup): 16,677 (+38%)
circuit_simulation_time_in_ms (root-parity): 1,220 (+884%)
circuit_simulation_time_in_ms (merge-rollup): 6,423 (+103%)
circuit_simulation_time_in_ms (public-kernel-setup): 209 (+76%)
circuit_output_size_in_bytes (public-kernel-app-logic): 26,202 (-50%)
circuit_output_size_in_bytes (public-kernel-tail): 3,812 (-49%)
circuit_output_size_in_bytes (public-kernel-teardown): 34,711 (-33%)
circuit_output_size_in_bytes (public-kernel-setup): 34,711 (-33%)
note_history_trial_decrypting_time_in_ms (10): 145 (+103%)
l2_block_building_time_in_ms (8): 21,724 (+16%)
l2_block_building_time_in_ms (32): 85,624 (+18%)
l2_block_building_time_in_ms (64): 171,125 (+18%)
l2_block_rollup_simulation_time_in_ms (8): 21,513 (+16%)
l2_block_rollup_simulation_time_in_ms (32): 84,868 (+18%)
l2_block_rollup_simulation_time_in_ms (64): 169,652 (+18%)
note_successful_decrypting_time_in_ms (32): 405 (+18%)
note_trial_decrypting_time_in_ms (32): 105 (+165%)
note_trial_decrypting_time_in_ms (64): 115 (+383%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
772
772
772

l1_rollup_calldata_gas
6,844
6,832
6,844

l1_rollup_execution_gas
587,325
587,313
587,325

l2_block_processing_time_in_ms
1,482 (-3%)
5,308 (-4%)
10,333 (-3%)

note_successful_decrypting_time_in_ms
112 (-7%)
:warning: 405 (+18%)
705 (-2%)

note_trial_decrypting_time_in_ms
10.2 (-28%)
:warning: 105 (+165%)
:warning: 115 (+383%)

l2_block_building_time_in_ms
:warning: 21,724 (+16%)
:warning: 85,624 (+18%)
:warning: 171,125 (+18%)

l2_block_rollup_simulation_time_in_ms
:warning: 21,513 (+16%)
:warning: 84,868 (+18%)
:warning: 169,652 (+18%)

l2_block_public_tx_process_time_in_ms
8,563 (+1%)
33,458 (+1%)
67,159 (+2%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
16,372 (-2%)
31,273 (-2%)

note_history_successful_decrypting_time_in_ms
915 (+3%)
1,705 (-4%)

note_history_trial_decrypting_time_in_ms
132 (+17%)
:warning: 145 (+103%)

node_database_size_in_bytes
19,132,496
35,864,656

pxe_database_size_in_bytes
29,859
59,414

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
157 (+1%)
47,763
31,978

private-kernel-inner
178 (+1%)
80,794
31,978

private-kernel-ordering
137 (+1%)
57,732
50,043

base-parity
80.8 (+6%)
128
265

base-rollup
:warning: 16,677 (+38%)
110,926
957

root-parity
:warning: 1,220 (+884%)
1,244
265

root-rollup
57.7 (+16%)
4,551
821

public-kernel-app-logic
1,834 (+11%)
62,017
:warning: 26,202 (-50%)

public-kernel-tail
4,661 (+11%)
168,566
:warning: 3,812 (-49%)

merge-rollup
:warning: 6,423 (+103%)
2,760
957

public-kernel-teardown
148 (+25%)
62,017
:warning: 34,711 (-33%)

public-kernel-setup
:warning: 209 (+76%)
62,017
:warning: 34,711 (-33%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.9
17.6
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.6
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.636
0.544
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
51.7
80.1 (-1%)
259 (-1%)
503
975 (-1%)
1,939
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
96.0
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.530
0.495 (-1%)
0.473 (-1%)
0.469
0.464 (-1%)
0.464
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
60.6 (+1%)
119
373 (-1%)
740
1,450 (-1%)
2,907
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
105
207
691
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.535
0.535
0.509 (-1%)
0.509
0.505 (-1%)
0.506 (-1%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
67.7

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
109

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.589

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
51,411
543,524

Transaction size based on fee payment method

Metric
native fee payment method
fpc_public fee payment method
fpc_private fee payment method

tx_with_fee_size_in_bytes
897
1,145
1,345

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
1,294 (+1%)
865
3,475

Metric
1 public data writes
2 public data writes
3 public data writes
4 public data writes
5 public data writes
8 public data writes

tx_sequencer_processing_time_ms
838 (+1%)
766 (+1%)
1,346
909
2,072
1,095


Diagonal Basis for Polarisation

It would be beneficial to also have (anti)diagonal basis states $| A> = [1/\sqrt{2}, -1/\sqrt{2}]^T$ and $| D> = [1/\sqrt{2}, 1/\sqrt{2}]^T$ for the polarisation as it is the third axis on the Bloch sphere representation/the third orthogonal basis.

Update including this improvement is in my fork and will be merged soon.


The main process freezes after enable main process anr

Is there an existing issue for this?

[X] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
[X] I have reviewed the documentation https://docs.sentry.io/
[X] I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?
Sentry Saas (sentry.io)
Electron SDK Version
4.17.0
Electron Version
27.2.0
What platform are you using?
MacOS
Link to Sentry event
No response
Steps to Reproduce

enable main process anr in sentry
computer sleep
wake up after about 10 minutes
main process freezes and is not responded.

It doesn't happen every time, but it occurs more frequently under low battery conditions.
The hangs stack is in v8:debugger and inspector.
Date/Time:        2024-02-19 22:30:45.010 +0800
End time:         2024-02-19 22:32:58.972 +0800
OS Version:       macOS 14.1.2 (Build 23B92)
Architecture:     x86_64h
Report Version:   44
Incident Identifier: FBB0FDDE-2A1F-4FD1-B6D6-F42A60BBEE57

Data Source:      Stackshots
Shared Cache:     C4E0C302-D68B-3B56-9F5A-6C3FBE5367CB slid base address 0x7ff81112b000, slide 0x1112b000 (System Primary)
Shared Cache:     6AAC45E6-EC03-3AD0-AC14-0EF2CF511C5B slid base address 0x7ff82888e000, slide 0x2888e000 (DriverKit)

Command:          RingCentral
Path:             /Applications/RingCentral.app/Contents/MacOS/RingCentral
Identifier:       com.ringcentral.glip
Version:          24.1.21.undefined (24.1.21.undefined)
Team ID:          M932RC5J66
Is First Party:   No
Architecture:     x86_64
Parent:           launchd [1]
PID:              55302
Time Since Fork:  12550s

Event:            hang
Duration:         133.96s
Duration Sampled: 4.30s (process was unresponsive for 130 seconds before sampling)
Steps:            43 (100ms sampling interval)

Hardware model:   MacBookPro16,1
Active cpus:      16
HW page size:     4096
VM page size:     4096

Time Since Boot:  29675s
Time Awake Since Boot: 10947s
Time Since Wake:  2s

Fan speed:        1856 rpm
Total CPU Time:   7.965s (20.6G cycles, 18.1G instructions, 1.14c/i)
Advisory levels:  Battery -> 2, User -> 2, ThermalPressure -> 1, Combined -> 2
Free disk space:  355.17 GB/931.55 GB, low space threshold 3072 MB
Low Power Mode:   Enabled
Vnodes Available: 79.36% (208839/263168)

Launchd throttled processes:
  gui/501/com.paloaltonetworks.gp.pangps throttled after exit(): throttled samples 1-43
  system/com.paloaltonetworks.gp.pangpsd throttled after exit(): throttled samples 1-43

Preferred User Language: en-CN, zh-Hans-CN
Country Code:     CN
Keyboards:        ABC
OS Cryptex File Extents: 6

--------------------------------------------------
Timeline format: stacks are sorted chronologically
Use -i and -heavy to re-report with count sorting
--------------------------------------------------

Heaviest stack for the main thread of the target process:
  43  start + 1942 (dyld + 25510) [0x7ff8111db3a6]
  43  ElectronMain + 155 (Electron Framework + 4105179) [0x114c703db]
  43  v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) + 15719 (Electron Framework + 7680407) [0x114fd9197]
  43  v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) + 15452 (Electron Framework + 7680140) [0x114fd908c]
  43  v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) + 20813 (Electron Framework + 7685501) [0x114fda57d]
  43  v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) + 21319 (Electron Framework + 7686007) [0x114fda777]
  43  v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) + 17266 (Electron Framework + 7681954) [0x114fd97a2]
  43  v8::internal::SetupIsolateDelegate::SetupBuiltins(v8::internal::Isolate*, bool) + 4242383 (Electron Framework + 46203295) [0x11749619f]
  43  v8::internal::SetupIsolateDelegate::SetupBuiltins(v8::internal::Isolate*, bool) + 4259474 (Electron Framework + 46220386) [0x11749a462]
  43  v8::internal::SetupIsolateDelegate::SetupBuiltins(v8::internal::Isolate*, bool) + 4252720 (Electron Framework + 46213632) [0x117498a00]
  43  node::AsyncResource::get_async_id() const + 9882143 (Electron Framework + 63505807) [0x11851658f]
  43  node::AsyncResource::get_async_id() const + 10133901 (Electron Framework + 63757565) [0x118553cfd]
  43  node::AsyncResource::get_async_id() const + 10417560 (Electron Framework + 64041224) [0x118599108]
  43  node::AsyncResource::get_async_id() const + 10426470 (Electron Framework + 64050134) [0x11859b3d6]
  43  -[NSApplication run] + 603 (AppKit + 196090) [0x7ff814c3edfa]
  43  -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1304 (AppKit + 9642824) [0x7ff815541348]
  43  _DPSNextEvent + 880 (AppKit + 256133) [0x7ff814c4d885]
  43  _BlockUntilNextEventMatchingListInModeWithFilter + 66 (HIToolbox + 197937) [0x7ff81bedf531]
  43  ReceiveNextEventCommon + 665 (HIToolbox + 198630) [0x7ff81bedf7e6]
  43  RunCurrentEventLoopInMode + 292 (HIToolbox + 199129) [0x7ff81bedf9d9]
  43  CFRunLoopRunSpecific + 557 (CoreFoundation + 500562) [0x7ff81163d352]
  43  __CFRunLoopRun + 919 (CoreFoundation + 502961) [0x7ff81163dcb1]
  43  __CFRunLoopDoSources0 + 215 (CoreFoundation + 507956) [0x7ff81163f034]
  43  __CFRunLoopDoSource0 + 157 (CoreFoundation + 508521) [0x7ff81163f269]
  43  __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 (CoreFoundation + 508615) [0x7ff81163f2c7]
  43  node::AsyncResource::get_async_id() const + 10419057 (Electron Framework + 64042721) [0x1185996e1]
  43  ??? (Electron Framework + 2002634) [0x114a6eeca]
  43  node::AsyncResource::get_async_id() const + 10423141 (Electron Framework + 64046805) [0x11859a6d5]
  43  node::AsyncResource::get_async_id() const + 10130659 (Electron Framework + 63754323) [0x118553053]
  43  node::AsyncResource::get_async_id() const + 10009145 (Electron Framework + 63632809) [0x1185355a9]
  43  v8_inspector::V8DebuggerId::V8DebuggerId(std::__Cr::pair<long long, long long>) + 22333 (Electron Framework + 5843021) [0x114e1884d]
  43  uv_run + 369 (Electron Framework + 4029393) [0x114c5dbd1]
  43  uv_timer_get_due_in + 141 (Electron Framework + 4014349) [0x114c5a10d]
  43  node::EmitAsyncDestroy(node::Environment*, node::async_context) + 356079 (Electron Framework + 126754255) [0x11c167dcf]
  43  v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*) + 591 (Electron Framework + 25317791) [0x1160ab19f]
  43  v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 506 (Electron Framework + 26500970) [0x1161cbf6a]
  43  ??? (Electron Framework + 202695) [0x1148b77c7]
  43  ??? (Electron Framework + 203420) [0x1148b7a9c]
  43  ??? [0x174a7863c]
  43  ??? [0x174a7aa7a]
  43  ??? (Electron Framework + 212708) [0x1148b9ee4]
  43  ??? [0x1748f63b5]
  43  ??? (Electron Framework + 200252) [0x1148b6e3c]
  43  ??? (Electron Framework + 1294538) [0x1149c20ca]
  43  ??? [0x1748f6137]
  43  ??? (Electron Framework + 479773) [0x1148fb21d]
  43  ??? (Electron Framework + 844278) [0x1149541f6]
  43  v8::internal::Runtime::GetInternalProperties(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>) + 21620 (Electron Framework + 32187892) [0x1167385f4]
  43  v8::internal::StackGuard::HandleInterrupts(v8::internal::StackGuard::InterruptLevel) + 1094 (Electron Framework + 26737766) [0x116205c66]
  43  v8::internal::Isolate::InvokeApiInterruptCallbacks() + 216 (Electron Framework + 26600040) [0x1161e4268]
  43  v8::debug::BreakRightNow(v8::Isolate*, v8::base::EnumSet<v8::debug::BreakReason, int>) + 43 (Electron Framework + 26250747) [0x11618edfb]
  43  v8::internal::Debug::HandleDebugBreak(v8::internal::IgnoreBreakMode, v8::base::EnumSet<v8::debug::BreakReason, int>) + 280 (Electron Framework + 26324616) [0x1161a0e88]
  43  v8::internal::Debug::OnDebugBreak(v8::internal::Handle<v8::internal::FixedArray>, v8::internal::StepAction, v8::base::EnumSet<v8::debug::BreakReason, int>) + 286 (Electron Framework + 26302846) [0x11619b97e]
  43  v8_inspector::V8DebuggerId::pair() const + 14063 (Electron Framework + 35967023) [0x116ad302f]
  43  v8_inspector::V8DebuggerId::pair() const + 13184 (Electron Framework + 35966144) [0x116ad2cc0]
  43  node::SetTracingController(v8::TracingController*) + 113890 (Electron Framework + 128454402) [0x11c306f02]
  43  node::AsyncResource::get_async_id() const + 3057539 (Electron Framework + 56681203) [0x117e942f3]
  43  uv_cond_wait + 9 (Electron Framework + 4080489) [0x114c6a369]
  43  <patched truncated backtrace>
  43  __psynch_cvwait + 10 (libsystem_kernel.dylib + 17934) [0x7ff81152760e]
 *43  psynch_cvcontinue + 0 (com.apple.kec.pthread + 20777) [0xffffff8003049129]

Sentry ANR is implemented using a debugger（https://github.com/getsentry/sentry-javascript/blob/develop/packages/node/src/integrations/anr/worker.ts）, and it should match up with the above stack info. Disabling Sentry ANR prevents the issue from being reproduced.
Expected Result
main process should not freeze after wakeup
Actual Result
main process freezes after wakeup

Thanks for the detailed report. I guess we might need to disable ANR between suspend and resume events from the powerMonitor module.

@timfish  Do we have a disable ANR api or this API will be added in the future.?


Tasty-plutus tests

This task is to write tasty-plutus tests for this project.
(Make sure you're using the liqwid-labs version of the repo, other plutus-extra versions do not have the functions needed. You may need to change the version the project is currently using).
Tasty plutus tests work directly against the validator, so you'll need to test the two redeemers supported.
The tests will need to check the signing behaviour and the datum updating behaviour.
It's likely not worth testing for >10 accepted signers, as we'll usually be using it in a 5 signer mode, 3 needed.
Feel free to branch off of sam/initial-contracts before it is merged, I dont expect there to be many behavioural changes. I'll let you know if you'll need to rebase.

This is all done.


WIP: Courses application

Courses application
Implementation of core objects Course and CourseSubjects and related CMS pages, inspired from organizations

[x] models, factories,
[x] simple course wizard (settings relation with subjects and organizations is not yet possible)
[ ] course subject wizard
[ ] CMS template
[ ] more tests
[ ] factorize with organization common parts ?

@rmoch great PR! Enjoyed reading it during my jet lag insomniae #latinpluralftw


taskServiceAccountName doesn't work

Expected Behavior
When using following PipelineRun:
apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
  name: run-pipeline-ci
  namespace: tekton-bug
spec:
  taskRunSpecs:
    - pipelineTaskName: task-1
      taskServiceAccountName: service-account-1
    - pipelineTaskName: task-2
      taskServiceAccountName: service-account-2
  pipelineRef:
    name: pipeline-ci
  timeout: 1h0m0s

I would expect to have taskRuns with a correct serviceAccountName assigned.
Actual Behavior
No serviceAccountName is assigned. Look at the following TaskRun:
apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"tekton.dev/v1beta1","kind":"Task","metadata":{"annotations":{},"name":"task-1","namespace":"tekton-bug"},"spec":{"steps":[{"image":"node:dubnium","name":"task-1","script":"#!/bin/bash\necho \"Task 1\"\n"}]}}
    pipeline.tekton.dev/release: devel
  creationTimestamp: "2020-08-05T13:34:31Z"
  generation: 1
  labels:
    app.kubernetes.io/managed-by: tekton-pipelines
    tekton.dev/pipeline: pipeline-ci
    tekton.dev/pipelineRun: run-pipeline-ci
    tekton.dev/pipelineTask: task-1
    tekton.dev/task: task-1
  name: run-pipeline-ci-task-1-p9xb5
  namespace: tekton-bug
  ownerReferences:
  - apiVersion: tekton.dev/v1beta1
    blockOwnerDeletion: true
    controller: true
    kind: PipelineRun
    name: run-pipeline-ci
    uid: bfc2c17f-882f-4e12-81ef-a4aac6b87c2c
  resourceVersion: "23642933"
  selfLink: /apis/tekton.dev/v1beta1/namespaces/tekton-bug/taskruns/run-pipeline-ci-task-1-p9xb5
  uid: 273bf2f6-9c7d-41eb-bfce-517dd4a18bb7
spec:
  resources: {}
  serviceAccountName: ""
  taskRef:
    kind: Task
    name: task-1
  timeout: 1h0m0s
status:
  completionTime: "2020-08-05T13:34:42Z"
  conditions:
  - lastTransitionTime: "2020-08-05T13:34:42Z"
    message: All Steps have completed executing
    reason: Succeeded
    status: "True"
    type: Succeeded
  podName: run-pipeline-ci-task-1-p9xb5-pod-478zq
  startTime: "2020-08-05T13:34:32Z"
  steps:
  - container: step-task-1
    imageID: docker-pullable://node@sha256:02a5fd0329277d081e65ccb5964a82dd5d735c2a8a92f089656486b32c29da49
    name: task-1
    terminated:
      containerID: docker://d345dce62d3d45e656f2aedc016d1c21e435da32358fe71b65469847b29d298e
      exitCode: 0
      finishedAt: "2020-08-05T13:34:42Z"
      reason: Completed
      startedAt: "2020-08-05T13:34:41Z"
  taskSpec:
    steps:
    - image: node:dubnium
      name: task-1
      resources: {}
      script: |
        #!/bin/bash
        echo "Task 1"

Service account is empty:
  serviceAccountName: ""
Steps to Reproduce the Problem

Create a tekton-bug namespace.
Apply the following YAML:

apiVersion: v1
kind: ServiceAccount
metadata:
  name: service-account-1
  namespace: tekton-bug
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: service-account-2
  namespace: tekton-bug
---
apiVersion: tekton.dev/v1beta1
kind: Task
metadata:
  name: task-1
  namespace: tekton-bug
spec:
  steps:
    - name: task-1
      image: node:dubnium
      script: |
        #!/bin/bash
        echo "Task 1"
---
apiVersion: tekton.dev/v1beta1
kind: Task
metadata:
  name: task-2
  namespace: tekton-bug
spec:
  steps:
    - name: task-2
      image: node:dubnium
      script: |
        #!/bin/bash
        echo "Task 2"
---
apiVersion: tekton.dev/v1beta1
kind: Pipeline
metadata:
  name: pipeline-ci
  namespace: tekton-bug
spec:
  tasks:
  - name: task-1
    taskRef:
      name: task-1

  - name: task-2
    taskRef:
      name: task-2
---
apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
  name: run-pipeline-ci
  namespace: tekton-bug
spec:
  taskRunSpecs:
    - pipelineTaskName: task-1
      taskServiceAccountName: service-account-1
    - pipelineTaskName: task-2
      taskServiceAccountName: service-account-2
  pipelineRef:
    name: pipeline-ci
  timeout: 1h0m0s

Look at created taskRuns. Check the line with serviceAccountName.

Additional Info

Kubernetes version:
Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.6", GitCommit:"dff82dc0de47299ab66c83c626e08b245ab19037", GitTreeState:"clean", BuildDate:"2020-07-16T14:19:25Z", GoVersion:"go1.13.13", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.11", GitCommit:"d94a81c724ea8e1ccc9002d89b7fe81d58f89ede", GitTreeState:"clean", BuildDate:"2020-03-12T21:00:06Z", GoVersion:"go1.12.17", Compiler:"gc", Platform:"linux/amd64"}

Tekton Pipeline version:
Output of  kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}':

v0.14.2

/assign

i've just tested on master and haven't been able to reproduce this. I used https://github.com/tektoncd/pipeline/blob/master/examples/v1beta1/pipelineruns/no-ci/pipelinerun-taskrunspecs.yaml and updated the taskServiceAccountName field to be something other than "default".  When I ran the pipeline I got a TaskRun with my custom service account name in its serviceAccountName field.
I'll test with the 0.14 tag now.

Same result on the release-0.14.x tag in the repo: my custom serivce account name was propagated to my taskrun. @pciazynski could you try updating to 0.14.3 to see if that resolves your issue?

Just in case off, are you running a kubernetes distro (i.e: openshift, microk8 or others) or on minikube/pure kubernetes?

Thank you for the fast asnwers!
@sbwsg I updated tekton to v0.14.3 and tested again - I've got the same result, service account being not propagated...
@chmouel I run it on our company internal Kubernetes. It's unfortunately quite old - v1.15.11, and yes, maybe there is some strange configuration there which I'm not aware of. But anyway I thought it's rather a tekton bug, because this happens only when I try to use taskServiceAccountName, when I set a serviceAccountName for the whole pipeline, then it works fine.
Do you have any tip how can I debug it, why tekton is not populating this service account?

OK, it works even for me when I try directly example from here:  https://github.com/tektoncd/pipeline/blob/master/examples/v1beta1/pipelineruns/no-ci/pipelinerun-taskrunspecs.yaml with updating the taskServiceAccountName field to be something other than default.
So I need to examine what is wrong in my example...

Sorry guys for bothering you - my mistake. I've used apiVersion: tekton.dev/v1alpha1 for the kind: PipelineRun...
After changing to apiVersion: tekton.dev/v1beta1 things works as expected :)
Thanks a lot for help. I'm closing this one.

Ah, great catch!  Thanks for getting back to us with the update.


Feat/no data value

Default value of the parameter no_data_value  was set to None. In ExportToTiffTask this is the NoData value of pixels in exported images. In ImportFromTiffTask this value is assigned to the pixels with NoData.
Added test for different no_data_values  input to both ExportToTiffTask and ImportFromTiffTask .

Codecov Report

Merging #459 (7e18452) into develop (9cb033f) will increase coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 7e18452 differs from pull request most recent head 95e6f9e. Consider uploading reports for the commit 95e6f9e to get more accurate results

@@             Coverage Diff             @@
##           develop     #459      +/-   ##
===========================================
+ Coverage    82.74%   82.75%   +0.01%
===========================================
  Files           59       59
  Lines         5609     5609
===========================================
+ Hits          4641     4642       +1
+ Misses         968      967       -1

Impacted Files
Coverage Δ

io/eolearn/io/raster_io.py
90.90% <ø> (ø)

core/eolearn/core/graph.py
95.95% <0.00%> (+1.01%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Found a few trunctated hadith.

https://raw.githubusercontent.com/fawazahmed0/hadith-api/1/editions/eng-nasai/4255.json
It was narrated that Khalid said:"Al-Miqdam bi
https://sunnah.com/nasai:4255
It was narrated that Khalid said:
"Al-Miqdam bi8n Ma di Karib came to visit Mu awiyah and said to him: I adjure you by Allah, do you know that the messenger of Allah forbade wearing the Hides of predators and riding on them? He said: 'yes."

https://raw.githubusercontent.com/fawazahmed0/hadith-api/1/editions/eng-nasai/2781.json
"It was narrated from Hafsah, the wif"
https://sunnah.com/nasai:2781
"It was narrated from Hafsah, the wif3e of the Prophet, that she said:
"O Messenger of Allah, why is it that the people have exited Ihram for Umrah but you have not exited your Ihram for Umrah? He said: "I have matted my hair and garlanded my Hadi, so I will not exit Ihram until I have offered the sacrifice."

I can correct them, can you tell me how exactly do I do that?
You mentioned something related to github actions. I am not aware about that.

Ok, if you want to correct mistakes, this is how it should be done:
For Text Correction:
Go here , directly edit the text and create a PR.
For Grades correction:
Go here, directly edit the grades in info.json and create a PR.
If you want to edit something else, please do ask me.
I will take care of Github actions thing.


Remove language option

Api appears to have removed all but EN as a language choice

@rhyspowell other 2 tests are still failing as well. The payload also changed (origin keyword, see #28).
I think you want to do some mocking instead, pytest-vcr is quite nice.

Will take a look again, it passed on mine and the logs are missing from the tests when I look on the app

Also, as this doesn't have any real business logic, dropping down to a unit test level and using mocks is the wrong thing to do. If we did that we would think the module is fine but we need to be at the integration test level as we are dependant upon a 3rd party.

Yeah good point and distinction. If only mocking we're not testing it end-to-end. Let's just leave it as "real deal" then and fix them. The good thing is that the tests notified us of their API change. Thanks.


Log a debug message to the console

The bare minimum env_logger example.

I've taken a crack at this one as well as error messages. I'm at work now, I'll submit a PR later this evening.


Transfer learning cat_dog retraining script throws error.

I downloaded the dataset for retraining then next step was to start training script  but the following error shows up.
python: relocation error: /home/user2/.local/lib/python2.7/site-packages/torch/lib/libtorch.so: symbol cudnnGetBatchNormalizationForwardTrainingExWorkspaceSize version libcudnn.so.7 not defined in file libcudnn.so.7 with link time reference

Hmm...which version of JetPack-L4T are you using?    Are you using the container, or did you install PyTorch manually?
If you installed PyTorch manually, which PyTorch version and wheel did you install?

Hey, I use ```NVIDIA Jetson TX2
L4T 32.1.0 [ JetPack 4.2 ]
Ubuntu 18.04.2 LTS
Kernel Version: 4.9.140-tegra
CUDA 10.0.166
CUDA Architecture: 6.2
OpenCV version: 3.3.1
OpenCV Cuda: NO
CUDNN: <IP_ADDRESS>
TensorRT: <IP_ADDRESS>
Vision Works: <IP_ADDRESS>0n
VPI: NOT_INSTALLED
I installed pytorch with the script provided by this repository under ```/home/dasal/jetson-inference/build/install-pytorch.sh```

I'm not sure why you might have that error.  If possible, your best bet might be to upgrade your device to the latest JetPack, since JetPack 4.2 is getting older at this point.

So which version do you recommend 4.4 or 4.3?

I upgraded jetpack 4.2 to 4.4 and problem solved but still wondering what was causing that?

I upgraded jetpack 4.2 to 4.4 and problem solved but still wondering what was causing that?

I'm not entirely sure, but perhaps that version of PyTorch on JetPack 4.2 was linked against a newer version of cuDNN which removed that symbol.


Expose raw JSON for discriminated types

Expose the raw JSON for a discriminated type.  This is to support the scenario where the endpoint returns a type that is not yet modeled in swagger.

Per discussion, for unknown types we'll generate a new type that exposes the JSON.  It would look something like this.
type UnknownFish struct {
  Fish
  RawObject map[string]interface{}
}