Issues with VNTextProxy

It's not working with Golden Marriage.
SJIS tunneling is not working with Shukusei no Girlfriend.

For Golden Marriage I already checked the .exe, and there is reference to d3d9, also tried using locale emu function, but I didn't worked, so I don't know if this engine is incompatible or is just my game or something else. (AdvHD)
For Shukusei i also used d3d9,dll and it worked for font, but It didn't worked SJIS tunneling. (Whale Engine)

sjis_ext.zip
By the way, this is just a question, I tried using VNProxy with Doukyuusei English Version, but It seems this version It uses Images to display chars, so I was wondering if you know a possible solution or maybe someone else.

I wanted to ask more about this, I wanted to make a proxy for dsound, but when i already did it, the game crashed, i tried with 2 different games, well the thing is, I saw this, so I wanted to ask is that the reason my proxy is not working or is something else?
Also, for proxies, if i want to make one I need to add every function or i can only add the ones my game uses? asking this because d3d9.dll
DSound.zip

Let's go one game at a time. The above commit should make tunneling work for Shukusei no Girlfriend - could you try it out? If it still doesn't work, could you send me an adjusted script archive + sjis_ext.bin?

I wanted to ask more about this, I wanted to make a proxy for dsound, but when i already did it, the game crashed

Win32AToWAdapter.cpp also works with DirectSound, so if you create a proxy, it needs to be made aware of that (similar to the #ifdef VNTEXTPROXY_D2D1 in D2DProportionalizer.cpp).

Also, for proxies, if i want to make one I need to add every function or i can only add the ones my game uses?

Technically it's enough to only provide the functions your game uses, but for broader usage, it's of course safer to provide all of them. The d3d9 files in AlternateProxies were incomplete, but should be complete now.

Crash before showing modified text, also, i don't if this is related but my infile is Shift-jis, but my output file is ANSI

issue.zip

Please send an archive (.dat file) rather than one script file - or tell me which tool I can use to pack .dat files myself. I tried https://github.com/vn-tools/whale-tools but it doesn't seem to work for this game.

you can use https://github.com/Forlos/vn_re to pack into .dat again, /bin/acv1
script.zip Modified
script original.zip Original

The game isn't crashing because of VNTextProxy, but because the test message is too long (looks like it can be 256 characters at most). Please try shortening it.

Oh, I see, my bad, now it´s working, the only issue it's this, but I don't if is because the engine or not, anyway, thanks.

(looks like it can be 256 characters at most)
I think it's less, my text was around 231 characters, I guess.

The extra spaces after accented characters are indeed caused by the engine. It thinks they're full-width (Japanese) characters and thus gives them twice as much space as half-width (Latin) characters. For simpler engines, VNTextProxy can fix this kind of incorrect positioning automatically - however, this one is more complicated, meaning you'd have to reverse engineer the engine, find out where it checks the character type, and patch it so that all characters are treated as half-width.
In the meantime I also checked Golden Marriage and found that it was quite easy to make custom fonts and non-SJIS characters work there as well (see above commits).

@Arata12 check this, a note from the guy hacked tsujidou

@Arata12 check this, a note from the guy hacked tsujidou

Thanks, I'll check it later.
Tested with Golden Marriage.
It's working. Thanks for your help.

Hm, not sure if this will work for Whale engine. Why don't we change the inserted text to full-width and use vntextproxy to change the letters back to half-width like SystemNNN and Csystem, well, if that could fix the characters limit.


Change WriteVerbose to WriteError, so an error is emitted when no package is uninstalled

PR Summary

PR Context
This PR aims to solve the issue mentioned in https://github.com/PowerShell/PowerShellGet/issues/598. Currently, when someone goes to uninstall a package it can appear as though the operation has concluded successfully when it hasn't and unless they were using the -Verbose parameter they wouldn't be given any indication it hadn't succeeded (see aforementioned issue for an example of this happening).  The code I have added changes the WriteVerbose statement to use WriteError insteamd so that the cmdlet emits an error if no package is uninstalled.

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[ ] None
OR
[ ] Documentation needed

[ ] Issue filed:

User-facing changes

[ ] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

@Conorc32 this looks good :) I'm going to merge in!


Add Router Resource

Description of your changes
Fixes a part of #329
I have:

[x] Read and followed Crossplane's [contribution process].
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Tested manually. Added unit tests for the Client code, and I am currently working on the controller tests.

@psinghal20 ping :)

Hi @turkenh, sorry took a while. Tried to resolve all your comments and the conflicts. Please take a look, thanks for your patience.

@psinghal20 looks like your branch is failing because of some changes after make generate not committed. Would you mind fixing that?

@psinghal20 another ping, I think we are very close for merge :)

Just pushed a commit fixing the last minor issues.


Video Player show black scrren

Hi team,
i am facing a problem when i add secure flag WindowManager.LayoutParams.FLAG_SECURE in Andoid app the youtube player screen is black but audio is coming. please help me.

No clue about how to fix this. May be the author of this plugin can help, as we're depending on the plugin. https://github.com/pichillilorenzo/flutter_inappwebview

having the same issue on older devices. sound plays but video part is a blank, black screen


Fix s390x regressions

Add relocation handling needed after PR #3275
Fix incorrect handling of signed constants detected by PR #3056 test
Disable fuzzing tests that require pre-built v8 binaries
Disable cranelift test that depends on i128
Temporarily disable memory64 tests

Note: In addition to this PR, the endian fix in PR #3329 and the rsix build fix https://github.com/bytecodealliance/rsix/pull/53 are required to make the CI tests fully pass again on s390x.

Also: Using qemu 6.1 we should now be able to turn on upstream CI for the s390x platform.

I opened https://github.com/bytecodealliance/wasmtime/pull/3331 to pull in the s390x fix in rsix.

I opened #3331 to pull in the s390x fix in rsix.

Thanks, @sunfishcode !

@alexcrichton you were right, I just had to add a single saturating_add.    Given that this is just a one-line obvious fix to common code,  I've now updated this PR after all.   Let me know if you'd prefer me to take it out again.
Note that BranchRI max ranges were just completely wrong, but that type isn't currently used anywhere so it didn't matter.  I've now fixed this and used precise max ranges for all types, only capped by a max of 0xffff_ffff due to the u32 type.

Nah yeah that's what I would have expected for a saturating_add and it looks good to me! I think someone will still want to look over the sconst changes to the s390x backend though.

Also: Using qemu 6.1 we should now be able to turn on upstream CI for the s390x platform.

Just want to mention that we have now upgraded to 6.1 in #3325

Also: Using qemu 6.1 we should now be able to turn on upstream CI for the s390x platform.

Just want to mention that we have now upgraded to 6.1 in #3325

Excellent.   Not sure exactly what we need to do to add a CI job for s390x, I haven't done much with GitHub actions before ...

To add a CI job theoretically all that needs to be done is to copy/paste this block to add another entry below it, and then update the various values for s390x instead of aarch64.

To add a CI job theoretically all that needs to be done is to copy/paste this block to add another entry below it, and then update the various values for s390x instead of aarch64.

Thanks!  I'll give it a try once the two PRs are merged.

So can this be merged now?   This is now the final bit blocking successful builds on s390x ...

To add a CI job theoretically all that needs to be done is to copy/paste this block to add another entry below it, and then update the various values for s390x instead of aarch64.

This is now https://github.com/bytecodealliance/wasmtime/pull/3372 .   I also had to disable the lightbeam tests (just like on aarch64).


IPHONE X, XR there is space between tabbar and bottom margin.

Version
Tell us which versions you are using:

react-native-router-flux v4.0.1
react v16.6.3
react-native v0.57.8

Expected behaviour
Tab bar on iphone X should be on the bottom with no space on top.
Actual behaviour
But In our case we have white space between tabbar and bottom margin.
Steps to reproduce
For non-obvious bugs, please fork this component, modify Example project to reproduce your issue and include link here.
1.
2.
3.
Reproducible Demo

Please provide a minimized reproducible demonstration of the problem you're reporting.
Issues that come with minimal repro's are resolved much more quickly than issues where a maintainer has to reproduce themselves.

the same here

I found the issue. It is all about safe area view. When I wrap my code with safe area view this thing happens.

Hey @yestay90 and how did you solve this issue? Did you just remove SafeAreaView ?

yeah, just removed safeareaview and added statusbar view on the top in
order to set right top margin.
пт, 26 июл. 2019 г. в 01:31, Cristopher Jonas de Faria <
<EMAIL_ADDRESS>
Hey @yestay90 https://github.com/yestay90 and how did you solve this
issue? Did you just remove SafeAreaView ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aksonov/react-native-router-flux/issues/3513?email_source=notifications&email_token=ACHCS6RSON536D6K6IOOGYLQBH5SPA5CNFSM4H62QY42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD22RDRY#issuecomment-515183047,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACHCS6SNF7SUEHTAKYD2V6TQBH5SPANCNFSM4H62QY4Q
.

--
*Естай Муратов    *
*iOS разработчик  *
+ 7 747 777 01 45

i have
<Fragment>
    <StatusBar />
    <Router>...</Router>
</Fragment>

I tried to add SafeAreaView in different places, but top nav bar was still showing behind the notch, and the bottom line was still across the bottom tab bar.
no luck so far, yet...

@jqtruong Did you mange to solve this issue?

same problem here, did you guys solve it?


Should collections consume 2 resources in "Limit number of Resources [146]"?

Currently the Zally implementation literally counts the number of path entries in the swagger file and ensures that this number is below some configured paths_count_limit (currently 8). This has the effect that any collection of things instantly burns up two of the allowed paths /things and /things/{id} - is that the intention of this guideline?
In my team we were considering a variation where we just put a limit on the count of top-level resources i.e. /things, /things/{id}, /things/{id}/related-thing/ all count as a single top-level resource, where /extra/, /extra/stuff/ would count as a second top-level resource. It occurred to me that this might have been the original intention of the rule?

PR #361 opened.
I chose to use the term "resource family" for grouping related resources since "type" is too strongly associated with json schemas and produces/consumes media types in this context. Hope that's ok.


Missing Fields in Income Statement Facts

For some 10Q imports, some facts are missing when querying the facts table.
For example, in the latest 10Q (Q2 2024) for $GD, the 10Q contains rows for Costs of Products and Services (us-gaap:CostOfGoodsAndServicesSold) but this fact is never loaded into the facts table in Edgar-tools or in the income-statement printed.
Likewise for "us-gaap:InterestIncomeExpenseNet" and "us-gaap:OtherNonoperatingIncomeExpense" facts.
This may possibly be related to these fields having a role of "http://fasb.org/us-gaap/role/ref/legacyRef" while most of the facts that do get loaded have a role of "http://www.xbrl.org/2003/role/disclosureRef"

https://www.sec.gov/ix?doc=/Archives/edgar/data/40533/000004053324000035/gd-20240630.htm

Hey Amit,
I'm working on a rewrite of the XBRL financials the intent of which is to render the data row for row as it is in the financials statements. Here is what it looks like now for General Dynamic

It's technically inside of edgartools now, but I need a few more rounds of testing to get it rock solid. I have been incorporating you findings in the new code base so that thanks for that. Should be stable within a week or so
Will keep you posted

Tracking changes on Financials Extraction from XBRL


Convert taggerlist and workloadlist commands to apps

What does this PR do?
Converts the agent taggerlist and agent workloadlist commands to Fx Apps.
Motivation
Top-down approach to componentization.
Additional Notes
This PR is against a base branch containing #13699 and #13662.  Once those are merged, I'll change the base of this PR to main and rebase, but it can be reviewed in the interim.
Possible Drawbacks / Trade-offs

Describe how to test/QA your changes
Run the various commands and verify that they still work.
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

TestGatewayLookupSubnetLookupError failure in dd-gitlab/kitchen_test_system_probe_linux_x64: [debian, debian-10,debian-11] is a known intermittent and can be ignored.

Hello @djmitche, are there any remaining blockers on merging this? We want to start componentizing the DCA as well, and these two commands will also live there after #13844 lands, so it would be nice to be able to share some of this code.

Nope, I was just waiting overnight for CI, and it looks like it's green except the flaky kitchen tests.


Update declaration of ts.Iterator to be compatible with ES2015 IteratorResult type

TypeScript Version:  3.5.0-dev.20190502

Search Terms:
Code
I'm trying to use the API changes of #31101, but I run into assignability issues.
import * as ts from 'typescript';
return ts.getParsedCommandLineOfConfigFile('foo', {}, undefined!, new Map<string, ts.ExtendedConfigCacheEntry>());

Expected behavior:
No type error.
Actual behavior:
Argument of type 'Map<string, ExtendedConfigCacheEntry>' is not assignable to parameter of type 'Map<ExtendedConfigCacheEntry>'.
  Types of property 'keys' are incompatible.
    Type '() => IterableIterator<string>' is not assignable to type '() => Iterator<string>'.
      Type 'IterableIterator<string>' is not assignable to type 'Iterator<string>'.
        Types of property 'next' are incompatible.
          Type '(value?: any) => IteratorResult<string>' is not assignable to type '() => { value: never; done: true; } | { value: string; done: false; }'.
            Type 'IteratorResult<string>' is not assignable to type '{ value: never; done: true; } | { value: string; done: false; }'.
              Type 'IteratorResult<string>' is not assignable to type '{ value: string; done: false; }'.
                Types of property 'done' are incompatible.
                  Type 'boolean' is not assignable to type 'false'.

This isn't an issue with lib.d.ts, but our own definition in src/compiler/core.ts. This should be fixed when #30790 is merged.

@rbuckton this issue still exists with the latest nightly release. The error message is still the same. Can you please reopen this issue?


Zombieland 1.4 version causes desynchronization when playing online. Can you make it compatible?

Issues is not a wishlist, imagine the spam. If you want to be helpful you need to detail the issues, provide logs and do testing.


gpg wasn't found (make sure it's available on the PATH)

Hi,
I'm trying kubesec on my Macbook, and I got this error :
`gpg` wasn't found (make sure it's available on the PATH)

But, it's strange, because gpg command work fine :
15:05:18 › which gpg
/usr/local/bin/gpg

15:05:20 › gpg
gpg: Go ahead and type your message ...
^C
gpg: Interrupt caught ... exiting

Thanks a lot, this tool look awesome.

@valentin2105 Thank you for the issue. Fixed in 0.1.1. :balloon:


Create New features upload

VulnSniff V1.1.0 features just rolled out!!!!

please do check our release note and README.md file for further and easy useability.


Alt-key does not toggle menu bar

VS Code Version:1.5.222
OS Version:Windows 21359.1 (German Swiss)

Steps to Reproduce:
1.Install Visual Code
2.Hide menu bar and activity bar under View
3.Press Alt key
Nothing happens
Reproduced on two workstations with similar setup. One a newly created VM.

Does this issue occur when all extensions are disabled?: Yes

@vscode-triage-bot although related this seems to be a different problem.

duplicate https://github.com/microsoft/vscode/issues/85124

If corrected the documentation according current behaviour.


Time Picker - Disable Default Time Value

By default, the time picker picks the value closest to the operating system timezone.  How do I disable this?

Especially "older" users will think a time is already selected, so I would like to disable highlighting of a "default" value as wel...

Did someone find a solution for this issue?

I solved my problem by remove the css style after rendered, and it works.
$('#picker').pickatime({
      //disable default highlight
      onRender: function() {
           $('ul.picker__list li').removeClass('picker__list-item--highlighted');
      }
});


New tagged release so Go modules users get recent code

The last release tag is from three years ago.  People depending on martian through go modules will get that by default, so I think making a new tag for something more recent might be warranted.

Added v2.1.0


Chore remove unused code about rowset tree

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall.

run buildall


[Feature Request] How to send additional parameters to on-success callback of Upload component?

Existing Component
是
Component Name
Upload
Description
I am working on a project, where there is a scenario I need to use a v-for loop to render Upload component, and I want to send additional parameters to on-success callback to write different codes for corresponding for-loop element. The code I write is as follows, and I want to send additional "v.key" to on-success callback. How could I do that? Thanks a lot.

Hi!
How you fixed this? I'm with the same problem.


Add variableRegexp property

I'm using this to parse formulas where the propositional variables are sentences about Tarski's World -- like Tet(a), Between(a, b, c), etc. --, like this:
// variableKey, unaries and binaries definitions here

var variableRegexp = /^[A-Z][^\)]*\)/;
var TarskiPropositionalFormulaParser = new FormulaParser(variableKey, unaries, binaries, variableRegexp);

Other people might need similar functionality, so I created this PR.
The earlier way of calling the constructor (without the variableRegexp argument) still works, and sets the variableRegexp property such that the class behaves identically to the earlier version.

Hey @tbitai, thanks for the PR!
I actually made this module in a way that is complete for a very specific set of functionality—in particular, it's quite sensitive about parentheses and whitespace, so I'm afraid that changing the definition of a variable would remove some of its "soundness".
That said, if you read the Limitations section of the README closely, you'll notice that there's actually a way to do this already! :smile:
var FormulaParser = require('formula-parser');

var variableKey = 'prop';

// define any predicates/function symbols as unaries:
var unaries = [
  { symbol: 'Between', key: 'btwn', precedence: 3 },
  { symbol: '~',       key: 'neg',  precedence: 3 }
];

// define comma as a binary operator:
var binaries = [
  { symbol: ',',   key: 'sepr', precedence: 2, associativity: 'right' },
  { symbol: '|',   key: 'disj', precedence: 1, associativity: 'right' }
];

var Parser = new FormulaParser(variableKey, unaries, binaries);

Parser.parse('Between(a,b,c) | ~Between(a,b,c)')

→
{ "disj": [
  { "btwn":
    { "sepr": [
      { "prop": "a" },
      { "sepr": [
        { "prop": "b" },
        { "prop": "c" }
      ]}
    ]}
  },
  { "neg":
    { "btwn":
      { "sepr": [
        { "prop": "a" },
        { "sepr": [
          { "prop": "b" },
          { "prop": "c" }
        ]}
      ]}
    }
  }
]}

Wow, that's smart, thanks! :) The trick of defining comma as an operator didn't come to my mind. This is actually better for me, because it treats Between(a,b,c) and Between(a, b, c) [with whitespaces] the same.
In the light of this and your soundness argument, I'm closing this.


Added collection status update and some UI changes

The merge conflict is due to lead/trail spaces.


Runtime logging?

Is your feature request related to a problem? Please describe.
I want lowlevel debug information from the driver (both queries sent by my code and implicit commands such as the SAVEPOINT management) and be able to control when I see them and eg prefix log entries with additional information
Describe the solution you'd like
There were already a few debug hooks, eg:
const debug = (() => void 0) as any;// _debug("pgc:connection");

but even if reenabled they would go to the debug package. I'd like to inject this handler myself, and would also like some more information where the debug command comes from so I can selectively enable/disable Connection's and IntlConnection's statements
There are many ways to do that and I have no problems coding it, but it would be nice if I can find an approach that upstream would like to support/keep too.
One approach could be
export const onPgcDebug = null; //there should be an API/hook to explicitly set this

pgcDebug(source: "IntlConnection" | "Connection" | "Pool", format: string, ...args: unknown[]): void {
  if(onPgcDebug)
    onPgcDebug(source, format, ...args);
}

and to update the various ts files to do:

- debug("[%s] ref %d", this.processID, this._refCount);
+ pgcDebug("IntlConnection", "[%s] ref %d", this.processID, this._refCount);

or

- const debug = (() => void 0) as any;// _debug("pgc:intlcon");
+ const debug = (format, ...args) => pgcDebug("intlConnection", format, ...args)

It's still not completely what I need as ideally this would be bound to an AsyncContext and/or the debug API would receive the associated connection so I can specifically debug the actions associated with a specific incoming request. We haven't verified yet how asynccontext-safe postgresql-client is so we might still run into issues there in the end.
Describe alternatives you've considered
Not really, unless we can get TC39 to consider adding #define to JavaScript.
We depend on fine grained debugging of the SQL actions related to specific requests so any debugging support gets quite intrusive fast. If needed we could fork and maintain the debugging solution ourselves.

Hi, i ve disabled "debug" library because it vulnerable. Here is the report
Dependency npm:debug:4.3.4 is vulnerable
Cx8bc4df28-fcf5 7.5  Inefficient Regular Expression Complexity vulnerability pending CVSS allocation
Results powered by Checkmarx(c)

The "debug" package has not been updated for a year.

I ve just released 2.7.0. which includes "debug" events in Pool and Connection.
do get debug events just use
pool.on('debug', info => console.log(info.message))

connection.on('debug', info => console.log(info.message))

@erayhanoglu thanks, this is a much nicer interface
It would be nice to expose the types of the debugmessages, eg for Connection
interface ConnectionDebugEvent {
  location: string;
  connection: Connection;
  message: string;
  sql?: string;
}

(I played a bit with getting emit("debug") to actually typescript-validate the debug message, but gave up after about 10 minutes because it's a bit tricky with SafeEventEmitter defining a generic emit which caused any debug message to validate anyway)
One drawback is that you also removed the debug statements from intl-connection.ts so you can't see the savepoint etc commands happening behind the scenes (which helped me when debugging #20).  Even if the endpoints are still there and require a TS override or patching it's nice to have them during a complex debugging session.

Hi.
I am sorry but i couldn't get what you mean with "typescript-validate", and did not understand with the problem with SafeEventEmitter. It is extended from EventEmitter and only difference is it doesnt throw Error on ("error") event.
Yes i ve removed "debug" statements. Because "debug" package is vulnerable. But emit('debug') can be used. You may make a patch.

Check, here's the patch: https://github.com/panates/postgresql-client/pull/28
It doesn't define a public API for it, but it's cleaner than patching console.logs straight into pgsocket


Document how entrypoints work

The mechanism via which entrypoints into

a generated binary and
an execution engine set up with a generated module
are generated, set up, and called, in both standalone cairo programs and contracts should be documented.
how the compiler generates the entrypoints and represents them with MLIR
how an entrypoint is selected for execution through the API and command line runner
How arguments are passed to the entrypoint (can link to relevent existing documentation)

Please can I be assigned this? @igaray

Hi @igaray can I be assigned this issue, please.

I believe this is now done here: https://github.com/lambdaclass/cairo_native/blob/main/docs/execution_walkthrough.md
closing as done then


Request better categorisation to have up to date list of Projects in scope for SIG Observability.

Tracking ticket to improve https://landscape.cncf.io/ to add some SIG-based label (:
cc @caniszczyk  @idvoretskyi  :hugs:
Will add JIRA issue for this.

@bwplotka if you have any enhancements in mind for the CNCF Landscape, you may submit a PR directly to https://github.com/cncf/landscape.

Ack :hugs:

Done: https://github.com/cncf/landscape/issues/1632

Looks like Dan had very good point: https://github.com/cncf/landscape/issues/1632#issuecomment-638763810
Adding PR now.

Done (:


Bump zend-servicemanager to ^3.4

zend-servicemanager 3.4.0 enabled plugin managers to accept psr containers not implementing interop interface as a creation context.
This PR bumps used version to ^3.4 to ensure zend-view works with different containers.

This repository has been closed and moved to mezzio/mezzio-skeleton; a new issue has been opened at https://github.com/mezzio/mezzio-skeleton/issues/1.

This repository has been moved to mezzio/mezzio-skeleton. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

Squash all commits in your branch (git rebase -i origin/{branch})
Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
Run the laminas/laminas-migration tool on the code.
Clone mezzio/mezzio-skeleton to another directory.
Copy the files from the second bullet point to the clone of mezzio/mezzio-skeleton.
In your clone of mezzio/mezzio-skeleton, commit the files, push to your fork, and open the new PR.
We will be providing tooling via laminas/laminas-migration soon to help  automate the process.


Drop django-admin-related translations

Saleor does not use django-admin and these add an unnecessary burden on translators who have no way to verify their work.
Related team discussion: https://github.com/orgs/mirumee/teams/open-source/discussions/1
Pull Request Checklist
(Please keep this section. It will make maintainer's life easier.)

[x] Privileged views and APIs are guarded by proper permission checks.
[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] Database queries are optimized and the number of queries is constant.
[x] The changes are tested.
[x] The code is documented (docstrings, project documentation).
[x] Python code quality checks pass: pycodestyle, pydocstyle, pylint.
[x] JavaScript code quality checks pass: eslint.

Codecov Report

Merging #1360 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1360      +/-   ##
=========================================
- Coverage   82.06%   81.9%   -0.17%
=========================================
  Files         114     114
  Lines        5492    5443      -49
  Branches      637     637
=========================================
- Hits         4507    4458      -49
  Misses        830     830
  Partials      155     155

Impacted Files
Coverage Δ

saleor/cart/models.py
99.34% <ø> (-0.02%)
:arrow_down:

saleor/product/models.py
91.04% <ø> (-0.54%)
:arrow_down:

saleor/userprofile/models.py
87.83% <ø> (-0.77%)
:arrow_down:

saleor/discount/models.py
88.76% <ø> (-0.25%)
:arrow_down:

saleor/shipping/models.py
77.14% <ø> (-1.24%)
:arrow_down:

saleor/order/models.py
88.88% <ø> (-0.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c206a...317f3e6. Read the comment docs.


Unable to deploy contract for unknown reasons

Environment information
Latest ape
python 3.9.7
macos
What went wrong?
tried to deploy ERC721 contract by itself (from open zeppelin)
ran into this error:
~/PycharmProjects/ape/src/ape_ethereum/ecosystem.py in encode_calldata(self, abi, *args)
    232         if abi.inputs:
    233             input_types = [i.canonical_type for i in abi.inputs]
--> 234             return abi_encode(input_types, args)
    235
    236         else:

....

ValueOutOfBounds: Value `()` of type <class 'tuple'> cannot be encoded by TupleEncoder: value has 0 items when 2 were expected

How can it be fixed?
Verify args and inputs first? not sure why it is failing

seems like it should be if len(abi.inputs) > 0

Incidentally fixed by #313 !


sendEvent doesn't support custom properties

Versions

0.2.2

Describe the bug
I'm trying to use custom props in the events, the same way you do in your cloud-hosted client, however it is not supported in the NPM package.
Expected behavior
Send custom properties for the event and get them captured and displayed in the dashboard.
Steps to reproduce

Steps:

Install normally
Assign it to a variable

import Plausible from 'plausible-tracker';
const tracker = Plausible({
  domain: 'mydomain.com',
  apiHost: 'https://tracker.mydomain.com'
});

I tried both, sending it in the data and in the options parameter, no one worked

tracker.trackEvent(event, {}, {props: {style: 'red'}})
// and
tracker.trackEvent(event, {props: {style: 'red'}})

Your Environment

Device: Desktop
OS: Mac
Browser: Chrome
Version: 86.0.4240.183

Additional context
I would like to know if this package has fewer options or if is it "outdated" compared to your cloud-hosted JS client. The point for me of using this package is to integrate the JS client in my app.js application so I don't have to rely on loading external scripts. It would be great that this package is up-to-date with what you actually run on your cloud client (a.k.a.: https://plausible.io/js/plausible.js)

You are correct, it was outdated, but now with v0.3.0 it should support custom props on events. Please give it a try and let me know if it works correctly :)

You are correct, it was outdated, but now with v0.3.0 it should support custom props on events. Please give it a try and let me know if it works correctly :)

It works now, tyvm for the quick response taken!


fix typo metric_resolution argument

fix document of heapster argument metric_resolution

This change is

@TinySong Could you please also change --metric_resolution to --metric-resolution. As heapster command line argument will replace all _ with -.

/ok-to-test


Use the rspec rake task

By analyzing the blame information on this pull request, we identified @activars to be a potential reviewer

Thanks

A new version has been published to rubygems.


GenericCheckArrayBound elimination does not use range analysis results

This seems a regression from older implementation which used to keep bounds checks represented as CheckArrayBound until much later in pipeline and then converted them into GenericCheckArrayBound.
In the code below I would expect to see a single bounds check, however in AOT version I see two.
double foo(Float64List l) {
  return l[1] + l[0];
}

In general it seems a bit weird to have two different IsRedundant methods - I think they should be merged into a single method.
I have made prototype of the fix:
diff --git a/runtime/vm/compiler/backend/il.h b/runtime/vm/compiler/backend/il.h
index ded19366d0..4a04b8ca1a 100644
--- a/runtime/vm/compiler/backend/il.h
+++ b/runtime/vm/compiler/backend/il.h
@@ -7696,6 +7696,8 @@ class CheckBoundBase : public TemplateDefinition<2, NoThrow, Pure> {
   // Give a name to the location/input indices.
   enum { kLengthPos = 0, kIndexPos = 1 };

+  bool IsRedundantBasedOnRangeInformation(const RangeBoundary& length);
+
  private:
   DISALLOW_COPY_AND_ASSIGN(CheckBoundBase);
 };
diff --git a/runtime/vm/compiler/backend/range_analysis.cc b/runtime/vm/compiler/backend/range_analysis.cc
index f99ae1fa2e..c1794d4a28 100644
--- a/runtime/vm/compiler/backend/range_analysis.cc
+++ b/runtime/vm/compiler/backend/range_analysis.cc
@@ -1317,16 +1317,17 @@ void RangeAnalysis::EliminateRedundantBoundsChecks() {
diff --git a/runtime/vm/compiler/backend/il.h b/runtime/vm/compiler/backend/il.h
index ded19366d0..4a04b8ca1a 100644
--- a/runtime/vm/compiler/backend/il.h
+++ b/runtime/vm/compiler/backend/il.h
@@ -7696,6 +7696,8 @@ class CheckBoundBase : public TemplateDefinition<2, NoThrow, Pure> {
   // Give a name to the location/input indices.
   enum { kLengthPos = 0, kIndexPos = 1 };

+  bool IsRedundantBasedOnRangeInformation(const RangeBoundary& length);
+
  private:
   DISALLOW_COPY_AND_ASSIGN(CheckBoundBase);
 };
diff --git a/runtime/vm/compiler/backend/range_analysis.cc b/runtime/vm/compiler/backend/range_analysis.cc
index f99ae1fa2e..c1794d4a28 100644
--- a/runtime/vm/compiler/backend/range_analysis.cc
+++ b/runtime/vm/compiler/backend/range_analysis.cc
@@ -1317,16 +1317,17 @@ void RangeAnalysis::EliminateRedundantBoundsChecks() {

     for (intptr_t i = 0; i < bounds_checks_.length(); i++) {
       // Is this a non-speculative check bound?
-      auto aot_check = bounds_checks_[i]->AsGenericCheckBound();
-      if (aot_check != nullptr) {
+      if (auto aot_check = bounds_checks_[i]->AsGenericCheckBound()) {
         auto length = aot_check->length()
                           ->definition()
                           ->OriginalDefinitionIgnoreBoxingAndConstraints();
         auto array_length = RangeBoundary::FromDefinition(length);
-        if (aot_check->IsRedundant(array_length)) {
+        if (aot_check->IsRedundant(array_length) ||
+            aot_check->IsRedundantBasedOnRangeInformation(RangeBoundary::FromDefinition(aot_check->length()->definition()))) {
           aot_check->ReplaceUsesWith(aot_check->index()->definition());
           aot_check->RemoveFromGraph();
         }
+
         continue;
       }
       // Must be a speculative check bound.
@@ -2931,7 +2932,7 @@ void IntConverterInstr::InferRange(RangeAnalysis* analysis, Range* range) {
   }
 }

-bool CheckArrayBoundInstr::IsRedundant(const RangeBoundary& length) {
+bool CheckBoundBase::IsRedundantBasedOnRangeInformation(const RangeBoundary& length) {
   Range* index_range = index()->definition()->range();

   // Range of the index is unknown can't decide if the check is redundant.
@@ -2985,6 +2986,10 @@ bool CheckArrayBoundInstr::IsRedundant(const RangeBoundary& length) {
   return false;
 }

+bool CheckArrayBoundInstr::IsRedundant(const RangeBoundary& length) {
+  return IsRedundantBasedOnRangeInformation(length);
+}
+
 // Check if range boundary and invariant limit are the same boundary.
 static bool IsSameBound(const RangeBoundary& a, InductionVar* b) {
   ASSERT(InductionVar::IsInvariant(b));

But I currently have enough of time on my hands to properly land this and add tests. I think the proper fix is just to merge IsRedundant into a single method on the base class.
(Important caveat: for range based bounds check elimination it is important to not unwrap length before creating boundary - because it can be constrained).

@aartbik Aart, could you take a look at this given that you were working on this code last?

@mraleph : my pleasure!

I agree it would make sense to have IsRedundant() in the base with shared code. However, some tests are specific for JIT (speculative) vs. AOT (non-speculative). So having a virtual method in the base (shared code) and the two versions (specific code) seems to make most sense. It will also clean up some of the loops inside the range analysis.

@aartbik when I glanced over the code it seemed to be that both versions can be used both in AOT and JIT  - they are making decision whether bounds check is redundant based on the results of the static analysis of the code (range analysis and induction variable discovery) and those analyses should not return different results depending whether we are in AOT or JIT. That is why it seemed to me that they can be merged. But I might be wrong because I only glanced over it.

@mraleph I should have phrased better. The redundancy tests themselves are probably not reall that much JIT/AOT specific, but I vaguely remember you telling me that the actual range computation used by JIT relies on Smi's deopting when overflowing, so that "arithmetic wrap-around" is not an issue. That is why I was a bit careful directly merging all tests, but I may be overly conservative. I will check the code carefully.

@aartbik that is correct range analysis relies on the fact that smi operations deopt on overflow. However, I believe, that this does not mean results of the range analysis are incorrect in AOT - computed ranges should be valid. e.g. if there are some Smi instructions in the graph - we will either prove that they don't deoptimize (don't overflow) or we will fail to generate code.


Optimize metadata merge protocol

Metadata merges as initially implemented in #41 fetch data batches synchronously within the flow of the query stream.
This may be fine for small merges, but throughput will suffer in larger merges and potentially hold up open query result sets in the source.
The data merge can be implemented with a background goroutine fetching data batches as requested by the primary merge goroutine through a buffered channel.

Measurements showing performance improvement from v1.0 with the optimizaitons in #68:
mcnode-v1.0:
1000 [0-1k]   0m10.233s
1000 [1k-2k]  0m10.287s
2000 [2k-4k]  0m17.673s
4000 [4k-8k]  0m33.720s
8000 [8k-16k] 1m4.431s

mcnode/parallel-fetch
1000 [0-1k]   0m8.716s
1000 [1k-2k]  0m9.709s
2000 [2k-4k]  0m15.859s
4000 [4k-8k]  0m26.150s
8000 [8k-16k] 0m47.155s

mcnode/parallel-fetch+merge-batch
1000 [0-1k]   0m5.598s
1000 [1k-2k]  0m6.325s
2000 [2k-4k]  0m8.548s
4000 [4k-8k]  0m18.896s
8000 [8k-16k] 0m34.640s

These measurements come from my laptop, with 4vcpus (2 cores, 4 threads) and pretty lousy bandwidth and latency from the peer node.
The test was performed with a clean database, with successive merges from QmeiY2eHMwK92Zt6X4kUUC3MsjMmVb2VnGZ17DhnhRPCEQ with the query SELECT * FROM images.dpla LIMIT ${x}000

Measurements from an ec2 test node:
1000 [0-1k]  0m0.731s
1000 [1k-2k]  0m1.018s
2000 [2k-4k]  0m1.639s
4000 [4k-8k]  0m2.805s
8000 [8k-16k] 0m5.386s

100k merge in ec2 in 35s:
$ time mcclient merge QmeiY2eHMwK92Zt6X4kUUC3MsjMmVb2VnGZ17DhnhRPCEQ "SELECT * FROM images.dpla LIMIT 100000"
merged 100000 statements and 100000 objects

real    0m35.354s
user    0m0.265s
sys     0m0.025s

1MM merge in ec2:
$ time mcclient merge QmeiY2eHMwK92Zt6X4kUUC3MsjMmVb2VnGZ17DhnhRPCEQ "SELECT * FROM images.dpla LIMIT 1000000"
merged 1000000 statements and 1000000 objects

real    6m31.248s
user    0m0.253s
sys     0m0.037s

:+1:

A final measurement with an additional optimization (occurs check delayed until request time, so that it can happen in parallel):
$ time mcclient merge QmeiY2eHMwK92Zt6X4kUUC3MsjMmVb2VnGZ17DhnhRPCEQ "SELECT * FROM images.dpla LIMIT 1000000"
merged 1000000 statements and 1000000 objects

real    6m23.390s
user    0m0.264s
sys     0m0.025s

so we are merging at a cool 2.5K writes/s


Grafana with multiple prometheus datasource

What did you do?
Created two prometheus instances listening on different ports

Prometheus Operator version:
release-0.26

Installed via yaml:
/prometheus-operator/tree/release-0.26/contrib/kube-prometheus/manifests
What do I want to do?
I want to connect both prometheus instances as datasources
My Question:
Where and what change I make in manifests files to add additional prometheus instance?

I found soultion here is example in ansible:
Create data sources file "grafana-datasources.yaml.j2":
apiVersion: 1
datasources:

name: core0
type: prometheus
access: proxy
org_id: 1
url: http://prometheus-k8s-core0.monitoring.svc:9090
version: 1
editable: true
name: core1
type: prometheus
access: proxy
org_id: 1
url: http://prometheus-k8s-core1.monitoring.svc:9090
version: 1
editable: true

Update "grafana-dashboardDatasources.yaml" with varibale:
apiVersion: v1
data:
prometheus.yaml: {{ grafana_datasources }}
kind: Secret
metadata:
name: grafana-datasources
namespace: monitoring
type: Opaque
In ansible tasks load file content as base64 in "grafana_datasources" variable and render new "grafana-dashboardDatasources.yaml" file:

set_fact:
grafana_datasources: "{{ lookup('template', './grafana-datasources.yaml.j2') | b64encode }}"

name: render grafana-dashboardDatasources.yaml
template:
src: grafana-dashboardDatasources.yaml
dest: "/opt/rafay/monitoring/kube-prometheus/configs-yaml/manifests/grafana-dashboardDatasources.yaml"
owner: "{{ ansible_user }}"
group: "{{ ansible_user }}"
mode: 0600


Draft: luci-app-statistics: Generate graphs for humidity sensors

This makes a humidity graph appear for the sht3x I have connected to my OpenWrt machine.
However it also shows some artifacts that I don't understand:

If you spot the problem, please advise.

The sensors graphs are problematic, as the plugin is rather generic, and doesn't have quite as standardized output as CPU freq, conntrack etc.
The artifacts are likely related to either the temperature definitions, or alternatively empty/wrong RRD files in the directory. LuCI is pretty brute-force here and by default tries all found sensors, and you might need to explicitly disable the other sensors in the settings.
But humidity sensors are so scarce, that I do not see much value is placing that humidity definition there for everybody. So, I wouldn't like to include that definition into the main LuCI coce.

The sensors graphs are problematic, as the plugin is rather generic, and doesn't have quite as standardized output as CPU freq, conntrack etc.
The artifacts are likely related to either the temperature definitions, or alternatively empty/wrong RRD files in the directory. LuCI is pretty brute-force here and by default tries all found sensors, and you might need to explicitly disable the other sensors in the settings.

I hoped someone would discern the problem. It seems I have to understand and fix it then.

But humidity sensors are so scarce, that I do not see much value is placing that humidity definition there for everybody. So, I wouldn't like to include that definition into the main LuCI coce.

humidity sensors are supported by the kernel and collectd.  With that argument you can stop caring for the sensors plugin, because there are very little people using an alternative firmware on a router. And among them only a small amount enables the sensors plugin ...
In my bubble of open source development, improving the code is usually welcome if there are no (or only very little) downsides for the other users of the code.

FTR: The Test Build failure looks independant to my PR.

Iirc the rrdargs() callback is invoked for any found *.rrd so it will try to render a humidity graph even for non-humidity rrd files. I will have to dig into the code myself again but my hunch is that you need to return either the temperature or the voltage diagram description, depending on what dtype argument is passed to the rrdargs() function

I did as suggested on top of the tree from this PR and got:

So it seems the function isn't called for every rrd file, but for every sensor twice ...
Also dtype is always null, so I wonder if the caller is aware of this argument at all. I didn't dig deeper yet, maybe I find some time later this week.

We might need to resort to querying the *.rrd files using rrdtool info as we cannot infer the contained data from the file name/path alone as it is the case with other plugins.

We might need to resort to querying the *.rrd files using rrdtool info as we cannot infer the contained data from the file name/path alone as it is the case with other plugins.
@ukleinek - Can you provide me with the output of uci show luci_statistics as well as /usr/sbin/sensors -j ?

Sure:
root@happy:~# uci show luci_statistics
luci_statistics.collectd=statistics
luci_statistics.collectd.BaseDir='/var/run/collectd'
luci_statistics.collectd.PIDFile='/var/run/collectd.pid'
luci_statistics.collectd.PluginDir='/usr/lib/collectd'
luci_statistics.collectd.TypesDB='/usr/share/collectd/types.db'
luci_statistics.collectd.Interval='30'
luci_statistics.collectd.ReadThreads='2'
luci_statistics.collectd.Include='/etc/collectd/conf.d/*.conf'
luci_statistics.rrdtool=statistics
luci_statistics.rrdtool.default_timespan='1hour'
luci_statistics.rrdtool.image_width='600'
luci_statistics.rrdtool.image_height='150'
luci_statistics.rrdtool.image_path='/tmp/rrdimg'
luci_statistics.collectd_rrdtool=statistics
luci_statistics.collectd_rrdtool.enable='1'
luci_statistics.collectd_rrdtool.DataDir='/tmp/rrd'
luci_statistics.collectd_rrdtool.RRARows='288'
luci_statistics.collectd_rrdtool.RRASingle='1'
luci_statistics.collectd_rrdtool.RRATimespans='1hour' '1day' '1week' '1month' '1year'
luci_statistics.collectd_csv=statistics
luci_statistics.collectd_csv.enable='0'
luci_statistics.collectd_csv.StoreRates='0'
luci_statistics.collectd_csv.DataDir='/tmp'
luci_statistics.collectd_email=statistics
luci_statistics.collectd_email.enable='0'
luci_statistics.collectd_email.SocketFile='/var/run/collectd/email.sock'
luci_statistics.collectd_email.SocketGroup='nogroup'
luci_statistics.collectd_logfile=statistics
luci_statistics.collectd_logfile.enable='0'
luci_statistics.collectd_logfile.LogLevel='notice'
luci_statistics.collectd_logfile.File='/var/log/collectd.log'
luci_statistics.collectd_logfile.Timestamp='1'
luci_statistics.collectd_network=statistics
luci_statistics.collectd_syslog=statistics
luci_statistics.collectd_syslog.enable='0'
luci_statistics.collectd_syslog.LogLevel='warning'
luci_statistics.collectd_syslog.NotifyLevel='WARNING'
luci_statistics.collectd_unixsock=statistics
luci_statistics.collectd_unixsock.enable='0'
luci_statistics.collectd_unixsock.SocketFile='/var/run/collectd/query.sock'
luci_statistics.collectd_unixsock.SocketGroup='nogroup'
luci_statistics.collectd_apcups=statistics
luci_statistics.collectd_apcups.enable='0'
luci_statistics.collectd_apcups.Host='localhost'
luci_statistics.collectd_apcups.Port='3551'
luci_statistics.collectd_chrony=statistics
luci_statistics.collectd_chrony.enable='0'
luci_statistics.collectd_chrony.Host='<IP_ADDRESS>'
luci_statistics.collectd_chrony.Port='323'
luci_statistics.collectd_chrony.Timeout='2'
luci_statistics.collectd_conntrack=statistics
luci_statistics.collectd_conntrack.enable='0'
luci_statistics.collectd_contextswitch=statistics
luci_statistics.collectd_contextswitch.enable='0'
luci_statistics.collectd_cpu=statistics
luci_statistics.collectd_cpu.enable='1'
luci_statistics.collectd_cpu.ReportByCpu='1'
luci_statistics.collectd_cpu.ReportByState='1'
luci_statistics.collectd_cpu.ShowIdle='0'
luci_statistics.collectd_cpu.ValuesPercentage='1'
luci_statistics.collectd_cpufreq=statistics
luci_statistics.collectd_cpufreq.enable='0'
luci_statistics.collectd_curl=statistics
luci_statistics.collectd_curl.enable='0'
luci_statistics.collectd_df=statistics
luci_statistics.collectd_df.enable='0'
luci_statistics.collectd_df.Devices='/dev/mtdblock/4'
luci_statistics.collectd_df.MountPoints='/overlay'
luci_statistics.collectd_df.FSTypes='tmpfs'
luci_statistics.collectd_df.IgnoreSelected='0'
luci_statistics.collectd_df.ValuesPercentage='0'
luci_statistics.collectd_dhcpleases=statistics
luci_statistics.collectd_dhcpleases.enable='0'
luci_statistics.collectd_dhcpleases.Path='/tmp/dhcp.leases'
luci_statistics.collectd_disk=statistics
luci_statistics.collectd_disk.enable='0'
luci_statistics.collectd_disk.Disks='hda1 hdb'
luci_statistics.collectd_disk.IgnoreSelected='0'
luci_statistics.collectd_dns=statistics
luci_statistics.collectd_dns.enable='0'
luci_statistics.collectd_dns.Interfaces='br-lan'
luci_statistics.collectd_dns.IgnoreSources='<IP_ADDRESS>'
luci_statistics.collectd_entropy=statistics
luci_statistics.collectd_entropy.enable='0'
luci_statistics.collectd_exec=statistics
luci_statistics.collectd_exec.enable='0'
luci_statistics.collectd_interface=statistics
luci_statistics.collectd_interface.enable='1'
luci_statistics.collectd_interface.Interfaces='br-lan'
luci_statistics.collectd_interface.IgnoreSelected='0'
luci_statistics.collectd_ipstatistics=statistics
luci_statistics.collectd_ipstatistics.enable='0'
luci_statistics.collectd_iptables=statistics
luci_statistics.collectd_iptables.enable='0'
luci_statistics.@collectd_iptables_match[0]=collectd_iptables_match
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>traffic'
luci_statistics.@collectd_iptables_match[1]=collectd_iptables_match
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>traffic'
luci_statistics.collectd_irq=statistics
luci_statistics.collectd_irq.enable='0'
luci_statistics.collectd_irq.Irqs='2 3 4 7'
luci_statistics.collectd_iwinfo=statistics
luci_statistics.collectd_iwinfo.enable='1'
luci_statistics.collectd_load=statistics
luci_statistics.collectd_load.enable='1'
luci_statistics.collectd_memory=statistics
luci_statistics.collectd_memory.enable='1'
luci_statistics.collectd_memory.ValuesAbsolute='1'
luci_statistics.collectd_memory.ValuesPercentage='0'
luci_statistics.collectd_netlink=statistics
luci_statistics.collectd_netlink.enable='0'
luci_statistics.collectd_netlink.IgnoreSelected='0'
luci_statistics.collectd_netlink.VerboseInterfaces='br-lan'
luci_statistics.collectd_netlink.QDiscs='br-lan'
luci_statistics.collectd_nut=statistics
luci_statistics.collectd_nut.enable='0'
luci_statistics.collectd_nut.UPS='myupsname'
luci_statistics.collectd_olsrd=statistics
luci_statistics.collectd_olsrd.enable='0'
luci_statistics.collectd_olsrd.Port='2006'
luci_statistics.collectd_olsrd.Host='<IP_ADDRESS>'
luci_statistics.collectd_openvpn=statistics
luci_statistics.collectd_openvpn.enable='0'
luci_statistics.collectd_ping=statistics
luci_statistics.collectd_ping.enable='0'
luci_statistics.collectd_ping.TTL='127'
luci_statistics.collectd_ping.Interval='30'
luci_statistics.collectd_ping.Hosts='<IP_ADDRESS>'
luci_statistics.collectd_processes=statistics
luci_statistics.collectd_processes.enable='0'
luci_statistics.collectd_processes.Processes='uhttpd dnsmasq dropbear'
luci_statistics.collectd_sensors=statistics
luci_statistics.collectd_sensors.enable='1'
luci_statistics.collectd_sensors.IgnoreSelected='1'
luci_statistics.collectd_snmp6=statistics
luci_statistics.collectd_snmp6.enable='0'
luci_statistics.collectd_snmp6.Interfaces='br-lan'
luci_statistics.collectd_snmp6.IgnoreSelected='0'
luci_statistics.collectd_splash_leases=statistics
luci_statistics.collectd_splash_leases.enable='0'
luci_statistics.collectd_tcpconns=statistics
luci_statistics.collectd_tcpconns.enable='0'
luci_statistics.collectd_tcpconns.ListeningPorts='0'
luci_statistics.collectd_tcpconns.LocalPorts='22 80'
luci_statistics.collectd_thermal=statistics
luci_statistics.collectd_thermal.enable='0'
luci_statistics.collectd_thermal.IgnoreSelected='0'
luci_statistics.collectd_uptime=statistics
luci_statistics.collectd_uptime.enable='0'

root@happy:~# /usr/sbin/sensors -j
{
   "mv88e6xxx102-mdio-2":{
      "Adapter": "MDIO adapter",
      "temp1":{
         "temp1_input": 36.000,
         "temp1_crit": 100.000,
         "temp1_max_alarm": 0.000
      }
   },
   "mv88e6xxx100-mdio-0":{
      "Adapter": "MDIO adapter",
      "temp1":{
         "temp1_input": 36.000,
         "temp1_crit": 100.000,
         "temp1_max_alarm": 0.000
      }
   },
   "f1072004mdiomii01-mdio-1":{
      "Adapter": "MDIO adapter",
      "temp1":{
         "temp1_input": 41.000,
         "temp1_crit": 100.000,
         "temp1_max_alarm": 0.000
      }
   },
   "ath10k_hwmon-pci-0200":{
      "Adapter": "PCI adapter",
      "temp1":{
         "temp1_input": 41.000
      }
   },
   "mv88e6xxx103-mdio-3":{
      "Adapter": "MDIO adapter",
      "temp1":{
         "temp1_input": 36.000,
         "temp1_crit": 100.000,
         "temp1_max_alarm": 0.000
      }
   },
   "mv88e6xxx101-mdio-1":{
      "Adapter": "MDIO adapter",
      "temp1":{
         "temp1_input": 36.000,
         "temp1_crit": 100.000,
         "temp1_max_alarm": 0.000
      }
   },
   "f10e4078.thermal-virtual-0":{
      "Adapter": "Virtual device",
      "temp1":{
         "temp1_input": 49.408
      }
   },
   "sht3x-i2c-7-44":{
      "Adapter": "i2c-0-mux (chan_id 6)",
      "temp1":{
         "temp1_input": 18.162,
         "temp1_max": 59.931,
         "temp1_max_hyst": 57.880,
         "temp1_min": -10.137,
         "temp1_min_hyst": -9.112,
         "temp1_alarm": 0.000
      },
      "humidity1":{
         "humidity1_input": 47.810
      }
   },
   "mv88e6xxx104-mdio-4":{
      "Adapter": "MDIO adapter",
      "temp1":{
         "temp1_input": 36.000,
         "temp1_crit": 100.000,
         "temp1_max_alarm": 0.000
      }
   }
}

Thanks to @jow who (re)discovered that graph.dataTypes() allows to inspect the sensors data sources all available data sources get their respective graph, no ugly boxes any more. Thanks a lot!

The failed test build seems unrelated to my change. The error message is
ERROR: package/feeds/base/ltq-adsl failed to build (build variant: danube).


Training in Yolo format

I have YOLO Annotated text dataset in Folder structure
train:
images/.jpg
labels/.txt
val:
images/.jpg
labels/.txt
Got this Error after 1 epoch:
Loading and preparing results...
20230314_012420 edgeyolo.train.trainer:480 - error: Results do not correspond to current coco set

it means there's at least one image with empty label in your val dataset, just check your txt files and remove the empty files, then set use_cache to false to re-generate cache.

I got the same error and discovered that the problem in my case was caused because of different image formats mingled. By default, the Yolo dataloader takes only the '.jpg' images, while all annotations are taken (also from other image formats, like '.png'). That causes a mismatch.
I created a fix to take all images (despite of their format) and after testing, Ill create a pull request.

I got the same error and discovered that the problem in my case was caused because of different image formats mingled. By default, the Yolo dataloader takes only the '.jpg' images, while all annotations are taken (also from other image formats, like '.png'). That causes a mismatch.
I created a fix to take all images (despite of their format) and after testing, Ill create a pull request.

Well, typically the first step before annotating a dataset is to unify the image format, so I think it's the problem of nonstandard process when creating the dataset, not the code


cmd/go: require directive too strict on requiring space before parentheses?

What version of Go are you using (go version)?

$ go version
go version devel +5aef51a729 Sun Mar 29 02:01:34 2020 +0000 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build136829961=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Unclear whether this is by design or not, so raising for completeness. The following test fails when I would have expected it to pass:
# Test demonstrating the sensitivity of bracket placement
# for require directives

exec go mod tidy
cmp go.mod go.mod.golden

-- go.mod --
module mod.com

go 1.12

require()
-- go.mod.golden --
module mod.com

go 1.12

By comparison the Go tool chain is agnostic on whether there is a space after the keyword of a parenthesised general declaration.
What did you expect to see?
Passing test
What did you see instead?
# Test demonstrating the sensitivity of bracket placement
# for require directives (0.004s)
> exec go mod tidy
[stderr]
go: errors parsing go.mod:
$WORK/go.mod:5: unknown directive: require()

cc @bcmills @jayconrod @matloob

I've been looking at this for #24031. For the most part, the go.mod parser just splits tokens on whitespace. So replace() is one token. But note that if ( or ) is the first character after a space, it's always interpreted as a separate token from non-whitespace characters immediately after (so require ()more is four tokens, not two).
I don't think it's safe to change this tokenization in general: none of the ASCII bracket characters (( ) [ ] { }) are allowed in  module paths, but they are all allowed in file paths on the right side of replace directives. They're also allowed in unresolved versions. So if ( in the middle of a sequence of non-whitespace characters were lexed as a separate token, it might break some go.mod files for newer versions of the go command. And in any case, after such a change, old versions of the go command would not accept go.mod files written with this syntax.
replace example.com/m => ./foo() // this file path is one token

sounds like a won't fix.


TestNetworkUpgrade flaky

Resolved itself after a retry. This one is very suspicious as I'm not sure what "failed to get preview summary" indicates.
FAILED https://github.com/pulumi/pulumi-gcp/pull/1651
❌ TestNetworkUpgrade (3.89s)
      provider_test.go:47: installing packages and plugins
      provider_test.go:47: creating stack test
      provider_test.go:59: installing packages and plugins
      provider_test.go:59: creating stack test
      provider_test.go:59: run cache found at testdata/recorded/TestProviderUpgrade/network/6.67.0/stack.json
      provider_test.go:59: importing stack
      provider_test.go:59: previewing update
      provider_test.go:59: failed to preview update: failed to get preview summary
          code: 0
          stdout: Previewing update (test):

              pulumi:pulumi:Stack network-test running
              gcp:compute:Network exampleNetwork
              gcp:compute:Router exampleRouter
           +  gcp:compute:Subnetwork examplesubnetwork create
           -  gcp:compute:Subnetwork exampleSubnetwork delete
              pulumi:pulumi:Stack network-test
          Resources:
              + 1 to create
              - 1 to delete
              2 changes. 3 unchanged

          stderr:
      provider_test.go:47: cleaning up stack

had this again on a pr: https://github.com/pulumi/pulumi-gcp/actions/runs/7929329382/job/21649654767?pr=1666


[Feature Request] Sync Link Thickness

Hello!
Could this plugin also sync link thickness in addition to the colors?

Alright, will add this some time later, I'll tag you when it's done

Done @Nydid https://github.com/Xallt/sync-graph-settings/releases/tag/1.4.0


Add image support back in with Stable Diffusion

need to add local image generation

Or comfy ui, which is supposed to be faster and lighter on the gpu


Update "Using Blue Waters" page

I'm submitting a ...

[x] feature request

Expected Behavior
Ideally, the Using Blue Waters page on the arfc site should be 100% correct, link to useful documentation on the bluewaters main pages, and how to load key environment settings (as are being updated in #213  ).
Actual Behavior
Some of the information is a bit out of date (bahg -> bbcc), a few links are not present, and there is no information on key environment settings for running moltres or serpent.
How can this issue be closed?
This issue can be closed with a merged PR that updates the Using Blue Waters page in the guides at arfc.github.io.

@LukeSeifert does your issue update everything required, or do we need to make a checklist for all of the updates we need on this page?

@LukeSeifert does your issue update everything required, or do we need to make a checklist for all of the updates we need on this page?

It has been a while since I made the PR, but it should have updated everything required. The links all still work, so I think everything is still up to date.

@LukeSeifert and I chatted and we'll close this issue once serpent usage directions are added to the page.

@gwenchee I think you mentioned yesterday that something might still be out of date on the Blue Waters guide? If it is, can you mention them here so we can fix them. If not, I think we can close this issue.

I mentioned that we don't use the dongle for 2FA anymore, instead we use duopush

😭 @yardasol I think this issue could be closed.
Alternatively, should we:

Add a note to the guide page that BW is sundowned but we're keeping the page for archival reasons
Delete all instances of BW from the website?

Closing because of #291


Implement cron job triggered latency increase commit

Summary

Implement 2 K8s cron jobs.
First one should increase the latency in httpserver - GET.
Second one should decrease the latency back.
Both should deploy an event marker to demonstrate code commit.

In order to pass delay notice to httpserver Redis cache will be used #54


404 at /engine/reference/commandline/compose_restart/

I found a broken link : https://docs.docker.com/engine/reference/commandline/compose_restart/
I arrived on this page through: https://docs.docker.com/engine/reference/commandline/compose/

Thanks for reporting; this should be fixed by https://github.com/docker/docker.github.io/pull/13256 (which will be published on docs.docker.com soon)


Example of JFXTreeView

hi, friends, I am developing an application I want FXML example of JFXTreeView.

Hello,
JFXTreeView is pretty much the same as TreeView control, there are many examples for TreeView online.
http://docs.oracle.com/javafx/2/ui_controls/tree-view.htm
Regards,


Update to 1.13.0-nightly (4f9812a59 2016-09-21)

Lots of work left here, this is a really bad update.

Closing in favor of #96.


ci(github): add dependency version consistency check

Commit to be reviewed
ci(github): add dependency version consistency check
Primary Changes
---------------
1. Added a new custom check which checks if there are any inconsistency with the dependency version, which is already being used with an exsisting package.

Changes needed to incorporate 1)
-------------------------------
2. Added a new dependency in the root package.json
3. Added a new npm script in the root package.json
4. Updated the lock file for the dependency inclusion

Fixes #3612
Pull Request Requirements

[ ] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[ ] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[ ] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

[ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz I have created multiple tickets to address the fix for this (#3684 till #3698)

@jagpreetsinghsasan Almost perfect, just please add the currently bad dependencies to the ignore list so that when we merge this PR the custom checks are passing. Then we can remove the ignore declarations as we fix the problems chunk by chunk and finally (hopefully) end up with no ignores at all.

@petermetz shall I add the ignore list with packages in it (instead of dependencies)? This is because the way we are targetting a fix for this to fix it per-package basis. A single dependency mismatch can happen in multiple packages and so tracking the ignore list (if it is per-dependency basis) will be much harder against the resolved issue (the 14 phases of addressing the fix for this)


Set up a Windows VM

probably on powertrip.mggen.nau.edu

:+1:

It might not be necessary to set up our own VM, appveyor is like travis-ci but for windows, supports both 32 and 64 bits and there's an example project set up for py2&3 here. Scikit-learn is currently using it besides travis-ci.

That's awesome! :+1:

I've been doing a crap-ton of VM stuff lately. If there's any need for this at the moment I can do it.

Thank you for offering to work on this @anderspitman! We're deferring this for now since scikit-bio doesn't support Windows yet, powertrip is in flux right now with CI/CD, and we'd probably use native Windows installs (e.g. dual boot) to develop against and use appveyor to do Windows CI.

@jairideout sounds good. That's about what I figured.

I have made a basic appveyor.com config file that managed to run the tests and created a pull request #1474
The test run and find two windows specific issues, one is a data type issue and probably a real bug.
The second is a file permissions issue, and may just be a testing bug not a production bug.
These are recurrent so lots of tests fail.
To use this biocore will need to open an appveyor account which is free for OSS.

Awesome, thanks for setting this up @genomematt! I'll follow up on #1474 to get that moving forward.


Nearby competition

How about organizing a competition using the Nearby feature?
For instance, the winner could be the person who has the most valid Wikidata edits from the Commons app on a particular week.
Once we have organized a few of these competitions, we will have ironed out the possible problems such as cheating or quality, and we can think about phase 2, which could be a daily or weekly competition with points and a leaderboard integrated into the app.
Also, we have to find a better name than "Nearby competition".

I love the idea and IMO this could be a potential task for GSOC or Outreachy if we manage to get interns.

If a user spends a week taking pictures using Nearby (without uploading), and then uploads all of them during the competition week, should it be considered cheating? We can easily find out using the picture's EXIF. A very determined cheater could go as far as modifying the EXIF, but I am not sure such extremes are realistic. I wonder whether this kind of cheating has ever happened on other WMF competitions.

If a user spends a week taking pictures using Nearby (without uploading), and then uploads all of them during the competition week, should it be considered cheating?

To eliminate this problem shouldn't we just keep this as an event of just a day or an event with submission deadline with the idea that whoever has the most valid Wikidata edits from the Commons app that might have been captured at any time scores highest?

an event of just a day
If it is just one day, it might not really feel like a competition, because of timezones. People starting the competition in the Americas might be discouraged at the sight of the scores of people in Asia (for whom it is already the evening). A competition is fun if you can compete with others, compare your performance with them, try harder, lag behind, catch up, etc. At the scale of the planet, it is difficult to achieve this with just one day.

it might not really feel like a competition, because of timezones

Ohh yes, I missed this point. At a global level one day event would definitely not be beneficial. The idea of a week long event is definitely better :)

Great idea!
Given that we aren't giving out any "real" prizes, I think we don't have to worry too much about cheating for the time being. :) EXIF checking alone should be sufficient IMO.

Hooray, we can now start planning this in preparation for the v4 release! :)
A list of things that I think we need to do:

[ ] Decide on the metrics for the winner. I agree that "number of valid Wikidata edits" would be a good objective measure, as it doesn't rely on the subjectivity of "best pictures".
[ ] Decide on timeframe (can't decide on exact dates until v4 is out, but can decide on length)
[ ] Collect metrics. @nicolas-raoul I guess our usual Wikidata query will obtain the number of submissions from each person for the required timeframe, right?
[ ] Display metrics in a user-friendly manner, so that people can see where they are in the ranking and who is winning. IMO it would be really amazing if there was a way to display these on our website. @sivaraam what do you think?
[ ] Decide on rewards. Barnstars perhaps? @neslihanturan
[ ] Inform Commons community about the competition, via mailing lists etc
[ ] Carry out competition
[ ] Reward and announce winners

Using the leaderboard's ranking would be ideal. Could someone check whether it shows different rankings to different people, for instance because of timezones? Also, I think there is a cache on our server-side? If someone could prepare a query to be the ultimate reference, that would be great.

Display metrics in a user-friendly manner, so that people can see where they are in the ranking and who is winning. IMO it would be fantastic if there was a way to display these on our website.

If we want to do this, I believe we could certainly do this. It should be enough if there's a API using which we could fetch the rankings.
That said, using the leaderboard to show the metrics as Nicolas suggests sounds like a better idea to me. Is there a particular reason you prefer to show this in the website @misaochan ?

Also, we have to find a better name than "Nearby competition".

May be "Wikiexpedition competition" ? I suggest this because the aim of Wikiexpedition seems to align with goal of our competition:

The aim of a Wikiexpedition is collecting, mainly photographic, documentation, by exploring a chosen region.

(note: We could consider our "chosen region" as the nearby places of each user ;-))

Is there a particular reason you prefer to show this in the website @misaochan ?

I was hoping that Wikimedians who don't have the app (i.e. people who only have iOS phones) would be able to follow the results of the competition as well, as that would be good for publicity. :) But I agree that it should definitely be shown in the Leaderboard, the website can just be an optional addition if we can manage it. What do you and @nicolas-raoul think?

May be "Wikiexpedition competition" ? I suggest this because the aim of Wikiexpedition seems to align with goal of our competition:

I've never been to one, but based on what I'm reading in your link, it seems to me that the term is specifically for the in-person event. If we use the term, IMO it would be better to use it for #3388 instead.
Ummm... how about "Commons app competition"? 😅

Leaderboard + website if we can manage it

Sounds good enough :-) A webpage might be able to get the same JSON as the app's leaderboard.

Sounds good enough :-)

+1

A webpage might be able to get the same JSON as the app's leaderboard.

Indeed. That would ensure consistency across the data shown. Let me know if the current leaderboard response contains all information necessary to show the data in the website, I'll start doing a prototype to show the details in the website.

Thanks a lot @sivaraam . :) The current leaderboard displays the data for the current week (no. of upload/used/nearby). So that would be sufficient I think, if our time limit for the competition was a week. We would need to add a query if we wanted a different time limit.

Could someone check whether it shows different rankings to different people, for instance because of timezones?

I don't think so - my rankings just reset today on a Tuesday, it had more uploads yesterday (Monday). I'm GMT +10. But we should definitely look further into this, @madhurgupta10 ?

Tomorrow we will make a walk with around 10 people for completing Nearby pictures. I planned there can be 5 groups (2 people per group). I am not sure about calling it a competition. As most of them are first time contributors, they need to warm up first:) I suggest e designing a badger for all of them to use in their user pages, instead of choosing a winner.

I don't think so - my weekly rankings just reset today on a Tuesday, it had more uploads yesterday (Monday). I'm GMT +10. But we should definitely look further into this, @madhurgupta10 ?

@misaochan Sorry I missed the notification for this old message, the timezone for all users should be the same which is the pacific timezone (server default) I guess so the week/month etc. calculations are done based on that. The ranks are calculated in real-time but the data we use to calculate these ranks is updated in the leaderboard database every 2 hrs.

Hi @neslihanturan , the photo walk task is #3388 . :) The Nearby event is a competition is a separate event that will be done virtually. (Thanks for organizing it, btw! The route looks good and well-planned, and new contributors is the goal indeed.)

the timezone for all users should be the same which is the pacific timezone (server default) I guess so the week/month etc. calculations are done based on that. The ranks are calculated in real-time but the data we use to calculate these ranks is updated in the leaderboard database every 2 hrs.

Great, I think this should be fine then for the competition, since everyone will be on equal ground.

I unassign for now, but if you are you still working on this, please let us know. Thanks a lot for organizing the first one and for the other great contributions. :-)


Add GPT-3 OpenAI plugin

Submit a new Plugin to Marketplace
Plugin Github repo URL: https://github.com/briansunter/logseq-plugin-gpt3-openai
Github releases checklist

[x] a legal package.json file.
[x] a valid CI workflow build action for Github releases. (Optional for theme plugin only).
[x] a release which includes a release zip pkg from a successful build.
[x] a clear README file, ideally with an image or gif showcase. (For more friendly to users, it is recommended to have English version description).
[x] a license in the LICENSE file.

Looks good to me. Only concern is that one of the screenshots show an "explain code" slash command while this isn't present anywhere either in the code or in the installed plugin.

@sawhney17 Just took out that demo since the code fence extract shortcut didn't make it into the MVP.

Awesome. Thanks for the contribution. Merging.


Add support for Sangoma

Please add this patch to add support for Sangoma, which is a redhat clone for running freepbx.
diff --git a/metadata.json b/metadata.json
index dc8c09b..185b75c 100644
--- a/metadata.json
+++ b/metadata.json
@@ -46,6 +46,13 @@
         "9"
       ]
     },
+    {
+      "operatingsystem": "Sangoma",
+      "operatingsystemrelease": [
+        "7",
+        "8"
+      ]
+    },
     {
       "operatingsystem": "Scientific",
       "operatingsystemrelease": [

Adding support for a new operating system requires repo metadata. Please take a look at the files under this path for an example of what is required. https://github.com/voxpupuli/puppet-yum/tree/master/data/os/RedHat


omnibox search suggestion not working

Describe the bug
In latest version of ungoogled-chromium for Arch Linux (87.0.4280.88) the search suggestions aren't working
To Reproduce
Steps to reproduce the behavior:

Change search engine to Ecosia or DuckDuckGo
Make a research on the address bar
Notice that there aren't any suggestion

Screenshots

Environment (please complete the following information):

OS/Platform and version: Manjaro Linux KDE 20.2 with linux kernel 5.9
ungoogled-chromium version: 87.0.4280.88 for Arch Linux

Do you have this settings checked on?

I hope your question has been answered, otherwise please let us know.
Closing this issue for now.


Structs in Moya.

As per issue #408, I'm sharing with you the solution I've come up with to the topic, which is structs in Moya. The general idea was a perfect start by @Matthijn followed up by a really good direction by @colinta
Motivation
We would like to keep existing enum setup and additionally support structs based setup for bigger projects or for any other reason. Specifically, what should be possible with this PR is that we can still use old configuration of enums and it won't break, but additionally we can use Moya with structs configuration, for instance:
GitHubStructProvider.request(.UserProfile(UserProfileResource(name: name))) { result in

}

Implementation
My idea was to create protocol that will be a default protocol for enum when using it with wrapped structs, I called it ServiceType. Then make TargetType conform to it protocol so we can reuse code for both implementations.
Issues
There were few issues that occurred during the implementation. Changes I've made created some problems with generic's type inferring so I had to move Defaults (DefaultEndpointMapping, DefaultRequestMapping, DefaultAlamofireManager and stubbing defaults) to another non-generic class and I called it MoyaDefaults, which is a breaking change in case someone used them via MoyaProvider.DefaultAlamofireManager for instance. Couldn't find a way for not-creating another struct without many changes in code so if you have an idea I would love to hear it.
Demo
I've also added an example of usage to the current demo. As per our conversation I also believe we could move it to second demo. In short we can now define our struct like the one below:
public enum GitHubStruct: ServiceType {
    case Zen(ZenResource)
    case UserProfile(UserProfileResource)
}

public struct ZenResource: TargetType {
    public let path = "/zen"
    public let baseURL = NSURL(string: "https://api.github.com")!
    public let method: Moya.Method = .GET
    public let parameters: [String: AnyObject]? = nil
    public let sampleData = "Half measures are as bad as nothing at all.".dataUsingEncoding(NSUTF8StringEncoding)!
}

Conclusion
This is really a first step and we could improve it I believe, so I'm curious to hear what you think about it.
Cheers 🎉

Current coverage is 90.31%

Merging #424 into master will decrease coverage by -1.06% as of d258c2f

@@            master    #424   diff @@
======================================
  Files           13      13
  Stmts          464     475    +11
  Branches         0       0
  Methods
======================================
+ Hit            424     429     +5
  Partial          0       0
- Missed          40      46     +6

Review entire Coverage Diff as of d258c2f

Uncovered Suggestions

+2.11% via ...ource/Response.swift#84...93
+1.05% via ...+ReactiveCocoa.swift#54...58
+1.05% via Source/Moya.swift#215...219
See 7 more...

Powered by Codecov. Updated on successful CI builds.

I must say I like this solution. Haven't checked into this a while. But this looks promising.

Going to close this in lieu of #427.


Fix bugs in settings due to recent typescript migrations.

First commit is to fix user email notification batching setting.
Second commit is to fix updating the realm default language setting.
Thrid commit is to fix updating the realm joining restrictions setting.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Seems like good progress, merged, thanks @sahil839!


Charting - X - Y ranges

I have some pre defined charts I would like to geenrate using thsi module .
The range from one chart reads like this =Worksheet1!$A$32:$A$44,Data!$C$32:$D$44.  How can I use this cmdlet  New-ExcelChartDefinition to acomplish teh same result?

Try this
$xlfile="$env:TEMP\testChart.xlsx"
rm $xlfile -ErrorAction SilentlyContinue

$ecd = New-ExcelChart -XRange '=Sheet1!$A$2:$A$11' -YRange '=Sheet1!$C$2:$C$11'

ConvertFrom-Csv @"
Region,Item,TotalSold
North,apple,91
North,banana,66
East,screwdriver,41
West,peach,95
South,orange,29
East,kiwi,33
West,melon,44
North,drill,34
East,avocado,57
West,melon,52
"@ | Export-Excel $xlfile -Show -ExcelChartDefinition $ecd

Create a new worksheet for the chart
$xlfile="$env:TEMP\testChart.xlsx"
rm $xlfile -ErrorAction SilentlyContinue

$excel =  ConvertFrom-Csv @"
Region,Item,TotalSold
North,apple,91
North,banana,66
East,screwdriver,41
West,peach,95
South,orange,29
East,kiwi,33
West,melon,44
North,drill,34
East,avocado,57
West,melon,52
"@ | Export-Excel $xlfile -PassThru

$ws = Add-WorkSheet -ExcelPackage $excel -WorksheetName Sheet2

Add-ExcelChart -Worksheet $ws -XRange '=Sheet1!$A$2:$A$11' -YRange '=Sheet1!$C$2:$C$11'

Close-ExcelPackage $excel -Show

Thank you
I am trying the below code and I am getting a refernce error Im not sure why..
$xlfile="$env:TEMP\testChart.xlsx"
rm $xlfile -ErrorAction SilentlyContinue
$excel =  ConvertFrom-Csv @'
Date,HelpDeskStaff,TotalTicketsClosed,HelpDeskTicketsOpened,WebrequestsForService
August-2020,5,1584.6,758.9,604
July-2020,5,	1542.2,	782.2,	552
June-2020,5	,1499.8	,805.5,	694
May-2020,5	,1457.,4	,828.8	,706
April-2020,5,1415,	852.1,	698
March-2020,5,	1372.6,	875.4,	652
February-2020,5	,1330.2	,898.7	,705
January-2020,6	,1287.8	,922,	805
December-2019,5	,1245.4,945.3,725
November-2019,4,1285,1002,925
October-2019,5,985,985,885
September-2019,5,1200,852,725
'@ | Export-Excel $xlfile  -AutoSize -StartRow 2 -TableName ITServiceDesk  -PassThru
$ws = Add-WorkSheet -ExcelPackage $excel -WorksheetName Sheet2
Add-ExcelChart -Worksheet $ws -XRange '=Sheet1!A2:A14' -YRange '=Sheet1!C2:D14' -ChartType Line
Close-ExcelPackage $excel -Show

I took a look thru github examples and foudn something . There is an example that creates the line chart correcly but i couldnt get it to work with another sheet. #1 is form the github page # 2 is creating  a blank chart on worksheet2
#1
$data = @"
Date,WindowsSeven,WindowsTen,PCsManaged
August-2020,2322,1300,3296
July-2020,2322,1300,3294
June-2020,2322,	1300,3294
May-2020,2322,1300,3289
April-2020,2322,1300,3289
March-2020,2322,1100,3290
February-2020,2322,1200,3290
January-2020,2322,1200,3280
December-2019,2322,11110,3280
November-2019,2322,1119,3280
October-2019,2322,1115,3280
September-2019,2322,1006,3273
"@ | ConvertFrom-Csv
$c = New-ExcelChart -Title OS     -ChartType Line -Header "Something"
-XRange "OS[Date]" `
-YRange @("OS[WindowsSeven]","OS[WindowsTen]")
$data |
Export-Excel temp2.xlsx -AutoSize -TableName OS -Show -ExcelChartDefinition $c
#2
$xlfile="$env:TEMP\testChart2.xlsx"
rm $xlfile -ErrorAction SilentlyContinue
$excel =  ConvertFrom-Csv @'
Date,HelpDeskStaff,TotalTicketsClosed,HelpDeskTicketsOpened,WebrequestsForService
August-2020,5,1584.6,758.9,604
July-2020,5,	1542.2,	782.2,	552
June-2020,5	,1499.8	,805.5,	694
May-2020,5	,1457.,4	,828.8	,706
April-2020,5,1415,	852.1,	698
March-2020,5,	1372.6,	875.4,	652
February-2020,5	,1330.2	,898.7	,705
January-2020,6	,1287.8	,922,	805
December-2019,5	,1245.4,945.3,725
November-2019,4,1285,1002,925
October-2019,5,985,985,885
September-2019,5,1200,852,725
'@ | Export-Excel $xlfile   -PassThru
$ws = Add-WorkSheet -ExcelPackage $excel -WorksheetName Sheet2
Add-ExcelChart -Worksheet $ws -Title OS   -XRange "OS[=Sheet1!Date]" `   -YRange @("OS[=Sheet1!WindowsSeven]","OS[Sheet1!WindowsTen]") -ChartType Line
Close-ExcelPackage $excel -Show

I got the chart to work with the below code ... the only thing I am missing is how to associate the legend with the 2 column names (Series 0 , Series 1)
$xlfile="$env:TEMP\testChart.xlsx"
rm $xlfile -ErrorAction SilentlyContinue
$excel =  ConvertFrom-Csv @'
Date,HelpDeskStaff,TotalTicketsClosed,HelpDeskTicketsOpened,WebrequestsForService
August-2020,5,1584.6,758.9,604
July-2020,5,	1542.2,	782.2,	552
June-2020,5	,1499.8	,805.5,	694
May-2020,5	,1457.,4	,828.8	,706
April-2020,5,1415,	852.1,	698
March-2020,5,	1372.6,	875.4,	652
February-2020,5	,1330.2	,898.7	,705
January-2020,6	,1287.8	,922,	805
December-2019,5	,1245.4,945.3,725
November-2019,4,1285,1002,925
October-2019,5,985,985,885
September-2019,5,1200,852,725
'@ | Export-Excel $xlfile   -PassThru
$ws = Add-WorkSheet -ExcelPackage $excel -WorksheetName Sheet2
Add-ExcelChart -Worksheet $ws -XRange '=Sheet1!$A$2:$A$13' -YRange @('=Sheet1!$C$2:$c$13','=Sheet1!$d$2:$d$13') -ChartType Line -Title OS
Close-ExcelPackage $excel -Show

I got it! Couldnt have figured it out with out you Doug, thank you!!
$xlfile="$env:TEMP\testChart.xlsx"
rm $xlfile -ErrorAction SilentlyContinue
$excel =  ConvertFrom-Csv @'
Date,HelpDeskStaff,TotalTicketsClosed,HelpDeskTicketsOpened,WebrequestsForService
August-2020,5,1584.6,758.9,604
July-2020,5,	1542.2,	782.2,	552
June-2020,5	,1499.8	,805.5,	694
May-2020,5	,1457.,4	,828.8	,706
April-2020,5,1415,	852.1,	698
March-2020,5,	1372.6,	875.4,	652
February-2020,5	,1330.2	,898.7	,705
January-2020,6	,1287.8	,922,	805
December-2019,5	,1245.4,945.3,725
November-2019,4,1285,1002,925
October-2019,5,985,985,885
September-2019,5,1200,852,725
'@ | Export-Excel $xlfile   -PassThru
$ws = Add-WorkSheet -ExcelPackage $excel -WorksheetName Sheet2
Add-ExcelChart -Worksheet $ws -XRange '=Sheet1!$A$2:$A$13' -YRange @('=Sheet1!$C$2:$c$13','=Sheet1!$d$2:$d$13') -ChartType Line -Title Tickets  -SeriesHeader 'TotalTicketsClosed',	'HelpDeskTicketsOpened'
Close-ExcelPackage $excel -Show

I do have a question Why in excel you can include the colmun name in the range but with the module it errors out?

Also is there a way to format the lines in the chart .. ie color and point size?

Try using  Export-Excel $xlfile -PassThru -AutoNameRange the names should be available.

yes that removed the reference error! Thx :) . Is there a way to set the line color and width of a chart.

Hi,
This post may answer your question.
https://github.com/dfinke/ImportExcel/issues/507

Hi,
The below modification has worked for me. can you check if this works for you?
$xlfile="$env:TEMP\testChart.xlsx"
rm $xlfile -ErrorAction SilentlyContinue

$excel = ConvertFrom-Csv @'
Date,HelpDeskStaff,TotalTicketsClosed,HelpDeskTicketsOpened,WebrequestsForService
August-2020,5,1584.6,758.9,604
July-2020,5, 1542.2, 782.2, 552
June-2020,5 ,1499.8 ,805.5, 694
May-2020,5 ,1457.,4 ,828.8 ,706
April-2020,5,1415, 852.1, 698
March-2020,5, 1372.6, 875.4, 652
February-2020,5 ,1330.2 ,898.7 ,705
January-2020,6 ,1287.8 ,922, 805
December-2019,5 ,1245.4,945.3,725
November-2019,4,1285,1002,925
October-2019,5,985,985,885
September-2019,5,1200,852,725
'@ | Export-Excel $xlfile -PassThru

$ws = Add-WorkSheet -ExcelPackage $excel -WorksheetName Sheet2

$chart=Add-ExcelChart -PassThru -Worksheet $ws -XRange '=Sheet1!$A$2:$A$13' -YRange @('=Sheet1!$C$2:$c$13','=Sheet1!$d$2:$d$13') -ChartType Line -Title Tickets -SeriesHeader 'TotalTicketsClosed', 'HelpDeskTicketsOpened'

$chart.Series[0].LineColor = [System.Drawing.Color]::ForestGreen
$chart.Series[1].LineWidth =4

Close-ExcelPackage $excel -Show

WOW that works great! Thank you! I am shifting gears a little . I am looking to plot the chart via table names properties like below keeping it onone page so the hcarting is more dynamic. How can I do with the beow code?..Thx!
$Data = ConvertFrom-Csv @'
Date,HelpDeskStaff,TotalTicketsClosed,HelpDeskTicketsOpened,WebrequestsForService
August-2020,5,1584.6,758.9,604
July-2020,5, 1542.2, 782.2, 552
June-2020,5 ,1499.8 ,805.5, 694
May-2020,5 ,1457.,4 ,828.8 ,706
April-2020,5,1415, 852.1, 698
March-2020,5, 1372.6, 875.4, 652
February-2020,5 ,1330.2 ,898.7 ,705
January-2020,6 ,1287.8 ,922, 805
December-2019,5 ,1245.4,945.3,725
November-2019,4,1285,1002,925
October-2019,5,985,985,885
September-2019,5,1200,852,725
'@
$c = New-ExcelChart -Title 'Helpdesk Tickets Opened/Closed'     -ChartType Line
-XRange "Helpdesk[Date]" `
-YRange @("Helpdesk[TotalTicketsClosed]","Helpdesk[HelpDeskTicketsOpened]")  -SeriesHeader 'TotalTicketsClosed',	'HelpDeskTicketsOpened'
$data |
Export-Excel V:\temp.xlsx -AutoSize -TableName Helpdesk -Show   -ExcelChartDefinition $c

I got works great Thank you!
$excelPath = "C:\Temp\Test3.xlsx"
Remove-Item $excelPath -ErrorAction Ignore
$Data = ConvertFrom-Csv @'
Date,HelpDeskStaff,TotalTicketsClosed,HelpDeskTicketsOpened,WebrequestsForService
August-2020,5,1584.6,758.9,604
July-2020,5, 1542.2, 782.2, 552
June-2020,5 ,1499.8 ,805.5, 694
May-2020,5 ,1457.,4 ,828.8 ,706
April-2020,5,1415, 852.1, 698
March-2020,5, 1372.6, 875.4, 652
February-2020,5 ,1330.2 ,898.7 ,705
January-2020,6 ,1287.8 ,922, 805
December-2019,5 ,1245.4,945.3,725
November-2019,4,1285,1002,925
October-2019,5,985,985,885
September-2019,5,1200,852,725
'@
$tableName = 'Helpdesk'
$splat = @{
Title = 'Logging Level Summary'
ChartType = 'Line'
XRange = "$tableName[Date]"
YRange = @("$tableName[HelpDeskTicketsOpened]","$tableName[TotalTicketsClosed]")
SeriesHeader ='TotalTicketsClosed',	'HelpDeskTicketsOpened'
Row = 15
Column = 0
Width = 500
Height = 200
}
$xl = $Data  | Export-Excel -Path $excelPath -WorksheetName 'Data' -AutoSize -TableName $tableName -PassThru
$chart = Add-ExcelChart @splat -Worksheet $xl.Data -PassThru
$chart.Series[0].LineColor = [System.Drawing.Color]::Red
$chart.Series[1].LineColor = [System.Drawing.Color]::Blue
$chart.Series[0].LineWidth =4
$chart.Series[1].LineWidth =4
Close-ExcelPackage $xl -Show

Drop a comment to let us know if your Excel report was liked by others.


feat(opa): Adding jq OPA builtin for selection

Add an opa builtin for gojq to query the entity object provided by the idp or the jwt with the subject_external_selector_value query string
references https://github.com/opentdf/platform/issues/470

@elizabethhealy Should we be building a builtin for jq or should it be for subject mappings?

@strantalis the subject mapping evaluation takes place in the rego currently, this is just to retrieve the selected field in the jwt/entity obj per https://github.com/opentdf/platform/issues/470

@elizabethhealy We want the subject mapping logic to also take place behind a builtin function as well. Someone that provides a custom opa bundle with modified rego shouldn't modify the mapping logic imo.

@strantalis ok that makes sense, i just read through the adr https://github.com/opentdf/platform/issues/472, we can open a separate issue when the adr is resolved to encompass that work (it will overwrite some of this work), but in the meantime can we merge this in to unblock downstream users since the other jq spec changes were already made?

@ttschampel @jrschumacher @biscoe916 Can you give this a review.

I'm ok approving this to move forward and start work on #567 and get things aligned with #472

thanks @ttschampel, already getting started on the third bullet under #567