Weapons that use strength doesn't factor in Charisma replacement

Describe the bug
Weapons that uses strength for damage doesn't factor in Charisma in Isekai Archetypes that replaces Strength with Charisma for factoring in damage. Example: Composite Longbow/Shortbow/Throwing Axes.
To Reproduce
Steps to reproduce the behavior:

Use Composite Bow on a low strength Hero Archetype Isekai character
See that the damage is low as it uses Strength rather than Charisma

Expected behavior
Charisma should still replace Strength on a Composite Longbow weapon
Screenshots

From what I can see, the composite enchantment and the Graceful Combat feature both uses the same OverrideDamageBonusStat method to override the weapon stat calculation, and that the composite enchnatment is also applied after the Graceful Combat feature, meaning only the composite enchnatment is effective.
Possible solutions:

Patching the composite enchantment to check for specific hardcoded features like the Graceful Combat feature before doing the stat replacement. Repeat for strength weapons, agile weapons, finesse weapons etc.
Get the Graceful Combat feature to trigger last. (no idea how at the moment)
Do nothing. Let the weapon enchantments take priority in this case.

I will investigate whether the 2nd solution is possible but if not I would rather let the weapon enchantments take priority.

I'd like to add that I noticed the same behavior with the feature that lets you use Dexterity for damage from the Edge Lord Subclass. "Sonic Strike" was it's name, I think.
On Composite LongBows, characters strength is used for Damage Calculations.
On non Composite Longbows, dexterity was used for damage.

I think I will leave it as it is. I couldn't find a way to re-order the weapon stat calculation when multiple sources override the weapon stat.


Guard against using a non-engine-aware resolver

One of the most common oversights when using this addon is forgetting to use this addon's custom resolver and instead using the default ember-cli resolver, which is not yet able to resolve engines.
We should both move the engine-awareness upstream to avoid the need for a custom resolver, and we should warn and polyfill engine-awareness if a different resolver is used.

@asakusuma, since you're looking at #10, you might want to note this as well.

@dgeb since this is upstreamed now, what (if any) is the action item here?


Which version of CHM13 reference genome to use

Hi,
Thanks for developing this great tool. I would like to use the "HPRC-CHM13 (88 haplotypes)" variant reference. Based on the name, I think the reference genome I should use for genotyping is CHM13, but I am not sure which version of CHM13 to use. Could you provide links to the reference genome you used when generating the variant reference vcf?
Thanks,
Han

Hi Han,
I'm using this reference: https://s3-us-west-2.amazonaws.com/human-pangenomics/pangenomes/freeze/freeze1/minigraph/CHM13v11Y.fa.gz
Best,
Jana

Hi Jana,
Thanks a lot! This is really helpful.
Best,
Han


when adding comment of content "..." in the end of the code, the WebView displays plain text error

Extension version: 0.17.0
VSCode Version: 1.47.0
OS: Windows10

Steps to Reproduce:

add a comment of content "..." in the end of code
goto the description page and press the refresh button

Closing this since I have not been able to reproduce it in the latest version of the extension, so think it has been fixed. Please let me know if you see it again. Thanks!


Non-ASCII in server console causes a panic

Starting a server with boxes, and the output containing a character outside of ASCII causes Boxes to panic with the following error:
thread 'main' panicked at src\minecraft\server.rs:91:33:
called `Result::unwrap()` on an `Err` value: Error { kind: InvalidData, message: "stream did not contain valid UTF-8" }

Steps to reproduce:

Create a server with boxes server generate or boxes create
Install a plugin that logs a non-ASCII character (for example, Multiverse-Core prints § when warning about a deprecated event.)
Start the server with boxes start <server>
Boxes panics due to the non-ASCII character

Fixed in latest release.
Using Stdio::inherit() instead of Stdio::piped()


Add configuration for GPS data.

Add configuration for GNSSRO data.  This is done with the UFO develop branch checked out on 09/27/2023.  There are around 1000 data passing QC in GSI but fail in JEDI. There are also difference in final observational errors.   However, UFO and GSI hofx values match each other.

Since gps is not turned on in any testing I'll go ahead and merge this now. Though I won't turn it on until post shutdown and hopefully when Francois has finished the consolidation of changes.


Added sealing of functions in traits

This PR adds the ability to seal specific functions.
This is done through adding the #[seal] attribute on the function.
This makes the entire function private.
If you want the function to be callable but not implementable, you need to add callable to the seal attribute.
Since sealing the trait is semantically somewhat equivalent to adding #[seal(callable)] to all its functions.
To allow users more freedom, I added a partial argument to the trait attribute.
This attribute removes the seal from the trait itself, so that the user has almost full freedom in what functions are implementable and what are callable.
Possible future additions

Allow users to specify the name of the inner version of a wrapped function.
Allow users to specify the name of the token type that is used to make functions sealed.
Add use statement for the token, to make it nicer to call the sealed function.

fixes #18

One thing I am not happy about is that the way to make a sealed function callable is by adding a wrapper function that calls the sealed function.
But since this wrapper function is not sealed, and (in my current implementation) has the normal name and arguments. This means it is possible (in fact it is quite easy to do accidentally) to overwrite the wrapper that is used to call the sealed implementation.

@TheLazyDutchman I was reviewing your code and going through the examples when I noticed the following the following code does not work:
#[sealed(partial)]
pub trait A {
    #[seal(uncallable)]
    fn sealed() {}

    fn lol(&self) {
        Self::sealed();
    }
}

Now, it makes sense that it doesn't! The issue is, it needs to work. As a library author, you need to be able to write the previous code (with, of course, the Self::sealed(Token) instead).
This works when done by hand because you're in full control of the names, but not with macros (as Rust doesn't have the same abilities as F#).
I see 3 possible ways out of this:

Rewriting every call to the function to use the generated value — very convoluted
Figuring out a syntax to make this approach work — possible but may be opaque to the end user, don't let this discourage you though!
Documenting the new pattern in the macro — easiest possible solution

I think we can add doc attrs to document that token needs to be used, and then have a use statement for the token with the same publicity of the sealed module. This way you can just use Token instead of _sealed_my_trait::Token everywhere where you are allowed to use the sealed trait.
Since this directly puts Token in scope it means we should allow the user to specify their own name for token, to avoid name collisions. (or instead of Token we make it MyTraitToken)

I'm not being able to visualize your proposal. Can you show an example of how the final code would look like?

pub(super) _sealed_my_trait {
    pub trait Seal {}
    pub struct MyTraitToken;
}
pub(super) use _sealed_my_trait::MyTraitToken;

Where pub(super) is just to showcase what would happen if users specify a pub in the sealed attribute.
This doesn't change that users need to add the token, but at least they don't need to use the path of the module, and we can change the doc comments of the function to signify that they need the token in order to call it.

@TheLazyDutchman I wasn't too clear when asking for an example. I meant, how would an end-user write the code?

#[sealed]
pub trait MyTrait {
    #[seal(uncallable)]
    fn sealed() {}

    fn unsealed() {
        Self::sealed(Token);
    }
}

They still need to add the token, but we have a use statement for it, so Token is all they need, not the full path.
And we add to the documentation of the function that they need to supply the token.

I am not sure if it is possible to get the full semantics of a sealed function without adding an argument (at least that is what was done in the blog). The problem is that when doing it manually, you know what is going on, and this library would be hiding some of it (which is a good thing), but it cannot hide everything, which means it is unclear to the user where this token is coming from.
I think this can be somewhat fixed by adding documentation (both for this library, and for the function that we are sealing).

As far as VSCode is concerned, it doesn't have a parameter, which becomes really misleading for the user.

As you said:

but it cannot hide everything, which means it is unclear to the user where this token is coming from.

I have to thank you for your efforts but I cannot move forward with this PR. I am open to merge a PR documenting the pattern from the blog though as it is indeed a really interesting pattern and still relevant to the people interested in this crate.

I was also unsatisfied with the Token trick and the wrapped function, and after thinking some more about it I think I have found a way to make a method be non-implementable but callable without using tokens.
But since this library normally already does exactly that for all methods, it would create two completely distinct behaviours, so I think it might be better as a separate library.
The new trick would be:

create a sealed wrapper type Wrapper<T>
impl<T> From<T> for Wrapper<T>
change one (or all) argument from e.g String to impl Into<Wrapper<String>> (this requires at least one argument.
add a line at the start of the function to rebind the argument name to the wrapped value.


[New] TrendDetector class as the interface for trend analysis

Summary of this new feature
We run S-R trend analysis with Scenario.trend(). This will not be changed, but new trend analysis (change point analysis) tools are required to improve this trend analysis. TrendDetector class will be prepared for the interface of trend analysis. Users will try (some) trend analysis with it. Scenario.trend() will call it internally.
This is related to #568.
Documentation will be updated here.
https://lisphilar.github.io/covid19-sir/usage_phases.html
As an idea, I-based trend analysis. This checks the trend of the number of infected cases. This will be discussed in a new issue.

We will replace ruptures.Pelt with ruptures.KenerCPD per the documentation of ruptures package.
https://centre-borelli.github.io/ruptures-docs/examples/kernel-cpd-performance-comparison/
algo_python = rpt.Pelt(model="l2", jump=1, min_size=2).fit(
    signal
)  # written in pure python
algo_c = rpt.KernelCPD(kernel="linear", min_size=2).fit(
    signal
)  # written in C, same class as before

Repeated running of KernelCPD raised Fatal Python Error (tests/test_trend.py::TestTrendDetector::test_sr). Pelt` class will be used at this time and this does not have runtime issues for our purpose.

The following class and function will be renamed as internal classes or removed. They have not been included in the stable versions and created with #651.

covsirphy.TrendPlot -> covsirphy.trend.trend_plot._TrendPlot
covsirphy.trend_plot -> removed

JHUData.to_sr() will not be used and this method will be deprecated.

PhaseSeries.trend() and PhaseSeries.trend_show() will be deprecated internally.


Android Specific database

I am creating (Only)Android application in Xamarin and i look at this tutorial to the NuGet package "sqlite-net-pcl", but because the package contains "platform independent versions of SQLite" it has lot of  useless dependecies  because i need it only for Android. Could you give me a link or something to NuGet package with SQLite only for Android(if it exists), please? (My app is for Android minSDK 25 if this matters)
And i would like to make sure that number of dependencies has impact to result application size, right?
Thank you, ptnavratil

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5ce30880-c4f0-78f7-1ee0-6507e378201e
Version Independent ID: a6ad2818-c0d2-e3ef-1262-e143d49cc348
Content: Store data in a local SQLite.NET database - Xamarin
Content Source: docs/get-started/quickstarts/database.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Sorry for creating Issue, I thought it is regular comment on the Tutorial page.


Is it safe to run multiple procrastinate instances on different machines?

Question
For a use-case we'd like to launch procrastinate workers on multiple different machines. I worry a bit that since there will be multiple connection pools in that case, there's some problems regarding syncing/concurrency/... Are there any known problems on the use of multiple connector pools/connecting from multiple places to the same DB from your side?
Thanks!

Hello, and thanks for opening an issue !
Having distributed workers on different machines is at the heart of how procrastinate is meant to be used. Sychronization & concurrency are managed by the ACID properties of your PostgreSQL Database.

Awesome, thanks for the quick response (4 minutes!). Can you comment on how one would go about synchronizing Task definitions?
Say we want to have an API running on one server that is supposed to add jobs for multiple different Tasks. How can we get the task definitions on the API side, so that it can add jobs for the different Tasks? Do we need to re-declare the @app.task everywhere we want to add jobs?

Ah, I found the solution to this myself. One can use app.configure_task(name="some_task", queue="some_queue") in order to defines tasks and defer jobs for them from some other place.
Thanks for your support, from my side this issue can now be closed.

Yep exactly :) If you think this would deserve more documentation, please say so.
For reference, https://procrastinate.readthedocs.io/en/stable/howto/defer.html#defer-a-job-if-you-can-t-access-the-task


Local configuration file or package.json property could not be found.

I am using https://github.com/vega/vega-lite-dev-config/pull/481 with https://github.com/vega/vega-embed/pull/637 (using yarn link) and when I run yarn, I get this error
yarn
yarn install v1.22.10
[1/4] 🔍  Resolving packages...
success Already up-to-date.
$ beemo create-config

Local configuration file or package.json property could not be found.
    at ConfigLoader.loadConfig (/Users/dominik/Code/vega-embed/node_modules/@boost/core/lib/ConfigLoader.js:190:19)
    at Beemo.loadConfig (/Users/dominik/Code/vega-embed/node_modules/@boost/core/lib/Tool.js:394:41)
    at Beemo.initialize (/Users/dominik/Code/vega-embed/node_modules/@boost/core/lib/Tool.js:289:14)
    at new Beemo (/Users/dominik/Code/vega-embed/node_modules/@beemo/core/lib/Beemo.js:78:14)
    at Object.<anonymous> (/Users/dominik/Code/vega-embed/node_modules/@beemo/cli/lib/CLI.js:18:15)
    at Module._compile (node:internal/modules/cjs/loader:1091:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1120:10)
    at Module.load (node:internal/modules/cjs/loader:971:32)
    at Function.Module._load (node:internal/modules/cjs/loader:812:14)
    at Module.require (node:internal/modules/cjs/loader:995:19)

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@domoritz This looks like really old code since @boost/core doesn't exist anymore.

It works if I prerelease a package but not with yarn link. Strange but unrelated to beemo.


Visualisations: x-zoomed histogram is not including config.viewport.xMin/xMax in back end request

e.g. GEMS1
histogram visualization
main var: Age
binWidth: 3 (default)
set the x-axis range [20,40]
You can see a tiny sliver of the (15,18] bar on the left hand side and its mouse-over is active.
Solution
config.viewport.xMin and config.viewport.xMax should be sent to the back end.

thank you for your information, @bobular I will take a look at it.

I can confirm that there is no longer a sliver of a bar at (15, 18] in the GEMS plot. See attached image.

Thank you for your review, @sweverschulman 👍


Performance Improvements

Fixes #1397
Fixes #1438
Try to parse simple and fast first, before parsing complex
Update libraries to its latest versions
Remove JUnit4 Leftover
Add a 6 second timeout to the Parser and let it fail gracefully when a Statement can't be parsed within that time
Add a special test assuring the cleanup of the Parser objects after the timeout (no stale background processes)

Totally unrelated: We pull the complete ANTLR as dependency for PMD, while we work with JavaCC in order to not use ANTLR -- I find that quite funny :)
pmd - The PMD libraries to be used for this project.
\--- net.sourceforge.pmd:pmd-java:6.41.0
     +--- net.sourceforge.pmd:pmd-core:6.41.0
     |    +--- org.antlr:antlr4-runtime:4.7.2
     |    +--- com.beust:jcommander:1.48
     |    +--- commons-io:commons-io:2.6
     |    +--- net.sourceforge.saxon:saxon:<IP_ADDRESS>
     |    +--- org.apache.commons:commons-lang3:3.8.1
     |    +--- org.ow2.asm:asm:9.2
     |    \--- com.google.code.gson:gson:2.8.5
     +--- net.sourceforge.saxon:saxon:<IP_ADDRESS>
     +--- org.ow2.asm:asm:9.2
     +--- commons-io:commons-io:2.6
     \--- org.apache.commons:commons-lang3:3.8.1

Sorry, I am lost -- too many branches and PRs open for too long time.
I have reverted those unwarranted changes already in my local repo and pushed it again, but somehow it is not updated in the PR.

Why create a single-threaded thread pool each time the parseStatement method is called? And also immediately synchronous blocking! How is this different from executing directly in the current thread?
When 200 concurrent requests came into one of my paginated query interfaces, the number of threads I served directly doubled ! wtf !

Why create a single-threaded thread pool each time the parseStatement method is called? And also immediately synchronous blocking! How is this different from executing directly in the current thread? When 200 concurrent requests came into one of my paginated query interfaces, the number of threads I served directly doubled ! wtf !

Is the purpose to throw an exception after an 8-second timeout? Why is the performance of this method so bad that it can not be executed in 8 seconds?


SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste…

…rStateProvider
https://issues.apache.org/jira/browse/SOLR-14985

Description
Outlined below is the perf impact of using CloudSolrClient with HttpClusterStateProvider as-is for /select request. Similar issues exist on the /update path
The test revealed 1 call being made to fetch entire cluster state and 5 other calls to fetch cluster status given a collection parameter, suggesting there is no caching mechanism in HttpClientClusterStateProvider
1. Call to Fetch Entire Cluster State

2. Several Calls to Fetch Cluster State for a Collection
3 calls originating from CloudSolrClient.getDocCollection()

3. 2 calls originating from CloudSolrClient.resolveAliases()

Similar problems exist in the processing of a /update request
Solution
Issue 1 Resolution: Modified the implementation of the default method default <T> T getClusterProperty(String key, T defaultValue) in ClusterStateProvider to call getClusterProperty(key) directly. This change avoids using getClusterProperties().get(key), which in BaseHttpClusterStateProvider would fetch the entire cluster state.
Issue 2 Resolution: Addressed the lack of a caching mechanism in HTTP-based ClusterStateProvider (CSP). The CloudSolrClient only caches DocCollection instances where ref.isLazilyLoaded() returns true. However, for CollectionRef instances handled by HTTP-based CSP, the default method CollectionRef.isLazilyLoaded() returns false. This PR disables the check in CloudSolrClient.getDocCollection() to ensure caching works regardless of the ref.isLazilyLoaded return value.
Issue 3 Resolution: Incorporated code changes from prior PR for CSC to call getDocCollection() instead of CSP.getState() to lookup inputCollectionName, whereby it would be checked against collectionStateCache/Cluster state.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
A new test, testHttpCSpPerf(), was added to initially identify performance issues. After implementing changes to address issues 1 and 2, this test confirms that these performance issues are resolved. The test also reveals that the remaining two calls to fetch the CLUSTERSTATUS, given a collection parameter, stem from issue 3, which has not been addressed in this PR.
Checklist
Please review the following and check all that apply:

[X] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[ ] I have created a Jira issue and added the issue ID to my pull request title.
[ ] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[X] I have developed this patch against the main branch.
[] I have run ./gradlew check.
[X] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

I love the sequence diagrams!  What tool did you use to draw it?
RE aliases:  I was anticipating that this PR might regress the alias functionality.  But CloudHttp2SolrClientTest.testAliasHandling passes (as do all tests), and it uses the HTTP based CSP, so I suppose there's no down-side to any current user with this PR?  BTW, CloudHttp2SolrClientTest.getRandomClient is not doing what it should be doing.  Based on the commented code, I suspect the last person touching it (Dat) accidentally commented out the randomization.  I ran this test locally using both clients and it passes both ways.

I love the sequence diagrams! What tool did you use to draw it?

Plant UML - It can be installed as a plugin in IntelliJ

The previous PR to solve this apache/lucene-solr#2086 has a test suggesting the alias matter only results in one request?

That is only true for add() - resolveAliases() is only invoked once in that code path. Whereas for commit(), /select etc resolveAliases() would be called twice, once in CSC.retryRequestWithStaleState() and then again in CSC.sendRequest()

I reported one of those test failures to Houston as it's a fresh issue.  The other is a long-time flaky failure; shouldn't be affected by this change.
I think this is ready!
CHANGES.txt: 9.8 not 9.7 because too risky for 9.7 feature freeze any day now.  Optimizations section:

SOLR-14985: Solrj CloudSolrClient with Solr URLs had serious performance regressions (since the beginning?) in which its collection state cache was not being used, resulting in many extra requests to Solr for cluster information.  (Aparna Suresh, shalin, David Smiley)

I plan to add this entry & merge this in about a day.

Will that be backported to 8.11? We recently started using the CloudSolrClient client in our Java applications and the performance went south. We are experiencing high latencies, millions of requests to /admin/collections endpoint and Zookeeper is queuing requests.
An upgrade to 9.4 won't help in this case since this "optimization" will be included for 9.8, right?

Thanks @janhoy We'll do that


Update culture names list

I create this PR based on issue #98

/cc @Eilon @kirthik

Updating CultureInfoList with just one CultureInfo may not be the right solution. Closing this one since we already have another PR - https://github.com/aspnet/Localization/pull/104 and a related issue for it - https://github.com/aspnet/Localization/issues/98.

@kirthik i'm still surprised why this PR has been closed, while it fix issue #98 after @DamianEdwards confirm. Regarding PR #104 i'm not sure if @Kagamine added the cultures manually or using the CultureInfoGenerator command, furthermore if you look to the updated list may you will understand that more than 400+ cultures have been added

@Eilon is this closed by mistake?!!

I think she would close the PR #104 ...

That's what I expect :smile:

Why you care it so much?

Because the PR sent after @DamianEdwards confirmation, furthermore the culture that you come up with is interesting and may we find a smart solution to generate all the culture cross platform
thanks @Kagamine

We will discuss these next week and get back to you.

Thanks @Eilon

@kirthik given our discussion today, I believe this is ok to merge.

@Eilon : Based on the discussion in https://github.com/aspnet/Localization/issues/111, plan is to remove KnownCultureNames. Then this PR will not be relevant right?

@kirthik oh yeah I was confusing the cache and the known list.

Closing this PR since it will no longer be relevant after https://github.com/aspnet/Localization/issues/111 is implemented.

@kirthik should issue #98 will be closed too?!!

Yes, I closed #98.


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?
Terraform
Module Classification?
Resource Module
Module Name
avm-res-apimanagement-service
Module Details
Requested by the AZD team: https://github.com/Azure/Azure-Verified-Modules/issues/261
Needs module owner.
CC: @jongio
Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
No response
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

cc- @jgardner04

@mbilalamjad I am interested in taking ownership of this module.

@mbilalamjad Bilal Amjad FTE I am interested in taking ownership of this module.

Hey @hannah-leland thanks for volunteering to own this one, we're double checking with @jgardner04 if him or his team is interested to own this, in case they aren't than I will come back to you

@mbilalamjad I am interested in contributing to the development of this module.

Hi @swatilekhapaul,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @swatilekhapaul,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry

For your module's repository:

Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

@mbilalamjad can you confirm that this module exists in index page. Tnx!

Thanks @prjelesi for the catch, will update the index page.

@swatilekhapaul - Do you have an ETA for this?

@swatilekhapaul - Do you have an ETA for this?

THis module has been abandoned since Feb 8 2024 and the repository has not beeen creates is it ok for me to take over this module I am interested into owning this.

reates is it ok for me to take over this module I am interested into owning this.

HI @Nepomuceno did you agree about this with current module owner?


[ARM] Fix an issue where What-If shows two resource group scopes with different casing

Description

The PR contains a simple fix for the user reported issue: Azure/arm-template-whatif#126.
Testing Guide

az deployment group/sub/mg/tenant what-if ...
History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

ARM

@zhoxing-ms @Juliehzl could you please take a look at this PR?


It seems that jquery is not properly loaded

I am not sure what causes the issue (whether it's the theme or the sphinx package) or if you are already aware of the issue but when doing a doc build and navigating to the html file, the tables don't show up correctly, and in the developer console I can see:

A small repro:
git clone git@github.com:BlueBrain/sonata-extension.git
cd sonata-extension
tox -e docs

and then open, for example, ./build/html/sonata_tech.html in a browser.
I tried the above yesterday and it was still affected.
If I ran the tox with sphinx < 6.0.0 and sphinx-bluebrain-theme < 0.4.0, everything worked as expected.

fixed by #67


cable/fiber ID

Right now it reads like there's just one cable-fiber ID for each portion of the fiber. Am I understanding that correctly?
As I'm working on an implementation of this in DASCore, I'm realizing it probably makes sense to keep a fiber ID and a cable ID for each portion of the light path.
Even though this may be redundant for some experiments, it's common enough to have a mix of straight stretches and loop-backs that I think it could help clarify acquisition setup for others after the fact.
A couple examples: This lets you leave a clear record when you start collecting data on a new fiber in the same cable. It also lets you have a clear indication of two fibers with a U connection at the end that sit in the same cable being differentiated from two fibers in two separate cables that are side-by-side or a cable deployed as a U. Or if you have a single mode DAS and a multimode DTS recording in the same cable (e.g. to do temp. corrections on your DAS data), and you use a similar metadata standard for DTS, then you can make it clear that they're in the same cable (and this means same thermal properties) versus side-by-side cables (potentially quite different thermal response).

This issue continued at https://github.com/FDSN/DAS-metadata/issues/6


[lit-labs/compiler] rollup example and source map tests

Issue: https://github.com/lit/lit/issues/189
RFC: https://github.com/lit/rfcs/pull/21
Full prototype PR: https://github.com/lit/lit/pull/3984
Why
The initial labs compiler public export is only a TypeScript transform. This makes it usable within multiple build tools that accept TypeScript transformers. E.g., within g3, @rollup/plugin-typescript, ttypescript, and maybe one day natively through TypeScript.
This PR adds an example rollup config for testing source maps. The example rollup config uses @rollup/plugin-typescript to compile the sourcemap test file. A new test has been added to ensure the resulting source maps correctly reference the authored example.
How

Add source-map which allows easy queries on a source map, and manually setup some source map tests.
Add a rollup.source_map_tests.js config which uses the compiler transform to compile a basic typescript file for source map testing.

Risk
This change has minimal risks as it doesn't add or change any logic in the compiler, it's a test only and example only change.

Why not run this transform on lit-html_tests?

Because labs/compiler uses TypeScript 5, while the rest of the monorepo uses TypeScript 4. This will also come in a followup, and can use the example rollup config here as inspiration.
Notes
I noticed in this change that the license does not remain at the top of the generated basic.js file. This will be addressed in a followup.

Thank you for the excellent suggestions!

I did some further investigating regarding the license falling below the imports in the generated source_map javascript file. That looks like a rollup/plugin-typescript behavior – as it occurs without the compiler transform.
I'll add a license golden to the test_files to show that the compiler transform doesn't do this by default.


Add logs to trace group deletions

Description

We observe some issues around groups where they are being deleted without any obvious reasons. This PR adds some logs to instrument group deletion and understand where it's coming from. Will be reverted once we find the root cause.
Risk

Deploy Plan

Closing as we found the issue.


[Alerting] fix commented out tests

Origin: https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/182
Alerting issue: https://github.com/opensearch-project/alerting/issues/403
The tests were commented in alerting plugin:
https://github.com/opensearch-project/alerting-dashboards-plugin/pull/214
So matching the source repo, the tests step were commented as well. We will need to copy-paste the fixes from the source repo.

@AWSHurneyt Do you plan to implement this as part of 2.0.0 release?

I don't believe so. As destinations are being deprecated, my understanding at this time is that we plan to refactor the destination-related portions of these tests to use notification channels instead.
Including @qreshi, as he's been working on the notifications plugin.

yes I actually have a PR running right now https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/191, then removed some of that stuff but not all. it does seem all the destinations stuff relies on notifications repo which seems like even more reason to onboard on to this repo. If the expected functionality of the alerting plugin relies on the notifications plugin, then having the sanity tests only run from the notifications repo where it can assume that it's the only plugin installed doesn't reflect reality.


Add dynamicyield.com dynamic content service

e.g. in https://www.luisaviaroma.com/en-at/
I do not know how to detect it.
Maybe the DY global variable or the usage of cdn.dynamicyield.com

Implemented in #3505
Thank you!


Fix signer receiving a drained body on retries

Description
When retrying, the body can be drained, and there is already code that resets the request body on retries. The issue was that we were sending the drained request to the signer before reseting the request body, so signature would be based on an empty body
Issues Resolved
#202
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I'm not sure why integration tests are failing. Doesn't seem related to my change.
BTW sorry for the mess I seem to have created in this PR. I can't re-trigger DCO and code coverage checks. Please trigger on your side or let me know if I need to close this and open a new PR

Thank you for fixing this! Let's deal with the integ test separately.
--- FAIL: TestNodes (1.48s)
    --- FAIL: TestNodes/Stats (0.06s)
        --- FAIL: TestNodes/Stats/without_request (0.05s)

You will need to fix DCO, git commit --amend -s and force push your branch please?

DCO is now fixed

Any ideas why the integ test started failing?
=== RUN   TestNodes/Stats/without_request
    api_nodes_test.go:182:
        	Error Trace:	/home/runner/work/opensearch-go/opensearch-go/internal/test/helper.go:147
        	            				/home/runner/work/opensearch-go/opensearch-go/opensearchapi/api_nodes_test.go:182
        	Error:      	Should be empty, but was [{"op":"remove","path":"/nodes/tFKzdl01Ss2oOLoYJtcXcg/indices/search/request/took"}]
        	Test:       	TestNodes/Stats/without_request

The Integration tests runs against latest which was updated 7 days ago to 2.17.  I assume the version adds the new field which is currently not present in our spec. We need to add it. Also fails in the dependency updates.

Any ideas why the integ test started failing?
=== RUN   TestNodes/Stats/without_request
    api_nodes_test.go:182:
        	Error Trace:	/home/runner/work/opensearch-go/opensearch-go/internal/test/helper.go:147
        	            				/home/runner/work/opensearch-go/opensearch-go/opensearchapi/api_nodes_test.go:182
        	Error:      	Should be empty, but was [{"op":"remove","path":"/nodes/tFKzdl01Ss2oOLoYJtcXcg/indices/search/request/took"}]
        	Test:       	TestNodes/Stats/without_request

The Integration tests runs against latest which was updated 7 days ago to 2.17. I assume the version adds the new field which is currently not present in our spec. We need to add it. Also fails in the dependency updates.

Looks right. Should we lock it against a specific version (probably)? Want to take this up?

@Jakob3xD thanks for taking care of the integ tests in #623
@aouji rebase?


Unable to ignore a certain Ruby MRI warning

I've got this valid RSpec code:
describe Foo do
  context "some context" do
    let(:foo) { build(:foo) }

    context "on create" do
      it "does something" do
        expect { foo.save }.to change(foo, :bar).from(nil).to('baz')
      end
    end
  end
end

But MRI spits out a warning: warning: possible reference to past scope - foo inside the it block.
I've tried to ignore these warnings with let g:syntastic_ruby_mri_ignore_errors=[" possible reference to past scope"] with no effect. I was able to get syntastic to ignore them with let g:syntastic_ruby_mri_args = "-W1" but I'm paranoid and would prefer to ignore just the one specific warning instead.
I'm sure it's a dumb mistake with my configuration for ignoring the specific error and would appreciate some help. Thanks!

I've tried to silence these warnings with let g:syntastic_ruby_mri_ignore_errors=[" possible reference to past scope"] with no effect.

This is the expected behaviour, since syntastic_*_ignore_errors exists only for the tidy checker. :)
Try :help 'syntastic_quiet_messages' for a mechanism that works for all checkers.

Thank you! Fixed it with this:
    let g:syntastic_quiet_messages = {
        \ "type":    "style",
        \ "regex":   '\m.*reference to past scope.*',
        \ "file:p":  ['\m_spec\.rb$'] }

Also apparently this was only a Ruby 2.2.0 warning; 2.1.5 didn't care.

This is mostly wrong.  "type": "style" kills all style messages for all checkers, and "file:p":  ['\m_spec\.rb$'] kills all messages referring to _spec.rb.  I'd suggest something like:
let g:syntastic_ruby_mri_quiet_messages = { 'regex': 'reference to past scope' }

Ah ha. Thanks again.


Burning wheel sheet - Darkmode on mobile

First of all I would like to thank you for the character sheet.
Recently the roll 20 companion app as been updated and as a result of that a bug as been created.
On the PC site of roll 20 everything works fine as it should, but on the app some of the skill advancement just don't show up and also the background color as been changed to black so some of the text is almost unreadable.
I've also attached a picture of the problem.

I know that it has been a while since the creation of this sheet and that it's not app compatible but if it's not too much for you can you please take a look at this problem?

I think the problem is with dark mode on the phone app, but I'm not sure why. It works fine in dark mode on desktop, as you say. So it may be something that roll20 has to resolve, not me. Try asking on their forums or the upstream github?

Alright so I just downloaded the app to have a look for myself. This seems to be a problem that's exclusive to the roll20 character sheet compendium app, which I don't think supports legacy sheets. The BW sheet is a legacy sheet, and updating it to be non-legacy could result in some breaking changes (and would also be a lot of work).
However, I did try just loading up the sheet in a firefox browser on my tablet, and it's oddly able to implement a near-seamless darkmode without any code in the sheet telling it to do so:

I say this is odd because when I use darkmode with the BW sheet on firefox desktop this doesn't happen. So I can only assume this is either caused by the system-wide darkmode on my tablet or something that the firefox app does that the desktop version doesn't. Either way, this looks like your best bet for using the BW character sheet on mobile.


Chore: support for Horizontal forms with smaller cols

with supabase horizontal layouts..

closing this as we've updated it with #134


Updated email Ville's email address

Updated email Ville's email address.

Lgtm. Github isn't letting me merge this. Please rebase.


Problem import RoniaKit in project

Hello, how are you?
I managed success to import the library into my project, but when I try to run it, it shows an error:
I'm using ubuntu 22.04 LTS

@eritondev-stack This is a cmake project, you should add it as a cmake subproject. As a ref, you can check the example project

qrc:/qt/qml/Main/main.qml:6:1: module "RoniaKit" is not installed
Im using CMake Project ,How to add the subproject, please ?

Please check this sample project:
https://github.com/MosiQt/RoniaKit/tree/master/examples

Perfect, thanks for helping! Now I can run it.

Hi, I have followed the "simple" example for importing library in my projects, but I noticed that QtCreator shows this warnings both in the example and in my project.

Anyway, the strange things is that they build and run correctly.
Any advice on how to fix this warning?

Hi, I have followed the "simple" example for importing library in my projects, but I noticed that QtCreator shows this warnings both in the example and in my project.

Anyway, the strange things is that they build and run correctly. Any advice on how to fix this warning?

@Tayebe79 Please check this :)

@eritondev-stack  @gunaNeelamegam
I've already answered your question here

@totino5
In my own projects, Qt Creator even shows some error indication regarding my custom module's import statement sometimes, but it links against it at runtime without any issues, so I guess, you just have to ignore that warning.

@eritondev-stack  @gunaNeelamegam
I've already answered your questions here

@totino5 Qt Creator may show some wrong error/warnings occasionally
Sometimes resetting the code model may help!
Tools > QML/JS > Reset code model
Since there is no issue in the project itself I am closing the issue!


Update repositories.txt

Hello @6moon9.  Thanks for your interest in contributing to the Arduino Library Manager index.
I see the bot reported a problem with your submission that will block its acceptance:
❌ ERROR: The repository has no tags. You need to create a [release](https://docs.github.com/en/github/administering-a-repository/managing-releases-in-a-repository) or [tag](https://git-scm.com/docs/git-tag) that matches the version value in the library's library.properties file.

If you have any questions or problems while following the instructions to resolve the problem, please let me know and I'll help out.
If you decide you no longer wish to submit the library, you can close this pull request.

For the sake of a tidy repository, I'm going to close this due to lack of activity.
@6moon9 if you ever resolve the issues reported by the bot, please submit another pull request to add the library.
I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.


Front page fails to render completely: Undefined index: carousel; Error: open() on null?

With code + db export dated 2023-05-04:
[05-May-2023 09:58:43 UTC] PHP Notice:  Undefined index: carousel in /var/www/html/site/assets/themes/fw-parent/blocks/query/elements/query_items.php on line 38
[05-May-2023 09:58:43 UTC] PHP Fatal error:  Uncaught Error: Call to a member function open() on null in /var/www/html/site/assets/themes/fw-parent/blocks/query/elements/query_items.php:38
Stack trace:
#0 /var/www/html/site/assets/themes/fw-parent/blocks/content/query.php(235): include()
#1 /var/www/html/site/assets/themes/fw-parent/resources/functions/loop/extras.php(116): include('/var/www/html/s...')
#2 /var/www/html/site/assets/themes/fw-parent/resources/functions/loop/elements.php(792): block_output('open')
#3 /var/www/html/site/assets/themes/fw-parent/resources/functions/loop/elements.php(125): open_element(Array, 'field', 163)
#4 /var/www/html/site/assets/themes/fw-parent/resources/functions/loop/elements.php(85): content_loop('elements', 163, true)
#5 /var/www/html/site/assets/themes/fw-parent/template/layout.php(58): content_loop('elements', 2)
#6 /var/www/html/site/assets/themes/fw-parent/front-page.php(1): include('/var/www/html/s...')
#7 /var/www/html/site/wp-includes/template-loader.php(106): include('/var/www/html/s...')
#8 /var/www/html/s in /var/www/html/site/assets/themes/fw-parent/blocks/query/elements/query_items.php on line 38

This error is also preventing Simply Static export from working.

Many thanks to @phil-evans for fixing the issue by updating the files and libraries in the h7-riskprofiler repo earlier today (2023-05-05).


ScanWifi() doesn't work on Android

I'm trying to scan the Wi-Fi signals from my app to see which one is stronger. I followed the exact steps in the ionic documentation but the plugin seems that isn't working.
This is my .ts file:
import { Component } from '@angular/core';
import { IonicPage, NavController, NavParams } from 'ionic-angular';
import { Hotspot, HotspotNetwork } from '@ionic-native/hotspot';
/**

Generated class for the WifiSignalPage page.

See https://ionicframework.com/docs/components/#navigation for more info on
Ionic pages and navigation.
*/

@IonicPage()
@Component({
selector: 'page-wifi-signal',
templateUrl: 'wifi-signal.html',
})
export class WifiSignalPage {
constructor(private hotspot: Hotspot, public navCtrl: NavController, public navParams: NavParams) {
}
goBack(){
}
startScan() {
this.hotspot.scanWifi().then((networks: Array) => {
console.log(networks);
});
}
ionViewDidLoad() {
console.log('ionViewDidLoad WifiSignalPage');
}
}
When I try to emulate the application with the ionic app it says that the plugin is not installed, even when I do the

ionic cordova plugin add cordova-plugin-hotspot

and the

npm install --save @ionic-native/hotspot

So I'm being forced to build and emulate it on Android.
This is what the Android console shows:

Sad to see this discontinued

scanWifi does not work for me on emulator . Please help how can I get connected wifi SSID name and unique id ?

the plugin is discontinued.
BTW: Testing only works on real devices, not on emulator as in many case with Android


Feature : Add Inline form creation on relational dependency.

Hello. I want to suggest a new form field type that is called form_type_modal.
Actually its a relational modal that can be created run time.
So when user select a relational user from drop down that time he can also create a new user in using create button inline.
So we can manage
n-n
1-m
m-1
m-m
Relational Modal type
For more details
https://sonata-project.org/bundles/admin/3-x/doc/reference/form_types.html

Hi @vikrampariharcodereadr ,
Thank you for the suggestion. It's something we're planning on having in 4.0. I'm going to close the issue since there's already a conversation going for it here, and a package providing a solution in Backpack v3 here.
Cheers!

Hi @tabacitu is this feature something planned anytime soon (eg. next 2 weeks) ?
I tried the v3 package but it's obviously not working on v4 so i'm now deciding if writing something on my own or wait for an "official" backpack solution.
Thanks for the awesome work!

Hi @tabacitu I am using Backpak 4.0.5 but i did not see any inline model creation feature.
As you mention "It's something we're planning on having in 4.0." in comment.

Hi guys. Indeed, it didn't make the cut in 4.0 - but it will definitely be there in 4.1. If you're in a rush, @pleone , code your own. We do plan on working on this soon, but can't promise it'll be launched in less than 1 month. Sorry to disappoint!


iridium: Add version 2020.04.81-1

Will close this for now, will open a new one when I get other request (toggl) sorted out, likely quite a bit of overlap in terms of badly formatted manifest.


Corrected sql_features tsv so that features do not claim to be supported when there exists unsupported sub-features

@mikethebeer please review

LGTM 👍


Footer UI improvements

Is your feature request related to a problem? Please describe.

In this image you can see the buttons and text fonts are not very appealing and the icon logo is not showing
Describe the solution you'd like
The text and buttons interface should be changed in such a way that it looks appealing and the icon logo can be shown
Describe alternatives you've considered
For the solution I can change the look of the footer texts and buttons which will match the great footer animation such that it looks very appealing hence leading to a great User Interface and I can fix the icon logo problem.
Additional context (Mandatory )
I'd like if you could assign this issue to me as I have made several projects and would love to contribute in this too…
Are you contributing under any open-source program ?
GSSoC'24

Please assign this issue to me

@VedantAnand17 Welcome to METAVERSE!!!!!!
I have assigned you .
You can start working on this issue , I will add the labels(e.g level 1 ,2 or 3) after the review of the PR
Happy Coding !!!!!!!!!!

Hello sir @apu52  I would lie to work on this issue. Please assign me this task.

I would like to work on this issue , please assign this to me.
@apu52

@Satuti99 @TheNikhilRaj this issue is already assigned. but u can still work on new issues looking at the existing issues.


Create Phroute.php

Middleware for Phroute dispatcher

Sorry but I don't consider to add more middlewares to this package because it will be deprecated as soon as PSR-15 is accepted (that I think it will be sooner than later). In fact, the current middlewares have already been ported to psr-15 (https://github.com/middlewares/psr15-middlewares), so only bug fixes or minor improvements to the currently existing middlewares will be accepted here.
Thank you anyway for your effort. Feel free to create the psr-15 version of phroute middleware if you want.


Mobile styling fixes for server-side wallet disclaimer

r? @xgess CC @keybase/react-hackers
Markdown wasn't being styled properly on mobile.

headline isn't centered on mobile


Update CONTRIBUTING.md

add additional doc statement to bottom of file.

update for #3267
Summary

Release Note

NONE
Documentation

Doc only.

Moved new text to contributing.md

Can you put this under CONTRIBUTING.md rather than the readme?

Moved to contributing.md as requested.


Update manage-storage-analytics-logs.md

Customers raise cases for classic storage account that they are not able to see the $log container inside the portal

@normesta

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thanks @jainsourabh123 - can you please review and merge this PR into your branch - https://github.com/MicrosoftDocs/azure-docs/pull/104053. It proposes a few edits to your contribution. I want to make sure that you receive credit for you contribution, so I'll just use PRs into your branch of for edits. The edits remove the capitalization of "Classic", does the same for the "portal" reference. Also, I'm not sure about the "Storage Explorer preview" reference. The only two vehicles in the Azure portal that I'm aware of is either the container view or storage browser. Not sure if the existence of Storage Explorer preview in the Azure portal is regional, but I believe that tool was deprecated in favor of storage browser.

Hi @jainsourabh123 - a gentle ping. I'll give a week and if I don't hear back, I'll make the update directly in my branch and resolve this one. I just want to give you credit for the contribution.  Thx!

The pull is here https://github.com/jainsourabh123/azure-docs/pull/2/ - or just replace note with this:

[!NOTE]
For classic storage accounts, the $logs container appears only in Azure Storage Explorer. The $logs container isn't visible from storage browser or the container view that is available in the Azure portal.

Cheers

Thank you!
#sign-off


rotating a page to landscape orientation offsets the image

When a landscape orientation PDF passes through pdftopdf with option landscape=true, the resulting image is offset. Removing the landscape=true option does the right thing (auto-rotating the image without offsetting it).
This is a change in behavior between cups-filters v1.28.7 or 1.28.12. I have not tested 1.28.13, and don't know if this is the same bug as #454 and is therefore now fixed.
As a test, use this PDF generated by darktable:
dt-landscape-test.pdf
Running /usr/sbin/cupsfilter -p /etc/cups/ppd/PDF.ppd -o landscape=true -m application/vnd.cups-pdf dt-landscape-test.pdf > dt-landscape-test-filtered-with-landscape-option.pdf produces this (offset) file:
dt-landscape-test-filtered-with-landscape-option.pdf
Running /usr/sbin/cupsfilter -p /etc/cups/ppd/PDF.ppd -m application/vnd.cups-pdf dt-landscape-test.pdf > dt-landscape-test-filtered-without-landscape-option.pdf produces this (correctly autorotated) file:
dt-landscape-test-filtered-without-landscape-option.pdf
While the right call may be to simply not set landscape=true, this does appear to be a regression which resulted in this darktable bug https://github.com/darktable-org/darktable/issues/11416.
Note that it is not necessary to use a darktable generated PDF. For example, this PDF creating with LibreOffice produces the same behavior:
print orientation test landscape.pdf

First, if a user application, like Darktable prints a file, it should not use the "landscape" option. If the page is actually landscape (width > height) the pdftopdf filter automatically rotates the page by 90 degrees in case the printer pulls in the paper short-edge-first (portrait orientation, size in PPD has width < height) and does not rotate the page if the printer pulls in the paper long-edge-first (landscape orientation, size in PPD has width > height). Other applications neither use landscape nor orientation-requested options/attributes, especially if they send PDF files.
For my understanding, "landscape" is more for plain text files to arrange the text in a landscape format.
My suggestion to solve the problem is to remove the line which adds the "landscape" option from the Darktable code. As you have already tried to solve it by adding a line to add the "fit-to-page" option, I suggest you to not add "fit-to-page" but remove the line which adds "landscape" from the Darktable code. Now all files should print correctly right away.
What "landscape" should do in the pdftopdf filter to do something useful I have to find out at first. I never put a lot of thought into this option as the automatic page management of pdftopdf simply does the right thing without the option, and up to now I did not hear of any user application which supplies the "landscape" option with landscape-shaped documents.
Simply turning the document by 90 degrees, as the CUPS documentation  suggests would also be wrong, at least if one rotates after the automatic page management got applied. Another possibility for it would be overriding the automatic page management, letting pdftopdf not do any automatic rotation and then rotate according to the supplied "landscape" or "orientation-requested" option.
@michaelrsweet what is a filter like the pdftopdf filter supposed to actually do if the user supplies the "landscape" or "orientation-requested" option?

@tillkamppeter In the case of the pdftopdf filter, it shouldn't do anything with it since the orientation is passed through to the printer. For a raster filter, it should honor the request, rotating as necessary to produce the IPP-defined orientation (landscape is counter-clockwise, reverse-landscape is clockwise) based on the orientation of the input paper (typically portrait for short-edge feed and landscape or reverse-landscape for long-edge feed)...

My suggestion to solve the problem is to remove the line which adds the "landscape" option from the Darktable code.

@tillkamppeter Yes, that sounds right to me as well. I wrote darktable-org/darktable/pull/11430 with that change. This certainly makes things much more straightforward on the darktable side. Thank you for the detailed explanation!

The Debian wiki has this page.

@debiantriage That page is helpful!
A query from the darktable side:

I don't have objection on relying to rotation being done by the driver but pdf2pdf is only one driver amongst many.

So long as darktable relies on CUPS for output, we can expect that any modern system will have the pdf2pdf filter installed with the autorotate function enabled?

Given https://github.com/darktable-org/darktable/issues/11416#issuecomment-1082726205 (Upgrade: cups-filters:amd64 (1.28.11-2, 1.28.12-1)), it looks like the landscape behavior changed in v.1.28.12.

@tillkamppeter I observe the described behaviour with cups-filters 1.28.12 (Debian unstable) but not with 1.28.7 (Debian stable) or 1.21.6 (buster).

Given darktable-org/darktable#11416 (comment) (Upgrade: cups-filters:amd64 (1.28.11-2, 1.28.12-1)), it looks like the landscape behavior changed in v.1.28.12.

@dtorop I did several bug fixes on pdftopdf recently, mainly to make N-up working with all settings of print-scaling and to get correct centering even if the unprintable margins of the printer are not symmetric. As with auto-rotation no one needs (and so no one uses) the "landscape" option I forgot about it completely and did not test with it.
We need a test suite for cups-filters (topic for next Linux Plumbers Conference).

@debiantriage your documentation is great, I have learned a lot about pdftopdf which I did not know before. I did not write it by myself. It is done by many contributors, not only by Tobias Hoffmann and me. There were many people who have helped to get the PDF workflow coded.
@debiantriage we should somehow upstreamize (move to OpenPrinting) your documentation.

@tillkamppeter Yes good news about the fix in darktable. As Pascal wrote, authoritative upstream advice most welcome. And good to take the rotation work out of darktable print code.
And yes, that makes sense about plumbing and test suite. I'll keep this issue open, fwiw...

@tillkamppeter For a PDF with mixed orientation pages  pdfinfo -f 1 -l 3 mixed.pdf shows

Page    1 size: 595 x 842 pts (A4)
Page    1 rot:  0
Page    2 size: 841.89 x 595.28 pts (A4)
Page    2 rot:  0
Page    3 size: 595 x 842 pts (A4)
Page    3 rot:  90

Pages 2 and 3 are PDF landscape pages.
After treatment by pdftopdf on cups-filters 1.28.7 and earlier, out.pdf is

Page    1 size: 595 x 842 pts (A4)
Page    1 rot:  0
Page    2 size: 841.89 x 595.28 pts (A4)
Page    2 rot:  270
Page    3 size: 595 x 842 pts (A4)
Page    3 rot:  0

Autorotation has taken place by rotating the whole of PDF pages 2 and 3.
On cups-filters 1.28.13 out.pdf shows

Page    1 size:  595 x 842 pts (A4)
Page    1 rot:   0
Page    2 size:  595 x 842 pts (A4)
Page    2 rot:   0
Page    3 size:  595 x 842 pts (A4)
Page    3 rot:   0

Autorotation still takes place but it seems to me that PDF pages 2 and 3 have been redesigned (rather than the whole page rotated) to have the text rotated to put  it parallel to the long edgeof a PDF portrait page. I am curious why pdftopdf's technique has changed.
The command to use pdftopdf is
/usr/sbin/cupsfilter -p test.ppd -m application/vnd.cups-pdf  mixed.pdf > out.pdf

mixed.pdf and test.ppd are attached.
mixed.pdf
test.ppd.txt

Fixed in commit 9b86754.
@dtorop Thanks a lot for the bug report.
@debiantriage @michaelrsweet Thanks a lot for all the help and for your great documentation.

Now also the output when not using auto-rotating (-o nopdfAutoRotate) and controlling fully manually by orientation-requested and landscape is correct.
Fixed this with commit f730a1f8c2.

Backported the fix to the 1.x branch as commit 161b32b134097.

cups-filters 1.28.14 released with the fix included.

@tillkamppeter
I have a question regarding what you wrote above in
https://github.com/OpenPrinting/cups-filters/issues/456#issuecomment-1082832984
If the page is actually landscape (width > height)
the pdftopdf filter automatically rotates the page by 90 degrees
in case the printer pulls in the paper short-edge-first
(portrait orientation, size in PPD has width < height)
and does not rotate the page if the printer pulls in the paper
long-edge-first (landscape orientation, size in PPD has width > height).

I do not understand why it matters if the printer pulls in the paper
short-edge-first or long-edge-first.
There are printers that normally pull A4 (or Letter) paper long-edge-first
also for usual portrait printing content (printing content width < height).
In particular A3 capable printers pull A4 long-edge-first for faster A4 printing speed.
They pull A3 short-edge-first because their printing unit is A3 short-edge wide.
This means they can pull A4 long-edge-first to use the whole width of the
printing unit also for A4 printing so the time for a A4 long-edge-first paper
to pass the printing unit is the time for the A4 short-edge length
which is only 71% compared to the A4 long-edge length
so pulling A4 long-edge-first makes A4 printing 40% faster.

When I say "the printer pull the paper short-edge first" its some simplified description. I mean that the raster output data should be arranged in lines of pixels parallel to the short edge. Imagine an A4 sheet, and to describe the graphics on it a bitmap, as series of bits (not a matrix of bits) is created. For this one goes line by line (like with text) over the page. There are two possibilities, to have the lines parallel to the long edge (if you imagine the page in landscape orientation) or parallel to the short edge (portrait).
For high-end laser printers which print on A3 this does not matter. They have enough space for the raster data of a full page, so if a job contains raster data with the bitmap lines parallel to the short edge and the printer pulls A4 paper long-edge-first it is no problem, as it only starts printing after having received the full page.
But for cheaper printers the arrangement of raster data is important as they cannot hold the full page. They receive a certain band of bitmap data and print it out before they receive the next band. So the bitmap has to be arranged in the correct direction now. If the printer pulls the page short-edge-first (the standard for these cheaper printers) the bitmap lines have to be parallel to the short edge of the paper. The CUPS/PWG/Apple Raster file which Ghostscript produces in the gstoraster filter step displays in portrait orientation in rasterview, and if the content is landscape-oriented, you see it rotated by 90 degrees, the rotation being performed in the pdftopdf filter step. This is the situation which I call short-edge-first, even if it does not necessarily correspond with the actual printer hardware. The rasterto... CUPS driver filter or the driverless PWG/Apple-Raster consuming printer receives and consumes the bitmap line by line, beginning from what you see at the top in rasterview.
The DesignJet printer of issue #457 is probably not a cheap printer, but it also cannot hold the raster data of a full page, due to its large page sizes. It also has a roll feeder and a cutter so that you can easily produce any custom page size with the width of the roll and arbitrary (only less than the length remaining on the roll) in the other dimension. To save paper you decide for each job whether you want to print it long-edge-first or short-edge-first, and as the printer cannot hold the raster data of the full page, landscape-oriented output (raster lines parallel to long edge) need to get produced.
You actually do not need to specify the "landscape" option on this kind of printer, it is enough to specify the custom page size in landscape orientation (Custom.42x20in) or select a landscape variant of your page size from the PPD file (A3.Transverse) and pdftopdf rotates a portrait-oriented input page automatically then.

I think one can leave out the paper handling in the printer
(because this is a printer internal "implementation detail")
and one should leave out the word "landscape" in printing issues
because using it only causes endless confusion because
There is no such thing as "landscape printing"

I described my understanding in
https://en.opensuse.org/SDB:Landscape_Printing
some time ago based on traditional printing with drivers and PPD files.
As fas as I understand it all what matters is that the printing content
is within the printable area of the selected page size for the print job
(regardless if the content is provided as PostScript or as raster data).

@jsmeix Short version: the media orientation generally only matters for (PWG or Apple) raster printing and when printing envelopes (to make sure the flap is on the top). For PDF, PostScript, and JPEG the printer will handle rotating as needed...
Long version: early AirPrint printers that were able to pull media by the long edge did not run at full speed because they needed to buffer the whole page (to rotate it) before printing. The PWG defined new IPP member attributes for media-col-ready and media-col-database to allow a client to detect the orientation of the media in the tray and do the raster rotation on the client in order to print at full speed. These additions also provide some guidance for media that is orientation-dependent such as envelopes and letterhead (where rotating the page content the wrong way would yield incorrect printed results...)

@michaelrsweet
thank you for your explanation!
It shows again that "landsape" issues are complicated.


Update Cluster Health checking logic

As of https://github.com/elastic/elasticsearch/pull/78968, Elasticsearch does not return a 408 for cluster health timeouts.
We now need to parse the HTTP 200 response for the timed_out field in case of timeouts while a wait_for_* parameter is invoked.
Note that currently the operation relies on a combination of default operation parameters (request-params and retry-until-success) in order to execute, but this may be a good opportunity to abstract the client-level behavior away from the user and provide some opaque wait-for parameters to the operation, then a top-level timeout. This would allow us to abort tests which will never pass the cluster state assertion, rather than the current behavior of hanging indefinitely.

It looks like https://github.com/elastic/elasticsearch/pull/78968 was reverted: https://github.com/elastic/elasticsearch/pull/80821.
As of 8.2.2, Elasticsearch still returns 408:
> curl -D - -k -u elastic:changeme "https://localhost:9200/_cluster/health?wait_for_nodes=2&timeout=1ms&pretty"
HTTP/1.1 408 Request Timeout
X-elastic-product: Elasticsearch
content-type: application/json
content-length: 465

{
  "cluster_name" : "elasticsearch",
  "status" : "green",
  "timed_out" : true,
  "number_of_nodes" : 1,
  "number_of_data_nodes" : 1,
  "active_primary_shards" : 2,
  "active_shards" : 2,
  "relocating_shards" : 0,
  "initializing_shards" : 0,
  "unassigned_shards" : 0,
  "delayed_unassigned_shards" : 0,
  "number_of_pending_tasks" : 0,
  "number_of_in_flight_fetch" : 0,
  "task_max_waiting_in_queue_millis" : 0,
  "active_shards_percent_as_number" : 100.0
}

Elasticsearch version:
> curl -k -u elastic:changeme "https://localhost:9200"
{
  "name" : "eli.local",
  "cluster_name" : "elasticsearch",
  "cluster_uuid" : "iYa9R7SbRmqbW1bwWGs1aA",
  "version" : {
    "number" : "8.2.2",
    "build_flavor" : "default",
    "build_type" : "tar",
    "build_hash" : "9876968ef3c745186b94fdabd4483e01499224ef",
    "build_date" : "2022-05-25T15:47:06.259735307Z",
    "build_snapshot" : false,
    "lucene_version" : "9.1.0",
    "minimum_wire_compatibility_version" : "7.17.0",
    "minimum_index_compatibility_version" : "7.0.0"
  },
  "tagline" : "You Know, for Search"
}

Not sure what's up with that.

Unfortunately, the needed reverted due to backward compatibility concerns :( It landed quite late to 8.0 and there was a concern that we didn't provide a proper migration path for ES 7.x users.

@j-bennet great find! And since it's not even deprecated now we can continue what we're currently doing and close this issue.


Migrate Java 17+ images to eclipse-temurin base

As described in #159 we have to move the openjdk:17 images to a new base. This PR is the beginning of that work. All of the images build and the tests pass. I need to test out some of the images some more, though.

reaping the benefit of your variants-as-tags refactor from earlier! 🏅

Isn't it nice when that works out that way? :)

This was done in response to https://github.com/docker-library/openjdk/pull/495


[5.10] Use new SwiftPM flag to remove $ORIGIN from installed sourcekit-lsp ELF executable runpath

Cherrypick of #894
Explanation: Without this flag, sourcekit-lsp looks in usr/bin/ first for shared libraries, but there are none in that executable directory.
Scope: installed executable runpath
Issue: none
Risk: none, there were no shared libraries there
Testing: SwiftPM merged using this flag into trunk and 5.10 last week, no problems with swift-package itself so far.
Reviewer: @ahoppen

@swift-ci please test


Tracking is working with NuScenes but strange error occurs

The Tracking seems to be working with nuScenes but still an error occurs.
Code:
python3 tools/nusc_tracking/pub_test.py --work_dir work_dirs/nusc_0075_test --checkpoint detection.json --version v1.0-test --root data/nuScenes/v1.0-test
Error:

Hi, after generating the prediction files, you need to submit to the eval server to get results for the test set.
The evaluation code can only evaluates val set locally


✨ [Feature] 建议facades.Orm(), 新增 AutoMigrate

Before feedback (在反馈之前)

[X] There are no features that I want to submit in Issues (当前 Issues 中没有我将要提交的新功能)

Describe Feature (描述功能)
新增 AutoMigrate, 可选用迁移功能
contracts/database/orm/orm.go:
type Orm interface {
	...
	AutoMigrate(values ...any) error
}

database/orm.go:
func (r *OrmImpl) AutoMigrate(values ...any) error {
	//TODO implement me
	db := r.Query().(*databasegorm.QueryImpl)

	return db.Instance().AutoMigrate(values...)
}

Hi @yueqing2617 Thanks for your feedback, AutoMigrate is so different from Laravel migration, and we think AutoMigrate  is not very safe and graceful, so we don't have a plan to implement this feature now.

Close, please reopen if necessary.


Allow JWT aud to be a string

Per the spec:

In the special case when the JWT has one audience, the "aud" value MAY be
a single case-sensitive string containing a StringOrURI value.

https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.3
I ran into this with my Apple ID token not being parsed. It uses a string for the aud value. Thanks!

Thanks!

@pilcrowOnPaper Thanks for merging! I just noticed the example in createJWT.md uses audience instead of audiences.
https://github.com/pilcrowOnPaper/oslo/blob/main/docs/pages/reference/jwt/createJWT.md?plain=1#L66


Confirm shutdown procedure of the ET computer

As Celine mentioned, https://github.com/TheAxonLab/hcph-sops/pull/152#discussion_r1310575993, it is unclear that the following is true:
https://github.com/TheAxonLab/hcph-sops/blob/7da38633627eb2d0bc82f56d0cac1cdc966785dd/docs/data-collection/tear-down.md#L82

@esavary please confirm and send PR with final procedure.


Update replay protection prefix for Foundation hardfork

--DO NOT MERGE UNTIL HARDFORK ACTIVATION ON FEB 3 2021--
This PR changes the replay protection prefix from 0 to 1, in accordance with the Sia Foundation hardfork, scheduled to activate at height 298,000. After the hardfork, users will need to update to the latest version of the app for their signatures to be valid on the fork chain.
The minimal version of this change is simply to change a 0 to a 1, but I opted to refactor the replay protection code a little as well.

cc @TamtamHero, just making sure you've seen this in advance of the hardfork.

cc @TamtamHero, just making sure you've seen this in advance of the hardfork.

Should I merge and release it before, or just after the fork happens ?

Should I merge and release it before, or just after the fork happens ?

I think it's not critical as long as it's within 24 hours. If you merge 24 hours in advance, then people might update early and create invalid signatures; if you merge 24 hours afterward, then in the interim people won't be able to create valid signatures at all.
So my recommendation would be to merge+release as close as possible to the activation, but "late" is probably better than "early," since you don't want people updating early and then complaining that the update broke everything.
A more robust approach would be to change the API such that the current block height is sent to the Ledger. Then the device can select the correct prefix automatically. The downside is that this would require updating all client software to supply the height. But I think we could make this happen if necessary.

I think it's not critical as long as it's within 24 hours. If you merge 24 hours in advance, then people might update early and create invalid signatures; if you merge 24 hours afterward, then in the interim people won't be able to create valid signatures at all.
So my recommendation would be to merge+release as close as possible to the activation, but "late" is probably better than "early," since you don't want people updating early and then complaining that the update broke everything.
A more robust approach would be to change the API such that the current block height is sent to the Ledger. Then the device can select the correct prefix automatically. The downside is that this would require updating all client software to supply the height. But I think we could make this happen if necessary.

I'm putting an alert for the HF day, it should be good enough :)

I'm putting an alert for the HF day, it should be good enough :)


add support for x-ms-header-collectioni-prefix

see docs for this extension here
Currenty storage sdks wrap this ini their own code:
request handling here
response handling here
Want to be able to handle this during generationn, as other languages are handling this

closing because we're moving away from swagger


tour: Update example code

Context: https://go.dev/tour/basics/3
package main

import (
	"fmt"
	"math"
)

func main() {
	fmt.Println(math.pi) // replace to fmt.Println(math.Pi)
}

I just didn't read the description to the end.


特性门控

missing ExpandCSIVolumes featureGates
in v1.26
but it missing v1.27 doc

Page related to the issue : https://v1-26.docs.kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

In v1.27, the ExpandCSIVolumes feature gate has been removed, and it is now documented on the Feature Gate (removed) page. Additionally, this has been highlighted in the "Removals and Major Changes in v1.27" blog post, which you can check out here: blog/upcoming-changes-in-kubernetes-v1-27

/triage unresolved
/priority awaiting-more-evidence
/close not-planned
Please file issues in English. However, this doesn't sound like a bug.


No matter what version I use it does not work

Same issue here

same

good to know im not the only one struggling


libwebp in windows executable

Current Behavior
When installing the windows versions provided here (https://github.com/UB-Mannheim/tesseract/wiki), the newest version (<IP_ADDRESS>3401) contains libwebp 1.3.0 which has a zero day vulnerability.
Similarly, the version we use (5.0.0-alpha.20190708) contains libwebp 0.6.1 which also has a zero day vulnerability.
We do not use the webp functionality (directly) but removing or replacing the dll with a good version causes negative results.
Expected Behavior
Update supported versions of the tesseract windows installer to include a non-vulnerable version of libwebp
Suggested Fix
No response
tesseract -v
tesseract v<IP_ADDRESS>30401
leptonica-1.83.1
libgif 5.2.1 : libjpeg 8d (libjpeg-turbo 2.1.4) : libpng 1.6.39 : libtiff 4.5.0 : zlib 1.2.13 : libwebp 1.3.0 : libopenjp2 2.5.0
Found AVX512BW
Found AVX512F
Found AVX512VNNI
Found AVX2
Found AVX
Found FMA
Found SSE4.1
Found libarchive 3.6.2 zlib/1.2.13 liblzma/5.2.9 bz2lib/1.0.8 liblz4/1.9.4 libzstd/1.5.2
Found libcurl/8.0.1 Schannel zlib/1.2.13 brotli/1.0.9 zstd/1.5.4 libidn2/2.3.4 libpsl/0.21.2 (+libidn2/2.3.3) libssh2/1.10.0

tesseract v5.0.0-alpha.20190708
leptonica-1.78.0
libgif 5.1.4 : libjpeg 8d (libjpeg-turbo 1.5.3) : libpng 1.6.34 : libtiff 4.0.9 : zlib 1.2.11 : libwebp 0.6.1 : libopenjp2 2.3.0
Found AVX512BW
Found AVX512F
Found AVX2
Found AVX
Found SSE
Found libarchive 3.3.2 zlib/1.2.11 liblzma/5.2.3 bz2lib/1.0.6 liblz4/1.7.5
Operating System
Windows 11
Other Operating System
No response
uname -a
No response
Compiler
N/A, using your pre-built installers
CPU
N/A
Virtualization / Containers
n/a
Other Information
Details on how we can compile our own version with a good copy of libwebp could also solve the problem, particularly on the version we currently use (5.0.0-alpha.20190708)

Replacing the relevant DLL by a newer compatible one (from msys2) should work.
And the code is only used for WebP images which are still very rare. It is possible to avoid or minimize the risk if you either don't process such images or only process WebP images from trusted sources.

Replacing the relevant DLL by a newer compatible one (from msys2) should work.
And the code is only used for WebP images which are still very rare. It is possible to avoid or minimize the risk if you either don't process such images or only process WebP images from trusted sources.

Sadly, we tried this and it broke our tooling, thus why we are looking at other solutions

Replacing the relevant DLL by a newer compatible one (from msys2) should work.
And the code is only used for WebP images which are still very rare. It is possible to avoid or minimize the risk if you either don't process such images or only process WebP images from trusted sources.

Sadly, we tried this and it broke our tooling, thus why we are looking at other solutions

We discovered why replacing the libwebp-7 DLL did not work.  In the newest (1.3.2) version, libwebp-7 adds another dependency.    We are testing, but adding the additional dependency does seem to solve our problem.  The additional dependency is libsharpyuv-0.dll.  We used files from here: https://packages.msys2.org/package/mingw-w64-x86_64-libwebp

I think this issue was fixed by the installer for Tesseract 5.3.3. Please reopen if it still exists.


TCGETS2 is not available on all arches

You can check the zerrors_linux_*.go files in https://github.com/golang/sys/tree/master/unix for TCGETS2, which is missing from a few of the files.
I also found this message from glibc about how it's architecture specific, though I did not find any specific docs about it.
Specifically, it is ppc64le that is failing when I build on Fedora.

That's a bummer, I guess we should split func (port *unixPort) setSpecialBaudrate(speed uint32) error by architecture and put an "unimplemented" placeholder for ppc64le (unless you have a different solution for that architecture).

Unfortunately, I do not have any other solution. It's a primary build target in Fedora, but I'm not even sure if anyone uses it with go-serial. If they do, hopefully they can come around with a better fix if one exists.


Update tob-mistake-tracker to v2.3

Fix issue where Verzik mistakes were not being detected
Looks like there was a recent change to when NpcSpawned event gets fired, which causes the PoseID to no longer be the same as what it was (it's now -1 at the time of event being fired). Using Verzik NPC IDs instead now.

Here is the diff of this commit, since the diff above is wonky (since it's going across repos):
https://github.com/QuestingPet/TobMistakeTracker/commit/835f0ee6bb251d5b335c5eb7040be690ebd60a9f


feat: implement configuration gui

Purpose
RAI's configuration is mostly dictated by the config.toml file.
Proposed Changes
This PR introduces a gui for configuring the following parts of RAI:

Models
Tracing
ASR (not yet honored by RAI_ASR)
TTS (not yet honored by RAI_TTS)
Additional features

Issues

Links to relevant issues

Testing
streamlit run src/rai/rai/utils/configurator.py

Summary by CodeRabbit

New Features

Introduced a Streamlit-based configuration wizard for setting up an AI environment, guiding users through model selection, tracing, speech recognition, and more.
Added new sections for automatic speech recognition (ASR) and text-to-speech (TTS) in the configuration, enhancing functionality.
Added a new dependency for enhanced project management.

Bug Fixes

Improved error handling in the configuration wizard to ensure necessary environment variables are present before saving configurations.

Refactor

Updated the function for tracing callbacks to allow optional parameters for more flexible configuration.

Documentation

Enhanced the README to clarify setup processes and limitations of the RAI framework.

@coderabbit pause


properly serialize maps skipping nulls

Previously, serializing map-like objects would incorrectly write commas when entries were skipped. This was because although the entry itself was skipped, the separator was not.
This PR changes that behaviour, and amalgamates some basic functionality used in the map serialization and many other serialization functions: writing entry separators and skipping members. Additionally, skipping nulls on pairs (single maps) has also been completed. With tests, of course.

Sweet, thanks for this fix!


[ConfigTool] USB controller -> calibrate magnetometer -> forever waiting...

Waiting for controller stream to start...
I think the USB-connected controllers shouldn't even have the calibrate magnetometer button available to them.

I fixed this issue in ce1e245e6ff097ad12c36b6c01c82528bd68e7e2 related to the other controller pairing work I did.


Feat: Add Blint Bom

https://pkg.go.dev/vuln/GO-2024-3080
depscan-normal.html.json
depscan-binary.html.json


Report: Some of ActiveRecord::Dirty methods are deprecated but it doesn't support

Report
HI. Right now, some of ActiveRecord::Dirty methods are deprecated in Rails 5.1 and will be removed in Rails 5.2 according to this pr:
ref: https://www.ombulabs.com/blog/rails/upgrades/active-record-5-1-api-changes.html
However, in simple_enum, new methods as described below are NOT supported.

saved_change_to_attribute? (instead of attribute_changed?)
attribute_before_last_save (instead of attribute_was )

What is problem?
It could cause some error when updating from Rails 5.1 or older to Rails 5.2+.
For example,
model: User, column: state_cd (enum)

before

state_changed? #=> true or false

after update(changing method name)
simple_enum doesn't support new methods, so it cause error like below.

saved_change_to_state? # => it doesn't work.

I got error.
        NoMethodError:
            undefined method `saved_change_to_state?' for #<User:0x00005xxa>

So I have to write like this.
saved_change_to_state_cd?  #=> true or false

@lwe  Could you check this issue?

@ykamez I will try and find some time to look into this and get back to you

Thanks y'all and especially @drobny for picking this up.

@ykamez can you confirm ☝ works for you, need to try and sort CI as it is failing (unrelated to my change)

Thanks @drobny
Changes in this pr looks good to me.

👍 will merge and release this weekend. Thanks y’all

@drobny  Please merge the latest master branch.


Build errors with Dart Sass 1.40.0

Updating from Dart Sass 1.39.2 to 1.40.0 leads to build errors when building Bootstrap 5:
Build Error (PostcssCompiler) in /home/boris/project/node_modules/bootstrap/scss/mixins/_border-radius.scss:9:36

0.2rem and 0 are incompatible.
  ╷
9 │       $return: append($return, max($value, 0));
  │                                    ^^^^^^ 0.2rem
  │                                            ━ 0
  ╵
  node_modules/bootstrap/scss/mixins/_border-radius.scss 9:36                                                           valid-radius()
  node_modules/bootstrap/scss/mixins/_border-radius.scss 20:20                                                          border-radius()
  node_modules/bootstrap/scss/_reboot.scss 322:3                                                                        @import
  node_modules/bootstrap/scss/bootstrap.scss 17:9                                                                       @import

There are perhaps more cases of this, I guess this is just the first one.
OS is Linux.

+1

The if condition doesn't work.

same, any idea how to resolve the issue? (downgrading?)

same, any idea how to resolve the issue? (downgrading?)
(NVM i should check before asking, :p resolved ;))

@PieterBollen87 how did you solve it?

Same here. Downgrading to sass 1.39.2 fixed it.

+1

+1 Same issue with Bootstrap v4.  I didn't upgrade anything but build started failing.  Forcing "sass": "1.39.2" fixed it.

There will be a patch release reverting the backwards incompatiblity soon, see: https://github.com/sass/sass/issues/3142#issuecomment-918923271

Yeah not an issue on our side. See the upstream issue.
Pin sass to an older version until a fix is released.


Time series improvements

Improvement of docstrings and docstring examples in TimeSeriesApi
Split up forecast function into multiple smaller functions
Static forecasts is now a possibility
Possibility of specifying resample_method of actual dataframe in init (either "ffill"(default) or "bfill") because some data providers like "Solcast" index their data with a timestamp marking the end of the time-period that the data is valid for
Automatic Datetime conversion of indices when initializing

very nice!


New: Allow bookkeeping on caches

Description
Changes proposed in this pull request.
Test plan
Outline the test plan used to test this change before merging it.

Fixes #.

Codecov Report

Merging #389 into master will decrease coverage by 0.05%.
The diff coverage is 72%.

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
- Coverage   55.47%   55.41%   -0.06%
==========================================
  Files          51       51
  Lines        6277     6301      +24
==========================================
+ Hits         3482     3492      +10
- Misses       2472     2486      +14
  Partials      323      323

Impacted Files
Coverage Δ

trireme.go
47.52% <100%> (ø)
:arrow_up:

supervisor/supervisor.go
65.68% <100%> (ø)
:arrow_up:

enforcer/datapath.go
61.81% <100%> (ø)
:arrow_up:

enforcer/utils/pkiverifier/pkiverifier.go
95.55% <100%> (ø)
:arrow_up:

enforcer/utils/tokens/jwt.go
93.33% <100%> (ø)
:arrow_up:

processmon/processmon.go
72.72% <100%> (ø)
:arrow_up:

cache/cache.go
78.03% <60%> (-5.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b4ec62...67ff3bd. Read the comment docs.


Pipeline api tweaks

Some small but breaking changes:

By default, ResponseContentTransformer used to skip the transform when the input type already matched the output type. (For example, if the transformer returned a string but there was already a string from upstream in the pipeline, it wouldn’t run.) This behavior is useful but confusing, and shouldn’t be the default.
Enum for clearer pipeline config actions:

Before:
configureTransformer("/foo", replacingExisting: true)
configureTransformer("/foo", replacingExisting: false)

After:
configureTransformer("/foo", action: .replaceExisting)
configureTransformer("/foo", action: .appendToExisting)

This PR also includes more helpful logging of exactly what happens to a response when it runs through the transformer pipeline.

Merging this PR, but project watchers, please feel free to provide feedback even after it’s closed. (That’s the point of making it a PR!)


can: stm32: Build issue on g4 target

Describe the bug
twister -b -p nucleo_g474re  -T samples/drivers/can/sample.drivers.can
/__w/zephyr/zephyr/drivers/can/can_stm32fd.c
/__w/zephyr/zephyr/drivers/can/can_stm32fd.c: In function 'can_stm32fd_get_max_bitrate':
/__w/zephyr/zephyr/drivers/can/can_stm32fd.c:161:20: error: 'const struct can_stm32fd_config' has no member named 'mcan'
  161 |  *max_bitrate = cfg->mcan.max_bitrate;
      |                    ^~
/__w/zephyr/zephyr/drivers/can/can_stm32fd.c: In function 'can_stm32fd_line_1_isr':
/__w/zephyr/zephyr/drivers/can/can_stm32fd.c:181:37: error: 'data' undeclared (first use in this function)
  181 |  struct can_mcan_data *mcan_data = &data->mcan_data;
      |                                     ^~~~

Impact
CI blocked

@alexanderwachter Would you  have time to have a look ?

@erwango My apologies. Fix is in #43901.


OADP-3598 Check ImageRegistryConfig management state isn't set to Removed

Signed-off-by: Tiger Kaovilai<EMAIL_ADDRESS>

/cherry-pick oadp-1.3


[MM-48658] Improve global widget resizing logic

Summary
PR simplifies the dynamic resizing logic for global widget and adds support for zooming along with the main app (see video below).
Ticket Link
https://mattermost.atlassian.net/browse/MM-48658
Related PR
https://github.com/mattermost/mattermost-plugin-calls/pull/323
Video
https://user-images.githubusercontent.com/1832946/217058887-a0ff3089-212a-4b03-b134-f985b247ed5f.mov
Release Note
NONE

Thanks Tasos, forgot to update a test after the last commit. Should be good now.


[BULK] Validation: validation fixes JM 5/24d

This PR fixes 30 missing descriptions.

Docs Build status updates of commit 1561265:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-nav/AutoFormatType-Property.md
:white_check_mark:Succeeded

dynamics-nav/AutoIncrement-Property.md
:white_check_mark:Succeeded

dynamics-nav/AutoReplace-Property.md
:white_check_mark:Succeeded

dynamics-nav/AutoSave-Property.md
:white_check_mark:Succeeded

dynamics-nav/AutoSplitKey-Property.md
:white_check_mark:Succeeded

dynamics-nav/AutoUpdate-Property.md
:white_check_mark:Succeeded

dynamics-nav/Automated-Data-Capture-System.md
:white_check_mark:Succeeded

dynamics-nav/Automating-the-Upgrade-Process-using-Sample-Windows-PowerShell-Scripts-2017.md
:white_check_mark:Succeeded

dynamics-nav/Avoiding-Run-Time-Errors.md
:white_check_mark:Succeeded

dynamics-nav/BINDSUBSCRIPTION-Function.md
:white_check_mark:Succeeded

dynamics-nav/BREAK-Function--Debugger-.md
:white_check_mark:Succeeded

dynamics-nav/BREAK-Function--Report--XMLport-.md
:white_check_mark:Succeeded

dynamics-nav/BREAKONERROR-Function--Debugger-.md
:white_check_mark:Succeeded

dynamics-nav/BREAKONRECORDCHANGES-Function--Debugger-.md
:white_check_mark:Succeeded

dynamics-nav/BREAKUNBOUND-Function--XMLport-.md
:white_check_mark:Succeeded

dynamics-nav/BackupKey-Property.md
:white_check_mark:Succeeded

dynamics-nav/Basic-Page-Operations.md
:white_check_mark:Succeeded

dynamics-nav/Best-Practices-for-Using-Automation-with-the-Microsoft-Dynamics-NAV-Windows-Client.md
:white_check_mark:Succeeded

dynamics-nav/Best-Practices-with-Microsoft-Dynamics-NAV-Events.md
:white_check_mark:Succeeded

dynamics-nav/BigText-Functions.md
:white_check_mark:Succeeded

dynamics-nav/Binding-a-Windows-Client-Control-Add-in-to-the-Database.md
:white_check_mark:Succeeded

dynamics-nav/Bitmap-Property.md
:white_check_mark:Succeeded

dynamics-nav/BitmapList-Property.md
:white_check_mark:Succeeded

dynamics-nav/BitmapPos-Property.md
:white_check_mark:Succeeded

dynamics-nav/BlankNumbers-Property.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you'd like to see. Thank you!
@buck1ey  Can you please suggest a reviewer for this PR? Thank you.


⚠ Bofrost.at has degraded performance

In a4b8d22, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1747 ms

Resolved: Bofrost.at performance has improved in 78f0ed9.


Switch quantum emoticon to use 7-bit ASCII and ibmq_melbourne_16 (fixes #41)

Fix some deprecation warnings related to using global functions rather than the new IBMQ ones
Use 7-bit ASCII and a 14-bit register, in order to enable ...
... using ibmq_melbourne_16 as the backend rather than the retired ibmqx5

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Good spot! Those are now fixed, thanks.


Logging to debug 500 Internal Server Error from Webpack Middleware

I have a webpack config that works fine from the command line, but throws a 500 (presumably from the Webpack middleware) whenever one of the entry points is accessed by the browser.
The Webpack middleware seems to be bit of a black-box at the moment, would it be possible to expose some of the Node.js instance's output? The 500 response returned empty content.

Actually I do get somewhat of an error at startup, although the javascript stack trace is split over several lines so a bit hard to bring back together...
Looks like a call from WebpackDevMiddleware.js into MemoryFileSystem.js - pathToArray is throwing the error.
28 May 2017 21:22:52.201  at C:\Users\james\Source\Workspaces\code\node_modules\webpack\lib\Compiler.js:73:18 28 May 2017 21:22:52.199  at Watching._done (C:\Users\james\Source\Workspaces\code\node_modules\webpack\lib\Compiler.js:98:16) 28 May 2017 21:22:52.198  at Compiler.applyPlugins (C:\Users\james\Source\Workspaces\code\node_modules\tapable\lib\Tapable.js:61:14) 28 May 2017 21:22:52.196  at Compiler.<anonymous> (C:\Users\james\Source\Workspaces\code\node_modules\aspnet-webpack\WebpackDevMiddleware.js:82:9) 28 May 2017 21:22:52.195  at copyRecursiveToRealFsSync (C:\Users\james\Source\Workspaces\code\node_modules\aspnet-webpack\WebpackDevMiddleware.js:133:31) 28 May 2017 21:22:52.193  at Array.forEach (native) 28 May 2017 21:22:52.192  at C:\Users\james\Source\Workspaces\code\node_modules\aspnet-webpack\WebpackDevMiddleware.js:137:33 28 May 2017 21:22:52.191  at MemoryFileSystem.statSync (C:\Users\james\Source\Workspaces\code\node_modules\memory-fs\lib\MemoryFileSystem.js:76:21) 28 May 2017 21:22:52.161  at MemoryFileSystem.meta (C:\Users\james\Source\Workspaces\code\node_modules\memory-fs\lib\MemoryFileSystem.js:61:13) 28 May 2017 21:22:52.159  at pathToArray (C:\Users\james\Source\Workspaces\code\node_modules\memory-fs\lib\MemoryFileSystem.js:44:10) 28 May 2017 21:22:52.157  Error 28 May 2017 21:22:52.156  ^ 28 May 2017 21:22:52.155  throw new MemoryFileSystemError(errors.code.EINVAL, path); 28 May 2017 21:22:52.152  C:\Users\james\Source\Workspaces\code\node_modules\memory-fs\lib\MemoryFileSystem.js:44
My webpack.config.js looks like...
`
var Path = require("path");
var Glob = require("glob");
const entries = {};
const files = Glob.sync("./Features/**/*.index.ts?(x)");
files.forEach(file => {
var name = file.match("./Features(.+[^/]+).tsx?$")[1];
entries[name] = file;
});
module.exports = {
entry: entries,
output: {
filename: "[name].js",
path: Path.resolve(__dirname, "wwwroot", "app"),
publicPath: "/app/"
},
module: {
rules: [
{
test: /.tsx?$/,
loader: "ts-loader",
exclude: /node_modules/
}
]
},
resolve: {
extensions: [".tsx", ".ts", ".js"]
}
};
`
I'm scanning my ./Feature folders that contain xxx.index.ts or xxx.index.tsx (in addition to MVC Controllers, Models, etc and aiming to output them to wwwroot/app/

Ok, looks like my entries are being generated with names like '/MyFeature1/MyFeature.index.ts' and '/MyFeature2/MyFeature.index.ts'. Webpack on the command line doesn't mind the leading slash, but it gets in the way of the Webpack Dev Server that WebpackMiddleware spawns off.