Use groth16 WASM implementation instead of the native one

Just separate the feature std from implementaion that provide the curves implementation in the hp-groth16 crate.
Now the verifier use the hp-groth16 instead the native one so the node proviede the native implementation for the future, but the verifier not.
Also I make the verifier functions interface all the same.
Missing: rerun the benchmarks

Would you be able to test locally ? Like try to sync to the testnet a node with new node and runtime version, submit a Groth16 proof ?

I did the follow tests:

Started a new local chain using the docker compose file provided in the source after pulled the horizenlabs/zkverify:latest docker image from docker hub, performed a runtime upgrade and checked that the update is ok and that the chain continues to forge new blocks
A new synch of the testenet chain (make sure that I'm not use an old cache)

Bonus: In order to be sure that I'm able to spot issue I generated a runtime that need the native groth16 implementation and repeated 1; in this case the runtime update executed successfully  but the chain stop to generate new blocks.

About submitting a new groth16 proof we have the e2e tests that protect us by proof submission regression.


Update package.json to include the repository

NOTE: This is not a bot. This change was made by and comments will be reviewed by humans. We are using this service account to be able to track the overall progress.
With the rise in supply chain attacks and OSS dependencies being used as a attack vector, Microsoft is working with our ecosystem partners, such as the Linux Foundation's OpenSSF, to enable OSS consumers to track packages back to their public sources.
We've identified that the following packages published to NPM do not report where sources can be found, typically accomplished by including a link to your GitHub repository in your package.json REPOSITORY field. This PR was created to add this value, ensuring future releases will include this provenance information.
If you do not want us to create such PRs against your GitHub repositories, or wish to provide any other feedback, please comment on this PR.
Published NPM packages with repository information:
• orbit-db-pubsub

Is there anything that is needed to land this pull request ?

ls there anything else I can do to land this pull request ?

Is there anything that is needed to land this pull request?


Does not build

While building locally or through aur-helper:
[ 28%] Building CXX object src/host/CMakeFiles/airwave-host-64.dir/host.cpp.o
In file included from /usr/include/wine/windows/objbase.h:258,
                 from /usr/include/wine/windows/ole2.h:25,
                 from /usr/include/wine/windows/wtypes.h:13,
                 from /usr/include/wine/windows/winscard.h:22,
                 from /usr/include/wine/windows/windows.h:70,
                 from /home/duke/.build/airwave/src/host/host.h:7,
                 from /home/duke/.build/airwave/src/host/host.cpp:1:
/usr/include/wine/windows/objidl.h:6100:15: error: ‘union _userSTGMEDIUM::<unnamed struct>::__WIDL_objidl_generated_name_0000000C’ invalid; an anonymous struct may only have public non-static data members [-fpermissive]
 6100 |         union __WIDL_objidl_generated_name_0000000C {
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/duke/.build/airwave/src/host/host.cpp: In member function ‘bool Airwave::Host::initialize(const char*, int)’:
/home/duke/.build/airwave/src/host/host.cpp:63:44: warning: cast between incompatible function types from ‘FARPROC’ {aka ‘long int (__attribute__((ms_abi)) *)()’} to ‘Airwave::VstPluginMainProc’ {aka ‘AEffect* (__attribute__((ms_abi)) *)(long int (__attribute__((ms_abi)) *)(AEffect*, int, int, long int, void*, float))’} [-Wcast-function-type]
   63 |    GetProcAddress(module_, "VSTPluginMain"));
      |                                            ^
/home/duke/.build/airwave/src/host/host.cpp:67:36: warning: cast between incompatible function types from ‘FARPROC’ {aka ‘long int (__attribute__((ms_abi)) *)()’} to ‘Airwave::VstPluginMainProc’ {aka ‘AEffect* (__attribute__((ms_abi)) *)(long int (__attribute__((ms_abi)) *)(AEffect*, int, int, long int, void*, float))’} [-Wcast-function-type]
   67 |     GetProcAddress(module_, "main"));
      |                                    ^
winegcc: g++ failed
make[2]: *** [src/host/CMakeFiles/airwave-host-64.dir/build.make:128: src/host/CMakeFiles/airwave-host-64.dir/host.cpp.o] Error 2
make[1]: *** [CMakeFiles/Makefile2:148: src/host/CMakeFiles/airwave-host-64.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

Put -D__WIDL_objidl_generated_name_0000000C= in the CXXFLAGS and it should build

Pull request here: https://github.com/psycha0s/airwave/pull/105


[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

You can run many tests automatically using release/src/main/scripts/mass_comment.py.

stop reviewer notifications


Added switch to force prompt on login after logout

If a user signed out using logout() there was no way to sign in as another user as when using calling login() again the same user would be silently logged in again.
Now there's a switch to drop all cookies and force the user to pass his credentials on login() (again).

I found it better to put in if (dropCookies) (and check that first) instead of having it the other way around if (! dropCookies) as imho negations are harder to read. We could, though, iverse this by calling it keepCredentials instead.
If there's another way to force the prompt again please let me know. Maybe any of these changes aren't actually required as I just didn't look deep enough.

Woops, forgot some things. How do I edit that pull request? Let's see ...

Then again I think: "Shouldn't it be rather login()'s concern wether to force a prompt or not?"
Maybe, at the time I call logout() I don't even know if I will want to login the user silently again somewhere in the future or force a prompt. In my case I'll always want the latter but that might look different for others using this library. Or maybe we should have both. What do you think?

Alright, users should now be prompted no matter what.

Thanks @black-snow!


Added SPST switch to schematic viewer

[x] Symbol in tscircuit/schematic-viewer

@seveibar review!!

Wait for checks before merging

Are you able to see the storybook @abhijitxy ? Seems like you need to update or make additions to tscircuit/react-fiber


Suggestion: server middleware watch and restart in dev mode

I suggest to add build.serverWatch option that will watch specified folders and restart nuxt server middleware in dev mode.
Now to rebuild nuxt server middleware you should change nuxt.config.js file.
Now to solve this issue I installed nodemon and changed package.json to
{
  "scripts": {
    "dev": "nodemon --watch api --exec \"nuxt\"",
  },
}

So I suggest to add build.serverWatch option in nuxt.config.js file to watch and restart nuxt server middleware in dev mode.

@clarkdo is right, we cannot watch server-files (except nuxt.config.js) since it means hot-reloading on server-side and this feature does not exist right now (it needs to remove required files in cache for npm, etc).
The best solution is to use nodemon + nuxt like you did in your example :)


Cannot change from php74 to php73

Describe the bug
After initial setup with php74, I then decided to change to php73 and add more extensions
But it still remained in php74 and extensions didnt add
which Branch / PHP Version are you using ?
php74
To Reproduce
1st run docker-compose up -d with the out of the box configuration
then update https://github.com/sprintcube/docker-compose-lamp/blob/master/bin/php73/Dockerfile#L43
to add extra extension as described
  docker-php-ext-install gettext && \     docker-php-ext-install soap && \     docker-php-ext-install bcmath && \     docker-php-ext-install xsl && \     docker-php-ext-install sockets
Also update the .env file
https://github.com/sprintcube/docker-compose-lamp/blob/master/sample.env#L5
to
PHPVERSION=php73
Then run docker-compose build and  docker-compose up -d
Expected behavior
php version suppose to change to 7.3
Desktop (please complete the following information):

OS: Ubuntu
Browser: chrome
Docker Version:

docker -v
docker version 19.03.8, build afacb8b7f0

Hi, @ztobs
you could try to build with docker-compose build --no-cache  but I would guess that you image names are somehow problematic. Did you change some image names ? Looks like docker uses an existing image to start your stack. I've tested this behavior going from php 5 => 7, nut not downwards.
You can try to purge you php images, this should do the trick:
docker rmi docker-compose-lamp_webserver
Otherwise check your docker images and purge all docker-compose-lamp*images.
The docker rmi docker-compose-lamp_webservershould be link to
Please let me know if this works for your.

I rebuilt with no cache and it work. I was try to avoid redownloading the images due to limited internet.


fix(delete-all): fix delete-all command when no option is provided

Small fix to delete all jobs AND views in one shot.
Currently the workaround is to call the command twice, once to delete jobs only, once to delete views only.

Thank you for contributing to openstack-infra/jenkins-job-builder!
openstack-infra/jenkins-job-builder uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.

Submitted change: https://review.openstack.org/505642
Closes story: https://storyboard.openstack.org/#!/story/2001207


[Proposal] Add a case-insensitive flag into string helpers

So it appears to me that right now all string helpers are case-sensitive. Should we add an optional $i flag where applicable to make them a bit more flexible? I imagine it shouldn't be that hard to implement, and would be happy to send a PR over if this proposal is considered sane.

Just created #8572 following this.


Bubble plots for LA NOx predictions

and minor tweaks

I've been adding some random updates to this pull request, but it's ready to merge whenever

Converting to draft for now, until Chris is done with his edits in these sections.


[Change] Add simpler string-only format to mock plugin's schema

Motivation for changes:
Having to type the Dict-structure for every entry is kind of annoying, especially pasting the titles from elsewhere
Detailed changes:

Added a simple string option to the accepted formats for each of the  list's entries and assume it's the title

Addressed issues/feature requests:

None, just indulging my own laziness

Config usage if relevant (new plugin or updated schema):
mock:
        - {title: foobar, url: http://some.com }
        - {title: mock}
+       - MockTitle

Log and/or tests output (preferably both):
VERBOSE  details       test            Produced 3 entries.
VERBOSE  task          test            ACCEPTED: `foobar` by accept_all plugin
VERBOSE  task          test            ACCEPTED: `mock` by accept_all plugin
VERBOSE  task          test            ACCEPTED: `MockTitle` by accept_all plugin

Great idea! This has always been a bit annoying with mock plugin, (because I never care about the url,) but I never even thought to fix it.


Auth crash when checking if user is Email-Verified

When checking if a user is email verified using Firebase auth the app crashes with the following message:
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[FIRUser emailVerified]: unrecognized selector sent to instance 0x600002c16800'
The setup is pretty simple. With a logged in user I execute this piece of code:
Napier.e("About to crash")
Firebase.auth.currentUser?.let {
    Napier.e("Did get current User")
    val mailVerified = it.isEmailVerified
    Napier.e("Unreachable on iOS | mailVerified: $mailVerified")
}

on iOS it leads to a crash; on Android it doesn't. I didn't test any other platforms yet. This crash only came up, after upgrading gitlive firebase auth from version 1.12.0 to 2.1.0

@siarhei-luskanau  is this likely to be caued by https://github.com/GitLiveApp/firebase-kotlin-sdk/pull/592/files and need to be changed to emailVerified()?

@siarhei-luskanau is this likely to be caued by https://github.com/GitLiveApp/firebase-kotlin-sdk/pull/592/files and need to be changed to emailVerified()?

I will have a look

@Tommyten I have tried to reproduce this issue on my project and isEmailVerified works well for me. Please provide more information about issue. I have tested this case there . Anonymous Sign-in provider is used in Firebase web console.

i don't have a reproducible project to share, but i am also getting this error by accessing AuthState.isEmailVerified since i upgraded to 2.1.0. reverting back to 2.0.0 seems to fix the issue.

2.1.0 version has the commit Updated firebase-cocoapods to "11.1.0". I think it is necessary to update the firebase-ios-sdk dependency version to 11.1.0 in iosApp/iosApp.xcodeproj/project.pbxproj file in ios project.
In my case it looks like:
/* Begin XCRemoteSwiftPackageReference section */
		92C05B532C972C51003DFD70 /* XCRemoteSwiftPackageReference "firebase-ios-sdk" */ = {
			isa = XCRemoteSwiftPackageReference;
			repositoryURL = "https://github.com/firebase/firebase-ios-sdk";
			requirement = {
				kind = exactVersion;
				version = 11.1.0;
			};
		};
/* End XCRemoteSwiftPackageReference section */

you are right @siarhei-luskanau! i had to update my pods, it's now fixed :)


Fix for loop TS logic in update/delete messages article

Docs Build status updates of commit fb3b7f2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
:bulb:Suggestion

Details

msteams-platform/bots/how-to/update-and-delete-bot-messages.md

Line 77: [Suggestion] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/bots/bot-conversations/bots-conversations' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 81: [Suggestion] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/bots/bot-conversations/bots-conversations#updating-messages' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 82: [Suggestion] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/bots/bot-conversations/bots-conversations#deleting-messages' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 4cbdc55:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/msteams-docs, working directory: W:\bfii-s, target branch: HEAD, target branch commit: 4bf7ec1b096e8bc43b4bd571c0469f451dce4b78, source commit: 4cbdc55a1d1a076ebbdbbef958ca55d8149c2b39.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 52312de:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Upgrade Apache Commons Collections to v3.2.2

Version 3.2.1 has a CVSS 10.0 vulnerability. That's the worst kind of
vulnerability that exists. By merely existing on the classpath, this
library causes the Java serialization parser for the entire JVM process
to go from being a state machine to a turing machine. A turing machine
with an exec() function!
https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-8103
https://commons.apache.org/proper/commons-collections/security-reports.html
http://foxglovesecurity.com/2015/11/06/what-do-weblogic-websphere-jboss-jenkins-opennms-and-your-application-have-in-common-this-vulnerability

Hi, thanks for this Pull Request but have you try this patch on the project ?
All is working ?
You deploy esup-koha ?
Do you think that esup-koha uses the binary serialization ? If esup-koha uses it,  you're sure that this PR will not break the project ?
If we don't use it, you think that this project is vulnerable anyway  ?
Thanks for your reply.

Hi, sorry but at this time, I can only offer the security patch as is. As for the security concerns, please refer to the links above for more details for researching the problem. Wish I could do more. Cheers!


Truncate instead failing if string is too long in writer

When a symbol name that is longer than 32k is encountered magic-trace stops processing the collected data. This PR truncates the long string instead if failing.
Original error:
[ Decoding, this takes a while... ]
(monitor.ml.Error
 (Failure "string too long for FTF trace: 60872 is over the limit of 32kb")
 ("Raised at Stdlib.failwith in file \"stdlib.ml\", line 29, characters 17-33"
  "Called from Tracing_zero__Writer.set_string_slot in file \"vendor/tracing/zero/writer.ml\", line 158, characters 7-89"
  "Called from Tracing_zero__Writer.intern_string in file \"vendor/tracing/zero/writer.ml\", line 182, characters 2-32"
  "Called from Base__Hashtbl.find_or_add.(fun) in file \"src/hashtbl.ml\", line 427, characters 20-30"
  "Called from Tracing__Trace.Baked_args.bake in file \"vendor/tracing/src/trace.ml\", line 96, characters 27-57"
  "Called from Tracing__Trace.Baked_args.create.(fun) in file \"vendor/tracing/src/trace.ml\", line 110, characters 39-61"
  "Called from Base__List.count_map in file \"src/list.ml\", line 483, characters 13-17"
  "Called from Tracing__Trace.writer_adapter in file \"vendor/tracing/src/trace.ml\", line 171, characters 19-43"
  "Called from Base__List0.iter in file \"src/list0.ml\", line 60, characters 4-7"
  "Called from Magic_trace_lib__Trace_writer.flush in file \"src/trace_writer.ml\", line 447, characters 2-404"
  "Called from Magic_trace_lib__Trace_writer.add_event in file \"src/trace_writer.ml\", line 463, characters 54-82"
  "Called from Magic_trace_lib__Trace_writer.ret in file \"src/trace_writer.ml\", line 680, characters 2-55"
  "Called from Magic_trace_lib__Trace_writer.check_current_symbol in file \"src/trace_writer.ml\", line 696, characters 4-27"
  "Called from Magic_trace_lib__Trace_writer.write_event in file \"src/trace_writer.ml\", line 1170, characters 10-83"
  "Called from Async_kernel__Pipe.iter_without_pushback.(fun).loop in file \"src/pipe.ml\", line 917, characters 10-13"
  "Called from Async_kernel__Job_queue.run_jobs in file \"src/job_queue.ml\", line 180, characters 6-47"
  "Caught by monitor Monitor.protect"))

I have tried this patch on top of latest version and it makes magic-trace a lot more usable :+1:

Thanks for the patch!
I think we shouldn't silently truncate these strings, and leave it up to the caller to truncate (or perhaps reformat) the symbols as appropriate. For reference, see how a different variant of this issue was patched in https://github.com/janestreet/magic-trace/commit/1087cbf4888787a6704200e46dffaa50220bfadc.
The right place to address this, I think, would be around https://github.com/janestreet/magic-trace/blob/d36c159dc7d68ce84f4ef5a6538138961ef723f2/src/trace_writer.ml#L385. See the big comment above that logic.
In fact, I think you could try using String instead of Interned here, if the string is too large to be interned: https://github.com/janestreet/magic-trace/blob/d36c159dc7d68ce84f4ef5a6538138961ef723f2/vendor/tracing/src/trace_intf.ml#L6
It might work!


About overlay network: swarm worker in private subnet connecting swarm manager in public subnet

I have a question which is already claimed in the title of this issue.
Assume we have a swarm manager deployed in a public network, and several swarm workers deployed in a private network (the private network is within a router, so all services in this private network uses NAT to communicate with public services). Apparently, a service in private network can play a role as client to connect to another service in public network but this cannot be feasible conversely.
Considering the situation above, I tested a swarm worker in private network connecting a swarm manager in public network, and I saw the operation can be successfully done, and it seems to work well even if I create a swarm service with many replications, replicated services can be harmonious started in both swarm worker and swarm manager. For example, service test.1.xxxxxx running on swarm manager and service test.2.xxxxxx running on swarm worker.
The only problem is,  test.1.xxxxxx and test.2.xxxxxx cannot communicate with each other over ingress network (a default overlay network tunnel used by inter-machine service comminution), so swarm network features like vip doesn't work as well.
My question is whether this communication problem is just due to a bug, or not a feature as designed. I think this requirement is very useful, since it can organize multi private network infrastructures. Current support of private swarm worker connecting a public swarm manager is already on the half way to realize it.

The ingress network is a special network, and not meant for services to communicate with each other. Services cannot communicate with each other on the "container-container" network, unless they are part of the same custom network. This allows you to separate services, and prevent them from communicating with each other.
The ingress network is only used to route incoming network traffic from published ports between nodes (the "routing mesh")

After the new test, "container-container" network didn't work as well between a public swarm manager node and a private swarm worker node if I create a shared overlay network for them instead of ingress.
Assume a swarm worker in private subnet joined into a swarm manager in public subnet. Then I did the following on swarm manager node:

docker network create --driver overlay --subnet <IP_ADDRESS>/16 test
docker service create --network test --replicas 2 alpine:3.4 sleep 1h

Then one container is booted on swarm manager node and another one is booted on swarm worker node, and they are not ping-able over their overlay interface.

Is it just ping not working, or are you not able to connect at all? Are you trying to ping individual containers, or a service (the VIP / Virtual IP)? Pinging the VIP cross-node may not work.
What version of docker are you running, and what platform are you on? (docker version, docker info); overlay networks on older (< 3.16 IIRC) kernels cannot have an IP-range that overlaps with an underlay network.

@thaJeztah
Docker 1.12.6 running on Ubuntu 16.04 (kernel = 4.4), no IP overlap.
Both ping serviceX.num.taskY and ping container-eth-peer-IP don't work if one container is in private network. And only if two containers are running on a shared subnet, both of above 2 approaches work.

An easy way to reproduce the issue:

Prepare a physical machine with Ubuntu 16.04 installed;
Setup docker.io via apt-get, and run 'docker swarm init', and save the join-token (as worker);
Setup qemu-kvm via apt-get, and create a NAT-mode VM with Ubuntu 16.04 installed;
Inside VM, install docker.io and run 'docker swarm join ... ' to join into the swarm host managed by the outer OS;
From outer OS, run 'docker service create --network my_overlay --replicas 4 alpine sleep 1d'
Both outer OS and VM should start booting part of replicas of this service. Using 'docker exec -it  sh' to log into one of containers, and test ping <other-containers>.
The result is a remote container is not pingable if one container is from outer OS, and the other container is from VM.

Here, VM simulates a private network, and outer OS simulates a public network.

Apart from ping (over icmp), I tried tcp and udp using netcat as well bewteen 2 containers, and they cannot communicate with each other as well. Besides, if I create a web service publishing port 80, it's also unable to forward the network service as well if the web service is running on worker node in a private network.

@ghostplant The case of workers behind private-addr trying to have a seamless container connectivity with other workers or managers behind a NAT'ed public-addr is an interesting case and has a few subtleties to it. To answer your question, not all behind-the-NAT public-addr connectivity is supported and it is as per design.
Container connectivity using overlay networking depends on VXLAN tunnel (for container data-plane) and Gossip control-plane (for routing exchange). These 2 mechanisms work in a totally distributed way between the workers and doesn't rely on managers or any central management layer  handle the control and data-plane (unlike the task scheduling that entirely rely on the swarm manager). Also unlike the initial swarm join (where the worker joins the manager), the distributed network control plane connects between them via UDP and is p2p (2 way connectivity). Hence the ports (4789 and 7946) of these nodes must be exposed for other nodes to connect to. NAT like mechanisms, take control over such port publishing and it requires special routing configurations to poke a hole on a particular exposed port all the way from Public address to the private address. Fortunately, in cases like AWS, they support 1:1 public->private addresses and hence fixes like : https://github.com/docker/libnetwork/pull/1337 will work with proper --advertise-addr and --listen-addr to enable such connectivity across NAT. PTAL : https://github.com/swarmzilla/swarm3k/blob/master/NODE_PREPARATION.md for 1 such deployment used during the swarm3k project.
Once you understand this design, you can configure your routers to have these ports opened up and then configure your swarm init and swarm join using appropriate --advertise-addr and --listen-addr to make it work behind a NAT.

@mavenugo
Thanks, I think this is a way to get some situation supported through it is not an approach of general purpose. I understand it which requires the forwarding access of the router node that works on this public IP. However, if I have the access to this public IP, it also means I can fully control the forwarding and mapping rules between the public address and multi private addresses, which is not a complex case.
The real case needed to solve is for a network service provider who only gives a private IP behind NAT to get access to WAN and you never have the access to changing rules of public IP. This case is far more common, including your devices connecting a mobility network, your laptop from schools/family and so on, and the method your provide cannot solve this kind of common case.

@ghostplant There are definitely very many scenarios that needs fine-tuning. But Docker network provides Plugin APIs using which one can implement plugins to solve such special purpose forwarding scenarios.

I saw weaveworks can support my case of NAT-behide containers as swarm worker which is not portable and thin. Hope to have a better support by built-in swarm engine.

I have the same problem. I spent a week trying to create an overlay network that would work (because if you expose the ssh port for the ingerss network, you can connect to the container on a private subnet). I wish there are more information about this limitation in the documentation or hope to have supporting overlay network in different subnets.

@ghostplant did you find workaround?

@BulatSaif currently using a VPN/weave around docker C/S seems work if you don't care about performance. Another choice is to realize the user-space tunnel in application layer.


Incorrect error message for an invalid transition delay

I kept seeing this error in my project but couldn't figure out where I had an invalid boolean expression. It was only when I looked at where the error was throwing that I realized it was because I had an int value in the delay field.
https://github.com/derkork/godot-statecharts/blob/56a7498fc6dc4423b21f40528c20deef342f67e0/addons/godot_state_charts/transition.gd#L91-L92
Separate but related issue: the error messages would be more useful if they included details like the invalid value and what kind of property it's failing in.
Happy to make the changes myself, just following the rules about making an issue first.

Oh, it happened to me too, when I set the delay field to 0 instead of 0.0!

I had another issue roughly in the same area, so i implemented this together with the fix for the other issue. thanks for reporting it!


BUG: MSD import fix

MSD Is not imported correctly

You have a 3-to-1 commit to lines changed ratio.

Two lessons:

Don’t try before morning coffee.
Don’t leave MBP in the car overnight in this weather…. cold keyboards lead to fat finger typing.

S
On Jan 10, 2015, at 9:39 AM, Thomas A Caswell <notifications<EMAIL_ADDRESS>wrote:
You have a 3-to-1 commit to lines changed ratio.
—
Reply to this email directly or view it on GitHubhttps://github.com/NSLS-II/ophyd/pull/44#issuecomment-69457971.

Fixed in 81b4151. Next time, please try to better approximate the golden ratio (~1.61803398875) of commits per lines changed. Thanks.


symbols with chinese words can't work well,and the search function is case-sensitive

symbols with chinese words can't work well,and the search function is case-sensitive，sometimes I can't remember that。

Hi @pinganjinrongyun Thank you for reaching out.
While coding this I haven't considered characters other than English! But I will soon roll out the support for that same.
About the search, the search is not case sensitive. It might not be giving you desired results because of the other Unicode characters. If you could send me a few symbols names, that would help me debug this.

Thanks for your timely reply. I just tested it, but the problem about case sensitive did not appear again. It should be the mistake I typed before.I'm sorrry about that.
This is a very great plug-in, looking forward to your update.

@pratikjshah the plugin is cool, but symbols with chinese words can't work,can you support the chinese characters, thanks!


consider treating FUID in same way as PHONE

consider treating FUID in same way as PHONE
refs:

https://github.com/covid19cz/bt-tracing-webapp/commit/158ca910883bcdf9b2e37f91536931c73d4168a5

FUID is not PI, by design.

@Kobzol I agree, but still - isn't better to keep the API consistent?

Sure, good point.


Custom 404 Page

How can I set a custom 404 page using the current theme? Is this possible?

totally :+1: nothing special should be needed here - Laravel looks for custom error pages within an errors folder, so you'll want to create errors/404.blade.php to create a custom 404 page.
https://laravel.com/docs/5.8/errors#custom-http-error-pages

Well considering that all of the theme files are hosted in their own folders (themes/ThemeName), and the errors folder must be included in the resources/views folder, that's not really the case. Meaning, if I switch themes, it will still default to the resources/views/errors/404.blade.php file, which does not change when I switch the current theme. I tried creating an errors folder within the theme folder and it still defaults to the resources/views/errors folder rather than the current theme.
I was able to get around this by using @include('errors.404) in the resources/errors/404.blade.php file, but this is more like a hack than anything else.

Hmm, I see what you mean. It does look like Laravel handles resolving these views a little differently than everything else. I'll have to look in to how to override/extend that here.
Re-opening :+1:

Taken care of in v7.1.0 👍


Thank Robert Jördens for the PyPi package

I think the thank you section title might be better as something like acknowledgments or the like, but we can change it when we actually write up the readme.
LGTM.


community-operators strimzi-kafka-operator (0.24.0)

This PR adds Strimzi 0.24.0 to Community Operators. It was tested manually on OCP 4.7.
Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

@J0zi @mvalarh Any idea what this error means? From the logs, I can see this.
error: pathspec 'origin/master' did not match any file(s) known to git

So it seems to me like it is not related to the operator.
Thanks

/test all

Retesting it

Hmm, it seems to fail with the same error :-(

Strimzi appears to have changed their primary branch from master to main. There is no longer a master branch, that would explain the error message.

@msfrucht Hmm, we did that change already in March. Do you know why is it trying to pull the Strimzi master branch? There are some old links in the description (which have redirects). But I guess it is not parsing the description. There is also the repository annotation which does not specify any branch. Can I specify the branch somewhere? Or is this a bug in the Operator Framework?

@scholzj My current suspicion based on the report you linked to is the pod's environment variables. The JOB_SPEC variable seems to setting the default branch to 'master', which is likely triggering some part of the pod's code to pull that branch after doing the git clone even though only branch 0.24 is the only one need.
See "base_ref": "master"
JOB_SPEC={"type":"presubmit","job":"pull-ci-operator-framework-community-operators-master-4.7-deploy-operator-on-openshift","buildid":"1410106911335911424","prowjobid":"6c6166bd-d963-11eb-ac6d-0a580a80056d","refs":{"org":"operator-framework","repo":"community-operators","repo_link":"https://github.com/operator-framework/community-operators","base_ref":"master","base_sha":"4ce54a3037ef15802771a97291432c9074356985","base_link":"https://github.com/operator-framework/community-operators/commit/4ce54a3037ef15802771a97291432c9074356985","pulls":[{"number":4148,"author":"scholzj","sha":"e0a394abd4f96b54a93d59a34fc55d5a164c0709","title":"community-operators strimzi-kafka-operator (0.24.0)","link":"https://github.com/operator-framework/community-operators/pull/4148","commit_link":"https://github.com/operator-framework/community-operators/pull/4148/commits/e0a394abd4f96b54a93d59a34fc55d5a164c0709","author_link":"https://github.com/scholzj"}]},"decoration_config":{"timeout":"4h0m0s","grace_period":"1h0m0s","utility_images":{"clonerefs":"gcr.io/k8s-prow/clonerefs:v20210629-a9e981a56e","initupload":"gcr.io/k8s-prow/initupload:v20210629-a9e981a56e","entrypoint":"gcr.io/k8s-prow/entrypoint:v20210629-a9e981a56e","sidecar":"gcr.io/k8s-prow/sidecar:v20210629-a9e981a56e"},"resources":{"clonerefs":{"limits":{"memory":"3Gi"},"requests":{"cpu":"100m","memory":"500Mi"}},"initupload":{"limits":{"memory":"200Mi"},"requests":{"cpu":"100m","memory":"50Mi"}},"place_entrypoint":{"limits":{"memory":"100Mi"},"requests":{"cpu":"100m","memory":"25Mi"}},"sidecar":{"limits":{"memory":"2Gi"},"requests":{"cpu":"100m","memory":"250Mi"}}},"gcs_configuration":{"bucket":"origin-ci-test","path_strategy":"single","default_org":"openshift","default_repo":"origin","mediaTypes":{"log":"text/plain"}},"gcs_credentials_secret":"gce-sa-credentials-gcs-publisher","skip_cloning":true,"censor_secrets":true}}
SIDECAR_OPTIONS={"gcs_options":{"items":["/logs/artifacts"],"bucket":"origin-ci-test","path_strategy":"single","default_org":"openshift","default_repo":"origin","mediaTypes":{"log":"text/plain"},"gcs_credentials_file":"/secrets/gcs/service-account.json","dry_run":false},"entries":[{"args":["ci-operator","--gcs-upload-secret=/secrets/gcs/service-account.json","--image-import-pull-secret=/etc/pull-secret/.dockerconfigjson","--lease-server-credentials-file=/etc/boskos/credentials","--report-credentials-file=/etc/report/credentials","--secret-dir=/secrets/ci-pull-credentials","--secret-dir=/usr/local/deploy-operator-on-openshift-cluster-profile","--target=deploy-operator-on-openshift","--variant=4.7"],"container_name":"test","process_log":"/logs/process-log.txt","marker_file":"/logs/marker-file.txt","metadata_file":"/logs/artifacts/metadata.json"}],"censoring_options":{"secret_directories":["/etc/boskos","/secrets/ci-pull-credentials","/etc/pull-secret","/etc/report"]}}

/test 4.7-deploy-operator-on-openshift

/merge possible

So, I figured out the problem after spending some time and digging through the CI code. It looks like I somehow by mistake pushed the commit which was in the PR into my fork twice. Once into the branch the PR is opened from and once into the master branch (in my fork). And it seems that https://github.com/operator-framework/community-operators/blob/2313f16f73e22ee38e5648885975cd76818af189/scripts/ci/openshift-deploy-core.sh#L81 is searching for the commit by sha checksum and gets reference to two branches instead of one. And that was causing the error.


add french

Pull Request Test Coverage Report for Build 326

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.217%

Totals

Change from base Build 324:
0.0%

Covered Lines:
115

Relevant Lines:
161

💛  - Coveralls


Can't install latest version 1.1.8

Apache version 2.4.52
PHP version 8.1.2
MySQL version 8.0.28
Getting this error below on step 4 of installation.
Fatal error: Uncaught mysqli_sql_exception: Table 'elkarte.elkarte_settings' doesn't exist in C:\laragon\www\elkarte\sources\database\Db-mysql.class.php:261 Stack trace: #0 C:\laragon\www\elkarte\sources\database\Db-mysql.class.php(261): mysqli_query(Object(mysqli), '\n\t\t\tSELECT \n\t\t\t...') #1 C:\laragon\www\elkarte\install\Install_Controller.php(745): Database_MySQL->query('', '\n\t\t\tSELECT \n\t\t\t...', Array) #2 C:\laragon\www\elkarte\install\Install_Controller.php(55): Install_Controller->action_databasePopulation() #3 C:\laragon\www\elkarte\install\install.php(44): Install_Controller->dispatch(5) #4 {main} thrown in C:\laragon\www\elkarte\sources\database\Db-mysql.class.php on line 261

Thank you for the report and details.
This issue is most likely due to you running PHP 8.1.x which changed the way MySQLi generates errors.  Prior to 8.1 it would simply return false and perhaps generate  a warning.  Now it throws the exception you see.  Although the "error" is expected (in this case) but the way to handle it has changed.
Your first option is to use php 8.0.x as that is supported on that branch.  If that is not possible you will need to make a one line edit to the code to enable the pre 8.1 behavior for MySQLi, but do not there could be other issues with ElkArte 1.1.8 and PHP 8.1

Fixed here: https://github.com/elkarte/Elkarte/pull/3646/commits/a59cdedaa36ab4fe1b4ad6a0fba6fae0316a7913


Fixes #132

Changes

Fixes #132
Added border, border-radius and shadows to modal
Set the body of the page to clrS (the secondary color is intended to be the background color)
Changed a few color settings in the modals (this makes them pure clrP)

This looks good, merge is waiting for the patch to the addresses. https://github.com/OpenBazaar/openbazaar-desktop/pull/150


[niconico] fixed bug for nm URLs when logged in

You couldn't download nm URL videos when you authenticated (you were able to when not authenticated)
I changed the download URL a bit; It shouldn't affect other than nm URLs.
for test

sm URLs
http://www.nicovideo.jp/watch/sm25798024

nm URLs
http://www.nicovideo.jp/watch/nm14296458

Thanks.


Fix pydantic to ~1.0 in reqs.

Set pydantic to 1.0. Alternative with 2.0 is in #42.

Superseded by #42


ngf-keep="distinct" removes all files from the model before adding new files - is this how it should work?

If I have
 <button type="button" ngf-select ng-model="uploadFiles" name="uploadFiles"
                          ngf-multiple="true"
                          ngf-keep="distinct"
                          >Add files</button>

my intuitive expectation would be that each time I click the button and select files, the new files should be added to $scope.uploadFiles and the old ones should still remain in the model. Only if I select the same file twice, it will be ignored in the model. But currently, each time I click the button my  $scope.uploadFiles gets completely cleared out.
If I set ngf-keep="true" then  $scope.uploadFiles is not cleared out, but then, obviously, duplicate files are not filtered either.
Is there any way to make distinct work similar to true and ignore only duplicate files without clearing out all the other ones from $scope.uploadFiles  ?

You are probably using an old version of the plugin.

Yes, I had 9.0.8 before. Today I updated to 9.0.9. But still the issue is present.
I'm using Chrome.
As it was hard to debug the problem because for unknown reason the file selection dialog does not  appear after breakpoint, I modified the code a bit:
  function handleKeep(files, prevFiles, attr, scope) {
    console.log(files, prevFiles);

and now I clearly see that when selecting files, handleKeep is being called twice - one time before file selection dialog appears, and then later one more time. During the first call files is null. But during the second call (right after file selection dialog has been closed), files holds the newly selected files, but prevFiles is empty array - because it got cleared during the first handleKeep call.
I guess, the root cause of the issue is the fact that handleKeep is being called twice, and the first call is really unexpected because it happens before selecting any files, thus causing model reset and losing prevFiles.

I am seeing the same issue also on 9.0.9 and I am using IE 11.  I have traced it to the function upload.attrGetter called on line 412 returning undefined rather than 'distinct':
var keep = upload.attrGetter('ngfKeep', attr, scope);
If the value of the variable keep is changed to 'distinct' with a debugger after the function returns, the rest of the code runs as expected and the file array maintains its values.

It should be ngf-keep="'distinct'" note the quotation.

Updated the docs to show the quotations.


[Question/Feedback]: Is deployment via terraform planned?

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Description
After following the Enterprise Scale terraform deployment, the next step is to implement baseline alerts, however this doesn't have Terraform support.  I was wondering if this was planned?

Hi @laingsc, thanks for you feedback.
Yes, Terraform and also Bicep support is on the roadmap. While I can't provide specific details at the moment, development is underway. I will provide additional details in the coming weeks.

Cheers @steph409 best of luck!


Checking details for repo without remote host fails.

 {
  "id": "c28ebcec",
  "repoName": "Testing",
  "repoPath": "C:\\Users\\SVNPC\\Desktop\\js\\vanilla_js\\testing",
  "timestamp": "2020-11-16 13:58:53.0060524 +0530 IST m=+11849.732890401"
 }
]
2020/11/16 14:01:22 INFO: Collecting repo status information
2020/11/16 14:01:22 INFO: Collecting repo status information
2020/11/16 14:01:22 INFO: Available remotes in repo :
[0xc0003964c0]
2020/11/16 14:01:22 INFO: Available remotes in repo :
[0xc000065af0]
2020/11/16 14:01:22 INFO: Collecting repo status information
2020/11/16 14:01:22 INFO: Collecting repo status information
2020/11/16 14:01:22 INFO: Available remotes in repo :
[0xc0002d8560]
2020/11/16 14:01:22 INFO: Available remotes in repo :
[]
panic: runtime error: index out of range [0] with length 0

goroutine 37 [running]:
github.com/neel1996/gitconvex-server/git.RemoteData(0xc000109f50, 0xc00012c120)
        C:/Users/SVNPC/Desktop/js/gitconvex/git/git_remote_data.go:49 +0x1dc
created by github.com/neel1996/gitconvex-server/api.RepoStatus
        C:/Users/SVNPC/Desktop/js/gitconvex/api/repo_status.go:29 +0x255

@Nageswari-droid Fix has been pushed to the repo. Retest and confirm

 {
  "id": "c9562e82",
  "repoName": "test",
  "repoPath": "C:\\Users\\SVNPC\\Desktop\\js\\vanilla_js\\testing",
  "timestamp": "2020-11-17 00:14:41.153507 +0530 IST m=+96.079532101"
 }
]
2020/11/17 00:14:44 INFO: Available remotes in repo :
[0xc0002e63a0]
2020/11/17 00:14:44 INFO: Available remotes in repo :
[0xc000184240]
2020/11/17 00:14:44 INFO: Available Branch : heads/development
2020/11/17 00:14:44 INFO: Available Branch : heads/main
2020/11/17 00:14:44 INFO: Available Branch : remotes/github/main
2020/11/17 00:14:44 INFO: Available Branch : heads/master
2020/11/17 00:14:44 INFO: Available Branch : remotes/github/master
2020/11/17 00:14:44 INFO: Available Branch : remotes/github/under-development
2020/11/17 00:14:44 INFO: Total commits in the repo -> 2
2020/11/17 00:14:44 INFO: Total Tracked Files : 6
2020/11/17 00:14:44 INFO: Total commits in the repo -> 89
2020/11/17 00:14:44 INFO: Total Tracked Files : 63
2020/11/17 00:14:44 INFO: Collecting repo status information
2020/11/17 00:14:44 INFO: Available remotes in repo :
[]
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x8 pc=0x936582]

goroutine 120 [running]:
github.com/go-git/go-git/v5/plumbing.(*Reference).Name(...)
        C:/Users/SVNPC/go/pkg/mod/github.com/go-git/go-git/v5@v5.2.0/plumbing/reference.go:178
github.com/neel1996/gitconvex-server/git.GetBranchList(0xc000178570, 0xc000196120)
        C:/Users/SVNPC/Desktop/js/gitconvex/git/git_branch_list.go:32 +0x1c2
created by github.com/neel1996/gitconvex-server/api.RepoStatus
        C:/Users/SVNPC/Desktop/js/gitconvex/api/repo_status.go:59 +0x5c5

@Nageswari-droid Fix pushed. Please check now.

fixed in https://github.com/neel1996/gitconvex/commit/6042a9a4ce15daf81abeef7a5ffa7a7fc99abdba


feat(API): Release V1 of pypi package

Depends on:
Release Generated Data
DOD:

The pypi package is updated
The pypi package can be installed
The latest release of the data is present
Write Integration tests.
Automated via GHA and runs after a pypi release.

complete https://github.com/chanzuckerberg/cellxgene-ontology-guide/pull/137


Create a "latest" link for pipelines

GitHub has support for the "latest" release
For example: https://github.com/nf-core/methylseq/releases/latest
Redirects to 2.5.0(At the time of writing this)
I'd like to be able to do https://nf-co.re/methylseq/latest. I think https://nf-co.re/methylseq does this however.
But I'd like to be able to point to https://nf-co.re/methylseq/latest/docs/output.
So I don't forget to update it in multiqc_config.yml on release 🙃

Wait maybe that already works 🤔

Yep, this is already there


Dispose overlay entries

As OverlayEntry implements a Listenable that is e.g. subscribed to by the Navigator, it should be disposed when no longer used. This PR adds the missing dispose() calls in all the places I could find they were missing.
Test-exempt: adding missing dispose() methods without other functional changes
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

Would this unblock removing the leak tracking config overrides on some testWidgetsWithLeakTracking() usages?
This PR does not modify any tests, hence why I'm asking.

@polina-c Is there a way to test these changes using your leak tracking tests?  Or should it be test exempt?

OverlayEntry is not instrumented to be tracked for leaks yet. So, not yet. Added it to list of classes to instrument.

test-exempt: will be tracked
is there a bug# to follow that work?


API selection

Which two API, will be used for this project ??

API 1
API 2
How the API will be used.

Two API with reasonably close properties

Movie API

https://www.themoviedb.org/documentation/api
############################

Flights

https://airlabs.co/a
https://aviationstack.com/

Initially discussed and chosen APIs approved

Aviation-Data (name)
Movies-APIs


Ability to message the bot privately

Currently, the bot is only triggered by mentioning vacation/ooo/etc. elsewhere.
Users should be able to message the bot directly.
Any message sent to the bot should be replied with:
"Hey there!
YES--> start the questions
NO --> "OK, maybe next time :slightly_smiling_face"

@ryanchartrand has reported that some users try to message VB to start vacation process:
I messaged the Bot directly this:username [9:58 AM]  I'll be Out of Office on July 4th, 2017
username [10:46 AM]  I'll be Out of Office on July 4th, 2017

It would be great to provide this functionality as well to meet users needs


[WIP] Do not try to enable AppArmor in rootless mode

When in rootless mode it's not possible to load profiles or check which profiles are loaded.
I am proposing this change is to avoid users having to specify --security-opt apparmor=unconfined every time they are running rootless.
If this is something that makes sense I'll also add some tests.
Actually a better way would be to get the parent process effective capabilities to see whether CAP_MAC_ADMIN is set. CAP_MAC_ADMIN allows controlling AppArmor without root permissions.
However I am not sure how to do it given that at the check time we are root in the user namespace and calling capget will give full effective capabilities.
Something like:
-       aaControllable := !rootless.IsRootless()
+       aaControllable := true
+
+       if rootless.IsRootless() {
+               myCaps, err := capability.NewPid2(0)
+               if err != nil {
+                       return fmt.Errorf("Error getting current process capabilities")
+               }
+               err = myCaps.Load()
+               err != nil {
+                       return fmt.Errorf("Error getting current process capabilities")
+               }
+               aaControllable = myCaps.Get(capability.EFFECTIVE, capability.CAP_MAC_ADMIN)
+       }

@vrothberg PTAL

The proposed changes make the code really complex. I think it's sufficient to add another check here https://github.com/projectatomic/libpod/blob/master/cmd/podman/create.go#L235 and here https://github.com/projectatomic/libpod/blob/master/cmd/podman/create.go#L199.
But I think it's timeo put the AppArmor loading into a speparate function func loadAAProfile(profile string) error (for instance) which would allow us to do a simple return nil instead of increasingly complex branches. For the rootless case, I suggest to log that Podman is not loading the AppArmor profile because of the above mentioned reasons.

@giuseppe PTAL

Yes I agree that having a function is probably the cleanest way to do it. I'll do a rewrite.

I agree with @vrothberg, it is better if you could refactor it in a function.
If it is something useful to have, we could add the check for the effective capabilities before doing the re-exec and store that result into an env variable.
If the re-exec code will grow to be too complex we might need to use some other data format instead of env variables, but it is not something for this PR.

@marcov I added the WIP to make sure no one accidently merges it,  Remove it when you are ready to have the PR reviewed.

@giuseppe thanks for the hint.
I realized we need to check ambient capabilities (permitted & inheritable) instead of effective.
Also it would be best to store the full capability bitmask in the environment variable, but the only way I found to extract the full 64-bit mask is via procfs. So I thought about using psgo for this.

is it something we could do using directly prctl on the current thread instead of going through /proc?

is it something we could do using directly prctl on the current thread instead of going through /proc?

I think that's possible. There's already quite some logic in psgo/internal/capabilities. We could sacrifice this package and make it public by moving it to psgo/pkg/capabilities and add a new API to do that. @marcov, what do you think?

@vrothberg: I like your idea, but consider there's already a gocapability package to operate on capabilities (even though this does not give access to the full capability bitmasks)
@giuseppe: prctl can only read one capabilty bit per call. I thought that reading the full-mask would be more future proof if we need to get other bits in future.

bot, add author to whitelist

@marcov Then I suggest going with your initial proposal of extending psgo with the required API and go from there.

bot, add author to whitelist

yes extending psgo is a good idea, but in our case don't we know exactly what capabilities are needed?

prctl is enough for now but we'll need to call it n times if in future we have to check for n capabilities. That's why I proposed reading the full capabilities once only with psgo. Anyway I am fine in both ways.

I actually need to correct myself regarding what is possible to do with AppArmor as non-root user.
The pkg apparmor uses apparmor_parser as a frontend to AppArmor, and that requires root privileges.
I am sorry for having provided you wrong information.
So for now I'll avoid checking capabilities and just do the refactoring of AppArmor code into a function as per your suggestion.
PS: some more details after checking in the AppArmor kernel code (these are my conclusions and may still be imprecise):

reading /sys/kernel/security/apparmor/profiles  requires to be root user (see policy_view_capable() in policy.c).
administering AppArmor requires to be root user and CAP_MAC_ADMIN (see policy_admin_capable() in policy.c).

changes LGTM, but would like head nods form @vrothberg and @giuseppe

bot, retest this please

Note to self, add a little comment in the test for the whale says positioning.

@rh-atomic-bot r+


Experiment with forcing Kerchunk to keep coordinate variables inline (i.e. in the Kerchunk file)

kerchunk.utils.inline_array is the function for this - include the arrays you want in names=[...].
NOTE: the docstring appears a little truncated and might not make sense.
We might have to create our own sub-class of kerchunk.hdf.SingleHdf5ToZarr and then modify the behaviour of one of the methods to incorporate the appropriate use of inline_array(...).

Kerchunk-tools now includes a setting 'b64vars', used like:
-b lat,lon (or) --b64vars lat,lon
Where the listed variables are always stored inline (and only stored once if identical across files)
See dwest77-generators branch. Could write these changes to a separate branch as a single feature to pull into the main version quickly, or keep with the generators.

Kerchunk-builder includes identical_dims checker which detects where lat/lon are identical


feat: only run greeter on opened or reopened PRs

Save resources and prevent duplication by running the PR greeter only on opened or reopened.

Thanks for the PR!
Any successful deployments (not always required) will be available below.
API available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

At @mishraomp's request we're now looking into this addition as a param in the action.  It would be far easier to share with action users.


Add Support for Operating Modes and Metadata Collection via the Kubernetes API

Is this a bug fix or adding new feature?
New feature/QOL improvement.
What is this PR about? / Why do we need it?
This PR does two things:

Adds support for metadata collection via the Kubernetes API. This will be used as a backup plan if the EC2 metadata collection fails (e.g. IMDS is disabled on the cluster).
Adds support for different operating modes. This allows the CSI controller pods to deploy just the controller service and the CSI node pods to deploy just the node service. This generally makes the csi driver more modular and is considered a Kubernetes best practice.

This PR also removes hostNetwork: true from the node daemonset configuration. This configuration is no longer necessary. Removing it improves our security posture: https://www.elastic.co/guide/en/security/current/kubernetes-pod-created-with-hostnetwork.html
What testing is done?
make test and make test-sanity
Deployed the driver to two clusters: a regular cluster and one with IMDS calls disabled.
Confirmed metadata collection was successful and confirmed dynamic provisioning/mounting functionality was kept intact for both clusters.

/approve
/lgtm
great work!


kontena cli with shell plugin breaks "kontena stack upgrade"

I tried to update an installed stack and got this:
deployment (develop *=)$ kontena stack upgrade staging kontena.yml
 [done] Reading stack staging metadata from Kontena Master
> Enter or paste a stack YAML
 [error] NoMethodError : undefined method `[]' for false:FalseClass
         Rerun the command with environment DEBUG=true set to get the full exception

Deinstalling the shell plugin fixed it

The only way I can reproduce this is by leaving the filename out.
$ kontena stack upgrade redis redis.yml

Works as expected.
$ kontena stack upgrade redis
> Enter or paste a stack YAML
(ctrl-d)
 [error] NoMethodError : undefined method `[]' for false:FalseClass

It should look for kontena.yml but the shell plugin seems to break that.

I don't understand why the shell plugin is hooking Kontena::Cli::Stacks::YAML::Reader.new('kontena.yml') and thus changing the behavior of the kontena stack commands when not using the shell, but it looks like #15 should fix the kontena-plugin-shell to not do that.
The NoMethodError : undefined method []' for false:FalseClass` seems to be a common lack-of-validation issue for the case of an empty YAML file:  #2204


Replaces saveHTML with saveXML for php versions preceding 5.3.6

Fixes issue #44
The issue here is that when using $DOMDocument->saveHTML($Node) the node paramerter in saveHTML was added in 5.3.6 therefore breaking previous versions.
Since only working with subsets of the document you can achieve the same effect by using saveXML and passing in the Node parameter.

I believe that previous versions used to use saveXML instead of saveHTML, and I don't remember what they were, but there were issues with this.

The pros might outway the cons at this time at least for me. I can't seem to include any HTML in my Markdown files or the HTML content will not render. I have no control over the server to update the PHP version so I will use my branch for now, but I'm sure others will run into similar issues.  I'd be curious to know what the issues were if you can remember, so I can be on the lookout.

Made another commit on this that fixes issue #44
# remove
$doc->replaceChild($doc->firstChild->firstChild->firstChild, $doc->firstChild);

The above code works only if the  has only one child node. When two HTML tags are smushed together, multiple support is needed.
I expanded on the processTag function by creating a parent function called processTags which handles multiple instances. Might want to run some test making sure the fix works in all cases and doesn't negatively affect speed.

One last comment on this, sorry about the chatter. I think I have most the kinks worked out on this fix, hope it helps saves you guys some time.
I do want to point out a couple of things:
It seems like the main issue is that classes cannot be assigned to elements that have nested markdown, even with the Markdown="1" set.  What goes wrong? Well, first it strips the inner text of the classed element and then builds that text inside a serpate element.
However, it seems like the issue lies in the Parsedown library not ParsedownExtra library. I'd even go as far as to say that once you figure out that issue the Markdown="1" will be obsolete. You could just call  $elementText = "\n".$this->text($elementText)."\n"; from the ParsedownExrta library every time you needed to process text (any element that is not an instance of DOMElement and not inside the textLevelElements array ).
Also,  please add a label tag to the Parsedown textLevelElements array.

@acmitch Thanks for the feedback. I'll review as soon as I have some time.


[Feature]: Make pod liveness/readiness probes timeout configurable

Is there an existing issue already for this feature request/idea?

[X] I have searched for an existing issue, and could not find anything. I believe this is a new feature request to be evaluated.

What problem is this feature going to solve? Why should it be added?
Current databaze pods have 5 seconds timeout to liveness/readiness probes and this timeout is hardcoded in pkg/specs/pods.go. It would be nice, if this could be configurable. In our setup, we need timeout about 20 seconds, it seems that DNS is involved in the probe and if DNS reply is lost, the Pod is restarted. With increased timeout, all is running just fine. I understand, it should not be default, but configurable.
Describe the solution you'd like
Add new field to cluster spec so that Pod probes timeout can be changed.
Describe alternatives you've considered
I do not know about alternative as the timeout is currently hardcoded.
Additional context
No response
Backport?
No
Are you willing to actively contribute to this feature?
Yes
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Did you look at this for the liveness one? commit:5f8e86d91b61503775a243caf577212d0696e725

Did you look at this for the liveness one? commit 5f8e86d

thanks, does it mean, that these values are futher altered?
https://github.com/cloudnative-pg/cloudnative-pg/blob/631bb20c500a64564773db0f98fc66704c6d0f54/pkg/specs/pods.go#L187
because, in the function here, both timeouts are hardcoded:
https://github.com/cloudnative-pg/cloudnative-pg/blob/631bb20c500a64564773db0f98fc66704c6d0f54/pkg/specs/pods.go#L208
and
https://github.com/cloudnative-pg/cloudnative-pg/blob/631bb20c500a64564773db0f98fc66704c6d0f54/pkg/specs/pods.go#L219

and moreover, I think that both probes are executed - liveness and readiness, so the abovemention patch should alter both timeouts.

@xhejtman  for reference, this commit was for this issue 4642 raised here

Please add the configurations for pod specs! The livenessProbeTimeout setting that was recently added does not change the timeout, it only adjusts the failureThreshold which is calculated from the timeout setting which is never actually changed. All these settings be configured for both readiness & liveness probes.

Created a PR for this as I have an instance of this running the cloudnative-pgvecto.rs image that seems to getting killed while PG is starting up.

I think we should look at all the available options and make a solid decision about how we want to expose the fine tuning of probes. See: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#configure-probes


[WTH Core] - Automatic generation of Student/Release ZIP file on each push to the master branch

This includes a new action to create a GitHub Release for each hack that is modified and pushed to the master branch. It excludes directories that are not hacks (such as 000-HowToHack, .github, etc).

updated to only generate a new ZIP file if the Student/Resources directory in a given hack is changed


Update the Longhorn images to latest version

Keep the images in /deploy/longhorn-images.txt to be up to date

Thanks, @meldafrawi to point out this:+1:


[#162] Add the ability to optionally configure imagePullSecrets to be…

… used when using a private repo.

@brusdev thank you for the approval!

@naude-r thanks for your contribution, it will be included in v1.0.12


Update missing value alert

Closes [Airseeker Telemetry]: Swap out/remove error message Nodary reference#500

There are lots of place still Nodary naming populated here some examples:

https://github.com/api3dao/airseeker/blob/8267a3c95e964d2763f9ab7adea800129dbc6d6d/src/alerting.ts#L125
https://github.com/api3dao/airseeker/blob/8267a3c95e964d2763f9ab7adea800129dbc6d6d/src/alerting.ts#L350
https://github.com/api3dao/airseeker/blob/8267a3c95e964d2763f9ab7adea800129dbc6d6d/src/alerting.ts#L377

Also in my opinion variables named as *nodary* that refers reference data should be changed. I don't think variable name changed is urgent but the alerts are.

I see thanks, I will go through the rest of the alerts as well then 😄

Looks fine 😆 but related to Bedirhan's comment it's probably safe to do a project-wide replace of nodary with maybe "source" 🤷 ?

We could almost do this, there are a few db column names still containing nodary, but that should be ok.

I'll try and deploy this and see what happens, can always revert.

No errors and/or issues, so this is running nicely.


Add BrowserWindow.isDevToolsFocused and fix "devtools-focused" not working

Close #981.

The OS X test failed because of lack of 10.10 SDK on CI machine, ignoring it for now.


Add continuous integration build that uses Bazel

I've started working on this. I think the best example would use cargo raze to install cxx itself (using a path to the root of the repo), and build a small crate that uses cxx and a small rust dependency (like num_cpus).  I think you may also need to add a dep from the cxx crate rust_library target on the cxx_cc_library target. I am open to accepting whatever metadata needs to go in our Cargo.toml to get cargo-raze to make sense of that dependency edge.

In my code, I'm only doing C++ to Rust, where you need to create a wrapper cc_library anyway, in Bazel. I just put the generated library there.
https://github.com/bazelbuild/rules_rust/tree/master/examples/ffi
I'll do a Rust to C++ example as well, though.


Add mastodon icon?

Hi and thank you for this work, it's nice!
I think in social icons, a mastodon icon should be added as it's more and more used!
Have a nice day!

@AmarOk1412 I just PR to add support. It's on my website you can check the result at https://r4ven.fr/ and add theses modification if you don't want to wait the merge of PR :+1:

aha I was thinking to do it for https://cha-cu.it, so now I don't need to do it!


Cannot confirm anything on Windows 11

Prerequisites

[X] Verify that this is not a Windows issue;
[X] Refer to the system requirements;
[X] Refer to the How to use;
[X] I do not use a homebrew Windows image;
[X] I did not tweak Windows before that could cause system instability;
[X] If your issue concerns the Wrapper, please mention @BenchTweakGaming in issue

Steps to reproduce
For PowerShell 5 or 7

Download the script
Customize anything you want
Execute the script

PS: I've removed the "warning" from the InitialActions comand, but it is still not possible to confirm the following prompts.
Windows Version
Windows 11 22H2 22621.1992
Sophia Script version
6.5.3

Any screenshot? Any please share your preset.
Did you use arrows on your keyboard?

I cannot help without screenshot...

Sorry, I could not answer previously, I tested yesterday again and saw that now works with the arrow keys, but it was still bad, I will not show a screenshot because it was on another computer that is no longer with me and you have already updated the package.
Imagine the following, any key you pressed, he rewrote the question on the screen, then would have the same question several times in the prompt, one below the other, after using the arrow keys the same happened, but he selected something, which exactly was not possible to know.

Good to hear. 🐱 Probably, I will add a notification that you need to you arrows))


[FEATURE] MViTv2: Improved Multiscale Vision Transformers for Classification and Detection

Describe the solution you'd like
Add https://github.com/facebookresearch/mvit from MViTv2: Improved Multiscale Vision Transformers for Classification and Detection to timm

@benihime91 merged


Is AGLint supposed to throw an error for forbidden class names?

I have this scss file alongside a react component file with the following class name:
.ad {
  color: red;
}

const MyComponent = () => (
    <div className='ad'>
      hello world
    </div>
);

running AGLint on it, yet no problems found:
npx aglint ./my-file.scss
npx aglint ./my-component.jsx

common adblockers will block this element from the browser, by applying a display: none css property to it.
My question is as follows:
Is AGLint supposed to throw an error for those kind of problems? Or did I completely miss the point of the linter?

Hi @royhadad, ONLY adblock filter lists can be linted with AGLint (like this), CSS / JSX files are NOT supported by AGLint. I can recommend Stylelint or ESLint for that.

Hi @royhadad, ONLY adblock filter lists can be linted with AGLint (like this), CSS / JSX files are NOT supported by AGLint. I can recommend Stylelint or ESLint for that.

Thanks for the reply, are you aware by any chance of any Stylelint or ESLint plugin that does this?

I'm not sure I fully understand what exactly you want, could you please elaborate it a little more?

@scripthunter7 Yeah, sure.
I had this bug in my website, where certain elements had a classname "advertiser", in production my adblock plugin blocked those elements from appearing.
What I'm lookin for is some sort of linter to scan my codebase for these kind of class names.

You probably need to configure a Stylelint rule (e.g. this one) to exclude some class patterns

found it! Very niche, only a few github stars
https://github.com/wuhonglei/stylelint-config-adblock


centered loading spinner

Fixes Issue
#21
This PR fixes the following issues:
#example

Changes proposed
Here comes all the changes proposed through this PR

Check List (Check all the boxes which are applicable)

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots and video

Add all the screenshots and a video which support your changes

can you show the screenshot of login / signup page to confirm that this spinner is also aligned at center on that page also

Fix it bro

resolved #21
centered in signin page

bro bhohot sahi lag rha hai spinner good job 👍👍


Remove tf.floor endpoint from TF 2.0

This fix tries to address the issue raised in #27003 where ceil is only exposed as tf.math.ceil for TF 2.0 while floor is exposed in both tf.floor and tf.math.floor for TF 2.0.
It makes sense to keep consistency for ceil and floor. This PR deprecates tf.floor and exposes only tf.math.floor in TF 2.0.
This fix fixes #27003.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

@yongtang can you please resolve merge conflicts.

TF2 API frozen, so we can't remove it anymore.


Lua support

Check for existing issues

[X] Completed

Language
Lua
Tree Sitter parser link
https://github.com/Azganoth/tree-sitter-lua
Language server link
https://github.com/sumneko/lua-language-server
Misc notes
Would be useful to include, a lot of things have config files and extensions written in Lua.

Tree Sitter Link: https://github.com/Azganoth/tree-sitter-lua

Just received my Playdate in the mail and now I'm not stoked to use VS Code.  Another vote for Lua here! 😅

I want to put in here that I would also love lua support! I use it for scripting several of my programming projects, and being able to do it in zed instead of VSC would be great :)

Lua support is merged into main and will be released in the next version or two

@JosephTLyons another Playdate developer here! have you managed to get autocompletition/hints to pick up the Playdate function definitions? Maybe using https://github.com/notpeter/playdate-luacats or https://github.com/notpeter/playdate-docdef


Feature: make all should handle file generation

Is your feature request related to a problem? Please describe.
Proto pb generation and checks/README.md generation happens manually today.
Describe the solution you'd like
We should update Makefile to handle this when we run make all.

Took care of the doc generation #455


Generate Code with most recent CPACS 3 schema

@joergbrech Could you please prune all  cpacs nodes that are irrelavant for us now? These are dead code right now, which is not helpful for code coverage.
To do so, just add the relevant root nodes to PruneLists.txt inside the cpacs_gen_input directory.


exoscale: update egoscale binding for 32-bit compatibility

egoscale is updated to use int64 where it makes sense.
Closes #1212.
Signed-off-by: Vincent Bernat<EMAIL_ADDRESS>

LGTM

@vincentbernat :+1:


Escape meta characters of LaTeX in "judgeOffset" to avoid the compilation failure

I found that PDF compilation via LaTeX halts when judgeMax, the character/word used for the grammaticality/acceptability judgement whose number of characters are the largest in the ex environment, contains one of the LaTeX's meta-characters such as #, % or &. So, the following two markdown examples are not properly processed in the compilation procedure and throw an error: ! Illegal parameter number in definition of \@jwidth.
::: {.ex #grammaticality-judgement}
^# I'm not sure this is grammatical.
:::

or
::: {.ex #grammaticality-judgement}
a. ^# I'm not sure this is grammatical.
a. This is grammatical.
:::

I suspect that the line in texMakeGb4e function and the line in texMakeLangsci function render the characters like #, % or & to LaTeX as they are (i.e. without escaping them) and that this causes the above-mentioned error.
Those lines can be replaced with the following lua command (I verified this works in my environment):
local judgeOffset = "\\judgewidth{"..string.gsub(pandoc.utils.stringify(judgeMax), "([#$%&_{}~^])", "\\%1").."}"

Would you mind considering and verifying this patch?
Environment
pandoc-ling: the latest version as of 2021/02/24
pandoc: v2.11.4
OS: Windows 10 x64 (build 19042)

Good catch! The error does not occur with linguex, so that might help until I have managed to fix this.

I fixed it using your proposal, thx @CLRafaelR!

Yes, the problem occurred with (langsci-)gb4e and I had to mentioned that more implicitly... Thank you for the adaptation of the patch!

I also added a new "lazy" example-coding possibility, in which you can make subentries (with letters) by just typing dashed (markdown lists). It will insert the letters anyway :-)


Stock quote on a specific date

I am a newbie to Alpha_vantage. I'm just wondering how to get the closing price of a stock at a specific date (say, 2019-08-26)? I don't need a long list.

This is one way to get data as a pandas dataframe. There are a few other ways by changing the "output_format" to either csv or json. Please see the README.md for more info
from alpha_vantage.timeseries import TimeSeries

# Your key here
key = 'XXXXXXXXX'
ts = TimeSeries(key, output_format='pandas')
aapl_data, meta_data = ts.get_daily(symbol='GOOGL')
aapl_data.loc['2019-08-26']


Example for how to print word definitions

I'm starting a small project where I print the definitions of words (via the Token object) with Lindera.
I'm also wondering, how can I generate furigana with this? I think this would be useful in the examples area in the docs!

nvm, i realized a few things after looking at https://github.com/encody/autoruby


"Change your avatar" tooltip/link on any user page

Visiting any user profile and hovering on any profile will show a tooltip to change avatar on gravatar.com.

On an unrelated note, it would be a good idea to add width/height attributes to avatar so that content doesn't jump while image is being loaded. It also seems that gogs resizes images to 200px, but user profile displays avatar in 234px.

It also seems that gogs resizes images to 200px, but user profile displays avatar in 234px.

Good catch, thanks!

Fixed by https://github.com/gogits/gogs/pull/1464


Cocktail sorting in C++

Is your feature request related to a problem? Please describe.
Not a bug or a problem, i just want to add cocktail sorting in C++
Describe the solution you'd like
I will add the code of cocktail sorting
please assign this issue to me under swoc, @Kumar-laxmi thank you!

Assigned!
@ArgyPorgy : C++

assign me i will do in python

@Kumar-laxmi my semester exams are going on so I'm not able to do it yet. My exams are ending on 11th feb, I'll start working on it once I'm done with my exams. I'm really sorry that this is taking so much time, hope you will understand.

@muskan467 What is your status on this issue?

@Kumar-laxmi I have created pull request #471, and that file is merged also.


Add option to specify "title" for the shared resource

Please add option to specify "title" for the shared resource, e.g. email subject line.

waiting for it

hi, tried it and give a title still image sent without title i think better to check it again ver 1.1.1

@kw2019ltd  I added the subject field for the sharing，but not all apps support this.
It depends on whether third-party apps use the subject to show.  Tested on email and it worked well, but other apps may not.

Hi @zhouteng0217,
Can you add subject option to shareMultiple function? If you want I can fork then send pr.

@Adem68 , I will add the code for share multiple function in the new version this time. It is just a simple code. Of course PR is always welcome.

You can close this issue. Thanks for reply.


Problem about environment

In your requirement.txt  timm==0.5.4 and torch==1.10.0+cu111 , but timm==0.5.4 requires torch>=1.4.0. And after upgrade the version of torch there is problem to train the models using 'python -m torch.distributed.launch --nproc_per_node=8 '.
torch.distributed.DistBackendError: NCCL error in: ../torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp:1970, invalid usage (run with NCCL_DEBUG=WARN for details), NCCL version 2.20.5

I have same issue...


DOC: add authRoutes.js

What's wrong with the existing documentation
add authRoutes.js in routes
Add ScreenShots
add authRoutes.js in routes this file is helpful to handle user registration, login, logout, and token verification
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

not clear

The existing documentation does not include the authRoutes.js file in the routes directory. This file is crucial for handling user registration, login, logout, and token verification.
Update the documentation to include the authRoutes.js file.
Provide details on how to use the routes for user authentication.
Adding authRoutes.js will enhance the documentation, making it easier for new developers to understand and implement user authentication.
This route file is essential for managing user sessions and ensuring secure access to the application.

Is it clear now ?

Is it clear now ?

Go ahead!


/github/home in K8s mode

If I understand https://github.com/actions/runner-container-hooks/blob/73655d4639a62f6e4b3d70b5878bc4367c0a436e/packages/k8s/src/k8s/utils.ts#L18-L68 correctly /github/home does not get added to pods executing a docker container.
Some images however (like super-linter) expect /github/home to be existent and writable. In my specific case I found out, that when running super-linter in a k8s-mode selfhosted runner it fails to execute, since it tries to modify the user's .gitconfig (to mark /github/workspace a git safe directory), which fails since the entire homedir does not exist. I've opened super-linter/super-linter#6242 do fix this issue for super-linter, but I would expect that there are more actions out in the wild that will fail in a similar fashion.
Is there any specific reason why this volume mount is excluded?

I ran into the same issue today when deploying self-hosted k8s runners and attempting to run a docker action that created and modified a file at /github/home/<foo>.txt.
I pulled down the hooks repo and built it into a new actions-runner image with the addition of the volume mount specified for the job container here, which appeared to sort of work.
The one oddity I noticed (that I still haven't fixed) is attempting to run the same docker action twice in a row causes the second to fail with an HttpError: HTTP request failed error.
Is /github/home reserved for use by the primary job container? Would love input from the @actions/actions-launch team


GAC issue

Good evening,
So I had everything set up and running during testing. No changes to the server, but after implementing this live (same server and code I just added access to the code to be run on a routine instead of manually)
However, today when checking, I'm getting the following error when using the APICaller_Post_Headers stored procedure. (Again, this was working perfectly last week). No changes to the server that anyone knows of.
When I run the code now, I get the following Response:
Could not load file or assembly 'System.Runtime.Serialization, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089' or one of its dependencies. Assembly in host store has a different signature than assembly in GAC. (Exception from HRESULT: 0x80131050)
I'm not really sure where to start in trying to figure this out.  Any help would be greatly appreciated.

Just a little more information. The APICaller_Post_Headers worked. But I had created a Second one called APICaller_Post_Headers1 that allowed the @JSON as a variable. (Which was done because of another thread/conversation.
My apologies but it's the second one that is giving the error.
Based on this
CREATE PROCEDURE [dbo].[APICaller_POST_Headers1]
@URL nvarchar,
@Headers nvarchar,
@jSON nvarchar
WITH EXECUTE AS CALLER
AS
EXTERNAL NAME [API_Consumer].[StoredProcedures].[APICaller_POST_JsonBody_Headers]
GO

Good morning @iamoop,
Did you try doing this:

ALTER  ASSEMBLY [System.Runtime.Serialization]
FROM 'C:\Windows\Microsoft.NET\Framework64\v4.0.30319\System.Runtime.Serialization.dll'
WITH PERMISSION_SET = UNSAFE

I will as soon as I can. (VPN is currently down. So I'll let you know). Thank you for the quick reply.

That worked. Thank you. Any ideas as to why that would have stopped working so that I can try to avoid it in the future?

Make sure the GAC was not updated.

Hey @iamoop , I just experienced same error in a production environment, right after installing this Windows update (Cumulative Update for .Net Framework 3.5 and 4.8 Version 1903 and 1909).
There is a tools named DQS, which could be use to automatically update SQL asembly after .Net framework update.


fix ranks in compression

This PR addresses 2 issues:

When multiple processes use a file, one of them downloads the file, and the others wait (by design there should be no download conflicts). When waiting for a compressed file, it is important to wait for the uncompressed local file to exist, not the compressed one, because that is when the shard is ready to use.

When a remote dataset is missing itscompression.txt file, the rank0 process notices right away with a FileNotFoundError and proceeds. But the other ranks, which are waiting for rank0 to complete it's download, may wait up to 3min (3 tries * 60s) to understand that the file is missing and proceed. The dist.broadcast behavior change here will make the init time in this case much faster.

Confirmed that this works with our multi-rank streaming tests:
 make test-dist WORLD_SIZE=2 EXTRA_ARGS="-s -m daily tests/datasets/test_streaming.py"

As well as an end-to-end BERT run with 8 GPUs, with both a compressed and uncompressed remote dataset.


problem with images showing up

I'm having an issue...
After pushing to GitHub, the images are not loading/showing up. The link for them shows up, and you can click on the link and see the images...
I can't seem to figure out why this is doing this.
Any thoughts?
https://github.com/thehamiltonlab/thehamiltonlab.github.io
https://thehamiltonlab.github.io/hamilton-lab/
Thanks!
Chris

Maybe you’ve sorted things out. Just looked at your site and images show up fine for me.

oh really? I can see some of the main images on the pages...but for those embedded within the text, they're just the code for the link the images (and then those show up in a gallery-like view).

Never mind I see an issue on the Hamilton lab page. You have some bad HTML. Check the img tag inside of the figure. You’re. Is sing a closing >
Should be this instead:

Dang! Good catch. Thanks, that worked.
Appreciate it!


recognition of double line text

Does MAERec support recognition of double line text

MAERec may only recognize single line text.


Alarm support wechat webhook

Please answer these questions before submitting a pull request

Why submit this pull request?

[ ] Bug fix

[√ ] New feature provided

[ ] Improve performance

Related issues
resolve #5460

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.
Alarm support Wechat webhook

@kezhenxu94 We had a discussion here, https://github.com/apache/skywalking/issues/5460. Please take a look.
From my personal preference, I don't like the integration API in the same method. Because they belong to different enterprises. They definitely will not consider others' API, if they are going to upgrade one day.
Such as, they could request a header or different authentication way.
If one day, something is not incompatible, we have to add strange if/else.

A minor different of slack vs wechat(dingtalk) is  slack support batch message,  wechat and dingtalk only support single message

A minor different of slack vs wechat(dingtalk) is slack support batch message, wechat and dingtalk only support single message

This is a kind of thing, I want to avoid. If we use a template, this will be strange to separate in the codes.

Yes, for now I totally agree @wu-sheng 's thought,  we can't control the outside dependency change.

And please provide a screenshot for the alarm sent through WeChat.

What is this? This doesn't like the alarm message we sent.

What is this? This doesn't like the alarm message we sent.

this is just a test

Could you trigger a real alarm? I want to post this on twitter and forward it to the QQ groups.

Yeap, one minute

this is from prod alarm

Do these IPs matter? Is this OK to post?

doesn't matter, it is inner ip

Do you have a twitter account? Could you share your name?

https://twitter.com/xbkaishui1 , just registered one

https://twitter.com/ASFSkyWalking/status/1304670754890366976 Done.

Thanks


#712 and #713

Description
Frontend for issue 712 and 713 has been implemented. A divider has also been added.
Fixes #712 #713
Review Time Estimate
Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[ ] Immediately
[ ] Within a week
[x] When possible

Type of changes
Please select a relevant option:

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Other (any another change that does not fall in one of the above categories.)

Checklist:
Please select all applicable options:

[ ] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[x] I have updated the CHANGELOG.
[ ] I have read the Contributor Guidelines.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[ ] My changes generate no new warnings.
[x] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

Backend logic for #713 is functional, backend logic for #712 is still in progress.


Roadmap

Hi @glittershark, just wanted to know what the future of the project is? I remember you saying there were some changes you wanted to make and I was wondering what they were.

This component meets a lot of our requirements and I think has a strong future.  But we need to able to render components easily inside of data-driven table (that is, when data property is used, not Tr/Td).  There are currently two PRs that meet this need, mine and another one.  Either one would be great!

Just wanted to say that we all love this project (hands-down the best data table library for React IMO) and we just want to make sure it receives the care it deserves 😄

Let me second @hassankhan.  Every other datatable we've tried seems consumed with solving edge case problems.  We just wanted a standard HTML table with some added features like sorting, filtering etc.  Long live reactable

Pinging @glittershark

I'm only being persistent because there are some issues that I would love to see addressed, and I just want to be assured that any work I do will get merged/released soon. For starters I'd love to see the warnings go away for once and for all, and secondly I'd love to see a re-do of pagination, either like #4 or by passing a paginatorComponent prop to <Table />.

So, in the last few months the time I've had to maintain this has waned a little bit as work has been taking up more and more of my time. Let's see if I can address the specific things you're asking for:

rendering rows in components: absolutely want this, but it's fairly difficult to achieve given how Reactable actually needs a fully rendered sub-tree in order to parse through child data. I took a crack at it a while back, and ran into some fairly unsurmountable issues. I'd accept a working patch though
rendering components in the data prop:  this one's a non-goal, as I don't feel like it provides much value (calling .map on an array is easy). The data prop was always intended as a kind of ramp-up to the full sub-tree rendering, which I would consider the "primary" interface to Reactable. I've been thinking about reworking the docs to make that clear for a while now.
Pagination re-do: this one's been necessary basically since day 1 (thus why #4 is such a low-numbered issue). Probably top of the list at the moment.

As far as things not already mentioned in this thread:

People keep asking for colspan and rowspan - I'm not sure how it'd work with sorting and pagination, but if someone can come up with an API that makes sense I'm open to it
Async loading of data is something I keep waffling on, as I'm not entirely sure Reactable provides a lot of value there given how idiosyncratic a lot of APIs can be. That said, I think the majority of real-world use cases for a data table involve async data loading so I could see moving into that space at some point

Awesome, thanks for the response! I've started work on a branch. There's a fair few changes, mainly:

Using Lodash for any data transformations
Using Webpack
Making the code a little friendlier
Using slightly more idiomatic React

Ideally, I want to get it back to feature parity using the test suite. That said, there's quite a few ways of passing data into a <Table /> 😮 . Once I get that out of the way, I think there might be a few other things worth considering:

Should Reactable keep supporting the multiple ways of passing data? While its flexible, it makes things quite complex internally as we have to parse all the child nodes to get a complete picture.
If we were to only receive data through <Table />, we could get rid of a lot of logic.
Make the filter input a separate component and provide a filterComponent prop.
Add stricter PropTypes validation - this might break a few things as well.

The only thing I'm against in that list is using Lodash - I'd rather not force that dependency on any upstream consumers. We as library authors have the burden of doing all the stuff that libraries like lodash make easy manually, so that application developers don't have to 😄

In the same vein, I'm fine with internal complexity, especially given how good the test coverage is (should be basically 100%). The entire point of libraries imo is to be complex so you don't have to.

I'm not sure I understand the resistance to custom components in data (or specified in column object).  The alternative would seem to be specifying all columns in markup even if only one column necessitated component rendering (a button, say).   I think people expect to be able to just hand some data to a datatable component and maybe do some limited customization.

@glittershark True, but I feel there's no point in reinventing the wheel for simple things like checking types etc., and using Webpack and ES6 imports we can specifically only require the functions we need and use tree-shaking to exclude unused code. We need not even need Lodash as a dependency, rather a few functions from it listed as separate devDependencies.
In terms on internal complexity, I don't feel that the codebase is very welcoming to new contributors or that it lends itself to extension very well, even with near 100% test coverage. I've spent the past few days trying to figure out the best way of parsing/storing the data internally and its not terribly obvious from looking at the code. While libraries are supposed to be complex, they don't have to be more than need be 😄
@alisman Currently I'm focusing on getting the branch up to parity, once I'm done we'll see what, if any changes, get made to either this repo or our fork.


Jcs/notes20190226

The database part of issue #516
Remember to change the DB of test and prod

Test and Prod updated


Add SpriteFadeComponent to potted plants

About the PR
Added SpriteFadeComponent to potted plants.
Why / Balance
See #13344.
Technical details

Media

https://github.com/user-attachments/assets/9e697227-3d20-435b-9dbc-d57d40e09bca
Requirements

[x] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

tweak: Potted plants now fade their sprites, just like trees.

it shouldnt close the original issue

it shouldnt close the original issue

As I remember there are no more things that you can go under.

As I remember there are no more things that you can go under and don't have SpriteFadeComponent.

There might still be more things so maybe just let it sit for a while

As I remember there are no more things that you can go under and don't have SpriteFadeComponent.

There might still be more things so maybe just let it sit for a while

Okay.

@UbaserB, I unlinked the issue.


Recalculate grid if props changed

Problem
Grid doesn't recalculate columns when props changed.
Now there is a condition that checks previous and current width. And it stops further function running.
I guess the condition was added to avoid redundant calculation when "resize" event is fired.
Well, let's validate the width only on the "resize" event.

very helpful!


bucket: fix buffer moving when growing

Why:
Livekit server throws errors like this sometimes:
"could not get packet from bucket,
sequence number mismatch, headSN 52552, sn 52248, cacheSN 52548" where the sequence number difference is always 300 (default size for video).
This points towards a problem with growing the bucket, as Grow() has been called since the error is not ErrPacketTooOld
What:
Add a test case for growing a bucket that is full, which reproduces the issue
Fix the byte array swap that is used for moving the packet slots around to preserve the original packet buffer order after growing the bucket

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Added CDK gitignore

Pull Request
Thank you for contributing to @toptal/gitignore and https://www.gitignore.io.
New or update
Select the appropriate check box for this pull request. This helps when merging to ensure there are no conflicts with other templates or misunderstandings of how thee template list works.
New

[x] Template - New .gitignore template
[ ] Composition - Template made from smaller templates
[ ] Inheritance - Template similar to an existing template
[ ] Patch - Template extending functionality of existing template

Update

[ ] Template - Update existing .gitignore template

Details
Create .gitignore template for AWS CDK
This is from the default .gitignore when using the AWS CDK CLI to create a new project and selecting typescript as primary language : https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk/lib/init-templates/app/typescript/.template.gitignore

Oh didn't saw this. Nice catch!
I think we can then close this PR and im gonna create a new one for the modification of .moban.yaml

Thank you @Wingjam! I'll be on the lookout for the next one!