[HOWTO] install org-ref in doom-emaxy way

Hi,
Great project.
I tried to install a wonderful package https://github.com/jkitchin/org-ref into doom-emacs.
But there is no package with M-x package-install.
I added a line in .emacs.d/init.el it asks me to install epdinfo , when confirmed with an yes, sudo password was asked, but reported the specific letter of the password was UNDEFINED after pressing each key of the letter!
M-x doom/info output is as follows:
- OS: gnu/linux (x86_64-pc-linux-gnu)
- Shell: /bin/bash
- Emacs: 26.2 (Jun 03, 2019)
- Doom: 2.0.9 (HEAD -> develop, origin/develop, origin/HEAD c99c184 2019-07-09 23:30:59 +0200)
- Graphic display: t (daemon: nil)
- System features: XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM THREADS LCMS2
- Details:
  ```elisp
  env bootstrapper: envvar-file
  elc count: 0
  uname -a:  Linux 4.4.0-148-lowlatency #174~14.04.1-Ubuntu SMP PREEMPT Thu May 9 08:50:56 UTC 2019 x86_64
  modules:   (:completion company ivy :ui doom doom-dashboard doom-quit hl-todo modeline nav-flash ophints (popup +all +defaults) treemacs vc-gutter vi-tilde-fringe window-select workspaces :editor evil file-templates fold multiple-cursors rotate-text snippets :emacs dired electric vc :term eshell term vterm :tools ansible eval flycheck (lookup +docsets) magit pdf tmux :lang cc data erlang elixir elm emacs-lisp go javascript latex markdown (org +attach +babel +capture +export +habit +present +protocol +ref) perl php python sh web :app write :config default)
  packages:  (org-ref-pdf-directory org-ref-bibliography-notes org-ref-default-bibliography)
  exec-path: (~/.asdf/shims ~/.asdf/bin /mnt/homepool/HOME/zenny/Downloads/mono2colour/torch/install/bin . /mnt/homepool/HOME/zenny/Downloads/mono2colour/torch/install/bin . /mnt/homepool/HOME/zenny/Downloads/mono2colour/torch/install/bin ~/.local/share/umake/bin ~/bin /usr/local/sbin /usr/local/bin /usr/sbin /usr/bin /sbin /bin /usr/games /usr/local/games /usr/brlcad/bin /usr/lib/jvm/java-8-oracle/bin /usr/lib/jvm/java-8-oracle/db/bin /usr/lib/jvm/java-8-oracle/jre/bin ~/.fzf/bin /usr/local/libexec/emacs/26.2/x86_64-pc-linux-gnu/)

What is the ideal way to install a new package in doom-emacs? Can anyone elaborate?
Cheers,
/z

Emacs/doom noob myself, but the "doom way" to add new packages is to add them to your private module (~/.doom.d directory). You can find more info in the wiki here: https://github.com/hlissner/doom-emacs/wiki/Customization#install-my-own-packages and here https://github.com/hlissner/doom-emacs/wiki/Modules
tldr, something like (didn't try this myself):
In ~/.doom.d/packages.el:
(package! org-ref)

In ~/.doom.d/config.el:
(def-package! org-ref
    :after org
    :init
    ; code to run before loading org-ref
    :config
    ; code to run after loading org-ref
    )

Then run ~/.emacs.d/bin/doom refresh

Emacs/doom noob myself, but the "doom way" to add new packages is to add them to your private module (~/.doom.d directory). You can find more info in the wiki here: https://github.com/hlissner/doom-emacs/wiki/Customization#install-my-own-packages and here https://github.com/hlissner/doom-emacs/wiki/Modules
tldr, something like (didn't try this myself):
In ~/.doom.d/packages.el:
(package! org-ref)

In ~/.doom.d/config.el:
(def-package! org-ref
    :after org
    :init
    ; code to run before loading org-ref
    :config
    ; code to run after loading org-ref
    )

Then run ~/.emacs.d/bin/doom refresh

@netpro2k Thanks for your input, shall try.

This doesn't seem to work for me:
    → Cloning org-ref...
    → Cloning org-ref...done
    → Building org-ref...
    → Building org-ref → Cloning helm...
    → Building org-ref → Cloning helm...done
    → Building org-ref → Building helm...
    → Building org-ref → Building helm → Building helm-core...
    → Building org-ref → Building helm → Building helm-core...done
    → Building org-ref → Building helm...
    → Building org-ref → Building helm...done
    → Building org-ref → Cloning helm-bibtex...
    → Building org-ref → Cloning helm-bibtex...done
    → Building org-ref → Building helm-bibtex...
x There was an unexpected error:
  Type: doom-package-error
  Message:
    Error with packages
  Data:
    "org-ref"
    (error "Could not find package bibtex-completion in recipe repositories: (org-elpa melpa gnu-elpa-mirror emacsmirror-mirror)")
    ""

I'm not quite sure what to do about this.

@ocharles Unrelated issue. See https://github.com/hlissner/doom-emacs/issues/2802#issuecomment-606654151.
Since this issue was answered I'll consider it resolved.


install error,  file could not be downloaded

"endroid/qrcode-bundle": "^1.6",
Loading composer repositories with package information                                                                                Updating dependencies (including require-dev)           - Installing endroid/qrcode-bundle (1.6.6)
Downloading: Failed
Failed to download endroid/qrcode-bundle from dist: The "https://api.github.com/repos/endroid/EndroidQrCodeBundle/zipball/f8f12fd9f6414a98e21b85acac4859d40b70130e" file could not be downloaded (HTTP/1.1 404 Not Found)
Now trying to download from source
Permission denied (publickey).

Hi @grekpg you can install "endroid/qrcode" and use the bundle you can find there. The qrcode-bundle package has been abandoned for about a half year and removed about a week ago.


Importing studies in v2.x

How do I go about to allow importing new studies in the OHIF viewer v2.x. Previously there was the importStudies.js file. I don't find anything similar in the code.
The study count is still visible in the UI, but the '+' next to it is missing, which previously allowed to select studies to be uploaded to the server.
Thanks for the support.

That hasn't been implemented yet, though there is some very similar
functionality in the Google Cloud UI we just added. It uses STOW-RS to send
studies do the dicomweb endpoint. We should use that upload component.
Happy to take a PR for that if you want to try to implement it.
On Fri., Jul. 12, 2019, 12:32 p.m. Timo Spring<EMAIL_ADDRESS>wrote:

How do I go about to allow importing new studies in the OHIF viewer v2.x.
Previously there was the importStudies.js file. I don't find anything
similar in the code.
The study count is still visible in the UI, but the '+' next to it is
missing, which previously allowed to select studies to be uploaded to the
server.
Thanks for the support.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/OHIF/Viewers/issues/660?email_source=notifications&email_token=AAEUMMIZAHU4E5A56DVNULLP7BMUBA5CNFSM4ICG2AVKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G63CZSQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEUMMLIMRKB4R6DPXJC3GDP7BMUBANCNFSM4ICG2AVA
.

@biharck

Remove the Upload button from here: https://github.com/OHIF/Viewers/blob/master/src/studylist/StudyListWithData.js#L224
Instead, the + button next to the number of studies should open the DICOM uploader: https://github.com/OHIF/Viewers/blob/master/src/studylist/StudyListWithData.js#L206

This was added in https://github.com/OHIF/Viewers/pull/717, you just have to ensure that studyListFunctionsEnabled is true in your config. You also have to ensure that your server supports STOW-RS at the same URL that it supports QIDO-RS.


Keyboard shortcut assignments for selected player sizes

I'd love to know if there could be a way for us to assign keyboard shortcuts to some of our favorite player sizes.  That would save me lots of scrolling and clicking (as I often watch videos on "fill screen.")  It would be great if we could toggle back and forth quickly instead with keyboard shortcuts.

+1
This would be great!


Header downloader

Michelangelo is working on the header downloader in https://github.com/mriccobene/silkworm.
Already implemented:

gRPC async client to talk with the sentry
rpcs: SetStatus, SendMessageById, SendMessageByMinBlock, PeerMinBlock, ReceiveMessages
rlp encoding & test of packets: BlockBodies, BlockHeaders, GetBlockBodies, GetBlockHeaders, NewBlockHashes, NewBlock
processing of  inbound GetBlockBodies, GetBlockHeaders messages and related responses

So, right now, the downloader is able to connect to the sentry and respond to external request.
This figure shows the overall architecture. All business logic runs in a single thread that processes both incoming and outgoing messages.

RPC
We have a class for each rpc of the sentry interface. Each class has this responsibility: prepare & execute a rpc

Packets
Messages (=packets) are not specified in the proto of sentry interface, they are in the Erigon code. We have a struct for each packet:

Messages
We have messages that encapsulate:

incoming packet pre-processing
outgoing packet pre-processing

(header processing & requesting logic is elsewhere)

Logic and "main"
The other classes are in the picture below:


Plotting for ZXDiagrams and ZXGraphs

Dear Maintainers,
this PR  implements the plotting functionality for ZXDiagrams and ZXGraphs and closes #101 and fixes #100
Please note, it is still missing weak dependencies, because currently we do not pass differently typed parameters to the plot function. This requires us to change the types of the arguments for plot
Let me explain in detail. The documentation has the following example with their original module:
module Plotting

function plot(x::Vector)
    # Some functionality for plotting a vector here
end

end # module

External Module with access to extra dependencies:
module PlottingContourExt # Should be same name as the file (just like a normal package)

using Plotting, Contour

function Plotting.plot(c::Contour.ContourCollection)
    # Some functionality for plotting a contour here
end

end # module

Here the c argument for plot is either Vector or the external dependency Countour
In my implementation of ZXCalculusVegaExt  booth definitions of plot have the same  type restriction. Please advise how you want the type signatures for plot to change, so  this can be added later or should be fixed before merging.
I am not sure if the Multigraph ZXDiagram is rendered correctly, due to the location of the spiders being set to zero. I have added this Diagram to the notebook under the heading Multigraph. Please have a look and tell me, if this is correct or what you expect so see instead.
Please inform me, what you like and don't like about this PR so I can improve on it.
Regards

Hello @contra-bit , thank you very much for working on adding plot into ZXCalculus.jl.  I was trying out the notebook tutorial.jl. I was able to see the new plots, they looked cool! But were you able to install all the required packages that are at the beginning of this notebook? I could not do it. I noticed that you added CompilerPluginTools to dependency. That was causing a little trouble for us. It will probably cause more trouble for us when Julia v1.10 is out. Roger is planning on updating YaoHIR and removing this completely see link. Is this a hard requirement for your future work regarding this dependency?

Good catch. It is not required.
I only added CompilerPluginTools as an explicit dependency because it was causing trouble for me, when it was being  imported as a dependency by YaoHIR.
The import failed because the version required could not be resolved.
The only way for me to resolve the YaoHIR dependency was to add the master branch from the git repo because the julia package had the wrong version.
In order for it to be imported correctly I ran the following command:
pkg> add https://github.com/JuliaCompilerPlugins/CompilerPluginTools.jl

Then I added the equivalent command to the notebook as well.
pkg> add https://github.com/JuliaCompilerPlugins/CompilerPluginTools.jl

@contra-bit Thanks for the PR. I suggest removing the dependency that is only used in the notebook, and keeping the main package as clean as possible. Perhaps it would be better to set up a separate environment in the notebook folder to include CompilerPluginTools and DataFrames.

I am thrilled to share several improvements in this pull request! I have introduced plotting functionality as an optional extension using Vega and DataFrames. This change ensures that these dependencies will only be loaded when needed, leading to faster load times and reduced memory usage.
To enhance accessibility, I have updated the color scheme of spider graphs so that they are distinguishable for people with Color Vision Deficiency (CVD), and improved the readability of phase labels. For further details, kindly consult the accessibility guidelines provided at zxcalculus.com.
My latest contributions enhance testing for both ZXDiagrams and ZXGraphs by adding plots to most tests, along with creating a brand-new notebook dedicated to equivalence checking and refining the existing tutorial notebook. Users will benefit from automatic generation of diagrams within these notebooks.
Moreover, YaoHIR has gained the ability to import OpenQASM files, allowing seamless conversion to ZXDiagrams—providing yet another practical method to construct quantum circuits. I will try to get all my contributions merged and then update the Pkg in the notebooks.
As part of my efforts, I fixed the match and apply function for the  ZXGraph :id rule while adding the new equivalence checking functionality. Now, it is possible to determine if two diagrams are identical through the built-in equivalency checks.
Last but not least, I took care of numerous housekeeping tasks such as updating imports, resolving problems discovered during testing, enhancing overall user experience for plots, and dealing with miscellaneous glitches

@contra-bit Thanks for working on this PR. It looks decent. Before merging this PR, I have only two minor suggestions.

You don't need to keep the original tutorial.jl notebook since it is out-of-date.
There are a lot of indent changes in this PR. The default indent of this repo is 4, but some of the indents are set to 2. These changes have created a lot of unnecessary differences, making it difficult to keep track of the real changes. Could please you fix the indent issue?

FYI you don't have to use the package env for notebooks, every Pluto notebook has its own env by default.

I hope I have fixed the indentation issues, further I have increased the test coverage and added a .JuliaFormatter.toml that species that the default indentation is 4.
The notebooks are now configured to use the Yao upstream repositories.
My next goal is to improve the notebooks and improve the documentation.

I have addressed the feedback and think this can be merged now. @ChenZhao44
Thank you for being patient.

I reformatted the mentioned files by hand. Thank you for the thorough review.

Great! This commit looks good to me. Let's see if Dr. Zhao and Dr. Luo has any further comments!

LGTM


The section "Provision a "modern" team site programmatically via SharePoint Online REST API" could use some details

It would be nice to see the actual endpoints to call to create modern team/communication sites in this section. Documentation on creating modern sites via REST seems to be relatively sparse in general.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1114c203-314e-f97a-a8a4-d4f5ec73af0e
Version Independent ID: 79c90765-56a2-9d05-9ace-83cd71fc0fde
Content: Provisioning
Content Source: docs/solution-guidance/modern-experience-customizations-provisioning-sites.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

What is your mean of actual endpoints? For data protection, the sensitive information will be hidden or disposed.

@Seiyasu, I mean the REST endpoint to call in SharePoint or Office 365 to create a new Modern Team Site. Something like: https://graph.office.com/beta/groups/ (no idea if it can be done via graph API or not) or similar.
I think it would be useful to have the information in this section on how you actually create modern Communication and Team sites via REST.

Further to my comment above, I see that the Graph API is officially documented with examples and so is the SitePages API. I'll add those to the documentation section on creating modern sites via REST and create a pull request.


Missing documentation about concurrent runs of MigrationHarness::run_pending_migrations

Setup
Versions

Diesel: 2.1.0

Problem Description
The documentation of MigrationHarness::run_pending_migrations does not mention if the method can safely be called concurrently from e.g. two different processes.
Will this lead to the same migrations being applied twice, will one of the method calls fail (with a panic or an error?), or will all calls simply block until the migrations are finished?
What are you trying to accomplish?
Automatically apply pending migrations on application startup, but the application is architectured to have multiple backend processes running concurrently.
Checklist

[x] I have already looked over the issue tracker and the discussion forum for similar possible closed issues.

[x] This issue can be reproduced on Rust's stable channel. (Your issue will be
closed if this is not the case)
[x] This issue can be reproduced without requiring a third party crate

I'm happy to accept a PR that adds this information to the documentation.


Github Page Template

Hi Greg,
I am a user of ProxyStore, and through it, I came across your personal GitHub page. I found it to be very clean and well-organized. Would it be alright if I used it as a template for my own personal GitHub page? Thank you!

Hi @Zilinghan! Yes, you are welcome to fork/use this template.
If you have any questions about how things work, feel free to open another issue!


Qt: Add GUI view of peer information. #4133

This breaks currently in Travis since it tries to build with --disable-wallet too. bitcoin/bitcoin@a92aded70ec2346c3f07ff1cf8eb97101a76912f should fix it, but also fixes a similar problem with another pathc. Should keep that in mind. Will merg for now until the other one is pulled and both get the fix commit :)

I like the feature very much tho :)


Running the tests locally does not work

We seem to have problems running the whole test set (or multiple tests at once) locally. This happens both in linux and windows. The tests run properly but when it's supposed to print out the results of the failed and erroneous tests, it does not. A sample ouput of the tests follow for a phpunit tests run:
[02.10.2015 11:47:19 p15628/t16160 NOTICE] Successfully established connection to the database
PHPUnit 4.8.10 by Sebastian Bergmann and contributors.

..............................................................  62 / 757 (  8%)
.............................................................. 124 / 757 ( 16%)
.............................................................. 186 / 757 ( 24%)
.............................................................. 248 / 757 ( 32%)
......................................................F....... 310 / 757 ( 40%)
.............................................................. 372 / 757 ( 49%)
.............................................................. 434 / 757 ( 57%)
.............................................................. 496 / 757 ( 65%)
.............................................................. 558 / 757 ( 73%)
.............................................................. 620 / 757 ( 81%)
....................................................F.....F.FF 682 / 757 ( 90%)
FFFFFF.IIIIIII..IIIIIIIII.IIIIIFIIIIIIIFIIF..EEII.......EIIIII 744 / 757 ( 98%)
IIIIIIIIIIIII

Time: 2.15 minutes, Memory: 49.50Mb

There were 3 errors:

1) EventsTest::testEnableEvents
PHP Fatal error:  Method PHPUnit_Framework_ExceptionWrapper::__toString() must not throw an exception in phar://C:/bin/phpuni
t.phar/phar/phpunit/TextUI/ResultPrinter.php on line 0
Whoops\Exception\ErrorException: Method PHPUnit_Framework_ExceptionWrapper::__toString() must not throw an exception in file
phar://C:/bin/phpunit.phar/phar/phpunit/TextUI/ResultPrinter.php on line 0
Stack trace:
  1. () phar://C:/bin/phpunit.phar/phar/phpunit/TextUI/ResultPrinter.php:0
   | array(0) {
   | }

This error __toString() must not throw an exception seems to happen regardless of what is the exact test that failed.
However, if I run a single test e.g. with phpunit tests/old/libraries/EventsTest, the test output is correct, a sample follows:
[02.10.2015 11:52:38 p15392/t14936 NOTICE] Successfully established connection to the database
PHPUnit 4.8.10 by Sebastian Bergmann and contributors.

EEII.

Time: 343 ms, Memory: 12.75Mb

There were 2 errors:

1) EventsTest::testEnableEvents
Exception: Invalid Method.

C:\dev\php\concrete5\web\concrete\src\Support\Facade\Facade.php:108
C:\dev\php\concrete5\tests\tests\old\libraries\EventsTest.php:35
C:\dev\php\concrete5\tests\tests\old\libraries\EventsTest.php:35

2) EventsTest::testGetInstance
Exception: Invalid Method.

C:\dev\php\concrete5\web\concrete\src\Support\Facade\Facade.php:108
C:\dev\php\concrete5\tests\tests\old\libraries\EventsTest.php:44
C:\dev\php\concrete5\tests\tests\old\libraries\EventsTest.php:44

FAILURES!
Tests: 5, Assertions: 3, Errors: 2, Incomplete: 2.

I'm just guessing maybe this has something to do with the Whoops integration. But at least obviously also something to do with the situation when there are multiple test files run at the same time.
Can anyone shed some light on how we can get the tests to run properly on our local machines?

This is due to the PHP language level __toString magic method not allowing exceptions. There's something about the original error that PHPUnit doesn't like so PHPUnit throws a new exception while processing it.
PHPUnit should be catching the error it throws and properly handing it in the __toString method rather than letting it fall through, so this might just be something you can fix by updating PHPUnit.

Updated PHPUnit to the latest stable 5.0.6.
Same issue with the same output.
For comparison I ran the test set for laravel/framework with correct output (which had 1 failed and 2 skipped tests).

@antii, I ran the tests this morning locally with no issues, maybe modify  PHPUnit_Framework_ExceptionWrapper::__toString to output what the actual
error is.
On Mon, Oct 19, 2015 at 3:23 AM Antti Hukkanen<EMAIL_ADDRESS>wrote:

Updated PHPUnit to the latest stable 5.0.6.
Same issue with the same output.
For comparison I ran the test set for laravel/framework with correct
output (which had 1 failed and 2 skipped tests).
—
Reply to this email directly or view it on GitHub
https://github.com/concrete5/concrete5/issues/3007#issuecomment-149175963
.

I'm also not having any problems running locally. Maybe do a clean clone / composer install and try again? Rule out something in your code base that might be causing it.

@KorvinSzanto I added try..catch there and it seems this is internally caused by PHPUnit because of a missing global variable. The missing global variable is named $GLOBALS['_SERVER']['SCRIPT_NAME'] which is accessed here (where the error comes from):
https://github.com/sebastianbergmann/phpunit/blob/master/src/Util/Filter.php#L31
When this error is raised, it is catched by Whoops which then throws an Whoops\Exception\ErrorException that PHPUnit doesn't like.
I read from here someone having similar problems but apparently the reason is not in PHPUnit itself:
https://github.com/sebastianbergmann/phpunit/issues/1255
Maybe there is some PHP setting wrong on my computer? But I have no idea where to look for.
If I try to print out $GLOBALS['_SERVER']['SCRIPT_NAME'] during tests/bootstrap.php, it is correctly set. So somewhere down the line it gets unset (no idea where).
===
@joe-meyer I'm running the core test set.

@joe-meyer Also to add, I have also tried with a clean composer install. And I just merged with upstream/develop so everything should be up to date.

@antii, no clue. Make sure the vendors are up to date and that composer is
up to date. Nothing should be modifying the $_SERVER superglobal at all.
On Mon, Oct 19, 2015 at 11:19 AM Antti Hukkanen<EMAIL_ADDRESS>wrote:

@KorvinSzanto https://github.com/KorvinSzanto I added try..catch there
and it seems this is internally caused by PHPUnit because of a missing
global variable. The missing global variable is named
$GLOBALS['_SERVER']['SCRIPT_NAME'] which is accessed here (where the
error comes from):
https://github.com/sebastianbergmann/phpunit/blob/master/src/Util/Filter.php#L31
When this error is raised, it is catched by Whoops which then throws an
Whoops\Exception\ErrorException that PHPUnit doesn't like.
I read from here someone having similar problems but apparently the reason
is not in PHPUnit itself:
sebastianbergmann/phpunit#1255
https://github.com/sebastianbergmann/phpunit/issues/1255
Maybe there is some PHP setting wrong on my computer? But I have no idea
where to look for.
If I try to print out $GLOBALS['_SERVER']['SCRIPT_NAME'] during
tests/bootstrap.php, it is correctly set. So somewhere down the line it
gets unset (no idea where).
@joe-meyer https://github.com/joe-meyer I'm running the core test set.
—
Reply to this email directly or view it on GitHub
https://github.com/concrete5/concrete5/issues/3007#issuecomment-149303132
.

@KorvinSzanto How about:
https://github.com/concrete5/concrete5/blob/develop/tests/tests/old/libraries/RequestTest.php#L24-L27
I just tried commenting those lines out and it seemed to fix the problem.
I can make a PR for this unless there is a reason those lines are there...?

Very strange, I can't see a reason to keep it if the full suite passes
without it. If we have issues we can just reset the values in the teardown.
On Mon, Oct 19, 2015 at 11:29 AM Antti Hukkanen<EMAIL_ADDRESS>wrote:

@KorvinSzanto https://github.com/KorvinSzanto How about:
https://github.com/concrete5/concrete5/blob/develop/tests/tests/old/libraries/RequestTest.php#L24-L27
I just tried commenting those lines out and it seemed to fix the problem.
I can make a PR for this unless there is a reason those lines are there...?
—
Reply to this email directly or view it on GitHub
https://github.com/concrete5/concrete5/issues/3007#issuecomment-149305776
.

Well, the test suite does not pass anyways for me. Here is the test output with those lines commented out:
PHPUnit 5.0.6 by Sebastian Bergmann and contributors.

..............................................................  62 / 763 (  8%)
...........................................................F.. 124 / 763 ( 16%)
.............................................................. 186 / 763 ( 24%)
.............................................................. 248 / 763 ( 32%)
.............................................................. 310 / 763 ( 40%)
.............................................................. 372 / 763 ( 48%)
.............................................................. 434 / 763 ( 56%)
.............................................................. 496 / 763 ( 65%)
.............................................................. 558 / 763 ( 73%)
.............................................................. 620 / 763 ( 81%)
..........................................................F... 682 / 763 ( 89%)
..F.FFFFFFFF.IIIIIII..IIIIIIIII.IIIIIFIIIIIIIFIIF..EEII....... 744 / 763 ( 97%)
EIIIIIIIIIIIIIIIIII                                            763 / 763 (100%)

Time: 1.99 minutes, Memory: 48.50Mb

There were 3 errors:

1) EventsTest::testEnableEvents
Exception: Invalid Method.

C:\dev\php\concrete5\web\concrete\src\Support\Facade\Facade.php:108
C:\dev\php\concrete5\tests\tests\old\libraries\EventsTest.php:35
C:\dev\php\concrete5\tests\tests\old\libraries\EventsTest.php:35

2) EventsTest::testGetInstance
Exception: Invalid Method.

C:\dev\php\concrete5\web\concrete\src\Support\Facade\Facade.php:108
C:\dev\php\concrete5\tests\tests\old\libraries\EventsTest.php:44
C:\dev\php\concrete5\tests\tests\old\libraries\EventsTest.php:44

3) RequestTest::testParse
Whoops\Exception\ErrorException: Argument 1 passed to Symfony\Component\HttpFoundation\Request::__construct() must be of the
type array, string given, called in C:\dev\php\concrete5\tests\tests\old\libraries\RequestTest.php on line 58 and defined

C:\dev\php\concrete5\web\concrete\vendor\symfony\http-foundation\Symfony\Component\HttpFoundation\Request.php:219
C:\dev\php\concrete5\tests\tests\old\libraries\RequestTest.php:58

--

There were 14 failures:

1) Concrete\Tests\Core\File\ImporterTest::testImporterMimeType
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'image/jpeg'
+'text/plain'

C:\dev\php\concrete5\tests\tests\Core\File\ImporterTest.php:236

2) LocalizationTest::testGeneratedPO
i18n.php output:
Could not open input file: C:\dev\php\concrete5\tests/build-tools/i18n.php
Failed asserting that 1 is identical to 0.

C:\dev\php\concrete5\tests\tests\Localization\LocalizationTest.php:18

3) FormHelperTest::testTextarea
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'ccm-input-textarea'
+    0 => 'form-control'
     1 => 'test-class'
 )

C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:166
C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:47

4) FormHelperTest::testText
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 'ccm-input-text'
-    1 => 'test-class'
+    1 => 'form-control'
+    2 => 'test-class'
 )

C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:166
C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:63

5) FormHelperTest::testEmail
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 'ccm-input-email'
-    1 => 'test-class'
+    1 => 'form-control'
+    2 => 'test-class'
 )

C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:166
C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:73

6) FormHelperTest::testTelephone
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 'ccm-input-tel'
-    1 => 'test-class'
+    1 => 'form-control'
+    2 => 'test-class'
 )

C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:166
C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:83

7) FormHelperTest::testUrl
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 'ccm-input-url'
-    1 => 'test-class'
+    1 => 'form-control'
+    2 => 'test-class'
 )

C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:166
C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:93

8) FormHelperTest::testSearch
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 'ccm-input-search'
-    1 => 'test-class'
+    1 => 'form-control'
+    2 => 'test-class'
 )

C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:166
C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:103

9) FormHelperTest::testSelect
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'ccm-input-select'
+    0 => 'form-control'
     1 => 'test-class'
 )

C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:166
C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:115

10) FormHelperTest::testSelectMultiple
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'ccm-input-select'
+    0 => 'form-control'
     1 => 'test-class'
 )

C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:166
C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:130

11) FormHelperTest::testPassword
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 'ccm-input-password'
-    1 => 'test-class'
+    1 => 'form-control'
+    2 => 'test-class'
 )

C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:166
C:\dev\php\concrete5\tests\tests\old\helpers\FormHelperTest.php:144

12) ConcreteUrlsHelperTest::testObjectClass
Failed asserting that false is true.

C:\dev\php\concrete5\tests\tests\old\helpers\concrete\ConcreteUrlsHelperTest.php:26

13) ConcreteUserHelperTest::testObjectClass
Failed asserting that false is true.

C:\dev\php\concrete5\tests\tests\old\helpers\concrete\ConcreteUserHelperTest.php:30

14) ConcreteValidationTest::testObjectClass
Failed asserting that false is true.

C:\dev\php\concrete5\tests\tests\old\helpers\concrete\ConcreteValidationHelperTest.php:27

FAILURES!
Tests: 763, Assertions: 1484, Errors: 3, Failures: 14, Incomplete: 50.

But please note it didn't pass in the first place for me either (see the result in the first message of this thread).

However, Travis CI build seems to pass with these lines commented out: #3036

@antii, if that doesn't resolve your issues I don't think it's worth
pulling out of the suite. We don't make any effort to support windows
versions of PHP, please run the tests in a posix based system.
On Mon, Oct 19, 2015 at 12:08 PM Antti Hukkanen<EMAIL_ADDRESS>wrote:

However, Travis CI build seems to pass with these lines commented out:
#3036 https://github.com/concrete5/concrete5/pull/3036
—
Reply to this email directly or view it on GitHub
https://github.com/concrete5/concrete5/issues/3007#issuecomment-149315586
.

Well it resolves the issue in question, does not break anything in the current test set and allows Windows developers to run the tests, so I have to disagree with that.
There are some test failuers but at least we can confirm that e.g. if we make changes affecting the user handling (#2996), it won't break any existing tested functionality.

Not sure that this issue can be closed yet, sounds like @ahukkanen is still having trouble

@ahukkanen Looking closely at the test errors you pasted, you shouldn't be running tests in that old directory at all, are you sure you're running the up to date test suite? You should be navigating to concrete5/tests/ and running $ phpunit.

Yeah, running phpunit solely works better, there is only a single failure which is the 1) in the output above (content type mismatch).
We have been following the guide at the root of tests which suggest running the tests from the whole tests folder. Maybe that should be modified?
And yes, this can be closed as the underlying issue was resolved. I think it is still good addition in case anyone else runs the old tests. Or maybe remove them completely in case they are no longer needed?

Yeah it's probably worth opening an issue to remove them.


Twitter Like Implementation

Hello, Can anyone assist me in using this to create a twitter like post view controller where the image picker loads under the post option and once the image picker view is swiped up the image picker loads fully

Currently not supported...

I want to use the same Twitter like approach. Basically you will leave out the tableview and present the collectionview without any options to choose asset types. Should be possible, isn't it?

I like the Twitter approach. I will support later.

Have you made any progress with that implementation?

Done.


Add ‘hacktoberfest’ tag

We should add the hacktoberfest tag to the repository to increase amount of contributions to the project.

Added. And put a fancy banner on it too 😃
https://github.com/topics/hacktoberfest?q=bukkit+bomberman


Comments with question marks

http://stackoverflow.com/questions/26633675/pdo-comment-error
PDO parses text within comments. Any comments should be stripped from incoming SQL. This is easy enough for lines starting with # or --.

Comments don't have to start at the beginning of the line - they can be at the end of a line containing sql too.  That means you'll need to strip from the comment marker to the end of the line, which sounds simple but... What if an enclosed string within the sql contains a hash?

Good point. All very testable.

Also need to test for other comment markers including -- and, more annoyingly, c++ style multi line comments (/* to */)

Nice regex here for stripping them, appears to handle multi-level too: http://stackoverflow.com/a/13821950
They make the point elsewhere that you probably want to replace the comments with whitespace rather than deleting them, otherwise debugging the sql gets very hard as the line and character numbers don't match the source file any more.

Can close once an integration test proves this is Illuminate's responsibility.


more fragmentation support

[ ] support fragmentation on general save events as well (on IDE side)
[ ] support outgoing fragmentation on fs_server side
[ ] support incoming fragmentation from fs_server (on IDE side)

not necessary with > 2.0, now handled in (atom-socket)[https://github.com/learn-co/atom-socket]


Embed builder into sync and async clients

Generate embedded builder classes into sync and async clients;
Import generated models for collapsed models;
Remove invalid imports;
Add correct imports for Android clients;

Is it possible to paste some generated android code (that related to the code change) as sample (easier for reviewer to understand what is changed in android)?
Ignore me if you only need Anu to review.


Check if file exists before running disk usage on it.

Check if file exists before running disk usage on it. Not all mounts are normal files.
I am running telegraf on an openstack cluster which uses openvswitch which creates mounts for network namespaces that look like this:
proc net:[4026532152] proc rw,nosuid,nodev,noexec,relatime 0 0

Telegraf fails for disk usage checks whenever this proc is present. The solution is simply to ignore any mounts that don't exist as normal files.

awesome, thanks @allen13! :+1:

@allen13 could you please sign the CLA? Let me know once you've done it and I can get this merged

CLA signed.


Redesign Website

The site is very cluttered right now, could definitely use a cleanup/redesign.

Had a quick crack at this.
https://github.com/Tama63/crafatar with a demo over on https://pacific-depths-7149.herokuapp.com/ (avatars are broken due to missing redis?).
Let me know what you think.

That's great. I like the table idea, although I find the table style a bit ugly and don't like the #F9F9F9 color.
"blazing fast" sounds good, too.
Want to make a PR?

Feel free to come talk about it in #spongy if you can hop on iRC.


CI: Reduce pip behaviour dependencies in test suite

Closes #2104

Contributor checklist

[x] Included tests for the changes (change is to fix a test).
[ ] PR title is short, clear, and ready to be included in the user-facing changelog.

Maintainer checklist

[ ] Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@ncoghlan could you check if this is still necessary? pip is now pinned to 24.2 in regular CI runs, and the CI has been made green with that (see #2140).

Given CI is green, I agree it isn't necessary to proceed with this.

@ncoghlan note that the pip version in CI is now restricted so that the updates are transparent. So it is possible that this breaks with newer pips (I know there are some problems; I just don't know if they are the same you were looking to address here).

Ah, in that case you will still need something along these lines when upgrading to a newer pip. The specific changes this made are to:

explicitly set a build system and constraint file in test_compile_recursive_extras_build_targets
remove setuptools, wheel and distribute from the expected set of protected modules in test_diff_should_not_uninstall


feat(auth): add auth support in turso dev

This PR adds auth support for turso dev command and adds two additional checks when starting and killing the sqld server process.
Changes
The Start method launches the sqld command without waiting for the process to fully initialize. If sqld exits with a non-zero status code due to validation issues or other errors, the error message may be missed by the user since the program also prints "sqld is listening", etc. and then blocks with the channel making it seem as if the server is running.
Calling the Wait method immediately after Start would cause the program to hang in the happy path since it waits to exit. Instead, this PR waits for the server to be ready by pinging the opened connection before printing the success messages. It also waits after calling Kill to ensure a clean shutdown, as Kill does not wait for the process to fully exit.
Lastly, the original purpose of this contribution was to fix https://github.com/tursodatabase/turso-cli/issues/752
New Experience
With valid JWT Key

With invalid JWT key

Hey! Thank you for the PR. If the user is passing JWT file, we should not print:

No auth token is required when sqld is running locally

Hi @avinassh, thanks for feedback. I updated the PR to match the the behavior devFile flag. Let me know what you think.

Thank you for your contribution @guergabo! 🥳


Android M fixes

Hi,
Thanks for creating this app. This is brilliantly simple. However some of the checks are deprecated and don't work the way you expect them to on Marshmallow. I fixed it up to make it work and changed the build information for testing.
I don't know anything about Android development, so I don't think you should actually pull this. It is just a bunch of quick and dirty fixes and the results are probably not even compatible with older API versions. I hope this saves you some time when you write a proper fix. It would be great if the version in the play store was compatible with more recent Android versions.
Best regards,
Florian Uekermann

Oh by the way, you are free to use any of this code in any way you want without attribution. Not that there is anything to take, but I guess it doesn't hurt to make sure there are no copyright issues.

Thanks for reporting!
I will look into this next week - I will have to keep the check in but only for Android <=5 (and possibly add a new check/help message for Android 6(?)).

https://github.com/luv/mockgeofix/commit/77d2a57ddeea121f8f8a5008576fa931e564940d


[bug 1193325] Remove eq_ and ok_: feedback.

This commit removes eq_ and ok_ imports as well as their use in the
files under feedback directory. It replaces eq_ and ok_ with proper
assert statements.

This looks good. Thank you!


🐫 camel-css: preprocessor for nesting selectors

this task is very similar to #107, so it's a good idea to read and understand that task first.
we need to make a css tagged-template function.
it needs to be a language like sass that enhances css.

it needs to be css-injection safe, similar to hamster-html.
but it needs to be more advanced, because in addition to adding injection-safety, we want to add a new feature: css selector nesting.

this means we need to write a parser, to read our new css-based language, and compile it to css.
this is a new css preprocessor.
for now, we are only interested in gaining selector nesting, similar to the sass language.

instead of using a build step like sass, our new preprocessor will generate css on-the-fly, and it will be usable on the serverside as well as on the frontend within web components.

requirements:

[ ] new css function in file s/toolbox/camel-css/css.ts.
[ ] css injection safe. we'll have to make a new css-escape.ts function.
[ ] devs can deliberately inject css, bypassing the css-escape. probably via nesting css calls.
[ ] implement sass feature & parent reference
[ ] cynic test suite must prove that it works s/toolbox/camel-css/css.test.ts

bitcoin bounty expired

add requirement to implement sass & feature

I will like to be assigned this ticket.


[rubberband] Update to 3.2.1 and use recommended sleef dependecy where supported

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

This PR:

Updates rubberband to the latest 3.2.1 release
Uses sleef instead of fftw on platforms where it's supported. Because it's the fastest available FFT library according https://github.com/breakfastquay/rubberband/blob/default/COMPILING.md#fft-libraries-supported

I don't understand what happens on arm64_windows.
Both vcpkg.json and the portfile contain the same architecture conditions,
    {
      "name": "fftw3",
      "platform": "(arm & windows) | (arm64 & osx)"
    },
    {
      "name": "sleef",
      "platform": "!(arm & windows) & !(arm64 & osx)"
    },

if(VCPKG_TARGET_IS_WINDOWS AND VCPKG_TARGET_ARCHITECTURE STREQUAL "arm")
    set(FFT_LIB "fftw")

but on arm64_windows it installs the dependency
fftw3:arm64-windows: SUCCEEDED: 30.9 ms
instead of sleef, while the compile parameter from the portfile is set to -Dfft=sleef :
 Command failed: D:/downloads/tools/python/python-3.10.7-x64/python.exe D:/installed/x64-windows/tools/meson/meson.py -Dfft=sleef -Dresampler=libsamplerate -Dipp_path= -Dextra_include_dirs= -Dextra_lib_dirs= -Djni=disabled -Dladspa=disabled -Dlv2=disabled -Dvamp=disabled -Dcmdline=disabled -Dtests=disabled --buildtype plain --backend ninja --wrap-mode nodownload --native C:/a/1/s/scripts/buildsystems/meson/none.txt --libdir lib --cross D:/buildtrees/rubberband/meson-arm64-windows-dbg.log -Ddebug=true --prefix D:/packages/rubberband_arm64-windows/debug --includedir ../include -Dcmake_prefix_path=['D:/installed/arm64-windows/debug','D:/installed/arm64-windows','D:/installed/arm64-windows/share'] D:/buildtrees/rubberband/src/v3.2.1-b2bb56759a.clean
For me it seems that arm is different during evaluation of the vcpkg.json file and during execution of the portfile.
Question: Should arm be set in case of arm64 or only for the 32 bit arm arcitecture?

In platform expressions, arm includes arm64. That's why you will find cases of, or need, (arm & !arm64).

Cf. https://learn.microsoft.com/en-us/vcpkg/reference/vcpkg-json#platform-expression

For discussion/consideration:
Reading https://github.com/breakfastquay/rubberband/blob/default/COMPILING.md#fft-libraries-supported, fftw3 seems to have two disadvantages for Apple platforms: slower than the default vDSP and using a restrictive license.
I wonder if we should add minimal feature control here. AFAIU there are different FFT backends, but not a different surface. We must not model "alternatives", but we can model the fast FFT "behaviour":

Default(core): Use the system vDSP lib on Apple targets, or the builtin FFT implementation otherwise.
This represents upstream's defaults.
fast-fft: The fastest FFT backend.

no effect for Apple targets.
otherwise using sleef where supported
otherwise using fftw3.

Rubberband consumes very significiant CPU ressources, for practical use, you always need fast FFT. The default is therefore easy to build but unusable in real applications.
The problem with Apple platforms is, that the fast Apple implemention requires this framework to be installed: https://developer.apple.com/documentation/accelerate
I guess VCPKG can't detect if it's installed. An I personal have no Mac to develop such a detection script. But the upstream manual doesn't state that the Apple implementation is faster than the sleef implementation.

The following error occurred when testing the feature on x86-windows and x64-windows-static:
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" -v
    Working Directory: E:/matplotplusplus/buildtrees/matplotplusplus/x86-windows-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      E:\matplotplusplus\buildtrees\matplotplusplus\config-x86-windows-dbg-CMakeCache.txt.log
      E:\matplotplusplus\buildtrees\matplotplusplus\config-x86-windows-rel-CMakeCache.txt.log
      E:\matplotplusplus\buildtrees\matplotplusplus\config-x86-windows-out.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:248 (vcpkg_execute_required_process)
  ports/matplotplusplus/portfile.cmake:34 (vcpkg_cmake_configure)
  scripts/ports.cmake:147 (include)

E:\matplotplusplus\buildtrees\matplotplusplus\config-x86-windows-out.log:
CMake Error: install(EXPORT "Matplot++Targets" ...) includes target "matplot_opengl" which requires target "glad" that is not in any export set.
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    _VCPKG_ROOT_DIR

CMake Generate step failed.  Build files cannot be regenerated correctly.

When installing sleep on x86-windows, the following error occurs:
E:\rubberband\buildtrees\sleef\src\3.5.1-7f3a2e645a.clean\src\libm\sleefsimddp.c(2104) : fatal error C1001: Internal compiler error.
(compiler file 'D:\a\_work\1\s\src\vctools\Compiler\Utc\src\p2\main.c', line 225)
 To work around this problem, try simplifying or changing the program near the locations listed above.
If possible please provide a repro here: https://developercommunity.visualstudio.com
Please choose the Technical Support command on the Visual C++
 Help menu, or open the Technical Support help file for more information
  cl!RaiseException()+0x69
  cl!RaiseException()+0x69
  cl!CloseTypeServerPDB()+0x20d78f
  cl!CloseTypeServerPDB()+0xd2f1d

This is a VS bug, see: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1334513/ , it has not been fixed yet. If you replace feature fftw with sleep, users of both VS 2019 and VS 2022 will face this error.
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review"

All features are tested successfully in the following triplet:
x86-windows
x64-windows
arm64-windows

Thank you!


Debian bullseye

Debian bullseye launches in summer this year, and we should update to that release when RPi OS Bullseye is released (Docker base images and Umbrel OS). I've created this issue to track all the required changes and progress on that update.

[ ] Update docker base images
[ ] Update Umbrel OS to build bullseye
[ ] Create distro update backend
[ ] Create distro update frontend

I'm not sure how you want to implement that (Ship it as part of an OTA update/Extra update button just for OTA updates).
@lukechilds @mayankchhabra @louneskmt What do you think about this?

hi, maybe it should be 64bit version of OS, because of performance.
"Across the few dozen different workloads tested, switching Raspberry Pi OS 11 for the 64-bit version improved the performance on average by about 48%. See all the 32-bit vs. 64-bit Raspberry Pi benchmarks over on OpenBenchmarking.org."
https://www.phoronix.com/scan.php?page=article&item=raspberrypi-32bit-64bit&num=4


STYLE: Use macros in tests

Use macros in tests:

Use ITK_TRY_EXPECT_NO_EXCEPTION macro when updating filters in lieu of try/catch blocks for the sake of readability and compactness, and to save typing/avoid boilerplate code.
Only place with the macro the code that might raise exceptions.
Test the Set/Get methods using the ITK_TEST_SET_GET_VALUE macro: make them quantitative instead of just calling the getter methods, or printing the returned values.

Take advantage of the commit to remove unnecessary/uninformative comments and messages where the code has been modified.
PR Checklist

[X] No API changes were made (or the changes have been approved)
[X] No major design changes were made (or the changes have been approved)

/azp run ITK.Linux


Add an exemple with Traefik using binary

Setup a quick lab and release an exemple for binary traefik version
This will help us debug issues like #41

Currently:

[ ] Traefik installed as a service
[ ] Crowdsec installed as a service
[ ] Whoami installed as a service
[ ] Traefik Dashboard accessible on port 8081
[ ] Traefik as the plugin setup in version 1.1.4
[ ] Whoami is accessible on port 9000 directly and from traefik on port 80 with any domain
[ ] Crowdsec is accessible at https://<IP_ADDRESS>:8080
[ ] Crowdsec is configured with TLS cert auth
[ ] Traefik plugin must implement TLS cert auth
[ ] Traefik plugin is connected to crowdsec with the TLS cert at startup
[ ] Add scenario exemple
[ ] Update documentation

Plugins are disabled if Traefik cannot write at a specific place:
{"error":"mkdir plugins-storage: permission denied","level":"error","msg":"Plugins are disabled because an error has occurred.","time":"2022-11-27T09:52:58Z"}

This comes from Traefik code which tries to write to:
const outputDir = "./plugins-storage/"
Somehow the func SetupRemotePlugins(client *Client, plugins map[string]Descriptor) from pkg/plugins/plugins.go of Traefik ends up start from / and not from ./ of the traefik conf directory

Waiting for #53

Ready to merge


[T4A2][F11-A2]Tiong YaoCong

Change of class-level members

convert paser methods into class-level
implemented sequence number for person
Regression testing completed

Ready For Review


A weapon called the boom-el-rang

Its a boomerang called the boom-el-rang, but instead of coming back to the user when thrown, it explodes. Art could perhaps be the crest of the Ayleid Crown of Lindai.

just a reskinned grenade or maybe single use thing


HDFS-16301.Improve BenchmarkThroughput#SIZE naming standardization.

Description of PR
In the BenchmarkThroughput#run() method, there is a local variable: SIZE. This variable is used in the local scope, and it may be more appropriate to change it to a lowercase name.
This is the purpose of this PR.
Details: HDFS-16301
How was this patch tested?
This is just the change of the variable name, which is not very stressful for the test.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 11s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 22s

trunk passed

+1 :green_heart:
compile
1m 34s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 32s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 41s

trunk passed

+1 :green_heart:
shadedclient
26m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 26s

the patch passed

+1 :green_heart:
compile
1m 32s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 32s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 56s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 7 unchanged - 1 fixed = 7 total (was 8)

+1 :green_heart:
mvnsite
1m 25s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 45s

the patch passed

+1 :green_heart:
shadedclient
26m  8s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
376m 20s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

488m  5s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestHDFSFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3622/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3622

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux ec764cec6025 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 63ce31f9ce1417d6cbc4c6acac094fba43901d68

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3622/1/testReport/

Max. process+thread count
1971 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3622/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

It looks like jenkins failed, there are some exceptions.
E.g:
TestReconstructStripedFileWithRandomECPolicy
TestStandbyCheckpoints
TestSeveralNameNodes
TestDecommissionWithBackoffMonitor
TestStateAlignmentContextWithHA
TestHDFSFileSystemContract
TestSeveralNameNodes
TestBlockReaderLocal
It doesn't seem to have much to do with the pr I submitted.
@goiri @tasanuma, would you like to spare some time to help review this pr.
thank you very much.

@jianghuazhu Thanks for reporting it. How about using fileSize?

Thanks @tasanuma for the comment and review.
I will update it later.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 16s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 49s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 13s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 22s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 22s

trunk passed

+1 :green_heart:
shadedclient
24m 59s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 17s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 52s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 7 unchanged - 1 fixed = 7 total (was 8)

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
25m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
377m 27s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

483m  7s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3622/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3622

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 0b7f04f9eb5e 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 11b57f0066d1f75b063ce37669174e564fbe072b

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3622/2/testReport/

Max. process+thread count
2278 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3622/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Can you help review this pr again, @tasanuma.
Thank you very much.

Merged. Thanks for your contribution, @jianghuazhu!


Set ss_len when creating SockAddr from std

The sockaddr_storage type of BSD contains a field ss_len that represents the size of the sockaddr. When converting from SocketAddr etc., we need to set them correctly. Otherwise, it may report wrong result when comparing addresses.

Maybe we can even drop SockAddr::len on targets that contain ss_len. A pr to fix the original issue and/or drop SocketAddr::len would be welcome.


auth endpoint "/api/v1/auth/token" not working

I deployed the app on google compute engine with certificate from letsencrypt, the web-app is wokring great so far, but when i tried to auth through "/api/v1/auth/token", I have no response, i tried both methods: password and client_credentials but the app seems crashing while hitting this end point.
check the latency on each endpoint:

api_1    | time="2017-01-19T16:47:19Z" level=info ip=<IP_ADDRESS> latency=1.049376ms method=GET status=200 url="/api/v1/users/self?include=projectGrants"
api_1    | time="2017-01-19T16:47:19Z" level=info ip=<IP_ADDRESS> latency=1.432486ms method=GET status=200 url="/api/v1/projects/a589a977-2a4d-4411-9659-5d79601d09c4/locales/"
api_1    | time="2017-01-19T16:47:26Z" level=info ip=<IP_ADDRESS> latency=145.90769ms method=POST status=200 url="/api/v1/auth/token"
api_1    | time="2017-01-19T16:47:44Z" level=info ip=<IP_ADDRESS> latency=86.716352ms method=POST status=200 url="/api/v1/auth/token"

I did not investigate yet, if you have ideas what can cause this, it may save me time.
Thank you for this great application, I was using google spearsheet before, and this is way better alternative.
Cheers,

Never mind, I was using postman, for some reason letsencrypt certificate was not validated, so i turned off the ssl validation and it worked.

Nice! To be sure before I close the issue, it was completely unrelated to Parrot?
It's cool to see people deploy it on different platforms. Was getting the server up and running on Google Cloud easy?


Testing Environment

Is there a way to test this project? Maybe a UTM virtual machine or emulator?

There is no point in emulating/virtualizing it since they already have their own UEFI implementation.
You could try compiling it on your own with Project Mu documentation, though it’ll probably be better to wait until there is proper documentation


v7.10.1

always leave ed for xcm transfers that requires delivery fee

Severity: Critical
Release version: 7.10.1
Release notes:
Improve cross-chain transfers validation


generate-raw: Accept a full path in generate, don't hardcode part of it

Make the callers of generate pass a full path to the witx file,
rather than having generate append the path to
wasi_snapshot_preview1.witx. This allows for callers that want to pass a
different path.

This is a partial step towards https://github.com/bytecodealliance/wasi/issues/28 . I pushed this as a baseline step that'll be common to any further approach.

This got merged as part of #30, so closing.


Request: Add link to docs in README

If/when docs are available (including a "Getting Started" page), it would be helpful to have it linked in the README.
I'd love to help contribute code if the vision was more clear, in terms of what the use of this project actually looks like. Without that, I'm a bit lost as to how to make sense of it all.

Thanks for the note.  I am working feverishly to try and get RHDL into shape.  I am super excited about it, and believe it will be much easier to use and more powerful than RustHDL was.  I hope in the next few weeks to complete the open items and then will start writing/porting the documentation.
I'll leave this issue open until I can get some semblance of intro docs written.


New release?

I'm submitting a...

[ ] bug report
[x] feature request
[ ] support request => Please do not submit support request here, see note at the top of this template.

Do you want to request a feature or report a bug?

Feature

What is the current behavior?

Cookiecutter-django was recently updated to support Django 1.11 and more specifically the most recent release of django 1.11.  A new release of cookiecutter-django has not yet been published.

What is the expected behavior?

I would expect that new versions of cookiecutter-django would be packaged as versioned releases as is standard practice.  This behavior is specifically expected when the underlying requirements for the package are updated, e.g. the version of django, or when a group of features are added to the package.

What is the motivation / use case for changing the behavior?

Production systems and environments are often built using pinned package versions.  When building an environment that uses cookiecutter-django, I want to be able to specify the (now) current version.

Short term fix: My team would like to use the current version, and we would prefer if it were packaged into a versioned release.

Long term: It's standard practice to have a process for releasing updates to software packages.  I would like to see regular versioned releases of cookiecutter-django as it and its underlying dependencies are updated.  My team is working on getting cookiecutter-django packaged for conda forge (community driven packaging system), and having versioned releases of cookiecutter-django published on github as the package is updated would help greatly in packaging for conda forge!

@pydanny It looks like the 1.11.9 release you created is broken and was fixed by this commit.
Could you possibly delete that release and move that tag to the latest commit before updating to django 1.11.10 so that the 1.11.9 release is a working build?  Here's the last commit before the update to django 1.11.10.

@webyneter @pydanny Even if you tag this commit as version 1.11.10, that would be very helpful as the 1.11.9 release is broken.

Okay, I'll get to this it a few hours

Created tag 1.11.10: https://github.com/pydanny/cookiecutter-django/releases/tag/1.11.10

I've also created tag 2.0.2. I'm going to close this for now. We can re-open if another release is required.


DeprecationWarning: Ftp.rawuser: Use Ftp.raw('user args') instead.

When I use ftp.auth method,  this deprecation warning appear. is there anyway to do authentication. my code is following.
const connect = (server) => new Promise((resolve,reject)=>{

	// create new ftp server with r
	const ftp = new JSFtp({
		host: server.host,
		port: server.port || 21,
		user: server.user,
		pass: server.pass,
		debugMode: true
	});

	ftp.on('error',function(err){
		if(err.code == 530 ) reject({status: true, err: 'invalid user credential'});
		if(err.code == 'ENOTFOUND') reject({status: true, err: 'invalid host'});
		reject({status: true,err:'criteria is not correct. cannot connect to server' });
	});

	ftp.on('connect',function(err){

		ftp
			.auth(server.user,server.pass,(err,data) => {
				if(err)	reject({ status: true, err: 'Error: 530 Login incorrect'});

				resolve(ftp);
			})
		// resolve(ftp);
	})
});

It happens the same with me :(

This is caused by the auth function itself for user look at line 334, for password its line 340 and for type it's line 349.
They should be changed to self.raw('user ' + user, function(..., self.raw('pass' + pass, function(... and self.raw('type I', function(....

This was already fixed and it is merged on master: https://github.com/sergi/jsftp/commit/35a8edd6e1132898590d585a415c521df000cb58. Could anyone release a new version so we stop receiving these warnings, please?

Bump. Can we have a new release, please?

Receiving this warning too. Bump.

Receiving. Bump it up!

Same here

Although this has been closed the lines referred to by @svenbw remain unaltered in the version distributed via npm. I think the new code needs to be npm published

Bump @sergi

+1, are moderators of this library active or should we fork ?

Guys, it's just a simple push to npm publish.... please

Bump @sergi

Guys, it's just a simple push to npm publish.... please

Bump @sergi

It's been a couple of months now. Is there a fork of this library that will be kept updated going forward?

Released v2.0.0. Really sorry for the wait, personal stuff got in the way.

Thank you so much for the update, @sergi.


[BUG]cannot recompile android13.apk

Information

Apktool Version (apktool -version) -2.6.1
Operating System (Mac, Linux, Windows) -Mac
APK From? (Playstore, ROM, Other) -Other

Stacktrace/Logcat
I: Using Apktool 2.6.1
I: Smaling smali folder into classes.dex...
I: Smaling smali_classes20 folder into classes20.dex...
I: Smaling smali_classes18 folder into classes18.dex...
I: Smaling smali_classes11 folder into classes11.dex...
I: Smaling smali_classes16 folder into classes16.dex...
I: Smaling smali_classes17 folder into classes17.dex...
I: Smaling smali_classes10 folder into classes10.dex...
I: Smaling smali_classes19 folder into classes19.dex...
I: Smaling smali_classes21 folder into classes21.dex...
I: Smaling smali_classes9 folder into classes9.dex...
I: Smaling smali_classes7 folder into classes7.dex...
I: Smaling smali_classes6 folder into classes6.dex...
I: Smaling smali_classes8 folder into classes8.dex...
I: Smaling smali_classes15 folder into classes15.dex...
I: Smaling smali_classes12 folder into classes12.dex...
I: Smaling smali_classes13 folder into classes13.dex...
I: Smaling smali_classes14 folder into classes14.dex...
I: Smaling smali_classes3 folder into classes3.dex...
I: Smaling smali_classes4 folder into classes4.dex...
I: Smaling smali_classes5 folder into classes5.dex...
I: Smaling smali_classes2 folder into classes2.dex...
I: Building resources...
W: /Users/niewei/all/any/app-cn-release/AndroidManifest.xml:131: error: attribute android:enableOnBackInvokedCallback not found.
W: /Users/niewei/all/any/app-cn-release/AndroidManifest.xml:131: error: attribute android:localeConfig not found.
W: error: failed processing manifest.
brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/var/folders/0m/ltd18w693fx4mgyxht34v2_c0000gp/T/brut_util_Jar_75188214170836631791981899796200836780.tmp, link, -o, /var/folders/0m/ltd18w693fx4mgyxht34v2_c0000gp/T/APKTOOL7692184737978072987.tmp, --package-id, 127, --min-sdk-version, 19, --target-sdk-version, 30, --version-code, 31600125, --version-name, <IP_ADDRESS>-rc125, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, -e, /var/folders/0m/ltd18w693fx4mgyxht34v2_c0000gp/T/APKTOOL2225047760528473291.tmp, -0, arsc, -I, /Users/niewei/Library/apktool/framework/1.apk, --manifest, /Users/niewei/all/any/app-cn-release/AndroidManifest.xml, /Users/niewei/all/any/app-cn-release/build/resources.zip]

Steps to Reproduce

apktool

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
APK
If this APK can be freely shared, please upload/attach a link to it.
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?
YES!
If you are trying to install a modified apk, did you resign it?
Are you using the latest apktool version?
YES!

Which os are you using?

macOs，It doesn't seem to be compatible with android13 yet

@bestneville Update the framework to version 33 or higher

@bestneville Use framework.jar version 33 or higher. And use aapt2 latest

framework.jar and aapt2 seem to be built into apktool. I tried to replace them, which caused some other problems.
When is supported by apktool itself?

Try this jar which i've edited
https://drive.google.com/file/d/1f1EkFUOBQTFxw4dw_QCUgKkk535XWltX/view?usp=sharing
How to use ?
1 - Create a folder with name tempr in same directory where you will place the jar
2 - use --use-aapt2 to recompile the apk
and let me know if its work.

@nikzdevz - I've removed that link. If you want to share a build, please share the code changes for the build and the user can build. I don't want to risk malware or unofficial builds.

@iBotPeaches ok. where to suggest the code changes ?

@nikzdevz - I've removed that link. If you want to share a build, please share the code changes for the build and the user can build. I don't want to risk malware or unofficial builds.

I tried it and had the same error  ， How can I solve this error

@iBotPeaches ok. where to suggest the code changes ?

Pull Request to this repo is preferred.

@iBotPeaches
:)

I found the latest code branch already supported

This was already resolved during the internal framework update. You could test yourself with a snapshot build here - https://github.com/iBotPeaches/Apktool/actions/runs/2644508403

I was facing same issue with an app , then I tried with the latest build from master , though this issue is resolved but I am facing a new error
error: failed linking references.
brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/var/folders/16/fss9c46s7slf3r7shkmfvmjm0000gq/T/brut_util_Jar_60540973667396634375182075550523300358.tmp, link, -o, /var/folders/16/fss9c46s7slf3r7shkmfvmjm0000gq/T/APKTOOL6954729294638853611.tmp, --package-id, 127, --min-sdk-version, 26, --target-sdk-version, 33, --version-code, 19289, --version-name, 2.74.0-automation, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, -e, /var/folders/16/fss9c46s7slf3r7shkmfvmjm0000gq/T/APKTOOL2928238007883608010.tmp, -0, arsc, -I, /Users/devtyagi/Library/apktool/framework/1.apk, --manifest, /Users/devtyagi/Work/apktool-experiment/Apktool/./apk-name/AndroidManifest.xml, /Users/devtyagi/Work/apktool-experiment/Apktool/./apk-name/build/resources.zip]

I could see that there is already an issue for this #2797 , can you please check this


tests/systemd-networkd-wireguard: migrate to python test runner

Updating systemd-networkd-wireguard to use the python test runner.
This change was purely syntactic. This migration did not require any
semantic change.
Motivation for this change
Part of #72828
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @tfc

@GrahamcOfBorg test systemd-networkd-wireguard


GreyScale Image on HTC M8

The cropped image returned on HTC M8 Eye is GreyScaled. Tested on few other device the image returned is colored. So it is just on HTC M8. Any Fixes?

wow... can help debug this?

It usually happens when image is quite big. But not sure why only on M8 Eye.

It may be related to sampling... if you can reproduce it in the sample app and then debug it will be super helpful. Unfortunately, I have no way to investigate this.

It's not only on HTC M8, I've met this issue on Samsung S5 Neo and couple more devices, mainly on Android 6.0 or 4.4. On those devices after cropping image

with
CropImage.activity(Uri.fromFile(photoFile)) 						.setRequestedSize(500, 500) 						.setAllowRotation(true) 						.setAspectRatio(1, 1) 						.setNoOutputImage(false) 						.start(getContext(), this);
the result is obtained as GreyScale


Add Sadie Bartholomew to list of contributors

After noticing #287 on the Issue Tracker, I noticed I am not on the list of contributors here and imagine I probably should be due to my infrastructure contributions (I don't think I have contributed in any other more direct way, yet, but hope to do so soon or at least eventually!). Please correct me if I am wrong. If you require some evidence to justify the addition of myself to the list, I can point you to some issues or similar, but hopefully that is not necessary. Thanks.

@sadielbartholomew you are clearly a valuable contributor, thank you for your work and for keeping this list up to date.