feat(workbench) adds configurable sidebar position

This PR adds a configuration setting allowing the user to put the sidebar on the right side. This is accomplished by creating a list of the "surface" components, and reversing their order if the setting is set to right. The default CSS lays out the components correctly.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Awesome PR @kyleshevlin - thank you!

I wonder if we should flip the 'highlight' in the activity bar:

there is a highlight line to show the active selected sidebar pane - I believe it would make sense to move it to the right side when workbench.sideBar.location is right.

Sure, @bryphe, that's how it looks in VSCode, so I can give that a shot

Sweet, thanks @kyleshevlin !
That border is here: https://github.com/onivim/oni2/blob/5e385db6ce03635bd390d4429d25ebd83af2ea7a/src/UI/Dock.re#L33
so we'll need to add a parameter to <Dock />, and then plumb it through <activityBar />:
https://github.com/onivim/oni2/blob/5e385db6ce03635bd390d4429d25ebd83af2ea7a/src/UI/Root.re#L126
Pretty close to where we query currently in Root.re to get the sidebar location.

I've discovered a bug that should be addressed before merging this involving resizing the sidebar.

I have the resizer on the correct side already. Working on the pane resizing as expected.

Nice catch @kyleshevlin !
I'm thinking we'll need to change the way the delta is applied as the resize in progress, depending on the sideBar location:
https://github.com/onivim/oni2/blob/5e385db6ce03635bd390d4429d25ebd83af2ea7a/src/Feature/SideBar/Feature_SideBar.re#L44
(If it's on the right, we'd want width - resizeDelta instead)

And got that, too.

FWIW, Ran unit tests locally and they all pass.

Just pulled the latest and tested it out - looks great, @kyleshevlin !
Thanks for fixing the highlight position and catching the resize issue 👍  Bringing in now!


Update last_git_commit action

Update the last_git_commit action to return this new information:

commit_hash
abbreviated_commit_hash

Looks great, thanks :+1:


13-pass-conf

Ready to merge?

Would suggest using a subdir of an exiting mount.
Do you mean something along the lines of:

volumes:
      - home:/home
      - secret:/.secret
      - ./slurm-conf:/home/.config

Since the source for the "home" volume is /var/lib/docker/volumes/slurmindocker_home/_data, I think having a mount in slurm-in-docker/ would be a good idea, and slurm-in-docker/slurm-conf seems like an intuitive location to place a slurm.conf file.

replaced by #19 - closing


Add vectorised unit test for Collatz Conjecture

As a demonstration of the point I raised in issue #109, here is an update for the non-core Collatz Conjecture exercise.  The current version of this does not test for vector parameters and the example would fail this test.
The following changes have been made:

An extra test has been added to the unit tests that send a four-element vector to the function.
In the example, he original function collatz_step_counter has been renamed to collatz_scalar.
Also in the example, the line collatz_step_counter <- Vectorize(collatz_scalar) has been added.

This is a very minor change to the example, but makes the function a lot more powerful by taking full advantage of R's vectorisation capabilities.  R developers really shouldn't be thinking in single values the way most mainstream programming languages do.

I have this on the radar, and will try to review it this weekend. Sorry for the delay!


Endpoints should return 405 Method Not Allowed rather than 404 for unsupported methods

What is the issue?
As mentioned on Discord, it's no big deal, but sometimes users make mistakes like opening http://<IP_ADDRESS>:11434/api/chat in a browser, which defaults to the GET method, and are served a 404 page.
As the resource presumably does exist and works with POST requests, returning a 405 Method Not Allowed would be a more accurate response to the user's error.
I have tested this on the /api/chat and /api/generate endpoints, as well as the /api/ps endpoint with a POST request, but I presume most, if not all, endpoints return a 404 page when queried with the wrong method.
Steps to reproduce:
curl -v http://<IP_ADDRESS>:11434/api/chat
*   Trying <IP_ADDRESS>:11434...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 11434
> GET /api/chat HTTP/1.1
> Host: <IP_ADDRESS>:11434
>
< HTTP/1.1 404 Not Found
...

curl -v <IP_ADDRESS>:11434/api/ps -d '{}'
*   Trying <IP_ADDRESS>:11434...
> POST /api/ps HTTP/1.1
> Content-Length: 2
> Content-Type: application/x-www-form-urlencoded
>
* upload completely sent off: 2 bytes
< HTTP/1.1 404 Not Found

Cheers, Pat
OS
Linux
GPU
AMD
CPU
AMD
Ollama version
0.1.46

@royjhan this is a great one to look at once we merge the OpenAI compatibility improvements


Benchmarking of RC2 v3.2.0 with extraneous timers

Event logs:

BPIC_2012_W_contained (train, test)
BPIC_2017_W_contained (train, test)
ConsultaDataMining201618 (train, test)
Governmental_Agency (train, test)
poc_processmining (train, test)
Production (train, test)

Governmental_Agency finishes with ValueError: probabilities are not non-negative reported by Prosimos (this log failed during the previous benchmarking because the time ran out, this time I use another machine for benchmarking, not HPC)

Still running most of the other logs.

Also, this time I'm facing a new issue with most of the runs. Before, I ran experiments via SLURM on HPC. Now, it's a simple powerful Linux machine in UT network, and I run experiments with a Python script executing a Simod's Docker container on a Simod configuration file via Python's subprocess.run.
I'm having the following issue now:
"""
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/multiprocessing/pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "/usr/local/lib/python3.10/multiprocessing/pool.py", line 48, in mapstar
    return list(map(*args))
  File "/usr/src/Simod/src/simod/simulation/prosimos.py", line 252, in _evaluate_logs_using_metrics
    value = compute_metric(metric, validation_log, validation_log_ids, simulated_log, simulated_log_ids)
  File "/usr/src/Simod/src/simod/metrics/metrics.py", line 31, in compute_metric
    result = get_dl(event_log_1, event_log_1_ids, event_log_2, event_log_2_ids)
  File "/usr/src/Simod/src/simod/metrics/metrics.py", line 106, in get_dl
    return evaluator.measure_distance()
  File "/usr/src/Simod/src/simod/metrics/tsd_evaluator.py", line 64, in measure_distance
    distance = self._evaluate_seq_distance(self.log_data, self.simulation_data)
  File "/usr/src/Simod/src/simod/metrics/tsd_evaluator.py", line 86, in _evaluate_seq_distance
    pool = Pool(processes=cpu_count)
  File "/usr/local/lib/python3.10/multiprocessing/context.py", line 119, in Pool
    return Pool(processes, initializer, initargs, maxtasksperchild,
  File "/usr/local/lib/python3.10/multiprocessing/pool.py", line 212, in __init__
    self._repopulate_pool()
  File "/usr/local/lib/python3.10/multiprocessing/pool.py", line 303, in _repopulate_pool
    return self._repopulate_pool_static(self._ctx, self.Process,
  File "/usr/local/lib/python3.10/multiprocessing/pool.py", line 326, in _repopulate_pool_static
    w.start()
  File "/usr/local/lib/python3.10/multiprocessing/process.py", line 118, in start
    assert not _current_process._config.get('daemon'), \
AssertionError: daemonic processes are not allowed to have children
"""

With this explanation https://stackoverflow.com/questions/51485212/multiprocessing-gives-assertionerror-daemonic-processes-are-not-allowed-to-have, it seems that because of the multithreaded evaluation which wants to run also multithreaded TSD (DL) metric computation it can't, because a thread cannot start another pool of threads.
There's a solution to this, https://stackoverflow.com/questions/6974695/python-process-pool-non-daemonic. But it still doesn't seem correct for a thread to run another pool of threads. It can actually slow down the metric computation because of a race for resources.

Hi @david-chapela. I'm still running benchmarking, but I've just taken BPIC 2012 to peak into the results.

With timers, graphs look way off. However, average cycle time seems to be closer to the original times.

These are the results after the bug is fixed (we've already reviewed them, so this is just for the history):

Production-timers_evaluation_20221222_160233267754.csv
Production-no-timers_evaluation_20221130_180242945366.csv

We decided:

To compare the results when optimizing for extraneous timers BEFORE the calendar optimization
To use absolute EMD instead of cycle time EMD in the extraneous package as an optimization metric


Bump to MongoDB 4.4

Bumps the MongoDB requirement from 3.6 to 4.4 and updates fiftyone-db to be backed by MongoDB 4.4.2.
The install script has been updated in efficient-clone, so that change has been omitted here.

Hey @benjaminpkane, since #728 requires 4.4 features, I found that I had to manually run the following in order to enable them on my DB:
Any ideas on how to avoid users having to manually do this? Either for source or wheel builds (unsure if this applies to wheel installs)
# Upgrade instructions
# https://docs.mongodb.com/manual/release-notes/4.4-upgrade-standalone/#upgrade-standalone

~/.fiftyone/bin/mongod --dbpath ~/.fiftyone/var/lib/mongo
~/.fiftyone/bin/mongo --shell

db.adminCommand({getParameter: 1, featureCompatibilityVersion: 1})
db.adminCommand({setFeatureCompatibilityVersion: "4.4"})
db.adminCommand({getParameter: 1, featureCompatibilityVersion: 1})

Yes,

Hey @benjaminpkane, since #728 requires 4.4 features, I found that I had to manually run the following in order to enable them on my DB:
Any ideas on how to avoid users having to manually do this? Either for source or wheel builds (unsure if this applies to wheel installs).
I presume the issue is specifically for users who are upgrading, not new installs.
# Upgrade instructions
# https://docs.mongodb.com/manual/release-notes/4.4-upgrade-standalone/#upgrade-standalone

~/.fiftyone/bin/mongod --dbpath ~/.fiftyone/var/lib/mongo
~/.fiftyone/bin/mongo --shell

db.adminCommand({getParameter: 1, featureCompatibilityVersion: 1})
db.adminCommand({setFeatureCompatibilityVersion: "4.4"})
db.adminCommand({getParameter: 1, featureCompatibilityVersion: 1})

Yes, I will add a revision to this PR.


uBiome form update

@madprime: looks good, 👍!

[Current coverage][cc-pull] is 88.14%

Merging [#519][cc-pull] into [master][cc-base-branch] will decrease coverage by <.01%

@@             master       #519   diff @@
==========================================
  Files           236        236
  Lines         10160      10156     -4
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           8956       8952     -4
  Misses         1204       1204
  Partials          0          0

Powered by Codecov. Last updated by [949f18e...0367d0a][cc-compare]
[cc-base-branch]: https://codecov.io/gh/PersonalGenomesOrg/open-humans/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/PersonalGenomesOrg/open-humans/compare/949f18e52df7fdeeeac825ea9d752e3a29233fa4...0367d0a1d9c01f94f26e26968bd7d9baa79994da
[cc-pull]: https://codecov.io/gh/PersonalGenomesOrg/open-humans/pull/519?src=pr


V11, How to add native fetch params?

new Zodios(definitions, {
  fetchConfig: {
    credentials: 'include',
  } as any,
});

I have to cast to any to skip type error, Not sure if this is the recommend way to add native fetch parameters, looks like zodios just forward these props.
https://github.com/ecyrbe/zodios/blob/feature/v11/packages/fetch/src/fetch-provider/fetch.types.ts#L3-L9
https://github.com/ecyrbe/zodios/blob/feature/v11/packages/fetch/src/fetch-provider/fetcher-provider.fetch.ts#L35-L51
maybe we need to improve the FetchProviderConfig typing?

I have no issue autocompleting,

check your ts config file, and enabling "dom" lib should fix your issue :
{
  "compilerOptions": {
    "lib": ["ES2019", "DOM"],
     ...
  },
 ...
}


'Buffer slices can not be empty'

Hi,
I'm not sure if I've run into a bug or I've misunderstood something, but could you try this code ?
in Cargo.toml
egui = "0.11"
epi = "0.11"
egui_wgpu_backend = "0.7"
egui_winit_platform = "0.6"
wgpu = "0.8"
winit = "0.24"

before the event_loop :
let width_image = 32;
let height_image = 32;
let mut pixels = Vec::<egui::epaint::color::Color32>::with_capacity(width_image*height_image);
for _ in 0..width_image*height_image {
    pixels.push(egui::epaint::color::Color32::from_rgb(0,128,0));
}
let mut texture_ids = Vec::<egui::TextureId>::new();
for _ in 0..20 {
    texture_ids.push(egui_rpass.alloc_srgba_premultiplied((width_image, height_image), &pixels) );
}

and in the event_loop :
let w1 = egui::Window::new("Window");
w1.show(&ctx, |ui| {
    let scroll_area = egui::ScrollArea::from_max_height(480.);
    scroll_area.show(ui, |ui| {
        for id in &texture_ids {
            ui.image(*id, (width_image as f32, height_image as f32));
        }
    });
});

and should end up with :
thread 'main' panicked at 'Buffer slices can not be empty', /home/frank/.cargo/registry/src/github.com-1ecc6299db9ec823/wgpu-0.8.0/src/lib.rs:1733:39

thanks,

Should be fixed by this https://github.com/gfx-rs/wgpu-rs/pull/894

thanks.


Improve fan speed controls

This change makes the fan speed controls work better in a few ways:

The fan slider snaps to 20% increments, corresponding to the 5 fan speeds supported by the Kumo API.
The previous mapping from slider percent to Kumo API values would fail for part of the slider range due to the valid values being 0,1,2,3,5,6 (no 4). This is resolved.
When turning on the fan by setting it to active ("Hey Siri, turn on the Living Room AC Fan"), it now turns on to max speed instead of min speed.
When turning off heating/cooling, the system mode is set to fan if a specific fan speed had been set; otherwise the system power is turned off. Other interactions between fan speed, mode, and "active" states are improved as well.
With the above improvements to handling active states, the "Power" switch seemed redundant, so I removed it. Please review this choice, as I'm not sure if some people might have been using this switch in some way I'm not aware of.

I tested these changes with both direct and cloud APIs. Some additional verification from another user/developer might be helpful, since there are some complex interactions here.
All of the changes are applied only to the "ductless" device class. Some of the improvements could be ported to the "simple" or generic device classes; please advise if you think this is necessary.

I have another big change coming up that builds on this one, that supports disabling some functions. (I only care about air-conditioning and fans so I don't want to see a mode selector that offers heating.) But I'm going to bring that later as a separate PR, so they will each be easier to review.

@jasongin With these improved fan selection options, how do you specify an "auto" fan speed?

With these improved fan selection options, how do you specify an "auto" fan speed?

If the AC is on and the fan speed control is set to off, then fan runs in "auto" mode. If the AC is off and the fan speed is set to off, then the system is fully off.


backout env w from grid mean w and updrafts

Adding the grid mean w to the update aux of the EDMF

Bors r+


Fullscreen Mode btn

Hi, I am using JCVideoPlayerStandard.
I can change the button image by player.fullscreenbtn.setImage
But how can I change the button image after fullscreen mode?

if (currentScreen == SCREEN_WINDOW_FULLSCREEN) {

}else if(currentScreen == SCREEN_LAYOUT_NORMAL){

}

I want to change the Shrink btn after fullmode

Extends JCVideoPlayerStandard
@Override
    public void setUp(String url, int screen, Object... objects) {
        super.setUp(url, screen, objects);
        if (currentScreen == SCREEN_WINDOW_FULLSCREEN) {
            shrinkButton.setBackground();
        }
}


Redesign: Carousel - UI Adjustment (responsive, dark-mode, hover, and scroll)

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] PR closes #3947
[x] adjust carousel for mobile
[x] adjust carousel for dark mode
[x] add hover interaction
[x] support scroll wheel

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

just to make it clear for others, in order to test this you need to visit https://deploy-preview-3951--koda-nuxt.netlify.app/?redesign=true
not sure if this was here before but the choice to remove one of the navigating arrows whenever there aren't more items in direction of arrow causes me to accidentally navigate to the item:
https://user-images.githubusercontent.com/73316633/190623625-4a536396-73a0-4eb0-86ec-6b3ed413a757.mp4

why did you need to import a new package for slider? Oruga & Buefy have some very simple ones to set up

Aah, I didn't aware of this one. I replace buefy carousel with an agnostic carousel because later on no need to migrate the carousel component again when we migrate from vue2 to vue3.
does the oruga next version has backward compatibility with the latest version? seems like the next version doesn't have animation when slides. and some of the specifications are still in progress maybe? for example, events and slots in carousel component are still empty

https://oruga.io/components/Carousel.html
https://vue2.oruga.io/components/carousel.html

could you move scss stylesheet to /styles/components
are you sure when to choose px over rem? (.dot, .arrow etc..)
are we not going to get confuse with useSpotlight and spotlight page?

not sure if this was here before but the choice to remove one of the navigating arrows whenever there aren't more items in direction of arrow causes me to accidentally navigate to the item:

good points, I will update it. currently, the arrow will be disabled when reaching the end of the carousel. seem like the Figma is still missing styles for the disabled arrow

does the oruga next version has backward compatibility with the latest version? seems like the next version doesn't have animation when slides. and some of the specifications are still in progress maybe? for example, events and slots in carousel component are still empty

code looks same oruga-next vs oruga might be missing some content in docs-next (still WIP I think)

code looks same oruga-next vs oruga might be missing some content in docs-next (still WIP I think)

I see, I will test/explore oruga carousel then

hi @roiLeo, is it ok to try oruga carousel in a different PR? I need to explore their some events prop

Yup no problem we didn't even start to include/setup oruga packages

maybe truncate text on mobile as we can't see arrow

or I would enlarge the card size

do we need to ask the designer first? it could happen on the desktop also

just add overflow: hidden;text-overflow: ellipsis; on collection name and it will do the job

@yangwao not sure what the payout should be here, please check

pay 100

😍 Perfect, I’ve sent the payout
💵 $100 @ 41.75 USD/KSM ~ 2.395 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x691ab5f2d5a2806480a0c8204b5f078525d8ed46e2437120b08df189f229aeb6
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


MSIRGB Scripts not starting on startup

I have to open the MSIRGB application everytime and click the script i want. Any way so that my script runs everytime i turn on my computer? It is very annoying to run MSIRGB everytime i turn on my pc.

The moment you open the application and check the script you want to use it should register a Windows service that will run at boot, this will not happen if you don't run application as admin (it should auto-ask you on launch).
Make sure you do not move MSIRGB folder anywhere after doing this or it will not work, it will have to be in one place to work.
Start->Run->"services.msc" and check for "MSIRGB Script Service".

Yes MSIRGB Script Service is in services.msc. The problem that is happening is if i completely shut down my computer then turn it on then msirgb doesnt run on startup. But if run the application and then restart or put computer to sleep and turn on then msirgb keeps working. The problem happens when i completely shut down and turn on my pc

On 22 Jun, 2020, at 10:43 PM, jacklul<EMAIL_ADDRESS>wrote:

The moment you open the application and check the script you want to use it should register a Windows service that will run at boot, this will not happen if you don't run application as admin (it should auto-ask you on launch).
Make sure you do not move MSIRGB folder anywhere after doing this or it will not work, it will have to be in one place to work.
Start->Run->"services.msc" and check for "MSIRGB Script Service".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

This is a known issue. MSIRGB fails to run on a cold boot. Still don't know why. Unfortunately, I don't have access to my desktop to fix this right now, so it'll have to wait (can't tell you how long - weeks, maybe a month).

What can I do if the service is not there?

Closing as it is a duplicate of #43. Please refer to that issue for info on the status of the fix.


Pass labels from vm to pod to make service selectors work like expected

Pass vm labels to pods, so that services, network policies and others can rely on vm labels, like they can on pod labels
Add tests to verify that a service can really select a vm by its label and route the traffic properly
As a side-effect fix netcat  based network tests which were broken (they always succeeded, no matter what happend)

@duyanyan FYI

@yuvalif FYI

retest this please

I miss some By steps,
like By("Creating the job pod ...)
Except this lgtm

@cynepco3hahue tried to address that. Let me know if you want more.

I did see the jobs fail many times before. However, it was mainly when there was completely no connectivity between pods/nodes.

@vladikr yes, I am not even sure if it was related to that, since it turned out that nc was not event installed on image.


Including functional header to use std::function

Fixing build error function in namespace std does not name a template type

ugh, we didn't catch it because we do unity builds. Thank you.

@amartya00 which compiler did you see this error with?

Hello!
My compiler version is g++ 7.3.0
My system is ubuntu 18.04.
Thanks!
-Amartya


[SYSTEMML-1437] Factorization Machines - Binary Classification

Implements Binary Classification script.

I will come here, shortly!.
Hi @dusenberrymw , my github @ mentions are not giving me the notifications for some reason, I'm deeply sorry for not knowing the @j143 mentions. Please, consider mailing me instead.

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2259/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2265/

Hi @dusenberrymw , please leave some comments over the change set. Thanks.

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2262/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2297/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2312/

Hi @dusenberrymw , I ran the functions to make sure they are working (but, I do not know correct or not).
Running the file spark-submit  target/SystemML.jar -f staging/fm-binclass.dml for a dummy response.

Hi @dusenberrymw , @krishnakalyan3 ,
I ran binary classification script, with the result :Epoch: 100, Iter: 100, Train Loss: 0.05560625513997489, Train Accuracy: 1.0, Val Loss: 0.05331218854017246, Val Accuracy: 1.0

@dusenberrymw  all set!

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2332/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2333/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2327/Failed Tests: 4SystemML-PullRequestBuilder/org.apache.systemml:systemml: 4org.apache.sysml.test.integration.functions.compress.ParUnaryAggregateTest.testSumDenseConstantDataCompressionorg.apache.sysml.test.integration.functions.compress.ParUnaryAggregateTest.testSumDenseRoundRandDataDDCCompressionorg.apache.sysml.test.integration.functions.compress.ParUnaryAggregateTest.testSumDenseRoundRandDataOLECompressionorg.apache.sysml.test.integration.functions.compress.ParUnaryAggregateTest.testSumDenseRandDataCompression

@dusenberrymw , let's move this forward & other forward.
fm::init(n, ..), I will resolve in another PR.

please consider merging this one.
@dusenberrymw

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2347/

@j143 - While this particular change maybe ok, in general, I would rather that you wait for a LGTM on your PR before merging code into master.

This PR was open a very long time and having this DML script in the staging directory can allow others to try out the script while recognizing that some additional work may need to be done, which can be handled in other PRs. So although in general a LGTM is good to have, I think it's taken too long to get a LGTM here for code that is only moving to scripts/staging.

@nakul02 - Yeah, sure.


Convert this to a collection

Converting this to a collection would make it easier to use until the modules are pulled in to a community collection.

Before I dive in and even think about contributing to this issue, anyone else actively working on it?

Before I dive in and even think about contributing to this issue, anyone else actively working on it?

I am not working towards this at the moment. My plan is to start working towards getting kld in to community.general.

I am not working towards this at the moment. My plan is to start working towards getting kld in to community.general.

Thanks - I'm mostly need sysrc at the moment.  Will probably fork.
re: community.general, LMK if you want help with the same thing for sysrc.

Thanks - I'm mostly need sysrc at the moment.  Will probably fork.
re: community.general, LMK if you want help with the same thing for sysrc.

sysrc is likely going to be in the next release of community.general, which is due this month. So I'm looking forward to deleting all the copy/paste versions of sysrc I have lying around.

sysrc is likely going to be in the next release of community.general, which is due this month. So I'm looking forward to deleting all the copy/paste versions of sysrc I have lying around.

Can this be closed out now? Might be worth updating the readme to let people know to use community.general.sysrc.

sysrc has been moved to the community.general collection. kld will be following.


Z-Fighting in various spots along the Karamja shoreline

Description
When the shadows setting is turned on there is multiple spots along the Karamja shoreline where you can observe Z-Fighting.
Reproduction
Steps to reproduce the behavior:

Go to south of the Karamja volcano
Make sure the shadows setting is turned on
Walk along the shoreline
Observe Z-Fighting in various spots

Expected Behavior
None of the blocky z-fighting shadows.
Screenshots

Environment:

OS: Windows 10 Pro
RuneLite version: 1.7.24
Launcher version:  2.1.3

I believe this was fixed by efe699adfaf7575b05516304446c8fcb39803d6f please reopen if you experience this again


Move generic inference from FunctionCall, clean it up, make it recursive and use findCommonRoot on all candidates to get the final type.

Right now, it really just is a series of hacks for specific cases.
I think we should split it out in algo/genericInference (or something similar), with the following API:

extractTypeArg: func (typeArg: String, type: Type) -> Type (assuming type is fully resolved, null means there is no typeArg match)
inferTypeArg: func (typeArg: String, types: ArrayList) -> Type (iterates over types, extracts their candidates, if any, then returns their common root)


OVAL updates

Does the docker version of openVAS use https://oval.cisecurity.org/repository/download  ?
when I checked the OVAL listen in openVAS thet all seemed very old.

We use whatever is shipped in the default version of openvas.
Please reopen if you have additional questions!


Updated type for pluck

Pluck is probably one of our more well used Ramda functions. If we see map(prop(...)) during code review we'll typically change it to a pluck. I recently wrote some code that was using map(prop()) to pull some values off a nested object, and of course it was pointed out that pluck could be used there as well.
While obvious in retrospect, it isn't obvious from the documentation that pluck can be used on things that aren't arrays. To me, this behavior seems useful, and isn't ad-hoc due to the Functor instance for objects.
I understand the desire for the docs to be easily understandable, and I know that Functor is less well known in the JS community than Array is. I don't want to remove the idea that this function operates on lists, simply add in the idea that it will work with other Functors as well.
I wasn't really sure what to do with the jsdoc annotations.  Looking at map it still has Array as the type for the second parameter and return value, so I left that here as well.

:+1:

I think it would be useful to mention the equivalence between pluck and map + prop.

:cow2:


plugins from file

Coverage decreased (-0.04%) to 87.039% when pulling 133bb9e5fbb7cea5b3bb2c85a3ba8ff99f58b666 on plugins_from_file into 477f18b4cf3e1d7670b03c9130d0beb3420e3fb3 on master.

Coverage decreased (-0.04%) to 87.039% when pulling 133bb9e5fbb7cea5b3bb2c85a3ba8ff99f58b666 on plugins_from_file into 477f18b4cf3e1d7670b03c9130d0beb3420e3fb3 on master.


Please update version

Hi,
please bump the version for your last fixes :)
The zoom behaviour is now a lot better and feels more natural thanks!

Nils

Want to integrate all these abandoned PRs first - sorry :D


Regenerate the ShEx bundle

According to the PR #23, current shex bundle has some issues and requires regeneration (or substitution with shex npm module).

Should be fixed by PR #26


Build failure building F# OSS codebase with CTP 5 installed

Fails to build the fsc-proto compiler: with the following spew
msbuild src\fsharp-proto-build.proj
CoreCompile:
......\lkg\FSharp-4.0.30319.1\bin\fsc.exe -o:obj\Proto\net40\FSharp.Build-proto.dll -g --noframework --define:DEBUG --define:NO_STRONG_NAMES --de
fine:NO_STRONG_NAMES --define:NO_STRONG_NAMES --define:BUILDING_WITH_LKG --define:DEBUG --define:NO_STRONG_NAMES --define:OPEN_BUILD --define:FSHAR
P_CORE_4_5 --define:FX_ATLEAST_45 --define:FX_ATLEAST_40 --define:FX_ATLEAST_35 --define:BE_SECURITY_TRANSPARENT --define:QUERIES_IN_FSLIB --define
:PUT_TYPE_PROVIDERS_IN_FSCORE --define:FX_ATLEAST_LINQ --doc:......\Proto\net40\bin\FSharp.Build-proto.xml --optimize+ --resource:obj\Proto\net40
\FSBuild.resources -r:C:\visualfsharp\lkg\FSharp-4.0.30319.1\bin\FSharp.Core.dll -r:"C:\Program
...
C:\visualfsharp\src\fsharp\FSharp.Build\Fsc.fs(256,14): error FS0034: Module 'Microsoft.FSharp.Build' contains     member Fsc.Sources : '_a     but i
ts signature specifies     member Fsc.Sources<'a0> : 'a0 []     The respective type parameter counts differ [C:\visualfsharp\src\fsharp\FSharp.Build-
proto\FSharp.Build-proto.fsproj]
C:\visualfsharp\src\fsharp\FSharp.Build\Fsc.fs(252,14): error FS0034: Module 'Microsoft.FSharp.Build' contains     member Fsc.Resources : '_a     but
its signature specifies     member Fsc.Resources<'a0> : 'a0 []     The respective type parameter counts differ [C:\visualfsharp\src\fsharp\FSharp.Bu
ild-proto\FSharp.Build-proto.fsproj]
C:\visualfsharp\src\fsharp\FSharp.Build\Fsc.fs(243,14): error FS0034: Module 'Microsoft.FSharp.Build' contains     member Fsc.References : '_a     bu
t its signature specifies     member Fsc.References<'a0> : 'a0 []     The respective type parameter counts differ [C:\visualfsharp\src\fsharp\FSharp.
Build-proto\FSharp.Build-proto.fsproj]
Exiting - too many errors
Done Building Project "C:\visualfsharp\src\fsharp\FSharp.Build-proto\FSharp.Build-proto.fsproj" (Rebuild target(s)) -- FAILED.

It's actually caused by not having MSBuild from Visual Studio 2013 installed.
Kevin

I installed Microsoft Build Tool 2013 but the build still fails:

FSC : error FS0082: The primary reference "C:\Windows\Microsoft.Net\assembly
GAC_MSIL\Microsoft.Build\v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a\Microsoft.Build.dll" c
ould not be resolved because it has a higher version "<IP_ADDRESS>" than exists in
the current target framework. The version found in the current target framework
is "<IP_ADDRESS>". (Code=MSB3257)

It seems to work on a machine with both VS 2013 and VS 2015 CTP 5 installed.

This looks like a duplicate of https://github.com/Microsoft/visualfsharp/issues/182?

Yes, seems same as #182


Upgrading Client Lib to API v2?

What did you do?
Used the client library in this repo (https://github.com/prometheus/alertmanager/blob/main/client/client.go)
What did you expect to see?
It use the v2 api
What did you see instead? Under which circumstances?
It's hardcoded to use the v1 api (https://github.com/prometheus/alertmanager/blob/main/client/client.go#L32)
Is this maintained? I note that it hasn't been touched in a year and a bit. Considering the expected deprecation of the v1 api we should probably update it or deprecate it along with the API (I would be in favour of the former)

The v2 client is https://github.com/prometheus/alertmanager/blob/main/api/v2/client/alertmanager_client.go

Would you send a PR to remove the v1 client?

Ah. Good to know. Yes sure


render full mention content if it's short enough (default to <= 300 chars)

here are some examples of this: https://snarfed.org/2016-06-11_decentralized-web-summit#comment-2599187
some are ugly because their sites' mf2 is missing or incomplete, e.g. @kevinmarks's :P

thanks!

Hm, that's my known site, so should have good mf2
On 25 Jun 2016 2:58 pm, "Ryan Barrett"<EMAIL_ADDRESS>wrote:

thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pfefferle/wordpress-semantic-linkbacks/pull/64#issuecomment-228572453,
or mute the thread
https://github.com/notifications/unsubscribe/AAGCwO2RwGztHZZ_2YRLSZuWQcnJEKuIks5qPaRzgaJpZM4I-bVn
.

@kevinmarks I think @snarfed had kind of a similar problem a while ago... The test is starting with a tab or several whitespaces and @snarfed is using a plugin which interprets it as a code block...

true! i was actually thinking about the extra stuff, though, not the formatting. it looks like http://known.kevinmarks.com/2016/decentralized-web-summit-snarfedorg is a like, but it doesn't have u-like[-of] (here's the parsed mf2), and it doesn't have e-content or p-summary either, so the whole h-entry gets dragged in. maybe it's an old version of known?
anyway. definitely not a big deal!


Need to target localhost for localhost:6490/evaluatepolicy with proxy to authenticate to login.microsoft.com

We run into an issue running an API call to localhost:6490/evaluatepolicy when the proxy is enabled.  We tried adding localhost to NO_PROXY but that did not work.  We need to keep the proxy in place to make an authenticate to azure call in VS Code, because that is the only way my customer may authenticate in VS Code.  Here is their feedback on the issue:

When connected to my company’s VPN, we need to use a proxy to call Connect to Azure from VS Code, so that we may authenticate

NO_PROXY settings have both included and excluded “login.microsoft.com” to ensure authentication can take place. I have seen authentication fail at times both because that value was included and excluded from the NO_PROXY setting, which might be a separate but related issue. We receive 504 status codes regardless of that configuration and the configurations listed below.

When the proxy is in place, we are prevented from making a call to localhost:6490/evaluatePolicy on the Azure Policy Extension.

When we add the localhost to the NO_PROXY in VS Code, we do not see the expected outcome. We receive a 504 status code.

When we configure the LAN Settings within Internet Properties to Bypass proxy server for local addresses, we still do not see the expected outcome. We receive a 504 status code.

When proxy settings are completely disabled and I am disconnected from my company’s VPN, which is not acceptable workaround, the call to localhost:6490/evaluatePolicy on the Azure Policy Extension works as expected.

VS Code Dev Tools team recommends reaching out to the VS Code GitHub support team to evaluate further.

My alias<EMAIL_ADDRESS>

localhost should automatically be excluded from being proxied.
Could you install the Network Proxy Test extension (https://marketplace.visualstudio.com/items?itemName=chrmarti.network-proxy-test) and check the output of F1 > Network Proxy Test: Test Connection in VS Code with "http://localhost:6490/evaluatepolicy"?
It sounds like the 504 is indicating a problem with your local service, but I might be missing some details here.

Here is the feedback we have on that test:
Note: Make sure to replace all sensitive information with dummy values before sharing this output.
VS Code 1.78.1 (6a995c4f4cc2ced6e3237749973982e751cb0bf9)
Network Proxy Test 0.0.6
win32 10.0.22000 x64
Settings:

http.proxy:
http.proxyAuthorization: null
http.proxyStrictSSL: true
http.proxySupport: override
http.systemCertificates: true

Environment variables:
HTTPS_PROXY=http://[username redacted]:[password redacted]@naproxy.gm.com:80/
HTTP_PROXY=http://[username redacted]:[password redacted]@naproxy.gm.com:80/
NO_PROXY=gm.com
Sending GET request to http://localhost:6490/evaluatePolicy...
vscode-proxy-agent: DIRECT
Received response:

Status: 404 Not Found

That looks good, I assume. I suggest you investigate the 504 on that URL for your request.


Release new version to update dom5?

According to this commit the update dom5 to v2, include parse5 already happened: https://github.com/PolymerLabs/css-slam/commit/98fadabd5be6446c973c4356b387d994ca7f9ba7
But it's unreleased. We have a --flat yarn install and also depend on<EMAIL_ADDRESS>which uses<EMAIL_ADDRESS>That is why we need to resolve dom5 to at least version 2.0.0 but doing so causes build errors for css-slam:

So I think all errors could be resolved if this lib would get the dom5 v2 update. Could somebody (maybe @azakus 😄 ) release a new version with the updated dependencies?

Ooops, looks like this was already updated to dom5 v2 in master a while ago, but never released.


Block indent_style for attributes?

Is there a config to let me change the default formatting of
#![forbid(bad_style, future_incompatible, missing_debug_implementations, missing_docs,
          unconditional_recursion, unsafe_code, unused, unused_imports)]

to
#![forbid(
    bad_style,
    future_incompatible,
    missing_debug_implementations,
    missing_docs,
    unconditional_recursion,
    unsafe_code,
    unused,
    unused_imports,
)]

?
Apparently indent_style does not apply here, and there's no single reference to attributes in <Configurations.md>.

In the RFC for attribute:

For attributes with argument lists, format like functions.

so probably we should use the block indent by default, and let indent_style config option apply to attributes as well? Though AFAIK there has not been much discussion on how to format attributes with argument lists.

Closed via #2809.


Accessors

This sprawling PR adds support for accessors throughout the library, thus addressing #360. It modifies the way that scales are built, by replacing a default notion of attr with a comprable notation of accessor, while adding default accessors that emulate the original behaviour. (Hopefully) This change is non-breaking, in that all old charts should still work, with the new accessor functionality enabled.
Note: one of the original goals of adding accessors was to enable immutable manipulations, and while were close, there is probably one or two more PRS worth of clean up around the library that needs to be done first. (i'm looking at you, several for loops still left in the library)
There still needs some documentation, but should be ready to review.

In deck.gl accessors are consistently called get...: getSize, getAngle etc. (although getX sounds a little strange?)

I guess react-vis has a slightly different API pattern? Generally when specifying a property about a dimension (eg the type of scale to be used or the domain) we specify that as xType or xDomain. I'm not opposed to copying deck.gl's api style, I just felt like the right move was to be consistant within the library first, and change later?

the right move was to be consistant within the library first, and change later?

That does make sense. Although given today's conversation I think we'd want to decide and possible change before we publish an official version.
I am not sure how the branching strategy in react-vis works, how long master can live without being published etc. If we land this, are we creating an urgency to decide and update?

I am not sure how the branching strategy in react-vis works, how long master can live without being published etc. If we land this, are we creating an urgency to decide and update?

Generally our strategy has been to develop on master, however if we want this to be part of some sort v2 release, we could hold all new pieces on a separate branch. I'm in no huge rush to get this is, so whatever is fine.

Bump for review?

@mcnuttandrew Based on conversations with @jckr I came away with the sense that we want accessor names to be aligned with the suite (i.e. deck.gl) from the start, rather than introduce one set of names one month and then introduce a completely different set next month. At the same time, the deck.gl alignment might (at least initially) only cover a small part of the charts.

While I appreciate that it is good to have things consistent across the suite, I think it is, perhaps, more important to have them be consistent within each library. The react-vis pattern is xType, xDomain, etc, so it seems like it makes sense to continue that into xAccessor? I guess if you really wanted to be consistent across the suite, react-vis would need to move to a naming convention like getXType getXDomain etc? But that seems kinda awkward to me?
I don't have a strong opinion, I'd mostly just like to get this merged in so that it doesn't to be defended against merge conflicts.

I guess if you really wanted to be consistent across the suite, react-vis would need to move to a naming convention like getXType getXDomain etc? But that seems kinda awkward to me?

Yes that is what is being proposed. In effect, we are trying to understand whether react-vis should be part of the suite or live alone. If part of the suite, there needs to be a story and a plan that gradually ties things closer together. No decisions made, just discussions at this point. I don't have specific goal in mind, I am mostly getting involved because I think react-vis deserves a strong vision and roadmap, and suite alignment could provide that.

Yeah that's the plan. if we do add accessors which your PR allows us to do then it's a great opportunity to move towards suite alignment and to revise the whole syntax of the API.

From a user standpoint this PR(in what ever form) would be a big help, and save a lot of extra data manipulation.

From a user standpoint this PR(in what ever form) would be a big help, and save a lot of extra data manipulation.

if we do add accessors which your PR allows us to do then it's a great opportunity to move towards suite alignment and to revise the whole syntax of the API.

I took a second look. My take is that if we just update this PR to follow the getX instead of xAccessor naming pattern, this would be a major move towards suite alignment and we could do additional syntax revision in a second step.
We could get the accessors into react-vis today in a backwards compatible minor version with minimal effort, score a big alignment win, and save a bigger API overhaul for a later major version.
That said, if I was reviewing another framework in our suite, I would ask that the component doc pages and a "What's New" doc page to be updated in this PR :)

@ibgreen Those are reasonable notes! I can take a shot at getting this wrapped up this weekend.

Alright, I have moved all of the accessors over to the getX pattern. Currently this PR is non-breaking, but so it can be slid in without a fuss. I didn't update the documentation in a more sprawling way, because I figured we'd only want to do that once every property had been moved to the getXType pattern. That said, I still want to argue against using getXType: getX makes sense you are providing a function to get something, while getXType does not, XType is a static string that won't change over time.

There's still a couple of things still to do, like moving nullAccessor to be getNull, and I've open an issue to that effect (#661).
Following @ibgreen's suggestion i've also open an issue to make a what's new page (#662)

bump for review (@balthazar or @ibgreen or ...?)


Address Pool Is Wrong - Overlaps with Virtual Network Address Space

If you follow the guide at https://learn.microsoft.com/en-us/azure/vpn-gateway/vpn-gateway-radius-mfa-nsp
You are instructed to create a Gateway Subnet, and then use the same subnet as the P2S client IP pool.
The document states "Address pool: Type the gateway subnet you created in the step 1." -- however this cannot be used as its part of the Virtual Network and will receive the error "The virtual network gateway's VPN client address pool overlaps with the virtual network's address space."
The system will not allow you to use a pool that is within an existing Virtual Network. The Gateway subnet is within the Virtual Network, so this cannot be used.
You need to use an entirely seperate, not-yet-defined subnet, outside of your virtual network.
As mentioned in issue #27351, the error is "Error: The virtual network gateway's VPN client address pool overlaps with the virtual network's address space.". However in issue #27351 the accepted solution is to make the "Gateway address pool" outside the virtual network. This doesn't fix the documentation, which shows an example of using the same "Gateway subnet" address pool as defined in the document.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6298aba8-c953-c7c1-3630-421639631b70
Version Independent ID: b552f7ae-0c8f-2bfc-a47e-131807b7e613
Content: Integrate NPS with VPN Gateway RADIUS authentication for MFA - Azure VPN Gateway
Content Source: articles/vpn-gateway/vpn-gateway-radius-mfa-nsp.md
Service: vpn-gateway
GitHub Login: @AhmadNYasin
Microsoft Alias: genli

@lazynooblet
Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

Thanks! I'm going to flag this for a full review and take a doc bug on it.

#please-close


Omnisharp does not update classes after folder insertion in the solution folder

Unfortunately the title is not the best and I hope I can be more clear here.
I was doing an assignment for university in C# and started typing. However, I realized I forgot to add my tutors framework inside the project and because of that his functions started to point errors. After copying his folder the errors were still there. Opening the file again, the errors were gone.
Other things that I tried and no results were obtained:

Save the file and then run :e %
Run :!dotnet add package MonoGame.Framework.DesktopGL --version <IP_ADDRESS>1
Do the second and then the first one.

If I do the same thing on VSCode (I use it for debugging), the errors disappear straight away.
Thanks,
Eduardo

If you make a change to a project then you'll need to restart the server. VSCode does some of this automatically using file watchers but we don't.
Just restart the server with :OmniSharpRestartServer


Bring us localized end-user spam notifications!

We need notifications that follow the user's preferred language. How do you expect that in a company with worldwide presence everyone can read and understand english?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c7b5bbb4-4c14-9637-6834-02f0e3e95261
Version Independent ID: da93570d-ecbc-d0c3-63c2-7445f7ba29b3
Content: Configure end-user spam notifications in Exchange Online
Content Source: microsoft-365/security/office-365-security/configure-end-user-spam-notifications-in-exchange-online.md
Service: o365-seccomp
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

@marc-fom  - Thank you for engaging with the community here for the docs.
I know the product teams are always looking for user feedback and feature request on how to make Microsoft 365 better. They keep a close tab on user feedback and it would be awesome if you could add your voice in UserVoice.
You might find others have made a similar request that you can add to, or you can open a new one. Let us know here if you do so we can up-vote your request.
Thank you for your contribution to make the docs better! Much appreciated!


Reconsider Foo<> means default instance

From design discussed here https://github.com/microsoft/typespec/issues/1163. Creating a new issue as that design discussion had 2 part and 1st is still relevant. This is to rediscuss the 2nd part.
It was decided that given a template
model Template<T  = string> {
  x: T
}

Template<> would reference the default instance (Template<string>)
Template would reference the uninstantiated template

The thing is right now Template means the default instance already, so this change would not only be a breaking change but I think relatively confusing for spec writers.
https://cadlplayground.z22.web.core.windows.net/?c=bW9kZWwgTTxUID0gc3RyaW5nPiB7CiAgeDogVDsKfQoKYWxpYXMgTURlZmF1bHRJbnN0YW5jZSA9IE07CgrGPkTFMmQxOtEnLng7Cn0%3D
with this issue https://github.com/microsoft/typespec/issues/1774 also now on the table I think we might want to reconsider the augment decorator scenario which is as far as I can tell the only place where we want to reference the uninstantiated template

We seem to be very confused about what Template means:

Notice that the alias is unused but somehow has an impact on things.
I think that I initially said on #1774 that Template was uninstantiated because I did a quick test like above without the alias.


TabPage - paths with lazy initialization ?

Trying to lazy load sets of pages with deferred as directive to split js files.
Since paths are all triggered when arriving on this "tab page", all pages (i.e. js files) are loaded which is counter-productive with the given directive.
Also, I'm using it with TabBarView and there's 10 tabs... for now.
Will this be possible in the future ?

Hi, thanks for the issue - I'll take a look into it, I'd absolutely like this to possible.
Out of interest, do you know if the widgets are actually building, or is it just that the JS files are loading?

I exposed the issue with web context but this is unrelated. All tab routes are called, at start, when using TabPage.
I load js file in the route like this, so yes, even in web target, DashboardPage will be loaded:
'/dashboard': (route) {
  return MaterialPage(child: FutureBuilder(
    future: dashboard.loadLibrary(),
    builder: (...)  { ... return dashboard.DashboardPage(); },
  );
},

Hi, thanks for the issue - I'll take a look into it, I'd absolutely like this to possible.
Out of interest, do you know if the widgets are actually building, or is it just that the JS files are loading?

I really hope that the tab widgets are not loaded all at once...

@bdremynoel I believe I'm right in saying that deferred as won't split JS files, as deferred components are only available on Android.

Closing this in favour of #149

This is the same idea as deferred components on Android platform. (Absolutly not the same tech behind though).
Here's a ref on this feature on web platform.
On web platform, this feature is implicit since JS file loading is managed by the browser.

Interesting, thanks! Shame the Flutter docs on deferred loading don't mention web.
From an app developer's point of view it looks like the exact same Dart syntax, so let's tackle it all in #177


As a user, I want to view which requirements are edited and want edits to be saved properly

If a requirement is edited, show that it is edited in the right side of the table cell
Implement reset to previous button

i closed the wrong issue lol


Show no projects if there is no projects

Fixes
https://github.com/CircuitVerse/CircuitVerse/issues/711
Describe the changes you have made in this pr
Show no projects if there is  no projects
Screenshots of the changes (If any) -

Coverage remained the same at 83.902% when pulling 241c3fb83e61036aa5c555e64c60c376581f802a on yash15601:no-projects into 232938ff7691ebb52fb12d19db15e634c9c95c57 on CircuitVerse:master.

@sal2701 Is this fine? or should there be a motivational message?

Should the target be _blank or should it redirect towards create new project page?

@Shivansh2407 when we click on here it will be redirected to simulator

@Shivansh2407 when we click on here it will be redirected to simulator

Cool Understood. I had misunderstood it earlier 👍

@Ananthavijay A motivational message or something similar to this link for Error 404 pages would be great. We can do it at a later stage.
@yash15601 For now we can just move the text in the PR to the center of the page because the page looks very empty and the text is in a corner.

@tachyons Please review

Done @tachyons  Review

Done @tachyons  Review

@tachyons  Done


Is "train_cobionet_semi.py" full supervision by default?

Is "train_cobionet_semi.py" full supervision by default?

No, use this script to train Co-Bionet in supervised setting: https://github.com/himashi92/Co-BioNet/blob/main/code/train_cobionet_sup.py

Thank the author for his reply， The running result of the script code/train_cobionet_sup.py: average metric is 0.7395.

Did you train with the given hyperparameters?

@liaochuanlin 请问你复现LA数据集了嘛？复现精度是多少啊


Translate "Advanced Algorithm Scripting" (advanced-bonfires.json) in Italian

Challenge Name
Advanced Algorithm Scripting (link to challenge)
Issue Description
Translate the challenge Advanced Algorithm Scripting in Italian

I'll be working on this 😄


 when rendered, has whitespace below where its rendered

Creates whitespace below the rendered component. How do I fix this?

 They have a bottom margin by default (MDN demo).


Hybrid Neutral Atom Mapper Functionality

Add Hybrid NA Mapper Functionality
This adds two things:

Move operation: Abstract operation describing the movement of an atom from one coordinate to another.
AodOperation: Describing the movements of the AOD to perform the above Move operation. The dump to qasm returns a format similar to qasm.

Checklist:

[x] The pull request only contains commits that are related to it.
[x] I have added appropriate tests and documentation.
[ ] I have made sure that all CI jobs on GitHub pass.
[x] The pull request introduces no new warnings and follows the project's style guidelines.

Finally found the time to go through this PR 😌 Overall the changes here look good 👍 I pushed two minor changes directly and added further smaller comments in the files themselves. Most of these should be pretty minor.
I have one medium-large question and one bigger question I'd like to get out of the way before proceeding here:
First, what about reading the produced QASM circuits back in? Right now, no adaptation on the QASM parser has been performed so far. So the produced QASM files cannot be read anywhere. While not a dealbreaker, it would certainly be nice to support that, wouldn't it?
Second, and probably the bigger question: @ystade recently introduced the na subcomponent in mqt-core and mqt-qmap, where he (amongst other things) also defined a ShuttlingOperation (with load, move, and store types). Now this PR implements essentially the same concept, but in a different fashion. While I would be ok with that in the short-term, this duplication is certainly no maintainable solution for the future. How hard do you think it would be to base your changes (especially those in QMAP) on @ystade's infrastructure for neutral atom computations? From the changes here, the QASM dump would be the most important thing to port to the existing NAComputation and NAOperation classes. (Expect me asking a similar question in the mqt-qmap PR)

Regarding the qasm import:
Back when I wrote the code I also added the correct parsing commands. This took me quite some time as I'm not really familiar with parsing in general. Unfortuantly in the meantime the parser was updated to support qasm3 which broke my version and I could not see an easy way to transfer my code. As for now, the only usecase where the parsing would be interesting is to schedule circuits which have been mapped and saved previously. This is indeed a possible/interesting option but currently not used by us and my knowledge on parsing is not sufficient to do some "quick fix" to that.
Regarding the NA unification:
Obviously, my code already existed before @ystade started with his part. We had some discussion back then on reusing the code but then decided to create two separate versions as a start as we required different things. A unification might probably be possible and would probably make sense for common export/import but currently this is a non-trivial task as we took different approaches to how we handle/represent the AOD moves.

Finally found the time to go through this PR 😌 Overall the changes here look good 👍 I pushed two minor changes directly and added further smaller comments in the files themselves. Most of these should be pretty minor.
I have one medium-large question and one bigger question I'd like to get out of the way before proceeding here:
First, what about reading the produced QASM circuits back in? Right now, no adaptation on the QASM parser has been performed so far. So the produced QASM files cannot be read anywhere. While not a dealbreaker, it would certainly be nice to support that, wouldn't it?
Second, and probably the bigger question: @ystade recently introduced the na subcomponent in mqt-core and mqt-qmap, where he (amongst other things) also defined a ShuttlingOperation (with load, move, and store types). Now this PR implements essentially the same concept, but in a different fashion. While I would be ok with that in the short-term, this duplication is certainly no maintainable solution for the future. How hard do you think it would be to base your changes (especially those in QMAP) on @ystade's infrastructure for neutral atom computations? From the changes here, the QASM dump would be the most important thing to port to the existing NAComputation and NAOperation classes. (Expect me asking a similar question in the mqt-qmap PR)

Regarding the qasm import: Back when I wrote the code I also added the correct parsing commands. This took me quite some time as I'm not really familiar with parsing in general. Unfortuantly in the meantime the parser was updated to support qasm3 which broke my version and I could not see an easy way to transfer my code. As for now, the only usecase where the parsing would be interesting is to schedule circuits which have been mapped and saved previously. This is indeed a possible/interesting option but currently not used by us and my knowledge on parsing is not sufficient to do some "quick fix" to that.

Fully understand that point. The new parser is structured quite a bit differently than the old one. Adding a parser for the new operations would definitely make sense in the future. Also triggered by the comment below, I would postpone that implementation to a point where we consolidated on the particular details when it comes to NA Compilation and how to represent the corresponding computations. At that point, this can be a student project. Might be worth tracking that in an issue.
It isn't valid QASM in either version of the standard.
For it to be valid, you would have to add an opaque gate declaration for the operation to the top of the file, eliminate the ; from the parameter list, and you'd have to somehow handle the fact that the parameter list can have arbitrary length.

Regarding the NA unification: Obviously, my code already existed before @ystade started with his part. We had some discussion back then on reusing the code but then decided to create two separate versions as a start as we required different things. A unification might probably be possible and would probably make sense for common export/import but currently this is a non-trivial task as we took different approaches to how we handle and represent the AOD moves.

It's obvious that this is a non-trivial task. It's still important to think about this early as I would really want to avoid to develop two completely separate strands of features here.
Just for clarification:
To me, the two AOD representations do not look fundamentally different. You choose to explicitly encode the direction and use floating point numbers for start and end coordinates.
@ystade chose to implicitly store the direction by assuming a 2D plane and using (x, y) (integer) coordinates for the start and end coordinates. Functionality-wise, these two are equivalent (at least in 2D and assuming the integer resolution is enough).
Do you really think that adapting your code to that class would be that much of an effort? Most likely, I am simply overlooking things given that I have not spent enough time with the QMAP code yet. So I am really interested in your judgement here.
If this is too much to ask for now (which is totally ok), then I'd at least like to have a clear plan on who has the responsibility to consolidate that in the future and a rough timeframe.

Fully understand that point. The new parser is structured quite a bit differently than the old one. Adding a parser for the new operations would definitely make sense in the future. Also triggered by the comment below, I would postpone that implementation to a point where we consolidated on the particular details when it comes to NA Compilation and how to represent the corresponding computations. At that point, this can be a student project. Might be worth tracking that in an issue. It isn't valid QASM in either version of the standard. For it to be valid, you would have to add an opaque gate declaration for the operation to the top of the file, eliminate the ; from the parameter list, and you'd have to somehow handle the fact that the parameter list can have arbitrary length.

Yes, exactly; this would probably be the way to go, also for the consolidated version below.

It's obvious that this is a non-trivial task. It's still important to think about this early as I would really want to avoid to develop two completely separate strands of features here. Just for clarification: To me, the two AOD representations do not look fundamentally different. You choose to explicitly encode the direction and use floating point numbers for start and end coordinates. @ystade chose to implicitly store the direction by assuming a 2D plane and using (x, y) (integer) coordinates for the start and end coordinates. Functionality-wise, these two are equivalent (at least in 2D and assuming the integer resolution is enough). Do you really think that adapting your code to that class would be that much of an effort? Most likely, I am simply overlooking things given that I have not spent enough time with the QMAP code yet. So I am really interested in your judgement here. If this is too much to ask for now (which is totally ok), then I'd at least like to have a clear plan on who has the responsibility to consolidate that in the future and a rough timeframe.

That's correct. As the basic functionality is quite clear (moving coordinates in 2D), I think both sides could be consolidated in a straightforward fashion conceptional-wise, but with small differences (e.g., I require floats instead of int) . An almost similar problem exists for the NeutralAtomArchitecture Class we used for the Mapping Tasks. For now I would keep the two projects separate and then discuss on an overarching Operation Class + Architecure Class in the following weeks, also in the context of a compiler collection.

I'll write the issues 👍


[Help needed] Laravel + Vue + Docker with Hot Reload

Laravel Mix Version: 5.0.9
Node Version (node -v): v12.14.1
NPM Version (npm -v):  6.13.4
OS: Linux

Description:
Hi Guys,
I'm setting up Laravel + Vue with Nginx and everything on docker... 95% is working, the only thing left is the hot-reload portion that is run on a node container.
I'm having trouble accessing the port 3000 that I've set up for my webserver.
The port is bound correctly on my machine, It shows as being used, but the app.js and app.css files are not being served correctly.
If I run npm run dev the code compiles and is served perfectly.
Below are the Files being used to build the docker environment.
# docker-compose.yml
version: '3'

networks:
  laravel:

services:
  nginx:
    image: nginx:stable-alpine
    container_name: nginx
    ports:
      - "80:80"
      - "443:443"
    volumes:
      - ./:/var/www/html
      - ./.nginx/default.conf:/etc/nginx/conf.d/default.conf
      - ./.certs/nginx-selfsigned.crt:/etc/ssl/certs/nginx-selfsigned.crt
      - ./.certs/nginx-selfsigned.key:/etc/ssl/private/nginx-selfsigned.key
    depends_on:
      - php
      - mysql
    networks:
      - laravel

  mysql:
    image: mysql:5.7.22
    container_name: mysql
    restart: unless-stopped
    tty: true
    ports:
      - "4306:3306"
    volumes:
      - ./.mysql:/var/lib/mysql
    environment:
      MYSQL_DATABASE: homestead
      MYSQL_USER: homestead
      MYSQL_PASSWORD: secret
      MYSQL_ROOT_PASSWORD: secret
      SERVICE_TAGS: dev
      SERRVICE_NAME: mysql
    networks:
      - laravel

  php:
    build:
      context: .
      dockerfile: Dockerfile
    container_name: php
    volumes:
      - ./:/var/www/html
    ports:
      - "9000:9000"
    networks:
      - laravel

  composer:
    image: composer:latest
    container_name: composer
    volumes:
      - ./:/var/www/html

    working_dir: /var/www/html
    networks:
      - laravel

  node:
    image: node:12.14
    container_name: node
    volumes:
      - ./:/var/www/html
      - ./.certs/nginx-selfsigned.crt:/etc/ssl/certs/nginx-selfsigned.crt
      - ./.certs/nginx-selfsigned.key:/etc/ssl/private/nginx-selfsigned.key
      - ./.hosts:/etc/hosts
    working_dir: /var/www/html
    expose:
      - "3000"
    ports:
      - "3000:3000"
    entrypoint: ['node']
    tty: true
    networks:
      - laravel

  artisan:
    build:
      context: .
      dockerfile: Dockerfile
    container_name: artisan
    volumes:
      - ./:/var/www/html
    depends_on:
      - mysql
    working_dir: /var/www/html
    entrypoint: ['/var/www/html/artisan']
    networks:
      - laravel

# webpack.mix.js
const mix = require('laravel-mix')
const path = require('path')

/*
 |--------------------------------------------------------------------------
 | Mix Asset Management
 |--------------------------------------------------------------------------
 |
 | Mix provides a clean, fluent API for defining some Webpack build steps
 | for your Laravel application. By default, we are compiling the Sass
 | file for the application as well as bundling up all the JS files.
 |
 */
mix.webpackConfig({
  resolve: {
    alias: {
      '@': path.resolve(__dirname, 'resources', 'app')
    }
  }
})

mix.options({
  hmrOptions: {
    host: 'localhost',
    port: 3000
  }
})

mix.js('resources/app/app.js', 'public/js')
  .sass('resources/scss/app.scss', 'public/css')

I've made some progress... It seems that node will only serve files if my host is <IP_ADDRESS> and that causes issues because I'm running under another domain.
How do I change the server to be able to serve files under another domain?


Need accordion view in Mobile resolution

Hi, Need accordion view in Mobile resolution .
Ex.

Not a trivial feature that might require significant code rewrite, keeping the issue open for further evaluation


Set source level of java and cart modules to 1.6

Nowadays the main source level of the toolbox is 1.8 (defined by it's parent pom).
However to prevent Android running into issues when using the toolbox we should set the source level of the used modules to 1.6
Ping @joezorry @silverpilen
P.S Sorry for wall of types :wink:

Not to be a pain, but actually it's 1.7, maybe should have said that. But 1.6 works fine too :smile_cat:, it's not like it's the end of the world not using the diamond.

Is that really true? What about try-with-resources for example?

Yeah, I think we need 1.6 to guard against  try-with-resources, or are you with another opinion @joezorry?

@adamvoncorswant @erikryverling you are correct sirs.  :+1:

OK, cool. So @joezorry whenever you have time, please review

Seems fine to me :)

Great!


rust-analyzer: 2021-04-05 -> 2021-04-12

Motivation for this change
Bump version
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 119211 at d05c84d8 run on x86_64-linux 1

3 packages built successfully:

rust-analyzer
rust-analyzer-unwrapped
vscode-extensions.matklad.rust-analyzer

@oxalica should I also squash that patch into version up?

@Riey

should I also squash that patch into version up commit?

I prefer to squash.


undefined is not an object (evaluating 'TrackPlayer.STATE_NONE')

Hello!
I can not make this library work in any way... I have observed this entry #102 and #96 , but I can not get it to work ... I have tried modifying the files ios/RNTrackPlayer/RNTrackPlayer.swift, I have tried installing "npm uninstall --save react-native-kit/react-native-track-player#dev ".
The error appears just by importing the library into any project screen
At the moment I've only tried on ios

react-native-cli: 2.0.1
react-native: 0.56.0
npm --v
6.2.0
I'm desperate, thanks

I am facing the same issue. I downgraded to 0.2.4 to make it work...

getting the same error on android
react-native: 0.54
react-native-track-player: 0.2.4

@mckmarc @himankpathak  Go to project navigator -> click right button on project name -> click New File -> than select Swift file -> give file name like dummy.swift -> Clean & Run

Looks like a linking problem. Try removing the library, adding it again and linking it.


tests merge idempotence and fixes found bug

Adds a way to make Fate in the manager always runs steps multiple times to test idempotence. Created versions of merge and delete rows ITs that uses this test manager. Found and fixed a bug in the merge code when running these new test. Changed mini accumulo to allow specifying a different manager class to use prio to startup.  There was an existing method that would allow starting a manager with a different class, but using it would have meant letting the actuall manager start and then killing it and starting another which would have added time to test.  The change to mini accumulo was not made to its public API, only its implementation.
fixes #4642

I manually verified that when the test runs that fate steps run twice by looking at the logs.  Saw logs like the following when doing this.  It would be good to verify this at run time during the test, but have not been able to figure out a good way to do this.
$ grep Running org.apache.accumulo.test.functional.MergeFlakyFateIT_merge/logs/FlakyFateManager_491616213.out | tail
2024-06-06T15:03:22,813 109 [fate.Fate] DEBUG: Running DeleteTablets.isReady() FATE:USER:c0599ae5-9671-4118-977e-b5529fd93983 took 0 ms and returned 0
2024-06-06T15:03:22,814 109 [fate.Fate] DEBUG: Running DeleteTablets.isReady() FATE:USER:c0599ae5-9671-4118-977e-b5529fd93983 took 0 ms and returned 0
2024-06-06T15:03:22,822 109 [fate.Fate] DEBUG: Running DeleteTablets.call() FATE:USER:c0599ae5-9671-4118-977e-b5529fd93983 took 8 ms and returned FinishTableRangeOp
2024-06-06T15:03:22,826 109 [fate.Fate] DEBUG: Running DeleteTablets.call() FATE:USER:c0599ae5-9671-4118-977e-b5529fd93983 took 4 ms and returned FinishTableRangeOp
2024-06-06T15:03:22,833 109 [fate.Fate] DEBUG: Running FinishTableRangeOp.isReady() FATE:USER:c0599ae5-9671-4118-977e-b5529fd93983 took 0 ms and returned 0
2024-06-06T15:03:22,833 109 [fate.Fate] DEBUG: Running FinishTableRangeOp.isReady() FATE:USER:c0599ae5-9671-4118-977e-b5529fd93983 took 0 ms and returned 0
2024-06-06T15:03:22,860 109 [fate.Fate] DEBUG: Running FinishTableRangeOp.call() FATE:USER:c0599ae5-9671-4118-977e-b5529fd93983 took 26 ms and returned null
2024-06-06T15:03:22,862 109 [fate.Fate] DEBUG: Running FinishTableRangeOp.call() FATE:USER:c0599ae5-9671-4118-977e-b5529fd93983 took 2 ms and returned null
2024-06-06T15:03:23,447 105 [fate.Fate] DEBUG: Running RenameCompactionFile.isReady() FATE:META:6bff1bc6-09e0-30f8-9d48-b4d04e59c402 took 0 ms and returned 0
2024-06-06T15:03:23,447 105 [fate.Fate] DEBUG: Running RenameCompactionFile.isReady() FATE:META:6bff1bc6-09e0-30f8-9d48-b4d04e59c402 took 0 ms and returned 0

Could expand the usage of this new testing technique to cover more of the Fate operations like bulk import, tablet compaction, etc.  Will look into that after this, should be easy to do, just need to find the right test.

@keith-turner - I took a look over this fix this morning since I worked on no-chop merge and added the merge marker to handle the indempotent case in #3975 and it looks good to me.
This does not affect 2.1 since the merge code is entirely different, but I was curious about main because the merged marker and no-chop merge also exists there in #3957. I took a look and found the following that I had added so I do not think this bug is currently an issue in main. In the merge code in main we are only checking if the last tablet in the merge range has the merged marker and then returning because we are assuming it is already merged if it does. We are not checking for a correct linked list. This makes sense as I tested the idempotent case manually when working on this and didn't see an issue.
I guess the only outstanding question if if we should add a similar check to the merge code in main to verify the linked list or not worry about it.

I guess the only outstanding question if if we should add a similar check to the merge code in main to verify the linked list or not worry about it.

The expectation is that the tablets being merged form a linked list.  Did not realize that was only checked in elasticity.  I think it would be good to add an issue for that.  If the persisted tablet metadata does not meet expectations its probably best to avoid proceeding w/ merge.

This does not affect 2.1 since the merge code is entirely different, but I was curious about main because the merged marker and no-chop merge also exists there in https://github.com/apache/accumulo/pull/3957.

Thanks for looking into that.  Made a comment on #4646 that while this exact bug does not exist in earlier branches that other bugs related to idempotence may exists.  Your suggestion there about back porting FlakyFate would help test that.

The expectation is that the tablets being merged form a linked list. Did not realize that was only checked in elasticity. I think it would be good to add an issue for that. If the persisted tablet metadata does not meet expectations its probably best to avoid proceeding w/ merge.

I created a new issue https://github.com/apache/accumulo/issues/4651


.NET playlists don't play

Possibly due to playlists not being enumerated until playlist is requested?

At the moment, the playlists aren't playing because the SpotifyControlWinForms app is still looking for the old filename (playlists.xml).


Add IfThenElse to the AST

Alex Nemish reports on X:

Validators are glorified IfThenElses.
Blockchain space is very expensive.
IfThenElse is one of the most used builtins.
Minswap contract has 96 IfThenElses.
It's used as (force (apply(apply(apply(force (builtin ifThenElse)) cond) (delay t) (delay f))))
Instead of (ifThenElse t f).
It's 8*5 + 7=47 bits instead of 5 bits, 10 times more.
Practically, we use force/delay ONLY because of IfThenElse is a builtin and it doesn't have lazy semantics.
10-15% all ALL Cardano bytecode in the blockchain is just that.
Minswap contract has 1350 force/delay nodes of 8213. It's 16%.
Unnecessary. Redundant.

My response was

This would be extremely awkward. Builtins are fully customizable in Core UPLC and hardcoding IfThenElse into the AST would mean that Bool needs to be hardcoded too and now we have "native" and "external" builtins...

but we should perhaps at least try adding an IfThenElse node to the AST to see how it affects performance. Maybe the awkwardness is worth it.

16% is crazy. If that number is actually correct then I personally would prefer any amount of awkwardness over 15% of all byte-code being force/delay.
That’s an extremely large performance tradeoff just to avoid awkwardness.

16% is crazy. If that number is actually correct then I personally would prefer any amount of awkwardness over 15% of all byte-code being force/delay.
That’s an extremely large performance tradeoff just to avoid awkwardness.

Weren't you the person who said "The cost of bytes is so low" recently? :stuck_out_tongue:
Seriously though:

16% isn't crazy, we've optimized runtime by ~100x from the original version incrementally and without changing the AST
IfThenElse is pattern matching for Bool, we also have [] and Data. Do you want us to hardcode pattern matching into the AST for lists and Data as well? Probably some of those 16% come from handling of lists and Data. At that point it'd perhaps be easier to just hardcode all builtins, although in that case I'm not sure how to handle builtins used for costing or testing.

extremely large performance tradeoff

I don't know how 16% of delay/force nodes translates to performance, but if we take it literally as 16% slowdown, then it's not extremely large, it's not even large. There are ways to improve performance by about as much without introducing "awkwardness", i.e. without slowing development down (increasing maintenance costs, increasing the cost of adding new features, spending time formalizing and specifying the updated AST etc) and increasing the risk of messing up the semantics of the language as that's what "awkwardness" translates to.
I was explicitly told that I should not spend any significant amount of time improving performance after I'd invested some effort in that as this wasn't deemed a priority. The latter is the reason why things don't become faster, not our lack of imagination.
Also, IfThenElse is for converting built-in Bool to SOPs (or Scott-encoded Bool as it used to be the case), not for using it 96 times within your contract. It's for interfacing, not for the logic. So maybe this is simply an issue of not holding the thing right.

16% is crazy. If that number is actually correct then I personally would prefer any amount of awkwardness over 15% of all byte-code being force/delay.
That’s an extremely large performance tradeoff just to avoid awkwardness.

Weren't you the person who said "The cost of bytes is so low" recently? 😛
Seriously though:

16% isn't crazy, we've optimized runtime by ~100x from the original version incrementally and without changing the AST
IfThenElse is pattern matching for Bool, we also have [] and Data. Do you want us to hardcode pattern matching into the AST for lists and Data as well? Probably some of those 16% come from handling of lists and Data. At that point it'd perhaps be easier to just hardcode all builtins, although in that case I'm not sure how to handle builtins used for costing or testing.

extremely large performance tradeoff

I don't know how 16% of delay/force nodes translates to performance, but if we take it literally as 16% slowdown, then it's not extremely large, it's not even large. There are ways to improve performance by about as much without introducing "awkwardness", i.e. without slowing development down (increasing maintenance costs, increasing the cost of adding new features, spending time formalizing and specifying the updated AST etc) and increasing the risk of messing up the semantics of the language as that's what "awkwardness" translates to.
I was explicitly told that I should not spend any significant amount of time improving performance after I'd invested some effort in that as this wasn't deemed a priority. The latter is the reason why things don't become faster, not our lack of imagination.
Also, IfThenElse is for converting built-in Bool to SOPs (or Scott-encoded Bool as it used to be the case), not for using it 96 times within your contract. It's for interfacing, not for the logic. So maybe this is simply an issue of not holding the thing right.

The cost of storage bytes is relatively low, but the deserialization fee per reference script byte is extremely high. So much so that most major dApp protocol revenue was cut in half by its introduction.
The reason it contributes to performance (by performance I mean in the context of onchain code, the ex-units that dApp developers care about). Is that the most impactful optimization techniques in onchain code involve trade-offs between script-size and ex-units. This results in a tight balancing act when making a production smart contract, the goal is to minimize ex-units while keeping the script size below (often as close as possible to) the ~16kb limit. Unrolling recursion, large lookup tables, and aggressive inlining are all powerful optimizations that reduce ex-units at the cost of increasing script size. When 16% of the script size is occupied by force/delay, that is 16% that could be used for either more features in the contract or more optimization via the above techniques.
I don’t know why it was decided that you shouldn’t spend any significant amount of time on performance when that is the number one concern of dApp developers. Aside from smart contract auditing, the vast majority of the contracting work we do at Anastasia Labs is for is smart contract optimization to enhance the throughput of dApp protocols. It is the same for every dApp, a massive amount of time is spent on script optimization (often at the expense of code-readability and occasionally even security), all because without such optimizations throughput is not sufficient.

If we would go so far as to actually create an IfThenElse term, I suggest making such a term accept a variable number of arguments (similar to case), and implicitly delaying those arguments.
So we can generate UPLC code like:
IfThenElseTerm(<cond0>, <case0>, <cond1>, <case1>, <cond2>, <case2>, <default>)

Instead of:
force ifThenElse(
  <cond0>,
  delay <case0>,
  delay force ifThenElse(
    <cond1>,
    delay <case1>,
    delay force ifThenElse(
      <cond2>,
      delay <case2>
      delay <default>
    )
  )
)


Add support for netbeans-color-codes-preview plugin

I created modifications of NB plugin https://github.com/junichi11/netbeans-color-codes-preview
If the author accepts it. It will be possible to integrate color codes preview for Android files.
https://github.com/junichi11/netbeans-color-codes-preview/issues/15
And I added basic support for Java, Color constants and RGB Color values.

colors.xml

Android java

Add support for official netbeans-color-codes-preview plugin.
Changes from my PR are already added...


fix(tekton): fix for empty tags and events

Signed-off-by: Brian Gleeson<EMAIL_ADDRESS>PR summary
Related issue: https://github.ibm.com/one-pipeline/adoption-issues/issues/1110
When attempting to remove a tags: ["tag1","tag2"] property from a Trigger, or an events: ["push"] property from a SCM Trigger, the removal would fail and the tags/events left in place in the trigger. This was because of the omitempty tag included for those proeprties in the generated Go SDK. By adding the x-sdk-go-serialize-empty annotation for the Tags and Events properties in the openAPI spec, the omitempty is excluded for these properties and the issue is fixed
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 1.0.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[feature] Global phase 1 limit

Hello @MrPig91,
You mentioned the "global phase 1 lmit" in another thread
Is this something that is on the road map?
Ref: https://github.com/MrPig91/PSChiaPlotter/issues/108#issuecomment-863374411

I will add this to the roadmap.


padding for action-chip on share structures

Issue #: /bcgov/entity#13106
Description of changes:

added padding on action chip for share structure
update version 2.0.4

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

To finish the rest of 13106 I will be making a PR on the edit-ui once this PR is merged. This was the easiest way to fix the action chip.

Did you follow the Readme steps and run storybook and lerna in your local environment? There might be some changes in the docs folder that should be updated in this PR.

Did you follow the Readme steps and run storybook and lerna in your local environment? There might be some changes in the docs folder that should be updated in this PR.

I will update my PR after following the readme

Did you follow the Readme steps and run storybook and lerna in your local environment? There might be some changes in the docs folder that should be updated in this PR.

I believe Lewis is talking about Storybook.
And he's right: you need to rebuild SB and commits its files. There should only be a handful. If there are more then you may be using the wrong Node version to run npm.

This seems like a lot of files being changed I am using node 12 so it should be right. Does this seem like to many

Yes, that's too many files, an indication that some version doesn't match. Last time I changed something in here, there were 3 changed files. Faiz or Travis had trouble with this recently, even after confirming their Node version.
Try this:
cd bcrs-shared-components
git co -b testing
git fetch --all
git reset --hard origin/main
nvm use 12
npm install
lerna bootstrap --hoist
npm run storybook:build
git status

If this doesn't work then (a) I can rebuild Storybook for you, or (b) we can dig in and find out why it's not working. Let me know.

Ya this is what I get when I do that. What version of node 12 are you using? I am using 12.22.12 I wonder if that is the difference?

I'm using the same version of Node as you:

Your vendors-main bundle should not have changed, since you didn't change any vendor (imported packages) files.
Do you want to try to resolve this now (for everyone), or just check in the changed file and I'll commit the SB changes for you?

I'm using the same version of Node as you:

Your vendors-main bundle should not have changed, since you didn't change any vendor (imported packages) files.
Do you want to try to resolve this now (for everyone), or just check in the changed file and I'll commit the SB changes for you?

I would be willing to try and fix it for everyone

I would be willing to try and fix it for everyone

I think maybe it was me all along! I recreated the repo and followed the steps in the readme, and saw that the vendor files had changed. So I committed those. (Theory: I was out of date and all of you are up to date.)
Please rebase and try building Storybook again :)

I have a bit of a problem with git at the moment I updated vs code in the middle of a merge and now git isn't letting me resolve merge conflicts. I'm just going to be trying to fix it sorry for all the notifications.

Successfully published:
 -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS>lerna success published 17 packages

I'm not sure why all the components were up-versioned but I'm confident there was no change to them so 🤷
(In the past, this kind of thing happened when there was a mismatch between the tags in GH and locally, but I don't think that's the case here. Anyway, no harm done.)

That is strange, I

I'm not sure why all the components were up-versioned but I'm confident there was no change to them so 🤷
(In the past, this kind of thing happened when there was a mismatch between the tags in GH and locally, but I don't think that's the case here. Anyway, no harm done.)

I'll try and scrap my fork and start with a fresh clone next time I work here so I don't run into this issue again hopefully.

I'll try and scrap my fork and start with a fresh clone next time I work here so I don't run into this issue again hopefully.

Might be on my side. I dunno and I'm not worried about it. (But cloning the repo is easy so not a bad idea.)


adds tests for Fn-Call-Id, and adds for timeouts

back when we streamed responses out from the container, we set this header
regardless of whether the task ran or not. now, we're setting this header at
the end since we're doing buffering, only if the task runs successfully atm.
we can change to the old policy pretty readily if we want to, up for
discussion. as this patch presents it, it's just adding a test that it exists
in the normal case and the timeout case, and adding the timeout case. however,
other relevant cases exist, like fdk protocol errors, and we can whitelist
those each or just cover all errors, even if the call was never executed, up
to us. when we add streaming, the plumbing goes back to the way it was where
we just add this at some point before the container writes any headers out of
it, and we can pick what level to do that if we want special behavior around
this header for whether the call executed or not.

I feel inclined to add it for all error cases as well, will make that change here. thanks for feedback

@skinowski https://github.com/fnproject/fn/pull/1344/commits/6449dfc22e6cd88fb532bb96fe7668377165bc89

LGTM

ty


Facing vulnerability issues with csi-image: 0.6.1

We are still facing the same issue [https://github.com/warm-metal/csi-driver-image/issues/49].
In closing comment, it's mentioned 'this warning is a misreport'.
Did anyone try with Jfrog Xray?

issue got fixed in our Xray tool.

I'm going to close this issue. Feel free to open new issues for questions or bugs.