Gradle Module Metadata

The existing Ivy and Maven metadata formats are insufficient to describe the variants and rich dependency information that is part of the Gradle software component model. A new, Gradle-specific metadata format will be used to allow the full model to be published, and to allow new dependency management features to be fully reflected int he publishing metadata.
Module metadata will be published alongside existing Ivy or Maven metadata files. Published .pom and ivy.xml files will contain a lossy mapping of the Gradle metadata model, and will be designed for consumers that cannot handle the new metadata format (eg Ivy, Maven, old versions of Gradle).
Existing repository layouts will be used. There is no requirement for a new Gradle-only repository layout.

Closing as this was delivered and improved over the Gradle 6.x line


Adds java8 time instance for OffsetTime

Fixes #809

Codecov Report

Merging #810 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
- Coverage   86.96%   86.92%   -0.05%
==========================================
  Files          71       71
  Lines        2310     2318       +8
  Branches      167      178      +11
==========================================
+ Hits         2009     2015       +6
- Misses        301      303       +2

Impacted Files
Coverage Δ

...main/scala/io/circe/java8/time/TimeInstances.scala
100% <100%> (ø)
:arrow_up:

...d/src/main/scala/io/circe/NonEmptySeqDecoder.scala
91.66% <0%> (-8.34%)
:arrow_down:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
91.76% <0%> (-0.59%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b8945...a5a924d. Read the comment docs.

👍, looks reasonable to me, thanks!


v up shows error

I see this error when issuing v up :
$ v up
cannot compile `/home/mdt/Source/oss/v/cmd/tools/vup.v`:
vlib/os/fd.c.v:83:6: error: expecting method name
   81 | }
   82 |
   83 | fn C.select(ndfs int, readfds &C.fd_set, writefds &C.fd_set, exceptfds &C.fd_set, timeout &C.timeval) int
      |      ~~~~~~
   84 |
   85 | // These are C macros, but from the V's point of view, can be treated as C functions:

```

no clue what i did wrong :/

sorry, wrong repo


docs: fix package name in README

What a coincidence: yesterday we also forked the old project and started cleaning it up, like you did. But you are a few steps ahead :smiley: Thanks a lot!

Hi Miallo, Thank you too for contributing!


Prometheus <-> Prometheus Packet service discovery flaky

Likely due to systemd hardening blocking filesystem access, since the file is world-readable (and in fact: world-writable?!?!)
Jan 13 22:00:07 eris prometheus[1315182]: ts=2024-01-13T22:00:07.123Z caller=file.go:343 level=error component="discovery manager scrape" discovery=file config=packet_nodes msg="Error reading file" path=/var/lib/packet-sd/packet-sd.json err="open /var/lib/packet-sd/packet-sd.json: permission denied"
Jan 13 22:00:37 eris prometheus[1315182]: ts=2024-01-13T22:00:37.123Z caller=file.go:343 level=error component="discovery manager scrape" discovery=file config=packet_nodes msg="Error reading file" path=/var/lib/packet-sd/packet-sd.json err="open /var/lib/packet-sd/packet-sd.json: permission denied"
Jan 13 22:01:37 eris prometheus[1315182]: ts=2024-01-13T22:01:37.121Z caller=file.go:343 level=error component="discovery manager scrape" discovery=file config=packet_nodes msg="Error reading file" path=/var/lib/packet-sd/packet-sd.json err="open /var/lib/packet-sd/packet-sd.json: permission denied"
Jan 13 22:04:07 eris prometheus[1315182]: ts=2024-01-13T22:04:07.124Z caller=file.go:343 level=error component="discovery manager scrape" discovery=file config=packet_nodes msg="Error reading file" path=/var/lib/packet-sd/packet-sd.json err="open /var/lib/packet-sd/packet-sd.json: permission denied"

I don't see a hardening option enabled that should prevent access. Nothing of the following worked:

disabling PrivateUsers=
disabling SystemCallFilter=
providing access through BindReadOnlyPaths=/var/lib/packet-sd

But I think it must be related to the runtime environment, since sudo -u prometheus cat /var/lib/packet-sd/packet-sd.json works.
Then I noticed that some processes seem to be able to read the file, and some don't.
[pid 1455844] openat(AT_FDCWD, "/var/lib/packet-sd/packet-sd.json", O_RDONLY|O_CLOEXEC) = 238
[pid 1455845] openat(AT_FDCWD, "/var/lib/packet-sd/packet-sd.json", O_RDONLY|O_CLOEXEC) = 238
[pid 1455836] openat(AT_FDCWD, "/var/lib/packet-sd/packet-sd.json", O_RDONLY|O_CLOEXEC) = -1 EACCES (Permission denied)

Very confusing.

Tracked it down to https://github.com/packethost/prometheus-packet-sd/issues/15

Renaming this bug to indicate this is less critical than I originally thought - this probably ends up making Prometheus miss some updates, but it's only a race condition that doesn't always get hit.

Tried updating to the patched version, but now it chmods to 0600. I'm confused.

The chmod is applyed to the outfile, not the tempfile. Ouch.
https://github.com/packethost/prometheus-packet-sd/pull/22
https://github.com/NixOS/nixpkgs/pull/291463


compute_test_err.py is broken for mnist.yaml in maxout

This line:
https://github.com/lisa-lab/pylearn2/blob/master/pylearn2/scripts/papers/maxout/compute_test_err.py#L55
will fail because x_arg will already be in a Conv2D space for mnist.yaml.
See discussion here:
https://groups.google.com/forum/#!topic/pylearn-users/WAo8x3LzvdU

That's correct, lines 54 and 55 should be removed, because the iterator is already doing the conversion.


Alignment of Homepage is not consistent

Description
With the new merge of the Homepage in PR #33, we can find an inconsistency in the alignment specially for a higher resolution.
An issue was seen for the following resolution:
Browser: Chrome 101.0 and Firefox 100.0
Screen resolution: 1920x1080
Screen size: 22 inch
Screenshots

Additional information
Problem
Currently the styles.module.css uses px for various sizes and alignment which makes the component not responsive
Possible Solution
We can use % instead of px to make it responsive or we can use the CSS @media rule. For more info link
Any other idea to this problem is always welcome

How we can run this project localhost?

How we can run this project localhost?

Clone the repository (clone your fork of the repository if you want to contribute)
Change directory (cd <repo name>) to the cloned repo on your local machine
Run npm install to start automatically install all the dependencies
Run npm start to start the local server. You should be automatically redirected to your default browser and site should open.  If not, go to localhost:3000/website on your browser

We'll soon have these steps mentioned in detail on CONTRIBUTING page on this repo

can you assign me?

If you want so, I can add these steps in my PR #26

resolved


.ASS lights are misconfigured

global_ui init.py line 979 and 980 should be swapped. Setting a light to Circle incorrectly exports it as a rectangle and vice versa.
file_ass build_asset.py lines 112 and 113 need to be swapped for falloff to work correctly

Update: here are some comparison screenshots
Halo Asset Blender Development Toolset
Normal spot light with default settings:

Normal spot light with 75-degree angle:

fbx-to-ass command
Normal spot light with default settings:

Normal spot light with 75-degree angle:

And here are two .ass files to compare: https://www.dropbox.com/s/xng6x7faz6b9t42/comparison.7z?dl=1

Sure thing, will do


[Bug] when pie legend icon="circle", series itemStyle influence it's size.

Version
<IP_ADDRESS>-current
Link to Minimal Reproduction
without
Steps to Reproduce
``

ECharts 饼图示例

cannot replicate with code provided.
pie.itemStyle does not have any size parameter.  Legend circle icon size is controlled by itemWidth.
📌 please close issue if problem solved.


Scaling along y in 'Affine Transformations' not right?

Hi, not 100% sure, in but the second animation (scaling along y) in the section about 'Affine Transformations'
https://www.algorithm-archive.org/contents/affine_transformations/affine_transformations.html
I could not see the difference with the one about 'scaling along x'... both seem to change the upper left element of the matrix:

Then in the the video:
https://www.youtube.com/watch?v=E3Phj6J287o&feature=emb_imp_woyt
you see the same steps, but then the lower right corner element of the matrix is used to change the scaling of y

Is it possible that the first mentioned animation is wrong?

Thanks! I'll fix this in a few hours! Not quite sure how that happened...


Updating Flatly theme to 3.3.2

Current version was using variables before they had been declared, and the box-shadow function needed to be included in order to work

Thanks!


How to add details in recent post sections

Question

In the exampleSite , I am unable to see any example to add recent posts. Can you please show some examples to add that?

@ahmadimt Please check hossainemruz template https://github.com/hossainemruz/toha-example-site

Thanks for the reply @ranrinc . I checked the link provided but could not find any example there. It would be great if you please could share an example  here.

@ahmadimt when you say example do you mean the website made using toha? something like this? https://toha.netlify.app/

I am able to get recent posts working


Unable to open extension view.

Error message:
connect ENOENT /Users/Kun/.nvim/XDG_RUNTIME_DIR/Code - Insiders-1.14.0-insider-shared.sock

VSCode Version: Code - Insiders-1.14.0
OS Version: macOS 10.12.5

This happened after I installed the latest update of insiders version last night(Chinese time), and it remains in today's release, but the latest stable version of VScode works fine, with the same configuration and extensions.
I have VSCodeVIM extension installed and with NEOVIM backend enabled, but previous version and stable version it works just fine.

In the latest release of vscode-insiders(2017-06-21T05:03:18.384Z), this error is gone, but there's a new extension problem:

There were some changes in Extensions view in yesterday's insiders which had few issues. These were fixed yesterday and please try today's insiders and let me know if you still have issues.

Hi, @sandy081 there are still some errors exist.

@sumanx these errors are unrelated to the issue which fixed yesterday... Looks like one of the old processes from VS Code is still running.. @joaomoreno Any idea how to release this?

Still not working, today's release, run insiders build alone. Same errors in develop console like above.

@sandy081 A machine reboot would work. 👍

@joaomoreno no, not work.

@sandy081 It seems caused by XDG_RUNTIME_DIR I defined in my zshrc. If I remove it, VSCode Insiders works.


Improve the comment for the prefix parameter in the AddEnvironmentVariables method

The /// comment for the prefix parameter of the AddEnvironmentVariables method is a bit misleading as it doesn't only filter the environment variables but also removes the provided prefix from the variable name. This behavior should be mentioned in the comments.
This has already been changed/improved in the documentation side and I think it would also make sense to improve on the code comments side. Please check the pull request in the documentation repo: https://github.com/aspnet/Docs/pull/1777
I spent a few hours myself trying to figure out why my environment variables weren't being loaded and why weren't they overriding my variables in the appsettings.json. Lets help other developers with this small change in the comments.

@miguelcrpinto are you planning to send a PR for the product to improve this? :smile:

@divega I could do the PR but as far as I know I'd have to sign the Contributor License Agreement which I haven't done yet and today I'm going on a short vacation until the end of the month.
I'll start by signing the Contributor License Agreement and this gets approved today I'll try to do the PR before going on vacations.

@miguelcrpinto no worries and enjoy your vacation. If you don't get to it we will apply the change here.

Done! PR #492

Merged thanks! e82c7aa236271b22792441caadce001e7fd426fa


[Fix] Mobile Support for Map Segment

In pages where we have a map segment make some adaptable for mobile change
An option:
We should add a button "view on map" when the user click it, will open a modal window with the map/redirect to map page. In this way, the map will be over all the screen and not a small window.

Originally posted by @ArkadiK94 in https://github.com/hasadna/open-bus-map-search/issues/16#issuecomment-1828052724
If you have other suggestion for adaptation you welcome :)

Hey, I'll gladly work on it 😎
Can you assign me please?

@NoamGaash @ArkadiK94
Hey mates, I implemented the styling for the expanded map (obviously the button isn't styled yet):

Now I'd like to work on the button styling, but when I went to search for which icons library we're working with, I saw none on package.json..
Should I work with mui-icons? I saw the other issue were you guys discussed which library should we work with.

@ant-design/icons , the library that we use for icons

consider splitting it to two separate pull requests:

the delivery will be faster
the CR will be better (in terms of speed and quality)

consider splitting it to two separate pull requests:

the delivery will be faster
the CR will be better (in terms of speed and quality)

Actually I've already incorporated styling as well using antd & antd/icons..
I'll make a PR shortly.

@NoamGaash I think I took care of all your notes, apologies in advance if the revert on yarn.lock didn't succeed (I'm kinda new to advanced GitHub stuff), let me know if anything else needs to be done on my side :)
And thanks again for your kindness!

would you like to try yourself reverting and solving the conflicts?

you're welcome, thanks! would you like to try yourself reverting and solving the conflicts? or I'll do it

Hey champ, sorry I really did try to revert the commit but I have no clue how to resolve the conflict with yarn.lock and I don't want to screw things up around here.
Hopefully in my future contributions I'll already know better how to use GitHub in a vast environment (I'm really used to develop alone)

git checkout main yarn.lock
git add yarn.lock
git commit -m "chore: reset yarn.lock to main"
git pull origin main
git push

done

@NoamGaash I just made a commit without the media query for mobile devices. Now we can have the expand button on all devices :)
Should I make a new PR?

sure! I'd love that. thank


Move remote_api.connect() to a separated file so that other scripts can reuse it.

LGTM!

Thanks. Merged.


The branch list appears with a delay

Issue Type: Bug
When I press on the branch button I see that the branch list appears with a delay (there are about 1000 branches)
VS Code version: Code 1.62.1 (f4af3cbf5a99787542e2a30fe1fd37cd644cc31f, 2021-11-05T09:23:14.144Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No
Remote OS version: Linux x64 4.4.114-50
Extensions (14)

Extension
Author (truncated)
Version

remote-containers
ms-
0.205.2

remote-ssh
ms-
0.66.1

remote-ssh-edit
ms-
0.66.1

remote-wsl
ms-
0.58.5

vscode-remote-extensionpack
ms-
0.21.0

material-icon-theme
PKi
4.10.0

vscode-todo-highlight
way
1.0.5

material-theme
zhu
3.13.2

template-generator-vscode
Den
0.4.1

gitlens
eam
11.6.1

json-pretty-printer
eus
1.1.0

git-graph
mhu
1.30.0

vscode-typescript-tslint-plugin
ms-
1.3.3

language-stylus
sys
1.13.0

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30384385
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
vsccppwtct:30382698
bridge0708:30335490
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30391933
pythonvspyt187:30373474
vsqsis200cf:30386380
vsaa593:30376534
vssld246:30386377

/gif-please

/gifPlease

Please have a look at screencast:

Note: I use remote-ssh extention (https://code.visualstudio.com/docs/remote/ssh)

I've also created empty repo with 1k branches on remote machine, but delay didn't reproduce.

@Yadro, apologies for not getting back to you on this until now. Are you still experiencing this issue? Given that we are unable to reproduce the problem in an empty repo with 1k branches I would say that there is something specific to the repository where this occurs. One thing that you could try is to use the git.checkoutType setting to control the types of references that are being shown to reduce the list.

Closing the feature request due to inactivity.


DELETE tag section testimonial dinamic

After a testimonial is posted and can be edited, there should also be a button to delete it.
The logical flow will follow the sequence of options to post and edit a testimonial.

The correction made in the PUT Tag was also applied here, in short, it was the same issue.


Great Job! Something went wrong with hand motion。。。

Hello
something went wrong when comes to hand motion
the body goes well but the hands dosen't move at all。。
where should I check?

@WenWeiZhao
Hello, may I take a look at the bones of your Blender model or could you please share your Blender model with me? My body motion goes bad and was wondering if you could give me some suggestions for troubleshooting the issue.
Thanks!
my email is<EMAIL_ADDRESS>

Hello
something went wrong when comes to hand motion
the body goes well but the hands dosen't move at all。。
where should I check?

@WenWeiZhao Hello, may I take a look at the bones of your Blender model or could you please share your Blender model with me? Thanks
my email is llpspark at 163.com

@siqi0905 @llpspark Do you have a solution for the character's bone problem? I am also encountering this issue. Could you please give me some advice or share your model with me? Thank you very much!


Question about generating the tsv file to fine-tuning.

Hello, I follow your readme file seems to be unable to generate the tsv file needed for the downstream task fine-tuning, can you give more detailed steps or share the ISCX-VPN task tsv file you generated in the paper. Thanks.

Hello, I follow your readme file seems to be unable to generate the tsv file needed for the downstream task fine-tuning, can you give more detailed steps or share the ISCX-VPN task tsv file you generated in the paper. Thanks.

Thank you very much for your interest in this work.
I will update a detailed README to explain the process of generating target data from PCAP as soon as possible. In the meantime, I will also share the data files of multiple publicly available datasets that have been processed.

Thank you very much for your answer and I look forward to your sharing!

Thank you very much for your answer and I look forward to your sharing!

I have shared the dataset and the README file, please check in here.

非常感谢您的回答，期待您的分享！

我已经分享了数据集和 README 文件，请在此处查看。

同问，看您写的readme里面的三条都是出现问题应该如何做，请问更具体一点的操作应该如何操作呢？比如第三步中pcap_path的路径还进行了变更，而且每一步都有这样的报错信息，

麻烦作者大大可以更加详细的给出如何生成tsv文件吗，谢谢


Implement QueryBuilder

Instead of editing Mapper, I decided to create new classes with a completely different and non-intrusive design. In my opinion, the current Mapper has a complex user interface. However, if you're not satisfied with the implementation design and direction, I can close this PR.
With this patch, writing queries become more elegant:
https://github.com/poacpm/api.poac.pm/blob/c01da77374e212ebf035f22dce76086e5ed52eeb/controllers/v1.cc#L30-L38
Additionally, adding filters conditionally will be much easier:
https://github.com/poacpm/api.poac.pm/blob/c0b02ce3377de764623a5f1c7618e202fa152fd4/controllers/v1.cc#L97-L105
The execSync method returns either Row or Result when SelectAll is false because the auto-generated drogon model does not support selecting partial columns, resulting in an Invalid SQL result for this model error. By improving the template for drogon model, we will be able to return simply T or std::vector<T>.
At the moment, this only supports select and a few filters.

@ken-matsui Thanks so much for the PR. would u please add the execAsync and execCoro method to the FilterBuilder class?

@an-tao

Thanks so much for the PR. It LGTM.

Thank you for your review!

would u please add the execAsync and execCoro method to the FilterBuilder class?

Sure!

@an-tao

Thanks so much for the PR. It LGTM.

Thank you for your review!

would u please add the execAsync and execCoro method to the FilterBuilder class?

Sure!

This is a big feature, I think we need more reviewers :)

It seems GitHub Actions on 092f40f571fe4e9ed14a3d4894413880fed20979 and e3e8c6973e6ee122d689e59fe3a5ef33248fa115 should be reran.

@ken-matsui would you please add some tests to the db_test.cc for this patch? thanks.

I do not have a compiler that implements coroutines, so the tests may fail.

Hi @an-tao,
I've added tests for the builders. However, I am not sure they are working correctly because they are frequently skipped somehow.
Let me ask one question about security. How are you preventing SQL injection? Or does DbClient assure it? If needed, I think I have to implement protection for the builders.

Also, do you have any plan to drop the support of C++14? Using C++17 or over would clean up our codes. For example, cpr recently decided to set the minimum required C++ version to C++17.
https://github.com/libcpr/cpr/releases/tag/1.9.0

Hi @an-tao,
I've added tests for the builders. However, I am not sure they are working correctly because they are frequently skipped somehow.
Let me ask one question about security. How are you preventing SQL injection? Or does DbClient assure it? If needed, I think I have to implement protection for the builders.

If you use placeholders for parameters, DbClient can prevent SQL injection.

@an-tao

If you use placeholders for parameters, DbClient can prevent SQL injection.

Thank you for your answer. Do you prefer to include the change to use placeholders in this PR?

@an-tao

If you use placeholders for parameters, DbClient can prevent SQL injection.

Thank you for your answer. Do you prefer to include the change to use placeholders in this PR?

Yes. thanks

@an-tao
I've implemented the builder to use placeholders. Please let me know if you need additional implementation.

@an-tao Thank you for your review! I've fixed both as reviewed.

@an-tao Thank you for your review! I've fixed both as reviewed.

Thanks, please rebase on the new master branch.

@an-tao
Could you please check why the bad-free error occurs?
https://github.com/drogonframework/drogon/runs/7778696421?check_suite_focus=true#step:15:46755

@an-tao
Could you please check why the bad-free error occurs? https://github.com/drogonframework/drogon/runs/7778696421?check_suite_focus=true#step:15:46755

I can't say where is the problem with this error, maybe we could try to use g++11 because the g++10 has some bugs with coroutines.

@ken-matsui please rebase on the master branch, thanks.

Through debugging on my Ubuntu machine, I found two things when I executed ./test.sh -t.

Building with -DCMAKE_CXX_FLAGS="-fcoroutines" causes this error; otherwise, nothing was caused (Everything is ok! was printed out)
With -DCMAKE_BUILD_TYPE=Debug, the following error appeared.
(Release will emit the same error with CI)

$ ./test.sh -t
...

In test case PostgreTest
↳ /home/kmatsui/Desktop/drogon/orm_lib/tests/db_test.cc:957  PASSED:
  MANDATE(result.size() != 0)

db_test: /home/kmatsui/Desktop/drogon/lib/inc/drogon/utils/coroutine.h:510: const T& drogon::CallbackAwaiter<T>::await_resume() const [with T = std::vector<drogon_model::postgres::Users, std::allocator<drogon_model::postgres::Users> >]: Assertion `result_.has_value() == true || exception_ != nullptr' failed.
./test.sh: line 203: 2931751 Aborted                 (core dumped) ./orm_lib/tests/db_test -s
Error in testing

Environment
$ uname -sp
Linux x86_64

$ g++ --version
g++ (Ubuntu 11.2.0-19ubuntu1) 11.2.0
...

$ git branch --show-current
implement-builders

So, my execCoro implementation is something wrong since the assertion failure is emitted as the following line is executed.
https://github.com/ken-matsui/drogon/blob/f0a88568a89c852322b5ecd87c6be9310b6c1b3c/orm_lib/tests/db_test.cc#L970-L973
I'll have a look into it.

@an-tao To make things simpler with this PR, I propose removing support for coroutines and addressing it in a separate PR. What do you think?

@an-tao Do you think this PR is ready to be merged?

@ken-matsui Would you please add a section to the wiki-doc for this patch? thanks so much.


🎇 Support for PDF images

This converts PDFs to PNGs in the build. They now work for Word and web export.

Nice -- I think this is good enough for now, next time we support an image type, we may want to have a better way to introduce image transforms.


Add support for Linux builds

BTW: On adding trailing newlines to the edited files:
On Linux, common editors like Vim automatically add terminating newlines at the end of files.
PS: Just for your information, with the comitted change to Setup.bat, on Linux, it prints this:
scripts/Setup.bat
Download https://premake.github.io for Linux and run it. Best regards, scripts/Setup.bat

@TheCherno @jamesthomasgriffin This supports Ubuntu inside of checks for for "gmake2" and "linux", so it does not affect Windows support in any way.
It checks that the needed libs are installed (for Ubuntu) and adds linking these dependencies (vulkan etc).
Once it's merged, more can be done, or I could do more for other Linux distros besides Ubuntu,
but this gives already a good start to get Linux support going.
For now, I am waiting until I've seen contributing works.

@bernhardkaindl nice work!
@TheCherno I have implemented similar support for building on macos. Is it worth submitting a pr?

@bernhardkaindl nice work!
@TheCherno I have implemented similar support for building on macos. Is it worth submitting a pr?

@despian yes please!

@bernhardkaindl nice work!
@TheCherno I have implemented similar support for building on macos. Is it worth submitting a pr?

can you share your version of macos please?


add email page and recorrected link to all pages

fix: #997

Hey @vivekvardhan2810 please review my PR

@shubhagarwal1 while i was checking the deploy preview in email page.
i can't see the logo

and here also.

please make the required changes.

fix: #997

Hey @vivekvardhan2810 please review my PR

Hey @vivekvardhan2810 this PR has many code lines changes, it is jsut because of reformatiing
also i have chagned the email us link to all the pages
and updated it so, no worries code is tight and okay

Doing, logo fix

Hey @vivekvardhan2810 done logo fix

Done @shubhagarwal1.
Updating the level also.

@shubhagarwal1 some feedback about me also, like how was my role and collaboration with you as a project admin and contributor.
And how much i was actively working on this.

@shubhagarwal1 Can you share some feedback about me also, like how was my role and collaboration with you as a project admin and contributor.
And how much i was actively working on this.

Working with @vivekvardhan2810  as a project admin and contributor has been an absolute pleasure. You were incredibly active on the repo, consistently reviewing the valuable insights and solutions, your dedication to the project was evident through his prompt responses, well-organized tasks, and proactive approach to resolving issues. His collaborative nature made the development process smooth and efficient, and I truly appreciated your commitment and hard work throughout the project, thankyou for the opportunity, and again working with you.

and bhai @vivekvardhan2810 agr ho ske can i have your contact details like number or linkedin

Working with @vivekvardhan2810 as a project admin and contributor has been an absolute pleasure. You were incredibly active on the repo, consistently reviewing the valuable insights and solutions, your dedication to the project was evident through his prompt responses, well-organized tasks, and proactive approach to resolving issues. His collaborative nature made the development process smooth and efficient, and I truly appreciated your commitment and hard work throughout the project, thankyou for the opportunity, and again working with you.

Thank you @shubhagarwal1 for the compliments and I loved your work also mann.
 Keep contributing to Open source.

and bhai @vivekvardhan2810 agr ho ske can i have your contact details like number or linkedin

You can check my linkedin in my profile.

@shubhagarwal1 Thank you for contributing to ML Fusion Labs.
your contribution values to our project.
please do contribute to other projects also.
And wishing you all the best for your future endeavors.

Okay @MastanSayyad.


Uncaught TypeError: this.buildPlaceholderTokenizedLinesForRows is not a function

[Enter steps to reproduce:]

...
...

Atom: 1.14.3 x64
Electron: 1.3.13
OS: Mac OS X 10.12
Thrown From: omnisharp-atom package 0.31.1
Stack Trace
Uncaught TypeError: this.buildPlaceholderTokenizedLinesForRows is not a function
At /Users/AAPG/.atom/packages/omnisharp-atom/node_modules/rxjs/scheduler/AsyncScheduler.js:45

TypeError: this.buildPlaceholderTokenizedLinesForRows is not a function
    at TokenizedBuffer.editor.tokenizedBuffer.silentRetokenizeLines.leading (/packages/omnisharp-atom/dist/features/highlight-v1.9.js:214:40)
    at invokeFunc (/packages/omnisharp-atom/node_modules/lodash/lodash.js:10350:23)
    at leadingEdge (/packages/omnisharp-atom/node_modules/lodash/lodash.js:10360:26)
    at /packages/omnisharp-atom/node_modules/lodash/lodash.js:10425:20)
    at /packages/omnisharp-atom/dist/features/highlight-v1.9.js:137:68
    at SafeSubscriber._next (/packages/omnisharp-atom/dist/server/omni.js:420:17)
    at SafeSubscriber.__tryOrUnsub (/packages/omnisharp-atom/node_modules/rxjs/Subscriber.js:234:16)
    at SafeSubscriber.next (/packages/omnisharp-atom/node_modules/rxjs/Subscriber.js:183:22)
    at Subscriber._next (/packages/omnisharp-atom/node_modules/rxjs/Subscriber.js:125:26)
    at Subscriber.next (/packages/omnisharp-atom/node_modules/rxjs/Subscriber.js:89:18)
    at FilterSubscriber._next (/packages/omnisharp-atom/node_modules/rxjs/operator/filter.js:88:30)
    at FilterSubscriber.Subscriber.next (/packages/omnisharp-atom/node_modules/rxjs/Subscriber.js:89:18)
    at RefCountSubscriber.Subscriber._next (/packages/omnisharp-atom/node_modules/rxjs/Subscriber.js:125:26)
    at RefCountSubscriber.Subscriber.next (/packages/omnisharp-atom/node_modules/rxjs/Subscriber.js:89:18)
    at ReplaySubject.Subject.next (/packages/omnisharp-atom/node_modules/rxjs/Subject.js:55:25)
    at ReplaySubject.next (/packages/omnisharp-atom/node_modules/rxjs/ReplaySubject.js:31:31)
    at ConnectableSubscriber.Subscriber._next (/packages/omnisharp-atom/node_modules/rxjs/Subscriber.js:125:26)
    at ConnectableSubscriber.Subscriber.next (/packages/omnisharp-atom/node_modules/rxjs/Subscriber.js:89:18)
    at MapSubscriber._next (/packages/omnisharp-atom/node_modules/rxjs/operator/map.js:83:26)
    at MapSubscriber.Subscriber.next (/packages/omnisharp-atom/node_modules/rxjs/Subscriber.js:89:18)
    at DebounceTimeSubscriber.debouncedNext (/packages/omnisharp-atom/node_modules/rxjs/operator/debounceTime.js:98:30)
    at AsyncAction.dispatchNext (/packages/omnisharp-atom/node_modules/rxjs/operator/debounceTime.js:114:16)
    at AsyncAction._execute (/packages/omnisharp-atom/node_modules/rxjs/scheduler/AsyncAction.js:111:18)
    at AsyncAction.execute (/packages/omnisharp-atom/node_modules/rxjs/scheduler/AsyncAction.js:86:26)
    at AsyncScheduler.flush (/packages/omnisharp-atom/node_modules/rxjs/scheduler/AsyncScheduler.js:36:32)

Commands

Non-Core Packages
linter 1.11.23
omnisharp-atom 0.31.1
qolor 0.4.1

Disabling linter does not prevent the error

I'm also having this issue, i'm adding more informations to help reproduce:

Open the package settings
Enable the Enhanced Highlighting option

Atom: 1.15.0 x64
Electron: 1.3.13
OS: Mac OS X 10.12.3
Thrown From: omnisharp-atom package 0.31.1
Feel free to ask if you need more infos :)
Hope this helps.

Any solution for this issue?

Atom: 1.15.0 x64
Electron: 1.3.13
OS: Fedora 25
Thrown From: omnisharp-atom package 0.31.2
The error comes from using a private/not documented function from atom that was removed in atom/atom@ea80483cbe6e97a668f720f42f9538267bc52d7f. I tried to replace the call with what that function did, there was no error afterwards but I think the Enhanced Highlightin feature still didn't work.


EDTF date picker component

@mirekys Ahoj, I've made refactoring of the datepicker like we discussed. Please when you can take a look at the code. I strongly recommend also checking out the branch and seeing for real how it looks/works, to make sure that I got it right. It also contains a small change regarding the information about whether the user is authenticated or not that I need in the searchAppConfig. Thanks a lot,

Remove extra space between picker & input (should be directly attached to it)

If value from/to is equal, show as single date in edit
Current behavior:

user choses a single date radio
picks a date and saves
edit form switches radio to multiple dates input:

Unable to pick date range in a range picker:
https://github.com/oarepo/oarepo-ui/assets/646743/d05235cd-4f82-4c61-bed4-2ddce2d411da

Form validation errors feedback should be dismissable (it otherwise blocks access to inputs until whole page reload) - can be tackled in separate PR :)

Illogical date ranges shouldn't be allowed (this happens with non-default date format modes):


Proper spelling -> higher credibility

BTW, I added webdriver-sync to Slant, http://www.slant.co/topics/2814/viewpoints/5/~what-are-the-best-node-js-selenium-webdriver-client-libraries-bindings~webdriver-sync

awesome!  Thanks @dandv !  I hope it serves you well :smile:


Repair Shared Stops Validator

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing
[ ] The description lists all relevant PRs included in this release (remove this if not merging to master)
[ ] e2e tests are all passing (remove this if not merging to master)

Description
The shared stops validator was built on incomplete data. As a result, most of the validators didn't work correctly. This PR resolves these, adding support for the file in the way it was meant to be used.
Also adds support for the columns being in any order

Thanks for the feedback! All addressed


Temporal Distance or Spatial DIstance

Is the distance matrix that we pass as input to the algorithm made of spatial or temporal distances? Because looking at the Individual.cpp section, it seems that the distances are indeed temporal! In case the distance are spatial, is it possible to use temporal distances?
Thank you in advance for your attention.

It does not matter which unit of distance is used in a CVRP: cost, time, distance, or emissions, for example, as long as it's a fixed scalar for any (i,j) pair.
When duration constraints are activated (as in the case of the Golden instances), the constraint on duration (for each route) is applied to the sum of the distance and service time of the customers.


asyn: use throttling for the get/put of AsyncFileSystem

Fixes #618

I hope you don't mind the push - sometimes it's easier to describe in code.

I wasn't even aware of the config capabilities, so it's nice to learn!


[RFR] AutocompleteInput issues

There are a couple of issues with AutocompleteInput:

[X] When the suggestion is undefined it errors https://github.com/moroshko/react-autosuggest/pull/481
[X] After the selectionlist appears and Escape is pressed, the selections do not reappear.
[X] getSuggestionValue does not check if optionText could be a function.
[X] Added a bunch of tests

I just tried those changes on the simple example locally and it seems that when editing a resource, the component now just show the selected one in its choices. You now have to explicitly erase the content and type a new search to see other choices. We added this feature deliberately to at least show some choices along side the selected one (optimistic UI). Can you add this behavior back ?

I just tried those changes on the simple example locally and it seems that when editing a resource, the component now just show the selected one in its choices. You now have to explicitly erase the content and type a new search to see other choices. We added this feature deliberately to at least show some choices along side the selected one (optimistic UI). Can you add this behavior back ?

Wow, I actually spend time to get rid of this behaviour. Can we agree to make it configurable (I can default it's behaviour to what you want). I think this is counter intuitive, and in the case the optionText renders an item which has additonalinfo (like a persons badge or something), it should only show the selecteditem item imo.

Thanks ! We'll fix the doc ourselves :)


[v1.0] Demo workflow

[ ] DeNas CNN Demo
[ ] DeNas Vit Demo
[ ] DeNas Bert Demo
[ ] DeNas ASR Demo

@csdingbin @tianyil1 @Peach-He
Due date: WW50
suggest to test and run after all DeNas main codes merged to e2eAIOK

https://github.com/intel/e2eAIOK/pull/102


Close or Open Notification

Is there any way SideMenu can update the content whether it's opened or closed?
For example, I need to do something as soon as the SideMenu opens. Any suggestion?

In your suggested implementation you'll invoke onChange even if you don't change current state (i.e. menu is open and after swipe menu is still open.

hmm, SideMenu calls onChange method. It's just a receiver.

Yeah, I mean that it calls onChange even when the state haven't been changed.

I clearly see the issue. nice catch. I have added prevState variable and isChanged method which fixes this issue. ddc0253ea3373de66abf4c14b00d41ca81c075b9

Gonna be solved in #24


Helm chart looks for cilium-operator-{generic,aws,azure,alibabacloud} which are not in the PATH

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When trying to deploy Cilium Operator using the Helm into our EKS clusters, we found that it was looking for cilium-operator-generic as the command in the Deployment manifest. However that command does not appear in the PATH for the operator container!
We looked more closely, both a the chart and the container and found that cilium-operator-{aws,azure,alibabacloud} also did not appear in the PATH. Along with checking the latest 1.12 version
Cilium Version
1.12.0 (but 1.12.1 also would fail for the same issue)
Kernel Version
$ uname -r
5.10.118
Kubernetes Version
1.21
Sysdump
cilium-sysdump-20220909-123329.zip
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@stormmore can you provide the helm values that you are using? Thank you


Implement directoryGetVersion

Will get the version of an entire directory
Implement the following method
/// <summary>
/// Gets the directory of the specific version.
/// </summary>
/// <param name="_localDirectoryPath">The local directory path.</param>
/// <param name="_item">The instance of the source control item.</param>
/// <returns>The path where the directory was extracted.</returns>
public FilePath directoryGetVersion(FilePath _localDirectoryPath, SysVersionControlTmpItem _item)
{
    return '';
}

Repro-steps as per @weedgarden
1) VS: create VS project (Visual C# -> Windows project)
2) VS: add to AOT, build, deploy
3) AX2012: add VS project to version control
4) commit
5) AX2012: delete the VS project
I got @SYS343905 (The project cannot be deleted because %1 is checked out.) when trying the last step.
No pending objects. "Undo checkout" does not help.


face_encodings  return [] to me

face_recognition version:(0.1.14)
Python version:py2.7
Operating System:ubuntu17.04

Description
when I use function face_encodings(),it return [].
What I want to know
I just want to know what it means.
It can't recognize the picture ?

Review this:
# Load a sample picture and learn how to recognize it.
obama_image = face_recognition.load_image_file("obama.jpg")
obama_face_encoding = face_recognition.face_encodings(obama_image)[0]

What happened here is that face_encodings loaded an image and find faces(note that its plural, not face but faces) in that image. Once thats done, it translated those faces into numpy array of 128 features.
So what you have in the end is a 2D array with first dimension being the faces and the 2nd dimension being the facial encoding features (size 128)

So like @sluongng said, if face_encodings() returns [], that means it didn't find any faces in the picture so the array is empty.


version installed by gem seems to be well behind this repository

I have just started using ruby-nessus and I am getting warnings from ruby:
/var/lib/gems/2.3.0/gems/ruby-nessus-1.2.0/lib/nessus/Version2/host.rb:362: warning: Enumerator.new without a block is deprecated; use Object#to_enum
so I went and fixed the source and then went looking for the 'original'.  The code here has clearly been reworked substantially from what I got from the gem.
I assume the gem has not been updated so my question is -- what is the best way to use  the
up to date version of this module?  i.e  clearly I uninstall the gem and then where should I clone the repository to (working on ubuntu).

I have work on this gem to refactor and enhance the gem last year, but I don't have the access to release the code on rubygems.
@rful011 : you can use directly the last version on github :
gem 'ruby-nessus', git: 'https://github.com/Cyberwatch/ruby-nessus.git'

@mephux can you release the gems on rubygems.org or give me the right to push a new release.

LOL!  I see nothing has changed.
Two years on and working on another project and I stumbled over the same problem.  Spent some time stuffing around and cursing then spotted this!  I have been here before!

I found this page helpful in getting the 2.0 beta installed:  https://www.stevencampbell.info/Ruby-Nessus/
I don't understand how gem 'ruby-nessus', git: 'https://github.com/Cyberwatch/ruby-nessus.git'  is supposed to work because gem expects a command ???

hmmm... is it time to rename the gem and  clone the repository under a different name.  I am not familiar with the terms of the various licenses...


try setting the context

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Does this PR have test?

Special notes for your reviewer:
Does this PR introduce a user-facing change?

sorry, wrong remote!


Solution from Contrast Security

Solution including workbook, data connector and analytics rules for review.

Closed until issues are fixed.


gap list found through .trg parsing

Hey, I just ran across this repo and I figured I should let you know that I have code for parsing .trg files to confirm gap existence:
https://gist.github.com/PARTYMANX/68112d487259c027251f19223ec74897
This gist includes both the code I used for parsing the gaps, as well as the gaps I found through parsing each trg file.  note that it's based on the JP release.  it was just the disc I had handy at the moment.  there should be no difference with other revisions, though it wouldn't hurt to confirm that

oh, I should also note that the .trg files i parsed were from the THPS2 pc release, the gap list was from the jp executable.  nothing was taken out of either to my knowledge

Hi, thanks for sharing your work.
I can see that "Wimpy Gap" is missing from the listing (gap in Downtown), has this gap been removed from the THPS 2 PC release?
Other than that, the gap "SMALL WATER HAZARD GAP" seems to really exist, this deserves some investigations in the level.
For the rest:

I don't know how to reach the 200+ feet DHJ gaps
Kicker Gap in Streets seems to exist only in multiplayer mode
I will stop searching for the gaps located in your section "Unused", too much clues that leads to a dead end to find them.

Nice.

oh, I think I see what happened to wimpy gap: either I got the wrong offset for the gap list (it's the first gap) or the ID being 0 threw my code off.  I'll parse through the THPS1 US data later

thps1gaps.txt
data from running against THPS1 PS1 US.  I made it output IDs alongside names this time.  I remember why I omitted Wimpy Gap the first time: there are a lot of gap nodes that refer to ID 0 (which is Wimpy Gap) in levels that don't have that gap.  I think it also acts as a placeholder for other triggers

Cool !
If the gap with id 2609 (Small Water Hazard Gap) is found, I will redo the TAS Career Mode 100% + All Gaps (minus the 200+ feet gaps, but I'll try to find an other setup to try to reach them).
By the way, are you interested to find it too or it's the game's data mining that you prefer?
Nice work !

I think I just prefer the datamining portion for now.  This was mostly work I did a while back.
I'm thinking small water hazard is possibly inaccessible. I don't understand enough of the trg format to figure out where the triggers would be placed though.  maybe someday I'll dig into it, would be nice to figure all of that out.


WriteHostedSceneServiceDefinitions.py script incorrectly sets "name" value in output json file to item title

In order to publish a hosted scene service from the associated hosted feature service we have to provide the appreciate json publishing parameters. This json can be found on the scene service rest endpoint (/rest/services/Hosted/"service"/SceneServer). However, we can't simply write the data out to a json file; it must have a "name" property added. I incorrect set the "name" property value to the title of the portal item. It must be the name of the hosted scene service.

Fixed. Tested. Merged fix from v.next into master.


Show/hide errors when model is not the current model (ToyLandingModel)

While running the ToyLandingModel tutorial, I found that showing and hiding the model behaved inconsistently for models not designated as the current model. (Windows, AppVeyor artifact OpenSim-dd7dc47b-2018-02-11).
To reproduce:

Open the ToyLandingModel.osim and ToyLandingModel_AFO.osim models
Set the ToyLandingModel.osim model as the current model
Right click the ToyLandingModel_AFO.osim model in the Navigator and select Display --> Hide. The footplate geometry will not be hidden. Trying to hide the r_AFO_footplate body directly will not hide the geometry either.
Set the ToyLandingModel_AFO.osim as the current model. You can now hide the footplate geometry, either by hiding the entire model, or by hiding through the r_AFO_footplate body directly.
Keep ToyLandingModel_AFO.osim hidden and set ToyLandingModel.osim as the current model.
Now try to show ToyLandingModel_AFO.osim (right click --> Display --> Show). Depending on whether or not you previously hid the entire model or only hid the footplate to remove the footplate geometry, different errors will occur. The model will either not show at all (if you previously hid the entire model), or the model will show but without the footplate geometry (if you only hid the footplate).

Show/hide seems to be working as expected now on my Mac.


Use pascal case instead of snake case

Idea Description
Please use pascal case for those const values here.
https://github.com/DroidKaigi/conference-app-2023/pull/519/files#diff-eb541caab1535b5af692b5b9cd3804dd961c0170bdbff6f470e875701e54739dR22-R25
Reference images and links
Here is the referrence:
https://github.com/androidx/androidx/blob/androidx-main/compose/docs/compose-api-guidelines.md#singletons-constants-seal[…]ass-and-enum-class-values

I'd like to work on this!!

Thanks! Assigned you!

First time I've know of this!
I didn't know, I've increased it as it is here...
#541
@iroha-168
Would you please change this as well.

@5altNaCl
I see! Thank you!!


[2634] Add String's ToLowerInvariant() and ToUpperInvariant() methods

Fixed #2634.

@michaelcheers, please see comment https://github.com/bridgedotnet/Bridge/pull/2771#issuecomment-321916248 regarding Unit tests.

Stale PR with no new activity. Closing, but we can re-open in the future if new activity.


Patent reference

Reference to a patent.
User Stories
Author

Production staff

But what if . . . ?

Considerations

At eLife, the minimum information for this reference type is:

Inventors
Year
Patent title
Patent source
Patent number

Assignees, Patent country and URL are optional.

XML requirements
eLife uses the attribute publication-type="patent".
<element-citation publication-type="patent">
    <person-group person-group-type="inventor">
      <name>
        <surname>Onoda</surname> <given-names>T</given-names>
      </name>
      ...
    </person-group>
    <year iso-8601-date="2015">2015</year>
    <article-title>Imidazopyridine Derivative</article-title>
    <source>World Intellectual Property Organization</source>
    <patent country="Japan">2015087996</patent>
    <ext-link ext-link-type="uri" xlink:href="https://patents.google.com/patent/WO2015087996A1/en">https://patents.google.com/patent/WO2015087996A1/en</ext-link>
  </element-citation>

eLife allows the following children of element-citation[@publication-type="patent"]:

person-group
year
article-title
source
patent
ext-link

person-group has the attribute person-group-type="inventor" and can contain child name or collab.
It would make sense to mandate the following elements:

person-group[@person-group-type="inventor"] (containing at least one name or collab)
year
article-title
source

Taken from: https://github.com/elifesciences/TextureRequirements/issues/79

No user stories at present to check this feature against


Add winecfg command to readme tips

Some LUG Wiki instructions have you accessing winecfg. To new users it may not be apparent how to access that without Lutris. This change adds some clarity.

LGTM

Thanks!


fix tmux

see tmux/examples/tmux.v
tmux is broken, need to make some tests and fix

can we review this?
check documentation


Suscribe to TV Shows

[ ] Dropdown for TV Shows
[ ] Create subscription (RSS Feed?)

Consider Firebase to store the needed information.

Needs to be broken down to several stories/tasks as this is a whole feature/separate API.


[Bug]: When using winston v3 on node14.18.3, there seems to be a memory leak event.

🔎 Search Terms
memory leak
The problem
I found memory leaks when using winston v3.7.2.
node test-winston.js 2> /dev/null

RSS: 28.9921875 MB
heap used/total: 4.790740966796875/8.57421875 MB
...
... snip ...
...
RSS: 195.984375 MB
heap used/total: 49.476966857910156/50.82421875 MB

What version of Winston presents the issue?
3.7.2
What version of Node are you using?
v14.18.3
If this worked in a previous version of Winston, which was it?
v2.4.5
Minimum Working Example
const w = require('winston')

setInterval(() => {
    w.error('test'.repeat(100))
}, 10)

setInterval(() => {
    const MB_DIV = 1024 * 1024;
    const usage = process.memoryUsage();
    console.log(`RSS: ${usage.rss / MB_DIV} MB`);
    console.log(`heap used/total: ${usage.heapUsed / MB_DIV }/${usage.heapTotal / MB_DIV} MB`);
}, 1000);

Additional information
In v2.4.5, the increase in memory usage has not occurred as in this case.

Thanks for the detailed report! I had to make a few tweaks to get initial stats reported:
const w = require('winston')
const printStats = () => {
    const MB_DIV = 1024 * 1024;
    const usage = process.memoryUsage();
    console.log(`RSS: ${usage.rss / MB_DIV} MB`);
    console.log(`heap used/total: ${usage.heapUsed / MB_DIV }/${usage.heapTotal / MB_DIV} MB`);
}
setInterval(printStats, 1000);
printStats();
setInterval(() => {
    w.error('test'.repeat(100));
}, 10)

I did not notice much of an increase in memory usage, even when making that 100 into 10000, though the logging interval function only repeats 17x in either case (and I don't fully understand why). The snipped portion for me is:
[winston] Attempt to write logs with no transports {"message":"test...test","level":"error"} 17x.
My initial testing was on Node 16.10.0. I also tried 14.18.3 and there, while it seemed like the random small initial difference might've been a bit larger, it went back down even lower several seconds later.
There may be some performance tradeoff somewhere in there which only cleans up references when memory use is above a certain threshold or at lower-activity times in order to make logging faster, because that's pretty important for a logging library, so even if there is some growth in memory usage with additional logging that doesn't necessarily mean it's problematic.  Are you seeing a more sustained usage or failure to close something properly?

Thanks for the detailed report! I had to make a few tweaks to get initial stats reported:
const w = require('winston')
const printStats = () => {
    const MB_DIV = 1024 * 1024;
    const usage = process.memoryUsage();
    console.log(`RSS: ${usage.rss / MB_DIV} MB`);
    console.log(`heap used/total: ${usage.heapUsed / MB_DIV }/${usage.heapTotal / MB_DIV} MB`);
}
setInterval(printStats, 1000);
printStats();
setInterval(() => {
    w.error('test'.repeat(100));
}, 10)

I did not notice much of an increase in memory usage, even when making that 100 into 10000, though the logging interval function only repeats 17x in either case (and I don't fully understand why). The snipped portion for me is: [winston] Attempt to write logs with no transports {"message":"test...test","level":"error"} 17x. My initial testing was on Node 16.10.0. I also tried 14.18.3 and there, while it seemed like the random small initial difference might've been a bit larger, it went back down even lower several seconds later. There may be some performance tradeoff somewhere in there which only cleans up references when memory use is above a certain threshold or at lower-activity times in order to make logging faster, because that's pretty important for a logging library, so even if there is some growth in memory usage with additional logging that doesn't necessarily mean it's problematic. Are you seeing a more sustained usage or failure to close something properly?

I think without config transports, winston will keep all the logs into this._readableState.buffer, and this will eventually cause memory issue..
https://github.com/winstonjs/winston/blob/master/lib/winston/logger.js#L300

When there is no transport configured, in order to control the size, it should be good to  truncate the buffer,  making it always below a certain size.

Is there any update on this?

Is there any update on this?

This memory leak is about the use Winston V3 without any transports.. So make sure you add transports for V3 and I enhanced the doc and warning message in Winston for this issue.
 You need add transports by yourself, and leaving the default logger without any transports may produce a high memory usage issue.

@zizifn We are getting the issue with transport configured as below
transports: [
			new winston.transports.Console()
		],

@zizifn We are getting the issue with transport configured as below
transports: [
			new winston.transports.Console()
		],

same here...

We are facing the same issue, Winston logger is causing memory leaks, transport is already configured in our case as well.
We are using Version : 3.6.0.
Do we have any update on the fix of this issue ? we are facing issues on Prod and some update on this will help - as it's urgent.

@Shahtaj-Khalid what version of Node are you using?
As you can see in my comment above, I wasn't able to reproduce the problem.  Even if I had been able to, diving into the details of why that's happening and figuring out how to fix it is far from a trivial effort, for a problem I'm not observing in any of my own applications, and it seems nobody is willing to fund any of the maintenance efforts on this package.

@wbt I'm using node v13.8.0 and latest version of winston logger.
Also, I have opened a separate question regarding the issue we are facing and have added all the details along with how we can reproduce the issue as well: https://github.com/winstonjs/winston/issues/2233, as we're able to reproduce the issue pretty much every time, Kindly check this and provide your feedback.
Also, it is high priority issue for us as it is effecting our prod environment. If it doesn't get fixed, we'll unfortunately have to consider other loggers.
Thanks.

@wbt I'm using node v13.8.0 and latest version of winston logger. Also, I have opened a separate question regarding the issue we are facing and have added all the details along with how we can reproduce the issue as well: #2233, as we're able to reproduce the issue pretty much every time, Kindly check this and provide your feedback.

That doesn't provide "all the details along with how we can reproduce the issue" - it isn't even logging one message, let alone enough to be overwhelming

Also, it is high priority issue for us as it is effecting our prod environment. If it doesn't get fixed, we'll unfortunately have to consider other loggers.

That is not the threat you might think it is. If you need contracted reliability you'll have to pay a service provider for that.
You can probably pay less for an engineer to start from something that mostly works but has a few bugs (and contribute those working solutions back to the community, where the benefits can be all shared and better maintained) than to start from scratch. If you think another logging library is a better starting point, please feel free to use that.  If you're interested in providing some serious funding to the Winston project, please say so.  It currently has none, and businesses relying on it have no right to insist that very-limited-time volunteers burn hours trying to fix issues that you and not we are encountering, especially when provided reports don't make it easy to reliably reproduce the problem.


Use "stable" as default channel

Looks like "this value will automatically get changed" may
not be correct, as installing with this script enabled the
"edge" channel.
DRY_RUN=1 ./install.sh
# Executing docker install script, commit: 40b1b76
...

yum install -y -q yum-utils
yum-config-manager --add-repo https://download.docker.com/linux/centos/docker-ce.repo
yum-config-manager --disable docker-ce-*
yum-config-manager --enable docker-ce-edge
yum makecache
yum install -y -q docker-ce

ping @seemethere @andrewhsu PTAL


[BUG] PS2 scratches may not match due to assembler differences

Describe the bug
Some scratches may not match due to assembler differences. https://decomp.me/scratch/jo4dl doesn't match on decomp.me but locally with Ps2EeAs it does. The code is compiled with a ProDG compiler which was packaged with a custom assembler Ps2EeAs.
Expected behavior
ProDG compilers should use Ps2EeAs (the assembler shipped with ProDG) or the assembler should be selectable in the Compiler Options tab.
Screenshots
On decomp.me: Note that the Current doesn't use at as the original does.

Assembled with Ps2EeAs locally:

Scratches
(https://decomp.me/scratch/jo4dl)

Where is this Ps2EeAs binary? are there different versions? do they have different behaviour in terms of matching?


Language Content Updates

I'm keeping a running list here of text I'm updating in the English version that will need to be updated in the Traditional Chinese and Japanese versions as well.
I'm going to do a lot of text updates between now and getting Get-it out of beta so nothing should be updated just yet. I'll update this thread when the list is complete :sparkles:

[x] :eyes: especially on changes to the GitHub UI :computer:

https://github.com/jlord/git-it-electron/commit/afa435dabc7c8f961140c38872206dbb745d35d7

Hi @jlord !
I want to update Japanese one.
If the list is complete, feel free to tell me!
After that I start updating :smile:

Closed via #111


Removed the returning of void return types as per job contract

Heya,
Thanks for your PR. You've submitted this on the Illuminate organization which is a read-only sub split of laravel/framework. Please submit your PR on the https://github.com/laravel/framework repository.
Thanks!

Heya,
Thanks for your PR. You've submitted this on the Illuminate organization which is a read-only sub split of laravel/framework. Please submit your PR on the https://github.com/laravel/framework repository.
Thanks!

Will do, thanks.


Front End UI changes

Update material UI plugin
Added pagination to search results page.
Integrated search results with API response
Added Read Search results page
Updated styles for the content panel on Browse Constitution
Added API encapsulation ( fetch functions and endpoints)

I did not realise that you were using env variables for the API endpoint. Please, make appropriate corrections

I did not realise that you were using env variables for the API endpoint. Please, make appropriate corrections

Will do, thanks

Added email sending features
Added calendly for scheduling appointment
Added get for lawyers list


Support additional redirect status codes

What would you like to be added:
Currently we only support 301 and 302 redirects. It would make sense to expand that to all possible values.
Why this is needed:
Although 301 and 302 are most common, there's no reason not to support the rest. This likely means we'll need to distinguish support levels per value (Core: 301,302, Extended: 303+)

This was suggested by @bowei in https://github.com/kubernetes-sigs/gateway-api/pull/772#discussion_r692452704.

This likely means we'll need to distinguish support levels per value (Core: 301,302, Extended: 303+)

I think supporting conformance at such a granular level is pushing a lot of pain on to the user. We should avoid this at all costs.

Harry -- are you saying to not say anything or to mandate more conformance?

For something as granular as a field inside a filter, we should not have a conformance like "x value is core but y is extended". Users would be pulling their hair out debugging it.
Instead a specific field should either be core or not core. Somewhere in the middle feels really trappy.
I would go so far as saying that a filter is the smallest block on which we should have conformance, but we don't agree on that front so I will let it be.

I am inclined to agree -- especially until we get a good sense of how specific the conformance tests could possibly be.

/lifecycle frozen

While grooming we saw that this one was open for a long period of time without anyone with a strong use case to champion it. We're going to close this as we don't expect anyone's ready to drive it forward, but if you still want this feature and have a strong use case we will be happy to reconsider this and re-open.


Calling queryClient.setQueryData during onSettled might cause onSettled to be called

Describe the bug
I have two queries q1 and q2.
Both of them contain part of data that is the same.
So I defined a onSettled callback in both of them. So that when q2 query suceeds, it updates the cache of q1, and vice-versa, when q1 query succeeds, it updates the cache of q2.
Unfortunately I'm meeting an infinite loop. It seems like onSettled callbacks get called infinitely:

It's not something I'd expect, as the documentation of onSettled says it shouldn't be invoked after cache update (in contrast to onSuccess).
Is there anything I'm missing?
Your minimal, reproducible example
not yet, but I might create one soon
Steps to reproduce
see description
Expected behavior
see description
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
Chrome, OS X
react 17.0.2
react-query version
3.39.1
TypeScript version
No response
Additional context
No response

It might seem to happen only when using useInfiniteQuery, during the last page fetch (when getNextPageParam returns undefined).

In v4, setQueryData does no longer call callbacks, so this is likely fixed. Can you please try with v4?

Yeah, it seems to be fixed in v4. I guess I'll stay with v4 then ;o


Remove deprecated is_streamable and is_fulltrack_available

Changes proposed in this pull request:

Remove deprecations added in https://github.com/pylast/pylast/pull/384
Last.fm has deprecated the Radio API and the streamable attribute is also deprecated and will be removed at some point
https://www.last.fm/api/radio
https://support.last.fm/t/is-the-streamable-attribute-broken-it-always-returns-0/39723/3

Remove deprecations added in Deprecate is_streamable and is_fulltrack_available #384

This phrasing is weird. I took it to mean you're un-deprecating something that was previously deprecated.

It's GitHub auto-expanding the titles :)
I've changed it to:

Remove deprecations added in #384

I still think that's confusing. I think "Remove methods deprecated in #384" would read a lot better.

Thanks, updated!


ci: update error reference docs

This PR is auto-generated by a nightly GitHub action to update the error reference docs from source code in withastro/astro.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
reference/error-reference.mdx
Source changed, localizations will be marked as outdated.

en
reference/errors/actions-returned-invalid-data-error.mdx
Source added, will be tracked.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


[Mention The Feature]: Improve Mobile Responsiveness for Pathsphere

Is your feature request related to a problem? Please describe.
The current implementation of the Pathsphere website could benefit from enhanced mobile responsiveness. While some elements function correctly, there are areas where components do not scale or align properly on smaller screens, impacting user experience.
https://github.com/user-attachments/assets/a21beaff-b815-4bee-8ffa-f82da24893ef
Describe the solution you'd like.
No response
Describe alternatives you've considered.
No response
Additional context.
No response
Show us the magic with screenshots
No response
Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

Could you please assign this issue to me? I’m eager to improve the mobile responsiveness of the Pathsphere website. Enhancing the user experience on mobile devices is crucial for accessibility and usability. I look forward to implementing the necessary changes.

this issue has been solved, so we are closing this issue.


Full US  data

What is the name of your project?
Census Bureau Project
What is the purpose of your project?
The purpose of this project is to deal with the inconsistent representation of names and addresses that hampers accurate linking of records, impacting data quality. Varying formats, labels, and attributes require preprocessing for standardization, as inconsistent use of nicknames, initials, legal name changes, and order contribute to variations in record matching.
Who is involved in the project? Which of these people will have direct access to the pseudopeople input data?
Dr John Talburt<EMAIL_ADDRESS>Shazia Aman<EMAIL_ADDRESS>What funding is the project under? What expectations with respect to open access and access to data come with that funding?
This project is funded under Census Bureau. We are expected to consistent and standardized representation of names and addresses is expected to ensure accurate data processing and record linkage for individuals in the United States.
We commit to:

[X] be responsive to further questions from interested parties
[X] deprecate and replace our version of the pseudopeople input data when a new version is released

What data would you like to request?

[X] Full US
[ ] Rhode Island
[ ] Other (may not be available immediately)

Other data - more explanation
No response

Thank you for your interest in this data! We are still figuring out just how this process will go, but I wanted to make sure you knew that your request has been received. More detail to come soon!

Could you please provide an estimated timeframe for when we can expect to receive the data?

Same answer (and question) as #187 :)

I'll send an email with the link now.  Thank you again for your interest in pseudopeople!


Building TF on archlinux with python3

Hi
Sounds like the python3 building script have some issues:
PC% bazel build -c opt //tensorflow/tools/pip_package:build_pip_package
...........
WARNING: Sandboxed execution is not supported on your system and thus hermeticity of actions cannot be guaranteed. See http://bazel.io/docs/bazel-user-manual.html#sandboxing for more information. You can turn off this warning via --ignore_unsupported_sandboxing.
INFO: Found 1 target...
ERROR: /home/zenol/tensorflow/tensorflow/tensorflow/python/BUILD:247:1: Converting to Python 3: tensorflow/python/ops/functional_ops.py failed: 2to3 failed: error executing command bazel-out/host/bin/external/bazel_tools/tools/python/2to3 --no-diffs --nobackups --write --output-dir bazel-out/local_linux-py3-opt/genfiles/python3/tensorflow/python/ops --write-unchanged-files ... (remaining 1 argument(s) skipped): com.google.devtools.build.lib.shell.BadExitStatusException: Process exited with status 1.
Target //tensorflow/tools/pip_package:build_pip_package failed to build
Use --verbose_failures to see the command lines of failed build steps.

Target //tensorflow/tools/pip_package:build_pip_package failed to build
INFO: Elapsed time: 30.007s, Critical Path: 29.28s

Nb : The python2 build seems to work.

I get a similar error message on OSX 10.11.2 with python 3.5.0:
$ bazel build -c opt //tensorflow/tools/pip_package:build_pip_package --verbose_failures
INFO: Found 1 target...
INFO: From Compiling google/protobuf/src/google/protobuf/util/time_util.cc [for host]:
google/protobuf/src/google/protobuf/util/time_util.cc:52:18: warning: unused variable 'kMicrosPerMillisecond' [-Wunused-const-variable]
static const int kMicrosPerMillisecond = 1000;
                 ^
google/protobuf/src/google/protobuf/util/time_util.cc:56:19: warning: unused variable 'kTimestampFormat' [-Wunused-const-variable]
static const char kTimestampFormat[] = "%E4Y-%m-%dT%H:%M:%S";
                  ^
google/protobuf/src/google/protobuf/util/time_util.cc:371:6: warning: unused function 'ToUint128' [-Wunused-function]
void ToUint128(const Timestamp& value, uint128* result, bool* negative) {
     ^
google/protobuf/src/google/protobuf/util/time_util.cc:396:6: warning: unused function 'ToTimestamp' [-Wunused-function]
void ToTimestamp(const uint128& value, bool negative, Timestamp* timestamp) {
     ^
4 warnings generated.
INFO: From Compiling google/protobuf/src/google/protobuf/util/internal/utility.cc [for host]:
google/protobuf/src/google/protobuf/util/internal/utility.cc:50:19: warning: unused function 'SkipWhiteSpace' [-Wunused-function]
const StringPiece SkipWhiteSpace(StringPiece str) {
                  ^
1 warning generated.
ERROR: /Users/zeis/tensorflow/tensorflow/python/BUILD:247:1: Converting to Python 3: tensorflow/python/ops/functional_ops.py failed: 2to3 failed: error executing command
  (cd /private/var/tmp/_bazel_zeis/137871672d8bee8042ab5135b1863c28/tensorflow && \
  exec env - \
  bazel-out/host/bin/external/bazel_tools/tools/python/2to3 --no-diffs --nobackups --write --output-dir bazel-out/local_darwin-py3-opt/genfiles/python3/tensorflow/python/ops --write-unchanged-files tensorflow/python/ops/functional_ops.py): com.google.devtools.build.lib.shell.BadExitStatusException: Process exited with status 1: 2to3 failed: error executing command
  (cd /private/var/tmp/_bazel_zeis/137871672d8bee8042ab5135b1863c28/tensorflow && exec env - bazel-out/host/bin/external/bazel_tools/tools/python/2to3 --no-diffs --nobackups --write --output-dir bazel-out/local_darwin-py3-opt/genfiles/python3/tensorflow/python/ops --write-unchanged-files tensorflow/python/ops/functional_ops.py): com.google.devtools.build.lib.shell.BadExitStatusException: Process exited with status 1.
Target //tensorflow/tools/pip_package:build_pip_package failed to build
INFO: Elapsed time: 7.380s, Critical Path: 7.22s

Attempted to build TF on Archlinux as well, with the same problem …
some additional info: The 2to3 linked/created by bazel seems to be only an empty stub:
> cat bazel-out/host/bin/external/bazel_tools/tools/python/2to3
#!/bin/bash

exit 1

I'm totally new to bazel, so I didn't easily spot what went wrong, but someone familiar with it might know what's going on …
Archlinux differs from many distributions, in that python points to python3, not python2; I however tried to pass /usr/bin/python3 to ./configure, without any change in the error …
As a workaround, I changed exit 1 to exec 2to3 $@ [and changed the mtime of the file (soft-link target!) to the future, as bazel apparently checks if the build tools have been tampered with), and could successfully build TF.
Regards, Christian

Some python targets are missing the srcs_version="PY2AND3" annotation in the BUILD file. We're working on it. In the meantime, any python target in python/BUILD without this annotation will fail when compiled with python 3.

@csachs Thanks for sharing, this worked well for me too.


Córdoba province, Argentina added

@kant thank you for your contribution. The "image" property must be a PNG or JPG image though - please update with that.


Economic - 0812 and 1519 from Pop

Use only data delivered by Population

all workflows will build off existing ingestion processes
incorporate data delivered by population on March 15

The 2008-2012 data seems to be missing count of households per income bracket (extremely low income, low income, etc). Both 2008-2012 and 2015-2019 data have the median household income and total income fields

@AmandaDoyle sorry forgot to tag you when I came across this issue

Sorry - just getting to this.
That's right.  Households per income bracket (i.e. the ELI households indicator) is only being reported for 2015-2019.  Other indicators are available for both time periods.

Hey @AmandaDoyle how do we label median wages per industry? For example I am looking at median wages for workers in industry "Finance and insurance, and real estate and rental and leasing" which has code "fire". Would median wages by wages_fire_median, wages_fire_median_cv etc?

Ok in the source data counts of workers per industry/occupation are crosstabbed by race, but median wages per industry/occupation aren't. This wasn't the pattern I was expecting, wanted to flag so we are on the same page @AmandaDoyle

But industry wage is crosstabbed by race. Strange. Industry is the more granular categorization, 13 industries and only 5 occupations


Oracle JDK Installation fails on windows server running on Azure

[2016-05-06T10:57:39+00:00] FATAL: No download url set for java installer.
===============================================================================
Recipe Compile Error in c:/chef/cache/cookbooks/java/recipes/default.rb
===============================================================================

URI::InvalidURIError
--------------------
bad URI(is not URI?):

Cookbook Trace:
---------------
  c:/chef/cache/cookbooks/java/recipes/windows.rb:29:in `from_file'
  c:/chef/cache/cookbooks/java/recipes/default.rb:22:in `from_file'

Relevant File Content:
----------------------
c:/chef/cache/cookbooks/java/recipes/windows.rb:
 22:
 23:  Chef::Log.fatal('No download url set for java installer.') unless node['java'] && node['java']['windows'] && node[
'java']['windows']['url']
 24:
 25:  pkg_checksum = node['java']['windows']['checksum']
 26:  aws_access_key_id = node['java']['windows']['aws_access_key_id']
 27:  aws_secret_access_key = node['java']['windows']['aws_secret_access_key']
 28:
 29>> uri = ::URI.parse(node['java']['windows']['url'])
 30:  cache_file_path = File.join(Chef::Config[:file_cache_path], File.basename(::URI.unescape(uri.path)))
 31:
 32:  if aws_access_key_id && aws_secret_access_key
 33:    include_recipe 'aws::default' # install right_aws gem for aws_s3_file
 34:
 35:    aws_s3_file cache_file_path do
 36:      aws_access_key_id aws_access_key_id
 37:      aws_secret_access_key aws_secret_access_key
 38:      checksum pkg_checksum if pkg_checksum

Platform:
---------
x64-mingw32

←[0m
Running handlers:
[2016-05-06T10:57:39+00:00] ERROR: Running exception handlers
Running handlers complete
[2016-05-06T10:57:39+00:00] ERROR: Exception handlers complete
Chef Client failed. 0 resources updated in 32 seconds
[2016-05-06T10:57:40+00:00] INFO: Sending resource update report (run-id: d67ef516-4bf3-4e19-ac9a-3c3e636f9d0b)
[2016-05-06T10:57:41+00:00] FATAL: Stacktrace dumped to c:/chef/cache/chef-stacktrace.out
[2016-05-06T10:57:41+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
[2016-05-06T10:57:41+00:00] FATAL: URI::InvalidURIError: bad URI(is not URI?):

Have you tried what the error message says to do?

Thanks for the response.
I don't have aws subscription so i could not  set an url to download installer. But I required Oracle java so I used Java_se cookbook.

AWS is not a requirement for this cookbook - you can set the URL to any location your server has access to.


[Filters] Recalculate values based on filtered values

Stand by, we need to get rid of Elastic Search first.


Items added to the DOM by javascript profiles are not shown on screenshots

Hello - and first of all congratulations on a amazing job on Splash.
I ran into a issue where elements injected into the DOM of the target page do appear in the HTML of the page, but not on screenshots.
The elements are injected via javascript scripts that are loaded using the "profiles" feature.
Here are more details about my situation :

I'm using the docker distribution of splash, with the latest version pulled from scrapinghub's repo at the time of writing this
I'm on OSX
I'm starting Slash with the following command : docker run --volume=/local/path/to/profiles:/profiles -p 5023:5023 -p 8050:8050 -p 8051:8051 scrapinghub/splash --js-cross-domain-access --js-profiles-path=/profiles
calls to render.html or render.js do show the elements injected by the javascript, but they don't appear in screenshots obtained vi arender.png or render.jpeg

The code i'm having the issue with
import requests, json
import shutil

SPLASH_BASE_URL = 'http://<IP_ADDRESS>:8050/render.png'
SPLASH_BASE_URL_JSON = 'http://<IP_ADDRESS>:8050/render.json'
OUTPUT_PATH = '/tmp/test_underline_image.png'

headers = {'Content-Type': 'application/json'}

# construct POST data
args = {"url": "http://test.iodbh.net",
        "js": "generic",
        "wait": 10, # i added a long wait to make sure this isn't a timing issue
        "render_all": 1,
        "console": 1,
        "html": 1,
        }

# this request grabs the screenshot
r = requests.post(SPLASH_BASE_URL, stream=True, data=json.dumps(args),
                  headers=headers)
print(r.request.body)

# this second request is here to get the page's html and console output
r2 = requests.post(SPLASH_BASE_URL_JSON, data=json.dumps(args), headers=headers)
print(r2.json())
print(r2.json()['html'])
console_output = r2.json().get('console', None)
print("[BEGIN CONSOLE OUTPUT]")
if console_output is not None:
    for line in console_output:
        print(line)
else:
    print('[!] no js console output')
    print("[END CONSOLE OUTPUT]")

if r.status_code == 200:
    # download the image
    with open(OUTPUT_PATH, 'wb') as f:
        r.raw.decode_content = True
        shutil.copyfileobj(r.raw, f)
else:
    print(r.text)

here is the structure of my profiles directory:
generic/
    100-jquery-3.1.0.min.js     # regular distribution of jquery
    101-jquery-noconflict.js    # see below
    201-inject-css.js                # see below
    301-hint-css-tooltips.js    # see below

101-jquery-noconflict.js :
this simply makes sure jquery does not conflict with another version present on the same page :
var l$ = $.noConflict(true);

201-inject-css.js :
this adds the CSS i'm using into the page :
l$('head').append('<link rel="stylesheet" href="http://test.iodbh.net/libs/hint.min.css">');

301-hint-css-tooltips.js :
console.log('injecting hint.css...');
l$('p').append('You can also make tooltips...');
console.log('done.');

I've run into this issue with other requests, this is simply the most basic case in which i have that problem. I should add that while some modifications are not reflected in the screenshot (injecting elements), others are (such as adding other elements to other pages, or calls to jquery's css() method).
I am available to provide any additional information, or look into the code if you point me into the right direction.

For clarity, here is a sample response from render.json that shows a screenshot without the extra elements while they are present in the html source :
https://gist.github.com/iodbh/d4e521d1a043fece6b2011ebe528a1de

Did you ever manage to solve your issue?

No, but I haven't tried doing this again since shortly after opening this issue.

Shall we close this issue, or is this something you plan to go back to?

this is far from critical for me but if the issue is with splash and not my code it is probably worth looking into as it can break some use cases (in this instance taking "annotated" screenshots of pages). Ultimately it caused me to use a different headless browser for that project.


differentiate backupmodes on cloud5

Use consistent parameter (same as for restore) in upgrade mode.

+1 code looks good.


Homepage + File Color Incompatability

Details
With the Homepage plugin enabled and configured to launch a workspace, or daily note on startup (or when no other notes are open) the custom colors applied to files and folders via the File Color Plugin, all previously configured folder/file colors are disabled.
I suspect it may be related to  another recently reported issue regarding Homepage & Iconize issue 103 given that the issues are both color related.
I am presently using the Iconic plugin (as an alternative to Iconize) which does interact with the icon colors, but I prefer to colorize my files/directories rather than just the icons so i can't speak to compatibility issues there.
Steps to reproduce

Install the File Color Plugin
Assign colors to directories or individual files
Install the Home Page plugin
Configure an action to occur at startup (in this case, opening the Daily Note on startup, or "open when empty").
Re-launch obsidian
Observe that colors have been suppressed
Disable homepage plugin
Re-launch Obsidian
Observe that colors are now correctly displayed

Debug information
{"version":4,"homepages":{"Main Homepage":{"value":"Home","kind":"Daily Note","openOnStartup":true,"openMode":"Replace all open notes","manualOpenMode":"Keep open notes","view":"Editing view (Live Preview)","revertView":false,"openWhenEmpty":true,"refreshDataview":true,"autoCreate":false,"autoScroll":true,"pin":true,"commands":[],"alwaysApply":false,"hideReleaseNotes":false}},"separateMobile":false,"_defaultViewMode":"default","_livePreview":true,"_focusNewTab":"default","_plugins":["table-editor-obsidian","auto-card-link","obsidian-auto-link-title","better-word-count","calendar","colored-tags","obsidian-custom-attachment-location","editing-toolbar","dataview","obsidian-file-color","file-explorer-note-count","multi-properties","nldates-obsidian","omnisearch","obsidian-projects","tag-wrangler","templater-obsidian","text-extractor","obsidian-trash-explorer","frontmatter-modified-date","metaedit","quickadd","obsidian-filename-heading-sync","obsidian-excel-to-markdown-table","obsidian-kindle-plugin","multi-tag","obsidian-tasks-plugin","obsidian-enhancing-export","iconic","obsidian-charts","homepage"],"_internalPlugins":["file-explorer","graph","backlink","canvas","tag-pane","properties","page-preview","daily-notes","note-composer","command-palette","slash-command","editor-status","bookmarks","markdown-importer","outline","file-recovery","sync"],"_obsidianVersion":"1.6.7"}

Checklist

[X] I updated to the latest version of the plugin.

This is indeed related to #103. Both are caused by the plugins not accounting for when a workspace is opened, and Homepage uses the same logic as workspaces internally.
There is a workaround in ecustic/obsidian-file-color#26 but given the that plugin no longer seems to be maintained I might add a direct patch on my end.

Well. Nuts.


Setting maxlength attribute dynamically since beta 11

I just finished upgrading to ionic2 beta 11 (and angular rc4) changing my forms to @angular/forms.
With the old forms, I was using ion-textarea with a dynamic value to maxlength, e.g:
[attr.maxlength]="VariableThatHoldsMaxLength"
and the maxlength was copied PROPERLY to the native <textarea> inside.
Since upgrading to beta 11 - this stopped working and I can no longer set it dynamically - it is not being copied to the native element.
If I set a static value like maxlength="5" - it is being copied PROPERLY to the native element.
Trying interpolation like maxlength="{{VariableThatHoldsMaxLength}}" does not work.
Trying "native property" [maxlength]="VariableThatHoldsMaxLength" also does not work.
Thanks,
Eddy

Hello! Thanks for opening an issue with us! We are currently working on making a doc on how to use the new angular/forms that may help you with this issue. I will keep this issue open for now and then close when that doc is done. Thanks for using Ionic!

The new docs for forms just got pushed. http://ionicframework.com/docs/v2/resources/forms/ Thanks for using Ionic

Hello Justin,
Thanks for the forms doc.
It still does NOT address the issue I raised.
How can I set maxlength dynamically for a text input or textarea field?

@efishman15 Sorry about that. Actually, this should be fixed for good now. We unfortunately did not specify the exact version of @angular/forms in our npm install command in our beta.11 update it was installing a version that was not compatible with angular 2 rc4. This has since been fixed in the changelog. Would you mind going to your package.json and changing the @angular/forms entry to<EMAIL_ADDRESS>and then running npm install again? Thanks !

Hi Jason,
My package.json already points to @angular/forms version 0.2.0 - here are my dependencies from package.json:
"dependencies": {
"@angular/common": "^2.0.0-rc.4",
"@angular/compiler": "^2.0.0-rc.4",
"@angular/core": "^2.0.0-rc.4",
"@angular/forms": "^0.2.0",
"@angular/http": "^2.0.0-rc.4",
"@angular/platform-browser": "^2.0.0-rc.4",
"@angular/platform-browser-dynamic": "^2.0.0-rc.4",
"@angular/router": "^2.0.0-rc.2",
"es6-promise": "3.0.2",
"es6-shim": "0.35.0",
"ionic-angular": "^2.0.0-beta.11",
"ionic-native": "^1.1.0",
"ionicons": "^3.0.0",
"reflect-metadata": "0.1.3",
"rxjs": "^5.0.0-beta.6",
"zone.js": "^0.6.12"
}
In any case - I would appreciate if you can answer my question directly - if/once it is resolved - how should I pass the "maxlength" propertly for it to be set dynamically?
Thanks,
Eddy

Hello! So the syntax you are using for changing maxlength dynamically should work, but we need to get you on the correct version of the forms module first. So because npm follows semver when their is a caret in front of the version, like their currently is for your @angular/forms entry, then it will install the latest minor version of that package, which in this case is 0.3.0, which also does not happen to work with the current version of Ionic 2. So, even though its listed as "@angular/forms": "^0.2.0" you actually have 0.3.0 installed. To fix this you can change it to "@angular/forms": "0.2.0" and run npm install again.

Hello Justin,
So I took a look inside package.json inside @angular/forms folder - and the version says 0.2.0 and not 0.3.0.
Just to be sure - I removed the caret as you suggested, ran npm install and checked again: no change.
The maxlength attribute is set only on the ion-textarea element and NOT being copied to the textarea native element - thus the field allows me to type unlimited number of characters.
What now?
Eddy

I'm having a similar issue setting the max attribute dynamicallywith ion-input type="date", also on beta 11, also with @angular/forms version 0.2.0.  And no, I'm not using the ion-datetime component because my form is in a modal and everytime I exit the datetime component it closes the modal (and it can't be due to the backdrop, I tried that fix already).  So unless you have a fix for that I'm sticking with regular input type="date".

@efishman15  in the meantime a workaround would be to add the following code to your ionViewDidEnter function:
document.querySelector("#myInput").setAttribute("max", maxValue);

I am facing the exact issue as @efishman15 after the upgrade to beta 11. Any luck @jgw96 ??

I am facing the same issue with an <ion-input type="number">, I can't bind to the min, max and step properties as I described in this forum's topic.
My @angular/forms dependency is 2.1.1 and my ionic-angular dependency is 2.0.0-rc.3.

It appears between beta.11 and rc.3, the support for the type="number" attributes (step, min, max) was lost on ion-input.

I am no longer able to reproduce this issue using latest for the following attributes: maxlength, step, min, and max. Please let me know if you are still seeing it using rc.6 and I can reopen. Thanks!

It's not working with me
Ionic Framework Version: 2.3.0
also my dependencies
"@angular/common": "2.4.8",
    "@angular/compiler": "2.4.8",
    "@angular/compiler-cli": "2.4.8",
    "@angular/core": "2.4.8",
    "@angular/forms": "2.4.8",


Steps indicator is not centered if there's only 1 step

I'm playing with dynamic steps and noticed that if there's only 1 step declared (or every other steps are disabled), the step indicator will stick to the left. Adding &.steps-1  li { width: 100%; } does the trick.

Sounds like custom CSS is the answer to your issue, thanks.