Clarify the documentation

Say that the index is one-based.

OPS Build status updates of commit 80675d4:
:clock10: Preparing: average preparing time is 3 min(s) 18 sec(s)

OPS Build status updates of commit 80675d4:
:clock10: Incremental building: average incremental building time is 53 min(s) 52 sec(s)

OPS Build status updates of commit 80675d4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/Word.Documents.Item.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ant-222 Thanks for your contribution. I updated this manually because it's such a small change. In the future, please submit small changes like this on the ISSUES tab. I'm closing this PR without merging it.

Thank you, Linda.


python37Packages.Nikola: 8.1.2 -> 8.1.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.Nikola is: "A modular, fast, simple, static website and blog generator"
meta.homepage for python37Packages.Nikola is: "https://getnikola.com/"
meta.changelog for python37Packages.Nikola is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 8.1.3 with grep in /nix/store/c9n3lvra5zxr3xnnanlrgy35m1bc0i4s-python3.7-Nikola-8.1.3

directory tree listing: https://gist.github.com/a1685f9d809a62681db32575a340ec9c

du listing: https://gist.github.com/0196540f48e77c943b8ca6719a794c7c

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python37Packages.Nikola
python38Packages.Nikola
python39Packages.Nikola

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c9n3lvra5zxr3xnnanlrgy35m1bc0i4s-python3.7-Nikola-8.1.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.Nikola https://github.com/r-ryantm/nixpkgs/archive/a884ef62f5a8c07a2145613b56715d7d9e993af2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c9n3lvra5zxr3xnnanlrgy35m1bc0i4s-python3.7-Nikola-8.1.3
ls -la /nix/store/c9n3lvra5zxr3xnnanlrgy35m1bc0i4s-python3.7-Nikola-8.1.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

python37Packages.Nikola
python38Packages.Nikola
python39Packages.Nikola

Maintainer pings
cc @jluttine for testing.

Result of nixpkgs-review pr 113231 at a884ef62 run on aarch64-linux 1

3 packages built:

python37Packages.Nikola
python38Packages.Nikola
python39Packages.Nikola


Remove unused base test class module

When unittests were first added a base test class module base.py was
added. The intent was that when the tests were running in CI we'd be
running under stestr and want to have the base fixtures for test method
timeout, and capturing stdout, stderr, and pylogging when the tests were
running in parallel. However, running unittests in parallel isn't
necessary because it takes < 1 second to run all ~300 unittests and
running with stestr takes 2-5 seconds because of overhead launching
multiple processes (all compared to ~2-4 minutes to compile retworkx)
so this base test class went unused. This commit removes that base.py
test class module, if in the future we do start running tests in
parallel using stestr we can revert this and add it back.

Pull Request Test Coverage Report for Build 300615365

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.381%

Totals

Change from base Build 291922156:
0.0%

Covered Lines:
2201

Relevant Lines:
2357

💛  - Coveralls


🐛 Unable to start the react-native app after installing react-native-vision-camera.

What were you trying to do?
I simply create a react native app. And after that I install the react-native-vision-camera, and I unable to start the project.
Reproduceable Code
npx react-native@latest init AwesomeProject
npm i react-native-vision-camera
cd AwersomeProject
npm run start
npm run android

What happened instead?
I got an error.
When I got to ./android and try to run ./gradlew clean I got the same issue.
Relevant log output
PS C:\Users\Szabolcs\Desktop\Szaby\Projects\TSISApp2\tsisappp> npm run android

><EMAIL_ADDRESS>android
> react-native run-android

info Starting JS server...
info Installing the app...

> Configure project :react-native-vision-camera
VisionCamera: node_modules/ found at: C:\Users\Szabolcs\Desktop\Szaby\Projects\TSISApp2\tsisappp\node_modules
VisionCamera: Building with Hermes...
Warning: The 'kotlin-android-extensions' Gradle plugin is deprecated. Please use this migration guide (https://goo.gle/kotlin-android-extensions-deprecation) to start working with View Binding (https://developer.android.com/topic/libraries/view-binding) and the 'kotlin-parcelize' plugin.
VisionCamera: Frame Processors are disabled because REA v2 does not exist. C++ part will not be built.
WARNING:DSL element 'dexOptions' is obsolete and should be removed.
It will be removed in version 8.0 of the Android Gradle plugin.
Using it has no effect, and the AndroidGradle plugin optimizes dexing automatically.
5 actionable tasks: 5 up-to-date

FAILURE: Build failed with an exception.

* What went wrong:
The Android Gradle plugin supports only kotlin-android-extensions Gradle plugin version 1.6.20 and higher.
The following dependencies do not satisfy the required version:
project ':react-native-vision-camera' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.5.30

* Try:
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 8s

error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup.
Error: Command failed: gradlew.bat app:installDebug -PreactNativeDevServerPort=8081

FAILURE: Build failed with an exception.

* What went wrong:
The Android Gradle plugin supports only kotlin-android-extensions Gradle plugin version 1.6.20 and higher.
The following dependencies do not satisfy the required version:
project ':react-native-vision-camera' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.5.30

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 8s

    at makeError (C:\Users\Szabolcs\Desktop\Szaby\Projects\TSISApp2\tsisappp\node_modules\@react-native-community\cli-platform-android\node_modules\execa\index.js:174:9)
    at C:\Users\Szabolcs\Desktop\Szaby\Projects\TSISApp2\tsisappp\node_modules\@react-native-community\cli-platform-android\node_modules\execa\index.js:278:16
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async runOnAllDevices (C:\Users\Szabolcs\Desktop\Szaby\Projects\TSISApp2\tsisappp\node_modules\@react-native-community\cli-platform-android\build\commands\runAndroid\runOnAllDevices.js:82:7)
    at async Command.handleAction (C:\Users\Szabolcs\Desktop\Szaby\Projects\TSISApp2\tsisappp\node_modules\@react-native-community\cli\build\index.js:108:9)
info Run CLI with --verbose flag for more details.

Device
Huawei Honor 9X Android
VisionCamera Version
"react-native-vision-camera": "^2.15.4"
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

same over here

If you are using Expo, it's recommended that you use the following command:
expo install react-native-vision-camera
Expo docs:
"We recommend always using npx expo install instead of npm install or yarn add directly because it allows Expo CLI to pick a compatible version of a library when possible and also warn you about known incompatibilities."

to add from @javier-sauma-rocketlab 's answer.
If you're using expo, install expo-build-properties ( https://docs.expo.dev/versions/latest/sdk/build-properties/ ) to change kotlin version
{
  "expo": {
    "plugins": [
      [
        "expo-build-properties",
        {
          "android": {
           ...,
           "kotlinVersion": "1.7.0"
          }
        }
      ]
    ]
  }
}

Try this https://www.youtube.com/watch?v=8QW5HDa4lQU&list=PLQhQEGkwKZUrempLnmxjt7ZCZJu1W3p2i&index=67

Same issue

I just added kotlinVersion = "1.7.0" to android/build.gradle and now it's working.

Closing as this is a stale issue - this might have been fixed with the full rewrite in VisionCamera V3 (🥳) - if not, please create a new issue.
If your issue has been fixed, consider sponsoring me on GitHub to say thanks 💖


Missing instruction on installing TFX

This page asks the user to use a tfx extension create command but does not instruct the user to actually install that tool:
npm i -g tfx-cli
I found the information on another how-to guide but was a bit of a speed bump in my quick start. Luckily it drove me to the comments where I saw I needed a newer NPM SDK as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 14955ee9-29f2-46fe-3a8d-a42666f53ffc
Version Independent ID: 5d417cd0-a671-ee30-8fca-5f8b0addd328
Content: Develop a web extension for Azure DevOps Services - Azure DevOps
Content Source: docs/extend/get-started/node.md
Product: devops
Technology: devops-ecosystem
GitHub Login: @apawast
Microsoft Alias: apawast

Hi @diom, Thanks for the feedback, although the step for installing the TFX tool is step #3 within the Prerequisites section. Thank you!


Array(T) implementation

Array(T) implementation

I feel like I forced you into breaking lines and that you're not really used to

Be a little. But on the other hand I have slightly reduced the font size and now I have 3x2 editor windows instead of 2x2 :)

Feel free to just merge these things as-is and I'll probably

Did I understand correctly that getting the approval status from you means that I can merge despite the remaining conversation?

I have slightly reduced the font size and now I have 3x2 editor windows instead of 2x2 :)

Heh, nice. Personally, I usually have two editors + one term but rather big font so that I can sit back nice and comfy at a bit of a distance from the screen.

Did I understand correctly that getting the approval status from you means that I can merge despite the remaining conversation?

Yes. "approved" + remaining comments means that I consider the remaining stuff minor enough that it is very unlikely that this will need another review after you fixed them (e.g. fix a comment) or that they are merely hints that don't block the PR at all (e.g. style stuff).
On the matter of merges, I'd like to propose that we generally merge PRs via squash to get rid of all the minor fix-up commits, commits that get created when you accept suggestions in the GH GUI, intermediate merges etc.. It is also possible to do interactive rebases (via a desktop client / CLI) and then do a regular merge, where you can clean up all this stuff on a commit by commit level. However, if you're not already familiar with that workflow, I will freely admit that it has quite a steep learning curve and there is a high chance to mess things up until you're used to it, so when in doubt, just go with the squash. :)

However, if you're not already familiar with that workflow, I will freely admit that it has quite a steep learning curve and there is a high chance to mess things up until you're used to it

I've never done this before, but I can't get past an issue that "has a pretty steep learning curve" and not try it:). Can you give me a link to some guide that you can start with?

It depends a bit on what client you're using. For a guide using the CLI, this one looks quite solid:
https://matthewsetter.com/git-interactive-rebase/
Also, the official doc:
https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
Another neat feature closely related:
https://blog.sebastian-daschner.com/entries/git-commit-fixup-autosquash
What makes the learning curve steep is mostly the fact that you need to force-push your changes after an interactive rebase (actually, any kind of rebase where you're rewriting history that you have previously pushed already) and you can break / change history on the remote branch. For this reason, before doing IBs for clean-up before merging, I will generally create a new branch from the branch that I intend to clean-up, do the IB on the copy and if something goes horribly wrong, I can just undo all changes by deleting the entire branch and creating a new one (instead of having to painfully fix it via reflog) and, when I'm happy, merge this into master.
You can force-push onto feature branches for clean-up or rebase, but whatever you do, never force-push onto master -- it will break everyone's local copies! :p
Personally I use TowerGit these days which makes IBs a lot easier because you can mostly just drag & drop commits around as well as just deleting and rewriting any commit without any hassle, but it's paid software.


Enhancement to allow jobs to be "versioned"

Code in job handlers can become out of date when you restart workers after a deploy.
Example: a method used in a job handler has been renamed as part of a deploy, the worker restarts (loading the new code) and tries to run the job, resulting in a NoMethodError.
Other times when this might be a problem: deploying changes that affect marshalling, Ruby / Rails major updates.
This PR adds the notion of job "version".
New jobs are given the version specified in Delayed::Worker.current_version.
Similarly, workers scope jobs to the version specified in Delayed::Worker.current_version.
Now, if deploying code you think might affect already-queued jobs, you can bump the version with Delayed::Worker.current_version = "whatever"
Post deploy, newly created jobs are not available to workers until they restart.
When you restart a worker, jobs created with the old version will no longer be visible to the worker and so will not be invoked by it.
Ideally you'd have multiple workers, so restarting "worker A" with the new version leaves "worker B" to pick up the remaining jobs (until it restarts)
Alternatively, jobs created with the old version will just sit in the queue, giving you the opportunity to handle them manually in the console.
I've made the necessary changes to delayed_job_active_record in another PR

This isn't something we want to take on support for, but you might consider releasing your own gem adding this feature to Delayed Job. This part could likely primarily be implemented using a plugin like https://github.com/collectiveidea/delayed_job/blob/master/lib/delayed/plugins/clear_locks.rb that implements a before enqueue callback to set the version on the job.


TypeError: Cannot read properties of undefined (reading code)

Extension version: 0.78.1
VSCode Version: 1.85.1
OS: Darwin x64 22.6.0
Repository Clone Configuration (single repository/fork of an upstream repository): Private
Github Product (Github.com/Github Enterprise version x.x.x): github.com

Steps to Reproduce:
When trying to fetch pull requests, there are times when it works and times when it suddenly stops working. These errors pop up whenever I try:
2024-01-05 12:04:22.871 [error] GitHubRepository> Fetching all pull requests failed: TypeError: Cannot read properties of undefined (reading 'code')

The same issue on my "Microsoft Windows [Version 10.0.19044.3803]".
Could you please take a closer look at this issue?

Same here on Windows 11, also VSCode 1.85.1. It worked fine for like an hour, then it stopped working. After closing all VSCode windows, the auto-update progress dialog briefly appeared. I started VSCode again and now it succeeds fetching the PR information and displays the GitHub Pull Requests icon in the activity bar again.
2024-01-19 12:29:18.572 [info] Review+0> Switch to Pull Request #436 - start
2024-01-19 12:29:18.704 [info] PullRequestGitHelper> Tried to checkout smartgraph-attribute-validation, but branch is already checked out.
2024-01-19 12:29:18.706 [info] Review+0> Switch to Pull Request #436 - done
2024-01-19 12:29:18.706 [info] Review+0> Validate state in progress
2024-01-19 12:29:18.706 [info] Review+0> Validating state...
2024-01-19 12:29:18.713 [info] Found GitHub remote for folder c:\ArangoDB\docs-hugo
2024-01-19 12:29:18.715 [info] Using in-memory cached assignable users.
2024-01-19 12:29:18.779 [info] Review+0> No matching pull request metadata found locally for current branch smartgraph-attribute-validation
2024-01-19 12:29:19.016 [info] Repo state for file:///c%3A/ArangoDB/docs-hugo changed.
2024-01-19 12:29:19.016 [info] Repo file:///c%3A/ArangoDB/docs-hugo has already been setup.
2024-01-19 12:29:19.020 [error] GitHubRepository> Unable to fetch issues with query: TypeError: Cannot read properties of undefined (reading 'code')
2024-01-19 12:29:19.021 [error] GitHubRepository> Unable to fetch issues with query: TypeError: Cannot read properties of undefined (reading 'code')
2024-01-19 12:29:19.021 [error] GitHubRepository> Unable to fetch issues: TypeError: Cannot read properties of undefined (reading 'code')
2024-01-19 12:29:19.036 [error] GitHubRepository> Fetching pull requests for branch failed: TypeError: Cannot read properties of undefined (reading 'code')
2024-01-19 12:29:19.036 [info] Review+0> No matching pull request metadata found on GitHub for current branch smartgraph-attribute-validation
2024-01-19 12:29:19.037 [error] GitHubRepository> Unable to fetch issues with query: TypeError: Cannot read properties of undefined (reading 'code')
2024-01-19 12:29:19.281 [error] GitHubRepository> Unable to fetch issues without milestone: TypeError: Cannot read properties of undefined (reading 'code')
2024-01-19 12:29:23.459 [error] Cannot read properties of undefined (reading 'code')
2024-01-19 12:29:26.593 [error] Cannot read properties of undefined (reading 'code')
2024-01-19 12:29:27.972 [error] Cannot read properties of undefined (reading 'code')

Fixed in the pre-release version of the extension.


ark-server-tools overwrites GameUserSettings.ini?

Hello,
Is it possible that the server tools overwrites my configuration each time I enter arkmanager start?
I put something in /home/ark/ARK/ShooterGame/Saved/Config/LinuxServer/GameUserSettings.ini or /home/ark/ARK/ShooterGame/Saved/Config/CleanSourceConfigs/GameUserSettings.ini and after a start it's deleted.
Can I search the problem here or somewhere else? Maybe you can help?
Thanks in Advance!

https://github.com/FezVrasta/ark-server-tools/issues/294
and
https://github.com/FezVrasta/ark-server-tools/issues/260

Your config is invalid therefore ark itself cleans it up.

Oh that's bad :-1:
First try generated through http://ini.arkforum.de/.
Second try generated through ARK Server Manager. (The Windows GUI one)
And it's overwritten with both.
Maybe encoding is different!?

Are all the settings being overwritten or just some of them?

Only write /home/ark/ARK/ShooterGame/Saved/Config/LinuxServer/GameUserSettings.ini.  Do not write /home/ark/ARK/ShooterGame/Saved/Config/CleanSourceConfigs/GameUserSettings.ini
How are you writing to the file?

@FezVrasta:
Yes the whole file is overwritten. (Game.ini and GameUserSettings.ini)
@klightspeed:
I write only the first one.
I tried to delete this /home/ark/ARK/ShooterGame/Saved/Config/CleanSourceConfigs/ and /home/ark/ARK/ShooterGame/Config/ Folder.
Maybe the attachments are helpfull to help me? :)
My-GameUserSettings.ini.txt
My-Game.ini.txt
And after start and stop:
Overwritten-GameUserSettings.ini.txt
Overwritten-Game.ini.txt

Your GameUserSettings.ini contains UTF8 characters (i.e. characters with codepoints above 127 - e.g. your ß character).  The last time I checked, the ARK server did not support UTF8, and instead used UTF16 when writing configs with non-ascii characters.

@klightspeed ;
Hmm it's not working if I remove them.
And very funny:
I set the files read only with chattr +i GameUserSettings.ini and can't modify it manually.
After server start the whole folder is deleted and recreated.
I don't know what's wrong with this :-1:

Of course setting the file immutable is going to cause you to be unable to modify it.
Setting the file immutable does not prevent it from being deleted.

Ah and before you mean I should change the windows crlf to unix lf? Let me try it :+1:

Ah and before you mean I should change the windows crlf to unix lf? Let me try it :+1:

Negative, no, nein.
The server will just change the Unix LF newlines back to Windows CRLF newlines.  If you use a decent editor, it should have no problem with Windows CRLF newlines.

Ok so what could I try?
By the way: Thanks for help!

Do not set the file immutable or read-only, and make sure the ARK server has permission to write the file
Ensure that there are only ASCII characters in the ini file, or that you convert the file to a UTF16 encoding with Byte Order Mark (BOM) using e.g. iconv -f utf8 -t utf16 My-GameUserSettings.ini.txt -o GameUserSettings.ini
Do not write the CleanSourceConfigs

With your command the file looks in nano like...

And its annoying -.-
Each time I enter arkmanager start the whole directory is overwritten I think.

I replaced all ß with ss and the ä with a.
Something about permissions... I tried:

Folder LinuxServer deleted and server started

2.1. File permissions changed AND files replaced with mine (if not then there is no change)

2.2. After server start

Don't know what's wrong :-1:

Ok how I fixed this after few hours of testing...

Reinstalling server folder with arkmanager install (and rm -rf /home/ark/ARK before)
Starting the server arkmanager start
Stopping the server arkmanager stop
Editing the server configuration via Notepad++ (Downloaded file and uploaded after) and added only the variables to the sections. Not deleting existing ones. So at the end I removed only duplicated entries. Then I had for example RCON Options at the top. (Which are default)
Starting

I think the problem is either the missing RCON configuration or some things which are important or it was an encoding problem or dont know some file related things and because I add only things it doesnt affect the header of the file.
But I'm happy now - It work's :+1:

This is how to fix it, had the same problem.
And dont delete something out of the generated files.


Request: Output all call sites which refer to a given function

Scenario: I have a method (ruby) defined in a model somewhere. I'd like to identify all call sites which call this method and call sites that refer to those call sites up to some given limit. This sounds like a subset of the graph which is generated.

This has been something I’ve been thinking about given code2flow’s recent popularity boost. The graphs quickly get unwieldy past 100 functions or so and could be made more useful by limiting their scope in the way you describe.
On the CLI I don’t know how this could be implemented elegantly. Adding a parameter for an exact name match of the function of interest might work… but it feels like doing this with a GUI would be a better approach. It also feels like a GUI is almost inevitable if the project is to evolve.
Would be curious if you had more thoughts as well. The more useful the tool is for actual development - the better

Yeah, exactly - or the ability to prune nodes that end up as calls into frameworks, etc.
I think having this call graph representation and the ability to query it would be super useful for other stuff like a GUI, or an LSP-speaking server that'd plug into code editors, etc. Rolling this parse/store/analyze capability into a library would make it reusable from other places.
If this becomes the case and you have to analyse large amounts of code, some kind of a representation on disk might come handy - to be updated incrementally only when some of the code changes.
Anyway - I'm going to look into this call-graph subgraph thing to see if I can come up with anything useful.

Shouldn’t be too tricky. I think it would be basically the last step before outputting results. Then it would be nice to have both upstream and downstream number of nodes as CLI args. Let me know if you wanted to take a stab at it. Otherwise will maybe do it myself in a few days. It’s a good idea.

👍 I have the same need 😄
Yeah a UI would be an elegant solution but specifying a function or class name with an optional depth parameter would probably solve most use cases.
This could in-deed be done as a post processing step. Was looking into how I could do this filtering on dot files. But obviously direct support in code2flow would be even better.
Vaguely interesting things I found related to this:

Filtering dot files (1)
Filtering dot files (2)
Dot file GUI
[Graph awk like utility]https://linux.die.net/man/1/gvpr

I actually just started working on the feature - lest anyone else accidentally replicate my work. The work in progress has three new parameters:

--target-function
--upstream-depth
--downstream-depth

I don't feel great about the names so would be curious if anyone has better suggestions. Also whether there is anything I am overlooking with that basic interface.

PR open. If anyone could take a look it would be helpful. Otherwise, will merge and release in a few days. https://github.com/scottrogowski/code2flow/pull/44

I'll give it a spin tomorrow.

Went ahead and merged. Please do suggest anything else that could make it better. Thanks for the suggestion!


add bandit pip install

before this commit: bandit is not installed for travis and
coveralls is missing a '-'
after this commit: bandit is installed for travis use and
coveralls has the missing '-'

@kalpatel01 - clean commit.

https://github.com/Bridgewater/appetite/pull/8


[BUG] Double signature bugs

On version v1.5.4. We are seeing behavior where the same signature will appear in the signatures list twice.
When pasting new signatures with lazy delete when two are present, one will be deleted. When pasting new signatures with lazy delete when one is present, a second will sometimes be added.

I have a question on this. Did you add the WKH signature manually? If so did you just add the letters and not the numbers? I have done this in the past and as I see it the system should see that as a different signature.

@eophten I think @CalMatar is right with his assumption.
Hot it works:

The "preview" table matches rows by the full name of a signature: WKH-190 (including numbers). This is done in JS (client side)

If there is a signature manually added with WKH, a new pasted WKH-190 Sig is interpreted as new, and the current WKH is flagged for delete (red row)
Sometimes there are two signatures with the same letters in a system e.g. WKH-190, WKH-180, so we can not just check the first 3 letters for row matching.

Saving the signature reader dialog, submits parsed "Scan result" (from textarea) to the server (not the content of the preview table)

The final validation and "row matching" is done in PHP (server side)
New sig rows now have a unique Id after saving them to the DB.

@exodus4d i was able to go back through our discord logging (this bug was bubbled up to me from my users), it looks like the WKH signature was added manually.
From a feature enhancement perspective, would a way to disable the manual addition of signatures?  For the life of me, I cannot think of a time when I (or any other pilot) shouldn't be adding the signature from the probe scanner copy/paste directly.
If that is too heavy handed, is there a way to surface a visual cue for manually added signatures versus signature read signatures?

Adding signatures manually is fine. The issue here is, that someone forget to add the numbers to its name.
You can see the full name in the tooltip, but I agree that this is not obvious or practicable.

We could think about a stronger validation (3 letters + dash + 3 numbers). This would solve the problem but would prevent users to add some temp/custom signatures to a system e.g. a "floating can" can no longer have a signature called "CAN".... (sry can´t find a better example :D)

Stronger validation would be great!

Signature ID (e.g. ABC-123) now has a stronger validation:


Update line 816 of URIUtility.cs

The variable mode does not exist, should it have been named as parseMode?

As it appears, this particular change, among others, was already made some time ago, but just wasn't committed or pushed yet.  Now I have done so.
Thank you, anyway.


preview badge doesn't scale properly

On galliumos on my pixel, the preview badge is very small relative to everything else:

I think it's the proper size in pixels, but there's something with the scaling that makes it appear small.

I think this was just a hidpi issue on my machine.


Improve Documentation

Documentation of the repo needs to be improved.
(Mostly people who handle social media platforms use these tools)

I can pick this up.
Any specific suggestions/improvements you had in mind?

Sure, please do!
You can take the current documentation for reference purpose and try to keep the description in simple language because many people who want to use these tools are not from technical background :)

Sorry, i couldn't figure out how to make the documentation even simpler than it is.
Maybe someone else can pick this up. if any ideas...


[BEAM-10695] Fix InteractiveEnvironment cannot evict PCollection

Change-Id: I271efeef53f99c8083a6d37b89085cddd63bf56a
The code in the InteractiveEnvironment was manipulating the _computed_pcollections set while iterating.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @davidyan74

R: @KevinGG

R: @pabloem


Permanent storage for app

Hello!
Is it possible to attach permanent storage for an application? E.g. I have a Laravel application and I want to locally store uploaded files. This requires to set up a symlink from the /storage/app to public/storage. I got around this by setting the base path to public/storage. Now the only issue is when I uploaded an image, redeployed the application, it disappears, as the storage is recreated again. Is it somehow possible to set a permanent storage for an app?

This is not currently possible, though watch #1521 for an upcoming solution.

Wow, that was fast! Thank you, I'll look into S3 then :)


Use with files plugin

I've posted here https://github.com/grammyjs/files/issues/4, but I reposted here for more exposure.
The files plugin use bot.api.config.use for configuration. Is it safe to use hydrateFiles(token) within conversation.run?

You can call ctx.api.config.use inside conversation.run, yes. Safe in what way?

You can call ctx.api.config.use inside conversation.run, yes. Safe in what way?

Ah, I just mean is it possible to use inside that function. Thanks for clarifying.


[refactor]: Block and sumeragi refactor

Description
I was poking around the codebase and refactored a few things:

with ProofBuilder we're assured that proof always has at least one signatures
with BlockBuilder only block that is chained and signed is called a block. Intermediate stages are encapsulated with the builder
the lifecycle of blocks is now SignedBlock -> ValidBlock -> CommittedBlock
only VersionedSignedBlock is allowed across network
optimized CommittedBlock impls of Eq and Ord
move AcceptedTransaction into iroha_genesis
refined our Value enum

Linked issue

Closes #3397

Benefits

Checklist

[x] I've read CONTRIBUTING.md
[x] I've used the standard signed-off commit format (or will squash just before merging)
[x] All applicable CI checks pass (or I promised to make them pass later)
[ ] (optional) I've written unit tests for the code changes
[ ] I replied to all comments after code review, marking all implemented changes with thumbs up

I'll approve when all tests pass

I will close this because I'm splitting it out in multiple PRs


[WIP] Update find-build for payload diffs

Liking the changes. Too bad about that merge conflict though.

Superseded by #41


Fixup standalone

This PR fixes 2 issues:

When emitting COM interfaces with standalone_sys the type aliases were not pub like everything else.
Nested types were not being crawled when gathering the types, which would result in fields in nested records that used types that were unique to them to not be emitted

Fixes: #2478
Fixes: #2479

Thanks for the fix! Just need to rerun cargo run -p tool_core to regenerate the internal bindings.

When emitting COM interfaces with standalone_sys the type aliases were not pub like everything else.

The trouble here is that this may introduce name collisions. I'm not opposed to changing it, but we'd need to be a bit more explicit in windows-core about how we refer to those bindings.

Oof, yah, that broke everything.

I can fix that up in a separate PR if you'd prefer. Let me know.

Sounds good - I can find a prettier solution separately.


Please Support stickyHeader

Since stickyHeader is not currently considered, Index will shift when stickyHeader is entered.

8ac9973064fc077858062156bc01189a7259574b Added compatibility with sticky headers. This might break in the future as sticky headers are still experimental.


Convert PCF Dev api to PCF Dev agent

Not really a valid, comprehensive, well-tested pr. Just a proof of concept around having the PCF Dev api binary behave more like an "agent".
The idea being similar parity with the BOSH ecosystem where we have an agent that the PCF Dev cli or vagrant CLI can talk to perform tasks like provision, set up ssh, generate certs, etc. Presently it behaves closely, but having the provision binary set up the "api" as another monit service, seems like an imperfect implementation. If modeling the BOSH ecosystem more closely, waiting for the BOSH agent to come up before the deployment does is one the of first operations that happens.
I believe this promotes a better adherence to the principles of encapsulation and is easier to understand at a high level.

@aemengo Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


US-10388 : create static page for user to choose a right child benefit service

closing this as old one is present


Specify file encodings in Python scripts

Specifies UTF-8 encoding when reading and writing files in the Python scripts.
Fixes building on Windows, where the scripts would fail by attempting to read files using the cp1252 encoding that is the default for Python on Windows.

Wow, would have thought python 3 would have made windows use a more sensible encoding by default...


docs: edit landing page to explain what, why, and how about CDaaS

The edits to the docs landing page in this PR are related to our efforts to communicate to the platform engineer doing research in Armory CD-as-a-Service that we are worth the time and effort of doing a real spike with their real apps.
Specifically this PR is refactoring the landing page to answer the following questions:

What is CD-as-a-Service?
Why use CD-as-a-Service / Why did we make it?
How does CD-as-a-Service work?

Related tickets:

CDAAS-2373

merged with Arch PR 26


non-selectable socket created

Still getting this inside containers for lbrycrd. I can't run lbrycrd in a container after initial sync. If the container goes down or if its stateless and is recreated, this error pops up and crashes lbrycrd. All versions <IP_ADDRESS> and up.
lbrycrd_1  | 2020-02-20T04:17:31Z BerkeleyEnvironment::Open: LogDir=/data/.lbrycrd/database ErrorFile=/data/.lbrycrd/db.log
lbrycrd_1  | 2020-02-20T04:17:32Z [default wallet] nFileVersion = 170302
lbrycrd_1  | 2020-02-20T04:17:32Z [default wallet] Keys: 2002 plaintext, 0 encrypted, 2002 w/ metadata, 2002 total. Unknown wallet records: 1
lbrycrd_1  | 2020-02-20T04:17:32Z [default wallet] Wallet completed loading in              60ms
lbrycrd_1  | 2020-02-20T04:17:32Z [default wallet] setKeyPool.size() = 2000
lbrycrd_1  | 2020-02-20T04:17:32Z [default wallet] mapWallet.size() = 1
lbrycrd_1  | 2020-02-20T04:17:32Z [default wallet] mapAddressBook.size() = 1
lbrycrd_1  | 2020-02-20T04:17:32Z mapBlockIndex.size() = 741815
lbrycrd_1  | 2020-02-20T04:17:32Z nBestHeight = 719000
lbrycrd_1  | 2020-02-20T04:17:32Z Cannot create connection: non-selectable socket created (fd >= FD_SETSIZE ?)
lbrycrd_1  | 2020-02-20T04:17:32Z Error: Couldn't open socket for incoming connections (socket returned error No such file or directory (2))
lbrycrd_1  | 2020-02-20T04:17:32Z Cannot create connection: non-selectable socket created (fd >= FD_SETSIZE ?)
lbrycrd_1  | 2020-02-20T04:17:32Z Error: Couldn't open socket for incoming connections (socket returned error No such file or directory (2))
lbrycrd_1  | 2020-02-20T04:17:32Z Error: Error: Couldn't open socket for incoming connections (socket returned error No such file or directory (2))
lbrycrd_1  | Error: Error: Couldn't open socket for incoming connections (socket returned error No such file or directory (2))
lbrycrd_1  | Error: Failed to listen on any port. Use -listen=0 if you want this.
lbrycrd_1  | 2020-02-20T04:17:32Z Error: Failed to listen on any port. Use -listen=0 if you want this.
lbrycrd_1  | 2020-02-20T04:17:32Z tor: Thread interrupt
lbrycrd_1  | 2020-02-20T04:17:32Z Shutdown: In progress...

I'm getting this too.

How this can happen
https://github.com/lbryio/lbrycrd/blob/master/src/compat.h#L114
I suspect using an onld build or build that not include these changes

@bvbfan I'm just using the binary from the v<IP_ADDRESS> release

Can you use v<IP_ADDRESS> where the fix presents. It needs full reindex for SQLite backend.

Don't use 17.4.2. It has too many bugs. I'll post a new build shortly.

Confirmed fix is good on 17.4.3 release


more variety in colors for leisure= features

leisure=stadium and leisure=pitch currently render in the same color. the result is that yankme stadium renders as a blob as the two are indistinguishable. the situation at the Polo Grounds is only slightly better.
https://www.openhistoricalmap.org/#map=16/40.8289/-73.9347&layers=O
time slider 1930 shows both stadiums

confirmed on live site:

confirmed on live site:


toml_edit: value is not written if table is constructed beforehand

The following code simply discards the last write to the tests sub-key.
use toml_edit::{DocumentMut, value};

fn main() {
    let toml = "";
    let mut doc = toml.parse::<DocumentMut>().expect("invalid doc");
    // doc["tool"] = toml_edit::table();
    // doc["tool"]["typst-test"] = toml_edit::table();
    doc["tool"]["typst-test"]["tests"] = value("tests");
    println!("doc: \n{}\n", doc.to_string());
}

Produces the following output:
tool = { typst-test = { tests = "tests" } }

Uncommenting the second line produces:
tool = {}

Uncommenting the second and first line produces:
[tool]

[tool.typst-test]
tests = "tests"

When inspecting the table tool.typst-test, the value exists, it's simply not written.

I've updated the reproduction case to make it easier to follow
#!/usr/bin/env nargo
---
[dependencies]
toml_edit = "0.22"
---

use toml_edit::{DocumentMut, value};

fn main() {
    let toml = "";
    let mut doc = toml.parse::<DocumentMut>().expect("invalid doc");
    doc["tool"]["typst-test"]["tests"] = value("tests");
    println!("doc: \n{}\n", doc.to_string());

    let toml = "";
    let mut doc = toml.parse::<DocumentMut>().expect("invalid doc");
    doc["tool"] = toml_edit::table();
    doc["tool"]["typst-test"]["tests"] = value("tests");
    println!("doc: \n{}\n", doc.to_string());

    let toml = "";
    let mut doc = toml.parse::<DocumentMut>().expect("invalid doc");
    doc["tool"]["typst-test"] = toml_edit::table();
    doc["tool"]["typst-test"]["tests"] = value("tests");
    println!("doc: \n{}\n", doc.to_string());

    let toml = "";
    let mut doc = toml.parse::<DocumentMut>().expect("invalid doc");
    doc["tool"] = toml_edit::table();
    doc["tool"]["typst-test"] = toml_edit::table();
    doc["tool"]["typst-test"]["tests"] = value("tests");
    println!("doc: \n{}\n", doc.to_string());
}

$ ./toml_edit-762.rs
warning: `package.edition` is unspecified, defaulting to `2021`
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.05s
     Running `/home/epage/.cargo/target/84/93c6f0d3e9e9a2/debug/toml_edit-762`
doc:
tool = { typst-test = { tests = "tests" } }

doc:
[tool]
typst-test = { tests = "tests" }

doc:
tool = {}

doc:
[tool]

[tool.typst-test]
tests = "tests"

To understand whats going on, I'm going to show the debug repr
[/home/epage/.cargo/target/84/93c6f0d3e9e9a2/toml_edit-762.rs:25:5] &doc = DocumentMut {
    root: Table(
        Table {
            decor: Decor {
                prefix: "default",
                suffix: "default",
            },
            implicit: false,
            dotted: false,
            doc_position: None,
            span: None,
            items: {
                "tool": TableKeyValue {
                    key: Key {
                        key: "tool",
                        repr: None,
                        leaf_decor: Decor {
                            prefix: "default",
                            suffix: "default",
                        },
                        dotted_decor: Decor {
                            prefix: "default",
                            suffix: "default",
                        },
                    },
                    value: Value(
                        InlineTable(
                            InlineTable {
                                preamble: empty,
                                implicit: false,
                                decor: Decor {
                                    prefix: "default",
                                    suffix: "default",
                                },
                                span: None,
                                dotted: false,
                                items: {
                                    "typst-test": TableKeyValue {
                                        key: Key {
                                            key: "typst-test",
                                            repr: None,
                                            leaf_decor: Decor {
                                                prefix: "default",
                                                suffix: "default",
                                            },
                                            dotted_decor: Decor {
                                                prefix: "default",
                                                suffix: "default",
                                            },
                                        },
                                        value: Table(
                                            Table {
                                                decor: Decor {
                                                    prefix: "default",
                                                    suffix: "default",
                                                },
                                                implicit: false,
                                                dotted: false,
                                                doc_position: None,
                                                span: None,
                                                items: {
                                                    "tests": TableKeyValue {
                                                        key: Key {
                                                            key: "tests",
                                                            repr: None,
                                                            leaf_decor: Decor {
                                                                prefix: "default",
                                                                suffix: "default",
                                                            },
                                                            dotted_decor: Decor {
                                                                prefix: "default",
                                                                suffix: "default",
                                                            },
                                                        },
                                                        value: Value(
                                                            String(
                                                                Formatted {
                                                                    value: "tests",
                                                                    repr: "default",
                                                                    decor: Decor {
                                                                        prefix: "default",
                                                                        suffix: "default",
                                                                    },
                                                                },
                                                            ),
                                                        ),
                                                    },
                                                },
                                            },
                                        ),
                                    },
                                },
                            },
                        ),
                    ),
                },
            },
        },
    ),
    trailing: empty,
}

InlineTables are implicitly being created.  When we go to render the values in an InlineTable but we come across a Table, we ignore it.

Unsure how well this is documented (I wanted to do the above before confirming) but
doc["tool"]["typst-test"]["tests"] = value("tests");

always produces inline tables for the intermediate tables and its left to the caller to put in standard tables, correctly, if they want that.
The question is what we should do moving forward

Leave it as-is
Add an assert when inserting, with [], a standard table into a Value
Change the rendering code to implicitly convert standard tables into inline tables / arrays.

always produces inline tables for the intermediate tables and its left to the caller to put in standard tables, correctly, if they want that.

I think that's the part that confused me when I initially used it (it makes somewhat sense in hindsight). An assertion seems like the best option to me, implicit conversion could cause problems elsewhere and be even more confusing, and leaving it as is, just seems wrong. It should definitely not swallow whatever I put in there without warning.

Created a test case

#[test]
fn table_under_inline() {
    let mut doc = DocumentMut::new();
    doc["tool"]["typst-test"] = table();
    doc["tool"]["typst-test"]["tests"] = value("tests");

    assert_data_eq!(doc.to_string(), str![[r#"
tool = {}

"#]]);
}

Another approach is we switch from creating inline tables implicitly to we create Tables implicitly unless we are in a Value and then we create an InlineTable.  While it doesn't solve all problems, it will make it so there is less of a chance of people using the API incorrectly.


new issue

Precondition
This condition must be met
Steps to Reproduce:
Step 1  [Retest]
Step uno
Expected Result
Goes 1
Step 2  [Pass]
Second goes
Expected Result
Goes thwo
Step 3  [Pass]
The classic third
Expected Result
goe three

Open Defect in TestQuality

Test testaroo in Run Run 550 (linked to Cycle All tests).

Open Requirement in TestQuality


Fix for operations bound to directoryObjects/deletedItems

Closes #449
Adds Org.OData.Core.V1.ExplicitOperationBinding and Org.OData.Core.V1.RequiresExplicitBinding annotations to functions bound to directory objects type to unlock generation of functions/actions on /deletedItems path
Depends on release of https://github.com/microsoft/OpenAPI.NET.OData/pull/430
TODO -

[x] validate beta
[x] validate v1

Validation notes
This PR ends up dropping functions/actions listed above in the following navigation properties paths that are of the type directoryObject paths in the final openApi metadata which looks to be valid given the testing and available documentation leading to some path reduction.

/groups/{group-id}/permissionGrants - No supporting docs and queries fail on GE. Can only be listed according to the docs. Contains target is true.
/teams/{group-id}/permissionGrants - No supporting docs and queries fail on GE. Can only be listed according to the docs. Contains target is true.
/chats/{group-id}/permissionGrants - No supporting docs and queries fail on GE. Can only be listed according to the docs. Contains target is true.
/identityGovernance/entitlementManagement/connectedOrganizations/{id}/externalSponsors - No supporting docs and queries fail on GE. Can only Add, list and delete. Should probably have contains target as false?.
/identityGovernance/entitlementManagement/connectedOrganizations/{id}/internalSponsors - No supporting docs and queries fail on GE. Can only Add, list and delete. Should probably have contains target as false? . Similar to externalSponsors above in 4.
/policies/appManagementPolicies/{id}/appliesTo - No supporting docs and ContainsTarget is false. Ideally functions/actions should not be bound to references.

Let's also set the internal and external sponsors to contains target false since https://learn.microsoft.com/en-us/graph/api/connectedorganization-post-internalsponsors?view=graph-rest-1.0&tabs=http uses a $ref to add a sponsor.

Agreed. Resolved in latest update


Feature Request: Send Messages

Ability to send messages via Xbox LIVE from authed user. Must keep Xbox's message limits in mind (100 messages per day?)

Looks like #78 added send message functionality


App won't start as of Sonoma 14.4.1

Hi Sam,
Thanks for developing and supporting this great project. I updated my MacBook Pro (M3 Max) to Sonoma 14.4.1 today and I get the message,
"Could not start Maestral
Could not start or connect to sync daemon. Please try again and contact the developer if the issue persists."
The timing with the MacOS update could be coincidental, maybe I've messed something up on my end in my Mac settings? Not sure, thought I'd flag it...
Thank you again!
Best,
Rory

Could you check ~/Library/Logs/maestral/maestral.log for any reported errors?

I've got Maestral installed on three Macs all running 14.4.1 and not seeing this issue on any of them.


MWPW-120935 - [SEO Structured Data] Event

add SEO data when the page is set as Event in the metadata

Resolves: MWPW-120935
Notes:

mixed event is not supported ("eventAttendanceMode": "https://schema.org/MixedEventAttendanceMode”,)
authoring (Word/gdoc): meta data key is written with ‘-‘  so that it’s easier to read in HTML:

Word/gdoc: Offers-Price-Currency | USD
HTML: <meta name="offers-price-currency" content="USD”>

Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/jck/test-seo-event?martech=off
After: https://seo-event--milo--adobecom.hlx.page/drafts/jck/test-seo-event?martech=off

Content model:

JSON-LD in the rendered HTML:

@jckautzmann I'm finally getting around to this. The more I think about this, the more I think this should be a regular block.
Reason: this is a lot for a person to type out. We can leverage the block library so authors don't have to type all this out. If we leave it as metadata, it wouldn't be library-able. Thoughts?
cc @rgclayton

this should be a regular block
@auniverseaway Agreed. I'll rework the PR once I'm done with the breadcrumbs enhancements.

@jckautzmann I'm finally getting around to this. The more I think about this, the more I think this should be a regular block.
Reason: this is a lot for a person to type out. We can leverage the block library so authors don't have to type all this out. If we leave it as metadata, it wouldn't be library-able. Thoughts?

I think this is a great idea. This sounds like a good pattern for any structured data that requires more than a few properties to update.

Closing PR while @jckautzmann reworks it to be a block.


Get Face Index

Im trying to retrieve the index of the face from the octree.search function.  Any ideas on how to find it.
I have a bufferGeometry that i convert to geometry, Create an octree from and search.  I then want to toss the octree and geometry mesh away and go back to using my buffer geometry. But can not find a way to correlate the octree face results to the indexed bufferGeometry.
I do notice that faces are the same as indexes in bufferGoemetry and geometry(  geometry.faces[i].a = bufferGeometry.index.array[i*3+0] )
Current Dumb Loop

octreeFaces: for (var octreeFaceIndex = 0; octreeFaceIndex < octreeResult.length; octreeFaceIndex++)
	for (
		var indexIndex = parseInt(surface.geometry.index.array.indexOf(octreeResult[octreeFaceIndex].faces.a) / 3) * 3,
		lastIndexIndex = parseInt(surface.geometry.index.array.lastIndexOf(octreeResult[octreeFaceIndex].faces.a) / 3) * 3;
                indexIndex < lastIndexIndex;
                indexIndex += 3
	) {
		if (
			surface.geometry.index.array[indexIndex + 0] == octreeResult[octreeFaceIndex].faces.a &&
			surface.geometry.index.array[indexIndex + 1] == octreeResult[octreeFaceIndex].faces.b &&
			surface.geometry.index.array[indexIndex + 2] == octreeResult[octreeFaceIndex].faces.c
		) {
			indexes2check.push(indexIndex);
			console.log(surface.geometry.index.array[indexIndex + 0], surface.geometry.index.array[indexIndex + 1], surface.geometry.index.array[indexIndex + 2])
			console.log(indexIndex, octreeResult[octreeFaceIndex])
			console.log('FOUND')
			continue octreeFaces;
		}
          }

Sorry @kpetrow I've not worked on THREEJS or the octree in far too long to answer your question. This might be better posed on the THREEJS help/issues.


How to get include directories that are injected by config.cmake.in based packages?

When I link to a hunter library that is found with the config mode of find_package( ... REQUIRED ) for example Qt5::Core, then the needed include directories get somehow injected into my library Foo and it will find includes like #include <QString>. This is all nice and good but...
In order to solve some other problem I now need access to the names of the include directories and I do not know how to get it. For the formerly used module mode packages I could call get_target_property( incDirs TARGET Foo PROPERTY INCLUDE_DIRECTORIES) but with the config mode packages this will not return the Qt-Directories. Does anybody of you know how I can get the names of the directories?

For the formerly used module mode packages I could call get_target_property( incDirs TARGET Foo PROPERTY INCLUDE_DIRECTORIES)

Same same. But property called INTERFACE_INCLUDE_DIRECTORIES. Also just for your information after hunter_add_package command new variable QT_ROOT will be added to the scope. Note that it's Hunter specific, e.g. will not work when HUNTER_ENABLED if OFF.

Thanks! This helps.


Change of approach to data storage. AC, A2C changed

Hello!
Again, I took the liberty of making changes to the code without approval.
For optimization, I tried to change the data storage approach:

Data is stored in the form in which it is transmitted by the environment.
Conversion to float32 takes place before they are sent to the model or in the tf-function itself.
 I tried on AC, A2C Algorithms .. It seems to work and requires much less RAM.
I’ll test it at home on a more powerful PC on Atari Env.
As a suggestion, I have the following:
go completely to type float64;
try to perform data conversion for all algorithms only in tf-functions.

Hi, @kmakeev
I've forgot why I write so many .astype(np.float32) before. But it seems I have encountered to a bug and must done this to fix it.
I'm not sure if accepted this PR whether the bug will occur or not, plz do more test on different gym enviornments if it's convenient for you.
thank you very much. Because I have been busy with other things recently, I will deal with this problem later

Hello!
Again, I took the liberty of making changes to the code without approval.
For optimization, I tried to change the data storage approach:

Data is stored in the form in which it is transmitted by the environment.
Conversion to float32 takes place before they are sent to the model or in the tf-function itself.
 I tried on AC, A2C Algorithms .. It seems to work and requires much less RAM.
I’ll test it at home on a more powerful PC on Atari Env.
As a suggestion, I have the following:
go completely to type float64;
try to perform data conversion for all algorithms only in tf-functions.

Actually, I've encounter a gym environment which reward has type of int. That's why I write reward.astype(np.float32) in gym_wrapper.py.
I know what you mean, you want deal with the data type when extracting experiences from the replay buffer so that could save some memory. But it's a trade-off between training speed and memory usage here:

change data type when storing it. High training speed, much memory use(maybe)
change data type when extracting and using it. Low training speed(beceause one experience could be extracted many times, so there will be multiple conversions), less memory use(maybe).

And I still note that you added an normalized operation for visual input. Actually, I will add this function in gym_wrapper.py deal with both vector and visual input.

And I still note that you added an normalized operation for visual input. Actually, I will add this  function in gym_wrapper.py deal with both vector and visual input.

You can clarify for a better understanding.

2.change data type when extracting and using it. Low training speed(beceause one experience could be extracted many times, so there will be multiple conversions), less memory use(maybe).

Can be easily checked by tests.

And I still note that you added an normalized operation for visual input. Actually, I will add this  function in gym_wrapper.py deal with both vector and visual input.

You can clarify for a better understanding.

2.change data type when extracting and using it. Low training speed(beceause one experience could be extracted many times, so there will be multiple conversions), less memory use(maybe).

Can be easily checked by tests.

I noted you added features = features / 255 in tf2nn.py, which is a normalization operation for visual input. Actually, I would like to implement observation normalizetion in gym_wrapper.py layer. And whether change [210, 160, 3] to [84, 84, 3] or grayscale is on the way !

OK! Now I understand.
But, all these cases also require normalization, normalization is needed for any visual inputs.
In my opinion, it is better to do this in the tf function, the calculation will be on the GPU.
In gym_wrapper.py I did not find calculations on tensors ...

@kmakeev
That's a good question... I‘ll think it twice.
And, does tf.cast run on GPU? I dont know that, do you know?

Must.
I will check it.

If the np operation is mixed in tf, i.e. tf.max(np.log(x)) will it affect the speed of GPU? Do you know about this?

If the np operation is mixed in tf, i.e. tf.max(np.log(x)), will it affect the speed of GPU? Do you know about this?
I checked on this code.
from future import absolute_import, division, print_function, unicode_literals
import tensorflow as tf
import numpy as np
import datetime

def normalizing_(a):
b = tf.cast(a, dtype=tf.float64)
b = b / 255
for i in range(10):
print("Executed numpy", np.amax(np.log(b)))
@tf.function
def normalizing(a):
b = tf.cast(a, dtype=tf.float64)
b = b / 255
for i in range(10):
tf.print("Executed tf - ", tf.reduce_max(tf.math.log(b)))
array = np.random.randint(0, 255, size=10**8, dtype = np.uint8)
print(datetime.datetime.now())
with tf.device('/CPU:0'):
result = normalizing(array)
print(datetime.datetime.now())
with tf.device('/GPU:0'):
result = normalizing(array)
print(datetime.datetime.now())
result = normalizing_(array)
print(datetime.datetime.now())
2019-11-20 21:22:45.303259
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
2019-11-20 21:22:46.271348
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
2019-11-20 21:22:46.395311
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed tf -  -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
2019-11-20 21:22:51.949725
Process finished with exit code 0
Everything works, much faster in tf-functions. on the GPU will be more noticeable with more complex calculations

I have already tested AC, A2C algorithms with my code. While everything works, there are no errors.
GPU utilization reaches 100%, especially on the AC algorithm. Let's see what he can achieve.

If the np operation is mixed in tf, i.e. tf.max(np.log(x)), will it affect the speed of GPU? Do you know about this?

I checked on this code.
from future import absolute_import, division, print_function, unicode_literals
import tensorflow as tf
import numpy as np
import datetime
def normalizing_(a):
b = tf.cast(a, dtype=tf.float64)
b = b / 255
for i in range(10):
print("Executed numpy", np.amax(np.log(b)))
@tf.function
def normalizing(a):
b = tf.cast(a, dtype=tf.float64)
b = b / 255
for i in range(10):
tf.print("Executed tf - ", tf.reduce_max(tf.math.log(b)))
array = np.random.randint(0, 255, size=10**8, dtype = np.uint8)
print(datetime.datetime.now())
with tf.device('/CPU:0'):
result = normalizing(array)
print(datetime.datetime.now())
with tf.device('/GPU:0'):
result = normalizing(array)
print(datetime.datetime.now())
result = normalizing_(array)
print(datetime.datetime.now())
2019-11-20 21:22:45.303259
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
2019-11-20 21:22:46.271348
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
2019-11-20 21:22:46.395311
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed tf - -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
Executed numpy -0.00392927813988955
2019-11-20 21:22:51.949725
Process finished with exit code 0
Everything works, much faster in tf-functions. on the GPU will be more noticeable with more complex calculations

Hi, @kmakeev
from your result , I didn't see any difference between using numpy or tensorflow operation.
Now, I've changed the time when changing the type of data, you can see the lattest commit for detail.

Hi!

from your result , I didn't see any difference between using numpy or tensorflow operation.
Now, I've changed the time when changing the type of data, you can see the lattest commit for detail.
The difference is clearly visible in the visual execution of the code.
A time stamp was printed between function calls. From it the difference is visible.
This is confirmed by other sources.

PR can be closed, I will understand further in your master branch.
https://databricks.com/tensorflow/using-a-gpu
PR can be closed, I will understand further in your master branch.


gray border fixed for alert

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

server-2013/lync-server-2013-set-up-network-interfaces-for-edge-servers.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

server-2013/lync-server-2013-set-up-network-interfaces-for-edge-servers.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

server-2013/lync-server-2013-set-up-network-interfaces-for-edge-servers.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[BUILD-725] Adds seperate controllers for default rolebindings

Introduces two new controllers:
openshift.io/builder-rolebindings - responsible for rolebindings for builder SA.
openshift.io/deployer-rolebindingsr - responsible for rolebindings for deployer SA.
Required for: https://github.com/openshift/openshift-controller-manager/pull/289

/assign @soltysh

/approve

/lgtm cancel
Based on the work in https://github.com/openshift/openshift-controller-manager/pull/289, we should add the "ImagePuller" role bindings controller in this PR as well.


Column chart not rendering correctly

Codepen
https://codepen.io/acathur/pen/YMxjgq

Explanation

Bars should not be overlapped
Distribute bars

Hi @junedchhipa , it seems bring a new bug when using tickAmount and labels.formatter

Codepen please?

@junedchhipa hi, just made the demos

run on v3.6.7 https://codepen.io/acathur/pen/QPOywO
run on v3.6.6 https://codepen.io/acathur/pen/mgqVqR


Cross-browser compatibility issues

fixed line numbers for old submission view, in case old links are redirected there
fixed Mozilla Firefox box-sizing issue (using -moz- CSS prefix)

:+1:  Deployed.


Remove pydub from dependencies

pydub is no longer actively maintained, and is now running into issues with audioop being removed in python 3.13. As such, we should try to remove it from our dependencies and implement the needed features ourselves.
From a quick look through the code, the main features needed to implement are:

AudioSegment.silent
AudioSegment.overlay
AudioSegment.from_file

https://github.com/ManimCommunity/manim/blob/ce1fff645d2b457919933c3f92cb6106fbb9b6a1/manim/scene/scene_file_writer.py#L330-L334
https://github.com/ManimCommunity/manim/blob/ce1fff645d2b457919933c3f92cb6106fbb9b6a1/manim/scene/scene_file_writer.py#L327
https://github.com/ManimCommunity/manim/blob/ce1fff645d2b457919933c3f92cb6106fbb9b6a1/manim/scene/scene_file_writer.py#L370

Pinging @behackl as we talked about this on stream a while back.

I read some source code of pydub and find this:
try:
    import audioop
except ImportError:
    import pyaudioop as audioop

It seems like, inside of pydub there is substitution functions written in python at pyaudioop.py. If those work as intended in runtime, there may not be so much of hurry and it may still work in 3.13. (One missing function was marked, but it may be some cursed global reference that no 3rd party cannot figure out without dancing with debugger)
But still, I think this is can be a issue maker and other alternativies should be investigated.
Original audioop code is in this package: https://github.com/AbstractUmbra/audioop
Pydub: https://github.com/jiaaro/pydub

Unfortunately, pydubs alternate python implementation is actually broken, as I found out in #3967

Yeah, it is totally broken. If you resolve the import issue, then the code is just filled with type errors and mentioned function really was not there. Never tested hasty conversion of C-code.

If dependency to external ffmpeg executable is dropped, this will be broken in that regard too.
PyAv does not share it's ffmpeg through envPATH.

The cases where pydub would call ffmpeg via the executable should be taken care of by manual transcoding on our end. Did you find some situation where pyav actually tries to invoke ffmpeg on the current main branch?

I was pondering solution space and then remembered transition to Pyav. So solution space did shrink to that singular interface structures. (Personally I don't know nothing about pyav interfaces.)
I was just refering subprocess calls to ffmpeg/libav inside of pydub-packet. As far I understand, those would fail when new user does not have external ffmpeg/libav executable and only PyAv-library? And every other solutions that does not use pyav interfaces.


Remove docker-py

docker-py now breaks docker v2.2.0
https://github.com/docker/docker-py/issues/1395
resulting in errors during docker-compose up  :
Dependency conflict: an older version of the 'docker-py' package is polluting the namespace. Run the following command to remedy the issue:
pip uninstall docker docker-py; pip install docker

Might also set state: absent to uninstall docker-py, but don't want to break existing installs with older versions of docker.

Hi, thanks for the info but I don't want to remove it completely since it's still a dependency.
I added docker_pip_dependencies so you can either choose to remove it there or set a specific version.


Transfer rules_foreign_cc to bazel-contrib

Description:
This issue proposes transferring the rules_foreign_cc repository from the bazelbuild GitHub organization to the bazel-contrib GitHub organization, which is owned by the Community for Bazel project under the Linux Foundation.
GitHub Discussion: https://github.com/orgs/bazelbuild/discussions/2
Impacts:

GitHub issues & PRs will be transferred to the new repository.
Branch protection rules will need to be transferred to the new repository.
Individual maintainers will be transferred to the new repository.
GitHub teams will NOT be transferred to the new repository and will need to be re-created.
Bazel CI configurations will need to be updated to point to the new repository.

Read more on Transferring a repository from GitHub documentation.
Checklist:

[x] Obtain approval from the current project maintainers (@UebelAndre, @jsharpe).
[x] Obtain approval from the bazel-contrib SIG (@alexeagle).
[ ] Initiate the transfer process on GitHub (@meteorcloudy).
[ ] Update Bazel CI settings and confirm presubmit & postsubmit work (@meteorcloudy).

You have my approval

Approved!

Notes from SIG meeting: this transfer was unanimously approved by a thumbs-up vote.

Thanks for the approvals, I'll initiate the transfer now.

This is done, presubmit verified at https://github.com/bazel-contrib/rules_foreign_cc/pull/1291
Let me know if anything is broken.


increment changes in hex search

i am looking increment changes as per switch, by default its uses +1
example
BitCrack.exe -s 6BBF8CCF80F8E184D1D300EF2CE45F7260E56766519C977831678F0000000000
next is BitCrack.exe -s
6BBF8CCF80F8E184D1D300EF2CE45F7260E56766519C977831678F0000000001
what i am looking user assign switch for increment add
example
BitCrack.exe -s 6BBF8CCF80F8E184D1D300EF2CE45F7260E56766519C977831678F0000000000
then +500 increment
BitCrack.exe -s 6BBF8CCF80F8E184D1D300EF2CE45F7260E56766519C977831678F0000000501
next +500 increment add into hex, not in digit
any solution

above function work in brainflayer
but brainflayer GPU not supported
in brainflayer function commands is
-n 1/500
developer can study this case from brainflayer and can apply in bitcrack

#68 created


docs(readme): include npm stats

Coverage remained the same when pulling 3b1472a031f65f4ceeddd1199ca3e90af63e3628 on gdi2290:patch-1 into 14d25f5d0d72f4486df2e7c85f4506f47be19647 on blakeembrey:master.

No thanks.


Cloudformation Stack fails with "Transform AWS::Include failed with: The location parameter is not a valid S3 uri."

I am trying to build from source after doing certain changes in the parent sam template. I followed the instructions in the wiki and cloudformation stack failed with the below error
Error Message: "Transform AWS::Include failed with: The location parameter is not a valid S3 uri."
Nested Cloudformation Template giving this error: The template creating the API Gateway and Lambda resources for the backend. This template is the output of "aws cloudformation package" command by the root pom.xml.
Investigation:
After having a quick look, i found that the "aws cloudformation package" did not replace the local path referencing the swagger yaml file which is below
DefinitionBody:
Fn::Transform:
Name: AWS::Include
Parameters:
Location: ../../swagger/api.yaml
Which basically lead to failure.
Workaround: I manually changed the location attribute to reflect the relevant template file in my S3 bucket with s3 uri scheme.
Expectations: it should have replaced it with S3 URL in the first place

Which AWS CLI version do you have? The minimum version requirement for AWS CLI is 1.16.66. If you have an older version of AWS CLI, you will need to upgrade it. You can run the following command to check your AWS CLI version:
aws --version

I am using aws-cli/1.16.71 Python/2.7.10 Darwin/16.7.0 botocore/1.12.61

Sorry the required version should be 1.16.84. I will update the quick start guide.

I was able to package the deploy the template successfully in us-west-2 using this version of AWS CLI:
aws-cli/1.16.212 Python/3.7.4 Darwin/18.7.0 botocore/1.12.202


[PT Run] Updating env vars: Old vars not removed

Microsoft PowerToys version
0.1.0
Running as admin

[ ] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce

start pt run
delete env var

✔ Expected Behavior
env var is deleted for pt run process
❌ Actual Behavior

Other Software
No response

To fix this we have to compare the vars of process against them of machine (and user) to finde the vars that doesn't exist anymore. They have to be added with null value to the dictionary for removing them.
See https://docs.microsoft.com/de-de/dotnet/api/system.environment.setenvironmentvariable?view=net-5.0#System_Environment_SetEnvironmentVariable_System_String_System_String.

To fix this we have to compare the vars of process against them of machine (and user) to finde the vars that doesn't exist anymore. They have to be added with null value to the dictionary for removing them.
See https://docs.microsoft.com/de-de/dotnet/api/system.environment.setenvironmentvariable?view=net-5.0#System_Environment_SetEnvironmentVariable_System_String_System_String.

@jaimecbernardo
Some thoughts about the entire topic:

With this solution (see quote) we might destroy process only variables.
With the implementation we have at the moment we destroy changes on process layer when the var value is different from machine and user layer. (We override process with machine and machine with user.)
I don't think that we can solve the bug without rethink our general solution.
It might be more save to call new processes, open files, etc. within an new environment based on actual system settings.

@jaimecbernardo
I might have a solution to doing a correct env vars update without loosing process vars and deleting old  vars.
But that requires:

Caching the last set vars while runtime in RAM. (Would this be okay?)
Caching a snapshot of the vars in ram directly after init PT Run process. (Where do we have to call the mothod from?)

@htcfreek ,
Looking again at this issue, it seems to be indeed a bit more complicated than initially, thought.
It's best to be fixed on a different PR.
Regarding the possible solutions:
I like the idea of initially getting a sort of cache at startup, though I think we only have to "cache" which "keys" existed in process that didn't also exist on either Machine or User. Basically we don't want to change/delete those keys, since they were attributed specifically to the process by the OS.
I think this initial "caching" method can be added to the EnvironmentHelper and can be called on MainWindows.OnSourceInitialized in src\modules\launcher\PowerLauncher\MainWindow.xaml.cs. (where we register the ProcessWindowMessages hook to handle the environment update messages).
What do you think?

@htcfreek ,
Looking again at this issue, it seems to be indeed a bit more complicated than initially, thought.
It's best to be fixed on a different PR.

I agree. I wrote this a few minutes ago within a comment in the PR itself.

Regarding the possible solutions:
I like the idea of initially getting a sort of cache at startup, though I think we only have to "cache" which "keys" existed in process that didn't also exist on either Machine or User. Basically we don't want to change/delete those keys, since they were attributed specifically to the process by the OS.
I think this initial "caching" method can be added to the EnvironmentHelper and can be called on MainWindows.OnSourceInitialized in src\modules\launcher\PowerLauncher\MainWindow.xaml.cs. (where we register the ProcessWindowMessages hook to handle the environment update messages).
What do you think?

When we don't cache the values we can't detect proccess only variables and (user/machine) variables that have ben changed on process level within the runtime of PT Run. That's why I we should cache the values too. I know this would be more complicated but then we are able to detect changes (add, change, new) on machine, user and process level.

My concept idea. I hope it's understandable.

I agree it would be a more general solution, but it seems to be more complicated than what is needed here.
From my understanding, I don't think we're changing any process level environment variable on PowerToys Run other than to update the environment variables after they've been changed in the Machine/User level.
That's why I thought it would be enough to, when starting the program, get a list of which keys only exist at process level or which process-level keys have different values than either the same user or machine-level key. Then these would be "protected" during our updates. Other keys would be edited, created, deleted except for these ones.
Is there some negative side I'm not foreseeing here?

I agree it would be a more general solution, but it seems to be more complicated than what is needed here.
From my understanding, I don't think we're changing any process level environment variable on PowerToys Run other than to update the environment variables after they've been changed in the Machine/User level.
That's why I thought it would be enough to, when starting the program, get a list of which keys only exist at process level or which process-level keys have different values than either the same user or machine-level key. Then these would be "protected" during our updates. Other keys would be edited, created, deleted except for these ones.
Is there some negative side I'm not foreseeing here?

If we say we don't expect changes on process level that doesn't came from machine/user level while PT Run is running, I think no.
Do you think we have to update the proces var names list on runtime or can it be static? At the moment I don't see any reason for updating it on runtime. (I guess you mean adding process only and by process level overwritten vars into the list. Correct?)

(I guess you mean adding process only and by process level overwritten vars into the list. Correct?)

Yes.
I think it can be calculated at program start and won't need to change during execution.

@htcfreek did this get wrapped up with the sept 22 merge?

@htcfreek did this get wrapped up with the sept 22 merge?

@crutkas
Yes. It's all working an merged with #13363. Can you please assign the project (0.51). Thanks.

This is fixed in 0.51.  Please head over to our releases and get the update!  https://aka.ms/installpowertoys


Ports with IP address

Wouldn't work on IP addresses with ports defined.
e.g:
<IP_ADDRESS>:3000
unless a protocol defined:
ftp://<IP_ADDRESS>:3000

Resolved in 0.6.0


Create a script to build and run different plain containers with different OS and CPU/CUDA

Done in the latest commit.


Not Opening

Describe your bug here.
Whenever i download the mac build normally, i open the zip and when i try to open the app it gives me this prompt, does anyone know the problem?

Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Mac
Did you edit anything in this build? If so, mention or summarize your changes.
Nope, this is just the exact mac build from the github

try this
#15792

i think it might be a compiling error or something with the code because its not a privacy thing


support isDone() and isCancelled() calls to SubExecutionContextFuture

these methods are used by generic Futures libraries
like guava's Futures class

ack


Post save cache step takes too long

I have used actions/cache for a long time to cache dependencies and Typescript build results. I am moving my monorepo from yarn to pnpm, so I can save some time on installing dependencies, and I faced an issue probably related to how `actions/cache works.
After moving to pnpm, I see that post save cache step takes too long, while before moving to pnpm, it took only 5s (see the third screenshot).
PNPM uses symlinked node_modules structure, but this shouldn't be related to dist folders produced by the Typescript compiler.

Here is the workflow from the first 2 screenshots:
  build:
    runs-on: self-hosted
    needs: dependencies

    steps:
      - uses: actions/checkout@v3
        name: Checkout

      - name: Install pnpm
        uses<EMAIL_ADDRESS>        with:
          version: 7
          run_install: false

      - uses: actions/setup-node@v3
        name: Install Node
        with:
          node-version-file: '.nvmrc'

      - name: Get pnpm store directory
        id: pnpm-cache
        run: |
          echo "::set-output name=pnpm_cache_dir::$(pnpm store path)"

      - uses: actions/cache@v3
        name: Setup pnpm cache
        with:
          path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
          key: ${{ runner.os }}-pnpm-store-${{ env.CACHE_VERSION }}-${{ hashFiles('pnpm-lock.yaml') }}
          restore-keys: |
            ${{ runner.os }}-pnpm-store-${{ env.CACHE_VERSION }}-

      - name: Install dependencies
        run: pnpm install
        env:
          NODE_OPTIONS: ${{ env.NODE_OPTIONS }}

      - name: Build
        run: pnpm build:ts
        env:
          NODE_OPTIONS: ${{ env.NODE_OPTIONS }}

      - uses: actions/cache@v3
        id: build-cache
        name: Save build cache
        with:
          path: |
            packages/**/dist
            packages/**/tsconfig.tsbuildinfo
          key: ${{ github.sha }}

Let me know if you need more information from my side and if everything above makes sense for you. Thanks

Is this a recurring issue? Can you share debug logs using https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging ?

@vtereshyn Do you have the logs of any recent run with this issue?
If you notice this is upload speed issue then it is a known issue. You may want to use cloud self-hosted runner instead of local machine runners to increase speeds

Closing due to no response

Hi, we have the same problem, 'only' 2 minutes delay but thats still 70% of our entire runtime. How can we speed this up?


[Feature Request] golang delve config

Your plugin looks awesome!
You think it's possible to support the go delve debugger as well?
I couldn't get it to work with the default settings. It would just continue forward when I was reverse continuing.

I'm not familiar with the Go ecosystem, but I'll try to check it out and see if the plugin can be adapted to run that aswell (as it just wraps the vscode-cpptools dap plugin).


Failure if there are multiple sysconfigdata files during cross-compilation

PyO3 searches for _sysconfigdata*.py and crashes if it finds any other number than 1 of them:
https://github.com/PyO3/pyo3/blob/4c80ce93c39110f1d65944c2ce4ea2149e241613/build.rs#L411
If you are cross compiling, you can set the target lib dir with PYO3_CROSS_LIB_DIR and specify the python version with PYO3_CROSS_PYTHON_VERSION if there are multiple versions.
Within these contraints, any matching _sysconfigdata*.py file will be found:
https://github.com/PyO3/pyo3/blob/4c80ce93c39110f1d65944c2ce4ea2149e241613/build.rs#L431
However, there is a problem with Anaconda Python versions, which is that all alternative _sysconfigdata*.py files are always bundled with Python, not only the target platform variant. So we have among others, the following files, where only one of them is relevant:

/lib/python3.8/_sysconfigdata_arm64_apple_darwin20_0_0.py
/lib/python3.8/_sysconfigdata_powerpc64le_conda_linux_gnu.py
/lib/python3.8/_sysconfigdata_x86_64_conda_cos6_linux_gnu.py

If I understand correctly, CPython uses a _PYTHON_SYSCONFIGDATA_NAME environment variable as a workaround for this specific cross-compilation issue.
My proposed solution is to take the sysconfigdata that corresponds with _PYTHON_SYSCONFIGDATA_NAME if there are multiple sysconfigdata files, the environment variable is set, and if that particular file exists.
🌍 Environment

Your operating system and version: macOS 11.2
Your python version: conda-forge/python 3.8.8
Your PyO3 version: 0.12.4+

This problem affects everyone who tries to do PyO3 cross compilation with Anaconda Python.

Nice catch, thank you for reporting!


Fix channels URI

Signed-off-by: Ravi Thaluru<EMAIL_ADDRESS>Description

fix the URI - remove index_management suffix

Issues Resolved
N/A
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #184 (cba0ab6) into main (196b444) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   61.85%   61.85%
=======================================
  Files         158      158
  Lines        4632     4632
  Branches      732      732
=======================================
  Hits         2865     2865
  Misses       1546     1546
  Partials      221      221

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196b444...cba0ab6. Read the comment docs.


Fixed an incorrect return type and removed restriction on optional parameter

Thanks @chrisharrison, nice catch! Sorry to be picky but can you convert to tabs and remove the space in if ( on line 455? Just to keep a consistent style.

OK will do. I don't mind picky.
The formatting I was using is PSR-2. I'm a big advocate and encourage you
to adopt it.
On 21 June 2017 at 15:54, Chris Barr<EMAIL_ADDRESS>wrote:

Thanks @chrisharrison https://github.com/chrisharrison, nice catch!
Sorry to be picky but can you convert to tabs and remove the space in if (
on line 455? Just to keep a consistent style.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chrisbarr/AmazonSNS-PHP-API/pull/17#issuecomment-310104534,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASE-l6q2yTqY5lAFVhkueCqb5vLarxWks5sGS6WgaJpZM4OBEwB
.

OK just pushed the formatting. Can you double check that is tabs I've committed?

Thanks all looks good, merging now. I know, it's on my todo list...


Integrate exceptions pages  ( 403, 404 ... )

Take inspiration from Tailwind UI (ask Lucas Jacques or myself, if you don't have access to it yet), or Flowbite


another nexus repo pattern

this pr is based on #786, also fix #783 , and try to  simplify codes and add another api pattern to use nexus resolve api.
new API pattern is compatible with #786 :
/nexus/(r|s|<repo-name>)/(http|https)/<nexus.host>[:port][/<entry-path>]/<group>/<artifact>[:k1=v1[:k2=v2[...]]].<format>

for /nexus/[rs]/... pattern, use the search api of the nexus server, and
for /nexus/<repo-name>/... pattern, use the resolve api of the nexus server.

@jgangemi

looks like you need to fix a tabs/spaces issue. also 👍 for picking up on this!

tabs/spaces issue is fixed

@paulmelnikow I'll read the test document and add some tests this weekend.
I just fixed the conflict of try.html, but the continuous-integration/travis-ci/pr failed on getting the tittle of PR, could plz you figure the problem?

PR: badges/shields#1017
Error: 403 Forbidden
at Error (native)
at fetch.then.res (/home/travis/build/badges/shields/service-tests/runner/cli.js:31:15)
at process._tickCallback (internal/process/next_tick.js:109:7)

@paulmelnikow the service tests have been added, and all new js codes are covered by the tests. plz trigger the CI-builds.

@paulmelnikow for the last commit, all the service tests about nexus part are passed, but there 4 github ones are failed, plz review the old  tests.

Thank you!


Fix string(int) issues for Go 1.15 compatibility

go vet in Golang 1.15 does not allow type casting from int to string. More info in https://github.com/golang/go/issues/32479 and https://github.com/golang/go/issues/3939.
Example output:
$ make test
go vet ./...
# github.com/kolide/fleet/server/datastore
server/datastore/datastore_labels_test.go:22:29: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
server/datastore/datastore_labels_test.go:22:40: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
make: *** [lint-go] Error 2

Thank you!


Attempt to fix permissions propagation test

[ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[ ] Ensure that the pull request title represents the desired changelog entry
[ ] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Not going to work, looking at changing infra back


release image: Allow arbitrary pre-release identifiers

Make the filter patterns for release image tags more lenient to allow arbitrary pre-release identifiers beyond rc. We made a similar change in main branch ^1, but the change got lost when we branched v1.16.
Fixes: f5bdf28e8af1 ("Prepare v1.16 stable branch")

backporting https://github.com/cilium/cilium/pull/29173 to v1.16 branch so that this change gets forward ported when we create new stable branches.

/test-backport-1.16

[ upstream commit 9b3ab90 ]

Is this accurate? GitHub reports that the linked commit is already in v1.16 branch.

LGTM, but the commit reference is a bit misleading.

updated the commit message 🚀

/test-backport-1.16


Binding to HTML5 audio events not working

Description
Binding to HTML5 audio events is not working.
I'm trying to bind to timeupdate and durationchange events as described in the docs:
https://www.polymer-project.org/1.0/docs/devguide/data-binding#two-way-native
This appears to have no effect.
I'm doing what's documented as far as I can tell.  If I'm doing it wrong, please let me know how.  I'm also happy to create a PR to update the docs if something's missing.
Live Demo
http://jsbin.com/xoxucimawa/2/edit?html,console,output
Steps to Reproduce
The docs use this to bind hostTime to video's currentTime through timeupdate events:
<video url="..." current-time="{{hostTime::timeupdate}}">

I'm doing something similar:
        <audio
            current-time="{{hostCurrentTime:timeupdate}}"
            duration="{{hostDuration:durationchange}}">

Expected Results
The host properties change when the audio element fires those events.
Actual Results
Nothing changes.  You can see in the jsbin that the relevant events are being fired by the audio element.
Browsers Affected

[X] Chrome
[ ] Firefox (not tested)
[ ] Edge (not tested)
[ ] Safari 9 (not tested)
[ ] Safari 8 (not tested)
[ ] IE 11 (not tested)

Versions

Polymer: v1.7.0
webcomponents: not sure

Your bindings are each missing a colon (should be double-colons):
        <audio
            current-time="{{hostCurrentTime::timeupdate}}"
            duration="{{hostDuration::durationchange}}">

jsbin

Thank you!  That was my mistake.


Fields Documentation

Looking for a description of what the differences between pconsume/psupply asf. and the respective p1, p2 asf.  parameters are.

The numbered ones should be individual phases. Consume/supply is +/-, but the words/signs really depends on how you have the EM wired up


Dynamic configuration for DEFAULT_FROM_EMAIL setting

We would like to be able to dynamically set the value of DEFAULT_FROM_EMAIL setting. A good place to store it is the SiteSettings model. We would need to extend the API to allow managing and retrieving it.
There is also ORDER_FROM_EMAIL setting which acts identically, except it's only used for sending order-related emails. I'm wondering whether it is actually needed or we could simplify it to have only one configuration. I'd like to hear some feedback on that.

To prevent header injection, we will have to validate the value doesn't contain any newlines before saving.


Spyder Dev Tools: Internal Console Operations

From<EMAIL_ADDRESS>on 2011-12-02T06:24:51Z
I'd like to play with Spyder from within Spyder itself. The idea is inspired by Blender's console described here: http://wiki.blender.org/index.php/Doc:2.5/Manual/Extensions/Python/Console (we should have a similar page for developers, but that's another story)
I've tried to repeat Blender's interactive session example in Spyder IC:
>>> dir()
['builtins', 'doc', 'name', 'execfile', 'help', 'runfile']
>>> doc
>>> name
'main'
>>> execfile
<bound method Interpreter.execfile of <Interpreter(Thread-1, initial)>>
>>> help
<bound method Interpreter.help_replacement of <Interpreter(Thread-1, initial)>>
>>> runfile
<bound method Interpreter.runfile of <Interpreter(Thread-1, initial)>>
>>>
Not really useful. The more useful stuff would be to provide spy module with information about Spyder internals.
>>> dir()
['builtins', 'spy']
>>> spy.plugins.list()
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=866

From<EMAIL_ADDRESS>on 2012-10-14T23:50:55Z
Status: Accepted
Labels: -Type-Defect Type-Enh

From<EMAIL_ADDRESS>on 2012-06-09T12:53:51Z
This issue was closed by revision fc1a2f86ad6d .
Status: Fixed


Missing libsodium.dll on windows

Version(s)
At least 0.1.7 and 0.1.8, the later tested both using coursier and the msi installer, on Windows.
Describe the bug
System error on launch, about missing libsodium.dll .
To Reproduce
On Windows (10), install, launch, say, scala-cli version, and notice the system popup.
Expected behaviour
Do not complain about libsodium.dll .
I added libsodium.dll which I found browsing github, and I get through then.

@NirvanaNrv Can you try again with the launcher that can be downloaded from the artifacts of this run (at the bottom of the page, click "launchers" - you need to be logged on GitHub for it to work IIRC), unzip it, unzip scala-cli-x86_64-pc-win32.zip from it, and use that. This ought to fix this, I think.

Ok, I reproduced that, and it seems https://github.com/VirtusLab/scala-cli/pull/1115 doesn't fix it 🤔