create ifuncs for compiled blocks once at module load time

Motivation

When a Ruby function rubyfunc receives a block implemented in C, a struct vm_ifunc is created for that block...on every call to rubyfunc.  The compiler, of course, does this all the time, and it's suboptimal when compared to the interpreter: the interpreter does not require an extra allocation for passing an (interpreted) block to functions.
This PR intends to change that state of affairs by allocating the struct vm_ifunc up front at module load time.  We can then re-use the structure on each call to rubyfunc, saving an allocation at runtime.  I expect this to be beneficial for block-heavy benchmarks, but haven't yet gotten the chance to benchmark this.
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_KeKHb3IPQ6znT1
→ https://go/builds/bui_KeKH1VpF6RB6mS

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_KeN1EjP7xr7Cpa
→ https://go/builds/bui_KeN1DVOQAThRCf

If you're able, it would be neat to see some benchmarks before and after this change.

It's not as effective as I hoped: it does indeed reduce the allocations to interpreter levels on the benchmark that motivated this, but the speedup is in the 1-5% range.  Still probably worth it to avoid increasing memory pressure in compiled code?


Error: EPERM

I'm getting the following error when running gulp tasks: Error: EPERM, open 'filename....'
Any idea what is causing this or how do I investigate the issue and resolve it?
Regards,
Gary

Anyone else have any luck being able to reproduce this? Or found a solution that I haven't had luck finding?

I got the same problem and possible sources. When I found the same problem the first first thing I did was check which files gulp was hanging on(lsof) and, bang, there was the file which del couldn't clean.
First possible source: Browserify keep files opened so del can't clean the directory;
Second possible source: Vinyl-source keep files opened so del can't clean the directory;
Third possible source: gulp.dest keep files opened after write so del can't clean the directory;
But i think it's  more Browserify or Vinyl problem than gulp itself.
My OS at moment is Windows 8.1, also tested in OS X Yosemite and ArchLinux. File permissions are ok and triple checked.
It's my gulpfile https://gist.github.com/schleumer/9e07d040d1a773511405 of course it's not complete, i just removed useless tasks which is not related.

@schleumer It's browserify or gulp-watch, none of the other things actually touch the file system they just deal with the in-memory files.

@sacredobelisk I downloaded your test repo and I am able to reproduce, but the bug is from browserify not from gulp. You installed the browserify module, created a bundle, and then the bundle throws an error. This has nothing to do with gulp, so the issue should be opened on browserify or you should check if there already is one. You should completely remove gulp from the equation when opening that issue so it is easier for them to reproduce and diagnose it.

Thanks, @contra! I'll move my issue to Browserify and gulp-watch, because  gulp-watch already have some issues like mine and this don't happen only with Browserify, kinda weird. Thanks again, sorry for the mess.

Will do. Thanks, @contra!

Just for whatever is worth to mention, I was having the EPERM error, what rang a bell was what @contra mentioned about gulp using the same permissions from the input file to write the output file, in my case I am sadly stuck with Clear Case for source control, and it is a pain to work with, all files that are read in a "non-checked out" state will end up being written as read only and next time the build runs, it errors out, my solution: try to check out all files before running the build tasks.
This may be a totally different problem from what everybody else is having, but just wanted to confirm on the statement of how gulp handles file permissions.

I'm writing this as it goes in thread with what @keberox is mentioning. I'm currently working for a client who is using Microsoft TFS 2013 (sigh). Sadly TFS is exhibiting the same behavior as "Clear Case". If files are not "checked out for editing" they will have a read-only flag set. Thus, the first gulp works fine, but subsequent runs fails with EPERM, Open errors. Bower and other tools are having similar issues. The only solution so far for me is to "check out" the entire project with gulp / bower dependencies, which kinda suck.
Is it possible to get gulp to NOT set the read-only flags on the output files, or is this overly complex? :)

@nover
Currently I am also using TFS 2013 but no longer encounter the issue with gulp EPERM error.
We resolved this by making the tfs workspace local, this also allows us to work offline if tfs goes down and we haven't had any issues with merging changes.
Reference to configure: https://msdn.microsoft.com/en-us/library/gg490753(v=vs.100).aspx

I got the same problem.. With TFS 2013. I change my workspace from server to local and it solves this point.

I have the same problem with TFS, but don't have the option to use a local workspace due to the size of our solution.  Is it possible to get gulp to NOT set the read-only flags on the output files?

@mvarblow  There's a way to create a gulp task that would allow you to update the file permission from read to write, but that would be problematic when you check stuff back in, might have merge conflicts on each checkin.
Here is a library that will assist with that: https://www.npmjs.com/package/gulp-chmod

Thanks @feiwaltan for sharing this. I use gulp in VS2015 for copying from /js to /jsdest which is the folder from where I am referencing the scripts in my browser. I only edit the /js files, so no problems with local workspace or TFS issues for me :)

@EjaYF How did you include your /jsdest folder in the project so it would publish that content, but not include it in source control/TFS? I have tried to select the files and use the Files > Source Control > Advanced > Exclude File from Source Control, but that still sets a read-only property on the file. That then causes issues with Gulp.

@8raveStarr I think your solution is fine. Make sure the file is not readonly. And use
       .pipe(chmod(755))
I guess from that moment you won't have read-only attributes anymore...

@8raveStarr I was facing the exact problem as you did now... This helped me: http://stackoverflow.com/questions/29483772/remove-windows-file-readonly-attribute-in-gulp-file
The solution is to remove the readonly attribute beforehand:
require("child_process").exec("attrib -r <dir-name>\*.* /s");

I have one problem related to setting the permission for js file, I am using gulp for combining multiple files into one. For that's what i am doing i am setting permission for the compiled file. Using  gulp-chmod package, so that  I can set the permission for the files,
Suppose i set write:false and run gulp it will set the file read only, but at the time of again removing the permission I am going to set write:true but that time I am getting the error. EPERM:  Operation not permitted, this is because of that read-only property true for the compiled file. If i manually remove the read-only property and run gulp again it will resolve. But I want to remove that property using gulp if i set the option write: true still i am getting error, is there another way to resolve the issue.

Actually I have simmilar problem... Actually I start the watch task, once it compile from less to css, than when it's start the real watch, it's dies.
Console:
[23:03:47] Using gulpfile /mnt/d/phptest/[...]/gulpfile.js
[23:03:47] Starting 'less'...
[23:03:49] Finished 'less' after 1.83 s
[23:03:49] Starting 'default'...
[23:03:49] 'default' errored after 13 ms
[23:03:49] Error: watch /mnt/d/phptest/[...]/less/ EPERM
at exports._errnoException (util.js:1012:11)
at FSWatcher.start (fs.js:1429:19)
at Object.fs.watch (fs.js:1456:11)
at Gaze._watchDir (/mnt/d/phptest/[...]/node_modules/gaze/lib/gaze.js:289:30)
at /mnt/d/phptest/[...]/node_modules/gaze/lib/gaze.js:358:10
at iterate (/mnt/d/phptest/[...]/node_modules/gaze/lib/helper.js:52:5)
at Object.forEachSeries (/mnt/d/phptest/[...]/node_modules/gaze/lib/helper.js:66:3)
at Gaze._initWatched (/mnt/d/phptest/[...]/node_modules/gaze/lib/gaze.js:354:10)
at Gaze.add (/mnt/d/phptest/[...]/node_modules/gaze/lib/gaze.js:177:8)
at new Gaze (/mnt/d/phptest/[...]/node_modules/gaze/lib/gaze.js:74:10)
gulpfile.js
/*global -$ */
'use strict';
var gulp = require('gulp');
var $ = require('gulp-load-plugins')();
var less = require('gulp-less');
// Error notifications
var reportError = function(error) {
$.notify({
title: 'Gulp Task Error',
message: 'Check the console.'
}).write(error);
console.log(error.toString());
this.emit('end');
}
// less processing
gulp.task('less', function() {
return gulp.src('less/style.less')
.pipe($.sourcemaps.init())
// Convert less into css
.pipe($.less({
outputStyle: 'nested', // libless doesn't support expanded yet
precision: 10
}))
// Show errors
.on('error', reportError)
// Autoprefix properties
.pipe($.autoprefixer({
browsers: ['last 2 versions']
}))
// Write sourcemaps
.pipe($.sourcemaps.write())
// Save css
.pipe(gulp.dest('css'));
});
// process JS files and return the stream.
gulp.task('js', function () {
return gulp.src('js/*.js')
.pipe(gulp.dest('js'));
});
// Optimize Images
gulp.task('images', function() {
return gulp.src('img/*')
.pipe($.imagemin({
progressive: true,
interlaced: true,
svgoPlugins: [{
cleanupIDs: false
}]
}))
.pipe(gulp.dest('img'));
});
// JS hint
gulp.task('jshint', function() {
return gulp.src('js/*.js')
.pipe($.jshint())
.pipe($.jshint.reporter('jshint-stylish'))
.pipe($.notify({
title: "JS Hint",
message: "JS Hint says all is good.",
onLast: true
}));
});
// Beautify JS
gulp.task('beautify', function() {
gulp.src('js/*.js')
.pipe($.beautify({indentSize: 2}))
.pipe(gulp.dest('js'))
.pipe($.notify({
title: "JS Beautified",
message: "JS files in the theme have been beautified.",
onLast: true
}));
});
// Compress JS
gulp.task('compress', function() {
return gulp.src('js/*.js')
.pipe($.sourcemaps.init())
.pipe($.uglify())
.pipe($.sourcemaps.write())
.pipe(gulp.dest('js'))
.pipe($.notify({
title: "JS Minified",
message: "JS files in the theme have been minified.",
onLast: true
}));
});
// Run drush to clear the theme registry
gulp.task('drush', function() {
return gulp.src('', {
read: false
})
.pipe($.shell([
'drush cc css-js',
]))
.pipe($.notify({
title: "Caches cleared",
message: "Drupal CSS/JS caches cleared.",
onLast: true
}));
});
// Default task to be run with gulp
gulp.task('default', ['less'], function() {
gulp.watch("less/.less", ['less']);
gulp.watch("js/.js", ['js']);
});
OS: windwos 10, script running from bash on windows console, also, it was installed the linux version of everything. All files are set to anybody can read/write/execute from linux console, and in window permission, the administrator, user, anybody roles has full (complette) permission (read/write/execute/etc).
Anybody?

I'm getting the same exact issue

Hello all, I had the same issue on Windows with Browserify/Babelify.
I resolved it by adding the buffer stage to the pipeline, ie changing:
return bundler
        .bundle()
        .on('error', gutil.log.bind(gutil, 'Browserify Error'))
        .pipe(source('content/js/main.js'))
        .pipe(gulp.dest('build'));

to:
var buffer = require('vinyl-buffer');

...

return bundler
        .bundle()
        .on('error', gutil.log.bind(gutil, 'Browserify Error'))
        .pipe(source('content/js/main.js'))
        .pipe(buffer())
        .pipe(gulp.dest('build'));

I haven't investigated why this is so important yet.
@schleumer Can you try changing your Gulpfile as follows:
var buffer = require('vinyl-buffer'); // at top

b.bundle()
    .pipe(source('app.js'))
    .pipe(buffer())
    .pipe(gulp.dest('./dist/js'))
```

I will definitely add that to mile gulpfile

My**

I've put before every .pipe(gulp.dest(*)) the .pipe(buffer()) line, and still I get the same error. I think there's something error in the watch... because the stand alone less task works.

We resolved this by giving read/write permissions to the Node application directory/node_modules.  Node uses its own node_modules directory during gulp processing.  We found that some users had read only permissions for anything in the Program Files directory - based on the image used (we were on PCs, not sure Mac is same).
Another way to avoid this might be to install Node elsewhere - the root drive, for example.

After a couple hours of flailing about trying to fix this,  finally found @cocoademon solution and it worked for me. Same issue with Vinyl/Browserify.

I've had that error while using gulp and realized that atom still had the old version of the file opened after I pulled from github.
All I had to do was close Atom and run gulp again.
Voila! no more error.

Also having issues with EPERM, but only on my watch task. All tasks run fine except for this one.
Simplified gulpfile:
var gulp             = require('gulp');
var postcss          = require('gulp-postcss');
var postcss_cssnext  = require('postcss-cssnext');
var precss           = require('precss');
var postcss_magician = require('postcss-font-magician');
var clean_css        = require('gulp-clean-css');
var concat_css       = require('gulp-concat-css');
var automath         = require('postcss-automath');
var vfs              = require('vinyl-fs');
var livereload       = require('gulp-livereload');
var pump             = require('pump');

var paths = {
    css: {
        base:       './src/postcss/**/*.postcss',
        normalize:  './node_modules/normalize.css/normalize.css'
    }
};

const css = Object.keys(paths.css).map(key => paths.css[key]);

var processors = [
    postcss_cssnext,
    precss,
    postcss_magician,
    automath
];

gulp.task('css', function(callback){
    pump([
        vfs.src([css[1],css[0]]),
        postcss(processors),
        concat_css('main.min.css'),
        clean_css(),
        vfs.dest('./bin/css/'),
        livereload()
    ], callback);
});

gulp.task('watch', function() {
    livereload.listen();
    gulp.watch(css[0], ['css']);
});

Complete error message:
root@PESTBARN-PC:/mnt/f/www/v2# gulp watch
[20:24:06] Using gulpfile /mnt/f/www/v2/gulpfile.js
[20:24:06] Starting 'watch'...
[20:24:06] 'watch' errored after 27 ms
[20:24:06] Error: watch /mnt/f/www/v2/src/postcss/ EPERM
    at exports._errnoException (util.js:1026:11)
    at FSWatcher.start (fs.js:1429:19)
    at Object.fs.watch (fs.js:1456:11)
    at Gaze._watchDir (/mnt/f/www/v2/node_modules/gulp/node_modules/vinyl-fs/node_modules/glob-watcher/node_modules/gaze/lib/gaze.js:289:30)
    at /mnt/f/www/v2/node_modules/gulp/node_modules/vinyl-fs/node_modules/glob-watcher/node_modules/gaze/lib/gaze.js:358:10
    at iterate (/mnt/f/www/v2/node_modules/gulp/node_modules/vinyl-fs/node_modules/glob-watcher/node_modules/gaze/lib/helper.js:52:5)
    at Object.forEachSeries (/mnt/f/www/v2/node_modules/gulp/node_modules/vinyl-fs/node_modules/glob-watcher/node_modules/gaze/lib/helper.js:66:3)
    at Gaze._initWatched (/mnt/f/www/v2/node_modules/gulp/node_modules/vinyl-fs/node_modules/glob-watcher/node_modules/gaze/lib/gaze.js:354:10)
    at Gaze.add (/mnt/f/www/v2/node_modules/gulp/node_modules/vinyl-fs/node_modules/glob-watcher/node_modules/gaze/lib/gaze.js:177:8)
    at new Gaze (/mnt/f/www/v2/node_modules/gulp/node_modules/vinyl-fs/node_modules/glob-watcher/node_modules/gaze/lib/gaze.js:74:10)

This error only occurs when running on Windows (Bash). On a Unix system, it works completely fine. Also, I've checked the permissions for every file and folder in the project, which are all rwxrwxrwx.

it's a bug with bash for windows fixed in build 14942

@ForsakenHarmony do you know if that has shipped in the official channel yet?

@phated going by my windows build version: No

Using vinyl-buffer  @cocoademon  mentioned, fix issue on my computer.
This is my gulp file.

const gulp = require("gulp");
const jasmine = require("gulp-jasmine");
const clean = require("gulp-clean");
const runSequence = require("run-sequence");
const source = require("vinyl-source-stream");
const buffer = require("vinyl-buffer");
const browserify = require("browserify");
const tsify = require("tsify");

let paths = {
    src: [
        "src/**/*.ts",
    ],
    content: [
        "src/**/*.json",
        "src/**/*.html",
        "src/**/*.css",
        "src/**/*.png",
    ],
    spec: "dist/spec/**/*.js",
    dest: "dist",
};

gulp.task("clean", () => {
    return gulp.src(paths.dest, {
            read: false
        })
        .pipe(clean());
});

gulp.task("copy", () => {
    return gulp.src(paths.content)
        .pipe(gulp.dest(paths.dest));
});

gulp.task("compile", () => {

    let b = browserify({
        debug: false, //turn on/off source map
        entries: [
            "./src/extension/content.ts"
        ]
    });

    //http://maximilianschmitt.me/posts/prevent-gulp-js-from-crashing-on-error/
    return b.plugin(tsify)
        .bundle()
        .on("error", error => {
            console.log(error);
        })
        .pipe(source("content.js"))
        .pipe(buffer())
        .pipe(gulp.dest("./dist/extension/"));
});

//test task depends on clean and compile tasks
gulp.task("test", done => {
    //start with clean, compile and test respectively
    runSequence("clean", "compile", "copy", () => {
        gulp.src(paths.spec)
            .pipe(jasmine({
                verbose: true
            }));
        done();
    });
});

gulp.task("watch", ["test"], () => {
    gulp.watch(paths.src.concat(paths.content), ["test"]);
});


Allow Array fileds in schema

Current client API does not allow you to specify field schema for Array types.
I propose extending the C# API to include support for defining array field schemas, which would allow developers to specify the type of elements in the array along with constraints such as capacity and maxLength. Below are proposed methods to add to the API for defining array fields with both varchar and scalar types:
FieldSchema.CreateVarcharArray("field_id", capacity: 200, maxLength: 255, description: "Array of varchars"),
FieldSchema.CreateArray<float>("field_id", capacity: 200, description: "Array of scalar types")

Thanks. Yeah, the SDK was originally developed against 2.2, and arrays were only introduced against 2.3 - we missed this. We'll take a look at implementing it.

As well as iterators. Crucial thing for our needs.

PR with an implementation https://github.com/milvus-io/milvus-sdk-csharp/pull/81


interaction.py file's cluster_tm_analysis doesn't run due to tfidf_vectorize not being defined?

import numpy as np
import pandas as pd
import matplotlib.pyplot as plt
import sys
sys.path.append('/content/social-network-url-clustering/src')
from data_loading.interactions import get_metadata, aggregate_text, cluster_tm_analysis
from preprocessing.vectorize_text import tfidf_vectorize, topic_generator
Error after using cluster_tm_analysis:
topics_list=cluster_tm_analysis(CLUSTER_FILE, METADATA_FILE, 1, 10)
NameError                                 Traceback (most recent call last)
 in
----> 1 topics_list=cluster_tm_analysis(CLUSTER_FILE , METADATA_FILE, 1, 10)
/content/social-network-url-clustering/src/data_loading/interactions.py in cluster_tm_analysis(cluster_json, filename, ngram, num_topics, i_min, n_len)
65     filtered_data = subset[subset.agg_text.apply(len)>n_len]
66
---> 67     tfidf, features = tfidf_vectorize(filtered_data.agg_text, ngram=ngram) #change ngrams here? predefined vocab can be adjusted
68
69     outputs=topic_generator(tfidf, features, num_topics=num_topics)
NameError: name 'tfidf_vectorize' is not defined

you never imported tfidf_vectorize in interactions. I would put cluster_tm_analysis in vectorize_text


Adding to contributor list

Translating document to Traditional Chinese (ZH-TW) and Simplified Chinese (ZH-CN).

Hi @kennith do you have an accompanying translation as a pull request? If so, can you add a link to it? We will pull this along with that one.

Hi @agektmr I started the translation for Traditional Chinese and Simplified Chinese. I submitted the review requests, but I am not sure if the translation was not correct or if the translation needs to be improved since it has not been reviewed or commented. I also prefer to make sure I am on the right direction before helping to translate more documents.
Here are the links to the review requests:
https://gitlocalize.com/repo/107/zh-TW/review/345
https://gitlocalize.com/repo/107/zh-TW/review/356
https://gitlocalize.com/repo/107/zh-TW/review/344
https://gitlocalize.com/repo/107/zh-TW/review/346
https://gitlocalize.com/repo/107/zh-TW/review/358
https://gitlocalize.com/repo/107/zh-CN/review/347

@limhenry Can you review his post on GitLocalize?

Everything looks OK!
@kennith i updated this: https://gitlocalize.com/repo/107/zh-TW/review/346/segments

@limhenry Thanks, but I think it should be
錯過了今年的 Chrome 開發峰會? 您可以在我們的YouTube播放列表觀看全部的峰會視頻。
and do you know how to create a pull request from GitLocalize? (Is pull request limited to moderator?)

@kennith only ones with moderator privilege can create a pull request. I'll help you do that for now.


[balsa] Re-enable header integration tests for BalsaParser.

[balsa] Re-enable IntegrationTest.[BadHeader,BadTrailer] for BalsaParser.
Explicitly enable trailers in IntegrationTest.BadTrailer, otherwise BalsaParser does not validate trailers.
Tracking issue: https://github.com/envoyproxy/envoy/issues/21245
Signed-off-by: Bence Béky<EMAIL_ADDRESS>Commit Message: [balsa] Re-enable header integration tests for BalsaParser.
Additional Description:
Risk Level: low, test-only change
Testing: //test/integration:integration_test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

/assign @diannahu @birenroy

Dianna and Biren: PTAL. Thanks!

/assign @KBaichoo

Kevin: PTAL.  For context, this change was made possible by https://github.com/google/quiche/commit/1fdac9bdbf85d27537e8ce47ca4f1eaa034f1ff5#diff-43919d5c357729334210d167fa9d89748b58c4e280723695f7529d1325d0edb2.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-29-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4749

Questions ?
Please refer to the Backport tool documentation


Can't render cheese in Godot 4 (material tester demo project)

Godot version:
Commit: 6e3f47983cabb5f162eaec075d810f717985beda
OS/device including version:
Windows 10, Vulkan, Nvidia 3070
Issue description:
Making our material tester demo work on Godot 4 there are two materials that result in the entire scene not rendering properly:

This happens with the Cheese and Marble materials, it looks like that it is subsurface scattering that is causing this.
Steps to reproduce:
Turn on subsurface scaterring on a material
Minimal reproduction project:
https://github.com/godotengine/godot-demo-projects/pull/616

What's happening with the depth draw? Looks like its not using the depth buffer and/or it's not functioning correctly

Fixed by #50186.


Enhancing consistency of Skill Card on Home page

hey @Vin205 ,
as a ui/ux designer it feels to see inconsistency in a web app and it  happens that there's one in e-nyanjoti's home page.
refer to screenshot below :

as you can see the placement of buttons are so inconsistent, please allow me to fix this hence assign me this issue.
don't forget to add gssoc-ext and hactoberfest-accepted labels.
Thank you

@iamsaura8h resolved this issue!


Encapsulate exceptions during chain and chainError

If the function passed to chain or chainError returned a non-promise type (specifically, a type that does not implement map or onRejected) then an exception would be thrown. This would typically happen if an exception was thrown during the passed function. Now use any exception thrown during a chain or chainError to reject the resulting promise.
@benschulz this is taken from your branch, rebased against master and edited to provide symmetry between chain and chainError. Are you happy with this?

Absolutely, though I'm not sure the comment in chain is still accurate.  Are you OK with me crediting you in the "Contributors" section of the READMEand, if so, what name and link would you prefer?

That's not really necessary, but if you feel like it, "Ben Schulz" and my github profile (https://github.com/benschulz) would do just fine. =)


Pybitcoin

@muneeb-ali can you check to see if this works for you? Hopefully I didn't break anything.

All looks good. Go ahead with the merge.

woohoo! :p


[WIP] Support returning multiple values

In this pull request i'll try to solve https://github.com/pirapira/bamboo/issues/14

Make sure to follow the ABI https://github.com/ethereum/wiki/wiki/Ethereum-Contract-ABI
For example, a boolean should occupy 256 bits.

@mqzry please indicate if you don't have time so that others could take over.

I do not have a lot of time. So others can pick it up if they want.


Make the whole search LHN menu scrollable

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/52910
PROPOSAL: https://github.com/Expensify/App/issues/52910#issuecomment-2491409188
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Prerequisite: have many saved search until it's scrollable

Open Search Page
Verify the whole search LHN is scrollable
For mobile, press the search type button to open the menu and verify it's scrollable

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/957e0ba0-c87a-45a6-bebe-2632895e8a92

Android: mWeb Chrome

https://github.com/user-attachments/assets/ade60be1-ceb5-47cf-8b56-a86438115927

iOS: Native

https://github.com/user-attachments/assets/b016ef4b-159f-4fd3-9cf4-c96c89997e01

iOS: mWeb Safari

https://github.com/user-attachments/assets/a85407ae-8bcc-4a82-81d6-54336c2740c3

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/b7aa615e-3f39-47ba-abdb-444d2703b66a

MacOS: Desktop

https://github.com/user-attachments/assets/efa0992b-20e5-4b1e-a6eb-64feb530b276

can you update the testing steps to add a precondition that there should be enough saved searches so that we can see the scrolling behaviour ?

There is already a prerequisite for that.

For mobile, go to search then press on the dropdown with the down arrow and verify it's scrollable

Open the search page is on the first step, so repeating it is redundant and I think the search type button is descriptive enough.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


start HTTP server before loading datasets

Codecov Report

Merging #256 (7b24dc4) into master (23b26a7) will increase coverage by 0.06%.
The diff coverage is 30.18%.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   70.63%   70.69%   +0.06%
==========================================
  Files          41       41
  Lines        7392     7418      +26
==========================================
+ Hits         5221     5244      +23
- Misses       1664     1667       +3
  Partials      507      507

Impacted Files
Coverage Δ

master/master.go
0.00% <0.00%> (ø)

master/tasks.go
36.48% <0.00%> (-4.88%)
:arrow_down:

model/ranking/data.go
86.64% <83.33%> (+0.53%)
:arrow_up:

model/click/data.go
80.85% <100.00%> (+1.42%)
:arrow_up:

server/rest.go
66.53% <100.00%> (ø)

worker/worker.go
53.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b26a7...7b24dc4. Read the comment docs.


Windows Wallet won

This issue tracker is only for technical issues related to bitcoin-core.
General hivecoin questions and/or support requests and are best directed to the Hivecoin Discord.
For reporting security issues, please direct message one of the core developers in discord.
Describe the issue
Can you reliably reproduce the issue?
If so, please list the steps to reproduce below:

Expected behaviour
Tell us what should happen
Actual behaviour
Tell us what happens instead
Screenshots.
If the issue is related to the GUI, screenshots can be added to this issue via drag & drop.
What version of bitcoin-core are you using?
List the version number/commit ID, and if it is an official binary, self compiled or a distribution package such as PPA.
Machine specs:

OS:
CPU:
RAM:
Disk size:
Disk Type (HD/SDD):

Any extra information that might be useful in the debugging process.
This is normally the contents of a debug.log or config.log file. Raw text or a link to a pastebin type site are preferred.

Windows QT Core won't sync so I can't send coins - Windows 10 pro, / Please Advise, thank you

Same issue

Looks like all of the seed nodes are down from log file
2024-02-25 04:50:25 IP: node1.hivecoin.org
2024-02-25 04:50:25 IP: <IP_ADDRESS>:9767
2024-02-25 04:50:25 IP: node2.hivecoin.org
2024-02-25 04:50:26 IP: <IP_ADDRESS>:9767
2024-02-25 04:50:26 IP: us-east-1.hivecoin.org
2024-02-25 04:50:26 IP: <IP_ADDRESS>:9767
2024-02-25 04:50:26 IP: us-west-1.hivecoin.org
2024-02-25 04:50:26 IP: <IP_ADDRESS>:9767
2024-02-25 04:50:26 4 addresses found from DNS seeds
2024-02-25 04:50:26 dnsseed thread exit


Bug #15307: Add check filterModel before registerJs in yii\grid\GridView

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
#15307

this is not correct, gridview.js also handles the checkbox column. Not only filters.


Reevaluate all public APIs

As a result of generating the .NET Aspire API docs, it became apparent that some APIs should not be public. This issue is to track the effort of re-evaluating all .NET Aspire public APIs:

Discuss and determine whether public APIs should alter their accessibility modifiers. It's expected that some APIs will become non-public, i.e.; internal, protected, or private.
While working through each API, it might be worthwhile to verify triple slash comments are meaningful, helpful, and provide an acceptable level of detail.

For example, this probably shouldn't be public:

FileNameSuffixes

Is the casing of "EndPoint" within service discovery intentional? I'm asking because it's generally spelled as "Endpoint", for example here. Also, the service discovery docs describe them as "endpoints", not "end-points" or "end points".

Is the casing of "EndPoint" within service discovery intentional? I'm asking because it's generally spelled as "Endpoint", for example here. Also, the service discovery docs describe them as "endpoints", not "end-points" or "end points".

That's a good callout. The various endpoint types are correctly spelled out as Endpoint. I think this should be updated, perhaps the old method name should be obsoleted, and the new one with the correct spelling added.

In System.Net it is EndPoint which is probably where our naming came from in service discovery - and then in Aspire we have EndpointAnnotation. So we are delightfully inconsistent here.


Async vs Sync Request

While trying to send page views hits and e-commerce hit if I send synchronous requests then I can see the data on my Google Analytics dashboard.. When I do the same with async request I don't see any hits. Any idea what the problem could be?
I'm switching the request type using the parameter in the config gamp.php file
'async_requests' => false,

@aditya-cherukuri Sorry for the delay. It seems like i totally missed this ticket. Async request could take few seconds, have you checked that?
Also check your logs for errors. Will have to debug this.

@irazasyed I have waited for quite a while on events to show up on the Analytics dashboard. Most of the time I don't see them.
I have checked Laravel logs but I don't see anything related to requests failing. Any other logs I need to check?
I also tried checking the AnalyticsResponse object as suggested in https://github.com/theiconic/php-ga-measurement-protocol#asynchronous-requests-non-blocking and I don't see anything different from the suggested results.

Do you still have this issue?
I was testing this today and it seems to be working fine. I hope you were able to resolve this. Please let me know if you still have problems.


Alef Maksura

@yanone reported an issue with the generated rules for ALEF MAKSURA, issue to track that.

           .medi version of ARABIC LETTER ALEF MAKSURA; both buffers returned    uni0649=1+1071
           space=1+0
           .init version of ARABIC LETTER ALEF MAKSURA; both buffers returned    uni0649=0+1071
           space=0+0

Specifically, the letter is reported as dual-joining by youseedee but only exists as right-joining. (The legacy characters also only exist as isolated and right-joining).

This issue doesn't seem right.

Specifically, the letter is reported as dual-joining by youseedee but in reality only exists as right-joining. (The legacy fully-encoded characters also only exist as isolated and right-joining).

@yanone Uighur uses 0649 dual-joining. Do you mean something more specific?

No, this is the answer. I wasn't aware of that and got confused further by the legacy right-joining-only encoded characters.
It means that we can ignore the reports at least for Arabic/Farsi/Urdu fonts at our discretion, and otherwise insist on it to function in full for fonts with wider language support.
Thank you. I'm closing this.


Incident page is cut off

On the incident page, no scroll bar is available. Some information is not shown on the screen.

Can you provide a screenshot and some information about your Phone? It looks good on my OnePlus 5

Screenshot sent per email. Guess my screen in smaller. Android 6.0.1.

I have the same issue here: Samsung Galaxy XCover 3 (SM-G389F) with 6.0.1

Will Take a look at this this evening - I am just not sure how to replicate this bug as it looks as it should on my test devices (OnePlus 5 / Samsung Galaxy S5 Mini)

I am just not sure how to replicate this bug as it looks as it should on my test devices

Is your device showing a scroll bar? Try to add more units?

I am just not sure how to replicate this bug as it looks as it should on my test devices
Just rotate the device/screen, if the incident is "long" enough you can probably reproduce it.

Just rotate the device/screen, if the incident is "long" enough you can probably reproduce it.

Smart. If I do so, the botton to the map is gone...

Okay, i found out why this happens - Units marked as "Führungskraft" see all units and the list was too long.
I've wrapped the List in a ScrollView so that it is scrollable. Should be fixed now.

@danielsteiner : according to https://forums.xamarin.com/discussion/2857/listview-inside-scrollview/p1 a listview never should be inside of a scrollview. Details for possible fixes see in slack.


Geospatial Location information added to recordings

I have it templated out in the recording but I should add the ability to put in a grid Id, Latitude/Longitude when uploading a recording.
Should probably also include a map that can be used to pick the lat/long points as well as manual inputs for the lat/lon

Update the Date selection to be a standard input that opens the actual map when the calendar icon is clicked on.  Right now it takes up too much space.
Maybe make it into a tabbed dialog or a wizard with File/Date/Location where you iterate through the options.
After entering the lat/lon could use geoJS and OSM layer to show the point where the record is located.

After updating the input.  I should add the geospatial information to the list output of the recording that have been uploaded.

This has been completed.


ExoPlayer DefaultHttpDataSource

Describe the bug
Some links can't playing on ExoPlayer. When i check the links, they can playable links, downloading directly. No problem for server side, we need the configure DefaultHttpDataSource, check screenshot below.
// Usually, home screen-recommended episodes can't playable.
Screenshots

there is a redirect problem, you can try allowCrossProtocolRedirects.

The problem described in the issue is about cross-protocol redirects (from http to https or vice versa). Exoplayer supports this, but you have to set allowCrossProtocolRedirects to true. Regular redirects (including 301 redirects) are supported by default. The redirect you're receiving is most likely a cross-protocol redirect.

https://stackoverflow.com/questions/41517440/exoplayer2-how-can-i-make-a-http-301-redirect-work

Fixed - ExoPlayer DefaultHttpDataSourceFactory added.


A more legible dice font

Recording this here since I think the idea has merit.
The DiceFont we have now is serviceable, but @Gazook89 presented what I think is a really nice alternative that allows larger characters, and is thus more legible to my eye.

I would rather keep a consistent dice shape [with the original DiceFont], and add a "stroke" around the numbers. The stroke wouldn't be another color, but just an 'erased' stroke...and the actual svg wouldn't actually have a true stroke.

If anyone wants to make a "diceFont Redux" as a side project.

And for fun, here's a crack at a D100.

Definitely prefer the second option, way more space between numbers and other lines

Here is a better take on the 'stroked' numbers.  Affinity Designer has a "Contour Tool" that can expand the edges of a shape, like a stroke, but keep the edge of that stroke as a vector path.   I'm sure InDesign and Inkscape have similar (I know inkscape has stroke-to-path capabilities which is similar).
So my process here was:

Open existing glyph svg in Designer
Duplicate the number layer (an SVG curve)
Use Contour Tool on the duplicated layer, and set radius to .6px
Select the dice shape layer, and the duplicated layer, and use the Subtract operation
export to SVG.

Unfortunately, Designer doesn't have any scripting. Other programs do.

I had a thought, more of just a "maybe this would be cool to try":  A variable font that used multiple alternate glyphs on a single axis.....applied here, it would be a single character that would change the displayed glyph based on something like the font-weight.   So a d10 character, that when set to font-weight: 1 would display a d10 glyph with the number 1 showing.   Change the font-weight to 2, and it would be the same character but display a 2 on it.
This isn't useful at all, I don't think, but you can read more about glyph swapping here.  https://glyphsapp.com/learn/alternating-glyph-shapes

This isn't useful at all, I don't think, but you can read more about glyph swapping here. https://glyphsapp.com/learn/alternating-glyph-shapes

I disagree, variable fonts are great! i just don't know exactly how they work just yet, or how to make them! If i did we would likely be using them.


Fix crashes where MessageList.searchView is accessed before it was initialized

Three different types of crashes related to this have been reported by Google Play.
See also: https://forum.k9mail.app/t/neue-version-offnet-nicht-mehr/5405

Unsuscribe.
On Sat, Sep 17, 2022, 14:50 cketti @.***> wrote:

Three different types of crashes related to this have been reported by
Google Play.
You can view, comment on, or merge this pull request online at:
https://github.com/thundernest/k-9/pull/6304
Commit Summary

165efa5
https://github.com/thundernest/k-9/pull/6304/commits/165efa598a1e8711efa0e11e0c43b33e9437650a
Fix crashes where `MessageList.searchView´ is accessed before it was
initialized

File Changes
(1 file https://github.com/thundernest/k-9/pull/6304/files)

M app/ui/legacy/src/main/java/com/fsck/k9/activity/MessageList.kt
https://github.com/thundernest/k-9/pull/6304/files#diff-271fc428848e559aa3f16bdd8e58ba4ec5af2bc2b3341d7344482ac512361adc
(26)

Patch Links:

https://github.com/thundernest/k-9/pull/6304.patch
https://github.com/thundernest/k-9/pull/6304.diff

—
Reply to this email directly, view it on GitHub
https://github.com/thundernest/k-9/pull/6304, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIE7ITSKARC772D2BBD5WKTV6WH75ANCNFSM6AAAAAAQO6ADDA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@shanuoon: You'll have more luck clicking the "unsubscribe" link in the email you've received.

Thanks very much

Very good metold


Header menu fixes

Description
Fixes two issues:

Removes the overflow style from the document body when clicking outside of the menu to close it
Closes the menu when clicking on the overlay

Checklist:

[x] The commit messages follow the convention for this project
[x] I have provided an adequate amount of test coverage

@pauleustice thanks for spotting those bits, have amended now. @elenagarrone please can you take another look as well 🙏


📡 Recursive math commands for LaTeX

See #392

@alanlujan91 @stevejpurves this should fix up the math recursion issues you were running into in #392! We will release it sometime this week!


Packs install (dowhload) is broken when branch is specified

If user specifies a "branch" parameter when installing a pack it doesn't work.
From Slack:
[14:19] root@ip-10-1-0-25:~/aws/roles/stackstorm/tasks# st2 execution get 589c7a79ecf50606a1314870
id: 589c7a79ecf50606a1314870
status: failed (2s elapsed)
parameters:
  force: false
  packs:
  - git@github.com:pearsontechnology/stackstorm-bitesize.git
result:
  exit_code: 1
  result: None
  stderr: "Traceback (most recent call last):
  File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/runners/python_action_wrapper.py", line 238, in <module>
    obj.run()
  File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/runners/python_action_wrapper.py", line 152, in run
    output = action.run(**self._parameters)
  File "/opt/stackstorm/packs/packs/actions/pack_mgmt/download.py", line 75, in run
    verifyssl=verifyssl, ref=pack_version)
  File "/opt/stackstorm/packs/packs/actions/pack_mgmt/download.py", line 139, in _clone_repo
    repo.git.checkout('-b', short_branch, branch)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/git/cmd.py", line 423, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/git/cmd.py", line 868, in _call_process
    return self.execute(call, **_kwargs)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/git/cmd.py", line 686, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout -b dev dev
  stderr: 'fatal: A branch named 'dev' already exists.'
"
  stdout: ''

We need some unit and integration tests for this as well.

Edit: It looks like it might only be related to an edge case when using a non-master default branch - confirming...

Confirmed - it's related to the default branch not being master - will work on a fix.

Fixed by #3201.


[Feat] Allow for stacking of effects.

Pretty sure this can be closed, right? Unless I've misunderstood the feature this issue represents, we can already do this.

This pertains to effects like fatigue and strife


Using both URLEncoding and JSONEncoding

I have to use an API that asks me to make a POST and put one parameter in the URL, others as JSON in the body.
If I had to only send the URL parameter, I would use URLEncoding.queryString
If I had to only send the body parameters, I would use JSONEncoding.default
But how can I send both with Moya? As far as I know, Moya only allow 1 parameter encoding.
As a workaround, in my implementation of TargetType I left the body params in parameters and 'parameterEncoding` to JSONEncoding.default, and tried to put the query parameter directly in the path, but doing so the '?' is encoded as '%3F' while it shouldn't and the API returns an error.
Using Moya 8.0.3

Nvm, I found some inspiration from https://github.com/Moya/Moya/issues/909 and created a custom encoding.
`struct MultipleEncoding : ParameterEncoding {
var urlParameters: [String]?

init(urlParameters:[String]) {
	self.urlParameters = urlParameters
}

func encode(_ urlRequest: Alamofire.URLRequestConvertible, with parameters: Parameters?) throws -> URLRequest {
	guard let parameters = parameters else { return urlRequest as! URLRequest }

	//Encode URL Params
	var filteredParams: [String: Any] = [:]

	parameters.filter({ (key,value) in
		return urlParameters?.contains(key) ?? false
	}).forEach {
		filteredParams[$0.0] = $0.1
	}

	let partiallyEncodedRequest = try URLEncoding.queryString.encode(urlRequest, with: filteredParams)

	//Encode JSON
	filteredParams = parameters.minus(dict: filteredParams)
	return try JSONEncoding.default.encode(partiallyEncodedRequest, with: filteredParams)
}

}`
That's not very generic but I someone has the same issue, here is something to start with :)

@amaurydavid  parameter.minus is not working. And can you help out on how to use this?


React resizable doesn't work with react-draggable anymore

Please select the type of issue you're reporting. For questions.

[x] Bug
[ ] Feature Request
[ ] Question

With new version (v2.0.0) nesting react-resizable within react-draggable is not working.
System Info
Node Version: v12.18.2
Browser: Chrome
OS: Windows 10
project created with react scripts / create react app
using:
"react": "^16.13.1",
"react-dom": "^16.13.1",
"react-draggable": "^4.4.3",
"react-resizable": "^2.0.0",
"react-scripts": "3.4.3"
Reproduction
https://codesandbox.io/s/red-fog-umlic?file=/src/App.js - this one doesnt work
https://codesandbox.io/s/condescending-feynman-t75eq?file=/src/App.js - this one works but has react resizable v1.10.1

use ResizableBox instead of Resizable and works fine

use ResizableBox instead of Resizable and works fine

I didn't try. I believe you. I don't think it is the right solution, and I didn't see anywhere in documentation explicit statement that we should replace Resizable with ResizableBox when updating from an old version to new.

I didn't try. I believe you. I don't think it is the right solution, and I didn't see anywhere in documentation explicit statement that we should replace Resizable with ResizableBox when updating from an old version to new.

This is why the deprecation message exists on 2.0.0 - we removed props passthrough and this turned out to break too many apps. This is outlined in detail in the CHANGELOG.

This is why the deprecation message exists on 2.0.0 - we removed props passthrough and this turned out to break too many apps. This is outlined in detail in the CHANGELOG.

https://codesandbox.io/s/admiring-hopper-wji3n?file=/src/App.js
It does work as expected. If the resize direction is one of n, nw, ne, w, sw, nw


Making extra messages for error messaging optional

Is there a way to make the extra error messages the _validator yields optional? If not, could it be an enhancement where you pass an "extraErrorMessages" property on the schema that is a boolean? I need to be able to disable that feature because of security issues.

Hi. Not sure I know what you mean here unfortunately.
Which extra messages are you referring to (and what do you mean by security issues)?
Perhaps sharing what code you're running would be helpful too.

Happy to discuss further if you can clarify!


Clarify use of istioctl vs kubectl

Fixes #1843
This PR fixes #1843 by clearly separating and explaining the use of istioctl vs kubectl.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: frankbu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [frankbu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: frankbu, sdake
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [frankbu,sdake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fixed port-forward command

The example described the in the docs isn't working without adding --namespace argocd to the port-forward directive.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Spark not initializing in local conda env

I have run into the issue that a notebook that I create/use in the web portal for Synapse Data Science seems to be missing environment initialization locally that happens on the web.
Steps:

Create a data science notebook in the web portal for Fabric, connect a Data Lake with data in it.
Right click a data file in the lake and choose load data > Spark

Run the cell that is inserted into the code and see that it loads the data correctly:

Click the tool bar button to open the notebook in VS Code (have the Synapse extension already installed) and confirm opening the notebook.
Select the conda env created by the extension () for the newly opened notebook:

Try running the same cell to load the spark frame and you get an attribute error:

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[1], line 1
----> 1 df = spark.read.format("csv").option("header","true").load("Files/Manateetracking/NW_GOM_manatee_habitat_data.csv")
      2 # df now is a Spark DataFrame containing CSV data from "Files/Manateetracking/NW_GOM_manatee_habitat_data.csv".
      3 display(df)

AttributeError: 'NoneType' object has no attribute 'read'

I also checked that the other UI suggested way of loading Lakehouse data with Pandas works in the web based notebook, but the Pandas package is not installed in the local conda env created with the extension:

Happy to grab more screenshots, but my main goal is to work on the same notebook that is in the web portal locally (in a Dev Container if possible to make the JDK requirement easy)
Thanks!

Hi @crazy4pi314 Thank you for reporting this issue.
Could you provide the python log to us?

Go to Local Work Folder 2) Go to logs folder 3) Go to the specific notebook artifact folder named by notebook artifact id 4) Show the PySparkLighter.log

We don't have pandas as a hard dependency of the local conda env. It will not be installed automatically when creating env. But we will try to keep it consistent with the fabric runtime package in the dev container. (We can try the dev container synchronously offline. But we haven't released it yet.)

The log file, I will double check my jdk install is ok, but that is part of why I started working in a DevContainer bc I don't trust any machine local state :)
00:58:28,363 root INFO Using synapse remote kernel ...
00:58:28,387 root INFO Should attach session in dev mode False
00:58:28,884 root INFO Starting session 1543b35e-acc5-46c9-aa76-a180b8067954...
00:58:37,469 root INFO https://pbipmsitwcus22-msit.pbidedicated.windows.net/webapi/capacities/F6B87806-0697-4974-BEA2-125CAEB71A13/workloads/Notebook/Data/Direct/sparklighter/api/tjs/versions/2022-04-30/artifacts/3a036ea4-abd3-4a73-a91d-8841b046b866/sessions/1543b35e-acc5-46c9-aa76-a180b8067954
00:58:39,70 root INFO <session_management.SessionStatus object at 0x0000020705130970>
00:58:44,719 root INFO Trident session states: idle
00:58:44,729 root INFO Starting session 1543b35e-acc5-46c9-aa76-a180b8067954 finished...
00:58:44,729 root INFO Attaching spark session 1543b35e-acc5-46c9-aa76-a180b8067954 for Spark Lighter ...
00:58:46,552 root ERROR Failed to initialize Spark Lighter variables. Java gateway process exited before sending its port number
00:58:46,552 root INFO Registering Spark Lighter magics for IPython...
00:58:46,552 root INFO Registered Spark Lighter magics for IPython.
01:15:47,654 root INFO Using synapse remote kernel ...
01:15:47,683 root INFO Should attach session in dev mode False
01:15:47,949 root INFO Starting session 84fd5121-1a72-464d-a763-3de26c36d67d...
01:15:50,906 root INFO https://pbipmsitwcus22-msit.pbidedicated.windows.net/webapi/capacities/F6B87806-0697-4974-BEA2-125CAEB71A13/workloads/Notebook/Data/Direct/sparklighter/api/tjs/versions/2022-04-30/artifacts/3a036ea4-abd3-4a73-a91d-8841b046b866/sessions/84fd5121-1a72-464d-a763-3de26c36d67d
01:15:53,623 root INFO <session_management.SessionStatus object at 0x00000195B77C0970>
01:15:57,600 root INFO Trident session states: busy
01:16:03,966 root INFO Trident session states: busy
01:16:11,230 root INFO Trident session states: idle
01:16:11,236 root INFO Starting session 84fd5121-1a72-464d-a763-3de26c36d67d finished...
01:16:11,236 root INFO Attaching spark session 84fd5121-1a72-464d-a763-3de26c36d67d for Spark Lighter ...
01:16:13,17 root ERROR Failed to initialize Spark Lighter variables. Java gateway process exited before sending its port number
01:16:13,17 root INFO Registering Spark Lighter magics for IPython...
01:16:13,17 root INFO Registered Spark Lighter magics for IPython.
01:16:36,977 root INFO Using synapse remote kernel ...
01:16:36,990 root INFO Should attach session in dev mode False
01:16:37,719 root INFO Starting session 8a5fa6be-17fe-4fc0-bfe7-b20efc89a454...
01:16:41,28 root INFO https://pbipmsitwcus22-msit.pbidedicated.windows.net/webapi/capacities/F6B87806-0697-4974-BEA2-125CAEB71A13/workloads/Notebook/Data/Direct/sparklighter/api/tjs/versions/2022-04-30/artifacts/3a036ea4-abd3-4a73-a91d-8841b046b866/sessions/8a5fa6be-17fe-4fc0-bfe7-b20efc89a454
01:16:42,552 root INFO <session_management.SessionStatus object at 0x000001ECB4240430>
01:16:46,335 root INFO Trident session states: idle
01:16:46,341 root INFO Starting session 8a5fa6be-17fe-4fc0-bfe7-b20efc89a454 finished...
01:16:46,341 root INFO Attaching spark session 8a5fa6be-17fe-4fc0-bfe7-b20efc89a454 for Spark Lighter ...
01:16:47,700 root ERROR Failed to initialize Spark Lighter variables. Java gateway process exited before sending its port number
01:16:47,702 root INFO Registering Spark Lighter magics for IPython...
01:16:47,703 root INFO Registered Spark Lighter magics for IPython.
01:17:20,750 root INFO Using synapse remote kernel ...
01:17:20,774 root INFO Should attach session in dev mode False
01:17:21,34 root INFO Starting session 3771af0e-62f3-4973-8ed9-8efce3bea1c4...
01:17:24,40 root INFO https://pbipmsitwcus22-msit.pbidedicated.windows.net/webapi/capacities/F6B87806-0697-4974-BEA2-125CAEB71A13/workloads/Notebook/Data/Direct/sparklighter/api/tjs/versions/2022-04-30/artifacts/3a036ea4-abd3-4a73-a91d-8841b046b866/sessions/3771af0e-62f3-4973-8ed9-8efce3bea1c4
01:17:25,544 root INFO <session_management.SessionStatus object at 0x000002403EC70430>
01:17:29,8 root INFO Trident session states: idle
01:17:29,15 root INFO Starting session 3771af0e-62f3-4973-8ed9-8efce3bea1c4 finished...
01:17:29,15 root INFO Attaching spark session 3771af0e-62f3-4973-8ed9-8efce3bea1c4 for Spark Lighter ...
01:17:30,224 root ERROR Failed to initialize Spark Lighter variables. Java gateway process exited before sending its port number
01:17:30,224 root INFO Registering Spark Lighter magics for IPython...
01:17:30,224 root INFO Registered Spark Lighter magics for IPython.

Update: I uninstalled and re-installed all Java/JDK tools on my system and that seems to have fixed the failing Java gateway process, and I was able to run the spark cells (intellisense still didn't have info on the spark package somehow though). I'll test some more now, but at least the basic setup seems to be working! <3
I think this makes a good argument for Dev Containers, to make sure the JDK setup is correct and reproducable across platforms/OS 💪

@crazy4pi314  Thanks :) we are working on this


iOS 17 hidden trackpad doesn't work in the TextFields (hold space bar and swipe to move cursor)

Describe the bug
The iOS 17 introduced hidden trackpad feature, when you can hold the spacebar and then move the cursor with the swipe on the keyboard.
This doesn't move the cursor in any TextField in Jetpack Compose Multiplatform.
Surprisingly - the same feature works fine on Android with the same code.
Affected platforms

iOS

Versions

Kotlin version*: 1.9.23
Compose Multiplatform version*: 1.6.1
OS version(s)* (required for Desktop and iOS issues): 17.2
OS architecture (x86 or arm64): arm64
Device (model or simulator for iOS issues): any iOS device or simulator

To Reproduce
Steps and/or the code snippet to reproduce the behavior:

Add a simple text field to the multiplatform app:

@Composable
fun App() {
    MaterialTheme {
        var text by remember { mutableStateOf("") }
        TextField(
            modifier = Modifier.fillMaxWidth(),
            value = text,
            onValueChange = { text = it }
        )
    }
}

Run the app on either iOS 17 device or iOS 17 simulator
Enter something in the text field
Hold the space bar on the soft keyboard and move finger while holding it

Expected behavior
Cursor should move in the direction finger moves. Actually - cursor stays in place.
Screenshots
iOS simulator, how it actually works:
https://github.com/JetBrains/compose-multiplatform/assets/6439273/de8baba4-0785-4bb8-905e-6cbb34f58957
The same app running on Android Emulator (API 34):
https://github.com/JetBrains/compose-multiplatform/assets/6439273/57c61cc2-2aa7-44c3-a4c1-3778b0a4c693
Additional context
This is the new feature in iOS 17 - https://www.cnet.com/tech/mobile/this-secret-ios-trackpad-makes-typing-on-your-iphone-so-much-easier/

@mazunin-v-jb Are we working on this?

Yes, we're planning to support that but not in the nearest future.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


RemoteDeploymentSample Exception on Deployer shutdown

Hi @skotzko,
Here is an issue for sample.
I've tried the RemoteDeploymentSample solution and noted that in case of "normal" (hit any key) termination of Deployer following exception appear:
[ERROR][16/07/2015 18:02:47][Thread 0021][[akka://DeployTarget/system/transports
/akkaprotocolmanager.tcp.0/akkaProtocol-tcp%3a%2f%2fDeployTarget%40<IP_ADDRESS>%3a6
202-1]] Underlying transport closed.
Cause: Helios.Exceptions.HeliosConnectionException: An existing connection was f
orcibly closed by the remote host ---> System.Net.Sockets.SocketException: An ex
isting connection was forcibly closed by the remote host
at System.Net.Sockets.Socket.EndReceive(IAsyncResult asyncResult)
at Helios.Reactor.Tcp.TcpProxyReactor.ReceiveCallback(IAsyncResult ar)
--- End of inner exception stack trace ---
[ERROR][16/07/2015 18:02:47][Thread 0010][[akka://DeployTarget/system/endpointMa
nager/reliableEndpointWriter-akka.tcp%3a%2f%2fDeployer%40localhost%3a6201-1/endp
ointWriter]] AssociationError [akka.tcp://DeployTarget@localhost:8090] <- akka.t
cp://Deployer@localhost:6201: Error [Shut down address: akka.tcp://Deployer@loca
lhost:6201] [   at Akka.Remote.EndpointReader.HandleDisassociated(DisassociateIn
fo info)
at Akka.Remote.EndpointReader.OnReceive(Object message)
at Akka.Actor.UntypedActor.Receive(Object message)
at Akka.Actor.ActorBase.AroundReceive(Receive receive, Object message)
at Akka.Actor.ActorCell.ReceiveMessage(Object message)
at Akka.Actor.ActorCell.Invoke(Envelope envelope)]
Cause: Unknown
[ERROR][16/07/2015 18:02:47][Thread 0010][akka://DeployTarget/system/endpointMan
ager/reliableEndpointWriter-akka.tcp%3a%2f%2fDeployer%40localhost%3a6201-1] Shut
down address: akka.tcp://Deployer@localhost:6201
Cause: Akka.Remote.ShutDownAssociation: Shut down address: akka.tcp://Deployer@l
ocalhost:6201 ---> Akka.Remote.Transport.InvalidAssociationException: The remote
system terminated the association because it is shutting down.
--- End of inner exception stack trace ---
at Akka.Actor.ActorCell.HandleFailed(Failed f)
at Akka.Actor.ActorCell.SystemInvoke(Envelope envelope)
How to make it not to throw an exception on Deployer termination?

@shilonosov this is intended behavior, as Akka.Remote logs an error when the association it has with a remote system closes.
The error message will happen regardless--that is Akka.Remote doing its job--but you should also have seen, right after the error message, a statement that said Was address terminated? True.
The reason we see this message right after (the Was address terminated? message) is because we've DeathWatched the remote actor (see line 21).
With this Context.Watch() we are demonstrating a way to listen to see if the reason we received a Terminated message was because the Association between the two systems closed. The Terminated.AddressTerminated property returns true if the reason why we're receiving
this death watch notification is because the association between our current ActorSystem
and the remote ActorSystem that Terminated.ActorRef lived on failed.
Does that make sense?


docker-compose client asking for access the api

I hope someone can help me. I tried to build the quickstart examples with docker-compose.
So i look at the docker folder and created the docker-compose.yml and the dockerfiles.
After that i created the project, how it was discribed at the quickstarter: http://docs.identityserver.io/en/release/quickstarts/1_client_credentials.html
but if i try to run this example, my output look like that:
{
client            |   "access_token": "eyJhbGciOiJSUzI1NiIsImtpZCI6Ijg4M2YxYTJlOThjODA2MDc2YTYyY2Q1ZmIzYmMwOTE4IiwidHlwIjoiSldUIn0.eyJuYmYiOjE0ODYxMzU3MzQsImV4cCI6MTQ4NjEzOTMzNCwiaXNzIjoiaHR0cDovL2xvY2FsaG9zdDo1MDAwIiwiYXVkIjpbImh0dHA6Ly9sb2NhbGhvc3Q6NTAwMC9yZXNvdXJjZXMiLCJhcGkxIl0sImNsaWVudF9pZCI6ImNsaWVudCIsInNjb3BlIjpbImFwaTEiXX0.Jk0MqKwvTimM9Yp27SXhymlK-MvBPV8KmZMVskF9HB-ISJBoTTp83-76G2BsxMv4E0u-Z3cYdG76tHHHCGsalQLM3zj366xwPXXu_XDCntjCYeMd0g0HJoeKXQTJTjYvRjNRzeo5yqDfLrzHUMxtqkauOKtAK4eqOU4zQ4eE5bRsIz6uT_-aAPVjWVBAFRfdFWidrtNevG9K-TzjhPsXExXheUpOt_c0JQ1Iyq0UtE6h08K210zPPiDKKQcqn-9Z1RkqyricZsklrvtkdnlszP1sG7D1Gp7vYj38Cum-IS-9xg1uKGkvILg1rL7g-z-zMcnElECfv3R18VfFvR2Nkg",
client            |   "expires_in": 3600,
client            |   "token_type": "Bearer"
client            | }
client            | Unhandled Exception: System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.Net.Http.CurlException: Couldn't connect to server

the client aasking the idserver for access token and getting it. after that the client asking the api for access but the server is not there.....and i don´t know why.
without docker it working well. i attached my project. Hopefully someone can help me.
id4.zip

hi,
i solved the problem by myself.
greetings

What was the fix?

i have to change the line : var response = await client.GetAsync("http://localhost:1773/identity"); into var response = await client.GetAsync("http://api:1773/identity"); at the program.cs in the client project folder.
thats adresse that was declared at the docker-compose.yml, but everywherer, was to read that it works with localhost too.
greetings


Improve coverage

The code coverage https://app.codecov.io/gh/megaease/easegress seems to be less than 60%.
It would be great if it can be brought up around 80-90% and ideally a 100%.

Hi, @phanirithvij. Thanks for the suggestion.
Yes, I am totally agreed with you. And We are working on raising the coverage rate aiming at 85% at least.
And we are also opened to any kind of suggestions and contributions. If u are interested in Easegress project, welcome to join our Easegress product slack: https://openmegaease.slack.com/archives/C028Z6SUCU9,  as well. :-)

HI， @phanirithvij
we,@localvar @suchen-sci , had added some test cases, and now the coverage rate is 81%.
https://app.codecov.io/gh/megaease/easegress
I closed this issue but we will continue to work on it.


Add qhub-ops validate command to PR github action

run qhub-ops validate  in github action
post comment to github PR using GITHUB_TOKEN

https://github.com/Quansight/qhub-ops/blob/master/qhub_ops/template/{{ cookiecutter.repo_directory }}/.github/workflows/jupyterhub-pr.yaml

https://github.com/Quansight/qhub-github-actions
https://github.com/Quansight/qhub-gcp-test-deployment/pull/1#issuecomment-707298719

Closing as completed

Closing as completed


ArcGIS Enterprise 11.1 Support

Hi @cameronkroeker
Is cookbook 4.0.0 supports ArcGIS Enterprise 11.1?
If not then when we can expect to get support for 11.1?
Thanks
Ayush

Hi @Ayushyadav19,
v4.0.0 supports 10.8 through 11.0:
https://esri.github.io/arcgis-cookbook/versions.html
We are aiming to release v4.1.0, that adds support for 11.1, sometime early next week.
Thanks,
Cameron K.

Hi @Ayushyadav19,
Cookbooks v4.1.0 for 11.1 has been released:
https://github.com/Esri/arcgis-cookbook/releases/tag/v4.1.0
Thanks,
Cameron K.


[Question] Date-typed request parameter

Please take the time to search the repository, if your question has already been asked or answered.

[ ] What version of the library are you using? 2.8.0 Is it the latest version? yes

What kind of issue is this?

[X] Question. Is this a question about how to do a certain thing?

[ ] Bug report. no, probably not

[ ] Feature Request. no

This is probably something real simple, but my flu-infested brain can't figure it out at the moment. I have a request parameter as follows:
@RequestParam(value = "from", required = false) @DateTimeFormat(iso = DATE_TIME) Date from

How can I make it show up in the Swagger documentation as a date field? It just comes back as a string. I've tinkered around with @ApiParam and directModelSubstitute to no avail.

This doesnt work out of the box? If not its a bug.

Same here
spring boot 2.0 RC1
spring fox 2.8.0 using swagger2 config
tested all of java.util.Date, java.time.LocalDate and java.time.OffsetDateTime
they appear as strings with the appropriate date/date-time in the generated swagger json
but swagger-ui displays a simple "string" as parameter type (it omits to indicate the format)

Seems like a bug in swagger ui!

Yes, the JSON is correct, for me too:
      {
        "name": "from",
        "in": "query",
        "description": "date/time from which to ...",
        "required": false,
        "type": "string",
        "format": "date-time"
      },

Now, this is the Swagger UI that comes with Springfox: io.springfox:springfox-swagger-ui:2.8.0.


python37Packages.distributed: 2.3.0 -> 2.4.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-distributed/versions.
meta.description for python37Packages.distributed is: '"Distributed computation in Python."'.
meta.homepage for python37Packages.distributed is: '"https://distributed.readthedocs.io/en/latest/"

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.4.0 with grep in /nix/store/dkazak95r2sk9v6hx0ayk949s8z154cy-python3.7-distributed-2.4.0

directory tree listing: https://gist.github.com/c2c59e9df0904084bc02d96c931453ef

du listing: https://gist.github.com/05b9932f90ffe6fed8ab3691d8d40f74

Rebuild report (if merged into master) (click to expand)

26 total rebuild path(s)
7 package rebuild(s)
7 x86_64-linux rebuild(s)
6 i686-linux rebuild(s)
7 x86_64-darwin rebuild(s)
6 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
python37Packages.dask-jobqueue
python37Packages.dask-mpi
python37Packages.dask-xgboost
python37Packages.datashader
python37Packages.distributed
python37Packages.streamz
python37Packages.stumpy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dkazak95r2sk9v6hx0ayk949s8z154cy-python3.7-distributed-2.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A python37Packages.distributed https://github.com/r-ryantm/nixpkgs/archive/c5791b47725a87933726d69a8c61b9de77d3dc36.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dkazak95r2sk9v6hx0ayk949s8z154cy-python3.7-distributed-2.4.0
ls -la /nix/store/dkazak95r2sk9v6hx0ayk949s8z154cy-python3.7-distributed-2.4.0/bin

cc @teh @costrouc for testing.

All dependent packages that aren't already broken build successfully, both macos 10.13 & non-nixos linux x86_64.


Add is_connected property to NetworkBase class

NetworkBase.is_connected calls _wifi.is_connected which calls esp.is_connected

closing


ipam: use ip provided by nad annotation when providing IPAM for other CNI plugins

Pull Request

[x] Make sure you have followed Kube-OVN Code Style.

What type of this PR
Examples of user facing changes:

Features
Bug fixes
Docs
Tests

Which issue(s) this PR fixes
Fixes #(issue-number)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 4 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 22.088%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controller/pod.go
0
4
0.0%

Totals

Change from base Build<PHONE_NUMBER>1:
0.0%

Covered Lines:
10160

Relevant Lines:
45997

💛  - Coveralls


CodeWindow: renderer process gone (reason: crashed, code: -1) 2

Does this issue occur when all extensions are disabled?: YES

VS Code Version:  1**.81** (tried with inside version)

OS Version: Windows 11 pro for workstations / 22H2 / 22621.2070 / 48,0 GB / AMD Ryzen 5 3600 6-Core Processor                 3.60 GHz

Steps to Reproduce:

We open the code (or let's say Discord) and it shows (pops up) the
interface is closed within 3 seconds...
renderer.log

Without any errors, any Electron (V8) application....

LOGS
main.log
renderer.log
exthost.log

Extensions are disabled.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!
VSCodeSetup-x64-1.81.0
No, this is the latest stable version.(

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.0. Please try upgrading to the latest version and checking whether this issue remains.

VSCodeSetup-x64-1.81.0
No, this is the latest stable version. (

here is another instruction. I use this utility (Modem Tweaker .
Windows) myself, it saves both soft and useful with optimization.
https://bestwindowssoftware.net/how-to-fix-paged-pool-non-paged-pool-memory-leak/

Fixing a memory leak (non-paged pool)
I do NOT recommend used.


Dependency

Hi,
I find your work to be very interesting and I'd like to try run your code (ACC 2021 to be specific). However, it seems the optimization with the sdpsettings relies on ipopt solver. The documentation here says it's based on the OPTI Toolbox, which seems to only work on Windows.
Sorry that I'm not a very experienced Matlab user. May I know am I following the correct path to set up the dependency? Is Windows really required?

Thank you for your interests, actually all my implementations are tested on ubuntu 18.04 system while not on windows. ipopt has mex file version, which can be found in the original archived repo link. Unzip that file and add it into your matlab address and it would solve your bugs.
Raise further questions or you cannot figure it out.

Thank you it works!

Let me just open it and I can upload dependencies for later users.

@yswhynot A new PR resolves this, thank you for pointing it out.


Proposal of Annotation Format

Annotation sample:
{
    "pii-low": "true",
    "pii-high": "false",
    "pii-finance": "false",
    "columns": {
        "actor_id": {
            "description": "Actor ID generated with Python UUID"
        },
        "actor_name": {
            "description": "Full name of actor in 'firstname (midname) lastname' format",
            "data-type": "VARCHAR(250)",
            "evolutions": [
                {
                    "maintenance-date": "10/04/2022",
                    "note": "Increase limit size from 100 to 250. Issue #12201."
                }
            ]
        }
    },
    "rows": {
        "6cde318f1ab8633211c4e622a78c9f5dc8991069744d7a3673b48b822669d022": {
            "correction": "The value of the row with this hash is outdated"
        }
    }
}

Table-level annotation:
{
    "pii-low": "true",
    "pii-high": "false",
    "pii-finance": "false"
}

Column-level annotation:
{
    "columns": {
        "actor_id": {
            "description": "Actor ID generated with Python UUID"
        },
        "actor_name": {
            "description": "Full name of actor in 'firstname (midname) lastname' format",
            "data-type": "VARCHAR(250)",
            "evolutions": [
                {
                    "maintenance-date": "10/04/2022",
                    "note": "Increase limit size from 100 to 250. Issue #12201."
                }
            ]
        }
    }
}

Row-level annotation:
{
    "rows": {
        "6cde318f1ab8633211c4e622a78c9f5dc8991069744d7a3673b48b822669d022": {
            "correction": "The value of the row with this hash is outdated"
        }
    }
}

Annotation rule:

Comply with the format
JSON serializable


Publish public npm registory v0.5.0

I would like to use<EMAIL_ADDRESS>(include dd94623fa73d8775155577146798abfbeee14a08) throgh official public npm registory. Would you publish<EMAIL_ADDRESS>?

@soundTricker Could you check this issue?

Released


Fix code style and remove unnecessary abbreviations

This PR contains some small style fixes. For some of the fixes, a relatively large amount of lines is touched (making this PR a bit larger than ideal), but the changes itself are very minor.

Remove unnecessary abbreviations to improve readability and consistency throughout the code base (in some places there are many, in others none). They make the code harder to read and do not provide any benefit. I hope I caught all of them. (2d15bdc and 9336290)
Remove (some) unnecessary line breaks for lines short than 100 characters (2d15bdc)
Remove an unnecessary else case in the launcher. This is done to express the intent of the method better and make it consistent with other code. (9d0a4d4)
Improve readability of directions in PacManSprites by moving them to separate lines (a9f5f65)
Remove unnecessary empty lines from PlayerCollisions (3a05155)
Fix indentation of the switch statement in the createGhost method in LevelFactory (9336290)

Better indeed! Thanks!

Beautiful PR, @casperboone! Clean code for the win!!


Chronological results section only showing FAILED/ERRORS

Fixed by moving report option statements for verbose and all (-v and -A) to new section pytest_cmdline_main:
def pytest_cmdline_main(config: Config) -> None:
    config.option.verbose = 1  # easier parsing of final test results
    config.option.reportchars = "A"  # "display all" mode so all results are shown


Received status code 403 from server: Forbidden

I'm using yarn to add @notifee/react-native, running android, and it fails to compile
Could not GET 'https://maven.testfairy.com/app/notifee/core/maven-metadata.xml'. Received status code 403 from server: Forbidden

Hi there, this will have nothing to do with this repository - it appears you are having a local network issue and somewhere in your gradle build configs you are using testfairy.com, we are not.
https://github.com/search?q=repo%3Ainvertase%2Fnotifee testfairy&type=code
You may need to add the local maven repository though you have included zero information about your build config so I can't comment on why or how you would best do that
There are other issues that may provide guidance though
https://github.com/invertase/notifee/issues?q=is%3Aissue+could+not+find+any+matches


Revert "Switch rmm::get_current_device_resource to use references via rmm::get_current_device_resource_ref"

Reverts NVIDIA/spark-rapids-jni#2372
This temporarily reverts https://github.com/NVIDIA/spark-rapids-jni/pull/2372 while we wait for RMM https://github.com/rapidsai/rmm/pull/1661 to be merged.
In response to comment by @harrism https://github.com/NVIDIA/spark-rapids-jni/pull/2372#issuecomment-2330474142

Opened a PR with signoff here: https://github.com/NVIDIA/spark-rapids-jni/pull/2382


Feat: add select order by feature.

What this PR does:
Which issue(s) this PR fixes:

For #92 .
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #260 (e0b20e6) into master (ddd683f) will decrease coverage by 0.05%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   37.40%   37.34%   -0.06%
==========================================
  Files          93       93
  Lines       13692    13772      +80
==========================================
+ Hits         5121     5143      +22
- Misses       7928     7980      +52
- Partials      643      649       +6

Impacted Files
Coverage Δ

pkg/dataset/fuse.go
44.26% <18.75%> (-9.74%)
:arrow_down:

pkg/runtime/optimize/optimizer.go
24.67% <25.00%> (+<0.01%)
:arrow_up:

pkg/dataset/priority_queue.go
56.47% <39.65%> (-37.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd683f...e0b20e6. Read the comment docs.


Support parallel test execution

We can use isolated ROS2 partitions to run tests in parallel. This is very useful with pytest-parallel, e.g. when you can run pytest --workers $((2 * $(nproc))). For this, you need to set the ROS_DOMAIN_ID:
import os
import random
if use_random_domain_id:
    if "ROS_DOMAIN_ID" in os.environ:
        warn("the user about the fact that they already specified it")
    os.environ["ROS_DOMAIN_ID"] = str(random.randint(0, 232))  # or maybe more clever?

One can also pass domain_id to rclpy.Context.init() (relevant for @with_single_node).


How to control navbar "collapsing"?

On some browsers my webpage is collapsing the navbar into the 3 horizontal lines in the top-right corner, even though there is plenty of room for the section headings, since I currently only have 3 of them.
On my linux system, the webpage displays the sections as I would like:

However, on other OSes, for example on Windows Edge, the navbar is collapsed:

This was also reported by a user using a Mac, who also did not realize the website had any content!
Is there a way I can control this? Can the collapse be disabled completely? Though, this is not ideal because it probably should collapse when viewed on a mobile phone.
In the navbar.html layout file I see a setting $maxVisibleSections, but I'm not sure if this is relevant (or how to set it in the config either).

HI @quantitative-technologies $maxVisibleSections has nothing to do with the navbar collapsing. The site is probably detecting the device as tablet. Can you please share your website link so that I can check if there is any other issues.

Hi @hossainemruz
Please notice that this also happens on the Toha example site when I use Windows Edge (it's running in a VM if that is relevant):

But Toha has 9 or 10 section headings...
Here is the link to my website.

Hi @quantitative-technologies, this is expected behavior. If the device width is less or equal to 1024px, then navbar goes into this mode. This is being handled by bootstrap framework itself.

Yes, the Windows VM is 1024x768. I'm surprised if that was the case for the Mac too.
So how can I change the expected behaviour? I looked through the navbar code, and I don't see any reference to bootstrap. There must be some way to disable the bootstrap for just the navbar, or am I mistaken?

If you inspect the code and check the CSS fornavbar-toggler button, you will see it is disabled only for screen >= 1200px. Maybe, you can overwrite this behavior by setting media query for the the navbar-toggler button and the respective menu list. You might need to use important (!) sign to overwrite the bootstrap behavior.


Adjusting the Padding of an Element

Challenge Name

https://www.freecodecamp.com/challenges/adjusting-the-padding-of-an-element#?solution=
<style>
  .injected-text {
    margin-bottom%3A -25px%3B
    text-align%3A center%3B
  }

  .box {
    border-style%3A solid%3B
    border-color%3A black%3B
    border-width%3A 5px%3B
    text-align%3A center%3B
  }

  .yellow-box {
    background-color%3A yellow%3B
    padding%3A 10px%3B
  }

  .red-box {
    background-color%3A red%3B
    padding%3A 20px%3B
  }

  .green-box {
    background-color%3A green%3B
    padding%3A 2px%3B
  }
<%2Fstyle>
<h5 class%3D"injected-text">margin<%2Fh5>

<div class%3D"box yellow-box">
  <h5 class%3D"box red-box">padding<%2Fh5>
  <h5 class%3D"box green-box">padding<%2Fh5>
<%2Fdiv>

Issue Description

The challenge saids "Your green-box class should give elements 20px of padding." When I change the padding of green-box in style element to 20px, I noticed the image of the green box on the bottom becomes smaller in size. I press Run Test and did not pass. I tried changing the px of the padding, but no matter if I increase the number or decrease the green box image stays small. I am operating on Chrome browser on my Samsung S6 phone. I then tried the challenge again on my Macbook, and it works. Weird. Definitely an issue with this challenge on my smart phone.
Browser Information

Browser Name, Version:
Operating System:
Mobile, Desktop, or Tablet:

Your Code

Screenshot

I would like to provide a screenshot, but how do I post it?

I don't know how they got there, but there are illegal whitespace characters in your CSS code (CSS is very particular about what whitespace characters are legal). If you reset your code and type the changes by hand you can be sure there will be no illegal characters.
Also, you can post screenshots by simply pasting or drag/dropping them into the Github text editor.
Closing as not an issue with the site. Thanks and happy coding!

Hi encountering almost similar. Green size is same with Red but won't pass.

Am also having the same issue....even after changing my green box to 20px

style>
.injected-text {
margin-bottom: -25px;
text-align: center;
}
.box {
border-style: solid;
border-color: black;
border-width: 5px;
text-align: center;
}
.yellow-box {
background-color: yellow;
   padding: 10px;
}
.red-box {
background-color: red;
   padding: 20px;
}
.green-box {
background-color: green;
   padding: 20px;
}

margin

padding
padding


Add comma

Someone forgot to put a comma in the JSON (thus, the webring doesn't work)

Ah, thanks for letting me know! Should’ve caught that lol 😂


logo contribution

Hello @B4nan .  I contribute to open source projects in my free time. You want me to design a logo for this repo? Actually, I have an idea. I can show you if you want. I will wait for feedback. Best regards.

Hello there! Sure you can, would be nice to have something, as there is no image and when sharing via FB it looks like an error:] I would probably stick to that colours I have in docs (blue/green).

Sure :) I designed a logotype. I used a single letter 'o' for a cleaner look. I combined the letter O with the icon representing the database. The readme and docs views are also available in the following image. What do you think?

Thanks, looks nice! I would try to align the icon, also what about applying similar gradient to the icon as I have in docs (maybe from top to bottom rather than from side to side). Also I would probably not mix those two colors like this (gradient moght be fine, idk). Black and blue variant looks nice, maybe darker blue?
I will experiment a bit myself tomorrow.

Oh ofcourse, i'll be looking forward to your selection of colors.

Could you please provide SVG code for this?

sure, here you are;
https://drive.google.com/open?id=1aEvbeUdTSIlWADKz8_4or96w0dWCIDpl

WDYT? A bit smaller db icon, color: #166788.

Also I would use smaller version in navbar (all white as you proposed) - here is 200x35px (which is fine for most cases, just the smallest devices needs tweaking - 320px wide).

Oh it looks fine! :) Is there anything you want from me?

It depends on if you want to become one of my very few collaborators and send a PR :] If you don't care, I will be happy to integrate this myself.
Anyway, thanks a lot!

Of course I will send a pr. Please contact me if you even need logo for other projects. Please check it :)
https://github.com/B4nan/mikro-orm/pull/44


Remove experimental CLI

See https://github.com/elastic/apm-aws-lambda/issues/293#issuecomment-1240451531 and proceeding comments.
Closes https://github.com/elastic/apm-aws-lambda/issues/293

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-09-09T03:32:44.467+0000

Duration: 8 min 53 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
160

Skipped
2

Total
162

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

any concerns from your side when removing the CLI?

Nope, no concerns. 👍


Remediation progress tracking

Is your feature request related to a problem? Please describe
Currently there is no way to track progress remediating a particular finding.  If a finding affects 10 endpoints and 9 are remediated, the finding remains open, and there is no way to report on the progress remediating the finding.  Similarly, if a finding affects two different areas of a single endpoint (e.g. CSS in two different fields), the finding remains open until all instances of the finding are fixed.
This presents challenges for communicating with developers when they think they've resolved the issue but have really only partially resolved it.  It also presents challenges for use in broader vulnerability management (scanning whole networks or network segments, as opposed to scanning just the servers supporting a particular product).
Describe the solution you'd like
As a vulnerability scanning program manager, I want a way to track the status of individual instances of a particular finding, so that progress can be tracked, and communication on outstanding items can be clear and concise.
Describe alternatives you've considered
The first option I considered was to break out vulnerability scanning into separate products and engagements, running separate scans for each, and importing the results from each area into DD.  However this quickly becomes unmanageable without additional automation (e.g. kicking off the scans from within DD and importing the results directly), and even then poses challenges for network discovery scans, where you don't know what product or environment a discovered endpoint will belong to.)
Another option is to change the key used to determine uniqueness of findings when importing from a scan tool.  For example, the Nessus importer looks at "severity + title" for deduplication, combining all affected endpoints into one DefectDojo finding.  If we change to "severity + title + endpoint", we'll have individual instances of each finding, but the findings list will also be flooded with what look like duplicates.
Ultimately I think the right solution is to add the concept of an "instance", and link findings to instances, and instances to endpoints.  Each instance should be able to have its own evidence, remediation status, notes, tags, user list (to indicate who is responsible for remediation) etc.
Additional context
The use case of vulnerability management may be a bit of a stretch for what DD was designed for.  Vulnerability management programs typically encompass multiple products and multiple product owners.

Hi @mossytrees, thank you for your detailed writeup. I've been thinking about this, and one way we may be able to address this is adding the notion of remediated endpoints. Do you think that would do enough to cover your use case?

@devGregA, sounds likely.  The main need I'm looking to fill is being able to track status of endpoints in relationship to findings.  So if a single finding has 10 endpoints associated, and we can mark each endpoint as remediated or not individually, and then be able to do some reporting/charting around that, I'd be happy :) . (Better yet if subsequent scan imports can be used to automatically mark endpoints as remediated if they don't show up on the latest scan results...)

I've added this as an issue for the interns I hired for summer. They start in about a month. Approximate ETA to completion 6 weeks. https://github.com/DefectDojo/django-DefectDojo/projects/7

Awesome!! 👍


Fix for typescript types on the Combobox and SetupAssistant component props

This adds types to the additional event parameters needed for the event props in these components so typescript doesn't fail when type checking. Also a typo fix for the disabled attribute in the options prop type in Combobox.
Fixes #2969

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[x] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[x] npm run lint:fix has been run and linting passes.
[x] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[x] Review the appropriate Storybook stories. Open http://localhost:9001/.
[x] Review tests are passing in the browser. Open http://localhost:8001/.
[x] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] CircleCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

bump. @interactivellama looking forward on a review to this! This would help us out a lot or anyone else that uses typescript in their projects with slds react.

Thanks @bolivierjr !