Swiper not updating offset without resize

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 5.3.8

Platform/Target and Browser Versions: all

Live Link or JSFiddle/Codepen or website with isssue: Stackblitz demo

What you did
I wanted to change the offset parameter after the initialization:
swiper.params.slidesOffsetBefore = -100;
swiper.update();

Expected Behavior
The swiper updates the offset properly.
Actual Behavior
The swiper isn't updating the slides until the window gets resized.

If free mode is disabled the swiper is working as intended.

probably related #3929

@harm-matthias-harms
I can't reproduce the issue
https://stackblitz.com/edit/swiper-demo-15-free-mode-no-fixed-positions-t3tnlf?file=index.html
Looks like it's working fine in this example, no?

@vltansky Yes, it seems to work with the latest version. I'm closing this issue. Thanks for checking.


Early exit with better error message when launching bst shell --build on some elements

See original issue on GitLab
In GitLab by [Gitlab user @cs-shadow] on Apr 16, 2019, 12:59
Summary
When trying to launch a build shell on element kinds like import, stack etc. BuildStream currently gives an error message like: Staged artifacts do not provide command 'sh'. This is not technically incorrect but I think we can do better. For example, since the import element can't have build dependencies (again, it technically can have them today but that's a separate bug), we know that any build shell on an import element is always going to fail with a similar error.
Similarly, stack element never stages anything in the sandbox, and as such, is also going to consistently fail.
It would be nice if BuildStream could report better error messages, something like: 'import' element does not allow build shell access.
Steps to reproduce
# Following steps we are running inside a fresh checkout of BuildStream repository

$ cd doc/examples/first-project
$ bst shell --build hello.bst

Error launching shell: Staged artifacts do not provide command 'sh'

Possible fixes
I can see broadly two ways to achieve this:

Add a new variable like BST_RUN_COMMANDS to Element() class and use that to determine if the plugin supports it.
Define a new method like shell() that the plugins can choose whether or not to implement, and not implementing it would raise a nice error.

In GitLab by [Gitlab user @tpollard] on May 15, 2019, 16:19
Could we not just query element kind at cli/stream time to check if it's going to later fail?

In GitLab by [Gitlab user @tmewett] on Aug 9, 2019, 16:26
BST_RUN_COMMANDS seems to have been already implemented for a different reason, which is nice. However, will this be clean enough? Likely I am wrong but it seems that if you try to start a runtime shell on a stack element, for example, that its dependencies could stage things themselves -- then it would be OK.

In GitLab by [Gitlab user @tristanvb] on Nov 5, 2020, 08:42

For example, since the import element can't have build dependencies ...  we know that any build shell on an import element is always going to fail with a similar error.

This is wildly incorrect, at the beginning of any full system build, we always require an import element which has a shell which will run on the host system.

Similarly, stack element never stages anything in the sandbox, and as such, is also going to consistently fail.

However it is plausible to shell into a stack, knowing that it has dependencies which provide a shell.
Last but not least, /bin/sh is only the default command to run when bst shell did not specify any, it is just as plausible that the user might want to run an interactive python interpretor in a bst shell where there is no /bin/sh, there is nothing wrong afaics with not having a /bin/sh unless you need one for some reason - and the only reason we want one here is to satisfy bst shell default parameter of launching an interactive shell.
I think we should just close this, and I think the current error is correct, while other suggested approaches are presumptuous.

In GitLab by [Gitlab user @cs-shadow] on Nov 5, 2020, 20:09

For example, since the import element can't have build dependencies ... we know that any build shell on an import element is always going to fail with a similar error.

This is wildly incorrect, at the beginning of any full system build, we always require an import element which has a shell which will run on the host system.

[Gitlab user @tristanvb] I'm not sure we're talking about the same thing. I'm not saying that whether or not the import element will provide a shell itself. I'm talking about opening a build shell (bst build --shell) on an import element. How would that work?
Usually we stage build-depends at / and the sources somewhere else. this case there would be no build-depends. So, if a shell has to work, it'd had to be a self-contained binary that doens't require anything else. Even if it did, our current implementation of import won't allow the sources to be staged correctly for a shell. So, if we want to support build shells on import elements for this case, we at least have some rewiring to do.

Similarly, stack element never stages anything in the sandbox, and as such, is also going to consistently fail.

However it is plausible to shell into a stack, knowing that it has dependencies which provide a shell.

Again, I'm talking build shells. stack element should not allow build-depends although it currently does (https://gitlab.com/BuildStream/buildstream/-/issues/1075). However, if we assume that #1075 is fixed and it doesn't allow build-depends, what will we stage in the build sandbox? As neither do we have any build-depends nor any sources.

In GitLab by [Gitlab user @tristanvb] on Nov 5, 2020, 20:37
First, sorry I didn’t notice the word “build” in there, it isn’t in the title and is easy to miss.
For build shells, this would make more sense, import elements normally only have sources (so no shell or any program which can be launched), and stack elements have no sources (so there could be nothing to build), these cases could be better handled by observing the BST_SOMETHING_ALLOWED_SOURCES_OR_SOMETHINGOROTHER flags which are a part of public api on elements.
We wouldn’t be able to support the semantic for import elements until we can fix them to not allow dependencies.

In GitLab by [Gitlab user @cs-shadow] on Nov 10, 2020, 00:09

First, sorry I didn’t notice the word “build” in there, it isn’t in the title and is easy to miss.

Yeah, that's easy to miss :) I'd be happy to stick the word build in the title. For background, I initially worded the issue intentionally a bit vaguely to leave the possiblity for disallowing shells in other circumstances, that I couldn't think of at the time. However, in both the examples (import and stack) that I know so far, it is only the build shell that problematic.

these cases could be better handled by observing the BST_SOMETHING_ALLOWED_SOURCES_OR_SOMETHINGOROTHER flags

I concur. (with a proper name of course)

We wouldn’t be able to support the semantic for import elements until we can fix them to not allow dependencies.

definitely

In GitLab by [Gitlab user @tristanvb] on Nov 10, 2020, 07:39
changed title from {-Provide better error messages when launching a shell is not possible-} to {+Early exit with better error message when launching bst shell --build on some elements+}


clear memory allocated for sampled data when constructing Dataset from text file

Sample data is useless after BinMapper is constructed, but the corresponding memory is still there before feature extraction is finished.

@xuchuanyin I hope you don't mind, I've proposed a re-wording of this pull request's title. Since pull request titles become items in this project's release notes, I've proposed a title that I think will be a bit easier to understand for users of LightGBM who aren't familiar with its internals.

@jameslamb yeah, the optimized title is much better

/gha run r-valgrind


Security patches and update to dependencies

This PR updates some of the dependencies but mostly tries to reduce the number of security alerts raised by npm audit
Before:
found 81 vulnerabilities (67 low, 12 moderate, 2 high)
After:
found 12 vulnerabilities (3 low, 8 moderate, 1 high)

You can preview this change here:
Built with commit 0f964bda3cac198d6ae4d49786cbcfab301042a1
https://deploy-preview-844--govuk-design-system-preview.netlify.com


Create new base images to use for pro product images

The r-docker/r-base images are very minimal and only install a singular version of R and a few core packages. This change adds new base images with and without the RStudio Pro Drivers included.These base images are very comprehensive compared to r-base and allow our actual professional product Dockerfiles to be slimmed down to only a few RUN statements used to install and configure the product itself.
This change adds or modifies the following:

Six new base image options:

base/ provides the base set of system dependencies, two versions of R, two versions of Python, tini, TInyTeX, and Quarto.
base/pro provides the same content as base/ but with the addition of the RStudio Pro Drivers.
Support for three OSes: Ubuntu 18.04 (re-stylized ubuntu1804), Ubuntu 22.04 (re-stylized ubuntu2204), and CentOS7.

I chose to change the stylization of the Ubuntu OS names, which previously used the release codename, to use the version number instead. Best practices from other organizations (such as Snyk) push towards using the version number instead of the codename since it's easier to comprehend. In the new style it's also much more obvious which OS is being used at a glance if the viewer is not familiar with Ubuntu's release names.

Professional product Dockerfile definitions using the new base images (i.e. connect/Dockerfile.ubuntu1804.draft).
A Justfile for the base images directory.
Goss tests for both the base and base/pro images.
A new job in build-latest.yaml to build the base images prior to building the professional products. This will allow us to begin building and testing the base images from the Github Workflow before we fully implement them into the product images.
Linting for all base image Dockerfiles.
New targets in ci.Justfile for building and testing the base images.

Remaining work once this change is merged:

Fully testing and implementing the base images into the pro product Dockerfiles.
Removing the content images since these new base images will likely take their place.

This change will not change the end user experience as we will not yet push any product images that use the new base images.

I'm still working on the CI, but I'm putting this up for review now to get feedback on the images themselves.

I used a separate text editor to try and make some responses for you here. Bear with me!

Haven't dug in super deep on this one yet. Although I definitely do appreciate the direction!
A couple of immediate questions/comments I have:
* Were the `content-base` and `content-pro` images considered for usage here? In spirit, definition, and practice these images seem to be a very close redevelopment of those images with some slight ordering / sysdep differences. I mentioned this [here](https://github.com/rstudio/rstudio-docker-products/issues/391#issuecomment-1256582714)

  * Sorry I missed your comment that these should replace the content images. Worth noting that the content images are used downstream / [referenced explicitly](https://github.com/rstudio/helm/blob/main/charts/rstudio-connect/default-runtime.yaml) by our Connect helm chart, customer infrastructure, etc. Is setting these images up as `base` a temporary naming convention? Or is the proposal to deprecate `content-base` as an image tag, and just go with `base` going forwards?

This is great feedback! I honestly wasn't aware that content base/pro were being used downstream for things. I do think that these changes should still replace the content images and here's my reasoning behind it:

The content images are not comprehensive (i.e. missing alt versions of R and Python, no tini, etc.)
We have a pattern to our other images. The content images do not match this pattern (content/base/bionic/Dockerfile vs connect/Dockerfile.bionic).

We can refactor the existing content directory and files, but I thought it was easier to just start from scratch.

  * I seem to recall some discussion for why `content-base` was chosen over `base` when we first built the `content` images. Maybe someone else will recall better than I can. Perhaps because we considered the "content" (no pun intended) of the images to be such that "content" could run. I.e. it is not a base image that you would use for installing R, etc. It is a base image that you would use for building some type of content (i.e. flask app, plumber API, Connect image, etc.). i.e. in contrast to [these base images](https://github.com/rstudio/r-docker/tree/main/base)

That explanation for the name makes more sense to me now, but admittedly I don't love it. I'd prefer using base as the name since content is less obvious.

* One noteworthy difference is one version of R/Python versus two. That seems like something that should not necessarily warrant two completely different dockerfiles / approaches though shrug

Including two versions was an attempt to satisfy the requirements that the product images set out as all of them use a primary and alt version. I'd lean towards including more instead of less in a base image. I agree that it doesn't warrant two Dockerfiles.

  * In contrast, a benefit of consistency here is that it would make it much easier for someone to build a different RSW/RSC/RSPM from a different base image by just tweaking the args to the product build
  * What are y'all's thoughts on the `content-base` image having one R / Python version, but these images having two?

* Is there a reason we changed from the codenames to version names? i.e. `bionic` to `ubuntu1804`?

I think using Ubuntu codenames is unhelpful to a lot of people less familiar with Linux. There are a lot of us that know the last 6 years of codenames off the top of our heads, but I know there's people that also need to google bionic to figure out which version that is. I think it's easier to use the OS's name and version number since that explicitly tells people that we're using Ubuntu 18.04 whereas Bionic only implies that. Tools like Snyk also push towards using explicit version numbers over code names so this change also satisfies those warnings.

* I also think it's worth noting the tagging convention in use for discussion

FROM rstudio/base-pro:ubuntu2204-r${R_VERSION}_${R_VERSION_ALT}-py${PYTHON_VERSION}_${PYTHON_VERSION_ALT}

* Recording some notes for the follow-up issues while they are front of mind.

  * One piece of this: the follow-up may be a good time to consider the pattern for including drivers in service images: whether we want to include them all the time, etc. They are awfully large, but in the spirit of our "kitchen sink" w/ lots of R, Python, etc., perhaps they are a good fit.

So here's my question: does anyone use a pro driver compatible product without the pro drivers? Since I'm still pretty new I'm not sure what kind of usage we see on that. Maybe we could control using the base or base-pro images for our pro product images with an ARG?

  * It will also be important to note any sysdep changes that _ultimately_ result inside of the product images. I presume care has been taken there, but it will be a tricky thing for someone to review smile

This is certainly something I struggled with when building the base images. Do we have any SSOT on product dependencies that we could leverage here?

* It's also worth noting the complexity this introduces for customers who are copying our code to build their own images (i.e. they cannot just "pull" images themselves), or to customers who are already doing that and will have to go through a refactor to change their build process

Yeah it's certainly a trade off we have to weigh. A more comprehensive base image is much easier for us to maintain, but may introduce some new difficulties if folks are making their own images. Really though you could just copy both the base image and the product image into the same file and have a decently easy time modifying them for your own purposes.

  * perhaps documentation for this change in NEWS / etc. can wait til the follow-up as well. Just wanted to note here
  * In this vein, is this something we should land as a part of the rebrand, since it will be a pretty sizable change? To be clear, I mean "switching to use the base images" and not necessarily this PR

Sounds like a good plan to me.

* Should we be introducing `rstudio.` labels at this point? I suspect we will have many many changes to make with the change to `posit`, but labels seem like one that this may be a good time to start off on the other foot stuck_out_tongue

Fair point! We could maybe include both for now and remove the rstudio.* ones later? Or we could just use posit from the start since by the time this gets used we should be well into the rebrand.

* One background point to highlight - we have a bit of an "open question" right now with respect to Quarto and how it will be versioned alongside R and Python. Right now you have a latent "one version of quarto without a tag referencing it" (i.e. version of quarto can float and is not an explicit dependency).

  * https://github.com/rstudio/rstudio-docker-products/blob/main/content/base/bionic/maybe_install_quarto.sh (we only install it into some base images at present)
  * #380
  * In one school of thought, there is the "let quarto float" approach and maybe some convention for bumping the version of quarto when we add new R / Pythons. In another, we could consider quarto a "top level" version and add it to the tag... which is already pretty long sweat_smile
  * For background, Connect treats Quarto more like R or Python. Further, the speed of development is partially a concern. i.e. what do we do when a new version of Quarto comes out that we want our containers to support out of the box, but no new R or Python has shipped. Do we introduce a breaking change? Do we bump quarto into the existing image tags and hope for the best but destabilize the image tags? etc.

Hmm that's much less straightforward than I had assumed. I'll give this some additional thought and circle back.

This is certainly something I struggled with when building the base images. Do we have any SSOT on product dependencies that we could leverage here?

Required product dependencies are typically spelled out within the DEB/RPM being installed for the product. For secondary/optional dependencies, I'm not sure how to get that information without digging into the development/Docker containers for product builds.

Thanks for your responses! One discussion point I think we should land on:

How many variations of this "base" image should there be? I.e. the content image currently has a huge matrix, because the images are meant to be a bit more surgical: https://github.com/rstudio/rstudio-docker-products/blob/main/content/matrix.json

And one other random point - the content images were actually consistent with everything until Daniel refactored things this summer. He did not tackle the content images, so they are still in the old world. I do think that base is too generic for an org-wide repository like rstudio or posit. Depending on the question above, it may be that we just want a product-base and product-pro image? tini is small, but it is an example of something that is needed for a "product" image, but not for a "content" image AFAIK.... or maybe we should start using tini or something like it in content image execution? 🤷

@colearendt I'll go through and update the content images quickly in a separate PR then so we can have those up to date.
Yeah I'm onboard with making these product-base since it's really serving that specific purpose. I'll rename stuff to match that.


Profile pictures for users not appearing on blogs, etc.

I've mentioned this before, but the profile pictures for users no longer appear on their profiles and now appear through a second image field that was not used before.

Anne Larson, for example, has an photo, which I included in her profile for a previous blog, but now it does not show up any more.
This is a serious bug and must be fix. The image fields must be reconciled, as now we have a fairly large group of users with a different primary image field that the majority of users. The longer this goes on the bigger the problem will get.

This is the picture that I previously uploaded and no longer appears on her profile. I had to upload another picture to this field under account:

this is strange,
here is what I get on her profile page:

Anyways, for this ticket and many other opened ones related to users and pictures I should have an update ready to publish by tomorrow to improve (a lot) the followings:

user profile page (this one)
the public profile snippet
the account forms

That’s because I just uploaded the new picture now because I needed to, as I published a new blog from her.

this is all re-done and cleaned. Visible on stage and will be pulled into production this morning.


We should have more metrics

We should first work on places like onBrokerStopped and such. It might be better to use Yammer metrics until the Kafka brokers move over to the Kafka Metrics in the client. We could also consider just writing these to Kafka directly.

It might even be good for the kafka scheduler to have its own topic that folks can configure so that information related can be consumed and produce. This would also help the scheduler know if the problem with a broker is wring to it vs another broker and/or another partition, etc.

Closing as outdated. From the moment this issue is opened, we have added few metrics.
For now a ticket about more concrete missing metrics should be created if required.


CNAME demo site to awesomeqr.js.org

https://github.com/js-org/dns.js.org

No one commented, closed.


Visibility on protected fields/methods in Azure Storage

Issues

[ ] Looking at the JavaDocs, BlobAsyncClientBase has protected fields which also have publicly visible getters.  We could reduce the public surface area by making these private.

Although we make use of azureBlobStorage in inheriting classes, it feels better to encapsulate this using a getter rather than having direct access to the field.

[ ] There are some methods that exist only to support cross-package support and we don't expect end users to use this (ie. getServiceVersion()). These should be removed from public API.

Alan may be able to help you look through the API list exposed in Storage and see what needs to be removed.

Possible solutions

Jonathan mentioned in the JDK, they have a helper pattern we may be able to leverage to avoid leaking implementation classes. For example, they have NodeHelper.java which allows them to access fields/methods in Node.java for implementation purposes, but they don't want to expose it as public API.
There is probably some way to pass in dependent variables/classes via dependency injection when creating the object so we don't have to have a getter on them.

Related to #5517
/cc @alzimmermsft @JonathanGiles @hemanttanwar

This API also needs to be moved: https://github.com/Azure/azure-sdk-for-java/pull/5911#discussion_r337286386

Working on this.

Do we expect users to call this? I was reading it in the java docs and couldn't understand why we need this in public view.
    /**
     * Resource Supplier for UploadFile
     *
     * @param filePath The path for the file
     * @return {@code AsynchronousFileChannel}
     * @throws UncheckedIOException an input output exception.
     */
    protected AsynchronousFileChannel uploadFileResourceSupplier(String filePath) {}

@amishra-dev I'm assigning this over to you to triage

Unfortunately this wasn't brought in before GA and would be a breaking change now.


Master to harmony branch, resolved conflicts, savegame compatibility fix

Highlights:

merged-in master,
resolved conflicts,
fixed savegame compatibility - now you can use savegame created on harmony branch(v11.0) with previous builds (<11.0) (thanks kvakvs)

Just a small PR then 🤣 How does this relate to PR #260 - does it replace it or is it part of it?

I assume it solves rebase conflict by reverse-merging the master, and also this savegame fix from the last night. It is not easy to review though, essentially reviewing stuff that happened since March.

As you can see it's PR to #260 PR :) Then we can merge #260  to master

I assume we're ignoring inconsistent using placement until everything is merged?

I assume we're ignoring inconsistent using placement until everything is merged?

Isn't that change in #419 ?

I will do multiple passes over the remaining files later, to make them more or less StyleCop compliant and to clean up remaining tabified files. Not everything at once.

Stuff I've looked at so far seems good. I'll do some more checking later this evening, particularly around stuff like mod compatibility checker.


Build fix 689

PR Checklist:

[x] Link to related issues: #698
[ ] Add changelog entry linking to issue, describe API changes
[ ] Add tests (optional)
[ ] (If new feature) add to description / readme

Running into a missing OUT_DIR env. See this issue.


Update School Domain list

Add Daejeon Daeshin High School Domain

@happycastle114 Pull request merged. Thank you!


Why Generation and  Keyset?

I have read the source, and I'm confused that why to store Generation and  Keyset?
1.Is there any condition to make serverGeneration and CacheNamespace.GetGeneration inconsistent?
2.When put a NH entity to redis, the put method also put it's cacheKey to a redis set, but it is never using again. Why?

Yes, the generation can be increased when Clear() is called or if someone poked around Redis and deleted the cache keys (including the generation key). This means that an O(1) operation to clear the cache can be achieved by clearing the generation and having the next requests to the cache see that the generation is out of date.
The key it is put into a set so that they can be enumerated upon (for example by another tool). Otherwise, you'd have to use a KEYS command on your whole database in Redis just to find the matching NHibernate keys (really bad performance). For some of my applications, we expose the set in a UI so that we know what items are cached for the current generation.

The keyset will occupy many redis's memory, and the memory is precious especially in production environment. So there should be a switch to close that feature.

The set only stores the key name (and it's serialized/compressed internally by Redis). I have several production instances where the large (> 100) cache key sets take up about 10KB of total memory. That shouldn't be much of a concern if you're worried about memory since your using this cache. If anything, you should be concerned about the cached values and how they're serialized to optimize for space.


Cell IDs are still injected when setting Lifecycle Identity to None

In my settings:

But when I open and run some cells in my runbook, it still injects {"id":"etc"} into my runbook.
It does not however (as expected) inject a Runme header at the top of the file. So the option seems to half work.
I restarted VS Code, and can confirm the setting persisted, but the result is as described.

I also noticed that when I remove the Runme header, it prevents the runbook output from being saved locally.

Thanks for reporting the issue @mt-ronkorving. Taking a look into this today. It should not write any IDs, not even cells when set to None.
Currently writing the runbook output requires the document-level lifecycle ID. From what I'm gathering you would like this feature to work even if lifecycle identity is set to None? I believe we should be able to "fix" that. Can confirm, please, @mt-ronkorving? I can spin off a separate ticket for it.

@mt-ronkorving we just shipped v3.3.1712245402 into pre-release which you can test drive this way:

The fix will likely go into v3.3.2 (stable) in the next few days. Also, we tweaked our integration test suite which had a blind spot for turning off lifecycle identity. Sorry about that!
Also spun off https://github.com/stateful/vscode-runme/issues/1255 as a separate issue.

Thanks so much :) I'll be following #1255 👍

No worries, I'm not blocked 👍
Thanks for caring :)

No worries, I'm not blocked 👍 Thanks for caring :)

Of course! Closing this issue as solved.


fix : HOME variable in dockerfile of uc-server

Description of changes
Modified line 2 of the server's Dockerfile, fixing the HOME variable in the file.
This PR fixes issue #755.

LGTM

@dennyglee Please approve 🙏


Component props inheritance should be shown on the right side next to props list

Description
I think component props inheritance should be shown on the right side next to props list e.g.
What is the problem?
The TouchableHighlight inherits props from TouchableWithoutFeedback but there is no information in the docs right side (https://reactnative.dev/docs/touchablehighlight) that it's inherited, the new learner has to scroll down to get know about this which isn't obvious.
How can we address it?
By adding a information about inheritance. Maybe like in the picture?

Why is it important?
I think it's important for new learners like me because they could find something faster. I spent ~10 minutes thinking about why example shows onPress prop and there is nothing like this in the props list, till I scrolled down and finally there was the information about inheritance
Who needs this?
I think the new learners mostly
When should this happen (use version numbers if needed)?
I used 0.63 docs version

Hi @SurmaAa,
the inherited props are already visible in the next version docs. The changes has been implemented in #2168. Hope this improves the readability and fixes the issue you are mentioning.
Note: In the previous version of websites clicking on the link in ToC was redirecting users strait to the parent components page, where in new version Toc links scroll to the section where link to the parent component props is located. This has been reported to the Docusaurus and will be fixed in the future.
Refs: #2190

Thanks, cool


step3 rlhf traning: RuntimeError: torch.cat(): expected a non-empty list of Tensors

Train RLHF- phase， encountered error：
Traceback (most recent call last):
  File "applications/DeepSpeed-Chat/training/step3_rlhf_finetuning/main.py", line 586, in <module>
    main()
  File "applications/DeepSpeed-Chat/training/step3_rlhf_finetuning/main.py", line 469, in main
    out = trainer.generate_experience(batch_prompt['prompt'],
  File "/applications/DeepSpeed-Chat/training/step3_rlhf_finetuning/ppo_trainer.py", line 119, in generate_experience
    seq = self._generate_sequence(prompts, mask, step)
  File "applications/DeepSpeed-Chat/training/step3_rlhf_finetuning/ppo_trainer.py", line 113, in _generate_sequence
    out_seq = torch.cat(out_seq, dim=0)  # concate output in the batch dim
RuntimeError: torch.cat(): expected a non-empty list of Tensors

Using A100 cuda=11.8, torch=2.0.0， python=3.10.12, deepspeed=0.10.0, transformers=4.30.2
training script config:
ACTOR_ZERO_STAGE=2
CRITIC_ZERO_STAGE=3
ACTOR_MODEL_PATH=../step1_supervised_finetuning/output_opt6.7b
CRITIC_MODEL_PATH=../step2_reward_model_finetuning/output_opt125m

it seems out_seq is None, you can check out_seq

@JackHenry1992  me too, how to solve this error?


Unable to select text properly when Blink Cursor option is enabled

When Blink Cursor option is enabled in the settings, unable to select the text in the terminal properly.

I was able to select text in the terminal. But if the text is inside a frame then it quickly became unselected.

Fixed in 0.49.1.


Ensure deletion logic is handled when deletion timestamp is set

When a deletion timestamp is set, we expect that the normal reconcile logic will be skipped. This forks the logic into a reconcileDelete function at the beginning. I've also added a couple of tests which outline what we are expecting from the deletion logic.

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-disruptive
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-aws-upgrade
This isn't in payload yet, and even if it were, there's nothing actually being deployed, this code isn't running in the E2E yet


Add HTTP & S3 Handlers

Hi Thomas,
I added S3 and HTTP handlers to osio.
Have not tested them yet in real application scenarios, but I was thinking you could give early feedbacks if needed.
Only question I have is related to the copyright for the new files? Should i add my company?
Thomas

Pull Request Test Coverage Report for Build 985594321

77 of 114 (67.54%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-6.04%) to 90.681%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

s3.go
36
49
73.47%

http.go
28
52
53.85%

Totals

Change from base Build 816963526:
-6.04%

Covered Lines:
506

Relevant Lines:
558

💛  - Coveralls

please also update README

@thomascoquet is this PR ready for merge?

Hi Thomas, I had to add HEAD requests to get file size. If you're okay with that, we can merge.


OOM - Process killed by CI when fetching artifacts

When running the FetchArtifacts step, the process is occasionally killed by CircleCI. I think it's possibly because the files are not being streamed to disk, but are held in memory first.

There must be another reason. Flank doesn't hold file artifacts in memory, it uses downloadTo function from class com.google.cloud.storage.Blob which under the hood writes gclouds Blobs to files directly via OutputStream

I've used Files.readAllBytes(data) throughout the codebase, maybe that should change? Doodla is running on low memory VMs.

I've used Files.readAllBytes(data) throughout the codebase, maybe that should change? Doodla is running on low memory VMs.

Right that could be a problem. I will try to fix that.

@doodla Could you share your yaml config and version of flank? It could be helpful.

I think we could probably replicate this on a very low memory linux virtual machine.

AndroidArgs
    gcloud:
      results-bucket: ***********-flank
      results-dir: null
      record-video: false
      timeout: 8m
      async: false
      client-details:
      network-profile: null
      results-history-name: null
      # Android gcloud
      app: /opt/workspace/scripts/app-us-prod-debug.apk
      test: /opt/workspace/scripts/app-us-prod-debug-androidTest.apk
      additional-apks:
      auto-google-login: false
      use-orchestrator: true
      directories-to-pull:
      other-files:
      performance-metrics: false
      num-uniform-shards: null
      test-runner-class: null
      test-targets:
        - annotation com.creditkarma.testing.ui.EspressoTest
      robo-directives:
      robo-script: null
      device:
        - model: Nexus4
          version: 21
          locale: en
          orientation: portrait
        - model: Nexus5
          version: 22
          locale: en
          orientation: portrait
        - model: Nexus7_clone_16_9
          version: 23
          locale: en
          orientation: portrait
        - model: Nexus5X
          version: 24
          locale: en
          orientation: portrait
        - model: Nexus5X
          version: 25
          locale: en
          orientation: portrait
        - model: NexusLowRes
          version: 26
          locale: en
          orientation: portrait
        - model: Nexus6P
          version: 27
          locale: en
          orientation: portrait
        - model: Pixel2
          version: 28
          locale: en
          orientation: portrait
        - model: Pixel2
          version: 29
          locale: en
          orientation: portrait
      num-flaky-test-attempts: 2

    flank:
      max-test-shards: 15
      shard-time: 100
      num-test-runs: 1
      smart-flank-gcs-path: gs://***********-android/test_timings.xml
      smart-flank-disable-upload: false
      files-to-download:
      test-targets-always-run:
      disable-sharding: false
      project: ***********
      local-result-dir: test-lab-results
      # Android Flank Yml
      keep-file-path: false
      additional-app-test-apks:
      run-timeout: -1
      legacy-junit-result: false
      ignore-failed-tests: false

Here's my config @jan-gogo . I used to be on a 1CPU 2GB ram circle VM where I saw issues. We're now on a 2CPU 4GB ram machine. Basically went from small to medium.


generate commit based on question difficulty

Current:
working commit - Created using LeetHub
Suggestions:
easy - created using LeetHub
medium - created using LeetHub
hard - created using LeetHub
Could be gitmoji commits too:
:feelsgood: easy - created using LeetHub
:rage1: medium - created using LeetHub
:godmode:   hard - created using LeetHub

reload your chrome extension because v.0.1.0 displays performance stats on commits (see image below).

Also, you can just look at the readme for difficulty level.
Therefore, i don't find this issue meaningful.


Listener not working properly on Configuration Change

Expected behavior
Greetings, It seems MultiplePermissionsListener doesn't work for the current activity on configuration change(android:configChanges="orientation|screenSize|keyboardHidden") that is on orientation change
Actual behavior
It seems that on rotation the Activity gets a different identifier hence the listener won't be able to run the given method on "report.areAllPermissionsGranted()".
The good thing is that the permissions are granted but the user will have to click the View again in order to run the method.
Steps to reproduce
On click of a given View, the onProfileImageClick method is called as specified below:
public interface PickerOptionListener{
void onTakeCameraSelected();
 void onChooseGallerySelected();}

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
      //Other Code}

  private void onProfileImageClick() {
       Dexter.withActivity(this).withPermissions(Manifest.permission.CAMERA, Manifest.permission.WRITE_EXTERNAL_STORAGE).withListener(new MultiplePermissionsListener() {
        @Override
        public void onPermissionsChecked(MultiplePermissionsReport report){
            if (report.areAllPermissionsGranted()){
                showImagePickerOptions();
            }
            if (report.isAnyPermissionPermanentlyDenied()) {
                showSettingsDialog();
            }
        }
        @Override
        public void onPermissionRationaleShouldBeShown(List<PermissionRequest> permissions, PermissionToken token) {
            token.continuePermissionRequest();
        }
    }).check();
}

private void showImagePickerOptions() {
          MainActivity.showImagePickerOptions(this, new MainActivity.PickerOptionListener() {
        @Override
        public void onTakeCameraSelected() {
            launchCameraIntent();
        }
        @Override
        public void onChooseGallerySelected() {
            launchGalleryIntent();
        }
    });
}

private void showSettingsDialog() {
    AlertDialog.Builder builder = new AlertDialog.Builder(MainActivity.this);
    builder.setTitle(getString(R.string.dialog_permission_title));
    builder.setMessage(getString(R.string.dialog_permission_message));
    builder.setPositiveButton(getString(R.string.go_to_settings), (dialog, which) -> {
        dialog.cancel();
        openSettings();
    });
    builder.setNegativeButton(getString(android.R.string.cancel), (dialog, which) -> dialog.cancel());
    builder.show();
}
 public static void showImagePickerOptions(Context context, MainActivity.PickerOptionListener listener){AlertDialog.Builder builder = new AlertDialog.Builder(context);
    builder.setTitle(context.getString(R.string.lbl_set_profile_photo));
    String[] photos = {context.getString(R.string.lbl_take_camera_picture), context.getString(R.string.lbl_choose_from_gallery)};
    builder.setItems(photos, (dialog, which) -> {
        switch (which) {
            case 0:
                listener.onTakeCameraSelected();
                break;
            case 1:
                listener.onChooseGallerySelected();
                break;
        }
    });
   Dialog myDialog = builder.create();
    myDialog.show();}

Version of the library
6.0.2

Hey @mshalomdave could you please try to update the library to the latest version? There are some fixes we introduced in the last releases that could fix the issue.

Hello @pedrovgs. Appreciate the response. I have done as you have suggested (V. 6.2.1) but unfortunately, it's still happening. Just to add in something to what I said above. This happens when I had clicked the View and in case of no permissions granted, the Permission Dialog Appears should I rotate the screen as I am granting the permissions then,(I believe the activity gets a different identifier) and then the granting of permissions may still proceed and will work well but won't be able to call the method not sure if it's because it doesn't recognize the current activity after rotation.

@pedrovgs could you please create a simple repository reproducing the issue? This would help us a lot with the fix.

Sorry for the delay in my response. I have created a Repository(https://github.com/mshalomdave/DexterRepo). So am clarifying on the issue:
This happens when I had clicked the View and in case of no permissions granted, the Permission Dialog Appears should I rotate the screen as I am granting the permissions then,(I believe the context gets a different identifier) and then the granting of permissions may still proceed and will work well but won't be able to call the method. Not sure if it's because it doesn't recognize the current context after rotation.
The good thing is that the permissions are granted but the user will have to click the View again in order to run the method.

@mshalomdave I'm running the code of the provided example and I don't see what's wrong. I'm afraid I don't understand where the issue is. Could you please a list of steps to reproduce the error in the sample provided and the expected behavior?

Faced with the same issue, onPermissionsChecked doesn't call after configuration change. I was able to reproduce the issue with provided sample by @mshalomdave
STR:

Click avatar icon(permissions dialog is showing)
Change screen orientation to landscape
Click 'Allow' button on permissions dialog
Click 'Allow' button on permissions dialog once more
AR: onPermissionsChecked didn't trigger
ER: onPermissionsChecked have triggered

Faced with the same issue, onPermissionsChecked doesn't call after configuration change. I was able to reproduce the issue with provided sample by @mshalomdave
STR:

Click avatar icon(permissions dialog is showing)
Change screen orientation to landscape
Click 'Allow' button on permissions dialog
Click 'Allow' button on permissions dialog once more
AR: onPermissionsChecked didn't trigger
ER: onPermissionsChecked have triggered

Apologies for the late response. What @ShandyukSergey  has said is exactly the issue

Apologies for the late response. What @ShandyukSergey  has said is exactly the issue

I'm afraid @mshalomdave this is a Dexter known issue we face due to the activity being recreated when the screen is rotated. If you don't mind we will keep reviewing the issue in #276


Document JSON::PullParser

I think more explicit / expressive errors for JSON::PullParser would benefit future developers.
Example code:
require "json"

temp_data = %q(
{"1":{"quest_rewards":"40;42","quest_exp": 0}}
)

struct Quest_Rewards
  def self.from_json(value : JSON::PullParser)
    #temp_value = value.read_string
    #temp_value.size > 0 ? temp_value.split(";").map &.to_i : Array(Int32).new
    value.read_string.size > 0 ? value.read_string.split(";").map &.to_i : Array(Int32).new
  end
end

class Quest_Schema
  JSON.mapping({
    quest_rewards:     {type: Array(Int32), converter: Quest_Rewards},
    quest_exp: Int32
  })
end

new_data = Hash(String, Quest_Schema).from_json(temp_data)

The exception is:

Unhandled exception: Invalid Int32: quest_exp (ArgumentError)

That threw me off! The real underlying issue with my example is read_string is being used twice. read_string calls read_next, thus advancing to the next key. I thought read_string could be used any number of times to get the value, did not know  it calls read_next.
If read_string is not supposed to be called twice in from_json, I think an exception for that would help a lot.

I don't think there is anything we could do here. read_string is supposed to be called as often as you need to read a string. If you do that wrong (i.e. call it too often) that simply means your converter is bugged. And honestly, the error message is pretty good.

I initially thought the error message was related to quest_exp.  But after making a reduced example, it doesn't seem related to quest_exp at all.

I think json pull parser lacks documentation (there's none). Maybe we can rename read to next? But for me reading is advancing the pull parser.

No, it's not related to the quest_exp mapping. It's an error in your converter and the stack trace should point you to the faulty location.

Maybe just adding a bit of documentation to read_string is the solution here

Looks like this can be closed due to https://github.com/crystal-lang/crystal/pull/9983, correct?

@coopergillan Thanks. It seems not everyone knows about "Fixes #N" 🤷


Kitties

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes

Alex Norell seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.


Columns for hidden/filtered resources still show up

We have a project where we store all resource data to a folder. However, we also have another subfolder with more specialized behavior that is implemented as a resource as well, in a custom behaviors folder:
status effects
├── burn.tres
├── common scripts
│   ├── EffectBehavior.cs
│   └── Effect.cs
├── custom behaviors
│   ├── BurnEffectBehavior.cs
│   ├── burn_effect_behavior.tres
│   ├── poison_effect_behavior.tres
│   └── PoisonEffectBehaviour.cs
├── parry.tres
└── poison.tres

The filter/process allows us to hide such resources from the view. However, the columns from such resources still show up, even though they're undefined for any of the other visible types:

Interestingly, editing of several resource types and these "empty cells" are a recent feature, glad to see more people needed it. I do plan on fixing this too!


Publishing docker images from master

Images are published on each commit to master. In the publishing step, docker images will be tagged with the git tag if there is one (as reported by travis) or otherwise will be tagged with the commit sha. Thus, images will never be pushed to an existing tag and will be immutable. See https://github.com/kubernetes-incubator/service-catalog/issues/504#issuecomment-286204441 for more detail on the tagging strategy.
Fixes #504
Fixes #488
I believe we should use this tagging strategy instead of that in #520. I also believe that we can close #525 (and hence, #331) with this PR. See https://github.com/kubernetes-incubator/service-catalog/pull/529#discussion_r105745994 for more details. Official Closes #1234 clauses are below so that when this PR is merged, those issues/PRs automatically close.
Closes #520
Closes #525
Closes #331

SGTM just need to resolve @pmorie's question about which registry to use

This should also push the image to a static tag name so people have a way to consistently pull the latest image based on master.  @arschles suggested the tag 'canary' so that 'latest' could be reserved for the latest release

@jwforres I'd like to avoid the latest tag completely - so that developers have to specify a tag in their helm charts, docker pull command, etc...

I'd like to avoid the latest tag completely - so that developers have to specify a tag in their helm charts, docker pull command, etc...

That's fine for contributors, but at some point (soon), we want to lower the bar for kicking the tires on this. @arschles was your intended use of canary that in the near term the chart can reference the canary images by default, but leave that overridable by developers?

yes. later on, we can have CI change the chart default tag info to the latest git-tagged release

@duglin I've created a quay.io organization for now, and I'd like to move forward with this PR on quay for now so that we're not blocked on GCR. I will create an issue for moving to GCR if this PR is merged. Thoughts?

I added the LGTM3 but not merging since there's an outstanding question to @duglin


[TextField] event handlers passed to InputLabelProps don't work

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Setting InputLabel event handlers for an outlined or filled labels doesn't not work.
Expected behavior 🤔
It should work like an event handler for standard label.
Steps to reproduce 🕹
https://codesandbox.io/s/formpropstextfields-material-demo-forked-1dwvd?file=/demo.tsx
Context 🔦
I want to render a Tooltip wrapped help icon on the label of the outlined input.

  Output from `npx @mui/envinfo` goes here.

Hi. Yes, InputLabelProps currently does not support event handlers passed to it.
Your workaround in the codesandbox, which is to pass a div element to label, seems perfectly fine.
However, sure, I think we can also support event handlers in InputLabelProps as I can't think of any downside from it.
@siriwatknp What do you think?

@ossan-engineer
Hi. We decided to enable pointer events for InputLabel elements with shrink=true. So, you will be able to use click event for shrunk labels but not for un-shrunk labels.
Please check out codesandbox.

@hbjORbj Cool! That makes sense perfectly. I appreciate your quick fix.


FileTarget - Mono2 runtime detection to skip using named archive-mutex

This change is

Current coverage is 82% (diff: 40%)

Merging #1844 into master will decrease coverage by <1%

@@             master      #1844   diff @@
==========================================
  Files           277        277
  Lines         18416      18425     +9
  Methods        2851       2852     +1
  Messages          0          0
  Branches       2116       2119     +3
==========================================
- Hits          15059      15057     -2
- Misses         2880       2889     +9
- Partials        477        479     +2

Powered by Codecov. Last update a14dc80...9ec29b6

👍

Great improvement!


fix(compiler-core): add codeframe into warn with use err.loc

Thanks for your review. I already change my code and commit it.


HADOOP-18645. Provide keytab file key name with ServiceStateException

util.ExitUtil - Exiting with status 1: org.apache.hadoop.service.ServiceStateException: java.io.IOException: Running in secure mode, but config doesn't have a keytab
1: org.apache.hadoop.service.ServiceStateException: java.io.IOException: Running in secure mode, but config doesn't have a keytab
  at org.apache.hadoop.util.ExitUtil.terminate(ExitUtil.java:264)
..
..

When multiple downstreamers use different configs to present the same keytab file, if one of the config key gets missing or overridden as part of config generators, it becomes bit confusing for operators to realize which config is missing for a particular service, especially when keytab file value is already present with different config.
It would be nice to report config key with the stacktrace error message.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
18m 22s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 21s

trunk passed

+1 :green_heart:
compile
25m 15s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
21m 53s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 58s

trunk passed

+1 :green_heart:
mvnsite
2m 28s

trunk passed

+1 :green_heart:
javadoc
1m 54s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 13s

trunk passed

+1 :green_heart:
shadedclient
23m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 33s

the patch passed

+1 :green_heart:
compile
24m 30s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
24m 30s

the patch passed

+1 :green_heart:
compile
21m 47s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
21m 47s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 53s

the patch passed

+1 :green_heart:
mvnsite
2m 28s

the patch passed

+1 :green_heart:
javadoc
1m 48s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 47s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 20s

the patch passed

+1 :green_heart:
shadedclient
24m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 23s

hadoop-common in the patch passed.

+1 :green_heart:
unit
21m  0s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

262m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5433/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5433

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 6df7b7e12a96 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3de09b884a0dad6609c425b7dc46e707935164b6

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5433/1/testReport/

Max. process+thread count
2426 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5433/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @virajjasani for your contribution.


option for disable slide-up-down

For example, in the desktop version i open menu on hover.
.menu {
    .sub-menu {
        display: none;
    }

    &:hover {
        .sub-menu {
            display: block;
        }
    }
}

But on the mobile version i use click to open menu via slide-up-down

    <slide-up-down :active="showed" class="sub-menu"></slide-up-down>

When user change screen resolution from desktop to mobile(rotate phone from landscape to portrait) and back it cause bug because slide-up-down set height:0px, cause it use el.scrollHeight, that equal to zero on display:none element
So we can use disabled option to remove unnecessary and buggy(height: 0px) styles and attrs on desktop version
<slide-up-down :disabled="isDesktop" :active="showed" :duration="150">
isDesktop = window.innerWidth >= 400

Hey! Thanks for the PR – but I'm afraid I will not accept it.
Putting this logic into this component may seem intuitive at first (that's probably why you did it! :D), but I think it is the wrong choice.
Imagine if you had an <Icon name="settings /> component, but on isDesktop, you don't want the Icon but also some text next to it. It would be weird to do <Icon name="settings" :showText="isDesktop" textToShow="Your Settings"> – I think this should be handled outside of the component.
So instead, I'd like to point you to https://vuejs.org/v2/guide/components.html#Dynamic-Components and advise you to do
<component
	:is="isDesktop ? 'div' : 'slide-up-down'"
	:active="showed"
	:duration="150"
>

I hope that helps!


Does TagUI support desktop application? - yes, some ways to copy, paste and click

So far I noticed TagUI supports web page operations, how about desktop applications, we may copy, paste and click.

Hi @evandeng2009 we can automate desktop applications with visual automation.
To copy and paste on windows, we can use:
keyboard [ctrl]c
keyboard [ctrl]v

you can also use the clipboard function to copy:
clipboard('some text')
keyboard [ctrl]v

on mac:
keyboard [cmd]c
keyboard [cmd]v

to click destop applications, you can save a snapshot of the button for example,

name this snapshot as windows_button.png, then do something like:
click windows_button.png

closing for time being until further inputs


Why a lot of (maybe all) d3d/d2d/dwrite APIs are marked as unsafe?

Probably duplication of (or somewhat related to) https://github.com/microsoft/windows-rs/issues/1506 and https://github.com/microsoft/windows-rs/issues/1782
Feel free to close this issue if this is a kind of duplicated one (but I'm asking in directX scope fwiw).
The unsafe is because those APIs are not thread-safe? (ID3D11Device should be thread-safe by default, ID3D11DeviceContext requires serialization though, and similar rule is applied to d2d depending on the way of construction time flags), or is there other concern?

Mostly the unsafe exists on non-WinRT APIs as we don't know how to reason about the safety of the calls themselves. I would like to relax this restriction as the blanket policy on all Win32 APIs is overly restrictive.
See this comment: https://github.com/microsoft/windows-rs/issues/1506#issuecomment-1050507750


Use official playwright-allure

experimental-allure-playwright is old and not maintained anymore. This is it's successor: https://www.npmjs.com/package/allure-playwright
So we recommend switching.

@mxschmitt : Thanks for suggestion I will fix this in next release.

Fixed in v1.0.0


Funnel returns TaskLog instead of ExecutorLog

Description
Trying the example on py-tes, version 0.4.0 with a local installation of the latest commit of Funnel (b906ba8) running on http://localhost:8000 results in a TypeError when calling cli.get_task(task_id), suggesting that the response provided by Funnel does not conform to TES specs.
This assumes that py-tes is basing its validation/unmarshalling on the latest version of the specs. At a cursory glance, it does. If it doesn't, the issue applies to py-tes instead.
Expected outcome
For the example call, .get_task(task_id) should return a response object corresponding to the TesTask model in the TES specification without throwing an error.
Actual outcome
First error in stack:
TypeError: ("'logs' must be a list of <class 'tes.models.ExecutorLog'> (got [TaskLog(start_time=datetime.datetime(2020, 7, 8, 21, 17, 36, 222942, tzinfo=tzoffset(None, 7200)), end_time=None, metadata=None, logs=None, outputs=None, system_logs=None)] that is a list of <class 'tes.models.TaskLog'>).", Attribute(name='logs', default=None, validator=<optional validator for _ListOfValidator(type=<class 'tes.models.ExecutorLog'>) or None>, repr=True, eq=True, order=True, hash=None, init=True, metadata=mappingproxy({}), type=None, converter=None, kw_only=False), <class 'tes.models.ExecutorLog'>, [TaskLog(start_time=datetime.datetime(2020, 7, 8, 21, 17, 36, 222942, tzinfo=tzoffset(None, 7200)), end_time=None, metadata=None, logs=None, outputs=None, system_logs=None)])

Entire traceback:
Traceback (most recent call last):
  File "/home/uniqueg/Software/miniconda3/envs/snakemake/lib/python3.6/site-packages/tes/utils.py", line 80, in unmarshal
    output = o(**r)
  File "<attrs generated init tes.models.TaskLog>", line 12, in __init__
  File "/home/uniqueg/Software/miniconda3/envs/snakemake/lib/python3.6/site-packages/attr/validators.py", line 191, in __call__
    self.validator(inst, attr, value)
  File "/home/uniqueg/Software/miniconda3/envs/snakemake/lib/python3.6/site-packages/tes/models.py", line 30, in __call__
    attr, self.type, value,
TypeError: ("'logs' must be a list of <class 'tes.models.ExecutorLog'> (got [TaskLog(start_time=datetime.datetime(2020, 7, 8, 21, 17, 36, 222942, tzinfo=tzoffset(None, 7200)), end_time=None, metadata=None, logs=None, outputs=None, system_logs=None)] that is a list of <class 'tes.models.TaskLog'>).", Attribute(name='logs', default=None, validator=<optional validator for _ListOfValidator(type=<class 'tes.models.ExecutorLog'>) or None>, repr=True, eq=True, order=True, hash=None, init=True, metadata=mappingproxy({}), type=None, converter=None, kw_only=False), <class 'tes.models.ExecutorLog'>, [TaskLog(start_time=datetime.datetime(2020, 7, 8, 21, 17, 36, 222942, tzinfo=tzoffset(None, 7200)), end_time=None, metadata=None, logs=None, outputs=None, system_logs=None)])

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/uniqueg/Software/miniconda3/envs/snakemake/lib/python3.6/site-packages/tes/utils.py", line 70, in unmarshal
    field = _unmarshal(v, obj)
  File "/home/uniqueg/Software/miniconda3/envs/snakemake/lib/python3.6/site-packages/tes/utils.py", line 58, in _unmarshal
    field.append(unmarshal(item, obj))
  File "/home/uniqueg/Software/miniconda3/envs/snakemake/lib/python3.6/site-packages/tes/utils.py", line 85, in unmarshal
    raise UnmarshalError(msg)
tes.utils.UnmarshalError: {'logs': [{'startTime': '2020-07-08T21:17:36.222942471+02:00'}], 'metadata': {'hostname': 'dell-7390'}, 'startTime': '2020-07-08T21:17:36.21283682+02:00'} could not be unmarshalled to type: TaskLog
TypeError: ("'logs' must be a list of <class 'tes.models.ExecutorLog'> (got [TaskLog(start_time=datetime.datetime(2020, 7, 8, 21, 17, 36, 222942, tzinfo=tzoffset(None, 7200)), end_time=None, metadata=None, logs=None, outputs=None, system_logs=None)] that is a list of <class 'tes.models.TaskLog'>).", Attribute(name='logs', default=None, validator=<optional validator for _ListOfValidator(type=<class 'tes.models.ExecutorLog'>) or None>, repr=True, eq=True, order=True, hash=None, init=True, metadata=mappingproxy({}), type=None, converter=None, kw_only=False), <class 'tes.models.ExecutorLog'>, [TaskLog(start_time=datetime.datetime(2020, 7, 8, 21, 17, 36, 222942, tzinfo=tzoffset(None, 7200)), end_time=None, metadata=None, logs=None, outputs=None, system_logs=None)])

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/uniqueg/Software/miniconda3/envs/snakemake/lib/python3.6/site-packages/tes/utils.py", line 80, in unmarshal
    output = o(**r)
TypeError: __init__() got an unexpected keyword argument 'logs'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/uniqueg/Software/miniconda3/envs/snakemake/lib/python3.6/site-packages/tes/client.py", line 75, in get_task
    return unmarshal(response.json(), Task)
  File "/home/uniqueg/Software/miniconda3/envs/snakemake/lib/python3.6/site-packages/tes/utils.py", line 73, in unmarshal
    field = _unmarshal(v, obj)
  File "/home/uniqueg/Software/miniconda3/envs/snakemake/lib/python3.6/site-packages/tes/utils.py", line 58, in _unmarshal
    field.append(unmarshal(item, obj))
  File "/home/uniqueg/Software/miniconda3/envs/snakemake/lib/python3.6/site-packages/tes/utils.py", line 85, in unmarshal
    raise UnmarshalError(msg)
tes.utils.UnmarshalError: {'logs': [{'startTime': '2020-07-08T21:17:36.222942471+02:00'}], 'metadata': {'hostname': 'dell-7390'}, 'startTime': '2020-07-08T21:17:36.21283682+02:00'} could not be unmarshalled to type: ExecutorLog
TypeError: __init__() got an unexpected keyword argument 'logs'

Steps to reproduce
Start Funnel:
funnel server run

Send task and check status:
import tes

task = tes.Task(
    executors=[
        tes.Executor(
            image="alpine",
            command=["echo", "hello"]
        )
    ]
)

cli = tes.HTTPClient("http://localhost:8000")
task_id = cli.create_task(task)
res = cli.get_task(task_id)  # Here the error occurs

Note that the error does not occur if view='MINIMAL' is passed to .get_task(); only views BASIC and FULL cause the error to be raised.
Environment

Ubuntu 20.04
Funnel; installed from commit b906ba8 as per instructions
py-tes v0.4.0; installed via pip

This may be related to an issue py-tes was having is misidentifying message types
Can you see if https://github.com/ohsu-comp-bio/py-tes/pull/29 helps?

Thanks a lot Kyle, I'll have a look and report back.

Can confirm that https://github.com/ohsu-comp-bio/py-tes/pull/29 fixes this issue.

Thank you for the report. I'll work on getting that PR merged and pushed into a new PyPI release


Need Tests for Core-Command Name-based endpoints

Please see the following issue for context https://github.com/edgexfoundry/edgex-go/issues/1223
We'll need tests to support these new endpoints whereby commands can be fetched by their name, as well as a list of commands for a given device by the device name.
@difince @cloudxxx8 for visibility

@FelixTing please help take care of this one when you have time


Content type lookup with lowercased key

To address issue #129

This looks great.  Thanks for the quick turnaround on it.

@hadrien - any chance this will get added and released this week?  I don't mean to pressure I'd just like to fix my app so I can deploy it.

@chrisgilmerproj I am not a part of aws so I cannot give you any detail, I do not have merging permission: Actually, I need that fix too :-)
@jamesls Whenever you have the time to give feedback, it will be super appreciated, thanks!

Oh! Interesting.  Well I appreciate the work @hadrien - thank you very much for your time on this.  It's going to be a big help for me and I hope others as well.

Thanks for the pull request.  In general I think this is a good change to add, the only problem I see is that this line:
self.headers = {k.lower(): v for k, v in headers.items()}

means that anyone previously relying on upper/title cased header names will now be broken.  Given the preview status of this project, this is still ok, but I wonder if it makes more sense to just have a case insensitive dictionary used for headers instead.
Thoughts?

@jamesls Totally agree, I was being lazy in the first place.
Please give me feedback on my last commit.
When/If PR is approved, should I squash commits to make a cleaner history?

No need to squash, I'll go ahead and merge.  Thanks for updating.

Quick update, I had to make a couple of small changes to this.  I want to preserve the property that app.current_request.to_dict() will always return JSON serializable data so I made a small update to the to_dict() method.
I wasn't able to dict(request['headers']) so I updated the code to subclass from collections.Mapping to make this possible.  Otherwise everything else is unchanged.
I also added a few tests to catch this in the future (the fact that to_dict() is json serializable).

Rebased/merged in https://github.com/awslabs/chalice/commit/d69a2481a918f01a3926ea224e42f6e9f02faf6b


Update integrating-web-apps.md

Here are some suggestions from talking with the team. Will discuss more today.

Docs Build status updates of commit 39ebffa:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/samples/integrating-web-apps.md
:warning:Warning
View
Details

msteams-platform/samples/integrating-web-apps.md

Line 70, Column 0: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/bots/how-to/get-teams-context?tabs=dotnet' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 70, Column 0: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/tabs/how-to/access-teams-context' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 110, Column 0: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/bots/how-to/get-teams-context?tabs=dotnet' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 110, Column 0: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/tabs/how-to/access-teams-context' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 128, Column 0: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/bots/how-to/get-teams-context?tabs=dotnet#fetching-the-roster-or-user-profile' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 128, Column 0: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/bots/how-to/conversations/subscribe-to-conversation-events?tabs=dotnet' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Include @nx/devkit as a dependency

This plugin doesn't have an Nx version listed in the Nx Plugin Registry because the plugin doesn't include @nx/devkit as a dependency.  Could you please release a version that fixes that?
Thanks,
Isaac (Nx Team)

@isaacplmann thanks for reaching out. I assuming you want to see the @nx/devkit package explicitly here?
Two things:

My plugin does depend on @nx/devkit  here but when I build using the tsc executor, the dependency is not added automatically to the built package.json.
Can the plugin registry logic perform a "npm view package-name" or something to check built dependencies? Id rather not maintain that version explicitly in the lib's package.json and let nx migrations update the root and have the tsc executor add that dependency for me.


Make statement import async

Importing statements is going to take multiple seconds, especially for larger imports or for users who have lots of categorization rules (or if the categorization implementation is slow).
Update the import statement controller to start a separate goroutine to handle the actual import, and send the user to the import submissions summary page.

going to push this out to a future release, assuming that imports continue to be reasonably performant after implementing categorization feature


v1.7 backports 2020-03-04

v1.7 backports 2020-03-04

#10366 -- fqdn: DNS proxy compresses DNS responses (@raybejjani)
#10397 -- daemon: create directory with correct permissions in prepareEndpointDirs (@tklauser)
#10415 -- kubernetes: do not disable node routes for portmap (@aanm)
#10414 -- daemon: fix cilium-agent helper message for disable-cnp-status-updates (@aanm)
#10428 -- docs: fix inconsistent ipv6 usage in getting started docker docs (@fristonio)
#10416 -- Fix dead link in 1.4->1.5 upgrade documentation (@Ropes)
#10434 -- Envoy: Apply CVE fixes 2020-03-03 (@jrajahalme)

Once this PR is merged, you can update the PR labels via:
$ for pr in 10366 10397 10415 10414 10428 10416 10434; do contrib/backporting/set-labels.py $pr done 1.7; done

This change is

never-tell-me-the-odds

Seems like we hit another variant of an old test issue #4612. Retrying.

test-me-please

test-missed-k8s

It looks like all the cherry-picked commits have
Signed-off-by: vagrant <vagrant@runtime1>

I assume this should be @jrajahalme's sign-off instead?

It looks like all the cherry-picked commits have
Signed-off-by: vagrant <vagrant@runtime1>

I assume this should be @jrajahalme's sign-off instead?

Good catch!

Fixed signoffs.

never-tell-me-the-odds


chore: Update CI for Django 4.2 Python 3.12 support

Removed Python 3.12 and Django 4.2 items from the matrix, as Django 4.2.8 now supports Python 3.12 (as per https://github.com/django/django/commit/9afeb6b9b6d4e025306c918e7e717288049cbdfd)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.683%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
3364

Relevant Lines:
3751

💛  - Coveralls


no need both iOSLink and AndroidLink

motivation
if users showcase data only have linkAppStore or linkPlayStore , not both. They will be render as a not link block. like D.I.T. or 烘焙帮
Test plan
Befor:

After:

By analyzing the blame information on this pull request, we identified @brentvatne and @manonthemat to be potential reviewers.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


Update pyoo.py

Add read only option to open_spreadsheet()

Merged, thank you tsingletonacic for your contribution.


Safari cannot open the page because the address is invalid Question

Description:
Hi,
I try to get authorize from dropbox. I can reach the login page but when I try to allow the access to its own folder and inside to my dropbox, there is an error show up "Safari cannot open the page because the address is invalid".
Sorry I am a new coder I still not familier with xcode. My friend told me that token need a server? But I saw the demo seems not need it. Sorry I try to read the readme.md, and I cannot full understand it. It will be very appreciated that you can help me.
Thanks
 func doOAuthDropbox(){

        let oauthswift = OAuth2Swift(consumerKey: my.consumerKey,
                                     consumerSecret: my.consumerSecret,
                                     authorizeUrl: "https://www.dropbox.com/oauth2/authorize",
                                     accessTokenUrl: "https://api.dropbox.com/1/oauth2/token",
                                     responseType: "token")

        self.oauthswift = oauthswift

        oauthswift.authorizeURLHandler = SafariURLHandler(viewController: self, oauthSwift: oauthswift)

        let _ = oauthswift.authorize(withCallbackURL: URL(string: "FTPtester://oauth-callback/dropbox")!,
                            scope: "", state:"DROPBOX",
                            success: { credential, response, parameters in

                                print(credential.oauthToken)
                                print(parameters)
                                // TODO: Save credential in keychain
                                // TODO: Create Dropbox provider using urlcredential
        }, failure: { error in
            print(error.localizedDescription)
        }
        )

OAuth Provider? (Twitter, Github, ..):
OAuth Version:

[ ] Version 1
[x ] Version 2

OS (Please fill the version) :

[x] iOS :
[ ] OSX :
[ ] TVOS :
[ ] WatchOS  :

Installation method:

[ ] Carthage
[x] CocoaPods
[ ] Manually

Library version:

[ ] head
[x ] v1.2.2
[ ] v1.2 (Swift 4.0)
[ ] v1.0.0
[ ] v0.6
[ ] other: (Please fill in the version you are using.)

Xcode version:

[x ] 9.4

[ ] 9.0 (Swift 4.0)

[ ] 9.0 (Swift 3.2)

[ ] 8.x (Swift 3.x)

[ ] 8.0 (Swift 2.3)

[ ] 7.3.1

[ ] other: (Please fill in the version you are using.)

[ ] objective c

The server is the provider, so for you Dropbox
You must debug to see what happens
Mais be you did not registered FTPTester url scheme in your project

Thanks solve the problem

What is the application name here?
Is'nt it my custom url scheme like: myapp://bla-bla?


[W6.1d][W13-B1]Tao Jiashu

Hi Tao Jiashu, I see that you have grabbed the concept of polymorphism. As a mandatory LO, I suggest you implement the interface, as well as other remaining LOs: JavaFX, NFR, Usecases.


Add book "Learn JavaScript" by Suman Kumar

What does this PR do?
Add resource(s)
For resources
Description
Added an amazing JavaScript book translated in six languages by Suman Kumar.
Why is this valuable (or not)?
I really found this book helpful for learning JavaScript.
How do we know it's really free?
The book is not only open source but also available in HTML and PDF forms on the authors website.
For book lists, is it a book? For course lists, is it a course? etc.
This is a book.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Thanks, and welcome to free-programming-books!


Typo in the "Step-by-step guide to writing an institutional profile" section

Describe the problem
Typos on the Step-by-step guide to writing an institutional profile section

[x] require your to specify should be require you to specify

The file to update is here.

Typo is solved and branch with the patch merged to master branch

@ctuni , good work!
Just a suggestion for future work, it's a best practice to link the Pull-Request with the associate issue.

@abhi18av thanks for the suggestion! I thought I had done it by commenting the issue on the PR comments but clearly I did not do it correcly. Do you know what have I misses? Thank you!

No problem @ctuni , you could make use of the "Development" section on the right hand panel to link the relevant PR.


I never recompiles ... always 'success' no matter what code changes ...

It watches nothing and gives out no error message, except for only one at the editor:  "This block has encountered an error and cannot be previewed"
It just doesn't work!

That's not a bug report


Firebase Messaging sdk deletes my icon on Unity 5.5.0f3 Android

I integrated the firebase messaging sdk to my game for android project. After that I made a build but there is no app icon. There was a bug and it deleted my icon after build.

Yep, we're aware of the issue and have staged a fix for the next release.
For the moment you can modify the Android Manifest
(Plugins/Android/AndroidManifest.xml) we provide by replacing it with the
attached one.
Cheers,
Stewart
On Sun, Dec 4, 2016 at 4:58 AM, Ömer<EMAIL_ADDRESS>wrote:

I integrated the firebase messaging sdk to my game for android project.
After that I made a build but there is no app icon. There was a bug and it
deleted my icon after build.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/firebase/quickstart-unity/issues/20, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AFw1RI8LNFW1d2ilIEcOrQBeSBAYBzgDks5rErjcgaJpZM4LDk_Q
.

I'm pleased to announce that we released:

Firebase C++ SDK 2.1.0 (release notes here, download here)
Firebase Unity SDK 1.1.0 (release notes here, download here)

I believe this should resolve your issue.  If not, please let us know and we'll take a look.
Cheers,
Stewart

@stewartmiles yeah.Thank you for having solved the two issues.Now I have found the other issue that I can't receive the fcm push notification when EXIT the game,only receive fcm push notification when the unity app is active.

See https://github.com/firebase/quickstart-unity/issues/25
On Mon, Dec 12, 2016 at 12:18 AM, BuKuSiShen<EMAIL_ADDRESS>wrote:

@stewartmiles https://github.com/stewartmiles yeah.Thank you for having
solved the two issues.Now I have found the other issue that I can't receive
the fcm push notification when EXIT the game,only receive fcm push
notification when the unity app is active.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/firebase/quickstart-unity/issues/20#issuecomment-266367861,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFw1ROCgWgFcMXlm8n7u543k_vae3C-8ks5rHQNvgaJpZM4LDk_Q
.


pod setup and example project

Initial pod setup
Example project with kaltura player and ima ads

This looks good, though I'm not so sure about the launch splash screen images since they refer to Get /video which is a bit confusing here. Could we just make these a solid color instead

If I remove the images then I think we get just plain white. is that ok?


FLAC support for Sonos?

No matter what I’ve tried, FLAC doesn’t work on Sonos. This isn’t really an issue but I do feel if you can find a workaround it can help lower the latency and bring native 24 bit support as .wav gets downscaled to 16 bit with Sonos speakers.

The problem is that I don't have Sonos, so I can't test/debug this issue to try and find a solution...

Sonos does not support flac over dlna, so I am closing this.


Mapy.cz service - short URLs doesn't work

Short mapy.cz URLs are detected, but not converted to location. It seems like server-side change, where if short URL is requested, long URL is not returned
If code setCurlOption(CURLOPT_NOBODY, true) is removed, then it is working as it should but it is returning extra data, which are not necessary, thus wasted resources on downloading body.

Closing due to inactivity - temporary solution works good enough.


Performance issues when Compiling in a VSPackage/Visual Studio Extension

Hi,
Thank you for developing RazorEngine, we've been using it successfully in a standalone application.
However, we want to use it inside a VSPackage (Visual Studio Extension). We use the exact same code we've been using in our standalone application and it works, but the performance is horrible.
It takes exactly 30 seconds every time we compile a template, since we will be using a lot of templates this quickly adds up to a very long time. Because it takes exactly 30 seconds every time, we have a feeling it might have something to do with the RazorEngine trying to do something and then giving up after a timeout (Maybe trying to cache something?).
No exceptions are thrown and the template is successfully compiled.
We use the following code:
for setup:
var config = new TemplateServiceConfiguration();
config.Language = Language.CSharp;
config.EncodedStringFactory = new RawStringFactory();

\\We also tried it with the following two lines enabled
\\config.CachingProvider = new DefaultCachingProvider(t => { });
\\config.DisableTempFileLocking = true;

var service = RazorEngineService.Create(config);
Engine.Razor = service;

And for actually compiling:
Engine.Razor.AddTemplate(cacheName, new LoadedTemplateSource(data, cacheName));
Engine.Razor.Compile(cacheName, typeof(RazorModel));

Is this a known issue and if so, does anyone know how to resolve this?
Thanks in advance.

If you already tried with the cleanup logic disabled and in-memory templates I can only assume its because of the CodeDom compiler? Can you maybe try out the Roslyn Compiler (RazorEngine.Roslyn nuget package)?
Is the template properly cached (and fast the second time it's used?)?
Default caching is in-memory only so I'm not sure why it should take 30 seconds...
Can you get a stacktrace where the program is within the wait time? Did you try profiling?
Hope this provides some points to further track this down...

I think this issue was previously caused by RazorEngine trying to reference
all the assemblies that VS also referenced while compiling the template.
I think you can now create a custom assembly resolver to restrict the
assemblies that are referenced and this should bring the compile time down.
On Tuesday, 2 June 2015, EvdHeide<EMAIL_ADDRESS>wrote:

Hi,
Thank you for developing RazorEngine, we've been using it successfully in
a standalone application.
However, we want to use it inside a VSPackage (Visual Studio Extension).
We use the exact same code we've been using in our standalone application
and it works, but the performance is horrible.
It takes exactly 30 seconds every time we compile a template, since we
will be using a lot of templates this quickly adds up to a very long time.
Because it takes exactly 30 seconds every time, we have a feeling it might
have something to do with the RazorEngine trying to do something and then
giving up after a timeout (Maybe trying to cache something?).
No exceptions are thrown and the template is successfully compiled.
We use the following code:
for setup:
var config = new TemplateServiceConfiguration();
config.Language = Language.CSharp;
config.EncodedStringFactory = new RawStringFactory();
\We also tried it with the following two lines enabled
\config.CachingProvider = new DefaultCachingProvider(t => { });
\config.DisableTempFileLocking = true;
var service = RazorEngineService.Create(config);
Engine.Razor = service;
And for actually compiling:
Engine.Razor.AddTemplate(cacheName, new LoadedTemplateSource(data, cacheName));
Engine.Razor.Compile(cacheName, typeof(RazorModel));
Is this a known issue and if so, does anyone know how to resolve this?
Thanks in advance.
—
Reply to this email directly or view it on GitHub
https://github.com/Antaris/RazorEngine/issues/286.

Thank you both for the quick reply.
Loading the required assemblies as proposed by coxp solved our problems.
This brought the compile time down to under a second per template.


Higher level API

I think we should consider adding some more abstraction on top of HAP-NodeJS for ease of development. I think this project could be a good starting point for design. Using chaining with getters, setters, and event emitters would greatly reduce the amount of code required to create an accessory. It also reduces the HomeKit specific knowledge required for a new developer to start contributing to the project. We might also want to consider some higher level accessory base classes such as Light, Switch, Lock, Door, Alarm, Sensor, etc. which provide defaults and create characteristics based on what parts of the interface the developer chooses to implement.
Here is an example of a potential interface using EventEmitters with callbacks. The underlying API would create permissions, cTypes, and other HomeKit specific attributes for HAP-NodeJS based on the event listeners that are implemented.
var accessory = new Accessory('First Garage Liftmaster');

var safetyLight = new Accessory.Light('Overhead Light');
accessory.addService(safetyLight);

safetyLight
    .on('setPowerOn', function (callback) {
        // Liftmaster API call for turning light on
    })
    .on('setPowerOff', function () {
        // Liftmaster API call for turning light off
    });

var backlight = new Accessory.Light('Information Display Backlight');
accessory.addService(backlight);

backlight
    .on('setPowerOn', function () {
        // Liftmaster API call for turning light on
    })
    .on('setPowerOff', function () {
        // Liftmaster API call for turning light off
    });

var securityLock = new Accessory.Lock(
    'Control Panel Lock',
    // We could add accessory type specific options such as Apple's auto lock feature like this
    {
        autoLock: true,
        lockTimeout: 10000
    }
);

accessory.addService(securityLock);

securityLock
    // Auto lock also calls this to simplify the interface
    .on('setLocked', function (isLocked, done) {
        // Fake Liftmaster API call for locking garage controls
        liftmasterApi.setControlLock(isLocked, function (err) {
            done(err);
        });
    })
    .on('getLocked', function (done) {
        // Fake Liftmaster API call for getting lock state of garage controls
        var isLocked = liftmasterApi.getControlLock(function (err, locked) {
            // Node js style callback with err, result
            done(null, isLocked);
        });
    });

// Example fake Liftmaster API event callback for updating a read-only characteristic
liftmasterApi
    .obstructionDetected(function () {
        securityLock.emit('obstructionDetected');
    });

// Run this when any discovery and setup is done to start the server
accessory.publish();

This is a great idea. I'm an OO guy personally so am wondering if these can be classes instead of top-level objects, but regardless I think we really need something like this.
(Also I added this to the new roadmap)

I'm not sure if EventEmitters are the right pattern for this, but it seemed to be the closest fit because emit allows us implement calls anywhere inside of callbacks from third party API libraries without needing this = that everywhere. If we use a standard naming scheme for the events such as obstructionDetected for an event notification to homebridge and getObstructionDetected for when the third party API requires polling and can't send event notifications like webhooks. (more on this below) Using this one to many pattern may increase complexity in the core however because of the potential for multiple listeners that could call a callback multiple times.
An alternative to EventEmitters might be a "fill in the blanks" class prototype, however I think that assigning functions to a class you didn't define can be awkward unless we use setters which may require the developer to have more homebridge specific knowledge.
I've heard great things about streams providing a simple interface but haven't wrapped my head around them yet. It seems that a two way asynchronous communication that can be used inside of third party callbacks is what we need. The ability for accessories to push events to homebridge and respond to events from homebridge. Also we may need the ability for homebridge to periodically poll for changes depending on how HomeKit triggers work (Does HAP send requests periodically or expect notification on a change?) and wether the third party API sends event notifications (AD2USB) or only has status requests. (Philips Hue)
Here are the three main "info events" I see:

HomeKit wants to know the lights current power state when it is connected after being offline (initialValue?)
HomeKit (probably Siri) wants to know the lights current power state on demand (onRead)
HomeKit either wants to be notified when the light is on or will poll homebridge periodically so it can fire a trigger (I'm not sure which. Can someone explain this? Is this related to eventEnabled and supportEvents?)

All of these should use the same accessory code to return the light state regardless of wether it is requested by homebridge or the third party API sends homebridge a change event. Some third party APIs may only support requesting state or events but not both. I think homebridge should provide a way to periodically poll for state or to save the current state given to it by an event, then provide that state information to HomeKit as it requires.

@nfarina I see that you have started building this in the provider-api branch. I haven't used ES6 yet but it looks exciting! Let me know how I can contribute to the project. I will probably have some time tomorrow and I can Skype if you want more efficient communication.

Hey I was going to follow up about your API proposal - on further reflection I think your code up top is pretty much ideal. The provider-api branch has a bunch of interesting ideas in it but it's getting a little in the weeds in terms of a ground-up redesign. I created a public Slack for HomeBridge if you'd like to chat more.


Entire article not downloaded when there are multiple images

 Issue by EHTaylor12
Sat Feb  1 21:57:02 2020
Originally opened as https://github.com/codelucas/newspaper/issues/775

I am running into an issue in which Newspaper3k does not download an article entirely if the article has an image embedded in the middle (usually a chart or graph image) of text.
This is an example article Sample Article in which Newspaper3k stops at the beginning of the graph embedded in the middle of the article.
Has anyone else experienced this or found a solution? I don’t need the images and if there was a way to disable loading images in the settings that would be even better.

chicagobusiness is protected by some javascript framework
fox13now works ok in 0.9.2


Test functionalities of Testerina on Windows

Description:
Carry out tests for Testerina in Windows.
Describe your task(s)
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Please refer the test document at https://docs.google.com/spreadsheets/d/1V5u3VtRd0qgBjgUVn3z9V79cjIL_ILni6JjuhghBqfE/edit?usp=sharing

Following issues were identified during the testing phase. Note that these are not Windows specific issues.
https://github.com/ballerina-platform/ballerina-lang/issues/30967
https://github.com/ballerina-platform/ballerina-lang/issues/30653
https://github.com/ballerina-platform/ballerina-lang/issues/30963


(PUP-10722) Fix masterport not honored

PUP-10670 introduced the serverport alias for masterport and changed Puppet to use it internally instead of masterport.
This introduced the following change in behaviour:

when setting masterport in any section different than main(eg. agent), this is ignored and the default serverport value is used.
users that have masterport set in their configuration, in a different section than main(eg. agent), are also affected as Puppet
will not pick up the value set for masterport and it will use the default serverport value.

This is due to the setting hooks not being called when they are set in sections other than main.
In addition to the setting hooks, check and set masterport and serverport when initialize_app_defaults is called, if required.

CLA signed by all contributors.

jenkins please test this with servertests


Different behaviour using build-scan and legacy build-scan

Hi,
I am using jfrog cli version 2.8.3
When i run jfrog rt build-scan <build-name> <build-number>, i am getting an expected warning telling me that i use a deprecated command. The command runs whitout a problem though.
But if i run the new command jfrog build-scan <build-name> <build-number>, I get an error response :
[Error] Server response: 404 Not Found
404 page not found

I do not know if i missed something but i could not find the doc with the brand new build-scan command
Thanks

Hi @mcanzerini ,
Thanks for reporting this issue.
Could you please provide the JFrog CLI version used in the task?
The new build scan command is supported by Xray version 3.37.0.
Also, on the latest Jfrog CLI version (2.9.0) we validate the Xray version and print a warning if it's below the minimum supported version for the new build scan.

Thanks for your answer.
I am using jfrog cli version 2.8.3.

Got it, so upgrading to Xray to version 3.37.0 and up should work for you.
And also upgrading CLI to version 2.9.0 will prompt a more informative message if your Xray server is under the minimum supported version.
Let us know if you have additional questions.


[Benchmark Doc] add gae benchmark results in doc

What do these changes do?

As titled.
Related issue number

Fixes #2281

Can be previewed here: https://alibaba-graphscope-build-pr-2386.surge.sh/performance_and_benchmark.html


Logs and video don't match each other on info screen for failed test

server v.3.3.37 | client v.3.3.47
i have a test run with failed test
when i open info screen to see what had happened i see that logs and video don't match each other

fixed in carina <IP_ADDRESS>+


[WIP] Fix testing against staging

need to figure out how to shorten circleci configuration using yaml links

Fixed in https://github.com/neuromation/cookiecutter-neuro-project/pull/82, closing.


Feature request: CustomJS in hidden folder

Is it possible to allow CustomJS to access javascript files in hidden folder (folder start with '.')?
I've tried it but CustomJS, for some reason, can't detect the hidden folders.

I haven't tried it, but if it doesn't work then it would be an Obsidian limitation since CustomJS uses Obsidian APIs to read the file.

I think it's possible if loadClasses start from app base path:
this.app.fileManager.vault.adapter['basePath'] + this.settings.jsFolder
instead of using Obsidian APIs to get files:
this.app.vault.getFiles();
Do you want me to try doing it? or you prefer the current way?
I believe that CustomJS ability to be in hidden folder is a plus to hide scripting folder from Obsidian File Explorer.

this.app.fileManager.valut.adapter['basePath'] will break on iOS and Android, that's why the other API is currently used.

That said, feel free to experiment and submit a PR if you get something working. Just make sure to test on desktop and mobile.


[Help Update] Verify that help linter properly lints help.yaml files / helpfile objects

Verify that help linter properly lints help.yaml files / helpfile objects. Add new linter tests if necessary (particularly to faulty_help_example_parameters_rule).

Will be reverting help.yaml updates