Uncaught Error: ioctl(2) failed.

[Enter steps to reproduce below:]

...
...

Atom Version: 1.2.4
System: Mac OS X 10.11.2
Thrown From: terminal-plus package, v0.14.5
Stack Trace
Uncaught Error: ioctl(2) failed.
At /Users/grawl/.atom/packages/terminal-plus/node_modules/pty.js/lib/pty.js:361

Error: ioctl(2) failed.
    at Error (native)
    at Terminal.resize (/Users/grawl/.atom/packages/terminal-plus/node_modules/pty.js/lib/pty.js:361:7)
    at TermView.resizeToPane (/Users/grawl/.atom/packages/term/lib/TermView.js:115:12)
    at delayed (/Users/grawl/.atom/packages/term/node_modules/debounce/index.js:19:14)

Commands
  3x -4:19.2.0 pane:show-next-item (atom-text-editor.editor.is-focused)
  2x -2:48.9.0 terminal-plus:toggle (div.package-detail.panels-item)
     -2:45.2.0 pane:show-next-item (div.package-detail.panels-item)
     -2:44.6.0 terminal-plus:toggle (atom-text-editor.editor.is-focused)
     -2:42.8.0 pane:show-previous-item (atom-text-editor.editor.is-focused)
     -2:40.5.0 core:select-all (atom-text-editor#terminal-plus.core.shell.editor.mini.is-focused)
     -2:40.3.0 core:cut (atom-text-editor#terminal-plus.core.shell.editor.mini.is-focused)
  4x -2:36.5.0 core:backspace (atom-text-editor#terminal-plus.core.shell.editor.mini.is-focused)
     -2:33.2.0 pane:show-next-item (atom-text-editor#terminal-plus.core.shell.editor.mini.is-focused)
 13x -2:32.6.0 terminal-plus:toggle (atom-text-editor.editor.is-focused)
  2x -1:27.2.0 core:move-left (atom-text-editor#terminal-plus.style.animationSpeed.editor.mini.is-focused)
  2x -1:26.5.0 core:move-right (atom-text-editor#terminal-plus.style.animationSpeed.editor.mini.is-focused)
  3x -1:26.2.0 core:backspace (atom-text-editor#terminal-plus.style.animationSpeed.editor.mini.is-focused)
  2x -1:25.3.0 terminal-plus:toggle (atom-text-editor#terminal-plus.style.animationSpeed.editor.mini.is-focused)
     -1:12.3.0 core:confirm (atom-text-editor#terminal-plus.style.fontFamily.editor.mini.is-focused)
  6x -1:11.5.0 terminal-plus:toggle (atom-text-editor#terminal-plus.style.fontFamily.editor.mini.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "autocomplete",
      "command-palette",
      "wrap-guide",
      "terminal-status",
      "terminal",
      "term",
      "Termrk",
      "atom-terminal"
    ],
    "themes": [
      "native-ui",
      "one-light-syntax"
    ]
  },
  "terminal-plus": {
    "core": {
      "shell": "fish",
      "workingDirectory": "Active File"
    },
    "style": {
      "animationSpeed": 10,
      "fontFamily": "Fira Code",
      "theme": "inverse"
    },
    "toggles": {
      "autoClose": true
    }
  }
}

Installed Packages
# User
auto-detect-indentation, v0.4.2
autocomplete-clang, v0.8.8
autocomplete-paths, v1.0.2
autocomplete-sass, v0.1.0
language-jade, v0.6.2
minimap, v4.17.0
native-ui, v0.10.0
pigments, v0.19.1
project-manager, v2.6.5
soft-wrap-indicator, v0.7.0
terminal-plus, v0.14.5

# Dev
No dev packages

sorry

Were you able to fix your issue?

It was because of I resized Atom window with open Terminal Plus pane. Cannot repeat this issue again. Sent this issue in the middle of a night, sorry again.

Came across same issue :
see https://github.com/chjj/pty.js/issues/187
quick check before resizing :
if (!socket.term.readable || !socket.term.writable || socket.term.destroyed) return;


update hashie version

Any updates with this?

No - since the pull request was closed I haven't been watching it. If the PR gets reopened or another one is made we'll add it in.

Thanks Chris, will issue a new one today, hopefully.

@chriswarren master is currently red with
rspec ./spec/desk/api_spec.rb:51 # Desk::API with module configuration with class configuration should override module configuration
rspec ./spec/desk/api_spec.rb:60 # Desk::API with module configuration with class configuration after initilization should override module configuration after initialization

What would you like me to do?


CA - Centralized CLIA for ImageMover

CA would like to be kept abreast of all new facilities being reported through ReportStream. While we can manage reporting on this effort for SimpleReport, we cannot guarantee that a sender will provide adequate notice to RS, and RS will be able to provide adequate notice to CA. Hence, this ticket is intended to create a centralized CLIA for all ImageMover facilities for CA.

Confirm with CA if this approach work for them
Determine the placeholder CLIA to be used
Make necessary steps in settings and configuration to manage the change

From Ellaison:
Please configure what is needed on the ReportStream side to send everything under CDPH000077.  We’ll have original sending CLIA in OBX-23.1, so local health staff will be able to tell where the results came from or where testing occurred.  And we’ll need a resend of all the results from ImageMover going back to say Oct 1.  I don’t think the total number is very high and this will allow the earlier NAK’s to go through now that corrections have been added to the feed.  We’ll also need the OBR-25 changed from F to C to ensure duplicates for CLIAs that we didn’t have built earlier are not filtered out by CCRS.
If possible, can we get a count of the number of messages this covers?  I am guessing it’s probably 300 or less.  And prior to the resend, can we ensure all the messages have LOINCs in OBR-4 and OBX-3.  I know this was a problem for some of them that didn’t cause a NAK, but is an issue in CalREDIE.
Thank you,
Ellaison

centralized CLIA set. CDPH requested resubmissions that are over 30 days old.  @brick-green-agile6 @anshulkumar-usds may need to get data from ImageMover.

Here is the list of Message IDs that need to be resent. It's essential that they send the test result status as "C". To do so they will use this field "test_result_status" and simply add C to all the results. @anshulkumar-usds Can you help coordinate this with ImageMover?
 Awaiting sender resubmissions

1/25: ImageMover completed the resubmissions.
Accession:
64ad12c3-102e-4dab-bb25-5b89b97dbb1b
Response:
cf0f6b5a-a5d8-4ae6-917e-e012e042c694
@brick-green-agile6 please review.

I don't see the new result in metadata yet. The only result I see with that accession\message id is the original result from november.

we have a problem - the data looks for from imageMover. But the imagemover schema needs to be updated. Currently it is defaulting the test result status to "F" and overwriting the "C" value that IM is sending.

Should deploy tomorrow if blocking ticket is resolved. Imagemover will need to resend affected files.

@anshulkumar-usds The fix was deployed on friday. ImageMover does not need to send the field test_result_status in their files. They only need to fill the correctedTestID field with the testID of the previous message. Let me know if i should reach out to IM on this.

@brick-green-agile6 I contacted IM with your instructions. Thanks,

@brick-green-agile6 sender made a few submissions. Please review and confirm if the resubmissions are good.

Checked these results and they look good. IM can send the reset along.

3/1: @brick-green-agile6 IM completed all remaining resubmissions.

Sent some examples to Ellaison for confirmation

3/1: CA confirmed receipt and validated records. Closing.


Does REST sort function work?

What are you trying to do?
Sort the response results for a given query. For example, the following queries (note change in sort field value) provides the same results.

https://search.maven.org/solrsearch/select?q=g:com.squareup.okhttp3 AND a:okhttp&core=gav&start=0&rows=20&p=jar&sort=timestamp desc
https://search.maven.org/solrsearch/select?q=g:com.squareup.okhttp3 AND a:okhttp&core=gav&start=0&rows=20&p=jar&sort=v desc
Am I using in the incorrect parameter syntax?

What feature or behavior is this required for?

The https://search.maven.org/solrsearch search service

How could we solve this issue? (Not knowing is okay!)

If someone could test and validate whether my query syntax is correct that would be a good start. After that we can determine if there is a bug or not.

Anything else?

https://github.com/fireant-bot/fireant/issues/70


(v0.12) Old glClear code bath as a fallback

Fixes #1005 in v0.12 branch

@homu r+

:pushpin: Commit 57caeec has been approved by kvark

:hourglass: Testing commit 57caeec with merge 6e9d47e...

:sunny: Test successful - status


Feature/ping

server/:id/status pings the server and returns true if the server responds

I pushed the changes related to timestamp parsing and extraction here too. The /timestamp branch can be ignored


showing raise KeyError('%s not in index' % objarr[mask])

have dataset with 41 features and one output which has 23 class
i modified the imdb sentimental classification example lstm for my dataset and it is showing error. please have a look on the attached image.
I am trying to implement

two memory blocks and two cells each
four memory blocks and two cells each
two memory blocks and four cells each
eight memory blocks and four cells each

from future import print_function
import numpy as np
np.random.seed(1337)
from keras.preprocessing import sequence
from keras.utils import np_utils
from keras.models import Sequential
from keras.layers.core import Dense, Dropout, Activation
from keras.layers.embeddings import Embedding
from keras.layers.recurrent import LSTM
from sklearn.cross_validation import train_test_split
import pandas as pd
max_features = 494021
maxlen = 100  # cut texts after this number of words (among top max_features most common words)
batch_size = 32
print('Loading data...')
data = pd.read_csv('kddtrain.csv', header=None)
X = data.iloc[:,1:42]
y = data.iloc[:,0]
X_train, X_test, y_train, y_test = train_test_split(X, y,test_size=0.2,random_state=42)
print(len(X_train), 'train sequences')
print(len(X_test), 'test sequences')
print(X_train.shape)
print('Pad sequences (samples x time)')
X_train = sequence.pad_sequences(X_train, maxlen=maxlen)
X_test = sequence.pad_sequences(X_test, maxlen=maxlen)
print('X_train shape:', X_train.shape)
print('X_test shape:', X_test.shape)
print('Build model...')
model = Sequential()
model.add(Embedding(max_features, 128, input_length=maxlen, dropout=0.5))
model.add(LSTM(128, dropout_W=0.5, dropout_U=0.1))  # try using a GRU instead, for fun
model.add(Dropout(0.5))
model.add(Dense(1))
model.add(Activation('sigmoid'))
model.compile(loss='binary_crossentropy', optimizer='adam')
print('Train...')
model.fit(X_train, y_train, batch_size=batch_size, nb_epoch=15,
validation_data=(X_test, y_test), show_accuracy=True)
score, acc = model.evaluate(X_test, y_test,
batch_size=batch_size,
show_accuracy=True)
print('Test score:', score)
print('Test accuracy:', acc)

Hi @vinayakumarr Did you find out what was causing the error?

@vinayakumarr @vedu4489 you should convert your X_train and y_train in a numpy array. E.g.,:
import numpy as np
...
model.fit(np.array(X_train), np.array(y_train), ...


Clicking outside of dropdown component still opens the dropdown menu

components: Dropdown, ButtonDropdown
reactstrap version #8.4.0
import method es
react version #16.13.1
bootstrap version #4.5.0

What is happening?
When the user presses the dropdown button, it opens the menu normally. Afterwards when the user clicks anywhere outside the button, it still toggles the dropdown on and off. If there are multiple dropdown buttons, it will toggle all of them when clicking anywhere.
What should be happening?
When the user clicks anywhere outside the dropdown, it should only hide the dropdown menu and not show it again until the user presses the button
Steps to reproduce issue

Include either Dropdown or ButtonDropdown on a page with any number of DropdownItems
Click the Dropdown button once to display the menu
Click anywhere else that is outside the button and it will toggle the menu on and off

Error message in console
No errors
paste error message with stacktrack here
No errors
Code
<UncontrolledButtonDropdown>
  <DropdownToggle caret/>
  <DropdownMenu>
    <DropdownItem>Test 1</DropdownItem>
    <DropdownItem>Test 2</DropdownItem>
   </DropdownMenu>
</UncontrolledButtonDropdown>

I couldn't reproduce this issue.

Not sure I understand what is happening. I took the code provided and made https://stackblitz.com/edit/reactstrap-v8-e4m4y9?file=Example.js
It seems to be functioning as expected for me.


Problems with generating prisma client using bun

The problem
When I install @prisma/nuxt and start at dev mode everything works until "Generating Prisma client...". At this moment it just freezes and nothing happens
Steps to reproduce:
# creating nuxt project
bunx nuxi@latest init <my-app>

bun install @prisma/nuxt

Add "@prisma/nuxt" to nuxt modules and run:
bun run dev

What I've noticed
There are some experiments that I've done. I've noticed that it works when there is no bun.lockb. So I tried installing packages and start dev mode with deleted bun.lockb and it worked.
Also if I add bunfig.toml:
[install.lockfile]

# whether to save the lockfile to disk
save = false

then it also works.
Also after successful first time (using no bun.lockdb or bunfig.toml)  it works anyway (with/without bun.lockdb). I am new to bun and prisma so I don't know the exact reason. I guess that "@prisma/nuxt" installs "@prisma/client" at first time and that breaks everything and at second time it is already installed so everything works. And it's very strange that bun.lockdb somehow affects runtime
Screenshots
Generation freezes. You can see that it started at 22:03 and I made a screenshot at 22:06:

Generation works good. Removed @prisma/nuxt from modules so it doesn't run at nuxt prepare. Then removed bun.lockdb and ran bun dev:

Generation works. Added bunfig.toml

I think this is a bug in Bun

I think this is a bug in Bun

So should I create an issue at their repo?

I think this is a bug in Bun

Okay, then I'll create an issue at it's repo

Don't use Bun.
Use Yarn instead.

same problem, stuck in "generating prisma client" when run "bunx nuxi@latest module add prisma"

Thanks for reporting the issue @Elijjahh.

same problem, stuck in "generating prisma client" when run "bunx nuxi@latest module add prisma"

Can you enable debug logging and give me the output?

Ran into the same problem with a fresh project using bun.
It logs nothing after 10 mins, escaping the process dont give anything either.
Manually running bunx prisma generate seems to work just fine.

Can you enable debug logging and give me the output?

@ankur-arch here is the output:

P.S: When there will be an update for npm package? I see you merged some fixes at main branch but there is no release yet

Yep, I'll be releasing the fixes soon!

Hello! Any news about the bug?

Hey @itsmelouis , I'll provide updates here as I release a fix for this.

Nice, thanks for the answer! :)

In the meanwhile, to get things working with bun, what worked for me is:
I edited<EMAIL_ADDRESS>and commented out the following code inside the generateClient function.
  // if (installPrismaClient) {
  //   try {
  //     const installCmd = installingPrismaClientWithPM();
  //     await execa(installCmd.pm, installCmd.command, {
  //       cwd: directory
  //     });
  //   } catch (error) {
  //     logError(
  //       PREDEFINED_LOG_MESSAGES.generatePrismaClient.prismaClientInstallationError
  //     );
  //   }
  // }

The code just tries to run bun add @prisma/client --dev so I ran that manually instead.

In the meanwhile, to get things working with bun, what worked for me is:
I edited<EMAIL_ADDRESS>and commented out the following code inside the generateClient function.
  // if (installPrismaClient) {
  //   try {
  //     const installCmd = installingPrismaClientWithPM();
  //     await execa(installCmd.pm, installCmd.command, {
  //       cwd: directory
  //     });
  //   } catch (error) {
  //     logError(
  //       PREDEFINED_LOG_MESSAGES.generatePrismaClient.prismaClientInstallationError
  //     );
  //   }
  // }

The code just tries to run bun add @prisma/client --dev so I ran that manually instead.

// nuxt-config.ts
  prisma: {
    autoSetupPrisma: false,
    installClient: false,
    installStudio: false
  },

Nuxt 3.14.159 with Nitro 2.10.4                                                                                11:13:52 PM
ℹ Using zod with vee-validate                                                                                11:13:54 PM
ℹ Using Tailwind CSS from ~/assets/css/tailwind.css                                                                                nuxt:tailwindcss 11:13:54 PM
✔ Prisma CLI is already installed.                                                                                11:13:55 PM
✔ Prisma schema file exists.                                                                                11:13:55 PM
✔ Database migrations folder exists.                                                                                11:13:55 PM
                                                                                11:13:55 PM
Not migrating the database.
Generating Prisma client...                                                                                11:13:55 PM

                                                                                11:13:56 PM
Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma

✔ Generated Prisma Client (v5.22.0) to ./node_modules/.pnpm/@prisma+client@5.22.0_prisma@5.22.0/node_modules/@prisma/client in 34ms

Skipped installing Prisma Studio.

For anyone with the same problem upgrading bun to 1.1.38 fixed it! I didn't try to test with versions between 1.1.33 and 1.1.38 so may be bug was fixed earlier. For me it doesnt matter) So I am closing this issue

@ankur-arch thanks for your care

For anyone with the same problem upgrading bun to 1.1.38 fixed it! I didn't try to test with versions between 1.1.33 and 1.1.38 so may be bug was fixed earlier. For me it doesnt matter) So I am closing this issue

I've been trying it with every single version in that ratio, including 1.1.38 and I'm still experiencing the same...
Maybe somebody else can say if 1.1.38 fixes this for them?

Still seems to occur on 1.1.38 (unless I do @davidparys's workaround, which worked before)


Nested form fields values are not reflected on submit

Hi, I am using ngx-formly. in my project to create dynamic tab based forms.
i have a similar model like below:
model = {
    areas_data: [{
            "area_id": "someuuid",
            "description": "ewrwr",
            "nested": [
                {
                  "name":  'rerw',
                  "desc": 'ewe'
                }
            ]
    }]
  };

I have created form field structure using tabs and repeat example from demo.
Here is stackblitz demo for the same Demo
I got one issue here whenever i try to open a nested element in other tab , the nested elements field values are not reflected on submit.
To reproduce issue:
Just click on Nested Button
Then in nested tab model fields are not populating by default.
@aitboudad please help me , how can i achieve this?
Any suggestions, what i am doing wrong here?
Thanks!!

the nested elements field values are not reflected on submit.

the model does not match the passed formly schema:
    areas_data: [{
      "area_id": "someuuid",
      "description": "ewrwr",
-     "nested": [
-       {
-         "name": 'rerw',
-         "desc": 'ewe'
-       }
-     ]
+     "nested": {
+       "name": 'rerw',
+       "desc": 'ewe'
+     }
    }]

Sorry if i misguided you, but model was correct , i want the nested as array


feat: Zarf deploy-time GPU configuration

Collapses everything into 1 image for CPU and GPU support
Zarf deployment allocated GPU based on GPU_ENABLED flag
Fixes for README and Deps

Note: still need to fix the config.yaml for the new workflow.


Next.js App Router Migration

Context
Please see Discussion: Next.js App Router Migration.
Next.js v13 introduced the new routing model, App Router, which supports server side components and requires a new project structure. This epic is to track the router migration process from page to app.
The issues tracked by this epic as follows:

The list of issues go here

Problem or idea
The context should lead to something, an idea or a problem that you’re facing. Put that here.
Solution or next step
You can tag others or simply leave it for further investigation, but you must propose a next step towards solving the issue.

This epic is closed for the following reason:
Via 1:1 instruction, the linked issue Discussion: Next.js App Router Migration will be converted into the epic for the Next.js app router migration (we'll treat the linked issue as the single source of truth of the epic).
Once the linked issue is converted into the epic, we'll continue to redefine/improve the implementation steps as necessary and the context of the epic will be updated accordingly to reflect those changes (e.g., requirements may change depending on the unexpected errors we encountered during the migration process).


add openssl lib when using prisma

Fix prisma errors related to missing libssl library

isnt this redundant as we already add the nix package?


Basic Indexing Support

Summary:
The HelloWorld examples have a few new lines showing the indexing functionality for both C# and F#
Array.cs: has a new indexing operator []
Util.cs: new Seq() and Span members
Data.cs: new Copy() method (which was missing)
Inside the Interop folder there's a new file (AFIndex.cs) and there's a new class af_seq.
AutoGenTool changes can be pretty much ignored since they are only for development purposes (code/interop generation).

Thank royalstream. It works cool.
I also noticed another issue, before issuing a post I want to have your suggestion:
is it possible to divide an array with a double?
One more time thanks for your contributions

@altaybrusan you're welcome.
I've found no way to scale an array by a scalar using the C API (which is what arrayfire-dotnet wraps)
All the arithmetic operations are between two arrays.
Looking at the C++ code for the *= and /= operators (when used with a scalar) it seems like internally what they do is creating a temporary constant array of the same size and then performing the operation as usual (see the ASSIGN_TYPE macro).
I could add this functionality as a separate PR (after they accept this one).
But now you know what it will do.

Ye,Thats what I have done

I also noticed there is no function for loading files,such as af_load_image_memory available in the wrapper! Any idea if is going to be implemented near soon or not?

I'm not sure if its just my system, but I'm running into a Backend Mismatch error for OpenCL (works fine for CUDA and CPU). I'm trying to investigate what the cause is.
The ArrayFire OpenCL examples work fine though.

The helloworld C# example is running into vshost.exe has stopped working. Would you know anything about this?

Quick question: If I'm using the Unified Backend, how could I be doing something wrong for OpenCL but right for CUDA?

Yeah I'm not entirely sure either. I tried looking at the code but found nothing obvious...im going to try and test it on another machine.

Do you get the error if you run the OpenCL without running the CPU and CUDA tests?
That is, please comment out the first two tests.

Yes I tested OpenCL only, and that failed too. I tested the helloworld examples too by calling CPU/CUDA/OpenCL all independently. OpenCL still ran into the same error.

In my computer it runs perfectly, as long as I only run OpenCL without CUDA or CPU before it.
Are you using the code from my new PR or the previous version? I don't think this PR is related, both should behave in the same way.

Here are further observations:

Yes I ran this PR as well as the devel branch. Looks like both are failing. This might need further investigation.
I ran this on an AMD system without CUDA. The OpenCL fails there as well but not CPU. On this machine OpenCL gives a failed to load DLL error.
Separate from the ongoing topic, but on this AMD machine, when it tried to set CUDA, it crashes the application. Ideally we would want this to print an error saying "failed to load CUDA backend" and then just skip to the next backend. If you want to replicate this in testing, you could probably just rename afcuda.dll to afcuda.dll.bak

Well, my bad I think my last point can be ignored.

This is what I've found on my system:

If I put a pause before the program is about to end ("Press any key to continue") I reach this point with no errors. This leads me to think the problem is related to unloading the DLL.
If I don't use the debugger and stick to OpenCL only, I get no errors.

Do you get the same behavior?

Maybe we should continue this conversation here

What about this PR? can it be merged?

Can you make the changes to the helloworld example (use Backend.DEFAULT) and print device info?
Also, the vshost.exe failure happens in debug mode. It looks like it may have to do with the build options.
Once these two action items are done, I'll merge it.

The vshost one can be fixed by checking the Project Properties -> Debug -> Enable Native Code Debugging box in the C# and ArrayFire DLL projects.

I had to edit the csproj by hand because using the checkbox was saving the changes in the csproj.user file.
In any event, the changes are done.


[Idea] byId Reducer For Direct Object Access

Currently it looks like the all reducer stores objects as an array. You could convert it with something like the following.
const arrayToObject = (array, key) => array.reduce((result, val, inx) => {
  result[val[key]] = val
  return result
}, {})

const myObjectsById = arrayToObject(myObjects, 'id')

However this adds overhead for every component that may directly access these values via connect or any other property sharing mechanism. Currently, I do not use the pre-built reducers included with redux-saga-requests, mostly in part because I can't find a way to directly access objects by id. Typically I run an all reducer right next to a byId reducer. While this results in twice the storage being used, I feel it adds more efficiency to my code base by allowing direct es5 based iteration over the all reducer, and direct access to objects with the byId reducer.
I was just curious, are there any plans to add this feature in the future? I've implemented this library in several projects so far and love everything it seems to offer, this is the only limitation I've found so far even though its very easy to work around and is not necessary.

Currently reducers store data in the exact shape like returned from the server. So if your server responds with array with big amount of nodes, this is what reducer will keep. You can control the exact shape in requestsReducer by implementing getData callback, you could for example call your arrayToObject function there. This callback would be executed only once per request, so not often. Alternatively, if you want your reducers to have original response, but also you would like to have data grouped by id, you can use write selectors with reselect, so again, it will be executed only once per request due to memoizing. Also, if you need it, you can configure multiple or getDefaultData to control reducers initial data.
Do you think it is enough for your use case?

Late reply... So what if, for instance, I use the onSuccess saga, then in the onSuccess saga mutate the action prior to being dispatched to the reducers by running the response through normalizr. As normalizr returns an object with IDs as indexes, would the reducer have any issue with that? I guess I haven't tried this yet.

Reducers don't care about object structure of data, so it shouldn't cause any issues.

Closing, this can be solved with getData or a custom selector. In the future versions it is possible that I will implement some automatic normalization of data with automatic getById selectors.


i18n-ed toolbar slots' descs and added polish trans

Contains
Minor i18n fix. :)

Merged this at long last, after resolving conflicts. Thanks @anuar2k ! :-)
Also took the opportunity to grab latest translation work from Weblate (resolving lots of conflicts from there) to merge in as well, plus re-updating Weblate itself.


chore: update nanostores dependency to latest version

This bumps the nanostores dependency to get rid of the TS error as reported in #10.

Sweet. Thanks!


[CodeCamp2023-497] Translation into Chinese of an English document.

Motivation
Translation into Chinese of an English document.
Modification
Add tracking_analysis_tools.md and tracking_dataset_prepare.md under zh_cn\user_guides folder.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @timerring,
We'd like to express our appreciation for your valuable contributions to the mmdetection. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: https://discord.gg/UjgXkPWNqA.
If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".
Thanks again for your awesome contribution, and we're excited to have you as part of our community!


Network change behavior for thaliWifiInfrastructure

PR is added to the queue for testing as 1. task. (c0fcaf3)

Test (Success) 58918757 build is completed (c0fcaf3)
See https://github.com/ThaliTester/TestResults/tree/58918757c0fcaf3_Network_change_behavior_for_thaliWifiInfrastructure_vjrantal/ for the logs

Test 58918757c0fcaf3(c0fcaf3) has failed
See https://github.com/ThaliTester/TestResults/tree/58918757c0fcaf3_Network_change_behavior_for_thaliWifiInfrastructure_vjrantal/ for the fail logs

PR is added to the queue for testing as 1. task. (1df074b)

@yaronyg: You could start the code review on this one already, but before I merge, I'll still check why one of the on-device test results in CI was not what I expected..

Test (Success) 58918757 build is completed (1df074b)
See https://github.com/ThaliTester/TestResults/tree/589187571df074b_Network_change_behavior_for_thaliWifiInfrastructure_vjrantal/ for the logs

Reviewed 10 of 11 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 10 unresolved discussions.

test/www/jxcore/bv_tests/testThaliWifiInfrastructure.js, line 3 [r2] (raw file):
I would recommend sticking in a test where we start and then stop and then validate that our state is clean.
I would also stick in a test where we start and then stop and then start again and make sure we are still functionality.

test/www/jxcore/lib/testUtils.js, line 140 [r2] (raw file):
Shouldn't this be called something like getMockWifiNetworkStatus since when we are mocking iOS or Android we'll want to return results claiming that bluetooth and BLE are available?

thali/NextGeneration/thaliMobileNative.js, line 444 [r2] (raw file):
Should we specify that {string} becomes {?string} and inside of saying "if missing" we should say "If null"?

thali/NextGeneration/thaliMobileNativeWrapper.js, line 247 [r2] (raw file):
If someone calls getNonTCPNetworkStatus before they have called start then we should return an Error.
Otherwise if we don't have nonTCPNetworkStatus it just means we have a race condition where someone managed to call start and getNonTCPNetworkStatus before the response came back from the native layer. But in that case we need to create a new promise that we hand off to the thaliMobileNativeWrapper event handler to call when it gets an event. That will then tell us when the value is available and we can return it.

thali/NextGeneration/thaliMobileNativeWrapper.js, line 422 [r2] (raw file):
I don't believe that our mock code should be in our production code. In other words I believe we should avoid a situation where iAmAMock shows up in a production file. Instead, I think, we should have mocked Mobile using proxyquire  for testing purposes and the thaliMobileNativeWrapper shouldn't need to know or care. Please talk to me if this is proving difficult, I'm sure together we can figure out a good approach.

thali/NextGeneration/thaliWifiInfrastructure.js, line 153 [r2] (raw file):
Setting self.peerAvailabilities[key] = false actually creates a memory leak. Javascript has to remember every key for as long as the code is running so it knows its value is false. Another approach is to use the delete operator to remove the key all together. That way, no memory leak.
And yes, it is safe to use delete inside of a for in loop so long as you only call delete on the current key. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...in for the gory details.
If we use delete then we can get rid of the 'if (self.peerAvailabilities[key])' check above.

thali/NextGeneration/thaliWifiInfrastructure.js, line 177 [r2] (raw file):
I think using for in is confusing with an array. It's generally recommended that one instead use results.forEeach(). Eventually we'll switch to for...of but the version of v8 and Spidermonkey that we are using doesn't support ES6 yet.

thali/NextGeneration/thaliWifiInfrastructure.js, line 313 [r2] (raw file):
Shouldn't other parts of states be cleared out such as the current and desired target states? Sounds like a good thing to test for as well.

thali/NextGeneration/thaliWifiInfrastructure.js, line 388 [r2] (raw file):
Typically the public function shouldn't have internal arguments on it. I would suggest having a public function that takes no arguments and then a _stopListeningForAdvertisements version that has whatever internal test hooks we need.

thali/NextGeneration/thaliWifiInfrastructure.js, line 468 [r2] (raw file):
This sets our goal state to true even if nobody has called start yet and we will eventually return an error. Isn't that a problem? If nothing else it puts the states variable in a strange state.

Comments from the review on Reviewable.io

Review status: 5 of 11 files reviewed at latest revision, 10 unresolved discussions.

test/www/jxcore/bv_tests/testThaliWifiInfrastructure.js, line 3 [r2] (raw file):
Done.
Added an explicit test for validating state after stop and assertions to setup and teardown that gets run many times to ensure state is always right. Since we start and stop many times during the tests and all tests pass, I'd say the second paragraph gets tested with current tests.

test/www/jxcore/lib/testUtils.js, line 140 [r2] (raw file):
Done.

thali/NextGeneration/thaliMobileNative.js, line 444 [r2] (raw file):
In the description of the property, there was already a defined behavior for when it is null. If we want to "overload" that and also cover the case where platform can't get the value with null I can change the text.
I think the question is, does anyone in the upper layers need to distinguish from this property whether we aren't connected to an access point versus whether we are unable to get the BSSID? I tend to think that separation might be valuable once someone implements the BSSID-based logic.

thali/NextGeneration/thaliMobileNativeWrapper.js, line 247 [r2] (raw file):
Done.
This is true. The reason for this is that I implement only the bare minimum from thaliMobilNativeWrapper.js to be able to mock network events so I didn't have any state handling nor start function implemented.
I now implemented the basics for this to work like you say in above comment.
While implementing, I realized one scenario, which may result in behavior that isn't necessarily expected:

The thaliWifiInfrastructure needs to call getNonTCPNetworkStatus to get the network  status and with this new requirement, it also needs to call thaliMobilNativeWrapper.start.
To restore the objects in their default states after all is done, I am calling thaliMobilNativeWrapper.stop in thaliWifiInfrastructure.stop (otherwise, thaliMobilNativeWrapper would be in started state when thaliWifiInfrastructure tests are done)
Above means that if someone stops thaliWifiInfrastructure, it also stops thaliMobilNativeWrapper (for listening and advertisement), which isn't necessarily what was wanted

This makes me wonder, should there a separate function in thaliMobilNativeWrapper called something like init that would be used to just "wakep up" the native side? thaliWifiInfrastructure could just call that and not have to call start/stop.

thali/NextGeneration/thaliMobileNativeWrapper.js, line 422 [r2] (raw file):
I agree - this was just a quick way for me to get going.
I tried to use proxyquire, but that did not solve any of my issues. I guess the main reason for that is that here, we don't want to mock something that this file requires, but we want to mock a global object (which is something proxyquire doesn't do).
I think one approach is how I mocked the global Mobile object in story_001 branch, but we can figure out better ways as well.
I suggest we let it be like this in this PR and cover the follow-up under https://github.com/thaliproject/Thali_CordovaPlugin/issues/531.

thali/NextGeneration/thaliWifiInfrastructure.js, line 153 [r2] (raw file):
Done.
This was a good catch and clearly had to be fixed.
Nitpick: I wouldn't necessarily call it a memory leak, but rather it was an array of peers that could have grown indefinitely :)

thali/NextGeneration/thaliWifiInfrastructure.js, line 177 [r2] (raw file):
Done.

thali/NextGeneration/thaliWifiInfrastructure.js, line 313 [r2] (raw file):
Done.

thali/NextGeneration/thaliWifiInfrastructure.js, line 388 [r2] (raw file):
Done.

thali/NextGeneration/thaliWifiInfrastructure.js, line 468 [r2] (raw file):
Done.

Comments from the review on Reviewable.io

@yaronyg: You could start the code review on this one already, but before I merge, I'll still check why one of the on-device test results in CI was not what I expected..

I was able to fix this issue so from my perspective, this PR would be ready to go in.

Reviewed 9 of 9 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

thali/NextGeneration/thaliMobileNativeWrapper.js, line 247 [r2] (raw file):
One thing I'm pretty sure of is that thaliWifiInfrastructure should never be calling start and stop on thaliMobileNativeWrapper. That is an abstraction failure. At worst thaliWifiInfrastructure should just detect that thaliMobileNativeWrapper isn't started and fail with a "hey, you got to start thaliMobileNativeWrapper first!"
But there is another approach that I think makes more sense. If you notice in the definition of start on thaliMobileNativeWrapper I explicitly omitted needing to call start in order to register for event handlers. This was to avoid some nasty race conditions. I only required that all other methods were blocked until start was called.
But what happens if we explicitly omit getNonTCPNetworkStatus from the start requirement? It is, after all, just syntactic sugar and not actually part of the native layer.
Remember, the native side is always 'awake'. Start doesn't wake it up. Start is just there to tell thaliMobileNativeWrapper when to set up its state. If you look into thaliMobileNative you won't find a start or stop method.

thali/NextGeneration/thaliMobileNativeWrapper.js, line 422 [r2] (raw file):
But mocking global objects is easy isn't it? Just replace the object in setup and reset it in tear down. That should work recursively through all the requires. Why not just do that from the start?

thali/NextGeneration/thaliWifiInfrastructure.js, line 153 [r2] (raw file):
Isn't that the definition of a memory leak?

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 2 unresolved discussions.

thali/NextGeneration/thaliMobileNativeWrapper.js, line 247 [r2] (raw file):
If I am not mistaken, what you suggest is what I had originally until you wrote as a review comment "If someone calls getNonTCPNetworkStatus before they have called start then we should return an Error." and then I implemented that way and run into this issue.
I'd prefer we don't require start before calling that and thus we don't have to call start/stop from thaliWifiInfrastructure.

thali/NextGeneration/thaliMobileNativeWrapper.js, line 422 [r2] (raw file):
That is similar to what I had before and what I am doing in story_001. The workaround I required for this was https://gist.github.com/vjrantal/24231aa0df442ca1a668, because requiring a file to replace the global.Mobile with doesn't work if in the required file (or in the "sub-requires") there are calls to Mobile. Anyways, this is now a separate issue so suggesting to close this discussion from under this PR.

Comments from the review on Reviewable.io

Reviewed 3 of 3 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


Bump backup code version 0.0.4 -> 0.0.5

Please refer the $subject.

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/2648000778

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/2648000778
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/2648000778

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/2648000778
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/2648000778

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/2649614268
Status: success


ReferenceError: google is not defined

I am getting the following in my console - Reference Error
ReferenceError: google is not defined
at link (http://localhost:8100/lib/ion-google-place/ion-google-place.js:17:40)
at nodeLinkFn (http://localhost:8100/lib/ionic/js/ionic.bundle.js:14336:13)
at compositeLinkFn (http://localhost:8100/lib/ionic/js/ionic.bundle.js:13730:13)
at compositeLinkFn (http://localhost:8100/lib/ionic/js/ionic.bundle.js:13733:13)
at compositeLinkFn (http://localhost:8100/lib/ionic/js/ionic.bundle.js:13733:13)
at nodeLinkFn (http://localhost:8100/lib/ionic/js/ionic.bundle.js:14330:24)
at compositeLinkFn (http://localhost:8100/lib/ionic/js/ionic.bundle.js:13730:13)
at nodeLinkFn (http://localhost:8100/lib/ionic/js/ionic.bundle.js:14330:24)
at compositeLinkFn (http://localhost:8100/lib/ionic/js/ionic.bundle.js:13730:13)
at compositeLinkFn (http://localhost:8100/lib/ionic/js/ionic.bundle.js:13733:13)

Purchase Location

Actually I just got it working.   Need to point to the css and js files in my index.html.


RTL languages does not work

RTL languages (for example, Arabic) do not work correctly because of directionality.
Usage
   val additionalData = AdditionalDataField()
    additionalData.setReferenceLabel("test")
    additionalData.setPurposeTransaction("يكلمنسعفصقرشتثخ")

I think it can help: https://stackoverflow.com/questions/6177294/string-concatenation-containing-arabic-and-western-characters

Dear @mvallim, sorry for this issue! I was expecting from your lib incorrect behavior...
I'll explain why i think that my issue should be rejected.
When we place RTL value to any field, we receive string that looks incorrect (at first glance). In this example Merchant Name field (tag "59") have some Arabic value. And in system-out I receive string with "6013" moved to the right side of Arabic string. (6013 is the next tag identifier, tag "60" (MerchantCity), length "13")

But when I checked it deeper I found out that string is fully correct (bytes are in expected order):

So exactly the string from MerchantPresentedMode.toString() should be used as a Payload. I have placed directionality unicode symbols to payload and found out that QR TLV parsers just do not work with this modified value. It looks better, yes, but it is incorrect approach.
Sample of my code (in Kotlin):
    @Test
    fun `test for check payload`() = runBlocking {
        val emvco = MerchantPresentedMode()
        emvco.setPayloadFormatIndicator("01")
        emvco.setPointOfInitiationMethod("10")
        emvco.setMerchantCategoryCode("0000")
        emvco.setTransactionCurrency("10")
        emvco.setTransactionAmount("810")

        val merchantAccountInfoTemplate = MerchantAccountInformationTemplate("30")
        merchantAccountInfoTemplate.addPaymentNetworkSpecific("00", "ABC")
        merchantAccountInfoTemplate.addPaymentNetworkSpecific("01", "TEST")
        emvco.addMerchantAccountInformation(merchantAccountInfoTemplate)

        emvco.setCountryCode("RU")
        emvco.setMerchantName("يكلمنسعفصقرشتثخ")
        emvco.setMerchantCity("MERCHANT_CITY")

        val payload = emvco.toString()

        println(payload)
    }

So it works perfectly well, you should not fix it ))
BTW, thank you for this lib! :)

Thanks @Julia94 !


exports is not defined error in typescript version 2.7

I am getting exports is not defined error while running a simple typescript project in typescript version 2.7
Is it an open issue?
My tsconfig.json is default which looks like :  {
"compilerOptions": {
"module": "commonjs",
"target": "es5",
"noImplicitAny": false,
"sourceMap": false
},
"exclude": [
"node_modules"
]
}

Please provide a code sample.

See attached code source where i am try to export one component and using in another component..its a normal typescript project running on lite-server using npm.
typescript-projects.zip

The problem is that you compiled with "module": "commonjs" and then tried running the code in a browser, which doesn't support commonjs. You might want to try targeting ES6 modules (although I couldn't tell you how to get it to work in a browser) or use a tool to bundle modules into a single script, such as rollup or webpack.


When tslint.json uses extends, some rules can't be disabled

Bug Report

TSLint version: 4.0.1
TypeScript version: 1.8.10
Running TSLint via: gulp-tslint v7.0.0

When I use this configuration
{
  "rulesDirectory": [
    "node_modules/tslint-eslint-rules/dist/rules"
  ],
  "extends": [
    "./tslint-eslint-rules.json"
  ],
  "rules": {
    "comment-format": [ false ],
    "quotemark": [ false ]
  }
}

I get violations for those 2 rules, even though they are set to be disabled. (I probably get more violations than this, but I have it limited to only show 50 at a time).  However, if I comment out the contents of the rulesDirectory and extends arrays like this:
{
  "rulesDirectory": [
    //"node_modules/tslint-eslint-rules/dist/rules"
  ],
  "extends": [
    //"./tslint-eslint-rules.json"
  ],
  "rules": {
    "comment-format": [ false ],
    "quotemark": [ false ]
  }
}

those rules stay disabled and do not report violations as expected.

likely a bug introduced by https://github.com/palantir/tslint/pull/1622

I can't reproduce. I can override quotemark with false if the extend .json file contains "quotemark": [ true, "double", "avoid-escape"] or if it extends tslint:recommended

There are 2 problems here:

This is reproducible in gulp-tslint when the config file in extends does not exist. In the CLI, you see the error, but gulp-tslint swallows the error.
The change of behavior occurred because the API used to throw an exception, but now attaches an error property to the result object. (#1686)

I think the fix would be to catch the error in the non-API part of the code

This still seems to happen:
{
    "defaultSeverity": "error",
    "extends": [
        "tslint:all",
        "tslint-config-prettier"
    ],
    "jsRules": {},
    "rules": {
        "object-literal-sort-keys": false
    },
    "rulesDirectory": []
}

I get ERROR: /Users/tommedema/projects/vg/playground/tshape/src/index.ts[5, 3]: 'width' should come alphabetically before 'x' therefore the rule is not disabled.

I have the same problem and it's been a year since the last comment.
{
  "extends": ["gts/tslint.json"],
  "rules": {
    "quotemark": [true, "double", "avoid-escape", "avoid-template"]
  },
  "jsRules": {
    "quotemark": [true, "double", "avoid-escape", "avoid-template"]
  }
}

$ gts check
...
    export async function get_employees_as_json() {
      const response = await pool.query(build_sql_to_get_all_employees_as_json());
   -  return response.rows[0]["json"];
   +  return response.rows[0]['json'];
    }

gts 0.9.0
tslint 5.14.0
clang-format (used by gts) 1.2.3

I'm not really familiar with gts. It would be best if you created a minimal repro to demonstrate the issue with the tslint CLI.

 I could not reproduce it with the tslint CLI. The Google Typescript Style says it uses tslint under the hood to do checks but it seems it is overriding the config file or it is using a previous version that had the bug being reported here.


#24 Clicking on the project link should not expand the accrodian

added a stopPropagation click method to stop accordion from opening

@adin234 Thank you for your contributions.


Register the missing IErrorBoundaryLogger for the blazor hybrid project of the TodoTemplate

following https://github.com/dotnet/maui/issues/4502 we need to manually register the IErrorBoundaryLogger for the MAUI projects for now.

Since we are going to implement a custom error boundary and handle the exceptions ourselves, this issue is no longer valid and I'm closing it.


Missing .rocks parser

@swistaczekfor the record this project isn't really maintained by @weppos any more, so I ended up starting my fork in which I merged some of the pending PRs and more fixes.
I did fix the .rock TLD parsing a while back in https://github.com/jarthod/whois-parser/commit/6354c4ead61afce8f0a92449ddef10dc3e2655ae BUT :unamused:  it looks like "Donuts Inc" rebranded to "Identity Digital Inc." in the meantime, so my fix no longer works and it'll require a small update.
Feel free to open a PR for this change on my fork, otherwise I'll try to fix it later.
This is how to use the fork:
gem 'whois-parser', github: 'jarthod/whois-parser' # Unofficial but more up-to-date fork, check status at https://github.com/jarthod/whois-parser

@swistaczek I just fixed again all the Donuts Inc TLDs (including .rocks) in 99b510c4ccb0c64dd0c5995c1632af8080f3668c
So you can use my fork if you want this fix.

Thank you, @jarthod, for your contributions!


⚠ Samsung has degraded performance

In 22f412b, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2273 ms

Resolved: Samsung performance has improved in ef6df3f.


Update change-the-phone-numbers-on-your-audio-conferencing-bridge.md

Added Notes
Replaced SkypeOnlineConnector with MicrosoftTeams

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@LanaChin PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Bump dependencies, bugfix release 2.0.1

Addresses a couple of dependabot complaints
Drops some unnecessary dependencies
Notes that we do not guarantee stability for lib.rs

@doronbehar After this is merged we can make a 2.0.1 release! I will test it a bit more; so far so good. If nothing happens I'll merge this before the end of this week and tag a release.

@makefu @Artturin I drafted a new release under https://github.com/nix-community/hydra-check/releases; it is not published yet. Is it visible to you guys? Is it okay? :eyes: If all good I will publish it for packaging.


Approve/rejekt for references is missing

Since yesterday afternoon, the buttons for approve or reject are missing for the parameter of references. Its in all items with a reference like URL. Other parameter are still ok. See picture

+1

@Tpt , @wastl : Is there any information for fixing this issue?

Seems like a recent CSS update in Wikidata broke this part. Changing…
.wikibase-referenceview .wikibase-referenceview-heading {
  min-height: 1.5em;
  padding: 5px;
  background-color: #F0F0F0;
  display: none;
}

…to…
.wikibase-referenceview .wikibase-referenceview-heading {
  min-height: 1.5em;
  padding: 5px;
  background-color: #F0F0F0;
  display: block;
}

…fixes the issue. @lydiapintscher, can you or someone from your team fix this? The deep link to the CSS in question is long and may be personalized to my settings, I don't know…

We streamlined the layout in December 2015 (see https://gerrit.wikimedia.org/r/254140) and made this gray heading bar invisible in non-edit mode. By default it's empty and does not help making the page more readable. It reappears in edit-mode because we need it ourself for our toolbar buttons.
Other tools had the same issue as you and solved it by enforcing the visibility of this heading container with a slightly more specific CSS selector. See https://www.wikidata.org/w/index.php?title=MediaWiki:Gadget-DuplicateReferences.css&oldid=296214700.
I talked to @lydiapintscher and we do not want to make these gray bars visible again by default. Please apply the same patch as the gadget linked above.

So this needs to be reopened. I've inlined the patch below:
/**
 * Adds a link to copy references and add them to other statements on the same item.
 *
 * @see [[MediaWiki:Gadget-DuplicateReferences.js]]
 * @author Bene*
 */

/* show reference heading which is otherwise only visible in edit mode */
.wikibase-referenceview div.wikibase-referenceview-heading {
	display: block;
}

Thanks, @tfmorris. Added to the CSS right away, so the issue can remain closed.
@Tpt or @lydiapintscher Could you or any other admin deploy the latest versions of PrimarySources.css and PrimarySources.js please?

@Benestar Can you do this?

@lydiapintscher @tomayac I just deployed this, can you verify that all features work as expected now?

All working as intended now, thanks everyone involved. Closing for good :-)

Looks good. Thanks!

Thanks to all. Its working now. But could it be, thats little slower?


Wrong Handling of RPC Control Messages

All released versions of libp2p-gossisub use logical OR in the guarding condition of the function _processRpcControlMessage:
_processRpcControlMessage (peer: Peer, controlMsg: ControlMessage): void {
    if (!controlMsg) {
      return
    }

    const iwant = this._handleIHave(peer, controlMsg.ihave)
    const ihave = this._handleIWant(peer, controlMsg.iwant)
    const prune = this._handleGraft(peer, controlMsg.graft)
    this._handlePrune(peer, controlMsg.prune)

    if (!iwant || !ihave || !prune) {
      return
    }

    const outRpc = createGossipRpc(ihave, { iwant: [iwant], prune })
    this._sendRpc(peer, outRpc)
}

I assume logical AND should be used instead, as an outbound control message may include any non-empty combination of IWANT, IHAVE, and PRUNE:
_processRpcControlMessage (peer: Peer, controlMsg: ControlMessage): void {
    if (!controlMsg) {
      return
    }

    const iwant = this._handleIHave(peer, controlMsg.ihave)
    const ihave = this._handleIWant(peer, controlMsg.iwant)
    const prune = this._handleGraft(peer, controlMsg.graft)
    this._handlePrune(peer, controlMsg.prune)

    if (!iwant && !ihave && !prune) {
      return
    }

    const outRpc = createGossipRpc(ihave, { iwant: iwant && [iwant], prune })
    this._sendRpc(peer, outRpc)
}

Note that composing the iwant array in outRpc message requires an additional check now.
The go-libp2p-gossipsub reference implementation of the corresponding function also uses this logic:
func (gs *GossipSubRouter) HandleRPC(rpc *RPC) {
    ctl := rpc.GetControl()
    if ctl == nil {
        return
    }

    iwant := gs.handleIHave(rpc.from, ctl)
    ihave := gs.handleIWant(rpc.from, ctl)
    prune := gs.handleGraft(rpc.from, ctl)
    gs.handlePrune(rpc.from, ctl)

    if len(iwant) == 0 && len(ihave) == 0 && len(prune) == 0 {
        return
    }

    out := rpcWithControl(ihave, nil, iwant, nil, prune)
    gs.sendRPC(rpc.from, out)
}

I came across this issue in a use case where IHAVE messages received by a subscribing peer were not answered by IWANT messages which, in consequence, led to lost publication messages.
Thanks a lot for fixing this issue in a patch release!
Hubertus
BTW, the pull request for [WIP] Gossipsubv1.1 is also affected.

Hey @ffa500
Thanks for the report. We had already fixed this for gossipsub1.1, and I just created PRs to fix this in the previous 2 gossipsub releases.

Great! Thanks a lot!

Closing this. A fix was released in 0.4.7, 0.5.1 and 0.6.0


"line" chart type missing "Data Direction" parameter.

Issue Type: Bug
Represent vertical data in a line chart in ADS currently requires a non-intuitive 3-step workaround. To reproduce this issue:

Run the following query:
SELECT * FROM (VALUES ('A', 1), ('B', 2), ('C', 3), ('D', 4), ('E',5)) V (Label, Data)
Click on the Chart icon to the right of the results.
Note that the default Chart Type is "bar" and the default Data Direction is "Horizontal"
Change Chart Type to "line".
[Actual Results] Note that Data Direction is no longer available and all of the results are aligned at the right side of the chart.
[Workaround] Change Chart Type back to "bar".
[Workaround] Change Data Direction to "Vertical".
[Workaround] Change Chart Type back to "line".
[Expected Results] Note that the line chart now correctly represents the data.

Making the "Data Direction" parameter visible for line charts would remove the need for the workaround.
Azure Data Studio version: azuredatastudio 1.3.9 (cacf0777c747046af6839de3688d709b10ef9fca, 2019-01-14T23:30:09.442Z)
OS version: Windows_NT x64 6.1.7601
Extensions: none

This is an unfortunate regression from previous versions of ops studio which would automatically use the first column as the x-axis for a line chart... which was immensely useful for plotting data over time.

@gh-canon I think I tagged this as an enhancement since it was requesting a new parameter, which we'd generally consider new functionality.  However, given the "enhancement" is being requested to mitigate a broken scenario I think tagging as a bug is also reasonable.  I'll change it back to a bug.
Do you happen to recall when the feature behaved the alternate way you described regarding pulling the X-Axis from the first column?

@kburtram - I think that this is not enhancement and it is UX bug. Please see very similar issue here: #10889. In the basic reports assumed data direction is wrong. In #10889 is described that user must manually re-configure the chart to get expected result. In line chart this is not even possible because direction is missing, so user needs to switch to bar chart to change direction and then go back to line chart that will use direction configured on bar chart.
My proposal would be to change default direction to Vertical both on bar and line charts and enable  users to modify them.


v1.0.1 => processing.dt stopps firing

After upgrading to v1.0.1 the processing event (processing.dt) stopped firing.
Check: https://datatables.net/reference/event/processing
I was using this code below to show a custom spinner when data is being processed:
$(window).on('processing.dt', function(e, settings, proc) {
    vars.set('processing', proc); // Reactive...
});

Copying and pasting your event handler into v1.0.3, it fires for me. If it still isn't working for you, provide a reproduction app or MeteorPad.

When will v1.0.3 be published ?

Never mind, I was confused by the github release verion, I will test this again...


Disable weather widget

The weather widget eats up valuable screen real-estate. I propose we disable it, until some weeks before the conference (i.e., when it becomes relevant).

For discussion, @miquelramirez @nirlipo @ssardina

The weather widget eats up valuable screen real-estate. I propose we disable it, until some weeks before the conference (i.e., when it becomes relevant).

Yep, I concur

agree too, done, removed!

We'll enabled closer to the conference


add new SingleDNASequence type, adapt nw-align to use new type

Closing this in favor of #6 as I messed with the commit history to get this change into the first commit.


customers and products webhooks

I got this tutorial:
https://github.com/ohmybrew/laravel-shopify/wiki/Creating-Webhooks
and it worked great for orders
but it seems like when Im trying to do the same for products or customers
the webhook is not created on Shopify...
my config:
'webhooks' => [

        [
            'topic' => 'orders/create',
            'address' => env('APP_URL').'/webhook/orders-create'
        ],
        [
            'topic' => 'orders/updated',
            'address' => env('APP_URL').'/webhook/orders-updated'
        ],
        [
            'topic' => 'orders/delete',
            'address' => env('APP_URL').'/webhook/orders-delete'
        ],

        // Customers
        [
            'topic' => 'customers/create',
            'address' => env('APP_URL').'/webhook/customers-create'
        ]
    ],

any ideas appreciated :)

I ran into a similar issue and then realized that I did not request sufficient permissions from Shopify when installing the app. Make sure you includes permissions for products and customers. The file is located in config > shopify-app.php
` /*
|--------------------------------------------------------------------------
| Shopify API Scopes
|--------------------------------------------------------------------------
|
| This option is for the scopes your application needs in the API.
|
*/
'api_scopes' => env('SHOPIFY_API_SCOPES', 'write_content,write_products,write_orders,write_script_tags,read_script_tags'),

`

When installing the app, make sure you are including permissions for products and Customers. I ran into a similar issue, until I realized the dependency/association of scope and web hooks.
To change the scope navigate to: config > shopify-app.php
`
| This option is for the scopes your application needs in the API.
'api_scopes' => env('SHOPIFY_API_SCOPES', 'write_content,write_products,write_orders,write_script_tags,read_script_tags'),

`

Correct. Make sure your scopes are correct and clear all cookies and reaccess the app to trigger the webhook manager


evaluation script

Hi,
May i know do you have the evaluation script in Python?
Could you please share it?
Best,
ZX

After running test_lanenet.py, you get the probability maps from the model. To get the final performance, you just need to follow instructions in SCNN-Torch. More specifically, follow step 3 and 4 (Get curve line from probability map and Calculate precision, recall, and F-measure) in the testing phase.

Thank you:) it works now!
Another question is about the F measure you calculated. Do you use threshold 0.3 or 0.5 at Run.sh?
Best,
ZX

Thank you! it works now:)

The evaluation for CULane is quite slow. It takes tens of minutes to finish all the evaluation (9 different test list). I wanna check if this is normal.

It is normal since there are 30k images in the testing set.

@cardwing Thanks! Pardon me for inquiring the details. May I ask what parameters do you use for evaluation? Do you use the default setup that width_lane: 30 and iou_threshold: 0.5?

Yes. You can just check the details in scripts of ENet-Label-Torch. The performance of the released model (F1-measure: 72.0) is higher than the reported value (F1-measure: 70.8).


Latest subscribed videos not shown correctly

Somewhat has changed with Youtube:
Account page activated, state: SUBSCRIPTION_VIDEOS YouTube request method:  "list" , resource:  "activities" , params:  QMap(("home", QVariant(bool, true) ) ( "part" ,  QVariant(QString, "id,snippet,contentDetails") ) )   Selected item is a video, opening video overview page Video overview page for video ID: hNqJvVCMoxE created YouTube request method:  "list" , resource:  "videos" , params:  QMap(("id", QVariant(QString, "hNqJvVCMoxE") ) ( "part" ,  QVariant(QString, "snippet,contentDetails,statistics") ) )   YouTube request method:  "list" , resource: "videos/getRating" , params:  QMap(("id", QVariant(QString, "hNqJvVCMoxE") ) )   Changing cover to: VideoOverview.qml
So YouTube request method:  "list" , resource: "videos/getRating" should be something else.
How do I can change that?

The problem is that youtube home activity APIv3 method that is used for the subscriptions videos is now returning some default youtube top videos b******t.
And it's a pain to implement it manually right now.
I will try to find some time to take a look at this, but could not promise anything.


No localized strings now when setting language to 'ja-HIRA'

It seems that something isn't fully connected with the addition of "ja-HIRA". Not seeing any strings at all in the response payload when ja-hira is selected. The response should at least have the default preload of "ja":

I guess each editor uses {host}/api/translations API and this API uses crowdin API internally.
And now This API doesn't work well.
We should check whether crowdin API which is used internally works well.
I want someone to check this or generate crowdin API key for my checking.

I couldn't find where the code of {host}/api/translations is.
I want someone to tell me where.

I noticed I can generate crowdin API key by myself.
I generated my key and made some tests.
I found the locale of "ja-hira" edited into upper case "ja-HIRA" but the id is still lower case "ja-hira".
Now I'm trying to update the crowdin API version, so I will be able to solve this problem after that.

I found it works well with query string translate=1.
With query string translate=1, crowdin JIPT is used, I guess.


Add help text to CLI commands

What changed?

Added short help text and long help text for each command

Rationale

To help users understand the purpose and function of each command

How was it tested?
If it was manually verified, list the instructions for your reviewers to follow.

[ ] Unit Tests
[ ] Functional Tests
[ ] Manually Verified

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The tests failed for aws credentials, but I don't understand how the credentials are being pulled, can someone point me to how to test and debug this locally?

The tests failed for aws credentials, but I don't understand how the credentials are being pulled, can someone point me to how to test and debug this locally?

no worry about the aws credentials. We lock down aws credentials step to only within org PR to assume aws credentials from GitHub. so it's expected to fail (tho we can conditional that to avoid confusing PR contributors). I will review this today.


_history can be used to check existence of foreign tenant resources

HAPI v4.0.0
If you have multple tenants configured and create a resource, e.g. Patient/1, as tenant a and you access Patient/1/_history as tenant b you get an empty history indicating that the guessed resource exists for another tenant. Actually, the correct reaction is to return an HTTP-404 for this very resource. This happens if a specific version is requested by tenant b, e.g., Patient/1/_history/1 returns a 404 which is perfectly fine.
This could be used for security attacks.
This is how the empty history looks like for Observation/1702/_history as a foreign tenant:
{
  "resourceType": "Bundle",
  "id": "7eb9c188-2648-4fb0-963e-c06c0666e682",
  "meta": {
    "lastUpdated": "2019-09-12T13:57:37.933+02:00"
  },
  "type": "history",
  "link": [
    {
      "relation": "self",
      "url": "http://localhost:8080/hapi-fhir-jpaserver/b/Observation/1702/_history"
    }
  ]
}

Yes, I used a UrlBaseTenantIdentificationStrategy and customized RPs to delegate the tenant ids to the resources' meta data. Using a ConsentInterceptor I filter for the tenant id on retrieval. I was just wondering whether this foreign tenant resource lookup could be used for some attack or at least to spy data

This sounds like an issue with your tenancy implementation.. What are you requesting we fix in this bug?

I think an HTTP-404 should arrise for a GET on a _history of an existing resource of a foreign tenant.
As I tried, this already works for specific _history/s but not for the whole _history, i.e., /_history gives you an empty history which indicates the existence of the resource on which the requester does not have access to but this should be an HTTP-404. Whereas /_history/ works fine and reports a 404.

Or do you think, I miss something in the tenancy implementation? How can I invalidate the request to a foreign tenant resource's history? For access control, I use the AuthorizationInterceptor which appends the tenant id for each request.

Maybe I'm misunderstanding the issue here, but if the JPA server doesn't support multitenancy, and you add it yourself and it's not working, I don't understand how we could fix that...
Are you able to submit a unit test that demonstrates the issue against HAPI?

Closing this, as it hasn't had any follow up.
@der-brecher Please leave a comment if you feel that this is an error. I do want to address any potential security issues in HAPI, but it's not clear to me how we could address (or even reproduce) this one.


Cannot bind value to numeric inputs in IE & Edge

<input value="[[numeric_property]]" type="numeric"> results in a blank field in IE11 and Edge.
I'm having trouble getting either IE11 or Edge to perform any databding on this example jsbin, but I have reproduced the issue in a fresh copy of the seed element.
IE apparently clears numeric input fields whenever it encounters a non-numeric value.  My guess is that the data binding mechanism isn't coercing the value to a number.

Hello @indolering
Could you change the attribute to value$ as described in the section about native binding. It should then become <input value$="[[numeric_property]]" type="numeric">. This should fix the issue you are encountering.
Please let me know if it fixed the issue for you.

Must have mistakenly closed this issue earlier while trying to look at it on the phone; my apologies.
To work in any platform other than Chrome or Opera, the jsbin needs to include the polyfills, and it needs to wait for the html imports to load before registering the element. Here's an updated jsbin:
http://jsbin.com/qawima/2/edit?html,output
This updated jsbin still shows the issue in question.
The value property is always a string, even on numeric inputs, so the type coercion theory doesn't seem right. In fact, I tried setting the input value manually in ready to 32 or this.age, and both worked fine. So I'm guessing this is some kind of timing issue.
IE 11 is horking up an exception when I try to use value$=. Not sure what's up with that.
@azakus can you see something I'm missing here? Looks like a legit bug to me...

@arthurevans That error is fixed in master with https://github.com/Polymer/polymer/pull/2673
This bin works correctly in IE 11: http://jsbin.com/rofosa/edit?html,output

Having this work on Chrome and Firefox but break on IE is very confusing and Polylint doesn't catch the problem either.
@azakus Your JS bin is broken on Chrome, IE, and Edge.
Okay to close if #2673 fixes the problem.

@indolering Sorry my syntax was wrong for the polygit line.
This one works in both: http://jsbin.com/pinile/1/edit?html,output

@azakus confirmed working on Chrome, IE, and Edge.
@JeremybellEU that section of the documentation doesn't list value as an attribute requiring $= so I created an issue ticket for the docs.

@azakus is there a reason we need to use value$= here to make IE happy? I've never had to use it for value elsewhere, and I'd expect a regular property binding to work in this case.

So I've confirmed as best I can that this doesn't work without the $= on IE.
We've never used $= with value before that i know of. In fact, we have property bindings to
value in the docs, and in the unit tests:
https://github.com/Polymer/polymer/blob/master/test/unit/bind-elements.html#L46
Now, we appear to need it for <input type="number"> (but not for regular text inputs, as above).
Is this a regression or a corner case?

Binding to the value attribute of an input element is problematic due to IE throwing exceptions when values does not match the expected type.
The test linked by @arthurevans does not specify a type and therefore takes the default text type. This matches the binding and therefore does not break. If however it type would be number, the binding does not match a number and therefore IE throws an exception.
When using value$, this original assignment is not evaluated (since value is not defined). Then Polymer calculates the correct value via the binding and explicitly sets the attribute value to the outcome.
Concluding: to prevent any exception from happening, use value$ (and for all other native attributes).
#2673 fixed a regression regarding input with value$, but this is now fixed on master.

@JeremybellEU you're right that this is an issue with IE. I was hoping to get an idea from @azakus or @sorvell whether there was some way the library could work around this.
Since value$= can't be used for two-way binding, it's a big disadvantage here, and if we're not careful risks creating a long-running confusion about whether it's necessary. In every other use case, using value$= is wrong.
If we can't fix this in the library in the near term, I think we should add a note to the "binding to native inputs" section, mentioning the limitation on typed inputs on IE, and giving both workarounds (use value$= or use <iron-input>).

It might be possible to, whenever Polymer encounters a value$ (or a different native attribute) to bind a listener to the onchange attribute of the element.
http://jsbin.com/xapurovuqu/edit?html,console,output
This does have some caveats:

You don't want to always trigger such a change
It only triggers upon hitting enter => maybe to bind to a different event
The value is a string, so conversion to the actual type is required.

Maybe this would solve such problems and also enable two-binding of native attributes. Although they are workarounds and might introduce more problems than they fix.

@JeremybellEU there are a few, specific native properties where attribute binding ($=) is generally required. value isn't one of them, except in this one, specific case, to work around a bug in IE.
What you're suggesting is to make the semantics of $= work completely differently, which is not what I'm asking about.
I'm asking whether we can make the standard property bindings, value="[[someProp]]" and value="{{someProp::input}}" work on IE.
There's no need for Polymer to convert the type (in the general case). An input's value is a string by definition. The problem here is that for type="number" (at least, I haven't tested any others), IE is imposing a nonstandard restriction.

Okay I misunderstood. Hopefully the core developers can jump in and develop a solution!

:+1:

This seems like a lot of trouble to go through for such a small edgecase.  If you can get the Edge developers to fix this one tiny difference, then you could just leave it as-is for numeric input values.

Ping @sorvell @azakus any way we could work around this IE bug?

@arthurevans It's my understanding that the bug has been fixed but hasn't been included in a release yet.  I've been pinging devs on Slack and a release will happen as soon as their unit tests start clearing.

@indolering I don't think this bug has been fixed. Or, it's half-fixed more accurately.
With 1.2.4, it looks like you can use value$="[[age]]". But you still can't use value="{{age}}" or
value="[[age]]" on IE.
I think that given the number of high priority issues and the relative risk/reward here, we should probably add a note to the document that for binding number inputs, you can either choose broken in IE, or half-broken everywhere. :crying_cat_face:

But you still can't use value="{{age}}" or value="[[age]]" on IE.

Can you use value$="{{age}}"?
Also, how does Github not have an IE glue eater emoticon?

Just a heads up, using value$=[[param]] severely broke data-binding in my element (including Firefox and Chrome).  I'm having a hard time isolating/reproducing the bug but I would strongly suggest against updating the documentation for now.
I'm using iron-list, would love suggestions on what to look for.

What is breaking? Can you add a brief repro?

@arthurevans I'm having a hard time replicating the issue in a naive re-implementation in JSBin.  But it appears as if iron-list has some deficits in it's data binding system ... so it's probably safe to update the documentation.  Given that people are probably experiencing subtle breakage on IE/Edge, it's probably better to update the docs now than to wait.
Sadly, I'm coming close to not being allowed to work on this anymore.  It's proprietary code, so I can't share it publicly but I can send a copy if you shoot me an email<EMAIL_ADDRESS>

@arthurevans, you mentioned <iron-input> as an alternative but it doesn't have a number type property.  Did you just not know about this or were you thinking it would be easier given the custom validator functionality?  Not sure if we should put it in the documentation until there is a numeric input option.

I finally tracked down the bugs I had with iron-list, combination of custom value$ reporting change events in response to non-user interaction and altering the path notification syntax.
@azakus feel free to close unless you want to keep it open for discussion on how to enable 2-way binding.


to add BLOCK M.D.

Hi.. this pull request is to add BLOCK M.D. into master repo. Please advice if I did it wrong.

Thanks @banksathapon. Can you also upload your logo into the logos folder?


update readthedocs.yml

This uses the new version of the readthedocs configuration. As usual, my setup failed on the creation of the environment, so we should try to check that before a merge.

[x] Closes #3623

I have made you an admin on readthedocs so you can iterate.
The way to do this may be to create a new github branch, push your changes there, activate an RTD build for that branch, and then open a pull request from that branch.

thanks, I'll try it out

it worked, so unless you have any comments we can merge?

Building documentation in PRs has recently been addressed by ReadTheDocs folks. According to this blog post the feature is in beta. The only requirement to opting-in, is to email them the url of the ReadTheDocs project.

If I remember correctly, @max-sixty did ask, but the answer was that we had too many PRs (see https://github.com/pydata/xarray/issues/3257#issuecomment-526276894)

Thanks @keewis


[simdutf] Disable benchmarks and tests.

Thanks! :) I wounder why the initial pipeline of #19742 was successful

Thanks! :) I wounder why the initial pipeline of #19742 was successful

Optional dependencies.
vcpkg install simdutf

passes.
vcpkg install icu
vcpkg install simdutf

fails.


new get_self command and fixed the result of contact_add.

Is that tested?

Eh, here goes nothing!


Long charges do not show in "Charges"

I think that I miss some long charges in the "Charges" view in the past, but was not sure about it. Now I have the evidence, for the last days. See the "Charge Level", where you can see clearly 4 charges since 23.06. (plus one active charge).

And now see the "Charges", where the charge from 25.06. (yesterday) is missing.

Maybe another Bug, but related to this one I am also missing a few other long charges, you can see it here: There is a jump from SOC end 33% to start SOC of next charge of 79% - this was also one long charge and is missing completely.

You'll have to use the "Bug Report" template when creating a new issue if you think you've encountered a bug in TeslaMate.
We cannot tell pretty much nothing  from a few screenshots. Most important are the logs of the given period and your environment. Please fill out the template as completely as possible.


fix(stackblitz): fix and standardize masthead examples for v2

Related Ticket(s)
Description
Updates the masthead component's CodeSandbox Stackblitz examples with up-to-date demonstrations for v2.
Changelog
Changed

Updates masthead Stackblitz examples for v2.

I also noticed that in the README.mdx, the Stackblitz links for L0 and L1 still have codesandbox in the URL path

I'm not sure what's up with that. I see the same for all the other other components in their Storybook READMEs, which indicates it's either a part of the URL the DPO team wants to keep, or it's a problem that needs fixing across the board. Either way, I'd argue it's out of scope for this PR.


Fix editor hover style margins when Draw Extra Borders is enabled

Fixes #88644
The slight movement seen in the videos provided by @Calinou was caused by a difference in content_margin that was only apparent when the Draw Extra Borders option is enabled. I introduced some extra styles in #86378 and didn't test how they were affected with this option on, apologies for the regression. I've now modified the styles so that the margin matches the "normal" stylebox (for FlatMenuButton and MainScreenButton) which fixes the movement issue:
https://github.com/godotengine/godot/assets/11141862/4dcc45e8-286a-4511-adaf-58dd42e315e4
I also added in the correct theme type variation to the "Mono build" button in order to stop the border from appearing in the normal state. Let me know if there's anything else I should account for here, thanks!

Thanks!

@RobProductions It looks like this change is still needed for the bottom panel, as letters get cut off otherwise:

@Calinou strange, I can't seem to reproduce that on the build I compiled before submitting the PR:

I tried with the setting on and off, in multiple themes, with the compact preset, and after restarting Godot but I don't see it. I'll take a look at the bottom panel code & try rebuilding on latest master soon to see if something changed. If it's not something on master, is there anything else that could cause the spacing to be different between our two setups?


Kani's assert macro implementation bypasses some compile-time checks

With PR #797, Kani's implementation of the assert macro's second form that accepts a custom message bypasses several compile-time checks.
For example, while rustc errors out on the following program:

fn main() {
    assert!(1 + 1 == 3, "Bad arithmetic: {}", foo);
}

output:
error[E0425]: cannot find value `foo` in this scope
 --> no_display.rs:2:47
  |
2 |     assert!(1 + 1 == 3, "Bad arithmetic: {}", foo);
  |                                               ^^^ not found in this scope

kani does not complain about the non-existence of the variable foo:
CBMC version 5.48.0 (cbmc-5.48.0) 64-bit x86_64 linux
Reading GOTO program from file no_display.goto
Generating GOTO Program
Adding CPROVER library (x86_64)
Removal of function pointers and virtual functions
Generic Property Instrumentation
Running with 16 object bits, 48 offset bits (user-specified)
Starting Bounded Model Checking
Runtime Symex: 0.00102581s
size of program expression: 75 steps
simple slicing removed 3 assignments
Generated 3 VCC(s), 1 remaining after simplification
Runtime Postprocess Equation: 7.25e-06s
Passing problem to propositional reduction
converting SSA
Runtime Convert SSA: 0.000213004s
Running propositional reduction
Post-processing
Runtime Post-process: 2.594e-05s
Solving with MiniSAT 2.2.1 with simplifier
100 variables, 33 clauses
SAT checker: instance is SATISFIABLE
Runtime Solver: 9.1981e-05s
Runtime decision procedure: 0.000343287s

** Results:
[assertion.1] Code generation sanity check: Correct CBMC vtable size for StructTag("tag-_4317141983261250885") (MIR type Closure(DefId(2:9147 ~ std[2f3c]::rt::lang_start::{closure#0}), [(), i8, extern "rust-call" fn(()) -> i32, (fn(),)])). Please report failures:
https://github.com/model-checking/kani/issues/new?template=bug_report.md: SUCCESS
[pointer_primitives.1] dead object in OBJECT_SIZE(&temp_0): SUCCESS
/home/ubuntu/examples/no_display.rs function main
[main.assertion.1] line 2 assertion: "Bad arithmetic: {}", foo: FAILURE

** 1 of 3 failed (2 iterations)
VERIFICATION FAILED

Other checks that would be skipped by kani's assert macro are that the argument must implement the Display trait.

@zhassan-aws Haven't you fixed this yet?

No, this isn't fixed. I have an idea for fixing it, but I haven't had time for it.


Can't find best crop

Hi !
Thanks for this amazing library. I use it to smart crop some thumbnails and a user of mine tried it to with the following image:

The purpose is to have it cropped to width: 450px, height 150px.
When using this tool: https://29a.ch/sandbox/2014/smartcrop/examples/testbed.html
I can see the preview works fine with a crop starting at 0x24. Notice the third one is a crop starting at 0x241.
In code though, all returned crops are:
{"x":0,"y":0,"width":1159,"height":383,"score":{"detail":-104.11501867093101,"saturation":-5.999802129457631,"skin":1.9283703323221526,"boost":0,"total":-0.00036810854144012653}}
{"x":0,"y":24,"width":1159,"height":383,"score":{"detail":-56.16525565183794,"saturation":-3.0477126789318594,"skin":2.461430895582579,"boost":0,"total":-0.00014573586749942855}}
{"x":0,"y":48,"width":1159,"height":383,"score":{"detail":-57.2293816730845,"saturation":0.463251345437012,"skin":1.153528922878493,"boost":0,"total":-0.0001911745230251786}}
{"x":0,"y":72,"width":1159,"height":383,"score":{"detail":-58.87187541531654,"saturation":4.535271644237246,"skin":-2.7804263678364567,"boost":0,"total":-0.0003347608140736796}}
{"x":0,"y":96,"width":1159,"height":383,"score":{"detail":-56.39788774743743,"saturation":8.004081548989408,"skin":-3.175305768719252,"boost":0,"total":-0.00033207676710718506}}
{"x":0,"y":120,"width":1159,"height":383,"score":{"detail":-52.75468313226228,"saturation":9.522417640144617,"skin":-3.5841913718215026,"boost":0,"total":-0.00032911415952503075}}
{"x":0,"y":144,"width":1159,"height":383,"score":{"detail":-52.34772009001673,"saturation":9.851516265132997,"skin":-5.311134061195629,"boost":0,"total":-0.00039051086166425075}}
{"x":0,"y":169,"width":1159,"height":383,"score":{"detail":-47.24157938791536,"saturation":12.106789364775224,"skin":-5.726827636896237,"boost":0,"total":-0.0003802888510400012}}
{"x":0,"y":193,"width":1159,"height":383,"score":{"detail":-38.91701515478981,"saturation":14.817643748754207,"skin":-4.613893562808923,"boost":0,"total":-0.00029951294023004024}}
{"x":0,"y":217,"width":1159,"height":383,"score":{"detail":-28.532768978099767,"saturation":15.29444837078221,"skin":-1.967200582733591,"boost":0,"total":-0.0001582609499561638}}
{"x":0,"y":241,"width":1159,"height":383,"score":{"detail":-21.00452786437013,"saturation":14.527971499002678,"skin":-0.7795081188924486,"boost":0,"total":-0.00008512186345513793}}
{"x":0,"y":265,"width":1159,"height":383,"score":{"detail":-20.15399038870834,"saturation":14.18834988216667,"skin":-0.9678796888294225,"boost":0,"total":-0.00008928286026529612}}
{"x":0,"y":289,"width":1159,"height":383,"score":{"detail":-20.463943223041927,"saturation":13.139495507556804,"skin":-2.8497882106712598,"boost":0,"total":-0.0001621649006123067}}
{"x":0,"y":314,"width":1159,"height":383,"score":{"detail":-23.719379163248988,"saturation":7.768022591345811,"skin":-4.150555686691474,"boost":0,"total":-0.00023454055547817977}}
{"x":0,"y":338,"width":1159,"height":383,"score":{"detail":-29.27577211811,"saturation":0.5480934018815907,"skin":-7.157569157327678,"boost":0,"total":-0.0003831194546961873}}
{"x":0,"y":362,"width":1159,"height":383,"score":{"detail":-34.24686307723896,"saturation":-2.2046311509920615,"skin":-9.814085297634454,"boost":0,"total":-0.0005072012234721338}}
{"x":0,"y":386,"width":1159,"height":383,"score":{"detail":-43.51412120549435,"saturation":-2.943339323742967,"skin":-16.556508747735762,"boost":0,"total":-0.0007955805839771476}}

and topScore is:
{"x":0,"y":241,"width":1159,"height":383,"score":{"detail":-21.00452786437013,"saturation":14.527971499002678,"skin":-0.7795081188924486,"boost":0,"total":-0.00008512186345513793}}
What I don't understand is why I can't find the exact same best crop using the same code and the online photo. Are there some options I could use to make detection fit better ?

Can you link to an example of what you expect and what happens? I'm not sure I understand what you mean.


Update commands.py

Something changed who knows what(Kouhai to the rescue)!!!

Issue #1: Fix return type for redis.commands.json.commands.JSONCommands


Intergrate wordle word bank.

Add an array with all the words from the wordle word bank and use it to get a random word to be checked against and validate word entries.

Done. Added both the wordle list for possible answers and the list where the words come from.


Potential segfault on server statup

Hi! Recently, I've got the following error https://gist.github.com/alesapin/0dbbc2616a6b88d6a14467fd78dc922a on server startup. Actually, this specific error is not important, but the idea to start some threads from a partially initialized object doesn't look good:
https://github.com/eBay/NuRaft/blob/master/src/raft_server.cxx#L252-L257
So in my case background threads were fast enough to do something and call my callback which (in my case) checks that the current node is Leader. And all these things have happened before the constructor of raft_server was finished. So such behavior makes raft_server object very dangerous not only for user callbacks but also for its own code which executes in background threads. Maybe we can introduce some kind of startup() method which will start all background threads after the object already initialized?

Also, I have a question. Is there any way from a user code to detect that the current server is ready to serve requests? By this, I mean that the server applied all uncommitted entries to its state machine and see the leader node or this node is the leader itself.
Seems like neither BecomeLeader nor BecomeFresh are not reliable ways to detect it.

@alesapin
There is is_initialized() API to check if the Raft is ready (either it becomes leader or receives the first heartbeat from the existing leader). But that won't be the case for you if your background thread is doing something with raft_server before the constructor is done. We also internally use an atomic flag, running for example:
raftServer = cs_new<raft_server>(ctx, i_opt);
...
running = true;

but that is not the part of Raft. I think your PR https://github.com/eBay/NuRaft/pull/195 seems reasonable to avoid the issue without maintaining external flags.

Thanks, let's close this one.


BuiltInDataTypes test base issue

I am unable to implement these tests:
public override void Can_insert_and_read_back_all_non_nullable_data_types()
{
//base.Can_insert_and_read_back_all_non_nullable_data_types();
}
public override void Can_insert_and_read_back_all_nullable_data_types_with_values_set_to_non_null()
{
//base.Can_insert_and_read_back_all_nullable_data_types_with_values_set_to_non_null();
}
As I am unable to ignore TimeSpan and DateTimeOffset, both of which are not supported by SQL CE.

@ErikEJ Can you send a pull request that changes the tests so that any of the properties can be ignored using the same pattern for the ones that SQL Server currently ignores?

@ajcvickers Yes, I plan to do that, just never got round to it yet. Should I make all properties "ignorable" or only Timespan and DateTimeOffset?

Actually would it be possible to test that the remaining properties do what they do in the base test. And that TimeSpan and DateTimeOffset throw or do whatever you expect them to do for SQL CE?

@lajones Well, currently that is not possible, as the test method tests all properties. Or maybe I misunderstand your statement?

@ErikEJ I would make all properties ignorable. @lajones I think that's a different test or a bigger refactoring. At the moment property types that are not supported are excluded from the model. Testing the negative case of a property type that is in the model but not supported would be useful, but that's probably best done in a separate test.

@ajcvickers Yes, some test that throw "NotSupported" for unsupported datatypes would be great! I will make them all ignorable, then.

@ErikEJ @ajcvickers I agree it would be harder to do - more refactoring etc - but it would make for a better test I think. Still - if we can't do it right now @ErikEJ would you mind creating an issue so that we don't forget to do it later? Thanks.

@lajones unsure what you are aiming for, so maybe better if you create it! 😉

@ErikEJ - if you create a model with e.g. a TimeSpan in it and point it at a SQL CE DB, what would you expect to happen when the user tries to use that model? How and under what circumstances should it fail? The test would just test that you get the expected failure(s).

@lajones yes, that seems like a good test, and it is possibly missing from the current test suite. I would expect a NotSupported exception to be thrown in the typemapper

Added #2385


[Task]: Add an optional tag to not run an example from cache

What needs to happen?
Streaming examples from unbounded data sources can run for a long period of time. They should not run during CI/CD and should always run as there is no precompiled object available.
Issue Priority
Priority: 3 (nice-to-have improvement)
Issue Components

[ ] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam examples
[X] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

.take-issue


Implement Contract Testing

Hey @Akash-Singh04 I am learning about contract testing and was going through all the examples which are implementing contract testing for Golang, i came through this repo. I would love to know more about how you guys are implementing the same . Could you please share me some resources which can help learn the same. Thanks. And sorry for spamming your github issue

Hey @khareyash05 , this repo currently does not implement contract testing yet :((. I apologise but i dont have any refrences for you as for now.

Hey @khareyash05 , this repo currently does not implement contract testing yet :((. I apologise but i dont have any refrences for you as for now.

not at all. thank you


Feature Request: Allow configuration for bar graph options

In my example below, I have multiple entries per day (see 2023-12-01 as an example) that I want to display as separate bars on the graph. Can we enable support for options such as:

Stacking
Bar Width

I'm not sure why the y-axis labels do not show by default, is this something that also requires configuration to be added ?

Thanks in advance :)

When it comes to charts, it is pretty hard to create a visual which is going to look good under all circumstances. The default visual works for our demo purposes but for your use case with small amount if data it is not that visually appealing.
I created new PR #236 which will allow you to override default styling. I recommend creating your own configuration in a view which will be send to the template.

Hi @lukasvinclav
In app.js Can you change
options: options ? JSON.parse(options) : DEFAULT_CHART_OPTIONS,

to
something like:
options: {...DEFAULT_CHART_OPTIONS, ...JSON.parse(options)}

Since, This way we wont be required to write all the options, incase we'd only want to change few of the properties like just the barThickness, most people are likely to just change few options so I think think second would be better. Let me know your thoughts on this.
Thanks
Paul


Boolean input prints label and hint twice (v 3.1)

Boolean inputs print the label twice, once from bootstrap_wrapping before the checkbox and once after the label from label_text_with_embedded_checkbox.
The one from bootstrap_wrapping needs not be included for boolean input.
The same happens for the hint, it's printed from bootstrap_wrapping and again included explicitly in to_html.

I believe this is a duplicate of https://github.com/mjbellantoni/formtastic-bootstrap/issues/118, which has been fixed, but the gem is still awaiting a new release (https://github.com/mjbellantoni/formtastic-bootstrap/issues/124)

Done! https://rubygems.org/gems/formtastic-bootstrap/versions/3.1.1

Thanks!


Handle dynamic URLs at sitemap.xml

Per title.

Somewhat addressed at https://github.com/cansin/next-with-sitemap/commit/69a208c6dc7fd9e3b2b4ddf49016879def60ea2a through exportPathMap Next.js config.


Duplicated @media rules not being removed

@media (max-width:767px) {
#header{position:fixed}
.class_a{display:none}
}
@media (max-width:767px) {
#header{position:fixed}
.class_b{background-size:150px}
}
Expected:
@media (max-width:767px) {
#header{position:fixed}
.class_a{display:none}
}
@media (max-width:767px) {
.class_b{background-size:150px}
}

Make sure your optimization level is set to 2 as it is now level 1 by default.

I have a similar issue with media styles. Duplicates are not removed when the existing properties are found between two media queries.
Tested on https://jakubpawlowicz.github.io/clean-css/.
Here is a file1. Duplicates are not removed:
@media only screen and (max-width:767px) {
    .breadcrumbs {
        padding-left: 15px;
        padding-right: 15px
    }
    .header {
        position: relative;
    }
}
.fieldset {
    padding: 0;
}
@media only screen and (max-width:767px) {
    .breadcrumbs {
        padding-left: 15px;
    }
    .header {
        position: relative;
    }
}

Here is a file2. Duplicates are removed:
@media only screen and (max-width:767px) {
    .breadcrumbs {
        padding-left: 15px;
        padding-right: 15px
    }
    .header {
        position: relative;
    }
}
.fieldset {
    margin: 0;
}
@media only screen and (max-width:767px) {
    .breadcrumbs {
        padding-left: 15px;
    }
    .header {
        position: relative;
    }
}

Won't fix as clean-css is going into maintenance mode.