gitignore env file

ignore annoying file

Codecov Report

Merging #273 (8f92ea9) into main (24addab) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   85.93%   85.93%
=======================================
  Files          85       85
  Lines        1920     1920
=======================================
  Hits         1650     1650
  Misses        270      270


Feed2Catalog doesn't appear to block if package download fails.

Per Application Insights trace logs the Feed2Catalog job was failing consistently on a nonexistent package.
Unable to download: http://int.nugettest.org/api/v2/package/DuplicatePushesAreRejectedAndNotDeleted.636263222102712356/1.0.0. Http status: NotFound

This was a test package created by a functional test.  The package did not exist intentionally.
However, the rest of the pipeline appeared to ignore this failure and continue.

This is a desired behavior.


Fix connection counting

As mentioned in #65, after a reset of the statistics the connection count jumps to the combined amount of users in channels, this is incorrect since they should be counted by their connection (in our case we use the socket id which is unique per connection) because users can be in multiple channels causing the connection count to be very inaccurate in case a lot of channels are used.

I added a some tests for this (skipped other statistic tests for now to keep the PR small).
While doing this I noticed they connection count is incorrect when the clients are connected but not subscribed to a channel. But that can be fixed later too (this is not new with this PR but the current behaviour).

@mpociot it would be greatly appreciated if this bug can be resolved or I could get some feedback if this PR is something you don't want to accept 👍

This pull request helps a lot when limiting the number of connections per application! It needs to be merged ASAP!. Thanks @stayallive

Thank you very much for the PR and your patience :)


Fix the ThemeData.copyWith toggleButtonsTheme argument type

Simple fix for the toggleButtonsTheme type of the ThemeData.copyWith method.
Related Issues
see #40992

Thanks for the contribution! We should really be writing a test or two to prevent https://github.com/flutter/flutter/issues/40992 from occurring again. Would you be willing to take that on?

My pleasure !
Here a first test, a ThemeData.copyWith test passing all arguments and verifying if all values are correctly set in the returned instance : https://github.com/flutter/flutter/pull/40994/commits/6553ce498dfabac47387e42d96daf2c1aebe8f37
Should I add more tests ?

Seems to still be failing the analyze test because of whitespace at the end of some of your lines. Make sure that this passes [and all failing tests after, if any]
▌06:59:13▐ ELAPSED TIME: 0.019s for grep --line-number --extended-regexp [[:blank:]]$ packages/flutter/lib/src/material/theme_data.dart packages/flutter/test/material/theme_data_test.dart in .
Whitespace detected at the end of source code lines.

I fixed the analyzer step. Now the 3 failings steps seems not related to my MR.

All green !

@rxlabz Thank you for the contribution! I just merged :)


NoLearn 0.7 requires scipy 0.16,  but Theano 0.8 & Lasagne 0.2 require scipy 0.17

Building wheels or conda packages based on this master branch (0.7 version) results in a downgrade of scipy and that may break Theano or Lasagne.

We should update the requirements list to newer version.  I'm curious though, where do Theano and Lasagne say they require scipy 0.17?

The only place I can find saying that Theano requires Scipy is here, and it only needs scipy >= 0.11. Lasagne only seems to require scipy through Theano.

Interesting. And Theano try/excepts the scipy import, accepting versions all the way back to 0.7:
try:
	    import scipy
	    scipy_ver = [int(n) for n in scipy.__version__.split('.')[:2]]
	    enable_sparse = bool(scipy_ver >= [0, 7])

But when you pip install Theano it installs the most recent scipy. And theano works well with the most recent scipy sparse matrices. So installing the most recent scipy with a >= probably makes sense for nolearn too. Since theano isn't maintaining/testing a version that hard-depends, with ==, on an older scipy version.

@hobson The use of requirements.txt is pretty much optional.  You can pip install nolearn (e.g. pip install . within a Git checkout) and it won't require any specific version of scipy since the list of dependencies in setup.py isn't pinned.

Yea, thank you. I have no problem on my environment. I just ran into this
trying to build conda packages for code school students on Windows. Not an
issue for you or most of your users, I'm sure. Theano never worked well on
Windows for them anyway (g++ compiler, etc).
--Hobson
(503) 974-6274
gh https://github.com/hobson/ twtr https://twitter.com/hobsonlane li
https://www.linkedin.com/in/hobsonlane g+
http://plus.google.com/+HobsonLane/ so
http://stackoverflow.com/users/623735/hobs
On Fri, Mar 25, 2016 at 10:00 AM, Daniel Nouri<EMAIL_ADDRESS>wrote:

@hobson https://github.com/hobson The use of requirements.txt is pretty
much optional. You can pip install nolearn (e.g. pip install . within a
Git checkout) and it won't require any specific version of scipy since the
list of dependencies in setup.py isn't pinned.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/dnouri/nolearn/issues/222#issuecomment-201363840

OK I'll close this issue since doing pip install Theano and pip install<EMAIL_ADDRESS>will just work.  Let me know if I misunderstood, or if there's anything else we can do in nolearn to support your use case better.

You're right. Your pip install order upgraded scikitlearn from 17.0 for
Theano to 17.1 for nolearn. Thanks.
--Hobson
(503) 974-6274
gh https://github.com/hobson/ twtr https://twitter.com/hobsonlane li
https://www.linkedin.com/in/hobsonlane g+
http://plus.google.com/+HobsonLane/ so
http://stackoverflow.com/users/623735/hobs
On Fri, Mar 25, 2016 at 11:54 AM, Daniel Nouri<EMAIL_ADDRESS>wrote:

OK I'll close this issue since doing pip install Theano and pip install
<EMAIL_ADDRESS>will just work. Let me know if I misunderstood, or if there's anything else
we can do in nolearn to support your use case better.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/dnouri/nolearn/issues/222#issuecomment-201422974


feat: enable support for Terraform 1.1.3

Updating this module to work with Terraform versions up to, but not including, 1.3.0.

Hey @jim80net and @houqp, not able to request reviews but would love a review on this 🚀 Thanks in advance!

thanks @nbaec , I am wondering whether we should just pin it to 1.x and hope hashicorp doesn't introduce breaking changes within major release.


Improve code review check to account for diff author-committer usecase.

See
$ go run . --repo=https://github.com/protocolbuffers/protobuf --show-details --checks=Code-Review
Starting [Code-Review]
Finished [Code-Review]

RESULTS
-------
Code-Review: Pass 9
    found different author and committer for pr: 8053
    found different author and committer for pr: 8052
    found review approved pr: 8048
    found review approved pr: 8045
    found different author and committer for pr: 8043
    found review approved pr: 8035
    found review approved pr: 8032
    found review approved pr: 8030
    found review approved pr: 8029
    found review approved pr: 8028
    found review approved pr: 8026
    found review approved pr: 8025
    found review approved pr: 8024
    found review approved pr: 8023
    found review approved pr: 8022
    found different author and committer for pr: 8014
    found different author and committer for pr: 8013
    found review approved pr: 8011
    found review approved pr: 8010
    found review approved pr: 8006
    found review approved pr: 8005
    found different author and committer for pr: 8003
    found review approved pr: 8000
    found different author and committer for pr: 7997
    github code reviews found

Without this, this check fails, E.g. PR https://github.com/protocolbuffers/protobuf/pull/8052 , in github people are used to just committing without pressing the approve button. Thoughts ? This was pointed by Harvey (Envoy) in his doc as well.

FWIW, in Envoy we require approval before merging. Maybe we should ask Protobuf maintainers to put in place this check and the existing check is WAI?

FWIW, in Envoy we require approval before merging, GitHub can enforce this. Maybe we should ask Protobuf maintainers to put in place this check and the existing check is WAI?

Do you block merge and require explicit approval using https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/enabling-required-reviews-for-pull-requests. I want to be realistic here, we had enabled it on our three projects and there comes a time when someone has to merge a tiny fix, and this policy completely bricks it. So, most people would be disabling it or keep the default (disabled). In that case, people just press the "Merge pull request" directly (i do it too sometimes). I dont think we should penalize this. As long as someone is opening a pull request and then it gets committed by someone other than main author, it feels ok as a review. Thoughts @htuch ?

Yep, we do that. Why can't tiny fixes have a quick review? In Envoy, we will have approval/merge on almost everything; a subset of senior maintainers are able to override for situations that really demand it, but I'd say the vast, vast bulk of our PRs have an approval stamp prior to merge.
I agree with pragmatism; can we have some nuance in the scorecard here? I.e. "passes all PRs have approval stamp", "passes all PRs are merged by or reviewed by someone other than the author"? Maybe distinct checks?

@htuch - using --show-details shows the verbose mode and we can customize it to any message. Currently, it does show "found review approved pr: <pr_num>" and "found pr with committer different than author: <pr_num>" in details view on last 30 prs anaylzed.

Got it; one other consideration, we want to consume this data from a tool oriented flow; is it possible to get JSON/proto structured data? Making a distinction here without having to scrap via regex would be useful.

Got it; one other consideration, we want to consume this data from a tool oriented flow; is it possible to get JSON/proto structured data? Making a distinction here without having to scrap via regex would be useful.

yes --format=json exists, it was missing details field, so i just added it in latest patch.


LivingEntity#removeStatusEffect clarification

While the previous names were technically correct, they imply the most straightforward method you can call is the former removeStatusEffect. However, it seems to be an internal method, which doesn't execute any cleanup/sync operation.
Most modders should call tryRemoveStatusEffect in every case.
This has caused confusion in a few mods already (example 1, example 2, example 3, example 4).

Nice catch


Power BI does not detect custom add-on

Power BI does not detect custom add-on
Followed the steps of changing XML creating and renaming the zip content to .Mez file.
And copy paste. as detailed below. However Power BI did not pick any add-on?

One check: The connector is not signed and hence requires to lower the security level. Have you checked this?

Problem solved. I was putting zipped content in PowerBI program file folder. Once I moved activity to My Documents folder , it worked.ThxSent from my iPhoneOn 29 Nov 2023, at 17:47, OlafFischer @.***> wrote:
One check: The connector is not signed and hence requires to lower the security level. Have you checked this?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Glad to hear that you could resolve the issue. Closing this thread.


Add helm and kubectl

This adds kubectl 1.29.2 and helm3 to the deployment image for k8 and helm related functionality.

Should we update to node-20 while you're changing this?

I feel like we might want to wait until everything is node 20 or maybe with another PR


Weights to run inference locally and/or training code

Great work!
I couldn't locate the training code, is it not uploaded?

Would you be sharing the trained weights to run inference locally?

+1


Fix global session use

Transfer the responsibility for the application to either specify a session, or choose to use the defaults stored in settings.

closed with 8f81effc


Building cartographer_rviz fails on NVIDIA Jetson TX1

==> ninja -j4 -l4 in '/home/syler/google_ws/build_isolated/cartographer_rviz'
ninja: error: '/usr/lib/arm-linux-gnueabihf/libopencv_videostab.so.2.4.8', needed by '/home/syler/google_ws/devel_isolated/cartographer_rviz/lib/libcartographer_rviz_submaps_visualization.so', missing and no known rule to make it
<== Failed to process package 'cartographer_rviz':
  Command '['/home/syler/google_ws/install_isolated/env.sh', 'ninja', '-j4', '-l4']' returned non-zero exit status 1

Reproduce this error by running:
==> cd /home/syler/google_ws/build_isolated/cartographer_rviz && /home/syler/google_ws/install_isolated/env.sh ninja -j4 -l4

Command failed, exiting.

I have OpenCV4Tegra (2.4.12) installed. I followed the steps in ROS – Hacking for OpenCV on Nvidia Jetson TX1 & Jetson TK1 to change the OpenCV search path forimage_geometry and cv_bridge to the appropriate directories (/usr/lib instead of /usr/lib/arm-linux-gnueabihf) but got a different error when trying to build:
==> ninja -j4 -l4 in '/home/syler/google_ws/build_isolated/cartographer_rviz'
[3/16] Automoc for target drawable_submap
Generating moc_drawable_submap.cpp
[6/16] Automoc for target submaps_display
Generating moc_submaps_display.cpp
[10/16] Building CXX object cartographer_rviz/CMakeFiles/submaps_display.dir/submaps_display.cc.o
FAILED: /usr/bin/c++   -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DROSCONSOLE_BACKEND_LOG4CXX -DROS_PACKAGE_NAME=\"cartographer_rviz\" -O3 -DNDEBUG -fPIC -isystem /usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem /usr/include/qt4/QtCore -isystem /home/syler/google_ws/install_isolated/include -isystem /opt/ros/indigo/include -isystem /usr/include/eigen3 -isystem /usr/include/OGRE -isystem /usr/include/opencv -isystem /usr/include/lua5.2 -I. -I/home/syler/google_ws/src/cartographer_ros/cartographer_rviz -I/home/syler/google_ws/src/cartographer_ros/cartographer_rviz/cartographer_rviz     -pthread -std=c++11  -Wall -Wpedantic -Werror=format-security -Werror=missing-braces -Werror=reorder -Werror=return-type -Werror=uninitialized -O3 -DNDEBUG -MMD -MT cartographer_rviz/CMakeFiles/submaps_display.dir/submaps_display.cc.o -MF "cartographer_rviz/CMakeFiles/submaps_display.dir/submaps_display.cc.o.d" -o cartographer_rviz/CMakeFiles/submaps_display.dir/submaps_display.cc.o -c /home/syler/google_ws/src/cartographer_ros/cartographer_rviz/cartographer_rviz/submaps_display.cc
c++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-4.8/README.Bugs> for instructions.
[10/16] Building CXX object cartographer_rviz/CMakeFiles/submaps_display.dir/submaps_display_automoc.cpp.o
ninja: build stopped: subcommand failed.
<== Failed to process package 'cartographer_rviz':
  Command '['/home/syler/google_ws/install_isolated/env.sh', 'ninja', '-j4', '-l4']' returned non-zero exit status 1

Reproduce this error by running:
==> cd /home/syler/google_ws/build_isolated/cartographer_rviz && /home/syler/google_ws/install_isolated/env.sh ninja -j4 -l4

Command failed, exiting.

c++: internal compiler error: Killed (program cc1plus)

You have a crash in your compiler. Sorry, that is out of scope for Cartographer. Maybe try a different compiler version? Or you are running out of memory in the compiler, could also be.

@5yler
hi , i also got this error，Have you solved the error？

Looks like you are running out of ram.
Check top (or htop) to find out how much memory you are using when the compiler errors.
You might want to try adding a swap file/disk, I use a usb pendrive with a swap partition.
It is not the fastest, but it does let it build on low(er) memory systems.

@carl1218 @SirVer I went through the ROS – Hacking for OpenCV on Nvidia Jetson TX1 & Jetson TK1 guide again and double-checked that I made all the necessary modifications:
sudo cp /opt/ros/indigo/lib/pkgconfig/cv_bridge.pc /opt/ros/indigo/lib/pkgconfig/cv_bridge.pc-bak
sudo cp /opt/ros/indigo/lib/pkgconfig/image_geometry.pc /opt/ros/indigo/lib/pkgconfig/image_geometry.pc-bak
sudo cp /opt/ros/indigo/share/cv_bridge/cmake/cv_bridgeConfig.cmake /opt/ros/indigo/share/cv_bridge/cmake/cv_bridgeConfig.cmake-bak
sudo cp /opt/ros/indigo/share/image_geometry/cmake/image_geometryConfig.cmake /opt/ros/indigo/share/image_geometry/cmake/image_geometryConfig.cmake-bak
sudo gedit /opt/ros/indigo/lib/pkgconfig/cv_bridge.pc &
sudo gedit /opt/ros/indigo/lib/pkgconfig/image_geometry.pc &
sudo gedit /opt/ros/indigo/share/cv_bridge/cmake/cv_bridgeConfig.cmake &
sudo gedit /opt/ros/indigo/share/image_geometry/cmake/image_geometryConfig.cmake &

Modifications for each file

remove each instance “/usr/lib/arm-linux-gnueabihf/libopencv_ocl.so.2.4.8;“
replace each instance of “/usr/lib/arm-linux-gnueabihf/” with “/usr/lib“
replace each instance of “2.4.8” with “2.4.12” (or the current version of OpenCV in opencv4tegra package)

I think I must have missed something the previous time I tried, as the build just completed successfully!

@5yler . it is very strange, In my system there is no such file about cv_bridge.pc.  You are using the Ubuntu 64 bit system or 32 bit？

@carl1218 The NVIDIA Jetson is ARM-based, so neither 32 not 64 bit. See 32-bit vs 64-bit vs ARM in regards to programs and OSes on unix.stackexchange.com. You may want to open a separate issue, since it appears my problem was specific to the OpenCV library linking with NVIDIA's non-standard OpenCV4Tegra distribution that led to problems.

@SirVer Could you tell me why cartographer does not support arm32?
My platform is  Ubuntu 14.04.3 LTS (GNU/Linux 3.4.39 armv7l),  CPU is ARMv7 Processor rev 5 (v7l). I want to try run cartographer on my platform.  I want to know what exactly wrong and  what should I do to achieve my purpose?  Thanks!

@ZhiyuLiu1993 Cartographer is only tested on 64bit hardware (see the CI runs), so it might work on 32bit arm, but there is neither guarantee nor verification that it does. It might.
For example, we know that Eigen requires alignment macros for 32bit systems which last time I checked Cartographer had not in place. So it might not work.

@SirVer Thank you for your answer. I will try it on the 64-bit arm in the future.


ADR for ejecting app from Create React App

This was started from the proof of concept in these two different PRs.

transcom/mymove#9825
transcom/mymove#9812

The idea behind this ADR is to focus on speeding up the client build for the
React application. This has been discussed a few times in 2022 and is being
revisited in 2023.
More information to come to this description soon ...

I'm closing but not deleting this PR since lots has changed in the idea of ejecting the MilMove client app from CRA. I think it's still valuable to discuss this and try to eject before we consider a larger refactor like a migration to NextJS or something similar like ViteJS, but for now we can close this PR.


Add indication in cassandra.yaml that rpc timeouts going too high wil…

…l cause memory build up

CI 3.11


bugfix 1.9a maximize current pane

bugfix 1.9a maximize current pane

I won't accept this pull request.
The .tmux.conf.local file in the repository is meant to be an example file. Each user is supposed to create its own ~/.tmux.conf.local and add its own settings. This is not the place to fix a broken feature. However, if you really decide you prefer stock's maximize pane feature (resize-pane -Z) instead of my enhanced maximize pane feature then yes you're totally entitled to add bind + resize-pane -Z to your own ~/.tmux.conf.local
I can only make guesses about what made you open this pull request in the first place: I believe you're running the official tmux 1.9a which crashes when using the swap-pane command (as noted at the beginning of README.md). In that case, yes <prefix>+ won't maximize the current pane and will warn you about your buggy tmux. From there, if you still want to use my enhanced maximize pane feature, your best bet is to compile tmux from source:

I gave an example here on how to compile tmux for Linux
for Mac, it's as easy as brew uninstall tmux; brew install --HEAD tmux

For those coming directly to this pull request through a Google search: the enhanced maximize pane feature scripted by this .tmux.conf allows you to further splits maximized panes into sub panes and at any time minimize back the maximized pane to its original place / window. In comparison, stock maximize pane (resize-pane -Z) exhibits a temporary nature.
Finally, I'll think about your idea of "degrading" to stock maximize pane (resize-pane -Z) in case I detect a buggy tmux 1.9a. But the fix would totally happen in implementation of the maximize_pane script that's inside .tmux.conf.
Cheers!

I see. You are right.
How to close this pull request?
Thanks.

I'll leave it open for a while as it sheds some light on the enhanced maximize pane feature.
Out of curiosity, did you bother compiling tmux from source or installing it with brew install --HEAD tmux since reading my reply?

I tried it in Mac. It's same to this:

Then yes if you prefer the builtin maximize pane feature (resize-pane -Z) the way to go is to add bind + resize-pane -Z in your ~/.tmux.conf.local

I think if the commond (resize-pane -Z) can change the name of pane will be better.
If status is maximize, so add a suffix to the pane's name.


Feature: Add Color Cycle application specification

Add Color Cycle application specification
Resolves: N/a
See also: N/a

Thank you @jdmedlock for your hard work!


Fixes WorldContext not being set during Async

Async delegates do not have WorldContext set causing errors for anything that requires it, this PR fixes that.

Thank you for the PR ⭐ !


localhost in TopicArn does not work

Hi,
I found that the lambda function subscribing offline-sns works well if TopicArn uses us-east-1 for region but does not work for localhost. Since offline-sns meant work locally, I think localhost should work. What do you think?
The following is the example from serverless-offline-sns-example.
[What works]
sns.publish({
Message: "hello!",
MessageStructure: "json",
TopicArn: "arn:aws:sns:us-east-1:123456789012:test-topic",
}
[What not work]
sns.publish({
Message: "hello!",
MessageStructure: "json",
TopicArn: "arn:aws:sns:localhost:123456789012:test-topic",
}
Thanks!

Hi there!
Thanks again for an interesting report.
I’ll have a look, but I think the SNS library only accepts legitimate AWS regions.
The pattern I’ve used in the past is to always keep the same region you’re deploying to.
If it doesn’t work with say eu-West-1 I will definitely want to fix that. It could be the same fix for both.

I was thinking the use case like setting AWS_REGION in local in env.yml. Then use it for offline-sns and local Dynamo and so on for local testing.

Yea I'm not sure if that's a recommended approach. I will take a look now

Ok I've just published 0.28.
If you set your region in serverless.yml, the SNS listener will also use that region. This includes localhost.
See here for an example - https://github.com/mj1618/serverless-offline-sns-example/tree/arbitrary-regions
It originally didn't allow any non-us-east region so it was worth fixing.

It works as a charm. Thank you so much for your support!


Specify a location in "Done compiling" messages

Fixes https://github.com/sbt/sbt/issues/3939, which was closed without comment a while back.
In a multi-module build, the "Done compiling" messages can feel spammy and uninformative - this change makes them correspond to the "Compiling..." message that's printed out when compilation starts.

Yeah, we also have our own thing in bloop. So let's close this ticket, thanks for looking into this anyway @ewiner  :smile:

I still think these messages would be useful in the CI logs, and I don’t see why it conflicts or messes up neither bloop nor super shell.

I have another PR here that'll hide only for super shell - https://github.com/sbt/zinc/pull/646


These status codes should show up in the grants modal alongside the list of "Interested" and "Rejected" Statuses

Hey @mhuang-usdr , here's what the new dropdown looks like with the Result options added

@slants3 thanks! I dropped my comments in the PR

@slants3 can this be closed?

Yup! Closing


Training time is faster in beginning

I train my custom dataset with YOLOP with tesla V100, I found that it training speed is very fast in first but it will get slow after 40 times. May I ask if this is normal or I ignore some settings? Thanks for any suggestions.
Epoch: [5][0/808]       Time 7.420s (7.420s)    Speed 6.5 samples/s     Data 5.233s (5.233s)    Loss 0.40308 (0.40308)
Epoch: [5][20/808]      Time 113.373s (60.213s) Speed 0.4 samples/s     Data 111.287s (58.143s) Loss 0.43158 (0.41728)
Epoch: [5][40/808]      Time 226.024s (115.841s)        Speed 0.2 samples/s     Data 223.994s (113.749s)        Loss 0.43076 (0.41315)
Epoch: [5][60/808]      Time 334.304s (170.884s)        Speed 0.1 samples/s     Data 332.240s (168.793s)        Loss 0.39735 (0.41089)
Epoch: [5][80/808]      Time 448.564s (226.228s)        Speed 0.1 samples/s     Data 446.482s (224.125s)        Loss 0.40302 (0.40986)
Epoch: [5][100/808]     Time 561.691s (281.968s)        Speed 0.1 samples/s     Data 559.411s (279.865s)        Loss 0.39656 (0.40988)

I had the same question. I noticed that this occurred both with a pre-trained model and training from scratch, so I assume it has something to do with the way training is set up/memory. Though wasn't sure exactly why it is happening or if its something that can be optimized.

Seems the code calculate time taken of data_time and batch_time with time.time() - start.
https://github.com/hustvl/YOLOP/blob/d37e600cf71ecac20b08865ddfe923d76fd02d55/lib/core/function.py#L48-L95
reseting start with time.time() at the end of for i, (input, target, paths, shapes) in enumerate(train_loader): seems right.
here is my example output when corrected.
Epoch: [1][265/1459]    Time 0.979s (1.027s)    Speed 49.0 samples/s    Data 0.000s (0.015s)    Loss 0.63933 (0.65864)
Epoch: [1][266/1459]    Time 0.981s (1.026s)    Speed 48.9 samples/s    Data 0.000s (0.015s)    Loss 0.65143 (0.65861)
Epoch: [1][267/1459]    Time 0.968s (1.026s)    Speed 49.6 samples/s    Data 0.000s (0.015s)    Loss 0.64569 (0.65857)
Epoch: [1][268/1459]    Time 0.980s (1.026s)    Speed 49.0 samples/s    Data 0.000s (0.015s)    Loss 0.65163 (0.65854)
Epoch: [1][269/1459]    Time 0.956s (1.026s)    Speed 50.2 samples/s    Data 0.000s (0.015s)    Loss 0.65266 (0.65852)
Epoch: [1][270/1459]    Time 0.953s (1.025s)    Speed 50.3 samples/s    Data 0.000s (0.015s)    Loss 0.64746 (0.65848)
Epoch: [1][271/1459]    Time 0.967s (1.025s)    Speed 49.6 samples/s    Data 0.000s (0.015s)    Loss 0.64903 (0.65844)
Epoch: [1][272/1459]    Time 0.961s (1.025s)    Speed 49.9 samples/s    Data 0.000s (0.015s)    Loss 0.65219 (0.65842)
Epoch: [1][273/1459]    Time 1.008s (1.025s)    Speed 47.6 samples/s    Data 0.000s (0.015s)    Loss 0.64192 (0.65836)
Epoch: [1][274/1459]    Time 0.968s (1.025s)    Speed 49.6 samples/s    Data 0.000s (0.015s)    Loss 0.64838 (0.65832)
Epoch: [1][275/1459]    Time 0.963s (1.025s)    Speed 49.8 samples/s    Data 0.000s (0.015s)    Loss 0.64337 (0.65827)
Epoch: [1][276/1459]    Time 0.976s (1.024s)    Speed 49.2 samples/s    Data 0.000s (0.015s)    Loss 0.64825 (0.65823)
Epoch: [1][277/1459]    Time 0.977s (1.024s)    Speed 49.1 samples/s    Data 0.000s (0.015s)    Loss 0.64206 (0.65817)
Epoch: [1][278/1459]    Time 0.971s (1.024s)    Speed 49.4 samples/s    Data 0.000s (0.015s)    Loss 0.64710 (0.65814)
Epoch: [1][279/1459]    Time 0.982s (1.024s)    Speed 48.9 samples/s    Data 0.000s (0.015s)    Loss 0.64195 (0.65808)
Epoch: [1][280/1459]    Time 0.971s (1.024s)    Speed 49.4 samples/s    Data 0.000s (0.015s)    Loss 0.64206 (0.65802)
Epoch: [1][281/1459]    Time 1.001s (1.024s)    Speed 48.0 samples/s    Data 0.000s (0.015s)    Loss 0.64064 (0.65796)
Epoch: [1][282/1459]    Time 1.008s (1.024s)    Speed 47.6 samples/s    Data 0.000s (0.015s)    Loss 0.64724 (0.65792)
Epoch: [1][283/1459]    Time 0.978s (1.023s)    Speed 49.1 samples/s    Data 0.000s (0.014s)    Loss 0.64849 (0.65789)
Epoch: [1][284/1459]    Time 1.036s (1.023s)    Speed 46.3 samples/s    Data 0.000s (0.014s)    Loss 0.64519 (0.65784)
Epoch: [1][285/1459]    Time 0.966s (1.023s)    Speed 49.7 samples/s    Data 0.000s (0.014s)    Loss 0.64414 (0.65780)
Epoch: [1][286/1459]    Time 0.966s (1.023s)    Speed 49.7 samples/s    Data 0.000s (0.014s)    Loss 0.64325 (0.65774)

Hi, can you provide your code of you sample output, thanks.

+Hi @junhocho, Can you provide the code to correct the output of the time, thanks for help


[HUDI-1016] [Minor] Code optimization

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request

Code optimization in MergeOnReadRollbackActionExecutor

Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #1718 into master will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #1718   +/-   ##
=========================================
  Coverage     18.21%   18.21%
  Complexity      859      859
=========================================
  Files           348      348
  Lines         15356    15356
  Branches       1523     1523
=========================================
  Hits           2797     2797
  Misses        12201    12201
  Partials        358      358

Impacted Files
Coverage Δ
Complexity Δ

...on/rollback/MergeOnReadRollbackActionExecutor.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cd824...252ecf0. Read the comment docs.


Not ignoring git by default

Even though it says it is ignoring the .git directory, it still gives me errors when trying to sync that directory
$ docker-osx-dev
2015-06-25 08:35:01 [INFO] Using sync paths from Docker Compose file at docker-compose.yml: .
2015-06-25 08:35:01 [INFO] Complete list of paths to sync: /Users/saul/projects/django-report-builder
2015-06-25 08:35:01 [INFO] Using default exclude paths: .git
2015-06-25 08:35:01 [INFO] Complete list of paths to exclude: .git
2015-06-25 08:35:01 [INFO] Starting docker-osx-dev file syncing
2015-06-25 08:35:02 [INFO] Installing rsync in the Boot2Docker image
2015-06-25 08:35:02 [INFO] Performing initial sync of paths: /Users/saul/projects/django-report-builder
2015-06-25 08:35:02 [INFO] Warning: Permanently added 'dockerhost,<IP_ADDRESS>' (RSA) to the list of known hosts.
2015-06-25 08:35:02 [INFO] Initial sync done
2015-06-25 08:35:02 [INFO] Watching: /Users/saul/projects/django-report-builder
2015-06-25 08:35:08 [INFO] rsync: link_stat "/Users/saul/projects/django-report-builder/.git/index.lock" failed: No such file or directory (2)

Can you enable debug logging when you run docker-osx-dev so we can see the exact rsync command being used?
docker-osx-dev -l DEBUG

$ docker-osx-dev -l DEBUG
2015-06-26 11:42:57 [INFO] Using default sync paths: .
2015-06-26 11:42:57 [INFO] Complete list of paths to sync: /Users/saul/projects/caido
2015-06-26 11:42:57 [INFO] Using default exclude paths: .git
2015-06-26 11:42:57 [INFO] Complete list of paths to exclude: .git
2015-06-26 11:42:57 [INFO] Starting docker-osx-dev file syncing
2015-06-26 11:42:57 [INFO] Installing rsync in the Boot2Docker image
2015-06-26 11:42:57 [INFO] Performing initial sync of paths: /Users/saul/projects/caido
2015-06-26 11:42:57 [DEBUG] Creating parent directories in Docker VM: sudo mkdir -p /Users/saul/projects && sudo chown -R docker /Users/saul/projects
2015-06-26 11:42:58 [DEBUG] rsync --archive --log-format 'Syncing %n: %i' --delete --omit-dir-times --inplace --whole-file --exclude .git --rsh="ssh -i /Users/saul/.ssh/id_boot2docker -o StrictHostKeyChecking=no" /Users/saul/projects/caido docker@dockerhost:/Users/saul/projects
2015-06-26 11:42:58 [INFO] Warning: Permanently added 'dockerhost,<IP_ADDRESS>' (RSA) to the list of known hosts.
2015-06-26 11:42:58 [INFO] Initial sync done
2015-06-26 11:42:58 [INFO] Watching: /Users/saul/projects/caido
2015-06-26 11:42:58 [DEBUG] fswatch -0 /Users/saul/projects/caido
2015-06-26 11:43:15 [DEBUG] rsync --archive --log-format 'Syncing %n: %i' --delete --omit-dir-times --inplace --whole-file --exclude .git --rsh="ssh -i /Users/saul/.ssh/id_boot2docker -o StrictHostKeyChecking=no" /Users/saul/projects/caido/README.md docker@dockerhost:/Users/saul/projects/caido
2015-06-26 11:43:15 [INFO] Syncing README.md: <f..t....
2015-06-26 11:43:15 [DEBUG] rsync --archive --log-format 'Syncing %n: %i' --delete --omit-dir-times --inplace --whole-file --exclude .git --rsh="ssh -i /Users/saul/.ssh/id_boot2docker -o StrictHostKeyChecking=no" /Users/saul/projects/caido/.git/index.lock docker@dockerhost:/Users/saul/projects/caido/.git
2015-06-26 11:43:15 [INFO] rsync: link_stat "/Users/saul/projects/caido/.git/index.lock" failed: No such file or directory (2)
2015-06-26 11:43:15 [INFO] rsync error: some files could not be transferred (code 23) at /SourceCache/rsync/rsync-45/rsync/main.c(992) [sender=2.6.9]
2015-06-26 11:43:15 [DEBUG] rsync --archive --log-format 'Syncing %n: %i' --delete --omit-dir-times --inplace --whole-file --exclude .git --rsh="ssh -i /Users/saul/.ssh/id_boot2docker -o StrictHostKeyChecking=no" /Users/saul/projects/caido/.git/index docker@dockerhost:/Users/saul/projects/caido/.git
2015-06-26 11:43:15 [INFO] Syncing index: <f+++++++

OK, I'm seeing the same error locally, but I'm stumped as to why. Here's the shortened version of the rsync command:
rsync --exclude .git /Users/saul/projects/caido/.git/index.lock docker@dockerhost:/Users/saul/projects/caido/.git

Shouldn't that exclude the .git folder, or am I not understanding correctly how rsync does excludes?

Just guessing here, but maybe --exclude only applies to files/folders below the sync root. So if I was rsyncing the whole directory then it would exclude git. But since you are rsyncing a file inside the git directory, it doesn't exclude it...
Do you think that makes any sense?

If that was true, you could either sync the whole directory the whole time, or interpret the exclude yourself, before sending to rsync.

Also may not be worth it to try to fix this, since #22 seems like it would be preferable anyway.

Ah, actually, the code should be trying to sync the whole directory, not the individual files that changed. Looks like there is a bug in the find_path_to_sync_parent function. I'll look into that a little later today.

OK, I think the bug is fixed. Copy the new docker-osx-dev script from GitHub into your /usr/local/bin and see if it works.

@brikis98 yep works great now.
Thank you for maintaining this library.


User data stream not working intermittently.

The userdata stream does not work some times. The main problem is, we dont get any error message from the server to identify the disconnect. Suddenly things start failing and nothing works. Can you please suggest a fix for this?
I dont see any error response from the server to handle this case.

Hey guys, I'm having similar issues, where Binance uds stops sending me any messages after running for a few hours. I have tried force re-connecting every minute too but seems like I still get a period of no messages from the websockets even though connection looks alive and responds to pings.
I am also running multiple pairs for market data websocket and multiple uds sockets since I have different programs using the UDS. Could the issue be related to starting more than a single UDS for the same account? @juansolana did you manage to solve your issue?

Looks like the issue is caused by multiple application instances listening user data stream for the same user account. I tried running several instances and I constantly had this issue. Single running instance have worked fine for 2 weeks already.

My observations from using this websocket are mixed. Sometimes it works fine for days, sometimes does not. If you use 2 applications using the same api key, only the last connected will receive updates indeed. But often this socket won't send you any updates anymore. I have an "order status listener" that uses both this socket and a polling mechanism to just query the statuses of orders periodically.

Hi guys, did anybody comes with an answer about multiple application instances listening user data stream ? I am experiencing same issue . Thank you.

request new listen key on the new instance.

Thanks for your reply ! I might be wrong, but do you have any example of
piece of code where a new listen key is requested ?
Le dim. 31 juil. 2022 à 17:57, zhenpingfeng @.***> a
écrit :

request new listen key on the new instance.
—
Reply to this email directly, view it on GitHub
https://github.com/sammchardy/python-binance/issues/119#issuecomment-1200461558,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEXHDLNWMOG5QQ3T5N5FTDDVW2V63ANCNFSM4ELYW7AA
.
You are receiving this because you commented.Message ID:
@.***>

--
Romeo Adjovi
M.A. in Applied Statistics and Economics, Data Scientist


Add the ability to add imagePullSecrets to deployments

Description of the bug:

Add the ability to use private registry credentials when creating a deployment..
Reproduction Steps:

Error Log:

No error message, just no options/documentation to add imagePullSecrets
Environment:

Framework Version:
OS:

Other:

This is :bug: Bug Report

This was user error lol, burred in the api reference you can find image_pull_secret :)

It doesn't look like PodSpec is used in Deployment.

ok its not named correctly (IMO), but there is a parameter called dockerRegistryAuth that takes an ISecret which correctly added an imagePullSecret to the deployment!
const deployment = new kplus.Deployment(this, 'Deployment', {
  metadata: {
    name: 'secure-deployment',
  },
  dockerRegistryAuth: kplus.Secret.fromSecretName(this, 'ecr-secret', 'ecr-secret'),
});

Yikes, that's well hidden. But works, thanks @clayrosenthal!


bin: added the client.rb script

This script is quite handy when debugging the RegistryClient class.

LGTM, just fix the issue with the tests

That's fixed on master (it was a problem unrelated to this commit)


Add OpenDyslexic font as alternative user setting

Resolves #1606

Can one of the admins verify this patch?

@ewpatton I removed the unused OpenDyslexic files, they must have been there from when I started working from #1639.  I also resolved the other issues that were present.


TG-1700: Add a new designed icon for apps/projects

TG-1700

Once package.json has a meaningful value for description, yarn auto-gen && yarn prettier --write . will fix all issues.


Update test framework to use mstest 2 which will hopefully give us less issues.

I have had multiple issues with the ms test adapter and came across this blog post:  https://blogs.msdn.microsoft.com/visualstudioalm/2016/06/17/taking-the-mstest-framework-forward-with-mstest-v2/
I had a go at upgrading it and turns out it's really easy!
Should be a quick review @tomkuijsten :)

Cool.


497: Switch to Rule IDs from Guidelines, Part 1

Related to #497

Codecov Report

Merging #504 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #504     +/-   ##
===========================================
+ Coverage     82.44%   82.54%   +0.1%
+ Complexity      909      895     -14
===========================================
  Files           145      133     -12
  Lines          2204     1931    -273
  Branches        275      272      -3
===========================================
- Hits           1817     1594    -223
+ Misses          257      219     -38
+ Partials        130      118     -12

Impacted Files
Coverage Δ
Complexity Δ

...zalando/zally/rule/Use429HeaderForRateLimitRule.kt
77.77% <100%> (+1.3%)
16 <1> (ø)
:arrow_down:

...a/de/zalando/zally/rule/NoUnusedDefinitionsRule.kt
79.06% <100%> (+0.49%)
45 <0> (ø)
:arrow_down:

...n/java/de/zalando/zally/rule/NoVersionInUriRule.kt
100% <100%> (ø)
9 <1> (ø)
:arrow_down:

...java/de/zalando/zally/rule/NoProtocolInHostRule.kt
100% <100%> (ø)
8 <0> (ø)
:arrow_down:

.../main/java/de/zalando/zally/rule/MediaTypesRule.kt
92.85% <100%> (+0.54%)
20 <1> (ø)
:arrow_down:

...alando/zally/rule/LimitNumberOfSubresourcesRule.kt
90.9% <100%> (+0.9%)
16 <1> (ø)
:arrow_down:

...alando/zally/rule/NestedPathsMayBeRootPathsRule.kt
81.81% <100%> (+1.81%)
11 <1> (ø)
:arrow_down:

...java/de/zalando/zally/rule/AvoidLinkHeadersRule.kt
100% <100%> (ø)
7 <1> (ø)
:arrow_down:

...ava/de/zalando/zally/rule/DefineOAuthScopesRule.kt
91.66% <100%> (+0.23%)
29 <1> (ø)
:arrow_down:

...n/java/de/zalando/zally/rule/ExtensibleEnumRule.kt
70% <100%> (-1.8%)
39 <1> (-1)

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f9db36...85b2834. Read the comment docs.

what about AC: "An overview of automated rules is created (simple mapping RuleClassName <-> RuleId)"?

Hey @maschleg . This is only the first part of the ticket. More changes will come, including other ACs

👍

👍


The core.Logger#setLevel method should work like

The core.Logger#setLevel method should work like Configurator#setLevel #2281
@ppkarwasz
I'm not sure how to really test this from our 1.2 module but I did install a snapshot locally and tested it with my Apache Commons Logging branch here https://github.com/garydgregory/commons-logging/tree/log4j1-log42-api
The POM change to apache-rat-plugin was required for mvn clean verify to pass locally.

BTW: you should also add a file in src/changelog/.2.x.x.

I added tests but they fail. I can't tell if the issue is in main or the test itself...


crf

crf + Viterbi instead of CrossEntropyLoss for layoutlm TokenClassificationtask ,is it better?

@sunnyForIOS This is similar to BERT-CRF vs BERT. We did not observe significant gains by adding CRF on top of a pre-trained model like BERT.


add null check to fix app setting npe issue

Add null check to fix app setting npe issue

Codecov Report

Merging #905 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             develop    #905      +/-   ##
============================================
- Coverage      44.12%   44.1%   -0.02%
  Complexity       772     772
============================================
  Files            141     141
  Lines           5256    5258       +2
  Branches         751     752       +1
============================================
  Hits            2319    2319
- Misses          2765    2767       +2
  Partials         172     172

Impacted Files
Coverage Δ
Complexity Δ

.../microsoft/azure/maven/AbstractAppServiceMojo.java
40% <0%> (-6.16%)
0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdba8df...c37881b. Read the comment docs.


updated typo in the command scale missing hiphen

Proposed changes
fixed typo in the command scale for missing hyphen
in
https://docs.docker.com/compose/reference/scale/

Deploy preview for docsdocker ready!
Built with commit e90f0e58d8d22a1b669f3f82ee4d910440ac3828
https://deploy-preview-9897--docsdocker.netlify.com

This is deliberate; in this context, docker-compose scale web=2 worker=3 is correct, it's just deprecated. You're probably thinking of docker-compose up --scale, which is the current method: https://docs.docker.com/compose/reference/up/ .
I'll update the topic to make that note about deprecation pop a bit more.


Debugging feature: textual descriptions for parsers

I think it should be possible to generate a textual description of each parser. This will help when debugging, since you can print the description together with an error, and it can also be used to pretty print the parsers and generally understanding what’s happening in a complex program.
I was planning on doing this using emojis like in the README. I think they do a good job of separating different parts of the description visually.
The 🍕 emoji would indicate a building block parser (I think it’s a cute joke, and I couldn’t find anything better), and ⚙ might indicate combinators. Then an arrow ➜ could be used to further separate combinator inputs.
The idea is not to have a parseable format, just a way of pretty printing. So humans should be able to figure it out, but it can be a little ambiguous.
I wasn’t able to develop the format fully and I don’t know how it will look for complex parsers.
In fact, ideally, there should be several formats.
A full format which prints the whole structure of the parser.
A concise single-like format.

This came up in the discussion in https://github.com/GregRos/parjs/pull/64#issuecomment-1810698810

This might be (partially) implemented with .debug() which I implemented when I was working on the new math example.
// Built-in parser for floating point numbers.
const tupleElement = float();

// Allow whitespace around elements:
const paddedElement = tupleElement.pipe(between(whitespace()));
// Multiple instances of {paddedElement}, separated by a comma:
const separated = paddedElement.pipe(manySepBy(","));

// Surround everything with parentheses:
export const surrounded = separated.pipe(between("(", ")"), between(whitespace())).debug();
// ⬆ notice the .debug()

It prints something like this when you run the parser (for example in your tests):
      consumed '(1,  2 , 3 )' (length 12)
      at position 0->12
      👍🏻 (Ok)
      {
        "input": "(1,  2 , 3 )",
        "userState": {},
        "position": 12,
        "stack": [],
        "value": [
          1,
          2,
          3
        ],
        "kind": "OK",
        "reason": "expecting a character"
      }
      {
        "type": "map",
        "expecting": "expecting a character matching a predicate"
      }

It's not exactly what the idea was but it should be good for a low level, quick and dirty understanding. It was very useful for me.
I haven't documented this yet, so I'll still keep this open for now.

Forgot to mention that the best place to read about the .debug() feature is currently in the PR description here https://github.com/GregRos/parjs/pull/80


Files Auto-Scrolling Upwards and Resets Theme Selection to the Top-Right

Description
I noticed that a this issue also occasionally occurs for me in Windows's settings menu(s) where there's enough space to scroll; so, I think this might be related to UWP, considering that I don't have this issue with any other application(s), but I'm not sure.
Steps To Reproduce

Open Files
Click on settings
Go to Appearance
Open Custom Themes
Select any theme
Watch Files override the selection with Burgundy
Attempt to scroll down in the themes menu
Have the scrollbar scroll back up without consent and highlight Burgundy after doing so

Expected behavior

Honor the user-selected Theme selection
Don't scroll without user input

Files Version
Version: <IP_ADDRESS> OS Version: 10.0.19042.1526
Windows Version
Edition	Windows 10 Home Version	20H2 Installed on	12/7/2019 OS build	19042.1526 Experience	Windows Feature Experience Pack 120.2212.4170.0
Relevant Assets/Logs

debug.log
debug_fulltrust.log

@ThisNekoGuy is this still an issue in the preview version? http://files.community/download/preview

@yaichenbaum Sorry for being slow to respond, I had caught covid
I'm testing it right now and it doesn't seem to be happening but I'll let you know if I see it again

@yaichenbaum Sorry for being slow to respond, I had caught covid
I'm testing it right now and it doesn't seem to be happening but I'll let you know if I see it again

Thank you for the update, be well!


Unordered named recipe argument flags

Hi folks,
I couldn't find any open issue on this thingy, hence I'm creating this one now.
So far just seems to support only positional arguments to recipes from a callers perspective (! not the "positional arguments" feature). Meaning that the order of args passed to a recipe matters and there are no named flags designating the parameter to which an arg will be bound to. It's actually the most natural thing to pass args to a cli-tool via flags (e.g. tool --param arg) without caring about the order.
It would be extremely helpful, if just would support a feature like that. Why?
Well two things come into my mind at this point. First, for readability reasons. It happens sometimes, that a recipe has quite a few args and passing them in correct order without designating what which arg actually is might cause confusion and errors. Imagine some maintainer changes the order of args in a recipe for whatever reason. This would break a lot. The second reason is mainly about default values for args. A recipe may have a dozen args and all of them have default values, but you want to set the last one only. In this case one has to pass them all, just to make the change to the last one unambiguous.
How would a possible solution look like?
just should accept args passed to a recipe in a typical CLI manner using flags as designators, where the order of passed flags does not matter to the recipe, while still supporting the old positional behavior where no flag is given. Example:
# justfile
do-magic arg1="dust" arg2="dust.txt":
    echo {{ arg1 }} > {{ arg2 }}

# shell
just do-magic --arg1 "hello world" --arg2 test.txt
# or equivalently
just do-magic --arg2 test.txt --arg1 "hello world"
# or even
just do-magic --arg2 ash.txt
# or on steroids
just do-magic --arg2 out.txt "content"

In an more advanced implementation (future music), just could support short-hand flags to each arg. Example:
# justfile
recipe long_param(l):
    echo {{ long_param }}

# shell
just recipe --long_param hello
just recipe -l world

AFAICT, this feature would neither break compatibility to current syntax, nor change the behavior of current justfiles/scripts (well maybe autocompletion needs to be adjusted). I sadly do not have the time, or required rust-skills to take on work on this myself, but are definitely willing to support where I can.

I don't think this is a terrible idea, but there's actually an issue open for this, #476, so closing as a duplicate. Check out #476.
This would be a backwards incompatible change, since it's possible to pass flags as a recipe argument:
foo arg:
  echo {{arg}}

$ just foo --bar
echo --bar
--bar

The version proposed in #476 requires declaring that arguments will be accepted as a flag, so as to be backwards compatible:
foo --arg:


Add file.upload v2 support for slackUploadFile

What feature do you want to see added?
Recently, we are facing 408 timeout error when uploading large file with slackUploadFile.
Other sdks solved this issue by adopting file.upload v2 API.

java-slack-sdk -> https://github.com/slackapi/java-slack-sdk/pull/1065
python-slack-sdk -> https://github.com/slackapi/python-slack-sdk/pull/1272

Replacing slackUplaodFile to python-slack-sdk's files_upload_v2 solved our problem.
It would be wonderful if slack-plugin could support file.upload v2 API so that we do not need to use other sdk to upload files.
Upstream changes
No response

Interesting!
Contributions are very welcome if anyone is interested to do this.

Note: Slack announced that file.upload is now deprecated and will stop functioning next year on March 11, 2025.
The deprecation will also enter a new phase on May 8, 2024, in which newly created Slack apps will not be able to use file.upload API. Which means for users of the Jenkins plugin, that new users will not be able to use the slackUploadFile step. It should keep working for already existing configuration until full retirement of the API.
Full details on this changes: https://api.slack.com/changelog/2024-04-a-better-way-to-upload-files-is-here-to-stay

Thanks for the update @jviolas
I've ported the plugin to v2 in https://github.com/jenkinsci/slack-plugin/pull/961
Please test it out and give feedback, and @junseok-l2 I would be interested if large files work for you now.

@timja Thanks for the fast update 🤩
I just updated to the last version (711) and it doesn't seem to work for me. At first I thought it might be coming from the fact that I upload the file as a response in a Slack thread using the syntax #channelName:ts where ts is coming from the result of the slackSend step. I removed to just use the channelName, also tried using directly a slack channel ID, but nothing worked.
In the job build console logs, I only have 2 logs Using dirname=xxx and Adding file=xxxx and nothing else after that for this step. Not sure what else I can test. For info, just after the slackUploadFile step, I use an input step for some validation.

if you can provide a minimal reproducer I'll try reproduce it.

I've found 2 issues so far.

If you're including a # then remove it and it'll work (incoming fix)
Rate limiting is low for the conversations.list API needed for looking up channel IDs so a cache is needed

As for a minimal scenario to reproduce, I'm not sure how to do it.
In my case, my pipeline (a scripted pipeline), use the folowing steps:
def slackResponse = slackSend channel: '#notifs-changes', blocks: blocks

slackUploadFile channel: "#notifs-changes:${slackResponse.ts}", filePath: 'infraChanges.txt', initialComment: '*Full changes*:'

def inputResult = input message: "Do you want to deploy?", ok: 'OK', submitter: validatorEmails, submitterParameter: 'approvedBy'

Works for me:

(blocks are the sample one from the README)
node {
  sh "echo hey > blah.txt"

  def blocks = [
	[
		"type": "section",
		"text": [
			"type": "mrkdwn",
			"text": "Hello, Assistant to the Regional Manager Dwight! *Michael Scott* wants to know where you'd like to take the Paper Company investors to dinner tonight.\n\n *Please select a restaurant:*"
		]
	],
    [
		"type": "divider"
	],
	[
		"type": "section",
		"text": [
			"type": "mrkdwn",
			"text": "*Farmhouse Thai Cuisine*\n:star::star::star::star: 1528 reviews\n They do have some vegan options, like the roti and curry, plus they have a ton of salad stuff and noodles can be ordered without meat!! They have something for everyone here"
		],
		"accessory": [
			"type": "image",
			"image_url": "https://s3-media3.fl.yelpcdn.com/bphoto/c7ed05m9lC2EmA3Aruue7A/o.jpg",
			"alt_text": "alt text for image"
		]
	]
]

  def slackResponse = slackSend channel: '#slack-plugin-testing', blocks: blocks

  slackUploadFile channel: "#slack-plugin-testing:${slackResponse.ts}", filePath: 'blah.txt', initialComment: '*Full changes*:'

}

In the job build console logs

Have you checked the system logs?
Or a log recorder under jenkins.plugins.slack INFO

I can reproduce with a new app. Looking into it.

Add the groups:read scope

Yes ! that's it. channel:read was not enough (but channel is a public channel), with groups:read it's working.

Thanks for your help and again for the fast update of this plugins !!

Yes ! that's it. channel:read was not enough (but channel is a public channel), with groups:read it's working.

Yeah it also includes private channels in its lookup if its been added to them, annoyingly requires an extra scope.
This will give you a clear error message: https://github.com/jenkinsci/slack-plugin/pull/963

https://github.com/jenkinsci/slack-plugin/pull/965 will resolve the caching issue for larger workspaces.
On my one with 1900 channels its very easy to get rate limited, bit painful and slow to test as once you're rate limited you're stuck for a bit -.-.


docs: fix dead link in Spanish guide article

Fix residual link from the original English version that doesn't work in the Spanish documentation.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Reason: There is no more guide, so this file is not even needed anymore.
Thank you and happy coding.


version matching error

(I think). Maybe I misunderstood how it works though.
With various package dependencies I end up with the requirement:
html5lib!=0.9999,!=0.99999,<0.9999,>0.99999,>=0.90

I expected the current latest version 0.9999999 to match.
But none match:
Could not find a version that matches html5lib!=0.9999,!=0.99999,<0.9999,>0.99999,>=0.90
Tried: 0.2, 0.9, 0.10, 0.11, 0.11.1, 0.90, 0.95, 0.99, 0.999, 0.9999, 0.99999, 0.999999, 0.9999999, 1.0b1, 1.0b2, 1.0b3, 1.0b5, 1.0b6, 1.0b7, 1.0b8

ok, I see this can't match.


vc: Remove container share dir when stopping

Remove the rootfs bind dest and finally remove the created share directory when stopping the container.
Fixes #2516
Signed-off-by: Li Yuxuan<EMAIL_ADDRESS>

Nice find.... I thought we had a CI check that ensured Kata (vc) cleaned up all of its paths once we had deleted a pod/container - soooo, @GabyCT can you check that, and figure out why we were not catching this? And @darfux - maybe we can add some tests (unit tests in vc, and ideally some CI tests as well) to make sure :

this is working
we never break it in the future? ;-)

@grahamwhaley the PR looks good to me. It'd be better to have some feedback from @devimc @jcvenegas @amshinde for more accurate review.
About the question why our CI didn't catch this, I think that's because we do the proper cleanup at the pod level anyway. But I agree this PR makes sense.

Thanks @grahamwhaley @sboeuf @devimc . Updated log & added UT for bindUnmountContainerRootfs :)  And maybe the share dir case should be done in the tests repo?

/test

ubuntu-18-04-virtiofs  failed due to unexpected /opt/kata/bin/qemu-virtiofs-system-x86_64
ubuntu-18-04 , ubuntu-18-04-initrd and fedora-31 failed due to rpc error: code = Unavailable desc = transport is closing
podman failed due to ERROR: /tmp/jenkins/workspace/kata-containers-runtime-podman-fedora-31-PR/go/src/github.com/kata-containers/osbuilder/rootfs is not a directory
Could someone give me a hand to restart them 👀

Sure. I've re-scheduled all 5 that failed. That's quite a lot of fails, so let's check if they happen again, or if you were just very unlucky!

Thanks @grahamwhaley ! 4 of 5 cases are happy now but virtiofs still fails unluckily because of curl: (7) Failed to connect to <IP_ADDRESS> port 8080: Connection timed out 🤣

nudged virtiofs CI one more time....


Auth flow is bad on Linux

Microsoft/vscode#62184
Tested on a relatively clean 18.04 VM.
Not sure you can do anything about this but, undefined?

Really long, due to the URL. Buttons are off screen, some people may not know to press the buttons or may be scared to on security grounds?

I don't want a keyring so I pressed cancel

It still signed in without the keyring?

@queerviolet It should be stored in local storage, never the settings file as many people sync that to the cloud publicly. https://github.com/Microsoft/vscode-pull-request-github/issues/368
I think vscode.ExtensionContext.globalState is the API for this.

Ah, okay, that's reasonable. I'll grab that bug.

im having this issue as well on kubuntu with chrome. every time i click the 'reload window and open' button it reloads the window from what i can tell and gives me the same message and never resolving:

so it obviously has the super wide notification but im not sure how to complete the auth?

I am facing the same problem. After the last VSCode update this extension is asking me to login again, but with xdg it opens a big popup that I am forced to close using Alt+F4. I have read in other issue that there should be a fallback way to login, but the auth page isn't providing it.

Auth flow is really bad on Ubuntu. After the last VSCode update this extension is asking me to login again, but with xdg it opens a big popup that I am forced to close using Alt+F4. I have read in other issue that there should be a fallback way to login, but the auth page isn't providing it.
EDIT: I just have to figure out how to click on the button far outside of my screen (VSCode is fullscreen in this picture)

EDIT: If anyone is in my situation, click on the white modal, thatn right arrow, right arrow, enter.

this doesnt work for me. i just get in a reload loop unfortunately. unless im misunderstanding what the 'white modal' is? i have KDE as a desktop so there may be a difference there.

I'm on Gnome. Arrow-Arrow-Enter was to "click" on the left button ("Open")

You can try https://github.com/Microsoft/vscode-pull-request-github/wiki#personal-access-token-authentication

can confirm i got auth in new code version out today. still get the super long notification but it works now. tyvm!

im not sure what happened but it asked me to set a default token? i didnt screenshot that but i did give it a password as requested. now after every reboot its asking me to enter that password. i did install live share and this is when it started happening. i can actually just cancel this popup, twice, and then GH PR logs in fine. did live share bork something with the auth of GH PR?

Auth has moved into VS Code core.


WAL and SHM files not cleaned up during reset

While running unit tests on my SSDataKit enabled project I was hitting some SQLite 522 'not an error' errors. Those unit tests were on iOS7 (which has WAL enabled by default) and the tests frequently run SSManagedObject +resetPersistentStore during setup.
Some Googling and StackExchange searching led me to a theory that this might be caused by WAL mode, and particularly by the inconsistent state caused by having a new sqlite database file created, but still having an old WAL journal. As part of exploring that theory, I modified SSDataKit to clean up those -shm -wal files used by WAL when SSDataKit resets the persistent store or is cleaning up after a failed lightweight migration.
That theory didn't pan out, but I wanted to offer those changes back to you regardless. (I'll send a pull request right after I submit this issue.) Feel free to reject the request if you know that SQLite will always do the right thing with just the sqlite file removed. (Which, in theory, it should be able to do.)

And you


Add instrumentation for fetch bootstrap blocks procedure

cc @xichen2020 @martin-mao @kobolog

Other than the minor comment, LGTM

Coverage increased (+0.009%) to 78.7% when pulling 9d43330941e402633347c8d937e4bc103b11c1e0 on instrument-fetch-bootstrap-blocks into a61907be87a80c335275243df9008b2cddc23fd7 on master.

Coverage decreased (-0.3%) to 78.439% when pulling e24f1e9f3fd208236d174eeb7f136442daf25948 on instrument-fetch-bootstrap-blocks into a61907be87a80c335275243df9008b2cddc23fd7 on master.


Example not working

@CentricStraaten commented on Fri Oct 12 2018
I copied the code to test this pattern. It compiles local and can published online without any problems. When I call the function as documented I receive a 404 HttpResponse. In the log files I notice and exception:  The function 'HandleFile' doesn't exist, is disabled, or is not an orchestrator function. Additional info: The following are the active orchestrator functions: 'E2_BackupSiteContent'.. InstanceId: ac0cc5f9e844461e9b1431f32e24f8b6. Function: HandleFile. HubName: DurableFunctionsHub. AppName: . SlotName: . ExtensionVersion: 1.6.2. SequenceNumber

Documentdetails
⚠ Dit gedeelte niet bewerken. Het is vereist om problemen te koppelen tussen docs.microsoft.com en GitHub.

ID: 2cc3cf42-8395-7e45-ae2e-6c629576d4f6
Version Independent ID: 6e60aa29-d501-270c-9e52-53138a0cf547
Content: Fan-uitgaand/fan-in scenario's in duurzame functies - Azure
Content Source: articles/azure-functions/durable-functions-cloud-backup.md
Service: azure-functions
GitHub Login: @cgillum
Microsoft Alias: azfuncdf

@cgillum commented on Fri Oct 12 2018
This is most likely because the host.json file you're using does not match the host.json file used by the samples: host.json.
Assuming this is your problem, we mentioned this in the previous chaining sample, but we probably need to add the clarification here as well.

@LisandroSu commented on Fri Oct 12 2018
Hello, @cgillum
Thanks for the answer! Should we move this issue to the ENU repo? Let us know when we can close it.
Thanks again!

@cgillum commented on Fri Oct 12 2018
I'm not familiar with the repositories used by MicrosoftDocs, but this issue is indeed language agnostic.

@LisandroSu commented on Wed Oct 17 2018
Usually with issues like this, we send it to the source repo for fixing. But if you are working on the issue we can close it and you can let the user know when it's fixed.

Hi team,
This was a source issue so I moved it here. If the problem was solved, please feel free to close it.
Kind regards,
Microsoft DOCS International Team

@CeciAc Thanks for the feedback! We are currently investigating and will update you shortly.

Hey @cgillum Were you referring to clarification below in screenshot on chaining doc in your comment above? if so, I can go ahead and add the same clarification about host.json to this doc as well.

Hey @CeciAc @cgillum PR's been created and submitted for merge. This issue will now auto-close and changes will reflect in few hours. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


[Enhancement] Build runtime filter for scalar NestLoopJoin

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Backport previous work #6105, build runtime filter for scalar NestLoopJoin.
Experiment result:

SQL: select count(*) from lineorder_flat where LO_ORDERDATE> (select max(LO_COMMITDATE) from lineorder_flat where year(LO_ORDERDATE)=1996)
Before: 1.208s
After: 701ms

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

@Mergifyio backport branch-2.4

run starrocks_admit_test

run starrocks_admit_test

@Mergifyio rebase

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 41 / 43 (95.35%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
7
9
77.78%
[1669, 1670]

:large_blue_circle:
com/starrocks/planner/PlanNode.java
9
9
100.00%
[]

:large_blue_circle:
com/starrocks/planner/NestLoopJoinNode.java
25
25
100.00%
[]

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 50 / 52 (96.15%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
7
9
77.78%
[1669, 1670]

:large_blue_circle:
com/starrocks/planner/PlanNode.java
9
9
100.00%
[]

:large_blue_circle:
com/starrocks/planner/NestLoopJoinNode.java
34
34
100.00%
[]

run starrocks_admit_test

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 49 / 52 (94.23%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
7
9
77.78%
[1669, 1670]

:large_blue_circle:
com/starrocks/planner/NestLoopJoinNode.java
33
34
97.06%
[84]

:large_blue_circle:
com/starrocks/planner/PlanNode.java
9
9
100.00%
[]

run starrocks_admit_test

run starrocks_fe_unittest


[BUG]How to set the ip address in the cluster mode

Setting:
This is my first time using Mars and I face some problems maybe pretty easy for you.
I am using mars as distributed computation engine. when i set the cluster mode as the doc said. I am confused about the ip address here:
mars-worker -H <host_name> -p <worker_port> -s <supervisor_ip>:<supervisor_port>
mars.new_session('http://<web_ip>:<web_port>')
(from https://mars-project.readthedocs.io/zh_CN/latest/installation/deploy.html)
Question:

does the ip means external network ip address or internal network?
I tried the external network ip address and it failed.
when I use the internal network ip address, and I am using VSCode on my Mac and remote-develop on a Linux system, how to open the web browser of the Mars WebUI on my Mac with the Linux internal network ip address？

Thanks for your question.
The web_ip in mars.new_session('http://<web_ip>:<web_port>') is the ip address of the supervisor node. The web_port is the port you launched supervisor by setting -w.
For example, we can launch a supervisor as follow:
mars-supervisor -H <IP_ADDRESS> -p 7001 -w 9001 -s <IP_ADDRESS>:9001 --log-level info --log-format "%(asctime)s %(levelname)s %(filename)s:%(lineno)d - %(message)s"

<IP_ADDRESS> is the ip address of my node.
Then we can see the log:
2023-05-12 10:58:16,555 INFO api.py:135 - Metric mars.operand.group_keys_num will be initialized when invoking `init_metrics()`.
2023-05-12 10:58:16,856 INFO api.py:73 - Finished initialize the metrics of backend: console.
2023-05-12 10:58:17,334 INFO api.py:135 - Metric mars.operand.group_rows_num will be initialized when invoking `init_metrics()`.
2023-05-12 10:58:17,334 INFO api.py:135 - Metric mars.operand.group_keys_num will be initialized when invoking `init_metrics()`.
2023-05-12 10:58:17,645 INFO api.py:73 - Finished initialize the metrics of backend: console.
2023-05-12 10:58:17,672 INFO fury.py:729 - Created fury serializer <pyfury._serialization.Fury object at 0x7fd485524d60> for thread<PHONE_NUMBER>28096.
2023-05-12 10:58:17,698 INFO fury.py:729 - Created fury serializer <pyfury._serialization.Fury object at 0x7fb0ecac57e0> for thread<PHONE_NUMBER>70624.
2023-05-12 10:58:17,727 INFO api.py:191 - Initializing a gauge whose name: mars.scheduling.request_worker_time_sec, tag keys: None, backend: console
2023-05-12 10:58:17,728 INFO api.py:191 - Initializing a gauge whose name: mars.scheduling.offline_worker_time_sec, tag keys: None, backend: console
2023-05-12 10:58:17,729 INFO supervisor.py:73 - Mars Web access log level is set to WARNING.
2023-05-12 10:58:17,732 INFO supervisor.py:90 - Mars Web started at <IP_ADDRESS>:9001

And the <IP_ADDRESS>:9001 is the web address.
First of all, you should ensure that the network is accessible, if you want to access the Mars Web service in your remote Linux. You can verify this by ping or telnet.
I don't understand your external network ip and internal network ip. You can execute the python code in your remote Linux to ensure the Mars is launched or not.

@PaulWongDlut any questions? If not, i'll close this issue.

@PaulWongDlut I'll close this issue. We welcome open an issue at any time if there is any problem.


ESLint 9 support?

https://eslint.org/blog/2024/04/eslint-v9.0.0-released/
Is there any plan to support eslint 9 flat config format?
Or is it already working and I'm missing it? I tried to do:
import readableTailwind from 'eslint-plugin-readable-tailwind';

export default tseslint.config(
  ...eslintPluginReadableTailwind.configs.warning
)

But then I get:
A config object has a "plugins" key defined as an array of strings.

Flat config requires "plugins" to be an object in this form:

    {
        plugins: {
            readable-tailwind: pluginObject
        }
    }

Seems like the format changed so I suppose there is no ESLint 9 support yet.

I think this is a bug.
The plugins in the shared configs are indeed defined as a string[]. For the .esm export, this should be changed to an object as described in the error message you have posted.
https://github.com/schoero/eslint-plugin-readable-tailwind/blob/b33d458bcd3ea39a8e5a59c12fed4e2f880d7bde/src/configs/config.ts#L13

I should have time to fix and test this on the weekend. Until then you should be able work around this by defining the rules manually.
import eslintPluginReadableTailwind from "eslint-plugin-readable-tailwind";

 export default [{
    plugins: {
      "readable-tailwind": eslintPluginReadableTailwind
    },
    rules: {
      "readable-tailwind/multiline": "warn",
      "readable-tailwind/no-unnecessary-whitespace": "warn",
      "readable-tailwind/sort-classes": "warn"
    }
  }]


Fix #319 : Deprecated the Onboarding Mentor Program

Removed the onboarding mentor program and form link, mentioned in #319 .

@Ash-2k3 PTAL! Thanks!

@Ash-2k3 I checked but couldn't find anything with onboarding mentors in the codebase so, I think we can merge this!

Thanks @HardikGoyal2003, merged this PR :)


add optional noindex (#3483)

Description
Cherry-pick of @ozdanborne's noindex fix.
Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Deploy preview for calico ready!
Built with commit 28da3a2d66b77357aa01d71f11f96ee11356b6ba
https://deploy-preview-3491--calico.netlify.app


Wallkick implemented, fixed rotation bug

This pull request does 2 things:

Replaces rotateCW with rotateTet, an implementation that prevents tetronimos from rotating into illegal positions, and also implements wallkick (so tetronimos don't glue themselves to the walls)
Moves the isInside function into Model.Lib

These same changes also happen for the RhineGloss.Arrowized code.

Amazing, thank you @AveryLychee!


Allow for variables in comment templates

It would be nice to have possibility to include some dynamic variables in comment, like:

pull request name
pull request id
branch and base branch
author
etc.

Is this not supported?
I am also planning to use this bot.

@boyney123 would love to see this in here too, even just having context like the PR number etc would be quite useful.


Planned enhancement: Improved edit command

Currently the edit commands allow users to proceed with editing even if they provide the same exact companies details which may be an undesirable behaviour especially the user is trying to fix a single character typo.
(#262)
Additionally, after editing, the list of companies is reset, which some users may find annoying especially after they run a find command.
(#212)

Resolved by https://github.com/AY2425S1-CS2103T-T09-1/tp/pull/300


Ensure that the resize also crops images upon request, and stores the result in S3.

Merging because the current state is breaking magnet.me production.

Looking good, seems like you had more than your fair share on nodejs for a day!


Update and add tests for the project builder cli

This adds tests for the project builder cli, and also includes a bit of cleanup.

@carsonfarmer If this looks good to you I'll do an npm version patch on this branch before merging and that will fix #95


Create Blueprint creates a lua that does not work

Several issues:

enapter calls have a colon : instead of a . in their commands.
send_registration() does not exist in the documentation or auto-complete. Is this retired?
it creates a sample schedule for a telemetry entry "reading" but it does not create the corresponding manifest.yml entry so code will not run.

It would help beginners with the blueprints if the default script runs right away. Better to learn from an example than going through reference documentation

Fixed in latest release (3/3/2022)


Update readme

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   54.07%   54.07%
=======================================
  Files          26       26
  Lines         736      736
  Branches       37       37
=======================================
  Hits          398      398
  Misses        331      331
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b498e...bb8c477. Read the comment docs.


Fix BC for previous php versions

👎

I'm torn.
I mean the library isn't very actively developed but now suddenly carrying forward this baggage for BC reasons.. what's you justification for this?

Not willing to go down this road to support PHP 5.4+, and I should now probably agree with @GrahamCampbell on the current PHP version, right? :/

@KartaviK , I just created a new branch 7.x. Are you able to fix these conflicts?
I think most of the changes you are doing can be possibly dropped in favor of a code that supports only PHP < 7.1, including PHPUnit version. Then we would have to keep this branch in sync with 8.x.

It is still possible to run travis on those old versions btw.

Example: https://github.com/schmittjoh/php-option/blob/1.5.3/.travis.yml.

https://github.com/antonioribeiro/google2fa/pull/152

@GrahamCampbell , Yeah, I just want to free the 8.x branch to move forward, but the idea is to keep them both running on Travis.
Thanks for all your contributions ❤

Sorry, I will pass on this one.

Good call IMHO


Controls to filter preset search results by geometry

Advanced users may want to filter results by geometry. I'm thinking we can add an unobtrusive footer area to the popover to show some controls like these.

I added this. It'll be especially helpful for POI mapping when you want to hide all the building variants.


Scrcpy returns different width and height in versions 1.24 and 2.3.1. Can you help explain?

Scrcpy returns different width and height in versions 1.24 and 2.3.1. Can you help explain? In addition, I want to simulate encapsulation and click mobile phone commands on the front end. Version 1.24 is OK, but version 2.3.1 is not. Is there still an error? Can you help me analyze it?
The java code I use
final Socket screenSocket = new Socket("<IP_ADDRESS>", localPort);
InputStream screenStream = screenSocket.getInputStream();
controlSocket = new Socket("<IP_ADDRESS>", localPort);
controlOutputStream = controlSocket.getOutputStream();
for (int i = 0; i < 64; i++) {
          screenStream.read();
}
width = screenStream.read() << 8 | screenStream.read();
height = screenStream.read() << 8 | screenStream.read();
System.out.println("scrcpy：width：" + width + "，height：" + height);

Version 1.24 obtains the width and height of scrcpy, Simulate click normally
CLASSPATH=/data/local/tmp/scrcpy-server1.jar app_process / com.genymobile.scrcpy.Server 1.24 log_level=info max_size=1000 bit_rate=8000000 max_fps=60 lock_video_orientation=-1 tunnel_forward=true send_frame_meta=false control=true display_id=0 show_touches=false stay_awake=true power_off_on_close=false
[server] INFO: Device: HUAWEI MHA-AL00 (Android 9)

scrcpy：width：560，height：1000

Version 2.3.1 obtains the width and height of scrcpy
CLASSPATH=/data/local/tmp/scrcpy-server.jar app_process / com.genymobile.scrcpy.Server 2.3.1 log_level=info max_size=1000 video_bit_rate=8000000 max_fps=60 lock_video_orientation=-1 tunnel_forward=true send_frame_meta=false control=true audio=false display_id=0 show_touches=false stay_awake=true raw_stream=false power_off_on_close=false
[server] INFO: Device: [HUAWEI] HUAWEI MHA-AL00 (Android 9)

scrcpy：width：26674，height：13876

The scrcpy versions output by the two versions are inconsistent. What is the reason?
There is another one, the same code simulates the request click event, and found that the 2.3.1 version cannot take effect, and some prompt messages
Simulate click request code
private void commitTouchEvent(byte actionType, int x, int y, int screenWidth, int screenHeight) {
        // Scrcpy.server Device.computeVideoSize
        if (screenHeight == maxSize) {
            screenWidth = height == maxSize ? width : height;
        } else if (screenWidth == maxSize) {
            screenHeight = width == maxSize ? height : width;
        }
        System.out.println(screenWidth + "x" + screenHeight);
        touchEventBuffer.rewind();
        touchEventBuffer.put(TYPE_INJECT_TOUCH_EVENT);
        touchEventBuffer.put(actionType);
        touchEventBuffer.putLong(-1L); // pointerId
        touchEventBuffer.putInt(x);
        touchEventBuffer.putInt(y);
        touchEventBuffer.putShort((short) screenWidth);
        touchEventBuffer.putShort((short) screenHeight);
        touchEventBuffer.putShort((short) 0xffff); // pressure
        touchEventBuffer.putInt(1); // buttons left button: 1 << 0 | right button: 1 << 1 | middle button: 1 << 2
        commit(touchEventBuffer.array());
    }

    private void commit(byte[] msg) {
        try {
            controlOutputStream.write(msg);
            controlOutputStream.flush();
        } catch (IOException e) {
            e.printStackTrace();
//            System.out.println(mobileId + " commit msg error");
        }
    }

2.3.1 Error information
[server] WARN: Ignore touch event, it was generated for a different device size
[server] WARN: Unknown event type: -1

I set max_size=1000 and found that 2.3.1 did not take effect.

The header has changed in scrcpy 2.0 by 238ab872ba0ea18c2553dfe3c2202d64d67d8960.
The protocol is documented here.


Failed to persist entry: TypeError: Cannot read property 'match' of undefined

Describe the bug
I've deployed a GatsbyJS site with the Netlify CMS at envyforge.com/admin. The Netlify CMS, in production, does load and I'm able to view each of the collection entries defined in the admin/config.yml. However, on save of new or existing cms entries, I get the following error:

Failed to persist entry: TypeError: Cannot read property 'match' of undefined

As a note: I am able to save in local development using npx netlify-cms-proxy-server.
To Reproduce

Go to 'envyforge.com/admin'
Click on 'blog' collection
Create new blog entry (use the hint text if you have questions on what the fields are for)
Click on 'Save'
See error

Expected behavior
To be able to save in product deployment as I am in local dev.
Screenshots

Applicable Versions:

Netlify CMS version: 2.12.14
Git provider: Bitbucket
OS: macOS 10.15.5
Browser version: Google Chrome 83.0.4103.97 (Official Build) (64-bit)
Node.JS version (local): v13.3.0
Note.JS version (production): AWS Amplify - Node.JS: v10.16.0

CMS configuration
backend:
  name: bitbucket
  repo: envyforge/envyforge.com
  branch: develop
  auth_type: implicit
  app_id: myappid

local_backend: true
publish_mode: editorial_workflow
media_folder: static/images
public_folder: src/data/images
site_url: https://envyforge.com/contribute

collections:
  - name: "blog"
    label: "Blog"
    folder: "src/data/blogs"
    create: true
    editor:
      preview: false
    fields:
      - {
          label: "Title",
          name: "title",
          widget: "string",
          hint: "This is the title that will be shown on the blog page.",
        }
      - {
          label: "Path",
          name: "slugPath",
          widget: "string",
          default: "/blog/",
          hint: "Must be /blog/ to control the path that the blog page will render in.",
        }
      - { label: "Date", name: "date", widget: "datetime" }
      - {
          label: "Author",
          name: "author",
          widget: "string",
          default: "Matt Ortiz",
          hint: "Values: Matt Ortiz or Envy Forge.",
        }
      - {
          label: "Format",
          name: "format",
          widget: "string",
          default: "image",
          hint: "Values: image, quote, video, link or gallery.",
        }
      - {
          label: "Image",
          name: "image",
          widget: "string",
          default: "../images/envyforge-spark-persona-app.png",
          hint: "E.g.: ../images/envyforge-spark-persona-app.png.",
        }
      - {
          label: "Category",
          name: "category",
          widget: "string",
          hint: "E.g.: technology, products & services, practices, this is value creation",
        }
      - {
          label: "Tags",
          name: "tags",
          widget: "list",
          hint: "E.g.: value-creation, product-management, product-development, growth, investment, agile, lean-startup",
        }
      - {
          label: "Featured",
          name: "is_featured",
          widget: "boolean",
          default: false,
          hint: "This controls whether the post will show as a featured item on the blog.",
        }
      - { label: "Body", name: "body", widget: "markdown" }
  - name: "service"
    label: "Service"
    folder: "src/data/services"
    create: true
    editor:
      preview: false
    fields:
      - {
          label: "Sort Order",
          name: "sortOrder",
          widget: "string",
          hint: "This is the order (ascending) that the service or practice card will render on the home page within each Category (services or practices).",
        }
      - {
          label: "Title",
          name: "title",
          widget: "string",
          hint: "This is the title that will be shown on the home page service or practice card.",
        }
      - {
          label: "Description",
          name: "description",
          widget: "string",
          hint: "This is the description (or overview) that will be shown on the home page service or practice card.",
        }
      - {
          label: "Path",
          name: "slugPath",
          widget: "string",
          default: "/service/",
          hint: "Must be /services/ to control the path the services page will render in.",
        }
      - { label: "Date", name: "date", widget: "datetime" }
      - {
          label: "Author",
          name: "author",
          widget: "string",
          default: "Matt Ortiz",
          hint: "Values: Matt Ortiz or Envy Forge.",
        }
      - {
          label: "Format",
          name: "format",
          widget: "string",
          default: "image",
          hint: "Values: image, quote, video, link or gallery.",
        }
      - {
          label: "Image",
          name: "image",
          widget: "string",
          default: "../images/envyforge-spark-persona-app.png",
          hint: "E.g.: ../images/envyforge-spark-persona-app.png.",
        }
      - {
          label: "Image Alt",
          name: "imageAlt",
          widget: "string",
          hint: "This is the image alt text that will show for accessiblity.",
        }
      - {
          label: "Category",
          name: "category",
          widget: "string",
          hint: "Values: services or practices.",
        }
      - {
          label: "Read More",
          name: "readMore",
          widget: "boolean",
          default: false,
          hint: "This setting controls the services and practices cards on the home page. False means no Read More link will be on the services and practices cards on the home page. True means a Read More link will be placed on the home page (services and practices sections) that goes to the underlying content (full body and post).",
        }
      - {
          label: "Tags",
          name: "tags",
          widget: "list",
          hint: "E.g.: value-creation, product-management, product-development, growth, investment, agile, lean-startup",
        }
      - {
          label: "Featured",
          name: "is_featured",
          widget: "boolean",
          default: false,
          hint: "This controls whether the post will show as a featured item on the blog (yes, even if a service).",
        }
      - { label: "Body", name: "body", widget: "markdown" }

Additional context
Happy to provide additional context.
Thanks,
Matt

HI Netlify CMS team,
Here is some additional context from Chrome Dev Tools from envyforge.com/admin:
Failed to load resource: the server responded with a status of 403 ()
https://api.bitbucket.org/2.0/repositories/envyforge/envyforge.com/pullrequests?pagelen=50&q=source.repository.full_name %3D "envyforge%2Fenvyforge.com"  AND state %3D "OPEN"  AND destination.branch.name %3D "develop" AND comment_count > 0 AND source.branch.name ~ "cms%2F"
Seems, perhaps, a permissions issue but I'm logging in to the CMS using my bitbucket account. Note: I'm the bitbucket private repo owner. Any support is appreciated.
BTW, I really appreciate what the team is doing for the community!
Regards,
Matt

I am, however, able to upload media to the Netlify CMS. Don't know if this provides any related context or not.
blob:https://www.envyforge.com/09eb1f37-b323-4e2a-bb84-7e1eab0ea42f

Hi @mattortiz, seems like a permissions issue with the OAuth consumer.
Can you try setting the permissions to:

We should probably add a note here that Pull requests permissions is required for editorial workflow

Hi @erezrokah ,
That did the trick! Thank you very much. Was stumped and spun around.
I've gone ahead and updated the documentation using Netlify CMS (so a PR is awaiting review). ;-)

Closed via https://github.com/netlify/netlify-cms/pull/3910


feat: Brutally simple local network discovery

This adds an extremely simple form of local network discovery on an IPv4 network.  It is not meant to be easy to use but can be combined to announce a service on a particular socket address.

@flub can we close this?


Fix resolver for public teams

Resolver was failing with teams because it did not pass public argument to team/get endpoint. Added parametrised implicit teams tests to check both public and private teams, but I think this issue also affected non-impteams, so maybe more tests are needed.
PR also brings in attempt at fixing the resolver, but it works only for team id URLs because only from them we can derive whether team is public or not.

How did this ever work?

Probably nothing before tried to resolve „tid” urls for public teams. Other things like loading the teams or resolving by assertion worked.

Wiadomość napisana przez Maxwell Krohn<EMAIL_ADDRESS>w dniu 22.03.2018, o godz. 16:52:
How did this ever work?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Fix MSVC warning C4819

Replace unicode whitespaces by ASCII whitespace 0x20

Coverage remained the same at 100.0% when pulling 66ffac9e8a4ee2d7210a25e0f7a9ce2e714ca814 on Chocobo1:c4819 into 6f3bebff5c11560542bc3ac4ad27fbe9de20e6a6 on nlohmann:develop.

Thanks!


kubelet: switch deprecated --config flag to --kubeconfig

this needs to be done during upgrade to 2.0 otherwise kubelet
wont start
Signed-off-by: Maximilian Meister<EMAIL_ADDRESS>

https://bugzilla.suse.com/show_bug.cgi?id=1062011

fixed @ereslibre comment and added the bug reference

included in https://github.com/kubic-project/caasp-container-manifests/pull/123


Please invite me to the GitHub Community Organization

Name
Sarthak Jain
Discord Username (if applicable)
Sarthak Jain#2443
Additional Context
Testing

test issue closed


removed spaces

Checklist:

[] I have read freeCodeCamp's contribution guidelines.
[] My pull request has a descriptive title (not a vague title like Update index.md)
[] My pull request targets the main branch of freeCodeCamp.
[] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Please review and approve .
If need changes please let me know so that i will push again.
I tried copying text and translating to Arabic but didnt find any issue.

Hey @TriJayDore
Thank you for opening this pull request.
This is a standard message notifying you that we've reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding.


Prepare the release

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:samoht/datakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353905936
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


Removed the need for HoneyLib

didn't push all the files changed in my last pr

i was gonna do this anyway so cool