[Service Bus] ECONNRESET when onDetached crashing application

Package Name: @azure/service-bus
Package Version: 1.1.6
Operating system: node10:alpine (docker image)
[x] nodejs

version:

[ ] browser

name/version:

[ ] typescript

version:

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
After upgrade to 1.1.6, we have noticed that there is this ECONNRESET that is crashing our application for our API/Event-Listener(Sender message) & Task-Email-Listener(Receiver message) service that consume<EMAIL_ADDRESS>To Reproduce
Steps to reproduce the behavior:

Playing around with disconnection(instability) of network able to reproduce this issue. My suspicion was at TCP level the old AMQP connection-1 is trying to connect still (FIN_WAIT1). Below are  the logs from our Test environment for our Listener & API under additional context.

Expected behavior

Should throw to client the error or dispose the previous connection(if recreate new connection is the issue) instead of crashing the application. It is possible that might be an uncaughtException from the library. We gotten consistent error logs when this happen.

Screenshots
If applicable, add screenshots to help explain your problem.
Note: This screenshot is from my local environment (minikube) when I am trying to replicate the issue with disconnect my wifi.

Additional context
API logs (Sender message)
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:23 GMT rhea:events [connection-1] Connection got event: disconnected
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.615Z rhea-promise:translate [connection-1] Translating the context for event: 'disconnected'.
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.617Z rhea-promise:error [connection-1] The connection is open ? -> false
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.618Z azure:service-bus:error The connection "connection-1" has been updated to "connection-2".
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.618Z azure:service-bus:error [connection-2] state: { wasConnectionCloseCalled: false, numClients: 1 }
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.618Z azure:service-bus:error [connection-2] connection.close() was not called from the sdk and there were some clients. We should reconnect.
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.918Z azure:service-bus:error [connection-2] calling detached on client 'taskEmail/c05b1656-7937-6d42-811f-d8676378fb25'.
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.918Z azure:service-bus:error [connection-2] calling detached on sender 'taskEmail-a481f20d-0376-8140-b832-3e09e4243c38'.
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.919Z rhea-promise:error [connection-1] The sender is open ? -> false
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.920Z rhea-promise:error [connection-1] The session is open ? -> false
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.920Z azure:service-bus:error [connection-2] close() method of Sender 'taskEmail-a481f20d-0376-8140-b832-3e09e4243c38' with address 'taskEmail' was not called. There was no accompanying error as well. This is a candidate for re-establishing the sender link.
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.920Z azure:service-bus:error [connection-2] Sender 'taskEmail-d84a15e1-f279-574f-9359-35465064f73e' with address 'taskEmail' is open? -> false
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.920Z azure:service-bus:error [connection-2] Sender 'taskEmail-d84a15e1-f279-574f-9359-35465064f73e' with address 'taskEmail' is open? -> false
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.921Z azure:service-bus:error [connection-2] The sender 'taskEmail-d84a15e1-f279-574f-9359-35465064f73e' with address 'taskEmail' is not open and is not currently establishing itself. Hence let's try to connect.
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:23 GMT rhea:events [connection-2] Connection got event: connection_open
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.937Z rhea-promise:translate [connection-2] Translating the context for event: 'connection_open'.
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:23 GMT rhea:events [connection-2] Session got event: session_open
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.938Z rhea-promise:translate [connection-2] Translating the context for event: 'session_open'.
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:23 GMT rhea:events [connection-2] Link got event: sender_open
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.939Z rhea-promise:translate [connection-2] Translating the context for event: 'sender_open'.
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:23 GMT rhea:events [connection-2] Link got event: sender_flow
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.940Z rhea-promise:translate [connection-2] Translating the context for event: 'sender_flow'.
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:23 GMT rhea:events [connection-2] Link got event: sendable
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.940Z rhea-promise:translate [connection-2] Translating the context for event: 'sendable'.
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:23 GMT rhea:events [connection-2] Link got event: receiver_open
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.941Z rhea-promise:receiver [connection-2] receiver got event: 'receiver_open'. Re-emitting the translated context.
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.941Z rhea-promise:translate [connection-2] Translating the context for event: 'receiver_open'.
May 01 21:50:23 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:23.941Z rhea-promise:receiver [connection-2] Resolving the promise with amqp receiver 'cbs-e0c798ee-06d6-254a-830c-f07b4257b1e3'.
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:24 GMT rhea:events [connection-2] Received disposition for outgoing transfers
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:24 GMT rhea:events [connection-2] Link got event: accepted
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:24.007Z rhea-promise:translate [connection-2] Translating the context for event: 'accepted'.
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:24 GMT rhea:events [connection-2] Link got event: settled
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:24.008Z rhea-promise:translate [connection-2] Translating the context for event: 'settled'.
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:24 GMT rhea:events [connection-2] Link got event: message
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:24.123Z rhea-promise:receiver [connection-2] receiver got event: 'message'. Re-emitting the translated context.
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:24.123Z rhea-promise:translate [connection-2] Translating the context for event: 'message'.
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:24.123Z azure:service-bus:error [connection-2] Trying to create sender 'taskEmail-d84a15e1-f279-574f-9359-35465064f73e'...
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:24 GMT rhea:events [connection-2] Session got event: session_open
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:24.178Z rhea-promise:translate [connection-2] Translating the context for event: 'session_open'.
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:24 GMT rhea:events [connection-2] Link got event: sender_open
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:24.180Z rhea-promise:translate [connection-2] Translating the context for event: 'sender_open'.
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:24 GMT rhea:events [connection-2] Link got event: sender_flow
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:24.180Z rhea-promise:translate [connection-2] Translating the context for event: 'sender_flow'.
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Fri, 01 May 2020 13:50:24 GMT rhea:events [connection-2] Link got event: sendable
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:24.180Z rhea-promise:translate [connection-2] Translating the context for event: 'sendable'.
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:24.181Z azure:service-bus:error [connection-2] Sender 'taskEmail-d84a15e1-f279-574f-9359-35465064f73e' with address 'taskEmail' has established itself.
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:24.181Z azure:service-bus:error [connection-2] Promise to create the sender resolved. Created sender with name: taskEmail-d84a15e1-f279-574f-9359-35465064f73e
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm] 2020-05-01T13:50:24.181Z azure:service-bus:error [connection-2] Sender 'taskEmail-d84a15e1-f279-574f-9359-35465064f73e' created with sender options: { name: 'taskEmail-d84a15e1-f279-574f-9359-35465064f73e',
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm]   target: { address: 'taskEmail' },
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm]   onError: [Function],
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm]   onClose: [Function],
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm]   onSessionError: [Function],
May 01 21:50:24 api core[task-svc-deployment-57fdf5ccf8-dgtvm]   onSessionClose: [Function] }
May 01 21:50:30 api core[task-svc-deployment-57fdf5ccf8-dgtvm] /task-svc/node_modules/applicationinsights/out/AutoCollection/Exceptions.js:37
May 01 21:50:30 api core[task-svc-deployment-57fdf5ccf8-dgtvm]                         throw THIS_IS_APPLICATION_INSIGHTS_RETHROWING_YOUR_EXCEPTION; // Error originated somewhere else in your app
May 01 21:50:30 api core[task-svc-deployment-57fdf5ccf8-dgtvm]                         ^
May 01 21:50:30 api core[task-svc-deployment-57fdf5ccf8-dgtvm] Error: read ECONNRESET
May 01 21:50:30 api core[task-svc-deployment-57fdf5ccf8-dgtvm]     at TLSWrap.onStreamRead [as _originalOnread] (internal/stream_base_commons.js:111:27)
May 01 21:50:30 api core[task-svc-deployment-57fdf5ccf8-dgtvm]     at TLSWrap.<anonymous> (/task-svc/node_modules/async-listener/glue.js:188:31)

Event-Listener logs (Sender message)
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:20 GMT rhea:events [connection-1] Connection got event: disconnected
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.559Z rhea-promise:translate [connection-1] Translating the context for event: 'disconnected'.
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.561Z rhea-promise:error [connection-1] The connection is open ? -> false
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.561Z azure:service-bus:error The connection "connection-1" has been updated to "connection-2".
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.561Z azure:service-bus:error [connection-2] state: { wasConnectionCloseCalled: false, numClients: 1 }
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.561Z azure:service-bus:error [connection-2] connection.close() was not called from the sdk and there were some clients. We should reconnect.
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.861Z azure:service-bus:error [connection-2] calling detached on client 'taskEmail/acef0b8f-f2dd-784c-9fb8-9f709d6fa85e'.
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.862Z azure:service-bus:error [connection-2] calling detached on sender 'taskEmail-67f9998c-2493-e443-96cd-ee449c0d30df'.
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.863Z rhea-promise:error [connection-1] The sender is open ? -> false
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.863Z rhea-promise:error [connection-1] The session is open ? -> false
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.863Z azure:service-bus:error [connection-2] close() method of Sender 'taskEmail-67f9998c-2493-e443-96cd-ee449c0d30df' with address 'taskEmail' was not called. There was no accompanying error as well. This is a candidate for re-establishing the sender link.
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.864Z azure:service-bus:error [connection-2] Sender 'taskEmail-df9392a8-c922-d34d-a615-498a81279c1e' with address 'taskEmail' is open? -> false
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.864Z azure:service-bus:error [connection-2] Sender 'taskEmail-df9392a8-c922-d34d-a615-498a81279c1e' with address 'taskEmail' is open? -> false
May 02 11:27:20 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.864Z azure:service-bus:error [connection-2] The sender 'taskEmail-df9392a8-c922-d34d-a615-498a81279c1e' with address 'taskEmail' is not open and is not currently establishing itself. Hence let's try to connect.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:20 GMT rhea:events [connection-2] Connection got event: connection_open
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.981Z rhea-promise:translate [connection-2] Translating the context for event: 'connection_open'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:20 GMT rhea:events [connection-2] Session got event: session_open
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.982Z rhea-promise:translate [connection-2] Translating the context for event: 'session_open'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:20 GMT rhea:events [connection-2] Link got event: sender_open
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.984Z rhea-promise:translate [connection-2] Translating the context for event: 'sender_open'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:20 GMT rhea:events [connection-2] Link got event: sender_flow
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.984Z rhea-promise:translate [connection-2] Translating the context for event: 'sender_flow'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:20 GMT rhea:events [connection-2] Link got event: sendable
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.984Z rhea-promise:translate [connection-2] Translating the context for event: 'sendable'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:20 GMT rhea:events [connection-2] Link got event: receiver_open
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.987Z rhea-promise:receiver [connection-2] receiver got event: 'receiver_open'. Re-emitting the translated context.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.987Z rhea-promise:translate [connection-2] Translating the context for event: 'receiver_open'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:20.987Z rhea-promise:receiver [connection-2] Resolving the promise with amqp receiver 'cbs-98e5da56-c783-c343-9a5b-4cfc9649749f'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:21 GMT rhea:events [connection-2] Received disposition for outgoing transfers
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:21 GMT rhea:events [connection-2] Link got event: accepted
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:21.050Z rhea-promise:translate [connection-2] Translating the context for event: 'accepted'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:21 GMT rhea:events [connection-2] Link got event: settled
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:21.051Z rhea-promise:translate [connection-2] Translating the context for event: 'settled'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:21 GMT rhea:events [connection-2] Link got event: message
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:21.051Z rhea-promise:receiver [connection-2] receiver got event: 'message'. Re-emitting the translated context.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:21.051Z rhea-promise:translate [connection-2] Translating the context for event: 'message'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:21.052Z azure:service-bus:error [connection-2] Trying to create sender 'taskEmail-df9392a8-c922-d34d-a615-498a81279c1e'...
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:21 GMT rhea:events [connection-2] Session got event: session_open
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:21.110Z rhea-promise:translate [connection-2] Translating the context for event: 'session_open'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:21 GMT rhea:events [connection-2] Link got event: sender_open
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:21.112Z rhea-promise:translate [connection-2] Translating the context for event: 'sender_open'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:21 GMT rhea:events [connection-2] Link got event: sender_flow
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:21.112Z rhea-promise:translate [connection-2] Translating the context for event: 'sender_flow'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] Sat, 02 May 2020 03:27:21 GMT rhea:events [connection-2] Link got event: sendable
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:21.112Z rhea-promise:translate [connection-2] Translating the context for event: 'sendable'.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:21.112Z azure:service-bus:error [connection-2] Sender 'taskEmail-df9392a8-c922-d34d-a615-498a81279c1e' with address 'taskEmail' has established itself.
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:21.113Z azure:service-bus:error [connection-2] Promise to create the sender resolved. Created sender with name: taskEmail-df9392a8-c922-d34d-a615-498a81279c1e
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] 2020-05-02T03:27:21.113Z azure:service-bus:error [connection-2] Sender 'taskEmail-df9392a8-c922-d34d-a615-498a81279c1e' created with sender options: { name: 'taskEmail-df9392a8-c922-d34d-a615-498a81279c1e',
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g]   target: { address: 'taskEmail' },
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g]   onError: [Function],
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g]   onClose: [Function],
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g]   onSessionError: [Function],
May 02 11:27:21 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g]   onSessionClose: [Function] }
May 02 11:27:22 event-listener core[task-svc-listener-deployment-7d678b5b65-n849g] operation-name="on" svc-name="event-listener" timestamp="2020-05-02T03:27:22.754Z" type="error" msg="Process uncaughtException: Error: read ECONNRESET" stack-trace="Error: Process uncaughtException: Error: read ECONNRESET |     at Object.logError [as error] (/task-svc/app/utils/logger.js:24:13) |     at process.on (/task-svc/app/event/index.js:24:10) |     at process.emit (events.js:203:15) |     at process._fatalException (internal/bootstrap/node.js:497:27) |     at process._asyncFatalException [as _fatalException] (/task-svc/node_modules/async-listener/glue.js:211:34)"

Task-Email-Listener (Receiver message)
May 01 19:05:02 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Fri, 01 May 2020 11:05:02 GMT rhea:events [connection-2] Connection got event: disconnected
May 01 19:05:02 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:02.775Z rhea-promise:translate [connection-2] Translating the context for event: 'disconnected'.
May 01 19:05:02 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:02.776Z rhea-promise:error [connection-2] The connection is open ? -> false
May 01 19:05:02 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:02.777Z azure:service-bus:error The connection "connection-2" has been updated to "connection-3".
May 01 19:05:02 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:02.777Z azure:service-bus:error [connection-3] state: { wasConnectionCloseCalled: false, numClients: 1 }
May 01 19:05:02 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:02.777Z azure:service-bus:error [connection-3] connection.close() was not called from the sdk and there were some clients. We should reconnect.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.078Z azure:service-bus:error [connection-3] calling detached on client 'taskEmail/e4b040ca-aa11-0c42-8dc5-f04a281fb734'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.078Z azure:service-bus:error [connection-3] calling detached on streaming receiver 'taskEmail-adc5d656-8ed5-7245-a585-da7778c9856b'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.079Z rhea-promise:error [connection-2] The receiver is open ? -> false
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.079Z rhea-promise:receiver [connection-2] receiver has been closed, now closing it's session.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.080Z rhea-promise:error [connection-2] The session is open ? -> false
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.080Z azure:service-bus:error [connection-3] Receiver 'taskEmail-adc5d656-8ed5-7245-a585-da7778c9856b' with address 'taskEmail' is open? -> false
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.080Z azure:service-bus:error [connection-3] The receiver 'taskEmail-adc5d656-8ed5-7245-a585-da7778c9856b' with address 'taskEmail' is not open and is not currently establishing itself. Hence let's try to connect.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Fri, 01 May 2020 11:05:03 GMT rhea:events [connection-3] Connection got event: connection_open
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.097Z rhea-promise:translate [connection-3] Translating the context for event: 'connection_open'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Fri, 01 May 2020 11:05:03 GMT rhea:events [connection-3] Session got event: session_open
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.098Z rhea-promise:translate [connection-3] Translating the context for event: 'session_open'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Fri, 01 May 2020 11:05:03 GMT rhea:events [connection-3] Link got event: sender_open
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.099Z rhea-promise:translate [connection-3] Translating the context for event: 'sender_open'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Fri, 01 May 2020 11:05:03 GMT rhea:events [connection-3] Link got event: sender_flow
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.100Z rhea-promise:translate [connection-3] Translating the context for event: 'sender_flow'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Fri, 01 May 2020 11:05:03 GMT rhea:events [connection-3] Link got event: sendable
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.100Z rhea-promise:translate [connection-3] Translating the context for event: 'sendable'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Fri, 01 May 2020 11:05:03 GMT rhea:events [connection-3] Link got event: receiver_open
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.101Z rhea-promise:receiver [connection-3] receiver got event: 'receiver_open'. Re-emitting the translated context.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.101Z rhea-promise:translate [connection-3] Translating the context for event: 'receiver_open'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.101Z rhea-promise:receiver [connection-3] Resolving the promise with amqp receiver 'cbs-58a99fab-0555-e744-947f-8f93518aa6a6'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Fri, 01 May 2020 11:05:03 GMT rhea:events [connection-3] Received disposition for outgoing transfers
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Fri, 01 May 2020 11:05:03 GMT rhea:events [connection-3] Link got event: accepted
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.163Z rhea-promise:translate [connection-3] Translating the context for event: 'accepted'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Fri, 01 May 2020 11:05:03 GMT rhea:events [connection-3] Link got event: settled
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.163Z rhea-promise:translate [connection-3] Translating the context for event: 'settled'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Fri, 01 May 2020 11:05:03 GMT rhea:events [connection-3] Link got event: message
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.163Z rhea-promise:receiver [connection-3] receiver got event: 'message'. Re-emitting the translated context.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.163Z rhea-promise:translate [connection-3] Translating the context for event: 'message'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.164Z azure:service-bus:error [connection-3] Trying to create receiver 'taskEmail-5f3fcc05-7e32-4044-8af4-3bc83b2cc430' with options { name: 'taskEmail-5f3fcc05-7e32-4044-8af4-3bc83b2cc430',
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]   autoaccept: false,
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]   rcv_settle_mode: 1,
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]   snd_settle_mode: 0,
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]   source: { address: 'taskEmail' },
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]   credit_window: 0,
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]   onMessage: [Function: onMessage],
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]   onClose: [Function: onClose],
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]   onSessionClose: [Function: onSessionClose],
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]   onError: [Function],
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]   onSessionError: [Function],
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]   onSettled: [Function] }
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Fri, 01 May 2020 11:05:03 GMT rhea:events [connection-3] Session got event: session_open
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.225Z rhea-promise:translate [connection-3] Translating the context for event: 'session_open'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.225Z rhea-promise:receiver [connection-3] Added event handler for event 'message' on rhea-promise 'receiver'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.225Z rhea-promise:receiver [connection-3] Added event handler for event 'receiver_error' on rhea-promise 'receiver'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.225Z rhea-promise:receiver [connection-3] Added event handler for event 'receiver_close' on rhea-promise 'receiver'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.225Z rhea-promise:receiver [connection-3] Added event handler for event 'settled' on rhea-promise 'receiver'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Fri, 01 May 2020 11:05:03 GMT rhea:events [connection-3] Link got event: receiver_open
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.226Z rhea-promise:receiver [connection-3] receiver got event: 'receiver_open'. Re-emitting the translated context.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.227Z rhea-promise:translate [connection-3] Translating the context for event: 'receiver_open'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.227Z rhea-promise:receiver [connection-3] Resolving the promise with amqp receiver 'taskEmail-5f3fcc05-7e32-4044-8af4-3bc83b2cc430'.
May 01 19:05:03 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] 2020-05-01T11:05:03.227Z azure:service-bus:error [connection-3] Receiver 'taskEmail-5f3fcc05-7e32-4044-8af4-3bc83b2cc430' with address 'taskEmail' has established itself.
May 01 19:05:12 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] /task-svc/node_modules/applicationinsights/out/AutoCollection/Exceptions.js:37
May 01 19:05:12 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]                         throw THIS_IS_APPLICATION_INSIGHTS_RETHROWING_YOUR_EXCEPTION; // Error originated somewhere else in your app
May 01 19:05:12 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]                         ^
May 01 19:05:12 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl] Error: read ECONNRESET
May 01 19:05:12 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]     at TLSWrap.onStreamRead [as _originalOnread] (internal/stream_base_commons.js:111:27)
May 01 19:05:12 task-email-listener core[task-svc-listener-deployment-f6fcbf89-xf2tl]     at TLSWrap.<anonymous> (/task-svc/node_modules/async-listener/glue.js:188:31)

Thanks for reporting @snuffykl
Can you run the same with the previous version of the package (1.1.5) to confirm that you don't see this behavior there? Am trying to confirm that it is the changes in 1.1.6 that is causing this.
Also, if you are able to consistently repro this, can you share the code you are using so that we can try with exactly the same? If you can strip out your application specific code and share the rest via a github repo, we can clone and try it from our end.
Anything we should know about your minikube set up?
@chradek,
Given that we had extensively tested the change to use new connection objects when disconnect event is fired, my guess would be that this is an environment specific issue. Perhaps we should try out in minikube as well

Hi @ramya-rao-a I've created a sample application for it. Most of k8s deployment is in there. The  difference was the error where ETIMEDOUT(minikube) vs ECONNRESET(Azure AKS). However both errror will crash the application. Take not ETIMEDOUT will take a little longer to crash compare to ECONNRESET.
https://github.com/snuffykl/http-sender-amqp

Thanks @snuffykl
We will try to get a repro from our end to investigate the root cause and give an update here ASAP

@snuffykl
Can you share which version of @azure/service-bus you were on previously that did not have this behavior? If you can provide the versions of rhea and rhea-promise your app had installed, that would be helpful as well.
I have been able to reproduce an ECONNRESET error that crashes the process. In my case I notice this when I use iptables rules to drop all incoming traffic from the service, wait for 2 disconnect events, then re-allow incoming traffic from the service. After a minute or two I get this issue.
I haven't gotten your example running yet but will work on doing so (I'm new to kubernetes/helm so was running into some issues I think with the version of helm I was installing).

@snuffykl
I was able to get your repo running, so thank you for that! I tried disconnecting and reconnecting a few times after triggering a send while watching the logs. In this case I'm just turning my wifi off, waiting a minute or two, then turning it back on. So far I haven't seen the process-crashing error yet with your sample.
Can you share more info about how often/how long you disconnect/reconnect your internet before seeing this error?  How long after a disconnect or reconnect do you see this happen?
I do have a way to reproduce the ECONNRESET under different conditions, but I do want to try and reproduce using your sample as well so we can be sure if we fix the issue for my sample, it is fixed for yours too.

Hi @chradek, regarding helm version am using helm version v2.16.6. If you are using MacOS you can do brew install helm@2

@snuffykl I found a scenario where our amqp dependency, rhea, could cause and uncaught ECONNRESET to be thrown. I created a PR to fix this in rhea that fixes my repro:
https://github.com/amqp/rhea/pull/300
Basically when the connection reaches an idle timeout (60 seconds), the connection is closed and we (service-bus sdk) create a new connection. If you log rhea:io, you should see an entry that includes aborting socket in your logs if you're running into the idle timeout.

Hey @chradek that is good news :). I've also enabled rhea:io in my test environment and noticed there is aborting socket before process crashes. Below are the logs from my test environment. I guess my assumption of previous connection(tcp) did not actually destroy was true.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-1] aborting socket
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-1] Connection got event: disconnected
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.387Z rhea-promise:translate [connection-1] Translating the context for event: 'disconnected'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.389Z rhea-promise:error [connection-1] The connection is open ? -> false
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.390Z azure:service-bus:error The connection "connection-1" has been updated to "connection-2".
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.390Z azure:service-bus:error [connection-2] state: { wasConnectionCloseCalled: false, numClients: 1 }
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.390Z azure:service-bus:error [connection-2] connection.close() was not called from the sdk and there were some clients. We should reconnect.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.691Z azure:service-bus:error [connection-2] calling detached on client 'taskEmail/3e190c6a-ec33-e74a-a149-b0376c63d7ca'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.691Z azure:service-bus:error [connection-2] calling detached on sender 'taskEmail-b8f074fe-8102-6145-8dd5-bac2475d6c73'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.692Z rhea-promise:error [connection-1] The sender is open ? -> false
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.693Z rhea-promise:error [connection-1] The session is open ? -> false
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.693Z azure:service-bus:error [connection-2] close() method of Sender 'taskEmail-b8f074fe-8102-6145-8dd5-bac2475d6c73' with address 'taskEmail' was not called. There was no accompanying error as well. This is a candidate for re-establishing the sender link.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.693Z azure:service-bus:error [connection-2] Sender 'taskEmail-866d9187-59ef-ae4b-96ca-9075e90bb13b' with address 'taskEmail' is open? -> false
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.694Z azure:service-bus:error [connection-2] Sender 'taskEmail-866d9187-59ef-ae4b-96ca-9075e90bb13b' with address 'taskEmail' is open? -> false
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.694Z azure:service-bus:error [connection-2] The sender 'taskEmail-866d9187-59ef-ae4b-96ca-9075e90bb13b' with address 'taskEmail' is not open and is not currently establishing itself. Hence let's try to connect.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] connected <IP_ADDRESS>:48844 -> xx.xx.xx.xxx:5671
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 8 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 63 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] got frame of size 63
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 26 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] got frame of size 26
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 8 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 70 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] got frame of size 70
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Connection got event: connection_open
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.711Z rhea-promise:translate [connection-2] Translating the context for event: 'connection_open'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 34 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] got frame of size 34
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Session got event: session_open
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.714Z rhea-promise:translate [connection-2] Translating the context for event: 'session_open'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 106 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] got frame of size 106
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Link got event: sender_open
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.718Z rhea-promise:translate [connection-2] Translating the context for event: 'sender_open'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 35 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] got frame of size 35
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Link got event: sender_flow
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.718Z rhea-promise:translate [connection-2] Translating the context for event: 'sender_flow'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Link got event: sendable
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.719Z rhea-promise:translate [connection-2] Translating the context for event: 'sendable'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 111 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] got frame of size 111
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Link got event: receiver_open
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.720Z rhea-promise:receiver [connection-2] receiver got event: 'receiver_open'. Re-emitting the translated context.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.720Z rhea-promise:translate [connection-2] Translating the context for event: 'receiver_open'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.720Z rhea-promise:receiver [connection-2] Resolving the promise with amqp receiver 'cbs-1831a3ee-ef7c-8947-baa8-8ddb02a1c7e0'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 23 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] got frame of size 23
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Received disposition for outgoing transfers
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Link got event: accepted
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.781Z rhea-promise:translate [connection-2] Translating the context for event: 'accepted'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Link got event: settled
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.782Z rhea-promise:translate [connection-2] Translating the context for event: 'settled'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 141 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] got frame of size 141
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Link got event: message
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.782Z rhea-promise:receiver [connection-2] receiver got event: 'message'. Re-emitting the translated context.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.782Z rhea-promise:translate [connection-2] Translating the context for event: 'message'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.783Z azure:service-bus:error [connection-2] Trying to create sender 'taskEmail-866d9187-59ef-ae4b-96ca-9075e90bb13b'...
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 34 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] got frame of size 34
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Session got event: session_open
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.843Z rhea-promise:translate [connection-2] Translating the context for event: 'session_open'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 188 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] got frame of size 188
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Link got event: sender_open
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.845Z rhea-promise:translate [connection-2] Translating the context for event: 'sender_open'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] read 38 bytes
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:io [connection-2] got frame of size 38
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Link got event: sender_flow
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.846Z rhea-promise:translate [connection-2] Translating the context for event: 'sender_flow'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] Tue, 05 May 2020 22:47:47 GMT rhea:events [connection-2] Link got event: sendable
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.846Z rhea-promise:translate [connection-2] Translating the context for event: 'sendable'.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.846Z azure:service-bus:error [connection-2] Sender 'taskEmail-866d9187-59ef-ae4b-96ca-9075e90bb13b' with address 'taskEmail' has established itself.
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.846Z azure:service-bus:error [connection-2] Promise to create the sender resolved. Created sender with name: taskEmail-866d9187-59ef-ae4b-96ca-9075e90bb13b
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] 2020-05-05T22:47:47.846Z azure:service-bus:error [connection-2] Sender 'taskEmail-866d9187-59ef-ae4b-96ca-9075e90bb13b' created with sender options: { name: 'taskEmail-866d9187-59ef-ae4b-96ca-9075e90bb13b',
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9]   target: { address: 'taskEmail' },
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9]   onError: [Function],
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9]   onClose: [Function],
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9]   onSessionError: [Function],
May 06 06:47:47 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9]   onSessionClose: [Function] }
May 06 06:47:51 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] operation-name="on" svc-name="event-listener" timestamp="2020-05-05T22:47:51.215Z" type="error" msg="Process uncaughtException: Error: read ECONNRESET" stack-trace="Error: Process uncaughtException: Error: read ECONNRESET |     at Object.logError [as error] (/task-svc/app/utils/logger.js:24:13) |     at process.on (/task-svc/app/event/index.js:24:10) |     at process.emit (events.js:203:15) |     at process._fatalException (internal/bootstrap/node.js:497:27) |     at process._asyncFatalException [as _fatalException] (/task-svc/node_modules/async-listener/glue.js:211:34)"
May 06 06:47:54 event-listener core[task-svc-listener-deployment-659bb4b799-zzkb9] src-file="/task-svc/app/event/index.js" operation-name="line-38" svc-name="event-listener" timestamp="2020-05-05T22:47:54.151Z" type="info" msg="Starting event-listener"

@snuffykl
Would it be possible for you to modify your test environment to include the change from rhea in your app? This would involve making this change in your node_modules/rhea/lib/connection.js file.
Otherwise once the new version of rhea is released you should just need to reinstall your node modules to get the latest version and test.

@chradek @snuffykl
We've encountered the same issue in our project. I was able to reproduce it also by disconnecting WiFi and I can confirm that with @chradek fix I stopped seeing ECONNRESET
I'm looking forward for the new rhea release.

@chradek I've deployed the fix that you suggested to my test environment. It looks like it fixes it. No more crashing now and i did a logging Destroyed socket after successfully executed this.socket.destroy(). Just wondering when will rhea publish the new version ?

@Rviku @snuffykl
rhea version 1.0.21 has been released with this fix. If you reinstall your node_modules you should get the latest version of rhea. (Note that you might need to clear any lockfiles, e.g. package-lock.json if you're using them to make sure 1.0.20 gets installed).
I just tested with a clean install of @azure/service-bus and verified that the latest version of rhea was installed.

I'm closing this issue since rhea 1.0.21 is out now and @azure/service-bus will pick it up when installing node modules.
If you continue to face this issue please feel free to post here or open a new issue.

We have just released an update to the @azure/service-bus package where the min version of rhea has been updated to 1.0.21 so that any existing application upgrading to latest service bus package will get the latest rhea package as well.
Thanks for reporting @snuffykl!


EID-1495 Configure EIDAS's VSP to use logstash for logging and Java 1…

…1 for running and building
Create verify-proxy-node-vsp-config directory.  Put custom Dockerfile in that directory along with a custom verify-service-provider.yml.
This can and should be deployed before changes to verify-eidas-pipelines.

Merging.... 🤞 !


Multiple conditions in retry policy

Description
Requesting the capability for multiple conditions in Emissary Ingress retry policy
Example
retry_policy:
retry_on: "connect-failure,5xx,retriable-4xx,"
num_retries: 2
Affected version
Emissary Ingress 2.2.2

Thanks for opening this discussion @anoopmash!
From what I understand reading https://www.getambassador.io/docs/edge-stack/latest/topics/using/retries/#retry_on, 5xx also includes connect-failure and refused-stream.
Can you help explain your use-case for having a retry scheme composed of multiple failure codes?


Is it possible to have the actions done as a bot?

Hey! Thanks for creating this action.
I was wondering if it's possible to have the actions (like the commits, branch and comments creation) done as non user? Is there a different token I could use for this?I'm currently using a PAT. I'm trying not to get pinged each time a branch/issue is created 😄
A bit more context, i'm currently using a different token like here https://github.com/github/licensed/blob/31b44067a069b7601060af337d7c27571486728f/.github/workflows/licensed.yml#L53.

@louim there is no default token available specifically for this action.  That said, you should be able to use any GitHub authorization token that's valid for the actions that you mentioned.
Also, you don't necessarily need to use a custom PAT, ${{ secrets.GITHUB_TOKEN }} may work for your needs.  There are [scenarios where the default actions token may not work]https://github.com/jonabc/licensed-ci#authentication), and it looks like I need to update the readme to also call out a limitation from the actions help documentation.  If none of those apply to your usage though, you might be ok with GITHUB_TOKEN?

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.

@jonabc yeah, sorry I wasn't clear, I'm using a custom PAT to get around the reason you mention (default action token not re-triggering a run).

Ah I see.  Yeah unfortunately there's no common PAT or other authorization mechanism I'm aware of to bypass notifications when using a PAT on your account. I haven't kept close track of changes or updates to notifications and token usage though, maybe there's something in the help docs?
If not, would creating a helper/bot type user account be an option and using PATs created on the other account to restrict or manage notifications?

you can use https://github.com/actions/create-github-app-token. Just register an app that you want to be the actor with the permissions and access needed, then pass the token into this action and you should be golden


MI:0808 (comigration in sds page) clarification/fixes

Hello,
can someone confirm/deny that this term, as currently defined:

Method allowing the detection of strong interactions between two
molecules by their very close proximity or the overlap of their
relative bands in a denaturing SDS gel.

applies only to hetero-dimers ?
If it, indeed, does, it should be modified as 'their very close proximity' seems to
refer to any two molecules (not bands) which, in turn,  seems to include
homo-dimers -  note that the band corresponding to a protein that runs at
twice (three, four, etc times) its molecule weight implies 2,3,4, etc molecules
are running together so, technically, it is covered by the current definition.
If the terms is supposed to cover a more generic case of any complex
it should clearly say so without explicitly referring to exactly two
molecules.
if it is somehow advantageous to separate homo-oligomer detection from
hetero-oligomer detection the definition should be modified to clearly say
so.  Note that it would imply  homo-oligomers could  be annotated using
only parent term unless a mixture of differentially labeled (or tagged)
molecules  is used and each is detected separately. Fair and square,
but it this is the case it should be clearly stated in ht definition.
Comment:  Personally, I don't think there's much to be gained by treating
homo-oligomers in some special way - the experiments show
that the interacting molecules (2, 3 or more) comigrate in sds-page

this is independent of their identity (participant identification annotation
clarifies if it is because of the band position or by testing for participant
presence).  I would also substitute SDS with 'denaturing' gel - SDS seems to be
the most popular  for proteins but every now an then other denaturing agents
(ie urea, particularly for nucleic acids) are used.  Please, also note that
running in close proximity (as stated in the definition) is not sufficient,
unless all molecules run within a single band (and even then it is necessary
but not sufficient condition - vide two proteins of the same molecular weight)

Also note that, in case homo-oligomers should be treated separately
from hetero-oligomers there are more terms to be split the same way
(eg. gel filtration &  centrifugation based methods). These methods are
prone to the same problems as denaturing electrophoresis (every now
and then things do run at the wrong place - membrane proteins, proteins
of strange shapes and charge) so for consistency all of them should
be treated the same way.
My preferred version of the definition would read, more or less:
A method allowing the detection of strong interactions between two
or  more molecules as running, all of them, within a single band in
a denaturing gel.
lukasz

Agreed and definition amended to your proposal.

sigh... the modified definition now reads:

The interaction of two molecules is determine by their very close proximity or the overlap of their relative bands in a gel.

apart from missing 'd' in 'determine', it is still not clear how
to deal with homo-oligomers - I read the definition and homo-oligomers
seem ok but others might claim they are not.  if only hetero-oligomers
are ok then the definition should mention 'distinct molecules'.
to make the definition worse, it now says 'two molecules' -  does it
mean the term cannot be applied to heterotrimers ???  I've got no
problem imagining three (or more) subunits of a membrane complex
running together even on sds-page gel :o(
lukasz

Definition amended, here's the new one:
"The interaction of two or more molecules is determined by their very close proximity or the overlap of their respective bands in a gel."
Pushing it to the repo in a few minutes, please suggests any changes if you see fit.

By the way, related terms have also been amended accordingly.


SPARK-5217 Spark UI should report pending stages during job execution on AllStagesPage.

This is a first step towards having time remaining estimates for queued and running jobs. See SPARK-5216

Test build #25544 has started for   PR 4043 at commit d335f8f.

This patch merges cleanly.

Test build #25545 has started for   PR 4043 at commit f6dc584.

This patch merges cleanly.

Test build #25544 has finished for   PR 4043 at commit d335f8f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25544/
Test PASSed.

Test build #25545 has finished for   PR 4043 at commit f6dc584.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25545/
Test PASSed.

lgtm.
I was going to suggest that pending stages should be sorted with oldest submission time first, not reversed ... but I guess we want the completed stages sorted with oldest last, and probably makes sense to keep those tables consistent with each other.

Hi Imran, Thanks for taking a look. @pwendell please take a look ?

I'm not sure this can be merged as-is. The state clean-up here is based on the assumption that every stage that is pending will at some later time be submitted. Is that definitely true? What happens if a stage is aborted or failed, won't its dependent stages remain pending indefinitely for the entire history of the application? I think at a minimum you need to make sure you remove all associated stages with a given job if the job ends. There may also be other corner cases I'm not thinking of.
A second assumption this makes is that the job start event will always occur before the stage is submitted. Is that definitely true? It would be good to dig through the reporting API and make sure that is a safe assumption. I think the guarantees of the listener around event ordering are pretty minimal.
Finally, what about putting pending stages after active stages in the display page? My concern is you may have dozens or more pending stages in production jobs, I think people will be frustrated if they open the UI and they have to scroll way down every time they need to e.g. refresh the page. It's a big odd to go (active -> pending -> completed), but I think better for usability.

Thanks Patrick !
Have two questions inline.

I'm not sure this can be merged as-is. The state clean-up here is based on the assumption that every stage that is pending will at some later time be submitted. Is that definitely true? What happens if a stage is aborted or failed, won't its dependent stages remain pending indefinitely for the entire history of the application? I think at a minimum you need to make sure you remove all associated stages with a given job if the job ends. There may also be other corner cases I'm not thinking of.

If I am understanding this correctly, "All stages for a particular job Id on jobEnd event - should be cleaned up". I am certainly missing something, is this not already achieved by this ?

A second assumption this makes is that the job start event will always occur before the stage is submitted. Is that definitely true? It would be good to dig through the reporting API and make sure that is a safe assumption. I think the guarantees of the listener around event ordering are pretty minimal.

This can lead to an anomaly that a stage will appear in progress in both active stages section and pending section. But it will still be obvious that - that stage is in progress. Is this safe to ignore, or is it a  concern that should be addressed at the cost of minute complexity ?

Finally, what about putting pending stages after active stages in the display page? My concern is you may have dozens or more pending stages in production jobs, I think people will be frustrated if they open the UI and they have to scroll way down every time they need to e.g. refresh the page. It's a big odd to go (active -> pending -> completed), but I think better for usability.

This is thoughtful, I am going to incorporate this asap.

Ah I see - so on the first point, the issue may be covered by the code you referenced. For some reason the diff originally rendered in a way where I didn't notice that.
For the second issue. My concern is that this line could throw an exception:
https://github.com/apache/spark/pull/4043/files#diff-1f32bcb61f51133bd0959a4177a066a5R263
I.e. if you had a stage submitted, but you never received the job started event.

Good point, in map in scala remove returns an Option and does not throw exception. However in lists what you said holds. See https://github.com/scala/scala/blob/2.11.x/src/library/scala/collection/mutable/LinkedHashMap.scala#L76

Test build #25644 has started for   PR 4043 at commit c7b3332.

This patch merges cleanly.

@ScrapCodes Rather than change this to +LinkedHashMap+ can you just check if it contains it before removing it? It might not be obvious to developers that +remove+ has that specific behavior. I think it's better to just be explicit.

LinkedHashMap was introduced to maintain the insertion order of stagesIds(Hasmap will lead to arbitrary order), all map(s) in scala has return an Option on remove behavior. Even in java calling remove on inexistent key returns null. Do you still want me to change it? Also may be changing the name pendingStages to pendingStagesMap will avoid that confusion ? and should the same apply to - already existing field activeStages ?

ah I see - if the existing remove call is safe, then I think it's fine.

Test build #25644 has finished for   PR 4043 at commit c7b3332.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25644/
Test PASSed.

Test build #25656 has started for   PR 4043 at commit 15cdda4.

This patch merges cleanly.

Test build #25656 has finished for   PR 4043 at commit 15cdda4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25656/
Test PASSed.

@ScrapCodes mind bringing up to date? The current form LGTM

Test build #25748 has started for   PR 4043 at commit 3b11803.

This patch merges cleanly.

@pwendell - patch updated to latest master.

Test build #25748 has finished for   PR 4043 at commit 3b11803.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25748/
Test PASSed.


Finding x coordinate?

Hi @gitbrent,
Is there a way in which I can get the x coordinate of one of the bar in bar chart? Is there a property that i can use or a method?

Hi @phavanagi ,
There is no way to determine the x value that I know of.
What are trying to do?  There are several options for placing the value, etc.


Enable travis-ci for this repository?

The repository contains a .travis.yml file, but travis-ci does not seem to be enabled. I believe it would be helpful for pull request if it was enabled.
What do you think?

indeed :+1:

Done

Thanks! :+1:


ReaderIO asksIO

And others.

What would be the use case for asksIO? 🤔 Just a stricter R.asks?
e.g export const asksIO: <R1, A>(f: (r1: R1) => IO.IO<A>) => RIO.ReaderIO<R1, A> = R.asks
Would you mind expanding on the and others? 😝 Are you looking for asksTaskEither on RTE and similar operations?

It's been a while! Let's think.
I think if you're in a stacked monadic context like ReaderIO it's ideal if everything you need exists in that module/namespace. Additionally I think R.asks only works there by relying on an implementation detail in how fp-ts represents stacked monads.
I suspect that's indeed what I meant by "and others". The same would apply to every ReaderT-based type.

Blocked awaiting fp-ts 2.13.

https://github.com/samhh/fp-ts-std/commit/922f0bad63524adecb0fbcb0b128cb9bd1772ff1..https://github.com/samhh/fp-ts-std/commit/355d472c36e359d3b51221ae1ae61956372bcb77


Bug 1291709 - PdfjsChromeUtils.jsm leaks browser.xul windows.

https://bugzilla.mozilla.org/show_bug.cgi?id=1291709

Looks good to me after reading about how WeakSet works. Could someone with more understanding about the extension code than me verify and merge?

This seems fine to me, but the question is why it's actually necessary!?
Unless I'm mistaken, when the viewer unloads (see PdfStreamConverter.jsm#L831-L835) we send the PDFJS:Parent:removeEventListener message (see PdfStreamConverter.jsm#L857).
That message is then handled by the parent in PdfjsChromeUtils.jsm#L161-L162, and within the _removeEventListener method the browser in question is actually removed from the Set (see PdfjsChromeUtils.jsm#L236).
Why is the existing code not working as intended?
Could it be that because the message is asynchronous it arrives after the browser has already been thorn down, and the _removeEventListener method is thus never invoked!?

This seems fine to me, but the question is why it's actually necessary!?

Good point, looking a bit closer it seems we never receive the message PDFJS:Parent:removeEventListener in pdfjschromeutils.jsm. Still not sure why though...

Good point, looking a bit closer it seems we never receive the message PDFJS:Parent:removeEventListener in pdfjschromeutils.jsm. I see it being sent from pdfstreamconverter side though.

I've also done some quick testing, and it seems that things work as expected when navigating away from the PDF viewer (i.e. by going to a new web page in the same tab as the PDF viewer).
In contrast, what does not work is when the tab/window containing the PDF viewer is simply closed, which makes me suspect that my earlier idea might be correct:

Could it be that because the message is asynchronous it arrives after the browser has already been thorn down, [...]

There must be some kind of close/quit/... event that we could listen for to handle the latter case, but I'm wondering if it's worth the trouble of figuring that out if just using a WeakSet does the job!?

There must be some kind of close/quit/... event that we could listen for to handle the latter case, but I'm wondering if it's worth the trouble of figuring that out if just using a WeakSet does the job!?

I think you can listener to the "unload" event on the browser window.  This is the browser.xul window.  Its not clear to me exactly what this corresponds to in the pdfjs extension, though.
We added something similar to AutoCompleteE10S.jsm:
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/satchel/AutoCompleteE10S.jsm#97
I agree its better to just listen for the unload instead of using WeakSet.

In auto complete code the "browser window" is coming from message.target.ownerDocument.defaultView:
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/satchel/AutoCompleteE10S.jsm#199

I think you can listener to the "unload" event on the browser window. This is the browser.xul window. Its not clear to me exactly what this corresponds to in the pdfjs extension, though.
[...] message.target.ownerDocument.defaultView

@wanderview Thank you, this is most helpful information!
However, in my testing, this unfortunately does not seem to be a complete solution:

When the entire browser window is closed, listening for the unload event as suggested above works just fine.
When only the current tab is closed, but the browser window remains open, the unload event does not seem to fire.
Is this not an issue (perhaps because closed tabs can be re-opened), or do need to try and remove the browser from the Set in this instance too?
(I've looked through http://searchfox.org/mozilla-central/source/browser/base/content/tabbrowser.xml quickly, and there doesn't seem to be a close event that we can use.)

There was a comment that appears to have been deleted, but just to clarify:
I believe you have to listen for tab close and window close separately.  This sucks and I would prefer that closing the window trigger tab closes as well, but it doesn't currently do it.  Not sure if we can add that without breaking code that does not expect to get two close events.

There was a comment that appears to have been deleted, but just to clarify:

Sorry about that; I removed my previous comment since it didn't really think it thought properly.

I believe you have to listen for tab close and window close separately. This sucks and I would prefer that closing the window trigger tab closes as well, but it doesn't currently do it. Not sure if we can add that without breaking code that does not expect to get two close events.

That's unfortunate, and it confirms what I've seen when testing this. Trying to call e.g. _removeEventListener in all the various cases (i.e. navigating away from the viewer, closing the tab, and closing the window), seems to easily trigger the error in PdfjsChromeUtils.jsm#L233.

Should we merge the patch in its current form? It would be good to stop leaking windows and from the comments above other approaches have obvious downsides. What do you think?

Should we merge the patch in its current form? It would be good to stop leaking windows and from the comments above other approaches have obvious downsides. What do you think?

I'd be in favour of taking this PR in its current form as a temporary fix, so that we at least won't keep old browser.xul instances around forever.
However, I really think that we need to solve this properly, it's just that a complete solution (i.e. one covering: navigating away from the viewer, closing the tab, and closing the window) unfortunately doesn't seem entirely straightforward to implement.

FWIW, I filed a bug to create a new event type that is fired for either tab close or window close:
https://bugzilla.mozilla.org/show_bug.cgi?id=1296099
Seems like the best long term solution to me.  In the meantime, though, it would be nice to land the WeakSet().  I ran into this leak through normal browsing again today.


bug/jenkins 36128 - durations not updating

Related to issue # JENKINS-36128
Summary of changes:

Enhance TimeDuration component to support live updating. Using a much less aggressive 30s update interval. Long term I'd like to improve this further to use an intelligent setInterval period (similar to exponential backoff).
Updated PipelineResult to support live updating. ReadableDate always live updates; TimeDuration only updates while the result is actually running.

@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

:bee:


'Delete' account not responding

Steps:
1.Visit https://nightly2.apinf.io
2.Create account by clicking on 'Sign up'
3.Navigate to 'Account' section
4.Click on 'Delete Account'
5.Click on 'Delete' button in user confirmation dialog box
Findings:

Clicking on 'Delete' button doesn't respond. It  allows to close user confirmation dialog.
It doesn't display successful dialog
Logs out but still shows 'Account' view

Expected Result: Delete account should be complete and must display successful dialog.
Browser:

Mozilla Firefox 48.0
(Mozilla Firefox for Ubuntu Canonical – 1.0 )
Google Chrome 52.0.2743.116

Operating System:

Ubuntu 16.0 LTS

Screenshot:

@saralavanip Can you add info on your environment, particularly browser and version?

@bajiat , please find the browser details updated .
Browser:

Mozilla Firefox 48.0
(Mozilla Firefox for Ubuntu Canonical – 1.0 )
Google Chrome 52.0.2743.116

Operating System:

Ubuntu 16.0 LTS


H600D bulbs not appearing

Version of the custom_component
Latest
Describe the bug
Currently, the H600D bulbs, and a few others, do not show up when using this integration. This appears to be because they use a slightly different version of the API to get device info and control them. In order to get the devices, this is the command.
curl --request GET \
     --url https://openapi.api.govee.com/router/api/v1/user/devices \
     --header 'Govee-API-Key: e9213276-4488-43c9-bb14-8b5422474553' \
     --header 'accept: application/json'

Changing the URL from https://developer-api.govee.com/v1 to https://openapi.api.govee.com/router/api/v1/user/devices allows the bulbs to show up. It appears to be a slightly different API version.
I have verified that using my API key, the H600D bulbs show up in the response, proving that they support the API. However, the response appears to be in a different format to the current API. Here is just the response for one of my H600D bulbs.
{"sku":"H600D","device":"MAC_ADDRESS","deviceName":"Bulb 4","type":"devices.types.light","capabilities":[{"type":"devices.capabilities.on_off","instance":"powerSwitch","parameters":{"dataType":"ENUM","options":[{"name":"on","value":1},{"name":"off","value":0}]}},{"type":"devices.capabilities.range","instance":"brightness","parameters":{"unit":"unit.percent","dataType":"INTEGER","range":{"min":1,"max":100,"precision":1}}},{"type":"devices.capabilities.color_setting","instance":"colorRgb","parameters":{"dataType":"INTEGER","range":{"min":0,"max":16777215,"precision":1}}},{"type":"devices.capabilities.color_setting","instance":"colorTemperatureK","parameters":{"dataType":"INTEGER","range":{"min":2700,"max":6500,"precision":1}}},{"type":"devices.capabilities.music_setting","instance":"musicMode","parameters":{"dataType":"STRUCT","fields":[{"fieldName":"musicMode","dataType":"ENUM","options":[{"name":"Energic","value":5},{"name":"Rhythm","value":3},{"name":"Spectrum","value":6},{"name":"Rolling","value":4}],"required":true},{"unit":"unit.percent","fieldName":"sensitivity","dataType":"INTEGER","range":{"min":0,"max":100,"precision":1},"required":true},{"fieldName":"autoColor","dataType":"ENUM","options":[{"name":"on","value":1},{"name":"off","value":0}],"required":false},{"fieldName":"rgb","dataType":"INTEGER","range":{"min":0,"max":16777215,"precision":1},"required":false}]}},{"type":"devices.capabilities.dynamic_scene","instance":"lightScene","parameters":{"dataType":"ENUM","options":[]}},{"type":"devices.capabilities.dynamic_scene","instance":"diyScene","parameters":{"dataType":"ENUM","options":[]}}]}]}
It seems Govee have changed their API for some newer devices. I don't fully understand why, or how it works, but hopefully the integration can be updated to support these bulbs.
If I can help test anything with this new API/Bulbs, I would be happy to too!

i have this exact problem, what can i do then to fix this problem?

i tried what this commenter did, and he's right, my led bulbs are working this way, however i tried to change it by going into the file and finding where you can change some stuff, and i couldn't find a way to change it, so id suggest trying to find an alternative until they fix this issue. also the new API works with other govee devices that still works with the old one

I was also unable to find how to change it unfortunately, but I have found some more documentation on this new API, which appears to be much more powerful. @LaggAt I know you seem to have stopped work on this integration, but any chance you might be able to take a look at this?

Found another solution, this integration https://github.com/wez/govee2mqtt has full support for the bulbs

Found another solution, this integration https://github.com/wez/govee2mqtt has full support for the bulbs

But does These bulbs support Local lan? i can't find the button that allows local lan on these bulbs. does it work for you

IT WORKS, I thought this was for local API. thanks. however it's kinda slow and i can't set the actual white colour


Helm chart

provide a helm chart (with just the Apigee istio-policy and istio-telemetry)
provide instructions on how to upgrade Istio (installed via helm from OSS) to use the Apigee adapter

Rework install procedure as a whole for internal mixer. Should look like:
Step 1: Install Istio from OSS
Step 2: Upgrade default mixer to Apigee's
Step 2 may be accomplished using kubectl apply or a helm chart.

To update the mixer, would be possible to run the OSS helm chart overriding the default value of the mixer image? Will test this and see
helm install \
--wait \
--name istio \
--namespace istio-system \
install/kubernetes/helm/istio \
--set global.configValidation=false \
--set sidecarInjectorWebhook.enabled=false \
--set mixer.image=gcr.io/apigee-api-management-istio/istio-mixer:1.0.2


How can I perform testing on other datasets

How can I perform testing on other datasets, such as the LOL dataset, and obtain the desired results? What should the corresponding npz format look like? Thank you for your assistance.

Hi, you can modify this imagenet_dataloader/save_random_images_hdr.py to obtain the .npz files.

Thanks for your help！

Hi, you can modify this imagenet_dataloader/save_random_images_hdr.py to obtain the .npz files.

I use the save_random_images_hdr.py script to make an npz file of an LR image. Is it possible? Because the code seems to only save one img and label? ~
    imgs_high = []
    labels = []
    for i, (data, data2) in enumerate(zip(dataloader, dataloader2)):

        x, y = data
        x2, y2 = data2
        print(x2.shape)
        # imgs.append(x)
        imgs_high.append(x2)
        labels.append(y)

    # imgs = torch.cat(imgs, dim=0)
    imgs_high = torch.cat(imgs_high, dim=0)
    labels = torch.cat(labels, dim=0)

    file_name_high = ('hdr_100_long_resolution_%d' % image_size2)
    ......

   file_name_high_1 = ('hdr_100_long_resolution_%d.npz' % image_size2)
    np.savez(file_name_high_1, imgs_high, labels)


F-Droid build failed

mobile_scanner is based on mlkit which is not FOSS. Could you please take a look? Thanks!

Ouch. thanks for the hint. The problem is that mobile_scanner performs so much better than what we had before....
We'll have to check options

There is no way how we can have both benefits currently, so we'll do a separate branch for f-droid which is pure FOSS and uses the worse-performing lib but still gets all other updates:
https://github.com/encointer/encointer-wallet-flutter/issues/709

Thanks!

We have fixed this now, the f-droid branch is now used to publish to f-droid.
The corresponding merge request to f-droid is here: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/12087#note_1170016967


Roll Flutter Engine from 58dc868c26cb to 591bf9f64bc6 (5 revisions)

https://github.com/flutter/engine/compare/58dc868c26cb...591bf9f64bc6
2023-08-23<EMAIL_ADDRESS>[web] Remove some unused functions (flutter/engine#44505)
2023-08-23<EMAIL_ADDRESS>Use decal TileMode in blur image_filter_test.dart (flutter/engine#45004)
2023-08-23<EMAIL_ADDRESS>FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#44996)
2023-08-23<EMAIL_ADDRESS>[impeller] combine sampler and texture maps. (flutter/engine#44990)
2023-08-23<EMAIL_ADDRESS>[Impeller] Flutter GPU: Add HostBuffer. (flutter/engine#44696)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


[DUOS-623][risk=no] Fix election translated use restriction display

Addresses
https://broadinstitute.atlassian.net/browse/DUOS-623
Bug fix PR.
Changes

Apply the same escape pattern for election translated use restriction field
Refactor common code usage

Thank you @mackenziekerwin!


Improve Voyager assets handling

[X] VoyagerServiceProvider now publishes the assets to config('voyager.assets_path')
[X] Add voyager_asset() helper function to be used in the views
[x] Change all views to use voyager_asset()

@marktopper this maybe merged.


Deprecate CompactionHost.getType

Is your feature request related to a problem? Please describe.
In 4.0.0 CompactionHost.getType can return TSERVER.  However the implementation will never return this as that functionality was removed.  Need to deprecate this.
Describe the solution you'd like
Deprecate CompactionHost.getType and CompactionHost.Type.  Remove almost all use of the deprecated types in the code.  Can use the enum in a single place in ActiveCompactionImpl and there always return COMPACTOR.  Can also remove usage in the shell code where a host prefix is calculated for list compactions.
Describe alternatives you've considered
Considered deprecating in 3.1.0, however it is not possible to stop using the method in 3.1.0.  Can only stop using the method in 4.0.0.

Realized that tablet servers still report minor compaction/flushes so for that case it does not make sense to deprecate this API.


[BUG] Select Component breaks when Value Property is set to Entire Object

Environment
Please provide as many details as you can:

Hosting type

[x] Form.io

Formio.js version: 4.14.8
Frontend framework: Angular 14.0.0
Browser: Google Chrome
Browser version: 105.0.5195.127 (Official Build) (64-bit)

Steps to Reproduce

Follow and complete the Application Development Guide.

Edit register.module.ts to remove event from parents:
 parents: [
  {
    field: 'user',
    resource: 'currentUser',
    filter: false
  }
]

Edit the Registration Form to set the Value Property and Item Template of  the Event select component as follows:
Value Property: {Entire Object}
Item Template: <span>{{ item.data.title }}</span>

Navigate to the "New Registration" page. Click the Event select and pick an option. See how the select component is broken when the data value property is set to "Entire Object" (see example screenshot below). Make a submission.

In the formio project, select the registration submission from the Data tab and click Export JSON. See how the event object is wrongfully saved as serialized json:
"data": {
         "event": "{\"title\":\"Super Bowl Party\",\"description\":\"\",\"date\":\"2022-09-29T09:00:00.000Z\",\"submit\":true}",

Expected behavior

The Event select component should display item.data.title as options based on the configured Item Template.

The Event select component should save the event object in proper json format:
"event": {
     "data": {
         "title": "Super Bowl Party",
         "description": "",
         "date": "2022-09-29T09:00:00.000Z",
         "submit": true
     }
 },

Observed behavior

The Event select component displays the entire object contents:

The Event select component saves the object as serialized json:
"data": {
         "event": "{\"title\":\"Super Bowl Party\",\"description\":\"\",\"date\":\"2022-09-29T09:00:00.000Z\",\"submit\":true}",

Example

"data": {
         "event": "{\"title\":\"Super Bowl Party\",\"description\":\"\",\"date\":\"2022-09-29T09:00:00.000Z\",\"submit\":true}",

We're currently addressing a backlog of GitHub issues, and as part of this effort, some inactive issues may be marked as closed. This isn't a dismissal, but a step toward more efficient tracking.
If you feel the issue is still relevant, please re-open and we'll ensure it gets the attention it deserves. Your understanding is appreciated as we work to enhance our open-source responsiveness.


Documentation: ClientAndProxy not available anymore

The usage documentation for Running Mock Server  via Java API states to use
import static org.mockserver.integration.ClientAndProxy.startClientAndProxy;
import static org.mockserver.integration.ClientAndServer.startClientAndServer;

Unfortunately ClientAndProxy is only available in 5.3.0 as it seems but not 5.4.1.
And updated usage example would be nice.

I'd say this is basically a duplicate of #508 as the base issue is, that the docs are for 5.3.0 and are outdated.
Server and Proxy were unified into only Server.

now fixed


Scan screen should subscribe to changes for camera permission

Current behaviour:
In the following scenario:

On phone B (scanning phone), turn off app permission to access camera
On phone A (requesting phone), go to REQUEST (third icon from left)
On phone B (sending phone) go to SCAN (second icon from left) – popup is displayed asking to activate camera
Click “Deny” – message is displayed informing that camera is needed with button "Allow access to camera"
On phone B, Go to “Home” page
On phone B (scanning phone) go to SCAN (second icon from left) – message is displayed informing that camera is needed with button "Allow access to camera"
Click “Allow access to camera” – taken to settings
On phone B, allow access to camera
Go back to app

the text “This app uses the camera...” is still displaying on SCAN screen. As a user it is unclear that I need to shift screen and go back in order to activate the camera.
Expected behaviour:
SCAN screen should automatically refresh and display scanning screen when camera permission has been enabled.

tested and verified Scan screen is already subscribing to changes for camera permission


device: migrate to comcast/wrp-go

Moves device package from webpa-common to wrp-go.

Hi Ryan, I don't think we should move forward with this until we get rid of webpa-common dependencies in wrp-go:
https://github.com/Comcast/wrp-go/search?q=webpa-common&unscoped_q=webpa-common
The plan is, once these dependencies are taken care of, to release a new major version of wrp-go that we can use in webpa-common.


https listener allow http request with a directive

We highly recommend that you differentiate between xquic and Nginx Quic implementations by using compilation options (maybe switch option --with-quic-implement=xquic) . Then in the documentation we can clearly explain the differences and advantages/disadvantages of each implementation. The final decision on which implementation to choose during the compilation phase should be up to Tengine's customers. It may seem unusual to support two implementations of the same protocol simultaneously at runtime.

I highly recommend that you differentiate between xquic and nginx quic implementations by using compilation options (maybe switch option --with-quic-implementation=xquic or --with-xquic) . Then in the documentation we can clearly explain the differences and advantages/disadvantages of each implementation. The final decision on which implementation to choose during the compilation phase should be up to Tengine's customers. It may seem unusual to support two implementations of the same protocol simultaneously at runtime.

This feature is not bind to XQUIC. It is a common feature for H1, H2 and H3.

I mean any tengine feature need to be incldued in a standalone macro, like #T_XXX_QUIC_XXXX, which makes it seperated with nginx source. You can enabled this macro in auto/have by default(see some examples) or enabled it by other module (see tongsuo option).

of course, all the tengine feature which includs xquic has T macro T_NGX_XQUIC.

Yes, if user wants to use xquic as HTTP/3 implementation, user will need to enable it which has the macro T_NGX_XQUIC specifically.

Yes, if user wants to use xquic as HTTP/3 implementation, user will need to enable it which has the macro T_NGX_XQUIC specifically.

Yeah, I have observed it has been enabled in ./modules/ngx_http_xquic_module/config

If the SSL 443 listen add a new option https_allow_http, https listener will allow http traffic.
        ## start server _
        server {
                server_name _ ;

                listen 80 default_server reuseport backlog=4096 ;
                listen [::]:80 default_server reuseport backlog=4096 ;
                listen 443 default_server reuseport backlog=4096 ssl http2 https_allow_http ;
                listen [::]:443 default_server reuseport backlog=4096 ssl http2 https_allow_http ;
                listen 443 default_server reuseport backlog=4096 xquic ;
                listen [::]:443 default_server reuseport backlog=4096 xquic ;

                ingress_gateway shm_service_cfg;
                ingress_gateway_metadata "ssl-protocols" $metadata_ssl_protocols;

                # set log host
                set $log_host $host;

                set $proxy_upstream_name "-";

                ssl_certificate_by_lua_block {
                        certificate.call()
                }

                location = /status.tengine {
                if ($host !~* "^\d{1,3}(\.\d{1,3}){3}|^status\.tengine\.com$") {
                        return 404;
                        break;
                }
                sysguard off;
                access_log off;
                root /etc/nginx/htdocs;
        }

sh-4.4# curl -i http://<IP_ADDRESS>:80/status.tengine
HTTP/1.1 200 OK
Server: Tengine/3.1.0
Date: Thu, 02 Nov 2023 03:34:31 GMT
Content-Type: text/html
Content-Length: 0
Last-Modified: Thu, 02 Nov 2023 03:31:20 GMT
Connection: keep-alive
ETag: "65431808-0"
Accept-Ranges: bytes

sh-4.4# curl -i http://<IP_ADDRESS>:443/status.tengine
HTTP/1.1 200 OK
Server: Tengine/3.1.0
Date: Thu, 02 Nov 2023 03:34:35 GMT
Content-Type: text/html
Content-Length: 0
Last-Modified: Thu, 02 Nov 2023 03:31:20 GMT
Connection: keep-alive
ETag: "65431808-0"
Accept-Ranges: bytes


hey men i cloned you project demo but it not work i get maven errors

I using IDE eclipse Luna SR2 the problem is on 0.10.0-SNAPSHOT not found
Description	Resource	Path	Location	Type
Missing artifact ro.fortsoft.pf4j:pf4j:jar:0.11.0-SNAPSHOT	pom.xml	/pf4j-demo-api	line 28	Maven Dependency Problem

I using IDE eclipse Luna SR2 the problem is on 0.10.0-SNAPSHOT not found

Maybe 0.11.0-SNAPSHOT not found
What command you use? You cloned the demo project in a personal new project/folder? Try to run mvn clean install from pf4j folder (to install pf4j.jar in your local maven repository) and try again to build your project.

@sirlordt Any resolution for this issue?

Sorry i not try again, i busy another develop issues not related with this lib.
Thanks for your concern.


this.setState({}) not change SegmentedControls

I face a bug.
getInitialState: function() {
  return {
    gender: 'Male'
  };
},
_press() {
  this.setState({gender: 'Female'});
}
render() {
...
  <SegmentedControls
    options={ ['Male', 'Female'] }
    onSelection={ (value) => {this.setState({gender: value}) }}
    selectedOption={ this.state.gender }
  />
...
}

When I press button to call _press, the selection of SegmentedControls is not changed. I am sure this.setState({gender: 'Female'}); works correctly, this.state.gender is changed to right value.
Does it exist a bug? Thank you!

Sorry about the answering delay. The bug you're facing comes from your code. You need to bind the function your are passing.
<SegmentedControls
    options={ ['Male', 'Female'] }
    onSelection={ function(value) { this.setState({gender: value}) }.bind(this) }
    selectedOption={ this.state.gender }
  />


Mark 10 14

This contains a number of fixes, mostly minor. The pipeline now works for GHRS data, which required more/trickier revisions than I would have hoped. It repairs several bugs that were apparent in the XML labels I noticed when we spoke last week. I have regenerated all XML labels in Dropbox under "HST-from-Mark". At the moment, these all generate without any apparent errors.

P.S. I don't plan to work on this any further for the next few weeks.

This pull request has 1,398 files changed.  Any pointers on which ones are important to look at?