Memory leaks when passing Drop objects to msg_send!

This is further investigation on SSheldon/rust-objc-foundation#9
I made an additional test to rust-objc that shows the issue here https://github.com/scoopr/rust-objc/commit/b637c967ddc81041f74d6c08fc5c8ec825a73665.
It has a minimal wrapper around the type that implements Drop, and then when used as an argument to msg_send!, it seems the drop is then never called. Using it just as a receiver for a method call does seem to work as expected.
I'm still not sure if the wrapper is wrong, or if there is a bug in msg_send!, or something else, but the fact is that there already is bunch of code that expects the drop to happen, and it would be really nice to have a solution without leaks :)

Thanks for the example @scoopr!
So let's look at this part of the example:
let obj = test_utils::WrappedObject::new();
unsafe { msg_send![..., isEqual:obj]; }

Rust and the objc crate have no idea what types are supposed to be passed to isEqual:, so it just uses the types given. In this case the type given for the first argument is WrappedObject. So behind the scenes the msg_send! macro converts this down to an external function call of a function that effectively looks like this:
unsafe extern fn isEqual(self: *mut Object, cmd: Sel, object: WrappedObject)

For a function with this signature, the WrappedObject will be moved into the function and the function takes ownership, meaning that the caller no longer owns the object and cannot drop it. So basically we're expecting isEqual to drop the object for us.
But isEqual won't do that; it's an Objective-C method implementation and it knows nothing about Rust objects or how to drop them. So instead the object is never dropped and will be leaked.
Another potential danger here is that the Objective-C method implementation is expecting a pointer to an object, and instead we're giving it a Rust struct. In this case it happens that the layout of the Rust struct is exactly a pointer, but if it has any other fields, we could be in trouble.
So I'd say when writing this unsafe code, we must ensure that we're not passing any non-repr(C) types and not moving in any type that implements Drop.
To avoid this, you can write your code like:
msg_send![..., isEqual:&*obj]

Or, even better, you could write a little wrapper function that enforces the types you expect:
impl WrappedObjectRef {
    unsafe fn isEqual(&self, object: &WrappedObjectRef) -> BOOL {
        msg_send![self, isEqual:object]
    }
}

With this wrapper function, the code would report:

expected reference, found struct WrappedObject
help: consider borrowing here: &obj

I'm trying to think if there's ways the objc crate can make it harder to have this error:

auto-dereferencing arguments? I'm not sure that's possible and it could have surprising results
enforcing that all message arguments are Copy? Could make sense and would catch this issue, but can't solve the general issue of passing the wrong inferred type.

For now though this is one of the things that needs to be manually audited when writing unsafe code without the usual compiler protections.
Does that all make sense and solve your issue? Let me know if you've got any other ideas about this.

I would very much like that there would be some enforcement that leaks wouldn't be quite as easy. I mean, rust-objc-foundation wrappers leak too if used in msg_send! arguments, and it isn't clear to me how they should be used instead.
First, I'm still not understanding what happens to the arguments. They are captured as.. tuples? which then implement MessageArguments trait? Why doesn't the tuple drop the contents at the end of the invocation?
One other solution I was thinking was having the Message trait have a method which would return the runtime::Object pointer, maybe have some default impl. Then it would be fairly unambiguous how a random type could be used as objc objects. But I guess that wouldn't necessary enforce the misuse by itself, but would be easy to fix in the macros that generate the wrappers.
I can't quite wrap my head around what kinds of dereferencing or inferring would/do happen in all this, so it may be I don't see the forest from the trees here.

It sounds to me that Copy bound addresses this concern rigidly, even though I share @scoopr inquiry about why the tuple doesn't get dropped in the first place...

can't solve the general issue of passing the wrong inferred type.

Perhaps, we can solve one thing at a time?


Workspace sharing dialog broken

If you try to share a workspace with enough users that the dialog needs to scroll, it snaps over and cover up the rest of the window that has the button to effect the sharing change. See video.
https://youtu.be/eGuLbt6kw48

Now I find I can scroll down to find the button, but the behavior is still pretty bizarre and it wasn't obvious that I had to do that scroll.


query methods

Can we add some query methods to this? Seems like payment should only be required to get the latest response...but couldn't old responses be cached and available once the current response has been received?
I'm sure this has been discussed, just wondering if I can bring this up.

Yes, this has been discussed. There is a small LRU cache of previously requested rates.
Since the cache is small, you won't be able to retrieve many old responses. On the contrary, you may only get recent rates, obviously just for pairs that were previously requested.
However, it doesn't cost much to increase the cache size and making a quick query call to check if there is a rate doesn't cost much, either. It may even be possible to increase the probability of success by asking for a rate in a certain time window (in the past).
Would it be useful to have a query endpoint that won't give you the most recent rate (as you said, payment should probably be required for this rate) and will only give you old rates in the recent past (that can be retrieved from the cache)?
If yes, do you think the cached rates should be certified?

No matter what time I give, it returns (# ForexInvalidTimestamp)
What should I do?


How to use raw query in grid?

Hi.
How to use raw query in grid?
thanks for your guide.

$grid->model()->where('id', '>', 100);
$grid->model()->orderBy('id', 'desc');
$grid->model()->take(100);

no. no. I don't want to use query builder. I need to use raw query. @bthiban

@enaeim
$grid->model()
->select(
\DB::raw(
'customers.name',
'loans.total as total_amount',
'sum(loan_payments.paid) as total_paid'
->orderBy('customers.name', 'desc')
->groupBy('loan_payments.loan_id', 'loan_payments.customer_id');
I hope this may help you.


[FEATURE] Companion Support

Add the ability to create Journal Entries for Companions and then drag and drop the Type (Tyrannosaurs, Raptors, etc. from Predation for example) on to the Companion Actor sheet. Allow it to fill in things like Health, Armor, Combat Ability (i.e. Claws skill that does 3 points of dmg), Companion Abilities and their Disposition.
This is specific to Companions, which are Predation only (unfortunately), so I understand if this is too much work.

No, it should not be. I just need to figure how to do that goodly with the new system and the v1 code :)
Will see how I can do that.


Stopped unexpectedly: failed to start

Describe the bug
🌲 vmgr | time="09-23 20:19:11" level=error msg="failed to unmount nfs" error="unmount nfs: operation not permitted"
🌲 vmgr | time="09-23 20:19:11" level=fatal msg="panic: new machine: Intel CPUs older than Skylake (6th generation) or newer than Ice Lake (10th generation), the newest CPU ever shipped in an Intel Mac, are not supported. Downgrade to OrbStack v1.5.1 or older at your own risk: https://go.orbstack.dev/intel-gen5-downgrade"
Check logs for more details.
To Reproduce
No response
Expected behavior
No response
Diagnostic report (REQUIRED)
No response
Screenshots and additional context (optional)
No response

Intel CPUs older than Skylake (6th generation) or newer than Ice Lake (10th generation), the newest CPU ever shipped in an Intel Mac, are not supported. Downgrade to OrbStack v1.5.1 or older at your own risk: https://go.orbstack.dev/intel-gen5-downgrade


Developer mode, wording and improve display of the request  reponse with an id token (OIDC4VP flow)

Replace "RESPONSE REQUEST" by "REQUEST RESPONSE"

When an id token is sent to the verifier add to the bottom of the display screen the header and payload decoded off the id_token

OIDC4VP test 11


Slack notifications

Implement slack integration: let µTask send notifications over slack chans.
Current available integrations: TaT (github.com/ovh/tat)

Merged #10


Update regex for notebooks reports

Signed-off-by: Joshua Li<EMAIL_ADDRESS>Description
[Describe what this change achieves]
Issues Resolved
https://github.com/opensearch-project/dashboards-notebooks/issues/53
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #118 (54740f5) into main (c0b29d3) will decrease coverage by 9.98%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #118      +/-   ##
============================================
- Coverage     63.40%   53.42%   -9.99%
  Complexity      309      309
============================================
  Files           101       69      -32
  Lines          4400     2454    -1946
  Branches        668      277     -391
============================================
- Hits           2790     1311    -1479
+ Misses         1442      978     -464
+ Partials        168      165       -3

Flag
Coverage Δ

dashboards-reports
?

reports-scheduler
53.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...nts/report_definitions/report_trigger/timezone.tsx

...itions/report_trigger/report_trigger_constants.tsx

...ions/report_settings/report_settings_constants.tsx

dashboards-reports/test/propsMock.js

dashboards-reports/public/components/main/main.tsx

...c/components/report_definitions/delivery/email.tsx

...s-reports/public/components/main/reports_table.tsx

...orts/server/routes/utils/converters/backendToUi.ts

dashboards-reports/server/model/backendModel.ts

...rts/server/routes/utils/savedSearchReportHelper.ts

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b29d3...54740f5. Read the comment docs.

Contributes to fix for https://github.com/opensearch-project/dashboards-notebooks/issues/53


Hh

Jj

Seems to only introduce whitespace changes. We will reformat code uniformly at a later state.


Websockets: non-working state after socket closes

How to reproduce

Take the websocket example.
Change the URL to some websocket server that sends one message and then immediately closes the socket

Expected behaviour

That one message is printed
The web socket is closed
This here logic re-opens the socket within three seconds
repeat step 1

One could argue that a neatly closed socket shouldn't be re-opened like that, but that's not the point of this issue.
Actual behaviour

That one message is printed
The web socket is closed
The socket is re-opened within three seconds
No messages about this socket arrive to the application

Why it happens
The onOpen, onMessage, onClose and onError handlers here refer to the socket defined on line 71. That's the old socket, not the new socket created on line 80 when the connection closes.
Solution
Not sure, but go in recursion on line 79-80 instead of rewriting the IORef?
I haven't made a PR for this because I'm not sure whether recreating the socket on close is always a good idea. I reckon it's a good idea to reconnect when the socket closed due to an error, but not when it's closed properly.
Simple example server
Not full code, sorry for that
import qualified "wai" Network.Wai as Wai
import qualified "wai-websockets" Network.Wai.Handler.WebSockets as WebSockets
import qualified "websockets" Network.WebSockets.Connection as WebSockets

main = WebSockets.websocketsOr opts serverApp nonSocket
  where
    serverApp :: WebSockets.PendingConnection -> IO ()
    serverApp pconn = do
            conn <- WebSockets.acceptRequest pconn
            WebSockets.sendTextData conn ("\"AAA\"" :: T.Text)

    nonSocket _req respond =
            respond $ Wai.responseLBS
                Http.notAcceptable406
                [("Content-Type", "text/plain")]
                "This is a websocket route. Connect to it using websockets."

    opts = WebSockets.ConnectionOptions $ pure ()

@FPtje, great work again :)
Regarding,

I haven't made a PR for this because I'm not sure whether recreating the socket on close is always a good idea.

It might be best if we only re-open the socket if the error code is erroneous. For example, if the close code was a 1000, we could just simply not recurse and keep the socket in closed state.


[Concurrency] Suggest replacing 'async' with 'await' at call site

It's pretty easy to typo-replace 'await' with 'async' and get a
confusing error about 'async' not being in scope. This patch updates the
diagnostic to suggest replacing 'async' with 'await' at the call-sites
so that users aren't left scratching their heads.
Fixes: rdar://72968205

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

I'm going to emit the error in the parser, fix the AST there, and then we should be able to continue compilation without emitting the confusing errors.

I'm going to emit the error in the parser, fix the AST there, and then we should be able to continue compilation without emitting the confusing errors.

@swift-ci please smoke test

@swift-ci please smoke test

It looks like the windows bot is full. The failure was: :0: note: IO failure on output stream: no space on device
https://ci-external.swift.org/job/swift-PR-windows/10264/console

It looks like the windows bot is full. The failure was: :0: note: IO failure on output stream: no space on device
https://ci-external.swift.org/job/swift-PR-windows/10264/console

@swift-ci please smoke test

@swift-ci please smoke test

Mostly LGTM. It would be nice to add a test case for async try (adapting the code if needed to correct it to try await), but it's less important and would be okay as a smaller JIRA task that someone else can pick up.

Test case added. We get both diagnostics for fixing the async to await and the warning that puts the await after the try.
The fix-it for the warning will correct the positioning of the bad token and put an await in the right place, regardless of whether it was async or await.

Mostly LGTM. It would be nice to add a test case for async try (adapting the code if needed to correct it to try await), but it's less important and would be okay as a smaller JIRA task that someone else can pick up.

Test case added. We get both diagnostics for fixing the async to await and the warning that puts the await after the try.
The fix-it for the warning will correct the positioning of the bad token and put an await in the right place, regardless of whether it was async or await.

@swift-ci please smoke test windows platform

@swift-ci please smoke test windows platform


Notifiers for JamfPackageUploader for Slack and Google Chat

Two autopkg processors to notify via Slack and Google Chat the Summary results from JamfPackageUploader.

I'll work on this in the pr-8 branch. The Notification Processors might need some work as I think they should notify output from all the processors, not just the JamfPackageUploader processor.

That makes sense.  If you like I can look at the processors and conditionally notify based on their individual summaries?  Would the idea be to notify once per recipe and output in one message with the summaries of all the processors that gave data?  Or would you want a message per processor?


Add ability to "Publish" in individual program view

Right now, there is no ability to "Publish" (no "Publish" button) from the "Edit program" view so it's unclear how to end this program creation/editing user journey. The admin has to go back to the "Programs" tab and click on "Publish all programs," which is not intuitive. To view the details of what will be published, admin needs to go into the Versions tab. We should reduce the number of steps to review and publish.

Closing in favor of #1589


3D collision tests performed on all bodies regardless of layer/mask with GodotPhysics (probably Bullet too)

Godot version:
v3.0-stable_x11.64
Issue description:
3D collision tests are performed on bodies that should never collide. Collision pairs are generated even before bodies come near each other, and after bodies intersect. No collision pairs should be generated.
This causes significant performance problem in all cases. Regardless of layer/mask settings, sufficient number of bodies will kill CPU performance even though there should be no tests performed at all.
Steps to reproduce:
Run attached project. Surface and cube have different layers/masks set. They should never collide and this is confirmed when cube falls trough surface.  But collision pairs are generated before and after cube makes "contact".
Running with Bullet can't provide more info because performance monitor isn't showing correct values https://github.com/godotengine/godot/issues/16540
Minimal reproduction project:
BugTest.zip

Oh damn, just found out about this issue. No wonder I noticed no improvements in my performance when adding everything to layers/masks! I hope this gets some attention before 3.1. Is this also an issue with the native physics, or just bullet?

CC @reduz @AndreaCatania

This is really strange, I'll test it soon

It's been long ago, but that test program I included displays number collision pairs in window title (or as text on screen, I don't remember).  There is also related bug with bullet where those counters don't work at all.
I don't know how underlying engine works, I assume collision pair should not be generated for objects that are prevented to collide by using layer/mask. But they do, and it is the problem that causes too many collision checks. I assume again that once those checks are performed, engine finally checks layer/mask and discards collision, but it is too late as CPU time is used already in vain.

I think that that data are wrong in Godot physics rather that is created a pair...
In bullet the result is 0 because I didn't create the function that update it, I will do to allow more fine optimization.

I'm moving it to 3.2 for now since doesn't seems that bullet create useless pairs

Fixed with #39399.


wamp_session on_published_fn callback

Hi,
I have a question. When on_published_fn callback argument of wamp_session::publish method: https://github.com/darrenjs/wampcc/blob/master/include/wampcc/wamp_session.h#L580
is supposed to be executed?
For example:
$ ./admin ws://<IP_ADDRESS>:55555 -p topic.test --arglist='["hello"]' -d
session #1 state: from init to sent_hello
session #1 state: from sent_hello to open
session #1 sending publish for 'topic.test', request_id 1

The publish itself works fine, but I never see "publish successful to topic ...", as in
https://github.com/darrenjs/wampcc/blob/master/utils/admin.cc#L556
, so on_published_fn is not executed in this (and my others) examples.
Could somebody clarify please. Thanks!

Hi,  this is intended to be executed  if/when the wamp router (that we received the publish message) replies with a published message.   Not all routers will do that; its optional.

Ok. Thanks!
On Sun, Apr 22, 2018, 5:29 PM Darren Smith<EMAIL_ADDRESS>wrote:

Hi, this is intended to be executed if/when the wamp router (that we
received the publish message) replies with a published message. Not all
routers will do that; its optional.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/darrenjs/wampcc/issues/33#issuecomment-383385558, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABCIjJPs-_VOckRNxWWYm2HPn40ZdkG5ks5trJPQgaJpZM4TelTu
.


Beginner`s problem with set up

Checklist:
[x ] I updated to the latest version available
[x ] I cleared the cache of my browser

Release with the issue:
2020.12/.2
Last working release (if known):
NA
Browser and Operating System:
Firefox / Win 10
Description of problem:
I have to say first, that I`m quite new with Home Assistant, so please be patient with me. If topic is marked incorrectly, please change it.
I have problem with setting up Drag & Drop in Lovelace. I did exactly like Zack did in his video (manual installation), but I`m getting errors so now Im in death end :)

I downloaded grid-view.js

I have put this file in my .homeassisant-config-www file

In Lovelace Dashboards I have added new resource and wrote URL like in video:

In Raw configuration I wrote in type: custom:grid-dnd and saved

But then I get this error:

What Im doing it wrong?
Many thanks for help!

Restart your server. I saw that someone was able to fix this by doing that

Restart your server. I saw that someone was able to fix this by doing that

Hmm, glad I'm not the only one... only different for me is that I installed through HACS and my path to resource is /hacsfiles/Custom-Grid-View/grid-view.js
Home Assistant State
Core Version: 2021.1.5
Supervisor Version: 2021.01.5
Host Version: HA OS 5.10

Hmm, glad I'm not the only one... only different for me is that I installed through HACS and my path to resource is /hacsfiles/Custom-Grid-View/grid-view.js
Home Assistant State
Core Version: 2021.1.5
Supervisor Version: 2021.01.5
Host Version: HA OS 5.10

Funnily enough, manual install seemed to work over HACS.

Funnily enough, manual install seemed to work over HACS.

I have EXACTLY the same issue. I followed the instruction but then get a red screen. Restarting the server did not help. Problem is still there.

*** update *** restarting the server did not work, but reloading the page did. I also changed folder permission (not sure if this is related). So I was able to solve the issue.

@avviano Thank you!!! I hadn't been able to get this working for forever!

I keep having the same issue here, this plugin does not work.  Keep getting doesn't exist.


Example_lib_pid and KSP 1.0

Due to the new ISP system most hovercrafts (including the one from showcase video) are no longer capable of flying in low Kerbin atmosphere.
I think example_lib_pid should display a warning using HUDTEXT if twr is lesser than 1.

Is it necessary? If the TWR is below 1 then the user will see full throttle and a stationary craft anyways.

I think it works fine if you just swap out the engine.  Change the LV-909 to a LV-T45.


cpm overrides don't occur when CPM_<pkg>_SOURCE exists

Description
Since the rapids-cmake cpm overrides hook into fetch content they previously would take priority over CPM_<pkg>_SOURCE. Now we don't add overrides when CPM_<pkg>_SOURCE exists.
Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

@trxcllnt This PR should fix the bugs you have encountered with rapids-cmake overrides and cpm pinning via CPM_<pkg>_SOURCE.

/merge


Remove unused I2CDriver properties

Removes driverType which is unused in the refactored i2c driver.
Makes sensorAddress public as it's set in the driver's constructor
Makes isInitialized public as it's set in the driver's constructor.

im a little paranoid about having public variables because people could set them by accident, unless you mean that?

@ladyada I wanted to simplify the src/drivers/WipperSnapper_I2C_Driver.h interface, but I can also refactor it to utilize getters/setters to wrap these variables (sensorAddress, isInitialized) as private members.

i think its best to do so, in case something else comes up! its too easy for folks to accidentally set em especially as we get contributors!

@ladyada  I've made a good # of modifications since the original PR comments and am requesting a re-review.


Make activitybar color the same as editor

The light grey background helps the activity bar blend more with the rest of the UI and look softer.
Original:

With #FAFAFA background:

Thanks for your contribution, it looks better indeed. I'll approve your PR but this will be released on 2.0.2.


presenterm: 0.5.0 -> 0.6.0

Description of changes
Changelog: https://github.com/mfontanini/presenterm/releases/tag/v0.6.0
cc @MikaelFangel

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 287581 run on x86_64-linux 1

1 package built:

presenterm


palmAi class

What is this PR for? The PalmAPI class should have been moved into the CSClubCommon with my PR


Allow access to chunk data.

As an use case in my company, we need to be able to encrypt each chunk separately when uploading a file. In order to do that, we needed access to the blobs of the chunks, so we created an event to support this feature.
I believe that it's an important feature to have in the library to allow more flexibility and I've seen other people on the internet who needed to do something similar. Here's an example:
http://stackoverflow.com/questions/31051664/how-to-modify-current-chunk-data-during-upload-process-with-fineuploader
I believe that, if the developer use it the wrong way and breaks their upload flow, it's entirely their responsibility.
Of course, there's a check to see if the content size of the chunk changed (except for the last one).
I hope you accept this Pull Request and maybe even improve on this feature in the future. I'm sure it will be helpful for many people.

Instead of opening a new PR each time, you can simply push fixes to your branch.

Oh, didn't know that. Sorry.

There are a lot of changes here, many of which I don't agree with. Allowing the chunk to be potentially modified (made smaller or larger) adds quite a bit of complexity to the library, which itself is already more complex than I'd like it to be. However, I think this can still be accomplished for traditional endpoints by extending the onUploadChunk event/callback. Currently, Fine Uploader passes metadata about the chunk to the callback handler, just before it is uploaded. The code could be modified to include the chunk Blob as well. Furthermore, internal code that handles onUploadChunk calls could be modified to support a promissory return type that, when resolved, includes the new chunk Blob. I don't think this will be a terribly difficult modification to make.
I'm going to close this pull request, but if you'd like me to consider this for a future release with my proposed solution, please open up a feature request, or, better yet, a pull request with minimal changes that implement my proposal.

What you suggested would be ideal, the problem is that it wouldn't support asynchronous code within onUploadChunk. That's what I need to support since each of the chunks I'm sending to the server are being encrypted using a WebWorker and there's no way to wait for the async work to be done within onUploadChunk unless I add a callback to it the same way I did with the other event. But I wanted to keep the event that already existed the same.
Do you have another suggestions that would work with async code?
Another thing is, the only chunk that's allowed to have its size changed is the last one, the other ones can't have the size changed and there's a validation in the code to avoid it from happening.

Hello, do you have a suggestion for this case?

@ericmackrodt Ray is on vacation until January 20.

What you suggested would be ideal, the problem is that it wouldn't support asynchronous code within onUploadChunk

Yes, it would. As I mentioned in my comment, the internal code would need to change to handle a promissory return value from the callback handler.

Do you prefer that I open a feature request instead of writing the feature?

If you feel comfortable making an attempt, by all means. But this is likely a pretty complicated change for anyone not familiar with the codebase. Otherwise, just open up a feature request.


Adding evernote and thrift typings.

Created these bindings and used them successfully in a little one-off script I made here https://github.com/corps/evernote-hansei so I can attest to their correctness.  Used the apache thrift typescript generator and then preformed a ton of cleaning to get them correct and modular.  Will likely use these when I extract from the same one-off my promisified-evernote bindings into a new package.

evernote/evernote.d.ts
check list

[ ] is collect naming convention?

https://www.npmjs.com/package/evernote
http://bower.io/search/?q=evernote
others?

[X] has a test file? (evernote/evernote-tests.ts or others)
[ ] pass the Travic-CI test?

thrift/thrift.d.ts
check list

[ ] is collect naming convention?

https://www.npmjs.com/package/thrift
http://bower.io/search/?q=thrift
others?

[X] has a test file? (thrift/thrift-tests.ts or others)
[ ] pass the Travic-CI test?

@corps thanks mate!
hansei is 反省? it is good names. :smile_cat:


User can choose multiple files when singleImage is true

The markup for the input element always has an attribute multiple="multiple" but this attribute should be omitted if the singleImage prop is set to true.
Also, the singleImage attribute is not documented.

This new issue is a duplicate of #45


Fixes ingestion of IERS EOP 1980 finals.data.csv files after Nov. 6 2023

See https://datacenter.iers.org/data/2/message_490.txt - four new columns are added the CSV. This MR just bumps the index numbers of all columns after column 9 by 4 to account for the new columns in the middle of the CSV.
A better fix might be to either

index columns by name instead of number (in case more columns are added in the future), or
switch the to the JSON format of the file mentioned in Message 490. That might be easier to parse and give more flexibility in case more columns are added in the future

All tests are passing locally now! Looks like the 2000A file format also changed so I've added a little fix for that too.

I also have a version of this in a branch - https://github.com/ThatcherC/SatelliteToolboxTransformations.jl/tree/eop-from-column-names - that resolves this issue by referencing the EOP columns by name rather than by index, which I think is a little more clear and resilient to future file format changes.
Here's the main commit with that new approach - https://github.com/ThatcherC/SatelliteToolboxTransformations.jl/commit/47f7f95864c2f7d873b0801a16693d42e3ca1d08. I could open an PR for that instead of this change if there's interest!

Hi @ThatcherC !
That's awesome! Thanks!!

I also have a version of this in a branch - https://github.com/ThatcherC/SatelliteToolboxTransformations.jl/tree/eop-from-column-names - that resolves this issue by referencing the EOP columns by name rather than by index, which I think is a little more clear and resilient to future file format changes.

IMHO, your verification of the number of columns should be fine for now! Those formats are very stable. I think the best effort would be to change the parser to accept the JSON file as you proposed. This version will be as future proof as we can get. My only concert is that it maybe take much longer to parse compared to the current format.


[improve][txn] PIP-160: Pending ack log store enables the batch feature

Master Issue: #15370
Motivation
see #15370
Modifications
I will complete proposal #15370 with these pull requests( current pull request is the step-4 ):

Write the batch transaction log handler: TxnLogBufferedWriter
Configuration changes and protocol changes.
Transaction log store enables the batch feature.
Pending ack log store enables the batch feature.
Supports dynamic configuration.
Append admin API for transaction batch log and docs( admin and configuration doc ).
Append metrics support for transaction batch log.

Documentation

[ ] doc-required

[x] doc-not-needed

[ ] doc

[ ] doc-complete

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@poorbarcode #16727 has merged, could you please use the shared time for this PR?

@poorbarcode #16727 has merged, could you please use the shared time for this PR?

Already fixed.

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks


normalize-docs

Unfortunately this feature still unstable (nightly rustfmt).
https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#normalize_doc_attributes

Seems like nightly rustfmt is also broken at the moment so I'm holding off on this. I wonder if we can update svd2rust to emit normal docstring comments instead.

It was working with rust nightly 2019-07-22

Looks like it's been broken since 26th: https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu.html

2019-07-31
All components except miri were restored.

please could you rebase?

Sure.

Done.


adds a visual pie chart of success vs. fail to the report summary

This will add a visual pie chart to the head summary section of the html report, representing the success vs. fail. This is more of a visual flavor feature. Was originally designed as an external plugin but it was brought to my attention that it could be nice to integrate within the framework itself.
Preview:

Would it be possible to move the graph to the right, to use the space more efficiently?

Few quick comments:

Isn't this a bit of duplicate information when the report already has all and critical tests graphs which show this information?

If we would add the skip status and remove all/critical distinction, showing pass/fail/skip in a pie chart might be a good idea.

It might be a good idea to make it possible to inject custom content to reports and logs. The main problem with that would be declaring which APIs in reports/logs could be considered stable.

I'm surprised how simple the implementation looks like!

Any chance you could do a bar chart instead?
https://www.stevefenton.co.uk/2009/04/pie-charts-are-bad/


About heatmap prediction model

It seems that the training of carotid artery heatmap is not included in this repo. Could you give any related implementation about the heatmap model?

Hello,
This code was indeed kept in a private version of the repo. I just added it.
Documentation is coming soon!

Great! I noticed two braches "heatmap_train" and "new" were added. Look forward to the compele implementations!


Update CI to run slow downstream tests prior to release

To hopefully avoid post-release issues like https://github.com/asdf-format/asdf/issues/1239 where downstream package CI fails after release, what is a good way to add slow downstream tests to our CI?
Specifically, adding astropy tests with both --open-files and --run-slow args to pytest to replicate this tests might be a place to start:
https://github.com/astropy/astropy/blob/main/.github/workflows/ci_workflows.yml#L68
I am not familiar enough with github CI to know a good way to do this but perhaps there is a way to notice a ..x branch change and run the slower tests as these branches are created/changed prior to a release.

I guess you could use this:
on:
  push:
    branches:
      - '**.x'

(filter syntax docs)

This is already being done.

Thanks @bilderbuchi
If I'm understanding we could copy from what we're doing in downstream.yml and make a slow_downstream.yml or pre_release_checks.yml that runs these tests.

Thanks @bilderbuchi If I'm understanding we could copy from what we're doing in downstream.yml and make a slow_downstream.yml or pre_release_checks.yml that runs these tests.

Or we could just add the --open-files and --run-slow flags to the tox environment run by our downstream tests...

It looks like if we had been using those options we would have caught the failure that motivated this issue:
https://github.com/astropy/astropy/actions/runs/3532958266/jobs/5927978680
I was originally thinking we were running the full astropy downstream tests (and enabling those options would slow down our CI) but reviewing the PR revealed we're only running only the astropy.io.misc.asdf tests which with these options still run faster than jwst.
Thanks for the fix!


Add standalone create table logic

Table creation needs to be implemented, as this feature was used from excel.

[x] Add table map update function
[x] make active table selectable by footer
make table deletable
allow changing table name
store table information in local storage


This commit add a dev extension.

The dev extension uses the dev server and the index.html from the dev server

This is for https://github.com/estruyf/vscode-community-ui-toolkit/issues/15

Thanks @idoprz 💪


Update to ruby 3.1.4

There's also a ticket for 3.2 https://github.com/rubymonsters/speakerinnen_liste/issues/1329


fix crash

Fixes #1
From my limited understanding, the crash was being caused by glib not extracting window names from i3ipc-glib correctly on x64 systems. This changes the way the name is obtained by going through i3ipc instead of using glib to extract the GObject attributes from the i3ipcCon.

Cool! I'll take a look at this asap.


ISSUE: automations and auto re-lock no longer working as of 0.0.86

Automations are no longer able to fire and provide notifications.
Environment (please complete the following information):

OS: HAOS 11.1
Core: 2023.11.2
Supervisor: 2023.11.3
Frontend: 20231030.2
Component version: 0.0.86
Z-Wave integration name: zwave_js
Lock make and model: Yale NF-YRD622-ZW2

Logs
Logger: homeassistant.components.automation.keymaster_frontdoor_lock_notifications
Source: helpers/script.py:1783
Integration: Automation (documentation, issues)
First occurred: 9:02:18 AM (3 occurrences)
Last logged: 9:03:04 AM
keymaster_frontdoor_start_timer: Error executing script. Error for call_service at pos 4: Timer timer.keymaster_frontdoor_autolock is not running, only active timers can be changed
9:02:58 AM – (ERROR) Script
keymaster_frontdoor Lock Notifications: Error executing script. Service not found for call_service at pos 1: Unable to find service script.keymaster_frontdoor_manual_notify
The automation "keymaster_frontdoor Door Open and Close" (automation.keymaster_frontdoor_door_open_and_close) has an action that calls an unknown service: script.keymaster_frontdoor_manual_notify.
This error prevents the automation from running correctly. Maybe this service is no longer available, or perhaps a typo caused it.
To fix this error, [edit the automation](/config/automation/edit/keymaster_frontdoor Door Open and Close) and remove the action that calls this service.
The automation "keymaster_frontdoor Lock Notifications" (automation.keymaster_frontdoor_lock_notifications) has an action that calls an unknown service: script.keymaster_frontdoor_manual_notify.
This error prevents the automation from running correctly. Maybe this service is no longer available, or perhaps a typo caused it.
To fix this error, [edit the automation](/config/automation/edit/keymaster_frontdoor Lock Notifications) and remove the action that calls this service.
Click on SUBMIT below to confirm you have fixed this automation.
I recently re-installed keymaster as I was unable to add/remove lock codes. That issue is fixed, however now none of the automations nor the auto lock functionality will work.

I have re=generated packages multiple times along with looking at my automation scripts, which all seem to be in order.

keymaster_frontdoor Lock Notifications: Error executing script. Service not found for call_service at pos 1: Unable to find service script.keymaster_frontdoor_manual_notify

This error is because you haven't created a notify script.
See the wiki.

Ahh, I re-named by device when setting back up. Thanks for the catch on that. Fixed!
I'll go ahead and edit my issue description.

If you changed the name, use the keymaster.generate_package service call to regenerate the template scripts.
Let me know if that helps.

If you changed the name, use the keymaster.generate_package service call to regenerate the template scripts. Let me know if that helps.

I did regenerate after every change here. No changes to the autolock, no counting when the door is closed.

I'm not entirely sure as I never used the autolock or door counting stuff.

Having same issue as @mattriney. Looking through the Home Assistant timer documents, service: timer.change can only be used on an active timer. The autolock script is applying that service call to an idle timer which is giving the error (line 111 of keymaster_common.yaml).

@roblamoreaux, thoughts?

So maybe the order of operations is wrong? the timer.start needs to come before the timer.change

I just did a test and if you use timer.start without setting a duration it defaults to a duration of 0. I tried running a script with timer.start and then timer.change to add time to the timer entity but I received the error about only active timers can be changed. I think the changes in release 0.086 need to be reverted back to 0.085 where timer.start was used instead of timer.change.

@roblamoreaux, thoughts?

I am not sure. my instance auto-relocks with the changes I pushed. if the change to HA was reverted and it won't break keymaster I see no reason not to revert back.
I'm just confused why it would break for others when I've had it running without issue for a week.

If you unlock one of your doors that auto-relic is you aren’t seeing the timer error in your logs? My locks still auto-relock but that is probably because I had set them to auto-relock via the lock interface before I had keymaster installed.

I just did some checking and the change should be rolled back. I Missed that changing the code in the custom directory didn't change the existing scripts it created. After manually changing the created script, it broke.
So please roll back the change

Reverted in 0.0.87

Resolved in 0.0.87.
Thanks!


Cannot select download URL through Graph

The instance annotation that exposes the download URL via graph is @microsoft.graph.downloadUrl, however that value is not correctly handled when specified in the select statement.

I ran into this issue and the solution is to query for content.downloadUrl, I wouldn't say that this issue is completely resolved yet.
https://stackoverflow.com/questions/45502275/microsoftgraph-querying-for-microsoft-graph-downloadurl-returns-character-i

Hi @gunna025, I just tried using<EMAIL_ADDRESS>for both OneDrive for Business and OneDrive for Consumers and it returned the URLs in both cases. If you're seeing it not work could you grab the request-id and date headers from the response and provide them here?

request-id: 737300e7-e857-406f-9f7b-b85a4b707e95
Date: Mon, 15 Oct 2018 13:18:07 GMT
Also, it may be worth noting that this request is being made with MS Graph and not the one drive API directly.


Add 'Mobile Vikings' to the 'Utilities' category

Submission Notes: Please fill in the template below, and don't worry about exact formatting, just do your best! Use the Preview tab to check your submission before sending it. Help for region/country 2-letter codes are below.

Add 'Mobile Vikings' to the 'Utilities' category. Details follow:
- name: Mobile Vikings
      url: https://mobilevikings.be/en/v2/
      img:
      twitter: mobilevikingsBE
      facebook: mobilevikings
      email_address<EMAIL_ADDRESS>      region: eu
      country: BE
      bch: Yes
      btc: Yes
      othercrypto: No

/abc img https://pbs.twimg.com/profile_images/876695509079031808/Cv75MOh3_400x400.jpg


This page is the only referency ro "gateway ring" in all docs

https://www.google.com/search?q=site%3Adocs.microsoft.com+"gateway+ring"&oq=site%3Adocs.microsoft.com+"gateway+ring"
...a definition/introduction would be useful :)
Thank you and best regards.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 15036ef6-9c0b-044e-d600-b9f90f039720
Version Independent ID: 6fe5cd14-a1ad-e183-a048-d72686abb969
Content: High availability - Azure SQL Database service
Content Source: articles/sql-database/sql-database-high-availability.md
Service: sql-database
Sub-service: high-availability
GitHub Login: @jovanpop-msft
Microsoft Alias: sashan

@robert4os , Thank  you for the request. We are looking into this and would get back to you soon on this thread.

@KalyanChanumolu-MSFT
Please assign this to original authors of the article for edits. In terms of connectivity we donot talk about control rings as a public concept. We just refer to them as "Sql Gateways" in a region.

Hi @robert4os , since it's been sometime since we've heard from you and it seems the article has been updated with the requested information, I'm going to close out this Git Issue for the time being. However, please feel free to comment should you need anything further.
Thanks again for helping improve our documentation and I hope you have a wonderful rest of your day!
Masha from the SQL Docs team
#please-close


 Error: No compatible version found<EMAIL_ADDRESS>

I don't think there is any point in trying to maintain nodejs 0.8 support anymore, nor have Travis and Jenkins dueling.


Social sharing

Issue: #3
For social sharing I have added several icons for several social sharing websites. There maybe way to many icons. I was not sure which one to add. There probably only needs to be a select few. I have coded these to be at the top of the page. Also there are no links that will take you to the social sharing sites.

Looks great, Tyrone!  I agree, there are a few too many icons.  If we were continuing, we could bring this up at our next meeting and the whole team and/or the stakeholders could decide which social media icons are most important for this project.  I think a max of 5 or 6 would be good?

After we get the sizing worked out and the number of buttons reduced appropriately, I recommend merging.

I'd agree, I've reduced the number of social sharing icons to 6 and cut back on links to services that don't make sense in the context of sharing poetry (youtube, spotify, etc). I also implemented some of the styling changes proposed by Laura.


create an agent for magick

It is assumed that magick is the third party program to be invoked. However this shouldnt be a hard rule. We should be able to intergrate with any appropriate third party program.
We should introduce the concept of an agent that represents the third party program and will interface with it as such. The agent is aware of anything that is specific to that program.
Also introduce a program field in the advanced config that allows it to be switched to wahat-ever program they wish. However, to prevent mis-configuration, we should not just allow anything to be used for this field. It should be vetted against an allowed list. In theory, more than 1 external program could be associated with a partilcuar agent if they have the same interface (in reality, this would be unlikely, but we should not make any assumptions upfront).
We probably need to introduce a new section into the advanced config for the explicit purpose of holdig any setting regarding the third party executable.

don't forget to put this code back in somewhere (checks that external program is available):
		if _, err := b.OptionsInfo.Program.Look(); err != nil {
			b.OptionsInfo.Program = &DummyExecutor{
				Name: b.OptionsInfo.Program.ProgName(),
			}
		}


[BUG] Github source release has wrong version

The tag https://github.com/Textualize/rich/releases/tag/v12.5.1 references the wrong commit, where pyproject.toml still has 12.5.0, this results in the wrong source tarball.
The release should have referenced https://github.com/Textualize/rich/commit/cde23ed0a1ecad8c63436148c7e1fb6f0073fca8

I recently encountered this in NixOS where one of my packages depends on rich 12.5.1. But pip fails due to the Github tag referencing a commit that says it's version 12.5.0. Are there any plans to fix this issue?

What error did you get?
Happy to fix it if you can suggest how.

Pip shows the following error:
> ERROR: Could not find a version that satisfies the requirement rich<13.0.0,>=12.5.1 (from pls) (from versions: none)
> ERROR: No matching distribution found for rich<13.0.0,>=12.5.1

The easiest fix would be to simply delete the current tag and recreate it at the correct commit.

AFAIK git tags have nothing to do with Pip.

True, mine is a nix-specific issue. The nix package for rich is built from Github tags (source tarballs). Proof here.
This is different from normal pip behaviour, because by default it uses the package from Pypi, which somehow did get the correct version number.

Issuing a new release, 12.5.2, with consistent package metadata (which nixpkgs could then switch to) should also fix it.

Issuing a new release, 12.5.2, with consistent package metadata (which nixpkgs could then switch to) should also fix it.

Or to elaborate on @arjan-s 's comment - a new git tag for a revision with consistent metadata would give nixpkgs something it could easily switch to and which would produce an installed package with consistent metadata.

@exarkun is correct, both options would fix the issue.
@willmcgugan would you be willing to do either of them?

@willmcgugan I see you closed this as completed, but I don't see a new tag/release and the existing tag isn't fixed either... Could you please take a look again? Thanks!

I ran the command you suggested.
If you are saying that a new release will fix it, then one is just around the corner.

Ah, maybe you forgot to push after the tag command?
git push --tags


Request: ignore end_with_newline when formatting selection

VSCode Version: Code - Insiders 1.14.0-insider (73015a5e052e6de8ecd60eed2670bea81fad8cac, 2017-06-16T05:13:31.107Z)
OS Version: Windows_NT ia32 10.0.15063
Beautify 1.1.1

I have the following line in .editorconfig:
insert_final_newline = true

This causes the problem with formatting selected text. Essentially, a new line is always appended after beautifying any selection.
Just select any (valid and properly formatted) line, invoke "beautify selection" and watch as an empty line appended after the selected line.
I don't think that insert_final_newline setting should affect the beautifying the selection, and it certainly shouldn't add new lines after each beautification of any selection.

Sorry for the delay. It is done.


Replace array and str helper

By default both array_* and str_* are no longer supported helper functions in Laravel 6 and not all user will import the new laravel/helpers package.

Thanks, I forgot about those! 👌


PackageInstallerActivity can't be recognized

From<EMAIL_ADDRESS>on March 17, 2011 22:45:37
What steps will reproduce the problem? I have a problem in my test. In activity A, do some tests and then click the button setup, it will call a new activity B.
solo.clickOnButton("Setup");
//Starting activity: com.android.packageinstaller/.PackageInstallerActivity
It will start the new activity PackageInstallerActivity.
The getCurrentActivity() will not return the correct activity B. What is the expected output? What do you see instead? getCurrentActivity() should return activity B
getCurrentActivity() still return activity A What version of the product are you using? On what operating system? Robutium 2.2
Android 2.2 Please provide any additional information below. I try to ues the following code
solo = new Solo(getInstrumentation());
getActivity();
It should not be the problem "it will not have time to register the new activity as the activity change happens instantly"
Original issue: http://code.google.com/p/robotium/issues/detail?id=88

From<EMAIL_ADDRESS>on March 18, 2011 10:39:09
Please see questions and answers. You are only allowed to interact and test the application described in the AndroidManifest.xml of your test project.
Status: Invalid


Traversable::peek behaviour

Javadoc:

Performs the given action on the first element if this is an eager implementation. Performs the given action on all elements (the first immediately, successive deferred), if this is a lazy implementation.

These are two radically different behaviours depending on the underlying implementation. I find that confusing.
Also, I need some way to process all elements in a Seq without changing the Seq and then continuing. Concrete use case: I have a Seq of all methods and want to apply multiple validations:
specialMethods = allMethods
  .filter(isSomeSpecialMethod())
  .peek(this::validateFoo)
  .peek(this::validateBar);

validateSomething() may print a compiler error, but in order to collect all possible compiler errors, it will continue. Logging all elements being processed is another possible use case for such a thing. I'll probably use a utility method for now as a workaround: filter(alwaysTrue(this::validateSomething))
While with Java streams peek() applies to all elements, the name "peek" somehow implies that it's only applied to the first element. Ruby has a method tap() for such use cases.
Still, the same interface method has very different behaviours depending on the underlying implementation, that's confusing and dangerous, IMHO.

Well, it is a well-defined behavior - but I agree, it violates the LSP.
You know me, I don't really want to talk about naming (peek or tap or whatever). It is just a matter of definition or interpretation.
I'm interested in our options here. In my experience, it is hard to satisfy the LSP across a collection hierarchy. Let's consider a peek() method that is defined only on the first element (if present), no matter if the collection is lazy or not. There exist collections that do not have a defined order, like HashMap or HashSet. In particular, each time we call peek(), a different element may be returned.
peek() currently is defined on Value (the parent of Traversable). In order to satisfy LSP, we would need to move peek() to Seq.
But wait - a lazy Seq would still do nothing at all, if elements are present but not read.
So, why isn't it legit to define a different behavior for lazy values?

It will stay as-is. It is a well-defined behavior.

Sorry, I wasn't suggesting to change the behaviour of peek() –well, OK, I was, but that's not the primary issue. :) Bad issue reporting from my side.
My main point is that there's no API for a very common use case: offer each element to a consumer without any mapping or filtering. Like forEach() but as an intermediate operation instead of a terminal operation. As I wrote, I currently use this workaround:
public static Predicate<T> alwaysTrue(Consumer<T> consumer) {
  return e -> {
    consumer.accept(e);
    return true;
  }
}

mySeq.filter(alwaysTrue(e -> doSomethingWith(e)))

And I use this a lot. Unfortunately, it builds a new list every time, although I can tell in advance that it won't change anything. Naming proposals: tap(), touch(), offer() – I like touch().
If you like, I can file a new issue that's more clear.
Yes, there is some critic on the behaviour of peek(), but that's secondary.

What would be a use-case other than performing side-effects that change the outer world. This is not a practice I want to further push than necessary.
A lightweight variant might be to operate on an iterator and finally convert to your collection of choice.

Unfortunately, the forEach and methods can‘t return this because the are inherited from Iterable....
Maybe your solution is the best alternative. A touch would not make sense for lazily evaluated collections.

A very common use case would be logging what's there.
One concrete use case where I stumbled upon this, is a compiler. The compiler should continue working when it encounters errors in order to find more errors. So, it looks at things, reports errors if it finds them, looks for more errors, transforms things further and so on. Very similar to logging, actually.
In a reactive context, you may want to use such a method in to push an object into a second processing stream. And that would make perfect sense for lazily evaluated collections. Although one might argue that Vavr isn't about reactive programming … :)
Sometimes, modifying the state of a mutable object may be what you want to do – although I completely agree that this is very bad practice. But Java isn't a native functional language and mutable objects are very common, so you may be forced to do such a thing  when interacting with non-functional 3rd-party libraries. Using map() may be misleading in this situation, because normally, map() produces a new value. touch(e -> e.setFoo("foo")) may point out that it actually changes the state of the object at hand.
And an addition to my concern about the name: the method I'm missing exists in Java's Stream and it's called peek(). It took me quite a while to realise that Vavr's peek() is a completely different thing. Yes, I should have read the doc earlier, but can you really blame me for assuming, that a method with the same name in the same context does the same thing?

I understand your concerns. It would be a duplication of forEach(). Please use iterator() or toStream().

forEach() is still a valid alternative if you don't stick to a fluent API.
#UseTheRightCollectionForTheRightPurpose

And an addition to my concern about the name: the method I'm missing exists in Java's Stream and it's called peek(). It took me quite a while to realise that Vavr's peek() is a completely different thing.

That's not true, see images above. It is exactly the same thing. However, you need to differentiate between eager and lazy evaluated collections. The implementation is canonical in a mathematical sense. There is nothing artificial build around, no balconies. I will not change that.


Fix syntax error on browsers that not support arrow function

Fix #74
This issue also occur on IE11, fixed by replacing arrow function to anonymous function

Thank you for the PR! @Marco129


GROOVY-7996: check for get(String)/set(String,Object) or propertyMissing

Here is another take on GROOVY-7996.  Closure delegate implements propertyMissing and owner has field.  Submitter expects propertyMissing to be respected since resolve strategy is DELEGATE_FIRST.

Merged. Thanks.


[ISSUE #1681]Increase the default value of zookeeperSessionTimeout

Fixes #1681.
Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #1682 (117176f) into master (ec0aa40) will decrease coverage by 0.64%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1682      +/-   ##
============================================
- Coverage     60.87%   60.22%   -0.65%
+ Complexity     2223     2211      -12
============================================
  Files           469      469
  Lines          9885     9885
  Branches        997      997
============================================
- Hits           6017     5953      -64
- Misses         3379     3446      +67
+ Partials        489      486       -3

Impacted Files
Coverage Δ

...r/zookeeper/ZookeeperServerRegisterRepository.java
65.59% <0.00%> (ø)

...enyu/client/tars/TarsServiceBeanPostProcessor.java
25.33% <0.00%> (-65.34%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
72.22% <0.00%> (-22.23%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
54.73% <0.00%> (-8.43%)
:arrow_down:

...he/shenyu/plugin/grpc/client/ShenyuGrpcClient.java
8.51% <0.00%> (-4.26%)
:arrow_down:

...henyu/plugin/httpclient/NettyHttpClientPlugin.java
57.14% <0.00%> (-2.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec0aa40...117176f. Read the comment docs.


Duplicate resource files using both dot naming and file naming disables all .resx lookups

When you provide a resource file using both dot naming and folder naming, it disables the entire localization resource lookup. For example, if I have the following resource files in Entropy, no other non-conflicting .resx files are used.

Resources\Controllers\HomeController.fr.resx
Resources\Controllers.HomeController.fr.resx

What does no other non-conflicting .resx files are used. mean?
Why would you have both files?

As @Eilon said Why would you have both files? but if the case is
Resources\Controllers\HomeController.cs
Resources\Controllers\HomeController.fr.resx
it's already discussed here #138

Damian asked me to:
Log a bug, but this is obviously a bit of an edge case, as you’re essentially duplicating the same resource.
@Eilon    Why would you have both files?
You shouldn't and I'll document that. But the Entropy sample and my sample will show both approaches. Suppose you add a new type and it's associated resource - then are off that project for a few days. You return and add the same type resource with the alternative name. You app now fails silently. I was just hoping that when it fails it would throw an exception telling you why it failed. Perhaps this is enough of an edge case that I only need to document it.
@hishamco  #13 is "resource name is not found it throws" - this issue is that if you have two resources that are essentially the same resource (one uses the dot naming and the other the file naming) - not that the resource is missing.
@Eilon  no other non-conflicting .resx files are used
In the Entropy sample, if you have both

Resources\Controllers\HomeController.fr.resx
Resources\Controllers.HomeController.fr.resx

It disables all resource files. Resources\Views.Shared._Layout.fr.resx and all the other .resx files are not read.

Ah, I see. I can only wonder what error we could show... I don't think we can know about the conflict until the app is running, so I don't think we can show an error during build.
I can think of two options:

If there's an ambiguity then arbitrarily pick one (e.g. sort them deterministically and pick the first one)
Maybe do (1) but also log a warning to the logger

@DamianEdwards any preference as to the behavior?

@Eilon logging a warning is good option, but can we align it with VS warning, so anyone using VS can see that too

I don't think VS can show the warning because it's a runtime warning. VS isn't even in the picture anymore.

I'm surprised this isn't failing at resource generation time (compile time). It can't embed both files with the same name, so it must either be embedding neither, or changing the names when embedding (e.g. append 1, 2 to the end).
Can we check what the actual embedded resources look like in the project assembly after compile?

@DamianEdwards is it possible that it gets embedded with both names? Or does it always embed with dots?
@ryanbrandenburg can you take a look and see what's in the physical DLL in this scenario?

@Eilon no, the \ are replaced with . by the compiler, you can't control it.

Ok then that's indeed weird.

Related to unrelated question, I faced a strange issue in the Entropy repo too while implementing a JsonRequestCultureProvider seems the entire localization resource lookup is disabled, the source is available here

@hishamco as you said, that seems to be an unrelated question since there are no duplicate Resource files. Please post it as its own issue with more information.

Ok @ryanbrandenburg

When I try to reproduce this I run into what @DamianEdwards expected, which is that it fails at compile time with CS1508: Resource identifier 'LocalizationSample.My.Resources.Controllers.HomeController.resources' has already been used in this assembly. This is true for both dnx web and dotnet run. @Rick-Anderson am I missing a part of what you're doing?

Closing. I'm not building so I didn't see that error. I just change the resource files/code and dnx run.


Some sort of game data service, or make use of Game.class

To pass objects around from GameApplication

Alternatively we can pass the reference to GameApplication. Clients can then typecast to their own class, e.g. MyApp app = (MyApp) FXGL.getApp();


Automatically request repaint when Area size changed?

I'm using an Area to center some ui, with .anchor(CENTER_CENTER, ZERO), which mostly works very well, except the first frame it shows up in the wrong place. This is expected, as only afterwards can it remember the size of the contents and calculate the right position for the ui to appear centered.
However, this first frame with the wrongly positioned center area stays visible until some kind of input event is generated.
For now I worked around this by using:
            let r = Area::new("...").anchor(Align2::CENTER_CENTER, Vec2::ZERO).show(...);

            if (r.response.rect.center() - ctx.available_rect().center()).length_sq() > 1.0 {
                ctx.request_repaint();
            }

Would it make sense for egui::Area to automatically request a repaint when after adding the contents the size turned out to be different than what it assumed while chosing the position? (Or maybe some functionality on Response to easliy opt-in to that behaviour?)

Related: https://github.com/emilk/egui/issues/843


Added Reverse LinkedList II problem from leetcode

Added the solution of Reverse LinkedList problem II from leetcode in C++ language.

Great work @PrathamMishra
Keep it up

Hey can you accept other pr also
On Sun, 31 Oct, 2021, 2:54 am Princeton21, @.***> wrote:

@.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Princeton21/Hacktoberfest_DSA_2021/pull/367#pullrequestreview-793623576,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANHW7UX7TWCJB6FJCRAHFOTUJRPCPANCNFSM5HBMTIAA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


test(#37): create automated test loader

Wow, what a PR. As described in #37, an automated test runner/loader would be excellent as I develop a full-blown testing suite to ensure things continue to work. Here's the general outline of what happened:
Changes

Since seam carving is a computationally heavy operation, 6x6 matrices with values from [0, 255) were randomly generated and their Sobel images were computed with OpenCV (the tests really on the fact that the Sobel operator works properly in OpenCV since the code is taken from their tutorial).
The vertical/horizontal energy map, vertical/horizontal seams, and vertical/horizontal images after removal and insertion were all computed by hand, and this data, along with the data from step 1, was inserted into a spreadsheet. The spreadsheet was exported from Google Sheets and imported into my project.
I wrote a parser to create a neatly-formatted JSON file of all of the relevant testing data from a collection of TSVs. The format of the JSON is described below.

JSON testing data format
The new test data can be found at test/data.json. All matrices, with the exception of the insertion and removal arrays, are uchar one-dimensional arrays of size 36. This array can be parsed as a 6x6 matrix using one of OpenCV's cv::Mat constructors. test/data.json is an array of test objects where a test object has the following structure:
{
	"test_id": int,
	"input": uchar[],
	"energy": {
		"sobel": uchar[],
		"map - vertical": uchar[],
		"map - horizontal": uchar[]
	} ,
	"carver": {
		"find - vertical": Coord[],
		"find - horizontal": Coord[],

		"remove - vertical": uchar[],
		"remove -horizontal": uchar[],

		"insert - vertical": uchar[],
		"insert - horizontal": uchar[]
	}
}

Future testing implications
Adding test cases
As mentioned above, test matrices are 6x6. The data for these matrices aren't too interesting, nor are their seams, but it will do for now. In the future, if I want to expand this size, I can add new sheets to the Google Sheet linked above. However, larger test cases will still need to be generated by hand. I think in the future I will make the test matrices 10x10 to get some more interesting seams.
Using test/data.json
The current way I'm envisioning the new test data being used is as follows:

the test file loads test/data.json
the test file extracts the input and corresponding outputs. For example, if Carver.FindOptimalVerticalSeam() was being tested, then the test file would load all of the carver["find - vertical"] outputs from each test_id.
the test file compares expected outputs from test/data.json against the actual outputs from the function.

This PR took about two weeks 🎉
Closes #37

A future improvement of this test loader can use the Google Sheets API to keep itself updated rather than manually exporting tests and accounting for sizes. Issue #39 has been created to keep track of this.


Solution project passthrough doesn't support calling Build directly

Steps to reproduce
With a simple solution
Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 15
VisualStudioVersion = 15.0.27130.2010
MinimumVisualStudioVersion = 15.0.26124.0
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "proj1", "proj1\proj1.csproj", "{41A1218F-E59D-4AC9-9741-AC6356D0880B}"
EndProject
Global
        GlobalSection(SolutionConfigurationPlatforms) = preSolution
                Release|Any CPU = Release|Any CPU
                Release|x64 = Release|x64
                Release|x86 = Release|x86
        EndGlobalSection
        GlobalSection(ProjectConfigurationPlatforms) = postSolution
                {41A1218F-E59D-4AC9-9741-AC6356D0880B}.Release|Any CPU.ActiveCfg = Release|Any CPU
                {41A1218F-E59D-4AC9-9741-AC6356D0880B}.Release|Any CPU.Build.0 = Release|Any CPU
                {41A1218F-E59D-4AC9-9741-AC6356D0880B}.Release|x64.ActiveCfg = Release|Any CPU
                {41A1218F-E59D-4AC9-9741-AC6356D0880B}.Release|x64.Build.0 = Release|Any CPU
                {41A1218F-E59D-4AC9-9741-AC6356D0880B}.Release|x86.ActiveCfg = Release|Any CPU
                {41A1218F-E59D-4AC9-9741-AC6356D0880B}.Release|x86.Build.0 = Release|Any CPU
        EndGlobalSection
        GlobalSection(SolutionProperties) = preSolution
                HideSolutionNode = FALSE
        EndGlobalSection
        GlobalSection(ExtensibilityGlobals) = postSolution
                SolutionGuid = {4CDA96E1-5FDA-460E-811F-4C2D0BF46566}
        EndGlobalSection
EndGlobal

Attempt to build the Build target of the project explicitly
msbuild simple_proj.sln /t:proj1:Build

Expected  behavior
Builds the Build target in proj1.csproj
Actual behavior
C:\Users\raines\source\repos\simple_proj\simple_proj.sln.metaproj : error MSB4057: The target "proj1:Build" does not exist in the project. [C:\Users\raines\source\repos\simple_proj\simple_proj.sln]

Environment data
MSBuild <IP_ADDRESS>428

@rainersigwald, what are the chances that we can get someone to look into this?

It's not currently very high on our list @cowlinator, but I'll mark it as up-for-grabs. Are you interested in contributing a fix?

I wouldn't know where to start.  Could you point me in the right direction?


Add steady-state support

This includes renaming and adding parent selection and survivor selection operators (right now we only have parent selection).

[ ] Separate files for parent and survivor selection
[ ] Documentation about parent and survivor selection

I decided to only keep parent selection abstracted. This way, we don't have an additional file to worry about.
Survivor selection is then left up to the user, making it easier to switch between steady state and generational settings.
An important thing to note is that some code is reused by both variants. This is to make use of the dynamic dispatch of Julia and not do the extra overhead for every "couple" of parents.


AzCopy Asynchronous data transfer between two Azure Stacks

Hello,
Does scenario of asynchronous data transfer  between two different appliances of Azure Stacks is supported?
Thank you !

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c3a78588-520c-9787-dadc-7ae66cfa2ed4
Version Independent ID: 1e191327-255f-7754-0f27-82201b22382c
Content: Tools for Azure Stack storage
Content Source: articles/azure-stack/user/azure-stack-storage-transfer.md
Service: azure-stack
GitHub Login: @mattbriggs
Microsoft Alias: mabrigg

#please-close


No such file or directory: 'data/clothing1M/clean_train'

Hi, dear author.
Thank you for your excellent work!
But when I try to run your code in clothing1M dataset (I follow the instruction in readme), but directory "clean_train" does not exist. Could you provide the related code about this directory?
Thank you very much.

Hello,
Thank you for your interest in our work. The folder data/clothing1M is for placing the clothing1M data. As we described in README, for Clothing1M, as we do not own the Clothing1M data set we cannot share the data in this repo, please contact the original creator for data access.
Hope this helps.

If you already obtained the data, there is indeed some simple processing to prepare the clean_train, clean_val, noisy_train, clean_test folders. I just uploaded a script load_cloth1m_data.py under CLOTHING1M, please run python3 load_cloth1m_data.py under the CLOTHING1M directory and it'll generate all four folders.

Thank you very much!
It is worked!


mac. Icons too small.

this works on mac btw.
I managed to debug a gio app.
Got some hangs. Not sure why yet. But generally this looks like a nice light debugging tool. Great stuff.
I like the simple GUI, but the icons are way too small. For example the "run immediately" checkbox, and also the debugging step through buttons.

thanks @gedw99 Icons can be enlarged quiet easily it takes the fontsize as the icon size, so wrapping the icon function call with FontEnlarge will enlarge the icon.
I'll do it next time I work on this project.
Also feel free to tinker in it and open a pull request if you feel like it

@gedw99 I enlarged the icons a bit. if you found a way to reproduce the freezing issue I would be grateful

Thanks. Yeah I am playing with it , and will make PR as I see I can help

Oh and about freezing issue, yes I will raise a reproduction issue

I testing the latest main branch again
using github.com/egonelbre/expgio/cursors as a simple test case.

Icons are a good size now.


Fixed broken link

Just fixed a broken link on this page...

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/973ae110e7871f2473fb3b24ab323772ccfeae1d/
Edited pages:

v19.1/architecture/replication-layer.md


Missing pytorch training files

[Enter feedback here]
The links for pytorch training python file is missing.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 34201ee9-62ca-1ffc-ac23-01a742d5ba64
Version Independent ID: 20c4fd76-e65d-c9e5-a5a8-fe91790aa99b
Content: Train deep learning PyTorch models (SDK v2) - Azure Machine Learning
Content Source: articles/machine-learning/how-to-train-pytorch.md
Service: machine-learning
Sub-service: training
GitHub Login: @balapv
Microsoft Alias: balapv

@aveyMaster
Thanks for your feedback! We will investigate and update as appropriate.

@aveyMaster
The missing link for the PyTorch training Python file can be found in the article. Here is the link to the Python file
https://learn.microsoft.com/en-us/azure/machine-learning/how-to-train-pytorch?view=azureml-api-2#:~:text=Download the training script file pytorch_train.py.

@aveyMaster
We are going to close this thread.if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Fix TTL cache issue

Ref #478, #410, #404

Codecov Report

Merging #479 (9233327) into master (5a59e85) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #479   +/-   ##
=========================================
  Coverage     91.97%   91.97%
  Complexity      256      256
=========================================
  Files            40       40
  Lines           810      810
=========================================
  Hits            745      745
  Misses           65       65

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a59e85...9233327. Read the comment docs.

Codecov Report

Merging #479 (9233327) into master (5a59e85) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #479   +/-   ##
=========================================
  Coverage     91.97%   91.97%
  Complexity      256      256
=========================================
  Files            40       40
  Lines           810      810
=========================================
  Hits            745      745
  Misses           65       65

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a59e85...9233327. Read the comment docs.

Can you fix the tests please?

Can you fix the tests please?


Select does not show errors from Rails' belongs_to presence validation

Rails 6+ adds a presence validation to belongs_to associations by default. The validation is on association name, rather than name_id, but in forms the input is always going to be on name_id rather than name.
This means that the errors on name do not show on the name_id input, and the summary error does not link to the input correctly.
This issue has come up numerous times on stack overflow and other form builders, e.g. https://github.com/bootstrap-ruby/bootstrap_form/issues/318 but no clear consensus on the best solution. Arguably this is Rails' fault.
Is there a recommended solution for govuk-formbuilder? If so, it would be good to documented and add an example to https://govuk-form-builder.netlify.app/form-elements/select/ that uses belongs_to.

Thank you for reporting this @sfnelson. As it's a problem that'd manifest in the same way on a vanilla Rails app I think we might be best just adding a cautionary paragraph to the guide. It feels like suggesting the disabling of the setting and requiring validations to be explicitly added is the way to go.

Thinking about it, this problem will also happen in #govuk_collection_radio_buttons. Maybe the suggestion should go in the setup guide or README.

@peteryates thanks for the reply. That seems like a pragmatic approach at present. It would be good to have some guidance for users in how to resolve this disagreement between ActiveRecord's needs and ActiveView's needs – personally, I would to see the example at https://govuk-form-builder.netlify.app/form-elements/select/#select-field-with-a-label-and-hint to use an ActiveRecord association similar to https://guides.rubyonrails.org/v7.0/form_helpers.html#the-collection-select-helper
It seems like this is the way Rails has implemented belongs_to since at least Rails 4, so it's unlikely they are going to accept a change (e.g. recently proposed and closed https://github.com/rails/rails/pull/46839). Would you consider a PR that uses reflection to identify associations and merges errors from association and association_id? This could be useful for more than just presence validations. Another approach to consider is https://github.com/rails/rails/pull/46564

... As it's a problem that'd manifest in the same way on a vanilla Rails app ...

Vanilla Rails doesn't provide helpers for showing errors next to fields so the problem is not equivalent, e.g. this might be typical for a vanilla rails form:
<%= f.label :department_id %>
<% f.object.errors.messages_for(:department) do |message| %>
  <%= tag.div message class: "error" %>
<% end %>
<%= f.collection_select :department_id, departments, :id, :name %>

As an aside, there's a rubocop to flag and remove presence validations on belongs_to associations: https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsredundantpresencevalidationonbelongsto

Yeah, sorry I meant the underlying problem of the automatic validation being applied to the relationship but the form having to refer to the attribute name.

Would you consider a PR that uses reflection to identify associations and merges errors from association and association_id?

I think it could work but I suspect there's a fair bit of complexity involved. It might make sense for it to be implemented via an error summary presenter as that would allow people to opt in.
I'd still probably go with defining the validations explicitly, I'll create a PR with some amendments to the guide/README in the meantime.

Closing this now as I think the warnings address the problem.


bugfix and refactor for the fault tolerance feature

Signed-off-by: JunShen Wu<EMAIL_ADDRESS>Description
the new feature:
Auto redeploy model when cluster rebooted/node rejoin
When a ml node under the opensearch cluster halt down with some unknown reasons. The models under this node will be broken and impact the process of the inference or reduced performance. So we add a new feature: When a ml node halt down, we reboot this ml node, the opensearch on this node will auto redeploy all the models under this node,and user will not reload the model manually. Even  in extreme cases, if the redeploy operation is still unsuccessful, opensearch will also tell the user via logs that the redeploy was unsuccessful.
Issues Resolved
please see:  https://github.com/opensearch-project/ml-commons/issues/577
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #836 (abbeddd) into 2.x (036bda0) will increase coverage by 0.10%.
The diff coverage is 86.33%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.x     #836      +/-   ##
============================================
+ Coverage     84.81%   84.92%   +0.10%
- Complexity     1628     1666      +38
============================================
  Files           135      136       +1
  Lines          6079     6262     +183
  Branches        596      609      +13
============================================
+ Hits           5156     5318     +162
- Misses          666      683      +17
- Partials        257      261       +4

Flag
Coverage Δ

ml-commons
84.92% <86.33%> (+0.10%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...main/java/org/opensearch/ml/utils/MLNodeUtils.java
89.47% <0.00%> (-4.98%)
:arrow_down:

...org/opensearch/ml/model/MLModelAutoReDeployer.java
86.36% <86.36%> (ø)

...rg/opensearch/ml/plugin/MachineLearningPlugin.java
98.85% <100.00%> (+0.02%)
:arrow_up:

.../org/opensearch/ml/settings/MLCommonsSettings.java
100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


OSX compatibility

gettid() isn't available on OSX. But we can use the Ruby's thread_native.h to get an identifier.

Thanks for this! One thing I spotted is that https://ui.perfetto.dev/ seems not too like the big tids we get on macOS. E.g. I just got this trace for example1.json: https://gist.github.com/ivoanjo/31e4699d6dc74dd3e9c042f910aa989b
and here's how it looks in perfetto (this example has 4 threads):

But... if I just search and replace on my text editor the big thread ids with smaller ids, it works lol:

I'll try to report it upstream, but in the meanwhile, any preference on how to work around this? I guess we could % or otherwise truncate bigger values, but it is a bit of a shame that it becomes a number with no connection to anything people see on their Ruby VM.

Hum, that's annoying indeed.
At some point I wanted to provide a small incremental thread_id in the hook arguments, it's especially important because two Ruby threads may have the same native thread id (threads can be re-used in some cases).
I'll make a PR and see if Koichi is open to it.

Upstream PR: https://github.com/ruby/ruby/pull/6189

Hum, I just though that short term this library could use a thread local variable and an atomic to generate that same serial identifier. Let me try.

I discussed the upstream PR with Koichi, it may or may not be acceptable, it depends on another things he's working on, so we'll know in a bit.
In the meantime I'll use a thread local to generate that same serial.

Sounds reasonable. I'd still probably keep the task id for linux, since it seems like a more useful value than the not-visible-to-users serial. (?)

I'd still probably keep the task id for linux, since it seems like a more useful value than the not-visible-to-users serial. (?)

Up to you. I can do that if you prefer. I'd say the advantage of serial id is that it's incremental, so 0 is the main thread, 1 is the first thread you ever created etc etc.
But I can add some code to check if gettid() is present, just let me know.

I'm happy with the current version. Can always re-add the thread id later.
Thanks for the contribution! I'll make a release a bit later today :)


Remove download of man page generator dependencies

These are now part of man/Dockerfile.*

LGTM

LGTM

Bust those caches!


Restrict iterating over every workitem field for reorder

fixes https://github.com/openshiftio/openshift.io/issues/4259

Ike Plugins (test-keeper)
Thank you @DhritiShikhar for this contribution!

It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin.

Codecov Report

Merging #2261 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2261      +/-   ##
==========================================
- Coverage   69.38%   69.37%   -0.01%
==========================================
  Files         175      175
  Lines       16390    16380      -10
==========================================
- Hits        11372    11364       -8
+ Misses       3924     3923       -1
+ Partials     1094     1093       -1

Impacted Files
Coverage Δ

workitem/workitem_repository.go
67.95% <100%> (-0.14%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d00f196...3ba0022. Read the comment docs.

[test]

@kwk changed the way to update column.
tx = tx.Model(&res).Select("execution_order", "version").Updates(WorkItemStorage{
		ExecutionOrder: order,
		Version:        res.Version + 1,
	})

tx.Model(WorkItemStorage{Version:wi.Version}) doesnot work as expected

@kwk
I use updates instead of updateColumns
tx = tx.Model(&res).Select("execution_order", "version").Updates(WorkItemStorage{
		ExecutionOrder: order,
		Version:        res.Version + 1,
	})

tx.Model(WorkItemStorage{Version:wi.Version}) doesnot update execution order so still using tx.Model(&res)

[test]

[test]


2022041901

Thank you CTH for the amazing work.

Why not process request removal from denylist?
Like the following request removal, no one has paid attention for a long time.

Maybe add these as well in the PR? Another small bacth of Hummingbird clusters.
Or keep those for the next PR.
https://github.com/helium/denylist/issues/4007
https://github.com/helium/denylist/issues/4008
https://github.com/helium/denylist/issues/4010
https://github.com/helium/denylist/issues/4011
https://github.com/helium/denylist/issues/4012
https://github.com/helium/denylist/issues/4013
https://github.com/helium/denylist/issues/4014
https://github.com/helium/denylist/issues/4015
https://github.com/helium/denylist/issues/4016
https://github.com/helium/denylist/issues/4017
https://github.com/helium/denylist/issues/4018
https://github.com/helium/denylist/issues/4019
https://github.com/helium/denylist/issues/4020
https://github.com/helium/denylist/issues/4021
https://github.com/helium/denylist/issues/4022

Why not process request removal from denylist? Like the following request removal, no one has paid attention for a long time.

Good call!
Include #2239 as well, been on the list for almost 3 months now since my first removal issue.

Maybe add these as well in the PR? Another small batch of Hummingbird clusters. Or keep those for the next PR.
#4007 #4008 #4010 #4011 #4012 #4013 #4014 #4015 #4016 #4017 #4018 #4019 #4020 #4021 #4022

I think some of those came in after I did the roll-up.

I think the formatting of this update is off. Really appreciate the roll up though.

Is the 2nd commit better?

Why not process request removal from denylist? Like the following request removal, no one has paid attention for a long time.

Good call! Include #2239 as well, been on the list for almost 3 months now since my first removal issue.

I'll focus on these in the next PR.

Why not process request removal from denylist? Like the following request removal, no one has paid attention for a long time.

Good call! Include #2239 as well, been on the list for almost 3 months now since my first removal issue.

I'll focus on these in the next PR.

Thanks a lot

This needs a manifest.json update as well.
diff --git a/manifest.json b/manifest.json
index b68d3a9..9a076c8 100644
--- a/manifest.json
+++ b/manifest.json
@@ -1,14 +1,14 @@
 {
-  "serial":<PHONE_NUMBER>,
-  "hash": "vopOR1YL6H7qJ5gfSSNjCunYVYKK+LwJnhtfTdVM2zM=",
+  "serial":<PHONE_NUMBER>,
+  "hash": "5zowpgJ5P7IoFpZ0MHMEhycBwDYCIfI805U2oI9bdQo=",
   "signatures": [
     {
       "address": "13YqCei6dP2ibq2DAy81NmU8FYwwzo5HLKXFA3yM3Rvq9WxDfKF",
-      "signature": "pWJ41c2GQhypAy5amZibeM4ulxTJKpvHod/n/zOwd9GmlDIKr+Y+llhVbBKE4U/RpdPKHCfNqC5hcTcmWUtQAg=="
+      "signature": ""
     },
     {
       "address": "14egjs9cSxt4jnaZTYQE4NemQVXL6qtayqNNpy3VJPSS6AAcaUq",
-      "signature": "1DXMjT8fxgo1O5g2K9lEdqAr2f0qVF+JvLeytqn6/WqpeZPq2/YfYtB3pdFbjCqJ1TUjCCCkXDUrV8RxBn6qAw=="
+      "signature": ""
     },
     {
       "address": "13RKFFy5qmibyaS6N3Uw18UBDwGhhsXpk6jDn7SMenfDrQ6o6eh",
@@ -16,15 +16,15 @@
     },
     {
       "address": "13t59Q3oihn5YnhmW4bJARbxrK9TWaXgn2SUXZYpZYBScjKycYZ",
-      "signature": "NTA7mCTSpT9QIdnTzoAojV7XyalqbI+Yk3HGRDDxWlsPbGy6veUeog90kOa374N+XGK5tyIwXYHxoaiIQzX8DA=="
+      "signature": ""
     },
     {
       "address": "14M61qg7QF7FMN8vZw8ne66ZAf17aGaw6hyednoaFQfHwM6kmX7",
-      "signature": "5TNOlBE9HpXIoaN+jmflg9wgPeBwIzOrYwOA+rfq+99tyfpuHplzvB+SIfdvTnDAt+nCIvgUTN3DUXB75DGzAw=="
+      "signature": ""
     },
     {
       "address": "147DRzZFQDrsgt4VG5JCugqZtjPMVgtuzwgSLxkSpoGxSm34WKH",
-      "signature": "F9n/Cfa/lXlffEwlg57kUTVjdphVTtaf+Rzors2ECxRxw6EsX+Oaet5F1WgQPOw6XoOcGk7MoWPYCq1P567vBw=="
+      "signature": ""
     }
   ]
 }

This is what I generate based on this

Unfortunately the github bug that makes it hard to auto close all the open Issues hit us again here. @6CornerDefender any chance you're open to some manual closing?

This branch is merged and on main: https://github.com/helium/denylist/commit/84e0f9a176c8e037da10a9d9a7b9dd45212f1fff

I think the formatting of this update is off. Really appreciate the roll up though.

Is the 2nd commit better?
@6CornerDefender
Is my appeal automatically closed by this batch processing?
#2243 , #2245 , #2246 ,#2247 ,#2248 ,  #2249 , #2250

Why not process request removal from denylist? Like the following request removal, no one has paid attention for a long time.

Good call! Include #2239 as well, been on the list for almost 3 months now since my first removal issue.

I'll focus on these in the next PR.

#2737 Thank you in advance!

Why not process request removal from denylist? Like the following request removal, no one has paid attention for a long time.

Good call! Include #2239 as well, been on the list for almost 3 months now since my first removal issue.

I'll focus on these in the next PR.

That would be very much appreciated @6CornerDefender   #2239


Limit the update process by an upper fps bound.

The upper bound is set by the used camera config. This value can in
theory also be set by the user

sceneView.setMaxFramesPerSeconds([int])

The default value is 60
The user can fine adjust the upper bound by a FrameRate-Factor

@Override
public void onViewCreated(ArFragment arFragment, ArSceneView arSceneView) {
    arSceneView.setFrameRateFactor(SceneView.FrameRate.FULL)
}

Three different factor values are available

FULL  (1)
HALF  (2)
THIRD (3)

The upper bound is divided by the FrameRate-Factor
The default value for the FrameRate-Factor is FULL

That's perfect like always.
Could you just add a small cameraConfig.md page in the /doc/ folder? Like I have from your Depth PR here:
https://github.com/ThomasGorisse/sceneform-android-sdk/blob/master/docs/depth.md
Simply/mostly paste the text you've already wrote on your PR description.
Has a bonus, a very little general AR camera configuration would be top.
I'm really sorry for not having time for it right now but it's it's due to the fact that I'm currently working hard on the repository visibilty from outside (referencing, articles, GitHub Page, screenrecords…)
Thanks

I added the documentation


Add author to post

Allows members to submit posts with attribution.
This covers #110 also.
@spikeheap MERGE AWAY!

:+1: :shipit:


[FLINK-33636][autoscaler] Support the JDBCAutoScalerEventHandler

What is the purpose of the change

[FLINK-33636][autoscaler] Support the JDBCAutoScalerEventHandler
Design doc: https://docs.google.com/document/d/1wXs6lLvX5jw6KNsz1pP9rdNLGoeInWkd5lbZo-rQp4s/edit?usp=sharing

Verifying this change
Unit test and IT case under development.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): yes
The public API, i.e., is any changes to the CustomResourceDescriptors: no
Core observer or reconciler logic that is regularly executed: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? docs

@gyfora  @mxm , sorry to bother you again. During I supporting PostgreSQL and Derby, I found some defects for jdbc event handler and jdbc state store about the table schema.
In order to ensure the stability of the table structure, I'd like to polish the state store design first. And finish the event handler in the next version. Thank you.

@1996fanrui How important is it for you to get this into 1.8.0? I think the 1.8.0 release could wait until then.

Sounds like @1996fanrui wants to have a peaceful vacation. I don't see any reason why we should rush this into the release or delay the release because of it.

@1996fanrui How important is it for you to get this into 1.8.0? I think the 1.8.0 release could wait until then.

If I didn't take vacation, I might ask for a two-day delay in release. (With two days of delay plus the weekend, I believe I have enough time to complete this PR). But I will be on vacation for 10 days, I am worried about affecting the release progress. Sorry for that.

Hi @gyfora @mxm , the development and test JdbcAutoscalerEventHandler are totally done,  it can be included in 1.8.0.
I finished the unit test, itcase, and I tested it on my local manually. It works well.


Compare to SVGHeight instead of prevSVGHeight

Fixes a bug that causes the viewer not to update when changing height of the embedded SVG.

I was going to write up an issue about this, but then i discovered where the problem should be fixed, so I decided to make a PR instead.
Thanks for a great framework!

Great! Thanks for this PR. I'm going to release a new version

Fixed with 3.0.2. You're now in the contributors list

Thanks! Glad to help


Unable to establish MQTT Connection with WSS protocol

Hi, I am trying to establish MQTT connection with WSS protocol (mqtt-xmeter-2.0.2-jar-with-dependencies).
I have tried with both Efficient Connect & MQTT Connect samplers, but unable to do so.
Below configurations am trying 👍
However, it connects successfully with MQTT Box using wss protocol.
Moreover, tried with all possible combination w.r.t. port, ws path, without port/ws path, protocols, etc.
Please suggest.

Please move the /mqtt? to the WS Path field. It should work fine :)