Remove dependence on mbstring extension

This patch removes reliance on the mbstring extension in three places:

The unicodeTrim function used mbstring to generate a UTF-8 encoding of a U+00A0 NO-BREAK SPACE character. This has been replaced by a sequence of byte escapes instead. The trimming has also been corrected not to substitute no-break spaces in the middle of the string
The nestedMfPropertyNamesFromClass function used mbstring to remove a prefix from the start of a string. All prefixes to remove are ASCII, however, making the use of mbstring unnecessary. The calls to mbstring functions have simply been replaced with their standard PHP equivalents
The  unicodeToHtmlEntities function uses mbstring to work around decoding problems in the DOMDocument class, according to commit d1c70ad288894f4c7e49278c0dc5588cd876d3f8. The commit in question does not elaborate on what these decoding problems are, nor is this functionality tested in the test suite. It is unclear if these problems even exist in modern PHP versions. I have elected to make the conversion optional, using mbstring if available.

Note this would address issue #136.

To address 3: yes, I believe this is still a problem even in the latest PHP stable. This is because it is not a PHP problem but a libxml problem. By today's standard, using libxml for HTML parsing really is not cutting it. But it is the only somewhat-globally available parser PHP has ever had.
There is a little more information about it here on StackOverflow which also mentions the solution php-mf2 is using.
(This is just one of many things you need to think about when doing HTML parsing in PHP.)
I feel like we really need to add tests where we parse non-UTF-8 HTML input, to see whether the removal of the mb_ functions breaks anything.

Thanks for clarifying. Sounds to me the answer is to handle character encoding properly, detecting encoding either from the HTTP header or pre-scan, then either prepending an XML declaration or modifying any existing one.
I did write an implementation of the HTML charset pre-scan algorithm last year for my own HTML parser. It shouldn't be that hard to backport to PHP 5.6, but it would add a lot of code (about 500 lines, with comments).

That might work. This also may already be handled if you use the userland HTML5 parser we recommend. I just think we do not have any tests for it.
At some point we will have to do the value calculation as well whether it is worth putting character encoding checking in our code (and having to maintain that) or if it is better to make something like the Masterminds HTML5 parser mandatory as a dependency.
I'd love to hear the input from the other maintainers here. But my instinct is to err on the side of "if it ain't broke, don't fix it". It would be really nice if we could get rid of mb_ function dependencies, but without the full test coverage of why they are in place, I am a little scared of merging something like this PR as it stands :sweat:
Lets keep this PR open to keep discussing what our alternatives are though!

In an effort to better understand the problem, I ran DOMDocument ::loadHTML() through html5lib's encoding-detection test suite (comprising 82 tests), inferring the encoding based on reading out some data I inserted into the test input. It failed 76 of the 82 tests, though because of how the tests are written the failure rate is perhaps higher than it could be. In any case, one can assert the following:

It does not attempt heuristic detection before using its fallback encoding in the absence of a charset declaration (which is not, it should be noted, a requirement)
Its fallback encoding is indeed ISO 8859-1, not Windows-1252 as it should be
It does not support the modern <meta charset="..."> charset declaration (this is the source of most failures)
Parsing fails in the presence of malformed characters rather than generating replacement characters

Given all that (especially the third point) I am forced to the agree that the patch under discussion would be insufficient. However, the current arrangement isn't great, either. It has its own set of problems:

At least on my system, mb_detect_order() returns ["ASCII", "UTF-8"], so while it will detect UTF-8, it won't detect anything else, returning false for most encodings (or for some, "UTF-8" incorrectly).
Passing false as the third parameter of mb_convert_encoding() issues a warning, so if mb_detect_encoding() does fail, mf2 will currently issue said warning
If the document is not in fact UTF-8, non-ASCII characters will be dropped. For example, feeding it the byte A5 (yen sign in windows-1252 encoding) yields the nonsense character reference &#2013266085;, which DOMDocument ignores after issuing a warning (which mf2 suppresses)
Since mb_convert_encoding() is called unconditionally, mf2 may be clobbering perfectly good documents with charset declarations DOMDocument actually understands

I suggest, therefore, that in the interim commit 6fb321e0f1700493953cc9198deb8c71036a9962 essentially be reverted, and that a detection order (only UTF-8?) be specified for consistency, as well as using strict mode.

I've now taken a different tack to fixing this, looking for <meta charset="..."> after parsing the document, and re-parsing with a byte order mark added if necessary. It necessitated altering tests which assumed heuristic detection, but it seems to work well otherwise. I can add more rigorous tests for the charset detection itself if this is deemed a suitable solution in general.

I think I am still with my previous comment and would like someone else to weight in besides me:

I'd love to hear the input from the other maintainers here. But my instinct is to err on the side of "if it ain't broke, don't fix it". It would be really nice if we could get rid of mb_ function dependencies, but without the full test coverage of why they are in place, I am a little scared of merging something like this PR as it stands 😓

I still do not know why we were forcing everything through a mb_convert_encoding in the first place. But if I am reading your PR correctly, that is dropped in favour of either adding a BOM or leaving the input completely untouched? Is there anything we are breaking by leaving the input untouched. e.g. when the input is coming in some non-latin encoding? Something that was previously fixed by running it through the conversion function?
Having a hard time evaluating the effects of this PR.
As far as the implementation itself, I think it is some really nice work! The addition of scanning the <meta> tag is close to how browsers would handle it. I wonder if it is also worth keeping watch for an encoding in Content-Type HTTP headers, if the user is letting the mf2 parser do the fetching.
Those different inputs are also mentioned by the HTML encoding sniffing algorithm. And this is also where I feel we might be heading out on thin ice. I would not want to have to maintain encoding sniffing in the mf2 parser library. Or if it does end up in here, it should have very strict unit tests on its own. (Maybe there is an existing implementation we can pull in instead?)
I am of many minds when it comes to this PR ...

I still do not know why we were forcing everything through a mb_convert_encoding in the first place.

The intent was obviously to bypass PHP DOM's character encoding detection, which does not support <meta charset="..."> as is commonly used on modern HTML documents (which would garble UTF-8 documents, which are now overwhelmingly common). It did this by converting all non-ASCII characters to HTML character references based on the heuristically-detected encoding according to mb_detect_encoding. This left only ASCII characters, so whatever encoding PHP DOM does or does not detect is irrelevant.

But if I am reading your PR correctly, that is dropped in favour of either adding a BOM or leaving the input completely untouched?

Correct. If <meta charset="..."> is found in the document and the charset is some valid label for UTF-8, a UTF-8 BOM is added, which PHP DOM does recognize, and the document is re-parsed correctly. If no such meta-element is found the document is left as-is with the assumption that it has an old-style encoding declaration and is fine.

Is there anything we are breaking by leaving the input untouched. e.g. when the input is coming in some non-latin encoding? Something that was previously fixed by running it through the conversion function?

In fact if the input is not UTF-8 the current way is almost certainly breaking things, as mb_detect_encoding by default only answers with either UTF-8 or iso-8859-1; documents in other encodings (like Shift_JIS which is still somewhat common in Japan) will parse out with lots of garbage. As-is this PR would break UTF-8 documents with no encoding declaraction (or BOM) whatsoever.

As far as the implementation itself, I think it is some really nice work! The addition of scanning the <meta> tag is close to how browsers would handle it. I wonder if it is also worth keeping watch for an encoding in Content-Type HTTP headers, if the user is letting the mf2 parser do the fetching.

Thanks! Yes, checking the HTTP header is definitely a good idea, but it's not trivial to actually do correctly. I wrote an implementation of a header parser myself, but using it would bump php-mf2's platform requirement to PHP 7.1.

Those different inputs are also mentioned by the HTML encoding sniffing algorithm. And this is also where I feel we might be heading out on thin ice. I would not want to have to maintain encoding sniffing in the mf2 parser library. Or if it does end up in here, it should have very strict unit tests on its own. (Maybe there is an existing implementation we can pull in instead?)

There is! I wrote one! Again, though, it requires PHP 7.1, and it's a full parser, which is pretty slow. You can use the character detection functions manually, though. The encoding detection portion has 202 tests with full coverage (the parser as whole has over 18,000 tests).
I wrote this patch long before my parser was finished, and I know that you have good reasons to continue supporting ancient PHP, otherwise I probably wouldn't have gone to the trouble of finding a good-enough alternate solution. :)

Hi @JKingweb, I finally took the time to look at this PR in more detail, getting slightly distracted by checking out your HTML5 parser along the way — looks like very nice work!
Some background about the heavy-handed usage of mbstring: php-mf2 was my first ever open source project, started in my mid teenage years. From what I recall, converting the entire document to ASCII HTML entities was the best solution to DOMDocument’s poor UTF-8 support which I could find at the time — it didn’t occur to me to try adding a UTF-8 BOM (a solution with which I’ve regrettably become very familiar with since then, due to having to create unicode CSV files which work with SPSS on windows — but that’s another story). It worked well enough (and I spent several years away from php-mf2) that I never thought to look for new solutions.
I must admit that I’m still a little confused about the state of DOMDocument’s character encoding detection support and the apparent need to implement our own meta charset decetion, given that it does in fact appear to support <meta charset="utf-8">, and will even complain about invalid charsets:

default (no <meta charset>, garbled UTF-8): https://3v4l.org/ZQ6FD
with <meta charset="utf-8" />: https://3v4l.org/KaSEU
with <meta charset="unicode-1-1-utf-8" />: https://3v4l.org/gR0gj
no <meta charset>, with UTF-8 BOM: https://3v4l.org/bGeG7
invalid <meta charset>, with complaint and garbled UTF-8 chars: https://3v4l.org/L750a
invalid <meta charset> but with UTF-8 BOM: complaint but valid UTF-8 https://3v4l.org/k6Ekl

This seems to contradict your assertion that “PHP DOM's character encoding detection, [•••] does not support ” — please let me know if I’m missing something obvious here!
Assuming I’m not missing anything, my conclusion would be the following:

PHP DOMDocument handles documents containing a UTF-8 BOM and/or <meta charset> just fine by itself.
UTF-8 difficulties arise in any of the many cases where a string is encoded as UTF-8 but has neither BOM nor <meta charset>, such as:

Document fragments parsed for testing

Documents where the content encoding is only communicated via Content-type: charset= headers, which are currently either unavailable to php-mf2, or ignored.

Documents which lack any indication of encoding and are assumed to be UTF-8

The first case is easy enough to solve internally, as we can simply add the UTF-8 BOM to any HTML fragments used in testing. The others are harder. I have a few ideas about potential solutions, but would like to hear back from you and the other maintainers before trying to come up with anything in more detail.

I seem to have missed your reply, @barnabywalters, which is quite unfortunate. Apologies about that.

I must admit that I’m still a little confused about the state of DOMDocument’s character encoding detection support and the apparent need to implement our own meta charset decetion, given that it does in fact appear to support , and will even complain about invalid charsets:

I too am confused. I had run a battery of tests and had confirmed the situation at the time, but maybe it was simply a matter of my system being misconfigured, as I cannot reproduce it now, either. I had been running PHP in Windows, which is a somewhat unusual arrangement to begin with, and maybe I still had an ancient libxml hanging aroundwhich PHP decided to use rather than its own newer version. In case, it seems not to be a problem after all.

The first case is easy enough to solve internally, as we can simply add the UTF-8 BOM to any HTML fragments used in testing. The others are harder. I have a few ideas about potential solutions, but would like to hear back from you and the other maintainers before trying to come up with anything in more detail.

The header case is relatively simple: add a <meta charset=whatever> to the top of the document. The only complication is that this should be doing after any DOCTYPE in case the libxml parser has any quirks-mode handling that might be relevant. Of course you have to also parse the Content-Type header-field, and the specification is somewhat exacting with this, but as we're only interesting in charset parameters and any valid value there is ASCII, there are a few shortcuts which can be taken.
The last case is trickier, though probably vanishingly rare. Nevertheless, one could do the equivalent of mb_detect_encoding for UTF-8 by looking for any non-ASCII bytes which don't match the UTF-8 byte pattern using preg_match, and if the number of matches is low, we can conclude the document is UTF-8.

I ran some fresh tests on what is recognized by libxml in PHP versions across time as an encoding declaration, using this test program:
<?php
$uni = "\xC3\xA9";              // U+00E9 LATIN SMALL LETTER E WITH ACUTE in UTF-8
$iso = "\xE9";                  // U+00E9 LATIN SMALL LETTER E WITH ACUTE in ISO 8859-1
$bom = "\xEF\xBB\xBF";          // UTF-8 byte order mark
$mojibake = "\xC3\x83\xC2\xA9"; // U+00E9 LATIN SMALL LETTER E WITH ACUTE in UTF-8 decoded as ISO 8859-1 and re-encoded into UTF-8

function mkUtf16be($s) {
    return preg_replace("/[\x{01}-\x{7F}]/s", "\x00$0", $s);
};
function mkUtf16le($s) {
    return preg_replace("/[\x{01}-\x{7F}]/s", "$0\x00", $s);
};

// sample documents with various forms of encoding detection
$input = array(
    array($iso, $uni),
    array($uni, $mojibake),
    array($bom.$uni, $uni),
    array("<meta charset='utf-8'>$uni", $uni),
    array("<meta charset='iso8859-1'>$iso", $uni),
    array("<meta http-equiv='content-type' content='text/html;charset=utf-8'>$uni", $uni),
    array("<meta http-equiv='content-type' content='text/html;charset=iso8859-1'>$iso", $uni),
    array("<meta http-equiv='content-type' content='text/html;charset=utf-8'><meta charset='iso8859-1'>$uni", $uni),
    array("<meta http-equiv='content-type' content='text/html;charset=iso8859-1'><meta charset='utf-8'>$iso", $uni),
    array("<?xml version='1.0' encoding='UTF-8'?>$iso", $uni),
    array("<?xml version='1.0' encoding='iso8859-1'?>$iso", $uni),
    array("<?xml version='1.0' encoding='iso8859-1'?><meta charset='iso8859-1'>$iso", $uni),
    array("<?xml version='1.0' encoding='iso8859-1'?><meta http-equiv='content-type' content='text/html;charset=iso8859-1'>$iso", $uni),
    array("$bom<meta http-equiv='content-type' content='text/html;charset=iso8859-1'>$uni", $mojibake),
    array(mkUtf16be("<meta charset='utf-16be'>\x00$iso"), ""),
    array(mkUtf16le("<meta charset='utf-16le'>$iso\x00"), ""),
    array(mkUtf16be("<meta charset='utf-16'>$iso\x00"), ""),
    array(mkUtf16be("\xFE\xFF<meta charset='utf-16be'>\x00$iso"), $uni),
    array(mkUtf16le("\xFF\xFE<meta charset='utf-16le'>$iso\x00"), $uni),
    array(mkUtf16be("\xFE\xFF\x00$iso"), $uni),
    array(mkUtf16le("\xFF\xFE$iso\x00"), $uni),
    array(mkUtf16be("\xFE\xFF<meta charset='utf-8'>\x00$iso"), $uni),
    array(mkUtf16le("\xFF\xFE<meta charset='utf-8'>$iso\x00"), $uni),
);
echo "PHP ".PHP_VERSION." libxml ".LIBXML_DOTTED_VERSION."\n";
foreach ($input as $k => $test) {
    list($in, $exp) = $test;
    $k = str_pad((string) ++$k, strlen((string) sizeof($input)), " ", STR_PAD_LEFT);
    $d = new DOMDocument;
    @$d->loadHTML($in);
    if (($exp === "" && !$d->documentElement) || $d->documentElement->textContent === $exp) {
        echo "$k. PASS\n";
    } elseif ($d->documentElement) {
        echo "$k. FAIL ".bin2hex((string) $d->documentElement->textContent)."\n";
    } else {
        echo "$k. FAIL\n";
    }
}

I used Windows versions of PHP as these are known to be bundled with contemporaneous versions of libxml. My findings were thus:

<meta charset="..."> became supported with libxml 2.8.0; the first version of PHP where this works is PHP 5.5, bundled with libxml 2.9.1
<?xml version="1.0" encoding="..."?> erroneously signals UTF-8 encoding prior to libxml 2.9.11, regardless of which encoding is actually listed in the declaration. This was obviously a bug. PHP 8.1 was the first version to ship with the fix as it bundled libxml 2.9.12
A UTF-8 BOM will be ignored if a valid meta element is in the document
A buggy XML declaration will also be ignored if a valid meta element is present
New-style meta and old-style meta have equal weight
Handling of UTF-16 BOMs is buggy prior to PHP 8.0, evidently due to a PHP bug rather than a libxml bug
The only completely reliable way to signal encoding is an old-style meta tag, but a new-style one is sufficient for the new target of PHP 5.6

And now, a third attempt. The patch as it now stands is much more complex, but it has the following advantages:

Encoding from Content-Type can be wired up easily (modifying the API to do so should probably be a separate patch, however)
2.Encoding detection is otherwise done as a browser would do
If no encoding information is included at all, UTF-8 encoding is still inferred from the byte pattern of the input string, just as mb_detect_encoding would do
We avoid the situation where mb_detect_encoding detects something other than UTF-8 or ISO 8859-1 as ISO 8859-1 thereby corrupting the text
The current approach is based on extensive testing of what PHP 5.6 through 8.2 does on both Linux and Windows: in addition to the test script in my comment of three days ago, another test script was used to figure out which encoding labels DOMDocument understands, rather than just blindly using the standard names
The logic for parsing Content-Type headers is a slight modification of existing code which had been rigurously tested

Though it is more than 500 added lines, much of that is either static data or detailed comments. All existing tests pass without modification, and if there is interest in merging this patch I will of course write as many tests as needed to cover the new logic.


Add last edited date to pages

It would be helpful in having an idea of how out of date a page is. As things are, there's no way to tell if a page was made for the most recent version of SMA or not.

Good idea, I'll look into it


Explicitly show the required number of approvals

@bradrydzewski PTAL
This is an attempt to address #3
BTW it looks like running make gen introduced some changes in autogenerated code. I assume this is due to me using a newer version of the dependency.

thanks!


fix: ignore unsupported "name" subsections

According to the WebAssembly specification, custom sections shouldn't
cause parsing to fail, and so we shouldn't error out because of an
unsupported subsection in the "name" custom section. This will make
the library more robust wrt. additions of more custom names.
Bug: https://crbug.com/1137335

:tada: This PR is included in version 3.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


"List banned users" item in the context menu (02/20/2015)

Typing /bans still shows me the banlist, there's just no item in the menu for it. I'm used to just pressing that so nyyaa
Also: (20:15:58) Koishi: Banned Users/IPs: This could say "No banned users" instead or something, it just looks better.

This shouldn't be here either.


testing protected branch

added TEST.txt to the dev branch on my repository

@ryantanaka ok it wont allow without my accepted review (or anyone's), what does it show now to you? is the merge button green to you?

The merge button is not green. It looks like this on my end.

@ryantanaka Great, it is working how I intended it to. This should avoid slips! Also, how is wiki side? Can you edit and create pages?

awesome! i created and saved a test wiki page on survey_display_local, but was unable to on survey_display_server since there is no wiki in it yet. can you create one? and I'll try make a test wiki there.

sorry it works, I just forgot to accept the invitation -__-

Which invitation you didn't accept?
Also did you try sending a commit directly to the repo without being via pull request? Did you get denied?

@carlosviansi  sorry for the confusion, I commented on this issue and not here.
And I forgot to accept the invitation for survey_display_server before trying to create a wiki there.


How can FEI_ec_c be "coming soon" to TaxBrain?

@talumbau added _FEI_ec_c to the TAXCALC_COMING_SOON_FIELDS list in commit 7d873eb on January 27, 2016.  Unless I'm missing something, it seems to me that this was a mistake and that the _FEI_ec_c policy parameter should have been added to the TAXCALC_HIDDEN_FIELDS list.
In the current version of Tax-Calculator, _feided is always zero (because there is no information on foreign earned income in the 2009 IRS-SOI PUF).  And, in addition, there is no information about whether Form 2555 was filed, and thus, the variable f2555 is always zero in Tax-Calculator.  This situation implies that changes in the _FEI_ec_c policy parameter will have no effect on Tax-Calculator output, which is not what a TaxBrain user would expect if (s)he was offered the chance to change the _FEI_ec_c policy parameter.  Below is the only line in the functions.py file that uses this policy parameter:
c02700 = min(_feided, FEI_ec_c * f2555)

The value of c02700 is always zero in the current version of Tax-Calculator, no matter what _FEI_ec_c value has been specified.
Also, note that all the other names in the TAXCALC_COMING_SOON_FIELDS list are not Tax-Calculator parameters, and therefore, should be deleted.
@MattHJensen @feenberg

@talumbau, the webapp/apps/taxbrain/helpers.py file contains the following code fragment:
TAXCALC_COMING_SOON_FIELDS = [
    '_Dividend_rt1', '_Dividend_thd1',
    '_Dividend_rt2', '_Dividend_thd2',
    '_Dividend_rt3', '_Dividend_thd3',
    '_BE_CG_trn', '_FEI_ec_c'
    ]

TAXCALC_HIDDEN_FIELDS = [
    '_ACTC_Income_thd',
    '_AMT_Child_em', '_AMT_em_pe', '_AMT_thd_MarriedS',
    '_CDCC_ps', '_CDCC_crt',
    '_DCC_c',
    '_EITC_InvestIncome_c', '_EITC_ps_MarriedJ',
    '_ETC_pe_Single', '_ETC_pe_Married',
    '_KT_c_Age',
    '_LLC_Expense_c'
]

TAXCALC_COMING_SOON_INDEXED_BY_MARS = [
    '_Dividend_thd1','_Dividend_thd2', '_Dividend_thd3'
]

But when I search for the phrase Dividend_ in the Tax-Calculator repo, I find nothing:
tax-calculator$ grep -r --include="*py" Dividend_ .
tax-calculator$
tax-calculator$ grep -r --include="*json" Dividend_ .
tax-calculator$

And when I search for the phrase BE_CG_trn in the Tax-Calculator repo, I find nothing:
tax-calculator$ grep -r --include="*py" BE_CG_trn .
tax-calculator$
tax-calculator$ grep -r --include="*json" BE_CG_trn .
tax-calculator$

Am I missing something?  Or should those seven variables be removed from the TAXCALC_COMING_SOON_FIELDS list?  If so, then the TAXCALC_COMING_SOON_INDEXED_BY_MARS list should be empty.
And then what about the remaining _FEI_ec_c variable in the TAXCALC_COMING_SOON_FIELDS list?  Should it not be moved to the TAXCALC_HIDDEN_FIELDS list for the reasons mentioned earlier in this issue?
Perhaps I'm confused, but it seems as if the code here has fallen out of date.  The webapp team is putting a lot of energy into new interfaces for new OSPC models, so it would seem as if removing the highly misleading COMING SOON label on the _FEI_ec_c parameter should get at least a little consideration.
@MattHJensen @Amy-Xu

In #137 , I interpreted Amy's comment:
"This parameter won't work right due to lack of data. So we should remove this one from input page for now."
to mean that we would, in a relatively short amount of time, have the ability to use this parameter. It looks like that is not the case. I will put _FEI_ec_c in the hidden fields.

In commit https://github.com/open-source-economics/Tax-Calculator/commit/d455762009ef26351bba9da79143b96f71c796f6, @MattHJensen removed BE_cg_trn, so I'll remove that from the TAXCALC_COMING_SOON_FIELDS

In commit https://github.com/open-source-economics/Tax-Calculator/commit/b8ca2850aa7cde955aa06aaeebc936d21f713c3c @Amy-Xu renamed the Dividend_* parameters, so I will delete any mention of these from the webapp repo.

Re-opening so that this stays open until merge of #294. In Github, since I referred to this issue in #294 by writing "resolves #285", Github should automatically close this issue when PR #294 is merged.


Prefer Vercel Framework Agnostic Env

Describe the bug
When deploying to Vercel, the module will set default site config from the Vercel environment variables. However, these will not work when the end-user has not manually selected the Nuxt framework.
For this reason we should prefer the agnostic environment variables.
NUXT_ENV_<key> -> <key>
Reproduction
No response
System / Nuxt Info
No response

Looking at the code we already prefer VERCEL_URL over NUXT_ENV_VERCEL_URL


Bug: You must feed a value for placeholder tensor 'input_1/dones_ph' with dtype float and shape [1]

Hello.
When I try to use pretrain with MlpLnLstmPolicy before actual learning,
it causes below traceback, and doesn't work.
As I see the code, i can't find feeding "dones_ph" in the base_class code.
# base_class.py : 228
feed_dict = {
    obs_ph: expert_obs,
    actions_ph: expert_actions,
}
train_loss_, _ = self.sess.run([loss, optim_op], feed_dict)

I think this pretrain is not compatitable with the MlpLnLstmPolicy.
Below is my code, and the error tracebacks.
Please help if I am wrong.
# My Code
env = DummyVecEnv([lambda: MyEnv()])
dataset = ExpertDataset(expert_path="my_data_set.npz", traj_limitation=-1, batch_size=1)

model = PPO2(policy="MlpLnLstmPolicy", env=env)

model.pretrain(dataset, n_epochs=100)

Errors :
Traceback (most recent call last):
  File "lib\tensorflow\python\client\session.py", line 1334, in _do_call
    return fn(*args)
  File "lib\tensorflow\python\client\session.py", line 1319, in _run_fn
    options, feed_dict, fetch_list, target_list, run_metadata)
  File "lib\tensorflow\python\client\session.py", line 1407, in _call_tf_sessionrun
    run_metadata)
tensorflow.python.framework.errors_impl.InvalidArgumentError: You must feed a value for placeholder tensor 'input_1/dones_ph' with dtype float and shape [1]
	 [[{{node input_1/dones_ph}}]]
	 [[{{node pretrain/Mean}}]]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "home/ppo/main.py", line 161, in <module>
    start()
  File "home/ppo/main.py", line 37, in start
    model.pretrain(dataset, n_epochs=100)
  File "lib\stable_baselines\common\base_class.py", line 232, in pretrain
    train_loss_, _ = self.sess.run([loss, optim_op], feed_dict)
  File "lib\tensorflow\python\client\session.py", line 929, in run
    run_metadata_ptr)
  File "lib\tensorflow\python\client\session.py", line 1152, in _run
    feed_dict_tensor, options, run_metadata)
  File "lib\tensorflow\python\client\session.py", line 1328, in _do_run
    run_metadata)
  File "lib\tensorflow\python\client\session.py", line 1348, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: You must feed a value for placeholder tensor 'input_1/dones_ph' with dtype float and shape [1]
	 [[node input_1/dones_ph (defined at lib\stable_baselines\common\policies.py:346) ]]
	 [[node pretrain/Mean (defined at lib\stable_baselines\common\base_class.py:214) ]]

Caused by op 'input_1/dones_ph', defined at:
  File "home/ppo/main.py", line 161, in <module>
    start()
  File "home/ppo/main.py", line 31, in start
    model = PPO2(policy="MlpLnLstmPolicy", env=env)
  File "lib\stable_baselines\ppo2\ppo2.py", line 93, in __init__
    self.setup_model()
  File "lib\stable_baselines\ppo2\ppo2.py", line 126, in setup_model
    n_batch_step, reuse=False, **self.policy_kwargs)
  File "lib\stable_baselines\common\policies.py", line 701, in __init__
    layer_norm=True, feature_extraction="mlp", **_kwargs)
  File "lib\stable_baselines\common\policies.py", line 406, in __init__
    scale=(feature_extraction == "cnn"))
  File "lib\stable_baselines\common\policies.py", line 346, in __init__
    self._dones_ph = tf.placeholder(tf.float32, (n_batch, ), name="dones_ph")  # (done t-1)
  File "lib\tensorflow\python\ops\array_ops.py", line 2077, in placeholder
    return gen_array_ops.placeholder(dtype=dtype, shape=shape, name=name)
  File "lib\tensorflow\python\ops\gen_array_ops.py", line 6834, in placeholder
    "Placeholder", dtype=dtype, shape=shape, name=name)
  File "lib\tensorflow\python\framework\op_def_library.py", line 788, in _apply_op_helper
    op_def=op_def)
  File "lib\tensorflow\python\util\deprecation.py", line 507, in new_func
    return func(*args, **kwargs)
  File "lib\tensorflow\python\framework\ops.py", line 3300, in create_op
    op_def=op_def)
  File "lib\tensorflow\python\framework\ops.py", line 1801, in __init__
    self._traceback = tf_stack.extract_stack()

InvalidArgumentError (see above for traceback): You must feed a value for placeholder tensor 'input_1/dones_ph' with dtype float and shape [1]
	 [[node input_1/dones_ph (defined at lib\stable_baselines\common\policies.py:346) ]]
	 [[node pretrain/Mean (defined at lib\stable_baselines\common\base_class.py:214) ]]

System Info
Describe the characteristic of your environment:

Describe how the library was installed (pip, docker, source, ...)
GPU models and configuration
Python version
Tensorflow version
Versions of any other relevant libraries

Additional context
Add any other context about the problem here.

Hello,
Recurrent policies are currently not supported for pretraining.
There is an issue #253  and a PR (awaiting review #315) that should solve that issue.
It should be part of the next major release.
If you try the PR, could you give use feedback?
Note: I will close this issue to avoid duplicates.

Thank you for quick answering.
I missed for that issue.
Surely I would use that PR with the feedback.


Image issues in transpiler stages topic

URL to the relevant documentation
https://docs.quantum.ibm.com/transpile/transpiler-stages
Select all that apply

[ ] typo
[ ] code bug
[ ] out-of-date content
[ ] broken link
[X] other

Describe the fix.
There are a couple of issues with images on this page.

[ ] The first image is in dark mode.
[ ] transpiler-11 is in there twice.  I'm pretty sure the one after "The transpilation output varies due to the stochastic SWAP mapper. Therefore, the numbers below will likely change each time you run the code." is supposed to be a different image.

@abbycross or @kaelynj Can one of you help me figure this out?

I suspect that the duplicate image Becky mentions above (see screenshot) can be removed altogether, unless @kaelynj do you recall if an image is intentional in this spot?

I used the same image for these two examples since they prepare the same example state.  Though I see the point about having the same image twice.  In the first part where it talks about the routing stage it might be better to instead add in a graph image of the hardware qubits that were assigned after the trivial_layout method was selected using plot_circuit_layout() from the qiskit.visualization module.

I tried it out, using example lines of code from the API, and got this -- @kaelynj does this look like what you'd expect?

This is the code I added to the cell
new_circ_lv1 = transpile(ghz, backend=backend, optimization_level=1)
plot_circuit_layout(new_circ_lv1, backend)

Yep!  This shows the point that section is making about the need to select hardware qubits in a smarter way.  The text might need to change a bit to reflect the different figure.  Do you want/need me to make those changes?

Thanks @kaelynj and @abbycross !

I used the same image for these two examples since they prepare the same example state. Though I see the point about having the same image twice. In the first part where it talks about the routing stage it might be better to instead add in a graph image of the hardware qubits that were assigned after the trivial_layout method was selected using plot_circuit_layout() from the qiskit.visualization module.

If it's not a mistake, it's fine with me.  I just wanted to make sure :)


Material You design

Not sure if that's possible/feasible but would be nice if the design is "Material You" like the Cashew app for instance.

I made a function that allows users to select a color theme from Red, Green, Blue and some other colors in a pre-set list. Next step I want to allow user to select color theme from a Color Palette.
As for Cashew, I tried it. It's a really beautiful app. I will have a try to make Fridgey as beautiful as it. I will take some time cause I am not very good at color and design ; )


DOC: add better example for MultinomialQMC.

Part of #16531
Rewrites the example to remove the warning and better explain how to use and what it does.
Bellow is the figure produced by the example:

LGTM thanks @tupui


Find an indexing library

One option is Apache Lucene but we need to search more.

I believe the best solution for now is to use ElasticSearch, which is a wrapper around Lucene that exposes a RESTful API which makes things much easier for us. I went ahead and created a new VPS for that purpose.


Close Survey && Slash Logo

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


BART as shared library?

For the project I'm currently working on, I've written a Java wrapper that runs smoothly on Windows accessing functions via native calls from a DLL compiled from BART.
My question is rather strategical in nature: Are you interested in incorporating the C part of the Java wrapper into this repo (it would mean a C header and a source file plus a couple of extra lines in the makefile) or is it better to keep it separately? Also, are there any plans to make BART accessible as a shared library?
@uecker mentioned in #253 that some people are working on a new Python integration. Can I ask what kind of approach they are following? Is it a "shared library"-based approach or the current "system call"-based approach remains? I'm asking this because the "shared library" solution looks cleaner for me from the user's perspective, especially if the Java/Python/Julia wrapper would be published to the central package repositories of these languages with precompiled binaries... And the same approach I use in the Java wrapper would be analogously applicable for a Python or a Julia wrapper.
For instance, I prefer to prototyping in Julia on my Linux machine or a Linux server, but later I need to develop on Windows + Java. Keeping the BART version consistent on all machines and systems tends to be cumbersome in the long run with the current solution.

This depends on whether we would be able to maintain this or not. Previously we had to remove similar thing because they broke and nobody fixed it. But if  it comes with a simple test that can be run on Linux automatically with standard dependencies, then I think we can try.
Compiling BART as a shared library is simple on Linux, should we add a Makefile target?
UCB is working on languages wrappers using SWIG.

I fully understand that maintainability is the most important question in this topic. I've written simple tests for my Java wrapper, and only Maven needs to be installed along with Java to download the required java packages and then compile and run the tests. Do Java and Maven count as standard dependencies?
I'll check out how easy it is to rewrite the wrapper with SWIG. I think it would complicate a bit the code, but it might improve the maintainability and it would definitely open up the way to Python and other languages, so it's definitely worth trying.

Compiling BART as a shared library is simple on Linux, should we add a Makefile target?

Yes, it would significantly simplify the compilation process.

Hi @hakkelt, I've been working for a little while on Python wrappers. I've been working on wrappers using SWIG (for internal functions) and a syscall-based approach (for exposing command-line tools to a Python interface). I'll update my repo at github.com/malits/bart-swig shortly with current code but would be happy to sync up with you and discuss code similarities and further directions.

Hi @malits, your wrapper looks really nice! It would be really interesting to combine your SWIG wrapper with the shared library approach. In fact, I wished to implement something like this when I started my Java wrapper, but so far I didn't have enough time to create a proper interface to the internal functions. So I would be glad to discuss the ways we can join our forces to create nice wrappers.

I added the Makefile target shared-lib for building shared libraries last year. If you need something else, please let us know.


Special characters (ä, ö etc.) detected incorrectly as two characters.

ncurses getch is called twice when pressing a multi byte character. Example: pressing ä results in Ã¤.

Fixed by using curses window method get_wch instead of getch. Required refactoring keyboard shortcuts etc.


possible imcompatibility with mystcraft

hello
i try your mod with only latest mystcraft and buildcraft
after a few minute i got massive lag and all my attribued memory was used (try to switch with more ram with same result(memory leak ?))
game is really unplayable after 3 or4 minutes
thanks in advance

hello
after a full re-install of minecraft and java it's run fine
sorry


Screenshots are saved flipped. o.O

Describe the bug
Screenshots are flipped on their horizontal axis, making them completely upside-down. Granted, I can flip these back in IrfanView or something, but... yeah, not ideal.
To Reproduce
Play game, hit F12 to take a screenshot.
Expected behavior
Screenshots should be saved right-side up?
Screenshots
Screenshots in PNG for space reasons, but this is how they end up in their original BMPs

Environment and game (please complete the following information):

Game version: beta 3
Operating System: Windows
CPU model: AMD Ryzen 5 PRO 3400G
GPU model: Radeon Vega Graphics

Screenshots is a dev feature of PsyCross, will update it later to save in Jpeg and unflipped.


SE-6932 SAP SNC Connection

Hi @dhirsch1 ,
I discussed with @VaneMolina and apart the above comment the documentation it is fine


Inline templates/error reporting doesn't work

I have an Angular project which our company uses VSCode for.
Just experimenting with Sublime Text seeing if it will work happily for our project, and I get pretty much nowhere. I have installed the LSP for typescript and angular, and yet type awareness doesn't activate for inline templates, nor do any errors display if I remove a declaration from my app module (which would make a specific template tag invalid somewhere else in the project)
Please provide some basic setup instructions, as so far this has been a frustrating experience and subpar to VSCode which works pretty much out of the box with its angular language server plugin.

nor do any errors display if I remove a declaration from my app module

Can you try installing this LSP file watcher and see if that fixes the errors not being displayed ? https://packagecontrol.io/packages/LSP-file-watcher-chokidar

I am getting typescript errors for an unused declarations, but no angular errors. Also still trying to figure out how to use my project's tsconfig.json...

I took a look at this.

I have installed the LSP for typescript and angular, and yet type awareness doesn't activate for inline templates

Does this work in VS Code?
I tied vs code, and I it looks like VS Code extension also does not support inlay template type.
Could you create a mini repository to reproduce the issue and specify the current behavior and your expected behavior.
I would love to help you solve this issue,
but unfortunately cannot dedicate more free time for this, so a if you leave this info above, it would be helpful.

I will get onto a minimal angular project testing with this soon

Please provide a simple project that reproduces this issue.

Hello,
I have the same problem with all my apps. I just created a new angular project (v16.0.5) and it also does not work, see attached screenshot below

However LSP-Angular works fine in plain HTML files:

Remark: I do not have this problem with VS Code (both inline templates and HTML files)

@pierresh what is the syntax that you’re using for these Angular Component files?

@pierresh what is the syntax that you’re using for these Angular Component files?

The syntax used by Sublime Text for these Angular Component files is Typescript
I have installed ngx-html-syntax in ~/Library/Application\ Support/Sublime\ Text/Packages,  if I use it, the HTML is rendered fine but all the typescript code around is displayed white.


read message body into Event type

Changes

Unmarshal received message into Event type
in web API, before we publish a message to the queue, pass it to the compliance.Protect as the consumer expects it to be protected.

Why Are Changes Being Made
ach-orchestrator publishes messages (encrypted, etc.) of the Event type.  When achgateway consumes the message from the queue, it should unmarshal it into Event type, not into ACHFile.

@adamdecaf
I’m not sure about my change in web/api_files and specifically about calling compliance.Protect but that was the easiest way. Other options:

change API of the endpoint to accept Event { "event": {…} }
add some kind of a flag into message (meta, etc.) so we can know into which type we can unmarshal the message and if we need to Reveal the data

Codecov Report

Merging #41 (e6011e5) into master (d56e3b9) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   37.14%   37.16%   +0.02%
==========================================
  Files          78       78
  Lines        2980     2981       +1
==========================================
+ Hits         1107     1108       +1
  Misses       1626     1626
  Partials      247      247

Impacted Files
Coverage Δ

internal/pipeline/file_receiver.go
0.00% <0.00%> (ø)

internal/incoming/web/api_files.go
72.88% <81.81%> (+0.46%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56e3b9...e6011e5. Read the comment docs.


alias ugly urls

This PR makes some minor changes to the rendered URLs for the notebooks in the README.md.

@dkillick Tweaked a change to fix the travis-ci :wink:

@bjlittle I'm just not sure I like the headings-as-links approach you've proposed here - I think it makes the readme less clear. My preference would be for a sentence under each heading after the description of each course that reads "View the course notebook." Happy to discuss that further though!

@dkillick I think this is now good to go.

think this is now good to go

... almost

🎉

@dkillick Hoo-rah! Thanks!


some bug fixes?

I've been working on a cloned version of jarbundler-3.3.0. I had thought of publishing it myself, but are you interested in a pull request? Small things so far (getting rid of deprecation warnings; JVMVersion also in Oracle plist; parsing modern version numbers (e.g. "9+") in setJVMVersion).
If you are interested, I'll send a pull request. If not, I'll keep it to myself. :-)

cc @sreynal
Dear @RBornat, I would really appreciate if you published the fixes. I am maintaining jPicEdt, and I am trying to make a MACOS bundle for it with JarBundler, and when I do this the bundle requires old 1.6 java run time, while jPicEdt can run on more recent runtimes.

@RBornat I agree with @vincentb1 . Could you please create a PR so we can publish it?

Will do.
Richard
Sent from my iPhone

On 3 Dec 2020, at 15:43, Matthias<EMAIL_ADDRESS>wrote:

@RBornat I agree with @vincentb1 . Could you please create a PR so we can publish it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I'm afraid you are going to hold my hand on this. I have never made a pull request.
What I have is:

a cloned copy of JarBundler repo from github

a modified copy of that repo, inside the RBornat/jape repository in the distrib/MacOSX folder (pushed to github)

a modified copy of ultramixer's universaljavaapplicationstub, also inside the RBornat/jape repo, pushed to github

2 and 3 together work in modern MacOSs -- High Sierra onwards for sure, and they even seem to work in Big Sur (3 removes a lot of hoo-hah about sorting the various java machinery, because it didn't work and java_home does it better; it ignores stuff about maximum version of java).
So: what do I have to do to make a pull request? Should I make a fork in my local jarbundler repo and start from that? The info I can see seems to be what to do if there's a fork in ultramixer's repo.
You can see that I'm confused.
Richard

On 3 Dec 2020, at 15:43, Matthias<EMAIL_ADDRESS>wrote:
@RBornat https://github.com/RBornat I agree with @vincentb1 https://github.com/vincentb1 . Could you please create a PR so we can publish it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/UltraMixer/JarBundler/issues/16#issuecomment-738088564, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANYREGCRA53IGSUCMSVNVLSS6W27ANCNFSM4TY62IDA.

@RBornat  sure, please provide a pullrequest to discuss here.

This link explains how to create a Pull Request on GitHub :
https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request
Le lun. 8 févr. 2021 à 11:19, Matthias<EMAIL_ADDRESS>a écrit :

@RBornat https://github.com/RBornat sure, please provide a pullrequest
to discuss here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/UltraMixer/JarBundler/issues/16#issuecomment-775035868,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGFEI33TRQN57HCWDJ7U3TS563CRANCNFSM4TY62IDA
.

This has been fixed with latest development on master.


Broken Financial Track Test

https://projectcrucible.org/servers/5543e1e16d6d319467000000#58786cec637275591f0c0000/connectathonfinancialtracktest/C9F_1A

NoMethodError: undefined method `preauth_claim' for #<Crucible::Generator::Resources:0x007fc8ceae82f8>
/Users/jwalonoski/git/plan_executor/lib/tests/suites/connectathon_financial_track.rb:31:in `setup'
/Users/jwalonoski/git/plan_executor/lib/tests/base_test.rb:53:in `execute_test_methods'
/Users/jwalonoski/git/plan_executor/lib/tests/base_test.rb:43:in `execute'
/Users/jwalonoski/git/plan_executor/lib/executor.rb:13:in `execute'
lib/tasks/tasks.rake:138:in `execute_test'


Illuminance rolling value

Hello,
Is there an Chance for Illuminance Value to get an rolling value, like 2 or 3 Value or 1 or 2 minutes of values?
Because my value get some sudden Change of value and my light is going off an on again...
Like these picture

The time is good for value with different times of value per Minute. On the other hand is just the last 2 or 3 Value also a good alternative.
Thanks a lot.

Currently this is not supported. Aggregate sensors only do a mean/sum of current value of all sensors and does not keep track of previous values. You'd need to use statistics sensor for that then aggregate on those sensors.


SerializedObjectNotCreatableException after domain reload

After Apply SaintsEditor, each time modify come code, after domain reload, SerializedObjectNotCreatableException is logged as below:
SerializedObjectNotCreatableException: Object at index 0 is null
UnityEditor.Editor.CreateSerializedObject () (at /Users/bokken/build/output/unity/unity/Editor/Mono/Inspector/Editor.cs:698)
UnityEditor.Editor.GetSerializedObjectInternal () (at /Users/bokken/build/output/unity/unity/Editor/Mono/Inspector/Editor.cs:670)
UnityEditor.Editor.get_serializedObject () (at /Users/bokken/build/output/unity/unity/Editor/Mono/Inspector/Editor.cs:564)
SaintsField.Editor.SaintsEditor.OnEnable () (at ./Library/PackageCache/today.comes.saintsfield@4d69fe59bd/Editor/SaintsEditor.cs:129)
It seems something buggy inside SaintsEditor.OnEnable().

Hi, thanks for reporting.
I did notice this kind of unexpected behavior sometimes, but it's kinda unstable to re-produce.
I tried:

Unity: 2022.2.0f
SaintsField 2.3.4
Enable SaintsEditor using Window - Saints menu

Attach this to an empty object in an empty scene:
public class Anything: MonoBehaviour
{
    [PropRange(0, 10)]
    [PlayaDisableIf]
    public int value3;

    [PlayaDisableIf] public string value4;

    public void Start()
    {
        Debug.Log("Hello Again!");
    }
}

Wait for Unity to compile.
Then modify the function and back to unity, no error gives. modify the field, no errors either. (Tested on IMGUI & UI Toolkit)

Sadly, somehow I can not re-produce it even I've seen it before (((
Appreciated if you can provide a guide of how to re-produce it, with the information:

Unity Version: Your version here
SaintsField Version: Find it in Window-Package Manager
Did you use IMGUI or UI Toolkit? A quick way to find out is using

[FieldType(typeof(SpriteRenderer))]
public GameObject sr;

IMGUI looks like (two selector buttons at the end):

UI Toolkit looks like (one selector button at the end):

And if possible, a code fragment and a way to re-produce it:
// Your code

Thanks in advance!

Hi @hailin-lee , this BUG might get fixed in 2.3.5. Without more information I can not identify which cause this problem, so please have a try in new version.

Closed due to lack of activity.


Is the game legal or not??

Hello,
Did you guys copied assets (Things: Zombie or world pictures-> Images.) from minecraft into your game?
Is your game legal or not
Thx.
For more better info for your website. Put this
"This game not copied from minecraft!, The game Assets are made by us)

So this is a somewhat odd question to ask nearly thirteen years since we began the project, I think - no offense intended :-)
In the very very beginning a few textures was used from a Minecraft texture pack, released under a permissive enough license for us to use it (open source / creative commons type stuff). And obviously Terasology was inspired by Minecraft, among other things. It isn't impossible that a stray old texture might have originated from elsewhere and been copied around, and certainly it is an objective (although a low priority one) to further distinguish Terasology further away from how Minecraft does things, i.e. the floating hand in the one corner.
The game is entirely legal and there is no need for additional disclaimers.
Frankly, the license you mentioned is (nothing).
If you are wondering why? Developers need a license from Mojang for the textures I mentioned
Who made those pictures? It's Mojang.
Images copied from Minecraft without a license from Mojang are (theft), and for use it is against the right to use.
If you say: This is just a game, my friend, no matter how stolen or legal it is, we do not care.
My friend, you do not know the penalty for using stolen materials.
Don't think I'm talking about cops

So this is a somewhat odd question to ask nearly thirteen years since we began the project, I think - no offense intended :-)
In the very very beginning a few textures was used from a Minecraft texture pack, released under a permissive enough license for us to use it (open source / creative commons type stuff). And obviously Terasology was inspired by Minecraft, among other things. It isn't impossible that a stray old texture might have originated from elsewhere and been copied around, and certainly it is an objective (although a low priority one) to further distinguish Terasology further away from how Minecraft does things, i.e. the floating hand in the one corner.
The game is entirely legal and there is no need for additional disclaimers. There are mentions here and there about the background if you go looking, various license files, attribution, etc 👍

If you want to help me, ask the developers to answer my question. only an answer from developers

Hello,
I trust what you said but honestly I have no right to play your game because every developer didn't answer the question, there are 99 graphics developers you don't know all of them and you don't know where they got the assets from or who made them.
I don't care about music because I'll always mute it, but the world of pictures and other things,
This game is illegal because there is no source about the assets.
Now you will enjoy playing this game and not worry about stealing, and later you will cry because you knew that your hands will be cut off for play illegal.
I will play any game instead of this game.
Thanks, Bye.

Based on Minecrafts EULA and Usage Guidelines people are freely allowed to use textures from Minecraft to support their own original works so long as the content doesn't violate the Minecraft EULA or TOS.
Terasology doesn't violate any of those as the stupilations or on ensuring you do not promote anything illegal and do not incite violence or hatred on others. Along with a few other things we do not do. As this is not for commercial use their rules and regulations on what we can use is also much more lax as this is a non-profit open source game. If we were to sell Terasology we'd be a lot more restricted but even still we would be entirely in the clear with the current state of the game and anything we might have taken from Mojan or Minecraft.
We also have the safety net of this being all protected under fair use anyway as we work closely with google for their "Google Summer of Code" event, which means we have a case for being a learning environment, doubly so that we are again, non profit.
Thank you for your concern, it is appreciated but at our current standings we are not violating any copyright law nor are we infringing on the rights of Mojan or Microsoft.
https://www.minecraft.net/en-us/usage-guidelines Usage guildelines founds here.


Remove smoke test for randomBytesTest as we have unit tests for this

For #5080

Codecov Report

Merging #5308 (51807e5) into main (c35f22b) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #5308   +/-   ##
=====================================
  Coverage     73%     73%
=====================================
  Files        401     401
  Lines      26550   26549    -1
  Branches    3877    3877
=====================================
+ Hits       19452   19454    +2
  Misses      5485    5485
+ Partials    1613    1610    -3

Impacted Files
Coverage Δ

src/client/common/process/pythonDaemonPool.ts
75% <0%> (-5%)
:arrow_down:

...datascience/notebookStorage/nativeEditorStorage.ts
80% <0%> (-1%)
:arrow_down:

src/client/datascience/baseJupyterSession.ts
75% <0%> (-1%)
:arrow_down:

src/client/datascience/jupyter/jupyterNotebook.ts
75% <0%> (-1%)
:arrow_down:

...lient/datascience/jupyter/kernels/cellExecution.ts
71% <0%> (-1%)
:arrow_down:

...active-common/intellisense/intellisenseProvider.ts
74% <0%> (-1%)
:arrow_down:

src/client/datascience/commands/commandRegistry.ts
39% <0%> (ø)

...ient/datascience/editor-integration/codewatcher.ts
69% <0%> (+<1%)
:arrow_up:

src/client/datascience/jupyter/kernels/kernel.ts
81% <0%> (+<1%)
:arrow_up:

...tascience/jupyter/liveshare/hostJupyterNotebook.ts
45% <0%> (+1%)
:arrow_up:

... and 3 more


ex_doc: 0.34.1 -> 0.35.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for ex_doc is: ExDoc produces HTML and EPUB documentation for Elixir projects
meta.homepage for ex_doc is: https://github.com/elixir-lang/ex_doc
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.34.2 in filename of file in /nix/store/l8fzp0idhwn43p8l6j3q4k4s50wwwp13-ex_doc-0.34.2

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

erlang_27
ex_doc
next-ls

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/l8fzp0idhwn43p8l6j3q4k4s50wwwp13-ex_doc-0.34.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ex_doc https://github.com/r-ryantm/nixpkgs/archive/4d4cd87d5b16abea59811846eba692b04e230c53.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/4d4cd87d5b16abea59811846eba692b04e230c53#ex_doc

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/l8fzp0idhwn43p8l6j3q4k4s50wwwp13-ex_doc-0.34.2
ls -la /nix/store/l8fzp0idhwn43p8l6j3q4k4s50wwwp13-ex_doc-0.34.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

erlang_27
ex_doc
next-ls

Maintainer pings
cc @chiroptical for testing.

I am unsure if I can blacklist this package from the update tooling?

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for ex_doc is: ExDoc produces HTML and EPUB documentation for Elixir projects
meta.homepage for ex_doc is: https://github.com/elixir-lang/ex_doc
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.35.1 in filename of file in /nix/store/g377ldrbrm3f0s28jiiivfhkg78mr9rf-ex_doc-0.35.1

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath

erlang_27
ex_doc
gleam
next-ls

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/g377ldrbrm3f0s28jiiivfhkg78mr9rf-ex_doc-0.35.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ex_doc https://github.com/r-ryantm/nixpkgs/archive/b3d897a14910747dfa9d633140348895dbf72bf4.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b3d897a14910747dfa9d633140348895dbf72bf4#ex_doc

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/g377ldrbrm3f0s28jiiivfhkg78mr9rf-ex_doc-0.35.1
ls -la /nix/store/g377ldrbrm3f0s28jiiivfhkg78mr9rf-ex_doc-0.35.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 4 packages built:

erlang_27
ex_doc
gleam
next-ls

Maintainer pings
cc @chiroptical for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

OTP 27.2 is still using 34.1, https://github.com/erlang/otp/blob/OTP-27.2/make/ex_doc_vsn

I am unsure if I can blacklist this package from the update tooling?

We can probably stop the bot from updating by removing this line.
https://github.com/NixOS/nixpkgs/blob/d70bd19e0a38ad4790d3913bf08fcbfc9eeca507/pkgs/development/beam-modules/ex_doc/default.nix#L54


[Bug] Fixing bug where events didn't respect a canceled event

If you added a before_ action, the dumpCollectionActions didn't respect the result and would still remove buttons if an event was canceled.

Hello,
Sorry for the delay, I work on other projects and have hard time to scale with my opensource ones.
I am scheduling some time to have a look at your contribution within a few days.
Have a good day


Path does not exist?

When I opened Bloxstrap it gave me this error

It popped out after the "Starting Roblox..." loading bar thing
When I opened it from the shortcut folder (C:\Users\river\AppData\Local\Bloxstrap)
It gave me this error:

I think its looking for the "Modifications/content" folder from %localappdata%/Bloxstrap/

Mods I currently have is the old oof death sound and a custom font (.otf)

which channel are you using currently

which channel are you using currently

I'm using ZIntegration

Got it working now, I switch to ZCanary. Thank you!

jsyk i removed the channel selector dropdown because of people like you

Got it working now, I switched to ZCanary. Thank you!

y not use the live channel


New-BcContainerBcUser returns 'The Aggregate Permission Set does not exist.' on BC20

Describe the issue
I am trying to generate users with special permission sets. It works like a charm for a BC19 container, but fails with a BC20 made in similar conditions.
New-BcContainerBcUser -containerName $containerName -credential $credential4 -PermissionSetId 'D365 TEAM MEMBER' -ChangePasswordAtNextLogOn $false
Note: I am NOT using a container set with newDatabase, and the permission set does exist in the Business Central UI and can be set manually.
The output being
`Creating User teammember
Assigning Permission Set D365 TEAM MEMBER to teammember
The Aggregate Permission Set does not exist. Identification fields and values: Scope='System',App ID='{00000000-0000-0000-0000-000000000000}',Role ID='D365 TEAM MEMBER'
at , : line 54
at Invoke-ScriptInBcContainer, C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\2.0.10\ContainerHandling\Invoke-ScriptInNavContainer.ps1: line 44
at New-BcContainerBcUser, C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\2.0.10\UserHandling\New-NavContainerNavUser.ps1: line 52
at , C:\Users****\Untitled1.ps1: line 9
The Aggregate Permission Set does not exist. Identification fields and values: Scope='System',App ID='{00000000-0000-0000-0000-000000000000}',Role ID='D365 TEAM MEMBER'
At C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\2.0.10\ContainerHandling\Invoke-ScriptInNavContainer.ps1:45 char:13

        throw $_.Exception.Message

        ~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OperationStopped: (The Aggregate P...65 TEAM MEMBER':String) [], RuntimeException
FullyQualifiedErrorId : The Aggregate Permission Set does not exist. Identification fields and values: Scope='System',App ID='{00000000-0000-0000-0000-000000000000}',Role ID='D365 TEAM MEMBER'`

How could I fix this?

I can definitely repro this, also when connecting to the container and using the cmdlet:

Have emailed the team behind this with a question on what to do

I learned that from 20.x, appName and appPublisher is required parameters to New-NavServerUserPermissionSet.
I will add those to containerhelper and default to Base Application and Microsoft.

NextMajor also verified that this fix works.


crazy syntax coloring

In the process of editing, I got a text from which the syntax highlighting goes crazy.
country.txt

everything returns to normal after deleting the LIBERIA line.

Isn't this because the keys are written like LR" instead of LR  (note the extra quote?) Not sure if this is supposed to be json, but in that case, that would make it invalid.


Fix #16: lock katex version at 0.7.1

Later versions break the gitbook build, most likely because katex has started using ES6.

Closing in favour of #18, I had a problem with my local repo when I created this so I had to delete it.


App wont open

The app was working fine till pre release 4, the app won't open like whenever I open the app, it immediately closes afterwards even in pre release 5. My phone model is Huawei Nova 7 SE if ever you need to know my device model.

I suspect its due to the local webserver but I can't be sure without logcat traces. I've made some changes to the app startup as well as added crashlytics to hopefully get some better diagnosis for crashes.
Can you try out the latest version?
https://github.com/Leapward-Koex/SubsPleaseApp/releases/tag/v0.5.1a

After getting access to a Huawei device I'm pretty confident the crahses are due to a lack of Google Play services. I'm made changes to handle phones without Play services and confirmed they work on the devices I have access to. Changes are in this release.
https://github.com/Leapward-Koex/SubsPleaseApp/releases/tag/v0.5.2a


Map in geometry PB is overlapping toolbar buttons

Issue

Expected behavior
The map shouldn't appear on top of the buttons

Tested and confirming that this now is looking good. @katrinDY when you have the time just try to add the CL entry.

CL
Fixed
What: The map in the geometry page block was overlapping the toolbar buttons
How: The z-indx of the toolbar element was increased so the buttons appear in top of the map and not the other way around
Ref:

23.3 ed097b6

Added CL


register standard interface types while creating encoding config

Description
register all standard types while creating an encoding config.
closes: #XXXX

Codecov Report

Merging #148 (776d982) into master (accbe90) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   32.01%   32.04%   +0.02%
==========================================
  Files          13       13
  Lines        2271     2272       +1
==========================================
+ Hits          727      728       +1
  Misses       1493     1493
  Partials       51       51

Impacted Files
Coverage Δ

x/payment/types/codec.go
91.89% <100.00%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3192328...776d982. Read the comment docs.

this was included in #149 so we can close this


[Bug]: Regenerate SSH key error comes up intermittently in git connected app on ME DP

Is there an existing issue for this?

[X] I have searched the existing issues

Description
For git connected app, when we perform various git operations like commit, discard and merge and switching envs, sometimes following error comes up in dp:

Steps To Reproduce

Connect an app to git
Perform git operations and switch between envs
Observe ssh key error is thrown

Public Sample App
No response
Environment
Deploy Preview
Issue video log
No response
Version
Deploy preview

@Parthvi12 is this still applicable? I am not able to reproduce this issue.

Closing as not reproducible


Implement tidyxl for Excel files

Brief Description

I would like to propose an implementation of tidyxl within Pyjanitor for non tabular data in Excel files.
The idea is to read in the Excel file, if it cannot be handled easily with Pandas because of the non tabular nature of the data; tidyxl](https://cran.r-project.org/web/packages/tidyxl/vignettes/tidyxl.html) in R represents each cell in its own row, where it describes the cell’s address, value and other properties. The data can then be wrangled with Pandas/Pyjanitor in a vectorized fashion.
There is a cookbook that shows the advantages of this approach. I feel it might be a way to ease wrangling Excel data in python, especially for non tabular data.

This looks like a neat idea, @samukweku!


Feature/manage backup bs dialog

#869499chm
#86949999y

Task linked: CU-86949999y Android. Cloud backup menu actions — Delete Cloud backup
Task linked: CU-869499chm Android. Cloud backup menu actions bottom sheet


Prune dependency features

See if there are any features of dependency crates that can be disabled

Moved async-std to dev-dependencies. Wasn't super easy to break apart any further because async-attributes doesn't seem to be usable directly.


Add MIT License

@avnermiz
Link: http://choosealicense.com/licenses/mit/#

@admiral96 did you check with travis if they expect the license to be in a certain file or something?

otherwise, if @avnermiz is fine, do merge

@mknecht Nope. Only on github. It said that I should put it on a file called LICENSE.md

alright, then let's wait for @avnermiz :)

alright, then let's wait for @avnermiz :)

+1


EF 7 Install Issues

I had so many issues installing EF7, I didn't know how to more specifically categorize them.
Here's my scenario (VS 2015):

Created ASP.Net 5 project using Windows Auth.
Added a Data project (Class library) to the solution
Attempted to NuGet EF 7 into Data project. Not found. Even when I checked "Prerelease". I was told on Twitter it was on myGet. But, it's in RC! Shouldn't the prerelease checkbox take care of that?
Used myGet to install. Got errors that it wasn't compatible with .Net 5.4 (5.4? that's strange)
Backed out Data project. Added a Data folder to web project.
Used myGet to install EF7 into web project.
Rebuilt. Error message: "Dependencies in project.json were modified. Please run dnu restore to generate a new lock file". 1) Why didn't the myget install update project.json? 2) I couldn't find any documentation on how to run dnu restore.

IMO, when the install doesn't work, I'm not sure I'm ready to take the plunge and use it. I have no idea what's lurking down inside.

@craigbern it's on NuGet (MyGet is just for our nightly builds). Where you trying to install the EntityFramework.MicrosoftSqlServer package, or a different provider?

@rowanmiller Hi Rowan. Nice to see you here. Searching for Entity Framework on NuGet didn't return acceptable results. I could get the current release version but when I checked "Prerelease" it didn't provide anything useful.

Hey,
This is mostly due to the pre-release nature of our product. Our package names have changed a few times etc. so you really need to be explicitly installing the pre-release package you want to use. Once we reach stable release, the package names will remain the same and increasing download counts will give them a better ranking in search results.

@rowanmiller Maybe lack of support for nuget tags in project.json makes the search sub-optimal?

I have installed / uninstalled numerous times and still get the error that "The EntityFramework package is not installed on project etc...'  This was working before and sometimes when I uninstall / reinstall it works.  Other times it totally crashes VS 2015 when I run the "Update-Database" command.  I am currently using v7.0.0-rc1-final.  Any idea why it cannot find the package? Is there a more reliable way of running these ps commands that won't crash my VS IDE?

Just as a followup to band-aid this problem I resorted to just creating a powershell script that ran the init.ps1 and install.ps1 and saved the script in my solution root directory.  Now when I have this problem in the Package Manager Console, I just type "ef7" the name of my script and it reruns those 2 powershell scripts and lets me work again.


Add "System" prefix to the Label in the Controller and the Test Class

Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

@davidhabib this PR is to fix the issue with the Build. I've added "System" prefix to the Labels in the Controller and Test Class.


[FIX] Add Spice library for Mac M1/arm64 architectures

Tickets addressed: None
Review: By commit
Merge strategy: Merge (no squash)

Description

After transitioning to a new M1 MBP, SpiceTests was failing. NAIF does not distribute a libJNISpice for M1 architectures. I re-compiled the library locally and updated the SpiceLoader to load the appropriate library according to the architecture detected.
Verification

The test now passes. If you have an M1 mac, please tell me if this works.
Documentation

I am not aware of documentation about Spice.
Future work

Ask NAIF to provide a proper distribution ?

I am not aware of documentation about Spice.

I'm not sure JNISpice is even an official product of NAIF, actually...

They mention it on https://naif.jpl.nasa.gov/naif/toolkit.html and provide several versions on https://naif.jpl.nasa.gov/pub/naif/misc/JNISpice_N0067/

Ah, interesting. Maybe it's a recent development -- I recall there was some consternation in the last couple years about JNISpice not being an officially supported product. Well, it's really good that that's being rectified :)

Closing this PR to be replaced by https://github.com/NASA-AMMOS/aerie/pull/271.


Suggestions: Prebuild & Exclusions

Two little suggestions that I'd love to see in Zappa.

Pre-build script. Basically allow you to add a python function to zappa_settings.json, which could get run before the deploy/update scripts.
Folder exclusions. Specify a folder that Zappa won't bundle up, so you can keep assets that shouldn't be uploaded in the same directory tree.

Both of these are great suggestions and wouldn't be terrible to implement.

Thanks for the comment Shakna!
Excludes are already in place, but it looks like it wasn't documented. Fixing that now - but you just add the patterns to exclude in "exclude": [".tar.gz", ".pem"] or whatever. Adding to README now..
Pre build script is a good one, I've wanted that as well. Can you describe your use case for that?

Okay, there is now support for a "prebuild_script" setting in the latest master.

@Miserlou Awesome. (For me, the prebuild was mostly minifying css, precompiling CoffeeScript and the like).

Ah, that makes total sense.
How are you serving up your static assets? YESTERDAY, API Gateway finally got the feature we need to serve binary data through it, but it's not a great practice and you should really use a CDN or something like that.

Whitenoise, but I only use it for text assets, like CSS and JS.

Oh wow, now that's really interesting! I've never seen that before.
Describing how to best handle static files is still an open and pressing matter for Zappa, so I'd love to know more about your setup!
If you don't mind, can you describe your setup in a bit more details? For example, are you using Django or Flask? Have you put Whitenoise on Lambda, or is that running on a dedicated machine somewhere?

Sure thing.
I'm using Flask for now, and wrapping it with Whitenoise before hitting it on Lambda.
So, the application that Zappa serves looks like:
import whitenoise
import routing

flaskApp = routing.app
app = whitenoise.WhiteNoise(flaskApp, root='/static')

I then have CloudFlare acting as a CDN around the site.
Since the only images I've used thus far are SVGs, and CSS shapes, I don't need to worry about binary formats and being served the wrong way.
That being said, Whitenoise should be enough to do it, if behind a CDN. So long as a user is using a CDN, then how they serve their files should be easy and simple, and fast.
That being said, I'm still getting used to Lambda, and haven't inspected to see if it obeys caching headers properly, or, like S3, completely fails to use gzip or the like.

That's fantastic, thanks for sharing! I look forward to experimenting with this myself.
WhiteNoise looks like it satisfies a number of requirements that I have, so once I try it out I hope to add it to the official Zappa documentation.
If you'd be so kind, I'd love it if you could see if it is obeying the caching headers like you say it should. If not, then perhaps there is something more that we could do to help with that.


"docker" deploy support of postgres 9.3.12

It looks like clair now only supports postgres 9.4+, right?
A couple of weeks ago I was able to use postgres 9.3.12 to server clair and see the db can be connected successfully. However, when I upgraded to the latest version of clair image with the same config file. I see an error in the container log saying:
2016-05-26 18:44:13.033496 C | main: pgsql: no database connection string specified
Is this because of the version conflict issue? or something wrong with my configuration.
in "/root/clair_config/config.yaml" I have postgres connection configured as following:
source: postgresql://postgres:password@postgres:5432?sslmode=disable

Also postgres server is running in my local host.
Any thoughts?

Could you check your configuration, since 1.2.2 the config has changed:
Have a look to the type and options tag:
clair:
  database:
    # Database driver
    type: pgsql
    options:
      # PostgreSQL Connection string
      # http://www.postgresql.org/docs/9.4/static/libpq-connect.html
      source: postgresql://postgres:root@postgres:5432?sslmode=disable

      # Number of elements kept in the cache
      # Values unlikely to change (e.g. namespaces) are cached in order to save prevent needless roundtrips to the database.
      cachesize: 16384

Hi,
The PostgreSQL backend for Clair uses Recursive Queries, which has been introduced in 8.4. The documentation states that Clair requires 9.4+, which is, I believe, a mistake. I never tried with an older version though.
If you are using Clair on master, the database configuration changed (e7b960c05b19d3bca0e1027071cacbbcf131c1a5). You have see the new example at https://github.com/coreos/clair/blob/a38fbf6/config.example.yaml. You probably want to use a release branch instead because the master branch is the development branch and breaking changes will occur.

I got the same issue with the quay.io/coreos/clair:latest

@jgsqware thanks for your confirmation.
@Quentin-M I strictly followed clair main doc under "docker" session of usecase.
Could you let me know which part/cmd I need to change to work this issue around?
Or I will need to build from source to resolve this issue?
thanks,

It looks like v1.2.2 has not been pushed into repo yet.
what will be the most convenient way of working this issue around through docker deployment?
docker pull quay.io/coreos/clair:v1.2.2
Pulling repository quay.io/coreos/clair
Tag v1.2.2 not found in repository quay.io/coreos/clair

I believe the documentation needs to be revised somewhat. but I manually changed my config file to be compatible to the one currently in master branch.


Custom policies and policy set definitions - optimal module location

I'm looking to implement custom policies and policy initiatives with ALZ-Bicep following best practice but am unsure how best to handle the policy module.
As we’re directly modifying the lib directory, should the entire policy module be copied to custom-modules to prevent issues around ALZ-Bicep update, or is there a more sensible approach to take, perhaps keeping the custom policy/policy set definitions within the config folder somehow?

Hi @danadamsituk, this appears to be a duplicate of #646 which I am working on and expecting to hopefully complete next month. I am planning on moving the policy module directory in its entirety to the custom-modules directory by default and then essentially updating the scripts and workflows/pipelines referenced within this documentation. That way you can extend the policies you need to modify on your end and get the latest policies from Enterprise-Scale repo which is what ALZ-Bicep syncs with. Still a work in progress though, so some of that may change somewhat.
Will go ahead and close this to have a single issue open. Please feel free to bring forth additional questions or offer any other insight on that thread.


Ghost install issue (sqlite3)

Greetings, I've tried to install from .zip file and while running in terminal npm install --production I get following response:
Node version 4.1.2
npm 2.14.4
Can you please suggest how to resolve this problem?
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":">= 0.8.0 <=0.12 || <=1.4.0"} (current: {"node":"4.1.2","npm":"2.14.4"})

><EMAIL_ADDRESS>install /Users/Illusion/ghost/node_modules/sqlite3
> node-pre-gyp install --fallback-to-build

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

  ACTION deps_sqlite3_gyp_action_before_build_target_unpack_sqlite_dep Release/obj/gen/sqlite-autoconf-3080900/sqlite3.c
  TOUCH Release/obj.target/deps/action_before_build.stamp
  CC(target) Release/obj.target/sqlite3/gen/sqlite-autoconf-3080900/sqlite3.o
Release/obj/gen/sqlite-autoconf-3080900/sqlite3.c:8954:26: warning: unused variable 'sqlite3one' [-Wunused-const-variable]
SQLITE_PRIVATE const int sqlite3one = 1;
                         ^
1 warning generated.
  LIBTOOL-STATIC Release/sqlite3.a
  CXX(target) Release/obj.target/node_sqlite3/src/database.o
In file included from ../src/database.cc:5:
In file included from ../src/database.h:11:
../node_modules/nan/nan.h:261:25: error: redefinition of '_NanEnsureLocal'
NAN_INLINE v8::Local<T> _NanEnsureLocal(v8::Local<T> val) {
                        ^
../node_modules/nan/nan.h:256:25: note: previous definition is here
NAN_INLINE v8::Local<T> _NanEnsureLocal(v8::Handle<T> val) {
                        ^
../node_modules/nan/nan.h:661:13: error: no member named 'smalloc' in namespace 'node'
    , node::smalloc::FreeCallback callback
      ~~~~~~^
../node_modules/nan/nan.h:672:12: error: no matching function for call to 'New'
    return node::Buffer::New(v8::Isolate::GetCurrent(), data, size);
           ^~~~~~~~~~~~~~~~~
/Users/Illusion/.node-gyp/4.1.2/include/node/node_buffer.h:31:40: note: candidate function not viable: no known conversion
      from 'uint32_t' (aka 'unsigned int') to 'enum encoding' for 3rd argument
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                       ^
/Users/Illusion/.node-gyp/4.1.2/include/node/node_buffer.h:43:40: note: candidate function not viable: 2nd argument
      ('const char *') would lose const qualifier
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                       ^
/Users/Illusion/.node-gyp/4.1.2/include/node/node_buffer.h:28:40: note: candidate function not viable: requires 2 arguments,
      but 3 were provided
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate, size_t length);
                                       ^
/Users/Illusion/.node-gyp/4.1.2/include/node/node_buffer.h:36:40: note: candidate function not viable: requires 5 arguments,
      but 3 were provided
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                       ^
In file included from ../src/database.cc:5:
In file included from ../src/database.h:11:
../node_modules/nan/nan.h:676:12: error: no viable conversion from 'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object>'
    return node::Buffer::New(v8::Isolate::GetCurrent(), size);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/Illusion/.node-gyp/4.1.2/include/node/v8.h:210:7: note: candidate constructor (the implicit copy constructor) not
      viable: no known conversion from 'v8::MaybeLocal<v8::Object>' to 'const v8::Local<v8::Object> &' for 1st argument
class Local {
      ^
/Users/Illusion/.node-gyp/4.1.2/include/node/v8.h:210:7: note: candidate constructor (the implicit move constructor) not
      viable: no known conversion from 'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object> &&' for 1st argument
class Local {
      ^
/Users/Illusion/.node-gyp/4.1.2/include/node/v8.h:214:13: note: candidate template ignored: could not match 'Local' against
      'MaybeLocal'
  V8_INLINE Local(Local<S> that)
            ^
/Users/Illusion/.node-gyp/4.1.2/include/node/v8.h:326:13: note: candidate template ignored: could not match 'S *' against
      'v8::MaybeLocal<v8::Object>'
  V8_INLINE Local(S* that)
            ^
In file included from ../src/database.cc:5:
In file included from ../src/database.h:11:
../node_modules/nan/nan.h:683:26: error: no member named 'Use' in namespace 'node::Buffer'
    return node::Buffer::Use(v8::Isolate::GetCurrent(), data, size);
           ~~~~~~~~~~~~~~^
../src/database.cc:145:9: warning: unused variable 'status' [-Wunused-variable]
    int status = uv_queue_work(uv_default_loop(),
        ^
../src/database.cc:230:9: warning: unused variable 'status' [-Wunused-variable]
    int status = uv_queue_work(uv_default_loop(),
        ^
../src/database.cc:509:9: warning: unused variable 'status' [-Wunused-variable]
    int status = uv_queue_work(uv_default_loop(),
        ^
../src/database.cc:610:9: warning: unused variable 'status' [-Wunused-variable]
    int status = uv_queue_work(uv_default_loop(),
        ^
In file included from ../src/database.cc:2:
In file included from /Users/Illusion/.node-gyp/4.1.2/include/node/node.h:42:
/Users/Illusion/.node-gyp/4.1.2/include/node/v8.h:221:5: error: assigning to 'v8::Primitive *volatile' from incompatible type
      'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/Illusion/.node-gyp/4.1.2/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:414:12: note: in instantiation of function template specialization
      'v8::Local<v8::Primitive>::Local<v8::Value>' requested here
    return NanEscapeScope(NanNew(v8::Undefined(v8::Isolate::GetCurrent())));
           ^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                             ^
In file included from ../src/database.cc:2:
In file included from /Users/Illusion/.node-gyp/4.1.2/include/node/node.h:42:
/Users/Illusion/.node-gyp/4.1.2/include/node/v8.h:221:5: error: assigning to 'v8::Boolean *volatile' from incompatible type
      'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/Illusion/.node-gyp/4.1.2/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:424:12: note: in instantiation of function template specialization
      'v8::Local<v8::Boolean>::Local<v8::Value>' requested here
    return NanEscapeScope(NanNew(v8::True(v8::Isolate::GetCurrent())));
           ^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                             ^
In file included from ../src/database.cc:2:
In file included from /Users/Illusion/.node-gyp/4.1.2/include/node/node.h:42:
/Users/Illusion/.node-gyp/4.1.2/include/node/v8.h:221:5: error: assigning to 'v8::Function *volatile' from incompatible type
      'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/Illusion/.node-gyp/4.1.2/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1514:12: note: in instantiation of function template specialization
      'v8::Local<v8::Function>::Local<v8::Value>' requested here
    return NanEscapeScope(NanNew(handle)->Get(kCallbackIndex)
           ^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                             ^
In file included from ../src/database.cc:2:
In file included from /Users/Illusion/.node-gyp/4.1.2/include/node/node.h:42:
/Users/Illusion/.node-gyp/4.1.2/include/node/v8.h:221:5: error: assigning to 'v8::Object *volatile' from incompatible type
      'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/Illusion/.node-gyp/4.1.2/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1632:12: note: in instantiation of function template specialization
      'v8::Local<v8::Object>::Local<v8::Value>' requested here
    return NanEscapeScope(handle->Get(NanNew(key)).As<v8::Object>());
           ^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                             ^
4 warnings and 9 errors generated.
make: *** [Release/obj.target/node_sqlite3/src/database.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 14.5.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/Users/Illusion/ghost/node_modules/sqlite3/lib/binding/node-v46-darwin-x64/node_sqlite3.node" "--module_name=node_sqlite3" "--module_path=/Users/Illusion/ghost/node_modules/sqlite3/lib/binding/node-v46-darwin-x64"
gyp ERR! cwd /Users/Illusion/ghost/node_modules/sqlite3
gyp ERR! node -v v4.1.2
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute '/usr/local/bin/node /usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/Users/Illusion/ghost/node_modules/sqlite3/lib/binding/node-v46-darwin-x64/node_sqlite3.node --module_name=node_sqlite3 --module_path=/Users/Illusion/ghost/node_modules/sqlite3/lib/binding/node-v46-darwin-x64' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/Users/Illusion/ghost/node_modules/sqlite3/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at emitTwo (events.js:87:13)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:818:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
node-pre-gyp ERR! System Darwin 14.5.0
node-pre-gyp ERR! command "/usr/local/bin/node" "/Users/Illusion/ghost/node_modules/sqlite3/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /Users/Illusion/ghost/node_modules/sqlite3
node-pre-gyp ERR! node -v v4.1.2
node-pre-gyp ERR! node-pre-gyp -v v0.6.7
node-pre-gyp ERR! not ok
Failed to execute '/usr/local/bin/node /usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/Users/Illusion/ghost/node_modules/sqlite3/lib/binding/node-v46-darwin-x64/node_sqlite3.node --module_name=node_sqlite3 --module_path=/Users/Illusion/ghost/node_modules/sqlite3/lib/binding/node-v46-darwin-x64' (1)
npm ERR! Darwin 14.5.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "--production"
npm ERR! node v4.1.2
npm ERR! npm  v2.14.4
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-pre-gyp install --fallback-to-build'.
npm ERR! This is most likely a problem with the sqlite3 package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build
npm ERR! You can get their info via:
npm ERR!     npm owner ls sqlite3
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/Illusion/ghost/npm-debug.log

Ghost does not support node v4, please use 0.10 or 0.12.

Thank you, Eris! :)


Add so a user can add multiple links at once

E.g. the user search for a product term like "3080" and then provide the url with that search to the program, and the program adds the 4 or x first products with that search to the program

Changing this to that the user provides the program with multiple categories and links and program can add all products


App Crash on library initialisation

App Crash on library initialisation
My App is crashed on initialisation of the library, and I'm getting these errors. I've completed all the configurations as described in Docs.
Screenshots

Minimal Reproducible
Link to minimal reproducible code. It would be much easier for us to investigate the issue!
Environment:

Health Connect Version: "^3.1.0"
React Native Version: "0.74.5"
New architecture enabled: Yes
Using Expo: Prebuild(Dev Client)
Android API Level: e.g API 34 (Android 14)

There have been some breaking changes in the v3.3.0:
https://github.com/matinzd/react-native-health-connect/releases/tag/v3.3.0
If that didn't help can you create a minimal reproducible and share it with me? Thanks

Closing this as I could not reproduce it and didn't get any answers.


Fetching Asset from read only account

Fetching Asset form read only accounts in Transfer builder fails. I wasn’t able to copy the error log because it automatically clears on Transfer builder tab closing.

Hi @cusma,
Just tried with a read-only account as "From Account". Yes it fails.
Reason - In "Transfer Builder" UI,  it currently needs "From Mnemonic" to derive "From Address". And as "From Mnemonic" is empty for read-only account, it fails.  As of now, the primary use-case for this UI is to transfer algo/asa and mnemonic is required for signing.
But I am assuming you are trying to just export the txn to json here.
If that's the case, I think we don't need Mnemonic for "Export Tx". so we can just rely on the "From Address" field instead of always trying to derive address from mnemonic for assets discovery.
I will fix this in the next release.
But if you are trying to just see the assets of an account , you can do so from the "Account Details" UI. Just right-click on the account row and select "Show Details".

Hi @satran004, that's correct: I was trying to ExportTx to be able to use it for the construction of a Group Transaction.
Thanks for the confirmation!


Twinny for Visual Studio Community 2022

Hi,
the concept of having a locally installed open source Copilot was very exciting for me, but I couldn't find Twinny extension for Visual Studio Community 2022.
As far as I understand, there is no possibility of using it on VS. Is it planned to offer this functionality?
Thanks in advance for your kind answer!

Hey, thanks for the question.
Unfortunately there are no plans to add the extension for Visual Studio Community 2022. AFAIK the implementation details are widely different and I do not own a copy of Windows which makes it impossible for me to develop it.
All the best and many thanks.


Allow constructor typescript

Fixes #131

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Use Xterm control sequence to hide/show the cursor

Instead of invoking setterm command to turn on/off cursor visibility, it's just better to use Xterm control sequences. Some very older terminals might not support this sequence but the majority of it does.

@rilysh - Thanks for the contribution!


chore(ci): deploy patch&minor at the right place

We had an incident where, for version v.X.Y.Z, we deployed /vX/, /vY/ and /vZ/ to our CDN instead of /vX/, /vX.Y/ and /vX.Y.Z/.
faeba9fecf72f55da2151fd7ec977e0e652ae8d0 fixes that, and b0a208d0d219561c3bb8d4c583d79daf6720cecd ensure deployment to a given environment can start only after manual approval.
We want the latter to verify our fix is working.
https://coveord.atlassian.net/browse/CDX-1535

[ ] @louis-bompart: unfreeze deployments after approval


Fixed #25549 -- Added auth_user_password_change urlreverse example.

Ticket

Sure, though I'll fix this tomorrow.
Thanks a ton! :smile:

merged in ad167502f36f2547718aee290d4d11bf7a26ff82, thanks!