Settings menu for custom model names

Feature Request
Summary:
Allow users to input custom model names in the model selection dropdown or within the settings when choosing which AI model to interact with.
Problem:
Certain proxies for OpenAI services have been experiencing issues where the /models endpoint might be malfunctioning or is not populating the model selection list as expected. This results in users being unable to select from the full range of available models, potentially limiting their access to specific or preferred AI models that are otherwise operational.
Proposed Solution:
Implement a feature within the chat interface that enables a user to add custom model names directly to the model selection dropdown. This could take the form of an input box within the dropdown itself, allowing for direct typing of the model name. Alternatively, a small section in the settings could be dedicated to managing custom model names where users could add or remove model names that they frequently use or wish to test.
Benefits:

Provides a workaround for when the model list is not automatically populated.
Offers flexibility to advanced users who are aware of model names that are not listed but are available for use.
Ensures continuity of user experience by enabling access to all models, regardless of potential temporary proxy endpoint issues.

@imesha10
Hi, I don't ever use custom proxies, but I'd be willing to accept a PR for this implemented as a settings menu for it like there is with Prompt Library (ideally with the ability to hide certain default ones in the dropdown.)
From a code standpoint, this will require refactoring away from the custom ModelChoice type, probably just to a standard string.

@imesha10 Hi, I don't ever use custom proxies, but I'd be willing to accept a PR for this implemented as a settings menu for it like there is with Prompt Library (ideally with the ability to hide certain default ones in the dropdown.)
From a code standpoint, this will require refactoring away from the custom ModelChoice type, probably just to a standard string.

Alright, I'll try to do a pr in the comming weeks. I have very little experiece with node and related but I will be able to figure it out.
Please close this issue when you see it and I will reopen a pull request once I'm done.
If I don't then assume that I failed.
Thanks!

I'll leave the issue open, since I think it is a good change. (I have alot of issues open that I'll never spend the time to implement but maybe someone else will take pity on me and help xD)
Please let me know if you need any help navigating the codebase, I know learning React can be pretty daunting for beginners.

btw, i'm working on this myself now, so no need to try. development is occurring on the 2.0.9 branch

btw, i'm working on this myself now, so no need to try. development is occurring on the 2.0.9 branch

Ok that's good. Thank you.

@jackschedel
Oh ya by the way if you didn't know. OpenAI default endpoint and most openai proxies gives a list of all the available models via the /v1/models endpoint.
So all you have to do is send a call to that and it will return a json object that you can then parse into the application.
This is how applications like SillyTavern and other ones work.

You can find more info in here https://platform.openai.com/docs/api-reference/models
If you want to see examples in a different language then press this drop box and choose:

I'm instead implementing the ability to do fully custom model names, so KoalaClient can be used with any endpoint.

I'm instead implementing the ability to do fully custom model names, so KoalaClient can be used with any endpoint.

Ya it's definitely a very useful feature to be able to enter custom model names so it can be used with any endpoint type and it basically will fix my problem of being unable to use certain models.
However I should mention that after looking at this project (KoalaClient) and using it for a while I have some thoughts.
I think you should definitely after this feature or some features down the line consider making it so that it auto populates the model list for the ones that has that feature.
I'm taking a blind guess but I'm guessing most of your users will be openai (85%) anthropic/claude(10%), and other(5%).
So if you implement this later you would be able to get most of your users all the models they have access to (all openai models from /v1/models). This makes it so that most of your users will not have to go into the api connection menu and manually input their specific models which will make the app feel simple and very easy to use.
Currently KoalaClient can't seem to fetch other openai models and it's limited to:

Here is a similar one where it auto fetches in SillyTavern via a proxy:

I just complied the latest version 3.0.9 and it does not seem to have the model "gpt-4-0125-preivew". So if you were to auto populate the list you would not have to constantly update it with the latest and the best models at least for openai.
Anyways these are just thoughts and I might be wrong or thinking in the wrong direction. Thanks for you time.

Thanks for your input. Btw, 3.0.9 is still in development, not in a working state yet.


az vm create under PowerShell won't permit empty public-ip-address

Description
Outline the issue here:
I first noticed this issue with my full az vm create command, and I progressively simplified it until it was basically just az vm create --resource-group TEST --name TEST-VNAS --public-ip-address "" and it still threw the error: az vm create: error: argument --public-ip-address: expected one argument. That's when I finally thought maybe this is just an issue with az under PowerShell. So I tried my original full command under a simple Command Prompt window, and it worked fine.

Environment summary
Install Method: How did you install the CLI? (e.g. pip, interactive script, apt-get, Docker, MSI, nightly)
Answer here: MSI on Windows 10 Pro
CLI Version: What version of the CLI and modules are installed? (Use az --version)
Answer here: 2.0.9  (same version under PowerShell and CMD)
OS Version: What OS and version are you using?
Answer here: Windows 10 Pro
Shell Type: What shell are you using? (e.g. bash, cmd.exe, Bash on Windows)
Answer here: PowerShell (throws error) and CMD (no issues)

Powershell is not a supported shell for Azure CLI 2.0. You might try using double single quotes instead of double quotes.... OR (this is a hacky workaround) you could try something like "''" (two singles wrapped in double) or '""' (two doubles wrapped in singles).

I guess MS has reasons for not supporting the cli under their own shell,
but oh well. One more reason to use my Linux box! :)
On Jun 29, 2017 11:33 AM, "Travis Prescott"<EMAIL_ADDRESS>wrote:

Closed #3917 https://github.com/Azure/azure-cli/issues/3917.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-cli/issues/3917#event-1144456336, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AY5HnXtVW3GZD0Q4jGRlFEQaD3iC0uy1ks5sI8PTgaJpZM4OJMvv
.

The main reason is because it is assumed that people using Powershell would be using the Powershell cmdlets for working with Azure rather than Azure CLI 2.0.

Ah, now that makes sense! I've just started exploring command line
interaction with Azure and didn't realize there was PS  commands for it
too.
On Jun 29, 2017 4:02 PM, "Travis Prescott"<EMAIL_ADDRESS>wrote:

The main reason is because it is assumed that people using Powershell
would be using the Powershell cmdlets for working with Azure rather than
Azure CLI 2.0.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-cli/issues/3917#issuecomment-312088173,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AY5HneU_-0c1T_pDINXkWe70EmopeEJ_ks5sJALZgaJpZM4OJMvv
.

https://github.com/Azure/azure-powershell
Enjoy (or use our product on your Linux box :grin:)


Mapping normalized images to real images

Hi tensorfuzz developers,
Thank you for making this tool public. I have a quick question about the quantization example. It seems that tensorfuzz works on a normalized image where each entry in the matrix is a fp value between [-1, 1].  So it appears to me that a mutated normalized image, despite having different prediction, could not map to a different image in original MNIST format where entries are integers.
I noticed that there's a piece of code that double check the validity of the mutated image. Is it related to this question?
I may miss something. Please let me know if it makes sense.

Hi, I'm not totally sure I understand your question, but I will try to answer and you can tell me if it was helpful:
In general the MNIST digits are integers in the range [0,255].
When you train vision models on them, generally you cast those ints to floats and normalize the floats to live in [-1,1].
If you find a disagreement on an particular input and that input uses more precision than
the original MNIST dataset has, then technically you will not then be able to map that input back to any original MNIST digit, but that's ok because:
a) that was never really the goal, we are concerned about the accuracy of the quantized model under unseen inputs, which may come with more precision
b) the precision may go away when you feed the input through a quantized model anyway, depending on the implementation
c) we already checked that no disagreements were found on the test set for our example model.
The check you found is for a different reason:
The classifier may give outputs that differ between the original and the quantized version simply due to stochasticity in e.g. the tensorflow matrix multiply implementation.
Thus, when we find a disagreement, we check that it persists across multiply tries of the same inference.

Thanks for your clarification. May I ask what precisely do you define
unseen inputs? Are they in original mnist format or normalized images? If
they were defined as the latter, will they be guaranteed to map back to
mnist format which are also unseen?
On Wed, Sep 19, 2018, 13:04 Augustus Odena<EMAIL_ADDRESS>wrote:

Hi, I'm not totally sure I understand your question, but I will try to
answer and you can tell me if it was helpful:
In general the MNIST digits are integers in the range [0,255].
When you train vision models on them, generally you cast those ints to
floats and normalize the floats to live in [-1,1].
If you find a disagreement on an particular input and that input uses more
precision than
the original MNIST dataset has, then technically you will not then be able
to map that input back to any original MNIST digit, but that's ok because:
a) that was never really the goal, we are concerned about the accuracy of
the quantized model under unseen inputs, which may come with more precision
b) the precision may go away when you feed the input through a quantized
model anyway, depending on the implementation
c) we already checked that no disagreements were found on the test set for
our example model.
The check you found is for a different reason:
The classifier may give outputs that differ between the original and the
quantized version simply due to stochasticity in e.g. the tensorflow matrix
multiply implementation.
Thus, when we find a disagreement, we check that it persists across
multiply tries of the same inference.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/brain-research/tensorfuzz/issues/3#issuecomment-422921775,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFnqX0JUapbaGrI-Ly1r-3cRjXFMX5tGks5ucpUmgaJpZM4Wuxqi
.


[23.11] nextcloud26: 26.0.12 -> 26.0.13, nextcloud27: 27.1.7 -> 27.1.8, nextcloud28: 28.0.3 -> 28.0.4

Description of changes
backport of https://github.com/NixOS/nixpkgs/pull/300126

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Had to remove the notify_push cherry-pick:
error: package `notify_push v0.1.0 (/build/source)` cannot be built because it requires rustc 1.74.0 or newer, while the currently active rustc version is 1.73.0


proxy support with vscode

Hi,
When I try to use ever new or any ever commands while I'm behind the corporate proxy I cannot use the extension.
I've already set http.proxy for vscode and it's working (I can install extensions).
Is there a way to force extension to use proxy?

Extension proxy has not been supported yet, you can only download the extension, but the request happened internally still can not work properly. See vscode #12588 for details.
I will keep an eye on this, thanks for your reply.


X icon removed when SuperPins is active

1.0.1-a.18
MacOS
The X icon disappears from the regular tab when Superpins is activated.

Same issue, I've discovered it happens when the option Makes pinned tabs look similar to Essentials (icon only in a grid) is enabled.

Same issue, MacOS too.

Same issue also present on the windows version too . It is triggered when enabling "Makes pinned tabs look similar to Essentials (icon only in a grid)"

Yeah, sry about that. Forgot to specify in the code so that the x button is only hidden from pinned tabs and not normal one, will fix asap

Thank you very much for the quick fix, Close buttons are back!


[Issue] azd env list w/o .azure folder throws error

Create a folder with an azure.yaml file in it.
Run azd env list
Expected: return zero env
Actual: Errors that .azure doesn't exist
PS D:\temp\yamltest> touch azure.yaml
PS D:\temp\yamltest> azd env list

ERROR: listing environments: listing entries: open D:\temp\yamltest\.azure: The system cannot find the file specified.

This was fixed in #2013


fix(ModelResponse): ensure proper Symbol.observable implementation

removes SymbolShim.js
adds dependency on symbol-observable.

SymbolShim had a few issues, was not tested, and was largely unused. This commit is also critical
to getting Falcor Router upgraded to RxJS 5
cc @jhusain

Coverage increased (+0.3%) to 91.888% when pulling e0f70475c7a91c2dfb6ecd13cc5677d8fe715c40 on blesh:fix-symbol-observable into 09d9b64c22372e88848b4eaae66e1ebf5b4562f0 on Netflix:master.


Some bug after reconnect 2

It seems to me that there is an mistake contained here. I'm reserching it now.
https://github.com/Visecy/Karuha/blob/master/karuha/event/bot.py#L31
After reconnecting, my custom on_rule method either doesn't work or is duplicated. Maybe you have an idea what's wrong?
Maybe here:

https://github.com/Visecy/Karuha/blob/master/karuha/bot.py#L1391
https://github.com/Visecy/Karuha/blob/master/karuha/bot.py#L1297

When the bot reconnects, all tasks related to the bot will be terminated. This does not affect the registered on_rule dispatcher. If you find related problems, please provide code that can reproduce the problem and debug-level logs.


Improve aggregate performance with adaptive sizing in accumulators / avoiding reallocations in accumulators

Is your feature request related to a problem or challenge?
Making aggregations fast in datafusion helps its adoption and makes it even cooler
As part of the new #6904  work, @yjshen  had an idea https://github.com/apache/arrow-datafusion/pull/6800#discussion_r1251142165 that could avoid a copy in the accumulator implementations:
Describe the solution you'd like
Adaptive sizing(perhaps?): How would the hash table header and states in each accumulator initialize and grow their sizes afterward?
Here is the structure of the current group operator
                                         ┌──────────────┐   ┌──────────────┐   ┌──────────────┐
                                         │┌────────────┐│   │┌────────────┐│   │┌────────────┐│
    ┌─────┐                              ││accumulator ││   ││accumulator ││   ││accumulator ││
    │  5  │                              ││     0      ││   ││     0      ││   ││     0      ││
    ├─────┤                              ││ ┌────────┐ ││   ││ ┌────────┐ ││   ││ ┌────────┐ ││
    │  9  │                              ││ │ state  │ ││   ││ │ state  │ ││   ││ │ state  │ ││
    ├─────┤                              ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
    │     │                              ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
    ├─────┤                              ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
    │  1  │                              ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
    ├─────┤                              ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
    │     │                              ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
    └─────┘                              ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
                                         ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
                                         ││ └────────┘ ││   ││ └────────┘ ││   ││ └────────┘ ││
                                         │└────────────┘│   │└────────────┘│   │└────────────┘│
    Hash Table                           └──────────────┘   └──────────────┘   └──────────────┘

                                          New NewAccumulator

stores "group indexes"                     There is one GroupsAccumulator per aggregate
which are indexes into                     (NOT PER GROUP). Internally, each
Vec<GroupState>                            GroupsAccumulator manages the state for
                                           multiple groups

The implementation of this, such as Average is to use a Vec<T>. While this approach is simple to implement, it also means that as the Vec grows, the accumulated vales may be copied (up to 2 times on average, given a doubling strategy)
An alternate, suggested by @yjshen  is to segment the state into fixed-sized vectors, allocate a new vector at a time, fill it until full, then create a new vector for upcoming new states.
                                         ┌──────────────┐   ┌──────────────┐   ┌──────────────┐
                                         │┌────────────┐│   │┌────────────┐│   │┌────────────┐│
    ┌─────┐                              ││accumulator ││   ││accumulator ││   ││accumulator ││
    │  5  │                              ││     AGG    ││   ││     SUM    ││   ││     0      ││
    ├─────┤                              ││ ┌────────┐ ││   ││ ┌────────┐ ││   ││ ┌────────┐ ││
    │  9  │                              ││ │ state- │ ││   ││ │ state- │ ││   ││ │ state  │ ││
    ├─────┤                              ││ │segment-│ ││   ││ │segment-│ ││   ││ │        │ ││
    │     │                              ││ │   1    │ ││   ││ │   1    │ ││   ││ │        │ ││
    ├─────┤                              ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
    │  1  │                              ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
    ├─────┤                              ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
    │     │                              ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
    └─────┘                              ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
                                         ││ │        │ ││   ││ │        │ ││   ││ │        │ ││
                                         ││ └────────┘ ││   ││ └────────┘ ││   ││ └────────┘ ││
                                         ││            ││   ││            ││   │└────────────┘│
    Hash Table                           ││ ┌────────┐ ││   ││ ┌────────┐ ││   └──────────────┘
                                         ││ │ state- │ ││   ││ │ state- │ ││
                                         ││ │segment-│ ││   ││ │segment-│ ││
                                         ││ │   2    │ ││   ││ │   2    │ ││
                                         ││ │        │ ││   ││ │        │ ││
                                         ││ │        │ ││   ││ │        │ ││
                                         ││ │        │ ││   ││ │        │ ││
                                         ││ │        │ ││   ││ │        │ ││
                                         ││ │        │ ││   ││ │        │ ││
                                         ││ │        │ ││   ││ │        │ ││
                                         ││ └────────┘ ││   ││ └────────┘ ││
                                         │└────────────┘│   │└────────────┘│
                                         └──────────────┘   └──────────────┘

Thru this segmented approach, we could avoid memory copy for each resize, which the number of resizing would be great for high cardinality aggs, and grows the size more predictably.
But admittedly, this approach would also bring complexity for both header pointer management and update span multiple vectors.
Describe alternatives you've considered
No response
Additional context
No response

It seems like deque in cpp ？

But what does adaptive mean in with adaptive sizing?

But what does adaptive mean in with adaptive sizing?

I think @yjshen  meant something like storing the values in  Vec<Vec<T>> rather than Vec<T>
And when more space was needed, create a new Vec::with_capacity rather than push to the existing Vec (which might reallocate and copy)

We (Coralogix) may want to tackle this but combine with ColumnStatistics::distinct_count to only allocate once.

Using statistics to improve the allocation performance certainly seems like a good idea -- though I am not sure the default distinct statistics are very reliable

take
Working on an poc, which is related to this.

take

Working on an poc for performance improvemetn which is related to this.


Async everything

Hi, is it possible to replace each sync operation on it async analogue? May be I have some weird use cases, but when I'm working over sshfs and have linter enabled each save hangs atom for about 2 seconds while linting is running.

@d4rkr00t the only sync functions used in the package are there to keep legacy support, they'll be removed soon, the new API is completely async. So You will just have to wait until your package's author migrates to the new API.

Also, you can disable lintOnFly from the settings to improve writing speeds. 'cause then the linters will only be triggered on save and not when you're editing the file.

Great, thanks. I have already disabled lintOnFly and lintOnFocus.

I didn't know there's a lintOnFocus option. Are you migration from the older version?
Sounds like https://github.com/AtomLinter/Linter/issues/578

Yes i've been using linter for about half of year now.

There seems to be a very noticeable slow down in linter since the latest update (1.0.0).

@muppetjones: @d4rkr00t is experiencing this lag due to SSHFS, a virtual SSH file system. Can you please elaborate where is it slow for you?

It's simply slowing down Atom in the editor. Text can take a second or more to show in the editor. It's not a memory issue as my system (OSX Yosemite) still shows free memory. If I close other windows and keep only a couple open at a time, this helps, but the biggest improvement is when I disable linter entirely. I am using linter-flake8, which could be the culprit.

@muppetjones I am not aware of any part of linter package that is so CPU or memory intensive, I haven't tried linter-flake8 yet, so Yeah maybe when linter-flake8 triggers the command line flake8, that slows down your Computer.

I switched to linter-pep8, and it's working fine, so it must be linter-flake8. Thanks for the quick responses and the recent updates!

Closing as not really a bug in this repo, will continue discussing though.


feat(create-frames): cloudflare custom images worker

Change Summary
This PR introduces new template for create-frames which implements custom image worker.
The reason why it is split to separate package is that cloudflare workers don't support multiple functions.
Also I removed tests from package since they are failing on wasm import and I couldn't find a solution.
Merge Checklist

[x] PR has a Changeset
[x] PR includes documentation if necessary
[x] PR updates the boilerplates if necessary

@michalkvasnicak perhaps we can just create a guide for this in the docs?


Update test workflow for macOS

Description of changes:
Update test workflow to use macOS-latest since macOS-10.14 is no longer supported.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

#77 should be fixing the build

Closing this issue since #77 includes the macOS environment update


[ENHANCEMENT] Highlighting Exact Matches

Is your feature request related to a problem? Please describe.
If you need to perform an exact match search on an index, Marqo doesn't support highlighting
Describe the solution you'd like
when we do text:("free") we should get something like  "Customers get free samples"
Describe alternatives you've considered
This should be an internal feature, a user could perform the highlighting on the returned result but that isn't optimal behaviour as it already exists in Vespa
Additional context
This seems to be supported in Vespa under bolding

Thanks Liam - this will be added in 2.6 with hybrid search. @pandu-k @farshidz can you confirm that we will support functionality that achieves this?

@tomhamer @LKing12 this will be part of a future release, but it may not be part of hybrid search (2.7) I'm afraid.


Missing EVs' CSVs in results

I did some runs over the holidays (with latest release) and came across another problem. With this scenario the resulting number of EVs is too small (see sums at right of table):

region_id
RegioStaR7
bev_mini
bev_medium
bev_luxury
phev_mini
phev_medium
phev_luxury
EXPECTED SUM
ACTUAL SUM

71
SR_Metro
1690
3844
1235
1047
2382
765
10963
1371

72
SR_Gross
1750
3676
1045
1084
2278
647
10480
10480

73
SR_Mitte
3548
7776
2421
2197
4818
1499
22259
8536

74
SR_Klein
880
1958
574
545
1213
355
5525
3290

75
LR_Zentr
816
1760
511
506
1090
317
5000
1173

76
LR_Mitte
2050
4625
1331
1269
2866
824
12965
6886

77
LR_Klein
2250
5230
1487
1394
3241
921
14523
980

Except for region 72 / SR_Gross the number of generated CSVs is too small (total: 32716 instead of 81715).
All EV types are affected
CSVs for PHEVs are only generated for the region which shows correct numbers (72 / SR_Gross)
I ran again with 1 week (2011-01-01 to 2011-01-07) with similar results:

now I get slightly more: 33271 EVs
here, the number of EVs is correct for 74 and 76 (and like before PHEVs are created for those 2 regions with correct EV numbers)

I observed a similar behaviour for the default_RS7 scenario (total: 38251 instead of ~140k). Here, none of the regions show correct number of CSVs and there're no PHEVs at all.

This seems to be a general problem.
Any ideas, @timroepcke @Mosc5? Could this behaviour be related to the sampling?

Update:

I ran all regions with 100 EVs per type an get 4200 CSVs as expected
I ran all regions with 500 EVs per type an get 16899 CSVs (thereof 7500 PHEVs) instead of 21000
I ran all regions with 1000 EVs per type an get 30588 CSVs (thereof 12000 PHEVs) instead of 42000

Can you make sense of this?

When running the rs7 defaut scenario in a single thread, I get the following error:

Multithreading eats those kinds of errors and just continues with the next region, which explains why it hadn't been noticed before.


kops_1_15: init at 1.15.0

Motivation for this change
New package version
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @zimbatm

What is the policy for keeping old versions for this package?

What is the policy for keeping old versions for this package?

I don't think there is one yet.
Typically the idea is to not force people to upgrade production clusters whenever nixpkgs updates.
I think it's reasonable to adopt the k8s supported versions model here, which boils down to the lastest three minor versions.
That being said, I would keep the existing versions because 1.12 introduces a breaking change and upgrading from <1.12 to >1.12 is not really supported.

Weekly reminder that this still needs a review.

@Mic92 So how do we make progress here?
This seems like a simple version bump to me, I don't really get why this has to linger here for weeks.
@zimbatm @offlinehacker @ehmry

let's cleanup the old versions later. Usually we keep the 3 latest


KAFKA-4607: Validate the names of auto-generated internal topics

I considered catching errors to add further information about naming internal state stores. However, Topic.validate() will throw an error that prints the offending name, so I decided not to add too much complexity.

I think it is better to add this check closer to the user to avoid deep stack traces. Thus, I would add it to KGroupedStreamImpl and KGroupedKTabelImpl.
\cc @guozhangwang @dguy @enothereska

Furthermore, can you please add a test for this.

Will look into it. Thanks @mjsax !

@mjsax Do you think it might be good to put it both in KGroupedStreamImpl/KGroupedTableImpland also inInternalTopicConfig` in case other, new code tries to use InternalTopicConfig as well?

Sounds like a good idea to me. Maybe we can put it as an assertion into InternalTopicConfig ?

@mjsax There are now ... a lot of changes. I am fairly new to contributing to open source so please let me know if I have updated the pull request in the wrong way. I left the full validation in InternalTopicConfig since I figured that internal topics should also follow the rules of regular topics.

What's the status of this PR?  I'd be great to get it merged soon.

Seems @nixsticks has not addressed the comments yet.

@guozhangwang I prefer shallow stack traces and thus IMHO we should check as soon as we can if names are valid. (Of course, just my personal opinion.)

@guozhangwang I prefer shallow stack traces and thus IMHO we should check as soon as we can if names are valid. (Of course, just my personal opinion.)

I'm convinced.

@guozhangwang Sorry, I was asked to wait for an update from you on the kafka-core module vs code duplication, and then I went on PTO for two weeks! I will try to get my changes in soon (I'm returning to the US in a few days)

@guozhangwang @mjsax Decided to open my computer just for a few minutes and then ended up making most of the changes you mentioned. I have not rebased with the upstream yet but will do so after  Could you let me know whether the addition of Topic.java is acceptable or whether I should do something else (and whether the changes look acceptable as well)? Thank you!

Not sure what happened to my previous comment, but: I have addressed most of the comments here. Could you let me know whether the changes are acceptable, and what you'd like regarding the addition of Topic.java vs using the kafka-core module? Thanks!

\cc anyof @dguy @enothereska for second review

LGTM, but I'd like @ijuma to comment on adding Topic.java please.

ping @nixsticks in case you did not receive notifications on new comments.

@guozhangwang Thanks. Apart from minor comments I'd like to hear more of a solid decision on where this code should go before I make changes again.

It is not ideal, though I feel we cannot avoid code duplication on Scala / Java, but I think it's better to go into o.a.k.common.internals instead of o.a.k.common since the latter is a public package meaning that Topic will be exposed to users and it'll be hard to change its interfaces in the future. cc @ijuma

@guozhangwang Thank you, sounds good. I'm a little pressed for time at work right now, so will look into this on the weekend. 👍

@guozhangwang Addressed minor comments and moved Topic into o.a.k.common.internals, along with its test.

@nixsticks There is a checkstyle failure from jenkins builds:
:clients:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk7-scala2.10/clients/src/main/java/org/apache/kafka/common/internals/Topic.java:1: Line does not match expected header line of '/*'. [Header]
 FAILED

@nixsticks please see https://github.com/apache/kafka/pull/2679 as a reference for the apache headers checkstyle issue.

Thanks @guozhangwang, fixed the checkstyle error.

@mjsax Addressed comments.

@nixsticks There was a checkstyle error in the build. Can you have a look. Thx.

@mjsax I did, last night, but it is for a file (ByteArrayConverter on Connect) that I did not touch.

Try to rebase to trunk

@mjsax I did, last night, but it is for a file (ByteArrayConverter on Connect) that I did not touch.

I think this is not from your code, but another PR merged recently that has a header issue, and it has been fixed in a most recent commit: https://github.com/apache/kafka/commit/962c378cc6cdb178541155af419c24e463516a5d

@mjsax @guozhangwang Rebased

BTW, what is the process for squashing/rebasing before merging?

We don't have an official policy. But this are my two cents:

As long as you work on the PR, it's best to just append new commits. This simplifies review process as the reviewer can inspect the deltas
If rebasing is required (eg., github shows some merge conflicts), just rebase (if possible don't squash commits -- but of course, if you squash first and rebase then, rebasing is simpler and it's also ok if you do this)

When a PR get's merged, the committer doing the merge will squash all commits anyway (so you don't need to squash by yourself). The commit message will contain the github title and github description for the PR (IRRC).
So overall, you don't need to worry about it too much :)

The details can be found in the following wiki page:
https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
What @mjsax is mostly right (apart from the no official policy comment :)). I'd just git merge instead of git rebase when you intend to update the branch with changes from trunk. Since commits are squashed automatically, there's not much point in using rebase and it doesn't make clear when the branch was updated to include more trunk commits.

By the way, one issue I raised early on is that doing this client-side won't necessarily work in every case. Here's a concrete example:
https://issues.apache.org/jira/browse/KAFKA-4893

@ijuma Thanks for clarification! :)
About KAFKA-4893 -- I guess, we should add a check to Streams, but this would be a different PR. The store names checked here are only part of topic names, and thus, we cannot check the topic name length at this level. I created https://issues.apache.org/jira/browse/KAFKA-4912 for this.


Setup aptos-wallet-adapter-tailwind-ui

Oh interesting that it's not rendering on your end. Okay let me set up the tailwind config

Thanks for the review @0xmaayan! Odd that its not rendering on next.js but working locally, ill address the comments.

Thanks for the review @0xmaayan! Odd that its not rendering on next.js but working locally, ill address the comments.

Hi @WEB3Zer0 , I tested it locally with the demo app (it is a nextjs app), I do it with running pnpm turbo run dev on the root of this monorepo
https://github.com/aptos-labs/aptos-wallet-adapter/blob/main/CONTRIBUTING.md#develop-locally


fix errors in AddHardDisk.ps1

All pass-through test cases return this error, although the test runs are successful:

Error: VM test setup script setupScripts\AddHardDisk.ps1 for test HotRemove_Multi_PassThrough_SCSI failed
Info :    test - PassThrough disk number not specified
Info :    test - PassThrough disk number not specified

Closing PR until further fixes in automation


oauth uses http callback when https is configured

After upgrading to version 5.4 and configuring oauth2, users are unable to login to Gitlab CI. There appears to be a bug which redirects users to an http callback url even if Gitlab CI is configured for https.
Clicking "Login with Gitlab" in Gitlab CI sends me to the following url:
https://gitlab.economicmodeling.com/oauth/authorize?client_id=foo&redirect_uri=http%3A%2F%2Fci-test.economicmodeling.com%2Fuser_sessions%2Fcallback&response_type=code
which incorrectly specifies an http redirect_url. The page says "An error has occurred
The redirect uri included is not valid." The callback url configured in Gitlab oauth applications is:
https://ci-test.economicmodeling.com/user_sessions/callback.
Viewing https://ci-test.economicmodeling.com/help/oauth2 displays the following which is incorrect (should be https instead of http):
In the GitLab admin area under OAuth applications create a new entry.
The redirect url should be http://ci-test.economicmodeling.com/user_sessions/callback

gitlab url: https://gitlab.economicmodeling.com/
gitlab ci url: https://ci-test.economicmodeling.com/
(gitlab) gitlab.yml:
production: &base
  gitlab:
    host: gitlab.economicmodeling.com
    port: 443
    https: true

(gitlab ci) application.yml:
defaults: &defaults
  gitlab_server:
    url: 'https://gitlab.economicmodeling.com/'
    app_id: 'foo'
    app_secret: 'bar'

  gitlab_ci:
    host: ci-test.economicmodeling.com
    port: 443
    https: true

Gitlab CI production.log:
Started GET "/user_sessions/auth" for <IP_ADDRESS> at 2015-02-12 13:00:30 -0800
Processing by UserSessionsController#auth as HTML
Redirected to https://gitlab.economicmodeling.com/oauth/authorize?client_id=foo&redirect_uri=http%3A%2F%2Fci-test.economicmodeling.com%2Fuser_sessions%2Fcallback&response_type=code
Completed 302 Found in 3ms (ActiveRecord: 0.6ms)

Gitlab production.log:
Started GET "/oauth/authorize?client_id=foo&redirect_uri=http%3A%2F%2Fci-test.economicmodeling.com%2Fuser_sessions%2Fcallback&response_type=code" for <IP_ADDRESS> at 2015-02-12 12:58:38 -0800
Processing by Oauth::AuthorizationsController#new as HTML
  Parameters: {"client_id"=>"foo", "redirect_uri"=>"http://ci-test.economicmodeling.com/user_sessions/callback", "response_type"=>"code"}

Apache2 is configured as a reverse proxy for Gitlab which also redirects http to https:
<VirtualHost <IP_ADDRESS>:80>
  ServerName gitlab.economicmodeling.com
  Redirect permanent / https://gitlab.economicmodeling.com/
</VirtualHost>
<VirtualHost <IP_ADDRESS>:443>
  ServerName gitlab.economicmodeling.com
  DocumentRoot /home/git/gitlab/public

  ProxyRequests Off
  ProxyPreserveHost On
  ProxyPass /uploads !
  ProxyPass / http://<IP_ADDRESS>:9292/
  <Location />
  ProxyPassReverse /
      Order deny,allow
      Allow from all
  </Location>

  RewriteEngine on
  RewriteCond %{DOCUMENT_ROOT}/%{REQUEST_FILENAME} !-f
  RewriteRule .* http://<IP_ADDRESS>:9292%{REQUEST_URI} [P,QSA]
  RequestHeader set X_FORWARDED_PROTO 'https'

  SSLEngine On
  SSLCertificateFile /path/to/crt
  SSLCertificateKeyFile /path/to/key
  SSLCertificateChainFile /path/to/chainfile
</VirtualHost>

With a similar setup for Gitlab CI:
<VirtualHost <IP_ADDRESS>:80>
  ServerName ci-test.economicmodeling.com
  Redirect permanent / https://ci-test.economicmodeling.com/
</VirtualHost>
<VirtualHost <IP_ADDRESS>:443>
  ServerName ci-test.economicmodeling.com
  DocumentRoot /home/gitlab_ci_test/gitlab-ci/public

  ProxyRequests Off
  ProxyPreserveHost On
  ProxyPass /uploads !
  ProxyPass / http://<IP_ADDRESS>:9494/
  <Location />
  ProxyPassReverse /
      Order deny,allow
      Allow from all
  </Location>

  SSLEngine On
  SSLCertificateFile /path/to/crt
  SSLCertificateKeyFile /path/to/key
  SSLCertificateChainFile /path/to/chainfile
</VirtualHost>

Thanks for the issue report but we only support issues for the latest stable version of GitLab. I'm closing this issue but if you still experience this problem in the latest stable version, please open a new issue (but also reference the old issue(s)). Make sure to also include the necessary debugging information conforming to the issue tracker guidelines found in our contributing guidelines.

@dbakken Try to add
RequestHeader set X-Forwarded-Proto "https"

to VirtualHost section of apache

I'm sorry, I might have closed this issue a bit to hasty!

Thank you, @vsizov! Adding X-Forwarded-Proto "https" to my Gitlab CI apache2 vhost fixed the redirect problem. An update to the Gitlab CI docs would make this clear to anyone using apache.


FAIL: TestQuadPolyFactors (overflow on 32 bit architectures)

I'm trying to create a proper package of this library for fedora, and the tests work fine on 64-bit architectures, but I get this overflow error on i386 and armv7hl:
on i386:
+ go test -compiler gc -ldflags '' github.com/cznic/mathutil
--- FAIL: TestQuadPolyFactors (0.00s)
	all_test.go:3630: 0: 7433(3155x+5915)(8168x+2313) = -1724821000x^2+1041449339x-1385406069 -> overflow
FAIL
FAIL	github.com/cznic/mathutil	119.487s

on armv7hl:
+ go test -compiler gc -ldflags '' github.com/cznic/mathutil
--- FAIL: TestQuadPolyFactors (0.00s)
	all_test.go:3630: 0: 7433(3155x+5915)(8168x+2313) = -1724821000x^2+1041449339x-1385406069 -> overflow
FAIL
FAIL	github.com/cznic/mathutil	594.629s

@decathorpe Thanks for the report. Please test and feel free to reopen if it's still broken, I don't have a 32-bit system around ATM. Thank you.

Wow, that was fast. Works fine on i386 and armv7hl (after increasing the test timeout from the default 10m to 30m) now. Thanks!


upgrade: docusaurusV2

Changes:
upgrade: docusaurusV2
Screenshots of the change:

I'm stuck at this point  as CompLibrary is deprecated in v2. Therefore when I move pages/en files in v1 to src/pages in v2, It shows errror like "Cannot find module: CompLibrary".

I'm stuck at this point  as CompLibrary is deprecated in v2. Therefore when I move pages/en files in v1 to src/pages in v2, It shows errror like "Cannot find module: CompLibrary".

Great! We will review recently :)

Great! We will review recently :)

I see there has a cli to help us migrate.
https://v2.docusaurus.io/docs/migration/automated

I see there has a cli to help us migrate.
https://v2.docusaurus.io/docs/migration/automated

I see there has a cli to help us migrate.
https://v2.docusaurus.io/docs/migration/automated

Yes. Initially I did  running the migration cli, and tried to complete the missing parts  using  the manual migration process.
migration command format
[1]npx @docusaurus/migrate migrate ( v1 website directory)  (desired v2 website directory)
Ex: npx @docusaurus/migrate migrate ./v1-website ./v2-website
That's why I created website2.0 :)

But here It says some parts can't easily be automated, and  have to fallback to the manual process.

I see there has a cli to help us migrate.
https://v2.docusaurus.io/docs/migration/automated

Yes. Initially I did  running the migration cli, and tried to complete the missing parts  using  the manual migration process.
migration command format
[1]npx @docusaurus/migrate migrate ( v1 website directory)  (desired v2 website directory)
Ex: npx @docusaurus/migrate migrate ./v1-website ./v2-website
That's why I created website2.0 :)

But here It says some parts can't easily be automated, and  have to fallback to the manual process.

ok, just to make sure, this PR is created by the following steps:

using the command to auto migrate;
fix missing parts which that command cannot do.

ok, just to make sure, this PR is created by the following steps:

using the command to auto migrate;
fix missing parts which that command cannot do.

ok, just to make sure, this PR is created by the following steps:

using the command to auto migrate;
fix missing parts which that command cannot do.

Yes

ok, just to make sure, this PR is created by the following steps:

using the command to auto migrate;
fix missing parts which that command cannot do.

Yes

Here the problem is Some parts of the migration can't be automated (particularly the pages), so we will have to migrate them manually.
Also  CompLibrary is deprecated in v2. Therefore when I move pages/en files in v1 to src/pages in v2, It shows errror like "Cannot find module: CompLibrary".
The guide says to write our own React component or use Infima styles.So Do we need to modify our pages according to this ?

Here the problem is Some parts of the migration can't be automated (particularly the pages), so we will have to migrate them manually.
Also  CompLibrary is deprecated in v2. Therefore when I move pages/en files in v1 to src/pages in v2, It shows errror like "Cannot find module: CompLibrary".
The guide says to write our own React component or use Infima styles.So Do we need to modify our pages according to this ?

Hi @KishaniKandasamy, I would prefer using Infima styles, but which one is easier for you, then we use it.

Hi @KishaniKandasamy, I would prefer using Infima styles, but which one is easier for you, then we use it.

Hi @KishaniKandasamy, I would prefer using Infima styles, but which one is easier for you, then we use it.

Hi Zhiyuan , Yes. If you give me sometime, I could  solve this as I am not most  familiar with Infima styles.

Hi @KishaniKandasamy, I would prefer using Infima styles, but which one is easier for you, then we use it.

Hi Zhiyuan , Yes. If you give me sometime, I could  solve this as I am not most  familiar with Infima styles.

Sure :)

Sure :)


Contributed view container: when there is only one view, split view should not be present

Refs: #85908

Have a contributed view container like remote
Hide all views except one
That view is still shown in a split view. Instead it should be merged with the container (same  as our vscode container behave, for example Explorer). It should no longer be inside a split view

This is also happening in Insiders
fyi @sandy081

I think this is expected ad remote viewlet has special behaviour and is not merged.
@alexr00 Please confirm?

That is correct, remote viewlet has special behavior and is not merged since the merging conflicts with the drop down.

I find that inconsistent - couldn't we merge the actions from the container with the actions of the view? Would there be too much?
Feel free to close as designed.

Since the drop-down functions as a filter I think keeping the things it filters (views, including actions) below it it is clearer than having the title change and having actions move to be next to the drop-down. If we merge, it could look like those are top level actions and a top level title, which it is not. I will bring up at the next UX sync to get more input.

That's makes sense, however since it is for a UX sync, we will probably not tackle it this week. Thus maybe assign to next milestone not this one?

After UX discussion, this is the goal:

Then when there is only one view, the title still makes sense and there is room for the buttons.


[6.0] vars may be used uninitialized

|| .../lv_draw_line.c: In function ‘lv_draw_line’:
/.../lv_draw_line.c|585 col 13| error: ‘aa_shift2’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
||              lv_draw_aa_ver_seg(prev_p.x + pattern[width_safe - 1].x + aa_shift2,
||              ^
.../lv_draw_line.c|440 col 16| note: ‘aa_shift2’ was declared here
||      lv_coord_t aa_shift2;
||                 ^
.../lv_draw_line.c|583 col 13| error: ‘aa_shift1’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
||              lv_draw_aa_ver_seg(prev_p.x + pattern[0].x - aa_shift1, prev_p.y + pattern[0].y,
||              ^
.../lv_draw_line.c|439 col 16| note: ‘aa_shift1’ was declared here
||      lv_coord_t aa_shift1;
||                 ^
|

When building lvgl on linux with these gcc options (removed include paths and defines, for clarity):
 -Wall -Werror -Wpointer-arith -Wuninitialized -std=gnu99 -Os -fdata-sections -ffunction-sections  -c -MD -o

Hmm. I build it with very strict warnings usually so I'm surprised I haven't run into this yet. I will fix it tomorrow.

It was introduced when I added display level anti-aliasing on/off.
They will be initialized if anti-aliasing is enabled else not used. So it's fine to add 0 init. value to both.
I found other minor warnings too with the latest version.
/home/kisvegabor/projects/littlevgl/eclipse-workspace/pc_simulator_sdl_eclipse/lvgl/src/lv_core/lv_obj.c: In function ‘lv_init’:
/home/kisvegabor/projects/littlevgl/eclipse-workspace/pc_simulator_sdl_eclipse/lvgl/src/lv_core/lv_obj.c:102:5: warning: "LV_INDEV_READ_PERIOD" is not defined, evaluates to 0 [-Wundef]
 #if LV_INDEV_READ_PERIOD != 0

#if LV_INDEV_READ_PERIOD != 0 should be removed.
/home/kisvegabor/projects/littlevgl/eclipse-workspace/pc_simulator_sdl_eclipse/lvgl/src/lv_objx/lv_roller.c: In function ‘inf_normalize’:
/home/kisvegabor/projects/littlevgl/eclipse-workspace/pc_simulator_sdl_eclipse/lvgl/src/lv_objx/lv_roller.c:670:20: warning: declaration of ‘roller_scrl’ shadows a parameter [-Wshadow]
         lv_obj_t * roller_scrl   = lv_page_get_scrl(roller);
                    ^~~~~~~~~~~
/home/kisvegabor/projects/littlevgl/eclipse-workspace/pc_simulator_sdl_eclipse/lvgl/src/lv_objx/lv_roller.c:656:34: note: shadowed declaration is here
 static void inf_normalize(void * roller_scrl)
                                  ^~~~~~~~~~~
/home/kisvegabor/projects/littlevgl/eclipse-workspace/pc_simulator_sdl_eclipse/lvgl/src/lv_objx/lv_roller.c:671:27: warning: declaration of ‘ext’ shadows a previous local [-Wshadow]
         lv_roller_ext_t * ext    = lv_obj_get_ext_attr(roller);
                           ^~~
/home/kisvegabor/projects/littlevgl/eclipse-workspace/pc_simulator_sdl_eclipse/lvgl/src/lv_objx/lv_roller.c:659:23: note: shadowed declaration is here
     lv_roller_ext_t * ext = lv_obj_get_ext_attr(roller);

@embeddedt can you fix these issues too?

@amirgon @kisvegabor I will fix all of them today.

Should have been fixed by https://github.com/littlevgl/lvgl/commit/ea7c82f47827a297b5d4a235454c67139154c46f.

Should have been fixed by ea7c82f.

Thanks @embeddedt!

Thank you!


Streaming response with text/event-stream

Are you still considering adding text/event-stream for the Streaming Response ? Reading #294, it might make sense to have that option for browser-only clients.
For reference, here is a JavaScript client for text streaming that works on both the browser and Node.js.
https://github.com/huggingface/huggingface.js/blob/main/packages/inference/src/tasks/custom/streamingRequest.ts

Amazing! @mxyng didn't know about the OpenAI compatibility 👏


Add Workspace callbacks for when each package is loaded

(for status and logs in clients such as IDEs)

@swift-ci please smoke test

@swift-ci please smoke test


winsock usage

Before using any winsock functions, WSAStartup has to be called:
https://docs.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-wsastartup
Adding the following code to socketstream.cpp solved the problem for me:
int socketbuf::open(const char hostname[], int port)
{
   // ...
#ifdef _WIN32
   WSADATA wsaData;
   WSAStartup(MAKEWORD(2, 2), &wsaData);
#endif
   hp = gethostbyname(hostname); // <- will always be null without WSAStartup
   if (hp == NULL)
   // ...
}

EDIT: calling WSAStartup in the constructor and WSACleanup in the destructor of the socketstream class would be cleaner .

Some additional thoughts:
When running the examples I was suprised that my server didn't receive any data and adding the above code to socketbuf::open was a quick fix for all examples. In general, it's the responsibility of the calling process to call WSAStartup and WSACleanup, so I think this not a bug of MFEM and the fix should probably be applied to the examples code.

Some additional thoughts:
When running the examples I was suprised that my server didn't receive any data and adding the above code to socketbuf::open was a quick fix for all examples. In general, it's the responsibility of the calling process to call WSAStartup and WSACleanup, so I think this not a bug of MFEM and the fix should probably be applied to the examples code.

Thanks for reporting this and suggesting a fix @wo80.
We don't usually run on Windows, so this is very useful. Can you tell us more about how you build and run mfem (and glvis)?

Thanks for reporting this and suggesting a fix @wo80.
We don't usually run on Windows, so this is very useful. Can you tell us more about how you build and run mfem (and glvis)?

Using cmake to build mfem works without any problems in Visual Studio (both serial and MPI).
Building glvis is rather painful. I had to edit both the cmake generated project files and some source code. Additionally, I had to disable all multi_session code path, since I'm not sure how to replace fork() on a Windows platform. This leads to the glvis server hanging after receiving mesh data, so it's not really useful.
But I've written my own visualization server in C# using OpenTK. It's very limited (only 2D) but works well for me.

Using cmake to build mfem works without any problems in Visual Studio (both serial and MPI).
Building glvis is rather painful. I had to edit both the cmake generated project files and some source code. Additionally, I had to disable all multi_session code path, since I'm not sure how to replace fork() on a Windows platform. This leads to the glvis server hanging after receiving mesh data, so it's not really useful.
But I've written my own visualization server in C# using OpenTK. It's very limited (only 2D) but works well for me.

Thanks for the details.
What do you think will be the best solution?
Is there any downside to put WSAStartup and WSACleanup in the constructor and destructor of socketstream?
Or should we just document this for the users?

Thanks for the details.
What do you think will be the best solution?
Is there any downside to put WSAStartup and WSACleanup in the constructor and destructor of socketstream?
Or should we just document this for the users?

Putting the code into socketstream will work, but is problably not the way it's supposed to be used and might have an impact on performance:
https://stackoverflow.com/questions/396484/what-is-the-cost-of-wsastartup-and-wsacleanup
So, since glvis isn't an option for Windows users anyway, I'd suggest to just add some documentation (maybe to the Building MFEM page) telling that the cmake build works fine on Windows (and the recent version of Visual Studio), but if sockets are used, the user is responsible to initialize the winsock2 dll using the above code.
Feel free to close this issue.

Putting the code into socketstream will work, but is problably not the way it's supposed to be used and might have an impact on performance:
https://stackoverflow.com/questions/396484/what-is-the-cost-of-wsastartup-and-wsacleanup
So, since glvis isn't an option for Windows users anyway, I'd suggest to just add some documentation (maybe to the Building MFEM page) telling that the cmake build works fine on Windows (and the recent version of Visual Studio), but if sockets are used, the user is responsible to initialize the winsock2 dll using the above code.
Feel free to close this issue.

Hi @wo80, can you check that #2009 fixes the issue?

Hi @wo80, can you check that #2009 fixes the issue?

@kanye-quest Yes, neat solution!

@kanye-quest Yes, neat solution!

@kanye-quest, do you want to mark #2009 as ready-for-review?

@kanye-quest, do you want to mark #2009 as ready-for-review?

Discussion continued in #2009.

Discussion continued in #2009.


Question: TTL is signed int or unsigned int

In the code, I see Ttl is uint32:
type RR_Header struct {
Name     string dns:"cdomain-name"
Rrtype   uint16
Class    uint16
Ttl      uint32
Rdlength uint16 // Length of data after header.
}
But in RFC 1035:
TTL             a 32 bit signed integer that specifies the time interval
that the resource record may be cached before the source
of the information should again be consulted.  Zero
values are interpreted to mean that the RR can only be
used for the transaction in progress, and should not be
cached.  For example, SOA records are always distributed
with a zero TTL to prohibit caching.  Zero values can
also be used for extremely volatile data.
So it's by design or not? I know there is no much difference, just curious :-)

I never knew that a TTL was signed, hence the uint32 (which is technically
wrong). I don't think the sign bit is actually used. Doing negative TTLs does
make for an interesting experiment though.

From erratum 2130:

It should say:
TTL             a 32 bit unsigned integer

From 2181 8:

The definition of values appropriate to the TTL field in STD 13 is
not as clear as it could be, with respect to how many significant
bits exist, and whether the value is signed or unsigned.  It is
hereby specified that a TTL value is an unsigned number, with a
minimum value of 0, and a maximum value of<PHONE_NUMBER>.

Also from 2181 8, regarding 'negative' TTLs:

Implementations should treat TTL values received with the most
significant bit set as if the entire value received was zero.

ha TIL. We don't do this atm. Probably makes sense to implement 2181 is normalize returned TTL values; right now you just get a big value

Thanks for the answer. RFC gives us direction, also the questions :-)

[ Quoting<EMAIL_ADDRESS>in "Re: [miekg/dns] Question: TTL is si..." ]

Thanks for the answer. RFC gives us direction, also the questions :-)

As said, might be worth following up with a PR to mask the higher or lower bits
in the TTLs

We ran into this question with the DNS Push Notifications draft and I polled all the DNS experts at the IETF Hackathon in Prague and they all said the TTL is unsigned.


Closing animation

Thanks for the great plugin!
I really like the smooth slide down animation when expanding the text and was wondering if there’s a way to also add a smooth slide up animation when hiding the text again.
Thanks in advance!

Hi magglomag, this happens because the height of the element after collapse is unknown. It is possible to predict the height after collapse, I'll make a fix whenever possible.

Hi vaakash,
Love your little plugin, it has saved me an hour or so of time. I also like the slide down animation and would love to see a similar slide up animation if possible. Thanks.


Revert "build(deps): bump helm.sh/helm/v3 from 3.8.2 to 3.9.4"

Reverts apache/dubbo-go-pixiu#498

Codecov Report

Merging #499 (3f22035) into develop (a494b71) will decrease coverage by 0.22%.
The diff coverage is 8.23%.

@@             Coverage Diff             @@
##           develop     #499      +/-   ##
===========================================
- Coverage    54.95%   54.73%   -0.23%
===========================================
  Files          662      664       +2
  Lines        77433    77740     +307
===========================================
- Hits         42555    42549       -6
- Misses       31263    31559     +296
- Partials      3615     3632      +17

Impacted Files
Coverage Δ

...registry/zookeeper/application_service_listener.go
0.00% <ø> (ø)

...ixiu/pkg/common/extension/filter/filter_manager.go
62.22% <0.00%> (-2.90%)
:arrow_down:

pixiu/pkg/config/xds/apiclient/apiclient.go
0.00% <0.00%> (ø)

pixiu/pkg/config/xds/apiclient/grpc_envoy.go
0.00% <0.00%> (ø)

pixiu/pkg/config/xds/cds.go
52.89% <ø> (ø)

pixiu/pkg/config/xds/lds.go
58.03% <ø> (ø)

pixiu/pkg/config/xds/apiclient/grpc.go
17.85% <3.33%> (-0.10%)
:arrow_down:

pixiu/pkg/config/xds/xds.go
12.30% <7.40%> (-7.70%)
:arrow_down:

pixiu/pkg/filter/prometheus/metric.go
63.88% <63.88%> (ø)

pixiu/pkg/server/dynamic_resource_manager.go
89.18% <100.00%> (ø)

... and 21 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Added dcl-edit version number to all files

#861m9adva

Task linked: CU-861m9adva add Version to all save files


Why in you're example you use require but not import

Hello, I am apologize if question is stupid  but I have hot discussions with my colleague about why in the https://github.com/microsoftgraph/msgraph-training-reactspa/blob/main/demo/graph-tutorial/src/GraphService.ts#L9 is used require  but not import? could someone explain this cause and why is not used es6 import instead? Would it not work with import?
Thank you in advance

Using import should work fine - there's no reason not to use it here. It would be something like:
import * as graph from '@microsoft/microsoft-graph-client';

Thank you )


initialValues of createFormStore should accept undefined if exactOptionalPropertyTypes is enabled

if exactOptionalPropertyTypes is enabled, initialValues won't accept undefined but accpet {}

Can you send me a Modular Forms code example with more details?

https://www.typescriptlang.org/tsconfig/#exactOptionalPropertyTypes

Why is this a problem? Instead of undefined you can just not define any initialValues or am I missing something?

It can't accept a variable that might be undefined, although I can add ?? {} after it.
const schema = v.object({
	name: v.string()
})
const formStore = createFormStore<v.InferInput<typeof schema>>({
	validate: valiForm(schema),
	initialValues: (() => Math.random() > 0.5 ? undefined :"str")() ,
})
/**
Type 'string | undefined' is not assignable to type '{ name?: Maybe<string>; } | undefined' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the type of the target.
*/

But it's just repeating what you've done in the code.
function createFormStore({
  initialValues = {},
  validateOn = 'submit',
  revalidateOn = 'input',
  validate
} = {})

I understand and agree that we should improve this for a better DX. In the meantime, I hope the workaround works for you.


Command Line Option to Start Remote Connection (SSH Remote)

It would be great to have a command line option to launch vscode against a specific remote workspace. That way, it would be possible to write shell scripts that do, for example, run vscode on the remote and also open SFTP connection to the same machine and also start up a couple of separate SSH windows, or even fire up web browsers pointing to specific ports on the target machine.

This is possible, see https://code.visualstudio.com/docs/remote/troubleshooting#_connect-to-a-remote-host-from-the-terminal


Allowed extensions "ms-vscode": "stable" doesn't seem to enable the extensions

Testing #234993
Azure Account is stable afaik

You can use microsoft as the publisher ID to refer to all extensions published by Microsoft, even though they might have different publisher IDs.

microsoft does works, but the actual publisher ID does not

All microsoft extensions are grouped under "microsoft" publisher key and therefore one should use "microsoft" as the key in the allowed list instead of the publisher id. We do not want to support overriding this using one of the microsoft publisher ids.


What does it mean by it doesn't support partial superficial losses?

What is a partial superficial loss?
Does it mean what is described here?
If so is this functionality that will be added?

Yes, it's the case listed under Partial Disposition.
I'd like to eventually add this feature but it's not a high priority for me right now.

Ah I see what is  the current behaviour if you have this case? It counts it as a normal loss?

The program will automatically detect and apply superifical losses at 100% (ie. the entire loss is made superifical). A better behaviour would be to allow the user to configure how much of a loss is superficial (from 0% to 100%).

Ah I see. What do you mean pick how much of a loss? Isn't the amount of loss determined by how much you bought in the 61 days compared to what you sold?

Actually I see what you mean since partial losses can optionally be applied. So if you do have superficial loss will this program update the cost basis for the next purchase after the 60 day window?

Actually couldn't you easily automatically calculate it for partial too? Since, you are already going through all the transactions in the 61 day period in your code you would have the necessary info (see picture) to calculate the amount that is superficial (to add to ACB) and the amount you can claim as a capital loss.

This can get complicated because purchases can happen within RRSPs and TFSAs that trigger superficial capital losses on sales in a non tax-sheltered account within that 61-day period. It's also hard to determine how much of the asset is left at the end of the period since some portion of that asset can be held within those tax-sheltered accounts. Transactions within tax-sheltered accounts aren't tracked for the purposes of calculating the ACB.
An improvement to what I have right now is to simply detect and warn the user that a transaction could potentially be a superficial loss, but not automatically apply it. It would be up to the user to manually input if the sale transaction is actually a superifical loss, and what portion of the loss should be considered superficial.

@EmilMaric Isn't this already a problem with what you have right now? (i.e. if a transaction occurs in a registered account then it wouldn't be factored into a superficial loss). So wouldn't a better solution be to simply add registered account transactions to  the spreadsheet but add an account type column. Then if it is in a registered account you could avoid updating the cost basis when those transactions occur but still look at them when considering what the superficial loss would be in your non-registered accounts.

Yes you're correct, it's a flaw/bug in my implementation.
I think what you're proposing would work, but I think it should be an optional feature. I don't think users should be required to track their transactions within registered accounts unless they really want to for the purpose of accurately and automatically tracking their superficial losses. There should be an additional option of manually setting the superificial loss percentage if users don't want to track registered account transactions, but do want the ability to dynamically set the amount of a capital loss that is superficial.


Missing requirement

I have a project that have numpy, pandas, sklearn imports when i run "pipreqs" command with --use-local and --debug options requirement.txt does not contain sklearn dependency.
Reproduction:
Os: windows 10
Debug output:
DEBUG: Found packages: {'sklearn', 'pandas', 'numpy'}
DEBUG: Found imports: numpy, pandas, scikit_learn
DEBUG: Getting package information ONLY from local installation.
DEBUG: Writing 2 requirements: numpy, pandas to .\requirements.txt

Have you found the solution?


chore(RingTheory/Multiplicity): squeeze an import

This was importing linarith, but it isn't ever used in the file, all that seems needed is finding the instance of Ring for the integers, used in just Int.emultiplicity_natAbs.

Thanks! :tada:
bors merge


amplpy issue - need to sort the DataFrame to connect to sorted AMPL code

See the fantop.py code for example.
Specifically
dat.my_draft_positions.sort_values("Draft Position", inplace=True)

is needed if the underlying my_draft_positioons.csv is unsorted.
Could isolate this for Felipe if needed.

AMPL no longer worth my effort. I tried guys!


UI buttons not working occasionally, until refreshed (e.g. Button for hiding topPanel often doesn't work, while Settings button works?!)

For now, you can make a simple replacement with HTML button and I can try to figure out a reason

caused by
https://github.com/mprinc/KnAllEdge/issues/75
Check why settings (gear) button keeps working while identical topPanel OFF/ON, is affected by this $digest bug!!
P.S. here we talk about Angular Material switches

closed with #02c4898

closed with #02c4898


GitHub: Open Invite Page when receiving a Repo Invite

Description
When receiving a Repo invite, the open in browser failed as described in #11249. So this change, checks the reason type of the notification and opens the invitation page for the repo instead.
Closes #11249
Screencast
soon
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[ ] I checked that files in the assets folder are used by the extension itself
[ ] I checked that assets used by the README are placed outside of the metadata folder

Feature idea: Instead of opening the invite in the browser, the default Action could be to accept the invite via the API and then open the repo.


Adding CheatSheet.rst

Attempting to start a successful pull request to add the CheatSheat.rst file. Currently in a pretty rough first draft for content - no fancy markdown tables yet. Could use comments about what to add/keep/delete.

oops, somehow I attached this to an old pull request for the debug/ bisect section stuff....


[2.1] Set field access mode for all entities in hierarchy when using lazy-loading

Fixes #11692
The issue was that the navigation property was defined on an abstract base class, and that entity type was not getting the NavigationAccessMode set.

Updated base to release/2.1 due to title but this has extra commits from dev which shouldn't go to release/2.1. May need cherry-picking.


Fix plotting commands

@tddesjardins pointed out on Slack that fillstyle='full' doesn't appear to work anymore.
The plotted apertures in the readme.md and other documentation show the defaults of aperture.plot(), which are filled cyan shapes. This appears to now be overridden almost everywhere by empty shapes with different colored lines for each aperture (see siaf.plot_main_apertures(), e.g.)
I also notice that in the default HST plotting example it appears that some ACS apertures are getting filled, but are  at a different scale or on a different coordinate system.
From Readme.md:

What you currently get if you actually run that code:

First step when I have the time: Find the PR or commit when this stopped working.

Tested old versions starting with 0.10.0. Plotting breaks in pysiaf starting with 0.13.0. Before that it behaves as expected.

@mfixstsci This strongly points to my initial suspicion that the problem relates to the changes made with PR #177 and PR #185 (Since that was the only time I remember anyone touching the plot functions...)


Update convert-base.jl

Fix Dict issue

This fixes #87

@simonbyrne Incorporated the changes you've suggested.

Fantastic, thanks.
Actually, would you mind adding a test as well?

Ah, I've written a bunch of tests. I thought about opening up another pull request for that. Shall I just add them all to this one?

Fantastic. Whatever is easier.

There seems to be a problem with rcopy(Cint(1)) . It says Type cannot be constructed. This seems to work on my Mac on Julia v0.4.1

This is on 0.3, which doesn't support calling bitstypes (such as Cint(1)). Add @compat outside (e.g. @compat(Cint(1)).
Perhaps time has come to deprecate 0.3, though that should be a separate PR.

I'm afraid @compat(Cint(1)) doesn't work. It still says Type cannot be constructed

Hmm, try @compat(Int32(1)).

Oh, that works. Interesting to note that @compat(Cint(1)) doesn't work even though they're just type-aliases.

Macro trickery I guess.

Oh I see. How will changing it to Int resolve it? Isn't Int typealias for Int64 on Windows too? Should I also write a method for Int32s as well in that case?

When you'll squash the commits before merging, it would be nice to use a more descriptive title than "update convert-base.jl".

Oh, I haven't squashed before. Would git rebase -i HEAD~5 squash all of my commits together?

Yes, if you change the first word of the lines to squash (except for the commits you want to keep of course, whose message can be edited by choosing edit). Note that you can keep several commits as long as each of them is meaningful and passes the tests.

The problem was only on 32-bit Windows (Int aliases to Int32 on 32-bit systems).
You can also use git rebase -i master to rebase from where you diverged from master.

 I hope that's okay? Or should I merge the two above too?

You should never have to merge branches: rebase them instead, so that all commits make logical sense. Anyway, the last commit doesn't include any changes, so you should be able to squash it just like the others.

@nalimilan I should be, but I get this error on git rebase -i HEAD~2 : error: could not apply 5e2a5ba... Update convert-base.jl. Not quite sure why, any ideas?

Hmm, you seem to have commits on two different branches that have diverged from origin/master.

Not quite sure why that is. I think I must have committed all these fixes without pulling the latest code in the first place. What that be the reason? And since Travis and Appveyor are happy, could we merge it? Or would the squash have to be done mandatorily?

Doesn't sound great to pollute the commit log with partial commits like this. A radical solution is to do git diff master > branch.diff to get a patch file for the whole branch. Then you can do git checkout -b backup to create a copy of the branch (just in case), git reset --hard master to destroy all of your changes, and git apply branch.diff to apply the patch. Then you can commit it as you do usually.

I've rebased and pushed it manually. Thanks for sorting this out!

Alright thanks! That fixes #87 then.


How to add image icone beside text fields

Dear Behzadi,
How to add image icone beside text fields for example :
$(function() {
$( "#datepicker" ).persianDatepicker({
showOn: "button",
buttonImage: "images/calendar.gif",
buttonImageOnly: true,
buttonText: "Select date"
});
});

Hi , this option not available for now, but you can create this with css and jQuery.
Many Thanks


Serve combined swagger docs with redoc

An implementation of some docs work for #248
Combines the swagger files generated from our proto compilation and serves them with redoc inside the existing hugo static site. The in-progress docs are marked with draft status so they are visible locally but not in the "live" docs.

this is really cool, it's looking awesome!!!


This is an optional additional pull request that adds timeFormat() function that adds an AM/PM format timing function

This would be in addition to https://github.com/nora-soderlund/cloudflare-d1-backups/pull/1 but remains completely optional. Might be a little overengineered might be a quality of life feature for some like me.

I'll change CreateBackupOptions#fileName to accept () => string so that you could do:
const options: CreateBackupOptions = {
    fileName: () => {
        const currentTime = // your implementation

        return `backups/${currentTime}.sql`;
    }
};

createBackup(database, bucket, options);

https://github.com/nora-soderlund/cloudflare-d1-backups/commit/450c2df361106dd52bc39dadda7368e0ea5a5c70


Request: dapr/kit maintainers / approvers should inherit from contrib and dapr/dapr roles

Background
dapr/kit used to be code inside contrib and runtime but was refactored into its own repo for code sharing.
Justification
This is heavily used by contrib and runtime, but we currently do not have maintainers for this repo.
To enable easy code reuse and consistency across runtime and contrib we need maintainers and approvers for this repo.
There are simply not enough changes made to this repo to justify a completely separate maintainership process. Additionally, it would require too much coordination with runtime and contrib maintainers. For this reason it is best to give control to maintainers of runtime and contrib.
Request
I propose that dapr/kit maintainers will be: @dapr/maintainers-dapr and @dapr/maintainers-components-contrib
And approvers will be: @dapr/approvers-dapr and @dapr/approvers-components-contrib

cc @dapr/steering-and-technical-committee

Agree!

Agree.

+1

Done:

Clarifying that this issue also approved removing approvers-kit and maintainers-kit. It will only affect @pkedy since he will not be maintainer anymore after this change.


Rectified the Copyright Year and name of the Copyright in the License…

….md file
Describe your changes

The Copyright holder's name and the year it got fixated have been specified.
Issue ticket number and link

#664
Motivation and Context

The change was made to ascertain the owner of the Copyright in the Source Code and in case any licensee is permitted to redistribute, modify, or adapt the moral right is still  vested in the Copyright owner - Nkọwa okwu
How Has This Been Tested?

Screenshots (if appropriate):

great work! @mustafaalameen

Thanks so much!🥰 @ijemmao
Nice project you have right there.
Just so you know that it is the first project I contributed to in the Opensource space.
I'm so proud of myself🤭❤🔥


Update all Go stuff

It's all using go_module and not using go_stdlib. Doing that and adding the pure Go build tags should produce a static binary, at least for Linux.
Fixes #172

adding the pure Go build tags should produce a static binary, at least for Linux.

Have we validated that this is outputting a static binary? We should be able to do this by using this repo's commit hash and ldding the output so that it doesn't have any dynamic dependencies

Yes, I have.
$ file plz-out/bin/tools/please_pex/pex_main
plz-out/bin/tools/please_pex/pex_main: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped


Install WSL2 without a distribution

On previous machines I've installed WSL2 but not added a distribution, i.e. follow steps 1-5 on https://docs.microsoft.com/en-us/windows/wsl/install-manual but skipping step 6, which is sufficient for running linux containers in Docker, but the new wsl.exe --install doesn't seem to have any option to skip the distribution.
Can you add an option to say no distribution, e.g. wsl.exe --install -d none
This would seem as though it would be a simple option that would allow saving lots of disk space for scenarios where it's not needed.

We've added this as a flag in the latest WSL versions on Windows Insiders!  :) Thank you for filing this!

Is this live already?

Did this ever land?


Added setup script for linux

Description
Created a Linux compatible version of the bin/setup script  for Ubuntu/Mint.
Tests

Tested each installation section independently
Ran the script

@tfrcarvalho Maybe we could make the bottom one it's own bash script then call it from the separate scripts?

Also feel free to add to https://github.com/chanzuckerberg/idseq-web/wiki/Developer-info

@tfrcarvalho Maybe we could make the bottom one it's own bash script then call it from the separate scripts?

Sounds good to me... would you mind doing that on this PR?

Created a common multi-platform script so we can reuse the same logic
Will update the wiki as soon as this is merged in case more changes are needed
Changed setup to setup-mac I don't want to inconvenience anyone since everyone else uses mac and likely always will but I think it may be confusing to developers to see bin/setup and bin/setup-ubuntu. I can change it back if you prefer

Changed setup to setup-mac

nit: Maybe setup-macos is the best logical match...


chore: Deprecate getTeamMembers and getMembers.

chore: Marked getMembers and getTeamMembers as deprecated.
Fixes #4140
Description
Marked getMembers and getTeamMembers as deprecated.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.003%) to 84.549%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
19668

Relevant Lines:
22036

💛  - Coveralls


Table Components

The components to render HTML tables will be created in the @kodiak-ui/tables package. Each component should render a separate HTML table element and accept the sx and variant props.

Table
TableHead
TableBody
TableFoot
TableRow
TableHeader
TableData

Main Story: ch51715

Details
All components accept the variant and sx prop and provide the appropriate HTML styling by default.
This PR will address changes to the following:

[x] Components
[ ] Hooks

Acceptance Crtieria

[x] Developer should be able to use Table components to render the appropriate HTML elements and style them with the sx and variant props.

API Changes

[ ] [Breaking] This PR introduces breaking changes
[ ] [Documentation] Documentation has been written about the API change

Deployment
Before merge to master
Note: Code merged to master should be safe to automatically deploy to production as-is.

[x] [QA] User-testing/quality assurance done
[ ] [Test] All components and hooks should have a corresponding unit test
[ ] [Storybook] All components and hooks should have a corresponding Storybook story
[ ] [Documentation] Documentation has been written or updated
[ ] [Version] Version number has been updated

I've updated the theme to show how to style with variants.


Fedora .NET 6 packages are now available

.NET 6 packages for both Fedora 35 and 34 are in the process of being
released:
34: https://bodhi.fedoraproject.org/updates/FEDORA-2021-22cd8b68c0
35: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9f61773163
cc @adegeo

Hey, @gewarren, can you help me find reviewers for this change?

@omajid Hey there, I made these changes about 15 days ago I think as soon as I had returned from vacation. I didn't notice your PR, sorry about that! https://github.com/dotnet/docs/pull/27737

Oh, hey, that's all great! Thanks for letting me know.


Unsupported uint data type in LINQ select statement

I know that there are issues (or unsupported) with unsigned values in DB.
But in this case, I'm using an uint variable to set an anonymous select object, and is throwing a casting exception:
uint test = 23;
uint idProduct = 12;
DbContext RepositoryContext = new ndsContext();
IQueryable query = from p in RepositoryContext.Products
                                                              where p.IdProduct.Equals(idProduct)  //Theres an issue reported: https://docs.microsoft.com/en-us/dotnet/framework/data/adonet/ef/language-reference/known-issues-and-considerations-in-linq-to-entities#UnsignedIntsUnsupported but this works fine
                                                              select new
                                                              {
                                                                  IdProduct = p.IdProduct, //p.IdProduct is an uint and it works
                                                                  IdSet = test, //This fails with a InvalidCastException
                                                                  Order = 0
                                                              };

If you are seeing an exception, include the full exceptions details (message and stack trace).
Exception message: An exception occurred while reading a database value. The expected type was 'System.UInt32' but the actual value was of type 'System.Int64'

Steps to reproduce
As seen in the code above, when I use a uint variable ("test") to set an anonymous property, it treats it as an Int64 value. The thing is that this value is not from the database, its just a local variable.
Why does it fails? It's a problem with LINQ to Entities? Or maybe the provider (Pomelo)?
Further technical details

Operating system: MacOS
IDE: Visual Studio 2017 Community for Mac 7.7.3

@scblason I have not been able to reproduce this. Can you post a small, runnable project/solution or complete code listing (like mine below) that demonstrates the behavior you are seeing?
public class Product
{
    [Key]
    public int IdProduct { get; set; }
}

public class BloggingContext : DbContext
{
    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
    {
        optionsBuilder
            .UseSqlServer(@"Server=(localdb)\mssqllocaldb;Database=Test;ConnectRetryCount=0");
    }

    public DbSet<Product> Products { get; set; }
}

public class Program
{
    public static async Task Main()
    {
        using (var context = new BloggingContext())
        {
            context.Database.EnsureDeleted();
            context.Database.EnsureCreated();

            context.AddRange(new Product(), new Product());

            context.SaveChanges();
        }

        using (var context = new BloggingContext())
        {
            uint test = 23;
            uint idProduct = 12;

            var query = from p in context.Products
                where p.IdProduct.Equals(idProduct)
                select new
                {
                    IdProduct = p.IdProduct,
                    IdSet = test,
                    Order = 0
                };

            var results = query.ToList();
        }
    }
}

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


Incorrect bounding box for the workbench V2

Describe the bug
The bounding bow of the workbench is too high; it should end at the table heigh.
And also, it is missing collision for the "wall" of the workbench.
Additional context

If the ammo press is placed on the workbench, players will suffer suffocation damage when approaching the ammo press

It's If you place double on top of eachother

If the ammo press is placed on the workbench, players will suffer suffocation damage when approaching the ammo press

You shouldn't be able to place an ammo press on the workbench and that will be fixed this dev build

It should be like this: keep the player's head close to the amo_ Press, players will suffer suffocation damage

I think they are quite similar

Yes, but similar is not the same

And no they aren't one is an incorrect bouding box, and the otehr is the way TE are created in MWC is very wrong

Issue 91 will be fixed in dev-11

Re-Opened -- @SticksDeveloper We need the backboard fixed.


Change the tabs

Hi there,
today on my company we use the SQLYog, but on Linux using the Wine. We trying to change to DBeaver but we need a new feature to organize our lives. I attach a photo to explain. I need a tab for organize the connections with the server. If you see the tab with color are the severs and the databases and when a select one, than the querys tab change to tha server.
Please contact me if you have some question.

In DBeaver you can change editor database using main toolbar (there are two combo boxes - to select active database and active schema).
Is this tabs toolbar the same but with different layout?
And what if number of connection more than 10 and these tabs doesn't fit the screen?

Hello mr Serge, i know i can change databases and schemes using the combo
boxes. But what i need is that when i alternate between databases/schemes
my query editor tabs also changes.
An example:
In database 1, i have 3 sets os query editor tabs, and in database 2 i have
5 different query editor tabs. When i switch between those databases (using
the combo boxes) , i'd like to only be able to see the query tabs that are
related to its database.
Database 1:
Schema23:
*QueryEditor1
*QueryEditor2
Schema42:
*QueryEditor8
*QueryEditor9
Database 2:
Schema18:
*QueryEditor3
*QueryEditor4
*QueryEditor5
*QueryEditor6
*QueryEditor7
2016-10-15 11:25 GMT-03:00 Serge Rider<EMAIL_ADDRESS>
In DBeaver you can change editor database using main toolbar (there are
two combo boxes - to select active database and active schema).
Is this tabs toolbar the same but with different layout?
And what if number of connection more than 10 and these tabs doesn't fit
the screen?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/serge-rider/dbeaver/issues/841#issuecomment-253987314,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGqAOYkO1lqZw_WxrgVK6SxQxJ8YXPKNks5q0OJAgaJpZM4KV03z
.

+1

I don;t think that this is possible in current DBeaver UI model.
There should be another way to simplify SQL editors management.


Failure on Mac

Hello,
I am on OSX 10.9.5 and make test is failing with
[WARN] cpp.c:628: /usr/include/sys/cdefs.h:81:0: #warning: "Unsupported compiler detected"
[ERROR] parse.c:1904: /usr/include/string.h:81:44: identifier, ( or * are expected, but got )
when I look there I see
#if !defined(GNUC) || GNUC < 4
But when running with
./8cc -D__GNUC__ -a -o h hello.c
I get
zsh: segmentation fault  ./8cc -D__GNUC__ -a -o h hello.c
Should I be including a different set of header files?
Thanks

Mac OS header files are peculiar. There are a lot of things to do if you want to run it on Mac OS.


Allow to change text colors

It would be nice to be able to change the text colors (black/gray) in XML or in Java code.
Could you implement that?
Thanks!

Sure I can. Actually it is done now. https://github.com/sujithkanna/SmileyRating#change-colors check this to see how to chage colors.

Thanks a lot!


Added shebang to tell unix systems to use node

Received command not found error when running node-prototype-repl on ubuntu: https://stackoverflow.com/questions/34353512/node-npm-package-throw-use-strict-command-not-found-after-publish-and-install-g.
Adding the shebang tells "*nix systems that the interpreter of our JavaScript file should be /usr/bin/env node which looks up for the locally-installed node executable".

https://medium.com/netscape/a-guide-to-create-a-nodejs-command-line-package-c2166ad0452e

Thanks!


Breadcrumbs

I use baguette via the nikola static website generator. I love the lightbox, and I have a (hopefully) minor request: breadcrumbs. What do I mean with this?
Let's take the example of the first gallery at https://feimosi.github.io/baguetteBox.js/ If I click in the 4th image on the 1st row, the lightbox opens showing a bigger image. So far so good.
What I would like is that the URL in the browser's location bar to have a reference to this image in the lightbox. The most usual way is to add an anchor to the URL, like https://feimosi.github.io/baguetteBox.js/#img/1-4.jpg
The second part of the request is that if the URL has a breadcrumb, the lightbox with the relevant image opens. That is, if I got to https://feimosi.github.io/baguetteBox.js/#img/1-4.jpg , I expect the page to open with the lightbox open and that image in it.
This way I can send URLs to specific images to people, instead of having to put them in their own folder or telling them "check the 284th image in this gallery!".
Unluckily my free time and JS knowledge are not enough to try to tackle this myself.

Look, I found some code that maybe you can use, at least as inspiration: https://github.com/fancyapps/fancybox/blob/master/src/js/hash.js


File globbing in package.json gives incorrect results

When I passed following files to textlint with textlint content/**/*.md, it correctly checks all of Markdown files.
├── content
│   ├── about.md
│   └── post
│       ├── 2013-07-07-install-julius-with-homebrew.md
│       ├── 2013-11-05-osx-http-proxy.md
│       ├── 2013-12-05-qiita-alfred-workflow.md

But when it comes to the script section in package.json, it began to returning result with missing about.md.
So I made workaround:
"scripts": {
  "test": "textlint content/post/*.md content/*.md"
}

I don't know whether or not this is the issue of textlint.
This is standard behaviour?
Thanks in advance.

@uetchy Thanks for report.
content/**/*.md is not handled by textlint.
npm run via /bin/sh expand content/**/*.md to content/post/about.md content/post/....md that doesn't contain content/readme.md
You try this behavior on  /bin/sh.
/bin/sh
ls content/**/*.md

As a result, textlint content/**/*.md  == textlint content/about.md content/post/....md
Currently, textlint support "path/to/file.md" or "path/to/dir" (not support wildcard).
We want to support $ textlint "content/post/*.md" if possible.
wordkaround
find ./content -name '*.md' | xargs textlint

or
Run textlint via task runner like gulp-textlint.

ok I got it.
I'll try find ./content -name '*.md' | xargs textlint.
By the way, I discovered this trick now:
sh-3.2$ ls content/{,*/}*.md
content/about.md
content/post/2013-07-07-install-julius-with-homebrew.md

This would be another workaround I think.
Anyway thank you for surveying this issue!


Generates wrong ${command.pickProcess} for .NET Core project

Environment data
dotnet --info output:

.NET Command Line Tools (1.0.0-rc4-004771)

Product Information:
Version:            1.0.0-rc4-004771
Commit SHA-1 hash:  4228198f0e
Runtime Environment:
OS Name:     Mac OS X
OS Version:  10.11
OS Platform: Darwin
RID:         osx.10.11-x64
VS Code version: 1.10.1
C# Extension version: 1.7.0
Steps to reproduce

create a .net core project by running the command dotnet new console
In Show Debug window, click Add Configuration..., in the drop-down list select .NET Core
In the newly generated launch.json file, check "processId": "${command.pickProcess}" which should be "processId": "${command:pickProcess}"

@cateyes99 Thanks for the report. This has already been fixed in the latest beta. See https://github.com/OmniSharp/omnisharp-vscode/issues/1275


Redirecting without a URL hash

Hello, first issue here.
I was creating a typical CRUD interface for a resource. After creation I respond with a redirect to a URL with a hash, but it only redirects to the URL without the hash.
Here's some logs from my server:
POST "/resource" for <IP_ADDRESS>
Redirected to http://localhost:3000/resource#resource_20
Started GET "/resource"

I'm using Rails and Rails only logs the URL on GET requests (no hash included) but it does respond w/ the hash intact on the browser (so no problem there).
I posted this issue here because redirecting w/ a hash works when I turn Turbo off (data-turbo="false") for the form I'm using.

See https://github.com/hotwired/turbo/issues/211
There isn't really a fix as it's related to the browser fetch API.

Thanks @t27duck. Closing this since it's a duplicate.