Add Docker compose support

https://github.com/jabrena/101-spring-boot-with-fibers/pull/7

Implemented


nixos/github-runner: add PAT support

Description of changes
This commit introduces support for runner registrations through a
personal access token (PAT). To use a PAT instead of a registration
token, place an appropriately scoped PAT in tokenFile. If the file
contains a PAT, the module queries a new runner registration token from
GitHub. Only github.com is support (i.e., no enterprise setups). Using a
runner registration token directly continues to work as before.
I decided to go for a Python script (without third-party dependencies) as a Bash script was too fragile and cumbersome.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 181823 run on x86_64-darwin 1

While browsing the runner source code, I noticed that the configuration routine has PAT support built in which does pretty much the same thing like the Python script in this PR—it just isn't mentioned in the docs. Stay tuned for a follow-up PR.


Im Online Shop gibt es KEINE Bestellung mit dieser Bestellnummer / Händlerreferenz. Entsprechend wurde auch nichts in die Wawi synchronisiert. Kunde sieht seine Bestellung nicht im Online Shop, Kunde bekommt keine Bestellbestätigung usw..
Bitte dringend prüfen. Details welcher Auftrag es war könnt ihr bei uns im Checkout selber prüfen mit folgenden Informationen.
#186448517 06.02.2024, 18:00:26
Damit könnt ihr die Bestellung / Bezahlung finden. Wir haben nun die Bestellung manuell angelegt in der Wawi.
Das ist aber absolut kein Zustand, dass wir jede Bezahlung im Checkout auf Dauer 1:1 vergleichen müssen mit den eingegangenen Bestellungen.

Same here with Twint payment. That's really a big problem.

Thank you for your Post. We will forward this to our Developers for review.

and again, valid paid order, no order in the wawi

hi @Alcpaone , can you provide the reference of the order in jtl (so we check what went wrong)

hi @Alcpaone , thank you, we will have a look

@thibault-mambour any news? 3 Weeks since the last release. There are several small bugs that would really be helpfull to be fixed. When will the next release be ready?

hi @Alcpaone , it should be early next week

hi @Alcpaone , it should be early next week

PLEASE write down everything you fix in the upcoming release. It looks like you fixed in the last release also some issues that aren't listed in the release notes. We only do updates if we see, that the new release solves issues. Also we can watch closer when we know that changes has be done for some parts of functionality.

again, successfull order in the online shop and payment in checkout, no order in JTL Wawi.
The Order has a number from the shop but in the shop backend you can't find this order.
we only found it because we compare every email from Checkout with the orders received. We would like to use the time differently again if the interface runs reliably.
How can it be that the order has a number generated by the online store but is not available in the online store?

Hi everyone
We had the exact same problem yesterday. We had a successful payment made by the customer, but the order was not transfered to the Wawi correctly.
Looks like it's exactly the same problem which was reported by @Alcpaone
Is there any update regarding this problem? We had this already a few weeks ago but I was hoping that it was a single case. But it looks like a recurring topic. Please have a look and provide a feedback. Thanks!

Hi everyone
We had the exact same problem yesterday. We had a successful payment made by the customer, but the order was not transfered to the Wawi correctly....

@martinreal91 what Plugin Release are you using? Latest 1.0.24?

@Alcpaone we are using 1.0.23 - is the issue fixed with version 1.0.24?

@Alcpaone we are using 1.0.23 - is the issue fixed with version 1.0.24?

@martinreal91 maybe :-) We use the actual release and in the last days we didn't had this issue again 🍀. I would suggest to upgrade anyway.

Hi @Alcpaone
Thanks for your feedback We will try to upgrade the plugin and then monitor if the problem occurs again. Fingers crossed, as always :)

@thibault-mambour please take a look at this screenshot from the checkout orders from today (actual release 1.0.24 in use):

One Ordernumber (OSB139104) is present twice, the second order with the same number never arrived to WaWi....

@thibault-mambour and just a few moments later look at this... what is here going on?

Now we miss the first order...

@thibault-mambour and again. Twice the same number used, no order in the wawi. The user informations are in the shop DB Tables. The order informations are in the postfinance checkout. So we can add manually the order for the customer as a temporary workaround.
This is a lot of work (check each order in the postfinance and compare with the order is in wawi, if not found search for all informations and add manually a order in the wawi).
Why does this happens? Please let me know what you need to investigate and solve this problem asap.
Thank you

hi @Alcpaone , can you create a separate issue for this ?

@thibault-mambour and again and again... are you working on a solution? Do you need any informations? Does anyone read this messages?

also again same issue on our end - post finance payment made successfully, but no order transfered to Wawi! Please fix this issue ASAP!

hi @martinreal91 , can you please send the affected transaction to our support<EMAIL_ADDRESS>?

Hi @thibault-mambour all details sent to<EMAIL_ADDRESS>

@thibault-mambour and again and again and again... are you checking and hopefully fixing this issue?

hi @Alcpaone , maybe can you clarify the next part ? is it often 2 orders created with the same number or only some order are 'just' not passed to wawi despite having the correct order number ?

hi @Alcpaone , maybe can you clarify the next part ? is it often 2 orders created with the same number or only some order are 'just' not passed to wawi despite having the correct order number ?

@thibault-mambour it is always the same. two orders with the same ordernumber, only one order is transfered to Wawi.

@Alcpaone just to take a newer one , the below is the example of what you mentioned ?

@Alcpaone just to take a newer one , the below is the example of what you mentioned ?

please use this OSB139104 for investigation.

Any update on this topic?

@thibault-mambour any updates here?
Problem still persists. Do you need a actuall example? Go with OSB140091 in our enviroment.

Good day
We have exactly the same problem. Time and again we have successful incoming payments in the PostFinance portal, but no order in the store, so no e-mail is sent to the customer. As a result, we have to check the incoming payments every day and create them manually.
Store version: 5.3.1
PHP: 8.1.28
Plugin: 1.0.24
Our order number: 54255
Transaction: #212107918
Is there a solution?
Thanks a lot!

hi @Alcpaone @nabooch , we are currently working on finding the root cause and fixing this issue

@thibault-mambour thank you for your information, ok so we still have to wait to send you 12 points until you break the code 😉


WIP bots: initial config for probot/stale

This will currently result in
-PRs getting flagged as stale after 7d, and closed after 14
-Issues not tagged with "help wanted" being flagged as stale after 30d and closed after 37.
WIP because we probably shouldn't submit until we've flagged the 3 pages of not-assigned not-help-wanted issues with help wanted, which I'm happy to do once we've done some bikeshedding
(is:issue is:open -label:"help wanted" no:assignee)
Happy to change time scales, turn off staleness for one or the other.  Suggest away!
I'm also mildly concerned that the + in help wanted will be incorrect and we'll have to untag a ton of bugs as stale.  I've limited tags per run to 1 and I'll turn it up on a day when I'm around to minimize that.  We can up the limit when we get busy enough we need to flag more frequently :-)
Testing: I wish
Docs Changes: Nope
Release Notes: n/a
Part of #2797
@envoyproxy/maintainers

My gut feeling is we should start without the help wanted staleness check right now. WDYT?

Sorry, I'm not entirely clear what you're suggesting.   Should we not triage stale issues yet, or are you suggesting we flag them as stale even if they're marked help wanted?

I was just suggesting that we start with only using the bot to mark staleness on PRs, and not use the bot for doing the help wanted triage. (Just because I share your concern of things not working out correctly and stuff getting closed, and I don't feel that's been a huge issue for us so far).

Gotcha.  I figured we could close off questions after a couple of months but if a combination of maintainer rotation and our preexisting and much appreciated MattBot have that covered I don't have a strong preference either way. :-)

I don't have a strong opinion either. I just was worried that things might get auto closed. If you think it's best to do the help wanted thing, that sounds fine to me as long as we keep a careful eye on it.

(I'm not going to assign anyone else -- my gut feeling is that if @mattklein123 and @alyssawilk agree on a config for this, it's good enough to start with.)

Stale for a week after comments addressed - I'll close this one off and we can revisit later when we care more :-)

Nah, it's not you it's me ;-)  I'm flat out this week (so wouldn't have time to play around with it in any case) so closed off instead of pinging you for review.


Fix intermittent PDT issues

Fixes issue #239.
Rather than use the same form for both the PDT callback and the postback, split these apart. We'll take a minimal set of parameters from the callback, and fill in rest using the postback endpoint.
I've included a test which includes the full set of query parameters I'm seeing on most (but not all) PDT callback requests. Note payment_date is in ISO format in these requests, and notify_version is a string. With this PR both these parameters will be ignored.

I'm no longer using PDT, so can't vouch for the accuracy of this PR any more. Will close!


Warn on use of inbox TP

Add a warning message to the build if we discover the use of an inbox type provider.  Eventually we may stop deploying this .Dll.  The warning is in the build targets and benign.
The message:
Text="This Project references the obsolete in-box TypeProvider: FSharp.Data.TypeProviders.dll.  Consider Switching to the Nuget package version: https://www.nuget.org/packages/FSharp.Data.TypeProviders."
@dsyme
There is a bit of an issue with this, because the nuget package has obsoleted use of the Microsoft.FSharp namespace.  I will be proposing a PR that removes that obsoletion.  We would prefer that developers can switch to the nuget version without having to modify source code.

MSBuild voodoo is extraordinary to behold :)


Fix integration tests with sqlalchemy hack

Describe your changes and why you are making these changes
Previous fix #927 has problem with schema updates since it uses 'current' upload script with production binaries. Therefore we have to revert the change.
This PR adds additional fix for the SQLAlchemy dependency issue by pin the version in github action. We need to rethink how to streamline these version updates in future.
Related issue number (if any)
Loom demo (if any)
Checklist before requesting a review

[ ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[ ] I have performed a self-review of my code.
[ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[ ] I have run the integration tests locally and they are passing.
[ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[ ] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

current actions passes checkpoint at server start, I will skip tests and merge


Cucumber support

Would be awesome with Cucumber too :smiley:

You'll have to add a thin wrapper and send a PR. I haven't used Cucumber since circa 2010 and have no plans to add support for it at this time. I don't mind merging a patch though.
On Wed, Jan 27, 2021, at 3:52 AM, Guillaume Hain wrote:

Would be awesome with Cucumber too 😃

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/dbalatero/capybara-chromedriver-logger/issues/27, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOQJORG24B3ROESHKH333S37H5BANCNFSM4WU33XXQ.

You'll have to add a thin wrapper and send a PR. I haven't used Cucumber since circa 2010 and have no plans to add support for it at this time. I don't mind merging a patch though.
On Wed, Jan 27, 2021, at 3:52 AM, Guillaume Hain wrote:

Would be awesome with Cucumber too 😃

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/dbalatero/capybara-chromedriver-logger/issues/27, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOQJORG24B3ROESHKH333S37H5BANCNFSM4WU33XXQ.

Good to know, thank you.

Good to know, thank you.

Closing this, but feel free to reopen if you have a patch!


error TS1005: ';' expected in TS typings

I'm submitting a bug report
This line and the lines below throw TS Error when building:
error TS1005: ';' expected.

This behavior is since yesteday, so presumably this commit has introduced the problem.

Library Version:
In fact, this problem showed up when using typing from aurelia-dialog 1.0.0

Please tell us about your environment:

Node Version:
8.9.1

NPM Version:
5.10.0

JSPM OR Webpack AND Version
JSPM 0.16.53

Language:
TypeScript 2.7.2

This issue seems like a bug on the aurelia-dialog not versioning its typings.
This issue comes from the infer keyword not being part of typescript 2.7. It was added in typescript 2.8. If you're able to update to typescript 2.8, that would mitigate the issue, but otherwise this should probably go to the other repo.


FYI: alternative option: design first

Hi,
nice writeup on freecodecamp. Somehow I couldn't comment there so thats why I mention this here:
An alternative option to runtime generation of the swagger file is to create the swaggerfile (or openapi-spec ;-)) first and then use: https://github.com/seriousme/fastify-openapi-glue
This will save you from having to manually create routes as well.
Cheers,
Hans

Awesome! Thanks a lot Hans, I will check it out and I might use it for the next tut!


Provide access to AFHTTPRequestOperation's completion handlers

I have a scenario where I have to repeat an already (unsuccessfully) executed request operation after issuing another request (to acquire a new access token).
While it is possible to clone the original failed operation (or create a new one with the same request), it is apparently not possible to copy the success/failure completion handlers of the original operation:

AFHTTPRequestOperation does not store references to the provided success and failure blocks, but rather creates a completion block on the fly that calls these blocks (see setCompletionBlockWithSuccess:failure:)
copying NSOperation's completionBlock is probably not a good idea, as you state yourself in the documentation for AFURLConnectionOperation:

Operation copies do not include completionBlock. completionBlock often strongly captures a reference to self, which, perhaps surprisingly, would otherwise point to the original operation when copied.

I think this is definitely not some obscure use case, but rather an essential feature. Repeating requests without calling the original completion handlers does not make much sense. And I don't seem to be the only one affected by this.
Please also see my question on SO, where I provide some code sample for my concrete use case: http://stackoverflow.com/questions/12951037/afnetworking-access-to-completion-handlers-when-retrying-operation

I came to the exactly same problem , thanks for your solutions!


Telemetry handler support

AB#9693

https://github.com/microsoftgraph/msgraph-sdk-design/blob/master/middleware/TelemetryHandler.md
We will require this to help us get better information about SDK usage. We will want to fully implement this spec.

Added to 2.0-RC5


Page navigation suggestion

When on this page, the is nothing highlighted on the left side navigation to indicate where this content is in the overall documentation hierarchy which is a little confusing. It would be helpful if this could be fixed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f546db7-20fa-c87d-f7a4-a0a931f47e05
Version Independent ID: 0180dfc6-d05d-8517-ec8c-94723f0f832e
Content: Power BI admin portal - Power BI
Content Source: powerbi-docs/service-admin-portal.md
Service: powerbi
GitHub Login: @mgblythe
Microsoft Alias: mblythe

Hi @DeanGross and thanks for the suggestion. I've assigned this to one of my doc leads but he will need to take this up with the people who develop our docs platform to see if there is interest in enhancing it.

Thanks for the feedback. The article now syncs correctly with the TOC.


Change tax rate

How is the tax rate changed for FlatTaxModifier and GlobalTaxModifier?

Rates are being defined via config API.
In the future: could you ask questions like this over in the gitter chat or on slack? These aren't really issues that belong here.

Is there any documentation as to how though?
FlatTaxModifier:
Rate: 0.10
isn't making a change.

https://github.com/silvershop/silvershop-core/blob/master/docs/en/01_Getting_Set_Up/05_Tax.md and https://github.com/silvershop/silvershop-core/blob/master/docs/en/03_How_It_Works/Order_Modifiers.md is all we have atm. Feel free to improve the docs though.


Update sign-with-akv-cert.md

I am not seeing the Key Management Operations section under Secret Permissions. Could you please fix this or clarify what it is?

sorry typo it's Secret Management Operations.
Without  Secret Management Operations Get, List  and  Certificate Management Operations Get, List enabled VS can't use certificate from Azure to sign apps.

ok. Done.


Add type declaration for Tailwind plugin

TailwindCSS 3.3 supports configs in Typescript.
Importing Flowbite in Tailwind-config written in TS results in a 'Could not find declaration file for module'-error.
This PR adds a basic type declaration for the plugin so that it can be imported without errors.

Hey @xenolithviktor,
Thanks for the contribution! Merged <3
Zoltan


generating (desc) a wordform returns two wordforms for each character with a diacritic

When generating a word form using $HLOOKUP $GTHOME/langs/lang-sje/src/fst/generator-gt-desc.hfstol, any character with a diacritic triggers two outputs: one with the single, precomposed unicode character, and one with a double, decomposed unicode (base + combining diacritic).
For example:
gähppe+A+Sg+Nom
gähppe+A+Sg+Nom	gähppe (precomposed output)
gähppe+A+Sg+Nom	gähppe (base+combing output)
This, If there are two characters with diacritics, then there are four outputs!:
härrá+N+Sg+Nom
härrá+N+Sg+Nom	härrá
härrá+N+Sg+Nom	härrá
härrá+N+Sg+Nom	härrá
härrá+N+Sg+Nom	härrá
I've tried modifying spellrelax.regexbut that didn't change anything.

@flammie could you have a look? Also @Trondtr?


Zig 0.11

Description
Fixes some compilation errors I encountered when building under Zig 0.11.0-dev.2287+1de64dba2.  This PR probably ain't ready to merge yet, since there are also some errors in zig-clap that require a separate PR there (and some git submodule shenanigans, probably). zig-clap is already Zig-0.11-ready on master, so that's good to go.
Motivation and Context
This is required to build linuxwave with Zig versions 0.11 and greater.
How Has This Been Tested?
zig version  # outputs 0.11.0-dev.2287+1de64dba2
zig build -Doptimize=ReleaseSafe  # to make sure the build process still works in isolation
zig build test
zig build run -- -s 0,7,1 -n 60 -v 65 -o boss.wav  # and other "presets" from the README

Screenshots / Logs (if applicable)
Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (no code change)
[ ] Refactor (refactoring production code)
[ ] Other

Checklist:

[X] My code follows the code style of this project.
[X] I have updated the documentation accordingly.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

Hello! 🐻
Thanks for your contribution. However, I'm not sure if switching to Zig master is something that will benefit the project right now. Most of the prominent Linux distros have the latest stable version of Zig (as of 0.10.1) packaged in their repositores and switching to 0.11.0-dev.2287+1de64dba2 will mean that they won't be able to distribute linuxwave. Also, it will make the manual compilation harder for users since they will need the development version of Zig and it might have some quirks in the future.
I will keep this PR open until there is a stable release for 0.11 and we can merge it when the adoption is becoming higher.

Yeah, I definitely don't expect this to be merged before 0.11's actually released; more just documenting the steps I needed to take to get it to build.

I see, thank you for making that clear and submitting this PR!

Zig 0.11.0 is now released! 🎉

Ping @YellowApple, can you look into this once again?

done in #28
thanks for your efforts everyone!


Update github-community-guidelines.md

Why:
Closes [issue link]

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[x] I have added the 'writer impact' label
[x] I have added a description and/or a video demo of the changes below (eg. a "before and after video")

https://wbd.ms/share/v2/aHR0cHM6Ly93aGl0ZWJvYXJkLm1pY3Jvc29mdC5jb20vYXBpL3YxLjAvd2hpdGVib2FyZHMvcmVkZWVtLzZhM2Y0YWNiYjA5NzQyMTA4YmZmYWYxZjI1NjMxMjY0X0JCQTcxNzYyLTEyRTAtNDJFMS1CMzI0LTVCMTMxRjQyNEUzRA== Odesláno z aplikace Pošta pro Windows 10 Od: JaniceOdesláno:čtvrtek 13. května 2021 20:00Komu: github/docsKopie: sollo11; AuthorPředmět: Re: [github/docs] Update github-community-guidelines.md (#6358) Closed #6358.—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.


Use README.rst as description on PyPI

Fixes https://github.com/mjuenema/python-terrascript/issues/95.
Running python setup.py --long-description will show text it finds, and upload to TestPyPI to check it renders.
Also removes the fallback to legacy distutils, it's not recommended to be used and their plans underway to remove it from stdlib, see draft PEP 632.

Passing CI build: https://travis-ci.org/github/mjuenema/python-terrascript/builds/724525277


Update inspect-traffic-with-azure-firewall.md

Added clarification on why application rules are preferred.

@asudbring
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@asudbring,
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#sign-off


Fix text drawer AnnotatedOperations

Summary
Fixes #11465
Details and comments
This PR fixes an issue in the text drawer where multi-qubit AnnotatedOperations were not displaying all the qubits.
Now this,
from qiskit.circuit import QuantumCircuit
from qiskit.circuit.annotated_operation import AnnotatedOperation, InverseModifier, ControlModifier
from qiskit.circuit.library import CXGate

gate = AnnotatedOperation(CXGate(), ControlModifier(1))
circuit = QuantumCircuit(gate.num_qubits)
circuit.append(gate, range(gate.num_qubits))
print(circuit)

displays as

q_0: ───■───
     ┌──┴──┐
q_1: ┤0    ├
     │  Cx │
q_2: ┤1    ├
     └─────┘

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.004%) to 87.544%

Totals

Change from base Build<PHONE_NUMBER>:
-0.004%

Covered Lines:
59248

Relevant Lines:
67678

💛  - Coveralls

@enavarro51, many thanks for the lightning fast fix. Just a small question: could there be a similar problem in matplotlib-based visualization?

The problem here was just that the text drawer did not handle the multi-qubit case. The mpl drawer already does.


Better error message for narrow to a nonexistent stream

Currently if you try to narrow to a stream that doesn't exist (or to a private stream you're not on), you get a message like "You are not subscribed to this stream." This is confusing because

it seems to confirm that the stream exists (even if it doesn't);
if you're pretty sure there is such a stream, and you're right, this is a poor way of explaining that you're not seeing them because it's private -- after all, if you narrowed to a public stream you're not on, you would see the messages.

Instead, we should say something like "Stream 'foo' doesn't seem to exist."
(The message should be the same for a private stream you're not on as for one that really doesn't exist, to avoid leaking that a stream with that name does exist.)
As a bonus, we could have a link to simply do a full-text search for the attempted stream name; in some cases that might help people find what they wanted.

@zulipbot claim

Hi @Anupam-dagar, thanks for looking into this! @synicalsyntax already has most of a PR in #6987. I'd recommend finding a different issue for now.

okay

The PR #6987 has merge conflicts regarding this issue. Just want to know was those resolved or not?

Hey @sroy8091, I'm currently not working on that PR. You can take this issue if you'd like, but make sure to note the issue discussion in that PR's comments (resolving this issue would involve migrating that backend template to a Handlebars template)

@gnprice If no one is working on this, I would like to work on this issue

Great! Let's use "#%s does not exist or is private.", where %s is the stream name, as the wording.

Okk. I am claiming this. @zulipbot claim

FYI I instructed @shreyanshdwivedi to use a generic message here instead.  All of the messages we show here are generic, and I don't feel this is a compelling enough use case to make an exception, as it leads to some issues with the node tests and makes it hard to create generic screenshots for docs, etc.
https://chat.zulip.org/#narrow/stream/issues/subject/.236862/near/377270


Integration Test - Release - 2019/03/19 21:36:29

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#backlog'

#pri2

#backlog

#assign PRMergerTest1

#assign NonAllowedUser

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

#reassign PRMergerTest2

GitHub user PRMergerTest1 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#reassign NonAllowedUser

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

#please-close


Hot find similar faces based on 1 face image

Question!
I'm new to python, i have many bulk of faces images, and some of the faces are same people.
I want to be able to find the same faces similar to the one i have.
How can i do that?
Can any one help me or guide me please?

Anyone?

If you have some known faces and some unknown faces, you can just use the command line tool: https://github.com/ageitgey/face_recognition#face_recognition-command-line-tool
If you want to do it from Python, check out the demos, like this one: https://github.com/ageitgey/face_recognition/blob/master/examples/recognize_faces_in_pictures.py

@ageitgey What do you mean known faces?Like Obmaha or Trump?
The faces i got are my friends..
Will it work?

Known faces are just any picture of a face where you already know the name of the person in the picture.


chore: pin Chrome

thanks!

E2E failure seems unrelated: https://github.com/GoogleChromeLabs/chromium-bidi/actions/runs/4947469165/jobs/8846880913?pr=703

Are those WPT failures related?


Don't prevent initalization if keys failed to be fechted

Would fix #18

Sorry for the delay, these last days have been busy.
I think I did it correctly, and I don't know how to test that too..
Should it have something written in the documentation?
I was going to write it in the Readme but then I saw that the documentation has a message saying it's auto-generated...
Please let me know how to handle that.
Thanks :)

Should it have something written in the documentation?

I wanna re-do the readme anyways based on feedback from other contributors. Will do that before releasing 0.4.1


python37Packages.azure-mgmt-media: 3.0.0 -> 3.1.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.azure-mgmt-media is: "This is the Microsoft Azure Media Services Client Library"
meta.homepage for python37Packages.azure-mgmt-media is: "https://github.com/Azure/azure-sdk-for-python"
meta.changelog for python37Packages.azure-mgmt-media is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.1.0 with grep in /nix/store/0pqj9ns2a5l8wr1xq1mwyzlwwzfdm7pg-python3.7-azure-mgmt-media-3.1.0

directory tree listing: https://gist.github.com/d99dca0171be621d4a8c099aaba85952

du listing: https://gist.github.com/5322ab97ffad3beb90e4cb85c77fa1fe

Rebuild report (if merged into master) (click to expand)

13 total rebuild path(s)

4 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
azure-cli
python37Packages.azure-mgmt-media
python38Packages.azure-mgmt-media
python39Packages.azure-mgmt-media

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0pqj9ns2a5l8wr1xq1mwyzlwwzfdm7pg-python3.7-azure-mgmt-media-3.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.azure-mgmt-media https://github.com/r-ryantm/nixpkgs/archive/b8debea9ceed807c9fea382cf3709817d20dea5d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0pqj9ns2a5l8wr1xq1mwyzlwwzfdm7pg-python3.7-azure-mgmt-media-3.1.0
ls -la /nix/store/0pqj9ns2a5l8wr1xq1mwyzlwwzfdm7pg-python3.7-azure-mgmt-media-3.1.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

azure-cli
python37Packages.azure-mgmt-media
python38Packages.azure-mgmt-media

Maintainer pings
cc @mwilsoncoding for testing.

Result of nixpkgs-review pr 114532 at b8debea9 run on aarch64-linux 1

3 packages built:

azure-cli
python37Packages.azure-mgmt-media
python38Packages.azure-mgmt-media

Result of nixpkgs-review pr 114532 run on x86_64-linux 1

3 packages built:

azure-cli
python37Packages.azure-mgmt-media
python38Packages.azure-mgmt-media

Result of nixpkgs-review pr 114532 run on x86_64-linux 1

3 packages built:

azure-cli
python37Packages.azure-mgmt-media
python38Packages.azure-mgmt-media


fix: get variable? to handle Type* and Sort*

Every time Type* and Sort* elaborate, they generate fresh universe level variables. This was not being accounted for in the computed vs expected check.

Thanks!
bors merge


Pulseq loading slow and potentially incorrect block ordering

Hello, me again :)
Two aspects on Pulseq that I have noticed:
1. Speed
I have been toying a bit more with Koma, now moving to even larger pulseq files.
Let's take as an example a toy cartesian 2D bSSFP sequence with 64 phase encode steps and 2 excitations per step. The result has 768 blocks, the pulseq file is 27KB in size.
Reading this with the latest master ae27d17326b7989d7fc1aceba01a051450e3d219, gives
julia> time_read_seq(f) = @time read_seq(f)
       println("baseline")
       seq = time_read_seq(seqfile)
baseline
[ Info: Loading sequence bSSFP_FA30deg_TE10ms_TR20ms_2D_(69x64)_pulseq.seq ...
  0.752135 seconds (8.51 M allocations: 299.462 MiB, 11.12% gc time)
Sequence[ τ = 3539.2 ms | blocks: 768 | ADC: 128 | GR: 636 | RF: 128 | DEF: 11 ]

julia>

We can see 8.5M allocations totaling 300MB and a ballpark of 0.5-1s for loading (have warmed-up the function before to force compilation).
A larger sequence file (6912 blocks), 220KB pulseq file comes in at ca 50s time and 21GiB allocations.
Extrapolating this to, say an MRF sequence, where you could easily have two to three orders of magnitude more blocks could easily make pulseq sequence loading completely infeasible (I have tried that). This was with an M1 macbook pro.
I have spent some time digging into the sequence loading code and optimizing it. I went through several iterations and I can now load the small file above in 0.027s with 300k allocations totalling in 11.6MB.
The larger file now loads in 0.25s with 2.59M allocations for 98MiB.
2. [BLOCKS] order
Along the way I realized that Koma seems to interpret the pulseq [BLOCKS] section as being reproduced on a scanner in incrementing ID order instead of line by line in [BLOCKS]. The blocks data is read into dictionaries of (ID => block_data), and then the sequence struct is assembled by iterating over incrementing IDs.
See https://github.com/cncastillo/KomaMRI.jl/blob/ae27d17326b7989d7fc1aceba01a051450e3d219/KomaMRICore/src/io/Pulseq.jl#L412
(which coincidentally is one of the main culprit lines for the slow load),
and then in get_block, we have: https://github.com/cncastillo/KomaMRI.jl/blob/ae27d17326b7989d7fc1aceba01a051450e3d219/KomaMRICore/src/io/Pulseq.jl#L642
obj["blockEvents"][i] is the mapping from block with ID==i to the data from the [BLOCKS] section for this ID.
Digging through the pulseq spec 1.4.1 (my seqs are 1.4.0, but there were no relevant changes from 1.4.1 to 1.4.0): https://pulseq.github.io/specification.pdf, we find sec 2.2:
There are no restrictions on the ordering of IDs, although sequential ordering is often implemented.

And in sec 2.7, p10 top
The sequence must declare at least one block. Any non-zero number of blocks
may be defined. The blocks are executed sequentially.

While this may be seen as a bit ambiguous ("sequentially line-by-line or by-id?"), I think together with sec 2.2, I would say it's line-by-line.
This is good, because it relieves Koma from storing the BLOCKS into a Dict and relatively expensive indirect lookups, but rather the entire [BLOCKS] section can be read into one big Int array that doesn't have to be modified, which is significantly more efficient for creation and access.
This is more or less how I achieved the optimizations described above.
3. What's next?
Since these are more invasive modifications (I had to define the == operator for sequences to ensure that the results I get form different reading functions are the same), and I could only test on my pulseq files. These are all v.1.4.0 and created via pypulseq and thus probably lack the diversity allowed by the specification. So, the obvious question is: are there pulseq test files available in Koma already? I didn't find any.
I'm happy to open a PR with the optimizations so that you can have a closer look. Let me know what you think.

These are examples (present en the writer branch) which have wave-shaped and time-shaped waveforms:

epi0.seq: RF wave-shaped
epi_se0.seq: RF time-shaped
spiral0.seq: tGrad wave-shaped
epise_rs0.seq: Grad time-shaped

Hi @gabuzi. Thank you so much for your efforts :smile:! It is very nice to see people other than me and Boris contributing to the project.
We have some Pulseq files that test different relevant aspects:

spiral-grad-uniformly-sampled.seq
epi_se-rf-time-shaped.seq
epi_rs-grad-time-shaped.seq
epi-rf-uniformly-sampled.seq

Hope this is useful.
@beorostica we should add some tests to https://github.com/cncastillo/KomaMRI.jl/pull/231 compare our k-space with MATLAB's Pulseq k-space for these examples, to ensure we are reading the same waveforms.

I looked at this again using @profview, and I found the same sources of slow down you mentioned. The culprits were type instability in get_blocks and read_blocks, the flip angle calculation, the Sequence constructor being slow, and the use of scanf in some parts. I fixed them in https://github.com/JuliaHealth/KomaMRI.jl/pull/321/commits/6176d032c7e5729d46db67d199f33a77bf942755.
The current master:

New version from #321

So now the reader is 20 times faster! :partying_face:  Thanks for detecting the problem and the great progress on the solution in #238  :smile:
In #321 we are also including some tests to be sure that we are reading the same as MATLAB's Pulseq (v1.4.X), but we still need to add some more for PyPulseq (v1.3.X) #318.
Cheers!

Nice! I am all for speed improvements. I will reopen this so I don't forget to look at this on the weekend. The difference in speed could be related to the use of the dictionaries. I will need to investigate.
Also related to performance, we recently enabled a new gl option for plot_seq that should make the plots much faster #364.  In the UI this option is automatically enabled if the sequence has more than 1000 blocks.


why can't submodules take the parent schell?

justfile
set windows-shell := ["powershell.exe", "-c"]
mod b

b.just
command:
   echo 1

Why should I install shell in b.just? I expected it to be taken from justfile.

This is a current limitation of modules. See #2252. It should be fixed, eventually T_T


Is there a auth_token timeout?

Good morning guys,
It seems I'm able to use the auth_token for login/fetching data when the time between the requests is short (a couple minutes). But when I wait a few more minutes (10-15) the script recognizes the auth.dat file but cannot login because the token seems to be expired (?). I have to delete the file manually to be able to fetch data again. Is it neccessary to do a logout every time to delete the auth.dat or am I doing something else wrong?
Thanks you!

@mands72 there is no time out. If you use logout() or login in your device it will revoke your auth.
No, its not necessary to logout() its better you keep online. Use this $snapchat->closeAppEvent();
Regards


Annotate that main returns unit in MLton backend

Regarding ML and exit, in #551 we try to enforce that main returns unit. So maybe we could annotate Unit as a type for a in the code generation of ml?

Originally posted by @b-studios in https://github.com/effekt-lang/effekt/pull/541#discussion_r1725335520

There's a warning coming from MLton that manifests if you try to use exit from the process module added in #541. Could we silence it by annotating the it to be unit?
Warning: <bogus> ~1.~1.
  Type of variable was not inferred and could not be generalized: it.
    type: ???
    in: val it = main_2612 (fn a => a)

Relevant code:
https://github.com/effekt-lang/effekt/blob/d96a17b70f99099d9a77e7059ccde99be6511421/effekt/shared/src/main/scala/effekt/generator/ml/Transformer.scala#L609-L619

Won't fix, we deleted the backend in #616


Can DDC provide more useful Pub Serve output

In WebStorm, when you run dart2js-produced JS, you see this in the Pub Serve console of WS:
[Info from Dart2JS]:
Compiling untitled4|web/main.dart...
[Info from Dart2JS]:
Took 0:00:16.951920 to compile untitled4|web/main.dart.
Build completed successfully

Nice!
But when you run DDC-produced JS, you don't see similarly clear info, and it can be hard to tell whether the JS is produced by DDC. Can nicer output be provided?

FYI, @kwalrath @jwren

Since DDC is dev-time only, we could even be more verbose, if that's helpful to devs. Perhaps we could point to the FAQ (https://webdev.dartlang.org/tools/dartdevc/faq or a shortened version of that URL). Let us know if you need help wordsmithing.

Making sure this is seen.  :) @vsmenon

@jakemac53


stack Implementation

I want to implement all the functions of stack

Push
Pop
Top
IsEmpty
IsFull

do assign me this issue under SWOC .

do assign me this issue under SWOC .

@Abhijit2505 assign me this isue

@Abhijit2505 assign me this isue

@Abhijit2505 can you assign me this issue?? I would be like to implement the stack and work on this issue!!

@Abhijit2505 can you assign me this issue?? I would be like to implement the stack and work on this issue!!


New rules?

Now not working for me on this article: http://www.dn.se/kultur-noje/fredrik-strage-jag-har-overvagt-att-jk-anmala-peter-springare-for-kulturell-appropriering/
Issue seems to be this (new?) rule.
Maybe remove .article__body--mask classes will solve it? I don't have recent skills to make plugin, just an idea.
.article__body--mask .article__premium-content {
/* display: none; */
}

I tried the page (and I actually read that article today) and it works on my machine and I'm unable to reproduce. Can you maybe screen shot the DOM-structure or something to show me what elements are blocking the article.

I've been digging a bit into this.
Are you sure that you sent the correct link? I noticed that mobil.dn.se did not work. Did you maybe access that domain?

It was the right url, same thing happened twice, but then I did a refresh and suddenly it worked. Maybe some slow loading time thing indeed. Thanks for looking into this.

Closing


HADOOP-17767. ABFS: Updates test scripts

Current test run scripts need manual update across all combinations in runTests.sh for account name and is working off a single azure-auth-keys.xml file. While having to test across accounts that span various geo, the config file grows big and also needs a manual change for configs such as fs.contract.test.[abfs/abfss] which has to be uniquely set. To use the script across various combinations, dev to be aware of the names of all the combinations defined in runTests.sh as well.
This PR updates the test scripts to address above concerns. An option to delete old test containers on the account is also added. Sample run output:
[Note - SET_ACTIVE_TEST_CONFIG will help activate the config for IDE/single test class runs]
1) SET_ACTIVE_TEST_CONFIG               4) SET_OR_CHANGE_TEST_ACCOUNT
2) RUN_TEST                             5) PRINT_LOG4J_LOG_PATHS_FROM_LAST_RUN
3) CLEAN_UP_OLD_TEST_CONTAINERS
#? 2
Enter parallel test run process count [default - 8]: 4

Set the active test combination to run the action:
1) HNS-OAuth               3) nonHNS-SharedKey        5) AllCombinationsTestRun
2) HNS-SharedKey           4) AppendBlob-HNS-OAuth    6) Quit
#? 1

Combination specific property setting: [ key=fs.azure.account.auth.type , value=OAuth ]

Activated [src/test/resources/abfs-combination-test-configs.xml] - for account: snvijayacontracttest for combination HNS-OAuth
Running test for combination HNS-OAuth on account snvijayacontracttest [ProcessCount=4]
Test run report can be seen in dev-support/testlogs/2022-10-07_05-23-22/Test-Logs-HNS-OAuth.txt

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
15m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ branch-3.3 Compile Tests _

-1 :x:
mvninstall
51m 26s
/branch-mvninstall-root.txt
root in branch-3.3 failed.

-1 :x:
compile
0m 43s
/branch-compile-hadoop-tools_hadoop-azure.txt
hadoop-azure in branch-3.3 failed.

-0 :warning:
checkstyle
0m 42s
/buildtool-branch-checkstyle-hadoop-tools_hadoop-azure.txt
The patch fails to run checkstyle in hadoop-azure

-1 :x:
mvnsite
0m 41s
/branch-mvnsite-hadoop-tools_hadoop-azure.txt
hadoop-azure in branch-3.3 failed.

-1 :x:
javadoc
0m 43s
/branch-javadoc-hadoop-tools_hadoop-azure.txt
hadoop-azure in branch-3.3 failed.

-1 :x:
spotbugs
0m 45s
/branch-spotbugs-hadoop-tools_hadoop-azure.txt
hadoop-azure in branch-3.3 failed.

+1 :green_heart:
shadedclient
3m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 30s
/patch-mvninstall-hadoop-tools_hadoop-azure.txt
hadoop-azure in the patch failed.

-1 :x:
compile
0m 30s
/patch-compile-hadoop-tools_hadoop-azure.txt
hadoop-azure in the patch failed.

-1 :x:
javac
0m 30s
/patch-compile-hadoop-tools_hadoop-azure.txt
hadoop-azure in the patch failed.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 29s
/buildtool-patch-checkstyle-hadoop-tools_hadoop-azure.txt
The patch fails to run checkstyle in hadoop-azure

-1 :x:
mvnsite
0m 28s
/patch-mvnsite-hadoop-tools_hadoop-azure.txt
hadoop-azure in the patch failed.

+1 :green_heart:
shellcheck
0m  1s

No new issues.

-1 :x:
javadoc
0m 29s
/patch-javadoc-hadoop-tools_hadoop-azure.txt
hadoop-azure in the patch failed.

-1 :x:
spotbugs
0m 32s
/patch-spotbugs-hadoop-tools_hadoop-azure.txt
hadoop-azure in the patch failed.

+1 :green_heart:
shadedclient
3m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 32s
/patch-unit-hadoop-tools_hadoop-azure.txt
hadoop-azure in the patch failed.

+0 :ok:
asflicense
0m 32s

ASF License check generated no output?

81m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5080/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5080

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs markdownlint compile javac javadoc mvninstall shadedclient spotbugs checkstyle xmllint

uname
Linux fa790f884396 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / b1b6d3a344019b94fc71cbe595bda14b6fa8d74c

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5080/1/testReport/

Max. process+thread count
88 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5080/1/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Develop authentication app

resolves #21

[x] register system
[x] login system
[x] logout system

Will continue to add page restrictions


Serverless Django?

This is a really great example but the name of the repository is a bit confusing. When I read it I expected to find some way of running django code in AWS Lambda.
It was a bit dissapointing to find that it just uses a serverless RDS instance.
Why does this example use a serverless version of RDS?

Sorry for the title misleading you. Still the sample relies only on serverless AWS services like RDS and Fargate. This example gives a guidance to run Django on AWS leverage scalability and resilience without the need of maintaining the underlying infrastructure - finally fully serverless.


Add unit-tests for the onPassword/onProgress callbacks of the API

The standard viewer implicitly depends on the onPassword and onProgress callbacks, in order to open password protected PDF files, respectively to report file loading progress. We currently have no unit-tests for this functionality, which seems unfortunate; hence this patch.
Please note: Rather than adding more unit-tests to api_spec.js, I slightly extended/reworked two existing tests. Specifically for the password test, this does not really change what we actually test, just how the test is done.

/botio unittest

Looks good. See if it's easy to address getDocumentPromise naming thing now.

I've changed this patch to use loadingTask instead of getDocumentPromise.
(The part about more general reviewing/refactoring of variable names in the code-base seemed better suited for a follow-up patch though.)
/botio unittest

Thank you for the patch.


Update the public documentation

[Enter feedback here]
According with an internal Microsoft IcM 404504056:"
Comments from Product Group:
"Mo AlHmoud (malhmoud) edited at 2023-07-12 01:31:03 CST
Gilberto Ruiz as mentioned, right now this is not possible, if you deploy a VM that does not have the tag, you cannot upgrade it later, as they are on different racks / different clusters in the backend, this is right now a known issue as mentioned, and no solution can be provided"
Could you please assist us to update the public URL to rid  of this part. ""or updated to NVMe when the VM is stopped and deallocated, provided that the VM size supports NVMe" action can't be done."
The link is https://learn.microsoft.com/en-us/azure/virtual-machines/enable-nvme-interface#launching-a-vm-with-nvme-interface
Thank you.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4716f731-96c3-1a42-c538-065d44b039a0
Version Independent ID: 7aef4bc8-c56a-c39c-a654-765008a3f1d2
Content: Enable NVMe Interface. - Azure Virtual Machines
Content Source: articles/virtual-machines/enable-nvme-interface.md
Service: virtual-machines
Sub-service: sizes
GitHub Login: @iamwilliew
Microsoft Alias: wwilliams

@gruizcr
Thanks for your feedback! We will investigate and update as appropriate.

@iamwilliew
Can you add your inputs on above query.

@gruizcr
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.

Thanks for your contribution to our documentation
We sincerely apologize for the delayed response. Unfortunately, we have been unable to review this issue in a timely manner. However, we are making overall enhancements to our content. We are closing this issue for now as there has been no activity for a while. If you feel that the problem persists, please respond to this issue with additional information.
?
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


[app] Profile might be reset

Under certain conditions the profile is reset
https://github.com/blockstack/ux/blob/69d03ee4c7c535981ddf49493984d21014603f33/packages/keychain/src/identity.ts#L53
This could happen for apps with permission publish_data and if fetching the profile fails

Thanks @friedger, this is a good point. I don't have a fix yet but we're looking into it.

Fixed in the above commits, good catch Friedger 👍


ConcurrentModificationException when running testKarateToJson

Stacktrace:
java.lang.RuntimeException: javascript evaluation failed: karate.toJson(sp, true), null
    at com.intuit.karate.ScriptTest.testKarateToJson(ScriptTest.java:1713)
Caused by: java.util.ConcurrentModificationException
    at com.intuit.karate.ScriptTest.testKarateToJson(ScriptTest.java:1713)

It looks like this is due to JsonUtils.removeKeysWithNullValues
The implementation is as following
 215             for (Map.Entry<String, Object> entry : map.entrySet()) {
 216                 Object v = entry.getValue();
 217                 if (v == null) {
 218                     map.remove(entry.getKey());
 219                 } else {
 220                     removeKeysWithNullValues(v);
 221                 }
 222             }

Here line 215 is iterating on the map while line 218 remove items from the map. Thus the CME is thrown.  A possible fix is to copy/clone the entry set or key and use the copy to iterate.
Let me know how you think about this.

@contextshuffling thanks, implementation changed in develop - I never ran into this though, so if you can check if it works for you that would be good, refer wiki for developer guide

@ptrthomas Thanks. I can confirm it fixes the problem.
Just for you reference, my workaround for this is to change
 for (Map.Entry<String, Object> entry : map.entrySet()) {
into
 for (Map.Entry<String, Object> entry : new ArrayList<>(map.entrySet())) {
Feel free to close the issue.

@contextshuffling yep, thanks ! agree that's better. I'll close this when we release 0.9.5. final

released 0.9.5


Wallet Presentation Proof: invalid JWS (jws cutoff) when tried in incognito mode

Use remote kms
Save DID KEY:
Presentation proof has invalid JWS
"proof": {
        "challenge": "5030792d-80e2-4335-9b05-5a0034c28811",
        "created": "2021-03-16T16:44:17.99-04:00",
        "domain": "demo-verifier.sandbox.trustbloc.dev",
        "jws": "eyJhbGciOiJFZERTQSIsImI2NCI6ZmFsc2UsImNyaXQiOlsiYjY0Il19..",
        "proofPurpose": "authentication",
        "type": "Ed25519Signature2018",
        "verificationMethod": "did:key:z6MknbvvxApNNLmhZV8JZXsoXcppnaF2dgG4bqN5Xi74Pisq#z6MknbvvxApNNLmhZV8JZXsoXcppnaF2dgG4bqN5Xi74Pisq"
    }

needs further investigation, ie prove/show that the WebKMS REST API for /sign is failing @sudeshrshetty @fqutishat

This has been fixed


public_path attr missing in rule web_bundle

public_path is listed as a visible attribute for rule web_bundle in README.md.  However, this attribute is not included in the implementation and consequently not carried through to the generated webpack configuration.  See https://github.com/zenclabs/bazel-javascript/blob/master/internal/web_bundle/rule.bzl#L228-L293
I have a branch that fixes this and carries the variable through to the publicPath field in the resultant webpack configuration.  I can issue a PR if you would like.

That'd be great, thank you!


jax.jit recompiles nested jitted functions

This isn't really a bug and more of a question, I guess, but who knows.
Why is f being compiled twice in this example:
x = onp.random.rand(1024).astype(onp.float32)
x = jax.device_put(x)

def f(x):
    print('f x', x)
    return np.square(x)

def g(f, x):
    print('g f', f)
    print('g x', x)
    return f(x)

def h(f, x):
    print('h f', f)
    print('h x', x)
    return f(x)

f = jax.jit(f)
g = jax.jit(g, static_argnums=(0,))
h = jax.jit(h, static_argnums=(0,))

f(x)  # will trigger compilation of f
f(x)  # reuse cache
print('')
g(f, x)  # will trigger compilation of g and another compilation of f
g(f, x)  # reuse cache
print('')
h(f, x)  # will trigger compilation of h, but uses cached f
h(f, x)  # reuse cache

f x Traced<ShapedArray(float32[1024]):JaxprTrace(level=-1/1)>

g f <function jit.<locals>.f_jitted at 0x7faa5bb22ae8>
g x Traced<ShapedArray(float32[1024]):JaxprTrace(level=-1/1)>
f x Traced<ShapedArray(float32[1024]):JaxprTrace(level=-1/2)>

h f <function jit.<locals>.f_jitted at 0x7faa5bb22ae8>
h x Traced<ShapedArray(float32[1024]):JaxprTrace(level=-1/1)>

I guess it has something to do with the level, but I don't really get why a jitted function is recompiled once it gets called from within another jitted function.

but I don't really get why a jitted function is recompiled once it gets called from within another jitted function.

Our trace-caching logic is pretty simple: it's just a @memoize decorator on the function that takes a wrapped Python callable fun and a set of abstract arguments and returns an executable XLA computation. The wrapping of fun just records what transformations have been applied to the underlying Python callable (and any auxiliary information that they need to smuggle out after the function has been called, like the tuple/list/dict tree structure of the output), and so that @memoize decorator is taking that transformation stack into account too.
What's complicated is the transformations we need to set up to guard against other traces' tracers hiding in function closures.
We can add a print(fun) to the top of the memoized xla_callable function to see why we're getting cache misses running your script. If we run just this part:
f(x)
g(f, x)

we see this (ignoring the stuff that prints out due to device_put):
jax/lib/xla_bridge.py:146: UserWarning: No GPU found, falling back to CPU.
  warnings.warn('No GPU found, falling back to CPU.')
Wrapped function:
0   : flatten_fun   ((*,),)
1   : process_env_traces   (xla_call, -1)
2   : pytree_fun_to_jaxtupletree_fun   ((*,),)
3   : argnums_partial_   ((0,), (None,))
Core: f

('f x', Traced<ShapedArray(float32[1024]):JaxprTrace(level=-1/1)>)
Wrapped function:
0   : flatten_fun   ((*,),)
1   : process_env_traces   (xla_call, -1)
2   : pytree_fun_to_jaxtupletree_fun   ((*,),)
3   : argnums_partial_   ((1,), (<jax.util.WrapHashably object at 0x7f9d54442990>, None))
Core: g

('g f', <function jit(f) at 0x7f9d54457848>)
('g x', Traced<ShapedArray(float32[1024]):JaxprTrace(level=-1/1)>)
Wrapped function:
0   : flatten_fun   ((JTupleTreeDef(child_specs=()),),)
1   : process_env_traces   (xla_call, -2)
2   : partial_eval_wrapper   ((ShapedArray(float32[1024]),),)
3   : trace_to_subjaxpr   (MasterTrace(-1,JaxprTrace),)
4   : process_env_traces   (xla_call, -1)
5   : pytree_fun_to_jaxtupletree_fun   ((*,),)
6   : argnums_partial_   ((0,), (None,))
Core: f

So the second time we're seeing f, the transform context is pretty different. It's tricky to unpack the details, but the high-level issue is that the second time we trace f we don't know if it closed over values that are traced by g. If it did, we need to generate different code (because, in effect, the computation carried out by f has more inputs the second time), even though from f's point of view those are just constants.
In this case, there's special structure here: f is a top-level function in the original Python source text, and in particular doesn't close over any values that could be traced, so we're safe from this closure issue. Maybe we could detect this special structure (by checking the Python runtime function object and noticing it has an empty closure?) and get a cache hit here.
But in general, when a function has a non-empty closure, we can't tell whether that's a benign closure (with no hidden traces) or whether that closure contains other tracers (maybe very indirectly, buried in arbitrary Python objects, including closed-over Python function objects) until we actually run the function. And at the point where we call and memoize xla_callable, we haven't actually run the function yet, so we don't know if we're safe from nested tracers, and we need to be defensive.
I'm inclined to err on the side of simplicity and not try to detect this special closure-free structure until we have a use case that needs it. (However, it's possible that @jonasrauber has already articulated possible use cases in other issues, and I just haven't grokked them yet.)
@dougalm did I get that right? Should we consider special handling of empty-closure functions, which might mean a special bind_call that is promised there are no traces in the closure? (There's a related todo in ad.py in call_transpose.)

Great explanation, thanks @mattjj. I am not sure how it relates to other issues I opened (in particular #282). I think for now it was just a question out of curiosity.

I'll re-mark this as a question and close it, but if we find a use case where we would really like cache hits here, we can reopen (or open a new issue).
Thanks for asking this!

Following up on this, now that I worked a bit more with it: calling jitted functions from within jitted functions does not seem to be a good idea… i.e. not jitting the inner function explicitly (it will still be jitted when the whole outer function is jitted) seems to improve performance… is this a general rule one can keep in mind (i.e. for maximum performance put jit only on the most outer function) or are there cases where jitting functions inside other jitted functions is advantageous?

@mattjj Curious if what @jonasrauber said is expected behavior? Should it affect performance in the general case if some "inner" functions have already been jited?


There are two 'lambert' textures tracked by git

Delete these. We've already renamed them

Merged #274


Charge move buttons

Added basic html/css layout for the buttons.

This branch is now dependent to the backend teambuilder branch. Several additional features have been added on as riders.

This branch is now dependent to the backend teambuilder branch. Several additional features have been added on as riders.


Bugfix: fix selection range handling in various scenarios

Handle linewise motions correctly
Fix issues related to EOL where the final position is<PHONE_NUMBER> related to https://github.com/neovim/neovim/issues/12071
Trim e_col before b_col , fixes single line scenarios where prefix trimming(b_col)  renders the e_col value outdated.

Thanks for the patch! really nice. I'm not really sure why github didn't notify me of this one.
One small thing, string length in lua is byte-wise, and if, for some reason, there's a multi-byte character, it can potentially lead to errors, so instead of using :len, I recommend using something like vim.fn.strwidth to get the width of a string in chars rather than bytes :slightly_smiling_face:
I'll test your branch, if you're in the mood to add this extra fix, let me know, otherwise I can probably do it myself later on after testing/merging.
Best regards,
Henry

No issues! Thanks for pointing it out, I am pretty new to lua . I have pushed the fix.

Well, then extra kudos to you for putting the effort to fixing this in a language you just started :slightly_smiling_face:
I'll merge it now.
Best regards,


Card Order Doesn't Save When Adding New Combo

When you add a new combo via the "Add as new" button, any changes to card ordering are ignored.

In this example I moved Cayth to the top and clicked "Add as new" and it didn't move.

Caused by https://github.com/jrief/django-admin-sortable2/issues/402

@GordonsKitchen this should be fixed now


[Feature Request] Is there any plan to upgrade webpack to 4?

Existing Component
否
Component Name
elementUI build
Description
I know about that  the current version of elementUI is using webpack with version of '^3.7.1' to build the elementUI', is there any plane to upgrade webpack to 4 ?

Absolutely yes 😆


[WIP] Add python modules

Building on #146. All of what I have done so far is based on or stolen completely from there.
This is still early stages - looking for feedback on what I have done so far pls

At the moment it configures and starts to build, but fails because in a .py.cpp file, we have a conflicting declaration for a sub-message of one of the messages


jetbrains.gateway: init at 223.6160.27

Description of changes
Add JetBrains Gateway. This has been tested against JetBrains JDK 17 to be working on NixOS unstable. There is also a minor fix in environment variables for the JetBrains Client to launch correctly from any of the JetBrains IDEs including this as well.
I don't have a darwin device to test this, would appreciate if darwin users can try it out as well.
Credits to https://discourse.nixos.org/t/jetbrains-gateway-client-support-on-nixos/18108 on identifying the additional environment variable to be set.
This should supersede the previous PR #148035.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

The IDE does throw a lot of exceptions though (example, shows up as a red notification in the bottom right), I don't know if this is our fault for using a bad JDK or an upstream problem.

I've mainly been using CLion, while I didn't notice the same issues there are some other problems such as the IDE can't be restarted remotely, plugins don't behave the same way as when running natively etc. The logs don't seem helpful enough to diagnose this issue. I don't have another non nixos system to verify these issues, but I think Gateway is at least usable for now, more importantly other IDEs can also launch a remote instance once the appropriate env var is set.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/jetbrains-gateway-client-support-on-nixos/18108/18


Memory leak

The tool causes Burp to consume too much memory. Even when specifying the -Xms & -Xmx options, using burp-hash will cause problems. Disabling the burp-hash plugin will cause Burp to behave normally.

@evict I know it has been a while but was wondering if you could send me a brief set of steps describing what you were doing when you noticed this. Were you just spidering a site? I'm willing to take a look to see if I can reproduce it and then identify a fix and submit a PR.

Thanks @evict. That helps a lot. I'll try and reproduce it. Did you have any other Burp Extensions installed at that time or was this the only one?

A few, Reflection, Logger++, WSDLer, think that is pretty much it.

Very helpful. Thanks.


[FLINK-5414] [table] Bump up Calcite version to 1.11

This PR resembles #3338 except that it canonizes the nullable types.
@wuchong can you please take a look?

Hi @haohui , the code looks very good to me. Thanks for investigating this, waiting for the CI pass.
@twalthr , I think you would like to have a look.

Thanks @wuchong and @haohui. I will look at it today.

@haohui your build is failing. Can you have a look at it again?

Sorry stuck with something. Will update the PR in a day or two.

Fix the unit tests.
There are two additional changes:

There are precision differences when converting double to BigDecimal. Fix the unit tests.
When registering UDFs Flink needs to distinguish nullable and non-nullable types. Patched UserDefinedFunctionUtils. We need a solution like FLINK-5177 to handle these cases systematically.

@twalthr can you please take another look? Thanks.

Thanks for the update @haohui. I fixed the decimal issues by applying changes from @wuchong's PR. I think for now we should not do the primitive checking for scalar functions, this should be part of FLINK-5177. I will merge this now. But we should definitely solve FLINK-5177 soon. I will assign it to me.


Add button to manually run the Cleanup VNC sessions task

Adds a button that clears the websockify targets file and clears the Redis cache. Might be useful for development (I've had to manually curl too many times.
TODO: Add other functions, also need to ensure that we're not leaking the VNC cleanup token.

The button is located at the bottom of the "Settings" page when signed in as an RTP.


WIP: systemd: 242 -> 243

Motivation for this change
This is the current WIP port systemd v243 to NixOS. Opening this so we can take notes and discuss things already.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

A few things we will have to change:
    * systemd now defaults to the "unified" cgroup hierarchy setup during
      build-time, i.e. -Ddefault-hierarchy=unified is now the build-time
      default. Previously, -Ddefault-hierarchy=hybrid was the default. This
      change reflects the fact that cgroupsv2 support has matured
      substantially in both systemd and in the kernel, and is clearly the
      way forward. Downstream production distributions might want to
      continue to use -Ddefault-hierarchy=hybrid (or even =legacy) for
      their builds as unfortunately the popular container managers have not
      caught up with the kernel API changes.

We will have to set this build flag, otherwise things like docker and kubernetes will not work anymore. It is going to take quite a bit more time before docker actually moves to cgroupsv2.  Fedora 31 has dropped cgroupsv1 support and has some information about their migration here https://fedoraproject.org/wiki/Changes/CGroupsV2 and here https://github.com/opencontainers/runc/issues/654#issuecomment-524647286
I think we're better of to support cgroupsv1 for a bit longer as I think dropping docker is a change people will not like.  Lets see how this pans out for Fedora Rawhide first ;)
    * Man pages are not built by default anymore (html pages were already
      disabled by default), to make development builds quicker. When
      building systemd for a full installation with documentation, meson
      should be called with -Dman=true and/or -Dhtml=true as appropriate.
      The default was changed based on the assumption that quick one-off or
      repeated development builds are much more common than full optimized
      builds for installation, and people need to pass various other
      options to when doing "proper" builds anyway, so the gain from making
      development builds quicker is bigger than the one time disruption for
      packagers.

I'm not sure if this is an issue, but we should stack generating man pages isn't broken
    * When a [Match] section in .link or .network file is empty (contains
      no match patterns), a warning will be emitted. Please add any "match
      all" pattern instead, e.g. OriginalName=* or Name=* in case all
      interfaces should really be matched.

This will cause issues for us.  We currently generate empty [Match] statements when useNetworkd=true. See https://github.com/NixOS/nixpkgs/issues/18962

systemd-pstore seems to be a new services that we might want to support:

https://www.phoronix.com/scan.php?page=news_item&px=Systemd-Pstore-Service
https://www.freedesktop.org/software/systemd/man/systemd-pstore.html

We need to provide both /etc/system/pstore.conf and a matching unit file. As always we can orientate around the upstream examples that will be in $out/share/factory.
I am not sure if it is worth putting the effort for pstore into this PR already or if we just do that afterwards. I still have hopes to include this in 19.09. The deadline is tight but we might be lucky if systemd didn't change that much.

Maybe, but I wouldn't make it a blocker.  For example,  systemd-portabled doesn't work on NixOS either and that hasn't blocked previous releases

@lheckemann @disassembler (the 19.09 RMs)
What would be required to have this included in 19.09? So far my tests show that this seems to be fairly low impact. I'll work on this during the weekend to see if that holds true.
It would get us down to maintaining one less systemd version during the release cycle (for most of the time anyway).

That would be nice! Since the branch-off is slated for tomorrow, time's pretty short though.

I think I am done here. Rebased onto master and restart my private hydra to test all the NixOS VM tests.
My laptop is running on this PR now and so far it looks fine. Looking for testers with more advanced use cases: @arianvp @fpletz @flokli @Mic92 etc…

@Mic92 addressed your comments. Anything else?

@andir my laptop is still rebuilding... Just from looking at the changes, it seems fine to me.

Unless there is some negative feedback I'll merge this into staging within the afternoon (UTC).

If this should still target 19.09, merging into staging probably won't get it into the release-19.09 branch, wouldn't it? Or do we branch-off staging to staging-19.09 as well?

I defer that to the release managers. If it doesn't land anyway they can indicate if they want us to backport into 19.09. I would just get this into unstable now no matter if it reaches 19.09 in the end.

The branch-off hasn't happened yet, I haven't heard from @disassembler but didn't want to go ahead with it without him. I'm not sure if we want to do one more staging merge cycle before the branch-off, but if not I'd be all for porting this onto staging-19.09 since it brings us closer to upstream and will save us divergence work.

Half a day from now the current staging-next cycle (https://github.com/NixOS/nixpkgs/pull/68244) should be finished building. I suggest merging that and branching-off. We will then have a staging-19.09 again and the systemd change could be cherry-picked in.


Review TokenSearcher and token address registration

Resolved: https://github.com/trustwallet/blockatlas/pull/1341

Resolved: https://github.com/trustwallet/blockatlas/pull/1341


The Links of Datasets  and Pretrained Model Are Invalid.

Dear Marcus:
I have found that The Links of the Datasets and Pretrained Model provided on the Readme file are Invalid. So can you update it?
Thank you!

Dear Marcus: I have found that The Links of the Datasets and Pretrained Model provided on the Readme file are Invalid. So can you update it? Thank you!

Check #3


Add support for clean documentation URLs

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1265
Originally created by @gtsiolis on 2019-11-05 13:45:26

Problem
Currently, documentation URLs append the .html suffix by default. This is how VuePress works out of the box.
This makes the URLs a) longer and b) more prone to error.
Proposal
Let's add vuepress-plugin-clean-urls which is an official VuePress plugin to support for clean urls.
For example, see some before and after links:

https://meltano.com/docs/command-line-interface.html (Before)
https://meltano.com/docs/command-line-interface (After)
https://meltano.com/docs/installation.html (Before)
https://meltano.com/docs/installation (After)

Benefits
This will make URLs shorter which will also benefit the CLI user experience and less prone to error.
Risk

As mentioned in the plugin documentation this could require a small configuration change in the deployment environment.
The recent refactor of the docs in https://gitlab.com/meltano/meltano/merge_requests/995 could require more configuration for this.
By default, the Markdown extension for VuePress supports redirecting to clean links which will help not break any existing link.

Next steps
Once this is done, let's plan to replace links in docs, CLI, app, etc.

View 4 previous comments from the original issue on GitLab


Hacks Week #2

Lists, Dictionaries, Iteration Hacks
HTML Table
Organized tags
Front Page with Color
Taiyo and I pair shared the theme change and helped make a HTML table
Theme Change Picture

Thoughts...

Changed the background color
HTML table works
Theme properly changed

Overall Grade

3.0+

Closing Statement
Your theme change is quite cool and the background color is pleasant.


Grabing activity from Steam

Steam api has option to see what game user currently playing
It requires steam account id (easily obtainable) and API key. This key is accessible here for any logged in user and accepts any string in "domain" field. It's not unreasonable to ask user to get their own, since target audience already nerds would be able download, compile and run this project
http://api.steampowered.com/ISteamUser/GetPlayerSummaries/ returns JSON containing gameid - steam id of game and
gameextrainfo - name of the game.
By altering searching of DetectableDB it is possible to search by steam id if provided or by game name, which are commonly same between Steam and Discord Verified games list
If game not found in this list it still can be used as custom activity
Con of this process is not having pid of game process, which is part of existing code base, but I hope it can be turned off and replaced with gameid field not existing or analyzing child processes of steam.
I understand it's not easy not implement, but without this arrpc on linux is kinda useless, cause detectable.json contains 5 linux executables: csgo ,terraria and 3 nonames, not even Dota2

Interesting idea but quite specific. Generally supporting Wine (#35) would probably be nicer but this could also be done in addendum.


🚧(Built-in commands): improve presentation of help command

The help command used to be very busy due to the default settings in
marked-terminal. With these changes, it is more cleaner and easy on the eyes.

Coverage decreased (-0.1%) to 88.615% when pulling e4129803d1ec7a92384523c950f5ea1df70abd72 on israelroldan:help-cmd-facelift into 21748fdd91f071ec8486af53d1124ba785a57041 on dongryphon:master.

Coverage decreased (-0.1%) to 88.615% when pulling e4129803d1ec7a92384523c950f5ea1df70abd72 on israelroldan:help-cmd-facelift into 21748fdd91f071ec8486af53d1124ba785a57041 on dongryphon:master.

Coverage increased (+0.1%) to 88.877% when pulling 221a812d4853f7c0463d88d58604d5de63aa8e1a on israelroldan:help-cmd-facelift into 21748fdd91f071ec8486af53d1124ba785a57041 on dongryphon:master.

Coverage increased (+0.1%) to 88.877% when pulling 11e78f23fee7eedf080d1f3e113663a80f7a8d8d on israelroldan:help-cmd-facelift into 21748fdd91f071ec8486af53d1124ba785a57041 on dongryphon:master.


Add unit tests for com.mossle.core.util.EncodeUtils

I've analysed your codebase and noticed that com.mossle.core.util.EncodeUtils is not fully tested.
I've written some tests for the methods in this class with the help of Diffblue Cover.
Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important in a subsequent PR.

Hi @xuhuisheng just following up and wondering if you would like me to make any changes to the PR?


Set bii-server to a commit that git can find

The install documentation for biicode says to do:
git clone https://github.com/biicode/biicode.git
cd biicode
git submodule update --init --recursive

At this point I receive:
Submodule 'bii-server' (https://github.com/biicode/bii-server.git) registered for path 'bii-server'
Submodule 'client' (https://github.com/biicode/client.git) registered for path 'client'
Submodule 'common' (https://github.com/biicode/common.git) registered for path 'common'
Cloning into bii-server...
remote: Counting objects: 158, done.
remote: Total 158 (delta 0), reused 0 (delta 0), pack-reused 158
Receiving objects: 100% (158/158), 114.38 KiB, done.
Resolving deltas: 100% (11/11), done.
fatal: reference is not a tree: c6fa3a4c1812d102c6049283f98d1a3daa2b88d3
Unable to checkout 'c6fa3a4c1812d102c6049283f98d1a3daa2b88d3' in submodule path 'bii-server'

It looks like the missing commit is on Github, but it's not an ancestor to any of the branches in the bii-server repository, so it doesn't come along when someone clones the repository.
The easiest thing to do seems to be to point to the current master instead, which is what I'm doing here.

Thanks @adamnovak, I have the same problem here.

I have the same problem


NotFoundException when a field is missing

I am trying to produce chart of z-spread against next call / maturity for a list of all outstanding Contingent Convertible bonds. This requires to get MATURITY and /or NXT_CALL_DT fields for a list of bonds (where I do not know beforehand which bond has missing which field).
The problem is that pdblp.ref() raises exception whenever a field does not exist for given security (e.g. MATURITY for perpetual bond).
Example (3 bonds, the first having both fields, the second missing MATURITY and the last missing NXT_CALL_DT):
tickers = ["EJ8189684 Corp", "EI862261 Corp", "EJ319090 Corp"]
fields = ["MATURITY", "NXT_CALL_DT"]
df = con.ref(tickers, fields)

raises
NotFoundException: Attempt to access unavailable sub-element 'MATURITY' of element 'fieldData'. (0x0006000d)
Shouldn't pdblp.ref just ignore missing field (or return NaN)? This is exactly what Excel or Rbplapi are doing:
bdp(securities=c("EJ8189684 Corp", "EI862261 Corp", "EJ319090 Corp"),
        fields=c("MATURITY", "NXT_CALL_DT"))
                 MATURITY NXT_CALL_DT
EJ8189684 Corp 2025-09-18  2020-09-18
EI862261 Corp        <NA>  2017-06-29
EJ319090 Corp  2022-08-17        <NA>

For reference. See below the debug printout:
DEBUG:root:Sending Request:
 ReferenceDataRequest = {
    securities[] = {
        "EJ8189684 Corp", "EI862261 Corp", "EJ319090 Corp"
    }
    fields[] = {
        "MATURITY", "NXT_CALL_DT"
    }
    overrides[] = {
    }
}
DEBUG:root:Message Received:
 ReferenceDataResponse = {
    securityData[] = {
        securityData = {
            security = "EJ8189684 Corp"
            eidData[] = {
            }
            fieldExceptions[] = {
            }
            sequenceNumber = 0
            fieldData = {
                MATURITY = 2025-09-18
                NXT_CALL_DT = 2020-09-18
            }
        }
        securityData = {
            security = "EI862261 Corp"
            eidData[] = {
            }
            fieldExceptions[] = {
                fieldExceptions = {
                    fieldId = "MATURITY"
                    errorInfo = {
                        source = "144::bbdbd4"
                        code = 9
                        category = "BAD_FLD"
                        message = "Field not applicable to security"
                        subcategory = "NOT_APPLICABLE_TO_REF_DATA"
                    }
                }
            }
            sequenceNumber = 1
            fieldData = {
                NXT_CALL_DT = 2017-06-29
            }
        }
        securityData = {
            security = "EJ319090 Corp"
            eidData[] = {
            }
            fieldExceptions[] = {
                fieldExceptions = {
                    fieldId = "NXT_CALL_DT"
                    errorInfo = {
                        source = "144::bbdbd4"
                        code = 9
                        category = "BAD_FLD"
                        message = "Field not applicable to security"
                        subcategory = "NOT_APPLICABLE_TO_REF_DATA"
                    }
                }
            }
            sequenceNumber = 2
            fieldData = {
                MATURITY = 2022-08-17
            }
        }
    }
}

Note that the issue is related to #6 but not the same. The problem is not that we are naming columns of an empty DataFrame like in issue #6 .

This is a use case I had not considered. I will take a look and see what is involved to allow this.

I'm wondering what your thoughts on the expected behavior should be in a couple
scenarios. When the field is truly non existent, not just not applicable
for a given security, I would expect to get an error. e.g.
con.ref(["EJ8189684 Corp"], ["not_a_real_field"])

DEBUG:root:Message Received:
 ReferenceDataResponse = {
    securityData[] = {
        securityData = {
            security = "EJ8189684 Corp"
            eidData[] = {
            }
            fieldExceptions[] = {
                fieldExceptions = {
                    fieldId = "not_a_real_field"
                    errorInfo = {
                        source = "161::bbdbd18"
                        code = 9
                        category = "BAD_FLD"
                        message = "Field not valid"
                        subcategory = "INVALID_FIELD"
                    }
                }
            }
            sequenceNumber = 0
            fieldData = {
            }
        }
    }
}

whereas when the field is not applicable I agree returning a NaN is reasonable,
e.g.
con.ref(["EI862261 Corp"], ["MATURITY"])

DEBUG:root:Message Received:
 ReferenceDataResponse = {
    securityData[] = {
        securityData = {
            security = "EI862261 Corp"
            eidData[] = {
            }
            fieldExceptions[] = {
                fieldExceptions = {
                    fieldId = "MATURITY"
                    errorInfo = {
                        source = "161::bbdbd2"
                        code = 9
                        category = "BAD_FLD"
                        message = "Field not applicable to security"
                        subcategory = "NOT_APPLICABLE_TO_REF_DATA"
                    }
                }
            }
            sequenceNumber = 0
            fieldData = {
            }
        }
    }
}

These behaviours are both consistent with Rblpapi. When given a non existent ticker, my preference would be to throw an error (Currently the behaviour is buggy in the sense that it ignores the error and returns a DataFrame without the erroneous ticker, unless all tickers are erroneous in which case it fails later when attempting to assign column names to an empty DataFrame). I can't think of any use cases for wanting to pass in erroneous tickers? @tschm you had suggested a fix for this in #6, I'm wondering if you have any example use cases for this in mind?
con.ref(["EJ8189684 Corp", "not_a_ticker"], ["MATURITY", "NXT_CALL_DT"])

DEBUG:root:Message Received:
 ReferenceDataResponse = {
    securityData[] = {
        securityData = {
            security = "EJ8189684 Corp"
            eidData[] = {
            }
            fieldExceptions[] = {
            }
            sequenceNumber = 0
            fieldData = {
                MATURITY = 2025-09-18
                NXT_CALL_DT = 2020-09-18
            }
        }
        securityData = {
            security = "not_a_ticker"
            eidData[] = {
            }
            securityError = {
                source = "161::bbdbd10"
                code = 15
                category = "BAD_SEC"
                message = "Unknown/Invalid security [nid:161] "
                subcategory = "INVALID_SECURITY"
            }
            fieldExceptions[] = {
            }
            sequenceNumber = 1
            fieldData = {
            }
        }
    }
}

Out[29]:
           ticker        field       value
0  EJ8189684 Corp     MATURITY  2025-09-18
1  EJ8189684 Corp  NXT_CALL_DT  2020-09-18

I agree with you Matthew: I would expect ref() to either pass or return NaN for NOT_APPLICABLE_TO_REF_DATA and raise exception in case of non existent ticker or field.

This is fixed in 659c0d2a8af7f8d24cf53adeb5f3790774160cdc

Hi, is there a similar fix for con.bulkref? I am having the same issue where a field does not exist for a subset of securities I'm trying to query, which throws an error for the entire thing.
test = ['594918BD5 Corp','594918BE3 Corp','88428LAA0 Corp']
bbg = con.bulkref(test, ['INDEX_LIST'])
The query works for the first two securities but not the last, so the whole query fails instead of just returning NaN where appropriate (error reproduced below).
    securityData = {
        security = "88428LAA0 Corp"
        eidData[] = {
        }
        fieldExceptions[] = {
        }
        sequenceNumber = 2
        fieldData = {
        }
    }
}

}
Traceback (most recent call last):
File "", line 1, in
bbg = con.bulkref(test, ['INDEX_LIST'])
File "C:\Temp\Jay\Anaconda\envs\py35\lib\site-packages\pdblp\pdblp.py", line 378, in bulkref
data = self._parse_bulkref(flds)
File "C:\Temp\Jay\Anaconda\envs\py35\lib\site-packages\pdblp\pdblp.py", line 404, in _parse_bulkref
if not fieldData.getElement(fld).isArray():
File "C:\Temp\Jay\Anaconda\envs\py35\lib\site-packages\blpapi\element.py", line 347, in getElement
_ExceptionUtil.raiseOnError(res[0])
File "C:\Temp\Jay\Anaconda\envs\py35\lib\site-packages\blpapi\exception.py", line 145, in raiseOnError
_ExceptionUtil.raiseException(errorCode, description)
File "C:\Temp\Jay\Anaconda\envs\py35\lib\site-packages\blpapi\exception.py", line 137, in raiseException
raise errorClass(description, errorCode)
NotFoundException: Attempt to access unavailable sub-element 'INDEX_LIST' of element 'fieldData'. (0x0006000d)

I agree with you Matthew: I would expect ref() to either pass or return NaN for NOT_APPLICABLE_TO_REF_DATA and raise exception in case of non existent ticker or field.

I would have to slightly disagree. While it is good to reference Excel as to what behavior to expect, the batch nature of pdblp's requests encourage some deviations from Excel. For example, you might have a large list of tickers, say 200, and as long as 1 of them is not supported (a bad strike for an option chain, for example) then the request won't resolve. I believe ideal behavior would be to handle bad tickers internally and return everything else. I might be wrong but I think it's worth a quick discussion :)

Just to follow up that i would also would like to see consistent behaviour with excel so if an invalid ticker were to be sent then it would return nan for that one but the rest would be fine. The use case as mentioned is when we have a large array of tickers that are not maintained as well as we would like due to changes, we would still like it to return those that are valid. Maybe an optional parameter such as ignore_invalid_tickers would provide full flexibility?


ReactiveCommand in current 8.0 alpha concurrency problem

PLEASE, reproduce the issue with this solution:
WpfApp1.zip
Do you want to request a feature or report a bug?
It's a bug
What is the current behavior?
The execution of the Command throws an InvalidOperationException related to concurrency.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
Execute the attached demo (VS 2017 Preview and .NET 4.7.1, if possible, although it should fail in previous versions)
What is the expected behavior?
The Command  should execute without problems.
What is the motivation / use case for changing the behavior?
Well, it's simply the way a ReactiveCommand should behave. We simply expect it to work :)
It works perfectly in the latest stable version.
Please, check the question in Stack Overflow: https://stackoverflow.com/questions/46574940/reactiveui-command-concurrency-webclient

Thanks for the repro, @SuperJMN. I've found that the problem is related to the (new) separation of WPF functionality from ReactiveUI core. Without the reactiveui-wpf package, you don't have the correct initialization logic for the platform. Thus, you end up with the RxApp ambient contexts incorrectly configured, including using the wrong schedulers. Those schedulers are not using the correct thread, so things go 💥
By installing reactiveui-wpf, the problem is solved. I suspect there's something better we can do about the experience here, but I am unsure what it is just now. I'll open a separate issue to track.

See #1499


Trying to test task_proxy move assignment

Codecov Report

Merging #12 (ee43e0b) into main (723c3cb) will increase coverage by 1.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   89.08%   90.13%   +1.04%
==========================================
  Files           3        3
  Lines         678      679       +1
  Branches      186      186
==========================================
+ Hits          604      612       +8
+ Misses         16        8       -8
- Partials       58       59       +1

Flag
Coverage Δ

unittests
90.13% <100.00%> (+1.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

lib/public/task_pool/task_pool.h
92.87% <100.00%> (-0.20%)
:arrow_down:

lib/task_pool.cpp
82.70% <0.00%> (+4.32%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update to 0.4

String -> AbstractString
Nothing -> Void
Union() -> Union{}

I just saw the other PRs


feat: Update hurl files

Feature Request
Describe the Feature Request

Update 47 hurl files to make them functional
Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

[ ] Yes
[ ] No

merged


feat: added unit tests to improve test coverage

/approve

Codecov Report

Merging #6 (21398ff) into main (baf2f5d) will increase coverage by 22.42%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main       #6       +/-   ##
===========================================
+ Coverage   63.12%   85.55%   +22.42%
===========================================
  Files           5        5
  Lines         179      180        +1
===========================================
+ Hits          113      154       +41
+ Misses         55       18       -37
+ Partials       11        8        -3

Flag
Coverage Δ

unittests
85.55% <100.00%> (+22.42%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

transformers.go
100.00% <ø> (+8.10%)
:arrow_up:

new.go
95.23% <100.00%> (+63.03%)
:arrow_up:

csvprocessor.go
73.77% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Datepicker Popup restore value problem

Hi,
I have an issue with the datepicker popup. In the version 0.13.0, the ng-model accepted the variable as string
<input type="text" class="form-control" datepicker-popup="yyyy-MM-dd" ng-model="dt" is-open="opened" datepicker-options="dateOptions" ng-required="true" close-text="Close" /
$scope.dt = '2011-05-25'
http://plnkr.co/edit/GkwxGzMce2ZiRNuKWetK?p=preview
I have updated to use latest version 1.3.2, the ng-model need to be initiated as Date object to make the value restore in the input, otherwise the input is empty.
 <input type="text" class="form-control" uib-datepicker-popup="yyyy-MM-dd" ng-model="dt" is-open="opened" ng-required="true" close-text="Close" />
http://plnkr.co/edit/1VJzkK0HMdLn4yPxzSNx?p=preview
Is there anyway to make the datepicker work with the string value as input?

We do not support strings anymore because there are timezone issues that manifest that are unfixable, and increase the complexity of the internals tremendously.
I would recommend instantiating it as a date before binding to the view.