Optimize eth_getLogs

The current implementation of eth_getLogs is not optimized well. The method requires data that is not returned by the Mirror Node in the endpoints that return Log data -
- contracts/results/logs
- contracts/:contractId/results/logs
The missing fields are taken from /contracts/:contractId/results/:timestamp and are the following:
- block_hash
- block_number
- transaction_index
- hash
The problem is that every single Log object requires a request to be made to the mirror node. This greatly increases the total number of mirror node requests.
As a solution we suggest to modify the REST endpoints contracts/results/logs and contracts/:contractId/results/logs to return the missing data but only if a flag is set to true - this should ensure that the additional queries do not impact the performance of existing functionallity that relies on those endpoints.
For hash and transaction_index it should be possible to perform a join Transaction on Transaction.consensus_timestamp = ContractLog.consensus_timestamp in the existing query to the ContractLog table.
For block_hash and block_number it would be more complicated, since the RecordFile.timestamp does not necessarily match the timestamp of the Log. One solution would be to call recordFileService.getRecordFileBlockDetailsFromTimestamp for every log object. This is not ideal, but would still reduce the total number of queries made by the Mirror Node for a single execution of eth_getLogs.
If those changes are made to the Mirror node we could optimize eth_getLogs to only perform 1 or 2 Mirror Node requests.
Another problem we noticed is that the endpoint blocks/:blockHash often times takes longer than 10 seconds to execute, which results in a TIMEOUT error thrown by Axios in the Relay.

Theoretically if the contract_log table in MR had a record_file_index field it would be possible to use a JOIN in a query when selecting multiple logs and easily retrieve their respective block data.

Regarding the poor performance of /blocks/:blockHash that is caused by a query that uses a LIKE statement to find the record file based on a given hash. It supports both 32 and 48 byte hashes. If the record_file table had a field for the 32 byte variant of the hash, then the LIKE  statement could be dropped in favour of a simple =.

To sum up: to solve the described issues we propose the following changes to the mirror node DB structure:

Add a referance in contract_log to record_file.index
Add a 32 byte hash field in record_file

Opened a ticket to address lack of block/transaction data in logs: https://github.com/hashgraph/hedera-mirror-node/issues/4217


[PoC] smarter CommandBus and QueryBus return types

I've experimented a bit and it seems that by some TypeScript tricks we are able to create smarter versions of CommandBus and QueryBus where execute method can infer return type basing on the command passed through argument.
I haven't tested the changes in runtime, it is just a proof of concept where you can try yourself with your IDE if type suggestions got better.

Closing this as I will create better implementation for this, that bases on better typed node-common


SPFx building ApplicationCustomizer step "write-manifests" cannot find manifest.json

Category

[x] Bug

Describe the bug
After upgrading from 1.8.1  to 1.10.0 gulp serve stopped to work and freezes on step "write-manifests".  In this task, the default configuration takes precedence. Consider removing the initialPage property. [19:37:32] [spfx-serve] To load your scripts, use this query string: ?debug=true&noredir=true&debugManifestsFile=https://localhost:4321/temp/manifests.js [19:37:33] Starting server... Starting api server on port 5432. Registring api: /workbench Registring api: */* [19:37:34] Finished subtask 'spfx-serve' after 2.32 s [19:37:35] Starting subtask 'pre-copy'... [19:37:35] Finished subtask 'pre-copy' after 127 ms [19:37:35] Starting subtask 'copy-static-assets'... [19:37:35] Starting subtask 'sass'... [19:37:35] Server started https://localhost:4321 [19:37:35] LiveReload started on port 35729 [19:37:35] Running server [19:37:36] Finished subtask 'sass' after 1.27 s [19:37:36] Starting subtask 'tslint'... [19:37:36] [tslint] Examining C:\Itera.Online.SPFx.AppCustomizer\tsconfig.json [19:37:36] [tslint] Found tsconfig.extends property<EMAIL_ADDRESS>It appears to be a relative path. Resolved to<EMAIL_ADDRESS>[19:37:36] [tslint] Examining<EMAIL_ADDRESS>[19:37:36] [tslint] Found tsconfig.extends property ./tsconfig-base.json. It appears to be a relative path. Resolved to<EMAIL_ADDRESS>[19:37:36] [tslint] Examining<EMAIL_ADDRESS>[19:37:36] [tslint] Found rush-stack compiler at<EMAIL_ADDRESS>[19:37:40] [tslint] tslint version: 5.12.1 [19:37:40] Starting subtask 'tsc'... [19:37:40] [tsc] typescript version: 3.3.4000 [19:37:42] Finished subtask 'copy-static-assets' after 6.7 s [19:37:56] Finished subtask 'tslint' after 20 s [19:37:56] Finished subtask 'tsc' after 16 s [19:37:56] Starting subtask 'substitute-config'... [19:37:56] Finished subtask 'substitute-config' after 32 ms [19:37:56] Starting subtask 'post-copy'... [19:37:56] Finished subtask 'post-copy' after 578 μs [19:37:56] Starting subtask 'collectLocalizedResources'... [19:37:56] [collectLocalizedResources] 1 localized resources defined. [19:37:56] [collectLocalizedResources] Found file "lib/extensions/iteraBranding/loc/en-us.js", identified as locale "en-us" [19:37:56] Finished subtask 'collectLocalizedResources' after 8.13 ms [19:37:56] Starting subtask 'configure-webpack'... [19:37:59] [configure-webpack] 1 entries specified. [19:37:59] [configure-webpack] 21 externals specified. [19:37:59] [configure-webpack] 1 localized resources specified. [19:37:59] Finished subtask 'configure-webpack' after 2.49 s [19:37:59] Starting subtask 'webpack'... [19:38:13] Finished subtask 'webpack' after 14 s [19:38:13] Starting subtask 'configure-webpack-external-bundling'... [19:38:13] [configure-webpack-external-bundling] No localized resources specified, nothing to do. [19:38:13] Finished subtask 'configure-webpack-external-bundling' after 1.88 ms [19:38:13] Starting subtask 'copy-assets'... [19:38:13] Finished subtask 'copy-assets' after 265 ms [19:38:13] Starting subtask 'write-manifests'... [19:38:13] [write-manifests] Using debug locale: en-US [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\decorators". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\decorators\node_modules\tslib". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\gulp". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\generator-sharepoint". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-application-base". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-component-base". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-core-library". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-lodash-subset". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@types\lodash". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-lodash-subset\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-lodash-subset\node_modules\tslib". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\node-core-library". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-module-interfaces". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@types\es6-promise". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-core-library\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-diagnostics". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\jest". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\tslib". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-dynamic-data". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-dynamic-data\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-dynamic-data\node_modules\tslib". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-http". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\microsoft-graph-client". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@types\adal-angular". We'll try to get each manifest separately [19:38:13] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\adal-angular". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\msal". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-http\node_modules\tslib". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-polyfills". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-polyfills\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\es6-collections". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-polyfills\node_modules\es6-promise". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-polyfills\node_modules\tslib". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-polyfills\node_modules\whatwg-fetch". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\whatwg-url". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-build-web". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\whatwg-fetch". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-loader". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\loader-raw-script". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\office-ui-fabric-react-bundle". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@types\react". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\office-ui-fabric-react-bundle\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@uifabric\icons". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\office-ui-fabric-react-bundle\node_modules\office-ui-fabric-react". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\react". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\react-dom". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\office-ui-fabric-react-bundle\node_modules\tslib". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\load-themed-styles". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-odata-types". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-page-context". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-page-context\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-page-context\node_modules\tslib". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@types\react-dom". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@types\requirejs". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-loader\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@uifabric\utilities". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\exports-loader". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-loader\node_modules\office-ui-fabric-react". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\raw-loader". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\requirejs". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-loader\node_modules\tslib". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-component-base\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-extension-base". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-extension-base\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:14] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-search-extensibility". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-search-extensibility\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-application-base\node_modules\tslib". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-client-base". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-client-base\node_modules\@types\es6-promise". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-client-base\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-client-base\node_modules\es6-promise". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\tiny-sha256". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@types\chai". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@types\mocha". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-dialog". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-webpart-base". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-webpart-base\node_modules\@microsoft\load-themed-styles". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-property-pane". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-property-pane\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-property-pane\node_modules\office-ui-fabric-react". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-property-pane\node_modules\tslib". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\teams-js". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@types\office-js". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-webpart-base\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-webpart-base\node_modules\office-ui-fabric-react". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-webpart-base\node_modules\tslib". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-dialog\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-dialog\node_modules\office-ui-fabric-react". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-office-ui-fabric-core". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-office-ui-fabric-core\node_modules\@types\webpack-env". We'll try to get each manifest separately [19:38:15] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\office-ui-fabric-core". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-office-ui-fabric-core\node_modules\tslib". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@pnp\sp". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\natives". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\office-ui-fabric-react". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\typescript". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-webpart-workbench". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@microsoft\sp-tslint-rules". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\@types\es6-collections". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in<EMAIL_ADDRESS>We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\ajv". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in "C:\Itera.Online.SPFx.AppCustomizer\node_modules\enzyme". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in ".". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in ".". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in ".". We'll try to get each manifest separately [19:38:16] [write-manifests] Unable to get "manifests.json" file for project in ".". We'll try to get each manifest separately
Developer environment
package.json
"dependencies": {     "@microsoft/decorators": "~1.10.0",     "@microsoft/generator-sharepoint": "~1.10.0",     "@microsoft/sp-application-base": "~1.10.0",     "@microsoft/sp-client-base": "^1.0.0",     "@microsoft/sp-core-library": "~1.10.0",     "@microsoft/sp-dialog": "~1.10.0",     "@microsoft/sp-lodash-subset": "~1.10.0",     "@microsoft/sp-office-ui-fabric-core": "~1.10.0",     "@microsoft/sp-webpart-base": "~1.10.0",     "@pnp/sp": "^2.0.3",     "@types/webpack-env": ">=1.12.1 <1.14.0",     "es6-collections": "^0.5.6",     "natives": "^1.1.6",     "office-ui-fabric-react": "6.189.2",     "react": "16.8.5",     "react-dom": "16.8.5",     "typescript": "3.3.1"   },   "devDependencies": {     "@microsoft/sp-build-web": "1.10.0",     "@microsoft/sp-module-interfaces": "1.10.0",     "@microsoft/sp-webpart-workbench": "1.10.0",     "@microsoft/sp-tslint-rules": "1.10.0",     "@types/chai": "3.4.34",     "@types/es6-collections": "^0.5.31",     "@types/es6-promise": "0.0.33",     "@types/mocha": "2.2.48",     "@types/react": "16.8.8",     "@types/react-dom": "16.8.3"<EMAIL_ADDRESS>"0.3.5",     "ajv": "~5.2.2",     "enzyme": "2.9.1",     "fs": "0.0.1-security",     "gulp": "~3.9.1",     "gulp-clean-css": "^3.10.0",     "gulp-concat": "^2.6.1",     "gulp-sass": "^3.2.1",     "gulp-spsync-creds": "2.3.4",     "gulp-string-replace": "^0.4.0",     "gulp-util": "^3.0.8",     "webpack-bundle-analyzer": "^3.6.0",     "yargs": "8.0.2"   }
tsconfig
{   "extends"<EMAIL_ADDRESS>  "compilerOptions": {     "target": "es5",     "forceConsistentCasingInFileNames": true,     "module": "esnext",     "moduleResolution": "node",     "noUnusedLocals": false,     "inlineSources": false,     "jsx": "react",     "declaration": true,     "sourceMap": true,     "strictNullChecks": false,     "experimentalDecorators": true,     "skipLibCheck": true,     "outDir": "lib",     "typeRoots": [       "node_modules/@types",       "node_modules/@microsoft"     ],     "types": [       "es6-promise",       "webpack-env"     ],     "lib": [       "es5",       "dom",       "es2015.collection"     ]   },   "exclude": [     "node_modules",     "lib"   ] }

OS: Windows 10
Framework:  Node.js v10
Tooling:  VS Code, SPFx v1.10.0

Removing "fs": "0.0.1-security" from packages and reinstalling solved the issue. As I saw some other packages uses "fs-extra" and it cause some conflict probably.


How to validate when blur a component.

Hello,
I have add v-validate="'required'"  in input tag <input> and <multiselect> and <datepicker>.
https://github.com/monterail/vue-multiselect
https://github.com/charliekassel/vuejs-datepicker
This require validation works well with <input> tag after we blur it without fill data.
But this require validation doesn't work with <multiselect> and <datepicker> after I blur them without choose data.
How can I make it works like <input>?
Thanks.

unless these component emit the blur event, you cannot validate them on blur. However there are  alternative events that might give you the same behavior using data-vv-validate-on attribute to override the default events.
For the multiselect it emits close event when the dropdown is closed which is also when the user leaves the control.
<multiselect data-vv-validate-on="input|close" ...>

For the date-picker you can instead validate on closed since that event emits when the user leaves the control.
<datepicker data-vv-validate-on="input|closed" ...>


Unskipable fullscreen take over Ad

MAX Module Version
4.1.3
React Native Version
0.66.5
Device/Platform Info
iOS
Current Behavior
My users are complaining about this Ad that takes over the screen and cannot be skipped after a timer or closed. They have to restart the app to use it.

Expected Behavior
Give the developer an option to only have timed skippable or skippable ads to give users a better experience.
How to Reproduce
Click on the Cooking Madness- Kitchen Frenzy ad
Additional Info
No response

Hey @sarons - thanks for raising this. We're aware of the issue with the rogue ad, and will notify you when a fix is scaled.

Hi @sarons - we've just pushed a fix to prevent this from happening again. Thanks for again for reporting this issue!


Ideas for modules and their layout

Opening this issue to keep track of potentially interesting modules and to brainstorm layout ideas

Jopyth/MMM-Remote-Control for remote control via browser (also requires remote access via browser to be enabled - separate issue)


Wishlist: --exclude-tags could support a regexp/glob pattern

This is useful in our use case, when we tend to tag a version when it is being deployed to a particular environment. E.g.: version 1.2.3 deployed to the tst environment would be tagged as tst_1.2.3.
I can volunteer to fix this, if it is considered a useful feature. Suggestions on how it should work (new option or just change existing behavior of --exclude-tags?) are highly welcome.

Implemented in 1.12.0 by #320

Excellent, thanks a lot!


chore: move wallet core files to legacy

preparing legacy wallet management to be deprecated
Summary
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
How did you test this change?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

Mistakenly opened.


[SP-3945] - Backport of [PDI-16726] Cannot connect to MSSQL with curl…

…y brace in password

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/database/Database.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -0.4% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Method Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapinput.LDAPInputMeta

Branch Change: -1.6% :small_red_triangle_down:
Complexity Change: -0.9% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -3.4% :small_red_triangle_down:
Complexity Change: -3.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -0.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

@mchen-len-son @stepanovdg please review


Compile the C++ code with too many warnings.

Hi,
When I try to compile the code, I got too many warnings. I was wondering can anyone fix this?
I am using
gcc version 4.4.7 20120313 (Red Hat 4.4.7-11) (GCC)
[1] Building cme_mdp3_sbe_otf     [cme_mdp3/otf]
[1] -- Compiling src/Listener.cpp
[1] -- Compiling src/Ir.cpp
[1] In file included from include/otf_api/Field.h:21,
                 from include/otf_api/OnNext.h:19,
                 from include/otf_api/Listener.h:25,
                 from /home/user/zluo/branch/CME/cme_mdp3/otf/src/Listener.cpp:21:
include/otf_api/Ir.h:135: warning:  'class sbe::on_the_fly::Ir::Callback' has virtual functions and accessible non-virtual destructor
[1] In file included from include/otf_api/Listener.h:25,
                 from /home/user/zluo/branch/CME/cme_mdp3/otf/src/Listener.cpp:21:
include/otf_api/OnNext.h:29: warning:  'class sbe::on_the_fly::OnNext' has virtual functions and accessible non-virtual destructor
[1] In file included from include/otf_api/Listener.h:26,
                 from /home/user/zluo/branch/CME/cme_mdp3/otf/src/Listener.cpp:21:
include/otf_api/OnError.h:45: warning:  'class sbe::on_the_fly::OnError' has virtual functions and accessible non-virtual destructor
[1] In file included from include/otf_api/Listener.h:27,
                 from /home/user/zluo/branch/CME/cme_mdp3/otf/src/Listener.cpp:21:
include/otf_api/OnCompleted.h:26: warning:  'class sbe::on_the_fly::OnCompleted' has virtual functions and accessible non-virtual destructor
[1] In file included from /home/user/zluo/branch/CME/cme_mdp3/otf/src/Listener.cpp:21:
include/otf_api/Listener.h:96: warning:  'class sbe::on_the_fly::Listener' has virtual functions and accessible non-virtual destructor
[1] In file included from /home/user/zluo/branch/CME/cme_mdp3/otf/src/Ir.cpp:21:
include/otf_api/Ir.h:135: warning:  'class sbe::on_the_fly::Ir::Callback' has virtual functions and accessible non-virtual destructor
[1]     In file included from /home/user/zluo/branch/CME/cme_mdp3/otf/src/Ir.cpp:22: include/uk_co_real_logic_sbe_ir_generated/FrameCodec.hpp: In member function 'void uk_co_real_logic_sbe_ir_generated::FrameCodec::position(sbe_uint64_t)':
include/uk_co_real_logic_sbe_ir_generated/FrameCodec.hpp:108: warning:  comparison between signed and unsigned integer expressions
[1] include/uk_co_real_logic_sbe_ir_generated/FrameCodec.hpp: In static member function 'static const sbe_int32_t uk_co_real_logic_sbe_ir_generated::FrameCodec::irIdNullValue()':
include/uk_co_real_logic_sbe_ir_generated/FrameCodec.hpp:160: warning:  overflow in implicit constant conversion
[1] include/uk_co_real_logic_sbe_ir_generated/FrameCodec.hpp: In static member function 'static const sbe_int32_t uk_co_real_logic_sbe_ir_generated::FrameCodec::irVersionNullValue()':
include/uk_co_real_logic_sbe_ir_generated/FrameCodec.hpp:214: warning:  overflow in implicit constant conversion
[1] include/uk_co_real_logic_sbe_ir_generated/FrameCodec.hpp: In static member function 'static const sbe_int32_t uk_co_real_logic_sbe_ir_generated::FrameCodec::schemaVersionNullValue()':
include/uk_co_real_logic_sbe_ir_generated/FrameCodec.hpp:268: warning:  overflow in implicit constant conversion
[1]     In file included from /home/user/zluo/branch/CME/cme_mdp3/otf/src/Ir.cpp:23: include/uk_co_real_logic_sbe_ir_generated/TokenCodec.hpp: In member function 'void uk_co_real_logic_sbe_ir_generated::TokenCodec::position(sbe_uint64_t)':
include/uk_co_real_logic_sbe_ir_generated/TokenCodec.hpp:108: warning:  comparison between signed and unsigned integer expressions
[1] include/uk_co_real_logic_sbe_ir_generated/TokenCodec.hpp: In static member function 'static const sbe_int32_t uk_co_real_logic_sbe_ir_generated::TokenCodec::tokenOffsetNullValue()':
include/uk_co_real_logic_sbe_ir_generated/TokenCodec.hpp:160: warning:  overflow in implicit constant conversion
[1] include/uk_co_real_logic_sbe_ir_generated/TokenCodec.hpp: In static member function 'static const sbe_int32_t uk_co_real_logic_sbe_ir_generated::TokenCodec::tokenSizeNullValue()':
include/uk_co_real_logic_sbe_ir_generated/TokenCodec.hpp:214: warning:  overflow in implicit constant conversion
[1] include/uk_co_real_logic_sbe_ir_generated/TokenCodec.hpp: In static member function 'static const sbe_int32_t uk_co_real_logic_sbe_ir_generated::TokenCodec::fieldIdNullValue()':
include/uk_co_real_logic_sbe_ir_generated/TokenCodec.hpp:268: warning:  overflow in implicit constant conversion
[1] include/uk_co_real_logic_sbe_ir_generated/TokenCodec.hpp: In static member function 'static const sbe_int32_t uk_co_real_logic_sbe_ir_generated::TokenCodec::tokenVersionNullValue()':
include/uk_co_real_logic_sbe_ir_generated/TokenCodec.hpp:322: warning:  overflow in implicit constant conversion

Signed/unsigned conversion is mentioned in issue #153 .

Hi @donmendelson ,
I saw the Signed/unsigned conversion issue, how about other issues?

We have seen similar issue reports from a static analysis tool scan for security vulnerabilities. (High priority these days.)

Hmm, I was just hoping that they could fix these issues. But seems did not get any reply.

We do plan to address them, yes. When we have time.

This is a project @tmontgomery and I maintain in our spare time. We would welcome quality pull request if you would like to help.

The CMake based build is now clean on clang (Mac) and gcc 4.9.2 (Ubuntu).

Hi I am using gcc version 4.4.7 20120313 (Red Hat 4.4.7-11) (GCC) and I am trying to compile the code. If I do not use std=c++0x, it seems that I can not compile the code. It gives the warning
/otf/include/uk_co_real_logic_sbe_ir_generated/TokenCodec.hpp:160: error:  'INT32_MIN' was not declared in this scope
/otf/include/uk_co_real_logic_sbe_ir_generated/MessageHeader.hpp:51: error:  'UINT16_MAX' was not declared in this scope
/otf/include/uk_co_real_logic_sbe_ir_generated/MessageHeader.hpp:129: error:  'UINT16_MAX' was not declared in this scope

Also, I don't want to change the SBE library to add those macros to the sbe.hpp.
I mean add
/* Minimum of signed integral types.  */
# define INT8_MIN               (-128)
# define INT16_MIN              (-32767-1)
# define INT32_MIN              (-2147483647-1)
# define INT64_MIN              (-__INT64_C(9223372036854775807)-1)
/* Maximum of signed integral types.  */
# define INT8_MAX               (127)
# define INT16_MAX              (32767)
# define INT32_MAX<PHONE_NUMBER>)
# define INT64_MAX              (__INT64_C(9223372036854775807))

/* Maximum of unsigned integral types.  */
# define UINT8_MAX              (255)
# define UINT16_MAX             (65535)
# define UINT32_MAX<PHONE_NUMBER>U)
# define UINT64_MAX             (__UINT64_C(18446744073709551615))

to the sbe.hpp.
Can somebody take a look at it?
Thanks.

Hi.
SBE C++ codecs already have a requirement on gcc 4.8, IIRC, for the bswap builtins. So, at least use gcc 4.8 for now.
In terms of approach, I don't think adding a specific value to shadow over specific system values is a good idea. Probably redefining the SBE_NULLVALUE_ values in sbe.hpp for particular compiler versions is a better approach.


Evaluate if T.command overload accepting a Task can be removed

Forgotten parenthesis on commands are a frequent cause of issue.
Here is the latest encouter:

https://github.com/com-lihaoyi/mill/discussions/3506#discussioncomment-10618276

T.command currently has two overloads, one accepting a Result (like most of the other task factories, T, T.input, T.task and so on) and one accepting a Task. Because of the second version, command definitions like the following don't do what the user thinks they do, although they seem to work.
override def publishLocal(localIvyRepo: String): Command[Unit] = T.command {
  super.publishLocal(localIvyRepo)
}

Instead of creating a new command, that depends on another command (the super-version) and returns just the result, it returns the super-command as-is.
The correct version is:
override def publishLocal(localIvyRepo: String): Command[Unit] = T.command {
  super.publishLocal(localIvyRepo)()
}

 override def publishLocal(localIvyRepo: String): Command[Unit] = T.command {
-  super.publishLocal(localIvyRepo)
+  super.publishLocal(localIvyRepo)()
 }

I wonder why we have this overload and if we should just remove it, since it causes a lot of issues. It was one of my first issues I had myself when I experimented with Mill IIRC and I helped others to identify it many many times. The rule of thumb since then is, to always use one extra pair of parenthesis compared to the definition side of the task you want to call.
This is quite obviously an issue with our API which we should fix.

I'd like to remove the overload


Bridged-app stop working with HomePod after 1-2 hours

Reproduction steps
Hi,
I have a project that was based on example/bridged-app/linux.
The project can run smoothly with chip-tool for days.
However, after adding to a HomePod, it stops connecting with the HomePod after 1-2 hours.
It's not crash or freeze. It just stops communicating with the HomePod.
Here are the last logs when it stopped:
[1696582495.888312][373969:373969] CHIP:EM: <<< [E:33169r S:27464 M:52856158 (Ack:168094164)] (S) Msg TX to 9:000000008467109D [A32E] [UDP:[fe80::b9:bd2f:62f2:7c9f%eno1]:55312] --- Type 0000:10 (SecureChannel:StandaloneAck)
[1696582495.888577][373969:373969] CHIP:IN: Received a duplicate message with MessageCounter:168094164 on exchange 33169r
[1696582495.888612][373969:373969] CHIP:EM: >>> [E:33169r S:27464 M:168094164 (Ack:52856155)] (S) Msg RX from 9:000000008467109D [A32E] --- Type 0001:01 (IM:StatusResponse)
[1696582495.888661][373969:373969] CHIP:EM: Found matching exchange: 33169r, Delegate: 0x55e8caae6d48
[1696582495.888694][373969:373969] CHIP:EM: Forcing tx of solitary ack for duplicate MessageCounter:168094164 on exchange 33169r
[1696582495.888797][373969:373969] CHIP:EM: <<< [E:33169r S:27464 M:52856159 (Ack:168094164)] (S) Msg TX to 9:000000008467109D [A32E] [UDP:[fe80::b9:bd2f:62f2:7c9f%eno1]:55312] --- Type 0000:10 (SecureChannel:StandaloneAck)
[1696582495.889028][373969:373969] CHIP:IN: Received a duplicate message with MessageCounter:168094164 on exchange 33169r
[1696582495.889094][373969:373969] CHIP:EM: >>> [E:33169r S:27464 M:168094164 (Ack:52856155)] (S) Msg RX from 9:000000008467109D [A32E] --- Type 0001:01 (IM:StatusResponse)
[1696582495.889135][373969:373969] CHIP:EM: Found matching exchange: 33169r, Delegate: 0x55e8caae6d48
[1696582495.889169][373969:373969] CHIP:EM: Forcing tx of solitary ack for duplicate MessageCounter:168094164 on exchange 33169r
[1696582495.889293][373969:373969] CHIP:EM: <<< [E:33169r S:27464 M:52856160 (Ack:168094164)] (S) Msg TX to 9:000000008467109D [A32E] [UDP:[fe80::b9:bd2f:62f2:7c9f%eno1]:55312] --- Type 0000:10 (SecureChannel:StandaloneAck)
[1696582495.984722][373969:373969] CHIP:EM: >>> [E:33169r S:27464 M:168094165 (Ack:52856156)] (S) Msg RX from 9:000000008467109D [A32E] --- Type 0000:10 (SecureChannel:StandaloneAck)
[1696582495.984773][373969:373969] CHIP:EM: Found matching exchange: 33169r, Delegate: 0x55e8caae6d48
[1696582495.984819][373969:373969] CHIP:EM: Rxd Ack; Removing MessageCounter:52856156 from Retrans Table on exchange 33169r
Triggering Interval request data from EchonetLITE devices
[1696582502.113647][373969:373969] CHIP:DMG: Time out! failed to receive status response from Exchange: 33169r
[1696582502.113674][373969:373969] CHIP:DMG: <RE> OnReportConfirm: NumReports = 0
[1696582502.113687][373969:373969] CHIP:DMG: IM RH moving to [AwaitingDestruction]

Bug prevalence
all the time
GitHub hash of the SDK that was being used
latest
Platform
darwin
Platform Version(s)
No response
Anything else?
No response

@nmtoan91 If this is reliably reproducible, please report a feedback assistant ticket per the instructions below (that is, install the relevant profiles, then reproduce, then capture the sysdiagnoses and whatnot) and let me know the ticket ID here.  That will let us look at what's going on on the HomePod side.  If you also attach a log from your device to the ticket so the two sides can be correlated with each other that would be very helpful too.
Feedback assistant ticket:

File a feedback assistant ticket.
https://developer.apple.com/bug-reporting/#feedback-assistant
Click on the link below using your account:
https://feedbackassistant.apple.com/new-form-response
Choose iOS/iPadOS to file an issue
Choose the area as Home App and fill in the details of the type of issue and the description

Technical Information
Please provide the following
a) Sysdiagnose logs for iPhone / iPad with the timestamp / timeframe of the issue
b) Sysdiagnose logs for all the Home Hubs (HomePod mini / HomePod / Apple TV) with the timestamp / timeframe of the issue
c) Accessory logs with the timestamp / timeframe of the issue
d) mDNS network logs with timestamp / timeframe of the issue
e) Video or screenshot describing the issue (optional but beneficial)
Please make sure you download and install the profiles for iOS and tvOS as provided here. The instructions are also in these links.
iOS:

https://developer.apple.com/bug-reporting/profiles-and-logs/?platform=ios&name=homekit
https://developer.apple.com/bug-reporting/profiles-and-logs/?platform=ios&name=network
https://developer.apple.com/bug-reporting/profiles-and-logs/?platform=ios&name=mdns

tvOS:

https://developer.apple.com/bug-reporting/profiles-and-logs/?platform=tvos&name=homekit
https://developer.apple.com/bug-reporting/profiles-and-logs/?platform=tvos&name=network
https://developer.apple.com/bug-reporting/profiles-and-logs/?platform=tvos&name=mdns
For installation instructions, refer to https://developer.apple.com/bug-reporting/profiles-and-logs.
Note: Once you have the profile on the iPhone, it will ask you if you want to install it on other devices. Follow the prompts to install on the HomePod, Apple TV, etc., where you have the described issue and reproduce it.


Unfederate battery_plus package

Description
Proof of concept of integrating the web, linux, macos and windows plugin into the battery_plus plugin. Leaving the platform interface still intact.
I am not sure if even leaving the platform interface is worth it, but seems to be the recommended way so we can keep it.
Related Issues
None.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (flutter analyze) does not report any problems on my PR.
[ ] I read and followed the Flutter Style Guide.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change. <-- the user should not notice the difference

Actually @jpnurmi branch is better structured: https://github.com/jpnurmi/plus_plugins/tree/poc/battery_plus/packages/battery_plus
Feel free to open a PR with your changes! :)


US05-EditCustomExam

Coverage increased (+0.05%) to 92.563% when pulling c8aafef54792ae6fcf78dc5a68f09aef3daf50a8 on devel into 4f30baba7eacda922ec8c28415b05b89fb2413a7 on master.


Change ChefDK default_version to master

This will ensure our integration/nightly builds:

Pull in the latest changes from the chef-dk gem.
Contain the proper base version (currently 0.5.0-rc.5)

When it’s time for release, the ChefDK version should be locked via an override version in the ChefDK project definition:
override :chefdk, version: “0.5.0”

/cc @chef/ociv @chef/client-engineers @chef/test-driven-infrastructure

Yes, please. :+1:

:+1:

This is now part of https://github.com/chef/omnibus-chef/pull/364, closing this


Network is sometimes zoomed-out on initial load on iOS

Sometimes the network appears zoomed out after the page loads (this is before user interaction). The desired behavior is for the network to be the full size of the Theta Chi flag area.
I can't repro on Android but can occasionally repro on the mobile mode in Chrome devtools. I can also repro on my iPhone (safari and chrome). It usually only repros on the first load after a navigation: subsequent reloads always display correctly.
I think this might only repro when inside the iframe. I can't repro when I load a locally-served file within the iframe, but I can sometimes repro if I serve a local file which points its iframe at https://nfischer.github.io/framily-tree/.

So I tried this again today out of curiosity and I see something different. If I load this in Safari, then the family tree graph isn't zoomed out, however the area appears to be blank because the family tree hangs off the bottom of the screen. I need to slide and drag upward to bring the graph into view. Alternatively, if I search for a brother by name then that will also pan the graph into view.
Tested on iOS 18.1 in Safari.
Not reproducible in Chrome for iOS. Chrome works as I would expect, it's only Safari which has issues.


Topic/implementation

This is what I have so far.

@grovecj , this is all I will complete this sprint.
I think you should review (lol 1.8k files) the current status of it and I will work from dev next sprint.

http://<IP_ADDRESS>:8000/app

From: Adam Michael<EMAIL_ADDRESS>Sent: Tuesday, October 27, 2015 3:14 PM
To: CSSE497/pathfinder-ios
Cc: Grove, Carter J
Subject: Re: [pathfinder-ios] Topic/implementation (#13)
@grovecjhttps://github.com/grovecj , this is all I will complete this sprint.
I think you should review (lol 1.8k files) the current status of it and I will work from dev next sprint.

Reply to this email directly or view it on GitHubhttps://github.com/CSSE497/pathfinder-ios/pull/13#issuecomment-151614623.


Initial windows support for agent.

Proposed Changes
These changes allow for k3s agent to support being built on Windows.
Types of Changes
This is a new feature adding Windows support for the agent.
Verification
Builds succeed.
Linked Issues
This is in support of adding Windows support. rancher/windows#52
Further Comments
The minimum about of changes were performed to get a successful build working on Windows. We tried to keep the changes as localized as possible.

check the linter too

@brandond I just pushed up changes based on your feedback. Thanks for the assist on getting this completed.

#3418


chantools forceclose: extract close tx from SCB

This is part of https://github.com/lightningnetwork/lnd/issues/7658#issuecomment-1774983789 implementation.
chantools forceclose was modified to extract closing tx from SCB.
New options:
      --multi_backup string      a hex encoded multi-channel backup obtained from exportchanbackup for force-closing channels
      --multi_file string        the path to a single-channel backup file (channel.backup)
      --single_backup string     a hex encoded single channel backup obtained from exportchanbackup for force-closing channels
      --single_file string       the path to a single-channel backup file

With this option, the command extracts closing transactions from SCB and prints them.
This PR depends on https://github.com/lightningnetwork/lnd/pull/8183
(Field chanbackup.Single.CloseTx is needed.)

@guggero: review reminder

@guggero: review reminder

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

I updated both PRs. Signing now happens in chantools scbforceclose. I put an example into PR's description.
@guggero Please take another look!

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

Rebased for LND 0.18, fixed lint warnings.
Tested manually.

@guggero: review reminder

@starius, remember to re-request review from reviewers when ready

Thanks for the review! I updated LND PR and this PR. The code producing signed transaction was moved to LND to use it in itest.

@guggero: review reminder

I rebased the PR, updated go replace to the latest https://github.com/lightningnetwork/lnd/pull/8183 version.
Also included the suggested patch for dump.go. @guggero I put your name in Author field of the commit.

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

I moved function SignCloseTx from LND's PR https://github.com/lightningnetwork/lnd/pull/8183 here.
Added unit tests validating that the produced transaction has a valid signature.

@starius, remember to re-request review from reviewers when ready

testvector for custom channels
{
    "chan_point": "85619671cb1987c80723ed457fd829f6444269a4d228ab580cd8f2176f1d4994:0",
    "chan_backup": "cbb0bde3b8a7a1158fc2186290c980862a384027bc6d7c8e82b4ae48b9294abe200cef8f07a96703981e573aa6b5e78f9b07dd240592e281f8e4027654c47ae612863d3c52d8f7ae33f433ceef26093179d5cfce3d11495f92542ad935953a97bd0454e76276494c24bab9448985103db9fbc1dea3bb8408f2b7fd0987745c3c3343f51c1285288e0248bb9288a0f65067225640281c97b201c29f9a8ff55d81f727484adeb58e4985559b1790fe23257bcf50186cb69e3dcc21f33131232e6510b080cdbc934d0c5d6c7283a1666e319a5f1862f5e285f22e06d9f35750a35778bae69c790fa2332caac18a25086d9f0500071214606f1a350bddc083a34b4362e3e70fe0c4063d3230387495e88570564dfa242ccfceb1d607f64726a0545066c482b73d00d6ac3e5527bd0aba6c8f79d2268c1824bda5ac9f48a7e545057f41cda74b9bcc0823c3357b85feb219ebf3bbe4b1d2c936b1589ab86f9e88f54f4893a31c1bd6ef1f71a59403a5daf51ed922350be2885b3604dd689e75c24f9d7c028138d9428a23b8f2cb624fa0ac2f6f4cbd9b36121f8bd20130c166a419cace33ba17dc03547e8679a319cd2d7061653559939e74e5e848dc62e1c051b1efe2a26f8f7028a1bedf2ddebfa7b89e4bd5a09248be62ea0a636c144ca80c9531dda69ea4007931105fe48348422b8eaea139d98ed34e5c805cc672f58c534bf44e64a2716fe3755700b704faae45e37c164f8ac286f99a903fdf70c781b043df7607c3bd662a6ae5e31e99f0ebc517c966d5d0bbc045110150b5b75d64a2bf2c6442a8cb6d91f0b88188094e6bc3bbc619bbfe7513c970ea4d538903cd3c1cb03962d813dcbb1573a544f0f2b45e780222ea3b998fc4e9d1a60aa0ac6ac9874fa3f2fef76c03d5857ee225dbbdf167b24d838fd76d8dbcc04e98c7b7481ea4de79be2a793cce7a363c91210eccff0e047b038e98658c233d410aea99b71d"
}

RootKey Regtest:
tprv8ZgxMBicQKsPf1ujkCE39iYKKmdzD4MgdpKb3EtiJrNCnE2K4GFMtL11adjRsCwA6J1jVKndF6GXpMdSpBGev9cczcjyhrSDVVeEXmwtmCt
Dump:
(dump.BackupMulti) {
 Version: (chanbackup.MultiBackupVersion) 0,
 StaticBackups: ([]dump.BackupSingle) (len=1 cap=1) {
  (dump.BackupSingle) {
   Version: (chanbackup.SingleBackupVersion) 6,
   IsInitiator: (bool) false,
   ChainHash: (string) (len=64) "0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206",
   FundingOutpoint: (string) (len=66) "85619671cb1987c80723ed457fd829f6444269a4d228ab580cd8f2176f1d4994:0",
   ShortChannelID: (lnwire.ShortChannelID) 402:1:0,
   RemoteNodePub: (string) (len=66) "0310150ae975211a226fc85160232e238bf072a071202e58ce5d0527cda5d7e4c9",
   Addresses: ([]net.Addr) (len=2 cap=2) {
    (*net.TCPAddr)(0x14000138a50)(<IP_ADDRESS>:9636),
    (*net.TCPAddr)(0x14000138f00)(<IP_ADDRESS>:9735)
   },
   Capacity: (btcutil.Amount) 0.00100000 BTC,
   LocalChanCfg: (dump.ChannelConfig) {
    ChannelStateBounds: (channeldb.ChannelStateBounds) {
     ChanReserve: (btcutil.Amount) 0 BTC,
     MaxPendingAmount: (lnwire.MilliSatoshi) 0 mSAT,
     MinHTLC: (lnwire.MilliSatoshi) 0 mSAT,
     MaxAcceptedHtlcs: (uint16) 0
    },
    CommitmentParams: (channeldb.CommitmentParams) {
     DustLimit: (btcutil.Amount) 0 BTC,
     CsvDelay: (uint16) 144
    },
    MultiSigKey: (dump.KeyDescriptor) {
     Path: (string) (len=17) "m/1017'/1'/0'/0/1",
     PubKey: (string) (len=5) "<nil>"
    },
    RevocationBasePoint: (dump.KeyDescriptor) {
     Path: (string) (len=17) "m/1017'/1'/1'/0/1",
     PubKey: (string) (len=5) "<nil>"
    },
    PaymentBasePoint: (dump.KeyDescriptor) {
     Path: (string) (len=17) "m/1017'/1'/3'/0/1",
     PubKey: (string) (len=5) "<nil>"
    },
    DelayBasePoint: (dump.KeyDescriptor) {
     Path: (string) (len=17) "m/1017'/1'/4'/0/1",
     PubKey: (string) (len=5) "<nil>"
    },
    HtlcBasePoint: (dump.KeyDescriptor) {
     Path: (string) (len=17) "m/1017'/1'/2'/0/1",
     PubKey: (string) (len=5) "<nil>"
    }
   },
   RemoteChanCfg: (dump.ChannelConfig) {
    ChannelStateBounds: (channeldb.ChannelStateBounds) {
     ChanReserve: (btcutil.Amount) 0 BTC,
     MaxPendingAmount: (lnwire.MilliSatoshi) 0 mSAT,
     MinHTLC: (lnwire.MilliSatoshi) 0 mSAT,
     MaxAcceptedHtlcs: (uint16) 0
    },
    CommitmentParams: (channeldb.CommitmentParams) {
     DustLimit: (btcutil.Amount) 0 BTC,
     CsvDelay: (uint16) 144
    },
    MultiSigKey: (dump.KeyDescriptor) {
     Path: (string) (len=17) "m/1017'/1'/0'/0/0",
     PubKey: (string) (len=66) "03c1102d1b9e016d72a39226ab34fb92fe6194b2f177882f5b167926d76417e070"
    },
    RevocationBasePoint: (dump.KeyDescriptor) {
     Path: (string) (len=17) "m/1017'/1'/0'/0/0",
     PubKey: (string) (len=66) "034a07a00f89920b27d965b041084cef9619f952fd8e1bbb4699be9f7a5806c4ee"
    },
    PaymentBasePoint: (dump.KeyDescriptor) {
     Path: (string) (len=17) "m/1017'/1'/0'/0/0",
     PubKey: (string) (len=66) "02a1b59387e693774772894155f5338f1e816ea3a36c2792377738f376ba1fde53"
    },
    DelayBasePoint: (dump.KeyDescriptor) {
     Path: (string) (len=17) "m/1017'/1'/0'/0/0",
     PubKey: (string) (len=66) "02a560b80e736d1b11af80069579b0894c19b7611f53b923674e4966c43d542140"
    },
    HtlcBasePoint: (dump.KeyDescriptor) {
     Path: (string) (len=17) "m/1017'/1'/0'/0/0",
     PubKey: (string) (len=66) "02e682ecf3cc018bb1547b89a4be96e6e7df228da97078930d55dc039d8dea7d5d"
    }
   },
   ShaChainRootDesc: (dump.KeyDescriptor) {
    Path: (string) (len=17) "m/1017'/1'/5'/0/2",
    PubKey: (string) (len=5) "<nil>"
   },
   CloseTxInputs: (*dump.CloseTxInputs)(0x1400028d700)({
    CommitTx: (string) (len=274) "020000000194491d6f17f2d80c58ab28d2a4694244f629d87f45ed2307c88719cb719661850000000000a0007180024a01000000000000225120fbd9aedad03a11215960cf6de9f51e5c7f7e292e9263a3b2410c2e14e0c68229987a010000000000225120e8807a199fd42c953f63cf78a840f444d3dd65541c38afe675ac2bf49f7d975a9bf94a20",
    CommitSig: (string) (len=196) "b8343a3033969c0eafbff5d4cff2fc981d279625b6ffc14996701c2fc90d787003ada823a2beee4a33b6524b9d1c6ccf751aa26c422b7bcc19631dea5214cf71b603d4d0cfa9a508e144a6f397319f56faa64854b7829129055bbab3ecf0fd4a49a2",
    CommitHeight: (uint64) 0,
    TapscriptRoot: (string) (len=64) "28dc51f66b841a32c48f4308e212d622d7ae5af2ceccdf10f9b37eeaf3ffcae3"
   })
  }
 }
}

scbclose:
If you do this and the state that you publish is *not* the latest state, then
the remote node *could* punish you by taking the whole channel amount *if* they
come online before you can sweep the funds from the time locked (144 - 2000
blocks) transaction *or* they have a watch tower looking out for them.

**This should absolutely be the last resort and you have been warned!**
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

Type YES to proceed: YES
Channel point: 85619671cb1987c80723ed457fd829f6444269a4d228ab580cd8f2176f1d4994:0
Raw transaction hex:<PHONE_NUMBER>010194491d6f17f2d80c58ab28d2a4694244f629d87f45ed2307c88719cb719661850000000000a0007180024a01000000000000225120fbd9aedad03a11215960cf6de9f51e5c7f7e292e9263a3b2410c2e14e0c68229987a010000000000225120e8807a199fd42c953f63cf78a840f444d3dd65541c38afe675ac2bf49f7d975a014093106f79bc27cee0105d3b77a11bf04109a33ec42e9d8c1813f48eac864f4413ef3b4551c6f22585044a4316408789e29be33aa82a2c362a4a988e02d8c1fcd99bf94a20

@ziggie1984 Thanks for providing the test vector for custom channel!
Could you also post pk_script for the channel UTXO, please?
It is needed to verify the signature and can't be deduced from the data already posted.

@ziggie1984 Thank you! It works! I updated the testdata for scbforceclose package.

@guggero: review reminder

@guggero: review reminder

@guggero: review reminder

I'm going to remove my request for review until lnd v0.19.0 (non-RC) is out.

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready

@starius, remember to re-request review from reviewers when ready


Reland "Updated SearchDelegate to follow custom InputDecorationTheme"

Description
This is a relanding of #55209 which was reverted due to some internal test failures. These have been resolved on the internal side and we should be good to go.

There were still some internal failures being reported, but appeared to be unrelated null safety issues that were caused by the roll being behind. I went ahead and marked it as a success so we can land this.


Should reset connection pools after fork

Consider this scenario:
process A creates a connection pool and send a request to url0, and then fork twice. Then we got process B & C.
process B and C then send another request to url0 at nearly the same moment, then the underlying connection they used would be the identical one, causing confused response.

@tesseract2048 Yes, connection pools should be reset after forking, but I don't believe that urllib3 should be doing it.
This has been discussed elsewhere, but generally speaking we don't know the user's intent: do they want only the child to own the connections, or only the parent? IMO, if a user is going to fork, they should be maintaining discipline over their own state, and should clear the connection pools from whichever process they want to no longer have access to them.

Right. I'm open to proposals that can reliably detect and warn (or even reset) when a fork happened, but that's borderline out of scope as urllib3 does not have any multiprocess-safe mechanics (we're merely threadsafe).
@tesseract2048 I'm closing this issue for now, but if you'd like to submit a PR to this effect I welcome it. :)
I would also appreciate any recipes you'd like to add to our documentation about how to use urllib3 properly in a multiprocess environment. This would be ideal, I think.

Thanks for response, @Lukasa @shazow .
I think adding description to the effect to document helps little because users may be just simply combining two libraries (i.e. python-requests and multi process thrift server), so connection polling and fork are done separately. Maybe they are not even aware of these implementation details before things actually break (and probably break with little chance and hard to repeat).
What do you say, if letting user specify whether they want to keep connections alive after fork (reset by default)? We could use POSIX calls such as pthread_atfork to detect a fork then handle the situation properly.

@tesseract2048 Does that work on every platform (win/linux/mac/etc) without edge cases? I suspect it would be safer to provide a multi-process recipe in the docs than try to detect it automagically.

As far as I know pthread_atfork isn't exposed by Python by default, so we'd need to add a dep to make that call.

Hi, @shazow @Lukasa . I cannot come up with any edge cases now but there could be many.
Another simpler idea would be associating a pid to each connection pool object, each process then checks its owner pid with associated pid (before using) to decide what to do. Does this sound portable?
We can introduce the mechanism and keep current behavior by default, then let other libraries to decide the policy.

At what point does the pool check the pid? What happens if a fork happens mid-use?

For example:
Before obtaining connection, check stored pid. If it's different from current pid, run these atfork policies. Then and set pid to current one.
If fork happens mid-use, and we are giving user two choices: after fork, either keep connections or get rid of all of them, cases are:
A. if there are no inflight request in any living connection, everything is fine.
B. if user chooses not to preserve connections after fork (e.g. keep these connections to parent process), and there are one or more requests inflight, we can still detect the fork and get rid of these connections by closing them (closing file descriptor instead of socket). Process that sent these requests are still able to receive further responses.
C. if user chooses to preserve connections after fork, and there are one or more requests inflight, the thread that waiting for response are generally not preserved after fork (one thread cannot doing both forking and blocking i/o at the same time), so if things like gevent is not used, child process will 'forget' about these requests. Parent are still able to receive further responses. In this case, as long as child process issues new request after these responses arrives, everything is fine. Otherwise, there could be a problem. However, it is not worse than current situation. It is user's choice to keep these connections.

if there are no inflight request in any living connection, everything is fine.

That's not true at all: we pool the connections. If there are no in-flight requests we still need to iterate over the pool and clear it.

and there are one or more requests inflight

The problem here is that we don't really know if requests are in-flight: the prior contract of urllib3 is that once we've grabbed a connection from the pool it's the property of the caller until they hand it back to us. We really shouldn't be tearing down connections under their feet.
That said, there shouldn't be any requests in-flight in the sense you mention it in part 3, because threading and forking are generally not mixed (though if there are we're in trouble, because we'll leak the connections from the pool).

Yes. By everything is fine I mean in this case it's trivial to clear the connection pool if necessary.
IMO it is simpler if it is caller's responsibility to return the connection, since there are no edge cases about in-flight requests: if one grab a connection, send the request, then before receiving response, another thread called fork, that connection will not be visible to children process. I won't consider it as leak because eventually the connection will be returned to parent process.

@tesseract2048 How do you feel about adding something like this to our docs instead?

How to use urllib3 in a multi-process environment?
Make sure to fork before using your urllib3 pools and everything will be good. Resources cannot be shared between processes, and behaviour of pre-used pools after forking to a new process is undefined.

Seems like less work and should satisfy the reasonably tiny subset of our users who rely on this functionality. :)

@shazow That makes sense.
Thanks.

@tesseract2048 Would you like to submit a PR to add this to our docs?

Sure, @shazow.
I'll submit a PR in a couple of days.

For completeness, this has bitten me severely when using Requests and Celery.
I've raised https://github.com/requests/requests/issues/4323 to discuss.

hey, i'm facing this issue, i'm using a library that uses urllib3 internally, could you please show me how can i reset the connection pools after fork?


[pilot] Simplifying creation of Pilot discovery service

What this PR does / why we need it:
This is similar to what has been done for Mixer. Separates
out the creation logic for the Pilot discovery service from
the command-line application. Allows the discovery service
to be more easily created in various environments, including
tests.
In addition, we've expanded the options to allow the
Pilot discovery service to run with a mock service controller
and a file-based config controller. This will be useful for
testing.
Release note:

@nmittler: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
ba77e3166b9d6e599cb107c0ad3b21d2add48bcf
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
733391a62768b496bf35c28c7d5ff9c0f120bfa1
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
604e04be5276beb5cdca864ef86a3b6259eda1f8
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
8354542a3adc5f6c88fd80b39c90331c2e98ba7f
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
69890a48473052a27f7511a89de7080acfbdfac6
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
332c5686e013b56638b14617f8e3a0f3cbaef81d
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
c9b13f1b3421a94f9993e2c6f1b084819644e367
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
426a5ab8ea23496f175f5715852b652c2d7f494a
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
1e6a2b0ab7c2b5568f090bcc0b236c324bb74bc8
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
31ee494b38ae1ea3dcac6b4a8a065b7b18ddc96c
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
d0ac89ed1d67e51825a7a2d0fc1ba5081911557c
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
778d5d450d0cadcfaf1f13c8d1bf7eb4ac12de2a
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
4f0892e1fced1b243957955c07179dae1cfe7f39
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
917c5824522ebef20351225769326b7fef511b00
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram All of the circleci tests seem to be passing now.  It's not clear to me that this PR is causing the presubmit failures.  Any thoughts?

Mixer unit test is still failing. Some missing template stuff (@geeknoid / @guptasu ???)
With regard to presubmit, there is just too much output to parse. I don't know what is going wrong.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
88eaf84582c9b8fafa43ccf466057530d7f0d22f
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
90c42d63693b74e3e642282a4d4ad641af8bb573
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Mixer folks ((@geeknoid / @guptasu?) I'm seeing the following unittest-mixer error that seems unrelated to my PR:
mixer/template/sample/template.gen_test.go:1712:15: unknown field 'OutStrMap' in struct literal of type istio_mixer_adapter_sample_myapa.Output
FAIL	istio.io/istio/mixer/template/sample [build failed]

Any ideas? Thanks!

I see this error on other PRs as well.
On Fri, Dec 8, 2017 at 12:49 PM Nathan Mittler<EMAIL_ADDRESS>wrote:

Mixer folks ((@geeknoid https://github.com/geeknoid / @guptasu
https://github.com/guptasu?) I'm seeing the following unittest-mixer
error that seems unrelated to my PR:
mixer/template/sample/template.gen_test.go:1712:15: unknown field 'OutStrMap' in struct literal of type istio_mixer_adapter_sample_myapa.Output
FAIL	istio.io/istio/mixer/template/sample [build failed]
Any ideas? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/2003#issuecomment-350327292, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH0qd7EQ9-XJnUZgRkEETMkn5Pu3mC7-ks5s-XasgaJpZM4Q4ajl
.

I guess it is because of outdated generated files. Bin/regenerate_files.py

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
967a6a523283237657ede676d123e0eea9a127a0
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
4fdeef7b28df2b509177df2c2cf0622434f05282
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram looks like unittest-mixer now passes ... progress! :slightly_smiling_face:
The istio-presubmit is still failing, however: https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/2003/istio-presubmit/1185.  Nothing looks like it's directly related to my PR AFAICT.  Any thoughts?

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
c48b8993ebbc2b88fb7639966357675fb87fa0ad
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Merging to unblock CF folks.. Will fix broken circleci unit tests later..

@rshriram thanks!


Count sample tests into reports and fix misc. test identifiers

We can now run sanitycheck on devices and include tests and samples in the report.

Codecov Report

Merging #15062 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #15062      +/-   ##
==========================================
- Coverage   52.93%   52.92%   -0.02%
==========================================
  Files         309      309
  Lines       45268    45268
  Branches    10451    10451
==========================================
- Hits        23961    23956       -5
- Misses      16542    16544       +2
- Partials     4765     4768       +3

Impacted Files
Coverage Δ

subsys/testsuite/ztest/src/ztest.c
68.59% <0%> (-4.14%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 766edd4...c009dd5. Read the comment docs.


Profile iota-core based on different scenarios and record/report error logs if there is any

Profile the iota-core and give the results of performance profiling for EBSI.

Define the testing scenarios, and use the up2date iota-core and the associated plugins to do the profiling.
For EBSI currently we use 5 nodes, 3 validator nodes and 2 non-validator nodes.

Testing scenarios
5-node profling results

According to different iota-core versions and scenarios, we collect the profiling results here

Profiling Results

Added more results for alpha.5 and some results for alpha.6 here

Provided more details results for alpha.7 and alpha.8 here

Provided detailed testing/profiling results for alpha.9 here

Close old issues.


Post EPANET build instructions

PR #166 changes the procedure to run reg testing locally. I have updated the instructions I wrote for building EPANET on Windows and would like to post them. Where should they be posted? Preferences?

!! I've been meaning to post about this
We need a very basic "getting started" section near the top of README - with blocks of text one could essentially copy-paste to get the build tools, clone the code, build it, and run the tests and executable. Probably need two sections separated by platform.
more in-depth instructions could be another page, linked in the README in a friendly way that will be picked up in Doxygen.
how does this sound?

For a long time we have been using the instructions by @eldemet here. Actually what is needed is just the Microsoft Windows SDK 7.1 and then the batch file we have in the repo will create the DLLs and EXEs (32 and 64 bits) with a single click. I understand that we want to move to a single make file but it should be made simple.

So what you like about the existing batch file is that it has one dependency (win sdk 7) and you can build with one click? And my instructions were too complicated?

Basically yes. However, I do understand the request for a single build script for all platforms (as CMake) even if it means a more complex set of instructions.

Thanks Elad! That is good feed back. I will see what I can do about simplifying the number of dependencies and reducing the number of steps in the build process.


Allow dumped image to be transferred to a criu page server

--page-server to specify the IP address of criu page server
--port to specify the port of the criu page server
Signed-off-by: Hui Kang<EMAIL_ADDRESS>

Would be nice to combine this with #543

Yes, I would vote for having a struct as input instead of many parameters

Me too.
I like the idea of using criuOpts *CriuOpts as the parameter for checkpoint
and restore.

Hui

On Wed, Apr 22, 2015 at 9:30 PM, Michael Crosby<EMAIL_ADDRESS>wrote:

Yes, I would vote for having a struct as input instead of many parameters
—
Reply to this email directly or view it on GitHub
https://github.com/docker/libcontainer/pull/551#issuecomment-95383218.

Hi, Michael,
Maybe you could merge #543 and then I will re-submit a patch for
page-server and port.

Hui

On Wed, Apr 22, 2015 at 9:30 PM, Michael Crosby<EMAIL_ADDRESS>wrote:

Yes, I would vote for having a struct as input instead of many parameters
—
Reply to this email directly or view it on GitHub
https://github.com/docker/libcontainer/pull/551#issuecomment-95383218.

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "criu" git@github.com:huikang/libcontainer.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

This will update the existing PR, so you do not need to open a new one.


Convert loadProps.gradle to Kotlin script

This is for consistency with all the other Gradle files.

@sschuberth hey, thank you so much for this!

@sgammon can you tell whether the failures are due to my change, or is something else going on?

@sschuberth i pulled down and tested locally, it looks like CI on v3 is just out of date. release/alpha2 and feature/js-runtime-v3 are where development is happening right now.
cherry-picking to release/alpha2 worked fine, i may re-target the PR to that branch and merge there instead.
all the tests passed of course, it looks like your change is fine.

@sschuberth now it's complaining because build secrets aren't making it in -- this is the first contribution btw outside of the core team! so i may need to tweak the workflows to allow the secrets, because they aren't really all that sensitive. it's just code coverage reporting, etc.
the tests all pass locally, so i think we can safely ignore CI and merge. thank you so much for your contribution, even though it's small, it means an enormous amount to us, since it's the first one! 🎉

new check run on feat/js-runtime-v3 looking fine.

even though it's small, it means an enormous amount to us, since it's the first one! 🎉

It was just a test balloon from my side 😉 This project sounds really cool, and if it turns out to be of use in one of my projects, I hope to be able to make more contributions!

hey, test balloon or not, we'll take it @sschuberth! lol.
i see you're a Kotlin fan. feel free to join us on Kotlin Slack in #framework-elide if you have any suggestions or ideas you'd like to share. 💯


Random Quote Generator

Is your feature request related to a problem? Please describe.
I want to add the Random Quote Generator extension which generates random quote when clicked up on
Additional context
I am working under GSSoC'24.
Please assign this issue to me

Hello @Chillthrower this issue also added to my repository #106


Cover the component with unit test

In order to improve the component code and to reduce potential bugs and also to make it easy to maintain we need to cover the ngx-avatar component with unit test.

I'm working on this one, I started by refactoring / covering the avatar.service. Here's the branch

should be closed when this branch gets merged #46

I think it's ready, isn't it?

I still need to cover some scenarios in the avatar.component.spec.ts
The goal is to cover the maximum features to avoid bugs / regression. I think after that we will be able to confidently auto publish to npm when we merge to master


Size Container Queries starting to ship in Chrome 105 🎉

https://chromestatus.com/feature/6525308435955712
The source for note 3 is there as well:

Note for M105: Table fragmentation in LayoutNG will not be shipped in M105, but expected to ship in M106. The consequence is that if an author combines table layout and size container queries inside a multicolumn layout, container queries will not work in that context in M105.

There doesn't seem to be a test on https://tests.caniuse.com/css-container-queries yet - I used
"container" in document.documentElement.style;

stolen from https://github.com/GoogleChromeLabs/container-query-polyfill:

Still false in 104 (currently Beta).

Thanks! And added a test based on the "container" check. :)


Workaround for login/signup styles different in production

Unfortunately this requires manually adding {index: 1} to affected styles, so I guess we'll just have to keep an eye out...

Glad you found a workaround!
Also, are you able to patch this in everywhere by changing imports and wirting a shim around the original makeStyles like this:
makeStyles = (originalMakeStyles: (theme) => styleType) => (theme => ({originalMakeStyles(theme), {index: 1}))

This probably doesn't run, but maybe you get what I mean?

Thank god for regex

Does this affect the ordering in which the the styles are injected only? Also where is this documented? Did you have to dig into their source code for this?

https://cssinjs.org/jss-api?v=v10.6.0#create-style-sheet
Higher index means lower in <head>, and it defaults to 0


ECO codes https://github.com/evidenceontology do not have a grouping designation

ECO codes https://github.com/evidenceontology do not have a grouping designation
These ECO codes are seen in gpa files from ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/ and https://github.com/evidenceontology/evidenceontology/blob/master/eco-basic.obo, but not seen in https://github.com/evidenceontology/evidenceontology/blob/master/gaf-eco-mapping-derived.txt:
**ERROR:     14,035 INSTANCES OF ECO:0005547 IN GPAs
**ERROR:      3,390 INSTANCES OF ECO:0005544 IN GPAs
**ERROR:        712 INSTANCES OF ECO:0005546 IN GPAs
**ERROR:        470 INSTANCES OF ECO:0005610 IN GPAs
**ERROR:        152 INSTANCES OF ECO:0005543 IN GPAs

Is it expected that some ECO codes will have no group designation, such as ISA, IEA, ISS, etc.?
Many researchers use the grouping designation, rather than the ECO codes. If some ECO codes have no grouping designation, then we need to update our annotation file readers to reflect this. Currently, there are only five ECO codes that have no grouping designation.
FYI, these annotation files contain ECO codes that do not exist in the ECO definition file:
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/ARABIDOPSIS/goa_arabidopsis.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/CHICKEN/goa_chicken.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/COW/goa_cow.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/FLY/goa_fly.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/HUMAN/goa_human.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/MOUSE/goa_mouse.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/PIG/goa_pig.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/RAT/goa_rat.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/WORM/goa_worm.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/YEAST/goa_yeast.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/ZEBRAFISH/goa_zebrafish.gpa.gz

Additional context
All files downloaded Dec 21, 2021
https://github.com/geneontology/helpdesk/issues/372

Hello,
These 5 terms should map to the GO evidence code IC.
We were asked to wait to make a mapping update until after the December GO release - but that has now happened so we will update these soon and push a new version of the derived file.
looping in @nsuvarnaiari

Hello again,
We are planning to push a new release of ECO and the derived file during the first week of January.
Is that soon enough to meet your needs?
Also, I realized that I didn't reply to one of your questions. In fact, not all ECO terms will map to a GO evidence code (as not all ECO terms contain evidence types that are covered by a GO evidence code), however we endeavor to make it such that all ECO terms that are relevant to a GO evidence code do have those mappings.
Michelle

Hello,
The new mappings for the above terms are in the latest ECO release.
I'm going to close this issue. But please reopen if you have further questions or concerns.
Regards,
Michelle


[release-v1.15] do not build OIDC config unless enabled

Backports of the following:

https://github.com/knative-extensions/eventing-kafka-broker/pull/4055
https://github.com/openshift-knative/eventing-kafka-broker/pull/1355

/retest

/retest

/retest

/retest

/retest

/retest-required

/retest-required


remove concentrated flag

removing concentrated flag as its deleted from source

FYI your PR is not against the right repo :D