PurchaseAsync no longer has payload

So using V4 of the plug-in.
I noticed that PurchaseAsync no longer has the developer payload parameter.
How do I now communicate app specific data so I validate this on the backend?
Thanks

Correct, payload was just a check and google removed it from the API. You can still get the payload when you implement IValidate as usual.

ok.
So i’ve implemented the google pub/sub updates for subscription updates in my server.  It give out the developer payload stuff but only if i use v2 of the plugin.  Just wondering how i can get that to the backend and continue to use the pub/sub updates?
On 27 Sep 2020, at 16:31, James Montemagno <notifications<EMAIL_ADDRESS>wrote:
Correct, payload was just a check and google removed it from the API. You can still get the payload when you implement IValidate as usual.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/jamesmontemagno/InAppBillingPlugin/issues/313#issuecomment-699649782, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQVPSMZILOH6M36OJSZWQUDSH5LENANCNFSM4RY3KHTQ.

Yeah there is still the same payload you get back for data and signature -> https://github.com/jamesmontemagno/InAppBillingPlugin/blob/feature/new-android-billing/src/Plugin.InAppBilling/InAppBilling.android.cs#L268
They "payload" was a parameter that was sent in that the library used to verify, but google doesn't use that. but your server should still get the info you need from the library.

I’m 100% misunderstanding something.
the “payload” parameter that was pass in to the older version of PurchaseAsync was actually used by google and gets pass around on the server side notifications from google.  I used this to tie an IAP notification back to the user record i keep in my app.
I’m not really clear how i do that now?  Are any of the other fields in i get back from google stable enough to use to link to a user record from the tap server side notification?
[X]             Andrew Westacott
Chief Technology Officer
Q Group Technology Ltd

P: 07712 279 564
A: 92 Station Road, Clacton-on-sea, Essex, CO15 1SG
W: www.qgroup.techhttp://www.qgroup.tech
On 27 Sep 2020, at 16:53, James Montemagno <notifications<EMAIL_ADDRESS>wrote:
Yeah there is still the same payload you get back for data and signature -> https://github.com/jamesmontemagno/InAppBillingPlugin/blob/feature/new-android-billing/src/Plugin.InAppBilling/InAppBilling.android.cs#L268
They "payload" was a parameter that was sent in that the library used to verify, but google doesn't use that. but your server should still get the info you need from the library.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/jamesmontemagno/InAppBillingPlugin/issues/313#issuecomment-699652431, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQVPSM4SLOJ3CLQKMC32ERTSH5NW3ANCNFSM4RY3KHTQ.

Developer Payload was removed by Google -> https://developer.android.com/google/play/billing/developer-payload
You would want to take a look at -> https://jamesmontemagno.github.io/InAppBillingPlugin/SecuringPurchases.html
When I call "VerifyPurchase" you will get the following:
signedData: Purchase Data returned from Google
signature: Data Signature returned from Google
I would look at the Google docs as well -> https://developer.android.com/google/play/billing/security

Developer payload was removed, but they added 'Purchase attribution' for purposes of identifying which account made the purchase (e.g. from pub/sub).  How will we pass this attributes to PurchaseAsync so that the library passes them to google API?


Add parallelization for RandomIntervalSpectralForest

Reference Issues/PRs

This PR is an extended version of #479.
What does this implement/fix? Explain your changes.

In addition to the parallelization for the training stage implemented in #479, this PR further adds the parallelization for the evaluating stage in predict_proba.
Below are some results on the time efficiency improvements brought by parallelization, with each cell corresponding to results before/after parallelization.

Dataset Name
Test Acc (%)
Training (s)
Testing (s)

Adiac
75.19/75.19
66.278/10.595
63.555/8.768

Beef
76.67/76.67
7.374/1.041
7.315/1.038

Car
80.00/80.00
15.305/2.122
15.167/2.106

CBF
93.89/93.89
3.698/0.537
106.791/15.221

ChlorineConcentration
76.93/76.93
71.050/9.793
559.179/209.677

Does your contribution introduce a new dependency? If yes, which one?

No.
PR checklist

For all contributions

[x] I've added myself to the list of contributors.

Got it, I will fix this : )

Hi @mloning, I have updated the code as you suggested. There are also some modifications on the import statements and docstrings for the better consistency of coding style.

It looks like the test module for RandomIntervalSpectralForest is missing on the master branch. I will take time to add a unit test to make it better.

Hi @mloning, I have followed your suggestion on cloning all base estimators before parallelization. As to the unit test, the expected result in test_rise.py is computed using sktime with stable version 0.4.3.
No idea on why building the docs fails, maybe there are too many on-going tasks : (

Hi @mloning, thanks for your suggestions! I have isolated _make_estimator from the body of class.
What I am a little confused about is your code snippet: self.estimators_ = [_make_estimator(self.base_estimators, rng.randint(np.iinfo(np.int32).max) for _ in range(self.n_estimators)]:
If we store a total number of self.n_estimators unfitted trees in self.estimators_ before the parallelization, we will have to remove these unfitted trees after the parallelization, because the fitted tree returned by each worker in joblib will not be stored in its original location (i.e., self.estimators_), but in a standalone memory space. For a fask check, if we do nothing after the parallelization, the program raises NotFittedError for decision tree, indicating that trees returned by joblib are not those in self.estimators_.
Therefore, an auxiliary list trees is used before the parallelization, and we manually append each fitted tree onto self.estimators_ after the parallelization.

Thanks @mloning, All checks have passed now ; )

By the way, how about improving the time efficiency of other algorithms implemented in sktime @mloning ?
This great lib has helped me a lot during my own research, and I am very willing to help to improve it :)

@AaronX121 I'm happy to hear that you want to contribute more! Feel free to take a look at some of the other algorithms to see if you can add improvements, I'd also be more than happy to discuss other areas to work on, ping me on Gitter and we can discuss what you'd be interested in 👍


Error in setwd(snakemake@scriptdir) : cannot change working directory

Do you know this bug? Confused since it seems to be basic snakemake-R interaction stuff, but one of the rules worked..

Bug: setwd(snakemake@scriptdir) : cannot change working directory
Rule dea worked
Rules volcanos, aggregate etc fail. (see below)
I use snakemake 7.32
here is how I use the rule in my .smk file

module ct_annotated_dea_limma:
    snakefile:
        github("epigen/dea_limma", path="workflow/Snakefile", tag="v1.0.3")
    config:
        config_wf['ct_annotated_dea_limma']

use rule * from ct_annotated_dea_limma as ct_annotated_dea_limma_*

here the error (note: I adapted paths etc for anonymization):

rule ct_annotated_dea_limma_volcanos:
    input: path/to/project/results/backup_demulti_old/first_batch_of_samples/differential_expression/dea_limma/normal____L2/results.csv
    output: path/to/project/results/backup_demulti_old/first_batch_of_samples/differential_expression/dea_limma/normal____L2/plots/volcano/ALL
    log: logs/rules/volcanos_normal____L2_ALL.log
    jobid: 0
    reason: Forced execution
    wildcards: analysis=normal____L2, feature_list=ALL
    resources: mem_mb=32000, disk_mb=1000, disk_mib=954, tmpdir=/tmp, slurm_account=rb, slurm_partition=shortq, runtime=720, slurm_extra=--qos=shortq

Activating conda environment: ../../../../yet/another/path/user/snakemake_conda/5871cfde6a5cff7f9193590f581e3235_
During startup - Warning messages:
1: Setting LC_COLLATE failed, using "C"
2: Setting LC_TIME failed, using "C"
3: Setting LC_MESSAGES failed, using "C"
4: Setting LC_MONETARY failed, using "C"
5: Setting LC_PAPER failed, using "C"
6: Setting LC_MEASUREMENT failed, using "C"
Error in setwd(snakemake@scriptdir) : cannot change working directory
Calls: <Anonymous> -> setwd
Execution halted
[Sun Sep 29 09:19:25 2024]
Error in rule ct_annotated_dea_limma_volcanos:
    jobid: 0
    input: path/to/project/results/backup_demulti_old/first_batch_of_samples/differential_expression/dea_limma/normal____L2/results.csv
    output: path/to/project/results/backup_demulti_old/first_batch_of_samples/differential_expression/dea_limma/normal____L2/plots/volcano/ALL
    log: logs/rules/volcanos_normal____L2_ALL.log (check log file(s) for error details)
    conda-env: /yet/another/path/user/snakemake_conda/5871cfde6a5cff7f9193590f581e3235_

RuleException:
CalledProcessError in file https://raw.githubusercontent.com/epigen/dea_limma/v1.0.3/workflow/rules/visualize.smk, line 29:
Command 'source /yet/another/path/user/miniconda3/bin/activate '/yet/another/path/user/snakemake_conda/5871cfde6a5cff7f9193590f581e3235_'; se
t -eo pipefail; Rscript --vanilla path/to/project/.snakemake/scripts/tmp_77ra6nc.volcanos.R' returned non-zero exit status 1.
  File "https://raw.githubusercontent.com/epigen/dea_limma/v1.0.3/workflow/rules/visualize.smk", line 29, in __rule_volcanos
  File "/yet/another/path/user/miniconda3/envs/snakemake7_32/lib/python3.9/concurrent/futures/thread.py", line 58, in run
Shutting down, this might take some time.
Exiting because a job execution failed. Look above for error message
srun: error: d019: task 0: Exited with exit code 1
[Sun Sep 29 09:19:28 2024]
Error in rule ct_annotated_dea_limma_volcanos:
    jobid: 0
    input: path/to/project/results/backup_demulti_old/first_batch_of_samples/differential_expression/dea_limma/normal____L2/resul
ts.csv
    output: path/to/project/results/backup_demulti_old/first_batch_of_samples/differential_expression/dea_limma/normal____L2/plot
s/volcano/ALL
    log: logs/rules/volcanos_normal____L2_ALL.log (check log file(s) for error details)
    conda-env: /yet/another/path/user/snakemake_conda/5871cfde6a5cff7f9193590f581e3235_

Since I am using an outdated version of the workflow and the results.csv files are available, I would ignore this for now and check if after I migrate to snakemake 8 the issue persists

Yes, this known when using the github() directive to load the module and the scripts load themselves other scripts e.g., utils.R or tools.py. Easy resolved by having a local dea_limma copy and not using github(), but very interesting if resolved in Snakemake 8.
https://github.com/snakemake/snakemake/issues/2205
https://github.com/snakemake/snakemake/issues/1632


Look into how we handle icons for Altinn Studio and app-frontend

Description
Today we store all our icons on Fort Awesome. Altinn Studio get the icons it needs from Fort Awesome, but app-frontend get icons from cdn (self hosted fort awesome packages). Is there a better way to handle this?
Screenshots

Screenshots or links to Figma (make sure your sketch is public)

Considerations

As a designer I would like to have control over available icons for app-frontend.
Can we simplify the process of uploading/changing icons for app-frontend? Now we have to upload to Fort Awesome and then create update a CDN. Seems like an unnecessary step.
Maybe divide Altinn Studio and app-frontend icons on Fort Awesome

Acceptance criteria

Describe criteria here (i.e. What is allowed/not allowed (negative tesing), validations, error messages and warnings etc.)

Specification tasks

[ ] Analyze if this is something we should solve
[ ] Should we use svg-s rather than use a custom font?

Soon-to-be-solved in the design system?

https://github.com/Altinn/altinn-design-system/pull/175


fix: export typescript interfaces

exports the typescript interfaces for polished data from the alpha namespace, so they
can be used when imported as an es module.
for example:
import Alphavantage from "alphavantage"
const alpha = Alphavantage({key: 'api_key'});

// ...
const polishedData = alpha.util.polish<Alphavantage.StockQuote>(rawData);

closes zackurben/alphavantage#196

Coverage decreased (-77.0%) to 16.97% when pulling 7561adf26cc35aeb1cc091eff9d6341a450df408 on OACDesigns:export-typescript-interfaces into 847f84385cb420087c53e404ca446d1bd11669f4 on zackurben:master.

@OACDesigns Thanks for the contribution! My apologies for the delay.

thanks for merging! :)


Create Github Action (build & lint)

Build failure for shaderc due to missing cmake - this needs some more work...


REFramework error: An exception has occurred during initialization

Attempting to load the REFramework throws the above error.
I have added the dinput8.dll file and the REFramework sits on initializing screen until after 5 minutes I back out and it throws the error.
Not sure if i've missed a step somewhere. I also downloaded the v1.483 night build which also crossed the same issue.
Not sure what i'm doing wrong.
re2_framework_log.txt

Nevermind, fixed by disabling the Razor Axon software.


A few Adjustments

Added that when you edit a product you see 1,99 instead of 15,9.
Added Darkmode to products/create
4C

Added a color for the Darkmode hover.
Implemented Hover color for /tickets.
Tickets are now shown on the Dashboard.

Added a Chart to view How many Users have been created in each Month

Added functionality to the three head bars(idk how to name them).
Added Functionality to the Charts in the Admin Dashboard
6F


New release?

There's some great updates to the TS typing here and it'd be awesome to have a 2.6.0 release :)
Thanks so much!

<EMAIL_ADDRESS>has been published. Thanks for the reminder!


[deprecated] test: genesis state tests for vesting accounts

closes #1806
Overview
This PR is proposing a test suit to test the vesting accounts where introduced at genesis state. It tests the scenarios that we are intend to use for our mainnet.

closing in favor of https://github.com/celestiaorg/celestia-app/pull/2004


Re-use existing work in module AzurePipelinesPS

There has been work in the PowerShell Gallery module AzurePipelinesPS  that could help with the tasks in this module. Suggest we investigate if the below code can be replaced by the command New-APGitPullRequest.
Current code in task:
https://github.com/SynEdgy/Sampler.AzureDevOpsTasks/blob/7ce31b18d29dea1fd67eff8a5683b92dcbc52511/source/tasks/Create_PR_From_SourceBranch.build.ps1#L192-L228

I would really appreciate that. It seems to me that this module would enable Windows authentication for build worker servers (on-prem). Which would also eliminate the need for the PAT.
AzurePipelinesPS Readme

Happy to see a PR that re-uses the commands in the module.


Should respect view-instance and other permissions

This plugin currently ignores permissions when constructing the schema. This doesn't lead to any information leakage, since the actual calls to resolve GraphQL queries dispatch to TableView which respects permissions - but it does mean that the GraphQL endpoint can "leak" the schema structure of a database even when that database should not be visible according to view-instance or view-database permissions.

I'm going to fix this in the view_graphql and view_graphql_schema view functions:
https://github.com/simonw/datasette-graphql/blob/71b546af34385362b0d571a1ff766711fb1e074e/datasette_graphql/__init__.py#L45-L69
https://github.com/simonw/datasette-graphql/blob/71b546af34385362b0d571a1ff766711fb1e074e/datasette_graphql/__init__.py#L27-L34

First check view-database - if that says False then disallow access, if it says True then allow access. If it says None check view-instance.


Child processes spawned from CueMol do not inherit env vars, such as LD_LIBRARY_PATH.

The options for posix_spawn_XX API should be correctly set before creating new processes.

All env variables (environ) are passed to the posix_spawnp function.


latest() sql error on a model with custom CREATED_AT column

Laravel Version: 5.6.33
PHP Version: 7.2.8
Database Driver & Version: mysql 5.7.23

Description:
Using latest() on Eloquent model with custom CREATED_AT column name, will result to SQL Error: Column not found created_at in ....
Steps To Reproduce:
Create Pet model class
use Illuminate\Database\Eloquent\Model;

class Pet extends Model
{
    const CREATED_AT = 'date_added';
    const UPDATED_AT = null;

}

Create pets table migration
class CreatePetsTable extends Migration
{
    /**
     * Run the migrations.
     *
     * @return void
     */
    public function up()
    {
        Schema::create('pets', function (Blueprint $table) {
            $table->increments('id');
            $table->string('name');
            $table->dateTime('date_added');
        });
    }

    /**
     * Reverse the migrations.
     *
     * @return void
     */
    public function down()
    {
        Schema::dropIfExists('pets');
    }
}

Run migrations
php artisan migrate
In Tinker run the following commands:
Pet::latest()->get()

Illuminate/Database/QueryException with message 'SQLSTATE[42S22]: Column not found: 1054 Unknown column 'created_at' in 'order clause' (SQL: select * from `pets` order by `created_at` desc)'

This has been fixed in Laravel 5.7: #24004


Migrating to harp

Hi girls!, I saw that you are creating html pages for sections. I have started to migrate the website to harp.
Harp is a static site generator, it allows you to have partials con compilate your partials into different htmls, so you don't have to be copying and pasting html chunks. I think it is pretty easy to use, and also is a cool tool to learn (founders and coders website is build using it!).
I haven't done a pull request, but I have created a new branch ("version/harp") where I'm starting to do the migration. I you are happy with that, you can make a pull request and merge it with master.

Hey Gabriel!
We think that is a great idea, we would love that if you think that is the best option,
FAC's website was also written in markup, is this part of harp or a separate thing?
thank you!!

@gabrielperales can we merge a this now to master or you want to wait with it more?


Update select_by_criteria function to be more readable

Change the sytanx to make it more apparent that select_by_criteria() is just a wrapper for subset() that works with lazy eval calls and does error handling.

made the following changes, and checked that results are identical:
# function to subset dataframe by criteria and do error checking
select_by_criteria <- function(x,criteria){

  if(!is.null(criteria)) {
    # if criteria are specified, subset the dataframe accordingly
    out <- subset(x,eval(criteria))

  } else {
    # if no criteria are specified, do nothing
    out <- x
  }

  # if no results are returned, return an error
  if( nrow(out) == 0 ) {
    stop( "No matches found. Either:
          1. the name of variable(s) you specified is/are incorrect or
          2. the values you are looking for are not contained in the variable(s) you specified")
  }

  return(tbl_df(out))
}

suggest closing this issue.


U/jrbogart/postgres validation

Can this PR be merged, @wmwv?

@wmwv or @reneehlozek please take a look at the not-very-extensive diffs for this pull request and let me know if the branch can be merged.  It's been hanging around a very long time. Thanks.


onTranslationNotFound not triggered when actually not found?

I may be understood it wrong, but I'm having issues on resolving async translations via Promise due this line of code?
It seems that when the translation is not found, it returns the default value but it never hits the line 172 where it resolves the translation via Promise?
Are correct my assumptions?

@tikiatua, it actually makes sense what you say. It would probably that I hadn't got the locale defined yet. Closing the issue for now.
Thanks for answering.


What log in Application Insights are they loaded to?

I've setup for export to Application Insights and its not failing however I don't see them in any of the log tables

Is Auth0 really this bad at responding!


Runelite Graphics Bug

Describe the bug
Whenever I hover over things weird stuff starts happening.
To Reproduce
Steps to reproduce the behavior (Note, I am not sure if this is the only way to trigger it or if it works every time, this is just what I did):

Log into OSRS
Click on the info button
Hover over some stuff in the panel
Watch the world burn

Expected behavior
I expected the icons to work as they normally do (light up and when clicked launch a link (the link does launch btw))
Screenshots
I decided a video would make more sense
https://www.youtube.com/watch?v=umwMS1iiIe4
Environment (please complete the following information):

OS: Windows 10 x64 1909
RuneLite version: 1.6.20
Launcher version: 2.1.3

https://github.com/runelite/runelite/wiki/Disable-Hardware-Acceleration


Confusing menu option text

At the  Configure Camera Settings  it says as first:
DAYTIME SETTINGS
50 - 160. Changes the amount of light in the image.Low value = dark; high value = bright. Only works with auto-exposure.
The phrase Only works with auto-exposure should be complemented with '(enable hidden option to change)' or something like this. Otherwise, not so familiar with allsky and the existence of a hidden options switch, you search and will not find a daytime auto exposure. Or hit instead the NIGHT auto exposure, which causes other 'problems' hours later beside the default everything on automatic...
Just not to confuse beginners.

4rr4n NB bbbbbbb NB j BBC
.b uh
o.if
N

From: Tartouffe @.>
Sent: Tuesday, November 2, 2021 10:01:44 AM
To: thomasjacquin/allsky @.>
Cc: Subscribed @.***>
Subject: [thomasjacquin/allsky] Confusing menu option text (Issue #756)
At the Configure Camera Settings it says as first:
DAYTIME SETTINGS
50 - 160. Changes the amount of light in the image.Low value = dark; high value = bright. Only works with auto-exposure.
The phrase Only works with auto-exposure should be complemented with '(enable hidden option to change)' or something like this. Otherwise, not so familiar with allsky and the existence of a hidden options switch, you search and will not find a daytime auto exposure. Or hit instead the NIGHT auto exposure, which causes other 'problems' hours later beside the default everything on automatic...
Just not to confuse beginners.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/thomasjacquin/allsky/issues/756, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT2PYK5VUFXQNR26FX3R3EDUJ74K7ANCNFSM5HGVUHWQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

4rr4n NB bbbbbbb NB j BBC .b uh

??
I think your cat has occupied the keyboard 😂

@Tartouffe sorry about that.  I think it was my butt...
Thanks for the feedback.  It will help make the software and documentation better.

Closing - this request was added to the Projects list - see the Projects link at the top of any Allsky GitHub page.
Project Title: Improve message about "Only applies if 'Auto-Exposure' is enabled" #756


Removed $response function argument

In the Authorization Example the before-callback receives 3 arguments, according to the code and options documentation there are only 2 => $request & $arguments.

Good catch. Thanks!


Java 21 master migration with gitignore

This branch replicates the changes of the java-21-master-migration branch, but ensuring that files that shouldn't be tracked remained untracked.
(From the java-21-master-migration pull request) Migrate code base (on master) to Java 21 and Spring Boot 3.2. Most changes were made to the pom.xml, but some minor changes to the code base were made as well (such as changing all instances of javax in imports to jakarta, like javax.persistence to jakarta.persistence)

I merged Nicholas's branch with mine before doing the migration. As for the wiki, what would you like on it? I could talk about the reasons for the migration, how I went about it, and what specific changes were made (although there weren't a lot of changes). Also, would you be okay with me merging this branch with master before making a wiki page?


allow for custom naming convention

There needs to be a way to specify custom resource names for customers that have an established naming convention that differs from the standard.

Done. The resource names are specified in set_names.sh


Document hmr lifecycle hooks

Would be nice to see the hmrOnStatus, hmrOnInit, etc hooks documented better.

@mattdistefano can you make a PR?


COM port may not close fast enough under windows after deploy

This issue addresses a problem that windows does not close a serial port fast enough when you close it: find a comment in the remark field here https://msdn.microsoft.com/en-us/system.io.ports.serialport.close.aspx
If you run now node-red-contrib-modbus in serial mode under windows you are faced with the problem that once you pressed deploy sometimes the serialport module reports "COM port X : Access denied" even if it has issued a close before when the deploying process is started. So the time between closing and starting the flow is too short during deploy process.
This is why I checked the problem is gone if the init() call of modus-getter, read,write is delayed by a timer. In my case 100msec was enough
if(process.platform === "win32") {
setTimeout(init,100); // last deploy on windows may not have closed the COM port so wait a little
} else {
init();
}

That should be fixed in node-modbus or in client node

please test with v0.9.1


A way to not filter options in InputMenu and SelectMenu

Description
Hello,
on our BE we have a geodata endpoint which already makes all the filtering and searches behind the curtain, with the query payload it receives. In our objects we don't have a specific field that is gonna contain the exact string that the component is passing, so, even if the options are populated correctly, the computed filteredOptions remains empty.
My question is:
Is there a way to not use the filteredOptions computed and just rely on the options array just as it is?
Please let me know if I wasn't clear enough

Yes sure ! You can just use the search prop. This prop is a function, and the return values will be the options given to those components.

Thank you very much for your answer.
Not sure this will help me though, as I'm passing the options (fetched in the parent component) as props to UInputMenu

I'm not sure to understand your usage of InputMenu then. Could you elaborate and provide an example ?

maybe command pallete is the component you are looking for?
https://ui.nuxt.com/components/command-palette

Feel free to reopen if it didn't solve your issue.

I am facing the same problem
`

`


Permission revocation of navigation menu items requires forced reload or opening of another menu point to be active for users on their device

If a user's permission to see a menu item is revoked, but the user has opened the menu, the content of the menu will still be displayed in the user's browser. Only the menu item disappears from the navigation bar. Only when the user changes the menu or reloads the page he has no further access.
Reproduction:

Two Accounts are needed; Superadmin und normal user account. Normal should be group staff.
open meeting with both accounts in different browsers
navigate with the normal user account to the participant menu
open as superadmin the participant menu. open the three-dot-menu and choose groups. revoke permission for group staff to see other participants
check the normal user view. menu is gone, but the user still sees the content.

What should happen: When the permission to see a menu item is revoked, there should be an automatic redirection to the first available menu item. Example: If available, then redirect to home page, otherwise redirect to next available menu item.

Goes in the same direction as #1421: I don't think this is important, since it's just visual and for a short moment. I don't think this situation happens often (if ever) in reality, since the permissions are not changed on the fly, and the amount of work required for this exceeds the benefit.

Goes in the same direction as #1421: I don't think this is important, since it's just visual and for a short moment. I don't think this situation happens often (if ever) in reality, since the permissions are not changed on the fly, and the amount of work required for this exceeds the benefit.

I agree that this would be a bit of work, but I don't actually think it would be so much that it would exceed the benefits.
This would likely require a new service that watches the current permissions and checks if the user is still allowed on his current page whenever there is an update. Some of the checking and re-navigating logic could then be handeled by the auth-check.service and the reroute.service (I believe that these two do, in fact already contain large parts of the required logic, so the new service wouldn't have to be that big (we may also just skip the creation of a new service and just handle it all in the auth-check now that I think about it)).

#1553 adds a permissionObservable that always delivers the current permissions. This could be used to implement this functionality.
It would also be a good idea to take a look at the various permission directives, I don't know if they currently update automatically

If it's not much work, we could move this into the 4.0 milestone and tackle this soon.


Update DG

Added a user story and use case in #117
Added Add a Pending Question to a Student under implementation, refer to #124


Add installation notice

Add notice why tts installation of coqui-ai will fail with python 3.10

Thanks xstable - good warning. I've just done a minor edit to fix up some spelling and make it stand out a bit more.


Should javascript files report errors like cannot find module?

moduleTest\a.js
import {a} from "b";
a++;

After compiling this as
tsc moduleTest\a.js --allowJs --outDir moduleTest\OutDir --module commonjs

no errors are reported.

https://github.com/Microsoft/TypeScript/commit/5657469666c8257a9e6bb32d02925e074bf9e522#diff-5f84377bdd5fb13a5afbefcee52563d2R10 shows has testcase for this

But it looks like https://github.com/Microsoft/TypeScript/commit/5772dade970d366f61c8b5bffb0f7d60b1edf8d1#diff-5f84377bdd5fb13a5afbefcee52563d2R10 actually should resolve correctly given that it has a c.js in node_modules

@DanielRosenwasser  we do not pick *.js or *.jsx from external package. Only typescript files irrespective of allowJs

After discussing this, JS file should report "appropriate" errors. https://github.com/Microsoft/TypeScript/issues/7162 tracks doing that.


Vending machines are backwards when placed in villages

Vending machine blocks place backwards within the village structures. On 1.18.2

Ok, thanks for looking into it. If I can isolate the conflict I'll post here.

If this is a modpack on curseforge then I can take a look if you post the pack name/version.


Automatic contrast limits?

Images when loaded, Napari automatically shows only min/max, this can be a problem with artefacts.
Perhaps lets use an automatic contrast setter?
90% quantile as max value should evade most artefacts, but could also kill very good signal to noise stains..
I would rather let the users deal with it

You can also calculate based on some crops in grid pattern in the image, avoiding most artefacts.

I think that makes sense, but still can be problematic. Have seen images were positive signal is less than 1% of area. and if max is hard to change, this will lead to user friction. Rather leave the full range.. However, if good range is too small, say 400 to 1000, this is very inconvenient to drag in 16bit 0-65535, Typing explicit ranges also possible. So nonissue in the end.

For current purposes, I think Napari contrast limits will do.


Fixes#28117: ValueError will be raised when an object contains NUL(0x00) chars on Postrgres DB

https://code.djangoproject.com/ticket/28117

A test is also required.

@timgraham done

@timgraham  Done

@srinivasreddy Thank you for fixing this issue, and thanks to all involved.


A warning occurs when adding an user using object ID on Manage Access dialog

Storage Explorer Version: 1.10.0
Build: 20190911.4
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu 19.04/macOS High Sierra
Architecture: ia32/x64
Regression From: Previous release
Steps to reproduce:

Launch Storage Explore using one mooncake account.
Expand a ADLS Gen2 account -> Blob Containers.
Create a blob container -> Open its context menu then select 'Mange Access...'.
Input an object id then click 'Add' button.
Check the result.

Expect Experience:
One user can be added successfully.

Actual Experience:
A warning occurs after clicking Add button.

More Info:

This issue also reproduces for Azure Germany accounts.
This issue doesn't reproduce for Azure accounts.

Fix checked into master. Also, @v-xianya , if you're going to be testing ACLs for sovereign clouds, make sure you're adding things which are actually in the directory for your sovereign cloud account.
To look for example things to add, you can:

go to the portal for the cloud
go to azure active directory
click on either users, groups, or enterprise applications
use the UPNs or object IDs of any thing that appears after click on those

For example, here's a user in the tenant for our Azure China test account:


Cleanup eddystone code to not pass pointers

Clean up the eddystone example code to pass a EddystoneParams_t using a
reference to the structure rather than passing a pointer when calling
getEddystoneParams().
@pan- @rgrover

@pan- perhaps it would also be good to pass by reference to saveEddystoneServiceConfigParams() and loadEddystoneServiceConfigParams(), but I am not sure this would be idea because that code interacts with C code i.e. pstorage, and there we dont have a choice but to pass the pointers.

Looks good for me. I don't understand why it would be a bad idea to use references for saveEddystoneServiceConfigParams and loadEddystoneServiceConfigParams. The fact that it call c  functions is an implementation detail.

saveEddystoneServiceConfigParams and loadEddystoneServiceConfigParams will be fixed in a separate pull request.


Does not take any action on onPress inside Flatlist

I am generating Google places textfields inside flatlist dynamically. But this stops the onPress function to work(after selecting any place from suggestions does not give any feedback).

I am generating Google places textfields inside flatlist dynamically. But this stops the onPress function to work(after selecting any place from suggestions does not give any feedback).

Its react native problems, check FlatList extraData props

for me when placing it on normal view not scroll view working. but extra space showing..

How can I use it inside Scroll List or Flat List?

Any workaround for this?

Yea, I just put the textfields instead of google autocomplete textfield. When the user taps on any of them. it redirects to another screen which has the Google autocomplete textfield. When th user inputs a place, it redirects back to the multple textfield screen. It's completely a workaround but not a solution to it.

Yea, I just put the textfields instead of google autocomplete textfield. When the user taps on any of them. it redirects to another screen which has the Google autocomplete textfield. When th user inputs a place, it redirects back to the multple textfield screen. It's completely a workaround but not a solution to it.

I ended up doing the same. I've removed the popup i had and created a new screen. Thanks for answering :)

this should not be closed. this is a problem for me too

@nikitph I can re-open this if you have some reproducible code to show what the issue is.

I found a workaround. Keyboardshouldpersisttaps= true inside scrollview
containing the Google place text field. It only happens when field is
nested in a scrollview
On Fri, May 8, 2020, 19:45 Steven Bell<EMAIL_ADDRESS>wrote:

@nikitph https://github.com/nikitph I can re-open this if you have some
reproducible code to show what the issue is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FaridSafi/react-native-google-places-autocomplete/issues/535#issuecomment-625836616,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGGUB2GH3UDPJUT7CE3PCTRQQHY5ANCNFSM4ML2A4JQ
.

thanks @nikitph - that led me to https://github.com/FaridSafi/react-native-google-places-autocomplete/issues/486#issuecomment-665602257

I guess you need this library as well
npm install react-native-virtualized-view --save


Define permissions not based on methods

Hi @fratzinger
Apologies for asking a question, but I can't seem to get any appropriate documentation on this.
As listed in the readme, one can define permissions not based on methods:
Define permissions not based on methods: can('view', 'Settings')
I've added a simple rule (inside defineRulesFor):
can('view', 'Map');
I assume I now have to defined what the rule means i.t.o the Feathers services' CRUD operations?
How does one implement such a permission rule?

Hey @EmileSpecs,
what do you expect can('view', 'Map') will do? I use exactly this type of rules (with a view-action). I define the rules on the server side. With the authentication/login, they get passed to the client side, where I take those and pass them to @casl/vue. Now I can use it there like: https://feathers-casl.netlify.app/client-side.html#just-use-it but the server side just ignores the rules. It's just for having a single source of truth for rules.
For my use-case the view-rules are totally decoupled from the crud-rules. I use the view-rules to hide e.g. MenuItems, or make routes from VueRouter not accessable for certain users. It's more like a kind of sugar.
Which client side framework do you use (angular, react, vue)? And how do you want to use the view-actions? What do you expect from it? 😃

closing due to inactivity. @EmileSpecs is there something left?

Hi @fratzinger
Sorry, I thought I did reply but seems like I intended to but then didn't!
My intent was to use it more like the a kind of "sugar" as you mentioned. For some reason my initial attempt to use it this way (not CRUD rules) didn't work, but subsequently it did.
Thanks for the answer and clearing it up for me.

Perfect. Let me know, if there's something else.


Update cv-utils git tag and pass more cmake flags down to external projects

PTAL @patmarion.

Just curious, what's the use case for the new cmake flags?

CCache mostly.

Do users set all these flags on the command line?

The CMAKE_<LANG>_COMPILER_LAUNCHER variables are the most relevant one, and you would set them to the location of CCache or to a launcher script.


feat: add ability to set custom java path to use when running jars

By default this plugin uses JAVA_HOME to find the correct java path to use. I frequently change my JAVA_HOME variable as I work so having the ability to statically set what the jdk 17+ path is would be really helpful to me and probably others.
This PR is to make setting it as simple as updating the config with the path:
require("spring_boot").setup({
    java_cmd = "/path/to/java17/bin/java",
})

Thank you


Provide plugin configuration options

If I specify  -Dspring.native.remove-yaml-support=true in commandlinerunner, -H:+PrintAnalysisCallTree shows Yaml classes are still included and reflect-config.json includes a org.yaml.snakeyaml.Yaml entry.
Maybe the switch to bti has broken ConfigOptions environnement based flag customomization?

We could maybe set it automatically based on the presence of application*.yml and allow the user to override.

How are you setting it?  There are two stages to think about now

if you want to influence .json computation, have to set it early.
if you want it to influence substitutions, need to set it late.

'Early' currently means early early as in -D passed to the maven command, setting it in build.args is too late.  Setting it late means including it in build.args so that native-image will see it.
I originally allowed it to be set once in build.args in the pom.xml for a sample then my variant of compileWithMaven.sh (while we were getting it going in bti samples) would extract those settings from build.args, ensuring they are set early when calling the mvn command but when we refactored that from individual samples to the shared folder that special handling of build.args was deleted. This enabled you just to specify things once and be set for both places.
I then changed compileWithMaven.sh to include a $* parameter in the call to maven. This means samples could tweak their build.sh scripts to pass -D options through to the maven command line that were specific to that sample, but it looks like you thought it was a typo and deleted it? So now I have no way to pass options to the maven command from individual samples. (i.e. with $* I could put this in build.sh and it would work fine):
${PWD%/*samples/*}/scripts/compileWithMaven.sh -Dspring.native.remove-yaml-support=true && ${PWD%/*samples/*}/scripts/test.sh

Both of the actuator samples were using this ability because they are experimenting with settings that reduce the footprint, but now the extra -D they specify in the build.sh scripts don't work.
The short term fix would be to put the $* back in, but of course specifying things in multiple places is a pain.
The total right thing to do here (I think) is for the maven plugins to offer real configuration settings we can then set via configuration in the XML, then build.args could also be used there I think.
This will build command line runner with no Yaml in the .json:
mvn -Dspring.native.remove-yaml-support=true -e -ntp -Pnative clean package

For the yml being excluded by default (if no application*.yml) - we could do that, the only concern is perhaps the confusion around how to override that since you'd need it both in build.args and on the mvn command right now. Whilst that is still complicated my preference would be do the 'most likely to work thing' by default.

We can do something with maven configuration pretty quickly, if we can agree on how we want it to be, but we'd need to add some form of generalized configuration for bti, rather than specific options related to native. Something like this would work but it is a little crude:
AbstractBootstrapMojo.java
	@Parameter
	protected Map<String,String> options;

And then the maven pom could say something like:
<configuration>
  <options>
    <spring.native.remove-yaml-support>true</spring.native.remove-yaml-support>
  </options>
</configuration>

Then have options available through the build context - we're all set - no need for -D to the mvn command.
That is not particularly elegant with the duplication of the opening closing key name.   Using Properties instead of map is feasible but still the xml is still a little ugly. Happen to learn from a maven guru on the better options.

Yeah I will add such Maven configuration as your proposed. We can ask to Maven experts as a second step.

I think I would prefer to use a more Spring Boot-ish approach for configuration, I am trying to implement what I have in mind.

The Spring Boot-ish way will probably be the target, but it is too ambitious for now. For now I am implementing a regular Maven configuration like:
<configuration>
  <native>
    <mode>agent</mode>
    <removeYamlSupport>true</removeYamlSupport>
  </native>
</configuration>


Module loader

This changes pretty much fix the rendering & including of patterns.
What i basically did was using the registerPartial method just for registering. And actually transpile & render in the renderPattern method.
I abstracted some functions for use within different locations in the engine.

@bramsmulders Can you confirm that the following scenario is not yet supported by this implementation?
I’d like to be able to import components as dependencies in my Edition repository. For example, if I am using React Select as an atom in my project, I’d like to be able to write an atom template like this:
import React from 'react';
import Select from 'react-select';

export default (props) => (
  <Select {...props} />
);

…and then I just declare react-select as a dependency in my Edition’s package.json.
The problem I’m seeing when I try to do something like this is that the pattern engine is unable to find the react-select module. It’s installed as a dependency of my Edition, but it seems like the pattern engine is trying to resolve it using its own dependencies.
Is this a known limitation of your current implementation? And if so, would you agree that it would be desirable to be able to resolve imports using the Edition’s dependencies?

@geoffp:
In the meanwhile i've made lineager & incremental builds possible in the core functionality. And with that I think the core is feature complete.
As mentioned in gitter: I've removed runtime rendering from this branch, and i'm going to work on that in another branch.

Update: I'm going to set aside some time, now that my family life is settling down a bit, to work on this. Sorry for the long absence. I think it's high time for the React engine to hit the mainstream. I think we can actually have it both ways without too much trouble.

And: thanks again for all your hard work, @bramsmulders!


[Service Bus] Issue with service side scalability of management API operations

When multiple related operations are in flight side by side, such as CRUD on subscriptions/rules tied to same topic, the service often returns the error “Resource Conflict Occurred. If this is a retry for failed operation, background clean up is still pending.”.
Some of these did not disappear even when inducing an explicit delay. Customers have faced this issue as well https://social.msdn.microsoft.com/Forums/sqlserver/en-US/b8a3f304-6c6c-4092-8b27-e46c19842ece/service-bus-gateway-timeout-errors?forum=servbus
This issue is to track investigation and related efforts to see if from SDK perspective it's possible to get around the service side problem. One of the approaches suggested (cc: @chradek) is to potentially use core-lro utility.
Once a fix is in place, the tests structure for the API in service bus can be revisited and updated.

Using lro would definitely change the api shape.
Do we see this issue only in one of the CRUD operations or is it non deterministic?

It would need more investigation and seems non deterministic as to which specific operations - but it is on almost all things topics reoperationslated (topic, subscriptions, rules) and not queues.

Related to #6197

On refactoring and updating tests to the initial state where same topic related management operations executed one after the other, the 409 conflict error with background clean in progress error is no longer showing. Unclear if service has rolled any changes pertaining to this.
But as of commit https://github.com/Azure/azure-sdk-for-js/pull/6603/commits/aa96a17ce368446a2afbdad7baf2e2f5ee5d24b2 in #6603, the workaround has been reverted

In that case, let's close this issue. If the problem re-appears in our tests, we can investigate.


Add socket option to specify the listen address

Currently the socket classes listen in INADDR_ANY (<IP_ADDRESS>). Support an optional argument in the SocketOpt struct to specify a listen address to use in place of <IP_ADDRESS>.

Resolved by #8


Error in importing agents, utils, components

In pytorch implementation of the above model, and in 10th cell. You have used following -
from agent import ProximalPolicyOptimization, DisjointActorCriticNet #, DeterministicActorNet, DeterministicCriticNet
from component import GaussianPolicy, HighDimActionReplay, OrnsteinUhlenbeckProcess
from utils import Config, Logger
import gym
import torch
gym.logger.setLevel(logging.INFO)
It is giving me error that agent module does not exist which I think it should because we dont have folder with agent, component name.
I am sorry but I am not able to understand what I am missing here. Please help.
Thanks in advance.

This repo is not maintained so please read the notices at the top of the readme and consider the more up to date repos.
When you say "above model" I'm guessing you mean the DDPG notebook. Try reading it again from the top, if you followed the instructions in the first markdown cell you should have cloned a repository into the DeepRL subfolder, and then run a cell which adds it to the path (os.sys.path.append(os.path.abspath('DeepRL'))), enabling imports from the agent.py file.


Test changes

Do you still need this PR, or are all the tests in #13?

We don't need this any more. I'll close it.


fix: use require instead of install

What in the world was I thinking? :man_shrugging:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
224

Relevant Lines:
224

💛  - Coveralls


Introduce the SVM Interface

Problem
As we continue efforts to split out the SVM and define the official Solana SVM
specification, it makes sense for the SVM to exist as an interface.
Representing the SVM as an interface can offer two main benefits:

Decouple the Solana SVM specification from the Agave implementation, allowing
us to see clearly what the interface needs, and include nothing it does not
need.
Position SVM-specific integration testing (specification compliance) on the
interface, to allow reusable compliance testing for custom SVM
implementations.

In summary, by separating interface (specification) and implementation, we can
mark a clear distinction between the SVM specification and Agave's
implementation of SVM, as well as offer composable tooling for SVM
implementations, such as rollups.
Summary of Changes
Introduce the SVM interface as a standalone crate, then implement this interface
in Agave's SVM crate.
The interface itself is intentionally simple, and comprised of traits.
Note that this interface should not serve as the specification, but rather
specifically as a Rust interface that is specification-compliant. It serves to
offer Rust projects the ability to implement the interface, rather than building
an SVM spec-compliant implementation from scratch.
Note the second commit is huge, since some types that were originally in the
svm implementation crate have been hoisted into the interface.

The first commit is the salient bit. The second commit is integrating the interface within our current SVM.
//! The interface of the Solana SVM.
//!
//! This crate outlines the Solana SVM specification in Rust.
//! Developers who wish to build custom SVM implementations in Rust can use
//! this interface to build a specification-compliant SVM, complete with an
//! integration testing harness to ensure maximum compatibility with the
//! network.

pub mod load_results;
pub mod results;

use {
    load_results::TransactionLoadResult, results::TransactionExecutionResult,
    solana_sdk::transaction::SanitizedTransaction,
};

/// The main interface for the Solana SVM.
///
/// At its core, the SVM is a transaction batch processor.
/// Given a batch of Solana transactions, any SVM implementation must be able
/// to process the batch and return a result.
/// This functionality is fully extentable, allowing developers to add custom
/// functionality, as well as configure their own monitoring tooling, such as
/// timings, metrics, and logging.
pub trait TransactionBatchProcessorInterface<C, T>
where
    C: TransactionBatchProcessorContext,
    T: TransactionBatchProcessorOutput,
{
    /// The entrypoint to the SVM.
    /// Load and execute a batch of sanitized transactions.
    fn load_and_execute_sanitized_transactions(
        &self,
        sanitized_txs: &[SanitizedTransaction],
        context: C,
    ) -> T;
}

/// An extendable context argument to the SVM's
/// `load_and_execute_sanitized_transactions`, for custom functionality.
pub trait TransactionBatchProcessorContext {}

/// The main return type of the SVM interface.
///
/// The output of the `load_and_execute_sanitized_transactions` method.
pub trait TransactionBatchProcessorOutput {
    /// The output of any SVM implementation should retain a list of loaded
    /// transactions.
    fn loaded_transactions(&self) -> Vec<TransactionLoadResult>;
    /// The output of any SVM implementation should retain a list of execution
    /// results.
    fn execution_results(&self) -> Vec<TransactionExecutionResult>;
}

I may be missing the context of this change. Are you trying to make the validator available without the SVM, so that one can implement another transaction procession pipeline while using the existing infrastructure?

Nice. What's the view for rollups -- how will they use the interface and/or the agave implementation? What's the meaning of "tooling" in this context?

@dmakarov @LucasSte Sorry guys, I meant to call out the omission of programs_modified_by_tx but forgot to include it in the description.
My thinking with this omission is that if we can figure out a sensible way to use "plugins" on the SVM implementation - where our programs cache is simply a "program-getter" plugin, then the SVM interface doesn't need to rely on solana-program-runtime as a dependency.
Right now it would have to. Maybe I can work that into the extended response type instead - LoadAndExecuteSanitizedTransactionsOutput.

I think ability to write a test suite for the agave validator without using the whole SVM is a good usecase.
The current SVM API is not final though. Putting an interface on top of it and implementing some alternate/test SVM implementation will make the designing of actual SVM too restrictive IMO.
I think we should defer this interface definition for now. If it helps, we can discuss it more in a call.

I may be missing the context of this change. Are you trying to make the validator available without the SVM, so that one can implement another transaction procession pipeline while using the existing infrastructure?

Sorry @LucasSte I think I missed your msg here when I was replying.
I think the idea of being able to run an Agave node with whatever SVM implementation you want is definitely an interesting concept, enabled by this approach. I think what's more relevant to what we're trying to do, in general, is point all the test harnesses at the interface, and then implementations can inherit all of that compliance-validation tooling by just implementing the interface.
The idea is that you can rest assured it's the exact same interface the validator is interacting with, SIMD- and spec- compliant. The more modularized we make the interface(s) and their subsequent Agave implementations, the easier it is to roll custom crates and use the rest of ours in something like a standalone SVM service or rollup.

I may be a bit pedantic with this, but perhaps the name SVM interface is misleading. I view the SVM as Agave's implementation of the Transaction Processor. If someone else implements it, it wouldn't be called SVM, would it?

I may be a bit pedantic with this, but perhaps the name SVM interface is misleading. I view the SVM as Agave's implementation of the Transaction Processor. If someone else implements it, it wouldn't be called SVM, would it?

I think that's a fair assessment!
The nomenclature is less important, in my opinion, but the term "SVM" has been coined to mean "Solana transaction processing unit" in the broader ecosystem. For example, ETH rollups/L2s are technically standalone "Ethereum transaction processing units", but everyone calls them "EVM rollups" or "EVM-compatible", sometimes just EVM.
To be even more specific, it's technically "Ethereum-spec-compliant transaction processing unit". 😀
You're correct that the code itself should be an accurate description of the relationship between these components, so perhaps a different name is necessary. However, most people are still going to call their project "SVM".


Multiple Series view with two images only.

If I display a series of two images (or a list of two images), the slider at the bottom does not move unless I click beyond the middle. Took me a while to realise that. I though it was not displaying the second image.
Generally the slider seems a little erratic when I have only a few images open. I tried it with 4 and it jumps from left to right in a sometimes unpredictable way.

the width of the slider is set according to the number of images in the series.


After GtIceRepositorySwitcher class>>#switchAll the old unregistered instances of IceLibgitRepository remain referenced

After GtIceRepositorySwitcher class>>#switchAll the old unregistered instances of IceLibgitRepository remain referenced.
IceRepository allSubInstances sort: #name ascending
Consider
(IceGitCliRepository allInstances collect: #name) difference: (IceLibgitRepository allInstances collect: #name)
(IceLibgitRepository allInstances collect: #name) difference: (IceGitCliRepository allInstances collect: #name)
Iceberg/iceberg is a case difference, the others are #('pharo' 'Spec2' 'NewTools' 'Roassal3' 'BeautifulComments' 'DocumentBrowser' 'WelcomeBrowser' 'Microdown' 'tonel'), are/were missing and did all but iceberg did get cleaned up.
The assumption is that some Monticello references still exist from after the original load of the code.

A new method was added, IceRepository>>#gtRelease, to break the cycle and stale reference MCWorkingCopy registry > ancestry > IceMCVersionInfo > commit / package / repository and is being called after switching.
This seems to work, but is loses the ancestry info, which resets automatically to a default. No harm seems to come from this.


[5.4] Update intersect method to allow booleans

Fix for #19991
Before if you passed a boolean value into $request->intersect() it would strip it out - this causes issues when you pass something such as an active state through. This PR fixes that so that it only strips out null values, allowing booleans which equal false to pass through

This would be a breaking change I think. @themsaid any feedback on this?

Would you prefer me to make to make a PR for the 5.5 release @taylorotwell?

Yes this could be breaking since it changes the behaviour in minor release, given that Request::intersect() was removed in 5.5 I don't think we need to apply these changes.
@GeorgeHanson in 5.5 Request::only() achieves what you need.

Thanks @themsaid - I'll switch to that as soon as 5.5 is released!


[Feature Request] A configuration option to remove the rarity from item names.

I love the concept of AcuteLoot, but I'd like it to seem more "integrated" with Minecraft (for a mostly-vanilla server) and this would be quite helpful.

Are you talking about the rarity name in the metadata/tooltip when you hover over an item?

Are you talking about the rarity name in the metadata/tooltip when you hover over an item?

Yupp

Added in 2.1.16, setting display-rarities: false in the config will disable rarities being added to the item lore. This will only effect new items however.


Stop shipping files not needed for native modules

Need to clean up .pdb, .ilk, .lib, .exp files from these native modules:

osx-keychain
clipboard-files
system-format
msint-selectcert (related: https://github.com/microsoft/AzureStorageExplorer/issues/4779)

On Windows this would save north of 41 MB of install space.

Seems mine is a dupe of yours: https://github.com/microsoft/AzureStorageExplorer/issues/5068
It's actually double 41MBs - at least 81MB's! For this class of app given its functionality compared to other similar apps, a target size really should be <=40MB's rather than 491MBs (given fully functional web browsers, frameworks, and even entire operating systems like Windows 2000 are smaller). It makes me think there's a lot more low hanging fruit hiding in space savings beyond the more obvious files that we easily see.

With the Edge WebView2 control, where multiple occurrences of the runtime from different apps are deduplicated via NTSF hard links, you could likely save a chunk more for file space the user. https://docs.microsoft.com/en-us/microsoft-edge/webview2/concepts/distribution It might save memory too, if Teams' experience applies: https://tomtalks.blog/2021/06/microsoft-teams-2-0-will-use-half-the-memory-dropping-electron-for-edge-webview2/

I merged the work to remove those files when packaging the application.

We still have other unused files during runtime. We will track them in a separate issue #5117.

@fdwr , since you seemed interested, after completing all of the size reduction work we had planned for this milestone, we are now just squeaking under 350MB. Only slightly larger than VS Code. There's definitely still more work for us to do in the future though. Thanks for being so involved!

@MRayermannMSFT

There's definitely still more work for us to do in the future though
140MB's is a good first start though. Thanks for listening and pushing it through.


Fix 'cannot spawn .git/hooks/post-rewrite' on Windows

Following is happening:
'''
error: cannot spawn .git/hooks/post-rewrite: No such file or directory: No such file or directory
'''
because the first line of the stubbed post-rewrite is a new-line, which
is interpretted by mingw as "not a shell script".

Updated commit to say this isn't bash that is interpreting that line, but rather mingw. mingw_spawnvpe calls parse_interpreter.

My hero ❤


CI failing for the use of macOS11 runner image

failure - https://github.com/microsoft/cpp_client_telemetry/actions/runs/9889178216/job/27314645563?pr=1286
macOS11 is not longer in the list of available runner images - https://github.com/actions/runner-images
The fix should be to upgrade to macOS12 runner image.

@lalitb thanks for looking this one.


Error: viewer missing on [object Object] | bug

Hi
I have next propTypes:
static propTypes = {
    viewer: propType(getHome),
  }

As you can see viewer is not required. But I can see next error in the console.

console.js:26 Error: viewer missing on [object Object]
    at Home.propsHook (preact-compat.js:542)
    at Home.newComponentHook (preact-compat.js:510)
    at Home.Component$1 [as constructor] (preact-compat.js:568)

problem is in next function of preact-compat
	// add proptype checking
	if (DEV) {
		var ctor = typeof this==='function' ? this : this.constructor,
			propTypes = this.propTypes || ctor.propTypes;
		if (propTypes) {
			for (var prop in propTypes) {
				if (propTypes.hasOwnProperty(prop) && typeof propTypes[prop]==='function') {
					var displayName = this$1.displayName || ctor.name;
					var err = propTypes[prop](props, prop, displayName, 'prop');
					if (err) { console.error(new Error(err.message || err)); }
				}
			}
		}
	}

@seeden any idea what the fix would be?  I don't use PropTypes but as far as I've seen the .isRequired() method is what triggers required validation.  What is your propType() method doing?  That seems important here.


Unable to create node: Failed to get list of pods

Centos 7.3
Using Heketi latest
Custom namespace
deleted all secrets from all ns
Heketi logs
[negroni] Started POST /nodes
[heketi] INFO 2017/10/24 11:33:31 Adding node lndcoruat02
[negroni] Completed 202 Accepted in 2.088751ms
[asynchttp] INFO 2017/10/24 11:33:31 asynchttp.go:125: Started job d9bb68f695018fb3a33bade1fa9b8dba
[sshexec] INFO 2017/10/24 11:33:31 Probing: lndwebuat01 -> <IP_ADDRESS>
[negroni] Started GET /queue/d9bb68f695018fb3a33bade1fa9b8dba
[negroni] Completed 200 OK in 38.413µs
[kubeexec] ERROR 2017/10/24 11:33:31 /src/github.com/heketi/heketi/executors/kubeexec/kubeexec.go:302: the server has asked for the client to provide credentials (get pods)
[kubeexec] ERROR 2017/10/24 11:33:31 /src/github.com/heketi/heketi/executors/kubeexec/kubeexec.go:303: Failed to get list of pods
[asynchttp] INFO 2017/10/24 11:33:31 asynchttp.go:129: Completed job d9bb68f695018fb3a33bade1fa9b8dba in 3.501774ms
[negroni] Started GET /queue/d9bb68f695018fb3a33bade1fa9b8dba
[negroni] Completed 500 Internal Server Error in 50.006µs

Thank you!

Sorry for the delay!
Did you use gk-deploy? If so, do you have the output from that?
Do you have a heketi-service-account and does it have the "edit" clusterrole bound to it?

@Justluckyg Any updates? If not I'll close this issue in a few days. :)


config param for Informed logging

Put the informed logging code behind a config param

The Informed code has been removed and replaced with a mechanism for custom hooks.


Support caching_sha2_password authentication (MySQL 8+)

MySQL 8 does not seem to be supported by this library, any plans to add such support?

@nazar-pc What problem are you seeing exactly? I haven't had a chance to give it a try yet, but if we can identify something that needs to be changed to support MySQL 8, we will take a look as soon as time permits :+1:

I get an exception during connection like this:
{
    "code": 1251,
    "message": "Client does not support authentication protocol requested by server; consider upgrading MySQL client"
}

It's nothing about the library (except for the caching_sha2_password authentication plugin). If you want to make this library work you should make your mysql work with the mysql_native_password authentication plugin.
https://www.php.net/manual/en/mysqli.requirements.php
https://stackoverflow.com/questions/50026939/php-mysqli-connect-authentication-method-unknown-to-the-client-caching-sha2-pa

I've been able to connect using the mysql_native_password authentication.

@clue I think that this issue can be closed :)

I faced an interesting thing. I changed caching_sha2_password to mysql_native_password but I still get same error. The solution is set bindto value in Connector class. For example:
        $connector = new Connector([
            'dns' => '<IP_ADDRESS>',
            'tcp' => [
                // We have to set this correct, otherwise you get that error:
                // https://github.com/friends-of-reactphp/mysql/issues/112
                //'bindto' => '<IP_ADDRESS>:0',
                'bindto' => '<IP_ADDRESS>:0',
            ],
            'tls' => [
                'verify_peer' => false,
                'verify_peer_name' => false,
            ],
        ]);

@kodmanyagha Thanks for your input on this, but I don't think this solved the problem the way you intended to. I can only guess as I don't know all the details here, perhaps you're using different authentication methods when connecting to different databases?
There are some helpful answers in here and I agree with @clue that support caching_sha2_password as the default authentication plugin should be a thing in the future to fully support MySQL 8. We could agree that the original question in this ticket seems to be answered (as @mmoreram rightfully pointed out to close this ticket), but I think we should leave this open and understand this more like feature request to support MySQL 8.


Chat only enforcing to reference search results only on first question

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

If you ask a question more than once, then the chat will bypass the check that is forcing to answer questions.
An example is pasted down here:

Any log messages given by the failure

No logs

Expected/desired behavior

It should always enforce to only reference information from the search query.

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

I saw this behavior as well today.
It seems the

I'm also facing the same issue, is any update on this?

Any update on this, we are facing similar issue.

Same here, it seems I am facing this issue as well. Anyone found a workaround?

Have you tried the latest changes, specifically this PR https://github.com/Azure-Samples/azure-search-openai-demo/pull/529 ? It moves the sources to user conversation, which seems to work better.


Build old revision for iOS?

Hi,
can I still use these scripts if I need to build an old revision (13311) of the  webrtc library for iOS?
Thanks

any updateS?


Loading it will crash the game

Loading it will crash the game

Unrar the cheat first, then run it.


Merge monaco-editor-wrapper and monaco-editor-react into monaco-languageclient's npm workspace

This PR is now ready for review. A couple of open points should be fixed, but review can start now.
This repository now hosts the following npm packages:

monaco-languagclient; Next release: https://www.npmjs.com/package/monaco-languageclient/v/8.0.0-next.4
vscode-ws-jsopnrpc; Next release: https://www.npmjs.com/package/vscode-ws-jsonrpc/v/3.3.0-next.4
monaco-editor-wrapper; Next release: https://www.npmjs.com/package/monaco-editor-wrapper/v/4.0.0-next.4
@typefox/monaco-editor-react; Next release<EMAIL_ADDRESS>monaco-languagclient-examples; Next release: https://www.npmjs.com/package/monaco-languageclient-examples/v/8.0.0-next.4

Important points:

The examples of this repository and the ones from https://github.com/TypeFox/monaco-components have been merged.
Verification examples have been removed from the npm workspace and are now contained in the directory verify.

The Angular example has been integrated here. The build pipeline verifies they are properly building
They have been excluded from main workspace to prevent pollution of the main node_modules (e.g. angular)

monaco-editor-workers is no longer needed and is replaced by monaco-editor-wrapper/workerFactory that integrates ideas from monaco-vscode-api demo and is fully customizable/over-writeable.
Client examples now make use of  monaco-editor-wrapper or @typefox/monaco-editor-react. This made reduces the amount of boiler plate code.

Left over points required at least required to be implemented before this PR can be merged:

[x] Browser example should also use the wrapper
[ ] Update all READMEs/CHANGELOGs and other documentation files
[x] Check if existing bugs should be fixed along or if they should be fixed with a bug-fix release
[ ] The worker based extension host needs to be integrate to allow advanced TypeScript support where needed in the example (wrapperTs and wrapperAdvanced), but this can be deferred.

Will close #543

@CGNonofr I have updated to 2.2.0-next.1 and the font in the command palette is wrong. Should this work without change?

@codingame/monaco-vscode-typescript-basics-default-extension gives me the following error:

and @codingame/monaco-vscode-typescript-language-features-default-extension and throws an error:

Did I miss changes in the vite configuration? I just checked the your demo config and I didn't see something obvious

Did I miss changes in the vite configuration? I just checked the your demo config and I didn't see something obvious

I'm not aware of anything :thinking:
The first error looks like the theme service override is not registered
The second one is probably due to the webworker extension host not working (the local process extension host is not able to replace worker urls by real urls)

I'm not aware of anything 🤔

It is consistently using the wrong font. Did you remove to many global css instructions? Interestingly, codicon is fine. In the past, usually problems originated from there.

The first error looks like the theme service override is not registered

I mixed the classical editor mode of the wrapper with the vscode extensions and therefore the themes override was not loaded. My fault.

The second one is probably due to the webworker extension host not working (the local process extension host is not able to replace worker urls by real urls)

You have a workaround for that problem in the demo, don't you? Could we generalize that somehow. I need to fix the editor worker issue as well, too.

It is consistently using the wrong font. Did you remove to many global css instructions? Interestingly, codicon is fine. In the past, usually problems originated from there.

There were some removed global style I've added back (with some tweaks to remove properties on the body and so on...)
What do you expect and what do you get?

You have a workaround for that problem in the demo, don't you? Could we generalize that somehow. I need to fix the editor worker issue as well, too.

Nop, in the demo, the default extensions run in the worker ext host

Latest force-push using<EMAIL_ADDRESS>fixes the issue above  ⬆

@CGNonofr I am continuing to merge and update the examples (latest code is not yet pushed). Have you seen this error already? Using the standalone editor here with 2.2.1:

I am not importing any workbench related things and I guess that should not be needed.

should i put this https://github.com/TypeFox/monaco-languageclient/issues/595 feature on hold until this WIP PR is merged and released ?
btw, for the language server client runner , is there a way to save the edited value back so that it can submit back to the API?
thx

should i put this https://github.com/TypeFox/monaco-languageclient/issues/595 feature on hold until this WIP PR is merged and released ?
btw, for the language-client-runner , is there a way to save the edited value in code editor back so that it can submit back to the API?   it is related to https://github.com/TypeFox/monaco-languageclient-ng-example/issues/5 ,  i am keen to help to update the angular demo once this two way data binding feature is in place in the wrapper .
thx

should i put this https://github.com/TypeFox/monaco-languageclient/issues/595 feature on hold until this WIP PR is merged and released ?

Yes, that makes sense. I hope to get this ready finally this week. My own availability will be better again now.

btw, for the language-client-runner , is there a way to save the edited value in code editor back so that it can submit back to the API? it is related to https://github.com/TypeFox/monaco-languageclient-ng-example/issues/5 , i am keen to help to update the angular demo once this two way data binding feature is in place in the wrapper .

The wrapper allows you already to get access to the editor/model itself. See for example. https://github.com/TypeFox/monaco-languageclient/blob/merge-monaco-edtior-wrapper/packages/wrapper/src/wrapper.ts#L156-L190 This is also put to use in some of the examples.

@CGNonofr I have merged your worker loading ideas and monaco-editor-workers (https://github.com/TypeFox/monaco-languageclient/blob/merge-monaco-edtior-wrapper/packages/wrapper/src/workerFactory.ts). It is fully customizable and comes with a preset. Paths and the configuration can be completed overridden.

@CGNonofr I have merged your worker loading ideas and monaco-editor-workers (https://github.com/TypeFox/monaco-languageclient/blob/merge-monaco-edtior-wrapper/packages/wrapper/src/workerFactory.ts). It is fully customizable and comes with a preset. Paths and the configuration can be completed overridden.

Does it work with both webpack and vite? In my experience, Webpack only tries to bundle the worker code it the exact literal syntax is used (new Worker(new URL(..., import.meta.url), ...)). Using any intermediate variable breaks it. Or maybe that's a Vite issue?

Does it work with both webpack and vite?

Don't know, yet. Need to still check all verification examples. Will let you know later.
The trick with monaco-editor-workers was always to supply a bundle and to work-around Firefox not being able to handle module workers. But, I just realized this need is gone. Firefox support module worker properly. If you supply the bundled worker in a relative location, you are always able to load it.

Webpack only tries to bundle the worker code it the exact literal syntax is used (new Worker(new URL(..., import.meta.url), ...). Using any intermediate variable breaks it. Or maybe that's a Vite issue?

They both don't support. I have verification examples for all cases in place now. I will integrate the Angular example as well. But all verification examples are not part of the npm workspace only the real examples (=prevent dependency pollution of the npm workspace).

@CGNonofr Angular verification example is in now as well. The old 1.85.0 broke when creating angular production builds with enabled optimization. This is resolved with the latest version. We are now able to quickly test this here as well. I want to get the final release out of the door this week, but there is some work ahead (docs, some further enhancements to worker handling, updating the browser example...). I will let you know once this is ready for review/testing, probably before doc is ready.

@CGNonofr two observations with 3.1.0:

Locale loading works, but the language in the editor (command palette) is still English. This works in the deployed demo
When I configure a standard monaco theme and do not load the theme service override, the theme works, but I see this error 2-3 seconds after the editor is done loading:

I will create a list of required work in the main description above.

But once I load the theme service override package isn't monarch support gone or do I understand this incorrectly?

But once I load the theme service override package isn't monarch support gone or do I understand this incorrectly?

There are 2 different things: loading the service override and using the returned services override in the initialize function. You're not supposed to do one without the other
Btw, I think using both TextMate and monach is possible. Tokenization is registered per language and I see no reason why a different tokenizer type per language wouldn't work (outside of the theme token coloration OFC)

@CGNonofr Thanks for the explanation. I only import it when I initialize it, at least that is the difference in the wrapper. Maybe I introduced an error/wrong import. Sorry, this PR is too big, but I don't know how to make it smaller. 😊
Btw, I updated the PR description and release new next releases a couple of minutes ago that reflect the current state/last commit.

@CGNonofr browser example is updated and your new code highlighted that my local loading was too late. It is fixed now.

@CGNonofr regarding the themes issue. I am positive that textmate and themes services are not loaded. No default vscode default theme is imported, then this error shows up after the 3 seconds timeout. You can check it here: https://github.com/TypeFox/monaco-languageclient/blob/merge-monaco-edtior-wrapper/packages/examples/src/ts/wrapperTs.ts

@CGNonofr regarding the themes issue. I am positive that textmate and themes services are not loaded. No default vscode default theme is imported, then this error shows up after the 3 seconds timeout. You can check it here: https://github.com/TypeFox/monaco-languageclient/blob/merge-monaco-edtior-wrapper/packages/examples/src/ts/wrapperTs.ts

You are importing it from editorAppExtended.ts which is imported by the index of the wrapper

You are importing it from editorAppExtended.ts which is imported by the index of the wrapper

Arrghh, you are right. Damn it. Thank you that makes sense

⬆ fixed ✅

@CGNonofr I have fixed a couple of bugs. Now it's time for the doc update...

@CGNonofr @codingame/monaco-vscode-editor-api is no longer installed as an alias to monaco-editor, because I no longer see the necessity. Something like basic-languages from MS monaco-editor cannot be used as they internally reference the editor api and not the package. WDYT about this approach?

But wait, this will likely become problematic as user may bring in monaco-editor and are not aware of the version clash. 🤔

@CGNonofr monaco-editor is used as npm dependency designation again.

Something like basic-languages from MS monaco-editor cannot be used as they internally reference the editor api and not the package. WDYT about this approach?

I don't understand what you mean, can you explain?

I don't understand what you mean, can you explain?

@CGNonofr  This is linked to https://github.com/CodinGame/monaco-vscode-api/issues/363 . monaco-editor is not modular. The basic and enhanced language support can't be used independently of the editor. They have a relative path reference to edtior.api.js and not to the npm package.
This is a strong advantage of the modular npm package approach you chose for monaco-vscode-api. If this exists for monaco itself one could combine the two. Currently this is not possible without hacks or copying stuff around.
Btw, I pushed some updates again. Some services util functions need to stay in monaco-languageclient otherwise it is no longer really self-standing and I fixed a bug in the enhanced MonacoEnvironment init function I introduced yesterday.

@CGNonofr README updates and LICENSE unification are done. CHANGELOGs are next.

@CGNonofr this is ready for review. Please go ahead.

@CGNonofr this is ready for review. Please go ahead.

There is still a WIP commit, am I supposed to review it?

There is still a WIP commit, am I supposed to review it?

A the first one. Nevermind, go ahead

@CGNonofr It's rebased and the first to commits on the branch have been merged.


legend does not respect itemStyle.opacity

[x] I am using English in this issue. 在这个 Issue 中我使用了英文（强烈建议）。

General Questions

[x] Required: I have read the document and examples and tried to solve it by myself. （必填）我读过了文档和教程，并且曾试图自己解决问题。
[x] Required: I have searched for similar issues and that didn't help. （必填）我搜索过 issue 但是没有帮助。
[x] Required: I have tried with the latest version of ECharts and still have this problem. （必填）我试过最新版本的 ECharts，还是存在这个问题。

In this issue, I have provided information with: 在这个 issue 中我提供了以下信息：

[x] Required: issue type；（必填）issue 类型
[x] Required: one sentence description in issue details；（必填）一句话的问题描述
[x] Required: demo；（必填）能反映问题的例子（如果你想提问或报 bug）
[x] Required: ECharts version；ECharts 版本

Issue Type

[ ] I have a question to ask about
[x] I have a bug to report；我想要报 bug
[ ] I have a feature to request
[ ] I have a feature to enhance
[ ] There's something wrong with the documents；文档有些问题
[ ] Others, or I'm not sure which issue types to choose here；其他，或我不知道应该选什么类型

Issue Details
When overriding the itemStyle in a data series, the legend does not respect the opacity setting.
Expected Behavior

Setting the data[n].itemStyle.opacity should affect both the plot area and the legend.
Current Behavior

Setting the itemStyle.color and opacity results in the legend showing a fully opaque item of the correct color. The opacity is ignored.
Online Example
Using 4.1.0 (only one I could get a link to from jsfiddle):
http://jsfiddle.net/yL64mkn0/

Full code:
var option = {
            title: {
                textStyle: {fontSize:12},
                text:'Legend Opacity Bug'
            },
            toolbox: {
             	 show: true,
             	 feature: {
             	 	 saveAsImage: {show: true}
             	 }
            },
            legend: {
                data:['Value2','Border'],
                right: '10%'
            },
            xAxis: {type: 'time'},
            yAxis: {type: 'value'},
            series: [
				{
                name: 'Value2',
                type: 'line',
                data: [
					[1546377489000, 1.26],
					[1546377589000, 3.68],
					[1546377689000, 5.24],
					[1546377789000, 7.82],
					[1546377889000, 9.95],
					[1546377989000, 11.81],
                	[1546378089000, 13.04],
					[1546378189000, 5.33],
					[1546378289000, 7.84],
					[1546378389000, 3.58],
					[1546378489000, 1.96],
				]
				},
            {
            	name: 'Border',
                type: 'bar',
				itemStyle: {  color: 'green', opacity: 0.3 },
                markArea: {
                            itemStyle:
                            	{ normal: { color: 'green', opacity: 0.3 }},
                            label: {
                                normal: {
                                	show: false,
                                    position: ['0%','50%'],
                                    color: '#000'
                                }
                            },
                            data: [
								[{
                                    name: 'Lower Critical',
                                    yAxis: -99999999999
                                }, {
                                    yAxis: 1.5
                                }],
								[{
                                    name: 'Upper Critical',
                                    yAxis: 9.5
                                }, {
                                    yAxis:<PHONE_NUMBER>9
                                }]
                            ]
                }
            }
            ]
        };

Topics

[x] Legend
[ ] Tooltip
[ ] Event
[ ] Performance
[ ] SVG
[ ] Map
[ ] ECharts GL
[ ] Third-party libraries, e.g.: Vue.js, React

Anything Else We Need to Know
N/A
Environment

ECharts version 4.2.0-rc2；ECharts 版本: {DESCRIBE_HERE}

[ ] It happens only on certain browsers or operating systems. 对于特定浏览器或操作系统才会出现的问题，请提供相应环境信息：{BROWSER_VERSION_OR_OS_INFORMATION_HERE}

Currently only color and symbol will be reflected in the legend.


Add flake8. Make code pretty

Pull Request Test Coverage Report for Build 66

18 of 19 (94.74%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 96.075%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

openregistry/lots/loki/validation.py
7
8
87.5%

Totals

Change from base Build 65:
-0.01%

Covered Lines:
1885

Relevant Lines:
1962

💛  - Coveralls


[Revise text def]

Bilateral frontoparietal polymicrogyria MONDO:0011738
**Bilateral frontoparietal polymicrogyria (BFPP) is a descriptive term reflecting increased gyral folding in the frontoparietal regions as determined by magnetic resonance imaging. It has subsequently been shown to represent a cobblestone malformation on histopathology. BFPP typically presents with hypotonia, developmental delay, moderate to severe intellectual disability, pyramidal signs, epileptic seizures, non-progressive cerebellar ataxia, deconjugate gaze, and/or strabismus. **
https://www.clinicalgenome.org/affiliation/40020/

Hi @madysoncbrown - thanks for this ticket. We'll work on this in November or later, thank you for your patience.

Thanks @madysoncbrown, I updated this definition.


Added class PromptsFromFileInvocation to prompt.py.

A new PromptFromFile custom node the provides similar functionality to the old 2.3.5 --from_file CLI command.  It reads prompts from a file one line per prompt and outputs them as a prompt collection. With inputs for filename, pre_prompt, post_prompt, start line number, and max_prompts. A max_prompts of 0 will read  int32.max number of lines from the file.
This replaces the messed up pull request I closed PR "Create prompts_fromfile.py " https://github.com/invoke-ai/InvokeAI/pull/3757

Additionally I added a @validator to check for the existence of the file_path and raise an error if not found


⚠ Bofrost.at has degraded performance

In 6a3c1a3, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2071 ms

Resolved: Bofrost.at performance has improved in 505df78.


Feature request：When I send a picture or video from phone to PC，give me an option to delete the source files from my phone?

Is your feature request related to a problem? Please describe.
no
Describe the solution you'd like
If I choose to delete option, after the file transfer is completed, the transmitted source files will be deleted from my phone, thus saving phone space.
Describe alternatives you've considered
No response
Additional context
No response

+1 :)


The document seems not right...

By following the doc written in README.md
I should get {"errors":[{"message":"You have to set GraphQL Schema to process"}]} this error, but I got:
[
  {
    "message": "Schema class AppBundle\\GraphQL\\Schema does not exist"
  }
]

( I don't the array as the root level result... )
After I generate by php bin/console graphql:configure AppBundle and also added the config. When visit localhost:8000/graphql?query={hello}, I got:
{
  "data": {
    "hello": null
  },
  "errors": [
    {
      "message": "Notice: Undefined index: name"
    }
  ]
}

Just first touch graphQL...

Hi @yarcowang , it seems like you forgot to add routing for the default GraphQL Controller to your app.
it's from the readme:
Add the routing reference to the app/config/routing.yml:
graphql:
    resource: "@GraphQLBundle/Controller/"

@viniychuk I've already added that...
$ cat app/config/routing.yml
app:
    resource: '@AppBundle/Controller/'
    type: annotation

graphql:
    resource: "@GraphQLBundle/Controller/"

@yarcowang your default controller intercept the routing – that's the default response from the Symofony's autogenerated stuff... Also check if you have bundle enabled and so on... Just try to do everything step by step again

I got the same responses.  Documentation seems to be out of date.
After looking at the generated Schema, it says "Stranger" would be the default response (not "World").  Mine simply responds with:
{ "data": { "hello": null }, "errors": [ { "message": "Notice: Undefined index: name" } ] }

Being unfamiliar with GraphQL, I'm not sure how name would be set.  I can get it to respond by removing return 'Hello ' . $args['name']; and replacing with a hardcoded name (eg. "World").
Also, the docs say to add:
graphql:
  schema_class: AppBundle\GraphQL\Schema

But the sample app uses:
graph_ql:
    schema_class: "AppBundle\\GraphQL\\Schema"

Hi !
I've got the same problem :/
The problem comes from the build action, into the the new Schema class generated :
    public function build(SchemaConfig $config)
    {
        $config->getQuery()->addFields([
            'hello' => [
                'type'    => new StringType(),
                'args'    => [
                    'name' => [
                        'type' => new StringType(),
                        'default' => 'Stranger'
                    ]
                ],
                'resolve' => function ($context, $args) {
                    return 'Hello ' . $args['name'];
                }
            ]
        ]);
    }

The $args argument in the resolve function seems to be an empty array :/
Any Idea ?
I would like to test GraphqlBundle before to make a choice between this one and FOSRestBundle.

Okay men sorry for the earlier post ( @bjunc I undertood what you meant but telling the solution would have been better :P)
@yarcowang here is the right syntax of the http query :
http://<IP_ADDRESS>:8000/graphql?query={hello(name:"john")}

@viniychuk  As mentioned bjunc, that would be a great idea to implement simple examples of how GraphQL works with symfony for those who are not familiar with it (like me ^^).
Sorry for the double post and hope that would help !

@bastos71 after some poking at it, I ultimately abandoned the "hello world" example.  When I started reading through the extensive Youshido/GraphQL repo docs, I was able to create a schema from scratch, and make calls through Postman and the graphql explorer.  I would be happy to create some basic examples and do a pull request.
Also, I created a javascript (axios) gist for my own notes, just to show the difference between sending a request through application/json and application/graphql.  While not specific to Symfony (or even PHP), I think some broader explanation of GraphQL would help people adopt and evolve this bundle.
Here's the gist, if you're interested: application/graphql vs application/json
I even started creating a REST wrapper around GraphQL.  Basically, I lifted some of the logic in the GraphQLController (Youshido\GraphQLBundle\Controller), and exposed CRUD methods that run GraphQL queries (and mutations!).  For me, this was a pretty helpful learning experience.
/**
 * @Route("/api/v1/users/{accountId}")
 * @Method("GET")
 */

public function getUserAction($accountId, Request $request)
{
    $query = "{ user(id: $accountId) {
        id first_name last_name mail full_name phone dob
        address { thoroughfare city state postal_code }
    } }";
    $responseData = $this->processGraphQL($query);
    return new JsonResponse($responseData);
}

The processGraphQL() method is the custom method I spoke about that lifts some logic from the GraphQLController.  From there, the schema resolve methods essentially act as a serializer for your entities (I'm not using the Symfony Serializer or JMS).  You can pretty easily add a voter system as well, for top level permissions, or even nested fields.  There is some (albeit vague) reference to this in the docs, but I think it needs further explanation / examples.  I could definitely see how that could hurt performance.
Deserializing is a little more complicated, and I am still working through how I think it is "best" done.  I created a custom denormalizer to convert the GraphQL input back into entities that can be saved.
Personally, I think the PHP and Symfony community are going to need real-world examples before they can feel comfortable really getting into this.  The Node.js community seems to be much further along in this regard.

Seems pretty cool !
I'm still learning how to work with Graphql and it seems to be kind of magic ^^
I do not think I've gone further enough in Graphql to understand all your work in it's globality, but for sure I agree with you : it has such potential to build an easy-to-use (and easy-to-build) API 👍
But I think we've gone too far for this issue ^^

@bastos71 @bjunc @yarcowang The problem is in dependencies. Updating it and will make sure we have the up to date example. Sorry guys.

all fixed in v1.3.4

@bastos71
Thanks for the syntax. Yes, it could work. But for the schema does have the definition of the default value 'default' => 'Stranger', I suppose it can output Hello Stranger.
@bjunc
I don't think you are on the right way of thinking GraphQL. In my mind, GraphQL = REST + Serializer, or a higher level thinking of getting data.
It does not have any sense to envelope the GraphQL to REST. REST is for getting one main entities and it's related things (like topics and comments); GraphQL is to get several entities even they have no relationships but only for performance. (Not quite sure whether it is right nowadays, cause there is HTTP2. But for mobile client end, maybe such performance is still required for there's the limitation of creating a lot of sockets -- not quite sure.)

@yarcowang I think you're missing the point of the exercise.  It was two fold:

Get familiarity with GraphQL within the context of the familiarity I have with REST.
Since it is likely that we would continue to offer a REST API, the ability to wrap a REST endpoint around a GraphQL query/mutation would mean easier maintenance of two concurrent APIs.

I'm not arguing that GraphQL can do more than REST, and that the thought process is a bit different.  It'd be silly to do all the GraphQL work to only offer a REST endpoint.  But if you're offering a GraphQL endpoint, you can also offer a REST endpoint using simplified queries so you're not forcing your integrators to use GraphQL before they're ready.

@bjunc Yes, that sounds reasonable. But what I'm thinking is to envelope the REST API as GraphQL (just like some integration gateway or serializer), that would save a lot of time on migration from current RESTful projects to GraphQL. (And I think there may already exist such project, or at least in javascript )


Added new parameter 'message_retry_set' to the Client.init. Set the timeout in seconds before a message with QoS>0 is retried. 20 seconds by default.

Thanks for the pull request. Let me have a look. :)
Nice and simple. :+1: Thanks for your contribution to asyncio-mqtt.


The Kernel crashed while executing code in the current cell

Hi! Thanks for writing Squidpy! Its really amazing!
I'm running into an issue and I'm not sure if its an issue with squidpy itself or how I'm running the code or space on my computer. I cannot run sq.gr.ligrec or sq.gr.spatial_autocorr without my kernel crashing. Is there something I am missing? Do I need to run this on the HPC?
Info about my data:

Xenium data
adata object is n_obs × n_vars = 53466 × 339
The size of the object is: 100039055 bytes (code: sys.getsizeof(adata))
The size of the object is: 151294272 bytes ( code: asizeof.asizeof(adata))

I've tried reducing my dataset to 0.2 and reducing the permutation to as low as 2 just to try to get it to work but every time I get the miss error:
The Kernel crashed while executing code in the current cell or a previous cell.
Please review the code in the cell(s) to identify a possible cause of the failure.
Here is the code I'm running
adata_subsample = sc.pp.subsample(adata, fraction=0.2, copy=True)
sq.gr.spatial_neighbors(adata_subsample, coord_type="generic", delaunay=True)
res = sq.gr.ligrec(
    adata,
    n_perms=2,
    cluster_key="new_clusters",
    copy=True,
    use_raw=False,
    transmitter_params={"categories": "ligand"},
    receiver_params={"categories": "receptor"},
)

and with the Moran I
adata_subsample = sc.pp.subsample(adata, fraction=0.2, copy=True)
sq.gr.spatial_neighbors(adata_subsample, coord_type="generic", delaunay=True)

sq.gr.spatial_autocorr(
    adata_subsample,
    mode="moran",
    n_perms=10,
    n_jobs=1,
)
adata_subsample.uns["moranI"].head(10)

...
Any suggestions would be really helpful!

Also having the same issue with VisiumHD data (140k + spots/barcodes with over 15k genes)
Perhaps it isn't optimized to support over 20-30k spots and so it crashes due to memory issues?

Hi @spatts14, @Rafael-Silva-Oliveira,
squidpy should be able to handle data sets of the size you mention. When the kernel crashes, is there any error message? Perhaps this is a RAM issue? Does it also happen if you run it on a machine with more RAM?

I think there was an issue with my conda environments. I had to uninstall anaconda and redownload and recreate my environments.


Optimized stringifier for base 16.

Coverage increased (+1.5%) to 86.441% when pulling 8d663a3f70958ea2d8c4d728ba5b530a14757a93 on pwnall:hex_speedup into 04d411fe65ae453d8f627be17325089daafefaff on heap:master.

Coverage increased (+1.5%) to 86.441% when pulling ffefad72ad21a3595885c5e84f418356741c5748 on pwnall:hex_speedup into 04d411fe65ae453d8f627be17325089daafefaff on heap:master.