Uncaught ReferenceError: setImmediate is not defined

I have tried this solution but doesn't work anymore.

... adding 3 user maintained dependencies for semantic logs across an app is, a bit disheartening. It would be great if we could package winston into the browser transport... there is little overlap with browserside use and server side use.
Perhaps we could grab the React and Vue crowd which are desperate for decent consistent logs across first party modules.


test(resolver): add a test case that explicitly verifies ownership transfer

Description of the change:
This adds a test case to the resolver that explicitly checks that an api can transfer ownership from one operator to another during an upgrade.
Motivation for the change:
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /docs
[ ] Commit messages sensible and descriptive

Merging the changes introduced here into https://github.com/operator-framework/operator-lifecycle-manager/pull/1483


MainDesktop.mxml instead of MainDesktop.as

There is possibility to change .as to .mxml to search Main{target} class?

Or simply option to define program access point class


Rec.CurrentCompany lost information

If the record is not passed by reference but by value into a procedure, the information from which Company this record comes from is lost.

to reproduce:
    local procedure test()
    var
        BankAcc: Record "Bank Account";
    begin
        BankAcc.ChangeCompany('CompanyTwo');//Select another Company than the Current Company (CompanyName())
        BancByRef(BankAcc);
        BancByVal(BankAcc);
    end;

    local procedure BancByRef(Var BancAcc: Record "Bank Account")
    begin
        if BancAcc.CurrentCompany = CompanyName then // this will be false. Its Correct if you change the Company of the Record.
            ;
    end;

    local procedure BancByVal(BancAcc: Record "Bank Account")
    begin
        // this will be true. Its not Correct becouse you change the Company of the Record.
        // it is not known from which company this record comes from
        if BancAcc.CurrentCompany = CompanyName then
            ;
    end;

Then I have all the information I need with this.
I do not think that is good. Some things that have always been the way they are need to be changed. Information about the origin of the data (temporary table or from the database and from which company) are from my point of view something completely different than any custom data (global variables etc.). I see this information on the same level as the Field values. Therefore, they simply belong with copied even without var. Or there should be some other way that when passing a record variable can be determined whether this information comes along.
e.g.:
local procedure someDoIt(Contact: Record Contact WithOriginInfo;...
This is quite interesting for events, because data is passed, even without var, but the triggers of the events could come from another company. As a subscriber I have no possibility to find out in which client I should do something, because this information is lost. Under some cases even wrong data constructions can result, where an error analysis can take a lot of time.
Translated with www.DeepL.com/Translator (free version)

And the change from C/AL to AL and the further developments demonstrate that some dinosaurs can also be civilized
;)


Cannot get simple react-native app to work on either Android or iOS

npx-version: 10.2.0

React-native info:
System:
    OS: macOS Mojave 10.14.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 130.27 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 10.17.0 - ~/.nvm/versions/node/v10.17.0/bin/node
    npm: 6.11.3 - ~/.nvm/versions/node/v10.17.0/bin/npm
  SDKs:
    iOS SDK:
      Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
  IDEs:
    Android Studio: 3.1 AI-173.4720617
    Xcode: 11.2.1/11B500 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.5 => 0.61.5

Simply initialising a new react-native app and running it (I get the same when I try to run on Android):
npx react-native init Test10
cd Test10
npx react-native run-ios

In the Metro Bundler window, the error log i get is:
/Users/***/test/Test10/node_modules/react-native/node_modules/@react-native-community/cli/build/index.js:154
  const cmd = _commander().default.command(command.name).action(async function handleAction(...args) {
                                                                ^^^^^
SyntaxError: missing ) after argument list
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:542:28)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/jonasl/test/Test10/node_modules/react-native/cli.js:13:11)
Process terminated. Press <enter> to close the window

In the simulator I get:
No bundle URL present.

Make sure you're running a packager server or have included a .jsbundle file in your application bundle.

RCTFatal
__28-[RCTCxxBridge handleError:]_block_invoke
_dispatch_call_block_and_release
_dispatch_client_callout
_dispatch_main_queue_callback_4CF
__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
__CFRunLoopRun
CFRunLoopRunSpecific
GSEventRunModal
UIApplicationMain
main
start

In the finder window where I ran the commands I get:
info Found Xcode workspace "Test10.xcworkspace"
info Building (using "xcodebuild -workspace Test10.xcworkspace -configuration Debug -scheme Test10 -destination id=96CA3786-25D8-4573-AAD9-50B7F76CB207 -derivedDataPath build/Test10")
..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
info Installing "build/Test10/Build/Products/Debug-iphonesimulator/Test10.app"
info Launching "org.reactjs.native.example.Test10"
success Successfully launched the app on the simulator

I appreciate all the help I get :)

You created a project with name Test10 but logs of metro bundler shows Test3. (/Users/***/test/Test3/...)
Please be sure, your metro bundler  is working in the right project.
Open a terminal, go to the Test10 project folder and start metro bundler with reset-cache parameter.
npm start -- --reset-cache

Then open a seperate terminal window and run the command below
npx react-native run-ios

Hey! I got the same error. I updated the original comment

Solved. I initially used nvm. Used node outside of nvm and it worked. Unfortunately I didn't write down which version of nvm I used, but I tried with different versions of node within nvm (v10 and v13 something)

Commenting in case anyone else runs into this, or similar errors.
I was running into the same syntax error as OP. Found out that every time a new terminal window was opened, nvm was reverting to an older version of node. Using node v13.11.0 solved this problem along with this stack exchange article: https://stackoverflow.com/questions/24585261/nvm-keeps-forgetting-node-in-new-terminal-session
Since running react-native run-<YOUR PLATFORM> was opening another terminal window, that new window was where I was still running into the issue.
Basically I had to make sure nvm was initializing a new terminal window with the correct version of node
nvm alias default <NODE VERSION YOU WISH TO USE>

Just for reference, the problem I had was using an older Node version. I have NVM, and switch between versions, and I was on an older version. Please make sure to use Node 12 and up. Hope that's helpful.


refactor: Move log deriv lookup accum to library

The logic for accumulating the log-derivative lookup relation subrelation contributions is generic and can be reused. It was previously implemented in the accumulate method of the eccvm lookup relation. This work moves the logic to an existing lookup library in preparation for reuse by the databus log-deriv lookup relation.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit d707d4e3 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
222,864
868,148
3,448,124

l1_rollup_execution_gas
841,951
3,595,256
22,203,493

l2_block_processing_time_in_ms
1,978
7,569 (-1%)
29,795

note_successful_decrypting_time_in_ms
293 (-1%)
884
3,213 (-1%)

note_trial_decrypting_time_in_ms
95.0 (-5%)
92.0 (-5%)
135 (+1%)

l2_block_building_time_in_ms
13,246
52,789
209,790

l2_block_rollup_simulation_time_in_ms
11,902
47,448
188,603

l2_block_public_tx_process_time_in_ms
1,305
5,199 (-1%)
20,691 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
21,660 (-1%)
42,236 (-1%)

note_history_successful_decrypting_time_in_ms
2,014 (-1%)
3,937

note_history_trial_decrypting_time_in_ms
120
142 (-1%)

node_database_size_in_bytes
1,632,300
1,099,421

pxe_database_size_in_bytes
29,748
59,307

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
773
61,697
18,905

private-kernel-ordering
123
24,297
8,153

base-rollup
1,774
656,311
814

root-rollup
81.5 (+5%)
4,072
1,097

private-kernel-inner
788
81,568
18,905

public-kernel-private-input
41.5 (-1%)
41,519
18,841

public-kernel-non-first-iteration
26.3 (-1%)
41,497
18,841

merge-rollup
0.935 (+1%)
2,592
873

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
8,787
27,547


Search error

This happens when trying to search anything:

I believe this is already fixed in master. @frdmn can you perform a patch release? Thanks.

Just released 1.5.7 :)


Update azure-sdk-go-qs-vm.md

Fix typos and a password's length requirement.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azure-go-sdk-conceptual/azure-sdk-go-qs-vm.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@alexandair Thank you for your contribution!


[docs-infra] Test the link check script

          The cleanest way I can think of would be to extract the script logic into packages-internal/scripts, test it there and leave just the CLI in the scripts directory.

Originally posted by @michaldudak in https://github.com/mui/material-ui/issues/43144#issuecomment-2270663097
For context, the script which takes care of verifying each internal link point to an existing page, and an existing anchor was doing nothing (except eating some CPU time)
It would be nice to have a test that ensures it fails
Search keywords:

Hey @alexfauquette, what needs to be fixed specifically?

This issue is about testing the script is working as expected.
The idea would be to have two markdown files, one with broken links, one with ok links, and run test that ensure the script is failing on the correct one and passing the other one.
This should avoid the issue we got with the script silently failing because it detected no link


Tilbakemelding
Box background prop docs say 'accepts a color token', this seems very generic (all our colors?)
Actual type is named 'BackgroundToken', this seems very constrained (just our bgColors?).
The type then resolves to 'bgColors + surfaceColors'. This is a bit messy, and there could probably be a single transparent term for all of them.

Would Semantic colors be generic enough?

Did some improvements to the JSDOC now. When it comes to the type name "BackgroundToken", one could argue that it refers to the prop and not to the actual semantic color tokens, but it's a stretch because of the "Token" suffix.
Suggestions:

Rename "BackgroundToken" to "BoxBackground".
Split "BackgroundToken" in two: background?: BackgroundColorToken | SurfaceColorToken;
Do nothing, JSDOC improvement was sufficient.

Split "BackgroundToken" in two: background?: BackgroundColorToken | SurfaceColorToken;

Like this one


keyword - Google search failed with error 429

Error message: The requested resource cannot be found! Please make sure your input parameters are correct! cUrl error:  (0) PHP error:
Query string: action=display&bridge=GoogleSearch&q=keyword&format=Atom
Version: dev.2019-09-12

429 errors are common errors for public rss-bridge instances
You are using old version (dev.2019-09-12) of RSS-Bridge

I've just updated to the dev.2020-02-26 version. This error is still happening. I think Google has changed something in their firewall.

This error is still happening. I think Google has changed something in their firewall.

I cannot reproduce it on my side. https://feed.eugenemolotov.ru/before/?action=display&bridge=GoogleSearch&q=keyword&format=Atom

This error is still happening. I think Google has changed something in their firewall.

I cannot reproduce it on my side. https://feed.eugenemolotov.ru/before/?action=display&bridge=GoogleSearch&q=keyword&format=Atom

That's weird. Could you share me your current Google Search bridge?

That's weird. Could you share me your current Google Search bridge?

It is the same as current one: https://github.com/RSS-Bridge/rss-bridge/blob/master/bridges/GoogleSearchBridge.php

That's weird. Could you share me your current Google Search bridge?

It is the same as current one: https://github.com/RSS-Bridge/rss-bridge/blob/master/bridges/GoogleSearchBridge.php

Looks like Google blocked my host's IP


Missing heading data

Hi,  I've been trying to extract text from some sites.  The following may be an issue or a feature.  I'm new to programming and python so not quite sure
I'm finding that the extract is missing heading and list data.
For example - http://bouncebackhigher.com/articles/empathy-a-critical-skill-for-effective-leadership/
The headings What is Empathy? and  What are the Traits of an Empathetic, Effective Leader? don't appear in the clean text. Text in lists also doesn't seem to extract. The headings are useful markers splitting the text,

@Eddies101 I agree that those would be useful items to extract. I haven't had the time recently to look into why lists and headings are not being extracted. Any help would be greatly appreciated!

@barrust I also see that even the current implementation doesn't handle lists and headings well. Any updates on this?

@abs51295 I haven't had time to look into this; any help would be appreciated!

Sure @barrust I would like to contribute to this! Any pointers to get started or where to look at? Thanks :)

In crawler.py
The problem seem to come in
self.article.cleaned_text = self.formatter.get_formatted_text()   (around line 198)
The raw html (self.article.top_node) before going into this function seems fine but the return from the function seems to be have no list data.
I hope this helps

Merged the ability to pull in #52


Added dependencies for issues (#2196)

Introduction
This PR implements dependencies for issues, as described in #2196.
It lets you define anonther issue as a dependency for an issue. You the cannot close the issue if it has any dependent issues which aren't closed. If you try to autoclose an issue via commit message which still has dependencies left, autoclose will simply not close the issue, but the commit will not fail.
You can disable dependencies in the repo settings.
Example: You set #2, #3 and #4 as a dependency of #1. Now you need to close all #2, #3 and #4, before you can close #1.
Screenshots
Adding a new dependency:

Overview of Issue Dependencies (sidebar):

Comments after adding a new dependency:

Questions
Currently, i would describe this as "working, but not finished", as there are some questions i have:

For now, you need the issue ID (not the index) to create a dependency. This is not very user-friendly, I'd like to have some kind of search bar where you search for the issue title/index select it, and it'll do the rest. Problem: There is no API-Endpoint to search for issues like that (Or just returns a list of all issues as JSON). I think this should be implemented first.
If such thing already exists, please point me to it, I haven't found any.
It is currently possible to create dependencies with issues from other repositories. Is this okay? Or should one not be able to do this, as it could create a massive overhead with all permission-checking etc.
There is some work to be done with migrations etc, currently i simply put the xorm-call at the beginning of the function, which probably shouldn't be there. Where is the appropriate place to put this?

This is my first time I've done something like this in Go, before i've only played around with Go but never really did anything bigger. So, there are probably some things I didn't got right as a novice. Looking forward to hear your improvents to be made! Also thanks to @JonasFranzDEV who has helped me a lot.

@Morlinest @JonasFranzDEV Done.

@kolaente conflicting files.

@lunny Done.

Can you add some screenshots pls?

@Morlinest of course, please see my updated first comment.

And we really need a better way to search for other issues (see my first question)

@kolaente Thx for screenshots. And yes, we need better search. Adding issue search api would be great.

Adding issue search api would be great.
@Morlinest wouldn't this be a seperate pr?

Yes, as another PR. Maybe I can do something with it.

I've created a seperate issue for the api endpoint so we dont forget it: #2597
@Morlinest

However, am i right when i say this pr is blocked until we have an apiendpoint to search for issues?

@kolaente No. Searching can be added later. Also I am working on issue search api right now, There is api endpoint for issues, but doesn't contains search by part of ID. You can wait for it or use it as it is now, without partialy ID matching.

Ok, cool. But i should change it so you only need the issue index, not its id (as it is right now).
Also, a more general question: should we allow dependencies across repositories? It doesn't check currently which repository the id belongs to you give it.
If so, this probably could create some problems with different access rights of a repository... (If I set a dependency to another repository, to which user B doesn't have access and he looks at the issue, should he see the dependent issue (from the other repository) or not, what if he tries to close it and so on... This could be solved, but it surely is worth thinking about.
(For now, I think I'll just implement it with the issue index, later, when we have the search we could probably think about dependencies across repositories)

It should be possible to add dependency only on same repository. One of reasons (for me) is security and access rights.

@kolaente I've finished (at least first version, but working very nice) index search for issues api. Will send PR tomorrow.

Ok, then i'll wait until this is merged to master (or shouldn't I?)

Don't wait. Maybe changes to current api is not needed for this feature (read #2606 - you can use existing api and load latests issues for making suggestions).

you can use existing api and load latests issues for making suggestions.
The problem is, there is no api to get a list of issues (not even one issue). Or did i overlooked something?

Yes, overlooked :) /api/v1/:username/:reponame/issues

It's not documented on swagger, maybe thats why you overlooked it.

Maybe its not documented because it doesn't work....? (quickly tried it, no luck. Was signed in, didn't work either on try.gitea.io)

Okay, seems like its /api/v1/**repos**/:username/:reponame/issues

Right, sorry I wrote it from hand

I think this is okay now. Or has anybody suggestions on what to improve?

@kolaente There are more things to do and improve, you are not done yet :) Need time to review, a lot of code...

@lunny @lafriks What do you think about using Unit for this feature? I think it should be part of UnitTypeIssues and can be also part (can be another PR) of UnitTypePullRequests. I see at least 2 reasons:

It doesn't have own page
It can't work without Issues/PullRequests

@bkcsoft Fixed the indetion and the ini stuff, don't know about time-tracking mismatch...
Also merged with master, my branch is now up to date. So it shouldn't be a problem (should it?).

Your PR deletes public/vendor/plugins/gitgraph/gitgraph.js file

@lafriks Yes, fixed with a lot other unleated changes.

Codecov Report

Merging #2531 into master will decrease coverage by 0.09%.
The diff coverage is 21.56%.

@@            Coverage Diff            @@
##           master    #2531     +/-   ##
=========================================
- Coverage   26.84%   26.75%   -0.1%
=========================================
  Files          89       90      +1
  Lines       17608    17748    +140
=========================================
+ Hits         4727     4748     +21
- Misses      12195    12312    +117
- Partials      686      688      +2

Impacted Files
Coverage Δ

models/unit.go
0% <ø> (ø)
:arrow_up:

models/repo.go
12.87% <0%> (-0.16%)
:arrow_down:

models/repo_unit.go
7.69% <0%> (-0.31%)
:arrow_down:

models/models.go
28.38% <100%> (+0.31%)
:arrow_up:

models/issue_dependency.go
17.44% <14.45%> (ø)

models/action.go
53.93% <33.33%> (-0.16%)
:arrow_down:

models/issue_comment.go
29.31% <43.9%> (-1.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ccaddc...827291e. Read the comment docs.

Can you add tests for the new functionalities ?

@strk Yes ofc, will do this weekend.

@strk Done.

@kolaente migration conflict since some PR merged.

@lunny Fixed.

@lunny Fixed the sess-stuff, but Github didn't update... again... but you can see the changes in my repository: https://github.com/kolaente/gitea/blob/master/models/issue_dependency.go

conflicted

@lunny Resolved conflicts.

@bkcsoft I fixed the statuscode stuff and added a migration for comments.

Since there's no migration to enable them on each repo. I think it's fine to keep it enabled for new repositories though 🤔

So, when the user upgrades it's Gitea instance, no existing repository has issue dependencies enabled, but all new ones get this by default?

I think all existing repositories must have set default that is specified in app.ini

@lafriks So, we should check inside the migration for the config and update everything accordingly and when it does not exist we use the global default (=on)?

It currently does nothing, which simply means issue dependencies are disabled for existing repos.

@kolaente no create migration that sets that for all existing repos (there is already such migrations)

@lafriks ok I'll do that.

On a side note, should I update the copyright header in all issue dependency files to "Copyright 2018 .." as we're in 2018 now?

@kolaente as these are new files than, I would say yes but not required

@lafriks seems like it is already in the migration: https://github.com/kolaente/gitea/blob/master/models/migrations/v57.go#L79

@kolaente as these are new files than, I would say yes but not required

Ok, I updated it in new files.

@bkcsoft fixed import order

Thanks!

Ah, yes, one last thing: I think we should use semantic's search module for picking issues on the sidebar, or at least allow users to place an issue number manually. Right now the issues are fetched through the API when the page the API, although the API only shows the X most recent issues, and we should probably give the ability to add as dependencies also issues older than that.

Ah, yes, one last thing: I think we should use semantic's search module for picking issues on the sidebar, or at least allow users to place an issue number manually. Right now the issues are fetched through the API when the page the API, although the API only shows the X most recent issues, and we should probably give the ability to add as dependencies also issues older than that.

Yes, the problem is you can't search for issues via the api (as of now). So I have to wait until this is possible.

Yes, the problem is you can't search for issues via the api (as of now). So I have to wait until this is possible.

Fair enough. Can you still add a way to set the input manually? So add #123456 as a dependency, even though it doesn't show up in the issue list?

So adding #123456 as a dependency by typing the entire number, even though it doesn't show up in the issue list?

Honestly, I'd prefer to make a seperate pr to provide the issue search api and implent this clean once nad for all instead of adding an extra input, checking if the issue id comes from said input, transforming it into an issue id etc.
I simply think it's less of a headache to do it that way.

I've opened a seperate PR to do just that:  #3612

Awesome! :tada: :tada: :tada: For what concerns this PR, I'll probably give it another go at reviewing sometime soon, although with the commits you made there shouldn't be much left to change. Thanks!

The PR, is done and merged, should I now execute a govendor fetch code.gitea.io/sdk/gitea to fetch the newest version of the sdk? This would probably result in me committing all new files as the vendor forlder is not in .gitignore. Or is this solved otherwise?

need @lafriks' approval

and @thehowl and @Morlinest

@kolaente Thanks for your work and dedication.

need @lafriks' and @thehowl's approvals

ping @lafriks and @thehowl

@Morlinest @lafriks are we all good?

@kolaente I was thinking, if it would not be better to use 2 different comment types. What do you think? Now from comment you don't know if issue was marked as blocker or as dependent issue on another one.

@lafriks @Morlinest please aprrove.

@lafriks @Morlinest need your approval.

@lafriks @Morlinest need your approval.

@lafriks @Morlinest need your approval.

@lafriks @Morlinest need your approval.

@lafriks @Morlinest need your approval.

@lafriks @Morlinest need your approval.

@lafriks @Morlinest need your approval.

@kolaente Sorry, I did not have much time last days/weeks. It is too big to do fast review for me (it takes me few hours)

@Morlinest I fixed the issues you found, please re-review.

@Morlinest @lafriks please approve.

conflicted

@JonasFranzDEV fixed.

@Morlinest @lafriks please approve.

@Morlinest @lafriks please approve.

Thanks @Morlinest !

@lafriks please approve.

Sry for taking so long to approve, nice work :+1:

Make LG-TM work

@lafriks Thank you!

LGTM

In the dependencies list it only lists the last 10 issues relative to that one.
For example issue 23 can only see to 12. Issue 20 can only see issues 19 - 9.
Also manual mention (for example of #13) doesn't work.
@kolaente Is this an intended behavior or a bug?

@AragurDEV Fast search: issues search api (/api/v1/repos/:username/:reponame/issues) uses SearchIssuesByKeyword to find issues by given keyword and right now it search in:
newMatchPhraseQuery(keyword, "Title", issueIndexerAnalyzer),
newMatchPhraseQuery(keyword, "Content", issueIndexerAnalyzer),
newMatchPhraseQuery(keyword, "Comments", issueIndexerAnalyzer),

I tested it, you can search only with full words, in your example it would be "test", "issue". But I can confirm, this feature is little buggy right now and UI does not fully work as expected in my tests.

@Morlinest thanks a lot!
I think it should be possible to directly reference a issue id. No matter if the search api succeeds

@AragurDEV Please create an issue so we can discuss there. This feature needs little tweaks.


Tensor/pipeline parallelism

🚀 The feature, motivation and pitch
First, thanks for this gem of a repo. I'm hoping to continue training at least the 7 and 13b parameter models and trust that FSDP should be up to the task. Have you implemented or do you plan to implement tensor parallelism or pipeline parallelism for training? I might be reading into this but it looks like there's a vestige of 2d parallelism in your Slurm script with the name Nano-2d-trainer-20b-8nodes.
Alternatives
No response
Additional context
No response

@ToddMorrill , thanks for your interest in this work. We are not using TP+pipeline in this work and mostly relying on FSDP as the most cost efficient/ user friendly training paradigm for now. For model sizes up to 25B FSDP scale almost linearly, beyond that we might need to add TP as well. We are working on this recipe for 70B. Will fix the name on the slurm script as well.

Are there any examples that attempt to implement tensor parallelism with FSDP? Should I take a closer look at anything in fairscale? For example, I see these parallel objects in the the llama model definition: https://github.com/facebookresearch/llama/blob/6c7fe276574e78057f917549435a2554000a876d/llama/model.py#L11-L15

@ToddMorrill you can take a look at this example that does 2D (TP+FSDP) for T5 model.

Thank you, I will add it to my queue!


Question about recomputation in actor module

I'm curious about why we must need to do recomputation when using HybridEngine. In generate_sequences() line 367-372 https://github.com/volcengine/verl/blob/main/verl/trainer/ppo/workers/fsdp_workers.py , we have
if self._is_actor and recompute_log_prob:
            # we should always recompute old_log_probs when it is HybridEngine
            output.meta_info['micro_batch_size'] = self.config.rollout.log_prob_micro_batch_size
            output.meta_info['temperature'] = self.config.rollout.temperature
            old_log_probs = self.actor.compute_log_prob(data=output)
            output.batch['old_log_probs'] = old_log_probs

This generate_sequences() function should be run by the rollout module, who can directly provide the old_log_probs (see the commented lines in line 208 of vllm_rollout.py https://github.com/volcengine/verl/blob/main/verl/trainer/ppo/rollout/vllm_rollout/vllm_rollout.py).
So why we must recompute it with extra overhead?
Besides, in my understanding, rollout module and actor module should be the same model at different steps, i.e., $M_{rollout}(t)=M_{actor}(t-1)$. It means that we need to maintains two sets of parameters for Actor model at the same time, and before we update the parameters of Actor, we should make sure the parameters-to-be-update are saved to update rollout model. But I didn't find relevant codes in ray_trainer.py. Do I miss something or I simply have some misunderstanding? Thanks!

New to RLHF, I sincerely thank the developers in advance for their attention 😁

Hi @0oshowero0 , thanks for your questions!
Recompute old_log_prob:  This is mainly because many RL algorithms (e.g., PPO) are quite sensitive to logits. The logits computed by the inference engine (vLLM) might use different kernels from those used in training (FSDP and Megatron).
Therefore, we use the actor model to recompute old_log_prob for better logit alignment.
Update parameter between actor and rollout: Your understanding is correct. The implementation of syncing weight (i.e., model weight resharding) is implemented in hybrid_engine and be utilized as a Context Manager in fsdp_workers.py](https://github.com/volcengine/verl/tree/main/verl/trainer/ppo/hybrid_engine) (similar in megatron_workers.py)

I see! This is a very valuable practical experience. Thank you for sharing!


Remove C++11 build jobs from CI

For Boost 1.80, we have announced the switch from C++11 to C++14 with Boost 1.80.
This should be followed with removal of C++11 builds from our CI-s.
Yes, GIL may still build as C++11 for a while after the release of Boost 1.80, but keeping those jobs will be confusing.
Removing them will also speed up our CI operations.

Shouldn't this be on the 1.81 milestone then?

Yes, GIL may still build as C++11 for a while after the release of Boost 1.80

Bold to assume that, I thought to get rid of all std::bind's as soon as we hit 1.80, replace them with generic lambdas and never look back ;)

Why? If Boost.GIL 1.80 is said and set to require C++14 or later, then what is the reason to keep anything C++11?


Specify cyptography version

Due to the use of cryptography.hazmat.primitives.asymmetric.ed25519 which seems to have been added in version 2.6: https://cryptography.io/en/latest/hazmat/primitives/asymmetric/ed25519.html should the requirement on cryptography specify a minimum version?
older versions of cryptography result in:
    from authlib.jose import jwt
  File "/Users/runner/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/authlib/jose/__init__.py", line 24, in <module>
    from .rfc8037 import OKPKey, register_jws_rfc8037
  File "/Users/runner/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/authlib/jose/rfc8037/__init__.py", line 1, in <module>
    from .okp_key import OKPKey
  File "/Users/runner/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/authlib/jose/rfc8037/okp_key.py", line 1, in <module>
    from cryptography.hazmat.primitives.asymmetric.ed25519 import (
ModuleNotFoundError: No module named 'cryptography.hazmat.primitives.asymmetric.ed25519'

Note this was found when running https://github.com/AMWA-TV/nmos-testing/ on a Mac with Conan installed, for some reason Conan requires cryptography < 2.4 on macos.

@alanb-sony cryptography 2.6 was released in Feb, 2019, which is very long time ago. I think this is not an issue for ed25519. But I will add a minimal version in setup.py next time.

Added in setup.py


Outdated information on the page

Hi,
following section seems to be outdated. The read operations are supported (s. section "User and support-related events" in https://docs.microsoft.com/en-us/power-platform/admin/enable-use-comprehensive-auditing)
Not supported for auditing
The following lists what cannot be audited for Common Data Service:
Audit of read operations
Audit of metadata changes
Regards,
Alexander

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d7eca476-edd9-e73e-fd07-7e000b9a6ef8
Version Independent ID: e69062b0-f865-7cdf-be53-a1db50af5d05
Content: Auditing Overview (Common Data Service) - Power Apps
Content Source: powerapps-docs/developer/common-data-service/auditing-overview.md
Service: powerapps
GitHub Login: @paulliew
Microsoft Alias: jdaly

@soutchilin The developer topic has been changed to show how to query for the tables and columns that can be audited.
Detect which tables are enabled for auditing


README.md: Use fenced code blocks more frequently

When copying the Shenandoah GC flags, I left out the first hyphen. It took me a while to find my error. The hyphen is the last character on a line, so that's why I didn't notice it; this PR should isolate large codeblocks. Hopefully, fenced codeblocks for the larger blocks should be easier for users to copy from.

Looks much better!

Good Idea, 👍🏽


BUG How To notebook fails on import PromptRequestPiece

Steps/Code to Reproduce
Getting started with PyRit, fresh conda environment setup, install of pyrit with pip today.
Looking at the How To notebook:
https://github.com/Azure/PyRIT/blob/main/doc/how_to_guide.ipynb
Fails on import of:
from pyrit.models import PromptRequestPiece
with:
ImportError: cannot import name 'PromptRequestPiece' from 'pyrit.models' (/root/miniconda3/envs/lhg_py310_pyrit/lib/python3.10/site-packages/pyrit/models.py)
Versions
OS: Ubuntu 23.04 (Windows 11, WSL 2)
Python : 3.10.14
System:
python: 3.10.14 (main, Mar 21 2024, 16:24:04) [GCC 11.2.0]
executable: /root/miniconda3/envs/lhg_py310_pyrit/bin/python
machine: Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.37
Python dependencies:
pyrit: 0.1.2
Cython: None
numpy: 1.26.4
openai: 1.23.2
pip: 23.3.1
scikit-learn: 1.4.2
scipy: 1.13.0
setuptools: 68.0.0
tensorflow: None
torch: 2.1.2
transformers: 4.40.0

This is new code that was introduced in main but isn't released yet. Same explanation as in https://github.com/Azure/PyRIT/issues/165#issuecomment-2072514945
If you want to use the latest development version please follow instructions in the contributor guide (doc/contribute.md)


simplex-chat-desktop: 6.0.4 -> 6.0.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for simplex-chat-desktop is: Desktop application for SimpleX Chat
meta.homepage for simplex-chat-desktop is: https://simplex.chat
meta.changelog for simplex-chat-desktop is: https://github.com/simplex-chat/simplex-chat/releases/tag/v6.0.5
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 6.0.5 in filename of file in /nix/store/90p0mrxz77rl5ymzp42s82vpjpxxk01z-simplex-chat-desktop-6.0.5

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

simplex-chat-desktop

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/90p0mrxz77rl5ymzp42s82vpjpxxk01z-simplex-chat-desktop-6.0.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A simplex-chat-desktop https://github.com/r-ryantm/nixpkgs/archive/8bab23b22dc269b32713690718ff2e92d22fa3b7.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8bab23b22dc269b32713690718ff2e92d22fa3b7#simplex-chat-desktop

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/90p0mrxz77rl5ymzp42s82vpjpxxk01z-simplex-chat-desktop-6.0.5
ls -la /nix/store/90p0mrxz77rl5ymzp42s82vpjpxxk01z-simplex-chat-desktop-6.0.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

simplex-chat-desktop

Maintainer pings
cc @TerryGarcia @yuuyins for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


move cuda code to cuda branch

Change-Id: Ieff696036c2084517c3abd629a7410006fd3e568

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Feature Request: Week (and month) notes format

Hi,
Thanks for the great plugin. I would like to suggest an option to parse @this week @next week into proper link to weekly notes (not everyone use this concept, but many do, I think).
More specific:

I have weekly and monthly notes.
The format is configured in Periodic Notes plugin. For me I use gggg-[W]ww for weekly notes.
Everytime I type @next week, I would think about linking it to the next week's note.
So I have there is an option to define that for parsing in nldates.

I also understand that not everyone will need this concept, so a fall back to default will be needed.
Hope to see this in your future updates of the plugin.
Thanks,
NA

Hi!
Thanks for this convenient plugin. I was about to write a same issue for the same feature!
I would suggest to implement this option based on Periodic Notes plugin. Namely, there is a "Format" value to fill to have the expected file name format.
For example: Weekly Notes have default format gggg-[W]ww in order create weekly note such as 2022-W13.
So, this parsing option for week and month notes can be done by replacing the first day of the month ( or week) when using @this month (respectively @this week) by the according note reference. The "Format" reference could be set in Options of Natural Language Dates plugin in order to match Periodic Notes Format ( or any other plugins that have this feature that I'm not aware of).
Thanks again for your time and effort writing this plugin. It's highly appreciated.

Here's my suggestion for naming the triggers to avoid the confusion with last week, this week and next week
Previous week
Current week
Following week

I would love this feature. When typing @this week I would much rather it link to my weekly note than the first daily note for that week.

Came to request the same thing. Would dearly love to link my weekly and monthly notes using your super convenient plugin!

came to support this request, would be fantastic if possible. thank you so much for your plugin!

I've opened #102 which adds support for week formats, in the form of a 'week:' prefix which can be applied to any date specifier, based on the already existing implementation of time: prefix.
When "Add dates as link" is enabled, weekly links are created.

@gillesgagniard I saw that you have an updated PR at https://github.com/argenos/nldates-obsidian/pull/107 but since it doesn’t look like it’s going to be merged, I wonder what the best way would be to get this feature. Should I just use your repo or what would you recommend?

https://github.com/argenos/nldates-obsidian/issues/93#issuecomment-1093118797 Yes! Hope this could support more peridic notes!
I would like to open weekly/monthly/quarterly/yearly note better than a date in a week/month/quarter/year.
And hope this would support advanced uri, too! Like obsidian://nldates?day=this-week and more!

This would be great, it might require some configuration, specially for defining the format for week date (I like the 2024-W12 format, but it's far from being universal), but I link the ideal to link to a given week, and not just the first day of the week.

@gillesgagniard I saw that you have an updated PR at #107 but since it doesn’t look like it’s going to be merged, I wonder what the best way would be to get this feature. Should I just use your repo or what would you recommend?

Hi @tophee Did you make it? Is it working?

@codey-badger unfortunately not.

Hello @tophee amd @codey-badger !
On my side I've been using the feature/week branch of my fork for the last 2 years, which I manually install into my obsidian vault plugins.
BTW I've just rebased it on the latest master from this repo, it still builds and runs fine.


Support v1 and v2 of the AWS SDK

This will require some reorganisation of the package/project structure. I propose

scanamo-core is the set of types and typeclasses offered by Scanamo which does not commit to a particular SDK
scanamo-sdk-v1 holds interpreters and other internal structures for dealing with SDK v1
scanamo-sdk-v2 same for v2

While playing with the "free of free" encoding, I added a set of type to represent concrete actions:
trait ScanamoTypes {
  type ScanamoBatchGetItem[G[_]]
  type ScanamoBatchWriteItem[G[_]]
  ...
}

This is enough to define the class of abstract runtimes:
abstract class ScanamoRuntime[F[_]] extends ScanamoTypes {
  def batchGetItem: ScanamoBatchGetItem[F]
  def batchWriteItem: ScanamoBatchWriteItem[F]
  ...
}

Then for e.g. v1 we can commit to types from that sdk:
import com.amazonaws.services.dynamodbv2.model._

trait ScanamoTypesV1 extends ScanamoTypes {
  type ScanamoBatchGetItem[F[_]] = ScanamoAction[F, BatchGetItemRequest, BatchGetItemResult]
  type ScanamoBatchWriteItem[F[_]] = ScanamoAction[F, BatchWriteItemRequest, BatchWriteItemResult]
  type ScanamoCreateBackup[F[_]] = ScanamoAction[F, CreateBackupRequest, CreateBackupResult]
  ...
}

and define both sync and async runtimes:
import java.util.concurrent.{Future => JFuture}

abstract class ScanamoAsyncRuntime[F[_]] extends ScanamoRuntime[F] with ScanamoTypesV1 {
  def execute[Req, Res](f: Req => JFuture[Res]): ScanamoAction[F, Req, Res]

  final def batchGetItem: ScanamoBatchGetItem[F] = execute(client.batchGetItemAsync(_))
  final def batchWriteItem: ScanamoBatchWriteItem[F] = execute(client.batchWriteItemAsync(_))
  ...
}

Of course it won't be that easy. Right now DynamoFormat is tightly coupled with AttributeValue. However, after the work for manual derivation is done, this won't be the case anymore. This ticket should probably be tackled after that.

Hi @regiskuckaertz! Has there been any work done on this topic? Probably, there is a dev branch somewhere.

@melgenek no, not yet, I have a draft indeed but it's going to take some time.

Is Scanamo currently supporting v2 of AWS SDK at all? If not, is there any work done in this direction?


Missing JS source & bower listing

The README mentions that the library can be found on bower, but I don't see any reference to it (http://bower.io/search/?q=Typist). Also, it mentions downloading the raw JS file however there is no such file in the repo or link to the file (via CDN or another site).
It would make sense to include the JS file somewhere in the repo (or even better, in a separate branch). This fork seems to get this right and has some additional files that this repo could benefit from (such as separated files).

I don't think this repo is useable in current form, especially with no dist files. Will the @EagerApps updates be merged or matched?

@rarkins https://github.com/positionly/Typist/blob/master/dist/typist.js – it's been there for a few days already.

Great, thanks. Also, given the similarity to https://github.com/iamchrismiller/typist/, you might want to consider a name change before publishing to bower? The sooner the easier if it's to be done.

Actually I see commits are 2 years old here, so I might be wrong above. Which repo was published and publicized first?

Yep, this project/repo was published months before the one you're mentioning.

Dist added. Closing. Created #2 for the bower issue.

Seems that other one has the bower name 'typist' though, so you'll need to change names or use a bower name that doesn't match the repository name?


Without sanitizing whereNull, whereNotNull, orWhereNull, orWhereNotNull is vulnerable to an injection.

For instance,
whereNotNull('1') will expand into WHERE 1 NOT NULL
whereNull('NULL') will expand into WHERE NULL IS  NULL
which effectively neutralizes a condition.
Additional reason to make sanitizer public - it is handy while working
with raw queries outside the library.

Could you please add tests for this?

Thanks!


Documentation: Configure API to use the DRF's TokenAuthentication

A tutorial part how to implement the DRF's TokenAuthentication for API access protection.
Having to research the method myself I propose to extend the documentation with an example how to implement the TokenAuthentication from the Django REST Framework.

Did you skip that on purpose or should we add it as well?

This strange feeling in the back of the head there was something I didn't mention: yes, of course, the settings need
REST_FRAMEWORK = {
    "DEFAULT_AUTHENTICATION_CLASSES": [
        "rest_framework.authentication.TokenAuthentication"
    ],
}

I extended the needed changes to settings.py, I hope this time it's clearer.
One could ponder how much more detail to put in this part, like mentioning how to generate the token (per manage.py command or in the Django admin).

Yeah, more details and also a fix :)


[move] Remove structured control flow from Move IR

Replace Move IR's structured control flow constructs (if (...) { ... }, etc.) with block labels and jump statements that more closely match the Move bytecode.
Motivation
There are two major textual programming language compilers in this repository: the Move source language compiler (defined mostly in language/move-lang) and the Move IR compiler (defined mostly in language/move-ir-compiler). The Move source language is what people interacting with Move use, whereas Move IR is used by the Move core team to test internal components. Many internal components, like the bytecode-verifier, operate on binary Move bytecode. Move bytecode does not currently have a standard textual format that can be translated to Move bytecode -- and even if it did, it would be too cumbersome for a human to write many of the bytecode verifier tests in such a format. The Move IR programming language exists to make writing these tests easier for the human core team member.
Move IR as it exists today contains several language constructs that do not translate directly to bytecode. Some of them may be useful, but its structured control flow -- if (cond) { ... }, if (cond) { ... } else { ... }, while, loop, continue, break, et cetera -- are more confusing than helpful, in my opinion. Move IR is intended to be a slightly more convenient form of bytecode, but each of these constructs are translated to bytecode in different, sometimes unintuitive ways. For example, there is no if-else bytecode construct, only Branch, BrTrue, and BrFalse. So, a Move IR if (cond) { ... } else { ... } construct is translated to multiple bytecode instructions and blocks. To test how the bytecode verifier operates on bytecode branch instructions, one must reverse engineer this translation and write the exact Move IR that will produce the intended bytecode. That's topsy-turvy, in my opinion -- Move IR should make testing simpler, not more complicated.
So, to that end, this pull request removes structured control flow. It introduces jump statements that map 1-to-1 with bytecode instructions:

New Move IR syntax
Bytecode instruction

jump <block-label>
Branch(<block-label>)

jump_if(<expression>) <block-label>
BrTrue(<block-label>)

jump_if_false(<expression>) <block-label>
BrFalse(<block-label>)

I think these new statements make a lot of the bytecode-verifier and move-vm tests clearer: whereas before these tests operated upon while loops with break statements (neither of which exist as a concept in the bytecode), they now operate on jump statements (branch instructions in bytecode) between blocks. In some cases, tests of invalid loops and fallthroughs are much simpler to write.
On the other hand, some older tests are made more obsolete. Many tests in ir-testsuite and in the move-ir-compiler unit test suite test while and break behavior specifically. I will delete or migrate these tests to the new move-ir-compiler transactional test harness, #9811, in a future commit.

:exclamation: Invalid command

Bors help and documentation

Bors is a Github App used to manage merging of PRs in order to ensure that CI is always green. It does so by maintaining a Merge Queue. Once a PR reaches the head of the Merge Queue it is rebased on top of the latest version of the PR's base-branch (generally master) and then triggers CI. If CI comes back green the PR is then merged into the base-branch. Regardless of the outcome, the next PR is the queue is then processed.
General

This project's Merge Queue can be found here.
This project requires PRs to be Reviewed and Approved before they can be queued for merging.
Before PR's can be merged they must be configured with "Allow edits from maintainers" enabled. This is needed for Bors to be able to update PR's in-place so that Github can properly recognize and mark them as "merged" once they've been merged into the upstream branch.

Commands
Bors actions can be triggered by posting a comment which includes a line of the form /<action>.

Command
Action
Description

Land
land, merge
attempt to land or merge a PR

Canary
canary, try
canary a PR by performing all checks without merging

Cancel
cancel, stop
stop an in-progress land

Cherry Pick
cherry-pick <target>
cherry-pick a PR into <target> branch

Priority
priority
set the priority level for a PR (high, normal, low)

Help
help, h
show this help message

Options
Options for Pull Requests are configured through the application of labels.

          Option
Description

Indicates that the PR is high-priority. When queued the PR will be placed at the head of the merge queue.

Indicates that the PR is low-priority. When queued the PR will be placed at the back of the merge queue.

Before merging the PR will be squashed down to a single commit, only retaining the commit message of the first commit in the PR.

I discussed this with @tnowacki yesterday evening and we came up with what I think are a few good ideas:

We both liked @vgao1996's proposed branch, branch_true, branch_false statements (and I think we all agree not to include if (cond) b0 else b1; syntax, which isn't representable in a single bytecode instruction), but the names we settled on were jump, jump_if, and jump_if_false. In the future we can change the bytecode mnemonics to match. (I personally don't mind branch vs jump, but what I do want is for the Move IR syntax to match the bytecode mnemonics.)
For label syntax, we decided that always requiring labels, and always requiring that blocks be terminated with a "terminator" instruction, would be a nice property for Move IR, especially for CFG analysis. And, instead of having the first block in a function definition be a special case, we thought that requiring the label always be specified would be a good way to go. Here's an example:foo() {
  let x: u64;   // Local declarations appear before any labels.
  let y: &u64;  // In the future we may change the `let ... : ...;` syntax to instead be
                // `locals:` followed by a sequence of identifier/type pairs such as `x: u64;`.
label b0:
  return; // The sequence of statements in b0 must end with a terminator such as `return`.
}

I'll update this PR with code to match this approach.

Sorry for missing some of the recent conversations... Been busy with a few other tasks..
I like the recent development on this and I'm happy to hear that you two have reached a consensus on the jump statements! Thanks to Brian for all the hard work!

This is ready for another review. There's a failing test result that I believe is unrelated and resolved by #9904.

/land

:broken_heart: Test Failed - ci-test

/land

:broken_heart: Test Failed - ci-test

/land


Swipe from left side for menu no longer working

This is a great add on, but the last update has meant that swiping from asking the left edge no longer allows the HA Menu bar to open. It did allow this in earlier versions, is there a chance it could be fixed to allow this again please?

Nevermind, it looks like this has an issue with a change made to the core system. Swiping used to be handled by the html front-end but this has been dropped. The iOS app has been updated to add the functionality back in, but looks like the Android app is lagging behind.
Sorry, this add on is still great, and in truth should be a core function in my mind.


SQL Error on latests results page

On page: https://html5test.com/results/latest.html, you are currently getting sql syntax error.
You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'ORDER BY timestamp DESC LIMIT 100' at line 7
Errors shouldn't be visible to user in production environment and you should investigate what what is wrong in generated $where, because there is potential SQL Injection vector.

Fixed on alpha.html5test.com


core: Fix handling of alternate shell if set to an empty string

In case alternate shell was set to an empty string ("") the old code would try to convert it to a WChar string. This resulted in a NULL pointer being returned by ConvertUtf8ToWCharAlloc that was interpreted as an error and the connection failed.

@freerdp-bot test


loopComplete event firing before the animation has completed

I'm trying to make icons animate when they are clicked. I would like the animation to complete before it can be restarted.
I build my icons first by selecting elements and then using their id's to load the animation data via the path option:
    var icon_containers = document.querySelectorAll('div.icon');
    var icons = [];

    function buildIcons() {
    	for (var i = 0; i < icon_containers.length; i++) {
    		element = icon_containers[i];
    		if (element.id !== '') {
    			var params = {
    				container: element,
    				renderer: 'svg',
    				loop: false,
    				autoplay: false,
    				path: element.id + '.json'
    			};
    			var anim = bodymovin.loadAnimation(params);
    			icons.push({
    				anim: anim,
    				element: element,
    				isPlaying: false
    			});
    		}
    	}
    }

    buildIcons();

The icons object is then looped through and the animationStart method is called as well as a click handler added to each icon container:
    function startAnimation(anim, icon) {
    	anim.setDirection(1);
    	anim.goToAndStop(1);
    	anim.play();
    	// This seems to fire immediately, before the icon has completed its animation?
    	anim.addEventListener('loopComplete', complete(icon));
    }

    icons.forEach(function(value, id) {
    	startAnimation(value.anim, id);
    	value.element.addEventListener("click", function(e) {
    		startAnimation(value.anim, id);
    	});
    });

The startAnimation method attempts to attach an event handler to fire when the loopComplete event happens.
    function complete(icon) {
    	console.log(icon + ' loopComplete');
    }

However this seems to fire immediately and I'd like to know how to make it fire after the animation so I can then not start a new animation until it has completed.
I've made a reduced test case here: https://codepen.io/paulyabsley/project/editor/ALEWnK

You probably need to wait for the animation to be loaded before calling the method startAnimation.
When you call loadAnimation, on the instance do something in the lines of:
icons.forEach(function(value, id) {
        value.anim.addEventListener('DOMLoaded',function(){
	    startAnimation(value.anim, id);
	    value.element.addEventListener("click", function(e) {
	            	startAnimation(value.anim, id);
	    });
        })
});

If you call startAnimation without waiting for the animation to be effectively loaded, you'll be starting an empty animation.

Thanks for taking a look! I tried adding in the code above like you suggest but it hasn't stopped the loopComplete event listener from firing immediately after clicking the icon. The icon play animation works fine on click. I thought I would be able to listen for it to finish before I allow it to be replayed.

Do you have a link with the new implementation?

Yeah sure: https://codepen.io/paulyabsley/project/editor/ALEWnK

In line 34, you're executing the method "complete" immediately instead of passing it to the addEventListener function.
You shoud change
anim.addEventListener('loopComplete', complete(icon));
with
anim.addEventListener('loopComplete', complete);
Of course that you'll need to solve passing the variable icon some other way if you need it.

I adjusted it to how you suggested and created a new function to pass to the event listener on the animation object:
    	function newComplete() {
		console.log(' loopComplete');
	}

	function startAnimation(anim, icon) {
		anim.setDirection(1);
		anim.goToAndStop(1);
		anim.play();

		anim.addEventListener('loopComplete', newComplete);
	}

But now I don't get anything in the console when the animations complete.
https://codepen.io/paulyabsley/project/editor/ALEWnK
Is this all something to do with me creating an object to hold the animations? Do I need to add the loopComplete event listeners in the loop where I initially make the animation objects? If so I'm not sure how to approach it. Thanks for your help by the way!


Cmd+/ to comment JSX code uses wrong comment syntax

TS and JS Grammar Extension version:  0.0.37 / latest
Use cmd+/ shortcut on any of the lines containing JSX below.
Expected behavior: line is commented as
{/*
*/}

Actual behavior: line is commented as
//
*/}

Code
// Please include a code snippet that demonstrates the issue
import React, { Component } from 'react';

class App extends Component {
  render() {
    return (

Welcome to React

    );
  }
}

export default App;

@jamesjryan have you figured out how to make jsx comments work with this extension installed?

No I haven't, I've disabled this extension sadly.
On Thu, Jun 14, 2018 at 12:13 PM André Junges<EMAIL_ADDRESS>wrote:

@jamesjryan https://github.com/jamesjryan have you figured out how to
make jsx comments work with this extension installed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript-TmLanguage/issues/589#issuecomment-397389083,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMKkblB6mEmJsuSeaU8F3KIzh8Aok2IRks5t8qevgaJpZM4S5jjX
.

disabled is ok .  and ,  are there any other way ?


Opening with rw mode doesn't work correctly

This code should return an error if there's no database file, but it doesn't
    _, err := sql.Open("sqlite3", "file:database.db?mode=rw&_foreign_keys=true")
    if err != nil {
        fmt.Println(err)
    }

SQLITE_OPEN_READWRITE
The database is opened for reading and writing if possible, or reading only if the file is write protected by the operating system. In either case the database must already exist, otherwise an error is returned.

Maybe it happens because of this line of the code?
https://github.com/mattn/go-sqlite3/blob/master/sqlite3.go#L1341

So you expect to remove SQLITE_OPEN_CREATE from flags?

Yes I do, when the flag is "rw"

Are you sure this is a bug? sql.Open itself doesn't necessarily call Open on the underlying driver. Try calling Ping() on the resulting database and see what it returns. The SQLite documentation itself says this should work as you expect.
https://www.sqlite.org/c3ref/open.html

mode: The mode parameter may be set to either "ro", "rw", "rwc", or "memory". Attempting to set it to any other value is an error. If "ro" is specified, then the database is opened for read-only access, just as if the SQLITE_OPEN_READONLY flag had been set in the third argument to sqlite3_open_v2(). If the mode option is set to "rw", then the database is opened for read-write (but not create) access, as if SQLITE_OPEN_READWRITE (but not SQLITE_OPEN_CREATE) had been set. Value "rwc" is equivalent to setting both SQLITE_OPEN_READWRITE and SQLITE_OPEN_CREATE. If the mode option is set to "memory" then a pure in-memory database that never reads or writes from disk is used. It is an error to specify a value for the mode parameter that is less restrictive than that specified by the flags passed in the third parameter to sqlite3_open_v2().

Maybe it's okay that it doesn't return an error, but I see that when mode=rw is passed, the database is still created if the file doesn't exist. Also, if an empty string is passed as the file name, an *sql.DB object is returned and the Ping method to this database does not return any errors.


Adding PPE live tests and adjusting test timeouts

Packages impacted by this PR
@azure/communication-*
Describe the problem that is addressed by this PR

Adding PPE SDK live tests for the email communication package.
Follow up to https://github.com/Azure/azure-sdk-for-js/pull/24175. That PR added email resource creation to a common resources template shared by all communication tests. However, only communication-email package needs the email resource for its test pipeline. So this PR adds an email-specific resource template, while reverting changes to the common template.

/azp run prepare-pipelines

/azp run prepare-pipelines

/azp run prepare-pipelines


Next major version: V5

Closes #1292
Major changes:

[x] Drop support of Node.js < 12.
[x] Drop support of plugging in third-party Promise Library. (As native Promise is pretty performant and Bluebird is deprecated.)
[x] Upgrade TypeScript to the latest version.
[x] Official TypeScript declarations.
[x] Support ESM + CJS.
[x] Scripts will retry in case of NOSCRIPT in pipeline mode. https://github.com/luin/ioredis/pull/1499
[x] #1293
[x] #1041 (May not merge directly, another approach is to add a warning)

@luin any chance we can squeeze in resp3 (dont remember this being supported, but might be wrong) / client side caching here? glad to help!

and another idea is native opentelemetry instrumentation

@luin any chance we can squeeze in resp3 (dont remember this being supported, but might be wrong) / client side caching here? glad to help!

It hasn't been supported 🤣 . For myself, I don't feel that resp3 will bring a lot of real value, and I'm not sure as a driver, what kind of API needs to be provided to support the new features that resp3 brings. Similarly, client side caching does not seem to be as meaningful for a language that uses GC.
But I haven't thought much about this, so open to suggestions! If we want to support resp3, v5 seems to be a good chance to do so.

and another idea is native opentelemetry instrumentation

Can you elaborate a little bit more on this? Does it mean to provide an interface to get the average command execution time or something similar?

Can you elaborate a little bit more on this? Does it mean to provide an interface to get the average command execution time or something similar?

it sort of allows you to perform diagnostics better and get a complete trace of a request when every part of your request chain is instrumented, typically you'd use async_hooks, but can be anything
https://github.com/elastic/apm-agent-nodejs/blob/main/lib/instrumentation/modules/ioredis.js is an example of an existing instrumentation, which can be bridged to opentracing/opentelementry, fed to something like https://github.com/jaegertracing/jaeger for visualization/search

It hasn't been supported 🤣 . For myself, I don't feel that resp3 will bring a lot of real value, and I'm not sure as a driver, what kind of API needs to be provided to support the new features that resp3 brings. Similarly, client side caching does not seem to be as meaningful for a language that uses GC.

I don;t think GC is relevant in terms of client-side caching here, in my opinion main benefit here is lower latency to access information, along with guarantees that information is still what server has. https://redis.io/topics/client-side-caching
for certain queries you can opt-in to cache the response. when server-side data changes - server will notify clients about that and clients will get new info

Resp3 changes response formats and we should mention that. eg. booleans are converted to true/false instead of 1/0: https://redis.io/topics/lua-api#lua-to-resp3-type-conversion
Therefore I'd schedule resp3 with another version later or support opt-out.

Raising the Node.js version bar to v12 as it's the oldest version that is still in maintenance status. With this change, we are able to upgrade all dependencies to the latest versions, and we can also get rid of lodash.flatten.
Also, I think we should delay RESP3 for the next major version (v6) as seems it's a big change and we need some time thinking of it. @AVVS does it make sense?

This PR now includes all changes I want to make in v5, and I'm going to update some examples and documentation in the next week, and then I think we are good to release v5 as a beta version (in next dist channel) 🚀.
Let me know if you have something in your mind that can be done before we release v5 as a stable version @AVVS @marcbachmann. cc @shaharmor @TysonAndre 👋
BTW going to consider RESP3 in the next major version 🤣

I think this could have a big performance impact because of buffer allocation in the tcp client. A benchmark would be nice for that.
edit: maybe not as writes still happen using strings

We had a benchmark at the end of https://github.com/luin/ioredis/wiki/_compare/c3aeabf0594e0c68b9c5ddf39d8cd7fa4876604a. There is no difference with the pure JavaScript parser whether the option is enabled or not. The option was useful because there was a non-trivial cost for hiredis (a parser written in C) to pass buffers from native to JavaScript. It's not an issue with the pure JavaScript parser that we are using.

But maybe it could be interesting to migrate to the onread function introduced in node 12 in socket.connect.
That way the buffer reuse would be possible.

Oh, good to know! Not sure how much it will improve the performance though.

Let me know if you have something in your mind that can be done before we release v5 as a stable version

The biggest thing I could think of for a major version would be changing the default to enableAutoPipelining: true to avoid the potential bottleneck.
Things it would affect:

select to manually select a db number (1505)
applications where failures due to networking errors are important to avoid? https://github.com/luin/ioredis/issues/1377#issuecomment-890546745
(In practice, I assume the number of in flight commands would be low if redis is in the same local network)

Renamed to the main branch. Published v5.0.0-beta.1.

The biggest thing I could think of for a major version would be changing the default to enableAutoPipelining: true to avoid the potential bottleneck.
Things it would affect:

select to manually select a db number (1505)
applications where failures due to networking errors are important to avoid? When not to use enableAutoPipelining? #1377 (comment)
(In practice, I assume the number of in flight commands would be low if redis is in the same local network)

Yeah I think that makes sense. Let's delay this to the next major release.

Hey @marcbachmann @TysonAndre 👋 , thanks for the contributions to ioredis. I've just invited you to become collaborators on this repository. Feel free to help review new pull requests in the future if you have time (and it doesn't matter at all if you don't have time 😄). Appreciate it 🙏. You can refer to https://github.com/luin/ioredis/blob/main/.github/CONTRIBUTING.md for some notes.

Why disable it by default?

Hey @shaharmor , The option at some level introduces side effects as it consumes resources, especially during a failover, that by default every 5 seconds all nodes may have to be recreated (if cluster slots gives different results). Given that, I think developers need to be aware of this option and only enable it explicitly when they are aware of its purpose. WDYT?


Tests with FlowRouter

With testing guides involving Iron Router, there is mention of a file like https://meteor-testing.readme.io/docs/jasmine-integration-tests-with-iron-router so that we can route to a new page and know when it is ready to perform subsequent actions.
Is something like this necessary for FlowRouter, or do we just FlowRouter.go and have at it?
If we do need something similar to determine when the client is ready, how would we go about converting that helper for FlowRouter?  The entry and exit triggers available do not seem to account for the additional events covered for Iron Router.
Thanks

Not sure how to do this exactly. This should be best suit to Meteor Forums where you can get more feedback.


Training / Performance on YouTube-VIS

Hi,
I was wondering whether you have tested the network on the YT-VIS dataset. If so, could you provide the performance measures?
If not, what would be possible steps to evaluate on that dataset? While I understand the obvious changes (such as converting the dataset into MOTS format, changing the directory paths), my main concern was regarding tracking. In TrackR-CNN, there are two classes with separate tracking for each class (and therefore, separate parameters - such as association threshold, keep alive etc). While now the number of classes are a lot higher (40), is there any refined way to perform this rather than tuning 40 additional different parameters first and then tracking based on these. In addition, are there any complexities introduced by changing the image resolution for training?
I would appreciate if you could provide me with a direction on how I should go about this? For clarity, if you could provide all the steps I should go through, that would be highly appreciated!

Hi,
we did not try YT-VIS ourselves, but in this arxiv paper, they did (bad results though): https://arxiv.org/pdf/2003.08429.pdf

Hi,
Thank you so much for your prompt response. I had actually taken inspiration from the mentioned paper, and wished to train on YT-VIS to verify those results once.
In this regard, could you help me out by addressing the queries I put forth earlier on how I could proceed?

Solved over our email discussion :)
Thank you for your prompt responses!


Add Partial Shipment to "Auto shipping"

Implement Automatic Partial Order Shipping for Mollie Integration
Problem
Currently, when only part of an order is shipped, the entire order remains fully open in Mollie. This can lead to payment expiration after a certain period, especially problematic for Klarna invoice purchases. If the payment expires, the merchant doesn't receive any money for the shipped items.
Impact

Risk of lost revenue due to expired payments
Incorrect payment terms for customers (particularly with Klarna invoice purchases)
Manual confirmation is impractical for stores processing thousands of orders monthly

Desired Solution
Implement an automatic method for handling partial deliveries in the Mollie integration:

Mark only delivered items as shipped in Mollie
Ensure correct payment terms are set for customers (especially important for Klarna invoice purchases)
Prevent payment expiration for partially shipped orders

Benefits

Reduced risk of uncollected payments
Accurate payment terms for customers
Improved efficiency for high-volume stores
Elimination of manual confirmation process

Additional Context
This feature is crucial for stores processing several thousand orders per month, where manual confirmation of partial shipments is not feasible.
Acceptance Criteria

[ ] Partial shipments are automatically reflected in Mollie
[ ] Only shipped items are marked as such in Mollie
[ ] Customer payment terms are correctly set based on shipped items
[ ] Payment expiration is prevented for partially shipped orders
[ ] Solution works at scale for stores with high order volumes

Priority
High - This issue significantly impacts revenue collection and customer experience.

Hello @rene-schwabe
we do have a "Ship Through Mollie" button in order overview, here you can select how many items are shipped in which quantity, then you can send them to mollie. The order is marked as partially shipped then.
You can then either use the button again and send another batch of items, or you can switch the delivery status to delivered in shopware and then all remaining items will be shipped to mollie (if automatic shipment is enabled in plugin config)
Also we provide the ship functions over API so it can be added to ERP for example
Payment expiration cannot be cancelled, the default expiration in mollie is 28 days, some merchants can extend this value on mollie side and you can configure the value in "Order Lifetime Days"
Or do i  misunderstood the usecase?
Best Regards,
Vitalij


Update to Dart SDK 1.23.0-dev.7.0+

(We're currently on dev.4.0.)
TL;DR because of a new dependency on the kernel package (from the front_end), we need to take this in a few steps and will need to wait for dev.8.0.
The longer story:
Attempting the update today, meets us with this error when we try to build flutter:
Could not import "package:kernel/analyzer/loader.dart" from "package:front_end/src/fasta/analyzer/element_store.dart":
No mapping for 'kernel' package when resolving 'package:kernel/analyzer/loader.dart'.

To get us past this we need to do a few things.

[ ] add the kernel package to the Dart SDK sources (cl/2756593002)

and once that lands and the kernel sources are in dev.8.0, we want to

[ ] introduce a dev dependency (like we do already for analyzer and front_end) in flutter_tools and elsewhere

FYI @kasperl as this impacts/delays landing strong-mode related analysis options changes

This will be in -dev.9.0 when it lands - I just released -dev.8.0 which was requested for Google3 integration.

Cool.  Thanks @whesse !


nativefier icons repo is unmaintained

There are a lot of pull requests pending for nativefier icons.
https://github.com/jiahaog/nativefier-icons
Perhaps it is time to add another project maintainer that can help keep it up to date.

Yeah, there are many outstanding pull requests, going back over a year.
I submitted the new Gmail icon 2 days ago:
https://github.com/jiahaog/nativefier-icons/pull/82


Subscribing FIA - Fundação Instituto de Administração

@davizanotto Pull request merged. Thank you!
FTR: domain ownership proof is at the very bottom of https://fia.com.br/wp-content/uploads/2019/09/RobsonPetersendoAmaral.pdf


Update README URLs based on HTTP redirects

Created with https://github.com/dkhamsing/frankenstein
GitHub Corrected URLs

Was
Now

https://github.com/jamieforrest/swift-style-guide
https://github.com/nartiles/swift-style-guide

Current coverage is 90.46%

Merging #263 into master will not affect coverage as of 073a5f5

Powered by Codecov. Updated on successful CI builds.

Due to updates to other style guides, the inclusion of this particular guide has become redundant. This link will be removed entirely, so there is no need to update it.


Classic computer science problems  in Kotlin

I'm going to port some of  examples  into Kotlin. This is my repo link
https://github.com/AlirezaSR/Classic-Computer-Science-Problems-in-Kotlin.

Thanks, let me know if you end up completing the rest of the chapters and I'll add it to the list of alternative language repositories.

Thanks, let me know if you end up completing the rest of the chapters and I'll add it to the list of alternative language repositories.


Track and Limit Validator / Nominator Count in Staking

This PR updates the staking pallet to track the number of Validators and Nominators in the staking system.
We also introduce fundamental limits to the number of Validators and Nominators, allowing us to better control the upper limit of these systems.
To avoid these limits being easily abused, we also set minimum amounts to be bonded to become a validator or nominator.

[ ] tests for all the new logic

@shawntabrizi please update this PR such that:

we put the counters in there
impose new MinStake and MinValidatorStake

but don't enforce any bounds yet. You can simply keep the functionality, but set it to None to indicate no bound is enforced now.
Then we can merge this PR asap as it would be simpler.

Needs a polkadot companion that enables the migration, otherwise LGTM.

Or, why don't we just put the migration inside the pallet?

/benchmark runtime pallet pallet_staking

/benchmark runtime pallet pallet_staking

/benchmark runtime pallet pallet_staking

/benchmark runtime pallet pallet_staking

/benchmark runtime pallet pallet_staking

/benchmark runtime pallet pallet_staking

It seems like I have forgotten to add migrations to a on_runtime_upgrade in #[pallet::hooks].

Regarding me removing the lower bound on min-bond. I realized at this point in the PR (where things changed a bit in the logic) it is not needed, since it is impossible to have less than ED bonded, so this min is enforced anyway.

bot merge


Ensure smooth a11y migration for SB5

Ensure a11y usage is properly deprecated, documented, and tested

Yo-ho-ho!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.0-rc.10 containing PR #5833 that references this issue. Upgrade today to try it out!
Because it's a pre-release you can find it on the @next NPM tag.
Closing this issue. Please re-open if you think there's still more to do.

Boo-yah!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.0-rc.11 containing PR #5833 that references this issue. Upgrade today to try it out!
Because it's a pre-release you can find it on the @next NPM tag.


[epm] Doesn't compile Java code with an -encoding flag

When epm forks to javac it currently uses the LC_ALL environment variable to try and figure out the encoding. This can be problematic if your system is weird or you don't have appropriate locales installed.
Should we always just supply -encoding utf8 as a flag?

This should be a good idea. @jneira Do you see any immediate consequences of doing this? I know you've struggled a lot with encoding on the Windows side.

Well, i suppose it could create some problems compiling source codes with other encodings. Maybe the safe (but hard) option would be let the user configure the encoding... has cabal some option about encoding that epm could reuse for javac?


Clarify requirements for CBO using "nearest" index

Fixes #4605.
Should be followed up ASAP with #5800.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/fd296f08fb1028ad898aa21e8232c82fe95b538a/
Edited pages:

v19.1/cost-based-optimizer.md
v19.2/cost-based-optimizer.md

@awoods187 I hope this at least clears up the requirements for the feature to work while we get in #5800 ASAP.  PTAL at your convenience.

@ericharmeling small one but FYI since you'll be closer to CBO going forward post-19.2 release


feat: mattermost socialite provider

Hello,
Is it possible to add this provider to bookstack ?
Thank you :)

Hi @LouisHrg,
Thanks for offering this but I've generally stopped extending our range of built-in social providers due to maintenance impact.
Instead, for cases where an additional provider is needed, we do provide an option to extend your BookStack instance to add social drivers using our logical theme system:
https://github.com/BookStackApp/BookStack/blob/development/dev/docs/logical-theme-system.md#custom-socialite-service-example
This would allow you to add the provider without editing any core app files.
Let me know if you need any guidance at all or if you get stuck.
Note, you'd be able to set an icon by adding an icons/auth/mattermost.svg file within your theme folder.

Ok thank you very much for your response ! Cheers


Migrate Rep modal adjustment

Need to make the You will need to sign 2 txs stand out more...i totally missed it

I created a separate ticket for REP migration updates so I'll close this


From WA to PWA

Q
A

Bug fix?
no

New feature?
yes

Issues
Nothing, but for reference #1279

License
MIT

This PR is not intended to be merged at this time. I used the Symfony UX site as a playground for a bundle in development.
However, I wanted to share it with you.
The goal is to easily enhance any Web Application into a Progressive Web Application.
There are many files in the PR, but just ignore the ones in the public folder for now.
Having a PWA enable several features I really love:

You can install the application that will behave like a normal native application.
With a service worker, the application can run offline.
With a fine grained cache strategy, the application is really fast.

@weaverryan I removed the screenshots in this example and now they are all generated using Panther.

I tried with panther and it just works as expected.
I added a few options and a config like as follows is correctly understood

WOW!!!

Forgive these ignorant questions but I don't know anything about PWAs:

with this PR, does it mean we can register ux.symfony.com on the various app stores (Microsoft, android, apple)?
does it download to your device as a normal app?
what is the worker you described and how does it add offline support?

Hi @kbond,

with this PR, does it mean we can register ux.symfony.com on the various app stores (Microsoft, android, apple)?

If you had asked me this question a month ago I probably would have said "no" or "I don't know".
But I recently discovered that it is possible to submit a PWA to an app store by packaging it. I don't know how exactly it works, but tools like https://www.pwabuilder.com/ help create the packages that are submitted.

does it download to your device as a normal app?

Not exactly. This is still a web application loaded by a browser so there is no full download of the application (although this is still possible). In general, you select the most important pages/assets that are pre-cached. Other pages may be cached as the user visit uses the application.

what is the worker you described and how does it add offline support?

The Service Worker is a JS script that acts as a proxy and allows you to react to events or interact with the web API. It is saved by the browser when you "install" the application.
Where it's very clever is that fetch can be totally controlled. I generally use Workbox because it offers caching strategies to simplify this (NetworkOnly, CacheOnly, CacheFirst, NetworkFirst, or StaleWhileRevalidate). Offline mode is possible by telling the Service Worker to keep certain responses so your application will always show a real page, including assets. Thanks to the web API like BackgroundSync, it is even possible to keep POST/PUT/DELETE requests in a queue and re-execute them when the network is available again.

https://store.app/ attempts to be an app store for PWAs.  It's not very good just yet, but the idea is there.  I've submitted some support issues and never received an answer.

That's great. The offline functionality now works wonderfully for reading pages.
Not a single line of JS and yet everything is there.

Hi all,
Initially, this PR was just a playground for the development of a bundle.
Now the bundle is marked as stable and I really think this PR could be considered stable as well.
Let me know what you think about it and if it should be updated, closed or could be merged.
Many thanks.
Regards.

@Spomky How do I run this as a PWA?  I've cloned the repo and am in the 2.x branch, but I don't see the pwa-bundle in composer.json.  The features/pwa branch is gone.


Fix show of private events

[x] Fix if the user type manually the route of a private event, he are not supposed to have access that page.

Add a helper method to redirect the user if he or she is not in the invited list of the event. :bug:
The changes can be seen in the following links. :eyes:

ce3ba115e7d30dbf8ba18f1c796b8cfd15d27421 - Fix show permissions.
5f75891caea867b5c4cffd938b4281a4ba270e9d - Refactor the helper method.

Now the public events can be seen by all the users, even anonymous ones. See the change here: :eyes:  c5fb37a7449d3c23000a1bd7d89064f696badb2d


Documentation: Doc/several operators page

[ ] finish taking comments into account
[ ] update htmls
[ ] remove pictures for Operators Entry and Premium cards

@anslpa the dpf_entry.html and dpf_premium.html files are too large to edit here. Let me know if you want me to check out your branch and edit these files.

Do we have a status on the premium/entry logos?

We'll remove the logos and have a section explaining differences between entry and premium and showing advanced premium examples.


Implement the register_processs command

This forwards process information to stagger for debugging.
See https://github.com/pusher/stagger/pull/5
/cc @mdpye

+1


This is not an issue but...

..perhaps you forgot to document
"material_theme_tabs_autowidth" : true ,

I just realized that this already works in the materialize theme.
Thanks and Regards
Gagan

:+1:

Thanks, updated.


Don't Synchronized data structures!!!

Navicat has this feature！But dbeaver haven't! It's very needed at work！

Hello @qq5411123,
It's not entirely clear what feature you are referring to.
Can you please provide more information? Screenshots/Recording may help. Thank you.


[DOCUMENTATION] Add license header to all sources

fix #379

closing as this project does not get enough attention


Fail to build latest version since Gradle Could not determine GCC metadata

Describe the bug
Task :Decompiler:compileDecompileLinux64ExecutableDecompileCpp FAILED

What went wrong:
Execution failed for task ':Decompiler:compileDecompileLinux64ExecutableDecompileCpp'.

No tool chain is available to build for platform 'linux64':
- Tool chain 'visualCpp' (Visual Studio):
- Visual Studio is not available on this operating system.
- Tool chain 'gcc' (GNU GCC):
- Could not determine GCC metadata: could not find vendor in output of /usr/bin/gcc.
- Tool chain 'clang' (Clang):
- Could not find C compiler 'clang' in system path.

To Reproduce

Use automatic script instruction to setup dependencies
Build on CentOS 7 with instruction "gradle buildNatives_linux64"
Error occur

Expected behavior
According to the instructions, the Ghidra should be build successfully
Environment (please complete the following information):

OS: CentOS 7.2
Compile: GCC 4.8.5, g++ 4.8.5
Java Version: 12.0.2
Ghidra Version: 9.2

Additional context
I install gcc with yum. However, it may indicate that my gcc has some problem that not match its needs. I think it may caused by gradle. But I have no idea what's wrong in gradle or your codes.

What version of Gradle are you using?

I found this on the Gradle site:

Note that if you are using GCC then you currently need to install support for C++, even if you are not building from C++ source. This restriction will be removed in a future Gradle version.

@ryanmkurtz emm... the master branch

@ryanmkurtz emm... the master branch

Gradle, not Ghidra.

@ryanmkurtz 6.0.1 The latest version. Maybe I should use a legacy version? I didn’t find an instruction which gradle works well.

I have tried the latest gradle and it works, but I'm on Windows.  Did you try installing g++?

I found this on the Gradle site:

Note that if you are using GCC then you currently need to install support for C++, even if you are not building from C++ source. This restriction will be removed in a future Gradle version.

I’ve also notice that. But my GCC does support for C++. So that made me confused.🤔

I have tried the latest gradle and it works, but I'm on Windows. Did you try installing g++?

You mean that I should reinstall g++ separately? I’ll try it later after my getting up.😴

I have tried the latest gradle and it works, but I'm on Windows. Did you try installing g++?

You mean that I should reinstall g++ separately? I’ll try it later after my getting up.😴

What is the output of gcc -v?
I ask because I found this information here and am wondering if the gcc target isn't what gradle is expecting. A cause would be if gcc was unexpectedly targeting a 32-bit system or if gcc doesn't exactly target your system's architecture.

I have tried the latest gradle and it works, but I'm on Windows. Did you try installing g++?

You mean that I should reinstall g++ separately? I’ll try it later after my getting up.😴

What is the output of gcc -v?
I ask because I found this information here and am wondering if the gcc target isn't what gradle is expecting. A cause would be if gcc was unexpectedly targeting a 32-bit system or if gcc doesn't exactly target your system's architecture.

@astrelsky The target of my gcc is "x86_64-redhat-linux". This gcc was installed with my CentOS 7 system. I've never changed it. Following info is the output.

使用内建 specs。
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper
目标：x86_64-redhat-linux
配置为：../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-linker-hash-style=gnu --enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto --enable-plugin --enable-initfini-array --disable-libgcj --with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install --with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux
线程模型：posix
gcc 版本 4.8.5 20150623 (Red Hat 4.8.5-36) (GCC)

Here is the code that is throwing the error:
What is your output of gcc -dM -E -v -

Here is the code that is throwing the error:
What is your output of gcc -dM -E -v -

使用内建 specs。
COLLECT_GCC=gcc
目标：x86_64-redhat-linux
配置为：../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-linker-hash-style=gnu --enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto --enable-plugin --enable-initfini-array --disable-libgcj --with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install --with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux
线程模型：posix
gcc 版本 4.8.5 20150623 (Red Hat 4.8.5-36) (GCC)
COLLECT_GCC_OPTIONS='-dM' '-E' '-v' '-mtune=generic' '-march=x86-64'
/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/cc1 -E -quiet -v - -mtune=generic -march=x86-64 -dM
忽略不存在的目录“/usr/lib/gcc/x86_64-redhat-linux/4.8.5/include-fixed”
忽略不存在的目录“/usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../x86_64-redhat-linux/include”
#include "..." 搜索从这里开始：
#include <...> 搜索从这里开始：
/usr/lib/gcc/x86_64-redhat-linux/4.8.5/include
/usr/local/include
/usr/include
搜索列表结束。

I have wait for a while. It seems just stop here. Some directories like “/usr/lib/gcc/x86_64-redhat-linux/4.8.5/include-fixed” are ignored since they are not disappeared. And it just find 3 directories.

Gradle may not be able to handle parsing the non-ascii character set.

They are looking for the word "version" but your output has "版本" instead.

They are looking for the word "version" but your output has "版本" instead.

 Our IT just change the system language for me. And it worked. Thanks a lot!


Add the Comparison Handlebar helpers

@dcalvom for whatever reason I didn't realize that handlebars couldn't do conditionals out of the box can you install the comparison helpers from here: https://github.com/helpers/handlebars-helpers#comparison
@btotharye this would allow you to do your Mycroft stuff without needing an additional API for fulfillment.

I added the comparison helper to Hanldebars.
Closed by https://github.com/samtecspg/articulate/commit/42d51df55a3e84d7cc2aac576e9cc1340c3a8b72


user_status: Trigger input focus once the modal is shown.

Minor commit for #19417.
Screenshot

Actually while debugging this, I was stuck at another point as well (not related to this issue).
The components.ts takes in a parameter child_wants_focus which triggers the focus event on the current tab.
https://github.com/zulip/zulip/blob/bbcc4798b7ed723d666ccf3d988afc7a4a71754e/static/js/components.ts#L32
However, within the function declaration, we have the logic to handle it like-
https://github.com/zulip/zulip/blob/bbcc4798b7ed723d666ccf3d988afc7a4a71754e/static/js/components.ts#L91-L93
What am I missing here ? I rectified the logic to remove the negation, the keyboard focus gets properly binded with keyboard shortcut UI (which was missing earlier).

It looks like the child_wants_focus logic was introduced here: 0e7073ec29b044cf802f5c409e87b1112f17b0c3
@showell can probably clarify, but I suspect what's going on is "if the child doesn't want focus, we should focus the toggle element".

Merged, thanks @aryanshridhar!

(Can you also debug the "keyboard shortcuts" widget's focus issues that prevent keyboard navigation while you've got a process for this?  That bug is really embarrassing)


config: list several modules that were missing

Add missing modules to configuration file generator.  I did not add deprecated and obscure modules.
(Referencing PR #173 because it would make sense to merge this before release.)

many thanks for your patch, it was very useful to clean up the config
I tested with your default config, and get a couple of warnings:
dl: mod: ./dtmfio.so (dlopen(./dtmfio.so, 6): image not found)
module dtmfio.so: No such file or directory
dl: mod: ./echo.so (dlopen(./echo.so, 6): image not found)
module echo.so: No such file or directory

these modules are not built by default, so I think they should be commented out
in default config.

From my reading of mk/modules.mk module dtmfio is enabled by default on Linux and disabled elsewhere.  Thus I've wrapped it in #ifdef LINUX.  Is it fine?

thank you @czarkoff  :)


HTML and XML code blocks do not render properly

I was recently trying to preview a document where I have some XML code blocks for SOAP web service calls and found that the Markdown Preview handling of XML and HTML style elements is wonky at best.  As you can see in the example image below, some sections only show pieces of the code, while other sections disappear completely.  I understand there is likely HTML generation happening for the preview, but perhaps the input needs to get escaped?  I even tried wrapping my code block in HTML comment tags, with no change.

Looks like it doesn't work with Java either

It seems to work fine with the version 3.0 :slightly_smiling_face: I'll close this, please reopen if it doesn't for you.