docs: autorefs warning about rst reference

From https://github.com/Python-Markdown/markdown/pull/1494#issuecomment-2541515245:

when rendering API docs, we enable automatic summaries (summary: true in mkdocs.yml)
previously this was an Insiders feature, and it was recently made available to everyone, so it's now active in this project too
when we render the extensions sub-package, we summarize each submodule
to summarize items, we render the first line of their docstring
in the case of the admonition module, its first line contains a reference: [rST][]
since we only render this first line, the reference is unresolved by Python-Markdown itself, and autorefs kicks in (and fails too)

Possible solutions:

don't use "defered inline references" (not sure what to call them) in docstrings summaries (the first line) and instead put their URL directly within them (so [rST](https://...) instead of [rST][]), or move them lower, into the docstring body
use pymdownx.snippets to auto-append references at the end of each markdown document (done on the fly, no modification to any file, except maybe to remove all refs from everywhere and gather them in the single auto-appended file, see https://facelessuser.github.io/pymdown-extensions/extensions/snippets/#auto-append-snippets)
disable auto-summaries

Answering to https://github.com/Python-Markdown/markdown/pull/1494#issuecomment-2541641709:

As an aside, if you are rendering a partial document, then you need to account for reference links and properly render them. IMO there should be no requirement that the document author needs to account for this and alter the way links are formatted.

If we want to account for references, then we'll have to parse (actually convert) the whole document with Python-Markdown, then only keep the HTML part we're interested in, which in this case is the first line. Not sure how much sense "first line" makes in HTML. It would probably translate as "first paragraph". Which if we want to do in a robust manner, would mean either parsing HTML again (no-go IMO, too inefficient), or using a temporary Python-Markdown extension (probably a tree processor) that prunes everything after the first paragraph. This could be wasteful too (converting the whole document just to get rid of most of it). Not sure if there are ways to make this more efficient (stop as soon as a first p element is added to the tree).

Reference links are resolved.

Implies the above.

Links are striped from summaries and only the label text is included.

Doesn't seem possible. The non-natively resolved reference could a valid autorefs cross-reference. In this case we do want the warning.
I'd be tempted to say that this is a limitation of the summary feature, and that users should account for it rather than the opposite. The same thing happens for rendering docstring sections by the way, since docstrings written following the Google-style or Numpydoc-style will be split into sections (and sections into items), and each section (item description) will be rendered separately, meaning each section (item) must include its own references and footnotes for them to resolve. Maybe there'd be yet another way for us to inject ourselves into the conversion process with an extension, in order to collect references and footnotes, but our integration with Python-Markdown is already quite complicated so I'm reluctant to complicate it further.

Disable summaries. But I'm not clear on what they look like so maybe we do want them. I need more info to know.

Try serving the docs locally to see how it renders :slightly_smiling_face:

IMO this is very clearly a bug in mkdocstrings. Requiring me to change Markdown which otherwise renders fine is unacceptable. And requiring me to use additional extensions to render Markdown which otherwise renders fine is equally unacceptable. That said, I understand that this is not an easy problem to solve, but, IMO, it is a problem that mkdocsstrigns needs to solve. Fortunately, as a workaround, I am not opposed to changing the Markdown in this instance. However, if mkdocstrings maintains its current behavior, I would expect you to receive continuing reports from users as more of them encounter this issue.
I have encountered other summary implementations before and the only behavior that works consistently is one where the entire document is rendered and then the summary is split out.  Or at least that is how it needs to appear to work to the user. It is possible that an implementation could do some gymnastics under the hood to avoid needing to render the entire source document, but, however it is implemented, the end user should be able to assume that the split happens after rendering.

Links are striped from summaries and only the label text is included.
Doesn't seem possible. The non-natively-resolved reference could a valid autorefs cross-reference. In this case we do want the warning.

I'm saying that it might be preferable to some users to never have any links in summaries. Therefore, a config option to remove all links from summaries, regardless of how they get there, might be a sensible option. Of course, in this instance, it wouldn't resolve the issue because the source text is not actually recognized as a valid link.

I'd be tempted to say that this is a limitation of the summary feature, and that users should account for it rather than the opposite. The same thing happens for rendering docstring sections by the way, since docstrings written following the Google-style or Numpydoc-style will be split into sections (and sections into items), and each section (item description) will be rendered separately, meaning each section (item) must include its own references and footnotes for them to resolve.

I see the two as very different. It is easy to understand that each docstring is a standalone document. And I am assuming that in this discussion. However, for an individual document (docstring in this case) to not render correctly because only a portion of it is fed to the renderer is a bug.
In any event, the above is my personal opinion about the general behavior of mkdocstrings' summary feature. However, this is not an issue opened in the mkdocstrings project. Presumably any further discussion about mkdocstrings' behavior should happen on that project. So, going forward in this discussion, let's focus on the immediate workaround with mkdocstrings' current behavior.
I expect that we will do one of the following:

Disable summaries.
Reformat that one link.
Rework the text so that the link doesn't appear in the summary.

Try serving the docs locally to see how it renders

That is my intention. Unfortunately, I don't have access to a local instance right now. When I do I will report back.

IMO this is very clearly a bug in mkdocstrings. Requiring me to change Markdown which otherwise renders fine is unacceptable. And requiring me to use additional extensions to render Markdown which otherwise renders fine is equally unacceptable. That said, I understand that this is not an easy problem to solve, but, IMO, it is a problem that mkdocsstrigns needs to solve. Fortunately, as a workaround, I am not opposed to changing the Markdown in this instance. However, if mkdocstrings maintains its current behavior, I would expect you to receive continuing reports from users as more of them encounter this issue.

From memory, we had 4-5 occurrences, including this one.

I see the two as very different. It is easy to understand that each docstring is a standalone document. And I am assuming that in this discussion. However, for an individual document (docstring in this case) to not render correctly because only a portion of it is fed to the renderer is a bug.

Docstrings are not meant to be rendered "as-is". When you format them following Google-style or Numpydoc-style conventions, they're not just Markdown anymore. Rendering them "as-is" is a mess, just try it and you'll see all your parameters rendered on a single line without any proper formatting.
The docstring styles let you structure data using plain text, so yes, you either need to pre-parse them to split everything in sections and items that you render separately, or you need to enable a Markdown extension that will understand these styles. We do the former because the latter would require communication between the Markdown extension and the tool that extracts data from Python source (Griffe here), which is even more complicated to achieve, especially when the tool itself strives to be markup-agnostic.
So lets agree to disagree :shrug: And yes this conversation should continue in mkdocstrings :relaxed:

I expect that we will do one of the following:

Sounds good!


Made south optional (using Django migrations from 1.7 on)

South is not compatible with Django 1.8. This commit removes the mandatory South dependency when Django >=1.7.

@claudep Thanks!


[SPARK-25362][JavaAPI] Replace Spark Optional class with Java Optional

What changes were proposed in this pull request?
Previous Spark versions didn't require Java 8 and an Optional Spark Java API had to be  implemented to support optional values.
Since Spark 2.4 uses Java 8, the Optional Spark Java API should be removed so that Spark uses the original Java API.
How was this patch tested?
OptionalSuite class was removed to test Spark Java API Optional class (this class as well).
Notice that the get method in the Spark Java API Optional class throws a NullPointerException when the value is not set whereas the native Java API java.util.Optional throws a NoSuchElementException.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

We can't do this until we decide whether the next version will be a major version or not. This breaks backwards compatibility. (See the bug I duplicated your bug to.)

Yeah this is the right kind of change but needs to wait for now. Can you update the title?

Updated @srowen
The PR title already contains SPARK-25395, is that what you're expecting or another PR?

Oops, I mean SPARK-25362. SPARK-25395 was a duplicate.

No problem. Done ;-)

Test build #4368 has started for PR 22383 at commit 054c79a.

Test build #4368 has finished for PR 22383 at commit 054c79a.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Yeah, you'll have to add this to the 3.0 excludes section of project/MimaExcludes:
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.api.java.Optional")

Test build #4376 has started for PR 22383 at commit 6eaa3f1.

Test build #4376 has finished for PR 22383 at commit 6eaa3f1.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #4379 has started for PR 22383 at commit f188243.

Test build #4379 has finished for PR 22383 at commit f188243.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Oh, hm:
Serialization stack:
	- object not serializable (class: java.util.Optional, value: Optional[x])
	- field (class: scala.Tuple2, name: _2, type: class java.lang.Object)
	- object (class scala.Tuple2, (1,Optional[x]))
	- field (class: scala.Tuple2, name: _2, type: class java.lang.Object)
	- object (class scala.Tuple2, (1,(1,Optional[x])))
	- element of array (index: 0)
	- array (class [Lscala.Tuple2;, size 5)

So java.util.Optional isn't Serializable. Well, that may scuttle this whole idea. I think we're going to find a number of instances where Spark or user apps need to collect() Optional objects.
Unless someone has a bright idea I think we can't do this. Same reason I was unable to change Spark to use java.util.function interfaces -- lambdas aren't otherwise Serializable in Java!

I agree @srowen.
What do you think about reusing the current implementation we already have, for example, in the guava lib instead of having that class in Spark?

Spark's class only reason to exist is so we do not use the Guava class, since everyone and their pet want to use a different version of Guava (and Spark shades it for that reason).

Yeah, I think we just can't do this unfortunately. It was worth looking into.


SC1056,1072 Flags |, &&, || after Line Continuation

OS: Windows 10 Enterprise, Version 1909, Build 18363.1556
VSCode Version: 1.56.2
Shellcheck Version: 0.7.2 (installed from .zip on GitHub)
The following code works on shellcheck.net, but fails in VSCode on Windows:
_my_test() {
  echo '1 2 3' \
  |cut -d' ' -f2
}

Errors at the |, expecting a }. Operators are required on new line per the CONTRIBUTING guidelines I am following for code readability (similar to putting operators on new line in Python)

Probably due to CRLF line endings, can you try with the CLI?

@felipecrs I can confirm it occurs with the CLI. Please also see https://github.com/koalaman/shellcheck/issues/2239. This is definitely something with shellcheck on Windows as opposed to just the VSCode Extension.

@felipecrs I can confirm switching from CRLF to LF in VSCode as you showed solves my problem. Thank you for this great tip! This issue can be closed now.

Solved by switching CRLF to LF in VSCode.


Dont work with Sinytra Connector

Minecraft version
1.20.1
Describe the issue
Crashes.
game_output.txt
(It doesn't generate the crash log file, this is the only thing I can give)

Probably worth closing over here, this is something the Connector devs would need to fix
https://github.com/Sinytra/Connector/issues/135


Update weather-bot cookbook

Codecov Report

Merging #327 into master will decrease coverage by 7.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
- Coverage   40.67%   32.69%   -7.99%
==========================================
  Files          91       87       -4
  Lines        2896     2505     -391
  Branches       10       10
==========================================
- Hits         1178      819     -359
+ Misses       1717     1685      -32
  Partials        1        1


Request: Use double click of a key or mouse button as Pie Key

I'd love to be able to access the Pie Menu by only using the mouse. The current Pie Key options don't really allow for that in a practical way. A solution could be to add an option for a double click of either a key or a mouse button to open the menu. Double clicking the middle mouse button, for example, would be pretty convenient I think.
Keep up the awesome work, in my search for the best pie/radial menu this is by far the most visually appealing and functionally fastest to use!

This is a good idea, I don't know if I will be able to add it easily though.
For the time being (although I'm sure you've already considered these options) I'd say take a look at the Back and Forward mouse buttons if you have them.  Otherwise, you can use MMB or RMB with a modifier key, or use the 'Pie Enable Key' to set any keystroke to be used as a kind of modifier key.
I'm happy you find this useful!  Fast and pretty was definitely my goal here.

This setup could actually work: [Setting the Pie Enable Key to the back button and Pie Key to MMB], if it didn't completely disable the actual back function of the back key. Is there any way to avoid this? Say, have the Pie Enable Key functionality work as long as you hold down the key, but on up/release still send the original key's function? The back and forward functions already work on key up/release so it wouldn't change anything in the rest of the OS I think.

Yeah that could work, like I just set up the 'Profile Enable Key' if it's in hold mode to send the original key's function if no pie menu is launched when it is released.  This would have a checkbox option.  Lmk if this would work for you.

Yeah that could work, like I just set up the 'Profile Enable Key' if it's in hold mode to send the original key's function if no pie menu is launched when it is released. This would have a checkbox option. Lmk if this would work for you.

So, is this something you're planning to incorporate?
Not trying to rush you or anything, just wondering if that was the conclusion if this conversation.

Yes I do plan on doing this 👍, shouldnt keep you waiting too long. I'm planning on having a version up tomorrow.

Amazing, looking forward to it!

Thanks for waiting on this, v1.0.16 will have this checkbox option.

I've uninstalled the previous version, installed the new one, closed all my other scripts and restarted my pc to be sure. This new feature doesn't seem to do anything for me. I at least tried it with each of the mouse buttons as Profile Enable Key and none kept their original function, either with the checkbox ticked or without. Does it work on your end?

yeaaaupp I see the issue, fixing this now.

Alright... lets give it another try here (no rush though), v1.0.16
I updated the installer, and you shouldn't have to uninstall for this, simple reinstall should do it.  Lmk what happens on your end.

Yes! It works :). It breaks my other scripts that I have bound to 'Back' but that's fine. Instead I can do MMB as Profile Enable Key and RMB as Pie Key, that suits me quite nice!
Another thing I noticed: In trying to make a workaround for my own scripts to work with this I rebound Back to be F18 and used F18 as Profile Enable Key. And even though it recognises the button as F18 when I press it to assign it, it will not work in practice. I tried some more and it seems that any key bound to be a different key will not work for the Profile Enable Key. I don't know if this is by design or not? IF you could fix that it would be very appreciated but I'm already very happy with this new working checkbox :D

heck yea I'll take a small win for the day!
What software are you using to rebind your keys?  AHK or hardware specific software?

AHK. Just a simple setup like this for example doesn't work:
AHK script:
XButton1::d
AutoHotPie:
No Profile Enable Key, Pie Key = d (with 'hover over all selections').
XButton1 is the 'Back' button. Using 'Back' prints a 'd' in any text field but it doesn't open the Pie Menu. Using the regular 'd' key does open the Pie Menu.

So really we just need a way of getting the "~" on the Profile Enable Key in order to keep my app from stealing the "Back" from your scripts, at least to solve your problem in a cleaner way.  You could technically do this by modifying the JSON settings file, but then the settings UI won't read the file correctly.  I'll see if it would be easy to make it so adding that symbol doesn't break everything, if this seems useful.

I'm not sure if ~ could work. Maybe it could. Is there not maybe a way to make autohotpie recognize rebound keys? I mean it does, like I said, whenever you go to set it as a Pie Key. But then it doesn't when you actually try to use it after saving and running. I think solving this would open up a lot of custom usage options for people who would like that, assuming this is at all possible.
If it helps btw, I attached my script for you to inspect. It's basically AltDrag but my own version, and with XButton1. Paired with some simple volume control (which btw I have set up using F15/F16 for my own setup because of crazy audio routing but it defaults to normal use for anyone not having my master file so don't worry about that haha)
Back Magic.zip

Jeez that window drag function works really well.
This makes me think the tilde won't work as you've been saying, only because then blocking 'Back' if no menu is launched wouldn't be handled unless you did more to your back magic script which would start getting messing. You are essentially using 'Back' as a modifier key in a similar way that I am using the 'Profile Enable Key' to allow pie menus to run.  If you're desperate, we can test if this '~' would work on your end and you might not have to use the 'Send original keystroke' checkbox.  Just search for this key object:
"pieEnableKey": { 				"useEnableKey": true, 				"enableKey": "XButton1", 				"toggle": false, 				"sendOriginalFunc": false 			}
Then just add the tilde to the enable key value.
"enableKey": "XButton1",  => "enableKey": "~XButton1",
Then try and run the actual PieMenu.exe found in the installation considering the settings UI will error out if you try to :
"C:\Users{username}\AppData\Local\Programs\AutoHotPie\resources\src\PieMenu.exe"
No pressure to try this though, I'm only mentioning the 'solution' in case it points to any other non-garbage fix.  The best solution here still seems like it would be an importable PieMenu AHK class type.

Thanks, Back Magic is my proudest scripting achievement hahaha.
There's an inherent problem with using the tilde and that is that the original function of the key will always persist (which is a solution and also a problem). I put the ~ in the place you suggested and just turned my other scripts of for testing. Of course the AutoHotPie menu works, but also the back function persists. So if I have explorer or a browser open, that program will also go back a page which is not what you want. So the ~ sounds good in theory but in practice it doesn't work all that well. That said, there's probably ways around this that I don't know.
The tilde doesn't make AHP work when Back Magic is running though.
I also tried to implement the AHP and Back Magic script together in a single script but couldn't really figure out how to make it work.

Any updates on this request? A double click Pie Key would still be a great feature imo.
Btw, I've noticed for a long while now that AHP doesn't work reliably for me. When I haven't used it for some minutes (I'm not exactly sure how long) it doens't turn on anymore when I use the designated hotkey. I have to restart the script via the tray icon to be able to get it to work again. Is this a known bug? Does it happen to you too? I've had this with multiple releases since we last posted in this thread. I use MMB as Profile Enable Key and RMB as Pie Key.

Hmmmm whenever something like that happens, I can't left click on anything but I'm still able to right click which means I can right click on the tray like you. Can't tell why it happens since it doesn't happen often enough to me. I don't use MMB/RMB as Profile Enable though.

Hmmmm whenever something like that happens, I can't left click on anything but I'm still able to right click which means I can right click on the tray like you. Can't tell why it happens since it doesn't happen often enough to me. I don't use MMB/RMB as Profile Enable though.

This is a seperate issue as I do not have the experience of my left click being blocked. For me the hotkeys to call AHP just stop working after a few minutes of not using it. All other functionality in Windows or other programs is unaffected.

Yikes, welp, those are both definitely big issues.

I can't left click on anything

Added issue #38

the hotkeys to call AHP just stop working after a few minutes of not using it.

Added issue #39

Any updates on this request? A double click Pie Key would still be a great feature imo.

Sorry work has just been getting worky lately, haven't really had much time for larger updates.  The issue I ran into with this is that I can't block the first key press of the double press, so it's not as clean as I'd like to commit as an official feature.  If you believe it would still be useful though, please refute me.  For features like this is where I want to make the importable AHK class type, and I'd have to use AHKv2 for it, maybe switching to v2 would help other issues too.  Also, this person apparently got a simulated keystroke to be intercepted by another AHK script by switching to the 'open source' version in the settings (#31).

Sorry work has just been getting worky lately, haven't really had much time for larger updates.

No need to apologies, I appreciate all the time you spend on this project for us :)

If you believe it would still be useful though, please refute me.

All I can really say is this. For me, AHP is at it's most useful and convienent if I can operate it using only the mouse. Since the menu inherently needs you to point with the mouse you will already have your hand there but depending on the current task you won't necessarily have a hand at the keyboard. Using a double click of any mouse button (of course disregarding LMB) would be a fast and easy to use method of using AHP. Sacrificing any one click of a mouse button is not really an option. Having a setup like MMB as Profile Enable Key and RMB as Pie Key (which I use now) does work but requires a conscience  effort to perform which "disrupts" the workflow.

Also, this person apparently got a simulated keystroke to be intercepted by another AHK script by switching to the 'open source' version in the settings (#31).

I checked it out. Seems like that person accomplished to do the opposite of what I'm trying to do. They got another AHK script to recognise a virtual input created by AHP whereas I am trying to make AHP recognise a virtual input created by another AHK script. Switching to the open-source version didn't work for this unfortunately. So just to reiterate: A setup like this does not work:
AHK:
o::p
Pie Key:
p
Pressing o will not open the Pie Menu, pressing p will. This is the same if you use either 'send' or 'sendevent' in AHK.

I've completely solved my issues with AHK vs AHP thanks to another thread on the AHP Github page! Using #InputLevel in my other AHK file (the Back Magic One) makes it so AHP will finally recognise the hotkey created by AHK as an input while AHP is running. I can even use it with any Activation Mode now, I prefer the 'Hover over submenus, release on function'. The only thing I had to add to my Back Magic AHK file was this:
#InputLevel 1 XButton1::XButton1 #InputLevel 0
Works great now!


update url to article 'Build Your Own Static Vector Tile Pipeline'

Hey @geraldo thanks for the URL fix!


Converting String back to object

Hi,
Once I convert the object to string using toJsonString, how can I generate object form that same json string ? Basically How do i reverse from String -> Object
Also please update in pod too

This library isn't capable of deserialization. We welcome a PR to add that capability.


Debug Form doesn't show for RPC in DocService

The DocService doesn't show any Debug Form options under the endpoint definitions:

I have tried the following:
    private val grpcServiceBuilder: GrpcServiceBuilder = GrpcService.builder()
        .supportedSerializationFormats(GrpcSerializationFormats.PROTO)
        .supportedSerializationFormats(GrpcSerializationFormats.PROTO_WEB)
        .supportedSerializationFormats(GrpcSerializationFormats.PROTO_WEB_TEXT)
        .supportedSerializationFormats(GrpcSerializationFormats.JSON)
        .supportedSerializationFormats(GrpcSerializationFormats.JSON_WEB)
        .enableUnframedRequests(true)

Also I have seen this issue: https://github.com/line/armeria/issues/1134
But no luck. Does anyone know what is happening and maybe we can improve the documentation for future users?

Hey! Could you just try with this?
GrpcService.builder()
           .enableUnframedRequests(true)
           .addService(...)
           .build()

builder.supportedSerializationFormats(...) overwrites the values previously set, so I think only GrpcSerializationFormats.JSON_WEB is set by the code you pasted.
Also, all serialization formats are set by default so you don't need to set them explicitly. 😉

@minwoox that did the trick, thanks. Which serialization format do we need to enable to use the debug form? Currently we are using .supportedSerializationFormats(GrpcSerializationFormats.PROTO) because JSON serialization does not run with proto3 optional fields. So enabling all can be risky for us.
Also, if I set enabledUnframedRequests(true), will it affect how the framed requests are handled? I guess not but I would like to double-check.
Finally:

There is no example request body (I did not add any examples but I expected some default like bloomRPC did here - photo below). Is this expected or is there a way to enable this kind of thing in debug form?

I can contribute to such a a feature and update the documentation to enable the debug form.

Which serialization format do we need to enable to use the debug form?

It's GrpcSerializationFormats.JSON. https://github.com/line/armeria/blob/master/docs-client/src/lib/transports/grpc-unframed.ts#L21 (Sorry about that we don't have documentation about it. 😅 )

JSON serialization does not run with proto3 optional fields

Oops, I didn't know about it. Could you give us a link to it or provide a simple reproducible example so we can take a look at it?

if I set enabledUnframedRequests(true), will it affect how the framed requests are handled?

No, it's not. 😉 https://github.com/line/armeria/blob/master/grpc/src/main/java/com/linecorp/armeria/server/grpc/UnframedGrpcService.java#L100-L105

Seems like only optional and oneof fields are not rendered in the example body. It could be nice to see them somehow.

Oops, I didn't know about it. 😄 bloomRPC does render it by default?

because JSON serialization does not run with proto3 optional fields.

As far as I know, protobuf-jackson supports optional since 2.0.0 https://github.com/curioswitch/protobuf-jackson/issues/7
You can also set Gson as a json marshaller. https://github.com/line/armeria/blob/8df42aa225af877ef13781ec1b27c1fe0ce37883/grpc/src/main/java/com/linecorp/armeria/common/grpc/GrpcJsonMarshaller.java#L71
If you encounter another issues except what we have known, please let us know.

minwoox

Seems like BloomRPC is using a completely different serializer than JsonFormat.
We are not outputting any optional value because of the following logic inside JsonFormat: https://github.com/protocolbuffers/protobuf/blob/main/java/util/src/main/java/com/google/protobuf/util/JsonFormat.java#L998
I will try to trick the formatter by overriding default values to the optional fields but even if we did that, oneof fields won't work and it would require some other way of serialization. Just letting you know...


Stuck Loading Large Playlist

Firstly I would like to say that I love this project but I have this one problem with it so far.
When I try to open a larger playlist that I have I run into problems, it gets stuck loading the playlist. But playback of the last item still works.
The issue title says that there is an issue opening large playlists but from what I could determine from the log files that I was looking through this looks like an issue with parsing specific PlayableItems If there is anything that you can to to look into this that would be great here is a section of the logs that I thought was important. If you need more log info let me know.
2021-11-08T17:47:49.309565Z DEBUG reqwest::async_impl::client: response '200 OK' for https://api.spotify.com/v1/playlists/2RI4NLi6npcHfCNQQxP3nM/tracks?offset=900&limit=100
2021-11-08T17:47:49.329055Z DEBUG hyper::proto::h1::conn: incoming body completed
2021-11-08T17:47:49.329091Z DEBUG hyper::client::pool: pooling idle connection for ("https", api.spotify.com)
2021-11-08T17:47:49.345084Z  WARN spotify_player::client::handlers: failed to handle client request: error decoding response body: data did not match any variant of untagged enum PlayableItem at line 7643 column 5

Caused by:
    data did not match any variant of untagged enum PlayableItem at line 7643 column 5
2021-11-08T17:47:51.117104Z DEBUG librespot_audio::fetch: File bbc67baf52a28dab4cfec9e348ae0135a955596b complete, saving to cache

Hi @Atrociously, thank you for trying this out.
Regarding the problem, I experienced the same thing before actually. My best guess at that time is that the playlist contains a deleted or unavailable track so the application cannot parse response into corresponding Playlist struct but haven't take a deeper look.
Hope this is a not big problem for you and it's one thing I can definitely look into.
In the mean time, it would be helpful if you could send me the playlist's information so I can reproduce the issue quicker.

Sure the specific playlist that I have been attempting to load is this one, But that one is rather large so it may be difficult to find the problem going through that one. However there may be shorter playlists that have the same issue.

@Atrociously filed an issue in rspotify. They assume that TrackId is not null when getting a playlist's items but you seem to find a case when it is null.

Should be fixed with https://github.com/ramsayleung/rspotify/pull/282


dissolve common module

move bitset to common crate, move composite file to directory
dissolve common module

Approved, but can you fix the unit tests?


Search many locations for unqualified dot program

If the name of the dot executable is not qualified with a full path, we should search through some likely locations for it. Use the 'env' program with some likely paths to search through.
(A better way to know where to search would be to get the path from the user's environment, but the javascript runtime seems to scour that away.)
If we fail to complete running, tell the user what the problem probably is. From env man page,
An exit status of 127 indicates that utility could not be found.
Closes: #7
Closes: #20

Env '-P' is not widely supported. Awaiting a better fix.


Added GoAccess analytics for Docker-based deployment

Description
This PR adds GoAccess analytics.
Rationale
A production level application can benefit from the insights offered by the webserver (Caddy at the moment that this PR was submitted) analytics.
Notes
GoAccess offers both terminal and browser based visualization, with the latter being prettier of course. This PR enables the terminal based visualization.
To see this in action:

Create a new project, and choose y for Docker
Choose y for GoAccess
Start the production.yml configuration i.e. docker-compose -f production.yml up
And then docker-compose -f production.yml run --rm goaccess goaccess --log-format COMBINED --log-file /srv/logs/requests.log

Now that we switched to Traefik (https://github.com/pydanny/cookiecutter-django/commit/b312d516a422b08c299b57cdd3515a235f82b03e), I will have to investigate whether GoAccess is compatible.

I'm going to close this old PR as it became out of date.
Personally, I generally prefer to keep these kind of dashboards separate and use an external service for that, but I appreciate others might disagree and prefer this approach. Also, we have the Flower service taking this approach already.
We can revisit if there is community interest. Thanks for the work @demestav and sorry for not replying earlier.

I'm going to close this old PR as it became out of date.
Personally, I generally prefer to keep these kind of dashboards separate and use an external service for that, but I appreciate others might disagree and prefer this approach. Also, we have the Flower service taking this approach already.
We can revisit if there is community interest. Thanks for the work @demestav and sorry for not replying earlier.


Support for "read your own writes"

In order to build something like a REST API on top of event sourcing you need to have support for "read your own writes". The current Reactor API does not support this as the result of writing is Mono Void, whereas it should return something that can hold the transactional id of the write, so that the read can then wait for that transactional id to be seen by the read model subscriber.
Simplest fix would be to return Mono someattributebucketgoeshere, such that the client could get the id and then coordinate with read model subscriber, to not try to read the database until the events have been applied. I don't see how it would be feasible to create any REST API on top of Occurrent with reasonable semantics without this, unless I am missing something.

Hi Rickard!
There are workarounds for this since you can add any (cloud event) extension you like to the event persisted to the event store. So you could add your own transaction id when writing and then store that your projections. But regardless of the workaround, I have been thinking of adding something like this to the API just like you imply. But I haven't really thought things through and I'd love to discuss what should be returned. My current thinking is that the new event stream version should be returned when calling write. This way you can return that in from your REST API and you can query the projection to see if it's at the correct version (or if you're OK with breaking a few ES rules, you could query the event store directly if you have the right indexes).
Thinking out loud, would it make sense to change Mono<Void> to something like Mono<TransactionDetails> where TransactionDetails allows you to get things like the new stream version?
Currently Occurrent stores very little metadata, only the stream version and stream id. One thing that I think is very important to store is something like a "transaction id". Maybe also sequence number(but I think that by using a transaction id combined with "stream version" will get you the same functionality?) as well as "correlationId". The reason why I've not added this already is that I'd like to use cloud event standards as much as possible. I need to google around a bit to see if there's a standard way to represent a "transaction id" in a cloud events, I haven't seen it yet. I think there are standards for distributed tracing and sequence numbers. But again, I'm not sure how much I should add by default and how much should be left to the user to add himself (at least in core).
Btw, thanks for the issue! :) It's one of the first and I'm really glad for your feedback. I know you have a lot of experience with ES/CQRS and I'm eager to hear your thoughts and ideas if you're willing to share them.

Thinking out loud, would it make sense to change Mono<Void> to something like Mono<TransactionDetails> where TransactionDetails allows you to get things like the new stream version?

I arrived at this overload signature for the Transact function - you sometimes want to do a version check both pre and post. You can hang things off the context like session tokens too

@bartelink Thanks a lot for the links! Definitely need to check it out.

Yes, in the context of Equinox, the State is also in play - in some cases you want to project from the state including the events you just wrote.
But in the general case, depending on the store, you may want to equally expose a Version (for EventStore), or a SessionToken (for reading your writes in CosmosDB or Dynamo); the exact value depends on the store in question, but they'll have analogous purposes. If there was a need to expose the etag of the most recent version of the stream's Tip, it'd go here too (in Equinox that's not exposed, but is used internally in the caching mechanism)

I've taken an initial step to support this by adding a WriteResult that is returned when writing events (instead of void) to the event stores. WriteResult currently contains the stream id and stream version, but it could be extended to include other things in the future if needed (including perhaps database-specific metadata that could be of interest). One should be able to use the stream version to see if your projections are updated. I'm closing this issue for now, but if any of you have comments just let me know and we can re-open it :) For example with the reactive API:
Flux<CloudEvent> events = ...
Mono<WriteResult> result = eventStore.write("myStream", events);
var streamVersion = result.map(writeResult -> writeResult.getStreamVersion());

@rickardoberg Published version 0.10.0 now that includes the changes described above.

@johanhaleby Excellent!!


Add tasks route

Add endpoint for user tasks

Coverage remained the same at 60.0% when pulling 532fb751b1e5df81d183f35bea7a97471b06bf29 on feat/tasks-endpoint into a699233b6e3fef25d04516633e424de331305096 on master.


Dataset

Hi Sir,
I would like to create data of missing characters.
So Can you pleas explain how the data was created.

We had a web-app with a canvas to input characters and upload them.
I have lost access to the codebase, but it was almost similar to this.
Hope this answers your question.


A question about h3ToGeoBoundary

In the function h3ToGeoBoundary, why it used the intersection to replace the real vertex of the hexagon in some cases?

H3 is defined on an icosahedron, where each face of the icosahedron is projected to the sphere using an inverse gnomonic projection centered on that face. Each face-centered gnomonic projection maps the cell boundaries that lie on that face to great circle arcs on the sphere. But when a cell boundary crosses an icosahedron edge, it moves between two projection spaces. So we introduce a vertex wherever a boundary intersects an edge so that each part of the boundary can be projected independently using the appropriate face’s projection. These new vertexes do not replace the original vertexes; they are in addition to them.


Multiple videos on one page, play will trigger all videos to play.

Hi,
Not sure if it's me or it's really a bug.
I have a page where I load mutiple videos and they all start playing when I change the playings state each video is wrapped in its own video component. I'm using vimeo in this case and they are all different videos.
Hope this helps.

Ik was updating a state also 'onPlay'.

How did you get around this? I'm having the same problem and apparently making the same mistake. I have the player in a slider and need to tell all the children to stop playing when the next slide is selected.


Include RPC endpoints in self-generated API docs

I see: https://github.com/begriffs/postgrest/pull/639 - I see that is merged into master - I am running 3.2.0 - is there a release coming soon? If I did start using master (instead of what comes down from a brew install postgrest), to get the endpoint data, do you just make a request with Accept: application/swagger+json or Accept: application/openapi+json
I also see from the API reading doc page: "As well as issuing a GET / to obtain a list of the tables, views, and stored procedures available, you can get more information about any particular endpoint."
Should I be able to see functions like /rpc/login, /rpc/signup? (like described in the example auth - http://postgrest.com/examples/users/ ) I don't see those in a GET request to the root endpoint. For example, an "anon" user, making a GET request to the root endpoint, sees only the views they have been given permission to (anon does not have access to tables). They don't see anything related to any /rpc methods in that GET request, but can POST to those endpoints to sign up and log in. If I try to make an OPTIONS (any request other than a POST) request on /rpc/login, I get <Response body is empty>. Is there something we need to do when creating the /rpc endpoints so this information get exposed?
Is there someway to get a list of all open/accessible endpoints and their available request methods? (and ideally what those endpoints expect for a successful request - body, headers, ?)

The version on the master branch responds with OpenAPI for the root if you request Accept: application/openapi+json. Also #693 will make that the default and you won't have to send any special Accept header.
Currently function calls are not described in the self-generated docs. I'll mark this as an issue for the 0.4 milestone.

Thank you @begriffs .  Getting the RPC endpoints into the self-generated API docs will be very useful to me as I am in the process of converting a big chunk of our current views into table returning functions instead.


[RDKDEV-262] DeviceIdentification: syncup from metro version

Copyright scan failure
Commit: fb4a225bab17323ffc437261c611863ad6dd2a13
Report detail: https://gist.github.com/c67b3db54fb0b82c3797c1cd155e27d7

Hi @pkumbh631  Please see my comment on pull req 2621 about updating NOTICE.

NA


Updated ipywidgets

Updated ipywidgets from v7 to v8 to work with JupyterLab.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

LGTM

Run Python PreCommit

Run Python PreCommit

Run Python PreCommit


Chunk long TXT records when using ZoneFileProvider

When generating a zone with long TXT records (for example DKIM records with 2048 bit keys), the TXT record becomes to long and named-checkzone fails to validate the zone.
It seems that adding the following line to the ZoneFileProvider class splits up the record nicely:
if record._type in ('SPF', 'TXT'):
    # TXT values need to be quoted
    value = value.replace('"', '\\"')
    value = record.chunked_value(value)   <--- This line
    value = f'"{value}"'

I could make this into a pull request if needed.

I think I ran into this when working on https://github.com/octodns/octodns/pull/1172 and addressed it there, but since that didn't ship, for now, it probably makes sense to get this sorted standalone. Will queue it up to look into.


Support the ability to provide a context

This adds support for passing in a context as other robust libraries (such as Redux) support: https://react-redux.js.org/api/provider#props.
This is important as right now React Query supports creating multiple queryClient instances but does not currently support the ability to specify which queryClient instance should be used with useQueryClient. In the case of nested QueryClientProvider instances in an application, the ability to specify which context (and thus which QueryClientProvider and queryClient)  should be used is critical. This adds such capability.
These changes should be 100% backwards compatible.

What would be the use-case for needing multiple, nested QueryClientProviders where you do not want to lookup the nearest one?

The scenario I have been seeing is an app container that wants to provide some core data using React Query but wants to have no coupling to the apps that it renders that may or may not be using their own React Query for their own data. In that case, trying to access the core data will try to access the app’s React Query instead of the app container’s.
Assuming a single context for all React Query instances leads to this issue and is the reason robust libraries like Redux support the option to specify which context to use at the provider and at the consumer level.

I think the code changes look fine, I'd still want @tannerlinsley's opinion here. We'd also need some tests and updates to the docs please. Feel free to wait with that until Tanner gives his okay :)

Any updates here?

@tannerlinsley what do you think please? Is that a feature that should make it into the library?

To illustrate the need for this a bit more clearly here:
<ContainerDataProvider> // <-- Provides container data using its own React Query provider
  ...
  <AppDataProvider> // <-- Provides app data using its own React Query provider
    ...
      <MyComponentDataProvider> // <-- Provides component data using its own React Query provider
        <MyComponent />
      </MyComponentDataProvider>
    ...
  </AppDataProvider>
  ...
</ContainerDataProvider>

Each "DataProvider" uses its own React Query provider for isolation and abstraction. Those that consume the data of these providers should not have to know what library they are using for data fetching and storage.
In this case, MyComponent needs to access useQuery from both  MyComponentDataProvider and ContainerDataProvider. Unless we can specify which context we wish to use for each useQuery, it will default to MyComponentDataProvider and fail.

I think this is a valid addition as long as:

It is backwards compatible
Doesn't require any code gymnastics to support it. The code looks simple enough on my first look-through, so let's hope it stays that way
It gets documented extremely well as an optional and often unnecessary feature
It gets tested well.

@blackarctic would you like to continue with the PR now that we have the approval from Tanner?

Yes. Sounds like we need:

Update branch to latest
Add accompanying tests
Add accompanying documentation

@TkDodo PR should be ready for re-review

code looks good - there seems to be one test failing consistently.

Not seeing any failing tests but it looks like coverage dipped by 0.03% in src/devtools/devtools.tsx. However, none of the uncovered lines of code were touched as part of this PR. Trying to get this PR in, though, so I added a test to test some of the untested code in the file to get the coverage up.

Thank you. I am thinking that maybe we should wait with the PR until v4 though. We are planning to change the api for useQueries to become an object, which would fit this use-case very well, because we could provide the context option at the very top, working for all queries:
useQueries({
  queries: [query1, query2, ..,. queryN],
  context: MyContext
})

Thank you. I am thinking that maybe we should wait with the PR until v4 though. We are planning to change the api for useQueries to become an object, which would fit this use-case very well, because we could provide the context option at the very top, working for all queries:
useQueries({
  queries: [query1, query2, ..,. queryN],
  context: MyContext
})

That would mean each query config (query1, query2, ..,. queryN) could not contain their own context? I would prefer to do that as a followup as that changes a good amount of types and implementation.

Judging from the current implementation, I was under the impression that it is a requirement that each query in useQueries uses the same context?

Judging from the current implementation, I was under the impression that it is a requirement that each query in useQueries uses the same context?

Correct, but this now changes the types of these query objects so that they cannot include the context option. They are now a different type of query object than what is passed to useQuery. This also changes the implementation of useQueries since we can no longer blindly pass this different query object (without the context) to handlers of single queries because those might be handling the context. This will require us to re-add the context to each query object before passing it to any single query handlers.

Correct, but this now changes the types of these query objects so that they cannot include the context option. They are now a different type of query object than what is passed to useQuery.

I think that's fine - we can Omit the context on type level for useQueries.

This also changes the implementation of useQueries since we can no longer blindly pass this different query object (without the context) to handlers of single queries because those might be handling the context. This will require us to re-add the context to each query object before passing it to any single query handlers.

yes, we would need to spread the context from the top level into each of the queries. Is that a problem?

Correct, but this now changes the types of these query objects so that they cannot include the context option. They are now a different type of query object than what is passed to useQuery.

I think that's fine - we can Omit the context on type level for useQueries.

This also changes the implementation of useQueries since we can no longer blindly pass this different query object (without the context) to handlers of single queries because those might be handling the context. This will require us to re-add the context to each query object before passing it to any single query handlers.

yes, we would need to spread the context from the top level into each of the queries. Is that a problem?

Nope, not a problem. Just outlining the additional changes that will need to happen and the increased risk of issues in long-running PRs.

I've just merged the new useQueries api into the alpha branch. can you please base your PR on alpha, thank you :)

This looks very good, thank you 🙏 . It seems that the useQueryClient api docs do not mention the new context yet, could we add that there as well?
Also, I'm a bit worried that the name context might be confused with the queryFunctionContext that we already have - the object that is injected into the queryFn. Do you think it would be better to choose a different name?

This looks very good, thank you 🙏 . It seems that the useQueryClient api docs do not mention the new context yet, could we add that there as well?
Also, I'm a bit worried that the name context might be confused with the queryFunctionContext that we already have - the object that is injected into the queryFn. Do you think it would be better to choose a different name?

Hmmm, I see your point. Well we could call it reactContext, reactQueryContext, customReactQueryContext, customReactContext, customReactQueryContext, queryContext, or customQueryContext? Any suggestions?

can you also add something to the New Features section in the migrating to v4 doc please. I think it's good to let people know that way that we now have this feature 🚀

Is it possible to export the default context too? I have the same structure as https://github.com/tannerlinsley/react-query/pull/2548#issuecomment-915496288 but I don't necessarily need to pass the context option everywhere.
I would like to use the parent context if it exists, much like contextSharing but without using window, the idea is to do something like:
function SubApp({}) {
  // const parentQueryClient = useQueryClient(); // Does not work because throws an error if tested in isolation
  const parentQueryClient = useContext(QueryClientContext);
  const queryClient = useMemo(() => (parentQueryClient || new QueryClient()), [parentQueryClient]);

  return (
    <QueryClientProvider client={queryClient}>
      {/* ... */}
    </QueryClientProvider>
  );
}

Or just an option that skips the error from useQueryClient.

@blackarctic we are nearing the release of v4. is there a chance we could get this in?

Is it possible to export the default context or getQueryClientContext too? I have the same structure as #2548 (comment) but I don't necessarily need to pass the context option everywhere.
I would like to use the parent context if it exists, much like contextSharing but without using window, the idea is to do something like:
function SubApp({}) {
  // const parentQueryClient = useQueryClient(); // Does not work because throws an error if tested in isolation
  const parentQueryClient = useContext(QueryClientContext);
  const queryClient = useMemo(() => (parentQueryClient || new QueryClient()), [parentQueryClient]);

  return (
    <QueryClientProvider client={queryClient}>
      {/* ... */}
    </QueryClientProvider>
  );
}

Or just an option that skips the error from useQueryClient.

Exported the defaultContext from QueryClientProvider. @TkDodo Is that ok with you?

can you also add something to the New Features section in the migrating to v4 doc please. I think it's good to let people know that way that we now have this feature 🚀

Done

@blackarctic we are nearing the release of v4. is there a chance we could get this in?

Sorry for the delay. Should be good to re-review.

@blackarctic we are nearing the release of v4. is there a chance we could get this in?

@TkDodo Sorry for the delay. Should be good to re-review.

thank you so much for bearing with me here @blackarctic. It's been a long 7 months since you opened the PR. It will be a great addition to v4 🚀 . Thank you for the contribution 🙇

:tada: This PR is included in version 4.0.0-alpha.21 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


I'm unable to produce this behavior on an 4th generation iPod touch (running iOS 6.1.6) and a 3rd generation iPad (iOS 8.1) - both fairly old models, and the iPod, especially, fairly lean, resource-wise.
This all is making the problem seem situational - something to do with the conditions of your test environment, perhaps a marginal resource like memory or bandwidth. I wish we had a way to narrow it down, somehow.

All I had to do was forcequit with keep me logged in on and then try to relaunch the application. Doesn't glitch multiple times every time but at least once with great reproducibility.


Sensitive project template can't be exported

Link to error

json: cannot unmarshal object into Go struct field Template.Items.Templates.DefaultValue of type string

The cause of this error was that the default value returned by the API can either be a string or an object capturing the details of a sensitive variable. Octoterra assumed the response was a string though, and failed to serialise a sensitive value.


DYNAMIC DEVICE NAME

You can choose the deviceName when you start a session with api. This allows each session to have a different device name on the WhatsApp servers and lowers the risk of being detected.

Você pode implementar isso?


Add GetPrinterType procedure to Printer Setup

Adds (exposes) a GetPrinterType procedure to the "Printer Setup" codeunit.
Restricted to [Scope('OnPrem')].
To be used for On-Premise extensions, as a more stable alternative to copying the implementation of GetPrinterCategory in the "Printer Setup Impl." codeunit.
Addresses #7549.

Anything else I can do for this PR?

I've reached out to the team again.

@rvanbekkum This has been reviewed and approved by the team, we're merging it internal now :)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Availability update: We will publish a fix for this issue in the next update for release 19.

These autogenerated messages are strange. I should either get those adjusted or removed :-)


Installing certs for Firefox/Chromium on Linux

Hi, while I don't have a use case for mkcert, I've just recently written a shell script which inserts a CA into all browser profiles for a user, and I thought I just leave some hints here:

For Firefox, the cert needs to be inserted into each NSS db in each profile directory within ~/.mozilla/firefox, using certutil. The code in truststore_firefox.go looks good already
For Chromium (and probably also Chrome), there's a central NSS db in ~/.pki/nssdb into which the certificate can be added via certutil, very similar to Firefox

That should do the trick for Linux for the most widely used browsers at least (which should cover like 90% of the use cases out there).
Adding the certificate to the system's trust store depends on the Linux distribution, it's a lot more complex. For Fedora, the browsers also trust certificates in the system-wide trust store in /etc, on Debian that's not the case: browsers just ignore all system ca certificates.

Thanks @fd0!


Add diagram for Avail

This pull request adds a diagram illustrating the Avail + Cartesi architecture. The diagram shows the different components involved, such as the App Front End, App Back End, Database, and various APIs. It also includes connections between these components and highlights the flow of data.

Preview: https://github.com/Calindra/nonodo/blob/docs/avail-diagram/docs/avail.md#avail--cartesi


Shared link preview shows only channel name

Hi! Thanks for your great work on this app and the lbry network. Recently, I shared a video and checked the preview of the link. It shows the channel name but not the video title. Can you please add an option to decide what the user would like the preview to show?
Thank you very much!
Keep up the good work!
Best regards Steve

Can you share a sample of the link? I think it's a bug with the format of the link we're adding.

Can you share a sample of the link? I think it's a bug with the format of the link we're adding.

For example this one https://lbry.tv/@Kessel_Buntes_TV#e/es-ist-eine-l-ge-punkt-preradovic-mit#6

For example this one https://lbry.tv/@Kessel_Buntes_TV#e/es-ist-eine-l-ge-punkt-preradovic-mit#6

Thank you, this is a bug with the urls themselves. You can try replacing # with : manually to make it work for now, we'll need to fix this.

Thanks a lot. Also link preview doesn't seem to work in WhatsApp.

Also this workaround doesn't show correct results. See https://www.sp.sknetworx.at/privatenextcloud/index.php/s/TCYWa8yJ7JbRL7C

The original Link https://lbry.tv/@KulturstudioTV#c/TROJANER#6

Hi! Can you please show me what the link should look like?
Thanks!
Mit freundlichen Grüßen / Best Regards
Stefan Pirker
Am Mo., 8. Feb. 2021 um 19:47 Uhr schrieb Thomas Zarebczan <
<EMAIL_ADDRESS>
Thank you, this is a bug with the urls themselves. You can try replacing #
with : manually to make it work for now, we'll need to fix this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-android/issues/1126#issuecomment-775361532,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKNNJ4QELHRCPXLATILKDLS6AWUPANCNFSM4WSWY7BA
.


Visualization now support simulator extensions

Fix #732
This JSON representation was generated through parsing and then, unrolling a QASM. The QASM unroller does not support simulator extensions.
According to https://github.com/Qiskit/qiskit-terra/issues/732#issuecomment-419221482, the DAGUnroller does support extensions so the DAGUnroller is uses instead of the QASM one.
But the DAGUnroller extended all the composite gates when parsing a circuit, which is not desired for circuit representation. A new flag is added to the DAG constructor for avoiding expanding composite gates.

Do you believe there will ever be a case where it is desired to expand the composite gates to give the user an explicit view of the underlying circuit?

Sure and I think this should be the consequence of user-controlled transformation, I mean, my ideal workflow would be:

You design a circuit:

a = QuantumCircuit(...)
a.swap()
plot_circuit(a)

You want to see how it would look like if executed in a specific backend:

compiled_a = compile(a, backend='ibmq_device')
plot_circuit(compiled_a)


[SPARK-44265][SQL] Built-in XML data source support

What changes were proposed in this pull request?
XML is a widely used data format. An external spark-xml package (https://github.com/databricks/spark-xml) is available to read and write XML data in spark. Making spark-xml built-in will provide a better user experience for Spark SQL and structured streaming. The proposal is to inline code from spark-xml package.
The PR has 4 main commits:
i) The first commit is just a vanilla copy of spark-xml src files to spark/connector
ii) The second commit fixes scala format issues and update/add ASF license to relevant files.
iii) Add mvn dependencies, etc.
iv) Use SharedSparkSession and testFiles to access resource files in the XML unit tests under all environment (sbt, mvn, IntelliJ).
Why are the changes needed?
Built-in support for XML data source would provide better user experience than having to import an external package.
Does this PR introduce any user-facing change?
Yes, Add built-in support for XML data source.
How was this patch tested?
Tested the new unit-tests that came with the imported spark-xml package.
Also ran ./dev/run-test

@HyukjinKwon

This would need an SPIP.

This would need an SPIP.

SPIP link
JIRA
Discussion Thread
Vote thread

Seems the test failure is flakiness. Mind retriggering https://github.com/sandip-db/spark/actions/runs/5745270542/job/15573043078 please @sandip-db ?

@sandip-db Thanks for the work!
All the new Spark connectors are under the folder https://github.com/apache/spark/tree/master/connector. I notice that there are over 100 files in this PR. Putting 100 files under the connector directory will definitely make our project structure look better.

Seems the test failure is flakiness. Mind retriggering https://github.com/sandip-db/spark/actions/runs/5745270542/job/15573043078 please @sandip-db ?

The following test (unrelated to this PR) is failing consistently. It was supposedly fixed by the Jira/PR. But its continuing to fail even after the fix. How do we get past this? @HyukjinKwon
2023-08-03T17:34:49.5298626Z [info] *** 1 TEST FAILED ***
2023-08-03T17:34:49.5412181Z [error] Failed: Total 9521, Failed 1, Errors 0, Passed 9520, Ignored 27
2023-08-03T17:34:49.5674077Z [error] Failed tests:
2023-08-03T17:34:49.5674974Z [error]    org.apache.spark.sql.execution.QueryExecutionSuite
StackTrace:
2023-08-03T17:07:15.5739831Z [info] - Logging plan changes for execution *** FAILED *** (11 milliseconds)
2023-08-03T17:07:15.5740917Z [info]   testAppender.loggingEvents.exists(((x$10: org.apache.logging.log4j.core.LogEvent) => x$10.getMessage().getFormattedMessage().contains(expectedMsg))) was false (QueryExecutionSuite.scala:233)
2023-08-03T17:07:15.5741729Z [info]   org.scalatest.exceptions.TestFailedException:
2023-08-03T17:07:15.5742406Z [info]   at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
2023-08-03T17:07:15.5743140Z [info]   at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
2023-08-03T17:07:15.5743968Z [info]   at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
2023-08-03T17:07:15.5744873Z [info]   at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
2023-08-03T17:07:15.5745601Z [info]   at org.apache.spark.sql.execution.QueryExecutionSuite.$anonfun$new$34(QueryExecutionSuite.scala:233)
2023-08-03T17:07:15.5746281Z [info]   at scala.collection.immutable.List.foreach(List.scala:431)
2023-08-03T17:07:15.5746979Z [info]   at org.apache.spark.sql.execution.QueryExecutionSuite.$anonfun$new$31(QueryExecutionSuite.scala:232)

@sandip-db would you mind adding some comments about what's new codes (e.g., pom.xml)? Then I think it'd be much easier to merge since most of the codes are already exiting one.
I took a cursory look, and it seems pretty fine to me.

@sandip-db would you mind adding some comments about what's new codes (e.g., pom.xml)? Then I think it'd be much easier to merge since most of the codes are already exiting one.
I took a cursory look, and it seems pretty fine to me.

Hi @HyukjinKwon and reviewers,
As indicated in the description, there is very little new code in this PR. Most of it is picked up from spark-xml package.
The first commit is the vanilla copy of spark-xml with license and scala style fixes.
Reviewers should focus only on the new code in other commits, which doesn't change any functionality. These changes addresses the dependencies and test issues.

I think I'd prefer to merge this first, and address them as a followup so other people can work together. I will review one more time tmr but would be great if others can review this too.

Merged to master.

@sandip-db I would appreciate if you create sub-tasks JIRAs based on my comments when you find some time.


v8.1 critical dependancy errors

Upon usage of the new release v8.1, Gradle was unable to build the app successfully due to missing dependancies on the server end.
These files upon visiting their respective links report 404 Not Found.
This could be a simple release timing error that will fix very shortly, but just reporting this issue just in case. Thanks.
Snippet of Gradle error message:
FAILURE: Build completed with 9 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':TeamCode:checkDebugAarMetadata'.
> Could not resolve all files for configuration ':TeamCode:debugRuntimeClasspath'.
   > Could not find org.firstinspires.ftc:Inspection:8.1.0.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/firstinspires/ftc/Inspection/8.1.0/Inspection-8.1.0.pom
       - https://dl.google.com/dl/android/maven2/org/firstinspires/ftc/Inspection/8.1.0/Inspection-8.1.0.pom
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/Inspection-8.1.0.jar
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/Inspection.jar
     Required by:
         project :TeamCode
         project :TeamCode > project :FtcRobotController
   > Could not find org.firstinspires.ftc:Blocks:8.1.0.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/firstinspires/ftc/Blocks/8.1.0/Blocks-8.1.0.pom
       - https://dl.google.com/dl/android/maven2/org/firstinspires/ftc/Blocks/8.1.0/Blocks-8.1.0.pom
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/Blocks-8.1.0.jar
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/Blocks.jar
     Required by:
         project :TeamCode
         project :TeamCode > project :FtcRobotController
   > Could not find org.firstinspires.ftc:Tfod:8.1.0.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/firstinspires/ftc/Tfod/8.1.0/Tfod-8.1.0.pom
       - https://dl.google.com/dl/android/maven2/org/firstinspires/ftc/Tfod/8.1.0/Tfod-8.1.0.pom
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/Tfod-8.1.0.jar
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/Tfod.jar
     Required by:
         project :TeamCode
         project :TeamCode > project :FtcRobotController
   > Could not find org.firstinspires.ftc:RobotCore:8.1.0.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/firstinspires/ftc/RobotCore/8.1.0/RobotCore-8.1.0.pom
       - https://dl.google.com/dl/android/maven2/org/firstinspires/ftc/RobotCore/8.1.0/RobotCore-8.1.0.pom
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/RobotCore-8.1.0.jar
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/RobotCore.jar
     Required by:
         project :TeamCode
         project :TeamCode > project :FtcRobotController
   > Could not find org.firstinspires.ftc:RobotServer:8.1.0.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/firstinspires/ftc/RobotServer/8.1.0/RobotServer-8.1.0.pom
       - https://dl.google.com/dl/android/maven2/org/firstinspires/ftc/RobotServer/8.1.0/RobotServer-8.1.0.pom
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/RobotServer-8.1.0.jar
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/RobotServer.jar
     Required by:
         project :TeamCode
         project :TeamCode > project :FtcRobotController
   > Could not find org.firstinspires.ftc:OnBotJava:8.1.0.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/firstinspires/ftc/OnBotJava/8.1.0/OnBotJava-8.1.0.pom
       - https://dl.google.com/dl/android/maven2/org/firstinspires/ftc/OnBotJava/8.1.0/OnBotJava-8.1.0.pom
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/OnBotJava-8.1.0.jar
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/OnBotJava.jar
     Required by:
         project :TeamCode
         project :TeamCode > project :FtcRobotController
   > Could not find org.firstinspires.ftc:Hardware:8.1.0.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/firstinspires/ftc/Hardware/8.1.0/Hardware-8.1.0.pom
       - https://dl.google.com/dl/android/maven2/org/firstinspires/ftc/Hardware/8.1.0/Hardware-8.1.0.pom
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/Hardware-8.1.0.jar
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/Hardware.jar
     Required by:
         project :TeamCode
         project :TeamCode > project :FtcRobotController
   > Could not find org.firstinspires.ftc:FtcCommon:8.1.0.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/firstinspires/ftc/FtcCommon/8.1.0/FtcCommon-8.1.0.pom
       - https://dl.google.com/dl/android/maven2/org/firstinspires/ftc/FtcCommon/8.1.0/FtcCommon-8.1.0.pom
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/FtcCommon-8.1.0.jar
       - file:/C:/Users/user/StudioProjects/BunyipsFTC/libs/FtcCommon.jar
     Required by:
         project :TeamCode
         project :TeamCode > project :FtcRobotController

Oh my.    I forgot to push the release button on the staged 8.1.0 repositories on sonatype/maven.
I did a sanity build after pushing 8.1 here and of course it was successful because gradle cached the 8.1 artifacts on my local machine and so I didn't realize that I forgotten to push the release button.
So sorry folks.  That should be fixed momentarily.

Looks like it's there now, and an invalidate caches and rebuild was successful, which forces a pull of a new set of artifacts from maven, on my laptop
https://repo1.maven.org/maven2/org/firstinspires/ftc/RobotCore/8.1.0/
Again, sorry for the churn.

Thanks, better late then never. 😊


FieldBuilderColorPicker - Allowing specific colors to be picked

What you'd like to happen:
I want to make it such a way that, the user is only allowed to pick from 3 or 4 pre-defined color blocks
Something similar to the ColorPickerType.blockPicker, but only with the few colors of my choosing.

Hi @dean-pearce!
I see that with option blockPicker, can add a property availableColors. I think that is this that you need.
If you can open a PR to include this, will be awesome. Thanks!


[ceph] Another filter for 'ceph report'

Older sosreports may have the extra 'report' line as
the first line of 'ceph report' which makes it an invalid
json file. Added a filter that removes the first line if
it starts with 'report'.
Fixes: #353
Signed-off-by: Ponnuvel Palaniyappan<EMAIL_ADDRESS>

Noticed the same 'first line' <-> 'last line' swap in few other files too. So extended it a bit.

@pponnuvel ignore my comment. I thought strip() will remove substrings but the function takes characters and strip the characters.  I am thinking if you can do substring and indexing to remove first or last line which will avoid creating temporary file.


[07_uart_chainloader] Make chainboot only works if I power my RPi3 after status [MP] ✅ Connected

Hi,
I encountered quite a weird issue in 07_uart_chainloader. After starting make chainboot, I never got the desired output
[MP] ✅ Connected
 __  __ _      _ _                 _
|  \/  (_)_ _ (_) |   ___  __ _ __| |
| |\/| | | ' \| | |__/ _ \/ _` / _` |
|_|  |_|_|_||_|_|____\___/\__,_\__,_|

           Raspberry Pi 3

[ML] Requesting binary
[MP] ⏩ Pushing 6 KiB ==========================================🦀 100% 0 KiB/s Time: 00:00:00
[ML] Loaded! Executing the payload now

[0] Booting on: Raspberry Pi 3
[1] Drivers loaded:
      1. BCM GPIO
      2. BCM PL011 UART
[2] Chars written: 93
[3] Echoing input now

Instead, I frequently got one of the following outputs:
[MP] ✅ Connected

[MP] ⚡ Protocol Error: Remove and insert the USB serial again

[MP] ✅ Connected
?? $Error ? ?$Error ?
[MP] ⚡ Protocol Error: Remove and insert the USB serial again

[MP] ✅ Connected
ting the payload now

[ML] Loaded! Executing the payload now

[ML] Loaded! Executing the payload now

[ML] Loaded! Executing the payload now

<repeats until I stop>

[MP] Bye 👋

[MP] ✅ Connected
?????????????????????????????????????????????????????????????????????????????????????
?????????????????????????????????????????????????????????????????????????????????????
?????????????????????????????????????????????????????????????????????????????????????

<repeats until I stop>

[MP] Bye 👋

After several hours I finally figured out how to work around the issue:

If I power my RPi3 like described in the wiring diagram, I always get the issues I described above
If I power my RPi3 via micro-usb, I mostly get the issues described above, but sometimes it works.

It always works if I do it like this:

make chainboot
Plug in my USB serial cable without using the red +5V wire (I linked the cable I use, in case this is important)
Wait until [MP] ✅ Connected gets displayed
Use micro-usb to power the RPi3.

I don't really understand the issue in detail, but to me it seems like it's somehow connected to timings/delays. The only place in the code I could find that directly influences said timings/delays is const DELAY: usize = 2000 in src/bsp/device_driver/bcm/bcm2xxx_gpio.rs. I tried some values here and if I set it to const DELAY: usize = 20000, it also works sometimes (but at this point I have no clue if the change really reduces my error rate, or if it just happened by chance and led me to wrong conclusions).
Do you have any idea what really causes the error? If so, I would appreciate if you could provide a little write-up what is happening on the lower levels and what causes the error I got. Since chasing this down took more than half of my day but I still didn't really understand it, I'm quite curious now 😄

Hi, sorry for the inconvenience!
Unfortunately, it is hard to exactly tell where it goes wrong.
Due to the fact that it always works when you power the RaspberryPi through Micro-USB, the best bet is that your USB-Serial cable is not able to provide enough power to the RaspberryPi. In this case, anything can happen.
If it is not the serial cable that is the bottleneck, maybe its the USB port. You could try different USB ports if that changes something.
Anyways, your message makes me realize that with different people using different serial cables and computers, assuming that powering over the serial works for everyone doesn't scale. It is convenient, that's why I went for it originally, but it was clear that underpowering can be an issue.
I'll take an action item to change the tutorials so that they demand the Pi being powered with an officially supported external power supply. This will also require changes to the chainloader protocol.
But please don't wait for me, I hope to get it done during the upcoming holidays.
FYI, delays on the host-side are in the Minipush and Miniterm scripts (but I don't think they are the issue here):

https://github.com/rust-embedded/rust-raspberrypi-OS-tutorials/blob/master/utils/miniterm.rb#L40
https://github.com/rust-embedded/rust-raspberrypi-OS-tutorials/blob/master/utils/minipush.rb#L30

Thank you so much for the quick answer and insightful answer! I certainly did not consider power to be an issue (very new to low level programming / interacting with hardware, so lots to learn).
Already checked the Scripts out earlier, because I wanted to understand the chainload protocol. So I tried to use CoolTerm and sending everything manually. Was quite interesting and certainly helped my understanding of what is going on, but didn't work in the end.
Since you mentioned it, enjoy your holidays! 😄


How to run docker on windows

Notice there is docs for Ubuntu and Mac.  Is there any docs for installing docker on Windows 10?

@marcnoon https://docs.docker.com/docker-for-windows/install/
Did you mean HAProxy? (https://github.com/EOSIO/eosio-webauthn-example-app#prerequisites)
HAProxy is just a suggestion, but you can use any proxy server or any other tool that allows HTTPS requests through and then update https://github.com/EOSIO/eosio-webauthn-example-app/blob/master/scripts/start.sh#L3 + https://github.com/EOSIO/eosio-webauthn-example-app/blob/0d037e4cf84b828f25ea52a1291a2f9b4fca2a97/scripts/stop.sh#L3 accordingly.


TeachingTip throws exception when calling isOpen

Describe the bug
Defining a TeachingTip in XAML markup and setting the isOpen property will cause the app to crash after throwing a Microsoft C++ exception: winrt::hresult_error at memory location 0x0000001B01A7DF90. Since this is definitely a low level error, it requires certain debug symbols for the Microsoft.UI.Xaml.dll module that are not present on my machine, even after loading all symbols.
Steps to reproduce the bug

Steps to reproduce the behavior:

Define any type of TeachingTip in XAML (doesn't matter if bleeding image is present or not)
Set the isOpen property from the XAML or C# source to true
Build, Deploy, and Launch the app
Navigate to the appropriate page which has the TeachingTip defined

Expected behavior

The TeachingTip should appear, and the application should not crash, nor throw any exceptions related to this control.
Screenshots

Version Info

Please Note: Both target SDK versions tested (1809 and Insider build 18327) seemed to demonstrate this bug.
NuGet package version:

Windows 10 version
Saw the problem?

Insider Build (18342)
Yes

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Anniversary Update (14393)

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

Additional context
Creating a reproduction project with nothing except a button and the teaching tip attached to it had the same problem. Furthermore, I understand that this is a pre-release control, so I don't expect it to be working at all. I just wanted to ensure this bug is evaluated before the control is released to stable.

Thanks for the report! The missing symbols is something that was broken for this build which I've corrected for future builds, but I did go back and try to re-publish symbols for this prerelease. Hopefully that will be working by the end of today.
As for the crash you're seeing, @StephenLPeters can you please take a look when you're back tomorrow?

@duke7553 look like symbols are published now, could you try resolving symbols and getting a crash stack now? Thanks!

@jevansaks I just tried to resolve the symbols, and everything went fine until I received an error related to base.h not being found.

In case it helps you, this file not found error may be related to what is described above. I did successfully attempt to change the SDK of my project to 19h1, but still couldn't resolve symbols.

Could you copy/paste the text from the Callstack window? Some of the files (like base.h) are from generated files and therefore aren't possible to source index since they don't live in GitHub.

This is everything I found in the call stack window
 	[External Code]
>	Microsoft.UI.Xaml.dll!winrt::throw_hresult(const winrt::hresult result) Line 4567	C++
 	[Inline Frame] Microsoft.UI.Xaml.dll!winrt::check_hresult(winrt::hresult) Line 4612	C++
 	Microsoft.UI.Xaml.dll!winrt::impl::consume_Windows_UI_Xaml_IVisualStateManagerStatics<winrt::Windows::UI::Xaml::IVisualStateManagerStatics>::GoToState(const winrt::Windows::UI::Xaml::Controls::Control & control, const winrt::param::hstring & stateName, bool useTransitions) Line 5153	C++
 	[Inline Frame] Microsoft.UI.Xaml.dll!winrt::Windows::UI::Xaml::VisualStateManager::GoToState::__l2::<lambda_9e66308770f1fce86491830749545e52>::operator()(const winrt::Windows::UI::Xaml::IVisualStateManagerStatics &) Line 17653	C++
 	[Inline Frame] Microsoft.UI.Xaml.dll!winrt::impl::factory_cache_entry<winrt::Windows::UI::Xaml::VisualStateManager,winrt::Windows::UI::Xaml::IVisualStateManagerStatics>::call(winrt::Windows::UI::Xaml::VisualStateManager::GoToState::__l2::<lambda_9e66308770f1fce86491830749545e52> &) Line 7403	C++
 	Microsoft.UI.Xaml.dll!winrt::impl::call_factory<winrt::Windows::UI::Xaml::VisualStateManager,winrt::Windows::UI::Xaml::IVisualStateManagerStatics,<lambda_9e66308770f1fce86491830749545e52> >(winrt::Windows::UI::Xaml::VisualStateManager::GoToState::__l2::<lambda_9e66308770f1fce86491830749545e52> && callback) Line 7496	C++
 	[Inline Frame] Microsoft.UI.Xaml.dll!winrt::Windows::UI::Xaml::VisualStateManager::GoToState(const winrt::Windows::UI::Xaml::Controls::Control & useTransitions, const winrt::param::hstring &) Line 17653	C++
 	Microsoft.UI.Xaml.dll!TeachingTip::OnIconSourceChanged() Line 772	C++
 	Microsoft.UI.Xaml.dll!TeachingTip::OnApplyTemplate() Line 91	C++
 	Microsoft.UI.Xaml.dll!winrt::impl::produce<TeachingTip,winrt::Windows::UI::Xaml::IFrameworkElementOverrides>::OnApplyTemplate() Line 10255	C++
 	[External Code]

Thanks! We'll investigate.

@duke7553, I know in the earlier version of the control there is a bug that causes the tip to crash if it does not contain fields for an icon and hero (formerly "bleeding") content. It is something that should be fixed in the updated version. But to help you where you're at, I've included the code from my working branch of the XAML Sample Gallery below. Does adding the IconSource and BleedingImageContent fix it for you?
.xaml
            <Button Content="Save" Click="SaveButtonClick1">
                <muxc:TeachingTip.Attach>
                    <muxc:TeachingTip x:Name="AutoSaveTip1"
                        Title="Saving automatically"
                        Subtext="We save your changes as you go - so you never have to.">
                        <muxc:TeachingTip.IconSource>
                            <muxc:SymbolIconSource Symbol="Save"/>
                        </muxc:TeachingTip.IconSource>
                        <muxc:TeachingTip.BleedingImageContent>
                            <Grid/>
                        </muxc:TeachingTip.BleedingImageContent>
                    </muxc:TeachingTip>
                </muxc:TeachingTip.Attach>
                <Button.Resources></Button.Resources>
            </Button>

.cs
    private void SaveButtonClick1(object sender, RoutedEventArgs e)
    {
        AutoSaveTip1.IsOpen = true;
    }

If not, it will require @StephenLPeters to help us look into it.

@duke7553 I've done some digging and found this issue, it is a bug in teaching tip and we are very grateful for your help finding it.  If you need a work around right now you can either set an Icon on your teaching tip, or, because of a very strange quirk in this bug, run your app without a debugger attached.
This is actually why this bug escaped us, the crash will only occur while a debugger is attached and the tip has no icon, all of our tests run without a debugger by default and our manual verification included an icon.
I'll be submitting a fix for this shortly. Thanks again!

@StephenLPeters I tried the workaround to add an IconSource and start without a debugger, but one of two things happen:

If IsOpen is set from source code, it does not display at all, but no crash.
If IsOpen is set from markup, it crashes with a similar error as last time.

Not sure if your PR fixes this, but I thought I should report it.

Thanks for the extra details, we'll make sure we try both of those scenarios ASAP.

@StephenLPeters Once you've verified that this is fixed, please close.

@StephenLPeters The TeachingTip is now able to display when IsOpen is called from non-markup code. I'll close this issue.


Support Material You themed icons

Avoid duplicates

[X] This enhancement request has not already been raised before
[X] Enhancement request is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in CWA-Wishlist
[x] If you are proposing a new feature, please do so in CWA-Wishlist

Current Implementation

The default CWA icon is shown on the home screen
Suggested Enhancement

When themed icons are activated, a themed version should be displayed.
<adaptive-icon>
  ...
  <monochrome android:drawable=""/>
  ...
</adaptive-icon>

Expected Benefits

Improves the overall UX for users of Material You. Should not be too difficult to implement, but is of course of low priority

Related issue: https://github.com/corona-warn-app/cwa-app-android/issues/5118

@thoweber

Are you are referring to Themed app icons available with Android 13 beta?

You mentioned also Material You, which is equivalent to Material Design 3. For Material You there are some comments in https://github.com/corona-warn-app/cwa-app-android/issues/5119 concerning what was implemented for CWA Android 2.21.

@MikeMcC399 yes, I am referring to themed app icons only, as the design team already decided against using color themes in the app

@thoweber
I guess this might also mean that CWA would need to explicitly support Android 13. https://developer.android.com/about/versions/13 says: "Beta 4 is the last update before the official Android 13 release, coming in the weeks ahead."

@MikeMcC399
This will only work with Android 13 and up, but as far as I have understood things, it is a matter of amending the app's adaptive icons (CWA has already defined adaptive icons in [https://github.com/corona-warn-app/cwa-app-android/tree/main/Corona-Warn-App/src/main/res/mipmap-anydpi-v26])...
But I am not an Android dev though
https://developer.android.com/about/versions/13/features#themed-app-icon-specs

Dependent on enhancement request https://github.com/corona-warn-app/cwa-app-android/issues/5469

Please see https://github.com/corona-warn-app/cwa-app-android/issues/5469#issuecomment-1371936091


Use returned values from super calls as 'this'

This PR fixes #7574.
In ES2015, constructors which return a value (which is an object) implicitly substitute the value of this for any callers of super(). As a result, it is necessary to capture any potential return value of super() and replace it with this.
Some remaining work might be to do some refactoring on the emit code.
I'd suggest reading one commit at a time.

Awesome work!
I have verified, that with this branch of TypeScript, I can now in fact create CustomElements entirely in TypeScript. Thank You
FYI: @justinfagnani @treshugart

Will this be merged into master before the end of september?

It's possible, but we'll need to get some eyes on this. @rbuckton and @mhegazy.

Looks like derivedClassConstructorWithExplicitReturns01, a new test, got its baselines added but not the test itself. (I don't think our test harness gives an error for this right now.)

I don't think our test harness gives an error for this right now.

@sandersn how have we been operating like this?
In any case, it looks like GitHub just has a limitation and might not be showing that file. I seem to have it  locally.

It's only been since we made the tests run faster by not writing output for passing tests.
I have the PR open in codeflow too or I would not have noticed the missing file at all. But maybe it's missing at the API level, not just the UI level.

@sandersn are you sure you don't see a tests/cases/compiler/derivedClassConstructorWithExplicitReturns01.ts?

When I check out the branch myself I see it, but I don't find it in the github list of files either. I guess it's a limitation of github proper, not just its UI.

@DanielRosenwasser after the removal of useCapturedThis did you see any changes in the test results?

@rbuckton nope, no changes.

Thanks @rbuckton & @sandersn!


[SEDONA-80] Geospatial stream processing support in Flink Table API

Is this PR related to a proposed Issue?
https://issues.apache.org/jira/browse/SEDONA-80
What changes were proposed in this PR?
Add the basic support for Apache Flink
This PR is compiled against Flink Table API 14.3, but it has been tested on Flink Table API 12 and 13 (both with Blink planner) manually.
We might need to add the CI for all recent Flink versions including 12, 13, and 14
How was this patch tested?
Added a number of unit tests
Did this PR include necessary documentation updates?
Will be added as a separate PR

@Imbruced This is the Sedona Flink support. I just pushed several basic operators and tried to re-use some functions in Sedona-core. I believe this will be a good start so others who are interested in Flink can contribute more funcs to this.
A doc PR will be published soon. But to give you an overview, this is the functions I added: https://github.com/apache/incubator-sedona/pull/575/files#diff-bcb3952f695c0b65fc27f9e7f30d5d365950823c326504fe0d55fa933bf81471

@jiayuasu What is better approach, create new package for python flink ? or add the code to exisitng one to python/sedona but create new sub module ?

@Imbruced Is there any Sedona python code can be shared between Sedona Spark and SedonaFlink? E.g., the shapely binding of geometry objects?
Then for Python, we probably could have 1. apache-sedona-core, then 2. apache-sedona-spark and 3. apache-sedona-flink.
2 and 3 will use 1 as a required library.

@jiayuasu For geometry objects at the moment logic is simple (wkb.loads). When I have some working example will let you know about possibilites and then we will decide. WDYT ?

@Imbruced Sounds good to me! I will merge the Java API first.


⚠ HDBits has degraded performance

In 0b4bc8e, HDBits ($HDB) experienced degraded performance:

HTTP code: 200
Response time: 4301 ms

Resolved: HDBits performance has improved in 0813ecd after 6 minutes.


Once Account Is Created, Cannot Go Back and Alter Its Settings

Expected behavior
I want to go back to my account settings and change the incoming and outgoing servers, so that it'll recognize my E-Mail and start drawing messages in, like it should.
Actual behavior
I cannot find a means to enter the settings and servers of my E-Mail. To do this, I have to uninstal the K-9 E-Mail App and reinstall it using the setup wizard.
Steps to reproduce

Open K-9
Account Settings or Global Settings
Notice the lack of E-Mail server settings

Environment
K-9 Mail version: Newest
Android version: Samsung Android LG GVISTA2
Account type (IMAP, POP3, WebDAV/Exchange): IMAP

https://github.com/k9mail/k-9/wiki/Manual-accountsettings
In the future please use the mailing list for support requests.


Edge features: support edge features in HinSAGE

Description
Similar to #1328, HinSAGE explicitly traverses edges to select neighbours, so we can include edge features for those selected edges, similar to how it includes node features for the selected nodes.
(#1326)

is anyone working on this issue? if yes, what's the ETA?

I don't know of anyone actively working on this, sorry.


Error while creating conda environment

I recently built a manjaro machine with a GTX 1070 to try and compile the DAIN-APP from scratch and fix the memory leak issue.
I added pytorch to my channels
conda config --append channels pytorch
Then I tried creating the conda environment,
conda create --name DAIN-APP --file requirements.txt
And now I am only missing one package:
Collecting package metadata (current_repodata.json): done
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: failed

PackagesNotFoundError: The following packages are not available from current channels:

  - mindepthflowprojection-cuda==0.0.0=pypi_0

Current channels:

  - https://repo.anaconda.com/pkgs/main/linux-64
  - https://repo.anaconda.com/pkgs/main/noarch
  - https://repo.anaconda.com/pkgs/r/linux-64
  - https://repo.anaconda.com/pkgs/r/noarch
  - https://conda.anaconda.org/conda-forge/linux-64
  - https://conda.anaconda.org/conda-forge/noarch
  - https://conda.anaconda.org/pytorch/linux-64
  - https://conda.anaconda.org/pytorch/noarch

To search for alternate channels that may provide the conda package you're
looking for, navigate to

    https://anaconda.org

and use the search bar at the top of the page.

What is this package, and where do I find it? Do I even need it? Do I remove it from the requirements.txt and attempt a compile?
I can't seem to find it anywhere, and a quick google search doesn't really seem to turn up much either.
https://github.com/BurguerJohn/Dain-App/blob/ebd4f22ffd97df6560acc2b59b22ef15ac1945ee/requirements.txt#L34

I ran into similar problems.

Commented out requirements.txt #mindepthflowprojection-cuda=0.0.0=pypi_0
All of the pytorch>1.4.0 was CPU conda search -f pytorch
Tried commenting out torch in the requirements.txt and then installing after the fact (and activating DAIN-APP) with conda install pytorch torchvision torchaudio cudatoolkit=11.3 -c pytorch
That isn't allowed, it conflicts with the other reqs.

Open to suggestions!


Remove javascript scrollbar library, use hover appearing scrollbar instead

Removes the tse-scrollbar library. Makes the channel list and user list only have scrollbar visible when hovering over the container.
This library was used in the channel list only, it is sometimes quite laggy on mobile.

I think there were some issues discussed on the channel, but if we end up being able to get rid of that plugin, that's really cool! 🎉
Will review when I get some free time.

I like that, works really well! Good job 👍
Styling could be a bit better (at least color match the old tse one and a transition), but that can go with another PR.

One minor comment (disabling the display-on-hover) and then I'll be +1 on that PR :-)

@astorije That's not exactly minor. Windows scrollbars are ugly in all browsers (except Chrome where we style them), and I'm sure users would want to get rid of them.

Right, I understand. However, I believe this should be a recipe in the CSS Mods page because, as it is in this PR, it contradicts OS settings in OSes that offer system-wide control of the scrollbars.

@astorije I've removed the hover stuff.

Great @xPaw, 👍!
Glad we can get rid of an in-repo library 😄


MacOS not working

I tried using a copy of MacOS os 10.4 Intel but it chrashed 20 seconds in with this error "Debugger called: "

Dude, it's a known issue.
https://github.com/copy/v86/issues/762
[https://opengraph.githubassets.com/f30ba73a5211f0341e84170738ecd0e5ddbedd3cb76a6da1f5ed10400a6aa4e4/copy/v86/issues/762]https://github.com/copy/v86/issues/762
Booting up vintage Hackintosh DVDs (JaS OS, iDeneb) in COPY V86 kernel panics · Issue #762 · copy/v86https://github.com/copy/v86/issues/762
github.com

From: corped12 @.>
Sent: Wednesday, May 1, 2024 2:33 AM
To: copy/v86 @.>
Cc: Subscribed @.***>
Subject: [copy/v86] MacOS not working (Issue #1028)
I tried using a copy of MacOS os 10.4 Intel but it chrashed 20 seconds in with this error "Debugger called: "
Screenshot.2024-04-<IP_ADDRESS>.PM.png (view on web)https://github.com/copy/v86/assets/161154933/c23cbc75-c831-4041-93c5-743c2bb1f435
—
Reply to this email directly, view it on GitHubhttps://github.com/copy/v86/issues/1028, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQQXXR2WPI62WBIJXORVZ7DZAAZ45AVCNFSM6AAAAABHBGVCZWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TENZRGEZDEOI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>