[DOC] Jaeger docker compose sample does not work

What do you want to do?

[ ] Request a change to existing documentation
[ ] Add new documentation
[x] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
Can I confirm do the docker compose file in Analyzing Jaeger trace data correct?
I used it to build the jaeger and opensearch, but nothing found in the opensearch.
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
When I click a button in the front end, the log that I got.
hotrod_1                 | 2023-04-03T07:39:27.245Z	INFO	frontend/server.go:96	HTTP request received	{"service": "frontend", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "method": "GET", "url": "/dispatch?customer=731&nonse=0.6673401970254771"}
hotrod_1                 | 2023-04-03T07:39:27.245Z	INFO	customer/client.go:54	Getting customer	{"service": "frontend", "component": "customer_client", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "customer_id": "731"}
hotrod_1                 | 2023-04-03T07:39:27.246Z	INFO	customer/server.go:67	HTTP request received	{"service": "customer", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "5d31d0b8377b635a", "method": "GET", "url": "/customer?customer=731"}
hotrod_1                 | 2023-04-03T07:39:27.246Z	INFO	customer/database.go:73	Loading customer	{"service": "customer", "component": "mysql", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "5d31d0b8377b635a", "customer_id": "731"}
hotrod_1                 | 2023-04-03T07:39:27.507Z	INFO	frontend/best_eta.go:77	Found customer	{"service": "frontend", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "customer": {"ID":"731","Name":"Japanese Desserts","Location":"728,326"}}
hotrod_1                 | 2023-04-03T07:39:27.507Z	INFO	driver/client.go:59	Finding nearest drivers	{"service": "frontend", "component": "driver_client", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "location": "728,326"}
hotrod_1                 | 2023-04-03T07:39:27.508Z	INFO	driver/server.go:75	Searching for nearby drivers	{"service": "driver", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "50f48e6caaee8e11", "location": "728,326"}
hotrod_1                 | 2023-04-03T07:39:27.529Z	INFO	driver/redis.go:67	Found drivers	{"service": "driver", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "cafa25f3b5d06559", "drivers": ["T794430C", "T795935C", "T765051C", "T720419C", "T765265C", "T736253C", "T718616C", "T731653C", "T775351C", "T785923C"]}
hotrod_1                 | 2023-04-03T07:39:27.564Z	ERROR	driver/redis.go:86	redis timeout	{"service": "driver", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "0bb4b59de57eef30", "driver_id": "T794430C", "error": "redis timeout"}
hotrod_1                 | 2023-04-03T07:39:27.564Z	ERROR	driver/server.go:87	Retrying GetDriver after error	{"service": "driver", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "50f48e6caaee8e11", "retry_no": 1, "error": "redis timeout"}
hotrod_1                 | 2023-04-03T07:39:27.640Z	ERROR	driver/redis.go:86	redis timeout	{"service": "driver", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "2e06cc550a83e84e", "driver_id": "T765265C", "error": "redis timeout"}
hotrod_1                 | 2023-04-03T07:39:27.640Z	ERROR	driver/server.go:87	Retrying GetDriver after error	{"service": "driver", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "50f48e6caaee8e11", "retry_no": 1, "error": "redis timeout"}
hotrod_1                 | 2023-04-03T07:39:27.709Z	ERROR	driver/redis.go:86	redis timeout	{"service": "driver", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "6226cd21148b7c69", "driver_id": "T775351C", "error": "redis timeout"}
hotrod_1                 | 2023-04-03T07:39:27.709Z	ERROR	driver/server.go:87	Retrying GetDriver after error	{"service": "driver", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "50f48e6caaee8e11", "retry_no": 1, "error": "redis timeout"}
hotrod_1                 | 2023-04-03T07:39:27.731Z	INFO	driver/server.go:98	Search successful	{"service": "driver", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "50f48e6caaee8e11", "num_drivers": 10}
hotrod_1                 | 2023-04-03T07:39:27.732Z	INFO	frontend/best_eta.go:87	Found drivers	{"service": "frontend", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "drivers": [{"DriverID":"T794430C","Location":"638,10"},{"DriverID":"T795935C","Location":"75,810"},{"DriverID":"T765051C","Location":"972,982"},{"DriverID":"T720419C","Location":"841,427"},{"DriverID":"T765265C","Location":"826,579"},{"DriverID":"T736253C","Location":"530,836"},{"DriverID":"T718616C","Location":"350,336"},{"DriverID":"T731653C","Location":"286,23"},{"DriverID":"T775351C","Location":"565,809"},{"DriverID":"T785923C","Location":"649,34"}]}
hotrod_1                 | 2023-04-03T07:39:27.733Z	INFO	route/client.go:54	Finding route	{"service": "frontend", "component": "route_client", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "pickup": "972,982", "dropoff": "728,326"}
hotrod_1                 | 2023-04-03T07:39:27.733Z	INFO	route/client.go:54	Finding route	{"service": "frontend", "component": "route_client", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "pickup": "638,10", "dropoff": "728,326"}
hotrod_1                 | 2023-04-03T07:39:27.733Z	INFO	route/client.go:54	Finding route	{"service": "frontend", "component": "route_client", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "pickup": "75,810", "dropoff": "728,326"}
hotrod_1                 | 2023-04-03T07:39:27.734Z	INFO	route/server.go:71	HTTP request received	{"service": "route", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "9a11dbb8b9dbf228", "method": "GET", "url": "/route?dropoff=728%2C326&pickup=638%2C10"}
hotrod_1                 | 2023-04-03T07:39:27.734Z	INFO	route/server.go:71	HTTP request received	{"service": "route", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "628744d0d1ab3acd", "method": "GET", "url": "/route?dropoff=728%2C326&pickup=75%2C810"}
hotrod_1                 | 2023-04-03T07:39:27.734Z	INFO	route/server.go:71	HTTP request received	{"service": "route", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "2b810d0d96675619", "method": "GET", "url": "/route?dropoff=728%2C326&pickup=972%2C982"}
hotrod_1                 | 2023-04-03T07:39:27.771Z	INFO	route/client.go:54	Finding route	{"service": "frontend", "component": "route_client", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "pickup": "841,427", "dropoff": "728,326"}
hotrod_1                 | 2023-04-03T07:39:27.772Z	INFO	route/server.go:71	HTTP request received	{"service": "route", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "35db9320efb67af2", "method": "GET", "url": "/route?dropoff=728%2C326&pickup=841%2C427"}
hotrod_1                 | 2023-04-03T07:39:27.786Z	INFO	route/client.go:54	Finding route	{"service": "frontend", "component": "route_client", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "pickup": "826,579", "dropoff": "728,326"}
hotrod_1                 | 2023-04-03T07:39:27.786Z	INFO	route/client.go:54	Finding route	{"service": "frontend", "component": "route_client", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "pickup": "530,836", "dropoff": "728,326"}
hotrod_1                 | 2023-04-03T07:39:27.786Z	INFO	route/server.go:71	HTTP request received	{"service": "route", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "6915208f241831bf", "method": "GET", "url": "/route?dropoff=728%2C326&pickup=826%2C579"}
hotrod_1                 | 2023-04-03T07:39:27.787Z	INFO	route/server.go:71	HTTP request received	{"service": "route", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "97235f12e8e65347", "method": "GET", "url": "/route?dropoff=728%2C326&pickup=530%2C836"}
hotrod_1                 | 2023-04-03T07:39:27.824Z	INFO	route/client.go:54	Finding route	{"service": "frontend", "component": "route_client", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "pickup": "350,336", "dropoff": "728,326"}
hotrod_1                 | 2023-04-03T07:39:27.824Z	INFO	route/server.go:71	HTTP request received	{"service": "route", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "e1fe1ec71590e0b7", "method": "GET", "url": "/route?dropoff=728%2C326&pickup=350%2C336"}
hotrod_1                 | 2023-04-03T07:39:27.842Z	INFO	route/client.go:54	Finding route	{"service": "frontend", "component": "route_client", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "pickup": "286,23", "dropoff": "728,326"}
hotrod_1                 | 2023-04-03T07:39:27.843Z	INFO	route/server.go:71	HTTP request received	{"service": "route", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "1fa4ba6126b29251", "method": "GET", "url": "/route?dropoff=728%2C326&pickup=286%2C23"}
hotrod_1                 | 2023-04-03T07:39:27.845Z	INFO	route/client.go:54	Finding route	{"service": "frontend", "component": "route_client", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "pickup": "565,809", "dropoff": "728,326"}
hotrod_1                 | 2023-04-03T07:39:27.846Z	INFO	route/server.go:71	HTTP request received	{"service": "route", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "abfcd32ec9a64d3d", "method": "GET", "url": "/route?dropoff=728%2C326&pickup=565%2C809"}
hotrod_1                 | 2023-04-03T07:39:27.874Z	INFO	route/client.go:54	Finding route	{"service": "frontend", "component": "route_client", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "pickup": "649,34", "dropoff": "728,326"}
hotrod_1                 | 2023-04-03T07:39:27.874Z	INFO	route/server.go:71	HTTP request received	{"service": "route", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "6b60e4707b8c19cc", "method": "GET", "url": "/route?dropoff=728%2C326&pickup=649%2C34"}
hotrod_1                 | 2023-04-03T07:39:27.936Z	INFO	frontend/best_eta.go:90	Found routes	{"service": "frontend", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "routes": [{},{},{},{},{},{},{},{},{},{}]}
hotrod_1                 | 2023-04-03T07:39:27.936Z	INFO	frontend/best_eta.go:106	Dispatch successful	{"service": "frontend", "trace_id": "eec77f1d0512911341f99c63c2a0103d", "span_id": "13920ece85bc3614", "driver": "T795935C", "eta": "2m0s"}
hotrod_1                 | 2023/04/03 07:39:29 Post "http://localhost:14268/api/traces": dial tcp <IP_ADDRESS>:14268: connect: connection refused
hotrod_1                 | 2023/04/03 07:39:29 Post "http://localhost:14268/api/traces": dial tcp <IP_ADDRESS>:14268: connect: connection refused
hotrod_1                 | 2023/04/03 07:39:29 Post "http://localhost:14268/api/traces": dial tcp <IP_ADDRESS>:14268: connect: connection refused
hotrod_1                 | 2023/04/03 07:39:29 Post "http://localhost:14268/api/traces": dial tcp <IP_ADDRESS>:14268: connect: connection refused
hotrod_1                 | 2023/04/03 07:39:29 Post "http://localhost:14268/api/traces": dial tcp <IP_ADDRESS>:14268: connect: connection refused
hotrod_1                 | 2023/04/03 07:39:29 Post "http://localhost:14268/api/traces": dial tcp <IP_ADDRESS>:14268: connect: connection refused

No trace available

No related index

@livekn: Looking at the output, it seems the connection to the trace was refused on port localhost:14268. Let me see if this is an issue with the example on our end and I'll get back to you.


make ByteBuffer._Storage.fullSlice a computed property

Motivation:
ByteBuffer._Storage.fullSlice can always be trivially computed, so it
should be.
Modifications:
make ByteBuffer._Storage.fullSlice computed
Result:
saved almost 56 bits per ByteBuffer 😂

@weissi Looks like an integration test failed here, want to take a quick look?

@Lukasa thanks filed as #563 will investigate shortly.

@swift-nio-bot test this please

hit a slow node:
14:47:25 Fatal error: Posix wrapper adds more than 20% overhead (with wrapper: 0.751054048538208, without: 0.594343900680542: file /tmp/.swift-nio-syscall-wrappers-sh-test_71I49G/syscallwrapper/Sources/syscallwrapper/SystemCallWrapperHelpers.swift, line 124


Add variable declaration

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #34696

Thanks for the suggestion, that's definitely how it should have been!

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


Init vars escape issue

When backend-config is passed to a subprocess with init_vars it is not properly escaped.
Example
import tftest
import logging

logging.basicConfig(level=logging.DEBUG)

if __name__ == "__main__":
    tf = tftest.TerraformTest('.', None, "terraform")
    backend_config = {
        "bucket": "bucket_name",
        "key": "dummy.tfstate",
        "region": "us-east-1",
    }
    tf.setup(init_vars=backend_config, cleanup_on_exit=False)

Output
DEBUG:tftest:['init', ('-no-color', '-input=false', "-backend-config='bucket=bucket_name'", "-backend-config='key=dummy.tfstate'", "-backend-config='region=us-east-1'")]
CRITICAL:tftest:Error running command init: 1 Initializing modules...
Downloading git::ssh://...
...

Initializing the backend...

Error: Invalid backend configuration argument

The backend configuration argument "'bucket" given on the command line is not
expected for the selected backend type.

Error: Invalid backend configuration argument

The backend configuration argument "'key" given on the command line is not
expected for the selected backend type.

Error: Invalid backend configuration argument

The backend configuration argument "'region" given on the command line is not
expected for the selected backend type.

Traceback (most recent call last):
  File "pr.py", line 14, in <module>
    tf.setup(init_vars=backend_config, cleanup_on_exit=False)
  File "/Users/vtk/.virtualenvs/qa/lib/python3.7/site-packages/tftest.py", line 309, in setup
    return self.init(plugin_dir=plugin_dir, init_vars=init_vars, backend=backend)
  File "/Users/vtk/.virtualenvs/qa/lib/python3.7/site-packages/tftest.py", line 317, in init
    return self.execute_command('init', *cmd_args).out
  File "/Users/vtk/.virtualenvs/qa/lib/python3.7/site-packages/tftest.py", line 397, in execute_command
    raise TerraformTestError(message)
tftest.TerraformTestError: Error running command init: 1 Initializing modules...
Downloading git::ssh://...
...

Thanks for reporting this, I'll take a look as soon as possible.

Uhm, the problem here is that the specified backend args are not valid for the selected backend (local). I am pushing a test that actually runs init on a simple fixture, can you please try and break it, considering the only valid backend config k/v for local backends is path?

Sorry, I haven't mentioned that my module use s3 backend
https://www.terraform.io/docs/backends/types/s3.html
terraform {
  backend "s3" {}
}

I've thought that there is something wrong with k value as it looks strange(with a single quote at the beginning).
The backend configuration argument "'bucket" given on the command line is not
expected for the selected backend type.

This might be related to how either python/subprocess or shell interpret the combination of single and double quotes for result init command.
DEBUG:tftest:['init', ('-no-color', '-input=false', "-backend-config='bucket=bucket_name'", "-backend-config='key=dummy.tfstate'", "-backend-config='region=us-east-1'")]

For example
subprocess.run(['terraform', 'init', '-no-color', '-input=false', "-backend-config='bucket=bucket_name'", "-backend-config='key=
dummy.tfstate'", "-backend-config='region=us-east-1'"])

Output
Initializing modules...

Initializing the backend...

Error: Invalid backend configuration argument

The backend configuration argument "'bucket" given on the command line is not
expected for the selected backend type.

Error: Invalid backend configuration argument

The backend configuration argument "'key" given on the command line is not
expected for the selected backend type.

Error: Invalid backend configuration argument

The backend configuration argument "'region" given on the command line is not
expected for the selected backend type.

CompletedProcess(args=['terraform', 'init', '-no-color', '-input=false', "-backend-config='bucket=bucket_name'", "-backend-config='key=dummy.tfstate'", "-backend-config='region=us-east-1'"], returncode=1)

If single quotes removed for backend-config it works as expected.
subprocess.run(['terraform', 'init', '-no-color', '-input=false', "-backend-config=bucket=bucket_name", "-backend-config=key=dummy.tfstate", "-backend-config=region=us-east-1"])

Ah, now I understand what you mean. This is super strange as I'm not getting the same error, which puzzles me. Let me try to see what breaks if we remove the quotes.

Released as v1.5.4 can you test it and see if the issue is fixed?
https://pypi.org/project/tftest/1.5.4/

Thanks!
The issue is fixed with v1.5.4.

Thank you for identifying the issue and suggesting the fix!!!

Hello - looks like this is a bug when using gcs as the backend as well. I've had to remove the quotes.

Hello - looks like this is a bug when using gcs as the backend as well. I've had to remove the quotes.

You mean we should reopen this? Can you provide a simple repro?


cargo powdr

cargo CLI tool to generate powdr host/guest templates, install tooling, etc. Currently only does the former.
The template was copied from the latest version of https://github.com/powdr-labs/powdr-template . Should we also copy README?
It can be installed via the cmd below, and it's quite quick:
cargo install --git https://github.com/powdr-labs/powdr --branch cargo-powdr cargo-powdr

(without the branch after it's merged)
It can be used via any of these options:
$ cargo-powdr new # creates project 'my-powdr-host' with guest dir 'guest' and guest name 'my-powdr-guest'
$ cargo-powdr new host # creates project 'host' with guest dir 'guest' and guest name 'my-powdr-guest'
$ cargo-powdr new host111 --guest-name guest222 # creates project 'host111' with guest dir 'guest' and guest name 'guest222'

I guess if we merge this we can drop the template project no?

I am getting a couple of errors when doing cargo install:
error: invalid character `{` in package name: `{{PROJECT_NAME}}`, the first character must be a Unicode XID start character (most letters or `_`)
 --> ../../.cargo/git/checkouts/powdr-5ad669c296f4e377/47f65a8/cargo-powdr/template/Cargo.toml:2:8
  |
2 | name = "{{PROJECT_NAME}}"
  |        ^^^^^^^^^^^^^^^^^^
  |
error: invalid character `{` in package name: `{{GUEST_NAME}}`, the first character must be a Unicode XID start character (most letters or `_`)
 --> ../../.cargo/git/checkouts/powdr-5ad669c296f4e377/47f65a8/cargo-powdr/template/guest/Cargo.toml:2:8
  |
2 | name = "{{GUEST_NAME}}"
  |        ^^^^^^^^^^^^^^^^
  |

weird, what exactly did you run?

Fixed the comments and added README.me and rust_toolchain.toml files too to the template.

So weird, locally cargo install --git https://github.com/powdr-labs/powdr cargo-powdr --branch cargo-powdr  works for me, but on the server it doesn't.

Ok, fixed by renaming the template Cargo.toml files to Cargo.toml.template, which also works on the server. The issue is that even though those crates are not supposed to be compiled, cargo still tries to parse any Cargo.toml files found.


running ipython notebook on google cloud compute engine with a chromebook

on amazon https://gist.github.com/iamatypeofwalrus/5183133
on google cloud: https://gist.github.com/samklr/07bee2868a6ed72a8ec4
why chromebook: cheap, replacable, demo from most limiting netbook
why ipython notebooks (jupyter notebooks):
sections: motivation, logistics, aesthetics
http://jjg.svbtle.com/
http://unix.stackexchange.com/questions/136371/how-to-download-a-folder-from-google-drive-using-terminal
relevant forums "chrome os forum", "ipython notebook forum", "jupyter notebook forum", "google compute engine forum", "data science forum"
Category: DevOps
Tags: devops, chromebook, cloud9, google_compute_engine, chrome, jupyter, ipython, ipynb

include wakari

gce: f1-micro, debian, only port forward - no http, snapshots as backups, fixed external ip
i'm on gce b/c the ui is intuitive and streamlines
environment: debian, anaconda with python 3.5

table of contents
steps involved as structure.
cloud9, and instructions for connecting
cloud9, digitalocean instances too small
Cloud9 and DigitalOcean hosted VM instances were too small (Cloud9 offers up to 2.5 GB RAM, 1 core; DigitalOcean up to 8GB RAM, 4 core). I now use Cloud9 for its fancy IDE, but only as a SSH workspace. I use Google Compute Engine as my VM instance. I port forward from the VM instance to my Chromebook to run jupyter notebook using the app "Secure Shell" (screenshot attached with options). I used the VM instance to create the id_rsa key pair for my Chromebook.
copy-paste tool for key-pairs
low-profile flash drive: http://www.amazon.com/gp/product/B00LLER2CS
large cheap monitor with hdmi input
for hosting the ipynb on web rather than port forwarding: https://gist.github.com/samklr/07bee2868a6ed72a8ec4
1st chromebook: http://www.amazon.com/Acer-Chromebook-11-6-Inch-CB3-111-C670-Celeron/dp/B00MMLV7VQ
2nd chromebook:
sftp utility: https://chrome.google.com/webstore/detail/sftp-file-system/gbheifiifcfekkamhepkeogobihicgmn
why chromebook: cheap, cloud-based so easily replaced
I don't use cloud9 for debugging. I use pdb for debugging and pytest for testing. I use the IDE mostly for code navigation, autocomplete, and managing packages with many files
so far avoided needing chrome os's dev mode. using now for 2 months.


tooltip doesn't fade out

When i hover on a curve the tooltip shows as expected.
But when I leave the chart though, the tooltip stays there. Is it normal?

Good spot, that looks like a bug to me. Are you using React JSX Highcharts version 3?

yes, from package.json: "react-jsx-highcharts": "^3.0.1"

By any chance are you overriding Highcharts.Pointer.prototype.reset anywhere in your app?
I've found that in my examples I'm overriding the reset method for the SynchronisedCharts example, however that seems to be bleeding through to over examples such as the SplineWithPlotBands example.
I had no idea Webpack would build the code in that way!

hehe yes i am, in a sync charts as you do :) I'll try to remove and see if it goes away.

yes that is it!

Wondering if I should make withHighcharts take a third argument, where we provide the overrides as an object of paths.
i.e.
export default withHighcharts(MyComponent, Highcharts, {
  'Pointer.prototype.reset': () => {},

  'Point.prototype.highlight': function (func, event) {
    this.onMouseOver(); // Show the hover marker
    this.series.chart.tooltip.refresh(this); // Show the tooltip
    this.series.chart.xAxis[0].drawCrosshair(event, this); // Show the crosshair
  }
});

We can apply the overrides when the withHighcharts HOC mounts, and revert to standard functionality when the HOC unmounts.

IMHO that looks clean.

Nice one.
@anajavi any opinions on this? (Sorry to keep bugging you)
Seems that overriding Highcharts functionality like this, bleeds through into other charts elsewhere in the app, that might not want the same overrides.

It overrides class prototype methods, so it should bleed all instances created.
About the HOC:
Wouldn't that bleed to other charts mounted at the same time? If there are several charts mounted with different withHighcharts calls, it is quite unclear which pointer config wins the race.
Isn't there any other way to have that functionality than modifying the prototype? Events? Tooltip formatter code?

Highcharts instantiates chart.pointer on first render.
The intance methods can be modified in some "after first render" event hook. That way the global Pointer prototype is not polluted.
Something like this (does not work, just an example):
<Chart onRedraw={ chart.pointer = myPointer //TODO run only once } />

It overrides class prototype methods, so it should bleed all instances created.

Yeah good point

If there are several charts mounted with different withHighcharts calls, it is quite unclear which pointer config wins the race.

Ah yes, also correct. I was thinking about this too.

Isn't there any other way to have that functionality than modifying the prototype?

Potentially we could use the callback functionality that already exists, and only modify the current chart instance, but it requires a bit of reverse engineering of the Highcharts source to figure out how to do it.
getChart = function (chart) {
  chart.pointer.reset = () => {};

  // Not sure if this works
  Highcharts.addEvent(Highcharts.Point, 'afterInit', function () {
    const point = this;
    // Adding highlight fn to every point instance, not very efficient
    point.highlight = function (event) {
      this.onMouseOver(); // Show the hover marker
      this.series.chart.tooltip.refresh(this); // Show the tooltip
      this.series.chart.xAxis[0].drawCrosshair(event, this); // Show the crosshair
    };
  }
}

render () {
  return (
    <HighchartChart callback={this.getChart}>
      // omitted
    <HighchartChart />
  )
}

Although that requires a bit more

I'm experiencing a similar bug, in IE11. I have a chart with multiple series with a tooltip that shows correctly on hover, and also disappears correctly when I leave the chart. In my case I have an onclick event tied to the charts' points, which when triggered has the unintended effect of creating a static tooltip which does not disappear. This can be repeated multiple times. It does not happen in chrome or FF.
Some info on the used versions:

react": "^15.6.2
react-jsx-highcharts": "^2.3.0-alpha.1

@ErnstWevers would you be able to give a simplified reproducible example? Its difficult to debug without knowing what you're doing in the the click handler etc.

I worked on it yesterday, but I am having some issues replicating the behavior outside our application. I have narrowed it down but there are still a number of options. A little recap: since I'm working in 2.3.0 the onClick prop has to be passed as an click event option. This works with a logger in the application but once I connect it to the actual functionality, i.e. make a fetch call to grab the raw data the graph represents, it shows the erroneous behavior. I mocked this as well but still can't seem to replicate the error outside of the original application. So for now the tooltip is out, I will keep you informed if I manage to produce a reproduction.

I have replicated the problem here. It seems to be a side effect of using Preact instead of React.

@ErnstWevers that is a strange way to pass plot options, the usual React JSX Highcharts way is just to pass plotOptions as a prop.
This seems to resolve the issue.

Highcharts.setOptions({
  lang: {
    noData: 'Geen berichten gevonden voor deze periode',
    resetZoom: 'Herstel zoom'
  }
});

const plotOptions = onClickAction => ({
  series: {
    cursor: 'pointer',
    point: {
      events: {
        click() {
          console.log('I got clicked! My category is: ', this.category);
          onClickAction();
        }
      }
    }
  }
});

const Chart = ({ title = '', onClickAction = () => {} }) => {
  const plotOpts = plotOptions(onClickAction);

  return (
    <div className="app">
      <HighchartsChart plotOptions={plotOpts}>
        <Title>{title}</Title>
        <Legend layout="vertical" align="right" verticalAlign="middle" />
        <XAxis>
          <XAxis.Title>X</XAxis.Title>
        </XAxis>
        <YAxis id="axis">
          <LineSeries name="testSeries1" data={[1, 2, 3, 2, 3, 4, 3, 4]} />
          <LineSeries name="testSeries2" data={[2, 3, 4, 3, 4, 5, 4, 5]} />
          <LineSeries name="testSeries2" data={[4, 3, 3, 2, 2, 3, 2, 1]} />
        </YAxis>
        <Tooltip shared />
      </HighchartsChart>
    </div>
  );
};


Collapse common spec fields into a CommonSpec.

Proposed Changes
This forms part of the basis to reduce repetition once we're moving forward with the interfaces proposed in #54.
I wanted to put this one out for discussion early as this is a breaking change in the construction of KnativeServing/KnativeEventing resources (see the test changes below). Do we want to go that route? The tradeoff is accepting this change vs. repeating accessor functions for both Eventing and Serving.
Release Note

NONE

/assign @aliok @houshengbo @jcrossley3

Rebased.

/approve
This is a very needed change IMO. Thanks for initiating this.

/lgtm


team: add new reviewers of eg

What type of PR is this?

team: add new reviewers of eg
What this PR does / why we need it:
Add new reviewers of eg.
Which issue(s) this PR fixes:

Fixes https://github.com/envoyproxy/gateway/issues/2020

Hi forks, @alyssawilk @phlax ! Would you like to help invite to envoyproxy org and @envoyproxy/gateway-reviewers team?

@tanujd11
@tmsnan
@cnvergence

invites sent!


Validate response failed,the WechatPay signature is incorrect.

错误描述
Exception in thread "main" com.wechat.pay.java.core.exception.ValidationException: Validate response failed,the WechatPay signature is incorrect.
重现bug的步骤
Exception in thread "main" com.wechat.pay.java.core.exception.ValidationException: Validate response failed,the WechatPay signature is incorrect.
预期行为
Exception in thread "main" com.wechat.pay.java.core.exception.ValidationException: Validate response failed,the WechatPay signature is incorrect.
导致错误的代码片段
No response
操作系统
macos
Java 版本
8
wechatpay-java 版本
0.2.1
其他信息
No response

test


Optimization 5 & 6 - Add exists(String file) and copy(String source, String dest) methods to FileBackend

Implement exists(String file) and copy(String source, String dest) methods as defined in https://github.com/perfectsense/gyro/issues/315 and https://github.com/perfectsense/gyro/issues/316

PR: https://github.com/perfectsense/gyro-aws-provider/pull/294


Define methodology for benchmarking Hardhat & EDR performance

Define methodology for benchmarking Hardhat & EDR runtime performance.
Definition of Done
A document agreed upon by team outlining benchmark requirements and plan to achieve it.

Done: https://www.notion.so/nomicfoundation/EDR-Benchmark-Requirements-Plan-0cf2b12d406a4905aa1d132488be98c6


Update dash's node and next versions

In an effort to slowly move our stuff to node 18, I made a PR that upgraded dash's version, since it's quite standalone.
From that I decided to also move it to Next14. See PR for more details.

Successfully deployed 👍


CLOUDSTACK-9025: Fixed can't create usable template from snapshot in Xenserver and Vmware

https://issues.apache.org/jira/browse/CLOUDSTACK-9025
Fix also reverts below commit as below solution making assumption about hypervisor which are not applicable in case of XenServer and VmWare
Revert "CLOUDSTACK-8964: Can't create template or volume from snapshot"
This reverts commit ccf5d75cfbe769b34c021ab3653ed318cae25933.
Testing:
Able to deploy VM successfully from template created from linked clone snapshot on XenServer.

@anshul1886 I do not have Xenserver, so I do not test it.
However, I have to say that the issue CLOUDSTACK-8964 will appear again with this commit.

@ustcweizhou That bug is already taken care in Ovm3 guru code with commit 66fed46

@anshul1886 thanks for pointing out.
I think it is not reasonable to send command to each hypervisorguru, so my suggestion is to not change  HypervisorGuruManagerImpl.java. let us look for a solution for xenserver and vmware.
Can you explain what cloudstack do for xenserver before and after your change?
I do not get the difference .

@ustcweizhou I differ on this. We should not make HypervisorGuruManagerImpl complex by adding these kind of conditions as nobody is expert of all hypervisors and can make errors as happened in this case.  This will keep the core code simpler.
In XenServer after version 6.2 with hotfixes we start handling creating template from snapshot in Hypervisor agent code. So the change is if version is 6.1 or 6.2 without hot fix then send the command to SSVM otherwise send to hypervisor.

@anshul1886 thanks a lot!
now I agree with you that we should revert 66fed46.
this PR LTGM, just one small comment.
I will create another PR for Ovm3HypervisorGuru, the CopyCommand on Ovm3 should be processed by    Ovm3StorageProcessor, not ssvm.
I checked  VmwareGuru, no problem with it

LGTM, but just fix the .equals()

FYI, this integration test failed:
Create a VPC with two networks with one VM in each network and test nics after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : EXCEPTION ===
ERROR

I will run it again to see if it is a temporary error or that something is broken. Will report back when the tests are done.

Run the tests again and it looks good.
LGTM based on these tests:
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

Result:
Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and check default routes ... === TestName: test_02_redundant_VPC_default_routes | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS ===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS ===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS ===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS ===
ok
Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 34 tests in 16732.637s

OK

And:
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py

Result:
Test router internal advanced zone ... === TestName: test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS ===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS ===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : SUCCESS ===
ok
test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS ===
ok
Test reset virtual machine on reboot ... === TestName: test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS ===
ok
Test migrate VM ... === TestName: test_08_migrate_vm | Status : SUCCESS ===
ok
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS ===
ok
Test to create service offering ... === TestName: test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: test_03_delete_service_offering | Status : SUCCESS ===
ok
Test for delete account ... === TestName: test_delete_account | Status : SUCCESS ===
ok
Test for Associate/Disassociate public IP address for admin account ... === TestName: test_public_ip_admin_account | Status : SUCCESS ===
ok
Test for Associate/Disassociate public IP address for user account ... === TestName: test_public_ip_user_account | Status : SUCCESS ===
ok
Test for release public IP address ... === TestName: test_releaseIP | Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with invalid services ... === TestName: test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status : SUCCESS ===
ok
Test list VPC offering ... === TestName: test_08_list_vpc_off | Status : SUCCESS ===
test_09_create_redundant_vpc_offering (integration.component.test_vpc_offerings.TestVPCOffering) ... === TestName: test_09_create_redundant_vpc_offering | Status : SUCCESS ===
ok
Test start/stop of router after addition of one guest network ... === TestName: test_01_start_stop_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest network ... === TestName: test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName: test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 42 tests in 8142.910s

OK

I didn't test the actual feature. This just shows it didn't break anything else.

@anshul1886 Please address comments made above. After that we can merge.

LGTM


Hands not displaying in VR headset mode after installing XCharts

Hi,
I just found your wonderful library for creating graphs in Unity. It works great and the configuration options leave nothing to be desired.
However, when I installed it and started my Unity application wearing a VR headset, the player's hands do not show anymore. I can reproduce this reliably by uninstalling/reinstalling the package. My application uses the OpenXR plugin together with an Oculus headset, which adds support for hand gestures using left/right hand controllers when wearing a headset.
I saw the input system is mentioned in the tutorial, but enabling it in the Unity Editor via "XCharts > InputSystem Enable" does not help. Do you have any idea why the player's hands disappear in VR mode when XCharts is installed?

I stand corrected, there was a change unrelated to XCharts causing the problem, sorry for the noise.


MPE environment

Whether to support MPE environment？

Hi,
Thank you for your interest. For now, we do no support MPE, but if possible we may make a wrapper to support that soon.

Whether to support MPE environment？

When I run train.py, I get an error when reading model.p in case322_3min_final folder. What version of pandas and pandapower are you using? Looking forward to your reply!
This error did not occur when running 33-node and 141 systems.
The code gives an error:
C:\Users\LMD\PycharmProjects\MAPDN\MAPDN-main\train.py:70: SyntaxWarning: "is" with a literal. Did you mean "=="?
if argv.save_path[-1] is "/":
Backend TkAgg is interactive backend. Turning interactive mode on.
Traceback (most recent call last):
File "C:\Users\LMD.conda\envs\MAPDN\lib\site-packages\pandas\core\indexes\base.py", line 3652, in get_loc
return self._engine.get_loc(casted_key)
File "pandas_libs\index.pyx", line 147, in pandas._libs.index.IndexEngine.get_loc
File "pandas_libs\index.pyx", line 176, in pandas._libs.index.IndexEngine.get_loc
File "pandas_libs\hashtable_class_helper.pxi", line 7080, in pandas._libs.hashtable.PyObjectHashTable.get_item
File "pandas_libs\hashtable_class_helper.pxi", line 7088, in pandas._libs.hashtable.PyObjectHashTable.get_item
KeyError: 'type'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "C:\Users\LMD.conda\envs\MAPDN\lib\site-packages\pandas\core\indexes\base.py", line 3654, in get_loc
raise KeyError(key) from err
KeyError: 'type'
Process finished with exit code 1


New package: Arviz v0.1.0

Registering package: Arviz
Repository: https://github.com/sethaxen/Arviz.jl
Created by: @sethaxen
Version: v0.1.0
Commit: 46667d8d9f4431fa509d005830f2117408f0769f
Reviewed by: @sethaxen
Reference: https://github.com/sethaxen/Arviz.jl/commit/46667d8d9f4431fa509d005830f2117408f0769f#commitcomment-35892617

I'll update the name and resubmit.

Is this a bug in the AutoMerge bot?

Maybe. So far as I can tell, all of the files point to the new name Arviz, while only the name of the PR points to the old name ArviZ.

Maybe it's just that your comment blocked the merge? I think maybe you can edit your comments and add [noblock] to help it.
[noblock]

What's the bug? New packages are merged after 3 days. Also, isn't ArviZ a better name given that the python package is named that?

AutoMerge reports
 ┌ Info: This is a new package pull request
│   pkg = "ArviZ"
└   version = v"0.1.0"
ERROR: SystemError: opening file "/home/runner/work/General/General/A/ArviZ/Package.toml": No such file or directory

in https://github.com/JuliaRegistries/General/pull/5280/checks?check_run_id=297369941 so I was wondering if the name change caused problems.

Probably because https://github.com/JuliaRegistries/Registrator.jl/pull/239 is not deployed yet

Also, isn't ArviZ a better name given that the python package is named that?

I agree now, I think ArviZ.jl will be the least confusing confusing option. Can someone change back the PR title? I'll then revert the name change and retrigger. Sorry everyone for all the hassle!


Request: also copy over a links target; $targetAParent.attr('target')

Currently when withLink is true you pick up the href of targetAParent. Could you please do the same for the target attribute of targetAParent?
So in code, something like:
        $targetAParent = $element.parent('a');
        if ($targetAParent.length && instance.settings.withLink) {
            var url = $targetAParent.attr('href');
            var target = $targetAParent.attr('target'); // <-- NEW
            $overlay = $('<a>', {
                class: 'sliphover-overlay',
                href: url || '#',
                target: target, // <-- NEW
            }).css({
                textDecoration: 'none'
            });

Thanks!!!

im willing to see you make a pull request :smile:

Sorry, I am not familiar with the process and currently am lacking the time to get into that.
Maybe one day ... ;-)
Maybe someone else already knows how to this and is willing to step in?

what you wanna by setting the target attribute?

I am using your plugin on a grid of partner logo's. These logo's all have links to there respective external sites (target="_blank"). When your plugin is activated it does pick up the href of the parent a-element but not it's target attribute. Because of that the sites no longer open in a separte tab, which of course is not the desired behaviour. By including the suggested code the target is picked up as well and everything works again as expected.

oh i got it. and fixed :)


Angular 9 breaks xi18n

🐞 Bug report
Command (mark with an x)

[ ] new
[ ] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[x] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
In angular 8+ when I use ng xi18n, command runs without error. Since angular 9, it produce an error.
Description
Produced error : Metadata collected contains an error that will be reported at runtime: Lambda not supported.
🔬 Minimal Reproduction
Try to execut ng xi18n inside a project with lambda.
For example:
Set a new route with:
{ path: 'signin', loadChildren: () => import('./lazy-loader-modules/lazy.module').then(m => m.LazyModule) }
And have a tsconfig like:
{
  "compileOnSave": false,
  "compilerOptions": {
    "baseUrl": ".",
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": true,
    "module": "esnext",
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "importHelpers": true,
    "target": "es2015",
    "types": [
      "node",
      "fabric"
    ],
    "typeRoots": [
      "node_modules/@types"
    ],
    "lib": [
      "es2018",
      "dom"
    ]
  },
  "angularCompilerOptions": {
    "enableIvy": true,
    "allowEmptyCodegenFiles": true,
    "annotateForClosureCompiler": true,
    "skipTemplateCodegen": true,
    "strictMetadataEmit": true,
    "fullTemplateTypeCheck": true,
    "strictInjectionParameters": true,
    "enableResourceInlining": true
  }
}

🔥 Exception or Error
Metadata collected contains an error that will be reported at runtime: Lambda not supported.
🌍 Your Environment

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 9.0.7
Node: 12.3.1
OS: win32 x64

Angular: 9.0.7
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router, service-worker
Ivy Workspace: Yes

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.900.7
@angular-devkit/build-angular      0.900.7
@angular-devkit/build-ng-packagr   0.900.7
@angular-devkit/build-optimizer    0.900.7
@angular-devkit/build-webpack      0.900.7
@angular-devkit/core               9.0.7
@angular-devkit/schematics         9.0.7
@angular/cdk                       9.1.3
@angular/flex-layout               9.0.0-beta.29
@angular/material                  9.1.3
@ngtools/webpack                   9.0.7
@schematics/angular                9.0.7
@schematics/update                 0.900.7
ng-packagr                         9.0.3
rxjs                               6.5.4
typescript                         3.7.5
webpack                            4.41.2

Anything else relevant?

Hello,
have the same issue, any one could help ?
thanks

The problem is that the xi18n process uses the old ViewEngine compiler which has some restrictions on anonymous fat arrow functions (i.e. "lambdas").  The workaround, until we implement the new Ivy-based i18n extraction, is to use exported named functions instead of anonymous functions. So instead of :
{ path: 'signin', loadChildren: () => import('./lazy-loader-modules/lazy.module').then(m => m.LazyModule) }

You would need to do something like the following, I believe:
export function loadLazyModule() {
  return import('./lazy-loader-modules/lazy.module').then(m => m.LazyModule);
}

{ path: 'signin', loadChildren: loadLazyModule }

Yes, this works.. But I don't understand why  when we migrate to angular 9, code is transformed with lambda if other fixtures will not work after that...

For v9 we did not implement the new i18n message extraction, which parses the Angular component templates and extracts messages that will need to be translated. Instead we resolved to continue to use the pre-ivy extraction mechanism. Unfortunately this old mechanism relies upon the Angular code being compiled by the old ViewEngine compiler, which is not as clever at understanding (and statically evaluating) anonymous functions (aka lambdas).
For v10 we expect to have implemented a new extraction mechanism that does not rely upon the ViewEngine compiler, and so this restriction will go away then.

Ok, maybe this could be document in migration tool to prevent issue like this ?
(Sorry if I miss something)

Yes, we should document this. @DefeninMaxime - can I ask where you tried looking for solutions when you came across this before posting the issue? It will help us work out where the best place to document it is.

The problem is that the xi18n process uses the old ViewEngine compiler which has some restrictions on anonymous fat arrow functions (i.e. "lambdas"). The workaround, until we implement the new Ivy-based i18n extraction, is to use exported named functions instead of anonymous functions. So instead of :
{ path: 'signin', loadChildren: () => import('./lazy-loader-modules/lazy.module').then(m => m.LazyModule) }

You would need to do something like the following, I believe:
export function loadLazyModule() {
  return import('./lazy-loader-modules/lazy.module').then(m => m.LazyModule);
}

{ path: 'signin', loadChildren: loadLazyModule }

Didn't work for me.
I'm running the latest version of the cli though :
Angular CLI: 9.1.0
Node: 12.16.1
OS: linux x64
Angular: 9.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, platform-server, router
... service-worker
Ivy Workspace: Yes
Package                           Version
@angular-devkit/architect         0.901.0
@angular-devkit/build-angular     0.901.0
@angular-devkit/build-optimizer   0.901.0
@angular-devkit/build-webpack     0.901.0
@angular-devkit/core              9.0.6
@angular-devkit/schematics        9.0.6
@angular-devkit/schematics-cli    0.901.0
@angular/cdk                      9.2.0
@angular/flex-layout              9.0.0-beta.29
@angular/material                 9.2.0
@ngtools/webpack                  9.1.0
@nguniversal/builders             9.1.0
@nguniversal/common               9.0.2
@nguniversal/express-engine       9.1.0
@schematics/angular               9.1.0
@schematics/schematics            0.901.0
@schematics/update                0.901.0
rxjs                              6.5.5
typescript                        3.8.3
webpack                           4.42.0

@iuliust - please provide more information about your scenario if the suggested fix doesn't work. Are you getting the exact same error message? Can you provide a minimal reproduction that we can look at? Have you looked through your code for fat arrow functions that might be used in NgModule, Component, etc, decorated classes?

The following code still not work with current xi18n (9.1.3)
  {
    path: 'user',
    loadChildren: () => import('@oms/user/user.module').then((m) => m.UserModule),
    data: {
      title: $localize`:@@user:User`
    }
  },

ERROR in Cannot read property 'loadChildren' of undefined
However, build and serve are working.

Are we still on track for an ivy based i18n extraction in v10? Where can I find the progress status for that? I suppose that the problems described above would be fixed with that.

I'm really sorry but the ivy message extraction has missed the cut for 10.0.0.
Targeting 10.1.0 now - I have just not had any capacity to work on this over the last few weeks.

Here is a pragmatic workaround.
Instead of ng i18n use the Locl cli from @ocombe.
https://github.com/loclapp/locl/tree/master/libs/cli#extraction
npm install @locl/cli --save-dev
npx locl extract -s="dist/apps/demo/*.js" -f=xmb -o=messages.xmb

I have tested this with XMB files, the generated files look slightly different, but the same keys are extracted (only in a different order). So we can finally all upgrade to Ivy! 🙂👍

To enable even more people to find a solution via Google. My error message was:
ERROR in src/app/xxx.reducer.ts(19,24): Error during template compile of 'reducer'
  Function calls are not supported in decorators but 'createReducer' was called.

So, I was using the new shorter syntax to create a reducer in NgRx, which was also not compatible with the current i18n extraction tooling (see)

Transferring to the FW repo, to be triaged better.


An extra 'Detach' action shows for '(Emulator - Default Ports) (Key)' node

Storage Explorer Version: 1.9.0
Build: 20190806.12
Platform/OS: Linux Ubuntu 19.04/Windows 10/macOS High Sierra
Architecture: ia32/x64
Regression From: Previous release(1.9.0)
Steps to reproduce:

Lauch storage explorer
Expand 'Local & Attached' -> 'Storage Accounts'
Right click '(Emulator - Default Ports) (Key)' node -> Check its context menu.

Expect Experience:
There is no 'Detach' for '(Emulator - Default Ports) (Key)' node.

Actual Experience:
There shows an extra 'Detach' action for '(Emulator - Default Ports) (Key)' node.

More info:
It only refreshes the 'Storage Accounts' node after executing the detach action for the '(Emulator - Default Ports) (Key)' node.

Fix merged into master.

This isue still reproduces on the latest master build  20190813.12. So reopened it.

I think this was still repro'ing due to a bad CE commit. @v-xianya can you check for repro on tonight's build? Thanks.


1.11.4-trail Build CPU-P9 Scikit-Build-core Failure

__________________ ERROR at setup of test_pep517_mixed_wheel ___________________
ERROR tests/test_setuptools_pep517.py::test_pep517_mixed_wheel - pytest.Pytes...
===== 294 passed, 46 skipped, 47 deselected, 1 xpassed, 1 error in 11.73s ======'

Fixed this issue by selecting some limited set of tests


Add CI tests for cache related noop flags

Tests to ensure that the cache related flags currently configured for noop are consumed by buildah bud but don't change its behaviour.
Signed-off-by: pixdrift<EMAIL_ADDRESS>

Interesting, the --cache-from failed which is the only noop flag with an option provided. Will take a closer look at this as I thought it passed in my local tests.


Delete non empty namespace test

No-Issue, fills in another test from. https://github.com/himdel/ansible-hub-ui/issues/1 in the Collections > Namespaces department: "can only delete [namespace] when empty".

you'd need cy.settings({ GALAXY_REQUIRE_CONTENT_APPROVAL: true }) to enable approval if you need it.
(Though, sounds like here you'd just need to wait until the import is successful since you don't actually need manual approval to test deleting namespaces.)

pr closed.


[Bug] Wheels for Python 3.11/3.12 missing from build

The github action for building pre-compiled wheels should be enhanced to cover Python 3.11 and 3.12, which are currently not built. Possibly this could be solved by updating the version of cibuildwheels installed in the action.

Python 3.12.0 final is scheduled for Monday, 2023-10-02 (2nd Oct. 2023) , see: https://peps.python.org/pep-0693/


add force run to cursor in debug actions

When i debug in vscode, i cant  run to one breakpoint and ignore all breakpoint before it.  Although i can disable all breakpoint before target code line, but this is so waste time and so troublesome.
Think the code below:
public class Application {
    public static void main(String[] args) {
        log.info("line1");
        log.info("line2");
        log.info("line3");
        log.info("line4");
        log.info("line5");
        log.info("line6");
        log.info("line7");
        log.info("line8");
    }
}

Now lets add 4 breakpoint on msg line1, line3, line5, line7.  In jetbrain idea, i can force run to msg line7 and ignore brekpoint in line1, line3, line5, but in vscode, i have to run to cursor with one breakpoint by breakpoint.
The sample code above is simple, so i can disable breakpoint line1 ~ line5 or run to cursor one by one, but if these code line is not simple code, but is some function call, or nest function call, disable breakpoint and enable or run to cursor one by one start to waste time and be troublesome
Can vscode add a force run to cursor action in debug just like Intellij Idea do?

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

we need more old brothers to upvote for this

we need more old brothers to upvote for this

it seems that amost all backlog candidates didnt get sufficant upvotes. i think the cause is that programers didnt see issue espsically backlog candidates or backlog, and most of programmer search issue and see issue only when they get problems. and the other hand, vscode dev team dont have sufficant time and people to complete all backlog, otherwise the backlog num is 0 insted of 1k+. as above say, this mechanism didnt work well as expected.

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Chunk missing revisions before attempting to save on target

In cases with pathological documents revision patterns (e.g., 10000 open
conflicts and tree depth of 300000 on a single document), attempting to
replicate the full revision tree in one batch causes the system to crash by
attempting to send an oversized message. We've observed messages of > 4GB in the
wild.
This patch divides the set of revisions-to-replicate for a single document into
chunks of a configurable size, thereby allowing operators to keep the system
stable when attempting to replicate these troublesome documents.
This patch was missed during Big Couch merge.

+1


ENHANCEMENT: Image Editing Re-Upload To Server

Hey Friend,
So, using imagetools, you can modify the image, but then it is stored as a blob within the text editor and no longer as an external resource. Can we work together to try to setup re-upload / edit on the server side after modifications are made to the image?

I'm not quite sure what you're trying to do.

Okay, try enabling the 'imagetools' plugin. Notice how you can modify an image that was uploaded using this code. Only problem is that now the edited image is stored as a blob and it is no longer technically the uploaded file. That edited image needs to be reuploaded to the server in order to persist the changes.
Know what I mean?
I have an outstanding question on Github for this:
http://stackoverflow.com/questions/32599125/tinymce-4-imagetools-not-working-for-remotely-stored-images

Honestly, I can't help you on that issue.  It seems to be changing the core functionality of the imagetools plugin.  This is not really related to the objective of the plugin I wrote here, so I'm going to close the issue.  Good luck in seeking out a solution.  I'm of no help when it comes to decoding the core packages and don't intend to venture down that path.

It's not editing the imagetools plugin at all :)
Here is why:

It's not editing the imagetools plugin at all :)
Here is why:
http://www.tinymce.com/wiki.php/Handling_Asynchronous_Image_Uploads
http://www.tinymce.com/wiki.php/PHP_Upload_Handler
The TLDR of those pages is that, out of the box, TinyMCE 4 supports asynchronous image uploads. Adding such functionality to the source and documentation of this repo is a natural extension of its initial goal. So, using this repo code, the user can upload an image into the editor, and the image is stored somewhere remotely. BUT now, what if the user wants to edit the image, or even just resize it? Then the image will be changed into a blob, and the edits will not persist onto the server unless it is re-uploaded asynchronously. See what I mean?
TinyMCE provides the tools by which we can add this functionality. It's just a matter of us adding and changing a bit of code. For example, changing the 'file_path' return paramater name to 'location' will already get us one step closer to being able to have this functionality. Other than that, adding an event handler to the plugin, and then possibly some server side code to handle this uploaded blob, and suddenly you have a complete solution to the whole problem. I hope you see what I mean.


Add size options to figure shortcode

Description
The figure shortcode is unflexible. Big images take up too much space (see a blog post) of mine. This PR adds classes for users to adapt figure sizes to their needs.

Checklist
Yes, I included all necessary artefacts, including:

[ ] Tests
[ ] Documentation (figure shortcode is not documented at all)
[x] Implementation (Code and Ressources)
[x] Example

Testing Checklist
Yes, I ensured that all of the following scenarios were tested:

[x] Desktop Light Mode (Default)
[x] Desktop Dark Mode
[x] Desktop Light RTL Mode
[x] Desktop Dark RTL Mode
[x] Mobile Light Mode
[x] Mobile Dark Mode
[x] Mobile Light RTL Mode
[x] Mobile Dark RTL Mode

@alexanderdavide I would name the class medium, small etc. as this would be consistent with the current definition "big". What do you think?

@alexanderdavide I would name the class medium, small etc. as this would be consistent with the current definition "big". What do you think?

Can you please list your tiers replacing full, lg, md, sm? We need 4, Big and large should probably not be used together.

I would go for big, medium, small, tiny.

I would go for big, medium, small, tiny.

I've refactored it to have these classes. Actually, we could get rid of big as there is no difference between the style without classes. That's indeed something I found irritating in the existing implementation.

@alexanderdavide I was giving it some thought and concluded it might be best to reduce big to 90%.
What do you think?

@alexanderdavide I was giving it some thought and concluded it might be best to reduce big to 90%.
What

@alexanderdavide I was giving it some thought and concluded it might be best to reduce big to 90%. What do you think?

Good idea to have something in between 75 % and no class which potentially fills 100 %. How about meeting right in between at 87,5 %. This looks even better to my eyes.


Remove optional-base plugin

Issues

Resolves https://github.com/hotchemi/PermissionsDispatcher/issues/299, https://github.com/hotchemi/PermissionsDispatcher/issues/304

Overview

Remove optional-base plugin and bundle v13 support lib
Update minSdkVersion to 14
Remove bundled progurad files
Update Gradle version to 3.3

remove test13 dir and move some test cases to under processor/test/java

In general, I approve the changes you made (raising minSdkVersion, Kotlin clean-up). However, I see that you removed the safeguards around FragmentCompat. As stated here, this will cause an issue, because we can't really make usage of support-v13 optional if the pre-requisite checks and V13Access are removed.
I had to pull the branch locally and test this out, but I was able to confirm this somewhat. Here's the example:
// Abbreviated; I don't want native fragments, so I exclude the dependency
compile ("permissions-dispatcher:2.4.0") {
    exclude module: "support-v13"
}
annotationProcessor "..."

@RuntimePermissions
class NativeFragment extends android.app.Fragment {
    // In this example, I'm an incosistent user that still annotates a native fragment
}

At runtime, the first call to NativeFragment#xxxWithCheck() will crash with a ClassNotFoundException here, since FragmentCompat is missing. Before, the V13Access class and NativeFragmentProcessorUnit made sure to check if it's there before trying anything.
Ideally, the annotation processor is aware of this inconsistency (but that probably won't work, since we can't rely on FragmentCompat on the classpath, which is the reason that issues like #279 even exist). Otherwise, maybe we can use Lint here! A Lint Detector should be able to discover the inconsistency, where I cannot annotate a native Fragment with @RuntimePermissions, if I don't have FragmentCompat on the classpath!
As an alternative, we can just remove the whole "optional dependency" thing and always use support-v13. It's only like 300 methods anyway, and ProGuard will take care of it if users don't use it. ¯_(ツ)_/¯

@aurae Ah thx for your good catch!
So how about just keep checkPrerequisites? With that we'll be able to find the problem in a compile time. Adding lint check would be fine as well though!
https://github.com/hotchemi/PermissionsDispatcher/pull/306/files#diff-de57b3433a39c68273e05dc9453aaf58L18

I'm afraid that we're going to get into a situation similar to #279 with checkPrerequisites... the annotation processor doesn't seem to share the entire classpath reliably with the application anymore. Therefore, we would not be able to detect the missing FragmentCompat, I think. Maybe a Lint check is the way to go (or we just force support-v13, that's definitely the easier option)...

Okay, so let me merge this PR and create lint later! I'll address https://github.com/hotchemi/PermissionsDispatcher/issues/305 at first!


Add investment team members endpoints

Also removes the reverse side of the archived_by relationship.

Codecov Report

Merging #295 into develop will increase coverage by 0.07%.
The diff coverage is 97.95%.

@@             Coverage Diff             @@
##           develop     #295      +/-   ##
===========================================
+ Coverage    92.87%   92.94%   +0.07%
===========================================
  Files           63       63
  Lines         2427     2466      +39
  Branches       215      218       +3
===========================================
+ Hits          2254     2292      +38
- Misses         145      146       +1
  Partials        28       28

Impacted Files
Coverage Δ

datahub/investment/urls.py
100% <100%> (ø)
:arrow_up:

datahub/investment/serializers.py
99.09% <100%> (+0.06%)
:arrow_up:

datahub/investment/admin.py
100% <100%> (ø)
:arrow_up:

datahub/investment/views.py
94.11% <96.42%> (+0.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b8f867...e463e26. Read the comment docs.


Patch traffic shaper texts

Some small textual changes which clarify the use of the shaper

@Northguy looks good, thanks!


[ChatGPT]  adding a customizable Chat GPT API server setting

Extension
https://www.raycast.com/abielzulio/chatgpt
Description
I suggest the author to consider adding a customizable Chat GPT API server setting.
Who will benefit from this feature?
Customization: Different users have different requirements for their chatbot, and customizable API server enables users to configure their chatbot according to their needs.
Efficiency: A customizable API server can be optimized based on the user's requirements, thereby improving the server's efficiency.
Anything else?
No response

Extension
https://www.raycast.com/abielzulio/chatgpt
Description
I suggest the author to consider adding a customizable Chat GPT API server setting.
Who will benefit from this feature?
Customization: Different users have different requirements for their chatbot, and customizable API server enables users to configure their chatbot according to their needs. Efficiency: A customizable API server can be optimized based on the user's requirements, thereby improving the server's efficiency.
Anything else?
No response

Could you elaborate more for your feature request?

Extension
https://www.raycast.com/abielzulio/chatgpt
Description
I suggest the author to consider adding a customizable Chat GPT API server setting.
Who will benefit from this feature?
Customization: Different users have different requirements for their chatbot, and customizable API server enables users to configure their chatbot according to their needs. Efficiency: A customizable API server can be optimized based on the user's requirements, thereby improving the server's efficiency.
Anything else?
No response

Could you elaborate more for your feature request?

One potential scenario is that obtaining access to the ChatGPT 4 API service can be challenging due to factors like country or usage restrictions. Nevertheless, certain third-party providers offer ChatGPT 4 API without connecting to OpenAI servers. As a result, users only need to modify the base URL.
for example:
https://chat-ai.logcg.com

Additional, add support for Azure OpenAI API please.

Recently, I gained access to Azure OpenAI, and I noticed that it's much faster than OpenAI's API.
In some other ChatGPT clients, there is a feature that allows users to swap the base URL from https://api.openai.com to others such as https://someopenaiproxy.com. This enables users to build a proxy and direct the request to other services.
You can take this project as an example: https://github.com/haibbo/cf-openai-azure-proxy/blob/main/README_en.md
It would be brilliant if this plugin could support customization of the server to allow this kind of feature. Thank you!

Recently, I gained access to Azure OpenAI, and I noticed that it's much faster than OpenAI's API.
In some other ChatGPT clients, there is a feature that allows users to swap the base URL from https://api.openai.com to others such as https://someopenaiproxy.com. This enables users to build a proxy and direct the request to other services.
You can take this project as an example: https://github.com/haibbo/cf-openai-azure-proxy/blob/main/README_en.md
It would be brilliant if this plugin could support customization of the server to allow this kind of feature. Thank you!

Hi! We're already working on it through this PR. You could look there to see our progress and do let me know if there's any suggestion :)


Incorrect link to note about showing updateDialog to iOS users

The link to the note about showing updateDialog to iOS users is outdated. I believe the new link should be: https://github.com/Microsoft/react-native-code-push#app-store

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 839ed343-89da-4d62-c160-8f81fe396518
Version Independent ID: 12f9c437-71ee-6f7a-bf72-0010a073df97
Content: React Native SDK with CodePush API Reference - Visual Studio App Center
Content Source: docs/distribution/codepush/rn-api-ref.md
Service: vs-appcenter
Sub-service: app-center-distribute
GitHub Login: @lucen-ms
Microsoft Alias: lucen

Hi @swrobel
Thank you for catching and reporting this issue.
I prepared a PR fixing it.

Fixed. Closing the issue.


License Request

This project is awesome and could benefit from an open source license. If you have some time, could you select one that makes it easier for contributions? It's entirely possible that Win 11 won't have resolved the network bridging issue, and we'll need a straightforward app like this to continue patching instances.
How to apply a LICENSE file to the repository

Amazing. Thank you!


Improve DCR Endpoint Error Handling

Currently for building the HTTP error response, we have to append the HTTP Status message to the internal error code.  https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/master/components/org.wso2.carbon.identity.oauth.dcr.endpoint/src/main/java/org/wso2/carbon/identity/oauth2/dcr/endpoint/util/DCRMUtils.java#L98
This needs to be improved to be able to properly define API error codes and generating error responses based on the error codes.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


NullPointerException when emitting CacheEndEvent to Telemetry

File Affected: BaseController.java
Lines Affected: 238
When emitting a CacheEndEvent to telemetry, we are not checking if CliTelemInfo is null or not. This results in a NullPointerException when calling getSpeRing on CliTelemInfo object if it was null.
This bug was introduced in commit 745777a3033405d56b3af51bf6f7698f8f142aeb

Fixed by #659


change social media user name on the fly.

Allow user to change the social media use name on the fly
scenario:
lets say user want to place someone else username instead of there own. the field should be editable.

@ShaileshParmar11 , did you get a chance to look into this?

We will not allow users to change their social username on the fly because this will lead to data mismatch as they will have different usernames saved in their profile.


more english translation - need help a bit - check conversation pls

problem in Base2306
Cannot change translation for each - one should be "learn" and second one should be "learning" i cannot achieve this, because line 224 doesnt change anything and line 219 changes both

Is that the name of the pet or the name of the player? How is that ment?

Is that the code for name of the pet or the name of the player? How is that ment? TextClick_v2.lps , Line 158/ 161 / 165 / 169
{name}补位主人#{name} cover me master.:| {name}带主人飞喵#{name} I'll pick you up, master.:| {name}强吧！夸我#{name} is Strong, isn't it? Compliment me.:| {name}才不菜呢！#{name} No, I'm not rookie!:|

Is that the code for name of the pet

problem in Base2306 Cannot change translation for each - one should be "learn" and second one should be "learning" i cannot achieve this, because line 224 doesnt change anything and line 219 changes both

Because they are same in chinese, both are study.
I will make it different in next update, you can skip it

OK TY


Replace redux with react context

We need to dispatch actions in getInitialProps method, so it is not possible


We should index unread articles so that Spotlight search can find them

It would be great to be able to search from the iOS search function

We do have Spotlight integration for articles as long as it is one that you have already read. I guess what you are asking for is for all articles, even unread ones, to be indexed?

Yes, why unread would not be indexed?
Enviado desde mi iPad
El 17 sept 2022, a las 3:29, Maurice Parker @.***> escribió:

We do have Spotlight integration for articles as long as it is one that you have already read. I guess what you are asking for is for all articles, even unread ones, to be indexed?
—
Reply to this email directly, view it on GitHubhttps://github.com/Ranchero-Software/NetNewsWire/issues/3674#issuecomment-1249958253, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGJAYSTMZERRZTSRZMSDRLV6UGGHANCNFSM6AAAAAAQNP2XLY.
You are receiving this because you authored the thread.Message ID: @.***>

Yes, why unread would not be indexed?

I just made a bad design decision. Unread should also be indexed.
I'm going to change the title of this issue to more accurately describe the issue.

We should also try integrating Spotlight search on macOS. I think when I implemented it we were still supporting older versions of macOS that didn't have the API available.

We should also implement a Spotlight index extension so that if the OS needs to rebuild its Spotlight index, we can participate in the process. This probably isn't possible unless we find some way to share the SQLite database between processes.

Basically I think that any article downloaded should be indexed in Spotlight regardless read or unread. I am not a technical person so I hope it can be done. This is useful if you use the app in different devices and you want to search from spotlight on some specific keyword


Update argilla integration to use argilla_sdk v2

Description
WIP
Closes #...

[!WARNING]
Do not review yet unless there's something critical, it's still WIP and a lot of things missing. To be completed ideally by the EOD.

As an update @burtenshaw @frascuchon I've installed argilla_sdk from the latest version of argilla-python in main and running the code below, leads to the following exception, complaining about not finding the /records/bulk endpoint, could you try to reproduce on your end?

Install as pip install "distilabel[hf-inference-endpoints]<EMAIL_ADDRESS>and then run the code below with your personal HF_TOKEN and your Argilla credentials (feel free to use dev):
from uuid import uuid4

from distilabel.llms import InferenceEndpointsLLM
from distilabel.pipeline.local import Pipeline
from distilabel.steps import (
    LoadDataFromDicts,
    PreferenceToArgilla,
)
from distilabel.steps.tasks import TextGeneration

if __name__ == "__main__":
    with Pipeline(name="my-pipeline") as pipeline:
        load_dataset = LoadDataFromDicts(
            name="load_dataset",
            data=[
                {
                    "instruction": "Write a short story about a dragon that saves a princess from a tower.",
                },
            ],
        )

        text_generation = TextGeneration(
            name="text_generation",
            llm=InferenceEndpointsLLM(
                model_id="meta-llama/Meta-Llama-3-8B-Instruct",
                tokenizer_id="meta-llama/Meta-Llama-3-8B-Instruct",
                api_key="...",  # type: ignore
            ),
            num_generations=4,
            group_generations=True,
        )

        preference_rating_to_argilla = PreferenceToArgilla(
            name="preference_rating_to_argilla",
            api_url="...",
            api_key="...",  # type: ignore
            dataset_name=f"preference-rating-{uuid4()}",
            dataset_workspace="admin",
            num_generations=4,
            input_mappings={"generations": "generation", "instruction": "instruction"},
        )

        (  # type: ignore
            load_dataset
            >> text_generation
            >> preference_rating_to_argilla
        )

    pipeline.run(
        parameters={
            text_generation.name: {  # type: ignore
                "llm": {
                    "generation_kwargs": {
                        "max_new_tokens": 512,
                        "temperature": 0.7,
                    },
                },
            },
        }
    )

The logs then look like:


Examples for angular2+ and protractor

Can You please provide some examples for e2e tests using angular2+ and protractor ?
I tried to do as said in : "Howto use for your protractor tests."
But this throws error:  ngApimock.selectScenario(...) , Cannot find name 'ngApimock'
What am I missing here ?
I added global.ngApimock = require('.. path to: protractor.mock.js') and also did: "Using Angular 2 or higher with Protractor?" steps, but no success.
Angular 4.0.0
Protractor ~5.1.0

Hi @ebem ,
Can you please provide your config file how you implemented it. According to the docs it should be required in the onPrepare() method of Protractor

Sorry, also some what confused.
I'm using the angular-cli, I have read the example in your comment and tried my best to make it work within this frame work but still not getting it.
I gathered the protractor.mock.js should possibly be;
`var ngApimock = require('ng-apimock')();
ngApimock.run({
"src": "mocks",
// "outputDir": "path/to/outputDir",
"done": function() {
// async
}
});
return ngApimock;`
maybe wrong... but as I'm also working within TypeScript it doesn't see the ngApimock in the e2e tests.

@ebem
I saw an email from github that you added more info, but I can't see it here. Did something went wrong?

No sorry for my late response. The thing is, I already changed my logic for mockup server in my application, so I can't provide you with the config file, it useless for ng-apimock. I will try this (ng-apimock) package some time in future and will see how it works for my next app and give you a feed back.. So I guess you can close this issue.
P.S Thanks for your fast response.

Ok,
Tnx, I'll close the issue for now


Change the handler to raise a 404 rather rc.NOT_FOUND

Some piston changes seem to have altered the behavior of how
rc.NOT_FOUND behaves. This triggers an error from inside Piston::
|   File "/projects/openstates/virt/src/billy/billy/web/api/handlers.py", line 91, in new_read
|     return rc.NOT_FOUND
|
|   File "/projects/openstates/virt/src/django-piston/piston/utils.py", line 55, in __getattr__
|     class HttpResponseWrapper(HttpResponse):
|
|   File "/projects/openstates/virt/src/django-piston/piston/utils.py", line 82, in HttpResponseWrapper
|     content = property(HttpResponse._get_content, _set_content)
|
| AttributeError: type object 'HttpResponse' has no attribute '_get_content'

(as seen in some API calls)
I can't reproduce this locally, but I can see that I've not caused regressions
here. Looking over the pison source, the Http404 control flow should avoid
hitting this error.

@rshorey did this in a better way


Network connectivity issue: Failed to load Organizations. Failed to load organizations

Expected Behavior
The app will open and be usable
Actual Behavior
Error screen shows. Clicking "Try to reload the page" does not help.
Reproduction Steps

Open app
See error message

Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
8.4.5
What operating system are you using?
macOS
Operating System Version
macOS Ventura 13.6.2
Installation method
download from insomnial.rest
Last Known Working Insomnia version
No response

Hi @ubermaniac is this still an issue?

This is an issue for me as well.
Error: Network connectivity issue: Failed to load Organizations.
Failed to load organizations at Module.cg1 [as indexLoader]
(file:///Applications/Insomnia.app/Contents/Resources/app.asar/index-016b0889.js:1550:3441) at async _8
(file:///Applications/Insomnia.app/Contents/Resources/app.asar/index-016b0889.js:54:3729) at async Promise.all (index 2) at
async Ve (file:///Applications/Insomnia.app/Contents/Resources/app.asar/index-016b0889.js:53:23499) at async q
(file:///Applications/Insomnia.app/Contents/Resources/app.asar/index-016b0889.js:53:21362)

Same for me:
Version: Insomnia 8.4.5
Build date: 11/23/2023
OS: Darwin arm64 22.6.0
Electron: 27.0.3
Node: 18.17.1
Node ABI: 118
V8: <IP_ADDRESS>-electron.0
Architecture: arm64

Same for me.
I found that switching my Corporate Wifi to my private at home or my mobile-hotspot-wifi then it worked. So something with the corporate network (which I off-course need to use normally)

Same here :)

I'm getting this regardless of network. Home, office, mobile all the same result.

same for me

Same for me, my current ver. 8.6.0, Win 10


chore: release 3.0.1

:robot: I have created a release *beep* *boop*
3.0.1 (2024-10-03)
Bug Fixes

add js-sha3 to the deps (ab089a9)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/nugaon/bmt-js/releases/tag/v3.0.1 :sunflower:


ImageClassificationEfficientNet

the accuracy is quite low for a transfer learning model
try increase number of epochs and  change optimization functions .
you out layer has wrong number of neurons.
you have multiclass classification problem with 3 class but the output has 2 neurons specified to it.
Reason:
for binary classification usually we utilize sigmoid has activation funciton in output layer. while for multiclass it is mostly softmax which return probability of each class available thats why it is required to specify output neurons to be equal to number of classes/target label available.
In your case it will be model.add(layers.Dense(3, activation=output_activation))

Resulting confusion matrix is still underwhelming
if you observe the all the test data is consider to be cat which state model is not well trained.
Before creating confusion matrix do check considering check output of y_pred to understand it.
Because result of classification report and Confusion matrix doesnt match anyways.
Also add gpu tag similar to CNN template in meta description


Incorrect sentence

https://github.com/vlajnaya-mol/message-analyser/blob/95a4a48456949e13f619efd0e26faf122994eaf1/message_analyser/GUI.py#L160
In your application I should choose file, but app suggest choose directory of file.

Yes, you are completely right. Fixed this


'pad_seq_to_2' from utils is not found

Hi there,
I am getting the following error:
ImportError: cannot import name 'pad_seq_to_2'
No documentation online seems to support this function in the package 'utils'. I would be really grateful to have some clarity on this issue!
Thanks :)

There is a function called pad_seq_to_2 in utils. You should be able to import it from utils.

Thanks for the quick response.
Just to be 100% sure:pip install utils ?

pad_seq_to_2 isn't a function of the package I have installed

No need to use pip, utils is not a package.
utils is a file in this repo. You can find pad_seq_to_2 in utils simply using your browser.

Such a silly oversight on my part—sorry about that. I tried to run the notebook in isolation on Google Colab with only /assets.


Diagnostics needs unit and linter (pylint) tests

In order to help in the development and maintenance of the CAM diagnostics package, unit tests (either as official python "unittests" or as "doctests") should be developed such that the diagnostics code can be easily tested, including in an automated CI/CD workflow.
Along with this, a method to properly apply the pylint linter program to the CAM diagnostics would also be beneficial, as it would help catch any possible syntax errors, as well as improve readability and portability.  Ideally this method can also be automated in a CI/CD workflow, similar to the unit tests.

Adding a note here that ideally pylint should be applied to all files in the lib directory, and not jus the adf_xxx.py files.  Once that is done this issue will be considered resolved.


Unexpected results from parallel_offset when updating Shapely from 1.7.1 to 1.8

Hello,
When updating shapely from 1.7.1 to 1.8, I have an issue with parallel_offset . For some geometries, when expecting a LineString to be offset as a LineString, it creates a MultiLineString. I have not been able to identify why it works with some geometries and not with others; some geometries that are very similar don't show the same results.
I am trying to update to 1.8 first to solve warnings and issues before updating to 2.0
Below is a minimal reproduction of the problem:
import numpy as np
from shapely.geometry import LinearRing, LineString, MultiLineString
import matplotlib.pyplot as plt
from shapely import __version__

print(__version__)

pts = np.asarray([[809.29025038, -1.22445615],
                  [796.0907264, -1.6687565],
                  [783.00450305, -2.3655554],
                  [770.01539453, -3.28167197],
                  [757.11530794, -4.39201819],
                  [744.31233618, -5.66988749],
                  [731.59838634, -7.09504763],
                  [718.95727263, -8.64726633],
                  [706.39708795, -10.3095485],
                  [693.90973938, -12.06489905],
                  [681.48713404, -13.89146715],
                  [669.12927192, -15.77468556],
                  [656.82806011, -17.69674991],
                  [644.58349862, -19.64228367],
                  [632.37940165, -21.59348246],
                  [620.22386209, -23.53416048],
                  [608.10878704, -25.44651334],
                  [596.0260836, -27.31597382],
                  [583.97575177, -29.12554682],
                  [571.94969865, -30.8622837],
                  [559.93983134, -32.51323581],
                  [559.93983134, 32.51323581],
                  [571.94969865, 30.8622837],
                  [583.97575177, 29.12554682],
                  [596.0260836, 27.31597382],
                  [608.10878704, 25.44651334],
                  [620.22386209, 23.53416048],
                  [632.37940165, 21.59348246],
                  [644.58349862, 19.64228367],
                  [656.82806011, 17.69674991],
                  [669.12927192, 15.77468556],
                  [681.48713404, 13.89146715],
                  [693.90973938, 12.06489905],
                  [706.39708795, 10.3095485],
                  [718.95727263, 8.64726633],
                  [731.59838634, 7.09504763],
                  [744.31233618, 5.66988749],
                  [757.11530794, 4.39201819],
                  [770.01539453, 3.28167197],
                  [783.00450305, 2.3655554],
                  [796.0907264, 1.6687565],
                  [809.29025038, 1.22445615],
                  [809.29025038, -1.22445615]])

line = LineString(pts)

plt.plot(*line.xy, '+-', color='blue')

inside = line.parallel_offset(distance=2.6, side="right", resolution=0, join_style=3)
print(f"Inside offset is type {type(inside)}")

if isinstance(inside, LineString):
    plt.plot(*inside.xy, '+-', color='orange')
elif isinstance(inside, MultiLineString):
    plt.plot(*inside[0].xy, '+-', color='orange')
    plt.plot(*inside[1].xy, '+-', color='green')

plt.show()

This is the expected output (with shapely=1.7.1):

1.7.1
Inside offset is type <class 'shapely.geometry.linestring.LineString'

This is the output with 1.8.5:

1.8.5
Inside offset is type <class 'shapely.geometry.multilinestring.MultiLineString'>

@gohu41 the exact result you see is probably more dependent on the exact GEOS version you are using (and in different environments with different Shapely versions, the GEOS version can also differ). And I know in the latest GEOS versions there have first been some regressions and then also fixes.
Reproducing your example with shapely 2.0.1 with GEOS 3.11.2, I get:

(so that looks even "more" wrong than your second example)
Doing the same but with GEOS 3.12.0, it looks correct again:

Hi Joris,
Thanks for your help. Which version of Shapely is packaged with GEOS 3.12.0 ?
Actually in your second figure, it still looks like the closed line is offseted into two disjoined open lines.