Automator: update<EMAIL_ADDRESS>in<EMAIL_ADDRESS>

Generated by Automator - 2023-08-10T01:51:08+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio_release-1.18
7eaea9ac00ceba6402bf38c869f087fddf24b3ae
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-mc


Migration to Flutter 3.0 / Dart 2.17

Hi everyone,
It would nice to migrate to Flutter 3.0 and thus enable:

enum members
Super params
Foldable devices support

More info
https://medium.com/dartlang/dart-2-17-b216bfc80c5d
https://devblogs.microsoft.com/surface-duo/flutter-3-foldable/

+1

But what needs to be migrated, just checked I am already on 3.0.1 since a week or so

You have to change the min environment.sdk to 2.17.
There are some enum with extension in the code + some super constructor also


Cashify 3.0+ Breaking Changes - Node.js v17.2.0 ERR_REQUIRE_ESM

Breaking changes to version 3.0+ of cashify has the following breaking changes that you did not mention in your Readme.
`const { Cashify } = require('cashify');
^
Error [ERR_REQUIRE_ESM]: require() of ES Module .\node_modules\cashify\dist\index.js from .\lib\currency.js not supported.
Instead change the require of index.js in .\lib\currency.js to a dynamic import() which is available in all CommonJS modules.
at Object. (.\lib\currency.js:1:21)
at Object. (.\lib\amazonProfit.js:32:18)
at .\server.js:64:26
at Object.init (.\lib\ssl.js:65:7)
at .\server.js:50:7
at .\node_modules\entourage\lib\entourage.js:126:9
at wrapper (.\node_modules\async\dist\async.js:271:20)
at iteratorCallback (.\node_modules\async\dist\async.js:501:17)
at .\node_modules\async\dist\async.js:327:20
at .\node_modules\entourage\lib\entourage.js:117:11
at .\node_modules\async\dist\async.js:2557:44
at eachOfArrayLike (.\node_modules\async\dist\async.js:506:13)
at eachOf (.\node_modules\async\dist\async.js:626:16)
at awaitable (.\node_modules\async\dist\async.js:211:32)
at Object.eachLimit (.\node_modules\async\dist\async.js:2660:16)
at Object.awaitable (.\node_modules\async\dist\async.js:211:32)
at .\node_modules\entourage\lib\entourage.js:100:11
at f (.\node_modules\once\once.js:25:25)
at Glob. (.\node_modules\entourage\node_modules\glob\glob.js:148:7)
at Glob.emit (node:events:390:28)
at Glob._finish (.\node_modules\entourage\node_modules\glob\glob.js:194:8)
at done (.\node_modules\entourage\node_modules\glob\glob.js:179:14)
at Glob._processSimple2 (.\node_modules\entourage\node_modules\glob\glob.js:703:3)
at .\node_modules\entourage\node_modules\glob\glob.js:673:10
at Glob.stat2 (.\node_modules\entourage\node_modules\glob\glob.js:786:10)
at lstatcb (.\node_modules\entourage\node_modules\glob\glob.js:761:12)
at RES (.\node_modules\inflight\inflight.js:31:16)
at f (.\node_modules\once\once.js:25:25)
at FSReqCallback.oncomplete (node:fs:199:5) {
code: 'ERR_REQUIRE_ESM'
}
Node.js v17.2.0`

I mentioned the transition to ESM both in the changelog and README.

The standard thing to do is to put a header near the top of your README that says BREAKING CHANGES in bold and explain the change there.
Furthermore, your changes break the module in NodeJS. Out of thousands of modules that I have used in my years of using NodeJS this is the first module to completely break the loading mechanism using require. This is also the first module to not specifically announce BREAKING CHANGES at the top of the README.
Your changes also makes this section of your README inaccurate https://github.com/xxczaki/cashify#migrating-from-moneyjs aka a lie.
Suggestion: Make require work by allowing an async module loader so import is not forced as majority of people using Node are still using require and do not want to asynchronously setup a workaround to require a module.
PS: Looking at your download statistics based on version it is pretty clear you have disenfranchised many people with these breaking changes.
https://www.npmjs.com/package/cashify <-- click versions tab at the top
`Version
Downloads (Last 7 Days)
Published

3.0.1
30
20 hours ago

3.0.0
102
6 days ago

2.5.0
2,790
a year ago

2.4.4
16
a year ago

2.4.3
239
a year ago`

I am maintaining an ES2017 fork of this package at https://www.npmjs.com/package/cashify-es2017 , which means it can be used as any other package.


Add 00 in the empty cell of calculator

Describe the bug

can add 00 in the empty cell of calculator

Possible solution

Describe the solution you thought of.

Screenshots

If applicable, add screenshots to help explain your problem.

I would like to work on this issue.

it is already there in the cell, if possible try adding something else


Please add the new MAUI workloads and components added in 17.3

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe411145-ff47-dfe5-1e57-db8d54671b58
Version Independent ID: 4dac6d72-8c3c-dec8-d473-a2902e4e1fb9
Content: Visual Studio Professional workload and component IDs
Content Source: docs/install/workload-component-id-vs-professional.md
Product: visual-studio-windows
Technology: vs-installation
GitHub Login: @anandmeg
Microsoft Alias: meghaanand

@dotMorten, thanks for the feedback. We've already updated the page and the changes should be live later today.
Thanks!


CLI configuration option removal

Contributor Comments
Remove vendor-specific CLI arguments to allow more flexibility in adding new config parameters.
Pull Request Checklist
Thank you for submitting a contribution to easy_sast!
In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

[ ] Ensure that make build completes successfully
[ ] Keep our reports up-to-date by committing the output of make report
[ ] Rebase your branch against the latest commit of the target branch, which likely should be master
[ ] If there is an issue associated with your Pull Request, align your PR title with this documentation

@JonZeolla Made the requested changes to the README and tests, please review when you have time.

Ran the following end to end tests:

Successfully submit scans with the following CLI arguments: verbose, debug, config-file
Confirmed debug and verbose can only be passed exclusive to one another
Tested the following CLI arguments still work as intended: help, version
Verified that the removed CLI arguments still work as intended in a config file: app_id, loglevel, apis, sandbox, sandbox_name, workflow

Everything looks good.
@JonZeolla Are there any other tests you can think of or is this ready to merge?

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         8
  Lines          920       905   -15
  Branches       173       170    -3
=========================================
- Hits           920       905   -15

Impacted Files
Coverage Δ

veracode/config.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deaeefe...6f60ca2. Read the comment docs.


Resolves #5629 | Typo fix + npm warning fixes

What's changed, or what was fixed?

updating karma.config.js -> karma.conf.js
addressing a couple npm warnings

Fixes: #5629
Target Live Date: YYYY-MM-DD

[ ] This has been reviewed and approved by (NAME)
[x] I have run npm test locally and all tests pass.
[ ] I have added the appropriate type-something label.
[x] I've staged the site and manually verified that my content displays correctly.

CC: @petele

:tada: This has been pushed live to https://developers.google.com/web/


How I can using react components inside vite django.

Thanks for this liberals.
How I can using react components inside vite django.??

Hi,
I'm not sure about your question, Django Vite do not care about what frontend framework you use or not.
You should start by looking at the ViteJS documentation, specificaly on existing templates here
I'm sorry but I close this issue because it is not related to Django Vite directly.


Change interface to use strings instead of json values

Currently the FFI api assumes it's getting rust json values somehow:
#[derive(Debug)]
#[repr(C)]
pub struct GA_json(Value);

impl GA_json {
    fn new(data: Value) -> *const GA_json {
        unsafe { transmute(Box::new(GA_json(data))) }
    }
}

But since there is no way to construct these values from c/c++, we should just change the FFI api to take strings instead.
The alternative is to create some way to convert nlohmann::json to rust json values, but I don't see a way to do that.

Alternative we could just create a GDKRPC_make_json function that takes a string and converts it to GDKRPC_json values...

ok I think I see them now, I see they were removed here:
12279a84f0c3ef7418a3269a379de6b77e300edb
but I believe you need those if you're calling from C

I've restored the GA_convert_string_to_json API in #32 which should fix this issue


Metadata for BA

Adding source and sourcetype to a finding report's evidence object.
Context: TR-3481, TR-3482

BA has now unblocked us on this.


libc.so.6 shouldn't be fixed.

What reproduces the bug?

tools/gethostlatency.bt does not work on my centOS machine.
After some research, found it was because libc.so.6 path was not the same with my machine.
# whereis libc.so.6
> libc.so: /usr/lib64/libc.so.6

Quick workaround is to change the path to /usr/lib64/libc.so.6 in my case.
Is there a method to dynamicly find the right location of libc.so on the running machine/
-uprobe:/lib/x86_64-linux-gnu/libc.so.6:getaddrinfo,
-uprobe:/lib/x86_64-linux-gnu/libc.so.6:gethostbyname,
-uprobe:/lib/x86_64-linux-gnu/libc.so.6:gethostbyname2
+uprobe:/usr/lib64/libc.so.6:getaddrinfo,
+uprobe:/usr/lib64/libc.so.6:gethostbyname,
+uprobe:/usr/lib64/libc.so.6:gethostbyname2

bpftrace --info

System
OS: Linux 5.15.4-1.el7.elrepo.x86_64 #1 SMP Sat Nov 20 08:10:25 EST 2021
Arch: x86_64
Build
version: v0.13.0
LLVM: 12.0.0
ORC: v2
foreach_sym: yes
unsafe uprobe: no
bfd: yes
bpf_attach_kfunc: yes
bcc_usdt_addsem: yes
bcc bpf_attach_uprobe refcount: yes
libbpf: yes
libbpf btf dump: yes
libbpf btf dump type decl: yes
Kernel helpers
probe_read: yes
probe_read_str: yes
probe_read_user: yes
probe_read_user_str: yes
probe_read_kernel: yes
probe_read_kernel_str: yes
get_current_cgroup_id: yes
send_signal: yes
override_return: no
get_boot_ns: yes
dpath: no
Kernel features
Instruction limit: 1000000
Loop support: yes
btf (depends on Build:libbpf): no
map batch (depends on Build:libbpf): yes
uprobe refcount (depends on Build:bcc bpf_attach_uprobe refcount): yes
Map types
hash: yes
percpu hash: yes
array: yes
percpu array: yes
stack_trace: yes
perf_event_array: yes
Probe types
kprobe: yes
tracepoint: yes
perf_event: yes
kfunc: no
iter:task: no
iter:task_file: no

Yes, with the recent bpftrace, you can use:
uprobe:libc:getaddrinfo,
uprobe:libc:gethostbyname,
uprobe:libc:gethostbyname2

Unfortunately, tools/gethostlatency.bt cannot be fixed, yet, as this feature depends on a newer version of BCC, which may not be present in some systems (e.g. our CI). If we resolved #1933, then it'd be possible.


error calling eq: missing argument for comparison

Seems like 93baa61cb69 introduced syntax errors in Go template expressions.
When cloning the repo, then invoking
$ helm dependency update
$ helm install cortex --namespace cortex /path/to/working/copy

I receive the following output:
Error: template: cortex/templates/table-manager-dep.yaml:102:7: executing "cortex/templates/table-manager-dep.yaml" at <eq .Values.useExternalConfig>: error calling eq: missing argument for comparison

The named code location looks as follows:
{{- if eq .Values.useExternalConfig }}
            secretName: {{ .Values.externalConfigSecretName }}
{{- else }}
            secretName: {{ template "cortex.fullname" . }}
{{- end }}

According to text/template documentation, eq does indeed expect a second argument, and I guess it should simply be {{- if .Values.useExternalConfig }}.

Hey, Did you manage to run this? because I have the same issue


same x with different y

I'm not strong enough in math. Can somebody help me? Is it correct to path same x with different y?
Example:
import regression from 'regression';
cons data = [
[0, 1],
[32, 67],
[32, 50],
[12, 79],
]
const result = regression.linear(data);

@olmer88
I'm assuming you already figured this out, but this is correct.
Also - GitHub issues is not the place to ask questions like this.


Add Blockchain namespace

Checklist

[x] Faker::Bitcoin => Faker::Blockchain::Bitcoin
[x] Faker::Ethereum => Faker::Blockchain::Ethereum
[x] Faker::Tezos => Faker::Blockchain::Tezos

This PR is related to https://github.com/stympy/faker/issues/1318

@Pierre-Michard I remember that you implemented Faker::Tezos. Let me know what you think about this namespace.

Hi Victor, that's a brilliant idea. that organizes the project and clarifies the purpose of those recipes.

Thanks for reviewing 🥇


Update compare function return value

The return value of compare function prototype is int. Use int as return value type for compare function to prevent compiler warning

Why do we need to modify the return value of compare function?

This PR is to fix the compiler warning of issue #107.
The prototype of the compare function is int instead of int32_t.
Please reference the following link.
https://pubs.opengroup.org/onlinepubs/009695299/functions/bsearch.html


validate backup config for cluster with local backup config

https://github.com/rancher/rancher/issues/18920

LGTM


whitelist problem

Hey,when i add myself to the whitelist,the console says im added,but i cant join.
It says "youre not whitelisted".

Same it was working and now it saying that to everyone


Restart of keda-operator causes ScaledJob object to be updated

Report
Restart/Recreation of keda-operator causes ScaledJob object to be updated, which leads to Jobs being rolled out as per the RolloutStrategy.
Expected Behavior
Restart/Recreation of the keda-operator should not update the ScaledJob object
Actual Behavior
Restart/Recreation of the keda-operator somehow update the ScaledJob object leading to Jobs being rolled out as per the RolloutStrategy.
Steps to Reproduce the Problem

Kill the keda-operator (with replicas >1).
Wait for the keda-operator to be recreated.
In the Kubernetes events for the ScaledJob object, around the time the keda-operator was restarted the following events can be seen:
i. KEDAJobsCreated
ii. KEDAScalersStarted

KEDA Version
2.13.1
Kubernetes Version
1.27
Platform
Microsoft Azure
Scaler Details
No response
Anything else?
This could also be the expected behavior of the keda-operator. However I do not understand why any changes the to keda-operator should affect the ScaledJob object.

Hello,
This is weird and it shouldn't happen. Are you willing to take a look and open a PR with the fix?


Test PFE components against Carbon web components

We should add carbon custom elements to our list of frameworks to test against, before Summit
https://github.com/carbon-design-system/carbon-custom-elements

As summit 2020 is behind us, closing for now. If we want to revisit, let's open an new issue


[FEATURE REQUEST] Automatically go to darkmode in the night

I think using the date api it is possible to set it so that if its after a certain time it can automatically go on dark mode but in #38 it messed up the whole project

@aliraza944 Do you know how to use the date api? And if yes, would you be possible to do this?

Yes, it's quite possible. But I think the toggle button is fine because you would a javascript code for each of the pages and then you'd have to guess the nighttime for each of the regions in the world. I think this is a bad user experience. Totally doable though.

@KendallDoesCoding do you still want this?

Well, if your saying it will be a bad experience, then I can agree, even I was wondering, but in discussion in #38 @TechStudent11 said that he could implement that only if the computer/mobile time was a certain so if that's possible I'm down, but if it isn't because he didn't manage to do it #38 .

Date.time()

Well, if your saying it will be a bad experience, then I can agree, even I was wondering, but in discussion in #38 @TechStudent11 said that he could implement that only if the computer/mobile time was a certain so if that's possible I'm down, but if it isn't because he didn't manage to do it #38 .

@aliraza944 @TechStudent11 So let me know if we should do this or no, accordingly will close this thread.

Well, if your saying it will be a bad experience, then I can agree, even I was wondering, but in discussion in #38 @TechStudent11 said that he could implement that only if the computer/mobile time was a certain so if that's possible I'm down, but if it isn't because he didn't manage to do it #38 .

@aliraza944 @TechStudent11 So let me know if we should do this or no, accordingly will close this thread.

@KendallDoesCoding tbh it could be cool, but not practical. It's your call.

I don't think it's practical so not doing it is my call.

@aliraza944 so we both agree. It's not practical so just don't add it.

@aliraza944 so we both agree. It's not practical so just don't add it.

Ok, closing this. I was thinking of another idea on this though that if they have set it to darkmode and closed the site, the next time they go to the site using cookies the site will be automatically on darkmode, making a issue for that and will discuss there.

@aliraza944 so we both agree. It's not practical so just don't add it.

Ok, closing this. I was thinking of another idea on this though that if they have set it to darkmode and closed the site, the next time they go to the site using cookies the site will be automatically on darkmode, making a issue for that and will discuss there.

Oh that's ez.

@aliraza944 so we both agree. It's not practical so just don't add it.

Ok, closing this. I was thinking of another idea on this though that if they have set it to darkmode and closed the site, the next time they go to the site using cookies the site will be automatically on darkmode, making a issue for that and will discuss there.

Forgot to close this. Closing now


ORC-892: Pin scala-library to 2.12.10

What changes were proposed in this pull request?
This PR aims to pin scala-library to 2.12.10.
Why are the changes needed?
Apache Spark 3.1 uses 2.12.10
How was this patch tested?
N/A

cc: @dongjoon-hyun , @pgaref

Thank you, I merged it.


[5.3] Allow for splitting commands and handlers on jobs.

This pull request allows for commands and handlers (whether in a queue, or command bus) to be separate as an alternative to self-handling jobs.
I have explained the purpose of this fix (and discussed it in detail) with Taylor, but I'll explain it here for the benefit of those reviewing.
Having the separation between commands and handlers makes the most sense in 'multi-app' environments that use a single queue consumer project. Consider the following:
APP1     APP2      APP3

	all fire queued jobs to:

	      APP4
  (running queue:listen)

Consider the following job:
<?php

use Some\Other\Package\FooService;

class DoSomething
{
	protected $someId;

	public function __construct($someId)
	{
		$this->someId = $id;
	}

	public function handle(FooService $foo)
	{
		// Do something with foo service.
	}
}

Apps 1-3 might wish to fire this job, but to do so they will need to import the package for FooService using composer, even though it's never used from those projects.
By separating the command and handler (splitting into two classes, one a value object, the other with a handle method) and allowing the user to map commands to handlers we can fire the jobs from APP1-3 without the FooService requirement.
Mapping commands looks like the following:
Bus::map(CommandClassHere::class, HandlerClassHere::class);

Firing jobs should use the 'command':
$this->dispatch(CommandClassHere::class)

Stand alone handlers should inject their dependencies through the constructor, where existing self-handling jobs will inject their dependencies through the handle method.
This change should be backwards compatible and still allow for self-handling jobs to function as before.
Thanks for reading!

@GrahamCampbell want to explain where you think this might fall short? I checked the other comment but I'm not sure I follow. Can you link to some source? Cheers buddy.

Yeh, of course. :)
The file in question is https://github.com/laravel/framework/blob/5.3/src/Illuminate/Queue/Jobs/Job.php#L209-L224.


fix(carbon): pin carbon deps

Closes #934
Summary

Remove the caret from carbon dependencies

:tada: This PR is included in version 2.45.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support GitHub deployment API

Looks like GitHub has an API to trigger deployments, https://developer.github.com/v3/repos/deployments/. Having support for this would be great as an explicit deployment point can be supported.
Probably need to support the specific hook type to be able to access it within the config and then do actual deploys.

track event type
We should probably start tracking what event triggered the build. For example, pull_request, push or deployment:
type Build struct {
+ Event string
}

update hook
We need to update the hook to correctly parse the deployment payload. We can see an example payload here: https://developer.github.com/v3/activity/events/types/#deleteevent
The data in the payload needs to be mapped to the commit.
add step filters
We should then add the ability to filter certain steps based on the hook event type. For example, we may only want to run a heroku deployment when the hook is deployment:
deploy:
  heroku:
    when:
      event: deployment

add user interface indicator
it would be nice to add a little label / tag to the user interface that the build was a deployment.
update github status code
the code that updates the github status api should be slightly altered to update the github deployment api if the build.Event == "deployment"
Overall this shouldn't be too difficult to implement and will be a really awesome feature.

This seems to be working so we can probably close this.

@bradrydzewski is there a way to include the deployment id as an environment variable? It would allow build scripts to update the deployment status (which would allow for things like publishing deployment status messages in Slack)

I opened a topic here https://discuss.drone.io/t/github-deployments/91

I think we can close this now that we have the ability to filter steps based on deployment target (below) as well as access the CI_DEPLOY_TO environment variable.
deploy:
  heroku:
    app: foo
    when:
      environment: production

We also recently accepted a pull request to update the deployment status automatically, so we no longer need to do so with custom scripts. Reference commit 6ddc2abf47cbf5d101106d966d90186941637de0


Bug on opencart <IP_ADDRESS>

Hello, there is a bug on the ebanx.php controller:
Notice: Indirect modification of overloaded property ControllerPaymentEbanx::$data has no effect in /home/nutrivita/public_html/catalog/controller/payment/ebanx.php on line 72Notice: Indirect modification of overloaded property ControllerPaymentEbanx::$data has no effect in /home/nutrivita/public_html/catalog/controller/payment/ebanx.php on line 77Notice: Indirect modification of overloaded property ControllerPaymentEbanx::$data has no effect in /home/nutrivita/public_html/catalog/controller/payment/ebanx.php on line 96Notice: Indirect modification of overloaded property ControllerPaymentEbanx::$data has no effect in /home/nutrivita/public_html/catalog/controller/payment/ebanx.php on line 97Notice: Indirect modification of overloaded property ControllerPaymentEbanx::$data has no effect in /home/nutrivita/public_html/catalog/controller/payment/ebanx.php on line 98Notice: Indirect modification of overloaded property ControllerPaymentEbanx::$data has no effect in /home/nutrivita/public_html/catalog/controller/payment/ebanx.php on line 99Notice: Indirect modification of overloaded property ControllerPaymentEbanx::$data has no effect in /home/nutrivita/public_html/catalog/controller/payment/ebanx.php on line 100Notice: Indirect modification of overloaded property ControllerPaymentEbanx::$data has no effect in /home/nutrivita/public_html/catalog/controller/payment/ebanx.php on line 103Notice: Indirect modification of overloaded property ControllerPaymentEbanx::$data has no effect in /home/nutrivita/public_html/catalog/controller/payment/ebanx.php on line 104Notice: Indirect modification of overloaded property ControllerPaymentEbanx::$data has no effect in /home/nutrivita/public_html/catalog/controller/payment/ebanx.php on line 113Notice: Indirect modification of overloaded property ControllerPaymentEbanx::$data has no effect in /home/nutrivita/public_html/catalog/controller/payment/ebanx.php on line 115Notice: Indirect modification of overloaded property ControllerPaymentEbanx::$data has no effect in /home/nutrivita/public_html/catalog/controller/payment/ebanx.php on line 116Warning: extract() expects parameter 1 to be array, null given in /home/nutrivita/public_html/system/modification/system/engine/loader.php on line 33
Simple solution, OC <IP_ADDRESS> has changed the $this->data to $data, its an easy solution, but it took me a while to figure out.... So this can help users on the future...

Hey! I'm can't seem to replicate this error, in which part exactly does this happen? It is simply echoed to the screen or this shows inside the error logs?

Its echoed when you go to select ebanx as a payment, on screen.


[python aio] AttributeError: module 'grpc' has no attribute 'aio'

What version of gRPC and what language are you using?
$ pip freeze
grpcio==1.32.0
six==1.15.0

What operating system (Linux, Windows,...) and version?
Fedora 32 Linux
What runtime / compiler are you using (e.g. python version or version of gcc)
Python 3.8.5 (default, Aug 12 2020, 00:00:00)
[GCC 10.2.1 20200723 (Red Hat 10.2.1-1)]

What did you do?
create file server.py
#! /usr/bin/env python
import asyncio
import logging
from concurrent import futures
import grpc

logging.basicConfig(level=logging.DEBUG)
addr = '[::]:50051'

async def run():
    server = grpc.aio.server(futures.ThreadPoolExecutor(max_workers=10))
    server.add_insecure_port(addr)
    logging.info(f"Listening on {addr}")
    await server.start()
    await server.wait_for_termination()

if __name__ == '__main__':
    asyncio.run(run())

What did you expect to see?
the code execute and print out
DEBUG:asyncio:Using selector: EpollSelector
DEBUG:grpc._cython.cygrpc:Using AsyncIOEngine.POLLER as I/O engine
INFO:root:Listening on [::]:50051

What did you see instead?
I get an import error.
$ python server.py
Traceback (most recent call last):
  File "server.py", line 16, in <module>
    asyncio.run(run())
  File "/usr/lib64/python3.8/asyncio/runners.py", line 43, in run
    return loop.run_until_complete(main)
  File "/usr/lib64/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "server.py", line 9, in run
    server = grpc.aio.server(futures.ThreadPoolExecutor(max_workers=10))
AttributeError: module 'grpc' has no attribute 'aio'

Also the docs https://grpc.github.io/grpc/python/grpc_asyncio.html for this version still say that the api is experimental but it has been moved out of experimental in this commit 5694b798b0d49c33f5589527cdea2b7e9649e4b8

Good catch. The aio module is not exposed as a visible attribute of grpc. So, it needs to be imported in this way now:
from grpc import aio

I will make a chance to make grpc.aio.foo work.

Filed two PR: https://github.com/grpc/grpc/pull/24289 for the import path update, and https://github.com/grpc/grpc/pull/24286 for fixing the document.
Thanks for reporting to GitHub.

feel free to close #24284

Fixed by https://github.com/grpc/grpc/pull/24341 and #24289


Dev.to scraper

Description
Script to scrape articles from dev.to as per user's choice and save them as pdf
Fixes #755
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] My documentation follows Template for README.md
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@antrikshmisri


how can I get the trainvalno5k.json file?

how can I get the trainvalno5k.json file? I can not find the way to get the trainvalno5k.json in datasets\Readme.MD.

See #23

Thanks, @scott-vsi  for the response.  Closing the issue now ...


Don't direct people to Stackoverflow.

Asking a Question?
Don't take this personally. Feel free to ignore my opinion.

Please don't file GitHub issues to ask questions! Instead use:

Then don't put your library on Github!!!
I don't understand why you expect people to make an account on Stackoverflow.
I don't have an acount there and I don't want to make one. I have several reasons for it and hopefully don't have to explain myself.
IMHO this is a very chauvinistic aporoach.
I'm very sure you don't agree so feel free to close this issue and hate me for bringing this up.
My issues with this library:
All the examples use relative paths so there is no way to find a proper example/demo. The examples use deprecated or old mechanisms that are far from best practice (i.e. ref='SomeString'}).
I think a library with so many stars and contributers should have a better option for supporting developers trying to find a clean way of using this library.
Since nobody will ever care I'll stop here.

I disagree.  If you need help using the library you should not file an issue.  If you feel the documentation is lacking then you can file an issue and explain how it can be improved and what you feel it's missing.

@neptunian

you can file an issue and explain how it can be improved and what you feel it's missing

Exactly my point.
This project does not want questions to be asked in issues but rather suggests asking on Stack Overflow.
And that's my complaint. You just confirmed my issue, thanks.

I'm saying I agree with them, get help on Stack Overflow or Slack etc.. don't open an issue in the repo unless the issue to actually update documentation and why it needs to be updated etc.  Asking direct help questions is not what issues are for.

Issues are there to help people. If you don't want to help you clearly don't understand open source.


Spinner in loading page should be properly centered on desktop.

Spinner should include a left padding of 85px on desktop render.

fixed


Throughput measurements of parallel and recurrence methods

Hi @fkodom ,
Thank you so much for sharing this work with the research community.
I have one question please, I measure the throughput in the inference and it seems that the parallel method has more throughput compared to the recurrence method, which is inconsistent with the paper. They claim that recurrent inference is O(1) and has higher throughput. Have you tested that or know what is the reason?
Best regards,
Abdelrahman.

Hi @Amshaker!
I haven't quite tested what you're asking about, but something very similar in scripts/benchmark_inference.py.  In that script, I reproduce (a scaled-down version of) the inference benchmarks in the paper -- comparing RetNet and nn.Transformer at various input sequence lengths.

They claim that recurrent inference is O(1) and has higher throughput.

This is true.  Recurrent inference has (roughly) $O(1)$ complexity per token generated.  Although I've seen quite a few people confusing that with $O(1)$ complexity for the entire sequence. 😅 See this figure (bottom of README) that was generated with the script above.

I measure the throughput in the inference and it seems that the parallel method has more throughput compared to the recurrence method

Something to keep in mind -- a single forward pass with RetNet.forward_parallel or RetNet.forward_recurrent only generates one new token.  For example, when using a sequence length of 4096, the RetNet.parallel_forward method does not generate 4096 new tokens at once.  You have to pass all N-1 preceding tokens into the model in order to generate token N.  Contrast that with RetNet.forward_recurrent, where the internal states are cached and reused for each successive token.  Maybe that's where the throughput calculation is confusing?
Here's a script that (almost) measures what you're after.  In the paper, they use a KV cache when measuring parallel Transformer throughput, which speeds things up quite a bit.  I didn't bother with KV cache for RetNet, because the recurrent formulation is already significantly faster.
import torch

from yet_another_retnet.retnet import RetNet
from yet_another_retnet.utils.benchmark import benchmark

num_tokens = 10000  # vocab size
batch_size = 4
seq_length = 2048
d_model = 512
nhead = 8
num_layers = 6

device = "cuda"
dtype = torch.float16

x = torch.randint(0, num_tokens, size=(batch_size, seq_length), device=device)
retnet = RetNet(
    num_tokens=num_tokens,
    d_model=d_model,
    nhead=nhead,
    num_layers=num_layers,
    device=device,
    dtype=dtype,
).eval()

with torch.no_grad():
    recurrent = benchmark(retnet.forward_recurrent, x[:, 0], seq_idx=0)
    print(f"RetNet recurrent: {batch_size / recurrent.mean:.3f} tokens/s")
    parallel = benchmark(retnet.forward_parallel, x)
    print(f"RetNet parallel: {batch_size / parallel.mean:.3f} tokens/s")

# Result on my machine with 2080 Ti GPU
# RetNet recurrent: 484.416 tokens/s
# RetNet parallel: 71.981 tokens/s

@Amshaker You're not entirely wrong. 🙃 To my understanding, here is the difference from what you described.
Suppose you're generating text with a RetNet model.  So far, you've generated 1024 tokens.  You do not know what the 1025th token is until you compute it with RetNet.
In order to compute token 1025, you could:

Pass the entire 1024-token sequence into RetNet.forward_parallel.  The model is trained with labels offset by 1 index, so the last token returned is your predicted 1025th token.
Incrementally pass the first 1023 tokens into RetNet.forward_recurrent while keeping track of the state Tensor.  When passing the 1024th token, the model returns a prediction for token 1025.

You do not have a state Tensor to reuse with RetNet.forward_parallel, so you're forced to pass the entire 1025-token sequence (or up to the allowed context window) into the model.  The last token returned is your predicted 1026th token.
With RetNet.forward_recurrent, you do have a state Tensor to reuse.  So like before, you pass that into the model and get a prediction for token 1026.

^^ Scenario (1) is how Transformer-based inference typically goes.  That's why each forward pass only generates one token -- not 1024 at once.  There are caching tricks to make it more efficient, which reduce the complexity from $O(N^2)$ (the complexity of naive multi-head attention) to $O(N)$.  Because the recurrent RetNet formulation maintains a running state Tensor, inference for each new token doesn't depend on the preceding sequence length, so it is $O(1)$.


scrollable panes, tooltip and history back

Watch view:

The hardcoded ellipsis didn't correspond to the fluid container, made the ellipsis CSS based
Also added HTML-based tooltip with full content

History view:

Back button for easier navigation
Scrollable panes for key and history, both of which had responsive sizing, but contents which didn't wrap right (there was truncation previously).

wow @mikeapr4 thanks a lot! much appreciated bud, i'm no UI guy


Type ... is not assignable to type 'never'.ts(2322)

I'm getting the error described in the comments at the bottom of the example below which is also available in a repo here.
Am I just approaching this incorrectly or is this something that can be fixed in this repo?
import joi from '@hapi/joi';
import 'joi-extract-type';

const testSchema = joi
  .object({
  tractor: joi
    .array()
    .has(
      joi.object({
        myId: joi
        .string()
        .optional(),
      })
    )
    .required()
    .min(1),
  })
  .required();

type TestType = joi.extractType<typeof testSchema>;

const tf = (): TestType => {
  return {
    tractor: [{ myId: '1' }]
  };
  // On myId above I'm getting this TypeScript error:
  // (property) myId: string
  // Type 'string' is not assignable to type 'never'.ts(2322)
}

Hey @guyellis I think .has is not implemented.
Any reason to use .has instead of .items?
Actually I haven't used .has myself, and I am not sure how it would map to a type since the implementation says that it is valid if at least one of array items match the schema.
https://hapi.dev/family/joi/?v=16.1.2#arrayhasschema

@TCMiranda - no reason not to use items - that works - thanks!


Remove From and Into test impls and create test-specific function for converting between Rust primitives and U256

Created a new test-utils module for these functions since it needs to be visible for tests in the block module that were also using the previous From and Into impls.
Fixes #3160

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

14 of 14 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 82.49%

Totals

Change from base Build<PHONE_NUMBER>5:
0.006%

Covered Lines:
19782

Relevant Lines:
23981

💛  - Coveralls


Define an authorized level of relativity

I would love to use your module but it is lacking something essential IMO: allow relative imports inside the same folder, i.e, allow from .a import b  but not allow from ..a import b.
Most people find it more legible to reference siblings files relatively as you can see/list them. However, as soon as the import to parent folders, it becomes very difficult to read, specially from ............a import b
maybe we could add a relative_level: int to the settings, with

0  meaning replace all relative imports
1 meaning keep only single dot (ex from .a import b)
2 meaning keep up to two dots (ex from ..a import b)
etc...

Hey @anis-campos - thanks for your suggestion, but I'd rather not add such complexity, sorry


[$250] Expense rules - Long comment entered in the description field overflows

EXPECTED RESULT:
Long comment entered should be within the field
ACTUAL RESULT:
Long comment entered goes beyond the field
ACTION PERFORMED:

Go to URL https://staging.expensify.com/
and login with any account
Navigate to Main/Settings/Your Account/Expense Rules
When the Merchant name contains: Test
Change Merchant to: New Test
5.Change Category to: Any category
Enter a long comment

Workaround:
Visual
Notes/Photos/Videos:

Tester login credentials - Email/Phone<EMAIL_ADDRESS>Tester login credentials - Password: w323052760We

This is coming from https://github.com/Expensify/Expensify/issues/216750 - it's already been triaged and marked as External, I'm just copying it over to the external repo.

Uhhh guys .... who marked this as external? It's in OldDot so definitely needs to be internal

This needs to be internal. @bfitzexpensify Please take down the upwork job and close this out. I reopened the internal issue

Closed the upwork job. Closing this out.


chore: added coverage tracking

I like it!  On one hand this is good to know, on the other hand this will likely reveal some embarrassing coverage numbers :)


Revert "Revert "feat(PRO-107): add tracking to settings IDV clicks""

Reverts artsy/force#12343

@iskounen - mind updating the PR description with the reason why we need to revert? Its always helpful to leave historical context so folks don't end up unintentionally repeating work (happens often with reverts)


Move tests from inst/tests/ to tests/testthat/

We should just get it over with after this release. @fritzo is happy to volunteer.

Great, thanks. But please check the "writing R extensions" manual to make
sure this is consistent with what CRAN wants.
On Mon, Apr 24, 2017 at 8:56 PM, Fritz Obermeyer<EMAIL_ADDRESS>wrote:

We should just get it over with after this release. fritzo@ is happy to
volunteer.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nimble-dev/nimble/issues/300, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACYr3kewoMu3dwdXbo1a9SkrRAHb3lqRks5rzUTHgaJpZM4NG4RV
.

I'm not sure this is the right way to go.  I think we didn't do it previously because there are steps when R will automatically run anything in the tests directory.  E.g. step 19 of R CMD check (section 1.3.1 of writing R extensions, which I think means that when CRAN checks a submitted package it will run what is in tests.  It is less clear from the documentation but may be the case that tests are also run upon installation (section 1.1.5).  In any case, our idea from past discussion was that our complete test suite is too heavy (hours) to include for CRAN checking, so we've kept with the "deprecated" but very useful inst/tests location.  We could consider adding small tests for R CMD check that could help ensure things are set up correctly without grinding through every MCMC test, DSL test, etc.

Moving to nimbleCoreTeam.


Maintainer update: Switch GH Account

I'm switching from my company account to my private account soon-ish. The company account will be deleted then.
To keep maintaining this project, I've exchanged the old company account for my personal one.

@conda-forge-admin, please rerender

not from fork, close


Make Linode ID an explicit param for setRDNS

This allows the user to take IPv6 RDNS actions and addresses #2853

Coverage remained the same at 50.96% when pulling 26a0a10f8474b420d0cb89c4955b69f7cd9cc3a8 on asauber:fix-rdns-unset into 430676a2bb941670db2754f5566e73205e4a2a6f on linode:develop.


Audio input/output

Can i use my airpods as input and output?

It records from the default microphone and default speaker for your system if your airpods are set as default then it will record from them.


[Profiler] Use the Kineto to profile Triton XPU Kernel's accuracy execution time.

There is no stand along profiler tools for Triton XPU now.
We used to use:

the Torch legacy profiler with the IPEX extension. (This is going to be removed by IPEX)
The new torch profiler with the Kineto extended by IPEX. (This depends on the Kineto and Torch)
Use the synchronization wait on the host to measure the performance. (This is not accurate with host overheads.)

The Triton has a new component for profiling performance of the Triton kernel. It worth to support it for the Triton XPU.

This task is highest priority for collecting accuracy Triton performance for the coming Triton Demon on Jun 25.

I have added post review comments to the PR that closed this issue, see https://github.com/intel/intel-xpu-backend-for-triton/pull/1136#discussion_r1605220737.
I am concerned the benchmarks use a different way than the do_bench Triton uses to compute timing.

Use the Torch legacy profiler with the IPEX extension to profile the Triton kernel.
The changes has been merged.
https://github.com/intel/intel-xpu-backend-for-triton/pull/1136

As the legacy profiler in public Torch doesn't support XPU, we need to use the Kineto to profile the Triton kernel.
The alternative solution is to enable the Proton which is tracked in
https://github.com/intel/intel-xpu-backend-for-triton/issues/1145
Change the title of this issue to be more precise.

The Pytorch Kineto for XPU requires a separate PTI package intel-pti-dev_p_<IP_ADDRESS> which is not included PTDB package so far.
I will try it with Triton kernel to see if it works properly.

Add @ZzEeKkAa as assignee to this issue because he has already worked on the Kineto profiler integration to Triton.
Here is the PR #1905 from @ZzEeKkAa

Speaking of PTI, can we use it for the elapsed_time. We would unblock long running https://github.com/pytorch/pytorch/pull/126456?

@chengjunlu could you please provide the detailed instruction on how to use Kineto for PyTorch profiling in general and Triton kernels profiling in particular. The use cases in scope are:

Triton UT's
Triton Tutorial's
Torch Inductor UT's relevant to the Triton
PyTorch/Benchmark E2E tests

Speaking of PTI, can we use it for the elapsed_time. We would unblock long running pytorch/pytorch#126456?

The elapsed_time is more general that can be used to profile the E2E GPU time including the bubble time which maybe caused by kernel scheduling bubble.  I am not sure it is possible in PTI.

@chengjunlu could you please provide the detailed instruction on how to use Kineto for PyTorch profiling in general and Triton kernels profiling in particular. The use cases in scope are:

Triton UT's
Triton Tutorial's
Torch Inductor UT's relevant to the Triton
PyTorch/Benchmark E2E tests

I combine all the information here for performance profiling.
There are two ways used in Torch + Triton to measure GPU kernel performance:

Diff the two events time stamp by elapsed_time.
Use the Kineto to profile kernel time thru PTI.

Note: Pytorch XPU 2.5 doesn't support elapsed_time and raises exception. The Triton XPU work around it approximately by using the wall time instead of GPU time stamp. I will mark the use cases with Triton Workaround for notice.
Here are the cases using 1st way:

Triton Tutorial's Triton Workaround

Triton UT's Triton Workaround

Torch Inductor UT's relevant to the Triton. Triton Workaround

Here are the cases using 2nd way:

PyTorch/Benchmark E2E tests

Note: https://github.com/intel/intel-xpu-backend-for-triton/blob/llvm-target/scripts/patch-pytorch.sh can be applied to allow using elapsed_time for the cases that specified above as using 1st way. It is used in CI and developer script.

This is blocked by an issue in Intel Kineto not able to trace the Triton kernel launched by SYCL API.

Closing this issue, it was superseded by:

#1066
#1145
#2499


fix(linter): remove confusing help text for now

#7081  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camchenry and the rest of your teammates on  Graphite


Um 313 make replay output mpi aware

With this change, UMPIRE_REPLAY will now include the PID of the calling process.
The replay tool has also been updated to only replay one of the PIDs.  By default, replay will replay the all of the operations from the first PID it finds.  If it finds other PIDs in the file, it will send a single error message per PID to std::cerr saying that it is skipping replays for that particular PID.

@davidbeckingsale, should we consider adding a new option to replay to tell it which PID to replay?  Something like -p or --pid PID#

This should be ready for review now.  The command line options look like:
$ ./bin/tools/replay -h
Replay an umpire session from a file
Usage:
  ./bin/tools/replay [OPTION...]

  -h, --help         Print help
  -i, --infile FILE  Input file created by Umpire library with
                     UMPIRE_REPLAY=On
  -u, --uid UID      The format of a REPLAY line begins with REPLAY,UID,...
                     This instructs replay to only replay items for the
                     specified UID.


Maximized windows using the title bar button are not remembered when using the "Move newly created windows to their last known zone" on Windows 10 (Enterprise LTSC/Server 2022)

Microsoft PowerToys version
0.70.1
Installation method
GitHub
Running as admin
No
Area(s) with issue?
FancyZones
Steps to reproduce
In Windows 10 (Enterprise LTSC/Server 2022 (21H2)), if you enable the option in "PowerToys" / "FancyZones" / "Move newly created windows to their last known zone", it won't remember if you put the window in full screen when you press the maximize title bar button.
Note: Snapping the window into full screen works with the mouse and remembers the window size when you reopen the application. When I tested it on my Windows 11 laptop, it worked correctly and remembered that the window was maximized.
Here's my PowerToys bug report file:
PowerToysReport_2023-06-20-16-02-14.zip
✔ Expected Behavior
Pressing the maximize button with "Move newly created windows to their last known zone" on remembers the window is maximized.
❌ Actual Behavior
Pressing the maximize button with "Move newly created windows to their last known zone" on forgets the window is maximized.
Other Software
No response

I see, I thought it was a bug, I guess it isn't a feature as of right now. Although it would be nice if the maximize button unsnaps the window so it gets remembered. For now, I can just unsnap the window and drag it to the top so it gets remembered as maximized. Should I close this and make a suggestion for this feature?


Support value_counts and plot in DC

Signed-off-by: shiyu22<EMAIL_ADDRESS>

#950

Codecov Report

Merging #964 (e3959e7) into main (7762932) will decrease coverage by 0.63%.
The diff coverage is 30.55%.

@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
- Coverage   69.04%   68.41%   -0.64%
==========================================
  Files         205      205
  Lines        9113     9146      +33
  Branches     1508     1518      +10
==========================================
- Hits         6292     6257      -35
- Misses       2388     2455      +67
- Partials      433      434       +1

Impacted Files
Coverage Δ

towhee/functional/mixins/display.py
54.23% <30.55%> (-34.23%)
:arrow_down:

towhee/functional/mixins/state.py
36.11% <0.00%> (-44.45%)
:arrow_down:

towhee/operator/stateful_operator.py
42.85% <0.00%> (-35.72%)
:arrow_down:

towhee/functional/mixins/metric.py
21.66% <0.00%> (-11.67%)
:arrow_down:

towhee/functional/mixins/parallel.py
48.01% <0.00%> (-3.09%)
:arrow_down:

towhee/hparam/hyperparameter.py
49.80% <0.00%> (-1.57%)
:arrow_down:

towhee/engine/factory.py
86.07% <0.00%> (-1.27%)
:arrow_down:

towhee/dataframe/dataframe.py
73.10% <0.00%> (-1.05%)
:arrow_down:

towhee/hub/file_manager.py
73.38% <0.00%> (+0.80%)
:arrow_up:

towhee/hub/repo_manager.py
81.08% <0.00%> (+0.90%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7762932...e3959e7. Read the comment docs.

Another PR #968


How to disable bash alert sound

I recently tried to disable the annoying alert sound (Windows Foreground.wav du-du-dunnn) of when e.g. I try to backspace on an empty line,  just for WSL bash but I couldn't.
I also tried to add to /etc/profile setterm -blength 0 but it didn't work.
I'd really like to turn off this sound in a Windows or Ubuntu way.

Hello! Please see this StackOverflow.com discussion for information on how to do so:
http://stackoverflow.com/questions/36724209/disable-beep-of-linux-bash-on-windows-10

Thanks! For now I just muted  the console via the windows mixer.

If you are using Windows Terminal, you can set "bellStyle": "none" in your profile defaults:
https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-5-release/#audible-bell-🔔

If you are using Windows Terminal, you can set "bellStyle": "none" in your profile defaults:
https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-5-release/#audible-bell-🔔

You can also edit it using the GUI. Navigate to Default->Advenced->Bell notification style, situated at the bottom of the page.

If you are using Windows Terminal, you can set "bellStyle": "none" in your profile defaults:
https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-5-release/#audible-bell-🔔

Just change line 21 on /etc/inputrc:
from:
# do not bell on tab-completion
# set bell-style none
# set bell-style visible

to:
# do not bell on tab-completion
set bell-style none
# set bell-style visible


Release/2024 01 25

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


bug: connect maas-anvil to dot-config-anvil slot during prepare_node script

MAAS Anvil cannot access $HOME/.config/anvil with the current prepare_node script. This PR provides such access.

@wyattrees Please sign and force push your commit in order to merge this PR. Thank you for the fix :slightly_smiling_face:


Use channel tag (color) more. Add topic tag

Fixes #227

You apparently reverted quite a lot :) I brought back your changes and reverted only the part I wanted reverted.


Floyd-Warshall : All pair shortest path algorithm in C++

I would like to implement this algorithm in C++ under GSSOC`21.

Hello @rudrakshi99 @dheerajkotwani @tarun26091999 @todi-2000 @geekquad @plazzy99
I am a GSSoC21 participant.
What I want to contribute :
My code will be in C++
The code will be commented for easy understanding, including 2 test cases
Please assign this issue to me.

Hey, I am Kanchan Jeswani, a GSSOC'21 participant.
I am a Competitive Programmer and C++ enthusiastic.
I would love to solve this problem using CPP with well-explained code and along with its time and space complexity.
Please assign me this issue.
Hope to hear from you.
Discord username  kanchan19#3152
@anubhavitis @dheerajkotwani @tarun26091999 @todi-2000 @geekquad @plazzy99 @rudrakshi99

@rudrakshi99 I have implemented the algorithm😁. Please review it and let me know the changes you want, if any.

Hi, I would like to add the Java Code for this Algorithm as a part of GSSOC'21. Please assign this to me.

I would like to add python code of this under Gssoc

I would like to contribute to the above problem in java as I am a participant of GSSOC'21. Kindly assign this to me.

@rudrakshi99 This issue has been resolved


clustermesh: Add an infrastructure for connect time parameter exchange and capability negotiation

Add a new kvstore object CiliumClusterConfig with path cilium/cluster-config/<cluster name>. The object is created per cluster by clustermesh-apiserver and obtained by cilium-agent at start-up time. The use cases of the objects are
Getting per-cluster parameter
ClusterMesh with overlapping PodCIDR support needs this for getting ClusterID on connect time and setup kvstore observers to annotate incoming objects with remote ClusterID. We can put such parameters to CiliumClusterConfig.
Capability negotiation and configuration validation
When there's a capability mismatch or configuration mismatch between clusters, we may not be able to connect those clusters correctly. Currently, we don't have any mechanism to check such a mismatch. With CiliumClusterConfig, we can check that on connect time. Currently, we only check ClusterID duplication but can add any capabilities/configuration in the future.
clustermesh: Add an infrastructure to connect time parameter exchange and capability negotiation

Ok, let me put it. Thanks for the heads up.

/test

Hitting known flakes
ci-l4lb: cilium-config-agent issue, need rebasing
ci-aks: cilium-config-agent issue, need rebasing
ci-eks: cilium-config-agent issue, need rebasing
ci-gke: https://github.com/cilium/cilium/issues/21652 (GKE IP exhaustion)
ci-multicluster: https://github.com/cilium/cilium/issues/21652 (GKE IP exhaustion)

/test

Failed tests
ci-aks: Seems like a new flake. Filed an issue https://github.com/cilium/cilium/issues/22681. See if retrying help.

/ci-aks

All tests are passed. Making this ready-to-merge.

Should @aanm become a member of @cilium/sig-clustermesh?


Add a comment about deserialization constructor

It shouldn't be used directly.

Or make them private.


ci-ipsec-upgrade: Drop no-missed-tail-calls exclusion

The issue got fixed by https://github.com/cilium/cilium/pull/29309.

/ci-ipsec-upgrade

@qmonnet I'm not sure about the v1.13 -> v1.12 downgrade, as the loader fix was backported only to v1.1{3,4}. Mind giving a go though?

Ah true we downgrade to 1.12 but the fix is not on that branch.
Yep I can still give it a try to see how it behaves.


refactor: correct types and lint [Badge]

Description

Correct types and lint
Rename badge.test.ts to Badge.test.ts

Related Issues
X
Tests
X
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] Run yarn test or yarn test -u if you need to update snapshot.
[x] Run yarn lint
[x] I am willing to follow-up on review comments in a timely manner.

@meohyun2 @jihu02 @meohyun2 @minji0345 It will help you how to refactor the Badge component.


Add parameters for isolation and parallelism

This enables you to change the default behaviour.

I've reverted that change because it broke the build. I'm currently working speeding up the local test matrix so that I apply feedback faster. Unfortunately life keeps me busy ;) This feature is still on the todo list

Fixing the code to let the tests pass (and updating the test a little bit) right now

Closed as we've merged #35
Thanks for the contribution.


Function for adding raw rgb data as an image

Hi. Thanks for this. Can I get you to run 'make format'? There are a couple of things that clang-format wants to shuffle around.


Arena ros

support visualising robot position and laserscan in Rviz
support stable-baseline package based on ros messages

using relative path is troublesome for ros. Therefore Cmake will set the absolute path of arena2d-sim package and automatically generate Environment.cpp. the original one will not be used.


[1.19] Forge breaking changes

Forges 41.0.64+ and 41.0.94+ introduce breaking changes for Uncrafter-1.19-1.1.1.

fixed in 5c7e8db


does not see any personal plan lessons that have not been purchased

What happened?
I signed up for a 1 week free trial personal plan membership and added one free and one personal plan course to the account
free course udemy.com/course/excel-dizi-formulleri/
personel plan course udemy.com/course/excelegitim/
downloaded the free course without any problems but gave an error while downloading the personal plan course
error
Failed request https://www.udemy.com/course/excelegitim/learn
[03:24:07] [udemy-downloader] [_get:1114] ERROR: 403 Forbidden, retrying (attempt 0 )...
When I query it via the API link below, it sees the free course but not the course for the personal plan.
https://www.[udemy.com/api-2.0/users/me/subscribed-courses?fields[course]=id,url,title,published_title&page=1&page_size=1000&ordering=-last_accessed,-access_time&search=excel-dizi-formulleri]

https://www.udemy.com/api-2.0/users/me/subscribed-courses?fields[course]=id,url,title,published_title&page=1&page_size=1000&ordering=-last_accessed,-access_time&search=excelegitim

Can you help me about this issue?
Expected Result
downloaded
Branch
Other (Enter below)
What operating systems are you seeing the problem on?
Windows
Relevant log output
No response
Other information
No response

because subscription courses are not owned by you... thats why the -sc option exists, use with --browser

because subscription courses are not owned by you... thats why the -sc option exists, use with --browser

py main.py -c https://www.udemy.com/course/excelegitim/learn --browser brave -sc
like this but still
Fetching course information, this may take a minute...
[03:35:01] [udemy-downloader] [_get:1113] ERROR: Failed request https://www.udemy.com/course/excelegitim/learn
[03:35:01] [udemy-downloader] [_get:1114] ERROR: 403 Forbidden, retrying (attempt 0 )...

because subscription courses are not owned by you... thats why the -sc option exists, use with --browser

py main.py -c https://www.udemy.com/course/excelegitim/learn --browser brave -sc
like this but still
Fetching course information, this may take a minute... [03:35:01] [udemy-downloader] [_get:1113] ERROR: Failed request https://www.udemy.com/course/excelegitim/learn [03:35:01] [udemy-downloader] [_get:1114] ERROR: 403 Forbidden, retrying (attempt 0 )...

are you logged in to udemy in brave? most likely you are being served a cloudflare challenge

because subscription courses are not owned by you... thats why the -sc option exists, use with --browser

py main.py -c https://www.udemy.com/course/excelegitim/learn --browser brave -sc
like this but still
Fetching course information, this may take a minute... [03:35:01] [udemy-downloader] [_get:1113] ERROR: Failed request https://www.udemy.com/course/excelegitim/learn [03:35:01] [udemy-downloader] [_get:1114] ERROR: 403 Forbidden, retrying (attempt 0 )...

are you logged in to udemy in brave? most likely you are being served a cloudflare challenge

Yes, I logged in, it downloads the purchased courses, but if it's because of cloudflare, shouldn't it download them too?


cargo-feature: 0.5.2 -> 0.5.3

Motivation for this change
Bump version
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 139500 run on x86_64-linux 1

1 package built:

cargo-feature


[Bug - next-pwa]: Having a hard time deploying to production

Provide environment information
"@ducanh2912/next-pwa": "^10.1.0",
"next": "latest",
"next-compose-plugins": "^2.2.1",
"next-contentlayer": "0.3.4",
Link to reproduction - Issues with a link to complete (but minimal) reproduction code help us address them faster
https://github.com/mubarakone/tailwind-css-starter-blog
To reproduce
Deploying to Vercel
Describe the bug
When I deploy for production, the PWA install icon does not show up on the address bar. And when I ran Lighthouse, the PWA was not installable because the manifest.json file wasn't recognizable.
Then when I checked the logs on Vercel, I see that the manifest.json was recognized, but it came with these 401 Unauthorized warning errors.

So I looked to the docs, and found a potential solution:

I didn't specify where, but judging by the syntax, I figured it would be located in the next.config.js file rather than manifest.json. When I implemented this, it looks like it doesn't recognize this:

But after some modifications, it is now looking much better:

However when I try to run on dev environment, I get this:
  ▲ Next.js 14.0.4
   - Local:        http://localhost:3000

 ✓ (pwa) Compiling for server...
 ✓ (pwa) Compiling for server...
 ✓ (pwa) Compiling for client (static)...
 ○ (pwa) Service worker: C:\Users\mubar\Documents\1to1 next app\zerodev-test\tailwind-css-starter-blog\public\sw.js
 ○ (pwa)   URL: /sw.js
 ○ (pwa)   Scope: /
 ○ (pwa) Building in development mode, caching and precaching are disabled for the most part. This means that offline support is disabled, but you can continue developing other functions in service worker.
Warning: Contentlayer might not work as expected on Windows
 ⨯ Please check your GenerateSW plugin configuration:
[WebpackGenerateSW] '0' property is not expected to be here.
 ⨯ Please check your GenerateSW plugin configuration:
[WebpackGenerateSW] '0' property is not expected to be here.
 ✓ Ready in 8.7s
Contentlayer config change detected. Updating type definitions and data...
successCallback C:/Users/mubar/Documents/1to1 next app/zerodev-test/tailwind-css-starter-blog/.contentlayer
SuccessCallbackError: Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'
 ○ Compiling / ...
 ⨯ Please check your GenerateSW plugin configuration:
[WebpackGenerateSW] '0' property is not expected to be here.
 ✓ (pwa) Compiling for client (static)...
 ○ (pwa) Service worker: C:\Users\mubar\Documents\1to1 next app\zerodev-test\tailwind-css-starter-blog\public\sw.js
 ○ (pwa)   URL: /sw.js
 ○ (pwa)   Scope: /
 ○ (pwa) Building in development mode, caching and precaching are disabled for the most part. This means that offline support is disabled, but you can continue developing other functions in service worker.
 ⨯ Please check your GenerateSW plugin configuration:
[WebpackGenerateSW] '0' property is not expected to be here.
 ⨯ Please check your GenerateSW plugin configuration:
[WebpackGenerateSW] '0' property is not expected to be here.
 ⨯ Error: ENOENT: no such file or directory, open 'C:\Users\mubar\Documents\1to1 next app\zerodev-test\tailwind-css-starter-blog\.next\fallback-build-manifest.json'
    at readFileSync (node:fs:453:20)
    at loadManifest (C:\Users\mubar\Documents\1to1 next app\zerodev-test\tailwind-css-starter-blog\node_modules\next\src\server\load-manifest.ts:12:43)
    at loadManifestWithRetries (C:\Users\mubar\Documents\1to1 next app\zerodev-test\tailwind-css-starter-blog\node_modules\next\src\server\load-components.ts:75:26)
    at loadDefaultErrorComponentsImpl (C:\Users\mubar\Documents\1to1 next app\zerodev-test\tailwind-css-starter-blog\node_modules\next\src\server\load-default-error-components.ts:66:20)
    at DevServer.getFallbackErrorComponents (C:\Users\mubar\Documents\1to1 next app\zerodev-test\tailwind-css-starter-blog\node_modules\next\src\server\dev\next-dev-server.ts:838:12)
    at DevServer.renderErrorToResponseImpl (C:\Users\mubar\Documents\1to1 next app\zerodev-test\tailwind-css-starter-blog\node_modules\next\src\server\base-server.ts:3363:34)
    at DevServer.renderToResponseImpl (C:\Users\mubar\Documents\1to1 next app\zerodev-test\tailwind-css-starter-blog\node_modules\next\src\server\base-server.ts:3096:24)
    at DevServer.pipeImpl (C:\Users\mubar\Documents\1to1 next app\zerodev-test\tailwind-css-starter-blog\node_modules\next\src\server\base-server.ts:1568:21)
    at DevServer.NextNodeServer.handleCatchallRenderRequest (C:\Users\mubar\Documents\1to1 next app\zerodev-test\tailwind-css-starter-blog\node_modules\next\src\server\next-server.ts:946:7)
    at DevServer.handleRequestImpl (C:\Users\mubar\Documents\1to1 next app\zerodev-test\tailwind-css-starter-blog\node_modules\next\src\server\base-server.ts:1353:9) {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'open',
  path: 'C:\\Users\\mubar\\Documents\\1to1 next app\\zerodev-test\\tailwind-css-starter-blog\\.next\\fallback-build-manifest.json'
}

Of course the project also fails to build for production as well
Expected behavior
Both dev and prod environment should work.
Screenshots (if relevant)
No response
Additional information (if relevant)
No response

Just ask yourself if you even know JavaScript.
Also that's not even related to the original issue.

@DuCanhGH you didn't need to be rude.
@mubarakone update your next.config.js as following:
const withPWA = require('@ducanh2912/next-pwa').default({
  dest: "public",
  workboxOptions: {
    mode: "production"
  }
})

@maverickdude I didn't have to be rude, and I was wrongly so nonetheless, but I don't regret that at all. Usually I do tolerate questions that make next to no sense, but this one was just too bad, and I was under a shitty fever that day. Quite a nice combination, I'd say.
First thing first, let's look at how they handled the case. Their first reaction to a 401 HTTP response was like this must have been caused by next-pwa?? Like why would it authenticate something? Usually, a cached response is a success one and wouldn't be an 401 one. Then, they turned to the docs. Cool, that was a nice move. But I just couldn't fathom how they came up with the idea that making Workbox run in production mode, which is the default when you deploy anyway, would fix their issue. Then they tried to do it. Now this is what triggered me the most. Why would a developer who have begun building a product think that workboxOptions.mode is a valid JS object key? I mean, I wouldn't have blamed them had they tried "workboxOptions.mode", since one could interpret the docs that way too, but they turned to removing .mode altogether. That was enough to push me over the edge. The validation error from Workbox was cryptic, however, so that wasn't really their issue.
Again, I could've been nicer, but that wouldn't be something I would expect from a bad-tempered guy under a fever.


querydsl-root POM changes

As querydsl-root's parent is 'mysema-source', it inherits its properties.
This means that the <organisation> of Querydsl is still 'Mysema Ltd'.
It should be a better idea to replace (or eliminate) 'mysema-source' as parent.

Maybe com.querydsl:querydsl-parent as a separate github project could work.

Just a few more ideas for the common parent:

unify the test configuration
probably look at including TravisFoldListener in some way?
code style checks

anything else?

What do you think about moving the contents of querydsl-root into the root directory of the project?
That seems to be the generally-accepted way of configuring a multi-module project but it does result in a more cluttered root directory.

@johnktims Moving the root to the root of the project is fine with me. But preferably only on the master side, not backport. @Shredder121 What do you think?

@timowest Just your opinion, why not on the backport?
In my opinion this makes it better to support the development platforms that silently support only the common practice. (various cloud IDEs I tried don't like it when there is 'no pom.xml' and generate one for you..)
So I think this is better. It also means we don't have an (almost) empty GitHub repository only for the parent root.

Yes, technically backwards compatibility is preserved, so the backport should be ok as well then

If you have an opinion, you can share it of course.

I'd like to keep the changes to the QUERYDSL_3 branch under the surface, on the other hand we agreed that backwards compatible changes should be applied there. So I am trying to be consistent and agree with you ;)

So to move this along, we can backport it now?

I'll backport #1270 and my documentation fixes as soon as I get home.

That is fine.


Please update the material font version

Are you planning to upgrade the material icons? I'm trying to use icons from https://material.io/resources/icons/?style=baseline that do not work with the old version.

Seems material-icons package was not updated for a while, but we could switch to https://www.npmjs.com/package/material-design-icons-iconfont

that the great!

Thanks! I'm a viewflow pro owner.  Looking forward to the new version.

1.6.7 released


XDM Support for Chatbot Experience Event Schemas

The current XDM schemas are not sufficiently expressive to represent the events emitted during chat interactions between brands and customers. We propose the creation of a new set of generic chat experience event schemas to represent such interactions.
What are the schemas that are affected by the issue
There are no existing schemas affected - the issue here is that there are no schemas that exist to represent a stream of events that are emitted from a chatbot and/or livechat experience.
What are examples of products that are impacted by the issue
Our chat automation platform, Stackchat, needs to send events to AEP as part of a client project. These types of events are defined here. On the recommendation of Adobe employee Wouter Van Geluwe (@woutervangeluwe ), we propose creating a set of generic chat experience event schemas that are common to all chat experiences across all third-party chat platforms.
Any chat platform will need to send to AEP both experience events & profile attributes. We plan to fork the XDM repo and raise a PR to add the new chat experience event schemas. We will use the existing profile schema for any user profile data.
As a business, we've invested considerable time and resources in defining how chat data should be represented and shared between external systems, as can be seen in our existing third-party integrations, such as with Adobe Analytics and Segment. As a thought leader in the space, we're well placed to lead this effort and are looking to the XDM team to provide their blessing for us to proceed.

@cmathis
@khanna-vikas
@lrosenthol
@prabhum2
Can you please give your blessing for us to go ahead and fork the XDM repo and begin work on this issue?

There is no need to fork the repo...just go ahead and create a branch with your changes and when ready raise the PR for us to review.
If you'd like our input along the way, feel free to ask...
Most important think to remember as you design your schemas is "don't reinvent the wheel"..If there is a schema or even a few members/keys of that schema that meet your need - use them. Also, any other 3rd party schemas that exist and can be leveraged (eg. DublinCore, Schema.org, etc.) should also be looked at as well.


[Bug]: Server not starting after upgrading from v4.0.0-beta.309 to v4.0.0-beta.310

Description
Server doesn't restart after upgrading from v4.0.0-beta.309 to v4.0.0-beta.310
Minimal Reproduction (if possible, example repository)
I created the server via the installation script, configured the domain, added a few users and then clicked upgrade.
Exception or Error
  2024-07-12 09:07:35 App\Jobs\CleanupHelperContainersJob ............ RUNNING
  2024-07-12 09:07:35 App\Jobs\CleanupHelperContainersJob ...... 227.39ms DONE
  2024-07-12 09:08:00 Running [App\Jobs\CleanupInstanceStuffsJob]  9.73ms DONE
  2024-07-12 09:08:00 Running [App\Jobs\ContainerStatusJob] ...... 1.33ms DONE
  2024-07-12 09:08:00 Running [App\Jobs\ServerStatusJob] ......... 1.19ms DONE
  2024-07-12 09:08:00 Running ['artisan' uploads:clear] ........ 314.75ms DONE
  ⇂ '/usr/bin/php8.2' 'artisan' uploads:clear > '/dev/null' 2>&1

  2024-07-12 09:08:01 App\Jobs\CleanupInstanceStuffsJob .............. RUNNING
  2024-07-12 09:08:01 App\Jobs\CleanupInstanceStuffsJob ......... 47.61ms DONE
  2024-07-12 09:08:01 App\Jobs\ContainerStatusJob .................... RUNNING
  2024-07-12 09:08:02 App\Jobs\ServerStatusJob ....................... RUNNING
  2024-07-12 09:08:02 App\Jobs\ServerStatusJob .................. 50.35ms DONE
  2024-07-12 09:08:02 App\Jobs\ServerStatusJob ....................... RUNNING
  2024-07-12 09:08:02 App\Jobs\ServerStatusJob ................... 3.88ms DONE
  2024-07-12 09:08:02 App\Jobs\ServerStatusJob ....................... RUNNING
  2024-07-12 09:08:02 App\Jobs\ServerStatusJob ................... 3.61ms DONE
  2024-07-12 09:08:02 App\Jobs\ServerStatusJob ....................... RUNNING
  2024-07-12 09:08:02 App\Jobs\ServerStatusJob ................... 6.25ms FAIL

Version
v4.0.0-beta.310

Can you please execute the installation script manually curl -fsSL https://cdn.coollabs.io/coolify/install.sh | bash ?

A bug has been fixed in v313. Please update or reopen this issue if it does not solve your problem.


SpecEd hands on upload of 12MB presentation

I can upload this presentation at https://plot.ly/organize/
But it does not seem to upload through SpecEd:

I couldn't open Dev Tools through Alt-Ctrl-i, so I don't have much insight into why this might be 😞
My only guess is that this presentation is much larger than other ones that I've successfully uploaded through SpecEd (12 MB).
In any case, it would be great to have an error message if the upload fails, or some type of status indicator that the upload is occurring for large files.
Here is how the presentation looks on Plotly:
https://plot.ly/~jackp/16661
aircheck.json.zip

The response from the API POST is 413:
POST https://api.plot.ly/v2/spectacle-presentations 413 (REQUEST ENTITY TOO LARGE)
This would likely need to be a server/api configuration change.

Yep - this is on our end. @tarzzz can we change this to something a little bigger? I imagine a large part of their size is the encoded thumbnails?

We'll increase the limit, but note that this is also a Spectacle issue.  They need to check if their requests are successful, because all sorts of things could go wrong (user hits a limit in their Plotly account, user isn't signed in to Plotly correctly, user's Internet connection is terrible, etc...)

Suggested Spectacle fix: Error message should be consistent with the cause of the error.


Fix to failed to find unique target for patch

Versions of Argo workflows after v3.3.4 appear to have a namespace added to their install.yaml resources (see https://github.com/argoproj/argo-workflows/pull/8280 and https://github.com/argoproj/argo-workflows/issues/8250#issuecomment-1084046919), with causes an error when kustomization tries to apply updates:
ComparisonError  rpc error: code = Unknown desc = Manifest generation error (cached): `kustomize build /tmp/https___github.com_climateimpactlab_downscalecmip6/infrastructure/kubernetes-gcp/argo` failed exit status 1: Error: no matches for Id ~G_v1_ConfigMap|~X|workflow-controller-configmap; failed to find unique target for patch ~G_v1_ConfigMap|workflow-controller-configmap  2022-06-02 18:16:15 -0700 PDT

This might relate to a bug in customization (see https://github.com/kubernetes-sigs/kustomize/issues/1332).
So we're specifying the namespace in the install.yaml resource when defining the patch for the customization with the hopes that it will be able to find its target.

[ ] closes #xxxx
[ ] tests added / passed
[ ] docs reflect changes
[ ] passes flake8 downscale tests docs
[ ] entry in HISTORY.rst

[summarize your pull request here]

Nope, this doesn't get it completely. Need to try something else.


Update sbt-scalajs, scalajs-compiler, ... to 1.13.1

About this PR
📦 Updates

org.scala-js:sbt-scalajs
org.scala-js:scalajs-compiler
org.scala-js:scalajs-library
org.scala-js:scalajs-test-bridge

from 1.3.1 to 1.13.1
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-js" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-js" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #341.

Superseded by #347.


Fix BeanFactoryFunctionCatalog initialization when a BeanFactoryPostProcessor

that depends on FunctionCatalog is present.
On application context refresh, BeanFactoryPostProcessors are
invoked before registering BeanPostProcessor(s).
If a BeanFactoryPostProcessor that depends on FunctionCatalog is present,
then when ContextFunctionCatalogAutoConfiguration tries to fetch
all functional beans (Function/Supplier/Consumer), the creation of beans
where no default constructor exists fails as
AutowiredAnnotationBeanPostProcessor hasn't been registered yet.
Initializing BeanFactoryFunctionCatalog on using SmartInitializingSingleton
delays the collection of functional beans to an even later point in
the lifecycle.
fixes #352

@Walliee First of all thank you for the contribution!
Now, just an FYI, if you look at the commit history it used to be SmartInitializingSingleton, but we had to change it as it was causing another issue in spring-cloud-stream (too long to explain).
With that said, there was another thing that we were discussing for a while and that is #355 and this issue and your PR kind of made us do it now as it both fixed the issue reported by you as well as enhanced the framework in generally. So kind of a win win!

That's great! Thanks for providing the context and the proper fix.


Fix #67

Coverage remained the same at 80.779% when pulling 6b3485638a11f4afbbdc35ef94e9a858f1e4d9eb on jfilo:upstream-issue-67 into d95406d2371aedd3898a30759acf0d2276253454 on tbeu:master.

Coverage remained the same at 80.779% when pulling 6b3485638a11f4afbbdc35ef94e9a858f1e4d9eb on jfilo:upstream-issue-67 into d95406d2371aedd3898a30759acf0d2276253454 on tbeu:master.

Coverage remained the same at 80.779% when pulling 6b3485638a11f4afbbdc35ef94e9a858f1e4d9eb on jfilo:upstream-issue-67 into d95406d2371aedd3898a30759acf0d2276253454 on tbeu:master.


Chat observations not working?

I specify <ObservationFromChat/> and <ChatCommand/> in my XML specification. I receive chat observations of the form "Chat":[].
The problem is that the array is always empty. I cannot see the countdown messages sent by the server, nor do I see echos of my own messages sent throught the chat command. All of these messages appear in the game window, therefore I was expecting to observe them, too. Is this intended behavior or maybe a bug?

The timer countdown messages aren't sent through the chat channel, they are printed directly to the screen, so I wouldn't expect them to appear in the chat observation. If this behaviour is something you'd like to see changed, feel free to add a feature request, but I think it's good to avoid polluting the chat with the timer messages.
As for not being able to see echoes of your own messages, I've not been able to reproduce this behaviour. "Works for me", as they say... is it still an issue with your code? If so, we'll need some more details in order to track it down.

Thanks for the clarification on the countdown. I'll close this for now.


Various updates (see description)

Adds a changelog
Fixes stitch menu logic
Removes four corners button
Changes stitch menu from vertical to horizontal. This one is the most controversial. I think that menu lends itself better to horizontal layout than vertical layout. I also provided an 'X' button to hide it easily. I'd like to know your thoughts on it. It will auto-hide when the main menu is also hidden.
Updates a few css transition/colors to be a bit cleaner

Did not implement:

Auto-hide buttons after a few seconds. I will add that as a commit if you are ok with the rest of the changes. I didn't want to get too far without getting approval for the horizontal menu first.

Looks awesome! The horizontal menu is especially nice now that the pdf is centred by default.

I'm going to comment here and say that auto-hide might take me awhile. This branch should be in a stable enough state for merge into beta as-is. I'd hate to see other features not release because we are waiting on auto-hide. I'm contemplating even branching to a new branch for auto-hide and pushing it up here in case someone else wants to take a crack at it. I'm running into performance issues that are going to take time to debug (as @j-huff discovered with his issue with the mouse auto-hide).

Okie doke, thank you for letting me know! My toddler had a fever for a couple of days so I've been running off very little sleep and free time. I'm going to try to pull together this release today/tomorrow!

Okie doke, thank you for letting me know! My toddler had a fever for a couple of days so I've been running off very little sleep and free time. I'm going to try to pull together this release today/tomorrow!

Oh no! I hope your little one feels better soon! I feel you on the free time part. I don't think I've opened up the project since Saturday. I'm loving all the activity going on in the project right now - but I feel quite behind on what's going on!

Merged into #158 :)


[🐛] After capturing photo or selecting image from library not returning to the component it was called.

Description
After launching the camera with launchCamera() function when then photo is taken and tick mark clicked, it does not take me to the component from where it was called rater than the App gets reload. Same thing happens when I use launchImageLibrary() function.
There is no log shown. Immediately the app gets reloaded
Solution
What needs to be done to address this issue?
Additional Information

Image Picker version: [^3.2.1]
React Native version: [0.63.4]
Platform: [Android]
Development Operating System: [Linux]
Dev tools: buildToolsVersion = "29.0.2"
minSdkVersion = 21
compileSdkVersion = 29
targetSdkVersion = 29

Same here It works normal on many devices but some devices keep getting this

duplicate #1502


Fix issue #32: correctly detect content type if utf-8

@bxjx Thanks for submitting this! Would you mind dropping the version bump from the PR?

Thanks @codealchemy! Sorry about version bump. Didn't mean to pop that on that branch.


[$250] [Workspace Feeds] App crashes after creating new WS and selecting start over

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Unable to validate in Prod because of Bank Setup
Issue reported by: Applause Internal Team
Action Performed:

Open the app and log in
Create a workspace
Navigate to More features and enable Expensify card
Tap Issue new card > select Connect online with Plaid and add VBA
Create a new workspace and enable Expensify card in More features
Tap Issue new card > + Add a new bank account and select Start over

Expected Result:
The options to add a bank account using Plaid or entering manually are displayed
Actual Result:
The app crashes
Workaround:
Unknown
Platforms:

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
1909_1.txt
https://github.com/user-attachments/assets/3f86ea4b-522f-4f8e-bbe8-f0d74066cb52

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021836823617385889668
Upwork Job ID:<PHONE_NUMBER>385889668
Last Price Increase: 2024-09-19

Issue OwnerCurrent Issue Owner: @

We think that this bug might be related to #wave-collect - Release 2

I'm just trying to figure out why this isn't testable in prod.

Unable to validate in Prod because of Bank Setup

@IuliiaHerets is it possible to test in prod with a different account? Or is this due to product functionality not being available?

Probably because the Plaid sandbox that loads for the test VBBA credentials only works on staging or something.

I can investigate this issue

Please do though, @koko57!

waiting for my android builds... On the web I don't see the problem after clicking "Start over". But I think we shouldn't show the "Start over" option as we already added an account, especially for a new workspace, am I right?

I can sheppard this one, its definitely weird. in web there would probably be some console error.

Able to reproduce this issue
email used<EMAIL_ADDRESS>(Precondition: New account)
Device details:  Pixel 6 / Android 14
https://github.com/user-attachments/assets/d49e3634-781d-49cf-a93f-aa709d7ecf2d

I think it will be this crashlog
 Fatal Exception: com.facebook.react.common.JavascriptException: Error: Missing bankAccountID when attempting to reset free plan bank account, js engine: hermes, stack:
resetFreePlanBankAccount@1:5269051
t5@1:8671650
t16@1:4785522
onPress@1:4245614
t23@1:4218512
anonymous@1:4219664
_performTransitionSideEffects@1:791974
_receiveSignal@1:791562
onResponderRelease@1:790391
executeDispatch@1:1250761
executeDispatchesAndReleaseTopLevel@1:1256047
forEachAccumulated@1:1252277
anonymous@1:1256485
batchedUpdatesImpl@1:1317425
batchedUpdates$1@1:1255971
dispatchEvent@1:1256250

       at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.java:65)
       at com.facebook.jni.NativeRunnable.run(NativeRunnable.java)
       at android.os.Handler.handleCallback(Handler.java:959)
       at android.os.Handler.dispatchMessage(Handler.java:100)
       at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
       at android.os.Looper.loopOnce(Looper.java:232)
       at android.os.Looper.loop(Looper.java:317)
       at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:235)
       at java.lang.Thread.run(Thread.java:1012)

To me this seems like something that exists on prod and the root cause is likely that we’re just passing ONYXKEYS.REIMBURSEMENT_ACCOUNT here even though it’s null or outdated

Confirmed that's the root cause by testing starting one without plaid flow

Overview of Solution:
We need to store some identifier key for the bank account as well (policy#, accountID, etc) so we can ensure that we're not using stale bank account data from a different flow
cc @BrtqKr as you implemented the original key

Demoting, because the above test was done on prod :)

This still External?

@grgia @mountiny but anyway, shouldn't we show a new VBBA page instead of Continue modal for a new workspace?

If we had a bankAccountID and we would choose "Start over" will it conflict with adding the account for the previous workspace?

@shawnborton I could have sworn there was a version of this that has a section at the bottom that says "Use existing account" that lists any VBBA the admin has added to their account can be selected to use. Am I making that up? 🤔

I tried to reproduce it once again and I was able to reproduce it on web.

I noticed that first we set shouldShowContinueSetupButton to true here https://github.com/Expensify/App/blob/d009d8ed4830c7d0562c524c991b8a688e2b4869/src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx#L208
because getShouldShowContinueSetupButtonInitialValue returns true, but in the meantime we send OpenReimbursementAccountPage request and we end up with this data
, but the page doesn't rerender to show the new VBBA flow page but the Continue modal is still there.
So as we don't have bankAccountID there we end up throwing this error https://github.com/Expensify/App/blob/d009d8ed4830c7d0562c524c991b8a688e2b4869/src/libs/actions/ReimbursementAccount/resetFreePlanBankAccount.ts#L22
Maybe we should handle this error differently though?

Am I making that up? 🤔

That sounds really familiar to me too, I could have sworn that was the case as well.

I could have sworn there was a version of this that has a section at the bottom that says "Use existing account" that lists any VBBA the admin has added to their account can be selected to use. Am I making that up? 🤔

Yeah same there should be a list of eligible bank accounts to pick from. @koko57 can you please share how the bank account data looks like when you try to issue the card on a new policy? Is the VBBA added for the first policy considered as eligible (is it OPEN state). Maybe that is why it's showing the "continue setup" as the bank account is not in the open state ready fro reimbursements

@mountiny no I think the problem here is with what I mentioned earlier - shouldShowContinueSetupButton is set using the data for the previous policy, but as in URL we have 'new' step the OpenReimbursementAccountPage is fired and the response overwrites the old data - we no longer have full achData for the reimbursement account. I think it would be good to add a check if the policyID from achData matches policyID from the URL - if not we can start a fresh new setup flow.
But now a question - is it ok that we're clearing the reimbursementAccount data?

From what I understand, the REIMBURSEMENT_ACCOUNT key is used during the bank account setup, right that suggests it makes sense that it's overwritten if we enter the new flow.
We had this mock

but in that case, it's about the same workspace.
In this bug, we are discussing two different workspaces, so we are adding the bank account to the new workspace.
So in that case it makes sense to clear the flow and start over

Overall whatever we will decide on this edge case I think that adding the check for the policyID will solve the problem, wdyt @trjExpensify @mountiny @grgia?

I think it would be good to add a check if the policyID from achData matches policyID from the URL - if not we can start a fresh new setup flow.

Lets try that and test out if we find some regressions

I'm working on implementing the logic here - I thought that this check would be an one-liner, but currently used logic is more convoluted than I thought and I need to take care of other things to make this work properly.

Ok, so it's actually nice - if we start the flow go to the other workspace the data for the reimbursement account will be overwritten, but if we go back to the first workspace we will get the correct data for what we left off for this workspace thanks to OpenReimbursementAccountPage call. I still need to tinker a bit with conditions and initial setup for ReimbursementAccountPage but I'm getting close to opening the PR for this issue.

I just need a confirmation here - is it ok that for a newly created Workspace OpenReimbursementAccountPage returns 'plaid' as a substep?

Seems like I need to rewrite ReimbursementAccountPage logic a bit to suit our current needs, for now the changes I thought would be sufficient don't test well in all the cases.

One question though - I started the VBBA flow with Plaid then left it at Personal Info step (What's your legal name?), when I returned to the flow I got this response from OpenReimbursementAccountPage - the substep was "manual" and the currentStep was "BankAccountStep" although before leaving the flow it was saved as "plaid" and "RequestorStep" in reimbursementAccount. Is this expected?

Does not sound expected to me @nkuoch do you know if this should have been saved after selecting the plaid option?

@mountiny @nkuoch I will also check if we're sending the request properly - I've noticed today that we're sometimes sending it with the old data.

ok, we're sending BankAccountStep as a step (should we do that? shouldn't we send RequestorStep instead if we've finished the BankAccountStep earlier?)
but we're also sending "plaid" subStep but we get "manual" in the response

Can we bring this convo to the thread to align faster and keep this moving?

It seems very strange to be changing to manual when plaid was initially chosen.

I believe it's not a bug. It's because when coming back, I believe we have no way to display the plaid selection without them trying to log in back to Plaid. So we just show the user the account numbers retrieved from Plaid. Also, even if it's shown as manual, logic wise back end side, we still consider it as added as Plaid, as we still have the plaidAccessToken

ok, but what if the user changes the numbers in the manual page? And if this step was done what's the point to show BankAccountStep when returning to flow? Maybe we could show the user the step from what they left off (RequestorStep) but enable them to go back to BankAccountStep with manual setup flow?

They shouldn't be able to edit the numbers. Fields should be disabled. And we also prevent it backend side

Maybe we could show the user the step from what they left off (RequestorStep) but enable them to go back to BankAccountStep with manual setup flow?

I'll check - No need to block on it though.

They shouldn't be able to edit the numbers. Fields should be disabled. And we also prevent it backend side

Ok, thanks, so I'm adding another thing to the todo list - for now we have the fields enabled.

I think I finally have the working solution, but now I need to test it thoroughly and disable the inputs for the manual step that Nathalie mentioned

I've found another problem today - when I start the flow for Workspace A, leave it at, let's say company step (Personal Info aka RequestorStep all filled - in) and then I start the flow for the Workspace B (no VBBA before) - After I get through plaid step, I choose the same bank account and I proceed to Personal Info step I get all the data from the previous workspace. Is this intentional?

yes it's intentional

I think I've finally got it right 😭 PR ready for review https://github.com/Expensify/App/pull/49687

Relinking Job post here — https://www.upwork.com/ab/applicants/1836823617385889668/job-details — since it got buried above

@CortneyOfstad The checklist isn't required here
@mountiny Is the payment handled on the project or independently here?

@strepanier03 I am heading OoO (10/15 to 10/23), so got this reassigned to keep it moving! Payment is due 10/16 and @DylanDylann is owed $250 👍
Per the comment here — checklist is not needed!

We can handle this separately

250 to @DylanDylann

@CortneyOfstad Bump on payment

Finished up the payment for @DylanDylann. Closing out 👋

Reopening for @DylanDylann and @CortneyOfstad to complete the regression checklist.

@mountiny Did we include this regression test on project overall?

I think this is a niche flow that would not make sense to create a regression test for Applause to run through with every test. Can you complete the rest of the checklist please?

I'm back from OoO (thanks @strepanier03 for holding down the fort!)

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: It more like a new improvement
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. No
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Do we agree 👍 or 👎

Looks good @DylanDylann! Thanks!


Mast: Watch minhaconexao.net.br

Mast requests the watch of the watch_keyword minhaconexao\.net\.br. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

minhaconexao\.net\.br has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Daniil in Charcoal HQ