node's outbound count of internet connections too high

To reproduce
$ scope launch
1c41ae18a677d54463e23e3adc5e63516b7409688634db79a9d8df5dcc9d635e
Weave Scope is reachable at the following URL(s):
  [...]
$ google-chrome http://localhost:4040
$ docker run --rm --name=foo -ti alpine /bin/sh
/ # IP=$(getent hosts cloud.weave.works | cut -d ' ' -f 1)
/ # echo $IP
<IP_ADDRESS>
/ # nc $IP 80

Wait for the 'foo' container and connection to the Internet node to show up in scope and then bring up the details panel on the 'foo' node. You should see something like

Notice that it says there are two connections from the node to the Internet, when in reality there is only one.
This doesn't happen all the time, unfortunately, though right now for me it happens more often than not. Sometimes I initially see a count of 1 and it then increases to 2. And then sometimes it drops back to 1.

I ran into this in the process of investigating #1495. The fix for that in #1843 doesn't cure this issue but has the effect that the Internet node details panel too shows a count of 2. At least it's wrong consistently.

I've added some instrumentation to detailed.outgoingConnectionsSummary. This reveals that the 'foo' container node has exactly one adjacent node, "out-theinternet". So far so good. However, it has two local endpoints: ";<IP_ADDRESS>;39120" and "xps;<IP_ADDRESS>;39120". The former is my host's WLAN IP, the latter is the container's docker-assigned IP. And the adjacency of both these endpoints apparently contains the ";<IP_ADDRESS>;80" endpoint. Hence it is counted twice.
@paulbellamy I'd appreciate a clue as to whether the data is wrong (e.g. the 'foo' container should only have one local endpoint, or only one of the two endpoint's adjacency should have an intersection with the "out-theinternet" remotes), or the algorithm (i.e. we are missing some additional filtering).

I would have expected probe/endpoint/nat.go to have handled that, and converted the first endpoint to the second (or the other way, maybe)

nat.go does no such thing, AFAICT; it simply adds extra endpoints.
Note that the count is wrong in the process topology too, i.e. in the above example the Internet node in the process topology shows the 'nc' process as having two connections.

I've looked into this some more. The 2nd endpoint is definitely added by natMapper.applyNAT, and since that copies the original endpoint, the edge/adjacency gets copied too.
We could detect such duplicate edges in the renderer, since the 2nd endpoint has a copy_of reference to the original endpoint. But to me that seems wrong - there is just one connection here, so surely there should only be one edge. Or am I reading too much into the semantics of edges / adjacency in scope?
@tomwilkie @peterbourgon you wrote/discussed this code, and the decision to copy endpoints was made in https://github.com/weaveworks/scope/issues/245#issuecomment-113821171. Edges aren't mentioned explicitly, though it does talk about copying metadata. So is the edge duplication an intended outcome?
The alternative here would be to "move" the edge from the original to the copied node. But that is a non-monotonic operation, which I am guessing is bad.

While I discussed the implementation, the code is all @tomwilkie IIRC.

While I discussed the implementation, the code is all @tomwilkie IIRC.

Yep, I am aware of that. However, AFAICT the implementation is very much a reflection of the design, for which there was some back-and-forth between you and tom.

From what I can read and remember, the code in question copied endpoints (nodes) but gave them different identifiers. That necessarily means duplicate edges; edges are defined in terms of nodes. So in that sense it was an intended outcome, though likely one that wasn't going to be noticed, because edge coalescing is a thing that happens, both in the merge steps in the backend as well as (IIRC) the UI.

Here's how to get a triple count:

desktop$ scope launch
vmhost1$ scope launch --no-app $DESKTOP_IP
desktop$ docker run -p 1122:1122 --rm -ti alpine nc -l -p 1122
vmhost1$ docker run --rm -ti alpine nc $DESKTOP_IP:1122

conntrack shows the following entries:

desktop: tcp      6 428551 ESTABLISHED src=<IP_ADDRESS> dst=<IP_ADDRESS> sport=41277 dport=1122 src=<IP_ADDRESS> dst=<IP_ADDRESS> sport=1122 dport=41277 [ASSURED] mark=0 use=1
vmhost1: tcp      6 431669 ESTABLISHED src=<IP_ADDRESS> dst=<IP_ADDRESS> sport=41277 dport=1122 src=<IP_ADDRESS> dst=<IP_ADDRESS> sport=1122 dport=41277 [ASSURED] mark=0 use=1

where

<IP_ADDRESS> is the desktop IP
<IP_ADDRESS> is the vmhost1 IP
<IP_ADDRESS> is the desktop container IP
<IP_ADDRESS> is the vmhost1 container IP (I cheated here and started a bunch of other containers first so the IP would be distinct from the desktop container IP and hence easier to track)

The report contains the following endpoints and associated edges

desktop;<IP_ADDRESS>;1122
;<IP_ADDRESS>;1122

copy_of desktop;<IP_ADDRESS>;1122

vmhost1;<IP_ADDRESS>;41277 -> ;<IP_ADDRESS>;1122
;<IP_ADDRESS>;41277   -> [;<IP_ADDRESS>;1122, desktop;<IP_ADDRESS>;1122]

copy_of vmhost1;<IP_ADDRESS>;41277

I am guessing the first two endpoints get associated with the desktop container, and the last two with the vmhost1 container.

@2opremio suggested simply dropping the copy endpoints in MapEndpoint2Process, but if we do that in the above then we are left with:

desktop container having endpoint desktop;<IP_ADDRESS>;1122
vmhost1 container having endpoint vmhost1;<IP_ADDRESS>;41277 -> ;<IP_ADDRESS>;1122

which leaves the latter's edge going nowhere and hence we see no edge at all in the graph (I've confirmed this by patching the code).

Converting the endpoint to the original kinda works, i.e. calling
func dedupEndpoint(n report.Node) report.Node {
	if copyNodeID, _, ok := n.Latest.LookupEntry("copy_of"); ok {
		if _, addr, port, ok := report.ParseEndpointNodeID(copyNodeID); ok {
			n = n.WithID(copyNodeID).WithLatests(map[string]string{endpoint.Addr: addr, endpoint.Port: port})
			n.Latest = n.Latest.Delete("copy_of")
		}
	}
	return n
}

in MapEndpoint2Process.
This effectively gives us the following endpoints in the previous scenario:

desktop container has endpoint desktop;<IP_ADDRESS>;1122
vmhost1 container has endpoint vmhost1;<IP_ADDRESS>;41277 -> [;<IP_ADDRESS>;1122, desktop;<IP_ADDRESS>;1122]

However, this does result in "flickering" in the details panel, i.e. rows coming and going. In my original observations I said "Sometimes I initially see a count of 1 and it then increases to 2. And then sometimes it drops back to 1.".  This is consistent with sometimes only seeing edges to ;<IP_ADDRESS>;1122, and not desktop;<IP_ADDRESS>;1122.
Curiously though there is no flickering in the rendered graph, only in the details panel. Which is mysterious.

Curiously though there is no flickering in the rendered graph, only in the details panel. Which is mysterious.

The process/container adjacency still has the edges, and that is what the graph renderer cares about. By contrast, the connection counting code needs to look at endpoints, and since we've dedup'ed the endpoints, it can no longer find the other end for some of the edges.
What I don't know is why the process/container adjacency still has the edges. Need to look into the rendering code a bit more.

What I don't know is why the process/container adjacency still has the edges. Need to look into the rendering code a bit more.

Figured it out. render.Render calculates adjacency by tracking which input nodes (in this case endpoints) got mapped to which output nodes (in this case processes). Endpoint de-duping has no effect on that.

De-duping endpoints just isn't going to work. Consider a container listening on a published port, e.g. the desktop container in my example above. We can have connections to that container at both the container IP - from other containers on the same host - and external IP - from elsewhere. If we eliminate either endpoint, then one of the connections is left with a dangling destination.
We could de-dup edges, but this requires a walk of the entire topology post the rendering stage. Do-able, but a lot of work and somewhat outside my comfort zone.
So in #1860 I instead decided to de-dup connections in the counting stage, hence addressing the subject of this issue quite directly.


New Potion Commotion ruleset where all card additions are potions.

⚱ Potion Commotion ⚱
What
A new ruleset idea suggested by a friend. Heroes start with their usual cards and abilities (except that Sorcerer's Zap is a 0AP casting cost #STS), but all of the cards that they get from chests or mana are Potions. Enemy respawns are disabled.
We gave this a playtest on Elven Necropolis thie evening and very much enjoyed it. This ruleset would be a real struggle on rat king as you'd only have the torches from the shop (if you're lucky enough to get them).
How to review
Build from this branch and give it a playtest.

I'll give it a build and try it out tonight with a few others.

Played it with friends and have a few notes.

More chests and/or faster mana regen to keep the potions flowing

Decrease the chance of getting the one-time-use damage resist potion by doubling or tripling the number of other potions in the CardAddition list. We were all resist maxed out and just recycling those halfway through floor 2.

Why is (only) Zap free? Were we all supposed to be sorcerers? (3/4 of us were, but just asking)

It's playable as-is and we won in the end but it seemed a bit slow moving. By the end of level 2 we almost all were card-starved and not quite max stats. I know we can't change multiplayer shops so everyone bought non-potions while we were there. If that's not intended then maybe less gold per floor would reduce shop reliance.

Which map did you try the ruleset on @TheGrayAlien ? We were desperate for more DamageResistPotions when we played it, but we had been putting them on Cána. We were just about maxxed out by the time we made it to the boss fight (which was a walk in the park). Our card starvation happened near the end of the 1st floor in our game.
Zap is 0AP becuase without that the Sorcerer is damage-limited compared to other heroes - As Sorcerer can no longer get Fireball/Freeze cards removing the casting cost on Zap evens things up a bit.

Which map did you try the ruleset on @TheGrayAlien ?
We just ran Black Sarcophagus

Zap is 0AP because without that the Sorcerer is damage-limited compared to other heroes - As Sorcerer can no longer get Fireball/Freeze cards removing the casting cost on Zap evens things up a bit.
I see. Might consider making Overcharge and/or Lightning Bolt also free for the same reason since none of them can be used in the same turn.


'Trash old videos' clears cache

General troubleshooting tips
Before logging an issue please check that:

[ ] You have the latest version installed (There may be a beta version that fixes your issue), see here for the latest releases and bug fixes: https://github.com/JohnCoates/Aerial/releases
[x] Your issue isn't already mentioned in our issues. You may find a workaround there or a similar request already made.
[x] Your problem isn't mentioned in the troubleshooting section.

If none of this fixes your issue, tell us about the problem you are experiencing or the feature you'd like to request.
Required information
In order to help us sort your issue, we ask that you provide the following information:

[x] Mac model: MacBook Pro (15-inch, 2019)
[x] macOS version: 10.15.1
[x] Monitor setup: MBP + Thunderbolt Display

Description of issue / Feature request
This might be just a matter of me misunderstanding a feature. I had all available videos cached in 4K. I recently found out the feature of 'Trash old videos' under the Advanced tab, which I thought meant freeing space from older versions of videos that aren't used anymore. After pressing the button, all of the cached videos were gone and I've then re-started the download of all of them.
Additionally, and this should probably be a separate issue, I'm unable to update to 1.6.3. It downloads the update but when I click to update and relaunch, it closes and no matter how much I wait, it doesn't relaunch. After a while I close System Preferences and re-open aerial configs, and it's still at 1.6.2.

Hi @GabrielSiq

This might be just a matter of me misunderstanding a feature. I had all available videos cached in 4K. I recently found out the feature of 'Trash old videos' under the Advanced tab, which I thought meant freeing space from older versions of videos that aren't used anymore. After pressing the button, all of the cached videos were gone and I've then re-started the download of all of them.

First, sorry about that.
This doesn't sound right at all, I'll need to check ! You mentioned you had 4K (HDR disabled I guess) cached, and just pressed Trash old videos, correct ? Since you are using Catalina, I assume you cached those recently (after Catalina install) right ?

Additionally, and this should probably be a separate issue, I'm unable to update to 1.6.3. It downloads the update but when I click to update and relaunch, it closes and no matter how much I wait, it doesn't relaunch. After a while I close System Preferences and re-open aerial configs, and it's still at 1.6.2.

Yes, this is a known bug in Catalina sadly, auto updates fail because of the new sandboxing. You need to update manually for the time being. I'm hoping we can fix this soon.  There's a lot of issues around Catalina, you can read a summary here : https://github.com/JohnCoates/Aerial/issues/880

No worries - first of all I appreciate the project and just wanted to flag in case anything is wrong. I'm not upset in the slightest.
'Use HDR if available' is checked. 4K HVEC is selected.
I had them cached before Catalina but if I remember correctly (and sorry, my memory isn't that reliable) I had to cache it again after updating to Catalina, so I think those were fairly recent. It said there were 80 old videos found. Could have been the videos from before the update to Catalina, I didn't really check the folder. I clicked trash old videos and then the next time screen saver kicked in I noticed a certain lag, which indicated it was trying to stream the 4K video and cache was gone.
Regarding the auto update - I was aware of the issue but didn't know the definition of autoupdate. I thought it meant some background update and actively clicking the update button wasn't considered autoupdate. Now I got it. If I download the latest release from here and update it, would my settings (and cached videos) survive?

No worries - first of all I appreciate the project and just wanted to flag in case anything is wrong. I'm not upset in the slightest.
'Use HDR if available' is checked. 4K HVEC is selected.

Ok I think that might be the issue. It's quite possible I didn't update the trash code for HDR, I'll have a look tomorrow ! I had another bug relating to HDR so it's quite possible there's something there.

I had them cached before Catalina but if I remember correctly (and sorry, my memory isn't that reliable) I had to cache it again after updating to Catalina, so I think those were fairly recent.

So, if you enable HDR, you have to recache videos (they are different files) so that could be it. Also, files that you had previously were on a location that Aerial couldn't write/delete to now with the sandbox thing, so it's quite possible there's something wrong in there.

It said there were 80 old videos found. Could have been the videos from before the update to Catalina, I didn't really check the folder. I clicked trash old videos and then the next time screen saver kicked in I noticed a certain lag, which indicated it was trying to stream the 4K video and cache was gone.

I see, so the new files were gone. Could you go into the Cache tab in Aerial, and tell me what the read only cache location is (the one that shows with > in the middle). If you click show in finder, what do you see there ? Possibly your old files ?
Catalina may have wiped your cache (or not, it wiped mine in Catalina beta, didn't for a friend who waited for 10.15.1 to upgrade) too at install which doesn't help.

Regarding the auto update - I was aware of the issue but didn't know the definition of autoupdate. I thought it meant some background update and actively clicking the update button wasn't considered autoupdate.

You're right. All the updates, either automatic or manual through Sparkle (the subproject that downloads and install, see more here if curious : https://sparkle-project.org) are currently broken.

Now I got it. If I download the latest release from here and update it, would my settings (and cached videos) survive?

Yes ! Just download the file here : https://github.com/JohnCoates/Aerial/releases/download/v1.6.3/Aerial.saver.zip
You can then double click the .saver and it will overwrite the old version. Settings and cache will be preserved. I highly recommend you close System Preferences before double clicking the .saver. If you don't, you'll have to close and reopen System Preferences to get it to load correctly.
Thanks for the report, I'll let you know when I find the bug and hopefully I can fix it for everyone !

Thanks for the explanation. It all seems more clear now.
Regarding the cache location, both places seem to point to the same folder, which seems to contain the videos currently being downloaded.

Ok thanks for confirming, looks like I accidentally trash the hdr videos I guess, looking for regular instead. I’ll keep you updated !

Hi @GabrielSiq
So I had a look and there were many bugs around the move/trash feature and I ended up finding a few others. As you experienced, HDR videos would always be detected/moved/trashed as if they were outdated video files. This is fixed.
There were a few places where Aerial was still looking in the old read only cache folder and not the sandboxed one, for example cache size which was incorrect as a result (if your optional read only cache was set differently than in the sandbox).
I made a few other changes to try and clarify things based on your feedback and others:

I clarified in the Catalina issue (https://github.com/JohnCoates/Aerial/issues/801) that all automatic updates, whether silents or the ones you manually checked/approved through Sparkle would always fail in Catalina for the time being.
I clarified the language about HDR to clearly say that those are separate files. I also added an help button with more info about how these files are different (all 4K videos are 10 bit encoded, but HDR ones are using Dolby Vision).

You can manually update by installing this on top of your version : https://github.com/JohnCoates/Aerial/releases/download/v1.6.4/Aerial.saver.zip
You should now see that you have 0 outdated files after install. Please let me know that this works correctly for you.

The behavior works as you described. I see 0 outdated files and cache size is correctly detected. Do you know what the default for the old cache is? I feel like there are remaining files there that I might need to manually delete.
One quirk from the update, though: I closed system preferences as instructed before updating. When I opened it back up, there were two Aerial screensavers listed that seemed to point to the same thing (both showed 1.6.4 as version). I deleted one of them.

The behavior works as you described. I see 0 outdated files and cache size is correctly detected.

🎉

Do you know what the default for the old cache is? I feel like there are remaining files there that I might need to manually delete.

So the previous cache location was either ~/Library/Caches/Aerial/ or /Library/Caches/Aerial/, depending on when you installed first.
You will have to delete those files manually though, as Aerial can no longer delete those files itself in Catalina because of sandboxing (which brought that whole mess of bugs). You can safely delete everything there.

One quirk from the update, though: I closed system preferences as instructed before updating. When I opened it back up, there were two Aerial screensavers listed that seemed to point to the same thing (both showed 1.6.4 as version). I deleted one of them.

That's... intriguing, certainly never heard of that one before ! One thing I can think of is that at the very first install time, when you double click a saver file, you can either install for your own user or all users. But when you upgrade, System Preferences should tell you that you have an older version installed and if you want to overwrite.
Assuming you said yes, it should replace it. If you said no, I don't know what happens to be honest ! One thing to keep in mind is that you can only have one version of the screensaver in memory at a time (that's why I ask to close syspref, if you don't, it won't reload correctly) so that makes things a bit weirder, maybe somehow you had both versions on your system but both would say 1.6.4 because you can only have one opened at a time anyway (it's a Swift bug with syspref).
Or could be a SysPref bug, install is very much out of our hands. That's super weird in any case, if you see that next time, feel free to reopen a bug report !

Hmmm, interesting... I can only find two folders named Aerial. One is in Library/Application Support and mostly contains old logs, jsons, but no videos. The other is in /Library/Containers/com.apple.ScreenSaver.Engine.legacyScreenSaver/Data/Library/Application Support and has all my current videos.
Regarding the install, I got asked the first case only: install to this user only or all users. No question about upgrade. I had SysPref closed. One thing to mention, is that when I extracted the zip file in my download folder, it got renamed Aerial 2.saver due to a previously existing file in the same folder.  As a result, the file under /Library/Screen Savers generated after I double clicked it is also called Aerial 2.saver. Could that be the reason?

Hmmm, interesting... I can only find two folders named Aerial. One is in Library/Application Support and mostly contains old logs, jsons, but no videos. The other is in /Library/Containers/com.apple.ScreenSaver.Engine.legacyScreenSaver/Data/Library/Application Support and has all my current videos.

My guess is the old Caches folders were wiped by Catalina's upgrade process. You can safely delete the one in Library/Application Support

Regarding the install, I got asked the first case only: install to this user only or all users. No question about upgrade. I had SysPref closed. One thing to mention, is that when I extracted the zip file in my download folder, it got renamed Aerial 2.saver due to a previously existing file in the same folder. As a result, the file under /Library/Screen Savers generated after I double clicked it is also called Aerial 2.saver. Could that be the reason?

100%. That's why it didn't prompt you to upgrade, it's based on filenames ;) When you double click a .saver, System Preferences just copies it in your screensaver folder (and with a different name, you weren't prompted to overwrite). That's why you had 2. And they both showed as 1.6.4 because you opened the Aerial 2 first.
You should close/reopen syspref and check version, to make sure you deleted the correct one.


Minor performance regression (more memory allocations)

There seems to be some performance regression as we now perform tons of little memory allocations somewhere. Model still time steps as fast as it should so we probably haven't noticed it as we run large model sizes where this allocations are kind of hidden.
Seems like mainly a CPU issue.
CPU:
julia> using Oceananigans

julia> model = Model(N=(128, 128, 128), L=(1, 1, 1));

julia> @time time_step!(model, 1, 1)
 16.614982 seconds (34.03 M allocations: 1.775 GiB, 6.86% gc time)

julia> @time time_step!(model, 1, 1)
  0.738576 seconds (1.31 M allocations: 264.089 MiB, 3.97% gc time)

GPU:
julia> using Oceananigans

julia> model = Model(N=(256, 256, 256), L=(1, 1, 1), arch=GPU());

julia> @time time_step!(model, 1, 1);
 28.425740 seconds (71.04 M allocations: 3.383 GiB, 10.72% gc time)

julia> @time time_step!(model, 1, 1);
  0.025893 seconds (8.90 k allocations: 978.531 KiB)

Hmmm yeah @glwagner points out in #402 that it may be the halo filling causing this regression.
My guess is that we need @inline for all the halo filling functions. This would only manifest as an issue on the CPU but the GPU @inlines by default in many cases.
I'll benchmark on a branch and open a PR if it's this easy.

The difference definitely suggests a missing @inline in some kernel function, somewhere. Note that the halo filling functions are not kernel functions (instead, they launch kernels) so we should not have to @inline them.

This was fixed and we must have forgotten to close this issue, although a missing @inline is probably also the reason for #675.


Update the tests in array_test.py to adapt the removal of strictIndexOperator in Spark 3.4

Signed-off-by: remzi<EMAIL_ADDRESS>Closes #7065.
Rationales of the PR
The configuration strictIndexOperator has been removed in Spark3.4, and it always throws exception when accessing array element using invalid indexes in ANSI mode.

build


feat: Add cursor, includeCursor options, bump version

This also removes the no_cache and save flags as they are undocumented.
This also bumps the version to 0.5.0 (breaking change).

Great job! Works for me.


Get extension working on chromium

browser.runtime.getURL works to fetch the resource's URL, but this error occurs when trying to fetch it:


Fix bug with reset foreclosure time when foreclosed tokens are bought on auction

Sorry, some 'prefix'  stuff got mixed into this commit from the matic PR. Don't worry too much about that.

Yeah, @moose-code.


Adding ability to run multiple subsets of JCK tests at once

For the convenience of executing JCK tests, there is a need to run arbitrary subsets of JCK tests (e.g. api/java_lang and api/java_math/BigDecimal).
Based on the description in openjdk.test.jck/include/test_targets.mk, there is a test.jck.custom target which can help developer to execute arbitrary subset of JCK tests. But it seems this target can only accept one test subset at once, if multiple subsets were provided, it will throw exception.
For example:

cmd like this make -k test.jck.custom JCKVERSION=jck9 JCKTESTSUITE=RUNTIME JCKTEST="api/java_lang" will successfully generate the STF JCK test script and start running the api/java_lang JCK test.

cmd like this make -k test.jck.custom JCKVERSION=jck9 JCKTESTSUITE=RUNTIME JCKTEST="api/java_lang api/java_math/BigDecimal" will failed the STF JCK test execution with error message

STF 18:06:36.920 - Redirecting stderr to /tmp/stf/20171109-180633-Jck/results/3.JCK.stderr
STF 18:06:36.920 - Redirecting stdout to /tmp/stf/20171109-180633-Jck/results/3.JCK.stdout
STF 18:06:36.933 - Monitoring processes: JCK
JCK stderr + set jck.env.runtime.testExecute.otherOpts "   --add-modules java.xml.ws.annotation,java.xml.bind,java.xml.ws,java.activation,java.corba -Xdump:system:none -Xdump:system:events=gpf+abort+traceassert+corruptcache -Xdump:snap:none -Xdump:snap:events=gpf+abort+traceassert+corruptcache -Xdump:java:none -Xdump:java:events=gpf+abort+traceassert+corruptcache -Xdump:heap:none -Xdump:heap:events=gpf+abort+traceassert+corruptcache "
JCK stderr Configuration file can not be imported due to question with specified tag "jck.env.runtime.testExecute.otherOpts" was not found on path. The path is:jck.intro
JCK stderr jck.env.simpleOrAdvanced (advanced)
JCK stderr jck.env.envName (jck_runtime)
JCK stderr jck.env.description (JCK9 runtime template jti for ST...)
JCK stderr jck.env.platform (jre)
JCK stderr jck.tests.chooseTests (Yes)
JCK stderr jck.tests.treeOrFile (tree)
JCK stderr jck.tests.tests (api/java_lang api/java_math/BigD...)
JCK stderr jck.env.testPlatform.intro
JCK stderr jck.env.testPlatform.nativeCode (Yes)
JCK stderr jck.env.testPlatform.multiJVM (Yes)
JCK stderr jck.env.testPlatform.useAgent (No)
JCK stderr jck.env.testPlatform.os (Current system)
JCK stderr jck.env.runtime.intro
JCK stderr jck.env.runtime.otherJVM
JCK stderr jck.env.runtime.testExecute.intro
JCK stderr jck.env.runtime.testExecute.cmdAsFile (/java9/bin/java)
JCK stderr jck.env.runtime.testExecute.classpath (command line option)
JCK stderr jck.env.runtime.testExecute.classpathOpt (-classpath #)
JCK stderr jck.env.runtime.testExecute.additionalClasspath ()
JCK stderr jck.env.moduleSystem.vmOptions (vmAddModsOptionTemplate=--add-mo...)
JCK stderr jck.env.runtime.testExecute.nativeLibsLinkage (dynamic)
JCK stderr jck.env.runtime.testExecute.libPath (environment variable)
JCK stderr jck.env.runtime.testExecute.libPathEnv (will_be_set_by_test_automation_a...)
JCK stderr jck.env.runtime.testExecute.nativeLibrariesLocation (Yes)
JCK stderr jck.env.runtime.testExecute.nativeLibPathFileValue (will_be_set_by_test_automation_a...)
JCK stderr jck.env.runtime.testExecute.cannot_read
JCK stderr
STF 18:06:38.599 - **FAILED** Process JCK ended with exit code (3) and not the expected exit code/s (0)
STF 18:06:38.599 - Monitoring Report Summary:
STF 18:06:38.599 -   o Process JCK ended with exit code (3) and not the expected exit code/s (0)
STF 18:06:38.600 - Killing processes: JCK
STF 18:06:38.600 -   o Process JCK is not running
**FAILED** at step 3 (Running JCK in multijvm way with Agent off). Expected return value=0 Actual=1 at /tmp/stf/20171109-180633-Jck/execute.pl line 93.
STF 18:06:38.619 - **FAILED** execute script failed. Expected return value=0 Actual=1
STF 18:06:38.620 -
STF 18:06:38.620 - ====================   T E A R D O W N   ====================

Although we can use a loop (in script) to run a list of subsets, the test summary outputs will be separated and hard to track which tests passed and which tests failed. I think we need the STF JCK test to be able to run multiple subsets of JCK test at once, as we want the final test summary to be combined together.

Per talk with Simon, each JCK test run will generate a .jtb file. If we defined multiple test targets in one run, the .jtb file will be overridden by other test settings, which may result in unexpected test failure due to mismatching test environment settings.
A suggested solution is to create extra makefile targets for subdirectories. So if we want to use this method, I think one question is where these targets should be added to? a) Adding them to the main test_targets.mk file or create a new one and include it from the test_targets.mk?
Also, if subsets of JCK tests are executed from makefile targets, I think there needs a mechanism to organize the whole test summary output. For example, if target test.jck9.runtime.subset includes api/java_lang/instrument api/java_lang/invoke api/java_lang/reflect, the final test summary of make test.jck9.runtime.subset would be more readable if each test target's summary are combined together but not separated into parts. If this is agreed, I think a separate issue is needed to tracking this feature.
Hi @lumpfish, I open this issue and moved our talk here to keep them under tracking. Could you kindly give some suggestions upon the question above?
FYI @smlambert  @pshipton

Having all the separate results combined into one isn't a requirement. I suggest leaving it for a future enhancement. As long as we can easily see which subset failed, we can open the results for that subset to see the details.
Although there are many failures now, in the future all the tests will be passing and should remain passing. We'll only be interested in the rare occurrences when something starts failing as the result of a merged change.

Great, thanks for confirming Pete


Great work! Is there any sample code to use this over BLE on a nRF52840 board?

I would love to use this code on an IPad over BLE!

At the moment JoystickXL is limited to wired USB connections, though I like the idea of using it over BLE.  A cursory look at the CircuitPython BLE library is promising, but it is ultimately quite a leap from the wired USB stuff I've been working with.
I've got a couple of nRF52840-based boards on order, so when they arrive I'll give it a more serious look.

Great, I am also using the nRF52840 boards from adafruit


datagrib in a form extended

I´m extending a form with a dataGrid with three columns.

In the form extended, I add a new columns in the first position.

The new column hides the first column of the principal form and add an empty column.
But if I move the new column to the last position It show the four columns with its data.

I don´t Know if it´s a bug or if I must to put in the principal form all the columns and in the onLoad event put visible that column
Servoy  2020.3.0

You can't change the order of columns in an overridden table (and so, can't have a new column in first position) - this is actually a restriction from Servoy for components with arrays of custom types, in this case the table (component) with the columns (array of custom types). The visibility approach should work.


Document release cadence and roadmap

It would be very helpful to know when we can expect new releases (with our contributions!) and what the high-level roadmap is (e.g., Windows support).

Can you clarify if there will be 3 or 4 releases per year? February, June, October sounds like 3.

Ah, sorry. We release every 4 months, so three releases per year. Had a brain fart there.


Find Uber scooter API endpoints

Uber provides scooter sharing through the brand Jump (https://nz.jump.com/nz/en/) and we are looking for someone to help us by reverse engineering their mobile app or proxying requests through packet capture.
Unfortunately the endpoints documented in the WoBike repository (https://github.com/ubahnverleih/WoBike#jump-usa) do not provide the locations of scooters.
Hopefully the endpoints and the required request format needed to load their scooter locations can be found this way, and then we will be able to add them to the map.

I will give it a shot. :)

Bike endpoints have been added, we are now just looking for someone to help find the scooter endpoints from the Uber app

https://github.com/NABSA/gbfs/blob/master/systems.csv

@jesserockz I took a look through that CSV and couldn't find anything for the Uber Jump scooters here. I tried emailing Uber Engineering a few months ago to find out if they have any GBFS URLs for Jump here in New Zealand but I unfortunately I didn't receive a response. As far as I know the only way to find the scooter locations would be to proxy/MITM the app - however I believe certificate pinning on recent iOS and Android versions makes it a bit complicated.

Yeah, it looks like most of the other cities have been found by guessing maybe.
https://gbfs.uber.com/v1/laxs/gbfs.json - Los Angeles
2/3/4 letter city/airport code followed by s for scooter or b for bike.
Tried a few combinations for Wellington but have not gotten it yet.

JUMP Scooters and Bikes can now be found under the Lime's API as "brand": "jump".


Use stock R headers to build RHost

Rapi.h uses windows definitions of some of the functions used. On linux some of those definitions lead to SIGSEGV fault. Trying to replace every function with a linux definition makes Rapi.h riddled with ifdef. Building RHost with gcc and stock R headers seems like the cleanest way.

What's the status?

This builds on linux now. I have to do a similar change in windows, but after the change likely that RHost will not build with VC++. It will have to be built with gcc.

Since this work item is linux specific. I am closing the item, since work remains to be done on the windows side.

If only VC++ was C99 compliant....


Duplicate board

Is your feature request related to a problem? Please describe.
I create a new standard board for each Trustee meeting of a charity I help run.  These are always identical in their settings for columns and categories. Currently I set them up each month and then set up similar tasks within the columns for each meeting. This can take a bit of time.
Describe the solution you'd like
When creating a Board it would be good to duplicate a previously made Board template
Describe alternatives you've considered
Additional context

Duplicate of #417, if I'm not mistaken.


[V6] Add submitSucceeded prop (related to issue #853)

Hi,
This pull request adds the submitSucceeded prop proposed and asked in issue #853.
It also includes a setSubmitSucceeded which isn't used yet, but can be useful in the future.
Thanks for this great library, v6 is really awesome !

Wow! Excellent work, @scboffspring! Perfect PR. 💯

Well. Did you not leave out where it is actually called,  in handleSubmit()?

That's what I found "weird". setSubmitFailed was only called part of asyncValidation, and not part of the doSubmit
(here https://github.com/erikras/redux-form/blob/v6/src/handleSubmit.js#L54 and here https://github.com/erikras/redux-form/blob/v6/src/handleSubmit.js#L64)
The failure is otherwise handled part of the STOP_SUBMIT reducer that will check _error fieldErrors.

Flag submitSucceeded is very helpful when you just want to show a message that your form got submitted successfully. But after successfully submitted form and flag set to true I would like to have that flag set back to false once you touch any part of the form again (similar to how error prop works set by SubmissionError _error flag, if you touch any part of the form error disappears).
May I know why isn't it working like that?
Imagine profile page which is full of fields of your own data. All those fields are going to be prepopulated with data that already exists in your store. Once you change that data and update it you get a success message thanks to sumbitSucceeded flag which becomes true.
The way I fixed it is by using submitSucceeded flag along with submitting flag. Basically, I only show success message if submitSucceeded flag is true but submitting is false and it works this way. But I would really love to remove success message once you touch a form again as it is obvious you are trying to do another form submission. And this can't be done with dirty/pristine flag because if you touch any field and then change it back to what it was before, success message will disappear at first and then get back once you change value to it's initial.

Why hasn't this made it into the docs yet? I wasted time because this flag wasn't documented. Thanks for the work!

@rjhilgefort

Why hasn't this made it into the docs yet?

What are you talking about? submitSucceeded is documented since ever:

http://redux-form.com/6.0.0-rc.4/docs/api/Props.md/#-submitsucceeded-boolean-
http://redux-form.com/6.1.0/docs/api/Props.md/#-submitsucceeded-boolean-
http://redux-form.com/6.2.0/docs/api/Props.md/#-submitsucceeded-boolean-
http://redux-form.com/6.4.3/docs/api/Props.md/#-submitsucceeded-boolean-
http://redux-form.com/6.6.0/docs/api/Props.md/#-submitsucceeded-boolean-

I wasted time because this flag wasn't documented.

The main feature of this PR is documented, you're probably just looking at the wrong place.
And please use wiser words the next time, otherwise people may get mad at you.

@gustavohenke My apologies. Thanks for the work, love the library!
Seems to just have been an SEO issue pulling up the most popular version of redux form from a google search and and then navigating there within. I hadn't noticed the URL for the version (seems to be no other prominent call out in any other place.
While nice to have doc instances for all versions, without a prominent display of the version on the page, it can add confusion and noise. I doubt I'm the only one to make this mistake. I think prominently displaying a version tag below the Redux Form logo would be extremely helpful.
Again, thanks for the work on this tool- it's made my life much easier and is generally a pleasure to interface with.

Is anyone can show example how to use submitSucceeded now?

It doesn't look like this has made it into the docs yet. Is it in the current stable release?
I have a feeling I'm going to extend this FR further with a conversation about field specific feedback - I need to resolve whether my API or my front-end will be providing feedback on password quality first.
Would be nice to see this conversation progress to include more thinking about affirming positive feedback.  I realise I'm getting into the realms of advocacy here, but I would like us to all think about how to "help Gran change her password"...  maybe it's an edge opinion but good user forms IMO should be affirming when entry is correct. (without being so full of green popups that they get annoying)


fix: the source part should not participate in loss calculation in SFT stage

fix https://github.com/microsoft/DeepSpeedExamples/issues/660
In the SFT stage, it's essential that the source part doesn't contribute to the loss calculation, only the completion part should be considered. To address this issue, I've adjusted the labels for the source part to be set as -100. This specific value, -100, corresponds to the default "ignore index" in the torch.nn.CrossEntropyLoss function. Importantly, both OPT and LLAMA models utilize torch.nn.CrossEntropyLoss for their loss calculations, as seen in OPTForCausalLM and LLamaForCausalLM. As a result, there is no need to make any modifications to the way the loss is computed, as it will automatically handle the source part as intended.
The training loss of opt-350m with Dahoas/rm-static as dataset

The function is now moved to "DeepSpeedExamples/applications/DeepSpeed-Chat/dschat/utils/data/data_utils.py"
This solution seems to assume single-turn conversation, please consider cases for multi-turn conversation.


Mothership: Marine starts with +5 Combat but sheet has +0

Maybe the Alpha didn't have this, but in the most recent edition available on DriveThru Marines get +5 in Combat (and an extra +5 if another Marine is helping, but the sheet should not account for that).
https://github.com/Roll20/roll20-character-sheets/blob/29f7271e1766114cd7ae86219c3657a4f60fe9cf/Mothership/Mothership.html#L67

Made requested change and submitted pull request.


Error installing in Angular 13.2 and 13.3

I'm submitting a ... (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[x] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
Library not installing on Angular 13.2 and 13.3 versions using
npm install @swimlane/ngx-datatable --save

and produces the following error
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/rxjs
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>|| ^7.4.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular/common
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@swimlane/ngx-datatable
npm ERR!       @swimlane/ngx-datatable@"*" from the root project
npm ERR!     1 more (@angular/platform-browser)
npm ERR!   1 more (@angular/core)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@swimlane/ngx-datatable
npm ERR!   @swimlane/ngx-datatable@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/user/.npm/eresolve-report.txt for a full report.

npm ERR!      /Users/user/.npm/_logs/2022-05-02T08_48_46_067Z-debug-0.log

Expected behavior
Library should be installed without error

Reproduction of the problem

What is the motivation / use case for changing the behavior?
Heavily using ngx-datatable in our project (Angular 8). Now upgrade to the latest update of Angular (Angular 13) but couldn't proceed due to the above error.

Please tell us about your environment:
Node version: 16.14.0
OS: Mac

Table version:

20.0.0

Angular version:

Angular 13.2.0 and 13.3.0

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Language: [all | TypeScript X.X | ES6/7 | ES5]

for the moment try it with npm i --force
the dev dependencies are not updated from the dev. We are waiting months..

@SwissKerim Degrading rxjs from 7 to 6 works for me.

@SwissKerim Degrading rxjs from 7 to 6 works for me.

oh well.. i got other dependencies for rxjs 7

Any update here? Having similar problem.

<EMAIL_ADDRESS>(Forked)
stackblitz

Same in angular 14... Any updates change update is planed?

I've submitted this PR #2108, hopefully that will unblock us to move forward with Angular 13 + Ivy.

Siemens maintains a fork with updated dependencies: siemens/ngx-datatable


Implement support for DUAL like table

We need some kind of support for a single row table like DUAL.
PostgreSQL for example does not require a from clause in that case

The only way to support that in my opinion is to register some virtual entities like done with CTEs and replace them in the generated SQL with the vendor specific syntax.

See https://github.com/Blazebit/blaze-persistence/issues/181


generator: add version to repo tag

Alaska Airlines Pull Request
Fixes: #165
Summary:
This PR adds the generator version to the repo's tags. This PR also addresses a miss with the README files in applying the correct npm namespace to the bundled URLs.
Type of change:
Please delete options that are not relevant.

[x] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 3.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Adding CI in other OS

As pointed out in https://github.com/dipy/dipy/pull/2759#issuecomment-1750678877, we are not currently testing on Mac and Windows OS. We should add CI runs on those OS.

Done in #59


Bar controls are not supported

https://www.byond.com/docs/ref/skinparams.html

A bar that can be used to show progress, health level, magic level, etc., or used as an adjustable slider. The bar can be straight or formed into an arc. Any area not covered by the bar or slider is transparent, so you can make an arc around another control.

Fixed by #1375 (though arc functionality is not implemented)


Add changes to slbeta3 release

Purpose

Pack the svg icon within the resource directory
Remove existing PNG icon
Update keywords in Ballerina.toml
Change connector configuration record name to ConnectionConfig
Add support for all HTTP Client configuration fields in connector Connector Configuration record
Update Package.md to state how to create an issue in https://github.com/ballerina-platform/ballerina-extended-library

Security checks
Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes
Test environment
JDK 11
Ballerina SLBeta3

Looks good to me.
Only thing missing is the svg icon.
After we receive the svg icon for this connector, we'll add that also

Thanks @LakshanSS


Create LICENSE

Yo, I would recommend adding a license to your repo, seeing that as of now, you could sue me for adding code to your unlicensed code. So, for now, I have added the MIT license.

Shit yaar mera master plan to file a lawsuit against you for hunnid fiddy
is ruined.
On Fri 7 Aug, 2020, 5:57 PM Rishvic Pushpakaran<EMAIL_ADDRESS>wrote:

Yo, I would recommend adding a license to your repo, seeing that as of
now, you could sue me for adding code to your unlicensed code. So, for now,
I have added the MIT license.
You can view, comment on, or merge this pull request online at:
https://github.com/hi-im-buggy/snake-clone/pull/2
Commit Summary

Create LICENSE

File Changes

A LICENSE
https://github.com/hi-im-buggy/snake-clone/pull/2/files#diff-9879d6db96fd29134fc802214163b95a
(21)

Patch Links:

https://github.com/hi-im-buggy/snake-clone/pull/2.patch
https://github.com/hi-im-buggy/snake-clone/pull/2.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hi-im-buggy/snake-clone/pull/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGXBO47TBMVEZ6XNGM2Z3HTR7PXKHANCNFSM4PXSTC3Q
.


Replaced .bind with .call method in .each

I still don't understand why you have to pass the element as a 2nd argument in the boundFn. The callback function from .each in app.js has only the index as the only parameter.
Like this:
const boundFn = callback.bind(element);
boundFn(i);

It works both ways, but I was kind of confused at first.


Rearrange minute multiplier heading & paragraphs

Why:
It is strange to read the paragraphs about minute multipliers above the 'minute multipliers' heading.
It's also strange to have the two paragraphs unrelated to minute multipliers between the table of multipliers and the note about them.
Closes: no issue

What's being changed (if available, include any code snippets, screenshots, or gifs):
Rearranged the paragraphs so the ordering on the page makes more sense. No content was changed, the text was only moved.

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@cmenon12 Thanks so much for opening a PR! I'll get this triaged for review ✨


fix(core): Check one authentication method for each login attempt

https://snowowl.atlassian.net/browse/SO-5621

Codecov Report
Base: 64.20% // Head: 64.11% // Decreases project coverage by -0.09% :warning:

Coverage data is based on head (e966532) compared to base (e0c0e8e).
Patch coverage: 0.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff              @@
##                8.x    #1110      +/-   ##
============================================
- Coverage     64.20%   64.11%   -0.09%
- Complexity    12542    12596      +54
============================================
  Files          1748     1754       +6
  Lines         58600    58869     +269
  Branches       5400     5432      +32
============================================
+ Hits          37623    37746     +123
- Misses        18654    18772     +118
- Partials       2323     2351      +28

Impacted Files
Coverage Δ

...nowowl/core/identity/request/UserLoginRequest.java
0.00% <0.00%> (ø)

...international/index/es/client/EsClusterStatus.java
68.00% <0.00%> (-25.75%)
:arrow_down:

...m/b2international/snowowl/core/RepositoryInfo.java
56.00% <0.00%> (-17.34%)
:arrow_down:

...international/index/es/client/tcp/EsTcpClient.java
63.82% <0.00%> (-13.10%)
:arrow_down:

...ernational/snowowl/core/codesystem/CodeSystem.java
40.00% <0.00%> (-13.07%)
:arrow_down:

...national/commons/exceptions/ApiErrorException.java
87.50% <0.00%> (-12.50%)
:arrow_down:

...b2international/index/es/client/EsIndexStatus.java
47.61% <0.00%> (-10.72%)
:arrow_down:

...ternational/index/es/client/http/EsHttpClient.java
75.00% <0.00%> (-9.22%)
:arrow_down:

...om/b2international/snowowl/core/bundle/Bundle.java
33.33% <0.00%> (-7.74%)
:arrow_down:

...m/b2international/index/es/admin/EsIndexAdmin.java
74.20% <0.00%> (-7.68%)
:arrow_down:

... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Remove redundant items last when simplifying types.

This also fixes a problem when filter_ignored_items removes all
items the type was Union[].  We fall back to Any now instead.

@gvanrossum Anything I need to change before this can get merged?  Thanks!

Sorry! Lost track of things over the holidays.


[move prover] Add type requires for generated code

Motivation
This PR adds pre-conditions requiring that function parameters are well-formed in generated code. If type-requires option is set to true, requires is used; otherwise free requires is used.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
cargo test

@wrwg I can't add reviewers so I'm tagging you here. Can you add yourself as a reviewer?

addressing issue @3989

@wrwg please help me land it. Thanks!

@bors-libra r=wrwg

:pushpin: Commit d94bdb0 has been approved by wrwg

:hourglass: Testing commit d94bdb0f09cfa2f7f250150acc85045726c99f3a with merge bbe3ee2c9c1e87e829db403c9ab21f62a0587e5d...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: wrwg
Pushing bbe3ee2c9c1e87e829db403c9ab21f62a0587e5d to master...


When hydrate failed, the old component instance did not be destroyed

Version
2.6.10
Reproduction link
https://jsfiddle.net/mt9xp1wo/
Steps to reproduce
open the link and see the result
What is expected?
the beforeDestroy hook should be called twice
What is actually happening?
the beforeDestroy hook only be called once

Why should the beforeDestroy hook be called twice? It seems expected https://jsfiddle.net/bec907ds/7/

The problem exists and it is really bad thing.
When hydrating it is expected that component will be destroyed before rendered again. But it's not, I've got two components linked with one node. I can see duplicates in this.$children.
@skyline0705 Do you have any updates with your case, maybe some workarounds?
I'm going to manually fire $destroy on duplicated children, because having the same component hidden is big problem for my project.
@DominusVilicus you can see everything here:
https://jsfiddle.net/zf1h8x94/1/


doc: Remove $ character from code blocks

Summary
Closes #227 and #200
Changes

Removed $ character from command blocks to make it easier for people to copy commands

Notes for Reviewers
WiP
Checklist

[ ] Scope: The referenced issue is addressed, there are no unrelated changes.
[ ] Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
[ ] New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
[ ] Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
[ ] Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

@benolayinka can you please check this out and provide your feedback? I don't feel like bugging other people with this before you approve

This is awesome, really nice work Nejra. I know it was a lot!

Thanks for a great feedback @benolayinka! I fixed everything you proposed. I think others don't really have to review so I'll just merge this.


Remove logging

Were there changes in progress for these log messages to still be around?

@drewjenkins No thanks for removing


undefined is not an object (evaluating '_react3.default.PropTypes.string')

When I run on the simulator it shows this error.
I have installed via
"react-native-audio-streaming": "git+https://github.com/tlenclos/react-native-audio-streaming.git",
I installed  prop-types.

Fixed by cleaning build!


Preliminary encrypted PIN class

Hola Patrón
Here's a preliminary Encrypted PIN class for the service base - can you please give it a quick look?
I already have these concerns:

Name of "DukptFields"
Javadoc of fields in DukptFields (struggled to glean much from Wikipedia + Thales. What is BDK?)
Which of the Dukpt fields were mandatory again? I've labelled all of them at this point

@neilmackellar the Eon has done a 180, more changes pending


Error: Cannot find module 'extract-text-webpack-plugin'

When I follow instructions I get the following error:
`module.js:472
throw err;
^
Error: Cannot find module 'extract-text-webpack-plugin'`
'extract-text-webpack-plugin' is not in the list of plugins in this part of the guide:
npm install css-loader style-loader file-loader url-loader html-webpack-plugin awesome-typescript-loader --save-dev

Hi @nikican in which sample you get this error?
Thanks

Hi @brauliodiez
Sorry, I should have formulated the issue a bit better.
It happens when I follow instructions for 00 Boilerplate.
In readme.md file there is a line:
npm install css-loader style-loader file-loader url-loader html-webpack-plugin awesome-typescript-loader --save-dev
and 'extract-text-webpack-plugin' is not in that list which causes the above mentioned error.

Just updating the readme step to this would fix the issue?
npm install css-loader style-loader file-loader url-loader html-webpack-plugin awesome-typescript-loader -extract-text-webpack-plugin --save-dev

If you can confirm that's the case, I can update the guide, or if you wish you can fork and do it (as you preffer).
Thanks

Hi @nikican, @mjuanfe have just uploaded a fix, merged :-). Thanks for your help.


deezer music

deezer music cutting and then coming back really fast in the first 3 seconds of the song

It works finw for me.
Do you have an example?

seems like was an issue on my end as i was doing something with the lava link settings.

Hi, where you find decryption key ?


[DC-2755] Check that mapping, extension, and OMOP tables contain the same number of records

@brendagutman I rebased on develop, the tests pass now.


Create an AWS Batch Cluster for Spark Ingests

Create a compute environment, cluster, job definition to do an ingest.
The path to an ingest definition on S3 will need to be parameterized. Jobs will need probably 12 GB now to work.

This will have to be "by hand" for now -- there doesn't seem to be a great way to encapsulate AWS Batch in an infrastructure as code way yet.


Add getAgentAccessAll for WAC Resources

This adds getAgentAccessAll, which returns a list of all the
individual agents being granted access to a Resource which access is
controlled by a WAC server.
Note that since the WAC code is largely based on pre-existing functions,
the tests check for implementation rather than behaviour by verifying
that the underlying function is called, in order to reduce the number of
tests.
Checklist

[X] All acceptance criteria are met.
[X] Relevant documentation, if any, has been written/updated.
[X] Commits in this PR are minimal and have descriptive commit messages.

@Vinnl, I realize only with this PR that testing for the underlying function to be called was what you suggested earlier, which I initially misunderstood. Is that correct ?


App Update (EXPOSUREAPP-8905)

Testing
1- Please use gmail testing account
2- Follow the steps sent by email message that has subject Testing - In App Update Google play
3- you should see something like

[x] Pending on Google play console testing

App is minimizing once the update is complete on my Samsung Galaxy S10+ (Android 11). Is this normal?  Is this normal? It happens every time.
Screen_Recording_20210922-152451_Corona-Warn.mp4

I have no idea 🤷, there is no intents triggered explicitly, Google play App is opening the app again

App is minimizing once the update is complete on my Samsung Galaxy S10+ (Android 11). Is this normal? It happens every time.
Screen_Recording_20210922-152451_Corona-Warn.mp4

I have no idea 🤷, there is no intents triggered explicitly, Google play App is opening the app again
BUT there is something weird in your video:
it is was Downloading -> Installing -> Downloading again ?!!

Juts Google Play things I guess 🤷


feat: Write a proper readme

Replaces the generic, auto-generated Readme with a description of the project,

looks good


Freeze popover

Hi all!
I need to show up a popover inside datatable that refresh data every 3 seconds.
The problem is that after refreshing, the popover reference is destroyed and popover showed go up  to coordinate 0,0 when scroll page.
Can it be solved?
CodePen demo

https://www.codeply.com/go/y2VQrjqdjf
Steps to reproduce the problem

Show popover
Delete popover reference
Scroll down

What is the expected behavior?

Popover stay on current position
What went wrong?

I dont know
Any other comments?

Thanks in advance! (sorry for my bad english :( )

That's a Bootstrap request, please open the ticket on their repository.


changes for trap target address, now to be read from MySQL DB openclos::...

...trapTarget table

One question to Moloy and Ramesh,
Do we handle the openclos trap group the same way as ND trap group? I see we still leave the openclos trap group in the openclos.yaml.
-yun
From: rgiyer<EMAIL_ADDRESS>Sent: Thursday, January 29, 2015 7:59 PM
To: Juniper/OpenClos
Subject: [OpenClos] changes for trap target address, now to be read from MySQL DB openclos::... (#140)
...trapTarget table

You can view, comment on, or merge this pull request online at:
https://github.com/Juniper/OpenClos/pull/140
Commit Summary

changes for trap target address, now to be read from MySQL DB openclos::trapTarget table

File Changes

M jnpr/openclos/conf/openclos.yamlhttps://github.com/Juniper/OpenClos/pull/140/files#diff-0 (3)
M jnpr/openclos/configure_for_ND.pyhttps://github.com/Juniper/OpenClos/pull/140/files#diff-1 (55)
M jnpr/openclos/model.pyhttps://github.com/Juniper/OpenClos/pull/140/files#diff-2 (12)
M jnpr/openclos/script/openclos_trap.shhttps://github.com/Juniper/OpenClos/pull/140/files#diff-3 (7)

Patch Links:

https://github.com/Juniper/OpenClos/pull/140.patch
https://github.com/Juniper/OpenClos/pull/140.diff

—
Reply to this email directly or view it on GitHubhttps://github.com/Juniper/OpenClos/pull/140.

Hi Yun,
The DB cache for trap target is only for ND. Standalone setup will use the openclos trap group from yaml file.
Moloy - feel free to add / correct my statement.
Regards
On Jan 29, 2015, at 6:46 PM, Yun Li <notifications<EMAIL_ADDRESS>wrote:
One question to Moloy and Ramesh,
Do we handle the openclos trap group the same way as ND trap group? I see we still leave the openclos trap group in the openclos.yaml.
-yun
From: rgiyer<EMAIL_ADDRESS>Sent: Thursday, January 29, 2015 7:59 PM
To: Juniper/OpenClos
Subject: [OpenClos] changes for trap target address, now to be read from MySQL DB openclos::... (#140)
...trapTarget table

You can view, comment on, or merge this pull request online at:
https://github.com/Juniper/OpenClos/pull/140
Commit Summary

changes for trap target address, now to be read from MySQL DB openclos::trapTarget table

File Changes

M jnpr/openclos/conf/openclos.yamlhttps://github.com/Juniper/OpenClos/pull/140/files#diff-0 (3)
M jnpr/openclos/configure_for_ND.pyhttps://github.com/Juniper/OpenClos/pull/140/files#diff-1 (55)
M jnpr/openclos/model.pyhttps://github.com/Juniper/OpenClos/pull/140/files#diff-2 (12)
M jnpr/openclos/script/openclos_trap.shhttps://github.com/Juniper/OpenClos/pull/140/files#diff-3 (7)

Patch Links:

https://github.com/Juniper/OpenClos/pull/140.patch
https://github.com/Juniper/OpenClos/pull/140.diff

Reply to this email directly or view it on GitHubhttps://github.com/Juniper/OpenClos/pull/140.

Reply to this email directly or view it on GitHubhttps://github.com/Juniper/OpenClos/pull/140#issuecomment-72145389.


Model aware scheduling

What would you like to be added:
Right now, model management is a tricky problem in the cluster, it's big, so we need to cache them in the node just like images, however, kubelet will take over the image lifecycle management but files, so that's a problem, and will not be tacked in the near future, so maybe we need to manage the models manually and make it aware by the  scheduler to make pod placement decisions.
Why is this needed:
Efficient pod scheduling with models
Completion requirements:
This enhancement requires the following artifacts:

[x] Design doc
[ ] API change
[x] Docs update

The artifacts should be linked in subsequent comments.

/kind feature

I see that the built-in plugins of scheduler currently include: volumebinding volumerestrictions volumeszone plugins. Do we have scoring plugins similar to imagelocality plugins (e.g. volumelocality) to cover this scenario?

Yes, basically the idea is we have models located at different nodes, and we should be aware of which node is the best candidate.
However, right now, I'm developing a P2P based model distribution project, you can take it as another lightweight dragonfly but most works for model weights. See https://github.com/InftyAI/Manta, once this finished, the model aware is not that urgent, because models will be transmitted across nodes, but still available.


Release of version <IP_ADDRESS> of xPowerShellExecutionPolicy

Releasing version <IP_ADDRESS>

This change is

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@060203a). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             master    #23   +/-   ##
=======================================
  Coverage          ?   100%
=======================================
  Files             ?      1
  Lines             ?     13
  Branches          ?      0
=======================================
  Hits              ?     13
  Misses            ?      0
  Partials          ?      0


Godot Editor Drag and Drop Lag on MacOS

Godot version:
3.2.1
OS/device including version:
macOS Catalina v10.15.5
3GHz 6-Core Intel Core i5
32gb DDR4
Intel UHD Graphics 630 1536 MB
Issue description:
Recently converted my work station over to mac from windows. Setup my Godot project and noticed that dragging and dropping assets from the file system to the inspector panel lags.
I've noticed no other performance hits while using the editor, and this was not a problem on my windows machine. Seems to happen specifically with dragging and dropping images into texture slots in the inspector.
Steps to reproduce:
Drag and drop an image from the file system panel to an appropriate outlet in the inspector tab.
Not sure if it's visible in this gif -- but you can at least notice the icon alongside the cursor dragging along.

@Mootook, can I ask you to check if you can also reproduce #17584 on your Mac?

It looks normal

I'm having what looks like the same issue. For me the lag is extreme, and in the lagging areas the cursor does not move nearly as far as usual for the same mouse movement (it's not just a delayed movement). Some additional notes that may be helpful:

I've only experienced the issue when my external monitor is connected.
The lag happens anywhere where the "illegal action" symbol is visible, in other words when you cannot drop the thing in that area. No lag dragging a png into the scene, or a script onto a script slot.

I'm using Godot 3.2.2 stable, on macOS Mojave.

@hmans Wow, super late response....sorry about that. But no, in general the editor for me is rather responsive except in this instance. Also, I've seen mention of monitors in related issues--not sure if it's relevant, but I'm on a Mac Mini Usb-c to an LG 4k display.

I'm seeing this issue on v3.2.3 as well.  macOS 10.15.6 (19G2021), quad core i5, 16 GB memory, Intel GPU.  The lag is bad enough I run out of trackpad when I'm clicking/dragging.

I'm seeing this issue on v3.2.3 as well.  macOS 10.15.6 (19G2021), quad core i5, 16 GB memory, Intel GPU.  The lag is bad enough I run out of trackpad when I'm clicking/dragging.

I'm seeing this issue on v3.2.3 as well. macOS 10.15.6 (19G2021), quad core i5, 16 GB memory, Intel GPU. The lag is bad enough I run out of trackpad when I'm clicking/dragging.

Does this happen with an external mouse?

I'm seeing this issue on v3.2.3 as well. macOS 10.15.6 (19G2021), quad core i5, 16 GB memory, Intel GPU. The lag is bad enough I run out of trackpad when I'm clicking/dragging.

Does this happen with an external mouse?

I'm seeing this issue on v3.2.3 as well. macOS 10.15.6 (19G2021), quad core i5, 16 GB memory, Intel GPU. The lag is bad enough I run out of trackpad when I'm clicking/dragging.

This issue appears to be resolved in the upcoming 3.2.4 -- maybe you can try the latest available beta to confirm?

I'm seeing this issue on v3.2.3 as well. macOS 10.15.6 (19G2021), quad core i5, 16 GB memory, Intel GPU. The lag is bad enough I run out of trackpad when I'm clicking/dragging.

This issue appears to be resolved in the upcoming 3.2.4 -- maybe you can try the latest available beta to confirm?

Lag happens with either mouse or trackpad. Also, I've just checked and I'm still getting this in 3.2.4 beta 6.
In my experience it only occurs when my external monitor (which also happens to be an LG 4K) is connected and Godot is displaying on that screen.
Here is a video that hopefully shows the issue better. But you still can't see just how bad it is, I've had to stop using drag and drop completely.
https://user-images.githubusercontent.com/33777501/105376996-2f935d00-5bbf-11eb-8200-b9b92f3a50a1.mov

Lag happens with either mouse or trackpad. Also, I've just checked and I'm still getting this in 3.2.4 beta 6.
In my experience it only occurs when my external monitor (which also happens to be an LG 4K) is connected and Godot is displaying on that screen.
Here is a video that hopefully shows the issue better. But you still can't see just how bad it is, I've had to stop using drag and drop completely.
https://user-images.githubusercontent.com/33777501/105376996-2f935d00-5bbf-11eb-8200-b9b92f3a50a1.mov

Lag happens with either mouse or trackpad. Also, I've just checked and I'm still getting this in 3.2.4 beta 6.
In my experience it only occurs when my external monitor (which also happens to be an LG 4K) is connected and Godot is displaying on that screen.
Here is a video that hopefully shows the issue better. But you still can't see just how bad it is, I've had to stop using drag and drop completely.
Screen.Recording.2021-01-21.at.7.58.09.AM.mov

Interesting observation, I concur this seems to only impact me when I'm performing a drag and drop on an external monitor.

Lag happens with either mouse or trackpad. Also, I've just checked and I'm still getting this in 3.2.4 beta 6.
In my experience it only occurs when my external monitor (which also happens to be an LG 4K) is connected and Godot is displaying on that screen.
Here is a video that hopefully shows the issue better. But you still can't see just how bad it is, I've had to stop using drag and drop completely.
Screen.Recording.2021-01-21.at.7.58.09.AM.mov

Interesting observation, I concur this seems to only impact me when I'm performing a drag and drop on an external monitor.

Maybe the external monitor has 50FPS only?

Maybe the external monitor has 50FPS only?

My external claims 60 FPS in macOS, it's definitely a 60 FPS monitor as well.

Doesn't necessarily feel like a monitor issue, it just seems like the mouse is losing steps.

My external claims 60 FPS in macOS, it's definitely a 60 FPS monitor as well.

Doesn't necessarily feel like a monitor issue, it just seems like the mouse is losing steps.

Seems to me that it happens when the mouse is over parts that the editor registers as illegal for the file: noted by the 🚫 next to the mouse, which is flashing as I drag the mouse.
Perhaps this check is happening constantly and stopping the mouse every time it sees that the place is illegal? Doesn't quite explain why it only happens on external monitors (which I can also confirm) 🤔

@Tadaboody If you're able to build from source, can you find and comment our the line of code that changes the cursor to the "forbidden" icon?

Yup! looks like commenting out ...set_cursor_shape(OS::CURSOR_FORBIDDEN) fixes the issue :O Maybe the can_drop var is too frantic on external monitors on mac?

Maybe the can_drop var is too frantic on external monitors on mac?

That might be the reason. Alternatively, it's possible that changing the mouse cursor changes its hotspot, causing the hotspot to flicker between two positions while the mouse is moving.

As a workaround, we can disable drag-and-drop cursor changes on macOS by wrapping that part of the code with #ifndef OSX_ENABLED.
I wouldn't love losing a feature on the OS - especially as someone who uses it!
I'll try looking into this more this week, expect me on the dev channels for questions :)

I get lag when dragging just about anything in the Editor or in my game when it's running from the Editor. (Haven't tested a built version because I don't have an Apple dev license.)
This includes:

Dragging to select text in the script editor
Dragging scrollbars (but using the mouse/trackpad scroll is smooth)
Dragging edges of editor panes to make them larger/smaller
Dragging nodes in the 2D or 3D view
Dragging Control nodes in a game when playing from the Editor

Video showing 1 and 2 (sorry, didn't mean to make it a Short, youtube is just stupid 😣)
Video showing 3, 4 and 5
I think discovered a key issue here. You can see in the second video, when I comment out if action.is_released: dragging = false code, it means that releasing the left mouse button won't end the drag action. And apparently, when I don't have the left mouse button held down, dragging is smooth.
Not sure what this means under the hood, but hopefully it helps?

On reddit, @TheDuriel said this may be an issue in scene/gui/control.cpp

Hmmmm... I just tested Godot on my friend's 2022 Macbook Pro M2 and I didn't have the bug at all. He's on Monterey while I'm on Ventura. Not sure if that has something to do with it? My machine is also slightly newer (2023 vs 2022) and has the Max chip.
His machine: Godot v4.1.1.stable - macOS 12.6.2 - Vulkan (Forward+) - integrated Apple M2 - Apple M2 (8 Threads)
My machine: Godot v4.1.1.stable - macOS 13.4.1 - Vulkan (Forward+) - integrated Apple M2 Max - Apple M2 Max (12 Threads)

Is either of the two Macs a Retina device?

Yeah, both are.

There goes my theory that it's resolution/fillrate related...

@Tadaboody If you're able to build from source, can you find and comment out the line of code that changes the cursor to the "forbidden" icon? The bug might be related to changing the mouse cursor.
https://github.com/godotengine/godot/blob/a1222e435fa64d09ccebed1a24388f8096dab5b1/scene/main/viewport.cpp#L2337-L2341
I'd try commenting both lines above then recompiling.
(Note: if you're using 3.2.x, build the 3.2 branch instead of master.)

I actually tried this and it helped somewhat, but there was still significant stuttering. I'll upload a video when I'm home.

I figured it out! It was another app, Multitouch. I use it for custom keybinds and gestures. As soon as I turned it off, dragging was fine. I'm glad I finally started checking other people's machines to see if it was just a problem on my end. Sorry for not testing more extensively earlier and for just assuming it was an issue with the engine! <3

@craigostrin good find, I'm running Magnet which caused similar issues. It made the editor lag like crazy while moving it around in general.
But, there's an ignore app option that resolved the issue.


How to reproduce your results.

@alirezazareian . Hi!  Thanks for opensourcing your code.
I follow the two step training procedure. However, the results are far away from your paper results.
I try many setting in the second stage but I still get inferior results.

Could you please share more details, e.g. the exact numbers you are getting and the entire output log for both pretraining and fine-tuning? Can you reproduce the results if you use the shared checkpoint?

Still a little gap.
Experiment results: 46.6, 26.9,  Generalized: 46.6, 22.1
Paper :  46.8 , 27.5,  Generalized: 46.0, 22.8

Could you help me on how to reproduce such pretrained model ?


Add versioning tests

This adds tests for reversion versions created when interacting with the endpoints dealing with the following models:

company
contact
adviser
interaction
event
investment project
investment project team member

Codecov Report

Merging #842 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #842   +/-   ##
========================================
  Coverage    96.67%   96.67%
========================================
  Files          159      159
  Lines         4657     4657
  Branches       452      452
========================================
  Hits          4502     4502
  Misses          96       96
  Partials        59       59

Impacted Files
Coverage Δ

datahub/omis/order/validators.py
95.32% <0%> (ø)
:arrow_up:

datahub/omis/market/metadata.py
100% <0%> (ø)
:arrow_up:

datahub/omis/order/serializers.py
100% <0%> (ø)
:arrow_up:

datahub/omis/invoice/managers.py
100% <0%> (ø)
:arrow_up:

datahub/omis/order/admin.py
94.78% <0%> (ø)
:arrow_up:

datahub/omis/notification/signal_receivers.py
88.57% <0%> (ø)
:arrow_up:

datahub/search/omis/signals.py
100% <0%> (ø)
:arrow_up:

datahub/omis/order/metadata.py
100% <0%> (ø)
:arrow_up:

datahub/dbmaintenance/management/base.py
100% <0%> (ø)
:arrow_up:

datahub/omis/invoice/serializers.py
100% <0%> (ø)
:arrow_up:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3caf940...9e6a8b5. Read the comment docs.


Wrong HINTS of params of function declared with @callback

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.80.0
OS Version: Windows 10 Pro 22H2. OS build 19045.3208

Wrong hints of params of function declared with @callback

Working as intended: https://github.com/microsoft/TypeScript/issues/18396
Object in JSDoc doesn’t mean the same thing it does in TypeScript.

That font makes it very difficult to see that it's an uppercase o. Another reason why one should always post code instead of a screenshot: Playground link
@fatcerberus I'd say the issue is that the callback is having three arguments, instead of having one argument with two properties. The same applies with a lowercase o (see playground link).

@MartinJohns Ah, I missed that it was supposed to be two properties on an object and not three separate parameters.  That’s a really confusing way to use the @param tag…
That said, both object and Object are treated as any per #18396 so that may still apply.

That’s a really confusing way to use the @param tag…

That's how it's supposed to be on regular function declarations. And if used derectly to type function parameter it would work with both object and Object.
I found that if these JSDoc comments only supposed to work in TS-powered environments and don't require descriptions - it's easier to type cb as @param { (obj: { a: string, b: string}) => void} cb <description> instead of bulky @callback declarations.
With descriptions it requires @typedef+@property a d then @callback.
Would be great to have same behavior for both callback declaration and regular functions.


General: Be able to use anatomy data in ffmpeg output arguments

Brief description
Be able to pass data from anatomy data into metadata of output from Extract Review plugin.
Changes

output ffmpeg arguments are formatted with anatomy data in Extract Review plugin

Testing notes:

add -metadata my_key={asset} into ffmpeg output arguments of Extract review
run publishing which will use that ffmpeg argument

Resolves https://github.com/pypeclub/OpenPype/issues/2524

Task linked: OP-2373 Review preset ffmpeg output arg with template formating


Fix package to match log4j2.xml packages attribute

Rationale
@labkey-willm flagged a log4j2 error on Tomcat standalone which pointed out that this class is in the wrong package for that deployment scenario
Related Pull Requests

https://github.com/LabKey/platform/pull/5257

I agree the path and declared package should match, but I'd prefer to use the logging subpackage or get rid of it completely. I guess my attempt at moving it in the original FB didn't go well.

Since log4j2.xml has now been updated in the docker PR, this class and SessionAppender will disappear once we're embedded-only, and branch time is quickly approaching, I'm going to leave it like this for now. We can clean up the logging package in a subsequent PR if we want to.


How to get a score from the results screen?

I am trying to save it in a new variable as integer, but I have no idea.

 Really... You call yourself as the creator of my hard work but the only thing you added is korean language. And after all you expect help from me?!

Shame Ganggroid as well. Also, you should probably find some way to get them to take it down, because it does violate your license (yes I read your license). Either that or change your license.


website down

site is down again.  no error message displayed - just a blank page.

website up again


[AutoPR storage/resource-manager] Remove GZRS and RAGZRS sku from SRP 2018-11-01 because feature slipped.

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5377

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/1562


Post deletion

Have a published post deletion button would be helpful for the post management,  if you agree, I can open PR on it.

Of course! Really appreciate it if you can put in a pull request😄

Hi @metrue I just added Markdown support for blog/thoughts.
Unsure if it affects your deletion feature. Excited for this to go live : D


FPS Camera rotation is jerky in some configuration

In OpenGL, both Debug and Release, the camera is very jerky: if you slowly move the mouse camera rotates after a considerable amount of movement.
For Direct3D, there is something different: the Debug configuration is ok, but the release is a bit jerky, but not as the same grade as OpenGL.
I've also disabled SP_WARN(mouse) to ensure that the issue was not caused by lots of printf calls.

I believe this is due to how vsync behaves in OpenGL on Windows. Can you try disabling vsync and see if that fixes the jerkiness?

Where can toggle the vsync?

Umm umm, don't you have to keep m_Window->SetVsync(false); to disable it?

@Xeryko technically isn't it already disabled since it's set to false?

Needs to be tested with vsync turned off in windowed mode.

You should merge with my rawinput pull request, that fixes this actually.
At least for me it does.

Can someone try this again? it seems okay on my end, although Sparky's vsync setting doesn't seem to switch off for OpenGL.


Accessibility Issues Provider

Implementation of #557
Description

Motivation and Context

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

Documentation should be adjusted:
documentation/src/main/wiki/AccessibilityIssuesReport.md
In section 'Downloading the report' in URL, 'type' should be replaced by 'verbosity'

Documentation is incoherent with the implementation
In report URL, WARNING is not working (as described in documentation), but 'WARN'
So this is working URL: http://localhost/api/accessibility/report?company=cognifide&project=pro&suite=sui&correlationId=corrID&verbosity=WARN&extension=txt
So this is NOT working URL: http://localhost/api/accessibility/report?company=cognifide&project=pro&suite=sui&correlationId=corrID&verbosity=WARNING&extension=txt

XLSX file generated with NOTICE verbosity (0 issues) , cannot be opened. The following error occurred

IMPROVEMENT
It would be useful if the report would have an information with issue level (NOTICE, WARNING, ERROR)


Hotfix/campus operator

This change is

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 22 at r1 (raw file):

        var rows = [Row]()
        if UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiom.phone {

Don't worry about this if. Go ahead and show them all the options up front

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 33 at r1 (raw file):

                    messageController.messageComposeDelegate = self
                    messageController.recipients = [BYU_INFO_NUMBER]
                    messageController.body = ""

I think this may be the default... Try removing it

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 60 at r1 (raw file):

        super.viewWillAppear(animated)

        if let indexPath = tableView.indexPathForSelectedRow {

This may not work for some of the options... See if coming back to the app from your phone or email actually deselects the row properly

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 68 at r1 (raw file):

    func tableView(_ tableView: UITableView, titleForFooterInSection section: Int) -> String? {
        return section == 0 ? "Campus operators can help you find phone numbers, information about BYU activities, and other related university information." : ""

Isn't there only one section? if so, don't worry about the ternary

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 84 at r1 (raw file):

    func mailComposeController(_ controller: MFMailComposeViewController, didFinishWith result: MFMailComposeResult, error: Error?) {
        if result == MFMailComposeResult.failed {
            super.displayAlert(error: nil, title: "Error", message: "your email failed to send. Please try again later.")

Capitalize "your"

Comments from Reviewable

Review status: all files reviewed at latest revision, 5 unresolved discussions.

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 22 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Don't worry about this if. Go ahead and show them all the options up front

Done.

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 33 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
I think this may be the default... Try removing it

Done.

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 60 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
This may not work for some of the options... See if coming back to the app from your phone or email actually deselects the row properly

It does work except on phones like my test phone that block calling because it doesn't actually open another view.

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 68 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Isn't there only one section? if so, don't worry about the ternary

Okay. I was just duplicating the logic from the original.

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 84 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Capitalize "your"

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 60 at r1 (raw file):
Previously, ecbrady (Erik Brady) wrote…
It does work except on phones like my test phone that block calling because it doesn't actually open another view.

Yup. That's what I thought. So let's just remove this and do it in the didSelectRow method

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 60 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Yup. That's what I thought. So let's just remove this and do it in the didSelectRow method

Did selectRow is being handled by TableData though. Do we want to duplicate that logic here and override TableData or do we want to add a deselectRow to TableData's didSelect?

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 60 at r1 (raw file):
Previously, ecbrady (Erik Brady) wrote…
Did selectRow is being handled by TableData though. Do we want to duplicate that logic here and override TableData or do we want to add a deselectRow to TableData's didSelect?

Don't duplicate the logic. Just override the didSelect and do this:
override func didSelect... {
  super.didSelect...
  tableView.deselectRow(at: indexPath, animated: true)
}

Comments from Reviewable

Review status: 5 of 6 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

byuSuite/Apps/CampusOperator/controller/CampusOperatorViewController.swift, line 60 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Don't duplicate the logic. Just override the didSelect and do this:
override func didSelect... {
  super.didSelect...
  tableView.deselectRow(at: indexPath, animated: true)
}

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


DownloadBuildArtifacts with buildNumber, not buildId

Environment

Server: VSTS
Agent: Private (OS: Ubuntu 16.04.4 LTS, Agent: 2.129.1)

Issue Description

Task: Download Build Artifacts

$(DependencyVersion) is a variable that is defined in the variable section of this build definition. It represents a build number from a different build definition that is set manually.
You can select different build numbers from the drop down menu.

But you can't pass a build number to the field. It is somewhat misleading.

The reason this doesn't work is because it requires the build id, not the build number.

Request / New Feature
Could it be possible to optionally pass the build number (even by linking it manually from the link settings), so that it would find the correct build. Another great feature would be an option to utilize the latest successful build from a different build definition.
Thank you.

@samssann - this is a limitation with task inputs that support drop-down. You are right - When value for the input is provided manually, the value should be Build Id. In case it is not possible to change $(DependencyVersion) to represent Build Id, you could do the following:

Author a custom task (could be PS script task as well) that takes $(DependencyVersion) as input and outputs the corresponding build id into an output variable, say $(DependencyVersionId).
Use $(DependencyVersionId) as input in the DownloadBuildArtifacts task for the value of Build.

The task has been enhanced to support taking latest build as an option. These changes should be deployed to production in next 3-4 weeks.

@samssann I don't see a build number input there...

This issue is getting addressed with this PR:
https://github.com/Microsoft/vsts-tasks/pull/6855

We have already added support for choosing latest build from a different build definition.

This support is added with this PR:
https://github.com/Microsoft/azure-pipelines-tasks/pull/7879


defaultBootstrapPaginator

defaultBootstrapPaginator is not working

Have a look at the example repository https://github.com/Kurounin/PaginationExample


Template is an empty object

I'm trying to upgrade place-my-order, but the pmo-restaurant-details ( https://github.com/donejs/place-my-order/blob/master/src/restaurant/details.component ) component isn't created correctly.
For some reason the template is an empty object.  Here's my package.json:
  "dependencies": {
    "bit-tabs": "^0.2.0",
    "bootstrap": "^3.3.5",
    "can": "^2.3.0-beta.6",
    "can-connect": "~0.3.1",
    "can-ssr": "^0.9.1",
    "d3": "3.5.5",
    "done-autorender": "^0.4.2",
    "done-component": "^0.3.0",
    "done-css": "~1.1.13",
    "es6-promise": "^2.2.0",
    "jquery": "^1.11.3",
    "place-my-order-api": "^0.4.2",
    "place-my-order-assets": "^0.1.6",
    "socket.io-client": "^1.3.5",
    "steal": "^0.12.0-pre.7",
    "steal-platform": "0.0.4"
  },
  "devDependencies": {
    "documentjs": "^0.3.3",
    "donejs-deploy": "^0.1.6",
    "funcunit": "^3.0.0",
    "grunt": "^0.4.4",
    "grunt-cli": "^0.1.13",
    "steal-cordova": "0.1.1",
    "steal-nw": "0.1.3",
    "steal-qunit": "^0.1.1",
    "steal-tools": "^0.12.0-pre.4",
    "testee": "^0.2.0"
  },

This was a problem with a missing curly.  I'll create another issue for giving a better warning.


undefined symbol: _ZN10tensorflow7strings6StrCatB5cxx11ERKNS0_8AlphaNumE

have anyone got this issue?

I also got that error:
tensorflow.python.framework.errors_impl.NotFoundError: /home/userName/Faster-RCNN_TF/tools/../lib/roi_pooling_layer/roi_pooling.so: undefined symbol: _ZN10tensorflow7strings6StrCatB5cxx11ERKNS0_8AlphaNumE

This is solved here Issue #50

@amirhfarzaneh thanks for your information. And I got it fixed.

@amirhfarzaneh  Which tensorflow version was you using to fix this problem?


UTable : support clickable row, emit value

Is your feature request related to a problem? Please describe.
This concern a feature request, to expose a whole row when it is clicked, to achieve some action afterwards, such as redirect/open a modal/slide over, ...
Describe the solution you'd like
Low level would be emit the row when a click is made on the tr
High level would have a new props that allow you to ask for the clickable functionnality on the row, if so we could add a new property in the preset that would customize the row when it is clickable and  hovered

Describe alternatives you've considered
Since you expose each slot for the column, i may have considered attaching a click on them, but I quickly removed that consideration since it's really not optimal,  especially when you don't need to extend any of the column and just display primitive values.
Additional context
I would gladly make a PR for this feature, as i don't see it being big or making breaking changes
Thanks in advance

That was fast! Thanks ❤


Remove delete release cleanup

contributes to #738 and #708
refactors RemoveDeleteModal to use a composed modal for more flexibility as well as numerous updates and fixes to get the component ready for release review. also made a small update to a test in Saving

@matthewgallo changes pushed. please re-review when you have a moment


Use uniform response format

Signed-off-by: Prasad Ghangal<EMAIL_ADDRESS>ISSUE TYPE

Feature Pull Request

SUMMARY
Use uniform codeblock format for command responses across different integrations

@codenio PTAL

@codenio PTAL


Update README.md and src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj

[X] I have signed the Contributor License Agreement.
[ ] This pull request is related to an issue.

Microsoft Reviewers: Open in CodeFlow

Meaning of style cops?

Meaning of style cops?

StyleCop is a thingy to enforce consistent source code style

Tell suggestions in #4619.


Add npm run dev command that watches files and runs tests

TODO:

[ ] Add to README
[ ] Make --grep on tests work
[ ] Rebase your changes on master so that they can be merged easily

@Slava do you know how I can pass through the args here? I need to pass through a --grep option to npm run testonly...

Great hacks!


Tracing error tags

Adjusted tags
added extra handling of Error in JSON.stringify
simplified some code (removed unneeded Dos)
moved functions around

I also wanted to add another function to public api which allows to add extra tags into span. However, I'm not clear on one moment in that code, so I will submit it as a next pr.


feat(core): add orderby to extractQueryFields

🏆 Enhancements
🐛 Bug Fix
Add orderby to extractQueryFields, which consolidates query options related to generating actual SQL queries.
This should also fix sorting options in table chart. Previously each plugin has to do the order_by_choices parsing themselves (e.g. in the now deprecated old new table chart), I figure it'd be useful to make this global, in case we want to support query mode switch for other viz types.
Related: #889 https://github.com/apache/superset/pull/10270

I'm going to admin merge since the blocking check "Semantic Pull Request" seems to be having a glitch.

I'm going to admin merge since the blocking check "Semantic Pull Request" seems to be having a glitch.


[otel-agent] add openshift support

LGTM 😄
I guess we should just add an entry on the change log.
WDYT?


Asking a Question

Hello,
Is it possible to create a line plot / multiple line plots, and force the x axis to display only integer values?
Also, is it possible for the y axis to display the values in 10^3 (for example) scale?
Thank you in advance,
Panagiotis

Yes, you have to play with axis which is accessible through plot.getGrid()...


chore(deps): update common-dev-assets digest to a5e68b7

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
4a89924 -> a5e68b7

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline