IE8 Invalid argument (index out of bounds)

      run: function(target, method /*, args */) {
        var onError = getOnError(this.options);

        this.begin();

        if (!method) {
          method = target;
          target = null;
        }

        if (isString(method)) {
          method = target[method];
        }

        var args = slice.call(arguments, 2);

        // guard against Safari 6's double-finally bug
        var didFinally = false;

        if (onError) {
          try {
            return method.apply(target, args);
          } catch(error) {
            onError(error);
          } finally {
            if (!didFinally) {
              didFinally = true;
              this.end();
            }
          }
        } else {
          try {
            return method.apply(target, args);
          } finally {
            if (!didFinally) {
              didFinally = true;
>>>>>>>>>              this.end();
            }
          }
        }
      },

The line highlighted above seems to cause the exception:
Invalid argument. {
	[prototype] : {...},
	description : "Invalid argument.",
	message : "Invalid argument.",
	number : -2147024809
}

I think it most likely occurs when the following executes:
 prototype.childAtIndex = function(element, index) {
      return element.childNodes.item(index);
    };

element looks like this: [object DispHTMLDocument]
and contains 0 childNodes
If I change the code to this:
    prototype.childAtIndex = function(element, index) {
      if(element.childNodes.length>index)
        return element.childNodes.item(index);
      else
        return null;
    };

I get
SCRIPT5022: a fragment parent must have boundary nodes in order to detect insertion
I'm not sure that element has been passed correctly as some of the properties have strange values, e.g. location: Unexpected call to method or property. mimetype/domain/fileSize: nspecified error. div: 'div' is undefined.
This is reproducible in IE11 using ie8 compatibility mode:
Ember      : 1.11.0-beta.1+canary.59757239
Ember Data : 1.0.0-beta.14.1
ember-cli: 0.1.7

Thanks for pinpointing it!  At first glance, it looks like the same problem addressed by @salzhrani at https://github.com/tildeio/htmlbars/pull/247/files#diff-ae9f94d48470b7d9baaf54b27751f728R145, in which case we should be good on this once that PR gets merged (we can leave this issue open until it's confirmed as fixed after that happens).

(Well, except the stuff you mention at the end, we'll have to look at that, too)

@zyllorion can you take a look at master and see what is still an issue? We've fixed quite a few items.

Looks great! :-) Thanks for the fixes.


[NFC] Name Binding -> Import Resolution

Rename this phase to more accurately reflect the bulk of the work that it actually accomplishes, and to remove one more overload of the phrase "name binding" in the compiler.  I've left the historical references to it alone, but a bunch of out of date doc comments are all updated to reflect the current state of the world.
This patch also has another NFC component that resolves an ancient FIXME around the extra bit in the maps we have for operators and precedence groups.  It seems unused so I've removed it and simplified the two-phase lookup logic.

@swift-ci please smoke test

@swift-ci please test source compatibility

Urf, need LLDB patches

Jenkins died
@swift-ci please test source compatibility

apple/llvm-project#80
@swift-ci please smoke test

apple/llvm-project#80
@swift-ci please smoke test macOS platform

@swift-ci please test source compatibility

Going to approach this a different way.  Leaving the LLDB patch up for the future though...


HEAD response must not include body

Hi,
When I make a request with HEAD method like the following example, it includes body entity. It doesn't conform with RFC 2616 which says in Section 9.4:

The HEAD method is identical to GET except that the server MUST NOT
return a message-body in the response

Could you please fix the issue by not including body entity in HEAD responses? Thanks in advance!
Here's an example output:
$ curl -i -XHEAD http://localhost:8888/folder1/
HTTP/1.1 200 OK
Content-Type: text/html
Date: Tue, 14 Aug 2018 15:44:32 GMT
Content-Length: 357
Server: WsgiDAV/2.4.1 Cheroot/6.4.0 Python/2.7.10

<!DOCTYPE HTML PUBLIC '-//W3C//DTD HTML 4.01//EN' 'http://www.w3.org/TR/html4/strict.dtd'>

  <meta http-equiv='Content-Type' content='text/html; charset=UTF-8'>
  <title>200 OK</title>

200 OK

200 OK

WsgiDAV/2.4.1 - 2018-08-14 11:44:32.666774

Thanks for reporting, I'll fixed this for 3.x.
How did this error affect you, i.e. how did you find it?

Thanks a lot, @mar10 ! I will try with the newer version once ready.
While contributing to https://issues.apache.org/jira/browse/VFS-360, I used this software as backend in testing. If Keep-Alive is option is not used from client, there's no problem. If Keep-Alive is used, meaning old used socket connection being reused, the consecutive request fails because the response was polluted by the previous head response. In VFS2 with my new HttpClient v4 code, Keep-Alive is now the default option, so I had to hit this issue.
Anyway, this is a great project! Cheers!

Intreresting, thanks for taking the time!


Terraform checkov detection: Check: CKV_AZURE_206: "Ensure that Storage Accounts use replication"

Check: CKV_AZURE_206: "Ensure that Storage Accounts use replication"
FAILED for resource: module.storage.azurerm_storage_account.storage_trials

Previously included in skip_check


Small bug with closing windows in settings

When you open settings and after click any submenu here, like spectrum analyzer or others, when you close it with gesture swipe down, it will open again immediately. Works good when you close it by clicking back button.
Latest iOS, Rattlegram 1.8.
I want to thank you for the app, it's really great❤.
Maybe one small enhancement about spectrum analyzer. It will be nice, if it can be higher with longer history. Like don't limit it only to 2 cm in middle of display. It can continue endlessly down.

Yes, I've also noticed that swiping doesn't always work reliably for closing sheets on the iOS version. Will see if that can be somehow improved.
A larger waterfall needs more processing and therefore drains the battery faster, which is why I kept it small. Will look if it can be made larger efficiently or at least configurable in both versions.
Thank you for the suggestion.


trace_processor_shell is broken on x64 VirtualBox Linux VMs

I have a CI running in VirtualBox VM part of which I process perfetto traces via python API collected from Android devices.
Recently I started getting weird failures that I tracked down to the new optimization flags added to trace_processor_shell as part of enable_perfetto_x64_cpu_opt added by this commit: https://github.com/google/perfetto/commit/2277f0695ed61c8ebdd1e2a2d60f4eb3f306e82c
The error I was getting is:
This executable requires a x86_64 cpu that supports SSE4.2, BMI2 and AVX2.
Rebuild with enable_perfetto_x64_cpu_opt=false.

Worth noting is that I was using perfetto 0.3 from pypi to process the perfetto traces. Which automatically downloads the latest version. So this breakage was a bit surprising. (I did move to perfetto 0.5 pypi release as part of the investigation FWIW).
I used TraceProcessorConfig() to enable verbose output which allowed me to see the real error message above. My python script was failing with something very random about failing to allocate Random Port or something like this. I had to scratch my head for a bit thinking something went wrong with my system setup or a system update has gone wrong.
It turned out at the end that while my hardware does support BMI2, but VirtualBox doesn't pass this on to the guest. I do see SSE4.2 and AVX2 in /proc/cpuinfo but not BMI2. vbox.log also clearly shows that BMI2 is not enabled on guest but available on the host. It seems VBox is still working on getting BMI2 support although it's been there for a while..
https://www.virtualbox.org/ticket/15471
I managed to work around the problem by downloading v25 and use TraceProcessorConfig() to set bin_path after implementing a simple function to see if trace_processor_shell is somewhere in PATH to use a pre-installed version rather than always download the latest one. Otherwise fallback to downloading as usual.
I liked the idea of the auto download as I hit issues in the past with incompatibility between traces captures by perfetto and trace_processor_shell. I wonder if it would be simple to detect if the system has the required requirements and download a non-optimized version automatically. Just a thought. I'm happy with my current workaround, but thought at least worth documenting this with an issue in case others get  hit by it too. For me it suddenly stopped working and the symptom was hard to diagnose.

Glad you managed to work around this, and thanks for the detailed bug report!
In my mind there ideally there are three actions to take:

Better error message if Python library fails to start trace_processor_shell
Python library should detect if any of {SSE4.2, BMI2 and AVX2} are missing
(maybe) we should provide trace_processor_shell binaries without enable_perfetto_x64_cpu_opt

The first one we can probably get too but I imagine the rest won't ever get prioritised high enough that we get to them ourselves.

+1 absolutely back up what Hector says. We should definitely expose the error message if trace processor binary fails to start but I think publishing x64 binaries/detecting CPU caps from Python is just not high prio enough.

A more helpful error message would be great! Maybe a suggestion to use TraceProcessorConfig() to force use a specific installed version would be good too as I had to look at source code to find out about these things (maybe it's documented but I failed to see that). Not sure if that can be phrased generically without a problem.
Giving the option to specify which released version to Download might be useful too.
Just random suggestions, not saying you should do any of this! :-)
I don't think Python library should detect any hardware deps. IMHO, if anything to be done, it needs to be done in trace_processor_shell binary itself. You can use some GCC builtin intrinsics and see if it supports a feature before calling an optimized routine. And maybe there are already some libraries that does that already for you that you just need to link to.
See __builtin_cpu_supports() in GCC docs for an example. In theory, it shouldn't be that time consuming to use. But of course, the devil is always in the details :-)
https://gcc.gnu.org/onlinedocs/gcc/x86-Built-in-Functions.html

We turn on autovectorization so we cannot just say: check CPU features before calling a function because potentially any function can end up having AVX/BMI instructions :)

Right :-)

The error message has been improved now: this is all we can commit to do now.


hatch release: --strict flag is misleading?

At the moment --help for hatch release says: -s, --strict          Aborts if a distribution already exists..
I expected it to exit with non-zero code if the package already existed.
However, behaviour seems to be the opposite of what I expect:
$ hatch release
Uploading distributions to https://upload.pypi.org/legacy/
  Skipping cachew-0.6-py2.py3-none-any.whl because it appears to already exist
(exit code 0)
$ hatch release --strict
Uploading cachew-0.6-py2.py3-none-any.whl
100%
(exit code 0)

So instead of aborting, --strict have forced uploading.
It seems that the option simply forwards to --skip-existing of twine upload, which means:
--skip-existing       Continue uploading files if one already exists.

Should the --strict flag do exactly the opposite? Also --abort normally implies non-zero exit code, I think; is hatch meant to implement this logic?
Happy to open a PR fix it, just not sure what was the original intent. Thanks.

Hatch has been rewritten from scratch and now no longer uses twine so no more --strict, see https://ofek.dev/hatch/latest/publish/


C_CPP: The 'this' Pointer

Description 📜
Explained how to use 'this' Pointer. Also, performed few program to explain the same.
Fixes #5794

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] C/CPP

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

@vasu-1 Done.


--version always returning 'unknown'

Seen on a Windows install, with grab-typings installed as a global package:
C:\> gt --version
unknown

Seems the version finder isn't quite janky enough. At least on Windows, the relative path references in GrabTypings() will resolve against the dir where you launched gt, not the script dir. No package.json for you.

sounds like we probably want __dirname in those relatives paths

Yeah, otherwise it's optionally messing with process.argv[1] iff platform == "win32", and ew.

thanks @benfahrenheit


Improve indexer

maintainer edit: discussion continued from #22
Ok, hopefully this PR is ready for review. Sorry it's quite a big set of changes! It's probably at a good point where other changes are more features or tweaks to structure as opposed to a large, get it to a 0.0.1 release.

Added a quickstart guide to the readme.
Added a docker-compose.yaml to stitch a functional docker build together.
Replaced the spatial server with native point-in-polygon queries directly to the WOF sqlite database (wof.rs).
Added a point-in-polygon r-tree structure so all pips can be optionally loaded, and then queried during indexing. So slower to build, requires 10GB of memory for planet, but faster for queries, compared to the above approach which offloads the problem to sqlite. This is optionally enabled with --pip-tree which will either build the tree and write to disk or load it from disk from a previous run.
Removed the docker container creation code.
Combined the load and indexing binaries, as they are so related it made it slightly confusing to work with. The indexer is exposed as a library, with a primary indexer binary. Extended the args to include commands allowing different loading functionality to occur - e.g. load osm from pbf or osmx, but will extend to other data.
Added support for loading directly from OSM pbf files. This removes the 3-4hr conversion step from pbf to OSMX. The indexer can optionally load from a pbf file or from a osmx file. When first loading from a pbf, a lookup table is created in the cache for all nodes to include their lat/lon, this is subsequently used to geo-locate ways.
Refactored as I worked through the codebase to allow different components to be re-used (e.g. caching during load for osm pbf cache).
Addressed clippy pedantic concerns.
Reduced memory and allocation during import.
Removed unwraps and other panics, replacing with thiserror and anyhow.
Re-worked some futures which might end up constraining the executor.

I'm currently running a planet import to double check if there are long running memory issues. I will check if a move to mimalloc/jemalloc will help reduce long running memory growth, likely due to many concurrent executors and lots of allocations. It might also be in SQLite.

Fantastic work, thank you so much. Just going to run a quick smoke test then merge.

Found some very minor necessary changes, see: https://github.com/disasterscience/airmail/pull/5

Amazing! Thank you

That might be the biggest PR I've ever reviewed. Thanks for the contribution! Please don't hesitate to reach out if you have any issues with the project. I think you might be the first production user when you launch it so I'd love the hear any feedback you have.

Haha sorry about that... I definitely got a bit carried away. I was planning to adjust the docs but probs spent too much time thinking about what a prod deployment might need as I don't think it's far off. I will definitely report back and there might be a few smaller PRs. Thanks again, and let me know if I can help further too


Fixing SQL Server flink CDC setup

Fixed all outstanding issues to get sql server flink cdc working on a wide variety of tables.

@ChengJie1053 - spotless applied, try again.

@ChengJie1053 - spotless applied, try again.

Thank you very much, can the code be submitted to the master-SQLServer branch instead of master

Done: https://github.com/ChengJie1053/flink-cdc/pull/2


Fix #4357: Inc. optimizer: Invalidate callers if shouldInline changes.

In GenIncOptimizer, we diff the attributes of a MethodImpl before and after a change. When any of those changes, callers need to be reoptimized. Previously, the comparison was bogus because we forgot to take the shouldInline attribute into account.
We refactor the handling of attributes to make it harder to make this mistake in the future. We use one case class Attributes that aggregates everything we care about in the superclass OptimizerCore.MethodImpl. The subclass in GenIncOptimizer does not need to know the list of attributes anymore, since it manipulates an instance of Attributes as a whole.

Updated with full tests for the private implementation of SHA-1. Ready for another round of review.

Updated with full tests for the private implementation of SHA-1. Ready for another round of review.

somehowRotateABCDE: Wouldn't that just be something like state(i % 5)? Loop unrolling would also (IIUC) remove the need for the custom box.
+1 on making blk / blk0 more readable. There is so much mutability in there, "scary" is really the right term.

somehowRotateABCDE: Wouldn't that just be something like state(i % 5)? Loop unrolling would also (IIUC) remove the need for the custom box.
+1 on making blk / blk0 more readable. There is so much mutability in there, "scary" is really the right term.

I've pushed 3 commits that progressively move away from the C implementation and towards the pseudo-code on Wikipedia. If you're happy with the final result, I'll squash those with the commit that introduces the SHA-1 implem.

I've pushed 3 commits that progressively move away from the C implementation and towards the pseudo-code on Wikipedia. If you're happy with the final result, I'll squash those with the commit that introduces the SHA-1 implem.


Feature Request: also provide models in torchscript.

Request in title.
Would be really helpful to integrate WhisperSpeech easily into e.g. android.

Technically this should be possible, I marked this as a good first issue, in case someone likes to take a closer look into this.

It may be worth looking into the recent ExecuTorch as a possible alternative.
WhisperSpeech already works with torch.compile but I think we had some issues with torch.export around our implementation of RoPE.

This also worked:
ffmpeg -hide_banner -loglevel panic -i "test 1.mp3" -threads 1 -acodec pcm_s16le -ac 1 -af aresample=resampler=soxr -ar 16000 "test.wav" -y

It seems to be that Executorch isn't compatible with Androids NNAPI. However I'm unsure if that leads to worse performance.

Hello, @SR-Lut3t1um is exporting as .onnx a good alternative?

Well, according to the pytorch docs torchscript is required, so I'm afraid. onnx isn't going to be an alternative for that use case.

I am pretty sure it is possible to use ONNX Runtime and the NNAPI execution provider.
perhaps converting to ONNX may be less of a hassle

Yeah onnx should be fine too


Update rpc endpoints in polygon_testnet.md

Update the RPC endpoint URLs in the readme

Codecov Report

Merging #1268 (e37e715) into main (491e160) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
- Coverage   99.99%   99.98%   -0.01%
==========================================
  Files         308      308
  Lines       20557    20557
==========================================
- Hits        20555    20553       -2
- Misses          1        3       +2
  Partials        1        1

see 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Populate DB tables with data from SFData

Context
We need to create Postgres tables based on SQLAlchemy models and populate them with the subset (100 rows) of the GeoJSON data from the SFData API endpoints.
Definition of Done

Table Address is populated and all required fields are mapped accurately to the model.
Table Soft Story is populated and all required fields are mapped accurately to the model.
Table Seismic Hazard is populated and all required fields are mapped accurately to the model.
Table Liquefaction Hazard is populated and all required fields are mapped accurately to the model.
The code is modular, well-documented, and tested.

Engineering Details

Addresses dataset: https://data.sfgov.org/Geographic-Locations-and-Boundaries/Addresses-with-Units-Enterprise-Addressing-System/ramy-di5m/about_data
Soft story dataset: https://data.sfgov.org/Housing-and-Buildings/Map-of-Soft-Story-Properties/jwdp-cqyc
Seismic Hazard dataset: https://data.sfgov.org/-/San-Francisco-Seismic-Hazard-Zones/re79-p8j5/about_data
Liquefaction hazard dataset: https://data.sfgov.org/Geographic-Locations-and-Boundaries/Soil-Liquefaction-Hazard-Zone/i4t7-35u3/about_data

Thanks for the feedback, I updated the issue. We will put a limit of 100 rows for the time being.


Use smaller icons for extension icon

Currently using 48px, but optimal is 19px

Using 38px icons ... much better


[New Command] Test-DbaSqlBuild

Feature Request
Problem to solve
Get-DbaSqlBuildReference provides build information and the closest match:

Discussion with the team at Pythian and we'd like to have a command that we can utilize to determine the path to get up to the latest build.
So my local instance is SQL Server 2014 SP1 + some unknown patch since it does not match what is in our build reference file. The test command would have similar output but include some additional information:
SqlInstance: MANATARMS\SQL12
Current Build: 12.0.4237
Current SP: SP1
Current CU:
Recommended SP: <latest SP number>
Recommended CU: <latest CU to SP, or lastest CU to RTM>
Recommended KB: < could just be comma separated list of KB #s >

I think I remember starting a discussion with @ClaudioESSilva  and logging a ticket about what would be needed to test the build.....

This one: #1919 ? @niphlod

yes!
BTW: 4237 should be there, but as of right now serves as a good example

in the end we went for a small DSL like "-maxbehind 1SP 2CU" which should suffice for most scenarios. Will start coding once I get a bit of free time


Using bt_music_sender_write example but with input from SD card?

Hi,
I'm a beginner to ESP32 and such, and your lib is a great help.
I'm trying to make a MP3 player that read from SD card and output audio to bluetooth speaker.
How can I modify your bt_music_sender_write example to do this? Specifically, how should I read raw data from storage instead of predefined const variable (which makes sketch size big as you mentioned in README).
I'm using a M5Stack device, and trying to achieve this with this example: https://github.com/dsiberia9s/mp3-player-m5stack/blob/master/mp3-player-m5stack.ino
In the example above, they uses lib https://github.com/earlephilhower/ESP8266Audio, is it possible to integrate this lib with yours?
Best regards,
Cuong.

oh, I should mention that the m5stack example above plays mp3 files from SD card but to built-in speaker of the device

oh, I should mention that the m5stack example above plays mp3 files from SD card but to built-in speaker of the device

I would also be interested in this. I am trying to send numerical audio information to bluetooth headphones.

I am currently working on some more scenarios with examples. Here is a first basic SD example
https://github.com/pschatzmann/arduino-sound-tools/tree/main/examples/file_raw-a2dp


After playing video on any site (listed in first screen of the app) if we click Fab download button nothing happens

me too


add fontbm setup

This PR implements installation of the fontbm tool on macOS as discussed in #13.

I've committed the changes requested in setup.ts.
Regarding Apple Silicon, I don't have one of those yet, so I can't help. I imagine it should be fontbm should be able to run there as it is very portable C++ code from what I can tell. I'm sure @vladimirgamalyan would be happy for a PR to add that once someone figures it out.

I also needed to set FREETYPE_DIR in order to get cmake to build correctly.

Do we need to do that here in this tool?


[Feature] Progress bar

I can check progress from the command line, but the UI progress bar is not updated.  Any chance this can be integrated?

I created a progress bar in UI but causing error in older webui versions I will update it after I found a workaround !

older versions of webui?
the current commit 22bbc is already 2 month old, i have the commit even in my mind.
let us suggest to people updating auto1111. most do not know they are behind because they have local changes and got pull did not anything since ages:)


typo (jeager) in build.sbt

https://github.com/softwaremill/sttp/blob/55bb70ca71f07fef98f012a50837a64adfc30299/build.sbt#L1106
I think this is meant to be Jaeger. GitHub search doesn't seem to have other mentions of this - so maybe it isn't used.

Yeah, seems not used. Can you create a PR which cleans this up maybe? :)


Check if Dependabot changed /dist folder

Description
My change will add a new workflow job, which will:

Checkout PR branch
Set up Node.js
Install npm dependencies with npm ci
Run dist with npm run dist
Show git diff if change was made made to /dist folder via Dependabot and fail the workflow job

Motivation & Context
Conflict appeared because Dependabot changed the /dist folder.
Type of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[X] I have read the contributing guidelines
[ ] My code follows the code style of the project (using npm run lint)
[ ] My change introduces changes to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Related issues
Closes https://github.com/twbs/bootstrap/issues/37479

Thoughts on this @XhmikosR? I feel like our dist is never up to date except for the moment we release, so this probably is moot?

Yup, only when we release a new version we update the dist folder.


Accessing query param before getting body causes body become ""

caseController has following function
public Response addCase(String json, boolean checkEnabled);

Here is problem
public static void main(String args[]) {
    port(8080);
    // other codes
    // ...
    post("/cases", (request, response) -> {
        boolean checkEnabled = true;
        String checkEnabledParam = request.queryParams("check_enabled");

        if (checkEnabledParam != null && checkEnabledParam.contentEquals("false"))
            checkEnabled = false;

        String body = request.body();  // body=""
        return caseController.addCase(body, checkEnabled);
    });
}

If I move String body = request.body(); upper, problem resolves
public static void main(String args[]) {
    port(8080);
    // other codes
    // ...
    post("/cases", (request, response) -> {
        boolean checkEnabled = true;
        String body = request.body();  // body="..."
        String checkEnabledParam = request.queryParams("check_enabled");

        if (checkEnabledParam != null && checkEnabledParam.contentEquals("false"))
            checkEnabled = false;

        return caseController.addCase(body, checkEnabled);
    });
}

A simple example can't reproduce:
	    Spark.port(8080);
	    Spark.post("/foo", (request, response) -> {
	       request.queryParams("foo");
	       String body = request.body();
	       return body;
	    });

Can you try to strip your code to the bare minimum that reproduces the problem? Does this happen in embedded mode or when deployed on a server?
Also:

Request parameters are extra information sent with the request. For HTTP servlets, parameters are contained in the query string or posted form data.

Could that result in the input stream being processed and not reset, ie. there no content remaining in the stream, when Spark tries to read the body?

Finally, I was unable to write minimal program, that reproduces the bug.
import static spark.Spark.*;

public class Application {
        public static void main(String args[]) {
                port(8080);

                before((request, response) -> {
                        response.header("Content-Type", "text/plain");
                        response.header("Cache-Control", "no-cache");
                        response.header("Access-Control-Allow-Origin", "*");
                        response.header("Access-Control-Allow-Methods", "GET, POST, DELETE, OPTIONS, PUT, PATCH");
                        response.header("Access-Control-Allow-Headers", request.headers("Access-Control-Request-Headers"));
                });
                options("/*", (request, response) -> "");

                post("/bug", (request, response) -> {
                        boolean shouldBeMoon = request.queryParams("shouldBeMoon") != null;

                        String body = request.body();

                        return  "-----------------------\n" +
                                "shouldBeMoon: " + String.valueOf(shouldBeMoon) + "\n" +
                                "body: \n" + body + "\n" +
                                "------------------------";
                });

                post("/no_bug", (request, response) -> {
                        String body = request.body();
                        boolean shouldBeMoon = request.queryParams("shouldBeMoon") != null;

                        return  "-----------------------\n" +
                                "shouldBeMoon: " + String.valueOf(shouldBeMoon) + "\n" +
                                "body: \n" + body + "\n" +
                                "------------------------";
                });
        }
}

The bug is related to header of request Content-Type. Bug can be reproduced iff 'Content-Type: application/x-www-form-urlencoded`

This makes sense - in order to get the form parameters, request body is read, which then interferes with getting the body later on. Basically has to do how the application server handles things and is not really a Spark issue - unless @perwendel thinks this "should just work" which probably would mean Spark making a defensive copy of the request body?

Hm... I'm tempted to say it "should just work". @perwendel ?

@jakaarl Could you check if this is a lot of work (and if not create a PR?)

Today, I encountered the same problem. I was trying to get API key from query param in a filter and then use body in Route. Unfortunately, body is always an empty string.

Hmm. It does strike me as odd to pass values to the backend as a form with application/x-www-form-urlencoded and AT THE SAME time pass other values as query parameters. As if one cannot make up h(er|is) mind. What does the HTTP standard say about this? Does somebody know?

I created very simple webpage with jQuery to demo my backend to a client.
$.ajax({
  type: 'POST' ,
  url: '/foo',
  headers: {
    'X-API-Key': apiKey
  },
  data: xml,
  dataType: 'text'
})

in this situation jQuery sets Content-Type: application/x-www-form-urlencoded; charset=UTF-8. I was very surprised when body was set to empty string. To fix it I need to specify contentType: 'application/xml' in $.ajax. In my app you can add apiKey to query params or to the X-API-Key header.

Problem is, that the input stream does not necessarily support mark/reset, so we can't simply reset it. Instead, we'd have to wrap the servlet request in Request in order to intercept any calls to getInputStream() or getReader() in order to provide a stream or reader which for example copies on read in order to provide a "fresh" stream or reader on subsequent calls. Or does someone have ideas for an easier workaround?

OTOH, this is just the way it works: application/x-www-form-urlencoded basically sends query parameters in the body - they are available as query parameters, as they should. The content type indicates that. If params and a body are both needed, shouldn't the request be multipart/form-data?

Hello,
I use spark 2.8.0 and I have the same issue.
Spark.before((request, response) -> {...........}
If i try to do request.body() , the result is always empty. It's a bug.

Been dealing with this bug for a bit... we use spark in production and found a very odd workaround to this problem.
Minimal sample code to reproduce:
    public static void main(String[] args) {

        port(8888);

        before((request, response) -> {
            String queryParam = request.queryParams("someQueryParam");
            System.out.println("Before 1: " + queryParam);
        });

        post("/", (req,res) -> {
            return "\n\nBody: " + req.body() + "\n\n";
        });

    }

curl -X POST -d 'hello' localhost:8888
Workaround:
    public static void main(String[] args) {

        port(8888);

        before((request, response) -> {
            request.body();
            String queryParam = request.queryParams("someQueryParam");
            System.out.println("Before 1: " + queryParam);
        });

        post("/", (req,res) -> {
            return "\n\nBody: " + req.body() + "\n\n";
        });

    }

For some reason accessing the request body in the before filter stops it from coming up as an empty string in the post method. So in our code, anywhere we have a filter that accesses the QPs in a before filter, we have a ridiculous looking request.body() with comments saying //Don't delete this


Release 0.3.0

Coverage increased (+0.9%) to 97.913% when pulling d5b72f197946a187219ce4c7da4db62e467e4c92 on develop into 51ef0b9bf9c0b57d7616d8950481d86fcdefe2d7 on master.


no doc update on selection

@devoncarew changed it, thanks for your feedback

Thanks for the PR, lgtm.


Add some documentation

Would love some documentation on how this works, and how to implement it in a project.

Will do!

Fixed in 264b633a2956d3a9a27c7b8e4e425ae85ae5aee1


How to force bind address using kubeadm ?

Hello,
I use weave as kubeadm addon as described here : http://kubernetes.io/docs/getting-started-guides/kubeadm/
It starts well and kube-dns then startup well too, but when I try to deploy a pod, I got the following error :

Error syncing pod, skipping: failed to "SetupNetwork" for "my-nginx-379829228-9xgsa_default" with SetupNetworkError: "Failed to setup network for pod "my-nginx-379829228-9xgsa_default(c43a42fd-a9aa-11e6-a778-080027d95c6b)" using network plugins "cni": unable to allocate IP address: Post http://<IP_ADDRESS>:6784/ip/cc0ad82ba90685498e80e1835b2bcf2b3b0057c50dfd093734c0745502383075: dial tcp <IP_ADDRESS>:6784: getsockopt: connection refused; Skipping pod"

And the following in weave-net logs :

2016-11-13T14:17:38.653313621Z E1113 14:17:38.449836    6720 reflector.go:214] github.com/weaveworks/weave/vendor/k8s.io/client-go/tools/cache/reflector.go:109: Failed to list *v1.Namespace: Get https://<IP_ADDRESS>:443/api/v1/namespaces?resourceVersion=0: dial tcp <IP_ADDRESS>:443: i/o timeout

Which seems to indicate it does not use the right IP address, the private accessible address of my master node being a 192.168.x.x address on eth1.
How can I force weave to use my private network on eth1 instead of the NATed one on eth0 ?
Any help would be greatly appreciated.

Sorry, the issue was with my kubernetes configuration (the api was not exposed on the right address). Closing this issue.

Hi @soualid it looks like we have someone with a similar issue on https://groups.google.com/a/weave.works/forum/#!topic/weave-users/-JWHW_jAXNM - would you mind saying a little more about how you fixed yours?

As stated by Adam Harrison on the Google Groups thread, I just added the private hosts IP addresses in each nodes /etc/hosts and created the proper routes to make the nodes use it to communicate. After that, binding the API to the right (private) address using --api-advertise-addresses during kubeadm init call worked well.


Add view style to app.json

We should add the view style (grid or list) to the app.json so that companies can easily change this preference. We should default this variable to grid-view.

@ahuberbullhorn Are you referring to the default view when you initially load the application? There are the buttons to switch from list/grid at the top.

@jgodi Correct. Currently we default to the list, but we should default to the grid. Per feedback, this seems to be a more desirable viewing state. However, we should add this into the app.json file to allow for companies to easily change this.

Beginning work on allowing configuration of default view. Still need to add unit tests
feature branch

Merge Request pending


New package: SMG2S v0.1.0

Registering package: SMG2S
Repository: https://github.com/SMG2S/SMG2S.jl
Created by: @brunowu
Version: v0.1.0
Commit: 90f439b40672917a94213bf5c4fe2ce801493d49
Git reference: 0.1.0
Description: A julia implementation of SMG2S (Sparse Matrix Generator with Given Spectrum)

This pull-request can be closed.
A new pull request (#55115 ) has been created with a new name for the package.


Basic Authentication Tests

We need to start writing jest tests in crowd.Bible. let's start with verifying basic authentication. Aslam is the developer that has integrated the SSO service. Work with him on any issues with setting up the crowd.Bible repo and dev.crowd.Bible website for automated testing.
First basic tests just need to test the happy path. We don't want to create a lot of tests right now. We just need to focus on proving the user can perform basic tasks.

Ensure crowd.Bible is setup for jest tests.
User can register. After registration, user is automatically logged in.
User can login.
User can logout.
User can login after a logout.

Sure @michaelmarshall thanks,

Hello @michaelmarshall @aslambabu
I've setup the local environments for Crowd.Bible and UI/Graphql is working on below URLs locally :
http://localhost:8201/graphql
http://localhost:8100/home
Can you please point to related UI and API's - Mutation/Queries and Flow if possible for the Auth tests so I can get started here ?

Do let me know if I'm missing anything here.
Thanks,


Create Blazor Server App with IndAuth > F5 and register > Click the user name > Click Logout, it doesn't work.

From @v-yuyul on Tuesday, September 3, 2019 9:18:42 AM
Repro Configuration: Win10 x64 19H1 ENU + Dev16.4 preview 1 (Preview channel : pre-release-build)VSC + Feed
.NET Core SDK (CLI) Version: 3.0.100-preview9-014004
.NET Core runtime Version: 3.0.0-preview9-19423-09
Testcases Affected: [3.0] SimpleWebAppWithServerSideBlazorIndAuth
Regression Info: It doesn't repro with 3.0 preview 6 but repro with 3.0 preview 8.
Install Steps

Clean machine: Win10 x64 ENU 19H1

Install Dev16.4 preview 1(master-29302.5)VSC

Run preinstall.cmd: \\vspreinstall\preinstall\preinstall.cmd
Install from here
Select NET Core + .NET Desktop workload
Check .NetCore 2.2 Runtime under IC tab
Add feed: https://pkgs.dev.azure.com/dnceng/public/_packaging/3.0.0-preview9-014004/nuget/v3/index.json

Repro Steps

File > Create a new project > Blazor App > Blazor Server App with IndAuth > Create
F5 > Register a new user> Click the user name on the top-right corner of browser> Click Logout, it doesn't work.

Note: It works fine in Home page, if you don't click the user name.
ACTUAL:
After clicking Logout:

Copied from original issue: aspnet/AspNetCore-ManualTests#16

From @mkArtakMSFT on Tuesday, September 3, 2019 3:20:57 PM
@javiercn can you please investigate this? Thanks!

From @javiercn on Tuesday, September 3, 2019 4:15:17 PM
This is a bug on the template.
/Areas/Identity/Shared/_LoginPartial.cshtml should have the content below. (With a form instead of a link)
@using Microsoft.AspNetCore.Identity
@inject SignInManager<IdentityUser> SignInManager
@inject UserManager<IdentityUser> UserManager
@addTagHelper *, Microsoft.AspNetCore.Mvc.TagHelpers

@if (SignInManager.IsSignedIn(User))
{

        Hello @User.Identity.Name!

        <form class="form-inline" asp-area="Identity" asp-page="/Account/Logout" asp-route-returnUrl="/" method="post">
            <button type="submit" class="nav-link btn btn-link text-dark">Logout</button>
        </form>

}
else
{

        Register

        Login

}

This is the piece we need to change
        <form class="form-inline" asp-area="Identity" asp-page="/Account/Logout" asp-route-returnUrl="/" method="post">
            <button type="submit" class="nav-link btn btn-link text-dark">Logout</button>
        </form>

From @javiercn on Tuesday, September 3, 2019 4:16:41 PM
@mkArtakMSFT @danroth27 We can fix this in 3.1, the workaround is described above. We can add it to the list of known issues.
Can you move it to the asp.net core repo?

@javiercn how is this not impacting non-blazor scenarios? Or does it?

Also, @javiercn if this is pure Identity change - you can hand it off to @HaoK to handle as part of the other Idenitty related changes for 3.1.

@mkArtakMSFT This is a template change. The _LoginPartial.cshtml is incorrect in the Blazor server-side template.


IDE Performance Issues

Issues
I have extensively tested the performance of IDE and I have found several critical issues listed below. Please feel free to partition them into separate issues if needed, but I believe we can just fix them and untick them here instead to keep a single performance thread for an easy overall picture.

[x] IDE logs so many things to console that it gets unresponsive sometimes. Logging to console should be enabled by a developer for debugging purposes, but never in the final product on the main branch. The console should be empty and should contain warnings and errors ONLY until the logs will not be enabled during runtime on purpose. This needs to be fixed ASAP.

[ ] Writing a SINGLE LETTER in searcher costs 30ms parser time (this will be fixed with new parser) + 90ms of updating the "list view", which is caused by regeneration of MSDF things on every keystroke (!). This means that updating the view on each key-press in searcher makes the GUI run at MAX 10 FPS.

[ ] After moving each node, all nodes get event set_expression which causes them to be re-drawn from scratch. This is a huge bottleneck for scenes containing many nodes.

[ ] After opening an empty scene, a node is created, and its expression is set to "Hello world" 6 times (!!!), and then it gets probably deleted cause it's not visible on the stage. Moreover, the expression "Hello world" is set on it every time a node is moved.

[ ] After starting the new project and putting node 12 on the stage, you have to wait 6-8 seconds to get it colored. The next nodes are getting colored fast, but the first is really, really slow.

[ ] I have nodes 12 and _.asin on the stage. I'm connecting 12 to _. As the result: the expression "Hello world" was set 4 times, the expression 12 was set 4 times, and the expression number1.asin was set 4 times.

[ ] Create node 12. You will get 15 notifications that its type is None and then 4 notifications that its type is Number.

[ ] Create node 12. On each move, you will get 2 events about its type (should be 0).

[ ] Create node 12. Press tab, select asin, press enter. We will get several interesting events. First, we got event about new expression number1.asin with INCORRECT SpanTree containing only Root node covering the whole expression. The correct SpanTree will be emitted later.

[ ]
Guess how many times our theme manager is queried for colors for a given type after I remove the second node and keep on the scene only the first one?  Click me to learn the answer.The answer is: 1600

+1 for Tauri, this makes perfect sense for Enso and can easily replace Electron

I use them together a lot.  Rust on the backend with Tauri is a huge performance boost.
The performance of Svelte blows React away - especially when paired with nanostores, and dev speed with it is much faster too.  SolidJS would also be a killer alternative if you can't give up JSX.

Svelte is nice, but I don't expect them to rewrite the UI - switching to Tauri however can be like running in a different browser (webview) which means very little of the codebase needs to change (just the packaging). I don't see anything wrong with whatever they're using for the UI but the performance bottleneck of electron is too important to ignore and now easy to replace (one can also use NeutralinoJS for example)


Support existingSecrets

It would be nice to allow chart users to specify an existingSecret for htpasswd as well as a handful of other Secrets that are currently either auto-generated or required to supply a value directly. (Admittedly, htpasswd is hashed, but it is still not ideal to keep the hashed value in Git.)
See some great examples in the various bitnami helm charts.

I'm looking for this too. I want the password to be randomly generated on deployment using a Job, but with the actual file contents being required at chart compile time, this is not possible.

Me also, it would be nice to use real secrets instead of hard-coding values for the chart.

it would be nice to provide a Secret resource with the kubernetes.io/basic-auth type.


Reader access to the Azure portal -- meaning unclear

"Using the Number Management Portal | NumberManagement.Read, NumberManagement.Write, PartnerSettings.Read, and PartnerSettings.Write roles for the Project Synergy enterprise application and Reader access to the Azure portal for your subscription"
Feedback:
What does "Reader access to the Azure portal for your subscription" mean? Is that different from "Reader access to the subscription" or is it just worded a bit strange? As a reader, I don't know what access to provide for users in this role.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 76010493-03c9-b310-0627-748cb3dc9980
Version Independent ID: 2d0fcd57-5472-4092-3f22-9d717534b4c9
Content: Set up user roles for Azure Communications Gateway
Content Source: articles/communications-gateway/provision-user-roles.md
Service: communications-gateway
GitHub Login: @rcdun
Microsoft Alias: rdunstan

@Dawnes
I've delegated this to @Dawnes, a content author, to review and share their valuable insights.

Hi @Dawnes,
Thank you for the feedback. I've updated the wording to be simply "Reader access to your subscription", like the other permissions. The change is now available on https://learn.microsoft.com/en-us/azure/communications-gateway/provision-user-roles.
Thanks again,
Rachel

#please-close


Random Segmentation Faults

I'm reading from MS Sql Server using Microsoft ODBC driver, V17.
I run in a container with the miniconda3 base image and build a conda env using
python 3.7
turbodbc 4.1.2 (conda-forge)
pyarrow 3.0 (conda-forge)
I'm reading the data out of the cursor using cursor.fetchallnumpy() . Randomly, I see a seg fault. I tried building turbodbc rather than pulling in the package from conda-forge and got the same result. I can run the same query 50 times in a loop and only occasionally will it crash. Enabling fault handler points to an error in cursor.close() when self.impl._reset() is called.
Any ideas on how to further troubleshoot?

Can you please post the traceback?

Sure, there isn't much to it though. A little bit of added information is that this happens as part of an Arrow Flight server, so I'm not sure if the threading that takes place inside the flight server is in some way causing a problem with the threads being used by Turbodbc.
flight-server_3  | Thread 0x00007f3085b0e700 (most recent call first): flight-server_3  |   File "/opt/conda/envs/arrow-flight/lib/python3.7/site-packages/turbodbc/cursor.py", line 380 in close flight-server_3  |   File "/usr/local/flight_server.py", line 153 in _turbodbc flight-server_3  |   File "/usr/local/flight_server.py", line 64 in do_get

Originally, I had use_async_io=True in the connection_options. If I remove that, then  the seg faults go away.  I'll try and do some testing of turbodbc outside the flight server, however it's looking more to me like it's the combination of the packages that are causing the issue..

Yes, things run fine outside of flight so it is related to the interaction between the 2 libraries. I'm at a bit of a loss how to further troubleshoot though.

I'm a bit confused about the /usr/local part in /usr/local/flight_server.py. Is that your code? Otherwise this would be spooky as all dependencies should be part of the conda environment.

yes,  everything in /usr/local/flight_server.py is my code. _turbodbc is a method there -
def _turbodbc(self, connection_string, query, params):
        from turbodbc import connect, make_options
        from turbodbc.exceptions import DatabaseError
        connected = False
        connection_options = make_options(
            use_async_io=True,
            varchar_max_character_limit=2000000
        )
        try:
            conn = connect(
                turbodbc_options=connection_options, connection_string=connection_string
            )
        except DatabaseError:
            time.sleep(2)
            conn = connect(
                turbodbc_options=connection_options, connection_string=connection_string
            )
        is_committed = False
        data = None
        cursor = conn.cursor()
        try:
            cursor.execute(query, parameters=params)
            if cursor.description:
                self.logger.debug(query)
                data = cursor.fetchallnumpy()
            else:
                self.logger.debug('empty result set')
            cursor.close()
            conn.commit()
            is_committed = True
        except Exception as e:
            print(e)
            print(query)
            cursor.close()
            if not is_committed:
                conn.rollback()
            raise
        finally:
            conn.close()
        return pa.Table.from_pydict(data or {})```


TensorRT

Hi.. pretty nice library.
Have you tryed converting the resulting model to tensorrt?
Thanks

Hi,
Thank you.
I will consider it and make an update when I have time.
Thanks for your concern.


Update to Scala 3.0.0-M2

Based on top of #1923
Dotty PR: https://github.com/lampepfl/dotty/pull/10503

@nicolasstucki I notice there are now 6 tests failing (passed in 3.0.0-M1):
> sbt scalatestTestDotty/test
...
[info] Run completed in 16 seconds, 600 milliseconds.
[info] Total number of tests run: 6313
[info] Suites: completed 310, aborted 0
[info] Tests: succeeded 6307, failed 6, canceled 7, ignored 8, pending 18
[info] *** 6 TESTS FAILED ***
...
[info] OldDocSpec:
[info] The stripMargin method
[info] - when passed a string with leading space, should return the string with the leading space omitted *** FAILED *** (0 milliseconds)
[info]   "[ ]Howdy" did not equal "[]Howdy" (OldDocSpec.scala:181)
[info]   Analysis:
[info]   "[ ]Howdy" -> "[]Howdy"
[info] OldDocSpec:
[info] The stripMargin method
[info] - when passed a string with leading space and two lines, should return the string with the leading space omitted from the first line, and the same amound omitted from the second line, with tabs converted to one space *** FAILED *** (0 milliseconds)
[info]   "[ Howdy
[info]   1]23456789" did not equal "[Howdy
[info]   ]23456789" (OldDocSpec.scala:189)
[info]   Analysis:
[info]   "[ Howdy
[info] 1]23456789" -> "[Howdy
[info] ]23456789"
[info] OldDocSpec:
[info] The stripMargin method
[info] - when passed a string with one or more blank lines, a line with leading space and two lines, should return the string with the leading space omitted from the first line, and the same amound omitted from the second line, with tabs converted to one space *** FAILED *** (0 milliseconds)
[info]   "
[info]   [ Howdy
[info]   1]23456789" did not equal "
[info]   [Howdy
[info]   ]23456789" (OldDocSpec.scala:197)
[info]   Analysis:
[info]   "
[info] [ Howdy
[info] 1]23456789" -> "
[info] [Howdy
[info] ]23456789"
[info] DocSpecSpec:
[info] The stripMargin method
[info] - when passed a string with leading space, should return the string with the leading space omitted *** FAILED *** (0 milliseconds)
[info]   "[ ]Howdy" did not equal "[]Howdy" (DocSpecSpec.scala:223)
[info]   Analysis:
[info]   "[ ]Howdy" -> "[]Howdy"
[info] DocSpecSpec:
[info] The stripMargin method
[info] - when passed a string with leading space and two lines, should return the string with the leading space omitted from the first line, and the same amound omitted from the second line, with tabs converted to one space *** FAILED *** (0 milliseconds)
[info]   "[ Howdy
[info]   1]23456789" did not equal "[Howdy
[info]   ]23456789" (DocSpecSpec.scala:231)
[info]   Analysis:
[info]   "[ Howdy
[info] 1]23456789" -> "[Howdy
[info] ]23456789"
[info] DocSpecSpec:
[info] The stripMargin method
[info] - when passed a string with one or more blank lines, a line with leading space and two lines, should return the string with the leading space omitted from the first line, and the same amound omitted from the second line, with tabs converted to one space *** FAILED *** (0 milliseconds)
[info]   "
[info]   [ Howdy
[info]   1]23456789" did not equal "
[info]   [Howdy
[info]   ]23456789" (DocSpecSpec.scala:239)
[info]   Analysis:
[info]   "
[info] [ Howdy
[info] 1]23456789" -> "
[info] [Howdy
[info] ]23456789"
[error] Failed tests:
[error]         org.scalatest.OldDocSpec
[error]         org.scalatest.DocSpecSpec
[error] (scalatestTestDotty / Test / test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 309 s (05:09), completed Nov 26, 2020 10:54:05 PM

Can you see if it is expected?
Anyway, I have staged 3.2.3 build for Scala 3.0.0-M2 using this PR, @bvenners will have the pleasure to release it.  :)

I had issues with the tests never finishing. Did they finish for you?

@nicolasstucki The tests did finish for me, though it did take some time to build before running.

@nicolasstucki Just in case SBT_OPTS matter, I have:
export SBT_OPTS="-server -Xms512M -Xmx10G -Xss10M -XX:+UseConcMarkSweepGC -XX:NewRatio=8"

I did that but I got
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512M; support was removed in 8.0

maybe that is my issue

Now it seems to be working

I do not see any reason why those tests should have changed. Might be a bug.

@cla-bot[bot] check

@cheeseng The last commit should fix the CI failure. Could you please confirm?

@liufengyun Sorry just saw your message now, it is a bit late over here, I'll try your fix in the morning tomorrow.
Cheers!

@liufengyun I tried it but unfortunately it failed to build with the following compile errors:
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:218:52
[error] 218 |      a [NullPointerException] should be thrownBy { stripMargin(null) }
[error]     |                                                    ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:221:6
[error] 221 |      stripMargin("") should equal ("")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:224:6
[error] 224 |      stripMargin(" Howdy") should equal ("Howdy")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:225:6
[error] 225 |      stripMargin("  Howdy") should equal ("Howdy")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:226:6
[error] 226 |      stripMargin("   Howdy") should equal ("Howdy")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:227:6
[error] 227 |      stripMargin("\tHowdy") should equal ("Howdy")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:228:6
[error] 228 |      stripMargin("\t\tHowdy") should equal ("Howdy")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:229:6
[error] 229 |      stripMargin(" \t \tHowdy") should equal ("Howdy")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:232:6
[error] 232 |      stripMargin(" Howdy\n123456789") should equal ("Howdy\n23456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:233:6
[error] 233 |      stripMargin("  Howdy\n123456789") should equal ("Howdy\n3456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:234:6
[error] 234 |      stripMargin("   Howdy\n123456789") should equal ("Howdy\n456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:235:6
[error] 235 |      stripMargin("\tHowdy\n123456789") should equal ("Howdy\n23456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:236:6
[error] 236 |      stripMargin("\t\tHowdy\n123456789") should equal ("Howdy\n3456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:237:6
[error] 237 |      stripMargin(" \t \tHowdy\n123456789") should equal ("Howdy\n56789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:240:6
[error] 240 |      stripMargin("\n Howdy\n123456789") should equal ("\nHowdy\n23456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:241:6
[error] 241 |      stripMargin("\n  \n\n  Howdy\n123456789") should equal ("\n\n\nHowdy\n3456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:242:6
[error] 242 |      stripMargin("\n  \t\t\n   Howdy\n123456789") should equal ("\n\t\nHowdy\n456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:243:6
[error] 243 |      stripMargin("\n\n\n\n\tHowdy\n123456789") should equal ("\n\n\n\nHowdy\n23456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:244:6
[error] 244 |      stripMargin("\n\t\tHowdy\n123456789") should equal ("\nHowdy\n3456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/DocSpecSpec.scala:245:6
[error] 245 |      stripMargin("\n      \n \t \tHowdy\n123456789") should equal ("\n  \nHowdy\n56789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class DocSpecSpec
[error]     |and imported by name subsequently by import org.scalatest.DocSpec.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:176:52
[error] 176 |      a [NullPointerException] should be thrownBy { stripMargin(null) }
[error]     |                                                    ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:179:6
[error] 179 |      stripMargin("") should equal ("")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:182:6
[error] 182 |      stripMargin(" Howdy") should equal ("Howdy")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:183:6
[error] 183 |      stripMargin("  Howdy") should equal ("Howdy")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:184:6
[error] 184 |      stripMargin("   Howdy") should equal ("Howdy")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:185:6
[error] 185 |      stripMargin("\tHowdy") should equal ("Howdy")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:186:6
[error] 186 |      stripMargin("\t\tHowdy") should equal ("Howdy")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:187:6
[error] 187 |      stripMargin(" \t \tHowdy") should equal ("Howdy")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:190:6
[error] 190 |      stripMargin(" Howdy\n123456789") should equal ("Howdy\n23456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:191:6
[error] 191 |      stripMargin("  Howdy\n123456789") should equal ("Howdy\n3456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:192:6
[error] 192 |      stripMargin("   Howdy\n123456789") should equal ("Howdy\n456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:193:6
[error] 193 |      stripMargin("\tHowdy\n123456789") should equal ("Howdy\n23456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:194:6
[error] 194 |      stripMargin("\t\tHowdy\n123456789") should equal ("Howdy\n3456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:195:6
[error] 195 |      stripMargin(" \t \tHowdy\n123456789") should equal ("Howdy\n56789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:198:6
[error] 198 |      stripMargin("\n Howdy\n123456789") should equal ("\nHowdy\n23456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:199:6
[error] 199 |      stripMargin("\n  \n\n  Howdy\n123456789") should equal ("\n\n\nHowdy\n3456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:200:6
[error] 200 |      stripMargin("\n  \t\t\n   Howdy\n123456789") should equal ("\n\t\nHowdy\n456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:201:6
[error] 201 |      stripMargin("\n\n\n\n\tHowdy\n123456789") should equal ("\n\n\n\nHowdy\n23456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:202:6
[error] 202 |      stripMargin("\n\t\tHowdy\n123456789") should equal ("\nHowdy\n3456789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[error] -- [E049] Reference Error: /home/cheeseng/git/scalatest/dotty/scalatest-test/target/scala-3.0.0-M2/src_managed/test/org/scalatest/OldDocSpec.scala:203:6
[error] 203 |      stripMargin("\n      \n \t \tHowdy\n123456789") should equal ("\n  \nHowdy\n56789")
[error]     |      ^^^^^^^^^^^
[error]     |Reference to stripMargin is ambiguous,
[error]     |it is both defined in class OldDocSpec
[error]     |and imported by name subsequently by import org.scalatest.Doc.stripMargin
[warn] two warnings found
[error] 40 errors found
[error] (scalatestTestDotty / Test / compileIncremental) Compilation failed

I submitted the following PR to your branch here to fix them:
https://github.com/dotty-staging/scalatest/pull/13
@nicolasstucki @liufengyun  Just trying to see If I understand it correctly, it is the cause is the stripMargin in the global scope now take precedence over the one imported at the top, is that right?

@nicolasstucki @liufengyun Just trying to see If I understand it correctly, it is the cause is the stripMargin in the global scope now take precedence over the one imported at the top, is that right?

Thanks @cheeseng . Yes, it is due to that this.stripMargin (defined in Assertions) takes precedence over the imported one.


Configuration option to disable "Conversation Subject"

From playing around with the demo I noticed "Conversation Subject". In the cases where someone might want to reproduce a system like the Facebook Messenger; i.e. - no conversation subject, is it possible to bundle messages by recipient rather than Conversation Subject?
i.e. - Is it possible to easily remove Conversation Subject and have Conversations based on receipients without changing so much code?

Hello :) !
The subject is fully optionnal in FOSMessage: you can easily disable it just by not providing it. A quite simple way to implement a "participants based" conversation system is to create a conversation between users the first time they talk together and then reuse this conversation object instead of creating a new one. It's not complicated, but if I'm not clear, don't hesitate to ask :) !

Hey @tgalopin! Thanks for the fast response again.
That sounds great, I just wanted to double check that it was easily configurable.
I haven't had a chance to look that closely at the code yet, more so at the driver so far. Ideally I'd like to make that Subject optional for any users of a Drupal module. So I guess I'd need some logic to switch between participants based and subject based conversation system. Where is the best home for this kind of logic?

I guess this should be an option in your module, and using this option, you should be able in your controller to either create a new conversation (with a subject or not) or load the existing one.

Awesome, that makes sense. Thanks.


[SC-225224] copy changes to upload flow

Summary:

What: Copy changes to upload flow for mpox
Ticket: sc225224
Env: none

Demos:

Notes:
The upload flow works.  There might be a bug with parsing the metadata file - I created a follow up ticket to look into this.
Checklist:

[x] I merged latest <base branch>
[x] I manually verified the change
[x] I added labels to my PR
[x] I tested in multiple browsers
[ ] I added relevant unit tests
[ ] I have notified others of changes they need to make locally (migrations, jobs, package updates, etc)

[ ] Update nextstrain defaults link in instructions to go here: https://docs.nextstrain.org/projects/ncov/en/latest/reference/metadata-fields.html


Add support for light client state prover

this is a parent issues explaining the design & overall progress, subtasks should be created for each individual points.
Replica:

When register on the stake table in L1, generate a Schnorr key pair (besides the HotShot’s consensus key which is bls-over-bn254)
On every new finalized block, if it leads to a new finalized LightClientState then the replica sign the new state and store the Schnorr signature locally and send one copy to the CDN

The copy are sent alongside the normal consensus vote in that round (i.e. no extra round is required)

Garbage collect: replicas also subscribe event stream from LightClient.sol on L1, when event NewFinalizedState is emitted, replicas delete all signatures on that state and even older ones. We could also add a worst-case storage cap on how long these signatures would be kept before being pruned.

Assume a worst-case delay on L1 light client update of 5 hour (and assume 3 sec block time), each replica only keeps ~6k * 64 = 0.38MB of signature data, ~6k * 208 = 1.25MB of state/message data locally.

Pessimistic case: in case of CDN failures, replica would send over their signatures to the prover

Since we don’t want anyone to DOS replica, how do we prevent that?

CDN:

Index all Schnorr signatures received by the block_height field of the signed message, and cached them
Upon request from the hotshot-state-prover on a specific block height, serve all Schnorr signatures cached
Garbage collect: same as that of Replica

cc @jbearer @philippecamacho @fkrell @chancharles92

Pessimistic case: in case of CDN failures, replica would send over their signatures to the prover
Since we don’t want anyone to DOS replica, how do we prevent that?

Is this problem not similar to the problem DoS against replicas by trigerring VID shares reconstruction? IIUC we reached the conclusion that this is a fundamental issue in distributed systems in general.

Pessimistic case: in case of CDN failures, replica would send over their signatures to the prover
Since we don’t want anyone to DOS replica, how do we prevent that?

Is this problem not similar to the problem DoS against replicas by trigerring VID shares reconstruction? IIUC we reached the conclusion that this is a fundamental issue in distributed systems in general.

Exactly. So I guess will proceed with directly fetching signatures from replicas, with standard DoS protection. There are way more entry points for DoS attacks beside ours.

Moved to https://github.com/EspressoSystems/espresso-sequencer/issues/801


Migrate polymer 1.0

Closes meteor-useraccounts/polymer#6, but requires Differential/meteor-vulcanize#24 to be closed before it can run on Meteor 1.2

:+1:

...I'm having problem running the app.
After running bower install I'm getting
Uncaught TypeError: Polymer is not a function
and nothing is rendered.
It seems a load order problem, since after several errors while loading elements, the Polymer object is defined and you can get it from the browser console.
Any idea?

It seems to be the issue with vulcanize using outdated API that no longer works in 1.2, so Polymer never gets included.
I'm waiting on a pull request of mine to be merged so it can work in 1.2, but until then, you can clone this branch into the local packages folder and it should override vulcanize with a working version and then work properly.
I did try to convince it to run on an older version of Meteor, but I had no luck getting it to stay there.

Up and running! :-)
I also added some instructions to get your working copy of differential vulcanize, see https://github.com/meteor-useraccounts/boilerplates/commit/3f40c1dc5c35c374a0fa133c90ca9b0a656d3fc3
I was sure it was ok, but I had to check ;-)
Thanks again for the contribution!

:+1:


fix: add output folder argument to check_viallabel_dmaqc call on proteomics qc

out_qc_folder missed in check_viallabel_dmaqc. File proteomics_qc.R, function validate_proteomics

Fix in v0.6.8


Monorepos and subdirs

It's common to want to run a buildpack against a sub-directory within an app repo. This is particularly necessary when the repo is a monorepo composed of multiple applications. For example, it might have the structure
my-monorepo
├── backend
│   └── pom.xml
├── frontend
│   └── package.json
└── worker
    └── requirements.txt

We should consider supporting this use case, or explicitly rule it out.

I'm leaning towards yes, but have many questions about how such a thing would appear to the buildpacks at execution time.  Definitely worth discussing as we've seen requests that would likely be satisfied by something here.

To add context from the JS community, by far the most commented-on issue and requested feature for the Heroku buildpack is monorepo support: https://github.com/heroku/heroku-buildpack-nodejs/issues/385
It's not always as simple as the above diagram. Many of these use separate directories for shared code such as between frontend and backend that would need to be packaged alongside either.
my-monorepo
├── package.json
├── shared-code
│   └── package.json
├── backend
│   └── package.json
├── frontend
│   └── package.json
└── worker
    └── requirements.txt

If sub-directories are used as a mechanism to distinguish between the apps in a mono-repo, we'll need some configuration for the ability to pull in other directories at build time.
Though it would be nice if there were a mechanism exposed to the buildpack itself that would allow it to determine what is needed when that can be determined statically, such as with Yarn workspaces.


Dorling Cartograms

Please consider implementing a useful D3plus version of a Dorling Cartogram to solve the ubiquitous problem of poor representations of the spatial distribution of demographic data.
In the basic case, over 80% of the US population is urban, but 90% of US counties are rural, so simple choropleth maps are EXTREMELY misleading. Take, for example, this election map from a year that democrats (blue) won the election by a handy margin - though this map would suggest otherwise:

Or a recent example from the preeminent urban publication CityLab:

And on your own Data USA site:
http://datausa.io/map/?level=county&key=median_property_value,median_property_value_moe
http://datausa.io/map/?level=county&key=grads_total_growth
It is even worse when data is aggregated by census tracts since each tract is designed to hold a somewhat proportionate number of people, in which case they are sized exactly disproportionately to the demographic data they are trying to communicate.
The solution is a Dorling Cartogram, which maintains the spatial integrity of counties / census tracts, but it scales each unit relative to the population within:

There are some good prototypes that have been developed:
http://mbostock.github.io/protovis/ex/cartogram.html
https://www.jasondavies.com/maps/dorling-world/
http://mbostock.github.io/d3/talk/20110921/collision.html
But nothing that uses counties / census tracts (the typical units of analysis for media reporting) and that is useful enough for popular consumption.
Please consider developing a useful implementation so that spatial demographic data can be represented honestly!

I love this idea!


Some more instructions would be appreciated

Hi!
I'm trying to build dart-sass as described, but I get an error about the lock file missing. This makes sense, but the question is, how am I supposed to get the initial lock file?
error: assertion '((builtins).pathExists  lockFile)' failed

       at /nix/store/lq06mr719q1dq3plg1i5y2wcnsz5p323-source/build.nix:23:1:

           22| assert builtins.pathExists specFile;
           23| assert builtins.pathExists lockFile;
             | ^
           24| let
(use '--show-trace' to show detailed location information)

You should be able to run pub get, at least that's what I do in my update script.

Great, I should be able to just use that, then.


Pagination

Is it possible to implement record pagination with this VE provider approach? The page currently does not mention this topic.
For example, we're working on an implementation where 20 million rows will reside within Azure SQL. We have determined that the maximum number of rows that we'll need to retrieve, and allow users to page through, in Dataverse is 350. Could the authors of this page explain whether this is supported and, if so, how they recommend implementing this paging functionality? Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: edbeb418-f5d9-da8d-7598-d4965f666e50
Version Independent ID: f28b539d-69f1-5f2e-6f32-4248cb96eedf
Content: Sample: Custom virtual table provider with CRUD operations (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/virtual-entities/sample-ve-provider-crud-operations.md
Service: powerapps
Sub-service: dataverse-developer
GitHub Login: @NHelgren
Microsoft Alias: nhelgren

Thanks for your comment, @tdutch1. This issue has been assigned to the doc author for review.

Hi tdutch, pagination is enabled by default for virtual tables. Each retrieval is limited to 250 records but through paging the next set of applicable records than can be retrieved. If you are using a grid or list view the pagination should function automatically. How are you planning to implement the feature?

@NHelgren Thank you for your reply. I'm glad I have that information now, but my point was that the article does not mention pagination nor that it's necessary to provide a value for the MoreRecords and PagingCookie properties of the EntityCollection that's constructed from the results of the SQL Server query. Maybe it should be obvious that setting those properties would result in the Dataverse grid going from disabled pagination controls to becoming enabled, but it took us quite a bit of experimentation to discover this.
In regards to how we're planning to implement the feature, we're working with a very large company in the transportation industry. They have hundreds of millions of records in multiple tables in Azure SQL and they want to be able to view subsets of that data within Dataverse. We mentioned to them that we could build or license OData v4 middleware to meet the requirements but we also wanted to determine whether the functionality described in the "Custom virtual table" article could also work. Our initial impression, due to some incorrect and omitted details in the article, was that this functionality was not capable of providing the needed functionality. Thus, please consider updating the sample code with the ten or so extra lines of code that shows how to implement paging, or at least mention paging in context with the MoreRecords and PagingCookie properties.

Add information about paging in context with the MoreRecords and PagingCookie properties to the article.


New logo for Toil

Hello, I designed a logo for Toil. If you like it, I will give you this logo as a gift.

Very cute! Thank you for the effort, we'll talk it over as a team.

Thanks! After you make a decision, I will send you the necessary files if you post messages.


Fix #7473 rename alias correctly on edit

If you change an alias name, but have other input errors on the initial attempt to save, then fix the input errors and save again, the alias name did not get updated in Rules/NAT/etc where it was used.
Refactor update_alias_names_upon_change also (which I was looking at before seeing this bug), to get rid of all that repeated code. Where it is used in diag_backup when restoring a m0n0wall config, it does not hurt to try to rename any port aliases etc also, in case somehow there were port aliases in an old m0n0wall config.

Note: Redmine 7473 is a duplicate of 7394. This PR fixes both.


Accessibility issues in brief.

Bootstrap 4 recommendations for accessibility.
https://v4-alpha.getbootstrap.com/
Looking through current and closed issues some of these have been touched upon.
Modal
Issue:
role="dialog" is missing required attributes.
Solution:
A Dialog is a descendant window of the primary window, where initial focus goes to an element within the dialog.
The container that includes role="dialog" must also include a valid label:

aria-label
aria-labelledby
aria-describedby is required to point to the message body for the Dialog text.

If the Dialog is meant to be modal, aria-modal="true" must be set on the container that contains role="dialog".
Recommendation
remove role="document".
Role=documents purpose is to negate the use of role="application" in limited circumstances.
Accordion
Issues

Aria-tab missing aria-selected attribute
Aria-tabpanel should not be nested within aria-tablist

ARIA attributes such as role="tablist" and role="tab" should not be included within an accordion.
This is because the insertion of inline content would place dynamic content sections within the same Tablist container, making it impossible to determine the order of nested Tab controls when present within the inserted content
Tab controls
Issues

Aria-tab missing aria-selected attribute.
A Tab Control should have only one tab stop. The arrow keys are then used to switch focus between each Tab, and the ENTER or SPACE key is used to expand the desired Tab content panel.
To address current issues with IOS, where the correct number of tabs is not announced correctly by VoiceOver, include aria-setsize and aria-posinset, this will force the screen reader to announce the correct numbering.

A note about carousels
Expected behaviors: The beginning and ending boundaries should be conveyed to screen reader users.
Role="region" aria-label="carousel".
Note: content changes should be announced to screen reader users only when a navigation button is manually activated.
All navigation buttons should be keyboard accessible and include unique accesskeys for screen reader users.
Alt + 1 Previous slide alt + 2 next slide.
Auto cycling should pause when an element within the carousel receives focus or when the mouse is moved into the region.
Auto cycling should resume when focus moves out of the carousel or when the mouse moves out of the region, and auto cycling should be stoppable from anywhere on the page using the keyboard.
What is the time frame for the closed issues be applied to the examples? It would be good to run testing on the updated versions.
Thanks for building this great resource.
Cheers
Laurence

Looking through current and closed issues some of these have been touched upon.

If things are already filed or have already been addressed in the repository (which is ahead of the web version on v4-alpha.getbootstrap), please do not re-file them in an issue. It simply adds noise and is confusing to maintainers (we currently have 213 open issues and 64 open pull requests) :)

No problem. To clarify the only thing previously mentioned is aria-modal on the role dialog attribute. My apologies for re-stating. Looking forward to reviewing when the next release is available. 😁

Update for accordion based on the repository version v-4
If this should be a PR please advise. I am new to commenting on Github :-)
https://github.com/twbs/bootstrap
The accordion design pattern is problematic in version 1.0 of the ARIA Authoring Practices guide. Version 1.1 updated the entire section that instructs developers to use ARIA Tabs for this purpose. This is die to a bug in where blind users cannot differentiate between an accordion and a tab control.
The new design pattern consists of a heading with a standard link or button embedded within that includes aria-expanded to convey the expanded or collapsed state of the accordion, plus the optional markup of a region to convey the expanded section boundaries. There are no special key events attached since these are basic active elements and handled naturally by the browser.
The bootstrap accordion design pattern uses ARIA 1.0 design method.
It is important that you adope this construct, even though, it seems at this point you are not adopting ARAI 1.1 for accessibilty.
https://www.w3.org/TR/wai-aria-practices-1.1/#accordion
https://www.w3.org/TR/wai-aria-practices-1.1/examples/accordion/accordion1.html

@patrickhlauke Are all these valid issues that need addressing?

Worth noting that the default link color doesn't pass accessibility guidelines when < 18px.
http://www.aremycoloursaccessible.com/?background=%23fff&isLight=true&textColor=%23007bff

@meetbryce as noted here http://getbootstrap.com/docs/4.1/getting-started/accessibility/#color-contrast

Closing this as stale. Most points originally mentioned have since been fixed or have been superseded. Some aspects are...not quite as clear cut. For any outstanding aspects, suggest opening specific focused issues - they usually stand a better chance of being actioned as discrete items.


support CopyStart for incremental snapshot

Description
link https://github.com/Azure/azure-sdk-for-java/issues/31805.
Sample will be in following PR.
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-resourcemanager-compute


com.facebook.react.bridge.NoSuchKeyException · couldn't find key severityReason in dynamic object

Expected behavior
This error doesn't occur
Observed behavior
A spike in this error on production as of yesterday
Steps to reproduce
Seems it happens when any error occurs
Version
2.5.0
Additional information
We've seen a very large spike in this error in the last 24 hours. The full stack is below
com.facebook.react.bridge.NoSuchKeyException · couldn't find key severityReason in dynamic object
Raw
ReadableNativeMap.java:-2com.facebook.react.bridge.ReadableNativeMap.getString
BugsnagReactNative.java:123com.bugsnag.BugsnagReactNative.notifyBlocking
Method.java:-2java.lang.reflect.Method.invoke
JavaMethodWrapper.java:363com.facebook.react.bridge.JavaMethodWrapper.invoke
JavaModuleWrapper.java:162com.facebook.react.bridge.JavaModuleWrapper.invoke
NativeRunnable.java:-2com.facebook.react.bridge.queue.NativeRunnable.run
Handler.java:751android.os.Handler.handleCallback
Handler.java:95android.os.Handler.dispatchMessage
MessageQueueThreadHandler.java:31com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage
Looper.java:154android.os.Looper.loop
MessageQueueThreadImpl.java:194com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run
Thread.java:762java.lang.Thread.run

Can't comment on Issues?
Some users have been unable to comment on Github issues when an adblocker extension is enabled.
We recommend temporarily disabling the extension, or if that fails, contacting<EMAIL_ADDRESS>

I should mention we don't use the client's notify function manually anywhere in our codebase.

Thanks for the report @tomauty - have you recently updated either the Bugsnag/React Native versions, or has this just happened spontaneously?

Seems pretty spontaneous. We haven't made any updates since our previous version release, which was before this started happening:

I'm having the same issue, I freaked out when I looked at my app's Crashlytics statistic

@mehdijjz are you using the same Bugsnag library version? Has this also just occurred spontaneously for you? Any additional information would be helpful for debugging this.

@fractalwrench No my bugsnag version is ^2.3.2 and my RN version is 0.48.2. this is the stack trace, I'm not sure if it's bugnsag's issue or not

@mehdijjz have you noticed any similar spikes for Native iOS crashes? Would you be able to find the bugsnag-react-native version in your yarn.lock file?

@fractalwrench Actually my bugsnag version was 2.3.2, but it is possible that we've mistakenly code-pushed when it was ^2.3.2. Maybe the reason is that the js version gets higher than the native version this way?
and by the way, I don't know if it's related or not but I can't tell whether it's notify or the new Error part which is making this error

This should be fixed in 2.7.1.
@mehdijjz that issue doesn't look related - is that still a problem? I'll spin off a separate issue if so.

@fractalwrench do we have to also update native code when updating ?

@mehdijjz we'd definitely recommend using the same versions of the native code and JS code - it's possible that code push could have caused that. Our changelog should document any upgrade steps, but feel free to get in touch if you run into anything.

guys, make sure that bundle is up to date react-native bundle --platform android --dev false --entry-file index.android.js --bundle-output android/app/src/main/assets/index.android.bundle --assets-dest android/app/src/main/res after you update packages via npm or yarn