Add 2D raycast

Development still in progress.
Fixes outstanding issue #729 .
Screenshot taken from playground example:

There is still lots to do, but I would appreciate a little input on the API design:

Crafty.map.boundaries(findKeys) was extended to find only hashmap cell keys if optional parameter is provided. Should this stay here (introduces some branching in code) or make an explicit method Crafty.map.keyBoundaries() (code duplication)? Added a separate, private method Crafty.map._keyBoundaries().
Crafty.map.iterateMap(origin, direction, entryCallback) iterates the hashmap in the direction of the ray. Calls entryCallback for each hashmap entry (obj). If entryCallback returns true, aborts iteration immediately.
Collision.approximateDistanceFromRay(origin, direction) returns the distance to nearest corner of the entity's bounding rectangle (if there is an intersection). Removed from implementation
Crafty.polygon.distanceFromRay(origin, direction) returns the distance to the closest intersection with any of the polygon's segements (if there is at least one intersection).
Crafty.raycast(origin, direction, maxDistance, comp, sort) uses the above described methods to find an intersection. Returns an array of raycast results, each raycast result looks like {obj: obj, distance: distance, x: intersection_point_x, y: intersection_point_y}.

If maxDistance is Infinity, finds all intersections (this is the default case). If its negative, finds only first intersection. If its a positive value, finds intersection up to that distance.
If comp string parameter is supplied, returns only entities that have the specified component
If sort boolean parameter is supplied and is set to false, then the results are not sorted by distance (opt-out, slight performance gain)
checkBroadphase dictates whether an approximate broadphase intersection check (approximateDistanceFromRay) should be used to filter objects, before checking for exact intersection (with distanceFromRay) removed from implementation

origin & direction describe the ray. direction must be normalized. Should this be mentioned in the docs, or should input sanitation (and thus this normalization) be done?
Crafty.raycast returns an array of raycast results. Duplicates are weeded out, but the array is not sorted by distance. Should there be an additional parameter sort (similar to the filter parameter in Crafty.map.search) that optionally sorts the results (and has performance impact)? Added

Notes:

I still have to test whether the approximate broadphase intersection check is worth it, and how many segments a polygon must have (increases complexity of the exact intersection check) to be worth it. Removed from implementation
Collision (and raycast) logic needs the collision bounding rectangle (this._cbr || this._mbr || this). Rendering stuff needs the minimum bounding rectangle (this._mbr || this).
The considered bounding rectangle is hardcoded in the hashmap's functions (currently the collision one is used). This can possibly lead to (and possibly has already lead to; haven't fully tested) problems with drawing dirty regions on Canvas, when there exists a collision hitbox outside of the entity's natural bounds (_cbr != null).
Having separate hashmaps for collision stuff and for each layer would help in configuring each hashmap so that the correct property gets accessed for the bounding rectangle. A more immediate fix would be to provide an optional argument to each of the hashmaps methods, which dictates which bounding rectangle property to use.

I guess finding the closest instance of a particular type of component will be something that's useful, which would require doing the check inside the raycasting?  I wish there was a way to avoid that, though the only other option would to basically have the raycaster be an iterator of some sort, maintaining it's internal state and allowing you to grab the next intersection through a method call.
It might be worth thinking about how this would interact with some sort of compiled asm.js collision engine.  I believe that the first approach would be tricky (the compiled code couldn't interact with general crafty code, and so it would be tricky for it to inspect entities for the presence of components), while the latter approach would perhaps be more natural in such a context?

I still have to test whether the approximate broadphase intersection check is worth it, and how many segments a polygon must have (increases complexity of the exact intersection check) to be worth it.

I'd expect that it's not worth it -- if used properly (i.e. don't put 100s entities in the same cell) the spatial map is itself the broadphase check.  This is probably more true of raycasting than regular collisions, since SAT is more expensive than the simpler checks here.

Having separate hashmaps for collision stuff and for each layer would help in configuring each hashmap so that the correct property gets accessed for the bounding rectangle. A more immediate fix would be to provide an optional argument to each of the hashmaps methods, which dictates which bounding rectangle property to use.

I wonder if the best approach for Canvas redrawing would be to have it flag cells of the hashmap as dirty, rather than carefully keeping track of the bounding areas of individual entities.

Crafty.map.boundaries(findKeys) was extended to find only hashmap cell keys if optional parameter is provided. Should this stay here (introduces some branching in code) or make an explicit method Crafty.map.keyBoundaries() (code duplication)?

IIRC calling boundaries is actually pretty expensive, maybe not something we want to do every time raycast is called.  A possible optimization is caching them, and only recalculating the boundaries if the hashmap has been modified?  (i.e. have a dirty flag on the hashmap)

@starwed Thanks for the feedback!

I guess finding the closest instance of a particular type of component will be something that's usefu

Added

I'd expect that the approximate intersection test is not worth it

Removed

A possible optimization is caching the hashmap boundaries, and only recalculating the boundaries if the hashmap has been modified?

Added

What's still missing:

documentation
split the single large test file into smaller ones
search the spatial map for the _mbr instead of the _cbr in the render code
setting the _cbr doesn't update the entry in spatial map, until the entity is moved/rotated/resized

If you're ok with it, I'd include the latter 2 points into a follow-up PR (with some additional proposals in regards to bounding rectangle handling).
I feel confident about the implementation now, so if you have time and are up for it, take a look at it, I've included extensive implementation-specific documentation.

It might be worth thinking about how this would interact with some sort of compiled asm.js collision engine. I believe that the first approach would be tough (...), while the latter approach would perhaps be more natural in such a context?

I don't quite understand what the 1st approach and 2nd approach is :)

I wonder if the best approach for Canvas redrawing would be to have it flag cells of the hashmap as dirty, rather than carefully keeping track of the bounding areas of individual entities.

In an 'Asteroids' like game, where you have small entities scattered all around the scene, it might perhaps require redrawing all cells? Might work well in the general case though. Maybe some additional metrics / statistics could be considered here, like heuristical cluster analysis? Might be overkill though :)

I don't quite understand what the 1st approach and 2nd approach is :)

No worries, I was just trying to think through how an underlying optimized algorithm would work, and probably wasn't very clear.  In the end the API the user calls would be unchanged.

In an 'Asteroids' like game, where you have small entities scattered all around the scene, it might perhaps require redrawing all cells? Might work well in the general case though.

Well, it would work the same way it does now -- if a large fraction of entities need redrawing, just do them all.

search the spatial map for the _mbr instead of the _cbr in the render code

I might be forgetting how our existing code works, but what's the change here?

search the spatial map for the _mbr instead of the _cbr in the render code

I might be forgetting how our existing code works, but what's the change here?

Ah, I'm glad you asked, there is no problem at all. Render code calls Crafty.map.search(rect), where rect is just a plain rectangle object, which does not have _cbr and _mbr properties.
Side-note:
Canvas clears some-dirty-entity-encompassing rects and then proceeds to draw all overlapping entities. Note that it does not clear the overlapping entities that are partly inside and partly outside these rects, thus these get drawn again. When drawing the same line multiple times in Canvas, I noticed it getting thicker and thicker. However, these artifacts may not apply here.

In an 'Asteroids' like game, where you have small entities scattered all around the scene, it might perhaps require redrawing all cells? Might work well in the general case though.

Well, it would work the same way it does now -- if a large fraction of entities need redrawing, just do them all.

True, I was just wondering about the edge case where percentage of dirty entities < 50% and their dimension << cellsize.
I like this proposal, as it could potentially improve performance for Canvas rendering.  Drawing dirty cells could be done by just clearing each individual cell and drawing its entities.

True, I was just wondering about the edge case where percentage of dirty entities < 50% and their dimension << cellsize.

From what I understand, you always want your cellsize to be some small multiple of the typical entity size.  If you have lots of small entities moving around inside a single cell, collision performance will suffer because the broad-phase pass will leave too many candidates for the more expensive check.
We kind of support setting the cellsize before init, but it should probably be an actual option exposed through the api.

Ok, added the missing stuff (api docs, test file organization and some minor tweaks).

@starwed
Do you want to take a look at this or should I go ahead and merge it?
We can still fine-tune it before release, if there are any issues.

@mucaho  I haven't had time to fully look through it, but so long as it doesn't seem likely to affect performance I don't have any problem with landing it.  Like you say, we can always tune it up before release.  (And if we're concerned, add a warning to the docs that the api is new and possibly unstable.)
Feel free to merge once the conflicts are resolved.

There may be certainly some things that could get optimized.
One notable thing that could be added in future: It would be nice to have method which does multiple raycasts (in different directions, from same origin point) at once. That would remove the need to check if the origin point lies inside the map for each raycast, but rather do it only once.
I'm particularly proud that the implementation does not use a single Math.sqrt statement. It uses basic math operations instead. It's a marginal improvement though :)


Removed Solr from Series Service

Removes all Solr functionality from the series service. Functions that relied on the solr index were either removed or now query the database directly.

Moved the series filter query endpoint to the external api, while trying to preserve as much functionality as possible (for example, there is no pagination, so instead an offset variable is offered)

Work sponsored by our generous Crowdfunding initiatives!
Your pull request should…

[ ] have a concise title
[ ] close an accompanying issue if one exists
[ ] be against the correct branch
[ ] include migration scripts and documentation, if appropriate
[ ] pass automated tests
[ ] have a clean commit history
[ ] have proper commit messages (title and body) for all commits

Do you expect/observe performance degradations? Should this maybe instead query Elastic-/OpenSearch (though I do expect the DB to scale quite good for normal queries)?

I did not observe performance degradations, but I also only tested this on my local machine, where database and server run on the same hardware. However, the DB queries are quite simple, so I also expect this to scale well.
Lars and I had discussed that we did not want to query the Elastic-/OpenSearch, in order to get away from the currently somewhat cyclic dependency where the External API and the Series Service are trying to get information from each other.

I will Merge it, but this needs the notes to be added before the release in one month ;)

Sorry for the late response Max, we discussed in the technical meeting that it would be fine for this PR to wait for Opencast 12, but I forgot you weren't there. I was gonna add the notes after the branch cut, especially since Matthias also mentioned that this changes the External API and would therefore need a new API version (sigh). I think it would be better to revert the merge if can still reasonably do so?

Hi @Arnei , thanks for your comment, of course we can revert the commit 🙂


Post-renderer not receiving chart hook manifests?

Output of helm version:
version.BuildInfo{Version:"v3.1.2", GitCommit:"d878d4d45863e42fd5cff6743294a11d28a9abce", GitTreeState:"clean", GoVersion:"go1.13.8"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.4+k3s1", GitCommit:"3eee8ac3a1cf0a216c8a660571329d4bda3bdf77", GitTreeState:"clean", BuildDate:"2020-03-25T16:13:25Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.4+k3s1", GitCommit:"3eee8ac3a1cf0a216c8a660571329d4bda3bdf77", GitTreeState:"clean", BuildDate:"2020-03-25T16:13:25Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}

I was experimenting with the --post-renderer option and a simple chart that includes one pod:
apiVersion: v1
kind: Pod
metadata:
  name: post-render-test
  labels:
    # The "app.kubernetes.io/managed-by" label is used to track which tool
    # deployed a given chart. It is useful for admins who want to see what
    # releases a particular tool is responsible for.
    app.kubernetes.io/managed-by: {{.Release.Service | quote }}
    # The "app.kubernetes.io/instance" convention makes it easy to tie a release
    # to all of the Kubernetes resources that were created as part of that
    # release.
    app.kubernetes.io/instance: {{.Release.Name | quote }}
    app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
    # This makes it easy to audit chart usage.
    helm.sh/chart: "{{.Chart.Name}}-{{.Chart.Version}}"
    values: {{.Values.Name}}
spec:
  # This shows how to use a simple value. This will look for a passed-in value
  # called restartPolicy. If it is not found, it will use the default value.
  # {{default "Never" .restartPolicy}} is a slightly optimized version of the
  # more conventional syntax: {{.restartPolicy | default "Never"}}
  restartPolicy: {{default "Never" .Values.restartPolicy}}
  containers:
  - name: waiter
    image: "alpine:3.4"
    command: ["/bin/sleep","9000"]

and one pre-install hook:
apiVersion: batch/v1
kind: Job
metadata:
  name: "{{ .Release.Name }}"
  labels:
    app.kubernetes.io/managed-by: {{ .Release.Service | quote }}
    app.kubernetes.io/instance: {{ .Release.Name | quote }}
    app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
    helm.sh/chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
  annotations:
    # This is what defines this resource as a hook. Without this line, the
    # job is considered part of the release.
    "helm.sh/hook": pre-install,pre-upgrade
    "helm.sh/hook-weight": "-5"
    "helm.sh/hook-delete-policy": before-hook-creation
spec:
  backoffLimit: 3 # retry this task 3 times
  template:
    metadata:
      name: "{{ .Release.Name }}"
      labels:
        app.kubernetes.io/managed-by: {{ .Release.Service | quote }}
        app.kubernetes.io/instance: {{ .Release.Name | quote }}
        helm.sh/chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
    spec:
      restartPolicy: Never
      containers:
      - name: pre-deploy-job
        image: "alpine:3.4"
{{- if .Values.predeploy_task.fail }}
        command: ["/bin/false"]
{{- else }}
        command: ["/bin/sleep","{{ default "10" .Values.sleepyTime }}"]
{{- end }}

For the test, I was using a no-op post-renderer:
#!/bin/bash

tee --append  <&0 all.yaml

When I execute helm install post-render-test ../chart --post-renderer ./post-renderer --debug --dry-run I see both the chart hook and the pod manifest in the output, however my post-renderer only captures the pod manifest.
I've tried this as well with helm template with the same results.
Is this the intended behavior?  I couldn't find anything in the documentation to suggest that hooks would not be included when invoking the post-renderer.

@thomastaylor312 if you get a chance ^^

@robg You are correct. I took a look at the code and it does not pass hooks, just the main manifests. I don't think hooks were intended as part of the initial post render work, but neither were they specifically excluded. So I am going to label this as a bug for now.
If someone wants to take this on it shouldn't be too difficult. It won't be elegant, but it shouldn't be too bad. In renderResources, you'll need to add the hooks to the buffer sent in to the post renderer. The clunky part will come in splitting the manifests back out into "Files" to be sorted by the SortManifests function, which expects a map of filenames to strings containing content.

I have the same question.
i want to inject some label by post-renderer, but not work.

I'm optimistically adding this to 3.3 in hopes that someone takes it up.

@robg, could you please test if the #7948 fixes the issue for you?
git clone https://github.com/kabakaev/helm.git
git checkout hook-post-renderer
make build-cross
ls _dist/*/helm

It worked for me with `helm install releasename chartname --post-renderer 'kubectl kustomize /some/directory'.

@robg, could you please test if the #7948 fixes the issue for you?
git clone https://github.com/kabakaev/helm.git
git checkout hook-post-renderer
make build-cross
ls _dist/*/helm

It worked for me with `helm install releasename chartname --post-renderer 'kubectl kustomize /some/directory'.

I buid helm bin  from your branch, and use post-renderer with ytt;  but not work.
Error: cannot prepare a file for post-process: document has no metadata:

use master branch, build helm bin is work.

@dellkeji, thanks for testing it!

Error: cannot prepare a file for post-process: document has no metadata:

There seem to be an empty template on the input. Do you build some public helm chart, so that I can also test it?

Ok, I think I know what happened. I forgot to check if the ‘document’ variable is not empty, which may happen with ‘Split()’.
I’ll push the fix in an hour.

@dellkeji, how about now with the new commit?
git fetch
git checkout d9e44ad9793e8e3d639416ff9227dffbde768086
make build-cross

@kabakaev Thanks for putting this patch together, sorry I missed your earlier message.
I just tried d9844ad and received the same error as @dellkeji:
(aws-cli) robg@robgnuc:~/projects/helm-poc/post-render/overlay(master)$ /home/robg/projects/patches/helm/_dist/linux-amd64/helm install post-render-test ../chart/ --post-renderer ./kustomize  --debug --dry-run
install.go:159: [debug] Original chart version: ""
install.go:176: [debug] CHART PATH: /home/robg/projects/helm-poc/post-render/chart

Error: cannot prepare a file for post-process: document has no metadata:
helm.go:84: [debug] cannot prepare a file for post-process: document has no metadata:

@dellkeji, how about now with the new commit?
git fetch
git checkout d9e44ad9793e8e3d639416ff9227dffbde768086
make build-cross

thanks!
this commit branch is ok,  passed the test of our case.
helm template ttt exam-chart -n default --post-renderer test-ytt/my_test

I just tried d9844ad and received the same error

@robg, please try 9c06aff.

I just tried d9844ad and received the same error

@robg, please try 9c06aff.

@kabakaev that one worked for me.  Thanks!

3.3.0-rc.1 is being cut tomorrow, so we're removing this from the milestone.

Any update on when this fix will available ?

expecting updates

Any updates on this one?

I need updates too.
In my use case with Kustomize, a ConfigMapGenerator creates some ConfigMaps which contain stuff for database migration, which is executed in a Job on pre-install and pre-upgrade hooks, so I cannot use the native way to propagate my name suffix (which is finally a way to patch but with a ConfigMapGenerator).
https://kubectl.docs.kubernetes.io/references/kustomize/configmapgenerator/#propagating-the-name-suffix
So currently, I fix a static configmap name for each helm install depending on the release name but it's not repeatable.

We are facing same issue..
We have a job in Contour namely cert-gen.
We just workaround this using helmsman hooks..However it will be good if this issue gets fixed.

This is probably also applicable to helm test

still relevant

Not stale, still relevant.

Any plan to include fix in future releases?

We've been bashing our heads around this behavior and just found out about this; at the minimum it would be great if this behavior was documented

This issue is relevant for me since I wanted to use Helm post-renderer in order to overcome the issue of deploying a chart (GitLab but could any other) into an Istio-enabled namespace. Istio has a known issue with Jobs not completing: https://github.com/istio/istio/issues/11045
And the GitLab Helm chart uses a Job to initialize shared Secrets. Unfortunately the Job is created through a Helm hook, so it is not customizable using the post-renderer, due to this issue.

Just stumbled face first into this too. Hooks running through the postrenderer would be great.

We are hindered by this limitation as well. Would be great if hook manifests would be passed over to post renderer.

Any update?

any update?

Not stale, still relevant.

Now that skaffold v2 switched to use --post-renderer skaffold, running development environments when there are hooks it's impossible, as skaffold can't set the image tag for the hooks correctly. :-(

Bumping this as I just spend hours writing a post-renderer script only to find that the part of the rendered manifests I wanted to fix in production was not affected by it. :/

Bumping this as I just spend hours writing a post-renderer script only to find that the part of the rendered manifests I wanted to fix in production was not affected by it. :/

Same here...

I'm trying to understand why only a subset is send to postrendering; why not the entire superset? Isn't that far easier...
Yes; we are hitting the same issue.
Paul

Based on my understanding of the code in question, it appears that the call to the SortManifests function in the action.renderResources package (https://github.com/helm/helm/blob/76157c6d06f981a42bfbb9ec636bae5443cb2c8f/pkg/action/action.go#L219) separates all files into two lists, hs containing resources with hooks, and manifests containing regular resources. The function then proceeds to consolidate all regular resources (from manifests list) into a single bytes buffer (https://github.com/helm/helm/blob/76157c6d06f981a42bfbb9ec636bae5443cb2c8f/pkg/action/action.go#L200) and sends that buffer to the post-renderer (https://github.com/helm/helm/blob/76157c6d06f981a42bfbb9ec636bae5443cb2c8f/pkg/action/action.go#L219).
The current implementation does not include the handling of hooks in the post-renderer process. However, I believe that the solution to this issue is not overly complex and I am willing to take a stab at implementing it.

Just stumble upon https://github.com/helm/helm/pull/7948 which already has a way better implementation for this issue. However it looks a bit stale. Any news @kabakaev? I just closed #11740.

Hi, any update on this ? (or any work around would be fine ! 👍🏻 ), it took me a while to realize that it resources with hooks wasn't generated !

Hello @kabakaev, is there any update on the plan and or how to be involved in it?
thanks!

+1

+1

Any solution? any old version not have this issue?

Yes it bug if our mainifests is similar lines
    # "helm.sh/hook": pre-upgrade
    # "helm.sh/hook-weight": "1"
    # "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded

It manifests not upload in kubernetes after postRendering handler

@mattfarina Would #13154 be an acceptable solution?

@mattfarina Would #13154 be an acceptable solution?

@mattfarina @banjoh @robertsirc
Nudge, nudge. Is there still interest in solving this?

I just stumbled upon this issue. Using kbld -f lock.yaml to pin the installed images, I figured out that my hooks where not pinned. So definitely, I would have loved this issue to be closed :-)


Finalize accessibility statement

Is your feature request related to a problem? Please describe.
The accessibility of this site leaves a lot of room for improvement.
Describe the solution you'd like

[ ] Finish statement
[ ] Make all aria-descriptions make sense

Describe alternatives you've considered
NA
Additional context
NA

See: https://www.accessibilitystatementgenerator.com/


bindProp is not working with the text shorthand

Hey all, when using bindProp() to return a bound text texture property one would expect it to work with this syntax:
public static _template() {
  const boundText = this.bindProp('text', (ctx) => {
    return { text: ctx.text, color: ctx.color }
  });

  return {
    SomeComponent: {
      text: boundText
    }
  }
}

Lightning seems to ignore the property completely, probably due to the way it parses shorthand properties for text.
Any thoughts?

Hi @victor-wm,
You should use unique property names for bindings, text as you noticed is one of component's reserved properties.
Proper usage would be something like this:
static _template() {
  return {
    SomeComponent: {
      text: {text: this.bindProp('myText'), color: this.bindProp('myTextColor')}
    }
  }

 _init() {
    this.myText = 'some text';
    this.myTextColor = 0xff112233;
 }

You should also be wary of binding whole objects as there are no sophisticated mechanisms that would detect when properties of those objects change.
We could consider expanding functionality of text property a little bit to support syntax such as:
text: this.bindProp('myTextObj')

this.myTextObj = {text: 'example', textColor: 0xff112233}

Best regards

Hey @g-zachar, thanks.
text: this.bindProp('myTextObj') is exactly what I'm looking for. And from what I read in source, moving the binding logic before the text property parsing would do the trick.


Handy way to organize servers

I've only recently got into working with Teleport (just two days of use) but one thing I have noticed, after building a series of generic re-usable recipes is, I have a lot of config for my server options e.g.
server "db",
:role => :db,
:services => ["mysql"],
:recipes => ["slave.rb"],
:mysql => {
	:server_id => 00, # Last two octets of the IP address
	:master => {
		:host => "host-of-master",
		:port => 3306,
		:user => "replication-user",
		:password => "blabla"
	},
	:slave => {
		:skip => [000,111,222] # Skip replication errors with these codes
	},
	:readonly => true
},
:"sd-agent" => {
	:key => "XXX"
}

I wanted to do something where I could include files in, say, servers/db.server.rb rather than having three or four of those large declarations in my Telfile.
Hopefully that makes sense, and will bring a handy feature into Teleport :D Thanks!

That's an interesting idea. It's a little tricky because Teleport is very careful to only copy certain files into the tar file that it scps over to the target machine. Usually Telfile lives in the root of a Rails app or similar, so I don't want to just copy everything willy nilly. A few ideas:

add support for lib/teleport or something?
maybe you can put your db_server.rb inside recipes? that gets copied automatically

We'll also have to make "require" work inside Telfile, of course. That might involve modifying LOAD_PATH. I'm open to suggestions.

Interesting, i'm not really a ruby developer (or rails) - I just know enough about the language to build simple things :-) If you think its something that would impede performance or simplicity then i'm sure its unnecessary. Just a little idea from my usage...


fix: make ssr friendly

Removes references to window and sets globalObject

Coverage increased (+0.07%) to 89.477% when pulling 97cc687b67e906968c824f3aee0fdc0bfbb2d77d on tuchfarber/make_ssr_friendly into 461b1aefcaa413cce1e28f3ad04fdd594845c521 on master.

:tada: This PR is included in version 4.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Reduce waiting time

The waiting time for next color prompt was very long allowing users to re-submit the same color.
Waiting time should be reduced from the current 2 seconds down to 1 seconds

This issue was fixed sometime this morning, I forgot to make an issue about it


Update to gz

Make this repo work again and rename things from ignition to gz.

This now also contains the changes from https://github.com/UniversalRobots/Universal_Robots_ROS2_Description/pull/114


sending code from nvim to R REPL garbled

Sending code from nvim to the R REPL is all garbled and often depends on where your cursor is (and sometimes doesn't), so sending several highlighted lines works maybe 1 in 5 times.
NVIM v0.5.0-715-gc5ceefca7 (neovim-nightly AUR package)
Arch Linux

Also gets a warning message from init.lua line 344 about expecting 4 arguments, but then it still sends it anyway..

I guess this was related to #170. Can you double-check now after that PR was merged?

Fixed


Protect required pflogger in CMake

Description

Add BUILD_WITH_PFLOGGER protections in CMake in pfio and geom
Related Issue

Closes #2152
Motivation and Context

Lets our non-pflogger MAPL users build without pFlogger.
How Has This Been Tested?

Well, it shouldn't affect with-pflogger builds. Perhaps @AlexanderRichert-NOAA can test for us in a non-pflogger build environment, or I'll try as soon as I can to do it in a spack instance.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[ ] I have tested this change with a run of GEOSgcm (if non-trivial)
[x] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[x] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

Update: This also uses an update to the circleci-tools orb to allow us to remove pflogger from the UFS test. This should prevent such mistakes from happening in the future (at least until UFS moves to using pflogger).


When python.pythonPath includes ${workspaceFolder}, tasks that use ${config:python.pythonPath} fail to start

From @segevfiner on August 28, 2018 22:39

Environment data

VS Code version: 1.26.1
Extension version (available under the Extensions sidebar): 2018.7.1
OS and version: Windows 10.0.17134.228 x64
Python version (& distribution if applicable, e.g. Anaconda): CPython 3.7.0 x64
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv

Actual behavior
When python.pythonPath includes ${workspaceFolder}, tasks that use ${config:python.pythonPath} fail to start:
> Executing task: ${workspaceFolder}\venv\Scripts\python.exe setup.py build_ext --inplace <

The system cannot find the path specified.
The terminal process terminated with exit code: 1

Terminal will be reused by tasks, press any key to close it.

Expected  behavior
The tasks should start correctly. It's quite useful to use ${config:python.pythonPath} in your tasks so as to use the Python version used by vscode-python to run the tasks.
Steps to reproduce:

Create a virtualenv under your workspace: virtualenv venv
Select it as the Python interpreter of VS Code using the status bar. (python.pythonPath should be set to a path using ${workspaceFolder}).
Create a task that uses ${config:python.pythonPath} to run anything you want, and try to run it.

Logs
Nothing relevant under default log level.
Copied from original issue: Microsoft/vscode-python#2459

From @bhrutledge on August 29, 2018 13:47
I stumbled upon this issue by way of #1664.
My workspace settings (set automatically, I think):
{
    "python.pythonPath": "${workspaceFolder}/venv/bin/python"
}

What I tried:
{
    "label": "runserver",
    "type": "shell",
    "command": "${config:python.pythonPath} manage.py runserver",
    "problemMatcher": [],
    "group": {
        "kind": "build",
        "isDefault": true
    }
}

Output:
> Executing task: ${workspaceFolder}/venv/bin/python manage.py runserver <

/usr/local/bin/bash: /venv/bin/python: No such file or directory
The terminal process terminated with exit code: 127

Changing command to ${workspaceFolder}/venv/bin/python manage.py runserver works. Just using manage.py runserver doesn't work because the virtualenv isn't activated. Of course, if I were using pipenv, I'm guessing pipenv run manage.py runserver would do the job.
Aside: this makes me wonder if VS Code has a facility for defining a new task type, that would handle the virtualenv automatically.

This is actually not task related. What the user does is configuring a  like this "python.pythonPath": "${workspaceFolder}/venv/bin/python" but to my knowledge settings can't contain variables.
WE can do two things:
@sandy081 allow variables in settings in the first place
@isidorn improve the configuration resolver so that it looks at the value of a setting and if a variable is in there replaces it as well
Opinions?

@dbaeumer we do not support variables in settings - adding it would be a big door which I am not sure I would like to open.
Option 2 does not really make sense since we do not support variables in settings, so I am not sure why we should resolve again.
For now I suggest no action, and if more users ask for this we can look in Option 2 (which feels a bit ugly).
fyi @weinand

OK. Will keep as a feature request then.

The python.pythonPath variable was generated by the extension after selecting an interpreter, and it was generated including ${workspaceFolder}, rather than being directly specified by the user.
Being able to create tasks that use the workspace interpreter is needed to get development tasks that use packages installed in a virtualenv working correctly, without hardcoding an absolute path to Python which cannot be shared. You often install development tools for the project in a virtualenv rather than globally, and you likely want to define setup.py tasks too.
This use case is even mentioned in the documentation: Tasks in Visual Studio Code - Variable Substitution! Which is where I got the idea from, and than got suprised when it didn't work.
It's also possible to support this using a custom task type (Should it be like shell or like process... That distinction is kinda annoying for task types like this), a task type can even activate the virtualenv, so you will be able to use it to run shell scripts that use Python too (If you make sure it can launch arbitary commands and not only Python scripts).
Another option is a custom variable expansion like ${pythonPath}, instead of the generic ${config:*}, but I don't think there is an extension API for that.
Yet another option is to implement something like ${configExpanded:*}, that's not exactly pretty though...

The problem is that you can either resolve a variable or a setting. But settings themselves don't have variable support right now.
Using a custom task makes sense here since you then have full control over what is called. The difference between shell and process is comparable to the node API difference between child_process.exec(command[, options][, callback]) which runs a command in a shell and child_process.spawn(command[, args][, options]) with options.shell: false.

The difference between shell and process is comparable to the node API difference between child_process.exec(command[, options][, callback]) which runs a command in a shell and child_process.spawn(command[, args][, options]) with options.shell: false.

Of course, but should a "python" task type be like "shell" or like "process". :wink:

It depends on. If the pyhton tasks wants to execute a shell script it should be a shell task. If it is a executable you should use a process task to have full control over the args since there will be no shell interpretation. If you want shell interpretation for the args (e.g. wild card expanding under bash for example) then even if it is a binary executable use a shell task.

Yeah I know about this but of logic. I was talking about if you implement a custom "python" task in the extension, should it act like the "shell" task type or the "process" task type. Since the distinction is made based on the task type and not a separate "shell": true/false flag.

FYI I've re-purposed the original issue on the Python extension's side to stop inserting ${workspaceFolder} into settings.json. Sorry about the mix-up.

Since the issue is that settings do not support variables, and the python extension was adding a variable to settings, I'm going to close this issue.
It also seems that the python extension has fixed the bug of adding a variable to settings. Please feel free to ping this issue if the problem still hasn't been addressed.


Typo 8.1.2

"Clearly whatever terms and predicates you fill in here, in the inferences remain valid." should be -> "Clearly whatever terms and predicates you fill in here, the inferences remain valid."

Thanks, @mvrozend ! Will fix later :)


Maa/url support

Codecov Report

Merging #7 (6115a7e) into master (c02f9b6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           10        10
  Lines          968       965    -3
=========================================
- Hits           968       965    -3

Flag
Coverage Δ

unittests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/option/option.go
100.00% <100.00%> (ø)

pkg/option/optionset.go
100.00% <100.00%> (ø)

pkg/value/value.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c02f9b6...6115a7e. Read the comment docs.


⚠ ClamAV has degraded performance

In f977592, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 72 ms

Resolved: ClamAV performance has improved in 00f3051 after 11 minutes.


ClusterIssuer not creating the secret with the certificate.

I'm using cert-manager with this webhook (https://github.com/Dopingus/cert-manager-webhook-dynu), when i create a clusterisssuer (show bellow) it's not creating the secret (dynu-secret-prod), i don't find any error messages and the clusterissuer appears as READY and with the status The ACME account was registered with the ACME server. Any Ideas on how can i troubleshoot this  ? why it's not creating the secret  ?
apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
name: letsencrypt-dynu-agtbr-prod
spec:
acme:
# The ACME server URL - PROD
server: https://acme-v02.api.letsencrypt.org/directory
# Email address used for ACME registration
email<EMAIL_ADDRESS># Name of a secret used to store the ACME account private key
privateKeySecretRef:
  name: acme-privkey-prod

solvers:
  - dns01:
      cnameStrategy: Follow
      webhook:
        groupName: com.github.dopingus.cert-manager-webhook-dynu
        solverName: dynu
        config:
          secretName: dynu-secret-prod

Thanks.

I made a little mess, its working now.


low training return of the example agents

Hi,
Thanks for your PyTorch version rllib code! However, when I run your SAC example by, eg,python examples/run.py agent SAC --agent-config ./examples/config/agents/sac.yaml --env-config ./examples/config/envs/half-cheetah.yaml --num-train 300, the performance is low (lower than 1000). And the return is also low when training the PPO agent and training in other mujoco environments (I tested ant, hopper, halfcheetah).

Also, for hopper.yaml and walker2d.yaml in your example, I guess the max_steps  should be 1000?

Hi, thanks for checking that out. Yeah I will fix the max_steps in hopper and walker. What about the default implementation, i.e.
python examples/run.py agent SAC --env-config ./examples/config/envs/half-cheetah.yaml --num-train 300
I am checking out the agent config because the default SAC performs well. Could you double-check?
Thanks

Thank you for your reply! I double-checked and found that default SAC agent works well in the Halfcheetah environment! But it still gives low training return in the hopper and ant environments. Would you suggest the proper settings that work in these tasks? Or other locomotion tasks that the default agents perform well? Thanks!

Hi that is good to know. I'm not sure, maybe check at this other repo to see the parameters they use there. Also I believe that 300 episodes is harder for these environments due to early termination. Usually you want something larger > 10000 or so episodes.

Thanks! I'll give it a try.


Create setter blocks that select from a list of values

Implement property setters that choose from a selection of values.  For example, the setter for screen.alignvertical should allow only top, center, and bottom.  This could be implemented with a new kind of block that incorporates a dropdown.  Make sure the dropdown uses the list-of-pairs method to accommodate internationalization.
Implement a new property editor type that generates this block from a list of values, coordinated with the way these appear in the designer.
We need to also keep the current version of the setters, for when the argument needs to be computed.  We should probably make a way to morph one form to the other, or make selecting from the dropdown do the transormation between forms.
After this is done, we can update some of the existing setters so that they use this.

This is the same as issue #155

Hi! I would like to try to implement this, as it is already implemented in Espruino Web IDE. I need this in my fork.
Which Blockly version are we used? Is it clean or patched by the AI team?

@fmntf @afmckinney @jisqyv @NeilFraser
Thanks for wanting to work on this.  We have our own copy of the Blockly code here in the App Inventor source tree.  We try not to modify our version of the Blockly core much, and Andrew periodically merges in the new Blockly updates from Neil.
There are some non-obvious aspects to what needs to be done here.  For example, the block that sets the value of a property will mostly be choosing from a fixed set of values and the dropdown is perfect for that.  But users also need the ability to set the property to the result of an expression, so a dropdown of fixed values is not sufficient.

Hi @halatmit. Espruno propose a fixed list of values on a dropdown menu, but it allows to delete the dropdown and plug other blocks (like variables or procedure calls). See this screencast.
Do you think it would be enough?

@fmntf
That looks very good.  Your video doesn't show this working with external inputs, but I assume it does.
It would be great if you could finish this up and submit it as a pull request, so we can all play with it.  thank you so much!

Hi. As said in Google Groups I have started to implement this feature on the UDOO branch. You can see the result here.
Some useful features could be:

if I try to set an argument like pin/mode/value to color/list/something else invalid, the connection should be rejected;
if I connect a number/string i.e. to pin, the number/string block should be casted to the dropdown Blockly.Blocks['udoo_pinout'] type.

For 1), it is done in other parts, like logic_negate
Blockly.Blocks['logic_negate'] = {
  init: function () {
    ...
    this.appendValueInput('BOOL')
        .setCheck(Blockly.Blocks.Utilities.YailTypeToBlocklyType("boolean", Blockly.Blocks.Utilities.INPUT))
        .appendField(Blockly.Msg.LANG_LOGIC_NEGATE_INPUT_NOT);
  }
};

but I have no idea on how to do this on Blockly.Blocks['component_method'] since it is shared on all components methods. Any advice?
For 2), I did not find anything similar in AI. I tried add a changed listener but I don't know Blockly internals to go on. @NeilFraser do you have suggestions?
Thank you!

Hi @halatmit @NeilFraser
have you got the chance to see my implementation?
I need some feeback to go on, to understand if I'm taking the right direction. Advices on how to implement some protection logic (see the first point in the previous post) are also welcome!
Thank you,
Francesco

Franceso,
The video looks great.   But it's hard for me to review the code unless you
submit it as a pull request, where you start building from the App Inventor
master branch, so we can pull down that branch and built it and run it.
Can you do that or do you have questions?
Paul:  Comments?
Lyn: comments?
== Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
MIT Media Lab, Second Class Faculty
On Tue, Jun 23, 2015 at 4:16 AM, Francesco Montefoschi <
<EMAIL_ADDRESS>wrote:

Hi @halatmit https://github.com/halatmit @NeilFraser
https://github.com/NeilFraser
have you got the chance to see my implementation?
I need some feeback to go on, to understand if I'm taking the right
direction. Advices on how to implement some protection logic (see the first
point in the previous post) are also welcome!
Thank you,
Francesco
—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/issues/195#issuecomment-114401802
.

I didn't see anything in the video showing the new property editor in the designer that you would use for specifying that this is an 'enum' type of property.  You would associate that property editor with properties that want to use it via the editorType attribute of the DesignerProperty annotation on the property.  Presumably in such an editor you would enable the user to specify a set of name/number pairs which would constitute the allowable dropdown options (i.e the names) and their corresponding numerical values.  Once you know those you can do type checking and type conversions.

Good job getting it this far. In the long run, it will be important that these blocks are generated based on information passed in from the designer. Creating lots of single purpose blocks like "arduino_pin_mode" and "arduino_pin_value" will be harder to maintain. Instead, as Mark said, marking properties as having drop downs, and using that drop down information to generate the block will make it possible to easily add these types of blocks for new components.

Thank you for your feedback!
I think there are two different cases. The first is about properties values (and it is related to issue #195) - we should make users able to select properties values from the blocks editor.
The second case - the one I need for UDOO - is to let users provide correct arguments to methods calls. Those lists are only related to the blocks editor (so I wouldn't use DesignerProperty annotation, since there is no designer involved).
For properties values we should probably generate Blockly code starting from editorType.
For method arguments, we should probably create a new attribute in SimpleFunction, which automatically generates code like my arduino_pin_mode example.

@fmntf
Maybe it's creating a separate issue which covers the work you are doing on functions, since issue #195 explicitly deals with properties.

@mark-friedman I totally agree. I have created a separate bug: #432. Thank you!

I believe that the helper block functionality implemented by Beka addresses this issue.


“Create custom list” API documentation missing

Looks like the formatting is messed up somewhere which caused the Create documentation to disappear.
I think it’s somehow been mixed up into the “Reorder a user’s lists” documentation as it appears to be under the example response in the reorder section https://trakt.docs.apiary.io/#reference/users/lists/reorder-a-user's-lists
Sent with GitHawk

Good catch, thanks! Docs are fixed now.


Suggestion: Change Axis.AxisBottom to Axis.Bottom

For the pre-made axes, would it be better to remove the prefix since they're called with Axis.*?
So:
Axis.AxisBottom -> Axis.Bottom
Axis.AxisTop -> Axis.Top
Axis.AxisLeft -> Axis.Left
Axis.AxisRight -> Axis.Right
I'm still pretty inexperienced though and can understand if there's something wrong with this.

Odds are good that most folks will use destructoring when they import the respective Axis they need like so:
import { AxisLeft, AxisBottom } from '@vx/axis';

// ...
<AxisLeft />
<AxisBottom />

In the gallery examples I'm using package namespaces to help folks identify where things are coming from (it's not necessary, just thought it'd be easier to read):
import Axis from '@vx/axis';
import Shape from '@vx/shape';

// ...
<Axis.AxisLeft />
<Axis.AxisRight />
<Shape.LinePath />

if you want smaller builds (building a library, concerned about js size) you can import the component directly:
import AxisLeft from '@vx/axis/axis/AxisLeft';
import AxisBottom from '@vx/axis/axis/AxisBottom';

// ...
<AxisLeft />
<AxisBottom />

Ahhhh, okay that makes a lot of sense. :D

this is a slightly different topic/I can open another issue, but right now destructuring fails for me on import:
import { AxisLeft } from '@vx/axis';
import Axis from '@vx/axis';

// ...
<AxisLeft /> // throws
<Axis.AxisLeft /> // fine

I think this is because named imports are not the same as destructuring? for that to work should we export as variables in addition to the default object?

good catch @williaster, I'll get a fix out today for all packages.
fix summary:
// instead of
import Axis from '@vx/axis';
<Axis.AxisLeft />

// if you want to namespace the components
import * as Axis from '@vx/axis';
<Axis.AxisLeft />

// even better (don't import unused things)
import { AxisLeft } from '@vx/axis';
<AxisLeft />

// even better for smaller file size (lib authors)
import AxisLeft from '@vx/axis/axis/AxisLeft';
<AxisLeft />

fix is here https://github.com/hshoff/vx/pull/29


Multiplayer: Typed Arrays in RPC Functions Throw Errors

Godot version
4.1.1.stable
System information
Godot v4.1.1.stable - macOS 13.4.0 - Vulkan (Mobile) - dedicated AMD Radeon Pro 5500M - Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 Threads)
Issue description
Here is the RPC function I have created.
rpc("call_local")
func show_items(item_names: Array[String], multiplier: int = 1, reroll: bool = false):
    pass

This function throws the following error on the clients (not the RPC caller).
E 0:00:19:0744   _process_rpc: RPC - 'CanvasLayer(ItemChooserSystem.gd)::show_items': Cannot convert argument 1 from Array to Array
  <C++ Source>   modules/multiplayer/scene_rpc_interface.cpp:294 @ _process_rpc()

I would expect it to be able to convert to the proper type, but getting rid of the type on the array resolves the issue.
Steps to reproduce

Create a multiplayer game.
Create an RPC function with a typed array
Call that RPC function with a valid array
See the error on the client

Minimal reproduction project
TypedArrayRPCError.zip

IIRC this cannot convert array to array error was some other issue, it might not be a problem with rpc here.

Related to / duplicate of #74391

Duplicate of #69215.
May be fixed by #78219.

Thanks for reporting the bug nonetheless!


Stop propagation of camera clicks after drags

still needs work for the sketch interaction in which camera drag clicks are still leaking through.

Was it what I thought it was? The apple track pad being ultra sensitive to like "click bounce"?

Was it what I thought it was? The apple track pad being ultra sensitive to like "click bounce"?

no.  check the thread convo in slack against the other PR
TL;DW - out of order mouse moves were coming into the engine via the unreliable websocket channel after the drag end's had been received.

For posterity: Slack thread

reminder, the sketch case for this still needs work.

out of order mouse moves were coming into the engine via the unreliable websocket channel after the drag end's had been received.

Oh wow <_>!

no. check the thread convo in slack against the other PR

This is not helpful to find the context for PRs like this. Please provide a link to a slack message or provide a search term in the future

Oh I'm getting it! This occurs when both:

The user has "Trackpad Friendly" or "NX" controls set, which makes one or more camera movement interactions and selection share a mouse button (NX only has this problem with panning, but Trackpad Friendly has all three)
The user's pointerup occurs faster than our this.isDragging can be written to by the pointerdown event, so it reads a stale isDragging value.

 Nice good find! I'm just gonna see if I can get the spirit of your fix in, while sticking to our patterns.

This current implementation allows users to orbit while in sketch mode (which we will want but just not yet), so I'm finding a different way.

This current implementation allows users to orbit while in sketch mode (which we will want but just not yet), so I'm finding a different way.

JK guess I needed to rubber duck that. New bug found: switching mouse control schemes while in sketch mode unlocks the locked-down orbit

This was annoying, found second client-side camera bug that had me thinking this PR broke something, but nope it's always been that way. I'll log it. Here's a demo of the sketch mode fixed:
https://github.com/user-attachments/assets/46444443-58fa-4324-a47d-8adb22c9be16


Add DiD - Decentralized identifiers - to PIDMR Backend

Provider to Add:
DiD - Decentralized identifiers

Done.
Resolution mode implemented: landingpage
Check and close please with the following DiD:
did:sov:WRfXPg8dantKVubE3HX8pw


TAB key management

Hi,
I'm a new user of your plugin and it's very usefull.
Currently, tab key is mapped to close the search without doing anything.
Is it possible to include a parameter which allow us to map an action ?
In most of selectbox, when you press tab key, the input content is set to the selected value and the focus is set to the next item without submitting.
I think it's a more natural user experience.
I try to do it by adding a event trigger, but first time I press tab, it's work. And after, I could not able to reload flexdatalist results without reloading the webpage.
Regards
Christophe

I've modifed the code to set the input content to the selected value on pressing tab:
            .on('input keydown', function (event) {
                if (_this.keyNum(event) === 9) {
                    val = $alias[0].value;
                    if (val.length === 0)
                        _this.results.remove();
                }
                _this.action.keypressValue(event, 188);
                _this.action.backSpaceKeyRemove(event);

and (I do not know if needed):
            // Enter/tab key
            if (keynum === 13 || keynum === 9) {
                event.preventDefault();
                $active.click();


Feature Request - DatabaseObjectOrder

Similar to the DatabaseOrder parameter would it be possible to have a parameter that specifies the order in which database objects are checked?
For example if you only have a 5 hour maintenance window each night and a VLDB you could run CHECKTABLE in batches starting with the oldest check date first and using the TimeLimit parameter.
This would allow us to configure the integrity checks similar to Paul Randal's suggestion here

Couldn't you use the @DatabaseOrder parameter?
https://ola.hallengren.com/sql-server-integrity-check.html#DatabaseOrder

Similar to the DatabaseOrder parameter would it be possible to have a parameter that specifies the order in which database objects are checked?
For example if you only have a 5 hour maintenance window each night and a VLDB you could run CHECKTABLE in batches starting with the oldest check date first and using the TimeLimit parameter.
This would allow us to configure the integrity checks similar to Paul Randal's suggestion here

I was looking at this again. It is a good idea. Thank you for the suggestion.


Adds long-running integration tests.

This adds packages/ignite-integration-tests so a npm run bootstrap will be required to set this up.
The idea of this package is to run some end-to-end integration tests.  @jamonholmgren was asking about these.
I've set up a handful to show how these can work.
They run the ignite cli with various arguments and look for expected output.
Have a look at packages/ignite-integration-tests/test/ignite-new/newMin.test.js.  That one will ignite new MinApp --min and test that right artifacts come out.

I've found some issues in our CLI with it already.  🙀

before tests we were all like
http://i.imgur.com/Lrkm9nP.gifv

1 question?  Why is this kept outside of ignite's package?

I'm super happy with this!

  So instead of configuring ava to ignore, I made a new package.
Lazy. I know.
I planned on cheating too.
We technically don't need a React Native app to test some of integrations.  Like generators, parts of the plugin system, etc. So that would buy us speed! We'd still need all of the ignite-* plugins so the game plan was to set dependencies.
TL;DR: I flipped a coin.  It came up tails.
@jamonholmgren - I'm super happy with you!


array: how to implement Serialize and Deserialize?

Currently, we are using the default derive of Serialize and Deserialize. But these two derives might not be a good fit for wire protocol. We might need a better way of implementing Serialize and Deserialize.
cc @wangrunji0408 @MingjiHan99

Maybe this document can help you: https://sqlite.org/src4/doc/trunk/www/key_encoding.wiki


Add makeRubyLock builtin

makeRubyGemsEnvironment requires to specify a rubyGems parameter with the entire pinned dependency tree. This is a huge headache as one has to go through each dependency in RubyGems and get its sha256. Aditionally, one still has to get a Gemfile.lock just to know the dependency tree for a set of direct dependencies.
Let's do what we do with Python:

Add a makeRubyLock (like makePythonLock) that automatically generates a lock file.
Make makeRubyGemsEnvironment receive such lock to create the environment.

https://github.com/rubygems/rubygems/issues/3379


Wrong resolution with rootless paths

Consider the following base IRI tag:a-b and the following relative IRI ref c-d. Resolving the latter against the former should result in tag:c-d, but oxiri gives tag:/c-d.
I checked the resolution algorithm (https://datatracker.ietf.org/doc/html/rfc3986#section-5.2) and I am convinced that my assumption above is correct, and that oxiri is wrong.
Preparing a PR to fix this.

Indeed, thank you!


NullPointerException when try to add null foreign record fix

Hello, i hope this fix will be useful for resolving that issue

I will take a look at this when I get to home! Thank you for your PR!

Could u fix the tests?

@sibelius, yes i could, what exactly need? Using empty constructor?

@sibelius, Ok. I look at the details of the check fail. Just I didn't before requests, don't understood at first time

Coverage increased (+0.04%) to 74.825% when pulling d057a0ca08e4b634da01f2b911bf339b2723bc0a on bioker:master into ca5dd14df77d4a78047197f223eaf1b0f6c50c16 on satyan:master.

Hi, is it possible to use a version of the library with this problem fixed?

looks good, tks

Thank you so much, but has any beta release that can I use? Or only cloning project and using it as an module?

@taynanb u just use master version for now: https://github.com/satyan/sugar#how-to-use-master-version

@sibelius Thanks!


load/Unload station smaller footprint

Thank you for the blueprints.
Would it be possible to offer also a loader/unload station with a smaller footprint similar to the LTN ones in the chunk-alligned books?
https://factorioprints.com/view/-M-gLfVHJstwMyNzr044
https://imgur.com/L0MyeMJ
Stations can unload to the front or back and have smaller footprint, which is quite good if you need multiple next to each other

For small footprint, use the "merged" station bodies and the load/unload prints for them.  Much smaller with higher throughput and less load on UPS.


Volume clone enhancement

Update the checkVolumeCreated condition for CSI CreateVolume call.
Sometime the volume is auto-attached quickly after being created. For
example, volume which require backup restore or volume require data
cloning. We shouldn't wait for the volume to be detached before return
OK for CreateVolume call because it could take a very long time to
finish the data transfer.
Implement the retry logic with exponential backoff for volume cloning

longhorn/longhorn#2907

Do we need to make the number of retries and initial time user configurable? (I think I can pretty easily be convinced now, but it would be good to write down a justification.)

I would like to avoid introducing more settings and API changes (for updating per volume setting). Maybe we can hard-code it for now and add customization later if there are users/custumers' requests for it. WDYT?

Ping @ChanYiLin Would you be able to take a look to see if there is any concern before merging?

Merging. I will push a new PR if there are additional review comes in


Fix panic on multiple calls to Receiver.Close()

This way client Mutex will guard the channel closing for us.

👍


where 'isomorphic-fetch' coming from?

Hi, there
I am interesting about code
import 'isomorphic-fetch'
I didn't find any file export 'isomorphic-fetch', where is coming from?

If you look in package.json, you'll see "main": "fetch-npm-node.js", which means when you require it (in node), it will pull in the fetch-npm-node.js file. When installing it for the frontend (using bower), you'll see "main": "fetch-bower.js" in bower.json. Hope this answers your question.

@AaronHarris , thanks dude, I found the all stuff I want.


Adding source code to produce the ar/ version of this dataset.

LGTM. However, I can't approve since I'm a co-author of this CL. We'll have to ask @DarshanSP19 :)


Better backwards compatibility

When new gt_* columns are added to the database in a new version, the GeminiQuery logic will break for databases created from earlier versions of GEMINI, since GeminiQuery explicitly queries for all gt_* columns when a user does a select * from variants query.  This yields a "column not found" error.  We should have checks in the code to make sure that an appropriate database version is present and if not, cull the column list to solely those columns that should be present for the given version.
Similarly, we need tools and options in the tools to be more backwards compatible.  For example, the new mendelian_errors tool will break for older Dbs since the PL columns are not present.  Thanks to @drmjc for bringing this up.

excellent, thanks @arq5x

+1


discovery: send empty group on empty SD config

Closes #4812
cc @krasi-georgiev @grobie

Friendly ping for @grobie and @krasi-georgiev

LGTM
as part of reviewing this I found a bug in the yaml package which doesn't dstinguish between nil and empty config so this might be able to be handled better if the yaml package changes its behaviour.
https://github.com/go-yaml/yaml/issues/417


Config is not overridable

After publishing and modifying the config file (to change translations scanners), it doesn't change anything, since it is always merged with the default one.
Example of my modified config file:
return [
    ...

    'translations' => [
        'scan' => [],

        //-----------------------------------------------------
        // Example of external language file
        //-----------------------------------------------------

        'external' => [
            [
                'group' => 'permissions',
                'scan' => [
                    JsonScanner::class => [
                        'paths' => [
                            resource_path('translations/permissions'),
                        ]
                    ],
                ]
            ],
            [
                'group' => 'locales',
                'scan' => [
                    JsonScanner::class => [
                        'paths' => [
                            resource_path('translations/locales'),
                        ]
                    ],
                ]
            ],
            [
                'scan' => [
                    PhpArrayScanner::class => [
                        'paths' => [
                            lang_path('/'),
                        ]
                    ],
                ]
            ]
        ],

What I get when I access config('craftable-pro.translations') (notice duplicated items in array and non empty value of scan key). This way I cannot disallow to scan translations in blades for example.
[
    "scan" => [
      "Brackets\CraftablePro\Translations\Scanners\Internal\PhpScanner" => [
        "paths" => [
          "/var/www/html/vendor/brackets/craftable-pro/src/Http/Controllers",
          "/var/www/html/resources/views",
        ],
      ],
      "Brackets\CraftablePro\Translations\Scanners\Internal\JsScanner" => [
        "paths" => [
          "/var/www/html/vendor/brackets/craftable-pro/resources/js",
          "/var/www/html/resources/js",
        ],
      ],
    ],
    "external" => [
      [
        "group" => "permissions",
        "scan" => [
          "Brackets\CraftablePro\Translations\Scanners\External\JsonScanner" => [
            "paths" => [
              "/var/www/html/resources/translations/permissions",
            ],
          ],
        ],
      ],
      [
        "group" => "locales",
        "scan" => [
          "Brackets\CraftablePro\Translations\Scanners\External\JsonScanner" => [
            "paths" => [
              "/var/www/html/resources/translations/locales",
            ],
          ],
        ],
      ],
      [
        "scan" => [
          "Brackets\CraftablePro\Translations\Scanners\External\PhpArrayScanner" => [
            "paths" => [
              "/var/www/html/resources/lang//",
            ],
          ],
        ],
      ],
      [
        "group" => "permissions",
        "scan" => [
          "Brackets\CraftablePro\Translations\Scanners\External\JsonScanner" => [
            "paths" => [
              "/var/www/html/resources/translations/permissions",
            ],
          ],
        ],
      ],
      [
        "group" => "locales",
        "scan" => [
          "Brackets\CraftablePro\Translations\Scanners\External\JsonScanner" => [
            "paths" => [
              "/var/www/html/resources/translations/locales",
            ],
          ],
        ],
      ],
      [
        "scan" => [
          "Brackets\CraftablePro\Translations\Scanners\External\PhpArrayScanner" => [
            "paths" => [
              "/var/www/html/resources/lang//",
            ],
          ],
        ],
      ],
    ],
    "publish" => [
      "craftable-pro" => [
        "groups" => [
          "craftable-pro",
          "permissions",
          "locales",
          "craftable-pro",
          "permissions",
          "locales",
        ],
        "path" => "/var/www/html/public/lang/",
      ],
    ],
  ]

@strstensky any update on this? I believe this is still an issue.


patch for listening to empty directories

Fix for #177.

This still needs some work - forgot to run npm test and there's some lints that are getting caught now.

I saw this PR now. What is the status que on it?

@nowindowsowrking It's been neglected. I've been away from the node world for a while and am not sure when I'll be back. I'll close this PR now, and you're welcome to take it over


Fix line breaks in emoji picker related to realm emoji on chat.zulip.org

There's a weird issue with realm emoji causing line breaks in the emoji/reactions picker.  You can see this if you scroll down to :glenda: in the chat.zulip.org emoji picker.
Note that chat.zulip.org is running tabbott/master which has a few extra commits that are emoji-related and could partially cause this; those extra commits will be merged into master soon, so it's worth fixing this regardless.

@zulipbot claim.

Reproducible on the latest master as well.


Image uploader caching is not scalable

Image uploader loads the entire bucket into the cache on any request. This means the time to open the uploader is proportional to the total size of the bucket, rather than to the size of folder being viewed/operated on.

Hi @p-decoraid
Camaleon CMS is caching the bucket data in the DB to optimize (The api doesn't permit to load data only for specific folder).

The api gem doesn't permit to load data only for specific folder

Sure it does...

http://docs.aws.amazon.com/sdkforruby/api/Aws/S3/Client.html#list_objects_v2-instance_method, pass the folder as prefix.

@p-decoraid you are right.
Added the optimization!


(MODULES-7845) Fix Module Build

Puppet 6 removes the puppet module build command. This functionality
has been moved over to PDK. Currently PDK has some issues that make it
difficult use the PDK version of that command. We are pinning to
Puppet 5 until PDK can be fixed.

Derp.  Of course that's the best solution.  The test itself isn't really Puppet version specific either.


CentOS 6.9 is not supported?

LSB Version:	:base-4.0-amd64:base-4.0-noarch:core-4.0-amd64:core-4.0-noarch
Distributor ID:	CentOS
Description:	CentOS release 6.9 (Final)
Release:	6.9
Codename:	Final
I've got the following error:
node_modules/puppeteer/.local-chromium/linux-526987/chrome-linux/chrome:
error while loading shared libraries: libatk-bridge-2.0.so.0:
cannot open shared object file: No such file or directory

Any help? Am I have to upgrade to CentOS 7 ?

Make sure you install all the depencies for Chrome. Here is a list I use on Ubuntu
https://gist.github.com/DavidFricker/67319b82b822246f0a1f2c2e60b17b05
From the looks of it you're missing libatk1.0-0

@DavidFricker THX for replying，at last I upgraded to CentOS 7, installed the dependencies, and now it's running good.

Does anyone know the answer ... upgrading to centOS 7 may not be a choice.


webtools.js expose as a separate module - remove from index.js and rename

This was a bad experiment. Version 3.0.0 removed this module.


Vespa grouping language requires grouping to take place

Describe the bug
Certain vespa grouping language snippets don't work like I'd expect them to work, I was instructed to open a GH issue as per recommendation of @bratseth. Specifically I'd assume that the grouping command all(output(min(price))) is equivalent to all(group(1) each(output(min(price)))). Instead the following error is returned when the first query is executed:
Failed: Cannot invoke "com.yahoo.searchlib.expression.SingleResultNode.min(com.yahoo.searchlib.expression.ResultNode)" because "this.min" is null", "stackTrace":"java.lang.NullPointerException: Cannot invoke "com.yahoo.searchlib.expression.SingleResultNode.min(com.yahoo.searchlib.expression.ResultNode)" because "this.min" is null at com.yahoo.searchlib.aggregation.MinAggregationResult.onMerge(MinAggregationResult.java:81) at com.yahoo.searchlib.aggregation.AggregationResult.merge(AggregationResult.java:49) at com.yahoo.searchlib.aggregation.Group.merge(Group.java:82) at com.yahoo.searchlib.aggregation.Grouping.merge(Grouping.java:70) at com.yahoo.search.grouping.vespa.GroupingExecutor.mergeGroupingMaps(GroupingExecutor.java:280) at com.yahoo.search.grouping.vespa.GroupingExecutor.performSearch(GroupingExecutor.java:254) at com.yahoo.search.grouping.vespa.GroupingExecutor.search(GroupingExecutor.java:91) at com.yahoo.search.Searcher.process(Searcher.java:134) at com.yahoo.processing.execution.Execution.process(Execution.java:112) at com.yahoo.search.searchchain.Execution.search(Execution.java:499) at com.yahoo.search.searchers.ValidateFuzzySearcher.search(ValidateFuzzySearcher.java:42) at com.yahoo.search.Searcher.process(Searcher.java:134) at com.yahoo.processing.execution.Execution.process(Execution.java:112) at com.yahoo.search.searchchain.Execution.search(Execution.java:499) at com.yahoo.search.searchers.ValidateMatchPhaseSearcher.search(ValidateMatchPhaseSearcher.java:55) at com.yahoo.search.Searcher.process(Searcher.java:134) at com.yahoo.processing.execution.Execution.process(Execution.java:112) at com.yahoo.search.searchchain.Execution.search(Execution.java:499) at com.yahoo.search.searchers.ValidateNearestNeighborSearcher.search(ValidateNearestNeighborSearcher.java:51) at com.yahoo.search.Searcher.process(Searcher.java:134) at com.yahoo.processing.execution.Execution.process(Execution.java:112) at com.yahoo.search.searchchain.Execution.search(Execution.java:499) at
To Reproduce
Steps to reproduce the behavior:

Go to https://docs.vespa.ai/en/grouping.html2.
Enter "all(group(1) each(output(min(price))))"
Execute the query

Expected behavior
I would expect the query to return the minimum price over all results.
Screenshots

Environment (please complete the following information):

OS: macOS
Infrastructure: self-hosted arm docker image
Versions 12.4

Vespa version
8.37.26
Additional context
Add any other context about the problem here.

Hi @lukasmoellerch. The query all(output(min(price))) is invalid - a group clause is required. Using a fixed value as the expression for group produces the expected result:
https://doc-search.vespa.oath.cloud/search/?yql=select * from purchase where true | all(group(1)each(output(min(price)))).
The lack of group should produce a proper error response and not cause the searcher to crash. I'll create a new issue to track that.

A better error message is good, but I think aggregation without grouping is a valid use case and this should be a feature request.

Necessary to build e-commerce filters like price/date sliders.

Workaround until this is done: Put everything in one group by grouping on a constant.


Fix time precision

Tested on multiple target with angle + duration config, if several targets in one sequence, then servo will not stop after (faster) intended duration.
Issue: due to the rounding when calculate speed ( duration / angle) , also the rounding of ellipse time check, as million returns unsign long.
Solution:
~~1. using a fix point arithmetic (AKA store speed as speed * 1000 to preserve the precision)
2. check the total duration of sequence, instead of checking the time between each degree

that PR is cancel due to the bug


Missing hubconf.py file?

Hi,
Is it an plan to create a hubconf.py file to make it is easy to use the torch.hub.load and use the pre-trained models?

see https://github.com/lyuwenyu/RT-DETR/pull/436

After I try the implementation I get this error:
File home/username/lyuwenyu_RT-DETR_master/rtdetrv2_pytorch/src/core/_config.py", line 8, in <module>
    from torch.optim.lr_scheduler import LRScheduler
ImportError: cannot import name 'LRScheduler'

And I'm wondering what kind of package this code has? I don't think the packages that is written in the requirement file doesn't reflex the real requirements to run the code.
I have this version installed on my system mention in the requirement file:
torch==2.1.0
torchvision==0.16.0
pycocotools==2.0.7
tensorboard==2.14.0
tensorboard-data-server==0.7.2
PyYAML==6.0.1

I don't know the reason, but according to the source code of 2.1, there is this class.  You can check it in your local machine.
https://github.com/pytorch/pytorch/blob/release/2.1/torch/optim/lr_scheduler.py#L26
from torch.optim.lr_scheduler import LRScheduler

Sorry, I have confused my self with having python 3.6 + 3.8 on same machine. Therefore I had these problems with not having the same right libs installed.


Refactoring of CDS to improve caching support

For https://github.com/istio/istio/issues/26732

configgen takes in cache
drop some dependencies on proxy

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9136e16b546b1be323881fc1df8e1a73190b8847
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9136e16b546b1be323881fc1df8e1a73190b8847
link
/test lint_istio

unit-tests_istio
9136e16b546b1be323881fc1df8e1a73190b8847
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test unit-tests_istio

integ-security-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test unit-tests_istio

integ-security-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-security-k8s-tests_istio

lint_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test unit-tests_istio

integ-security-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-security-k8s-tests_istio

lint_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test lint_istio

integ-distroless-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test unit-tests_istio

integ-security-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-security-k8s-tests_istio

lint_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test lint_istio

integ-distroless-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test unit-tests_istio

integ-security-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-security-k8s-tests_istio

lint_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test lint_istio

integ-distroless-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test unit-tests_istio

integ-security-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-security-k8s-tests_istio

lint_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test lint_istio

integ-distroless-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test unit-tests_istio

integ-security-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-security-k8s-tests_istio

lint_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test lint_istio

integ-distroless-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-pilot-k8s-tests_istio

release-test_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test unit-tests_istio

integ-security-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-security-k8s-tests_istio

lint_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test lint_istio

integ-distroless-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-pilot-k8s-tests_istio

release-test_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test release-test_istio

integ-operator-controller-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test unit-tests_istio

integ-security-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-security-k8s-tests_istio

lint_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test lint_istio

integ-distroless-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-pilot-k8s-tests_istio

release-test_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test release-test_istio

integ-operator-controller-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test unit-tests_istio

integ-security-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-security-k8s-tests_istio

lint_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test lint_istio

integ-distroless-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-pilot-k8s-tests_istio

release-test_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test release-test_istio

integ-operator-controller-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test integ-ipv6-k8s-tests_istio

analyze-tests_istio
215cdd416adf6d874d6f83db7ecb24cba20ab105
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Added support for Upstart.

When using this cookbook on Ubuntu 14.04 it was failing to either enable
or start the service.

will review once tests pass

Fixed!

@shortdudey123 as tests have passed, could this be merged? Thanks!

It looks like chef will default to upstart if an upstart script for the service is present (see https://github.com/chef/chef/blob/a52dee886b6635fbc0fcca6cbb04d28bbdaed9e6/lib/chef/provider/service.rb#L204)

Ok, it looks it will, but it's not in v11.18.0 (https://github.com/chef/chef/blob/11.18.0/lib/chef/provider/service.rb) which is the one I'm currently using.

Yeah, looks like it was added in chef 12.
Can you add a chef version chef for < 12?

Ok, I'll do it tomorrow.
On Tue, Sep 29, 2015 at 18:42, shortdudey123/chef-gluster
<EMAIL_ADDRESS>wrote:
Yeah, looks like it was added in chef 12.
Can you add a chef version chef for < 12?
—
Reply to this email directly or view it on GitHub
[https://github.com/shortdudey123/chef-gluster/pull/30#issuecomment-144199848] .[https://github.com/notifications/beacon/AEH0tF3flVSgK5T9_4vdPUlJX1d8HH0mks5o2v1PgaJpZM4GBN3t.gif]

Cool, will merge this once the chef version check is added

@leoditommaso any update on the Chef version chef? also, can you rebase your commits into 1 once you are done?

Closing due to inactivity


add context field.

With pull requests:

Open your pull request against main
Your pull request should have no more than two commits, if not you should squash them.
You should pass all tests by go test -v ./... at the project root path in local.
It should pass all tests in the available continuous integration systems such as GitHub Actions.
You should add/modify tests to cover your proposed code changes.
If your pull request contains a new feature, please document it on the README.

Codecov Report

Merging #48 (752b109) into main (e87630c) will decrease coverage by 1.52%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   56.48%   54.95%   -1.53%
==========================================
  Files           6        6
  Lines         108      111       +3
==========================================
  Hits           61       61
- Misses         44       47       +3
  Partials        3        3

Impacted Files
Coverage Δ

internal/core/plugin/response/response.go
0.00% <0.00%> (ø)

internal/core/plugin/chain.go
45.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e87630c...752b109. Read the comment docs.


Could not access to Diagnostic settings by security administrator role.

I tried the settings on my environment but I couldn't perform following operation by "security administrator" role.
--
2. Select Azure Active Directory > Diagnostic settings -> Add diagnostic setting. You can also select Export Settings from the Audit Logs or Sign-ins page to get to the diagnostic settings configuration page.
Needed  "global administrator" role to perform this operation.
Could you fix the "Prerequisites" on this document ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b1eb6343-c4d6-6b06-f2eb-1c9435f997f3
Version Independent ID: 7413b72d-8305-eb0f-3876-2fcb013c5196
Content: Stream Azure Active Directory logs to Azure Monitor logs
Content Source: articles/active-directory/reports-monitoring/howto-integrate-activity-logs-with-log-analytics.md
Service: active-directory
Sub-service: report-monitor
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@emshimon
Thanks for your feedback! We will investigate and update as appropriate.

@emshimon
Thank you for pointing this out! Using my own tenant, I was able to see the Diagnostic Settings tab with my test user which was assigned the Security Admin role.

If you received a permissions error with a user that is assigned to the security admin role, I'd recommend signing out and back in, and retrying the operation.
Since this role is currently supported to view the Diagnostic settings, I'll go ahead and close out this issue.
Thank you for your time and patience throughout this issue.

@JamesTran-MSFT
I could see and set diagnostic settings.
Thank you for your help!


Update documentation

Reduce public API surface where possible (e.g. replace export of SlackConfig with fine-grained options exposed via the layer builder)
Add screenshot of slack messages sent from the examples in the README

Completed in v0.6.0


Adding restriction about arrow functions

This documents the linter restriction in Office Scripts around arrow functions.

Docs Build status updates of commit a5e1428:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/typescript-restrictions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 0edabf9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/typescript-restrictions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Thanks @wandyezj. I've updated the sentence accordingly.

Docs Build status updates of commit 1a80198:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/typescript-restrictions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Added more options to Expect module

Looking at the expect module from Expecto (here), it feels really bad to not be able to use all the nice convenience features
So I added them with some test cases to make sure they all work as expected and the same as in Expecto
I'm not quite sure why the build fails. I haven't been able to replicate it locally. It seems to be some inconsistency with the Fable compiler.

Hi there @Linschlager thanks a lot for the PR! these changes look good. I am not sure either why this error occurs 🤔
TypeError: cond$$7.CompareTo is not a function

I will look into it in the coming days
Sorry for the late reply! 🙏


[Hospitality] update to latest

Purpose
What is the context of this pull request? Why is it being done?
Update to latest https://github.com/microsoft/botframework-solutions/commit/acdfdda8b1223f602ed279d2b6227197e9105218
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

only update async in main
move AllowedCallersClaimsValidator to SkillServiceLibrary
send WelcomeMessage in OnMembersAddedAsync as skill

Tests
Is this covered by existing tests or new ones? If no, why not?
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated the appropriate tests
[ ] I have updated related documentation

update other dialogs to async


[DevOps] Continuouos integration issues across multiple platforms

Describe the issue
There are a few scattered issues that I'm leaving an official record of for any frontend wizards out there

puppeteer fails stochastically on certain windows/ubuntu workflows; all tests pass locally but we disabled the GitHub actions in the meantime

Some speculation it comes down to random timeouts (according to debugging snapshots) but no idea why certain steps get hung up for so long if so

Daily tests on Mac (both arm and intel) started failing as of July 25, 2024 due to a stall/freeze in the postinstall step of npm ci

This has been observed occasionally before #678 but in that case updating the package.lock file was sufficient to resolve it
Both #898 and #899 failures to resolve the issues, so they have been disabled in the meantime
Again, building works fine locally
This one is slightly more significant because it does mean that our automated build+release won't work for Mac distributions, and we will instead have to push releases manually
Steps to Reproduce
See Action logs
Operating System
Mac
GUIDE Version
v1.0.2
Code of Conduct
Yes
Did you confirm this issue was not already reported?
Yes

Thanks to @rly for solving all of this!


Quotes are concealed in json files

When I open a .json file with some some quotes are concealed

You can fix it with this setting
let g:webdevicons_conceal_nerdtree_brackets=0
greetz

can you tell me which version you have?
echo webdevicons#version()

0.4.0
I installed it via NeoBundle.

can you try to update?
this issue should be fixed in 0.4.1
Let me know either way if that solves your problem (without having to disable the conceal feature)

hmm...after :NeoBundleUpdate! I still have version 0.4.0.

I switched to master branch and the issue is gone. Thanx for your help.

@punknroll :+1: no problem. Glad that was the fix :smile: