Increase test coverage

Some error messages not tested in the new fetch/read polytope methods. (This should be easy, I think.)
Also, we never test reading from files. Somehow, this should be tested.

@ariostas Any thoughts on the latter?

I'm not very familiar with how GitHub testing works. However, reading from a file vs string uses the same code, so as long as the few lines that read the contents of the file are not broken then it should be fine.

There are multiple sets of tests being executed:

Running the code,
Executing code that is used for the documentation,
Setting up and deploying (i.e. shipping to the website) the documentation.

Here, I am mostly thinking about 1. Those tests are spelled out in the /test/runtests.jl file. (The doc tests are all examples that you add for the docstrings.) In the case at hand, I would like to check that the few lines that read from a file work. From what I read in the code and you are saying, the file should have the same content as the string that we are currently handing over to the method, correct?
If yes, then we could indeed add this as a test file and use that to add test coverage for those lines too.
Minor related point: Unless I am mistaken, as of now, the code does not test if the exists and is readable. So this might backfire badly. Could be improved as we add tests for this.


[BUG] Strange behavior with nested Pagers

Describe the bug
I am experiencing a strange behavior trying to use nested pagers, with an outer horizontal pager and an inner vertical pager on each page. The outer pager works totally fine. The inner vertical pagers appears to change pages, but the animation looks very strange, and it does not behave 100% correctly in all cases. On this one unfortunately I have no idea what the issue is. Hopefully its an error in my configuration.
To Reproduce
This code will reproduce the issue.
struct ContentView: View {
    @State var outerPage: Int = 0
    @State var innerPages: [Int] = [0, 0, 0]

    var body: some View {
        ZStack {
            Pager(page: $outerPage, data: Array(0..<3)) { parent in
                Pager(page: $innerPages[parent], data: Array(0..<10)) { item in
                    ZStack {
                        Color.red
                        Text("\(parent)_\(item)")
                            .foregroundColor(.white)
                    }
                }
                .vertical()
                .pagingPriority(.simultaneous)
            }
            .pagingPriority(.simultaneous)
        }
    }
}

Expected behavior
I would expect that each of the internal pagers behave correctly as a vertical pager
Screenshots / Videos
The behavior will be very easily observed using the above code sample
Environment:

OSX: [e.g. iOS] iOS 14.2
Device [e.g. iPhone6] iPhone 7
SwiftUIPager version 1.14.1

Additional context
Add any other context about the problem here.

Hi @metsfan , I'm gonna tell you the whole story and maybe you can help with this one. I changed page from being a simple Binding to an ObservedObject. Reason is I found that for some reason the views were being updated in two steps:

First the State variables
Then the Binding
This didn't happen with an ObservedObject. You can find more info here and here. You can maybe try with version 1.13.0 and see if it works better and ping me here.

I've tested your code and I've managed to make it work by changing ObservedObject to StateObject (line 150  in PagerContent)

@metsfan I've released 1.14.2-beta.1 that should fix this problem on iOS 14. Unfortunately, the problem still exists on iOS 13.

@fermoya Your update in 1.14.2-beta1 appears to have solved the issue entirely. I think changing to StateObject seems to have solved the problem. Thankfully I'm targeting iOS 14 so it's not an issue for me. Given that iOS 14 adoption is already over 70% it's probably fine.

@fermoya the only bug I'm seeing now is that the onPageChanged callback is not being called.

@metsfan it might not be so direct as I'd expected. I'll need to dive deeper into this. For now, I would suggest using version 1.13.0. That one is using a Binding and should work fine

Ok thanks

it might not be so direct as I'd expected. I'll need to dig deeper into this. For now, I would suggest using version 1.13.0. That one is using a Binding and should work fine

The change seems to break onPageChanged handler for me, it stops getting called after the first or second call.

I've made a new beta 1.14.2-beta.2. Please, use the new initializer I've made available and let me know if you find any other issue:
struct ContentView: View {
    @StateObject var outerPage = PagerModel(page: 0)
    @State var innerPages: [PagerModel] = [
        PagerModel(page: 0),
        PagerModel(page: 0),
        PagerModel(page: 0)
    ]

    var body: some View {
        ZStack {
            Pager(page: outerPage, data: Array(0..<3)) { parent in
                Pager(page: innerPages[parent], data: Array(0..<10)) { item in
                    ZStack {
                        Color.red
                        Text("\(parent)_\(item)")
                            .foregroundColor(.white)
                    }
                }
                .vertical()
                .pagingPriority(.simultaneous)
            }
            .pagingPriority(.simultaneous)
        }
    }
}

extension Int: Identifiable {
    public var id: Int {
        self
    }
}

I've made a new beta 1.14.2-beta.2. Please, use the new initializer I've made available and let me know if you find any other issue:
struct ContentView: View {
    @StateObject var outerPage = PagerModel(page: 0)
    @State var innerPages: [PagerModel] = [
        PagerModel(page: 0),
        PagerModel(page: 0),
        PagerModel(page: 0)
    ]

    var body: some View {
        ZStack {
            Pager(page: outerPage, data: Array(0..<3)) { parent in
                Pager(page: innerPages[parent], data: Array(0..<10)) { item in
                    ZStack {
                        Color.red
                        Text("\(parent)_\(item)")
                            .foregroundColor(.white)
                    }
                }
                .vertical()
                .pagingPriority(.simultaneous)
            }
            .pagingPriority(.simultaneous)
        }
    }
}

extension Int: Identifiable {
    public var id: Int {
        self
    }
}

Should be solves now, please use release 2.0.0

Should be solves now, please use release 2.0.0


Decide how to handle restricted audio/video items on the work page

Relates to #5762
For most works we provide a link to the item page to view the material. However, for audio and video items we display them on the work page.
If these items are restricted we don't show them, however, we will want to show them if a staff member is logged in and has the necessary permissions.
This would mean doing something similar to #5761, on the work page (but only for audio/video items)
OR should we make the items page capable of displaying audio and video (and pdfs), remove the audio and video from the work page and always link to the item page.
This would make any further work around restricted items unnecessary.
There are also other reasons to do this:

https://github.com/wellcomecollection/wellcomecollection.org/issues/9423
Would make the code much simpler and more maintainable
If we wanted to link to the viewer for born digital items which we can display. These can be a mix of file types such as images, audio and video so we would need to
More consistent user experience

Discussed as a team and agreed to move audio and video player into viewer as reasons stated above outweigh benefits of having one less click for the user to access the work.


Clean up $user vs. $wgUser

In src/DiscordHooks.php, some functions require a $user parameter to be passed in, whereas others use the $wgUser global. This is inconsistent and potentially a source of errors (e.g. I almost didn't notice the discrepancy in #8 ). If there's a functional difference between these, it needs to be clearly documented.

The reason some of the hooks use $wgUser is because the hook itself does not pass the User object associated with that specific action, so we have to fall back to the global variable. It's not pretty, but there's not really much else we can do about it.

Another reason to do this is because $wgUser is going away.


EmptyCell error

When running through an Excel with multiple sheets I eventually get this error
  File "C:\Users\...\AppData\Local\pypoetry\Cache\virtualenvs\sfdata-annexa-clean-0V-eWLLp-py3.10\lib\site-packages\sfdata_stream_parser\parser\openpyxl.py", line 14, in _parse_sheet     excel_location=cell.coordinate, excel_number_format=cell.number_format) AttributeError: 'EmptyCell' object has no attribute 'coordinate'

This is confirmed with read-only sheets when they contain an empty row. OpenPyXL fill the empty rows with 'dummy cells' that do not have the normal properties.
See the following modified unit test that adds an empty row to the standard test suite.
emptycell-error-patch.txt


[dask] Rework base margin test.

A small part extracted from https://github.com/dmlc/xgboost/pull/6591 .
Close #6300

Codecov Report

Merging #6627 (1b6ff8c) into master (d6d72de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6627   +/-   ##
=======================================
  Coverage   81.13%   81.13%
=======================================
  Files          13       13
  Lines        3679     3679
=======================================
  Hits         2985     2985
  Misses        694      694

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d72de...1b6ff8c. Read the comment docs.

Codecov Report

Merging #6627 (1b6ff8c) into master (d6d72de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6627   +/-   ##
=======================================
  Coverage   81.13%   81.13%
=======================================
  Files          13       13
  Lines        3679     3679
=======================================
  Hits         2985     2985
  Misses        694      694

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d72de...1b6ff8c. Read the comment docs.


Distinguish clean for test and test-all

'make clean-test' should only get rid of the artifacts from 'make test'.
'make clean-test-all' will get rid of the containers and other artifacts
from 'make test-all'.

LGTM


enforceEmailVerification with other services and account-meld

The doc says:

Warning: experimental! Use it only if you have accounts-password as the only service!!!

Well, I have just realized my app uses enforceEmailVerification with Facebook and Google services, and also with account-meld.
What kind of risk am I taking?

This is what you get as login hook when you enable the enforceEmailVerification option.
I think the doc should be rephrased a bit.
If you'r not using accounts-password you don't risk anything actually!
...the problem would be using OAuth services that let you in even if you're email address is not verified while telling you it is..
If you also use the password service you would risk to let a user in even if she did not verify any registered email.

Sorry, I forgot to say I use Facebook, Google and accounts-password.
I guess Facebook is ok, as it ensures that the email is verified. However, Google is a problem.
Am I right to say that your enforceEmailVerification hook could check for Google verified email, just like in account-meld?  Then the doc could say:

enforceEmailVerification: works only if you use accounts-password and/or accounts-facebook and/or accounts-google. Using any other service will allow a user to log-in without having a verified email address

Looking better at the code I linked above, especially this line and this one, I recalled what could happen.
Since it's controlling the emails field of the user object, and not the registered_emails maintained for splendido:accounts-meld, this is what could happen:

A users register with the password but ignores the email with the verification link she get
Then come back to the app and logs in with ShameService which let you in even with non-verified email.
by chance (or by purpose...) the email address is the same used before and the two accounts get melded.
the user is let in since the OAuth login was successfull

So you wanted your users using password login to verify their emails before being allowed to access your app, but using also an OAuth service not enforcing email verification (e.g., Facebook or LikedIn see this table you  frustrated the request for email verification.
I hope the example is clear...
How would you put this on the docs?

Is this line actually called? (i.e. is it possible to have info.type === "password" && info.methodName === "login" && info.methodArguments[0].user.email === falsey?)

If the user logs in using username and password you don't get an email address here, so you'll have to look among the emails within the user object (see here).
It would be awesome if you could test it out once again ;-)

Looking at your code, I have another question:
Suppose I create an account with 2 email addresses, where one is verified and the other is not. If I try to login with the unverified email, my login will be rejected, right? Don't you think a more useful feature would be that my login is rejected only if I have no unverified email?

If the user logs in using username and password you don't get an email address here, so you'll have to look among the emails within the user object (see here).

Of course, sorry for the dumb question (I forgot about this "login with username" feature, as I don't use it in my app).

mmmm, I guess you're right.
with the username login we're asking to have at least one verified email..
...while with the email login we're asking the email used for the login attemp is verified itself.
Would you get rid of the if clause and keep only these lines then?

...or you meant you'd let a user login only if ALL her email are verified?

Would you get rid of the if clause and keep only these lines then?

Yes I would.
I don't know if this is the general need, but it is definitely my need :-)
However, I also question the very opportunity of having this feature in this package. I am currently thinking about it, I will come back to you shortly.

...it will probably make more sense when also splendido:accounts-meld will be integrated into UA: this is likely to happen with<EMAIL_ADDRESS>

Yes, definitely!

For your information, here is my code:
  // Ensure user has a verified email address
  Accounts.validateLoginAttempt(function (info) {
    // If the attempt has failed: nothing to do
    if (! info.allowed)
      return false;

    //
    // WE WILL CHECK THAT USER HAS AT LEAST ONE VERIFIED EMAIL IN AT LEAST ONE
    // LOGIN SERVICE
    //
    // Notice that we can't check the "registered_emails" field of
    // splendido:meteor-accounts-emails-field, because it has not been updated
    // yet (it will be later in the "onLogin" hook).
    // However, at this stage, even for a first login, "info.user" has been
    // updated with latest login information.
    //
    var found = false;

    // Check account-password. See:
    // https://github.com/meteor-useraccounts/core/blob/3862dd2ffee16902c9c94cc015cc0bbea3546c34/lib/server.js#L108-111
    found = found
      || _.find(info.user.emails, function (e) { return e.verified; });

    // Check Facebook: no need to do anything, as Facebook enforces email
    // verification
    found = found || info.user.services.facebook;

    // Check Google: see if verified_email is true.
    // THIS MIGHT NOT BE NECESSARY, see:
    // https://github.com/splendido/meteor-accounts-emails-field/issues/28
    found = found
      || (info.user.services.google && info.user.services.google.verified_email);

    // If a verified email address has been found, quit
    if (found)
      return true;

    // Address not found: display an error message based on the latest login
    // service user has tried
    var msg;
    switch (info.type) {
      case 'password':
        msg = 'Cannot sign-in because your email address has not been '
          + 'verified. Please check your inbox or spam folder and click the '
          + 'verification link.';
        break;
      case 'facebook':
        throw Error('should not happen (Facebook ensures email is verified)');
      case 'google':
        msg = 'Cannot sign-in with Google because your Google account has no '
          + 'verified email address. Please go through Google verification '
          + 'process or use another method to sign-in.';
        break;
      default:
        throw Error('should not happen (login with ' + info.type
          + ' is not supported)');
    }
    throw new Meteor.Error(401, msg);
  });

Awesome, It makes a lot of sense!
...@steph643, you seems to have dug well enough into both splendido:accounts-meld and splendido:accounts-emails-field: what about joining the team for useraccounts:meld? :-)
There's a board on trello where I'm trying to organize things a bit better...
Feel free to have a look at it!

Thanks @splendido. I would love to, but I am currently under heavy pressure and I cannot commit to anything more. I hope I can reconsider this in the future. In the meantime, I will try to help as much as I can.

Thanks @steph643 and @splendido for this important discussion.
If I uderstood @splendido well, could the warning be rephrase as follows?

Warning: experimental! Use it only if you have accounts-password as the only service OR in combination only with services that do not allow login of unverified emails (such as Facebook and Linked-In).

For my use case, the whole point of user login-in in is to have at least its correct email. Currently I am using only facebook and accounts-password. I was planning to introduce more, but after seeing [this table] https://github.com/splendido/meteor-accounts-emails-field#already-tested-services, it wouldn't make much sense anyway to add those other services, except for Linked-In.
Could I use enforceEmailVerification with no worries in this scenario then?


Introduce new predicates

What this PR does / why we need it:
Add new predicates to filter out clusters that don't have a control plane ready or were not marked for import. I didn't remove all similar logic from reconciler because I've seen in the past predicates failing and unexpected behavior happening because of that.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist:

[x] squashed commits into logical changes
[ ] includes documentation
[x] adds unit tests
[ ] adds or updates e2e tests

@furkatgofurov7 @Danil-Grigorev @richardcase all fixed, please take a look again

@Danil-Grigorev let's merge e2e suite first :D

@Danil-Grigorev let's merge e2e suite first :D

@alexander-demicev can we update the PR, e2e should be merged now

Apart from the action failure this looks good to me 👍

I managed to run e2e locally and it passed

@furkatgofurov7 Thanks for the review, I addressed all comments except for the last ones about tests. I like using before each blocks to set up objects for tests and then only assign parameters that are different inside it blocks. I'm not strongly against repeating object setup but it just looks prettier to me with before each.


Replace View on Map from city card to View Weather forecast

Steps to reproduce

Open destinations screen.
Swipe any city card. Following view is displayed

Expected behaviour
Replace View on Map with View weather forecast. On clicking that option, weather forecast screen should open up.

Currently, the weather forecast screen opens up by following steps:

Select any destination
Click on weather card

I'm taking this up!


WAF for Application Gateway is GA - References to Preview removed

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@mbsnl : Thanks for your contribution to the Azure documentation! The author, @amsriva, has been notified to review your proposed change.


Initiative implementation for Decommissioned/Sandbox LZ

Overview/Summary
Implementing new policies/initiatives for the Decommissioned and Sandbox management groups.
Includes portal accelerator update.
Addressing stories: AB#25743, AB#25744, AB#26309, AB#25742, AB#24618
Addressing spike: AB#23249
This PR fixes/adds/changes/removes

New Initiative for the Decommissioned landingzone including policies:

Initiative name: Enforce-LZ-Decomm.json

Allowed resource types - nothing allowed, however the policy requires at least one resource, so defaulting to 'microsoft.consumption/tags'.
New policy to deploy an auto shutdown policy for virtual machines - Deploy-Vm-autoShutdown.json

Portal accelerator updated with additional tab and options to enable this initiative.

New Initiative for the Sandboxes landingzone including policies:

Initiative name: Enforce-LZ-Sanbox.json

Not allowed resource types - blocking the deployment of ER/VPN/vWAN
Deny vNet peering cross subscription.

Portal accelerator updated with additional tab and options to enable this initiative.

Breaking Changes

N/A

Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
Testing URLs
The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

As part of this Pull Request I have

[X] Checked for duplicate Pull Requests
[ ] Associated it with relevant issues, for tracking and closure.
[X] Ensured my code/branch is up-to-date with the latest changes in the main branch
[ ] Performed testing and provided evidence.
[X] Ensured contribution guidance is followed.
[ ] Updated relevant and associated documentation.
[ ] Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

Kindly review, testing from portal experience proves successful.

Please review following on from #1175

@jtracey93 I have processed your feedback and integrated all the changes. As for your kind review.


Intercept calls are ignored

I have the following:
$builder = new HttpClientBuilder();
$builder->followRedirects(2);
$builder->intercept(new SetRequestTimeout(5000, 5000, 5000));
$builder->intercept(new LogHttpArchive("/tmp/test.txt"));
$builder->intercept(new SetRequestHeader('User-Agent', 'test'));
$builder->intercept(new SetRequestHeader('Accept-Encoding', 'gzip, deflate'));

$client = $builder->build();

..........

$request = new Request('myprivatehost');
$request->setBodySizeLimit(1024*1024*2);
$response = yield $client->request($request);
..........

Response is received fine, but none of the intercept classes are applied.
I've noticed they do get registered in the build loop (at least it seems so), but still not working.
I've verified that the user agent is missing by looking at my requested uri host logs, it uses the default amphp user agent.
I've verified that the http archiver doesnt work, by checking for existing /tmp/test.txt file, but there was none.
No exceptions are raised during runtime.
Any idea what i might be doing wrong?

The builder always returns a new instance, so you need to rewrite it to:
$client = (new HttpClientBuilder)
    ->followRedirects(2)
    ->intercept(new SetRequestTimeout(5000, 5000, 5000))
    ->intercept(new LogHttpArchive("/tmp/test.txt"))
    ->intercept(new SetRequestHeader('User-Agent', 'test'))
    ->intercept(new SetRequestHeader('Accept-Encoding', 'gzip, deflate'))
    ->build();


HttpIngester: Ability to attach URL parameters as intrinsic EVs on routes

Who was the customer who requested this feature?
A big one
What is the feature to be added?
Many of the HTTP data producers can provide URL and/or header values in addition to the actual data.
This is often things like index, source, etc... on HEC
But other webhooks can throw stuff in other parameters in the URL or header
Why should we add this feature? (Business justification? What problem is the feature trying to solve?)
Those extra parameters are often useful metadata that should right with each entry.  Customer states they use those to identify where data came from.
How does this feature address the above problem?
Allows for attaching intrinsic EVs to data that come in via the URL parameter or header.
Any other comments?
Make sure that there is logic in there to prevent grabbing sensitive header values like the authentication token... so... not EVERY header and/or url parameter is in play.

working as intended in 5.4.4-beta1


Default Button?

Hello so my comfy spicetify theme works 100% fine! But my play button remains the default which kind of bothers me. Do you know a fix?

There isn't a "fix", this is supposed to happen - how the theme was created. If you want it a customised one, then make a theme your-self / edit this one, or find another one.

There isn't a "fix", this is supposed to happen - how the theme was created. If you want it a customised one, then make a theme your-self / edit this one, or find another one.

Yes however on the actual release image it represents a custom curved button for play. So I assume this isn't supposed to happen


Can't monitor ARK server

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
I'm trying to monitor my ARK server and have tried both Gamedig and the Steam API method, but both don't work. I'm pretty sure this isn't an issue on my side, since installing Gamedig on the server that is also running my Uptime Kuma instance and trying to run gamedig --type arkse (ip censored) with the same IP specified on Uptime Kuma, it does return server info. When using the Steam API method, it said it couldn't find the server. Does anyone know what's happening here?
📝 Error Message(s) or Log
2023-05-20T19:11:34+02:00 [MONITOR] INFO: Get Monitor: 21 User ID: 1
2023-05-20T19:11:36+02:00 [MANAGE] INFO: Resume Monitor: 21 User ID: 1
2023-05-20T19:11:36+02:00 [MONITOR] INFO: Get Monitor: 21 User ID: 1
2023-05-20T19:11:36+02:00 [MONITOR] WARN: Monitor #21 'ARK Server': Pending: Server not found on Steam | Max retries: 1 | Retry: 1 | Retry Interval: 60 seconds | Type: steam
2023-05-20T19:11:42+02:00 [MONITOR] INFO: Get Monitor: 21 User ID: 1
2023-05-20T19:12:28+02:00 [MANAGE] INFO: Resume Monitor: 21 User ID: 1
2023-05-20T19:12:28+02:00 [MONITOR] INFO: Get Monitor: 21 User ID: 1
2023-05-20T19:12:28+02:00 [MONITOR] WARN: Monitor #21 'ARK Server': Pending: Server not found on Steam | Max retries: 1 | Retry: 1 | Retry Interval: 60 seconds | Type: steam
2023-05-20T19:13:05+02:00 [MANAGE] INFO: Resume Monitor: 21 User ID: 1
2023-05-20T19:13:05+02:00 [MONITOR] INFO: Get Monitor: 21 User ID: 1
2023-05-20T19:13:07+02:00 [MONITOR] WARN: Monitor #21 'ARK Server': Pending: Failed all 1 attempts | Max retries: 1 | Retry: 1 | Retry Interval: 60 seconds | Type: gamedig
2023-05-20T19:13:32+02:00 [MANAGE] INFO: Clear Events Monitor: 21 User ID: 1
2023-05-20T19:13:37+02:00 [MANAGE] INFO: Clear Heartbeats Monitor: 21 User ID: 1
2023-05-20T19:13:40+02:00 [MONITOR] INFO: Get Monitor: 21 User ID: 1
2023-05-20T19:13:42+02:00 [MANAGE] INFO: Resume Monitor: 21 User ID: 1
2023-05-20T19:13:42+02:00 [MONITOR] INFO: Get Monitor: 21 User ID: 1
2023-05-20T19:13:44+02:00 [MONITOR] WARN: Monitor #21 'ARK Server': Pending: Failed all 1 attempts | Max retries: 1 | Retry: 1 | Retry Interval: 60 seconds | Type: gamedig
2023-05-20T19:14:46+02:00 [MONITOR] WARN: Monitor #21 'ARK Server': Failing: Failed all 1 attempts | Interval: 60 seconds | Type: gamedig | Down Count: 0 | Resend Interval: 0
2023-05-20T19:15:48+02:00 [MONITOR] WARN: Monitor #21 'ARK Server': Failing: Failed all 1 attempts | Interval: 60 seconds | Type: gamedig | Down Count: 0 | Resend Interval: 0
2023-05-20T19:16:50+02:00 [MONITOR] WARN: Monitor #21 'ARK Server': Failing: Failed all 1 attempts | Interval: 60 seconds | Type: gamedig | Down Count: 0 | Resend Interval: 0
🐻 Uptime-Kuma Version
1.21.3
💻 Operating System and Arch
Debian 11 x86
🌐 Browser
LibreWolf 112.0.2-1
🐋 Docker Version
Docker version 24.0.0, build 98fdcd7
🟩 NodeJS Version
16.20.0 (via docker exec)

Nevermind, seems like for some reason my server was running on the wrong port.


coredns config in charm should default to empty

Deployed charm-microk8s with addon dns enabled with dns server <IP_ADDRESS>
$ juju config microk8s addons dns:<IP_ADDRESS> hostpath-storage: metallb:<IP_ADDRESS>-<IP_ADDRESS>
However the coredns still shows <IP_ADDRESS>,<IP_ADDRESS> as forwarder.
$ microk8s.kubectl -n kube-system get cm coredns -o yaml
apiVersion: v1
data:
  Corefile: |
    # This file is managed by Juju. Manual changes may be lost at any time.

    .:53 {
        errors
        health {
          lameduck 5s
        }
        ready
        log . {
          class error
        }
        kubernetes cluster.local in-addr.arpa ip6.arpa {
          pods insecure
          fallthrough in-addr.arpa ip6.arpa
        }
        prometheus :9153
        forward . <IP_ADDRESS> <IP_ADDRESS>
        cache 30
        loop
        reload
        loadbalance
    }
kind: ConfigMap

Expected the forwarder to be <IP_ADDRESS>.
The problem is because of default config value of coredns which is hardcoded to <IP_ADDRESS>,<IP_ADDRESS>.4 as forwarder [1].
If coredns configuration is not updated, microk8s snap could have taken care to update forwarder in coredns configmap [2].
Suggestion is not to have any default value for config coredns_config and leave it to to microk8s to handle unless user specifies coredns_config.
[1] https://github.com/canonical/charm-microk8s/blob/master/config.yaml#L47
[2] https://github.com/canonical/microk8s-core-addons/blob/main/addons/dns/coredns.yaml#L35

Proposal sounds like a good compromise, but see my comment on the PR itself.
Also, worth mentioning that starting from MicroK8s 1.26, you should no longer have to specify the upstream nameservers when enabling the DNS addon, MicroK8s will pick them up from the host by default https://github.com/canonical/microk8s-core-addons/pull/111

I see the problem with microk8s 1.26 as well since the charm default is overriding the coredns configmap set by the microk8s snap.
So the charm default for coredns_config does not make sense.


Fix: typos

Describe your changes
tests: fix typos
full.rs: fix typo
CONTRIBUTING: fix typo

@bobbinth thank you very much for your review.


Update rustc option for instrument-coverage

Fix the nightly-coverage CI job by adjusting the flag for the nightly
rustc compiler.
Also throw in -C link-dead-code into the compiler flags for the
nightly-coverage CI job.

Codecov Report

Merging #1377 (15c1a42) into main (37822e5) will decrease coverage by 0.7%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

:exclamation: Current head 15c1a42 differs from pull request most recent head 23946a9. Consider uploading reports for the commit 23946a9 to get more accurate results

@@           Coverage Diff           @@
##            main   #1377     +/-   ##
=======================================
- Coverage   59.7%   59.0%   -0.7%
=======================================
  Files        275     275
  Lines      27597   27930    +333
=======================================
+ Hits       16485   16491      +6
- Misses     11112   11439    +327

Files
Coverage Δ

light-client-verifier/src/errors.rs
3.3% <ø> (ø)

... and 4 files with indirect coverage changes
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!


Linking in research menu to research still locked causes exception filling window

Selecting a link in the research menu to another research project which is unavailable yet (parent research isn't complete) throws exceptions.
Exception filling window for CommunityCoreLibrary.MainTabWindow_Research: System.NullReferenceException: Object reference not set to an instance of an object
at CommunityCoreLibrary.MainTabWindow_Research.b__17 (CommunityCoreLibrary.HelpDef hd) [0x00000] in :0
at System.Linq.SortSequenceContext`2[CommunityCoreLibrary.HelpDef,System.Single].Initialize (CommunityCoreLibrary.HelpDef[] elements) [0x00000] in :0
at System.Linq.QuickSort`1[CommunityCoreLibrary.HelpDef].PerformSort () [0x00000] in :0
at System.Linq.QuickSort`1+c__Iterator21[CommunityCoreLibrary.HelpDef].MoveNext () [0x00000] in :0
at System.Collections.Generic.List1[CommunityCoreLibrary.HelpDef].AddEnumerable (IEnumerable1 enumerable) [0x00000] in :0
at System.Collections.Generic.List1[CommunityCoreLibrary.HelpDef]..ctor (IEnumerable1 collection) [0x00000] in :0
at System.Linq.Enumerable+c__IteratorF`1[CommunityCoreLibrary.HelpDef].MoveNext () [0x00000] in :0
at System.Linq.Enumerable.Count[HelpDef] (IEnumerable`1 source) [0x00000] in :0
at CommunityCoreLibrary.MainTabWindow_Research.DoWindowContents (Rect inRect) [0x00000] in :0
at Verse.Window+c__AnonStorey1C3.<>m__EE (Int32 x) [0x00000] in :0
(Filename: C:/buildslave/unity/build/artifacts/StandalonePlayerGenerated/UnityEngineDebug.cpp Line: 56)

possibly related - reloading CCL without closing RW seems to cause errors in research window but not help window

Perhaps people think the "reload if changing any setting more complicated than the volume" is a joke...

Closing this as research is getting a full rewrite


Update Plugin API

This is a first step towards making the plugin API more generally useful.
The sample plugin I have in mind is to address #862. The idea is to fix indentation when python code is run: if all lines in the code being run start with identical whitespace, the plugin should strip off that whitespace and run the unindented code instead. As a first step I've created a plugin that simply prepends a print statement to all python code run (I haven't written the actual whitespace transformation yet because I spent most of today on these plugin API updates).
To implement this plugin the following new features need to be added to the plugin API:

Detecting when code is about to be executed
Modifying code to be executed (I have decided to break this up into cancelling the original execution event, followed by issuing a new one from the plugin itself)
Detecting when a new kernel is created (because listeners for kernel execution should only be attached once)
Knowing the language of a running kernel

The original plugin implementation relied on atom's Emitters to trigger events for plugin use. Implementing onDidChangeKernel and future plugin updates would have required expanding Emitter usage -- but by now hydrogen is already using mobx. So along the way I decided to get rid of one usage of Emitter in favor of hooking into mobx.
Note that I'm not familiar with all of the fancy tools like prettier and flow that have been added to the project, so no idea if this code will pass lint.

My reviewer assignment is just a mistake. reverted. sorry

I think this PR is mostly driven by the needs to implement #862 .
I still think the plugin API would be more flexible if plugins had direct access to kernel instances (instead of the current store.kernel.getPluginWrapper()).
For the same reason, I also think that it'd be more flexible if plugins could hijack a kernel. That is, I think a plugin listening to onDidCreateKernel and onDidChangeKernel (as they currently do) should be able to replace the kernel instance. In this way a plugin could wrap the original kernel instance and overwrite only the methods they want to customise (execute in the case of #862).

@n-riesco I actually hadn't thought of using object instance replacement for kernel hijacking behavior. Definitely worth considering.
Though I think it's unfair to characterize the approach here as not being general. Obviously this PR only has the pieces needed to implement #862, but that's mostly to keep the diff small/reviewable while still demonstrating the overall approach. The more general idea is to allow plugins to listen and react to various events being emitted by hydrogen, while possibly stopping event propagation to execute a custom codepath instead. The inspiration here is how event handling is done in the browser. Certainly this model has different tradeoffs to one where each plugin wraps the kernel and modifies some of its behavior.
One thing I've been thinking about over the course of this PR is how to make sure plugins interact sanely with each other (I haven't really come to a good conclusion on this yet). If multiple plugins want to go about replacing kernel behavior, they should be able to compose with each other.
For reference, here are the plugin ideas I had in mind while working on this PR:

Implement #862
Implement watches using a plugin
Implement a feature like watches, except have the watched code run just before user-requested code instead of just after
Remap executing expr? to opening the inspector for expr, for those of us with lots of muscle memory from using notebooks

(I'm not saying all of these plugins would be all that useful for real work, but it would be disappointing if the plugin API couldn't accommodate each of these being implemented by a separate and independent plugin)

Though I think it's unfair to characterize the approach here as not being general. Obviously this PR only has the pieces needed to implement #862, but that's mostly to keep the diff small/reviewable while still demonstrating the overall approach.

I understand.

The more general idea is to allow plugins to listen and react to various events being emitted by hydrogen, while possibly stopping event propagation to execute a custom codepath instead.

I'm not clear about this "stopping event propagation":

if you mean to have something like before_event, event and after_event (and give a chance to the listeners of before_event to cancel event), then this sounds ok  to me.

if you have in mind a hierarchy of plugins, then it sounds too complicated to me. Could you  think of an example that would require a hierarchy of plugins?

If multiple plugins want to go about replacing kernel behavior, they should be able to compose with each other.

This sounds ok to me, Could think of an example where this approach wouldn't work?

(I'm not saying all of these plugins would be all that useful for real work, but it would be disappointing if the plugin API couldn't accommodate each of these being implemented by a separate and independent plugin)

I think moving watches into a plugin would simplify Hydroden's code.

On a side / separate note -- I now use yapf on my Python code which obviates the need (for me) for Hydrogen to fix the indentation of my Python (part of what this PR is about).
On to this PR and status -- would you want to continue this on and/or keep it open @nikitakit?

@nikitakit @rgbkrk
I would highly appreciate an implementation to the whitespace issue #862 !
Its not about having false indentations but about testing parts of a loop/if-statement etc.

@nikitakit @rgbkrk
I would highly appreciate an implementation to the whitespace issue #862 !
Its not about having false indentations but about testing parts of a loop/if-statement etc.

An update on the status of this PR: I have a rewrite that accomplishes the same goals but exposes a different API to plugin authors. I'm going to wait for my other PR to make it through code review, and then publish the rewritten plugin API changes here.


Build: Fix Manifest for jdk.net

JAVA-4399
Simple fix - I checked all other calls to Class.forName and didn't find any others that should be removed from the manifest.

Based on the feedback, rather than not declare it, I've marked it optional. So it should work for all users now.
<EMAIL_ADDRESS>- also seems to think optional is the correct way to handle it.


test: Increase coverage publish api tests

Type: Unit test
The following has been addressed in the PR:

There is a related issue? No Issue
Unit or Functional tests are included in the PR.

Description:

Adds test for publish api endpoint

@priscilawebdev Please review again.


fix(e2e): stabilise TestNativeBinding (1.10.x)

Backport #3747

Release Note
NONE

I'll try to include this in 1.10.2

Release 1.10.2 has been cut, this will go in 1.10.3.

@oscerd Yes, it's not in a hurry. I'll see if I can improve this a bit more before merging it.

It looks like something is going wrong with Knative serving.
      dump.go:268:     > {"level":"info","ts":1666186902.059175,"logger":"camel-k","msg":"could not find any knative type in namespace test-99c98bf6-e772-43c3-aa13-db4d840f77a5, last error was: services.serving.knative.dev is forbidden: User \"system:serviceaccount:test-99c98bf6-e772-43c3-aa13-db4d840f77a5:camel-k-operator\" cannot list resource \"services\" in API group \"serving.knative.dev\" in the namespace \"test-99c98bf6-e772-43c3-aa13-db4d840f77a5\""}

It looks like something is going wrong with Knative serving.

dump.go:268:     > {"level":"info","ts":1666186902.059175,"logger":"camel-k","msg":"could not find any knative type in namespace test-99c98bf6-e772-43c3-aa13-db4d840f77a5, last error was: services.serving.knative.dev is forbidden: User "system:serviceaccount:test-99c98bf6-e772-43c3-aa13-db4d840f77a5:camel-k-operator" cannot list resource "services" in API group "serving.knative.dev" in the namespace "test-99c98bf6-e772-43c3-aa13-db4d840f77a5""}

OK, this doesn't seem to be an issue: #2397

The native-it tests keep failing, but let's try to address them with another pull req. I'm merging this one.


Logger delegate utility

Makes instantiation of loggers easier in code. E.g.
class Business {

    fun earnAMillion() {
        logger.info("Started earning a million")
    }

    companion object {
        val logger by Logger()
    }
}

Merged, will be in version 2.3.20


Node Name not used anymore

The Name of the nodes is not used anymore (I just upgraded from 1.0.2 - where it was working as expected).
Even entering a node name, in the flow the node still just show "dirigera".
Not an high priority, but this makes managing the flows much harder.

Will look into it

Fixed in version 1.0.7


r11s-driver: properly reset discovery refresh flags

Description
@zhenmichael was asking about the discoverP variable, and I noticed it wasn't being reset anywhere. Must have gotten lost in a local iteration. Everything was working for 1 resfresh, but would not refresh a second time. This ensures that we refresh as many times as needed.

Good find. Thanks Zach!


Max pods

Hi team!
This PR includes max-pods attribute on each node pool. This way you can configure the maximum number of pods per node in AWS EKS.
As this is part of the shared interface, wait for the rest of cloud installers :)
If you specify a value, it will be used, otherwise, specify null value to use the default behaviour witch in AWS is computed based on the instance type.

What about these limitations? https://github.com/awslabs/amazon-eks-ami/blob/master/files/eni-max-pods.txt
We should add this info somewhere in the docs, pointing that you cannot go over these numbers due to eni limitations

What about these limitations? https://github.com/awslabs/amazon-eks-ami/blob/master/files/eni-max-pods.txt
We should add this info somewhere in the docs, pointing that you cannot go over these numbers due to eni limitations

Yes, we should add that note in the docs. In the other side, if you deploy calico instead of the default CNI, it is worthy to modify the max_pods :) I'll add it to the docs right now. Thanks @nutellinoit !

What about these limitations? https://github.com/awslabs/amazon-eks-ami/blob/master/files/eni-max-pods.txt
We should add this info somewhere in the docs, pointing that you cannot go over these numbers due to eni limitations

Yes, we should add that note in the docs. In the other side, if you deploy calico instead of the default CNI, it is worthy to modify the max_pods :) I'll add it to the docs right now. Thanks @nutellinoit !

Done: https://docs.kubernetesfury.com/docs/installers/managed/eks/#max_pods


Rxy + ghost note inaccuracies

Just to log it, there's another bug in Rxy which I'm not planning to fix for now. If a row contains no note but an instrument with the Rxy effect, what happens is that on tick 0, the ghost note of the previous instrument plays (as per standard behavior with rows that contain instruments without notes), but on the first retrigger the instrument is changed to the new one. So actually the instrument changes mid-row.
This looks harder to implement because the logic to change instruments is not part of xm_trigger_note, but I haven't investigated into it. If you want, I can open an issue to log this.
Originally posted by @rasky in https://github.com/Artefact2/libxm/issues/20#issuecomment-822318552

Here is the test case which I think highlights what @rasky is talking about: RxxTest.zip.
Here's some audio comparisons. This is a diff of FT2Clone (Dark) and LibXM (Light):

Here's the full comparison image, which highlights that MilkyTracker and OpenMPT fail this as well:

The test case is is actually just parts taken from look & zalza - little computer boy.

Hey @Artefact2 you might be interested in my version of your code, as I have revamped it for a lot of options it was missing, such as stereo samples, brick wall limiter, some effects revised, and a few playback fixes.
It is not perfect, but you might be interested.
Cheers.

Hi @jmorel33, the licensing is not clear on your modified file so I can't merge any changes back in libxm (which is WTFPLv2) as is.
Stereo samples are not standard (and in my experience not a widely used feature) so I think it's out of scope for libxm (unless you have good examples of XMs with stereo samples).
If you could submit playback fixes as patches or pull requests (ideally with a test case), that would be much better licensing-wise. Thanks!

Yep concerning Stereo, XM tracker artists back in the 90s were really allergic to stereo samples probably to save space.  So a lot of people fanned out of the XM community to do IT mod files instead for all the other features.  That said, I used the feature for my own music and so that is why I need it and I just felt maybe someone else might also.
Concerning the bugs and other features;  I haven't change the original code too much that you can't spot my changes, but you can see what I did in the history.
For clipping, I would highly recommend to just brick wall, because pretty much every XM track clips, and there's no sense to plot an invalid out of bound value in the mixer.

Yep concerning Stereo, XM tracker artists back in the 90s were really allergic to stereo samples probably to save space. So a lot of people fanned out of the XM community to do IT mod files instead for all the other features.

FT2 and IT never officially supported stereo samples at all, so I'd hold back on writing that memoir. It was the Modplug Tracker (now OpenMPT) that added stereo support to XM, IT.

cheers.

Maybe this can help.


Scalability Capabilities

Page needs to be updated to reflect that Azure SQL Data Warehouse now supports in-memory query caching as per adaptive caching.
Supports in-memory caching of data: Yes for Azure SQL Data Warehouse

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6831bf64-b00f-b234-b16e-d1bd42ebb77b
Version Independent ID: 43bb3955-7d3a-c348-bde4-c3740e93c300
Content: Data warehousing in Microsoft Azure
Content Source: docs/data-guide/relational-data/data-warehousing.md
Service: architecture-center
Sub-service: cloud-fundamentals
GitHub Login: @MikeWasson
Microsoft Alias: pnp

Hi @jasonbruno88 - Thank you for your feedback! We have assigned this issue to the author to review further and take the right course of action.


Add URL path to client URL in in Client._parse_host()

This fix for #113 allows instantiating a client with a custom URL path as part of the host argument.

Someone please approve the PR and merge the code. 🥺

Resolves #244 as well.
I'd love to see this PR get merged.

thanks @mxyng I've added your suggestions to the pull request.


Source code generation in .NET Core

CodeDOM will be added in corefx 2.0 (it will not be a part of .NET Standard Library), so CodeDOM based serializer generator stack will be able to back in netstandard2.0 library.

This was achieved on PR #255


Patch (Dockerfile) Build from separate os and nodejs images instead o…

Build docker image from separate os and node images instead of from the combined node-os images so as to be able to select the latest/desired version of os and node, and to be able to patch them separately.

Some issues with the status checks, to fix.


Making sure IDs are loaded for all FieldLinks in a ContentType with EnsureProperties

I created a issue earlier today (https://github.com/OfficeDev/PnP-Sites-Core/issues/91) related to Content Types and Fields. I got a error when adding certain fields to a Content Type. The ID of the field was not loaded properly.
I went through and debugged the ContentType-handler and found that sometimes the fields wasn't loaded properly.
With this pull request I'm making sure IDs are loaded for all FieldLinks in a ContentType with the override EnsureProperties().

Hi @olemp, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Tried to create another PR, but https://github.com/olemp/PnP-Sites-Core/commit/de7389b36e9bbc839a58adfde9be511f8bf7b3e5 was merged into this one.

@SchauDK How do you want to make sure the properties are loaded then?

Created #99

Thanks for this. This does seem to fix the whole thing. We'll get this included during the weekend after second verification. Especially the field reference issue is causing wider headache as well, so we'll most likely push update directly to the Oct Nuget release to get this addressed immediately.
Will wait for second confirmation on the fix and we'll get things then included to avoid surprises.

Hi! Thanks for your contribution, we really appreciate your commitment. Unfortunately, this PR targets the master branch, instead of the dev branch, and I need to close it. However, thanks to your feedbacks and to PR #99, which has already been merged, we will now fix the engine in the dev branch and will release an updated Oct Nuget package as soon as possible, as stated by Vesa.

We'll absolutely ensure thought that all of the people related on this pull requests will get credits on reporting these findings and providing solution for them regardless that things were actually manually merged to dev branch.
Thank you for reporting these. Community programs absolutely need assistance from the community for ensuring that we can provide value for each other.


with function from eloquent builder does not work with callback and multiple relations

Laravel Version
11.x
PHP Version
8.2
Database Driver & Version
MySql 8
Description
/**
 * Set the relationships that should be eager loaded.
 *
 * @param  string|array  $relations
 * @param  string|\Closure|null  $callback
 * @return $this
 */
public function with($relations, $callback = null)
{
    if ($callback instanceof Closure) {
        $eagerLoad = $this->parseWithRelations([$relations => $callback]);
    } else {
        $eagerLoad = $this->parseWithRelations(is_string($relations) ? func_get_args() : $relations);
    }

    $this->eagerLoad = array_merge($this->eagerLoad, $eagerLoad);

    return $this;
}

If $relations is array and $callback is instance of closure
=> Illegal offset type
Steps To Reproduce
Call
Model::newQuery()->with(['relation1', 'relation2'], function (Relation $relation): void {})->get();

Hey there,
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to open up a new issue with a link to the original one and we'll gladly help you out.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord or InertiaJS Discord for Inertia questions
Larachat
IRC

Thanks!

I will not do that. Thank you.

This is not a bug from the functionality intention point of view but it is from the code point of view. It should throw some exception in this situation not die with php error..


Turning on LEDs

When to turn on an LED.  Green or Red?

Red:  Error.
Green:  Initialized and running.
Flash red when sending message, so that it stays on when stays in loop or there is deadlock.
Which results in
Red Only:  Fail to initialize
Red and Green: Fail to send or receive message
Green Only:  All OK.
None:  Program not started


Set up validation to reshape the input

This'll probably come up again down the line unless validation copies and reshapes the data.
In the case of the streaming detectors, it's not much additional memory. In the case of the batch detectors, the reference data needs to be a static copy whenever it's set.
The validation should probably be moved into update and set_reference in the child classes, because return values from super().* seem unintuitive.
Double-check that the concept drift detectors expecting floats/ints behave when arrays are passed

On the other hand, making copies of huge arrays is a waste except when they're being used in set_reference. Going to leave this as-is for now, unless something comes up down the line that motivates doing this copying universally.

Went through with this in #103 .


add procfile and local_server script

I like to have a script in every project called local_server that
will boot the application, not matter what stack it is on or which
services need to be initialized so that there is no ambiguity about
launching a local instance. We should also use Procfile.dev by default
since it is almost always necessary to run multiple processes and for
those who prefer running them in the same shell, this makes it trivial.

Sure thing. Though I have to admit I don't quite see the point of wrapping foreman in another script. Anyway, can you please move it to scripts/? It's something I started doing to separate my own stuff from the binstubs that Rails autogenerates.

I'm wrapping foreman because on other non-ruby projects you can still use local_server (and your alias for it) with different process managers (e.g. Nodemon for node/express apps, etc). Moving it does throw a wrinkle in my aliasing strategy though, need to stew on that

On Jun 25, 2017, at 9:14 PM, Michael Kohl<EMAIL_ADDRESS>wrote:
Sure thing. Though I have to admit I don't quite see the point of wrapping foreman in another script. Anyway, can you please move it to scripts/? It's something I started doing to separate my own stuff from the binstubs that Rails autogenerates.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

You could replace the alias with a shell function. If scripts/local_server exists it calls that, otherwise bin/local_server.
Or we just ignore my obsession with separating concerns and move scripts to bin 😉 , I'm fine with that.


Set contextIsolation: true

Fixes compatibility with Electron 12 and closes #78

Expect pr to be merged

thanks @marcoancona
published<EMAIL_ADDRESS>


Can the winfile build a copy for NT5 system?

windows 2000/xp were first not include winfile as a windows component,so I wish this project would bring it back to these old NT5 systems.

I have it running on NT5.2 (XP Pro x64), it seems like it just requires the VC redist and one language-related function removed. Haven't tested any language-switching functionality with the function removed.

by the way, blackwingcat built NT5 compatible version of latest winfile release:
https://github.com/blackwingcat/winfile_nt5

by the way, blackwingcat built NT5 compatible version of latest winfile release: https://github.com/blackwingcat/winfile_nt5

That looks to be a 2003-compatible release, not an XP-compatible release.  (XP doesn't have the Wow64 disable APIs.)
As you probably know, there's a retro branch here, but the community that advocated for it seems to have departed and I'm not sure what (if anything) to do with it.  Part of me agrees with blackwingcat that re-forking the current master, using a 2017 rather than 2019 compiler and a handful of dynamic API imports would allow this code to run back to Windows 2000 with relatively minor changes.  However, that assumes the goal is compatibility rather than visual nostalgia.  Visual nostalgia would mean removing/hiding a lot of features that have been added, but if that's the goal, there's no point forking from master, and that code should be largely frozen-in-time.

and by the way, there is an attempt to port it to win16:
https://github.com/osfree-project/WIN16/tree/master/programs/winfile

I just published a functional build that works on NT 5.1 / XP 32-bit.
https://github.com/wesinator/winfile_xp
h/t to @schinagl's work and blackwingcat build (which was partially working for Server 2003/NT 5.2)
Screenshots:

I just published a functional build that works on NT 5.1 / XP 32-bit.
https://github.com/wesinator/winfile_xp
h/t to @schinagl's work and blackwingcat build (which was partially working for Server 2003/NT 5.2)

Excellent idea to use v141_xp!
And thx for bringing UNC Support to XP ☺
Drop me an email if you want.

Now that v141_xp support is in master, can this be closed?  It does not support Windows 2000 but although the title of this issue is NT5 most of the discussion seems to be around XP.

Closing this; we can start a new issue if there's any interest in 2000 or earlier.


update the readme with additional information and recommendations on …

update master readme with 2.0 information

Looks good.


[suggestion] Trinkets Thermometer Slot

It would be useful if there's a custom trinket slot for the thermometer when the Trinkets mod is enabled, since this would allow the offhand to be used for more important things, such as totems and shields.
The thermometer, when equipped could be placed on the waist.

Yea I'll probably add this sometime. That is, if I figure out how.


[types] $fetch.onResponse(ctx)

Environment

Operating System: Linux
Node Version:     v16.14.2
Nuxt Version:     3.4.1
Nitro Version:    2.3.3
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-yn4nmm?file=plugins/test.ts
Describe the bug
When passing the ctx.options of a $fetch onResponse to another $fetch generates types incompatibility, I had this problem since 3.2 but still is not fixed:
Argument of type '{ onResponse: undefined; baseURL?: string | undefined; body?: BodyInit | Record<string, any> | null | undefined; params?: SearchParameters | undefined; ... 19 more ...; window?: null | undefined; }' is not assignable to parameter of type 'NitroFetchOptions<RequestInfo, "delete" | "get" | "post" | "head" | "patch" | "put" | "connect" | "options" | "trace">'.
  Types of property 'method' are incompatible.
    Type 'string | undefined' is not assignable to type '"delete" | "get" | "post" | "GET" | "HEAD" | "PATCH" | "POST" | "PUT" | "DELETE" | "CONNECT" | "OPTIONS" | "TRACE" | "head" | "patch" | "put" | "connect" | "options" | "trace" | undefined'.
      Type 'string' is not assignable to type '"delete" | "get" | "post" | "GET" | "HEAD" | "PATCH" | "POST" | "PUT" | "DELETE" | "CONNECT" | "OPTIONS" | "TRACE" | "head" | "patch" | "put" | "connect" | "options" | "trace" | undefined'.ts(2345)

Additional context
No response
Logs
No response

In this case you will need to type cast the options, as ctx.options doesn't inherit the specific method typing from the parent useFetch. I can look at inheriting it, but I'm not sure of the value in doing so.

In this case you will need to type cast the options, as ctx.options doesn't inherit the specific method typing from the parent useFetch. I can look at inheriting it, but I'm not sure of the value in doing so.

It doesn't work neither with $fetch as parent, as a temporal fix I'm using HTTPMethod type from h3


Remove Kia Seltos from Legacy Safety Model

Added this during the initial port thinking it was the issue as to why steering inputs were not being accepted. Turned out to be the checksum and I just never undid this commit.
It has secretly been causing issues and headaches for me, and I assume the other Seltos owners out there.

It has secretly been causing issues and headaches for me, and I assume the other Seltos owners out there.
What kind of issues? The legacy safety mode is exactly the same, except more relaxed since some HKGs are missing checksums and counters in some of the messages.

It has secretly been causing issues and headaches for me, and I assume the other Seltos owners out there.

What kind of issues? The legacy safety mode is exactly the same, except more relaxed since some HKGs are missing checksums and counters in some of the messages.

It appears to have magically solved an issue I’ve been having where the resume button will engage openpilot, but the car does not accept steering commands.
Even if it didn’t it’s probably better that it uses a more strict safety model if it can no?

Even if it didn’t it’s probably better that it uses a more strict safety model if it can no?
Yes, the stricter safety mode is better. I'd just like to ensure that the behavior between the two safety modes isn't different on your car.

Yes, the stricter safety mode is better. I'd just like to ensure that the behavior between the two safety modes isn't different on your car.

I haven’t noticed any difference, the resume issue I thought was fixed was not and still occurs intermittently.
Unrelated to this PR. Related to the resume issue. Looked at plot juggler and noticed a big output spike right at the point of engagement. Could that be triggering the car to not accept steering commands for a period of time? How long depends, sometimes it’s like 5 seconds, others it’s probably closer to 20-30s. It happens both on the legacy and current safety models if you were wondering.
I’ll open up a new issue for it soon as it’s been  boggling my mind for a while now.


Italian translation

Hi, I translated everything up to the translator credits line.
I set "0.1" as translate_version, but I don't know if it's the right value
There are strings that cannot be translated currently, so this needs some work on your side:

The status messages seem to always be in English even if I translated them, e.g:
"Wallet successfully decrypted" (Under unlock button)
"Valid address", "Invalid address" (under "Address to" field)
"Account does not exist or account balance too low" (Under "send transaction" button)
"File selected:" (under "Select your wallet file..." button)

The radio buttons under "Select the format of your private key:" don't have a matching translation string:
"JSON or Keystore File", "Plain Text Private Key" (Select format of your private key:)

Withdraw DAO:
"You are about to withdraw 0 DAO Tokens for 0 ETH. " (there is no string to translate)
"Yes. Just push the big red button. It's that easy. " (translation is ignored)

DGD Page:
Information under "DGD Crowdsale Information" has no matching translation string:
Centstotal: 0
Weitotal: 0
Share: 0
Badges: 0
Claimed? false
When clicking on "generate claim" it generates the raw and signed transactions, but then
the button reads "Generate signed transaction" instead of "send transaction"

On the footer, there are no translations for some sentences:
Created by kvhnuke and tayvano.
URLs:
Source:
Also, one might want to translate " on reddit", " on github" but maybe it's too much.

The printed wallet is always in English

The menu in the Chrome extension (the drop down that appears when clicking on the MyEtherWallet CX icon, near the top right) is always in English

Ciao,
Giulio

Wow thank you so much. I know there are a few things that don't have the tags on them yet which is why they are always in English. The error messages, chrome extension pop down, printable wallet, and some of the buttons / placeholders come to mind. I think (hope!) they all have matching strings in the translation files, they just haven't been linked back.
 Thank you for your diligence.


media: add recovery.mp3 and a readable readme for system developers

Checklist

[ ] npm test passes
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added

Doesn't seem to be used anywhere?

I'm writing :)

@legendecas See the https://github.com/yodaos-project/yoda-app-system/pull/1, it uses the new mp3.


Overwrite Outputs

At present, a stage can be forced, run, and then have none of the outputs overwritten, because of file existence checks.
These existence checks should be removed completely (and will be handled in a later PR r.e. Metamist source of truth). Logically, they don't make sense. These stages are 'forced' to run, yet do not produce new outputs.
For now, we're setting overwrite=True, so that we can finish these plots promptly!

FYI @violetbrina, the culprit!

@vivbak this works in test! 👌


Comments parsed as actual code by challenge tests

The tests on challenges parse comments as if they were actual code.
Take this challenge for example:
https://learn.freecodecamp.org/responsive-web-design/css-grid/create-a-column-gap-using-grid-column-gap
Using the following code, I can pass the test (which checks for grid-column-gap to be set to 20px), even though grid-column-gap: 20px is in a comment.

1

2

3

4

5

This was also an issue on the old version of the website. See https://github.com/freeCodeCamp/freeCodeCamp/issues/15134

This happens because you need to use /* YOUR COMMENT HERE */ syntax when adding CSS comments. CSS does not have the // COMMENT HERE syntax.

@coolshaurya Thanks for pointing that out. I forgot about that. It looks like there is no problem after all, so I will now close this issue.


Docs: Turborepo 2.0 and playwright docker container

What is the improvement or update you wish to see?
I'm just adding this here so people can find it on Google, because my Playwright docker container started failing when I tried to upgrade to turborepo 2.0.
For those who are experiencing this issue:
  1) [chromium] › login.spec.ts:6:5 › user can login with correct details ──────────────────────────

    Error: browserType.launch: Executable doesn't exist at /github/home/.cache/ms-playwright/chromium-1117/chrome-linux/chrome
    ╔═════════════════════════════════════════════════════════════════════════╗
    ║ Looks like Playwright Test or Playwright was just installed or updated. ║
    ║ Please run the following command to download new browsers:              ║
    ║                                                                         ║
    ║     pnpm exec playwright install                                        ║
    ║                                                                         ║
    ║ <3 Playwright Team                                                      ║
    ╚═════════════════════════════════════════════════════════════════════════╝

When running with a setup using the playwright docker container (in my instance, running with mcr.microsoft.com/playwright:v1.44.1-jammy), the solution was to add:
PLAYWRIGHT_BROWSERS_PATH to globalEnv in your turbo.json file.
I'm not sure this needs to be added to the docs specifically or not, but I figured making a post here would make it easier for people who are googling to find a solution to the same issue.
Is there any context that might help us understand?
I'm just adding the above to make this issue googleable. If this isn't the right place, please let me know and I'll move it.
Does the docs page already exist? Please link to it.
No response

Quick note: globalEnv will cause cache misses for all tasks when PLAYWRIGHT_BROWSERS_PATH changes. You might want to use the task's env or passThroughEnv instead.

@anthonyshew ah, thanks for that, I'll update my own setup accordingly :)

@citypaul @anthonyshew Just ran into this and was able to fix this pretty quickly thanks to your posts here. For anyone else, all I had to do was add the PLAYWRIGHT_BROWSERS_PATH to the env of the task, just like @anthonyshew said.
    "test:playwright": {
      "dependsOn": ["build"],
      "env": ["PLAYWRIGHT_BROWSERS_PATH"]
    }

Thank you!!

There's a Playwright doc that still needs to be written that will include this information

Any word on when this will be released.?

I spent 4 hours this morning trying to solve this problem. Fortunately, after a long (erroneous) search, I came upon this post! I searched for issues at playwright and docker, but didn't realize that this issue was related to a turbo update....
Thank you so much!


updates boilerplate for new base image to patch CVE's

updates boilerplate to use latest ubi-minimal as current one has CVE's

Codecov Report

Merging #208 (cf556be) into main (618bc5a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   38.91%   38.91%
=======================================
  Files          31       31
  Lines        1971     1971
=======================================
  Hits          767      767
  Misses       1113     1113
  Partials       91       91


 Done

APT update complete.

Checking for installed dependencies...

Package git found.
Package llvm-4.0 found.
Package clang-4.0 found.
Package libclang-4.0-dev found.
Package make found.
Package automake found.
Package libbz2-dev found.
Package libssl-dev found.
Package doxygen found.
Package graphviz found.
Package libgmp3-dev found.
Package autotools-dev found.
Package build-essential found.
Package libicu-dev found.
Package python2.7 found.
Package python2.7-dev found.
Package python3 found.
Package python3-dev found.
Package autoconf found.
Package libtool found.
Package curl found.
Package zlib1g-dev found.
Package sudo found.
Package ruby found.
Package libusb-1.0-0-dev found.
Package libcurl4-gnutls-dev found.
Package pkg-config found.
No required APT dependencies to install.
Checking CMAKE installation...
CMAKE found @ /usr/bin/cmake.

Checking Boost library (1_67_0) installation...

Boost library found with correct version @ /home/ubuntu/src/boost_1_67_0 (Symlinked to /home/ubuntu/opt/boost).

Checking MongoDB installation...

MongoDB found with correct version @ /home/ubuntu/opt/mongodb-3.6.3 (Symlinked to /home/ubuntu/opt/mongodb).
Checking MongoDB C driver installation...
MongoDB C driver found with correct version @ /home/ubuntu/src/mongo-c-driver-1.13.0.
Checking MongoDB C++ driver installation...
MongoDB C++ driver found with correct version @ /home/ubuntu/src/mongo-cxx-driver-r3.4.0.

Checking LLVM 4 support...

LLVM found @ /home/ubuntu/opt/llvm.

========================================================================
======================= Starting EOSIO Build =======================
CMAKE_BUILD_TYPE=Release
ENABLE_COVERAGE_TESTING=false
-- Using custom FindBoost.cmake
CMake Error at libraries/fc/CMakeModules/FindBoost.cmake:1129 (message):
Unable to find the requested Boost libraries.
Boost version: 1.58.0
Boost include path: /usr/include
Detected version of Boost is too old.  Requested version was 1.67 (or
newer).
Call Stack (most recent call first):
CMakeLists.txt:105 (FIND_PACKAGE)
-- Configuring EOSIO on Linux
-- Using 'EOS' as CORE symbol name
-- Using 'EOS6MRyAjQq8ud7hVNYcfnVPJqcVpscN5So8BhtHuGYqET5GDW5CV' as public key for 'eosio' account
-- Configuring fc to build on Unix/Apple
-- zlib found
-- Configuring Builtins
-- Configuring SoftFloat
-- Using custom FindBoost.cmake
-- Boost version: 1.58.0
-- Found the following Boost libraries:
--   date_time
--   filesystem
--   system
--   chrono
--   unit_test_framework
-- Configuring ChainBase on Linux
-- Using custom FindBoost.cmake
CMake Error at libraries/fc/CMakeModules/FindBoost.cmake:1129 (message):
Unable to find the requested Boost libraries.
Boost version: 1.58.0
Boost include path: /usr/include
Detected version of Boost is too old.  Requested version was 1.60 (or
newer).
Call Stack (most recent call first):
libraries/appbase/CMakeLists.txt:20 (find_package)
-- Configuring AppBase on Linux
-- Using prebuilt re2c lexer
-- Starting yubihsm configuration...

See also "/home/eos/build/CMakeFiles/CMakeOutput.log".
See also "/home/eos/build/CMakeFiles/CMakeError.log".
ubuntu@ip-172-26-11-104:/home/eos$ sudo ./scripts/eosio_install.sh
make: *** No rule to make target 'install'.  Stop.
MAKE installing EOSIO has exited with the above error.
what should i do to resolve such this error..................!!!

you need to have boost version 1.67

@taokayan i have boost version 1.67 but still i'm facing same issue.

If you're not using boost 1.58 for anything else, the easiest fix for this problem is to uninstall the boost development packages for 1.58.  Use sudeo apt remove '^libboost.*1\.58.*-dev'.

@jgiszczak sir, but now i'm facing this issue-
-- Starting yubihsm configuration...
Install targets
Libraries /home/ubuntu/opt/eosio/lib
Includes /home/ubuntu/opt/eosio/include
Binaries /home/ubuntu/opt/eosio/bin
Manuals /home/ubuntu/opt/eosio/share/man
Pkg-config /home/ubuntu/opt/eosio/share/pkgconfig
not win32
-- Looking for memset_s
-- Looking for memset_s - not found
-- Looking for explicit_bzero
-- Looking for explicit_bzero - not found
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")
-- Checking for one of the modules 'libcrypto'
-- Checking for one of the modules 'libcurl'
-- Checking for one of the modules 'libusb-1.0'
-- yubihsm configuration complete
-- Found bsoncxx headers: /home/ubuntu/include/bsoncxx/v_noabi
-- Found bsoncxx library: /home/ubuntu/lib/libbsoncxx-static.a;/home/ubuntu/lib/libbson-static-1.0.a;-lc;/usr/lib/x86_64-linux-gnu/librt.so;/usr/lib/x86_64-linux-gnu/libm.so;-pthread
-- Found mongocxx headers: /home/ubuntu/include/mongocxx/v_noabi;/home/ubuntu/include/bsoncxx/v_noabi
-- Found mongocxx library: /home/ubuntu/lib/libmongocxx-static.a;/home/ubuntu/lib/libbsoncxx-static.a;/home/ubuntu/lib/libbson-static-1.0.a;-lc;/usr/lib/x86_64-linux-gnu/librt.so;/usr/lib/x86_64-linux-gnu/libm.so;-pthread;/home/ubuntu/lib/libmongoc-static-1.0.a;/home/ubuntu/lib/libbson-static-1.0.a;-lc;/usr/lib/x86_64-linux-gnu/librt.so;/usr/lib/x86_64-linux-gnu/libm.so;-pthread;/usr/lib/x86_64-linux-gnu/libssl.so;/usr/lib/x86_64-linux-gnu/libcrypto.so;rt;/usr/lib/x86_64-linux-gnu/libz.so;resolv
-- Git commit revision: 448287d5
-- Git commit revision: 448287d5
-- Found Intl: /usr/include
-- Git commit revision: 448287d5
-- Not building contracts in directory eos/unittests/test-contracts/
-- Found Doxygen: /usr/bin/doxygen (found version "1.8.11")
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
/home/EOSIO/eos/libraries/appbase/Boost_INCLUDE_DIR
used as include directory in directory /home/EOSIO/eos/libraries/appbase
/home/EOSIO/eos/libraries/chainbase/Boost_INCLUDE_DIR
used as include directory in directory /home/EOSIO/eos/libraries/chainbase
/home/EOSIO/eos/libraries/fc/Boost_INCLUDE_DIR
used as include directory in directory /home/EOSIO/eos/libraries/fc
-- Configuring incomplete, errors occurred!
See also "/home/EOSIO/eos/build/CMakeFiles/CMakeOutput.log".
See also "/home/EOSIO/eos/build/CMakeFiles/CMakeError.log".

What version of eosio are you trying to build?

@heifner  i am using mainnet-1.6.0

Have you tried building 1.8? Is the issue resolved?

No response from submitter in nearly a month. Closing this as report was against 1.6. If problems persist on 1.8 please file a new report.


Disable animations for step and button

Hi, is it possible to disable animation for step and button? I've tried to pass null in the @Component attribute "animations" but I've got some error on browser console.
Thank you,
Davide.

Hi, in this component the animations also controls when the step is showing or not, so in order to have no animations when change of step you need create an animations too , like this:
static none = [
        trigger('WizardAnimations', [
            state('enter', style({ position: 'relative', top: 0 ,width:'100%'})),
            state('leave', style({ display: 'none', position: 'relative', top: 0 }))
        ])
    ];

you can insert the above code in the file ion-simple-wizard-animations.ts and in the file ion-simple-wizard.step.component.ts change the animation to none, like this:  animations: WizardAnimations.none and it's the same for the button , create a new state in the animations file :
 static btn_none = [
        trigger('btnState', [
            state('enter', style({ position: 'relative', top: 0 ,width:'100%'})),
            state('leave', style({ display: 'none', position: 'relative', top: 0 }))
        ])
    ];

and in the file ion-simple-wizard.component.ts change the animation to this animations: WizardAnimations.btn_none
Greetings

Thank you :)


Is there a way to allow only certain types of requests to upstream URLs

I'd like to block based on GET, PUT, DELETE, POST
Is this supported?

Hi @raravena80, I'm unsure if oauth2_proxy natively supports this, but you could always try using the nginx auth_request directive as described here, and then restricting the HTTP method using nginx as described here.
If you're looking for email specific blocking, then you could check against the "$email" variable that's set after the auth_request succeeds (The auth_request_set directive that does this is described here, search for "auth_request_set" on the page).
However, the above method might be a little clunky depending on how many emails you wish to check against.
Hope this helps!


Support rollback for edit of view

Now, when the cross is pressed, the view is not rolled back.
Also saving of state will help us not to submit a Vulnerability, when it is not changed

Creating a new version as a suggestion instead of applying changes resolves this issue

@DrAlexD covered it already. @DrAlexD please link a PR here.

Done in #2740


sched/signal: There is no need to use sched_[un]lock

purpose:
1 sched_lock is very time-consuming, and reducing its invocations can improve performance. 2 sched_lock is prone to misuse, and narrowing its scope of use is to prevent people from referencing incorrect code and using it
test:
We can use qemu for testing.
compiling
make distclean -j20; ./tools/configure.sh -l qemu-armv8a:nsh_smp ;make -j20 running
qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic -machine virt,virtualization=on,gic-version=3 -net none -chardev stdio,id=con,mux=on -serial chardev:con -mon chardev=con,mode=readline -kernel ./nuttx
We have also tested this patch on other ARM hardware platforms.

@hujun260 some ltp test case fail: https://github.com/apache/nuttx/actions/runs/8949322132/job/24583521866?pr=12283

@hujun260 please take a look at @anchao comments

@hujun260 please take a look at @anchao comments

I update the patch


Add horizontal scale on mobile

Resolves #5
Also:

Remove invalid and unnecessary CSS-proprieties
Fix "hacs.json" file

@OperKH Thanks for this - not had chance to look at this in a while.


feat(storybook): Add getting started page

Resolves #1699
Get started page has the same text as our root readme, but in norwegian.
Removed all <Information />, except the ones telling the user about deprecation.

Suggest also removing all the occurrences of this line in the examples under "Bruk"
import '@digdir/designsystemet-theme'; // Importeres kun en gang i appen din.

Suggest also removing all the occurrences of this line in the examples under "Bruk"
import '@digdir/designsystemet-theme'; // Importeres kun en gang i appen din.

Removed in latest commit 😄


use of tika parser with multiprocessing

I was wondering if tika can be used with multiprocessing (in my case to scale up pdf text extraction)?  Would this involve starting multiple jvms explicitly?  I'd be interested in adding this functionality given some guidance.  Thanks.

I have 6 workers in my multiprocessing pool:
(env1) ubuntu@ip-172-31-31-94:~$ sudo lsof -n -i :9998
COMMAND   PID   USER   FD   TYPE  DEVICE SIZE/OFF NODE NAME
java    25545 ubuntu   19u  IPv6 2011453      0t0  TCP <IP_ADDRESS>:9998 (LISTEN)
java    25545 ubuntu   40u  IPv6 2043175      0t0  TCP <IP_ADDRESS>:9998-><IP_ADDRESS>:53224 (ESTABLISHED)
java    25545 ubuntu   63u  IPv6 2043156      0t0  TCP <IP_ADDRESS>:9998-><IP_ADDRESS>:53204 (ESTABLISHED)
java    25545 ubuntu  137u  IPv6 2043144      0t0  TCP <IP_ADDRESS>:9998-><IP_ADDRESS>:53192 (ESTABLISHED)
java    25545 ubuntu  152u  IPv6 2043168      0t0  TCP <IP_ADDRESS>:9998-><IP_ADDRESS>:53216 (ESTABLISHED)
java    25545 ubuntu  155u  IPv6 2043202      0t0  TCP <IP_ADDRESS>:9998-><IP_ADDRESS>:53232 (ESTABLISHED)
java    25545 ubuntu  158u  IPv6 2043159      0t0  TCP <IP_ADDRESS>:9998-><IP_ADDRESS>:53208 (ESTABLISHED)
python  27693 ubuntu   20u  IPv4 2043155      0t0  TCP <IP_ADDRESS>:53204-><IP_ADDRESS>:9998 (ESTABLISHED)
python  27694 ubuntu   20u  IPv4 2043189      0t0  TCP <IP_ADDRESS>:53232-><IP_ADDRESS>:9998 (ESTABLISHED)
python  27695 ubuntu   20u  IPv4 2043176      0t0  TCP <IP_ADDRESS>:53224-><IP_ADDRESS>:9998 (ESTABLISHED)
python  27696 ubuntu   20u  IPv4 2043160      0t0  TCP <IP_ADDRESS>:53208-><IP_ADDRESS>:9998 (ESTABLISHED)
python  27697 ubuntu   20u  IPv4 2043143      0t0  TCP <IP_ADDRESS>:53192-><IP_ADDRESS>:9998 (ESTABLISHED)
python  27698 ubuntu   20u  IPv4 2043167      0t0  TCP <IP_ADDRESS>:53216-><IP_ADDRESS>:9998 (ESTABLISHED)

It looks like each worker boots its own jvm (tika server), but they need to have  unique endpoints.  I'll see if I can iterate an initialization routine for the workers.

this is great! If you get this working please contribute back. Each worker booting its own JVM is fine, up to a point. A common practice...

if you get time for a PR please contribute it back.

@chrismattmann - currently, I looking for mutiprocessing. Is this implemented with current release?


Fix json malformed for link(str, str) equations

Replace quotes before build the json by escaped quotes.

References
https://stackoverflow.com/questions/2896600/how-to-replace-all-occurrences-of-a-character-in-string

Smoke Test

Before
After

https://user-images.githubusercontent.com/14595398/128889576-f71a48c2-4eff-4828-ac9a-42f2d5ad7f13.mp4
https://user-images.githubusercontent.com/14595398/128891085-a7ae0988-9570-4d37-a424-216c06721fe7.mp4


Keyboard layout issue (again)

Hi. Last time we fixing issue with keyboard height for iPhone Max models. But today I found one more issue:
Tested on iPhone 14 pro.

second and third row items is on 1 point shifted to the right when compared to standard keyboards.

U can look this on screenshot.

Also I found that in standard keyboard on PRO max models Q W E buttons has different width.

Nice finds @krizhanovskii!
Just so you know, my ambition with the KeyboardKit keyboards has always been to generate keyboards that feel at home on various devices. I've however never aimed for pixel perfection, since that's a huge task considering all the supported locales and device types.
If you however want to create PRs that make the keys closer to their native counterparts, I'd naturally love to take a look at them :)

I can try, but where I should start?) can't find start point where this sizes and insets setups)

I believe you found the height parts before, right? Where you have device-specific configurations.
For layout, it's a bit different. There, you have iPhone and iPad-specific layout provider that returns the key sizes of an English keyboard. The keyboard calculates a width for the input keys based on the entire layout, so that the key size reflects the largest number available.
The iPhone layout provider bases its item sizes on a regular phone, so if a larger device tweaks the relations between keys, the result will look a bit different.
All of this is quite complicated, since it must be a dynamic way that works across locales and layout differences. But perhaps you can see some item type that can be tweaked to make the keys closer to what they should be?

yea, I tried adding left and right inserts for max models but nothing changed. I think it's a lot of work to make it pixel perfect for all devices and all locales, but at least for an English keyboard it should be done.
In our analytics tools we see that most of the users were using the max models and we have some support emails from users where they report that the keyboard is broken and they always make mistakes)

Do you really think the few points difference is what's causing the users to make a lot of mistakes? I think that sounds strange. I believe the problem lies elsewhere, in two recently solved issues.
You're right that the keyboard has had problems with typing before, where keys would get lost and the cursor sometimes moved unexpectedly. I have addressed these problems in just the last two versions, released two weeks and five days ago.
7.7.0 (to me and other developers) drastically improves the typing experience by adding a fix for release outside. Before, the keys didn't trigger if they were released outside the button bound, but now they have a tolerance which reduces the amount of "lost" keys.
7.7.1 fixes a bug where the space input move drag gesture started immediately, which caused the cursor to sometimes move when you were typing a space fast and sliding with your finger.
Since these two versions makes the typing experience a lot better, my suggestion would be to upgrade to the latest version and see if the typing issues disappear for your users. 👍

It can be one of the reason. And I believe that the main reason that's custom keyboards is made more mistakes if compare with default -> its that apple don't gave for us API with standard predictions and autocompletions.
Im always use latest versions.
I played around and created some monkey code. Now the pro max keyboard looks more similar to the standard one.
I Added padding and change size for some keys. Results on screenshot.
Mb u can look and when u got time make it more nice and stable.

final class EnglishProMaxKeyboardLayout {
    static func get(for layout: KeyboardLayout) -> KeyboardLayout {
        var rows = layout.itemRows
        var row_1 = layout.itemRows[0]
        var row_2 = layout.itemRows[1]
        var row_3 = layout.itemRows[2]
        var row_4 = layout.itemRows[3]

        let next = row_1[0]

        for i in 0..<row_1.count {
            switch row_1[i].action {
            case .character("Q"), .character("q"):
                row_1[i].insets = EdgeInsets(top: next.insets.top, leading: next.insets.leading + 1, bottom: next.insets.bottom, trailing: next.insets.trailing)
                row_1[i].size = .init(width: .points(44.3), height: next.size.height)
            case .character("P"), .character("p"):
                row_1[i].insets = EdgeInsets(top: next.insets.top, leading: next.insets.leading, bottom: next.insets.bottom, trailing: next.insets.trailing + 1)
            default:
                break
            }
        }

        for j in 0..<row_2.count {
            switch row_2[j].action {
            case .character("A"), .character("a"):
                row_2[j].insets = EdgeInsets(top: next.insets.top, leading: next.insets.leading + 2, bottom: next.insets.bottom, trailing: next.insets.trailing)
                row_2[j].size = .init(width: .points(45.3), height: next.size.height)
            case .character("L"), .character("l"):
                row_2[j].insets = EdgeInsets(top: next.insets.top, leading: next.insets.leading, bottom: next.insets.bottom, trailing: next.insets.trailing + 2)
                row_2[j].size = .init(width: .points(44.3), height: next.size.height)
            case .character("S"), .character("s"):
                row_2[j].insets = EdgeInsets(top: next.insets.top, leading: next.insets.leading + 1.3, bottom: next.insets.bottom, trailing: next.insets.trailing)

            default:
                break
            }
        }

        for k in 0..<row_3.count {
            switch row_3[k].action {
            case .shift:
                row_3[k].insets = EdgeInsets(top: next.insets.top, leading: next.insets.leading + 1, bottom: next.insets.bottom, trailing: next.insets.trailing)
            case .character("Z"), .character("z"):
                row_3[k].insets = EdgeInsets(top: next.insets.top, leading: next.insets.leading + 1.5, bottom: next.insets.bottom, trailing: next.insets.trailing)
            default:
                break
            }
        }

        row_4[0].insets = EdgeInsets(top: next.insets.top, leading: next.insets.leading + 1, bottom: next.insets.bottom, trailing: next.insets.trailing + 1)
        row_4[row_4.count - 1] .insets = EdgeInsets(top: next.insets.top, leading: next.insets.leading, bottom: next.insets.bottom, trailing: next.insets.trailing + 1)

        rows[0] = row_1
        rows[1] = row_2
        rows[2] = row_3
        rows[3] = row_4

        layout.itemRows = rows
        return layout
    }
}

Ok, nice. Does it look good on other device types as well?

I use this code only for Max Pro, so it doesn't affect other devices :)


Polygon2D animations fail to interpolate between AnimationNodeStateMachine animation nodes.

Godot version
4.0
System information
Windows 10
Issue description
Creating an animation track for a Polygon2D node's polygon property and setting that track's Update Mode to "Continuous" (so that I can smoothly interpolate between polygon vertex positions) does not work when transitioning between those animations inside a AnimationNodeStateMachine.

The triangle should smoothly transition between the two animation states (as it did in 3.5) but instead does nothing at all.
Steps to reproduce

create a Polygon2D and an AnimationPlayer.
in the AnimationPlayer create two animations, each having a Polygon2d polygon property keyframe where the Polygon2d has its points at different positions.
set the animation tracks' Update Mode to "Continuous" in each of the animations.
create an AnimationTree node and connect it to the AnimationPlayer
in the AnimationTree node, with AnimationNodeStateMachine, create two animation nodes per the two animations. create a transition between them with an xfade_time of 0.5.
activate the animationtree and test the transition between the two animations.

Minimal reproduction project
N/A

Dupe of #73342


add threat engine

Describe what problem your feature request solves
It would be good to have the Threat Engine available when adding threats
Describe the solution you'd like
The threat engine needs to be ported over from version 1.6.x, and will provide Threats by Context and Threats by Type
Additional context

I will take this one on for now

Pull request #498 provides the threat engine according to Type / Element. Closing this issue and raising another one for OWASP Automated Threats by property


Not iterable error in optional lists constrained by unique items

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
unique_items validation breaks optional lists when None is passed as a value.
Example Code
from typing import Any, Optional
from pydantic import BaseModel, conlist

class Model(BaseModel):
    prop: Optional[conlist(Any, unique_items=True)]

m = Model(prop=None)

#> pydantic.error_wrappers.ValidationError: 1 validation error for Model
#> prop
#>   'NoneType' object is not iterable (type=type_error)

Python, Pydantic & OS Version
pydantic version: 2.0.0.dev0
install path: C:\repos_me\ppp\pydantic\pydantic
python version: 3.9.8 (tags/v3.9.8:bb3fdcf, Nov  5 2021, 20:48:33) [MSC v.1929 64 bit (AMD64)]
platform: Windows-10-10.0.19044
optional deps. installed: ['email-validator', 'typing-extensions']

Affected Components

[ ] Compatibility between releases
[X] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[X] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Fixed by #4568


Remove Trainer._device_type

What does this PR do?
Part of https://github.com/PyTorchLightning/pytorch-lightning/issues/11449
Does your PR introduce any breaking changes? If yes, please list them.
Removes the protected _device_type.
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

We have a logging issue right now on master.
GPU available: False, used: False
TPU available: True, using: 8 TPU cores
IPU available: False, using: 0 IPUs
/usr/local/lib/python3.8/dist-packages/pytorch_lightning-1.6.0.dev0-py3.8.egg/pytorch_lightning/trainer/trainer.py:1737: UserWarning: TPU available but not used. Set the `tpu_cores` flag in your trainer `Trainer(tpu_cores=8)` or script `--tpu_cores=8`.

This PR should resolve it.


Update Composer dependencies (2020-01-05-00-11)

Visual regression test passed!
View the visual regression test report


Issue with New-HTML : The file 'NUglify.resources' could not be found.

Hi Klyss,
I have a strange issue using New-HTML and I think I have found the cause.
More info in the transcript file : transcript.txt.
I have also add PSWriteHTML and PSParseHTML version in the transcript.
As you can see, I'm using the -Minify parameter with New-HTML. and I have an error, but If i disable this parameter, my function using New-HTML runs fine.
Hope this help you and happy new year
Regards

You need to install PSParseHTML for -Minify or -Format to work.

PSParseHTML is installed (see transcript) in the last version.

What versio of net framework you have installed? To me it seems like someting didn't load. Either files are missing, or old net framework.

PowerShellVersion    : 5.1.22621.4391
NetFrameworkVersions : v2.0.50727; Version=2.0.50727.4927
v3.0; Version=3.0.30729.4926
Windows Communication Foundation; Version=3.0.4506.4926
Windows Presentation Foundation; Version=3.0.6920.4902
DotNetCoreVersions   : Microsoft.AspNetCore.App; Version=7.0.20
Microsoft.AspNetCore.App; Version=9.0.0}
Microsoft.NETCore.App; Version=6.0.36
Microsoft.NETCore.App; Version=7.0.20
LatestNetFramework   : 4.8.09032
LatestDotNetCore     : 9.0.0
As you can see, .NET framework is on the latest version.
If it helps, I'll send you the full code I'm using in attachment. This is an advanced feature I built.
Get-EOL-V3.ps1.txt
I can also provide the exact command line I'm using.
Get-EOL -ProductName windows-server -Export -Verbose
My observations : I use the function in 2 ways: The first with in $PSDefaultParameterValues (see line 230 and following), New-HTML:Minify'= $false, and the second way 'New-HTML:Minify'= $true
The problem only occurs when Minify = $true.
In both cases, I ran in Verbose mode and I have this line
"COMMENTS: Unable to verify version of Microsoft .NET Framework 4.7.2 because it is not in the list of allowed versions."
With Minify = $true, an fatal error occured.
Get-EOL : Failed to generate report: Exception calling "Html" with "2" argument(s): "The file 'NUglify.resources' could not be found."
At character Line:1 : 1

Get-EOL -ProductName windows-server -Export -Verbose

CategoryInfo : NotSpecified: (:) [Write-Error], WriteErrorException
FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Get-EOL

Hope this help

It's a problem on PSParseHTML, for some reason it doesn't work for you. Nothing to do with PSWriteHTML. You can try reinstalling it, and listing/checking files it has. Maybe try PS 7?


Add support for unions

Unions are currently not implemented.

The new type system does not support unions.