T014 - Binding site detection

Details

Talktorial ID: T014
Title: Binding site detection
Original authors: @AndreaVolkamer
Reviewer(s): @dominiquesydow
Date of review: 15.12.2020

Content review

Potential labels or categories (e.g. machine learning, small molecules, online APIs): XXXXXXXX
One line summary: XXXXXXXXXX
[x] The table of contents reflects the talktorial story-line; order of #, ##, ### headers is correct
[x] URLs are linked with meaningful words, instead of pasting the URL directly or linking words like here.
[x] I have spell-checked the notebook
[x] Images have enough resolution to be rendered with quality, without being too heavy.
[x] All figures have a description
[x] Markdown cell content is still in-line with code cell output (whenever results are discussed)
[x] I have checked that cell outputs are not incredibly long (this applies also to DataFrames)
[ ] Formatting looks correctly on the Sphinx render (bold, italics, figure placing)

Code review

Time it took to execute (approx.):
[x] Variable and function names follow snake case rules (e.g. a_variable_name vs aVariableName)
[ ] Spacing follows PEP8 (run Black on the code cells if needed)
[ ] Code line are under 99 characters each (run black -l 99)
[x] Comments are useful and well placed
[x] There are no unpythonic idioms like for i in range(len(list)) (see slides)
[x] All 3rd party dependencies are listed at the top of the notebook
[x] I have marked all code cell with output referenced in markdown cells with the label # NBVAL_CHECK_OUTPUT
[x] I have identified potential candidates for a code refactor / useful functions
[x] All import ... lines are at the top (practice part) cell, ordered by standard library / 3rd party packages / our own (teachopencadd.*)
[x] I have update the relative paths to absolute paths.
List here unfamiliar libraries you find in the imports and their intended use:

Cannot add myself as reviewer because I opened the PR - assigned myself instead here.
The code for retrieving KLIFS pocket residues from a PDB ID is as short as:
from opencadd.databases.klifs import setup_remote
session = setup_remote()
# Get first structure KLIFS ID associated with PDB ID
structures = session.structures.by_structure_pdb_id("3w32")
structure_klifs_id = structures["structure.klifs_id"].iloc[0]
# Get the structure's pocket
pocket = session.pockets.by_structure_klifs_id(structure_klifs_id)

:)

@dominiquesydow the notebook is ready for review.
Note I still have the problem that the ccp4 file does not show in nglviewer.

Great notebook! :) The theory part is clear and on-point - and I think the DoGSiteScorer/KLIFS combo is a nice scope for this binding site detection topic.
I left my ReviewNB review already but will go over the nglview/cloud question and the mentioned biopandas point tomorrow.

@dominiquesydow Thanks for your review, I addressed all comments.
Thanks also for offering to look into the ccp4 visualization as well as the suggested code simplification.

@AndreaVolkamer, great - thanks for the super fast update. Addressed all open tasks on my side. Waiting for your feedback on the unresolved comments above before I push the changes.

@jaimergp, I thought I understood how to solve the environment conflict but apparently I did not :) When you take a look at this, could you please ping me so that I can learn how to do this?

@dominiquesydow thanks for your help. I addressed the remaining open comments above.

@AndreaVolkamer this is ready from my side (note: I did not check the sphinx rendering).

@dominiquesydow and @jaimergp added last changes to render properly in the web site.
Few comments on that, maybe you might be able to fix/answer

For whatever reason on the website T014 appears in the list as T015?
The nglviewer rendered images do not show on the website?
viewer._display_image()
only prints this text:  ../_images/talktorials_T014_binding_site_detection_70_0.png
during make html a few errors/warnings are reported, but I think they refer to other notebooks?

AttributeError: module 'teachopencadd.utils' has no attribute 'pdbqt_to_pdbblock'
AttributeError: module 'teachopencadd.utils' has no attribute 'show_pdf'

Content-wise the notebook is ready to be merged.

And just a side comment: The ccp4 volumes still don't show on my laptop neither in jupyter notebook nor lab?

The ccp4 volumes still don't show on my laptop neither in jupyter notebook nor lab?

Can you print your versions for nglview, jupyterlab and ipywidgets in your teachopencadd environment? @AndreaVolkamer @dominiquesydow
conda list | grep -E "nglview|jupyterlab|ipywidgets"

here you go
ipywidgets                7.5.1              pyh9f0ad1d_1    conda-forge
jupyterlab                2.2.8                      py_0    conda-forge
jupyterlab_pygments       0.1.1              pyh9f0ad1d_0    conda-forge
jupyterlab_server         1.2.0                      py_0    conda-forge
nglview                   2.7.7              pyh5ca1d4c_1    conda-forge

In Jupyter Notebook the volume shows, in Jupyter Lab not.
ipywidgets                7.6.3              pyhd3deb0d_0    conda-forge
jupyterlab                2.2.9              pyhd8ed1ab_0    conda-forge
jupyterlab_pygments       0.1.2              pyh9f0ad1d_0    conda-forge
jupyterlab_server         1.2.0                      py_0    conda-forge
jupyterlab_widgets        1.0.0              pyhd8ed1ab_1    conda-forge
nglview                   2.7.7              pyh5ca1d4c_1    conda-forge

I am skeptical about ipywidgets. Can you update your environment @AndreaVolkamer? conda update --all should do 🤞

@jaimergp I did update the versions to the same as @dominiquesydow but still the volumes don't show.
Could you check if it works for your?

Investigating (later)!

So this is a known issue: https://github.com/nglviewer/nglview/issues/929
With the following workaround that no longer works: https://github.com/nglviewer/nglview/issues/783#issuecomment-484434701

The problem was:

If passed a local file, NGLView needs to "download" the files from the corresponding Jupyter server URL (http://<IP_ADDRESS>:8888/files/this/is/now/a/local/path/to/file.txt)
Jupyter Lab and Jupyter notebook have different ways of building this URL.
The one encoded in NGLView used to work for both, but I guess Jupyter Lab updated something and that does not work now.

Our workaround, since we are downloading a file with requests (and that results in a r.content byte-array), we can skip the file path / download URL issue and work with a memory file (io.BytesIO in this case, because it's bytes, not text). A little issue is that the "file" is gzipped, so we need to decompress that in memory. Then we wrap that in the file like object and pass it to NGLView saying that's a CCP4 map. Since there are no files or paths involved, this works reliably on both Jupyter UIs.
Fun one!

Thank you, @jaimergp!

@jaimergp, this branch is ready to be merged from @AndreaVolkamer's and my side (your workaround looks super nice and clean, thanks!) - do you want to do the merge when everything is ok from your side as well?

It's customary that the PR author goes ahead and pulls the trigger! @AndreaVolkamer, proceed!


fix ASAN in cache test

cache was trying to access c, k1, k2 after they had already been destructed.

I wasn't able to get ASAN running on my machine, so I'll ask swift-ci to check if this actually fixes things.
@swift-ci please test asan

@swift-ci please test asan

@swift-ci Please ASAN test

@swift-ci please smoke test


loopCfg ignored when controlPoints set to true

G6 Version: 3.4.0
Platform: OSX, Google Chrome 80
Screenshots:

controlPoints: false

controlPoints: true

Code Sandbox Links:
controlPoints: false
https://codesandbox.io/s/trusting-wave-nvcpk
controlPoints: true
https://codesandbox.io/s/prod-lake-lihdh

Hi everyone,
First thanks for providing this awesome graph visualization library.
We are currently experiencing issues with the combination of the dagre layout with loops. When we set controlPoints: true, all edges between the nodes are properly rendered. However, the loopCfg is completely ignored. In our case the loops are even rendered in a place, where they are hidden by other edges, that's why we would like to change the position.
If we set controlPoints: false, the loops are rendered properly, but the rest breaks. You can also see that in the screenshots or the code sandbox links. The loopCfg is in both cases as below (loop to the left), but controlPoints is either set to true or false.
loopCfg: {
  position: "left",
  dist: 75,
  clockwise: true
}

Thanks for the quick bug fix. Now the loopCfg works properly :)


HDDS-1662.Missing test resources of integrataion-test project in targ…

https://issues.apache.org/jira/browse/HDDS-1662

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
523
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
539
trunk passed

+1
compile
290
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1632
branch has no errors when building and testing our client artifacts.

+1
javadoc
163
trunk passed

_ Patch Compile Tests _

+1
mvninstall
454
the patch passed

+1
compile
296
the patch passed

+1
javac
296
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
2
The patch has no ill-formed XML file.

+1
shadedclient
679
patch has no errors when building and testing our client artifacts.

+1
javadoc
157
the patch passed

_ Other Tests _

-1
unit
136
hadoop-hdds in the patch failed.

-1
unit
1220
hadoop-ozone in the patch failed.

+1
asflicense
55
The patch does not generate ASF License warnings.

5521

Reason
Tests

Failed junit tests
hadoop.ozone.container.common.impl.TestHddsDispatcher

hadoop.ozone.TestMiniOzoneCluster

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-933/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/933

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml

uname
Linux 4f1455e21b77 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / fcfe7a3

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-933/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-933/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-933/1/testReport/

Max. process+thread count
4888 (vs. ulimit of 5500)

modules
C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-933/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

The failed UTs are irrelevant.

+1 pending CI.

@elek , thanks for the approve. Without reference the ${basedir}/../../hadoop-hdds/common/src/main/resources, many unit tests will pass in IDE, but fail with "mvn test -Dtest=testClass". The root cause is  Thread.currentThread().getContextClassLoader().getResource("filename").toURI() will not return a normal URI  if the specified file is packaged in a jar file.

Thanks the information @ChenSammi
In the mean time I found that the smoketest are also failed because a similar problem: scm can't be started as the default network topology file can't be loaded from the classpath.
I think it can be fixed with using the classloader.getResourceAsStream instead of classloader.getResource().toURI(). See #946 about my proposal. Can you please review it?

@elek,  You are right. We can use getResourceAsStream instead.  Thanks for improve the code to solve the issue.
I base in Shanghai. Sorry for miss the review.

No problem. Sorry to not wait for enough time. Usually I prefer to wait at least one day to give the chance to all the time zones to comment it (I am GMT+1/+2)
But this was a small fix and it's blocked my CI comments. And I am ready to improve it if you have any further comments....


This fixes the bug and the test to match.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

LGTM

Great!


fix(windows): detect startup approved register

Currently, this plugin won't detect if the autostart is truly enabled. To do that correctly the startup approved register should also be checked. The odd first byte of this register will prevent the app from autostarting. Even byte or none will allow it. This register is used by the Windows Settings or any other app that can modify startup behaviour. Normally, when Windows Settings enables app to autostart, it will set the first byte to 0x0 or 0x2 and zero-out other 11 bytes.
To reproduce:

open example app
enable autostart in the app
open Windows Settings -> Apps -> Startup
disable autostart for the example app in Windows Settings
reload the example app

The app will show that the autostart is enabled, but in fact, it is not.
With startup approved registry check it will show the true autostart state.

LGTM


IT Semester 3: Operating System Course

Operating System course has 2 lab credits as well.

Fixed. Thank you! [#3]


JSON chat output on guild list GUI click.

With a split message of Join Guild | Inspect Guild to click in chat an option to either join the guild or inspect it for further chat output / info about the guild. So if you had some GUI hover info disabled, you could see the full guild details with member list in chat when clicking on that guild.

For now I won't be able to do this until I find something that will easily support Spigot / Bukkit. Feel free to re-open if you know of something that would work.


Fixed the PT2E LLM example

Type of Change
bug fix
API changed or not: None
Description
Restrict the Dim range for exporting.
Dependency Change?
None

EXT TEST


Umple, Travis, and the Memory problem in general

Currently, when we build on Travis-CI's Linux platform, it fails. See #257, #255, etc..
The reason why it fails (talked about here) is due to the memory Umple consumes is too large. Memory problems will arise on any memory constrained machine, not just Travis. The solution of "add more heap space" when we already consume 1.2+GB of RAM is not reasonable for a compilation process.
I'm not an expert by any means on memory profiling, so I would like any and all input about possible improvement points and reductions:

[ ] Investigate changing the GC cycle to run more often (this will likely slow down compilation)
[ ] Use string caching instead of the "load at class time" scenario we currently have

Load from files stored as Java resources (packaged into the jar) instead of static strings
Use Guava's Cache or hand-roll one for our needs when loading/storing strings (with Ivy we can pull this in simply)

[ ] Improve the memory footprint of Umple's template language

This is a big consideration given #708 going forward
Also an opportunity!

[ ] Cache models during compilation:

Once a model is used, if we can drop any references from memory, it would be beneficial

I think the model verification stage needs all the memory at once, but we might be able to hack some parts together

Cause "model rendering" to be incremental
Use a flat-file cache to write object meta-model data to then pull from it as required and recreate the objects when generating code and are needed keeping "weak" objects in memory that hold the graph of dependencies

These are my initial thoughts, I would really like input and help in implementing this. I don't think I have time to tackle this problem myself, but I'll make some time going forward to help out.

@TimLethbridge I was unsure what to tag this, but I did my best.
@aforward any chance you've had some insight into VM profiling any have any ideas?
I have previously run the Umple compiler through a Java Profiler (no idea which one) and I remember it came back that we spend a ridiculous amount of memory holding onto template strings in static memory. This was obvious when I looked at the templates that JET creates. This memory can never be freed and that's a problem.

No specific insight from me, sorry.
--
aforward

On Feb 9, 2016, at 8:40 AM, Kevin Brightwell<EMAIL_ADDRESS>wrote:
@TimLethbridge I was unsure what to tag this, but I did my best.
@aforward any chance you've had some insight into VM profiling any have any ideas?
I have previously run the Umple compiler through a Java Profiler (no idea which one) and I remember it came back that we spend a ridiculous amount of memory holding onto template strings in static memory. This was obvious when I looked at the templates that JET creates. This memory can never be freed and that's a problem.
—
Reply to this email directly or view it on GitHub.

I will gather sone insights into how and if we can ... don't assign someone just yet.
Clearly Travis itself has lowered its allowable memory threshold or has started running on lower power machines since the exact same compile that used to run now does't. It would be good to see if Travis has any settings to increase the allowable memory before we do any compiler optimizations.

on OSX I did some experiments using a utility called memusg, and also forcing limits on process memory usage.
Wnen memory usage is unconstrained, on my OSX machine, compiling Master.ump uses 1.5GB of peak memory.
It takes about 15s
But if I force a memory limit of 100MB using the ulimit command, compilation still takes 15s, and compilation still is successful! Garbage collection clearly kicks in to constrain memory, but the amount of extra time used is marginal.
If I drop the memory limit to 85MB then CPU time starts to increase noticably ... up to 16.5s
If I drop the memory limit to 80MB then CPU time almost doubles ... up to 28s
If I drop the memory limit down to 75MB, then I get an out of memory error (garbage collection clearly can't handle things at this limit).
It seems impossible that Travis is not allowing 80MB processes, so either:
a) Umple is using the 1.5GB without garbage collection and Travis is just killing when it sees this (solution: force more garbage collection, which seemingly won't cause too much trouble) or
b) It is not memory that Travis is limiting; perhaps it is files open or CPU time
I will do further experiments

Is this compiling the project itself or just running general compilation? Could it be a scale issue?
And yes, 80MB is incredibly low.. I'd say a safe reasonable goal is around 800MB max. I have no justification for that number except that most machines have > 2GB of RAM.

My comments above were for compiling the project itself (compiling Master.ump).
I am working on a branch where I am one-by-one forcing JVM jobs that crash to stay within a 500MB memory limit. This seems to work. The full compile of Umple is now working without being killed. However the documenter packager then had the same problem, so I slapped a limit on this. Next the template.tests were failing ... again I had to slap a JVM memory limit option on that, and all works ok.
And ... successful Travis build of the branch.
If the OSX build completes successfully I will create a pull request.

That's excellent!
May I suggest we keep this as a standing consideration for the template switch, though? While explicitly limiting memory works, most will not and it would have a usability approach to those running it locally.

Not quite sure what you mean by 'standing consideration for the template switch', I have just built the limitation into the build scripts; it will be invisible to all. It just causes 1% increase in garbage collection overhead, which is not noticeable.
Perhaps we could add a -DlimitJvmMemory where true would be the default and a user could use false if they want to eke out that last bit of speed. Or maybe you were thinking making the default false, and putting the true option on the travis task. I leave this as a later step.

Not quite sure what you mean by 'standing consideration for the template switch', I have just built the limitation into the build scripts; it will be invisible to all. It just causes 1% increase in garbage collection overhead, which is not noticeable.
I just meant that keeping reducing memory foot print as an important aspect to consider going forward. Especially since there is a large tendency to grow over time.

Perhaps we could add a -DlimitJvmMemory where true would be the default and a user could use false if they want to eke out that last bit of speed. Or maybe you were thinking making the default false, and putting the true option on the travis task. I leave this as a later step.

That's a really good idea.


Fix Uncaught TypeError: Argument 3 passed to Rollbar\RollbarLogger::log() must be of the type array

Closing as the same problem seems to have been addressed in https://github.com/rollbar/rollbar-php/pull/111


Add reload button to LLM response

WIP
Dump committed due to gnarly behavior.
Needing to repull base code.

While working on this branch I tried to add a call to pop off of the history inside of regenerateOutput.
In the process of doing this I added a pop to src\History\HistoryHandler.ts that tried to pop the last message off of the history array.
This did not work, and I ended up with a UX where:

2-3 seconds after receiving a response from ChatGPT
The assistant response was deleted from the UI.

Now where this gets frustrating dev wise...
Rolling the code back to main did nothing.
I had to wipe out the LLM plugin directory locally, repull the codebase, only then running the same code (commit cbdde19 on the branch from the linked PR) no longer produces the broken behavior.
Unsure what is the specific root cause but wiping out the plugin directory seemed to be the only workable solution I could come up with. Code changes in the files & directory git tracked had no impact.

Somewhere in either the utils or in the ChatContainer there is a setTimeout designed to remove the users prompt (the only response/last response in the messages array) after x seconds if the plugin encounters an error on the backend. The current behavior of adding messages to the UI is pretty basic too, it was done under the assumption that the user would never send 2 messages in a row and the assistant could never reply with 2 messages in a row, so I suppose there is potential for a bug to happen when you pop the last message of the array, or any messages of the array, that the index is not updated and that setTimeout is removing the assistant response because its the last response in the array

Yup the error handling issues went away.


garbage collection stats

https://github.com/dainis/node-gcstats
(https://github.com/bretcope/node-gc-profiler)

perhaps low priority, this requires C hooks in node


Go to symbol in workspace seems to not be working:

Search symbol in project does not see to work on an exported module function. If I do symbol search in file, it works fine.
In some cases, it only finds some of symbols, in others, it finds none.

VSCode Version: Code 1.15.1 (41abd21afdf7424c89319ee7cb0445cc6f376959, 2017-08-16T17:15:57.756Z)
OS Version: Darwin x64 16.7.0
Extensions:

Extension
Author (truncated)
Version

beautify
Hoo
1.1.1

code-settings-sync
Sha
2.8.3

html-css-class-completion
Zig
1.9.0

project-manager
ale
0.20.0

npm-intellisense
chr
1.3.0

path-intellisense
chr
1.4.2

vscode-eslint
dba
1.2.11

vscode-dash
dee
1.7.0

githistory
don
0.2.3

python
don
0.7.0

macros
ged
1.2.0

sublime-keybindings
ms-
2.9.1

debugger-for-chrome
msj
3.2.0

vscode-fileutils
sle
2.6.2

Steps to Reproduce:

Copy pasting actual symbol name into the search area per screenshot below.
Also try a search for a very common settings import.

Reproduces without extensions: Yes

I also notice that, with the Sublime shortcuts extension, I get two different GUI views even though the following shortcuts are linked to the same command in the shortcuts:

Does your workspace have one or more jsconfig or tsconfig files?
For the sublime extension shortcut problem, can you please file that issue against that extension: https://github.com/Microsoft/vscode-sublime-keybindings/issues/new

I have neither a jsconfig or tsconfig file in my workspace.

Try creating a jsconfig at the root of your workspace with the contents:
{
    "compilerOptions": {
        "target": "ES6"
    },
    "exclude": [
        "node_modules",
        "**/node_modules/*"
    ]
}

This tells VSCode to treat all JS files in the workspace as part of a single project


Player should be able to win level when all spawn points locked

Depends on #14

Merged with a bunch of other changes in ad1644e


Improve the checkbox component

Add new token for the border  --border-width-2 with 2px value and use it in checkbox component
Reduce the size(height and width) of the checkbox from 5x to to 4x of root unit.

Hey team! Please add your planning poker estimate with Zenhub @ichik @jsartisan @KelvinOm


huggingface_hub.utils._validators.HFValidationError

DrAttack/drattack/utils/model_loader.py", line 105, in get_worker
tokenizer = AutoTokenizer.from_pretrained(
huggingface_hub.utils._validators.HFValidationError: Repo id must be in the form 'repo_name' or 'namespace/repo_name': '../../../llm_models/vicuna/vicuna-7b-v1.3'. Use repo_type argument if needed.

Would you please check your whether you have placed your model at target location?
Please check your configuration here in line 7 and line 10. Make sure this path contains your model from huggingface.

Would you please check whether you have placed your model at target location?
Please check your configuration here in line 7 and line 10. Make sure this path contains your victim model from huggingface.

Thanks very much. That works for me.


Beacon HTTP API slow response times

Describe the bug
The Beacon HTTP API takes always > 2 sec to complete any request even for endpoint that don't require any processing.
We must investigate what is causing this delay:

Node to busy?
Some logic bug?
Fastify?
NodeJS itself?

Expected behavior
Respond to API requests in < 100ms times
Steps to Reproduce
Run lodestar beacon
time curl localhost:9596/eth/v1/beacon/headers/head

Non actionable issue directly. We are working on reducing main thread load an watching REST times closely


Upload .xlsx file for download

Sometimes the editor might need to upload an Excel file to the platform so users can download it

Now supporting "other files" (also added to the download button style). The format is interpreted automatically.


The test result(megaface rankn and roc) of Circle loss is so bad.

The test result(megaface rankn and roc) of Circle loss is so bad. I trained it by efficient-b0. but when I test it on megaface. the result is so bad. Do you ever trained it? if yes. can you provice the pretrained model? ths

I trained r100 with circle loss. how about  val dataset acc ?

the training acc is always stay 0.001 like below, so strange. But the val eval looks good(lower than arcface loss).
56786 Epoch 24/24 Batch 12000/12948   Training Loss 25.2287 (22.5939) Training Prec@1 0.000 (0.001)   Training Prec@5 0.000 (0.005)
56787 ============================================================
56788 Current lr 1.2296052467588773e-05
56789 ============================================================
56790 Perform Evaluation on LFW, CFP_FP, AgeD and VGG2_FP, and Save Checkpoints...
56791 Epoch 24/24, Evaluation: LFW Acc: 0.9956666666666667, CFP_FP Acc: 0.9568571428571427, AgeDB Acc: 0.9576666666666667, VGG2_FP Acc: 0.9348000000000001

The training parameters is default. At first, i wonder if it is too little training iterations. But the circle loss paper is only 182k iterations. less than 24epoch. So it seems like my wonder is wrong.

The training parameters is default. At first, i wonder if it is too little training iterations. But the circle loss paper is only 182k iterations. less than 24epoch. So it seems like my wonder is wrong.

your LOSS_NAME  is softmax or softplus?

softplus.

what's the megaface and ijbc acc ?

what's the megaface and ijbc acc ?

how to look at the megaface acc? I only use the cmc_json which generated under the megaface_24 file. and generate the cmc curve. the rank1 is too low.
by the way. when I finished run the eval code about megaface. the megaface_24 only generate two  files, namely matches_facescrub_megaface_retina_1000000_1.json and cmc---json. But when I trained the model by arcface. and evaluate the megaface. the megaface_24 includes :cmc_facescrub_megaface_retina_1000000_efficientnet_1.json  embedding  embedding_clean  matches_facescrub_megaface_retina_1000000_1.json  otherFiles, is there something wrong with the evaluation code. But I only changed the model with the same eval code.

what's the megaface and ijbc acc ?

how to look at the megaface acc? I only use the cmc_json which generated under the megaface_24 file. and generate the cmc curve. the rank1 is too low.
by the way. when I finished run the eval code about megaface. the megaface_24 only generate two files, namely matches_facescrub_megaface_retina_1000000_1.json and cmc---json. But when I trained the model by arcface. and evaluate the megaface. the megaface_24 includes :cmc_facescrub_megaface_retina_1000000_efficientnet_1.json embedding embedding_clean matches_facescrub_megaface_retina_1000000_1.json otherFiles, is there something wrong with the evaluation code. But I only changed the model with the same eval code.

what's the megaface and ijbc acc ?

how to look at the megaface acc? I only use the cmc_json which generated under the megaface_24 file. and generate the cmc curve. the rank1 is too low.
by the way. when I finished run the eval code about megaface. the megaface_24 only generate two files, namely matches_facescrub_megaface_retina_1000000_1.json and cmc---json. But when I trained the model by arcface. and evaluate the megaface. the megaface_24 includes :cmc_facescrub_megaface_retina_1000000_efficientnet_1.json embedding embedding_clean matches_facescrub_megaface_retina_1000000_1.json otherFiles, is there something wrong with the evaluation code. But I only changed the model with the same eval code.

the eval program will generate embeddings and otherfiles, and remove embeddings and otherfiles when finish evaluation. the result is appended in service/face.result file

hello, Has the problem been solved？


Add error logger

I am submitting this change looking for directions on what could be the best way to integrate it into official exqlite release. This particular change has been extremely useful when debugging errors on applications that use LiteFS and I am sure could be useful to others.
From sqlite docs:

The SQLITE_CONFIG_LOG option is used to configure the SQLite global error log. (The SQLITE_CONFIG_LOG option takes two arguments: a pointer to a function with a call signature of void()(void,int,const char*), and a pointer to void. If the function pointer is not NULL, it is invoked by sqlite3_log() to process each logging event. If the function pointer is NULL, the sqlite3_log() interface becomes a no-op.
The void pointer that is the second argument to SQLITE_CONFIG_LOG is passed through as the first parameter to the application-defined logger function whenever that function is invoked.
The second parameter to the logger function is a copy of the first parameter to the corresponding sqlite3_log() call and is intended to be a result code or an extended result code.
The third parameter passed to the logger is log message after formatting via sqlite3_snprintf().
The SQLite logging interface is not reentrant; the logger function supplied by the application must not invoke any SQLite interface. In a multi-threaded application, the application-defined logger function must be threadsafe.

What we'll want to do here is not use that fprintf, but instead we'll need to take that error string that is emitted by sqlite, and notify erlang somehow with the message.
There is a function in the sqlite3_nif.c called make_binary(env, the_string, length_of_string). This will return the ERL_NIF_TERM which we can then enif_send to a pid.
We'll need to stand up a listener for this.
This does tie into #192 somewhat where we should probably spin up one process instance.

@dangra What are you thinking about with consuming the log messages? Were you just wanting to dump to Logger and friends? Or were you wanting to monitor the events pushed out via a handler of some sort?

@warmwaffles I haven't had the time to look at it and honestly lack the experience with NIFs and Elixir, to me it is all new stuff. Not making excuses! just setting expectations here, if the open PR bothers you, I am ok closing it for now and resubmit once I have something that integrates your feedback.
that said, my only goal was to log the messages so in case of this type of errors, I can tail logs and see what sqlite3.c function and line have error'ed. I don't have the need to push the events to a handler of any type.

@dangra I was going to implement this using the methods I outlined above. We shouldn't be printing to stdout using the NIF. We risk interleaving output in a highly concurrent environment.

👋
I've opened a PR with the suggested changes (send binary to pid): https://github.com/elixir-sqlite/exqlite/pull/266
I mostly wanted to make sure this feature would work after https://github.com/elixir-sqlite/exqlite/issues/192 and one way to do that is to put add_error_log/2 in master :)


HelperSabotage shows numeric value 7 in HASS

Describe the bug
I have just added a HM-SEC-SC-2 and tested Sabotage alarm. I noticed that the value 7 is indicating sabotage. In home assistant I can see the value 7 but shouldn't it be Yes instead?
When there is no sabotage alarm present, the value in HASS is correct No.
https://github.com/danielperna84/pyhomematic/blob/e298897c455340cd43c50e700d227322e4ed735f/pyhomematic/devicetypes/helper.py#L16

This is cause by Home Assistant here. I don't know why it has been done this way, but I assume different devices use different numbers. 0 always is no error, whereas anything greater than 0 is something the user has to figure out. There can be different errors after all I guess. Just saying Yes won't help the user to track down the issue.

Are you sure. For me it looks like that ERROR in the code you referenced is always related / translated to sabotage. Hence, at least in the homematic component can never mean anything else. Also I checkt the comprehensive Homematic device description of Homegear ant ERROR is always meaning sabotage alarm.
Last, the homematic component in HASS is using your python lib. Therefor it is actually you who defines what ERROR means. the component in HASS only translates your values into readable words.

Therefor it is actually you who defines what ERROR means.

No. pyhomematic is just a wrapper that passes on data. If the CCU sends the value 7, then we pass that on to Home Assistant. What the error code 7 means ahs nothing to do with pyhomematic. The mapping in HASS just know that with 0 everything is fine, 1 is an error, and everything else it doesn't know about.
The only reference for what ERROR means I found in the XML-RPC API documentation (<IP_ADDRESS> ERROR):
{1, “Unknown Error”}
{2, “Busy”}
{3, “MemFull”}
{4, “Target Invalid”}
{5, “Channel Invalid”}

So everything, like 7, is outside of the standard errors and, in my opinion, depends on the device. So, yeah, HelperSabotage should be HelperError, and the sabotage-method should compare the value to 7. At least for RF devices. For IP devices it might be different.

I am sorry about my too overconfident sentence that ERROR always means sabotage. I checkt many devices but not all. I was too fast with this.

And HM-Sec-SC-2 has:

0 = NO_ERROR
1 = SABOTAGE

Here the documentation is wrong I have the idea that the document is not up-to-date anyway. As I said, I have the sensor just added with the latest firmware and it shows value "7" when it detects a sabotage. I have the idea that the documentation of Homegear about the devices is much more reliable.
There is still one thing I do not understand. You are casting the value to bool (True or False) but still the actual value is passed to HASS. When I cast "7" to bool than I get true. How does that work? Does this mean HASS is responsible to know about homematic specific device attributes? This would mean that ever project using your lib would have to figure out themselves.
If You designed your lib to be "just" a connector without handling any knowledge about the devices I understand this. Don't you thing that it could make sense to make the lib aware of  device specifics - at least in these corner cases. For example translate the information about the ERROR if known and create an attribute SABOTAGE even though it does not exist. ERROR will still be offered untouched. SABOTAGE or ERROR_SABOTAGE exists for anyways on other devices. Or instead of passing the value you could pass the translated string such as VALVE_DRIVE_BLOCKED instead of 1.

Here the documentation is wrong I have the idea that the document is not up-to-date anyway. As I said, I have the sensor just added with the latest firmware and it shows value "7" when it detects a sabotage. I have the idea that the documentation of Homegear about the devices is much more reliable.

And that's exactly why I don't want pyhomematic to take care of this. If this was part of pyhomematic, this would have to be maintained for every device with every firmware update. That's just not worth the effort. So we just pass on the value. And if a user want's to know what it is he can google it. It's different for every device after all. Do you know ioBroker? It does even less logic than pyhomematic. It just exposes all channels with all paramters with their values. The user has to decide what to do with these values. That's what I can live with for everything that's not core functionality for the devices.

There is still one thing I do not understand. You are casting the value to bool (True or False) but still the actual value is passed to HASS. When I cast "7" to bool than I get true. How does that work?

In Python everything that is not 0 or None will evaluate to True.

Does this mean HASS is responsible to know about homematic specific device attributes? This would mean that ever project using your lib would have to figure out themselves.

Correct. I'm not willing to clean up the mess ELV has made. In theory we could detect all this by iterating through the paramsets. By doing that we wouldn't even have to create alle these classes. Everything could be automated. But reading paramsets is incredibly slow. So in some way what pyhomematic does is making usable objects out of the paramsets, but manually by us, because in terms of speed it's not practical to automate it.

If You designed your lib to be "just" a connector without handling any knowledge about the devices I understand this. Don't you thing that it could make sense to make the lib aware of device specifics - at least in these corner cases.

I want to stick to the standards. Creating a virtual SABOTAGE parameter that just is computed by pyhomematic would fall out of the specification. Let's just say some other tool would use pyhomematic and it didn't know about the SABOTAGE paramter because it does not exist for that particular device. Maybe the fired event would have negative impacts in this case.
To sum this up. I want to keep pyhomematic as simple as possible. It's a wrapper with a few extras. Everything beyond that has to be done by the consuming library if it's really needed.

To sum this up. I want to keep pyhomematic as simple as possible. It's a wrapper with a few extras. Everything beyond that has to be done by the consuming library if it's really needed.

I understand, also because it would be a lot of effort if we would expect the Attributes to stay the same across firmware updates. I personally think it would be worth it but only when there would be a active community that reports the details as they change. That is probably wishful thinking.
In addition your other points make sense from the perspective you explained.
I guess than we have to change the Helper later and contact HASS about their problematic line of code you referenced.

I guess than we have to change the Helper later and contact HASS about their problematic line of code you referenced.

I'm the one maintaining it there. This library primarily is for use with Home Assistant. That's what I have created it for. So I'll take care of that. 😉


gateway-api: bump dependency to fix flakes

Please provide a description of this PR:

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
866f7d08aa8f703bd226adec39fe2ae69b801bd2
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Stateless Skylight Component

Hey @marcio ,
This PR adds a new component: SkyLightStateless. This component externalizes it's open-state to a property. This allows it to be used in Flux/Redux contexts.
I've also updated a couple of libs and did some boilerplatey cleanup. Let me know if you have any questions!
-Chris
Fixes #32

Hi @darthtrevino,
Looks good man! I will analyse and merge as soon as I can.
I need some time to write some documentation about that too.
Thanks.

Awesome! If you have a good test-bed for the main Skylight component, it would be worthwhile to test that. I'm using the stateless component in an app I'm writing, but I haven't had a chance to dig too far into stateful one.

@marcio I added some unit tests to verify that everything was still behaving correctly. You're welcome. ;-)

Wow!! Thanks @darthtrevino!!
This week I'll work on merge and docs.If everything goes well I publish a new version. 👍


Unable to generate new definitions on Ubuntu 20.04

It appears that the shared library that is provided with the package in the releases tab is compiled for RedHat variants of Linux. When attempting to use it with LabVIEW 2021 SP1 on Ubuntu 20.04, it states that liblabview_grpc_generator.so cannot be found, see screenshots below. Even after directly selecting the library through, it still responds with Error 7 file not found. I have seen this in the past when trying to use a shared library that was compiled for Debian/Ubuntu variants of Linux on CentOS with LabVIEW.

Checking out the source and running the build steps and updating the reference to point to the newly compiled liblabview_grpc_generator.so and it is able to be loaded in. Appears to be an issue with the shared object produced in the provided VI package. Using the latest v<IP_ADDRESS> release. Build was made on Ubuntu 20.04.


Not able to get value of the search bar

Following is the code which I am trying but it does not provide value of the search bar
<SearchBar
                ref={(ref) => this.searchBar = ref}
                data={items}
                onSubmitEditing={this._performSearch}
            />

 _performSearch(query) {
    //let query = this.searchBar.getValue();
    // also tries this.searchBar.getValue();
    // query.getValue();
    console.log('PERFORM SEARCH FUNCTION ');
    console.log(query);
    /*APIHelpers.searchProducts(query).then((res) => {
            console.log(res);
        }
    ).catch(err => {
        console.log('error');
        console.log(err);
    });*/
}

I request you to please update the read me with more elaborated usage, I am a beginner and got confused implementing.

@khanof89 I'm not sure why that isn't working for you. Note that onSubmitEditing will not pass your callback any params.
You could try maintaining a copy of the search bar input value in your component state, by using the handleChangeText prop, then using this value to search your API when the user presses search.


Reopen: Not able to deploy marimo app with docker with version 0.3.0 or higher

Describe the bug
Reopening issue:
https://github.com/marimo-team/marimo/issues/1093#issuecomment-2051130250
Environment
marimo >= 0.3.0

Not sure if https://github.com/marimo-team/marimo/issues/1093 was not Re-openable for you (let me know if it was locked), but I re-opened it, so we can keep context to one thread

Thank you.
Yes I am not able to reopen an issue.


test-branch/execute-job/quoted-authorization/deb8560b-3e38-45fa-81a6-9ba39a42fb70

PR for testing 7d85110a75a8d9499561e4a46a8757f8994acc5c

/canonical/self-hosted-runners/run-workflows 7d85110a75a8d9499561e4a46a8757f8994acc5c


Remove @babel/runtime devDependencies in next-server

As stated here : https://babeljs.io/docs/en/babel-plugin-transform-runtime#installation
Only @babel/runtime-corejs is needed : https://babeljs.io/docs/en/babel-plugin-transform-runtime#options
@babel/runtime-corejs seem to be required during runtime, so it should be move to dependencies ?
Also, @babel/runtime is not required when using corejs.

This has been updated in canary, so this PR now does the following :
Remove @babel/runtime and @babel/runtime-corejs2 devDependencies in next-server
(not necessary because there's already @babel/runtime-corejs2 in dependencies 🙂)


Upload of VLDs is possible

Story identified in Roadmap meeting

Do not understand this story. We have spent 9 months implementing a replacement for VLD processing called CSVProc. What is being proposed here? Upload of a file is trivial. It will just sit there. There are no current processes that would take the entries and put them in the database. The latter is a 21 size task.

VLDs can already be uploaded as CSV files - so deleting from Roadmap and will then close.


Extend return message

extending the return message so we can propagate payment status to the user

Coverage increased (+0.7%) to 72.3% when pulling 8ed9b16a008d4ec754334167e8099fb6504fb80b on extend-return-message into 67797d68aaca7bc8a8ebcf5e607bc02bbb96c164 on master.

Coverage increased (+0.7%) to 72.3% when pulling 240ba8939b392a875ae9b8982978d5fc1d28ef57 on extend-return-message into 67797d68aaca7bc8a8ebcf5e607bc02bbb96c164 on master.

https://github.com/microservices-demo/front-end/issues/32


Update readme to replace --level option with -O

This change removes mention of the --level option which never existed. In versions earlier than 5.0.0, clean-css-cli used to accept the invalid option silently.  With versions > 5.0.0, trying to use the option results in the following: error: unknown option '--level'.  The root cause of the change the upgrade to commander v7.0.0, where unknown (excess) command arguments are now raised as an error.
For interest, I was using the option because Bootstrap previously used it in their package.json.

Hi @davidjb - many thanks for spotting this! You are right, there were never a --level option in the CLI. Merging right away.

No problem @jakubpawlowicz - I had to go digging to understand what happened on upgrading from v4 to v5..and turns out it was never there at all :man_shrugging:


Inject: Annotation @Inject is misleading

The property "identifier" is misused and leads to confusion. DoozR's DI is based on an optional property "identifier" which is in that context used for identifying an existing Instance for injection for automagically injections and manually injections by identifier.
In the annotation class Inject the property "identifier" is used to identifiy the receiver of the injection. For example currently its used with a string for example getInstance which leads to an injection via method ...::getInstance(...). This works as expected but could lead to an error.
We also need the property now for identifying instances to inject if not explicit mapped before.
We need to rename the property identifier of the class Injection to receiver same for parser which parses .dependencies. We need to ensure that the logic and convention is always 1:1.
So we implement both in @Inject - property receiver (name of the receiver to inject via e.g. getInstance) and property identifier (which instance! like UUID).

Will be integrated into and fixed with #67.


State Inconsistency in Calling Nested Inner Function

🐛 Bug Report
I encountered a discrepancy in the "state" of two nested functions while working on this project. Sometimes "state" does not seem to update its value as expected.
🔄 Steps to Reproduce
The issue can be reproduced using the following code snippet:
def my_stateful_function():
    count, set_count = use_state(0)

    def increment():
        set_count(count+1)

    print("count:", count)
    return increment

inc = my_stateful_function() # Initial count = 0
inc() # Must Increment: 0 to 1
inc() # Must Increment: 1 to 2
inc() # Must Increment: 2 to 3
my_stateful_function() # Expected: count = 3, Actual: count = 1 gets printed in console

Meanwhile, for comparison, the following method of using states behaves correctly as expected:
def my_stateful_function():
    count, set_count = use_state(0)

    def increment():
        set_count(count+1)

    print("count:", count)
    return increment

inc1 = my_stateful_function() # count = 0 and prints 0
inc1() # Increment: 0 to 1
inc2 = my_stateful_function() # Print 1
inc2() # Increment: 1 to 2
inc3 = my_stateful_function() # Print 2
inc3() # Increment: 2 to 3
my_stateful_function() # Prints 3

⚙ Expected behavior
The anticipated outcome is that both code samples should produce identical outputs, maintaining and updating the state correctly across various methods of calling functions.
💻 Environment

OS: macOS 14.2.1
Python version: Python 3.11.7

Thanks for the bug report @arvindavoudi, I'm taking a look


Set system-chart branch to dev-v2.4

Fixed conflicts in https://github.com/rancher/rancher/pull/28314


[Outlook] (displayNewMessageForm) Correct modes

Fixes https://github.com/OfficeDev/office-js-docs-pr/issues/2201.

Docs Build status updates of commit 5d19495:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/objectmodel/preview-requirement-set/office.context.mailbox.md
:white_check_mark:Succeeded
View

docs/reference/objectmodel/requirement-set-1.6/office.context.mailbox.md
:white_check_mark:Succeeded
View

docs/reference/objectmodel/requirement-set-1.7/office.context.mailbox.md
:white_check_mark:Succeeded
View

docs/reference/objectmodel/requirement-set-1.8/office.context.mailbox.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 95dcd4d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/objectmodel/preview-requirement-set/office.context.mailbox.md
:white_check_mark:Succeeded
View

docs/reference/objectmodel/requirement-set-1.6/office.context.mailbox.md
:white_check_mark:Succeeded
View

docs/reference/objectmodel/requirement-set-1.7/office.context.mailbox.md
:white_check_mark:Succeeded
View

docs/reference/objectmodel/requirement-set-1.8/office.context.mailbox.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 63bc1e5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/objectmodel/preview-requirement-set/office.context.mailbox.md
:white_check_mark:Succeeded
View

docs/reference/objectmodel/requirement-set-1.6/office.context.mailbox.md
:white_check_mark:Succeeded
View

docs/reference/objectmodel/requirement-set-1.7/office.context.mailbox.md
:white_check_mark:Succeeded
View

docs/reference/objectmodel/requirement-set-1.8/office.context.mailbox.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


RuntimeError: unreachable

Description
Installing in VSCodium and opening a .toml file gives error that the LSP crashed 5 times in the last 3 minutes.
Console output
Pastebin link because GitHub complains it's too long: https://pastebin.com/uWcP00PW
VSCodium info
Version: 1.83.1
Release: 23285
Commit: 36d13de33ac0d6c684f10f99cff352e2f58228b3
Date: 2023-10-12T18:42:10.077Z
Electron: 25.8.4
ElectronBuildId: undefined
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22631

This looks like a duplicate of #434 which is fixed by #462 which is waiting to be released by #473. Feel free to subscribe to that last issue to know when your issue will be fixed.

This looks like a duplicate of #434 which is fixed by #462 which is waiting to be released by #473. Feel free to subscribe to that last issue to know when your issue will be fixed.

I see, glad it's been addressed. Wouldn't a tag like awaiting-new-release more appropriate?


feat(dashboard): API to get a dashboard's charts

SUMMARY

Adds a new API to get the chart definitions for a specific dashboard. This is going to support future efforts to turn Superset's frontend into a single page app by allowing removal of the Dashboard app's bootstrap data.
Alternative considered: Using GET dashboard/:id/related/slices, and iterating over the results to fetch all the slices from /charts/:id.
I rejected this approach because it would require changing the /related/slices endpoint (currently the endpoint returns the names of charts rather than ids, which is pretty useless for this purpose), and also because it would result in a large number of API requests. The chosen method of a single convenient API endpoint is much simpler.
Thanks to @pkdotson for pairing ❤
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A
TEST PLAN

Wrote tests
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[x] Introduces new feature or API
[ ] Removes existing feature or API

Requesting review from @dpgaspar to make sure I got the security related code and doc strings correct :)

@suddjian You can probably get some logs if you visit /swagger/v1 which the result of compiling these docstrings.

Codecov Report

Merging #12978 (f152f56) into master (89b6a2c) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #12978      +/-   ##
==========================================
+ Coverage   66.75%   66.94%   +0.18%
==========================================
  Files        1015      489     -526
  Lines       49634    28707   -20927
  Branches     4839        0    -4839
==========================================
- Hits        33134    19217   -13917
+ Misses      16377     9490    -6887
+ Partials      123        0     -123

Flag
Coverage Δ

cypress
?

javascript
?

python
66.94% <100.00%> (+2.97%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/constants.py
100.00% <ø> (ø)

superset/dashboards/api.py
87.24% <100.00%> (+0.60%)
:arrow_up:

superset/dashboards/dao.py
95.09% <100.00%> (+0.41%)
:arrow_up:

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/utils/celery.py
89.65% <0.00%> (-10.35%)
:arrow_down:

superset/db_engine_specs/hive.py
73.84% <0.00%> (-10.00%)
:arrow_down:

superset/utils/cache.py
76.34% <0.00%> (-8.77%)
:arrow_down:

... and 594 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b6a2c...f152f56. Read the comment docs.

Congrats on the first step and thanks for the collaboration! @suddjian @pkdotson
seems to me that Multiline chart is not passing through the new API.

Thanks for the QA @junlincc, but I don't think that error could possibly have anything to do with this PR. No existing functionality has been changed here.

got it, that's strange. i also checked on master and other branches which don't have this issue. please disregard if it's not related.


ExecutionStrategy ctor argument - maxRetryCount has incorrect documentation

Documentation says:
The maximum delay in milliseconds between retries.

but the argument is TimeSpan.
We should change the message to:
The maximum delay between retries.

There are 5 places where this needs to be changed.

Can I poach this? :trollface:

@AndriySvyryd - Suggested doc comment here?
The maximum delay between retries. ? or do we want to include timespan too?

Timespan is implied, so the first suggestion should be ok.


[FEATURE] Create a E2E cypress test for OIDC refresh token workflow

Is your feature request related to a problem?
There seems to have been a regression with the OIDC refresh token workflow introduced in this PR: https://github.com/opensearch-project/security-dashboards-plugin/pull/1773. Checking the existing e2e tests we have for OIDC there is no test covering the refresh token workflow: https://github.com/opensearch-project/security-dashboards-plugin/blob/main/test/cypress/e2e/oidc/oidc_auth_test.spec.js. We should add a test to make sure there are no regressions with this feature.
What solution would you like?
E2E test covering oidc refresh token workflow
What alternatives have you considered?
None
Do you have any additional context?
Potentially related PR fix: https://github.com/opensearch-project/security-dashboards-plugin/pull/1924

[Triage] Hi @derek-ho thank you for filing this issue. This looks like a smart follow-up for the issue fixed by the linked PR. Going to mark triaged.


Question: multi-body analysis with Multiple Point Constraints(MPC) or constraint equations

Hello MFEM staff and community,
I checked out the ex2, 6, and 21, and they look great. My question is can MFEM solve the multi-body problems using the same scheme for the problems illustrated below? The body boundaries are not aligned exactly, only a portion of the boundaries are bonded. If it is an electrostatic/magnetostatic analysis, do I need to create a new integrator rather than using the existing ElasticityIntegrator?
                    +----------+
        +----------+| material |
        | material ||     2    |+----------+
        |    1     ||          || material |
        |          |+---------+||    3     |
        +----------+            |          |
                                +----------+

Look forward to hearing from you. Thank you.
Best regards,
Liang

Hello Barker29,
Thank you for your answers.
Yes, my question is about the similar contact condition between bodies, but no separation or sliding occurs. The bodies are just simply bonded from the beginning to the end of the simulation. No shared nodes or elements on the boundary between bodies. Nowadays, MPC condition has many applications in structural, thermal, and electromagnetic analyses. So I really look forward to seeing and using this feature in MFEM.
I will look into #1842 and the relevant source code, and try to understand the algorithms implemented in MFEM. Forgive me that I may have some questions (could be dummy) in the future.
Best regards,
Liang

I will close this for now, but please feel to re-open if you have further questions.


Typescript error: using name 'ClassProp' from external module cannot be named

Describe the bug
Typescript compiler complains that ClassProp cannot be named.
To Reproduce
Use cva as part of a type export.
import { cva, VariantProps } from 'class-variance-authority'

const classProps = cva('badge pa-2')

export type BadgeVariants = VariantProps<typeof classProps>

Typescript error:
Exported variable 'classProps' has or is using name 'ClassProp' from external module "node_modules/class-variance-authority/dist/index" but cannot be named.

Expected behavior
Typescript should not complain.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
I think ClassProp is just missing an export.

Hey! See https://github.com/joe-bell/cva/issues/5
I think you perhaps need to add skipLibCheck or double-check your tsconfig.json file


The rest api of download file have an error.

Hi:
I try to download a file by the driveItem unique identifier using drive/items/{item-id}.But the server return the error code of 400.
Thanks
Davin

Hi @wudeyong, can you provide the full request / response? Without those it's hard to say why you'd be seeing a 400 Bad Request.

Yes,of course.
The request like this:

GET https://graph.microsoft.com/v1.0/drives/items/{item-id}/content

The response is:
{
  "error": {
    "code": "BadRequest",
    "message": "Resource not found for the segment '01FASBQH4B3TCO37AHZRCLRP3CVRSN34QX'.",
    "innerError": {
      "request-id": "4c90ff6a-37df-40cd-8436-e8e93fd087de",
      "date": "2017-12-07T09:07:46"
    }
  }
}

Thanks
But it can correct work when use another  API: /drives/{driver-id}/items/{item-id}/content


Core: add an event builder to simplify making events

@alexanderdean for this ticket I was going to follow these examples for a builder with subclasses (https://weblogs.java.net/blog/emcmanus/archive/2010/10/25/using-builder-pattern-subclasses).  The usage would then be something like:
tracker.track(PageViewEvent.Builder().url("").referer("").build())

PageViewEvent being an extended version of a base Event class which will have all the common event attributes.  Does this sound good to you or did you have something else in mind?

I think that looks good @jbeemster ! It should be pretty user-familiar, user-friendly.


/add oftenUsedListOfFiles

Issue
It would be nice to be able to save lists of frequently used files as variables.
We would be allowed to use this list of files as a variable in the /add and other commands.
/add oftenUsedListOfFiles
/drop oftenUsedListOfFiles
...

Version and model info
No response

Related #1619

Thanks for trying aider and filing this issue.
You can use CONTROL-R to search back for previous /add some files I like to add commands, or /drop some other files I like to drop.


[ParseableInterface] Fix failing to build a module when the importing file has errors.

We were checking the parent invocation's DiagnosticEngine rather than the sub-instance's to determine if there were any errors building the module, which meant we would fail to load the module if there were errors prior to the import statement in the importing file.
This also meant code completion would fail to load the module, because it always emits a bogus error in order to mark the AST as erroneous so that different parts of the compiler (e.g. the verifier) have less strict assumptions.
rdar://problem/43906499

@swift-ci please smoke test

@swift-ci smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@nathawes Brent had to revert this because the test failed on the 32-bit iOS simulator.

Thanks – I'll take a look today.


feat(): add warning message for not linked evidences (AAA-1456)

Change description
assessments upload API now returns the result about if evidence is linked or not. This BE PR is about it.
It shows warning messages when API returns not linked evidences. Used warning messages that Kyle suggested on this ticket

I'm confused about this.
There is almost always going to be non-linked evidence (Lens creates more evidence then is strictly needed by requirements). Why do we want to warn users about it? If we want to reduce evidence, we need to explicitly remove any evidence that isn't associated with a requirement. If we want that, we should just do that. Not warn the user.


revert network,passt: configure unprivileged_port_start to 0

The sysctl configuration is no longer needed as the issues in passt are fixed:

https://bugs.passt.top/show_bug.cgi?id=15
https://bugs.passt.top/show_bug.cgi?id=18

We continue testing connectivity to low port in e2e tests.
Signed-off-by: Radim Hrazdil<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/test pull-kubevirt-e2e-k8s-1.23-sig-network
/test pull-kubevirt-e2e-k8s-1.24-sig-network

/cc @AlonaKaplan

Turns out, it's the CAP_NET_BIND capability that we want to drop. So let's close this

@rhrazdil The capability could stay. It is little bit better than having this as it is visible to user &| audit tools