[SPARK-16861][PYSPARK][CORE] Refactor PySpark accumulator API on top of Accumulator V2

What changes were proposed in this pull request?
Move the internals of the PySpark accumulator API from the old deprecated API on top of the new accumulator API.
How was this patch tested?
The existing PySpark accumulator tests (both unit tests and doc tests at the start of accumulator.py).

Test build #63140 has started for PR 14467 at commit 736f6ce.

Test build #63140 has finished for PR 14467 at commit 736f6ce.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Least(children: Seq[Expression]) extends Expression
case class Greatest(children: Seq[Expression]) extends Expression

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63140/
Test PASSed.

cc @davies (python). @rxin (new accumulator API) & @srowen (accumulator API cleanup) - not that it necessarily needs all of you to look at it but just to make sure everyone is aware if interested.

Test build #63182 has started for PR 14467 at commit 4756853.

Test build #63186 has started for PR 14467 at commit 4b1b872.

Test build #63190 has started for PR 14467 at commit a4d87e8.

Test build #63182 has finished for PR 14467 at commit 4756853.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63182/
Test FAILed.

Test build #63186 has finished for PR 14467 at commit 4b1b872.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63186/
Test FAILed.

Failure seems unrelated, Jenkins retest this please.

Test build #63195 has started for PR 14467 at commit a4d87e8.

Test build #63190 has finished for PR 14467 at commit a4d87e8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63190/
Test PASSed.

Test build #63195 has finished for PR 14467 at commit a4d87e8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63195/
Test FAILed.

Merged build finished. Test FAILed.

Test build #63205 has started for PR 14467 at commit cc5f435.

Test build #63205 has finished for PR 14467 at commit cc5f435.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63205/
Test FAILed.

jenkins retest this please.

Test build #63248 has started for PR 14467 at commit cc5f435.

Test build #63248 has finished for PR 14467 at commit cc5f435.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63248/
Test PASSed.

ping @srowen & @rxin & @squito

Test build #64030 has started for PR 14467 at commit 04a1d37.

Test build #64030 has finished for PR 14467 at commit 04a1d37.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64030/
Test FAILed.

Merged build finished. Test FAILed.

jenkins retest this please

Test build #64087 has finished for PR 14467 at commit 04a1d37.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64087/
Test PASSed.

Merged build finished. Test PASSed.

Just a heads up - going on some vacation next week so will be slower responding to comments.

Back from vacation if anyone has review bandwidth I'd love to get this cleanup in :)

Test build #65119 has started for PR 14467 at commit 2f0af6a.

Test build #65119 has finished for PR 14467 at commit 2f0af6a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65119/
Test PASSed.

Merged build finished. Test PASSed.

Ping @MLnick / @srowen ?

Test build #65274 has started for PR 14467 at commit 6169c3c.

Test build #65274 has finished for PR 14467 at commit 6169c3c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65274/
Test PASSed.

Merged build finished. Test PASSed.

Test build #65394 has started for PR 14467 at commit b29d8cd.

Test build #65394 has finished for PR 14467 at commit b29d8cd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65394/
Test PASSed.

Test build #65678 has started for PR 14467 at commit 45ec1ef.

Test build #65678 has finished for PR 14467 at commit 45ec1ef.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65678/
Test PASSed.

Merged build finished. Test PASSed.

Test build #65728 has started for PR 14467 at commit 76f1fac.

Test build #65728 has finished for PR 14467 at commit 76f1fac.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65728/
Test PASSed.

That LGTM. I'll leave it open a bit for any more comments.

Merged to master


Update public image folders to consume new public OME-TIFF/OME-XML folders

As discussed with @ome/formats, the internal name of the public folders has been changed to public to match the other formats.
This playbook has been deployed so that https://downloads.openmicroscopy.org/images/OME-TIFF/ and https://downloads.openmicroscopy.org/images/OME-XML/ keep working.
Proposing to merge as soon once Travis is green.

Merging as per the description to keep the playbook in sync with the production state.


Any plan to open source swagger schemas ?

This is a...

[x] Feature Request
[ ] Bug Report

Problem:
Thanks for your great work on thingsboard product and the detailed documents!
Since the firewall issue, I couldn't access the Administrator REST API online, any plan to open source the swagger schemas ?
Proposed Solution:
Create a new Repo to open source Swagger Schemas or just open source it in this repo.
Page to Update:
https://thingsboard.io/docs/reference/rest-api/
https://pe.thingsboard.io/swagger-ui.html

You can see the swagger schema by accesing this url:
http://localhost:8080/v2/api-docs?group=thingsboard

Got it, thanks a lot!

You're welcome.


support nested message/list in protobuf data source

Is your feature request related to a problem? Please describe.
current protobuf parser can't parse nested message/list
Describe the solution you'd like
support parse protobuf nested message/list
Describe alternatives you've considered
None
Additional context
None

done


yahoo.no is not being validated

yahoo.no is not being validated, instead it suggests yahoo.ca

This should be fixed now :+1:


Find and Replace Dialog Hangs When Moving Between Columns

Using version 2.9.8

Select a calculated column
Click to focus the expression pane
Press Ctrl+H to bring up Find & Replace dialog
Enter find / replace strings and Replace All
Select another column in the same table without closing the dialog
Click Replace All again
Select another column in the same table without closing the dialog

The Find & Replace dialog hangs as described in #103. I think the problem is that the

N occurance(s) replaced

report appears behind the Find & Replace dialog, rendering the OK button unclickable.

@saviourofdp thanks for reporting - indeed you are correct. When I follow your steps to reproduce, I found that I can hover over the Tabular Editor application icon in the Windows task bar, and this causes the "n occurances(s) replaced" dialog to show up, after which I can close it and continue working. But this is indeed a bug that I'll look into.

Fixed in 2.10.0


Stop using the room ID from the space child state events.

This property was removed in Synapse 1.65 as it was going against the spec.
For more info see https://github.com/matrix-org/synapse/pull/13365 and https://github.com/vector-im/element-ios/issues/6547.

Codecov Report

:exclamation: No coverage uploaded for pull request base (hotfix/0.23.14@7a69ef4). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             hotfix/0.23.14    #1547   +/-   ##
=================================================
  Coverage                  ?   42.08%
=================================================
  Files                     ?      515
  Lines                     ?    84115
  Branches                  ?    37072
=================================================
  Hits                      ?    35401
  Misses                    ?    47677
  Partials                  ?     1037

Help us with your feedback. Take ten seconds to tell us how you rate us.

For more info see matrix-org/synapse#13365

And vector-im/element-ios#5144.


SAML Response

Getting the below error in SAML response
Saml2 error_detail {"error":"Could not validate timestamp: not yet valid. Check system clock."}
Saml2 error ["invalid_response"]

Hi @Akhilb25 - Thank you for your feedback! In order for us to relay your question and feedback to the right team, could you provide us with the URL of the documentation that you were following?

@Akhilb25 Following up on my previous comment above, please let us know if there is a specific MS Doc that your feedback is applicable to so we can address the issue better and more effectively. Otherwise, we'll proceed to close this issue. Thanks.

The issue was with the server clock.
The timestamp of SP and IDP was not synched.
We have synched the server clock and it worked.
Sent from my iPhone

On 05-Oct-2019, at 12:03 AM, Mike Urnun<EMAIL_ADDRESS>wrote:

@Akhilb25 Following up on my previous comment above, please let us know if there is a specific MS Doc that your feedback is applicable to so we can address the issue better and more effectively. Otherwise, we'll proceed to close this issue. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@Akhilb25 Glad to hear that you're unblocked. We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Log4j log correlation: Add unit tests for handing configuration properties.

Codecov Report

Merging #1405 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1405      +/-   ##
============================================
+ Coverage     84.19%   84.23%   +0.04%
- Complexity     1475     1477       +2
============================================
  Files           228      228
  Lines          6795     6795
  Branches        639      639
============================================
+ Hits           5721     5724       +3
+ Misses          888      885       -3
  Partials        186      186

Impacted Files
Coverage Δ
Complexity Δ

...census/implcore/trace/export/SpanExporterImpl.java
91.78% <0%> (-1.37%)
8% <0%> (ø)

...tion/log4j/OpenCensusTraceContextDataInjector.java
90% <0%> (+10%)
18% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25e66b...2ae2cd9. Read the comment docs.


3 9 1

I have picked up this off @EmmaWoodONS .
@ANikolova22 or @uzzelk have requested your review, which I will respond to. No urgency.
One note:
I can’t get the Checks file to run, and get the below error:
“Error in yaml::yaml.load(..., eval.expr = TRUE) :   Scanner error: while scanning for the next token at line 3, column 7 found character that cannot start any token at line 3, column 7”

@uzzelk and @MichaelGNairn, do you want me to have a look at this or would that complicate it at this stage? :D Katie, the code edits/ bug fixes you describe in your latest review message, are they integrated into this branch now?

@ANikolova22 No, I've not changed the code at all on this branch (I created a 3-9-1_review branch on my local repository to do the review as I didn't want to break anything further!)

@uzzelk amazing review, thanks a lot!
When I initially reviewed this for Emma I couldn't get the checks file to work, despite trying numerous things, so I'm very grateful for the work through. I'll implement all of your suggestions tomorrow and hopefully a checks file appears!!
Will update tomorrow

@uzzelk  getting there!
CLicking source on updat eindicator main now gets as far as:
"Quitting from lines 191-205 (3-9-1_checks.Rmd)
Error: Problem with mutate() column difference.
i difference = new - live.
x non-numeric argument to binary operator"
I can't recall having this issue before, and it may be to do with how Emma coded her checks file. Will have a dive later today after a break from checks files!!
Thanks a lot

@uzzelk checks file now producing properly. As expected, Emma had done something clever I couldn't work out, so have stripped it back to be similar style to other checks files.
Hope all running ok now.

Thanks for making the changes to the README.md, it’s much clearer now in terms of what source link is downloading what data.
Code now runs as a whole, and the csv is produced as expected. Have not re-checked values as these were fine last time, and now changes made to the update script.
3-9-1 checks file
Now produces – YAY!
Just a few comments:

Line 3 – Author is still Emma Wood… not sure if this is wrong, but seeing as you rewrote checks file would it make more sense to be in your name?
Line 27 – missing full stop.
Lines 32 – 39 – these seems to be guidance for how to write the checks file, not sure if they’ve been left in by accident. Suggest delete and list specific things that might need to be checked in addition to the QA document (e.g., what is written in quotation marks re provisional values).
Lines 42 – 46 – again, these seems to be guidance for how to write the checks file so suggest deleting.
Lines 54 – 64 – I’m not too sure what this is telling me to do… Or where to find the comparison information in the metadata tab.
Lines 137 – 176 – Unsure why only plots for Region are produced for the QA – I guess because it’s too many to do all the LA’s but maybe a sentence stating that would be helpful (if that is the reason).
Also, in the QA html file, some of the code shows up under the generated plots, that I am not sure if it is meant to be there/what it is for:
Line 185 – “The following example is taken from 13-2-2:” Do you mean the following sentence or the following code? I’m guessing sentence, but if so, not sure what the relevance is to 3.9.1…

Thanks Katie. Think those few final changes have been addressed. Thanks


[cosmetic] set width 9 to 15 on status

tested with PRE_ENABLED

I set width 15 for OUTPOINT_SPENT


[HOLD][$250] Migrate ACHContractStep.js to function component

Class Component Migration
Filenames

[ ] src/pages/ReimbursementAccount/ACHContractStep.js

type: React.Component
has state values: true
has refs: false
has context: false
lifecycle methods: none

Task

We currently have some class components in our codebase that we would like to refactor to a function component.
Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
If you need additional guidance, please ask in #expensify-open-source
Test for any regressions and verify that there are no breaking changes

⚠ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

Heads up, I'm taking this issue off HOLD and making it a Daily. If you are unable to work on it please remove your assignment and add the External + Help Wanted labels as per this update.

I'll decide by tomorrow if I'm going to take internal or release this one

I can work on this if it goes to external.

I can work on this, if you make it external.

I'd like to work on this issue

I'd like to work on this

Thanks for your considering me, @grgia
I will create PR tomorrow.

@multijump The guidelines state that you can work on 1 migration issue at a time and should wait for your previous PR to be merged before you ask for a new one.

Hi, @grgia
I created the PR https://github.com/Expensify/App/pull/20350
Please give me your feedback.
Thanks

@multijump Is already working on one functional migration issue, and another issue has open PR, so we should not assign the same user two issues at a time as per this guideline.
@allroundexperts @grgia

@allroundexperts seeing as both PRs are up, there's no point in unassigning just for someone else to duplicate the work. There are tons of these issues still open, so let's focus on getting them done. That said, @multijump can you please confirm that you understand the rules from now on? For our migration project, you cannot take more than one issue simultaneously, please merge your first issue before moving on to the next.
@allroundexperts are you alright with moving forward with this decision? Please let me know if you feel strongly the other way.

@multijump can you please apply for this job - I am unable to locate your Upwork profile.

Hi, @slafortune
I already applied to this job so I couldn't do again.
Should I withdraw my proposal and apply again?

@multijump I'm having a hard time seeing what profile would be yours - when there isn't a name to match, it makes it hard.  How should I be searching for you?

@multijump I'm having a hard time seeing what profile would be yours - when there isn't a name to match, it makes it hard. How should I be searching for you?

I am sorry for your hard time. @slafortune
Yes, it's me, Oleh K.
Thanks.

Done


Update README.md

Improvement
Update README.md to have more information about the project. Add:

purpose of the project
existing features
incoming features

Done


Adding Illustration for Age

#12
SHORT DESCRIPTION
Setting up illustrations template for Age feature. more features to be added later.
TESTING
move to Illustrations/Age/ and run
python age_accuracy.py

In the plot

@prateekiiest please review


How to Design Resilient Microservices

Proposed title of article
How to Design Resilient Microservices
Proposed article introduction
Even if a microservice application has a 99.9% uptime, a downtime of 0.1 percent suddenly becomes noticeable as use becomes larger. There may be just one failure in a thousand requests, but what about a million? That equates to a total of a thousand missteps.
Microservice applications can't have any failures. Instead, you should concentrate on creating microservices that can gracefully recover from errors and minimize the effect of such failures on your system, which are failure-tolerant.
In this article, we'll look at the causes of failure in a microservice application, how to reduce or minimize their influence on a system, and how to optimize service availability — basically, unique approaches to build and assure a dependable, failure-tolerant microservice.
Key takeaways

Sources of failure
Maximizing service availability
Performance testing

Article quality
In this article we will look at the various points where failures are likely to occur in a microservice application. We will explore the strategies and techniques we can utilize to mitigate the impact of these failures in our system. To make our article unique, we shall see how can we use performance testing methods to validate that our services are truly fault-tolerant, and can recover gracefully.
References
N/A

Thank you for your response and we thank you for submitting your topic. After some careful consideration it struck us that this topic may be a bit over saturated throughout other blog sites and official documentations as previously mentioned on your topic form by our content moderator.
We typically refrain from publishing content that is covered widely on the net or other blogs. As we're more interested in original, practitioner-focused content that takes a deeper dive into programming-centric concepts.

It can be summarized as:
How to Make Your Services Resilient?

Identify Failure Scenarios. ...
Avoid Cascading Failures. ...
Avoid Single Points of Failure. ...
Handle Failures Gracefully and Allow for Fast Degradation.
Design for Failures.
Circuit Breaker Pattern.
Retry Design Pattern.
Timeout Design Pattern.


Fix execute resource with integer user parameter.

Signed-off-by: Pete Higgins<EMAIL_ADDRESS>The execute resource accepts an integer or string for the user parameter. There is some code that attempts to parse a domain name out of the user value that was blowing up if it was passed an integer.
With a simple resource like this:
bash "something" do
  user 501
  code "echo $(id)"
end

Running it would produce output like this:
Petes-MBP:chef pete$ sudo chef-apply test_bash_resource.rb  --log-level=debug
Password:
[2020-07-13T18:09:47-07:00] DEBUG: Reading products and relationships...
[2020-07-13T18:09:47-07:00] DEBUG: Successfully read products and relationships
[2020-07-13T18:09:47-07:00] DEBUG: Searching for the following licenses: ["infra-client", "inspec"]
[2020-07-13T18:09:47-07:00] DEBUG: Found license chef_infra_client at /etc/chef/accepted_licenses/chef_infra_client
[2020-07-13T18:09:47-07:00] DEBUG: Found license inspec at /etc/chef/accepted_licenses/inspec
[2020-07-13T18:09:47-07:00] DEBUG: Missing licenses remaining: []
[2020-07-13T18:09:47-07:00] DEBUG: All licenses present
[2020-07-13T18:09:47-07:00] DEBUG: Running Ohai with the following configuration: {:logger=>#<Mixlib::Log::Child:0x00007fc2061d92d0 @parent=Chef::Log, @metadata={:system=>"ohai", :version=>"16.2.4"}>}
[2020-07-13T18:09:47-07:00] DEBUG: Running Ohai with the following configuration: {:logger=>#<Mixlib::Log::Child:0x00007fc2061d92d0 @parent=Chef::Log, @metadata={:system=>"ohai", :version=>"16.2.4"}>}
[2020-07-13T18:09:52-07:00] DEBUG: Extracting run list from JSON attributes provided on command line
[2020-07-13T18:09:52-07:00] DEBUG: Applying attributes from json file
[2020-07-13T18:09:52-07:00] DEBUG: Platform is mac_os_x version 10.15.5
[2020-07-13T18:09:52-07:00] INFO: Run List is []
[2020-07-13T18:09:52-07:00] INFO: Run List expands to []
[2020-07-13T18:09:52-07:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
[2020-07-13T18:09:52-07:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
[2020-07-13T18:09:52-07:00] DEBUG: NoMethodError: undefined method `include?' for 501:Integer
/Users/pete/work/chef/lib/chef/resource/execute.rb:633:in `qualify_user'
/Users/pete/work/chef/lib/chef/resource/execute.rb:599:in `after_created'
/Users/pete/work/chef/lib/chef/resource_builder.rb:74:in `build'
/Users/pete/work/chef/lib/chef/dsl/declare_resource.rb:318:in `build_resource'
/Users/pete/work/chef/lib/chef/dsl/declare_resource.rb:273:in `declare_resource'
/Users/pete/work/chef/lib/chef/dsl/resources.rb:36:in `bash'
test_bash_resource.rb:1:in `run_chef_recipe'
/Users/pete/work/chef/lib/chef/application/apply.rb:212:in `instance_eval'
/Users/pete/work/chef/lib/chef/application/apply.rb:212:in `run_chef_recipe'
/Users/pete/work/chef/lib/chef/application/apply.rb:227:in `run_application'
/Users/pete/work/chef/lib/chef/application/apply.rb:240:in `run'
/Users/pete/work/chef/chef-bin/bin/chef-apply:24:in `<top (required)>'
.git/safe/../../.bin/chef-apply:29:in `load'
.git/safe/../../.bin/chef-apply:29:in `<main>'
[2020-07-13T18:09:52-07:00] FATAL: NoMethodError: undefined method `include?' for 501:Integer

After this PR I get this output:
Petes-MBP:chef pete$ sudo chef-apply test_bash_resource.rb  --log-level=debug
[2020-07-13T18:10:19-07:00] DEBUG: Reading products and relationships...
[2020-07-13T18:10:19-07:00] DEBUG: Successfully read products and relationships
[2020-07-13T18:10:19-07:00] DEBUG: Searching for the following licenses: ["infra-client", "inspec"]
[2020-07-13T18:10:19-07:00] DEBUG: Found license chef_infra_client at /etc/chef/accepted_licenses/chef_infra_client
[2020-07-13T18:10:19-07:00] DEBUG: Found license inspec at /etc/chef/accepted_licenses/inspec
[2020-07-13T18:10:19-07:00] DEBUG: Missing licenses remaining: []
[2020-07-13T18:10:19-07:00] DEBUG: All licenses present
[2020-07-13T18:10:19-07:00] DEBUG: Running Ohai with the following configuration: {:logger=>#<Mixlib::Log::Child:0x00007f9939127468 @parent=Chef::Log, @metadata={:system=>"ohai", :version=>"16.2.4"}>}
[2020-07-13T18:10:19-07:00] DEBUG: Running Ohai with the following configuration: {:logger=>#<Mixlib::Log::Child:0x00007f9939127468 @parent=Chef::Log, @metadata={:system=>"ohai", :version=>"16.2.4"}>}
[2020-07-13T18:10:24-07:00] DEBUG: Extracting run list from JSON attributes provided on command line
[2020-07-13T18:10:24-07:00] DEBUG: Applying attributes from json file
[2020-07-13T18:10:24-07:00] DEBUG: Platform is mac_os_x version 10.15.5
[2020-07-13T18:10:24-07:00] INFO: Run List is []
[2020-07-13T18:10:24-07:00] INFO: Run List expands to []
Recipe: (chef-apply cookbook)::(chef-apply recipe)
  * bash[something] action run[2020-07-13T18:10:24-07:00] INFO: Processing bash[something] action run ((chef-apply cookbook)::(chef-apply recipe) line 1)

    [execute] uid=501(pete) gid=20(staff) egid=0(wheel) groups=20(staff),12(everyone),61(localaccounts),79(_appserverusr),80(admin),81(_appserveradm),98(_lpadmin),264(_webdeveloper),701(com.apple.sharepoint.group.1),33(_appstore),100(_lpoperator),204(_developer),250(_analyticsusers),395(com.apple.access_ftp),398(com.apple.access_screensharing),399(com.apple.access_ssh),400(com.apple.access_remote_ae)
[2020-07-13T18:10:24-07:00] INFO: bash[something] ran successfully
    - execute "bash"
[2020-07-13T18:10:24-07:00] DEBUG: Exiting

Found by @johnmccrae.

Nice find


refactor CreateMenu to have dynamic items

Details

updated CreateMenu to take a dynamic list of items based on MENU_ITEM_KEYS enum
updated ReportActionCompose to open the original attachment modal when AttachmentPicker is selected

Fixed Issues

Fixes https://github.com/Expensify/Expensify.cash/issues/1508
Tests

log in and click on the + fab to verify list has new items
enter a convo with more than one person to see SplitBill|AddAttachment options when clicking the attach icon
enter a convo with one person to see RequestMoney |AddAttachment options when clicking the attach icon

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Video Walkthrough
https://user-images.githubusercontent.com/12075600/108810552-3ca9c000-7560-11eb-9ed2-ce4325973ec9.mov
Screenshots

Web

Mobile Web

Desktop

iOS

Android

I have read the CLA Document and I hereby sign the CLA

Also, could you update your PR to fix the merge conflict and the description to update the fixed issued link, and I think you mean

enter a convo with more one person to see RequestMoney |AddAttachment options when clicking the attach icon

Enter a convo with just one person?

Tried to test the PR but it doesn't seem like the Add Attachment button is working for me at all even with the timeout

Tried to test the PR but it doesn't seem like the Add Attachment button is working for me at all even with the timeout

hmm looks the change to conditionally render the component with {this.state.isMenuVisible ? ( causes it to not work. going to investigate further.

@Julesssss looks like conditionally rendering using this.state.isMenuVisible causes the component to unmount before it can call onModalHide.
I can fix this by adding:
    componentWillUnmount() {
        this.onModalHide();
    }

let me know if this is fine, otherwise I can revert the conditional rendering.
I haven't been able to get the modals to work without using setTimeout, what's strange is onModalHide is supposed to be the solution to opening a modal once another closes so not sure why it's not working.

@Maftalion ah, lets revert to the previous solution then.
I'm also not sure why the callback doesn't work without setTimeout, it might be worth sharing the issue in the Contributor chat  slack channel to see if anyone else has an idea.

Hey @Expensify/design, would you mind sharing the new plus icon asset that will replace the paperclip icon. Shown in the following screenshot:

Hmm, the setTimeout issue is a tricky one.
I tried looking for a specific callback that was closing  the AttachmentPicker with no luck — the ReportActionCompose Component props aren’t changing (I thought this might be the issue)
finally, the issue might lie within the native AttachmentPicker Component as this issue doesn't exist on web, but I couldn't find anything here either 😞
I’m a bit confused by the nesting of  within   and wonder if this is necessary/could be made simpler?

I’m a bit confused by the reverse nesting of within and wonder if this is necessary/could be made simpler? This isn't in scope for this PR though - yeah, definitely makes it tricky to debug as well
Regarding the plus asset, I noticed we already have it so I can just swap it in. Do you also want the border gone like your screenshot above or is this fine?

@Maftalion your screenshot looks perfect, let's go with that.

Hey @Maftalion. just wanted to check in and provide some guidance for moving forward.
As we'll need to resolve the issue without the setTimeout workaround, the next step will be to locate the cause (bug in Expensify.cash OR bug in external library). If this is an internal bug we should aim to fix it as part of the PR, but in the case where this is an external issue we could leave the PR on hold and mark the UpWork complete.
We would then aim to resolve the issue within the offending library and if this was of interest to you we would treat this as a separate issue and provide an additional payment. Once the library issue is fixed, this PR can be taken off hold and merged.

Hey @Julesssss, I've been unable to get it to work without the setTimeout.
I've tried looking for re-render issues, moving things around and calling the Api directly instead of openPicker but all attempts were unsuccessful.
I then looked into the react-native-image-picker and there seems to be major breaking changes between the current version and the latest so the whole actionsheet would need to be redone in order to test the latest version. But i also tested swapping it out with RN's built in ActionSheetIOS and that led to the same behavior.
Which meant the issue was probably with the modal library react-native-modal. There seems to be a lot of similar issues as this: https://github.com/react-native-modal/react-native-modal/issues?q=is%3Aissue+onmodalhide and a few lead to the same solution of just using setTimeout.

Hey @Maftalion, apologies for the delayed response. Thanks for looking into the modal library and potential solutions.
Lets leave this PR on hold while I try to get the react-native-modal library issue created. I'll update this PR once I have an update.

Hi @Maftalion. I'm sorry for keeping you waiting for so long!
To move forward, we'll merge this PR with the setTimeout workaround.
Would you mind fixing the conflicts with master to finish up here? I'll make sure to add a bonus to the payout as this is due to my delay.

@Julesssss no worries! fixed the merge conflicts

Okay, we're almost there.
I'm going to branch from here to prepare a PR locking the feature behind the new internal IOU Beta flag, once this is completed I will merge this issue and quickly follow it up by merging the beta flag PR.
Should be first thing Monday.

Hello! @Julesssss @Maftalion
We were about to do the QA for this PR and came across this other PR https://github.com/Expensify/Expensify.cash/pull/1548. On the latter the options that we need to test for this one are actually expected to be hidden right?
This would block us from being to execute the steps for this PR.

Hi @isagoico.
Yeah, good point. Let's skip testing for this one in that case. I'll add the test steps to the PR which re-enables the new options.


Changing DISPLAY causes Neovim to hang at launch. Removing NERDTree solves the problem.

Self-Diagnosis

[x] I have searched the issues for an answer to my question.
[x] I have reviewed the NERDTree documentation. :h NERDTree
[x] I have reviewed the Wiki.
[x] I have searched the web for an answer to my question.

Environment (for bug reports)

[x] Operating System: Ubuntu 18.04
[x] Vim/Neovim version :echo v:version: Neovim v0.3.8
[x] NERDTree version, found on 1st line in NERDTree quickhelp ?: 6.7.7
[x] vimrc settings

Plug 'preservim/nerdtree'
Plug 'Xuyuanp/nerdtree-git-plugin'
map <silent> <C-n> :NERDTreeToggle<CR>

Other NERDTree-dependent Plugins

[ ] jistr/vim-nerdtree-tabs
[ ] ryanoasis/vim-devicons
[ ] tiagofumo/vim-nerdtree-syntax-highlight
[x] Xuyuanp/nerdtree-git-plugin
[ ] Others (specify):
[ ] I've verified the issue occurs with only NERDTree installed.

I frequently ssh into a remote Linux system for work. At the moment, the machine I'm using at home is Windows. I access a terminal in WSL, and I use VcXsrv as an X-server. I can successfully run xlogo from the remote machine and see the X logo in Windows. However, X-forwarding over my VPN connection often performs quite poorly.
Lately, I have been running a VNC server on the remote machine and logging in with a VNC viewer. I will usually work from the terminal, and update the DISPLAY environment variable to point to the local VNC server at :1 rather than VcXsrv at :10. However, I found that when I do that, Neovim appears to hang at launch. It makes using Neovim completely unusable. I discovered that commenting out NERDTree from my list of plugins resolved the issue. Alternatively, I can switch my DISPLAY variable back to :10, and everything will go back to normal. However, this is not a viable solution for me.
Does NERDTree connect to the X-server for some reason? If so, why? It doesn't seem like it would need to.
Steps to Reproduce the Issue

Connect to a remote machine over SSH with X-forwarding.
Start a VNC server
Change the terminal environment variable to the VNC display
Run neovim and observe that it hangs
Kill neovim
Comment out NERDTree from the list of plugins
Run neovim again. Observe that it works fine.

No, NERDTree doesn't connect to the X-server, at least not intentionally. Try this:
nvim --startuptime log
<Ctrl-C>  # after a few seconds
# Quit vim if necessary.
less log

If <Ctrl-C> works to stop the hanging, then there may be something useful in the log file. The second column shows the elapsed time in milliseconds for each step. Look for a large number in that column, and copy that line in a new comment in this issue. Or if the file's not too large, and contains nothing sensitive, you could paste the whole thing instead.

Thanks for the quick response. Unfortunately, it looks like the problem is no longer reproducible. My setup changed a bit though.
Normally, I ssh from my work laptop to my work desktop and run tmux there. In some of the tmux panes, I will then ssh to a cloud virtual machine. However, because of a power outage, my work desktop is off, and I haven't been in yet to restart it. Since the power outage, I've been logging in directly to the cloud VM and running tmux there. I guess something about the environment has changed, and now the problem is gone.
I will probably restart my desktop this coming week, and I will try to reproduce the problem then.

Ok, so this is definitely intermittent. It happened earlier today, but I was in the middle of something and couldn't stop to diagnose it. By the time I tried, it had stopped happening.
It just started happening again now. I ran nvim --startuptime log and waited 12 seconds before killing it.. The log file is completely empty... 😕 Any other ideas?

When setting DISPLAY back to :10, it was still taking a noticeably long time to start. Here is the log:
times in msec
 clock   self+sourced   self:  sourced script
 clock   elapsed:              other lines

000.020  000.020: --- NVIM STARTING ---
000.328  000.308: locale set
000.727  000.399: inits 1
000.741  000.014: window checked
000.900  000.159: parsing arguments
001.088  000.188: expanding arguments
001.160  000.072: inits 2
001.848  000.688: init highlight
004.939  002.577  002.577: sourcing /home/hardebj1/.local/share/nvim/site/autoload/plug.vim
018.092  000.027  000.027: sourcing /home/hardebj1/.config/nvim/plugged/vim-fugitive/ftdetect/fugitive.vim
018.587  000.365  000.365: sourcing /home/hardebj1/.config/nvim/plugged/verilog_systemverilog.vim/ftdetect/verilog_systemverilog.vim
018.738  000.063  000.063: sourcing /home/hardebj1/.config/nvim/plugged/Vim-Jinja2-Syntax/ftdetect/jinja.vim
018.909  008.340  007.886: sourcing /usr/share/nvim/runtime/filetype.vim
019.180  000.058  000.058: sourcing /usr/share/nvim/runtime/ftplugin.vim
019.411  000.049  000.049: sourcing /usr/share/nvim/runtime/indent.vim
020.198  000.312  000.312: sourcing /usr/share/nvim/runtime/syntax/syncolor.vim
020.337  000.649  000.337: sourcing /usr/share/nvim/runtime/syntax/synload.vim
020.382  000.893  000.243: sourcing /usr/share/nvim/runtime/syntax/syntax.vim
021.293  000.219  000.219: sourcing /usr/share/nvim/runtime/syntax/syncolor.vim
022.098  000.219  000.219: sourcing /usr/share/nvim/runtime/syntax/syncolor.vim
022.377  000.113  000.113: sourcing /home/hardebj1/.config/nvim/plugged/onedark.vim/autoload/onedark.vim
049.374  028.906  028.355: sourcing /home/hardebj1/.config/nvim/plugged/onedark.vim/colors/onedark.vim
049.402  047.290  006.467: sourcing /home/hardebj1/.config/nvim/init.vim
049.408  000.270: sourcing vimrc file(s)
050.074  000.343  000.343: sourcing /home/hardebj1/.config/nvim/plugged/targets.vim/plugin/targets.vim
050.433  000.219  000.219: sourcing /home/hardebj1/.config/nvim/plugged/vim-easy-align/plugin/easy_align.vim
051.436  000.235  000.235: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/autoload/nerdtree.vim
053.145  000.755  000.755: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/path.vim
053.373  000.155  000.155: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/menu_controller.vim
053.565  000.114  000.114: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/menu_item.vim
053.783  000.134  000.134: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/key_map.vim
054.129  000.272  000.272: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/bookmark.vim
054.459  000.255  000.255: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/tree_file_node.vim
055.102  000.555  000.555: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/tree_dir_node.vim
055.412  000.233  000.233: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/opener.vim
055.781  000.290  000.290: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/creator.vim
055.918  000.066  000.066: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/flag_set.vim
056.161  000.172  000.172: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/nerdtree.vim
056.628  000.396  000.396: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/ui.vim
056.735  000.033  000.033: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/event.vim
056.863  000.055  000.055: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/lib/nerdtree/notifier.vim
057.486  000.544  000.544: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/autoload/nerdtree/ui_glue.vim
061.272  000.134  000.134: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/nerdtree_plugin/exec_menuitem.vim
686.581  624.612  624.612: sourcing /usr/share/nvim/runtime/autoload/provider/clipboard.vim
687.163  625.853  001.241: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/nerdtree_plugin/fs_menu.vim
687.365  000.119  000.119: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/nerdtree_plugin/vcs.vim
688.254  000.731  000.731: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree-git-plugin/nerdtree_plugin/git_status.vim
688.763  638.193  007.091: sourcing /home/hardebj1/.config/nvim/plugged/nerdtree/plugin/NERD_tree.vim
689.673  000.772  000.772: sourcing /home/hardebj1/.config/nvim/plugged/vim-buftabline/plugin/buftabline.vim
690.015  000.215  000.215: sourcing /home/hardebj1/.config/nvim/plugged/vim-obsession/plugin/obsession.vim
690.975  000.840  000.840: sourcing /home/hardebj1/.config/nvim/plugged/fzf/plugin/fzf.vim
692.489  001.351  001.351: sourcing /home/hardebj1/.config/nvim/plugged/fzf.vim/plugin/fzf.vim
692.976  000.288  000.288: sourcing /home/hardebj1/.config/nvim/plugged/LanguageClient-neovim/plugin/LanguageClient.vim
693.488  000.385  000.385: sourcing /home/hardebj1/.config/nvim/plugged/vim-signify/plugin/signify.vim
695.553  001.942  001.942: sourcing /home/hardebj1/.config/nvim/plugged/vim-fugitive/plugin/fugitive.vim
695.876  000.187  000.187: sourcing /home/hardebj1/.config/nvim/plugged/vim-slime/plugin/slime.vim
696.530  000.110  000.110: sourcing /usr/share/nvim/runtime/autoload/provider/pythonx.vim
711.155  000.375  000.375: sourcing /usr/share/nvim/runtime/autoload/remote/host.vim
711.308  015.088  014.603: sourcing /usr/share/nvim/runtime/autoload/provider/python.vim
749.650  038.078  038.078: sourcing /usr/share/nvim/runtime/autoload/provider/python3.vim
750.185  000.094  000.094: sourcing /usr/share/nvim/runtime/autoload/provider.vim
871.048  175.048  121.788: sourcing /home/hardebj1/.config/nvim/plugged/vim-ipython-cell/plugin/ipython-cell.vim
871.664  000.423  000.423: sourcing /home/hardebj1/.config/nvim/plugged/verilog_systemverilog.vim/plugin/verilog_systemverilog.vim
873.045  001.250  001.250: sourcing /home/hardebj1/.config/nvim/plugged/vim-table-mode/plugin/table-mode.vim
873.870  000.288  000.288: sourcing /usr/share/nvim/runtime/plugin/gzip.vim
873.937  000.029  000.029: sourcing /usr/share/nvim/runtime/plugin/health.vim
874.097  000.129  000.129: sourcing /usr/share/nvim/runtime/plugin/man.vim
874.937  000.805  000.805: sourcing /usr/share/nvim/runtime/plugin/matchit.vim
875.313  000.339  000.339: sourcing /usr/share/nvim/runtime/plugin/matchparen.vim
876.148  000.798  000.798: sourcing /usr/share/nvim/runtime/plugin/netrwPlugin.vim
876.492  000.027  000.027: sourcing /home/hardebj1/.local/share/nvim/rplugin.vim
876.507  000.315  000.288: sourcing /usr/share/nvim/runtime/plugin/rplugin.vim
876.724  000.181  000.181: sourcing /usr/share/nvim/runtime/plugin/shada.vim
876.823  000.056  000.056: sourcing /usr/share/nvim/runtime/plugin/spellfile.vim
877.098  000.237  000.237: sourcing /usr/share/nvim/runtime/plugin/tarPlugin.vim
877.270  000.131  000.131: sourcing /usr/share/nvim/runtime/plugin/tohtml.vim
877.363  000.055  000.055: sourcing /usr/share/nvim/runtime/plugin/tutor.vim
877.656  000.254  000.254: sourcing /usr/share/nvim/runtime/plugin/zipPlugin.vim
877.672  003.189: loading plugins
877.801  000.129: loading packages
877.898  000.097: loading after plugins
877.918  000.020: inits 3
880.418  002.500: reading ShaDa
881.422  001.004: clearing screen
881.795  000.372: opening buffers
886.230  004.147  004.147: sourcing /home/hardebj1/.config/nvim/plugged/LanguageClient-neovim/autoload/LanguageClient.vim
886.620  000.169  000.169: sourcing /home/hardebj1/.config/nvim/plugged/LanguageClient-neovim/autoload/LSP.vim
887.010  000.145  000.145: sourcing /home/hardebj1/.config/nvim/plugged/vim-signify/autoload/sy.vim
887.214  000.958: BufEnter autocommands
887.225  000.011: editing files in windows
887.887  000.663: VimEnter autocommands
887.896  000.009: before starting main loop
889.035  001.139: first screen update
889.040  000.005: --- NVIM STARTED ---

It looks like there are 3 long-load items. One is coming from the clipboard and two are coming from NERDTree. Any idea what might be going on?

Can you run top or htop while Neovim is starting up? Is it pegging the CPU? What files does vim have open? Use the lsof command as described here: https://www.cyberciti.biz/faq/howto-linux-get-list-of-open-files/

Nope, it's not pegging the CPU.
 I discovered this after I did :helpgrep startuptime to learn more about its output. Maybe you need that flag to get things to work, or maybe it will disable your clipboard functionality. Just a thought.

It looks like that option doesn't exist in Neovim. I can find it in Vim though.

Check :version for the +X11 feature. Your vim may not have been compiled with that option. To answer your earlier question, I'm only guessing here, but startup may be multithreaded, resulting in column 1 not being the running total of column 2.

Did you try the lsof command yet?

Yes, I already posted it: https://github.com/preservim/nerdtree/issues/1115#issuecomment-623757373
And it looks like the clipboard is handled significantly differently in Neovim. I was able to find -X with :helpgrep in Vim, but there is no such option in Neovim. I searched.

My bad. I see it now; for some reason I disregarded it, thinking it was the top output. I don't think it will help anyway, except to show three Vimscript files still being sourced. I guess that may be good to know.
For some odd reason, my Neovim is reading the Vim help files, so yeah, -X may not be a thing in Neovim. I'll take your word for it.
Try this command, from Stackoverflow, to profile the startup.
vim --cmd 'profile start profile.log' \
    --cmd 'profile func *' \
    --cmd 'profile file *' \
    -c 'profdel func *' \
    -c 'profdel file *' \
    -c 'qa!'

If it writes the log file, it will be huge. Check it for repeated text, or anything that would indicate an infinite loop.

This command produces an output when DISPLAY = :10, but not when DISPLAY = :1.
Thanks for your help. This is frustrating.

Do you think it's worth creating a Neovim issue about this? It seems like this could be some weird intersection of Neovim behavior and NERDTree.

That's probably a good idea. I'm a little out of my element on this one. Put a link to the issue here once you create it, so I can follow its progress.

@bradleyharden , did you create a Neovim issue yet? Do you want to close this one?

I haven't, yet. Sorry. I'm experiencing other weird issues with Neovim when switching between displays. In both cases, it seems to somehow involve the clipboard. It's probably unrelated to NERDTree. You can close this issue if you want. It's up to you. I'll probably reference it in my Neovim issue.

Yes, it seems xsel is the culprit. There are a number of Neovim issues where xsel causes the system to hang. They recommend xclip instead. Installing xclip seems to resolve the issue. I'll have to monitor the problem, though, because it has always been intermittent. Other people seem to observe the same intermittent issues as well. See, for instance, https://github.com/neovim/neovim/issues/9402 and https://github.com/neovim/neovim/issues/7237.


MakerBase MKS Monster8 support

This is a placeholder issue until a fit test is completed.

Fits on carrier with heat set inserts installed. I will try fitting carrier board into case once I'm done printing the rest.

Thanks!


fixes: pid reuse attack when kill a exec process (release/1.1)

As mentioned in #2832, this is the patch for release/1.1
Signed-off-by: Lifubang<EMAIL_ADDRESS>

Codecov Report

Merging #2833 into release/1.1 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/1.1    #2833   +/-   ##
============================================
  Coverage        48.99%   48.99%
============================================
  Files               85       85
  Lines             7603     7603
============================================
  Hits              3725     3725
  Misses            3203     3203
  Partials           675      675

Flag
Coverage Δ

#linux
48.99% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5960cad...190c910. Read the comment docs.

LGTM


Integration won't save API Key

Hi there,
I've tried to search for other people experiencing this, but I wasn't able to find any. When I add the integration and paste in my TeslaFi API Key, it throws a "Unknown error occurred" error.
I tried to search through the logs, but I can't find any references to this integration. I must admit though that I'm about a week into my Home Assistant journey so I don't know where everything is located.
Many thanks.

I've updated my development environment to 2024.3.0, just to confirm that it's working correctly on newer versions, and I'm not seeing any issues currently.
I'm going to need more information to be able to troubleshoot this.

Home Assistant version
TeslaFi integration version
Logs from home assistant when you try to submit the API key:

To make things easy: go there first, and click the "Clear" button at the bottom of the screen. Then try to add the integration with your API key, and then when you see the error message in the dialog, to back to the logs screen and click Download Full Log at the bottom. Do not filter or search in the top search bar, because if there's another error, it might not be attributed to teslafi.
If you still don't see anything in the log at that point, try clicking the Load full log button at the bottom.

Same error here:
Calling the API from a browser returns my VIN number / drives / etc.
V2.4
Core
2024.3.3
Supervisor
2024.03.1
Operating System
12.1
Frontend
20240307.0
logs
Logger: aiohttp.server
Source: /usr/local/lib/python3.12/site-packages/aiohttp/web_protocol.py:421
First occurred: 20:47:27 (1 occurrences)
Last logged: 20:47:27
Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_protocol.py", line 452, in _handle_request
resp = await request_handler(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_app.py", line 543, in _handle
resp = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_middlewares.py", line 114, in impl
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 91, in security_filter_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 25, in request_context_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 79, in ban_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 235, in auth_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/headers.py", line 31, in headers_middleware
response = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/http.py", line 68, in handle
result = await handler(request, **request.match_info)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/decorators.py", line 72, in with_admin
return await func(self, request, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 197, in post
return await super().post(request, flow_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 72, in wrapper
result = await method(view, request, data, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 111, in post
result = await self._flow_mgr.async_configure(flow_id, data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 359, in async_configure
result = await self._async_configure(flow_id, user_input)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 405, in _async_configure
result = await self._async_handle_step(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 551, in _async_handle_step
result = await self.async_finish_flow(flow, result.copy())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 1183, in async_finish_flow
title=result["title"],
~~~~~~^^^^^^^^^
KeyError: 'title'

I don't think this helps, unfortunately. This only shows a Home Assistant error, but isn't showing anything from the teslafi integration. Since it looks like this is happening in HA, it's possible that it might be an issue in your config entry. You can try looking at your .storage/core.config_entries file and search for teslafi. If the entry is there, then it should also have a title property, containing the name of your vehicle. If it's not there, then the error is happening before it can even write the new entry, but I don't see a code path where I could return an entry that does not contain a title.  Unless...

Calling the API from a browser returns my VIN number / drives / etc.

Try this again, and search the JSON data for "display_name". If that is not present, or its value is null, that could be the problem. It should be the name of your vehicle.

If that doesn't help, it may be useful to turn on debug logging for the integration. Normally you can do it from the integration page, but if you're encountering errors adding the integration in the first place, you won't be able to do that. Instead, you can configure the teslafi logger in your configuration.yaml file:
logger:
  default: info
  logs:
    custom_components.teslafi: debug

Reload Home Assistant, and try to add the integration again. Then back in System > Logs, click the "Load full logs" button at the bottom to see the full log file. Then look for anything teslafi related there.
If this still doesn't uncover some information I can use to debug or reproduce the issue, then I'm not sure how else I can help. It works for me, even after removing and readding.

That will likely be the issue then.  I never set up a name for my Tesla.  I could never come up with anything witty enough so left it blank!

Apologies for not replying sooner. I think that'll be my issue too because I never saw the point of giving my car a name! Thanks very much.

Apologies for not replying sooner. I think that'll be my issue too because I never saw the point of giving my car a name! Thanks very much.

Yes - I named the car and it all works.  Thanks all!

I'll be honest: I didn't know that you could choose to leave it unnamed 😂  I thought that was forced when setting it up.
Since it affected both of you - I'll try to add a fallback name instead of just relying on the Tesla display name.


|nbsp| appearing for the .. autonamedtuple:: directive resulting documentation

Description
I just started using the .. autonamedtuple:: directive to begin formatting the namedtuples in some of my projects. And they look great aside from the peculiar |nbsp| appearing between the field index and its short description.
Steps to Reproduce

Implement a collections.namedtuple in source that you would like to document.
Configure Sphinx documentation to use .. autonamedtuple:: for the value.
Build documentation and verify that |nbsp| is used to separate the field index and brief description.

Actual result:

Expected result:
I would have expected something like a paragraph symbol used in place of the nbsp here.

Reproduces how often:
Standard behavior -- appears every time Sphinx is built.
Version

Operating System: Windows 11
Python: 3.11.1
sphinx-toolbox: 3.3.0

Installation source

PyPI

Other Additional Information:
I've identified this as coming from line 401 in sphinx_toolbox/more_autodoc/autonamedtuple.py. It seems like this was perhaps a placeholder, or just a location that Sphinx was intended to swap in an HTML &nbsp character? I would like to suggest that the characters nbsp be replaced with the appropriate content to format a paragraph symbol such as the following:

Thank you so much! I think this is marvelous to have such additional tooling for the Sphinx ecosystem. I desirable, I would be willing to investigate contributing a change to modify nbsp --> <paragraph symbol> myself.

I haven't been able to reproduce this myself. Can you post a copy of your conf.py file?
Sphinx is supposed to substitute |nbsp| for an actual non-breaking space, but for some reason that's not happening.

Sure! Here's the conf.py
# Configuration file for the Sphinx documentation builder.
#
# This file only contains a selection of the most common options. For a full
# list see the documentation:
# http://www.sphinx-doc.org/en/master/config

# -- Path setup --------------------------------------------------------------

# If extensions (or modules to document with autodoc) are in another directory,
# add these directories to sys.path here. If the directory is relative to the
# documentation root, use os.path.abspath to make it absolute, like shown here.
#
# import os
# import sys
# sys.path.insert(0, os.path.abspath('.'))
import os
import sys
import getpass

BASE_PATH = os.path.dirname(os.path.abspath(__file__))

# -- Project information -----------------------------------------------------

project = 'SEL AcSELerator RTAC Python CLI Wrapper'
copyright = '2023, Schweitzer Engineering Laboratories'
author = 'Schweitzer Engineering Laboratories'

# -- General configuration ---------------------------------------------------

# Add any Sphinx extension module names here, as strings. They can be
# extensions coming with Sphinx (named 'sphinx.ext.*') or your custom
# ones.
extensions = [
    'sphinx.ext.autodoc',
    'sphinx.ext.napoleon',
    'numpydoc',
    'sphinxcontrib.confluencebuilder',
    'sphinxarg.ext',
    'myst_parser',
    'sphinx_toolbox.more_autodoc.autonamedtuple',
    #'sphinx_docbook.docbook_builder',
]
source_suffix = {
    '.rst': 'restructuredtext',
    '.txt': 'markdown',
    '.md': 'markdown',
}

# List of patterns, relative to source directory, that match files and
# directories to ignore when looking for source files.
# This pattern also affects html_static_path and html_extra_path.
exclude_patterns = ['_build', 'Thumbs.db', '.DS_Store']

# -- Options for HTML output -------------------------------------------------

# The theme to use for HTML and HTML Help pages.  See the documentation for
# a list of builtin themes.
#
html_theme = 'sphinx_material_sel'

# Add any paths that contain custom static files (such as style sheets) here,
# relative to this directory. They are copied after the builtin static files,
# so a file named "default.css" will overwrite the builtin "default.css".

#html_logo = os.path.join(BASE_PATH, 'SELImage.png')
html_favicon = os.path.join(BASE_PATH, 'selfavicon.png')
html_sidebars = {
    "**": ["logo-text.html", "globaltoc.html", "searchbox.html"]
}

# Material theme options (see theme.conf for more information)
html_theme_options = {

    # Set the name of the project to appear in the navigation.
    'nav_title': '  ',

    # Specify a base_url used to generate sitemap.xml. If not
    # specified, then no sitemap will be built.
    'base_url': 'https://selinc.com/',

    # Specify that the Icon Should use a generic git logo
    'repo_type': "git",

    # Set the color and the accent color
    'color_primary': 'blue',
    'color_accent': 'light-blue',

    # Set the leading text at the top of the index page and others
    "heroes": {
        "index": "Python Bindings for the AcSELerator RTAC CLI",
    },

    # Visible levels of the global TOC; -1 means unlimited
    'globaltoc_depth': 2,
    # If False, expand all TOC entries
    'globaltoc_collapse': True,
    # If True, show hidden TOC entries
    'globaltoc_includehidden': False,
}

# END

I see you have the myst_parser extension enabled. Is the .. autonamedtuple:: directive in a markdown file?

I see you have the myst_parser extension enabled. Is the .. autonamedtuple:: directive in a markdown file?

Yes, the .. autonamedtuple:: appears in a markdown file as such:

I think I've found the problem, then. The `|nbsp| substitution to an actual no-break space seems to be reST specific so isn't happening in markdown.
Can you try installing the fix-nbsp branch (put git+https://github.com/sphinx-toolbox/sphinx-toolbox@fix-nbsp in your requirements instead of sphinx-toolbox)?
I've done away with the substitution altogether and just put the unicode character in directly.

That looks marvelous!!!


How to query PX4 version using MAVSDK

I have used MAVSDK Info plugin to query PX4 version that I am using. Info plugin gives PX4 version 1.13.0, But the exact version of PX4 is 1.13.0beta. Is there any another way to query the exact version of PX4?

Is the information you need not in this struct somewhere?
https://github.com/mavlink/MAVSDK/blob/main/src/mavsdk/plugins/info/include/plugins/info/info.h#L136-L148

@julianoes Yes, It has some information. But If git tag of PX4 firmware is v1.13.0-beta*, Info plugin gives version data until v1.13.0 without beta as flight_sw_patch version in  Version struct is an Int. I could use git hash instead of tag.  Some how Qgroundcontrol managed to query the PX4 version including beta using Additional version type.

I guess the information should be somewhere and we need to decode it correctly in mavsdk.
https://github.com/PX4/PX4-Autopilot/blob/ce609144b0b8058cf4d05dac691c36c4f0a4ffd0/src/lib/version/version.c#L48-L59
https://github.com/mavlink/MAVSDK/blob/7ebcc681eaf425c5426d12bc53b529bb90062f5c/src/mavsdk/plugins/info/info_impl.cpp#L106-L108
Maybe this information is enough for you to figure it out and make a pull request? I'm pretty busy at the moment and can't look into it in detail I'm afraid.


How do I get  contract Standerd_Json_Input. when compiling the contract

when i use this plugin, i want get contract Standerd_JSON_Input.  use json to verify contract in scan.


First internal API for cluster paginated browse

Hi,
This is the API i mentioned in the call, with the first implementation and test case, it's only internal and it will ever be internal so we are free to play around it as we want.
@luigidellaquila  have a quick look to the test case and see if is what you expect
@laa obviusly also an opinion on the style of the API is welcome and a review of the code as well, I expect to merge this, in the long run i expect to push a layer down the implementation so we can limit the "cpm" page loads to 1 per page not as today N+1 per page (counting that a cpm page has ~5k entries we could have 5k less cache hit for this specific case)
Bye

Sure, will do

It's OK for me

hi @laa,
Fixed also with the relative cleanup from codacy, actually the test case reported the problem but i assumed was an issue on the test case :), now should be fine.
Regards


feat: multi lib

Full featured multiple library support, archetypes may now be generated by any supplied lib

Codecov Report
Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.96%. Comparing base (106b88f) to head (c942a16).
Report is 42 commits behind head on main.

Files
Patch %
Lines

alzlib.go
25.00%
1 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   70.66%   72.96%   +2.30%
==========================================
  Files           6        6
  Lines         900      714     -186
==========================================
- Hits          636      521     -115
+ Misses        193      121      -72
- Partials       71       72       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


unify how we allow WelcomeError to interrupt get_code and input_code

Both functions currently do similar things (they stash a Deferred so that _signal_error() can errback it), but they do it in different ways:

input_code stashes a Deferred into self._input_code_waiter
get_code stashes itself into self._get_code, from which we can get ._allocated_d

This got rewritten in #42, but we still need some way for a WelcomeError to interrupt input_code. It's not easy, because we've got a separate thread, sitting in a blocking call to input(). What we really need is a way to tell readline to give up from the outside. I'm pretty sure the low-level python glue has some sort of periodic timer; if it was checking a flag or something, maybe we could write to that flag and tell it to bail.


Implement Into<Vec<N>> for MatrixVec<N, R, C>

Very narrowly addresses @jturner314's proximate issue of getting the Vec out of a Matrix backed by a Vec.
This makes possible something that was previously impossible. However, this change isn't enough on it's own to achieve the ergonomic goals of #479.

Thanks!


feat(module:dropdown): improve NzContextMenuService#create()

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
NzContextMenuService#create() return void，developer cannot listen to view destroy event.
What is the new behavior?
NzContextMenuService#create() will now return EmbeddedViewRef, developers can listen to view destroy event through EmbeddedViewRef#onDestroy().
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

it's ready.

Thanks for contributing. A test case would be better :)


[Bug]About "UploadFile"

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
@PostRouter.post("/file", response_model=Response)
async def UploadSmall(request: Request,
                      document: UploadFile = File(..., alias="document"),
                      password: Union[str, None] = Body(default=None,
                                                        min_length=4,
                                                        max_length=11,
                                                        alias="password")):
    headers = request.headers
    cl = int(headers["content-length"])
    if cl > int(Configs["FILE"]["MAXSIZE"]):
        return FileUploadFail(Msg="超过最大文件限制大小")
    if document.content_type not in allow_type:
        return FileUploadFail(Msg="文件类型不允许")
    name = document.filename.rsplit(".", maxsplit=1)[0]
    if len(await SSR.SelectAllKeys("UPLOAD." + name)) > 0:
        return FileUploadFail(Msg="重复文件名")
    l = document.file.read()
    # Attention: There is a value pass
    md5 = Md5Hex(l)
    print(name, md5)
    ftype = document.filename.split(".")[-1]
    if await SaveFile("./statics/" + md5 + "." + ftype, l) is False:
        return FileUploadFail(Msg="未知错误，请联系开发者")
    temp = {}
    temp["md5"] = md5
    temp["date"] = Now()
    temp["size"] = str(round(cl / 1024 / 1024, 2)) + "MB"
    temp["type"] = ftype
    if password:
        temp["password"] = password
    await SSR.SetKeyValue("UPLOAD." + name, json.dumps(temp))
    await SSR.SetKeyValue("FILE." + temp["md5"],
                          "./statics/" + md5 + "." + temp["type"])
    return FileUploadSuccess(Data=SSFile(
        Name=name,
        Date=temp["date"],
        Size=temp["size"],
        Type=temp["type"],
    ))

Description
I'am uploading pics, but one pic cant be uploaded, other pics can be uploaded.
Here is the  error pic

Operating System
Linux
Operating System Details
Ubuntu 20.04
FastAPI Version
0.85.0
Python Version
Python3.8.2
Additional Context

First Check

[x]  I added a very descriptive title to this issue.
[x]  I used the GitHub search to find a similar issue and didn't find it.
[x]  I searched the FastAPI documentation, with the integrated search.
[x]  I already searched in Google "How to X in FastAPI" and didn't find any information.
[x]  I already read and followed all the tutorial in the docs and didn't find an answer.
[x]  I already checked if it is not related to FastAPI but to Pydantic.
[x]  I already checked if it is not related to FastAPI but to Swagger UI.
[x]  I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[x]  I commit to help with one of those options 👆

Example Code
@PostRouter.post("/file", response_model=Response)
async def UploadSmall(request: Request,
                      document: UploadFile = File(..., alias="document"),
                      password: Union[str, None] = Body(default=None,
                                                        min_length=4,
                                                        max_length=11,
                                                        alias="password")):
    headers = request.headers
    cl = int(headers["content-length"])
    if cl > int(Configs["FILE"]["MAXSIZE"]):
        return FileUploadFail(Msg="超过最大文件限制大小")
    if document.content_type not in allow_type:
        return FileUploadFail(Msg="文件类型不允许")
    name = document.filename.rsplit(".", maxsplit=1)[0]
    if len(await SSR.SelectAllKeys("UPLOAD." + name)) > 0:
        return FileUploadFail(Msg="重复文件名")
    l = document.file.read()
    # Attention: There is a value pass
    md5 = Md5Hex(l)
    print(name, md5)
    ftype = document.filename.split(".")[-1]
    if await SaveFile("./statics/" + md5 + "." + ftype, l) is False:
        return FileUploadFail(Msg="未知错误，请联系开发者")
    temp = {}
    temp["md5"] = md5
    temp["date"] = Now()
    temp["size"] = str(round(cl / 1024 / 1024, 2)) + "MB"
    temp["type"] = ftype
    if password:
        temp["password"] = password
    await SSR.SetKeyValue("UPLOAD." + name, json.dumps(temp))
    await SSR.SetKeyValue("FILE." + temp["md5"],
                          "./statics/" + md5 + "." + temp["type"])
    return FileUploadSuccess(Data=SSFile(
        Name=name,
        Date=temp["date"],
        Size=temp["size"],
        Type=temp["type"],
    ))

Description
I'am uploading pics, but one pic cant be uploaded, other pics can be uploaded.
Here is the error pic
Operating System
Linux
Operating System Details
Ubuntu 20.04
FastAPI Version
0.85.0
Python Version
Python3.8.2
Additional Context

I have already find solution in stackflow, but it doesn't work. here https://stackoverflow.com/questions/62418392/size-of-pdf-breaks-fastapi-using-python-multipart

I assume you solved it, thanks for closing the issue 👍

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

I assume you solved it, thanks for closing the issue 👍

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

Yeah, It's postman's bad.


Add demo scene.

Now it's operational, but I have to add demo and quick tutorial.

Yes.. I got a project which ends in June~July. After that, I'm gonna update repo with new syntax and manuals, which "actually usable".

It's been a long time. 😂 I add a demo scene.


Create codereview

Great start! I like how you have set up the project, was easy to read through the code and get an understanding of what was happening.


When sorting RowHeader, sorting the CellItems too

it was a missing part of the work on sorting.
In order to keep the dataset up-to-date, the cells has to be sorted too, when rowheaders are sorted. (just like we do when sort by column, we sort the rowheaders, to keep everything aligned)
I also added an option to disable DiffUtils animation

Ready to merge, it is the missing part of previous work done on sorting.


Proposed API Price Lookup

Using coindesk API look up the current price of bitcoin.

Thank you very much for this contribution!


Incorrect content-type parsing in actions

Describe the bug
When using a simple fetch to an endpoint like so:
fetch('/login', {method: "POST", body: new URLSearchParams('key', 'value')})
This is sent by Chrome and Safari as a POST request with the following content-type header:
Content-Type: application/x-www-form-urlencoded;charset=UTF-8
But https://github.com/sveltejs/kit/blob/master/packages/kit/src/runtime/server/page/actions.js checks the content-type value by splitting on "; " (note the space).
Therefore I cannot use the above fetch call because the endpoint returns:
Actions expect form-encoded data (received application/x-www-form-urlencoded;charset=UTF-8)
I think this is a bug and that you should instead split on ";" (without space).
Reproduction
Use a simple fetch to an endpoint (/login/+page.server.js) like so:
fetch('/login', {method: "POST", body: new URLSearchParams('key', 'value')})
Logs
No response
System Info
any system

Severity
serious, but I can work around it
Additional Information
No response

I'll fix this. The easy solution would be to split on ; and trim the results. Any objections?

Any objections?

It would be nice to add tests

Whatever we do here, we should probably also do for the content type check that's part of the CSRF protection, if appropriate.

is this also related to https://github.com/sveltejs/kit/issues/7112 ? i guess not right?

Thanks for such a quick fix, great job.


Vulnerability issue

Hi I'm facing a High risk warning issue when i tested my app for vulnerability scan and that issue is occur in every React native app. Is there anyone who solved this issue thanks.
Description:
The mobile application uses weak hashing algorithms. Weak hashing algorithms (e.g. MD2, MD4, MD5 or SHA-1) can be
vulnerable to collisions and other security weaknesses, and should not be used when reliable hashing of data is required.

Could you please paste an exact copy of the output you're concerned about?

@chrisbobbe can you please elaborate that what are the further steps you need.

Closing as stale


Encoder.forward(..) seems to return the output of Encoder n-times

In a multi-GPU setting, trainer.get_model().encoder.forward(..) seems to return the output of the encoder n-number of times. Where n is the number of GPUs that is in use. Is my observation right? What is its implication?

I don't understand, can you please clarify what this means, preferably with an example?


can't clone format-benchmark - fails to find cppformat/sphinx_rtd_theme

git clone --recursive https://github.com/cppformat/format-benchmark.git
fails at
'Clone of 'https://github.com/cppformat/sphinx_rtd_theme.git' into submodule path 'doc/sphinx_rtd_theme' failed'
Repo deleted and not found, so perhaps update to use cppformat lib from a few days after 1.0 when you had removed that sub-module.
Sorry I can't check it out to give you a pull request!

Fixed in https://github.com/cppformat/format-benchmark/commit/4bbdc8bacef05a8f87320c67ec31b9c8188afef8. Thanks for catching this.


High token usage via OpenRouter

Description
Dear all,
I have been using big-AGI for a while and I love it.  I didn't install it but use the provided web interface with my open OpenRouter api key (gpt-4o)
I observed high usage cost in OpenRouter and try to figure out what's the problem.
I figured out that for the same simple question, my prompt's token usage via big-AGI is 10 times more than other similar services.
For example:
I type "Hi" in the general default mode in big-AGI as my input prompt, the token is "20,402" in OpenRouter record
I type "Hi" in chatbox (web.chatboxai.app) as my input prompt, the token is "1,996"
for "how are you?" in big-AGI: input token is "20,423"
for "how are you?" in chatbox: input token is "2,008"
I wonder if I have done something wrong in the settings?
Best,
Jake
Device and browser
macos 12.7.1
firefox browser 130.0.1 (64-bit)
Screenshots and more

Willingness to Contribute

[ ] 🙋♂ Yes, I would like to contribute a fix.

(from the i in Tokens Column)
The number before the arrow is the number of tokens in the prompt (or all messages you sent, including previous history).
The number after the arrow is the number of tokens in the completion.
Different models tokenize text in different ways. They usually represent between 2 to 4 characters.
If you select the session under Provider in OpenRouter  you will get the particulars as well as the generation ID which you can review for the exact API call

(from the i in Tokens Column) The number before the arrow is the number of tokens in the prompt (or all messages you sent, including previous history). The number after the arrow is the number of tokens in the completion. Different models tokenize text in different ways. They usually represent between 2 to 4 characters.
If you select the session under Provider in OpenRouter you will get the particulars as well as the generation ID which you can review for the exact API call

Thank you for the explanation. After clearing the history everything is back to normal.
Jake

(from the i in Tokens Column) The number before the arrow is the number of tokens in the prompt (or all messages you sent, including previous history). The number after the arrow is the number of tokens in the completion. Different models tokenize text in different ways. They usually represent between 2 to 4 characters.
If you select the session under Provider in OpenRouter you will get the particulars as well as the generation ID which you can review for the exact API call

Thank you for the explanation. After clearing the history everything is back to normal.
Jake


Init new ldap server... fails when having a secret in kube

ldap dosn't create a db when working with secrets.
*** ------------------------------------------ Database and config directory are empty... Init new ldap server... invoke-rc.d: could not determine current runlevel invoke-rc.d: policy-rc.d denied execution of stop.

one problems seams to be a missing config in startup.sh
slapd slapd/invalid_config boolean false
EOF

my fault....setting ldap domain in the wrong format. I wrote dc=blabla,dc=org instead auf blabla.org


rtc backup access is not enabled twice

Some of st code does this on stm32wb, but this only seems to be done once in embassy:
    HAL_PWR_EnableBkUpAccess(); /**< Enable access to the RTC registers */

    /**
     *  Write twice the value to flush the APB-AHB bridge
     *  This bit shall be written in the register before writing the next one
     */
    HAL_PWR_EnableBkUpAccess();

cc @MathiasKoch

our equivalent statement is crate::pac::PWR.cr1().modify(|w| w.set_dbp(Dbp::ENABLED));

Is this a specific edge case around stm32wb?
I don't think I have ever seen it for my stm32l4?


Dir.children only exists in ruby 2.5

But we are using Ruby 2.5, no? https://github.com/Fryguy/manageiq-cross_repo/blob/master/.travis.yml#L4

@Fryguy he was trying to use this locally

Ok, we should just make the minimum required 2.5, then.


Fix for issue #21: allow loading keystores with trailing data

cfr. Issue #21
Portecle is able to load JKS, JCEKS and BKS keystore files that have trailing data, so we should aim to be able to load them as well. This patch fixes hash/HMAC checks to no longer assume that they are present at the last N bytes of the input data, but instead to look for them immediately following the location where entry parsing stopped.
This also allows the loader to detect when a given keystore file is truncated and has a signature or HMAC of insufficient size. (And this exposed a bug in the manually-constructed BKS stores in the test routines checking for bad formats).

Looks good. Merging, will post back here when a new version hits PyPI.

Cool :) (Don't forget about the _version_ and _versioninfo_ attributes in jks/jks.py when bumping versions btw!)

Thanks for the reminder! PyJKS 0.5.0 is now uploaded and I've started a CHANGELOG.


Crash on call to minetest.is_protected

I installed this on a private server running MeseCraft, had to comment this line out to prevent the server from crashing: init.lua#L154
The following error occur when placing a block:
2023-08-29 13:31:27: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'extended_placement' in callback environment_Step(): ...minetest/games/mesecraft/mods/MODULES/protector/init.lua:400: attempt to index local 'pos' (a nil value)
2023-08-29 13:31:27: ERROR[Main]: stack traceback:
2023-08-29 13:31:27: ERROR[Main]:   ...minetest/games/mesecraft/mods/MODULES/protector/init.lua:400: in function 'is_protected'
2023-08-29 13:31:27: ERROR[Main]:   ~/.minetest/mods/extended_placement/init.lua:154: in function 'do_player_placement_checks'
2023-08-29 13:31:27: ERROR[Main]:   ~/.minetest/mods/extended_placement/init.lua:176: in function <~/.minetest/mods/extended_placement/init.lua:169>
2023-08-29 13:31:27: ERROR[Main]:   /usr/share/minetest/builtin/game/register.lua:446: in function </usr/share/minetest/builtin/game/register.lua:432>

Seem like new_pos is nil because it's never defined, but I'm not sure what variable is holding the expected value.

Crash has been fixed, AFAICT, but I'll leave this issue open, in case I'm checking the wrong location for the check. Basically a 50/50 I have the right one (target.above instead of target.under), but I'm pretty sure I have the right one. Feel free to get back to me after testing to ensure it's properly respecting protections and that it's not preventing building into unprotected space from a block on the edge of a protected area.

Thanks for looking into my issue. As soon as I have some time I will do some testing and report back!

Given that I've not heard anything further, I'm closing this under the assumption that my changes have fixed the original issue.


403 OPTIONS  "/api/generate"

Hi!
Just tested this and noticed it does a  OPTIONS  "/api/generate" request. From what I can tell this doesn't exist in latest ollama code...
Thoughts?

Hi there,
Browsers often send an OPTIONS request to verify CORS, which might be the case here. Were there any other issues caused by the OPTIONS request?
Thanks.

Well, I get that asking something trying to generate something, but it seems to stop there so nothing else happens.

Could you please provide any specific error messages or logs that you encounter during the process? This information would greatly assist me in diagnosing the problem more accurately and providing you with the appropriate guidance.
Thanks.

How do I get better logs? I tried typing something, pressed enter, and then nothing.

Hi there,
To obtain more detailed logs, you can use the following command for Docker:
docker logs ollama-webui

Additionally, it would be helpful for diagnosing your issue if you could provide a screenshot of your console logs from your browser's developer tools. This will allow us to examine any client-side errors or issues that might not be visible in the server logs.
Please feel free to share the Docker logs and the browser console logs screenshot, and we'll do our best to assist you in resolving the problem.
Thanks.

@Chillance Part of the reason that browsers invented CORS Preflight Requests (the OPTIONS issue) is to prevent people from stumbling into security issues.
Do you already have the access protected with an API token or HTTP Basic Auth?
Check out https://github.com/jmorganca/ollama/issues/849#issuecomment-1773697189 and the CORS section at https://webinstall.dev/caddy.

I have an example of how I did it in #10

I don't do anything particular but just staring the ollama serve. And, on the same machine I run this in docker.
docker run --network=host -p 3000:3000 --name ollama-webui --restart always ollama-webui
I actually  got chatbot-ollama (other repo) working fine. But here I can see this in the console log:

e87e0c1f-4d67-4015-959a-0e2b59659483
2.fb1b6367.js:52 submitPrompt
<IP_ADDRESS>/:1 Access to fetch at 'http://<IP_ADDRESS>:11434/api/generate' from origin 'http://<IP_ADDRESS>:3000' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
start.93b882e2.js:1
   POST http://<IP_ADDRESS>:11434/api/generate net::ERR_FAILED

window.fetch @ start.93b882e2.js:1
R @ 2.fb1b6367.js:52
await in R (async)
re @ 2.fb1b6367.js:58
start.93b882e2.js:1
   Uncaught (in promise) TypeError: Failed to fetch
at window.fetch (start.93b882e2.js:1:1402)
at R (2.fb1b6367.js:52:108120)

And
docker logs ollama-webui
only returns:
Listening on <IP_ADDRESS>:3000

Your logs confirm the CORS error as expected, you should pull the latest commit of the main branch and build the docker container. It introduces breaking changes so your command should be replaced with the following instead:
docker build --build-arg OLLAMA_API_BASE_URL='' -t ollama-webui .
docker run -d -p 3000:8080 --name ollama-webui --restart always ollama-webui

Also make sure to run the following command to serve Ollama, which should solve your issue:
OLLAMA_HOST=<IP_ADDRESS> OLLAMA_ORIGINS=* ollama serve

Thanks.

Thanks! Works now!


Allow friends to join private battles without a password

I want to allow friends to join private lobbies without having to enter a password.
This should be easy by bypassing the password requirement when the gatekeeper of a lobby is set to friends.
General Idea:
https://github.com/beyond-all-reason/BYAR-Chobby/issues/654

All right, thanks for doing this! Happy to unblock chobby on it, it should be deployed within the week :)


Extend SecHub CodeScan report parts to have an explanation field  inside JSON report

As a developer having a SecHub JSON report, I want to have an explanation field in JSON about the finding.

TODOs

change the internal sereco report model
provide explanation field(s) also in sechub report JSON model

Still to DECIDE

decide which kind of format we will put in (e.g. many products provide a HTML explanation - do we really want to insert HTML here?!?!)
decide structure e.g. just a

 "explanation" : "i am the explanation"

or something like
"explanation": {
         "text": "plain text" ,
         "html" : "html content",
         "links": ["https://owasp.org/topten/xyz"]
 }

the latter one would be nice because we could provide different possibilities (of course those should be optional).
But it would be easier to implement and use - e.g. in plugins - so prefereable

Albert Tregnaghi<EMAIL_ADDRESS>Daimler TSS GmbH, imprint

In my opinion, we should not support HTML itself. However, besides plain text we could support massages in AsciiDoc and/or markdown. For an inspiration: the SARIF format supports messages in plain text and markdown: https://github.com/microsoft/sarif-tutorials/blob/main/docs/3-Beyond-basics.md#more-about-messages
In addition, it would be nice to have an optional language field, for both the explanation text (description) and the links. Maybe, the explanation can look like this:
"explanation": {
         "descriptions": [
                {
                  "text": "plain text" ,
                  "asciidoc" : "asciidoc content",
                  "markdown": "markdown content",
                  "language": "de"
                },
                {
                  "text": "by default we assume English as language for a message"
                }
          ],
         "links": [
                 {
                   "link": "https://owasp.org/de/topten/xyz",
                   "language": "de",
                },
                {
                   "link": "https://owasp.org/topten/xyz"
                }
          ]
 }

Will be solved with #510

Will be solved with #510


docs(guide/Providers): describe your change...

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
Highlights the important notes

Highlighted the one important note

I don't feel like this is so important in this context. This is an introduction to providers and there are much more important concepts for the target audience of the guide, imo.
In any case, we can't merge this without a signed CLA.