Graphics improvements and code cleanups

Pull Request checklist
Note: these are not necessarily requirements

[x] I reformatted the code with clang-format (mostly)
[x] I checked to make sure my submission worked
[x] I am the author of submission or have permission from the original author
[ ] Requires update of the PS2SDK
[ ] Requires update of the gsKit
[ ] Others (please specify below)

Pull Request description

Add HIRES compile option, disabled by default. Compile with HIRES=1 for HIRES version. That will provide true 1080i and 720p support (no scaling!)
Code cleanups
Scaling and aligning improvement
Alpha blending fix for 16bit modes, fixes the visible "transparant" box around png images

OMG, YES! Finally it gets merged into ifcaro's repo! :)
Now that finally makes OPL a real '0.9.5'... Erm... '0.9.4' 😀

The versioning in OPL is: VERSION.SUBVERSION.PATCHLEVEL.
As I understand it each bugfix or small improvement should increment the PATCHLEVEL, and each new feature should increment at least the SUBVERSION. Perhaps incrementing the version can be added to the Pull Request checklist?
In my opinion the version should have become '1.0.0' a long time ago. Then PADEMU would have become '1.1.0' and HIRES would have become '1.2.0'... but that's too late now.
 Or '1.0.0'?

Well, I suppose we can say, that the patch-level shifted since '0.9.1'... It possibly should be '1.5' already. :-D
Anyway... IMO a '0.9.4' would be fine. People are used to the kind of revisioning and most who work on it PROBABLY would prefer that.
Maybe @RandQalan or @SP193 can create a poll on Psx-scene.com?

IMO whenever we ask for input on psx-scene, we'll just get input from users who may just choose whatever that is convenient, but not necessarily the best. In fact, I feel that the meaning of commits was long tainted. It was also my fault, as I had a habit of mega-commits. So each commit became a major change.
Now it could be even at a stage where each commit becomes a release.
Then we also have this topic of how development (the commits in-between) versions are identified. In the past, people used to just go with revision numbers (e.g. r681). But ever since we moved to Git/Mercurial, that is not so correct (since the revision numbers are not unique to each branch or fork).
Now, we identify commits/trunk builds by their hashes. Some people still go with the old method, however.
So if we change the way version numbers are written and update them with every commit, I see these implications: more work for contributors, how to tell when the minor version values should be increased and whether people will take each minor version increment over-seriously or not at all?
Whenever I made new release for FMCB, it eventually reached a point where I wasn't intending to add new features and some releases had more refinements than new features that were worth a totally new installation. I tried to indicate that by giving such a release a very small version increase... but people either upgraded right away or never moved up since a long time ago. I think the problem here is that the users are gamers... so such information may not even be useful to them.
I do not know what @ifcaro or Jimmikaelkael intended for the version numbering, but perhaps they also viewed "v1.0" as the stable version. Hence OPL cannot be a v1.0 since it was in development all this while.
It was originally just a major and minor. The major was always 0, while the minor was increased with every release. When we hit 0.9, when it might have been that point where we just started to avoid calling any new version "v1.0". In a way, you could say that the version numbers did not really carry much significance, other than just indicating when they were made.
But it could be a good thing since we'll eventually run out of numbers at v0.9.9 lol. We should just decide if it's worth changing and stick to the version numbering system. If necessary, encourage people to move over.

Regarding cd48fb7: you have removed DETAILED_CHANGELOG as well.
It didn't occur to me, but we did have redundancy with the version control management system...
@ElPatas1, so with this, it would also mean that DETAILED_CHANGELOG should be generated only when a release is to be made, only so you can include DETAILED_CHANGELOG in a package.
For us who have access to this Git repository, we can see the commit history with "git log".

DETAILED_CHANGELOG is a generated file, but it wasn't being generated automatically. This caused the build version number to almost always be wrong becouse the build version was generated from the DETAILED_CHANGELOG file. With this change the build version is calculated with 'git rev-list --count', so it's always correct.
Another problem with DETAILED_CHANGELOG is the enless-dirty-build-loop. After each commit, the DETAILED_CHANGELOG needs to be re-generated. But re-generating the DETAILED_CHANGELOG causes the build to become dirty. The only way to fix the dirty build, is to commit DETAILED_CHANGELOG... but then the last commit is (once again) missing from the DETAILED_CHANGELOG.
I fixed the Makefile so now DETAILED_CHANGELOG will be generated on every build. So after every build, there is an up-to-date DETAILED_CHANGELOG file. And in every release, there can still be an up-to-date DETAILED_CHANGELOG file.
The only 'downside' I can see is that this file can no longer be viewed on github, but instead github can show every commit in a much nicer interactive way, so why would anyone want to?

@SP193: Well, I mentioned psx-scene.com, because it technically is (still) the development-board... ;)
I agree, that some user-ideas are bollock from a developer-perspective, however...
I think that a 0.9.4-release would be fine! I think an 'Open Beta Test' would be neat, tho' to fix some issues, before implementing ANY new features!
The list of new features and fixes is soooo freakin' long, that it is hard to keep track on/of it!
The SDK-Updates, the HiRes-Implememtation and stuff like this are worthy a new release alone!
@rickgaiser THX for the fix! That was some annoying issue! 😁 I ever wondered, why it did not take the revision from another source (but I am a lazy guy, sometimes)! ^^
THX @ElPatas1 for merging it into the main-repo/fork!

I compiled the OPL and appears some fatal errors:

Although the compilation ends fine and the build works fine, but this is normal than
now appears all this lines of fatal errors?
Another question, is not to be supposed that the DETAILED_CHANGELOG now is generated
automatic when is compiled the OPL?
Because when i compiled it do not creates any DETAILED_CHANGELOG file.
What i made for compile the OPL is download the package and compile it locally which
is what i made always.
Best regards

I suppose it can't get the revision that way, during compilation/compile-time?!

DETAILED_CHANGELOG is not generated automatically when I do a build, but is now being generated correctly if I run make_changelog.sh.
@ElPatas1 your local repository has some changes to it, which might be causing the problem.

@ElPatas1 it is not possible to correctly build OPL without git. The git command was already used in the build process, but now it's also used for calculating the revision number:
$(shell git rev-list --count HEAD) + 2
As a result, your revision number is now '2'
Other things that should not have worked before without git are the calculation of the '-dirty' flag. And ofcourse, the git revision itself.
@sp193 The DETAILED_CHANGELOG is only generated when you do a make release. More specifically, it is a dependency for creating the .zip file, becouse that is where it's needed.
So it's not generated on 'every build' as I mentioned before, sorry for the confusion.

If i understood well is not possible have the revision number and other things if the OPL
is compiled locally.
For compile from the repository this is the correct execution?:
cd $HOME && rm -rf open-ps2-loader && hg clone https://github.com/ifcaro/open-ps2-loader && cd open-ps2-loader && make rebuild
And which is the correct way for run the "make_changelog.sh"?
Best regards.

Yes, this only works if you 'fetch' the file online...
I  thought 'make_changelog.sh' is a started during compilation?!

@ElPatas1 The first time:
cd $HOME
rm -rf open-ps2-loader
git clone https://github.com/ifcaro/open-ps2-loader
cd open-ps2-loader
make clean release

Every time after that:
cd $HOME/open-ps2-loader
git pull
make clean release

make rebuild does not generate a .zip file, so it also does not run ./make_changelog.sh. You can manually run ./make_changelog.sh any time you like to generate a new DETAILED_CHANGELOG.

@ElPatas1 : I noticed that you're using hg instead of git. Since we're using Github, we're using git instead of Mercurial's hg.
When you can, please install git and use it instead. The syntax is different, but we all had to make that change before (from SVN to Mercurial, now to Git).
I will be continuing this conversation with you via e-mail.

Thank you very much! now is working fine, just a little detail, i compiled two versions with this features:
VMC, GSM, CHEAT, PADEMU
VMC, GSM, CHEAT, PADEMU, HIRES
I noticed that in the case of the HIRES feature do not appears in the "About screen", and
because in both compilations the options of 720p and 1080i are available in the menus for
choose, i'm not sure if really the one with HIRES is compiled with this option, and
if the 720p and 1080i are working fine without scaling.
I mean, maybe would be good that this feature appears informed in the upper right part of the
screen in the about screen like the other features, or is nothing important.
Best regards.

I tried to compile it this morning and it compiled successfully. I haven't had time yet, to test the ELF however.
Regarding HIRES: Well, I would like to ask... Why it should be a veritable in the first place? For testing-reasons?
Why not just have both choices (scaled and not scaled) in one build, with the choice simply being in the settings... (and without the HIRES-Var as a compile-option, because it would not be necessary then)
I don't want to complain... I just want to understand the reson for/behind it. ;)
Best regards,
TnA

@ElPatas1 One way of knowing if you've got the HIRES version is by checking the resolutions. Without HIRES 720p and 1080i are scaled. With HIRES, they are not. This is visible when selecting the resolution:
        , "PAL 640x512i @50Hz 24bit"
        , "NTSC 640x448i @60Hz 24bit"
        , "EDTV 640x448p @60Hz 24bit"
        , "EDTV 640x512p @50Hz 24bit"
        , "VGA 640x480p @60Hz 24bit"
#ifdef HIRES
        , "PAL 704x576i @50Hz 24bit"
        , "NTSC 704x480i @60Hz 24bit"
        , "EDTV 704x480p @60Hz 24bit"
        , "EDTV 704x576p @50Hz 24bit"
        , "HDTV 1280x720p @60Hz 16bit"
        , "HDTV 1920x1080i @60Hz 16bit"
#else
        , "PAL 704x576i @50Hz 16bit"
        , "NTSC 704x480i @60Hz 16bit"
        , "EDTV 704x480p @60Hz 16bit"
        , "EDTV 704x576p @50Hz 16bit"
        , "HDTV 1280x720p @60Hz 16bit scaled"
        , "HDTV 1920x1080i @60Hz 16bit scaled"
#endif

Every compile option should be visible in the about screen, I'll add it.
@TnA-Plastic That's a good point. I would really like this option to be a runtime setting, instead of a compile time setting. There's a lot more compile time settings I would love to have as a runtime setting. Becouse now we have 6? compile time settings. So that means we can build 2^6=64 different versions of OPL.

Well, actually there are even more...
VMC, IGS, GSM, PADEMU, HIRES,...
I am not sure, if PS2Logo, PS2RD or IGR still have their compile-vars...
The VMC-var was implemented, because there have been issues in the past with some games, when OPL was build with VMC-Support (even if it was not enabled in the settings).
I suppose it does/did add some stuff somewhere in RAM anyway (in-game), even when the option in the per-game-settings was 'off'...
'PADEMU', 'IRG', 'PS2RD' possibly suffer from the same issue...
'IGS' is not stable AFAIK...
All of these Vars are related to in-game-things or issues caused in-game by these functions! ;)
HIRES however is GUI-depended only, but MIGHT cause issues in-game, due to something 'left in an unwanted state' (de-/re-init-issue during VMODE-change in the beginning of a game, or whatever), if there is/are any of such...
Then there are the debug-options... O.o

@rickgaiser, aha, i don't noticed before the word scaled in the resolutions without hires, thank you.
Best regards.

Currently testing the new changes made to the ifcaro repo...
Nice job on the changelog fix, now we don't need to run it each time, so it represents the new repo version when we commit new changes to it.  One less step for us.
For those that use a msys/mingw Windows Compiling Environment, does anyone know how to make the Zip function work, when we later want to run a make release command?
About the HIRES feature, has anyone tested it using the INFO page feature enabled and also loaded a custom theme that displays background image of the game (_BG), plus the theme has a transparency PNG background at the same time?   And then using the following two new HIRES display options:
HDTV 1920x1080i @60Hz 16bit
HDTV 1280x720p @60Hz 16bit
It seems to show some horizontal large graphic issues when going back and forth from the Main and Info page and if I do it a few more times, it will freeze up the OPL GUI -- and then have to hard reset the PS2.
A good test for such a custom theme would be this one from my collection or any other custom theme that has the same type of transparency background and also displays the game's ART background (I know there are lots of them--just can't remember one from the top of my head at the moment): http://www.ps2-home.com/forum/viewtopic.php?f=51&t=112
I will later post a screenshot of what the GUI looks like with this graphical issues at the end of this thread: http://www.ps2-home.com/forum/viewtopic.php?p=27448#p27448  -- once I push the new changes at PS2-HOME for others to test as well to see if others experience the same issue with the new HIRES changes.
Unless the new changes above require us to update PS2SDK on our end?  If yes, let us know???  The last PS2SDK update on my end was commit: d5ce63a

@Jay-Jay-OPL why have you not learned look at changes to sdk
@sp193
sp193 committed 3 days ago

By the way, was there any reason why the high-resolution stuff had to be made into a compile-time option? If it works well, you might want to consider just making it part of OPL.
We've got a number of compile-time options because some of these features cause weird problems just by being around... :(
I think @Jay-Jay-OPL is just interested in OPL, so he doesn't want to bother with rebuilding the PS2SDK. But to answer his question, the late commits were all for the proper functionality of network support. So while they will likely not affect @rickgaiser's work, they will probably make network support of OPL work better.

@Jay-Jay-OPL:
Your environment is probably lacking zip&unzip.
You can install it via 'sudo apt-get install zip unzip'. On a side-note, WSL is much more performant!

I tried the HIRES=1 build on pcsx2 and i only see top half of the screen getting drawn.
I'll give it a shot on actual hardware to see if that is normal (with the exact same bios dump), as i had my share of misbehaving git builds of OPL for quite some time.

@sp193 The high-resolution stuff has it's limitations, so it has to be optional. A run-time setting would be best, but I don't have the time to make it.
The limitations are caused by:

SDTV and EDTV modes require (multi-pass) rendering at 2x 60fps = 120fps.
HDTV modes require (multi-pass) rendering at 3x 60fps = 180fps.
GS coordinate system is only 4096x4096 pixels. When rendering 1920x1080 this leaves very little borders.

With normal rendering, you can slow down to 30fps, or even slower.  With hires the front, back and depth buffer are all sqashed into the front buffer. Rendering has to finish within 1/180 s or you will see artifacts.
@yoshi314 lol. Emulators cannot handle this. It's impossible to take a snapshot of the front/display buffer, becouse it's never complete. Only the part that the CRTC is using is complete, the rest is used as back buffer or even depth buffer.
@Jay-Jay-OPL It's likely that some/all themes use more GS memory than there is available, resulting in re-transmission of the ART, 180 times per second. Try to limit the art, the resolution or use 8bit bmp (no transparency). I'll monitor your thread on ps2-home and reply there on this issue.
Other known artifacts are the display animation (left <-> right) in 1080i mode. It doesn't fit the 4096 pixels GS coordinate system.
Emulators and (heavy) themes are the reason I disabled HIRES by default.

@RandQalan, I tend to wait until a dev tells us when we need to update PS2SDK when it comes to new changes made to OPL.
For example in the pull request above (and a few other ones recently), the following Pull Request checklist was unchecked:
Requires update of the PS2SDK
As they say, it never hurts to ask.  :)
@SP193, thanks for the tip to update PS2SDK--I'll get right on it. :)
@TnA-Plastic thanks for the tip on the zip issue with the Windows Compiling Environment.
@rickgaiser -- yeah, it might be the "heavy theme" issue again. :( --  I'll make sure to tell users that if they wish to use the HIRES settings, to stay away from heavy themes.

@Jay-Jay-OPL: If you have Win10 64Bit (or a Server-Version), 'WSL is quite more fun! --> http://psx-scene.com/forums/f19/quick-dirty-tutorial-install-ps2sdk-windows-subsystem-linux-2017-a-157028/
It (the thread) requires some updates, because it became even simpler... I thought about creating a few scripts, to set it all up... (I just have pretty much no time.)
Regarding Themes: I (would) suggest to create ANY/ALL theme/-s or atleast files which do not need transparency, with palletized 8Bit-PNGs!
Those files which need transparency can still be in another format.
This way we could have the best 'out of all worlds'...:
-transparency, where it is needed
-faster loading-times, because the files are smaller, etc.
-higher resolution on those themes and backgrounds, etc.
-etc.

Sorry, to post another reply here, but I have no other way to contact you...
@Jay-Jay-OPL: WTF? Someone just used the handle I use on PSXTools.de, to register on your forum... Is that a case of 'stolen identity' (or if the account is registered via my E-mail, ir got hacked? 😰 --> http://www.ps2-home.com/forum/viewtopic.php?f=64&t=5549
To not clutter up the topic here, I'd prefer you to contact me or just take a look into it.
<EMAIL_ADDRESS>

@TnA-Plastic go here and start a support ticket with the forum admin -- he'll help you with that (I'll send him a quick PM just to let him know that you will be contacting him shortly about this): http://www.ps2-home.com/support/index.php

Regarding HIRES:
So it technically is a compile-time-option to choose to compile OPL either via the 'original'/old rendermethod, or compile it with the new other render-method, correct?
Well, IMO the best would be to use the old method for the SDTV&EDTV-Stuff and the new method only for higher resolutions.
That way(:)
-those graphical issues are possibly less likely to occur on SDTV&EDTV-Modes
-there would be no extra-compiletime-option/-var and
-we would still have the benefits of the new renderer for HiRes-Stuff
Any thoughts?


Move the send transactions test to the main branch or turn it off

Motivation
The send transactions test is very slow and copies a lot of data.
We want to fix this test in #5015. But until then, we could move it to the main branch, or turn it off.
If we move it to the main branch, we'll have a better chance of catching any changes that break this RPC.
If we turn it off, we need to either:

test it manually before every release, or
accept the risk that it might be broken in a release.

We're not planning on making any changes to this RPC, but we are working on some related RPC and mempool code that it calls.
Designs
Move the workflow to main like we did in PR #5393.
Move the job definition into a separate workflow file, and turn off that workflow in GitHub Actions.

@mpguerra this is the slow test we talked about this morning

Let's move to main for now and see how it goes

Hey team! Please add your planning poker estimate with Zenhub @arya2 @conradoplg @oxarbitrage @teor2345 @upbqdn


Switch to another network from Block explorer

Similar to https://github.com/vegaprotocol/frontend-monorepo/issues/722 but for block explorer.
e.g.

opens a new URL that looks at a different network

code is ready to be pulled in from https://github.com/vegaprotocol/frontend-monorepo/pull/1084 for this


Feature/dockerfile

preview-1  | /bin/sh: 1: make: not found which is because make is not present on the bun image. You should either refactor the Dockerfile to run the bun commands directly or ensure that make is installed.

@Toby-Rea all should be fixed now

Awesome, thanks!


Build shared library

Dear,
current meson build have to be updated in order to generate .so file

Is it beneficial to building a template heavy library like this as a shared library?
Pretty much every symbol that is going to be used is going in the dependent binary rather than the shared library.

I am trying to package all dependencies required for DCD for fedora.
And the guideline (here) tell
Packaging Static Libraries

    In general, packagers SHOULD NOT ship static libraries.

I'm only seeing one function in the library that would be distributed in a static library:
https://github.com/dlang-community/containers/blob/master/src/containers/internal/hash.d#L45
It could be templated and then this should be fully a source library, no need to distribute it as a shared library.

ok thanks I will try to provides the package with only a static library.

You misunderstand me, you don't need to distribute a built version (assuming everything gets templated that isn't already) at all.

Maybe I mistudrestand, so I will try to develop the consequence as I understand:
if we do not provide a built version:

in this case, any software that need it have to include it  in their build.
this do not follow the linux philosophy
the chance to get the package rejected is very hight
if we apply this on [DCD](https://github.com/dlang-community/DCD] we would add the containers source code into the DCD source code. And at the end they are one executable binary, instead of one executable and one static library.

Almost all of the code in this library is templated.
When you build this library as a static library, there will be almost nothing in that binary, because no templates were initialized to go into it.
When you use it, you initialize templates and therefore they go into your binary.
Templates get compiled and initialized every time you use them. There is simply nothing to distribute if every declaration is templated.


spongevanilla-1.8.9-4.1.0-BETA-322 refuses to start

A newly downloaded spongevanilla-1.8.9-4.1.0-BETA-318 server refuses to start. Here's the log.
http://pastebin.com/nRk6Qpvs

This was already fixed, however our build server is currently having trouble uploading the new builds. They will be available as soon we have fixed the problem.


C# matrices are row-major while c++ ones are column-major

Both OpenTK and System.Numerics.Vectors matrices are row-major. It would be convenient to use System.Numerics.Vectors matrices due to simd support. We most likely should just drop OpenTK math libraries and do a straight port of C++ vector/matrix/quaternion classes and add simd support when possible ourselves.

Note that urho3d Quaternion is w, x, y, z while C# ones x, y, z, w


Verify: Bug 283 (Swift 2.3)

Core Data Model

JSON
[
  {
    "id": "tasklist",
    "owner": {
      "id": "owner"
    }
  }
]

Found the bug, not related to a specific version of Swift. So I'll continue on https://github.com/hyperoslo/Sync/pull/291


Gpg Public key not found

I'm trying to verify signature for Electron Cash 2.9.4 but gpg tells me that can't found public key.
I've imported all keys published on Electron Cash website with gpg
What's wrong?
Thank you

you imported jonaldkey2 ?

Thanks a lot for you reply, now I've imported jonaldkey2 but gpg tells me
than there is no trusted  signature.
this is the screenshot
[image: Immagine incorporata 1]
Il 01 dic 2017 3:17 PM, "fyookball"<EMAIL_ADDRESS>ha scritto:

you imported jonaldkey2 ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fyookball/electrum/issues/298#issuecomment-348505445,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AauXIWdnILVVRH2MnoPfIJvn85K3f99pks5s8ApagaJpZM4QxRQZ
.

so get the sig from the repo


fixed typo

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thank you for finding and fixing this!


What should be included as a part of a consent record?

Problem description
To be able to design a consent API, we need to detail out what a consent record should include. This issue is created as a question to gather feedback from the subproject members.
Some examples could be: ConsentStatus (granted/denied), Consent capture date+time, PersonalData  etc.
Possible evolution
We should be able to define a clear structure for consent.
Alternative solution

Additional context

@shilpa-padgaonkar If it helps, and just as an example, below is how we currently model a consent record internally at Telefónica (not all fields may apply):

NOTE: We also want to add the application (with a client_id field or something like that).
NOTE: Fields like channel, reason, triggered_by... may be a bit more specific to Telefónica and not necessarily needed here.

In any case, so far there is no need to expose a Consent API to third party clients as a CAMARA API with CRUD operations on consent records. Consent must be obtained through operator channels (there is no delegated consent) and only operators internally manage user consents (e.g. check if a consent record exists, create a new consent record if it is captured from the user, etc).


Not able to compile contracts

I am following the multi index example at
https://developers.eos.io/eosio-cpp/docs/using-multi-index-tables
I get the following error when I compile contracts using eosio-cpp -abigen youvote.cpp -o youvote.wasm
error: error reading '/piyushkumar/Desktop/dev/youvote/youvote.cpp'
1 error generated.
Error while processing /piyushkumar/Desktop/dev/youvote/youvote.cpp.
abigen error

Earlier it used to work, I came across this error recently. I am using eosio-cpp version 1.5

@vectar31 Are you sure that your code and the tutorial's code match verbatim? And are you looking at the stable version of the tutorial (v1.6)?
I just cloned and built a fresh version of eosio.cdt v1.5.0, followed the tutorial verbatim, and could not reproduce the error that you're getting. Could you provide more details on the system that you're currently using and any other details that may be pertinent?

Closing due to inactivity.


The pretrained model ?

Excellent Job! Can you provide the link to the pretrained model ?

Hi Lee Soon,
Thank you for your interest! I have just found out that the original link to the pretrained model is no longer available. I will try to upload to a cloud server and share the new link as soon as possible.

Excellent Job! Can you provide the link to the pretrained model?

Hi Lee Soon,
Thank you for your interest! I have just found out that the original link to the pretrained model is no longer available. I will try to upload to a cloud server and share the new link as soon as possible.

Thank you very much for your reply.

Excellent Job! Can you provide the link to the pretrained model?

Hi Lee Soon, Thank you for your interest! I have just found out that the original link to the pretrained model is no longer available. I will try to upload to a cloud server and share the new link as soon as possible.

Thank you very much for your reply.

In the paper, the initial learning rate is set to 0.005 and is divided by 10 for two times during the training process.
How does the learning rate change in the code?
parser.add_argument('--lr-steps', type=list, default=[int(1e4*x) for x in [1.5,3,4]])
It seems that different data should be set differently?

In the paper, the initial learning rate is set to 0.005 and is divided by 10 for two times during the training process. How does the learning rate change in the code?
parser.add_argument('--lr-steps', type=list, default=[int(1e4*x) for x in [1.5,3,4]])
It seems that different data should be set differently?

Yes, the settings here are a bit out of date and we will update this to a dynamic version as soon as possible. We are currently a bit busy with NeurIPS so please understand that there may be a short delay in the update. Closing this issue as the pretrained model is now available.


Replaced round(x) with floor(x+0.5)

I got ERROR 'round' : no matching overloaded function found (using implicit comversion), and made this quick change to fix it. Seems to be related to the version of GLSL supported by my graphic card (I don't know much of shaders), but I believe this change does not break anything, hopefully.

In retrospect, this is better than what I did just now. Will merge it when at home.


To fetch data at certain interval and show the latest data.

We can discuss the interval time and set it accordingly.


test: add tests for region migration procedure

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?

Refactors the State of the RegionMigration.
Add some basic region migration tests.

And some remaining tests will be added in the next PR.
Checklist

[x]  I have written the necessary rustdoc comments.
[x]  I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)
#2700

@fengjiachun @MichaelScofield PTAL


Discourse plugin

Create a Discourse plugin to embed Snapshot proposal results within a Discourse post.

@bonustrack Is there any design ideas for this?


Fix descending index order after between()

Fixes #76

Awesome, thanks! Sorry for the late answer, I completely forgot yesterday to check the PR once I got home.

Released in 2.2.9


ARROW-14461 [R] write_dataset() allows users to pass invalid additional arguments

This PR aims to add checks to arguments passed to write_dataset() via ..., conditional on the value passed for format.
The code below should not run without a complaint.
td <- tempfile()
dir.create(td)
write_dataset(iris, td, format = "feather", arg_that_doesnt_make_sense = "blah-blah")

Currently write_dataset() supports 5 formats ("parquet", "feather", "arrow", "ipc", "csv"). Ultimately all formats use FileWriteOptions$update(). "csv" is the only one that errors on non-relevant additional arguments passed via ... (without checks). "arrow", "ipc" and "feather" all use the same type  (dataset___FileWriteOptions__type_name).

@jonkeane :)

Oh and it would be good to match the issue name with the PR name (feel free to copy what you have here to rename the jira if that's more accurate)


The conneciton pool returns corrupt connections

Setup
Versions

Rust: rustc 1.75.0 (82e1608df 2023-12-21)
Diesel: 2.1.0
Diesel_async: 0.4.1
Database: mysql 5.7.26-log
Operating System： linux

Feature Flags

diesel: ["mysql_backend", "time"]
diesel_async: ["mysql", "deadpool"]

Problem Description
After running for a few days, some connections in the connection pool will return an error
What are you trying to accomplish?
Query records in the database
What is the expected output?
No error
What is the actual output?
Got an error: "Unexpected end of row"
Are you seeing any additional errors?
Input/output error: can't parse: buf doesn't have enough data
Steps to reproduce
It's hard to reproduce the problem, after running for a few days, some connections in the pool will return errors. I think those connections are already corrupt but still can pass the health check of the connection pool. So I did a contrast experiment, when I found the connection got corrupt, the ping2 responded with ok, but the ping responded with an error "buf doesn't have enough data"

use diesel_async::{pooled_connection::deadpool::Pool, AsyncMysqlConnection};

type MysqlPool = Pool<AsyncMysqlConnection>;

pub struct AppState {
    pub mysql_pool: MysqlPool,
}

async fn ping(State(state): State<Arc<AppState>>) -> Result<impl IntoResponse> {
    let mut conn = state.mysql_pool.get().await?;
    let x: i32 = diesel::select(1_i32.into_sql::<diesel::sql_types::Integer>())
        .first(&mut conn)
        .await?;

    Ok(Json(x))
}

async fn ping2(State(state): State<Arc<AppState>>) -> Result<impl IntoResponse> {
    let mut conn = state.mysql_pool.get().await?;
    let _ = diesel::select(1_i32.into_sql::<diesel::sql_types::Integer>())
        .execute(&mut conn)
        .await?;

    Ok(Json(())
}

Checklist

[x] I have already looked over the issue tracker for similar possible closed issues.

[x] This issue can be reproduced on Rust's stable channel. (Your issue will be
closed if this is not the case)
[x] This issue can be reproduced without requiring a third party crate

Thanks for opening this bug report. I think I would accept a PR that just changes the built-in ping function to your first variant. That should hopefully workaround that issue. Otherwise I would be interested in having a minimal reproducible example for this, as otherwise this is impossible to debug for anyone.
https://github.com/weiznich/diesel_async/blob/1ef43d2a8a4080c1e9e5c34056f4d26cbb2a85cc/src/pooled_connection/mod.rs#L330
For now you can also workaround that issue by providing your custom connection check function via this config.

Thanks for opening this bug report. I think I would accept a PR that just changes the built-in ping function to your first variant. That should hopefully workaround that issue. Otherwise I would be interested in having a minimal reproducible example for this, as otherwise this is impossible to debug for anyone.
https://github.com/weiznich/diesel_async/blob/1ef43d2a8a4080c1e9e5c34056f4d26cbb2a85cc/src/pooled_connection/mod.rs#L330
For now you can also workaround that issue by providing your custom connection check function via this config.

Changing the built-in ping function to my first variant is not easy, since it requires the backend to support the integer type i32. The workaround way is to change the ping implementation in every certain backend.

We can assume support for i32 for all database systems, as it is a really fundamental type. It just need to be encoded in the trait bounds for this impl.


[1.18.2] Assembler charging

While charging internal buffer goes up to 32K and then jumps to -32K

Oh dear. I only tested the assembler using coal. This might be an energy api bug, but given that I've never seen other machines do this, I'm probably using the energy api wrong.
Thanks for letting me know. I'll try and fix this as soon as I can.

Just did a few more tests. That happens only playing on server and with any vanilla/moded fuel/power.

Ok, I bet this is an encoding problem then. I only tested this in single-player, forgetting that single-player doesn't normally force packet encodes/decodes and just passes packet objects between logical-server and logical-client directly. Somewhere the energy value must be being cast to a short and then back.

Ok, this is fixed in versions v0.3.7+1.18.2 and v0.4.8+1.19 on Modrinth and CurseForge.


Update Get-SPConnectedServiceApplicationInformation.md

Filled in placeholders.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Get-SPConnectedServiceApplicationInformation.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add a WildEmitter.mixin(<constructor>) method for mixing emitter behaviour into a "class" more easily

A reimplementation of #8 against the newest codebase.

@HenrikJoreteg should I squash to one commit, or is this ok?

I don't particularly care if they're not squashed. Also, I've given you publish rights on npm too.
Feel free to merge/publish. Please follow semver.org for versioning and I tend to use these scripts to actually publish so that a corresponding git tag gets pushed to github as well: http://ampersandjs.com/learn/bug-triage-process#publishing


jQuery 1 noconflict still not working.

Following up on #24417. I saw #24513 And it looks like this is exactly what was needed.
However since the dist/ files are not updated to include that fix yet. I compiled myself and pasted the minified version into my testing bin for this. I get the same error I got b4 with the minified version.
That is TypeError: e is undefined in Firefox.

You're right that's a compatibility issue see my Codepen(s) :
Using your jQuery 1.12.4 : https://codepen.io/Johann-S/pen/PJvLMK
Using jQuery 3 : https://codepen.io/Johann-S/pen/MEdxZP

I was wrong in my last comments, they are something which break or JS in Wordpress
Using jQuery 1 from jQuery CDN : https://codepen.io/Johann-S/pen/PJvLMK (working)
Using jQuery 1 from your jQuery link : https://codepen.io/Johann-S/pen/rGgbOE (not working)


util linux: implement mountpoint checking

The mountpoint -q tool simply looks at /proc//mountinfo per default and
falls back to stat()ing the relevant path in case /proc//mountinfo does
not exist. There's really no point in spawning a new subprocess for this. Let's
simply pars /proc//mountinfo per default and fallback to stat()ing when
the file doesn't exist or is busted.
Closes #3877.
Signed-off-by: Christian Brauner<EMAIL_ADDRESS>

jenkins not happy :)

@stgraber, updated :)

jenkins: test this please


[Don't merge] PoC for Options-based AzureKeyVaultProvider

Hi @pakrym, @glennc,
I took the existing #500 PR and integrated some of our current in-house solution (as described in my comment in #487) into it.
This is a completely untested quick & dirty PoC (the tests don't even compile and some stuff is not yet implemented). I just wanted to show you something with as little effort as possible in case you don't want to proceed with such a solution.
Differences to the existing PR:

Parameters are Options-based - this means, they can come from a different ConfigurationBuilder (e.g. from a file, from environment variables, ...)
Include-Pattern which allows to map one physical secret to multiple internal keys
The internal keys can contain a ":" which allows for nice nesting if stuff should be mapped e.g. to multiple Options-classes.
Exclude-Pattern for people who just want to load all secrets except some
If there's no include-pattern and no exclude-pattern, every secret is loaded
It does not handle multiple vaults right now. Not sure if this is required or if people should just call .AddAzureKeyVault() multiple times.
Vault-name alias: If added to an existing ConfigurationBuilder, one could specify an internal name for the vault which will be added as a prefix to every key in the dictionary (e.g. "MyVault:SomeKey", "MyVault:SomeOtherKey")

A config file which just fetches every secret without a mapping would look like this:
{
  "ClientId": "75e92952-701b-43f7-9f8b-8769bdd804de",
  "ClientSecret": "a909502dd82ae41433e6f83886b00d4277a32a7b",
  "VaultUri": "https://my-vault.vault.azure.net"
}

A config file with an include pattern would look like this:
{
  "ClientId": "75e92952-701b-43f7-9f8b-8769bdd804de",
  "Thumbprint": "a909502dd82ae41433e6f83886b00d4277a32a7b",
  "StoreLocation": "LocalMachine",
  "VaultName": "MyVault",
  "VaultUri": "https://my-vault.vault.azure.net",
  "IncludedSecrets": {
    "KeyWithNoDifference": "",
    "KeyWithDifference": "ActualKeyIsDifferent",
    "ModuleOneOptions:ConnectionString": "Sql-ConnectionString",
    "ModuleTwoOptions:SqlConnectionString": "Sql-ConnectionString",
  }
}

If you decide to go with such a solution, I'd be happy to improve the code and follow your guidance!!

Hi @cwe1ss, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

closed, since #500 has been merged. at least one comment would have been nice :)


Cannot access to dataset InfoRe

Hi,
I cannot access to dataset InfoRe. Could you please update the link?
Thank you!

Hi @ngoanpv,
My personal server is currently down (my laptop's charger is broken), therefore I cannot provide you the downloadable link for quite a while.
Also I don't have enough google drive storage to store the data.
I'm fixing the charger so please wait, I'll notify you when the server is up.

Thanks for your information,
I look forward to receiving your update!

Hi @ngoanpv, the link is updated, I'm closing this here.

@ngoanpv, ah I forgot, it's BroughtToYouByInfoRe


Inconsistent results across devices

I got inconsistent results between two different computers. Both were Macbooks running Big Sur on the same network.
Here's what I got on my newer M1 device:

Here's the same site on my older non-M1 device:

(Note this is also more consistent to the Lighthouse scores in the browser. The browser scores were consistent across devices)
The Lighthouse docs mention variability but this seems pretty extreme.
I saw similar results on a number of sites. I tried making sure to use the same version of Node, reinstalling Chrome, restarting my machine, etc.
I'm not sure if this is related to it being an M1 machine or something else?

I was recently able to run Lighthouse Parade on my M1 and it seemed to run find. ¯_(ツ)_/¯

I re-ran this on my mac (not an M1) and asked Danielle run it on hers (M1) and we are still seeing this issue:
Non-M1:

M1:

Command used:
nvm use 14
npx lighthouse-parade https://cloudfour.com/ --max-crawl-depth 3 --exclude-path-glob "/thinks/*" --exclude-path-glob "/presents/*"

Thanks Caleb! That's interesting. I wonder why that is....

I am looking into it more. I've looked through lighthouse issues to see if they list anything similar, but I couldn't find anything. Gonna try updating lighthouse too

We were able to dig into this more in #92
The issue crops up when "using virtualized x64 instead of natively running arm instructions" (quoting @calebeby because he has a better grasp of this than me)
I believe this means that if you're on an M1 machine you'll need to use Node 15 or 16 and confirm that your Node version is using arm64 as the underlying architecture. @calebeby , @spaceninja , does that sound correct? If so what's the best place for us to document this? Should we add a Troubleshooting section to the Readme?

Yeah, adding a section in the README should be enough. I'd imagine something like:

Mac M1 Note
Users running virtualized x64 versions of Node on Macs with M1 chips may see anomalous results. For best results on an M1 chip, ensure you are running the arm version of Node 15+.
When you run the command node -p process.arch you should see arm64. If you see x86, try uninstalling and reinstalling your version of Node, like so:
nvm uninstall 16
nvm install 16
nvm use 16
node -p process.arch

Addressed in #93!!


Corrected link to OpenREM website

I was glad to see OpenREM on this list (I was looking for something else!)
However, the http:// was duplicated so the link didn't work. This PR corrects that.

Thanks! Merged.


Add contributors list

Problem
The Javadoc-publisher.yml project doesn't have a contributors list at the end of the README.md.
Solution
To resolve it we can use this GitHub Actions : contributors-list.

Is this being worked on or done? If not then I can make it.

Will PR shortly


RuntimeError: PytorchStreamReader failed reading zip archive: failed finding central directory

I try to run "python3 playground.py --stage1_weight WEIGHT_FOLDER/stage1_cc3m.ckpt",but it shows the ckpt cannot load normally like the title. I suspect the ckpt files is broken or I have a wrong version of pytorch.

Do you change the WEIGHT_FOLDER to the correct path? Also, you need to load stage2_weight for the playground.  Another person in #10 just successfully ran the demo.

No, it doesn't work. I see the error is just about "stage1_cc3m.ckpt" in the "playground.py" line 40.

The uploaded weight is correct. Can you try torch==2.0.1?

no，I guess because my conda get a low version cuda 11080

my cude version is 11.8 and i got a warning of low version. is that the reason?

I don't think so. My cuda version is 11.7, even lower than your version.


✨ [REQUEST] Jellyfin mount web folder to addons_config/jellyfin

Which addon?
Jellyfin

Is your feature request related to a problem? Please describe.
I think so. I wanted to add a custom link to the sidebar of jellyfin. They added a configuration option for that in Jellyfin 10.8 but to add it you need to edit the config.json file in the webroot. I could not find that file in the addons_config/jellyfin folder. See here: https://jellyfin.org/docs/general/clients/web-config/

Describe the solution you'd like
mount the /usr/share/jellyfin/web/ folder to addons_config/jellyfin i guess?

Describe alternatives you've considered
none

Additional context

Hi, not sure about the benefit but I've pushed it :-)

The server doesn't start after upgrading to this version:
[15:08:43] [INF] [2] Main: Received a SIGTERM signal, shutting down

Thank you for pushing this update :) ! It works but it makes a web directory in the web directory causing the error above.

Thanks, my mistake. I've corrected the cp command as you proposed and pushed a new version


CVE check is failing

TL;DR
No immediate action is needed. Ignoring until further notice.
TS;WM
Last night's CVE check is failing: https://github.com/thetredev/steamcmd/actions/runs/4020769278/jobs/6909037276
The following packages should get an update as soon as they're available in AlmaLinux 9.1:

Package
Vulnerability
Relevancy for project

bash
heap-buffer-overflow
The shell the game servers are started from

libtasn1
Out-of-bound access in ETYPE_OK
Only relevant if SSH server is enabled, probably still safe as only public key authentication is enabled

Since the findings are of severity MEDIUM the priority to fix them is not high, so no immediate action (like manually updating them) is needed.

Fixed after merging #18

This time it's https://github.com/thetredev/steamcmd/actions/runs/4309756239/jobs/7517505001.
Severity of all of them is MEDIUM again, so no immediate action is necessary.

Removed check, see commit https://github.com/thetredev/steamcmd/commit/3f1d829fdf3753bb5950bdc8b6d95f2babee6058.


Can't connect verified accounts via 3box

Trying to update my profile, I followed the links to 3box... verified twitter, github and email and then returned to the garden and refreshed... none of my verified accounts show up in my profile in Gardens

We should address this one as part of the migration to IDX. Relates to #48


Facebook Bot Webhook TypeError: Cannot read property 'length' of undefined

Node.js version: 8.4.0
Botkit version: 0.5.5
Unsure what's going on during this event
 { object: 'page',
   entry:
    [ { id: '<facebook-page-id>',
        time:<PHONE_NUMBER>376,
        messaging: [Array] } ] }
     at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5)

Which leads to the length of undefined
TypeError: Cannot read property 'length' of undefined
     at Object.<anonymous> (/app/node_modules/botkit/lib/Facebook.js:19:54)
     at Object.Facebookbot.facebook_botkit.handleWebhookPayload (/app/node_modules/botkit/lib/Facebook.js:336:41)
     at /app/components/routes/incoming_webhooks.js:24:22
     at Object.Botkit.botkit.trigger (/app/node_modules/botkit/lib/CoreBot.js:1047:49)
     at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5)
     at Function.process_params (/app/node_modules/express/lib/router/index.js:335:12)

I was previously using Botkit 0.5, and read in another issue that was resolved to upgrade to 0.5.1 which would resolve the issue, however upgrading to later versions still didn't do the trick.
Would appreciate any help on this. Thanks in advance!

@kniteshift This doesn't occur for me in v0.6.6 but the solution in previous versions was to stop listening on events standby and messaging_handovers. Must you listen for these events?

@urbanslug messaging_handovers and standby is not checked on my end.

@kniteshift can you share what is?

@peterswimm

@kniteshift So this is okay to close, right?

@urbanslug I am still seeing the issue, and the only reproducible element is that referrals is a cause of the issue.

@kniteshift Well I could be wrong but if your referral link really has the backslash before the query string (m.me/?ref=) as is in your example that could be it.

@urbanslug sorry, I meant to say m.me/<page-id>?ref= is a case that shows the error.
Following the convention provided here: https://developers.facebook.com/docs/messenger-platform/discovery/m-me-links

@kniteshift Hey, I am also facing this issue in 0.6.6 I am looking for a fix or a workaround. Will let you know how it goes.

Sorry, in my case I was using facebook_postback instead of facebook_referral to listen for referral links. Are you using the facebook_referral event?
https://github.com/howdyai/botkit/blob/master/docs/readme-facebook.md#facebook-specific-events

@urbanslug yes we are, we have set a console log event to track each referral to the time being.

@kniteshift I suggest you try v0.6.6 to see if your problem persists. The release was described as "fix for facebook and cisco"

@urbanslug I have been a bit hesitant to switch over because I haven't gone through the documentation regarding Message Pipeline. So I'm not sure if there will be any breaking changes for FB.

@kniteshift There should be no breaking changes (after the above mentioned fix)

@peterswimm I actually upgraded to v0.6.6 but the bot did not respond, possibly because I did not apply any changes required for message pipeline and etc.,. Could you share/provide documentation for the changes needed if upgrading from 0.5?

Check out:
https://github.com/howdyai/botkit/blob/master/docs/howto/upgrade_05to06.md
If any new issues arise from this, go ahead and create a new issue!

Have had similar issue, not the same though.
Unsubscribing to two events, namely: messaging_handovers and messaging_policy_enforcements did the job.


[Enhancement/Feature] Add option to save login-name only (without password)

I suggest to either use three option fields (remember login-name/password, remember login-name, don't remember me) or two checkboxes (remember me, remember password [disabled and not-activated if the first one isn't checked]) - I tend to the second one.

I tend to the second one too.


customisation

Hi I really liked nightly, but we cannot really change stuff, so I made a flask version in which we can locally host the page and thus make our own modification, maybe check my fork out, and maybe implement a similar way of loading the page, so that we can have different flavors of nightly
overall a great web greeter, nice job dude

Thanks for the suggestion and love your work! I am sorta new to web dev so it'll take me some time, but I'll surely try to implement it. Although one thing I'd like to state is that my major goal with v2.0 was to make it more user friendly and less tech oriented, which of course came with some customisation compromises. I thought that the people who'd need more tinkering would generally be the people who love fiddling with the code anyways, so I left everything else to be a diy thing. Your version, adding more configurability, also adds a layer of complexity, so It'll also take me some time to make it more user-friendly.
That said, I'd again like to thank you for your thoughts and feedback!


Add links to external API docs

We should add links in our overviews, etc to our API docs on rubydoc.info, which offers an alphabetical listing of types, global listing of methods, and is familiar to experienced Rubyists.

Closing, as we now expect greater prominence for the external docs.


HassView now acts as standard WebView when not using Home Assistant

I'm sending 2 commits in this pull request:
Now, if a different web than home assistant is used, HassWebView won't do anything related to home assistant, so it should work with every web page.
Also, I realized that due to pager paging, it was impossible to slide some home assistant controls. For example, if you touch a light, a popup will show a slider to choose brightness, and a color wheel to select color. Swiping horizontally does not allow setting a slider position. The same happens for roller shutter sliders. So, I modified it to disable pager paging when a home assistant dialog is shown. When the dialog is closed, paging is enabled again.
If you get any compiler error, you may need to refresh HassWebView dependency. You can refresh it by adding this to your build.gradle, as seen here:
configurations.all {
    resolutionStrategy.cacheChangingModulesFor 0, 'seconds'
}

For now I prefer to use dependency as snapshot version I will upload a release version when we are sure everything is working fine, and there is no need for more modifications.

Just a note from testing, it doesn't seem that setAdjustBackKeyBehavior(true/false) has any difference on the behavior of the component.   If you do navigate to one of the admin levels, it seems that you do have some issue using the device back button to get back to the alarm panel.    This may require more testing and tweaks when integrated into the application.   It's ok for a first release, I have put both setAdjustBackKeyBehavior and setHideAdminMenuItems in the platform settings of the application so users can turn on/off those features.


Clarify transparency/discoverability on main README

The repo name and main title of the README introduces this work as transparency, but the body of the text talks primarily about integrity achieved via signatures:
This project demonstrates how to protect the integrity of a model by signing it with [Sigstore](https://www.sigstore.dev/), a tool for making code signatures transparent without requiring key maintenance. When users download a given version of a signed model they can check that the signature comes from a known or trusted identity and thus that the model hasn't been tampered with after training.

The implicit claim above is that transparency is achieved by virtue of logging it to SigStore. Logging such claims is necessary for transparency but not sufficient. The missing part of the transparency puzzle is that identity owners will tail the log seeking to discover any signatures issued from their identity that they are not aware of. This completes the signature transparency story, as key compromise will be detected, and thus authenticity can be relied upon.
@haydentherapper has more context on this as we discussed this yesterday.

Thanks Martin for mentioning this. I think this was implicit to us, but would not be to a newcomer in this space. https://github.com/sigstore/rekor-monitor is a work in progress, but the identity monitoring portion is in a far better state now. I'd recommend we update the readme to go a bit more in depth into the claims that are added to the log and how to monitor for those claims.


Reminder setup doesn't appear for some users

Hello,
We are happily using TeamLink, thanks for making it available! However, we have one issue: For me, the red button to activate the reminders appeared in the top right corner, I could click it and since then get the reminder every Friday. But for at least one of my colleagues the button doesn't appear. Would you have any idea why that might happen and how we can make it appear?

HiThe red button only appears if you have notifications switched off.  The default is that notifications are on so your colleague should get the reminder card on their last working day of the week.  Stuart On 17 May 2023, at 07:30, Tobias Fenster @.***> wrote:
Hello,
We are happily using TeamLink, thanks for making it available! However, we have one issue: For me, the red button to activate the reminders appeared in the top right corner, I could click it and since then get the reminder every Friday. But for at least one of my colleagues the button doesn't appear. Would you have any idea why that might happen and how we can make it appear?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Dear Stuart, I have the same problem with my team. No member of my team gets a reminder card at friday in the chat via power automate. What must I do? Notifications are allright, test are sucessful (see below) but no cards?!? BR Gundi

works for me in the meantime


Meteor CommitAbility

GA_Meteor_BP doesn't check the return value of CommitAbility, but it seems like it ought to be connected to the immediately following branch.

Not sure when or how that got disconnected. Thanks!

Thank you for this fantastic learning resource! :)


LOKO air unit without Ground unit

Hi,
Loko is awesome waiting to get one soon, Just want to know, can we will use the air unit independently, or ground unit is always required to access the GPS location on the phone App?
Can I use it as a Car location finder?
Thanks.

hi ,
you can connect Loko Air to excited LoraWAN network in your city, if you don't want to use Ground unit.

hi , you can connect Loko Air to excited LoraWAN network in your city, if you don't want to use Ground unit.

Can it run on helium?

what do you mean by helium, ?

hi , you can connect Loko Air to excited LoraWAN network in your city, if you don't want to use Ground unit.

Can it run on helium?

No it can't. Helium must have SX1302 or SX1303 and a lot of other things.

Helium is a cryptocurrency blackchain concept working as a sideline with lorawan protocol. The Air unit should be working with any lorawan gateways. Helium has its own eco system only on lorawan gateway, not on the end device. The Air unit will communicate with Helium network, Reference link to for STM32 Controller working with Helium infrastructure, https://docs.helium.com/use-the-network/devices/development/stmicroelectronics/st-b-l072z-lrwan1/
BTW, Helium is not relay on SX1302/SX1303 concentrator modules. It can work with other models as well.


Always test before merging

No one complained for 4 hours, I never thought that MultiOgar-Edited is that unpopular :smile:

Sorry my mistake


Support for passing a specific prisma client in plugins

Hi Ahmed,
I notice the plugins import the dmmf from '@prisma/client'. This causes an issue when using a custom path for the generated prisma client.
For example with this directive in the schema
generator client {
  provider = "prisma-client-js"
  output   = "../generated/database/client"
}

This is a likely scenario if building a GraphQL with multiple data sources, and therefore using more than one prisma client.
Would it be possible to support passing the client to the plugin?
Thanks!

@roderickhodgson, thanks for your issue. I am already working on that.

@roderickhodgson please update to last version https://github.com/paljs/prisma-tools/releases/tag/v2.5.0

Hi, dmmf does not seem to be exported now or at least not the same way it did before. Anyhow, the generate client exports a Prisma object. Inside that object I found dmmf and DMMF both. But nothing works! Any solution for this?


Behavior of hasManyThrough different lazy vs. eager load

As a forward, I'm working with a database that was designed very poorly (namely the references between tables are not done off PKs in many cases.) As such I have to override column names in most relations, but this hasn't been a problem. The basic structure is:
Creditor

_rowid (PK)
id

Debitor

_rowid (PK)
creditor_id (references Creditor.id)

invoices (just refactored this, hence moving towards using PKs, and more appropriate naming standards)

id (PK)
debtor_id (references Debitor._rowid)

My relationship from Creditor to Invoice is:
return $this->hasManyThrough(Invoice::class, Debtor::class, 'creditor_id', 'debtor_id', 'id');
If I lazy load by doing:
$creditor = Creditor::find($id); $creditor->invoices
Everything works fine.
If I try it with eager loading:
$creditor = Creditor::with('invoices')->find($id);
The invoices relationship on the creditor is empty.
Similarly, calling:
$creditor->load('invoices')
does not work.
In investigating the SQL generated, it seems that in the eager-loading situation, the PK of the Creditor table is being used, instead of the 'id' column that I specified.

I managed to come up with a fix. I modified two lines in HasManyThrough.php as follows:
Line 139:
$this->query->whereIn($table.'.'.$this->firstKey, $this->getKeys($models, $this->localKey));
Line 174:
$key = isset($this->localKey) ? $model->{$this->localKey} : $model->getKey();
This has seemed to work for my application, though I believe this is the only place I am presently using hasManyThrough, so not positive there isn't a case where this could break.


Is TAP-Net an offline algorithm?

Hi, thank you very much for your great work!
Could I consider TAP-Net as an offline algorithm? Because TSM-ResNet-18 is used as the backbone.

Got it. Thank u very much for your prompt support!


Add server.invoke

[ ] Add server.invoke using RemoteFunction.InvokeClient in server queries

ByteNet Max does not support server->client remotefunctions as it is not recommended by Roblox. I suggest using packets for that.


[Bug] FX Tablet Asset problem

little bug, pinball Fx - table civil war : Table_1

Ah, got it. All FX tables use the base name "Table" which mixes up every download.

Syd711 | [MAT] — Today at 7:32 PM
Ok, interesting. This is actually a problem/bug in PinUP Popper where I can't do anything. E.g. if you are adding assets for "Battle of Mimban" (with name "Table_107", this asset will also be visible for "Civil War", as it has the name "Table_1".


Add Bialik Hebrew Day School

Website: bialik.ca
Bialik offers a rich STEM curriculum.
Students have email addresses at students.bialik.ca and staff have email addresses at bialik.ca.

@humanoid Pull request merged. Please notice that free educational license for JetBrains tools is for high and higher schools students, i.e. those who are over 13 of age. Thank you!


Improve privacy policy page with some styling

@gbowne1 I want to improve the overall look and feel of the privacy and policy page
so kindly assign it to me :)
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Ok @ratishjain12

@gbowne1 sorry for the delay my exams are going on rn so not able to contribute,
Will start contributing to this project in next week or so.

@gbowne1 sorry for the delay my exams are going on rn so not able to contribute,
Will start contributing to this project in next week or so.

@ratishjain12
No worries, contribute when you're able to. You are very close to being invited to be a collaborator.  Looking forward to reviewing your PR.  Thanks for keeping us updated.

@gbowne1 this issue is still open right I am working on this?

Yes it is still open and I did assign you @ratishjain12

@gbowne1 I'll also be working on this issue.

@gbowne1 This should be removed from the issues list since it has been merged.

@BlackBond06 Sorry I forgot to add & link the issue to the PR, which would have closed the issue automatically.
If you create a PR that already has a issue, make sure you add the issue to the PR, which you can do from either the PR or the issue and the issue(s) will be closed on merge.
If there is no issue, I would appreciate a issue being created.
We still have a bunch of browser console issues in Firefox to get through (I still need to look at most of the app in Chrome).


SNAX accelerator control port contains redundant bits

Currently, the data_arga and data_argb ports in the SNAX CSR control port are 64 bits but the valuable information only takes up lower 32bit. The higher 32 bits are useless now.

Won't do anything for this since we're using CSR instructions instead.


Titles capitalization in profile page

Proposal:
Proposal written by Jecsham
What is the title of your proposal?: Titles capitalization in profile page
Is it a suggestion for the website or for the bot?: website
Explain your proposal more accurately (It's best to give as much information as possible, so that we can implement the proposal better): https://i.imgur.com/9VMI9Bu.png
Why should we add this feature?: Looks better
ReportID: 144

➤ LenoxBot commented:
Approve:
Looks better
Profxy#5396

➤ LenoxBot commented:
Approve:
titles should be capitalized anyway; names of ranks even more
DanNick#8108

➤ LenoxBot commented:
Approve:
agree with dannick
Dadi#7808


Signage for the day

Figure out how to sign post people to the hack day

Downstairs reception roller banner
GDS reception roller banner and desktop sign in notice
Garage signage
Info on where the quiet room, prayer space and toilets are
Board game social

Inc wifi info / code of conduct etc

DSD Hackday posters.pdf

Hopefully the final posters for print, @NoraGDS
Please print the 'Hackday posters' at A3, the rest can be done A4 I think
DSD Hackathon door signs.pdf
DSD Hackday posters.pdf
Pizza signs.pdf


How to train with KFold

Thank for your awesome library.
I am wondering if this library supports training with KFold Cross-validation?

Hi,
Long story short, it is available, but not fully automated.
For now, you can make it by:

prepare KFold split in your DataSource (config example, DataSource example).
add prepare_logdir for your model.py (example)
run some kind of grid search with different train_folds (example)

I think, you can start from this example to figure out how it is all working. Or, simply tune its prepare_logdir and run_grid.sh for additional run_kfold.sh example (PR are always welcome 😄 ).
PS. for different train_folds  just pass something like --stages/data_params/train_folds=[1, 2, 3, 4]:list for train.py script. (example)

Thank you.
I got your ideas. It makes sense for me.


Support foreign keys during rebase

Currently if someone uses foreign keys between tables, things may not work correctly.
For example: table "tree_species" (with ID, latin name, common name columns) and table "trees" (with ID, location (X,Y), tree species ID). If two users both add a new tree species and a new tree:

user1: tree_species: new row with ID 5 named "abc"
user1: trees: new row with ID 10, referencing ID 5 of tree_species
user2: tree_species: new row with ID 5 named "def"
user2: trees: new row with ID 10, referencing ID 5 of tree_species

During rebase, tree_species of one user will be updated from ID 5 to 6, but the entry in trees table will still point to ID 5 (and does not get updated to ID 6).
For this, we should scan all foreign keys and make sure to update also update ID in other tables.

what to do with this:
user1: remove specie "abc"
user2: add tree with specie "abc"

+1 also for @PeterPetrik point of view https://github.com/MerginMaps/input/issues/1636#issuecomment-921637944
Problem: geodiff, as a lib, cannot really help the user to:

check if serials or fids are used in foreign keys and return errors (or warning ?)
help the user the create the UUID fields in all needed tables (good practice for sync tools, but it modifies the user data)
etc.

This could be delegated to geodiff clients ?


Training on GTX2080

Process 2 terminated with the following error:
Traceback (most recent call last):
File "/data3/liuhaogeng/anaconda3/envs/vits/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 20, in _wrap
fn(i, *args)
File "/data3/liuhaogeng/test/vits-main/train.py", line 120, in run
train_and_evaluate(rank, epoch, hps, [net_g, net_d], [optim_g, optim_d], [scheduler_g, scheduler_d], scaler, [train_loader, None], None, None)
File "/data3/liuhaogeng/test/vits-main/train.py", line 138, in train_and_evaluate
for batch_idx, (x, x_lengths, spec, spec_lengths, y, y_lengths) in enumerate(train_loader):
File "/data3/liuhaogeng/anaconda3/envs/vits/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 363, in next
data = self._next_data()
File "/data3/liuhaogeng/anaconda3/envs/vits/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 989, in _next_data
return self._process_data(data)
File "/data3/liuhaogeng/anaconda3/envs/vits/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1014, in _process_data
data.reraise()
File "/data3/liuhaogeng/anaconda3/envs/vits/lib/python3.8/site-packages/torch/_utils.py", line 395, in reraise
raise self.exc_type(msg)
RuntimeError: Caught RuntimeError in DataLoader worker process 2.
Original Traceback (most recent call last):
File "/data3/liuhaogeng/anaconda3/envs/vits/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 185, in _worker_loop
data = fetcher.fetch(index)
File "/data3/liuhaogeng/anaconda3/envs/vits/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/data3/liuhaogeng/anaconda3/envs/vits/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 44, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/data3/liuhaogeng/test/vits-main/data_utils.py", line 94, in getitem
return self.get_audio_text_pair(self.audiopaths_and_text[index])
File "/data3/liuhaogeng/test/vits-main/data_utils.py", line 62, in get_audio_text_pair
spec, wav = self.get_audio(audiopath)
File "/data3/liuhaogeng/test/vits-main/data_utils.py", line 74, in get_audio
spec = torch.load(spec_filename)
File "/data3/liuhaogeng/anaconda3/envs/vits/lib/python3.8/site-packages/torch/serialization.py", line 577, in load
with _open_zipfile_reader(opened_file) as opened_zipfile:
File "/data3/liuhaogeng/anaconda3/envs/vits/lib/python3.8/site-packages/torch/serialization.py", line 241, in init
super(_open_zipfile_reader, self).init(torch._C.PyTorchFileReader(name_or_buffer))
RuntimeError: [enforce fail at inline_container.cc:144] . PytorchStreamReader failed reading zip archive: failed finding central directory
I set the batch size to 16

I met the same error.
This error is caused because that function TextAudioLoader.get_audio saved empty spectrograms file(.spec.pt). (Maybe caused by multi-processing?)
Torch load empty file will throw this error.
You can compute and save spectrograms before your training. The following is spectrogram compute code separated from vits. Change base to your wavs's folder path.
from scipy.io.wavfile import read
import torch
import numpy as np
import os
from multiprocessing import Pool
from tqdm import tqdm

# Change here
base="Your wavs's folder path"

hann_window = {}
def load_wav_to_torch(full_path):
    sampling_rate, data = read(full_path)
    # data, sampling_rate = librosa.load(full_path)
    return torch.FloatTensor(data.astype(np.float32)), sampling_rate

def spectrogram_torch(y, n_fft, sampling_rate, hop_size, win_size, center=False):
    if torch.min(y) < -1.:
        print('min value is ', torch.min(y))
    if torch.max(y) > 1.:
        print('max value is ', torch.max(y))

    global hann_window
    dtype_device = str(y.dtype) + '_' + str(y.device)
    wnsize_dtype_device = str(win_size) + '_' + dtype_device
    if wnsize_dtype_device not in hann_window:
        hann_window[wnsize_dtype_device] = torch.hann_window(win_size).to(dtype=y.dtype, device=y.device)

    y = torch.nn.functional.pad(y.unsqueeze(1), (int((n_fft-hop_size)/2), int((n_fft-hop_size)/2)), mode='reflect')
    y = y.squeeze(1)

    spec = torch.stft(y, n_fft, hop_length=hop_size, win_length=win_size, window=hann_window[wnsize_dtype_device],
                      center=center, pad_mode='reflect', normalized=False, onesided=True)

    spec = torch.sqrt(spec.pow(2).sum(-1) + 1e-6)
    return spec

def get_audio(filename):
    max_wave_length = 32768.0
    filter_length = 1024
    hop_length = 256
    win_length = 1024
    audio, sampling_rate = load_wav_to_torch(filename)
    audio_norm = audio / max_wave_length
    audio_norm = audio_norm.unsqueeze(0)
    spec_filename = filename.replace(".wav", ".spec.pt")
    spec = spectrogram_torch(audio_norm, filter_length,
        sampling_rate, hop_length, win_length,
        center=False)
    spec = torch.squeeze(spec, 0)
    torch.save(spec, spec_filename)

if __name__=="__main__":
    waves = []
    for wav_name in os.listdir(base):
        wav_path = os.path.join(base, wav_name)
        if wav_path.endswith(".wav"):
            waves.append(wav_path)
    with Pool(16) as p:
        print(list((tqdm(p.imap(get_audio,waves),total=len(waves)))))

@lpdink, Thanks, I had this error too, and your advice helped me a lot!


feat: split-off MockApplication::assert_no_more_expected_calls into two

Motivation

Resolve #2249

Proposal

split the assert_no_more_expected_calls into two - itself & assert_no_active_instances

Test Plan
CI

@jvff
Could you take a look at the PR?


Add Retina support

Solves #77
Yes, this is an opinionated PR, but we're in the latter half of 2014 and we still don't have Retina support for cmsplugin_filer_image. Some say that we should be doing retina images in CSS. Sure, but what about cases where operators need to upload images? This is precisely what filer is for, and this is precisely where support for Retina/High-DPI belongs.
This is a relatively simple change that does the following:

Adds a checkbox in FilerImage model/plugin labeled "Create a pair of images for Retina/HiDPI.";
When this is checked, the template for filer will add an image attribute data-src with the normal source, and data-src2x with the Retina/HiDPI image source at 2X the supplied dimensions. The normal img tag’s src will reference a 1x1 transparent GIF in cmsplugin-filer's static files;
Also when it is checked, uses Sekazai, to add a very small snippet of JS to insert the correct image into the src, based on whether window.devicePixelRatio is greater than 1.5.

NOTE: This is a change as I've now noticed that Sekazi and jQuery are already dependencies in this project. If jQuery is not desired/required in the project, then overriding the cmsplugin_filer_image/plugins/images/default.html template is all that is required. Here's some appropriate, pure JS one could use:
//
// Enables Hi-DPI images in pure JS, however, please note:
// - Not compatible with IE7 or lower because of querySelectorAll().
// - Not compatible with IE6 or lower because of attribute selectors.
//  '[data-src][data-src2x]', to get around this, filter by class name
//  '.filer_image_hidpi' instead.
//
(function(){
  var use_hidpi = (window.devicePixelRatio > 1.5),
      imgs = document.querySelectorAll('[data-src][data-src2x]');
  for (var i=0, img; i<imgs.length; i++){
    img = imgs[i];
    img.setAttribute('src', use_hidpi ? img.getAttribute('data-src2x') : img.getAttribute('data-src'));
  }
}());

Yes, there will be issues with non-JS environments... most likely screen readers, which won't need/want the images anyway. Also, there's a myth that some people don't enable JS. I've checked on a pretty busy site... there were exactly zero non-bots (i.e., real people) who disabled their JS. Sure, there are cases where the site's audience is likely to not use JS, in these cases, the web developer should simply not check the box labeled: "Create a pair of images for Retina/HiDPI." checkbox and the behavior will just remain as it is now.
Happy to hear suggestions on how to improve this, but its pretty simple and very effective already and has a very low footprint on the overall solution. I'm using it now with very nice results, and the result has brought my PageSpeed Insights score from 65 to 97 (it really didn't like my oversized images before...)

@FinalAngel @jrief @mkoistinen given that the specs has been finalised and is now a standard https://html.spec.whatwg.org/multipage/embedded-content.html#embedded-content), could we rework this PR to comply with the approved standard?

@yakky
Using Javascript sending a HEAD request to determine, if the 2x picture is available, is a really ugly hack, invented about 2-3 years ago.
I fully support this, and would go with <img src="normalsize.jpg" srcset="doublesize.jpg 2x">. This does not require any fixes on easythumbnails, since images are already transformed as 1x and 2x there. So its only about rendering images with 2x in the admin interface, using the above technique.
BTW: djangocms-cascade already supports these kind of images.

+1 for the srcset implementation. I'd recommend explicitly creating  the double size image though, instead of relying on the global 2x option of easy-thumbnails, because then we're not forced to create a 2x version for every image and it will work for people who don't want the global 2x option active.

This PR does NOT "use Javascript to send a HEAD request" at all; that's what RetinaJS does, which is what @jrief proposed earlier, oddly.
This PR is quite declarative. If you need Retina, you click a box and the additional image is created, the JS determines which image is more suitable for that client, and displays that one. It only ever creates @2x versions when its been asked and works well in virtually every browser.

My opinion on this it's that declaring an opt-in for 2x images is good, but this PR should just use easy-thumbnails option to create the @2x image by passing HIGH_RESOLUTION parameter to the templatetag in case the flag is selected; I'd also move the flag to ThumbnailOption and use a future-proof attribute by using srcset to add the high resolution image and write the JS code to act as a polyfill for browser that does not support the standard syntax


Unplash API not viable

Unsplash API freezes requests frequently. Looking for other options to fetch random images open to suggestions.

I believe your issue is that the Unsplash API rate limits you at 50 requests per hour
Ironically if you make an unauthenticated request to https://source.unsplash.com/random then there is not really a rate limit
If you make a request within around 5 seconds as your last then it will just return the same image but I've tested it with well over 100 tabs and it still works
approve my pull request here:

Haha well that's pretty funny. Thanks for the PR.


chore: sort data alphabetically

Sorted every data file apart from commerce_data.h and person_data.h, as sorting them messed up string formatting/ broke tests. Created issue #825 to document the script and run it in a CI pipeline.
Closes #650.

build failed

Build fixed @cieslarmichal.


Fix build

Remove last call site of Str.

Let's wait for the CI build to complete.

Thanks, just stumbled upon this for the JSX branch.

@yunxing I just merged #661. Can you rebase and see if things still make sense?

@chenglou That diff should be good enough. Thanks. I will update this diff to remove unused code.

Killed some dead code.

Feel free to merge after the check.


Trouble with Codeunit DimensionManagement

If I reference Codeunit DimensionManagement the Pre-Compiler shows the following Error Message:

Reference to object DimensionManagement is ambiguous. Make sure you are not referencing packages containing objects with the same names.

I cannot reproduce this error. Creating a variable of type codeunit DimensionManagement works fine.
Could you double check that you don't have any other symbols in your solution named DimensionManagement? If not, can you try to isolate the issue and provide a code sample that reproduces it?

I found out that the unusable Property SIFTLevelsToMaintain in a few Keys created that issue (See #756).
Here a sample project which has this error.
Simple Project.zip

I test VsCode with a solution of 2700 objects (1600 are new objects and the rest are object extensions). After converting with txt2al.exe the Pre-Compiler found 1500 Errors. Now I start at the top and go to the bottom of the list to fix these errors in order to get the solution build.
I have the same Error Message with other Codeunits now. I found out, that if you delete the Symbol Files and close and reopen the solution Go to Definition brings you to another object. In my case to a Pages which has the same Codeunit in some function as variable, but also a Property ControlAddin, which is not supported and cause an right now. If I comment that out, the ambiguous is gone.


Remove automatic scroll when posting ?

Looks like something in 8chan's JS. I don't like messing with that stuff. Maybe make a thread on /operate/?


[Bug] Invalid query

What are you really trying to do?

temporal workflow list -q "ExecutionStatus != 'foo'"
Error: unable to list workflow executions: invalid query: unable to convert filter expression: operator '!=' not allowed in comparison expression
('export TEMPORAL_CLI_SHOW_STACKS=1' to see stack traces)

Environment/Versions

OS and processor: Mac
Temporal Version: 0.2.0 (homebrew)

Maybe != requires advanced visibility, so won't work until SQL adv vis is shipped?

I bet this is true, may have to wait.

i'm seeing that temporal workflow list -q 'ExecutionStatus!="Completed"' works now with 1.20
however for specifically status "foo" just getting context deadline exceeded

Weird, maybe @rodrigozhou knows why?
On Wed, Mar 8, 2023 at 11:08 PM Ruslan @.***> wrote:

i'm seeing that temporal workflow list -q 'ExecutionStatus!="Completed"'
works now with 1.20
however for specifically status "foo" just getting context deadline
exceeded
—
Reply to this email directly, view it on GitHub
https://github.com/temporalio/cli/issues/63#issuecomment-1461244726, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB5LGCIHOXKMAUEYYJEQSLW3FJR3ANCNFSM6AAAAAATK2CF6Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

I found the issue. The error was supposed to be non-retryable because 'foo' is an invalid value for ExecutionStatus, but it's currently retrying until the request times out.
PR fixing the issue: https://github.com/temporalio/temporal/pull/4036


Develop

another pull request, containing same step definition via 'vendor/bin/behat -di'

What does PR title mean?


broken links at plugins.jquery.com

The "View Homepage" and "Read The Docs" links at http://plugins.jquery.com/mixitup/ point to mixitup.io, which is no longer.

Thanks for letting me know. Looks like the jQuery plugin repo is in "read-only" mode now and no longer maintained. Since we've just dropped jQuery, hopefully no longer relevant.


How to include a op code in the first byte always?

Hey @phretaddin!
Thanks for all your help so far!  I have another question.  We want to convert all of our WebSocket messages that are currently using json to schemapack, but we have a problem: how to know which message is witch?
We are using 'ws' package on the server and, standard native WebSocket on the client.
Currently this is easy because when we send a json message one of the peroperties is 'op' e.g.
From server:
ws.send(JSON.stringify({op: 'welcome', message: 'welcome to our game'}));
On client:
...
switch (message.op) {
    case 'welcome':
    handle_msg_welcome(message);
    break;
...

This is easy when using json, but when we convert to schemapack and everything is a buffer, and we're not using Socket.io that can include a string key with every message,  we loose the ability to easily tell messages apart.
Maybe you've already solved this problem in your own projects?  One of the ways I was considering solving this was to make the first byte of every buffer a numeric op code in the schema e.g:
var welcomeSchema = sp.build({
    op: "uint8',
    message: "string",
});
var playerSchema = sp.build({
    op: "uint8',
    health: "varuint",
    jumping: "boolean",
    position: [ "int16" ],
    attributes: { str: 'uint8', agi: 'uint8', int: 'uint8' }
});

Then read the first byte directly before deciding which schema to use to decode:
var op == readFirstByte(buffer);
switch (op) {
    case ops.WELCOME:
        handle_welcome( welcomeSchema.decode(buffer) );
        break;
    case ops.PLAYER:
        handle_player( playerSchema.decode(buffer) );
        break;
...

What do you think of that idea?  If that's a good solution, how do I guarantee that 'op' will always be in the first byte of the buffer?  I know you mentioned that the object is sorted, maybe naming it with double underscore __op: "uint8" or something will force it to be the first in sort order?

Looking at your sort method
Looks like if I add a property of 0 it will sort to the first element of the keys e.g.:
var welcomeSchema = sp.build({
    0: "uint8',
    message: "string",
});

Does that mean that 0 propterty of the schema can always be read as the first byte of the buffer?

Yes, that should work. That's also how I do it for my game. As long as it alphabetizes to the first element, you can just read the first byte to determine the type of the message.

Ok thanks!

Can you share how you are reading the first byte?

Well, I'm receiving it on the server as an ArrayBuffer, so I just create a view for it and then grab the first element:
  var view = new Uint8Array(data);
  var packetType = view[0];

That worked great thanks!!


Need vendor support for Windows Service

To support vDVS plugin running on Windows as a service, we need to introduce a 3rd-party vendor support from https://github.com/kardianos/service.

Fixed with PR #1622.


chore: replace kuttl tests with chainsaw

Replace kuttl tests with chainsaw.

Looks good! Would you please adapt the expect file of the spell checker by adding KUTTL and removing kudobuilder kuttl namespacedelete teststep ? More info here https://github.com/keptn/lifecycle-toolkit/actions/runs/7830812153?pr=3000

Would you please adapt the expect file of the spell checker by removing kudobuilder kuttl namespacedelete teststep ?

@odubajDT done :)


Feature Request : Sass mixins

Hello,
I wanted to include materialize into a current project, and we use a BEM naming, trying to keep Html for markup, CSS for styling.
The problem I have with the current implementation, is that I need to use HTML markup to make styles.
Here what I was thinking doing for example :

    <input type="text" name="user[email]" value="email" />

    <input type="text" name="user[firstname]" value="" />

and in the scss :
@import "materialize/mixins/forms";
.form__field{
   @include input-field();
}

.form__field--active{
   @include input-field();
   @include input-field-active();
}

This way, I could keep clean html markup !
Here an example of mixins I was thinking (untested & using foundation) :
/**
 * Define an input field (group of label + input).
 * When the input have a value, should see `input-field-active`.
 * Example :
 * ```
 * .my-div{
 *   @include input-field(); // default format, see your variables
 * }
 * .my-div2{
 *   @include input-field($margin-top: 18px); // Override the top margin.
 * }
 * ```
 */
@mixin input-field(
  $margin-top: 1rem,
  $font-size: 1em,
  $gutter-width: $gutter-width // use default materialize variable, and can be overriden
){
  $font-size: -zf-bp-to-em($font-size);
  margin-top: $margin-top;
  position: relative;
  & label{
    @include label(
      $label-color: $input-border-color,
      $font-size: rem-calc($font-size)
    );
    position: absolute;
    top: rem-calc($font-size - 2/10);
    left: $gutter-width / 2;
    cursor: text;
    transition: .2s ease-out;
  }
}

/**
 * Input field that have a value setted.
 * Example :
 * ```
 * .my-div{
 *   @include input-field($font-size: 1.2rem);
 *   @include input-field-active();
 * }
 * ```
 */
@mixin input-field-active(){
  transform: translateY(-140%);
}

/**
 * Set the global HTML markup for the whole project.
 * For the ones that want to keep using materialize classes.
 */
@mixin global-input(){
  .input-field{
    @include input-field();
  }
  .input-field.active{
    @include input-field();
    @include input-field-active();
  }
}

In summary, my feature request is to use a bit more Sass features in the whole project. All the defined classes should use only mixins. And there is also the possibility here to stop adding classes that we don't use.
Will execute CSS faster, make a smaller file, and be able to work with foundation or bootstrap.
Materialize should be super easy to customize, and this is actually not really the case.
Thanks for reading my bad english, and um abraço do Brasil.

There is a great way to avoid the tech-deb.
but what about the js? It seems to be a refactor problem, and could cause a lot of issues, I thought.
off-topic: I like to use grammarly.com to improve my writing, it's also used also by native speakers!
Un abrazo desde Colombia.

Well you are right ! After looking closer to the sources, it's looks like the classenames are not in options, but hard-coded in the js. I tought as everything is jquery plugin in materialize you would have the ability to specify your classes when instanciate them.
From the start it wasn't planned this way, and it seems difficult to make any moves without breaking everything. Seeing no movement for the past year, I would suggest you to close this feature request.
Thanks


Separate image resources from application

Images should be uploaded separately only once and updated when needed. TCC should not include them and checkand download them only if needed. This will make the application smaller, allowing faster updates.

Started in caa02874dec31a48067e95afae5af917bff4619f.

Finished in 3f422a15c778e44eac0eec816f932c5c1a63d615.


E (376645) esp_mqtt_glue: MQTT_EVENT_ERROR E (391653) esp-tls: couldn't get hostname for :a1p72mufdu6064-ats.iot.us-east-1.amazonaws.com: getaddrinfo() returns 202, addrinfo=0x0 E (391653) esp-tls: Failed to open new connection E (391658) TRANSPORT_BASE: Failed to open a new connection E (391663) MQTT_CLIENT: Error transport connect E (391667) esp_mqtt_glue: MQTT_EVENT_ERROR

E (376645) esp_mqtt_glue: MQTT_EVENT_ERROR
E (391653) esp-tls: couldn't get hostname for :a1p72mufdu6064-ats.iot.us-east-1.amazonaws.com: getaddrinfo() returns 202, addrinfo=0x0
E (391653) esp-tls: Failed to open new connection
E (391658) TRANSPORT_BASE: Failed to open a new connection
E (391663) MQTT_CLIENT: Error transport connect
E (391667) esp_mqtt_glue: MQTT_EVENT_ERROR

Closing this issue as it looks same like #199


Your Ship? (V)

"Your Ship? (V)" also has an incorrect imageUrl, but I'm not sure what its supposed to be.  I don't see it in the holotable github repo so I'm not sure what to change it to.

Just pushed a fix for this.  Path was: "https://res.starwarsccg.org/cards/Images-HT/starwars/VirtualPremium-Light/large/yourship.gif?raw=true"


Link type fails to serialize

I'm using the Link type to model a relation to another collection, but when I try to serialize it, it fails with a strange error:
ValueError: [TypeError("'_thread.lock' object is not iterable"), TypeError('vars() argument must have __dict__ attribute')]

This is in the context of FastAPI, using their jsonable_encoder.
I suppose it is failing while trying to encode the link object. Is the encoding of the Link type simply not yet implemented, or am I not seeing something?
Full traceback:
ERROR uvicorn.error:380 – Exception in ASGI application
Traceback (most recent call last):
  File ".../lib/python3.10/site-packages/uvicorn/protocols/http/h11_impl.py", line 377, in run_asgi
    result = await app(self.scope, self.receive, self.send)
  File ".../lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 75, in __call__
    return await self.app(scope, receive, send)
  File ".../lib/python3.10/site-packages/uvicorn/middleware/message_logger.py", line 82, in __call__
    raise exc from None
  File ".../lib/python3.10/site-packages/uvicorn/middleware/message_logger.py", line 78, in __call__
    await self.app(scope, inner_receive, inner_send)
  File ".../lib/python3.10/site-packages/fastapi/applications.py", line 212, in __call__
    await super().__call__(scope, receive, send)
  File ".../lib/python3.10/site-packages/starlette/applications.py", line 112, in __call__
    await self.middleware_stack(scope, receive, send)
  File ".../lib/python3.10/site-packages/starlette/middleware/errors.py", line 181, in __call__
    raise exc
  File ".../lib/python3.10/site-packages/starlette/middleware/errors.py", line 159, in __call__
    await self.app(scope, receive, _send)
  File ".../lib/python3.10/site-packages/starlette/middleware/cors.py", line 92, in __call__
    await self.simple_response(scope, receive, send, request_headers=headers)
  File ".../lib/python3.10/site-packages/starlette/middleware/cors.py", line 147, in simple_response
    await self.app(scope, receive, send)
  File ".../lib/python3.10/site-packages/starlette/exceptions.py", line 82, in __call__
    raise exc
  File ".../lib/python3.10/site-packages/starlette/exceptions.py", line 71, in __call__
    await self.app(scope, receive, sender)
  File ".../lib/python3.10/site-packages/starlette/routing.py", line 656, in __call__
    await route.handle(scope, receive, send)
  File ".../lib/python3.10/site-packages/starlette/routing.py", line 259, in handle
    await self.app(scope, receive, send)
  File ".../lib/python3.10/site-packages/starlette/routing.py", line 61, in app
    response = await func(request)
  File ".../lib/python3.10/site-packages/fastapi/routing.py", line 226, in app
    raw_response = await run_endpoint_function(
  File ".../lib/python3.10/site-packages/fastapi/routing.py", line 159, in run_endpoint_function
    return await dependant.call(**values)
  File "..../app/sites/router.py", line 21, in list_sites
    sites_json = jsonable_encoder(sites)
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 115, in jsonable_encoder
    jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 66, in jsonable_encoder
    return jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 101, in jsonable_encoder
    encoded_value = jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 145, in jsonable_encoder
    return jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 101, in jsonable_encoder
    encoded_value = jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 145, in jsonable_encoder
    return jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 145, in jsonable_encoder
    return jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 101, in jsonable_encoder
    encoded_value = jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 145, in jsonable_encoder
    return jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 145, in jsonable_encoder
    return jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 101, in jsonable_encoder
    encoded_value = jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 93, in jsonable_encoder
    encoded_key = jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 145, in jsonable_encoder
    return jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 145, in jsonable_encoder
    return jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 101, in jsonable_encoder
    encoded_value = jsonable_encoder(
  File ".../lib/python3.10/site-packages/fastapi/encoders.py", line 144, in jsonable_encoder
    raise ValueError(errors)
ValueError: [TypeError("'_thread.lock' object is not iterable"), TypeError('vars() argument must have __dict__ attribute')]

When I add a custom json encoder for the Link type, it works fine.
Quick hack:
class Here(Document)
    there: Link(There)

    class Config:
            json_encoders = {
                Link: lambda v: { "_id": str(v.ref.id) },
            }

A clean version of this as part of the Link class would probably be sufficient.

A slightly cleaner version that retains all the DBRef properties would look like this:
    class Config:
        json_encoders = {
            Link: lambda v: {
                "$id": str(v.ref.id),
                "$collection": v.ref.collection,
                "$database": v.ref.database
            }
        }

When I add a custom json encoder for the Link type, it works fine. Quick hack:
class Here(Document)
    there: Link(There)

    class Config:
            json_encoders = {
                Link: lambda v: { "_id": str(v.ref.id) },
            }

A clean version of this as part of the Link class would probably be sufficient.

Looks like you are using Link(There) instead of Link[There] (parenthesis vs brackets) as per the documentation could that be the root cause of your issues ?

Thanks, good point–but no, that was just an oversight while typing up the issue here. 😄


Custom instrumentation methods opt-in for Object

I've been meaning to PR this for some time.
It allows measuring of arbitrary methods without much code overhead. We use it in production a lot.
Not sure if monkey patching Object (even if opt-in) is such a good idea for everyone. Happy to make it a module instead if so desired.

Thanks for the patch @timonv :-)
We're working on making a few changes in this area. I will definitely  draw inspiration from this one :-).


easytrace-bot-adding remotecommandlet in proto

Duplicate code. Possible refactor?

its an auto generated code from .proto service definition.Let me see if i
can fix this.
On Fri, May 4, 2018 at 10:58 PM, Jurgen Schatz<EMAIL_ADDRESS>wrote:

Duplicate code. Possible refactor?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/weAutomateEverything/go2hal/pull/185#issuecomment-386732673,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ag92S5BslVRQQn3sO_jFFDY8IhPIXNd4ks5tvMDngaJpZM4TzAxZ
.


Remove extra --join flag from cloud migration tutorial

Follow-up to https://github.com/cockroachdb/docs/pull/3357.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/87b63b334b1c651e9ea4dc847c2764376624834a/


Add documentation on adding authentication

This adds a page on setting up authentication in app, it's mostly tailored towards existing apps and is mostly to help: https://trello.com/c/8VZznDSn/1-make-apis-authenticate-when-talking-to-each-other but it's probably a good to have it documented long term anyway.

@kevindew Thanks for doing this! 👍 💯 🥇