Plugin management not working

Can not add  map to poller:

Can not add group to poller:

The first time you open the settings, an error occurs:

Can be fixed on https://github.com/howardjones/network-weathermap/pull/157

Don't fix at last commit

browser consol error fixed, but function not working

This should be working now (I've been adding groups this weekend). You still can't move an existing map to a new group, but that's just because the code isn't there yet.

In the settings there is still a lot of things not working, for example, I can not turn off or turn on the debug map.
Probably it is worth creating a separate issue for each functional, how do you think?

It isn't finished. I guess there could be an issue for each missing item,
but it will be a lot of issues! This is the kind of thing github project
boards are for, but I haven't figured out how to choose which issues go on
a board yet.
On Mon, 8 Oct 2018 at 15:39, Alex<EMAIL_ADDRESS>wrote:

In the settings there is still a lot of things not working, for example, I
can not turn off or turn on the debug map.
Probably it is worth creating a separate issue for each functional, how do
you think?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/howardjones/network-weathermap/issues/156#issuecomment-427861061,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA3sJXYkvpj0BBKpbawKRulvXAJBFqRaks5ui2OzgaJpZM4Wrl5s
.

If you create the project using one of the automated templates, you can search and add issues that are open via the "Add Cards".  I've created a test project for you on a test repo so you can see... you could have done the same but figured if I got one done, it gives you more of an idea.

https://github.com/netniV/project-test

Thanks! Just trying to figure out if there's a pleasant way to turn a big text list into a lot of issues, all with the right labels.

You could use the github API to drag out the open issues or a specific post, then post the post feature.

I'm going to try this: https://github.com/gavinr/github-csv-tools to create the issues with the right labels, at least.

Well, I have 28 new issues lined up in a CSV file, anyway :-) Haven't quite figured out how to get them in yet.

You need to get an API token to use with index.js, then you just run that with nodejs I think...

Yep - didn't have the right token permissions. Lots of nice new issues now, all sitting in the 1.0 and 1.1 release project boards.

You just spammed my many devices!! 👍 😆 🤣 😱


feat: add api for capi provider

What this PR does / why we need it:
This is work in progress to add the CRD for a capi provider
CRD definition in markdown: https://github.com/Danil-Grigorev/rancher-turtles/blob/providers_api_spec/capiprovider.md
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist:

[ ] squashed commits into logical changes
[ ] includes documentation
[ ] adds unit tests
[ ] adds or updates e2e tests

I can't approve as i am a commit but from my side LGTM


Allow specifying number of lines in a mat-list-item

The framework tries to be clever and count the mat-line children to determine whether to put mat-2-line and mat-3-line classes on a mat-list-item. Sometimes, though, the real contents is too complex to have top-level mat-line items, and I just want to specify that I want the mat-3-line styling. However, if I add this class myself, Angular helpfully removes it :/
It'd be great to be able to specify this somehow, possibly just through the class, or through a mat-3-line directive.
Right now, my workaround is to put some empty divs in like:

@calebegg can you post what your template looks like? Rather than adding a separate API, it might make sense to mark our query as descendants: true so that it picks up all descendant items, rather than just the direct ones.

Oh, that would work. I didn't know it would be that easy.
It's basically something like:
<mat-list-item>

foo

detail

timestamp

status

    <button mat-icon-button>...</button

</mat-list-item>

I'd be tempted to put mat-line on the timestamp and status divs as well if I didn't understand how it worked, so I'm not sure if it's exactly clear what's happening, but it would definitely solve the issue for me and I think it would be an improvement over what we have now.


Optimize negative numbers

Include the negative sign in the buffer and write everything at once.
This will probably make no difference in most Writers but I guess it's still valid.

Thanks but I benchmarked this and it performs about 20% worse for signed integer types. The extra if statement is very expensive.

Oh, I missed that. I guess it's no worth optimizing for non-buffered/memory writes anyway.


Inferencing from Text

❓ Questions and Help
Looking at evaluating TextClassifier from
python examples/pytorch/text_classification/run_text_classifier.py -config examples/pytorch/text_classification/config/trec/ggnn_bi_fuse_constituency.yaml
run_text_classifier 'main()' does training and testing using data loaders.
Wish to test the trained model, by supplying sample text directly. meaning, can I predict label by giving text?
TextClassifier to have following method:
def predict(self, texts):
	predicted_labels = model.foo(texts)
	return predicted_labels

TextClassifier only receives the GraphData object (not the raw texts).
As we discussed in #319 (issue), currently this feature is natively supported. If you want to decouple the training and inference stages, you could implement it by constructing the GraphData given raw text inputs during inference.

It will be an important feature in the next version. Thank you!


Added code instrumentation capability:

caliper based instrumentation added
add command line option to select instrumentation type

Should this be closed for now?


[docker] split pkg/util/docker files into smaller ones

What does this PR do?
The util/docker package has lots of features and the docker.go and docker_util.go files grew to a hard to manage size. This PR moves some code to three new files:

filter.go for container filtering
network.go for container networking stuff
networkstats.go for network stats coming from /proc/$$$/net, as these might be useful for other container runtimes

I also un-exported util methods that have no use outside of the package.
Tests have also been split according to the new files. This will allow easier navigation into the codebase and less merge issues.

I approved the new layout, but if a line is missing I couldn't find it for my life 🙈


Dynamic view compilation fails because of RazorPage under linux>dotnet>net451>.NETFramework,Version=v4.5.1>mono 4.2.3

Hi.
I am trying to get ASP.Net running under docker. So far so good I got kestrel serving pages but then Razor fails with the following errors produced in the browser.

Cannot define a class or member that utilizes 'dynamic' because the compiler required type 'System.Runtime.CompilerServices.DynamicAttribute' cannot be found. Are you missing a reference?

public class _Views_Home_Index_cshtml : Microsoft.AspNetCore.Mvc.Razor.RazorPage<dynamic>

What can be done about this?
  Always after the quick buck those guys, sigh.
Wait the kestrel does not have to be on net451...but then nothing works on netcoreapp1.0.

Do the views work locally i.e. outside the container?

Not inside linux no.
It only works when you run it natively on windows or through iisexpress.
The issue seems to be that the 'dynamic' type support is not seamless in mono. It comes from Mono's System.Core assembly that is somehow not part of razor's run time environment.

Mono has this type, razor can not use it for some reason:
https://github.com/mono/mono/blob/ef407901f8fdd9ed8c377dbec8123b5afb932ebb/mcs/class/System.Core/Documentation/en/System.Runtime.CompilerServices/DynamicAttribute.xml

We don't have coverage for Mono at this point, but we've had no issues running apps with Mono 4.0.5. What version are you using? We have coverage for .Net Core and that should definitely work.

I use Mono 4.3.2.
I got by the issue by just copy and pasting that class into my project. Now I get a different set of errors that are the same on types that are from mscorlib:

An error occurred during the compilation of a resource required to process this request. Please review the following specific error details and modify your source code appropriately.
Generated Code
Predefined type 'System.Boolean' is not defined or imported
public class _Views_Home_Index_cshtml : Microsoft.AspNetCore.Mvc.Razor.RazorPage
The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'.
public class _Views_Home_Index_cshtml : Microsoft.AspNetCore.Mvc.Razor.RazorPage
The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'.
public Microsoft.AspNetCore.Mvc.IUrlHelper Url { get; private set; }
Predefined type 'System.Object' is not defined or imported
public Microsoft.AspNetCore.Mvc.IUrlHelper Url { get; private set; }
Predefined type 'System.Void' is not defined or imported
public Microsoft.AspNetCore.Mvc.IUrlHelper Url { get; private set; }
....

I must say, this is causing all kinds of headaches for me. Research is leading me to places like this:
https://blogs.msdn.microsoft.com/mvpawardprogram/2015/06/18/demystifying-pcls-net-core-dnx-and-uwp-redux/
Things are getting too complex now.

I saw your comment in the other bug - are you trying to run netcoreapp1.0 binaries using Mono?

No.
We would love to run netcoreapp1.0, but that target framework is not "production ready". 3rd party libraries simply don't work so we have to continue on net451.
The problem is that ASP.Net Core dynamic view compilation does not work on framework net451 on Linux (it does on Windows). This is because Mono is not exactly the same as .NetFramework 4.x on Windows.
So basically we are stuck with our CI docker system. We cannot run the Kestrel server on Linux. We can run our API, which is also Kestrel (and net451), under Linux/dotnet/Mono  just fine because it does not do the rocket science .cshtml dynamic razor view compilation stuff that fails. So we are almost there.
Therefor, to conclude. We desperately need someone that works on razor to look at these issues. I am sure that an engineer would instantly understand what the problem is. For example, that they are using reflection and that does not work under Mono because the specific types they are looking for does not exist or cannot be found in the way that they are looking for them (System.Boolean & Object).
To reproduce the issue: Just create a basic ASP.Net Core MVC Web app with a index.cshtml under net451 and try to run it under Linux with dotnet and Mono installed on it. It will take 5 minutes to reproduce. It will take 6 minutes to fix.

@pompomJuice see the discussion here - https://github.com/aspnet/Mvc/issues/4818#issuecomment-224167616 and a possible workaround at https://github.com/aspnet/Mvc/issues/4818#issuecomment-224181486.


Net48 sdk

pull

@MRMcBaicn , we keep net48-sdk branch ( targets .NET 4.8 ) separate from the main branch which targets ( .NET versions ). Therefore, I am closing this PR.
However, we appreciate your contributions and you can take on other bugs/issues.


Create GUI

A CLI is alright, but for someone brand new to coding, opening up a Terminal, installing node and npm, and then installing this module can be a little daunting. My goal is that this would be a one click solution. With Electron, this is totally possible! The flow that I'm thinking of is that the user launches the app, and then just starts coding. It'll create a directory for their code to live automatically, though the user could change it if they want.
I'll likely start working on this once I've finished up v2.0.0. (GH-2)

Expanded notes (cc @abacon, sorry for the delay!):

The GUI should be super easy to use. Like the CLI is just one command, the GUI should just be one click.
The user should be able to set which directory they want to have the server run in. It should have a default, though. (~/Documents/run-js, or the platform equivalent, for example)
Mac and Windows for the initial release. Windows is important, since there's a lot of people who use Windows with Node, especially newbies. It'll be a bit of an extra complication for the build step, but with modules like electron-packager and electron-builder, it shouldn't be too bad.
The GUI should feel native on each platform. Custom styling for each platform is fine for me.
I had initially planned the ability to add more handlers/transforms/plugins in the app, but for the initial release, I want to leave that out. I want to make sure that the core functionality works first, and then extra features can be added on from there.
Ideally, there should be auto updates. Electron has the auto-updater module, but the set up for it is a bit annoying, since it requires a custom server. There are modules that interface over it so that it uses GitHub Releases (see: https://github.com/GitbookIO/nuts), but even then, there'd have to be a lot of extra logic, like signing releases, and generating certain update files for Windows. The apps should be signed, of course (safety! woo!), but I'm considering having a system that just prompts the user to download a new version from a website to start with. It's not the best user experience, but it'll be easier to start with. Once the core app is done, and more people are using it, then I'd probably take the time to properly set up auto updating.

This is awesome! I've got a prototype that's almost ready... I'll try to get it done today so you can take a look. I think we've both thought more or less along the same lines. :raised_hands: :exclamation:

@remixz ok, don't judge too hard... 😳 https://github.com/abacon/run-js-app

No judging here! This is super radical!! :boom:
This is really awesome to see in action. It has some bugs, of course, but I'm mostly just excited to play with it. This is really starting to feel like how I imagined run-js to be.
I like the idea of having multiple project folders. I didn't even think of that, but it actually works really well. There'll have to be port management, so that multiple can run at once, but that's a really solid idea.
I'm not the biggest fan of menu bar apps, but that might just be me... I sometimes find keeping track of a bunch of icons in the menu bar kind of annoying. Not really that big of a deal, though. I'll play around with it.
I'll likely be pushing up some of my work on the GUI up to a repo soon. I'll add you as a contributor to that as well, @abacon. Again, awesome work. Thanks for bringing in some great ideas. This is exciting! :smile:


feat: composer cli commands

Commands

graph

create: Create new graph
delete: Delete the graph from database
list: List all the graphs in the database
print: Print json representation of graph object

rule

create

and: Create new and rule
atleast: Create new atleast rule
or: Create new or rule
sign: Create new sign rule

delete: Delete rule from graph
connect: Connect two rules within graph
disconnect: Disconnect two rules within graph

Dependent on #10


Did Change Content Callback

Hello,
I am having a really hard time understanding the delegate mechanism of fetched results controller and fetch request controllers.
example:
self.fetchedResultsController = PersistentStore.sharedInstance.articles.orderByDescending({$0.publicationTimeStamp}).toFetchedResultsController()
then, after my networking and saving is all done, there is a call to my DataContext:
try! self.save()
which doesn't seem to update my fetched results controller. What would be the proper way of using NSFetchedResultsController with the data context?

Actually, it was a bug in my code, too difficult to explain, and wouldn't help anyone explaining it. Thanks for the awesome library.


Update akka-sse to 3.0.0

Updates de.heikoseeberger:akka-sse from 2.0.0 to 3.0.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "de.heikoseeberger", artifactId = "akka-sse" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "de.heikoseeberger", artifactId = "akka-sse" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by https://github.com/sangria-graphql/sangria-subscriptions-example/pull/23


How to train with pretrained model

How can I train my own data with your small_satrn pretrained model? Thank you.

Please refer to #30.


added test unit for event classification with sklearn MLPClassifier

Since I tested some nice behaviour with sklearn MLPClassifier on my own with ASTRI MC data, I just added some test unit  in ctapipe.
I noticed I couldn't use the StandardScaler()  available in sklearn.preprocessing module, since the feature_list in the code is a dict: ideas? Should I take the dict values for the scaler, or override the StandardScaler and let it accept the dict type input?

maybe you can add a member function to RegressorClassifierBase that takes the feature_list as the dict that it is now and calls StandardScalar internally?

If the classifier was trained with scaled features, should the prediction not also be performed the same? Do we have to store the range of the scaling to disk with the fitted model?
The predict test seems to have passed, so I wonder why...

Yes. This can be stored using an sklearn pipeline.
http://scikit-learn.org/stable/modules/generated/sklearn.pipeline.Pipeline.html

cool, if I understand this correctly, we can use this Pipeline directly in-place as the classifier argument? Then it also should work with save and load just like that.

Yes, But I think one needs to use
http://scikit-learn.org/stable/modules/generated/sklearn.preprocessing.StandardScaler.html#sklearn.preprocessing.StandardScaler
Instead of the plane scale function.

Should I code a version with Pipeline and StandardScaler?

Sure, please.
FYI I'm on vacation now for the next few days with sparse internet.
On Tue, 4 Jul 2017, 17:59 francesco visconti<EMAIL_ADDRESS>wrote:

Should I code a version with Pipeline and StandardScaler?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cta-observatory/ctapipe/pull/459#issuecomment-312910830,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARcFv9ZeDslKnbS5xRSvuCOGrg0xWSwiks5sKmFogaJpZM4OMZM4
.

I successfully tested a version with no pipeline.
Now, I tried naively to write this one too:
def test_pipeline_classifier():
cam_id_list = ["FlashCam", "ASTRICam"]
feature_list = {"FlashCam": [[1, 10], [2, 20], [3, 30], [0.9, 9],
[10, 1], [20, 2], [30, 3], [9, 0.9]],
"ASTRICam": [[10, 1], [20, 2], [30, 3], [9, 0.9],
[1, 10], [2, 20], [3, 30], [0.9, 9]]}
target_list = {"FlashCam": ["a", "a", "a", "a", "b", "b", "b", "b"],
"ASTRICam": ["a", "a", "a", "a", "b", "b", "b", "b"]}
    estimators = [('scaler', StandardScaler()), ('clf', MLPClassifier())]

    clf = EventClassifier(classifier=Pipeline(estimators), cam_id_list=cam_id_list,
                                      clf__max_iter=400)
    clf.fit(feature_list, target_list)

    prediction = clf.predict_by_event([{"ASTRICam": [[10, 1]]},
                                                             {"ASTRICam": [[2, 20]]},
                                                             {"ASTRICam": [[3, 30]]}])
    assert (prediction == ["a", "b", "b"]).all()

    prediction = clf.predict_by_event([{"FlashCam": [[10, 1]]},
                                                              {"FlashCam": [[2, 20]]},
                                                              {"FlashCam": [[3, 30]]}])
    assert (prediction == ["b", "a", "a"]).all()`

but then I get this error:
E           TypeError: 'Pipeline' object is not callable
I suppose we should change the RegressorClassifierBase to have it works..
Shall I meanwhile push skipping the pipeline test?

Is this definitively approved?

Thanks to @tino-michael for fixing the Pipeline usage.
Shall I be notified here when this pull request is merged?

Yes, since you are in the list of participants, you should get an e-mail again when this is merged.
Cheers :-)


./ethd update fails with: failed to solve: process "/bin/sh -c set -eux

Hi, I have been running eth-docker for a while and now i am getting this error when i tried to update. I also pruned docker and updated to the latest version but the issue persist.
Docker version: 23.0.4

This says it couldn’t get the Ubuntu archive. This may have been a temporary issue with network connectivity. This is easier to troubleshoot interactively on discord


Error in Typings

Hello,
I see getContext typings seems wrong:
https://github.com/telegraf/telegraf-session-redis/blob/develop/lib/session.d.ts#L39
It is:
getSession(key: Context): string;

but I expected it to be:
getSession(key: string): Context;

and in the code it seems to work like the latter, i.e. returning an object.

Checkout this fork: https://github.com/igorivaniuk/telegraf-session-redis


read timeouts and iter_lines

I want to be able to consume an HTTP stream of indefinite length, but I also want a way to cleanly exit the read loop that doesn't involve killing the thread. Here's what I've got:
import threading
import socket
import requests

resp = requests.get('http://some-url/', stream=True, timeout=5)

quit = False
quit_lock = threading.Lock()
it = resp.iter_lines(chunk_size=1)
while True:
    quit_lock.acquire()
    if quit:
        quit_lock.release()
        break
    quit_lock.release()
    try:
        line = next(it)
    except StopIteration:
        break
    except socket.timeout:
        print('read timed out')
        it = resp.iter_lines(chunk_size=1)
        continue
    print(line)

The idea here is that a separate thread can set quit = True and this read loop will exit within some seconds. The approach works fine on Python 2 but fails on Python 3. On Python 3, once a read has timed out, a subsequent read will fail with the exception:
OSError: cannot read from timed out object

Is this a bug in the requests library? Or is it simply a limitation of Python 3? Or is there some other workaround?

This seems to be a limitation of Python 3, introduced in Issue #7322. The core problem here is that the read and readline methods of Python socket objects use internal buffers, in order to satisfy the read contract that says that reads should only return less than amt if the data stream is closed (see also shazow/urllib3#709). These internal buffers can get screwed up if the timeout is thrown during a later recv call.
Now, we don't actually use those methods directly, but http.client does, and also provides some internal buffers of its own. Those buffers are also at risk of being screwed up.
Finally, iter_lines also uses buffers internally, which are also lost when this exception fires. This doesn't matter for you in the "everything is working fine" case, because you only expect the exception to fire once a newline has been received (so the internal buffer is empty), but if anything went wrong it would fire mid-line and you'd lose the whole line.
There are two ways that leap out at me to make this work, only the first of which uses the majority of your code. The first is a bit gross, because it involves reaching way into requests and urllib3, but it should be fairly stable (the objects you're touching aren't moving around a lot). This involves using select and timeouts instead. You could write this:
import threading
import select
import socket
import requests

resp = requests.get('http://some-url/', stream=True, timeout=60)

quit = False
quit_lock = threading.Lock()
it = resp.iter_lines(chunk_size=1)
while True:
    quit_lock.acquire()
    if quit:
        quit_lock.release()
        break
    quit_lock.release()

    try:
        if not select.select([resp.raw._fp.fp], [], [], 5)[0]:
            continue
    except TypeError:
        # Raised if the connection is completed
        break

    try:
        line = next(it)
    except StopIteration:
        break

    print(line)

The second approach is to use a proper concurrency framework for this job. Obviously, that's a bit out of scope for this repo so I won't go into it more, though I'm happy to point out some frameworks that would help if that would be useful (e.g. asyncio, Twisted).

Ah yes, I wondered if I could use select somehow. Thanks for the tip. Would this also work for HTTPS connections or would there be a different fd to check?

It should be the same fd.

So this approach almost works. On the first iteration, the select is not considering the fd readable even though there is data to read. I think what is happening is any initial data is being buffered inside the response object (or some other layer) and so has already been read by the time we poll the socket. Once new data arrives on the socket, it becomes readable, and the client reads the initial data.
Is there a way to test if there is buffered data to try to read?

Is there a way to test if there is buffered data to try to read?

Oof, harder. I don't immediately see anything here. I can't even see where the buffer is: it's not in socket or io AFAICT, so I'd have to guess it was in http.client, but I can't see it in there either. Someone, somewhere, has buffered your data above the socket level, but I don't know who did it.


How to pass component prop values to static-query GraphQL

Is is possible for a Vue component to accept a prop value and pass it into its GraphQL static query? ex: ID of reference from parent.
<template>

		{{ $static.jumbotron.heading }}

</template>
<static-query>
	query Jumbotron($id: String!) {
		jumbotron: contentfulJumbotron(id: $id) {
			heading
		}
	}
</static-query>

Greatly appreciate the insights! Thanks.

Still a bit new to Gridsome and wanted to follow up. Is this the wrong way of looking at how to bring in a long-form list of referenced content types? (in this case via Contentful). Thanks! :)

Both page-query and static-query are handled on the server, so they don't have access to JavaScript variables, unfortunately. But you will be able to have the current node id as the $id variable in your page-query in the next version of Gridsome :)

Should this be closed?
Am i right in saying "'static-query' is called static as it can not accept any variables" I can add this to the docs.

@sanscheese Yes, that's correct. I want to look into giving it a global state sometime. Maybe it could be meta data from the project config. That would at least make it possible to give it some context.

So whats the alternative solution?

@hjvedvik so to confirm, does this mean that a component in gridsome can never access the store for any data other than what can be queried with its own ID?
For example, rendering a side navigation for a sub-section- where I want to query pages that are children of a parentID passed as a prop?

@hjvedvik & @nolfranklin perhaps I should query all pages in v-for and v-if until I get values matching props. Move the logic out of graphql query since I can't feed it custom variables from props...
@nolfranklin you can also grab all and v-for v-if to get the one you want. Inefficient, but thats a cost on gridsome build which is only seconds anyway.

@Kainkainkain You can get data based on static IDs in the query, but it won't be possible to pass JS variables into the query, unfortunately. I would get all navigation items in one query and have a helper method to find items base on a parent ID. Maybe something like this:
<template>

...

</template>

export default {
  methods: {
    getNavItems(parentId) {
      return this.$page.allNavItem.edges.filter(edge => {
        return edge.node.parentId === parentId
      })
    }
  }
}

Slick! Sweet I'll use that code. Will help also for a top nav with show / hides for children.


Make Alumni section collapsable?

The main page of the website is getting a bit crowded imo. I cna try to make the Alumni part collapsable or a separate page.
Toughts?


RSS?

This looks like a great blog with great technical insights. I've very much enjoyed reading it, but I am going to miss future updates since I don't generally go to Github to read blogs and the updates are easily lost in the stream of updates. You guys should look into using Jekyll or Octopress to generate a page with an RSS feed to enable a good reading environment.

We've had several similar requests, so moving to something like Jekyll is definitely something we are going to do in the (hopefully near) future. It's just a matter of finding the time to learn the tools and set everything up.


Shokofin not fetching trailers/credits

Jellyfin version.
10.9.8
Shokofin version.
<IP_ADDRESS>
Shoko Server version, release channel, and commit hash.
4.2.2 Stable
File structure of your Media Library Folder in Jellyfin/Import Folder in Shoko Server.
../Anime Title/Season X/S0XE0Y: Episode Title
Screenshot of the "library settings" section of the plugin settings.

Library Type(s).
Shows
Do the issue persists after creating a library with Shoko set as the only metadata provider? (Now is your time to check if you haven't already.)

[X] Yes, I hereby confirm that the issue persists after creating a library with Shoko set as the only metadata provider.

Issue
Shokofin doesn’t add trailers for a series (not yet tested for movies, so unsure about that) into a trailers folder that Jellyfin supports. I have VFS turned on, so I can’t manually add a trailer either. The same goes for credits as well, but I can live without it, although support for that would be great as well.
Stack Trace
No response

is this a shows type library, or a mixed type library?

are the trailers recognised in shoko?

Also, just to be sure, but you don't see this icon in the UI?

are the trailers recognised in shoko?

I'm new to Shoko, so I'll ask this, just to be sure:
Will Shoko fetch trailers from some online source or do I have to place a trailer into my import folders, and Shoko can check the hash to detect it as a trailer?
If the answer is that Shoko automatically fetches trailers from an online source, is there any way to check that Shoko has indeed fetched a trailer and the issue is specific to Shokofin?

shoko onpy provide local tdaileds (for mow at least) that are recognised by shoko itself.

Also, just to be sure, but you don't see this icon in the UI?

That icon shows up as YouTube Trailers Plugin was enabled for me. If Jellyfin has fetched a YouTube Trailer and there exists a trailers folder, Jellyfin will prioritize the media inside the trailers and ignore the YouTube Trailers completely.
Since, clicking on that icon loads up a YouTube Trailer, I suspected Shokofin didn't create a trailers folder. I confirmed the lack of such folder, when I looked inside the VFS folder to see there were Season X folders will symlinks to my episodes, but no trailers folder.
I have disabled YouTube Trailers as 90% of the trailers that Jellyfin fetches are region-restricted, so it doesn't load up.

shoko onpy provide local tdaileds (for mow at least) that are recognised by shoko itself.

So, I have to manually place a trailer content in my import folders and Shoko should recognize it as a trailer. Is that correct?

You can either

create a trailer folder in the VFS entry for the show/season and place the youtube video you downloaded in there, followed by a refresh of the show/season in Jellyfin afterwards, or

you can add a trailer to shoko (either automagically through hash recognition or manually by linking using Shoko Desktop), and it will automagically be linked to the trailer folder for the show and season in Jellyfin.

EDIT: I downloaded a trailer from YouTube and threw it in Shoko's import folder. It categorized it as "Unrecognized".

That is intended behaviour if hash recognition doesn't work btw. You need to manually link anything that is not indexed on AniDB (or add it if it's a public release, which the downloaded youtube video is not).

If there is a plugin that places files in a trailer sub-directory for the show/season then it should in theory work fine even with the VFS (provided they've written it to work with relative paths the same way Jellyfin would resolve the trailers). Not that I've done any research to check if there are any.


Provide a custom option for ViewTransition

What ?
This PR aims to provide an additional flag to ViewTransitions besides .reload and .animated.
Why ?
In many scenarios - simple batch reloads might create a choppy animation or cause some UIKit-related animation glitches.
Many of these are usually resolved by some sort of a “workaround” such as doing beginUpdates, endUpdates manually on a UITableView, or coordinate some other timing mechanism to overcome UIKit’s issue .
This PR lets users who wish to do so, an option to provide a custom transitioning logic for their entire UITableView / UICollectionView.
Breaking Changes
None. This is a purely additive change.

Hi @freak4pc, out of curiosity what is the reason that this pull request was closed? This looks like a really handy feature that would be great for achieving custom animations on cell reloads, which is something that I have struggled with in the past.

Krunoslav was against adding it. We had a discussion out of github and I decided to close. I

Oh ok. If you don't mind my asking did you find another way of solving this problem? I have been trying to come up with a way of using RxCollectionViewSectionedAnimatedDataSource with custom cell reload animations, but haven't had any luck so far.


Make extendr-engine dev-dependency

Fix #144
The main purpose of extendr-engine was not to call non-API symbols in R (#46). But, in actual, extendr-api unconditionally depends on it to execute tests. So, we need to opt-out the tests and accordingly the dependency on extendr-engine.
I'm yet to figure out how to do this elegantly. Currently, I made extendr-engine as the default feature because otherwise I probably need to add no_run to all the example code... Any ideas?

I think you're way overthinking this. All tests need to be marked with #[cfg(test)]. This was the case at some point in the past and things worked fine. But some recent commits have added tests without #[cfg(test)].
The one other change I would recommend is to put extendr-engine into dev-dependencies so downstream crates don't have to depend on it if they don't care for it.

I think you're way overthinking this. All tests need to be marked with #[cfg(test)]. This was the case at some point in the past and things worked fine. But some recent commits have added tests without #[cfg(test)].
The one other change I would recommend is to put extendr-engine into dev-dependencies so downstream crates don't have to depend on it if they don't care for it.

And, all tests should live in tests modules: https://doc.rust-lang.org/book/ch11-03-test-organization.html#the-tests-module-and-cfgtest
I believe we don't systematically do this currently.

And, all tests should live in tests modules: https://doc.rust-lang.org/book/ch11-03-test-organization.html#the-tests-module-and-cfgtest
I believe we don't systematically do this currently.

Thanks, using dev-dependencies works. For test structure, I have no idea what it should be, at the moment.

Thanks, using dev-dependencies works. For test structure, I have no idea what it should be, at the moment.

All tests should be set up like the ones here:
https://github.com/extendr/extendr/blob/daee5c88842b0ec226c32ae9472244b6c6a8a63e/extendr-api/src/lib.rs#L345

All tests should be set up like the ones here:
https://github.com/extendr/extendr/blob/daee5c88842b0ec226c32ae9472244b6c6a8a63e/extendr-api/src/lib.rs#L345

Oh, I didn't remember with #[cfg(test)], thanks! But it triggers another error, which probably should be fixed.
---- src/functions.rs - functions::base_namespace (line 162) stdout ----
error[E0423]: expected function, found macro `test`
 --> src/functions.rs:164:1
  |
5 | / test! {
6 | |    assert_eq!(base_namespace().parent().ok_or("no parent")?, global_env());
7 | | }
  | |_^ not a function
  |
  = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `!` to invoke the macro
  |
28|         test!(|| {
  |             ^

Oh, I didn't remember with #[cfg(test)], thanks! But it triggers another error, which probably should be fixed.
---- src/functions.rs - functions::base_namespace (line 162) stdout ----
error[E0423]: expected function, found macro `test`
 --> src/functions.rs:164:1
  |
5 | / test! {
6 | |    assert_eq!(base_namespace().parent().ok_or("no parent")?, global_env());
7 | | }
  | |_^ not a function
  |
  = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `!` to invoke the macro
  |
28|         test!(|| {
  |             ^

Yes, I think this is the issue: The introduction of the test! macro and associated test() function added testing code to all api builds. If we set things up so test!() can only be compiled inside of test code we have also added an additional check against testing code outside of test modules.

Yes, I think this is the issue: The introduction of the test! macro and associated test() function added testing code to all api builds. If we set things up so test!() can only be compiled inside of test code we have also added an additional check against testing code outside of test modules.

Hm, there are various failures though. Maybe a function and a macro shouldn't have the same name?

Hm, there are various failures though. Maybe a function and a macro shouldn't have the same name?

Maybe @andy-thomason should take a look, since he added the test! macro.
The latest failure is in a documentation example. Not sure if that matters.

Maybe @andy-thomason should take a look, since he added the test! macro.
The latest failure is in a documentation example. Not sure if that matters.

I think the answer is that the test() function needs to live in extendr-engine, not in extendr-api.

I think the answer is that the test() function needs to live in extendr-engine, not in extendr-api.

Maybe a function and a macro shouldn't have the same name?

(I think you already found the answer, but let me note here.) Since function test is compiled conditionally, it's unavailable when not in a testing context; we cannot use test-only functions in a macro, which is unconditionally compiled.

I think the answer is that the test() function needs to live in extendr-engine, not in extendr-api.

Sounds good, but, from a user's perspective, might it be convenient to let test() live in extendr-api? I can't decide which one is better as an API.

Maybe a function and a macro shouldn't have the same name?

(I think you already found the answer, but let me note here.) Since function test is compiled conditionally, it's unavailable when not in a testing context; we cannot use test-only functions in a macro, which is unconditionally compiled.

I think the answer is that the test() function needs to live in extendr-engine, not in extendr-api.

Sounds good, but, from a user's perspective, might it be convenient to let test() live in extendr-api? I can't decide which one is better as an API.

I think test! can remain in extendr-api, since it's a macro and only needs to compile when it's used. test() needs to be in extendr-engine since it requires the engine to be present. The macro can explicitly call extendr-engine::test().
If a user needs to call the test() function directly, rather than use it via the test! macro, they'll have to also use extendr-engine::test(). But I don't think test() is meant to be used directly. It is meant to be accessed via the macro.

I think test! can remain in extendr-api, since it's a macro and only needs to compile when it's used. test() needs to be in extendr-engine since it requires the engine to be present. The macro can explicitly call extendr-engine::test().
If a user needs to call the test() function directly, rather than use it via the test! macro, they'll have to also use extendr-engine::test(). But I don't think test() is meant to be used directly. It is meant to be accessed via the macro.

Makes sense, thanks.

Makes sense, thanks.

It seems this needs some more thoughts.

test() returns Result<()>, which is defined in extendr-api
As the document actually uses test!, it's always compiled (and currently fails). This needs to be moved to optional dependency again, instead of dev-dependency?

It seems this needs some more thoughts.

test() returns Result<()>, which is defined in extendr-api
As the document actually uses test!, it's always compiled (and currently fails). This needs to be moved to optional dependency again, instead of dev-dependency?

After looking at the commit that introduced test! macro (https://github.com/extendr/extendr/pull/107/commits/22f6388a4afb08aae5f844f27c01d90d1dc7500b), I'm now inclined to move extendr-engine back to optional dependency because, while exendr_engine::test() isn't meant to be used directly by users, exendr_engine::start_r() is always needed when used solely by Rust, and I guess testing and documentation are the case. For testing, we can use [dev-dependencies], but there's no convenient way to use "documentation-only dependency," if I understand correctly.

After looking at the commit that introduced test! macro (https://github.com/extendr/extendr/pull/107/commits/22f6388a4afb08aae5f844f27c01d90d1dc7500b), I'm now inclined to move extendr-engine back to optional dependency because, while exendr_engine::test() isn't meant to be used directly by users, exendr_engine::start_r() is always needed when used solely by Rust, and I guess testing and documentation are the case. For testing, we can use [dev-dependencies], but there's no convenient way to use "documentation-only dependency," if I understand correctly.

I'll convert all the tests to test! next. I also want to introduce a
prelude module and phase out the global pub uses in lib.rs
On Sun, 24 Jan 2021, 11:57 Hiroaki Yutani<EMAIL_ADDRESS>wrote:

After looking at the commit that introduced test! macro (22f6388
https://github.com/extendr/extendr/commit/22f6388a4afb08aae5f844f27c01d90d1dc7500b),
I'm now inclined to move extendr-engine back to optional dependency
because, while exendr_engine::test() isn't meant to be used directly by
users, exendr_engine::start_r() is always needed when used solely by
Rust, and I guess testing and documentation are the case. For testing, we
can use [dev-dependencies], but there's no convenient way to use
"documentation-only dependency," if I understand correctly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/extendr/extendr/pull/146#issuecomment-766335876, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAL36XBTUZZPR4WCH47QQZLS3QDLBANCNFSM4WQD5SGQ
.

I'll convert all the tests to test! next. I also want to introduce a
prelude module and phase out the global pub uses in lib.rs
On Sun, 24 Jan 2021, 11:57 Hiroaki Yutani<EMAIL_ADDRESS>wrote:

After looking at the commit that introduced test! macro (22f6388
https://github.com/extendr/extendr/commit/22f6388a4afb08aae5f844f27c01d90d1dc7500b),
I'm now inclined to move extendr-engine back to optional dependency
because, while exendr_engine::test() isn't meant to be used directly by
users, exendr_engine::start_r() is always needed when used solely by
Rust, and I guess testing and documentation are the case. For testing, we
can use [dev-dependencies], but there's no convenient way to use
"documentation-only dependency," if I understand correctly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/extendr/extendr/pull/146#issuecomment-766335876, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAL36XBTUZZPR4WCH47QQZLS3QDLBANCNFSM4WQD5SGQ
.

Thanks. So, maybe I should wait for it? I think I don't understand what things should be placed enough to complete this pull request. Let's keep discussing on #144

Thanks. So, maybe I should wait for it? I think I don't understand what things should be placed enough to complete this pull request. Let's keep discussing on #144


Add support for SAML configuration parameter wantsResponsesSigned

Provides support for pac4j configuration parameter wantsResponsesSigned

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.fabio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Print stream size in info

It would be nice if the size for each stream would be printed in info output, similar to annie.

Does #130 solve this issue? I just released a new version.

@john-black-3k #130 should solve your problem.
AverageBitrate * time (in seconds), should give you size.

Then we should add the calculated total size to the output.

There should be a separate column for size, which should be in MB.

@corny
We should use the ContentLength field inside a Format struct to determine the real size of a stream. Additionally, what about adding the QualityLabel to the output as well, since it is more descriptive than just "medium", "large", "small" etc?
The relevant lines from info.go are as follows:
	size, _ := strconv.ParseInt(itag.ContentLength, 10, 64)

	table.Append([]string{
		strconv.Itoa(itag.ItagNo),
		fmt.Sprintf("%s %s", itag.Quality, itag.QualityLabel),
		strings.ToLower(strings.TrimPrefix(itag.AudioQuality, "AUDIO_QUALITY_")),
		fmt.Sprintf("%0.2f", float64(size)/(1024*1024)),
		strconv.Itoa(bitrate),
		itag.MimeType,
	})

I adjusted the info output and the usage of quality labels. Please check out the current master. Example:
+------+---------------+---------------+-----------+---------+--------------------------------------------+
| ITAG | VIDEO QUALITY | AUDIO QUALITY | SIZE [MB] | BITRATE |                  MIMETYPE                  |
+------+---------------+---------------+-----------+---------+--------------------------------------------+
|   18 | 360p          | low           |      62.6 |  377450 | video/mp4; codecs="avc1.42001E, mp4a.40.2" |
|   22 | 720p          | medium        |     122.4 |  737483 | video/mp4; codecs="avc1.64001F, mp4a.40.2" |
|  137 | 1080p         |               |     201.9 | 1217823 | video/mp4; codecs="avc1.640028"            |
|  248 | 1080p         |               |     279.0 | 1682769 | video/webm; codecs="vp9"                   |
|  136 | 720p          |               |     101.3 |  610810 | video/mp4; codecs="avc1.4d401f"            |
|  247 | 720p          |               |     137.7 |  830520 | video/webm; codecs="vp9"                   |
|  135 | 480p          |               |      51.0 |  307588 | video/mp4; codecs="avc1.4d401e"            |
|  244 | 480p          |               |      62.8 |  378782 | video/webm; codecs="vp9"                   |
|  134 | 360p          |               |      24.4 |  147436 | video/mp4; codecs="avc1.4d401e"            |
|  243 | 360p          |               |      37.5 |  225939 | video/webm; codecs="vp9"                   |
|  133 | 240p          |               |       8.9 |   53812 | video/mp4; codecs="avc1.4d4015"            |
|  242 | 240p          |               |      18.8 |  113676 | video/webm; codecs="vp9"                   |
|  160 | 144p          |               |       4.7 |   28398 | video/mp4; codecs="avc1.4d400c"            |
|  278 | 144p          |               |      12.1 |   73188 | video/webm; codecs="vp9"                   |
|  140 |               | medium        |      21.1 |  127063 | audio/mp4; codecs="mp4a.40.2"              |
|  249 |               | low           |       8.4 |   50653 | audio/webm; codecs="opus"                  |
|  250 |               | low           |       9.6 |   57776 | audio/webm; codecs="opus"                  |
|  251 |               | medium        |      17.5 |  105629 | audio/webm; codecs="opus"                  |
+------+---------------+---------------+-----------+---------+--------------------------------------------+

Looks good. Thanks!


AAP-29152 Hub Remotes Access Tests User and Team

These tests cannot run on CI yet because that server does not have the new RBAC APIs
Description
This PR is for Hub Remotes Access tests for User and Team ticket
Acceptance Criteria

[x] create a new remote, from the user access tab assign a user and apply role(s) to the user of the remote
[x] create a new remote, from the team access tab assign a user and apply role(s) to the team of the remote

Replaced with https://github.com/ansible/ansible-ui/pull/2970


Update tests

Fixes #109
Some tests required an updated because of the change to decimal for prices.
A couple more corrections ewre required to handle different formatting of numbers in different cultures.
I updated UspsService so it always uses the en-US culture to parse strings. However, I don't think the same assumption can be made for ZipCodeTaxPart in the method where it parses the rates.

Looks good otherwise. Do you want me to wit for you to squash before I merge, or should I merge as is?

As you wish. I can squash it tomorrow when I am on my work pc.

Sounds good. Thanks!


Feature Idea: Schema matching with GraphQL and Proto

Have guardrails take in a GraphQL schema or ProtoBuff schema for format validation

@chitalian just to clarify, do you mean as an input (which then gets converted into a RAIL spec which may be in XML or another format) or do you mean the validation should happen using GraphQL/Proto as part of the compiled prompt?

Closing due to inactivity. Feel free to reopen and elaborate.


How to run ingest.py?

Could you tell me how to run ingest.py, thanks.

Apologies for the late response. As long as you have the necessary packages, you just call python3 ingest.py <YouTube URL>


chore: fixed resolver issue

This PR resolves  a warning seen while running cargo update
warning: some crates are on edition 2021 which defaults to resolver = "2", but virtual workspaces default to resolver = "1"
note: to keep the current resolver, specify workspace.resolver = "1" in the workspace root's manifest
note: to use the edition 2021 resolver, specify workspace.resolver = "2" in the workspace root's manifest

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[x] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] No

Checklist

[x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[x] I have added a convincing reason for adding this feature, if necessary

Oh looks like you didn't sign your commits and I can't merge the PR unless they are signed.
Also could you rebase and target 1.x branch which will be merged later into dev?

Thank you and Ah I screwed up again .. I push the amended and signed version to dev ... one sec I will target 1.1 as you asked.

You need to rebase your branch as well to have 1.x as a base not dev so you don't pull this changes. Might be easier to just close this PR and open a new one.

Closed in favor of https://github.com/tauri-apps/tauri/pull/7747

You need to rebase your branch as well to have 1.x as a base not dev so you don't pull this changes. Might be easier to just close this PR and open a new one.

Agreed here is the new PR https://github.com/tauri-apps/tauri/pull/7747


Drop Support For Python 3.5

Now that SpyDrNet doesn't support Python 3.5, some SpyDrNet-TMR tests fail for Python 3.5. We should probably just drop support for Python 3.5.

I agree that we should drop support for Python 3.5 for SpyDrNet-TMR for the next release.

Python 3.5 is dropped in release 1.2.0


update_spahm-b

There are a few changes I would like to PR:

optional argument to use the same basis (CC.bas)  for all atom-pairs
changes to generate representations for a single element-type in a structure
ecp argument for CLI parser

then I also have various some implementations for a better atom-pair bagging for global spahm-b, but these are not totally worked out yet
Is it ok if I included these changes in the same PR or do you want me to split

i think ecp should be together with other ecp changes

Ecp related changes are now at #48


Android NDK r25 support

NDK 25 and later is supported by tf master after https://github.com/tensorflow/tensorflow/commit/0caae80adf169e0106946b2d92faad362854f220
replacing TF-2.8 with TF master doesn't work. It seems there are some Python issues
I backported related changes from master to TF r2.14 branch and made diff (//patches:ndk_25_r14.diff in the diff)
C++14 --> C++17 because TF 2.14 requires C++17
remove our own code of protobuffer, cpuinfo, and Apple related bazel rules, because TF 2.14 should have newer dependencies
for NDK >= 25, ANDROID_NDK_HOME,  ANDROID_NDK_VERSION , and ANDROID_NDK_API_LEVEL are required.
-- NDK >= 25: e.g., ANDROID_NDK_HOME=..., ANDROID_NDK_VERSION=25, ANDROID_NDK_API_LEVEL=33
-- NDK <= 21: e.g., ANDROID_NDK_HOME=..., ANDROID_NDK_VERSION=21

I was able to build TFLite backend w/o and w/ MediaTek neuron delegate.

ios: why do we need ANDROID SDK and NDK fro iOS as in https://github.com/mlcommons/mobile_app_open/blob/master/flutter/ios/ci_scripts/ci_post_clone.sh#L76-L90

The macOS host can build both iOS and Android app, so I added it in case. I think we can remove it.

@freedomtan I got this error building for Android TFLite backend. Is there any installation / setup step needed except setting the env vars above?
$ make flutter/android
WITH_TFLITE=1
Skip checksum validation
bazel    \
                build --disk_cache=/Users/anh/cache/bazel --symlink_prefix bazel-  \
                --config=android_arm64 \
                //mobile_back_tflite/cpp/backend_tflite:libtflitebackend.so \
                 \
                 \
                 \
                 \
                //flutter/cpp/flutter:libbackendbridge.so
INFO: Invocation ID: 8c898bae-9bed-4b56-a492-33a1db4511d3
INFO: Options provided by the client:
  Inherited 'common' options: --isatty=1 --terminal_columns=199
INFO: Reading rc options for 'build' from /Users/anh/dev/mlcommons/mobile_app_open/.bazelrc:
  Inherited 'common' options: --experimental_repo_remote_exec
INFO: Reading rc options for 'build' from /Users/anh/dev/mlcommons/mobile_app_open/.bazelrc:
  'build' options: -c opt --announce_rc --config=short_logs --verbose_failures --spawn_strategy=standalone
INFO: Found applicable config definition build:short_logs in file /Users/anh/dev/mlcommons/mobile_app_open/.bazelrc: --output_filter=DONT_MATCH_ANYTHING
INFO: Found applicable config definition build:android_arm64 in file /Users/anh/dev/mlcommons/mobile_app_open/.bazelrc: --config=android --cpu=arm64-v8a --fat_apk_cpu=arm64-v8a
INFO: Found applicable config definition build:android in file /Users/anh/dev/mlcommons/mobile_app_open/.bazelrc: --copt=-w --cxxopt=-std=c++17 --host_cxxopt=-std=c++17 --crosstool_top=//external:android/crosstool --host_crosstool_top=@bazel_tools//tools/cpp:toolchain
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/llvm/llvm-project/archive/dc275fd03254d67d29cc70a5a0569acf24d2280d.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/tensorflow/runtime/archive/7d879c8b161085a4374ea481b93a52adb19c0529.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
WARNING: Download from https://mirror.bazel.build/github.com/bazelbuild/rules_cc/archive/081771d4a0e9d7d3aa0eed2ef389fa4700dfb23e.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/google/XNNPACK/archive/b9d4073a6913891ce9cbd8965c8d506075d2a45a.zip failed: class java.io.FileNotFoundException GET returned 404 Not Found
ERROR: /private/var/tmp/_bazel_anh/30b0ae0ebfc82d789f6eeabcb52f979d/external/local_config_cc/BUILD:44:19: in cc_toolchain_suite rule @local_config_cc//:toolchain: cc_toolchain_suite '@local_config_cc//:toolchain' does not contain a toolchain for cpu 'arm64-v8a'
ERROR: /private/var/tmp/_bazel_anh/30b0ae0ebfc82d789f6eeabcb52f979d/external/local_config_cc/BUILD:44:19: Analysis of target '@local_config_cc//:toolchain' failed
ERROR: Analysis of target '//flutter/cpp/flutter:libbackendbridge.so' failed; build aborted:
INFO: Elapsed time: 3.718s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (247 packages loaded, 5944 targets configured)
make: *** [flutter/android/libs/build] Error 1

it seems you didn't set ANDROID_NDK_API_LEVEL.

@freedomtan I got this error building for Android TFLite backend. Is there any installation / setup step needed except setting the env vars above and download the correct NDK version?
$ make flutter/android
WITH_TFLITE=1
Skip checksum validation
bazel    \
                build --disk_cache=/Users/anh/cache/bazel --symlink_prefix bazel-  \
                --config=android_arm64 \
                //mobile_back_tflite/cpp/backend_tflite:libtflitebackend.so \
                 \
                 \
                 \
                 \
                //flutter/cpp/flutter:libbackendbridge.so
INFO: Invocation ID: 8c898bae-9bed-4b56-a492-33a1db4511d3
INFO: Options provided by the client:
  Inherited 'common' options: --isatty=1 --terminal_columns=199
INFO: Reading rc options for 'build' from /Users/anh/dev/mlcommons/mobile_app_open/.bazelrc:
  Inherited 'common' options: --experimental_repo_remote_exec
INFO: Reading rc options for 'build' from /Users/anh/dev/mlcommons/mobile_app_open/.bazelrc:
  'build' options: -c opt --announce_rc --config=short_logs --verbose_failures --spawn_strategy=standalone
INFO: Found applicable config definition build:short_logs in file /Users/anh/dev/mlcommons/mobile_app_open/.bazelrc: --output_filter=DONT_MATCH_ANYTHING
INFO: Found applicable config definition build:android_arm64 in file /Users/anh/dev/mlcommons/mobile_app_open/.bazelrc: --config=android --cpu=arm64-v8a --fat_apk_cpu=arm64-v8a
INFO: Found applicable config definition build:android in file /Users/anh/dev/mlcommons/mobile_app_open/.bazelrc: --copt=-w --cxxopt=-std=c++17 --host_cxxopt=-std=c++17 --crosstool_top=//external:android/crosstool --host_crosstool_top=@bazel_tools//tools/cpp:toolchain
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/llvm/llvm-project/archive/dc275fd03254d67d29cc70a5a0569acf24d2280d.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/tensorflow/runtime/archive/7d879c8b161085a4374ea481b93a52adb19c0529.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
WARNING: Download from https://mirror.bazel.build/github.com/bazelbuild/rules_cc/archive/081771d4a0e9d7d3aa0eed2ef389fa4700dfb23e.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/google/XNNPACK/archive/b9d4073a6913891ce9cbd8965c8d506075d2a45a.zip failed: class java.io.FileNotFoundException GET returned 404 Not Found
ERROR: /private/var/tmp/_bazel_anh/30b0ae0ebfc82d789f6eeabcb52f979d/external/local_config_cc/BUILD:44:19: in cc_toolchain_suite rule @local_config_cc//:toolchain: cc_toolchain_suite '@local_config_cc//:toolchain' does not contain a toolchain for cpu 'arm64-v8a'
ERROR: /private/var/tmp/_bazel_anh/30b0ae0ebfc82d789f6eeabcb52f979d/external/local_config_cc/BUILD:44:19: Analysis of target '@local_config_cc//:toolchain' failed
ERROR: Analysis of target '//flutter/cpp/flutter:libbackendbridge.so' failed; build aborted:
INFO: Elapsed time: 3.718s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (247 packages loaded, 5944 targets configured)
make: *** [flutter/android/libs/build] Error 1

I updated the docs and Docker container in this PR https://github.com/mlcommons/mobile_app_open/pull/788
Building the backend for TFLite, MediaTek, Pixel works, but not for Samsung and QTI, therefore the App Build / build-android-apk still fails.

I updated the docs and Docker container in this PR #788
Building the backend for TFLite, MediaTek, Pixel works, but not for Samsung and QTI, therefore the App Build / build-android-apk still fails.

It seems we have some hard-coded library places, which do work because of changes of the NDK directory structure, in QTI backend.
I guess if we change NDK back to r21, it will work. @mohitmundhragithub please help make NDK r25c work.

Build for Windows still failed.

@AhmedTElthakeb please help check if we build samsung backend with NDK 25c

can we merge #799 before this?

can we merge #799 before this?

I am fine with that.

can we merge #799 before this?

I am fine with that.

Created #803 which has qti backend related changes, and also the changes in flutter required for fetching the libc++_shared.so from the ndk directly.

@anhappdev I fixed the Windows build.

The app now can be built successfully with all backends.
Only the Code Analysis failed at the last scan step, but it's an issue of the code scanner. I will try to fix that later.

@AhmedTElthakeb and @mjkim010 you can get apk from https://github.com/mlcommons/mobile_app_open/actions/runs/6620173841?pr=787

on Samsung backend, link to the libc++_shared.so need to be updated, #812.
@freedomtan to check if adding the libc++_shared.so is necessary.

@AhmedTElthakeb and @anhappdev: it seems to me linking libc++_share.so is fine. Accutally, it should be required to specify which c++ library we want to use when building stuff with NDK for Android (because there is no stable C++ API). I cannot figure out why linking libc++_shared.so was not required for Samsung before (maybe some Samsung binaries / libraries did something like static link?)


Deduplicate fontdb types

resvg optionally depends on fontdb. Meanwhile,

usvg::FontStyle is identical to fontdb::Style
usvg::FontStretch is identical to fontdb::Stretch

Worse, there isn't even a conversion method between the two. This is a pain when implementing a usvg::FontResolver.

Erm... what exactly is your solution?
Also, there are like 2 people who would need to implement usvg::FontResolver themselves. It's a super niche case.

The simplest I can think of is to make this feature dependent:

when usvg uses fontdb, those types are just re-exports of the fontdb types
otherwise, they are distinct types

This will only complicate things.

No, it will simplify things for anyone downstream happening to need to use both types.
An alternative would be to implement From conversions. Probably more robust (to unforeseen changes in fontdb definitions of the types), but slightly more complicated.

From is fine.


How to use multigpu？

I change the config file like this ，"devices": [0,1,2,3]  and  add code
USE_CUDA = torch.cuda.is_available()
device = torch.device("cuda:0" if USE_CUDA else "cpu")
but I got the error：
Traceback (most recent call last):
File "/data1/qianxiong/Actionformer/train.py", line 186, in
main(args)
File "/data1/qianxiong/Actionformer/train.py", line 128, in main
train_one_epoch(
File "/data1/qianxiong/Actionformer/libs/utils/train_utils.py", line 277, in train_one_epoch
losses = model(video_list)
File "/data1/qianxiong/anaconda3/envs/Actionformer/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
return forward_call(*input, **kwargs)
File "/data1/qianxiong/anaconda3/envs/Actionformer/lib/python3.8/site-packages/torch/nn/parallel/data_parallel.py", line 168, in forward
outputs = self.parallel_apply(replicas, inputs, kwargs)
File "/data1/qianxiong/anaconda3/envs/Actionformer/lib/python3.8/site-packages/torch/nn/parallel/data_parallel.py", line 178, in parallel_apply
return parallel_apply(replicas, inputs, kwargs, self.device_ids[:len(replicas)])
File "/data1/qianxiong/anaconda3/envs/Actionformer/lib/python3.8/site-packages/torch/nn/parallel/parallel_apply.py", line 86, in parallel_apply
output.reraise()
File "/data1/qianxiong/anaconda3/envs/Actionformer/lib/python3.8/site-packages/torch/_utils.py", line 457, in reraise
raise exception
IndexError: Caught IndexError in replica 0 on device 0.
Original Traceback (most recent call last):
File "/data1/qianxiong/anaconda3/envs/Actionformer/lib/python3.8/site-packages/torch/nn/parallel/parallel_apply.py", line 61, in _worker
output = module(*input, **kwargs)
File "/data1/qianxiong/anaconda3/envs/Actionformer/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
return forward_call(*input, **kwargs)
File "/data1/qianxiong/Actionformer/libs/modeling/meta_archs.py", line 334, in forward
batched_inputs, batched_masks = self.preprocessing(video_list)
File "/data1/qianxiong/anaconda3/envs/Actionformer/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
return func(*args, **kwargs)
File "/data1/qianxiong/Actionformer/libs/modeling/meta_archs.py", line 423, in preprocessing
batched_inputs = batched_inputs.to(self.device)
File "/data1/qianxiong/Actionformer/libs/modeling/meta_archs.py", line 330, in device
return list(set(p.device for p in self.parameters()))[0]
IndexError: list index out of range
Process finished with exit code 1
Please tell me how to use multigpu to train your code？

Hi, our code currently does not support multi-GPU training.
Using a larger batch (along with multi-gpu training) may decrease the performance here.

By the way, if you really want to try on multi-gpu training, you may need to try use DistributedDataparallel model along with some distributed launch tweaks.

OK ， I  get it


[BUG] Error in tutorial notebook 02_Catalog_Queries_with_TAP

Describe the bug
A clear and concise description of what the bug is.
Queries take much longer than the tutorial notebook suggests.
To Reproduce
Steps to reproduce the behavior:

Go to the tutorial notebooks on the RSP instance on the IDF under /notebooks
Click on 02_Catalog_Queries_with_TAP
Scroll down to section 3.2. Cone search specifying the maximum number of records
See error

Expected behavior
Small error in the notebook, in every cell that says the queries should take 2-10s they actually usually take close to 4mins.
Screenshots

URL
https://data.lsst.cloud/nb/user/kabelo-t/lab/tree/notebooks/tutorial-notebooks/02_Catalog_Queries_with_TAP.ipynb
Desktop (please complete the following information):

OS: [MacOS 12.5]
Browser [Safari]

My apologies @Kabelo-T, this issue completely escaped my notice.
For staff, it is being addressed with jira.lsstcorp.org/browse/PREOPS-1363.

OK, I did some tests, and the cells that can take just a few seconds do sometimes take more time, but always <2 minutes. Changed all text to say "This query usually takes <2 minutes" to avoid future confusion. But there's nothing wrong with the queries or anything.
Changes have been pushed to main and so will appear to users in the next release to prod, by Patch Thu Sep 15 if not before.
Closing issue.


create-react-app 2.0.0 support

Hi,
What's the plan/roadmap on 2.0.0 support?
I seem to have it working to a large extent with cra-universal, but am missing some clues with regard to css modules support which was added to 2.0, and also getting blanks for svg's (img src [Object object]).
Thanks
Ref: https://github.com/facebook/create-react-app/issues/3815

hi,
for svg import, it's on https://github.com/antonybudianto/cra-universal/wiki/Known-issues

may I know the css module issue?

the library itself should provide SSR support, just like React helmet, react router, loadable component, etc.

also correct synchronization between the 'randomized' class names  is one similar issue with svg import 😢

@patroza Have you tried modules.css loader? Any reproducible will be helpful here

? this library only support cra v1.x ?

I've not used 2.0.0 since it's not released yet, please open new issue for any incompatibilities :)


New version: CurricularAnalytics v1.1.0

Registering package: CurricularAnalytics
Repository: https://github.com/CurricularAnalytics/CurricularAnalytics.jl
Created by: @haydenfree
Version: v1.1.0
Commit: 202324b08787d982267f8fd478ada6002f916f85
Reviewed by: @haydenfree
Reference: https://github.com/CurricularAnalytics/CurricularAnalytics.jl/commit/202324b08787d982267f8fd478ada6002f916f85#commitcomment-41830280

Don't merge - going to create a new PR


Joint Discovery merge with main script

In case we dont have > 30 exomes, we could simply set up the VQSR recalibration step to take 30 exome samples from 1000G and use these as calibration samples. For bigger clusters, we could even store these without having to process them every time we analyse a single exome sample.
What do you think @marchoeppner ?

That would allow us to merge the jointdiscovery workflow again within a single script, making the entire process less annoying ...

I would support this; we currently use in-house calbration exomes for this - we would need to make sure that we don't introduce any biases if different sequencing platforms (patterned vs non-patterned flow cells) are used (?)


Reduce file size by not recording some types of packets

For example being able to disable items, particles, etc is useful to reduce filesize when recording packet-monsters like world-eaters
could be done for each type in the configs.
Similar: https://github.com/Robitobi01/SARC

we are already yeeting the light update packets to greatly reduce the file size in those specific case, to support other packet removal we would loose some functionality compared to official replayMod. if you want to remove specific packets i suggest you t make a fork of this mod and add your filter to ReplayRecorder::onPacket before the call to save(packet)


rollout support application full-link greyscale

What is full-link greyscale?
The community microservice governance solution MSE, Istio is able to support the full link grey scale capability of the business, as follows:

A new full-link greyscale solution
There are some differences between the full-link greyscale model and the regular Rollout model, the most significant of which is that the traffic greyscale should be triggered even if only application C is published. Due to these characteristics, the traffic grayscale should not be tied to a specific application, but should be shared by all applications.
The shared TrafficRouting yaml
You can start by defining a TrafficRouting resource that describes the rules for full-link greyscale, as follows to import traffic from the Android client into the greyscale environment.
apiVersion: rollouts.kruise.io/v1alpha1
kind: TrafficRouting
metadata:
  name: mse-traffic
spec:
  objectRef:
  - service: spring-cloud-a
    ingress:
      name: spring-cloud-a
      classType: mse
  strategy:
    matches:
    - headers:
      - type: RegularExpression
        name: x-user-agent
        value: 'andriod'

The application's rollouts yaml
For each Application (a, b, c), you can define the corresponding Rollout configuration, and you can add annotations[rollouts.kruise.io/trafficrouting] to statement the associated TrafficRouting.
---
apiVersion: rollouts.kruise.io/v1alpha1
kind: Rollout
metadata:
  name: rollout-a
  annotations:
    rollouts.kruise.io/trafficrouting: mse-traffic
spec:
  objectRef:
    workloadRef:
      apiVersion: apps/v1
      kind: Deployment
      name: spring-cloud-a
  strategy:
    canary:
      steps:
      - pause: {}
        replicas: 1
---
apiVersion: rollouts.kruise.io/v1alpha1
kind: Rollout
metadata:
  name: rollout-c
  annotations:
    rollouts.kruise.io/trafficrouting: mse-traffic
spec:
  objectRef:
    workloadRef:
      apiVersion: apps/v1
      kind: Deployment
      name: spring-cloud-c
  strategy:
    canary:
      steps:
      - pause: {}
        replicas: 1
---
apiVersion: rollouts.kruise.io/v1alpha1
kind: Rollout
metadata:
  name: rollout-b
  annotations:
    rollouts.kruise.io/trafficrouting: mse-traffic
spec:
  objectRef:
    workloadRef:
      apiVersion: apps/v1
      kind: Deployment
      name: spring-cloud-b
  strategy:
    canary:
      steps:
      - pause: {}
        replicas: 1

Codecov Report

Merging #153 (ab8de26) into master (3578b39) will decrease coverage by 0.23%.
The diff coverage is 44.85%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   44.67%   44.45%   -0.23%
==========================================
  Files          48       49       +1
  Lines        5077     5172      +95
==========================================
+ Hits         2268     2299      +31
- Misses       2432     2496      +64
  Partials      377      377

Flag
Coverage Δ

unittests
44.45% <44.85%> (-0.23%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...chrelease/control/canarystyle/deployment/canary.go
61.33% <ø> (ø)

...hrelease/control/canarystyle/deployment/control.go
74.35% <ø> (ø)

pkg/controller/rollout/rollout_status.go
19.23% <0.00%> (-0.15%)
:arrow_down:

pkg/util/constant.go
0.00% <0.00%> (ø)

pkg/util/controller_finder.go
0.00% <0.00%> (ø)

pkg/util/workloads_utils.go
22.75% <ø> (ø)

...ollout/validating/rollout_create_update_handler.go
63.56% <0.00%> (-0.50%)
:arrow_down:

pkg/trafficrouting/network/gateway/gateway.go
52.80% <7.69%> (-0.48%)
:arrow_down:

pkg/util/parse_utils.go
36.56% <29.41%> (-0.49%)
:arrow_down:

pkg/controller/rollout/rollout_progressing.go
46.18% <33.89%> (-4.78%)
:arrow_down:

... and 4 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

/approve


Separate Refused Status from Cancelled

…ommodate the new status
#370 #373 #374 #375
Added Refused status as a separate one from Cancelled
Changelog:

Added new fixture
Updated model
Updated serializer
Added test
Updated logic for text representation
Updated Breadcrumbs

 Credit Transfer | Respondent can Refuse a Credit Transfer Proposal |2|

 Confirmation Alerts | Refuse a Credit Transfer Proposal |1|

 Bug | extra return in code |1|

 Credit Transfer | Add 'Refused' status |3|


New package: GLNS v0.1.0

Registering package: GLNS
Repository: https://github.com/stephenlsmith/GLNS
Created by: @stephenlsmith
Version: v0.1.0
Commit: 0baa697a3dd45d27c6b9868bfee5c23998760705
Git reference: master
Release notes:

A solver for the generalized traveling salesman problem (GTSP).
Stephen L. Smith
<EMAIL_ADDRESS>

Your new package pull request does not meet all of the guidelines for automatic merging.
Specifically, your pull request does not meet the following guidelines:

Name does not meet all of the following: starts with a capital letter, ASCII alphanumerics only, ends in lowercase
Name is not at least five characters long
Repo URL does not end with /name.jl.git, where name is the package name

It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.

These guidelines are intended not as requirements for packages but as very conservative guidelines, which, if your new package or new version of a package meets them, it may be automatically merged.

On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.
Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)
If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.

[noblock]

I have updated the url to add .jl to the name and updated the version number to v1.0.0.
I would like to keep the name as GLNS since this matches the paper that presented the algorithm:
Smith, S. L., & Imeson, F. (2017). GLNS: An effective large neighborhood search heuristic for the generalized traveling salesman problem. Computers & Operations Research, 87, 1-19.

Can you retrigger the bot in order to reflect those changes?

I intended to do that, but instead submitted a new package request (#4609).  That request has now been merged into master and this pull request can be deleted.


Flutter 3.19.0, versions problem

Environment
Flutter (Channel stable, 3.19.0, on macOS 14.3.1 23D60 darwin-arm64, locale pl-PL)
sentry_dart_plugin: ^1.7.0
integration_test:
sdk: flutter
Steps to Reproduce
Try to install sentry dart plugin with integration_test flutter package on the latest flutter version 3.19.0
Expected Result
That should work
Actual Result
Because no versions of sentry_dart_plugin match >1.7.0 <2.0.0 and sentry_dart_plugin 1.7.0 depends on process ^4.2.4, sentry_dart_plugin ^1.7.0 requires process ^4.2.4.
And because no versions of process match >4.2.4 <5.0.0, sentry_dart_plugin ^1.7.0 requires process 4.2.4.
And because process 4.2.4 depends on file ^6.0.0 and every version of integration_test from sdk depends on file 7.0.0, sentry_dart_plugin ^1.7.0 is incompatible with integration_test from sdk.
So, because XXX depends on both integration_test from sdk and sentry_dart_plugin ^1.7.0, version solving failed.

hey thanks for the issue.
while we ship a fix you can work around this with overriding the dependency for now
dependency_overrides:
  process: ^5.0.0

this is now part of 1.7.1


Huge pile of compilation errors from the latest version on git

I get a giant pile of errors when trying to build from source from the latest git. I get the following:
g++ -std=c++11 -ggdb -Iinclude -Istfl -Ifilter -I. -Irss -Werror -Wall -Wextra -Wunreachable-code -DLOCALEDIR=\"/usr/local/share/locale\" -DGIT_HASH=\"f8db\" -I/usr/include/libxml2 -I/usr/include/json-c -D_GNU_SOURCE -D_DEFAULT_SOURCE -DHAVE_OPENSSL=1 -o filter/Scanner.o -c filter/Scanner.cpp
filter/Scanner.cpp: In member function ‘Token* Scanner::NextToken()’:
filter/Scanner.cpp:587:12: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'-' && ch <= L'.') || (ch >= L'A' && ch <= L'Z') || ch == L'_' || (ch >= L'a' && ch <= L'z')) {AddCh(); goto case_3;}
         ~~~^~~~~~~
filter/Scanner.cpp:587:26: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'-' && ch <= L'.') || (ch >= L'A' && ch <= L'Z') || ch == L'_' || (ch >= L'a' && ch <= L'z')) {AddCh(); goto case_3;}
                       ~~~^~~~~~~
filter/Scanner.cpp:587:42: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'-' && ch <= L'.') || (ch >= L'A' && ch <= L'Z') || ch == L'_' || (ch >= L'a' && ch <= L'z')) {AddCh(); goto case_3;}
                                       ~~~^~~~~~~
filter/Scanner.cpp:587:56: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'-' && ch <= L'.') || (ch >= L'A' && ch <= L'Z') || ch == L'_' || (ch >= L'a' && ch <= L'z')) {AddCh(); goto case_3;}
                                                     ~~~^~~~~~~
filter/Scanner.cpp:587:86: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'-' && ch <= L'.') || (ch >= L'A' && ch <= L'Z') || ch == L'_' || (ch >= L'a' && ch <= L'z')) {AddCh(); goto case_3;}
                                                                                ~~~^~~~~~~
filter/Scanner.cpp:587:100: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'-' && ch <= L'.') || (ch >= L'A' && ch <= L'Z') || ch == L'_' || (ch >= L'a' && ch <= L'z')) {AddCh(); goto case_3;}
                                                                                ~~~^~~~~~~
filter/Scanner.cpp:591:11: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if (ch <= L'!' || (ch >= L'#' && ch <= 65535)) {AddCh(); goto case_4;}
        ~~~^~~~~~~
filter/Scanner.cpp:591:26: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if (ch <= L'!' || (ch >= L'#' && ch <= 65535)) {AddCh(); goto case_4;}
                       ~~~^~~~~~~
filter/Scanner.cpp:600:12: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'0' && ch <= L'9')) {AddCh(); goto case_6;}
         ~~~^~~~~~~
filter/Scanner.cpp:600:26: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'0' && ch <= L'9')) {AddCh(); goto case_6;}
                       ~~~^~~~~~~
filter/Scanner.cpp:604:12: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'0' && ch <= L'9')) {AddCh(); goto case_8;}
         ~~~^~~~~~~
filter/Scanner.cpp:604:26: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'0' && ch <= L'9')) {AddCh(); goto case_8;}
                       ~~~^~~~~~~
filter/Scanner.cpp:609:12: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'0' && ch <= L'9')) {AddCh(); goto case_8;}
         ~~~^~~~~~~
filter/Scanner.cpp:609:26: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'0' && ch <= L'9')) {AddCh(); goto case_8;}
                       ~~~^~~~~~~
filter/Scanner.cpp:614:12: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'0' && ch <= L'9')) {AddCh(); goto case_9;}
         ~~~^~~~~~~
filter/Scanner.cpp:614:26: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'0' && ch <= L'9')) {AddCh(); goto case_9;}
                       ~~~^~~~~~~
filter/Scanner.cpp:619:12: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'-' && ch <= L'.') || (ch >= L'A' && ch <= L'Z') || ch == L'_' || (ch >= L'a' && ch <= L'z')) {AddCh(); goto case_3;}
         ~~~^~~~~~~
filter/Scanner.cpp:619:26: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'-' && ch <= L'.') || (ch >= L'A' && ch <= L'Z') || ch == L'_' || (ch >= L'a' && ch <= L'z')) {AddCh(); goto case_3;}
                       ~~~^~~~~~~
filter/Scanner.cpp:619:42: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'-' && ch <= L'.') || (ch >= L'A' && ch <= L'Z') || ch == L'_' || (ch >= L'a' && ch <= L'z')) {AddCh(); goto case_3;}
                                       ~~~^~~~~~~
filter/Scanner.cpp:619:56: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'-' && ch <= L'.') || (ch >= L'A' && ch <= L'Z') || ch == L'_' || (ch >= L'a' && ch <= L'z')) {AddCh(); goto case_3;}
                                                     ~~~^~~~~~~
filter/Scanner.cpp:619:86: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'-' && ch <= L'.') || (ch >= L'A' && ch <= L'Z') || ch == L'_' || (ch >= L'a' && ch <= L'z')) {AddCh(); goto case_3;}
                                                                                ~~~^~~~~~~
filter/Scanner.cpp:619:100: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    if ((ch >= L'-' && ch <= L'.') || (ch >= L'A' && ch <= L'Z') || ch == L'_' || (ch >= L'a' && ch <= L'z')) {AddCh(); goto case_3;}
                                                                                ~~~^~~~~~~
filter/Scanner.cpp:620:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    else if ((ch >= L'0' && ch <= L'9')) {AddCh(); goto case_6;}
              ~~~^~~~~~~
filter/Scanner.cpp:620:31: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
    else if ((ch >= L'0' && ch <= L'9')) {AddCh(); goto case_6;}
                            ~~~^~~~~~~
cc1plus: all warnings being treated as errors
make: *** [Makefile:112: filter/Scanner.o] Error 1

Steps to reproduce the issue:

Clone the latest from git
Run make.
Observe the errors.

I have g++ 6.3.1 20170306 (according to g++ --version).

Wonder why Travis didn't catch this—does 6.2.0 20160901 that's used there differ that much from 6.3.1?
You can try doing export CXXFLAGS=-Wno-sign-compare before compiling, but that probably won't help because it'll be overridden by -Wall.
I don't really want to modify this Scanner stuff because it's autogenerated, so this will probably be fixed only as part of #299.

Strange, did a 'clean' build on a Ubuntu 17.04 docker container with only build dependencies (debhelper, devscripts, build-essential + whats in the "control" file) and it worked fine as well :/
That used g++ 6.3.0 20170406

Compiler versions don't seem right. g++ 6.3.1 has date 20170306 but 6.3.0 has 20170406?

g++ (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406
Ubuntu/Debian manages their system packages separate (mostly to provide security patches to older versions)

I thought "6.3.0 20170406" is upstream version and Debian/Ubuntu only change package version ("6.3.0-12ubuntu2" in your case). If it's so, then the date on 6.3.0 should be earlier than the date on 6.3.1. Or is it a build date?

I guess it's the build date. '6.3.0' should be the upstream version. But yes.. it's confusing :confused:


native bindings

The current native bindings implementation does not allow to pass parameters to the inflect methods because of the inner workings of prototype.__defineGetter__. Thus calling "example_string".camelize(false) results in an error.
I could provide a fix (pull request) for this that changes the getter calls to real method calls but unfortunately that would break backwards compatibility.
So instead of calling "example_string".camelize one would have to use real method calls "example_string".camelize() even if no parameters are given.
Is this okay for you?

I would recommend using inflect.camelize('message_properties', false) form if anyone ever needs to pass that parameter.


(BOLT-1445) Update log level docs

This commit updates the log level documentation in the writing plan docs to include updated information about how to log messages from plan execution. It also adds a section to the common debugging page with some prescriptive recommendations for handling plan logging.

CLA signed by all contributors.

@lucy we should probably update https://github.com/puppetlabs/bolt/blob/c049c3609ac2d3af88b9f772cdfac93d4950485d/bolt-modules/out/lib/puppet/functions/out/message.rb#L5 and rebuild the plan function docs

@donoghuc Great point I completely spaced that! Updated

CLA signed by all contributors.


launchArgs does not effect Android Emulator

What happened?
In my .detoxrc.json I added under apps > android.release > launchArgs: { "dns-server":""} but it doesn't affect my emulator, I also tried it via the cli: detox test -c android --app-launch-args="-dns-server "<example-dns"" but both attempts didn't work. Only when I launch the emulator in another terminal before the test with "emulator -avd "EMULATOR_NAME" -dns-server "", then it works. But my problem is that I want to run this on a Ci and not start the emulator manually in another terminal before testing.
What was the expected behaviour?
That the launch args affects the emulator start
Was it tested on latest Detox?

[X] I have tested this issue on the latest Detox release and it still reproduces.

Did your test throw out a timeout?

[ ] I have followed the instructions under Identifying which synchronization mechanism causes us to wait too much.

Help us reproduce this issue!
No response
In what environment did this happen?
Detox version: 19.4.5
React Native version: 0.66.4
Node version: 17.7.2
Device model: Emulator Pixel 4 APi 30
Android version: 11
Test-runner (select one): jest-circus
Detox logs
Detox logs
paste logs here!

Device logs
Device logs
paste logs here!

More data, please!
No response

I think you might have had launchArgs/--app-launch-args mixed up with --device-launch-args: https://wix.github.io/Detox/docs/api/detox-cli/#test


image alignment not working as expected

How can this bug be reproduced?

Create a post.  Insert an image, with a caption, and align center

What did you expect to happen?
I expected the figure and image to be centered and the caption to be the same width of the image, which is what happens in the preview.

What happened instead?
Image is left-aligned with caption spanning the whole line.

Please List the Following:

OS & version: CentOS 7.3.1611
Node version (node -v) [Node v4+ is required] : v6.9.4
FoundationPress version (see line 3 in package.json): v2.10.4
Foundation version (found in node_modules/foundation-sites/package.json) : 6.4.3

Sorry, I'm not sure how to do this properly within a codepen or jsfiddle, since it depends a lot on the combination of wordpress and foundationpress.

This is sort of interesting. This looks like it has to do with the filter "img_caption_shortcode" in cleanup.php . On line 25 if you comment out this line your images will probably work as expected.
@colin-marshall @olefredrik Is this needed anymore?

@JPOak the purpose of that filter is to:
// Remove inline width attribute from figure tag causing images wider than 100% of its container
Did you test this with the filter removed and images that are wider than the container?

@colin-marshall I am not seeing any difference when I add an image of 2000px to the default FP template for a page. The _global for images is set to max-width: 100% . I'm just wondering if this stuff needs these function overrides now.

If images larger than the container are staying 100% width of the container with that filter removed then I see no problem with removing the filter. It serves no other purpose that I can tell.

@jturmelle if you get a chance just comment the line I mention above. It won't destroy anything, but I think it will fix your problem. Let us know. I tested with theme testing data  and it look fine.

Thanks a lot, that did fix the caption, but the image still doesn’t center, or is that just me?
This is the figure code generated:
The view out Diane Davis’ kitchen window on June 23, 2017 (Source: Diane Davis/Newfoundland Iceberg Reports).

I have this site walled off, but I’m happy to open it or send you the login if you want to look at it in person.
Jeff
Jeff Turmelle
International Research Institute for Climate and Society
The Earth Institute at Columbia University

On Feb 26, 2018, at 8:46 PM, JP<EMAIL_ADDRESS>wrote:
@jturmelle https://github.com/jturmelle if you get a chance just comment the line I mention above. It won't destroy anything, but I think it will fix your problem. Let us know. I tested with theme testing data and it look fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/olefredrik/FoundationPress/issues/1237#issuecomment-368717262, or mute the thread https://github.com/notifications/unsubscribe-auth/AFMW0K9SncRVRrTqaqOxedfHE5tSBx6qks5tY15hgaJpZM4ST-v_.

@jturmelle did you try to debug with the inspector?

Sorry,  I screwed with the SCSS trying to fix it.  I’m reverting my changes now.  I’m pretty sure that’s the remaining problem.
Jeff Turmelle
International Research Institute for Climate and Society
The Earth Institute at Columbia University

On Feb 26, 2018, at 9:21 PM, Colin Marshall<EMAIL_ADDRESS>wrote:
@jturmelle https://github.com/jturmelle did you try to debug with the inspector?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/olefredrik/FoundationPress/issues/1237#issuecomment-368723792, or mute the thread https://github.com/notifications/unsubscribe-auth/AFMW0EQ1-oab4v84NWxYpfIRjHtYkwrYks5tY2aQgaJpZM4ST-v_.

Looks like its working now.   I checked out _wp_overrides.scss to overwrite my changes and it is working again.
Thanks very much for your quick help with this!
Jeff

On Feb 26, 2018, at 9:21 PM, Colin Marshall<EMAIL_ADDRESS>wrote:
@jturmelle https://github.com/jturmelle did you try to debug with the inspector?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/olefredrik/FoundationPress/issues/1237#issuecomment-368723792, or mute the thread https://github.com/notifications/unsubscribe-auth/AFMW0EQ1-oab4v84NWxYpfIRjHtYkwrYks5tY2aQgaJpZM4ST-v_.

Is this closed out now @colin-marshall ?

Yup. Thanks.


HPP Fix + VCC

Fixed HPP broken API
Add support of VCC

Coverage remained the same at 100.0% when pulling e556ca793b15d8a794c97b178c7074024bf6e299 on hpp_plus_card_service into e5865ae093b8f36269953a7296bc969c9fd6a87f on v4.1.

Coverage remained the same at 100.0% when pulling e556ca793b15d8a794c97b178c7074024bf6e299 on hpp_plus_card_service into e5865ae093b8f36269953a7296bc969c9fd6a87f on v4.1.


comfyui ExtraVAELoader error: No module named 'diffusers'

I downloaded the sana comfyui workflow just like it's shown on numerous youtube videos, but it just doesn't work.
I can't get this error to go away no matter what I do.  I updated comfyui, added custom nodes, the sana custom nodes from github, I installed the diffusers package globally, I activated a venv and installed it in the venv, I created a new bat file to launch comfyui from the venv.  Nothing works.  How do i resilve this error?

Can you copy more details from your error log?

try
pip install diffusers["torch"]