table 38 "Purchase Header" - add integration event in procedure PrintRecords

Similar to the event  in SendRecords functions in Purchase Header, please extends IntegrationEvent in function:

PrintRecords

SendProfile
procedure SendRecords()
var
DocumentSendingProfile: Record "Document Sending Profile";
ReportSelections: Record "Report Selections";
DocTxt: Text[150];
IsHandled: Boolean;
begin
  ****IsHandled := false;
  OnBeforeSendRecords(Rec, IsHandled);
  if IsHandled then
      exit;****

  CheckMixedDropShipment();
  OnSendRecordsOnAfterCheckMixedDropShipment(Rec);

procedure PrintRecords(ShowRequestForm: Boolean)
var
DocumentSendingProfile: Record "Document Sending Profile";
DummyReportSelections: Record "Report Selections";
IsHandled: Boolean;
begin
  ### //ADD Similar event

  CheckMixedDropShipment();
  OnPrintRecordsOnAfterCheckMixedDropShipment(Rec);

  IsHandled := false;
  OnPrintRecordsOnBeforeTrySendToPrinterVendor(Rec, IsHandled, ShowRequestForm);

procedure SendProfile(var DocumentSendingProfile: Record "Document Sending Profile")
var
DummyReportSelections: Record "Report Selections";
ReportDistributionMgt: Codeunit "Report Distribution Management";
IsHandled: Boolean;
begin
  ### //ADD Similar event
  CheckMixedDropShipment();
  IsHandled := false;
  OnSendProfileOnBeforeSendVendor(Rec, IsHandled);

Thank you

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10881.


[18.09] bump libnetwork 4725f2163fb (bump_18.09 branch)

full diff: https://github.com/docker/libnetwork/compare/2cfbf9b1f98162a55829a21cc603c76072a75382...4725f2163fb214a6312f3beae5991f838ec36326
relevant changes:

https://github.com/docker/libnetwork/pull/2344 (reverts https://github.com/docker/libnetwork/pull/2286 / https://github.com/docker/libnetwork/pull/2285)
https://github.com/docker/libnetwork/pull/2327 Fix possible nil pointer exception

ping @andrewhsu @fcrisciani PTAL


Horizontal Downsampling

Hello, amazing work you’ve done here; thank you so much.
I noticed that downsampling only functions vertically. Horizontal resolution is always maintained, resulting in non-square pixels.
This is a great feature and I’m happy to have it, but I’m surprised that that Downsampling on both axes is not the default.
Is there any hope of adding this?
Thank you for all your work.
Regards

Downsampling is in both dimensions. By default, N64 output is 640x240 after VI scanout

Downsampling is in both dimensions. By default, N64 output is 640x240 after VI scanout

If that’s the case, then why do I see increasing horizontal resolution moving down this list of settings, while vertical resolution stays constant:

1x Supersampling with 1/1 Downsampling
2x Supersampling with 1/2 Downsampling
4x Supersampling with 1/4 Downsampling
8x Supersampling with 1/8 Downsampling

If that’s the case, then why do I see increasing horizontal resolution moving down this list of settings, while vertical resolution stays constant:

1x Supersampling with 1/1 Downsampling
2x Supersampling with 1/2 Downsampling
4x Supersampling with 1/4 Downsampling
8x Supersampling with 1/8 Downsampling

That sounds weird, how are you observing this increasing horizontal resolution?

That sounds weird, how are you observing this increasing horizontal resolution?

I don’t have access to my computer right now, otherwise I would upload a screenshot.
The horizontal resolution increases because the aspect ratio of each pixel increases.
The Pixel Aspect Ratio (PAR) increases with each of the settings above like this:

1:1 PAR, 320x240 Observable Resolution
2:1 PAR, 640x240 Observable Resolution
4:1 PAR, 1280x240 Observable Resolution
8:1 PAR, 2560x240 Observable Resolution

This is using a GTX 980 Ti.

I don’t have access to my computer right now, otherwise I would upload a screenshot.
The horizontal resolution increases because the aspect ratio of each pixel increases.
The Pixel Aspect Ratio (PAR) increases with each of the settings above like this:

1:1 PAR, 320x240 Observable Resolution
2:1 PAR, 640x240 Observable Resolution
4:1 PAR, 1280x240 Observable Resolution
8:1 PAR, 2560x240 Observable Resolution

This is using a GTX 980 Ti.

I should add that I play with the VI Bilinear filter disabled

I should add that I play with the VI Bilinear filter disabled

Did you restart core after changing the scaling factor?

Did you restart core after changing the scaling factor?

Yes, I fully restart RetroArch

Yes, I fully restart RetroArch

Well, it does the right thing for me.

With 4x upscale -> 1/4 downscale. 2390x896 is scaled down to 597x224 as expected. The odd horizonal resolution is cropping.

Well, it does the right thing for me.

With 4x upscale -> 1/4 downscale. 2390x896 is scaled down to 597x224 as expected. The odd horizonal resolution is cropping.

I will take some screenshots and upload my config.
It might be a day or two until I can.

I will take some screenshots and upload my config.
It might be a day or two until I can.

So, I was partly mistaken about what I was seeing.
You can see that 1x with no downscaling retroarch shows square pixels.
2x, 4x, and 8x using 1/2, 1/4, and 1/8 downscaling respectively show rectangular pixels.
This doesn't make sense to me since I would expect that downscaling an image by the same factor that it was upscaled by would return you to the same number of pixels you started with, represented by 1x.
But clearly there are twice as many pixels horizontally after downscaling than if you never upscaled to begin with, which is why it looks like the x and y axes are not scaled the same.
1x

2x

4x

8x

So, I was partly mistaken about what I was seeing.
You can see that 1x with no downscaling retroarch shows square pixels.
2x, 4x, and 8x using 1/2, 1/4, and 1/8 downscaling respectively show rectangular pixels.
This doesn't make sense to me since I would expect that downscaling an image by the same factor that it was upscaled by would return you to the same number of pixels you started with, represented by 1x.
But clearly there are twice as many pixels horizontally after downscaling than if you never upscaled to begin with, which is why it looks like the x and y axes are not scaled the same.
1x

2x

4x

8x


React 0.13.x compatibility (without mixins)

React is deprecating mixins for ES6 classes. So, what would be an alternative to use radium with ES6?
Some inspiration can be found here:
https://gist.github.com/sebmarkbage/ef0bf1f338a7182b6775
Any thoughts?

Nice! I hadn't see that proposal until now. This seems like a decent
alternative, and very similar to my proposal in #80 for Radium.wrap.
On Thu, Mar 12, 2015 at 9:01 PM, Alan R. Soares<EMAIL_ADDRESS>wrote:

React is deprecating mixins for ES6 classes. So, what would be an
alternative to use radium with ES6?
Some inspiration can be found here:
https://gist.github.com/sebmarkbage/ef0bf1f338a7182b6775
Any thoughts?
—
Reply to this email directly or view it on GitHub
https://github.com/FormidableLabs/radium/issues/87.

It should be possible to have an implementation that allows you to use it like this:
var React = require('react');
var Radium = require('radium');

var Component = React.createClass({
  render() {
    return <div style={this.props.style} {...this.props.stateEvents}>
      Content
    </div>;
  }
});

var styles = (state, props) => ({
  // can use `state` or `props` here
  margin: '5px',
  states: [ { hover: { margin: '0' } } ]
});

module.exports = Radium.styleResolver(Component, styles);

Radium.styleResolver would be a higher-order component that would pass the resolved styles as props.style and the state event handlers in props.stateEvents to the component. props.stateEvents would be an object such as { onMouseDown: function() { ... } }. This would get away from mixins and allow using ES6 classes.
The only thing about this that I don't like is that the styles function is totally separate from the component class object. We could use a static function to get around this but not sure which would be nicer.
All that said, I think it would be nice to have a release that supports 0.13 without drastically changing the API (still using mixins) in the short term.

Thanks all! Release supporting 0.13.x should be ready ~tonight. (There's a matchMedia context issue I want to fix before tagging it, but everything else still works fine if you're using createClass.)

That said-- going to close this one as a duplicate of #65.

A note to anyone who read this and was scared: neither createClass or its mixins property are depricated.  0.13 simply allows people to start playing with a class-based style if they don't need mixins and prefer that.
From Facebook's post on 0.13: "until we have a replacement for current mixin use cases and support for class property initializers in the language, we don't plan to deprecate React.createClass".
It's unfortunate that createClass wasn't named createComponent or just component.  The issue linked by alexlande has some more background.


Cannot query Stripe FDW using client sdk

Bug report

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
Cannot query data from the Stripe FDW using client sdk. I have tried several different ways but have not managed to do this successfully. Not even using the service role key.
To Reproduce

Go to the Supabase Dashboard Settings > Database > Wrappers and set up Stripe FDW. Create the foreign tables in the public schema.
Attempt to query the tables from the client sdk, any key - anon or service_role

const { data } = await supabase.from('public.stripe_products').select().throwOnError();

Produces the following error message:

permission denied for schema vault

I have also reproduced the issue this way:

Go to Supabase Dashboard Settings > Database > Wrappers and setup Stripe FDW, but this time create the foreign tables in a private schema named stripe.
Create a view in the public schema which displays the data from the foreign table.

create or replace view public.products as select * from stripe.products;

Attempt to query the view from the client sdk, use any key: anon or service_role

const { data } = await supabase.from('public.products').select().throwOnError();

Same error message is produced

permission denied for schema vault

Expected behavior
I expected to be able to query the data that is visible in the public schema. I am trying to use stripe to store product data which should be visible to customers.
Related Issues

https://github.com/supabase/wrappers/issues/246

The foreign table does not provide Row Level Security, so it is not advised to expose them via API (client sdk) access. The Wrappers Docs explained this in details and provided security definer function as an alternative solution.


Benchmarks when not tracing

For a reality check to see how we are doing, it is essential
that we compare the overhead of work that's done without tracing
entirely. The results are a dunk of one's head in cold water.

tracing, sampling: NeverSample vs AlwaysSample

$ benchstat w_nosample.txt w_sample.txt
name  old time/op    new time/op    delta
It       200ns ± 2%     611ns ± 1%  +205.12%  (p=0.029 n=4+4)

name  old alloc/op   new alloc/op   delta
It        128B ± 0%      576B ± 0%  +350.00%  (p=0.029 n=4+4)

name  old allocs/op  new allocs/op  delta
It        2.00 ± 0%      4.00 ± 0%  +100.00%  (p=0.029 n=4+4)

no tracing vs NeverSample

$ benchstat notracing_reuse.txt w_nosample.txt
name  old time/op    new time/op    delta
It      5.68ns ± 2%  200.25ns ± 2%  +3427.08%  (p=0.029 n=4+4)

name  old alloc/op   new alloc/op   delta
It      0.00B ±NaN%   128.00B ± 0%      +Inf%  (p=0.029 n=4+4)

name  old allocs/op  new allocs/op  delta
It       0.00 ±NaN%      2.00 ± 0%      +Inf%  (p=0.029 n=4+4)

no tracing vs AlwaysSample

$ benchstat notracing_reuse.txt w_sample.txt
name  old time/op    new time/op    delta
It      5.68ns ± 2%  611.00ns ± 1%  +10661.78%  (p=0.029 n=4+4)

name  old alloc/op   new alloc/op   delta
It      0.00B ±NaN%   576.00B ± 0%       +Inf%  (p=0.029 n=4+4)

name  old allocs/op  new allocs/op  delta
It       0.00 ±NaN%      4.00 ± 0%       +Inf%  (p=0.029 n=4+4)

You can make the overhead of tracing (percentage-wise) almost arbitrarily large by making "doWork" cheaper. Conversely, you can easily "fix" the high overhead of tracing by replacing "doWork" with something arbitrarily more expensive.
The point of microbenchmarks is to gradually improve the performance of a small piece of code, not to prove that overhead is acceptable. You can't prove that in a microbenchmark because, as shown above, it all depends on what else your program is doing.

I agree with what @ramonza says. I don't think we should merge this PR.


docs(colors): get color from element

📥 Proposed changes
affects: @fremtind/portal
changed from hardcoded color to picking out the color using getComputedProperty
ISSUES CLOSED: #1399
☑ Submission checklist

[x] I have read the CONTRIBUTING doc
[x] yarn build works locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

@all-contributors please add @Fridaks for code


function to both download and unzip ts file[s]

load_timeseries is nice for R users, but we could also make it easier for excel/sas/etc. users by providing downloading and unzipping a ts file all in one go. could even wrap load_timeseries and write a new, merged table to text file. what to call it...or maybe it's an option to download_timeseries...?

resolved: get_ts %>% export_data


Various Helm 3 Improvements

This PR covers a series of Helm issues as well as a few things I fixed myself in the process of working on these issues.

[x] HELM-98: Alarm Table text bold if 'Style with severity' is checked
[x] HELM-116: Alarm table no longer respects column sizing
[x] HELM-117: Unable to deselect a row in the Alarm Table
[x] HELM-118: Enable Table panel to display durations
[x] HELM-120: Sorting by number of alarms in the alarm table panel
[x] HELM-121: Related alarm view should show the node label
[x] HELM-124: Limit number of alarms returned by the FM DS
[x] HELM-125: Add the ability to see the complete alarm JSON from the alarm details view
[x] HELM-126: white text when Style With Severity=Row is hard to read

LGTM other than 3 things:

the obvious 'JSON' debug panel,
the |!/ situation debug  inspection panel and
I'm seeing the same hover issue Jesse mention where the Related Alarms dissapear to a dark row in the dark theme.

Looks good!


Reactabular 0.15-beta9 out - Feedback welcome!

beta1
I pretty much rewrote the component based on #109 ideas (context based API). The component is more flexible now. I ended up simplifying it in a few ways while at it. The old cell API accepts just something you can pass through a React component (i.e., a string, number, React component, ...). You can still achieve the same things and more as before.
beta2

Fixed requires at dist-modules. The problem was that Babel renamed Table.jsx and Search.jsx to lowercase while retaining requires in uppercase. Now they should be in lowercase.

beta3

I resolved #143 and #149. This means you can use nested definitions at property. So property: 'dad.name' is acceptable. It will work with sorting and search too.

beta4

New site and documentation. Still bit of a WIP.

beta5

Redesigned column definition. It's clearer what's going on now even though there are more fields to think about. The semantic split was needed to make it all work together nicely.
Started improving test coverage. There's still work left to do with that but getting better.

beta6

Improved test coverage.
Renamed cell.value as more descriptive cell.resolve.
Dropped redundant formatters. Only highlight remains at the core.
Moved to curry pattern for transforms. So you now you get edit(...)(...) instead of having to bind.
Expanded documentation somewhat. There might still be bits missing so be sure to comment.
Implemented selection example.

beta7

Improved test coverage. Now we are hovering near 100% and it seems good enough although I may be missing some tests still.
Improved className handling at Table.Header and Table.Body. Now it merges possible className returned from a transform correctly. I'm not happy about this but I couldn't see any neater way to do this given React expects a string and I didn't want to introduce an external dependency just for this.
Rewrote the search interface. The API should be more sensible now. I extracted the Search component from the core and pushed it to documentation helpers. It's quite likely it will become a package of its own and I might push the logic there as well. Given the logic is generic, we could end up with two packages. One for the React bit, one for logic.
Expanded the tree example to multiple levels. While at it I did a performance pass so searches are linear (relies on ordered structure). Performance can likely be improved further. I'll need to generate test data to see the limits better.

The documentation can use some work still, but the APIs are starting to feel solid. I still need to do a couple of examples to exercise the API further and see how it works out.
beta8

Made search work correctly with resolved values.
Renamed header.value to more descriptive header.label.

beta9

Made search operate correctly with selected columns. Due to a naming error (parameter) it was searching all instead of the specified columns.
Pushed rowKey to Table from Table.Body. That felt like a better place for it and this clean the table definition further.
Tidied up the "full table" example. It's using a different data generator now and overall is nicer to study. Also fixed a pagination related glitch there. Now the paginator uses the correct data.

--
There are still smaller things to do like release logs and a migration guide, but not that much. Feedback would be very welcome.

You can install the beta through npm i reactabular@beta9.

Wonderful :) Unfortunately, at this point I run into
ERROR in ./~/reactabular/dist-modules/Table.js
Module build failed: Error: ENOENT: no such file or directory, open '/home/sebastian/projects/cra/node_modules/reactabular/dist-modules/Table.js'
    at Error (native)
 @ ./~/reactabular/dist-modules/index.js 7:13-31

ERROR in ./~/reactabular/dist-modules/Search.js
Module build failed: Error: ENOENT: no such file or directory, open '/home/sebastian/projects/cra/node_modules/reactabular/dist-modules/Search.js'
    at Error (native)
 @ ./~/reactabular/dist-modules/index.js 16:14-33

as well as
warning.js?8a56:44Warning: Failed Context Types: Required context `columns` was not specified in `Header`

although I'm following the examples to a T (as far as I can tell).

@skosch Thanks for letting me know! Investigating the distribution further revealed that Babel transforms the source so that while it renames the files (i.e., Table.jsx -> table.js), it doesn't take this transformation fully into account at the imports it generates (it does require('./Table.js') here). I "fixed" this by renaming files a bit and pushed out beta2.
To install, try npm i reactabular@beta2. Hopefully we have better luck this time. 👍

In case anyone is following, there's proper support for nested data now. You can use property: 'dad.name' kind of declarations (arbitrary nesting). This works with search and sorting too.

I updated the site. Please have a look and let me know what you think. I know there are still rough bits and the main bundle is far too big.

Hi,
I just found this component and love it so far.
The sorting is not working as expected at the moment. When I click a th for the third time, the item is not removed from state.sortingColumns. Only sort is set to "" which leads to _.orderBy's default asc order.
So you can't remove a column from the sorting once you added it ...
A quick fix could be something like
const sort = cycleSort(newSortingColumns[index].sort);
if (!sort) {
    newSortingColumns.splice(index, 1);
} else {
    newSortingColumns[index] = {
      property: selectedColumn,
      sort,
    };
}

here https://github.com/bebraw/reactabular/blob/master/src/sort/byColumns.js#L15

@sokki Thanks! Good catch. I'll get that fixed.
The API might change still a bit. It would be great if you could comment at #151 .

There's a new beta available. I redesigned the column interface. It's a little clearer what's going on now. More fields but clarity as well. I also started pushing test coverage forward although there's still work to do.
@sokki Fixed now.

By the way – loving the documentation site! :)

the value → resolve fix is on master, but needs to be pushed to gh-pages
while you're at it, could you make a note in the documentation about the extraParameters?

Yeah. I realized the naming gotcha after the beta. That's going to the next one.
I have to enumerate the extraParameters interface in detail. Good point.

Beta 6 is out there now. Read the issue description for changes. There were quite a few.

Beta 7 is available now. Most important thing - new search API. As usual, refer to the issue description for more details.

@bebraw I'm having trouble with the new search API unfortunately.
I suspect it has to do with search.js#L48, which calls value instead of resolve, and doesn't pass along any extraParameters either (but then again I haven't debugged it much, so that may be mistaken).
At any rate I keep running into a TypeError: Cannot read property 'toString' of null at the line formattedValue = formattedValue.toString ? formattedValue.toString() : ''; .. any ideas?

Yeah. That should be resolve. Thanks! I'll fix that for the next beta.

@skosch I fixed the issue in beta8. Also renamed header.value as header.label as that describes the intent better.

Pushed beta9. A couple of minor tweaks. Most importantly rowKey was pushed to Table directly as that gives a cleaner API.

Extremely minor nitpick: search.multipleColumns({ data, columns, query }); takes an object, whereas sort.sorter(data, sortingColumns, orderBy); takes individual params.
Overall, things are coming together really nicely :+1:
Also (a bit off-topic but I wanted to mention it) I got my multi-column sorting to work by setting my table component's initial columns state to
columns: props.columns.map((c, ci) => Object.assign(c, {
        header: {
          ...c.header,
          transform: (input) => ({
            ...(c.header.preTransform ? c.header.preTransform(c.header.label) : {}),
            ...sortable(ci)(input)
          })
        },
      })),

and by sorting the data as such:
let sortedData = [];
if (this.state.sortingColumns.length) {
  const flattenedData = cloneDeep(filteredData); // make a copy
  /* go through each of the sorting columns, loop through all values and resolve the data. */
  for (let j = 0, k = this.state.sortingColumns.length; j < k; j++) {
    const sortIndex = this.state.sortingColumns[j].property; // property is actually the column index
    const column = this.state.columns[sortIndex];
    const resolver = (column.cell.resolve && typeof column.cell.resolve === 'function') ? column.cell.resolve : (a => a);
    for (let i = 0, l = flattenedData.length; i < l; i++) {
      flattenedData[i][column.cell.property] = resolver(flattenedData[i][column.cell.property], {cellData: flattenedData[i]});
      flattenedData[i].index = i;
    }
  }

  /* throw the data into orderBy */
  const sortedFlattenedData = sort.sorter(flattenedData, this.state.sortingColumns.map(c => ({
    sort: c.sort,
    property: this.state.columns[c.property /* actually the column index */].cell.property
  })), orderBy);
  /* go through the sorted data and re-shuffle the original according to the new order of indices */
  sortedData = new Array(sortedFlattenedData.length);
  for (let i = 0, l = sortedFlattenedData.length; i < l; i++) {
    sortedData[i] = filteredData[sortedFlattenedData[i].index];
  }
} else {
  sortedData = filteredData;
}

... maybe something of the sort can be thrown into the docs/helpers folder as well, so people don't end up stumbling in the dark.

Extremely minor nitpick: search.multipleColumns({ data, columns, query }); takes an object, whereas sort.sorter(data, sortingColumns, orderBy); takes individual params.

Good point. I'll get that sorted out.

Also (a bit off-topic but I wanted to mention it) I got my multi-column sorting to work by setting my table component's initial columns state to

If you could PR, that would be great. I'm currently shuffling the docs a bit, but after that would be fine.

beta10 is available now. The search API signatures are object based from now on. I made this change to make the API consistent with rest of the component. See the issue description for further information.

Getting the following error when I try to webpack using beta10:
ERROR in ./~/reactabular/dist-modules/table.js
Module not found: Error: Cannot resolve module 'lodash/get' in /path/to/my/project/node_modules/reactabular/dist-modules
 @ ./~/reactabular/dist-modules/table.js 11:11-32

ERROR in ./~/reactabular/dist-modules/search.js
Module not found: Error: Cannot resolve module 'lodash/get' in /path/to/my/project/node_modules/reactabular/dist-modules
 @ ./~/reactabular/dist-modules/search.js 7:11-32

ERROR in ./~/reactabular/dist-modules/sort.js
Module not found: Error: Cannot resolve module 'lodash/get' in /path/to/my/project/node_modules/reactabular/dist-modules
 @ ./~/reactabular/dist-modules/sort.js 7:11-32

ERROR in ./~/reactabular/dist-modules/table.js
Module not found: Error: Cannot resolve module 'lodash/has' in /path/to/my/project/node_modules/reactabular/dist-modules
 @ ./~/reactabular/dist-modules/table.js 15:11-32

It looks like there's no lodash dependency in the package.json

There's a new beta available now. Plenty of changes as described in the issue above. The biggest change was moving from transform to transforms array. More flexible this way.
@marcello3d Fixed in beta11.

Should lodash be an regular dependency? In my case, our app code already depends on lodash 3 (which is incompatible with 4), so I have to decide between updating reactabular and lodash at the same time, or neither.

@marcello3d The problem is that Reactabular is married with lodash 4 API. That's why the minimum version. I can see this can be problematic, though.
The lodash dependency is quite light. Currently we depend just on get, has, merge, and orderBy. Probably the biggest problem is the way I require. I have bits like import merge from 'lodash/merge';.
One way to solve this would be to push the dependencies into an adapter. So we would get reactabular-lodash3, reactabular-lodash4 and so on. This would decouple Reactabular from lodash and allow you to use other solutions with it as long as you implement the same interface.
Would this work for you?

No need!
With npm 3, if reactabular had a (non-dev/peer) dependency on lodash 4, it'd install two copies and should "just work":
myapp/node_modules/lodash -- would be v3
myapp/node_modules/reactabular/node_modules/lodash -- would be v4

And if the developer instead depends on lodash 4, it'd only install one copy in app/node_modules/lodash.
With npm 2, it may or may not install two copies, depend on the order they get installed (lodash first or reactabular first). However, client-side bundlers can de-dupe identical modules.
Since you're already depending on subfiles of lodash, the overhead of including both lodash 3 and 4 functions is low (in our case, I don't think we're even using any of the same lodash methods, so there'd be no duplication).
(The exception to this approach is React itself, because it needs a single global instance per browser session—leading the use of peer deps.)

Good points. I guess the question is, can I rewrite the imports so that they work for both lodash 3 and 4?
Direct dependency would be acceptable. I guess the version range would have to be very broad then?
Implementing an adapter would add certain overhead as then you would have to glue the adapter with the core before you could actually use it. That's not really the Node way.

You might be able to rewrite the imports to work on both, but it'd probably end up a little hacky. I don't know enough about lodash to know if there's a clean way to do it.
I think it's reasonable that if someone is depending on lodash 3 that they'll have extra bundled functions (from v3 and v4) until they're ready to upgrade to lodash 4.

@marcello3d If you are on webpack, you can definitely write aliases for each import (not too many). I can document the basic idea and loosen the peer dependency range so it won't fail to install.
Note that the dist version bundles the lodash bits I use. That adds to the dist size, but at least those are standalone. That's actually another way to deal with it. You can alias to the dist version and consume it from there. This would solve the problem as well I think.
I don't mind changing the dependency declaration. Just need to understand which way to go. npm 2 vs. 3, peer/normal deps, lodash 3/4 add to the complexity. I need a solution that works for all and I can cover those special cases like aliasing through documentation.

Beta 12 is out. Some API work was done (mainly columnIndex, rowIndex are available to formatters/transforms, added header.component and cell.component for extra flexibility). Most of the time was spent on examples.

Beta 14 is out (skipped 13 for technical reasons). See the issue description as usual.
@marcello3d I expanded the version range and added installation docs. Could you see if that's enough for Lodash 3?

whoa, cool stuff!
I promise I'll shut up about it after this, but do you see the sorter getting an upgrade to work on resolved values, or will that remain a userspace thing for this release?

I promise I'll shut up about it after this, but do you see the sorter getting an upgrade to work on resolved values, or will that remain a userspace thing for this release?

Can you open a separate issue? I might need some hammering to get the idea right. 👍

Opened #160 :)

Pushed rc2 to fix Table.Provider. There was something extra in dist-modules preventing it from working correctly. Better fix tooling a bit.

rc3 is available now. See the issue for further details. If nothing serious appears, this is likely the final release. We can always do 2.0, 3.0 if the API has to break.

Uhhh, one last thing on my wishlist: an example in the docs on how to use sortingColumns to initialize the sorting.

@skosch Yeah, I'll do that for the final. Thanks. 👍

rc4 is out. Most importantly the sort interface includes order information now since that matters for multi-column sorting. Also made toFormatter more generic function. See the issue for further details.
Unless something serious comes up, this will likely be the final release. Still not too late to get changes in. If we need to break the API after that, then we'll do 2.0 etc.

Ahhh, yet another thing! Since updating react I'm regularly getting invalid props errors à la
cra.dll.js:1201 Warning: Unknown props `candidate`, `faculty`, `room`, `group` on <tr> tag. Remove these props from the element. For details, see https://fb.me/react-unknown-prop
    in tr (created by BodyRow)
    in BodyRow (created by Body)
    in tbody (created by Body)
    in Body (created by Qtable)
    in table (created by Provider)
    in Provider (created by Qtable)
.....

so it looks like there is a little bit more cleaning up to do :|

@skosch Could you open a separate issue about that with a minimal example? Are you passing custom props around? The current version of React is very strict.

rc5 is available. See #165.
There are some breaking changes so take care when upgrading. Esp. property: 'foo.bar', highlight and edit behavior changed for the better. The documentation examples get to the ideas the best. The old cell.resolve field still works but that will most likely change a bit in the next release.

For the record, that problem three comments up … it was due to carelessness in my onRow handler. Nothing to see here.


Semicolon error in npm installed with yarn

I have installed a version with bower and it is working. However, I have installed circleType with yarn in another project and, when i do gulp to generate the app.js file, the file generated does not work. The error is:
TypeError: (intermediate value)(...) is not a function
When i go to the file /node_modules/circletype.js/circletype.js i can see these last lines:
      if (document.readyState !== 'complete') {         elem.style.visibility = 'hidden'         $(window).on('load', function () {           elem.style.visibility = 'visible'           layout()         })       } else {         layout()       }     })   } }))
If I manually add a semicolon at the end of the last line and i do the gulp process it works like a charm. In the bower version the file finish fine with semicolon.
I have resolved the problem by placing circletype library at the last position of the gulpfile. This way there are no more libraries after circleType and there is no error. But I don't think this is a definitive solution.

Are you using this fork?
https://github.com/mike3run/CircleType/blob/master/circletype.js
It looks like the semicolons were removed from this version, for some reason.

I will add package.json so you can load this npm.

@hisie You can now install this package with npm:
npm i circletype --save


Set up app to render templates

User Stories

As a user, I want to be able to view the home and dashboard pages in the browser

Added base /routes, /templates, /static - into /app.


Allow changing destination directory name of Cloned Gist Repositories

Is your feature request related to a problem? Please describe.
Clone to Repository saves as the gist GUID which can make it hard to identify
Describe the solution you'd like
When choosing "Clone Repository", offer a popup to name the repository folder in the target rather than the GUID it is typically assigned. This behavior could be toggled by a preference variable
Describe alternatives you've considered
Clone and then rename afterwards, however this is less desirable to the workflow

Ah yeah, that's a great suggestion! In your case, do your gists have descriptions, that you'd want to use as the cloned folder name? At a minimum, we should definitely use the description if the gist has one, since the ID is pretty useless 😁

Ah yeah, that's a great suggestion! In your case, do your gists have descriptions, that you'd want to use as the cloned folder name? At a minimum, we should definitely use the description if the gist has one, since the ID is pretty useless 😁

I normally give them descriptions, but it should still prompt with the description auto-populated, because my descriptions tend to be very verbose which I'm not sure if that's the norm or not:

I normally give them descriptions, but it should still prompt with the description auto-populated, because my descriptions tend to be very verbose which I'm not sure if that's the norm or not:

Got it. Thanks for sharing that detail!

Got it. Thanks for sharing that detail!


Improper benchmarking of throughput

Hi,
Thanks for the benchmark! I noticed that the benchmark uses timeit, and each iteration repeatedly creates a new gRPC channel:
https://github.com/llucax/python-grpc-benchmark/blob/94a175fbcbb7d144506b5f5099c8b87e9f21c658/benchmark#L21
https://github.com/llucax/python-grpc-benchmark/blob/94a175fbcbb7d144506b5f5099c8b87e9f21c658/grpcio/client.py#L9-L12
However, more realistic scenarios would involve creating a single channel and reusing it for multiple RPC calls. I've forked the repo and and re-ran the benchmarks for multiple payload sizes:

unary-unary: grpc.aio achieved 1.5-2x throughput vs. grpclib
unary-streaming: grpc.aio achieved 1.3x-0.9x throughput vs. grpclib

It seems like grpc.aio (blue) actually shows significantly better performance compared to grpclib (orange) for single calls, but slightly poorer performance for large streaming requests.

Test conditions: i5-13600K, 32GB RAM, Python 3.11, 1000 loops

Very interesting, thanks a lot for sharing!

The official documentation has mentioned in the performance best practices section that unary RPCs in Python have higher performance than streaming RPCs because there are extra threads
https://grpc.io/docs/guides/performance/#python


[Event Request] Report 188 "Create Reminders" - OnProgressWindowUpdateOnAfterGetRecordCustomer

Hi, would it be possible to get an OnProgressWindowUpdateOnAfterGetRecordCustomer event in report 188 (Create Reminders), like this:
            trigger OnAfterGetRecord()
            var
                IsHandled: Boolean;
                Result: Boolean;
            begin
                RecordNo := RecordNo + 1;
                Clear(MakeReminder);
                MakeReminder.Set(Customer, CustLedgEntry, ReminderHeaderReq, OverdueEntriesOnly, IncludeEntriesOnHold, CustLedgEntryLineFeeOn);
                if NoOfRecords = 1 then begin
                    Result := false;
                    IsHandled := false;
                    OnAfterGetRecordCustomerOnBeforeMakeReminder(
                        Customer, CustLedgEntry, ReminderHeaderReq, OverdueEntriesOnly, IncludeEntriesOnHold, CustLedgEntryLineFeeOn, Result, IsHandled);
                    if not IsHandled then
                        MakeReminder.Code();
                    Mark := false;
                end else begin
                    NewDateTime := CurrentDateTime;
                    if (NewDateTime - OldDateTime > 100) or (NewDateTime < OldDateTime) then begin
                        NewProgress := Round(RecordNo / NoOfRecords * 100, 1);
                        if NewProgress <> OldProgress then begin
                            Window.Update(1, NewProgress * 100);
                            OldProgress := NewProgress;
                            OnProgressWindowUpdateOnAfterGetRecordCustomer(Customer, Window); // New Event
                        end;
                        OldDateTime := CurrentDateTime;
                    end;
                    Result := false;
                    IsHandled := false;
                    OnAfterGetRecordCustomerOnBeforeMakeReminder(
                        Customer, CustLedgEntry, ReminderHeaderReq, OverdueEntriesOnly, IncludeEntriesOnHold, CustLedgEntryLineFeeOn, Result, IsHandled);
                    if IsHandled then
                        Mark(Result)
                    else
                        Mark := not MakeReminder.Code();
                end;
            end;

    [IntegrationEvent(false, false)]
    local procedure OnProgressWindowUpdateOnAfterGetRecordCustomer(Customer: Record Customer; var Window: Dialog)
    begin
    end;

Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 40900.


Installing through pods

Hi, Please help  when updated to swift 3.When I install it through pods and open the project it always sees it as an old swift version how can I install the latest version compatible with swift 3 through pods.
Thanks in advance.

@mahmoudnaja, how did you setup your Podfile?

Hi here is my podfile.
source 'https://github.com/CocoaPods/Specs.git'
platform :ios, ‘8.1’
use_frameworks!
target “App” do
pod 'ObjectMapper', '~> 2.0'
end

Did you mean that your ObjectMapper 1.x is installed?

Yes it installs version 1.x

@mahmoudnaja have you tried $ pod update? If it doesn't work, try:
$ pod repo update
$ pod install

Will try the above and will let you know if it works

Thanks the above worked


Inconsistent Display of repositories in Organization

I have the following setup:

Organization "O"
User "U" who is not a member of organization "O"
Organization "O" has a non-private repository "R"
Organization "O" has a private repository "P" with user "U" as a collaborator

When user "U" looks at the organization site of organization "O" ("gogs.example.com/org/O") that usually shows the repositories of this organization, both repositories "R" and "P" are not listed there.
I would expect that either

the repositories "R" and "P" are displayed on the organization "O" site for user "U" or
user "U" can not access the overview site of organization "O".

If I could set a priority to this issue, it would be very low.

Close now but open for continuing discussion.


Emit warning on chainerx import in debug mode

Fixes #7177

Jenkins, test this please.

Jenkins CI test (for commit 2b67692762d5b517c2217a62d7b5946e8e16a00e, target branch master) failed with status FAILURE.

The Jenkins failure seems unrelated to this PR. LGTM.


refactor(ObjectId): remove buffer dependencies

I'll rebase this PR when tests were fixed by you. so don't merge it until that

This PR can be merged now

test [ObjectId] should correctly handle objectId timestamps ... ok (10ms)
test [ObjectId] should correctly create ObjectId from ObjectId ... ok (9ms)
test [ObjectId] should throw error if empty array is passed in ... ok (9ms)
test [ObjectId] should throw error if nonempty array is passed in ... ok (8ms)
test [ObjectId] should throw error if empty object is passed in ... ok (8ms)
test [ObjectId] should throw error if object without an id property is passed in ... ok (10ms)
test [ObjectId] should correctly create ObjectId from object with valid string id ... ok (10ms)
test [ObjectId] should correctly create ObjectId from object with valid string id and toHexString method ...dooe
ok (13ms)
test [ObjectId] should correctly create ObjectId from object with valid Buffer id ... ok (9ms)
test [ObjectId] should correctly create ObjectId from object with valid Buffer id and toHexString method ... ok (8ms)
test [ObjectId] should throw error if object with non-Buffer non-string id is passed in ... ok (9ms)
test [ObjectId] should throw an error if object with invalid string id is passed in ... ok (8ms)
test [ObjectId] should correctly create ObjectId from object with invalid string id and toHexString method ... ok (8ms)
test [ObjectId] should throw an error if object with invalid Buffer id is passed in ... ok (8ms)
test [ObjectId] should correctly create ObjectId from object with invalid Buffer id and toHexString method ... ok (8ms)
test [ObjectId] should correctly create ObjectId from 42 and result in 42 ... ok (9ms)
test [ObjectId] should correctly create ObjectId from 42 and result in 42 ... ok (8ms)
test [ObjectId] should correctly create ObjectId from 4.2 and result in 4 ... ok (7ms)
test [ObjectId] should correctly create ObjectId from NaN and result in 0 ... ok (9ms)
test [ObjectId] should correctly create ObjectId undefined or null ... ok (8ms)
test [ObjectId] should throw error if non-12 byte non-24 hex string passed in ... ok (8ms)
test [ObjectId] should correctly create ObjectId from 24 hex string ... ok (8ms)
test [ObjectId] should correctly create ObjectId from 12 byte sequence ... ok (8ms)
test [ObjectId] should correctly create ObjectId from uppercase hexstring ... ok (9ms)
test [ObjectId] should correctly create ObjectId from valid Buffer ... ok (10ms)
test [ObjectId] should throw an error if invalid Buffer passed in ... ok (12ms)
test [ObjectId] should correctly allow for node.js inspect to work with ObjectId ... ok (12ms)
test [ObjectId] should isValid check input Buffer length ... ok (10ms)
test [ObjectId] should throw if a 12-char length but non-12 byte string is passed in ... ok (12ms)
test [ObjectId] should have isValid be true for 12-char length and 12-byte length string ... ok (11ms)
test [ObjectId] should have isValid be false for 12-char length but non-12-byte length string ... ok (11ms)
test [ObjectId] should correctly interpret timestamps beyond 2038 ... ok (10ms)
test result: ok. 32 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (324ms)


Pow breaks when used with Network Link Conditioner

.dev domains fail to load when the Network Link Conditioner is turned on in OS X Mavericks.
This is the error in Chrome:

So far the only solution I've found is a full restart. There doesn't appear to be anything happening in the logs. Everything silently fails the moment the Network Link Conditioner is turned on.

+1

+1

+1

+1

+1

+1

Pow (0.5.0) remains broken, even after turning off Network Link Conditioner and restarting Pow. It seems clear that the Network Link Conditioner operates in part by altering pf rules to push traffic through dummynet, and in doing so breaks Pow's rule redirecting port 80. What's worse, when the Network Link Conditioner is turned off, it does not fully restore pf to its previous state. I hope people who read this and have some influence at Apple will get on them to fix this.
Meanwhile, as a workaround, you can at least restore pow to working order after turning off the Network Link Conditioner by resetting pf with
sudo pfctl -f /etc/pf.conf

Note that if you do this while the Network Link Conditioner is active, you will bypass the Network Link Conditioner without any indication in the UI and then when you turn it off via the UI, it will break pf again and you will have to reset pf again.
Overall, you may have better luck with using the link conditioning built into the Google Chrome browser dev tools or in the iOS developer tools on real Apple iOS devices.

Thanks @Nuru. That is very helpful to know.

+1


fix: editinplace replace outline with border

Closes #5779
fixes an issue where EditInPlace inside of a td was having experiencing a visual bug when focused. replacing outline with border allows the cell to appropriately size the component.

@ariellalgilmore when you have a chance to look 👍


@option options (see #other)  doesn't work

Here's what I'm trying to do:
  # @param name [#to_s] The name of the cassette. VCR will sanitize
  #                     this to ensure it is a valid file name.
  # @param options [Hash] The cassette options. The given options will
  #  be merged with the configured default_cassette_options.
  # @option options :record [:all, :none, :new_episodes, :once] The record mode.
  # @option options :erb [Boolean, Hash] Whether or not to evaluate the
  #  cassette as an ERB template. Defaults to false. A hash can be used
  #  to provide the ERB template with local variables.
  def insert_cassette(name, options = {})
  end

  # @param (see #insert_cassette)
  # @option options (see #insert_cassette)
  def use_cassette(*args, &block)
    cassette = insert_cassette(*args)

    begin
      call_block(block, cassette)
    ensure
      eject_cassette
    end
  end

There's a lot more doc comments in the file, but those are the pertinent ones.  I want the use the see #insert_cassette reference tag to have it copy all the option docs over, but it's not working.  Is the see syntax supposed to work for copying option hash docs?

If you want to copy options, you have to copy it on the full tag, as in @option (see #insert_cassette), without the name. Note that you cannot document parameters that are not in a method signature, so your use_cassette method needs an @overload.

Note that you cannot document parameters that are not in a method signature, so your use_cassette method needs an @overload.

Ah, this was the problem.  I had tried @option (see #insert_cassette) and it didn't work previously...once I changed the splat args to listed args the problem went away.  It didn't occur to me that the splat args would mess yard up.
Thanks for the help!


fix: use object syntax to define NuxtConfigScriptRegistry

🔗 Linked issue
fix #92

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
This PR moves NuxtConfigScriptRegistry to Object syntax to correctly loop over ScriptRegistry keys, avoiding it to merge values types when using Record

I'm not sure if this solves the issue. The problem can be seen here: https://unpkg.com/browse/<EMAIL_ADDRESS>(second line)
All of the type imports are being transformed to .js imports from the latest nuxt-module-builder which broke cross runtime types. We need to move the types to build time and import into runtime I believe

Good catch, looks to fix it :+1:


Centro Universitário do IDEAU

@marcelbrambatti-ideau First stage of verification passed, official domain is ideau.com.br as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@marcelbrambatti-ideau Thank you for your patience while waiting for a review and processing your request. Pull request merged.


send + sync support

Hi, trying to wire parts of this library into a tokio-based inference engine, I'm starting to bump into types that are not Sync / thread friendly, specifically types that are using Rc, and I'm locked out of changing this or supporting Sync with any sync primitives that I have from a library-user's point of view.
Any idea if there's something behind it that I'm missing to support thread safety and async use cases?

Which type ?
Could you share a reproducible example ?

Here:
https://github.com/huggingface/candle/blob/main/candle-nn/src/var_builder.rs#L15
luckily this is the only Rc usage in the repo as well.

Thanks!
Well, sharing a bit on what I'm doing -- I'm taking the examples and making them into a library. For example, I specifically needed bigcode support, and so I shaped the bigcode example into a simple library with two steps:

building a model
prompt completion

Where building a model, would be async, but done once, and prompt completion is async as well, running many times during a session.
The first thing I bumped into was that the model was mut, but not all parts in the example were mut. I gave up and tried to whole-sale just load the files, the varbuilder and hopefully build a new pipeline every time completion was requested -- which is where I got stuck with Rc.
There's a ton of value in the examples, I hope it by itself becomes a library. For that to happen there probably needs to be a deliberate thinking about what's mut and what's not, and to separate the two types of abstractions

Just to mention that the mut here is required because of the kv cache and the same applies to a bunch of transformers based models. Other models usually don't have this.
And yes it would be great to have the models moved from the examples directory to a lib, similar to the python transformers lib, that's the goal of candle-transformers but we first want to sketch a bunch of different examples so as to get a better sense of how we should architecture this lib.

Closing this for now, feel free to re-open if you have further questions or open a new issue. Note that we've started moving models to candle-transformers so hopefully the examples will be easier to re-use.

amazing, thanks!


Add image resolution checkbox and improve page layout

Added the checkbox as discussed earlier and labelled the color pickers. Also capitalized each box label. and changed the font to the default sans-serif.

@samuel-w Thanks for helping me with the development. I removed the made by proxtx and added a link to this repo so everyone can see you helped.


Rename plugin to mathjax?

This plugin is very mathjax specific.  Any reason not to call it mathjax instead of the more ambiguous math?

That was the first name I gave the plugin. Later, I decided to use more short one and renamed it. I absolutely don't mind to rename it. Moreover, I believe it will harmonize the plugin name with the names of other plugins we already have.
Thanks!

Done!


proposal for an audio-option "--only-audio-codec"

When faced with a very large collection of DVDs (say 500), I want to automate as much as possible. Right now, I can provide reasonable defaults and get DVDs to probably transcode to a result with good-enough settings. One thing that would be tremedously helpful though is if I could supply a --only-audio-codec-source AC3.
This would help in the numerous cases where a DTS and a Dolby AC3 audio track is present on the DVD. This way I could supply an --add-audio eng,deu and still make sure that the non-needed audio-codecs in the source won't get picked up.

another way to go would be an audio option --no-DTS

I tried to achieve my desired goal by using -H audio-copy-mask=aac,ac3,mp3 but I guess as transcode-video is already passing in the DTS source, there's no way to exlcude it with a handbrake option from the output alltogether...

@JMoVS Are your DVDs ripped to individual .mkv files or are they stored as disk image directories?

They are individual mkv files created with makemkv

@JMoVS OK, so you intentionally left the DTS tracks in there. Probably to be thorough, right? :) I was just curious.
This is a pretty geeky feature request and I really see it only being useful when transcoding DVDs and not Blu-ray Discs. But maybe we can make this work.
Perhaps it's better to design the API to exclude specific formats instead of only including others? Maybe something like this?
    --exclude-audio-format FORMAT

... where the format string is dts, ac3, etc. And it could be called multiple times.

@donmelton Yes, being thorough just in case. ;-)
I have so far no experience with transcoding Blue-Rays, so I'll take your word for it.
Your proposal sounds solid, although I think it's easier to do something like --exclude-audio-format FORMAT[,FORMAT] as in one can provide a comma-separated list akin to existing audio options and thereby could potentially mention more than one. Whatever is easier to implement.

@JMoVS Yeah, I can probably make it a list. It's a little more work to parse up front but the implementation would be the same in the core.

@donmelton I guess as the use-case is very very narrow, if the implementation of calling ot more than once is easier, then go for that. ;-)

@JMoVS This is turning out to be much harder to implement than I thought do the rather narrow-focus of and optimizations within my audio code. And it's likely to take a significant re-architecture to complete. And that has me worried since it will take a lot of testing to make sure I don't break anything.
So, it's not looking like it will go into the release next week. Sorry about that.

@donmelton M yline of thought here is that both from a workflow and a logical point of view, it could make sense to only call this option as the very last audio option.

Choose and add audio
Now remove unwanted codecs

This to mee seems implementation-wise easier. If you store the current audio selection some sort of list/array, later callingf this option could maybe simply remove the eg. DTS audio tracks from said Array before it gets passed into handbrake.

@JMoVS Yes, but what happens if the user places the --exclude-audio-format option first?
I'm starting to think that semantically this option does not make sense. For example, my API allows specifying the main track and adding other tracks by their index number. What if one of these very specifically identified tracks is then excluded? Which option wins? By order on the command line? And which track would then become the main track?
BTW, the tracks are already stored in an array. That's not the hard part. No, the hard part is fitting the exclusion into all the other special cases in the prepare_audio method. You can't just do it at the end.

SHAME ON THE USER!
Kidding aside, I think that this is indeed a problem. Maybe going back to my original suggestion, I thi k this would be more in line with current strategy and also wouldn't give you the "what wins when" thing. A user could supply a --only-source-audio-with-codec AC3,stereo and then would achieve the same result but wouldn't have this strange excluding behaviour.

This would also have the nice benefit that thisnexact pattern could also be used with a "noDTS" option supplied. But it's still a thing on what to include and not exclude. and that's how I saw the already existing options.

@JMoVS But an option and argument like --only-source-audio-with-codec AC3,stereo would raise all the same issues. It's just exclusion by another name.
However, looking at things more closely, the current implementation does allow the last conflicting option to "win" so maybe this is possible. But it's going to take me awhile to settle on the semantics exactly.

@donmelton Well, that's correct. My mental model is sort of different with the --only-source..., as this suggests to me that this is the very first option that is used when looking at audio-tracks and only the remainings of that will be used. That also seems to help with a lot of conflicts where eventually, the user can reasonably be blamed.

 :)
First, regarding the order of options problem. After much study of the existing code (you wouldn't thinks this is hard since I wrote it, but ...:) the only way to implement this feature is to do the exclusion right before actual audio processing and not earlier during argument parsing. In fact, it's not even possible during argument parsing since the input media hasn't even been scanned. This means the exclusion option will override all other audio selection options no matter their order on the command line.
Second, regarding audio format specification. It turns out that HandBrake's nice, clean list of audio output format specifiers, i.e. aac, ac3, eac3, truehd, dts, dtshd, mp3, vorbis, flac and opus, don't map very well to the names returned by scanning the input. For example, there's at least three kinds of DTS-HD out there. This is because "libav" is doing most, but not all, of the actual work of parsing the tracks. I'm not even sure yet if the names are consistent across media types.
So, I starting to think this option, if I implement it all, might be reduced in scope to just --exclude-dts since that's what you wanted in the first place. :)
Thoughts?

@donmelton Well, it turns out that I imagined some sort of "before you handle audio at all, pls just exclude DTS".
So I am not sure whether I fully understand it. So let's maybe go through some edge cases:
Case 1: DVD has Dolby and DTS track in my language
In this case, if I remember past conversations with you correctly, it doesn't make much sense to include the DTS track. So an option to automatically choose the Dolby track when it comes to the question "What surround track shall I include" would be nice.
Case 2: DVD only has a DTS surround track in my language (no Dolby)
In this case, I guess it's better to include the DTS track as the surround  sound. So excluding DTS at the very beginning seems like it's not helping in this very edgy corner case.
Case 3: Audio setups in Blue-Rays
I have no personal experience with Blue-Ray Audio formats and what to use and what not to use. So that's for you to imagine the edge cases. ;-)

@JMoVS OK, let's talk about your edge cases:
For your first case, yes, including DTS in output isn't a good idea since playback compatibility can be reduced significantly, especially on Apple devices. (And, yes, I've said this for years. :) However, "automatically" choosing the AC-3 track is not possible because how would transcoder-video know which AC-3 track to select? Just because a video contains DTS and AC-3 tracks, even if they're in the same language and channel configuration, doesn't mean they contain the same audio. The only solution is exclusion by format but that turns out to be a blunt instrument, because...
...of your second case. And there's likely many discs in that configuration. Maybe not so "edge" after all, either. So, it seems to me that this option, if I implement it, could only be used selectively. Probably by inspecting each video first. And if a user is going to that trouble up front, they can simply select audio by track index instead and achieve the same result. We don't need a new API to confuse them.
As for Blu-ray Discs, no one has asked me about format exclusion yet. In fact, most of the requests I get are about supporting TrueHD and DTS-HD, meaning those folks want to include the original audio or even transcode to those formats. Which is a really foolish idea but, hey, it's also why I implemented the --copy-audio option to keep them quiet for now. :)
Anyway, I'm less inclined to implement this feature. Mostly because now I don't think it's really any more convenient than selecting by track index. It just doesn't seem worth the complication at this point.

Hmm. Edge case 1 for me always was "same audio track in both formats on this DVD". Never had anything different. So for me, even if this isn't the case, the vast majority of disks are that way. Would improve my defaults and reduce manual handling need a Lot. To be honest, edge case 1 would be the primary use case for me (as audio tracks all were identical in the past for me).
About the second edge case: It is a theoretical one - I never stumbled upon it. Neither on old DVDs (like from 2000) nor today's DVDs. So I am not really concerned about edge case 2. If I catch 1 disk with edge case 2 out of 300, that's fine.
As explained, for me they are edge cases to consider. But I have yet to stumble upon a DVD that only contains a DTS track and NOT contain an AC3 track.
So your proposed 'exclude-DTS' option sounds super awesome for me as it would catch like 99% of my cases perfectly. ;-)


Deleted submittal button from Report and ACC pages.

Deleted splitter from Report and ACC pages.
Cleaned up unused code.

Sorry about that, I guess it just slipped my mind!


restore dynamic directory embedding

@jridgewell works locally in nextpack, will see if I can enable it by default

No, I mean instead of having dynamic_embed_contents, we should change it to static_embed_contents. We wouldn't need a default feature that way, and we could still pass --features static_embed_contents for the test builds

No, I mean instead of having dynamic_embed_contents, we should change it to static_embed_contents. We wouldn't need a default feature that way, and we could still pass --features static_embed_contents for the test builds

the release builds would need to static embed


Import Plant Ontology

Please add PO to import chain

doesn't seem to import in Protege

reload import, seems ok now


Copilot Studio isn't deleted from environment but tfstate confirms it does

Describe the bug
When removing a copilot studio bot resource, it's not getting deleted from the target Power Platform environment, even the tfstate says so.
To Reproduce
Steps to reproduce the behavior:

Add the following resource
Then remove it
tfstate confirms removal
Resource isn't deleted from target Power Platform environment (confirmed through real time OData endpoint call)

Sample Terraform Code
resource "powerplatform_data_record" "sample_bot" {   environment_id     = powerplatform_environment.dev.id   table_logical_name = "bot"   columns = {     name = var.copilot_name // e.g. test01     schemaname = var.copilot_schemaname // e.g. new_test01     template = var.copilot_template_version // default-2.1.0   } }
If applicable, add terraform code to help explain your problem.
Expected behaviour
A clear and concise description of what you expected to happen.

When this bot resource is removed (commented out).
tf state confirms its removal
The resource actually gets removed from the target environment (which it doesn't).

System Information

Provider Version: [2.7.0-preview]
OS & Version: [Windows]

Additional context
When creating a Copilot Studio bot, it creates several records across multiple tables

1 x bot for the Copilot record
n x botcomponent for topics, global variables etc.

I speculate it the botcomponent records would prevent the deletion of the bot records due to referential integrity.
Contribution
Do you plan to raise a PR to address this issue?  YES

thunder-collection_Create Bot (template).json


Create version-downgrade-prevention.md

Hi Roland,
Please take a second to sign the CLA (even though you are Mendix internal).
Thanks.


[Dynamic Shape] Add Properties to PassBase

This is part of refactoring the core passes to support dynamic shapes, we are adding properties to passes where each pass can specify which features it supports.

Added a new utility class EnumMask to make working with enum properties easier.

As the first pass, I'm not removing any old code yet. Want to make sure everyone is OK with how we set and query the pass property.

LGTM :)

@louisfeng let me know if I my understanding is right we can set passmanger property when we explicitly register the pass.
pass_manager.register_pass<runtime::cpu::pass::CPUFusion>(pass::REGULAR_FUSIONS | REQUIRE_STATIC_SHAPE); then inside inside match_node() of the matcher we can put additional check whether is_dynamic() violates get_property() and abort if necessary ?

The way I plan it to be used is each pass's constructor will set the property flags based on its features/requirements. Then in the PassManager during pass execution, it will check Function's dynamic state and compare against each pass's property to make sure the right passes are ran.

additionally, each pass can have  many function registered. if we refactor the passes like
 if (fusions & ngraph::pass::DIFFERENTIABLE_FUSIONS)
        {
            construct_conv_bias(); // DEPRECATED - Use CoreFusion
            construct_sigmoid_multiply();
        }

        if (fusions & ngraph::pass::REGULAR_FUSIONS)
        {
            construct_matmul();
            construct_matmulbias();
            construct_fprop_bn();
            .......

here based on the pass manager state , we should be good

additionally, each pass can have many function registered. if we refactor the passes like
 if (fusions & ngraph::pass::DIFFERENTIABLE_FUSIONS)
        {
            construct_conv_bias(); // DEPRECATED - Use CoreFusion
            construct_sigmoid_multiply();
        }

        if (fusions & ngraph::pass::REGULAR_FUSIONS)
        {
            construct_matmul();
            construct_matmulbias();
            construct_fprop_bn();
            .......

here based on the pass manager state , we should be good

Yes, I have added similar property to Matcher class. During construction of Matcher we also set these properties. We also need to add logic in the matcher run_on_function() method.


worldToMiniMap should be named localToMiniMap

In the Perspective class, the method worldToMiniMap should be renamed to localToMiniMap as the method requires a local x and y coordinate. The injected client will need to be updated to reflect this change.

Fixed by #4577


[Bug] Title "Pod 4.1.X" to "Pod 4.1.1"

Hi,
There is an issue on a page title that sets the title to Pod 4.1.X. It would be better if we can change it to Pod 4.1.1 or Pod 4.1.1 :  Arch Eagle

@gavishpoddar This is already being managed by @Devansh3712 here https://github.com/MLH-Fellowship/pod-4.1.1-portfolio/pull/18

I didn't saw that. Notes taken :)
Thanks @khattakdev


feat: Improve rg and highlight pattern matching

Use \b to narrow down ripgrep results
Highlight only keywords inside comments

This looks great!  I won't have time till later today to test this.

Good point. Then probably also add the other one like this:
search = {
    pattern = "...", -- ripgrep search pattern
}

I'll add in the rg default args there later so definitely useful to have it as a group under options too

Thanks again for this PR. I've merged it in and made some additional changes to the default patterns and make sure it never uses the comment string for the quickfix buffers


80 test driver app chat camera support

before you merge, please test on IOS if everything builds properly

without npm start and expo we can't show ios support on the demo day, since apk can't be installed on ios.

It is possible to run react-native run-ios, but I cannot test this because I don't have an iOS env

Cannot be merged into master because it breaks iOS/Expo build.


More types, fix some tsc errors

Purpose
Errors are bad, let's get rid of them
Summary of Changes

Removes / combines auth mixins
Adds type declarations for ember-simple-auth and ember-cli-meta-tags
Adds private methods to base osf-adapter
Use public routing service for beforeModel

Side Effects / Testing Notes
Ticket
https://openscience.atlassian.net/browse/EMB-
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Coverage increased (+0.07%) to 48.285% when pulling a6b5d5b4cd192bf0d5415925ae1dc315a11b19d2 on binoculars:feature/ts-auth into 25ec78404ad2971908a4f98357095dc9c07df737 on CenterForOpenScience:develop.


refactor(FileSystemInfo): reduce duplication around finding a managed item

What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
n/a
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing

This only safes 1 LOC, but adds an additional runtime check for the return value. For performance reasons I will not merge it.


Regular logged-in users access to hooks IDs

Use Case: Using Portainer in a demo/test setup.
Have you reviewed our technical documentation and knowledge base? Yes
Question:
Hello, is there a way for regular logged-in users to see the hooks (services/stacks)? Currently only admin user can access this information. May be in the Business edition?

@VirgileD
Within Business Edition:
[1] Standard Users can create Stacks and enable Webhooks.
[2] The Environment Administrators can toggle the Webhook after creation.
[3] If you want a User to edit a Webhook, they have to be in the Environment Administrator role.
Thanks!

Hello Tamara, Tx for your fast answer!
I'm not sure though, a standard user can enable and see the hook when she/he creates the stack, right? Or does she/he needs to ask an administrator for the hook to be visible?
what about services' hooks, is it the same?
tx again for your time.


Longest-Match Router

This patch replaces the embedded gorrila/mux router with a new Longest Match router.  The LM Router is made for high-performance proxies in that it only uses basic string prefix matching, with no path parameter parsing or use of regular expressions. The router auto-sorts the paths from longest to shortest each time a route is registered, thus the sorting logic previously needed to work with Gorilla has been removed from /pkg/routing/routing.go.  For routers that don't care about host header or path prefix matching (e.g., the pprof router), those mechanisms can be disabled on the router itself for optimal performance.
Key Files:

./pkg/routing/routing.go
./pkg/router/router.go
./pkg/router/lm/lm.go

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

175 of 263 (66.54%)  changed or added relevant lines in 12 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage increased (+1.1%) to 90.065%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/proxy/handlers/rpc/rpc.go
0
1
0.0%

pkg/proxy/handlers/clickhouse/clickhouse.go
0
2
0.0%

pkg/proxy/handlers/influxdb/influxdb.go
0
2
0.0%

pkg/proxy/handlers/prometheus/prometheus.go
0
2
0.0%

pkg/proxy/handlers/purge.go
0
8
0.0%

pkg/httpserver/httpserver.go
0
16
0.0%

pkg/httpserver/listeners.go
0
23
0.0%

pkg/router/lm/lm.go
119
153
77.78%

Files with Coverage Reduction
New Missed Lines
%

pkg/cache/filesystem/filesystem.go
3
97.93%

pkg/cache/bbolt/bbolt.go
4
88.55%

Totals

Change from base Build<PHONE_NUMBER>:
1.1%

Covered Lines:
17188

Relevant Lines:
19084

💛  - Coveralls


fix #1777, Dynamic DAG failed after changing parallelism for many times

For review only, please don't merge it for now.

@manuzhang
Please make a quick test to see whether this fix #1777.


Create additional examples of overlay implementation.

Any Overlays

[ ] Demonstrate how to add overlays to mods you do not have the ability to edit.

Texture Overlays

[x] Demonstrate a simple texture based overlay. @Data.Sample.Sunglasses

Interface Overlays

[ ] Demonstrate overlays that react to papyrus events. For example, show certain elements of the overlay while in combat, and hide those elements at other times.
[ ] Demonstrate how to populate text fields with papyrus.
[ ] Demonstrate how to create animations with motion tweens and control them with papyrus.
[ ] Demonstrate the various visual effects and display filters.
[ ] Demonstrate overlays that manipulate vanilla HUD elements.
[ ] Demonstrate how a display meter might be created.

@BlahBlahDEEBlahBlah said..

I’d watch a video on how to make an overlay of a screen monitor so that what you would normally see looks as if looking at a monitor from within a vehicle, perhaps an APC. :wink:

I have decided to create a script aware example for the Scouter Mod. I am also considering WestTek for an example.

I am also considering WestTek for an example.

@NovaFinch is trying to bait me into making an ODST style health meter replacer. :100:

There is also the ye'olde bouncy ball for player input I made for another project. Look in the lower left corner of this video. The little grey ball would make a fine example.
https://youtu.be/An_1koqa62U

The full features I wanted in the scouter mod are:
On Enemy rollover (in crosshairs):
Display enemy name, level and health.
Enemy not in crosshairs:
Display "scanning" with animated trailing dots "..."
Also a text field that display random alphanumeric string, animated (so like, switching between 3 or 4 strings to look like some bit of code).
Displayed all the time:
Player health.
Player AP.
Compass.
Displayed when gun is out:
Ammo count and type.
Equipped weapon.
That's the overall idea for the moment, but will also tie in globals controlled by an mcm so users can toggle features on and off.
Thinking of it as a sort of HUD replacement for people who hide HUD elements normally, but with options to turn off features for people who still use vanilla hud (dont need two compasses for eg).
Not sure how far you want to roll with it, I'm happy to implement all the different bits and pieces just need something to start with that I can pick apart and work out how it is all out together.
Thanks for all your help with this man


improve typescript declaration files

fix #60

I have to bump @types/react from v15 to v16 due to breaking changes.
When using node_modules depending on @types/react with mixed major versions then you get compile errors like DefinitelyTyped/DefinitelyTyped#21242.

Hi @thomschke, is the file exactly the same with index.d.ts? I'm a typescript n00b and curious that can we reuse or reference to that existing file? So, we don't to maintain two files with have the same code.

Hi @supasate, DRY version is up.

I revert this because it may affect people who use React 15.x. I'll merge this when we have a major upgrade.

I understand.
A lot of other projects define a wildcard version (@types/react: "*") to prevent this compile problems.

@thomschke you can submit a new PR by using the wildcard if it helps.


Shifts logic from hx711_cycle into data gathering loop.

Changes function hx711_cycle to be inline and not returning a value.

In total removes calls to hx711_cycle from data gathering loop. Just when its needed to set gain (and channel) its also marked as inline.
As hx711_cycle is not needed to return data, those lines are removed as well.

Roger That


How can I continue to download with incremental mode

My download interupted because of disk full, when I remove the exists files, and use --incremental to restart download, it seems began from the very beginning, can I creat some 1k ‘XXX.tar’ to pretend there are files? Or is there any way to solve the problem？ Thanks!

Shards that have the NNNNN_stats.json file are finished and img2dataset does not attempt to redownload those shards again. If you migrate the actual data (.tar and .parquet files) somewhere else, keep the stats file and img2dataset will continue from where you left. Webdataset tarballs that are incomplete will need to be downloaded again. I don't believe there is an easy way to avoid that.

That's correct


[Autocomplete] Module build failed @symfony/ux-autocomplete/package.json" could not be found

Getting this error when I try to build/watch:
edu@education:~/work/test-project$ npm run watch

> watch
> encore dev --watch

Running webpack ...

 ERROR  Failed to compile with 1 errors                                                                                1:15:50 PM

 error  in ./assets/controllers.json                                                                                1:15:50 PM

Module build failed (from ./node_modules/@symfony/stimulus-bridge/dist/webpack/loader.js):
Error: The file<EMAIL_ADDRESS>could not be found. Try running "yarn install --force".
    at createControllersModule (/home/edu/work/test-project/node_modules/@symfony/stimulus-bridge/dist/webpack/loader.js:46:19)
    at Object.loader (/home/edu/work/test-project/node_modules/@symfony/stimulus-bridge/dist/webpack/loader.js:106:43)

Entrypoint app [big] 676 KiB = runtime.js 14.6 KiB vendors-node_modules_symfony_stimulus-bridge_dist_index_js-node_modules_core-js_modules_es_da-03e5c3.js 639 KiB app.js 22.3 KiB
webpack compiled with 1 error

Installed Symfony 6.3 like shown here: https://symfony.com/doc/current/setup.html
Installed encore like shown here: https://symfony.com/doc/current/frontend/encore/installation.html
Installed stimulus like shown here: https://symfony.com/bundles/StimulusBundle/current/index.html#manual-installation-details
Installed autocomplete: https://symfony.com/bundles/ux-autocomplete/current/index.html
and at this point I run into the problem.
Minimum project to reproduce: https://github.com/henryfoster/test-project
Tried to reinstall everything
Tried to clear cache
Tried to delete and reinstall node_modules

Arf i' sorry you're right, i've been too happy too soon :)
I know there is something between bundle/bridge but cannot remember. You may want to ask on slack or maybe digg a bit previous issues, i'm certain this has already happened..
... sorry to not help you more :/


Required dependents is incorrect

This line
> Reference navigations to owned entity types cannot be null unless they are explicitly mapped to a separate table from the owner

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d02e6748-42e0-000a-4945-42cd05a0b875
Version Independent ID: e3effbd0-07f2-423d-4032-1722e75adb37
Content: Owned Entity Types - EF Core
Content Source: entity-framework/core/modeling/owned-entities.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @AndriySvyryd
Microsoft Alias: ansvyryd

Also, you should put an example with the nullable constraints activated (https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/builtin-types/nullable-reference-types). A good example/caveat is when you have an entity that all his property are null, the value return by EFCore is a null value, not an empty object so the type of the property (that use an owned entity type) should be nullable, but when all or one of the property are required then the type of the property should not be nullable.


[Storage] [DataMovement] Fix to resolve The using directive for BaseShares Models appeared previously in this namespace

Fix to resolve The using directive for BaseShares Models appeared previously in this namespace
will convert to regular PR when CI passes, since this issue only appears in CI.

API change check
API changes are not detected in this pull request.


Hitomezashi Stitch Patterns

Create a program that can generate Hitomezashi stitch patterns.

Create a grid of points
Create labels for each axis with either 0 or 1 for each row/column
For each row and column, if 0, draw lines from every other point starting from the beginning
For each row and column, if 1, draw lines from every other point offset by 1 from the beginning
The resulting pattern is a Hitomezashi stitch pattern

Feature has been added successfully


[Quest/eCBIS] Remove a Family member represented in the  Group Resource.

Name of feature to enhance

Family representation

Description of feature

We currently use the Head of family patient resource to represent a family
We are moving this to use the Group resource.

Describe the enhancement

[x] The individual Patient profile will have a Remove Person menu. By clicking this menu a form should be launched to remove the person.
[x] If the person is a family head then do the following

[x] Remove the RelatedPerson reference on the managingEntity attribute on the Group resource representing the family
[x] Remove the Patient reference on the members attribute on the Group resource representing the family
[x] Update the RelatedPerson resource and set the active attribute to false
[x] Update the Patient resource and set the active attribute to false
[x] NB :- We will not be selecting a new family head at this point.

[x] If the person is a normal family member then do the following

[x] Remove the Patient reference on the members attribute on the Group resource representing the family
[x] Update the Patient resource and set the active attribute to false

Depends on  -- https://github.com/opensrp/fhircore/issues/1202

Can be done concurrently

@dubdabasoduba
Code breakdown:

[ ] Implement overflow in PatientProfileScreen
[ ] Add action for remove person in patient profile PatientProfileScreen
[ ] Implement functionality for launching the RemoveFamilyQuestionnaireActivity (available in FamilyProfileViewModel)
[ ] Add logic for remove patient loaded from family/individual member

Closed by #1235 and #1236


[Event Request] Codeunit 5057 VendCont-Update - OnAfterTransferFieldsFromVendToCont

Can an event please be added to codeunit 5057 - VendCont-Update
Event Signature:
LOCAL [IntegrationEvent] OnAfterTransferFieldsFromVendToCont(VAR Contact : Record Contact;Vendor : Record Vendor)
Insert code as identified below

Okay, just confirmed, and closing the issue


panic: runtime error: invalid memory address or nil pointer dereference

Indeed similar to #55 but I'm super confused as to what I'm doing wrong here, since as far as I can see I'm doing everything as normal.
Code is here: https://play.golang.org/p/vKbxsbNLSa9
I get the following error:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x132cb6a]

goroutine 1 [running]:
github.com/turnage/graw/reddit.(*appClient).authorize(0xc0000d0090, 0xc0000d0090, 0xc0001040b4)
	/Users/joseph/go/src/github.com/turnage/graw/reddit/appclient.go:59 +0x24a
github.com/turnage/graw/reddit.newAppClient(0xc00010600d, 0x2a, 0xc000106045, 0xf, 0xc000106066, 0x1b, 0xc00010608e, 0xa, 0xc0001060a5, 0xd, ...)
	/Users/joseph/go/src/github.com/turnage/graw/reddit/appclient.go:79 +0xff
github.com/turnage/graw/reddit.newClient(0xc00010600d, 0x2a, 0xc000106045, 0xf, 0xc000106066, 0x1b, 0xc00010608e, 0xa, 0xc0001060a5, 0xd, ...)
	/Users/joseph/go/src/github.com/turnage/graw/reddit/client.go:79 +0x15a
github.com/turnage/graw/reddit.NewBot(0xc00010600d, 0x2a, 0xc000106045, 0xf, 0xc000106066, 0x1b, 0xc00010608e, 0xa, 0xc0001060a5, 0xd, ...)
	/Users/joseph/go/src/github.com/turnage/graw/reddit/bot.go:38 +0xba
github.com/turnage/graw/reddit.NewBotFromAgentFile(0x13f7db3, 0xd, 0x0, 0xc000044e88, 0xa3d9af05b49f4c1d, 0x10, 0x13715e0)
	/Users/joseph/go/src/github.com/turnage/graw/reddit/bot.go:64 +0x156
main.main()
	/Users/joseph/golang-reddit/main.go:8 +0x54
exit status 2

Which seems to point back to it being an error in NewBotFromAgentFile but I'm not sure what I've done wrong.

Fixed in #61


Update bug-template.yaml

@penalosa just for posterity, can you pls provide some context as to why we're making these changes 🙏 ?


refactor: rename the template files

rename scripts directory to templates
rename the files to completion.${ext}

conflict


On initial load safari browser is giving errors

Environment
2.15.8
Reproduction
2.15.8
Describe the bug
In my Nuxt js app on production server i am getting issue with safari browser both on desktop and mobile view on initial load. i am using Nuxt version 2.15.8. On initial load safari browser is giving errors and not applying search on button click and returning these errors (see log) . When refresh the page it works fine, but not on the initial load.
Additional context
No response
Logs
SyntaxError: Unexpected identifier 'lValue'. Expected an opening '(' before a function's parameter list
SyntaxError: Unexpected identifier 'y'. Expected an opening '(' before a function's parameter list.

Likely some library you are using needs to be transpiled because its code is too modern for Safari. You can do this by adding it to build.transpile.

HI @danielroe i have added build.transpile in nuxt.config file. But it is still giving error on initial load. when i do hard refresh it worked.
build: {
    transpile: [
      'defu'
    ],
}

I am also facing the same issue on node version of 16.20.0 and nuxt version 2.17.0. It is creating issue with my production website which is causing issue to the customers to login or apply search after initial load.


Fix bug when generic builder is rebuilt

When an existing generated class is rebuilt without cleaning, javac will pick up the old .class file, and references to the generated type will not be ERRORs. This was triggering a bug in Analyser.IsSubclassOfGeneratedTypeVisitor when the generated type is generic.
This fixes issue #111.

:+1:


WARN - SQLCipher 3.x - 4.x compatible problem

Today(2018.12.25), I tested to compile sqlcipher on windows. but I found some incompatibility with old version( or my misunderstand.).

anyway, I opened this issue to figure out that reason.

https://github.com/sqlcipher/sqlcipher/blob/master/CHANGELOG.md

test log on windows.
# scoop install msys
# mingw64
# pacman -Syu

# pacman -S mingw32/mingw-w64-i686-gcc
# pacman -S base-devel
# pacman -S tcl

# https://slproweb.com/products/Win32OpenSSL.html
# Win64 OpenSSL v1.0.2q # C:\OpenSSL-Win64 - check The OpenSSL binaries (/bin) directory
# Win32 OpenSSL v1.0.2q # C:\OpenSSL-Win32 - check The OpenSSL binaries (/bin) directory

  git clone https://github.com/sqlcipher/sqlcipher sqlcipher64
  git log
 commit 27d58453c6e56c3dd85e02bca379161bc69c746a (HEAD -> master, tag: v4.0.1, origin/prerelease, origin/master, origin/HEAD)

  cp /c/OpenSSL-Win64/bin/libeay32.dll ./
  ./configure --with-crypto-lib=none --disable-tcl CFLAGS="-DSQLITE_HAS_CODEC -DSQLCIPHER_CRYPTO_OPENSSL -I/c/OpenSSL-Win64/include /c/OpenSSL-Win64/bin/libeay32.dll -L/c/myHome/prj/hello/sqlcipher64 -static-libgcc" LDFLAGS="-leay32"
  make clean
  make sqlite3.c
  make
  make dll

https://github.com/netpyoung/SqlCipher4Unity3D/tree/master/testing_new_win64dll

I found the reason of that https://www.zetetic.net/blog/2018/11/30/sqlcipher-400-release/
from sqlcipher 4.x, some option of database was changed.
Now SqlCipher4Unity3D using sqlcipher 3.x.
Until now It's works. But there are some issue on future(ex, bugfix or something...)

Until now SqlCipher4Unity3D looks like stable and using some productions.
So, I will holding current version of sqlcipher on 3.x
But, For the future It is need to prepare to moving 4.x easily.

for compile tag: v4.1.0, on x64 windows, It need to change on configure file.
for ac_option in --version -v -V -qversion; do

to
for ac_option in --version -v; do

because gcc doesn't have -V and -qversion options.

https://www.zetetic.net/blog/2018/12/18/sqlcipher-401-release/
PRAGMA cipher_compatibility = 3;.

close - duplicate with #25


Edit publisher allowances

Currently we do not have an option to edit the allowance of a publisher.
This could be a full publisher edit page?

we now got an edit-modal which currently allows to edit the budget.


add scrollEnable info to documentation

I was struggling a log why my content is not scrollable when switched to WKWebview plugin, it turned out that it has to be set manually in config.xml file by adding <preference name="ScrollEnabled" value="true" />
I googled this for several hours, stumbled upon Mark's article about this issue:
https://markandruth.co.uk/2017/09/15/using-ionics-wkwebview-engine-with-standard-cordovaphonegap-projects#comment-6365
Please add scrolling info into GitHub installation or FAQ page, so it will save devs couple of hours.
Thanks 🥇

I have added this tag to the config.xml and I'm still not able to scroll. Any other reason you might have?

For me the <preference ... solved the issue.
I think the main point of Ionic is that you have viewport of screen size and every component is handling scrolling events by its own (kind of what native app development feels like)
Since I am not heavy user of this framework, I could not help you on this one.

:tada: This issue has been resolved in version 4.1.2 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Feature: Support average time to review

Concept
Params -> Options -> CalcuateTimeToReview (median/average)

Hi @eduardoacskimlinks sorry for the late reply.
Average is easily affected by outliers, therefore leading to inaccurate results (ie. a single forgotten PR for review can impact a lot on someone's consistency). Time to reviews are usually skewed values and for that kind of values median is preferred.


[ MB-11716 ] Update server debugging

This will be updated once this has left the Draft state.
<!---

## [Jira ticket](tbd) for this change

## Summary

Is there anything you would like reviewers to give additional scrutiny?

[this article](tbd) explains more about the approach used.

## Setup to Run Your Code

<details>
💻 You will need to use three separate terminals to test this locally.

##### Terminal 1

Start the Storybook locally.

```sh
make storybook
```

##### Terminal 2

Start the UI locally.

```sh
make client_run
```

##### Terminal 3

Start the Go server locally.

```sh
make server_run
```

### Additional steps

<!-- Fill out the next section as you see fit, these are just suggestions.

1. Access the
2. Login as a
3.

## Verification Steps for Author

These are to be checked by the author.

- [ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
- [ ] Request review from a member of a different team.
- [ ] Have the Jira acceptance criteria been met for this change?

## Verification Steps for Reviewers

These are to be checked by a reviewer.

<!-- Fill out the next sections as you see fit, these are just suggestions.

### Frontend

- [ ] User facing changes have been reviewed by design.
- [ ] There are no aXe warnings for UI.
- [ ] This works in [Supported Browsers and their phone views](https://github.com/transcom/mymove/tree/master/docs/adr/0016-Browser-Support.md) (Chrome, Firefox, IE, Edge).
- [ ] There are no new console errors in the browser devtools
- [ ] There are no new console errors in the test output
- [ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the `officeApp` class or custom `min-width` styling is used to hide any states the would not be visible to the user.

### Backend

- [ ] Code follows the guidelines for [Logging](https://transcom.github.io/mymove-docs/docs/dev/contributing/backend/Backend-Programming-Guide#logging)
- [ ] The requirements listed in [Querying the Database Safely](https://transcom.github.io/mymove-docs/docs/dev/contributing/backend/Backend-Programming-Guide/#querying-the-database-safely) have been satisfied.

### Database

#### Any new migrations/schema changes:

- [ ] Follows our guidelines for [Zero-Downtime Deploys](https://transcom.github.io/mymove-docs/docs/dev/contributing/database/Database-Migrations#zero-downtime-migrations)
- [ ] Have been communicated to #g-database
- [ ] Secure migrations have been tested following the instructions in our [docs](https://transcom.github.io/mymove-docs/docs/dev/contributing/database/Database-Migrations#secure-migrations)

## Screenshots

Messages

:book:
:link: MB-11716

  Generated by :no_entry_sign: dangerJS against 2e7e95e72155655cb6509fad3e913f933321f624

I'm removing this PR as I've successfully used Delve without needing to run anything in the Makefile. I've also done some light research on this and interviewed a couple of Trussels to see how they debug code, and found that most folks use their editor without thinking about doing this on the command-line.
As I said in #8256, I think the Makefile is due for some cleaning up, and this command is in a similar spot.


Optimize code coverage collection

This marks which tests cargo-tarpaulin doesn't take kindly to, and adds quality of life script for collecting code coverage reports without polluting cached artifacts built by cargo test

Looks like it's traversing into target/**/* ?

Looks like it's traversing into target/**/* ?

:facepalm: yeah, that is not a feature, thanks for catching this and I'll attempt to fix before day's end!


com.wordnik.swagger.model.ApiInfo has been deprecated

com.wordnik.swagger.model.ApiInfo has been deprecated and may need to be replaced by
com.wordnik.swagger.models.Info

@mrwanny This should be fixed in an upcoming release that supports swagger 2.0

Yes, I actually submit a merge request to the swagger 2.0 branch...
(some spec are failing in the project... but they are not related with the changes I made)
Please let me know if you have any feedback.

Fixed via refactoring


Entering bower search lists all packages which takes a while

Entering bower search with no entry causes bower to list all packages, this process takes a long time. As an alternative maybe bower should say no search was entered and then ask the user if they would like to list all packages instead of being hung up for about 10 seconds

Good idea, either that or bower should return nothing.

I think it is better to be explicit and let the user know their query failed because it needed more information. Alternatively, we could warn: This will list all (more than X) Bower packages, and will take a while. Continue? y/N

Actually there should be a threshold, like 100 to give that warning.

Any PR that improves this behaviour is welcome

Pull request #2074 resolves this issue

Hi guys!
Is there now a way to retrieve all bower packages using cli? It's a needed operation for WebStorm Bower integration. Previously, IDE just run bower search --json and parsed JSON output.

It turns out the implementation AND tests are wrong... We should display all packages when --json is passed.

I can work on fixing this today if no one else is.

Thank you for the fast respond. Yep, --json would be a good trigger. Meanwhile, bower search "" --json is used as a workaround. FYI, I think I observed several time some text prefix (like some debug output) before JSON body result. Unfortunately, it cannot be reproduced anymore.

Thank you for the quick turnaround!


Expose strerror and strerror_r

I'm refactoring some code of mine to use nix where possible but right now I can't get a string description for low-level errors. I used to use errno, but you can't do that easily with nix because once you have an Errno there's no way to get the underlying i32 and pass that to libc::strerror. Instead of supporting extracting this integer, it'd be useful having a safe wrapper around strerror. I'd be happy to do this since I already have code that does it, but I don't know where it should go or if this functionality is desired in nix. Should I add wrappers for strerror and strerror_r in a new /src/string.rs module?

You want a function strerror(Errno) -> SomeStringType? Sounds good to me. And it does belong in src/string.rs as you suggest.

So it looks like this behavior already exists in Errno::desc(). I've used it in my own library to make sure it works correctly, and it does, so I'll just use that instead. I don't see a good reason to expose strerror() or strerror_r() given that that functionality exists, but there should be a way for people trying to use those functions to find the Errno struct and related functionality.

once you have an Errno there's no way to get the underlying i32 and pass that to libc::strerror

You can do this via a cast: my_errno_value as i32. It may be nicer to provide a method, however.

I don't need this functionality anymore since discovering Errno::desc. Should I close this or leave it open as a TODO item?

We can convert it to a doc issue :-)

If you have a suggestion for how to document this, I can submit a PR for it. I just don't know where this should go.

@Susurrus maybe module level docs on nix::error?

Re https://github.com/nix-rust/nix/issues/545#issuecomment-284399321 would it be accepted to add impl From<i32> for Errno which I think is more ergonomic than a cast? This could possibly replace the from_i32() method as well.
Also, do you mean I should add docs to nix::errno? nix::error doesn't exist though the type nix::Error does.

Regarding this, is there any reason to have hard-coded error strings in nix versus uses strerror_r? I'm uncertain why we'd want to bloat the binary size and duplicate the descriptions by hard-coding them.


Throw a runtime error for registrations that occur after startup

Original issue: https://charm.cs.illinois.edu/redmine/issues/1514

This specifically comes up for templated entry methods that aren't explicitly instantiated in the ci file. If you forgot to instantiate a version of the templated entry method, the code still compiles and links fine but at runtime, the behavior is undefined and no errors are ever thrown. One quick fix for this behavior would be to at least throw an error if a new registration occurs after startup.

Original date: 2017-05-01 22:17:35

This issue doesn't happen on multicore version. Even without instantiation of template on ci files, the application is compelled, linked and executed on multicore version.
Investigating this issue.

Original date: 2017-05-01 22:57:18

I think that's just a symptom of the example program I gave you. The call to the entry method that wasn't instantiated was done in the main chare constructor, so it was still during startup. If you move that call to somewhere after startup completes then I suspect multicore will have the same problem.

Original date: 2017-05-10 07:40:21

~~https://charm.cs.illinois.edu/gerrit/#/c/2510/~~ https://github.com/UIUC-PPL/charm/commit/5b0dd6364ea32405c1a48ad5bafe5b2837a99714

Original date: 2017-05-10 20:55:31

After the initialization is done, the calling the templated entry method in an uninstantiated form leads to CkAbort. Probably this patch helps the issue resolved.