Common go library for API tools

The type "DatameshVolume" is spelt out in:

cmd/dm/pkg/remotes/api.go
cmd/datamesh-server/pkg/main/types.go
tests/testtools.go (doAddCollaborator)

...and VolumeName is likewise reproduced a lot.
We should make a library that can be used from everywhere that needs it.

This should be the same type of thing as https://github.com/dotmesh-io/python-sdk

first pass made in github.com/dotmesh-io/dotmesh/pkg/client :sparkles:


GUACAMOLE-406: Add documentation for event listener support

Documentation for event listener support squashed into a single commit with a merge base of staging/0.9.14.incubating

Hmmm...looks like there are some extra commits in here??

I'm not sure why we're seeing that.

Closing to change base for local branch, too.


replace deprecared push_all with extend

Where do you find a deprecation warning for push_all(). rustc 2015-03-14 does not complain about deprecation, and it's not showed as deprecated in the standard library documentation.

You are right, I got this warning after removing #![feature(collections)]
src/utils.rs:14:9: 14:22 warning: use of unstable library feature 'collections': likely to be replaced by a more optimized extend
src/utils.rs:14     dst.push_all(buf);
                        ^~~~~~~~~~~~~
src/utils.rs:14:22: 14:22 help: add #![feature(collections)] to the crate attributes to silence this warning

Now the pull request makes sense

As of now when benchmarking the performance still seems to be slightly better when using push_all().
push_all()
test crypto::secretbox::xsalsa20poly1305::bench::bench_seal_open                ... bench:    194737 ns/iter (+/- 6228)
extend()
test crypto::secretbox::xsalsa20poly1305::bench::bench_seal_open                ... bench:    213381 ns/iter (+/- 14673)
Because of that I think I'll hold back on merging the change until the more optimized extend() has landed.


The base url domain for registering new tenants.

Description of your feature
In current scenario before installing the package, we can access the home route , i.e. welcome page. This page is an entry point to the app. The space can be used to make a base registration page for tenants.

Proposed behavior
I am proposing that even after installing the package the normal behaviour of the app should remain same. The base URL(/) home page can be used as a registration page of welcome page for new onboarding users. The home route should not be overridden.
Current behavior
In current scenario, after installing the package we are given a 404 error for the home route. And we add the new tenants via commands or other means. We can access the app at the sub-domains only.
Information

hyn/multi-tenant version: 5.x
laravel version: 5.6.x

Please read the tenancy.php configuration and/or documentation to configure the package to your needs. The documentation calls this the fallback.
The 404 given is a configuration called abort-without-hostname, you can set it to false.
Please note that going through the configuration is highly recommended to make the package do what you need. It's a very flexible component that can be easily adjusted to do whatever you need.

Well, the fallback option is there. But in my application I want a feature to host the / route for the welcome page and a different fallback page for hostnames that are not found. However, I am unable to achieve this. Why the routes in my core laravel application's web.php is not working?

Are you able to do this?
Route::domain('domain.com')->group(function() {
});

$hostname = app(Hyn\Tenancy\Contracts\CurrentHostname::class);

if ($hostname) {
	Route::domain($hostname->fqdn)->group(function() {});
}


Add config option to not connect in the constructor

Hi,
Can we add a config option to the constructor so that it will not try to connect until manually calling .connect()?

Seems lazyConnect option should do the trick.

Does it work in Cluster mode as well? I want to do something like this:
var redis = new Redis.Cluster();

// then sometime later
redis.connect().then(() => ...)

hmm...It doesn't work in cluster mode. What's your use case?

I just want to have the redis instance created in the constructor of my own class, and then make sure it connects before using it.
We can just wrap this line: https://github.com/luin/ioredis/blob/master/lib/cluster/index.js#L83
in an if statement with lazyConnect no?

Yeah, should be pretty similar to the standalone version: https://github.com/luin/ioredis/blob/master/lib/redis.js#L126-L131

For me it also looks very strange that instantiation does some connections.
I like how it did in mongoose. You need to connect explicitly:
mongoose.connect('mongodb://localhost/myapp');
var MyModel = mongoose.model('Test', new Schema({ name: String }));
// Works
MyModel.findOne(function(error, result) { /* ... */ });

Yes, I can lazyConnect option, but anyway it looks like antipattern


Add .shadeX documentation to colors

Relates to https://github.com/flutter/flutter/issues/71591
Color documentation (e.g. https://api.flutter.dev/flutter/material/Colors/red-constant.html) should be updated to indicate that shades of color are available via .shadeX, e.g. Colors.red.shade100.
The generated diagrams for color shades should also be updated

Hi, @pedromassango I would like to solve this issue, can you please assign it to me?

Hi, @pedromassango I would like to solve this issue, can you please assign it to me?

Why this issue is opened even after it merged?


Doesn't work with generic associated types

Generic Associated types are stable for more than a year now:
https://blog.rust-lang.org/2022/10/28/gats-stabilization.html
#[auto_impl::auto_impl(&, Arc, Box)]
pub trait Trait {
    type Type<'a, T>: core::iter::Iterator<Item = T> + 'a;
}

Output
error[E0107]: missing generics for associated type `Trait::Type`
   --> main.rs:221:14
    |
221 |         type Type<'a, T>: core::iter::Iterator<Item = T> + 'a;
    |              ^^^^ expected 1 lifetime argument
    |
note: associated type defined here, with 1 lifetime parameter: `'a`
   --> main.rs:221:14
    |
221 |         type Type<'a, T>: core::iter::Iterator<Item = T> + 'a;
    |              ^^^^ --
help: add missing lifetime argument
    |
221 |         type Type<'b><'a, T>: core::iter::Iterator<Item = T> + 'a;

I'd be happy to look into this, but context switching into this library is a bit of a challenge. It should be pretty straightforward to support.


Release CI/CD pipeline

We need to create a release CI/CD pipeline for this project.
Use these documents as a reference:

How to release the first Eclipse version of projects
JSONP release job

Blocked by https://bugs.eclipse.org/bugs/show_bug.cgi?id=538893

Job: https://jenkins.eclipse.org/jaxws/job/jax-ws-api-release/7/console
tested with master and EE4J_8 branch.


RespondWithFileAsync(string file_path) causes an error.

Line that invokes the exception
Exception Text

Exception thrown: 'System.Net.Http.HttpRequestException' in mscorlib.dll ("Error while copying content to a stream.")

Issue starts on line 232 of DiscordMessage.  Passing my own FileStream into RespondWithFileAsync works just fine.

i think it because Position field of file stream not set to 0 before send here:
https://github.com/NaamloosDT/DSharpPlus/blob/master/DSharpPlus/DiscordRestClient.cs#L356
but i no have time now to fork, fix (maybe), test

I'd need to see the exact code.

Also the stream position is purposely not set to 0. You are expected to rewind the stream yourself.

This is fixed with e7e5bde.


easy_install documentation should promote (or mention) Pip

Originally reported by: hickford (Bitbucket: hickford, GitHub: hickford)

Pip is preferred to easy_install for several good reasons. Thus it's promoted by all the recent Python guides, and by Python itself now shipping with Pip.
Thus it might also make sense for the documentation at https://pythonhosted.org/setuptools/easy_install.html to encourage users to Pip. At the least, it should mention Pip and give a link to it.

Bitbucket: https://bitbucket.org/pypa/setuptools/issue/318

I believe this is done in f4b320e5e3ec9c7e1ef4b90017050e029029d449


Providing jmod format download

Hi:
Recently Java release jmod format, so is it possible to provide jmod format release version along with jar format?
If so, we could use jlink to integrate lwjgl3.jmod into customized jre
like JavaFX which provides jmod format download

Hey @chengenzhao,
You don't need dependencies in jmod format to use jlink, normal jars work just fine. The only prerequisite is that all dependencies must be explicit modules (i.e. include module-info.class, simply adding an Automatic-Module-Name in the manifest is not enough).

Hey @chengenzhao,
You don't need dependencies in jmod format to use jlink, normal jars work just fine. The only prerequisite is that all dependencies must be explicit modules (i.e. include module-info.class, simply adding an Automatic-Module-Name in the manifest is not enough).

Thanks for reply, so basically we need to add module-info.class manually, and then use jlink to link this modified jar to generate jre right?
It looks feasible but if we could add module-info.class in the native jar, would it be more convenient for users?

I believe it's already in there, check the META-INF/versions/9 folder.

I believe it's already in there, check the META-INF/versions/9 folder.

found it, cool, thanks

Since LWJGL 3.1.4 artifacts are jlink-able without any changes. module-info.class was moved into META-INF/versions/9 in 3.1.6 for compatibility with older software that tried to parse it and failed.

Since LWJGL 3.1.4 artifacts are jlink-able without any changes. module-info.class was moved into META-INF/versions/9 in 3.1.6 for compatibility with older software that tried to parse it and failed.

thanks a lot, test it successfully


Deploy calico failed when use cri-o runtime

https://github.com/kubernetes-incubator/kubespray/blob/master/roles/network_plugin/calico/tasks/install.yml#L38
https://github.com/kubernetes-incubator/kubespray/blob/master/roles/network_plugin/calico/tasks/install.yml#L49
Doesn't use docker run.
What other methods to do that?

/ansign @okamototk

/assign @okamototk

cc @okamototk

i suggest that we should switch then to calicoctl binary

can we run containers  with cri-tools:
https://github.com/kubernetes-sigs/cri-tools
and continue to have the same workflow ?


assertion fails because of BoringSSL?

Hi,
I'm using Boost 1.75 and try to run a webserver based on the beast examples. My project also includes the Google WebRTC library which comes with BoringSSL. This seems to work also for Beast but sometimes when I connect multiple browsers using SSL and doing websockets and WebRTC I run into this assertion :
boost::beast::detail::stream_base::pending_guard::assign(bool & b)
in ..\boost_1_75_0\boost\beast\core\detail\stream_base.hpp Line 111
I've seen this for both read and write operations but it's hard to reproduce and happens only when there's much going on on the SSL websocket. Could this be related to the use of BoringSSL instead of OpenSSL?
Thanks and best regards,
Johannes

It'll probably be because you are using beast (and ASIO) incorrectly.
You must ensure that only one thread is using one IO object at a time (including during outstanding async operations).
You must ensure that only one async_read and/or one async_write is in progress on a stream at once.
This is true of beast, asio and any library that depends on them.

You're probably right and I'll check my code (which is still close to the example and i.e. a async_read is only called in on_read() so the previous read should be finished? As far as I understood it's OK to have an overlapping read and write (different type) but I must prevent two overlapping calls of same type (two reads or two writes)?

That is correct. The most common errors are:

multiple writes
more than one thread.

If it's none of those, then happy to take a look if you can help me with the SSL lib installation

Hi,
thanks very much for your help. I did a first quick check in my code and added some variables and assertions to see if I have some obvious mistakes. So far my checks don't fail, but I still have the assertion in stream_base.hpp. I started to think about SSL because I found this comment in ...\boost_1_75_0\boost\beast\core\impl\basic_stream.hpp Line 288 which also appears in my calll stack. And I can only reproduce the problem if there's a lot of data transferred between the browser and my webserver through this websocket.
BoringSSL is part of the WebRTC project which is a part of chromium ... that's 10 GB of code but I finally managed to compile and link with my beast based WebServer. I think I'll try if I get the problem reproduced without SSL ...
Best,
Johannes

Hmmm ... I did several tests without SSL and I pushed really hard to run into this assertion but I have never seen it so far without SSL. Now I'm not sure how to go on. I'm no SSL expert but SSL is mandatory for WebRTC once you go beyond <IP_ADDRESS> and our project also requires SSL. I'll probably have to try to compile WebRTC using OpenSSL ...

Not a bad idea. That will at least narrow it down.

Here some comments from Google about switching between OpenSSL and BoringSSL
https://boringssl.googlesource.com/boringssl/+/HEAD/PORTING.md
From your comments so far I'd guess that SSL in Beast is not yet tested to be used with BoringSSL?

Hmm that would be an Asio question.
@chriskohlhoff ?

OK, so I did various builds of OpenSSL und WebRTC without BoringSSL and either I could not link because of unresolved functions or because of already defined functions and when I finally managed to get something compiled and linked WebRTC crashed inside the first SSL calls. I also found some comments that OpenSSL support in WebRTC is not something which is intended anymore and probably will fail or cause security problems. So I returned to using Boost Asio with BoringSSL and I found a #define in Boost which is OPENSSL_IS_BORINGSSL ... but this doesn't seem to do the trick.

This is definitely an Asio question. I'll see if I can get Chris to chime in.

I already posted this also to https://github.com/chriskohlhoff/asio/issues/852 ... thanks for your support.

BoringSSL support was added through user-supplied patches, and I do not test asio with it myself. If you can create a minimal reproducer that runs with both OpenSSL and BoringSSL then we may be able to compare the behaviour of the two.

Now that the corresponding issue in the Asio repo is resolved, are we in a position to resolve this issue now?

Due to https://stackoverflow.com/questions/18409517/boost-asio-ssl-async-read-and-async-write-from-one-thread it seems to be necessary to do everything from one strand when it comes to a SSL stream. So far this seems to have solved the problem.

Not just SSL. Everything in asio and beast.
Strands are there to ensure correct concurrency control with io objects

Well, I think my misunderstanding was that just not have overlapping calls which I can also achieve from different threads with some synchronisation is not enough. There seem to be some inner asio and beast calls which still overlap and (at least to me) this seems to happen more often when it comes to SSL. So the importance of a strand vs. multiple but synchronized threads was not clear to me. Thanks again for your support.

Yes, all async operations involving SSL are composed operations. That is, there are intermediate completion handlers that touch the stream object prior to your final completion handler being called.
These all make progress on the executor associated with your final completion handler (see bind_executor()). If you don't bind an executor to your handler, the stream's default executor is used.
It therefore makes sense that this default executor (passed when the stream is created) is a copy of a strand, if you are in a multi-threaded environment.
strands are cheaply-copied handle objects.


FlightTask - Move ekf reset counter monitoring logic in the base FlightTask

Until now, the FlightTask altitude was checking for the EKF quaternion reset, and the AutoLineSmoothVel & PositionSmoothVel were checking for position and velocity estimate resets; the code was simply duplicated.
To make it more scalable and to avoid further copy/paste, the logic for checking the reset counters has been moved to the base FlightTask that calls EKF reset handler functions.
Each child FlightTask can simply implement what it wants to do in case
of an EKF reset event by overriding one of the _ekfResetHandler... functions:

void _ekfResetHandlerPositionXY()
void _ekfResetHandlerVelocityXY()
void _ekfResetHandlerPositionZ()
void _ekfResetHandlerVelocityZ()
void _ekfResetHandlerHeading(float delta_psi)

Changes made in

[x] ManualAltitude
[x] ManualPositionSmoothVel
[x] AutoLineSmoothVel
[x] AltitudeSmoothVel

Next step is to send the delta_position and delta_velocity as well, but this is more than a simple refactoring (see issue #12966)

makes sense.

one question:
Would it be possible to hide the reset from the child-tasks entirely? Basically the entire reset + delta-adjustment would be done in FlightTasks

@Stifael Unfortunately not. Some Flight Tasks, such as the ones using the "VelocitySmoothing" class need to adjust their internal state, not only the generated setpoint. However, we might want to have a basic reset handling in FlightTask.cpp and then just override it if required.

Rebased on master

I pushed a suggestion for the struct initializer that IMHO is more readable but feel free to drop it if you don't agree.


[Bug Report] questions about element-ui development

Element UI version
1.3.5
OS/Browsers version
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.2 LTS
Release:	16.04
Codename:	xenial
Vue version
2.3.3
Reproduction Link
https://elementui.github.io/issue-generator/#/en-US
Steps to reproduce
yarn dev
What is Expected?
怎么实时监听组件的变化
What is actually happening?
在开发组件时实时监听组件的变化

Simply run npm run dev. cooking watch takes care of that.

@Leopoldthecoder 我改变packages下面的文件时，并没有监听到变化


Multilingual translation

I am training multilingual translation for three languages.
The languages are English,Hindi and Bengali.
I am training a single model for translating English-Hindi,English-Bengali,Hindi-English,Begali-English as described here: https://github.com/pytorch/fairseq/tree/master/examples#multilingual-translation.
After training for 30 epochs,
While Testing for English to Hindi,
The output translation contains Hindi and Bengali both instead of only Hindi.
Other Directions from Hindi to English and Bengali to English is coming correctly(Towards English).
My training details are as below:
Hindi -English corpus : 1689738 sentences
Bengali-English corpus : 387425 sentences

@pipibjc

@amrit-bhaskar, could you provide your training log and fairseq version you used? I can help to take a look.

I forget to mention, you don't need to provide the whole training log. Just the first part that includes Namespace(... so that I can check the parameters.
I had a fix 1566cfb that fixed a bug for one-to-many multilingual translation. If your fairseq checkout is older than that, you could patch the fix, re-train and evaluate your result to see if that fix your problem. Feel free to still share your training log so that I can help to double check.


Reconstruct time-tree with earliest samples

Using the most recent samples as lineage representatives is starting to yield time-scaled trees that are not consist with lineage definitions (i.e., lineage B, which should be ancestral/basal, is nested in a recent subtree).
See issues #278 and #245

This has been changed in dev but it is not yet tested live.  See pull request.


integrate resize sensor to update scrollbar

In my case, the component size may be changed without updating.
But scrollbar component only recalculates correct position during updating.
So the scrollbar doesn't show when needed, or the opposite.

Implement by myself. This repo is unmaintained

Hi @Justin-ZS
Can you please share your logic of resize


Secondary variants cannot be created lazily

Current Behavior
Creating secondary variant lazily, using register, leads to failures like
Cannot create variant 'my-secondary-variant' after dependency configuration ':myConsumableConfiguration' has been resolved

See the reproducer project for more details.
Expected Behavior
Secondary variants should be allowed to be created lazily
Context (optional)
No response
Steps to Reproduce
https://github.com/ALikhachev/gradle-reproducers/tree/main/secondary-variant-resolution
Gradle version
8.10
Build scan URL (optional)
No response
Your Environment (optional)
No response

This issue needs a decision from the team responsible for that area. They have been informed. Response time may vary.

Using lazy APIs in this context probably does not have the benefit it has for task registration. However, the type exposed by Gradle, or an exception, should make that clear. Or it should work properly.

We'll take a look for 8.12

The error message is misleading. This configuration is never resolved.
This seems to be an error in the way we handle disabling mutation of secondary variants in DefaultConfigurationPublications


OLED controller compatability

Didn't know where to put this, or contact you, so I'll put it here:
Which controller IC did you use for your display? Is it a 256x64 pixel one?
Those are usually SSD1322, and the 128x64 ones uses SSD1306.
Didn't see any clues in form of libraries in the source folder.
This is a great contribution btw.

Clue is in the name https://github.com/openscopeproject/HP34401a-OLED-FW/tree/master/lib/SSD1322_Display
I built it around 256x64 display based on SSD1322, this is the particular one I recommend https://www.buydisplay.com/white-3-2-inch-arduino-raspberry-pi-oled-display-module-256x64-spi
(it's also available on ebay)

I absolutely love that site. And they've added quite the assortment in the last year. I like the model you choose. I would've too.

Was it difficult to code?

You mean the display lib specifically or the firmware as a whole?
Display lib was a bit tricky to do efficiently because of 4 bit per pixel encoding. You are forced to update 2 pixels with each command so if you want to change only one pixel then you either have to read the display memory (another command, slow) or have a frame buffer in memory. I chose the latter, the chip had enough ram fortunately.
Firmware was pure fun to do, especially reverse engineering part.


Argument destructuring idea

If in TypeScript your function takes a dictionary of parameters, I often end up writing code like this:
public doStuff({ arg1, arg2, arg3, arg4 }: { arg1: string, arg2: number, arg3: number, arg4?: boolean })

which is not particularly DRY.
My suggestion would be to write the above code like this:
public doStuff({ arg1: string, arg2: number, arg3: number, arg4?: boolean })

I think this would make a lot of code easier to read. Thoughts?

@johnfn unfortunately this is impossible because the the syntax you propose is already in use. It destructures the incoming object, declaring locals having the names to the right of the :s aliasing the properties to their left.
I have no idea why this syntax was chosen by TC39 given that the as keyword is used for destructuring imports into local aliases, which is conceptually analogous.
I wonder if anyone can shed some light on why this syntax was chosen.

I have no idea why this syntax was chosen by TC39

No idea here either :confused:

Coincidentally, @bterlson and I had this conversation earlier today. Still no answer. :smile:

that the as keyword is used for destructuring imports into local aliases

Indeed it is for imports. However for general destructuring it is consistent with structuring and uses : (and parameters follow the same pattern) (wrote it up once).
// structure
const obj = {"some property": "some value"};

// destructure
const {"some property": someProperty} = obj;

Everyone's dislike for the es6 import syntax has been discussed before ¯\_(ツ)_/¯ :rose:

Alright - my poor attempts at defining a new syntax aside, I think we're getting away from the main point, which is the violation of DRY by the duplication of argument names. I'm pretty sure that faux-keyword-arguments is a fairly common pattern that leads to code that could look nicer. 😄
Furthermore, since this is a problem specific to TypeScript - more precisely, the typings that TypeScript gives to the arguments, it seems like it's fairly well within scope. (Unless I misunderstood something?)
Thoughts?

public doStuff({ arg1 implements string, arg2 implements number, arg3 implements number, arg4? implements boolean })

Just syntax-bikeshedding.

@DanielRosenwasser I don't recall that conversation :-P But it's true I don't entirely grasp the rationale. I am guessing that it was important that a destructuring pattern match the grammar of object literals. It definitely seems nicer than as with nested destructuring, ie let {x: {y: z}} = {x: {y: 1}} over let {x as {y as z}} = {x: {y: 1}}. You could argue that binding to a nested pattern uses : but renaming uses as, though this doesn't resolve the ambiguity for TS and introduces an inconsistency for arguable gain. Additionally, because you can make use of the { x } shorthand, it is useful to know this is always a shorthand for { x: x } even in destructuring patterns.

Since we're already talking about it, maybe a syntax like this would be acceptable?
public doStuff({arg1: string, arg2: number, arg3: number, arg4: boolean } as params)
The as would give a strong hint as to what's going on.

@johnfn but you still have the problem that you can't express an inline rename and the type at the same time.
Also that syntax could break compatibility with a future version of ECMAScript which, for example, could introduce a feature that allows simultaneously destructing an object to access specific fields but allowing the entire structure to be named.
@bterlson when nested destructuring patterns come into play, the symmetry of the current syntax is really quite elegant. It wins me over. Actually, I'm curious why the : syntax is not leveraged, by analogy, for aliasing module exports. Why was as introduced? Does it stem from a preference for Python?

@aluanhaddad
If you want the inline rename you can just type out the original syntax. It seems like an acceptable compromise to me.


Update install.md

docs are out of date =)

minor change for go package link

nvm. looks like this repo has enough of these lol. Sorry for not looking first.


Create a list of issues on the dashboard

Add the list of issues that a person is working on the homepage.

As discussed, this is a vertical container which holds all the cards containing issues. Clicking on the cards takes you to the issues page on github.

@anandrajaram21 are you working on this right now?

An improvement could be that we allow certain actions to take place through the dashboard itself like closing an issue and stuff.


fix: not exist db

What this PR does:
Which issue(s) this PR fixes:

Fixes #597
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report
Base: 36.65% // Head: 36.95% // Increases project coverage by +0.29% :tada:

Coverage data is based on head (33a8999) compared to base (ac942f6).
Patch coverage: 0.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
+ Coverage   36.65%   36.95%   +0.29%
==========================================
  Files         198      198
  Lines       22145    22145
==========================================
+ Hits         8117     8183      +66
+ Misses      13149    13053      -96
- Partials      879      909      +30

Impacted Files
Coverage Δ

pkg/mysql/server.go
0.00% <0.00%> (ø)

pkg/boot/boot.go
52.17% <0.00%> (+6.83%)
:arrow_up:

pkg/boot/watcher.go
7.81% <0.00%> (+7.34%)
:arrow_up:

pkg/boot/discovery_watch.go
24.74% <0.00%> (+24.74%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update pl.json

Hi, as part of the hacktoberfest action I made some language modifications for this repository.

@KaminskiDaniell Do consider raising this PR in https://github.com/ferdium/ferdium-app which is a fork of this project and is in fast development

Please contribute via Crowdin.


Table Pagination and search

How to use table with template for show pagination and search, i'm try more dont have success.

Please share the code that you have tried and the issue occurring in the output.


Unable to push to repo (ssh issue?)

After following the setup instructions:
kubectl create -f https://raw.githubusercontent.com/hasura/gitkube/master/manifests/gitkube-setup.yaml

#expose gitkubed service
kubectl --namespace kube-system expose deployment gitkubed --type=LoadBalancer --name=gitkubed

I've set this repo up:
apiVersion: gitkube.sh/v1alpha1
kind: Remote
metadata:
  name: my-app-remote
  namespace: default
spec:

# Insert ssh-keys for allowing users to git push
  authorizedKeys:
  - |
    "ssh-rsa AAAA........"  #content of ~/.ssh/id_rsa.pub

# Provide registry details: https://github.com/hasura/gitkube/blob/master/docs/registry.md
  registry:
    url: "services.azurecr.io"
    credentials:
      secretRef: services-regsecret                # Name of docker-registry secret

# Define deployment rules
  deployments:
  - name: my-app                             # Name of K8s deployment which is updated on git push
    containers:
    - name: my-app                           # Name of container in the deployment which is built during git push
      path: .                   # Docker build context path in the git repo
      dockerfile: ./Dockerfile  # Location of Dockerfile for the source code

For
kubectl get remote my-app-remote -o yaml

I get
<EMAIL_ADDRESS>
I then set up the remote:
git remote add release<EMAIL_ADDRESS>
When I push, it failes with
The authenticity of host '<IP_ADDRESS> (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:lOqGRBz/OyFYKwkUbrZrWSAYqWPjPGp1x8moUj9ci18.
Are you sure you want to continue connecting (yes/no/[fingerprint])?
Host key verification failed.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

What could possibly be going wrong?

Can you edit the SSH key to remove the quotes?
    "ssh-rsa AAAA........"  #content of ~/.ssh/id_rsa.pub

should be
  - ssh-rsa AAAA........

on a single line

I you wanna do multiline, use
  - |
      ssh-rsa AAAA........

Indentation is important

I had the same issue, it wasn't anything wrong in the yaml. It turned out that gitkubed is not refreshed when adding or changing remotes, so if you add an authorized key you need to restart gitkubed before you can connect.


[PoC] Dynamic iterator demo

This is a demonstration of a combinator-style iterator implementation, ported from muts and inspired by @tonyfettes's iter.
This PR is created to be closed.

we are working on this, thanks for suggestions


suppress cve

Suppress the CVE
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

fix in https://github.com/hmcts/rd-user-profile-api/pull/977 no need to suppress

Closing this PR based on @dpmatheson provided fix for CVE !! fyi @pksaxena01


bufio: Scanner considers a buffer of length = len(token) as not enough

What version of Go are you using (go version)?

$ go version
go version go1.15 darwin/amd64

Does this issue reproduce with the latest release?
Haven't tried
What operating system and processor architecture are you using (go env)?
go env Output
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/k0nst4nt1n/Library/Caches/go-build"
GOENV="/Users/k0nst4nt1n/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/k0nst4nt1n/_gopath/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/k0nst4nt1n/_gopath"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.15/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.15/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/3q/jr3whwkn13ld3j1s1xms0v4w0000gp/T/go-build070878361=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Golang bufio.Scanner considers a buffer of length = len(token) as not enough, please see example below:
(full code is here https://play.golang.org/p/3e95HG3j4H-)
func main() {
	d1 := "12" // data size == 2
	r1 := strings.NewReader(d1)

	s1 := bufio.NewScanner(r1)
	s1.Split(bufio.ScanLines)
	s1.Buffer(make([]byte, len(d1)), len(d1)) // buf size == 2

	_ = s1.Scan()
	fmt.Printf("Token=%s, Err=%v\n", s1.Text(), s1.Err())
}

What did you expect to see?
No error (output: Token=12, Err=<nil>)
What did you see instead?
Error (output: Token=, Err=bufio.Scanner: token too long)

I don't see an easy fix here.  The code would have to do a look ahead when it reaches the end of the buffer, which would be complicated, and would help approximately nobody.
This should probably just be mentioned in the documentation.

You are using
s1.Split(bufio.ScanLines)
//scanlines add additioonl byte for endline char "\n"
change to
s1.Split(bufio.ScanBytes)

bufio.ScanLine

I know how to workaround with +1 and bufio.ScanBytes is not what I want. I want to read the whole line until the EOL or EOF.

replace string with EOL to simulate reading file
d1 := "12\n"

replace string with EOL to simulate reading file
d1 := "12\n"

The issue is not about how to workaround or simulate something. I can make it work. The issue emphasizes how EOL and EOF are treated differently in terms of how big your buffer should be for the scanner. This behavior is not immediately obvious (and of course it doesn't matter what we read, a file can also not have EOL).

scanline without EOF and EOL is not working , take a look here

I think you would like to add additional "if" to scanline function to read string without EOF and EOL

scanline without EOF and EOL is not working , take a look here
https://golang.org/src/bufio/scan.go?s=11967:12045#L340
I think you would like to add additional "if" to scanline function to read string without EOF and EOL

I'm not sure why you say "without EOF and EOL" there is EOF in my case.  In this case EOF is just a contract supported by the Reader interface. No more data to read it will return EOF.

EOF is an extra int with value -1
https://en.wikipedia.org/wiki/End-of-Transmission_character
https://www.includehelp.com/c/value-of-eof-in-c-programming-language.aspx

I investigated this issue and you are right something is bad.

The code at scan.go indicate that if if len(s.buf) >= s.maxTokenSize, it will raise ErrTooLong error. A quick fix would be to update the document like this:

Buffer sets the initial buffer to use when scanning and the maximum size of buffer that may be allocated during scanning. The maximum token size can't be larger or equal to the larger of max and cap(buf). If max <= cap(buf), Scan will use this buffer only and do no allocation.


[QUESTION] Laravel Vapor Storage Issues

Prerequisites

[X] Have read and understood: https://github.com/Maatwebsite/Laravel-Excel/blob/3.1/.github/SUPPORT.md
[X] Checked if your Laravel Excel version is still supported: https://docs.laravel-excel.com/3.1/getting-started/support.html#supported-versions
[X] Checked that your question isn't already asked before.
[X] Filled in the entire issue template

Versions

PHP version: 7.4.1
Laravel version: 7.10.2
Package version: 3.1.19
Vapor Core: 2.5.5

Description
I'm currently importing data with an import class that has ShouldQueue and WithChunkReading traits and using 'remote_disk' => 's3', my expectation would be that the file is read from s3. However after a week of error free imports on Laravel Vapor a bunch of errors started showing up in Sentry.io and no further imports were able to be processed.
The errors were coming from maatwebsite/excel/src/Files/RemoteTemporaryFile.php with the following error. touch(): Unable to create file /tmp/laravel-excel-ZUHzpmGcmZIlYptDogYVj9yOzjk5wQf7 because No space left on device
I thought this was odd as I figured the use of s3 meant no files would be stored on the server, but after looking at the class maatwebsite/excel/src/Jobs/ReadChunk.php in the stack trace I noticed the following
$spreadsheet = $this->reader->load(
    $this->temporaryFile->sync()->getLocalPath()
);

I believe the issue was that the job failed several times (due to an unrelated mysql validation issue), every time it failed it also didn't remove the temp file afterwards. Since there was a constant stream of queued imports the lambda container never shut down and was never able to clear its tmp folder, and after enough failed imports stacked up the storage space was full thus preventing any further imports from running.
To solve the issue I stopped all imports, and let the queue run to zero. (Fixed the mysql issue) And then retried all the failed jobs.
So an obvious solution to the above is never have failed imports which I will keep a closer eye on moving forward. However in debugging, it occurred to me that this could potentially happen in a high traffic vapor site even without failing imports. If the chunks were split up on enough jobs and the queue was backed up enough i would expect the same file storage issues to arise again.
So the question(s):

Is there a technical limitation preventing being able to read the file directly from s3?
If so, is the local temporary file removed after every instance of ReadChunk has been run? Or just after entire import has been run?
In the ReadChunk::failed method, would it be advantageous in your opinion to remove the temp file here?

Thank you for your time reading this, and any insights into the above 😌

Hey thanks for using the package. Cool to hear that the package works (more or less :) ) okay on Vapor! I haven't played around with exporting on Vapor myself yet.

Is there a technical limitation preventing being able to read the file directly from s3?

PhpSpreadsheet unfortunately doesn't support it. That's why we have to copy the remote file to a local file

If so, is the local temporary file removed after every instance of ReadChunk has been run? Or just after entire import has been run?

I think only after entire import.

In the ReadChunk::failed method, would it be advantageous in your opinion to remove the temp file here?

I think that should be possible yes.
Feel free to PR a solution that works for Vapor too!

Thanks for the prompt reply, I will try and look into the file removal in the failed event and create a PR for it, in the coming week 👍🏻
In regards to the following;

is the local temporary file removed after every instance of ReadChunk has been run? Or just after entire import has been run?

If say a CSV with 20,000 rows is chunked by 1000 into 20 different jobs, it's quite likely that those jobs will land on different Vapor containers. Each will then create a local file on it. But based on your answer. I think only the job that runs the after import event would be the one to remove the temporary file. (Which might not even have any of the related temporary files on it).
So I'm not sure what the best approach would be for the above, but I think a similar issue with a constant queue will also eventually lead to storage issues. I wouldn't want to spend time on approaching a PR for this incorrectly, so I would be interested to hear if you have any ideas about what the best approach would be.

I think that sounds good yes. It should copy the temporary file from the remote again if it doesn't exist in the next job.

Thanks for merging in those last two PR's. I believe the issue I outlined surrounding a distributed constant load of imports would eventually cause the file storage to fail on Laravel Vapor, as it won't have been able to shut itself down and clear its /tmp folder. Based on our conversation above only the last after import job does this clean up task, and that will only remove the temp file from the instance that handles that job, not the others that were processing its other chunks.
I've been looking into this the last couple days while working on the above PR's. So far I think a possible approach would be to suffix the file with the start row which could be passed through on the sync() method, something like the following;
ReadChunk::class
public function handle(TransactionHandler $transaction)
{
    ...

    $spreadsheet = $this->reader->load(
        $this->temporaryFile->sync($this->startRow)->getLocalPath()
    );

    ...

    $transaction(function () use ($sheet) {
        ...

        $sheet->disconnect();

        if ($this->temporaryFile instanceof RemoteTemporaryFile) {
            $this->temporaryFile->deleteLocalCopy();
        }
    });
}

If you could let me know if this approach would be ok, I could explore a PR for this over the weekend, if not let me know what concerns you would have any maybe any insights on how we could solve it ✌🏻

I think the reason why I didn't originally re-copy the remote file in each chunk was to prevent having to stream big files for each chunk. Perhaps it's not the biggest issue to make temporary files chunk dependent and just clean them up on success and failure and let each chunk re-sync it.
I'm okay with your suggest approach. Perhaps suffix isn't needed if we always re-sync? I believe local file name will be unique?

Ok so here are a few thoughts on this. In the Vapor use case we basically always want to remove the file being read at the end of the chunk. And since the file has a unique name we copy it for each request, read, import then delete.
In the case of a regular server user using queued chunk reading and remote disk, it seems plausible that the person may not want this constant copying for each chunk, especially if they were working with larger files. (In the case of vapor this is unlikely to be a problem as File Uploads are capped at 2MB).
In order to accommodate both use cases for a PR I would propose that this feature be optionally toggled in the config with a flag something like the following.
 'copy_from_remote_disk_for_each_chunk' => false,
Happy to update the config file with a summary of the topics covered in this thread as per other settings in the config as part of the PR.
Keen to hear your thoughts on this, as well as any alternative names for the above flag if you approve of the approach.

Sounds good!
Is there a way we could auto detect Vapor usage? I'm fine with automating the clean-up.

I believe you could probably use these https://docs.vapor.build/1.0/projects/environments.html#environment-variables to try and auto detect. However, I think a flag would be better suited as those variables could change without warning. Additionally would make it a bit less intuitive to run the app locally under similar settings.

Yeah lets go for a config variable, perhaps adding some explanation to that config setting and adding a dedication section to Vapor usage.
For the config setting, maybe: excel.temporary_files.force_resync_remote

Setting is merged

I'm having similar issue currently, but my settings seem to be correct.
ErrorException: touch(): Unable to create file /tmp/storage/framework/laravel-excel/laravel-excel-7IEEz0rP7NORtp7N4NeOxuH0hlbM9JPR.csv because No such file or directory in /var/task/vendor/maatwebsite/excel/src/Files/RemoteTemporaryFile.php:97
Do I need to remove
'local_path'          => storage_path('framework/laravel-excel'),
Entry from config?

I'm having similar issue currently, but my settings seem to be correct.
ErrorException: touch(): Unable to create file /tmp/storage/framework/laravel-excel/laravel-excel-7IEEz0rP7NORtp7N4NeOxuH0hlbM9JPR.csv because No such file or directory in /var/task/vendor/maatwebsite/excel/src/Files/RemoteTemporaryFile.php:97
Do I need to remove
'local_path'          => storage_path('framework/laravel-excel'),
Entry from config?

I'm having similar issue currently, but my settings seem to be correct.
ErrorException: touch(): Unable to create file /tmp/storage/framework/laravel-excel/laravel-excel-7IEEz0rP7NORtp7N4NeOxuH0hlbM9JPR.csv because No such file or directory in /var/task/vendor/maatwebsite/excel/src/Files/RemoteTemporaryFile.php:97
Do I need to remove
'local_path' => storage_path('framework/laravel-excel'),
Entry from config?

Did you find a solutions?

anyone solve this issue? I get the same thing.


fix: resign urls when then don't work

fix: proper amazon aws path
fix: regenerate a signed url if expired
fix: do url check on BE

Fixed with #617


Use mina version wisely

Problem: Module mina_version uses mina_version.normal as the default
implementation which causes recompilation of most of the project on
every commit.
Solution:

use mina_version.dummy as the default implementation
rename mina_version_normal to mina_version_compiled
use mina_version_compiled in all archive, rosetta and archive
executables

This PR also makes mina_version_compiled a separate package (not part of
mina_version). While this is unnecessary for the purpose of PR, it eases
dependency analysis on package level vs. library level. This is useful
for some work that will be introduced in follow-up PRs.
Explain how you tested your changes:

Mina compiles
Compiled executables show correct commit id when mina version is called

Checklist:

[x] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[x] Modified the current draft of release notes with details on what is completed or incomplete within this project
[x] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[x] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[x] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules
[x] Does this close issues? None

!ci-build-me

!ci-build-me

!ci-build-me


[Feature Request] Standardize Function Naming Conventions

The function naming conventions should be more universal, such as with capitalization in the case of FreeRTOS_SignalSocket vs FreeRTOS_closesocket. I would suggest renaming as needed for next major version and include macros to link to the old names.
Also there are some functions such as xSocketSetSocketID/pvSocketGetSocketID which state are only used by the user but don't have the API naming convention.

@HTRamsey wrote:

The function naming conventions should be more universal, such as with capitalization in the case of FreeRTOS_SignalSocket vs FreeRTOS_closesocket.

The function FreeRTOS_SignalSocket is using Camel case because there is not a corresponding signalsocket(), although the function signal() is quite similar: it can interrupt an API.
All BSD functions are in small letters and preceded by FreeRTOS_, such as FreeRTOS_bind().


Compose multiplatform support (for ios, jvm, js, macos, linux etc.)

Is there any work on it?

There are no plans for this but we'd welcome a PR!


VTK output on high-order Lagrange elements

Purpose of this PR is to enable VTK output on high order Lagrange elements for DG (already exists) and FEM.
Need to add a unit test before merging.
The function now accepts any AbstractLazy so we can write
mesh = rectangle_mesh(6, 7; xmin = -1, xmax = 1.0, ymin = -1, ymax = 1.0)
u = FEFunction(TrialFESpace(FunctionSpace(:Lagrange, 4), mesh))
projection_l2!(u, PhysicalFunction(x -> x[1]^2 + x[2]^2), mesh)

vars = Dict("u" => u, "grad_u" => ∇(u))

for degree_export in 1:5
    println("Output of degree $(degree_export)")
    U_export = TrialFESpace(FunctionSpace(:Lagrange, degree_export), mesh)
    Bcube.write_vtk_lagrange(
        joinpath(@__DIR__, "out_$(degree_export)"),
        vars,
        mesh,
        U_export,
    )
end

I have also added tests with the above example. The generated files sha1sum are compared to reference sha1sum stored in a checksums.sha1 file.
There is also a new Project.toml in the test directory : this allows to add dependencies just for the tests and not the entire project.
Finally, I have increased the Bcube.jl/Project.toml version. It fixes the compat issue with BcubeParallel and, more importantly, I think it's a good practice to do it as soon as a version is tagged (to show that we are working on a new version).
@ghislainb if you have time, it would be nice that you run the naca example with this write_vtk_lagrange function instead of write_vtk_discontinuous. Both should give the same result and we could get rid of write_vtk_discontinuous. Since this PR is quite decoupled from the rest of the project, we can wait until you do that.

I have removed order 3 and 5 in my test because it leads to some differences (on the sha1sum) when running in REPL vs running in test. The differences are minor (last digit of some number) but breaks the tests.


Fine-tuning metric depth model

The relative depth model outputs the inverse depth, while the metric depth model outputs the true depth.So I think it is necessary to use inverse depth to fine-tuning metric  depth model, right?

Maybe this is why the metric depth training gets worse over time during fine tuning

Which loss should we use if the inverse depth is used? Should we use SiLogLoss or L2 loss?
@tmagcaya @ysz-leo


TimescaleDB connection in left panel and overall support

System information:

Operating system (distribution) and version: MacOS 10.15
DBeaver version 6.1.1
Java version 11
Additional extensions

Connection specification:

Database name and version
Driver name TimescaleDB
Do you use tunnels or proxies (SSH, SOCKS, etc)? Localhost

Describe the problem you're observing:
If I try to add a new connection to TimescaleDB it doesn`t appear in a connection list panel. Opening connection list to the main panel (F4 on Connection row) this TimescaleDB connection exists, but double click on it is not working. It is possible to open a script tab for this connection and write queries but not able to open Data/Properties tabs view for schemas and tables for this type of connection.
Steps to reproduce, if exist:
Add a new connection for TimescaleDB and try to use it
Include any warning/errors/backtraces from the logs

I can't reproduce this. Sounds like some kind of DBeaver internal error.

Does this happen only with Timescale connections?
Could you send error/debug logs? (https://github.com/dbeaver/dbeaver/wiki/Log-files)

This TimescaleDB connection has appeared in the left panel after a couple of program restarts. After it appeared all newly added connections of TimescaleDB are working fine and all the features needed are also available. Seems like some internal problem that is fixable with restarts.

This still looks like a bug in DBeaver. Any log files would be very helpful, otherwise I can't realize what is wrong.

This issue was not reproduced. Also tried on 6.1.2 - works fine. Sorry, but no logs from that moment are available.

Ok.
Thanks for testing


Move admission configs to v1

For https://github.com/istio/istio/issues/30822
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-helm-tests_istio
c9773980df40dc016ddd54f3e856df054b171a57
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

might need https://github.com/helm/helm/issues/7697#issuecomment-613535044 or manual steps for helm

/retest


Refactor events to decouple k8s event and cloud event

Changes
This commit refactors the code in events to decouple the k8s events emit
and cloud events emit. This commit fixes https://github.com/tektoncd/pipeline/issues/4404. This could avoid circular dependencies. The events in test is also moved to k8sevent pkg.
This also pave the path for https://github.com/tektoncd/pipeline/pull/5770
/kind cleanup

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

cc @lbernick

@Yongxuanzhang can we add ad test for EmitCloudEventsWhenConditionChange?

@Yongxuanzhang can we add ad test for EmitCloudEventsWhenConditionChange?

Sure! It is actually tested from the Emit() function, is it ok to just copy some test cases there?

/lgtm


[Ahuna] Users can create private assistants & change scope in builder

Related task
@Duncid added you for review with screenshots below, and a proposal for "workspace" assistants builder: it felt natural that team sharing section remained across all builder screens, tell me if you're fine with it

From private to published

After publication

Suggestion for worskpace assistants, as accessed by "Workspace assistants" nav

Made changes requests
Elements noticed during testing that remained to be done but, not directly related to this PR

In 'Workspace assistants', published  assistants shouldn't be shown?
cross on private assistants should prompt to delete them, not remove from list
for workspace assistants  in the workspace nav the cross has 2 modalities (delete / remove from workspace list) as per figma
people should see clearly which assistants are private / published by looking at their list

confirmation modal contents: text-sm in scopeflow modals but not in assistant details modal

Hey @philipperolet !
Overall looking good 👍
I know Figma is a bit tricky to navigate.
The component for team sharing shows a different copy:

I'll be adding copy for the Workspace case.

Thanks @Duncid ! The difference you are talking about is the last text, right? (or did you notice another difference that I didn't?) In the figma
This assistant is shared with X people in your team. Any edits will apply to everyone. If you want to create your own version of the assistant.

and in the screenshots
            This assistant can be discovered by everyone in the Assistant Gallery. Any edits will
            apply to everyone. You can create a duplicate to tweak your own,
            private version.

Here I changed the text for 2 reasons:

the sentence in the end (about duplicate) was incomplete => ok to change to anything else than what I wrote instead
the 'shared with X people' kind of made me think it was not accessible to other people than those X people (+ it slows a little the UX since it involves a DB query, although probably very little) => I don't feel strongly so if you think these are not a problem I will switch to the exact wording

As discussed irl

I rebase, @spolu takes the list of stuff above from this PR
I fix text-sm in modals
missing flow to be back on correct page
creation flow => create published => in my list

Thanks!

the sentence in the end (about duplicate) was incomplete => ok to change to anything else than what I wrote instead

Indeed. Modified it:

the 'shared with X people' kind of made me think it was not accessible to other people than those X people (+ it slows a little the UX since it involves a DB query, although probably very little) => I don't feel strongly so if you think that's not a problem I will switch to the exact wording

It's meant to show the number of people who will be impacted by a change.
If it's 0, it means you're pretty free to do whatever you want. if it 128, you'll probably understand you need to be careful.


Add an option to skip cache

Either with https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-setCacheDisabled or https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-reload

a reload (cached material icon) button after filter would be intuitive, as people would set their filters, enable interception, and reload with tab/enter/tab/enter.

a reload (cached material icon) button after filter would be intuitive, as people would set their filters, enable interception, and reload with tab/enter/tab/enter.


istio-remote deploy failed when zipkin is disabled

Please get more detail from https://github.com/istio/istio/pull/6127#issuecomment-397601409
I think the solution is we need add a parameter to check if we need to add zipkin endpoint or not.
/cc @sdake @tiswanso

I created a general istio-remote issue with handling services in #6321
IMO, we should either all but the absolutely essential services optional via not setting endpoint defaults in the values.yaml and checking if the value is set OR using helm subcharts and tags/conditions to include/exclude service manifests.

Thanks @tiswanso , let me close this one and trace it in your ticket.


Tried to make hide url functionality more usefull

I have been working on a project where we have paired mbp with jquery-pjax. There are lots of modifications we have made to the base that are specific to our needs, but I thought this one could be useful to others.
Basically there are times when a user does a page load where we know it would be cool to re-hide the url bar.  Also, while the initial behavior is acceptable(move to 1, check if it's interpreted as 0) on the first page load, if you do that every time the user does a page transition it can look like a bug. So, if you cache the value you can alleviate the need to re-check that every time.
I tried to be conscience of style, and tone but I might have missed something in the code it's self. Not sure if this is the best place to make a comment like this as well, so feel free to let me know if I should bring this up somewhere else.

hey, we did some update to the function based on scott's new script, but this looks great, so is it possible to have a new pull request? :)


Change hard coded strings to Enum const for routing and API error keys

Replace hard coded string with constants
https://github.com/BearStudio/start-ui/pull/78#discussion_r680941499
https://github.com/BearStudio/start-ui/pull/78#discussion_r680941587

I would love to work on it.

https://github.com/BearStudio/start-ui-web/pull/80#pullrequestreview-722086423