Added: collectCoverage

What:

collectCoverage added
test's coverage increased

Why:

Phrased simply, code coverage provides a visual measurement of what source code is being executed by a test suite. This information indicates to the software developer where they should write new tests in an effort to achieve higher coverage.

How:

set collectCoverage: true in jest.config.js
add more test-case to achieve better coverage percentage

Result:

Before

After

Suggestion:
I review some of the lines, were useless at this point.
Please check these lines (attached as "After" screenshot) and change them before accepting the PR if needed.

Hi @moh3n9595 Jan,
Thanks for contributing to the project. well done.
I appreciate it if you check the issues and contribute to implement the requested features.


DLA-3911-1, DLA-3912-1 missing in OSV.dev all.zip

DLA-3911-1, DLA-3912-1 missing in OSV.dev all.zip file downloaded from osv-vulnerabilities.storage.googleapis.com

Debian reference for same DLAs

DLA-3911-1

DLA-3912-1

Kindly clarify on these please.

Thanks for letting us know! Our exporter is currently facing some performance issues at the moment causing it to not update all.zip correctly, but it should be fixed soon (within this week)!

Thankyou for the quick response, Please do update after the fix


Landing page integration

Monika Pull Request (PR)
What feature/issue does this PR add

Add landing page integration (#680 )

How to test

cd docs
npm run dev
desktop preview & mobile preview

I think it's best to make the card style similar to the "What they say about Monika" section:


cannot use func(s string) string {…} (value of type func(s string) string) as func(strs ...string) string value in assignment

Error: ../../../go/pkg/mod/github.com/elewis787/boa@v0.1.1/cmdlist.go:41:8: cannot use func(s string) string {…} (value of type func(s string) string) as func(strs ...string) string value in assignment

I think you need to release a new release for boa

I will cut a release today - thanks for circling up on this.

resolved in v0.1.2

Thanks @elewis787


[MRG] Add data loader functions for BESA files

Implementing file readers for BESA .avr and .mul files, which are simple text files containing evokeds as produces by the BESA analysis software. Needs testing.
closes #9238, #10908
Todo:

[x] Support for .avr files
[x] Support for .mul files
[ ] Add entry to what's new (will do this after this PR is cleared for merge otherwise)

@massich This PR messes with your BESA .elp montage file loader. Could you have a look?

@wmvanvliet IIRC @massich has moved on to other projects/domains so I would proceed without a review. I think we can trust that tests were implemented well enough that we can go based on what they tell us

I would have just put the testing files in the mne-testing-data

They are only a few kb each.


Take in 3+ characters instead of the default 2

Is there a way to configure this plugin to take in 3 or more characters after s?  I often find that my files have many matches for two characters, and it's smoother for me to directly read the text at the place I want to go, as opposed to the arbitrary hint letters placed at each match by leap.  The leap-added letters require me to (1) read the place I want to go, (2) type s{c1}{c2}, (3) read the place again to react to the leap-added character, (4) type the character.  It seems smoother to instead (1) read the place I want to go, (2) type the characters there until my cursor gets there.  The hint letters are still useful as an escape hatch in case the string i'm searching for is long and occurs many times in the file.
I realize I'm basically just describing search, but that involves extra keystrokes to exit the search, and doesn't have hint letters.
I'm still newish to this plugin, so maybe there is another option that reduces this friction (or i just need to get used to it).

The very point of Leap (and Lightspeed) is that you don't have to pause and check the "result" of your actual input ("Am I already there? Should I type more characters?"), because at every stage it's already determined what your next keypress should be. You always have to type two characters, and if there is a need for a 3rd one, you already know it after the first input (well, if you're not typing extremely fast).

require me to (1) read the place I want to go, (2) type s{c1}{c2}, (3) read the place again to react to the leap-added character

No, it's more like: (2) type s{c1} (3) while typing {c2}, your brain is already processing {label}, if there is one (4) type {label}, and you're there.
With the method you described ("native search on steroids"), you also have to "react" to something - whether you arrived or not, and it worse, because you can never know it beforehand. Adding hint letters complicate the thing even more, since you have to accept the pattern first (with e.g. enter), so that the hints can be assigned to the matches - another decision, another additional keypress.
Pounce has an alternative solution to this: it uses fuzzy matching, and continuously relabels the matches as you type (it is even possible that a label disappears). Yes, that is - IMO - as confusing and un-ergonomic as it sounds. Additionally, the hints should all be uppercase characters (so that there's no need for accepting the pattern with enter first).
That said, you can also try Hop (there is a motion called HopPattern, which is basically what you requested), if not convinced, and see how that works for you.

This issue actually made me understand why this plugin does what it does.  It is a really cool idea and I agree with what @ggandor says.


Auto-Resize Windows Feature Breaks When Using Microsoft Teams

Microsoft PowerToys version
0.45
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce

Ensure the auto-resize window feature is turned on and working.
Start Microsoft Teams and join a video call.

✔ Expected Behavior
Microsoft Teams windows should auto-resize properly. If this is not possible, then, at a minimum, other windows on the desktop should still resize correctly.
❌ Actual Behavior
The auto-resize window feature in FancyZones breaks not just for Teams, but for all other open windows too.
Another user reports the same issue. See below:
I installed v0.45 and it solved the problem at first. But next day, it again stopped working (changing dispositon didn't changed windows sizes). If I open PowerToys, go to FancyZones, uncheck the feature, and re-check the feature, then all windows resize again immediately. But it quickly stops working again.
I think the problem can be linked to Teams: when I uncheck/recheck the feature, sometimes I get a colored rectangle appearing in the top-left corner of a zone, always on top all windows, and impossible to get rid of, except when I quit Teams. I then tried to use fancyZones with Teams off, and no more problems until I relaunch Teams.
Originally posted by @helaersr in https://github.com/microsoft/PowerToys/issues/8552#issuecomment-919011850
Other Software
Microsoft Teams Version <IP_ADDRESS>61 (64-bit)
Windows 10 - 10.0.19043 Build 19043

I can recreate but honestly, this may be due to how Teams creates the windows for calls.  The main chat window is launched correctly if snapped on new launch but I'm willing to bet the video conf window is a new window ID.
@SeraphimaZ don't we have a tool to verify this type of scenario to quickly debug?

@SeraphimaZ if my guess is correct, new window IDs, i think this is closed as external as we can't really do much about it

The issue though is that even after teams is no longer running, the issue doesn't correct itself automatically. If we can't fully fix the issue can we at least make this happen?

@crutkas I did a quick debug session and verified that the meeting window has the same ID. That's the reason why it's not snapped to a zone. Only the first window would be snapped. However, I've never seen that it breaks anything.
I'd like to take a look at logs, maybe there is something useful.

@flyoffacliff can you please attach a bug report?

There you go. Right before I took this bug report I opened the main Teams window, dragged it to a zone, and then applied a different layout via keyboard shortcut (to show it doesn't resize). Let me know if you need me to do anything else. Thanks.
PowerToysReport_2021-10-01-22-58-04.zip

@flyoffacliff thanks for the details. Looks like it's general problem, it doesn't relate to Teams.

This is not fixed for me. Installed the patch 0.47.1, and everything is the same as before. Rebooted and nothing but Chrome and file explorer are running.

I also experience issue with resizing snapped windows.
For me it's not related to Teams.
Restarting PowerToys fixes the issue for some time. Will be watching whether there is any reproducibility here... Other than that, can I help somehow


[Prototype] Improve batch module load performance on Knach

In A0 machine, reduce load time from 0.8s to 0.07s. This change delay the operation hander fetching.
This is a concept need more rigorous testing.

View a preview at https://prompt.ws/r/Azure/azure-cli/5150
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.

The CI complains about an undefined op_handler in your code.

Yes, op_handler is used again to make the request around line 495:
result = op_handler(client, **kwargs)

Will fix. Aside from that, @annatisch, does the change look good to you?

Updated.

Yup @troydai - LGTM

Great. @tjprescott the AzureBatchDataPlaneCommand doesn't inherit the AzCliCommand therefore it doesn't have an access to the command_loader. We may want to revisit the design later.

Automation failed, but no new tests fail comparing to the KnackFinal branch. I'll therefore merge this to the KnachFinal_2.0.24 branch soon.


feature: Create BodyText Component

Overview
Create a component that will render text given the following props:
fontSize: string,
color: string,
alignText: string,
text: string

Acceptance Criteria
The component should render the text using the props;

changed alignText to textAlign


Contract Config Stub (with Default-NFT)

There shall be a Stub for the contract-settings, which will later be added.
[Functionality later: Contract-URI, Contract-Metadata, Contract-Cover images etc etc]
For now, we shall just add the page and display the Default-NFT (+ option to Edit it):

When editing the Default-NFT, the Normal NFT-Editing view (shown in detail in #25 and #29) shall be used with some small changes:

Instead of the SLID, default shall be shown
Owner-History etc. will not be available

The default-NFT of a particluar contract with [CSN] can be found from SELECT * from nfts WHERE contract.csn == [CSN] AND anchor='default' LIMIT 1;

Started to work on branch contractSettings

Pushed a schema-change, which adds a mandatory JSON-Column contracts.settings, which is initialized with {} when importing contracts
Decided for JSON-settings, because we will often add new settings / features there. So having a relational schema doesn't seem developer friendly.
We can and should add a JSON-Schema for the settings, to have some structure and documentation, which should be kept up-to-date whenever a new key/setting is introduced

Will merge this schema-change outside the PR process, since we previously broke the schema already and I'll add this column to the breaking change. After that, we can start with proper prisma-migration scripts


Growl not show in Drag/Drop event

Describe the bug
Growl not show in Drag/Drop event.
Steps to reproduce the bug
GrowlNotShowInDropEvent.zip
using System.Windows;

namespace GrowlNotShowInDropEvent;

/// <summary>
/// Interaction logic for MainWindow.xaml
/// </summary>
public partial class MainWindow : Window
{
    public MainWindow()
    {
        InitializeComponent();
    }

    private void Window_DragEnter(object sender, DragEventArgs e)
    {
        Log.Text += "\nDragEnter begin";

        HandyControl.Controls.Growl.Info("DragEnter");

        e.Effects = DragDropEffects.Link;
        e.Handled = true;

        Log.Text += "\nDragEnter end";
    }

    private void Window_Drop(object sender, DragEventArgs e)
    {
        Log.Text += "\nDrop begin";

        HandyControl.Controls.Growl.Info("Drop");

        Log.Text += "\nDrop end";
    }
}

Expected behavior
Show Growl
Screenshots

NuGet package version
HandyControl 3.4.0
IDE
Visual Studio 2022
Framework type
.Net 6.0
Windows version
Windows 11 (22000)
Additional context
No response

I've found that sometimes Growl can work once if you don't click anywhere else after the program starts and just drag and drop the file in, so I tried activating the window:
Application.Current.MainWindow.Activate();
HandyControl.Controls.Growl.Info(msg);

Success!


Python: Fix cyclic import FP relating to packages.

Fixes #2125.
I also added a test case for one (of the many) instances that appeared on LGTM.com.

Done.


Memory Size and TileCache

Target Use case

Hello!  I am developing something that looks like it will have off-screen (i.e not visible) custom BaseTileLayers that I would like to have loaded for quick use and I would love to be able to allocate cache size equally and/or have each layer take up a predetermined percentage of the memory.
Proposed feature

I'd like if we could implement the maxCacheSize of the TileCache as a function of memory (allowing the user to control a percentage config, perhaps).  I see that there is a TODO for it already here so I just wanted to make my use-case known.  I am aware that my last PR seems to have opened something of a can of worms as per #4139 (very excited for these improvements, by the way!!!) so I understand if this is not coming for a while (until the API and location of the TileCache are finalized).

To avoid unload the whole responsibility to the user, maybe we can do the following:

Allow users to limit the cache by memory size, instead of the number of tiles. To track the memory used, we can look for a byteLength field on the result returned by getTileData. This will automatically work for ArrayBuffers, and applications need to manually populate this field for other data formats.
Update TileCache settings when the layer's props change (minZoom, maxZoom, maxCacheSize etc.)

Logistic wise, we are making an effort to align the 2D TileLayer with Tile3DLayer. Because the two layers will share some dependencies, I am moving the BaseTileLayer back to the geo-layers module. In the long term, we would like both the 2D and 3D tile layers to support non-geospatial use cases, and they may warrant their own module.

Just so I can get a sense of where things are heading, will moving that revert the newly exposed API for non-geospatial use cases or is the move in name only really?  Also, is #4139  going to be in 8.1?

It's not going to revert the new API. We will have one TileLayer that by default implements getTileIndices and tileToBoundingBox to the OSM spec.
#4139 is going to be in 8.1. I can publish an alpha release if you are interested in trying it out.

That would be superb, actually - I've been on the other alpha branch (since I am using the BaseTileLayer) and everything has been working swimmingly.  I can let you know if anything looks off.  Thanks!

@ilan-gold published 8.1.0-alpha.2

Thanks! Just so I can know what's coming, is #4232 going to be in 8.1?

Yes. I'll let you know when the change is in an alpha release. We also need to go through API audit before the official release, which might change some prop names.

Thanks, that second part is good to know.

@ilan-gold  8.1.0-alpha.5 is published with built-in support for non-geospatial tiles and cache size in bytes. The documentation on the master branch is up to date. Could you give it a try and let me know if things are working as expected?

@Pessimistress I already checked out master and gave it a whirl.  Ill test out the release tomorrow.  I was planning on offering you all a PR with a small example of it, like map-tiles in the website example section.  Would you be interested?  There might be a question of where to store tile data for the non geospatial image if so.

Here's the demo

@ilan-gold Love the demo!!! - what is the fully zoomed in resolution???

24000 x 24000 - I just wanted to offer it up here as @Pessimistress did the unit tests and I offered a demo: https://github.com/uber/deck.gl/pull/4246#discussion_r382206464.  If hosting the tiles are too much of a pain, no worries - I just wanted to follow up :)

@Pessimistress The release worked for me, by the way.

24000 x 24000

seamless zooming on 576 Megapixel image, that is quite impressiv!

If hosting the tiles are too much of a pain,

There is a deck.gl-datafor storing big data sets for other demos. I believe your tiles would be welcome there, as long as they are under permissive license. Or you can set up another similar repo to serve them.

@ibgreen I used libvips to create the tiled image pyramid.  I got the image from http://lroc.sese.asu.edu/posts/293 so I can add that URL in the bottom corner as well.

I used libvips to create the tiled image pyramid

Interesting. You may want to mention that in the deck.gl-data README. And also perhaps in the info panel for the demo. I think users will be curious to learn how to make a dataset like this.

I got the image from http://lroc.sese.asu.edu/posts/293

I took a look on their site, but couldn't see a LICENSE. If not stated, can you contact them and ask for permission?

I can reach out, yes.  I’ll also add information on the generation of the data from the source.

I reached out but I also saw this @ibgreen http://lroc.sese.asu.edu/posts/293

OK, that is enough.

[ ] Link to those terms in deck.gl-data PR
[ ] Add a Citation (compliant with those terms) in deck.gl-data
[ ] Add a Citation (compliant with those terms) in the example README and info box.

I noticed in http://lroc.sese.asu.edu/posts/293 that they are using an app called zoomify to offer the same (seamless zoom) functionality, and if you look in the network tab while zooming we can see them loading tiles...
Just a crazy idea, maybe we could make our tile layer compatible with zoomified data sets:

[ ] if we could deduce the zoomify naming scheme
[ ] if we could make our tile layer load those tiles directly.
[ ] not clear if those "zoomified tiles" are covered under the license

@ibgreen I think writing utilities for that sort of thing would probably be very nice.  I use DeepZoom which is another "format".  We have other formats as well that we could be interested in offering once we have written the finalized them.  Maybe some sort of data-utils folder would be nice.  You can have a look at the DeepZoom structure in my PR to deck.gl-data.
Another thing that I was planning on tackling was writing a MapController that offers smoother zoom/pan, kind of like OpenSeaDragon.  If y'all were interested, I could contribute it here once done.

I think writing utilities for that sort of thing would probably be very nice. I use DeepZoom

Maybe the first step is simply to create a short markdown doc, that talks about different tiled formats for deep image zoom (listing the tools available to generate that format, and the resulting file structure, whether format is proprietary etc). This would be a great go-to resource for users who are new to this problem and help establish the TileLayer as a serious option for visualizing such image stacks.
It would be cool if we could cover a lot of the available formats just by defining some template strings, that user could supply as a prop. If not, as you say, we could show how to write the tile URL generation functions in the docs, and later maybe even offer a library of such functions.

writing a MapController that offers smoother zoom/pan, kind of like OpenSeaDragon.

You mean a controller with inertia/dampening, so that it scrolls pixel by pixel and keeps scrolling a bit after we release? Yes that is a beautiful feature that we currently miss.
Some complications with taking such a PR on the core frameworks :

The design should ideally work for all our controllers, not just the map controller,
Have thorough test cases to make sure it keeps working in future releases
Be carefully architected so it does not constrain view/controller development in other areas

Obviously, you'd get some help to work through those issues, just as long as you are ready for them. If not, we can always accept a PR for an example as a first step.

Ok that sounds good for the tiling.  Thanks for the direction on the controller - I think it should be within my skill range.

[ ]  if we could deduce the zoomify naming scheme

It looks like the network requests are for the normal z/x/y tiling scheme, just that instead of having them nested in folders, the images are named {z}-{x}-{y}.jpg.

[ ]  if we could make our tile layer load those tiles directly.

Those tiles don't have the right cors settings, so I don't think we could load them directly.
Other notes: the image-tile example dir isn't yet included in the bootstrap settings, so I had to run yarn again in the dir.

Those tiles don't have the right cors settings, so I don't think we could load them directly.

In what sense? Is it the case where they can be loaded as images but only "opaquely" so textures can not be created?

As in trying to call
fetch('http://lroc.sese.asu.edu/ptif/zoomify/wac_nearside/TileGroup0/1-0-0.jpg')

from a non asu.edu domain returns
Access to fetch at 'http://lroc.sese.asu.edu/ptif/zoomify/wac_nearside/TileGroup0/1-0-0.jpg' from origin 'http://example.com' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

It looks like the network requests are for the normal z/x/y tiling scheme, just that instead of having them nested in folders, the images are named {z}-{x}-{y}.jpg.

Zoomify URLs require a TileGroup in addition to a z/x/y mapping, where a TileGroup contains up to 256 tiles. For reference, here's the OpenLayers source:
https://github.com/openlayers/openlayers/blob/master/src/ol/source/Zoomify.js


RedundantCatchClause

Started porting this analyzer.Having some issues to figure out what write for the IsThrowsClause and IsRedundant methods.  Plus, I would just like to make sure that nothing is missing.

I would just need some guidance in this as I think it's almost finish (analyzer)
How should I get started on the code fix provider? How should the fix work? Only but an empty throw statement plus a semi-colon ?

@mkrueger


update Kitura-net- remove minor version

This builds as-is with only the majorVersion.  If you want to keep the minor version, it needs to be updated to minor: 6
fyi: @rfdickerson

@AntonAleksandrov I've added minor: 6 to the PR.

Kitura-net already updated to 1.6


Beef up v2 api doc, create v3 api doc

Also some small tidy ups I found along the way...

Add prod high mem npm target
Remove duplicate get all services for space action GetServicesForSpace
Remove undeeded lines
Remove invalid sorting in space apps table (its non-local and cannot use sort by name & instances)

Created #3197 PR with the code changes


[ML Text Recognition] Different result on different iOS device

[REQUIRED] Step 1: Describe your environment

Xcode version: 11.4.1
Firebase SDK version: idk
Firebase Component: FirebaseMLVision, FirebaseMLVisionTextModel
Component version: 0.19.0
Installation method: CocoaPods (and cinterop, kotlin multiplatform)

[REQUIRED] Step 2: Describe the problem
Steps to reproduce:
Hey there! I have 2 same images and 2 iPhones: 8 and X. UIImage have scale set to 1 and cropped width and height by app. Then I send this image in onDeviceTextRecognizer() and get 2 different maps with all different results. Why so? Is there some scale dependence in ML KIT library?
Images is not too small. height = 2048, width = 1383.
I have same result without cropping image.

For tests, I compressed the image to 1280px, but still have different result, for different iPhones...

Now I took image from example and there is still different result for iPhone 8 and X.

Prop
iPhone 8
iPhone X

Height
1536.0
1536.0

Width
1024.0
1024.0

Scale
1.0
1.0

Wege der
[(410, 666) - (631, 643)][(414, 710) - (636, 688)]
[(410, 667) - (631, 644)][(414, 713) - (636, 691)]

parlamentarischen
[(287, 738) - (743, 686)][(292, 785) - (748, 733)]
[(287, 738) - (742, 685)][(292, 785) - (747, 733)]

Demokratie
[(372, 786) - (651, 754)][(376, 825) - (655, 794)]
[(372, 785) - (650, 754)][(376, 825) - (654, 794)]

As you can see there is some mismatch for text coordinates for same image on different devices. But why and how to avoid this?

Sorry missclick...

@artemsivcev Thanks for the report. We're tracking internally at b/156483920

@paulb777 is there any chance for hotfix to this issue?

Now I tested version 0.12.0 and 0.18.0 for this bug and there it is, but with different coordinates.
In ver.12 there is more accuracy between devices:

Prop
iPhone 8
iPhone X

Height
1536.0
1536.0

Width
1024.0
1024.0

sclae
1.0
1.0

Wege der
[(412, 665) - (633, 645)][(416, 713) - (637, 694)]
[(410, 665) - (633, 645)][(414, 713) - (637, 694)]

parlamentarischen
[(287, 739) - (743, 688)][(292, 784) - (748, 734)]
[(287, 739) - (743, 688)][(292, 784) - (748, 734)]

Demokratie
[(372, 785) - (650, 754)][(376, 824) - (654, 794)]
[(372, 785) - (651, 754)][(376, 824) - (655, 794)]

And in ver.18 same result as ver.19

@paulb777 Hi! Any progress?

@artemsivcev Sorry, not yet. I repinged the MLKit team.

@paulb777 sorry for trying, but... Still nothing? We are used this solution on production and this is really major issue...

@paulb777 Hi! Any progress?) I can help if you need it.

@morganchen12 ok, I can ping you instead)) I'm really want to resolve this issue and help!

Hey, sorry for the delay @artemsivcev. I'll take a look at this today. Are you receiving different results on different devices if you use the exact same image (not just two separate images downscaled to the same size)?

@morganchen12 yes, I sent on 2 iPhones 1 image via AirDrop. Then I open it with UIImage and compare all meta info and it was exactly the same. Where can I check downscaled info?

Your approach should be sufficient. I'll investigate.

I haven't been able to identify a root cause yet. I'll try reproducing this issue in the quickstart and continue from there.

Ok, if you need any info or help let me know

Some update, on all simulators same result for coordinates, problem only on real devices

Thanks @artemsivcev, I was also unable to reproduce the issue on simulator. Due to the work from home situation, I'm not immediately able to acquire another iOS device to test this on, so I'm going to have to ask for your help for on-device testing.
ML Kit's text recognition uses GoogleMobileVision under the hood. Can you try running text detection directly through GMV via the instructions in this doc and letting us know if the results differ per-device?

@morganchen12 yeah of course, I'll try it right now

I'm not really iOS developer, did you have swift example to use GoogleMobileVision? Or example project?

Running it, looking for iPhoneX...

Same test image, same test devices.

Prop
iPhone 8
iPhone X

Height
1536.0
1536.0

Width
1024.0
1024.0

scale
1.0
1.0

Wege der
[410.0, 644.0, 229.0, 68.0]
[410.0, 645.0, 229.0, 67.0]

parlamentarischen\nDemokratie
[287.0, 688.0, 467.0, 147.0]
[288.0, 688.0, 465.0, 146.0]

Thanks, I'll pass this info on to the GMV team. In the meantime, what version of GMV are you using? Does the behavior change if you switch to an older version?

@morganchen12 I get GMV from CocoaPods, think that was last one. Without issue in GMV repo(there is one?) it's dead end... Whom I suppose to ping? =D Need a solution for this...

You can manually pin an older version of a CocoaPod by explicitly listing it in your Podfile with the = operator. Don't worry about pinging the GMV team, I've done that for you (their issue tracker is Google-internal).
pod 'GoogleMobileVision', `= 1.5.0`

Only 1.5.0 need to check? And how to see all a available version on pods?

You should hopefully only need to check 1.5.0. You can check which versions of a pod are available by looking at the podspecs on GitHub: https://github.com/CocoaPods/Specs/tree/master/Specs/0/4/2/GoogleMobileVision

@morganchen12
GMV 1.5.0 test. There is only one line for iPhoneX... Still different result, but something new!

Prop
iPhone 8
iPhone X

Height
1536.0
1536.0

Width
1024.0
1024.0

scale
1.0
1.0

Wege der
[414.0, 643.0, 233.0, 69.0]
[-]

parlamentarischen\nDemokratie
[290.0, 687.0, 468.0, 155.0]
[-]

Wege der parlamentarischen Demokratie
[-]
[284.0, 635.0, 471.0, 205.0]

Thanks, looks like this behavior has been broken for some time now. I'll keep this updated with the GMV team's response, which may take a week or two. In the meantime let's try to find a workaround for your use case.
What are you using text recognition for and why is it important that text recognition is consistent across different devices?

I'm using it for detect table data. Some photo contains problems with degree angle for text. I try to use angle of bottom line of each block to detect average angle and create a straight line between blocks. And I create the best solution and it works, but only on iPhone 8. Now I found some workaround and used only longest blocks for detect angle. It's pretty close, but still have some issues...

@morganchen12 hey there! Any progress?

I have not been able to pin down why GMV returns different results on different devices. I'll let you know if I'm able to find a root cause.

@morganchen12 Hello! Still nothing? GMV team keep silent?

Nothing yet. I've pinged the internal bug for you.

That would be nice) And what they say?

They have yet to respond.

The Firebase ML Kit text recognition API has been deprecated since all on-device ML Kit features are no longer a part of Firebase. You should move to using the Google standalone ML Kit instead by following the migration guide here.
Sorry for the bad news.


Question about: [Action Required] Update your Firebase Remote Config SDKs before May 2, 2021

I used Firebase/RemoteConfig in my iOS app,
This is My PodFile.Lock：

Firebase/RemoteConfig (6.34.0):
Firebase/CoreOnly
FirebaseRemoteConfig (~> 4.9.1)

There are two version about FirebaseRemoteConfig, So, What is my FirebaseRemoteConfig  version number?
This is email I received：
To continue using Remote Config, be sure to upgrade your apps to SDK version 16.3.0+ for Android and 6.3.0+ for iOS before May 2, 2021.
My question is : Do I need to upgrade my FirebaseRemoteConfig?

No, your version of Remote Config is newer than the required 6.3.0, so you do not need to upgrade.


Use a distinct RandomState in the prefetch thread of MultiProcessIterator

Numpy shares the internal state of numpy.random across all threads. So if we use numpy.random from non-main thread, random number generation will be non-deterministic, dependent on context switch timing.
It hurts reproducibility. This PR fix the problem, by creating a distinct RandomState for each prefetch loop.

@takagi Thank you for your review. Fixed.

jenkins test this please.

I will merge the change after CI will pass.

 The problem is now fixed in the latest master.

@takagi Thanks. Now the branch is rebased on the master branch (with my commits squashed to a single commit) and it passed CI.

jenkins test this please.

Thanks! I have merged.

@grafi-tt Would you serialize the RandomState as well so that MultiProcessIterator can reproduce the order even when it repeats across serialization.


Shift+click selection for editor

When a user presses shift and taps/clicks on a text position (SuperTextField) or a content position (SuperEditor), the selection should move the extent to that position.

There's a debate to be had on how shift+click works with double- and triple-clicks. As far as I can tell, there's two possible ways to handle this behavior on desktop:

Default double and triple click behavior, even when shift is pressed

This would be no change to current double and triple clicking behavior, and is how browsers (or at least, Firefox on my macbook) do things.

Double click expands selection to include the entire word at the second position, Triple click collapses the selection back to a the original position (getting rid of the selection).

If the second position is in a different paragraph, the triple click expands the selection to include the second position's paragraph.
This is how it's done in Visual Studio Code

While the easy (and probably more "expected") behavior is the first option, playing around with how VSCode does it's text selection seems slightly more intuitive to me, although that's just personal opinion.
Thoughts?

The default behavior should probably match what is most commonly found in document editors, e.g., Word, Docs, Medium, etc. While it should be possible to use this package to write code editors, that isn't the default use-case.
Fortunately, package users have the opportunity to completely replace gesture and keyboard interactions, if desired. It's a little bit of work, but not a lot.

Great, less work to implement it like that anyway :)


Fix #7140 User is redirected away when help is their first page priv

This seems a bit of a hack here, having to hardcode a test for "help.php".
But what is better - sort the help.php entry to the end of the list? And then still have to handle the case where it is the only entry in the allowed pages list.

See #3412 for a way to handle this entirely in help.php - inspired by @jim-p comment above.

Closing in favor of #3412, I just merged that one it will show up momentarily. Thanks!


Update ts-automute.lua

untested changes to not mute players dieing in preparing.
untested changes to unmute all players at the beginning of the round.
untested changes to unmute players respawning while round is still in progress.

This should fix:

#7
#8

Thank you very much for contributing to this Project.
I really appreciate that :)


Rhythmbox daap support

Motivation for this change
As per title, this PR adds daap support for Rhythmbox. Important because Rhythmbox is one of the remaining DAAP clients for Linux
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 129819 at 56ea61d8 run on aarch64-linux 1

2 packages built successfully:

rhythmbox (gnome.rhythmbox)
libdmapsharing

Patch is here: https://gitlab.gnome.org/GNOME/rhythmbox/-/merge_requests/12

@jtojnar Thanks a lot for the prompt review. I think that I have applied the changes that you requested.


Move the validUntil and timeZone properties up to the Schedule Definition

What would you like to be added:
Move the validUntil and timeZone properties up to the Schedule Definition.
So, instead of having this:
start:
  schedule:
    cron:
      expression: '* * * * *'
      validUntil: '01/01/2023 10:00 PM'

We would have this:
start:
  schedule:
    cron: '* * * * *'
    validUntil: '01/01/2023 10:00 PM'

In order to allow this:
start:
  schedule:
    interval: PT1M
    validUntil: '01/01/2023 10:00 PM'

Why is this needed:
There is no reason IMHO for not giving to an interval-based schedule the same control on expiration than a CRON-based schedule's.
As a matter of fact, there are use cases where one has to use interval-based schedules and still want the ability to define the date and time at which the schedule expires. This cannot be done out of the box with the current schema.

https://en.wikipedia.org/wiki/ISO_8601#Time_intervals

As discussed in today's weekly meeting, ISO 8601 already provide a way to specify an end date.


fix deserialize issue

Codecov Report

Merging #228 (2c51411) into main (98b89b7) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   19.91%   19.90%   -0.01%
==========================================
  Files         208      208
  Lines       27141    27144       +3
==========================================
  Hits         5404     5404
- Misses      21737    21740       +3

Flag
Coverage Δ

gsagh
19.90% <0.00%> (-0.01%)
:arrow_down:

integration
∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../Components/GraveyardComp/EditMember1d_OBSOLETE.cs
0.00% <0.00%> (ø)

.../Components/GraveyardComp/EditMember2d_OBSOLETE.cs
0.00% <0.00%> (ø)

.../Components/GraveyardComp/EditMember3d_OBSOLETE.cs
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Disable SSL.

Disable SSL till proper SSL certificate is configured.

Repeat the following per solution project if option is available (screenshot is attached for reference).

right click on project
click "Properties"
click "Debug"
scroll to "Web Server Settings"
uncheck "Enable SSL"
close tab
republish


[iOS][0.27.2] Unable to resolve module emptyFunction from SwipeableRow

I'm use import like this:

import SwipeableListView from 'react-native/Libraries/Experimental/SwipeableRow/SwipeableListView';

or

import SwipeableListView from 'SwipeableListView';

Throw error:

Unable to resolve module emptyFunction from /Users/xxx/node_modules/react-native/Libraries/Experimental/SwipeableRow/SwipeableRow.js: Unable to find this module in its module map or any of the node_modules directories under /Users/node_modules/emptyFunction and its parent directories

See http://stackoverflow.com/questions/37489145/react-native-how-to-import-use-rc-experimental-components-i-e-swipeablerow/37709143#37709143

@facebook-github-bot answered

Closing this issue as @janicduplessis says the question asked has been answered. Please help us by asking questions on StackOverflow. StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only.


install RBAC api in federation-apiserver

 Issue by zhouhaibing089
Tuesday Mar 21, 2017 at 07:47 GMT
Originally opened as https://github.com/kubernetes/kubernetes/issues/43433

RBAC has been in beta since v1.6, and I think we should enable this apigroup in federation-apiserver, too.
Per this document: https://docs.google.com/document/d/1O2SEr_TDtgXzndh5lHPuAZmT-haylB9NaBRSo4DsUdk/edit#, RBAC was not enabled due to that it was still alpha at that time.
cc @nikhiljindal

 Comment by nikhiljindal
Tuesday Apr 11, 2017 at 23:22 GMT

Yes we do want to support RBAC with federation.
cc @kubernetes/sig-federation-feature-requests

 Comment by quinton-hoole
Friday Apr 14, 2017 at 22:45 GMT

As per my comments in the doc, I think that there are two separate questions here:

Do we want to support RBAC on Federated API objects (e.g. "is Alice allowed to create Federated ReplicaSets in namespace X?". I think that the answer is yes, but not in v1.7.
Do we want to Federate RBAC? (e.g. "reliably propagate this RBAC rule/user/whatever to all or a subset of federated clusters"). Again, I think that the answer is yes, but not in v1.7.

 Comment by nikhiljindal
Tuesday Apr 18, 2017 at 19:33 GMT

Yes for both.
If someone is willing to work on it then I dont mind getting it in 1.7 as well (as alpha, disabled by default)

 Comment by ericchiang
Tuesday Apr 25, 2017 at 18:13 GMT

A note from the auth side. The credentials that federation uses to talk to the underlying cluster with will need the powers that encompass the roles and bindings it creates. E.g. you want to create a rolebinding that grants a user "admin", the federation control plane will need at least "admin" in that context. Setups will either need to give federation a lot of power on the underlying cluster, or have federation only be able to manage a small subset of roles.
I could see this feature being extremely useful for managing pod API access. I'd probably not recommend using it to manage user access.
cc @kubernetes/sig-auth-feature-requests

 Comment by deads2k
Tuesday Apr 25, 2017 at 18:21 GMT

E.g. you want to create a rolebinding that grants a user "admin", the federation control plane will need at least "admin" in that context.

We also check the bind verb on the role or clusterrole being bound to allow more narrow permissions.  Obviously it would allow an escalation path, but it helps limit some classes of bugs.

 Comment by smarterclayton
Tuesday Apr 25, 2017 at 23:04 GMT

The current thought is that federation should be able to grant roles on the underlying cluster, but that's still being discussed.

cc @zhouhaibing089


KOGITO-9571: "quarkus convert" command is broken on KN CLI due to KogitoDataIndexInMemory not being part of RHBQ registry

🍣


concourse: consume local-users from k8s secret

instead of directly from helm chart. k8s secret will use the chart value
as a default, so functionality is not lost

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #8098

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

Wouldn't this also need to update templates/secrets.yaml ?

@chrishiestand Cheers- thats clearer :)
FYI, you may need to read https://www.helm.sh/blog/helm-dco/index.html to pass the DCO/dco-labler checks.

Thanks @matthope, I didn't even know DCO was a standard thing. Fixed.

/ok-to-test

@chrishiestand please resolve conflicts / chart version bump and you could be next!

/lgtm

/lgtm


Null genotypes missing GT_CONF_PERCENTILE value

I have a multisample VCF from minos v0.5.1 where some samples are missing the GT_CONF_PERCENTILE field. It seems to only be on samples with a null genotype (./.) An example of the INFO string
GT:DP:COV:GT_CONF:GT_CONF_PERCENTILE:STATUS

and an example incorrect sample entry
./.:0:0,0:0.0:FAIL

Hey @mbhall88 , using the latest version of minos (0.9.1; your issue uses to 0.5.1 from 18th March), this problem is no longer present.
Meaning that a './.' GT field leads to no GT_CONF_PERCENTILE field, as per https://github.com/iqbal-lab-org/minos/blob/30e526e4652a96c41391072aa3304409807a310e/minos/adjudicator.py#L187-L188
An example FORMAT field on data I worked on today: DP:GT:COV:GT_CONF       0:./.:0,0:0.0
OK to close?

no - it turns out a VCF needs to have the same things in all the FORMAT fields - which from my point of view is craxy - might as well have it in the header.
i think we will need, for downstream people, to just have a GT_CONF_PERCENTILE of 0 when there is no call, and just ignore it. i prefer our current behaviour in terms of logic, but it breaks too many tools

i think that was a race condition between @mbhall88 and me

I see. That is strange that FORMAT should be the same across records seems to defy the point.
Maybe have '.' rather than '0' for no calls though?

I think this would cause an issue as the field is likely defined as a number?

yes i think it has to be the right type


Upgrade to VMA 2.3.0 (2019-12-04)

Thank you very much for this wrapper.
I have tested it with the latest version of VMA (2.3.0) and found out that it does not work. For example the struct VmaAllocatorCreateInfo in the latest version of VMA has 2 additional fields:
VkInstance instance;
uint32_t vulkanApiVersion;
It would be great if you could upgrade it to the latest version.
Otherwise, I can do that and prepare a pull request. But before I can do that I would ask you to tell me which version of VMA you were using for this wrapper - this way I will be able to do a diff between two versions of vk_mem_alloc.h files and then update the wrapper accordingly.

Hi, glad you found this helpful!
Looking back through the history (most importantly this PR which enabled building VMA as a dynamic library on Windows) it looks like I was using a 2.3.0 development version. You might be able to run a diff on the files from that PR to see exactly what I was using. Hopefully there aren't too many changes required. I haven't touched the code in ages but I'd be happy to accept a PR. 🙂


Trouble paginating grouped query

Hello, I've found that pagination fails with a query that includes a group_by, it looks like the pagination is calculated without doing this grouping, so the number of pages is greater than expected (and the extra pages are therefore empty).
For example, this query without the group_by will result in 9 pages in my project:
issues = from(i in Issue,
  where: i.project_id == ^project.id) |> Repo.paginate(params)

But if I group the issues, then although only 1 page of results should be available, I still see 9 pages:
issues = from(i in Issue,
  where: i.project_id == ^project.id,
  select: %{ sample_id: min(i.id),
             type: i.type,
             sub_type: i.sub_type,
             message: i.message,
             how_many: count("*") },
  group_by: [i.type, i.sub_type, i.message],
  order_by: [:type, desc: count("*")]) |> Repo.paginate(params)

This is using  phoenix 1.2.0, scrivener_ecto 1.1, scrivener_html 1.4

Thank you, will try to find the way to fix this. In the meantime I'm using scrivener_list to paginate the results instead.

@jaimeiniesta thanks! Take a look at https://github.com/drewolson/scrivener_ecto/issues/14 as well, it may be quasi-related.

I believe 62681ff73954846370ee41047d0a349c530b3d8b will fix this.

Thank you but I'm afraid this introduced new issues. This query worked OK on scrivener_ecto 1.1.0 but fails in 1.1.2:
    sitemaps = from(s in Sitemap,
      join: w in WebPage,
      on: w.sitemap_id == s.id,
      where: [user_id: ^(conn.assigns.current_user.id)],
      group_by: [s.id],
      order_by: [desc: :inserted_at],
      select: { s.id,
                s.url,
                count(w.id),
                sum(w.errors_count),
                sum(w.warnings_count),
                s.inserted_at }) |> Repo.paginate(params)

The error message says:
** (Ecto.QueryError) subquery can only select sources (t) or fields (t.field), got: count(&1.id()) in query:
And if I removed this count(w.id) from the select, then:
** (Ecto.QueryError) subquery can only select sources (t) or fields (t.field), got: sum(&1.errors_count()) in query:

I'm pushing a fix for this now, will be released soon. Thanks for the report!

This is now fixed in 1.1.3 and released.


When swapping themes (in Tokens UI) Figma autolayout spec 'Space Between' flips to 'Packed'

Describe the bug
Upon swapping themes to specified components ('Apply to selection' in tokens UI), the application itself flips Figma autolayout spec 'Space Between' to 'Packed'.
To Reproduce
Steps to reproduce the behavior:

'Apply to Selection' in Tokens UI
Select a Component on Figma Canvas
Swap themes in Tokens UI
See error

Expected behavior
I only am swapping color themes, so expecting only colors to swap, not spacing attributes.  Both themes use the same 'Spacing' tokens.
Screenshots or Screencasts

In screenshot - 'Light theme' is the default theme, when flipping the second line to 'dark theme,' the error occurs.

Can you make sure there's no spacing token applied on that layer? That behaviour only appears when there's a spacing token applied on auto layout layers currently.
Best to include a screenshot of the Inspect tab with Deep inspect on and one of those card layers selected.


Add a secondary CI/CD engine to LCCI

Currently the repo is being vuilt by ci.librecores.org. While it is good to build CI systems by themselves, it is nice to have a backup plan if something goes wrong. I suggest we have a build on Travis or other CI system as Plan B

I;d guess it would be GitHub Actions now


Try to productise docker-compose setup

Would this be OK for you @alexmojaki ?

Doesn't seem to work:
➜  opensanctions git:(pudo/fixup) make shell
docker-compose up -d postgres redis
Starting opensanctions_postgres_1 ... done
Starting opensanctions_redis_1    ... done
sleep 3
docker-compose run worker sh
Starting opensanctions_postgres_1 ... done
Starting opensanctions_redis_1    ... done
/memorious # memorious run un_sc_sanctions
Traceback (most recent call last):
  File "/usr/bin/memorious", line 11, in <module>
    load_entry_point('memorious', 'console_scripts', 'memorious')()
  File "/memorious/memorious/cli.py", line 110, in main
    cli(obj={})
  File "/usr/lib/python3.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python3.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python3.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/memorious/memorious/cli.py", line 48, in run
    TaskRunner.run_sync()
  File "/memorious/memorious/task_runner.py", line 58, in run_sync
    for task in Queue.tasks(stop_on_timeout=True):
  File "/memorious/memorious/model/queue.py", line 27, in tasks
    yield (job_stage.operation, state, load_json(data))
AttributeError: 'JobStage' object has no attribute 'operation'
/memorious # memorious run us_ofac
Traceback (most recent call last):
  File "/usr/bin/memorious", line 11, in <module>
    load_entry_point('memorious', 'console_scripts', 'memorious')()
  File "/memorious/memorious/cli.py", line 110, in main
    cli(obj={})
  File "/usr/lib/python3.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python3.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python3.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/memorious/memorious/cli.py", line 48, in run
    TaskRunner.run_sync()
  File "/memorious/memorious/task_runner.py", line 58, in run_sync
    for task in Queue.tasks(stop_on_timeout=True):
  File "/memorious/memorious/model/queue.py", line 27, in tasks
    yield (job_stage.operation, state, load_json(data))
AttributeError: 'JobStage' object has no attribute 'operation'

Otherwise this seems to work now, thank you! If we could merge it that would be great.


simillarity value

@View12138
How much similarity should be so
Confirm the similarity of the two photos ???
0.65 or higher ??
in this function :
float similarity = viewFace.Similarity(oldEigenValues, newEigenValues);

bool isSelf = viewFace.IsSelf(similarity);


Is this method suitable for 3DScene? example,  a room

I try, but get a bad result.

Hi,
We have not tried it, but I do not think it can work as well as our object-level reconstruction results. One main reason is the limited resolution of the indicator grid. Another reason is, for the learning-based pipeline, we only trained on the ShapeNet object, not indoor scene dataset like this synthetic indoor scene dataset. If you can train on that, I believe you can have better results.
Best
Songyou


Using name "Dispatch" in app.json with eas build -p ios fails. A different name on same project creates the build with no error.

Build/Submit details page URL
https://expo.dev/accounts/dispatch-inc/projects/dispatch-mobile-app/builds/8365d82e-98a8-4058-b379-1d9fc4417d8a
Summary
When I name my app "dispatch." and run EAS Build, it creates a build but when I use the same code and only change app name to "Dispatch" in app.json and try to create a build with eas-cli it fails on Run Fastlane step.
P.S. In my opinion the "Dispatch" module in expo-modules-core/iOS/AppDelegate ExpoAppDelegate.swift line#2 might be creating a conflict with the app name and causing the build to fail.
Managed or bare?
Managed
Environment
expo-env-info 1.0.5 environment info:
System:
OS: macOS 12.3
Shell: 5.8 - /bin/zsh
Binaries:
Node: 16.15.1 - /usr/local/bin/node
Yarn: 1.22.15 - /usr/local/bin/yarn
npm: 8.11.0 - /usr/local/bin/npm
Managers:
CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
IDEs:
Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
npmPackages:
expo: ^46.0.0 => 46.0.20
react: 18.0.0 => 18.0.0
react-native: 0.69.6 => 0.69.6
npmGlobalPackages:
eas-cli: 3.4.1
expo-cli: 5.4.12
Expo Workflow: managed
✔ Found all copies of expo-modules-autolinking
All copies of expo-modules-autolinking satisfy ~0.10.1
✔ Found all copies of @expo/config-plugins
All copies of @expo/config-plugins satisfy ^5.0.0
✔ Found all copies of @expo/prebuild-config
All copies of @expo/prebuild-config satisfy ^5.0.1
🎉 Didn't find any issues with the project!
Error output
758
› Executing expo-updates Pods/EXUpdates » Copy generated compatibility header
759
› Compiling Pods/Pods-Dispatch » Pods-Dispatch-dummy.m
760
› Packaging Pods/Pods-Dispatch » libPods-Dispatch.a
761
› Executing Dispatch » [CP] Check Pods Manifest.lock
762
› Executing Dispatch » Start Packager on http://localhost:8081
763
› Compiling Dispatch » ExpoModulesProvider.swift
764
❌  (ios/Pods/Target Support Files/Pods-Dispatch/ExpoModulesProvider.swift:8:8)
6 |  */
7 |
>  8 | import ExpoModulesCore
|        ^ circular dependency between modules 'Dispatch' and 'ExpoModulesCore'
9 | import EASClient
10 | import ExpoImagePicker
11 | import ExpoKeepAwake
765
› Compiling Dispatch » noop-file.swift
766
❌  (ios/Pods/Target Support Files/Pods-Dispatch/ExpoModulesProvider.swift:8:8)
6 |  */
7 |

8 | import ExpoModulesCore
|        ^ circular dependency between modules 'Dispatch' and 'ExpoModulesCore'
9 | import EASClient
10 | import ExpoImagePicker
11 | import ExpoKeepAwake
767

❌  (ios/Pods/Target Support Files/Pods-Dispatch/ExpoModulesProvider.swift:8:8)
6 |  */
7 |

8 | import ExpoModulesCore
|        ^ circular dependency between modules 'Dispatch' and 'ExpoModulesCore'
9 | import EASClient
10 | import ExpoImagePicker
11 | import ExpoKeepAwake
768

❌  error: emit-module command failed with exit code 1 (use -v to see invocation)
769
▸ ** ARCHIVE FAILED **
770
▸ The following build commands failed:
771
▸ 	CompileSwift normal arm64 /Users/expo/workingdir/build/ios/Pods/Target\ Support\ Files/Pods-Dispatch/ExpoModulesProvider.swift (in target 'Dispatch' from project 'Dispatch')
772
▸ 	CompileSwift normal arm64 /Users/expo/workingdir/build/ios/Dispatch/noop-file.swift (in target 'Dispatch' from project 'Dispatch')
773
▸ 	EmitSwiftModule normal arm64 (in target 'Dispatch' from project 'Dispatch')
774
▸ 	CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler (in target 'Dispatch' from project 'Dispatch')
775
▸ (4 failures)
776
2023-02-01 00:28:22.571 xcodebuild[4453:12614] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionSentinelHostApplications for extension Xcode.DebuggerFoundation.AppExtensionHosts.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
777
2023-02-01 00:28:22.571 xcodebuild[4453:12614] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
778
2023-02-01 00:28:22.604 xcodebuild[4453:12614] XType: failed to connect - Error Domain=NSCocoaErrorDomain Code=4099 "The connection to service named com.apple.fonts was invalidated: failed at lookup with error 3 - No such process." UserInfo={NSDebugDescription=The connection to service named com.apple.fonts was invalidated: failed at lookup with error 3 - No such process.}
779
2023-02-01 00:28:22.605 xcodebuild[4453:12614] Font server protocol version mismatch (expected:5 got:0), falling back to local fonts
780
2023-02-01 00:28:22.605 xcodebuild[4453:12614] XType: unable to make a connection to the font daemon!
781
2023-02-01 00:28:22.605 xcodebuild[4453:12614] XType: XTFontStaticRegistry is enabled as fontd is not available.
782
** ARCHIVE FAILED **
783
784
785
The following build commands failed:
786
CompileSwift normal arm64 /Users/expo/workingdir/build/ios/Pods/Target\ Support\ Files/Pods-Dispatch/ExpoModulesProvider.swift (in target 'Dispatch' from project 'Dispatch')
787
CompileSwift normal arm64 /Users/expo/workingdir/build/ios/Dispatch/noop-file.swift (in target 'Dispatch' from project 'Dispatch')
788
EmitSwiftModule normal arm64 (in target 'Dispatch' from project 'Dispatch')
789
CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler (in target 'Dispatch' from project 'Dispatch')
790
(4 failures)
791
Exit status: 65
792
793
+-------------+-------------------------+
794
|           Build environment           |
795
+-------------+-------------------------+
796
| xcode_path  | /Applications/Xcode.app |
797
| gym_version | 2.206.1                 |
798
| sdk         | iPhoneOS15.5.sdk        |
799
+-------------+-------------------------+
800
Looks like fastlane ran into a build/archive error with your project
801
It's hard to tell what's causing the error, so we wrote some guides on how
802
to troubleshoot build and signing issues: https://docs.fastlane.tools/codesigning/getting-started/
803
Before submitting an issue on GitHub, please follow the guide above and make
804
sure your project is set up correctly.
805
fastlane uses xcodebuild commands to generate your binary, you can see the
806
the full commands printed out in yellow in the above log.
807
Make sure to inspect the output above, as usually you'll find more error information there
808
809
[stderr] [!] Error building the application - see the log above
810
Error: Fastlane build failed with unknown error. See logs for the "Run fastlane" and "Xcode Logs" phases for more information.
Fastlane errors in most cases are not printed at the end of the output, so you may not find any useful information in the last lines of output when looking for an error message.
Reproducible demo or steps to reproduce from a blank project

Create a blank project
Use name "Dispatch" as app name in app.json (This is the reason behind build fail)
configure other required app.json properties for IOS these are not causing the issue.
create iOS build with EAS CLI

I think I am right that ExpoAppDelegate.swift file has conflict with my app name because there are 3 module imports in expo-modules-core/iOS/AppDelegate ExpoAppDelegate.swift
import UIKit
import Dispatch
import Foundation
I tried Dispatch as app name and build failed.  for which I created this issue.
Now I tried Foundation as app name and build failed again with following error in fast lane step
Packaging Pods/Pods-Foundation » libPods-Foundation.a
763
› Executing Foundation » [CP] Check Pods Manifest.lock
764
› Executing Foundation » Start Packager on http://localhost:8081
765
› Compiling Foundation » noop-file.swift
766
› Compiling Foundation » ExpoModulesProvider.swift
767
❌  error: emit-module command failed with exit code 1 (use -v to see invocation)
768
▸ ** ARCHIVE FAILED **
769
▸ The following build commands failed:
770
▸ 	CompileSwift normal arm64 /Users/expo/workingdir/build/ios/Foundation/noop-file.swift (in target 'Foundation' from project 'Foundation')
771
▸ 	CompileSwift normal arm64 /Users/expo/workingdir/build/ios/Pods/Target\ Support\ Files/Pods-Foundation/ExpoModulesProvider.swift (in target 'Foundation' from project 'Foundation')
772
▸ 	EmitSwiftModule normal arm64 (in target 'Foundation' from project 'Foundation')
773
▸ 	CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler (in target 'Foundation' from project 'Foundation')
774
▸ (4 failures)


Poor styling on dragged item in tree view

When a user is dragging an item in the tree view, it shows up in a style that doesn't match the page, with the wrong font and everything.  Style on the dragged element should match the one on the original.

(Screen shot is dark because I had to pause the script in a debugger to grab a screenshot.  But you can still see it.)


Unable to enter 2FA OTP in frodo conn add

Frodo CLI version
Provide output of frodo -v
You are running the NPM package.
Installed versions:
cli: v2.0.0-55
lib: v2.0.0-64
node: v20 11.1
Describe the issue
$ frodo conn add https://my tenant.id.forgerock.io/am<EMAIL_ADDRESS>"$PW"
2FA is enabled and required for this user...
I never get the 2FA prompt. I cannot continue to add connection.

@jgdtech what type of MFA have you configured for your admin? Frodo only supports OTP, not WebAuthN. However, there should be a prompt telling you that, so either way there is something wrong and I have to check if the admin MFA journeys have changed in ID Cloud.
I've been considering adding browser support to Frodo so we could support any login journey thrown at us but we haven't had the bandwidth to do that, yet.

OTP via ForgeRock Authenticator app.
On Tue, Apr 16, 2024, 18:36 Volker Scheuber @.***>
wrote:

@jgdtech https://github.com/jgdtech what type of MFA have you
configured for your admin? Frodo only supports OTP, not WebAuthN. However,
there should be a prompt telling you that, so either way there is something
wrong and I have to check if the admin MFA journeys have changed in ID
Cloud.
I've been considering adding browser support to Frodo so we could support
any login journey thrown at us but we haven't had the bandwidth to do that,
yet.
—
Reply to this email directly, view it on GitHub
https://github.com/rockcarver/frodo-cli/issues/385#issuecomment-2060119379,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXBIWLBNDZ6U7LQJBUEPNDY5W7Y5AVCNFSM6AAAAABGKIJ4IKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRQGEYTSMZXHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hm... I just tested that a couple of weeks ago. Can you test with frodo info command? It should work like this:
% frodo info volker-dev<EMAIL_ADDRESS>'F@m4Rdev3MEehrvs'
Multi-factor authentication is enabled and required for this user.
Enter verification code: 284271
Connected to https://openam-volker-dev.forgeblocks.com/am [alpha] as user<EMAIL_ADDRESS>...

I do remember fixing something, though, in a recent version, so make sure you are running close to the latest:
% frodo -v
You are running the NPM package.
Installed versions:
cli: v2.0.0-55
lib: v2.0.0-77
node: v20.5.1

@jgdtech  something is off with you library version... as a matter of fact, I am surprised anything works with the mismatch between cli and lib versions. CLI 2.0.0-55 requires LIB 2.0.0-77. You are somehow stuck on 2.0.0-64 for library, which is too old and quite a few commands may break because of it.

On my Windows host with git bash, I removed node_modules folder then reinstalled. npm i; npm run build:local; npm i -g; frodo -v
cli: v2.0.0-55
lib: v2.0.0-77
node: v20.11.1
But frodo conn add tells me "Multi-factor authentication is enabled and required for this user." Yet I never get the next prompt on Windows that I do see on my phone:
Multi-factor authentication is enabled and required for this user.
Enter verification code:
I never get that Enter verification code: prompt on Windows. It's been sitting there for a good 5 minutes. :(

@jgdtech that is troublesome! Looks like a platform specific issue. I develop on MacOS and while we run our unit tests across all platforms, we don't have test automation (yet) for the MFA prompt. I'll test in my Windows VM and see if I can reproduce what you are seeing.
Out of curiosity: Would you mind running the following command (using your own tenant of course) and see if you get the confirmation prompt on Windows?:
% frodo journey prune volker-dev
Connected to https://openam-volker-dev.forgeblocks.com/am [alpha] as service account Frodo-SA-1712175401543 [eb108b7a-e039-40bc-9764-84bed891fee1]
✔ 1314 total nodes
✔ 1216 active nodes
✔ 98 orphaned nodes
Prune (permanently delete) orphaned nodes? (y|n): n
%

I get at end of the prune command:
0 orphaned nodes
No orphaned nodes found.
On Wed, Apr 17, 2024, 10:52 Volker Scheuber @.***>
wrote:

@jgdtech https://github.com/jgdtech that is troublesome! Looks like a
platform specific issue. I develop on MacOS and while we run our unit tests
across all platforms, we don't have test automation (yet) for the MFA
prompt. I'll test in my Windows VM and see if I can reproduce what you are
seeing.
Out of curiosity: Would you mind running the following command (using your
own tenant of course) and see if you get the confirmation prompt on
Windows?:
% frodo journey prune volker-dev
Connected to https://openam-volker-dev.forgeblocks.com/am [alpha] as service account Frodo-SA-1712175401543 [eb108b7a-e039-40bc-9764-84bed891fee1]
✔ 1314 total nodes
✔ 1216 active nodes
✔ 98 orphaned nodes
Prune (permanently delete) orphaned nodes? (y|n): n
%
—
Reply to this email directly, view it on GitHub
https://github.com/rockcarver/frodo-cli/issues/385#issuecomment-2061754097,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXBIWLF7N3VJSVZI5ZH57DY52SFBAVCNFSM6AAAAABGKIJ4IKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRG42TIMBZG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

@jgdtech I tried to reproduce on Windows with the latest build but it appears to be working fine for me. I know your setup was slightly special due to git bash but I don't see a way to dupe this.
It could also be that some of our recent changes have remedied the issue.
frodo conn save https://openam-volker-dev.forgeblocks.com/am<EMAIL_ADDRESS>"5up3r53cr3t!"
Multi-factor authentication is enabled and required for this user.
Enter verification code: 141420
Connected to https://openam-volker-dev.forgeblocks.com/am [alpha] as user<EMAIL_ADDRESS>Created and added service account Frodo-SA-1718847016944 with id d2a50830-d6f4-4dec-a0a2-986cc5956ab7 to profile.
Created log API key 9935d058460a608e9eace73109592293 and secret.
Saved connection profile https://openam-volker-dev.forgeblocks.com/am

Closing for now, please re-open if you are still struggling with this.


Slash Command Alternatives to Context Menus

Describe your feature request
Introduce a slash command alternative to context menus for mobile users.
Ease of access could entail creation of select menu prompting the user with an action they may wish to take on a message.
Example Usage
/interact <messageId>

Bot displays ephemeral message with dropdown menu

Upvote
Downvote
Flag
Convert to Answer
Convert to Question
etc

v0.1 removed this functionality.


How do I config ylt with fetch content?

Search before asking

[x] I searched the issues and found no similar issues.

What happened + What you expected to happen
Hi, I am using ylt in a project. And the way I import ylt is by fetch content.
include(FetchContent)
FetchContent_Declare(
    yalantinglibs
    GIT_REPOSITORY https://github.com/yhyu13/yalantinglibs.git
    GIT_TAG 679cbac8f3c5566a842c91b9d332632d3076f6ac
    GIT_SHALLOW 1 # optional ( --depth=1 )
)
FetchContent_MakeAvailable(yalantinglibs)

I found severl config flag interesting https://github.com/alibaba/yalantinglibs/blob/main/cmake/config.cmake
How do I enable these flag options in my build with the way fetch content work?
Do these flags taken effect simply by truning them to ON, and leave everything else to CMAKE? Then I should probably make a cl to my fork repo that turn these flag on
Reproduction way
Anything else
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Can you look at this PR: https://github.com/alibaba/yalantinglibs/pull/519
maybe helpful for you.

@qicosmos
It seems config.cmake is only included when compiling yalantinlibs as the promary project, the config.cmake is never toched on fetch content, only install.cmake is executed https://github.com/alibaba/yalantinglibs/blob/a920fce8b0d7b6a3a42e459c17ee5b9925d5a2ff/CMakeLists.txt#L17

Ok, here is my solution
include(FetchContent)
Set(FETCHCONTENT_QUIET FALSE)
FetchContent_Declare(
    yalantinglibs
    GIT_REPOSITORY https://github.com/yhyu13/yalantinglibs.git
    GIT_TAG 679cbac8f3c5566a842c91b9d332632d3076f6ac
    GIT_SHALLOW 1 # optional ( --depth=1 )
    GIT_PROGRESS TRUE
    SYSTEM
)
FetchContent_MakeAvailable(yalantinglibs)
target_compile_definitions(yalantinglibs INTERFACE YLT_ENABLE_PMR IGUANA_ENABLE_PMR ENABLE_STRUCT_PACK_OPTIMIZE)
target_link_libraries(Common PUBLIC yalantinglibs::yalantinglibs)

If you wan to use uring on linux, you need add compile defintion ASIO_HAS_IO_URING ASIO_HAS_FILE YLT_ENABLE_FILE_IO_URING and manully target_link_libary with uring

I will leave this issue open, may be consider adding more config cmake options for devs who use fetch content for easier configuration?

Maybe we can export config.cmake to user. but some options' name should be changed to avoid conflict with user defined option. And I'll add some description to document later.

@yhyu13 hi, I test fetch content on my MacOS 13, it work fine
the highlight cmake config maybe
# change ylt_cmake_fetch to your own target name
target_link_libraries(ylt_cmake_fetch PRIVATE yalantinglibs)

the following is detail information about my demo

cmake config

cmake_minimum_required(VERSION 3.28)
project(ylt_cmake_fetch)

set(CMAKE_CXX_STANDARD 20)
include(FetchContent)
FetchContent_Declare(
        yalantinglibs
        GIT_REPOSITORY https://github.com/alibaba/yalantinglibs.git
        GIT_TAG a920fce8b0d7b6a3a42e459c17ee5b9925d5a2ff # the least commit id
        GIT_SHALLOW 1 # optional ( --depth=1 )
)
FetchContent_MakeAvailable(yalantinglibs)
add_executable(ylt_cmake_fetch main.cpp)
target_link_libraries(ylt_cmake_fetch PRIVATE yalantinglibs)

c++ code

#include <iostream>
#include <ylt/struct_pack.hpp>

struct Foo {
    int x;
};

int main() {
    std::cout << "Hello, World!" << std::endl;
    Foo foo{.x = 100};
    auto buf = struct_pack::serialize(foo);
    auto ret = struct_pack::deserialize<Foo>(buf);
    if (ret) {
        std::cout << "use struct_pack success" << std::endl;
        std::cout << "foo.x is " << ret->x << std::endl;
    }
    else {
        std::cout << "Error: " << std::endl;
    }
    return 0;
}

output

Hello, World!
use struct_pack success
foo.x is 100


{python3.pkgs.pybind11, cdrtools, nix}: disable fortify hardening on musl

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

FWIW I think it'd be fine to cause the rebuilds as long as this went to staging, where these packages will almost certainly get rebuilds anyway.

Going through staging means I have to wait for the next staging cycle though, and the rebuilds are entirely unnecessary ;)

Well, mkderivation doesn't seem to like null in this context, guessing the only way to avoid a rebuild would be to do a // optionalAttrs isMusl { hardeningDisable = [...]; } which is super ugly.

Incidentally, this made me look into the case where the nix build was failing - looks like it fails when code tries to get a function pointer for vsnprintf, which is of course impossible with "always_inline". So there are clearly some cases which will never work properly with fortify-headers' approach.

Well, mkderivation doesn't seem to like null in this context

Right, this works for other attributes, but not hardeningDisable.
Changed it back to lib.optional and changed the base to staging.


Select-String: Add OnlyMatching parameter to return only the actual matching value

PR Summary
PR Context
Issue #7712 wanted a -OnlyMatching switch to allow Select-String to only return the text that matched rather than either the full MatchInfo object (default behaviour) or the Line (-Raw behaviour). This is the initial implementation of that.
The issue does suggest allowing this switch to avoid the primary code path that creates the MatchInfo objects in the first place to improve performance since they aren't actually used in the output at all, I'd like to add that functionality but it's a bit beyond my abilities right now but I'll look into it and see if I can add that in either before this PR is merged or in a future PR if the team feels it's a needed improvement.
I had thought to add a parameter set for this new parameter since it doesn't make sense to be able to use both -Raw and -OnlyMatching but that broke parameter binding in a way I didn't expect and wasn't able to see why it would. I can add that back in as part of this PR and try to resolve it should it be required.
PR Checklist

[X] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[X] Summarized changes
[X] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[X] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[x] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

@PoshChan please retry Linux

@vexx32, successfully started retry of PowerShell-CI-Linux

I know the -OnlyMatching name was specified by the committee, but it feels very awkward to me in comparison to some cmdlets; Get-ChildItem doesn't have a -OnlyName switch, it's just -Name
Personally I feel like something along the lines of -OnlyMatch would be a little less out of place, or even just -Matches might be OK (though I'm a little wary of that, if only because it aligns too well with the [regex]::Matches() method, which returns full objects).
What do you guys think, @SteveL-MSFT? 🙂

On other thing to implement:
-OnlyMatching should be mutually exclusive with -SimpleMatch, because in the latter case the matching parts of the lines are currently not captured at all, right? At least they don't show up in the output objects.
Note that, similarly, the currently permitted but pointless combination of -SimpleMatch and -AllMatches should be prevented - see #11091


Angular password reset link not routed correctly

With the angular boilerplate, there are errors with the password reset functionality.

The reset password angular controller calls the Account.forgotPassword() instead of Account.resetPassword()
The resetPassword function on the account service tries to call '/reset', but on the server the only valid route is '/reset/:token'

This is not working as it is currently structured and needs to be refactored to call the right function and pass the token from the server to the browser.
In my application I built from this, I ended up taking the password reset as a query param in angular and then passing that to '/reset/:token' on the server because it was easier.
I am happy to make the change, but with the refactor being done with #109, this would make sense to combine with that effort or wait until the refactor is complete.

I fixed both issues, however, there seems to be another bug which has been overlooked. When password has been reset successfully it calls Passport's logIn function which doesn't apply to React/Angular apps:
user.save(function(err) {
  req.logIn(user, function(err) {
    done(err, user);
  });
});


New component for Sector Alarm

Description:
New component for Sector Alarm temperature sensor and alarm panel.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9022
Example entry for configuration.yaml (if applicable):
sector_alarm:
  email<EMAIL_ADDRESS>  password: Password
  alarm_id: 012345678
  code: 1234

Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[X] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[X] New dependencies have been added to the REQUIREMENTS variable (example).
[X] New dependencies are only imported inside functions that use them (example).
[X] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[X] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @peroyvind,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Recent changes to sector-api causes your lib to break, check PR I made to another lib used by custom-component:
https://github.com/mgejke/asyncsector/pull/4
Lib should probably be updated, or use a different lib?

This PR seems to have gone stale. Closing it.