openssh: 8.1p1 -> 8.2p1

Motivation for this change

https://www.openssh.com/txt/release-8.2
add libfido2 to enable hardware tokens support added in this release

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

eval problems seem unrelated to the package, but maybe @mmahut can confirm?

@GrahamcOfBorg build openssh

I just realized that gssapi patchset does not apply and we need to wait until the package is updated the debian (where we fetch the gssapi patch from).

Or just disable the gssapi patchset. I don't think that should be a blocker for updating ssh.

I added another change in 464890f which keeps version 8.1p1 for openssh_gssapi. I kept openssh_hpn for now, because it was fixed by version update in 025217a.
If there is a reason to drop the hpnSupport completely because no one uses it, I can amend my
changes, but it seems it's not really required as it builds for now and the upstream seems active too.

@GrahamcOfBorg eval

tested with fido2 and a titan security key, works like a charm :+1:

Can anyone help with the eval failure? I don't see what's wrong here ...

@prusnak can you please try to rebase on master?

@GrahamcOfBorg eval

@GrahamcOfBorg build libfido2 openssh

@GrahamcOfBorg build libfido2 openssh openssh_hpn openssh_gssapi

@GrahamcOfBorg build libfido2 openssh openssh_hpn openssh_gssapi

I had to fix the libfido2 on darwin, but afterward, it works!

It looks like libfido2 needs IOKit if you haven't fixed it yet

Debian team meanwhile updated the gssapi patch for 8.2p1 so I also bumped openssh_gssapi to this version.

@GrahamcOfBorg build libfido2 openssh openssh_hpn openssh_gssapi

@GrahamcOfBorg build openssh openssh_hpn openssh_gssapi

Once https://github.com/NixOS/nixpkgs/pull/80909 is merged I'll drop the optional stdenv.isLinux from libfido2 feature as this will be available on darwin too.

Since #80909 was just merged, I updated my PR to enable FIDO2 support for Darwin too (replaced optional stdenv.isLinux with optional stdenv.isUnix).

I'm unable to work out a suitable fix, but just so folks are aware:
IIRC openssh+libfido2 causes eval infinite loop on musl-based
configurations, by means of NetBSD tool trying to fetch its source
via our fetchcvs which has openssh injected.
I'm not sure how to best resolve this, I tried a few things but
ultimately ran out of time and rebuild-power so it's on my "revisit"
pile.
Maybe gitMinimal doesn't need fido-enabled openssh?

a144c0ef19ba51e24e436917683503c819e69449
(this helps via different route, maybe?)

Since netbsd CVS source doesn't need openssh AFAIK,
openssh-less fetchcvs and use it for these:

86c261db6d1eb2e7dd1471aa90e0ba6bdee45039

Or look at the problem and come up with a more coherent solution :).
Hope this helps, sorry can't tackle this myself for the next weeks :/.
On Mon, 24 Feb 2020 10:01:40 -0800, Pavol Rusnak<EMAIL_ADDRESS>wrote:

Since #80909 was just merged, I updated my PR to enable FIDO2 support for Darwin too (replaced optional stdenv.isLinux with optional stdenv.isUnix).
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/80196#issuecomment-590467946Non-text part: text/html

@GrahamcOfBorg build openssh openssh_hpn openssh_gssapi

This PR does need to add back a withFido2 option, which I think was in an earlier commit. I can't find it, but it should be in @prusnak's reflog. The option should probably default to stdenv.isUnix

@GrahamcOfBorg test openssh

I reintroduced the withFIDO option like suggested above by @artemist. However, there was no stdenv.isUnix attribute on my NixOS Linux system, so I used stdenv.hostPlatform.isUnix instead. Is that correct?

@GrahamcOfBorg test openssh

Given we need openssh 8.2 on the server side as well for these new features to work. I would like to propose to backport this into 20.03.

@mmahut should we just create a PR to 20.03 branch or what exactly is the process for proposing a backport?

We discussed the possibility of backporting openssh 8.2p1 in #nixos-dev

https://logs.nix.samueldr.com/nixos-dev/2020-02-27#3113587;

my feelings were well expressed in this comment https://logs.nix.samueldr.com/nixos-dev/2020-02-27#3113665;
A question that was raised that would make the determination easier if answered was "how long will 8.1 get security updates?".

@worldofpeace I'll ask among the OpenSSH folks what's their security update strategy is.

@worldofpeace answer from Damien Miller of OpenSSH: "We don't do backported security fixes - we're a tiny team and so only maintain the current release."

@worldofpeace answer from Damien Miller of OpenSSH: "We don't do backported security fixes - we're a tiny team and so only maintain the current release."

I guess this makes the decision easy :smile:

@prusnak Let's do it.

@worldofpeace Shall I prepare a PR? To which branch?

@worldofpeace Shall I prepare a PR? To which branch?

release-20.03

Backport created in https://github.com/NixOS/nixpkgs/pull/81368


Language: Theme -  AccentColor - Buttons

Hi there
The Buttons on the "Accent Color" Popup are not in english.
Thx!

same as https://github.com/HandyOrg/HandyWinGet/issues/30


feat(table): convert all tables to HTML and convey cell alignment

fixes #26
BREAKING CHANGE: simple md tables no longer remain markdown

@davidnuescheler should we turn the first row into a <th> ?

Don't you think that at this point we'd be better served with directives?

no. I looked at it again and discussed it with @davidnuescheler. we want to convey the structure of the document using the .md file, and not interpret too much semantics at this level. so the 4 options we have to include a rich table are:

html table
mixed html/markdown table (see #25)
grid-tables ala pandoc
something homegrown using directives.

with the directives we could do something like:
:::::table
::::tr
:::td{align="right"}
**Hello**,

_world_.
:::td
1. hello
2. world and a very long line.
:::::

the problems with this are:

nobody understands directives
the spec is IMO flawed such as the nesting of container elements is done with the matching of the colons :. so you need 5 : to close the :::::table container. this is highly unusable, as it doesn't allow for easy nesting.


git ssh push requires password?

Using the latest gitea version through docker hub, I have added my ssh key to gitea and I'm trying to push code to an empty repository using ssh. However gitea asks me for a password.
  gitea:
    image: gitea/gitea
    environment:
      - GITEA__server__PROTOCOL=http
      - GITEA__server__ROOT_URL=https://my.domain.xyz/
      - GITEA__service__DISABLE_REGISTRATION=1
      - GITEA__repository__DEFAULT_PRIVATE=private
    volumes:
      - ./data/gitea:/data
      - /etc/timezone:/etc/timezone:ro
      - /etc/localtime:/etc/localtime:ro
    ports:
      - '3003:3000'
      - '2222:22'
    networks:
      - public

Gitea is behind a Traefik edge router when it comes to http/https, however ssh is directly redirected to port 2222.
[server]
APP_DATA_PATH    = /data/gitea
DOMAIN           = my.domain.xyz
SSH_DOMAIN       = my.domain.xyz
HTTP_PORT        = 3000
ROOT_URL         = https://my.domain.xyz/
DISABLE_SSH      = false
SSH_PORT         = 2222
SSH_LISTEN_PORT  = 2222
LFS_START_SERVER = true
LFS_CONTENT_PATH = /data/git/lfs
PROTOCOL         = http
LFS_JWT_SECRET   = supersecretjasonwebtoken
OFFLINE_MODE     = false

[security]
INSTALL_LOCK                  = true
SECRET_KEY                    = mysecretkey
REVERSE_PROXY_LIMIT           = 1
REVERSE_PROXY_TRUSTED_PROXIES = *
INTERNAL_TOKEN                = supersecret.token.and-stufff
PASSWORD_HASH_ALGO            = superhash

[service]
DISABLE_REGISTRATION              = 1
REQUIRE_SIGNIN_VIEW               = false
REGISTER_EMAIL_CONFIRM            = false
ENABLE_NOTIFY_MAIL                = false
ALLOW_ONLY_EXTERNAL_REGISTRATION  = false
ENABLE_CAPTCHA                    = false
DEFAULT_KEEP_EMAIL_PRIVATE        = false
DEFAULT_ALLOW_CREATE_ORGANIZATION = false
DEFAULT_ENABLE_TIMETRACKING       = false
NO_REPLY_ADDRESS                  =

When using https everything works fine. Any obvious problems with my setup? Or did I hit some kind of bug?

Your SSH_LISTEN_PORT does not match your docker file.

@KN4CK3R thnx for the heads up! However it did not fix the problem, I still get asked for a password.


Add HTTPS to Odnoklassniki

For compatibility with sites which available by https.

👍

@Corey-Maler, thank you, good point! There’s a problem however: config.protocol already has a colon so concatenating it with '://connect.ok.ru' will result in 'https:://connect.ok.ru'. Could you please remove the colon in the URL?

@iamakulov done.

@Corey-Maler, also in odnoklassniki.js:10.

@iamakulov Done, thanks

Thank you!


Question/Possible improvement about the encoding option in the DataFrame.from_csv/2 function

The documentation for the function DataFrame.from_csv/2 is missing an explanation of the "encoding" option.
And even if this encoding option is passed, the code will only accept the "utf8-lossy" option, as any other string will be considered as "utf8": io.rs.
WDYT? Is it worth including this information in the DataFrame.from_csv/2 docs?

@Jhonatannunessilva unfortunately we can only accept the options provided by Polars. But you are right, we are missing docs around that! Please go ahead if you plan to open a PR for this! :D


Ability to display image or HTML depending on Content-Type of response

I have a website that displays photos submitted by the user.
When they upload a photo, I generate thumbnails immediately, but the generation of large versions of the photo happens asynchronously. So when I return a page of thumbnails, when the user clicks on a thumbnail I want them to be able to see the large image in a Featherlight box if it's ready, or a "sorry, try later" message in the box if it's not.
I have a script on the server that is loaded like /viewimage?i=123.
Initially I tried having that script return either the real image or a different image (with the "sorry" text encoded in that image), and setting data-featherlight-type to image, but then the result seems to be cached and won't be reloaded if the user clicks the thumbnail again.
So I tried having the viewimage script instead return either
Sorry...
 or  and set data-featherlight-type to ajax. That does basically what I want except that the image is now shown full size and isn't scaled in the Featherlight box to fit the browser window.
Is there a better way?
To me it would make sense if Featherlight could tell the content type from the header returned by my script, either text/html or image/jpeg, and display accordingly, rather than having to specify it upfront. Would that be easy to implement? Or is there another way that I'm missing?

Seems like an interesting problem, but I don't have time to help you out.
I don't see how we can modify featherlight easily.
Please ask this as a StackOverflow question.
Good luck.


CP-14538:  Ensure drivers set to bootstart start at boot time

It appears windows can 'forget' a driver is bootstart - so this ensures windows is told our bootstart drivers are also boot start.
We check drivers which are not bootstart in case a user (such as PVS) has set them to start at boot time

Formatting fixes required


[11.x] Add get, write and forget cache events

To allow tracing how long read/write cache operations take I've added events that fire before the already existing events that fired after calling the cache store. This makes it so that every cache operation has a "start" and "end" event that allows tracking the time between them.
To make sure every cache operation has a matching start and end event there are also 2 new failed events. The $result could also be added to the current events but not sure if it's a BC change to do that so instead I opted for the new failed events.

Kinda worried about performance degradation here, not a fan of this.

With #51032 (already release) you would be able to opt-out of these!
Not sure if it makes sense to make even more granular than that.


Update to version v2.0.0

Added

Log ingestion from S3 bucket to support more log sources #89
Show logs and metrics of the log analytics pipelines #112
Quickly enable alarms on log ingestion pipeline #113
Show the AWS resource changes when importing AOS using automatic networking mode #53
Log Agent Installation: Support of agent installation on AL2023 instances #88
Support of multi-AZ standby enabled OpenSearch cluster when creating log pipelines #170
Instance Group: Show error message on the console when the installation of log agent fails #169
Support same index name in different OpenSearch clusters #166
Installation: refresh the aws-exports.json once update the CloudFormation input parameters #161
Application log pipeline: Add a step to choose Log Config during the application pipeline creation steps #159
Log Agent: Auto rotation of Fluent Bit log file #158
Instance group: Add an option to attach IAM policies to Instance Group managed EC2 instances automatically #151
Domain management: Check the prerequisites of OpenSearch clusters before import OpenSearch clusters #148
Support ingest WAF (associate with CloudFront) sampled logs to OpenSearch in other regions except us-east-1 #129

Fixed

Log Config: Time key in Fluent Bit config for Spring Boot should be time type instead of None #71
EventBridge will be disabled automatically if deleting instances in instance group #64
Log Config should not be created without Regex/Log Format #163
Lack of region check before creating WAF log pipeline #162
The Fluent bit configuration file generated in sidecar deployment option has a wrong shared volume #160
S3 access log dashboard: 5xx Code description is covered #157
S3 access log dashboard: The Average Time Unit should be milliseconds #155
Cross-account: Unable to get instance list and create instance group in CN region #156
The OpenSearch information (e.g., version, data nodes) is not updated automatically after customer upgraded the cluster #150
Cannot differentiate the Lambda for different AWS Service log pipeline based on Lambda description #146
Fix data lost when cannot find the location with IP address using MaxMind database #126
Syslog: Fix port conflict when adding & deleting new log source in parallel #174

Changed

Minimize the permissions of EC2 log ingestion IAM role #154
Minimize the privileges of cross-account access role #153
Soft delete when removing OpenSearch domain #152
Save ALB access logs of Nginx based proxy to S3 bucket #149
Code refactor: DynamoDB design optimization and GraphQL API design optimization #147
Minimize security group egress of the provisioned ECS #145
WAF dashboard: Cannot filter results using nonTerminatingMatchingRules.action field #144

Removed

Domain management: Remove the support of Elasticsearch engine #176

EventBridge will be disabled automatically if deleting instances in instance group https://github.com/aws-solutions/centralized-logging-with-opensearch/pull/64 does not point to the right item


Unify what authorization MLEM and DVC require

Right now, when working with private repos, MLEM require HTTPS auth, while DVC require SSH https://mlem.ai/doc/user-guide/dvc/#working-with-private-repositories
It's awkward, so we'd like to allow to use a single authentication method. IIUC, DVC supports SSH only https://dvc.org/doc/api-reference/open#example-accessing-private-repos (@skshetry, @efiop, can you please confirm?)
If so, then it makes sense to make MLEM support SSH (we can keep supporting HTTPs if that's possible).
related to https://github.com/iterative/mlem/issues/497

DVC supports both HTTPS/SSH authentication. The docs was just showing an example with ssh. You can pass passwords in url itself, or better enable git credentials-helper, from which dvc can extract username/password for the remote url.
Regarding GITHUB_USERNAME and GITHUB_TOKEN, it's mlem's implementation than being a standard.
https://github.com/iterative/mlem/blob/1a1d2031643c56d24473f77c9b6a015a9d43d4a5/mlem/contrib/github.py#L78-L79

Hi @skshetry! Is this incorrect info that should be fixed then?

https://dvc.org/doc/command-reference/exp/push

@skshetry could you please TAL?

yes, it is incorrect.


az ssh vm is omitting ssh.exe output

Client-side issue using 'az ssh vm' to connect to Linux using Azure AD user.
If you're trying to connect to ssh using Azure AD credentials (following https://docs.microsoft.com/en-us/azure/active-directory/devices/howto-vm-sign-in-azure-ad-linux#login-using-azure-ad-user-account-to-ssh-into-the-linux-vm) through 'az ssh vm' cli command, you had it working before, then deleted the VM, created another VM with the same name (hostname), then 'az ssh vm' command will omit the output of C:\Windows\System32\OpenSSH\ssh.exe (haven't tested on Linux).
It should display "WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!" output, but instead, it just returns without any output.
This happens since VM was recreated, another SSH fingerprint is presented. SSH client will refuse connecting to the server.
To confirm this is the issue, try connecting using:
C:\Windows\System32\OpenSSH\ssh.exe userPrincipalName@ip <-- this will display the above message.
The following will display no output:
az ssh vm -n <vmname> -g <resourcegroupname>
az ssh vm --ip <private_or_public_ip>

Workaround is to fix or delete 'known_hosts' file at:
%userprofile%\.ssh\known_hosts

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 29a90500-fe23-5ae5-caad-9b897ed5ac6c
Version Independent ID: 588d5bec-fcbe-75f9-5206-616746e61d5f
Content: az ssh
Content Source: latest/docs-ref-autogen/ssh.yml
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

route to service team

@mvaferreira  - Thanks for reporting the issue. We will fix it soon.
Another workaround is to pass the verbosity flag,
az ssh vm -n <machine-name> -g <resource-group> -- -v

In addition to outputting the the error, is it also possible to output a message based on incorrect IAM permissions.  If a user does not have login permissions (e.g. virtual machine user login), even using the -v option the only hint we get is a connection closed response.  Can the cli check for permissions to the resource before attempting and provide a access denied message?

Any update on this?
It's an absolutely horrible end user experience. The underlying call (SSH) is giving a perfectly servicable error message, and az simply swallows it - doesn't even respond with a warning! Even experienced sysadmins are confused, because the CLI is just closing without any response.
Options:

Capture the error, bubble it up
Capture the error, return a custom warning
Capture the error, return a custom error

And if the recommended response is "pass -- -v" - can that please at least be added to the result of "az ssh vm --help"
Even better, you could add this known issue to the help file for now, so end users have a chance.


npm run start.android doesn't deploy app to physical device

IMPORTANT: This repository's issues are reserved for feature requests and bug reports. Do not submit support requests here.
Steps to reproduce and a minimal demo of the problem
npm run start.android
What steps should we try in your demo to see the problem?
Current behavior
App can't find Android emulator
Expected/desired behavior
App comes up on phone.
Other information
I am running hyper-v so I can't use VirtualBox emulator, so I use physical device

Nevermind, after reviewing the commands in the root level package.json file I see the start.android.device command and it works great--including livesync. Thanks for all your hard work!


Features.. without updating? (Trojan horse?)

For the not-that-technologically savvy bunch of you or the ones needing a TLDR: this codebase is a potential trojan horse.
Question
Where do I thank the developer for adding means to add features without the user ever updating the code?
We're evaluating a file, with 0 restrictions. The target file seems similar to what a JSON file could potentially be, but obviously line 5 already imports a JSON parsing library and it isn't used. So a reasonable conclusion can be made that there's an underlying intent of adding a "feature", malicious or not being totally out of the question, to the codebase without any "update" necessary on the client's end.
This is known as Remote Code Execution. In this instance, it isn't even conditionally executed. It is executed on each and every run of this project. There's no defending it, unless of course this is intentional.
This breaks any trust that a potential or an existing user could have from your project. Kindly remove such instances, and maybe be a little competent over future commits.
I'd very much advise to also get rid of the file that is being "executed". Obviously, the damage is irreparable. Any user before this commit have a potential risk of an attack on their device.

A potential "fix" would be to hardcode a hash along with the request and verifying integrity before execution.
At that point this becomes a remote import tho, so yeah this is a really stupid idea

The new commit is better, but I fail to see the continued use for eval
Why wouldn't plain json work?

As everything that could cause an arbitrary code execution was removed, can this issue be closed?

Closed as resolved as of this commit.


[TASK] Create a Game Play class

Description
Create a Game Play class that:

[x] Gets called from processing thread via callback
[ ] Gets results from processing thread and accumulates them
[ ] Once accumulated, decides which one is a valid detection
[ ] Once the valid detection is found, keep the last cards coordinates (corner and mid-point)
[x] Use the card coordinates to differentiate between the Dealers and Players hands
[x] Dealer only has one card.
[ ] Once these detections are finished, store the results in the class.
[x] Continue with Strategy Engine and LEDs
[x] Stop Strategy Engine if the player has finished playing. I.e. when STAND is called.
[x] If the player has busted, then player has lost and game will reset.
[ ] If the Dealers hand is total empty, then the game has finished. (i.e. all cards have been collected and the board is clean)
[ ] Wait for new game to start. (i.e. dont do anything until new cards are dealt)

@Eagleeye101 Have a look through the logic above. We need to also keep track on when the game has started or finished. I was thinking that the game will be finished when there aren't any cards detected on the dealer, i.e. when we sweep the cards and have an empty board.

Yeah, I like the logic here. The separate class to do all these things is sensible. Good idea to reset when there is an empty board, but may be difficult to reset when player busts as cards will still be on the table. Probably just easiest to remove all cards after a bust and reset that way

@Eagleeye101 did what you suggested here, just check if tehre aren;t any cards, i.e. you clear the board. Feel free to add functionality.

Open PR #73.
Some tick boxes are unchecked.
Accumulator has not been solved for example, and the reset case is instead an empty board alltogether.


Take too much time to respond and return most of the gar-beg data

cool its working fine, but response time is too much, and its giving most of the gar-beg text, do you have solution on this? please let me know

Can you give me a sample image?

@halkar @Surajvbinorkar  Any update on this? I am getting the same behavior.
Taking images in landscape or portrait mode does not improve the recognition capabilities. (at least not in my case)
Thanks :)


[LAYOUT] App icon is small (API 25-)

App icon is shown corrected now but it is small for API 25-.

Closed by #1651


Cannot see any entities in Home Assistent after importing the Integration  via HACS

Hi,
the Integration does not work the way it is supposed to be. The Integration is now availible so far but I cannot observe any entities for my Heatung pump THZ 403 SOL from Stiebel Eltron. The ISG works fine.

any hints or ideas?
I just followd your guidance with the automatic Integration via HACS.
Thanks
Wolfgang
My ISG:

Possibly the ip address is incorrect? Difficult to say...

I', going to check that out. Thanks. After installing the Stiebel Eltron Integration from the HACS, where can I configure the IP Address, username and password of my ISG?

Yes that was the problem:)
Thanks a lot, it's working now.


SQS messages don't contain MessageGroupId and MessageDeduplicationId when sent from batch #3101

Adding MessageGroupId and MessageDeduplicationId when sent from batch (#3101)

Coverage remained the same at 94.316% when pulling 024106f9519037d9ac892d697b596f87d39667bc on ryanlchandler:enhancement/sqs-batch-group-message-id into b09c8034e603a59906cf2fa33e8dc25336f1e179 on spulec:master.

Coverage remained the same at 94.316% when pulling 024106f9519037d9ac892d697b596f87d39667bc on ryanlchandler:enhancement/sqs-batch-group-message-id into b09c8034e603a59906cf2fa33e8dc25336f1e179 on spulec:master.


Fixing the issue with result schema

The existing code returns the wrong result schema
when order by column does not appear as part of the
selection columns. This fixes the minor bug in the
code and returns the schema correctly.

SELECT ObjectAttributes from T where ... ORDER BY timestamp DESC LIMIT 1000

The above query returns the ObjectAttributes (NULL) . After this patch, it correctly returns ObjectAttributes (STRING)

Codecov Report

Merging #6353 (e16aebe) into master (1beaab5) will decrease coverage by 1.10%.
The diff coverage is 45.12%.

@@            Coverage Diff             @@
##           master    #6353      +/-   ##
==========================================
- Coverage   66.44%   65.34%   -1.11%
==========================================
  Files        1075     1291     +216
  Lines       54773    62158    +7385
  Branches     8168     9014     +846
==========================================
+ Hits        36396    40617    +4221
- Misses      15700    18645    +2945
- Partials     2677     2896     +219

Flag
Coverage Δ

unittests
65.34% <45.12%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/broker/api/resources/PinotBrokerDebug.java
0.00% <0.00%> (-79.32%)
:arrow_down:

...ot/broker/broker/AllowAllAccessControlFactory.java
71.42% <ø> (-28.58%)
:arrow_down:

.../helix/BrokerUserDefinedMessageHandlerFactory.java
33.96% <0.00%> (-32.71%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ava/org/apache/pinot/client/AbstractResultSet.java
66.66% <0.00%> (+9.52%)
:arrow_up:

.../main/java/org/apache/pinot/client/Connection.java
35.55% <0.00%> (-13.29%)
:arrow_down:

...inot/client/JsonAsyncHttpPinotClientTransport.java
10.90% <0.00%> (-51.10%)
:arrow_down:

...not/common/assignment/InstancePartitionsUtils.java
73.80% <ø> (+0.63%)
:arrow_up:

...common/config/tuner/NoOpTableTableConfigTuner.java
100.00% <ø> (ø)

...ot/common/config/tuner/RealTimeAutoIndexTuner.java
100.00% <ø> (ø)

... and 1141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4183ffe...e16aebe. Read the comment docs.

Please add a test case where the previous code fails and the new one passes


How to upload video to youtube?

I want to upload videos to youtube using nodejs so please tell me how to upload videos to youtube using youtube-node.

Today I will work in the method upload. I'll let you know by this means. Thanks

@christopher-ramirez,  #youtube-query allow upload files?

No. And I do think that this kind of feature is out of the scope of projects like youtube-node and youtube-query.
We should aim to limit our project scope to querying (reading) youtube public data in a simplified manner. Trying to do more than that is to fall in the "complete alternatives to Google's client" category. It would take a lot of work and it will be very difficult to out done Google.
This feature request should be closed.

@periyasamy25 alternatives: https://www.npmjs.com/package/youtube-uploader https://www.npmjs.com/package/youtube-upload


Adding PR and issues template

Adding templates as described in https://github.com/camaraproject/WorkingGroups/blob/main/Commonalities/documentation/Issue and PR template Howto.md
PR https://github.com/camaraproject/NumberVerification/pull/40

The PR was merged.


PIXI.js and node canvas

Hi, I was thinking about using PIXI.js to do server side rendering. Before I was doing it using Fabric.js and NodeCanvas for Node.js canvas implementation. I've used similar approach with PIXI.js but it's heavily dependent on browser variables. Of course I could use Phantom.js to simulate browser environment on the server but there are many problems with canvas rendering in the Phantom.js. Have anyone tried to make PIXI.js compatible with NodeCanvas?

would this code snippet be viable for v3 still? I've managed to get everything set up and "running" correctly, but I believe node-canvas is not actually rendering anything.
I have been able to successfully draw an image to a node-canvas and sent it as a data URI to client which then places it in a PIX texture. When I change from canvas.toDataURL() to renderer.view.toDataURL() I still get an image, but it is just a transparent png.
I am for sure calling renderer.render. My "stage" is worldStage (it's a Container) and to keep it simple I am just doing:
worldStage.addChild(new PIXI.Sprite.fromImage('https://mydomain.com/wood1.png'));

when I do that on the client, it works fine. I replicated the client code to the server and have even ended up stripping some stuff out to make sure it wasn't just a problem with performance. Is there any way I can verify PIXI is actually rendering?

I had to modify it a bit to get it working btw:
global.document = require('jsdom').jsdom(null);

global.window = document.defaultView;
global.Canvas = require('canvas');
global.Image = require('canvas').Image;
global.window.CanvasRenderingContext2D = 'foo'; // let Phaser think that we have a canvas
global.window.Element = undefined;
global.window.document = global.document;
global.navigator = global.window.navigator = { userAgent: 'node.js' }; // could be anything

global.window.DOMParser = require('xmldom').DOMParser;

// fake the xml http request object because Phaser.Loader uses it
global.XMLHttpRequest = function() {};

// load an expose PIXI in order to finally load Phaser
global.PIXI = require('./pixi/bin/pixi.js');

Here is an example of the generated data URI

I opened the page, saw "node-canvas" and "AAAAAAAAAAAAAAAA" and thought that you screamed. Are you in the end of 10-hour marathon of implementing this stuff? :)

:D


gherkin/javascript: Include tags from rules in scenario outlines

See #2090

Hi @chaofan-nirvana,
Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾
In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Is it possible to add a new, or modify an existing, feature file from the testdata that would expose this difference?

Yes, we should. This one: https://github.com/cucumber/common/blob/main/gherkin/testdata/good/rule_with_tag.feature

I've got an MR for that in progress. It's not trivial, the code to generate the reference files is broken.

Available in Gherkin 24.1.

The cucumber and its community are so great! It is a good start for me. Thank you all!


pull request for e2e test at 01/20/2017 01:15:14

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Miss close } tag in /lib/audioplayers.dart

https://github.com/luanpotter/audioplayers/blob/master/lib/audioplayers.dart#L411

absolutely!!! probably a merge conflict problem... if'd like to contribute with a PR :)
just one character probably, but it'd help us out!

Fixed by #222


sleuth unable to read message properties

Describe the bug
I am addidng sleuth 2.2.1.RELEASE to my existing spring boot project. i am using MappingJackson2MessageConverter with JMSTemplate. message is getting published with properties b3 and typeId successfully. But when @JMSListener receives the message there is an exception below :
Caused by: org.springframework.jms.support.converter.MessageConversionException: Could not find type id property [typeId] on message
when i dubug the code and look at spring MessagingMessageListenerAdapter.invokeHandler(), i see in the message there is null inside properties which is troublesome.
I see that on activeMQ there are message properties but when application recive that message it does not read properties.
This whole code works if i remove sleuth support.
Could you help me on this issue ?

Please upgrade to the latest version 3.0.5 or 3.1.0 and try again.

Please upgrade to the latest version 3.0.5 or 3.1.0 and try again.

After updating cloud dependency to 2021.0.0 under dependency management i got 3.1.0 sleuth. but facing the below error on application startup:
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'entityManagerFactory' defined in class path resource [org/springframework/boot/autoconfigure/orm/jpa/HibernateJpaConfiguration.class]: Initialization of bean failed; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'refreshEventListener' defined in class path resource [org/springframework/cloud/autoconfigure/RefreshAutoConfiguration.class]: Unsatisfied dependency expressed through method 'refreshEventListener' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'configDataContextRefresher' defined in class path resource [org/springframework/cloud/autoconfigure/RefreshAutoConfiguration.class]: Post-processing of merged bean definition failed; nested exception is java.lang.IllegalStateException: Failed to introspect Class [org.springframework.cloud.context.refresh.ConfigDataContextRefresher] from ClassLoader [jdk.internal.loader.ClassLoaders$AppClassLoader@9e89d68]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:603) ~[spring-beans-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:517) ~[spring-beans-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:323) ~[spring-beans-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:226) ~[spring-beans-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:321) ~[spring-beans-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202) ~[spring-beans-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at org.springframework.context.support.AbstractApplicationContext.getBean(AbstractApplicationContext.java:1108) ~[spring-context-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:868) ~[spring-context-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:550) ~[spring-context-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:143) ~[spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]
at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:758) ~[spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]
at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:750) [spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]
at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:397) [spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:315) [spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1237) [spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1226) [spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]

You're using a wrong version of Boot. Please upgrade to 2.6.3

You're using a wrong version of Boot. Please upgrade to 2.6.3

Due to project limitations i can not switch the entire project to the latest versions. currently i am using Hoxton-SR1 for cloud dependencies with spring-boot-version 2.2.1.RELEASE which should be compatible. could you suggest solution in these versions?

That version is not maintained. You can check this support page https://spring.io/projects/spring-cloud-sleuth#support for more information


Non-admin DJ Controls do not receive hosts for remote broadcasts

DJ Controls without admin status are not listing any available hosts in remote broadcast forms even when hosts are available. This prevents remote broadcasts from being possible through these DJ Controls.

[x] Find the problem

[x] Fix

[x] Monitor fix

Issue transformed into a security one where hosts were being exposed in the recipients model. Modified DJ Controls and the system so that it does not rely on the Hosts model for remote calling and only needs Recipients; Recipients will specify which ones can make / receive calls, and will now use a distorted host ID so the real one isn't revealed.


Version 4 missing multi().select

multi().select no longer works after upgrading to v4 from v3.
Property 'select' does not exist on type 'RedisClientMultiCommandType<{ graph: { CONFIG_GET: typeof import("d:/Code/ProRank/code/coreservices-node/node_modules/@node-redis/graph/dist/commands/CONFIG_GET"); configGet: typeof import("d:/Code/ProRank/code/coreservices-node/node_modules/@node-redis/graph/dist/commands/CONFIG_GET"); ... 15 more ...; slowLog: typ...'.
Environment:

Node.js Version: v16.14.1
Redis Server Version: 6.2.6
Node Redis Version: 4.0.4
Platform: Windows 10

Maybe the solution at #1989 might help you

Sorry, looks like my title was wrong. I have redis.mult(). What I get an error on is redis.multi().select.

I could be wrong, but I don't think the solution in https://github.com/redis/node-redis/issues/1989 fixes this issue

Using the SELECT commands effects all the commands afterwords (even if the SELECT command is within  MULTI context):
client.multi()
  .select(2)
  .exec();

client.set('a', 'b'); // will set the key a under db 2, even though the `SELECT` command is in the multi context

(I'm not saying this is not a valid bug/feature request, just that I don't think you'll want to use it...)

Using the SELECT commands effects all the commands afterwords (even if the SELECT command is within  MULTI context):
client.multi()
  .select(2)
  .exec();

client.set('a', 'b'); // will set the key a under db 2, even though the `SELECT` command is in the multi context

(I'm not saying this is not a valid bug/feature request, just that I don't think you'll want to use it...)

That is the conditions I want to use it in.

Oh, I didn't realize there is a .addCommand(['SELECT', '1']). I'll have to check it out.
The most I can share about my use case is that I need to run commands (mostly get and set) in multiple databases at the same time. So like...
SELECT 1
GET abc
SELECT 2
GET def
etc...

It is odd to me why mult().select was even removed in version 4 if it existed in version 3. I wasn't able to find anything on why it was removed, so it seems like just an oversight perhaps?

yea, it was removed by a mistake, and will be added back soon

Any update on this?

@ItzRabbs wanna try #2133?

Yes, though I'm away from my computer for a few days. I'll try it out the moment I can.

Can a new npm release be created with this patch?

@ItzRabbs sorry about the long delay, I was on vacation... I'll release it this week.

@leibale no worries, thank you

@leibale Any chance for a new release soon?

@ghost<EMAIL_ADDRESS>&<EMAIL_ADDRESS>is on NPM :tada:

It doesn't look like this is fixed
const { host, port } = { host: '<enter the right host name in here>', port: 6379 };

import { createClient } from 'redis';

void (async () => {
  const client = createClient({
    url: `redis://${host}:${port}`
  });

  await client.multi().set('foo', 'bar').exec();
  await client.multi().select(1).exec();
})();

test.ts:11:24 - error TS2339: Property 'select' does not exist on type 'RedisClientMultiCommandType<{ graph: { CONFIG_GET: typeof import("D:/Code/ProRank/code/coreservices-node/node_modules/@redis/graph/dist/commands/CONFIG_GET"); configGet: typeof import("D:/Code/ProRank/code/coreservices-node/node_modules/@redis/graph/dist/commands/CONFIG_GET"); ... 15 more ...; slowLog: typeof import...'.

11   await client.multi().select(1).exec();


[$1000] Phone number contact in task assignee is displayed with @expensify.sms

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Click plus and click on assign task
Enter any title and click on next
Click on Assignee
Search for user with phone number as default contact method and select it
Observe that on new task page under assignee, the phone number contact is displayed with @expensify.sms in the end

Expected Result:
App should display phone number contact below assignee in new format as it displays in assignee search
Actual Result:
App displays phone number contact in old format and with @expensify.sms behind it below assignee
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/a549f5c3-bedf-465e-9ad0-7f8d69043df1
https://github.com/Expensify/App/assets/43996225/59ff6ee6-6ff9-4214-bb12-838412f517e2
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688140198815779
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010ead72a986dba400
Upwork Job ID:<PHONE_NUMBER>963620864
Last Price Increase: 2023-07-04

Yup, this is reproducible. As we do elsewhere throughout the app, we shouldn't be showing the @expensify.sms portion of the phone number login. Let's not reinvent the wheel and extend however we're doing that elsewhere here on the taskReport.
@thienlnam putting this on your radar as well, as it relates to tasks. Going to move it External for the time being.

There are several approach.
split phone number in frontside,
and make function such like FormatPhoneNumber() , and fix api(BE)
or remake  component.

Contributor details
my Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~017b2ac34ea29e2afb?viewMode=1
but my upwork account is not good because my last account has problem  so i create it today.

yes,  ok,  I'll  contact after fix it.

@trjExpensify just a note that we have to start a discussion on slack (after this is fixed) on how to prevent @expensify.sms bugs, because they keep happening.

Yeah, I'm not sure why they are all of a sudden creeping in again, but I agree it's a good discussion on the checklist item to prevent them moving forward.

Are we all cleared up here, when can we expect the PR to be linked? Thanks!

We require a 🟢 from @bondydaa actually. :)

oh wait maybe I remembered incorrectly, this bit of code in the API seems to suggest we do expect the @expensify.sms from clients https://github.com/Expensify/Web-Expensify/blob/313880bfc5062e846d75bbe0ee0fda28201a3925/api.php#L109-L119.

asked in slack https://expensify.slack.com/archives/C03TQ48KC/p1689005020724049

yes both of those links were internal only

sorry, looks like I had it backwards and we do expect clients to strip out the sms domain from the logins 👍

approved the PR 👍

reviewing today

@trjExpensify @bondydaa I can reproduce above issue on build 1.3.42-21
https://github.com/Expensify/App/assets/93399543/214633ed-4f09-4fb2-b973-a5f0ef64b07b

In the video uploaded just above, the number is 8 (705) XXXX but the email is +7705. Why is the first digit changing from 8 to 7?

Not sure, maybe it's something to do with the phone number validation - I would expect to see the country code there as well. @kbecciv what country code was used/is this a US number? Also, can you retest this issue with expensify.sms showing up on the task row in the chat. Thanks!

Yeah, I'm happy to go from when Bondy confirmed the green light to proceed after the clarification, so we'll apply the #urgency bonus here!
Payments due by my calculation to confirm are:

@dhanashree-sawant - $250 for the bug report
@c3024 - $1,500 for the fix & #urgency bonus
@rushatgabhane - $1,500 for C+ & #urgency bonus

I'll make sure @c3024 & @dhanashree-sawant have offers in Upwork. @rushatgabhane can you complete the checklist items though please, so we can proceed with payment? As we discussed earlier, we want to try and limit these @expensify.sms bugs from creeping in time and time again. Thanks!

In the video uploaded just above, the number is 8 (705) XXXX but the email is +7705. Why is the first digit changing from 8 to 7?

As for this, it's unrelated to this issue so @c3024 can you investigate it a bit more and if it's not reported yet, pop that one through #expensify-bugs as per the process as you found it. Thanks!

Reviewed details for @rushatgabhane. This is accurate and approved for payment in NewDot.

Cool, awaiting the checklist!

Yes, we typically don't proceed with payments until the checklist is complete.

WIP ⚠

The PR that introduced the bug has been identified. Link to the PR:

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Determine if we should create a regression test for this bug.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

Created a manual request https://staging.new.expensify.com/r/8107948973342401

Thanks, @rushatgabhane!
@dhanashree-sawant - settled up.
@c3024 I was just about to settle up, but I can see you've somehow already been paid $1,000 for this job. I've sent a bonus of $500 but can you confirm? 😕

@trjExpensify you can close this issue because creating a request on new dot is enough. it'll be tracked there

I'm seeking confirmation on that from @JmillsExpensify elsewhere actually.

I've been paid. we can close 😅

Dope!

as reported here https://expensify.slack.com/archives/C049HHMV9SM/p1692114818807249
looks like either this wasn't fully fixed by https://github.com/Expensify/App/pull/22566 or there is a new regression

quickly looking at the PR I don't see any screenshots or videos that show the task preview so we might have just missed it 🤦
Going to spin up a new issue for this.

ah thanks for that context! if you can find which PR might have caused it then great! we can tie it to that but otherwise we can get it handled on the new GH that gets spun up.

Yes, we have another issue reported by Contributor
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694333604061429
Uploading Screen Recording 2023-08-15 at 22.54.24.mov…
.

Going to spin up a new issue for this.

@bondydaa where is that? Let's not reopen this one that's already done and dusted with payments made.

Created a new issue here https://github.com/Expensify/App/issues/27330, closing old one.


Docs: Modal > Tooltips and Popovers missing data-bs-toggle

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
5.0 Docs > Modal page > Tooltips and popovers
The example doesn't have the attribute data-bs-toggle="tooltip" on the anchor tags.
I've checked for syntax errors in my code, but the tooltip only displays correctly when this data attribute is added. I thought this might be an error in the docs.
Reduced test cases
https://getbootstrap.com/docs/5.0/components/modal/#tooltips-and-popovers
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
5.1.3

This is because those are triggered via JavaScript as opposed to data attributes. I suppose we could replace them but I'm not sure if we did it that way for a reason.

@mdo is fake html, in real example displayed:

Popover in a modal

This button triggers a popover on click.

Tooltips in a modal

This link and that link have tooltips on hover.


Update docs to incorporate yarn create, and update the npm scripts

Small updates! Easy Merge! :)

All comments addressed

The documentation for running graph-cli has moved to the official docs.


RFC: More features to add to vite-preset-react

Discussed in https://github.com/PuruVJ/vite-preset-react/discussions/9

Originally posted by PuruVJ November 15, 2021
Vite Preset React currently implement only 2 features, as listed in the README:

These two are pretty good, but this package is supposed to be a preset, meaning more opinionated.
What all things do you think would be good to add to this, which would make your React Developer Experience better?
Comments welcome! :)

I would love to get the option of setting the nonce attribute of the script injected to a value I set.


[SPMD] Tighten _is_param data ptr check

I am reading the compiler code, and I noticed something minor with the _is_param check. Checking .storage().data_ptr() means that views are considered equal. For example:
>>> t = torch.randn((3, 3))
>>> t.data_ptr()
94158967421632
>>> t.storage().data_ptr()
94158967421632
>>> s = t[1:]
>>> s.data_ptr()
94158967421644  <-- offset by 12 bytes (3 elements) representing skipping the 0th row
>>> s.storage().data_ptr()
94158967421632  <-- same as that of `t`

If I understand correctly, any input to the forward will be represented by an fx.Node whose name starts with primals_. In that case, if the forward takes in a view of a parameter, then the saved primal mappings may include an extra entry, "double-counting" the parameter, which should trigger the assert in _map_primal_to_param():
https://github.com/pytorch/tau/blob/11a8896707848524b3c0ee20354b319f9f475bc0/spmd/compiler/distribute.py#L498-L501
Ideally, this PR would add a unit test that fails before this change and passes after. However, I am still familiarizing with the code base, so this PR is mainly meant to point this out to the core developers.

Test failures look real. Let me investigate.

Nevermind. The tests are failing on the latest commit in main as well.

I don't think the test failures are related:
NotImplementedError: Operator aten.fill.Scalar does not have a DistributedTensor rule registered.

Sounds good. I will merge then.

Wait how do you guys usually merge? "Squash and merge"?

Yes, exactly.

If my memory is correct, only the unique parameters will have primal_ name prefix. Views will have another naming.


What is the best way to fully customize the theme?

Currently I make it to transparent and use content's styles
.tippy-tooltip.tomato-theme {
  background-color: transparent;
  color: transparent;
}

.tippy-tooltip.tomato-theme[data-animatefill] {
  background-color: transparent;
}

.tippy-tooltip.tomato-theme .tippy-backdrop {
  background-color: transparent;
}

.tippy-popper[x-placement^='top'] .tippy-tooltip.tomato-theme .tippy-arrow {
  border-top-color: transparent;
}
.tippy-popper[x-placement^='bottom'] .tippy-tooltip.tomato-theme .tippy-arrow {
  border-bottom-color: transparent;
}
.tippy-popper[x-placement^='left'] .tippy-tooltip.tomato-theme .tippy-arrow {
  border-left-color: transparent;
}
.tippy-popper[x-placement^='right'] .tippy-tooltip.tomato-theme .tippy-arrow {
  border-right-color: transparent;
}

.tippy-tooltip.tomato-theme .tippy-roundarrow {
  fill: transparent;
}

Closed. I found the tippy structure in here, I think I know how it works.
BTW, How can I remove all default imported CSS styles?

BTW, How can I remove all default imported CSS styles?

This was a tradeoff so you don't need to think about CSS: but basically, you can't (easily). Maybe you could wait until DOMContentLoaded and then find the <style> node and remove it from the <head>.
Maybe we should offer an import point without the CSS, like ``import Tippy from<EMAIL_ADDRESS>

This was a tradeoff so you don't need to think about CSS.
This is very reasonable.

Maybe we should offer an import point without the CSS, like ``import Tippy from<EMAIL_ADDRESS>
Maybe we can provide another option to control the enable/disable auto injection of theme?

Maybe we can provide another option to control the enable/disable auto injection of theme?

The issue is import tippy from 'tippy.js' auto-injects CSS into head, but import tippy from 'tippy.js/esm won't
Maybe this hackish solution could work: node monkey-patch.js that runs before dev/build:
const fs = require('fs')
const path =<EMAIL_ADDRESS>fs.writeFileSync(
  path,
  fs
    .readFileSync(path, 'utf8')
    .replace(
      "import tippy from 'tippy.js'",
      "import tippy from 'tippy.js/esm'"
    )
)

I've also done similar monkey-patching on node_modules before

Could you import the non-css version by default and inject the css yourself, but also provide a prop to disable the injection part?

The injection is global so not sure how that would work. I think the ideal is to provide a different import path w/o the CSS. It shouldn't be too hard to make a PR for if you want?

I have personally come up with a pretty clean hack based on the comments above.
I have added the following line in my webpack's resolve.alias section and it stopped injecting the default style!
resolve: {
    alias: {
        'tippy.js': 'tippy.js/esm',
    }
}


Newrelic support

Do you have any plan to add newrelic support?
So it installs newrelic-sysmond and accepts license key via env variables.

There is not any plan to support it, it's not a feature any user use by default.
We are trying to mantain the original image as small as possible.
Maybe you can do it building a new docker image, extending the original apsl/thumbor and installing all you need it for monitor, like we are doing in thumbor-multiprocess image.


chore(core): pin pytest to 7.1.3

Why is this needed?
This change is intended to avoid errors like the following at build (tox) time:
ModuleNotFoundError: No module named 'py'

pytest removed the dependency on py in:
https://github.com/pytest-dev/pytest/commit/19dda7c9bdc8ef71c792e0f77a9595bfad8d9248
This change pins the version of pytest to one that includes py until a path forward can be agreed on (e.g. include py explicitly or via a transitive dependency).
Proposed Changes

Pin pytest from latest (currently 7.2.1) to 7.1.3.

Does this PR introduce any breaking change?
No. This change affects build/test only.

Closing this. Although this is a problem -- the real issue I was seeing is that tox-wheel is deprecated and doesn't work with tox 4. I'll open a new PR for that instead.


Running Litmus workflows in Openshift throws "cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on:"

I deployed Litmus 2.6 on Openshift in a disconnected environment. While I had issues with RBAC for starting Litmus, I finally got everything working and Litmus seems to be running fine.
Next I wanted to run the workflow to do some chaos experiments in the cluster
However when I try to schedule a workflow using Litmus Portal  Chaos Hub I can see the following errors in the Workflow Operator.
pods "custom-chaos-workflow-1647427227-1647432738-3411883899" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , " namespace=litmus workflow=custom-chaos-workflow-1647427227-1647432738
Attaching the log snippet. Any ideas as to what permissions am I missing
LitmusWorkflowLogs.txt

opened it under the wrong project


Option to return coords of caret bottom

Hi!
If you want to display a popup/tooltip below caret, you have to account for text field's line height.
Retrieving a calculated value of a DOM element's line height is non-trivial. There's a library that implements a hack similar to what subj does for caret position. Unfortunately, it is unreliable: on Chrome 57 it would report double line height, but single on Firefox 51.
Subj has all the framework required to detect the bottom of the caret. Essentially, the top of the caret + line height.
There's already an undocumented options argument which could be used to pass a bottom flag.

Fixed via af904838644c60a7c48b21ebcca8a533a5967074. Thanks for raising this.
PS: first time I see "subj" on GitHub :)

Thx!


Provide functionality to be able to highlight the current location in a TOC

From John Nowak:
I'd like to highlight the user's current location in a book when displaying its TOC. As far as I can tell, this means getting the current idref and CFI by calling 'ReadiumSDK.reader.bookmarkCurrentPage', and then -- somehow -- turning this into data I can use to identify the navigation element accessible via the TOC that's immediately prior to the user's current location.
Given that I can't find any obvious way to do this, and given that the Readium Chrome app doesn't indicate the user's position in the TOC, I think it may just not be possible with Readium at present. If anyone does know how to do this though, or has an idea about how such functionality could be added, I'd very much appreciate it!
Thanks!

So here is a naive thought:
Don't we know the URI of the currently displayed "pages"? I see that the iframe src data is cached in a blob but we do know the original URI and could cache it.  Then it seems easier to match that value to the fragment identifiers contained in the TOC document.  Although I suspect that large items or references to other spine items within the currently displayed "pages" could present a problem. And I'm sure I don't understand all of the nuances of TOC documents!

Hi @becka11y you can use spineItem.href and resolve against the package's base URI, for example:
https://github.com/readium/readium-shared-js/blob/develop/js/views/internal_links_support.js#L55
    function getAbsoluteUriRelativeToSpineItem(hrefUri, spineItem) {

        var fullPath = reader.package().resolveRelativeUrl(spineItem.href);

        var absUrl = hrefUri.absoluteTo(fullPath);

        return absUrl;
    }

So, I can highlight the top level TOC item but once the user starts paging through I can't find a way to identify the section that is currently displayed.  Is there a way to get the dom of the currently visible "view"? If so, I can search for elements with the id's associated with the hrefs in the TOC associated with that spine item.  Although this would probably be slow on continuous scroll documents.
I did find the api to get the domRange between two CFI's but I don't think the domRange gives me enough info to find the actual elements with a specific set of id's.
I'm thinking there is no way else to identify the current TOC items than to use CFI's as you originally suggested, but creating the cache of them will be tedious.

Documenting here so I don't forget!
I tried using .getVisibleElements("[id]") to find the visible elements that are identified in the toc.  I can then compare those id's with the ones in the toc to find the one to highlight. The problem is when the item represented in the toc is not actually displayed on the page. I can't find a way to match the currently displayed data with an id represented in the toc. It looks like there is no hack around using CFI's.


Do you have train data?

Do you have train data?

As stated in the manuscript, the data used in this study cannot be shared due to restrictions. We apologize for not being able to provide the data, but you will need to use your own data or publicly available medical datasets.


AnonCreds which use schemas from other issuer are wrongly stored

We are using credentials from different issuers but all of them share the same schema. At some point, the indy-vdr is assuming that the DID of the credential definition should be the same as the schema definition, which is not true.
I got the real DID for the schema from the request to the VDR.
Here is the diff that solved my problem:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 30ded2c..ce29344 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -637,14 +637,15 @@ class IndyVdrAnonCredsRegistry {
             return null;
         }
         const schema = (_b = response.result.data) === null || _b === void 0 ? void 0 : _b.txn.data;
-        const schemaId = (0, anoncreds_1.getUnqualifiedSchemaId)(did, schema.data.name, schema.data.version);
+        const customDID = _b.txn.metadata.from || did
+        const schemaId = (0, anoncreds_1.getUnqualifiedSchemaId)(customDID, schema.data.name, schema.data.version);
         return {
             schema: {
                 schemaId,
                 attr_name: schema.data.attr_names,
                 name: schema.data.name,
                 version: schema.data.version,
-                issuerId: did,
+                issuerId: customDID,
                 seqNo,
             },
             indyNamespace: pool.indyNamespace,

Ups! You are right. 0.5.3... We didn't want to update just in case there are breaking changes. But we will probably do. Thx


Generate project's setup.py

Rationale
https://lincolnloop.com/blog/using-setuppy-your-django-project/
https://docs.djangoproject.com/en/2.0/intro/reusable-apps/

Maybe I'm missing the point, but I'm not really convinced by the first article.
The second link is not relevant to this project IMO as it's not a template to generate a reusable Django app, but to generate a whole Django project.


[BUG] is_datetime_or_timedelta removed in Pandas 2.1.0

What is the bug?
We import is_datetime_or_timedelta in field_mappings.py but that has been removed from Pandas version 2.1.0.
How can one reproduce the bug?

pip install pandas==2.1.0
from opensearch_py_ml.ml_commons import MLCommonClient
run the file

What is the expected behavior?
Should not give import error.
What is your host/environment?
N/A
Do you have any screenshots?
If applicable, add screenshots to help explain your problem.
Do you have any additional context?
Add any other context about the problem.

I was bit by this one recently. @dtaivpp @dhrubo-os I'm not familiar with the CCI label -- is this one somebody is working on, or would you take a PR?

I was bit by this one recently. @dtaivpp @dhrubo-os I'm not familiar with the CCI label -- is this one somebody is working on, or would you take a PR?

Currently no body is working on this issue. I marked this as CCI so that our next college contributors can work on this issue. PRs are welcome.

Got it. Thanks! Let me look into it and see if I can contribute something.

I see that a quick fix for this is to limit the version of pandas to < 2.0 .

I see that a quick fix for this is to limit the version of pandas to < 2.0 .

Yeah, we can just do: pandas>=1.5.2,<2.0 for a quick fix.
@bsowell are you working on this issue? Just checking.

I'm sorry. I had trouble getting tests to run locally and then got distracted so I haven't done much. The implementation of is_datetime_or_timedelta_dtype is straightforward, so if there is value in upgrading pandas, it would be easy enough to just include the logic in field_mappings.py, but agree that the dependency change would be faster.

I think we should close this issue. is_datetime_or_timedelta is not used anymore

Closing this issue in favor of https://github.com/opensearch-project/opensearch-py-ml/pull/316


fix travis OSX build issues:

Boost source not downloading (see https://github.com/conan-community/conan-boost/issues/90)

fix python2 config for joystream-node (see PR #772)

Fixed in #104


HTTP Cookie rewriting

Required by radiasoft/comsoljupyter#2:

[ ] Define REST object format to specify Cookie Mapping.
[ ] Simple cookie parser to remove specific cookies.
[ ] Swap cookies on web request.

Not using anymore.


New plugin for working with dovecot

Hey hey,
i wrote a plugin to collect metrics from dovecot and i am wondering if you are interested in forking it into the sensu-plugins namespace. I would continue maintaining it.
See: https://github.com/ushis/sensu-plugins-dovecot
Cheers, ushi

@ushis sorry for the delay, I have created: https://github.com/sensu-plugins/sensu-plugins-dovecot which has our basic skel (working on making this easier so that there is not so much delay in the future on this). Please feel free to open PRs against it.

@mattyjones ping on permissions

The repo is all set for rubygems deploys once it's ready for release. @ushis can add Sensu_Plugins  as an owner in Rubygems.

@majormoses @eheydrick thanks for setting up the repo.
i am going to migrate the repo this weekend, if i find some time.

your welcome, thank you for contributing.


Is there a better way to handle fsevents?

https://github.com/danecreekphotography/node-deepstackai-trigger/blob/608e3ea1054437ea87ab7eccedaf75628071e510/webpack.config.js#L7
fsevents causes issues when doing webpack in the docker container because it's an optional component in chokidar (only needed on Mac). I couldn't find any better way to resolve the issue than this.
Is this really the right way to do it?

This will never run locally on a mac after webpack. This is fine to work this way.


Current working directory of CliRunner.invoke

I found no way to control the "current working directory" when calling click.testing.CliRunner.invoke inside tests, and I think that it can be a keyword parameter (accepting a string or a pathlib.Path object) of either CliRunner.invoke or CliRunner.__init__.
runner = CliRunner()
result = runner.invoke(main, ["filename.ext"], cwd=Path(__file__).parent)

I can try to create something like a context manager or a fixture (for setup/teardown) that sets it (e.g. with os.chdir, like what happens in CliRunner.isolated_filesystem) before calling the test, getting back to the previous working directory after running that specific test, however that will make it quite difficult to run tests in multiple threads at once, unless everything can be done from the same single current working directory.
Perhaps CliRunner.isolated_filesystem should include some note in its docstring telling that it must not be called more than once at the same time (multi-thread or concurrently/async) in a single process.
I need something like that because the current working directory is part of the result of the application I'm trying to test.

Use PyTest's (or something like it) tmp_path and monkeypatch.chdir fixtures to manage this.


chore: bump backstage version

Closing as coverage pipeline action seems to be stuck in some weird state and running the old packages.


Handle non-jsonable types in records

Currently, we just convert anything to a string which is not ideal as the user might not be aware of it. To address

Record should allow for registration of a custom json-serialiser to convert complex types to strings
if no serialiser is registered, an Exeception should be raised if type is not JSONable
the exception should explain alternatives like storage.save_data()

No longer applicable (though we may re-introduce a records interface in future)


[feature request] support LlamaIndex instrumentation tags

LlamaIndex released an update to instrumentation
Basically, users can add arbitrary tags to their spans/events
from llama_index.core.instrumentation.dispatcher import instrument_tags
with instrument_tags({"user_id": 1234}):
agent.chat("Hello!")
Any events/spans emitted under the with block will have a .tags attribute with the provided tags attached
Instrumentation should parse this part of the span and attach it as metadata's

Sounds like they should be attached as tags rather than metadata.


add sounds to it

What if a sound plays When the toast appears or the toast is closed  ?

We won't be adding any sounds. You can wrap the toast() function with additional logic (like a sound in your example) that would then run everytime a toast is invoked.


[Workspace] Add ACL related functions for workspace

Description
The main change of this PR are:

Add acl related functions for workspace feature
Add permissions field to the default mapping of the OSD index(.kibana)
Update the test snapshot after we change the default mapping of the OSD index

Check List

[ ] All tests pass

[ ] yarn test:jest
[ ] yarn test:jest_integration
[ ] yarn test:ftr

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] Update CHANGELOG.md
[ ] Commits are signed per the DCO using --signoff

Codecov Report

Merging #146 (ad9011d) into workspace-pr-integr-2.9 (c3bc14b) will decrease coverage by 11.09%.
The diff coverage is 65.85%.

@@                     Coverage Diff                      @@
##           workspace-pr-integr-2.9     #146       +/-   ##
============================================================
- Coverage                    66.19%   55.11%   -11.09%
============================================================
  Files                         3317     1176     -2141
  Lines                        63894    23561    -40333
  Branches                      9970     3914     -6056
============================================================
- Hits                         42297    12985    -29312
+ Misses                       19156     9962     -9194
+ Partials                      2441      614     -1827

Flag
Coverage Δ

Linux_1
?

Linux_2
55.11% <65.85%> (+0.03%)
:arrow_up:

Linux_4
?

Windows_1
?

Windows_2
?

Windows_3
?

Windows_4
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...ore/server/saved_objects/permission_control/acl.ts
65.43% <65.43%> (ø)

...d_objects/migrations/core/build_active_mappings.ts
87.09% <100.00%> (+0.43%)
:arrow_up:

... and 2497 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add android on-device translation

Builds on top of https://github.com/bluesky-social/social-app/pull/4098
This PR aims to add on-device translation to Android via MLKit's Translation API to achieve feature parity with iOS. From my testing, Google's 1st party service (translate.google.com) still is the best, but if the aim is to have feature parity on Android, then I think this is a satisfactory solution.
Do note that translation could break rich text formatting (link detection etc) when displaying the translated text, but that may even be expected when translating - the user could revert to the original text at any time if needed.
I'm not super familiar with the codebase, so I might have not done everything in the best possible way so bear with me on that, open to any feedback.
Todo: Add better Google attribution (according to their guidelines)
Quick preview:
https://github.com/bluesky-social/social-app/assets/19533289/0767fead-64d0-4481-a330-027f5b9fd02b

cc @mozzius

Wow, amazing! I’ll take a deeper look on Monday, but this is great! Thanks!
With regards to rich text, the best way would probably be to re-detect the facets using our RichText API

as is tradition:
🚨🚨 S-tier PR Alert! 🚨🚨


Follow up on renaming vcs_PullRequestCommitAssociation to vcs_PullRequestCommit

https://github.com/faros-ai/faros-community-edition/pull/169

Can you please create a new release?


wrap urls with papertrail

@jpaidoussi removing the middleware from identity store, wrapping individual URLs intead to reduce noise. I'm still trying to figure out how to wrap the DRFs routers URLs.

ready for review


Meilisearch with Pydantic v2

I saw you updated Neo4j to use Pydantic 2, meilisearch-python-async has also been updated with support for Pydantic 2. I have been meaning to try that out and see what difference it makes here, but just haven't gotten to it yet.

Awesome! Yes, I in fact had some local commits that I haven't pushed yet to run it for the Meilisearch case next... Other than the initial data validation step, are there other areas where the async Meilisearch client is affected by pydantic v2's release?
I'll push my changes later today and maybe you can take a look to see if there's something more to be gained?

The latest update just added support for Pydantic v2, there should be no user facing changes. I'm happy to take a look when you push it if you want.


Killing a child process on the server side crashes VSCode

VSCode:
1.55.2
3c4e3df9e89829dce27b7b5c24508306b151f30d
x64
OS: macOS Big Sur 11.2.3 (20D91)
Steps to reproduce:

create a long-standing child process using either ChildProcess.execFile or ChildProcess.spawn, trying from either the client side or the server side
after some time, kill() the process

Expected: the process dies in both cases
Actual:

from the client, nothing bad seems to happen
when the server one is killed, the whole VSCode goes down with the window has crashed (reason 'killed')

Is there something to do to prevent that?

@Ptival what you could try is to run the server using a custom node and not the node version that ships with VS Code.
@deepak1556 @bpasero any idea why this is happening? I suspect that the process spawned is an electron node process. TO we somehow monitor those?

Sorry but those steps to reproduce are not helpful for me, please provide step by steps instructions that I can follow through.

I'm still trying to create a reproducible version of it. Depending on what command I try to execute, it does not crash VSCode, and the one that I can reliably make crash relies on a setup that is too complex to reproduce.
My reproduction setup is otherwise super simple, I just cloned the vscode-extensions-sample, and added the following to server.ts:
import * as ChildProcess from 'child_process'
import * as fs from 'fs'
import * as os from 'os'
import * as path from 'path'

and somewhere in the validateTextDocument method I drop:
const command = ...
const options = [...]
const timeout = ...

const p = ChildProcess.execFile(command, options)
setTimeout(() => p.kill(), timeout)
p.stdout?.on('data', (d) => connection.window.showInformationMessage(d))

Now the choice of command, options, and timeout that make VSCode crash is where I'm having trouble finding a reproducible setup.
Notably, simple Unix commands like yes or sleep have not yet allowed me to reproduce the error.
Even on my failing command, the choice of timeout can make the error go away. It seems to happen more reliably for small values like 100.
If it helps, I found a relevant crash log (Application Support/Code/logs/20210414T175050/renderer1.log):
[2021-04-14 17:50:50.659] [main] [info] update#setState idle
[2021-04-14 17:51:20.678] [main] [info] update#setState checking for updates
[2021-04-14 17:51:20.927] [main] [info] update#setState idle
[2021-04-14 17:53:10.267] [main] [error] CodeWindow: renderer process crashed (detail: killed)
[2021-04-14 17:53:10.379] [main] [error] [uncaught exception in main]: Error: SharedProcess: crashed (detail: killed)
[2021-04-14 17:53:10.379] [main] [error] Error: SharedProcess: crashed (detail: killed)
    at /nix/store/h0vvl0dq11hfqy37dhxwm8zgkdjhbj6k-vscode-1.55.0/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:56:68768
    at E.fire (/nix/store/h0vvl0dq11hfqy37dhxwm8zgkdjhbj6k-vscode-1.55.0/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:16:1836)
    at /nix/store/h0vvl0dq11hfqy37dhxwm8zgkdjhbj6k-vscode-1.55.0/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:14:47011
    at E.fire (/nix/store/h0vvl0dq11hfqy37dhxwm8zgkdjhbj6k-vscode-1.55.0/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:16:1836)
    at Object.<anonymous> (/nix/store/h0vvl0dq11hfqy37dhxwm8zgkdjhbj6k-vscode-1.55.0/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:55:9352)
    at Object.emit (events.js:327:22)
[2021-04-14 17:53:10.381] [main] [error] CodeWindow: renderer process crashed (detail: killed)

I'll update if I find some way to crash it with readily available executables.

Can you follow these steps https://github.com/microsoft/vscode/wiki/Native-Crash-Issues#creating-and-symbolicating-local-crash-reports and attach the crash reports. Thanks!

No dump file, just three empty directories and a settings.dat.
Note that when I say VSCode crashes, it actually stays open with a window The window has crashed (reason: 'killed') letting me choose whether to Close or Reopen.
I get two such pop-ups: one for the original editor, one for the debugging editor.

Nevermind, I missed the reason was killed rather than a crash. Can you launch the app with the following and attach the output from terminal once the window gets killed. The output will contain verbose information about child process calls which will print details of your env, if you think they are sensitive you can instead send the logs to<EMAIL_ADDRESS>NODE_DEBUG='child_process' code --verbose

It's too long to post as a Github comment, but here it is, hopefully with no critical private information:
https://gist.github.com/Ptival/64646dded680449ce6d4635ed09fbc62
It will be very clear in this log that I am using nix to install VSCode, if that is relevant to this situation!

Thanks for the logs, after the lsp server spawn call https://gist.github.com/Ptival/64646dded680449ce6d4635ed09fbc62#file-vscode-log-L2342 I only see some git calls before shutdown. What is the child process call that you had created ?

Oh, thanks to you I found the source of the problem!
The process I am launching is a research tool, which I have now found, in its setup, installs a signal handler for the SIGTERM signal that broadcasts the signal to its entire process group!
It is actually now very easy to reproduce, for instance, by using the following Python "group murder" script:
#! /usr/bin/env python
import os, signal
os.killpg(os.getpgid(os.getpid()), signal.SIGTERM)

If you run this script in the language server, it brings down all VSCode instances.
In this light, it actually seems moderately reasonable to not expect the language server to sandbox this entirely.

That makes sense :)
I don't think we have to selectively sandbox this scenario given the nature of extension host. Closing for now, @dbaeumer feel free to reopen if you think this deserves further attention.


Public port is not being configured for networkMode=bridge

When networkMode=bridge is specified for the container, its public port is not being configured on the host.

Tested with server version - v0.34.0-rc3
Created a container with port 80->7771 and 81->8881 with container in bridge mode:
"ports": [ 2 items
"80:7771/tcp",
"81:8881/tcp",
],
Container has ports 7771  and 8881 exposed , but they are mapped to 80 and 81.
f1222e8e2802 - was deployed from rancher server
de470958ab46 - was deployed using docker run command using following command:
docker run -d -p 80:6666 sangeetha/testnewhostrouting
de470958ab46        sangeetha/testnewhostrouting          "/scripts/run.sh ngin"   7 minutes ago       Up 7 minutes        80-81/tcp, 443/tcp, <IP_ADDRESS>:80->6666/tcp       hopeful_pare
f1222e8e2802        sangeetha/testnewhostrouting:latest   "/scripts/run.sh ngin"   13 minutes ago      Up 13 minutes       80-81/tcp, 443/tcp, 7771/tcp, 8881/tcp         92f47de2-e769-426d-93ed-ceb16590deff

Reopening this issue , since we expect the ports to be mapped.

python-agent with this change hasn't been released yet; the change exists in python-agent master branch only. I'll update this bug once its released and ready to test. Want to keep status "to-test" to indicate that the fix has been checked in.

Ok, python-agent 0.47 has been released, and you can test it on the latest now.

Tested with server version - v0.34.0-rc4
Created a container with port 80->1234 and 81->1235 with container in bridge mode:
The public ports are mapped as expected
e7016cb04b4a        sangeetha/testnewhostrouting:latest   "/scripts/run.sh ngin"   30 seconds ago      Up 29 seconds       443/tcp, <IP_ADDRESS>:1234->80/tcp, <IP_ADDRESS>:1235->81/tcp   a20e2293-31f4-4ddc-9bc9-d78a3323079f


Retouched icon.

Retouched icon and added PSD.

The icon doesn't scale well on windows 10, this happends on the file explorer and also on the startup menu


Made all address fields nullable

I noticed that the Google Maps address service doesn't return a state value. So inserting a Google address resulted in a SQL error. Maybe it's better to make all address fields nullable on database level?

I'm not sure if this is a smart idea. I think at least the street, zipcode, city & country should be required.
Shouldn't there also be a streetnumber field by the way?


update vllm cuda runtime image based on rc2

@tarukumar could you backport it to releases/2.15.0 branch pls?


Add footer links to "How we'll use your data" and "User agreement"

How we'll use your data: [Pending the creation of a page for this] see text in content repo.
User agreement: https://www.consumerreports.org/cro/2015/01/user-agreement/index.htm

@benrito Footer links have been updated.
I opened a separate issue #62 to add in the content when it is finalized. Looks like there is still some discussion in the content doc.

Looks good!


Fix issues with header expanded

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #401
Test URLs:

Before: https://main--bevespi--hlxsites.hlx.page/
After: https://issue-401--bevespi--hlxsites.hlx.page/

@lansami after approving I found a regression: close butto missing on mobile view

I could not reproduce the issue highlighted at https://github.com/hlxsites/bevespi/pull/409#issuecomment-1819409864 hence approving and merging


Spike investigate pause and resume

PR for changes for claims from staff iDAMS and adds Pause function PoC

Closing as replaced by PR #18


Long/wrong? reference path for get_statistics

https://primitybio.github.io/cellengine-python-toolkit/statistics/#cellengine.utils.api_client.APIClient.APIClient.get_statistics

Looks like maybe one too many APIClient?

It's the correct number of APIClient, but it is a bit annoying. I can certainly remove the root path if you'd like

It's the correct number of APIClient, but it is a bit annoying. I can certainly remove the root path if you'd like


Extract 2020 Stories

Description
Extract the 2022 stories from the PDFs and make them ready.
Tasks
Include specific tasks in the order they need to be done in. Include links to specific lines of code where the task should happen at.

[ ] Run extraction pipeline to interim
[ ] Clean up interim to processed
[ ] Commit, do a pull request

Is this a duplicate of #15?


Window Resizing with CTRL/ALT

Description of the new feature / enhancement
From KDE Window Resizer: It allows you to press ALT and move your windows by left-clicking and dragging from anywhere, without having to click on the title bar, and to resize by right clicking and dragging, without needing to grab the edges.
Scenario when this would be used?
The idea is to allow moving windows without having to grab the title bar, and to resize them without having to grab the edges. It’s just a nice way to work with open windows, makes moving them around and sizing them much more versatile once you get used to it. The snap to edge functionality is also a very nice addition.
Supporting information
Like this tool: https://www.freewaregenius.com/kde-window-resizer-move-and-resize-windows-from-anywhere-in-the-style-of-kde-linux/

Thanks for your message. This is a Duplicate of an other issue. Additional comments may be added there. /dup #269


Add JetBrain's DataGrip/IntelliJ

I think this one the best IDE for Tarantool for now.

@kokizzu, I think we can update links in PR and proceed with merge.
Link: https://plugins.jetbrains.com/plugin/17422-tarantool-database

Squashed commits, camelcased product names (as it is written on the official website).


Has failed to load correctly.

My friend is getting a has failed to load correctly error all the sudden while everything is working fine for me even though we've been using the same exact modpack with no changes to it for months now.
Here's the crash log. https://pastebin.com/5UqFKiHm

it randomly fixed itself


Update models to correspond to the actual PayPal responses

Namely Refund, Authorization and Capture all contain an intermediate "reason" field in their status_details.
https://developer.paypal.com/api/orders/v2/#definition-refund_status_details
https://developer.paypal.com/api/orders/v2/#definition-authorization_status_details
https://developer.paypal.com/api/orders/v2/#definition-capture_status_details

thanks


ImportError

An error occurs when I run the following commands:
conda create -n py36eap python=3.6
conda activate py36eap
conda install -c pytorch pytorch
conda install -c anaconda cudatoolkit=9.2
conda install -c conda-forge sox
conda install -c pytorch torchaudio
python

import torchaudio
waveform, sample_rate = torchaudio.load('/home/lst/t.wav')

The error is
ImportError: /home/lst/anaconda3/envs/py36eap/lib/python3.6/site-packages/_torch_sox.cpython-36m-x86_64-linux-gnu.so: undefined symbol: _ZN3c105ErrorC1ENS_14SourceLocationERKSs
This error seems to be related to cudatoolkit, because this error did not occur when I run the following commands (did not install cudatoolkit):
conda create -n py36eap python=3.6
conda activate py36eap
conda install -c pytorch pytorch
conda install -c conda-forge sox
conda install -c pytorch torchaudio
python

import torchaudio
waveform, sample_rate = torchaudio.load('/home/lst/t.wav')

I found that this error is caused by installing cudatoolkit from the channel anaconda. If I install cudatoolkit by "conda install -c pytorch cudatoolkit=9.2", this error will not occur.


allow sort by select fields from custom select fields

When I select some custom fields such as count(id) as total_num and pass q[s]=total_num+asc or q[s]=total_num+desc, it is ignored by search(params[:q]). Because when I try model.total_num, it works, it should allow order by total_num when I pass it in q[s]=total_num.

I also tried scope :sort_by_custom_name_asc, order('custom_name ASC')
scope :sort_by_custom_name_desc, order('custom_name DESC') as per meta_search's documentation, but it does not work either.


Pressing Enter in Files List Search box causes reload

My Setup

Operating System: Windows 10
App Version: 2.13.1

[x] I have tested with the latest version
[x] I can simulate the issue easily

Description

Open a chat room/channel
Open the Files List (using the paperclip icon or the kebab menu)
Click in the search field
Type a search term and press the Enter key on the keyboard, or just press Enter

Current Behavior

The application and/or server reloads (I don't have visibility into this)

Expected Behavior

Nothing -- the same behavior when searching the chat content. (The Files List searches as you type. Enter is unnecessary, but people do it anyway.)

Issue moved to RocketChat/Rocket.Chat #11998 via ZenHub


fixed paint fill tool

Resolves
Fixes issue with paint bucket not working when clicking in the middle of an object

Fixes ENG-8488

Proposed Changes
Makes the intersection bigger when selecting objects
Test Coverage
https://www.loom.com/share/840ff942b8de48f68591478987410b46?sid=499c64de-84c0-4b31-b8d4-1642febc7fdf
use the various tools and make sure they're correct

@toto4tots this seems pretty safe - can we get this live today?

Probably won't get to it today but will try to look at it tomorrow


feat: upgrade lance to 0.10.15

This includes some fixes for writing to datasets that have had schema evolution applied.
Full changes at https://github.com/lancedb/lance/releases/tag/v0.10.14

Nevermind, handled in https://github.com/lancedb/lancedb/pull/1229


Please expose Dep in Vue.util

What problem does this feature solve?
This is for users who are implementing bridges between the reactivity of VueJS and external systems which manage their own data internally and which have their own reactivity system.
Giving a way to users to access Dep will allow them to define a dependency in a simple way. The use case is for defining changing values from other systems (mini-mongo's reactive queries, for instance) as dependencies in watched functions.
Currently, the users can only use defineReactive(), which means that there should be an object and a field for the dependency to exist. It is quite painful since the only thing needed is a const dep = new Dep() on which we would call depend() each time the external resource (function, db cursor, etc ...) changed.
What does the proposed API look like?
I propose to expose Dep in the object Vue.util.

For reference, Meteor has a dependency tracking system very similar to the one used in VueJS, and they expose their Tracker.Dependency class to the users on purpose :

Applications will find Tracker.autorun useful, while more advanced facilities such as Tracker.Dependency and onInvalidate callbacks are intended primarily for package authors implementing new reactive data sources.

I hope the same can be done on VueJS.

Can you please clarify how this issue correlate with https://github.com/vuejs/vue/pull/4652?

You are totally right. I missed this PR when I did my search earlier. Thanks a lot!

Can this be reopened since mentioned pull request was abandoned?

I made this package which exposes Dep and Watcher classes.


double cast by dpct

I tried the DPCT tool from Syclomatic. It does not generate the cast...
sycl::rsqrt((double)dist_sqr * dist_sqr * dist_sqr);

Hi @jinz2014,
If I understand you correctly, the original CUDA code effectively calls rsqrt(double) even though coords_t is float, and you would therefore expect that the translation tool should respect that and cast the intermediate result to make sure the right function is being called.
I think your best bet is to make an issue in the Syclomatic repository as I don't think this is necessarily related to the code in this repository specifically.

Thank you for your reply. I'll close the issue.


Wires and cables can't be powered with lever

It seems that wires and cables cannot be powered directly with Lever. I'm not sure if it was intended or not.

It's semi-intentional, but after reconsidering it, it probably should work like the way you expected and I should be able to make it work like that.
In the meantime, you can power levers with wires by attaching the lever to the same block as the wire (the wire will receive the power conducted indirectly through a solid cube).

Or can create his own lever( with wire or stone plate). Having multiple types. Like the delayed levers, or inverse lever (Lever + Not Gate)

Fixed in 1.16.5-<IP_ADDRESS>


Question about Dynamic Registration example

func authenticated(with user: User) {
    ...
    Container.userProviding.register { UserProvider(user: user) }
    ...
}

In the above example that you provide, what was the way that userProviding was initially registered? Should this be created as a nilable, a UserProvider that takes no user, or even a separate type conforming to UserProviding protocol?

Considering that I made up the example... ;)
Let's go with the optional protocol version.
extension Container {
    static let userProviding = Factory<UserProviding?> { nil }
}

And just to round out the example...
func logout() {
    ...
    Container.userProviding.register { nil }
    ...
}

Thanks for this.
Would a better approach be to create a custom scope for authenticated users, and then reset this?
Also, following the guide you provided, it would seem that calling:
Container.userProviding.reset()

Should also set it back to nil, if I have understood it correctly.

Thanks for this.
Would a better approach be to create a custom scope for authenticated users, and then reset this?
Also, following the guide you provided, it would seem that calling:
Container. userProviding.reset()

Should also set it back to nil, if I have understood it correctly.

That was primarily an example I made up to show how you could change behavior during runtime. I wouldn't read too much into it from an architectural standpoint.
That said, I've done the session scope thing in several apps.
And yes, gold star! Reset would work as well.


"0" in boolean context evaluates to False

While looking at http://rosettacode.org/wiki/Temperature_conversion#Perl_6, it occurred to me that it's a bit unfortunate that the string "0" (and not the integer) evaluates to False.  It's not much consistent either, considering that other strings of null numerical value (e.g.  "-0" or "0+0i") evaluate to True.
If "0" was evaluating to True, the loop could be written:
while my $temperature = prompt "Temperature: " {
    ...
}

with no risk of ending the program prematurely if the user enters "0".
See also IRC backlog of this day.

I daresay it's what I would expect according to the principle of least
surprise as a Perl5 hacker.
IIRC, in Perl5 there is "0 but true" that evaluates to a true value in
boolean context (or "0E0" for what that matters), but it becomes the
integer 0 when evaluated as a number (I'm completely ignorant about Perl6
number system).
Ciao,
Flavio.

2015-03-11 10:48 GMT+01:00 grondilu<EMAIL_ADDRESS>
While looking at http://rosettacode.org/wiki/Temperature_conversion#Perl_6,
it occurred to me that it's a bit unfortunate that the string "0" (and not
the integer) evaluates to False. It's not much consistent either,
considering that other strings of null numerical value (e.g. "-0" or
"0+0i") evaluate to True.
See also IRC backlog of this day.
—
Reply to this email directly or view it on GitHub
https://github.com/perl6/specs/issues/87.

+1 to the string "0" being True, and the number 0 being false.
If I have a statement if $value I typically want either Str.Bool ("Does this string have characters"), OR Num.Bool ("Is this number non-zero"), not some combination of the two. Perl 5's behavior ("0" false) has caused dumb bugs in a number of my Perl 5 programs, and at least one bug in Rakudo's CORE.setting (see https://github.com/rakudo/rakudo/commit/dd4a0e6f066308f5cdac0f85d21d9cc046025f3b)

:-1: for me. Testing a string for length is more explicit. Having different behavor based on the type of the argument would produce action-at-a-distance bugs that are much harder to nail down than the examples mentioned above.

@zoffixznet what do you mean by "different behavor based on the type"? I mean, that is hat types are for, encapsulate behaviour. For me a "0" being a string but boolifying like a number is pretty weird.

@FROGGS , I gues it's a difference of backgrounds. I'm very new to Perl 6, but have been coding Perl 5 for years. For me, this code/result would be pretty weird, especially if that sub is from some module about whose innards I should not care.
zoffix@~:/tmp$ perl6 -e 'sub foo ($x) { if ( $x ) { say "Self-destruct sequence activated"; } else { say "We get to live another day" } };  foo(0); foo("0");'
We get to live another day
Self-destruct sequence activated
zoffix@~:/tmp$

But you do bring up a good point that types encapsulate behaviour and the above should probably be sub foo ( Str $x ) { ...

Or even sub foo ( Str() $x ) { ... or sub foo ( Real() $x ) { ...

I'm reverting to :+1:  then

I have very mixed feelings about this, coming from a Perl 5 background.  I'm used to not caring about the data type (and having it be unknowable), and I have thought falsy "0" to be convenient.  At the same time, I've been tripped up on bugs like the 0° temperature (even though real programmers use Kelvin).
Anyway, changing Str.Bool in Rakudo only generates 5 spectest failures, 4 of which are direct tests of 0.Str's truthiness (S03-operators/context-forcers.t, /S32-str/bool.t).  The only interesting failure is in S26-documentation/09-configuration.t, on the sheep test.
Additionally, Str.Bool seems about 9% faster without checking for "0" in my primitive A/B test.  Common op, but marginal gain.

This issue can be considered fixed: https://github.com/perl6/specs/commit/befb20c3bf
Now we just need to align rakudo+roast.


feat(email): Artwork images are linkable

This PR resolves AMBER-415
Description
This adds a link to the artwork image being sent, so the user can tap on it. Works for single or multiple images. Also important to note that links work on published artworks; otherwise, only the image is attached:
https://github.com/artsy/energy/assets/236943/827dcf15-22ad-4b7f-8623-5efa94b5e56f
Additionally, fixes QR code generation:

@jonallured since yr OOO today i'm just gonna merge! can follow up.