Compliance text explaining usage of Client VPN for teams (with ranking)

Describe the issue
We want some guidance text for teams to be able to use and make an informed assumption of risk over the use of Client VPN for teams to use tools like DB front-ends.
Which Sprint Goal is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' description (created in ZenHub) should clearly list Sprint Goals. This section should indicate which 'goal' this issue is related to.
Additional context

skillsaw analogy, here's your new tool don't cut your fingers off.
CDN region and ISO implications - it's a sub feature of VPC
https://aws.amazon.com/vpn/client-vpn/

This ticket describes an example of something we want to do generally for cloud services offered by CSPs:

provide an indication of industry standard certifications (ISO 27000:*, SOC II, etc.) a service has

provide an indication whether BC Gov ISB has/is/will specifically review and if an ISB review has/is taken place provide an indication of the status (not reviewed, queued for review, in-progress, complete) as well as the outcome of the review (acceptable, not acceptable)

any known relevant notes/tips/best practices a team should consider prior to/while using a service

the existing aws-services-masterlist.xls can be used as a starting point, with columns added as necessary to capture the elements above.

a mockup of a "v2" of the services list has been assembled in AirTable

ticket #777 also involves surfacing the services list within our BC Gov AWS "start page" where the informational elements described here would be very useful for tenant teams

Definition of done

Brainstorm with Shea about the ranking format
A tiered ranking of some sort "alpha (pathfinding), beta, live (fully reviewed and compliant)" - to what degree it's had oversight from compliance.
A text explainer that we will eventually bolt into the tab pages in the login screen page.

@sheaphillips there is a note in the ticket 'Brainstorm with Shea about the ranking format'

let me know if you want to meet or just add to the ticket. Thx

@bluemel-gov I am doing some thinking/research on this and will have notes to add here or share with you otherwise.

@bluemel-gov please see updates to "Additional Context" above.  I can provide access to the AirTable PoC as well via other channel.

moved to backlog due to ongoing tasks on lambda and certs SPIKE ticket

blocked atm due to conflicting branch task

Correction: Client VPN is a feature of VPN
Update:  Client VPN and VPN service are services offered in Canada, but aren't ISO compliant at the moment.
unclear how appropriate use policy (AUP), section 4 applies,

spoke with policy and governance teams
sending a note on current setup and proposed guidance to stakeholders

sent draft to compliance staff, waiting for confirmation/update from review before closing ticket.

"Working with Client VPN
You can work with Client VPN in any of the following ways:
Amazon VPC console
The Amazon VPC console provides a web-based user interface for Client VPN. If you've signed up for an AWS account, you can sign into the Amazon VPC console and select Client VPN in the navigation pane.
AWS Command Line Interface (CLI)
The AWS CLI provides direct access to the Client VPN public APIs. It is supported on Windows, macOS, and Linux. For more information about getting started with the AWS CLI, see the AWS Command Line Interface User Guide. For more information about the commands for Client VPN, see the AWS CLI Command Reference.
AWS Tools for Windows PowerShell
AWS provides commands for a broad set of AWS offerings for those who script in the PowerShell environment. For more information about getting started with the AWS Tools for Windows PowerShell, see the AWS Tools for Windows PowerShell User Guide. For more information about the cmdlets for Client VPN, see the AWS Tools for Windows PowerShell Cmdlet Reference.
Query API
The Client VPN HTTPS Query API gives you programmatic access to Client VPN and AWS. The HTTPS Query API lets you issue HTTPS requests directly to the service. When you use the HTTPS API, you must include code to digitally sign requests using your credentials. For more information, see the AWS Client VPN actions."
--- https://docs.aws.amazon.com/vpn/latest/clientvpn-admin/what-is.html

DoD #3 - Can be done in Airtable. Connect with @wrnu


Add support for in-browser mnemonic accounts for UI e2e testing scenarios

Just a suggestion for cases when it's not possible to fully e2e test things like perawallet or myalgo, a simple in-browser mnemonic account is useful for e2e tests in tools like cypress, selenium, playwright because it's easier to automate input of a mnemonic phrase rather than automation real providers.
Can function similar to the existing KMD provider - on select it asks for a passphrase of an account and that's it. Related documentation or warnings can be supplied that it's only recommended in testing/dev environments.
Let me know if more examples of how this provider can be useful for ui testing just let me know. Also if you'd agree that this is useful i can try the initial pr draft myself - i believe it should be relatively easy to implement.

Added PR with proposal https://github.com/TxnLab/use-wallet/pull/28

Huge thanks for that PR. Closing this issue as your PR is in review. :)


Add NTRU + some small schema changes

Add data for scheme “NTRU”
Make classical security level optional
Allow nist category value of 0.

Thanks. See also the comments inside the changes above.
What I'm the most uncertain about is the security levels. There are lots of numbers flying around and no simple summary. Could you independently extract numbers from the paper so that we can see whether we end up with the same result? (Rather than just checking if you find my numbers somewhere in the paper)

I'm arriving at the same numbers (Table 6, hybrid attack). They clearly understate security, since they just set o(1)=0. Also, I'm not sure if we should take the non-local model numbers. Maybe we should at least take the NIST categories from the local model, but stay with the bit costs of the non-local model (Similar to Dilithium, where the bit costs do not match the NIST levels).

(Similar to Dilithium, where the bit costs do not match the NIST levels).

But there, it is because they say "our estimates are very conservative, so we put it in category X even though the numbers are a few bits too low". Here, it's two completely different models. I don't think we can mix those.


Redstone support for Commandsigns

Hello this isnt an issue.
More a question. Is it possible to add Redstone support to your plugin? Like you can Run CMDS with redstone power also with inverted Signal support.

This is not supported no.
The closest is Tripwire support.

when i want to add it by my own, which class you would prefer to add it ?

in executeTasks i found this section:
@Override
	public void run() {
		final Player player = this.executor.getPlayer();
		if (player != null) {
			try {
				if (player.isOnline() && !player.isDead()) {
					this.executor.execute();
				}
			}
			catch (CommandSignsException e) {
				Bukkit.getScheduler().runTask(CommandSignsPlugin.getPlugin(), () -> player.sendMessage(e.getMessage()));
			}
			finally {
				this.executor.stopPlayerTask(this);
			}
		}
	}

is this the event when player clicks on it ?

Not exactly
Events are received in the CommandSignListener (controller package)
There, there is a executeCommandBlock method that triggers the command sign

Thanks for that. I hope I get some working stuff out :D

How do you choose between the possible Blocks (Sign,Lever) to Generate the Individual menu.
Because only the Lever has the ActivationMode where you did this ?

There is a method to override in the EditionMenu
"shouldBeDisplayed"
It is overriden in CoreMenuActivationMode

ok i wont destroy the functionality of your base so i try to Implement it via Addon

I'm a bit curious, wouldn't it be easier for you to simply use the game's base CommandBlock if you need redstone ?

Maybe it will, but its still more comfortable with your plugin to do the stuff i want.
Also im not good at coding on a CommandBlock... even its simple. also i want unified using.
Like run specify commands wenn a train goes over an detection rail. stuff like that.
i also dont like CommandBlocks because they not really safe.

Ok i got a new idea out of that what i wanna to do. but i dont know exactly where i get started...
I want to write a new Plugin to make Scriptable Books tha you can enchant on Blocks or items. with a customized Scripting Language that supports custom variables than can be used like placeholders when you like to execute commands z.B(the Players X coordinate + 100) and stuff like that.
Even get scripts on Cubes and Execute them over PlayerClickEvent or RedstonePowered.
Im a very new to Java but even very good at C# which looks for me very similar to Java.
But i think when i try to do that all by my own I think it could get very worse..


i2c?

can i use this to detect interrupts from i2c devices like an MPC23017 port expander?

Yes, this should be possible. For example, this mechanism is used to detect interrupts from an MCP9808 in this repo: https://github.com/fivdi/mcp9808-temperature-sensor


typo: Double word "the"

@nschonni : Thanks for your contribution! The author, @mikejo5000, has been notified to review your proposed change.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/data-tools/fill-datasets-by-using-tableadapters.md
:white_check_mark:Succeeded

docs/debugger/debugging-absolute-beginners.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


remove --decommission from cockroach quit

Fixes #7656.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/91b501766a1d997193ebab8e4c92b7c9c1d6cae0/
Edited pages:

v20.2/cockroach-quit.md


what if I am using px4?

what if I am using px4? I do not have Qualcomm Snapdragon

Hi @vxgu86!
Any autopilot can be used as long as you can send velocity commands. The core code is autopilot agnostic. The code that interfaces with the autopilot is in saftey.cpp.
I would suggest writing your own node that subscribes to the /goal topic that comes from safety.cpp (using snapdragon_msgs). Then, use mavros (or whatever) to relay the goal msg to the pixhawk.

I have questions when running simulation.
I could post picture here so I send you a email at gmail, could you help me please?
thanks, it's about global status error with map error

@plusk01 I still have not solved this error，could you help please

From @vxgu86:

hi,really nice job. and thanks for sharing
I have got some questions, could you share some idea?
##1 you said the following in the github:
To run a simulation (referred to as a trial) use the following incantation. There must not be a roscore running before you run this step.
$ rosrun aclswarm_sim trials.sh -f swarm6_3d -i
but if I start a roscore first, the command above could not executed due to that:  A roscore is already running. Shutdown roscore and try again.
##2 when I click start, the RViz and rqt pop out like in the picture, but I could not see any motors,
there is global status error, nothing show up in the right window. I do not know how to fix this?

##3 you make this great job with Qualcomm Snapdragon Flight, could I say that, the "Qualcomm Snapdragon Flight" is like a mini-computer+pixhawk?
the ros nodes are running on the mini-computer part and send commands like changespeed to the flying control part like pixhawk?
and the "Qualcomm Snapdragon Flight" is a mixer that combine them together?
I am not familiar with pixhawk, not to say the "Qualcomm Snapdragon Flight".
##4 I recall some algorithm called CBBA, also from MIT, do the consensus have something in common with it?
do you have any explaniation or documents that I can learn from for the job, really great job ,and I want to learn from it.
thanks!!!!!!!!!

Thanks for your kind words!

The instructions say: "There must not be a roscore running before you run this step."
I have added an rviz file that automatically configures the sim visualization in a3d00bb1042cbd51c3321674a668f42fbd886dd7. Pull and run the same steps again.
Correct, Snapdragon flight is a mini-computer + pixhawk autopilot. ROS runs on snapdragon flight Linux CPU side, sends motor commands to DSP/low-level microcontroller side.
Yes, we utilize CBAA in our distributed task assignment algorithm. See our paper for more details.

Hope this helps!

closing, feel free to reopen if you're still having issues


Issues/716

PR includes

[x] Bug Fix

Related issues
Resolve taskany-inc/issues#716
QA Instructions, Screenshots, Recordings
longest text with icon doesn't break between

Передумал, на уровне приложения поправлю


The link to docs is broken

Hello! Recently discovered your project on PyPI and got interested in it, but couldn't open the docs - the link is (maybe) broken. Searching it in ReadTheDocs didn't get any result with valid links. Can you please check the link?

Appreciated for your report. The DNS system for the documentation seems to
have a little bit of problem. I'll let you know as soon as I fixed it.
On Sat, 29 May 2021, 6:11 pm ASMaksimov2007, @.***>
wrote:

Hello! Recently discovered your project on PyPI and got interested in it,
but couldn't open the docs - the link is (maybe) broken. Searching it in
ReadTheDocs didn't get any result with valid links. Can you please check
the link?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/melvinchia3636/YouTube-Scraping-API/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APMTCUBZMBVW2ORIJKKTFRTTQC4VJANCNFSM45YEUWDQ
.

The documentation has now been migrated to a new place: https://ytsa.thecodeblog.net


games: /s/name/pname&version/

Motivation for this change
#103997
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 127823 run on x86_64-linux 1

1 package marked as broken and skipped:

beret

11 packages failed to build and are new build failures:

kodiPackages.steam-launcher: log was empty
lutris: log was empty
protontricks: log was empty
steam: log was empty
steam-run: log was empty
steam-tui: log was empty
steamcmd: log was empty
vessel: log was empty
xonotic-dedicated-unwrapped: log was empty
xonotic-glx-unwrapped: log was empty
xonotic-sdl-unwrapped: log was empty

59 packages built:

andyetitmoves
asc
ballAndPaddle
bitsnbots
bottles
bsdgames
chessdb
crack_attack
doom-bcc
eboard
eduke32
exult
fsg
gav
gltron
gmad
gnome.atomix
gnome.gnome-klotski
gtetrinet
icbm3d
kobodeluxe
macopix
neverball
njam
openlierox
orthorobot
playonlinux
pokerth
pokerth-server
pong3d
prboom
racer
rili
rimshot
rocksndiamonds
rogue
scrolls
sgtpuzzles
sienna
snake4
steam-run-native
tcl2048
teetertorture
tennix
tintin
tome4
typespeed
uhexen2
ultimatestunts
vectoroids
xbomb
yquake2-all-games
yquake2-ctf
yquake2-ground-zero
yquake2-the-reckoning
zandronum
zandronum-server
zod
zoom

@SuperSandro2000 anything more to do?

No. Thank you for your work!


"error TS6053, File source.integration.ts not found" and two more files

Bug description
When running:
npx ts-to-zod userInterface.ts
Three errors occur, stating that three files are missing: source.integration.ts, source.ts and source.zod.ts.
Input
export interface User {
	username: string;
	user_description?: string;
	user_tags?: string[];
	github_account_link?: string;
	following: number[];
	followed_by: number[];
	follower_count: number;
	authored_ideas: number[];
	owned_projects: number[];
	watched_projects: number[];
	date_joined: Date;
	date_updated: Date;
}

export interface NewUser {
	username: string;
	user_description?: string;
	user_tags?: string[];
	github_account_link?: string;

	// These attributes aren't needed / are server
	// Generated

	// following: number[];
	// followed_by: number[];
	// follower_count: number;
	// authored_ideas: number[];
	// owned_projects: number[];
	// watched_projects: number[];
	// date_joined: Date;
	// date_updated: Date;
}

Expected output
... The generator Zod schema ...

Actual output
⠋ Validating generated typesDeprecationWarning: 'createTypeAliasDeclaration' has been deprecated since v4.8.0. Decorators are no longer supported for this function. Callers should switch to an overload that does not accept a 'decorators' parameter.
⠋ Validating generated types    Error: error TS6053: File 'C:/VS Code/DevIt/devit/front-end/types/source.integration.ts' not found.
The file is in the program because:
Root file specified for compilation
The file is in the program because:
Root file specified for compilation
error TS6053: File 'C:/VS Code/DevIt/devit/front-end/types/source.zod.ts' not found.
The file is in the program because:
Root file specified for compilation
Versions

Typescript: v4.9.4
Zod: 3.20.2

Same problem. I don't see any of these files (source.ts, source.integration.ts etc) in the library files. I had to add the flag --skipValidation in order to make it work

These files are generated here. The problem is Windows-specific, and happens due to incorrect handling of file paths somewhere between TS Compiler API and ts-to-zod internals.
I will investigate when I have time, but if your generated schema will be used by ts-node or tsc later, you can avoid the issue by passing --skipValidation flag.

closing for now as we now run successfully run the automated tests on windows.


Workplan Page - Viewer persmission problems

The Download Workplan button should be disabled for non-team members
when a viewer looks at the workplan they are not assigned to, they see a select label where the bulk action box is for team members. this should not appear. it should be a disabled checkbox.

(If yes, list here)
Screenshot
(Link above will always be the most up-to-date version.)

"when a viewer looks at the workplan they are not assigned to, they see a select label where the bulk action box is for team members. this should not appear. it should be a disabled checkbox."
It should not appear or it should be a disabled checkbox

the select label should not appear.
the disabled checkbox should.


GUI

Added GUI using dearpygui so users can save their config and change config settings in GUI

Checking the code, the interface was not very interesting, i.e. not very user friendly, and also almost half of the original code is cut out. I think GUI will be written in PyQt5, the most optimal module. You can see a rough design of the application, I'll work on it some more.


Make the signup page responsive

Hey @AtriSukul1508 , I would like to work on this issue under JWOC. Can you assign it to me?

Go ahead @Laxmankohar

@AtriSukul1508 , Have a  look.

Add some merging at the top and bottom and in the first picture reduce the height of each input box and the signup button a little bit

good


Fixes issue where keyboard dismiss would scroll to top

Reverts https://github.com/react-native-community/react-native-webview/pull/134 to fix https://github.com/react-native-community/react-native-webview/issues/201

:tada: This PR is included in version 2.14.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


JWT Auth Handling Port

@scottf did you mean auth with JWT/creds, or having the JWT management API?

@scottf did you mean auth with JWT/creds, or having the JWT management API?

Auth Handling via JWT credentials. Maybe also any JWT utils from Java as the JWT utils don't exist in .net v1

Yes.
You also need to sign the nonce from the server INFO with the private key.

Yes. You also need to sign the nonce from the server INFO with the private key. It has to be also handled on reconnections.

nice. yes those are done as well. In that case I'm going to close this issue. We can open another for JWT utils later since I think that should be a separate thing.


feat: Can you support llama3?

Feature request
https://llama.meta.com/llama3/
Motivation
No response
Other
No response

Any update? It would be very interesting to have llama3 available

llama 3 is already supported.


Deduplicate ensureValidMerge check

when there is a call in IndexWrier#maybeMerge->updatePendingMerges->registerMerge
i think the ensureValidMerge is duplicated check  which do the same logic in the code:
https://github.com/apache/lucene/blob/bed07c6b0242646306470df9265469f6a811b5b2/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java#L4766-L4777
and when check error, it return false early.

Good catch!  Thanks @luyuncheng.
Except, the ensureValidMerge would throw an exception in this case -- can we fix the duplicated code to throw that same exception?

Except, the ensureValidMerge would throw an exception in this case -- can we fix the duplicated code to throw that same exception?

@mikemccand thanks for your advice,  i added throw exception in https://github.com/apache/lucene/pull/12237/commits/d14f5d4a254b425d2b4e3e14e71b4510b9fec818 and fixed test testLiveMaxMergeCount when throw the same exception in iterator
MergePolicy selected a segment (_2e) that is not in the current index _0(10.0.0)


[must-gather-operator] maintenance

Type of repository request
maintenance
Requested name for the repository
must-gather-operator
Additional details
Please add the following github secrets
QUAY_USERNAME
QUAY_PASSWORD
with push grants to the following quay repo (create them if necessary):
quay.io/redhat-cop/must-gather-operator
quay.io/redhat-cop/must-gather-operator-bundle
these repos should be public.
Finally disconnect travis and any permission that it holds against this repo.

Review request:
cc: @redhat-cop/container-cop-core

Resolved by #311


[REVIEW]Fix cli_args related failures

This pr:

Removes cli_args from global context to make  it easy for a single client to pass them across queries
Fixes failures described at: https://github.com/rapidsai/tpcx-bb/pull/33#issuecomment-658444670
Renames cli_args to config

Thanks for the hard work figuring out what was happening with the config being read on all workers, coming up with the fix, and updating the many many queries.
Approved pending confirmation you tested that this works at SF1k for all queries (besides known dask query #14 and blazing q #5.)

Can confirm both these things.  Merging it in. :-)


Abstract Engine class

Create an abstract Engine class that OpenGLEngine and VulkanEngine both extend

CSCI441Engine -> GLFWEngine -> OpenGLEngine -> OpenGL3DEngine
                            -> VulkanEngine


Shield removes scripts without content

When building the application with the following script:
<script
    type="text/javascript"
    id="Cookiebot"
    src="https://consent.cookiebot.com/uc.js"
    data-cbid="d14922fe-e985-4886-9910-cf8a45c1406b"
    data-blockingmode="auto"
    async>
</script>

I get the following error:
09:15:11 [WARN] [@kindspells/astro-shield-post-config-setup] Script "https://consent.cookiebot.com/uc.js" must have either a src/href attribute or content, but not both. Removing it.

Hi @dsmith-digitalmint , I'm sorry for my delay in responding to this issue. These past weeks I've been overloaded.
You can avoid this issue by removing all spaces inside the <script> block. So, instead of writing:
<script
    type="text/javascript"
    id="Cookiebot"
    src="https://consent.cookiebot.com/uc.js"
    data-cbid="d14922fe-e985-4886-9910-cf8a45c1406b"
    data-blockingmode="auto"
    async>
</script>

Write:
<script
    type="text/javascript"
    id="Cookiebot"
    src="https://consent.cookiebot.com/uc.js"
    data-cbid="d14922fe-e985-4886-9910-cf8a45c1406b"
    data-blockingmode="auto"
    async></script>

I'll be working on a more flexible solution, but this will solve your problem for now.

I tried that and got the following error:

DId you want to put another bounty on this issue like we discussed?


[Bug]: fork snippet is not provided within a class method

Description
Although this snippet is provided within a module-level function, it is not visible within a class method as shown below.

Steps to Reproduce
Prompt for completions for the following cursor positions.
class MyClass {
    function name() {
        fo<CURSOR>
    }
}

Affected Version(s)
Ballerina 2201.8.5 (Swan Lake Update 8)
OS, DB, other environment details and versions
OS: macOS 14.2.1 23C71
JDK: openjdk 17.0.8 2023-07-18
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Also, does not support within isolated functions.


Automatic temperature parameter tuning on SAC

Implement automatic tuning of temperature parameter of entropy and reproduce results from Soft Actor-Critic Algorithms and Applications.

https://github.com/keiohta/tf2rl/commit/f102b2b9ac3caf5e925917abdab4a93eb6455771 tunes temperature parameters on SAC and SAC-discrete, but does not work well on SAC-discrete.
We might need to search optimal target entropy.


Remove #[available_gas]

Gas calculation used for available_gas is incorrect, because it doesn't include the cost of contract execution. It's a misleading parameter and we should remove support for it.

We should probably throw an very explicit error in case the user tries to use this attribute in tests.


Mass update (Mehrfachänderung): Do not make a preselection for property update to avoid mistakes

When a user tries to edit properties, they might not want to overwrite them, but add new properties.
Currently "Overwrite" is pre-selected, which would remove all non-selected properties by mistake.

In most cases, "Add" would be a better choice.
As this might not be true for every use case, I would suggest to make no pre-selection in this dialog and let the user choose if they really want to overwrite or add new properties.
I would be nice to get some feedback for this feature, we then can probably provide a pull request.

Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know.
Thank you again for your valuable feedback.

This is not yet solved, but it's more a feature request and should be easy to fix.
Eventually I would tackle it on boost day.


You can check what CSS rules apply. The font-size is 16px in the material themes and 14px in all other. Can be verified in our online demo. https://blazor.radzen.com/dropdown


Refactor heterogeneous graph compare into a test utility

Minor refactor of @gcwenger's powerful new type-heterogeneous graph comparison test framework. This branch removes the BACKEND_NAME cmake variable dependence and opts for using template params to pick the desired backends to compare. With this change the comparison methods introduced in #2020 can be used as a header utility in individual backend source files.

For backend comparisons of graphs, there are three identified use cases:

Backend specific comparison tests. Tests a specific backend is making to ensure specific regressions
Graph specific comparison tests. Tests the results of all backends to ensure each produce equivalent results.
A combinations of 1 and 2 in a separate utility binary.

Current master(28002287d410d14a610fb4808c038af2ee97c3a6) has partial support for 1 and 2, whereas this PR adds full support for (1) but only partial supports (2) as it would require multiple comparator and test instantiations for each backend.
Thus, the proposal is to close this PR until all three points above are met.


Commit VSCode settings in version control

Forgetting to run forge fmt is a frequent source of error for CI failures in PRs.
@mds1 - what do you think about committing a minimal set of VSCode settings in version control, so that VSCode users get auto-formatting on save?
e.g.
{
  "[solidity]": {
    "editor.defaultFormatter": "NomicFoundation.hardhat-solidity"
  },
  "editor.formatOnSave": true,
  "solidity.formatter": "forge"
}

Alternatively, we could use JuanBlanco.solidity. I don't mind either way.

I'm personally not a fan of adding IDE specific settings to repos for a few reasons, mainly that (1) not everyone uses VSCode, and (2) of those that do, not all of them use the same solidity extension. In the past to make things easier for contributors I'll just fix the fmt issues myself before merge so I think the current approach seems ok :)


docs: add k8s audit config examples

Signed-off-by: Michele Zuccala<EMAIL_ADDRESS>What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
Adds examples on how to configure k8s auditing
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A

@zuc: The label(s) area/documentation cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: Michele Zuccala<EMAIL_ADDRESS>What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
Adds examples on how to configure k8s auditing
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: zuc
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [zuc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Merge siloes and filtering

This ticket is actually about two similar problems:
Merge filtering.
Right now a MergePlanner is instantiated for each index pipeline.
It is initialized withthe list of existing splits as given by the metastore and updates itself with the newly created splits.
If several pipeline targetting the same index exist on the same node, or if on several nodes, merge planner will
spawn conflicting merge operations, ending up as a failure on  publish, respawning the entire indexing pipeline.
In the future the plan is to handle this problem by centralizing the merge planning on a node responsible for the control plane.
However, we will probably have a need for a workaroudn to allow some clients to distribute their indexing using #1794.
Merge siloes
We will soon introduce index partitioning, a functionality in which indexers are producing many splits that attempt to isolates tags.
Merging splits from different tags would defeat the purpose.
We need a way to tell the merge policy to consider the different partition independently.

Solution
We want to isolate the extract the merge pipeline out of the regular pipeline.
After the extraction, we should have:

one merge planer per index.
one supervized merge pipeline per index (downloader, executor, packager, uploader, publisher)
one indexing pipeline per source

If there are several source on the same node indexing the same indexer, their respective publisher will route published splits to the same merge pipeline (associated to the index).
We can assume that the merge planner is simple enough to never die, and does not require supervision.
The rest of the pipeline however is tricky.
The simplest is probably to have a supervised pipeline containing merge executor, packager, uploader, publisher. (no sequencer needed)
We need a mechanism for the merge planner to know about failed merge.
The merge pipeline supervisor could for instance send the merge planner a message to trigger the reload of the information from the SQL database (or we could have some Drop Guard travel with the splits... The Drop guard would lock/unlock the splits).
Once this is done, we only need to add a node_id to SplitMetadatas and have the merge planner only consider splits with the right node id. (Source_id is not necessary)
Finally we want, we want the merge planner to siloe the splits per partition_id (as added in #1821) and only consider merging split with the same partition_id.

Assigning to @guilload as I'm going in holiday and this might be blocking.

Merge siloes and filtering is done in #1865
But we can track other parts in new issues:

The simplest is probably to have a supervised pipeline containing merge executor, packager, uploader, publisher. (no sequencer needed)

We need a mechanism for the merge planner to know about failed merge.
The merge pipeline supervisor could for instance send the merge planner a message to trigger the reload of the information from the SQL database (or we could have some Drop Guard travel with the splits... The Drop guard would lock/unlock the splits).


can I replace the log package with zap?

I use the zap to take over the gin logger and other package's log.it'sI use zap to take over the log output of the package in the project, and I also want to take over the log of gin-oauth2 using zap, is there any solution?

@wuzhican right now there is no solution for this. I think what we can do is to use a minimal log interface such that it would satisfy the requirement of the library. In this case I would hop that basically any logger could be able to use.
Do you want to propose a PR?

This still open for contribution? Would really like to log in JSON. and with a minimal interface for let's say info(), error() and warn()
if custom logger is used, it will replace calls in ginoauth2.go
func errorf(f string, args ...interface{}) {
	logf(glog.Errorf, f, args...)
}

func infof(f string, args ...interface{}) {
	logf(glog.Infof, f, args...)
}

func infofv2(f string, args ...interface{}) {
	logf(glog.V(2).Infof, f, args...)
}

with the LoggerInterface.info() or LoggerInterface.error()
will submit a PR with proposal


[fuel-jackson] Add Request.body(any: Any) extension method

I'd like to be able to make requests like this:
 val (request, response, result) = Fuel.post(url)
            .body(MyCustomRequestBodyObject(...)) // here
            .responseObject<MyCustomResponseBodyObject>()

Currently I have an extension method in my project which allows this:
fun Request.body(any: Any) = body(mapper...)

Would be nice if this was a part of the fuel-jackson module.

I don't think I quite understand what you're asking for 😅. I personally think it's great to add project-based extension methods in your project!

I don't think I quite understand what you're asking for 😅. I personally think it's great to add project-based extension methods in your project!

The kotlin-jackson module adds responseObject() as an extension-function, so you can easily convert a HTTP response body to a Kotlin object.
I'm proposing adding another extension-function, body(), so you can easily convert a Kotlin object to a request body.

Got it. Can you post the extension method in full that you currently use? I think we can add this to all the libraries, if applicable!

I can do that tomorrow. It's just the standard serialization call though, nothing out of the ordinary.
It will work fine with all libraries.

fun Request.body(any: Any) = body(defaultMapper.writeValueAsString(any))

That'd be great.

I'm switching from fuel-gson to fuel-jackson and this is a missing feature where gson has a jsonBody extension

@benjefferies yes, I feel like adding jsonBody or body everywhere is cewl :)

@tipsy are you happy to throw a quick PR? I would love to see it added ❤

I tried to clone the project and run it locally, but got an SDK location not found. error. I have some other stuff I have to deal with today, so I can't really spend too much on this.

I tried to clone the project and run it locally, but got an SDK location not found. error. I have some other stuff I have to deal with today, so I can't really spend too much on this.

Ah it is looking to Android SDK path.

Ah it is looking to Android SDK path.

Why? How is this project related to Android?

Ah it is looking to Android SDK path.

Why? How is this project related to Android?

fuel-android is

fuel-android is

I see. Is Android Studio required to run the project?

No, @kittinunf and I both run IntelliJ (NO Android Studio).

I can take a look at this if people are busy 🙋

Is there any updates on this issue?
Thanks


Ftrack: Fix version 0 when integrating to Ftrack - OP-6595

Changelog Description
Fix publishing version 0 to Ftrack.
Additional info
Error:
Traceback (most recent call last):
  File "C:\Users\tokejepsen\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Users\tokejepsen\OpenPype\openpype\modules\ftrack\plugins\publish\integrate_ftrack_api.py", line 57, in process
  File "C:\Users\tokejepsen\OpenPype\openpype\modules\ftrack\plugins\publish\integrate_ftrack_api.py", line 149, in integrate_to_ftrack
TypeError: 'NoneType' object has no attribute '__getitem__'

Testing notes:

Setup version 0 for any or all hosts.
Publish version 0 to Ftrack from the configured host.

I tested with Ftrack and Nuke publish, withouth issue.


New SRU Server for CERL's HPB

The SRU server for CERL's HPB database has changed and is now: https://sru.k10plus.de/hpb
Sorry...

Thanks for the message, I'll update the link!

https://github.com/TomDeneire/ulpia/commit/cbf995103fc1eff9aa0724465e0d67bf70640fc8


feat: expand card to fit three buttons

@arispech This is ready for a round of qa

@arispech This is ready for a round of qa

Looks good to me!


Layout Tuner

This PR:

Launches layout tuner based on a flag.

You are pushing duplicate commits again. Fetch and rebase from cmu-db:master.

I already did that, this is effect of recursive merge.


Metadata is not passed from http_connect() and http_connect_upstream() HTTP Events.

Problem Description
Metadata is not passed from http_connect() and http_connect_upstream() HTTP Events.
Steps to reproduce the behavior:
I hook every event from HTTP Events in the order they fire during the request. In every event, I modify flow.metadata and expect on every further step to read metadata from the previous event. This logic starts to work as expected only starting from requestheaders(). Metadata is not passed from http_connect() to http_connect_upstream(), and
from http_connect_upstream() to requestheaders()
I run mitmproxy in upstream mode using:
mitmdump -s test_meta.py --set confdir=.mitmproxy --set upstream_cert=false --mode upstream:http://$UPSTREAM_HOST:$UPSTREAM_PORT --upstream-auth $UPSTREAM_USERNAME:$UPSTREAM_PASSWORD
Here is my addon for testing:
import mitmproxy.http
import mitmproxy.connection
import mitmproxy.proxy.server_hooks

class TestMetaAddon:
    def client_connected(self, client: mitmproxy.connection.Client, *args, **kwargs):
        print(f"client_connected")
        return

    def server_connect(self, data: mitmproxy.proxy.server_hooks.ServerConnectionHookData, *args, **kwargs):
        print(f"server_connect")
        return

    def http_connect(self, flow: mitmproxy.http.HTTPFlow):
        print(f"http_connect: {flow.metadata}")
        flow.metadata["http_connect()"] = 1

    def http_connect_upstream(self, flow: mitmproxy.http.HTTPFlow):
        print(f"http_connect_upstream: {flow.metadata}")
        # Comment failed asserts
        # assert flow.metadata["http_connect()"] == 1

        flow.metadata["http_connect_upstream()"] = 2

    def requestheaders(self, flow: mitmproxy.http.HTTPFlow):
        print(f"requestheaders: {flow.metadata}")
        # Comment failed asserts
        # assert flow.metadata["http_connect()"] == 1
        # assert flow.metadata["http_connect_upstream()"] == 2

        flow.metadata["requestheaders()"] = 3

    def request(self, flow: mitmproxy.http.HTTPFlow):
        print(f"request: {flow.metadata}")
        assert flow.metadata["requestheaders()"] == 3

        flow.metadata["request()"] = 4

    def responseheaders(self, flow: mitmproxy.http.HTTPFlow):
        print(f"responseheaders: {flow.metadata}")
        assert flow.metadata["request()"] == 4

        flow.metadata["responseheaders()"] = 5

    def response(self, flow: mitmproxy.http.HTTPFlow):
        print(f"response: {flow.metadata}")
        assert flow.metadata["requestheaders()"] == 3
        assert flow.metadata["request()"] == 4
        assert flow.metadata["responseheaders()"] == 5

        flow.metadata["response()"] = 6

addons = [TestMetaAddon()]

System Information
Mitmproxy: 9.0.1
Python:    3.10.4
OpenSSL:   OpenSSL 3.0.7 1 Nov 2022
Platform:  macOS-12.4-arm64-arm-64bit

These two hooks work with a separate flow object, and metadata is not shared between them. See https://docs.mitmproxy.org/stable/api/events.html. That's kind of by design. What are you looking to accomplish?

And my described flow works with mitmproxy, but only for HTTP requests, not for HTTPS. As described here https://github.com/mitmproxy/mitmproxy/issues/5998

I ended up with patching flow.cleint_connect in http_connect(). It seems to be only one param that is same between http_connect() and http_connect_upstream()
    def http_connect(self, flow: mitmproxy.http.HTTPFlow):
        """
        Only for HTTPS requests.
        Read auth credentials for connection to mitmproxy

        :param flow:
        :return:
        """
        username, password = self._parse_proxy_auth_header(flow)
        if not self._validate_mitm_auth(username, password):
            return self.return_mitm_auth_required_response(flow)

        # patch `flow.client_conn` in order to pass `mitm_auth` to `http_connect_upstream()`event
        setattr(flow.client_conn, "mitm_auth", (username, password))
        logging.debug(f"http_connect(): mitm_auth={(username, password)}")

    def http_connect_upstream(self, flow: mitmproxy.http.HTTPFlow):
        # Only for HTTPS requests. Set another username/password for connecting to UPSTREAM proxy server
        if hasattr(flow.client_conn, "mitm_auth"):
            mitm_user, mitm_passw = getattr(flow.client_conn, "mitm_auth")
            self.set_upstream_proxy_auth(flow, mitm_user)

These two hooks work with a separate flow object, and metadata is not shared between them. See https://docs.mitmproxy.org/stable/api/events.html. That's kind of by design. What are you looking to accomplish?

Wonder why is this by design
I want to pass some data from http_connect to requestheaders too

This should be open until this feature/fix is shipped

Wonder why is this by design

Because it's a different request/response pair, and each flow corresponds to one request/response pair.

I want to pass some data from http_connect to requestheaders too

As mentioned above, the recommended way to do this right now is to use a WeakKeyDictionary with ClientConnection as key (see the proxyauth addon above).


use the symbols parameter to download only requested currencies

http://api.fixer.io/latest?symbols=USD,GBP

Hi - thanks for submitting this! :smile:
Downloading only the rates for the required currencies is a great idea, I must have overlooked these parameters when I started the project. I'll try and put something together asap.


Mark method CountryCodeToRegionCodeMap#getCountryCodeToRegionCodeMap as public

In our project we used the following workaround to get access to the CountryCodeToRegionCodeMap#getCountryCodeToRegionCodeMap method:
package com.google.i18n.phonenumbers;

import java.util.List;
import java.util.Map;
import java.util.Set;

public abstract class CountryCodeToRegionCodeMapWrapper {
    static final Map<Integer, List<String>> _CountryCodeToRegionCodeMap = CountryCodeToRegionCodeMap.getCountryCodeToRegionCodeMap();

    public static Map<Integer, List<String>> getCountryCodeToRegionCodeMap(){
        return _CountryCodeToRegionCodeMap;
    }
}

We put CountryCodeToRegionCodeMapWrapper class in the package com.google.i18n.phonenumbers to have access to this method. It will be very useful, to have direct access to this method without above hack.

+1

+1

+1

+1

+1

Can you please let us know why you need this CountryCodeToRegionCodeMap?

@padmaksha I try to describe all our use-cases. We'd like to have access to the following data/operations:

Get all country codes (CountryCodeToRegionCodeMap.getCountryCodeToRegionCodeMap().keySet())
Get region codes by country code (I think we can do it via PhoneNumberUtils#getRegionCodesForCountryCode, so it would be ok, but we can minimize memory usage a little bit, if we use CountryCodeToRegionCodeMap directly without PhoneNumberUtils).
Retrive CountryCodeToRegionCodeMap.getCountryCodeToRegionCodeMap() and send this information via GWT RPC on the client side. It is necessary for our UI components.

@vbauer
CountryCodeToRegionCodeMap is one of our helper API that is developed for internal API usage. CountryCodeToRegionCodeMap returns the country codes and region codes that libphonenumber supports. Ex: It does not have details for countries like South Georgia & South Sandwich Islands, Antarctica..etc. Exposing helper APIs is not a good thing to do for lot of reasons like maintenance, compatibility.. etc
Can you please specify the exact use case for which you need this map in front end?
Ex: Depending on the country code entered in the UI do you want to get the region code list..etc
Please check other methods like PhoneNumberUtil.getRegionCodesForCountryCode(), PhoneNumberUtil.getCountryCodeForRegion() if they suits your use case. Or you need to add more logic to create your custom map. Similar APIs are available in our JS library so that you can use directly in your UI components.

Please reopen if there is something to mention here.
Thanks for all the support.

@vbauer:
For the specific use-cases that you mention:

Get all country codes (CountryCodeToRegionCodeMap.getCountryCodeToRegionCodeMap().keySet() -- what do you use this for? We could theoretically provide a method e.g. getValidCountryCallingCodes() to return a set of all the valid ones if there's a need for this? This would include global network calling codes e.g. +800 -> would you want that or not?

Get region codes by country code (I think we can do it via PhoneNumberUtils#getRegionCodesForCountryCode, so it would be ok, but we can minimize memory usage a little bit, if we use CountryCodeToRegionCodeMap directly without PhoneNumberUtils). -- Do you do something other than just parse the number? Is that why you need this? Maybe an image of your widget would help here?

Retrieve CountryCodeToRegionCodeMap.getCountryCodeToRegionCodeMap() and send this information from server-side to client side (via GWT RPC). It is necessary for our UI components. -- What do you do with this?

Given the current API, what we'd expect users to do is call getSupportedRegions (and optionally getSupportedGlobalNetworkCallingCodes as well), and then use this to build a custom map of the data they want, keyed off whatever they want. (E.g. you could imagine building a map of calling code to a "country" object that contains an image link to a flag and the name(s) of the countries to show on hover). Does this not work for your use-case? I wouldn't think the region-codes themselves are something you want to show to users directly in your UI.


Fix chef_*_remote autocompletion in knife plugin

Perhaps its the result of changes in knife's output, but the existing chef_*_remote completions in the knife plugin haven't been working for me. Here's my fix.

Doesn't look like this will cleanly merge at the moment, want to resubmit?

Fixed in 10618f323f2915c2a7281e258a42d05faf1cc1af. Closing.


azuit-edged 1.4.9 doesn't want to build with read-only root

I'm still investigating this, but build with ro root started failing for me (maybe it's "broken" for longer than since 1.4.9).
bitbake ends with
do_rootfs: The following packages could not be configured offline and rootfs is read-only: ['aziot-edged']
log:
NOTE: If an image is being built, the postinstalls for the following packages will be postponed for first boot: aziot-edged
NOTE: Executing write_package_manifest ...
DEBUG: Executing python function write_package_manifest
DEBUG: Python function write_package_manifest finished
NOTE: Executing license_create_manifest ...
DEBUG: Executing python function license_create_manifest
DEBUG: Python function license_create_manifest finished
NOTE: Executing zap_empty_root_password ...
DEBUG: Executing shell function zap_empty_root_password
DEBUG: Shell function zap_empty_root_password finished
NOTE: Executing rootfs_update_timestamp ...
DEBUG: Executing shell function rootfs_update_timestamp
NOTE: rootfs_update_timestamp: set /etc/timestamp to<PHONE_NUMBER>3456
DEBUG: Shell function rootfs_update_timestamp finished
NOTE: Executing read_only_rootfs_hook ...
DEBUG: Executing shell function read_only_rootfs_hook
DEBUG: Shell function read_only_rootfs_hook finished
NOTE: Executing write_image_test_data ...
DEBUG: Executing python function write_image_test_data
DEBUG: Python function write_image_test_data finished
NOTE: Executing set_systemd_default_target ...
DEBUG: Executing shell function set_systemd_default_target
DEBUG: Shell function set_systemd_default_target finished
NOTE: Executing systemd_create_users ...
DEBUG: Executing shell function systemd_create_users
groupadd: group 'systemd-journal' already exists
useradd: user 'systemd-network' already exists
useradd: user 'systemd-resolve' already exists
useradd: user 'systemd-timesync' already exists
DEBUG: Shell function systemd_create_users finished
NOTE: Executing empty_var_volatile ...
DEBUG: Executing shell function empty_var_volatile
DEBUG: Shell function empty_var_volatile finished
NOTE: Executing deploy_pkgstatus ...
DEBUG: Executing shell function deploy_pkgstatus
DEBUG: Shell function deploy_pkgstatus finished
NOTE: Executing sort_passwd ...
DEBUG: Executing python function sort_passwd
DEBUG: Python function sort_passwd finished
NOTE: Executing rootfs_reproducible ...
DEBUG: Executing shell function rootfs_reproducible
NOTE: rootfs_reproducible: set /etc/version to<PHONE_NUMBER>3456
DEBUG: Shell function rootfs_reproducible finished
ERROR: The following packages could not be configured offline and rootfs is read-only: ['aziot-edged']
DEBUG: Python function do_rootfs finished

Guess it might be #108

It is that. Hmm being in .inc file it's not that easy to override ...

@sindelar-fr we added a post install script to add admin and sudo users to the iotedge group so the services could be start/stop/resume from an admin/sudo user directly.  On a read-only rootfs you need to add the following to your local.conf.  Just following what was done in the Debian/Ubuntu installers for IoT Edge.  @timesys-nathan noticed this during the Kirkstone Upgrade efforts.  Maybe needs to be refactored to omit as this seems only useful to desktop environments possibly?
IMAGE_FEATURES_append = " read-only-rootfs-delayed-postinsts"

@sindelar-fr and @ggjjj, on second thought, the below section in aziot-edged.inc needs to be omitted.  It's really only useful in a desktop environment.
pkg_postinst_ontarget_${PN}() {
    #!/bin/sh

    # Add each admin user to the iotedge group
    for u in $(getent group admin | sed -e "s/^.*://" -e "s/,/ /g"); do
        usermod -aG iotedge "$u" >/dev/null || true
    done

    # Add each sudo user to the iotedge group
    for u in $(getent group sudo | sed -e "s/^.*://" -e "s/,/ /g"); do
        usermod -aG iotedge "$u" >/dev/null || true
    done
}

@sindelar-fr and @ggjjj, on second thought, the below section in aziot-edged.inc needs to be omitted. It's really only useful in a desktop environment.
pkg_postinst_ontarget_${PN}() {
    #!/bin/sh

    # Add each admin user to the iotedge group
    for u in $(getent group admin | sed -e "s/^.*://" -e "s/,/ /g"); do
        usermod -aG iotedge "$u" >/dev/null || true
    done

    # Add each sudo user to the iotedge group
    for u in $(getent group sudo | sed -e "s/^.*://" -e "s/,/ /g"); do
        usermod -aG iotedge "$u" >/dev/null || true
    done
}

Yes, that's what I've done locally to temporarily unblock us - I've just removed this and it did build fine. But since it's included in the bb file, it's not that simple to get rid of in bbappend (I've seen something with using python to remove a variable of the function thus effectively removing it from what's already included, but that seems a bit more like a hack than a sollution and I didn't really have time to investigate it further yet).

@sindelar-fr it needs to be gone.  I debated putting it in their initially.  (I was not working with read only rootfs).  I then started working with a read only rootfs a couple of weeks ago and regretted my decision.

Fix merged. Please re-open if needed


Upgrade Jinja2.

I think we can easily upgrade Jinja2 since Jinja2 is well tested by the frontend tests.

Seems right to me, but @umairwaheed can you take a look for whether any of the Jinja2 changes are relevant (or allow us to delete any of our jinja2 interface code)?

Sure.

I have looked at the changelog of Jinja2 2.8, and apparently, new changes do not warrant a change in the interface code.

Cool, merged, thanks @sharmaeklavya2 and @umairwaheed!


Missing Last Verified Date on Service Details

"Last Verified" date does not show up on any of the Service Detail page on Staging V1.25.0 Server V1.13.24

Acceptance Criteria

[ ]  Last Verified date shows up at the bottom of Service Detail

Steps for QA:

Click on a topic
Click "Find related services near me"
Select a service record to open the service detail
Scroll to the bottom of the service detail
Check if the Last Verified date shows up

@tomy-pg Just want to clarify, is this an issue of missing data or do I need to add the verificationDate attribute myself from the backend? I've traced the service request and doesn't seem like the API response includes the verificationDate

the DateLastVerified is available data in the bc211 data set so I think you will need to ensure its being sent along with the rest of the data set attributes we want. Let me know if you need access to the bc211 data.

@tomy-pg  sure. is this data different from the one found in bc211/data folder?

OK, so fixing this issue actually requires changes all the way from the DB and the data importer to the REST API. It's complicated by the fact that there is a large server side refactoring PR sitting waiting to be merged. Pretty much nothing else has been changing on the server side for a while. Still, we need to have a conversation about how these two changes should be handled.
In terms of how to make the fix, the data verified field is sitting on the ResourceInfo node under the SiteService node that gets imported into the Service table. The server side code is heavily unit tested, so I would start out with ServiceParserTests and add a new test_can_parse_date_last_verified().

@rasmus-storjohann-PG I spent the last couple days getting familiarized with the backend code plus getting ramped up with Django. I don't see this change making a lot of dent. Just wondering if I can proceed according to the current system and not worrying about your changes.

Tested on Staging V1.31.0, server V1.3.30 on iOS:

[x]  Last Verified date shows up at the bottom of Service Detail


Use standard OCaml CI scripts

See https://github.com/ocaml/ocaml-ci-scripts
It will help to keep track of various OCaml/opam switches, and will relieve some workarounding efforts. So adding a new version in the build matrix would be very easy as adding a new line:
env:
  - OCAML_VERSION=4.02 [...]
  - OCAML_VERSION=4.05 [...]
  - OCAML_VERSION=4.07 [...]
  - OCAML_VERSION=4.08 [...]

See https://github.com/ocaml/ocaml-ci-scripts/blob/master/README-travis.md

thanks for the bug report! we switched away from travis to use azure pipelines recently, where we are able to get machines with much more capacity. Since Kremlin CI requires building F*, we are now able to get 2min turnaround times via our in-house docker container infrastructure, as opposed to 45+ min CI times previously

I removed the last config file that remained from the travis era


Option, Error type, lambda and namespace

Option, Error
Option and Error types will be simply a value variant but storing another value variant within
Probably should add function that returns type as string for the sake of making things clear
Lambda
Lambda will be simply the same signature as a function, and probably turn functions into an expression of sort that can be invoked with ()
Namespaces
Could add namespaces for the sake of managing files
Namespace of a file will be simply be in the file name
To "import" file content like functions and variables, you can do use namespace
To use imported file, you can use them by doing namespace::function, $namespace::variable, etc
Additional note
Apply after rework of script compiler in #66

Swapped backend in #130 , closing


[ALIGNED CHATBOX] becomes unaligned and rounded when using the PartyMode plugin in vencord

also the combo meter is placed above the chatbox, but never displays the combo

Just don't use the partymode plugin. Adding support for this would be super confusing when I maintain this in the future


Use torch.Generator for RNG

This PR refactors some of the parts that are random to use torch.Generator for reproducible results and also introduces a more generic list sampler for collating batches.

Codecov Report

Merging #18 into master will decrease coverage by 0.01%.
The diff coverage is 98.36%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   97.48%   97.47%   -0.02%
==========================================
  Files          19       20       +1
  Lines         635      672      +37
==========================================
+ Hits          619      655      +36
- Misses         16       17       +1

Impacted Files
Coverage Δ

pytorchltr/datasets/svmrank/svmrank.py
99.18% <83.33%> (ø)

pytorchltr/datasets/__init__.py
100.00% <100.00%> (ø)

pytorchltr/datasets/list_sampler.py
100.00% <100.00%> (ø)

pytorchltr/datasets/svmrank/example3.py
100.00% <100.00%> (ø)

pytorchltr/datasets/svmrank/istella_s.py
100.00% <100.00%> (ø)

pytorchltr/datasets/svmrank/mslr10k.py
100.00% <100.00%> (ø)

pytorchltr/datasets/svmrank/mslr30k.py
100.00% <100.00%> (ø)

pytorchltr/utils/tensor_operations.py
96.87% <100.00%> (+0.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e655c53...00c4f32. Read the comment docs.


⚠ Secret Website 3 has degraded performance

In ae76d89, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 10149 ms

Resolved: Secret Website 3 performance has improved in bb937a6.


changed last_modified to modification_date

in response to #12
Please follow the guidelines here to create a new pull request.
If your pull request requires discussion, make sure the OPTIMaDe developer list is alerted (for more info see the link above.)

It seems we have decided to only do last_modified, see issue #1 and PR #77.

We decided the other way: modification_date -> last_modified


Angular 8 + alasql

I wanted to process an array of objects with alasql.
Steps followed:

Installed alasql using sudo npm i alasql --save. Installed version - "alasql": "^0.5.1"
On compiling it gives the following error.

Any solution ?

Strange. What version of typescript are you using?

"typescript": "3.5.3" -

This cleared the error (with guidance from stackoverflow). But alasql stopped working and I changed over to SP in mysql to get the results...
Anyway, a solution to this issue may help many others and also alasql itself.

Thank you for letting me know. Hmm.
Any chance I can ask you to see if it works if you change those lines to
declare var _alasql: alaaSQLSpace.AlaSQL;
declare module 'alasql' {
    export var _alasql
}

Hi,
I am also facing the same issue. Any workaround is there to resolve this issue.
Thanks,
Naveen.

@mnjaya @gsknbabu
Any chance I can ask one of you to see if it works if you change those lines to
declare var _alasql: alaaSQLSpace.AlaSQL;
declare module 'alasql' {
    export var _alasql
}

It’s not working for me.
On Thu, 24 Oct 2019 at 4:41 PM, Mathias Rangel Wulff <
<EMAIL_ADDRESS>wrote:

@mnjaya https://github.com/mnjaya @gsknbabu
https://github.com/gsknbabu
Any chance I can ask one of you to see if it works if you change those
lines to
declare var _alasql: alaaSQLSpace.AlaSQL;
declare module 'alasql' {
export var _alasql
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/agershun/alasql/issues/1138?email_source=notifications&email_token=AAQ7S42JY77GPWWIAFHDZA3QQF7EVA5CNFSM4I2MXI72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEUYQI#issuecomment-545868865,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQ7S42ILKWRP3644YH4O5DQQF7EVANCNFSM4I2MXI7Q
.

--
Sent from Gmail Mobile

Hi,
I get the same error with the same versions.

Any update on this issue? Still seeing this error in Angular v8.* and AlaSQL v0.5.1

@frostbytedata Can you please confirm if the solution from @JanOnGit is working for you?


d3.nest reformats a Date object to a string

Using d3.nest to aggregate a dataset by date. My code:
vis.nestData = d3.nest()
	.key(function(d){ return d.survey; })
	.rollup(function(leaves){ return leaves.length; })
	.entries(vis.data);

vis.nestData.forEach(function(d){
	d.key = new Date(d.key);
})

vis.data has  field survey as JS Date objects.  Upon return, the keys become strings, NOT Date objects. The second call is needed to reformat them into dates. Somewhere in the nest call they are converted to strings.

This is the expected (and documented) behavior; keys are strong identifiers, not arbitrary types, so if you try to use a value that is not a string it will be coerced to a string.
This design is partly a consequence of earlier versions of JavaScript lacking the Map class. I think it would be reasonable to switch to Map internally as a breaking major change in the future.


libpng find_package broken

Describe the bug
When installing libpng and attempting to use through cmake, I get the error in the log section below.
Package installed correctly and I followed the instructions it gave:
The package libpng:x64-linux provides CMake targets:

    find_package(libpng CONFIG REQUIRED)
    target_link_libraries(main PRIVATE png_static)

Environment

OS: Ubuntu 18.04
Compiler: gcc 7.4.0/cmake 3.14.3

To Reproduce
Steps to reproduce the behavior:

./vcpkg install libpng
In my project's CMakeLists.txt do find_package(libpng CONFIG REQUIRED)

Expected behavior
I should be able to find libpng with find_package
Failure logs
CMake Error at /home/sebastien/.ezvcpkg/2019.07/scripts/buildsystems/vcpkg.cmake:266 (_find_package):
  Could not find a package configuration file provided by "libpng" with any
  of the following names:

    libpngConfig.cmake
    libpng-config.cmake

  Add the installation prefix of "libpng" to CMAKE_PREFIX_PATH or set
  "libpng_DIR" to a directory containing one of the above files.  If "libpng"
  provides a separate development package or SDK, be sure it has been
  installed.

Additional context
vcpkg folder installed/x64-linux/share/libpng contains the following files:
libpng16.cmake
libpng16-debug.cmake
libpng16-release.cmake

Renaming to:
libpngConfig.cmake
libpngConfig-debug.cmake
libpngConfig-release.cmake

lets cmake find the package as expected.

Hi @sjdrc
PR #7972 should fix this issue.
I will note, that the traditional way to include libpng is by using the built-in CMake module (call find_package(PNG REQUIRED) instead).

Ah right, if that is the case, should the The package libpng:x64-linux provides CMake targets: message recommend using find_package(PNG REQUIRED) instead?

The message is auto-generated by vcpkg when config files are detected, in this case it can be overridden by providing a usage file.
However, once the PR is merged both find_package(libpng CONFIG) and find_package(PNG MODULE) will work.


Issue 673 - fix indentation

Fixes #673
Changes proposed in this pull request:

Sorry this is such a big PR, but as the issue stated, there were many indentation issues.
All build indentation errors corrected: ember build completes with no errors

cc @HospitalRun/core-maintainers

Not sure why the tests failed on travis... they all pass locally?

@jmabry111, i tried to get travis to rebuild, but the button didn't seem to work. could you just add a commit run tests then remove it to rewrite history and force travis to rebuild

there seems to be a new error now, caused by snyk. ill look into it

Awesome... looks like the tests passed that time 👍

@jmabry111 thanks


URBNLin not installing

I know this is no fault of alcatraz, but there doesn't seem to be a wealth of resources around debugging this so I'll ask it here. URBNLin was merged into the packages this morning however when I or anyone else on the team here goes to install via alcatraz, it starts to load (shows the progress) and then stops. Other plugins work. Its also important to note that simply running the plugin project locally does properly install the plugin and it works. Is there something I'm missing?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/8867427-urbnlin-not-installing?utm_campaign=plugin&utm_content=tracker%2F282297&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282297&utm_medium=issues&utm_source=github).

Hey, that's because the name that is specified in the package.json doesn't match the name of the xcodeproj in the repository (where it's just called Lin).
This is actually mentioned in the README of the packages repo:

The url should be a repository containing the Xcode project, and the name should be the same as the .xcodeproj file.

but I should have checked it before merging, apologies!
In short: You'll have to update the name of the xcodeproj file and it should work :)

Doh! Thats my bad. I fixed it up (I hope) a couple of hours ago. Plugin still isn't installing though. Is there a length of time I should wait? Or do you have to push a button somewhere to make it pick up the new stuff? Thanks for your help!

Looks like a little (casing) typo:
"name": "URBNlin", URBNLin.xcodeproj
I've updated the name in the package list to reflect this and it installs ok for me now :)

Thank you, that was dumb. Sorry for the hassle

No problem at all!


Parity: Parity: XMLElement: XML Namespaces (final part)

⚠ Needs tests.
Fixes what NSUnimplemented() invocations remained in FoundationXML:

Finish implementing namespace accessors.
Finish implementing namespace utility methods for working with qnames;
Note that XQuery is unavailable in s-c-f.

@swift-ci please test

Fixes https://bugs.swift.org/browse/SR-10424


Add health check endpoint for Process Mapper

Configure a Process Mapper endpoint that is suitable for a health check (runs quickly and returns 200 code) in the Unity SSM parameters.  The SSM endpoint format is /unity/healthCheck/<MARKETPLACE_ITEM>/<COMPONENT_NAME>. The SSM parameters should follow the Unity conventions described at https://app.gitbook.com/o/xZRqGQeQXJ0RP4VMj7Lq/s/UMIRhLdbRQTvMWop8Il9/developer-docs/common-services/docs/users-guide/deployment/deployment-concepts-and-infrastructure/unity-ssm-parameters
Acceptance Criteria:

[ ] A process mapper endpoint to be used for a health check returns within 10 seconds and returns 200 code
[ ] Process Mapper health check endpoint is added to the shared service SSM parameters during deployment.

SSM endpoint could be /unity/healthCheck/shared-services/process-mapper

Status Update:

Added SSM parameters as a resource automated with Terraform: https://github.com/unity-sds/unity-analytics-dapa/blob/devel/terraform/ssm.tf
Next steps:

Add /health endpoint to backend process mapper server
Expose /health endpoint through the ALB
Add health check API to API Gateway: am-uds-dapa/processes/health

Status Update:

Added health check endpoint to the backend process mapper service
Modified load balancer to reflect the changes
Next steps:

Add an API Gateway path for the new endpoint
Automate the health check endpoint deployment in Terraform

Status Update:

Terraform automation of process mapper health check is fully implemented
Deployment is not yet tested due to a permissions issue.  API deployment now requires mcp-tenantOperator role.
Message from Gabe Ortiz on this: Sadly, we did have to clean up APIG permissions as they were only half working and Tenants would not realize this until after deploying something.  This permission was moved out of Tenant Developer and only exists at the Tenant Operator level.  You can upgrade your permissions, by request Tenant SysAdmin in NAMS or have someone in the tenantOperator role deploy that for you.

@jjacob7734 ping for status update.

Status

@zx128 completed SATERN training required to get mcp-TenantOperator role.
Just got this role added to his account on May 29.
He will now use the new role to fully test the Process Mapper health check endpoint deployment automation and get it deployed to Unity-Dev/Test/Prod environments.

Status

Completed and deployed to Unity-Dev/Test/Prod
Example: SSM configuration in Unity-Prod is arn:aws:ssm:us-west-2:217910134673:parameter/unity/healthCheck/shared-services/process-mapper/url
Terraform code checked in: https://github.com/unity-sds/unity-analytics-dapa/blob/devel/terraform/ssm.tf, https://github.com/unity-sds/unity-analytics-dapa/blob/devel/terraform/ag_hc.tf


NimBLE Gap device name limits (I need BLE name with 25 chars).

Hi, I'm using NimBLE on espressif ESP32 IDF version 4.0.
I have problems with the size of name of device (ble_svc_gap_device_name_set). We can put until 19 characters on device name.
I know the advertise table is limited in 31 Octets.  logging adv table: these 31 bytes is 3 for flags, 3 for tx power, 4 for service uuid, 2 for name header ... it lasts 19 bytes for name as I imagine.
How we can use a additional "scan response" with more 31 bytes to solve my problem.

Hi,
ble_svc_gap_device_name_set is used to set name for GAP DEVICE NAME characteristic in GAP service and not advertising i.e
Advertising data and scan response data you can configure independently.

How can we configure scan response? Do you have an example.

Hi @adrianolmar you can use ble_gap_adv_rsp_set_fields to set scan response. If you have ESP32 specific issues, feel free to raise issues here: https://github.com/espressif/esp-nimble/issues

@adrianolmar I would look here: https://github.com/apache/mynewt-nimble/blob/master/apps/peripheral/src/main.c
and here:
https://github.com/apache/mynewt-nimble/blob/master/apps/ext_advertiser/src/main.c

Because of no further replies, I'm assuming issue is solved, but feel free to reopen if needed @adrianolmar


Correct approach to separate static and dynamic regions

Hi, I have originally mentioned this issue in #1, but it seems to deviate from the original question, so I decided to open a new issue.
As discussed in #1, I tried setting the raw_blend_w to either 0 or 1 to create "static only" and "dynamic only" images that theoretically would look like the Fig. 5 in the paper and in the video. However, this approach seems to be wrong because from the result, the static part looks ok-ish but the dynamic part is almost everything, which is not good at all (we want only the moving part, e.g. only the running kid).
It's been a week that I have been testing this while waiting for some response, but still to no avail. @zhengqili @sniklaus @snavely @owang Sorry for bothering, but could any of the authors kindly clarify what's wrong with my approach to separate static/dynamic by setting the blending weight to either 0 or 1? I also tried blending the sigmas (opacity in the code) instead of alphas as in the paper, or directly use the rgb_map_ref_dy as output image, but neither helped.
https://github.com/zhengqili/Neural-Scene-Flow-Fields/blob/7d8a336919b2f0b0dfe458dfd35bee1ffa04bac0/nsff_exp/render_utils.py#L804-L809
I have applied the above approach to other pretrained scenes, but none of them produces good results.

Left: static (raw_blend_w=0). Right: dynamic (raw_blend_w=1).

Left: static (raw_blend_w=0). Right: dynamic (raw_blend_w=1).

I believe there's something wrong with my approach, but I cannot figure out. I really appreciate if the authors could kindly point out what's the correct approach. Thank you very much.

I read the paper you mentioned, I think that one's setting is much simpler than yours, and like you said they use mask loss to explicitly supervise the model.

where for static region, the static model should converge faster than dynamic model and gives less error, therefore dominate the static region, whereas for dynamic region, dynamic model converges faster

I think you are right. However the concern is that even if the static model learns faster in static region, it probably isn't able to fully learn it before the dynamic model learns something on it. As a result the "static only" is not bad (as shown in #1) but dynamic model still adds some layers on top of it to complete the scene and minimize color loss, making the segmentation (fg/bg separation) unmeaningful.
I agree that it's not the main contribution of the paper (the flow guidance is excellent!) and only a by-product, but I believe there are some people like me that are overwhelmed by the ability of such accurate segmentation, but could not find a satisfactory result (at least for now) in this code.

Thanks!  I believe blending weight is not the optimal way to go (although it gives me the least artifacts in my system) and removing weight and directly compose two models along the ray should be better, but this idea is not so easy to train on monocular videos.
And for challenging and complex dynamic scenes with a monocular camera, I have to add more and more components to make it work, which might not be the optimal way as well, so I hope someone could figure out a better and more elegant solution in the near future for this problem.

I actually tried the composition as in "nerf in the wild." It performs very well, separates almost perfectly the fg from the bg (with only very coarse mask as supervision). However my data is multiview, so I'm not sure if it translates to your monocular setting. I think this requires future solution!


Build openssl with enable-md2 flag to fix mamba

Checklist before submitting

[ ] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
We need to build openssl with enable-md2 flag so that mamba build works with. Otherwise we see the following error -
ImportError: /usr/lib64/librpmio.so.8: undefined symbol: EVP_md2, version OPENSSL_1_1_0

## Review process to land

1. All tests and other checks must succeed.
2. At least one [maintainer](https://github.com/open-ce/open-ce/blob/main/MAINTAINERS.md) must review and approve.
3. If any  [maintainer](https://github.com/open-ce/open-ce/blob/main/MAINTAINERS.md) requests changes, they must be addressed.

Closing this as this is no more needed.


fix: prefix-related error when downloading same EOProduct (when dest …

feat: requester_pays AwsDownload config option
feat: endpoint_url AwsDownload config option
feat: ignore_assets StacSearch config option
Your checklist for this pull request
Please review the guidelines for contributing to this repository.

[x] Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[ ] Check your code additions will fail neither code linting checks nor unit test.

Description
I have added:

endpoint_url option to AwsDownload section to get the possibility of changing it
ignore_assets option to StacSearch to get the possibility to get the EOProduct without assets (which is useful for AWS downloads)
Fixed the outputs_prefix related error (according to the docs, default is the temp folder)

The eodag.yml example with these options is attached.
eodag_gcs_example.yml.zip

Ran the linters, ran the tests (failed because of provider username/passwords), nothing changed, nothing to commit
Updated the branch

flake8 and black did nothing to mine changes. Why is that? (never used flake8/black before)

flake8 and black did nothing to mine changes. Why is that? (never used flake8/black before)

these tools are used in eodag pre-commit settings (and github actions) for linting / code formatting

@robert-werner thanks again for the PR. I just moved ignore_assets from search plugin to download plugin. I'll also add a new providers earth_search_gcs to search on earh_search and download on google cloud storage, following your example in eodag_gcs_example.yml.zip

The earth_search is existing provider, I want to PR a new search provider, that seeks on GEE (Google Earth Engine), and perspectively, downloads straight from it (not from GCS)


Support mixing cython.compile with directive decorators.

e.g.
import cython

@cython.compile
@cython.boundscheck(False)
def foo():
    ...

Depend on http://trac.cython.org/ticket/737
Migrated from http://trac.cython.org/ticket/738

@robertwb  Do you have knowledge of which pure mode decorators do mix with @compile?
@returns, @nogil, @locals and @cfunc are of particular interest.
Thanks

@h5rdly it would be nice if you could try out the relevant ones and provide a list in this ticket, so that we can see what exactly is there or isn't.


Remote cache usage is not resumed after temporary network drop

Expected Behavior
If the remote cache doesn't respond (for whatever reason), usage of it will be disabled for the remainder of the build. The expected behaviour is that the cache will be used again when Gradle detects that the remote cache is available again, e.g. through a configurable periodic background ping.
Current Behavior
As stated above, the remote cache availability will only be requeried when a new build is started.
Context
This affects particularly CI builds which will execute several thousands of potentially long running but cached tasks. If the cache doesn't respond in the beginning of the build, they will often time out.
Although network quality also can be improved outside of Gradle, this would improve CI build stability a lot.

There are two kinds of issues here:

Likely non-transient failure while communicating with the remote cache

There are problems like HTTP 401 or 403 that are a clear sign that the remote cache is not configured properly, and no amount of retrying will fix it. Being lenient here (=disable caching instead of failing the build) only leads to users not noticing the issue and going on without a remote cache. So instead we should fail the build immediately with a clear message.

Likely transient failure while communicating with the remote cache

This is about HTTP 500 or timeouts. We could be more resilient here, e.g. by disabling only after the third problem, or re-enabling after a minute (as proposed in the issue description). This makes sense because transient network errors can be a thing.
However, we need to make sure that transient problems don't go unnoticed. If the user has a bad connection on CI where they rely on a resilient protocol to keep things mostly working is probably a sign that they need to fix something in their infrastructure.
Maybe a summary at the end of the build could work. We should also show these problems prominently in build scans.

Artifact size too big

When the cache server refuses to store an artifact because it exceeds the size limit, we should not disable caching at all.

This is still on.


[Dialog] DialogTitle overrides DialogContent className

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

The DialogTitle className (MuiDialogTitle-root) is overriding the set className to DialogContent.
Expected Behavior 🤔

The DialogTitle className should not override the set className to DialogContent.
Steps to Reproduce 🕹

https://codesandbox.io/s/sparkling-architecture-47w73?file=/src/index.tsx
This is happening after<EMAIL_ADDRESS>To reproduce, change the package dependency in the codepen @material-ui/core to 5.0.0-alpha.36 or higher.

The reason is the breaking change introduced by https://github.com/mui-org/material-ui/pull/26323. @eps1lon should we improve the description of the breaking change? I think this is a corner case, but as it already came up as an issue maybe we should mention the bigger specificity that is introduced in the styles.

I didn't make that particular change nor do I think it should stay. It makes customization not straight forward. You'd have to ask @oliviertassinari what problem the sibling selector solves and what alternatives he tried.

The biggest constraint I had was the lack of support for &:first-child that emotion sets on us. We moved to &:first-of-type during the migration from JSS to emotion. But now, with a flat header. We can no longer rely on &:first-of-type either. The DOM structure is

div (MuiDialog-root)

h2 (MuiDialogTitle-root)
div (MuiDialogContent-root)

The least worse solution I could find is
https://github.com/mui-org/material-ui/blob/e8dd87d14f9d64719faaca9c8ff8c97e943262e3/packages/material-ui/src/DialogContent/DialogContent.js#L43

For the solution, an update of the docs like proposed by @mnajdova sounds great 👍
diff --git a/docs/src/pages/guides/migration-v4/migration-v4.md b/docs/src/pages/guides/migration-v4/migration-v4.md
index b66b55e80d..2d8629a8be 100644
--- a/docs/src/pages/guides/migration-v4/migration-v4.md
+++ b/docs/src/pages/guides/migration-v4/migration-v4.md
@@ -773,6 +773,10 @@ You can use the [`collapse-rename-collapsedheight` codemod](https://github.com/m
      </Typography>

Note that the DialogContent now applies its padding with a specificity of 2.
It was changed to work around the lack of support of :first-child in emotion.
See #26795 for more details.

Divider

Use border instead of background color. It prevents inconsistent height on scaled screens.

Why can't we apply the styles to the DialogContent? A Dialog should always have a heading anyway. Instead, people should add padding if they purposely omit the heading.

A Dialog should always have a heading anyway

@eps1lon It's written as is it was a fact. Why should a DialogTitle be always rendered? Material Design doesn't seem to support this affirmation.

Title (optional)

https://material.io/components/dialogs#usage
Or the first demo of the page.
It seems that they are consistent with the legacy version:
https://material.io/archive/guidelines/components/dialogs.html#dialogs-behavior

Most alerts don't need titles.

Instead, people should add padding if they purposely omit the heading.

Actually, we could likely leverage that a dialog title will most often be used to reverse the CSS tradeoff.

I have tried:
diff --git a/packages/material-ui/src/DialogContent/DialogContent.js b/packages/material-ui/src/DialogContent/DialogContent.js
index 131e5e6980..0ed698d896 100644
--- a/packages/material-ui/src/DialogContent/DialogContent.js
+++ b/packages/material-ui/src/DialogContent/DialogContent.js
@@ -32,7 +32,7 @@ const DialogContentRoot = styled('div', {
   // Add iOS momentum scrolling for iOS < 13.0
   WebkitOverflowScrolling: 'touch',
   overflowY: 'auto',
-  padding: '20px 24px',
+  padding: '0 24px 20px',
   ...(styleProps.dividers
     ? {
         padding: '16px 24px',
@@ -40,8 +40,8 @@ const DialogContentRoot = styled('div', {
         borderBottom: `1px solid ${theme.palette.divider}`,
       }
     : {
-        '.MuiDialogTitle-root + &': {
-          paddingTop: 0,
+      '.MuiDialogTitle-root + &': {
+          paddingTop: 20,
         },
       }),
 }));

But it's not working. Maybe we should add a new prop like noTitle on the DialogContent component, to flatten the CSS specificity for the most frequent use case.

A dialog having no title is problematic UI. Customization should not be our concern in this case. Otherwise we encourage problematic UIs.

Looking at WAI-ARIA, they seems to support that a dialog should always be labeled.

The dialog has either:
A value set for the aria-labelledby property that refers to a visible dialog title.
A label specified by aria-label.

We could support DialogContent being the aria-label of the dialog, and rendered as a h2, without the DialogTitle. This would help use better support the guidelines of Material Design.

A dialog having no title is problematic UI.

@eps1lon This is confusing me. Do you mean from a DOM perspective or a design perspective? The two seems distinct. Also, it seems exposed as an axiom, adding resources to support it would help.
I agree with this affirmation if it concerns the label of the dialog (not the title) and concerns the DOM aspect, not the design one.

Do you mean from a DOM perspective or a design perspective?

I don't know what a "DOM perspective" is. The DOM is just a programming interface.
I'm talking about a design perspective. Just as your documents should have titles. Dialogs are mini-documents that are nested within other documents. Especially for fullscreen dialogs I don't see how a dialog without a title is a good thing.

@eps1lon OK thanks for the clarification, so it's none of the option concepts I was wondering about (DOM, as the a11y tree, and design as the Material Design aspect. Your point is more conceptual, something that labels the content of the model, which is close to the a11y that requires a label. I agree.
Here Material Design is saying that the "title" can either be the "DialogTitle" or "DialogContent" (if alone).

Here Material Design is saying that the "title" can either be the "DialogTitle" or "DialogContent" (if alone).

I didn't find any such statement. I even found statements contradicting this claim:

A dialog’s purpose should be communicated by its title and button text.

-- https://material.io/components/dialogs#anatomy

When scrolling is required, the dialog title is pinned at the top, with buttons pinned at the bottom.

-- https://material.io/components/dialogs#behavior
The only statement that comes close is only applicable under certain conditions:

Titles should be succinct. They can wrap to a second line if necessary, and be truncated. If there are long titles, or titles of variable lengths (such as translations), place them in the content area instead of the app bar.

-- https://material.io/components/dialogs#full-screen-dialog
And then people can wire the dialog label up differently.

I didn't find any such statement.

I come to this conclusion that DialogContent can act as a title when DialogTitle is not rendered, from:
from https://material.io/components/dialogs#anatomy, the DialogTitle (the design element) is optional:

The interactive demo: https://material.io/components/dialogs#interactive-demo

The demo:

For the solution of this GitHub issue. My proposal would be:
diff --git a/packages/material-ui/src/DialogContent/DialogContent.js b/packages/material-ui/src/DialogContent/DialogContent.js
index 131e5e6980..5ecfb34f7c 100644
--- a/packages/material-ui/src/DialogContent/DialogContent.js
+++ b/packages/material-ui/src/DialogContent/DialogContent.js
@@ -5,6 +5,7 @@ import { unstable_composeClasses as composeClasses } from '@material-ui/unstyled
 import styled from '../styles/styled';
 import useThemeProps from '../styles/useThemeProps';
 import { getDialogContentUtilityClass } from './dialogContentClasses';
+import DialogContext from '../Dialog/DialogContext';

 const useUtilityClasses = (styleProps) => {
   const { classes, dividers } = styleProps;
@@ -32,18 +33,16 @@ const DialogContentRoot = styled('div', {
   // Add iOS momentum scrolling for iOS < 13.0
   WebkitOverflowScrolling: 'touch',
   overflowY: 'auto',
-  padding: '20px 24px',
+  padding: '0 24px 20px',
   ...(styleProps.dividers
-    ? {
-        padding: '16px 24px',
-        borderTop: `1px solid ${theme.palette.divider}`,
-        borderBottom: `1px solid ${theme.palette.divider}`,
-      }
-    : {
-        '.MuiDialogTitle-root + &': {
-          paddingTop: 0,
-        },
-      }),
+    && {
+    padding: '16px 24px',
+    borderTop: `1px solid ${theme.palette.divider}`,
+    borderBottom: `1px solid ${theme.palette.divider}`,
+  }),
+  ...(styleProps.noTitle && {
+    paddingTop: 20
+  }),
 }));

 const DialogContent = React.forwardRef(function DialogContent(inProps, ref) {
@@ -52,15 +51,18 @@ const DialogContent = React.forwardRef(function DialogContent(inProps, ref) {
     name: 'MuiDialogContent',
   });

-  const { className, dividers = false, ...other } = props;
-  const styleProps = { ...props, dividers };
+  const { className, dividers = false, noTitle = false, id: idProp, ...other } = props;
+  const styleProps = { ...props, noTitle, dividers };
   const classes = useUtilityClasses(styleProps);

+  const { titleId: id = idProp } = React.useContext(DialogContext);
+
   return (
     <DialogContentRoot
       className={clsx(classes.root, className)}
       styleProps={styleProps}
       ref={ref}
+      id={noTitle ? id : undefined}
       {...other}
     />
   );

This would solve the issue of @jlin5 by always having a flat level of specificity, making overrides easier. It also resonates with the point of @eps1lon around how the usage of the DialogTitle + DialogContent should be a lot more frequent.
But still, it allows to support the short alert dialog use case. It can be used like this:
diff --git a/docs/src/pages/components/dialogs/AlertDialog.tsx b/docs/src/pages/components/dialogs/AlertDialog.tsx
index d06b6c6860..0b79f9ed9d 100644
--- a/docs/src/pages/components/dialogs/AlertDialog.tsx
+++ b/docs/src/pages/components/dialogs/AlertDialog.tsx
@@ -28,14 +28,8 @@ export default function AlertDialog() {
         aria-labelledby="alert-dialog-title"
         aria-describedby="alert-dialog-description"
       >
-        <DialogTitle id="alert-dialog-title">
+        <DialogContent noTitle>
           {"Use Google's location service?"}
-        </DialogTitle>
-        <DialogContent>
-          <DialogContentText id="alert-dialog-description">
-            Let Google help apps determine location. This means sending anonymous
-            location data to Google, even when no apps are running.
-          </DialogContentText>
         </DialogContent>
         <DialogActions>
           <Button onClick={handleClose}>Disagree</Button>

Before

After

I don't understand why you're hell bent on making no title work when there's a really simple solution to the problem that puts the usability of the UI first: just add a title.

With the current behavior, an outlined TextField in a DialogContent doesn't display correctly its label.
https://codesandbox.io/s/textfield-in-dialog-content-dswq4?file=/demo.tsx

Have the same issue. Title gets rid of the top padding for me on Dialog Content. How come this doesnt follow the doc examples?

I just came to this issue after upgrading from v4 to v5. We have many dialogs where the first TextField label gets truncated as shared by @amaslakov above.

Was there a specific reason why this DialogTitle component didn't get the same prop system primaryTypographyProps as ListItemText. I'm running into a use case where our Design System wants to use a different variant for all DialogTitles. There's no easy way to do that for dialogs... ForListItemText I would just add prop overrides within ``primaryTypographyProps`...
But since h6 is baked in as the default DialogTitle typography variant, that's not possible.
I could always use disableTypography and add the right variant I wanted, but I feel like this could be supported to keep the whole design system idea.

I'm currently experiencing this same issue on<EMAIL_ADDRESS>Any padding-top I provide to the DialogContent component is overwritten with padding-top: 0 from the .MuiDialogTitle-root+.css-b3xomw-MuiDialogContent-root class.
I see that this thread hasn't had a reply in awhile. Has anybody been able to resolve this or find a work around?

I'm currently experiencing this same issue on<EMAIL_ADDRESS>Any padding-top I provide to the DialogContent component is overwritten with padding-top: 0 from the .MuiDialogTitle-root+.css-b3xomw-MuiDialogContent-root class.
I see that this thread hasn't had a reply in awhile. Has anybody been able to resolve this or find a work around?

We can't change anything for now, at least until the next major. I would propose bumping the specificity using &&

To solve the problem of the floating labels getting cut of I'm using this for now: createTheme({compontents: { MuiDialogContent: { styleOverrides: { root: { paddingTop: "20px !important" } } } }
You could also set overflowY: unset

I have fixed this by wrapping  in a div. Have not seen any side effects of this yet.

I have fixed this by wrapping <DialogContent> in a div. Have not seen any side effects of this yet.

worked for me , but still very hacky.

I'm currently experiencing this same issue on<EMAIL_ADDRESS>Any padding-top I provide to the DialogContent component is overwritten with padding-top: 0 from the .MuiDialogTitle-root+.css-b3xomw-MuiDialogContent-root class.
I see that this thread hasn't had a reply in awhile. Has anybody been able to resolve this or find a work around?

We can't change anything for now, at least until the next major. I would propose bumping the specificity using &&

As specified by @mnajdova here, best implementation right now would be ,
sx={{
        '&& .MuiDialogContent-root': {
          padding: '4px 24px',
        },
      }}


Feature: #290 HTTP client & auth challenge call

closes #290
What's changed:

HTTP client added to relay package w/ completion & async methods. Session's standard async API requires iOS 15+
Integrated AuthChallengeProvider call. Integration tested on dev API.

PS: It's ready, only needs to be instantiated in the SDK

Session's standard async API requires iOS 15+
but I understand you did not use it and did not have to increase minimal requirements, correct?

Session's standard async API requires iOS 15+

but I understand you did not use it and did not have to increase minimal requirements, correct?

Yes, I used continuations instead


bug: Side menu closing has visual problem in Edge

Type: bug
Ionic Version: 2.x
Platform: desktop browser
Run the following plunker in Edge browser on Windows:
http://plnkr.co/edit/nMWUDuqdPs6pxuhjQM2V?p=preview
Problem:
Open page 1 and on page 1 the side menu. When closing the side menu a black background can be seen on the right side upon the menu is fully closed. Seems to be a redraw/transotion issue.
This can only be observed in Edge browser, FF47 and Android are fine.

This issue got worse in beta.10, especially the closing side menu on a tabs page makes visual problems in Edge now. There can always be content from other tab pages seen, when the menu slide is closing and the content of another tab is scrolled in. Upon the menu is closed, the page is refreshed and it's fine.
This can only be observed with the ios theme. I'm gonna make an updated plunker for this.

@mpaland hi! can you record a quick video or gif? we don't have a windows machine right now :(

Sure, here it is.

Problem is, that this behavior in Edge is the same like in the native Windows app. I guess they use the same rendering engine...
Perhaps you can setup a Windows VM (on your Mac or Linux machine)

This is still observable in beta 11, no change.

Any update on this? I have this issue too but on iOS

@mpaland @elineopsommer I am so sorry, but I can't reproduce this bug without a windows machine.
I will try to get a VM working after RC1 is released :)

@elineopsommer can you file a new issue?

Hello all! After further review I am going to close this issue as a duplicate of https://github.com/driftyco/ionic/issues/8710.