[AQL Graph traversals] Feature request: Allow order:dfs + uniqueVertices:global and allow uniqueEdges:global

Hello,
Currently, order:dfs + uniqueVertices:global is not allowed. The doc explains that it is not allowed because it would return unpredictable results.
However, order:bfs + uniqueVertices:global is allowed, and leads to non-deterministic results, like the doc explains:

Note: Using this configuration the result is not deterministic any more. If there are multiple paths from startVertex to vertex, one of those is picked. In case of a weighted traversal, the path with the lowest weight is picked, but in case of equal weights it is undefined which one is chosen.

I would like to understand why one is allowed and not the other.
I understand that results of order:dfs + uniqueVertices:global will depend on the order of edges, but this the same for order:bfs + uniqueVertices:global.
I can imagine that a depth-first traversal will use less memory than a breadth-first traversal so allowing order:dfs + uniqueVertices:global may optimize some applications.
Hence, would it be possible to allow order:dfs + uniqueVertices:global in a future release? Or is there something I am missing that makes the bfs case fundamentally different from the dfs case?
Also, would it be possible to allow uniqueEdges:global? There are applications where using uniqueEdges:global would be useful. Results will also be non deterministic but are useful in some cases.
Thank you!

Hi @OlivierSohn!
I'll try to fill in some of the details.

I would like to understand why one is allowed and not the other.

First, regarding the (non-)determinisim of {order: "bfs", uniqueVertices: "global"}. While the paths that are taken aren't deterministic, the set of vertices visited/returned will be the same. So regarding FOR v, e, p IN ..., the set of vs will be deterministic (and in any bfs-order). The set of es and ps can be different though, that's what mentioned in the docs.
Now generally, that is similar for a dfs, which you correctly pointed out. But note that a traversal always has a maximum depth assigned, e.g. FOR v, e, p IN min..max. And with that and uniqueVertices: "global", dfs behaves badly. Take for example a graph with the vertices {s, a, b, c}, and the edges {(s, a), (s, b), (b, a), (a, c)}.

A traversal FOR v IN 0..2 OUTBOUND s, with dfs and uniqueVertices: "global", could either return [s, a, c, b] or [s, b, a]. This is because, when visiting b before a, c will be reached at depth 2.
So in short, for a dfs with uniqueVertices: "global" (and a maximum depth, which is not optional), not even the set of vertices returned is deterministic. That's why the combination is disallowed.
That being said, I get that this can be desirable. However, it will need more profound changes to AQL traversals than just allowing the option combination, so it can be a sensible choice.

I can imagine that a depth-first traversal will use less memory than a breadth-first traversal

Not generally. The difference between a dfs and a bfs is the central data structure: a stack for dfs, and a queue for bfs. Depending on the actual data, one might use less memory than the other; but in the end, it's always linear, in particular for uniqueVertices: "global", where the already visited vertices have to be kept track of.

Also, would it be possible to allow uniqueEdges:global? There are applications where using uniqueEdges:global would be useful.

We are aware of that, and we have it in our backlog to discuss this. If you could describe your usecase(s) for this, it might be helpful.
Best regards,
Tobias

So in short, for a dfs with uniqueVertices: "global" (and a maximum depth, which is not optional), not even the set of vertices returned is deterministic. That's why the combination is disallowed.

Thank you @goedderz ! Indeed it makes sense with your explanation.

That being said, I get that this can be desirable. However, it will need more profound changes to AQL traversals than just allowing the option combination, so it can be a sensible choice.

In fact, knowing now that it could give different results I don't think it would use this functionality even if it was slightly faster than bfs.

I can imagine that a depth-first traversal will use less memory than a breadth-first traversal

Not generally. The difference between a dfs and a bfs is the central data structure: a stack for dfs, and a queue for bfs. Depending on the actual data, one might use less memory than the other; but in the end, it's always linear, in particular for uniqueVertices: "global", where the already visited vertices have to be kept track of.

That is true, thanks.

Also, would it be possible to allow uniqueEdges:global? There are applications where using uniqueEdges:global would be useful.

We are aware of that, and we have it in our backlog to discuss this. If you could describe your usecase(s) for this, it might be helpful.

Cool! The use case I have in mind here is the following:

I have an edge collection Edges
I have a condition Cond (a filter) that tells me whether I am allowed to use a given edge of Edges or not, based on its properties
I have a source vertex S
a distance Dist
I define the (abstract) subgraph Sub = all vertices V such that "distance between S and V using edges of Edges that meet Cond" <= Dist
And I want a way to retrieve vertices / edges of Sub, with a reasonable complexity, ideally it should be linear in number of vertices + number of nodes of Sub.

The context here is that I need to compute all shortest paths between 2 nodes, and cannot use https://www.arangodb.com/docs/3.8/aql/graphs-k-paths.html because of the condition on edges of the edge collection.

Hello @goedderz ,
Thanks for your help!

First, do a weighted traversal (with {uniqueVertices: "global", order: "weighted"}) to extract only the vertices of your desired subgraph. Combine it with PRUNE to stop when the maximum distance is exceeded (you will have to post-filter those).

In the PRUNE condition, can I also check for Cond to eliminate paths that would use forbidden edges, or will this filtering be too aggressive and remove paths that would be valid?
Here is an example to explain the problem:

The source vertex is S
There are 2 edges from S to A, one of the edges is forbidden

If the traversal first discovers the forbidden edge, given that we have uniqueVertices: "global", will the second edge be considered or discarded because it goes to a vertex that has already been "pruned"?
Thanks!

In the PRUNE condition, can I also check for Cond to eliminate paths that would use forbidden edges, or will this filtering be too aggressive and remove paths that would be valid?

Don't do that in PRUNE; instead, add a FILTER path.edges[*].color ALL == "red" (assuming you want edges with edge.color == "RED").
In PRUNE, check for something like PRUNE path.edges[*].length > @Dist", assuming lengthprovides the cost of an edge.lengthmust be the same attribute as supplied viaweightAttribute` to the weighted traversal.
PRUNE works as follows: If the condition is true for some vertex v, it will still be returned by the traversal, but the traversal will stop there, i.e. no incident edges from v will be traversed. In combination with uniqueVertices: "global" that still means that the vertex was visited, and it will not be visited again from any other edge during this traversal. So as you suspected, if you'd check the edge condition during prune, this would lead to erroneous results.

@goedderz
Yes that is a bit unfortunate. I was hoping to find a solution which "scales well" in case the graph is densely connected and the condition on edges is highly effective at reducing the number of traversed edges/nodes. I guess that the feature you have logged for the future (https://github.com/arangodb/arangodb/issues/15537#issuecomment-1055194008) may address that concern.
Thanks for the help!

@goedderz I didn't know that the optimizer would do this, so it sounds like this should be exactly what we need. I will forward the information to the team responsible of writing these AQL queries. Thanks again.

Happy to help!


Could we make it a package?

First thanks for this awesome work and making it open source! I have been using the tokenizer (inference) for my experiments. It would be really great if this repo was a package so we could load the model easily after a pip install without having to checkout the code.

Thanks for your PR and interest on our work. I will take some time to process it in order to avoid potential conflicts.

I made some other changes (only structure, no code changes) and uploaded a version of the package to pypi so it is easy to test.
github: https://github.com/vinyesm/Open-MAGVIT2
pypi: https://pypi.org/project/open-magvit2/

Hi, Recently I have been busy with some stuff. Sorry for reply late. I have checked the pull request. Since we will make some updates in the future, I think you can make it an extended branch as for the package.  We will update our ReadME later. Again, thanks for your PR.


grafana official helm chart as dependency

Since the release of 0.17-beta12, I think this PR is ready to be merged.
I'd like to create a dedicated chart version (version: 0.17.0-gf-dep) so that users still have a choice to use devlake-0.17.0-beta12 for non-official Grafana helm chart.

@klesh I think this can be merged now because all the prerequisites are met. This will release a new chart version 0.17.0-gf-dep; other users can still use 0.17.0-beta12.


soc: intel_adsp: cavs: /soc/timer missing or empty reg/ranges property

Is your enhancement proposal related to a problem? Please describe.
Compiling the intel_adsp_cavs* boards might generated the following warnings:
/home/ycsin/zephyrproject/build/zephyr/zephyr.dts:116.16-119.5: Warning (simple_bus_reg): /soc/timer: missing or empty reg/ranges property

https://github.com/zephyrproject-rtos/zephyr/blob/d5a1a8bf04c9a4a1f7b9c73f2426368e93844143/dts/xtensa/intel/intel_adsp_cavs25.dtsi#L141-L144
Describe the solution you'd like
Compiling those boards shouldn't produce any warnings in the terminal.
Describe alternatives you've considered
Ignore the issue.

Thanks for filing this! You can see DT warnings every day at https://github.com/thesofproject/sof/actions/workflows/daily-tests.yml
Recent example: https://github.com/thesofproject/sof/actions/runs/6764790187/job/18383560016
@nashif , @tejlmand , @mbolivar-ampere, @galak,... is there a build option to make Device Tree warnings fatal in SOF CI? We already use --cmake-args= for the compiler, could it be used for Device Tree too? https://github.com/thesofproject/sof/commit/f97183a8c496
Github Actions doesn't have anything to surface warnings; it does not have the concept.


Top-level docs entry-point --- coming from jaeger, zipkin, opentracing, opencencus

We can probably break this into separate issues over time, but something that seems to come up often is people already have some older instrumentation from jaeger, zipkin, opentracing, or opencensus. How should they adopt opentelemetry?
I would propose that we have a new top-level entry point, or 2nd-level one: something to the effect of, "I already have instrumentation in $TECHNOLOGY", where $TECHNOLOGY is one of the ones listed.
There's really two paths for them: interoperate or replace.
To interoperate, your path will most likely involve the collector.  You instrument new services with opentelemetry and then set up a receiver for your existing services in the collector.
To replace, I would propose it's similar. Set up a receiver and then rewrite their instrumentation piecemeal, one service at a time.
The other thing to consider is version compatibility. Very old versions of Jaeger instrumentation would need to be upgraded to a minimum version to work with a receiver. Are there other versions involved?

Yeah, we'd need to have one for jaeger at least, but ideally all of them.
I think that doc needs work as well since it doesn't involve the collector. But it's a good place to start.

Maybe https://opentelemetry.io/docs/migration/ could have some of that generic info you mentioned:

There's really two paths for them: interoperate or replace.
To interoperate, your path will most likely involve the collector. You instrument new services with opentelemetry and then set up a receiver for your existing services in the collector.
To replace, I would propose it's similar. Set up a receiver and then rewrite their instrumentation piecemeal, one service at a time.

I think I'm gonna close this one out. We probably don't need it now that so many people are coming from OTel and there's enough bridges.


Push notifications for Android and iOS

It's awesome that gitify is now available on iOS and Android as well!
It would be great if gitify-mobile would support push notifications like the desktop app.

Has any progress been made on this?

I bought the app thinking that this feature was already included actually.
Is it possible to at least add the notifications counter (the red badge) on the app icon?

I agree with @FezVrasta, to me it feels a bit misleading. I can view notifications on Github.com, don't need an app for that. For a mobile app that is only meant for handling notifications I expected push notification support.
I'm not angry, just disappointed. I'm happy to pay for a subscription if that is required to help cover the cost.

I also agree with @FezVrasta it's misleading that the app doesn't already support this.
Disappointing there hasn't been a comment regarding this issue from the developer yet.


Twitter API v2

https://developer.twitter.com/en/docs/twitter-api/early-access

Twitter API v2 is out now. Would love to see this project get some more attention

Me too. Good Plugin, would be great if it could support Twitter API v2


Presentation of multilingual fields

For the Peaceportal corpora, I had to tackle #1106 . These corpora may have transcriptions in different languages (e.g., English or German). Right now, the transcriptions are indexed as transcription_german, next to a main transcription field. Then, all language specific fields are hidden for the frontend -- they will be searched, but the user only ever gets to see the (unanalyzed) transcription field. This means that highlighting won't work for stemmed / complex queries.
An alternative idea I had was to make the common "transcription" (or "speech") field indexed=False, but make this the only field that is shown to the user, and devise a mechanism by which the "parent" field displays contents from the language specific fields here instead. On Elasticsearch level, this would be quite easy to tackle with searching in a transcription* field, but I cannot oversee the complexity of required frontend changes to make this work.

Small point: I would strongly recommend using ISO codes in fieldnames, e.g. de rather than german.
A method I've seen is to use nested fields, e.g. a german source document would look like this:
{
	"transcription": {
		"de": "Some text in german",
		"en": null,
	}
}

And an English one like this:
{
	"transcription": {
		"de": null,
		"en": "Some text in English",
	}
}

This makes it trivial to set language-specific analysers for each subfield. If needed, you could still make a scripted or unindexed with the unanalysed text, but you may not need it.

Oh yes, you brought this up before. I did look into nested fields, but it seems you need to query them with a specific nested query: ES documentation, and they are generally not encouraged by Elasticsearch. Do you perhaps mean flattened fields? I just followed through on a link and thought that this looks perhaps more like what you had in mind.

Oh, I wasn't aware of the performance issue, thanks for looking into it!

A possible issue with searching for transcription* is that it is plausible you'll have unrelated fields with the pattern transcription_something. (E.g. speech_type in the parliament corpora follows this pattern.)
So you would either need to:

add validation to forbid this and re-index any existing corpora that use names like this.
explicitly declare language variants in the corpus definition and search for them without a wildcard.

Oh by the way, if you're creating an index for this, could you add a field with the ISO code? C.f. https://github.com/UUDigitalHumanitieslab/I-analyzer/issues/795 You can hide the field, it's more for compatibility with future language-related features.


[Data Collection] Fix mapping for task type in local db

Towards #1545

Verified by creating a new job with name "All tasks" and validating that a fragment is created for each task.

@JSunde  PTAL?

/gcbrun


Allow individual options to have bold style

cc @tgolen since it looks like this was missed in your cleanup PR (that I helped review 🙃 )
Details
Regression from https://github.com/Expensify/App/pull/13319/
Fixed Issues
$ https://github.com/Expensify/App/issues/14154
Tests

Navigate to Settings -> Profile -> Pronouns
Verify your current selected pronoun is in bold

Navigate to Settings -> Profile -> Timezone
Make sure you're not automatically updating timezone, then click "Timezone"
Verify your current selected timezone is in bold

Update each and make sure the newly selected items are now bold and the previously selected items are no longer bold

[ ] Verify that no errors appear in the JS console

Offline tests
Same steps above
QA Steps
Same as all above steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Reviewing.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @techievivek in version: 1.2.53-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.2.53-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[YUNIKORN-887] Automate generation of k8shim FSM state transition diagrams.

What is this PR for?
Automate generation of .dot/.png files for the core scheduler application state.
New Makefile target fsm_graph will generate FSM graphs for the application, task, node, and scheduler states, and output to _output/fsm both the original .dot files as well as .png images. These may be directly used for website documentation.
What type of PR is it?

[ ] - Bug Fix
[x] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-887
How should this be tested?
Test succeeds.
Screenshots (if appropriate)

Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

@kingamarton can you review?


Floating Action Button positioning

Two ideas for FAB's:

Basically the buttons that provide a menu of other action buttons, either when hovering on the button or clicking the button initially. The MD page says those are called speed dials which are already on list of components to make.

The Floating Action Buttons already provide an Absolute positioning class, where they have style="position:absolute;" and I think a Fixed positioning class would help as well. Absolute ends up staying in the same spot on the page even when I have it in my base #app div and the page scrolls down. Fixed positioning stays the same spot on the screen as I scroll.

Numer 2 seems simple enough, I'd be willing to add it in a PR, I believe it's only adding those classes to this file

It's pretty easy to make your own speed dial:
http://codepen.io/korylprince/pen/EZxpxx
That's not a perfect implementation of the spec, but it wouldn't take too much mucking around with the CSS to get there.
It would be cool to have an md-speed-dial that encapsulated md-buttons and took care of transitions and such though.

Nice yea thats a good mock up. Where did you get those transition components?
Another cool component would be a general Collapsible div that can be triggered with events. We already have something like this with the md-list-expand but I havent tried that without another md-list inside. Also, from what I see, the expand component needs to be nested inside an existing md-list > md-list-item component, so the first list item will always show and act as the toggle button.
This could be used to abstract the md-list-expand, and allow both the accordian and static expand options, the latter being when you click to expand one section, and then click to expand a second section, they both stay expanded. This Collapsible component could also be used with a one time click to cancel, to show some type of banner or announcement only once that the user would then click and cancel and the banner wouldn't appear again.

The transition component is built into Vue itself, and the css I'm using is almost directly copied from the docs:
https://vuejs.org/v2/guide/transitions.html
As far as the rest, I think @marcosmoura is focusing on building components in the Material Design spec. I'm not seeing anything there that meets what you're describing. However I think just like the fab button example, it shouldn't be too hard to make yourself with a transition component and some css.

@korylprince , thanks for the reply, I never noticed the transition component in the standard vue.js library.
As for the collapsible component, from the material.io site, they list Expansion Panels as a separate component.
It looks like they behave the same as the md-list-expand component, and they're listed again in the List Controls section as an collapsible list component, so I guess maybe for md-vue we could make it an expandable panel that you can optionally put nested lists in.
Where it's currently documented in md-vue under the List component makes it seem like the expandable component is being relegated to be a sub component of lists when it doesnt necessarily need a list context. Or am I off base? I haven't tried it without a list inside the expand component, so maybe it's just a matter of giving the expandable component it's own section and showing a demo with just some content and then another demo with content that uses the md-list component inside the expanded component.

@capttrousers No, it looks like you're right. When I skimmed over Expansion Panels I thought they just covered lists, but they look to be pretty generic.
It looks like @marcosmoura already has both speed dial and expansion panels on his list to do:
https://github.com/marcosmoura/vue-material/projects/6

Hi Guys. Sorry for the delay to answer. The Speed Dial will be the next component to be delivered. Also @korylprince, GREAT job on that codepen!!!

@marcosmoura thanks! I modeled it after the speed dial in the google inbox app.

no worries @marcosmoura hope you had a good holidays. what do you think about adding a fixed class to the Floating Action Button so they can be fixed on a scrollable page, like the Compose button in the gmail app or the directions button the the gmaps app? is it as simple as i think? if so i'd love to contribute

I'm thinking in a special class for the fab, like md-fixed.


Default branch linter  and MRI versions out of synch with Blacklight 7.x

A 7.0.x release should have in gemspec:
  s.add_development_dependency 'rubocop', '~> 0.60.0'
  s.add_development_dependency "rubocop-rspec", '~> 1.8'

and in linter config:
AllCops:
  DisplayCopNames: true
  TargetRubyVersion: 2.3

following Blacklight 7.0.0

A thing to note is that Blacklight 7.0.0 is inconsistent in documented MRI expectations:

<EMAIL_ADDRESS>says 2.2+
<EMAIL_ADDRESS>says '~> 2.1'
<EMAIL_ADDRESS>says TargetRubyVersion: 2.3

I think the right thing for a plugin to do is to align its linter rules with the core blacklight gemspec, since that's what really matters. So I'm going to target 2.1 in this PR.

Well, that's rude:

The rubocop dropped support for MRI 2.1 targets after 0.58
version 0.60.0 won't run with MRI 2.6.x due to a YAML update; needs 0.64.0
0.64.0 rubocop will only target MRI 2.2+, so the Blacklight README wins for 7.0.0


Modified Dockerfile to shorten build time

Merged existing Dockerfile with the upstream
Made changes to use caching more effectively
Upgraded ruby version in Gemfile to 2.2.2
Removed non necessary statement

The one thing I might suggst adding is some "comment guards" to make it clear which bit of the docker file is the 'webapp-onbuild' Docker file.
Something like:
FROM ministryofjustice/ruby:2

###
### Start of copy from ruby:2-webapp-on-build
###
+# add official nodejs repo
+RUN curl -s https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add - && \
+        echo 'deb https://deb.nodesource.com/node jessie main' > /etc/apt/sources.list.d/nodesource.list
+

…
…

###
### End of copy from ruby:2-webapp-on-build
###

WORKDIR $APPHOME

…
…

And a comment about 'weve added libreoffice to this list - otherwise as per stock' so that we can unpick this change later if we can find a nicer solution.


Sitecore 10.2 Support and Compatibility

Pending in feature branch support-10-2

Confirmed with @SitecoreDave that this is completed

For consistency purposes, we should use 10.2.0 as opposed to 10.2. @SitecoreDave to fix the code, check in, make a new release and push the release.


conan doesn't build since it was updated to 1.6.0

Builds here: https://hydra.nixos.org/job/nixpkgs/staging/conan.x86_64-linux/all
It seems to be missing cmake and pythonPackages.pkgconfig.
cc @talyz

I might be hitting this. Is there a workaround?

I think there is simply noone who's willing to maintain conan. If nobody steps up, I suggest marking the package as broken.

I have fixed and updated the package in https://github.com/NixOS/nixpkgs/pull/53380.
However there is actually not much use for conan environments with nix so I am not sure about mantaining it.


Refactor staic files etc.

Ah sorry I meant to do this to mine and check that it all works, that's what I get for coding before coffee...


Ean/make notifier hosted aware

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
@mpolden

We need the extra indirection to separate fetching of contact data from creating the mail content.
CuratorDB lives in vespa-engine/vespa, while hosted information like the dashboard url lives in the close repository.
And to avoid exposing all of the Hosted System information in vespa the indirection here is needed.
It will also give us an extendable way to add other destinations in the future (Slack, IRC, ...) now that Notifier is no longer responsible for dispatching a notification to the destination.


Support verbosity=1 for log-enricher

What type of PR is this?
/kind feature
What this PR does / why we need it:
Added increased verbosity to log enricher.
Which issue(s) this PR fixes:

None
Does this PR have test?
None

Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

Support `verbosity=1` for log-enricher

/test pull-security-profiles-operator-test-e2e

Codecov Report

Merging #787 (3576cc4) into main (81644f3) will increase coverage by 0.02%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
+ Coverage   53.50%   53.52%   +0.02%
==========================================
  Files          42       42
  Lines        4170     4174       +4
==========================================
+ Hits         2231     2234       +3
- Misses       1872     1873       +1
  Partials       67       67

@pjbgf PTAL


config 1.0

[x] move current config to v0 module
[ ] create v1 config

[x] definitions
[x] inheritance (workspace -> package)
[x] inheritance (installer -> installer.shell)
[x] simple defaults
[ ] make_relative_to
[ ] complex defaults ("enable build cache if config x or y are enabled")
[ ] complex validation ("you flipped on x and y this makes no sense")
[x] toml deserialization (impl'd but untested)
[ ] toml serialization (the code init does with toml-edit)

[ ] use v1 config internally

[x] create v0_to_v1 translation layer
[x] apply translation layer to current v0 config to also construct v1 in parallel
[ ] change workspace config users to use v1
[ ] change package config users to use v1

[ ] expose v1 config to end-users (probably not in this PR)

[ ] read either v0 or v1 in, branching on which it is
[ ] create v1 with init
[ ] auto-translate v0 to v1 in init

Right now the biggest issue I'm running into is how "random" it is that something is a global setting or not, and the fact that a global setting vs a package-local setting requires a bunch of duplicated definitions/logic. I tried to do a cheeky split of "only ci config is global" but a lot of not-actually-ci-config is defacto-ci-config like github releases or build dependencies.
I'm going to try to do the package-local settings first to see if they're easier to migrate.

complex defaults ("enable build cache if config x or y are enabled")

This design is based entirely on the config overhaul i did in oranda last year, and it also had a last-step freeform system for Complex Defaults:
https://github.com/axodotdev/oranda/blob/0044504916cfbeaf5a830d8703828a81375b3362/src/config/mod.rs#L260-L271
My main annoyance here is that "defaults last" means some things have to be Options in the final config (or we add a 4th fucking copy of every struct ;-;). In practice a few extra options you have to unwrap is..... Probably Fine.

This doc-comment in oranda is quite informative about the basic idea of the design: https://github.com/axodotdev/oranda/blob/0044504916cfbeaf5a830d8703828a81375b3362/src/config/mod.rs#L1
What this design adds is an extra "Inheritable" thing between Config and Layer to represent the delayed application of inherited values like installers.install_path onto installers.shell.install_path.
This results in there being 4 possible values any given setting can come from, which need to apply in this exact preference order

workspace.publish.prerelease
workspace.publish.cargo.prerelease
package.publish.prerelease
package.publish.cargo.prerelease

you need the accursed middle struct to handle cases like

workspace.publish.prelease = true
package.publish.cargo = true

(cargo is enabled within a package, but doesn't specify its prerelease preferences, so the prerelease setting needs to be inherited from the workspace all-publishes setting. The workspace.publish.prerelease setting therefore can't be eagerly merged into workspace.publish.cargo.prerelease, because workspace.publish.cargo = None.)


⚠ Bofrost.at has degraded performance

In 25a19c4, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 3195 ms

Resolved: Bofrost.at performance has improved in 371fc3b.


The page https://stable.getautoclicker.com/ opened on its own

Describe the bug
I was just watching a Twitch stream when the page opened showing my password. What if I myself was streaming? What was that? An update?
To Reproduce
Steps to reproduce the behavior:

Do nothing.

Expected behavior
None.
Desktop:

OS: Windows 7
Browser: Chrome
Version: 89.0.4389.90

Hi @Melanol ,
We release all new great features to the stable version today. the previous version was 2.2.0 and the latest new version is 3.2.0
Please check out https://discordapp.com/channels/702091948902711388/804933573395087361/827067072039092234

I would keep this ticket open for some time if users have same issue


Add foxglove monitoring config

Summary
Adds a foxglove config for udp bridge monitoring
TODO: launch file

You need to update the config with latest changes


Support bwa-meth alignment samples

Hi, @hanyangii @lutsik, great work!
I have some bam files generated by bwa-meth and I wonder if methylbert has future update plan to support bwa-meth alignment.
To my knowledge, bwa-meth has higher mapping rate and similar accuracy compared to bismark under certain filtering conditions like MAPQ > 10. However, bwa-meth output bam file without XM tag.
I'm writing script to add XM tag to meet methylbert's need but still looking forward to hearing from you.
Best,
Fan

Hello, thanks a lot for your interest!
Although I don't have first-hand experience with bwa-meth aligned BAM files, I am willing to update MethylBERT to support bwa-meth alignment in future. I just cannot guarantee when the update will be made.
Meanwhile, if you want to generate the XM tag yourself, you can find the information here (p.9 - 12):
https://www.bioinformatics.babraham.ac.uk/projects/bismark/Bismark_User_Guide.pdf
Or, if possible, I would rather recommend to generate a processed data file yourself including
"methyl_seq" column containing 0, 1, and 2 meaning unmethylated CpG, methylated CpG, and non-CpG. Please find the data format 03_Preprocessing_bulk_data.ipynb in the tutorial.
You don't need to make all of the columns. Only ["dna_seq", "methyl_seq", "ctype", "dmr_ctype", "dmr_label"] are needed in the file as shown in dataset.py.
Hope my comment is helpful for you!

Thanks a lot! It's very helpful.

Hello @vanreality
I just looked at the bwa-meth aligner github page but could not find information about how read-level methylation patterns are stored in bwa-meth-aligned bam files.
Could you please share it with me if you have any references/tutorials explaining read-level methylation patterns in bwa-meth?
Kind regards,
Yunhee

I evaluated the callMethylation function in the epialleleR package, version 1.11.9, using a WGBS sample. By comparing the XM tag similarity of identical reads (the same read name and position) between bwameth and Bismark, I found that 98.61% of the reads in the bwameth BAM files matched perfectly with those in the Bismark BAM files.
Given these results, I plan to use this R package to extract read-level methylation information from BAM files aligned with bwameth.

Glad to hear this! I will then have a look at the epialleleR package :)
Thanks a lot!


Error while installing on rPI2

Hello,
I get this error when I try to install node-gyp on my rPI2. Hope anyone could help me.
sudo npm install -g node-gyp
abort: m??$0??0????%:????:??$
==== Stack trace ============================================
Security context: 0x4f334659 #0#
1: _parse(aka parse) [/usr/local/lib/node_modules/npm/node_modules/tar/lib/extended-header.js:~61] (this=0x39984c45 #1#,c=0x3998a4f5 #2#)
2: emit [events.js:95] (this=0x39984c45 #1#,type=0x56f14839 <String[4]: data>)
3: arguments adaptor frame: 2->1
4: _read [/usr/local/lib/node_modules/npm/node_modules/tar/lib/entry.js:111] (this=0x39984c45 #1#)
8: _read [native v8natives.js:1594] (this=0x39984c45 #1#)
9: write [/usr/local/lib/node_modules/npm/node_modules/tar/lib/entry.js:68] (this=0x39984c45 #1#,c=0x3998a4f5 #2#)
10: _process [/usr/local/lib/node_modules/npm/node_modules/tar/lib/parse.js:105] (this=0x39914d6d #3#,c=0x3998a47d #4#)
11: /* anonymous / [/usr/local/lib/node_modules/npm/node_modules/tar/lib/parse.js:47] (this=0x39914de5 #5#,c=0x3998a47d #4#)
12: emit [events.js:95] (this=0x39914de5 #5#,type=0x56f14839 <String[4]: data>)
13: arguments adaptor frame: 2->1
14: _emitChunk [/usr/local/lib/node_modules/npm/node_modules/block-stream/block-stream.js:145] (this=0x39914de5 #5#,flush=0x4f308091 )
15: arguments adaptor frame: 0->1
16: resume [/usr/local/lib/node_modules/npm/node_modules/block-stream/block-stream.js:~55] (this=0x39914de5 #5#)
17: arguments adaptor frame: 1->0
18: resume [/usr/local/lib/node_modules/npm/node_modules/fstream/lib/reader.js:~251] (this=0x39914d6d #3#,who=0x4f308091 )
19: arguments adaptor frame: 0->1
20: / anonymous / [/usr/local/lib/node_modules/npm/node_modules/tar/lib/extract.js:57] (this=0x39914f6d #6#)
21: emit [events.js:92] (this=0x39914f6d #6#,type=0x35efd1a9 <String[5]: ready>)
22: / anonymous / [/usr/local/lib/node_modules/npm/node_modules/fstream/lib/dir-writer.js:39] (this=0x4f334701 #7#,er=0x4f308081 )
23: arguments adaptor frame: 2->1
24: / anonymous */ [/usr/local/lib/node_modules/npm/node_modules/mkdirp/index.js:29] (this=0x4f334701 #7#,er=0x4f308081 )
26: oncomplete [fs.js:108] (this=0x3995a521 #8#)
27: arguments adaptor frame: 1->0
==== Details ================================================
[1]: _parse(aka parse) [/usr/local/lib/node_modules/npm/node_modules/tar/lib/extended-header.js:~61] (this=0x39984c45 #1#,c=0x3998a4f5 #2#) {
// stack-allocated locals
var i = 260
var l = 410
var b = 67
var val = 0x3998b399 <String[4]: File>
// expression stack (top to bottom)
[05] : 0
[04] : 2086534
--------- s o u r c e   c o d e ---------
function parse(c) {?  if ........
......
.....

@a-i-ks What's the version of nodejs and npm are you using?

I had installed the latest version of nodejs accidentally. Then tried to uninstall nodejs again, by deleting all files of nodejs manually. After that I installed node_0.10.36_armhf.deb.
pi@raspberrypi ~ $ node -v
v0.10.36
pi@raspberrypi ~ $ npm -v
1.4.28

@a-i-ks you shouldn't need to install the extra node-gyp manually. npm bundled its own copy of node-gyp. Can you try skip that step and just do npm rebuild and see if that works?

@a-i-ks I found that the pre-built version of node that you installed didn't work for me. Try compiling yourself: http://www.armhf.com/node-js-for-the-beaglebone-black/ but replacing with the 0.10.36 version of Node. That seemed to work fine for me.

@KhaosT  I tried to skip the node-gyp installation step and just do npm rebuild. Unfortunately I ran into this error, when I execute "sudo npm rebuild".
pi@raspberrypi ~/HAP-NodeJS $ npm rebuild

<EMAIL_ADDRESS>install /home/pi/HAP-NodeJS/node_modules/curve25519
node-gyp rebuild

gyp ERR! clean error
gyp ERR! stack Error: EACCES, unlink 'build'
gyp ERR! System Linux 3.18.10v7-aufs
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/pi/HAP-NodeJS/node_modules/curve25519
gyp ERR! node -v v0.10.36
gyp ERR! node-gyp -v v1.0.1
gyp ERR! not ok
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
....http://pastebin.com/sK1J2pxn
@bjtitus Thanks for your suggestion. I compiled the source code of Node 0.10.36 and installed it as described in the instruction. But after I execute the command 'sudo npm rebuild' in the HAP-NodeJS folder I get the same error message (see above).
Thank you for your help.

@a-i-ks "stack Error: EACCES", are you sure you have write access to that folder?

@KhaosT
when I execute "ls -l" I get the following output for the HAP-NodeJS folder
drwxr-xr-x  5 root root     4096 Apr  6 19:52 HAP-NodeJS
Shouldn't I have write permission in any case, when I execute the command 'sudo npm rebuild' (because of sudo)? KhaosT I can give you SSH remote access to my PI, if it would help to figure out, what's wrong.? It would be so good to have an HomeKit Accessory Server running.

@a-i-ks you didn't use sudo ... "pi@raspberrypi ~/HAP-NodeJS $ npm rebuild"

Ah true. However, I just tried it with sudo. Same issue :(

@a-i-ks If you are comfortable to email me a temp account, I'll see what I can do.


Navbar breakpoints to hide tab

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] PR closes #2760
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[x] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[x] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

/giphy wheel fortune

You should check these responsive helpers

Thanks, it's helpful. However, in this case these ranges are not precise enough, we need to accurately control the display of each tab.

Okey, now this searchBar is responsive. 👀

I mean previous hiding technique was a great approach.
Maybe just hide out chain selector and language, so the search bar won't look bad if someone use it, for example, someone is using a split-screen on 13"
1110px width

I mean previous hiding technique was a great approach. Maybe just hide out chain selector and language, so the search bar won't look bad if someone use it, for example, someone is using a split-screen on 13"
1110px width

Oh I misread what you meant. Let me revert to the original state

I mean previous hiding technique was a great approach. Maybe just hide out chain selector and language, so the search bar won't look bad if someone use it, for example, someone is using a split-screen on 13"
1110px width

Oh I misread what you meant. Let me revert to the original state

yes, a flexible search bar with hiding would be great I guess! :)
yes, in the previous state was an issue that search bar was fixed :)

yes, a flexible search bar with hiding would be great I guess! :)
yes, in the previous state was an issue that search bar was fixed :)

How about now? 👀   shorten the width of search-bar first, and then hide out language and chain selector

I mean way better, I guess we will rework the whole navbar later :)

pay 100 usd

😍 Perfect, I’ve sent the payout
💵 $100 @ 191.64 USD/KSM ~ 0.522 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xfd0992102b23d4b9b9b3c73967cc03fc133b499c62dc94a61f3ee0cb9418e205
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

We should rework and refactor the navbar code in a much more sensible way and what's should be merged and exclude on different widths.
Hidding least popular buttons from first, hence we don't have any UX research I can only bet.

language
chain/protocol selector
create
history
stats
profile

With search bar should be flexible and fill up the rest space next to the buttons.


Consider destructured array elements as undefined

Flow (0.38.0) finds 0 errors in the following code:
// @flow
const [a, b] = ''.split(',');
console.log({a, b}); // prints: { a: '', b: undefined }
b.trim(); // TypeError: Cannot read property 'trim' of undefined

I would expect that Flow infers b (and maybe a) as undefined. Is this the expected behavior?

You are generally permitted to index into an array without checking for undefined:
const a: Array<number> = [];
a[0].toFixed();
// no Flow error
// runtime error: TypeError: Cannot read property 'toFixed' of undefined

It is fairly common for array/vector/list structures in statically typed languages to have a subscript operation that returns the n th element without requiring you to explicitly handle the case of n being out of bounds (eg by throwing an exception in that case). Flow considers Array subscript to be the same.

Thank you.


Investigate increased number of java processes running for a long time

I've spotted ~100 java processes, ~20 of them running over 100h.
All together with the usual staff, they were using almost 100% of memory.
Sadly I closed them all before verifying the specifics - "hopefully" they reappear and I will be able to provide them.
Questions that came to my mind:

Is it related to the usual development or to local runs of UI test suite (on which I was focused recently)?
Is it only me, macOS or Fedora too?
Is it because of gradle or intellij?

Now (as memory usage dropped to ~20% on my machine) I see a significant improvement in UI test execution performance.

We decided to drop this issue.
It is most likely related to ui test shutdown problems.


Improve inner-loop performance for .NET developers

Summary
Inner-loop performance is critical to providing the developer experiences that are increasingly expected/demanded by developers. How fast developers can make code changes and see the resulting impact in their apps is directly proportional to how productive they can be.
When using other platforms, many of the common inner-loop operations are faster, sometimes dramatically so, than the equivalent when using .NET. First-time user impressions may be negatively impacted by such differences, to the point that it deters their choice of .NET as a developer platform.
Epics
Epics under this Theme:

[x] Improve performance of CLI/SDK/MSBuild that relate to the developer inner-loop.
[ ] Improve and modernize the launch/debug/update loop
[x] Hot Reload application changes during development inner-loop from the .NET CLI
[x] Hot Reload for Blazor Components
[x] Hot Reload for ASP.NET Core
[x] Reimplement the Razor compiler using source generators & introduce incrementality
[ ] Blazor WebAssembly Hot Restart
[x] Support Code Hot Reload (EnC) for Razor
[ ] ASP.NET Core Hot Restart
[ ] Xamarin developers have an improved development experience on .NET 6
[x] Ensure the BCL supports Hot Reload
[x] Reduce EF Core application startup time via compiled models

This is really very critical. From day to day i have pain with slow builds compared to Go compilation.

I notice this quite a bit when doing TDD, add one line of code, wait 30 seconds for it to compile and validate my test.  I guess this would apply to the first two epics.

Updated the link for the Hot reload for Blazor components link.

will it add support jit reload on monovm?

Consider replacing the wwwroot/lib artifacts in new projects with libman config

is this expected to break IL weavers like postsharp and fody?

has a fast loop been considered for test execution? as in patching into a process that can run test?

I think development in C# should give good developer experience as in this talk: https://youtu.be/Yu9zcJJ4Uz0?t=416
In the end users will use languages which provide best development experience and other one will die.
And I think quick updating your code is critical in development like hot reloading of js in React / Angular...
I think in compilation should look like in https://www.snowpack.dev/ for js :)

@przemo098 I think Vite.js is the new gold standard that all other tools will be compared with in the foreseeable feature.

On a related note:
When running dotnet watch in terminal I often

cannot see build errors/warning in VS error window
cannot run tests, because VS runs it's own build and obj/*.dll files are locked by the dotnet watch.

In other words, I either use dotnet watch and loose lot of VS tooling support, or I use run the app using VS (Debug or Run without debugging) and loose some of the live reload functionality.
Also, when debugger is attached and app is rebuilt, it could automatically reattach, resp. never detach. Just like when I set breakpoint in javascript file in Chrome's developer tools and refresh a page.

When can developers expect hot reload of Blazor (WASM) to be available? This is such a huge productivity enhancement that is crucial in successful adoption of Blazor.

super
Reduce EF Core application startup time via compiled models

Inner loop. smh. The terminology gets more embarrassing each... outer loop.

Great Efforts.

THIS IS GREAT. THANK YOU!!!

Closing this out as it pertains to work done in .NET 6.0


problem with UrlManager rules behavior

Hi,
I have this rule in my url manager configurations:
        'urlManager' => [
            'enablePrettyUrl' => true,
            'rules' => [
                '<language:\w{2}>/news'=>'news/front/index',
            ]
        ],

it works fine for a URL like mysite/index.php/en/news. but the problem occurs when the URL is mysite/index.php/en/news/, that last / seems to broke the link and a 404 exception is thrown.
I added the following rule to rules array but it didn't solve it:
     '<language:\w{2}>/news/'=>'news/front/index',

I've used similar rules in Yii 1.1 and it's working just fine, and it's the first time I'm working with rules in Yii 2.0 and this is happening, am I missing something?

Duplicate of https://github.com/yiisoft/yii2/issues/7670

Thanks couldn't find it :+1:


[Feature request] Integrate rowspan in vuepress

Feature request
It would be possible to add the rowspan to the default theme, see example for clarification
Description

As the markdown-it-multimd-table doesn't work on vuepress 2 (if you know how to enable it, i would very happy too! 😊
Proposed Solution
I'm not so expert, so i ask to you if there is a method...

And in vuepress 2? I tried with rowspan but it doesn't work...

This is for vuepress2. Remember extendMarkdown is renamed to extendsMarkdown

okok no problem ✌


Prefix has been set but does not show (NukkitX)

I just cleared and reapplied the prefix but the prefix doesn't show in chat.

LuckPerms doesn't format the chat for you - you need to install a chat formatting plugin.
I'm not aware of one that exists for Nukkit. Is there a standard API to provide prefix/suffix data, like Vault for the Bukkit project?
p.s. I try to keep the issues on GitHub free of questions - and tend to close such tickets as soon as an answer has been given. We have a Discord server which you might find to be a better place to ask questions.

thank you for replying after my two other non-relevant issues, and i will be on a lookout for a plugin like that.


[Improvement of Documents] List of Installation patterns and options.

Issue/Feature Description:
SODA installer has a lot of useful installation options such as automatic download functions of storage backend modules and pre-set their configs.
It enables us to set up various patterns of storage architecture easily (Thank you!).
However, there is NOT a list of these great options, so it's difficult to use well for SODA beginners.
I think that it's better to add a list of patterns of architecture which we can set up by using the installer and which options we should turn on.
Why this issue to fixed / feature is needed(give scenarios or use cases):
The people who would like to use SODA will be able to understand SODA usecases easily. It will acceralate the SODA community.
How to reproduce, in case of a bug:
None
Other Notes /  Environment Information: (Please give the env information, log link or any useful information for this issue)
None

Thanks for the issue - very good comments.
I will make sure I review the documents over the next few days and try to improve.
We are also working on a redesign of SODA Installer: https://github.com/sodafoundation/architecture-analysis/pull/89


Tooling: Bundler - Use from non Tauri apps

It says in the tooling/bundler/readme.md file
Tauri automatically loads configurations from the tauri.conf.json > tauri > bundle object, but this library doesn't rely on it and can be used by non-Tauri apps.
Implying that the Tauri bundler can be used to bundle a non Tauri app.
How would this be accomplished, considering that the bundler

Download the webview
And errors out because it doesn't look like a Tauri app (missing web assets/dist and so on)

If it's indeed possible to bundle a non-Tauri app with the Tauri-bundler, how would this be done?

You're right, it currently does not work outside of Tauri's (or very similar) use-cases. The readme note comes from the fact that it used to work and because it was a fork of cargo-bundler, a general purpose bundler.
And i think we briefly mentioned once that we would like to have at least parts of it available for a wider audience (aka non-tauri users) again at some point :) -> No promises of course! (interpret this comment as my own opinion, not a tauri team statement)

Hi
Thanks for the response
Maybe it would be nice of the tauri team, to push some of the changes upstream to burtonageo/cargo-bundle (see burtonageo/cargo-bundle#116 ). Or alternatively, make a roadmap for how to make the tauri bundler work with non-tauri-app.
A roadmap as in what changes would be required in the tauri-bundler codebase to make it able to be used on non-tauri-app

The issue you linked is a bit unfortunate timing since we're basically moving tauri's msi target to be a second class citizen too, and will promote the new nsis target as the default one (because using WiX doesn't spark joy)
A roadmap would probably would probably entail something like "rewrite the whole bundler" 😂 Seriously there needs to happen a lot to a) make it more modular and b) make tauri specific stuff optional. Especially for targets like the appimage where the bundle format itself is really brittle by itself already.
So yeah, this will be a long running process, so upstreaming parts of it may be easier but then the issue would be that nobody has time to do that anytime soon which may make the "long running process" faster in the end.

That was really weirdly phrased, sorry. i hope you get what i mean. There are just so many weird things we had to change for webview specific reasons (and the updater too i guess).

I'll do some more thinking and add a more concrete list of things i'd like to see happening here (in a way that would be possible for us to handle in a sane manner). Like for example the appimage bundler is one thing i don't see upstreamed any time soon from our side.

It makes sense. Or in any case, it would be nice with more people weighing in on the upstream issue. Cause I totally agree that WiX kills my joy from the inside.
I like the NSIS target myself, but again would be nice with more voices telling that WiX is dang impossible.
On that note (and without looking into it much), it sounds like the app package format for MacOS (dmg) should be easy enough to bundle regardless of the included app file(s). I mean, isn't it basically just a reskinned zip file with a custom background image.
But yeah, on the topic of Windows, it would be nice with more voices upstream.

idk if we just messed something up with our dmg bundler but in terms of problems it's the second place after appimages tbh. dmg is a disk image format so ig more similar to iso than zip.
We currently depend on a fork of https://github.com/create-dmg/create-dmg which tbh is not going too great for us, it is a bit brittle and many people have problems with it, so i hope that we can investigate a more rust native solution like https://github.com/indygreg/apple-platform-rs in the future - which imo would also be more suitable for upstream, if it works.

I'd say that https://github.com/crabnebula-dev/cargo-packager which is based on tauri's bundler "fixes" this issue. The aforementioned cargo-bundle is of course also an alternative.
At this point i highly doubt we'll make tauri bundler itself more generic and instead make it (or rather, the tauri cli) use one of the other 2 projects, or mostly unmodified fork of them.


Content Dialog not available

I tried it like this (from the flyout example)
<button id="contentDialogAnchor">Show a content dialog!</button>
<win-content-dialog anchor="'#contentDialogAnchor'">This is the content dialog content!!</win-content-dialog>

Maybe you could also add an example to the README.md also explaining how to use title, primaryCommandText and secondaryCommandText.
Thanks!

@TheWrathOfConst let's add ContentDialog to the README.

I've improved the documentation in the readme. It now shows use of several properties and also demonstrates how to make a ContentDialog appear


[db-up] Test db up

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/williexu/azure-cli-extensions.git@test_db_up#subdirectory=src/$EXT&egg=$EXT"


Clarify alert message error

Issue #, if available:
#574
Description of changes:
This change to the documentation adds clarity to the alerts displayed when an error occurs.
Only affects the Amazon Cognito Identity SDK for JavaScript.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #575 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #575   +/-   ##
=======================================
  Coverage   88.54%   88.54%
=======================================
  Files          62       62
  Lines        3072     3072
  Branches      593      593
=======================================
  Hits         2720     2720
  Misses        337      337
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0124c02...31045c2. Read the comment docs.

@mlabieniec @richardzcode I liked the stringify idea. Changed accordingly


Question about Extras in add_feature_layers_jsapi.md

The second (last) bullet in add_feature_layers_jsapi.md is a tad confusing.
Can we clarify in text what we want the developer to do on this step? Do they simply need to swap the addLayer() statements, or something more advanced such as using Map.reoderLayer()?

Fixed #156


Question:  How can I change the default draw.text  font (size)?

We are working in a Robotic Challenge with Open Roberta and we have serious problems with the text size.
It is too small!
For our challenge the students work in a low ilumination environment, and they must navigate through a menu in the little EV3 screen... :-( draw.text has a 'font' argument. And it is possible to use larger fonts. But the code is generated by Open Roberta (with Open Roberta connector) . And the argument is not used.
My question: Is it possible to change the default font for draw.text? Perhaps we can overwrite the default font (a dirty solution but enough for our purposes) ... How? Where?
Thanks!

draw.text() function comes from Pillow library. When no font is specified, it uses getfont() function, which calls ImageFont.get_default(), which has the font hardcoded. So there is no better way than to provide some non-default font. May be you should ask @ensonic to add the support for this.

@DJuego this would be better filed for https://github.com/OpenRoberta/robertalab
I'll compare the font-size on the ev3dev version with what they use on lejos.
One reason we're not adding a font-size there is that the x-y pos is made for the text size and not for pixels.

Thank you,  @ddemidov, @ensonic four your valuable and swift answers. 👍
As I need an immediate solution (this week is the Challenge)  I think i will try to modify the source of Pillow library with a new 'default' font...  Any advice? Any recommended font?
DJuego

There is a table with all fonts distributed with ev3dev-lang-python here: http://python-ev3dev.readthedocs.io/en/stable/other.html#bitmap-fonts.
I suggest you pick one you like and replace the font = self.getfont() line with ev3dev.fonts.load('font_you_like').

@DJuego try changing the font here:
https://github.com/OpenRoberta/robertalab-ev3dev/blob/develop/roberta/ev3.py#L36

DJuego, could we help you? Can we close this?

Hi. @ensonic. I'm sorry very much i did not answer earlier!  Due to our Robotic Challenge I've been traveling a lot of days.
However, I had not forgotten this.  I simply wanted to answer after having tested the solution you proposed. Sorry for my delay. I tried the @ddemidov suggestion inmediately but it does not work. I read your suggestion but i had not time for testing.
Meanwhile, my 'team' decided a different approach to the problem (no text in the screen) and my priorities changed suddenly. But i always wanted to try your workaround. For this reason, i did not close this issue. :-/
But now (today) i have tried your suggestion... and it is strange but i am unable to connect. :-? I am surprised. I receive messages like:
"You are trying to connect a robot of a different type as selected in the menu. Please switch the robot type in the robot's menu and try to connect again!"
However I choose Ev3->EV3dev,
I am using a Open Roberta Local Server (2.2.3 version, and now, 2.2.4 version). But i have tried it too with Open Roberta Online. I am using USB cable.
I have tried in three differents PCs with two differents EV3 bricks. After that i have updated fully the ev3dev (with openrobertalab connector update). The problem persist. I am unable to connect to OpenRoberta. (!!)
The last week i connected without problems multiple times. :-O It is true I worked with a different robot design but i have disconnect all ports and still stuck... Consequently I have not been able to test your suggestion. :-((( In any case this unexpected problem is much more worryng.
DJuego
P.S-1: I am working in Visual Studio 2010 x64..
P.S-2: I am suspecting of connmanctl. I have activated the wifi precisely in the EV3s i am testing now!
Could it be related?

I have opened an specific issue: https://github.com/OpenRoberta/robertalab-ev3dev/issues/42
DJuego

ok to close since an issue was opened with OpenRoberta?

Sure, please close.


Add Clickability for the Detailed Person View

so that I can click on Individual Components/fields of the detailed person view to edit them.

I believe this issue has been resolved in Ryan's PR. Please feel free to open another issue if you had other logical implementations of clickability. Thanks for raising this up!


ComposableImageTransform or allow for separate pipelines in 1 recordreader

Issue Description
To have my model trained with both transformed and original datasets, I need to have 2 recordreaders and datasetiterators. It would be nice to have the ability to train a model with both transforms and original datasets easier. Somehow. Adam Gibson stated something in the lines of "we could probably add a transform that treats the transform as just an additional "next" method to be called".
This would be a composable record reader for the transforms.
Please describe your issue, along with:

expected behavior
encountered behavior

Version Information
Please indicate relevant versions, including, if relevant:

Deeplearning4j version
platform information (OS, etc)
CUDA version, if used
NVIDIA driver version, if in use

Contributing
If you'd like to help us fix the issue by contributing some code, but would
like guidance or help in doing so, please mention it!

Closing  https://github.com/deeplearning4j/deeplearning4j/issues/3236 in favor this.

@antdood We about a method that changes the state of the record reader between transforming images and passing them as is?


Unexpected Assertion error when using lax.with_sharding_constraint

Description
Hi,
I was facing an error when trying to use data paralellism with equinox and opened an issue there: equinox issue #738. Turns out the issue is not related with equinox but with lax.with_sharding_constraint so I am opening an issue here.
Here is the MWE:
import jax
from jax.experimental import mesh_utils
import jax.sharding as jshard

num_devices = len(jax.devices())
print(f"Num GPUs: {num_devices}")
devices = mesh_utils.create_device_mesh((1,num_devices))
sharding = jshard.PositionalSharding(devices)
replicated = sharding.replicate()

x = jax.random.uniform(jax.random.PRNGKey(42), (256, 20, 1000))

x = jax.lax.with_sharding_constraint(x, sharding)

And here is the error being thrown:
Traceback (most recent call last):
  File "/home/ids/afreitas/test/mwe2.py", line 13, in <module>
    x = jax.lax.with_sharding_constraint(x, sharding)
  File "/home/ids/afreitas/jax/lib/python3.10/site-packages/jax/_src/pjit.py", line 2179, in with_sharding_constraint
    outs = [sharding_constraint_p.bind(xf, sharding=s,
  File "/home/ids/afreitas/jax/lib/python3.10/site-packages/jax/_src/pjit.py", line 2179, in <listcomp>
    outs = [sharding_constraint_p.bind(xf, sharding=s,
  File "/home/ids/afreitas/jax/lib/python3.10/site-packages/jax/_src/core.py", line 422, in bind
    return self.bind_with_trace(find_top_trace(args), args, params)
  File "/home/ids/afreitas/jax/lib/python3.10/site-packages/jax/_src/core.py", line 425, in bind_with_trace
    out = trace.process_primitive(self, map(trace.full_raise, args), params)
  File "/home/ids/afreitas/jax/lib/python3.10/site-packages/jax/_src/core.py", line 913, in process_primitive
    return primitive.impl(*tracers, **params)
  File "/home/ids/afreitas/jax/lib/python3.10/site-packages/jax/_src/pjit.py", line 2191, in _sharding_constraint_impl
    return api.jit(_identity_fn, out_shardings=sharding)(x)
  File "/home/ids/afreitas/jax/lib/python3.10/site-packages/jax/_src/sharding_impls.py", line 122, in shard_shape
    return _common_shard_shape(self, global_shape)
  File "/home/ids/afreitas/jax/lib/python3.10/site-packages/jax/_src/sharding_impls.py", line 68, in _common_shard_shape
    assert len(partitions) == len(global_shape), (len(partitions), len(global_shape))
AssertionError: (1, 3)

System info (python version, jaxlib version, accelerator, etc.)
python                   3.10
jax                      0.4.26

You need to reshape your sharding to match the length of the shape's ndim:
In [7]: import jax
   ...: from jax.experimental import mesh_utils
   ...: import jax.sharding as jshard
   ...:
   ...: num_devices = len(jax.devices())
   ...: print(f"Num GPUs: {num_devices}")
   ...: devices = mesh_utils.create_device_mesh((1, num_devices))
   ...: sharding = jshard.PositionalSharding(devices).reshape(1, 1, 8)
   ...: replicated = sharding.replicate()
   ...:
   ...: x = jax.random.uniform(jax.random.PRNGKey(42), (256, 20, 1000))
   ...:
   ...: x = jax.lax.with_sharding_constraint(x, sharding)

This might be a might inconvenient though, so I would suggest using NamedSharding instead:
In [10]: import jax
    ...: from jax.experimental import mesh_utils
    ...: import jax.sharding as jshard
    ...: from jax.sharding import PartitionSpec as P
    ...:
    ...: num_devices = len(jax.devices())
    ...: print(f"Num GPUs: {num_devices}")
    ...: devices = mesh_utils.create_device_mesh((1, num_devices))
    ...: mesh = jax.sharding.Mesh(devices, ('x', 'y'))
    ...: sharding = jshard.NamedSharding(mesh, P(None, None, 'x'))
    ...:
    ...: x = jax.random.uniform(jax.random.PRNGKey(42), (256, 20, 1000))
    ...:
    ...: x = jax.lax.with_sharding_constraint(x, sharding)
Num GPUs: 8

If you want to shard only the first dimension then your PartitionSpec can be P('x').

We should probably raise a better error message when this happens. Wdyt @yashk2810?

Sure, feel free to send a CL :)
You would need to implement is_compatible_aval method on PositionalSharding to raise a better error message.

Thanks @yashk2810 !
Indeed a better error message would be useful :)


Added new order status held

This order status is not documented here but the back-end sends it in some rare cases. I've added it into C# SDK months ago for unblocking clients' bracket order placement logic. This PR should solve issue #153 completely.

Thank you @OlegRa!


1.7.0 wont prod build: cannot read property line of undefined

Small dependencies problem I guess.
Versions
Angular CLI: 1.7.0-beta.1
Node: 8.9.4
OS: darwin x64
Angular: 5.2.0
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 1.7.0-beta.1
@angular-devkit/build-optimizer: 0.0.41
@angular-devkit/core: 0.0.28
@angular-devkit/schematics: 0.0.51
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.10.0-beta.1
@schematics/angular: 0.1.16
typescript: 2.5.3
webpack-bundle-analyzer: 2.9.2
webpack: 3.10.0

Repro steps

Fresh project using CLI v1.7.0-beta.1
ng build --prod

Observed behavior
The code won't compile at all. An error in modules.
/project/node_modules/clean-css/lib/reader/input-source-map-tracker.js:37
  if (originalPosition.line === null && line > 1 && selectorFallbacks > 0) {
                       ^

TypeError: Cannot read property 'line' of undefined
    at originalPositionFor (/project/node_modules/clean-css/lib/reader/input-source-map-tracker.js:37:24)
    at originalMetadata (/project/node_modules/clean-css/lib/tokenizer/tokenize.js:486:43)
    at intoTokens (/project/node_modules/clean-css/lib/tokenizer/tokenize.js:435:68)
    at tokenize (/project/node_modules/clean-css/lib/tokenizer/tokenize.js:74:10)
    at fromStyles (/project/node_modules/clean-css/lib/reader/read-sources.js:147:12)
    at fromString (/project/node_modules/clean-css/lib/reader/read-sources.js:48:10)
    at doReadSources (/project/node_modules/clean-css/lib/reader/read-sources.js:33:12)
    at readSources (/project/node_modules/clean-css/lib/reader/read-sources.js:24:10)
    at /project/node_modules/clean-css/lib/clean.js:99:12
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)

Mention any other details that might be useful
Tried to delete package-lock.json, delete node_modules, fresh reinstall. Same problem. Also tried yarn with no success.
Reverting to previous version make the error disappear.

Any news on that? With 1.7.0 stable it still occurs.

This is also happening for me too. I can confirm downgrading @angular/cli to 1.6.6 fixes the problem.
If it helps in solving what is going on in 1.7 here is my environment info.
It is happening on both MacOS and the node:latest containers that I am using on GitLab in my CI pipeline.
.../node_modules/clean-css/lib/reader/input-source-map-tracker.js:37
if (originalPosition.line === null && line > 1 && selectorFallbacks > 0) {
                       ^

TypeError: Cannot read property 'line' of undefined

same issue with 1.7.0 stable
.../node_modules/clean-css/lib/reader/input-source-map-tracker.js:37
if (originalPosition.line === null && line > 1 && selectorFallbacks > 0) {
^
TypeError: Cannot read property 'line' of undefined

Downgrading to 1.6.8 fixes the issue. It surely is a dependency upgrade in 1.7.0 which is more strict on css/scss way of writing. It's abnormal since style which was previously "compiled" and minified previously should not break the build since there was no change in these files.
There are several way of writing css, including breaking lines on some long properties. It should'nt break the build.

As already mentioned, broken in 1.7.0 but working in 1.6.8 with the same error as @KayoticSully and @sgomanf.
In my case the error occurs in a third party SCSS file from the PrimeNG Ultima theme.
_data.scss.txt
If I reformat the file using VSCode the error in the production build goes away but the CSS produced does not look right ...
_data (reformatted in VScode).scss.txt
Using original _data.scss (CSS correct, compile error prod build).

Using reformatted _data.scss (CSS incorrect, compile OK prod build).

I am also facing this issue.
Is there any solution for this?

In my opinion, the way we write css,  including "beautified" versions with multiple line breaks for better "looking code" should not impact the build success or fail.

@blackholegalaxy I have too many css files in my project. Is there any way that I can find out that which file has such issue ?
Or is there any way to troubleshoot this ?

Downgrading to 1.6.8 did not solve my issue.

I did not manage to find a way to detect faulty file. Solution by @MisterEffix console logs around 500 lines of 0, 1px and single liners like that. So it doesn't help determine which file/line is faulty.

@blackholegalaxy, I have looked for a line at the end of these logs the first line that was "foundable" in my source files.  My one was something like "0.2s margin ease-in" (a string easly foundable in my css).
It didn't point exactly to the problematic css property but the problem wasn't far away.
Hope it helps.

Alright! It's confirmed that this is happening in latest version of angular cli.
I finally fixed my issue by lowering version to 1.6.7 and by removing ^
I was facing this issue even after lowering version:
"@angular/cli": "^1.6.7"
Then I removed ^ to fix the cli version and now it works fine.
I request that please fix this angular cli issue so that we can use latest versions.
I hope this would help.

It doesn't change the fact having scss which previously compiled and which seems correct. In the example mentionned above, MisterEffix case:
.is-loading .spinner {
   transition: 0.2s margin ease-in,
      .4s opacity ease-in;
  margin-left: 5px;
  opacity: 1;
}

is a common way to write long statements. It's not incorrect and should therefore not break the build.

Maybe helpful for any VSCode user:
Installing extension and format all SCSS files with it has fixed the issue.

Finally manage to get the one who threw the error: it was a non-breaking space in the scss.
Definitely, this should'nt break that way hard.

@asadsahi In my case, the VSCode Beautify extension fixed the compile issue but the resulting CSS produced didn't seem right.
See my previous comment.

I agree that the SCSS compiler is improperly handling whitespace and/or should allow more flexibility with technically incorrect CSS. However, this is an issue with clean-css module, not Angular and so reporting it here really isn't going to get much traction. Not trying to be dismissive, just suggesting a better place to focus these issues.

@jacobslusser you are right. I will close the comment and report it to clean-css instead

@jacobslusser that is even more worrying to see the differences in rendering.

@jamieathans, we'll check Ultima theme. Thanks a lot!

@mertsincan I found out the issue with the Ultima theme.
Line 487 of assets/sass/theme/_data.scss contains a bad character.

By reformatting and removing the bad character, the border-color: $accentColor starts actually working and thus we see this being applied in the output.
Personally, I prefer it the original way which is basically border-color: inherit.

@jamieathans  how do you lint this??
I have same problem with materialize-css  (using dist/css),  on ng build
92% chunk asset optimization/Users/elporfirio/Projects/temu-fidelizacion-cms-nodejs/source/node_modules/clean-css/lib/reader/input-source-map-tracker.js:37
 if (originalPosition.line === null && line > 1 && selectorFallbacks > 0) {

@elporfirio I had to go through my scss/css manually to find out which one was causing the problem.
The VSCode Highlight Bad Chars plugin showed me where the problem was.

@jamieathans  thank you.
Alternative method don't add css/sass to angular.cli , instead copy css to assets folder, and add respective link to index.html.
It is ugly, but it can help while library gets an update.

I wonder how quickly it will be fixed upstream; if it's not quick, it will be wonderful to have CLI put in some kind of workaround. It's currently a remarkably unpleasant development experience when this happens.

Would be great if angular team, at scss compile step, could regex and remove all non-breaking spaces.

https://github.com/jakubpawlowicz/clean-css/issues/1006

Used js-beautify (https://github.com/beautify-web/js-beautify)
npm -g install js-beautify
Then cd to /src.
Then create .jsbeautifyrc en /src path.
{
"css": {
    "allowed_file_extensions": [
        "css",
        "scss",
        "sass",
        "less"
    ],
    "end_with_newline": false,
    "indent_char": " ",
    "indent_size": 4,
    "newline_between_rules": true,
    "selector_separator": " ",
    "selector_separator_newline": false,
    "preserve_newlines": false,
    "max_preserve_newlines": 1
}

}
And finally apply to all .scss files (or .css if you have them)
In Windows I used:
FORFILES /S /M *.scss /C "cmd /c css-beautify -r -f @file"

any update on this?

replace the code in node_modules/clean-css/lib/reader/input-source-map-tracker.js with the following
`var SourceMapConsumer = require('source-map').SourceMapConsumer;
function inputSourceMapTracker() {
var maps = {};
return {
all: all.bind(null, maps),
isTracking: isTracking.bind(null, maps),
originalPositionFor: originalPositionFor.bind(null, maps),
track: track.bind(null, maps)
};
}
function all(maps) {
return maps;
}
function isTracking(maps, source) {
return source in maps;
}
function originalPositionFor(maps, metadata, range, selectorFallbacks) {
var line = metadata[0];
var column = metadata[1];
var source = metadata[2];
var position = {
line: line,
column: column + range
};
var originalPosition;
while (!originalPosition && position.column > column) {
position.column--;
originalPosition = maps[source].originalPositionFor(position);
}
if (originalPosition && originalPosition.line === null && line > 1 && selectorFallbacks > 0) {
return originalPositionFor(maps, [line - 1, column, source], range, selectorFallbacks - 1);
}
return (originalPosition && originalPosition.line) !== null ?
toMetadata(originalPosition) :
metadata;
}
function toMetadata(asHash) {
if(asHash){
return [asHash.line, asHash.column, asHash.source];
}
}
function track(maps, source, data) {
maps[source] = new SourceMapConsumer(data);
}
module.exports = inputSourceMapTracker;
`

It's now fixed as per clean-css 4.1.10 release just few hours ago. So it it occurs again on your side, just let npm install CLI with latest clean-css version. It should work.

I still have this issue with the version 1.7.1 of the CLI which is installed with clean-css 4.1.9

I confirm the issue is solved with angular CLI 1.7.2 which is is installed with clean-css 4.1.10  :-).
It can be closed.

@FabienDehopre you need to remove node_modules and let npm/yarn recompute angular dependencies.
@MisterEffix already closed? ;p

We have updated our dependency to<EMAIL_ADDRESS>meanwhile, but for those still affected you can do this:
npm install<EMAIL_ADDRESS>npm uninstall clean-css
npm ls clean-css

Installing and uninstalling should force the package manager to use the newer one and dedupe it. This is generally useful when you want to force your project to use a certain version of an indirect dependency, and better than just deleting your node_modules and package lock.


Replacing license headers per PR-3700 feedback.

Replacing license headers per PR-3700 feedback.

Not sure about doxygen warnings source, please advise.

Is it possible that something has changed on "Docs" builder side about a day ago? Recent builds all go with similar warnings on that builder.

@mkostin You are right, it is testing infrastructure issue. Fixed

:+1:


Fix compilation errors with btrfs-progs-4.5

btrfs-progs-4.5 introduces device delete by devid
for this reason btrfs_ioctl_vol_args_v2's name was encapsulated
in a union
this patch is for setting btrfs_ioctl_vol_args_v2's name
using a C function in order to preserve compatibility
with all btrfs-progs versions
Signed-off-by: Julio Montes<EMAIL_ADDRESS>

@devimc looks like this needs a gofmt; https://jenkins.dockerproject.org/job/Docker-PRs-experimental/17233/console
21:40:08 These files are not properly gofmt'd:
21:40:08  - daemon/graphdriver/btrfs/btrfs.go
21:40:08
21:40:08 Please reformat the above files using "gofmt -s -w" and commit the result.

ohh my bad, sorry


Adjust docs for clarity around setters (RFC)

Description
The generated docs pick up closeButtonContent(content) as a function which takes in a content param, but there's no documentation around the fact that it is a setter. Meaning, its usage is closeButtonContent = yourContent, not closeButtonContent(yourContent).
Solutions?
Maybe this is as easy as outlining this in the comments. Or is there a better way in JSDoc to deal with this sort of thing?

Good catch. Gonna have to dig into JSDoc Docs

I spent some time today looking into this. Can't find an amazing solution, but changing from @param to @type seems to do the job.

I spent some time today looking into this. Can't find an amazing solution, but changing from @param to @type seems to do the job.


cmake include file search out of sync with a stdenv update some time ago

Currently cmake has a setup-hook that tries to add include search directories listed in NIX_CFLAGS_COMPILE using -I to CMAKE_INCLUDE_PATH so that cmake can find the headers when running FIND_PACKAGE directive.
Unfortunately, that hook is out of sync with stdenv that currently uses -isystem /path/to/include/dir/ format.
I have added approximately this code to one package:
preConfigure = ''
    include=
    for i in $NIX_CFLAGS_COMPILE; do
      if test -n "$include" && test -d "$i"; then
        export CMAKE_INCLUDE_PATH="$CMAKE_INCLUDE_PATH''${CMAKE_INCLUDE_PATH:+:}$i"
      fi;
      if test "x$i" = "x-isystem"; then
        include=1
      else
        include=
      fi
    done
'';

I think something like that is needed in the cmake setup hook, but the question is «when» and «in which branch» (given the talk of release-16.09 branch deadline approaching).

If you know a solution, push it to staging. Afterwards we can discuss whether it's worth picking to 16.09 which has been branched off in the meantime.

My only test case depends on Qt which also depends on CMake…
I hope the overnight build will succeed.

Pushed to staging

Ref: dabf09aa9, in master now. I think it's solved, except for the 16.09 question.

This issue can be closed now I think.


TheHive - Create Case updated

Added fields:

pap
flag
Customfields
CustomJson (import new case by filling only the json)

Corrected:

TLP level

Beautifying the code:

TLP, PAP, Severity code
Tags code

Nice! Thanks :dancers:


Wrong assertion handling failed with xpath

Describe the bug
When dealing with HTML as response and handling assertions via xpath validation, failed assertions are not recognized as failures and the tests pass as successful.
To Reproduce
Steps to reproduce the behavior:

Choose a test object with HTML as reponse (e.g. JPetStore)
Define an assertion via Xpath
Manipulate assertion so it failes
Run test
Assertions failes, but test finishes successfully

Expected behavior
If a xpath validation as assertion failes, the test should be marked as failed, too.
Screenshots

Desktop (please complete the following information):

STAF-Version 0.50

Tests are know failing with Xpath validation when assertion fails.


Getting error if documentDB instance does not exists yet

Hi again!
I guess I'm doing something wrong, but that's how I've been working with the mysql provider without any problems.
When I try to start an environment for the first time and configure the provider as recommended, I get an error when I launch terraform apply the first time.
"Error: Error connecting to Mongo server context deadline exceeded"
Of course it cannot connect. IT is only trying to refresh tfstate and the documentDB database has not been launched yet.
My related configuration follows:
terraform {
  required_providers {
    .........
    mongodb = {
      source  = "Kaginari/mongodb"
      version = "0.0.8"
    }
  }
  required_version = ">= 1.0.0"
}

module "documentdb_cluster" {
  source                  = "git::https://github.com/cloudposse/terraform-aws-documentdb-cluster.git?ref=tags/0.8.0"
  namespace               = ""
  stage                   = terraform.workspace
  name                    = "docdb"
  engine_version          = "4.0.0"
  cluster_family          = "docdb4.0"
  master_username         = data.aws_ssm_parameter.DOCDB_USERNAME.value
  master_password         = data.aws_ssm_parameter.DOCDB_PASSWORD.value
  cluster_size            = local.settings.docdb_cluster_size
  instance_class          = local.settings.docdb_instance_size
  vpc_id                  = module.networking.vpc.vpc_id
  allowed_security_groups = [aws_security_group.ecs_worker.id]
  subnet_ids              = module.networking.vpc.private_subnets
  allowed_cidr_blocks     = [local.settings.common_services_cidr]

  tags = local.tags
}

provider "mongodb" {
  alias                = "docdb_cluster"
  host                 = module.documentdb_cluster.endpoint
  port                 = "27017"
  username             = data.aws_ssm_parameter.DOCDB_USERNAME.value
  password             = data.aws_ssm_parameter.DOCDB_PASSWORD.value
  auth_database        = "admin"
  ssl                  = true
  insecure_skip_verify = true
  certificate          = file("${path.module}/tools/rds-combined-ca-bundle.pem")

}

resource "mongodb_db_user" "user_profile_management" {
  provider      = mongodb.docdb_cluster
  auth_database = "admin"
  name          = data.aws_ssm_parameter.PROFILE_SERVICE_USER.value
  password      = data.aws_ssm_parameter.PROFILE_SERVICE_PASSWORD.value
  role {
    role = "dbOwner"
    db   = data.aws_ssm_parameter.PROFILE_SERVICE_DBNAME.value
  }
  depends_on = [module.documentdb_cluster]

}

❯ terraform state list
aws_efs_file_system.hgts
aws_efs_file_system.resources

❯ terraform apply
aws_efs_file_system.hgts: Refreshing state... [id=fs-XXXX]
aws_efs_file_system.resources: Refreshing state... [id=fs-YYYY]
╷
│ Error: Error connecting to Mongo server context deadline exceeded
│
│   with provider["registry.terraform.io/kaginari/mongodb"].docdb_cluster,
│   on rds_docdb.tf line 29, in provider "mongodb":
│   29: provider "mongodb" {
│
╵
Releasing state lock. This may take a few moments...

Am I missing something?

Hello @viyullas  , the  way mysql provider works is different , your suggestion seems legit.
We well try to change the behavior.
Thank you again for your support :)

Thank you for your great job.

BUG when database is not created  fixed  (add  plan support  when database is not created too )
@viyullas  in the version  v0.1.1  of the provider the problem is fixed
Thank you again for your support  :)


AS5600 Encoder Showing Pos_error when ESC Power is connected

When only USB is connected the encoder shows position and loops values within a range.
But when power is connected to the USB:

Hello friend, how are you? With this firmware is it possible for me to control a motor to rotate at low speed? I want to control it at low speed and only have speed feedback. I'm trying to use this ESC to control 4 wheels. Basically I want to control an omnidirectional robot.


Bug fix on simple mixing in GCEED part

I fixed a bug on simple mixing in GCEED part.

For simple mixing and Broyden's method, obtained oscillator strength of a C2H2 molecule is same. So I merge this PR.

Thank you for merging, @mn2007 san.


removed abs path to dylib -DDY=..

from comments in the pull request "check for --enable-shared #7"

superseded by another pull request:
initial configure.py. uses python-config --ldflags if not anaconda
#15 opened 11 minutes ago by effbiae


Provide other kind of development workflows

# Create a new deploy and build a new release based on the remote repository
koli create deploy django --remote github.com/repo#[branch|tag]
# Update a deploy and build a new release based on the remote repository
koli update deploy django --remote github.com/repo#[branch|tag]

# Development workflow
[ A team work on local repositories with git ]

# Lets test the application on the cloud or deploy to a production namespace
koli create deploy django --remote https://github.com/heroku/python-getting-started.git#v0.1.0
# Track the release build on real time
koli release django/v1 --logs -f

[ Build finished ]
[ A team work on several bugs with git ]

# Lets deploy the changes
koli update deploy django --remote https://github.com/heroku/python-getting-started.git#v0.1.1
# Track the release build on real time
koli release django/v2 --logs -f

The koli command line it's not on the road map yet, closing for now.


fix: file#move do not delete origin file if same as destination

[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Currently if user passes same bucket object, fileobject, or fileName string as the original file, the client will attempt to "copy" (essentially leaving the file in place) and subsequently delete the origin/destination file.

Sounds like what we really should do here is to error out when the user tries to copy/move to the same destination, unless I'm missing something here?

IMHO I am not sure passing same destination on copy/move deserves an error (would be a breaking change). WDYT?

Yeah I would try to avoid a breaking change here as well. The draft looks good, promote it to a PR?


SA1649 code fix does not remove files from linked projects

When renaming a source file A.cs → B.cs, the code fix for SA1649 properly updates each project which previously included A.cs to now include B.cs. However, it only removes A.cs from the project which was the context for the rename operation.
During the rename, the original file needs to be removed from all projects which contained it.

Grabbing this

Blocked on dotnet/roslyn#6261.

The root cause simply seems to be a missing call to RemoveDocument here:
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/DocumentationRules/SA1649CodeFixProvider.cs#L66-L71


Loading a week

Describe your bug here.
so i load in a custom made json file for week 2 in the game in story mode but an error js shows up and crashes the game (with the error msg log thing)
idk what happened but it seems like seomthing to do with the events or an xml from somewhere
using build 0.6.3
Command Prompt/Terminal logs (if existing)
C:\HaxeToolkit\haxe\std/haxe/xml/Parser.hx (line 254)
C:\HaxeToolkit\haxe\std/haxe/xml/Parser.hx (line 285)
C:\HaxeToolkit\haxe\std/haxe/xml/Parser.hx (line 117)
C:\HaxeToolkit\haxe\std/Xml.hx (line 122)
flixel/graphics/frames/FlxAtlasFrames.hx (line 246)
Character.hx (line 164)
PlayState.hx (line 973)
flixel/FlxGame.hx (line 637)
flixel/FlxGame.hx (line 724)
flixel/FlxGame.hx (line 677)
flixel/FlxGame.hx (line 545)
openfl/events/EventDispatcher.hx (line 402)
openfl/display/DisplayObject.hx (line 1399)

Uncaught Error: haxe.xml.XmlParserException: Expected = at line 14 char 34
Please report this error to the GitHub page of Psych Engine (cos idk how to code and
its still psych engine technically): https://github.com/ShadowMario/FNF-PsychEngine

> Crash Handler written by: sqirra-rng
shiftyZ was here

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
yes, i edited MainMenuState.hx (removing the pretty much useless tabs leaving only story mode, freeplay, creedits and options), edited CreditState.hx (for the credits ofc), edited TitleState.hx (removed the default blackBackground and replacing it with an image (assets\images\coolswag2.png), re added the old fnf floating logo thing but applied it to logoBumpin, edited the startup screen text), edited CrashState.hx (i think its called that, i only made it so that the errors contributes to my psych fork basically), FPS.hx (so that the font is different and the text shows something additional), anjd a few more things i forgor

loving how noone replied


Use autobahn in CI scripts

@BenchR267 What do you think about dogfooding autobahn in our CI scripts?

Great idea!


[BEAM-7945] Allow runner to configure semi_persist_dir which is used …

Currently "semi_persist_dir" is not configurable. This may become a problem in certain scenarios. For example, the default value of "semi_persist_dir" is "/tmp" (https://github.com/apache/beam/blob/master/sdks/python/container/boot.go#L48) in Python SDK harness. When the environment type is "PROCESS", the disk of "/tmp" may be filled up and unexpected issues will occur in production environment.
So, This pull request makes the semi_persist_dir configurable through adding a new PipelineOption(RemoteEnvironmentOptions).The Pipeline option will be passed to the DefaultJobBundleFactory and then be used in each EnvironmentFactory(docker, process, external and embedded).
For details of the discussion can be found in [1].

I appreciate if you have time to look up the changes @robertwb @mxm :)

Thanks for the review @mxm !
I have update the PR according your comments. I appreciate if you can have a another look.

@mxm @tweise  Thanks a lot for the review. Sorry that I missed the comments from @tweise.
I have updated the PR, would be great if you can take another look.

Run Java PreCommit


Sticky header is not removed when RecyclerView is gone

Is there any clean way to hide/remove the sticky header when the RecyclerView's visibility changes?

Currently, no. The header id is R.id.header_view so you can look for that and, if not null, hide it.
I think this is a good enhancement and shouldn't be hard to implement in the library using an OnGlobalLayoutListener. I'll get this set up to be automatic in a release sometime this weekend.

Could you instead hide the parent layout, rather than the RecyclerView?

Cool, @bgogetap thanks for the tip!

Btw it can be a bit tricky to hide the "proper" header if you have multiple RecyclerViews with StickyHeaders under the same parent (e.g. a TabLayout switching between different lists)

Have the same problem.
Single activity that show single fragment. One of there fragmets is recycler view with sticky headers. I try to hide header when fragment is detached. However this works only the first time. In case I'm switching back to recycler view fragment and then switching to another fragment - header is not hiding.
   @Override     public void onDetach() {         getActivity().findViewById(R.id.header_view).setVisibility(View.GONE);         super.onDetach();     }

Fixed in 0.5.0