No bug: Optimize seed process

What happened?
I optimize the import process for only import active countries, it is necessary for my because import all countries  is very long time and memory consuming. In my case, only need active countries.
How to reproduce the bug
<?php

namespace Database\Seeders;

use Altwaireb\World\Database\Seeders\BaseWorldSeeder;
use Altwaireb\World\Models\City;
use Altwaireb\World\Models\Country;
use Altwaireb\World\Models\State;
use Altwaireb\World\World;

class WorldTableSeeder extends BaseWorldSeeder {

    protected function createCountries(): void {
        $allCountries = $this->serves->getCountries();
        $countriesActive = World::getIdsCountriesActiveByIso3();

        $countries = array_filter(
            $allCountries,
            fn($country) => in_array($country->id, $countriesActive)
        );

        $this->command->info('Starting Seed Country Data ...');
        $this->command->getOutput()->progressStart(count($countries));

        foreach ($countries as $country) {
            Country::create([
                'id' => $country->id,
                'name' => $country->name,
                'iso2' => $country->iso2,
                'iso3' => $country->iso3,
                'numeric_code' => $country->numeric_code,
                'phonecode' => $country->phonecode,
                'capital' => $country->capital,
                'currency' => $country->currency,
                'currency_name' => $country->currency_name,
                'currency_symbol' => $country->currency_symbol,
                'tld' => $country->tld,
                'native' => $country->native,
                'region' => $country->region,
                'subregion' => $country->subregion,
                'timezones' => $country->timezones,
                'translations' => $country->translations,
                'latitude' => $country->latitude,
                'longitude' => $country->longitude,
                'emoji' => $country->emoji,
                'emojiU' => $country->emojiU,
                'flag' => $country->flag,
                'is_active' => TRUE,
            ]);
        }
        $this->command->getOutput()->progressFinish();
        $this->command->info('Country Data Seeded has successful');
        $this->command->line('');
    }

    protected function createStates(): void {
        $allStates = $this->serves->getStates();
        $countriesActive = World::getIdsCountriesActiveByIso3();

        $states = array_filter(
            $allStates,
            fn($state) => in_array($state->country_id, $countriesActive)
        );

        $this->command->info('Starting Seed State Data ...');
        $this->command->getOutput()->progressStart(count($states));

        foreach ($states as $state) {
            State::create([
                'id' => $state->id,
                'name' => $state->name,
                'country_id' => $state->country_id,
                'latitude' => $state->latitude,
                'longitude' => $state->longitude,
                'is_active' => TRUE,
            ]);
            $this->command->getOutput()->progressAdvance();
        }

        $this->command->getOutput()->progressFinish();
        $this->command->info('State Data Seeded has successful');
        $this->command->line('');
    }

    protected function createCities(): void {
        $allCities = $this->serves->getCities();
        $countriesActive = World::getIdsCountriesActiveByIso3();

        $cities = array_filter(
            $allCities,
            fn($city) => in_array($city->country_id, $countriesActive)
        );

        $this->command->info('Starting Seed City Data ...');
        $this->command->getOutput()->progressStart(count($cities));

        foreach ($cities as $city) {
            City::create([
                'id' => $city->id,
                'name' => $city->name,
                'country_id' => $city->country_id,
                'state_id' => $city->state_id,
                'latitude' => $city->latitude,
                'longitude' => $city->longitude,
                'is_active' => TRUE,
            ]);

            $this->command->getOutput()->progressAdvance();
        }

        $this->command->getOutput()->progressFinish();
        $this->command->info('City Data Seeded has successful');
    }

}

Package Version
1.0
PHP Version
8.3
Laravel Version
11
Which operating systems does with happen with?
Linux
Notes
I publish my solution in case it is useful to another developer.

You can now update and select the countries you want to create through:
return [
    'insert_activations_only' => true,
    'countries' => [
        'activation' => [
            'default' => true,
            'only' => [
                'iso2' => ['AL','AR'],
                'iso3' => [],
            ],
            'except' => [
                'iso2' => [],
                'iso3' => [],
            ],
        ],
        'chunk_length' => 50,
    ],

    ...
];

Thank you for that.


[RFC] Renaming API for consistency

Summary 💡
API which stands for it's component shape is not consistent between components.
like round vs circle, rectangle vs rect, and outlined (adjective) vs round (noun).
This have been discussed on several PRs by @oliviertassinari and @mblodorn
https://github.com/mui-org/material-ui/pull/18116#issuecomment-548984709
https://github.com/mui-org/material-ui/pull/21903#issuecomment-663647529
As this is breaking changes, it would be great to have more feedback from community on suggested changes bellow.
Changes
suggested change by @oliviertassinari at https://github.com/mui-org/material-ui/pull/21903#issuecomment-663701937
- Pagination (& Item): `shape: PropTypes.oneOf(['round', 'rounded']),`
- Fab: `variant: PropTypes.oneOf(['extended', 'round']),`
- Avatar: `variant: PropTypes.oneOf(['circle', 'rounded', 'square']),`
- Badge: `overlap: PropTypes.oneOf(['circle', 'rectangle']),`
- Skeleton: `variant: PropTypes.oneOf(['circle', 'rect', 'text']),`
+ Pagination (& Item): `shape: PropTypes.oneOf(['circular', 'rounded']),`
+ Fab: `variant: PropTypes.oneOf(['extended', 'circular']),`
+ Avatar: `variant: PropTypes.oneOf(['circular', 'rounded', 'square']),`
+ Badge: `overlap: PropTypes.oneOf(['circular', 'rectangular']),`
+ Skeleton: `variant: PropTypes.oneOf(['circular', 'rectangular', 'text']),`

Related
https://github.com/mui-org/material-ui/issues/20012 (v5 RFC)
https://github.com/mui-org/material-ui/pull/21903
https://github.com/mui-org/material-ui/issues/21593 (loading vs pending)
cc @mui-org/core-team

@kodai3 I think that we are clear to go on this one.

I renamed Fab component here https://github.com/mui-org/material-ui/pull/21903.
I will work on others soon


[0.8.12 BUG] Edge case: Burn inner first is missing a few burns where end nodes are coincident with outer path nodes

In inkscape the inner nodes were explicitly snapped to edge nodes, yet the edge was burned first.
I suspect that this is either a floating point rounding error or an issue with the way the algorithm approximates the outer or inner paths- the inside check needs to allow inner paths to be fractionally (i.e. say 1/2 the width of a laser beam) outside the outer path.

Couldn't establish a case where that became evident. Do you have a culprit file to be showed/shared?

This is (literally) an edge case, perhaps due to comparisons between floating point coordinates, probably in the same code referred to in the issue about images being inside #2192 where I said:

P.P.S. There also seems to be a potential bug around use of the rounding tolerance. In the raster-specific tests, the tolerance is applied the opposite way from the following tests and I cannot work out why.

If the tolerance was applied the wrong way around, then it would likely have this effect.

Fine, I created an edge case myself. But - and that's a bit but - the current scan beam implementation in geomstr as well as the old VectorMonotizer do not support at all (scan beam) / incompletely (VectorMonotizer) tolerances. So this needs to go to the backlog for now. But it's unfortunately not a simple arithmetic error.

It took me some time but I think this much better: Commit

The early bounding box check was faulty
The is_inner check did not recognize the tolerance


Add tag_cloud to add tags to home page.

Discussed in https://github.com/wowchemy/wowchemy-hugo-themes/discussions/2495
Newbie to wowchemy here.
I am trying to add tags to the home page of my website (https://www.ajitgoel.net/). I added the tag_cloud based on the documentation here. I however do not see the tag_cloud added to my home page. What am I missing?
To add I use the wowchemy UI to add blogs pages to my website, but I am trying to make it more professional.
https://raw.githubusercontent.com/ajitgoel/hugo-blog-theme/main/content/home/index.md
--- #Homepage type: widget_page widget: tag_cloud #Homepage is headless, other widget pages are not. headless: true content:   #Choose the taxonomy from config.yaml to display (e.g. tags, categories)   taxonomy: tags   #Choose how many tags you would like to display (0 = all tags)   count: 20 design:   #Minimum and maximum font sizes (1.0 = 100%).   font_size_min: 0.7   font_size_max: 2.0 ---

I have created a post on https://stackoverflow.com/questions/71581920/add-tag-cloud-to-wowchemy-theme


[TI-CDC] Using canal JSON to output to Kafka, different primary key types produce inconsistent results

Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
1.Deploy tidb and ticdc
2.Create a table with int type as primary key
CREATE TABLE `int_id_table` (
  `int_id` int(11) NOT NULL,
  `var1` varchar(255) DEFAULT NULL,
  PRIMARY KEY (`int_id`) /*T![clustered_index] CLUSTERED */
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;

3.Create another table with varchar type as primary key
CREATE TABLE `varchar_id_table` (
  `varchar_id` varchar(32) NOT NULL,
  `var2` varchar(255) DEFAULT NULL,
  PRIMARY KEY (`varchar_id`) /*T![clustered_index] NONCLUSTERED */
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;

4.Create a ticdc synchronization task to output the change logs of the above two tables to kakfa
{"changefeed_id":"test4","sink_uri":"kafka://xxxxxxx:9092/ticdc-test4?kafka-version=2.5.0&protocol=canal-json",
"filter_rules":["test.int_id_table","test.varchar_id_table"]}

5.Insert data into the above two tables, and then update their primary keys
insert into int_id_table value ('1','1');
insert into varchar_id_table value ('2','2');
update int_id_table set int_id = '3' where int_id = '1';
update varchar_id_table set varchar_id = '4' where varchar_id = '2';

2. What did you expect to see? (Required)
The log of primary key update is split into delete log and insert log, which is convenient for downstream processing with flink.
3. What did you see instead (Required)
The int type primary key change log is split, but the varchar type primary key log is not split.

4. What is your TiDB version? (Required)
Release Version: v5.4.0
Edition: Community
Git Commit Hash: 55f3b24c1c9f506bd652ef1d162283541e428872
Git Branch: heads/refs/tags/v5.4.0
UTC Build Time: 2022-01-25 08:39:26
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false

I transferred this issue from pingcap/tidb to pingcap/tiflow, because TiCDC  was developed in this repo.

The log of primary key update is split into delete log and insert log, which is convenient for downstream processing with flink.

You mean Flink can't handle update events?

Flynk inserted the updated data, but did not delete the data before the update.
Because there is no delete event.

This will cause invalid data accumulation when I use ticdc as the source to synchronize data to the downstream, because such old ID data has not been deleted.
This may be related to the degree of support for the Flink canal JSON format.

When the update does not involve the primary key, it can work normally. flink use the upsert method to overwrite the data. When the primary key changes, upsert uses the after content in the update log, so it only writes the updated data to the downstream without deleting the before data. This is why I expect ticdc to be split into delete events and insert events like int primary keys.

I try to use changefeed_ config to set the enable old value configuration, but it doesn't seem to work.
myconfig
enable-old-value = false
[filter]
rules = ['test.int_id_table','test.varchar_id_table']
[sink]
protocol = "canal-json"

my create command
./cdc cli changefeed create --pd=http://xxx:2379 --sink-uri="kafka://xxx:9092/ticdc-test4?kafka-version=2.5.0&protocol=canal-json" --config ./changefeed_config.toml

Synchronize task information

Is my configuration wrong?

At present, I can only avoid the synchronization task of varchar primary key. Although this is caused by the mechanism of Flink, I still expect ticdc to unify the behavior of outputting logs through the adjustment of parameter configuration, which is very useful for users to maintain a consistent experience
By the way, I have also tried to use the Ti CDC connector by Flink Chinese community to complete such work, but I found that is not stable enough. I have also mentioned such problems in relevant communities
(https://github.com/ververica/flink-cdc-connectors/issues/1154).

Can you try the arvo protocol? It also works well with flink, but you need to use v6.1 version.(other versions have some bugs)

The project has no plan to upgrade tidb for the time being. I'll try it if I have a chance.

I'll close this issue. If you have any other questions, please feel free to reopen this issue.


MeiQ: Labyrinth of Death [PCSE00918]

App summary

App name: MeiQ: Labyrinth of Death
App serial: PCSE00918
App version: 1.0

Vita3K summary

Version: v0.1.5
Build number: 2656
Commit hash: https://github.com/vita3k/vita3k/commit/d6200b6
CPU backend: Dynarmic

Test environment summary

Tested by: gymzatan
OS: Windows 11
CPU: AMD Ryzen 7 5800H
GPU: AMD Radeon(TM) Graphics
RAM: 16 GB

Issues
Game runs beyond intro and menu, can save, but freezes at black screen right after displaying the prologue title.
Screenshots

Log
vita3k.log
Recommended labels

Ingame -

Playable for me

You're running the European version (PCSB00990) so that could be the reason.

Playable for me

The European version is playable on my end as well.


add github issue and PR templates

Adds github issue and PR templates so we can have more consistent
issues and PRs opened.

Merge pending discussion on https://github.com/rust-bpf/rust-bcc/pull/55

#19 achieves the goal of this PR with nicer wording. Closing without merge


Add mid-download token refresh, fix headers length overflow bug

Added mid-download token refresh (it's really a cookie not a Bearer buy anyway). We hook into fessonia's .update event, do a time delta and check if we need to refresh the token and if so, we go do it every 3000 seconds. I bit into the setInterval() poisoned apple at first, oh boy what a trip has that been...

Added fix for Node headers overflow (i'm very surprised we didn't get any issue on this yet).  The Node devs raised this limit again in 13.x, but 12 and versions below it have it set to 8KB by default. To add insult to injury Node 8.x doesn't boot with the header parameter passed to it so we need to if around that at bootstrap.

cli-progress upped to 3.8.0 via project-lock.json. It happened so i didn't fight it. Seems to work fine.

Slightly refactored the Puppeteer test in the hope GItHub Actions would show us mercy

i think there is still a missing case:
your old token is still valid for x mins, you run destreamer, next refresh is y (y > x), next download will fail
i would not print messages while stdout is controlled by cli-progress, it will create minor glitches, we can just refresh the token under the hood, the user does not need to know when that happens, it is a verbose thing
so we maintain a clean output

.token_cache only holds the initial Bearer token we get from sessionInfo. At the start of each download we get a fresh cookie anyway either by passing the Bearer token or by reading session.Cookie.
https://github.com/snobu/destreamer/blob/midwayrefresh/src/destreamer.ts#L187
To sum up, we boot up and call the API with a Bearer token then we do all the subsequent calls with fresh cookies unless we can't get one and we fall back to our original Bearer.
Am i missing something here?

I'm with you on the verbose flag, will push a change now. We should think about moving to debug before the whole verbose things gets outta control.

ok, missed that line, i was looking only at the changes

This looks really great to me, exactly what I had in mind as a concept

I have a bug which i'm trying to track down, looks like i'm refreshing the cookie but axios is still getting the old one when calling RefreshToken(). Just got a 401 from the API mid-download.

Alright, fixed the bug, dropped passing the token via session object in favor of optional parameter.
I've also added source maps to build step so it's caveman easy now to add a breakpoint in VSCode straight in the .ts file.


Artifacts when visualize the test.npy

As is shown @EvelynFan
Anybody came across this problem?

I got the same problem too. Have you find the solution to this problem?


Render D3 or ECharts

Hi,
Great job!
How I can render json data as: table, bar, pivottable with D3, echarts or pivottable.js ?
May I have to build everything as string setting the "$$html$$" variable?
Thanks in advance.

you should be able to use the %%script token to run javascript directly on the cell, you shouldn't have to build html variables for it


[SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

What changes were proposed in this pull request?
To wait until all the executors have started before submitting any job. This could avoid the flakiness caused by waiting for executors coming up.
How was this patch tested?
Existing tests.

Test build #122856 has started for PR 28584 at commit b08a272.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27501/
Test PASSed.

Thank you so much, @jiangxb1987 .

Retest this please

Test build #122860 has started for PR 28584 at commit b08a272.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27505/
Test PASSed.

Retest this please.

Test build #122862 has started for PR 28584 at commit b08a272.

Retest this please.

Test build #122864 has started for PR 28584 at commit b08a272.

Test build #122856 has finished for PR 28584 at commit b08a272.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122856/
Test FAILed.

"SPARK-31485: barrier stage should fail if only partial tasks are launched" This test case is flaky, @Ngone51 can you take a look?

sure, thanks!

Test build #122860 has finished for PR 28584 at commit b08a272.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #122864 has finished for PR 28584 at commit b08a272.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122860/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122864/
Test FAILed.

retest this please.

Test build #122862 has finished for PR 28584 at commit b08a272.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122862/
Test FAILed.

Test build #122865 has started for PR 28584 at commit b08a272.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27508/
Test PASSed.

Test build #122865 has finished for PR 28584 at commit b08a272.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122865/
Test FAILed.

Also fix this test like:
  test("share messages with allGather() call") {
    val conf = new SparkConf()
      .setMaster("local-cluster[4, 1, 1024]")
      .setAppName("test-cluster")
    sc = new SparkContext(conf)
    val rdd = sc.makeRDD(1 to 4, 4)
    val rdd2 = rdd.barrier().mapPartitions { it =>
      val context = BarrierTaskContext.get()
      // Sleep for a random time before global sync.
      Thread.sleep(Random.nextInt(1000))
      // Pass partitionId message in
      val message: String = context.partitionId().toString
      val messages: Array[String] = context.allGather(message)
      Iterator.single(messages.toList)
    }
    // Take a sorted list of all the partitionId messages
    val messages_list = rdd2.collect()
    assert (messages_list.length === 4)
    for (messages <- messages_list) {
      assert (messages === (0 until 4).map(_.toString).toList)
    }
  }

Opened a separate PR https://github.com/apache/spark/pull/28596 to fix the test @WeichenXu123

Retest this please.

Since #28596 is merged, shall we restart to proceed this PR? Thanks.

Test build #123066 has started for PR 28584 at commit b08a272.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27704/
Test PASSed.

Test build #123066 has finished for PR 28584 at commit b08a272.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123066/
Test FAILed.

ping @jiangxb1987 Could you please update this?

Test build #123106 has started for PR 28584 at commit 83a34c2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27740/
Test PASSed.

Test build #123106 has finished for PR 28584 at commit 83a34c2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123106/
Test FAILed.

retest this please.

Test build #123110 has started for PR 28584 at commit 83a34c2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27744/
Test PASSed.

Test build #123110 has finished for PR 28584 at commit 83a34c2.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123110/
Test FAILed.

retest this please.

Test build #123126 has started for PR 28584 at commit 83a34c2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27758/
Test PASSed.

Test build #123126 has finished for PR 28584 at commit 83a34c2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123126/
Test PASSed.

Retest this please.

Retest this please.

Test build #123134 has started for PR 28584 at commit 83a34c2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27766/
Test PASSed.

Test build #123134 has finished for PR 28584 at commit 83a34c2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123134/
Test PASSed.

Retest this please.

Let's trigger one more time to ensure the suite is no longer flaky.

Test build #123138 has started for PR 28584 at commit 83a34c2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27770/
Test PASSed.

Test build #123138 has finished for PR 28584 at commit 83a34c2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123138/
Test PASSed.

Retest this please.

Test build #123199 has started for PR 28584 at commit 83a34c2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27825/
Test PASSed.

Test build #123199 has finished for PR 28584 at commit 83a34c2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123199/
Test PASSed.

Thanks, merged to master/3.0 !

Opened https://github.com/apache/spark/pull/28658 for branch-3.0


Data Reporting:  Create dashboard with initial fields

Breakout from #2016
What we want: As an end user i want an easy to use dashboard for seeing all of the data that has been entered in the events manager, have the ability to create reports from this information and have it exportable to be able to report this to key stakeholders.
Initial fields that should be in the dashboard are:

How many volunteers in total were in a specific day (there should be a date range available in calendar format)
How many hours were spent in total
Time tracking per volunteer
Human asset tracking
How many smoke detectors were handed out in a specific day
Age of volunteers
Gender
Age

Mine! @binaryjanitor


Error: After re imaging computer, got my function folder back from GIT but its nor working anymore

I had to remove my azure function folder, and then i cloned it back from GIT. After that when I am trying to test locally using VS Code, its getting the local address ready, but once I do a curl call, it exits with these lines in the log
Language Worker Process exited. [6/24/19 3:39:05 PM] python exited with code 1 [6/24/19 3:39:05 PM]  SyntaxError: invalid syntax. [6/24/19 3:39:05 PM] Exceeded language worker restart retry count for runtime:python. Shutting down Functions Host
Its the same folder but now I got it from GIT in the same location too.
Any idea. Oh, its a python function.

@anindya5 It could be related to the local.settings.json file. That files isn't tracked in git because it could have sensitive information (connection strings, etc.). You could create a new project and copy that file over if you're not familiar with what it should look like
Also - do you have http triggers, timer triggers, or other triggers? Is your project open source - could I take a look?

thanks. that worked. its not open source.
On Wed, Jun 26, 2019 at 11:01 AM Eric Jizba<EMAIL_ADDRESS>wrote:

@anindya5 https://github.com/anindya5 It could be related to the
local.settings.json file. That files isn't tracked in git because it
could have sensitive information (connection strings, etc.). You could
create a new project and copy that file over if you're not familiar with
what it should look like
Also - do you have http triggers, timer triggers, or other triggers? Is
your project open source - could I take a look?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-azurefunctions/issues/1356?email_source=notifications&email_token=ACQLYQHRPPSED3KKSK6PCTLP4OHGLA5CNFSM4H276DIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUAJKA#issuecomment-505939112,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACQLYQBW5ZGQ5LCNHSG6H4TP4OHGLANCNFSM4H276DIA
.

--
Anindya Sankar Dey

Awesome - closing this.
We already have an issue to improve this experience here: https://github.com/microsoft/vscode-azurefunctions/issues/1233


[WIP] Knative Service forwarder for EventsHub receiver

Changes

:gift:
Add option for global environment to enable Knative Service Forwarder for EventsHub receiver:

ctx, env := global.Environment(eventshub.WithKnativeServiceForwarder)

Reuse forwarder from https://github.com/knative/eventing/blob/main/test/upgrade/prober/wathola/forwarder which is being maintained as part of knative/eventing repo. Version knative-v1.10.0 as of now
The forwarder has support for tracing and CloudEvents
Tests which use EventsHub can stay untouched if they don't want to use the Knative Service forwarder. Tests which want to use it can re-use Features from other tests and only configure global environment like in the example below:

func TestPingSourceBrokerTriggerKsvc(t *testing.T) {
	t.Parallel()

	ctx, env := global.Environment(
		knative.WithKnativeNamespace(system.Namespace()),
		knative.WithLoggingConfig,
		knative.WithTracingConfig,
		k8s.WithEventListener,
                // vvv------ This line enables KSVC forwarder. Other lines are unchanged.
		eventshub.WithKnativeServiceForwarder,
		environment.Managed(t),
	)

        // features.SendsEventsWithSinkRef is reused (not changed)
	env.Test(ctx, t, features.SendsEventsWithSinkRef())
}

Other alternatives considered:

Having EventsHub itself as Knative Service (vs. using the forwarder KSVC) - this approach has some drawbacks: The EventsHub records events and includes ObjectReference to the Pod that sends/receives the Event. This is problematic with Knative Serving because it might scale up and then there's no good way to get info about the concrete pod that is running.  It would have to be limited to max-scale=1 which is kind of limiting for the desired usecases. This limitation is not there with the forwarder approach.
Provide Knative Service as a separate StepFn - this limits the re-use of the whole Feature when someone want to test it together with Knative Service. It's no longer possible to re-use the whole Feature but it's required to re-implement it and add the KSVC in the scenario manually.

/kind

Fixes #516

Release Note

Docs

One problem is that we cannot depend on eventing (because eventing depends on rekt too), so we might need to move the forwarder in this repository and consume it from here in eventing

Uh. OK

I may pull out the most important stuff from the eventing-forwarder and copy the code here. A lot of the stuff is not required here. Let's see what's the minimal impl that works here.

I may pull out the most important stuff from the eventing-forwarder and copy the code here. A lot of the stuff is not required here. Let's see what's the minimal impl that works here.

Actually, the Eventshub itself already has most of the functionality. I will try to re-use code from there and not depend on anything from Eventing.

The current implementation of forwarder logs the forwarded events in this way:
{"level":"info","ts":"2023-05-02T08:55:00.368Z","logger":"eventshub.event logger","caller":"logger_vent/logger.go:26","msg":"Event: \n-- EventInfo --\n--- Kind: Received ---\n--- Event ---\nContext Attributes,\n  specversion: 1.0\n  type: dev.knative.sources.ping\n  source: /apis/v1/namespaces/test-sopikrdd/pingsources/pingsource-gbzgetvy\n  id: 893ff8c6-085f-46b5-9b3a-06028e2d24f8\n  time: 2023-05-02T08:55:00.287604272Z\nExtensions,\n  knativearrivaltime: 2023-05-02T08:55:00.29040074Z\n\n--- HTTP headers ---\n  X-B3-Spanid: 4fa16212ea1b1928\n  X-B3-Traceid: 0170963cc4b953629afd3438a5f3fdab\n  Content-Length: 0\n  Prefer: reply\n  Forwarded: for=<IP_ADDRESS>;proto=http\n  Accept-Encoding: gzip\n  Host: sink-kvnevsuz.test-sopikrdd.svc.cluster.local\n  K-Proxy-Request: activator\n  Traceparent: 00-0170963cc4b953629afd3438a5f3fdab-4fa16212ea1b1928-01\n  X-Forwarded-Proto: http\n  X-Forwarded-For: <IP_ADDRESS>, <IP_ADDRESS>\n  User-Agent: Go-http-client/1.1\n  X-Request-Id: e1ab22ed-2235-4e76-9423-ddcffaead355\n  X-B3-Sampled: 1\n\n--- Origin: '<IP_ADDRESS>:53498' ---\n--- Observer: 'sink-kvnevsuz' ---\n--- Time: 2023-05-02 08:55:00.367962994 +0000 UTC m=+23.086618826 ---\n--- Sequence: 0 ---\n--- Sent Id:  ' ---\n--------------------\n","commit":"c0e4ef7-dirty"}
{"level":"info","ts":"2023-05-02T08:55:00.398Z","logger":"eventshub.event logger","caller":"logger_vent/logger.go:26","msg":"Event: \n-- EventInfo --\n--- Kind: Sent ---\n--- Event ---\nContext Attributes,\n  specversion: 1.0\n  type: dev.knative.sources.ping\n  source: /apis/v1/namespaces/test-sopikrdd/pingsources/pingsource-gbzgetvy\n  id: 893ff8c6-085f-46b5-9b3a-06028e2d24f8\n  time: 2023-05-02T08:55:00.287604272Z\nExtensions,\n  knativearrivaltime: 2023-05-02T08:55:00.29040074Z\n\n--- HTTP headers ---\n  Ce-Knativearrivaltime: 2023-05-02T08:55:00.29040074Z\n  Ce-Id: 893ff8c6-085f-46b5-9b3a-06028e2d24f8\n  Ce-Specversion: 1.0\n  Ce-Type: dev.knative.sources.ping\n  Ce-Time: 2023-05-02T08:55:00.287604272Z\n  Ce-Source: /apis/v1/namespaces/test-sopikrdd/pingsources/pingsource-gbzgetvy\n\n--- Origin: 'sink-kvnevsuz' ---\n--- Observer: 'sink-kvnevsuz' ---\n--- Time: 2023-05-02 08:55:00.397931325 +0000 UTC m=+23.116587158 ---\n--- Sequence: 0 ---\n--- Sent Id:  '893ff8c6-085f-46b5-9b3a-06028e2d24f8 ---\n--------------------\n","commit":"c0e4ef7-dirty"}
{"level":"info","ts":"2023-05-02T08:55:00.398Z","logger":"eventshub.event logger","caller":"logger_vent/logger.go:26","msg":"Event: \n-- EventInfo --\n--- Kind: Response ---\n--- HTTP headers ---\n  Date: Tue, 02 May 2023 08:55:00 GMT\n  Content-Length: 0\n\n--- Body ---\n\n--- Status Code: 202 ---\n--- Origin: 'http://sink-kvnevsuz-rqrhixpu.test-sopikrdd.svc.cluster.local' ---\n--- Observer: 'sink-kvnevsuz' ---\n--- Time: 2023-05-02 08:55:00.398066529 +0000 UTC m=+23.116722360 ---\n--- Sequence: 0 ---\n--- Sent Id:  '893ff8c6-085f-46b5-9b3a-06028e2d24f8 ---\n--------------------\n","commit":"c0e4ef7-dirty"}

The forwarder also work with Tracing, this is a screenshot from Zipkin for an event that was sent in a test:

Note: The Zipkin traces end at the Knative Service and don't continue further to eventshub Service. I will investigate this.

Fixed the traces with the latest commit:

/cherry-pick release-1.10


cdxgen crash when scala project isn't at repository root dir

cdxgen crach when analyse a scala repository where the project dir isn't at the root directory. The following directory structure can be used to reproduce the bug.
/git/test/
└── src
    └── scala
        ├── build.sbt
        ├── project
        │   ├── build.properties

This is happening because determineSbtVersion() function is being called against the root dir here and it can't find the build.properties file. cdxgen crash with the following error:
Scanning /git/test/
Detected sbt version: null
/opt/node/lib/node_modules/@cyclonedx/cdxgen/node_modules/semver/classes/semver.js:19
      throw new TypeError(`Invalid version. Must be a string. Got type "${typeof version}".`)

With this PR if cdxgen can't detect sbt version at the root of repository being analysed it will loop over sbtProjects array trying to find a valid build.properties file.

I found an use case where this PR fails: when there are nested project directories and one build.properties does reference data on another. So I have to improve this fix.

I've rewrite the patch. I think it is ok now.

Could you run npm run pretty?


Mandatory change in licensing and legal documentation

Description
Due to a change in how we want to license Eclipse Tractus-X, there are a couple of changes
to legal documentation in our repositories.
This issue is created for every active repository in our GitHub org, to remind everyone
about the required changes and also to track the completion of if.
If there are any reasons, why you think this change should not be applied to this repository,
document them as comment on this issue, before closing it. Be aware, that there are most likely no
exceptions for our repositories.
If you have any questions, feel free to join the weekly Community Office Hour
and raise it there.
What has to be done?
The following steps have to be completed, to fully implement the licensing change:

[ ] Add a new file LICENSE_non-code in your repository root with the contents of the CC-BY-4.0 license
[ ] Remove the /LICENSES directory in case you previously stored the CC-BY-4.0 license there. Make sure there is no other CC-BY-4.0 License left, other than on root as LICENSE_non-code
[ ] Add the "Project Licenses" and "Terms of Use" sections to your CONTRIBUTING.md file. See eclipse-tractusx/sig-infra#476 for an example
[ ] Adapt "Declared Project License" section in NOTICE.md. See eclipse-tractusx/sig-infra#476 for an example
[ ] Please verify, your CONTRIBUTION.md does not have encoding issues. We found several occurences in repositories.

Additional information
You can find detailed information in our Release Guidelines section 7.
The changes have been introduces in eclipse-tractusx/eclipse-tractusx.github.io#856.
You can also see an example on how a repository was changed in eclipse-tractusx/sig-infra#476.
Overall progress tracked in eclipse-tractusx/sig-infra#477

Closing as PR is merged.
@agg3fe  - FYI: a PR will only close a linked issue if it is preceeded by a keyword such as "closes" as outlined here

Closing as PR is merged. @agg3fe - FYI: a PR will only close a linked issue if it is preceeded by a keyword such as "closes" as outlined here

Hi @arnoweiss , Thanks for your comments. Yes I know that and it was done intentionally, because I wanted to close them manually after a final check :)
But anyhow, thanks for closing the issues.


Open Issues asking users to test pyhf v0.7.0 release candidates

Opened:

https://github.com/Daniel-Noel/hep-fitting-scripts/issues/1
https://github.com/Rupt/interval-evidence/issues/1 (doesn't want to receive future updates)
https://gitlab.cern.ch/rles/pyfittools/-/issues/1
https://gitlab.cern.ch/ekourlit/pyfits/-/issues/1
https://github.com/SModelS/smodels/issues/22
https://github.com/MadAnalysis/madanalysis5/issues/130

cabinetry is already testing the release candidates.
https://gitlab.cern.ch/atlas/StatAnalysis is unlikely to test and doesn't seem super dependent on the pyhf API at this point.
LCG views won't test release candidates.

Note that https://github.com/Rupt/interval-evidence doesn't want to receive updates in the future: https://github.com/Rupt/interval-evidence/issues/1#issuecomment-1252668662

Thanks to some very thoughtful feedback from @alexander-held I've now amended the text

This Issue is meant to be helpful to avoid unexpected breaks of your code, but if you find this intrusive or annoying please let us know and we won't bother you again.

to the Issues. Apologies in advance to everyone who found these Issues intrusive or demanding!


Develop Data Needed DN_0036_150_dns_server_could_not_load_dll

Develop Data Needed DN_0036_150_dns_server_could_not_load_dll (Event ID 150) using this template and related Logging Polic (if there is any) using this template.

it will be renamed to DN_0108_150_dns_server_could_not_load_dll

done


Sugar doesn't seem to be saving entries on all devices

I'm having an issue with Sugar ORM. First off, it works great on my device and many other devices. However I'm seeing crash logs from my users that indicate it isn't saving entries on all devices. Here is the class I am saving to the database:
public class Alarm extends SugarRecord {
@Unique
public int requestCode;
public int hour;
public int minute;
public int repeatDays;
public int status;
public int snooze;
public float volume;
public String song = Settings.EMPTY_MODULE;
public String name = Settings.EMPTY_MODULE;
public long millis;

public Alarm(){}

public Alarm(int requestCode, int hour, int minute, int repeatDays, int status,
             int snooze, float volume, String song, String name, long millis) {
    this.requestCode = requestCode;
    this.hour = hour;
    this.minute = minute;
    this.repeatDays = repeatDays;
    this.status = status;
    this.snooze = snooze;
    this.volume = volume;
    this.song = song;
    this.name = name;
    this.millis = millis;
    }
}

Here is how I save it:
Alarm addAlarmSql(int requestCode, int hour, int minute, int repeatDays, long millis, int snooze,
float volume, String name, String song) {
Alarm alarm = new Alarm(requestCode, hour, minute, repeatDays,
AlarmStatus.ALARM_ON.value, snooze, volume, song, name, millis);
alarm.save();
return alarm;
}
Like I said, it seems to work great on most devices including my own. However the following call returns null for some users:
            Alarm alarm = Select.from(Alarm.class).where(Condition.prop("request_code").eq(requestCode)).first();
For completion, here is the Sugar initialization in my Application onCreate:
            SugarContext.init(getApplicationContext());
And here are the lines related to it in my manifest:
    <meta-data android:name="DATABASE" android:value="*********.db" />         <meta-data android:name="VERSION" android:value="2" />         <meta-data android:name="QUERY_LOG" android:value="true" />         <meta-data android:name="DOMAIN_PACKAGE_NAME" android:value="com.*********.*************.*********.schema" />
And my application extends SugarApp. So I'm fairly certain I've set it up correctly. One might simply say my issue is that my requestCode sent to that call is wrong and therefore Sugar can't find any entries. That's fair. I'm also searching my code to find if there's any way the requestCode is changed or perhaps the wrong value is sent. So far I haven't found anything like that. That aside, does anyone think the issue could be elsewhere?

@sadelbrid I'm not able to use the Unique annotation in any of my models. It says it don't exist. How are you able to make it work on your end.


Update PR template to encourage prose, detail, rational.

What changes are in this PR? Why did you implement them this way?
This PR adjusts the PR template to move away from a "checklist-only" description by

Adding a few prose prompts
Adding a prompt for bug reproduction
Reducing the length of the checklist and splitting it into 2 parts
Asking PR author to remove the checklists to reduce noise

We want to upgrade our PR descriptions from "a list of things the code does" to more of a first class representative of the changes taking place in the PR.
Longer descriptions with the rationale and process included encourages deeper thinking. Writing them typically helps bubble up additional concerns that might otherwise not come up until code review. It also communicates more context to the reviewer.
Was anything tried that didn't work? Is there anything reviewers need to pay attention to? Anything difficult or tricky that should be explained?
I looked into how we could create 2 different templates: bug and feature — that looks possible, but you can only actually switch between them by passing the template url variable and not via the UI (this is possible with issue templates, however). So for now I included the prose prompt for bug reproduction up top and it will have to be manually deleted when not applicable to the PR.
Another open issue is "noise" — for example, on this PR, almost none of the checklist is relevant. The "bug reproduction" prompt is also not relevant. To increase readability, I'd like to manually curate what is put in the PR description vs. including it all by default.
Another concern is part of the checklist should actually happen after every commit (tests/percy/etc). It's somewhat confusing to see PRs with ✅ that tests passed, and then a red X on the actual tests. We should let the tests/percy/etc speak for themselves and have the checklist be a "reminder" that gets removed when a PR is opened.

What do you think about adding something related to an Issue a PR might be fixing? @sudara, you often put a lot of thought in writing up the issue and its proposed solution. Feels like we should utilize it somehow.
Should we:

just link the issue and expect the reviewers to read it
briefly summarize the issue and the root cause/solution inside the PR description
copy/paste pieces from the issue.

My preference is that we don't have to leave the PR to get full context. If the PR closes out an issue, that should be listed first/last in the description.
In most cases, after the work has happened (PR) there's a different perspective than before happens (issue). The scope shifts, new things bubble up, some things are reprioritized, etc.
I like to use issues as "source material" and listing out work before the it happens — they are  useful to refer to/crib from, but don't replace framing what actually happened (and why) in a PR.


ISPN-16194 Change index writer queue config

https://issues.redhat.com/browse/ISPN-16194
~Based on https://github.com/infinispan/infinispan/pull/12503, that should be merged first!~ done we can merge it!
I also added the documentation.

@yrodiere I don't know if you can have a look at it

Thanks!


18307130031

You are not supposed to submit insert_data.sql, because it is not required.

Try remove the file and commit again, then just push it to your origin, the change will automatically appear here, let me know if you have any questions.


Process all closed uTP streams in UtpListener and handle the payload in overlay service

What was wrong?
UtpListener runs as a self-contained service in the background and handles all active uTP streams.
We need a way to process all closed uTP streams and pass the payload to the overlay service, so we can verify, store and propagate gossip/POKE the received content via uTP.
Subtask of https://github.com/ethereum/trin/issues/313.
How was it fixed?
1, Refactor the way we are storing the received payload (DATA packets) in the uTP socket.
2. Add a new ProcessClosedStreams UtpListener request and invoke this request at a set of intervals in the overlay service loop.
3. On this request, UtpListener process all closed uTP streams and send the received payload back to the overlay service.
4. Remove process_utp_byte_stream() dead code.
5. Add RawContentKey type.
Manually tested with Fluffy.
To-Do

[ ] 1. Add protocol id when creating uTP socket.
[ ] 2. Add UtpSocket <-> UtpListener event channel and emit an event upon uTP socket closing.
[ ] 3. Emit global UtpListener event with uTP payload, stream id, and protocol id on closed uTP socket.
[ ] 4. Add uTP listener event handler to dispatch the global event to the specific overlay networks.
[ ] 5. Listen and handle dispatched events in the overlay layer.

[ ] Add entry to the release notes (may forgo for trivial changes)
[ ] Clean up commit history

The approach I would suggest is similar to the way Discv5 emits Discv5Event to a channel that we can stream. Upon socket close, UtpListener can emit some message to a channel where the message contains the socket info and any data that the socket received. OverlayService can listen to this channel to handle those messages.

Yeah, this seems a more robust way to handle the closed streams.
However, this will require an event channel per network because if we emit a global overlay event, then only one of the overlay networks will consume it because we will run multiple overlay protocols.
Also, the connection state is closed inside UtpSocket and I think at least for now, we will still need to process all active sockets in a set time interval in UtpListener to check which one is closed and then emit the event. Another alternative is to add event channels between UtpSocket and UtpListener but this will bring more complexity.
One major issue I realized today is that now UtpListener doesn't recognize which stream for which network is related and we can't emit specific events for a specific network.
I will try to refactor a bit and first store all active uTP connections in UtpListener in a separate HashMap per network and then try to pass state and history event receivers to the OverlayService struct and emit an event when a connection is closed (after UtpListener process all active connections to check which one is closed).
As we are using the same OverlayService struct for every network, probably I should pass those event receivers as Option<UnboundedReceiver<...>>, because we may not always want to run all the networks, do you have any better idea?
Let me know what you think and if this makes sense to you!

Good, I updated the PR description with some TODOs and will re-open it for review when all of them are done.


[stable/stolon] Use custome names for stolon keeper in different namespace

What this PR does / why we need it:
Which issue this PR fixes

It help to create different UIDs for stolon keepers when you create two stolon clusters on one backend storage

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

/retest

@cpanato It's ready to approve

/lgtm


2F - Workflow metadata and plan

When I am a newcomer to BugFlow
Then I want to create a new workflow
So we need a new template for adding workflows to BugFlow.
These workflows need to have the proper metadata.
Essential information and plan for adding institutional workflows to GitHub

Each workflow added to the repository requires certain metadata for submission:

Title (what is this workflow?)
Authorship
Copyright/License information
Institution
Date Created
Date last modified
keywords
Database being used
Link to a pdf file

2 options for submission:

Create new workflow using markdown
Upload pdf file, with license information

Created new Issue Template here: https://github.com/EntCollNet/BugFlow/blob/master/.github/ISSUE_TEMPLATE/Add-Your-Workflow.md Closing with 7339fea


fix(create-append-anything): element connection via dragstart

Follow up from https://github.com/bpmn-io/bpmn-js/pull/1843

Good stuff :tada:


Virtual Machine Scale Set to forward syslog to Microsoft Sentinel using AMA

Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

@sreedharande thanks, I updated it.

@sreedharande, can you please check and approve, thanks.

@sreedharande, can you please have a look on the changes, thanks.

@sreedharande, can you please check and approve, thanks.

@sreedharande, can you please have a look into this?

Hey @sreedharande, any updates?


Update Google+ logo

See more: https://developers.google.com/+/branding-guidelines

/cc @xnutsive

Wow. So thank you, much awesome, very gratitude.
On Sat, Oct 3, 2015 at 3:59 AM Roman Shamin<EMAIL_ADDRESS>wrote:

/cc @xnutsive https://github.com/xnutsive
[image: em-emoji-tbi 2x]
https://cloud.githubusercontent.com/assets/1148914/10262585/ef881514-69d6-11e5-9d2a-5a2d7d7ccfe4.png
—
Reply to this email directly or view it on GitHub
https://github.com/outpunk/evil-icons/issues/70#issuecomment-145236760.


Changes to Production DB for the next release -MZ

Project_Main_VW_Unchanged
Added project manager information (first, last, email, phone)

Delete Submit_OnTime field from Project_Main table


Fix wrong bit count in comment.

Previous PRs mean the address can now be the full 16bit, but this comment wasn't updated.

bors r+


Enhance the "List" endpoint to support query by different attributes

As a promotion manager
I need to query Promotions by type, start_date, status, product_id  of the Promotion
So that group promotions easily
Details and Assumptions

Add different functions for querying Promotions by type, start_date and product_id of the Promotion
Add query capability to the model
Add query string support to the List function

Acceptance Criteria
Given type
When calling List with the type
Then shows all promotions of this type

Given start_date
When calling List with start_date
Then shows all promotions starting on this date

Given product_id
When calling List with a  product_id
Then shows all promotions related with this product

After some research I removed status from the story since for that query we need to either

have a db column dedicated for status.
use the sqlalchemy native datetime representation.

Since we don't have the field and we are using python datetime for start date and duration, the filter wouldn't be able to calculate active/expired status from the two fields.


inline warnings

Currently there are a lot of warnings like this
WARNING AS224: TODO: Cannot inline inferred calls and specific internals yet.

         it >>= shift;
         ~~~~~~~~~~~~
 in assembly/integer/u256.ts(515,8)

when I build the project. It seems that this happens only with the new runtime. It would be nice if we can fix it.

yeah, currently new runtime little bit more verbose with inlined operators.
@dcodeIO is it possible reduce this warnings?

It would be good to know what causes these warnings.

At some occasions, if the arguments to a call have already been compiled prior to compiling the call itself, which happens for example if a binary operation is being compiled and an overload found later based on the type that resulted from compiling the binary operands, converting the call into an inlined block can lead to situations where locals used inside of the previously compiled arguments will conflict with locals introduced in the inlined block. Since runtime has been merged, there is some utility to potentially remedy local conflicts, but this hasn't yet been attempted in some cases, hence the old warnings are still in place.

Fixed


Build error using Gulp: Unexpected token

When I try to use your Angular library in our project we get an error using it. During concatenation and minification, gulp-uglify throws following error:

Error (gulp-uglify): [...]/frontend/vendor/angular/angular-cache/angular-cache.js: Unexpected token: operator (<)

Do you have an idea what is wrong?

How about you share your gulp config? And show how you're using angular-cache in your code?

This is our complete gulp config file: https://github.com/HelloLily/hellolily/blob/develop/gulpfile.js
I think this is the relevant part (line 224):
gulp.task('vendor-js', [], function() {
    return gulp.src(config.vendor.js.src)
        .pipe(ifElse(!isProduction, function() {
            return sourcemaps.init();
        }))

        .pipe(cached('vendor-js'))
        .pipe(ifElse(isProduction, uglify))
        .pipe(remember('vendor-js'))

        .pipe(concat(config.vendor.js.fileName))
        .pipe(ifElse(!isProduction, function() {
            return sourcemaps.write('.');
        }))
        .pipe(gulp.dest(config.vendor.buildDir))
        .pipe(ifElse(isWatcher, size))
        .pipe(ifElse(isWatcher, livereload));
});

with config.vendor.js.src (line 75) being:
    vendor: {
        buildDir: 'lily/static/vendor/',
        js: {
            src: [
                'frontend/vendor/**/*jquery.min.js',
                'frontend/vendor/**/*angular.js',
                'frontend/vendor/**/*.js',
                '!frontend/vendor/**/angular-mocks.js',
                '!frontend/vendor/metronic/assets/global/plugins/ie-fixes/**/*.js',  // IE fixes
            ],

The angular-cache.js file is placed frontend/vendor/angular/angular-cache/
The gulp-uglify error is given when issuing the (our) gulp build command, so actually before even using you library in code.

And what's the exact angular-cache.js file you're using? Where did you get it?

I got it from https://github.com/jmdobry/angular-cache/tree/master/dist , stable version 4.5.0.
But I now see I made a mistake (and never gonna make again...), right clicking the link saves a html file named .js instead of the raw js file. So I got the wrong file, sorry for the inconvenience.


Fabric CLI tools should install Spark for local mode

Currently, we assume Spark is just available.  But in local mode (e.g., on a jenkins slave), this is certainly not true.  This should be baked into the eggo tools for local mode.

Closing for cleanup/refactor.


NuGet pack Include Referenced Projects can only be set when versioning scheme is Off

Environment
TFS 2018 Update 2
Private build agent 2.133.3 running on Windows Server 2012 R2
Issue Description
With the NuGet task, when using the pack command, you can only set the Include Referenced Projects option if the versioning schema is set to Off. However, setting that option first and then changing the versioning schema works just fine, and you can see in the build definition that the flag is indeed set and the flag is passed to NuGet when the build is run, so this seems to be a UI glitch. Also, the implementation of the task doesn't seem to care about the versioning scheme when checking the includeReferencedProjects flag.
Is there a particular reason that the option is only visible when versioningScheme is set to off as can be seen in the screenshots below?

Hello! I'm a PM over on the Azure Artifacts team. I wanted to drop in here and address some of these issues with the news that we're currently reevaluating the types of tasks we offer in Azure Pipelines, and looking to focus more on lighter-weight tasks that cover authentication and setup. In lieu of the task redesign, we're going to forego making changes to the current tasks (with a few exceptions). We hope the new tasks we spin up in the next quarter or so are easier and more helpful, be on the lookout!


Add Pipeline Witness categorization for failed cache steps

There are at least two failures on MacOS DevOps agents coming from the Vcpkg Cache step. We should track these failures in our system to understand how widespread it is.
Failure message:
##[error]The HTTP request timed out after 00:00:30.

Known failures:

https://dev.azure.com/azure-sdk/public/_build/results?buildId=486522&view=logs&j=458eebdd-b8c0-53fa-652f-fe4233aa7246&t=a49668b7-66ea-5f36-4791-f26a292d6dcc&s=ff05ad62-bb9a-53b6-ce9f-72f329a63e7c
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=482895&view=logs&j=4bef5d43-441c-5b11-9e73-e199bb3c37eb&t=d12f0e06-61f0-5a39-48b7-764a4fee902c

Example classifier: https://github.com/Azure/azure-sdk-tools/blob/master/tools/pipeline-witness/Azure.Sdk.Tools.PipelineWitness/Services/FailureAnalysis/PythonPipelineTestFailureClassifier.cs

This is showing up a few times a month.  It affects our CI metrics and may create a false impression on code quality.
@mitchdenny is this appearing in your reports?

Looking at the failures, it looks like it is a 30 second timeout, and successful runs are coming up close to that. So it might be just a case of increasing the timeout to 1 minute to cover slower than average cache fetch times that are likely to occur from time to time?

Take a look at the PR I just linked. It is still failing after I increase the timeout to 1 minute. But look at the cache size it is restoring - that seems pretty large for such a tight library.

I'm not seeing any issues anymore.


istio.io blog post about sail-operator

With the official deprecation of the istio operator on 1.23 Istio  I'll start a first blogpost for istio.io to get some visibility taking advantage to the official announce of deprecation. This was discussed by the team and the idea is to create a first blogpost that give a description of the operator and points to the user documentation recently updated in the repo

Blogpost published: https://istio.io/latest/blog/2024/introducing-sail-operator/


datapath: require FnGetSocketCookie

This helper was added with kernel 4.12, while we already have 5.4 as minimum version. Just require that it's available, and remove the fallback logic.

/test


Type conversion operators

Why there are no operator int(), operator std::string(), operator bool() and others in Json class?

Certainly I can see operator bool() being confusing/ambiguous.

There is possibility to declare these operators explicit.

There's no operator bool because there's no obvious meaning for it. Javascript's semantics for truthiness are somewhat subtle (e.g. an empty string evaluates as false, but an empty array evaluates as true) and that's often a source of confusion. Being more explicit with is_null(), bool_value(), etc. makes code easier to read and write.

Er, replace "no obvious meaning" with "too many possible meanings" in the above

But what about other operators (operator int(), operator std::string() etc)?


[enhancement] Add a portable version for Windows

Actually, there isn't a Windows portable version, yet.
Please, add a portable version: I'd like to test the app features but without installing it.

@Bellisario Done, please check the v.2.1.1 release 😀

@Bellisario Done, please check the v.2.1.1 release 😀

Ok, thank you @daltonmenezes!

Ok, thank you @daltonmenezes!


[WIP] Feature/static code security scanner

Proposed changes

gosec is a static code analysis tool that scans for known security vulnerabilities. This PR adds gosec to the pipeline and fixes some issues raised by the tool.
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactor (changes to code, which do not change application behavior)

Checklist

[x] I have filled out this PR template
[x] I have read the CONTRIBUTING doc
[ ] I have added automated tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (README.md, inline comments, etc.)
[ ] I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

Further comments

Example of gosec working in our pipeline


fix(extension): escape special chars

Description

Webview displayed a white screen if the json schema contained a single quote or special characters like \n (new line).

@DaAnda97 I have revised it a bit. Can you please test it again.


org.gradle.internal.classpath.Instrumented not found when using System.getProperties() in a Gradle Plugin

Expected Behavior
No errors when building a project that uses a Kotlin Compiler Plugin during compilation.
That Kotlin Compiler Plugin is provided to the compilation via a custom Gradle Plugin.
It has been working since Gradle 5.0until Gradle 6.5.1 (included).
Current Behavior
$./gradlew clean build

> Task :compileKotlin FAILED
e: java.lang.NoClassDefFoundError: org/gradle/internal/classpath/Instrumented
  at arrow.meta.internal.registry.InternalRegistry$DefaultImpls.registerMetaComponents(InternalRegistry.kt:150)

InternalRegistry.kt comes from the Kotlin Compiler Plugin and the content of that line is:
println("System.properties are: " + System.getProperties().map {

Context
It works until Gradle 6.5.1 (included).
It fails with Gradle 6.6, Gradle 6.6.1 or Gradle 6.7-rc-3.
It impacts on environments with latest Gradle versions that try the examples of the Kotlin Compiler Plugin.
The error has been reported by a user in Kotlin Lang Slack - #arrow-meta channel.
We didn't realize about it because the example is using Gradle 5.6.4 and the first Gradle version was 5.0.
Steps to Reproduce
With Gradle 6.6, Gradle 6.6.1 or Gradle 6.7-rc-3, run:
git clone https://github.com/arrow-kt/arrow-meta-examples.git
cd use-arrow-meta-compiler-plugin
gradle clean build

Your Environment
Build scan URL: https://scans.gradle.com/s/doy7eoh223nlc

The error comes from the custom Gradle Plugin that provides the Kotlin Compiler Plugin.
No errors when providing the Kotlin Compiler Plugin manually via compileKotlin.kotlinOptions.freeCompilerArgs without the custom Gradle Plugin.

I've updated the title:

org.gradle.internal.classpath.Instrumented not found when using System.getProperties() in a Gradle Plugin

Hey @eskatos, could you take a look? That seems linked to the configuration cache work.

Thank you so much @ljacomet :raised_hands:

Another example: https://github.com/trustin/sphinx-gradle-plugin/issues/19

We have the same problem. grade Plugin in groovy invokes java lib. java11:
Exception in thread "main" java.lang.NoClassDefFoundError: org/gradle/internal/classpath/Instrumented
at org.apache.velocity.util.ExtProperties$1.run(ExtProperties.java:187)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at org.apache.velocity.util.ExtProperties.(ExtProperties.java:182)
at org.apache.velocity.runtime.RuntimeInstance.(RuntimeInstance.java:170)
at org.apache.velocity.app.VelocityEngine.(VelocityEngine.java:55)
at net.masterthought.cucumber.generators.AbstractPage.(AbstractPage.java:39)
at net.masterthought.cucumber.generators.ErrorPage.(ErrorPage.java:18)
at net.masterthought.cucumber.ReportBuilder.generateErrorPage(ReportBuilder.java:229)
at net.masterthought.cucumber.ReportBuilder.generateReports(ReportBuilder.java:109)
at org.foo.bar.gradle.plugin.ReportGenerator.generateCompleteReport(ReportGenerator.java:42)
Caused by: java.lang.ClassNotFoundException: org.gradle.internal.classpath.Instrumented
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)

I've following exception on 6.7:
java.lang.NoClassDefFoundError: org/gradle/internal/classpath/Instrumented
at org.codehaus.groovy.reflection.GroovyClassValueFactory.(GroovyClassValueFactory.java:32)
at org.codehaus.groovy.reflection.ClassInfo.(ClassInfo.java:109)
at org.codehaus.groovy.reflection.ReflectionCache.getCachedClass(ReflectionCache.java:110)
at org.codehaus.groovy.reflection.ReflectionCache.(ReflectionCache.java:55)
at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.registerMethods(MetaClassRegistryImpl.java:214)
at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:112)
at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:90)
at groovy.lang.GroovySystem.(GroovySystem.java:36)
at org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:82)
at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.createMap(ScriptBytecodeAdapter.java:636)

Is there a chance to have it fixed in of next release?

This one is a blocker for us. :disappointed:
Is there a work around for this issue ?
We are currently using gradle 6.5.1 and running into https://github.com/gradle/gradle/issues/14168 while using latest protobuf. That issue fix is part of 6.7 and we can not upgrade because of this issue.
For us the exception is thrown while one of the custom plugin trying to use ClassLoader.getSystemClassLoader()
Exception for reference:
Exception in thread "main" java.lang.NoClassDefFoundError: org/gradle/internal/classpath/Instrumented
        at com.abcd.gradle.plugins.SomePlugin.$instrumentedCallSiteArray(SomePlugin.groovy)
        at com.abcd.gradle.plugins.SomePlugin.$getCallSiteArray(SomePlugin.groovy)
        at com.abcd.gradle.plugins.SomePlugin.<clinit>(SomePlugin.groovy:15)
        at com.abcd.SomeClass.finalizeBody(SomeClass.java:262)
        at com.abcd.SomeClass.getBody(SomeClass.java:184)
        at com.abcd.SomeClass.generateMultiplePageHtml(SomeClass.java:225)
        at com.abcd.SomeClass.generateHtmlFromMarkdownSources(SomeClass.java:132)
        at com.abcd.SomeClass.generate(SomeClass.java:91)
        at com.abcd.SomeClass.main(SomeClass.java:79)
Caused by: java.lang.ClassNotFoundException: org.gradle.internal.classpath.Instrumented
        at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
        ... 9 more

I've also encountered this when updating the build scripts in Buildship to 6.8-rc-1. You can reproduce it with my feature branch: just execute ./gradlew installTargetPlatform.
The stacktrace points to org.apache.maven.artifact.ant.AbstractArtifactTask.initSettings().
Caused by: java.lang.NoClassDefFoundError: org/gradle/internal/classpath/Instrumented
        at org.apache.maven.artifact.ant.AbstractArtifactTask.initSettings(AbstractArtifactTask.java:237)
        at org.apache.maven.artifact.ant.AbstractArtifactTask.execute(AbstractArtifactTask.java:750)
        at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
        ... 149 more
Caused by: java.lang.ClassNotFoundException: org.gradle.internal.classpath.Instrumented
        at org.apache.tools.ant.AntClassLoader.findClassInComponents(AntClassLoader.java:1383)
        at org.apache.tools.ant.AntClassLoader.findClass(AntClassLoader.java:1338)
        at org.apache.tools.ant.AntClassLoader.loadClass(AntClassLoader.java:1093)
        ... 156 more

AbstractArtifactTask.java:237 does try to call System.getProperty("user.home").

Here another instance that is probably related:
https://github.com/ph4r05/javacard-gradle-plugin/issues/7
There the Gradle plugin uses a dirty code source location lookup trick to get a JAR from the current class path and then adds this jar to the class path of a JavaExec task (sub class) that then fails at runtime due to the missing instrumentation class.
I cannot see from the posted examples whether the other cases are the same, but I guess that it is at least similar, that the plugins use the build script class path for other things and then the instrumentation fails.
In my case it was easy to solve, I just removed the bad jar from those class paths, as the jar was added to it in a different way anyway, so the lookup and adding was totally unnecessary.
Maybe the instrumentation could be enhanced in a way so that it works within Gradle context and without, so for example checking whether the class Instrumented is present, if yes, then use the instrumented code, if not then use the original code.

Here another instance that is probably related:
https://github.com/ph4r05/javacard-gradle-plugin/issues/7
There the Gradle plugin uses a dirty code source location lookup trick to get a JAR from the current class path and then adds this jar to the class path of a JavaExec task (sub class) that then fails at runtime due to the missing instrumentation class.
I cannot see from the posted examples whether the other cases are the same, but I guess that it is at least similar, that the plugins use the build script class path for other things and then the instrumentation fails.
In my case it was easy to solve, I just removed the bad jar from those class paths, as the jar was added to it in a different way anyway, so the lookup and adding was totally unnecessary.
Maybe the instrumentation could be enhanced in a way so that it works within Gradle context and without, so for example checking whether the class Instrumented is present, if yes, then use the instrumented code, if not then use the original code.

There the Gradle plugin uses a dirty code source location lookup trick to get a JAR from the current class path and then adds
this jar to the class path of a JavaExec task (sub class) that then fails at runtime due to the missing instrumentation class.

@Vampire It seems that I have the same problem but with this exception that I cannot remove those additional jars from classpath (i.e. my Plugin is running JavaExec to scan classes/resources available on build classpath). So unfortunately I cannot use your workaround.
I'm blocked with old version of Gradle now for over half a year :(

There the Gradle plugin uses a dirty code source location lookup trick to get a JAR from the current class path and then adds
this jar to the class path of a JavaExec task (sub class) that then fails at runtime due to the missing instrumentation class.

@Vampire It seems that I have the same problem but with this exception that I cannot remove those additional jars from classpath (i.e. my Plugin is running JavaExec to scan classes/resources available on build classpath). So unfortunately I cannot use your workaround.
I'm blocked with old version of Gradle now for over half a year :(

Well, another work-around would probably be to either add the jar with the needed class to the class path too, or have a dummy implementation of the instrumentation class.

Well, another work-around would probably be to either add the jar with the needed class to the class path too, or have a dummy implementation of the instrumentation class.

It would be good to know the timeline when such a blocker/critical issue will be addressed. Without that it feels a bit constrained with sticking to old release.

It would be good to know the timeline when such a blocker/critical issue will be addressed. Without that it feels a bit constrained with sticking to old release.

Can we disable instrumentation or make it optional for certain dependencies? I think the solution suggested by @Vampire will work as well.

Can confirm that this bug is still there on version 6.7.1

Can confirm this issue persists in 6.8.x as well.

I've just tested on 6.8.3 - problem still occurs.

Update: it also happens with latest 7.0.

Hope someone from gradle team listening :pray:
Sincerely request for any thoughts on when this can be fixed. Thanks in advance.

The error comes from the custom Gradle Plugin that provides the Kotlin Compiler Plugin.
No errors when providing the Kotlin Compiler Plugin manually via compileKotlin.kotlinOptions.freeCompilerArgs without the custom Gradle Plugin.

rachelcarmena,
Can you kindly show configuration example for this opiton?

Can you kindly show configuration example for this opiton?

Of course:

Where the Gradle Plugin provides the Kotlin Compiler Plugin: https://github.com/arrow-kt/arrow-meta/blob/main/gradle-plugin-commons/src/main/kotlin/arrow/meta/plugin/gradle/ArrowMetaGradlePlugin.kt#L30

When providing the Kotlin Compiler Plugin manually via compileKotlin.kotlinOptions.freeCompilerArgs without the custom Gradle Plugin: https://github.com/arrow-kt/arrow-meta-examples/blob/main/generate-sources/use-plugin/build.gradle#L28

However, the use of the Kotlin Compiler Plugin is not relevant for this issue. I mean, I would like to say that the error came from the Gradle Plugin:

Adding some configuration things directly in a Gradle file: :heavy_check_mark:
Embedding that configuration in a Gradle Plugin: :red_circle:

Fortunately, we could remove the use of System.getProperties() to progress (they weren't essential to make the plugin work but to show debug info).
I hope we can recover that additional feature some day :pray:

Thank you very much!
Hope, this will be helpful to someone else.

We have experienced this problem with custom gradle tasks in this project: https://github.com/opencaesar/owl-tools
The only recourse we have at this time is to stick to Gradle 6.5.1

Thanks for sharing your issue @NicolasRouquette :raised_hands:  I think it's the first reported case here about a Gradle Task Type.
It seems something related to classes management changed from Gradle 6.5.1 that makes the use of custom Gradle Plugins or custom Gradle Task Types fail when calling ClassLoader.getSystemClassLoader() (your case as well as other cases reported in this thread) or System.getProperties().
I hope these clues are useful to the Gradle Team :pray:

Why clues? ANd why first reproted case?
It is the exact same problem.
It is exactly clear why it is happening.
And I also reported this happened in a 3rd party task.
That plugin - at least that's how @NicolasRouquette described it - looks in its own classpath for a certain jar and then uses it outside the build script runtime classpath and that simply is not supported currently.
That plugin could easily do it properly and so make itself compatible with newer Gradle versions just like the plugin I mentioned did.
But noone opened an issue in their tracker yet to tell them that their plugin is not compatible.

Frankly, i am not even sure why there is no workaround provided so far. Let alone fixing it. Bit disappointing actually :(

That plugin - at least that's how @NicolasRouquette described it - looks in its own classpath for a certain jar and then uses it outside the build script runtime classpath and that simply is not supported currently.

Is this limitation documented somewhere?

That plugin could easily do it properly and so make itself compatible with newer Gradle versions just like the plugin I mentioned did.

@Vampire Can you recommend either a documentation or an example for a proper class lookup technique?

Frankly, i am not even sure why there is no workaround provided so far. Let alone fixing it. Bit disappointing actually :(

Well, there is a "work-around" or actually fix, namely don't try to use jars from the build script class path outside the build script class path, but instead use detached configurations to declare and resolve the libraries you need, then you also automatically get the transitive dependencies. It is just bad practice to search for a jar in the current class path and then build a new class loader from it. This also is a bit fragile as the class loader could anytime be changed and not use files on disk to load classes from but dynamically generate them, network-load them or whatever. If you get struck by this issue, then the part that causes it like the owl-tools plugin is following bad practice which just now stopped working as there were internal changes.
While it could probably be made in Gradle so that it would still work, the actual bug is in the unclean plugins using jars from the build script class path and there the bugs should be fixed, even if this concrete breakage gets worked-around within Gradle code as there could as well be future changes breaking this again.

Is this limitation documented somewhere?

I don't know of any documentation, but as I just described in this comment again, it is bad practice that works with specific Gradle versions as it uses internal knowledge on how the class loading is currently (or better was up to now) implemented and thus uses tight-coupling which should be avoided. Those plugins are simply not compatible with newer Gradle versions (unless this gets worked-around within Gradle) due to this tight coupling. The point is not, that this limitation is not documented. The point is, that the plugins doing such actions rely on internal behaviour that is not documented and not part of the API and thus can change anytime and thus break. which is why tight-coupling is most often a bad idea.

@Vampire Can you recommend either a documentation or an example for a proper class lookup technique?

I just described it earlier in this comment one way and you could also look at the commit where the plugin I mentioned here earlier fixed it in a different way to become compatible with newer Gradle versions again.
Basically you can either create a detached configuration, declare your dependencies on it and resolve it, or the more flexible and user-friendly approach that works even if coordinates change and similar is to create a normal configuarion, and add the needed libs as default dependenices, then the user of the plugin has the possibility to declare different dependencies even if the coordinates changed.

@ljacomet @eskatos Could you guys give us an update on this issue? It really hampers our workflow.

Going over this issue, I am afraid the answer will be to not try to load transformed buildscript dependencies outside of a Gradle execution context.
Instead you should use proper dependency management to pull in what you need.
@eskatos Anything to add?

Hi @Vampire,
Could you please elaborate on this?

Basically you can either create a detached configuration, declare your dependencies on it and resolve it, or the more flexible and user-friendly approach that works even if coordinates change and similar is to create a normal configuration, and add the needed libs as default dependencies, then the user of the plugin has the possibility to declare different dependencies even if the coordinates changed.

We have our own custom plugin for internal usage by the teams. We have the following code where the line with the System.getProperty is throwing the exception mentioned in the issue.
private static List<URL> getAllClassPath(ClassLoader loader) {
    if (loader instanceof URLClassLoader) {
        return ImmutableList.
                <URL>builder().
                add(((URLClassLoader) loader).getURLs()).
                addAll(getAllClassPath(loader.getParent())).
                build();
    } else {
        return ImmutableList.
                copyOf(System.getProperty("java.class.path").split(":")).
                stream().
                map(ClassPathHandler::getUrl).
                collect(Collectors.toList());
    }
}

This method is used initially with the class loader of the class that it's part of, meaning it's called like this -  getAllClassPath(ClassPathHandler.class.getClassLoader().
I wasn't the one who wrote this code so I'm struggling a bit with how to resolve this issue.
I tried to understand the solution for the ivypot-gradle-plugin you shared but couldn't get a good grasp on what I'm supposed to implement to fix this issue in our case.
As far as I understood the Instrumented class is taking control of the System.getProperty part (This was extracted to the AccessTrackingProperties class instead of the Instrumented) but this class exists from both the Plugin classpath we have, and also from the service classpath we are using this plugin since both of them are using Gradle 6.9.1 which includes the org.gradle.internal.classpath.Instrumented class. Why would this error happen?
I'm assuming that this class is also included in the Plugin when the service calls its Tasks.
Could you please share a code example of how to implement this detached configuration or any other of the solutions you suggested? I prefer not to implement a dirty workaround.
Regrading this:

Going over this issue, I am afraid the answer will be to not try to load transformed buildscript dependencies outside of a Gradle execution context.
Instead you should use proper dependency management to pull in what you need.

What does this mean exactly? We are already using the Gradle dependency management. Are we supposed to import the plugin code as a dependency instead of a Plugin declaration?
Sorry for the number of questions I throw at you, this thread has many abstract definitions and it's a bit hard to understand the whole picture like you the maintainers. I try to read the Gradle docs/blogs but couldn't find any useful information on how to solve this issue.

@ljacomet @eskatos could any of the Gradle team address the above message I posted?

FYI: I managed to work around this problem inspired by @Vampire's comments about using a gradle configuration classpath. This helps me migrate from Gradle 6.5.1 to 7.4.2.
Here is the gist of the solution in the build.gradle script:
plugins {
    id 'com.github.psxpaul.execfork' version '0.2.0'
}

configurations {
    fuseki
}

dependencies {
    fuseki 'org.apache.jena:jena-fuseki-server:4.2.0'
}

/*
 * Start the headless Fuseki server as a background build process.
 * Note that the server is stopped after the build; this alleviates the need for a stopFuseki task.
 */
task startFuseki(type: com.github.psxpaul.task.JavaExecFork, group:"oml") {
    classpath = project.files().from(configurations.fuseki.resolve().toList())
    main = 'org.apache.jena.fuseki.main.cmds.FusekiMainCmd'
    def config = file('.fuseki.ttl')
    args = [ "--config=$config" ]
    waitForPort = 3030
    workingDir = file('.fuseki')
    standardOutput = file('.fuseki/fuseki.log')
}

Hope this helps!

Nicolas.

So, to put a summary here:

The JAR files on the build script classpath are not the original JARs because Gradle modifies the bytecode of plugins and their dependencies to do various internal tasks. In particular, some Java API calls are replaced with calls to Gradle's Instrumented class to intercept them and detect build script inputs like system properties and environment variables.
Because of (1) it is not possible to use JARs of the build script classpath outside the original Gradle's classloader, at least not without the significant effort. It may work for now if the code doesn't hit instrumented call sites, but it may break in the future versions of Gradle when the list of instrumented API calls grows.
Therefore, constructing a classpath out of JARs retrieved from the build script's classpath (with protectionDomain.codeSource.location or casting the classloader to URLClassLoader) is not supported by Gradle and should be avoided.
As a preferred alternative, one could use Gradle's dependency management capabilities to obtain necessary JARs, e.g. by declaring a configuration with these JARs as dependencies and resolving it. The Worker API with classpath/process isolation could also be of help there.

Eventually, we might change the way instrumentation works to avoid exposing the modified JARs at all, but I cannot provide any estimates of when it happens. We'd still prefer users to switch to supported ways of getting dependencies.


ValueError: Expected object or value

When I run:
python K-QA/run_eval.py --result_file K-QA/dummy_res.json --version test0
It reports the following error:
Traceback (most recent call last):
File "/home/bufang/langchain-rag-tutorial/K-QA/run_eval.py", line 157, in
asyncio.run(
File "/home/bufang/anaconda3/envs/rag/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/home/bufang/anaconda3/envs/rag/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
return future.result()
File "/home/bufang/langchain-rag-tutorial/K-QA/run_eval.py", line 32, in run_experiment
df_gt = pd.read_json(
File "/home/bufang/anaconda3/envs/rag/lib/python3.10/site-packages/pandas/io/json/_json.py", line 815, in read_json
return json_reader.read()
File "/home/bufang/anaconda3/envs/rag/lib/python3.10/site-packages/pandas/io/json/_json.py", line 1023, in read
obj = self._get_object_parser(self._combine_lines(data_lines))
File "/home/bufang/anaconda3/envs/rag/lib/python3.10/site-packages/pandas/io/json/_json.py", line 1051, in _get_object_parser
obj = FrameParser(json, **kwargs).parse()
File "/home/bufang/anaconda3/envs/rag/lib/python3.10/site-packages/pandas/io/json/_json.py", line 1187, in parse
self._parse()
File "/home/bufang/anaconda3/envs/rag/lib/python3.10/site-packages/pandas/io/json/_json.py", line 1427, in _parse
ujson_loads(json, precise_float=self.precise_float), dtype=None
ValueError: Expected object or value

Hi,
Thank you for opening this issue. Please correct me if I am wrong, but I assume you simply didn't execute the script from the correct directory.
In the terminal, you can follow these steps:
git clone git@github.com:Itaymanes/K-QA.git
cd K-QA

Then, install the relevant packages. We use poetry as we have found it more convenient for obtaining the necessary requirements. Additionally, add the relevant environment keys for azure or openai.
Finally, execute the following command:
python run_eval.py --result_file dummy_res.json --version test0

Thanks for your reply. Now it works for me. Thanks~


touched frame issues

I am using FTCoreTextView and have noticed two issues with the location of the link as received in the delegate function:

(void)coreTextView:(FTCoreTextView *)acoreTextView receivedTouchOnData:(NSDictionary *)data
{
...
CGRect touchedFrame = CGRectFromString([data objectForKey:FTCoreTextDataFrame]);

The Y value is always too large, by about the font size. I may be miscalculating something, but that's what I'm seeing.
If there are multiple links on a line, I always get the same frame.

I am using this in conjunction with a popup, so I really notice these issues. #1 I can work around, but #2 makes for an awkward UX.

Hi,
I'm also facing the second issue you got. It seems that the rect value of first links are overridden by the rect value of the last link.


Upgrade to Expo 49 & expo-blur 12.4.1 ( with needed fixes for breaking changes )

Hello 👋
closes: #111
There have been breaking changes with Expo 49 & expo-blur 12.4.1 see: https://github.com/expo/expo/issues/23539
This PR bump expo + expo package versions and fix related breaking changes.
Unfortunately this library also breaks with reanimated 3.3.0 and 3.4.0. Not sure if it works with later versions or not. But there was a problem with assigning functions to a reanimated shared value ( when you try to read function after words it's always empty object) I could fix that with these changes that I found here:
diff --git a/src/reanimated2/shareables.ts b/src/reanimated2/shareables.ts
index 03575ab9e4f399a6a3a6fa6e7786b92b2c671830..1bf9451adcea074339105fef0c494b118c445385 100644
--- a/src/reanimated2/shareables.ts
+++ b/src/reanimated2/shareables.ts
@@ -21,6 +21,7 @@ const _shareableFlag = Symbol('shareable flag');
 const MAGIC_KEY = 'REANIMATED_MAGIC_KEY';

 function isHostObject(value: NonNullable<object>): boolean {
+  "worklet"
   // We could use JSI to determine whether an object is a host object, however
   // the below workaround works well and is way faster than an additional JSI call.
   // We use the fact that host objects have broken implementation of `hasOwnProperty`
@@ -257,6 +258,15 @@ export function makeShareableCloneOnUIRecursive<T>(value: T): ShareableRef<T> {
   function cloneRecursive<T>(value: T): ShareableRef<T> {
     const type = typeof value;
     if ((type === 'object' || type === 'function') && value !== null) {
+      // apply https://github.com/software-mansion/react-native-reanimated/commit/e76311f05c661787ffcc14bb9ab71d7403d680e7
+      // @ts-expect-error
+      if (value?.__remoteFunction) {
+        // @ts-expect-error
+        return value.__remoteFunction;
+      }
+      if (isHostObject(value as object)) {
+        return value as ShareableRef<T>;
+      }
       let toAdapt: any;
       if (Array.isArray(value)) {
         toAdapt = value.map((element) => cloneRecursive(element));

awesome this works perfectly for me!
FYI I didn't need to apply that react-native-reanimated patch to get it to work but maybe i will run into the error later on

Maybe they merged the changes to the latest version? which version of reanimated are you using? 3.4.0?
The issue should happen when trying to execute actions from the menu

Please merge this great PR maintainers 🙏  @enesozturk @kesha-antonov @gorhom @spencerc99

Hey @enesozturk this seems to fix the issue. Please review and approve it when you are free.

@enesozturk please review changes, we also need rn-hold-menu in our project but expo 49+ and reanimated 3+

Hey there,
It works on my side.
However, when I click on an action, I have this error:
TypeError: item.onPress.apply is not a function (it is undefined)
The onPress does not seem to be pass down the good way within the component.
Any ideas?
Thank you 🙏

@marcdelalonde Did you try the reanimated patch I mentioned above?

Please merge 🙏

Thanks for the work done! Looking forward at this to be merged 😄

@enesozturk could we merge this? 🙏 the package is currently broken and this should fix it.


Video full screen immediately exit

short description of the bug / issue, provide more detail below.
I am trying to create youtube video in slick slider and full screen option is not working, its  immediately exiting.dont know why this issue coming..please help me to resolve this issue
====================================================================

[  paste your jsfiddle link here  ]
use this jsfiddle to reproduce your bug:
http://jsfiddle.net/simeydotme/fmo50w7n/
we will likely close your issue without it.
====================================================================
Steps to reproduce the problem

...
...

====================================================================
What is the expected behaviour?
...
====================================================================
What is observed behaviour?
...
====================================================================
More Details

Which browsers/versions does it happen on?
Which jQuery/Slick version are you using?
Did this work before?

I'm facing the same issue and for the life of mine can't seem to be able to figure out how to prevent it.
I have youtube embeds as slides. It seems to have something to do with responsive setting. I suspect, that when I click on fullscreen on youtube video, it cause the responsive breakpoints to fire and reinitialize slick carousel and  therefore forcing fullscreen to exit.

I'm also facing the same issue on Chrome v 125.0.6422.72 on Android. When I play an embedded YouTube video and attempt to make it full screen on mobile, it immediately closes the video. This does not happen on desktop. Other embedded YouTube videos on the page work just fine, it's just the one embedded within my slick slider that does this. Using slick v 1.9.0, jQuery v 3.7.1.


UHF-10774: news location

UHF-10774

What was done

This thing was fixed

How to install

Make sure your instance is up and running on latest dev branch.

git pull origin dev
make fresh

Update the Helfi Platform config

composer require drupal/helfi_platform_config:dev-UHF-0000_insert_correct_branch

Run make drush-updb drush-cr

How to test

[ ] Check that this feature works
[ ] Check that code follows our standards

Continuous documentation

[ ] This feature has been documented/the documentation has been updated
[ ] This change doesn't require updates to the documentation

Translations

[ ] Translations have been added to .po -files and included in this PR

Other PRs

https://github.com/City-of-Helsinki/drupal-helfi-etusivu/pull/755

Codecov Report
Attention: Patch coverage is 35.80247% with 52 lines in your changes missing coverage. Please review.

Project coverage is 16.60%. Comparing base (bb50a52) to head (7f32184).
Report is 232 commits behind head on main.

Files with missing lines
Patch %
Lines

src/Plugin/Field/FieldWidget/LocationWidget.php
0.00%
26 Missing :warning:

.../Field/FieldFormatter/LocationDefaultFormatter.php
0.00%
15 Missing :warning:

src/TypedData/LocationDataDefinition.php
0.00%
5 Missing :warning:

src/EventSubscriber/SearchApiSubscriber.php
55.55%
4 Missing :warning:

src/Plugin/Field/FieldType/LocationItem.php
92.30%
2 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #843      +/-   ##
============================================
+ Coverage     15.29%   16.60%   +1.31%
- Complexity      259      275      +16
============================================
  Files            31       34       +3
  Lines           981     1048      +67
============================================
+ Hits            150      174      +24
- Misses          831      874      +43

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


JsArrayList.contains() doesn't work in IE8

Evidently IE 8 and earlier is missing Array.indexOf() which causes JsArrayList.contains() to break.
Fix was simple once I figured out what was going on.  Maybe this could be included in the implementation.

I would happily accept a PR :)