Cannot find module '@babel/runtime/helpers/interopRequireDefault'

I have encountered above error when attempting to work with a module from nbb.
I don't know why you need to depend on this but I know you already have a great a fully working es6 codebase.
My request is, if possible, to move completely to es6 without the interop part, or put an interop aside as an workaround.

A pure JS repro:
foo.mjs:
import * as foo from 'rqlite-js'

$ node foo.mjs
internal/modules/cjs/loader.js:902
  const err = new Error(message);
              ^

Error: Cannot find module '@babel/runtime/helpers/interopRequireDefault'

@borkdude there is a pure ES6 implementation in the es6 folder if you would prefer to use this an see if it works.  The NPM module is transpiled to ES5 from ES6.  Could you first try importing just the exports you need from 'rqlite-js and not *?
Explicit import:
import { DataApiClient, BackupApiClient, BackupApiClient  } from 'rqlite-js/es6'
ES Import:
import * as foo from 'rqlite-js/es6'
Are you using babel in your project?  Sometimes this error can occur when babel versions conflict.

@justinmorant
import * as foo from 'rqlite-js/es6'

does not work as the files in the es6 modules are not named .mjs and you may not use import on .js files if package.json does not have "type": "module" or the JS files should use .mjs. Have you tried using the es6 module yourself in Node.js?

Example:
foo.mjs
import { DataApiClient, BackupApiClient } from 'rqlite-js/es6/index.js'

gives:
file:///private/tmp/rq/foo.mjs:1
import { DataApiClient, BackupApiClient } from 'rqlite-js/es6/index.js'
         ^^^^^^^^^^^^^
SyntaxError: Named export 'DataApiClient' not found. The requested module 'rqlite-js/es6/index.js' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'rqlite-js/es6/index.js';
const { DataApiClient, BackupApiClient } = pkg;

And this:
foo.mjs
import * as foo from 'rqlite-js/es6/index.js'

$ node foo.mjs
(node:61458) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
/private/tmp/rq/node_modules/rqlite-js/es6/index.js:5
import DataApiClient from './api/data'
^^^^^^

SyntaxError: Cannot use import statement outside a module

@borkdude the testing framework uses ES6 in docker containers to run tests before the npm lib is built.  The container use babel to execute the Javascript so it does not throw these errors.  I will find sometime to convert the ES6 code to .mjs to see if I can remove babel.
In the meantime if you change from using import * to named imports i.e. import { DataApiClient, BackupApiClient } from 'rqlite-js' (notice the es6 folder was exclude) does this work for you?

does this work for you?

No

The work has begun on mjs branch with es6 implemented using the .mjs extension.  It is working transpiling from es6 to es5, but rewriting the import .mjs. to require .js is not correctly replacing the file extensions.
Once this is sorted out I will update the thread.

@borkdude and @littleli jqlite-js v2.5.5 has been released with an updated package.json, @babel/runtime was moved from dev dependencies to dependencies which should fix the interop issue.
The expectation is the import * should no longer throw an interop issue since the babel runtime is now a regular dependency.
import * as foo from 'rqlite-js'

This is output I get from shell
On es6 import:
ᐅ node rq.js
(node:13785) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
/Users/littleli/Work/nbb/examples/rqlite/rq.js:1
import * as rq from 'rqlite-js';
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at Object.compileFunction (node:vm:352:18)
    at wrapSafe (node:internal/modules/cjs/loader:1033:15)
    at Module._compile (node:internal/modules/cjs/loader:1069:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Module._load (node:internal/modules/cjs/loader:827:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:17:47

On commonjs use:
ᐅ node
Welcome to Node.js v18.0.0.
Type ".help" for more information.
> const rq = require('rqlite-js');
undefined
> rq
{
  DataApiClient: [class DataApiClient extends ApiClient],
  BackupApiClient: [class BackupApiClient extends HttpRequest],
  StatusApiClient: [class StatusApiClient extends ApiClient]
}

so definitely require (commonjs) module works now!
For my original use case it means nbb is able to load the module as well. FYI example similar to one from README in the project.
(ns example
  (:require ["rqlite-js$default" :as rq]
            [promesa.core :as p]))

(def client (rq/DataApiClient. "http://localhost:4001"))

(defn query-by-name [name]
  (str "SELECT id FROM foo WHERE name = \"" name "\""))

(p/let [results (.query client (query-by-name "fiona"))]
  (when-not (.hasError results)
    (-> results
        (.get 0)
        (.get "id")
        (prn))))

;; Output
1
#<Promise[~]>

I hope the .mjs improvement will make it even better and future proof! Great library Justin!

Ok, one more update. After renamed rq.js to rq.mjs es6 import seems to work too. So I think we're good.

@littleli thanks for confirming it is now working. This issue is closed.


bad card detection in deck exporter

resolution : 1600x900
Detected : (Lay on Hands instead of Circle of Healing)
2 Power Word: Shield
2 Northshire Cleric
2 Undertaker
2 Zombie Chow
2 Loot Hoarder
1 Shadow Word: Death
2 Thoughtsteal
2 Dark Cultist
2 Injured Blademaster
2 Auchenai Soulpriest
1 Baron Rivendare
1 Defender of Argus
1 Holy Nova
2 Sludge Belcher
2 Cabal Shadow Priest
1 Cairne Bloodhoof
1 Sylvanas Windrunner
2 Lay on Hands

another one : Burly Rockjaw Trogg and Fel Cannon instead detected of Ironbeak Owl and Kill Command (in Hunter deck)

another one : Burly Rockjaw Trogg and Fel Cannon instead detected of Ironbeak Owl and Kill Command (in Hunter deck)

Idea : we should check the class cards and warn (before submit button is available) if the deck is invalid (<30 cards)

Idea : we should check the class cards and warn (before submit button is available) if the deck is invalid (<30 cards)


Action doesn't work

Robot Model
Turtlebot4 Standard
ROS distro
Humble
Networking Configuration
Simple Discovery
OS
Ubuntu 22.04
Built from source or installed?
Installed
Package version
H2.6
fastdds (default)
usb
Type of issue
Other
Expected behaviour
I want to use the ros2 action to perform the create3 operation.
First, I executed the following command on the command line
ros2 action send_goal /drive_distance irobot_create_msgs/action/DriveDistance "{distance: 0.5,max_translation_speed: 0.15}"
Actual behaviour
It didn't work.
I got a few errors about the message size,
but it was basically just waiting.
I've seen delays of a few seconds, but even after waiting 10 minutes it still didn't work.
Additionally, a happy sound suddenly started. The cause is unknown, but it appears to reboot.
Error messages
^C
ubuntu@ubuntu:~$ ros2 action send_goal /drive_distance irobot_create_msgs/action/DriveDistance "{distance: 0.5,max_translation_speed: 0.15}"
Waiting for an action server to become available...
Sending goal:
     distance: 0.5
max_translation_speed: 0.15

2024-08-02 08:41:52.524 [RTPS_READER_HISTORY Error] Change payload size of '32' bytes is larger than the history payload size of '19' bytes and cannot be resized. -> Function can_change_be_added_nts

^C
ubuntu@ubuntu:~$ ros2 action send_goal /drive_distance irobot_create_msgs/action/DriveDistance "{distance: 0.5,max_translation_speed: 0.15}"
Waiting for an action server to become available...
Sending goal:
     distance: 0.5
max_translation_speed: 0.15

^C

To Reproduce
I flashed the humble image for tb4 and updated it to the latest version along with the C3 firmware. I used the setup tool.
After that, all you have to do is run the command.
The list of topics and actions is as follows.
ubuntu@ubuntu:~$ ros2 topic list
/battery_state
/cmd_vel
/diagnostics
/diagnostics_agg
/diagnostics_toplevel_state
/dock_status
/function_calls
/hazard_detection
/hmi/buttons
/hmi/display
/hmi/display/message
/hmi/led
/imu
/interface_buttons
/ip
/joint_states
/joy
/joy/set_feedback
/mouse
/oakd/rgb/preview/image_raw
/parameter_events
/robot_description
/rosout
/scan
/tf
/tf_static
/wheel_status
ubuntu@ubuntu:~$ ros2 node list
/_internal/composite_hazard
/_internal/kinematics_engine
/_internal/mobility
/_internal/stasis
/analyzers
/joint_state_publisher
/joy_linux_node
/launch_ros_1217
/mobility_monitor
/motion_control
/oakd
/oakd_container
/robot_state
/robot_state_publisher
/static_transform
/system_health
/teleop_twist_joy_node
/turtlebot4_base_node
/turtlebot4_diagnostics
/turtlebot4_node
/ui_mgr
ubuntu@ubuntu:~$ ros2 action list
/dock
/drive_distance
/led_animation
/undock
/wall_follow
Other notes
No response

Hi,
I think you need to install create3 messages package.
check if it installed:
apt list --installed | grep irobot
if you cannot see ros-humble-irobot-create-msgs, install it:
sudo apt install -y ros-humble-irobot-create-msgs
br,
On Fri, Aug 2, 2024 at 1:03 PM taara67 @.***> wrote:

Robot Model
Turtlebot4 Standard
ROS distro
Humble
Networking Configuration
Simple Discovery
OS
Ubuntu 22.04
Built from source or installed?
Installed
Package version
H2.6
fastdds (default)
usb
Type of issue
Other
Expected behaviour
I want to use the ros2 action to perform the create3 operation.
First, I executed the following command on the command line
ros2 action send_goal /drive_distance
irobot_create_msgs/action/DriveDistance "{distance:
0.5,max_translation_speed: 0.15}"
Actual behaviour
It didn't work.
I got a few errors about the message size,
but it was basically just waiting.
I've seen delays of a few seconds, but even after waiting 10 minutes it
still didn't work.
Additionally, a happy sound suddenly started. The cause is unknown, but it
appears to reboot.
Error messages
^C
@.***:~$ ros2 action send_goal /drive_distance irobot_create_msgs/action/DriveDistance "{distance: 0.5,max_translation_speed: 0.15}"
Waiting for an action server to become available...
Sending goal:
distance: 0.5
max_translation_speed: 0.15
2024-08-02 08:41:52.524 [RTPS_READER_HISTORY Error] Change payload size of '32' bytes is larger than the history payload size of '19' bytes and cannot be resized. -> Function can_change_be_added_nts
^C
@.***:~$ ros2 action send_goal /drive_distance irobot_create_msgs/action/DriveDistance "{distance: 0.5,max_translation_speed: 0.15}"
Waiting for an action server to become available...
Sending goal:
distance: 0.5
max_translation_speed: 0.15
^C
To Reproduce
I flashed the humble image for tb4 and updated it to the latest version
along with the C3 firmware. I used the setup tool.
After that, all you have to do is run the command.
The list of topics and actions is as follows.
@.:$ ros2 topic list
/battery_state
/cmd_vel
/diagnostics
/diagnostics_agg
/diagnostics_toplevel_state
/dock_status
/function_calls
/hazard_detection
/hmi/buttons
/hmi/display
/hmi/display/message
/hmi/led
/imu
/interface_buttons
/ip
/joint_states
/joy
/joy/set_feedback
/mouse
/oakd/rgb/preview/image_raw
/parameter_events
/robot_description
/rosout
/scan
/tf
/tf_static
/wheel_status
@.:$ ros2 node list
/_internal/composite_hazard
/_internal/kinematics_engine
/_internal/mobility
/_internal/stasis
/analyzers
/joint_state_publisher
/joy_linux_node
/launch_ros_1217
/mobility_monitor
/motion_control
/oakd
/oakd_container
/robot_state
/robot_state_publisher
/static_transform
/system_health
/teleop_twist_joy_node
/turtlebot4_base_node
/turtlebot4_diagnostics
/turtlebot4_node
/ui_mgr
@.***:~$ ros2 action list
/dock
/drive_distance
/led_animation
/undock
/wall_follow
Other notes
No response
—
Reply to this email directly, view it on GitHub
https://github.com/turtlebot/turtlebot4/issues/454, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADYU3C47YMLWW6FVFQRQU23ZPNKNZAVCNFSM6AAAAABL4HP5HWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2DINRQGAYTANQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

thank you for your reply
ubuntu@ubuntu:~/turtlebot4_ws$ apt list --installed |grep irobot
WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
ros-humble-irobot-create-control/jammy,now 2.1.0-1jammy.20240801.165108 arm64 [installed]
ros-humble-irobot-create-description/jammy,now 2.1.0-1jammy.20240729.033517 arm64 [installed,automatic]
ros-humble-irobot-create-msgs/jammy,now 2.1.0-1jammy.20240730.201125 arm64 [installed]
it was already installed in Raspi 4

The send goal was executed!
max_translation_speed: 2"
Waiting for an action server to become available...
Sending goal:
     distance: 0.3
max_translation_speed: 2.0

Goal accepted with ID: 161fe707c3c047168555455001fad3c4

Result:
    pose:
  header:
    stamp:
      sec:<PHONE_NUMBER>
      nanosec: 515621639
    frame_id: odom
  pose:
    position:
      x: 0.137577086687088
      y: 1.928069829940796
      z: 0.011613388545811176
    orientation:
      x: -0.002767911152024286
      y: -0.004743525546562102
      z: 0.6954821418999861
      w: 0.7185223920877143

Goal finished with status: SUCCEEDED

real	1m36.783s
user	0m2.869s
sys	0m1.262s
ubuntu@ubuntu:~/turtlebot4_ws$

However, it takes a very long time to execute the action.
https://github.com/turtlebot/turtlebot4/issues/332
I found a similar problem, but in my environment, I can't connect the robot to wifi, so I want to speed up action execution with a discovery server.

Hi,
How did you solve it? What was a root problem?

No recent updates. Ticket is closed.

Hi, How did you solve it? What was a root problem?

@dgel27 just in case this is may be still useful: I encountered the same issue and it turned out to be mismatching RMW_IMPLEMENTATION between the host and create3 app config. Once they were set to match (either rmw_fastrtps_cpp or rmw_cyclonedds_cpp), the mismatching message size error went away, and things started working.


CI: fix build of code-formatting container

This is an alternative to #2874. I don't like the changes that Astyle 3.4 introduces, so I'd avoid upgrading to it if possible. By migrating the Docker image from Alpine to Debian, we can drag our feet a while longer, maybe long enough for Astyle to get fixed.

coverage: 60.681%. remained the same
when pulling 5f26b6c7d9159d11f297d2ab7617a9601708a7da on bugfix/code-formatting-ci
into 74f32a983b97049ac33b72404aee61f64c3a718f on master.


converted image to webp

Hello
I have converted images to webp format
So previously using png images the lighthouse report gave performance of 54% but when using webp images it gave 55% with a little increase of 1%
As in our code there are less number of images the performance difference is not much
But if the images increases it could benefit us.
Thank you
Issue #213

Your PR is successfully merged.


Feature suggestion: Proxying a request may want to change the Host header

I have a case where I need karma to proxy requests with a specific Host header (matching the target configuration).
The http-proxy module, used by karma, has an option to do so: changeOrigin. I would like to be able to enable this option in the configuration file, per proxy.
I have a suggestion of solution ready at this branch
Example of configuration in config file:
proxies: {
        '/foo': 'http://foo.localhost',
        '/bar': {
            target: 'http://bar.localhost',
            changeOrigin: true
        }
    }

Thanks

I think as we are already providing the functionality of proxying we might as well allow this. So please send a PR and I'll review it :smile:


Add configuration section with TypeScript in documentation

Are you requesting a feature or reporting a bug?
A documentation suggestion change
What is the current behavior?
The doc doesn't have a section to configure with TypeScript
What is the expected behavior?
The doc should have a section to configure with TypeScript. For example setting up type in tsconfig.json. After configuring types in tsconfig.json, the users can easily get code completion from IDE
How would you reproduce the current behavior (if this is a bug)?
N.A.
Provide the test code and the tested page URL (if applicable)
N.A.
Specify your

operating system: MacOS High Sierra
testcafe version: 0.19.0
node.js version: 9.7.1

Hi @AhnpGit,
For now TestCafe doesn't support custom tsconfig.json files but we have planned to implement it (#1845).

After configuring types in tsconfig.json, the users can easily get code completion from IDE

Do you mean code completion for TestCafe API? IDEs should enable it automatically when you write TestCafe tests (see TypeScript Support).


Some calendar month days do not appear when I scroll the calendar vertically

Library information:

Version: [ 2.1.1]
View or Compose module: [view]

Describe the bug**
i have add already exists google calendar Events in the calendar then after i scroll the calendar so some calendar month days do not appear when I scroll the calendar vertically
To Reproduce (if applicable)
Steps to reproduce the behavior:

Go to 'scroll the calendar then back to the previous calendar month'

Expected behavior (if applicable)
A clear and concise description of what you expected to happen.
Screenshots? (if applicable)
If applicable, add screenshots or screen recordings to help explain the problem.

Additional information
Add any other information about the bug here.

If you hid some days in your binding logic you also have to unhide them otherwise they remain hidden. Can you see if this issue happens in the sample project?

I will close this issue, please reopen it if this is really a library issue.


Not listed yet: link.springer.com

The website at this url is unlisted: https://link.springer.com/article/10.1365/s40702-018-00474-6

This site is now listed in the latest version of Global Consent Manager. Thank you for the notification and let us know if you have any more issues.

Also, note that the Mozilla Add-On release will only be updated when I've finished all of the current listing issues. Today or tomorrow.


Cache not saving on Windows

Seems to be working just fine on other OS/py combinations, including Windows 3.12 and Linux/Mac 3.13.
During post job, the following output is generated:
Post job cleanup.

Warning: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.

gha job: https://github.com/omnilib/aioitertools/actions/runs/10660169548/job/29543776557?pr=193
gha workflow: https://github.com/omnilib/aioitertools/pull/193/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f

this is #12, no? they wrote not restoring but it's not restoring because it's not saving :D

BTW I checked – it's not saving on your other combinations either which blessedly makes it a bit simpler.

ok, I swear I'd looked and the 3.12 windows job had saved, so I thought it was something specific to 3.13. 🤪
Unlike #12 though, I'm not specifying any particular shell or anything else "weird" beyond installing to the "system" so that I don't have to manage venvs in my CI jobs. Is there a workaround in the other issue that I'm missing?

No, I think it’s my fault and will have to figure out what Windows directories are off-limits if accessed from a different action. :( IOW: I suspect I can access certain dirs in my own CI, but not if the action is used in a different project.
this is gonna be fun to figure out

looks like Astral has published their own action and I don't think there's a point in competing with them so maybe check them out and see if it works over there: https://github.com/astral-sh/setup-uv

looks like Astral has published their own action and I don't think there's a point in competing with them so maybe check them out and see if it works over there: https://github.com/astral-sh/setup-uv

It looks like Astral's action does cache/restore correctly on windows, using a non-standard temp directory:
Set UV_CACHE_DIR to D:\a\_temp\setup-uv-cache

https://github.com/omnilib/ufmt/actions/runs/10766175508/job/29851507811?pr=239

lol i just saw it too


Decorator on class methods not working

First, thanks for your work on this project it has been really helpful.
The mocurly decorator doesn't seem to work on class methods:
class RecurlyTestCase(unittest.TestCase):
  @mocurly
  def test_count_recurly_accounts(self):
    for i in range(10):
        recurly.Account(account_code=str(i)).save()
    assert count_recurly_accounts() == 10

raises the following exception:
    def __call__(self, *args, **kwargs):
        self.start()
        try:
>           retval = self.func(*args, **kwargs)
E           TypeError: test_count_recurly_accounts() takes exactly 1 argument (0 given)

I would have made a pull request, but I'm not sure how to fix this.

Thanks for the report! You can try out https://github.com/Captricity/mocurly/pull/5

Yes that works, thanks for the quick fix!


4.3.0 will force children to be recreated - does not happen in 4.2.1

Today I updated to 4.3.0 and suddenly I noticed that children component inside the flexbox were being completely recreated (instead of updated) upon new renders.
When I went back to 4.2.1 the issue was fixed.
PS: not sure if it helps, but the root of the cause seems to be re-creations of styled.div children I think.

I just noticed that you are basically creating a styled(element) on each render. Maybe that's why?
Would it be better to make FlexBox a full class component and only recreate (and cache in a class property) this styled component on componentWillMount + componentWillUpdate?

Ok, basically that worked, but I still had to use the props inside the styled element itself for it to work.
Here is the code I did (and tested) in typescript (tsx file). This way it doesn't recreate the children as it used to in 4.2.1, except if the 'element' property changes (which I guess is unavoidable unless a cache with all elements asked so far is used)
Sorry I don't have time for a proper pull request, but it should be fairly easy to translate back to jsx if you so wish.
import * as React from 'react';
import {PropTypes} from 'react';
import styled from 'styled-components';

const { string, oneOf, node, number, bool, object } = PropTypes;

const toPropertyString = (name: string, value: any): string => {
  // hyphenate the camel case name
  const realName = name.replace(/([A-Z])/g, (g: any) => `-${g[0].toLowerCase()}`);

  return value ? `${realName}: ${value};` : '';
};

// TODO: here you could define the Flexbox props as an interface instead if desired (in case you wanna keep using typescript)
export type FlexboxProps = any;

class Flexbox extends React.Component<FlexboxProps, {}> {
  static defaultProps: Partial<FlexboxProps> = {
    display: 'flex',
    element: 'div',
  };

  static propTypes: any = {
    alignContent: oneOf([
      'center',
      'flex-end',
      'flex-start',
      'space-around',
      'space-between',
      'stretch',
    ]),
    alignItems: oneOf(['baseline', 'center', 'flex-end', 'flex-start', 'stretch']),
    alignSelf: oneOf(['baseline', 'center', 'flex-end', 'flex-start', 'stretch']),
    children: node,
    display: oneOf(['flex', 'inline-flex']),
    element: oneOf([
      'article',
      'aside',
      'div',
      'figure',
      'footer',
      'header',
      'main',
      'nav',
      'section',
    ]),
    flex: string,
    flexBasis: string,
    flexDirection: oneOf(['column-reverse', 'column', 'row-reverse', 'row']),
    flexGrow: number,
    flexShrink: number,
    flexWrap: oneOf(['nowrap', 'wrap-reverse', 'wrap']),
    height: string,
    inline: bool,
    justifyContent: oneOf(['center', 'flex-end', 'flex-start', 'space-around', 'space-between']),
    margin: string,
    marginBottom: string,
    marginLeft: string,
    marginRight: string,
    marginTop: string,
    maxHeight: string,
    maxWidth: string,
    minHeight: string,
    minWidth: string,
    order: number,
    padding: string,
    paddingBottom: string,
    paddingLeft: string,
    paddingRight: string,
    paddingTop: string,
    style: object,
    width: string,
  };

  // take the prop names from the propTypes but for some that don't need to be styled
  private static _propNames: string[] = Object.keys(Flexbox.propTypes).filter((e: string) => e !== 'children' && e !== 'element');

  private _styledComponent?: any;
  private _element?: string;

  componentWillMount(): void {
    this._updateStyledComponent(this.props);
  }

  componentWillUpdate(nextProps: FlexboxProps): void {
    this._updateStyledComponent(nextProps);
  }

  render(): JSX.Element {
    const {element, children, ...otherProps} = this.props;
    const StyledComponent = this._styledComponent;
    return (<StyledComponent {...otherProps}>{children}</StyledComponent>);
  }

  private _updateStyledComponent(props: FlexboxProps): void {
    // do not recreate if not needed
    if (props.element === this._element && this._styledComponent) return;
    this._element = props.element;

    this._styledComponent = styled(props.element)`
      ${(p: FlexboxProps): string => Flexbox._propNames.map((name: string): string => toPropertyString(name, p[name])).join(' ')}
    `;
  }
}

export default Flexbox;

PS: I'm not sure if styled components do anything with the style attribute. Probably it would need to be removed.
On the other hand, if it does work maybe className would need to be added as well.
It would need to be added to propTypes,
( e !== 'children' && e !== 'element' && e !== 'style' && e !== 'className'), and
    const {element, children, style, className, ...otherProps} = this.props;
    const StyledComponent = Flexbox._styledComponents[element.trim().toLowerCase()];
    return (<StyledComponent className={className} style={style} {...otherProps}>{children}</StyledComponent>);

Ok, apparently both style and className are supported, so I just added them to the source code above.
Also I added some proper typescript typing, so it can be easily translated into a definitions file by the typescript compiler.
Cheers!

I will add to this...since upgrading to 4.3 I started seeing strange issues. If wherever I have a Flexbox component I replace with <div style={{display: flex etc...) with the same properties as passing to Flexbox then everything is fine. I love the approach with this component where it insulates the developer from dealing with all the intricacies of all the proper Flexbox styles across browsers as well as the simple React tag, properties for everything. Right now I went back to 4.2.1 and all is good. Great job with the component!

@xaviergonz @jeffbonasso I can shed some light to why v4.3.0 uses the styled(element). It's because the previous approach with inline styles doesn't work with server side rendering, but using styled-components fixes that issue. I'd be happy to assist in fixing any issue you guys are seeing with this approach.

I just upgraded and am seeing the same issue. styled-components creates a new class upon each DOM update which reloads all child components.

Having the same problem, version 4.3.0 broke our app. When parent elements are recreated all the child inputs lose focus etc.

If you could submit a PR with that fix it would be awesome @hampusohlsson! 😄

Or you @xaviergonz, it would be highly appreciated! 😃

@nachoaIvarez I believe @xaviergonz is right, the problem is that you're creating the styled component inside pure component's render (https://github.com/nachoaIvarez/flexbox-react/blob/master/src/Flexbox.jsx#L41), you should move StyledComponent outside the Flexbox function and just prefix everything with props., like align-content: ${props => props.alignContent ? props.alignContent : ''};. Didn't test it yet though :)

I just noticed the dynamic tag name (element), that makes moving it outside more complicated.

Check this implementation and test case:
https://www.webpackbin.com/bins/-Kfrfs0WOsUM4RIc3m_j

v4.3.1 is out! Thanks @hoppula for your help!

Great job guys, thanks @hoppula !!


Add additional metadata to all builds for historic information

Fixes https://github.com/fastlane/ci/issues/570
WIP, as I want to add some tests also

Self-approve due to missing review


Is there a way to avert the diamond dependency problem for modules that use .Net types?

It seems like certain things can only be defined once per PowerShell session.  Public enums named in calls to Add-Type are one such example.  In the repro below, a .Net enum of a particular name could only be defined once even though the two definitions are in separate modules.  Working around such naming collisions amongst unrelated modules is usually a one-time event.  However, the same problem manifests when more than one version of the same module is required to exist in a single session.  This occurs every time a .Net type in a low-level module changes and the mid-level modules aren't updated simultaneously.  I've been running into this problem in PowerShell with increasing frequency as I incorporate more third-party libraries and as my code has become more modular.
As far as I've read this problem is called "the diamond dependency problem" (video).  The repro below demonstrates the canonical scenario described in the video in PowerShell.
There seems to be some signs that C# projects can load multiple versions of the same assembly thereby averting the diamond dependency problem (e.g. stackoverflow question).  Is there a similar strategy that works in PowerShell?
Steps to reproduce
New-Module libutil_v1 {
    Add-Type -TypeDefinition 'public enum E {a,b,c}'
    function f {
        param
        (
            [e]
            $E
        )
    }
} | Import-Module

New-Module libutil_v2 {
    Add-Type -TypeDefinition 'public enum E {a,b,c,d}'
    function f {
        param
        (
            [e]
            $E
        )
    }
} | Import-Module

New-Module liba {
    Get-Module util_v1 | Import-Module

    function g_a {
        f -E c
    }
} | Import-Module

New-Module libb {
    Get-Module util_v2 | Import-Module

    function g_b {
        f -E d
    }
} | Import-Module

g_a
g_b

Expected behavior
No exception thrown.
Actual behavior
Add-Type : Cannot add type. The type name 'E' already exists.
At C:\users\un1\Desktop\test.ps1:13 char:5
+     Add-Type -TypeDefinition 'public enum E {a,b,c,d}'
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (E:String) [Add-Type], Excepti
   on
    + FullyQualifiedErrorId : TYPE_ALREADY_EXISTS,Microsoft.PowerShell.Command
   s.AddTypeCommand

f : Cannot process argument transformation on parameter 'E'. Cannot convert
value "d" to type "E". Error: "Unable to match the identifier name d to a
valid enumerator name. Specify one of the following enumerator names and try
again:
a, b, c"
At C:\users\un1\Desktop\test.ps1:35 char:14
+         f -E d
+              ~
    + CategoryInfo          : InvalidData: (:) [f], ParameterBindingArgumentTr
   ansformationException
    + FullyQualifiedErrorId : ParameterArgumentTransformationError,f

Environment data

> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.0-beta.8
PSEdition                      Core
GitCommitId                    v6.0.0-beta.8
OS                             Microsoft Windows 6.3.9600
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Add-Type uses a default namespace. I think Add-Type -Namespace resolves the issue.

@daxian-dbw Could you please clarify why we first load assembly and only then check duplicate types? I'd expect that terminating error should prevent loading the assembly with duplicate types.

@iSazonov I agree with you that the duplicate type check should happen before actually loading the assembly. With the current behavior, 2 assemblies containing 2 different implementations of the same type name should be loaded in the AppDomain, and either one will be used when the user references the type name depending on the randomly generated assembly names by Add-Type.
I think we check duplicates after loading now because it's easier. Before loading, it might be harder to know what types are in the assemblies. But I guess we can use the SyntaxTree returned from CSharpSyntaxTree.ParseText to get that information.

@iSazonov I found an interesting issue when playing with Add-Type and opened #5515

I discover that CheckTypesForDuplicates has a wonder logic - it can add new non-duplicate types in a loaded type cache and then throw on duplicate type - and we get full mess with types.
I think our logic should be simple - don't load an assembly if the one contains duplicate types  in relation to loaded ones.
I still not found how get types from SyntaxTree. And it seems we need SemanticModel not SyntaxTree. Roslyn types isn't well-documented. The alternative way is to use new AppDomain to load imitted assembly, maybe with ReflectionOnlyLoad() - I don't know if it works.

Add-Type uses a default namespace. I think Add-Type -Namespace resolves the issue.

@iSazonov Are you suggesting that, to avert this problem, the types used by the liba and libb modules should be namespaces named uniquely for each minor version of libutil?  So accessing the type from, say version 1.3.2 of module liba would look like [libutil.v1_0_0.E], for example.  And accessing the type from version 1.3.3 of module liba would look like [libutil.v_1_0_1.E].

@alx9r You can use this as workaround for this certain case.

Bugs in Add-Type fixed. Can we close the Issue? Currently we have a workaround. General solution requires a significant alteration in the type resolution.


Update lua and add luarocks

Update lua to 5.3.4
Add lua libraries
Add luarocks

Complies: https://github.com/lukesampson/scoop/issues/1592
@Guard13007 can you test these and report back? I don't dare to merge them yet. :grin:

To get the luarocks installer to work I had to change the installer block to the following:
    "installer": {
    	"script": "
    		$luaBin = \"$(appsdir $global)\\lua\\current\"
    		$luaLib = \"$(appsdir $global)\\lualib\\current\"
    		$luaInc = \"$(appsdir $global)\\lualib\\current\\include\"
    		& \"$dir\\setup\\install.bat\" /SELFCONTAINED /P $dir\\luarocks /NOADMIN /Q /BIN $luaBin /INC $luaInc /LIB $luaLib
    	"
    },

This also prevented me from getting exit code 121 when using cmder like in the rustup.json manifest.

any progress on this? would be really useful to have luarocks in scoop.

#2399 already add luarocks, this can be closed.


Performance improvements

Instead of calculating the deltaX, deltaY and r for each item n*n times, it now calculates them n times. Also reduced the allocations by caching the transformed polymer instead of allocating it inside each interaction check.

This is fixing #10 as well.

TODO:

it should be possible to cache the distance from each path to the observer to calculate that n times instead of n * n times as well

@FabianTerhorst Check out some of the recent branches i made in my fork of the repository, I tried out a few performance improvements that didn't end up being improvements. I found Java to be faster/better at allocating many small objects that eventually get garbage collected instead of performing object pooling.

What im doing there isn't the same its just calculating the values in the loop before the intersection check happens n * n times. Its not caching any values accross multiple measurements. Colors are also very easy to calculate thats why i inlined the full logic there its getting full java jit optimization.

I added a few more raycast algorithms for testing the performance differences, currently i would prefer the new one https://github.com/FabianTerhorst/Isometric/pull/16/commits/4b0b326c4dc4a9d82b8a24771170a0e4663599a5#diff-7798cc0d3e9fcdd35a27e8e0f6febf5dR85 .

have you tried caching the paint object with the associated color integer that got calculated from android.graphics.Color.argb?


Auto-remove Scout devices without restarting Homebridge

There's a unpaired event that has all of the device data.

After some more research, it looks like I need to refactor the platform to be registered as a “dynamic” plugin. This allows you to manually register/unregister platform accessories instead of just returning a static list from the platform.

This is blocked by #22.


Directory Structure

The file structure now is a little messy, we need to clean it up.
The most important thing in this effort is to partition contents by how they are used/treated.
Right now I am thinking a few key directories with locations controlled in config:

Courses -- Where all course directories/repos live. These files should never be changed by the autograder so git updates are always clean.
Config -- Where server config files live.
Output -- Where the output/artifacts of courses go (submissions, users.json, etc).
Cache -- Contains general caches. May be rendered useless by #1.

This has been resolved with the new database infrastructure.


+render should work on all supported languages

The idea of adding +render is that is it rendered when the presentation is created.
It would be incredibly useful to have scripts that make up content of the presentation be rendered as well, however currently only latex and typst are supported.
For example CLI tools for creating text graphs can be put in a bash +render block, allowing you to insert CLI graphs easily in your presentation.
Even for programming languages, a quick and dirty js script in your presentation to programmatically create content in a slide could be handy.
This can also be a different option from +render if we want to preserve that for images.

For example CLI tools for creating text graphs

Can you provide examples of what you'd want to create? For the record, mermaid support for +render blocks works in master and I think that would cover most "nice" graphs you'd want and would also look way better than an ascii graph.

Didn't know about mermaid, but I think the limit is your imagination the moment you can do it with scripts.
The tool I was thinking of was graph-easy however.

 You just want the code to be replaced automatically with the output of running said code?

 You just want the code to be replaced automatically with the output of running said code?

Yes.
You add a code block with +render and it is immediately executed and put on the slide. No special highlighting (besides maybe centering), no codeblocks are shown, only the output.
Some examples might be:

Gnuplot
Cowsay
asciichart
spark
tree
graph-easy
any script/programming language + imagination
...

The writer can use any tool they want or are familiar with.
It would simply appear as if you had copy-pasted the output in there yourself, 'rendering' it.
If this functionality is actually different from the other 'render' things, you could also call it +pre_process or something instead as well. But I think categorizing it under 'render` makes sense.

An option to interpret it as markdown for custom slide content would be super cool and fancy but seems excessive.

The +render flag has been used to render images that are then inserted into the presentation. You might could allow arbitrary script invocation, but then you need someway of know what image is produced to display it. This is different than tools like cowsay which write to stdout

An option to interpret it as markdown for custom slide content would be super cool and fancy but seems excessive.

If presenterm could read from stdin then a script could pipe dynamic content into it at the time of presentation:
./my_dynamic_presentation | presenterm --present

Or more simply, you just write a script that uses any number of templating languages to dynamically generate your presentation:
./my_dynamic_presentation > dynamic_presentation.md
presenterm --present  dynamic_presentation.md

The +render flag has been used to render images that are then inserted into the presentation. You might could allow arbitrary script invocation, but then you need someway of know what image is produced to display it. This is different than tools like cowsay which write to stdout

An option to interpret it as markdown for custom slide content would be super cool and fancy but seems excessive.

If presenterm could read from stdin then a script could pipe dynamic content into it at the time of presentation:
./my_dynamic_presentation | presenterm --present

Or more simply, you just write a script that uses any number of templating languages to dynamically generate your presentation:
./my_dynamic_presentation > dynamic_presentation.md
presenterm --present  dynamic_presentation.md

If +render is preserved for images than I would still opt for a +pre_process option.
While piping in-and-of itself is not a bad idea, it is not what this issue is meant for.
This is simply for having bash script's output be inserted into slides.
slides does something similar.

Example:

## My cool data slide

|```bash +pre_process
| ./assets/data.csv | gnuplot | lolcat
|```

### Takeaways

- Graph is linear (and colorful)

The idea is that the limit is the users imagination with ASCII tools. There may be hundreds of cool cli utilities that would be useful to insert as content into the slides without presenterm having explicitly support these.

Taking this idea even further:
## My other slide

|```js +pre_process_md
|console.log("### My points")
|
|for (let i = 0; i < 10; i++) {
|    console.log("- ***Point*** " + (i+1))
|}
|```

I created https://github.com/mfontanini/presenterm/pull/330 for this. I ended up calling this +exec_replace because I found pre_process to be too vague, e.g. preprocess how?. This makes naming this a bit annoying but I think it's more descriptive. I'm open to alternatives tho!


Add Octane benchmark

Add a Makefile and the necessary harness code to run Octane 2.0 benchmark. A few tests need to be stubbed out for now for various reasons (missing stub functions, const limits).
This should replace tests/google-v8-benchmark-v7 as being larger in scope. I'll update the commit tests so that the Octane benchmark is executed on a fixed physical host.

There's a Gameboy emulator and pdf.js in the Octane test, which are welcome additions because they'll probably exercise some more application behavior not covered previously.  The automatic test needs to maybe do 5-10 runs and take average or maximum. In any case scores will be lower with this hardware, though the variance due to throttling etc seems smaller at least in other tests.

 :)


Should TM_DIRECTORY in an untitled file should be '' instead of '.'?

Have a snippet like
"test": {
  "prefix": "test",
  "body": "foo ${TM_DIRECTORY:bar}"
}

In an untitled file, TM_DIRECTORY resolves to '.'. Should it be empty, so we can use a default value instead?

Testing https://github.com/Microsoft/vscode/issues/15875

so now we get TM_DIRECTORY as a placeholder in untitled file. Is that the fix?

latest build should be better...

Now it is empty string when no default is provided.
And default when default is provided.
great, verified.


Tests are not passing on windows machine.

What did you have in mind?
The behavior on win is weird, some of the fields in tests results duplicate for some reason.
     '```\r\n' +       'chore: unit test this thing\n' +       '\n' +       'chore: unit test this thing\r\n' +       '\r\n' +       'Lorem ipsum dolor sit amet\r\n' +       '```\r\n' +
So, a good solution for now will be writing a docker file that runs the tests agnosticlly.
Are you trying to fix a problem?
I can, if the maintainer will approve.
Any lead on how this feature can be implemented?
No response

hmm... good catch!
please feel free to fix it!
:-)

@TomerFi sorry, I'm leaving this for now. I have no idea what is going on there.

That's cool bro - thank you for reporting this issue and trying to fix it.
:-)

hey @dolby360
I'm looking around for a Win station to verify this on,
in the meantime, can you please elaborate on your experience?
Did you:
npm i
npm test

and witness a test case failure?
if so, what was the failing test case?

you know what...
I think I have an idea of what's the cause of this...
in all tests, I used os.EOL for line breaks,
I specifically used this to make the test work for Win-based developers too,
I guess it didn't work.
regardless, I was able to confirm the issue you reported by manually setting the EOL variable,
I'm on Linux, so this worked for me:
const EOL = '\n';

but when I did this, I was able to confirm your reported issue:
const EOL = '\r\n';

but... that actually doesn't get us anywhere,
it was obvious that it was an EOL issue based on the error you provided,
and the two assignments I manually did is exactly what we get when we use os.EOL,
but at least I was able to confirm the issue.
can you perhaps try setting:
const EOL = '\n';

at your end?

Sure
I install and run tests this way.
npm i
npm run test

This is what I'm getting
C:\Users\dolevb\Downloads\Personal\auto-me-bot>npm run tests
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.

><EMAIL_ADDRESS>tests
> mocha --check-leaks --fail-zero --color --parallel --ui tdd --recursive ./tests/

  Testing the pr-tasks-list handler
    1) Test with all tasks checked, expect the check to pass with a summary of the completed tasks
    2) Test with unchecked tasks, expect the check to fail with a report of the not yet completed tasks
    ✔ Test with not tasks, expect the check to fail providing notification indicating no tasks found

  Testing the pr-signed-commits handler
    ✔ Test with one commit signed by the author, expect a successful check run
    ✔ Test with one commit signed by the committer, expect a successful check run
    ✔ Test with two commits signed by the author, expect a successful check run
    ✔ Test with one commit signed by someone else (not author/committer), expect a failed check run
    ✔ Test with one unsigned commit, expect a failed check run
    ✔ Test with two commits, one unsigned and one signed by the author, expect a failed check run
    ✔ Test with one commit signed by the author, with a SMTPConnectionError service error, expect a failed check run
    ✔ Test with one commit signed by the author, with a SMTPConnectionTimeout service error, expect a failed check run
    ✔ Test with one commit signed by the author, with a domainNotFound service error, expect a failed check run
    ✔ Test with one commit signed by the author, with a invalidEmailStructure service error, expect a failed check run
    ✔ Test with one commit signed by the author, with a noMxRecords service error, expect a failed check run
    ✔ Test with one commit signed by a Bot, not author or committer, expect a successful check run

  Testing the auto-me-bot export
    ✔ When invoking the application, expect a registration of the events
    Test various pull request related configurations
      ✔ When all PR operations are checked, execute all PR related handlers
      ✔ When the conventionalCommits operation is checked, execute the related handler
      ✔ When the signedCommits operation is checked, execute the related handler
      ✔ When the tasksList operation is checked, execute the related handler
      ✔ When no operations is checked and config is {"pr":{}}, do not execute any handlers
      ✔ When no operations is checked and config is {}, do not execute any handlers
      ✔ When no operations is checked and config is null, do not execute any handlers

  Testing the pr-conventional-commits handler
    3) Test with one warning commit message, expect one warning report
    ✔ Test with one error commit message, expect one error report (140ms)
    ✔ Test with one good commit message, expect a successful result
    4) Test with one warning, one error, and one good commit message, expect a report for warning and error
    5) Test with one error and custom commit configuration, expect a report error on custom violation

  23 passing (2s)
  5 failing

  1) Testing the pr-tasks-list handler
       Test with all tasks checked, expect the check to pass with a summary of the completed tasks:
     AssertionError: expected repo to have been called with arguments {
  check_run_id: 13,
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  conclusion: 'success',
  output: {
    title: 'All Done!',
    summary: 'You made it through',
    text: "### Here's a list of your accomplishments\r\n- task 1\r\n- task 2\r\n- task 3"
  }
}
Call 1:
{
  head_sha: '#f54dda543@',
  name: 'Auto-Me-Bot Tasks List',
  details_url: 'https://auto-me-bot.tomfi.info',
  started_at: '2022-08-08T07:42:40.333Z',
  status: 'in_progress'
  check_run_id: 13,
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  conclusion: 'success',
  output: {
    title: 'All Done!',
    summary: 'You made it through',
    text: "### Here's a list of your accomplishments\r\n- task 1\r\n- task 2\r\n- task 3"
  }
}
Call 2:
{
  check_run_id: 13,
  name: 'Auto-Me-Bot Tasks List',
  details_url: 'https://auto-me-bot.tomfi.info',
  started_at: '2022-08-08T07:42:40.333Z',
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  conclusion: 'success',
  completed_at: '2022-08-08T07:42:40.349Z',
  output: {
    title: 'All Done!',
    summary: 'You made it through',
    text: "### Here's a list of your accomplishments\r\n" +
      '- task 1\r\r\n' +
      '- task 2\r\r\n' +
      '- task 3'
    text: "### Here's a list of your accomplishments\r\n- task 1\r\n- task 2\r\n- task 3"
  }
}
      at Context.<anonymous> (tests\handlers\pr-tasks-list.test.js:182:42)

  2) Testing the pr-tasks-list handler
       Test with unchecked tasks, expect the check to fail with a report of the not yet completed tasks:
     AssertionError: expected repo to have been called with arguments {
  check_run_id: 13,
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  conclusion: 'failure',
  output: {
    title: 'Found 2 unchecked tasks',
    summary: "I'm sure you know what do with these",
    text: '### The following tasks needs to be completed\r\n- task 2\r\n- task 3'
  }
}
Call 1:
{
  head_sha: '#f54dda543@',
  name: 'Auto-Me-Bot Tasks List',
  details_url: 'https://auto-me-bot.tomfi.info',
  started_at: '2022-08-08T07:42:40.360Z',
  status: 'in_progress'
  check_run_id: 13,
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  conclusion: 'failure',
  output: {
    title: 'Found 2 unchecked tasks',
    summary: "I'm sure you know what do with these",
    text: '### The following tasks needs to be completed\r\n- task 2\r\n- task 3'
  }
}
Call 2:
{
  check_run_id: 13,
  name: 'Auto-Me-Bot Tasks List',
  details_url: 'https://auto-me-bot.tomfi.info',
  started_at: '2022-08-08T07:42:40.360Z',
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  conclusion: 'failure',
  completed_at: '2022-08-08T07:42:40.360Z',
  output: {
    title: 'Found 2 unchecked tasks',
    summary: "I'm sure you know what do with these",
    text: '### The following tasks needs to be completed\r\n- task 2\r\r\n- task 3'
    text: '### The following tasks needs to be completed\r\n- task 2\r\n- task 3'
  }
}
      at Context.<anonymous> (tests\handlers\pr-tasks-list.test.js:182:42)

  3) Testing the pr-conventional-commits handler
       Test with one warning commit message, expect one warning report:
     AssertionError: expected repo to have been called with arguments {
  check_run_id: 13,
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  conclusion: 'success',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  output: {
    title: 'Found 1 non-conventional commit message',
    summary: 'Take a look at these',
    text: '### https://fake.commit.url/#f54dda543@\r\n' +
      '```\r\n' +
      'chore: unit test this thing\r\n' +
      '\r\n' +
      'missing line break\r\n' +
      '```\r\n' +
      '#### Warnings\r\n' +
      '| name | level | message |\r\n' +
      '| - | - | - |\r\n' +
      '| body-leading-blank | 1 | body must have leading blank line |'
  }
}
Call 1:
{
  head_sha: '#f54dda543@',
  name: 'Auto-Me-Bot Conventional Commits',
  details_url: 'https://auto-me-bot.tomfi.info',
  started_at: '2022-08-08T07:42:40.613Z',
  status: 'in_progress'
  check_run_id: 13,
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  conclusion: 'success',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  output: {
    title: 'Found 1 non-conventional commit message',
    summary: 'Take a look at these',
    text: '### https://fake.commit.url/#f54dda543@\r\n' +
      '```\r\n' +
      'chore: unit test this thing\r\n' +
      '\r\n' +
      'missing line break\r\n' +
      '```\r\n' +
      '#### Warnings\r\n' +
      '| name | level | message |\r\n' +
      '| - | - | - |\r\n' +
      '| body-leading-blank | 1 | body must have leading blank line |'
  }
}
Call 2:
{
  check_run_id: 13,
  name: 'Auto-Me-Bot Conventional Commits',
  details_url: 'https://auto-me-bot.tomfi.info',
  started_at: '2022-08-08T07:42:40.613Z',
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  conclusion: 'success',
  completed_at: '2022-08-08T07:42:40.889Z',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  output: {
    title: 'Found 1 non-conventional commit message',
    summary: 'Take a look at these',
    text: '### https://fake.commit.url/#f54dda543@\r\n' +
      '```\r\n' +
      'chore: unit test this thing\n' +
      '\n' +
      'chore: unit test this thing\r\n' +
      '\r\n' +
      'missing line break\r\n' +
      '```\r\n' +
      '#### Warnings\r\n' +
      '| name | level | message |\r\n' +
      '| - | - | - |\r\n' +
      '| body-leading-blank | 1 | body must have leading blank line |'
  }
}
      at Context.<anonymous> (tests\handlers\pr-conventional-commits.test.js:355:42)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

  4) Testing the pr-conventional-commits handler
       Test with one warning, one error, and one good commit message, expect a report for warning and error:
     AssertionError: expected repo to have been called with arguments {
  check_run_id: 13,
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  conclusion: 'failure',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  output: {
    title: 'Found 2 non-conventional commit messages',
    summary: 'We need to amend these commits messages',
    text: '### https://fake.commit.url/#f54dda543@\r\n' +
      '```\r\n' +
      "it doesn't matter what you stash\r\n" +
      '```\r\n' +
      '#### Errors\r\n' +
      '| name | level | message |\r\n' +
      '| - | - | - |\r\n' +
      '| subject-empty | 2 | subject may not be empty |\r\n' +
      '| type-empty | 2 | type may not be empty |\r\n' +
      '### https://fake.commit.url/#f54dda543@\r\n' +
      '```\r\n' +
      'chore: unit test this thing\r\n' +
      '\r\n' +
      'missing line break\r\n' +
      '```\r\n' +
      '#### Warnings\r\n' +
      '| name | level | message |\r\n' +
      '| - | - | - |\r\n' +
      '| body-leading-blank | 1 | body must have leading blank line |'
  }
}
Call 1:
{
  head_sha: '#f54dda543@',
  name: 'Auto-Me-Bot Conventional Commits',
  details_url: 'https://auto-me-bot.tomfi.info',
  started_at: '2022-08-08T07:42:41.071Z',
  status: 'in_progress'
  check_run_id: 13,
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  conclusion: 'failure',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  output: {
    title: 'Found 2 non-conventional commit messages',
    summary: 'We need to amend these commits messages',
    text: '### https://fake.commit.url/#f54dda543@\r\n' +
      '```\r\n' +
      "it doesn't matter what you stash\r\n" +
      '```\r\n' +
      '#### Errors\r\n' +
      '| name | level | message |\r\n' +
      '| - | - | - |\r\n' +
      '| subject-empty | 2 | subject may not be empty |\r\n' +
      '| type-empty | 2 | type may not be empty |\r\n' +
      '### https://fake.commit.url/#f54dda543@\r\n' +
      '```\r\n' +
      'chore: unit test this thing\r\n' +
      '\r\n' +
      'missing line break\r\n' +
      '```\r\n' +
      '#### Warnings\r\n' +
      '| name | level | message |\r\n' +
      '| - | - | - |\r\n' +
      '| body-leading-blank | 1 | body must have leading blank line |'
  }
}
Call 2:
{
  check_run_id: 13,
  name: 'Auto-Me-Bot Conventional Commits',
  details_url: 'https://auto-me-bot.tomfi.info',
  started_at: '2022-08-08T07:42:41.071Z',
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  conclusion: 'failure',
  completed_at: '2022-08-08T07:42:41.206Z',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  output: {
    title: 'Found 2 non-conventional commit messages',
    summary: 'We need to amend these commits messages',
    text: '### https://fake.commit.url/#f54dda543@\r\n' +
      '```\r\n' +
      "it doesn't matter what you stash\r\n" +
      '```\r\n' +
      '#### Errors\r\n' +
      '| name | level | message |\r\n' +
      '| - | - | - |\r\n' +
      '| subject-empty | 2 | subject may not be empty |\r\n' +
      '| type-empty | 2 | type may not be empty |\r\n' +
      '### https://fake.commit.url/#f54dda543@\r\n' +
      '```\r\n' +
      'chore: unit test this thing\n' +
      '\n' +
      'chore: unit test this thing\r\n' +
      '\r\n' +
      'missing line break\r\n' +
      '```\r\n' +
      '#### Warnings\r\n' +
      '| name | level | message |\r\n' +
      '| - | - | - |\r\n' +
      '| body-leading-blank | 1 | body must have leading blank line |'
  }
}
      at Context.<anonymous> (tests\handlers\pr-conventional-commits.test.js:379:38)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

  5) Testing the pr-conventional-commits handler
       Test with one error and custom commit configuration, expect a report error on custom violation:
     AssertionError: expected repo to have been called with arguments {
  check_run_id: 13,
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  conclusion: 'failure',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  output: {
    title: 'Found 1 non-conventional commit message',
    summary: 'We need to amend these commits messages',
    text: '### https://fake.commit.url/#f54dda543@\r\n' +
      '```\r\n' +
      'chore: unit test this thing\r\n' +
      '\r\n' +
      'Lorem ipsum dolor sit amet\r\n' +
      '```\r\n' +
      '#### Errors\r\n' +
      '| name | level | message |\r\n' +
      '| - | - | - |\r\n' +
      "| body-max-line-length | 2 | body's lines must not be longer than 10 characters |"
  }
}
Call 1:
{
  head_sha: '#f54dda543@',
  name: 'Auto-Me-Bot Conventional Commits',
  details_url: 'https://auto-me-bot.tomfi.info',
  started_at: '2022-08-08T07:42:41.209Z',
  status: 'in_progress'
  check_run_id: 13,
  name: { test: [Function (anonymous)], message: 'typeOf("string")' },
  details_url: { test: [Function (anonymous)], message: 'match(undefined)' },
  started_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  status: 'completed',
  conclusion: 'failure',
  completed_at: { test: [Function (anonymous)], message: 'match(undefined)' },
  output: {
    title: 'Found 1 non-conventional commit message',
    summary: 'We need to amend these commits messages',
    text: '### https://fake.commit.url/#f54dda543@\r\n' +
      '```\r\n' +
      'chore: unit test this thing\r\n' +
      '\r\n' +
      'Lorem ipsum dolor sit amet\r\n' +
      '\n' +
      'chore: unit test this thing\r\n' +
      '\r\n' +
      'Lorem ipsum dolor sit amet\r\n' +
      '```\r\n' +
      '#### Errors\r\n' +
      '| name | level | message |\r\n' +
      '| - | - | - |\r\n' +
      "| body-max-line-length | 2 | body's lines must not be longer than 10 characters |"
  }
}
      at Context.<anonymous> (tests\handlers\pr-conventional-commits.test.js:406:38)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

@TomerFi I also immediately suspected on the EOL and even tried your suggestion.
The results are the same.
I did this:
    const errorCommitMessageBody = 'Lorem ipsum dolor sit amet';
    const longCommitBodyMsg = `${goodCommitMessage}${'\n'}${'\n'}${errorCommitMessageBody}`;
    const oneErrorCustom_commitsListResponse = {
        data: [
            {
                html_url: fakeCommitUrl,
                commit: {
                    message: longCommitBodyMsg
                }
            },
        ]
    }

    const oneErrorCustom_expectedUpdateCheck = {
        check_run_id: fakeCheckId,
        name: sinon.match.string,
        details_url: sinon.match(u => new URL(u)),
        started_at: sinon.match(t => Date.parse(t)),
        status: 'completed',
        conclusion: 'failure',
        completed_at: sinon.match(t => Date.parse(t)),
        output: {
            title: 'Found 1 non-conventional commit message',
            summary: 'We need to amend these commits messages',
            text: [
                `### ${fakeCommitUrl}`,
                '```',
                goodCommitMessage + '\n',
                errorCommitMessageBody,
                '```',
                '#### Errors',
                '| name | level | message |',
                '| - | - | - |',
                '| body-max-line-length | 2 | body\'s lines must not be longer than 10 characters |'
            ].join('\n')
        }
    }

I have Win machine if you want to have a live session.


🚀 - Auto Day/Night Mode

Which @codeimage/* package(s) are relevant/releated to the feature request?
Don't known / other
Description
Currently I only have choices for dark/night and light/day themes for codeimage, but my current setup automatically follows day and night by switching theme when the sun goes up and down so it is very annoying to always switch between the two.
So could an option for codeimage to follow system theme be added?

Available with 1.1.6 release 😄


New Feature: Add all-contributors-bot

Purpose: To automate acknowledging contributors to our open source projects.
Solution: Add all-contributors-bot
App: https://github.com/apps/allcontributors
Repo: https://github.com/all-contributors
Doc: https://allcontributors.org/docs/en/bot/installation

@all-contributors please add @shubham-kaushal

@all-contributors please add @shubham-kaushal

@all-contributors please add @shubham-kaushal for bug, business, design, doc, ideas, research and test.

@all-contributors please add @shubham-kaushal for bug, business, design, doc, ideas, research and test.

@all-contributors please add @ovr for doc

@all-contributors please add @ovr for doc

@all-contributors please add @katrinLuna for doc, test, bug, and ideas.

@all-contributors please add @katrinLuna for doc, test, bug, and ideas.

@all-contributors please add @timeshift92 for test, bug, and ideas.

@all-contributors please add @timeshift92 for test, bug, and ideas.

@all-contributors please add @andrey-skl for bug and ideas.

@all-contributors please add @andrey-skl for bug and ideas.

@all-contributors please add @tenphi  for code, bug, business, design, doc, ideas, research and test.

@all-contributors please add @tenphi  for code, bug, business, design, doc, ideas, research and test.

@all-contributors please add @YakovlevCoded for ideas and test.

@all-contributors please add @YakovlevCoded for ideas and test.


edit to tukey test #2

Can you remove all rows in the Tukey's ANOVA table except for 'sq.pred'? If not, add subtitle to 'Tukey's Test for Nonadditivity': 'Attention: refer only to 'sq.pred' in this table - ignore all other rows'

I'll add the attention for now as that is easy.


[video_player] black borders around video

Steps to reproduce
just run an example app
i know that this issue might be duplicate of #72508 , but i don't get how to fix it
its happens only on android, on some devices, for example on Xiaomi MI 13 and POCO F5
Expected results
no black borders
Actual results
black borders, which is looks weird
Code sample
Code sample
example app

Screenshots or Video

Screenshots / Video demonstration
https://github.com/user-attachments/assets/34c6e862-dd86-4091-ab68-1ed325f617bc

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.3, on macOS 14.6.1 23G93 darwin-arm64, locale
    en-BG)
    • Flutter version 3.24.3 on channel stable at /Users/ivantonev/dev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (6 weeks ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/ivantonev/Library/Android/sdk
    • Platform android-35, build-tools 34.0.0
    • ANDROID_HOME = /Users/ivantonev/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16A242d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.94.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.98.0

[✓] Connected device (5 available)
    • Ivan’s Iphone (mobile)          • 87c7899fc15348534b00a14a5f70a08f0a40805d • ios            • iOS 16.7.10 20H350
    • Tseh85 (mobile)                 • 3E67F860-1434-4009-91A8-B03764D84898     • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
    • macOS (desktop)                 • macos                                    • darwin-arm64   • macOS 14.6.1 23G93 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                    • darwin         • macOS 14.6.1 23G93 darwin-arm64
    • Chrome (web)                    • chrome                                   • web-javascript • Google Chrome 130.0.6723.60
    ! Error: Apple Watch — Ivan needs to connect to determine its availability. Check the connection between the device and its
      companion iPhone, and the connection between the iPhone and Xcode. Both devices may also need to be restarted and unlocked.
      (code 1)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Thanks for the report @JILTB
I do see the same behavior after cloning your repo and then running on S10+ device (Android 12). Interestingly, if I run the same app in emulator, it doesn't show the black border.
From your app, I see that you are rendering the videos from assets. Can you test with a network url to check if the behavior still persist or not ?

@darshankawar first video was copied from URL
same behaviour with it.

screenshot from real published application.

Can you try the plugin example on same device to check if they show such behavior ?

Can you try the plugin example on same device to check if they show such behavior ?

no black borders.

Thanks for the update. As verified earlier as well, I am able to replicate this on S10+ device. The black borders aren't shown when running the same code on emulator. The same works properly on iOS. So this seems to be specific to Android devices only.
stable : 3.24.3
master : 3.27.0-1.0.pre.231

in my case
H.264 (Main)   have black bar
H.264 (Constrained Baseline) is ok

What is a fix around this I'm facing this in many Redmi & pixel phones as well. @darshankawar


package_cache is nil sometimes.

Hi, from time to time, when I open Neovim, I get this error:
Error detected while processing BufWinEnter Autocommands for "*":
Error executing lua callback: ...re/nvim/lazy/LuaSnip/lua/luasnip/loaders/from_vscode.lua:329: attempt to index upvalue 'package_cache' (a nil value)
stack traceback:
        ...re/nvim/lazy/LuaSnip/lua/luasnip/loaders/from_vscode.lua:329: in function '_load_lazy_loaded'
        ...local/share/nvim/lazy/LuaSnip/plugin/luasnip.lua:103: in function <.../.local/share/nvim/lazy/LuaSnip/plugin/luasnip.lua:102>

I use the default setting for Luasnip and nothing special. I can't understand the concrete steps to 100% reproduce the issue. I can say that when the problem has happened when reopening Neovim for a second or third time helps.

Oh that should not be nil.. is it possible you have another version of luasnip floating around (ie. in runtimepath), maybe installed with a different package-manager?

That was a good point from you. After I migrated from packer to lazy, I forgot to clean up some packages in pack/packer/ folder. These packages are not presented in runtimepath, so it was not evident that they still exist. So, I manually removed all leftovers, and the issue has been resolved. Thank you.

I experienced this same issue. The old pack folder was hiding in ~/.local/share/nvim/site, which was included in the runtimepath and was very easy to overlook.


[WIP] add eos to makefile

[x] add changelog
[ ] requires https://github.com/owncloud/ocis-reva/pull/127
[ ] get others to run make eos-start and report back

we can merge this but it requires using a newer version of ocis-reva to actually work: owncloud/ocis-reva#125

I had to add explicit eos commands to preconfigure eos correctly, so now we depen on https://github.com/owncloud/ocis-reva/pull/127

@ownclouders rebase

@butonic Fine for now.

For the sake of completeness, these are the things you need to do to get it running on macOS, @mbarz

in Makefile line 195, where the LDAP_HOST is set, set host.docker.internal as LDAP_HOST
run make eos-start. It will exit with an error, but the containers will be running. That's what's important.
build ocis for linux like this: env GOOS=linux GOARCH=amd64 go build -o bin/ocis-linux ./cmd/ocis and copy it into the eos-cli1 docker container like this docker cp ./bin/ocis-linux eos-cli1:/usr/local/bin/ocis
stop everything with make eos-stop
since the linux binary has been copied in step 3, you can just start eos again with make eos-start.
testing: https://localhost:9200/

Although eos will be running successfully then, it still fails to create any user home when running from macOS. This results in an access denied error on the user login page. I'm happy to help out debugging this, but since it's deep into eos, I lack the knowledge to do this efficiently.


Fuge step

It should be great to have one (final?) step explaining how to use Fuge (https://github.com/apparatus/fuge) for generating execution environment.

I would avoid to do it here since the focus here is on seneca itself. Adding that step to seems a little bit out of scope.

so what's your thought about it @marcopiraccini ?

Well, I'd still like to have a "final" step with it, to show how "real" microservices can be created, but we have to figure out how that can be verified.
Maybe we simply describe how to create it and simply verify from the client point-of-view (assuming that if it works, the service has been created with fuge).

I agree with @piccoloaiutante. Fuge is just one possible implementation that uses Seneca. There is no reason to make it look like it's part of Seneca.
Adding a Fuge step would be like... adding React to a Javascript tutorial, if you know what I mean.


Using pre-trained models

Hello, thank you for the great work.
I used this script to run the pre-training for MLM task: https://github.com/shabie/docformer/blob/master/examples/docformer_pl/3_Pre_training_DocFormer_Task_MLM_Task.ipynb
Afterwards, I used the resulting model in the token-classification task. ( using load_from_check_point which copies all the weight except the linear layer which has a different shape).
The problem is that no matter how much I run the pre-training, I always get the same metrics in the token-classification task (using that pre-trained model as a starting point).
I even tried the model from document-classification task as a base for token classification and I still the get same exact metrics as the results I was getting from using the MLM-pretrained task.
Any suggestion on how to properly use the pre-trained models?

Not sure, how to go about it. Because I tried for just a few samples of documents. I think, there is something which saturates the entire training, would look for it, in a few days.

thanks for the quick response! ok

Can you let me know, what approach did you try? I guess, it would be helpful for me as well, to conduct the experiment

first, I ran the MLM task and got the pre-trained model. In the token_cls task, after model init (docformer = DocFormer(config)), I used load_from_checkpoint to load the pre-trained model ( had to override on_load_checkpoint to skip copying layers with mismatch size, which were the weights and biases for linear layer). then started training the model.

Got it. Thanks, and would update here, as soon as possible

Hi @HoomanKhosravi, I did try to train the docformer on the FUNSD dataset from scratch.
Here is the script, Kaggle Notebook, and here are the results Weight and Bias Report
When we see the results, the model is overfitting the train data and can obtain 100 percentage results on each of those metrics but around 30 percentage on the validation set (refer to the kaggle notebook's last section). In order to obtain good metrics for the validation dataset, I think some tricks to prevent overfitting can help. Were you getting similar results?
Regards,
Akarsh

Hi, nope, I haven't tried to pre-train and then fine-tune it, but I am planning to do it in a few days and then observe the results. I guess, I have been able to write scripts for pre-training, so I would get back here, as soon as possible
Regards,
Akarsh

Hi,
I am also facing the exact same issue where model is overfitting on the training dataset. Did you have any luck?

I guess pre-training would help, I have managed to prepare a small data for pre-training. It is actually IDL Dataset (https://github.com/furkanbiten/idl_data) and in some time I am about to train and get the results.

Thank you for the prompt response. However, I am wondering how pertaining would help here since there is no attempt to save either embedding features (layoutLM) or visual features(ResNet)

I am looking at the approach in this way, if the model can overfit that means, the implementation is going in the right direction. Now, the idea of pre-training came, because in the paper as well, the authors mentioned about pre-training on a large data gave them good results. So, that was the reason, pre-training came in mind

Although, I didn't get, when you say "there is no attempt to save the embedding features or visual features"

My bad. I misunderstood your earlier comment.
If you see any improvement with the pertaining, would you be able to share the pertained weights?

@uakarsh , any luck with the pre-training?

Not till now (since busy with one of my research work)

Hi @riteshKumarUMass @HoomanKhosravi, can you guys again try the fine-tuning using the pre-trained weights (I have attached them in the readme)


B 18793 trdm usprc data dump main (DO NOT MERGE BEFORE 18794)

Integration PR

@deandreJones Upstreams are g2g, just need boss man's stamp

rerunning pipeline


zowecli-cobol-upload-run-tutorial job error

Hello,
I am currently working with Wazi, Zowe, and IBM Open Editor. I do not have much experience with mainframes and their technology stack.
I was able to run some sample scripts in this project.
zowe/zowecli-cobol-upload-run-tutorial.sh

When the scripts run, the job gets submitted and runs. It has an error, though.
ICH70001I IBMUSER  LAST ACCESS AT 03:40:42 ON THURSDAY, MARCH 23, 2023
IEFA111I SAMRUN IS USING THE FOLLOWING JOB RELATED SETTINGS:
         SWA=BELOW,TIOT SIZE=64K,DSENQSHR=DISALLOW,GDGBIAS=JOB
IEFA107I SAMRUN CMPLSAM2 STEPLIB - DATA SET IGY630.SIGYCOMP NOT FOUND
IEF272I SAMRUN CMPLSAM2 - STEP WAS NOT EXECUTED.
IEF373I STEP/CMPLSAM2/START 2023082.0340
IEF032I STEP/CMPLSAM2/STOP  2023082.0340
        CPU:     0 HR  00 MIN  00.00 SEC    SRB:     0 HR  00 MIN  00.00 SEC
        VIRT:     0K  SYS:     0K  EXT:        0K  SYS:        0K
        ATB- REAL:                    20K  SLOTS:                     0K
             VIRT- ALLOC:      10M SHRD:       0M
IEF375I  JOB/SAMRUN  /START 2023082.0340
IEF033I  JOB/SAMRUN  /STOP  2023082.0340
        CPU:     0 HR  00 MIN  00.00 SEC    SRB:     0 HR  00 MIN  00.00 SEC

It seems that IGY630.SIGYCOMP is not in the most current version of Wazi.
I am running the ibm-zos-2-4-s390x-dev-test-wazi-7 image.
Any idea which data set I can use instead?
I also found this in JCL/RUN.jcl file.
//* IT MIGHT ALSO BE NECESSARY TO UPDATE THE COBOL COMPILER LIBRARY
//* IF YOUR SYSTEM USES A DIFFERENT VERSION.
//*
//* THE LINK LIBRARY MAY NEED TO BE UPDATED IF YOUR SYSTEM HAS IT
//* INSTALLED UNDER A DIFFERENT DATASET NAME.

//*
//*****************************************************************
//    SET HLQ='IBMUSER'                       *TSO USER ID
//    SET CMPLLIB='IGY630.SIGYCOMP'           *COMPILER LIBRARY
//    SET LINKLIB='CEE.SCEELKED'              *LINK LIBRARY
//    SET SPACE1='SYSALLDA,SPACE=(CYL,(1,1))' *SPACE ALLOCATION
//    SET SPACE2='SYSALLDA,SPACE=(CYL,(1,1))' *SPACE ALLOCATION

It looks like I just need to find the proper compiler library for this version of Wazi. I am not sure how to do that.
Thanks for the help. :-)

I asked the right person in our organization. He said to try IGY.V6R4M0.SIGYCOMP instead of IGY630.SIGYCOMP, and magically, it worked.
Once I figure out how he knew that, I will share the information here.


Blazor gRPC guidance

Fixes #18850
Internal Review Topic (links to section)
This is a challenge to cover without getting into the weeds. What I'd like to do is provide the minimum viable coverage for the scenario and not maintain a sample app. I have no gRPC experience, so I can't tell if enough is covered. Is what I have on the PR enough? If we need to show more, what else is needed?

@mkArtakMSFT ... This is ready AFAIK.

@JamesNK ... How do you want the catch composed?
try
{
    var request = new HelloRequest { Name = name };
    var reply = await GreeterClient.SayHelloAsync(request);
    serverResponse = reply.Message;
}
catch (RpcException ex)
{
    // ex.Status.DebugException
}

@JamesNK ... Show the try-catch like that :point_up: ... or something else?
I think that's the last thing here to resolve before merging this one.

Paging Mr. @JamesNK ... Mr. @JamesNK, please pick up a courtesy telephone. :smile:
I think this only needs a look at what to show in the catch, or we can just show that. :point_up:

Sorry for the delay, I wanted to test this for myself.
I confirmed that this works:
try
{
    var request = new HelloRequest { Name = name };
    var reply = await GreeterClient.SayHelloAsync(request);
    serverResponse = reply.Message;
}
catch (Grpc.Core.RpcException ex) when (ex.Status.DebugException is AccessTokenNotAvailableException tokenEx)
{
    tokenEx.Redirect();
}

The docs should mention that Grpc.Net.Client 2.30.0 or later should be used. That version added ex.Status.DebugException property.


Components/cicd use schema

Closes #958

Change the PR to be against the main branch?

Change the PR to be against the main branch?

All of the previous PR have been to blueprints branch. I think it makes sense since defaults have been manipulated for blueprints purposes.
If done to master branch, the mapping to defaults has to be done again anyways.


Unable to change port in Rasa when dockerized

Rasa NLU version (e.g. 0.7.3): 0.10.0
Used backend / pipeline (mitie, spacy_sklearn, ...): spacy_duckling
Operating system (windows, osx, ...): debian
Issue:
I'm new with Rasa and docker. My attempt to dockerize Rasa-NLU consists of the below steps: Instructions were referred from here

Did a Git clone of latest Rasa-NLU
Copied Dockerfile_full (from within /docker) to the root directory
Changed the port number specified in config_default.json and Dockerfile_full from default(5000) to 5048.
Build done using: docker build -t rasa_nlu .
Run the docker on a port(5048) different from the default(5000) port.

However, the following gets logged in the console:
INFO:rasa_nlu.data_router:Logging requests to '/app/logs/rasa_nlu_log-20170928-091903-1.log'.  My doubts on whether a wrong port was being referred were confirmed when checked within docker container (using docker exec)it was running on port 5000.
Can someone help me out here as to where exactly I'm going wrong and where should the port number be configured ?
Thanks in advance!
Note: Added the same issue at SO as well
Content of configuration file (if used & relevant):

Dockerfile_full expects the config file to be in the sample_configs folder. Also Dockerfile_full uses the config_spacy_duckling.json config file. So make sure you replace the below reference in the dockerfile.
COPY sample_configs/config_spacy_duckling.json ${RASA_NLU_HOME}/config.json
Ignoring that, why change the ports in both locations? All you need to do is change it in your docker run or compose command.
docker run -p 5048:5000 rasa/rasa_nlu:latest-full

Hi I figured out from SO that I just needed to set the port explicitly inside sample_configs/config_spacy_duckling. Now that it works, I'm closing this.
Thanks!


Fix unique constraint error of generated columns

Using a unique constraint on a "GENERATED ALWAYS AS ( generation_expr ) STORED" - column, gives you:
Error: Unique constraint "_the_key" violated for
model "model" on fields (_field) with values ().

This is because
const values = constraint.fields.map((c) => props.modelData[c]);
is [ undefined ], in this case.
Suggested fix by doing this update to constraints.ts:
before:
  for (const constraint of sortedConstraints) {
    // We skip the constraint if it contains null values
    if (
      constraint.fields.some((c) => props.modelData[c] === null)

after:
for (const constraint of sortedConstraints) {
    // We skip the constraint if it contains null values
    if (
      constraint.fields.some((c) => props.modelData[c] === null || props.modelData[c] === undefined)

@martinsellergren Would you consider opening a PR to fix this?

@martinsellergren Would you consider opening a PR to fix this?

Sure, but unfortunately not gonna have the time to write tests. Would you add me as a collaborator and I'll do it.


Disable parallel reading for gziped ndjson file

Which issue does this PR close?

Closes #9564
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Thanks again @Lordworms  and @Dandandan 🙏


az webapp config appsettings set --settings endpoints:api=https://example.com returns bad request when containing colon in the name

This is autogenerated. Please review and update as needed.
Describe the bug
I have a .net core web API with some app settings. These app settings are in a json structure, ie.
{
  "endpoints": {
       "api":"https://example.com"
    }
}

When settings this app setting via. the Azure Portal, i would set the name to endpoints:api and the value to https://example.com and this works fine.
Doing in via the CLI, this is not allowed.
Command Name
az webapp config appsettings set
Errors:
Operation returned an invalid status code 'Bad Request'

msrest.http_logger : Response content:
msrest.http_logger : {"Code":"BadRequest","Message":"AppSetting with name 'endpoints:api' is not allowed.","Target":null,"Details":[{"Message":"AppSetting with name 'endpoints:api' is not allowed."},{"Code":"BadRequest"},{"ErrorEntity":{"ExtendedCode":"04072","MessageTemplate":"AppSetting with name '{0}' is not allowed.","Parameters":["endpoints:api"],"Code":"BadRequest","Message":"AppSetting with name 'endpoints:api' is not allowed."}}],"Innererror":null}
msrest.exceptions : Operation returned an invalid status code 'Bad Request'

To Reproduce:

az webapp config appsettings set --resource-group {} --name {} --settings endpoints:api=https://example.com --debug

Expected Behavior
Should set an app setting
Environment Summary
Darwin-18.6.0-x86_64-i386-64bit
Python 3.7.3
Shell: bash

azure-cli 2.0.67 *

Additional Context

@panchagnula can you take a look at this one

@mratrifork please follow the examples in the documentation on using the --settings, the command excepts a KEY=VALUE format. in your case the key is "endpoints" & value is "{'api': 'https://example.com'}"
So run the command as
az webapp config appsettings set -n{} -g {}  --settings endpoints="{'api': 'https://example.com'}"
or use a json file with the settings with say name appsettings.json
{
"endpoints": {
"api":"https://example.com"
}
}
& run command as
az webapp config appsettings set -n {} -g{} --settings @appsettings.json

please follow the examples in the documentation on using the --settings, the command excepts a KEY=VALUE format. in your case the key is "endpoints" & value is "{'api': 'https://example.com'}" So run the command as az webapp config appsettings set -n{} -g {} --settings endpoints="{'api': 'https://example.com'}"

@panchagnula this does not seem quite right. Why would changing a setting in the Portal be allowed, but not if I change it from the cli?
When configuring the keys in Portal and az webapp config appsettings list --name {} -g {} it shows as follows:
  {
    "name": "AzureAd:CallbackPath",
    "slotSetting": false,
    "value": "/signin-oidc"
  },

But when I try to set this via az webapp config appsettings set --resource-group {} --name {} --settings 'AzureAd={ "CallbackPath": "/signin-oidc" }' as you suggested, it turns up as:
  {
    "name": "AzureAd",
    "slotSetting": false,
    "value": "{ \"CallbackPath\": \"/signin-oidc\" }"
  },

Am I doing something wrong? Are you saying this should be equivalent?


add violation msg to order on violation

return bool on place order based on validation

Coverage increased (+0.01%) to 93.769% when pulling 835be3e637f4ac031e488617e35a5cdc2c18b262 on task/297-improve-voilation-logging into 65a33d785350d9cfdfa8a9184372e41c23235d10 on master.


feat(napi/parser): change parse API to accept mandatory filename and optional lang

#7605  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Replace deprecated command with environment file

Description
Resolve  #450
Update .github/actions/create-minikube-cluster/action.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
I found the workflow file that use set-output command through the following command:
$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS
echo "::set-output name=version::$(minikube version --short)"

TO-BE
echo "version=$(minikube version --short)" >> $GITHUB_OUTPUT

/ok-to-test
/lgtm
/assign @mresvanis

/approve


e2e: no secret found for service account in ocp 4.14

Running e2e tests on an ocp 4.14 cluster, the e2e failed with:
Testing ManagedCluster Testing Clusterca sync Get CA from service account
/go/src/github.com/stolostron/multicloud-operators-foundation/test/e2e/managedcluster_test.go:158
  [FAILED] in [It] - /go/src/github.com/stolostron/multicloud-operators-foundation/test/e2e/managedcluster_test.go:164 @ 11/10/23 02:43:19.359
• [FAILED] [0.020 seconds]
Testing ManagedCluster Testing Clusterca sync [It] Get CA from service account
/go/src/github.com/stolostron/multicloud-operators-foundation/test/e2e/managedcluster_test.go:158
  [FAILED] Unexpected error:
      <*errors.errorString | 0xc000b338f0>:
      secret with type kubernetes.io/service-account-token not found in service account kube-system/default
      {
          s: "secret with type kubernetes.io/service-account-token not found in service account kube-system/default",
      }
  occurred
  In [It] at: /go/src/github.com/stolostron/multicloud-operators-foundation/test/e2e/managedcluster_test.go:164 @ 11/10/23 02:43:19.359

root cause: Starting Kubernetes 1.24, Secrets are not automatically generated when Service Accounts are created.


chore(headless-client): add a placeholder IPC server for Windows

### Before merging
- [ ] Add a unit test that runs the IPC server with a stub client in CI
- [ ] If any files shared with Linux changed, run the manual smoke test for Linux
- [ ] Make sure headless Client does not busy-loop (I changed its main loop slightly)
- [ ] Make sure IPC service does not busy-loop
- [ ] Test standalone headless on Linux
- [ ] Test standalone headless on Windows
- [ ] Test debug IPC service on Linux
- [ ] Test debug IPC service on Windows
- [ ] Test GUI + systemd IPC service on Linux
- [ ] Test GUI + SC IPC service on Windows

Regardless of the entry point and subcommand, events must happen in this order:

Enter main
Remove the token from the environment
Branch on CLI subcommand if needed
(Windows service stuff happens here, probably)
If we're an IPC service or standalone Client, start a file + stderr logger
Else, if we're a debug IPC service, start only the stderr logger
Start a single-threaded Tokio runtime

Entry points:

firezone-client-ipc for Linux - Systemd passes CLI args, journald logs stderr for us
firezone-client-ipc for Windows - Windows passes CLI args, stderr doesn't work
headless-client for Linux -
linux-client - Same as ...

I think I was intending to base this on #4942

Closing in favor of #4978 which is newer and isn't based on the failed refactors


Smooth Glowstone Slab doesn't emit light

Describe the Bug:
When I put a Smooth Glowstone Slab on the ground, it doesn't emit any light, although the whole block gives off good light.
Expected Behavior:
I thought I could use the slabs as a light source for platforms composed of slabs.
Screenshots:
Screenshot 1
Version Information:

Operating System: Windows 10 21H1 (19043.1348)
Mod Version: 2.3.2-beta.1
Minecraft Version: 1.17.1
Forge Version: 37.0.108

This is due to vanilla's lighting system and therefore there is nothing we can do about this.


I can not run a command with specific user and password

I need to run a script with specific user and pass ,  like
``
az vm run-command create --name "myRunCommand" --vm-name "MyVM" --resource-group my-rg  --script "C:\temp\test.ps1"  --run-as-user "user1" --run-as-password ""
but I'm not able to execute, the state is always
"executionMessage": "Script cannot be executed with specified runAsUser/runAsPassword parameters",
    "executionState": "Failed",
    "exitCode": 0,

The password must be encrypted but there is not documentation about how to do it
I tried  power shell  ConvertTo-SecureString, and it doesn't work
I need to used from bash, and I don't have idea how to do it there.

Could you help me? I need

---
#### Document Details

⚠ *Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.*

* ID: f04b196d-7d11-7213-f037-f12b85b19c52
* Version Independent ID: adc05d8e-b13b-134b-5f61-42aaf23666df
* Content: [az vm run-command](https://docs.microsoft.com/en-us/cli/azure/vm/run-command?view=azure-cli-latest)
* Content Source: [latest/docs-ref-autogen/vm/run-command.yml](https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/latest/docs-ref-autogen/vm/run-command.yml)
* Service: **virtual-machines**
* GitHub Login: @rloutlaw
* Microsoft Alias: **routlaw**

Compute

This looks like a service related issue. Could you send me the debug log by email ? My email address is<EMAIL_ADDRESS>

I sent the log requested by you.

In fact, this should be an error message returned by the REST service, so we need the investigation of the service team
Request URL:
GET /subscriptions/a012a8b0-522a-4f59-81b6-aa0361eb9387/resourceGroups/far-arcbox-bicep/providers/Microsoft.Compute/virtualMachines/ArcBox-Client/runCommands/myRunCommandFar?$expand=instanceView&api-version=2021-11-01 HTTP/1.1

'x-ms-correlation-request-id': 'ddd51e9f-6be2-487d-92a5-e1cf02cc6b7f'

Hi, let me know if there is something that I can do.
Let me know when there is any news

@v-fearam Apologies for the late reply. Could you please let me know if you still need assistance on this issue ? Awaiting your reply.

I moved away Azure run-command, we needed to solve the issue. We installed OpenSSH on a not standard port and execute on the context of a specific user.
You can close this ticket as not needed, but unresolved.
I think It is good to follow the topic in order to document in a proper way the functionality, and the the community is able to use the Microsoft products.

@v-fearam Thanks for getting back. We are sorry to hear about this. We sincerely apologize for the delay in reaching out to you. You can refer this docs for more details on this command. We have taken your feedback. We will now proceed with the closure of this issue. If you need any further assistance on this issue in future, please feel free to reopen this thread. We would be happy to help you.

I'm seeing the exact same issue, and I've noted that it is reported for the Azure Powershell library as well: https://github.com/Azure/azure-powershell/issues/17534#issuecomment-1075509019
Executing the following simple test fails when providing a 'run-as' username and password:
az vm run-command create --name "myRunCommand" --vm-name "testvm" --resource-group "PFTestGroup" --script "Write-Host Hello World!" --run-as-password "***" --run-as-user "***"
The following is the result (truncated) after running az vm run-command show:
{ "executionMessage": "Script cannot be executed with specified runAsUser/runAsPassword parameters", "executionState": "Failed" }

@malchowc Please open a new issue and share the above details in it. We would be happy to assist on that.


How to adjust Date plus and minus,since the date is not same for all countries

How to adjust Date plus and minus, the date is not same for all countries
For example in Oman Current Hijri Date is
Georgian Date: 19/06/2019
Hijri Date:15  Syawwal1440
but https://zulns.github.io/Calendar.js/index.html
showing 16 syawwal, we want to minus 1, please let me know how to do so.

I want to add 1 day for Saudi Arabia. Please update the solution if anyone have.


Upgrade to PHP 7.1

Let's take it one step at a time.
This is ready to merge

Man, are you ever sleeping? I will make code review and merge if everything is ok :D

Rector is great. I'm going to show Rector in polish php community Phpers (polsih version of Pehapkari).
You have plans to change some other thing or I can do release?

Do you mean strilecky? ;)
Cool! :1st_place_medal:  It still in development, so report any issue you find.

You have plans to change some other thing or I can do release?

This is all for PHP 7.1 and it's lot of changes.
When this get merged, I'll prepare PR coding standard setup :tulip:

Very good :+1: