fix: Remove invalids field from auto commit

Description
During auto commit, the invalids field in the datsource was being added and later removed by regular commit. Also older format js libs were removed. This PR fixes this issue.
PR fixes following issue(s)
Fixes #29824
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

[x] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

Refactor

Improved the process for saving JS libraries by adding a change detection mechanism.
Enhanced data handling by refining the removal of unwanted fields from the DatasourceStorage object.

/ok-to-test<EMAIL_ADDRESS>


Updated Redis cache project to support .NET Core

@muratg @Eilon @Tratcher

@muratg are we finally getting an RTM version of stackechange.redis?

https://github.com/aspnet/Caching/pull/147/files

https://github.com/aspnet/Caching/issues/121

:shipit:

@muratg Yes I am hitting the issue(localhost) now on my Linux VM

@kichalla OK, thanks.
@glennc Let us know if you'd like to check this in still. Keep in mind that we may need to pull it out if StackExchange.Redis does not RTM before us.

Had an offline discussion with @glennc and decided to go forward with pushing this to have the package on the dev feeds. If we don't get a StackExchange.Redis RTM package close to RTM, we'll pull this back.

Is this getting pushed to NuGet any time soon?

@RehanSaeed mainly myget for now. I expect this to be on nuget with the rest of 1.1 release.


Support new filter for listing outside collaborators without two-factor authentication enabled

Announcement: https://developer.github.com/changes/2017-01-16-audit-outside-collaborators-for-2fa/

Hi, I'd like to work on it.

Thank you, @glapul - I'll send you an invite so that I can assign it to you.

You are correct.  The new Organizations Membership API needs to be supported too.
Announcement: https://developer.github.com/changes/2016-11-28-preview-org-membership/
I'll change the label for this issue, and it can address both.

#538 I've implemented the support for listing outside collaborators. Feedback?

Should this be closed, as #538 was closed and merged?

From a quick glance at this announcement: https://developer.github.com/changes/2016-11-28-preview-org-membership/ it appears that #538 did not fully support all the new API endpoints. For example, I don't think Remove an outside collaborator was addressed.  There may be more, and part of the ownership of an issue (in my opinion) is to investigate what all is needed to completely resolve the issue.
If @glapul would like to complete this issue, then @glapul is welcome to... otherwise if someone else would like to read the announcements and add the missing endpoints, that is fine with me too.


Alternative to neovim-lib

Hey, hope you don't mind this issue, feel free to delete/close it if you feel this is an intrusion.
I'm working on a fork of neovim-lib that I'd like to advertise a bit. It started with the idea to leverage async/await to allow for arbitrarily nested requests, but has grown into more of a rewrite, since I saw the chance to follow some ideas of my own :) It's definitely not API compatible, of course, but has already gotten some features I deem improvements.
If you're interested, I'd dearly like some feedback on it, and I'd certainly be open to requests/ideas, so if you want some influence on the lib you're using, it's a good time to get into touch.
Thanks for reading, and thanks for sharing your project :)

Hey I'm definitely interested! One thing I've been considering doing which might be a good addition as well is taking my event parsing code found here: https://github.com/Kethku/neovide/blob/master/src/events.rs and upstreaming it to the neovim-lib or something similar.  My wrapping enums make life a bit easier.
Can you be more explicit about the differences and improvements you've built over the neovim-lib?

Ah yeah looks like youre planning on a type safe api instead of the Value type. Maybe my events code could be a good starting point. In any case collaborating on that part of the codebase would make my life WAY easier :)

I see two sides of type safety. First, the "fixed" existing API, where I'd want to do all necessary conversions for the user by default (e.g. get_keymap should not return something containing Values, but a proper rust type), and there's no risk of a panic (e.g. get_lines should not panic if the response does not consist of an array of strings).
Secondly, there's user-generated events like in your case (for fixed events like nvim_buf_lines_event we should probably provide conversion functions), where we can't know the structure beforehand. I've written this PR to aid in providing useable conversion functions like you've implemented. Let's see how far we can drive this. But I'll also want to think about providing a serde-like macro #[derive(try_from_value)] to tag structs that provides a TryFrom<Value> implementation or something like this. But I've no experience with this, maybe rmpv-serde already provides something like this? It's more of a longer-time goal I think, unless someone can provide a solution :)

Can you be more explicit about the differences and improvements you've built over the neovim-lib?

The main point would certainly be the usage of async/await to allow nested requests without explicitely spawning threads. I've reworked error handling, but it's not yet done, because it ties in with the next point: An API that enforces the event loop to be running appropriately, rather than runtime panics if one forgets to start the event loop. Both of this is done in my mind, but I'll need to code it up (that's my next step). I've also written up examples, in particular showing how to properly quit an addon (which wasn't properly possible with neovim-lib, in my opinion). More plans in the Roadmap :)
I'll open up an issue about event parsing and notify you about it, let's see what we can come up with ;)


Depth First Search (Graph)

Description 📜
I will explain the basic concept behind DFS traversal of a graph with proper code and logic.

Domain of Contribution 📊

[ X] C/CPP

/assign


Client Timeout should be configureable

Describe the feature you'd like to request
See: https://github.com/vercel/turborepo/discussions/1993
There is a timeout hardcoded here: https://github.com/vercel/turborepo/blob/d79261f1b6da79ee5cbeb3f0988003a303eb15e3/cli/internal/client/client.go#L77
This causes timeouts for assets that take more than 20s to upload (like over my slow home connection to a remote)
Note: This used to be a timeout of 60 seconds but was changed to 20 in this PR: https://github.com/vercel/turborepo/pull/545
Describe the solution you'd like
The timeout should be configurable
Describe alternatives you've considered
I've tried different implementations but ultimately its because my home internet connection is not fast enough to upload the asset in under 20 seconds

That seems reasonable. Would you expect this to be a user configurable number (given your use case) or something in the turbo.json config? It could go into the remoteCache config or be a CLI arg. (which I notice now isn't documented in our Configuration options)

HI @mehulkar thanks for the comments!

In the turbo.json is fine (didnt know about the remoteCache config myself). Really whatever is easier for you to program
It only applies to upload/download not the entire command turbo is running.

Reasonable ask. If you're up for making a PR, go for it!

@mehulkar This is actually a duplicate of #2096

Thanks for hunting that down! Closing this in favor of the older #2096. (If you could update your "fixes" in the PR too, that would be great 😄 )


access: approver access to oauth2

See https://golang.org/wiki/GerritAccess

I am the latest owner of go/oauth2 library so I would like to have the +2 approval access to the repository for reviewing and merging responsibilities. Thanks.

/cc @golang/release

Friendly ping

Please list your Gerrit email address in the issue.

My gerrit email<EMAIL_ADDRESS>Thanks for your help!

Hi Shin,
Thank you for contributing to the Go project and helping out with oath2! I've discussed this request with the team (/cc @golang/release ), and we agreed to grant you access. I've added you to the may-start-trybots and approvers groups now.
Please be familiar with the rules for voting and submitting changes as described at https://golang.org/wiki/GerritAccess#approver-access-approvers. If you're unsure or have any questions, please don't hesitate to ask us.
Additionally, as described at https://golang.org/wiki/GerritAccess#trybot-access-may-start-trybots, please be sure to at least skim CLs before starting a trybot run.
Thank you again for contributing, your help is greatly appreciated!


Add a config file for the audio components

Coverage remained the same at 25.336% when pulling e212b199350a5339bedf370b571a3ae1f5d8a67a on padenot:add_audio_rotation into 73ef4f76595ce866a56fc8ee0e5769b7b4b8df1c on mozilla:master.


Error while switching club scene

While we try to shift from club scene to the next scene or any other, We get this error of Composer not defined. This prevents the scene switching and the next scene is not loaded.

https://user-images.githubusercontent.com/35926530/168114878-4f78acc9-0d81-4ce3-8208-ae8da7600638.mp4

Fixed


Use a Trie (or a high-performance) data structure for ExpressionBuilder and Conditions

At this very moment, the underlying data structure of the ExpressionBuilderand Conditions are just a primitive struct or slice.
In order to increment perfomance, use a Trie or another data structure that fits the requirements for these cases.

Note:  If Select API allows child Conditions, a tree MUST be used as underlying data structure. If not, a slice is fine as Select API internals do not search for a specific item. Therefore, item traversing is always O(n).


For ADAS access, error in import cfspopcon

import cfspopcon
/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/_vendor/flexcache.py(182)_for_cache_name()
-> yield from super()._for_cache_name()
(Pdb) c
/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/_vendor/flexcache.py(182)_for_cache_name()
-> yield from super()._for_cache_name()
(Pdb) c
Traceback (most recent call last):
File "", line 1, in
File "/home/audreysa/cfspopcon/cfspopcon/init.py", line 7, in
from . import algorithms, file_io, formulas, helpers, named_options, unit_handling
File "/home/audreysa/cfspopcon/cfspopcon/algorithms/init.py", line 5, in
from .algorithm_class import Algorithm, CompositeAlgorithm
File "/home/audreysa/cfspopcon/cfspopcon/algorithms/algorithm_class.py", line 12, in
from ..unit_handling import convert_to_default_units
File "/home/audreysa/cfspopcon/cfspopcon/unit_handling/init.py", line 7, in
from .decorator import wraps_ufunc
File "/home/audreysa/cfspopcon/cfspopcon/unit_handling/decorator.py", line 12, in
from .setup_unit_handling import Quantity, convert_units, magnitude, ureg
File "/home/audreysa/cfspopcon/cfspopcon/unit_handling/setup_unit_handling.py", line 16, in
pint.UnitRegistry(
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/facets/plain/registry.py", line 138, in call
obj._after_init()
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/facets/system/registry.py", line 78, in _after_init
super()._after_init()
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/facets/group/registry.py", line 64, in _after_init
super()._after_init()
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/facets/plain/registry.py", line 307, in _after_init
loaded_files = self.load_definitions(path, True)
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/facets/plain/registry.py", line 550, in load_definitions
parsed_project = self._def_parser.parse_file(file)
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/delegates/txt_defparser/defparser.py", line 137, in parse_file
return fp.parse(
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/_vendor/flexparser.py", line 1401, in parse
pp[(source_location, target)] = parsed = parser.parse(
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/_vendor/flexparser.py", line 1010, in parse
return self.parse_file(source_location)
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/delegates/txt_defparser/defparser.py", line 78, in parse_file
content, basename = self._diskcache.load(path, super().parse_file)
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/_vendor/flexcache.py", line 336, in load
cache_path = self.cache_path_for(header)
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/_vendor/flexcache.py", line 298, in cache_path_for
h = self.cache_stem_for(header)
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/_vendor/flexcache.py", line 288, in cache_stem_for
for value in header.for_cache_name():
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/_vendor/flexcache.py", line 81, in for_cache_name
for el in self._for_cache_name():
File "/home/audreysa/cfspopcon/.venv/lib/python3.9/site-packages/pint/_vendor/flexcache.py", line 182, in _for_cache_name
yield from super()._for_cache_name()
File "/usr/lib/python3.9/pathlib.py", line 1249, in read_bytes
with self.open(mode='rb') as f:
File "/usr/lib/python3.9/pathlib.py", line 1242, in open
return io.open(self, mode, buffering, encoding, errors, newline,
File "/usr/lib/python3.9/pathlib.py", line 1110, in _opener
return self._accessor.open(self, flags, mode)
FileNotFoundError: [Errno 2] No such file or directory: '/home/audreysa/.cache/pypoetry/virtualenvs/cfspopcon-ecNu8Maz-py3.9/lib/python3.9/site-packages/pint/default_en.txt/constants_en.txt'

Fixed by
rm .cache/pint

Similar error was reported in https://github.com/hgrecco/pint/issues/1572.
As @AudreySaltzman mentioned, removing the cache should resolve the issue.
I'll close this as solved, but feel free to reopen if new problems come up.


Tracking PR for write-functionality branch

This pull request will track the progress of the write-functionality branch, which has aims to properly implement write functionality for the library

I’d just like to interject for a moment. Just because this branch is named write-functionality, it doesn't mean that all commits here are write-related. Instead, certain commits, like f427f9e for example, make it easier to implement such behaviour.

Should have been a draft PR in the first place


Pb with external avatars

on preprod, when an external change his avatar, it is not seen by agents

It finally worked (perhaps the time to propagate)


Rails 5 support?

I created a new project and I would prefer using render_sync API instead of ActionCable since it seems simpler to me.
The problem I am facing is that rails server(which is puma in Rails 5) is restarted when I run rackup sync.ru -E production.
I am not sure what is the reason for this. Any advice? Is it maybe that rackup command is doing a touch tmp/restart.txt or something like that?

I copied my code folder and started rails puma server in one copy and sync server in other.
It works. The problem seems to be that both rails and sync use puma. Sync does not use thin as expected.
Is puma a better alternative?

is it working for Rails 5?


Crete a calculate routes custom element

I would like and would be usefull create a custom element for routes.

Hmm, I think this same custom element  was usefull, just adding other params.
I should to use in company websites at address areas.


(C#) .Bind missing on the Callable object

Godot version
Godot Engine v4.0.beta1.mono.official.4ba934bf3
System information
Windows 11, Vulkan API 1.2.0 - Using Vulkan Device #0: AMD - AMD Radeon RX 5700
Issue description
The method .Bind does not exists in the current beta, along with some of the docuemented code such as the .Connect on a delegate. I'm unsure if this is due to the fact that the documentation is regarding latest, and not beta, but as of now I can not see a way to connect a signal with additional paramteres.
Steps to reproduce
Create a new callable, and try to call .Bind, or any other form of passing a variable on build in signal
Minimal reproduction project
No response

That makes sense, the documentation was a bit odd. Your code works fine for signals that I create, but if I were to try the same with a built-in signal, such as Timeout, it does not accept additional parameters. Is there any way around this for now?
E.g.
public partial class Node2ds : Node2D
{
    [Signal]
    public delegate void MySignalEventHandler(int a, int b, int c);
    public override void _Ready()
    {
        var _t = GetTree().CreateTimer(1);
        MySignal += (a, b, c) => MySignalCallback(a, b, c); // all good
        _t.Timeout += (a, b, c) => MySignalCallback(a, b, c); // no good
    }
    private void MySignalCallback(int a, int b, int c) { }

    public void Text(string t)
    {
        GD.Print(t);
    }
}

@TandersT: You can't add additional parameters to default signals, it's the same in GDScript

Okay, so as of now is there any way to achieve something similar to this, in which the variable_fire, is parsed with the signal?
timer.Connect("timeout", this, nameof(FreeFire), new Godot.Collections.Array { _fire });

Thank you, that does the trick! That's on my end, I see I misunderstood :)

@raulsntos Wow, TIL - this trick is worth documenting in the docs!

this trick is worth documenting in the docs!

It is used in the documentation, e.g. in Tween.

Should also be documented in Callable documentation itself, and possibly signals

@Zireael07 Sure. I just added C# examples where there were already GDScript ones. The Callable doc page doesn't provide examples for bind  in any language at the moment.

It's currently documented in Object's connect method (a bit outdated, see https://github.com/godotengine/godot/pull/64930):
https://github.com/godotengine/godot/blob/aa553f403099a31520ab0c75a43f352642170d5f/doc/classes/Object.xml#L172-L306
But it should probably be documented in Callable too.

Missed that one while reading through the docs. I can update those if you need me to 🙁

I already update it in https://github.com/godotengine/godot/pull/64930, marked as a draft pending some changes to Callable on C#'s side.

How to remove such a

@TandersT I think you misunderstood my example, you can add additional parameters by using closures, see this example:
var _t = GetTree().CreateTimer(1);
_t.Timeout += () => MySignalCallback(1, 2, 3);
// Or capturing variables:
int a = 1;
int b = 2;
int c = 3;
_t.Timeout += () => MySignalCallback(a, b, c); // a, b, c are captured by the closure

To answer your last comment:
timer.Timeout += () => FreeFire(_fire); // The _fire variable is captured by the closure

@Zireael07 I'm pretty sure you can use bind/unbind with GDScript for default signals, unless I misunderstood what you meant:
func _ready() -> void:
    var t := get_tree().create_timer(1)
    t.timeout.connect(_on_timeout.bind(1, 2, 3))

func _on_timeout(a: int, b: int, c: int) -> void:
    pass

How to remove such a lambda bind from the signal after it was added?

How to remove such a lambda bind from the signal after it was added?

Do you mean disconnect the lambda from the event? It works like it does in C#, you need to store the lambda:
// Store the lambda in a variable
var myCallback = () => MySignalCallback(1, 2, 3);

// Connect the callback to the signal
MySignal += myCallback;

// Disconnect the callback from the signal
MySignal -= myCallback;

Keep in mind, the events we generate with source generators don't generally need to be disconnected because on disposing the object we will automatically disconnect all signals, if that's what you are worried about:
https://github.com/godotengine/godot/blob/f6f8a48459f9bbe97ee76a7186b9ae37e71e724b/modules/mono/csharp_script.cpp#L1743-L1745

The method described here fixed my issues, and since this Callable seems to have its docs updated, hence closing this issues.

is missing in GodotSharp v4.0.3 if there a workaround? it blocks me to update my project


Added an option to not dereference internal $refs.

Hello,
When I was using this plugin to dereference external $refs I had an issue with the internal $refs being dereferenced as well. Therefore I added an option to turn on/off internal dereferencing.  I do not know if this affects the codegen part of the plugin since I am not using it at the moment.
Regards
Adrian

+1
Without this option the resulting json can bloat enormously, particularly when paths share the same schema/parameters/responses, etc.

Thank you guys, good call.

I actually made a few more changes on top of that to enable SwaggerParser options to be passed in from the Gulp task as to enable full control over the parser. Check out v1.0.0 (now also semver friendly) and let me know what you guys think! :)

Great work! I took a quick look at the commit and everything looks really good. It great to be able to have full controll over the parser. I will replace my Github fork with your new NPM package in my projects. Thank you for the quick response!

No problem, thank you for the feedback and collaboration!


API: Change block txn default

Summary
In #1241 we started using the MaxTransactionsLimit parameter to limit the number of transactions returned in the /v2/block API. That caused users who expected to receive the whole block to start getting errors when blocks with high numbers of txns were requested.
In order to enable users to set this limit but also enable those who would like to retrieve the entire block at once, I've set this limit to unlimited by default.
Since the MaxTransactionsLimit parameter was also previously being used in the /v2/transactions endpoint, I've separated the param to a new config option which will only control transactions returned in blocks.

Will reopen a new PR against the hotfix branch.


[DEV] Need database implementation

https://github.com/lnfernal/casino-9

phpMyAdmin creating local database with XAMPP, always show errors after every attempt to create it


No release

There are no release in this package. Is it maintained/developed?

Yes, it's maintained, but I didn't have time for it lately. I will do some updates this week and tag a first version.

Thanks :)

Let's see where we get with the url builder.


Expo Plugin Uses Outdated Version of Crisp SDK

Issue Title
Expo Plugin Uses Outdated Version of Crisp SDK
Issue Description
The Expo plugin in the file plugin/src/withCrispChat.ts uses an outdated version of the Crisp SDK (2.0.0beta1). It is not in sync with the latest releases of the Crisp SDK.
File Reference

plugin/src/withCrispChat.ts

Current Version Used

Crisp SDK: 2.0.0beta1

Latest Release

Release 0.14.4 [2024-09-05] 2.0.2beta3

Suggested Action
Update the Crisp SDK version used in the Expo plugin to the latest available release. This will ensure compatibility and access to the latest features and fixes provided by the Crisp SDK.
Steps to Reproduce

Review the file plugin/src/withCrispChat.ts.
Observe the Crisp SDK version being used (2.0.0beta1).

Expected Behavior
The Expo plugin should use the latest version of the Crisp SDK.
Actual Behavior
The Expo plugin uses an outdated version of the Crisp SDK (2.0.0beta1).

Hello!
I just released a new version based on your suggestion :)


📝(project) improve documentation readability

Following @SergioSim remarks on PR #535, improving some parts of the documentation.

No worry, thanks for the reviews @SergioSim !


Add missing comma to oauth example config

Summary
Fix oauth config example in docs by adding missing comma. This makes the config more easily copy-and-pastable 😄
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@tomquirk Thanks! LGTM 👍


Improving logging

Refactor how output is done, so as to include better logging and to DRY up all the println! calls

https://github.com/env-logger-rs/env_logger/

Done, in v0.0.10 release


[Bootstrap] Do not pass -Ddispatch_DIR to the Yams CMake build

With the version-bump of Yams in https://github.com/apple/swift/pull/36366, Yams 4.0.2 now actually expresses the dependency on Dispatch in its CMake config.
With the current behavior of passing -Ddispatch_DIR to its CMake build, we have the following problem on Linux:

swift's build-script installs Dispatch into a just-built toolchain which we use to build SwiftPM, which will contain, among other things, the Dispatch .swiftmodule.
The compiler workspace checkout of swift-corelibs-libdispatch also contains a copy of the Dispatch .swiftmodule.

Both of these will be found, leading to build failures like:
/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-main/swift-nightly-install/usr/lib/swift/dispatch/module.modulemap:1:8: error: redefinition of module 'Dispatch'
19:37:47 module Dispatch {
19:37:47        ^
19:37:47 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-main/swift-corelibs-libdispatch/dispatch/module.modulemap:1:8: note: previously defined here
19:37:47 module Dispatch {
19:37:47        ^
19:37:47

We also cannot put off building libDispatch until SwiftPM is built, because the libDispatch dylib is required to link SwiftPM.
Not passing -Ddispatch_DIR to Yams' CMake build causes it to successfully locate the Dispatch package in the just-built toolchain on its own.

@neonichu, any problems this can cause that I am not aware of?

Sounds reasonable to me, let's just do a full toolchain build to be sure.

@swift-ci please test

@swift-ci please smoke test

We should wait for both test and smoke test results to be successful in this particular case.


codebase/codelab

https://codelabs.developers.google.com/codelabs/kotlin-coroutines/#5
MainCoroutineScopeRule is a custom rule in this codebase that
->
MainCoroutineScopeRule is a custom rule in this codelab that

Codebase looks good to me (the codebase of this codelab's app)

Codebase looks good to me (the codebase of this codelab's app)


ZADD does not account for null reply

Description
According to the documentation, ZADD should return null if the operation was aborted because of a conflict.
This null is converted to 0 because the command does not use the correct transformer for the reply.
Node.js Version
N/A
Redis Server Version
N/A
Node Redis Version
4.6.13
Platform
N/A
Logs
No response

@puchm

until we fix it you can use client.sendCommand to workaround it:

const reply = await client.sendCommand(['ZADD', 'key', 'NX', '1', 'member']);

there are 2 ways to fix it:

changing ZADD type to always return number | null (which is not true in the "simple case" of ZADD).
remove support for NX, XX, LT, and GT in the main ZADD command, keep the return type number, create ZADD_CONDITINAL (have a better name?) which will support all modifiers and have a return type of number  | null.

Which one is better in your opinion? (@guyroyse @sjpotter)

I'm leaning toward option 1. But I am concerned that either change could break existing code.

Option 1 can be considered a bug fix, option 2 is a breaking change for sure. Should we do 1 for v4, and 2 for v5?

I think that's reasonable. Now we just need a name. But that's a problem for Future Leibale. And probably Future Guy. ;)

I would oppose option 2 because I don't see a reason why ZADD should be treated any different from most other commands. This would need specific documentation just for ZADD. That is reasonable for things that are more complex like scan or transactions but not for ZADD in my opinion.

@puchm the main reason is to make
const reply = await client.zAdd('key', {
  member: 'a',
  score: 1
});

if NX, XX, LT, and GT are supported in the main ZADD, the type of reply will be number | null, which is "not true" because it'll never be a null unless you use one of NX XX LT or GT. By separating it into multiple commands we can have different return types for different cases (i.e. number for the "normal case", and number | null for the "conditional" case).

there are 2 ways to fix it:
changing ZADD type to always return number | null (which is not true in the "simple case" of ZADD).
remove support for NX, XX, LT, and GT in the main ZADD command, keep the return type number, create ZADD_CONDITINAL (have a better name?) which will support all modifiers and have a return type of number  | null.
Which one is better in your opinion? (@guyroyse @sjpotter)

I prefer the latter, as it makes the return type obvious.  I dislike return types that are not possible, but now one has to code around them due to that.

@leibale I guess the optimal way would be to use the power of Typescript to make the return type dynamic based on what is passed in, but I don't think that's possible with the current architecture. Still, the number of methods you have where the name is different from the actual Redis command is really low and should probably stay that way. I'm wondering if there are other cases where some return types are just not possible depending on what is passed in?
I.e. it looks to me that there is a similar situation with SET. If neither GET nor XX nor NX are given the return type of SET will never be null. How do you handle that?

The "optimal way" would be to use TypeScript generics for that, but we are already "abusing" them for other things, which makes that very hard. This is the best option I found, but I hate it...
interface Command {
  transformArguments(...args: Array<unknown>): unknown;
}

function transformArguments(key: string, options?: { NUMBER: false; }): string;
function transformArguments(key: string, options?: { NUMBER: true; }): number;
function transformArguments(key: string, options?: { NUMBER: boolean; }) {
  if (options?.NUMBER) {
    return ['GET', key] as never;
  }

  return ['GET', key] as never;
}

const GET = {
  transformArguments
} satisfies Command;

const COMMANDS = {
  GET,
  get: GET
};

type COMMANDS = typeof COMMANDS;

type RedisClient = {
  [COMMAND in keyof COMMANDS]: COMMANDS[COMMAND]['transformArguments'];
};

const client = undefined as unknown as RedisClient;

const a = client.get('key');
const b = client.get('key', { NUMBER: true });

if you have any ideas please share.. ;)
In SET we didn't do it since in the "normal case" the reply does not matter, but we did it in other commands (for example, XAUTOCLAIM_JUSTID).

Having exactly this issue as well with the null reply screwing things up ...


[Feature][RestAPI] Add overview api

Purpose of this pull request

{
"projectVersion": "2.3.5",
"gitCommitAbbrev": "DeadD0d0",
"totalSlot": "0",
"unassignedSlot": "0",
"runningJobs": "0",
"finishedJobs": "0",
"failedJobs": "0",
"cancelledJobs": "0",
"works": "1"
}
Does this PR introduce any user-facing change?

How was this patch tested?

Check list

[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

Please fix ci error


⚠ Bofrost.at has degraded performance

In e21f4d1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2283 ms

Resolved: Bofrost.at performance has improved in 494c9b6 after 6 minutes.


[d1]: Create query-databases.md

This PR:

Moves the Client API docs under "How To", as they were buried under Reference in the restructure. This is one of the most important docs for D1 and it became harder to find. It is now simply called "Query databases".
Continues to link "Client API" to this moved doc (for the above reasons) rather than just re-directing the old link. Developers really need to find this doc, and so it's OK if it's in two places.

New:

(The link checker breaks because it can't follow re-directs. I'll have to fix all of these manually)


Change "nameEs" to "titleEs" for all translations

There are three properties associated with a challenge that have to do with naming, each has it's own place.
Title is user-defined. It is the name of the challenge given by the community. This is used in the challenge itself and displayed to the user in the html.
name is programmatically generated from the title property while removing any non-alphanumerics. This is used during regex searching for dynamic routes.
'dashedNameis programmatically generated from thename` property. It further changes the title by removing and replacing spaces with dashes. This is used in the url of the challenge.
This was not always the case and was changed to the current set up some months ago.
Unfortunately, the translations of these challenges did not have those properties updated.
In order to move forward with translations and enable dynamic routes, we need to change those title properties that are currently in the format nameEs to titleEs.

I've got this.  I already have a framework written for processing the JSON.
I take it that we're talking about nameLN to titleLN where LN is any 2 letter language identifier?

Yes, but we are using camelCase even for the indentifier. nameLn to titleLn.

I meant LN as a placeholder.  Got it.  I'll get a PR going by the end of the day.

@SaintPeter and @BerkeleyTrue Does this change affect the current translations procedures in anyway?
If yes would any of you mind commenting on the issue FreeCodeCamp/wiki#565 with the details?
I making changes to the guide and will update if anything is required.

@SaintPeter and @BerkeleyTrue I don't know if this "issue" causes any kind of impact , but the translators for Brazilian Portuguese are using PtBR as a identifier, once the language spoken in Brazil is different from the one spoken in Portugal (PT).
So far, we've been doing like in the excerpt bellow:
      "namePtBR": "Recorra à nossa Wiki",
      "descriptionPtBR": [
        [
          "http://i.imgur.com/4GO4zcI.gif",
          "Um gif mostrando como você pode clicar no botão \"Wiki\" no canto superior esquerdo para acessar a wiki.",
          "Clique no botão \"Wiki\" no canto superior esquerdo. <br>Nossa comunidade tem contribuído com muitas informações úteis que podem ser pesquisadas nessa wiki.",
          ""
        ]
      ]

Extracted from the following Pull Request: 7097.


Created pull request template

I added a pull request template which may help developers to describe the fixes and new features in a good way and fast.
I think this may help you!

is this repository still active?? @juliangarnier

is this repository still active?? @juliangarnier

Yes, check #779

k thanks! @Lukas-Batema


Better handling of "out of sync" Tables

Is your idea related to a problem? Please describe.
data.all has logic for when a user manually goes to delete a table (shares checked, table removed, permissions cleaned, etc.) but something to think about is how best should we handle table syncs (I am not sure the correct answer here). For instance:

Either when a user starts a manual sync or the scheduled table_syncer ECS task is run (ultimately both run DatasetTableService.sync_existing_tables() at some point)
If the glue table exists in data.all but does not exist in the glue response --> we update table status to Deleted
On the UI we no longer show those tables by filtering for != Deleted (ref: DatasetService.paginated_dataset_tables()
But these tables still do have associated permission records for who should be able to access the table

And if we do clean them up right away but the table DOES still exist on Glue (i.e. some other error in API Response or similar returns 0 tables incorrectly) then we have potentially just broken existing access or shares if the next time a user hits Sync the table re-appears

Describe the solution you'd like
Some ideas of what we can do:

Do nothing. There will be stale tables and permission records in RDS but it avoids risk of removing permissions inappropriately and should not greatly affect logic of data.all
Implement some type of garbage collection. Delete tables and associated shares on those tables after the tables have been in status of Deleted for some extended period of time (i.e. 30 days)
As soon as a table status gets updated to Deleted still show it on the UI but with a Deprecated Flag and with the only option for the user to do is to delete the table + clean up shares (pre-req to table delete already)

Remove from Catalog (already done by sync), prevent all new shares, only can revoke share and clean-up / delete of table
If next sync restores the glue table back to InSync allow for normal activity again (no longer Deprecated)

P.S. Don't attach files. Please, prefer add code snippets directly in the message body.

Adding to Backlog to be picked up when have some capacity


Move mcp/ratelimiter out of internal

This change moves MCP ratelimiter outside of internal package and exposes it so it can be consumed in other (e.g galley server/server.go)
Also related https://github.com/istio/istio/issues/11379

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Nino-K
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS
pkg/mcp/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Nino-K: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test e2e-simpleTests

prow/istio-unit-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
464566acd35f6d26ca402fd288f4aa96023b1fe3
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Needs to rebase I think
/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: louiscryan, Nino-K
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS
pkg/mcp/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests-cni

prow/istio-pilot-multicluster-e2e.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests-cni

prow/istio-pilot-multicluster-e2e.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests

prow/e2e-mixer-no_auth.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio_auth_sds_e2e

prow/e2e-bookInfoTests-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests-cni

prow/istio-pilot-multicluster-e2e.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests

prow/e2e-mixer-no_auth.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests-cni

prow/istio-pilot-multicluster-e2e.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests

prow/e2e-mixer-no_auth.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests

prow/e2e-mixer-no_auth.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
c949e72feaa945a47c70a2d38be2e8cd8fba5b0b
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-dashboard

prow/istio-integ-k8s-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-mixer-no_auth

prow/istio-integ-k8s-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests-cni

prow/e2e-dashboard.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-mixer-no_auth

prow/istio-integ-k8s-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests-cni

prow/e2e-dashboard.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test e2e-mixer-no_auth

prow/istio-integ-k8s-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests-cni

prow/e2e-dashboard.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests-cni

prow/e2e-dashboard.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio_auth_sds_e2e

prow/e2e-mixer-no_auth.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
49a819da640f03f0ce071d94c53783e8e49f71cc
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests-cni

prow/e2e-dashboard.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio_auth_sds_e2e

prow/e2e-mixer-no_auth.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-simpleTests-cni

prow/e2e-dashboard.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio_auth_sds_e2e

prow/e2e-mixer-no_auth.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio_auth_sds_e2e

prow/e2e-mixer-no_auth.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests-cni.sh
f91f5071914fdf9e78bb972439cbcf3f73e50bff
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio_auth_sds_e2e

prow/e2e-mixer-no_auth.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
f91f5071914fdf9e78bb972439cbcf3f73e50bff
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
f91f5071914fdf9e78bb972439cbcf3f73e50bff
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
f91f5071914fdf9e78bb972439cbcf3f73e50bff
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
f91f5071914fdf9e78bb972439cbcf3f73e50bff
link
/test istio-integ-k8s-tests

prow/e2e-bookInfoTests-v1alpha3.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
f91f5071914fdf9e78bb972439cbcf3f73e50bff
link
/test istio-integ-k8s-tests

prow/e2e-bookInfoTests-v1alpha3.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
22c67c2774fed98d3e1b41480546100414e60ddd
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-integ-k8s-tests.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
cf703cbecc221419e90e3b21fdf328d7adceebaf
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
d599ad5333eeaaf55e4178464f47e2e66d3a09e4
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
d599ad5333eeaaf55e4178464f47e2e66d3a09e4
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
d599ad5333eeaaf55e4178464f47e2e66d3a09e4
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
0b86afb92ab78114470f1ad7f54cf410e0c1ce65
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
d599ad5333eeaaf55e4178464f47e2e66d3a09e4
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
d599ad5333eeaaf55e4178464f47e2e66d3a09e4
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
d599ad5333eeaaf55e4178464f47e2e66d3a09e4
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
d599ad5333eeaaf55e4178464f47e2e66d3a09e4
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
d599ad5333eeaaf55e4178464f47e2e66d3a09e4
link
/test istio_auth_sds_e2e

prow/e2e-simpleTests-cni.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren @ayj can we merge this if there are no other comments/concerns?

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: louiscryan, Nino-K, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ozevren]
pkg/mcp/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
4d9d01480fa74e9746e11e6a9dafb4f2a93a4c47
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[MMCA-4172] Upgrade version for Non-HMRC dependencies

Could you please update the non HMRC libraries (mentioned in attached google doc in the ticket) as this ticket is for non HMRC libraries update? Better to leave the HMRC libraries unchanged, in case these create any issues


Bump PDF.js from 3.11.174 to 4.3.118

Description
Please provide a summary of the changes, including relevant motivation and context.
Please test it in detail, I have tested all embedded functions, but as you know it works for me ;P
Closes #1257
Checklist:

[x] I have read the Contribution Guidelines
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

Contributor License Agreement
By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.
(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

#819