reporting frame size twice

by @williangalvani

I went all the way to the backend to find out that this issue is actually related to this (and maybe some others) camera driver, which is reporting duplicated formats (both size and intervals):
v4l2-ctl -d /dev/video2 --list-formats-ext
ioctl: VIDIOC_ENUM_FMT
        Type: Video Capture

        [0]: 'H264' (H.264, compressed)
                Size: Discrete 1920x1080
                        Interval: Discrete 0.033s (30.000 fps)
                        Interval: Discrete 0.040s (25.000 fps)
                        Interval: Discrete 0.067s (15.000 fps)
                        Interval: Discrete 0.033s (30.000 fps)
                        Interval: Discrete 0.040s (25.000 fps)
                        Interval: Discrete 0.067s (15.000 fps)
                Size: Discrete 1280x720
                        Interval: Discrete 0.033s (30.000 fps)
                        Interval: Discrete 0.040s (25.000 fps)
                        Interval: Discrete 0.067s (15.000 fps)
                Size: Discrete 800x600
                        Interval: Discrete 0.033s (30.000 fps)
                        Interval: Discrete 0.040s (25.000 fps)
                        Interval: Discrete 0.067s (15.000 fps)
                Size: Discrete 640x480
                        Interval: Discrete 0.033s (30.000 fps)
                        Interval: Discrete 0.040s (25.000 fps)
                        Interval: Discrete 0.067s (15.000 fps)
                Size: Discrete 640x360
                        Interval: Discrete 0.033s (30.000 fps)
                        Interval: Discrete 0.040s (25.000 fps)
                        Interval: Discrete 0.067s (15.000 fps)
                Size: Discrete 352x288
                        Interval: Discrete 0.033s (30.000 fps)
                        Interval: Discrete 0.040s (25.000 fps)
                        Interval: Discrete 0.067s (15.000 fps)
                Size: Discrete 320x240
                        Interval: Discrete 0.033s (30.000 fps)
                        Interval: Discrete 0.040s (25.000 fps)
                        Interval: Discrete 0.067s (15.000 fps)
                Size: Discrete 1920x1080
                        Interval: Discrete 0.033s (30.000 fps)
                        Interval: Discrete 0.040s (25.000 fps)
                        Interval: Discrete 0.067s (15.000 fps)
                        Interval: Discrete 0.033s (30.000 fps)
                        Interval: Discrete 0.040s (25.000 fps)
                        Interval: Discrete 0.067s (15.000 fps)

So I think the best we can do about it is to, on our backend, suppress the doubles when retrieving them from v4l. If so, I think I can do it with my current rust skills, what do you think, @patrickelectric?

@patrickelectric perfect!


Extension issue - I uncaught errors - showing up in 'Running Extensions"

Issue Type: Bug
Extension Name: csharp
Extension Version: 1.20.0
OS Version: Darwin x64 18.6.0
VSCode version: 1.36.0-insider

{
	"messages": [],
	"activationTimes": {
		"startup": true,
		"codeLoadingTime": 43,
		"activateCallTime": 5,
		"activateResolvedTime": 14,
		"activationEvent": "workspaceContains:*.csproj,*.sln,*.csx,*.cake,**/*.csproj,**/*.sln,**/*.csx,**/*.cake"
	},
	"runtimeErrors": [
		{
			"name": "TypeError",
			"message": "Cannot read property '0' of null"
		}
	]
}

@rbadapanda Can you elaborate more on what you are trying to achieve, like what files are you trying to edit and what is the issue that you are facing like intellisense not working, unable to debug, etc


Bridge the eth from holesky to hekla , but no reflection....

Describe the bug
Bridge the eth from holesky to hekla , but no reflection....
Steps to reproduce

using bridge
holesky to hekla

processing a long time, no tx in taikoscan

Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

You are bridging from Holesky to Hekla. So the bridge transaction shows up on Holesky.


504 Gateway Time-out

When going to the my site sometimes it does not load at all and gets a 504 gayway timeout
When it does work faq etc do not load.


Allow HEAD requests for HttpHealthCheckShareAdjuster

Depending on the application, HEAD can return less data than a GET request as hardcoded in this share adjuster with requests.get.

On board. An optional 'method' or 'verb' parameter with a default value of 'GET' would maintain compatibility for existing users.

This is fixed by #11

Thanks @SEJeff!


Feature - Opayo card tokens

This PR looks to improve the Opayo payment provider in general, add some tests and also bring in support for reusable payment tokens.

@alecritson does this package need its README.md file updated?

@alecritson does this package need its README.md file updated?

Added some initial docs


Fix taskify with immutable arguments.

taskify mutates the args adding a callback every time the task runs, causing the wrapping promise not being resolved. This PR fixes this behaviour.

@DenisFrezzato good catch, thanks


Fix a few typos

Just fixed a few typos.
Thank you very much @lucahammer for the development of such a useful tool, I used it massively so far!

Thanks!


Cannot connect to remote debugger when using android real device with charlse proxy enabled.

Is this a bug report?
Yes,I think it's a bug with react-native itself.
Have you read the Bugs section of the Contributing to React Native Guide?
Yes,the bug can only be reproduced with real devices.
Environment

react-native -v:0.45.1
node -v:v7.8.0
npm -v:5.0.3
yarn --version:0.15.1

Then, specify:

Target Platform (e.g. iOS, Android):Android
Development Operating System:macOS Sierra 10.12.5 (16F73)
Build tools : Android Studio 2.2.2 , SDK 21

Steps to Reproduce
1.With a local node data server running,hijacked http://demo.com:6003 to local server with hosts.
2.open Charlse as device proxy set my android phone proxy to Charlse address
3.Shake the phone and press debug Debug JS Remotely,react native package process log Launching Dev Tools... and http://localhost:8081/debugger-ui shown,but android device keeps showing connecting to remote debugger green bar and after short time it shows Timeout while connecting to remove debugger
Expected Behavior
I can connect to remote debugger successfully,log my http response from server .
Actual Behavior
packager server acts but real device cannot aware of conneted info.
PS:the packager works well and if I do not open Debus js remotely everything works well,the aoo compile and reload well.
Reproducible Demo
Real Device bug,there's no demo can be offered.
have changed ip address to IP or localhost,no difference.

Same issue for me

As there's no one reply the issue I'll close it.But I have to say the problem still exits.
😞
By moving website to a public repo and chrome devTool network panel,I can continue my development

I resolve this by disable production config in main App
// console.disableYellowBox = true
// console.error = error => error.apply
// NativeModules.ExceptionsManager = null

For me, it solved to uninstall the app in the real android device and install it again by running react-native run-android in the terminal. After that, shake the device and enable debugger. Everything works.

I got the same problem using react native 0.53

I also have the same issue using react native 0.53 on macOS with android virtual device emulator. In addition when I try to enable debugging and it fails I am always taken to this url: http://<IP_ADDRESS>:8081/debugger-ui. When it works I am redirected to this url: http://localhost:8081/debugger-ui/
I have only gotten the debugger to work once out of over a dozen times restarting terminal instance, browser, emulator etc. trying to get it to work.

same here, I am using react-native 0.5.3 running on mac os. Trying to reverse port in terminal but it does not help.

Follow this link link, the second answer works for me!


Improve integration test performance

See comments on #10 - tests w/ simulator are too slow still, and can probably improved dramatically.

The main problem should be fixed with https://github.com/LiberTEM/LiberTEM-live/commit/8056e38a05fb36dd71333c26b1bb78a132bfd989

Fix confirmed with data pipeline for #14, closing!


Does pod-reaper act on 1 pod at a time? or all pods simultaneously

I apologize in advance if this was specified in your documentation, but I could not find it in either Github or Docker Hub.
I was wondering if pod-reaper acts on all pods that match based on REQUIRE_LABEL_KEY/EXCLUDE_LABEL_KEY at the same time, or if it iteratively does 1 pod at a time.
This matters to me because I need to ensure when pod-reaper kills off pods, we have zero downtime. So in a way, I am basically looking for a RollingUpdate + maxUnavailable: 0, option for killing off pods.
I understand I can use CHAOS_CHANCE to try to ensure some pods stay alive. But a rolling strategy for killing off pods would be far more deterministic and predictable.
Please let me know if this is the default implementation, or if there is something I can set to make this happen.
Thank you.

pod-reaper grabs all pods that match based on REQUIRE_LABEL_KEY/EXCLUDE_LABEL_KEY and rapidly (without any delay) accesses whether or not each pod should be terminated. With the CHAOS_CHANCE flag set and it being able to look at every pod in a replicaset (or deployment/daemonset) there isn't currently way to ensure at least one of those pods is running. Basically, the current behavior will always lead to ($CHAOS_CHANCE)^(REPLICA_COUNT) chance of having all pods in a replicaset terminated by pod-reaper on a given reaping cycle.
The approach I've taken has been to calculate this chance, observe the effects in a testing environment, and try to do a quick cost/benefit analysis relative to relative to my products error budget. For systems with extremely tight service level objects, this usually meant running a high enough replica count that the risks of a clusterwide outage heavily outweighed the chances of pod-reaper (or something else) knocking out all pods in a replicaset at the same time.
That being said, this is something that's come up a couple of times now. If this is something where having the extra layer of safety means the difference between trying it out, and skipping over, then maybe it's time for me to implement it :)

This would be really helpful for me as well - the non-zero chance of all replicas being terminated at the same time is a problem for us (even if it is a low chance). It would be especially useful when there is a low number of replicas.

I'm going to block some time to take a deeper look at what an implementation of this would look like.
Inevitably, it will need to involve the reaper being aware of a constructs managing relicasets (or deployments/daemonSets) which doesn't immediately make me feel great about the idea. But if having a safety mechanism helps, it's absolutely worth the look!

This would be very cool. Thanks peeps

Worked on a prototype when I got some time this weekend. Sample output log below:
The way I went about this was to make use of each pods OwnerReferences. Basically, we keep track of a map of these owners to a pod count. Before deleting pods, we compare the values of each owner of the pod to a configurable value. If it's too low, we don't delete. I've got a ways to go on testing and such, but this looks like an approach that should work without requiring the reaper to be directly aware of deployments/replicasets/daemonsets (it does still need to know about them through OwnerReference.Kind and OwnerReference.UID -- but that doesn't take custom code for each different type)
{"level":"info","msg":"pod flagged as unsafe for delete by minimum replicas DaemonSet/kindnet","pod":"kindnet-zhhw6","reasons":["was flagged for chaos"],"time":"2020-12-27T23:44:28Z"}
{"level":"info","msg":"reaping pod","pod":"kube-apiserver-kind-control-plane","reasons":["was flagged for chaos"],"time":"2020-12-27T23:44:28Z"}
{"level":"info","msg":"reaping pod","pod":"kube-controller-manager-kind-control-plane","reasons":["was flagged for chaos"],"time":"2020-12-27T23:44:28Z"}
{"level":"info","msg":"pod flagged as unsafe for delete by minimum replicas DaemonSet/kube-proxy","pod":"kube-proxy-xw5rv","reasons":["was flagged for chaos"],"time":"2020-12-27T23:44:28Z"}
{"level":"info","msg":"pod flagged as unsafe for delete by minimum replicas Node/kind-control-plane","pod":"kube-scheduler-kind-control-plane","reasons":["was flagged for chaos"],"time":"2020-12-27T23:44:28Z"}
{"level":"info","msg":"pod flagged as unsafe for delete by minimum replicas ReplicaSet/local-path-provisioner-7745554f7f","pod":"local-path-provisioner-7745554f7f-8t7r2","reasons":["was flagged for chaos"],"time":"2020-12-27T23:44:28Z"}
{"level":"info","msg":"pod flagged as unsafe for delete by minimum replicas ReplicaSet/pod-reaper-76cbbf8d87","pod":"pod-reaper-76cbbf8d87-mf9vl","reasons":["was flagged for chaos"],"time":"2020-12-27T23:44:28Z"}

here's an example of it keeping one replica alive and killing the others.
reaper               dummies-65876d98cb-8zfzb                     1/1     Running   0          14s
reaper               dummies-65876d98cb-s8sx6                     1/1     Running   0          14s
reaper               dummies-65876d98cb-wfxgh                     1/1     Running   0          14s
reaper               dummies-65876d98cb-wh7vl                     1/1     Running   0          109s
reaper               pod-reaper-76cbbf8d87-ppw4w                  1/1     Running   0          109s

There's going to be either some form of chance or some form or order to which pod gets saved. The API seems to be returning pods is alphabetical order, and the safety check allows pod deletes until it encounters a violation of minimum replicas so it favors alphabetically last pods.
Another thing to perhaps consider -- this code does not look at the health of the pods (Running in the case above). That might be something to add before I go much further.

Before deleting pods, we compare the values of each owner of the pod to a configurable value.

Such a value is already a standard concept in Kubernetes, it's the pod disruption budgets. Users and administrators should already be setting them, because they are used e.g. when machines are drained for any reason or the scheduler triggers some piority-based preemption. The above sounds a lot like reinventing PDBs.
You can take advantage of them through the pods' eviction API: https://kubernetes.io/docs/tasks/administer-cluster/safely-drain-node/#eviction-api
Now the question is: would you only use evictions? or maybe evictions, followed by deletes if they haven't succeeded after some time? or maybe leave that for the admin to choose for each reaper instance, given that services should be able to survive drains, preemptions AND sudden deaths? @gilgameshskytrooper would only set up evictions, in this case.
I hope the above helps and spares you from writing a lot more code :)

Created #68 which uses the eviction API to delete pods, behind an optional feature gate

closing this as I think it's been resolved. Please feel free to reopen if there's anything else!


gulp dev

Advanced Usage
After installation, run npm install and then run gulp dev . my question is how to run gulp dev? newbie here

I think you haven't installed the package gulp-cli as global.
npm install gulp-cli -g

After doing that it just says "no gulpfile found"


Why you're using imports in TypeScript files which are pointing to node_modules of dev dependency directly?

Is your feature request related to a problem? If yes, please describe it.

The problem isn't related to anything specific, it is more a question that has been already asked here in PR #1084
https://github.com/intershop/intershop-pwa/pull/1084
Describe the desired solution.
While playing with intershop-pwa as part of npm workspace I just discovered some troubles while building schematics. Mostly while typescript couldn't find some dependencies.
Describe alternatives you've considered.
I was wondering why you're not using direct imports from rxjs as it was previously.
Now:
import { switchMap } from '@angular-devkit/core/node_modules/rxjs/operators';

Before:
import { switchMap } from 'rxjs/operators';

Provide additional context.
It is in the context of npm workspaces and general monorepo idea.
AB#83987

I'm just thinking loud here, wouldn't be better to abstract intershop-schematics and publish it in npm as a completely separate dependency so it could be devDependency for intershop-pwa?

I'm just thinking loud here, wouldn't be better to abstract intershop-schematics and publish it in npm as a completely separate dependency so it could be devDependency for intershop-pwa?

Could be a good idea but it is currently not a priority. Maybe it becomes one if we would need our schematichs for more than this one project.


Where is this blog ?

Interested highly, if this is upcoming..

Never worked on this. Not in plans in recent future.


Add "Copy code" button to API and help center docs

It would be helpful if code blocks in the /api and help center documentation had a "Copy code" button, similarly to the Zulip app.

CZO discussion

@zulipbot claim

I've submitted a pull request (https://github.com/zulip/zulip/pull/25803) for this issue that's ready for review.


Inactive tab color matching Windows titlebar color

On previous Chrome versions the inactive tab color matched the titlebar set by the Windows theme, instead of the grey/black color now, is it possible to bring back this behaviour?

Yes, I can do that. I just need to find out the API call to return the colour of the titlebar and it should be doable.

https://devblogs.microsoft.com/oldnewthing/20170405-00/?p=95905
this seems to let you get the accent color, but i'm not sure if this exposes whether the user has chosen to use it for the titlebar or not

Chromium still does this internally, but I noticed that some internal values had been changed since Windows 7 was dropped, so I restored them. However I didn't see much of an influence from the titlebar, and the same was true on version 49. I wonder if #transparent-tabs plays a role?

I hope you'll be able to figure it out (as having the inactive tab color respect the titlebar helps with accessibility), on older Chrome versions (on 8.1 at least) the titlebar color is used for the status bar (when you hover over a link for example) and also the border around the new tab button if that's any help to you.


chore(ci) add some naive retries to our CI

:tada: This PR is included in version 4.10.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


favicon

Steve168 has a good candidate favicon.  It hasattribution requirements.  This is to implement the "bindle" icon he found as a favicon.

I copied the attribute link when i got the favicon and attributed it on Facebook and X so I think it should be ok to use it, unless you want to redo it for peace of mind

I am going to use another icon from flaticons and put attribute it to  Refugee icons created by Freepik - Flaticon


Increased timeouts and retries for instrumentation tests

Tests fail quite often but retries seem to help.
Test Plan:

see Circle CI logs

By analyzing the blame information on this pull request, we identified @mkonicek to be a potential reviewer.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


RSS  element support

For the sake of completeness, we should support the <ttl> tag, since some feeds use it.
See current specification file: https://www.rssboard.org/rss-specification

Done


check_indexes: add warning for when autovacuum isn't keeping up

Warning should fire when the number of dead tuples exceeds the point where auto-vacuum should have kicked off.
Will have to use coalesce these:

Table-level autovacuum is turned off
Table-level vacuum settings
Database-level vacuum settings

Code is merged into the dev branch, but has 3 known issues that I need to work through:
/* BGO FIXFIX:
	This does not include a percentage threshold above for warning purposes,
		but just immediately fires if we are even 1 row above the autovacuum
		threshold, which is probably too noisy. We probably want to alert
		when we are say 10% over the threshold.

	This query is running by using pg_class.reloptions.
		I want it to run based on c_tbl.reloptions instead.

	I do not know that the estimated tuple threshold reporting is accurate
		from the formula written by ChatGPT.
*/


fix bug in containers being filtered by image name

Fixes #857
Was introduced in #838

LGTM (pending the tests)


Initial checkin of admin ui calls and associated config file

Just curious if we need a FileBasedUIServerConfigStoreConnector separate from FileBasedServerConfigStoreConnector?  I see that they use different beans to represent different server config types; but perhaps that could be addressed by the methods that are bean-specific using a slightly more abstract bean from which the underlying types (UI vs non-UI) extend?  (Then the method signature is the same, same connector can be used, same code for ser/de, etc?)

@cmgrote I think this is what https://github.com/odpi/egeria/issues/1658 is for. I was hoping to get the initial UI admin code in - as it is quite big - then refactor the file store side of things in the other issue.

I made a patch to correct the dependency issues. Even if more changes are needed it may help as an example of what the issue was and how to correct.
In open-metadata-implementation/adapters/open-connectors/configuration-store-connectors/ you have two sub modules

configuration-encrypted-file-store-connector
configuration-file-store-connector

A dependency on
        <dependency>
            <groupId>org.odpi.egeria</groupId>
            <artifactId>ui-admin-services-api</artifactId>
        </dependency>

was expressed in the parent project.
However only configuration-file-store-connector seems dependent on this module.
Doing this results in compile time errors from the checks we do for unused dependencies.
To avoid this you added an exclusion to the pom for configuration-encrypted-file-store-connector , in this case it was masking the underlaying issue.
We should try and be careful with exclusions. They absolutely are needed sometime (and perhaps I've misunderstood your code - as I haven't RUN it) but generally just with classes that are loaded at run time, such as through spring component scan or logging implementations for sl4fj. No doubt there will be others - including in connectors - over time.
Hope that helps, here's the diff -> https://gist.github.com/bd81a7fad1070b4040bb7cbd16a62a6d

let me know when ready for another review of poms and I'll check again :-)

@planetf1 sorry Nigel I have merged. I thought that is what we had agreed.

The comments from https://github.com/odpi/egeria/pull/1673#issuecomment-539030738 need actioning to correct the dependency issue. The patch may apply (not try). Suggest we open up and fix in new issue as those dependency issues are still in there

Opened up https://github.com/odpi/egeria/issues/1689


What is darksky?

What is darksky, can´t find it in Homeassistant?!
Michael

Bought by Apple, not available anymore. Use another weather service.


6pm a tutor list

front end for tutor list table and tutor list page.
back end for course controller (tutorassignment controller included) and tutor controller; tutorassignment repository and tutor repository. member check controller
some things to mention:
we write some controllers by ourselves but these controller or repositories are 6pm-c's stories. We just write what we need, so it needs to be merged with team c.

Please fix merge conflicts
Please also fix the description of the PR.  It is not a very clear description of what changes are in this PR.
Please describe from a user standpoint, not just a programmer standpoint, what this PR does.


fix: allow users to override defaulted api params

Description
This PR updates the behavior of parameter extension in three API functions within the ChatGPT plugin. The functions are Api.completions, Api.chat_completions, and Api.edits. The change involves modifying the vim.tbl_extend() method's first argument from "keep" to "force".
Changes

In Api.completions, Api.chat_completions, and Api.edits functions, update the vim.tbl_extend() method's first argument from "keep" to "force" to ensure that user-configured OpenAI API parameters (Config.options.openai_params and Config.options.openai_edit_params) take precedence over the default parameters.

Thank you @alankopetman !


Create kloak.spec

Spec file for rpm, specifically for Fedora.
This pull request changes...
Changes
Mandatory Checklist

[ x ] Legal agreements accepted. By contributing to this organisation, you acknowledge you have read, understood, and agree to be bound by these these agreements:

Terms of Service, Privacy Policy, Cookie Policy, E-Sign Consent, DMCA, Imprint
Optional Checklist
The following items are optional but might be requested in certain cases.

[ x ] I have tested it locally
[ x ] I have reviewed and updated any documentation if relevant
[ ] I am providing new code and test(s) for it

Fixes #

This works great for me on Fedora 40, however the kloak service is not enabled by default after installation since there is no systemd preset file. Not really a bug, the user can always enable it themselves, but since the Debian package for kloak does automatically enable it after installation, it might be worth considering.

This works great for me on Fedora 40, however the kloak service is not enabled by default after installation since there is no systemd preset file. Not really a bug, the user can always enable it themselves, but since the Debian package for kloak does automatically enable it after installation, it might be worth considering.

Actually good point, I didn't think about it. Right now I have a review request open to get it into the Fedora repos, so I'll have to look after the packaging guidelines again to make sure I'm able to enable it by default, but iirc I should be able to. I've never made a systemd preset file before, so if you know how to and can make a PR it would be appreciated.

I can try to take a look when I have some free time.

@adrelanos https://docs.fedoraproject.org/en-US/packaging-guidelines/DefaultServices/


Expiry works only during runtime and is lost on shrink

Version: v1.3.0
If I add key first without expiry and then re-set it with expiry, but the expiry is not concluded during runtime, they key is never expired and on shrinking expiry is lost. To reproduce it:
Run this code:
func main()  {
	db, err := buntdb.Open("data.db")
	if err != nil {
		log.Fatal(err)
	}
	defer db.Close()

	err = db.Update(func(tx *buntdb.Tx) error {
		_, _, err := tx.Set("my_key", "my_val", nil)

		return err
	})

	err = db.Update(func(tx *buntdb.Tx) error {
		_, _, err := tx.Set("my_key", "my_val", &buntdb.SetOptions{Expires: true, TTL: 5 * time.Second})

		return err
	})
}

The data.db will look like this:
*3
$3
set
$6
my_key
$6
my_val
*5
$3
set
$6
my_key
$6
my_val
$2
ae
$10
1701350403

After more than 5 seconds, run this code:
func main() {
	db, err := buntdb.Open("data.db")
	if err != nil {
		log.Fatal(err)
	}
	defer db.Close()

	db.Shrink()

	db.View(func(tx *buntdb.Tx) error {
		err := tx.Ascend("", func(key, value string) bool {
			fmt.Printf("key: %s, value: %s\n", key, value)
			return true
		})

		return err
	})
}

It will print:
key: my_key, value: my_val

The data.db file looks like this:
*3
$3
set
$6
my_key
$6
my_val

I guess the expiry is not set when reconstructing the state from the log if there were previous versions of the same key without expiry.

actually it's a bug about the db reconstruction, not only shrink

@tidwall please look into this issue.

I looked into this issue. There are two problems.
First, when loading a database from disk, entries with an expired timestamp may still find their way to the in-memory database if there was a previous (non-expired) entry that was already added.
Second, iterators do not check each item that may have been expired before returning it to the caller.
For example, calling Ascend will return potentially expired items, but calling Get will not.
The PR by @Sora233 sorta fixes the problem by always reinserting every item. This works for Get but not iterators like Ascend and fails to work for the example provided by @boguslaw-wojcik.
The correct fix would be to force delete entries on load when those entries are expired, and then also check when items have expired during iteration.

I just pushed a fix that addresses the problem.

Thank you @tidwall !

I think I can close the issue as resolved.


Update Laravel JSON:API package

Hi! I'm the author of cloudcreativity/laravel-json-api which I've actually re-written and released as laravel-json-api/laravel. This PR replaces the link to the old package with the new one, as the old package isn't recommended for use with new projects.

Thanks @lindyhopchris. Sorry to take a while to review and merge!


Migeran LibGodot Feature

Features

Compile Godot Engine as either static or shared library.
Expose Godot Engine controls (startup, iteration, shutdown) over the GDExtension API to a host process.
On Apple Platforms, Godot Engine windows (both the main window, and other windows created after startup) may be rendered into surfaces provided by the host process.

This support can be extended to other platforms, read on for details.

Sample applications (separate repository)

C++ Sample (tested on MacOS and Linux)
SwiftUI Sample (tested on iOS)

Why LibGodot?
LibGodot has a number of different use cases.

Control Godot Engine from a host application

E.g. Start Godot from a .NET process to use standard .NET tooling

Use it for automation of development tasks (e.g. building an asset pipeline using a Python GDExtension API)
Embed Godot into another application while displaying Godot Windows as part of the host application's UI.

How to try it out?
We provide a Github repository with preconfigured build environment, sample apps and more information: https://github.com/migeran/libgodot_project
Migeran LibGodot Design
The core idea of the LibGodot feature is to build upon Godot's strong extension capabilities: its modularity, powerful type system and the GDExtension API.
The main advantage of this approach is, that this way LibGodot may be used from any language that has a GDExtension binding (e.g. C++, Swift, Rust, Python, ... etc.), with only minimal changes to the binding.
Godot Instance Lifecycle Management
The main class added by the LibGodot design is the GodotInstance:
class GodotInstance : public Object {
	GDCLASS(GodotInstance, Object);

	static void _bind_methods();

	bool started = false;

public:
	GodotInstance();
	~GodotInstance();

	bool start();
	bool is_started();
	bool iteration();
	void shutdown();
};

This class is made accessible over the GDExtension API. This class can be used to control a Godot instance.
To actually create a Godot instance a new symbol is added to the GDExtension API:
GDExtensionObjectPtr gdextension_create_godot_instance(int p_argc, char *p_argv[], GDExtensionInitializationFunction p_init_func);

This function can be used to create a new Godot instance and return a GodotInstance object reference to control it. Both samples show how easy it is to bind this function and then use the generated GDExtension API bindings with the returned GodotInstance object.

Note: Due to Godot's internal architecture (the use of global data structures and singletons) only one Godot instance may be created in a process.
Embedding Godot UI
Note: UI embedding is currently implemented for Apple platforms. Please read the Next Steps section for more information on the status of other platforms.
To allow for embedding the Godot UI into a host process the host process needs to be able to pass the necessary data about a native surface where
Godot may render its contents. The form of this native surface is entirely platform and rendering backend specific.
The Migeran LibGodot design adds the following types to Godot to allow this:

A new DisplayServerEmbedded implementation which uses externally provided native surfaces as its rendering targets.
A RenderingNativeSurface class and its associated platform specific subclasses, e.g. RenderingNativeSurfaceApple.
The Window class is extended by a set_native_surface(Ref<RenderingNativeSurface>) method which allows specifying the rendering target of a Window in a typesafe, platform independent manner. It is even possible to change the rendering target of a Window dynamically during its lifecycle.

These classes are all exposed to the GDExtension API, so it is easy to use them from the host process.
The DisplayServerEmbedded class also exposes methods that allow the injection of input events from the host process into the Godot instance.
The RenderingNativeSurface class hierarchy has an additional function: provides a mechanism using the Factory Method design pattern to create compatible RenderingContextDrivers for a native surface.
This allowed us to make the DisplayServerEmbedded class platform agnostic.
We also refactored the other DisplayServer implementations to use RenderingNativeSurface during initialization.
Since all these classes are exposed over the GDExtension API, these can be seamlessly used from any supported language with a GDExtension binding.
Rationale for RenderingNativeSurface Design
For those who are familiar with Godot Engine internals: there was already a way to pass in platform specific native surface data (called WindowPlatformData) during initialization.
Why is this refactoring necessary to a full fledged reference counted object?

We chose reference counting because it makes it easier to use on the client side, no need to manage the lifecycle manually. Earlier versions of this PR used simple Godot Objects, but they required manual memory management which was error prone.

While on Apple platforms it is very easy to pass in a CAMetalLayer reference, and Metal (and thus MoltenVk) will happily render into it, other platforms impose way more restrictions.

For example: On Windows and Linux a separate Vulkan instance and the use of external textures is required to render Godot on a separate thread from the host application's main renderer thread.

This is not just a theoretical option: We already implemented a prototype on Linux and Windows based on Godot 4.2, where the host process and Godot are using Vulkan External Textures to pass the rendered frames from Godot to the host process. We intend to upgrade and refactor this patch to the current version of the LibGodot patch.

To use External Textures a thread-safe queue has to be implemented between between the host process and Godot, and a reference-counted RenderingNativeSurface subclass would be an ideal place to implement it, e.g. RenderingNativeSurfaceVulkanExternalTextureWin32.

Next Steps
Open for Discussion
We are happy to discuss any part of the design, naming conventions, additional features ... etc.
Merging for Godot 4.3 as an Experimental Feature

We propose to merge the current LibGodot patch as an experimental feature in Godot 4.3, because it is already very usable in its current form for many use cases.

Godot 4.4 Developments
During the Godot 4.4 development cycle additional features may be added, for Example:

Support for additional platforms for UI embedding: Android, Windows, Linux (both X11 and Wayland).
Support for OpenGL (Native / ANGLE) UI embedding on all platforms.
Add a Configuration API that can be used on startup instead of supplying command line parameters.

Sponsors & Acknowledgements

Initial development sponsored by Smirk Software
Rebasing to Godot 4.3 and further development sponsored by Xibbon Inc.

* The GDExtension registration of the host process & build system changes were based on @Faolan-Rad's LibGodot PR: https://github.com/godotengine/godot/pull/72883
About the Authors
This feature was implemented by Migeran - Godot Engine & Robotics Experts.

Production edit: This closes https://github.com/godotengine/godot-proposals/issues/6267.

You can fix some of the github ci actions tests with pre-commit run -a.
Here are the rest of the errors. https://github.com/V-Sekai/godot/actions/runs/8642913827

I've tried to get the Godot Engine Github actions continuous integration to pass. Most tests pass except for Windows. https://github.com/V-Sekai/godot/tree/vsk-libgodot-migeran-4.3

Thanks! I'm so excited to finally see this PR :-)

Thank you, and thank you for taking the time to review it!

I looked only at the GDExtension-related changes so far. There's a bunch of rendering and display server related changes that I haven't looked at.
At high-level, this seems like a pretty good approach. Also, I really appreciate that the code changes to GDExtension are fairly minimal. :-)
On PR #72883, we discussed the possibility of introducing a new concept, perhaps called GDExtensionLoader, that would encapsulate the loading behavior, so that we could have GDExtensionLibraryLoader that used OS::open_dynamic_library() (so the current way) and then maybe a GDExtensionEmbeddedLoader that would just take an initialization function.
However, given how simple the changes are here, I think we could perhaps save something like that for a future refactor? It could make things a little cleaner by not having to constantly check if GDExtension::library is null or not, though.

I think introducing the concept of library loaders would benefit not just this use case, but also other language support that are implemented as GDExtensions. If you recall, I proposed a feature like that in my .NET integration proposal:  https://docs.google.com/document/d/1QwZpo3oIKHyita1mDOIB_xIxdwJ5rtAmpY4_vP9S02Y/edit?usp=sharing
However, I am also not sure if we should try to push this whole loader concept into this PR, we could do that in a follow-up PR. We can discuss this more in the GDExtension meeting.

I've tried to get the Godot Engine Github actions continuous integration to pass. Most tests pass except for Windows. https://github.com/V-Sekai/godot/tree/vsk-libgodot-migeran-4.3
Edited: Time is limited for me to work on this, so I hope this can help your efforts.

Thank you @fire ! Would it be ok if I squash your changes into a single commit, and add it to our branch?

Do what what works for you.

@fire
Are you familiar with the DirectX surface so the UI is not just a desktop BUt standard userControl  compatible with e.g. Avalonial or WPF or WinForm?
https://github.com/migeran/libgodot_project/commit/246cb91cd8a4255f605653869a912d6076a5efa7

For the purposes of this libgodot pull request I am postponing these for the future as listed in the start:
* WPF (w/ WPF DirectX 12 Extensions)
* Support for OpenGL (Native / ANGLE) UI embedding on all platforms.
* Add a Configuration API that can be used on startup instead of supplying command line parameters.

There are several unfinished review comments from @dsnopek to be worked on.

Thank you all for your reviews and contributions. We are working on some updates and will include the contributed features as well. Stay tuned!

does this help with running/embedding the game in editor
related
https://github.com/godotengine/godot-proposals/issues/7213
https://github.com/godotengine/godot-proposals/issues/9142

@octanejohn:

does this help with running/embedding the game in editor

I don't think so. This would allow other applications to embed Godot, but I don't think it would allow Godot to embed Godot. Those proposals offer different approaches to accomplish their goals

This would allow other applications to embed Godot, but I don't think it would allow Godot to embed Godot.

Genuine question, what's the difference?

With this latest update most review comments should be fixed.
Still on the TODO list:

Windows build
Fix CI builds
Create a .NET/C# example using the new GDExtension-based .NET implementation.

Create a .NET/C# example using the new GDExtension-based .NET implementation.

See https://github.com/godotengine/godot/pull/72883#issuecomment-2226296833

@YakoYakoYokuYoku Where did you leave suggestions? I can't see any code suggestions

@AThousandShips
The windows build PR is ready for merge
I think this PR is ready to merge too. Please feedback

@GeorgeS2019 We're in feature freeze for 4.3, and this PR is slated for 4.4. Please be patient.

@YakoYakoYokuYoku Where did you leave suggestions? I can't see any code suggestions

I've messed up with the PR review, my bad. Regardless, here they go.

this PR is slated for 4.4

@akien-mga Is the plan to ship 4.4 with the unified editor (assuming things go well with this and related PRs)?

this PR is slated for 4.4

@akien-mga Is the plan to ship 4.4 with the unified editor (assuming things go well with this and related PRs)?

@rovantiq Could you please point me to the unified editor PRs / proposals that you are referring to?

@rovantiq Could you please point me to the unified editor PRs / proposals that you are referring to?

Maybe rovantiq was refering to the possibility of related PRs, not to specific PRs that he could remember. I remember myself this topic of having an unified .net editor but I can't remember where I first read about it. I have just searched and found a mention about a .net contributors meeting here https://github.com/godotengine/godot-proposals/issues/7895#issuecomment-1737839064, I'm just copy-pasting the text here for convenience.
==========

Since I don't see it mentioned anywhere, I just want to paste below the minutes from last week's .NET contributors meetings regarding this specific topic. Note that I'm just quoting, I don't personally share the same opinion on all of the points.

Editor unification (.NET integration as a plugin/extension) (switch to integration as gdextension or just always bundle it)

Good way to move forward. Decouple C# support from the core. If anything is missing in GDExtension, it would be missing for other languages too.
Would need to drop the entire interop code and rewrite it from scratch. Module uses a number of APIs which might not be exposed to GDExtension yet.
C++ extension would not needed to be reloaded, and it would be able to reload C# assemblies just like the module does currently.
Performance difference need to be assessed - attendees not convinced this would make a difference to the current approach.

The unified editor with .NET support via GDExtension is being worked on (see https://github.com/raulsntos/godot-dotnet), but this is orthogonal to this proposal and thus off-topic.

https://github.com/godotengine/godot/pull/90510#issuecomment-2159522891
Still on the TODO list:

- Fix CI builds

[WIP 18 Aug 2024] There is now working example
https://github.com/migeran/libgodot_project/issues/1#issuecomment-2294996680

Windows build
Create a .NET/C# example using the new GDExtension-based .NET implementation.

Also curious about if it will be published on NuGet.
My use case involves deserializing Godot resources from an ASP.NET Core project so we can read values easily from tres/res files. Having this in a NuGet package would make consumption a breeze.


[bug] Nano Dimmers by Aeotec does not report back to the controller when switched manually

latest from docker : zwavejs/zwavejs2mqtt:latest
Build/Run method

[x] Docker
[ ] PKG
[ ] Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: Alpha - sorry did not grab the version number (but I've updated the docker today if that helps - problem has been there since first docker version of zwavejs
Describe the bug
When using Nano Dimmers by Aeotec the switch itself (normal UK toggle switch) does not report back to the controller it seems.
On the older zwave2mqtt docker this worked correctly, however no matter what setting for

Notification report association group 1 (4-112-1-80)

I set on any of my switches the switch vs HA / Dashboard become out of sync as soon as the light switch itself is used.
I have tracked this down to an error on the debug log  - see bottom Additional Context
To Reproduce
Steps to reproduce the behavior:

Setup latest zwavejs
Have a aeotec nano dimmer
using the hail function as Send Hail CC when using the manual switch to change the load state
Turn the light on via the switch
notice that the dashboard / HA does not mirror the switch values

Interestingly the dimmer value IS set if you use anything other than Hail, however the switch does not appear "on"
Expected behavior
Dashboard / HA to be in-sync with light regardless of source of turning on or off.
Additional context
15:46:23.553 SERIAL » [ACK] (0x06)
15:46:23.555 DRIVER « [Node 004] [REQ] [ApplicationCommand]
└─[ConfigurationCCReport]
parameter #: 80
value size: 1
value: 4
15:46:35.408 SERIAL « 0x010a00040004028201cf00bb (12 bytes)
15:46:35.409 DRIVER Dropping message because it could not be deserialized: The command class Hail
is not implemented
15:46:35.409 SERIAL » [ACK] (0x06)
15:46:38.108 SERIAL « 0x010a00040004028201d200a6 (12 bytes)
15:46:38.109 DRIVER Dropping message because it could not be deserialized: The command class Hail
is not implemented

Humm I think it's something fixed in  https://github.com/zwave-js/node-zwave-js/pull/1278

Humm I think it's something fixed in  https://github.com/zwave-js/node-zwave-js/pull/1278

3\. using the hail function as Send Hail CC

Do you have any other option, e.g. Basic Set or Binary Switch Report?

3\. using the hail function as Send Hail CC

Do you have any other option, e.g. Basic Set or Binary Switch Report?

I've tried to set as basic CC and get the following:
19:25:38.313 SERIAL « 0x010b0004000603200363c9007c (13 bytes)
19:25:38.314 SERIAL » [ACK] (0x06)
19:25:38.316 DRIVER « [Node 006] [REQ] [ApplicationCommand]
└─[BasicCCReport]
current value: 99
19:25:38.317 DRIVER Send queue: (empty) (0 messages)
19:25:38.318 DRIVER send thread state: idle
19:25:38.318 DRIVER Send queue: (empty) (0 messages)
19:25:38.319 CNTRLR [Node 006] [~] [Multilevel Switch] currentValue: 0 => 99 [Endpoint 0]
z2m:Zwave Node 6: value updated: 38-0-currentValue 0 => 99 +12s
19:25:38.320 DRIVER send thread state: idle
z2m:Mqtt Message received on zwave/7/37/1/0/set +26s

As you can see below it's the current value 6 that is still false.
In the older version both the number and true / false that were set. (Based on hail CC)

I've tried to set as basic CC and get the following:
19:25:38.313 SERIAL « 0x010b0004000603200363c9007c (13 bytes)
19:25:38.314 SERIAL » [ACK] (0x06)
19:25:38.316 DRIVER « [Node 006] [REQ] [ApplicationCommand]
└─[BasicCCReport]
current value: 99
19:25:38.317 DRIVER Send queue: (empty) (0 messages)
19:25:38.318 DRIVER send thread state: idle
19:25:38.318 DRIVER Send queue: (empty) (0 messages)
19:25:38.319 CNTRLR [Node 006] [~] [Multilevel Switch] currentValue: 0 => 99 [Endpoint 0]
z2m:Zwave Node 6: value updated: 38-0-currentValue 0 => 99 +12s
19:25:38.320 DRIVER send thread state: idle
z2m:Mqtt Message received on zwave/7/37/1/0/set +26s

As you can see below it's the current value 6 that is still false.
In the older version both the number and true / false that were set. (Based on hail CC)

The Multilevel switch value gets updated correctly now. Currently only the "main" mapping gets done automatically. Since this device identifies itself as a multilevel switch, this is the CC that Basic gets mapped to.
I'm unsure how to proceed with this. Maybe with a compat flag that maps the report to both CCs?

The Multilevel switch value gets updated correctly now. Currently only the "main" mapping gets done automatically. Since this device identifies itself as a multilevel switch, this is the CC that Basic gets mapped to.
I'm unsure how to proceed with this. Maybe with a compat flag that maps the report to both CCs?

@pbathuk In zwave2mqtt were you actually able to control the switch using the binary value, or was it read-only?

@pbathuk In zwave2mqtt were you actually able to control the switch using the binary value, or was it read-only?

Obsolete or not, there are random devices older that use the Hail class. How big of a deal is it to add it?

Obsolete or not, there are random devices older that use the Hail class. How big of a deal is it to add it?

The Hail class has no meaning as defined by the Z-Wave spec, it is application specific. However, I believe a few devices were using this to circumvent "instant status" patents, or something like that, so several hubs treat this as a message to poll the device, including OZW (since 2010!) and OpenHAB. SmartThings implements this on specific device handlers, and for those implementations it seems to just do a Basic Get on the node (only for certain hub versions??). Hubitat is probably the same since it is based on SmartThings. Not sure about other hubs. The consensus seems to be do some sort of Get to refresh the device, whether that's the entire device or just a Basic Get. If there is interest in supporting these old devices, it would be good to implement in this manner.
That said, you can imagine that using the Hail setting on a device like the Nano Dimmer is not ideal if the hub is polling all its values. This dimmer has several value to refresh (several power related, alarms, dimmer level), which will add extra network traffic. In OZW even using the Basic CC isn't the best because it triggers a Get of the multilevel value instead of just using the mapped value as reported. For this reason alone I'd personally configure the Nano Dimmer to send Basic Report (only if there are no Get commands by zwave-js involved) or Switch Multilevel, and just use the dimmer level values instead of the binary one.
For comparison, neither OpenHAB and SmartThings utilize the Binary Switch command class for this device, and SmartThings automatically configures it for Basic Reports.
Also why isn't the current value of the level (6-38-0-currentValue) shown in the screenshot, was it cutoff?

The Hail class has no meaning as defined by the Z-Wave spec, it is application specific. However, I believe a few devices were using this to circumvent "instant status" patents, or something like that, so several hubs treat this as a message to poll the device, including OZW (since 2010!) and OpenHAB. SmartThings implements this on specific device handlers, and for those implementations it seems to just do a Basic Get on the node (only for certain hub versions??). Hubitat is probably the same since it is based on SmartThings. Not sure about other hubs. The consensus seems to be do some sort of Get to refresh the device, whether that's the entire device or just a Basic Get. If there is interest in supporting these old devices, it would be good to implement in this manner.
That said, you can imagine that using the Hail setting on a device like the Nano Dimmer is not ideal if the hub is polling all its values. This dimmer has several value to refresh (several power related, alarms, dimmer level), which will add extra network traffic. In OZW even using the Basic CC isn't the best because it triggers a Get of the multilevel value instead of just using the mapped value as reported. For this reason alone I'd personally configure the Nano Dimmer to send Basic Report (only if there are no Get commands by zwave-js involved) or Switch Multilevel, and just use the dimmer level values instead of the binary one.
For comparison, neither OpenHAB and SmartThings utilize the Binary Switch command class for this device, and SmartThings automatically configures it for Basic Reports.
Also why isn't the current value of the level (6-38-0-currentValue) shown in the screenshot, was it cutoff?

Thanks for all the comments, seems like I have a device (or 4) that does not fully meet the standards, which is always fun.
@kpine I will repeat the basic CC update and copy the full logs + send before and after images as well.
Unfortunately I just accidentally only took one screen shot, rather than a full image.
What I can say, and will grab the logs to share, is that on zwave2mqtt the hail cc only updated a few sections, so not a full refresh.
It will take me a while as working now, but once I have done it I will post all info. Hopefully that helps.
The alternative is (and this would only help me) is that for these devices the HA template uses the dimmer value for on / off rather than the true / false value. That way no other changes would be needed.

Thanks for all the comments, seems like I have a device (or 4) that does not fully meet the standards, which is always fun.
@kpine I will repeat the basic CC update and copy the full logs + send before and after images as well.
Unfortunately I just accidentally only took one screen shot, rather than a full image.
What I can say, and will grab the logs to share, is that on zwave2mqtt the hail cc only updated a few sections, so not a full refresh.
It will take me a while as working now, but once I have done it I will post all info. Hopefully that helps.
The alternative is (and this would only help me) is that for these devices the HA template uses the dimmer value for on / off rather than the true / false value. That way no other changes would be needed.

I tend to agree with @kpine. Implementing the Hail CC is no big deal per se, but the driver needs to react to it, which depends on #1163. While there are sensible workarounds that also don't cause additional network traffic (the Basic Set/Report does not trigger a query), I prefer to work on more pressing matters.
I've lately seen a few devices where the Binary Switch mirrors the Multilevel Switch and don't understand why. Maybe it is worth just hiding the CC on affected devices?

I tend to agree with @kpine. Implementing the Hail CC is no big deal per se, but the driver needs to react to it, which depends on #1163. While there are sensible workarounds that also don't cause additional network traffic (the Basic Set/Report does not trigger a query), I prefer to work on more pressing matters.
I've lately seen a few devices where the Binary Switch mirrors the Multilevel Switch and don't understand why. Maybe it is worth just hiding the CC on affected devices?

I tend to agree with @kpine. Implementing the Hail CC is no big deal per se, but the driver needs to react to it, which depends on #1163. While there are sensible workarounds that also don't cause additional network traffic (the Basic Set/Report does not trigger a query), I prefer to work on more pressing matters.
I've lately seen a few devices where the Binary Switch mirrors the Multilevel Switch and don't understand why. Maybe it is worth just hiding the CC on affected devices?

While I completely understand wanting to work on more pressing things first, unless you disagree I’m going to open a feature request. The fact is that we know some devices use this so it seems odd to just say those won’t work as they were intended. More specifically, though, I think not implementing this will cause many more future headaches. People transitioning will need to reconfigure their devices to use the BasicCC which is going to generate a lot of more basic tech support type issues explaining that and walking them through it.  This also isn’t a minor thing...as I understand how this class is used it informs that the device is on (or rather informs the controller that the device needs to be polled)...so without it any manual control will result in the device state not updating.
In my humble opinion, the transition needs to be as out-of-the-box as possible to reduce strain on your time. If qt-openzwave has 100,000 active users and even if only 1% have an issue with the Hail class, that is still 1,000 issues...

I tend to agree with @kpine. Implementing the Hail CC is no big deal per se, but the driver needs to react to it, which depends on #1163. While there are sensible workarounds that also don't cause additional network traffic (the Basic Set/Report does not trigger a query), I prefer to work on more pressing matters.
I've lately seen a few devices where the Binary Switch mirrors the Multilevel Switch and don't understand why. Maybe it is worth just hiding the CC on affected devices?

While I completely understand wanting to work on more pressing things first, unless you disagree I’m going to open a feature request. The fact is that we know some devices use this so it seems odd to just say those won’t work as they were intended. More specifically, though, I think not implementing this will cause many more future headaches. People transitioning will need to reconfigure their devices to use the BasicCC which is going to generate a lot of more basic tech support type issues explaining that and walking them through it.  This also isn’t a minor thing...as I understand how this class is used it informs that the device is on (or rather informs the controller that the device needs to be polled)...so without it any manual control will result in the device state not updating.
In my humble opinion, the transition needs to be as out-of-the-box as possible to reduce strain on your time. If qt-openzwave has 100,000 active users and even if only 1% have an issue with the Hail class, that is still 1,000 issues...

If qt-openzwave has 100,000 active users and even if only 1% have an issue with the Hail class, that is still 1,000 issues being open...

Agreed. In the meantime it would help if you (or others) could collect some examples/requirements polling support. Like what is being polled and when.

If qt-openzwave has 100,000 active users and even if only 1% have an issue with the Hail class, that is still 1,000 issues being open...

Agreed. In the meantime it would help if you (or others) could collect some examples/requirements polling support. Like what is being polled and when.

If qt-openzwave has 100,000 active users and even if only 1% have an issue with the Hail class, that is still 1,000 issues being open...

Agreed. In the meantime it would help if you (or others) could collect some examples/requirements polling support. Like what is being polled and when.

Will do. I’ll see which of my devices have a Hail option (even if I’m not using it) and then capture what they’re doing.

If qt-openzwave has 100,000 active users and even if only 1% have an issue with the Hail class, that is still 1,000 issues being open...

Agreed. In the meantime it would help if you (or others) could collect some examples/requirements polling support. Like what is being polled and when.

Will do. I’ll see which of my devices have a Hail option (even if I’m not using it) and then capture what they’re doing.

@AlCalzone I can confirm that with the #1308 cc/hail branch my Aeotec dimmers now report their status when set to either Hail or Basic CC.
I’m controlling this via direct association as mine don’t have switches... @pbathuk can you confirm with a manual switch state? It should be the same.

@AlCalzone I can confirm that with the #1308 cc/hail branch my Aeotec dimmers now report their status when set to either Hail or Basic CC.
I’m controlling this via direct association as mine don’t have switches... @pbathuk can you confirm with a manual switch state? It should be the same.

@blhoward2 thanks. From reading #1308 it does seem to do what is needed.
I was wondering how I build my own docker image (as run using docker-compose on Ubuntu) to test this?
@AlCalzone I see you have managed to get this working, if you could let me know how I will gladly test.

@blhoward2 thanks. From reading #1308 it does seem to do what is needed.
I was wondering how I build my own docker image (as run using docker-compose on Ubuntu) to test this?
@AlCalzone I see you have managed to get this working, if you could let me know how I will gladly test.

@blhoward2 thanks. From reading #1308 it does seem to do what is needed.
I was wondering how I build my own docker image (as run using docker-compose on Ubuntu) to test this?
@AlCalzone I see you have managed to get this working, if you could let me know how I will gladly test.

DOCKER_BUILDKIT=1 docker build --build-arg SRC=git-clone-src --build-arg Z2M_BRANCH=fix#23 --build-arg ZWJ_BRANCH=cc/hail --no-cache -f zwavejs2mqtt/docker/Dockerfile.contrib -t zwavejs2mqtt .
Then change your image in your docker-compose to be zwavejs2mqtt:latest

@blhoward2 thanks. From reading #1308 it does seem to do what is needed.
I was wondering how I build my own docker image (as run using docker-compose on Ubuntu) to test this?
@AlCalzone I see you have managed to get this working, if you could let me know how I will gladly test.

DOCKER_BUILDKIT=1 docker build --build-arg SRC=git-clone-src --build-arg Z2M_BRANCH=fix#23 --build-arg ZWJ_BRANCH=cc/hail --no-cache -f zwavejs2mqtt/docker/Dockerfile.contrib -t zwavejs2mqtt .
Then change your image in your docker-compose to be zwavejs2mqtt:latest

@AlCalzone @blhoward2 I managed to get a chance to run the latest zwavejs2mqtt (dev) on docker - sorry did not build a new one but used a pre-built dockerhub.com one
Happy to be told if this does not include this fix, but tracking through I can see that it was merged & built into master 16 hours ago and the dev branch was last updated 2 hours ... but maybe i'm misssing something.

For future logs, please enable writing the zwave-js logs to a file and attach them. Inline logs make these issue threads insanely long and your paste is formatted strangely.

@pbathuk That log doesn't look like it comes from the current master.
For future logs, please enable writing the zwave-js logs to a file and attach them. Inline logs make these issue threads insanely long and your paste is formatted strangely.

Happy to close this issue as the new zwavejs2mqtt beta (1.0.0) uses the latest version of zwave-js and it fixed my light issue :)
Hail now works for me on all my switches.

Happy to close this issue as the new zwavejs2mqtt beta (1.0.0) uses the latest version of zwave-js and it fixed my light issue :)
Hail now works for me on all my switches.


BlockMerging出错！！！

我使用了您的训练模型，并且下载了完整且没有错误的S3DIS数据用于测试。
但是在BlockMerging这里出现了 :     index 129 is out of bounds for axis 0 with size 100这样的问题。
想请教您这个问题到底出在哪里了呢？

Hi, I'm running this model, too. The inference_merge.py file was found missing during training. Have you ever encountered this problem? Do you have this file to share?

@swjtu-jia-wei @LH1005 @WXinlong hello! have encountered the same issue, like this:
Traceback (most recent call last):
File "test.py", line 261, in
test()
File "test.py", line 202, in test
groupids_block.astype(np.int32), group_seg, gap)
File "/mnt/pjn/segment/ASIS/utils/test_utils.py", line 184, in BlockMerging
groupcounts[grouplabel[i]] += 1
IndexError: index 686 is out of bounds for axis 0 with size 100
that's why? i can't understand


Update SetupAndTeardown.md

Quick suggestion that may make the docs clearer.

Summary

I had a hard time reading that sentence.
Test plan
Only a documentation change

Thanks! Could you update the version in docs/?


net/http: why isn't there any mentioning about the need for usage of UTC with http.TimeFormat??

I was trying to use the http.TimeFormat to format a http response and the way I found to do that is using:
time.Now().UTC().Format(http.TimeFormat)
which uses the format ...
const TimeFormat = "Mon, 02 Jan 2006 15:04:05 GMT"
But it's just using the format to output a string with a GMT in it.
I have seen that everywhere in the golang code it's being used with a UTC() time conversion and I think that it is worth to mention that it uses the local time but just adds a GMT to it unless the time is being converted to UTC using the UTC() function.
I encountered this issue more then once in the last couple month and I have not found anything actually mentioning it that you need to use UTC() with it in the docs.(which can confuse).
Can a small addition to the http.TimeFormat  constant documentation be added??

CC @bradfitz

Sure. https://golang.org/cl/18933

Thanks!


Exception when using CompileToDynamicAssembly with ReflectedDefinition

I'd like to compile some code on the fly and get the quotation. I tried doing:
let scs = SimpleSourceCodeServices()
let fn2 = Path.GetTempFileName() + ".fs"
File.WriteAllText(fn2,"""
module Main
[<ReflectedDefinitionAttribute>]
let add a b = a + b""")

scs.CompileToDynamicAssembly([| "-o"; "compiled.dll"; "-a"; fn2 |], execute=None)

This fails with:
System.Exception: convCustomAttr: {mspecMethodRef =
  {mrefParent =
    {trefScope = Assembly Microsoft.FSharp.Compiler.AbstractIL.IL+ILAssemblyRef;
     trefEnclosing = [];
     trefName = "Microsoft.FSharp.Core.CompilationMappingAttribute";
     hashCode =<PHONE_NUMBER>;
     asBoxedType = Boxed {tspecTypeRef = ...;
                          tspecInst = [];};};
 (lots more stuff omitted)
   at Microsoft.FSharp.Compiler.AbstractIL.ILRuntimeWriter.convCustomAttr@1334.Invoke(String message) in C:\GitHub\fsharp\FSharp.Compiler.Service\src\absil\ilreflect.fs:line 1334
   at Microsoft.FSharp.Compiler.AbstractIL.ILRuntimeWriter.convCustomAttr(cenv cenv, emEnv emEnv, ILAttribute cattr) in C:\GitHub\fsharp\FSharp.Compiler.Service\src\absil\ilreflect.fs:line 1334
   at Microsoft.FSharp.Compiler.AbstractIL.ILRuntimeWriter.emitModuleFragment@2085-1.Invoke(ILAttribute cattr) in C:\GitHub\fsharp\FSharp.Compiler.Service\src\absil\ilreflect.fs:line 2085

Is this something that should work?

For starters, perhaps try a set of command line flags using --noframework, making all assembly references including FSharp.Core explicit (like the command line that would be used by an MSBuild/xbuild compilation).

Just tested this with version <IP_ADDRESS> and it works there! Will try adding the --noframework option when I start using it though. Thanks!

It was unrelated to that suggestion - I think it's a fix that has come through from Microsoft\visualfsharp


[BUG] Header Component Icon Not Rendering Properly on Edit Post Page

Description
When navigating to the edit post page and attempting to edit a post, the header component fails to render as expected. The header should display the title "Edit" along with an icon to the left, but neither the title nor the icon is visible. This issue obstructs users' ability to identify the purpose of the page and affects the overall user experience.
Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
No response

Hey @Nishitbaria , I can work on this issue please assign this issue to me.


Optimize NodeIndicesStats output behind flag

Description:
As of today the APIs which fetch Node Stats with indices stats currently returns all shard statistics regardless of the requested level (node, level, or indices) to the coordinator node (node where-in or from which the rest request was created). This unnecessary iteration on the coordinator node leads to overhead and potential health issues. Furthermore,  the coordinator node repeats index-level statistics calculation for each node response even when the requested level is indices.
This pull request proposes optimizations to the NodeStats API to pre-compute and return only the necessary information to generate the response. The APIs would now perform pre-computation of shard or index-level statistics on remote nodes (individual nodes which respond to the coordinator node) based on the level parameter in the REST request - nodes, indices or shards.  Only for level = shards does the response contains the shard level stats.
The optimisation hides behind a flag transport level flag optimizeNodeIndicesStatsOnLevel part of CommonStatsFlag. This is enabled in RestNodeStatsAction as well as RestNodeAction API calls as we do not require it during these code paths.
Pre-computation on remote nodes minimizes data transfer and processing on the coordinator node, leading to significant performance gains, especially in large clusters. Reduced load on the coordinator node contributes to a healthier state by minimizing GC pauses and CPU spikes.
Testing:
Extensive testing with a 20k shards cluster has validated the effectiveness of these optimizations.

Stats
Without Optimisation
With Optimisation

Average
0.857280048
0.4961762

P90
1.1514673
0.7631599

Max
1.78542
1.423496

Min
0.444184
0.212655

Related Issues
Resolves #13340

Check List

[x] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[Test Result](https://build.ci.opensearch.org/job/gradle-check/42419/testReport/) (3 failures / -5)
[org.opensearch.discovery.ClusterDisruptionIT.classMethod](https://build.ci.opensearch.org/job/gradle-check/42419/testReport/junit/org.opensearch.discovery/ClusterDisruptionIT/classMethod/)
[org.opensearch.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureLastSuccessfulSettingsUpdate](https://build.ci.opensearch.org/job/gradle-check/42419/testReport/junit/org.opensearch.index/ShardIndexingPressureSettingsIT/testShardIndexingPressureLastSuccessfulSettingsUpdate/)
[org.opensearch.indices.replication.SegmentReplicationIT.testReplicaAlreadyAtCheckpoint](https://build.ci.opensearch.org/job/gradle-check/42419/testReport/junit/org.opensearch.indices.replication/SegmentReplicationIT/testReplicaAlreadyAtCheckpoint/)

For org.opensearch.discovery.ClusterDisruptionIT.classMethod
java.lang.AssertionError: SpanData validation failed for validator org.opensearch.test.telemetry.tracing.validators.AllSpansAreEndedProperly
MockSpanData{spanID='aa1534630900e459', parentSpanID='f8c436a5e84c915f', traceID='d7fd33dd4c374128', spanName='dispatchedShardOperationOnPrimary', startEpochNanos=2792950755631, endEpochNanos=0, hasEnded=false, attributes={index=restart_while_indexing, refresh_policy=false, thread.name=opensearch[node_t1][write][T#1], bulk_request_items=1, shard_id=0, node_id=uRqO2n91TTCp5ocLhE5MQA}, stackTrace=null}

Similar to failures in Flaky Test Issue - #14308

For org.opensearch.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureLastSuccessfulSettingsUpdate
java.lang.AssertionError: expected:<0> but was:<2>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
	at org.opensearch.index.ShardIndexingPressureSettingsIT.lambda$waitForTwoOutstandingRequests$13(ShardIndexingPressureSettingsIT.java:939)
	at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1128)
	at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1101)
	at org.opensearch.index.ShardIndexingPressureSettingsIT.waitForTwoOutstandingRequests(ShardIndexingPressureSettingsIT.java:938)
	at

Similar failures in Flaky Test Issue - #14331

For org.opensearch.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureLastSuccessfulSettingsUpdate
Flaky Test - #14328

❌ Gradle check result for 8416ec8: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Test Result (1 failure / +1)
org.opensearch.action.admin.indices.create.RemoteCloneIndexIT.testCreateCloneIndexLowPriorityRateLimit
Flaky - https://github.com/opensearch-project/OpenSearch/issues/14292

❕ Gradle check result for 8029c78: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Test Result (1 failure / ±0)
org.opensearch.http.SearchRestCancellationIT.testAutomaticCancellationDuringFetchPhase
https://github.com/opensearch-project/OpenSearch/issues/14311

❕ Gradle check result for 1128006: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Test Result (1 failure / -1)
org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock
Flaky - https://github.com/opensearch-project/OpenSearch/issues/14289


Introduce GD32F4xx serial SoCs with GD32F450i_EVAL board

Initial version for GD32F4xx serial SoCs support. There also have a more functional serial driver https://github.com/zephyrproject-rtos/zephyr/pull/39897 in progress.
[EDIT]: About GD32 support on zephyr, more info can be found in https://github.com/zephyrproject-rtos/zephyr/issues/38657

Hi @gmarull
I found you are also work on GD32F450i_EVAL board at https://github.com/teslabs/zephyr/tree/gd32f450
Since this PR not have the GD32F450i_EVAL board description, I think we can work together to finish it.
I have done the board basic init with the hello_world sample.
This PR use J-Link to Flash and Debug the board.
Best,
Cameled

Since I already had the support ready for this board I've opened https://github.com/zephyrproject-rtos/zephyr/pull/39958 which has some more things, e.g. GD-Link support, docs and some HAL/DTS re-organization (use series/soc more in line with manufacturer practices, since GD32 is not following STM32 conventions).
Let's try to find a way to merge both, since this PR also has interesting stuff like J-Link support and F405/407 initial support.

Let's try to find a way to merge both, since this PR also has interesting stuff like J-Link support and F405/407 initial support.

There is a task list at #38657 and everyone is invited to add their name at tasks that want to do and avoid duplicated work. I saw that @gmarull already assumed some tasks. This is very important to avoid this kind of conflicts.
@cameled, do you mind rebase on top of #39958 in this particular case?

Let's try to find a way to merge both, since this PR also has interesting stuff like J-Link support and F405/407 initial support.

There is a task list at #38657 and everyone is invited to add their name at tasks that want to do and avoid duplicated work. I saw that @gmarull already assumed some tasks. This is very important to avoid this kind of conflicts.
@cameled, do you mind rebase on top of #39958 in this particular case?

Rebase is good. I don't have much more time to improve this recently.


Limit mac os jobs

Changelog
- description: |
    Limit mac os jobs
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated. See Running tests for more details
[ ] Self-reviewed the diff

cc @carbolymer if you want to have a look again after the rebase.
LGTM, thanks @newhoggy :+1:

cc @carbolymer if you want to have a look again after the rebase.
LGTM, thanks @newhoggy :+1:

LGTM, but do we need macos job still?

cc @Jimbo4350, but anyway, since this a net improvement reducing the CI pressure on MacOS runners; I'm enqueueing for merge. We can delete the MacOS runs altogether later on.


Does this code work properly with the model universal_transformer?

Description
...
I try to run it,and it report a error,and I try to fix it,but the code can not to set eager execution,I also try to fix it by the code replace original ,
In the file universal_transformer_util.py line 581:state, inputs, memory = layer_inputs
replaced by the follow
state, inputs, memory = layer_inputs[0], layer_inputs[1], layer_inputs[2]
it also not fix.and report a "ValueError: The two structures don't have the same nested structure.",So I want to ask a question : what can I do fix this error.
Environment information
OS: ubuntu 16.4

$ pip freeze | grep tensor
# tensorboard==1.7.0  tensorflow-gpu==1.8.0rc1

$ python -V
# Python 2.7.14 :: Anaconda, Inc.

$ tensor2tensor version
# tag v1.7.0

For bugs: reproduction and error logs
PROBLEM=translate_envi_iwslt32k
MODEL=universal_transformer
HPARAMS=universal_transformer_base

CUDA_VISIBLE_DEVICES=1 code/t2t-trainer \
  --data_dir=$DATA_DIR \
  --problem=$PROBLEM \
  --model=$MODEL \
  --hparams_set=$HPARAMS \
  --output_dir=$TRAIN_DIR

# Steps to reproduce:
...
``` just run it

Error logs:
...
TypeError: Tensor objects are not iterable when eager execution is not enabled. To iterate over this
tensor use tf.map_fn.

Universal Transformer uses a fold function that also supports processing nested tensors, which was released in TF 1.9. Just update your TensorFlow to 1.9 or 1.10 and this should be fixed.


Issues with stable ids

Such as when the source is a dynamic amount of information. (Potentially 10-50 items depending on the data passed)

Hi. This library requires stable IDs (setHasStableIds(true)) to the distinguish dragged/swiped target item. I think it's not an critical issue, because it's possible to assign non-overlapped identifiable number for each item of dynamic data source.


Process#wait without closing input

Noticed that Process#wait closes the input pipe, but I would like to write to the input, until the process has died, I thought this would do it:
p = Process.new("cat", input: Process::Redirect::Pipe, output: Process::Redirect::Pipe, error: Process::Redirect::Pipe)
spawn do
  loop do
    p.input.puts "abc"
    sleep 1
  end
end

spawn do
  loop do
    puts p.output.gets
  end
end

p.wait

But that will raise IO::Error on the first input.write because the input pipe has been closed already by wait. Is my thinking wrong or could we add a parameter e.g.Process#wait(close_input = true)?

I think the first relevant question is if the fact that the pipes are closed in the first place is a bug or not.

I don't think it should...

Just came across this issue aswell. Would be nice to not close the process's input IO when waiting it to terminate.
In general, a way to know that a process finished without affecting it's IO.


✨PersistentVolumeClaim support UWS status update

User Story
As a user, I want to update the spec.resources.requests.storage of PVC, but I found that after updating requests.storage, status.capacity.storage is not updated synchronously, resulting in an exception when kubectl get pvc.
Detailed Description

Anything else you would like to add:
Should we consider updating the pPVC status synchronously to the pPVC?
/kind feature

Yes，At present, the PVC status.capacity is updated by the CSI driver after allocating storage space. and now after the spec.requests.storage of the PVC is updated in the VC, it is synchronized to the super, and then the PVC status on the super is updated by the CSI driver, but the status in the VC has not been updated.

Sure. Then adding uws makes sense.  Btw, I did not get this part " an exception when kubectl get pvc." .  What is the error?

Sure. Then adding pvc uws makes sense. Btw, I did not get this part " an exception when kubectl get pvc." . What is the error?

$ kubectl get pvc data0-kafka-1 -n confluent
NAME            STATUS   VOLUME                   CAPACITY   ACCESS MODES   STORAGECLASS                  AGE
data0-1         Bound       d-2zexxxxxxxxxxxxxx   1000Gi           RWO            storageclass-name                13d

It will show like this, capacity is displayed incorrectly. But in fact, the storage of PVC has been updated.


[v0.16.1] Fix rendering for openICMP

Changes
Rendering for the new openICMP feature was broken when more than one addressed was assigned to sshAccessAllowedSourceCIDRs, this fixes it.

Codecov Report

Merging #1867 into v0.16.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           v0.16.x    #1867   +/-   ##
========================================
  Coverage    24.41%   24.41%
========================================
  Files           98       98
  Lines         5116     5116
========================================
  Hits          1249     1249
  Misses        3727     3727
  Partials       140      140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a43cd06...ba4664d. Read the comment docs.


Unknown Named Parameter $match in Zend_Filter::filterStatic()

This code works in PHP 7.4
        if ( isset($params['method']) ) {

            $method = Zend_Filter::filterStatic(
                    $params['method'],
                    'PregReplace', array('match' => '/[^A-Za-z0-9_]/', 'replace' => '')
                );

            $this->{$method}($params);
        }

Fails in PHP 8.1.23
Exception information:
Message: Unknown named parameter $match
Stack trace:
#0 .../vendor/shardj/zf1-future/library/Zend/Filter.php(229): ReflectionClass->newInstanceArgs(Array)
#1 .../application/services/Ad.php(81): Zend_Filter::filterStatic('getReferralAdDa...', 'PregReplace', Array)

Solution
It appears that the issue is with passing named parameters into the newInstanceArgs() method of the Reflection class. In PHP 7 this gets ignored, but it doesn't get ignored in PHP 8 and tosses an exception.
The solution is to update the ZF1 code as follows (example):
$object = $class->newInstanceArgs( $args );

becomes
$object = $class->newInstanceArgs( array_values( $args ) );

The following files are affected and need to be tested (see screen shot of IDE showing files affected).

I tested this locally on the Zend_Filter::filterStatic() method and it works, but I don't have a testing environment setup yet. If someone wants to jump in for the fix I will send you a Starbucks!  :D


Status "unbounded" for a correct model?

For some benchmark tests I invoked the "catenary example" with N=1000 chain links and got the following status message:
N = 1000
L = 2; h = L/N
x = Variable(N+1)
y = Variable(N+1)
objective  = sum(y)
constraint = list(x[1] == 0, x[N+1] == 1,
                  y[1] == 1, y[N+1] == 1,
                  diff(x)^2 + diff(y)^2 <= h^2)
problem <- Problem(Minimize(objective), constraint)
result <- solve(problem)

result$getValue(x); result$getValue(y)
## [1] NA
## [1] NA
result$status
## [1] "unbounded"

The same code with N=100 returns the usual catenary line with status "optimal", and with N=500 NAs again and a status of "optimal_inaccurate".
I think, "optimal_inaccurate" is a correct message (the same we get with solver SCS, the result being far off the truth), but a status message "unbounded" for a model that works with a smaller numbers of variables does not seem right.

CVXR is merely reporting what the default solver (ECOS) said. And different solvers report differently. In such cases, using the parameter verbose = TRUE to solve is revealing.
However, I plan to look into why the version of the problem handed to ECOS by CVXR (and CVXPY too) cause it to fail.

As a note, tweaking the solver parameters seems to help the solver.
result <- solve(problem, FEASTOL = 1e-4, RELTOL = 1e-3, verbose=TRUE)

But what I said above still holds.

Yes, that would be interesting, because when I hand-code the matrices and send them to ECOS resp. SCS directly (without any intervention by CVXR), them both solvers return a good solution within less than 0.5 sec -- no need to set any options.

This is mostly a solver issue, depending on how the problem details are handed to it. This did expose another bug relating to how CVXR expressions are considered positive or negative and that is now addressed in version 0.97+


Firefox web workers

AFAIK Firefox doesn't support ESM in workers ATM so setting workers.format to es will break the resulting sure in Firefox. I think Vite explicitly has code to transform workers in dev mode rather than rely on ESM so they will work in Firefox. Any way to get this plugin to work with classic workers?

Rollup only accepts code with TLA in ES mode, not in IIFE mode. So I'm going to add some magic hack in my plugin (vite-plugin-top-level-await) to make the worker code build as ES first and then transform the built code to IIFE to make it work in Firefox.

BTW, Firefox is going to add

Supported with vite-plugin-top-level-await v1.3.0.


fix(api): update out of date cert api docs

Fixes #338

Nice - It is missing the attach and detach endpoints but that's probably fine for now

@helgi I'll fix that tomorrow morning!

Sweet thanks!

@helgi Added attach and detach.


The match() method of the String type fails even on simple patterns

Tested versions
v4.2.stable.official [46dc27791]
System information
Godot v4.2.stable - Windows 6.1.7601 - GLES3 (Compatibility) - GeForce 8600 GTS () - Intel(R) Core(TM) i5-4570 CPU @ 3.20GHz (4 Threads)
Issue description
The match() method of the String type uses regex to return a bool if a pattern is matched in the string. This method failed to find any matches when the pattern used a list ie [ ]
I tested this on Windows 7 and also on Ubuntu 24.x.
I tested the regex expressions on regex101.com and they all work there.
I tested these regex expressions in Python script and they work as expected there.
Steps to reproduce
func _ready() -> void:
	printt("3".match("3"), "3".match("[1234]"), "3".match("[3]"), "3".match("*"), "3".match("[123]*"))
	printt("a".match("a"), "a".match("[abcde]"), "a".match("[a]"))

This outputs:
true	false	false	true	false
true	false	false

All of these should have produced true.
Minimal reproduction project (MRP)
func _ready() -> void:
	printt("3".match("3"), "3".match("[1234]"), "3".match("[3]"), "3".match("*"), "3".match("[123]*"))
	printt("a".match("a"), "a".match("[abcde]"), "a".match("[a]"))

It doesn't support this syntax, it says what it supports in the documentation, where did you see it mentioned it supports that?
It doesn't use a regex to do this, to do that you need to use RegEx instead

I understand now. Please mark this as Not A Bug.


http: provide built-in support for filtering, pipe and middlewares

The http package was developed based on middleware. Just like in express, filter and pipe middlewares can be added.


Wait until container exits in test to remove race condition

I expect this will fix #1502

Do you now get You cannot attach to a stopped container, start it first messages in the case where there wasn't a problem previously?

Yes, but they are hidden unless the test fails.

That's rather misleading though.

I get:
$ ./666_abuse_of_start_test.sh
Abuse of 'start' operation
2c16a52b2600c4c3d59414880c1bbfc07533a9c400d356d971236630e3a87991
8811c22051e3d2346bb0974be0c9c6cd2b9744159f94ff94c48d83453ccc7823
You cannot attach to a stopped container, start it first
a88ac7421149515ffa3db7d7c7af2f8a4c63fd2dc934491e31382888eb6ae314
You cannot attach to a stopped container, start it first
86b2383e480d1a580494e498c57f9fa08613da55352633a222fa58b6cf4e3065
You cannot attach to a stopped container, start it first
5c6a707a781e6e0d186b28f36f1ece107d8f787da226bbae664401636abf2c9a
all 5 tests passed in 4.433s.

Fixed in ed957715


✨ suspend user feature

requires https://github.com/TryGhost/Ghost/pull/8114

adds "(Un-)Suspend User" options on user profile page with a modal confirmation screen
separates team index into "active" and "suspended" users
adds "suspended" badge to user profile when suspended
updates oauth2-ghost authenticate method to handle an ember-ajax error object instead of an xhr (fixes "There was a problem on the server" message instead of "Your account has been suspended" when trying to log in)
bumps gh-task-button test timeouts to avoid random test failures

TODO:

[x] add "un-suspend user" option and confirmation modal
[x] remove OAuth-only restriction
[x] indicate which users are suspended on team index
[x] indicate a user is suspended when viewing their profile
[x] display useful error message when trying to log in as a suspended user
[x] tests

Coverage decreased (-0.2%) to 73.098% when pulling 04d81dc8c9494f30d1f00db86b955b0b78d52a87 on kevinansfield:suspend-users into bc4e60766162a40ae537a64ae403f4937122375b on TryGhost:master.

Coverage increased (+0.6%) to 73.941% when pulling 86821ed6f6a13292a6ab00c5ed81c94e113d2793 on kevinansfield:suspend-users into 4d66ca653a299c84a623920134f8c9cb87d79b0c on TryGhost:master.


MS standard SKU CDN Rewrite action does not support Regex or wildcards

I got confirmation from Microsoft support team (azure support ticket<PHONE_NUMBER>001959) that MS standard SKU CDN Rewrite action source pattern does not support regex or wildcards. Therefore, the documentation is incorrect in the below statement as it does not use regex or prefix-based match:
Source pattern | Define the source pattern in the URL path to replace. Currently, source pattern uses a prefix-based match. To match all URL paths, use a forward slash (/) as the source pattern value.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 87d90250-071e-0775-00f7-f25fcc65ef80
Version Independent ID: 8b3c648d-c348-b11f-68cc-5445feba3aa0
Content: Actions in the Standard rules engine for Azure CDN
Content Source: articles/cdn/cdn-standard-rules-engine-actions.md
Service: azure-cdn
GitHub Login: @asudbring
Microsoft Alias: allensu

Thanks for the feedback! I have assigned the issue to the content author to investigate this and update the document as appropriate.

This document made me look into the CLI for az, specifically for the MS standard SKU CDN.
I was able to get around the /. requirement by using the aforementioned CLI. Prior to this I could not get my URL rewrite to work properly for my React SPA client side routing.
Here's the command:
az cdn endpoint rule add -g resourceGroupName -n endpointName --profile-name cdnProfileName --order 1 --rule-name "ruleName" --match-variable UrlFileExtension --operator LessThan --match-values 1 --action-name "UrlRewrite" --source-pattern "/" --destination "/index.html" --preserve-unmatched-path false

Now instead of requiring the /. you have the working config / as pictured below. Please adjust it so we can use / instead of /. or just update it so /. works as the catch-all as it does not currently for the MS standard SKU CDN.

#reassign: jessie-jyy

Hello @sergiosolorzano, I removed the prefix-based text from that section to avoid confusion. Please let me know if you have any questions. Thank you. #please-close


[CARBONDATA-2302]Fix some bugs when separate visible and invisible segments info into two files

There are some bugs where separate visible and invisible segments info into two files:

It will not delete physical data of history segments after separating
Generate duplicated segment id

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?  No

[ ] Any backward compatibility impacted?  No

[ ] Document update required?  No

[x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4227/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3493/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4720/

retest sdv please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4228/

retest sdv please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4229/

retest sdv please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4231/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4233/

retest sdv please

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4235/

@ravipesala @jackylk  please review, thanks

LGTM


Set sentinel default port when no port is provided

Now when a Redis sentinel configuration is provided without a port
or with a nil or empty port, the sentinel default port is configured
to it.

bors r=@unleashed, @eguzki


runtime/host/sgx: Log the advisory URLs on attestation failure

The commit and pr should read "advisory IDs", oops.


AccessCodes - Add ability to disable create/edit

Extension of #236, there should be props to disable create, or edit.
<AccessCodeTable />:

[ ] Add disableCreate, disableEdit, disableDelete props to the AccessCodesTable component
[ ] Show + button when disableCreate is false
[ ] Show "menu" button on Code row when disableEdit and disableDelete is false

<AccessCodeDetails />:

[ ] Add disableEdit and disableDelete props to the AccessCodeDetails component

Closing as all of these are actually handled, though the disable* are hardcoded while AccessCodes are not released.


Fix typo

Fixing what seems to be a typo in the authorization section of the docs.

@KevinAsgari could you please review this PR? 😄


docs(codecov): favour npx over installing locally

Coverage remained the same at 96.82% when pulling 8b16fe6b737174da222ec50386078ee15163acf4 on docs/fixup-codecov into 85c1eacc8d403a8960caa7ac4a3d22bd528b6422 on master.

Coverage remained the same at 96.82% when pulling 8b16fe6b737174da222ec50386078ee15163acf4 on docs/fixup-codecov into 85c1eacc8d403a8960caa7ac4a3d22bd528b6422 on master.


selector must be dynamic

innertext of share stock must be dynamic

#114  this is a duplicate of this id


Created in C

fixed #6

@iankitdabas has already sent a pull request. Please first comment on the issue to get assigned. Don't directly send a pull request.


renamed metabake to intu.dev

Old: MetaBake was mostly a CLI tool, with a bit of WebAdmin.
The new version: intuition.dev still has CLI way to generate code, but is now primarily a WebAdmin tool.
With the new name, there is a new website/domain that matches the new name (old domain redirects to the new domain).

Can we bump this please? I change project name due to WebAdmin.

Done, thanks!


Stop support the Ubuntu 14.04

The Ubuntu PPA has stop support the Ubuntu 14.04 on 14 hours ago (Sat May  4 08:54:30 CST 2019), so I will stop support it first.

https://launchpad.net/~ondrej/+archive/ubuntu/php/+index?batch=75&memo=150&start=150

php7.0 | 7.0.33-7+ubuntu19.04.1+deb.sury.org+1 | Ondřej Surý                                      (14 hours ago)
php7.0 | 7.0.33-7+ubuntu18.10.1+deb.sury.org+1 | Ondřej Surý                                      (14 hours ago)
php7.0 | 7.0.33-7+ubuntu18.04.1+deb.sury.org+1 | Ondřej Surý                                      (14 hours ago)
php7.0 | 7.0.33-7+ubuntu16.04.1+deb.sury.org+1 | Ondřej Surý                                      (14 hours ago)

The build failed on CI.

Travis CI APP [8:41 AM]
Build #177 (4962656) of chusiang/php7.ansible.role@develop by Chu-Siang Lai failed in 19 min 52 sec

https://travis-ci.org/chusiang/php7.ansible.role/jobs/527856480

The CI jobs were all passed, and improved to Galaxy, so I close this issue.


TO golang -- validation checks for divisions

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1165/
Test PASSed.


PyTorch reduction='none' is not properly handled

When loss option reduction='none', then in backward function self.grads.mul_(grad_output) cannot be properly computed.
Because grad_output dim is [batch_size] and self.grads dim is [batch x seqLength x labelLength x outputDim].
My ad-hoc solution would be making grad_output broadcastable by grad_output.view(-1, 1, 1, 1).

The bug is fixed, thank you very much!


fix: do not add additional end-of-file newline

As discussed in #205, this PR fixes the printing and prevent typstyle from adding unintended additional end-of-file newlines.

Hi, please rebase latest master. I've fixed the ci

I will release a new version when I leave work