Fix issue with cutoffs for small number of remaining items.

There is unexpected behavior when the list of remaining words is less than 20 in easy mode.
The issue is that when the number of remaining words is less than 20, we still set the stop to 20, but i will never reach that. This is fine in hard mode because the iterator will run out after all remaining words are processed, but in easy mode we will process the full dictionary. This does causes an increase in runtime for marginal benefit in score, but the point of cutoff mode is to sacrifice score for better performance.
I discovered this while playing around with parallelism, but was getting slightly different results with the same configuration.

Version
Runtime
Score

main Branch
~36s
3.6215

This PR
~30s
3.6223

Codecov Report

Merging #20 (352431c) into main (4482ad1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   80.35%   80.35%
=======================================
  Files           4        4
  Lines         341      341
=======================================
  Hits          274      274
  Misses         67       67

Impacted Files
Coverage Δ

src/solver.rs
86.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4482ad1...352431c. Read the comment docs.


Dynamic Links on Android with C++ SDK only received if App not started previously

We've setup dynamic link creation both on iOS and Android with the Firebase Dynamic Link C++ SDK. All is working perfectly fine on iOS, links get received and the Listener is triggered whether the App is closed before or not. This is our Listener code:
void PlatformManager::OnDynamicLinkReceived(const firebase::dynamic_links::DynamicLink *dynamic_link)
{
        MLLOG("[PlatformManager] OnDynamicLinkReceived - Received link: %s", dynamic_link->url.c_str());
}

App Init:
#if CC_TARGET_PLATFORM == CC_PLATFORM_IOS

    firebase::AppOptions appOptions;
    _firebaseApp = firebase::App::Create(appOptions);

#elif CC_TARGET_PLATFORM == CC_PLATFORM_ANDROID

    firebase::AppOptions appOptions;
    _firebaseApp = firebase::App::Create(firebase::AppOptions(), JniHelper::getEnv(), JniHelper::getActivity());

#endif

    firebase::dynamic_links::Initialize(*_firebaseApp, this);

Also our manifest setup:
        <activity
            android:name="org.cocos2dx.cpp.AppActivity"
            android:screenOrientation="sensorPortrait"
            android:configChanges="orientation|screenSize|keyboardHidden"
            android:label="@string/app_name"
            android:launchMode="singleTask"
            android:theme="@android:style/Theme.NoTitleBar.Fullscreen" >

            <intent-filter>
                <action android:name="android.intent.action.MAIN" />
                <category android:name="android.intent.category.LAUNCHER" />
            </intent-filter>

            <intent-filter>
                <action android:name="android.intent.action.VIEW"/>
                <category android:name="android.intent.category.DEFAULT"/>
                <category android:name="android.intent.category.BROWSABLE"/>
                <data android:host="towerduel.com" android:scheme="http"/>
                <data android:host="towerduel.com" android:scheme="https"/>
            </intent-filter>
        </activity>

On Android, the log is only triggered when the App was not open previously. If the App was open, then clicking the Link also does correctly open the App, but the listener is not triggered / no log ist printed.
Do you have any idea why this is happening and how we can also make the listener trigger if the app is already open like on iOS?

Unfortunately we can't hook the application lifecycle on Android (on iOS we use method swizzling on the app delegate) so you need to call dynamic_links::Fetch() when the app gains focus to get the link.
https://firebase.google.com/docs/reference/cpp/namespace/firebase/dynamic-links#namespacefirebase_1_1dynamic__links_1ad0a04de4c0b8c875bf6fe39fa90ea420

Thank you so much, this works!
Really cool support here :)
In case you want to add it to the documentation, I followed these guides here:
https://firebase.google.com/docs/dynamic-links/android/receive
https://firebase.google.com/docs/dynamic-links/cpp/receive
Maybe it'd be cool to add this piece of info to these guides, so people will not make the same mistake in the future.

A note was added to the bottom of:
https://firebase.google.com/docs/dynamic-links/cpp/receive
"Note: On Android you must also call Fetch() when the application gains focus in order for the listener to be triggered."


Fix upstream packages' test suites to allow our test suite to run

Just making a note so it is tracked. Maybe someone will see this issue and take it on as part of Hacktoberfest. :P

the still relevant upstream have been fixed.
buzz seems very inactive, it has issues with its integration tests as seen in last years (unmerged) pull requests.


Fix MediaSet

It doesn't work atm. In particular, it doesn't react when you send it a picture.

Fixed in 13038ce5746514faa550fe9377e709b8edc33ff3.


Preserve stepId to point the right step

While adding more events for the same stepId I spot a bug on the stepId variable.
stepId is a closure for the bind function so the variable will always get the value of the highest stepId and put the event value to the wrong step ...

@stefandoorn still here ?

Thanks!


Double encodes html entities (&,  , etc)

Description
Describe your issue here.
What type of issue is this? (place an x in one of the [ ])

[x] bug
[ ] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
slackhq/csp-html-webpack-plugin version:  v5.1.0
node version: v20.11.1
OS version(s): all
Seems to have broken sometime recently, I'm guessing it is related to https://github.com/slackhq/csp-html-webpack-plugin/pull/75
Steps to reproduce:

Have html entities (&,  , etc) in your html template file

Expected result:
Observe html entities are unaffected
Actual result:
Observe that they get double encoded, & becomes &amp;,   becomes &nbsp;
Attachments:
OSS project: https://github.com/gitkraken/vscode-gitlens can see when the settings.html file gets built (https://github.com/gitkraken/vscode-gitlens/blob/e3795f8a80eb43b91b3c7736d7705c6316b921f7/webpack.config.mjs#L323)

It looks like it's caused by wrong version of cheerio transitive dependency. Version 1.0.0 is fetched by default when run npm i | yarn | pnpm i, but ^1.0.0-rc.5 is required


RMNet26？

Hello, I found that you use resnet50. What should I do to use resnet18? I see that rmnet26 is also mentioned in your paper. Do you have the source code?

What is RMNet26?


replacing example Elasticsearch and Logstash URL's

Just a minor update of configuration description.

@dragoslav this has been updated in the latest version of Vamp package. this PR can be closed.


RSpec output creates multiple new lines

Current Behavior

Add the fuubar gem, bundle install
Add configuration to spec_helper.rb
Run tests

Screenshot

Expected Behavior
Expect to see progress output on a single line that is updated
Environment

Device: 2017 MacBook Pro

OS:

[ ] Windows
[x] macOS
[ ] iOS
[ ] Android
[ ] Linux
[ ] Other

OS Version: 10.15

Shell: Zsh, managed by Oh My ZSH!

@safetypins you are running RSpec with Fuubar as well as the default formatter.  Run it with only Fuubar and it will be fine.


is_move_and_slide_on_wall() and is_move_and_slide_on_ceiling()  Issue

Windows 7- Godot 2.2 alpha
is_move_and_slide_on_wall() doesn't work at all, always returns false, and is_move_and_slide_on_ceiling() works like if you were using "is_move_and_slide_on_wall()", if you collide with a wall returns true.

Here is the code that checks the move_and_slide normal:
scene/2d/physics_body_2d.cpp:1192-1205
if (get_collision_normal().dot(p_floor_direction) > Math::cos(Math::deg2rad((float)45))) { //floor

	move_and_slide_on_floor = true;
	move_and_slide_floor_velocity = get_collider_velocity();

	if (get_travel().length() < 1 && ABS((lv.x - move_and_slide_floor_velocity.x)) < p_slope_stop_min_velocity) {
		revert_motion();
		return Vector2();
	}
} else if (get_collision_normal().dot(p_floor_direction) < Math::cos(Math::deg2rad((float)45))) { //ceiling
	move_and_slide_on_ceiling = true;
} else {
	move_and_slide_on_wall = true;
}

Thus, move_and_slide_on_wall would be true only if the dot product of the collision normal and the floor direction is exactly equal to cos(45⁰). Obviously something fishy here.
@reduz Since you introduced this code in fc70824f7c6ab1944d54194f54b816e55671e177, can you elaborate on this issue? :smiley:

@0nepixel can you share that scene?

@nunodonato Here it goes: 7313-is-on-celling-false.zip (yea, I know I'm not called 0nepixel...)


[FEATURE] RequestsGet and RequestsPost tools support

Describe the feature you'd like
It seems that RequestsGet and RequestPosts tools not supported now.
How can I add support to these two tools.

hey @missmess, they are already available. If you had git cloned the project, pull the latest changes and you'll see it.

For docker and npm installation, waiting for https://github.com/FlowiseAI/Flowise/pull/1 to merge before pushing a release. Will update soon

New release has been pushed. RequestsGET and POST Tools should be there if you reinstall/pull latest changes.


search count badge jumps

have a search result
resize the sidebar
🐛 the count badge jumps at one point

This is by design, because it doesn't look good when the view is very wide, like in the panel, and the numbers are on the right side far from the content. Problems does the same. The threshold could be tweaked maybe? Why does it look like a bug to you?

Why does it look like a bug to you?

Because it looks like screen cheese. It also messes with usability and readability - glancing over groups or selecting inline actions is really hard when things are at varying positions. It is also super inconsistent with the SCM viewlet, its own title buttons, with explorer decorations etc etc

I will change the "wide" threshold from 600 to 1000.
Or, I can change it to always align left when in the panel and always right when in the sidebar. But I wanted to avoid that because either one can be narrow or wide and the view shouldn't have to know where it is.


feat(consensus): cache proposals based on height and round

This change is

#2586  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Remove unused parameters.

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Remove unused parameters.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/approve


Add Belarusian language

Hi! I would like to translate reactjs.org to belarusian language. This is an official language in Belarus.

Hi! Any details about this one? Am I missing some details I need to fulfil?

Hi, I can help with this translation

Sounds good, creating a translation owned by @zubialevich and @belarusaed.


HARP-4946: Fix empty Tiles

@heremaps-bot ok to test

the fix is does not work with the warp/OLP datasources


Making scroll always visible.

Simple trick to prevent the page from "jumping" when navigating from/to a page not long enought to have the scroll.

Thanks your PR!
Can you take a screenshot for the visual effect?

This is not something one will note unless they pay attention, actually. The elements of the page will move very slightly to right when navigating to a page without the scrollbar.
Not a big deal, but since the fix is easy, I made it.

OK, make sense. Thanks again!


JavaFS -- a port of fuse-jna to JNR

Hi!
Just wanted to let you know that I've ported fuse-jna to JNR, and changed the API so that instead of having a new FUSE API, you just use the standard JDK's FileSystem and mount it.
The project is here, and you're welcome to copy back whatever pieces you want.

This is very cool. I don't think it'd be a good idea to merge things back into fuse-jna because it would go contrary to the project's title, and the change in the library user API would probably not be desirable. However I'll certainly link to this from the README file.

Done in 20c8118.


Support placeholder arguments in C FFI

Design how placeholder arguments can be generically sent over the C FFI to the Rust library.

Here is a proposed API:
// A single placeholder argument.
struct PlaceholderArgument;
// A vector of placeholder arguments to be sent into query methods for use.
struct PlaceholderArgumentVector;

// Creates a new placeholder argument vector to send to a query method.
PlaceholderArgumentVector* placeholder_argument_vector_new();
// Frees an entire placeholder argument vector, including all argument inside.
void placeholder_argument_vector_free(PlaceholderArgumentVector *self);
// Adds a new placeholder argument to the vector.
// Data is referenced by the void* `buffer` and is `buffer_size` bytes.
// The data is NOT owned and must remain alive until the placeholder arguments are bound to the query.
// Data is decoded in the library of type `type`, which is a supported column type for decoding.
// Returns the created argument for further modification if desired.
PlaceholderArgument* placeholder_argument_vector_add(PlaceholderArgumentVector* self, void* data, size_t data_size, DataJointType type);
// Gets the placeholder argument at the given index.
// Returns NULL if invalid index.
PlaceholderArgument* placeholder_argument_vector_get(PlaceholderArgumentVector* self, size_t index);
// Returns the number of placeholder arguments in the vector.
size_t placeholder_argument_vector_size(PlaceholderArgumentVector* self);

// Re-sets the data in the placeholder argument with a new value.
// Same as above.
void placeholder_argument_set_data(PlaceholderArgument* self, void* data, size_t data_size, DataJointType type);

// Updated APIs for using placeholder argument vectors.
// Send in NULL if placeholders are not wanted.

int executor_execute(Executor* self, const char* query, PlaceholderArgumentVector* placeholders, unsigned long long* out_size);
int executor_fetch_one(Executor* self, const char* query, PlaceholderArgumentVector* placeholders, TableRow* out);
int executor_fetch_all(Executor* self, const char* query, PlaceholderArgumentVector* placeholders, TableRowVector* out);

int connection_execute_query(Connection* self, const char* query, PlaceholderArgumentVector* placeholders, unsigned long long* out_size);
int connection_fetch_query(Connection* self, const char* query, PlaceholderArgumentVector* placeholders, Cursor* out_cursor);

It makes sense when we think about it as an emplace operation. We want to return access to the new placeholder argument so the user does not have to index immediately after if they want access to the argument.

API here makes sense, but not moving over yet due to Rust library version not being in. Keeping open for now.


Search, Sort, Filter, Pagination features

Can we expect that you add these essential features?
Thanks

What context do you want this functionality? Like searching the site or a specific collective's transactions, etc.

Lik searching/paginating the open source projects, people who contributed money for a particular project, similarly the backers and sponsors. If possible, use Elastic Search to search project descriptions, etc.
In the Admin panel, same features should be there.
Any plans?

All of those are on the list - hope to launch some of those early next quarter. We are a small team of 2 engineers (looking for our 3rd), so we have a long backlog of features to deliver.

Ok fine Thanks for the update

Hello all,
Tim from Algolia here. Maybe we could help? In addition to what we pledge to each individual projects as a company, we would also like to offer our help in improving the /search page of the current website.
The main features we would add to the current search would be results displayed in real time (as opposed to having to submit the form), typo-tolerance, speed and custom popularity ranking. Pagination and filtering on backers/companies/etc is also completely possible, depending on the data you have available.
At the very minium we can give you access to our Algolia For Open-Source free plan, but I'd be happy to go even further and help you build the actual search page.
Let me know if that's something you would be interested in.
Cheers,
Tim

Hi @pixelastic !
Thank you for reaching out. I've assigned this to @HipsterBrown that built search so he can jump on the thread.
With regards to the plan, we already have access to it (many many thanks!!)!


Hive Example with SSL

Hi
Can you please provide sample plugin with Hive authentication mode using SSL. Thanks

Hi, Can you provide more information about what you would like to do? If you want behavior that is mostly similar to our existing Cloudera or Hortonworks connector you might be able to start with one of those as your base class even though our documentation does not recommend it since we haven't tested it. 'hortonworkshadoophive' is one option. This method would give you the connection dialog and all the connection builder code. You could just customize the connector name, driver, and dialect if needed.


Provide 'how to upgrade' instructions, please?

I'm trying to maintain legacy code, which literally just broke because evalidate.evalidate is now gone.  I don't know the code nearly well enough to tell how to update it; some sort of 'if you did X, do Y now' instructions would be fantastic.
Specifically, the code in question looks like:
    math_node = evalidate.evalidate(math,
                                    addnodes=VALID_MATH_EXPRESSION_NODES,
                                    funcs=MATHEMATICAL_FUNCTIONS.keys())
    compiled_math = compile(math_node, '<math>', 'eval')
    return compiled_math

Any hints appreciated!

Easiest workaround is just  to lock evalidate version to any before 2.0.0 (which I published just few hours ago), e.g. v1.1.0 has evalidate function.
But better to upgrade it:
#!/usr/bin/env python3

import evalidate

VALID_MATH_EXPRESSION_NODES = ['Call', 'Mult']
MATHEMATICAL_FUNCTIONS = ['int']

def prepare(math):
    model = evalidate.base_eval_model.clone()
    model.nodes.extend(VALID_MATH_EXPRESSION_NODES)
    model.allowed_functions.extend(MATHEMATICAL_FUNCTIONS)

    expr = evalidate.Expr(math, model=model)
    return expr.code

code = prepare('int(a) * 3')

# 36
print(eval(code, None, dict(a=12.34)))

Thank you!  That was enough to figure it out, though I did have to change 'expr.code' to 'expr.node' to match the previous functionality.  For future explorers:
    math_node = evalidate.evalidate(math,
                                    addnodes=VALID_MATH_EXPRESSION_NODES,
                                    funcs=MATHEMATICAL_FUNCTIONS.keys())

becomes:
    model = evalidate.base_eval_model.clone()
    model.nodes.extend(VALID_MATH_EXPRESSION_NODES)
    model.allowed_functions.extend(MATHEMATICAL_FUNCTIONS.keys())

    math_node = evalidate.Expr(math, model=model).node

If something like this could be added to the docs (for this and other functionality), I think that would help anyone else in the same boat.

Attribute node is parsed AST tree, but not an python byte-code. Do you really need it (AST-tree)? If you need to eval(), then Expr.code is byte-code which would be evaluated very quickly (no need to call compile() to convert AST node to bytecode). Using code attribute can speed-up execution greatly (as demonstrated in benchmarks).

It's possible the downstream code could also be changed, but since 'evalidate' retuned a node, that's what the code expects--using 'code' gave me an error it took some time to track down.  This is not time-sensitive code; the time it takes me as a programmer to update stuff is far far longer than the time spent executing it.


incorrect working directory using Windows shrotcut

Hi,
create a Windows shortcut for Atom. Specify the working directory (on shortcut -> right click -> properties -> specify Start in: e.g. c:\ ) . Start Atom via shortcut and run a script like:
console.log("The current working directory is " + process.cwd());
Notice that a different working directory is shown.
Starting the script in atom using the plugin script shows the correct working directory.
Workaround: Start atom in your working directory using command line.

Hi,
The current working directory should be set to the folder containing the startup file. In v 1.1.9 this does not work though but it has been fixed in trunk. We have also discussed the possibility to override the default working directory in the config file but that has not been implemented.
@kiddkai maybe it is time to build a new release soon. If you tell me what to do I can fix it.

Fixed in the latest version


Does the amount of metadata downloaded affect Instagram limits?

When getting data with Instaloader I’m wondering whether the amount of data I save affects ability to obey Instagram rate limits. For instance, will the examples below all be treated the same way, or is it smart to only extract the data you need? Also, is the dropwhile/takewhile method of getting to a specific date treated the same, even if no data is being downloaded?
Downloading
for post in hashtag.get_posts():
    L.download_post(post)

Appending shortcode only to list
shortcodes = list()
for post in hashtag.get_posts():
    shortcodes.append(post.shortcode)

Generally, if you have two alternative methods of doing one thing, an easy way to determine which one requires more requests is to run both with a profiler and compare the number of calls to InstaloaderContext.get_json().

Very interesting! Thanks for your help. Just did it for a few days worth of locations posts, and realized that Instaloader only called InstaloaderContext.get_json() 27 times for 630 posts. I never realized that Instaloader didn't query the Instagram API for each iteration of NodeIterator, which I guess is what that implies. Very cool!
This is what I did if anyone is interested. There was no difference when skipping posts.
import cProfile, pstats, io

def profile(fnc):

    """A decorator that uses cProfile to profile a function"""

    def inner(*args, **kwargs):

        pr = cProfile.Profile()
        pr.enable()
        retval = fnc(*args, **kwargs)
        pr.disable()
        s = io.StringIO()
        sortby = 'cumulative'
        ps = pstats.Stats(pr, stream=s).sort_stats(sortby)
        ps.print_stats()
        print(s.getvalue())
        return retval

    return inner

import csv
from time import sleep
import json
from datetime import datetime, timedelta
from itertools import takewhile, dropwhile
from pathlib import Path
import instaloader
import pandas as pd

@profile
def main():
    L = instaloader.Instaloader(fatal_status_codes=[400, 429])
    L.load_session_from_file("USERNAME")
    posts = L.get_location_posts(213189119)

    SINCE = datetime.today() - timedelta(days=30)
    UNTIL = datetime.today() - timedelta(days=60)

    with instaloader.resumable_iteration(
        context=L.context,
        iterator=posts,
        load=instaloader.load_structure_from_file,
        save=instaloader.save_structure_to_file,
        format_path=lambda magic: f"resume_info_{magic}.json.xz",
    ) as (is_resuming, start_index):
        if is_resuming:
            next(posts)
        for post in takewhile(lambda p: p.date > UNTIL, dropwhile(lambda p: p.date > SINCE, posts)):
            shortcode, date = post.shortcode, post.date
            print(shortcode, date)

@profile
def main():
    L = instaloader.Instaloader(fatal_status_codes=[400, 429])
    L.load_session_from_file("USERNAME")
    posts = L.get_location_posts(213189119)

    UNTIL = datetime.today() - timedelta(days=60)

    with instaloader.resumable_iteration(
        context=L.context,
        iterator=posts,
        load=instaloader.load_structure_from_file,
        save=instaloader.save_structure_to_file,
        format_path=lambda magic: f"resume_info_{magic}.json.xz",
    ) as (is_resuming, start_index):
        if is_resuming:
            next(posts)
        for post in posts:
            shortcode, date = post.shortcode, post.date
            if date < UNTIL:
                break
            print(shortcode, date)

Nice, thanks for sharing your observations!


Listener filter ECDS Support

This PR support TCP listener filter ECDS functionalities.
This is the 4th PR to support TCP listener filter ECDS as in issue: https://github.com/envoyproxy/envoy/issues/20049.
Note, the support of UDP listener ECDS will be done in a separate PR as in item 8 of issue https://github.com/envoyproxy/envoy/issues/20049
Build:
passed
Testing:
passed
Release Notes:
N/A
Issues: ecds: add support for listener filters https://github.com/envoyproxy/envoy/issues/20049
Signed-off-by: Yanjun Xiang<EMAIL_ADDRESS>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/wait

This PR is WIP.
Need to add:

integration test for TCP listener filter with MatchPredicate:
https://github.com/envoyproxy/envoy/blob/635f18cad06b8e1478a18884db3b50d7541fad11/api/envoy/config/listener/v3/listener_components.proto#L367

integration test for  UDP listener filter ECDS.

/assign @adisuissa @kyessenov

/retest

/assign @htuch @KBaichoo

For reviewers:

Added the tcp_listener_config_provider_manager_ in class ProdListenerComponentFactory thus it can be used when creating listener_filter_factories_:
listener_filter_factories_ = parent_.factory_.createListenerFilterFactoryList(
config_.listener_filters(), *listener_factory_context_);

https://github.com/envoyproxy/envoy/blob/b58eb9519b6b3cf0facd0250898fdbc2ec2353ca/source/server/listener_impl.cc#L617
Here parent_ is a ListenerManagerImpl instance. and factory_ is here: https://github.com/envoyproxy/envoy/blob/b58eb9519b6b3cf0facd0250898fdbc2ec2353ca/source/server/listener_manager_impl.h#L210

This function eventually call in ProdListenerComponentFactory: https://github.com/envoyproxy/envoy/blob/b58eb9519b6b3cf0facd0250898fdbc2ec2353ca/source/server/listener_manager_impl.h#L56

To make sure when 2) is called, the tcp_listener_config_provider_manager_ is there, whenever a make_unique is called, a ProdListenerComponentFactory object need to be passed in as parameter, not ListenerComponentFactory object, which don't have this tcp_listener_config_provider_manager_ object.

@yanjunxiang-google I had a quick look over the PR. Exciting to see the progress here. I don't have any feedback beyond what has been covered by existing reviewers, I think if you can address those concerns this is on track.

@yanjunxiang-google I had a quick look over the PR. Exciting to see the progress here. I don't have any feedback beyond what has been covered by existing reviewers, I think if you can address those concerns this is on track.

Thanks @htuch for reviewing.  Sure, will do!

@mattklein123  Could you please take a look this PR?  Thanks!

/retest

Thanks LGTM with a small comment. Do you plan on doing the UDP stuff right away and then adding docs/release notes then? Otherwise we should do docs and release notes in this PR? Thank you.
/wait

Yes, I am planning to work on the UDP changes right away. The code is most ready.  We can do doc/release notes with the UDP PR since that will wrap up the listener ECDS work.

/retest

/retest

Sorry if I missed it, but what's the plan here for documentation and release notes? Will this be done after your final PR assuming that is a quick follow? Or should we do docs and release notes now? Thank you.
/wait-any

Sorry if I missed it, but what's the plan here for documentation and release notes? Will this be done after your final PR assuming that is a quick follow? Or should we do docs and release notes now? Thank you.
/wait-any

Hi, @mattklein123 , Yes, I am planning to work on the UDP changes right away. The code is most ready. We can do doc/release notes with the UDP PR since that will wrap up the listener ECDS work.

OK sounds good concerning docs/release notes as the next PR. Thank you!

/retest

/retest

/retest

LGTM, thanks! Let's make sure CI is green. @soulxu in case you have more comments.

previously one thing come to my mind, I think the current is the right way. But just put it here in case people have different thoughts. I'm thinking about whether we should enable the listener matcher for MissConfigFilter. Should we skip the connection close if the connection doesn't match the listener matcher? But I think the current code is right, since it is an invalid config case, then closing the connection directly without considering the listener matcher is right. And it is a little strange for some connection successes due to not matching the matcher, some connections are failed.
Anyway, I think this is LGTM now, thanks!

LGTM, thanks! Let's make sure CI is green. @soulxu in case you have more comments.

previously one thing come to my mind, I think the current is the right way. But just put it here in case people have different thoughts. I'm thinking about whether we should enable the listener matcher for MissConfigFilter. Should we skip the connection close if the connection doesn't match the listener matcher? But I think the current code is right, since it is an invalid config case, then closing the connection directly without considering the listener matcher is right. And it is a little strange for some connection successes due to not matching the matcher, some connections are failed.
Anyway, I think this is LGTM now, thanks!

Thanks for sharing the thoughts.  What you described make sense to me, i.e, if a listener filter config is invalid, the filter chain match predicate value should be ignored, and the connection need to be closed.

/retest

/retest

/retest

/retest

/retest

Hi @mattklein123 , do you have further comments? After you took the pass last time, what we changed is adding the missing_config counter and the integration tests for listener filter matcher.
If no further comments, could you please approve?

I already approved this. Please have the others doing active reviews review any new code and merge. Thank you!

I already approved this. Please have the others doing active reviews review any new code and merge. Thank you!

Thanks @mattklein123


[FLINK-26785] Add FlinkSessionJob CRD

This PR meant to add the FlinkSessionJob CRD

I will look into the CI failure first.

What is the point of reorganizing the CRD/Status classes into new packages? I feel that currently it is structured in a pretty straightforward way, but now it got a bit messy :)

I see it's only 5 new spec/status classes that internally use the old (common) classes. At this point I would prefer to keep the current package structure that would also make this change easier to review (and rebase etc)

Get it, I will keep it in the current package first.

I remove the package reorganizing in this pr, PTAL again @gyfora  cc @wangyang0918

@Aitozi would you like to merge this as is now or together with the controller?

@gyfora You can merge this first, I will open another PR for the controller

Could you please rebase the latest main branch and re-generate the java doc?

Could you please rebase the latest main branch and re-generate the java doc?

@wangyang0918 Thanks for remind, I have regenerated the doc


Auto KGE Feature

For a given dataset and a knowledge graph embedding model, make a sequence decisions so that our computation and time budgets are fully utilized, specficaly

Find a combination of the batch size and size of embedding vectors that fully uses the available hardware.
Through validation set performance, we may study adaptive rates for drop outs

Detect available GPUs and the size of the KG and move to model paralleisim from data parallelsim

Update:

Find a combination of the batch size and size of embedding vectors that fully uses the available hardware.

Possible workflow:

Initialize the model and check the CPU usage
Perform dummy forward and backward pass to compute memory usage
Assume that (2) is a "good" approximation of actual memory usage in CPU/GPU etc.
Increment the batch size until out-of-memory issue occurs.

Auto batch finder is available here.


Add a .gitignore for node_modules at the root

When you npm install from the root directory, git thinks node_modules need to be checked in. This fixes that. Cheers.

Nice, thanks!


Remove Nuxt

In the first version of Recolto, Nuxt was needed in order to pregenerate pages.
This is no longer needed and nuxt comes with a lot of unnecessary dependencies and functionalities.
So we want to remove Nuxt and make Recoloto a simple Vue.js application.
Steps to remove nuxt:
Remove @nuxt/ui
This is the big part of the migration.

Replace each nuxt-ui component with vanilla ones.
Remove  @nuxt/ui dependency

Remove nuxt
The simpliest way to achieve this is perhaps to bootstrap a brand new Vue.js project and then copy/past neede components to rebuild the app

@SimonMellerin @dlercier I would be interested to take this issue.

@cbaccam thanks!
May be we can make this issue step by step.
I have quickly checked and here is a list of component from Nuxt/ui to remove from the project:

[ ] UIcon
[ ] UButton
[ ] USelectMenu
[ ] URadio
[ ] UToggle
[ ] UInput
[ ] UPopover
[ ] USkeleton

I propose to make one PR per component to be replaced.
If some components are too complicated to develop, you could consider replace nuxt/ui with another components library.

ok for one PR per component. I will start after the holidays to give me time to learn properly vue.js . I am more familiar with javascript/typescript with angular/jquery.
when you mean vanilla js,  is it  the standard html 5 code ?

when you mean vanilla js, is it the standard html 5 code ?

Yes that was what I was thinking about. But, maybe it won't be so easy to do. And I don't think it's worth spending too much time on it.
We usually use the primevue component library on our Vuejs projects. We could probably use it on recolto too.


Broken in Django 1.10

This no longer seems to work in Django 1.10.
Any page using it throws the Javascript error Uncaught TypeError: c.split is not a function coming from jquery.maskedinput.min.js:7.
I'm also using this with Django-Suit, and after upgrading to Django 1.10, this app now causes all tabbed form elements to disappear. Something in the jquery.maskedinput.min.js seems to be interferring with the code that shows/hides form fields when you click on Suit tabs.

Try subst c.split to c.toString().split


Simplify useFetch usage

As discussed, we can simplify usefetch. I believe we don't need to use a store right now.
If that approach works for you, then I'll let you remove the store.

Current dependencies on/for this PR:

main

PR #73

PR #74

PR #77

PR #78   👈

PR #75

PR #76

This comment was auto-generated by Graphite.


chore(tests): integrate with CodeCov

Coverage remained the same at 81.013% when pulling bb3ed6f166b9b2872dfb74a7dfdfcfb67c763b82 on code-cov into 271213876ebf6023e33eff4c427331ceb1a0cafc on master.


koordlet: fix cpuset hook for unset cfs

Signed-off-by: saintube<EMAIL_ADDRESS>Ⅰ. Describe what this PR does

bugfix for the registration of the cpuset runtime hook
Ⅱ. Does this pull request fix one issue?

fixes #677
Ⅲ. Describe how to verify it

do not fail on unit tests
run koordlet successfully without panic

Ⅳ. Special notes for reviews
V. Checklist

[X] I have written necessary docs and comments
[X] I have added necessary unit tests and integration tests
[X] All checks passed in make test

/lgtm
/approve


Add additional functionality to minor admin page

Allow an admin to add an interested student to the Interested Students section on that page. I think we can reuse the functionality of the Add Volunteers modal in Manage Volunteers.

 Add additional functionality to minor admin page

 Have an "Email All Interested" button on the CCE Minor Management page


Minor ENH: Grey hline when spatial_colors=True

The horizontal line for butterfly plots is in red. This looks silly (and is potentially confusing) for plots with spatial colors (see below).

This PR makes it grey for spatial_colors, but leaves it red for black plots.
Furthermore, how about a vline option..?

I'm -0.5 on the vline option since it's pretty easy to add manually afterward given you have access to the fig and axes at that point. But if we have it other places then I'm up to +0.5.

mne.decoding.TimeDecoding.plot and mne.viz.plot_epochs_image automatically plot a vline at 0 for time series. They don't have a vline kwarg though.
It's not a big thing either way.

Putting one at t=0 makes sense to me, but I wonder why we don't have it already for other epochs plotting routines. We could add it, and if users complain, make it an option?

Should I add the vline at 0 to this PR?

I'm fine with it, but you might want to wait for another opinion or two. @jaeilepp any thought on t=0 line?

I'm fine either way. It'll probably overlap with legend when given a close to zero tmin, so maybe a -0.5 from me.

I'd set zorder to -1, that would set it below the legend right?

Yeah, actually I think it'll go under the legend anyway, since it's a different axis. So maybe a +0.5 then :)

Personally, I would just add the vline later ... but it's just me.

+.5, +.5, -1, that's a tie (unless my vote counts :)).
Anybody else?

-1 on vline.
I'll just merge this PR as is.
when travis is happy

Ok.
@jaeilepp the legend head looks a bit oval doesn't it? Is that just my setup?

The head size is set as percentage in the beginnig. So if you resize the window, it won't be a perfect circle anymore. I've noticed it works reasonably well if you don't go crazy with the resize.

thx @jona-sassenhagen


Update release instructions to use git tag from cli.

Signed-off-by: Ville Aikas<EMAIL_ADDRESS>
Summary
As @cpanato mentioned in #483 we can simplify our release instructions. So changing the instructions to use direct tagging.
Release Note

Documentation

I created this
release using these instructions. The one thing I see being different is the 'contributors' section. When doing this route, it says 'Thanks to all the contributors', vs. listing the contributors. I'm not sure how much it matters, but just pointing it out. The other projects this seems to happen, so maybe I missed a step here somewhere?
For example: https://github.com/sigstore/cosign/releases
And scaffolding previous releases:
https://github.com/sigstore/scaffolding/releases/tag/v0.5.0

I see. When you go to edit the release, you should still 'generate release notes' even though tagging creates some of them. I'll update.


Using periodic time interval in Report with increment and value set sometimes results in INVALID_ARGUMENT

Reported by @mariolamassaavedra on behalf of Amritha Shenoy from Slack thread https://cross-mediaworkspace.slack.com/archives/C0312M4HE3F/p1668180627736149. Related to #759.
Not yet reproducible by Halo eng.

I have been able to reproduce it. The issue is when cumulative is set to true.


[release-1.3] Skip syncing root cert if not in self signed CA mode

This is a cherry-pick of #18713
#17059

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.3
56647e29da3ba6dd8e3eff96ee5279006aaf6506
link
/test lint_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.3
56647e29da3ba6dd8e3eff96ee5279006aaf6506
link
/test lint_istio_release-1.3

e2e-simpleTests-cni_istio_release-1.3
cf585d694fa533e33e547eab868c300b6587bc37
link
/test e2e-simpleTests-cni_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-cni_istio_release-1.3

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio_release-1.3
cf585d694fa533e33e547eab868c300b6587bc37
link
/test racetest_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test racetest_istio_release-1.3

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio_release-1.3
cf585d694fa533e33e547eab868c300b6587bc37
link
/test racetest_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
cf585d694fa533e33e547eab868c300b6587bc37
link
/test integ-new-install-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio_release-1.3
cf585d694fa533e33e547eab868c300b6587bc37
link
/test racetest_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
cf585d694fa533e33e547eab868c300b6587bc37
link
/test integ-new-install-k8s-tests_istio_release-1.3

integ-mixer-k8s-tests_istio_release-1.3
cf585d694fa533e33e547eab868c300b6587bc37
link
/test integ-mixer-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Get derived path of the app after building

Hello,
I need the path of the .app after the build has been completed, in order to pass it as a parameter to the automaton test command.
The path is usually something like:
/Library/Developer/Xcode/DerivedData/MyProject-aywzvukszxzouebvjouhteovxgkp/Build/...
How can I retrieve the path after the build has been completed?
Thanks.

I think you need to use heuristics right now ( something like ls -t1 /Library/Developer/Xcode/DerivedData/MyProject-* | head -1).
Feel free to send a pull request that adds an option like --print-product-path and prints it out somewhere sensible.

I needed up parsing like this:
export APP_BUNDLE_PATH=xctool -workspace BentleyPOS.xcworkspace -scheme BentleyPOS-cal -showBuildSettings | grep "SYMROOT" | sed 's/.*= //'"/Debug-iphonesimulator/Showroom-cal.app"


Typescript error for R.type when using a date type

For typescript, when using the function R.type, the possible types are
"Object" | "Number" | "Boolean" | "String" | "Null" | "Array" | "RegExp" | "Function" | "Undefined" | "Symbol" | "Error"
However, if you pass R.type(new Date ()), a string of 'Date' gets returned

R.type has since been updated to support all the types mentioned by OP and more. Closing


[Bug]The value of the 'table-list-container' property will be lost

Reproduction steps:
1.Visit: https://codepen.io/attoae/pen/WNBGjZp
2.Create a table with a list

Get the delta data：
{ "ops": [{ "attributes": { "table-temporary": {} }, "insert": "\n" }, { "insert": "01" }, { "attributes": { "table-list": "ordered", "table-list-container": "cell-a00y", "table-cell": { "data-row": "row-nrot", "width": "72" } }, "insert": "\n" }, { "insert": "02" }, { "attributes": { "table-list": "ordered", "table-list-container": "cell-a00y", "table-cell": { "data-row": "row-nrot", "width": "72" } }, "insert": "\n" }, { "attributes": { "table-cell-block": "cell-4gmw", "table-cell": { "data-row": "row-nrot", "width": "72" } }, "insert": "\n" }, { "attributes": { "table-cell-block": "cell-feww", "table-cell": { "data-row": "row-up1u", "width": "72" } }, "insert": "\n" }, { "attributes": { "table-cell-block": "cell-o383", "table-cell": { "data-row": "row-up1u", "width": "72" } }, "insert": "\n" }] }

3.Try to render the delta to the editor and find that the value of the 'table-list-container' property is lost.
The following is the value of the new delta
{"ops":[{"attributes":{"table-temporary":{}},"insert":"\n"},{"insert":"01"},{"attributes":{"table-list":"ordered","table-list-container":"undefined","table-cell":{"data-row":"row-nrot","width":"72"}},"insert":"\n"},{"insert":"02"},{"attributes":{"table-list":"ordered","table-list-container":"undefined","table-cell":{"data-row":"row-nrot","width":"72"}},"insert":"\n"},{"attributes":{"table-cell-block":"cell-4gmw","table-cell":{"data-row":"row-nrot","width":"72"}},"insert":"\n"},{"attributes":{"table-cell-block":"cell-feww","table-cell":{"data-row":"row-up1u","width":"72"}},"insert":"\n"},{"attributes":{"table-cell-block":"cell-o383","table-cell":{"data-row":"row-up1u","width":"72"}},"insert":"\n"},{"insert":"\n"}]}

"table-list-container": "cell-a00y"
has become:
"table-list-container": "undefined"
4.In some cases, it may cause abnormal display of the table.

Okay, I will fix it.


timer breaks on de-/focus after more than one call to set-screen!

Odd behavior with a timer:

starting the app normally (CIDER Repl, calling (-main))
the timer starts and works flawlessly
defocus game window
timer events not triggered anymore
focus game window
timer event triggered again

So I guess the timer is on hold when the window is not focused (guess one can hook into that via on-pause  and on-resume).
I do not necessarily consider this an issue so far. Maybe a bit weird, that the timer stops, but on-render keeps going...
Here is the real issue, continuing after step 6. from above:
7. run (play-clj/on-gl (play-clj/set-screen! viking-village-vandalism-game main-screen ui-screen))
8. the game window is defocused now (as I switched to the REPL)
9. the screens are reset and start over again, the timer working normally
10. focusing the game window again stops the timer
11. defocusing the game window does not change anything, most importantly does not enable the timer again
(12. GOTO 7. and everything repeats from there)
So, this really seems to be broken somehow.
I am running this on Fedora 23, play-clj "1.0.0".

Here is the project I am encountering this issue.
adding timer: https://github.com/nblumoe/viking-village-vandalism/blob/master/desktop/src-common/viking_village_vandalism/core.clj#L108
(this gets trigger on-show https://github.com/nblumoe/viking-village-vandalism/blob/master/desktop/src-common/viking_village_vandalism/core.clj#L82)
on-timer handler: https://github.com/nblumoe/viking-village-vandalism/blob/master/desktop/src-common/viking_village_vandalism/core.clj#L162
function call to reset the screens: https://github.com/nblumoe/viking-village-vandalism/blob/master/desktop/src-common/viking_village_vandalism/core.clj#L264

Yeah there's a pretty long history of timer-related issues in libGDX. The particular issue you mentioned about its behavior when calling set-screen! is new to me, though. I'll look into it and see if we can do some kind of workaround, but since libGDX is a Java framework I imagine their design doesn't account for calling methods from a REPL =)

Probably you can suggest any workaround? Just hit this issue too.

I hit this problem as well... after I click on the game window the timer stops firing :( I think its probably simplest just not to use the timer and count down from delta times.


Fix build issue with aes-gcm-armv8-unroll8_64.S on older aarch64 assemblers

The EOR3 instruction is implemented with .inst, and the code here is enabled
using run-time detection of the CPU capabilities, so no need to explicitly
ask for the sha3 extension.
Fixes #17773

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.  Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

but this PR has failing CI tests

Bot is confused. Adding the label.

but this PR has failing CI tests

Bot is confused. Adding the label.

Can I see the failure log of CI test?  Here I can only see: "All checks have passed, 68 successful checks"

Can I see the failure log of CI test?

There is no CI failure

Merged to master branch. Thank you for your contribution.

Just to confirm it worked for me and fixed the build issue.
https://github.com/userdocs/openssl-crossbuild/actions/runs/1933177778
Thank you for the fix.


Move to ci-master for CI configuration managment

Tests failed, not related to CI configuration changes

Tests failed, not related to CI configuration changes


Add Html::div to HtmlHelper

Currently Html::img & Html::a are supported in the HtmlHelper because of their unique characteristics.
On the other hand you could assume that these are supported because of their widely use.
What is happening in practice, is that I often automatically want to try Html::div() to render a container,. But this should be done by Html::tag('div'), which 'feels' not autonomically yet for such a widely used element. It also is less readible in the code.
I would suggest to include a shortcut to DIV in the Html Helper. For several reasons:

more intuitive
faster code to read (especially within widgets)
shorter code to write

Example:
        $body[] = Html::tag('div',$img,$this->imageOptions);
        $body[] = Html::tag('div',$body,$this->bodyOptions);
        return Html::tag('div',implode($body),$this->options);

        $body[] = Html::div($img,$this->imageOptions);
        $body[] = Html::div($body,$this->bodyOptions);
        return Html::div(implode($body),$this->options);

+1

Html::img and Html::a have been extracted because the y use different function API: img should always have an "src" attribute and a - a "href" attribute.
Using Html helper for the general markup composition is a bad practice - you should use plain HTML for your containers.

@klimov-paul: I agree with most of what you are mentioning (and that is what I was saying about 'Html::a and Html::img and  their unique characteristics),  but what you basically are stating that 'plain HTML' should be use for containers at all times (as it is a bad practice).
With this you imply that using plain HTML is always better than using a function, which of course is not the case. There are enough usecases in which you dont want to use plain HTML:

when you are making use of dynamic attributes contained in arrays
when you dont want to use views for HTML (such as in widgets)
when you prefer consistent codewriting
when a DIV is not important enough show as plain HTML, but important enough as a container.
etc etc.

in those cases it is fine to use Html::tag('div',$content,$options). there is no need for an extra method.


fuzz: add .Delete fuzzing

Adds an oss-fuzz pass for fuzzing just .Delete in which a tree is populated by corpus generated by *[...]<DELETE_KEY>
/cc @cuonglm

LGTM. Thanks again!

Sorry to hjack you here @liamsi, would you mind answering my question in https://github.com/celestiaorg/smt/pull/51#issuecomment-887152900.
Thanks!

replied here: https://github.com/celestiaorg/smt/pull/51#issuecomment-888975911


Bump API dispatcher version

Introduce changes from https://github.com/wso2/product-is/issues/7102

Addressed test failures with https://github.com/wso2/product-is/pull/7109.


"Error: Invalid context key"

So I have configured this node , I am able to connect to alexa account , I am able to see all my devices but I am getting below error
"Error: Invalid context key"

Same error here on an M1 iMac. Did you ever find a solution?


Something went wrong. Please report issue.

Nothing can be obtained from Instagram anymore (tested with the current version and an older one). All the requests were made with residential proxies and still can not get any data. The response is:
Response code is 200.
Body: Something went wrong. Please report issue.

The same here. work only on localhost!

The same here. work only on localhost!

I downgraded back to v0.9.10, used authentication and a residential proxy, and seems to work fine.

@listdev - Would you be able to provide a code snippet of what is working for you?

I think Instagram just tightens their ip ranges bans so it's getting really tricky to get results unless you are not using your own residential network (which is not always feasible) and low req rates. Take a look at https://github.com/restyler/instagram-php-scraper which is the proxified version of this scraper using https://rapidapi.com/restyler/api/instagram40 under the hood, it uses smart proxy network and manages to get 95 of 100 reqs successfully even in the current situation.

Dont work for me


fix missing example data

fixes response examples for all top level GETs that provide them

Follow up for a few special cases: https://github.com/linode/manager/issues/1848

Coverage remained the same at 82.308% when pulling 3ffe5e4ab75c44efdabb9e24fe7aec0550aae3b0 on mparke:fix-docs-examples into 130bb6c0645e308894b903064174fbe940463c60 on linode:master.


Retrieving code snippets

Copy a block of code:

{
	"label": "Frieze",
	"target": "^https?://(www\\.)?frieze\\.com",
	"lastUpdated": "2017-03-12 02:26:24"
}

Retrieve a previous item (doesn't matter what)

Retrieve the block of code (note its tab/line break issues):

{

"label": "Frieze",

"target": "^https?://(www\\.)?frieze\\.com",

"lastUpdated": "2017-03-12 02:26:24"
}

I haveto found an universal escape character :x:
Will see that this evening

I updated the release 1.1 could you tell me if it is working for you ?

1.1 @erebe released this 7 days ago · 14 commits to master since this release

Should there be a different experimental release here?

Yeah don't look at the release days, I uploaded a new binary yesterday.
I still need to bump the tag if there is a way with github


First

Will keep this PR open until we have a version that's working.
Purpose of this is to see how hound-ci manages commits to already existing pull requests.

The reason I'm disabling the rule conditional_binding_cascade is because in Swift 3 you have to write let on every new line. At least that's why my compiler is telling me.

I'm no longer working on this repo, so I'll close this issue.


Add Section on Env Functions

This PR adds a section explaining the environment functions in both SDKs.
Mentioned: https://github.com/near/docs/pull/1239#issuecomment-1275813132

Hi guys, I propose to implement the table in this PR and provide examples of each of the functions following the table in a separate PR


⚠ Bofrost.at has degraded performance

In 9a0925e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1877 ms

Resolved: Bofrost.at performance has improved in 9fa9c37 after 8 minutes.


added designing

I have changed designing part of footer-top section.
close#373 issue.

Please merge my PR if it is looks better than previous.

Before image:-

After image:-

Please merge my PR  ,if it looks better.

#373

@Shobhit61730 actually its not looking good to me plus i don't want changes in footer for if u can find the bug because of which icons are not displaying please create a issue for that
sorry for the inconvenience


Issue 564 - change message ( fixed english only )

Description
resolves issue 564. the message was confusing so was changed (in the english resourse only ) to the suggested stopped when location services are disabled or stopped at user request
How to test
1 go to settings,
click on stop logging text or icon,
see message appears.  it should now read
Location Tracking was disabled
Stopped at user request.
2 go to settings
turn off location services from OS.
click on stop logging text or icon
see message appears.  it should now read
Location Tracking was disabled
Stopped.
(any ideas for unit tests)
Still todo other languages (please advise!)
(In another locale the english text will appear until the translation is present I think)

Can you add more verbose message keys and preferable title also?
Something like - "Device location has been disabled. Please enable it in the settings" and "Location access to Safe Paths has been removed. Please enable it in the settings for effective logging" (Or instead we can do the same on-boarding kind of process also from UX perspective)
Ex. - Uber says: "For a better location experience, turn on the device location"
Given that the PR is dedicated towards only changing the message which is same for the both case right now, I would suggest only change text and get it in, and make a ticket for much in depth UI/UX for the events of location being disabled/enabled etc.

Makes sense.  Leave it with me!

Actually One clarification @tremblerz , the proposed change will distinguish between if the location services have been switched off externally or if its the user clicking the stop tracking icon.  So what you are suggesting is to change the message when location services have been disabled externally
to
"location_disabled_title": "Device location has been disabled. Please enable it in the settings",
"location_disabled_message": "Location access to Safe Paths has been removed. Please enable it in the settings for effective logging.",
I cant help thinking that the title and message duplicate information, as they are both displayed together at all times.  the message can show more info as the font is smaller.
would it not make more sense to have the title convey the current state, and the message to convey the reason for the state and the suggested resolution.
"location_disabled_title": "Device location has been disabled.",
"location_disabled_message": "Location access to Safe Paths has been removed. Please enable it in the settings for effective logging.",
How does that sound?

Actually One clarification @tremblerz , the proposed change will distinguish between if the location services have been switched off externally or if its the user clicking the stop tracking icon. So what you are suggesting is to change the message when location services have been disabled externally
to
"location_disabled_title": "Device location has been disabled. Please enable it in the settings",
"location_disabled_message": "Location access to Safe Paths has been removed. Please enable it in the settings for effective logging.",
I cant help thinking that the title and message duplicate information, as they are both displayed together at all times. the message can show more info as the font is smaller.
would it not make more sense to have the title convey the current state, and the message to convey the reason for the state and the suggested resolution.
"location_disabled_title": "Device location has been disabled.",
"location_disabled_message": "Location access to Safe Paths has been removed. Please enable it in the settings for effective logging.",
How does that sound?

On that note, you also don't need 'has been' in these two strings. The meaning is still conveyed and is shorter and might look better on screen.
"location_disabled_title": "Device location disabled.",
"location_disabled_message": "Location access to Safe Paths removed. Please enable it in the settings for effective logging.",

agreed

#564

Sorry, missed this pull request because it was not linked to the issue https://github.com/tripleblindmarket/covid-safe-paths/issues/564.   Should be merged with https://github.com/tripleblindmarket/covid-safe-paths/pull/647

I did a test on this (Pixel 2 emulator), and it gets stuck showing "stopped at user request" even though I actually have location permissions disabled in the OS.
I would expect it to say "Location access to Safe Paths removed. Please enable it in the settings for effective logging." right?
I suspect we need more thorough checks..
Can you show a video of how it should be working?

Thanks for helping me on this @tstirrat .
heres a vid of the way the new messages are showing.
2020-04-25 00-53-20.mkv.zip
Unfortunately I just noticed that the new suggested text for when location services are disabled was too wordy and spills over uncomfortably onto two lines and the message is truncated.

I think I should be shortened again.
Also I could reproduce the issue you are seeing when the loc services are disabled then the ui shows active when bringing the app back into the foreground
2020-04-25 01-10-59.mkv.zip
i dont think this is an issue i have introduced with my change (but i could be wrong)
If I confirm its an existing defect then I will raise a new issue and I can take a look this weekend, but will shorten that message first.
many thx.

just confirmed that this defect exists without my changes.  in fact when location services disabled it gets a bit messed up.  the app can think location tracking is enabled when its not as well as getting stuck at Location tracking disabled ( which is the original message before my changes )  Ill raise an issue for this.

issue #685 raised

apologies for the delay in updating.  I have shortened the messages so they fit into the android notification message area.  I have also significantly changed the word 'securely' to 'anonymously' in the Enabled message.  I think it is more accurate and better for PR (it seems all the press is talking about how contact tracing is bad for your privacy rights) so I thought this would be a better message and would make our app rise above...  regarding the issues you saw @tstirrat i have a separate PR coming to fix that issue (issue-685)

Superseded by #725


flesh out bot set-up tutorial

I will do this when I get the chance, but if anyone else wants to do it first, please be my guest. Thanks!

Did you ever get to it?


get information of user after login in facebook

I have used nativescript-facebook-login  but it gives only access token. So i have tried to retrieve info through access-token but it gives only user-name and user-id.
Than i used nativescript-social-login but i am not successful in implementing. please help me in implementing.

This issue was moved to AntonioCuevaUrraco/nativescript-facebook-login#37


Bug in OnOrderUpdate with case OrderState.Working:

else if (order == orderEntryOCOLong || order == orderEntryOCOLong)
one of these should be the short order
else if (order == orderEntryOCOLong || order == orderEntryOCOShort)

ok fixed in the main branch ty very much :-)


Fixes

I wasn't able to use dyanmoid-devise out of the box, and I figure out those changes.

Thanks for the merge. Could you make a release please so that the Gemfile is usable?

Thanks Pascal for your fix. I am actually trying to test the gem, before publishing it to repo. but having hard time testing with sample app. Did you test with any sample app? if so, could you share that git with me please?

Hi Vinay, I did use it in one of my projects (I'm patching the Gem with the
diff I sent you).
Unfortunately I cannot share the git with you a it's not OpenSource at this
point.
Pascal
2016-04-05 16:00 GMT+02:00 Vinay C<EMAIL_ADDRESS>
Thanks Pascal for your fix. I am actually trying to test the gem, before
publishing it to repo. but having hard time testing with sample app. Did
you test with any sample app? if so, could you share that git with me
please?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/vinaycyadav/dynamoid-devise/pull/1#issuecomment-205820929

No worries Pascal, I will go ahead & push new version of gem to repo in a day. Thanks & let me know if new gem serves the need.
Vinay C


V122 R4 version takes ages to launch on Windows XP, and accessing the website randomly freezes the browser.

Describe the bug
When accessing a website or searching something in the address bar (or even opening the settings!), the browser freezes for a few seconds up to one minute, and then recovers of iteself, and freezes again for the same time, etc. no matter what I do or search for. It also takes ages (around one minute) to create a window and fully load. When it freezes, sometimes I have to kill it via Task Manager as it won't recover.
To Reproduce
It randomly happens when launching the browser, so reproducing it is not very easy...
Expected behavior
Supermium should (if possible) launch a bit quicker, and stop freezing and crashing when opening something.
Screenshots
No screenshots available.
Computer
Microsoft Windows XP Home Edition Service Pack 2
32 bit
122.0.6261.152 (R4)
512MB RAM (I've also tested with 2GB, same result).
Intel Centrino Duo @ 1.7GHz
Acer Aspire 1680

This bug does not happen for me with the 32bit browser build "Supermium 122.0.6261.152 (R4)" on XPSP3 32bit with 4GB RAM, C2D-based Pentium E5200 @ 2x 2.5GHz.
Your processor is also a dual core, right? Maybe it is the old SP2 state of your XP, which is causing it?

If you do have an HDD instead of an SSD, you may experiment with that alternative to progwrp.dll: https://github.com/win32ss/supermium/issues/527#issuecomment-2094654192

Hello, my processor is indeed a dual core, but it is slow af xD I might try this patched file since I have an HDD, but I don't know if that'll work. I'll just find out when testing.

:) Thats not a patched file, thats alternative file. (Another implementation. It simply uses same API)
It was initially intended for XP SP3 only. Don't know about SP2. I dont even have virtual machine with it to check. May be will implemet support and for SP2 soon (depening on what functions not implemented).

UPD: now I have fixed it, and it works also on XP SP2.

Thanks :) I'll try it out this evening.

Although it was backported to XP, it wasn't meant to be run on XP era hardware really. My recommendation for absolute minimum would be a Core 2 Duo and 3 GB of RAM (Single core is too weak for even older versions).


[Content]: SendGrid Personas Caveat

What article on segment.com/docs is affected?
https://segment.com/docs/connections/sources/catalog/cloud-apps/sendgrid/
What part(s) of the article would you like to see updated?
Some clients have been asking to use SendGrid Source data in Personas. It is my understanding that this is not possible today. Can we add a disclaimer to notify users that using SendGrid data is not available in Personas? Ideally, we would like to eventually add instruction that would enable users to use their SendGrid data in Personas but until then, we may need to caution users.
Additional information
No response

@k-griese We've added a note about this to the SendGrid page.  Thanks for bringing it to our attention.


[DS-4575] v.6 - Exposed more parameters for DBCP2

Exposed more parameters for DBCP2 in the DSpace config.
Notably, maxConnLifeTime and removeAbandoned
See:

#3070
#3080
#3162

See also:
http://dspace.2283337.n4.nabble.com/Notes-on-PostgreSQL-connection-pooling-with-a-Tomcat-JNDI-resource-td4687149.html

Just a note for discussion.
This PR maps to config for DBCP2.
It enables the admin to switch one the built-in function to remove abandoned connections. By default the timeout for abandoned connections is 5 minutes (300 secs).
After trying that out we've found that limit to be to short. Which is to say the library is closing valid idle connections on our instance it seems:
2021-09-13 11:51:48,393 ERROR org.hibernate.engine.jdbc.spi.SqlExceptionHelper @ Connection org.postgresql.jdbc.PgConnection@5c1ab3b4 is closed. 2021-09-13 11:51:48,393 ERROR org.dspace.statistics.SolrLoggerUsageEventListener @ could not prepare statement
I am sure this is an issue for tweaking.


[BUG] No folders in modification folder

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
The thing is I deleted the modification folder because my mods were messed up and when i opened the bloxstrap (Using Play Roblox) shortcut, modification folder appeared but i cant put something like cursors because there's no "Cursors" folder thing

https://github.com/pizzaboxer/bloxstrap/wiki/Adding-custom-mods

"By default, the mods folder does not have the directory structure of the version folder. So, you will often need to create new folders in order to represent your file's location within the version folder."


DPG, integrate with apiview

Add language and apiViewArtifact.
Update script for 1-1 readme-package. And fix the case the readme.md is in a folder under data-plane folder.
Use java-sdks-folder for folder parameter to autorest.

Test on openapi-env-test: https://github.com/openapi-env-test/azure-rest-api-specs/pull/3083
CI result: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1470974&view=logs&j=a8a7a537-82b0-583c-7971-bac70b9822ca&s=eb9754a7-3885-5b5b-bd91-16c95dd7881e
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

LGTM!


Index creation with lemmatize_en doesn't work as expected

Hi
I tried to perform the following command using docker container and got an error:
mysql> CREATE TABLE IF NOT EXISTS lis_prod_test (publish_date timestamp, internal_id text stored, article_body_hash text stored, content text indexed) stopwords = 'en' morphology='lemmatize_en' morpoholgoy='lemmatize_en_all' morpoholgoy='stem_en' morpoholgoy='libstemmer_en'  html_strip = '1' min_prefix_len='3' min_prefix_len = '3' engine='columnar';
ERROR 1064 (42000): error adding index 'lis_prod_test': failed to open /en.pak: No such file or directory

Afteward I tried to place e.pak into  /usr/share/manticore and  it doesn't work as well:
total 1628
drwxr-xr-x 1 root root    4096 Mar 27 16:31 ./
drwxr-xr-x 1 root root    4096 Mar 27 16:13 ../
-rw-r--r-- 1 root root      36 Dec 23 03:22 INSTALL
drwxr-xr-x 5 root root    4096 Dec 23 05:32 api/
-rw-r--r-- 1 root root 1632084 Mar 27 16:31 en.pak
drwxr-xr-x 2 root root    4096 Dec 23 05:32 icu/
drwxr-xr-x 1 root root    4096 Mar 20 20:50 modules/
drwxr-xr-x 2 root root    4096 Dec 23 05:32 stopwords/

Here's how you can do it.
snikolaev@dev:/tmp/docker$ mkdir data
snikolaev@dev:/tmp/docker$ cd data/
snikolaev@dev:/tmp/docker/data$ wget https://repo.manticoresearch.com/repository/morphology/en.pak.tgz
--2022-03-28 05:06:13--  https://repo.manticoresearch.com/repository/morphology/en.pak.tgz
...
2022-03-28 05:06:14 (13.5 MB/s) - ‘en.pak.tgz’ saved [789620/789620]

snikolaev@dev:/tmp/docker/data$ tar -xvf en.pak.tgz
en.pak

snikolaev@dev:/tmp/docker$ docker run --name manticore -v $(pwd)/data:/var/lib/manticore -e common_lemmatizer_base='/var/lib/manticore' -p <IP_ADDRESS>:9316:9306 -d manticoresearch/manticore
f43b7cf28b4c87e97b84885794454731a2ee98efc79e280ab065a314ad1f5167

mysql> create table t(f text) morphology='lemmatize_en'; call keywords('apples', 't');
Query OK, 0 rows affected (0.00 sec)

+------+-----------+------------+
| qpos | tokenized | normalized |
+------+-----------+------------+
| 1    | apples    | apple      |
+------+-----------+------------+
1 row in set (0.00 sec)

@sanikolaev I tried to build a reproducible use case but it seems it is not reproducible any longer and it was related to a substantial amount of data being deleted in an async fashion that's why this exception appears via JDBC and it is just my assumption so far.
Let's consider it as solved and I'll reopen the ticket in case I will be able to reproduce it again.

fixed in https://github.com/manticoresoftware/manticoresearch/issues/769


ISPN-11649 Remove Wildfly Modules

https://issues.redhat.com/browse/ISPN-11649

[x] Tested with empty maven repo
[x] Tested with -Pdistribution
[x] Tested documentation rendering
[x] Tested javadoc

Did not test the release: not sure if it's possible to do it without actually releasing

Testing the distribution build.
+8 −54,155  is tasty !

Thank @gustavonalle


nightly-20240611 perf degradation

Describe the bug
+---------------------------------------------------------------+--------------+------------+----------------------------------------------------+---------------------+-----------------------------+-------------------------------+
| BENCHMARK NAME                                                | EXECUTION ID | STATUS     | KEY METRICS                                        | FLUCTUATION OF BEST | FLUCTUATION OF LAST 10 DAYS | FLUCTUATION OF LAST EXECUTION |
+---------------------------------------------------------------+--------------+------------+----------------------------------------------------+---------------------+-----------------------------+-------------------------------+
| nexmark-q4-blackhole-medium-1cn                               |        31360 | Negative   | avg-source-output-rows-per-second                  | -31.71%             | -17.57%                     | -16.73%                       |
| nexmark-q5-blackhole-medium-1cn                               |        31362 | Negative   | avg-source-output-rows-per-second                  | -41.01%             | -17.13%                     | -10.00%                       |
| nexmark-q5-rewrite-blackhole-medium-1cn                       |        31366 | Negative   | avg-source-output-rows-per-second                  | -30.04%             | -14.86%                     | -8.63%                        |
| nexmark-q7-blackhole-medium-1cn                               |        31372 | Negative   | avg-source-output-rows-per-second                  | -20.86%             | -13.77%                     | -3.59%                        |
| nexmark-q8-blackhole-medium-1cn                               |        31381 | Negative   | avg-source-output-rows-per-second                  | -32.22%             | -11.24%                     | -16.42%                       |
| nexmark-q9-blackhole-medium-1cn                               |        31385 | Negative   | avg-source-output-rows-per-second                  | -28.78%             | -16.15%                     | -17.88%                       |
| backfill-datagen-100m-rows-medium-arm-all-affinity            |        31388 | Negative   | backfill-batch-query-latency-per-100m-rows         | 33.40%              | 29.95%                      | 35.49%                        |
| nexmark-q3-no-condition-blackhole-medium-1cn                  |        31399 | Negative   | avg-source-output-rows-per-second                  | -29.81%             | -20.53%                     | -26.39%                       |
| sysbench-select-random-limits-medium-1cn                      |        31400 | Negative   | sysbench-qps                                       | -66.10%             | -32.02%                     | -1.00%                        |

http://metabase.risingwave-cloud.xyz/dashboard/241-nexmark-blackhole-1cn-anti-affinity-rw-avg-source-throughput?namespace=daily
Error message/log
No response
To Reproduce
No response
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
nightly-20240611
Additional context
https://github.com/risingwavelabs/rw-commits-history?tab=readme-ov-file#nightly-20240611

Today (nightly-20240612) the performance seems to be back to normal.

Today (nightly-20240612) the performance seems to be back to normal.

Yep, any related fix we can paste here as a reference and close this one?

Yep, any related fix we can paste here as a reference and close this one?

I didn't find any direct fix in nightly-20240612 against anything in nightly-20240611. Is it an accidental jitter?

cc. @cyliu0


HIVE-26827 - Add configs in error message to workaround predicate iss…

…ue with Parquet on TIMESTAMP data type

What changes were proposed in this pull request?

Appending the error message with configs to workaround the issue
Why are the changes needed?

These changes help users to try the workaround as soon as they see the message instead of spending time analysing the issue
Does this PR introduce any user-facing change?

Yes, error message to contain workaround configs
How was this patch tested?

Added Junit test cases

@veghlaci05


bug: double tap a tab then go to a global page, back button missing and swipe back broken

Bug Report
Ionic version:
[x] 4.11.5
Current behavior:
using Angular router.navigate(), double-tap a tab then go to a global page, back button missing and swipe back broken
Expected behavior:
back button still appears, and swipe back gesture still working
Steps to reproduce:
1.run it
2.tap twice the tab
3.click the global page button
4.check the back button
Related code:
A sample application via GitHub
https://github.com/peterzhang41/ionicDoubleTapTabIssue
Other information:
our team has to use NavController instead
Ionic info:
Ionic:
   Ionic CLI                     : 5.4.6 (/home/zehui/.nvm/versions/node/v10.17.0/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.11.5
   @angular-devkit/build-angular : 0.12.4
   @angular-devkit/schematics    : 7.2.4
   @angular/cli                  : 7.2.4
   @ionic/angular-toolkit        : 1.4.1

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : android 8.1.0
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.1.3, (and 4 other plugins)

Utility:

   cordova-res : not installed
   native-run  : 0.2.9

System:

   Android SDK Tools : 26.1.1 (/home/zehui/Library/Android/Sdk)
   NodeJS            : v10.17.0 (/home/zehui/.nvm/versions/node/v10.17.0/bin/node)
   npm               : 6.13.0
   OS                : Linux 4.15

See: #19293 and #18455

I think this is the same issue as described here: #19455, you can find my workaround in the comments which works fine for me. Unfortunately the author already closed the issue.

@DavidStrausz , keep in mind that the old window stack system (with the nav controller) is deprecated and will likely be removed in a future version

I'm encountering the same issue.  Double click on a tab will prevent the back button to display on the "next" page. :-(

Cannot reproduce anymore on 4.11.8 or newer. Can anyone confirm?

<EMAIL_ADDRESS>still be able to replicate, and it seems to be even worse now as one tap can also reveal it

I can confirm this is still an issue in 5.4.11. Tapping 2 or more times on a tab-button breaks back button on the next navigation. Any fix/workaround for this?

Yup, funny thing is that I cannot reproduce this using the Ionic Conference Starter, but with other apps. The only difference is in the way (angular) routing is set up. Haven't nailed it down yet, but something gets messed up when tapping a tab button while already being on the root page for the tab - on consecutive navigations within the tab, the previous component will be destroyed (ngOnDestroy called), and thus there is no back button available. we had to hard code back button hrefs because of that - still, the animation is messed up due to the routing issues.
@liamdebeasi , we experience this bug since 4.x - any chance someone might take a look at this?

As stated in #19455 , setting this.navController.setDirection('forward'); before calling this.router.navigate(['some',path]); actually seems to solve the issue.
Should we use navController.navigateForward instead of router.navigate to navigate through the app, in order to avoid this problem?

At least since Ionic 4 you shouldn't use the navController at all and use Angular Routing - the old nav controller is deprecated

I guess this has something to do with the routing - together with componentless routes and redirects and/or the way navigation happens when tapping an already open tab with its root component being displayed. Lazy loaded routes and componentless modules seem to play a role here - I am able to work around this by moving some child routes into the tab routing module.
I'm currently investigating and trying to nail this down a bit more.

Hi everyone,
This looks to be the same issue as https://github.com/ionic-team/ionic/issues/21074. There is a dev build in https://github.com/ionic-team/ionic/issues/21074#issuecomment-616695624 if people are interested in testing a fix out (requires Ionic 5.0+).
Thanks!

Thanks for the issue. This has been resolved via https://github.com/ionic-team/ionic/pull/21085, and a fix will be available in an upcoming release of Ionic Framework.

Is this also being ported to ionic 4?

This fix will not be ported to Ionic 4. Ionic 4 is only receiving critical security fixes moving forward.


fix Fix status update

Proposed changes
If BE crashed the error would be logged, and the analysis task would be mark as finished, which is incorrect.
In this PR, update analysis task according to the query state

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Sixth Korean l10n work for release-1.16

Sixth Korean l10n work for release-1.16

Update _index.md (#17762)
Update apparmor.md (#17767)
Update hello-minikube.md (#17771)
Update guestbook.md (#17773)
Update localization_ko.md (#17777)
Fix grammatical errors (#17776)
Translate /docs/reference/issues-security/security.md in Korea (#17763)
Create issues.md (#17765)
Update basic-stateful-set.md (#17774)
Fixed typo ko/docs/concepts/overview/components.md (#17778)
Modify typo. (#17802)
Update cloud-controller.md (#17760)
Update file outdated korean docs in dev-1.16-ko.6. (#17772)
Translate concepts/services-networking/ingress-controller in Korean (#17858)
Update ingress-controller.md
Translate services-networking/ingress.md in Korean. (#17807)
Fix grammatical errors (#17775)
Translate docs/contribute/style/write-new-topic.md in Korean (#17758)

Co-Authored-By: const-k<EMAIL_ADDRESS>Co-Authored-By: Yuk, Yongsu<EMAIL_ADDRESS>Co-Authored-By: power8993<EMAIL_ADDRESS>Co-Authored-By: reung37<EMAIL_ADDRESS>Co-Authored-By: Chihoon-Sung<EMAIL_ADDRESS>Co-Authored-By: Claudia J.Kang<EMAIL_ADDRESS>Co-Authored-By: Seokho Son<EMAIL_ADDRESS>

/assign
/lgtm
/approve


Install help

Hi, i m getting stuck on a very beginning, INSTALL
after copy the CONTENT of source to
http://app.mydomain.com/
and navigate to the install. it return a BLANK page ( checked the error return is 404.shtml )
did anyone experience this? can help
thank you. running:
PHP 5.4.29
mysql 5.5.36-cll

Closing due to age of issue.  Please reopen if still required.


Add columns to error messages

Just caught up to the latest video in the series and saw @orosmatthew wanted to but didn't implement columns. This series has been great in teaching me C++ and learn more about how compilers work.
Simple solution to add a column count to error messages that works pretty well for it's simplicity.
Changes:

Parser.hpp

Update to display column count in error_expected() and the binding.

Tokenization.hpp

Add a column_count int that is incremented on each consume and is reset to 1 on new lines.
Update all token.push_backs() to include column_count

Submit your pull request to my fork ApplePieCodes/hydrogen-cpp. The original seems to have stopped accepting them

With commit 1e2d30d2c0f75313890f8faba78the line numbers have been added.
This PR should be closed.


[MNT] CI failing due to missing codecov token

The CI seems to be failing due to a missing codecov token?
Example: https://github.com/felipeangelimvieira/prophetverse/actions/runs/9032395207/job/24820502043?pr=22

That's strange, it happens only with dependabot PRs 🤔
The CI execution of this PR that I've just opened worked well... Maybe it has to do with permission to access the token, depending on who's lauching the CI process?
I'll take a loot at it later. Thank you for pointing this out Franz

Seems to have solved dependabot CI workflows by adding secrets to the project settings. The codecov secret was missing in "Dependabot" section.
https://github.com/felipeangelimvieira/prophetverse/actions/runs/9417860637


[cf-types] *Data types for Events

Describe the bug
There should be some *Data type for each of the messages so consumers of the package can import them easily rather than using the *Message types exclusively.

Fixed, closing


WIP Fix usage w/ doctrine-fixtures-bundle^3.0

Q
A

Branch?
master

Bug fix?
yes #27

New feature?
no

BC breaks?
yes (for now)

Deprecations?
yes (for now)

Tests added
not yet

Doc added
updated

WIP

[ ] Make doctrine-fixtures-bundle dependency optional or drop fixtures/directories support ;

Hi,
Sorry I missed that PR.
I created a v7.0 branch. This PR will be merged here as there are BC breaks.


Revert "OCPBUGS-3493: added suggest ns to manifest"

Reverts openshift/ingress-node-firewall#239

/bugzilla refresh

/bugzilla refresh

/bugzilla refresh


Failed to get user roles

Hi,
I'm using spree-3-1 and after installing this gem I can't enter admin area, it fails on this line with such error
Started GET "/admin/orders" for ::1 at 2017-03-02 21:58:18 +0300
  ActiveRecord::SchemaMigration Load (5.6ms)  SELECT "schema_migrations".* FROM "schema_migrations"
Processing by Spree::Admin::OrdersController#index as HTML
  Spree::Preference Load (0.4ms)  SELECT  "spree_preferences".* FROM "spree_preferences" WHERE "spree_preferences"."key" = $1 LIMIT 1  [["key", "spree/backend_configuration/locale"]]
  Spree::User Load (2.8ms)  SELECT  "spree_users".* FROM "spree_users" WHERE "spree_users"."deleted_at" IS NULL AND "spree_users"."id" = $1  ORDER BY "spree_users"."id" ASC LIMIT 1  [["id", 1]]
Completed 500 Internal Server Error in 92ms (ActiveRecord: 9.6ms)

PG::UndefinedTable - ERROR:  relation "spree_roles_users" does not exist
LINE 5:                WHERE a.attrelid = '"spree_roles_users"'::reg...
                                          ^

I've tried in console
[6] pry(main)> user ||= Spree.user_class.new
[7] pry(main)> user.roles
ActiveRecord::StatementInvalid: PG::UndefinedTable: ERROR:  relation "spree_roles_users" does not exist
LINE 5:                WHERE a.attrelid = '"spree_roles_users"'::reg...
                                          ^
:               SELECT a.attname, format_type(a.atttypid, a.atttypmod),
                     pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod
                FROM pg_attribute a LEFT JOIN pg_attrdef d
                  ON a.attrelid = d.adrelid AND a.attnum = d.adnum
               WHERE a.attrelid = '"spree_roles_users"'::regclass
                 AND a.attnum > 0 AND NOT a.attisdropped
               ORDER BY a.attnum

but I can see such roles created after installing
[5] pry(main)> Spree::Role.all
  Spree::Role Load (0.5ms)  SELECT "spree_roles".*  I'm using Spree 3.2 and spree_admin_roles_and_access 2.0.0
Correct me if i'm wrong.
Thanks!

@huyngvu
Any reason for not using the latest version of this extension ?
The latest version has a lot of improvements including a fancy UI for admin.
Regarding your error:
As can be seen in the shared screen print, the extension is looking for a table spree_roles_users which does not exist in your db.
This join table used to be there (hard coded) until recently. See this commit for details
P.S. I have used this extension in one of my projects and will be happy to share my experience.

@Anuragjain89 thanks bro, I fixed it yesterday by override User model.
The latest version you said is branch master?

@huyngvu
Yep. That's the latest one.
In fact, there are some more improvements / bug fixes ( here's my PR ) lined up which are likely to be merged into the master.


[api-docs] remove outdated notice instead

A new commit was made into the api-docs repo. This issue was created automatically. Need to review if we made any change to the library for this commit.
https://github.com/discord/discord-api-docs/commit/e22c91a5743968dc15d94d1024d184262c04133f

ncn


[bug] In Python 3.4 and below inspect.stack() returns just a tuple in the list, not a list of named tuples

Describe the bug
In Python 3.4 and below inspect.stack() returns just a tuple in the list, not a list of named tuples. Only since version 3.5 does it return a list of named tuples.
To Reproduce
Steps to reproduce the behavior:

Having the following folder structure

 Project structure

# example.py
# settings.ini

Having the following config files:

 Config files
settings.ini
[default]
path = 'example.txt'

Having the following app code:

 Code
example.py
from dynaconf import settings

print(settings.PATH)

Executing under the following environment

 Execution
$ python example.py

Traceback (most recent call last):
  File "example.py", line 3, in <module>
    print(settings.PATH)
  File "C:\Python\Python34\lib\site-packages\dynaconf\base.py", line 93, in __getattr__
    self._setup()
  File "C:\Python\Python34\lib\site-packages\dynaconf\base.py", line 118, in _setup
    default_settings.reload()
  File "C:\Python\Python34\lib\site-packages\dynaconf\default_settings.py", line 74, in reload
    start_dotenv(*args, **kwargs)
  File "C:\Python\Python34\lib\site-packages\dynaconf\default_settings.py", line 61, in start_dotenv
    or _find_file(".env", project_root=root_path)
  File "C:\Python\Python34\lib\site-packages\dynaconf\utils\files.py", line 62, in find_file
    script_dir = os.path.dirname(os.path.abspath(inspect.stack()[-1].filename))
AttributeError: 'tuple' object has no attribute 'filename'

Expected behavior
from dynaconf import settings

print(settings.PATH)
# 'example.txt'

Debug output

 Debug Output

export `DEBUG_LEVEL_FOR_DYNACONF=DEBUG` reproduce your problem and paste the output here
2019-08-26:16:46:23,988 DEBUG    [default_settings.py:55 - start_dotenv] Starting Dynaconf Dotenv Base
2019-08-26:16:46:23,989 DEBUG    [files.py:57 - find_file] No root_path for .env
Traceback (most recent call last):
  File "example.py", line 3, in <module>
    print(settings.PATH)
  File "C:\Python\Python34\lib\site-packages\dynaconf\base.py", line 93, in __getattr__
    self._setup()
  File "C:\Python\Python34\lib\site-packages\dynaconf\base.py", line 118, in _setup
    default_settings.reload()
  File "C:\Python\Python34\lib\site-packages\dynaconf\default_settings.py", line 74, in reload
    start_dotenv(*args, **kwargs)
  File "C:\Python\Python34\lib\site-packages\dynaconf\default_settings.py", line 61, in start_dotenv
    or _find_file(".env", project_root=root_path)
  File "C:\Python\Python34\lib\site-packages\dynaconf\utils\files.py", line 62, in find_file
    script_dir = os.path.dirname(os.path.abspath(inspect.stack()[-1].filename))
AttributeError: 'tuple' object has no attribute 'filename'

Environment (please complete the following information):

OS: Windows 8.1
Dynaconf Version 2.0.4
Python Version 3.4.3

I'm the same guy who just still uses Python 3.4 and has not yet updated. I think this is a great reason to finally do it :)


Feat: Optimize speed and memory usage

Speed and memory usage optimization

Implemented in v2.2.6


Change or remove include/Platforms/c2000/stdint.h

The named file defines uint8_t for C2000 MCUs using the following line:
https://github.com/cpputest/cpputest/blob/81eb8b8fd3ba4a85097c01d1e114c4315b8d8b44/include/Platforms/c2000/stdint.h#L34
This is done because on C2000 platforms, a char is 16bit (as this is the smallest addressable unit on this MCU core).
Anyway, this is bad behavior for two reasons:

A uint8_t is defined to be 8 bit wide, not 16 bit. People might rely on that (for overflow behavior, e.g.). Defining a uint8_t to a 16bit wide type is no good idea.
It usually is considered bad to re-define standard types (even if they are not available on this platform)

A solution would be to change this line to typedef unsigned char uint_least8_t;. That way it is indicated that the size is 8bit or more.
Anyway, this should not be necessary, as at least current C2000 compilers already do exactly that.
In addition, it seems, that at least in CppUTest, uint8_t is not used at all.
Thus, I recommend removing this line.

I've never been able to get a C2000 build stood up so I've been hesitant to touch it. If you're able to test the change, a pull request would be appreciated.

I can try, but I'm not sure where to start.

The toolchain used for the tests is far outdated (even if the exact version is nowhere stated).
Update to a new toolchain or stay with the old one?
I'm not even sure if the old one is still available, anyway, the current version should be able to import old projects (creating a new project would also not be rocket science)
If built using a new IDE version, also the new compiler will be used, which is likely to be incompatible to the existing code
Testing: TI moved away from their C2000 simulator, and recommends their Launchpad evaluation boards. Good for eval board sales, bad for cloud-based CI

I try to figure out how to test it in a few weeks and will keep you updated on the available options before creating a PR.
Is there a guideline/strategy I can fallow on how to deal with deprecated and/or non-testable platforms in this project (upgrade to newer version, drop support, etc.)?

We tend to try to keep support for old platforms and versions. So, if it is possible to put the newer version next to the existing one then often that is preferred (so people using old versions can also use it). If that becomes too troublesome, then better just upgrade.

There are no references to uin8_t anywhere else in CppUTest, including the platform examples. I think this can be safely removed.


建议增加镜像的描述信息，如dockerfile，run的启动脚本等。

查看镜像时，如果有dockerfile和启动方面信息展示，就太好了，方便镜像的内部传播和使用，减少沟通成本，更方便管理

the issue is, we don't have a build engine, so there's no way to  ensure the consistency between image and docker file.

哈哈我也觉得有个Dockerfile会效果更好。

cool

This should be mitigated after introducing the "history" of an image.

Without further a due I'm closing this issue given user can see "history" of an image from UI.


What is the use case for onHeightChange callback?

(Context: I am playing around with using this in https://github.com/necolas/react-native-web/)
What do you see as the use case for this? The callback takes a height, which seems to be the CSS height (respects border-box) rather than the layout height of the element.
So to implement onLayout I need to re-query the DOM anyway, to get the outer height/width/offset. But one thing I cannot do easily is infer the number of rows. That might be quite useful to pass to the callback.

Sounds reasonable. i'd accept a PR for that.

I'll probably drop this dependency as it's not actively developed or tested, so won't get around to adding this change.


refactor: remove usage of monolithic arkCrypto.h

Summary

Updated arkCrypto.h header to just be a dummy header for the sole
purpose of forcing the cpp-crypto library to be linked into an
Arduino sketch.
Updated tests to use specific headers instead of arkCrypto.h
Updated Arduino sample sketches to use only the headers required
for the sketch.

Checklist

[ ] Documentation (if necessary)
[x] Tests (if necessary)
[x] Ready to be merged

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.
If no reviewer appears after a week, a reminder will be sent out.

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.
Thank you for your contribution!

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.