Add the DFDL snippets

Use #43 as a reference implementation and add the DFDL snippets file to the extension.

Not sure if the email I sent went to the group, so here is the text:
It’s been a while since I used github.  I cloned the example-snippets-vscode repository, and created a new branch. But I don’t have permission to push the code:
git push --set-upstream origin dfdl-snippets
remote: Permission to jw3/example-daffodil-vscode.git denied to rthomas320.
fatal: unable to access 'https://github.com/jw3/example-daffodil-vscode.git/': The requested URL returned error: 403
I also tried making my github the remote origin.  I was able to push the branch to my repository, but I’m not sure how or if I can create pull request from my repository to your repository.
The problem maybe that I have to git accounts a personal account regetom that uses my personal email address, this is where I have been getting all the email for this project, and my work git account rthomas320, this is tied to my work email and the computer with the source code.
I haven’t been using my personal git account much, so I haven’t set up an access token or 2 factor authentication.  Not sure what the easiest way to get the code into the repository is.  Any suggestions would be appreciated.

I added your @rthomas320 account as a collaborator to this repo, which should allow you to push a branch.

The other account @regetom was previously added as a collaborator, but if you aren't going to use that I will remove it for clarity.

Alternatively @regetom could fork the repo and push a PR there. But it's better to be a collaborator.
Also, GitHub should have better error messages, or perhaps git should relay the error message better.

Push to update the snippets file still fails.  I attached the code for the snippets file at the end I had to add the txt extension to upload the file). Maybe the easiest thing for now is to have someone else commit the [file.
git push
fatal: The current branch dfdl-snippets has no upstream branch.
To push the current branch and set the remote as upstream, use
git push --set-upstream origin dfdl-snippets
git push --set-upstream origin dfdl-snippets
remote: Permission to jw3/example-daffodil-vscode.git denied to rthomas320.
fatal: unable to access 'https://github.com/jw3/example-daffodil-vscode.git/': The requested URL returned error: 403
[dfdl.code-snippets.txt](https://github.com/jw3/example-daffodil-vscode/files/7046380/dfdl.code-snippets.txt)


Filtering using Asset Pipelines

Thanks for this amazing Gem!
I've been through all the docs + issues + code and I'm quite confused on how to filter keys. Currently I have tried these ways:
# i18n-js.yml
- file: "app/assets/javascripts/i18n/translations.js"
  only: "studio_dash.*"

# i18n-js.yml
- only: "studio_dash.*"

There's a number of competing issues that make me unsure this is the correct way to go about it.
Am I forced to use the middleware or can I keep it in the pipeline?

Can you try *.studio_dash.*?
We change to use that format since some user want to filter by locale as well
Which is a valid case

@PikachuEXE thanks for the super fast response. Here's my i18n-js.yml
translations:
  - only: "*.studio_dash.*"

translations:
  - file: "app/assets/javascripts/i18n/translations.js"
    only: "*.studio_dash.*"

I tried both and filtered-<fingerprint>.js comes up with 100% of my keys. The translations-<fingerprint>.js file is empty though?

It seems you are trying to use with asset pipeline
So #= require i18n/translations?
Also there are some bugs in caching
maybe try to change something in translation files (add some meaningless entries)

There it is, caching was the answer. Thank you sir!


Enable GZIP for V2

The script from https://az416426.vo.msecnd.net/scripts/b/ai.2.min.js is served without gzip compression.

I believe this to be a misconfiguration, since https://az416426.vo.msecnd.net/scripts/a/ai.0.js is served with the correct Content-Encoding.
See related issue #42

Looks like compression was not enabled for text/javascript. I've enabled and verified that it is now being served properly.


SDKs flow

Adding examples to SDK

Vi na PR do @bressani e seria legal adicionar aqui tb:

refund example
bank account transfer example

superseded by #219


Use macOS 12 for testing.

GitHub has officially begun to drop macOS 10.15 support, causing workflows to fail.

Should we consider macos-11 instead instead of macos-12, to help ensure that our NDLL binaries will remain compatible with the oldest possible macOS version? I recall that's why we were chose macos-10.15 instead of going the easier route with macos-latest.

Guess I'm out of the loop on this. Sure, we can do that.

Wait, didn't they officially drop support at the beginning of the month? How have workflows been working all this time? In any case, it's time to merge.


Custom Keras model adds extra dimension to scalar inputs

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04.6
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): 2.2.0
Python version: 3.7.3
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 10.1
GPU model and memory: TITAN V (12036MiB)

Describe the current behavior
I am creating a custom Keras model that takes scalar inputs (i.e. inputs have shape [batch_size]). When I compile the model and pass in a tf.data.Dataset to model.fit(), the shape of the input data is changed to [batch_size, 1].
However, when I train in a training loop using an iterator, the shape of the input data is [batch_size].
This happens both locally and on Colab.
Describe the expected behavior
The current behavior adds a side effect of changing the data input shape when using model.fit(). This behavior is inconsistent, since an extra dimension is not added to scalar inputs when training iteratively. The expected behavior would not add an extra dimension to scalar inputs, or at least be consistent between model.fit() and iterative training.
Standalone code to reproduce the issue
Colab Notebook: https://colab.research.google.com/drive/14RyEYCRtYCwryJhkd4koYnK04RlUoqrI?usp=sharing
import numpy as np
import tensorflow as tf

class ToyModel(tf.keras.Model):
  def call(self, inputs):
    # Inputs are scalar, so we should only have a batch dimesion.
    print("Input shape is {}".format(inputs.shape))
    return tf.reduce_sum(inputs)

toy_model = ToyModel()
optimizer = tf.keras.optimizers.Adam(learning_rate=1e-3)
loss = tf.keras.losses.MeanSquaredError()

data_size = 10
data_inputs = np.float32(np.random.randn(data_size))
data_outputs = np.float32(np.random.randn(data_size))
dataset = tf.data.Dataset.from_tensor_slices(
    (data_inputs, data_outputs)).batch(data_size)

# Train iteratively
iterator = iter(dataset)
inputs, outputs = iterator.next()
with tf.GradientTape() as tape:
  predictions = toy_model(inputs)
  loss_value = loss(outputs, predictions)
grads = tape.gradient(loss_value, toy_model.trainable_weights)
optimizer.apply_gradients(zip(grads, toy_model.trainable_weights))
# Input shape is [batch_size]

# Now, try training with fit() instead
toy_model.compile(optimizer=optimizer, loss=loss)
toy_model.fit(dataset, epochs=1)
# Input shape is [batch_size, 1]

Was able to reproduce the issue with TF v2.2 and TF-nightly. Please find the attached gist. Thanks!

@keyonvafa I think this is not a bug but intended behavior. Under the hood, some functionality of model.fit require the shape to be like that but it will not change your original data shape. Does this concern you for your use-case? Can you please mention little more details how this affects your use-case? Thanks!

@jvishnuvardhan Thanks for the response. The main issue for me is the inconsistency. Sometimes when I'm prototyping I'll train iteratively so I can debug in Eager mode. When I run it in the terminal I'll change training to model.fit, but I also have to include lines like inputs = inputs[:, 0] and outputs = outputs[:, 0].

@keyonvafa Is this still an issue for you? Are you interested in contributing to update any part of the code. Any update need to be backward compatible. Thanks!

@jvishnuvardhan Thanks for the note. For now I'm avoiding this issue by only using iterative training. I unfortunately don't have the bandwidth to contribute to the code

@keyonvafa Do you want to close the issue or keep it open? Thanks!

@jvishnuvardhan It seems like others are having the same issue so I'm fine keeping it open. Thanks!

Sure. I am adding contributions welcome labels so that community can pick it up and contribute. Thanks!

@keyonvafa , That was wrongly triggered message, please ignore it. Thanks!

Was able to replicate the issue with TF 2.5,please find the gist here ..Thanks!

I think this is not a bug but intended behavior.
@jvishnuvardhan i think this is clearly a bug right? because it's inconsistent behavior between using custom Model vs using functional API. Could you fix this? Thx.

Hi There,
This is a stale issue. As you are using an older version of tensorflow, we are checking to see if you still need help on this issue. Please test the issue with the latest TensorFlow (TF2.7 and tf-nightly). If the issue still persists with the newer versions of TF, please feel free to open it in keras-team/keras repository by providing details about the issue and a standalone code to reproduce the issue. Thanks!
Please note that Keras development has moved to a separate Keras-team/keras repository to focus entirely on only Keras. Thanks!


CSS Autocomplete stopped working

When this plugin is enabled, it seems to prevent CSS autocomplete from working. When I have a css file open and I am typing a property the autocomplete does not show suggestions for CSS.

Same issue here.

Duplicate of  #2

I also have the same issue, as well as my colleagues

Same here with Atom 1.19.2 and package version 1.3.1


[Bug]: undefined value in the bindings pane of explorer

Is there an existing issue for this?

[X] I have searched the existing issues

Description
https://www.notion.so/appsmith/Fix-the-bindings-that-show-undefined-values-23d6e18c1ebf4bd2856279ad221f89cf
Steps To Reproduce

Add a Table widget
Bind data to it
Open the explorer, click on more option for table widget and select show bindings
Notice that all the binding values are undefined.

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
1.9.61

related, maybe can be picked up separately: #30670


As an admin, I'd like error messages to include the user and org ids

For those admins that manage more than one org, it is useful to know which org the error is coming from.
We can have a message similar to the one Salesforce adds at the beginning of an error message:
Apex script unhandled exception by user/organization: xxxxxxxxxxxxxxxx/xxxxxxxxxxxxx

Included in beta release version 3.38 (Beta 5) and higher

Included in production release version 3.38


Bump/dbt 0 17 0

Repo checklist:

Making some updates to the package as part of a greater effort to update packages to be compatible with dbt 0.17.0

[x] A require-dbt-version parameter in the dbt_project.yml:

[x] The dbt_project.yml is in version 2 format (upgrading docs)

[x] Any sample dbt_project.yml snippets in the README.md are in v2 syntax (especially for packages that use vars

[x] Release is of format major.minor.patch, e.g. 1.0.0

[x] A license (example)

[x] If this package relies on dbt-utils, make sure the range allows v0.4.x

[x] Issue and PR templates (examples — make sure you update for the right package name)

[x] A codeowner (example)

[x] Installation instructions (see segment), including:

Link to packages docs
Variables that need to be included in the dbt_project.yml file
Listed database support

[x] A link to our package contribution guide (Might formalize this as a CONTRIBUTING.md file)

Upcoming Changes:

[ ] Models are documented
[ ] Macros are documented
[ ] Integration tests
[ ] Move model logic intro model files, rather than entirely in adapter macros

@sanjanasen96 Did you manage to test this locally with a dummy Redshift project?

@sanjanasen96 Did you manage to test this locally with a dummy Redshift project?

@jtcohen6


[IGNORE] Ccxdev 11638

Just for quay image creation, ignore
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Refactor (refactoring code, removing useless files)
Unit tests (no changes in the code)
Bump-up dependent library (no changes in the code)
Behavioral tests (no changes in the code)
Integration tests (Kafka, Logstash etc.)
Benchmarks (no changes in the code)
Documentation update

Testing steps
Please describe how the change was tested locally. If, for some reason, the testing was not done or not done fully, please describe what are the testing steps.
Checklist

[ ] pre-commit run -a passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
Attention: Patch coverage is 4.25532% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 86.36%. Comparing base (d6a2d10) to head (2a7233d).
Report is 6 commits behind head on main.

Files
Patch %
Lines

ccx_messaging/utils/clowder.py
4.44%
43 Missing :warning:

ccx_messaging/downloaders/http_downloader.py
0.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   88.23%   86.36%   -1.88%
==========================================
  Files          34       34
  Lines        1139     1166      +27
==========================================
+ Hits         1005     1007       +2
- Misses        134      159      +25

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[FLINK-10572] [JobManager] Enable Per-Job level failover config

What is the purpose of the change
Today we Failover strategy is a cluster level config, we cannot set it for individual job, this PR try to expose the config to ExecutionConfig and let it can be set in per-job level
Brief change log

Add enum FailoverStrategyType
Add set FailoverStrategyType in ExecutionConfig
Extract FailoverStrategyType and pass it to ExecutionGraph

Verifying this change
This change added tests and can be verified as follows:

A test in jobMaster to validate the config was passed correctly.

Does this pull request potentially affect one of the following parts:

The public API, i.e., is any changed class annotated with @Public(Evolving):  yes

Documentation

If yes, how is the feature documented? (not documented, will be handled in FLINK-10574

Closing this PR because it is quite out dated with respect to the current code base.


Coolcam Light switch 2 channel (EU-2) "does not support the CC assosiation" error

Build/Run method
[ X ] Manually built (git clone - npm install - npm run build )
zwavejs2mqtt version: 4.2.1
zwave-js version: 7.4.0
Describe the bug
Interview fails
Device : 600-4235-3 (0x0258-0x0003-0x108b)
Tried : multiple interviews without any success / remove device / factory reset device
Thanks for your support.
logs.txt

This should already be fixed on master -> #2646
I'll probably release a patch tonight.

Thnaks my friend and for your faaaaast answer :-)

Hello,
Just one small question, it tried to find the answer without success (probably wrong search ...)
I'm running with zwavejs2mqtt 4.3.0 (with included zwavejs 7.5.0).
How to upgrade only zwavejs to 7.5.1 without waiting next release of zwavejs2mqtt ?
Thanks for your help.


Spell lists are wonky in a few places

It looks like some of the spell lists are incorrect for sub-classes. Found missing spells in a number of cleric domains, the Eberron dragonmarks, and in some Warlock subclasses. Didn't do a full audit.
I might just fix it myself if I have time, but it looked like you were doing some clean up of cleric domains, so it might all be fresh in your head.

Fixed spell "Commune With City (UA)" being the wrong level.
Humblewood Campaign Setting - Cleric Circle Domain:
Heroism is a 1st level spell, but the book gives it to you at 3rd cleric level.
Removed Cleric (Nature) From "Call a Roggenwolf".
Removed Cleric (Peace) from "Acid Splash (UA)".
Added wyrm colors to "Warlock (Ancient Wyrm (HB))".
Fixed "Warlock (Great Dreamer (HB))" typo from "Conjure Minor Elementals".
Removed "Warlock (Lurker in the Deep (UA))" from the "Shatter" spell.
Fixed "Mages of Witherbloom" Spell lists accidentally using "Mass Cure Wounds" instead of "Death Ward".
Removed "Ray of Sickness", "Silence", "Feign Death", "Aura of Life", "Contagion", and "Legend Lore" from "Warlock (Undead (UA))" spell list.
Added "(HB)" tag to my own "Ungodly SCIENCE!" Spell list.
That should be all the Cleric and Warlock spell lists fixed.


Automatically copy the command string to the clipboard when clicked

To clarify, I'm talking about the command string used to save changes.
If this is too hard, just selecting the string on click would probably be enough.

Should be easily possible.

1f19160c30814af96bedbaf4718dd254ce9aeef0
Thanks @BrainStone :)


TensorFlowOnSpark vs Tenserflow distribution

Hello,
I am planing on using Tensorflow on multiple machines when searching in the internet I have found two solution to do this

distributed tensorflow
tenserflowOnSpark
could you guide me in my choice? There is no much resources in the internet that could help me with this choice.

I am planning to use keras too and I don't want to do a separate configuration for that. So I am really looking for something that after configuration will work with TesorFlow separately form keras and it will also work for keras with TenorFlow.
Thank you :)

It depends on a couple things:

What is the size of your "cluster"?  If it's a small number that you are managing yourself, you might want to just start with distributed tensorflow, so you will not need to install/learn Spark, and you can get started by following their examples fairly closely.  If it's a large cluster, or you will not be managing the cluster, then you would need some base layer of distributed filesystem and node management.  TensorFlow uses Kubernetes.  But for folks already on Hadoop/YARN/Spark, TFoS is a simple way to use distributed TF.
If you want to use Keras (separately from the tf.keras API in TF), then you'd likely need to install various dependencies (which implies that you will be managing these nodes yourself).  See #1.
What is the size of your data?  If you can fit your data on a single node by copying files around, then you MIGHT be able to get by without using a distributed filesystem.  But if you have more than is practical to fit on a single disk (or copy around), then you will definitely need some form of a distributed filesystem.
Do you have other pre-processing or post-processing tasks that you'd want to use Spark for?  If so, you'd want Spark w/ a distributed filesystem anyways.

Anyhow, those are the major points... hope that helps.

Closing for now.  Feel free to re-open if you have further questions.

Hi,
I am new to Tensorflow on Spark , I check the demo code u gays provided . I found that the tensorflow code is distributed . Does the code in Tensorflow should be distributed ?
Thanks.

@fansy1990 yes, your TF code must be capable of being distributed in order for it to work within TFoS.  TFoS really just helps you set up the cluster.  That said, in the past, you needed to convert single-node TF to distributed TF via tf.train.Server and if PS else worker boilerplate code.  Today, if you use tf.estimator.train_and_estimate, it lets you run the same code in both single-node and distributed environments.  We have an example here.


[Bug]: Removal of metadata key

What happened?
mikekk — Yesterday (14-Jan-24) at 9:32 PM
Hello everyone, I am able to add  new  keys  to the metadatas and their associated values, but once I 've added a new key to the collection metadatas, using the  collection.update, I can only change its value, can't delete anymore  the key from metadatas. Why that happens?  Is it a bug or a wanted behaviour? Thanks.

https://discord.com/channels/1073293645303795742/1191351965230313472/1195812744188932136
Versions
Chroma 0.4.22, Colab, MacOS
Relevant log output
import chromadb
client = chromadb.PersistentClient() #this is in-memory client, adjust as per your needs
collection = client.get_or_create_collection("mytest")
collection.add(ids=["id1"],documents=["document 1"],metadatas=[{"key_to_keep":1,"key_to_remove":2}])
records = collection.get(ids=["id1"])
print(records["metadatas"][0])
# {'key_to_keep': 1, 'key_to_remove': 2}
del records["metadatas"][0]["key_to_remove"] #remove the unnecessary key
print(records)
# {'ids': ['id1'], 'embeddings': None, 'metadatas': [{'key_to_keep': 1}], 'documents': ['document 1'], 'uris': None, 'data': None}
collection.update(ids=records["ids"],documents=records["documents"], embeddings=records["embeddings"],metadatas=records["metadatas"])
# verify
records1 = collection.get(ids=["id1"])
print(records1["metadatas"][0])
# {'key_to_keep': 1, 'key_to_remove': 2}

@tazarov Does deleting the older metadata for the record and then inserting the new metadata sound like a good approach? If yes, can raise a PR.

@GauravWaghmare, take a look at the CIP PR for this - https://github.com/chroma-core/chroma/pull/1636. There is a bit more "nuance" to things.
I'd love your input on the CIP.

@GauravWaghmare, to accommodate different use cases of how people update metadata. Users will update a document in a single overwriting operation. The intent is clear, and they don't necessarily need to know what is in the document to make the update. Metadata differs significantly, depending on the use case. The PR addresses as many use cases as I could think of:

Clear the metadata
Partial update
Full overwrite of metadata

Please elaborate on your thoughts in the PR if you feel the above use cases can somehow be merged into one or if you have a different idea about the implementation.


[capture] Specify offset in target clk cycles

Specify offset in target clock cycles, rather than number of samples.
Partially addresses #177
For the time being, I've added offset adjustment in the scope code (cw_segmented.py and device.py), because that's where we can read the sampling rate.
Perhaps there is an elegant way to do this computation without touching the scope code, but I don't see it at the moment.

Thanks @vrozic for initiating this. I've taken your work as a basis and continued the effort. I've now pushed back the result to this PR.
With this PR, the code now takes the PLL frequency of the target ( = ADC base frequency), multiplies that by an integer to get as close to 200 MHz (max sampling frequency of Husky) and then computes the number of samples to take as well as the horizontal offset based on numbers specified in target clocks. The nice thing about this is that we can very easily change the base frequency to get more oversampling without changing the offsets / window length.
What is missing from this PR is

the adjustment of the simplified capture script - @nasahlpa offered to take care of this
the corresponding changes to make this work with WaveRunner - @johannheyszl offered his help but he is OoO this week.

I think we should try to merge this asap to unblock other work.

Update: also the simple capture script now works with this.

Thanks for the review @nasahlpa , let's merge this :-)


nextpnr error

After running the command, FAB_ROOT=.. nextpnr-generic --uarch fabulous --json test_design/${DESIGN}.json -o fasm=test_design/${DESIGN}_des.fasm
I see an error
ERROR: Max frequency for clock 'clk': 6.29 MHz (FAIL at 12.00 MHz)
I am unable to find where the clock constraint of 12 MHz is set. I would like to relax it.
Can someone help?

Try to use the "nextnpnr-generic" option "--freq". For more info and options run "nextpnr-generic -h".


web sdk release script

Published the most updated version of the web-sdk as version 0.0.2 on npm.
Added a small script that I used to make the publishing process easier in the future.

I've been blocked from merging by a random test error that seems to be from firebase/firestore being updated: https://github.com/firebase/firebase-js-sdk/issues/5687
Will merge as soon as a solution is figured out

The error in the testing was addressed with #292 so this should be ready to merge now as well


Updated START tagging ADM

Modified prompt
Removed duplicated RED tag example, replaced with missing BLACK tag example
Removed duplicated inference call in identify_tag_color

@eveenhuis no issue here with the proposed changes.  Though please update the CHANGELOG.md file, if there isn't one already I typically create a new section above the latest release called Unreleased to track the changes prior to cutting an actual release, e.g.:
## Unreleased

### Added
- Added something

### Changed

### Fixed
- Fixed something

Slightly longer term it is worth thinking about capturing this prompt and samples somewhere alongside the other templates/texts so that we can switch between them more easily if we ever need to (for a/b testing etc.)

@dmjoy Added the changelog entry
Completely agree about the templating, Bill already has that as a TODO in the code. It doesn't look like we really use issues in this repo, is there somewhere specific we should note that down?

Thanks for the update, merging shortly.
We haven't historically used the issues here, but seems like a good time to start (especially since this is a very code specific task).


version

Hello, I would like to ask, what are the python, torch and cuda versions used in this code

We used the following:

Python version: 3.9.16
Pytorch version: 2.0.1 (with CUDA support: py3.9_cuda11.8_cudnn8.7.0_0)
CUDA version: 11.8

I think I know. Thank you

Excuse me again, have you encountered this error?


Going from layer -> OTLP collector -> Jaeger, causes a warning to be displayed in Jaeger

When opening a root trace generated by this library, the following warning is displayed in Jaeger:
    invalid parent span IDs=c1b973f219df2f05; skipping clock skew adjustment

This is a standalone server for now, so nothing is sending trace ids (yet), it just receives raw requests from a browser.

Currently the layer, automatically generate a trace_id (+span_id fake) if no trace/span is provide by the client (that will become an option). Maybe it's the cause.
Thanks for reporting

I've deployed it in a test environment now and honeycomb is also pointing this out:
.
Thanks for the quick replies and this crate in general. I just had to set it up for work today so I made the issues with things I came across when setting it up for the first time and I didn't have much time to really dig deep in them, so apologize if they were misconstrued as being annoyed or if I came across unhappy with this crate, I just quickly made the issues before I forgot about them.
That being said, awesome crate (especially the little touch of the function to get the current trace id), and I'd like to see this crate gain even more traction! So if you're OK with it I can potentially look into making a PR for this (probably somewhere next week).

The fix should be included into version 0.5.2.  Can you check on your side to ?
Thanks for the feedback

Just checked, works perfectly! Thanks for the quick fix!


Changed the Farsi messages folder to  which fixes #7438

It resolves #7438

Thanks! https://github.com/yiisoft/yii2/commit/b65006a4690e29b2364b2a97cd6c02e9eaa21af9


Ability to remove "YOURLS -- Your own URL Shortener" Title.

[x] I've read the guidelines for Contributing to YOURLS Projects
[X] This request isn't a duplicate of an existing request
[X] This is not a personal support request that should be posted on the YOURLS Discourse community

Summary
In the  of every page, "YOURLS -- Your own URL Shortener" shows.
Motivation
You should be able to change this to anything you want so your page can be personalized.
Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
A field in config.php to do this.
Describe alternatives you've considered
A setting in a config page.

YOURLS ships with a sample plugin that does exactly this. See the sample plugin and how it is made, and expand from there.

But it does not take out the "YOURLS -- Your own URL Shortener." It only adds onto the end of the title.

and expand from there.

This is the key phrase. @ozh isn't saying the sample plugin already does exactly what you want, but it can be adapted to do so.

and expand from there.

This is the key phrase. @ozh isn't saying the sample plugin already does exactly what you want, but it can be adapted to do so.

But it doesn't show me how? I am very confused.

Here's the relevant sample code.
Line 40 says:  * We're going to modify the <title> of pages in the admin area
yourls_add_filter( 'html_title', 'ozh_sample_change_title' ); tells YOURLS to run a function named ozh_sample_change_title when it's generating the html_title.
And this is the actual title-modifying logic:
function ozh_sample_change_title( $value ) {
	$value = $value . ' -- the sample plugin is activated';
	return $value; // a filter *always* has to return a value
}

PHP has string replace. Your title-changing function doesn't have to add text into the $value…

Here's the relevant sample code.
Line 40 says:  * We're going to modify the <title> of pages in the admin area
yourls_add_filter( 'html_title', 'ozh_sample_change_title' ); tells YOURLS to run a function named ozh_sample_change_title when it's generating the html_title.
And this is the actual title-modifying logic:
function ozh_sample_change_title( $value ) {
	$value = $value . ' -- the sample plugin is activated';
	return $value; // a filter *always* has to return a value
}

PHP has string replace. Your title-changing function doesn't have to add text into the $value…

Setting $value, will just work...
I am preparing a plugin for that.


WIP/POC - copy directories

see #206
If you agree this change i update doc and tests

I'm okay with this, but have You tried rsync:warmup from deployphp/recipes/rsync.php? I guess it does everything Your deploy:copy_dirs does, ony You can leverage all of rsync glory :wink:

Rsync is a good solution for many case.
Copy (cp) is installed on all system, so i think there solutions are complements one from other. Rsync if you install it and use on the same serveur or not and copy for simpliest cases.

@ZeeCoder Have you a point of view ?

@deployphp/maintainer this is really requested feature. We need to think how is better to bring it.

@AlexStansfield if you think this is usefull and writed as you wait, you can add a comment here

Just added PR #406 for copying vendors between releases

I think cool feature. @nicodmf can you add docs for this?


fix(website): fix blog post social card

It should show 2.1 instead of 2.0 😅

Can we enable auto-merge?

Can we enable auto-merge?

You mean once a PR is at least approved?
I still think it's useful to review the deploy preview in many cases, our tests do not capture 100% of problems

I don't know if auto merging requires PR approval. But for trivial changes like this, auto merging sounds fine.


template! macro is throwing an error

lib.rs
use leptos::{component, template, view, IntoView, Scope};
use web_sys::*;

#[component]
pub fn MyTable(cx: Scope) -> impl IntoView {
    let rows = (0..100)
        .map(|y| {
            let cols = (0..131)
                .map(|x| {
                    let value = format!("({x}, {y})");
                    template! { cx, {value}	 }
                })
                .collect::<Vec<_>>();
            template! { cx,
{cols}
 }
        })
        .collect::<Vec<_>>();

    view! { cx,

{rows}

    }
}

main.rs
use leptos::*;
use styler_examples::*;
pub fn main() {
    mount_to_body(|cx| view! { cx,  <MyTable/> });
}

Cargo.toml
[package]
name = "styler_examples"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
leptos = { git = "https://github.com/leptos-rs/leptos.git" }
web-sys = "0.3.61"

Error
error[E0433]: failed to resolve: could not find `MountKind` in `leptos_dom`
  --> src/lib.rs:11:21
   |
11 |                     template! { cx, {value}	 }
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `MountKind` in `leptos_dom`
   |
   = note: this error originates in the macro `template` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0433]: failed to resolve: could not find `MountKind` in `leptos_dom`
  --> src/lib.rs:14:13
   |
14 |             template! { cx,
{cols}
 }
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `MountKind` in `leptos_dom`
   |
   = note: this error originates in the macro `template` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0425]: cannot find function `mount_child` in crate `leptos::leptos_dom`
  --> src/lib.rs:11:21
   |
11 |                     template! { cx, {value}	 }
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `leptos::leptos_dom`
   |
   = note: this error originates in the macro `template` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0425]: cannot find function `mount_child` in crate `leptos::leptos_dom`
  --> src/lib.rs:14:13
   |
14 |             template! { cx,
{cols}
 }
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `leptos::leptos_dom`
   |
   = note: this error originates in the macro `template` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unused import: `web_sys::*`
 --> src/lib.rs:2:5
  |
2 | use web_sys::*;
  |     ^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unnecessary braces around block return value
  --> src/lib.rs:11:41
   |
11 |                     template! { cx, {value}	 }
   |                                         ^     ^
   |
   = note: `#[warn(unused_braces)]` on by default
help: remove these braces
   |
11 -                     template! { cx, {value}	 }
11 +                     template! { cx, value	 }
   |

warning: unnecessary braces around block return value
  --> src/lib.rs:14:33
   |
14 |             template! { cx,
{cols}
 }
   |                                 ^    ^
   |
help: remove these braces
   |
14 -             template! { cx,
{cols}
 }
14 +             template! { cx,
cols
 }
   |

error[E0599]: no method named `unchecked_into` found for struct `Node` in the current scope
  --> src/lib.rs:11:38
   |
11 |                     template! { cx, {value}	 }
   |                                      ^^
   |
  ::: /Users/abishek-15673/.cargo/registry/src/github.com-1ecc6299db9ec823/wasm-bindgen-0.2.84/src/cast.rs:78:8
   |
78 |     fn unchecked_into<T>(self) -> T
   |        -------------- the method is available for `Node` here
   |
   = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
   |
1  | use wasm_bindgen::cast::JsCast;
   |
help: there is a method with a similar name
   |
11 |                     template! { cx, <unchecked_into_f64>{value}	 }
   |                                      ~~~~~~~~~~~~~~~~~~

error[E0560]: struct `leptos::leptos_dom::Element` has no field named `element`
  --> src/lib.rs:11:38
   |
11 |                     template! { cx, {value}	 }
   |                                      ^^ `leptos::leptos_dom::Element` does not have this field

error[E0599]: no method named `unchecked_into` found for struct `Node` in the current scope
  --> src/lib.rs:14:30
   |
14 |             template! { cx,
{cols}
 }
   |                              ^^
   |
  ::: /Users/abishek-15673/.cargo/registry/src/github.com-1ecc6299db9ec823/wasm-bindgen-0.2.84/src/cast.rs:78:8
   |
78 |     fn unchecked_into<T>(self) -> T
   |        -------------- the method is available for `Node` here
   |
   = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
   |
1  | use wasm_bindgen::cast::JsCast;
   |
help: there is a method with a similar name
   |
14 |             template! { cx, <unchecked_into_f64>{cols}
 }
   |                              ~~~~~~~~~~~~~~~~~~

error[E0560]: struct `leptos::leptos_dom::Element` has no field named `element`
  --> src/lib.rs:14:30
   |
14 |             template! { cx,
{cols}
 }
   |                              ^^ `leptos::leptos_dom::Element` does not have this field

error[E0599]: no method named `unchecked_into` found for struct `web_sys::Element` in the current scope
  --> src/lib.rs:11:38
   |
11 |                     template! { cx, {value}	 }
   |                                      ^^
   |
  ::: /Users/abishek-15673/.cargo/registry/src/github.com-1ecc6299db9ec823/wasm-bindgen-0.2.84/src/cast.rs:78:8
   |
78 |     fn unchecked_into<T>(self) -> T
   |        -------------- the method is available for `web_sys::Element` here
   |
   = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
   |
1  | use wasm_bindgen::cast::JsCast;
   |
help: there is a method with a similar name
   |
11 |                     template! { cx, <unchecked_into_f64>{value}	 }
   |                                      ~~~~~~~~~~~~~~~~~~

error[E0599]: no method named `unchecked_into` found for struct `web_sys::Element` in the current scope
  --> src/lib.rs:14:30
   |
14 |             template! { cx,
{cols}
 }
   |                              ^^
   |
  ::: /Users/abishek-15673/.cargo/registry/src/github.com-1ecc6299db9ec823/wasm-bindgen-0.2.84/src/cast.rs:78:8
   |
78 |     fn unchecked_into<T>(self) -> T
   |        -------------- the method is available for `web_sys::Element` here
   |
   = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
   |
1  | use wasm_bindgen::cast::JsCast;
   |
help: there is a method with a similar name
   |
14 |             template! { cx, <unchecked_into_f64>{cols}
 }
   |                              ~~~~~~~~~~~~~~~~~~

Some errors have detailed explanations: E0425, E0433, E0560, E0599.
For more information about an error, try `rustc --explain E0425`.
warning: `styler_examples` (lib) generated 3 warnings
error: could not compile `styler_examples` due to 10 previous errors; 3 warnings emitted

What command are you using to build it?
If I add a wasm-bindgen dependency to Cargo.toml
wasm-bindgen = "0.2"

and import JsCast in lib.rs
use wasm_bindgen::JsCast;

It builds perfectly with trunk build, without the other warnings.

Ah I see. If I run cargo check I get all the errors you're describing. But if I run cargo check --target=wasm32-unknown-unknown, I do not. The DOM stuff is gated because a wasm32 check so it seems like something in whatever you're using to build it is setting up only for client-side rendering but not for WASM.

Yeah using trunk build it is working now. previously I was using cargo build. Also previously I haven't added below crates in Cargo.toml.
wasm-bindgen = "0.2.84"
web-sys = "0.3.61"

after addding these two and adding below import in lib.rs it is building successfully.
use wasm_bindgen::JsCast;

I know leptos is in an early state but an idea might be to give a better compilation error when this happens. Something like
"It seams you are compiling with feature "csr" (client-side-rendering), this is unsupported for non-wasm targets. Help: Change compilation target to wasm32-unknown-unknown, or disable csr feature.


IBC denom metadata creation fix

Description

closes: #1737

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

This source to destination swap makes sense based on the behavior that @tbrooks-figure was seeing on testnet against RC2.


Migrate Storybook component stories to new format

Use this script to auto-migrate the story, this helps you with the basis: https://storybook.js.org/docs/react/migration-guide#storiesmdx-to-mdxcsf.
You will still need to edit and adjust the files thereafter to get our desired result. Look at the stories of Accordion and Typography for inspiration.
Make a new issue + PR for each component when starting this cleanup
Checklist for new docs:

Make sure "show code" show correct code.
Make sure props table is interactive and works.

Have a look at Typography story for interactive props table on sub-components

Do adjustments to types if needed
Remove usages of TokenTable
Add jsdocs to proptypes

### Tasks
- [ ] Migrate Textfield stories to new format
- [ ] https://github.com/digdir/designsystem/issues/369
- [ ] https://github.com/digdir/designsystem/issues/514
- [ ] https://github.com/digdir/designsystem/issues/581
- [ ] https://github.com/digdir/designsystem/issues/583

Closing this as it will be solved as part of developing new updated version of the components for "felles designsystem".


Update README.md

Added an new showcase

Can you show what part is using Vuetify? It just looks like a nuxt application.

This Pull Request is being closed due to unresolved merge conflicts. Once corrected we will re-open.
Thank you for your contribution and interest in improving Vuetify!


Error loading Voxel Art model

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Windows
GPU
cuda
VRAM
6GB
What happened?
When trying to load the Voxel Art model on a fresh install I get the following error:
Loading voxel_art-1.0 from C:\Users\venjs\invokeai\models\ldm\stable-diffusion-v1\VoxelArt_v1.ckpt
| LatentDiffusion: Running in eps-prediction mode
| DiffusionWrapper has 859.52 M params.
| Making attention of type 'vanilla' with 512 in_channels
| Working with z of shape (1, 4, 32, 32) = 4096 dimensions.
| Making attention of type 'vanilla' with 512 in_channels
** model voxel_art-1.0 could not be loaded: Error(s) in loading state_dict for LatentDiffusion:
size mismatch for embedding_manager.string_to_param_dict.: copying a param with shape torch.Size([1, 768]) from checkpoint, the shape in current model is torch.Size([8, 768]).
size mismatch for embedding_manager.initial_embeddings.: copying a param with shape torch.Size([1, 768]) from checkpoint, the shape in current model is torch.Size([8, 768]).
Traceback (most recent call last):
File "c:\users\venjs\documents\github\invokeai\ldm\invoke\model_cache.py", line 80, in get_model
requested_model, width, height, hash = self._load_model(model_name)
File "c:\users\venjs\documents\github\invokeai\ldm\invoke\model_cache.py", line 232, in _load_model
model.load_state_dict(sd, strict=False)
File "C:\Users\venjs\Documents\GitHub\invokeAI\installer_files\env\envs\invokeai\lib\site-packages\torch\nn\modules\module.py", line 1604, in load_state_dict
raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for LatentDiffusion:
size mismatch for embedding_manager.string_to_param_dict.: copying a param with shape torch.Size([1, 768]) from checkpoint, the shape in current model is torch.Size([8, 768]).
size mismatch for embedding_manager.initial_embeddings.: copying a param with shape torch.Size([1, 768]) from checkpoint, the shape in current model is torch.Size([8, 768]).
Screenshots

Additional context
No response
Contact Details
<EMAIL_ADDRESS>

hmm. can you try something a bit hacky? can you go into configs\stable-diffusion\v1-inference.yaml, find personalization_config: and a few lines below that, change num_vectors_per_token: from 8 to 1?

Yep I will do that as soon as the 1000 image batch i'm running finishes in 3 hours :P

Ok, yep that seems to have done the trick. Does this need to be set back to "8" for the standard models?

Scanning Model: voxel_art-1.0
Model Scanned. OK!!
Loading voxel_art-1.0 from C:\Users\venjs\invokeai\models\ldm\stable-diffusion-v1\VoxelArt_v1.ckpt
| LatentDiffusion: Running in eps-prediction mode
| DiffusionWrapper has 859.52 M params.
| Making attention of type 'vanilla' with 512 in_channels
| Working with z of shape (1, 4, 32, 32) = 4096 dimensions.
| Making attention of type 'vanilla' with 512 in_channels
| Using faster float16 precision
| Loading VAE weights from: C:\Users\venjs\invokeai\models\ldm\stable-diffusion-v1\vae-ft-mse-840000-ema-pruned.ckpt

it should be fine to leave it at 1, this code is only used when there’s a textual inversion embedding being loaded, so it’s a bit weird that the voxel model uses it. i’ll have to investigate.

fixed by #1730


[BUG] Misalignment of Color Picker and Menu

Bug Report
Describe the bug
The color picker and menu positions on the website are not properly aligned, which negatively impacts the user experience. The color picker appears off-center and the menus are not aligned correctly with their respective elements.
To Reproduce
Steps to reproduce the behavior:

Go to the Draw It Out website.
Click on the color picker tool.
Observe the position of the color picker.
Navigate through the menus.
Observe the positions of the menus.

Expected behavior
The color picker should be left-upper and aligned properly within its designated area. Menus should be correctly positioned in center and aligned with their corresponding elements to provide a seamless user experience.
Additional context
This issue seems to affect both desktop and mobile versions of the site. Proper alignment is crucial for better user interaction and overall experience.

hey @singodiyashubham87
kindly assign me the issue.

Hey @singodiyashubham87 I am GSSOC contributor can you please assign this issue to me I would like to work on it!

@Atanu789 There are already several issue currently open related to the UI changes, let them be resolved & then if the issue persist, I'll assign you this issue.

@Atanu789 Is this issue still valid according to you?


allows matching 0 space before or after EATSPACE

Signed-off-by: Winckel Mathias<EMAIL_ADDRESS>Thanks for contributing!
Please check if the PR fulfills these requirements 👌:

[X] Confirm the PR related to a dedicated issue
[X] Confirm your PR corrects a single bug or implements a single feature
[X] Your code is linted locally prior to submission
[X] Your code is fully tested: 99% to 100% coverage
[X] Everything is correct on Sonar dashboard
[X] Confirm your code is under Apache 2.0 license
[X] Confirm your documentation is under CC-BY-4.0 license
[X] Confirm license and copyright content is created/updated in each file (see CONTRIBUTING.md)
[X] Confirm changelog.adoc is updated
[X] If corrects vulnerabilities, confirm changelog.adoc contains CVE IDs

Also remember: each commit MUST contain a sign off message (see CONTRIBUTING.md) 🙄
Indicate related issue:
issue #119
Explain what is done, scope, limitations etc.
Seems that whitespaces around EATSPACE place holder could be removed by other punctuation rules.
EATSPACE regex matching no longer requires whitespaces to work ( [\\s¤]+ => [\\s¤]*)
It avoids any chance of a EATSPACE text appearing after rendering.
Does this PR introduce a breaking change? 😁
no

I left a change aside, inverting some tests of eatspace in regards of the expected result:
bxlabla
bylabla
rbla
lbla

Do I need a new PR or can I add it in this one?


coqPackages.coqeal: 1.0.6 -> 1.1.0

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@vbgl successfully tested on coq-nix-toolbox https://github.com/coq-community/coq-nix-toolbox/pull/80


--thread-count doesn't seem to work

Whatever value I input into it, it always do the 16 that's set as default.
I'm running the script in Debian 11 with the latest actions from yesterday.
@nilaoda do you think you could take a look at this ?
Thanks in advance for the awesome script.

Please note that when recording a live stream, all tracks will be recorded simultaneously, and each track will have a number of threads equal to --thread-count to concurrently download the segments of that track.

You can manually execute the command to test it, and there is no doubt that --thread-count will take effect.

Take a look at this, and give me your opinion if possible

Also as a FYI if I run ps huH p 2307434 | wc -l I always get the 16 threads I have been talking about.

Also I'm running simultaneously 9 instances of N_m3u8DL-RE at the moment with 6 cores 12 threads, and I'm having high load averages: load average: 6.88, 5.92, 3.50
given that my command is this:
$command = "screen -dmS {$key} bash -c 'RE_LIVE_PIPE_OPTIONS=\"-f hls -hls_time 5 -hls_list_size 4 -hls_flags delete_segments /tmp/ramdisk/hls-data/{$key}/hls/playlist.m3u8\" /tmp/ramdisk/testing/N_m3u8DL-RE --thread-count 3 --no-date-info \"{$url}\" -H \"AppleCoreMedia/<IP_ADDRESS>K71 (Apple TV; U; CPU OS 16_1 like Mac OS X; pt_pt)\" --del-after-done --no-log --mp4-real-time-decryption --live-real-time-merge --live-keep-segments false --live-take-count 2 --live-pipe-mux --use-shaka-packager --key \"{$drm_key}\" -sv best -sa all --tmp-dir /tmp/ramdisk/hls-data/{$key}/tmp --save-dir /tmp/ramdisk/hls-data/{$key}/hls --save-name {$key}'";

What do you think I could do the improve the performance ?


Upgrade operator version

Upgrade operator manifest version

this is the annoying piece, there should be a way to automate all of these steps.


PostgreSQL错误修改为MySQL

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix nightly cron jobs

# m h  dom mon dow   command

0 18 * * * cd /home/ubuntu/unity-cs-infra/nightly_tests && ./run.sh --destroy true --run-tests true --project-name unity --venue-name nightly >> /home/ubuntu/nightly_run_`date +\%F_\%H-\%M`.log 2>&1

The cron job expression has been updated, the nighlty will run every day at 6pm

[@Joshua D Rodriguez](https://jpl.slack.com/team/U4TRSG66M)
, thanks again for creating the new MC release!  I think perhaps Tom pushed a different version that contained a reference to this commit:
https://github.com/unity-sds/unity-proxy/commit/59ec1f65c4227a56c9996714e2292887f99254df
(unity-proxy)
The reason why I think this, is that the error stacktrace above (which I believe is running the latest MC release), mentions EFSAccessPolicy, and the commit above would have prefixed that string like ${var.deployment_name}-EFSAccessPolicy .
I’m wondering if this line:
https://github.com/unity-sds/unity-management-console/blob/86a92cfe8691a0f86c62c0e34ace7c8a54dc2ce6/backend/internal/processes/bootstrap.go#L178
needs to be bumped up to 0.12 ?

The MC failed to spin up do to the above issue. Bumping the version to 0.12 fixed the issue.

PATH=/home/ubuntu/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
PATH variable needed to be set since cron uses a minimal environment, the cron job was failing to find the aws python etc command

The script set_common_ssm_params.sh uses the variable names prefixed with /unity/cs/..., but in AWS Parameter Store, they are actually named with the prefix /unity/ci/.... This mismatch in naming conventions is causing issues. Justed the name of the affected paramters to follow /unity/cs/.... Script now does not error on this issue,

ubuntu@ip-10-5-29-201:~/unity-cs-infra$ git pull
remote: Enumerating objects: 33, done.
remote: Counting objects: 100% (33/33), done.
remote: Compressing objects: 100% (18/18), done.
remote: Total 33 (delta 21), reused 26 (delta 15), pack-reused 0
error: insufficient permission for adding an object to repository database .git/objects
fatal: failed to write object
fatal: unpack-objects failed

The cronjob used to run the script with sudo privilege's, I believe this messed up the permissions for the .git directory.
sudo chown -R ubuntu:ubuntu .git
sudo chmod -R u+rwX .git
The above command fixed the permission issues

The nightly output didn't make it to Slack because the set_common_ssm_params.sh script overwrites the Slack URL
Link to PR that addresses this issue: https://github.com/unity-sds/unity-cs-infra/pull/69

The nightly now runs without issue in the new bastion host on Unity-CM

fixed


Add more specilalizations

Add trace, trace_oper_ket, svd and solve specializations.
Most of them are newly additions to Qutip.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

32 of 33 (96.97%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 95.385%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/qutip_jax/linalg.py
19
20
95.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
496

Relevant Lines:
520

💛  - Coveralls

LGTM @Ericgig. Is there some specific aspect I can help review here? This can be merged as it is.

If you are happy with it, please approve it and I will merge.

Yes I approve it. We have not put specific rules for approval before merge so you can go ahead and merge it now.


feat(x/photon): validate fee ante decorator

Relates to #44
This PR adds a sdk.AnteDecorator implementation in x/photon/ante and adds it to the list of the app ante decorators. This new ante decorator ensures that photon is the fee token or returns an error. Exceptions are possible like if the transaction's messages type URL are present in a new parameter of the photon module txFeeExceptions.
Some significant changes have been made to the e2e tests to make them compatible with this conditions.
uatone has also been put in a constant to avoid repetition (in app/params package)

Quite more extensive than what initially seemed to be. Mostly lots of changes required for tests and the issue with simulation.
One note, "Excepted" is rarely used and rarely I see it, I would use something else. I added a suggestion to the function name and I would also do this everywhere "excepted" is used, e.g. in the proto

Removed the 'excepted' term and renamed the function as suggested 15374464


Angular2+

Any plan to create Angular2+ directive for this wonderful project?

Has anyone found a port to angular2+ yet or anything close for an easy conversion?

Ok, I have an ng2+ version working, @darthwade  is this project still supported? and would it be best to create a fork/pull request, or would a separate repo be better?

I see a people here waiting for ng 2+ version. If you need something that will work today on v5.x support with a few small refactors you can use https://github.com/bculley/ngx-angular-loading, i'll try to keep on top of issues and collaboration welcome.
The concept is the same with slight renaming, code includes demo and short readme to get you going.


(Waiting on Dynamic Ontology) Fix saved search table breaking with ontology updates

[x] joeferner
[ ] sfeng88
[ ] mwizeman joeybrk372 jharwig

Important: Change base to master before merge
Testing Instructions: Verify saved search table still works after adding new concepts, edges, and properties that are part of the results.
no CHANGELOG

@joeybrk372 does this fix also work if items in the ontology is deleted?

yes, it will also handle deletions


visualize savings

how to show savings totals, benefits of pre-tax, etc...

experimenting with sankey:
// https://sankeydiagram.net/
// SOURCE [VALUE (can be a '?')] TARGET ([COLOR])
AGI [200] target
401k match [10] target
HSA match [2.5] target
target [37.25] 401k
target [7.75] HSA
target [167.25] Taxable Income
Taxable Income [37.25] Roth
Taxable Income [20] Taxes Owed
Taxable Income [110.00] Net Income
Net Income [90] Spending
Net Income [20] Savings (taxable)
401k [37.25] Savings (tax advantaged)
HSA [7.75] Savings (tax advantaged)
Roth [37.25] Savings (tax advantaged)

related user feedback:

I would organize the tool as budget-centric. User enters in their gross income, expenses, and taxes, and the tool then calculates available cashflow to be put toward priorities. Then, the cash flow cascades down the priorities like a waterfall. Your "saving summary" front page should basically be a budget, with income, expenses, and taxes at the top, and all remaining allocations to the categories shown below. I would't bother showing the match on this page; it's basically irrelevant to one's monthly budget.


Create: 2-Add-Two-Numbers.go

File(s) Modified: 2-Add-Two-Numbers.go
Language(s) Used:  go
Submission URL: _https://leetcode.com/problems/add-two-numbers/submissions/867412800/_

Thanks, @cybraia!


Digging Speed not working

Version: vanilla-hammers-3.2.0-1.18.1.jar
Fabric: 0.13.2
Configuration:
Set Diamond Hammer Digging Speed to 0.86
Set Stone Hammer Digging Speed to 0.43
Steps:
Mine blocks with each hammer paying close attention to the time required.
Expected Result: Diamond hammer should mine twice as fast as Stone Hammer.
Actual Result: Stone hammer and Diamond hammer mine at the same speed.

getMiningSpeedMultiplier() is unused


Missing args  in function calls

Hey please add args  to build(args ) etc.  and thanks for taking the time to make this plugin :)

Thanks for catching this, I thought I already did this in an earlier version, I am releasing a new version later today or tomorrow.

version 0.1.4 is published with the fix.


improve the documentation for the starter

Hi all,
I try to fix an issue https://github.com/EuroPython/epcon/issues/365 and when I execute the server with python manage.py runserver. but there is an issue ;-) the server is not configured in DEBUG mode, and it's normal because we use the current configuration for the production.
Just add a DEBUG=True in front of the command and the system will be execute in DEBUG mode.
Not specified in the README.md file.

Implemented by @alexsavio during the sprint @europython


refactor: internal/helper/image_unit_test : use table driven tests

Fixes #832
Unit tests were spread across various functions, but most of them can be organized into table driven test cases.

One other thing is missing here, that I should've noticed earlier, we require all commits to be signed: https://github.com/dyrector-io/dyrectorio/blob/develop/CONTRIBUTING.md#commit-signatures


add contributors graph

I want to add contributors graph in readme.Please assign this issue to me

@S-ishita Can you look into some bigger issue which will be really worthwhile for contribution since already this issue of handling contributor.md has been taken


Regtest does not reject dust transactions

This transaction is rejected as being dust on lbrycrd_main:
{
  "txid": "6a78ecf9cc7ed8ce700075ebc0f6598aec0e3d969703c5d8ec3dbc6d115fb2fc",
  "size": 192,
  "version": 1,
  "locktime": 0,
  "vin": [
    {
      "txid": "7992634f28066c38a89b6e44ae81db23eceed663180bd2bd2604c6c7db351a10",
      "vout": 0,
      "scriptSig": {
        "asm": "3045022100dc3fc3d565ef852e94d05f69b852c1d36b1079603a5f42aaff2cae49a08495a402205530fe6170096e7d33ab6e44d88836824bebe787e0780b52c6d0eec3b6de9bef[ALL] 03be327adddbf705c863115dfaad45f3dceab48bccf58406b74a33595695867d0a",
        "hex": "483045022100dc3fc3d565ef852e94d05f69b852c1d36b1079603a5f42aaff2cae49a08495a402205530fe6170096e7d33ab6e44d88836824bebe787e0780b52c6d0eec3b6de9bef012103be327adddbf705c863115dfaad45f3dceab48bccf58406b74a33595695867d0a"
      },
      "sequence":<PHONE_NUMBER>
    }
  ],
  "vout": [
    {
      "value": 0.00000000,
      "n": 0,
      "scriptPubKey": {
        "asm": "OP_DUP OP_HASH160 81a05dc24d35355bc880ed9998e1cc57e191bca0 OP_EQUALVERIFY OP_CHECKSIG",
        "hex": "76a91481a05dc24d35355bc880ed9998e1cc57e191bca088ac",
        "reqSigs": 1,
        "type": "pubkeyhash",
        "addresses": [
          "bQYfyRFjJ1xwx3qqtdb9htdHuv45KE8dAT"
        ]
      }
    }
  ]
}

while this regtest transaction is accepted:
  "txid": "4d9a274b782bb97bc685f6115e8eb8deaf873e4e9018e5d0ec832c8063d0400b",
  "size": 192,
  "version": 1,
  "locktime": 0,
  "vin": [
    {
      "txid": "0ad723f58eb5687c1ea8ff7f4c61a46167432012bf5f167d2b8e0a269e895874",
      "vout": 0,
      "scriptSig": {
        "asm": "3045022100b57b72c009bfa1e4bc84e67db045aa59383832328ac1a32261bcaabeaab0cb590220447778474c1b7edf97301dc22ba83ee44ca9cb497d505e3cc99e48bdd183ac9f[ALL]<PHONE_NUMBER>7c5a7e6f1486e99ba53dade8b80139e154a93f8d1a574df91cd4fbc1",
        "hex": "483045022100b57b72c009bfa1e4bc84e67db045aa59383832328ac1a32261bcaabeaab0cb590220447778474c1b7edf97301dc22ba83ee44ca9cb497d505e3cc99e48bdd183ac9f012102588081807c5a7e6f1486e99ba53dade8b80139e154a93f8d1a574df91cd4fbc1"
      },
      "sequence":<PHONE_NUMBER>
    }
  ],
  "vout": [
    {
      "value": 0.00000000,
      "n": 0,
      "scriptPubKey": {
        "asm": "OP_DUP OP_HASH160 2c2f6e664a3c59565b4bb5e271962ecdecfbddbb OP_EQUALVERIFY OP_CHECKSIG",
        "hex": "76a9142c2f6e664a3c59565b4bb5e271962ecdecfbddbb88ac",
        "reqSigs": 1,
        "type": "pubkeyhash",
        "addresses": [
          "mjYar5L8Re5JJvY5JwVQkvPuzJi5F4jsCR"
        ]
      }
    }
  ]
}

This makes testing the transactions produced by lbryum difficult since the dust rules for the test environment do not match the live network.

I think we can change this. There are likely some unit tests that need to be changed because they use regtest rules.

Actually the dust amount should be the same regardless of whether its main net or reg test, the default dust amount 0.00001.  You can set these variables manually so maybe its set somewhere either on the main net client or regtest client?
( set by -minrelaytxfee , can check it via ./lbrycrd-cli getinfo in the field relayfee  )
If that looks good, it must be rejected  for some other reason.  Can you describe how you generated these transactions?

The accepted transaction done through regtest can be replicated by this integration test (message me on slack if you want help setting things up to run it):
https://github.com/lbryio/lbrytest/blob/master/tests/test_abandon.py#L20
As far as the real mainnet transaction, this was generated by @tzarebczan . See convo here: https://lbryians.slack.com/archives/C81K0BM9A/p1519158521000395

Please use this flag when running lbrycrdd in regtest mode : -acceptnonstdtxn=0
(run ./lbrycrdd -acceptnonstdtxn=0 )
Behavior is documented here: https://github.com/lbryio/lbrycrd/blob/master/src/init.cpp#L461
IsStandardTx is not used when running in regtest mode, thus dust transactions are not rejected. Using the above flag will enable the use of IsStandardTx and will reject dust transactions.


Update Makefile

Update makefile to include command for running ABCI and Node from local testnet config.

Closing because it will be included in @ElFantasma 's changes


Support executable jars in JavaExec task (#1346)

Context
Feature has been requested in #1346
Contributor Checklist

[X] Review Contribution Guidelines
[X] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[X] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[X] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[X] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[X] Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

Thanks @stovocor - I resurrected parts of your PR and cherry-picked it to master.  This will be in Gradle 5.6
Instead of using a separate property (executableJar), we automatically use java -jar when two things happen:

main is not defined.
classpath is a single jar

Assuming package.Main is the entry point for the application, you can define Main-Class in the jar and run the jar with runExecutableJar.
jar {
  manifest {
    attributes('Main-Class': 'package.Main')
  }
}

task runExecutableJar(type: JavaExec) {
  classpath = files(tasks.jar)
}


Onnxruntime Seq2Seq doesn't work

It appears that when attempting to run a Seq2Seq model using the onnxruntime framework, an error arises after executing a config file in the command line. The error message indicates:
  File "/home/isolated-optimum-benchmark/optimum-benchmark/optimum_benchmark/benchmarks/inference/inputs_utils.py", line 18, in extract_text_generation_inputs
    raise ValueError("Could not find any valid text generation inputs.")
ValueError: Could not find any valid text generation inputs.

Additionally, in the logs, a warning regarding inputs is present:
[PROC-0][2024-04-12 15:21:38,250][benchmark][INFO] - Allocating inference benchmark
[PROC-0][2024-04-12 15:21:38,250][inference][INFO] -    + Creating input generator
[PROC-0][2024-04-12 15:21:38,250][input][INFO] -        + Using text2text-generation task generator
[PROC-0][2024-04-12 15:21:38,250][inference][INFO] -    + Generating Text Generation inputs
[PROC-0][2024-04-12 15:21:38,251][inference][INFO] -    + Preparing Text Generation inputs
[PROC-0][2024-04-12 15:21:38,251][onnxruntime][WARNING] - Input input_ids is not in expected inputs names. Removing it.
[PROC-0][2024-04-12 15:21:38,251][onnxruntime][WARNING] - Input decoder_input_ids is not in expected inputs names. Removing it.
[PROC-0][2024-04-12 15:21:38,251][onnxruntime][WARNING] - Input attention_mask is not in expected inputs names. Removing it.
[PROC-0][2024-04-12 15:21:38,251][onnxruntime][WARNING] - Input position_ids is not in expected inputs names. Removing it.

It seems that the issue may lie in the usage of input names in ORTModelForSeq2SeqLM. Specifically, in the inputs_names property within the onnxruntime backend, there is a check of attributes:
  @property
  def inputs_names(self) -> List[str]:
      if hasattr(self.pretrained_model, "inputs_names"):
          return self.pretrained_model.inputs_names
      elif hasattr(self.pretrained_model, "input_names"):
          return self.pretrained_model.input_names
      else:
          return []

However, ORTModelForSeq2SeqLM does not possess such attributes. The encoder and decoder of the pretrained model have "input_names".
For reference, here is the content of the config file:
defaults:
  - experiment # inheriting experiment schema
  - benchmark: inference
  - launcher: process
  - backend: onnxruntime
  - _self_ # for hydra 1.1 compatibility
  - override hydra/job_logging: colorlog # colorful logging
  - override hydra/hydra_logging: colorlog # colorful logging

experiment_name: pytorch_t5_small

launcher:
  device_isolation: true

benchmark:
  latency: true
  memory: true

backend:
  device: cpu
  no_weights: false
  use_io_binding: false
  model: google-t5/t5-small
  export: true
  library: transformers
  task: text2text-generation

# hydra/cli specific settings
hydra:
  run:
    # where to store run results
    dir: runs/${experiment_name}
  job:
    # change working directory to the run directory
    chdir: true
    env_set:
      # set environment variable OVERRIDE_BENCHMARKS to 1
      # to not skip benchmarks that have been run before
      OVERRIDE_BENCHMARKS: 1

Hi @Knzaytsev! Thanks for spotting this one, measuring prefill latency using the forward pass was causing many input issues (because the model doesn't expect the same inputs as with generate pass) so we were hacking our way around it.
I just solved this in #184 and added some text encoder-decoder tests, don't hesitate to flag this kind of issues or request specific model families to be added to our ci.

@Knzaytsev tell me if your problem was solved

@IlyasMoutawwakil
Yes, solved, thank you!


Fail to import entities that contain empty partitionkey/rowkey value

Storage Explorer Version: 1.22.0-dev
Build Number: 20211102.2
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 18.04/MacOS Big Sur 11.6
Architecture: ia32/x64
How Found: From running test cases
Regression From: Previous release (1.21.3)
Steps to Reproduce

Expand one storage account -> Tables.
Open one table -> Add an entity with the partitionkey/rowkey value is default.
Export the entities -> Then import the entities to a new created table.
Check whether succeed to import.

Expected Experience
Succeed to import.
Actual Experience
Fail to import with a failed activity log.
Errors:
Unable to import entity with partition key '' and row key ''.

@v-xianya A few questions:

Please clarify what you mean by "default partition/row key value". What are the default values? If they are empty, this would seem to conflict with #5120 and #5121.
Please share the contents of the CSV file you tried to import. This will help isolate the problem more effectively.

@craxal

Click 'Add' then click 'Insert' button without any changes on the Add Entity.(as the screenshot)

The .csv file to reproduce this issue.
atabley.csv

This appears to be due to some subtle differences in how keys are validated for createEntity vs upsertEntity. The platform definitely accepts entities with "" for partition or row keys, so it looks like a bug in the SDK. I've opened a new issue for them: Azure/azure-sdk-for-js#18521.

The SDK issue is still open, but I'm not able to repro with the current SDK version and current main, so I'm going to close.

Verified on the build 20211119.4. Fixed.


Fix DateTimePicker evaluations

Datetime picker accepts closures for the hasDate, hasSeconds and hasTime, but they're are not being evaluated. This PR fixes the behavior calling $this->evaluate() to evaluate the closures.

The calendar breaks when dynamically changing these properties, is this the "expected" behavior and the cause to the current non-evaluation approach?
If its a known wontfix issue, should we remove the Closure typing?

Thanks


Missing license

Just wanted to ask if there were plans to add a LICENSE.txt :) ?

Good catch, added an MIT license :+1:

Just to clarify -- the LICENSE field in pyproject.toml reads "Copyright ENEA Australia Pty Ltd - All Rights Reserved. Proprietary and confidential".
Is this an oversight, or intentional? As I would imagine this overrides MIT + I would like to use this in a work project.
Thanks

Definitely an oversight, thanks for pointing it out, it's been fixed!

I just saw in the MIT License:
https://github.com/RenaudLN/dash-pydantic-form/blob/bbbc8d0c91682487edac1e965fcc7a7f5f49d091/LICENSE#L3
I did not see how this is affiliated with Plotly and thought this might be a copy-paste error.
If not, sorry for the noise.
Anyway, cool project!

Oops, good catch


Getting error while downloading genefamilyabundance data of "AsnicarF2021"

I was trying to download "AsnicarF_2021"  data from the command line with CuratedMetagenomicData. I successfully downloaded the pathway abundance and species abundance data, but I am unable to download the genefamilyabundance data. I am using the following command:
deep@deep:~/Desktop/Asnicar_2021$ curatedMetagenomicData -m "2021-03-31.AsnicarF_2017.gene_families"

I am getting the following error:
Datasets to be downloaded:
2021-03-31.AsnicarF_2017.gene_families.tsv
Working on 2021-03-31.AsnicarF_2017.gene_families
snapshotDate(): 2021-05-18
Error in h(simpleError(msg, call)) :
  error in evaluating the argument 'x' in selecting a method for function 'rbind2': invalid class 'NA' to dup_mMatrix_as_geMatrix
Calls: rbind ... rbind2 -> rbind2 -> rbind2 -> .handleSimpleError -> h
Execution halted

Can you please tell me how can I download the data?
Many Thanks,
Deep Chanda

Hi again @DPC7, can you first try updating the underlying installation of curatedMetagenomicData with the following command.
Rscript -e "BiocManager::install('curatedMetagenomicData', ask = FALSE)"

Then run your command again and report back what happens.
deep@deep$ curatedMetagenomicData -m "2021-03-31.AsnicarF_2017.gene_families"

I patched an issue for the gene_families data type last week and it may be related.


⚠ ClamAV has degraded performance

In a03e886, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 208 ms

Resolved: ClamAV performance has improved in 2034f17.


[SPARK-23328][PYTHON] Disallow default value None in na.replace/replace when 'to_replace' is not a dictionary

What changes were proposed in this pull request?
This PR proposes to disallow default value None when 'to_replace' is not a dictionary.
It seems weird we set the default value of value to None and we ended up allowing the case as below:
>>> df.show()

+----+------+-----+
| age|height| name|
+----+------+-----+
|  10|    80|Alice|
...

>>> df.na.replace('Alice').show()

+----+------+----+
| age|height|name|
+----+------+----+
|  10|    80|null|
...

After
This PR targets to disallow the case above:
>>> df.na.replace('Alice').show()

...
TypeError: value is required when to_replace is not a dictionary.

while we still allow when to_replace is a dictionary:
>>> df.na.replace({'Alice': None}).show()

+----+------+----+
| age|height|name|
+----+------+----+
|  10|    80|null|
...

How was this patch tested?
Manually tested, tests were added in python/pyspark/sql/tests.py and doctests were fixed.

@HyukjinKwon We need a separate PR and target it to 2.3

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/566/
Test PASSed.

Hm .. could't we backport this to 2.3 as well? Or, do you suggest to make the current change to branch-2.3 only?

Test build #87037 has started for PR 20499 at commit 13bdc24.

cc @rxin, @gatorsmile, @holdenk, @zero323 and @viirya, this is an alternative of reverting its alias matching, and a fix to address https://github.com/apache/spark/pull/16793#issuecomment-362684399. Could you guys take a look and see if makes sense?

We need a separate JIRA and target it to 2.3

Sure.

Thanks!
Also cc @ueshin @cloud-fan

The linked JIRA targets 2.3.0 and it was an alternative of reverting https://github.com/apache/spark/pull/20496#issuecomment-362843558 .. Let me rebase it here anyway ..

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/567/
Test PASSed.

Test build #87037 has finished for PR 20499 at commit 13bdc24.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87037/
Test PASSed.

Test build #87038 has finished for PR 20499 at commit 198bda4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87038/
Test PASSed.

Merged build finished. Test PASSed.

I think this is what originally proposed in the JIRA:

It is possible to use dict as to_replace, but we cannot skip or use None as the value value (although it is ignored). This requires passing "magic" values:

df = sc.parallelize([("Alice", 1, 3.0)]).toDF()
df.replace({"Alice": "Bob"}, 1)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/571/
Test PASSed.

Test build #87042 has started for PR 20499 at commit 3da7ba6.

Test build #87042 has finished for PR 20499 at commit 3da7ba6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87042/
Test PASSed.

Test build #87051 has started for PR 20499 at commit 5c18594.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/576/
Test PASSed.

Test build #87051 has finished for PR 20499 at commit 5c18594.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87051/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/591/
Test PASSed.

Test build #87068 has started for PR 20499 at commit 1849f59.

Test build #87068 has finished for PR 20499 at commit 1849f59.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87068/
Test PASSed.

I think that behavior is shipped in 2.2, right? Then we may need to add a note in migration guide.

Yup, sounds good.

Seems RC3 is near to be cut, do we want to get this in 2.3?

is it a bug fix or a new feature?

I think it's a bug fix. For the context,

the dictionary support was added but value was required (and ignored) at the first place SPARK-6876:
df.replace({"Alice": "Bob"}, value=1).show()

value=None was added to allow the case below SPARK-19454:
df.replace({"Alice": "Bob"}).show()

but it happened to allow the case below too:
df.replace("Alice").show()

df.na.replace is an alias of df.replace. So, it has the same default value value=None SPARK-21658:
df.replace({"Alice": "Bob"}).show()

An design issue was raised in SPARK-21658 and  https://github.com/apache/spark/pull/16793#issuecomment-362684399 (SPARK-19454).
To cut it short, I think the issue raised is basically that the case below is weird:
df.replace("Alice").show()

SPARK-21658 was reverted.

This PR deals tries to throw an exception in 4. case, and also deals with SPARK-21658

Looks like an existing issue since Spark 2.2, I don't think this should block 2.3.

Sure, let me unset the target version.

I'd fix this in 2.3, and 2.2.1 as well.

Will update this tonight

Test build #87196 has started for PR 20499 at commit 9f49b05.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/698/
Test PASSed.

Test build #87198 has started for PR 20499 at commit a349d07.

LGTM, waiting for more feedbacks.

Test build #87201 has started for PR 20499 at commit 885b4d0.

Test build #87196 has finished for PR 20499 at commit 9f49b05.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class _NoValueType(object):

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87196/
Test PASSed.

Test build #87198 has finished for PR 20499 at commit a349d07.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class _NoValueType(object):

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87198/
Test PASSed.

Merged build finished. Test PASSed.

Test build #87201 has finished for PR 20499 at commit 885b4d0.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87201/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/705/
Test PASSed.

Test build #87205 has started for PR 20499 at commit 885b4d0.

Test build #87205 has finished for PR 20499 at commit 885b4d0.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87205/
Test FAILed.

retest this please

Test build #87206 has finished for PR 20499 at commit 885b4d0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87206/
Test PASSed.

thanks, merging to master/2.3!
Can you send a new PR for 2.2? it conflicts...

Yup, I should fix the guide for 2.2 anyway :-) Will open a backport tonight KST.


The baseUri value on the request log is handling the default value.

Hi,
Looking into the logs of my middleware API, I found that the logs for the request to commercetools the value for the baseUri are showing always the default value.
Steps to reproduce:

Follow the Readme to create the ClientBuilder and execute requests. https://github.com/commercetools/commercetools-sdk-typescript/blob/master/packages/platform-sdk/README.md
Use a different region (don’t use the default region that is europe-west1.gcp.
Add withLoggerMiddleware() to log the incoming requests and response objects.
Execute a request and validate the logs.

Result log:
Request:  {   baseUri: 'https://api.europe-west1.gcp.commercetools.com',   method: 'GET',   uriTemplate: '/{projectKey}/carts',   pathVariables: { projectKey: 'my-project-key' },   headers: {     Authorization: 'Bearer my-token,     'User-Agent': 'commercetools-sdk-javascript-v2/1.4.0 node.js/16.13.1'   },   queryParams: undefined,   uri: '/my-project-key/carts' }
As you can see, the request log is always showing the default baseUri:
baseUri: 'https://api.europe-west1.gcp.commercetools.com'
But the request is executed correctly in the host defined in the authMiddlewareOptions.
Dependencies version:
"@commercetools/platform-sdk": "^2.8.0"
"@commercetools/sdk-client-v2": "^1.4.0"
Thanks!!

Hi @fiquarato
To use a baseUri other than the default 'https://api.europe-west1.gcp.commercetools.com you need to pass it as a second argument to the createApiBuilderFromCtpClient() function.
Example
const {
  ClientBuilder
} = require('@commercetools/sdk-client-v2')
const { createApiBuilderFromCtpClient } = require('@commercetools/platform-sdk')
const fetch = require('node-fetch')

const projectKey = process.env.CTP_PROJECT_KEY
const authMiddlewareOptions = {
  host: "https://auth.us-central1.gcp.commercetools.com",
  projectKey,
  credentials: {
    clientId: process.env.CTP_US_CLIENT_ID
    clientSecret: process.env.CTP_US_CLIENT_SECRET
  },
  scopes: [`manage_project:${projectKey}`],
  fetch,
}

const httpMiddlewareOptions = {
  host: 'https://api.us-central1.gcp.commercetools.com',
  fetch
}

const apiRoot = createApiBuilderFromCtpClient(client, 'https://api.us-central1.gcp.commercetools.com') // this will force the apiRoot to use the provided baseUri
...

I hope this helps.

Hi @ajimae,
Yep, it helps to get the log with the URL that we are using.
But, this second argument is optional, and I think we should handle the URL set on the client.
Let me know what you think about it! Thanks!

Hi @fiquarato
Thanks for the feedback, I will have a discussion with my team on this.
Thanks

Hello there, I was going crazy about this issue as well.
Even if I set the API URL on the middleware the client doesn't seem to care about the API URL at all. If I do it like you propose (second argument) it works just fine.
Thanks for your help.


12.10失效

Traceback (most recent call last):
File "/opt/urllib3/util/connection.py", line 61, in create_connection
for res in socket.getaddrinfo(host, port, family, socket.SOCK_STREAM):
File "/var/lang/python3/lib/python3.6/socket.py", line 743, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -2] Name or service not known
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/urllib3/connectionpool.py", line 672, in urlopen
chunked=chunked,
File "/opt/urllib3/connectionpool.py", line 376, in _make_request
self._validate_conn(conn)
File "/opt/urllib3/connectionpool.py", line 994, in _validate_conn
conn.connect()
File "/opt/urllib3/connection.py", line 300, in connect
conn = self._new_conn()
File "/opt/urllib3/connection.py", line 169, in _new_conn
self, "Failed to establish a new connection: %s" % e
urllib3.exceptions.NewConnectionError: <urllib3.connection.VerifiedHTTPSConnection object at 0x7f80e71f2748>: Failed to establish a new connection: [Errno -2] Name or service not known
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/requests/adapters.py", line 449, in send
timeout=timeout
File "/opt/urllib3/connectionpool.py", line 720, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/opt/urllib3/util/retry.py", line 436, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='www.cpdaily.com', port=443): Max retries exceeded with url: /v6/config/guest/tenant/list (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x7f80e71f2748>: Failed to establish a new connection: [Errno -2] Name or service not known',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/var/runtime/python3/bootstrap.py", line 176, in handle
ret = self.real_handler(event, context)
File "/var/user/index.py", line 380, in main_handler
raise e
File "/var/user/index.py", line 343, in main_handler
apis = getCpdailyApis(user)
File "/var/user/index.py", line 38, in getCpdailyApis
url='https://www.cpdaily.com/v6/config/guest/tenant/list', verify=not debug).json()['data']
File "/opt/requests/api.py", line 76, in get
return request('get', url, params=params, **kwargs)
File "/opt/requests/api.py", line 61, in request
return session.request(method=method, url=url, **kwargs)
File "/opt/requests/sessions.py", line 530, in request
resp = self.send(prep, **send_kwargs)
File "/opt/requests/sessions.py", line 643, in send
r = adapter.send(request, **kwargs)
File "/opt/requests/adapters.py", line 516, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='www.cpdaily.com', port=443): Max retries exceeded with url: /v6/config/guest/tenant/list (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x7f80e71f2748>: Failed to establish a new connection: [Errno -2] Name or service not known',))

俺也一样

www.cpdaily.com 域名弃用 ，API 更改，见 PR

www.cpdaily.com 域名弃用 ，API 更改，见 PR

谢谢