[FEATURE] Enable Renovate on opensearch-project and repos that choose to use it

Is your feature request related to a problem?
The opensearch-sdk-java repo wants to enable automated issues for upgrading dependency versions.
See #185
What solution would you like?
While dependabot is an option, I believe Mend Renovate is a suprerior option.  It is endorsed by OpenSSF as the industry standard tool for dependency updates.
I have switched my external OS repo from dependabot to renovate and found it far superior for a few key reasons:

it was always faster at alerting on dependency updates than dependabot
it provides a header on the bump PR showing adoption percentage, test passing rate, age of the dependency, and other metrics that help evaluate if a dependency may break things
it provides a "Dashboard" issue for a very quick look at pending bump PRs

Enabling this on opensearch-sdk-java requires an owner of opensearch-project enable it.  Repos which choose to use it can also be enabled; formally requesting this for opensearch-sdk-java.
The maintainers of the main Opensearch project may wish to consider it as well, as a replacement for dependabot.
What alternatives have you considered?
Dependabot
Do you have any additional context?
Some quick links to my own repo demonstrating some of the benefits outlined above

Bump PRs have a header with badges displaying the quality of the dependencies.  See an example here.  What the age of the version is, what percentage of Renovate users have upgraded, what percentage of them have passing tests.  This is invaluable for evaluating major version bumps and adoption/quality.
You can group/batch version bumps together. I have done this to batch my build plugins (to get a single PR instead of 3 for ones that release together, for example) to reduce the PR noise.  Here's an example batch PR
It creates a "Dashboard" issue that shows you any pending bumps or ones you've intentionally suppressed.  See example here.
It has the ability to auto-merge its own PRs, which I've enabled for minor and patch versions of build plugins.  We probably don't want that feature here, but it's available

We operate WhiteSource already, @CEHENKLE @davelago isn't that the same thing? Or @hyandell can we just enable the above for the org?

We operate WhiteSource already

Yes, we use that company's (renamed Mend) security check in our CI workflow.
This would add another feature similar to the usage of dependabot.

can we just enable the above for the org?

Enabling it org-wide will create a PR in each Repo (adding the config file) that the maintainers could choose to merge (or not to merge, that is the question).  It can be run side-by-side with dependabot for evaluation (would create duplicate PRs).

I just went through a dialog sequence that looks like it sent a request to admins for approval.  Just following up here to confirm that it was me asking for that, in case you get suspicious :)

Helpful link for an "admin": https://github.com/marketplace/renovate
Scroll to bottom and click "Install it for free"

Quick update: I've submitted an internal ticket for this, and switched the recommendation to "Forking Renovate" which does not create branches in the repo (requiring write access) but does the traditional fork-and-PR approach that any unprivileged contributor would do.

@dbwiddis Any updates here?

This was approved and there's an open PR on SDK repo to finish installation that I'll handle later this week.

I think we need documentation in .github that describes what the options are for keeping libraries up-to-date, maybe add a security section with "Keep Dependencies up to Date" and dependabot and renovate subsections  in https://github.com/opensearch-project/.github/blob/main/RESPONSIBILITIES.md?

FYI: the recent org-wide installation of Mend includes renovate, which everyone can now enable with a few lines in their .whitesource file.


SPI

Hi i'm trying to SPI interface through BBBIO.
after iolib_init(),
i set
BBBIO_McSPI_channel_ctrl
and used function Enable - McSPI_work - Disable.
But it errored
BBBIO_McSPI_CLK_set: No effect pin mux Detected of SPI-0 ,Please use EP_STATUS toolkit to check Pin mux mode
BBBIO_McSPI_work: McSPI 0 CM_PER Clock Gating!
BBBIO_McSPI_CLK_set: No effect pin mux Detected of SPI-0 ,Please use EP_STATUS toolkit to check Pin mux mode
so i use EP_STATUS toolkit and pin mux mode is not correct for use SPI interface
any idea or function in BBBIO to change pin mux mode? or i misused that?

Did you load the spi overlay?

sorry i didn't. but i got another problem when i try to load BBBIO-SPI1 to slots.
i got error message
[bash: echo: write error: File exists]
i'm newbie for linux, sorry :-)
and OS on BBB is BeagleBoard.org BeagleBone Debian Image 2014-04-23.
what should i do?
and what is 'bad file descripter' error?

Hi,
These error shows about the pinmux status error.
There are some illustration in "overlay" directory to slove this problem (for kernel 3.8 ... 3.15 or newer no avail).
to load SPI overlay : echo BBBIO-SPI1 >> /sys/devices/bone_capemgr.*/slots

The "File exists" message is prompted, if you load one overlay twice or more.
You could check the pinmux status by EP_STATUS after overlay loaded, or check the slots by cat command .

oh i solved that
i just didn't disable HDMI pin overlay
thank you


Added unit_of_measurement to Currencylayer

Description:
Added unit_of_measurement so that the graphs appear properly.
If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

Any chance this can be included in 0.58? I will understand if we have already finalized the release branch :)


docs: fix up broken self-referential links

Change-type: patch
Signed-off-by: Matthew McGinn<EMAIL_ADDRESS>

@thgreasi can you merge this for me as admin? it seems builds generally are broken and i want to avoid repeatedly slamming the API with tests if possible


[Feature] AST to markdown

Do you think it would be possible to produce back a markdown from AST ? (keeping spacing too, like spaces and line breaks) 🙂

The AST does not have the spaces and line breaks information, so it is impossible to produce a Markdown string only from AST.
But you can use the position information of each AST Text node to find out the spaces and line breaks on the original Markdown string.

Here is an example of reversing a AST to Markdown string.
https://github.com/chenzhiguang/dart_markdown/blob/master/lib/src/reverse_renderer.dart
If you are wring a Markdown editor, you can use the same idea. Just leave the whitespaces as what they are and render only the "token" elements(markers and text nodes)


Add Bitcoin Core 23.0

Added Dockerfiles for 23.0 that are nearly the same as 22.0. The main difference was updating the gpg keys, and removing one problematic sig from SHA256SUMS.asc (using sed) for which I could not find a usable public key from any keyservers:
C388F6961FB972A95678E327F62711DBDCA8AE56
<EMAIL_ADDRESS>
It was found on keys.openpgp.org, however the identity was stripped, so it wasn't easily usable. I'm not sure if this is likely to eventually propagate to other keyservers, and/or the sig removed from SHA256SUMS.asc if it causes problems for many others.
A more robust solution for verifying sigs could be the updated contrib/verifybinaries/verify.py from bitcoin/bitcoin/pull/23020. Let me know if you prefer I add that file here (in 23/verify.py), or I can update it in a follow-up PR (soon or after it's merged).
Resolves #127

Thank you so much @thinkmassive! Regarding the key issue, it's being tracked on https://github.com/bitcoin/bitcoin/issues/25022. I've included the asc file manually for now as workaround.
Merged in https://github.com/ruimarinho/docker-bitcoin-core/commit/ba147b689b9a78c60cf7d9fd5b20d8dfd2407e30.


chore(oms): rename oms definition file

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff          @@
##           master    #4   +/-   ##
====================================
  Coverage      70%   70%
====================================
  Files           1     1
  Lines          20    20
====================================
  Hits           14    14
  Misses          4     4
  Partials        2     2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ddbcf1...53caff0. Read the comment docs.


Debugger not stopping on breakpoints

Running "Debug" (Ctrl+F5) on a file does not stop on breakpoints anymore, but simply runs through them.
I first noticed it after upgrading spyder in my normal work environment from 5.0.1 to 5.0.3. However, the same thing happens with a clean spyder install in a separate conda environment, even if I revert to .1 or .2.
Python 3.8.10 64-bit | Qt 5.12.9 | PyQt5 5.12.3 | Windows 10

@matheger, thanks for reporting. Please post your full configuration (conda list or pip list) and a an animated git that displays your problem (you generate it with the Licecap program).

Just using a random assignment to demonstrate. Same thing happened anywhere in actual production code.

conda list:

@matheger, thanks for the gif. This problem was introduced by IPython 7.24.0, released last Friday. I already submitted a couple of PRs there, so hopefully this issue will be fixed soon.
In the meantime, please downgrade to version 7.23.1.

I'm still having the debugger bug with spyder 5.0.4 and kernel 2.0.4...
So I still need to downgrade IPython ?


KAFKA-9781: Allow to specify a time zone when converting a timestamp to string

This implements the proposal from [KAFKA-9781].
TimeZone matters when converting a date to a string (and vice versa).
Committer Checklist (excluded from commit message)

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[x] Verify documentation (including upgrade notes)

Could someone informed tell me what is the reason of the build failure? Thanks!


[Text Selection] TextSelectionDelegate should not expose direct access to TextEditingController's TextEditingValue

Instead, it should operate on the text/selection from the previous frame as it is what the user sees.
Things that may prevent this from happening:

Currently in the TextSelectionControls implementation we sometimes do a side-effect and try to observe it immediately: For instance, in response to certain gestures we first select a word and the text selection menu should show up with the "cut" and "copy" options.

I agree, RenderEditable does not need to know the raw TextEditingValue, especially since this value is changed by both the IME as well as various framework entities. It makes more sense to consolidate it in editable text where other similar operations are made.


Remove global Server* server, capture by reference

It seems to be a hack to allow the lambda to use the server, not sure why you'd want that.
If you want to learn more about lambdas, check out this link: http://shaharmike.com/cpp/lambdas-and-functions/

I might have fooled you by including functional, but the callbacks are actually not closures, but "raw" C function pointers. I will change them to std::function sometime soon.


Automated cherry pick of #8780: fix: mcclient panic when keystone init empty service catalog

Cherry pick of #8780 on release/3.5.
#8780: fix: mcclient panic when keystone init empty service catalog

Codecov Report

Merging #8781 (1b070f1) into release/3.5 (e3fe6c4) will increase coverage by 11.96%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release/3.5    #8781       +/-   ##
================================================
+ Coverage         6.03%   17.99%   +11.96%
================================================
  Files              795       84      -711
  Lines           124282     8851   -115431
================================================
- Hits              7503     1593     -5910
+ Misses          116114     7089   -109025
+ Partials           665      169      -496

Flag
Coverage Δ

aFlag
17.99% <0.00%> (+11.96%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/misc.go
0.00% <0.00%> (ø)

pkg/keystone/driver/cas/cas.go
11.11% <0.00%> (+0.52%)
:arrow_up:

pkg/keystone/models/idp_remote_ids.go

pkg/compute/models/guesttemplate_resource.go

pkg/monitor/models/metric.go

pkg/cloudcommon/policy/policy.go

pkg/apis/share.go

pkg/util/samlutils/instance.go

pkg/compute/models/secgrouprules.go

... and 619 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f721d3...1b070f1. Read the comment docs.


fix(errors) : handled potential errors in the request view

Changes made

Changed the setState in number button to int.parse() to handle decimal values.
Changed the copy invoice button
Handled the error when we try to generate invoice with 0 msats.
Increased the size of QR.
Added the home button in bottom sheet.
Some minor changes in the number Pad.

Mh what is the status of this? I should review it?

This is quite old. Most of the functions are already implemented. We can close it


Missing target schemas config in dbt_package.yml

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the issue
We have installed the dbt package for github but when we run the models it does not create a target schemas. So comparing the code with Jira package.
In Jira package dbt_package.yml file config
models:
  jira:
    +materialized: table
    +schema: jira
    intermediate:
      +materialized: ephemeral
      +schema: int_jira

In Github package dbt_package.yml file config
models:
  github:
    materialized: table
    intermediate:
      materialized: ephemeral

Relevant error log or model output
NA

Expected behavior
Should be creating int tables and model tables in the *_int_github and *_github location.
dbt Project configurations
NA
Package versions

package: fivetran/github
version: [">=0.7.0", "<0.8.0"]

What database are you using dbt with?
snowflake
dbt Version
1.3
Additional Context
No response
Are you willing to open a PR to help address this issue?

[X] Yes.
[ ] Yes, but I will need assistance and will schedule time during our office hours for guidance
[ ] No.

HI @rajan-lw thanks for raising this and opening the PRs to address the update!
I agree with you that we should update the packages to build the models in the same format as our other packages by default. However, I did want to note that you can also define this in your root dbt_project.yml to override the package targets. See the section in our README for a description on how this can be done.
With that being said, we will likely accept your PRs and review to work to get the updates rolled out into the latest releases. One thing to note is that changing the target schema by default will result in breaking changes (v0.8.0 for dbt_github and v0.8.0 for dbt_github_source). As such, we will likely hold off on merging these until we have other breaking changes to integrate into the next breaking release. I will still review, but wanted to keep you updated on the status.
Thanks again!

Hi @rajan-lw to update you, I will be adding in your target schema PRs in the next week or so. I will merge your PRs into my branches and then make some additional changes related to other issues. I'll post back here when it is released!


APD-954: Publish to NPM

Another NPM publish attempt, this time using the plugin from https://gitlab.com/lt.petuska/npm-publish
Replaces PR #30
This plugin adds the tasks assembleKoapNpmPublication and publishKoapNpmPublicationToGithub
To Do

[ ] Remove npm.publish.dry=true
[x] Remove private=true

@davidtaylor-juul is this working w/ the Gradle plugin now?

@davidtaylor-juul is this working w/ the Gradle plugin now?

Yes, this plugin had a bunch up updates and some new releases since I last tried it (in the last couple of days) and it's working now.

Updated with v1.0.0 of the plugin which fixes the dependency packaging and allows removal of the webpack step.

@davidtaylor-juul just fyi, npm-publish 1.0.1 has been released.


Update dogfood TaskRuns to use generate name

Expected Behavior
Folks releasing Tekton pipelines via https://github.com/tektoncd/pipeline/tree/master/tekton#release-pipeline should be able to run the Runs as-is.
This should apply to all of the -run.yaml TaskRuns in the tekton dir.
Actual Behavior
Folks running these TaskRuns need to make sure to clean up old Runs before/after executing, or the Runs will silently do nothing since they have already completed.
Additional Info
#685 talks about using generateName instead of a hardcoded name which is probably the way to go here!
I would have just made this change while creating the 0.5 release, however I forgot about it and kicked off the TaskRun before I remembered! I'd like whoever does this to verify it actually works before committing it.

Bahaha my run just failed, I can actually solve this myself XD

Nevermind, I won't do this right now after all, there's an additional complication as @zxDiscovery mentioned at https://github.com/tektoncd/pipeline/issues/685#issuecomment-477846453 we have to start using kubectl create instead of kubectl apply; since the -run.yaml files also contain the PipelineResources, calling create on the yaml file as-is leads to failures creating these PipelineResources since they already exist (looking forward to maybe being able to embed PipelineResources via #544 😜 😇 )

This isn't required now that we're using tkn and I'm proposing to remove the Runs in #1274


fix(select):change calculateOverlayOffsetY to address offset for small lists

Fixes #9751
Adds to the _calculateOverlayOffsetY function of select.ts to disable the offset for lists when an option is already selecte
Current implementation determines if the new functionality is enabled based on a new property disableOffset and if it is set to "true". Criteria can be changed if needed.
Example of usage:
<mat-select multiple [(ngModel)]="currentPokemon"
          [required]="pokemonRequired" [disabled]="pokemonDisabled" #pokemonControl="ngModel" disableOffset="true">
          <mat-option *ngFor="let creature of pokemon" [value]="creature.value">
            {{ creature.viewValue }}
          </mat-option>
        </mat-select>

list with offset:

list without offset:

I know the travis check is failing (screenshots below), but the errors seems to indicated a lost connection/time out and I'm unsure if this has to do with the code I'm introducing. Any help with the error messages would be much appreciated, thanks!


fix-fix-1971

Turns out that when the EBI submission fails, we populate the ebi_experiment_accessions with Nones, which is the expected behavior.

Is it possible to add a test?

Not sure, suggestions?

Coverage decreased (-0.03%) to 91.372% when pulling 04b40be9286a72fdf4b4e0dabd15fec7b9ae79d4 on antgonza:fix-fix-1971 into b5c82d9e50511af8bd91cff9445b7c2722cc825a on biocore:master.

Coverage decreased (-0.03%) to 91.372% when pulling ba853f3290eec91c9ff6e6e91d6a7b454ccbd492 on antgonza:fix-fix-1971 into b5c82d9e50511af8bd91cff9445b7c2722cc825a on biocore:master.

@antgonza I think the only way to test this will be to emulate a failed EBI submission adding Nones in the DB as ebi_experiment_accession numbers for one artifact. Do you think that it can be done?

@josenavas, @ElDeveloper, can you guys check why this is failing ... can't find the reason! Thanks.

Can't quite tell what is it that's leading to the mismatch in statuses. Could it be something to do with "reseting the database" or not resetting it? (just guessing).

Thought about that and pull the latests version to check locally and it works fine. To test, I'm changing the order of the asserts in those tests ...

@antgonza I think the errors here are related with the test that you added. Remember that now the tests are not independent unless you write them in that way. Probably your test is altering the data that those other tests are accessing.

@josenavas the issue is that I originally only modified qiita_pet/handlers/api_proxy/tests/test_studies.py and the errors are in qiita_ware/test/test_dispatchable.py (I modified test_dispatchable.py later to see if we could get more insight into the problem) so either the DB reset is not working in test_studies.py or I'm missing something, not sure ... any ideas?

Coverage decreased (-0.005%) to 91.424% when pulling 09d23db234c8afa8859b86bf03c33165a0efd25e on antgonza:fix-fix-1971 into d54f5336912be04ccede723758cfd00afe93b7b3 on biocore:master.


IE source/destination interface

@RoadRunnr
Sorry it is bit theoretical question.
According to TS 29.244 R 16.05, and section 8.2.24 & 8.2.2,
The "Access" and "Core" values denote an uplink and downlink traffic direction respectively.
i.e. Core represents way towards PDN if I understood correctly.
Then in upg implementation why we use SGi-LAN as way to PDN ?

I haven't found an explicit definition for Core and Access, but TS 23.217, Table 5.2.2-1 gives a clear picture of what is meant.
Traffic in core direction applies only to GTP traffic going towards a UPF, the traffic arrives at the UPF from access (i.e. from the RAN).
Traffic in access direction means GTP traffic from an UPF towards the RAN.
So CORE would be used when describing the GTP path towards the PDN, while SGi/N6 would mean the plain IP path towards PDN.
Also the term PDN and SGi/N6 actually mean the thing (actually SGi being the reference point on the PDN where the UPF attaches to it).
There is also TS 29.244, claus 5.2.1A.2A, that describes how to to apply SDF filter:

when the Source Interface is CP-function or SGi-LAN, the UP function shall use the Flow Description as is.

@RoadRunnr
I have written nrf client code for UPF which will basically expose UPF profile to NRF then SMF (who is subscribed to NRF) will then sends association requests to UPF.
So as VPP-UPF additionally uses nwi, it should be added in UPF profile while registering to NRF.
And it can be done by using InterfaceUpfInfoItem (we can add UPInterfaceType and networkInstance) TS 29.510, section <IP_ADDRESS>.24
Now problem is <IP_ADDRESS>.9 Enumeration: UPInterfaceType does not contains interface N4, so I am bit unclear how nwi for N4 can be added in UPF profile.
I hope it is not off the topic and let me know your suggestion.

From the specifications there is clearly no need to add the N4 interface or the N4 NWI to the profile.
The requirement to declare a NWI for the management GTP tunnel across N4 is clearly something that would be solvable on the VPP-UPG side. The PFCP API should know on which NWI it is currently talking and should use that NWI for the N4 GTP rules as well.
You can open a feature request to fix that, but I can't promise that it will be addressed soon.
As long as that is not solved in VPP-UPG, I would suggest adding a N4 to the enumeration (in case your NRF permits that).


[VL] Gluten-it: Add option --scan-partitions

Add options --scan-partitions and remove --min-scan-partitions which was not working for some time.

What's the impact to Gluten usage?

What's the impact to Gluten usage?

No impact. It just fixes a broken functionality that was not used by Gluten CI.

@zhztheplayer, uniffle test failed. Is the failure relevant to this pr?
https://github.com/apache/incubator-gluten/actions/runs/9360339717/job/25767147453

@zhztheplayer, uniffle test failed. Is the failure related to this pr? https://github.com/apache/incubator-gluten/actions/runs/9360339717/job/25767147453

It appears to be my mistake missing Uniffle's CI result when merging this. Thank you for helping figure out.
https://github.com/apache/incubator-gluten/pull/5986


bot breaking up words with single quotation marks in them

Trying to generate sentences with !g and words such as "I'm", "haven't", "can't" etc. doesn't work, I believe they are saved properly in the database and the bot uses them normally when it picks them itself, but it breaks if you try to put them in a !g command.
Typing "!g i've" makes the bot say "I haven't learned what to do with "i 've" yet."
Typing "!g can't" makes it say "I haven't learned what to do with "ca n't" yet."
It does have data for the actual words in the database but it looks like something goes wrong with splitting the words and putting them back together when generating.

This should be fixed now in the latest release. Feel free to upgrade. Your old database won't immediately update, but new entries should be correct now.

I've opened up an issue on NLTK for the tokenizing issue I mentioned: https://github.com/nltk/nltk/issues/3069.


[Bug] hero[n]_Number in settings.ini is buggy

You can't use a number greater than 6 in the section below :
[Heroes]
hero1_Number = 1
hero2_Number= 2
hero3_Number = 3
hero4_Number = auto
hero5_Number = auto
hero6_Number = -
The bot crashes with an error "out of range"

fixed here : https://github.com/Efemache/Mercenaries-Farm-bot


publish test results

What this PR changes/adds
Adds a step on the Test Code workflow that will publish and show test results on github action user interface in this way:

Why it does that
It will be more easy to understand which test failed and why instead of having to go through all the gradle output
Further notes

Linked Issue(s)
Closes #849
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[x] documented public classes/methods?
[x] added/updated relevant documentation?
[x] added relevant details to the changelog? (skip with label no-changelog)
[ ] linked GitHub project? (see the section on the right-hand side -->)

Codecov Report

Merging #850 (ed156b8) into main (43480d9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #850   +/-   ##
=========================================
  Coverage     59.95%   59.95%
  Complexity     2236     2236
=========================================
  Files           600      600
  Lines         12992    12992
  Branches        907      907
=========================================
  Hits           7790     7790
  Misses         4777     4777
  Partials        425      425

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43480d9...ed156b8. Read the comment docs.


Remove the beta warning modal when opening an e2e room

@manuroe commented on Tue Feb 12 2019
the fist time.

We forgot the modal when enabling e2e in a room.


Find a way to manage size for pictures

Currently the documentation say to run a commande for each sources.
We could make the script return a sizes list to each sources of a picture element with media query detected when runing resize by puppeteer.

I guess the best would be to find if the <img> parent node is a <picture> and then look at its <source>s and their media attributes.
Really not easy, but there might be some Node lib helping.


Back-End: Create Support Requests

Create services, controller and model

Created backend for Support Requests.


Task2 to task15

@MaheshT28
Task -2
Code verified. provide a annotations and change default activity names
Task -3
Code verified. provide a annotations and change default activity names
Task -4
Code verified. provide a annotations and change default activity names
Task -5
Code verified. provide a annotations and change default activity names
Task -6
Code verified. provide a annotations and change default activity names
Task -7
Code verified. provide a annotations and change default activity names
note:
Provide annotations means the process done with code explain in step vice description and change a activity names with use of activity in this process.

@MaheshT28
Task -8
Code verified. provide a annotations and change default activity names
Task -9
Code verified. provide a annotations and change default activity names
Task -10
Code verified. provide a annotations and change default activity names
Task -11
Code verified. provide a annotations and change default activity names
Task -12
Code verified. provide a annotations and change default activity names
Task -13
Code verified. invalid output
Task -14
Code verified. provide a annotations and change default activity names
Task -15
Code verified.
Task -16
Code verified.
Task -17
Code verified. invalid output


fix: update CI/CD process to enable auto-release workflow

Description

add new hook to pre-commit to fix eof lines
add new release.yml workflow. this workflow will automatically:

create and push new tag for next semver based on conventional-commits
create GitHub release with notes
update Changelog with release notes
this workflow will also automatically notify PRs that are included in the release, mimicking the manual behavior but now its automated https://github.com/clowdhaus/terraform-aws-rds/pull/1#issuecomment-952097291

remove old chglog configs and Makefile

Motivation and Context

automate release process in a standardized manner
standardize new CI workflow (copying from RDS)

Breaking Changes

No

How Has This Been Tested?

[x] https://github.com/terraform-aws-modules/terraform-aws-rds/pull/361

This PR is included in version 3.2.1 :tada:


Hydrate (capital H) not exported from @tanstack/react-query 5.0.0-alpha.91

Describe the bug
The title says it all. I'm running the 5.0.0-alpha.91 of @tanstack/react-query, and there's no Hydrate exported. It's not just the typings, too - I checked and it really is undefined at runtime.
I'm assuming / hoping we can still use useQuery in conjunction with <Hydrate going forward.
Or is useSuspenseQuery intended to replace <Hydrate altogether? I'm seeing extremely weird behavior when that hook is used not within a <Suspense tag, so I assumed useSuspenseQuery was only intended to be used with streaming / <Suspense /> (but I can write up a separate ticket if that's not the case)
Your minimal, reproducible example
n/a
Steps to reproduce
Import Hydrate from @tanstack/react-query v 5.0.0-alpha.91 and see that it's not there
Expected behavior
Should be there
How often does this bug happen?
Every time
Screenshots or Videos
n/a
Platform
n/a
Tanstack Query adapter
react-query
TanStack Query version
5.0.0-alpha.91
TypeScript version
n/a
Additional context
n/a

It has been renamed to HydrationBoundary: https://tanstack.com/query/v5/docs/react/guides/migrating-to-v5#hydrate-has-been-renamed-to-hydrationboundary-and-the-usehydrate-hook-has-been-removed

@TkDodo FYI this needs to be updated in the docs. I'd do it myself but I don't know enough about the specifics of how hydrate works or the latest changes to it.

You are linking to the v4 docs. The v5 docs have been changed:
https://tanstack.com/query/v5/docs/react/reference/hydration


Filter by Ongoing Requests in Live View

Description
It would be very useful to filter to ongoing requests only in the live view. I often times want to see the logs corresponding with actions that I'm taking in my client - especially long-lived operations - and being able to filter to live requests would help me identify the spans corresponding with the actions I'm taking in real time.

Try kind = 'pending_span'.
cc @petyosi who I think would be interested in the existence of this use case.

Excellent, thanks!
The next thing that would be great would be to filter to "top level" spans  - when I run that query I see all sub-spans unfolded by default, but what I would love to do is
kind = 'pending_span' and span_level = 0 or something

Right-click on your profile pic and turn off "Expand to display query-matching spans", then refresh the page.
The way to identify those spans in SQL is parent_span_id is null, but for technical reasons your experience will probably be smoother if you don't also include that in your filter in the live view.


feat(ca): implement PKI and TLS

Overall work for #6
Implemented initial tasks to create the CA signing key and CSR for the CA cert
WIP #7
Closed #6
Closed #7

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Truncates text regions even more

TextRegion |> break up <p> tags |> break up <br> tags |> truncate to 7500 characters.
Wondering about the 7500 + 10 code?  It's to remove the very last </p>, if it's there (and maybe newlines - this is all a bit hand-wavy).

Needs specs on HTML -> [TextRegion] parsing

@steam Specs!


new Archive model

This PR does two main things:

Introduces an Archive class that, at the moment, is just a 1-to-1 model attached to the Issue class. The presence of an Archive instance for an Issue indicates that issue instance is an archive.

Adds a step to the create_archive command that creates a new Archive instance for the newly-created Issue
Changes views and hooks to now determine if a Version is "archived" based on the existence of an Archive instance for an article's Issues

Updates field definitions for the Version class

Removes unused boolean fields for changed author & is_archived, and removes a "date updated" field. Replaces these with class methods since they are all computable from existing DB fields.
Changes foreign key on_delete methods for Versions to ensure DB consistency. No application code allows you to delete articles right now, but it is currently possible to delete them from the admin interface, and this causes unexpected behavior with the archive plugin if Article relationships are merely set to None when an article is removed.

If an article is deleted, it's associated Version will also be removed.
If you attempt to remove an article that serves as an immediate parent article for a version, this raises a PROTECT error
If you attempt to remove an article that serves as a base article for any version, this raises a PROTECT error

Some questions:

In order for the article_version_list.html template to know if an article has been archived, I pass the list of archived versions and have the template do the comparison. This feels like it puts a bit too much logic into the template, but maybe that's unavoidable? What do you think?
This doesn't yet build any hook to let you edit an issue to turn it into an archive / remove it's archive status. (although maybe you shouldn't be able to manually pick and choose what articles get listed in an archive edition, as that seems to miss the point of being a snapshot of the whole journal at a state in time?)
For ETHOS, if Chris wants a display of normal, non-archive issues, we'd need to build that out in the templates cause they aren't anywhere now. That's sort of a new feature not in the original spec.
Might impact the way you implement the archive-friendly search, lmk how you'd like to coordinate that.

In order for the article_version_list.html template to know if an article has been archived, I pass the list of archived versions and have the template do the comparison. This feels like it puts a bit too much logic into the template, but maybe that's unavoidable? What do you think?

I think that the only other solution other than doing that logic in the template is to add a field to Version to keep track of any issue that it's added to through the create_archive command.
if is_latest:
	new_issue.articles.add(article)
	v = Version.objects.get(article=article)
	v.archived_issues.add(new_issue)

and then when returning in the article_version_list {% for issue in version.archived_issues.all %} . Do you see any problems with this? Is this against DRY principles?

This doesn't yet build any hook to let you edit an issue to turn it into an archive / remove it's archive status. (although maybe you shouldn't be able to manually pick and choose what articles get listed in an archive edition, as that seems to miss the point of being a snapshot of the whole journal at a state in time?)

Yeah, that's a good question... It could let people use this archive plugin in different ways. We are coming in to this with specific context for ETHOS where it is a snapshot of a whole thing. But others may think of an archive differently. I don't think we need to add this now.

For ETHOS, if Chris wants a display of normal, non-archive issues, we'd need to build that out in the templates cause they aren't anywhere now. That's sort of a new feature not in the original spec. Might impact the way you implement the archive-friendly search, lmk how you'd like to coordinate that.

kk. will have to talk to Chris about that because it's likely a design thing. Should they show up on the TOC page? They could certainly still show up in "Featured Issue" or "Current Issue" as a homepage element.

I think that the only other solution other than doing that logic in the template is to add a field to Version to keep track of any issue that it's added to through the create_archive command.

😂 no no no, this PR got RID of that is_archived field! Just say no to database inconsistency 🗡  Really what I was trying to do was use Django's annotate() to check whether an article's issues had any Archives and compute that boolean field on the fly. I was having difficulty getting it work though, so I put in this slightly kludgier bit.

kk. will have to talk to Chris about that because it's likely a design thing. Should they show up on the TOC page? They could certainly still show up in "Featured Issue" or "Current Issue" as a homepage element.

Good ? but also a feature request, so I'd log it as new work to be done. Chris has never specified what that'd look like, if it'd be a separate page from the archives, what function a non-archive issue would fill with ETHOS, or any of that.

@hachacha success! Figured out how the annotate function works - apparently you define a subquery and can then pass it to the real query and check whether any Archives come up for a given article version


Update the code for tf 2.5

DRAFT PR FOR TESTING

Note this is a draft for https://github.com/RasaHQ/rasa/issues/8700. Known remaining tasks in order to actually update code for tf 2.5 are:

[ ] see TODOs marked with 2.5
[ ] investigate failed memory leak tests
[ ] remove keras-nightly from lockfile and figure out appropriate substitute

@koernerfelicia It sounds like we were able to verify the bug was fixed?

@TyDunn not much has changed from my update here: https://github.com/RasaHQ/rasa/issues/8700#issuecomment-863405940
I guess I can say it is fixed in the sense that the code no longer hangs, but I'm not sure if it is a complete fix, since there seem to be some performance issues which look like they're related to the original bug, simply because they only occur in the same scenario in which the original bug occurred (anytime we are using our custom CRF layer).
How would you suggest I handle this? I'm thinking I'll update the original issue with the TODO's I wrote above, and add a note about this flakiness?

How would you suggest I handle this? I'm thinking I'll update the original issue with the TODO's I wrote above, and add a note about this flakiness?

@koernerfelicia  That seems reasonable to me. And then throw it in the Research inbox?

@TyDunn, done! I updated the issue description to include the list of todos and added a note about the somewhat fishy behaviour around our custom CRF layer.

/modeltest
include:
 - dataset: ["all"]
   config: ["all"]


[WIP do not merge] MPD: try to support password

This is a crude and untested implementation, but am I on the right track?
Tries to deal with #492

I don't know so much mpd, but seems good, anyone can test?

Fine by me!


Revert "fix: remove windows custom libstdc++ (#42)"

What ❔
This reverts commit fb986a43c44e2ae056484504b83cbae3a3aa71fa.

Why ❔

We were copying GNU libstdc++ static lib from msys64/mingw to the LLVM folder with static libs.
llvm-sys takes this libstdc++ just because it's in this directory and links with it
additionally, llvm-sys build.rs adds dynamic libstdc++ to be linked on Windows
+crt-static Rust flag is not recognizable by build.rs on Windows

Although it can cause some issues with tester (due to dynamic and static linkage mix), there is no beautiful and other way for now to link properly. It's better to revert now to unblock testing and releases in zksolc/zkvyper.
Related issue: https://github.com/rust-lang/rust/issues/24345

Checklist

[x] PR title corresponds to the body of PR.
[x] Documentation comments have been added / updated.
[x] Code has been formatted via cargo fmt and checked with cargo clippy.

Why our CI had not catch this change?

I had to create a branch with this builder to test, and it fails only when running unit tests for zksolc:
https://github.com/matter-labs/era-compiler-solidity/actions/runs/10920217654/job/30309606987
This is happening because Command starts zksolc in cmd and not msys, and cmd is lacking dynamic libstdc++6.dll.
This is a complex issue to catch, because LLVM builds and zksolc/zkvyper builds will work with no issues, even tester will run and correctly execute everything. But our final FE Windows executables will be attached to msys gnu libstdc++.a and this can cause issues for the users.


Remove any trace of graphviz. Make plotting output to stdout.

Ticket
No reference ticket.
Description
Instead of depending on graphviz, export computational & topology plots to text formats, which can later be piped into graphviz or other interactive tools for plotting.
New command outputs the graph in a .dot format:
ob info computational -b /tests/data/Benchmark_001.yaml

One can then pipe the output to a plotting command (i.e. graphviz) to render a png, or import it into an interactive browser.
ob info computational -b /tests/data/Benchmark_001.yaml | dot -Tpng -Gdpi=300 > Benchmark_001.png

The images would look similar to the ones generated using pygraphviz, but without the hard depdendency on graphviz:

Checklist:

[x] My code follows the code style of this project.
[x] My CLI method respects the signature defined in the task.
[x] I have documented the CLI method accordingly.
[x] I have added tests to cover my changes.
[ ] I have added a CHANGELOG entry.

Remarks for the reviewer:

Thanks, looks good. Oddly enough I cannot install it locally with micromamba (pip) in barbara, trying to debug before approving.
Solver.
$ pip show conda-libmamba-solver
Name: conda-libmamba-solver
Version: 24.7.0
Summary: The fast mamba solver, now in conda
Home-page: https://github.com/conda/conda-libmamba-solver
Author:
Author-email: "Anaconda, Inc."<EMAIL_ADDRESS>License: BSD 3-Clause License

Copyright (c) 2022, Anaconda, Inc.

[skip]

Commit.
$ git log | head -5
commit e5a84dfc8e5ba29e24716239f958d57e1e939e1b
Author: Daniel Incicau<EMAIL_ADDRESS>Date:   Sat Oct 12 11:26:41 2024 +0200

    Remove any trace of graphviz. Make plotting output to stdout.

Solver / install trace.
$ micromamba install -f test-environment.yml

[skip]

Using cached iniconfig-2.0.0-py3-none-any.whl (5.9 kB)
Building wheels for collected packages: omnibenchmark, easybuild-framework, omni-schema
  Building wheel for omnibenchmark (pyproject.toml) ... done
  Created wheel for omnibenchmark: filename=omnibenchmark-0.1.0-py3-none-any.whl size=67773 sha256=85ecedd20be68c2233ea0eacf12053b5bcf5bbb42f77c414b57a4cd95d0b16b3
  Stored in directory: /home/imallona/tmp/pip-ephem-wheel-cache-gur6ofs2/wheels/20/87/3a/1eb643ca36c389f3008ead1a2dd49747b4cb07f648011859a2
  Building wheel for easybuild-framework (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> [47 lines of output]
      /home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/site-packages/setuptools/_distutils/cmd.py:66: SetuptoolsDeprecationWarning: setup.py install is deprecated.
      !!

              ********************************************************************************
              Please avoid running ``setup.py`` directly.
              Instead, use pypa/build, pypa/installer or other
              standards-based tools.

              See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
              ********************************************************************************

      !!
        self.initialize_options()
      Traceback (most recent call last):
        File "/home/imallona/tmp/tmpdt6rsj_d.py", line 1, in <module>
          from distutils.util import byte_compile
        File "/home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/site-packages/_distutils_hack/__init__.py", line 110, in find_spec
          return method()
                 ^^^^^^^^
        File "/home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/site-packages/_distutils_hack/__init__.py", line 117, in spec_for_distutils
          import importlib.abc
        File "/home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/importlib/abc.py", line 18, in <module>
          from .resources import abc as _resources_abc
        File "/home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/importlib/resources/__init__.py", line 3, in <module>
          from ._common import (
        File "/home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/importlib/resources/_common.py", line 2, in <module>
          import pathlib
        File "/home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/pathlib.py", line 8, in <module>
          import fnmatch
        File "/home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/fnmatch.py", line 14, in <module>
          import re
        File "/home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/re/__init__.py", line 124, in <module>
          import enum
        File "/home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/enum.py", line 3, in <module>
          from types import MappingProxyType, DynamicClassAttribute
        File "/home/imallona/tmp/types.py", line 17, in <module>
          from dataclasses import dataclass, field
        File "/home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/dataclasses.py", line 3, in <module>
          import copy
        File "/home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/copy.py", line 52, in <module>
          import weakref
        File "/home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/weakref.py", line 22, in <module>
          from _weakrefset import WeakSet, _IterationGuard
        File "/home/imallona/micromamba/envs/omnibenchmark/lib/python3.12/_weakrefset.py", line 6, in <module>
          from types import GenericAlias
      ImportError: cannot import name 'GenericAlias' from partially initialized module 'types' (most likely due to a circular import) (/home/imallona/tmp/types.py)
      error: command '/home/imallona/micromamba/envs/omnibenchmark/bin/python' failed with exit code 1
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for easybuild-framework
  Running setup.py clean for easybuild-framework
  Building wheel for omni-schema (pyproject.toml) ... done
  Created wheel for omni-schema: filename=omni_schema-0.0.1-py3-none-any.whl size=11983 sha256=132e66ae9783043536090877cd9d39fdba51eef8482e1a1d99b1cfead51061d8
  Stored in directory: /home/imallona/tmp/pip-ephem-wheel-cache-gur6ofs2/wheels/4f/36/11/4bb8bc33aec8cf544bbdfffae8676bff5ffd36714a1529a083
Successfully built omnibenchmark omni-schema
Failed to build easybuild-framework
ERROR: ERROR: Failed to build installable wheels for some pyproject.toml based projects (easybuild-framework)
critical libmamba pip failed to install packages

Question, would it make sense to remove the easyconfig file checks for plotting benchmark layouts? I think it would sense to remove these checks @retogerber @DanInci
(Related but unrelated: those checks might need updating as well, because easyconfigs are stored in the robotspath and not in 'env', easyconfigs and conda env files are not equivalent in this regard.)
$ ob info computational -b ./tests/data/Benchmark_003.yaml
Error: An unexpected error occurred: Software environment path for 'envmodules' does not exist: '/home/imallona/src/omnibenchmark/tests/data/R_4.3.3-gfbf-2023b.eb'.
Software environment path for 'envmodules' does not exist: '/home/imallona/src/omnibenchmark/tests/data/python_vX-gfbf-2023b.eb'.

I agree, no need for those checks. Long term there should be multiple layers of validation depending on how critical an action will be, i.e. running a benchmark is much more critical than making sure the benchmark model compiles.
@imallona Is there a way to expand all possible paths based on an robot path? That could solve our current checks.

I'd try with det_easyconfig_paths as shown here when using the same easybuild configuration we're using via shell calls. Happy to discuss how to make this cleaner/streamlined.

as for how to find the blob you can retrieve these paths from eb --show-config (find below the output with a default configuration, in barbara - linux)
(omnibenchmark) $ eb --show-config
#
# Current EasyBuild configuration
# (C: command line argument, D: default value, E: environment variable, F: configuration file)
#
buildpath      (D) = /home/imallona/.local/easybuild/build
containerpath  (D) = /home/imallona/.local/easybuild/containers
installpath    (D) = /home/imallona/.local/easybuild
repositorypath (D) = /home/imallona/.local/easybuild/ebfiles_repo
robot-paths    (D) = /home/imallona/micromamba/envs/omnibenchmark/easybuild/easyconfigs
sourcepath     (D) = /home/imallona/.local/easybuild/sources

Thanks @DanInci . Unfortunately I don't manage to solve Benchmark_003.yaml's layout using your last commit:
(omnibenchmark) imallona@mlshainan:~/src/omnibenchmark$ pip install . | tail
  Running command git clone --filter=blob:none --quiet https://github.com/omnibenchmark/omni-schema.git /home/imallona/tmp/pip-install-o3bzwae9/omni-schema_1134cf30720a43d48bec6cc09e89cb42
  Building wheel for omnibenchmark (pyproject.toml): finished with status 'done'
  Created wheel for omnibenchmark: filename=omnibenchmark-0.1.0-py3-none-any.whl size=67450 sha256=bc6640a795c508f520f66636fa3d30689af7e9e2c31c882cdde5b0a4805a8c50
  Stored in directory: /home/imallona/tmp/pip-ephem-wheel-cache-69zl9_ps/wheels/20/87/3a/1eb643ca36c389f3008ead1a2dd49747b4cb07f648011859a2
Successfully built omnibenchmark
Installing collected packages: omnibenchmark
  Attempting uninstall: omnibenchmark
    Found existing installation: omnibenchmark 0.1.0
    Uninstalling omnibenchmark-0.1.0:
      Successfully uninstalled omnibenchmark-0.1.0
Successfully installed omnibenchmark-0.1.0

(omnibenchmark) imallona@mlshainan:~/src/omnibenchmark$ git log | head -5
commit 1bd88824b43327cba09e33a627c04d3d56a8612e
Author: Daniel Incicau<EMAIL_ADDRESS>Date:   Fri Oct 25 14:10:04 2024 +0200

    Integrate easyconfig checks in validators

As it raises:
(omnibenchmark) imallona@mlshainan:~/src/omnibenchmark$ ob info computational -b ./tests/data/Benchmark_003.yaml
'One or more files not found: R_4.3.3-gfbf-2023b.eb (search paths: /home/imallona/micromamba/envs/omnibenchmark/easybuild/easyconfigs)'
'One or more files not found: python_vX-gfbf-2023b.eb (search paths: /home/imallona/micromamba/envs/omnibenchmark/easybuild/easyconfigs)'
Error: An unexpected error occurred: Software environment with id 'R' does not define


Default value for 'markdown.previewFrontMatter' setting should be 'show'

VSCode Version: 1.8.1
OS Version: win 10

... because

majority of markdown documents won't have front matter included (personal opinion ?), so this might be the general case.
it should improve performance with markdown rendering as in
vscode/extensions/markdown/src/extension.ts @ getDocumentContentForPreview
the regular expression is not applied then.

thanks.

@goessner Is there any user bad here?
There's not much of a case IMO for rendering frontmatter as markdown (but we allow it as a fallback if users need it) so I think many more people would be opting into hiding the frontmatter than showing it.
Performance of the regexp is also not really a problem in this context. Do you have numbers showing this is causing a problem?

There's not much of a case IMO for rendering frontmatter as markdown (but we allow it as a fallback if >users need it) so I think many more people would be opting into hiding the frontmatter than showing it.

.. sounds reasonable .. switching defaults is always problematic ..

Performance of the regexp is also not really a problem in this context. Do you have numbers showing this >is causing a problem?

.. no I did not do runtime performance measurements .. You say that performance is no problem here, so I will handle it the same way then.
Thanks


cargo-msrv: 0.15.0 -> 0.15.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for cargo-msrv is: "Cargo subcommand "msrv": assists with finding your minimum supported Rust version (MSRV)"
meta.homepage for cargo-msrv is: "https://github.com/foresterre/cargo-msrv"
meta.changelog for cargo-msrv is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/h9vb6xnqnzim8d8ygvv7dhw8d3hczfdi-cargo-msrv-0.15.1/bin/.cargo-msrv-wrapped had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/h9vb6xnqnzim8d8ygvv7dhw8d3hczfdi-cargo-msrv-0.15.1/bin/cargo-msrv had a zero exit code or showed the expected version
0 of 2 passed binary check by having a zero exit code.
0 of 2 passed binary check by having the new version present in output.
found 0.15.1 with grep in /nix/store/h9vb6xnqnzim8d8ygvv7dhw8d3hczfdi-cargo-msrv-0.15.1
found 0.15.1 in filename of file in /nix/store/h9vb6xnqnzim8d8ygvv7dhw8d3hczfdi-cargo-msrv-0.15.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
cargo-msrv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/h9vb6xnqnzim8d8ygvv7dhw8d3hczfdi-cargo-msrv-0.15.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-msrv https://github.com/r-ryantm/nixpkgs/archive/68d158b97eb8c6021437a71bb0eb94b13fd3ce3f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/h9vb6xnqnzim8d8ygvv7dhw8d3hczfdi-cargo-msrv-0.15.1
ls -la /nix/store/h9vb6xnqnzim8d8ygvv7dhw8d3hczfdi-cargo-msrv-0.15.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cargo-msrv

Maintainer pings
cc @otavio for testing.

Result of nixpkgs-review pr 162138 run on x86_64-linux 1

1 package built:

cargo-msrv


feat: support system use []object

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.94%. Comparing base (4784ec9) to head (322b8a4).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   71.16%   71.94%   +0.78%
==========================================
  Files           8        8
  Lines         430      442      +12
==========================================
+ Hits          306      318      +12
  Misses         92       92
  Partials       32       32

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Local mode (--local) doesn't seem to allow using the fidesctl generate commands

Bug Description
I was wanting to use fidesctl to generate a YAML without spinning up the webserver locally, and figured I'd take --local mode for a spin as I hadn't used it recently.
Unfortunately, I think --local doesn't disable the reliance on API like we thought anymore, as I immediately get errors:
$ fidesctl --local generate dataset db foo
Connection failed, webserver is unreachable at URL:
http://localhost/api/v1/health.

Steps to Reproduce
~% mkdir ~/fidesctl-local-test
~% cd fidesctl-local-test
~/fidesctl-local-test% python3 -m venv venv
~/fidesctl-local-test% ./venv/bin/pip install fidesctl
...
~/fidesctl-local-test% ./venv/bin/fidesctl --local generate db foo
No config file found
Using default configuration values.
Connection failed, webserver is unreachable at URL:
http://localhost/api/v1/health.

Expected behavior
I'd like as many of the CLI commands as possible to work without the webserver - but especially commands like generate, scan and similar that are meant to help me author my YAML files 👍
Environment

Version: 1.7.0
OS: macOS-12.4-x86_64-i386-64bit
Python Version: 3.10.5
Docker Version: 20.10.11

~/fidesctl-local-test% ./venv/bin/fidesctl --version
fidesctl, version 1.7.0
~/fidesctl-local-test% ./venv/bin/python --version
Python 3.10.5
~/fidesctl-local-test% ./venv/bin/python -m platform
macOS-12.4-x86_64-i386-64bit
~/fidesctl-local-test% docker --version
Docker version 20.10.11, build dea9396

to tag onto this, when running fidesctl --local -h it should show the only the commands that are available locally, as-is it shows the entire list of commands which doesn't make sense

@ThomasLaPiana --local is a flag so that is why it doesn't only show the local commands with -h. If it was instead setup to work as fidesctl local -h I think it would would as you expect.

@sanders41 we're adding commands programmatically, i found the bug locally and got it working as intended. will push up a fix shortly
fides> fidesctl --local
Usage: fidesctl [OPTIONS] COMMAND [ARGS]...

  The parent group for the Fidesctl CLI.

Options:
  --version               Show the version and exit.
  -f, --config-path TEXT  Path to a configuration file.
                          Use 'fidesctl view-config' to
                          print the config. Not
                          compatible with the 'fidesctl
                          webserver' subcommand.
  --local                 Run in 'local_mode'. This mode
                          doesn't make API calls and can
                          be used without the API
                          server/database.
  -h, --help              Show this message and exit.

Commands:
  evaluate   Compare your System's Privacy...
  init       Initializes a Fidesctl instance,...
  parse      Reads the resource files that are...
  view       View various resources types.
  webserver  Starts the fidesctl API server using...


how does this compare to karabiner-elements

I never really used karabiner-elements, but it is my understanding that the main purpose of karabiner-elements was key remapping and other ways to customize the keyboard / multiple different keyboards?
skhd is developed with one goal in mind, running an arbitrary command(s) when pressing a combination of keys.

Yeah karabiner is less specialised, I (and maybe quite a few others?) happen to have it installed already because it's useful for some other things I need to customise.
I would like to set up chunkwm, I just wonder whether karabiner can be used instead of skhd, or if skhd is many more times more performant or some other reason.

I'm not familiar enough with karabiner to comment on its performance, but if all you want is some way to create keybindings, I think skhd is superior for that purpose.
If you already use karabiner for other purposes you can probably use it for this as well without issues.

Yeah karabiner is less specialised, I (and maybe quite a few others?) happen to have it installed already because it's useful for some other things I need to customise.
I would like to set up chunkwm, I just wonder whether karabiner can be used instead of skhd, or if skhd is many more times more performant or some other reason.

You technically could per the documentation here although I can't say I've tried, I dont see why it wouldn't work

Not to necrobump, but for future lurkers: I am starting to use yabai and love it, naturally I bumped into skhd and wanted to learn about it. If I am not mistaken, there is nothing it can do that karabiner can't. I use karabiner with goku for config, so admittedly it's a mess, but I use it to run arbit scripts with keybinds just fine. If skhd has capabilities that karabiner doesn't I'd love to know, but I can't find any.


MQTT Publish topic as an attribute of the Pub/Sub message

Hi,
Is it possible to capture the topic that the MQTT message came through, and add as an attribute of the resulting GCP Pub/Sub message?

Hi @r-harrison !
What is your use case here? Are you using a wildcard MQTT subscription?

Hi @ferrarimarco :-)
My apologies, I should have included our use case in my original request - yes, we are using a wildcard subscription. Unfortunately the topic name conveys information about the structure of the resulting payload, which makes deserialisation on the other end cumbersome without that extra context.
I've had a look at the code and think that something like this might do the trick (line 85 of MqttToCloudPubSubRoute.java):
 from(routeStart)         .id(mqttToCloudPubSubRouteId)         .process(             exchange -> {               String mqttTopic =                   exchange.getIn().getHeader("CamelMQTTSubscribeTopic", String.class);               exchange.getIn().setHeader("CamelGooglePubsubAttributes", "mqtt_topic=" + mqttTopic);             })         .to(routeDestination);
I haven't written any tests for the above yet but I'm happy to throw up a PR if you are amenable (noting that your non-goals included mapping of MQTT semantics to Pub/Sub).

I'd be happy to review a PR for this! Thanks :)

@r-harrison: I've opened #290 to implement this feature request. Can you kindly check if it's what you're looking for? Thanks!

This is perfect, thanks mate :)


feature: A user-friendly user management page for apollo portal

What's the purpose of this PR
A user-friendly user management page for apollo portal
Which issue(s) this PR fixes:
Fixes #4294
Brief changelog

Modify the backend, add and modify users, and search the contents of the user interface
Modified the front-end management user interface

Follow this checklist to help us incorporate your contribution quickly and easily:

[X] Read the Contributing Guide before making this pull request.
[X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit tests to verify the code.
[ ] Run mvn clean test to make sure this pull request doesn't break anything.
[X] Update the CHANGES log.

Codecov Report

Merging #4464 (a95d300) into master (afad056) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4464      +/-   ##
============================================
- Coverage     53.54%   53.47%   -0.07%
+ Complexity     2688     2686       -2
============================================
  Files           488      488
  Lines         15229    15234       +5
  Branches       1587     1587
============================================
- Hits           8154     8147       -7
- Misses         6515     6528      +13
+ Partials        560      559       -1

Impacted Files
Coverage Δ

...ip/framework/apollo/portal/entity/bo/UserInfo.java
52.17% <0.00%> (-7.83%)
:arrow_down:

...trip/framework/apollo/portal/entity/po/UserPO.java
28.00% <0.00%> (-1.17%)
:arrow_down:

.../spi/springsecurity/SpringSecurityUserService.java
0.00% <0.00%> (ø)

...work/apollo/biz/message/DatabaseMessageSender.java
50.00% <0.00%> (-14.59%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afad056...a95d300. Read the comment docs.

@nobodyiam  please help me review the code.

2. to allow the administrator enable/disable the users without filling the passwords
How about we add enable/disable buttons in the operation

If the enable or disable is put outside and becomes a separate button, the backend needs to write a new interface,like
@PreAuthorize(value = "@permissionValidator.isSuperAdmin()")
@PostMapping("/user/enabled")
  public void changeUserEnabled(@RequestBody UserPO user) {
  }

Because the current interface checks that the password cannot be empty.
@PreAuthorize(value = "@permissionValidator.isSuperAdmin()")
@PostMapping("/users")
public void createOrUpdateUser(@RequestBody UserPO user) {
  if (StringUtils.isContainEmpty(user.getUsername(), user.getPassword())) {
    throw new BadRequestException("Username and password can not be empty.");
  }

  CheckResult pwdCheckRes = passwordChecker.checkWeakPassword(user.getPassword());
  if (!pwdCheckRes.isSuccess()) {
    throw new BadRequestException(pwdCheckRes.getMessage());
  }

  if (userService instanceof SpringSecurityUserService) {
    ((SpringSecurityUserService) userService).createOrUpdate(user);
  } else {
    throw new UnsupportedOperationException("Create or update user operation is unsupported");
  }
}

is it ok to add a new interface？

BTW, I think it's ok to add a new interface to enable/disable users.

@nobodyiam do you have any other suggestions :D

@zcy1010
It looks great now! There is one minor issue though. I think we need to disable the user login name field in the edit user page:

BTW, please also fix the conflict in CHANGES.md.


credentials in cmdArgs are not redacted

Below line logs credentials in cmdArgs but does not redact them.
https://github.com/cloudfoundry/voldriver/blob/master/invoker/invoker.go#L30

Hi Abel,
Are you using the RedactingWriterSink that we use in nfsv3driver?
If so, note that RedactingWriterSink is configurable--you can give it regular expressions to redact things from your logs based on pattern match of either the keys or the values of json that is passed in a lager.Data block.  If you give it nil pattern lists, it will default to filtering any value where the key contains pwd or pass, and it will also look for MD5 keys, SHA values AWS keys, or private SSH keys, but it is totally customizable.
You can find the code that sets up the default values for redaction here: https://github.com/cloudfoundry/lager/blob/b4f07fd10491fae0d6d9a0d07145e9f90935ac50/json_redacter.go#L22
My guess is that you just need to override the pattern list for the key patterns to include whatever key value your secrets have.
HTH,
-Julian

@julian-hj I did use the same code. You can see my code here.
The password in opts is redacted but that in args is not.
Below is my logs:
{"data":{"opts":{"dirMode":"0777","fileMode":"0777","gid":"2000","password":"*REDACTED*","source":"//abelstorage.file.core.windows.net/test","uid":"2000","username":"abelstorage","vers":"3.0"},"session":"3.8900.1.1"},"log_level":1,"message":"smb-driver-server.server.handle-create.with-cancel.create.with-opts","source":"smb-driver-server","timestamp":"1496644498.816172600"}
{"data":{"args":["-t","cifs","//abelstorage.file.core.windows.net/test","/var/vcap/data/volumes/smb/d7633591-a3c3-44e4-96f6-8ee9fcd2e2b4-27c18a0aaf2ade2cd5568d67a428c62f","-o","username=abelstorage,password=MY-REAL-PASSWORD-HERE,file_mode=0777,dir_mode=0777,uid=2000,gid=2000,vers=3.0","--verbose"],"executable":"mount","session":"3.89<IP_ADDRESS>","volume":"d7633591-a3c3-44e4-96f6-8ee9fcd2e2b4-27c18a0aaf2ade2cd5568d67a428c62f"},"log_level":1,"message":"smb-driver-server.server.handle-mount.with-cancel.mount.invoking-command.start","source":"smb-driver-server","timestamp":"1496644498.817555189"}

Yes I see--it is because in this case the "password" string is in a value in the array so the key filter will not find it. Probably you could add "args" to the list of key filters to fix this, or add "pass" to the list of value filters.

Sent from VMware Boxer
On August 10, 2017 at 6:31:50 PM PDT, Chou Hu<EMAIL_ADDRESS>wrote:
@julian-hjhttps://github.com/julian-hj I did use the same code. You can see my code herehttps://github.com/AbelHu/smbdriver/blob/master/cmd/smbdriver/main.go#L252.
The password in opts is redacted but that in args is not.
Below is my logs:
{"data":{"opts":{"dirMode":"0777","fileMode":"0777","gid":"2000","password":"REDACTED","source":"//abelstorage.file.core.windows.net/test","uid":"2000","username":"abelstorage","vers":"3.0"},"session":"3.8900.1.1"},"log_level":1,"message":"smb-driver-server.server.handle-create.with-cancel.create.with-opts","source":"smb-driver-server","timestamp":"1496644498.816172600"}
{"data":{"args":["-t","cifs","//abelstorage.file.core.windows.net/test","/var/vcap/data/volumes/smb/d7633591-a3c3-44e4-96f6-8ee9fcd2e2b4-27c18a0aaf2ade2cd5568d67a428c62f","-o","username=abelstorage,password=MY-REAL-PASSWORD-HERE,file_mode=0777,dir_mode=0777,uid=2000,gid=2000,vers=3.0","--verbose"],"executable":"mount","session":"3.89<IP_ADDRESS>","volume":"d7633591-a3c3-44e4-96f6-8ee9fcd2e2b4-27c18a0aaf2ade2cd5568d67a428c62f"},"log_level":1,"message":"smb-driver-server.server.handle-mount.with-cancel.mount.invoking-command.start","source":"smb-driver-server","timestamp":"1496644498.817555189"}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/cloudfoundry/voldriver/issues/2#issuecomment-321714472, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIF0_KE_mceE34Aqp4W-UN64z6K6PmsYks5sW68CgaJpZM4OzJqS.

If I set any of the key or value as a filter, the default filters will be overwritten. It is not my expected. Could we add a new value filter in json_redacter for such cases? How do you think?
https://github.com/cloudfoundry/lager/blob/94c528f7360490f75431b618078be3c89dcbbe50/json_redacter.go#L22-L27

It was never really the intent that the default values for the redacter would catch all secrets.  We added that redaction capability because we anticipated that people would write drivers and brokers that have different types of sensitive information we could not know about in advance.  So we made the RedactingWriterSink configurable for exactly this kind of circumstance--so that we don't have to modify our code each time someone uses it within a different library.
We might consider removing the args from that logger session altogether, since it's likely to have sensitive things in it, but in the mean time, I think it's a pretty small change in your newLogger function to add "args" to the list of redacted keys:
	sink, err := lager.NewRedactingWriterSink(os.Stdout, lager.DEBUG, []string{"[Pp]wd","[Pp]ass","args"}, nil)

@julian-hj Agree with you. It is better to remove args in logs.  I will try to create RedactingWriterSink with customized filters. Thank you so much.


compatibilidad con 1.16.4 FORGE

por favor hacer que funcione en forge para la 1.16.4

Please submit your issue in English next time. You can use a translator if you want.
We will not be backporting to older versions, especially backports as pointless as a single minor release (.5 -> .4). Just use 1.16.5.


Step 14 of build.sh failed

Got this error running ./build.sh , i have alr tried update pip and python
Step 14/20 : RUN pip install simple-pid pygame networkx==2.2
 ---> Running in 2509aa2c3ba4
Collecting simple-pid
  Downloading https://files.pythonhosted.org/packages/f0/23/fa4e51987a031580f3af54a75eae60aacce593e23669075ae65664511244/simple_pid-1.0.0-py2.py3-none-any.whl
Collecting pygame
  Downloading https://files.pythonhosted.org/packages/d2/11/4212b97ea025aca55e2284e9c7d8cb87cfaddb4e89f5eb613c81017246c1/pygame-2.0.1-cp27-cp27mu-manylinux1_x86_64.whl (11.7MB)
Collecting networkx==2.2
  Downloading https://files.pythonhosted.org/packages/f3/f4/7e20ef40b118478191cec0b58c3192f822cace858c19505c7670961b76b2/networkx-2.2.zip (1.7MB)
Collecting decorator>=4.3.0 (from networkx==2.2)
  Downloading https://files.pythonhosted.org/packages/71/bd/042e63027bea950da4e6f5545eb59b973868da854ab30a18128d3b884104/decorator-5.0.2.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-nLxXse/decorator/setup.py", line 4, in <module>
        exec(open('src/decorator.py').read(), dic)  # extract the __version__
      File "<string>", line 162
        print('Error in generated code:', file=sys.stderr)
                                              ^
    SyntaxError: invalid syntax

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-nLxXse/decorator/
The command '/bin/bash -o pipefail -c pip install simple-pid pygame networkx==2.2' returned a non-zero code: 1

I am also getting the same error, any help from the team would be great

I am also getting the same error, any help from the team would be great

hi I made it work by installing pygame separately and hashtag the dockerfile step 14

@alvinliu97 by step 14, do you mean "RUN pip install simple-pid pygame networkx==2.2"

yes

thanks a lot, I think the issue is solved now


error: Convert 'Serial' from 'Serial_' to 'HardwareSerial&'HardwareSerial &serialPort = Serial

Hi,
I have tired to use the library, but I get the following error when I compile the code

I noticed, you mentioned that this error was solved, so I don't know if there is something wrong from my side.
Thanks in advance

Hi,
The example was outdated, you need to pass the Serial (or Serial1, Serial2, SerialX)  object in the constructor.
I solved the problem in the last commit.
best regards.


Suggestion: scan folder and compare against an archived folder

Hi Elise,
Hope you are well.
I wanted to run a scenario past you and was wondering if this is possible, please?
So we deal with timesheets and daily we do get duplicates. DifPy (during POC was amazing) when testing against a single folder and moving out the duplicates to another folder.
Then my situation changed and was asked if it could search against an archived folder just incase we get backdated timesheets.
So it goes like this:
I have a working folder where the timesheets get dropped into. Images in here will change throughout the day.
Any images dropped into the working will automatically copy into the archived folder where we will store up to a month.
If an image arrives 2 weeks later in the working folder, it would look into the archived folder and say 'hey, you look similar to what is in the archived folder' - and move that image from the working folder into the duplicates folder.
The idea is that the archived folder images is not moved but is used as a 'database' to refer to, which is just sitting there storing images (until we do our monthly housekeeping).
I am not an hardcore Python dev (just in case someone says read the code) but just throwing out an idea if that is possible.
Thanks
Raj

Hi @phpology,
Thanks a lot for the suggestion and for describing your use case! We will keep this idea in mind for a potential feature for difPy, but as of today are not planning to implement this in the near future.
Thanks again,
Elise


Eternal build loop when building with docker

Issue template

Hardware description: Arduino nano rp2040 connect
Installation type:  build with docker
Version or commit hash: Galactic, latest

Steps to reproduce the issue
When building the precompiled library the build completes with errors(Package 'rcutils' exports library 'dl' which couldn't be found). Then the build keeps looping withou an exit. It seems all the packages complete before loop restarts.
Expected behavior
Build completes without error and exits.
Actual behavior
Build has errors, and never completes.
Additional information

Please provide steps (commands) for replicating the issue.

The library is built multiple times for all the supported boards. So its not looping, its just building the library with different compilers/configurations and should eventually end.
You should be able to pass this arguments to docker, so the build only happens for certain boards:
https://github.com/micro-ROS/micro_ros_arduino/blob/8eff9c2c435c72f10131d77fef8a98c49d5f676b/extras/library_generation/library_generation.sh#L12-L25

Thanks for the help, your solution worked!


Setting windowLevel for that users are using multiple windows.

Hi,
I guess someone want to change windowLevel like me. :p
Wanbok.

Hi Wanbok.
I haven't forgotten about your PR. I'm just trying to decide if it makes sense in the main repo. For the few people that may need to modify the windowLevel it may make sense just to pull down the source and modify it. I'm trying to make the class as simple as possible.

Hi Wanbok. I've decided to not merge your change into master. I think that most users of this repo will not be modifying the windowLevel, so exposing it only adds additional noise. For advanced users such as yourself, you can modify the source by cloning or forking. 😄


vryjs.exe detected as trojan and malware

virustotal detected vryjs.exe as trojan and malware but the original val rank yoinker is not detected as anything, any clues why?

No idea about how they flag exe files, but i will look into it for sure.
But the best part about open source is that you can look into the code yourself to see that there's nothing suspicious, so that's a false positive virus detection.

Looks like it's because of Go runtime
https://go.dev/doc/faq#virus

ah i see thanks


ApiTooOld error

Can you rebuild this app with last firmware? And would be nice to upload it in flipper apps catalog

Hi! Sorry for the delay. The code was already integrated into both the official and the Unleashed fork!


Remove "Frequency" from the option list

Discussion suggests it makes sense just not to show this option?

Dear Chuck,
Thanks for looking into this!
Frequency doesn’t make sense in the sunpath diagram.
It should remain in the drop-down for the psychrometric chart. I believe the issue is that all the drop-down at the moment share the same list
Best,
Giovanni
On 3. Dec 2023, at 00:08, Chuck McCallum @.***> wrote:

Discussionhttps://github.com/CenterForTheBuiltEnvironment/clima/issues/176#issuecomment-1537376587 suggests it makes sense just not to show this option?

You can view, comment on, or merge this pull request online at:
https://github.com/CenterForTheBuiltEnvironment/clima/pull/218
Commit Summary

e81207bhttps://github.com/CenterForTheBuiltEnvironment/clima/pull/218/commits/e81207ba57bbad467de8693367e0cbe8d5e1c76e Remove "Frequency" from the option list

File Changes
(1 filehttps://github.com/CenterForTheBuiltEnvironment/clima/pull/218/files)

M my_project/tab_sun/app_sun.pyhttps://github.com/CenterForTheBuiltEnvironment/clima/pull/218/files#diff-c57cbdaab847b6f81a07f9d1a002fb5402d6165501a806c27f057916527af4f3 (1)

Patch Links:

https://github.com/CenterForTheBuiltEnvironment/clima/pull/218.patch
https://github.com/CenterForTheBuiltEnvironment/clima/pull/218.diff

—
Reply to this email directly, view it on GitHubhttps://github.com/CenterForTheBuiltEnvironment/clima/pull/218, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIWZJADMOOR7YUHL6HL3IRDYHOYE3AVCNFSM6AAAAABAEKHGA6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDEMRUG44TINY.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Refresh breakpoints on hot restart

Our internal JS files have a cache busting URI for JS files but not source maps.  This appears to confuse the source map refresh logic when a new JS file is loaded while running.  With this change, the old source map is reset properly.
@alan-knight

Well, I don't quite understand what's going on here, but it seems to fix the problem, so OK.


Update 15.handling-attachments README for Teams

The README.md for sample 15.handling-attachments needs an update.

Add pointer to sample 56.teams-file-upload as "The Teams samples are designed to work in Teams better than the other samples" per this related issue.
Needs to be done across all languages.

@daveta The differences that I see between the 2 exmaples are:

Sample 15 uploads file to an endpoint on on the serviceURL server (/v3/conversations/{conversationId}/attachments) while sample 56 uploads the SharePoint account of the Teams user.
Sample 15 shows how to proactively upload a file unlike sample 56 where an uploadURL is required to upload the file.

I am looking to upload a file proactively as in case of sample 15.

@clearab Assigning this to you for now as related to Teams issues. Once we have a clear scope for the issues we are addressing in R10 we can load balance if needed.

All up SDK tracking issue for Teams docs https://github.com/microsoft/botframework-sdk/issues/5896


Update all pre-commit versions

Description

Closes #3666
Link to documentation:

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[x] 🛠 Code is written according to the code quality guidelines
[x] 🛠 Tests run successfully
[x] 🛠 All checks below this pull request were successful

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

I have tried using both the current precommit rev (v<IP_ADDRESS>07) and the latest rev (0.4.2) but both get slightly different variations of the same error
For v<IP_ADDRESS>07:
[INFO] Installing environment for https://github.com/lorenzwalthert/precommit/.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('<mo-environmentlocation>', '--vanilla', '/var/tmp/tmp0bxucmjx/script.R')
return code: 1
stdout: (none)
stderr:
    # Bootstrapping renv 0.16.0 --------------------------------------------------
    Warning: unable to access index for repository https://cran.rstudio.com/src/contrib:
      cannot open URL 'https://cran.rstudio.com/src/contrib/PACKAGES'
    Warning: unable to access index for repository https://cloud.r-project.org/src/contrib:
      cannot open URL 'https://cloud.r-project.org/src/contrib/PACKAGES'
    * Downloading renv 0.16.0 ... FAILED
    Error in bootstrap(version, libpath) : failed to download renv 0.16.0
    Calls: source ... eval.parent -> eval -> eval -> eval -> eval -> bootstrap
    Execution halted

for 0.4.2 :
most recent:
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/net/project/ukmo/scitools/opt_scitools/conda/environments/esmvaltool-2.9.0-2/bin/Rscript', '--vanilla', '/var/tmp/tmphzwj4nyz/script.R')
return code: 1
stdout: (none)
stderr:
    # Bootstrapping renv 0.17.3 --------------------------------------------------
    Warning: unable to access index for repository https://cran.rstudio.com/src/contrib:
      cannot open URL 'https://cran.rstudio.com/src/contrib/PACKAGES'
    Warning: unable to access index for repository https://cloud.r-project.org/src/contrib:
      cannot open URL 'https://cloud.r-project.org/src/contrib/PACKAGES'
    * Downloading renv 0.17.3 ... FAILED
    Error in bootstrap(version, libpath) : failed to download renv 0.17.3
    Calls: source ... eval.parent -> eval -> eval -> eval -> eval -> bootstrap
    Execution halted
Check the log at /net/home/h02/egillett/.cache/pre-commit/pre-commit.log

I think it may be a MO specific issue related to R so have assigned to @ehogan for the time being as will be moved onto a different project this week.

This is a MO issue (related to our usual proxy issues) 🙄 I will fix this in our community environment, but in the meantime, I will suggest using this branch to all versions in the .pre-commit-config.yaml file 👍

@ehogan Did you want to synchronize the pins here with those in environment (_osx).yml and optionally those in setup.py for a more consistent experience?

@ehogan Did you want to synchronize the pins here with those in environment(_osx).yml and optionally those in setup.py for a more consistent experience?

This is a tricky question 😊 One of the benefits of pre-commit (in my opinion) is that pre-commit manages its own environments for the versions defined in the pre-commit configuration file (one environment per pre-commit hook, so there are no solving issues), so if everyone installs the pre-commit hooks, everyone will be using the same version. It's true that if someone chose to run, e.g. isort on the command line (which would use the version installed in the developer's ESMValTool environment) it may behave differently to the pre-commit hook, because the pre-commit version wouldn't necessarily be aligned with the version in the ESMValTool environment, so I agree there is a benefit to aligning the versions. The disadvantages are that if we pinned all the versions in the environment(_osx).yml file, this may make the environment harder to solve, and we would need to introduce a policy on when we would update the versions (once per release?). There may be other disadvantages I haven't thought of (@valeriupredoi any thoughts?). I would be happy to pin the versions in the environment(_osx).yml file if others are happy to do so? 😊

It shouldn't be a problem to pin in environment.yml if we update regularly. The thing is that 1) not everybody uses pre-commit and 2 pre-commit doesn't quite manage its own environments, only the Python bits, for e.g. the R linters you're still dependent on whats installed in conda.

It shouldn't be a problem to pin in environment.yml if we update regularly. The thing is that
1. not everybody uses pre-commit and

2. pre-commit doesn't quite manage its own environments, only the Python bits, for e.g. the R linters you're still dependent on whats installed in conda.

Ah, true. Ok, I'll do some pinning shortly 👍

It shouldn't be a problem to pin in environment.yml if we update regularly. The thing is that

not everybody uses pre-commit and
pre-commit doesn't quite manage its own environments, only the Python bits, for e.g. the R linters you're still dependent on whats installed in conda.

Ah, true. Ok, I'll do some pinning shortly 👍

Now done in 16e4d6adf 😊

I think I broke everything 😕

Did you want to pin the R linter (lintr) and formatter (styler) too? The most recent versions are 3.1.2 and 1.10.3 respectively.

Did you want to pin the R linter (lintr) and formatter (styler) too? The most recent versions are 3.1.2 and 1.10.3 respectively. Note that these are different version numbers than the associated pre-commit hooks because pre-commit does not install R packages.

Yes, I did originally use the version from the pre-commit configuration file (0.4.2), but that didn't work, and I just realised the versions of the individual packages are available in the lock file for the pre-commit hook (3.1.2 and 1.10.2, respectively), but I'll use the versions you provided 👍

Did you want to pin the R linter (lintr) and formatter (styler) too? The most recent versions are 3.1.2 and 1.10.3 respectively. Note that these are different version numbers than the associated pre-commit hooks because pre-commit does not install R packages.

Yes, I did originally use the version from the pre-commit configuration file (0.4.2), but that didn't work, and I just realised the versions of the individual packages are available in the lock file for the pre-commit hook (3.1.2 and 1.10.2, respectively), but I'll use the versions you provided 👍

Done in 47c2a6772 😊


Update ruby to 2.6.5 for security reasons

https://www.reddit.com/r/ruby/comments/dbu4pm/new_ruby_released_265_257_248_security_fixes/