Update Composer dependencies (2022-01-05-00-12)

Visual regression test passed!
View the visual regression test report


Add check/test for  Add-On System Types: Container Build Host and virt. Host

bsc#1048470

[ ] head
[ ] 31
[ ] 30

# And I should see a "Virtualization Host" text  (not sure if the text was that)
And I should see a "Container Build Host" text

ok since the virt-host is not possible to test with a virt-host, closing for momoemnt, build host is already checked


feat: Memory Integrations (chat history)

PR Checklist

[x] Read the Contributing documentation.
[x] Read the Code of conduct documentation.
[x] Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
[x] Describes the source of new concepts.
[x] References existing implementations as appropriate.
[x] Contains test coverage for new functions.
[x] Passes all golangci-lint checks.

Description

adding the ability to port in any memory integration for the buffer
by this logic, we can pass in any store that we would like to have to keep track of the chat history

Very nice! As I understand this will allow me to implement a postgre based chat message history, which I attempted in https://github.com/tmc/langchaingo/pull/186

Very nice! As I understand this will allow me to implement a postgre based chat message history, which I attempted in #186

exactly! 😄

@tmc Can we add option.WithTokenLimit() or something of the kind here? I know python lib has TokenBuffer class to flush to chat msgs that overflow the token size for a model. Not sure if we need an entirely new buffer for that, so we might consider it... cc @FluffyKebab
related to https://github.com/tmc/langchaingo/issues/125

@tmc Can we add option.WithTokenLimit() or something of the kind here? I know python lib has TokenBuffer class to flush to chat msgs that overflow the token size for a model. Not sure if we need an entirely new buffer for that, so we might consider it... cc @FluffyKebab
related to #125

I will see when I grab time, to add the token limit, like they have in the python lib, maybe we can do it as a separate PR.

Could you add or augment an example showing use?

TestBufferMemoryWithChatHistoryOption is mimicking the store (that could be anything) and is an example of usage, do you think we need smth more?

@tmc Can we add option.WithTokenLimit() or something of the kind here? I know python lib has TokenBuffer class to flush to chat msgs that overflow the token size for a model. Not sure if we need an entirely new buffer for that, so we might consider it... cc @FluffyKebab
related to #125

@tmc @Struki84 added the token limit logic https://github.com/tmc/langchaingo/pull/217


Support for custom HTTP headers

It would great if the client could emit a custom HTTP header with every request. Two options should be available to register such a header: as global option and on a per-request basis.

Did you try
$e = Search::Elasticsearch->new(
    nodes       => [ 'search1', 'search2' ],
    default_headers => {
        'X-Opaque-Id' => $id,
    },
)

?


Setup MailChimp to be the primary storage point for donor submissions

To discuss...

Hello Topher, is there anything you want to discuss with me?
On Oct 9, 2015 6:31 PM, "Topher White"<EMAIL_ADDRESS>wrote:

To discuss...
—
Reply to this email directly or view it on GitHub
https://github.com/rfcx/rfcx.org/issues/7.

Hello Topher,
Have you checked the map work? Wanna talk to you about the upcoming
project.
Debjani
On Fri, Oct 9, 2015 at 11:29 PM, Debjani Saha<EMAIL_ADDRESS>wrote:

Hello Topher, is there anything you want to discuss with me?
On Oct 9, 2015 6:31 PM, "Topher White"<EMAIL_ADDRESS>wrote:

To discuss...
—
Reply to this email directly or view it on GitHub
https://github.com/rfcx/rfcx.org/issues/7.

This is done, and working. Thanks!


"Error validating token: IDX10223" Whilst getting a KeyVault secret

Package Name: azure-keyvault-secrets
Package Version: 4.1.0
Operating System: Ubuntu 20.04
Python Version: 3.8

Describe the bug
After some period of time, running the following will return an error
credential = DefaultAzureCredential()
self._secret_client = SecretClient(vault_url=keyvault_url, credential=credential)
# ... after a undetermined amount of time
self._secret_client.get_secret(secret_name)

Stacktrace
HttpResponseError: (Unauthorized) Error validating token: IDX10223
  File "a/server.py", line 48, in readyz
    cache.get_secret('a-readyz')
  File "a/cache.py", line 21, in get_secret
    secret = self.storage.get_secret(normalised_secret_name, secret_name)
  File "a/storage.py", line 50, in get_secret
    secret_value_obj = self._secret_client.get_secret(secret_name)
  File "/usr/local/lib/python3.8/site-packages/azure/core/tracing/decorator.py", line 83, in wrapper_use_tracer
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/azure/keyvault/secrets/_client.py", line 66, in get_secret
    bundle = self._client.get_secret(
  File "/usr/local/lib/python3.8/site-packages/azure/keyvault/secrets/_shared/_generated/v7_0/operations/_key_vault_client_operations.py", line 1625, in get_secret
    map_error(status_code=response.status_code, response=response, error_map=error_map)
  File "/usr/local/lib/python3.8/site-packages/azure/core/exceptions.py", line 102, in map_error
    raise error

To Reproduce
Unknown, it happens after a few hours/days, I've had this happen in 3 different environments now,
Expected behavior
I expected it to return a secret
Additional context
This is running in a container, on Kubernetes in Azure using pod-aad-identity to assign a managed identity to the worker the container is running on, and then handles calls to the metadata address.

It's no consolation to you I'm sure, but this is an interesting bug 😄
IDX10223 means the client sent an expired access token. This is unexpected because if a token appears to be expired or expiring within 5 minutes, the client will ask for a new one. If that failed, you would see a different error. It is possible for the client to send an expired token, however, because it will use a new token once before checking its validity (see this code).
That suggests two possible causes. First, perhaps the client determined the token was valid. It uses time.time() to do that. If it receives a sufficiently skewed value, it will use a token Azure AD considers expired. Second, perhaps the client requested a token from the managed identity endpoint and received an expired one. The endpoint presumably has its own cache and shouldn't hand out expired tokens from it, but that misbehavior would have the result you're seeing. I suppose skewed clock values on your worker could also cause this to happen.
But I'm speculating. I'm afraid it would take some debugging within your cluster to figure out what exactly is going on. I don't see any related issue in aad-pod-identity.

Thanks @chlowell, I've done some digging around the cluster and verified all the clocks are in sync. I also noticed it happened across multiple clusters in short succession which roughly followed the order in which I deployed the containers so I'm thinking that it was given an expired token by aad-pod-identity. It works at first so a cached expired token makes sense to me. I'll go bug those guys and see if they have any ideas.

Hey @chlowell so I've done some digging. Clock skew seems unlikely, and I've spoken to the AAD guys and they do no caching and pass through the requests straight to the metadata endpoint.
Got some logs when it happened the other day.
These log lines all followed the stacktrace above, so it happens 4 times a day
<IP_ADDRESS> - - [13/Jul/2020:08:30:08 +0000] "GET /readyz HTTP/1.1" 500 35 "-" "kube-probe/1.16"
<IP_ADDRESS> - - [13/Jul/2020:08:32:08 +0000] "GET /readyz HTTP/1.1" 500 35 "-" "kube-probe/1.16"
<IP_ADDRESS> - - [13/Jul/2020:08:35:08 +0000] "GET /readyz HTTP/1.1" 500 35 "-" "kube-probe/1.16"
<IP_ADDRESS> - - [13/Jul/2020:08:42:08 +0000] "GET /readyz HTTP/1.1" 500 35 "-" "kube-probe/1.16"

The issue is slightly more complicated as there are 2 workers serving requests for /readyz but both should request a token and deal with it appropriately.
These are the logs from the NMI pod on that host. Basically showing the time the pod requested tokens
I0713 08:20:08.403864       1 standard.go:72] No clientID in request. pod1-54cc5b6fdc-5fng8 has been matched with azure identity pod1
I0713 08:20:08.403938       1 standard.go:165] matched identityType:0 clientid:adf7##### REDACTED #####eec5 resource:https://vault.azure.net
I0713 08:20:08.617855       1 server.go:190] Status (200) took 214117053 ns for req.method=GET reg.path=/metadata/identity/oauth2/token req.remote=<IP_ADDRESS>
I0713 08:43:08.403759       1 standard.go:72] No clientID in request. pod1-54cc5b6fdc-5fng8 has been matched with azure identity pod1-identity
I0713 08:43:08.403842       1 standard.go:165] matched identityType:0 clientid:adf7##### REDACTED #####eec5 resource:https://vault.azure.net
I0713 08:43:08.415703       1 server.go:190] Status (200) took 12119465 ns for req.method=GET reg.path=/metadata/identity/oauth2/token req.remote=<IP_ADDRESS>

Is there anything I can do to dig into this further, to verify that the metadata endpoint isn't handing out expired tokens? Anyway I can easily hook/monkeypatch the credential getting piece?

You could enable debug logging on the client with logging_enable=True:
self._secret_client = SecretClient(vault_url=keyvault_url, credential=credential, logging_enable=True)

That would log all its requests at DEBUG level with nothing redacted. So, security warning there, but it would let you read the token from a failed request's Authorization header and check its exp claim (the token is a JWT). Alternatively, you could do similar with the credential instead, i.e. DefaultAzureCredential(logging_enable=True). Then you'd see the token request itself:
Request URL: 'http://<IP_ADDRESS>/...'
Request method: 'GET'
Request headers:
    'Metadata': 'true'
    'User-Agent': 'azsdk-python-identity/1.3.1 ...'
Request body:
None
Response status: 200
Response headers:
    'Content-Type': 'application/json; charset=utf-8'
    'Date': 'Mon, 20 Jul 2020 16:19:39 GMT'
    'Content-Length': '1643'
Response content:
{"access_token":"...","expires_on":"1595347982", ...}

For a monkeypatch approach, SecretClient adds tokens to requests here and the credential deserializes the token here.

Have not seen it reoccur in the environment with the additional logging. Am working on it :D

Thank you @terrycain! Please let us know if you are able to repro this!


Fix unit tests on Windows.

Prep for release 0.4.0

Codecov Report

Merging #91 (3b0236f) into main (3800e01) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   96.26%   96.26%
=======================================
  Files          10       10
  Lines        1714     1714
=======================================
  Hits         1650     1650
  Misses         64       64

Flag
Coverage Δ

unittests
96.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3800e01...3b0236f. Read the comment docs.


stack roll events and dice roll content on small screen

Why
On small screen dice page shows roll event, winner event and game ui in single row, making events UI to overlap with center game UI.
What
On small screen dice page will show Game UI on top and then roll event and then winner event in stack form.
How
When screen size is small reduce the grid column to 1 and rearrange Game UI, Roll Event and Winner UI with grid's start-row property.

Thanks @pankaj512  looks great 🙌


super cool

super cool

Agreed! Good job @KohakuBlueleaf !

LOOL is that a Disney pokemon card?


[ENH] Add test steps and explicit support for Python 3.9 and 3.10

Closes #575.

Changes proposed in this pull request:

Support Python versions 3.9 and 3.10. Create and add new jobs for 3.9 and 3.10 in the CircleCI config file.

Updating the version fixed the issue. Should we use the latest release (setuptools==58.2.0)?

If it still works for Python 3.6, then yes. Otherwise, I'd like to determine the most recent version that works for all Python versions we support.

It seems like numpy has not released a wheel for Python 3.10.

I would add 3.9 support in this PR and tackle 3.10 later. The numpy wheel may be out by next month, but any issues with a different package in 3.10 may delay the 3.9 support.


[IconButton] Improve onClick warning

Not sure where to put this, but I'm getting the warning:
Failed prop type: Material-UI: You are providing an onClick event listener to a child of a button element.
Firefox will never trigger the event.
You should move the onClick listener to the parent button element.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Warning thrown
Expected Behavior 🤔
Warning is a non-issue (in Firefox, from what I gather, in this situation), so this warning shouldn't be there.
I get why this is being thrown, the expand icon is wrapped in a button base (IconButton), but I feel like the warning is misleading.
Also, curious to know if you guys had a conversation about ever giving users the ability to pass a function to the IconButton component? If not, I wouldn't mind making a PR. Not sure how it would look like yet, but what would be wrong with something like,
type TAccordion = {
       . . . . .
       onExpandIconClick: (...params: any[]) => any;
}

const AccordionSummary = React.forwardRef(function AccordionSummary(props, ref) {
   const {
        onExpandIconClick,
        classes,
        expandIcon,
        IconButtonProps = {},
        ...other
   } = props;
   . . . . .
   return {
   . . . . .
    {expandIcon && (
        <IconButton
            onClick={onExpandIconClick}
            edge='end'
            component='div'
            tabIndex={null}
            role={null}
            aria-hidden
            {...IconButtonProps}
            className={clsx(
                classes.expandIcon,
                {
                    [classes.expanded]: expanded,
                },
                IconButtonProps.className,
            )}
        >
            {expandIcon}
        </IconButton>
    )}

Steps to Reproduce 🕹

I simplified your example https://codesandbox.io/s/competent-hopper-vbe1p?file=/src/Accordion.js
The basic HTML rule is that you cannot put "button" element inside another "button" element. https://stackoverflow.com/a/39386695/2996376
I guess because AccordionSummary's rendered root element has role="button", even though it is not a button you cannot put another button in it.

@croraf Thanks for investigating, so the provided codesandbox is invalid. Regarding the warning, the latest version of Firefox support it correctly now. However, the warning seems still relevant as adding an onClick listener on the svg inside the icon button will leave a bunch of the element unresponsive. I would propose something like:
diff --git a/packages/material-ui/src/IconButton/IconButton.js b/packages/material-ui/src/IconButton/IconButton.js
index 4335eef644..5f544fa3b1 100644
--- a/packages/material-ui/src/IconButton/IconButton.js
+++ b/packages/material-ui/src/IconButton/IconButton.js
@@ -145,11 +145,9 @@ IconButton.propTypes = {
     if (found) {
       return new Error(
         [
-          'Material-UI: You are providing an onClick event listener ' +
-            'to a child of a button element.',
-          'Firefox will never trigger the event.',
-          'You should move the onClick listener to the parent button element.',
-          'https://github.com/mui-org/material-ui/issues/13957',
+          'Material-UI: You are providing an onClick event listener to a child of a button element.',
+          'Prefer applying it to the IconButton directly.',
+          'This guarantees that the whole <button> will be responsive to click events.',
         ].join('\n'),
       );
     }

Regarding the use case, developers can have custom layout with the children prop. I don't think that we need to change anything to the expandIcon prop.

Let me comment just on the use case part.
Yes, the AccordionSummary can be customized as per user's wish with the children props.
But from the docs it is not 100% clear about what is the intention of the expandIcon. That its use case is purely presentational and that it just bubbles the click to the parent. What makes it even more confusing is the "button click ripple feedback" that happens when you click on the icon. (the button does not take the keyboard focus and that is good).

@croraf The prop is described as :
  /**
   * The icon to display as the expand indicator.
   */
  expandIcon: PropTypes.node,

Its default purpose is presentational, it has no roles, no tab indexes. What do you envision as an appropriate change?

@oliviertassinari The first question is, do we really want this expandIcon to be wrapped in IconButton. This is not clear from https://material.io/archive/guidelines/components/expansion-panels.html#expansion-panels-behavior
From the default usage, it seems that it should not be wrapped, as it triggers no special event (just passes it to the entire "AccordionSummary".

do we really want this expandIcon to be wrapped in IconButton

@croraf Google featured snippets' accordion doesn't. We could potentially drop it.

I will make this PR tomorrow (if I dont forget) so the others can also comment if it makes sense.

Thanks guys. Closing for now. If that's a premature action, please feel free to reopen it.

I have added the "good first issue" label, we can update the warning message.
Regarding the IconButton, we could potentially remove it, it would match what Google would use for its accordion on search result featured snippets: https://www.searchenginejournal.com/google-featured-snippets-guide/351272/.
However for this demo: https://next.material-ui.com/components/accordion/#additional-actions, we likely want it.

I am new to open source and want to make my first PR on this. @oliviertassinari please tell me more about it and where to start.

@pranjanpr Check https://github.com/mui-org/material-ui/blob/next/CONTRIBUTING.md .
Basically only this change is required: https://github.com/mui-org/material-ui/issues/22804#issuecomment-701028707
or if you have something better to suggest regarding this particular issue.
The rest of this issue is related to AccordionSummary component. That comment is related to the IconButton component.

@croraf so I just have to modify the onClick warning to the one given in above discussions?

@pranjanpr yes.
Also there is an unrelated second issue that I'm doing a PR for (you can see the PR link slightly above).


Bug: typing error passing list of context managers to lifespan app parameter

Description
Passing a list of pre-constructed async context managers to lifespan parameter causes:
app.py:20: error: Argument "lifespan" to "Litestar" has incompatible type "list[AioCtxMgr]"; expected "list[Callable[[Litestar], AbstractAsyncContextManager[Any]] | AbstractAsyncContextManager[Any]] | None"  [arg-type]
app.py:20: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
app.py:20: note: Consider using "Sequence" instead, which is covariant

URL to code causing the issue
No response
MCVE
from __future__ import annotations

from typing import Any

from litestar import Litestar

class AioCtxMgr:
    """A dummy context manager."""

    async def __aenter__(self) -> None:
        pass

    async def __aexit__(self, *args: Any) -> None:
        pass

ctx_mgrs = [AioCtxMgr()]
Litestar(route_handlers=[], lifespan=ctx_mgrs)

Litestar(route_handlers=[], lifespan=[AioCtxMgr()])  # OK

Steps to reproduce
Run mypy on MCVE code.

Screenshots
"![SCREENSHOT_DESCRIPTION](SCREENSHOT_LINK.png)"

Logs
No response
Litestar Version
2.0.1final0
Platform

[X] Linux
[ ] Mac
[ ] Windows
[ ] Other (Please specify in the description above)

Funding

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified

Can this be typed with OptionalSequence?

Can this be typed with OptionalSequence?

I don't why not :+1:


Install Errors

I did $ git clone, then npm install, then npm run devserver. Got these errors:
ERROR in multi main
Module not found: Error: Cannot resolve module 'es6-shim' in /Users/scottopolis/Documents/Apps/ionic2-webpack-ES6-boilerplate
@ multi main
ERROR in multi main
Module not found: Error: Cannot resolve module 'zone.js' in /Users/scottopolis/Documents/Apps/ionic2-webpack-ES6-boilerplate
@ multi main
ERROR in multi main
Module not found: Error: Cannot resolve module 'reflect-metadata' in /Users/scottopolis/Documents/Apps/ionic2-webpack-ES6-boilerplate
@ multi main
ERROR in multi main
Module not found: Error: Cannot resolve module 'angular2/angular2' in /Users/scottopolis/Documents/Apps/ionic2-webpack-ES6-boilerplate
@ multi main
ERROR in ./lib/data/data.module.js
Module build failed: Cannot resolve module 'angular2/angular2' in /Users/scottopolis/Documents/Apps/ionic2-webpack-ES6-boilerplate/lib/data
Required in /Users/scottopolis/Documents/Apps/ionic2-webpack-ES6-boilerplate/lib/data/data.module.js
@ ./lib/index.js 25:20-49
ERROR in ./lib/account/account.module.js
Module build failed: Cannot resolve module 'angular2/angular2' in /Users/scottopolis/Documents/Apps/ionic2-webpack-ES6-boilerplate/lib/account
Required in /Users/scottopolis/Documents/Apps/ionic2-webpack-ES6-boilerplate/lib/account/account.module.js
@ ./lib/tabs/tabs.module.js 26:23-59
ERROR in ./lib/chat/chat.module.js
Module build failed: Cannot resolve module 'angular2/angular2' in /Users/scottopolis/Documents/Apps/ionic2-webpack-ES6-boilerplate/lib/chat
Required in /Users/scottopolis/Documents/Apps/ionic2-webpack-ES6-boilerplate/lib/chat/chat.module.js
@ ./lib/chats/chats.module.js 25:20-50

yep you are running an old npm version I guess:

Just updated, getting same errors.
npm -v
3.3.8
node -v
v4.2.1
I also tried npm cache clean, with no success.

it is working fine on my end.
# Remove node_modules when you re-install it is safer.
rm -rf node_modules/
npm install

Got the same error with a fresh installation. Running on Win10, Npm v.3.7.3, Node v.v4.3.1. Looks like there are missing dependencies.

This repo is kinda old, it need to be updated. If you happen to make it
work with the ionic 2 beta version please make a PR
On Feb 19, 2016 04:04, "Christoph Ebert"<EMAIL_ADDRESS>wrote:

Got the same error with a fresh installation. Running on Win10, Npm
v.3.7.3, Node v.v4.3.1. Looks like there are missing dependencies.
—
Reply to this email directly or view it on GitHub
https://github.com/shprink/ionic2-webpack-ES6-boilerplate/issues/1#issuecomment-186147424
.


Add Spacer.auto()

Pull Request Template
Description
Add a auto height/width Spacer to fit for many use cases.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
I have used this in my app for more than half a year.

[ ] Unit Tests

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

@mlch911 Can you kindly update your branch with our main please? We have resolved the Github actions problem that's been preventing merge. I'll happily merge when you push up.

@mlch911 Can you kindly update your branch with our main please? We have resolved the Github actions problem that's been preventing merge. I'll happily merge when you push up.

You mean master branch, right?


Create a package for pub itself

This issue was originally filed by @seaneagan

I'm building a package which involves reading and writing to pubspecs, and pub's code to represent pubspecs, packages, dependencies etc. in the following files would be quite useful to have access to:
https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/sdk/lib/_internal/pub/lib/src/package.dart
https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/sdk/lib/_internal/pub/lib/src/pubspec.dart
It could either be a pub package or multiple pub_\*\*\* packages ala pub_semver.

This issue has been moved to dart-lang/pub#1154.


ig:dm

Cookie sessionid you are searching found was either not found or not valid!

this issue is fixed for me now, can you please try again. Closing this


New-world lacking submit failures

Fixed a problem with a test expecting submission failures in the old w…orld, whereas in the new world they would be accepted.

Why not remove submission failures if they can no longer exist?

@geoffjentry interesting question. I think they can still exist (e.g. no WDL supplied) but don't currently. What do you want me to do - remove or leave? I can see an argument either way

@cjllanwarne Let's chat in person as I interpreted your statements as that it would certainly not exist - so clearly I'm not playing with a full deck at the moment :)

:+1:

👍 LGTM


But

`
### Tasks
- [ ] Add a draft title or issue reference here

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

### Tasks
- [ ] https://github.com/microsoft/vscode/issues/185475

Nqr

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


DNS Leaks

Under Windows 10 (1709) 64 bit and OpenVPN massive DNS Leaks! Please check!

Would you mind writing a documentation page about what DNS leaks are, how to check for them and how DNS and VPNs interact?
Based on your initial content, it will be easier to understand the exact problems that may apply and how to solve them.
Thanks!


InstructionWeavingException on compile, regression since 0.7.0

Updating the nuget package has caused one of my projects to fail to compile, reverting to 0.6.2 works just the same as before.
I'm unable to product a minimal reproducible example right now, but code that I assume is supposed to be unreachable was reached, which led to the following compiler error:
  Fody: An unhandled exception occurred:
Exception:
Unexpected stack-clearing instruction encountered
Type:
InlineMethod.Fody.Helper.InstructionWeavingException
StackTrace:
   at InlineMethod.Fody.Extensions.CecilExtensions.GetPopCount(Instruction instruction) in C:\Work\c#\InlineMethod\src\InlineMethod.Fody\Extensions\CecilExtensions.cs:line 130
   at InlineMethod.Fody.InlineMethodWeaver.AnalyzeArgs() in C:\Work\c#\InlineMethod\src\InlineMethod.Fody\InlineMethodWeaver.cs:line 642
   at InlineMethod.Fody.InlineMethodWeaver.Process() in C:\Work\c#\InlineMethod\src\InlineMethod.Fody\InlineMethodWeaver.cs:line 710
   at InlineMethod.Fody.ModuleWeaver.ProcessCallInstruction(Instruction instruction, MethodDefinition method) in C:\Work\c#\InlineMethod\src\InlineMethod.Fody\ModuleWeaver.cs:line 25
   at InlineMethod.Fody.ModuleWeaver.ProcessMethod(MethodDefinition method) in C:\Work\c#\InlineMethod\src\InlineMethod.Fody\ModuleWeaver.cs:line 45
   at InlineMethod.Fody.ModuleWeaver.Execute() in C:\Work\c#\InlineMethod\src\InlineMethod.Fody\ModuleWeaver.cs:line 67
   at InnerWeaver.ExecuteWeavers() in C:\projects\fody\FodyIsolated\InnerWeaver.cs:line 204
   at InnerWeaver.Execute() in C:\projects\fody\FodyIsolated\InnerWeaver.cs:line 112
Source:
InlineMethod.Fody
TargetSite:
Int32 GetPopCount(Mono.Cecil.Cil.Instruction)

The only function that I can think of to trigger this is perhaps this one, which must inline the stackalloc since otherwise the memory address would be invalid by the time the function returns.
I'm sorry for not providing much information, I hope this is enough to sort the issue out.

I think it's fixed in 0.7.1

Works wonderfully, thank you for this library!


Call host podman inside a container but encounter Connection refused error

I want to call host podman inside a container by podman python client
So I do

run a contianer and mount podman socket
podman run -it --privileged --entrypoint=bash -v /lib/systemd/system/io.podman.socket:/lib/systemd/system/io.podman.socket docker.io/python:3.6

then I login to the container, install python package
python3 -m pip install podman

call podman with the socket unix:/lib/systemd/system/io.podman.socket like what I did with docker but error shows

python
Python 3.6.9 (default, Sep 12 2019, 16:23:48)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import podman
>>> pclient=podman.Client(uri='unix:/lib/systemd/system/io.podman.socket')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.6/site-packages/podman/client.py", line 178, in __init__
    if not System(self._client).ping():
  File "/usr/local/lib/python3.6/site-packages/podman/libs/system.py", line 38, in ping
    with self._client() as podman:
  File "/usr/local/lib/python3.6/site-packages/podman/client.py", line 98, in __enter__
    self._iface = self._client.open(self._context.interface)
  File "/usr/local/lib/python3.6/site-packages/varlink/client.py", line 598, in open
    connection = self.open_connection()
  File "/usr/local/lib/python3.6/site-packages/varlink/client.py", line 613, in open_connection
    return self._socket_fn()
  File "/usr/local/lib/python3.6/site-packages/varlink/client.py", line 512, in open_unix
    s.connect(address)
ConnectionRefusedError: [Errno 111] Connection refused

Anyone can help me on this, about I could I call host podman like what we did with docker

I think you're trying this as a rootless user?  If so, ping won't work inside of the container without further admin changes.  Can you confirm you try this as root and see if it works?  Here's a ptr to allow ping to work rootless if that's the issue.

A couple of things.  First is the podman on the server, new enough.  I think it has to be at least podman 1.5 or newer.  Second, this should only work if you are running rootfull podman not rootless.

@TomSweeneyRedHat I'm trying as a root user.  it working in podman 1.6 but not working on podman 1.02

Thanks @rhatdan it seems podman varlink issue.

Hello @lcnsir
Can tell me more about the varlink issue that you observe?

@4383  I want to call host podman inside a container that mount the socket in the container that I did in
https://github.com/containers/python-podman/issues/57#issuecomment-540995108
Then Call podman socket by the python client
When  podman  version
is
root@swagman3:~# podman version
Version:            1.6.1
RemoteAPI Version:  1
Go Version:         go1.10.4
OS/Arch:            linux/amd64

on a ubuntu host, it successfully
when the podman version is
[root@worker1 core]# podman version
Version:       1.0.2-dev
Go Version:    go1.11.5
OS/Arch:       linux/amd64

it failed with error
>>> pclient=podman.Client()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.6/site-packages/podman/client.py", line 178, in __init__
    if not System(self._client).ping():
  File "/usr/local/lib/python3.6/site-packages/podman/libs/system.py", line 38, in ping
    with self._client() as podman:
  File "/usr/local/lib/python3.6/site-packages/podman/client.py", line 98, in __enter__
    self._iface = self._client.open(self._context.interface)
  File "/usr/local/lib/python3.6/site-packages/varlink/client.py", line 598, in open
    connection = self.open_connection()
  File "/usr/local/lib/python3.6/site-packages/varlink/client.py", line 613, in open_connection
    return self._socket_fn()
  File "/usr/local/lib/python3.6/site-packages/varlink/client.py", line 512, in open_unix
    s.connect(address)
ConnectionRefusedError: [Errno 111] Connection refused

@lcnsir I don't believe remote access was supported until podman 1.1.0

So can we close this as not an issue?

yes pls close it, thanks guys


UART Bridge Mode Issue: Fails to Open Serial Port in WebSerial

I am encountering an issue with the Hydrabus device when trying to use UART bridge mode. Specifically, I am unable to connect to the device using WebSerial via a browser. The connection attempt fails with the error "Failed to open Serial port."
Steps to Reproduce

Connect the Hydrabus device to the computer.
Switch the Hydrabus to UART bridge mode using the appropriate commands.

uart 1
speed 115200
bridge

Open a browser and navigate to a WebSerial application. example https://web.esphome.io
Attempt to connect to the Hydrabus device.

Expected Behavior
I expect the browser to successfully connect to the Hydrabus device in UART bridge mode without any errors.
Actual Behavior
The browser fails to connect to the Hydrabus device, and I receive an error message stating "Failed to open Serial port."
Board: Hydrabus v1.0

Hello,
Looks like you have a permission issue. I tested and could get it listed and even interact with the shell or uart bridge.

Yes I confirm I have tested on my side with Windows it works perfectly using Chrome browser (or any browser which support correctly WebSerial)

I confirm, Windows worked flawlessly.
For Linux i had to add the user to the dialout group, then reset the session.
$ sudo usermod -aG dialout $USER

Thanks


Bug in Beam Search

There might be a bug in the beam search. If my understanding is correct increasing the beam size should never worsen the result. When testing on very large problems (CVRP1000) with beam sizes up to 4096 I'm experiencing some inconsistent results. Up to like a beam size of 16 results get better and then they start fluctuate a bit with the tendency to get worse again. A beam size of 4096 yields the same result then as the beam size of two.
I'm running something like this:
srun python eval.py
data/vrp/vrp_uniform_1000.pkl
-f
--no_progress_bar
--decode_strategy bs
--eval_batch_size 1
--width 1 2 4 8 16 32 64 128<PHONE_NUMBER> 2048 4096
--model pretrained/cvrp_50/epoch-99.pt
--max_calc_batch_size 10000
--softmax_temperature 1
Is this known? Anything I should try?

Hi!
Thanks for using our code! This is an interesting finding but does not mean there is a bug (per se) for two reasons:

First, while on average a larger beam size has better performance, there is no theoretical guarantee. With a larger beam size, you may include a partial solution which seems better at first, such that its descendants push other partial solutions off the beam that would otherwise have been extended until completion. This may result in better overal solutions not being found with a larger beam size.
You can debug/verify this yourself: find an example where a larger beam size yields worse performance and track the better solution from the smaller beam size in the bigger beam: when does it fall off the beam? Verify that indeed it has a worse score at that point.

Second, the beam is selected based on the model score, whereas performance is evaluated using route length. There is a mismatch, which should be small if the model is trained well. However, if the model is tested in a setting it was not trained for (e.g. a model trained on 50 points is tested on 1000 points), it is more likely that there is a mismatch, where the model selects 'bad' partial solutions thinking they are good/promising. This may be more prominent with a larger beam size, where there are more possibilities for the model to be 'confused' (i.e. pick an outlier which is bad but considered good by the model).
Also this you can verify by checking the correlation between the model score and the cost of the final prediction.

I am no expert, but I think similar results are seen when using beam search in NLP: bigger beam sizes give worse results and the 'search error' (from a small beam size) is actually used as a feature. See for example If beam search is the answer, what was the question?.

Ah yes you are right. My error of thinking was in your first point. I thought a beam size of 16 for instance must include all results from a beam size of 8 and only add more on to it. I didnt see how they would be pushed out later again because I thought only one expansion ahead so to say.
Thanks for the super fast response and also thanks for the code base!


Multiplayer peer documentation

Enabled the docs in the editor and added SMP class description and descriptions for some methods and signals.

Very cool!  Thank you so much for getting this going!


User-defined type not defined

Do you know what could be the problem here? I've imported the code into my excel document, But every time I try to run my macro I get the following error on the following line of code from the JsonConverter:
Compile Error: User-defined type not defined
Private Function json_ParseObject(json_String As String, ByRef json_Index As Long) As Dictionary
EDIT: I didn't realize that you could see the old resolved problem, I got it to work after adding the reference to Microsoft Scripting Runtime.
Thanks you very much for creating this!

Denis,
How did you resolve this issue?

Denis,
How did you resolve this issue?

As far as I remember, you need need to add Microsoft Scripting Runtime as a reference in VBA:

Alt + F11
"Tools"
"Reference"
Find "Microsoft Scripting Runtime" and add it


Update catalog-container-push-latest workflow

Since we need to build a catalog file every time when we have a new bundle image, we can't reuse metal-toolbox/container-push/.github/workflows/container-push.yml@main workflow, here is a temporary patch, so the catalog image can be built.

Merging to fix the release action and this doesn't affect the actual operator or tests.


The expected dependency version of ExternalDependencyManager[1.2.178] seems deprecated

Question
Mentioned in the package.json is the dependency of: "com.google.external-dependency-manager": "1.2.178".
When looking at Google's archive, you can see that this version is not listed (jumping from 1.2.177 to 1.2.179): https://developers.google.com/unity/archive#external_dependency_manager_for_unity
The version 1.2.178 seems to have been deprecated - although I'm not entirely sure why.
So the question is should this dependency be bumped to 1.2.179?

Yes, we'll bump it for the next release.

If you're curious, this is why 1.2.178 was not included in the archive: https://github.com/googlesamples/unity-jar-resolver/issues/672
The changes from 1.2.178 to 1.2.181 aren't major, but we'll still look into updating.


Add a Redis health check

Add a health check to Redis. We need to make an IHealthCheck implementation what establishes a connection to the database. If the connection establishes the check is Healthy, if not the check is Unhealthy.
The amount of work is low, so I don't think we need a third-party.
Test endpoint is /health.
References:

ControllerResolveHealthCheck class
Health checks in ASP.NET Core

Resolved at #40


Helm Installs of Spinnaker Periodically Fail with PersistentVolumeClaim Issues

I'm attempting to install Spinnaker via Helm and they fail a high percentage of the time with the following issues:
Minio Deployment:
[SchedulerPredicates failed due to PersistentVolumeClaim is not bound: "sullen-seahorse-minio", which is unexpected., SchedulerPredicates failed due to PersistentVolumeClaim is not bound: "sullen-seahorse-minio", which is unexpected., SchedulerPredicates failed due to PersistentVolumeClaim is not bound: "sullen-seahorse-minio", which is unexpected., SchedulerPredicates failed due to PersistentVolumeClaim is not bound: "sullen-seahorse-minio", which is unexpected., SchedulerPredicates failed due to PersistentVolumeClaim is not bound: "sullen-seahorse-minio", which is unexpected.]

Redis Deployment:
pod (sullen-seahorse-redis-1955876852-4xn7z) failed to fit in any node fit failure summary on nodes : NoVolumeZoneConflict (4), PodToleratesNodeTaints (3)

When this happens they never appear to recover, so I delete the release with Helm if it shows up, or delete all resources manually if it does not.
Sometimes trying it again will just work.

This error is bubbling up from Kubernetes' PVC system. @lachie83 do you have any experience on these errors? I don't know what they mean.

By default the minio chart uses persistence which needs to backed by a PV that matches the requirements or use a dynamic provisioner. Have you manually created a PV or are you expecting to use the dynamic provisioner? @pluttrell

I wasn't sure what to expect. Early on in my attempts to deploy this chart I created a bunch of PVs manually evenly spread across the AZs but then noticed they weren't being used. Instead of smaller ones were getting auto created and used. I was unable to find clear Kubernetes documentation on what to expect, nor why the PVs I created weren't being used...but since it appears to auto create them, I've since stopped manually creating them.

When I try the Spinnaker chart, I get various errors such as the two described in this original issue.
The NoVolumeZoneConflict errors, such as the one example above for Redis pod, I believe can be traced back to the PVs being created in one AZ and the scheduler attempting to attach it to an EC2 instance in a different AZ, which isn't allowed. On this deep dive, it feels like something core is wrong with Kubernetes, perhaps in the schedule for this to ever happen. Since I've built my k8s cluster using Kops, I was pointed to a manual workaround that has worked thus far. It's documented in this kops issue.
With regards to the more generic error in the Minio deployment, I wonder if AWS is taking longer than some timeout to bind the PV and thus fulfill the PVC...though I have no idea where such a timeout might be. Further adding to the inconsistency of these issues is that sometimes I'll see failures like this one that will go away after some time..in the many minutes timeframe. Other times I'll wait hours and it'll still be listed as failed before I delete the chart if helm lets me, or all of the artifacts manually.

This looks like it might be a Kubernetes Chart repo issue... should we move this issue to that queue?

Works for me.

Anything new on this?

closing. Tickets related to the spinnaker chart should be followed up at https://github.com/kubernetes/charts.


Unclear inscription ID in handbook

The handbook states the below.
Ord will output two transactions IDs, one for the commit transaction, and one for the reveal transaction, and the inscription ID. Inscription IDs are of the form TXIDiN, where TXID is the transaction ID of the reveal transaction, and N is the index of the inscription in the reveal transaction.

The commit transaction commits to a tapscript containing the contents of the inscription, and the reveal transaction spends from that tapscript, revealing the contents on chain and inscribing them on the first sat of the first output of the reveal transaction.

What exactly is N? Can you reveal multiple inscriptions in a reveal transaction? With the second paragraph, it mentions that the inscription is inscribed on the first sat of the first output. If there are more than one inscriptions revealed, where are subsequent ones inscribed?

Multiple things, first, there is an inconsistency because on https://docs.ordinals.com/inscriptions.html the docs say inscriptions are made "on the first sat of its input" (which is correct). I opened #2276 to make that change.
Secondly, N is the index of the inscription in the transaction. So in theory you can have multiple inscriptions per transaction. Taking the new definition from above a reveal transaction could have multiple inputs where each contains an inscription and they are inscribed on the first sat of their input. Going further you could have multiple inscriptions per input but currently we only assign them inscriptionIDs and make them unbound (not assigned to a sat). In the future these will become reinscriptions.
You can have a look at most of that code in src/inscription.rs and src/index/updater/inscription_updater.rs.

Ah, ok, that makes a lot more sense 👍 Thanks for the additional info. I'll leave this ticket open as a request to fix the description on the page I linked 🙏


feat(valibot): update valibot to v0.33.0

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Unfortunately, I introduced a breaking change in a type of Valibot v0.33.0. So I updated the dependencies and the implementation.

I forgot something. Let me fix it quickly.

Thanks @fabian-hiller! 😊


Extract response information by using libcurl

Fixes this issue.

awsome!
thanks.
I'll merge soon with checking behavior.


Remove some deprecated code from the viewer

Revert "[GENERIC viewer] Add fallback logic for the old PDFPageView.update method signature"
This reverts commit<PHONE_NUMBER>17c395f14f3cb60a02806c1b3bebc8, since it's now been included in three official releases.

Remove the deprecated PDFFindController.executeCommand method
This partially reverts commit fa8c0ef6164c7abfd5236e97823102a89517f8a4, since it's now been included in two official releases.

/botio integrationtest

/botio-linux preview

Nice clean-up!


Property 'executeDeepLink' does not exist on type 'typeof microsoftTeams'

Trying to use executeDeepLink() api on microsoftTeams sdk, but get the below error saying no such api is there.
microsoftTeams.executeDeepLink("deeplink");
Property 'executeDeepLink' does not exist on type 'typeof microsoftTeams'
Is there any other import required?

Which version of Microsoft Teams client SDK are you using? Could you please try it with latest version (1.4.2)?


[packager] Add font to project1 (Traffic Jam) when does PR

I don't know if it is possible, but would be a nice feature.
Eventually could add the labels "Ready for review" + "Font upgrade" or "New Font" according if the font is already on GF or not.

I'm pretty sure it's possible


fix: update apply, delete, getobjects func, unit tests

Codecov Report

Merging #6 (3cf59f8) into main (cab08ee) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   55.06%   55.06%
=======================================
  Files          12       12
  Lines         592      592
=======================================
  Hits          326      326
  Misses        214      214
  Partials       52       52

Flag
Coverage Δ

unittests
55.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client.go
32.35% <ø> (ø)

apply.go
52.27% <100.00%> (ø)

helper.go
46.15% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


bon_eval_utils.py is missing

Hi, Great job! I am very interested in your job. But the script of bon_eval_utils.py is missing, could you update it? Thanks a lot.

Thank you! I've supplemented the missing files:
bon_eval_utils.py
grader.py
normalizer.py
feel free to reopen the issue whenever you need!


Should setting npm as the package manager still display Commands ("yarn run COMMAND"):

Currently the terminal after running projen with packageManager: NodePackageManager.NPM is still showing:
Commands ("yarn run COMMAND"):
instead of
Commands ("npm run COMMAND"):

Right now the string is just hardcoded in:
https://github.com/eladb/projen/blob/6847053eddbb5ab8847c89e3f11d16f3023d0af1/src/cli/cmds/start-app.ts#L31
I'm not sure offhand how to go about implementing the bug fix, since it seems like the CLI tool generally doesn't have access to the entire set of projenrc.js options at runtime. One way I could see this being worked around is by adding some kind of extra metadata field in one of the generated config files (maybe package.json) which specifies the package manager choice, and then reading from that during the CLI tool's execution -- but maybe there's a simpler solution I haven't considered.
In principle you might be able to tell which package manager is set based on the presence of package-lock.json or yarn.lock files, but I don't think that would be reliable either.


jsx-no-bind message clarity

eslint-plugin-react<EMAIL_ADDRESS>Description:
The message for a jsx-no-bind check failure that I received reads JSX props should not use arrow functions.
However, the check was failing when passing in a direct function reference without an arrow function. For example:
onClick={runFunction}
I had to look at the docs to discover that this type of function passing was disallowed. The message I received doesn't explicitly mention my case, it only mentions arrow functions.
From looking at the linting code, it looks like the failure message should be dynamic and not just always mention arrow functions. However, I don't seem to be getting other messages:
https://github.com/yannickcr/eslint-plugin-react/blob/f93f90abe050c2232393ce0855f78f5c9a45d4ea/lib/rules/jsx-no-bind.js#L24
Proposed Success Criteria:
We should make it clear in the failure message what is disallowed. Specifically, we should not mention arrow functions if none are being used.

This is happening for me inside a functional component. Let me know if you can't reproduce and it's just something strange with my setup.

Can you try with the latest version, v7.28.0?

@xavier630 any chance you've been able to try with the latest version, which is now v7.29.3? Happy to reopen if that doesn't fix it.


Settings for Auto Responder

Summary
Settings > Notifications > AutoResponder

Activate Auto Responder in settings
Add custom message
If activated a new system message system_auto_response is sent and shown like this

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Has server changes (please link)
[x] Has UI changes
[x] Includes text changes and localization file (.../i18n/en.json) updates
[x] Touches critical sections of the codebase (auth, posting, etc.)

Screenshots

Thanks @miguelespinoza for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.


MI - QUICK START GUIDE

Remaining work for the QSG:

Update the project file attachments for the QSG [1]
Validate (with team) the QSG's applicability to EI 7
Text formatting and Copy editing

[1] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/docs/quick-start-guide/quick-start-guide.md

Assigning @a5anka  for a review.
Please note that the same QSG for the Micro Integrator of EI650 is added to EI700 with the following updates:

The 'Run on VM' section is added.

@nilminiwso2 Do we have instruction on generating or downloading hello-world-config-projectCompositeApplication_1.0.0.car. I couldn't find it in the linked document.

Is curl accessible in Windows? We might have to add a tool that can be used easily by Windows users.

@a5anka : regarding "Do we have instruction on generating or downloading hello-world-config-projectCompositeApplication_1.0.0.car. I couldn't find it in the linked document."
The CAR is available in the project file that we download in the 'Set up the Workspace' section. This is the MI_QSG_HOME directory.

@a5anka : regarding "Do we have instruction on generating or downloading hello-world-config-projectCompositeApplication_1.0.0.car. I couldn't find it in the linked document."
The CAR is available in the project file that we download in the 'Set up the Workspace' section. This is the MI_QSG_HOME directory.

:+1: I missed that one.


Update README.md

Issue #
just make it more formatted >
Changes

-

Flags

Related Issues

Issue #
Pull Request #

Thanks for your contribution @sakshamtaneja21 , however, both of these issues have negligible benefit.
I encourage you to choose from the list of existing open issues or to create a new issue first before making a PR.


Changing heating state on AC throws an error

Describe The Bug:
An error is thrown when trying to control heating/cooling state. Works fine from LG Think app.
To Reproduce:
Request the AC to heat or cool from the "accessories" tab in Homebridge or from Homekit.
Expected behavior:
State changes to the requested state
Logs:
[12/9/2022, 11:37:34 AM] [homebridge-lg-thinq] This plugin threw an error from the characteristic 'Target Heater-Cooler State': Unhandled error thrown inside write handler for characteristic: undefined is not a function. See https://homebridge.io/w/JtMGR for more info.
[12/9/2022, 11:37:34 AM] [homebridge-lg-thinq] TypeError: undefined is not a function
    at Array.filter (<anonymous>)
    at AirConditioner.setTargetState (/volume2/homebridge/node_modules/homebridge-lg-thinq/src/devices/AirConditioner.ts:331:8)
    at TargetHeaterCoolerState.<anonymous> (/volume2/homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:2547:42)
    at step (/volume2/homebridge/node_modules/homebridge/node_modules/tslib/tslib.js:144:27)
    at Object.next (/volume2/homebridge/node_modules/homebridge/node_modules/tslib/tslib.js:125:57)
    at /volume2/homebridge/node_modules/homebridge/node_modules/tslib/tslib.js:118:75
    at new Promise (<anonymous>)
    at Object.__awaiter (/volume2/homebridge/node_modules/homebridge/node_modules/tslib/tslib.js:114:16)
    at TargetHeaterCoolerState.Characteristic.handleSetRequest (/volume2/homebridge/node_modules/homebridge/node_modules/hap-nodejs/dist/lib/Characteristic.js:871:24)
    at Bridge.<anonymous> (/volume2/homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:1889:29)

Plugin Config:
       {
            "country": "NL",
            "language": "en-NL",
            "auth_mode": "token",
            "refresh_token": "[removed]",
            "username": "",
            "password": "",
            "platform": "LGThinQ",
            "devices": [
                {
                    "id": "61d87baa-a56f-1011-be4b-4cbce98fec96",
                    "name": "AC zolder",
                    "type": "AC",
                    "ac_mode": "BOTH",
                    "ac_swing_mode": "BOTH",
                    "ac_temperature_sensor": false,
                    "ac_humidity_sensor": false,
                    "ac_fan_control": true
                },
                {
                    "id": "af921227-df83-1fcd-b89a-4cbce9a25a2b",
                    "name": "AC woonkamer",
                    "type": "AC",
                    "ac_air_quality": false,
                    "ac_mode": "BOTH",
                    "ac_swing_mode": "BOTH",
                    "ac_temperature_sensor": false,
                    "ac_humidity_sensor": false,
                    "ac_fan_control": true
                }
            ],
            "thinq1": false,
            "refresh_interval": 60
        }

Screenshots:

Environment:

Plugin Version: 1.2.20
Homebridge Version: 1.6.0
Node.js Version: 16.16.0
NPM Version:
Operating System: Synology DSM 7.1

please update to latest version


[Bug]: obclient command line window displays an exception

ODC version
4.2.x
OB version
none
What happened?
After the obclient command line window executes a multi-line statement, an exception is displayed after pressing the up key.

What did you expect to happen?
normal display
How can we reproduce it (as minimally and precisely as possible)?
operate like the picture above
Anything else we need to know?
No response
Cloud
No response

The jdbc version needs to be upgraded to <IP_ADDRESS> or 2.4.11.


[FATFileSystem] Updated FatFs to R0.11

Updated the internal FatFs library to R0.11. Minor changes were made to FATFileSystem and FATDirHandle in order to accommodate API changes.

I just commit additional changes that modify the FATFileSystem virtual method argument types to match the integer widths expected by FatFs. Specifically, the read/write count argument is no longer a BYTE in this revision, and the uint64_t sector arguments have been changed to uint32_t. I'm not sure where the uint64_t came from since integer.h clearly specifies that DWORD should be 32-bit. SDFileSystem and USBHostMSD were also updated since they inherit from FATFileSystem. I didn't update USBMSD since it doesn't inherit from FATFileSystem, but it might benefit from the updated API for consistency sake.

Shall we split this into 2 PR? One is update with those minor changes, and the another one is updating API types?

Sure, how could I do that?

revert the last commit (changing API), and force push , for instance

Ok, I rolled back to the initial commit. Once this one is accepted, I'll work on a new pull request to change the API types.

Thanks for reverting.  I'll merge this the next week. LGTM


aud property is missing in 2.19

We add aud to payload via lexik_jwt_authentication.on_jwt_created event. After upgrade to 2.19, this property is missing in encoded token
Our listener
<?php

use Lexik\Bundle\JWTAuthenticationBundle\Event\JWTCreatedEvent;
use Lexik\Bundle\JWTAuthenticationBundle\Events;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

final class AttachPayloadToJwtSubscriber implements EventSubscriberInterface
{
    public function __construct(private PlatformDetector $platformDetector)
    {
    }

    public function onJwtCreated(JWTCreatedEvent $event): void
    {
        /** @var User $user */
        $user = $event->getUser();
        $payload = ['aud' => [],];

        foreach ($user->getLicense()->getApplications() as $licenseApplication) {
            $payload['aud'][] = $licenseApplication->getApplication()->getId();
        }

        $event->setData(array_merge($event->getData(), $payload));
    }

    public static function getSubscribedEvents(): array
    {
        return [Events::JWT_CREATED => 'onJwtCreated'];
    }
}

Same problem here. It's like the class never gets called when an event is fired.

Fix at https://github.com/lexik/LexikJWTAuthenticationBundle/pull/1144


pls work pls

Song Name
hard heart
Artist Name
elliot holmes-subiect
Source
Youtube
Youtube Link
qNvz0zJYCuimRdYE
Direct File Link
No response
Song ID
844658
Start Offset [ms]
1
Extra
Created from Auto Nong.
Created for level: 52469322

reject
invalid YouTube link. Also note that replacing popular songs such as creo songs with unrelated nongs is inconvenient and is therefore likely to be rejected


Add "mbed" to keywords

I just searched for "mbed tls" on crates.io and the only result was mbedtls-sys. This is clearly also crates.io's fault, but this might be a useful workaround.

Thanks for the PR! I'll just roll this up in the next release.


Video streams, but no audio (mp4/aac)

When video is streamed through hlsjs engine (from common desktop browsers lastest Chrome/FF/IE11) there is no audio. When video streams through html5 engine (iOS Safari) sound is OK.
You can check here: http://<IP_ADDRESS>/test/html5.html
For simplicity in m3u8 file I left only one bandwidth version, streaming is provided by Adobe Streaming server.
Yet there is no codec version in m3u8 file but I tried different ones, no change. I understand that hlsjs tries to guess right encoding if codec information is not provided.
mp4 file is encoded with this settings:
===================== Video =====================
Id                          : 1
Format                      : AVC
Format info                 : Advanced Video Codec
Format profile<EMAIL_ADDRESS>Use of CABAC                : Yes
RefFrames                   : 4 frames
Codec Id                    : avc1
Codec info                  : Advanced Video Coding
Duration (ms)               : 12mn 38s
Bitrate mode                : Variable
===================== Audio =====================
Id                          : 2
Format                      : AAC
Format info                 : Advanced Audio Codec
Format profile              : LC
Codec Id                    : 40
Duration (ms)               : 12mn 38s
Source_Duration/String      : 12mn 38s
Bitrate mode                : Variable
Bitrate                     : 192 Kbps
Bitrate maximum             : 297 Kbps
Channel(s)                  : 2 channels
ChannelPositions            : Front: L R
Sampling rate               : 48.0 KHz
Compression_Mode/String     : Lossy

The same happens with hls.js alone: http://dailymotion.github.io/hls.js/demo/?src=http%3A%2F%2F<IP_ADDRESS>%2Ftest%2Fplaylist1943.m3u8
I can't see any obvious problem with your stream, and it plays in generic HLS, so may I ask you to take this to the hls.js bug tracker: https://github.com/dailymotion/hls.js/issues - the plugin cannot make it work, if the hls.js client can't.
Thank you.

Thank you. I did that now https://github.com/dailymotion/hls.js/issues/61

I got the same issue when i make livestream with mp3 there was no sound in chrome but there was sound in safari and ios then i switched to acc it worked both chrome and safari but what is wrog with mp3?


Feature Request: map CJK Compatibility Supplement characters to the more frequent charcters

Not sure whether it's complete, but it looks a good starting point: http://tieba.baidu.com/p/1099507674

This would definitely be a nice feature. Contributions welcome :)


Added 'type' attribute to the default template of the directive

the reason of that is to use this directive on mobile devices
and to set up the input for e.g. "tel", "number", "password" etc.

Thanks, @mmBs
This looks like a nice addition for mobile usage.


x/pkgsite: type header table of contents links to a different type

What is the URL of the page with the issue?
https://pkg.go.dev/google.golang.org/grpc#EmptyDialOption
What is your user agent?
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Screenshot
Original:
After clicking "Experimental":

What did you do?
Under the "EmptyDialOption" type, I clicked on the "Experimental" link, which is intended to be a table of contents for the headers within the type doc.
What did you expect to see?
I expected the page to jump to the "Experimental" header just a few lines below (shown in the "Original" screenshot above).
What did you see instead?
The page jumped to https://pkg.go.dev/google.golang.org/grpc#hdr-Experimental, which is part of "func ClientSupportedCompressors" instead of "type EmptyDialOption".
The problem seems to be that the IDs (#hdr-Experimental) aren't unique per type/function, so links go to whichever appears first on the page.

@jba Isn't this an issue in go/doc/comment? (I see the same issue in godoc). Or does pkgsite use a custom header generation logic?


Upgrade bookstack to 0.25.2

https://github.com/BookStackApp/BookStack/releases/tag/v0.25.2

Hey @pschmitt ,
thanks for your PR. Could you rebase against master to trigger a new ci build .

Sure thing.

See https://github.com/solidnerd/docker-bookstack/pull/128


Resolving files with querystring

Hi, I am one of the maintainers of the @sentry/nextjs SDK and we recently got a bug report stating that we mess up the output of @vercel/nft. This is completely valid and reproducible.
What we're doing in the SDK is that we have a webpack loader that "proxies" user files and re-exports wrapped versions of particular functions (i.e. Next.js data fetching methods and API routes).
For the proxying mechanism we first replace the user-file with a proxy-file, from which we then import the user-file with a query string at the end to mark it as "already proxied" to avoid infinite loops (e.g. import * as wrapee from './page.js?__sentry_wrapped__'). The rollup docs explain this rather well.
For some reason this breaks the Next.js' nft file generation, leading to my first question: Do you know why this would be happening?
Webpack is able to resolve imports containing a query parameters - it simply strips the query parameter when looking for the file in the file system. Is nft also able to resolve these paths? I tried using nft why to experiment but it seemed like it couldn't resolve it with the error:
Error: Failed to resolve dependency ./pages/index.js?__sentry_wrapped__:
Cannot find module '/workspaces/sentry-nextjs-vercel-testproject/pages/index.js?__sentry_wrapped__' loaded from /workspaces/sentry-nextjs-vercel-testproject/test.js

Do you know if there is a workaround for us or something we can do here? We would also be ready to contribute upstream to support query params and fragments in import paths.

Do you know why this would be happening?

Looks like a bug. I confirmed Node.js will drop query string params for ESM imports (not CJS) so we need to fix @vercel/nft to resolve the same way.

We would also be ready to contribute upstream to support query params

Sounds good! Let me know when you have a PR ready and I'll take a look, thanks!

Thanks for taking a look! Just to make the process of fixing this a bit quicker would you be able to give a pointer where that logic would have to be added?

I don’t know off the top of my head. I would start by adding a failing unit test and look at the stack trace when the error is thrown.

Just chiming in as another one of the folks working on @sentry/nextjs.
I can't seem to replicated the error Luca mentioned above, either with ESM or CJS files, and with either yarn nft why or yarn nft print. That said, I did just push a PR fixing the problem which led to this issue being filed in the first place.

I would start by adding a failing unit test

I mentioned this in that PR, too, but I couldn't get a handle on how exactly one would do that. Would love some help in that regard, please.


Error executing pip3 install tensorflow-2.8.0-cp39-none-linux_aarch64.whl

Issue Type
Support
OS
Other
OS architecture
aarch64
Hardware
Other
Description
i have the problem describe in the tittle, when i execute pip3 install tensorflow-2.8.0-cp39-none-linux_aarch64.whl in my raspberry pi 3b +, with this especs
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
NAME="Debian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=debian
i got this message in the bash:
ERROR: Wheel 'tensorflow' located at /home/pi/Project/tensorflow-2.8.0-cp39-none-linux_aarch64.whl is invalid.
please help
i have install this dependencies before execute the command in a virtualenv:
pip list
Package             Version

h5py                3.1.0
Keras-Applications  1.0.8
Keras-Preprocessing 1.1.0
mock                4.0.3
numpy               1.22.1
pip                 22.0.3
pybind11            2.9.1
setuptools          60.6.0
six                 1.16.0
wheel               0.37.1
Relevant Log Output
$ pip3 install tensorflow-2.8.0-cp39-none-linux_aarch64.whl

ERROR: Wheel 'tensorflow' located at /home/pi/Project/tensorflow-2.8.0-cp39-none-linux_aarch64.whl is invalid.

Due to the high volume of download requests from around the world, my Google Drive has reached its download limit. Therefore, the file may not have been downloaded properly. I deleted the files on Google Drive and migrated them to Releases on GitHub, try the following.
cd Tensorflow-bin
git pull
sudo chmod +x tensorflow-2.8.0-cp38-none-linux_aarch64_numpy1221_download.sh
./tensorflow-2.8.0-cp38-none-linux_aarch64_numpy1221_download.sh

I repeated the first procedure and now i get this message from bash , because do directly in the repo clone doesnt work for me,
I am doing  the instalation in a virtual environment
sudo pip install tensorflow-2.8.0-cp39-none-linux_aarch64.whl
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Processing ./tensorflow-2.8.0-cp39-none-linux_aarch64.whl
Requirement already satisfied: setuptools in /usr/lib/python3/dist-packages (from tensorflow==2.8.0) (52.0.0)
Collecting keras-preprocessing>=1.1.1
Using cached https://www.piwheels.org/simple/keras-preprocessing/Keras_Preprocessing-1.1.2-py2.py3-none-any.whl (42 kB)
Collecting grpcio<2.0,>=1.24.3
Using cached grpcio-1.43.0-cp39-cp39-manylinux_2_17_aarch64.whl (50.1 MB)
Requirement already satisfied: h5py>=2.9.0 in /usr/local/lib/python3.9/dist-packages (from tensorflow==2.8.0) (3.1.0)
Requirement already satisfied: typing-extensions>=3.6.6 in /usr/lib/python3/dist-packages (from tensorflow==2.8.0) (<IP_ADDRESS>)
Requirement already satisfied: six>=1.12.0 in /usr/lib/python3/dist-packages (from tensorflow==2.8.0) (1.16.0)
Collecting flatbuffers>=1.12
Using cached https://www.piwheels.org/simple/flatbuffers/flatbuffers-20181003210633-py2.py3-none-any.whl (14 kB)
Collecting gast>=0.2.1
Downloading https://www.piwheels.org/simple/gast/gast-0.5.3-py3-none-any.whl (19 kB)
Collecting keras<2.9,>=2.8.0rc0
Using cached keras-2.8.0-py2.py3-none-any.whl (1.4 MB)
Collecting astunparse>=1.6.0
Using cached https://www.piwheels.org/simple/astunparse/astunparse-1.6.3-py2.py3-none-any.whl (12 kB)
Collecting tensorboard<2.9,>=2.8
Using cached tensorboard-2.8.0-py3-none-any.whl (5.8 MB)
Requirement already satisfied: wrapt>=1.11.0 in /usr/lib/python3/dist-packages (from tensorflow==2.8.0) (1.12.1)
Collecting tf-estimator-nightly==2.8.0.dev2021122109
Using cached tf_estimator_nightly-2.8.0.dev2021122109-py2.py3-none-any.whl (462 kB)
ERROR: Could not find a version that satisfies the requirement tensorflow-io-gcs-filesystem>=0.23.1 (from tensorflow) (from versions: none)
ERROR: No matching distribution found for tensorflow-io-gcs-filesystem>=0.23.1

I see. That went well. Please wait a moment. I'll fix the binary.

@davidto098
I've updated the wheel file. Try to download and install it again.

Thank you, finally I was able to install tensorflow successfully in raspberry pi 3b+, your great

Is it possible for older versions?


Lombok dependency is missing

After updating IntelliJ Lombok plugin to 0.12.16 I get:
10:21 AM Lombok Dependency is missing
Project "parent" does not seem to have lombok dependency added.
This plugin does not provide it and will not function correctly without.
Please make sure to add it manually and refresh your project.
Click here to see how to add it to your project.
This is a maven project with the parent pom.xml containing only maven properties and a modules section. The (child) modules do need Lombok, but the parent pom doesn't.
I added the dependency to lombok in parent pom.xml and the error went away.
Previous plugin versions did not complain about this. Do I really need to have the dependency to lombok in parent pom even if every child has it's own?
FYI: I erroneously reported this under the lombok project itself. Alexej gave some comments:
https://github.com/rzwitserloot/lombok/issues/1161

For the sake of removing need to check multiple issues for comments:

As for the immediate issue at hand - this is not needed to be in parent in your setup, but AFAIK we have no reliable way of finding out if its just a parent container project or if it has actual source code.
This feature has been added to the plugin as a lot of issues to the IntelliJ plugin kept being reported where users thought adding only plugin to IntelliJ is enough (even though our documentation clearly states Lombok itself is still needed). As it stands today, in the plugin config (Other Settings -> Lombok plugin) its possible to turn off some of the features in intellij, including version checks and run-time patching of older versions of IDEA. AFAIK missing dependency warning is a different check (prior to version) and could possibly be extracted.

As per my quoted comment above - we might want to consider extracting missing dependency check into configuration system OR making it smarter by detecting if the "parent" is actually containing any sources.

It also complained about missing dependency in a project which does not use lombok at all.

Also, please note that #263 tracks similar issue.

#266 Should allow you to disable the warning for the properly configured project

As #266 is merged and it fixes default settings (for some reasons "default is disabled" did not work) I will mark this as resolved.


fix(file-list): do not define fs.statAsync

Defining fs.statAsync affects other modules such as bluebird which
throws an error because of the 'Async'-suffix:

Cannot promisify an API that has normal methods with 'Async'-suffix
See http://goo.gl/MqrFmX

Fixes: https://github.com/karma-runner/karma/issues/3466

:white_check_mark: Build karma 2575 completed (commit https://github.com/karma-runner/karma/commit/3419c2ebd1 by @matz3)

retry

:white_check_mark: Build karma 2580 completed (commit https://github.com/karma-runner/karma/commit/26e7b27a80 by @matz3)

Ok so now the travis integration point is broken.  I will force this PR, and see if we get a release.


Expose enough information to for the async state instance to be useSyncExternalStore compatible

Well yes, the async state instance will become useSyncExternalStore compatible
it is already the case, we only need the getState method
may be source should also be useSES compatible ?

we should add a getState and subscribe functions (which already exists, should only be added, but they ll do chaos)

~some of it in #77


Suggestion : allow for js validations on form submission

This is not an issue but a suggestion.
I have many js validations on input forms, originally blocking submission with event.preventDefault() when conditions are not met.
I had to include a boolean condition submitValidate to support this validation :
submitForm = function (event) {
    var $form = $(event.currentTarget);

    if (!$form.is(options.blacklist) && submitValidate) {
             ...

Perhaps a variable (option ?) could be added, to access this validation without changing the code?

@VD17593 does event.preventDefault() not prevent smoothState from reloading the page?

Checked again.
Apparently  event.preventDefault()  doesn't prevent from reloading.
It doesn't prevent the reload for submit not for link klick,
so I added the following condition for the click event of a link too:
        clickAnchor = function (event) {
    	if (!event.metaKey && !event.ctrlKey && utility.shouldLoadAnchor($anchor, options.blacklist)
           && linkValid) {
                          ...


indentation: fix for BEGIN/END OF SCREEN

Fixes false positive when defining sub-screens with SELECTION-SCREEN BEGIN/END OF SCREEN and option "selectionScreenBlockIndentation": true:
SELECTION-SCREEN BEGIN OF SCREEN 100 AS SUBSCREEN.
  SELECTION-SCREEN BEGIN OF BLOCK b1.
    SELECT-OPTIONS s_repos FOR gv_repo.
  SELECTION-SCREEN END OF BLOCK b1.
SELECTION-SCREEN END OF SCREEN 100.

published as 2.93.34


Calling ProteinEntry.from_pickle().to_pdb(<target_path>) on the entire dataset reveals errors

Hi Liza,
I noticed when trying to create a W&B table visualization for the entire dataset that converting the pickle files into pdbs reveals multiple bugs.
Firstly, I got a "UnpicklingError: unpickling stack underflow" from the line "protein_entry = ProteinEntry.from_pickle(pickle_path)" It did not happen with every protein, so when I handled that exception I realized that PDBParser could not properly parse a few of the generate pdb files, throwing out an error in the line "structure = parser.get_structure(pdb_id, target_path)"

Could you please attach an example file that this fails on or say its pdb id @ardagoreci ?


Add option to 'compress' GeoJSON result into single feature

Currently when a time series is requested as GeoJSON output, the result is structured as a FeatureCollection where each feature in the collection is the same feature at different time steps. Each feature also includes it's own distinct geometry.
I propose that we have an option that would allow the user to instead get back only a single Feature where the properties of that feature contain all the fields requested by the user but as a list instead of a single value.
This would save a lot on the size of the returned GeoJSON object for long time series results which would help with both egress cost and individual request latency.
Example:
{
    "status": "200 OK",
    "time": 458.179,
    "hits": 3,
    "results": {
        "csv": "",
        "geojson": {
            "type": "FeatureCollection",
            "features": [
                {
                    "id": "0",
                    "type": "Feature",
                    "properties": {
                        "reach_id": "73282400171",
                        "time_str": "2023-07-28T22:10:37Z",
                        "wse": "211.178",
                        "slope": "-0.0007516914999999999"
                    },
                    "geometry": {
                        "type": "LineString",
                        "coordinates": [...]
                    }
                },
                {
                    "id": "1",
                    "type": "Feature",
                    "properties": {
                        "reach_id": "73282400171",
                        "time_str": "2023-09-08T15:40:49Z",
                        "wse": "82.082",
                        "slope": "-1.0184e-06"
                    },
                    "geometry": {
                        "type": "LineString",
                        "coordinates": [...]
                    }
                },
                {
                    "id": "2",
                    "type": "Feature",
                    "properties": {
                        "reach_id": "73282400171",
                        "time_str": "2023-09-29T12:25:52Z",
                        "wse": "206.49349999999998",
                        "slope": "-0.0007833485000000001"
                    },
                    "geometry": {
                        "type": "LineString",
                        "coordinates": [...]
                    }
                }
            ]
        }
    }
}

Would instead become:
{
    "status": "200 OK",
    "time": 458.179,
    "hits": 3,
    "results": {
        "csv": "",
        "geojson": {
            "type": "FeatureCollection",
            "features": [
                {
                    "id": "0",
                    "type": "Feature",
                    "properties": {
                        "reach_id": ["73282400171", "73282400171", "73282400171"],
                        "time_str": ["2023-07-28T22:10:37Z", "2023-09-08T15:40:49Z", "2023-09-29T12:25:52Z"],
                        "wse": ["211.178", "82.082", "206.49349999999998"],
                        "slope": ["-0.0007516914999999999", "-1.0184e-06",  "-0.0007833485000000001"]
                    },
                    "geometry": {
                        "type": "LineString",
                        "coordinates": [...]
                    }
                }
            ]
        }
    }
}

In practice we would have to use the geometry from one of the entries in the database but I don't think it is too important which one is chosen.
@torimcd @cassienickles interested in your thoughts on this.

General consensus is yes, this feature is useful. Users want to retain ability to choose which return format is returned

Consider 'compact' instead of 'compress' as the name of the variable because compress is generally associated with compression algorithms like zip or bz.
Also, need to add documentation section describing how we handle the 'properties' object for features returned from hydrocron. The GeoJSON RFC specifies that 'properties' can be any valid JSON object (https://datatracker.ietf.org/doc/html/rfc7946#section-3.2). So, it is up to us to describe to end users how that object is structured.

@frankinspace - Do you think we should return a compact response for cases where the Accept header is application/geo+json? Reading the RFC it seems like this might still be valid GeoJSON? If so it might be nice to allow the user to return the compact version of GeoJSON.

Good idea, yes agreed. I was thinking we would wait to make compact the default when we update to v2 of the API because it's technically a breaking change to the API (changing the format/schema of the returned object would break clients).
But, since the application/geo+json is a new feature I think we can start with compact being the default, then transition the json response to default to compact with the V2 upgrade


Explicitly include button styles for the email survey submit button

The send button in the email survey UI used the ".button" class to get the
styling defined in helpers/_buttons.  Unfortunately this styling is not
included in all layouts that an app might request from static.  For example
it is included in the static layout, but not the header_and_footer_only or
core_layout.  This means that only some frontend rendering apps will style
the button correctly.
Instead we explicitly include the button styling mixin in the css for a
button in the user-satisfaction-survey in helpers/_header.  This helper
is included in all layouts so all frontend rendering apps will style the
button correctly.
For: https://trello.com/c/dfSufy85/114-develop-a-new-survey-delivery-method

@h-lame can you let me know the best way to test this? E.g. which pages I should check etc, will be helpful when it gets deployed too.

One example is that currently the button for email surveys is green on pages rendered by frontend (e.g. https://www.gov.uk/access-to-elected-office-fund:

).
but not on pages rendered by manuals-frontend (e.g. https://www.gov.uk/guidance/the-highway-code:

).
After merging the integration versions of the manuals-publisher page should render a green button.
Note that the survey is due to stop at midnight on Monday, so testing will be hard after that (not impossible, just hard).


Ptp

It looks like this PR incorporates a lot of code from https://github.com/stm32-rs/stm32-eth/pull/77 which is under a different licence (Apache 2 vs 0BSD here), so probably shouldn't be merged as-is.
I think either have stm32h7xx-hal depend on stm32-eth (if/once that PR is merged), which I think is the best choice, or acknowledge the source of the code with a copyright header in those files and an update to the main stm32h7xx-hal README and Cargo.toml about the multiple licences and other authors.
If it's possible for @datdenkikniet to agree to relicense the code 0BSD that could also work, but they should have been asked first, and they would still need acknowledging since they're not in the git commit history this way.

In the medium-term it would be great for stm32h7xx-hal to depend on stm32-eth, although that requires the resources for https://github.com/stm32-rs/stm32-eth/pull/77 to be finished, tested and merged.
Incorporating parts of that code without acknowledging the license is of course not a solution. I would agree that this PR can't be merged as-is and ideally there would be a reference to the original code in a header or otherwise asap.

I've asked permission from @datdenkikniet and they have agreed to relicense the code to stm32h7xx-hal under 0BSD. I have added the relevant acknowledgement headers in the appropriate files as requested by them as well. i believe there are more changes that need to be made before merging, but hopefully this means that this PR can get merged after that @adamgreig @richardeoin

Confirmed! The bits of code reused in this PR are relicensed under 0BSD (new bits, too, so long as I've authored them. I can't speak for authors other than myself, but AFAIK we're not touching any of that here). We discussed and this seemed like a reasonable approach :)

PR is ready for review


Notify when gpus can not be found

Instead of silently failing when 1 or both gpus are not found instead notify the user that they could not be found.
This is helpful if gSwitch is installed on a computer without dual gpus or if apple eventually uses a different vendor for the dgpu and gswitch doesn't account for it yet.

added


support collection based storage for resume tokens

Hope this is OK for a first shot at it...
The functionality is controlled by populating the 'resumeTokenCollection' property in the config file. If the string value is left empty the file based resume token functionality will be used, but if a value is provided it will use the collection based storage instead.
The collection will be automatically created if it does not already exist.
As collections names must be unique in a database I've taken the liberty of using the collection name for the _id therefore making use of the automatic index on the field to save creating additional indexes and storing more fields in the source database than necessary.
I haven't implemented the removeResumeToken() function as I noticed it wasn't being called in any of the code base - I can easily add this if required but I didn't want to add dead code unnecessarily.
Let me know if you have any suggestions/changes or would like it implemented in a different manner.
Thanks!
fixes #41

@g2valdez @AndrewVDP @badavis  Any objections to getting this merged, and switching our own setup to use Mongo-based storage? Seems it would help address a big sync pain point.

@lordjabez  No objections to merging. I would avoid this in our own setup given that we already have a volume configured in helm to handle the resumeTokens and our original intent was to keep mongo-stream as a read only service.


Added name: Darshan Kasundra

Tried to resolve conflict but didn't work. Please help.

@Darshan-Kasundra it looks like you fixed the merge conflict correctly once, and then we merged more things so it came back 😆
I've fixed the merge conflict now, and will merge your PR. Nice work!


Overhaul Transform2D documentation

Continuation of https://github.com/godotengine/godot/pull/87334 but on the 2D side.
This PR aims to overhaul the Transform2D type's documentation.
The reasoning and changelog are extremely similar to the "Overhaul Basis documentation" PR, so I'm not sure I should bother repeating them twice.
A lot of wording is ripped straight from Transform3D and Basis's descriptions, with a few exceptions:

A lot of things have to be "rerouted" to explain them on the spot, rather than point to Basis, because there's no Basis2D Variant type.
basis_xform_inv was reworded quite a bit because it was very, very awkward.

Thanks!


Feature/fedn 256

mnist-keras example has been updated with data partitions
Summery:

create_data_partitions.py to split mnist.npz into N partitions inside data/clients
Settings for training_samples and test_samples has been removed in settings.yaml and train.py ,validate.py and read_data.py have been updated accordingly.
docker-compose.yaml for deployment of two clients has been updated to support different data partitions, i.e two containers are created with different volume mounts (--scale removed)
README has been updated with the new changes

Comments:
Tested with docker-compose setup for FEDn(develop) using three clients

Obs 3 new commits since reviewed by @ahellander  and @carmat88

@mattiasakesson If you have some time, any inputs, ideas and/or comments about the above code is very welcome. Thanks!

Looks good,
a minor question: Isn't the src/data/read_data.py script redundant now when the data is pre partitioned?

Looks good,
a minor question: Isn't the src/data/read_data.py script redundant now when the data is pre partitioned?

@mattiasakesson No I don't think so, read_data.py act as a pre-processor for the data. Though, I don't now why it is in a "data" directory. Is this some common structure that we have for the package? This is not where the data will be stored once the package is extracted, it will be in a separate data folder?

Looks good,
a minor question: Isn't the src/data/read_data.py script redundant now when the data is pre partitioned?

@mattiasakesson No I don't think so, read_data.py act as a pre-processor for the data. Though, I don't know why it is in a "data" directory. Is this some common structure that we have for the package? This is not where the data will be stored once the package is extracted, it will be in a separate data folder?

You are right, the pre-processing part could be done before the data partitioning also? But this is also ok. I think it is the cookiecutter structure way of organize the code.


PHPLIB-662: Unified test runner should error for unexpected operation arguments

https://jira.mongodb.org/browse/PHPLIB-662

@aleksandr-rudo: I noticed in https://github.com/mongodb/mongo-php-library/pull/896 that you manually applied the same suggestions I left. In case you're not familiar with the feature, take a look at applying suggested changes (that may save time for this PR).
You can batch them up so that they apply in a single commit, which will then be immediately tested by CI. If you need to continue development on the branch locally, you'll want to pull down changes from your remote fork first, though. And at merge time, we can always squash the commits and ignore the "Suggestions from code review" commit(s).


AttributeError: 'stringzilla.Strs' object has no attribute 'extend'

Hi again,
Just to let you know; this happens in prep_parquet.py while trying to read smiles from multiple files as in REAL.
Am I doing it wrong or the API has changed?
lines.extend(file_lines)
^^^^^^^^^^^^

AttributeError: 'stringzilla.Strs' object has no attribute 'extend'

@h4RkhW8t53e, the StringZilla API has changed. Can you check if it works with StringZilla v2 or v1? If so, we need to patch the requirements.txt.

Thank you for your quick reply! prep_parquet.py works with StringZilla v1 (1.2.2) and
file = Str(str(File(os.path.join(dir, filename)))) instead of file = Str(File(os.path.join(dir, filename))).

Great, thank you @h4RkhW8t53e! Can you please patch those?

Hi, a patch is attached. Would it be possible to update prep_parquet.py and prep_smiles.py to use Stringzilla v3 instead?
sz_v1.patch

Hi @h4RkhW8t53e! Any chance you could submit it as a PR?
Sure, I will look into upgrade options soon, when I publish the new embeddings you've suggested - already working on them 🤗


This is telling me I need to use //unprotect on last test all the rest pass. If I had an infinite it would stop me before the other test started

Challenge Smallest Common Multiple has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

function smallestCommons(arr) {
  var smallest = (Math.min.apply(null, arr));
  var largest = (Math.max.apply(null, arr));
   var scm = 0;
   var x = true;
   var newArray = [];

   for(var i = smallest; i <= largest; i++){
    newArray.push(i);
  }
    while(x){

      scm++;

    for(var j = smallest; j <= newArray.length; j++){
        if(scm % j !== 0){
          break;
        }
     else if (j === newArray.length){
        x = false;
      }

      }
  }

  return scm;
}

smallestCommons([23,18]);

I have passed all the test but the last one which tells me I could have an infinite loop. I have tested and made sure that my numbers being used are [ 18, 19, 20, 21, 22, 23 ] and that it is pulling the smallest and largest. And by the way I have tried the chat rooms and no luck getting an answer anywhere.

Refer https://github.com/freeCodeCamp/freeCodeCamp/issues/15079, please do not open duplicate issues. You can continue on the other thread instead.


Couple of improvements to using a separate bench_repo

1.Skip installing opam dependencies of the repo when using separate bench_repo
2. Ensure cached bench_repo is used only when the bench_repo has no changes. We use the GitHub refs API to see if the repo has changed, to decide whether to use the cached bench_repo or make a new clone of it.  The trick here is from this GitHub issue comment.
3. Support specifying a specific branch of the bench_repo to use for running the benchmarks.  The branch can be specified using the /tree/<branch-name> suffix in the bench_repo URL.

I think we can ship with the FIXME regarding github assumption for the time being, and add an issue to git clone properly from other sources afterward

Yes, I agree. That was my intention too, with adding the FIXME.

Thanks for the review and the merge, @ElectreAAS!


Improve browser support

Using styled-components.com as an example, page rendering looks a bit spotty? I have similar experience with my own code using styled-components when tested on my Mac using the VirtualBox VMs provided by Microsoft. What are other people experiences? Is a polyfill needed?

Browser screenshots powered by BrowserStack

It's interesting that it doesn't render on ID at all, not sure if that's a thing we messed up or react or something. Do you have access to logs in the console of those browsers? Let's get that support up!

Right it's due to missing Symbol on IE. We're not using it, but postcss is using for (let x in y) and babel transpiles that to something that uses Symbol.
There's a small core-js symbol polyfill we should be able to use: https://github.com/zloirock/core-js/blob/v2.4.1/modules/es6.symbol.js
...but I won't get to that till tomorrow at the earliest. The real solution would be to change postcss to not use those loops, but that might be a while before I can do that one.

I updated my example app to make it easier to test on the BrowserStack snapshots page Microsoft hosts and explicitly imported symbol from core-js at the top of my entrypoint (I think create-react-app might already be including it, but just to be sure). No luck, but maybe test doesn't remedy the need for Symbol deeper into the dependency tree?

Turned out to be easier than I thought. Pushed PR #91.

Thanks @geelen and @mxstbr! I confirm that my example app now renders on IE11. I assume the browser compatibility matrix for styled-components doesn't include IE10 or earlier since Microsoft isn't supporting these browsers on the desktop anymore themselves (with the exception of IE9 on Vista which will be EOL'ed April 2017).
Nevertheless, I'd be curious if any older versions of IE could be supported with a polyfill and think it would be helpful to have a sentence in the README communicating the browser compatibility targets.

Nevertheless, I'd be curious if any older versions of IE could be supported with a polyfill

Is there any errors in the console for earlier versions? What's missing?

I downloaded an IE10 VM and dug deeper to find the issue, but someone else beat me to posting it and submitted #107. :)