[Hotfix] Rewrite force_archive script [OSF-7921]

Purpose
Expand/improve functionality of scripts/force_archive.py
Changes

Rewrite script as management command
Improve behavior

Side effects
None expected
Ticket
[OSF-7921]

There are a number of flake8 errors in force_archive.py. I've unignored osf/management in our flake8 config, so if you update with master, you'll be able to lint the file.


Zip file in node package

I've just installed hyphen locally and noticed that there is a file named hyphen-1.3.1.tgz within the directory of the node package. I guess it was added by accident.

Very thank you for reporting that! I published a patch 1.5.1 to fix it.


As a developer, I want to make a initial migration, such that our database and schema is created

User Story
As a developer, I want to make a initial migration, such that our database and schema is created
Description of the solution you'd like
By migration our program, it will create a schema of our model classes, and make a database
Definition of Done

[x] run "dotnet ef migration add InitialCreate"
[x] run "dotnet ef database update"

Addition this was the step that made it possible to run "dotnet run". And with that there came a bit of debugging.


Increase Slack community member count to 1000

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2724
Originally created by @DouweM on 2021-04-23 15:48:22

View 3 previous comments from the original issue on GitLab


Add root/sudo check to run_me.bash

This adds a check to ensure the run_me.bash script is executed with the right permissions.

Ah, as usual @tatokis is right. Good thing I did separate PRs! :sweat_smile:


fix(asurascans): remove has_permanent_chapter_url

Unfortunately not all chapters on asura support permanent url's so some chapters break if this is enabled
This also means read history will be lost if asura rerolls the random int prefix (which they have been doing frequently) on the chapter url's as that will change the chapter id

fix(asurascans): remove has_permanent_chapter_url
chore(asurascans): bump version

Checklist:

[x] Updated source's version for individual source changes
[x] Tested the modifications by running it on the simulator or a test device

is there no way to selectively detect if a chapter supports it? :(

is there no way to selectively detect if a chapter supports it? :(

Not that I'm aware of, the chapters that support it and don't look identical in the HTML. The only way to tell, is to actually request the chapter page and see if it returns 404 or 301


Add tests for loadFile

Extracted from https://github.com/natecraddock/ziglua/issues/64
There may be one or two other functions not tested...

Fixed in 32ca8e4d53edd4e3d78e6ab9aeedc3d15a3f1cbc


Standalone Loggregator does not have the RLP on log-api

I think the name "log-api" is more descriptive than "reverse_log_proxy" for a VM name. I think we should collocate the RLP with the TC on the log-api VM. We can do it now with now downtime concern.

I'm moving this to loggregator-release


Update Lib/os.py

Update Lib/os.py as cpython main
Implement io.text_encoding (partial implementation for PEP-5907)

Could you please rebase this branch on a fresh copy of main? The CI issues should now be fixed.


Codify how to remove TreeArtifact base directories in pkg_files

We often have TreeArtifacts (directory artifacts) that are built to be installed
directly onto the filesystem in packages, but their names are often not correct.
They, thus must be renamed.  There are two ways to do this after we submit #319.

Rename the TreeArtifact to the destination
Rename the TreeArtifact to nothing

I believe that (2) is clearer, as the prefix provided to pkg_files stands
out more than an entry in renames.  This change codifies a workaround we have
tried out internally -- renaming to "nothing".  "Nothing" in this case, is the
constant REMOVE_BASE_DIRECTORY.  (1) is still allowed.
This change does not attempt to do anything related to updating paths inside
TreeArtifacts.  This will be attempted in a follow-on change.
Tests and documentation updates are also provided.
This change also moves the common analysis test boilerplate to its own location
in pkg/tests/util/defs.bzl, where it will be more generally accessible in
future changes.
Partially resolves #269.

I'm sorry I missed this one.

No worries, thanks for taking a look!


Remove use_random_flen command line parameter from derive_mirror_rnda

The tool derive_mirror_rnda requires to set --use_random_flen and --random_flen float, although there is no functionality for random_flen without use_random_flen.
Remove the use_random_flen flag and replace by a check for not None of random_flen.
Motivation: simpler and less code / command line parameters.

Wait, now that I looked into it, it is not that simple.
One can set use_random_flen without setting random_flen and then the simulation will run using random focal length based on the random_focal_length value already in the model. The use of the argument random_flen is to replace the value of random_focal_length, but it is not always necessary when using random focal lengths.
This is to say, we cannot make the simple change of
use_random_focal_length=args_dict["use_random_flen"]```

to
use_random_focal_length=args_dict["random_flen"] is not None```

because this would remove the functionality of simulating using the random focal length defined in the model (Gaussian distribution around that value, but never mind).

OK, I wasn't aware of this and I see that this is also actually a use case on how to use the application.
This means we keep everything how it is and close this issue. Thanks!


Tables are created but no data inserted

I received the message "No new or modified records found".  However, all of the data contained in the Salesforce objects selected appear on the page.

Unfortunately, I'm no longer maintaining this project. It may be worth checking some of the forks people have created. Thanks


NuGet claims <Net5.0 support on Release 2.0.2

Hi folks,
NuGet still claims NetStandard2.0 and NetCore3.0 support for Release 2.0.2, a whole day's tinkering with NetCore3.1 and it doesn't seem to work and it looks to me that >=Net5.0 is already a requirement? I eventually found issue #246 which stated the aim to remove NetCore support - We therefore push forward with .NET 5 as requirement - but this looks like it was closed after 2.0.2?
Can I just have confirmation if 2.0.2 is meant to be supporting NetCore3.1?
If 2.0.2 is not supporting that version can the NuGet page be changed please?
Cheers!

@yeroc-sebrof NetStandard2.0 was dropped after the release. You can verify it by looking at the tag for v2.0.2 or the commit history of master


Refactor Utils class to create ShutdownHookManager (branch-1.4)

Branch: branch-1.4
Fix issue with log4j being initialized too early.  Custom spark class loader is not set on thread context preventing the use of custom appenders and layout engines in log4j.properties.
As discussed here:
http://apache-spark-user-list.1001560.n3.nabble.com/log4j-custom-appender-ClassNotFoundException-with-spark-1-4-1-tt24159.html

Can one of the admins verify this patch?

I didn't compile all profiles..  I'm trying out -Pyarn and -Phadoop-2.6 as we speak..

I'm closing this PR and following the spark contribution process


Allow for exe/dll paths for the Icon setting

Summary of the Pull Request
Allow exe/dll paths for the Icon setting
The exe/dll icon needs to work in all the following areas:

[x] The tab
[x] The navigation view item in the SUI
[x] The new tab flyout
[x] The command palette

PR Checklist

[x] Closes #1504
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
For the command palette, we had to switch to using ContentPresenter because IconSourceElement cannot take in every type of icon we need to provide
Validation Steps Performed
Setting "%SystemRoot%\System32\shell32.dll,214" as the icon for a profile works in all the cases listed above.

Taking over this feature since @zadjii-msft is going to be OOF for a while. Currently have it working for everything except the command palette, which is proving to be quite annoying because we cannot just declare an IconElement in xaml, we have to specify a child class of IconElement such as IconSourceElement / FontIcon or the like, which each take in a specific source type (whereas we need to be able to use both IconSource for the old icon paths and SoftwareBitmapSource for the new icon paths)

font icons are now tiny, here and in the SUI.

Thanks for the catch, fixed now!

@mstbot merge this in 10 minutes

@msftbot merge this in 10 minutes

Which version will this be released in?

The next release will be 1.17 Preview. No specific ETA on that yet - it'll be done when it's done 😉


CMRI data is now available via OASIS. Can you please add Capacity Testing data set WEIM_RSE_CAPACITY_TEST?

WEIM_RSE_CAPACITY_TEST is the dataset we are looking for now that CMRI source is no longer providing the same data.

are you speaking about this dataset?

Yeah, that is it! CMRI is no longer providing that info and OASIS has it as shown in that screenshot. Is it doable? Two other sources stopped showing up in CMRI. Hunting the dataset name.


High memory usage

When generating a report for a profiling that hit the probes many, many times, the ram usage goes very high (> 10 Gb).
Thanks to fix this issue.

Hi @antoyo ,
This in an inherent limitation of python runtime (the number and footprint of objects created for representing samples). One solution is to use the txnFilter callback in your profileInfo.py to filter out transactions not of interest. This would reduce the amount of transactions processed.  Can you give it a try please ?
Thanks
Mani

Is there a way to lower the sampling (I thought it was the goal of the -H option)?

Yes, the snippet in your comment would work.
However, If you would like to even avoid capture or strictly control the samples captured, it can be done using the c++ embedded profiling API.
Here is an example of an app using embedded profiler. The profile method lets you switch profiling on/off in a scope and thus can be used to capture only what's desired.

That does not seem convenient to use this API.
It would be nice to have a way outside the application to sample the probes.
Using a filter does not help much because the extractor still loads everything.

Agreed.
Xpedite works on the concept of transactions (a collection of probes, that measure something meaningful). So sampling at probe level won't make much sense. If that's what is required, there are tooling that already accomplish that well (linux perf, Intel vtune). So I assume, we are talking about sampling transactions.
We also don't want to run any sampling logic in critical path, since that can add more overhead due to profiling. This could be done post processing in the Samples loader.
This would require enriching the samples loader to pick a subset of txn samples, from those captured. Or picking only transactions that exceed a latency limit. However we don't have that capability currently.

Hello, I've been trying to test out integrating Xpedite into my application over the past few weeks. Recording seems to work efficiently with reasonably large numbers of transactions (hundreds of millions), but the analysis infrastructure totally falls over when digging into the data (takes on the order of hours and uses hundreds of gigabytes of RAM). Is this an expected limitation of the python infrastructure given your usage of xpedite profiling? I'm wondering if I'm using the toolset incorrectly or if it's really only intended to be used for smaller sampling periods.

Hello, I've been trying to test out integrating Xpedite into my application (one you may have heard of :) over the past few weeks. Recording seems to work efficiently with reasonably large numbers of transactions (hundreds of millions), but the analysis infrastructure totally falls over when digging into the data (takes on the order of hours and uses hundreds of gigabytes of RAM for a 1.6 gigabyte samples data file). Is this an expected limitation of the python infrastructure given your usage of xpedite profiling? I'm wondering if I'm using the toolset incorrectly or if it's really only intended to be used for smaller sampling periods.
Some output of report generation from a < 5 minute benchmark run with [12701853 transactions]

Thank you for  the details. This is a known issue for us. The python object model currently doesn't scale with millions of transaction. One stop gap solution to get around the scaling issue is to use txnFilter, to filter out uninteresting transactions.
The section in your report that runs for unspecified time is the bit that's creating the jupyter notebook. since we don't have visibility on it's implementation, we don't log % of progress there.
creating xpedite data directory /tmp/xpedite22r_wb5u/xpData
generating notebook redline-inrush.exe-2021-08-07-18:07:05.ipynb ->

We are actively working on a solution for the scalability issue. The Idea is to port the implementation to C++ with pybind11. The first pull request the enable pybind11 is under development. Over the coming weeks, we will move more and more of the object model from python to C++ to provide better scalability.
Hope this helps.

Thank you for your response!

One stop-gap solution to get around the scaling issue is to use txnFilter, to filter out uninteresting transactions.

I was able to get meaningful information out of my benchmarks by applying filters to remove uninteresting transactions, but it leads to an awkward workflow for me. That said, I can keep pushing forward with this as-implemented to see if I can get to a point where Xpedite can add value for us :)

The section in your report that runs for unspecified time is the bit that's creating the jupyter notebook. since we don't have visibility on its implementation, we don't log % of progress there.

The Idea is to port the implementation to C++ with pybind11. The first pull request the enable pybind11 is under development. Over the coming weeks, we will move more and more of the object model from python to C++ to provide better scalability.

That sounds like a reasonable approach :) looking forward to testing it out when it's all in place!
I might be getting off-topic for this issue, so please let me know if you'd like me to ask this elsewhere.
I've been experimenting with Xpedite's support for top-down microarchitecture analysis, and I'm struggling to figure out the set of steps I need to take to drill into Topdown nodes that require more than 8 simultaneous performance counters. Is there a short guide for doing this available in the repo somewhere that I could take a look at (no worries if not, I can keep scrubbing through the python code to try and figure out my approach)?
I have played around with toplev a bit in the past with some success, but it abstracts the end-user from the complexities of trying to multiplex performance counters (either during program execution or across benchmark runs). I haven't seen anything like this in Xpedite, but I might be missing something in my read of the python code. If you have any tips for performing top-down analysis with Xpedite, I'd really appreciate them!
Thanks,
Bobby McShane

Sorry about the delayed response.

I've been experimenting with Xpedite's support for top-down microarchitecture analysis, and I'm struggling to figure out the set of steps I need to take to drill into Topdown nodes that require more than 8 simultaneous performance counters. Is there a short guide for doing this available in the repo somewhere that I could take a look at (no worries if not, I can keep scrubbing through the python code to try and figure out my approach)?

Topdown is implemented in a different way in Xpedite.
Xpedite is not a sampling profiler, instead it lets you define transactions and build statistics / plots for a set of transaction.
In addition the focus is on drilling down to one or more transactions based on topdown / counters and looking at them in detail.  For example, we might want to compare our outlier transactions (95 or 99%ile) with our median transaction etc..
With this design, it's not feasible to multiplex performance counters, when the number of counters exceed the available combination of fixed + general purpose registers. The reason being, transactions are quite unique. They can execute different number of instructions and suffer from different bottlenecks. We may not get meaningful data by by multiplexing performance counters for different transaction and trying to combine them. It might also break the topdown ratios (may not add up to the expected %). Hence we don't support pmc multiplexing. This is represented by colors in the xpedite topdown command. If you run it in console, it will print the tree for the current processor architecture. The nodes that are not supported will be printed in red.
Thanks
Mani

Thanks, Mani. I agree that multiplexing performance counters over the course of a single program's execution wouldn't make sense for our type of low-latency financial workloads which can be bursty or have fairly variable execution paths for each transaction. That said, I have a very deterministic benchmarking setup that consistently shows the same microarchitectural bottlenecks for my outlier transactions. I was hoping that Xpedite could multiplex the counters across benchmark runs to help me drill down on the true bottleneck.
I have successfully done something similar with toplev in the past by passing the --no-multiplex parameter. On second look, I may have mistakenly used the word "multiplex" here which could be leading to some confusion. I am really looking for a way to correlate counters across benchmark invocations rather than varying the set of sampled counters within a single benchmark.
All that said, it sounds like this isn't supported by Xpedite today (which is totally fine). Your response was helpful regardless in that I don't need to keep digging through the python code to see if I'm missing something.
Thanks again,
Bobby


Change Github to GitHub

This is a little pet peeve of mine, just cleaning up the capitalization of H in GitHub. :)

Thanks so much @cassidoo! :)


Add support for scope regex in JWT filter

Please describe your use case / problem.
We have a very granular auth system that allows us to give or take permissions for specific actions. Each service has an auth layer, however, we like the possibility of enabling some auth in the gateway layer, features like token signature validation and expire date. We would also like to use scope validation. Our scopes are structured like user:read, user:update, user:create, etc. In some cases, there might be more than 30 different scopes in the same "group".
Describe the solution you'd like
We would like to define scopes by regex in the JWT filter. Following the example set previously, we could have a regex that is user:.* for the /user path.
Describe alternatives you've considered
Add every single scope in the scopes list. Keep it up to date when applying changes to the service.

This is a very useful and needed feature!
Describe the solution you'd like
Following the /user example, we could have an admin scope allowed to access this path


Add outage costs

This PR adds support for outage cost calculations on residential triplex_meters.
Current issues
None
Code changes

[x] Add a new cost class to the reliability module.
[x] Add global default_cost_type to specify the default cost types to consider.

Documentation changes

[x] /Module/Reliability/Cost

Test and Validation Notes

[x] Add reliability/autotest/test_cost.glm and reliability/autotest/test_cost_outage.csv.

There's a new circleci issue with this one....
gldcore 2.zip

There's a new circleci issue with this one....
gldcore 2.zip

Annoying and very rare intermittent problem not caused by this PR.  Please proceed.


Update docs regarding application support

We should add a citation/link to the DR-WG paper at the landing page for the AIRR Data Representations section.
Also, we should ping the authors in the Supporting Applications section and see if that table needs an update.

@javh I just opened a branch with an updated version of the main README.

Thanks!  I can check on the application status and update your branch accordingly. I mostly just wanted to remind myself we need to do these things...

Citation was added via #198.

closed as done


Add NewCguBuilder and WaitUntilComplete CGU functions

@trewest @achuzhoy @mpmaruthu  Hey, could you please review when you get a moment? Thanks

LGTM

Looks good to me.
/Peri M

pr looks good. Please add unit tests

Added unit tests and refactored functions.


Generate QZSS

I am making a QZSS signal.
The signal does not become the green used for positioning.
Please advise what should be changed.

It turns green when it is used in navigation. You never get valid 3D navigation fix with only three satellites.

How do I know if it's the correct signal?

Add GPS satellites.

If gps is added and qzss turns green, does that mean it's okay?

Plus you have to get proper navigation solutions.

Would you please send a pull request to add your QZSS signal generation code to the gps-sdr-sim? Your contribution would be greatly appreciated.

I tried receiving again.
Is this a success?

too bad values Residual


refactor: rename StateProvider structs

Made all StateProvider Impls have a consistent name.
StateProviderImplHistory -> HistoricalStateProvider
StateProviderImplLatest -> LatestStateProvider
StateProviderImplRefHistory -> HistoricalStateProviderRef
StateProviderImplRefLatest -> LatestStateProviderRef
Closes #639

Codecov Report

Merging #663 (bacc65e) into main (f5ae970) will not change coverage.
The diff coverage is 16.66%.

@@           Coverage Diff           @@
##             main     #663   +/-   ##
=======================================
  Coverage   71.99%   71.99%
=======================================
  Files         260      260
  Lines       26264    26264
=======================================
  Hits        18909    18909
  Misses       7355     7355

Flag
Coverage Δ

unit-tests
71.99% <16.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/storage/provider/src/db_provider.rs
100.00% <ø> (ø)

crates/storage/provider/src/lib.rs
100.00% <ø> (ø)

crates/storage/provider/src/db_provider/storage.rs
19.09% <9.09%> (ø)

crates/stages/src/stages/execution.rs
89.38% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Yeah that's what I thought as well re Ref. @rakita was there any reason?

I didnt want to drop transaction after Provider is done, so I made wrapper that takes Ref


Post Episode 156

Guest: Ray Law

Great to see you back! I have added NSBrief to my iOS-development-podcast repo. I would appreciate a mention of the repo on NSBrief and/or Twitter, as that helps more people find the repo, ultimately resulting in more listeners for the podcasts, my primary goal for the repo.

Of course! I have to admit I felt a little distraught when I first found that list and found NSBrief in the dearly departed section. I'll add a link to the notes and tweet a link out as well.


CXP-2071: [SPIKE] Refactor schema change handling callbacks to use committed offsets

The previous version of the feature was tracked in sugarcrm-jgminder/1.9.2-database-callbacks.
TODO:

[x] Create a feature branch in the SugarCRM's fork (database-callbacks), and retarget from the production branch.
[ ] Fix the existing test failures.
[x] Add more tests (CXP-2157).
[x] Make sure that this feature can be disabled via configuration (CXP-2156).

@morozov The tests fail because of the call to the "delete capture instance" stored procedure that doesn't exist. Having done CXP-2156 will fix the tests automatically.


build(module:*): strip internal-annotated declarations

PR Checklist
Please check if your PR fulfills the following requirements:

[X] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the new behavior?
Declarations annotated with @internal are not preserved in d.ts files.
An example might come from the PR https://github.com/NG-ZORRO/ng-zorro-antd/pull/3766
https://github.com/NG-ZORRO/ng-zorro-antd/blob/386b962792a1ea5b1003b4d93c46e7dd6c5774b1/components/table/nz-table.component.ts#L73-L79
As you can see, the viewChange field is used internally. There is no point in exposing it.
This will produce a cleaner public API.
Annotating with @internal means
 * ...
 * @internal
 */
viewChange = new Subject<ListRange>();

Does this PR introduce a breaking change?
[ ] Yes
[X] No

Good idea. We should use this annotation on many other functions or methods.

@vthinkxie remember this tag cannot be applied to methods and fields used in the template.
Anyway, you would notice, as an error would be spit out from the compiler.
Hope this won't be required anymore with Ivy as methods/fields for templates should not be part of a public API.


only warn when registry specified multiple times

When service registry was specified multiple times, there is no need to break the server creation. We can only ignore the duplication, give warnings, then continue to new the server.

/test all

/ok-to-test

/test e2e-pilot

@zhuguihua: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
1c1caf76df09479add5e2904c7d80a7d0bc3cbb6
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

/lgtm

@zhuguihua: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
d5ea50d65c7e9cda3a7fe96f2baa35b1d4455ac3
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@zhuguihua: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
d5ea50d65c7e9cda3a7fe96f2baa35b1d4455ac3
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@zhuguihua: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
d5ea50d65c7e9cda3a7fe96f2baa35b1d4455ac3
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pilot-e2e failed because of #2985


sbJson reader should not import short abstract

ScienceBase creates the short abstract from the first 300 characters of the full abstract.  Do not import the short abstract when reading sbJson into the mdTranslator.  see issue adiwg/mdEditor#145.

Also removed short abstract from sbJson writer.


[SPARK-10469][DOC] Try and document the three options

From JIRA:
Add documentation for tungsten-sort.
From the mailing list "I saw a new "spark.shuffle.manager=tungsten-sort" implemented in
https://issues.apache.org/jira/browse/SPARK-7081, but it can't be found its
corresponding description in
http://people.apache.org/~pwendell/spark-releases/spark-1.5.0-rc3-docs/configuration.html(Currenlty
there are only 'sort' and 'hash' two options)."

Merged build triggered.

Merged build started.

Test build #42084 has started for   PR 8638 at commit 4978681.

Test build #42084 has finished for   PR 8638 at commit 4978681.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42084/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #42088 has started for   PR 8638 at commit 0aada24.

Test build #42088 has finished for   PR 8638 at commit 0aada24.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42088/
Test PASSed.

LGTM, merging into master 1.5.


Add explicit tracking of pathogens of interest

It would be good to have a standard list of pathogens we look for in the workflow, with a standard way of presenting the results. We can use the select agent list and MA list of reportable pathogens as references here.

This might or might not be subsumed by our Q4 plans to enhance our list of reference pathogens, downweighting for now.

Update, no current plans to do this and unclear if it fits in the direction the v2 pipeline is developing. Closing this for now.


Migrate to Go modules

Go modules are easier to deal with and update, and helps to reduce the future growth of the repository size.

please run go mod vendor and commit vendor ...

Why vendor the dependencies when it's not necessary though?

diff easily

Well, if they decide that it's necessary for this to be merged I will, but I won't unless someone from the company explicitly says so, as I consider vendoring dependencies to be a horrid practice.


Timedelta string with hour value greater than 23 is not supported (breaking change)

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
In Pydantic v1, timedelta strings in the format HH:MM:SS with HH greater than 23 worked fine (i.e. the example code below works). This format is also supported by pandas.Timedelta by the way.
In Pydantic v2, the example code below fails with the following exception:
ValidationError: 1 validation error for MyModel
td
  Input should be a valid timedelta, hour value is outside expected range of 0-23 [type=time_delta_parsing, input_value='26:30:00', input_type=str]
    For further information visit https://errors.pydantic.dev/2.6/v/time_delta_parsing

As a workaround I have to change string to:

26:30:00 -> PT26H30M or 1 day 02:30
24:00:00 -> PT24H or 1 day 00:00

IMO, ideally HH:MM:SS with HH greater than 23 should be supported in Pydantic v2. Or at the very least, this should be documented as a breaking change in the Migration Guide.
Example Code
import datetime
import pydantic
from pydantic import BaseModel

class MyModel(BaseModel):
    td: datetime.timedelta

print(f"{pydantic.__version__=}")
assert MyModel(td="26:30:00").td == datetime.timedelta(days=1, seconds=9000)
assert MyModel(td="24:00:00").td == datetime.timedelta(days=1)

Python, Pydantic & OS Version
pydantic version: 2.6.0
        pydantic-core version: 2.16.1
          pydantic-core build: profile=release pgo=true
                 install path: /home/gbezerra/ipynb/.venv/lib/python3.11/site-packages/pydantic
               python version: 3.11.3 (main, Jun  7 2023, 13:51:08) [GCC 11.3.0]
                     platform: Linux-5.19.0-35-generic-x86_64-with-glibc2.35
             related packages: email-validator-2.0.0 typing_extensions-4.6.3 fastapi-0.83.0
                       commit: unknown

It looks like Pydantic (speedate) tries to parse Durations in the format HH:MM:SS as "Time", thus the 0-23 limitation.
Relevant code: https://docs.rs/speedate/latest/src/speedate/duration.rs.html#262-280.

@gusutabopb,
Thanks for reporting this. I'll chat with the team tomorrow morning + we'll decide if we want to document this change in the migration guide or if we want to change the behavior of speedate.

@gusutabopb,
Indeed - this is something that we want to support, and I don't think this change would be breaking in nature. Feel free to submit a PR adding support for this!

having this issue too, would be good to get it fixed.

I've added this to our 2.8.0 milestone!

@sydney-runkle I can take this one. But just to clarify, should the change be in pydantic-core or speedate  ?

@nix010 fantastic! I believe the fix would be in speedate for this one!

@sydney-runkle gotcha !

@sydney-runkle silly question ! we only want Duration to support format HH:MM:SS with HH in range 99..00 ?
101:20:20 is invalid and raise Err but 99:20:20 is ok ?

@nix010 I don't think there should be any arbitrary limit on the number of digits of the HH component.
pydantic/speedate with PT notation works fine with up to 6 digits HH components (it fails with 7 digits though)
from pydantic import TypeAdapter
import datetime

TA = TypeAdapter(datetime.timedelta)
TA.validate_strings("PT123H00M")  # datetime.timedelta(days=5, seconds=10800)
TA.validate_strings("PT123456H00M")  # datetime.timedelta(days=5144)
TA.validate_strings("PT1234567H00M")  # throws a ValidationError, "duration is too large"

I think the support for HH:MM:DD should behave the same as when using PT notation (i.e. no arbitrary 3-digit limit for HH).

@gusutabopb oh I didn't noticed that. But tbh they are different format. Let's see how does @sydney-runkle decide!

@nix010,
Hmm, I think we'd want to mimic whatever worked in V1. I can ask @davidhewitt on Monday what he thinks!

It looks like the V1 behaviour derives from Django, which itself derives from how Python's datetime.timedelta is formatted (using str(my_timedelta)).
However it looks like the datetime.timedelta normalizes itself to never have more than 23 hours (if it hits 24, it moves the value into "days"). So it's unclear to me whether Django accepted wider ranges deliberately or by accident.
@gusutabopb how are you generating these duration strings?

@sydney-runkle If you modify the code sample in the and run it in Pydantic v1 (I just tried with 1.10.15), it works fine for 3~11 digits.
>>> MyModel(td="123456789:30:00").td
datetime.timedelta(days=5144032, seconds=77400)

We hit an OverflowError at some point though:
>>> MyModel(td="99999999999:00:00").td
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "pydantic/main.py", line 339, in pydantic.main.BaseModel.__init__
  File "pydantic/main.py", line 1074, in pydantic.main.validate_model
  File "pydantic/fields.py", line 881, in pydantic.fields.ModelField.validate
  File "pydantic/fields.py", line 1098, in pydantic.fields.ModelField._validate_singleton
  File "pydantic/fields.py", line 1154, in pydantic.fields.ModelField._apply_validators
  File "pydantic/class_validators.py", line 337, in pydantic.class_validators._generic_validator_basic.lambda13
  File "pydantic/datetime_parse.py", line 248, in pydantic.datetime_parse.parse_duration
OverflowError: Python int too large to convert to C int

If Pydantic v1 compatibility is the goal, then there should be no arbitrary restriction on number of digits the HH component takes as suggested/asked by @nix010. Restrictions due to memory overflow, etc are understandable though.

@davidhewitt I don't think "by typing on my keyboard" is the answer you are looking for (it is the literal answer though), so I assume you're asking about my original use case.
I needed to schedule jobs to be run at a given time (offset) after a reference date (probably not relevant, but I'm using apscheduler). Some jobs were scheduled to run on the same date as the the reference date (e.g. offset = 14:30), while some were on the next day (e.g. offset = 26:30).
I use Pydantic mostly to validate configuration, and while migrating to Pydantic v2, I had to change dozens of time offsets in my config files (e.g. from 26:30 to 1d 02:30). This is not a big deal but still a breaking change from Pydantic v1 behavior and lead me to raise this issue.
Thinking in terms of greater-than-24 hours to indicate T+1 times is quite handy when dealing with timezones, UTC offsets, etc and is actually extremely common in some parts of the world.

Thanks, that's useful to understand.
I had a bit of a chat with the rest of the team, and we agreed that it does make sense to accept the v1 behaviour again. The format seems unambiguous, so while it's a little atypical to want to exceed 23:59:59 in this format, there's no good reason not to accept it.
That said, it looks like there's a workaround for now (even if it requires a bit of work), so we're unlikely to tackle this with any particular priority. If someone really wants this sooner than we can tackle it, a contribution would be gratefully accepted. 👍

ok! I will go ahead with the change.

@davidhewitt Hi, just curious so now the PR in speedate is merged. Does any changes needed on pydantic-core (or pydantic) also ? I imaging should be some dependancies version update!

@nix010,
We'll want to do a dependencies update in pydantic-core, but we'll have to do a speedate release first. I can handle that as we wind up for our 2.8 release this week :).
Thanks for your help here!

Marking this as resolved as the corresponding PR has been merged. For folks following along, we'll have this fix out hopefully by the end of the month.


Bot Skype in review

Bot Info

SDK Platform: Node.js
Active Channels: Skype,
Deployment Environment: Azure Bot Service

Issue Description
My bot is in Review since several weeks with no information, no message or mail.
Is this normal?

@Polaris-BS Please share the Bot Handle and Microsoft App Id, so we can escalate this to the proper team.

Yes :
Microsoft App Id : ad902637-9704-47a3-ada0-140809db6d6b
Bot handle : ByeAndUse

Thanks @EricDahlvang  !

No news ? It's in review , no change :/

@Polaris-BS On February 8th, the response was: "We currently have some backlog with the Bot reviews and hence the delay . Will review the Bot and share feedback ."
I've pinged the review team again.  Thank you for your patience.

Thx EricDahlvang .
My solution must be in production in 15 days. It's been 8 months since it's in development is all operational except the revision. Many investors are becoming impatient. My first revision date of November 2017 :/

The following is the feedback:
The bot must have links to a valid Privacy Policy and Terms of Use, currently its giving 401 error.
Bot avatar image must be with non-black and non-white background color, now it has white background.
Once customer has addressed these issues resubmit the bot again for review.

ok i will do the necessary


Slow with Arabic (esp vs fzy)

[x] I have the latest version of fzf
[x] I have read through the manual page (man fzf)
[x] I have searched through the existing issues

Info

OS

[x] Linux
[x] Mac OS X

Shell

[x] bash

Problem / Steps to reproduce
I appreciate that this is not a common use case however I have noticed that fzf is many times slower than fzy when searching Arabic (and fzy's results are quite good).
Dataset
wget https://dumps.wikimedia.org/arwiki/latest/arwiki-latest-abstract1.xml.gz
gunzip arwiki-latest-abstract1.xml.gz

fzf
$> time cat arwiki-latest-abstract1.xml | fzf -f 'هذه تجربة' | wc -l
    6427
real  0m3.425s
user  0m16.836s
sys 0m0.624s

fzy
$> time cat arwiki-latest-abstract1.xml | fzy -e 'هذه تجربة' | wc -l
    6479
real  0m0.389s
user  0m1.352s
sys 0m0.267s

+x +i --algo=v1 --literal really helps, but there remains a big difference
$> time cat arwiki-latest-abstract1.xml | fzf +x +i --algo=v1 --literal -f 'هذه تجربة' | wc -l
    6427

real	0m1.925s
user	0m2.761s
sys	0m0.494s

Thanks for the report.
I'm not familiar with the implementation of fzy, so I can't tell where the performance difference stems from, but here are a few observations.

Looks like most of the time is spent loading up the list. cat arwiki-latest-abstract1.xml | fzf and you'll see that it takes a couple of seconds until the loading is complete. On the other hand, fzy finishes loading much faster. I think the major difference comes from the fact that fzf was inherently designed to support streaming input, while fzy blocks until the input command completes.
for i in $(seq 100); do echo $i; sleep 0.1; done | fzf
for i in $(seq 100); do echo $i; sleep 0.1; done | fzy

find / | fzf
find / | fzy

There is much more work involved to support streaming, so I can imagine fzf is significantly slower than fzy in this scenario.

The search algorithm of fzf is particularly optimized for ASCII data.

https://github.com/junegunn/fzf/blob/6654239c94667fefb38d76cfc47b6abf5ced8149/src/algo/algo.go#L358-L362

Maybe we can apply the same optimization to non-ASCII data when --literal is set, but I haven't tried.

Thank you so much for the reply!
I'm sure streaming is playing a role, but it can't be the major cause, since the difference between fzy and fzf on https://dumps.wikimedia.org/enwiki/latest/enwiki-latest-abstract10.xml.gz is much less drastic.
$> time cat enwiki-latest-abstract10.xml | fzf +x +i --algo=v1 --literal -f 'All_article_disambiguation_pages' | wc -l
    7221
real  0m0.637s
user  0m1.036s
sys 0m0.235s

$> time cat enwiki-latest-abstract10.xml | fzy -e 'All_article_disambiguation_pages' | wc -l
    7222

real  0m0.335s
user  0m0.911s
sys 0m0.238s

Nice observation. So while streaming overhead definitely exists, it isn't the major factor in loading performance.
If a line only contains ASCII characters, fzf can load it as a byte array without any processing. But if it contains a non-ASCII character, fzf loads it as an array of 4-byte integers, unpacking Unicode code points from the original byte array. So there is significant memory and computational overhead.
https://github.com/junegunn/fzf/blob/6654239c94667fefb38d76cfc47b6abf5ced8149/src/util/chars.go#L46-L63
Maybe we can somehow avoid the extra processing as much as possible with some tricks. I'll see if there's any room for improvement when I get some time. (FWIW, I mostly use fzf with ASCII input, so this has never been an issue for me.)

Awesome, thank you! Yeah, it's a bit of an untypical use case.  However, all the unique features of fzf make it a powerful multi purpose search tool, so this use case might start becoming a bit more common.

Has there been any more insights into this? It sounds interesting as it might affect search speed in Japanese text as well, for example? :)


Deleting localization bits creates error on Net Core

On an ASP.NET Core application using Fluent Validation all the localization folders (fr, pt, ...) are added to the output when building. But by removing those folders manually as suggested on the Wiki the application will give an error on start.
Is there a change to split Fluent Validation and Localization into two different libraries?

No, sorry - they're going to stay in the same package. See the discussion here: https://github.com/JeremySkinner/FluentValidation/issues/254
Deleting them should work just fine though. What error are you seeing?

@JeremySkinner I think I solved that part and the error was due to something else.
Did you try the following with ASP.NET Core:
`

false

`
I am asking this because the files are still copied ...

@JeremySkinner In fact there is a problem by removing the culture folders from Fluent Validation. After I did that I get an error on the application I am hosting on Azure:
502.5 > Application Failed to Start

I then added the localization folders and the application starts again ...

How are you deleting them?

I am deleting the folders before sending to server since the tasks on Wiki don't seem to work on the new csproj Asp.Net Core format

I really don't see how those folders being removed would cause an error on the server as they aren't required in any way. Can you get more details on the error? Can you reproduce locally?

It is strange but I just tried something else: deleted the folder on Azure, restarted the application and I got the error. Then I added the folders again, restarted the application, and now it works.

I tried to run the application as Development instead of Production and I get the same error when I remove the Fluent Validation localization files but I am not able to see the error details ... Just the error I mentioned before.

Was that locally or on azure too?

On Azure to

Can you reproduce locally?
To be honest this really doesn't sound like a FV it's probably something to do with the combination with azure, aspnetcore and localisation assemblies, in which case you'd be better off talking to someone on the aspnetcore team. I'd be tempted to just leave the assemblies there - having them in place doesn't have a negative impact in any way.
Good luck

In case anyone comes across this old thread: Since FluentValidation 7.0, the localization approach has been rewritten and no longer generates satellite assemblies, so there is no longer any need to delete the satellite assemblies if you don't want them.


Problem activating the plugin

Using oh-my-zsh, appending zsh-syntax-highlighting at the end in plugins=(... ) has no effect.
Alternatively, placing "source ~/.oh-my-zsh/plugins/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh" at the end of .zshrc will result in following errors when new zsh shell is started, and hanged. I also has defined my highlighting by placing 'ZSH_HIGHLIGHT_HIGHLIGHTERS=(main brackets pattern cursor)' in my .zshrc.
_zsh_highlight_load_highlighters:pwd:13: too many arguments
zsh-syntax-highlighting: 'brackets' highlighter should define both required functions '_zsh_highlight_brackets_highlighter' and '_zsh_highlight_brackets_highlighter_predicate' in '/home/atomic/.oh-my-zsh/plugins/zsh-syntax-highlighting/highlighters/brackets//brackets-highlighter.zsh'.
_zsh_highlight_load_highlighters:pwd:13: too many arguments
zsh-syntax-highlighting: 'cursor' highlighter should define both required functions '_zsh_highlight_cursor_highlighter' and '_zsh_highlight_cursor_highlighter_predicate' in '/home/atomic/.oh-my-zsh/plugins/zsh-syntax-highlighting/highlighters/cursor//cursor-highlighter.zsh'.
_zsh_highlight_load_highlighters:pwd:13: too many arguments
zsh-syntax-highlighting: 'line' highlighter should define both required functions '_zsh_highlight_line_highlighter' and '_zsh_highlight_line_highlighter_predicate' in '/home/atomic/.oh-my-zsh/plugins/zsh-syntax-highlighting/highlighters/line//line-highlighter.zsh'.
_zsh_highlight_load_highlighters:pwd:13: too many arguments
zsh-syntax-highlighting: 'main' highlighter should define both required functions '_zsh_highlight_main_highlighter' and '_zsh_highlight_main_highlighter_predicate' in '/home/atomic/.oh-my-zsh/plugins/zsh-syntax-highlighting/highlighters/main//main-highlighter.zsh'.
_zsh_highlight_load_highlighters:pwd:13: too many arguments
zsh-syntax-highlighting: 'pattern' highlighter should define both required functions '_zsh_highlight_pattern_highlighter' and '_zsh_highlight_pattern_highlighter_predicate' in '/home/atomic/.oh-my-zsh/plugins/zsh-syntax-highlighting/highlighters/pattern//pattern-highlighter.zsh'.
_zsh_highlight_load_highlighters:pwd:13: too many arguments
zsh-syntax-highlighting: 'root' highlighter should define both required functions

The error persists and can only be stopped by closing terminal.

There is no pwd call on line 13 of _zsh_highlight_load_highlighters, or anywhere else in the source tree (!).  Can you please run git rev-parse HEAD in your zsh-syntax-highlighting working copy and report the output?  (As well as whether git status is clean.)
Does the error happen if you run zsh -f and therein source zsh-syntax-highlighting.zsh?

git rev-parse HEAD gives 57624bb9f64b88c633c03df986f73a45512eb60b
git status gives
On branch master
Your branch is up-to-date with 'origin/master'.

nothing to commit, working directory clean

That git output is fine  Does the error happen if you run zsh -f and therein run source zsh-syntax-highlighting.zsh?

hmm, if i run zsh -f first, and source the plugin, it works. But it the source doesnt work in my normal zsh. conflicts with other plugins?

oh, it works now if i put zsh-syntax-highlighting at the end of plugin=(.... zsh-...). I think I might've spelled it wrong previously.

@atomic Glad it works now! Thanks for following up and describing the cause and solution of the problem.


MySQL: '--skip-host-cache' is deprecated

From terminal output of $ ./vendor/bin/sail up:
quiz_app-mysql-1         | ...
[Warning] [MY-011068] [Server] The syntax '--skip-host-cache' is deprecated and will be removed in a future release.
Please use SET GLOBAL host_cache_size=0 instead.

Fixed in upstream PR https://github.com/docker-library/mysql/pull/1002

PR has been merged, go ahead and close this as completed now

Great - thanks @rawr51919.


Which NewLife.Redis versions supports Redis 7.0?

Main question of #107 I could not find an answer for:

We're now contemplating updating our Redis from 6.2 to 7.0 and I tried to find out which Redis versions you support. I.e. from which version onward is 7.0 supported? And does upgrading your library have any breaking changes?

@Soar360 or @nnhy Can you share from which NewLife.Redis version onward it supports Redis 7.0?
(Or are there no breaking protocol changes and we can use any version of the last two years)

vx.x.2003.x


caches: add lldb-python-scripts

This adds a missing component to the packaged tarball for the toolchain.

/azp run VS2019 (Google)

CC: @mikkeyboi - this at least builds it - need to get that into the installers still


Do not try to pump OpLine instructions into a block

When the SPIR-V includes metadata for debugging
(aka OpLine instructions) the CompilerError at
line 1588 was eventually triggered.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Thanks for the find.


Python 3.11 support

As title says

Do not merge this PR

Looks like only one dependency is missing - h5py
Apparently, building the wheel from source is not enough... so we might have to wait until a Python 3.11 release is available on their side.  We are good to go =) @jorgepiloto @MaxJPRey please review whenever possible.


Problem with hot addWidget (Cannot read property '_state' of null/helper.lastResults)

I'm still working out getting a simplified/reproducible case for this. It happens for me on a current app if I merely switch my widget adding to after .start().
Bug: What is the current behavior?
 Always use the latest one before opening a bug issue.
Instantsearch 2.3.1
It appears that helper.lastResults is unexpectedly null .

Is it a custom widget?

Nope, I removed all my custom widgets and still saw it.
But…I've distilled this down to a reproducible case! https://jsfiddle.net/timkelty/13jbye0r/
Note: to see this on jsfiddle I had to "preserve log" and hard-refresh several times.
As it doesn't seem to happen every time, I'm thinking it may be some kind of race condition.
Furthermore, It doesn't seem to be related to one widget being before and one after. I tried adding them both after .start and still saw it.
Note: widgets still render and function, just seeing this js error.

Hi @timkelty thanks a lot for the repro case and the issue,
I have tracked down the issue and this is a really an edge case produced by two new features we added:

The hot add/remove widgets API
The "search stalled" state (currently used to display a loading indicator for the search box)

What happens:

First request is sent with calling .start()
Second request is sent by adding a new widget
First request too much time, so we re-render widgets with a search is stalled parameter.

But this second render is not correctly done because we don't have access to lastResults since the first request is not done yet.
We are aware of the issue, we want to fix it, I would suggest you to don't add any widgets right after you started the InstantSearch instance.
(You can easily reproduce the issue by simulating a slow network with the code you shared)


@angular/forms not accessed from the right direction

Adter installing new Angular forms
in package.json
"dependencies": {
"@angular/forms": "0.2.0",
}

we get error
(index):277 Error: (SystemJS) Error: XHR error (404 Not Found) loading<EMAIL_ADDRESS>So we had to copy that file from @angular/forms/src/ to @angular ,as well as all other required files and folders, that we are subsequently warned about
This is strange because in DEMO-VERSION it is not required even though they don’t exist in
https://angular.io/docs/ts/latest/guide/forms.html

Maybe our settings are wrong, so we should direct the system to search for forms from
http://localhost:5555/node_modules/@angular/forms/src/
instead from
http://localhost:5555/node_modules/@angular/
we should say to the system (GULP or?) where to search for @angular/form as we do fo SystemJS (that we don't use, btw)
https://github.com/kara/material2/blob/8a1d36f7f1f88e4e840fe8d91b656c40e4bc4de5/GETTING_STARTED.md#configure-systemjs

First, you need to let SystemJS know where to look when you import @angular2-material. You can do this by adding the path to the Material folder to the maps object.
src/system-config.ts
const map: any = {
'@angular2-material': 'vendor/@angular2-material'
};
This says something like "when you look for an @angular2-material import, look inside the vendor folder" (the base folder will already be dist).

I think you just need to put it either in config file or in index.html
file, to set up path for SystemJS
On Sat, 16 Jul 2016 at 14:32 sinisarudan<EMAIL_ADDRESS>wrote:

Assigned #175 https://github.com/mprinc/KnAllEdge/issues/175 to @mprinc
https://github.com/mprinc.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mprinc/KnAllEdge/issues/175#event-725285495, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA8yofg-fhzJXaH4JXxHoy5fIM5No0hPks5qWT_tgaJpZM4JOFtl
.

Yes, it was as we both suggested, issues of letting system know about it through SystemJS:
Closed by @mprinc with https://github.com/mprinc/KnAllEdge/commit/a5eff3a6c1abd82b862f8ae57f1faecae7eae1f5


Add stack ID attribute to windows

I'm curious if you intend stacks to be a first class citizen: identifiable by id, queryable via yabai -m query --stacks … etc?
1) Ability to query stacks
I ask because, currently, stackline's stack detection is the worst of both worlds –  complicated and crappy :-) Lacking a mechanism to query stacks directly, stackline assumes that windows that occupy the same space (a.frame == b.frame) are in a stack. This is quite fragile:

zoom-parent and zoom-fullscreen may result in false positives (possible to mitigate by filtering out zoomed-windows, but stacked windows may also be zoomed, and this adds yet more complexity)
apps that constrain window dimensions (such as iTerm2, grrr!) often result in false negatives (i.e., the dimensions of such an app's window are not equal to those of its stacked siblings). I'm working on an update to add fuzzy frame matching, but this has its own failure cases.
similarly, apps with a minimum window size constraint (most apps) also result in false negatives

I would much prefer to query stack data directly from yabai. For example:
❯ yabai -m query --stacks --space
   → [ {"id": 405386, "focused": false, "zoom-parent": 0, "zoom-fullscreen": 0, "windows": [123456, 789123, …], {…}]

2) Signals for stacks
Stackline's logic for tracking stack state is also really complicated. If you don't think stack signals are going to be added soon, I'll take another pass at trying to simplify it as-is.

stack_changed (would be even better to differentiate cosmetic changes (move/resize) from structural changes (member added/removed)
stack_added
stack_removed

Let me know if you want me to split this into 2 issues.

I don't think stacks will be considered its own entity in the query system, but I can see the use of stacks having an internal id that would be included as an attribute alongside the stack-index in window queries.
As for signals, the current system is not capable of providing custom signals that are not directly mapped 1-to-1 with the macOS notifications that we observe, and so this is unlikely to happen for quite some time.

but I can see the use of stacks having an internal id that would be included as an attribute alongside the stack-index in window queries.

Yep, that ↑ would work fine.
And it's helpful to know that signals for stacks is unlikely. Very helpful!

@koekeishiya I updated the issue title to reflect your last comment. It'd be helpful to have a sense of when (soon / not soon) you expect a stack ID attribute could be added to windows, since it affects design decisions in stackline. Thanks!

@koekeishiya

I don't think stacks will be considered its own entity in the query system, but I can see the use of stacks having an internal id that would be included as an attribute alongside the stack-index in window queries.

However, it would be helpful to have control over them with rules. Right now it's not possible to configure a layout that uses stacks. The stacking layer that can be configured there seems to be a completely different concept that doesn't interact with the normal window stacking that can be achieved via window commands.

This is outside the scope of what rules are meant to be used for. If you want to somehow automate layouts, use the signal system instead.
Sent from my iPhone
On 21 Dec 2020, at 17:25, nbcomplete<EMAIL_ADDRESS>wrote:

@koekeishiyahttps://github.com/koekeishiya
I don't think stacks will be considered its own entity in the query system, but I can see the use of stacks having an internal id that would be included as an attribute alongside the stack-index in window queries.
However, it would be helpful to have control over them with rules. Right now it's not possible to configure a layout that uses stacks. The stacking layer that can be configured there seems to be a completely different concept that doesn't interact with the normal window stacking that can be achieved via window commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/koekeishiya/yabai/issues/672#issuecomment-749060029, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPDZV5FPVJKBS4U5TSY5NTSV5ZG7ANCNFSM4R3CFHNQ.


joplin-desktop: 1.0.216 -> 1.0.224

Motivation for this change

Joplin Update to 1.0.224. This release includes the new CodeMirror Editor.
App Icon did not work. Fixed

Since I had no glue how to fix (2), i borrowed the idea from another nix package.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

1.0.227 has been released. I added a commit for this (but it seems that it is not yet recognized)


Upgrading to latest code-generator commit

Signed-off-by: Aaron Eaton<EMAIL_ADDRESS>Description of your changes
Bumping provider-aws to latest code-generator commit.
Fixes https://github.com/crossplane/provider-aws/issues/876
I have:

[X] Read and followed Crossplane's contribution process.
[ ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
This PR is currently not mergeable. https://github.com/aws-controllers-k8s/code-generator/pull/237 has broken some of our functionality, including:

The APIGroupSuffix is no longer being set to 'aws.crossplane.io`
The Package Metadata in each service is now being ignored. This is resulting in everything being re-built for the latest apiVersion, instead of respecting the multiple apiVersions we support.

Will find some time to dig into it and submit another fix upstream.

@AaronME after pushing that PR yesterday, I realized that the function that checks for the latest api doesn't work correctly on crossplane and that there is a variable that sets the api version instead.  I added a Pr to fix that and use the supplied variable here: https://github.com/aws-controllers-k8s/code-generator/pull/240  I think this would at least fix some, if not all, of the issues seen here--particularly resources being created with v1beta1 apis.

Any updates on the status?

Closing and re-opening to trigger tests.

This PR is currently blocked by the issue described in https://github.com/aws-controllers-k8s/community/issues/1078 and https://github.com/aws-controllers-k8s/community/issues/1065
We are tracking those issues for the fix and will update as soon as they are available.

@AaronME I didn't notice this PR before opening https://github.com/crossplane/provider-aws/pull/993 . Do you want to continue with this one after a rebase?


Add missing models and attributes

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[PIO-46] Fix readlink with -f option not working on BSD based systems

Thanks for pio script's supporting soft link.
https://github.com/apache/incubator-predictionio/pull/289
But readlink -f doesn't seem to work on Mac and possibly BSD based systems.
As execute pio script, the following errors occurs.
readlink: illegal option -- f
usage: readlink [-n] [file ...]
usage: dirname path
bin/pio: line 45: //bin/pio-class: No such file or directory
bin/pio: line 45: exec: //bin/pio-class: cannot execute: No such file or directory

I had fixed pio script not to use readlink with option -f , based on this sbt script.
https://github.com/apache/incubator-predictionio/blob/d45d0a4170ef73695e0fffe921e5bda2c37e2281/sbt/sbt#L8-L32

Thanks @haginot !


Fix uninitialized variable warnings.

Hum this warning was a false positive, the initialization was not needed.


kernel: While thread is running [thread_state] is in _THREAD_QUEUED

Describe the bug
While doing thread profiling I have noticed that when a thread is running, state is "queued". From profiler it is visible that thread goes from "suspended" state to "0x00" state before entering "queued" state. On thread end, state goes from "queued" to "0x00" to "suspended". I couldn't find any reference to what state is value 0x00.
HW used is nRF52840DK.
I have created a demo application which has 4 threads:

idle (system thread)
main is aborted after system initialisation
ShutDnBtn (custom thread); thread is preemptive (prio=3) and runs every 50 ms
adcSwitchBtn (custom thread); thread is preemptive (prio=4) and runs every 50 ms

This is the code inside ShutDnBtn:
uint8_t cnt = 0;
uint8_t stop = 10;
while(1)
{
  while(cnt < stop)
  {
    cnt++;
  }

  k_sleep(K_MSEC(50));
}

Expected behavior
I would expect to have defined "running" state for threads. When checking kernel_structs.h there isn't any mention of running state.
Impact
When profiling OS threads it is hard to interpret when a thread is running, when is suspended or in some other state. These state names also differ from state names described in the documentation.
Logs and console output
For profiling states I used <thread>.base.thread_state variable.

Environment (please complete the following information):

OS: Windows.
Toolchain is nRF Connect SDK v1.9.0.
I have tried with OS versions 2.7.99 and 3.0.0 and the result is the same.

probably need to increase size of thread_state and add more states, uint8_t is hitting the limit right now.

I also noticed that "idle" thread never changes [thread_state]. For CPU load calculations it would be great help if you could see how much time CPU is idle (not working on other threads or IRQs) - idle thread running.
What is the benefit of using single bit for state? Why not use just numbers, for example 0x01 run, 0x02 suspend 0x03 queued, 0x04 dead and so on.

Sorry for the delay ... looking into this now.

@peter-mitsis Thank you for mentioning k_current_get(). I looked into it and found out that if I profile value of _kernel.cpus[0].current, I'm able to see when which thread is running and for how long. If I replace address values with thread names (done in profiling SW), I can see exact timing of running threads, CPU load and thread switching. Just what I was looking for. Thank you.


[App]:

Current Behavior
Segmentation mask predictions Wandb visualization having uniform red noise
Expected Behavior
visualization without the  noise
Steps To Reproduce
The problem can be observed in this Wandb tutorial itself.
https://wandb.ai/stacey/deep-drive/reports/Image-Masks-for-Semantic-Segmentation--Vmlldzo4MTUwMw
Screenshots
The first picture is from my personal project

The second picture if from the tutorial

Environment
OS: macOS Monterey
Browsers: Safari
Version: 12.5.1
Additional Context
No response

Hi @NehalD99, thank you for bringing this up to our attention. We actually have a bug report out for this and I'll increase the priority on it. If there are any updates on it, I'll let you know :)

Hi, are we any close to fixing this? Need help?

I have the exact same issue with MacOS and Safari, thanks for working on it!

I got the same issue on Windows 11. The problem appears both in Chrome and Firefox.

Also when I download a mask, the noise is there:

I'm experiencing the same issue, however I noticed it is less prominent when using Brave Browser. Below a comparison of the exact same run, showing with the same settings, between Safari (Version 17.4.1 (196<IP_ADDRESS>.14)) and Brave ([Version 1.66.115 Chromium: 125.0.6422.112]):


Gemini and Gopher support

Gemini support was removed in f2fd8fc92898b5312bd7bc787cc8221f5650ce65 due to lack of support and interest

It would be good to me if support be resored.
I am working on a news chat bot for XMPP which works well with HTTP and I intend to add support to Gopher and Gemini, yet non of the available modules appear to satisfy my needs.
If Ladybird has a "headless" mode, so called, then it would greately be useful to my bot.
This is a link to my bot https://git.xmpp-it.net/sch/Slixfeed and it can serve hundreds and probably even thousands of chats at the same time.

The main focus of Ladybird is to support the same widely-adopted standards that other major browsers support. We're building a browser for the web, not a showcase for niche technologies :)

I would argue and say that we, that is people, are deciding the standards, yet the problem is that so called "standards" are being foisted on us.
Gopher was an integrated part of Mozilla products and so was RSS.
Is Gopher still relevant? Yes.
Is RSS still relevant? Certainly!
The fact that big money browsers with big interests from advertising to spy industries, including government intelligence, are attempting to set the standards, does not mean that these are real standards, nor acceptable, nor appropriate.
Hence, I think that Gemini and Gopher are crutial.
I use Lagrange every day, and after a couple of months, I am smiling each session I have with Lagrange.
I am really smiling, because of the comfort.
Corporations do not smile, humans do.

By the way, adding Gemini support is probably the first Falkon extension that I will publish.

I don't think we're ruling out Gopher etc. It's just that we're a small team with a tight deadline for a usable alpha version in 2026, so we have to prioritise things.

If a web browser doesn't implement Gopher, or Gemini, or RSS, it's still a functional browser to most people.
If a web browser doesn't implement all the DOM APIs, or common media codecs, or CSS properties, or if it crashes and bugs out, then it's no good to anybody.

So, we have to focus on getting it to work well with the web that people use, first.

I would argue and say that we, that is people, are deciding the standards, yet the problem is that so called "standards" are being foisted on us.

In the case of this project, the standards are ultimately decided by the W3C, WHATWG, and ECMA. This project's current single goal is implementing a client for the Web as laid out by them, however:

The fact that big money browsers with big interests from advertising to spy industries, including government intelligence, are attempting to set the standards, does not mean that these are real standards, nor acceptable, nor appropriate.

Yes, it is possible that a standard which blatantly violates the user's privacy were accepted by W3C or WHATWG, but in that case the maintainers of Ladybird can simply choose to not implement it. That is the advantage of no funding or control from the advertising industry.

Understood. I am following this matter. Thank you!


Multi-GPU support in embeddings.py

python embeddings.py start data_set_fullseq.fasta data_set_fullseq -embedder pt --gpu -bs 0

When run as above, everything works fine. However, if I use the -nproc 2 flag, the computations are much faster, but the resulting database file contains embeddings for only half of the input sequences.

-nproc will only work correctly when asdir or h5py option is specified, this should be validated before actual run

I've stumbled upon this too - there are also 2 overlapping progress bars shown as I recall.
Additionally there's a typo in README that I've followed at that time: https://github.com/labstructbioinf/pLM-BLAST/blob/main/README.md?plain=1#L64

Yes, the progress bars looked weird (one was updating during the calculations and the other was stuck at 20%).


Interaction Ideas

Just want to drop this here: http://ianlunn.github.io/Hover/

We added most of the "good" ones. If there are other specific ones you like let me know.

The border ones are pretty cool, I thought. Used often for navigation!

True. I can get down with those.
On Sun, Sep 27, 2015 at 2:11 PM Jeff Escalante<EMAIL_ADDRESS>wrote:

The border ones are pretty cool, I thought. Used often for navigation!
—
Reply to this email directly or view it on GitHub
https://github.com/jenius/axis/issues/218#issuecomment-143588212.


Props formatting

I love how dprint handles the formatting in JSX with the component's props, for example
const Component = () => {
    return (
        <Badge color="red" size="xs">
            {"@" + username}
        </Badge>
    )
}

This code formats to this: (the same)
const Component = () => {
    return (
        <Badge color="red" size="xs">
            {"@" + username}
        </Badge>
    )
}

And this code:
const Component = () => {
    return (
        <Badge
            color="red"
            size={25}
        >
            {"@" + username}
        </Badge>
    );
};

to this (also the same)
const Component = () => {
    return (
        <Badge
            color="red"
            size={25}
        >
            {"@" + username}
        </Badge>
    );
};

When you have 2 props, you can select use a new line on every prop, or put it in the same line, this avoid this ugly prettier problem:
Input

    <Card name="John Doe" age={25} imageUrl="myImageHost.com/x"/>
    <Card name="John Doe" age={25} imageUrl="myImageHost.com/x1242141245939519659"/>

Output

    <Card name="John Doe" age={25} imageUrl="myImageHost.com/x" />

    <Card
        name="John Doe"
        age={25}
        imageUrl="myImageHost.com/x1242141245939519659"
    />

;

With no option of be like this:

    <Card
        name="John Doe"
        age={25}
        imageUrl="myImageHost.com/x"
    />

    <Card
        name="John Doe"
        age={25}
        imageUrl="myImageHost.com/x1242141245939519659"
    />

;

This plugin has the same problem, and I would like to have an option like mantain the user selection of new lines in props. Thank you for this awesome plugin! I like to use it with Astro

I may add a new option to support this style, but it will be disabled by default to avoid breaking. Does this make sense?

With the code example you gave:

    <Card name="John Doe" age={25} imageUrl="myImageHost.com/x"/>
    <Card name="John Doe" age={25} imageUrl="myImageHost.com/x1242141245939519659"/>

The first <Card> component won't be splitted into different lines: playground
What's the problem?

I will add a new option for this, but it will be disabled by default to avoid breaking. Does it make sense?

v0.6.0 is released. You don't need to update your configuration and now it formats as you expected.
Feel free to open new issues if you find bugs, also don't forget to give it a star and recommend this project to others.


feat(metadata): updated expected values in tests

The tests for metadata were failing because the expected values needed to be updated to reflect the new length and format of metadata. I changed the expected length from 19 to 18 and added brackets around the values.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@saigiridhar21 @Ramanth @a-ghag this change is waiting on reviews. Can you take a look when you get a chance? Thanks!


Standardized React Native ActivityIndicator for Android and iOS

Fixing deprecated calls for both Android and iOS

Can you prepare a new npm release including this fix?

@larsvinter waiting for release... :]


Install Ansible for working CI

For some reason installing ansible-lint alone is not enough. The linting test would fail with a complaint about missing Ansible:
ERROR    No module named 'ansible'
FATAL: ansible-lint requires a version of Ansible package >= 2.9, but none was found. Please install a compatible version using the same python interpreter. See https://docs.ansible.com/ansible/latest/installation_guide/intro_installation.html#installing-ansible-with-pip
Error: Process completed with exit code 4.

This change results in that error message no longer failing the CI.


[Draft]add condition check for restart single job only

restart single job only.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.max.zhang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

please consider combine commits into 1 or 2

Use PR https://github.com/SAP/InfraBox/pull/411 instead.


[Feature] Option to enable element picker shortcut globally, instead just when the inspector is open

Currently the element picker shortcut can not be used unless the inspector is open.  However in Chrome, Firefox, etc the shortcut is enabled globally.  It'd be nice if the same could be true in Discord.

I'm not sure if this is possible within Electron, but I will look into it when I have much free time.

This is possible and will be included in the next update

NICE


Add the ability to define sh/exec commands

For example, it might be nice to have a 'dev python' command which runs 'dev sh python foo.py'. Adding code for each of these cases shouldn't be necessary.  Add the ability to define these shortcuts globally or per-project in the configuration file.
I'm thinking that a command defined outside of the project would apply to all projects, i.e., in the case above, dev projectname python.
Possible configuration (needs work)
sh_shortcuts: {
   "python": "/home/app/.virtualenv/bin/python",
}

Punting on this. Probably a better fit for short scripts living outside the tool. We'll see.


Changing comment length causes test to go from passing to blowing up

I have a test that passes, of the form:
/**
 * Verifies that Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce eu tincidunt risus. Nam quis felis quam.
 * Etiam blandit volutpat est, ut venenatis odio vehicula a. Nam luctus eleifend massa sed rhoncus.
 */
void test_myFunction_yyy(void) {
   ...
}

When I do nothing else but lengthen its preceding comment (for example, by repeating the original comment content 3X), e.g:
/**
 * Verifies that Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce eu tincidunt risus. Nam quis felis quam.
 * Etiam blandit volutpat est, ut venenatis odio vehicula a. Nam luctus eleifend massa sed rhoncus.
 * Verifies that Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce eu tincidunt risus. Nam quis felis quam.
 * Etiam blandit volutpat est, ut venenatis odio vehicula a. Nam luctus eleifend massa sed rhoncus.
 * Verifies that Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce eu tincidunt risus. Nam quis felis quam.
 * Etiam blandit volutpat est, ut venenatis odio vehicula a. Nam luctus eleifend massa sed rhoncus.
 */
void test_myFunction_yyy(void) {
   ...
}

the test blows up, with erroneous "duplicate symbol" errors:
duplicate symbol '_tearDown' in:
    ...
duplicate symbol '_setUp' in:
    ...
ld: 2 duplicate symbols
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ERROR: Shell command failed.
> Shell executed command:
'gcc "build_test/test/out/c/[...].o" "build_test/test/out/c/[...].o" "build_test/test/out/c/unity.o" "build_test/test/out/c/cmock.o" -o "build_test/test/out/[...].out" -lm -lm'
> And exited with status: [1].

Is this expected behavior with Ceedling?
Is there a way to prevent this from happening, short of keeping all comments within a certain, empirically determined limit?
Note: I'm experiencing this running on OSX, where the majority of my development team is NOT experiencing this, running under Linux. In case its relevant, the ruby version I am using is:
> ruby -v
ruby 2.6.10p210 (2022-04-12 revision 67958) [universal.arm64e-darwin23]

Ho @mvandervoord - thanks for the ideas.

is it possible you're doing a combination of /* */ style comments, // style comments, and/or #ifdef sections all in that area?

No, just one comment style, and no #ifdef sections.

The setup / teardown functions are at the top of the file, while this comment/function are near the bottom of the file; not proximal.

Are you using gcc or another compiler?

I've been using this version of gcc:
> gcc -v
Apple clang version 15.0.0 (clang-15<IP_ADDRESS>.5)
Target: arm64-apple-darwin23.2.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

...but I also just tried switching to Homebrew's (GNU) gcc, and I get the same error.

Do you rely on weak function definitions for setup / teardown?

Hmmm... I'm not sure; how would I check this (and should this be a factor, given the concrete comment examples above)?
Thanks again.

The issue seems to relate to the number of lines in a comment, rather than the length in characters.

Outside of the "bad parsing" theory, I'm at a bit of a loss as to what could be happening. From what you've answered above, it seems very unlikely that it's a result of bad parsing.... those comments are just too "normal" and the setup/teardown functions don't seem like they'd be the only issue.
In your build folder, there are files that might be able to give us clues?
If you have the preprocessor enabled, then there will be a preprocessed version of this header. It'd be interesting to open that and see if it contains all the things you'd expect (the function definitions for your tests, as well as setup and teardown).
If you open the runner associated with this particular test, does it include its own setup and teardown function?
Sorry about sending you all over the place. I don't have a clearly defined theory at the moment and I'm casting a wide net in hopes we find clues. :/

I just looked in build_test/test/preprocess/files/, and:

When the long (problematic) comment is used, the file in question holds only one function: the function after the comment. (That function happens to be the last in the file).
When the short comment is used, the file in question holds all of the functions of the original file.

Does this suggest anything? Should I be looking elsewhere in build_test?
I've got the line use_test_preprocessor: TRUE in project.yml.  (When I try to set it to FALSE, other things break that prevent me from easily testing what that change might do...)

Interesting.
So there is something about your test preprocessor that is causing it to chop out much of your output when the comment gets too long. If you're running with defaults, it's just using clang for this also... which I wouldn't expect to have any issues with this sort of thing (clang is used to handling very long files, etc... a comment block shouldn't confuse it).
I assume you're using the last release, not the current release candidate, correct? I ask only because the preprocessing handling changes a lot in the new release.

I assume you're using the last release, not the current release candidate, correct? I ask only because the preprocessing handling changes a lot in the new release.

It looks here like the latest release is 18.1.8; I'm using 15.0.0 - so not "living on the edge" with an untested release candidate...

If you're running with defaults, it's just using clang for this also...

How would I check? Are there particular settings to look out for that might be over-riding some aspect of this?
Appreciate any recommendations re: how to go about debugging this sort of thing.

It looks here like the latest release is 18.1.8; I'm using 15.0.0 - so not "living on the edge" with an untested release candidate...

Whoops. I wasn't very clear there. I was referring to the Ceedling version. If you do a ceedling --version I suspect it's 0.31.1?

How would I check? Are there particular settings to look out for that might be over-riding some aspect of this?

In your ceedling project.yml file, have you defined you own tools, particularly test_preprocessor ? Given your statements above, I strongly suspect you have not (which is a good thing in this case. The stock clang SHOULD be fine here)

If you do a ceedling --version I suspect it's 0.31.1?

Strangely, ceedling --version causes the tests to run - but when they do, from error output, I see:
...gems/ceedling-0.31.1/lib/ceedling...

...so I'm guessing the version is 0.31.1.

In your ceedling project.yml file, have you defined you own tools, particularly test_preprocessor ?
I don't think so (but am still very much learning how this system works...)

From project.yml, here are the lines that seem possibly relevant:
:project:
  ...
  :use_test_preprocessor: TRUE
  :use_preprocessor_directives: TRUE
  ...

and:
...
# Ceedling defaults to using gcc for compiling, linking, etc.
# As [:tools] is blank, gcc will be used (so long as it's in your system path)
# See documentation to configure a given toolchain for use
:tools:
  :test_file_preprocessor:
    :executable: gcc
    :name: default_test_file_preprocessor
    :stderr_redirect: :none
    :background_exec: :none
    :optional: false
    :arguments:
    - ''
    - ''
    - "-E"
    - -I"$": COLLECTION_PATHS_TEST_SUPPORT_SOURCE_INCLUDE_VENDOR
    - -I"$": COLLECTION_PATHS_TEST_TOOLCHAIN_INCLUDE
    - "-D$": COLLECTION_DEFINES_TEST_AND_VENDOR
    - "-D$": DEFINES_TEST_PREPROCESS
    - "-DGNU_COMPILER"
    - "-include FreeRTOS.h"
    - '"${1}"'
    - -o "${2}"
  :test_file_preprocessor_directives:
    :executable: gcc
    :name: default_test_file_preprocessor_directives
    :stderr_redirect: :none
    :background_exec: :none
    :optional: false
    :arguments:
    - "-E"
    - -I"$": COLLECTION_PATHS_TEST_SUPPORT_SOURCE_INCLUDE_VENDOR
    - -I"$": COLLECTION_PATHS_TEST_TOOLCHAIN_INCLUDE
    - "-D$": COLLECTION_DEFINES_TEST_AND_VENDOR
    - "-D$": DEFINES_TEST_PREPROCESS
    - "-DGNU_COMPILER"
    - "-include FreeRTOS.h"
    - "-fdirectives-only"
    - '"${1}"'
    - -o "${2}"
  :test_includes_preprocessor:
    :executable: gcc
    :name: default_test_includes_preprocessor
    :stderr_redirect: :none
    :background_exec: :none
    :optional: false
    :arguments:
    - ''
    - ''
    - "-E"
    - "-MM"
    - "-MG"
    - -I"$": COLLECTION_PATHS_TEST_SUPPORT_SOURCE_INCLUDE_VENDOR
    - -I"$": COLLECTION_PATHS_TEST_TOOLCHAIN_INCLUDE
    - "-D$": COLLECTION_DEFINES_TEST_AND_VENDOR
    - "-D$": DEFINES_TEST_PREPROCESS
    - "-DGNU_COMPILER"
    - "-include FreeRTOS.h"
    - '"${1}"'
  :test_dependencies_generator:
    :executable: gcc
    :name: default_test_dependencies_generator
    :stderr_redirect: :none
    :background_exec: :none
    :optional: false
    :arguments:
    - ''
    - ''
    - "-E"
    - -I"$": COLLECTION_PATHS_TEST_SUPPORT_SOURCE_INCLUDE_VENDOR
    - -I"$": COLLECTION_PATHS_TEST_TOOLCHAIN_INCLUDE
    - "-D$": COLLECTION_DEFINES_TEST_AND_VENDOR
    - "-D$": DEFINES_TEST_PREPROCESS
    - "-DGNU_COMPILER"
    - "-include FreeRTOS.h"
    - -MT "${3}"
    - "-MM"
    - "-MD"
    - "-MG"
    - -MF "${2}"
    - -c "${1}"
    ...

Does this suggest any solutions?
In case its relevant: gcc on the Macbook corresponds to clang.
Thanks again,
-K

Hi, @krispin-gradient. Could you try your build with :use_preprocessor_directives disabled? It's very possible you need this feature in your test setup. If not, it might be causing the shenanigans. It's not a particularly resilient feature in 0.31.1.
I ran some tests with Ceedling 1.0.0 prerelease. It handles your reported scenario just fine to the extent I am able to adequately replicate your specific scenario. Unfortunately, we don't have the resources to actively support two versions of Ceedling simultaneously. 1.0.0 is basically ready for release, save for finishing some stress testing and final packaging. It includes a long list of bug fixes, improvements, and new features users have asked for. In particular, its preprocessing abilities are greatly improved (though we did have to pull one advanced feature to be restored in a future release). With its impending official release I don't think we can spend the necessary time to troubleshoot and bug fix 0.31.1. Your issue definitely seems like a needed bug fix.

Hi @mkarlesky,

Could you try your build with :use_preprocessor_directives disabled?

This seems to do the trick. I don't know that my organization can comment out this flag for all the tests we need to run, but I was able to at least verify that the tests that were failing in relation to long comments (when run on OSX) no longer fail when this flag is disabled.
Appreciate the recommendation, and look forward to Ceedling 1.0.0!

The flag in question in 0.31.1 is an enhancement to Ceedling's preprocessing that tries to preserve certain macros (Unity's advanced test case range features) that would otherwise get preprocessed (by the compiler not Ceedling) in unhelpful ways. If you don't use Unity's test case range and related features, you can skip entirely this configuration flag.
In 1.0.0+ this behavior will not require a special flag but will just work (not there quite yet).


Temperature is converted to Kelvin twice

Hi, as someone who just stumbled onto your project and took a look at the code,
I've noticed that the function calc_isothermal_compression_energy in physics/_helper_functions.py converts the incoming temperature to Kelvin twice in a row here.
Hope this helps and I didn't misunderstand anything.

Thanks for telling. I just fixed the problem.


Cheery-pick bugs fix to Release 1.5.0

Fix bug 4665 project admin cannot change the role of some user.
Add query string when getting members
ix UI/UX issues and manually refresh component when fresh
Fix configure save err #4698

Coverage increased (+0.04%) to 64.335% when pulling 939dd14091554da484eeaa1088e656980c816c54 on ninjadq:release-1.5.0 into e67dbd00b7831056d097c5e01977d7430ccc7ec2 on vmware:release-1.5.0.

Please rebase

It’s dq’s commits
From: Daniel Jiang<EMAIL_ADDRESS>Sent: Wednesday, April 18, 2018 4:35 PM
To: vmware/harbor<EMAIL_ADDRESS>Cc: Fuhui Peng (c<EMAIL_ADDRESS>Review requested<EMAIL_ADDRESS>Subject: Re: [vmware/harbor] Cheery-pick bugs fix to Release 1.5.0 (#4696)
Please rebase
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_vmware_harbor_pull_4696-23issuecomment-2D382309164&d=DwMCaQ&c=uilaK90D4TOVoH58JNXRgQ&r=aeIUxwdoJfj5RkcI5m5zAw&m=d_KAl2GfyjmO7UearkOxwaUbUYjsbkHqrHFO5nFslgQ&s=8QG6YFBrMOZchDPDCvMwc8FJ9FCSYVD-SvYsjPiNfcs&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_Acfv7fPL2XzgO87ssWV6tf7k0r386Sdjks5tpvqigaJpZM4TYIWL&d=DwMCaQ&c=uilaK90D4TOVoH58JNXRgQ&r=aeIUxwdoJfj5RkcI5m5zAw&m=d_KAl2GfyjmO7UearkOxwaUbUYjsbkHqrHFO5nFslgQ&s=RLk3jIrDmfaJlceYTHu1yDXE2ao8gNVb2R4WdS1nWaQ&e=.


Update Labels in Issue Templates

We are currently using four issue templates for the four different types of live stream reviews.
In order to streamline the process for filtering and reviewing these, we need to update the templates to apply the current label and each of them should apply the live stream review label.
An example change would be:
---
name: Github Profile Review
about: Please review my github profile on a live stream
title: '[REVIEW]'
- labels: gh profile review
+ labels: 'gh profile review, live stream review'
assignees: ''
---

Files to Edit
All of these are within the .github/ISSUE_TEMPLATE directory.

[ ] gh-profile-review.md (#1327)
[ ] opensource-review.md
[ ] portfolio-review.md
[ ] resume-review.md

Share the love! Please only change one file and let others get squares too!

is this issue still open?

is this issue still open?

Unfortunately I think for all four templates PRs were created only one pr is waiting for merge.

Yep. The four PRs have been merged now. Great work everyone!


Stop the player just hammering on the space bar

Cooldown? Miss prevents a hit?
Daniel:

adding some early/late feedback that stays on the screen for X ms and ignoring presses would be a reasonable UX i think

One attack per turn. Done.


creational/builder: mismatching function call

duplicate of https://github.com/tmrts/go-patterns/pull/80


tests: use ceph-ansible to deploy, configure and verify test builds

Let's not merge this until we can change the CI to run the tests against this PR. I should be able to get that done today. I have tested this manually though and it does work on one of our jenkins slaves.
The idea is that for each PR we will start a CI job that builds the images, starts a local insecure docker registry and then adds the new images to that registry. The script then uses ceph-ansible and it's existing docker_cluster testing scenario to deploy, configure and test a ceph cluster using the new image from the registry on the jenkins slave.

jenkins test ceph_ansible2.1-jewel-centos7_cluster

jenkins test ceph_ansible2.1-jewel-centos7_cluster

jenkins test ceph_ansible2.1-jewel-centos7_cluster

jenkins test ceph_ansible2.1-jewel-centos7_cluster

jenkins test ceph_ansible2.1-jewel-centos7_cluster

I've got this passing now on the slaves in our sepia labs, but the nodes we use in OVH are not passing the tests. I'm investigating why.

jenkins test ceph_ansible2.1-jewel-centos7_cluster

jenkins test this please

jenkins test ceph_ansible2.1-jewel-centos7_cluster

Alright, this seems to be stable now. This does need https://github.com/ceph/ceph-ansible/pull/1229 to be able to use a custom registry though. We can leave this commit https://github.com/ceph/ceph-docker/pull/458/commits/189d4383c23a7662daaaca2e259bdca7631b5bad in here for now, but eventually once that's merged we'll want to backport it to the stable-2.1 branch so we can go back to using it for testing.


Has anyone been able to get past greet screen?

I think that's a Tauri default screen. This project is in really early stages of development.


[FLINK-7307] Add proper command line parsing tool to ClusterEntrypoint

What is the purpose of the change
Add a proper command line parsing tool CommandLineParser to the entry point of the ClusterEntrypoint#parseArguments
Brief change log

Add command line parsing tool CommandLineParser
Use CommandLineParser instead of ParameterTool in ClusterEntrypoint#parseArguments

Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
(example:)

Added test case CommandLineParserTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@tillrohrmann @aljoscha I have fixed https://issues.apache.org/jira/browse/FLINK-7307 in this PR, could you please have a look when you're free, thanks

This has been fixed as a side effect of other work.


fix "null" quota interval parsing error

closes #108

Codecov Report

Merging #109 into master will decrease coverage by 1%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #109    +/-   ##
======================================
- Coverage      77%    76%   -<1%
======================================
  Files          14     14
  Lines        1224   1143    -81
======================================
- Hits          935    864    -71
+ Misses        195    189     -6
+ Partials       94     90     -4

Impacted Files
Coverage Δ

adapter/product/manager.go
76% <100%> (+1%)
:arrow_up:

adapter/adapter.go
89% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71503de...7cf6f4a. Read the comment docs.


add credentials

Tests are being skipped right now.

I guess this can be closed as we now. use pytest-servers


Port the support for accessing Vim variable dictionaries in Lua scripts from NeoVim

This passes on CI, but in my local setup it fails:
Found errors in Test_lua_global_var_table():
Caught exception in Test_lua_global_var_table(): Vim(lua):[string "vim chunk"]:1: bad argument #1 to 'remove' (table expected, got userdata) @ command line..script /home/mool/vim/vim82/src/testdir/runtest.vim[473]..function RunTheTest[44]..Test_lua_global_var_table, line 51
Found errors in Test_lua_predefined_var_table():
command line..script /home/mool/vim/vim82/src/testdir/runtest.vim[473]..function RunTheTest[44]..Test_lua_predefined_var_table line 12: Expected 'list is locked' but got '[string "vim chunk"]:1: bad argument #1 to ''remove'' (table expected, got userdata)': lua table.remove(vim.v.argv, 1)
SKIPPED Test_lua_list_table_insert_remove(): Lua version < 5.3
I suppose that is because of the Lua version being 5.2.

Hi Bram,
On Tue, Aug 3, 2021 at 9:59 AM Bram Moolenaar @.***>
wrote:

This passes on CI, but in my local setup it fails:
Found errors in Test_lua_global_var_table():
Caught exception in Test_lua_global_var_table(): Vim(lua):[string "vim
chunk"]:1: bad argument #1 https://github.com/vim/vim/issues/1 to
'remove' (table expected, got userdata) @ command line..script
/home/mool/vim/vim82/src/testdir/runtest.vim[473]..function
RunTheTest[44]..Test_lua_global_var_table, line 51
Found errors in Test_lua_predefined_var_table():
command line..script
/home/mool/vim/vim82/src/testdir/runtest.vim[473]..function
RunTheTest[44]..Test_lua_predefined_var_table line 12: Expected 'list is
locked' but got '[string "vim chunk"]:1: bad argument #1
https://github.com/vim/vim/issues/1 to ''remove'' (table expected, got
userdata)': lua table.remove(vim.v.argv, 1)
SKIPPED Test_lua_list_table_insert_remove(): Lua version < 5.3
I suppose that is because of the Lua version being 5.2.

Yes. The Lua 5.3 release notes mention that the table library
was enhanced to use metamethods for setting and getting elements.
I have updated the test to not use the table API for adding and
removing elements from the Vim dictionary.

Yegappan


Camera Transform Issues

When making an entity with Camera3d a child of another entity, the camera transform is not updated properly.
This is due to camera_view.rs, around line 300 in the line:
mut cameras: Query<(&mut Camera, &mut Transform), Without>,
By only taking the Transform and not the global transform, the real_cam_transform is not adjusted to the true global positon of the camera.
I propose replacing the line with:
mut cameras: Query<(&mut Camera, &mut GlobalTransform), Without>,
This allowed any of my cameras that were children to update the viewport properly.

Thank you for the issue and the suggestion! I'll try this tomorrow

Fixed and tested for child camera. Real camera transform updating correctly right now. But I gound that gizmo transform works badly with child entities. Will fix in another issue


Add issue template

See "Insights >> Community"

I added an issue template. If you don't like it, I'll fix it.

Both the feature and bugfix were a great start, but I enhanced them both to be more QuISP-specific.