Move all crate attributes after the docs

Objective

Part of #9500
Follow up of #9558

Solution

Move crate attributes after the crate docs.

Whether the attributes go before or after the docs, we should at least stick to a consistent style. IIRC, it currently differs depending on the crate which is ugly and confusing.

I'd be happy to clean this one up, but I guess we might need more of a consensus? I reckon the point @mockersf makes is pretty valid (documentation in source files is for generators and tooling, not for ease of reading).
Could also close out #9558 if we can get some agreement?

I reckon the point @mockersf makes is pretty valid (documentation in source files is for generators and tooling, not for ease of reading).

I think with time I finally agree with this point. I'll close this PR and let you handle this.


notion links in the Resources.pdf dont seem to work

the links to Notion pages in the Resources.pdf dont seem to work

found this link under the Q&A of the udemy hosted version of this same material which seems to be the current home
https://melisai.notion.site/ChatGPT-101-Supercharge-Your-Work-Life-750-Prompts-Inc-4233ca9acf234f58a6be8781dd9988b2
https://melisai.notion.site/ChatGPT-101-Prompt-Ideas-Public-2698a98149da4a16b8537f83954a76a1

Hi @boogieshafer
Please refer to the following updated link:
https://melisai.notion.site/ChatGPT-101-Supercharge-Your-Work-Life-750-Prompts-Inc-4233ca9acf234f58a6be8781dd9988b2
The author has compiled all the resources into this one.


Automate dependency management between Paket and Directory.Build.props

This issue is a follow-up on https://github.com/fsprojects/Fabulous/issues/184
A lot of work has been done for dependency management (centralized versioning) with the Directory.Build.props file.
Most of the projects don't rely on Paket directly for dependencies, instead use PackageReference.
Only the Android/iOS projects manually reference the dlls retrieved by Paket.
Paket should still be used for its better dependency resolution (sanity checker).
But Paket can't be used directly because of a limitation of Visual Studio for Mac which has its own way of restoring NuGet packages, ignoring Paket. (https://github.com/mono/monodevelop/issues/5123)
The idea currently is when we need to add/update a dependency, we ask Paket to resolve it and then apply the new versions in the Directory.Build.props file manually.
What remains to do:

Convert Android and iOS projects to RestoreProjectStyle=PackageReference, so they can be centralized as well (https://github.com/fsprojects/Fabulous/issues/181)
Generate Directory.Build.props automatically from the Paket resolution (if it's feasible)

Closing the issue like #181
We can't currently do anything about it without building a gasworks process.
It will be resolved automatically when we can migrate Xamarin.Android/Xamarin.iOS to the new SDK-Style project format.


Extending automatic teststuite

Extended the automatic test_constraints testsuite which uncovers several bugs (some of which are fixed in this PR)
Main changes to test file:

Inspect "globalconstraints.py" and "globalfunctions.py" files to automatically generate all global constraints
All Boolean expressions, including global constraints are also tested as numerical expressions now
Option to do a solveAll which tests wheter all solutions to the constraint are valid. Untested for now as it takes a long time for some consrtaints, but potentially usefull before doing a release?
General cleanup

Bugs and fixes:

[fixed in #463] Some vars were unknown to the solver
[fixed] Simplify Boolean did not translate comparisons to 0/1 when in numerical context
[fixed] When partial functions are in a toplevel constraint, should be translated to False and not throw an error (I am unsure about this fix, it produced a lot of duplicate code, potential for cleanup here)
[open] incorrect decomposition of Inverse consrtraint when nested

The last is also why the automatic tests fail for now.

Is this a draft?

Quite some errors in Choco too, regarding GCC. Choco accepts only ints for values, and not variables

The inverse bug is just because it uses element probably?
Maybe disable inverse if we want to merge this, but indeed there should be a way to get rid of all that duplicate code..

We could have argval return an 'undefined' value in stead of raising an error

I'm not very convinced by the use of the NaN's anymore...
There are quite a bit of inconsistencies and hard things to catch.
E.g., nan != False returns True...
I think we should look for a more elegant solution

well NaN==anything is False so NaN!=anything should be True. Using NaN saves us a little bit of effort but using another undefined object is also fine for me

we could also make another argval function that turn NaN's into False, but then you need to use this one in boolean contexts and the other one in nonboolean contexts..

Fine to be merged by me, but some conflict to be resolved first

Hmm not sure if I like having two value functions... Using argval seems like a good solution tho!
Actually, if we assume reasonable use by the user. That is, a user does not set values to a constraint himself, we might not even need to wrap the .value() function at all!
Take the following (convoluted) example:
m = cp.Model()
arr = cp.intvar(0,10, shape=3, name="arr")
idx = cp.intvar(0,10, name="idx")
x = cp.boolvar(name="x")
y = cp.boolvar(name="y")

m += cp.AllEqual([cp.AllDifferent([arr[idx], 11, 12]),x,y])
m += idx == 7

Then, arr[idx] is undefined, hence will throw the exception.
As AllDifferent is the nearest Boolean context to the undefinedness, it should be set to False. But this is done by the argval call originating from AllEqual
E.g., the constraint becomes AllEqual(False, x,y) which is a perfectly valid constraint and can proceed as normal.
So basically what I'm saying is: the Boolean expression catching the undefinedness will never be at the top-level of the constraint model when the user is interested in the value of the decision variables. This is true as the model will be UNSAT when a constraint at toplevel is set to False because of the undefinedness so no values are assigned to the variables anyway.
So, as long as the value of the arguments of any expression are calculated using argval we do not need to put any logic about the exceptions into the individual expressions. This means we can revert the changes of the safe_value() and just put that logic into argval again like it used to be.

yeah exactly, .value() will only fail if it is called on a toplevel constraint with an undefined value directly underneath, because at all the other levels argval will take care of the undefinedness.
The extra safe_value function does feel quite useless, but we actually need it to be a class function because then it knows if it is being called on a boolean expression or not. argval can not know this..
I guess we could make it hidden _safe_value() and tell the user only about argval

@Wout4 A lot of PRs depoend on this one now. I think it is ready to merge?

Indeed, if it also looks good to you will merge it


BUG: Gitea integration sending wrong URLs to Gitea

First of all this  is a copy of my bug report which got automaticly closed (https://github.com/drone/drone/issues/2470).
Secondly @bradrydzewski said I should report this on https://discourse.drone.io/ - Since then my account didn't get approved so I'm opening this issue a second time.
I am running a drone ci instance using the following docker-compose.yml
version: '2'

networks:
  drone:
    external: false
  proxy:
    external:
      name: proxy

services:
  drone-server:
    image: drone/drone:0.8
    expose:
      - 8000
      - 9000
    volumes:
      - ./drone:/var/lib/drone/
    restart: always
    networks:
      - proxy
      - drone
    environment:
      - DRONE_OPEN=true
      - DRONE_HOST={{REMOVED}}
      - DRONE_SECRET={{REMOVED}}D
      - DRONE_GITEA=true
      - DRONE_GITEA_URL={{REMOVED}}
      - DRONE_GITEA_GIT_USERNAME=Drone
      - DRONE_GITEA_GIT_PASSWORD={{REMOVED}}
      - DRONE_GITEA_PRIVATE_MODE=true

  drone-agent:
    image: drone/agent:0.8

    command: agent
    restart: always
    networks:
      - drone
    depends_on:
      - drone-server
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    environment:
      - DRONE_SERVER=drone-server:9000
      - DRONE_SECRET={{REMOVED}}

After pushing into a activated repository Gitea shows the build status.

If the build succeeded the URL is working as expected (Redirecting to the defined DRONE_HOST)
But if a build is still pending or fails the URL redirects to http://drone-server:8000/
I don't think this is an intended behavior.
If you need any other details or configuration, let me know.

Also a Gitea maintainer confirmed that this is a drone issue: https://github.com/go-gitea/gitea/issues/4711#issuecomment-413056909

Looks like you have activated the repository before setting a proper DRONE_HOST environment variable. Please removed the webhook from Gitea and activate the repository again and it should work totally fine.
Besides that, I'm a maintainer on both projects and I'm running a Gitea and Drone setup on my own and I can't confirm any issue if Drone is configured correctly.

So now I have removed the webhook.
Confirmed that I set the DRONE_HOST in my docker-compose.yml.
Readded the webhook.
But still the status uses the wrong URL in the "pending" state.

Are you running drone and gitea behind a reverse proxy? Make sure to pass the forwarded for headers.

So yes I'm using it behind a proxy.
I now set the headers correctly, readded the webhook. (It still get's added automaticly with the container name), changed the url to the subdomain.domain.tld.
Now errors are displaying correctly using the right URL.
But a pending build still uses drone-server:8000/.

@tboerger Do you have any solution for my problem?...
This is a relay annoying bug...

there is no bug here. If you are running drone behind a reverse proxy, drone cannot ascertain its actual domain name in order to create a webhook with a proper url. So you have to set the X-Forwarded-For headers. We provide examples for a few different reverse proxy servers (see https://0-8-0.docs.drone.io/setup-with-nginx/)
drone has worked this way for 4 years. the above solution has worked for everyone else.

This is my complete nginx config:
    server {
      include ssl.conf;
      server_name drone.example.com;

      location / {
        set $upstream drone-server;
        proxy_pass http://$upstream:8000;
        proxy_set_header X-Forwarded-For $remote_addr;
        proxy_set_header X-Forwarded-Proto http;
        proxy_redirect off;
        proxy_http_version 1.1;
        proxy_buffering off;
        chunked_transfer_encoding off;
      }
    }

My reverse proxy is working fine, because the commit status is correctly applied on "success" and "error", but not on "pending".

The status URL for pending comes from X-Forwarded-For. The status URL for a completed build (success or error) comes from the DRONE_HOST variable [1]. If the pending URL is incomplete it would tell me that either 1) your webhook is not being routed through your reverse proxy (hence no X-Forwarded-For) or 2) your reverse proxy is not passing the headers correctly.
[1] https://discourse.drone.io/t/drone-host-in-webhooks/2164/2?u=bradrydzewski

0.8 got a known issue where the webhook doesn't get deleted if you deactivate a repo with Gitea.

I manually deleted the webhook.
And after a reactivation it's still using the docker-container hostname...

Okay I now migrated to version 1.0.
But now I'm not getting any build status updates on my commits. (Neither if a build is pending, failed or successful).
Are status reports currently not implemented in the 1.0 version?

statuses are implemented in 1.0.  If a request to create the status fails it would be written to the logs (in below format). Have you inspected your logs for any error messages?
		logger.WithError(err).
			Warnln("manager: cannot publish status")

Thanks a lot.
I will look into it :smile:

When you are there atm I have another issue with the Gitea integration.
If I create a merge request on gitea, the build uses the the merge request description not the title.
Also the git clone is failing:
Initialized empty Git repository in /drone/src/.git/
+ git fetch origin +refs/heads/master:
From https://git.example.com/Webteam/Core
 * branch            master     -> FETCH_HEAD
 * [new branch]      master     -> origin/master
+ git checkout master
Branch master set up to track remote branch master from origin.
Already on 'master'
+ git fetch origin refs/pull/69/head:
From https://git.example.com/Webteam/Core
 * branch            refs/pull/69/head -> FETCH_HEAD
+ git rebase 5369c3ec5d3122cef524fa952a0b7a154331c388
First, rewinding head to replay your work on top of it...
fatal: empty ident name (for<EMAIL_ADDRESS>not allowed

I recommend creating a discourse thread, since this issue is closed and this is getting a bit off topic. thanks :)

Okay, I opened a discourse.
But I cannot find anything how to contribute. How can I compile a new drone binary? How do I setup my dev environment?


 So I assume you are still building against the old version of rapidfuzz-cpp which had a bug.

Apparently the test for the system installation was broken and would just fallback to the non system version :sweat_smile:

I did publish a new version of the library which properly requires the latest version of rapidfuzz-cpp. Please let me know if the problem continues to occur when building rapidfuzz v3.8.1 with rapidfuzz-cpp v3.0.4

Btw I had a quick look at https://github.com/freebsd/freebsd-ports/blob/main/devel/py-rapidfuzz/Makefile.

${PYTHON_PKGNAMEPREFIX}rapidfuzz-capi==1.0.5:devel/py-rapidfuzz-capi@${PY_FLAVOR} \ is no longer required
jarowinkler-cpp>0:textproc/jarowinkler-cpp \ is no longer required
https://github.com/maxbachmann/RapidFuzz this is redirected by github, but could be updated to https://github.com/rapidfuzz/RapidFuzz (the same is true for https://github.com/maxbachmann/rapidfuzz-cpp)
I am surprised compiler:c++14-lang python is working, since the library requires C++17

@yurivict was this resolved?


Pickling a JAX array does not preserve its original device

Description
What I hope to achieve
The JAX arrays are created in a subprocess, evoked by multiprocessing.map, on CPU. I hope that when the arrays are sent to the main process, they are still on the same device (i.e. CPU). However, after they are sent to the main process, they are placed on the default device (i.e. GPU) instead.
import jax
import jax.numpy as np
import multiprocessing

def f():
    jax.config.update('jax_platforms', 'cpu')
    a = np.zeros((2,))
    print(a.device())  # TFRT_CPU_0
    return a

def main():
    ctx = multiprocessing.get_context('spawn')
    with ctx.Pool(1) as p:
        a = p.starmap(f, ((),))[0]
    print(a.device())  # gpu:0, expected TFRT_CPU_0

if __name__ == '__main__':
    main()

This also applies to the underlying pickle module
import jax
import jax.numpy as np
import pickle

jax.config.update('jax_platforms', 'cpu')

a = np.zeros((2,))
print(a.device())  # TFRT_CPU_0

with open('1.dat', 'wb') as f:
    pickle.dump(a, f)

import pickle

with open('1.dat', 'rb') as f:
    a = pickle.load(f)
print(a.device())  # gpu:0, expected TFRT_CPU_0

What jax/jaxlib version are you using?
jax 0.3.17, jaxlib 0.3.15+cuda11.cudnn82
Which accelerator(s) are you using?
GPU
Additional System Info
Python 3.10.6, Arch Linux x86_64

This is expected behavior; see the description from the CHANGELOG entry when pickle support was added: https://github.com/google/jax/blob/main/CHANGELOG.md#jax-0314-june-27-2022
The issue is that pickling and unpickling need not happen in the same environment, and so attempting to preserve the original device can be problematic; see https://github.com/google/jax/pull/10659 for further discussion, and let us know if you have any suggestions.

@jakevdp Thank you! I agree that attempting to preserve the original device can be problematic. My suggestion is that we should give priority to implementing a with block to specify the target device. For example: in PyTorch we can do:
with torch.cuda.device(2):  # specify default device
   ...  # create array on the default device

I remember that this issue was discussed in https://github.com/google/jax/issues/8879

https://github.com/google/jax/pull/9118 may have fixed this, but I'm not sure. Checking with @skye ...

Yes, I believe doing something like with jax.default_device(jax.devices("cpu")[0]) should work. Please let me know if it doesn't, I haven't tried it with pickle.

Unpickling of an array uses jax.device_put with no device argument, so I believe the default default device context manager should do the right thing.

To put a fine point on it, the analogue of code like this:
with torch.cuda.device(2):  # specify default device
   ...  # create array on the default device

Is something like this:
devices = jax.devices()
with jax.default_device(devices[2]):
  ... # create or load (e.g. unpickle) array on default device

I think this issue is resolved, but please reopen if not!

@mattjj Thank you for the reply, but this issue is not solved. jax.default_device works when creating the array, but does not work when loading the array from pickle:
import jax
import jax.numpy as np
import multiprocessing

def f():
    jax.config.update('jax_platforms', 'cpu')
    a = np.zeros((2,))
    print(a.device())  # TFRT_CPU_0
    return a

def main():
    device_cpu = jax.devices('cpu')[0]
    with jax.default_device(device_cpu):
        a = np.zeros((2,))
        print(a.device())  # TFRT_CPU_0

        ctx = multiprocessing.get_context('spawn')
        with ctx.Pool(1) as p:
            a = p.starmap(f, ((),))[0]
        print(a.device())  # gpu:0, expected TFRT_CPU_0

if __name__ == '__main__':
    main()

I found the cause of the problem

Unpickling of an array uses jax.device_put with no device argument, so I believe the default default device context manager should do the right thing.

But actually this does not work as expected:
import jax
import numpy as onp

device_cpu = jax.devices('cpu')[0]
with jax.default_device(device_cpu):
    a = onp.array([1., 2.])

    b = jax.device_put(a)
    print(b.device())  # gpu:0, not TFRT_CPU_0

@mattjj Please reopen this

Reopening and assigning to @skye – it looks like device_put does not respect the default device context. Is this intended?

I think that is not intended.
(@ayaka14732 thanks for following up and for the pings. Sorry I didn't notice your replies until now!)

Are there any updates on this? I'm wondering if I may be running into a related problem..
TL;DR recently updated jax, and code that used to run fine---using multiprocessing (forkserver) + jax (with default device / all arrays placed on CPU)---is now crashing due to memory overload on GPU. Monitoring the GPU, I can see that it starts by allocating 10Mb per process, which over time balloons to 100-400+, and ultimately crashes.
Thinking this might be caused by pickle (underlying multiprocessing) not playing well with device placement


Datatable failing to load in certain circumstances

Example column value is:
java -cp $HELLO_WORLD blah.blah.blah.blah.blah -v FOO -W BAR -a http://localhost:1000/service -j $MYDIR/dir/file.xml -p 1000 -P 1001

Issue with trunc(date, 'IW')  and to_char function w/i Oracle db. table does not load.

@lukerhoffman  -- issue here is with how mocaResults.ts is dealing with dates. I did some tests and this processing is unnecessary and actually hurting things. Removing this processing will fix your/all other date issues. I plan on doing so for the next release.
That being said, I am also looking into potential data grid alternatives.

This is fixed in v1.6.26!

This is fixed in v1.6.26!


[Hotfix 4.0.1] Release notes

The changes aren't up-to-date with #1474. Also, some of my suggestions weren't reviewed in that PR.


Introduce pytest factory boy

See https://github.com/pytest-dev/pytest-factoryboy

Add user factory
Helper to easily register factories
Use factory in test_user

It potentially makes most sense to integrate (pytest-randomly)[https://github.com/pytest-dev/pytest-randomly] with a fix seed for reproducible builds with factory boy as well.


Basic Reflection Support

[x] Reflection metadata transform (transform ECMA metadata and type system entities to the native metadata format)
[x] Make sure reflection gets initialized at startup path
[x] Emit a mapping table between EETypes and native metadata
[x] Emit a mapping table between fields offsets and native metadata
[x] Emit a mapping table for methods
[x] Generate dynamic invoke stubs for reflection-invokable methods
[x] Clean out calls to System.Private.TypeLoader from System.Private.Reflection.Execution (this is not useful without __Canon instantiations anyway)

Out of scope (not "basic reflection"):

reflection invoking virtual and interface methods
reflection field get/set for GC static/threadstatic fields
reflection blocking
reflection on generic types/methods
Array.CreateInstance
Type.GetType search in current assembly
Type.MakePointerType
RuntimeMethodHandle/RuntimeFieldHandle

Known dependencies on other tasks:
#469, #274, #273, #272

"Basic reflection" is done.


SAM failed

I opened it to show only one game, and entered the game ID with achievements and opened it to show no achievements

See #152.


No module named 'pibooth_fire_remote'

I've cloned the git and run 'sudo python3 setup.py install' to install the plugin, which seems to have completed successfully.
After the above, when trying to start pibooth I'm getting the following error:
ModuleNotFoundError: No module named 'pibooth_fire_remote'
Any advise on this?
Thanks

Hi! The normal way would be to install it using pip install pibooth-fire-remote, however I did not yet create a new release and the last one has a bug. What you can do is just cloning the repo without installing and specify it in the pibooth config.
See here https://pibooth.readthedocs.io/en/stable/sources/plugins/plugins.html

Sorry for the delayed response.
Thanks for that. So I've closed the repo and referenced it as a plugin. pibooth loads, and fire-remote is shown as a plugin, but the enter button or settings button don't do anything. Any thoughts/advise?

Did you connect it to your pi correctly? E.g. Enter button should work in
console.
m4est @.***> schrieb am So., 4. Juni 2023, 15:06:

Sorry for the delayed response.
Thanks for that. So I've closed the repo and referenced it as a plugin.
pibooth loads, and fire-remote is shown as a plugin, but the enter button
or settings button don't do anything. Any thoughts/advise?
—
Reply to this email directly, view it on GitHub
https://github.com/chilipp89/pibooth-fire-remote/issues/2#issuecomment-1575563314,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APOUBN7B2YQ3B3QKIN5YTEDXJSB43ANCNFSM6AAAAAAWINQAMI
.
You are receiving this because you commented.Message ID:
@.***>

The remote is connected, I don't see any console events for it though.
However the left and right to work once I progress from the first page of pibooth - but left and right works without having the plugin enabled.

My guess is that your remote has a different key mapping.
Check out https://python-evdev.readthedocs.io/en/latest/usage.html
m4est @.***> schrieb am So., 4. Juni 2023, 15:59:

The remote is connected, I don't see any console events for it though.
However the left and right to work once I progress from the first page of
pibooth - but left and right works without having the plugin enabled.
—
Reply to this email directly, view it on GitHub
https://github.com/chilipp89/pibooth-fire-remote/issues/2#issuecomment-1575580570,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APOUBNYDDJ2M3TFW5Y5MDN3XJSIERANCNFSM6AAAAAAWINQAMI
.
You are receiving this because you commented.Message ID:
@.***>


[Feature Request] Clarify tolerance percentage format

Is your feature request related to a problem? Please describe.
Clarify that percentage tolerance should be expressed as a decimal value as it could be misinterpreted to be a nominal value and cause silent errors.
Describe the solution you'd like
Simple addition to readme. I actually already have something ready to go here: https://github.com/mbkupfer/dbt-expectations/commit/e4735566d701b41fffb0c02cc690033bf29c4a56, but realized I needed to first open an issue the pull request.
Describe alternatives you've considered
n/a
Additional context
Backstory, I made the mistake of assuming it was nominal and was thinking I was testing a 0.5% tolerance when in fact it was looking at a 50% tolerance! Needless to say, I should have read the source code beforehand, but I'm sure it would be more accessible if we can just add a few extra words in the readme :)

Sounds good to me, thanks


feat/frontend/admin/students: add Table.svelte component and student dashboard route

Add the table component
Add the student dashboard page route
Connected table component to student dashboard using dummy data
Started +page.server.ts (unfinished)

I found the reason why it selectStudentDB returns a lot of unnecessary information! It's because Status.value is a of type Response | null. If it has a value, we'd need to use await Response?.json() to access the list of objects containing student information.
I'll first fix the Student class and to return a list of Student objects when selectStudent is called.

P.S. I'm really sorry for merging and committing backend changes here in your branch. But it save you time merging! Ahahhaa, I will do better next time :>


Brainstorming Document

Add and build on my old brainstorming documents to remind myself the data, analyses, functions necessary to answer some questions in there.

I did just add the file RT Objectives & Analyses 20181108.docx which summarises my initial objectives for the RT project and analyses to address each of those objectives. Might be useful to guide us on additional data or functions that need to be added to the package.


Upgrade Windows runners to windows-2022

r? @Amanieu
(rust-highfive has picked a reviewer for you, use r? to override)

@bors r+

:pushpin: Commit f94e9477dbf3c1168d14edd3a454990f1c266ece has been approved by Amanieu

:hourglass: Testing commit f94e9477dbf3c1168d14edd3a454990f1c266ece with merge f70d55b9f57730e917e5cf8d0e90549253a7034f...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing f70d55b9f57730e917e5cf8d0e90549253a7034f to master...


feat: add SPDX support to scorecard

This adds SPDX support to the parlay scorecard enrich command. Logic is pretty much the same as it is for CycloneDX, just using a few early returns instead of nested ifs.
I tried to see if we could improve perf by making a HEAD request to the Scorecard API; which they unfortunately don’t support…
$ parlay scorecard enrich testing/sbom.spdx-2.3.json | jq ".packages[1]"
{
  "name": "debug",
  "SPDXID": "SPDXRef-2-debug-1.0.5",
  "versionInfo": "1.0.5",
  "downloadLocation": "NOASSERTION",
  "filesAnalyzed": true,
  "copyrightText": "NOASSERTION",
  "externalRefs": [
    {
      "referenceCategory": "PACKAGE-MANAGER",
      "referenceType": "purl",
      "referenceLocator"<EMAIL_ADDRESS>    },
    {
      "referenceCategory": "OTHER",
      "referenceType": "openssfscorecard",
      "referenceLocator": "https://api.securityscorecards.dev/projects/github.com/debug-js/debug"
    }
  ]
}

Once this is merged, I’d like to have a stab at refactoring all the sizedwaitgroup repetition.

Closes #3


Fix the GCD estimation

So apparently serverticks are the cause as to why we can get faster/slower GCD estimates, in a 0.05s range around the real GCD.
Initial idea is to locate peaks in the GCD histogram and then rebin the whole thing since it's most likely to have the client side GCD value as the GCD and not GCD +- 0.05.

This has been superseded by the work for the SpeedStatAdapter and updating the ABC calculations.  If we determine that we still need to tune the estimates in light of the ABC calculation updates, we will need to port this work to the new data structure.


ASN1 templates: application tags for sequences?

Sorry if it's not a right place to ask such questions, the thing is I'm trying to use new asn.1 templates feature and in my asn module I use custom application tags. How do I specify them in sequences definition  using macros from asnt1.h?
I mean, I have such a bnf:
Foo ::= [APPLICATION 13] SEQUENCE {
m01 INTEGER,
m02 OCTET STRING
}
And I need to override default sequence tag.

The appropriate place for this kind of question is<EMAIL_ADDRESS> You do need to subscribe, please see here for more info.


Add RHEL requirements for building GUI

Without this there will be no GUI.
Tested on RHEL8.

This change actually breaks our test of RHEL using docker:
https://github.com/The-OpenROAD-Project/OpenROAD/actions/runs/4491586294/jobs/7900385085?pr=3063
Are you using some specific distribution, or maybe we are missing some other repo source?

I may be wrong but if i run this on registered RHEL8 I am getting extra repositories namely (rhel-8-for-x86_64-appstream-rpms).
It seem to be related to this message:
This system is not registered with an entitlement server. You can use subscription-manager to register.

Those packages are available for example from here: https://centos.pkgs.org/8/centos-appstream-x86_64/
Feel free to close this or I can try to find a way to add those packages.

Other way would be to check if the repository rhel-8-for-x86_64-appstream-rpms exit.

Other way would be to check if the repository rhel-8-for-x86_64-appstream-rpms exit.

Also, to enable epel-next extra there is a much simple way see here:
# centos extra repositories
RUN dnf -y config-manager --set-enabled powertools
RUN dnf -y install epel-release epel-next-release

Thanks @cbalint13 for the expert input

@themperek ,
As side note info regarding RHEL/Fedora:

There are regular (weekly) builds on COPR
Also some walk-through the full VLSI suite

That is quite nice! Thank you @cbalint13


Can't connect to mongoDB

I am using mlab remote mongoDB and get this message added the connection uri to the .env. I have node v 7.2.1, npm 4.0.5
MongoError: failed to connect to server [undefined:27017] on first connect [MongoError: getaddrinfo ENOTFOUND undefined undefined:27017]

i am also facing same problem

@mylastore its because your process.env.MONGO_DB_URI is undefined.
Before "npm start" you need to manually export MONGO_DB_URI variable with:
export MONGO_DB_URI=your_remote_mlab_uri
You can setup dotenv on project to user an .env file.


IFormFile

[ ] Update doc with IFormFile and IFormFileCollection Support
[ ] Update what's new

Code merged with #26494
See also test sample

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b09824ab-b051-75a1-13b7-b0e281cc46e0
Version Independent ID: b09824ab-b051-75a1-13b7-b0e281cc46e0
Content: Minimal APIs overview
Content Source: aspnetcore/fundamentals/minimal-apis.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Fixed in https://github.com/dotnet/AspNetCore.Docs/pull/26988


Added logging for when Jobs have triggered

Also:

unified variable naming a bit more, so it's consistent across projects
inlined the GetScopedJobAndExecuteAsync function

Failing test is flaky due to actions being slow sometimes, unsure how to fix it 😓


"EDDTableAggregateRows" - Time, Latitude and Longitude min/max values are calculated from the first child only

Describe the bug
EDDTableAggregateRows range for time is not the min/max of all the child.
Also other variables, like latitude and longitude have this problem.
Some variables are not affected by this problem and the min/max value is calculated from all the child
To Reproduce

Create a "EDDTableAggregateRows" datasets with two (or more) child of type ""EDDTableFromErddap"
Time of the first datasets must be different from the other. As an example, first child has time from 2013-01-01 to 2020-03-31 and the second one has data from 2024-01-01 to today
The "EDDTableAggregateRows" time will be from 2013-01-01 to 2020-03-31

With real data, if you create this dataset:
<dataset type="EDDTableAggregateRows" datasetID="TS_SLEV_TAD" active="true">
	<reloadEveryNMinutes>60</reloadEveryNMinutes>
	<dataset type="EDDTableFromErddap" datasetID="TS_SLEV_TAD_15_composite" active="true" >
		<reloadEveryNMinutes>60</reloadEveryNMinutes>
		<sourceUrl>https://er1webapps.emodnet-physics.eu/erddap/tabledap/TS_SLEV_TAD_15</sourceUrl>
	</dataset>
	<dataset type="EDDTableFromErddap" datasetID="TS_SLEV_TAD_800_composite" active="true" >
		<reloadEveryNMinutes>60</reloadEveryNMinutes>
		<sourceUrl>https://er1webapps.emodnet-physics.eu/erddap/tabledap/TS_SLEV_TAD_800</sourceUrl>
	</dataset>
</dataset>

https://er1webapps.emodnet-physics.eu/erddap/tabledap/TS_SLEV_TAD_15 time is 2013-06-07T09:00:00Z to  2013-06-13T09:57:15Z
https://er1webapps.emodnet-physics.eu/erddap/tabledap/TS_SLEV_TAD_800 time is  2022-09-01T00:03:00Z to  2023-12-19T11:03:00Z
The EDDTableAggregateRows TS_SLEV_TAD time is 2013-06-07T09:00:00Z	to  2013-06-13T09:57:15Z (instead of 2013-06-07T09:00:00Z to 2023-12-19T11:03:00Z)
Same problem with latitude and longitude.
Other variable (like SLEV) min/max are calculated in the right way.
Expected behavior
time range, latitude and longitude of the EDDTableAggregateRows dataset to be the min / max of all the child datasets
Screenshots
not applicable
Server
I'm using ERDDAP  Version 2.23 in a docker container using axiom/docker-erddap:2.23-jdk17-openjdk image
Desktop (please complete the following information):

Windows, Linux
Any Browser

Additional context
None

Hi!
I've (probably) found the problem in the code for the time variable in the EDVTimeStamp class.
I'll make some test and if all is fine I'll make a pull request with the changes.
I'm still working on the same problem for latitude, longitude and depth variables.

@MarcoAlbaETT That's great. I've assigned this issue to you since you're working on it. Let me know if you have any questions.

Hi @ChrisJohnNOAA, the bug fix is ready.
Sadly I've trouble running the tests. I've changed only EDDTableAggregateRows.java class, but the tests fail for EDVTimeStampTests. I think this is something related to the language settings of my pc.
Is it fine to make a pull request without a succesful test?

Yeah, go ahead and make the pull request. I'm aware that some tests can fail on other machines and have been trying to find and fix those to make them more reliable.


Consider passing through PEX_ env vars to PEXed Pex.

On PEX startup, all PEX_ env vars are stripped before handing off control to the underlying application:
https://github.com/pantsbuild/pex/blob/73ce2f4b4fdc1fe3ad76779c06f0b9a25f443384/pex/pex.py#L416-L419
https://github.com/pantsbuild/pex/blob/73ce2f4b4fdc1fe3ad76779c06f0b9a25f443384/pex/pex.py#L45-L54
When that application is Pex itself (Someone uses the PEXed Pex we release for example), this leads to surprising behavior where Pex does not respond to the same environment variable control it does respond to when installed as a wheel.
It seems like this should be fixed by either passing through the PEX_ env vars in this special case (which is likely hard to detect) - or else we should revisit stripping PEX_ env vars wholesale.

See #180

Stripping of PEX_ variables seems to have been done to solve a problem. Although I'm not sure what the problem was, the use case for not stripping seems narrow - it's only really useful to not strip when the PEX if either running Pex itself or launching other PEXes and the explicit desire is to have PEX_ env vars pass through. It seems simple enough to add a PexInfo / Pex CLI option for this and just keep the current default of stripping the same. The PEX Pex ships can be configured to not strip and other legitimate use cases can be determined by end users likewise or via the API of PexInfo.


"7z" utility somehow not recognized on MacOS/Travic CI

See the output, 7zip is installed, and "7z" utility is available on command line. Yet aqtinstall complains.
Called like this: aqt install -E 7z -O "$QTPATH" 5.15.2 mac desktop clang_64 -m qtwebengine
Output of aqtinstall:
Traceback (most recent call last):
  File "/usr/local/bin/aqt", line 5, in <module>
    from aqt.__main__ import main
  File "/usr/local/lib/python2.7/site-packages/aqt/__init__.py", line 25, in <module>
    from aqt.cli import Cli
  File "/usr/local/lib/python2.7/site-packages/aqt/cli.py", line 83
    raise Exception('Specified 7zip command executable does not exist: {!r}'.format(sevenzip)) from e

Output of 7z
7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21
p7zip Version 16.02 (locale=utf8,Utf16=on,HugeFiles=on,64 bits,2 CPUs x64)
Usage: 7z <command> [<switches>...] <archive_name> [<file_names>...]
<EMAIL_ADDRESS><Commands>
  a : Add files to archive
  b : Benchmark
  d : Delete files from archive
  e : Extract files from archive (without using directory names)
  h : Calculate hash values for files
  i : Show information about supported formats
  l : List contents of archive
  rn : Rename files in archive
  t : Test integrity of archive
  u : Update files to archive
  x : eXtract files with full paths
<Switches>
  -- : Stop switches parsing
  -ai[r[-|0]]{@listfile|!wildcard} : Include archives
  -ax[r[-|0]]{@listfile|!wildcard} : eXclude archives
  -ao{a|s|t|u} : set Overwrite mode
  -an : disable archive_name field
  -bb[0-3] : set output log level
  -bd : disable progress indicator
  -bs{o|e|p}{0|1|2} : set output stream for output/error/progress line
  -bt : show execution time statistics
  -i[r[-|0]]{@listfile|!wildcard} : Include filenames
  -m{Parameters} : set compression Method
    -mmt[N] : set number of CPU threads
  -o{Directory} : set Output directory
  -p{Password} : set Password
  -r[-|0] : Recurse subdirectories
  -sa{a|e|s} : set Archive name mode
  -scc{UTF-8|WIN|DOS} : set charset for for console input/output
  -scs{UTF-8|UTF-16LE|UTF-16BE|WIN|DOS|{id}} : set charset for list files
  -scrc[CRC32|CRC64|SHA1|SHA256|*] : set hash function for x, e, h commands
  -sdel : delete files after compression
  -seml[.] : send archive by email
  -sfx[{name}] : Create SFX archive
  -si[{name}] : read data from stdin
  -slp : set Large Pages mode
  -slt : show technical information for l (List) command
  -snh : store hard links as links
  -snl : store symbolic links as links
  -sni : store NT security information
  -sns[-] : store NTFS alternate streams
  -so : write data to stdout
  -spd : disable wildcard matching for file names
  -spe : eliminate duplication of root folder for extract command
  -spf : use fully qualified file paths
  -ssc[-] : set sensitive case mode
  -ssw : compress shared files
  -stl : set archive timestamp from the most recently modified file
  -stm{HexMask} : set CPU thread affinity mask (hexadecimal number)
  -stx{Type} : exclude archive type
  -t{Type} : Set type of archive
  -u[-][p#][q#][r#][x#][y#][z#][!newArchiveName] : Update options
  -v{Size}[b|k|m|g] : Create volumes
  -w[{path}] : assign Work directory. Empty path means a temporary directory
  -x[r[-|0]]{@listfile|!wildcard} : eXclude filenames
  -y : assume Yes on all queries

Does 7zip command is in the PATH on your python  environment?
For example, is a following small snippet working?
$ python
>>>  import subprocess
>>>  subprocess.run(['7z', '--help'])

Hard to test, but yes AFAIK 7z is in the path.
But anyway I managed to fix it, my TravisCI script was installing also package homebrew/p7zip which was probably source of the problem. I removed the package, also removed "-E" clause from the call and now it's working.
It seems that aqtinstall does not work well with p7zip package from homebrew, but I workarounded so you can probably close.

An exception is happened at a line  subprocess.run(sevenzip, '--help']) to test -E argument that is in sevenzip variable.
That is why I asked you a test. You can add a full path of a 7z command.

Here is travis output, at the end there is first the output of "7z" command entered into CLI, then output of the above "aqt ... install -E..." command:
https://travis-ci.org/github/martinrotter/rssguard/jobs/746037382

You seems to use deprecated python 2.7 which is not supported by aqtinstall.
And python 7zip support requires python 3.7.5
Here is a part of log you mentions in above comment.
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
7848Collecting aqtinstall
7849  Downloading https://files.pythonhosted.org/packages/3e/8a/28832f092ef7e9a8eb14879ac907a6be29c4dab7509846b276eb152714e3/aqtinstall-0.9.5-py2.py3-none-any.whl
7850Requirement already satisfied: wheel in /usr/local/lib/python2.7/site-packages (from aqtinstall) (0.33.6)

It seems better to change from pip install aqtinstall to python3.9 -m pip install aqtinstall and from aqt install  to python3.9 -m aqt install in your scripts.

I checked it and you are actually right. At one point I also realised that but then forgot about it. Nevermind, your tool works just fine now
https://travis-ci.org/github/martinrotter/rssguard/jobs/746136783#L3212


Add getStreams APIs to MediaStream classes

Added a handful of get*Streams APIs to the MediaStream classes.

Again, looks pretty straightforward and shouldn't be a problem to merge. Thanks for adding these extensions!


[Outlook] (autolaunch) getAccessToken not supported

Fixes https://github.com/OfficeDev/office-js/issues/1512.

Docs Build status updates of commit fa495c0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/outlook/autolaunch.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


3/12 AM Publish

:warning: Validation status: warnings

File
Status
Preview URL
Details

:warning:Warning

Details

azurermps-5.5.0/AzureRM.Compute/Add-AzureRmVmssSecret.md
:warning:Warning

Details

azurermps-5.5.0/AzureRM.Compute/Add-AzureRmVMNetworkInterface.md
:warning:Warning

Details

azurermps-5.5.0/AzureRM.Compute/Add-AzureRmVMSecret.md
:warning:Warning

Details

azurermps-5.4.0/Azure.Storage/Azure.Storage.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageBlob.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageBlobContent.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageBlobCopyState.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageCORSRule.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageContainer.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageContainerStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageFile.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageFileContent.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageFileCopyState.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageQueue.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageQueueStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageServiceLoggingProperty.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageServiceMetricsProperty.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageServiceProperty.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageShare.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageShareStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageTable.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Get-AzureStorageTableStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageAccountSASToken.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageBlobSASToken.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageContainer.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageContainerSASToken.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageContainerStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageContext.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageDirectory.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageFileSASToken.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageQueue.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageQueueSASToken.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageQueueStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageShare.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageShareSASToken.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageShareStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageTable.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageTableSASToken.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/New-AzureStorageTableStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Remove-AzureStorageBlob.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Remove-AzureStorageCORSRule.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Remove-AzureStorageContainer.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Remove-AzureStorageContainerStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Remove-AzureStorageDirectory.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Remove-AzureStorageFile.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Remove-AzureStorageQueue.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Remove-AzureStorageQueueStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Remove-AzureStorageShare.md
:white_check_mark:Succeeded

azurermps-5.4.0/Azure.Storage/Remove-AzureStorageShareStoredAccessPolicy.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.

[Warning] 'W:\ijeq-s\docs-conceptual/index.md' would be overwritten by redirection rule configured in master redirection file .openpublishing.redirection.json. Please remove the original file to resolve this warning.
[Warning] Error happen when converting azurermps-4.4.1/module/toc.json to Pdf. Details: The process cannot access the file 'W:\ijeq-o-unknown\azureps_en-us_module_toc.pdf' because it is being used by another process.
[Warning] Error happen when converting azurermps-1.2.9/azure/toc.json to Pdf. Details: The process cannot access the file 'W:\ijeq-o-unknown\azureps_en-us_azure_toc.pdf' because it is being used by another process.
[Warning] Error happen when converting azurermps-4.4.1/azure/toc.json to Pdf. Details: The key already existed in the dictionary.
[Warning] Error happen when converting azurermps-1.7.0/module/toc.json to Pdf. Details: The key already existed in the dictionary.
[Warning] Error happen when converting azurermps-5.5.0/module/toc.json to Pdf. Details: The key already existed in the dictionary.
[Warning] Error happen when converting azurermps-1.7.0/azure/toc.json to Pdf. Details: The key already existed in the dictionary.
[Warning] Error happen when converting azurermps-5.5.0/azure/toc.json to Pdf. Details: The key already existed in the dictionary.
[Warning] Error happen when converting azurermps-2.2.0/azure/toc.json to Pdf. Details: The process cannot access the file 'W:\ijeq-o-unknown\azureps_en-us_azure_toc.pdf' because it is being used by another process.
[Warning] Error happen when converting azuresmps-4.0.0/azure/servicemanagement/toc.json to Pdf. Details: The process cannot access the file 'W:\ijeq-o-unknown\azureps_en-us_azure_servicemanagement_toc.pdf' because it is being used by another process.
[Warning] Error happen when converting azurermps-2.2.0/module/toc.json to Pdf. Details: The key already existed in the dictionary.
[Warning] Error happen when converting azuresmps-4.0.0/module/servicemanagement/toc.json to Pdf. Details: The key already existed in the dictionary.
[Warning] Error happen when converting azurermps-3.8.0/module/toc.json to Pdf. Details: The key already existed in the dictionary.

azurermps-5.5.0/AzureRM.Compute/Add-AzureRmVmssSecret.md

[Warning] Invalid file link:(~/azurermps-5.5.0/AzureRM.Compute/Set-AzureKeyVaultSecret.md).

azurermps-5.5.0/AzureRM.Compute/Add-AzureRmVMNetworkInterface.md

[Warning] Invalid file link:(~/azurermps-5.5.0/AzureRM.Compute/Get-AzureRmNetworkInterface.md).

azurermps-5.5.0/AzureRM.Compute/Add-AzureRmVMSecret.md

[Warning] Invalid file link:(~/azurermps-5.5.0/AzureRM.Compute/Set-AzureKeyVaultSecret.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Feature/frf0002

added page for registration user. added and changed user controller's method in order to ensure that login, email are unique. added and changed tests.

add registration form


[Need Help] Upload failed with "E: UNPROCESSABLE" (but actually uploaded?)

I was trying to uploading several dependent commits and ran into "E: UNPROCESSABLE" errors.
Version: 0.1.5 (from pip)

I tries to upload all and ran into confliction: You must specify relative branches to prevent this conflict!.
It is normal, but revup stores metadata in commits -- that is to rollback and amend commits chain. It would be better if revup can take metadata from other sources like command line.

So I created a branch, set to the commit before the confliction, but got error. (with fork; --trim-tags)

$ revup upload
...

Looking at github web ui, it seems that the commits are already uploaded to github.
e.g. https://github.com/manga-download/hakuneko/compare/master...myocytebd:hakuneko-tmp:9634838+myocytebd/revup/master/proxy.switch
Is something wrong with the upload?

Then I try to amend and upload the conflicted commit with relative branch.
revup probably treats previous 4 commit uploads failed and re-upload them.

Looking at github web ui, it seems that the commit is uploaded to github.
https://github.com/myocytebd/hakuneko-tmp/tree/9634838+myocytebd/revup/master/batch_download
Log: https://pastebin.com/cfhzTxUt

This is because your git user is configured as "9634838+myocytebd" which probably comes from your email. revup creates branches using your email name + branch name + topic name, but its not accounting for characters that are valid in emails but not valid in git branches. I recommend you work around this for now by configuring an email that doesn't contain special characters.
for reference see https://docs.github.com/en/get-started/using-git/dealing-with-special-characters-in-branch-and-tag-names

The English alphabet (a to z and A to Z)
Numbers (0 to 9)
A limited set of punctuation characters:
period (.)
hyphen (-)
underscore (_)
forward slash (/)
To avoid confusion, you should start branch names with a letter.```


[Feature]: CI tests support run on podman

What this PR does / why we need it:

Support run CI test on podman.

Which issue this PR fixes:

fixes #
Special notes for your reviewer:

It is better to change nginx ports to 8080(or any >= 1024 port).

Release note:

Can you work on the pr #2973 ？

Can you work on the pr #2973 ？

Do you mean change base branch to #2973?

Can you work on the pr #2973 ？

Do you mean change base branch to #2973?

support podman based on branch docker-yml and merge all to master in the PR.

Can you work on the pr #2973 ？

Do you mean change base branch to #2973?

support podman based on branch docker-yml and merge all to master in the PR.

OK, let me do it.

@sejust Please review again.

Maybe we should enable CI tests for docker-yml branch?

Maybe we should enable CI tests for docker-yml branch?

sorry，I have force updated branch docker-yml, Rebase on it then merge to master.

Maybe we should enable CI tests for docker-yml branch?

sorry，I have force updated branch docker-yml, Rebase on it then merge to master.

Done.


[BUG] - Accordion doesn't handle selectedKeys changes

NextUI Version
2.0.19
Describe the bug
It's only possible to update accordion selection through the onSelectionChange handler. I have attached a link to a codesandbox demonstrating a simple example where accordions are used as steps with Back/Next buttons. When trying to change selectedKeys - nothing happens.
  const [selectedKeys, setSelectedKeys] = React.useState<Selection>(new Set(["1"]));

  return (
    <Accordion
      selectedKeys={selectedKeys}
      onSelectionChange={setSelectedKeys}
    >
      <AccordionItem key="1" aria-label="Accordion 1" title="Accordion 1">
        <Button onClick={() => setSelectedKeys(new Set(["2"]))}>Next</Button>
      </AccordionItem>
    </Accordion>
)

Your Example Website or App
https://codesandbox.io/p/sandbox/reverent-maria-vr8229
Steps to Reproduce the Bug or Issue

Click on the link to sandbox
See accordions
Click on the "Next" button

Expected behavior
I'd expect that it's possible to update selectedKeys from any handler by just returning new Set of values (new Set())
Screenshots or Videos
No response
Operating System Version
macOS 12.3.1
Browser
Chrome

Hey @wolkyura thanks for reporting this, could you please open this issue on the template repo? https://github.com/nextui-org/next-app-template/issues
Thanks!

I tried to change Set() to string[], but it didn't work either (https://codesandbox.io/p/sandbox/busy-leftpad-5xy9p6).
The example of controlled Acoordion uses new Set() (https://nextui.org/docs/components/accordion#controlled):

Also, I think it's a bit confusing that state and setter have different types

Yeah, this is a bug. What I think is happening is that the onSelectionChange doesn't pass through the state change to the actual rendered component.

Hey guys, we're looking into this, but yes it is a bug. Thanks, @wolkyura for reporting it


[Flaky Test] ControllerManager Shoot Controller Suite fails with data race

/area testing
/kind flake
/priority 3
Which test(s)/suite(s) are flaking:
ControllerManager Shoot Controller Suite and Gardener Envtest Suite fail with data race
CI link:

https://concourse.ci.gardener.cloud/teams/gardener/pipelines/gardener-master/jobs/master-head-update-job/builds/234
https://concourse.ci.gardener.cloud/teams/gardener/pipelines/gardener-master/jobs/master-head-update-job/builds/233
https://concourse.ci.gardener.cloud/builds/11207009

Reason for failure:
Anything else we need to know:

Yep, also saw this one...
It seems like it wasn't the best idea to start g-api in-process and we should probably reconsider building a binary and executing that one instead.
Ref https://github.com/gardener/gardener/issues/3765

Should we disable the test for now until we have sorted things out in the envtest package?

It seems like it wasn't the best idea to start g-api in-process and we should probably reconsider building a binary and executing that one instead.

I decided to not build a binary beforehand and keep running g-api in-process because

we don't have to think about test result caching for envtest suites
we don't have to think about building binaries in make {verify,test,...}
test packages can still be executed easily with go test / ginkgo without building binaries in pkg/envtest
k/k uses the same approach in its integration tests

To fix the data race in the API server described in this issue, I rather isolated the integration tests (again just like k/k does) and just disabled the race detector for them: https://github.com/gardener/gardener/pull/4265.


Need a reference page for dnx

We need a page that would contain a description for each command and each option

All of DNX (including DNU) will soon be replaced by the new .NET CLI, which will be documented as part of the .NET docs. Closing.


fix(Quantic): issue managing two document suggestions with the same title fixed

SVCC-449

What was wrong?
When document suggestion returns 2 items with same title, if user expand 1 document, it will automatically close the other documents
What is the correct behaviour ?
We should handle this case, even if 2 items with the same title, it should work properly

From the PR description:

We should handle this case, even if 2 items with the same title, it should work properly

"it should work properly" is not clear to me. Can you please define what is the expected behavior?


[Question] StreamingOutsideDTWebVid cache_limit for video

Do I understand correctly that the cache_limit parameter only works for MDS shards and does not index extra_local for downloading videos?
https://github.com/mosaicml/streaming/blob/5f939c9057b041f10342dfc5744d2d3880e3f14b/streaming/multimodal/webvid.py#L210
If so, is it possible to clear the folder from old videos using an additional cache_limit ?
Best Regard, Alex.

Thanks for the answer!
I have another question, is it possible to work with ZIP or TAR archives as it is implemented in the webdataset library?
https://github.com/webdataset/webdataset

Hey, we don't offer direct support for zip or tar since Streaming requires the data to be in a predictable format (as written by our Writer classes, such as MDSWriter, JSONWriter, CSVWriter, etc) so that the dataset knows how to access particular samples with very low latency.
However, the Writer classes do offer compression of shards if you want to save space. See this section in the docs for more info on writing datasets & compression.


About the gnn

Hi, I have a question about the communication radius. I notice that you adjust the radius dynamically to ensure the graph is connected. I wonder that if this setting will make each agents to communicate with at least one other agent? If I want to use gnn for communication as you did, do I need to make the graph connected? My project is about MAPF and I want the agents to communicate with other agents within a fixed communication radius. That means that some agents will not be in the communication graph so I'm not sure whether GNN works in this situation.

@StormstoutY can you share data download from the link, i did message to access the data for the repository but no response


Renamed enrol to enroll for the Rewards Program.

This is in line with the US English we're trying to use everywhere 👍


https orphan connection

What does this PR do?
This PR addresses the issue with KeyTuple creation from a ConnectionStats object, ensuring that all possible KeyTuples are created without any omissions. Additionally, this PR includes relevant debug logs that will facilitate investigating similar issues in the future.

Motivation
We observed a bug while attempting to capture HTTPS traffic in the following environment:

HTTPS client run on machine A
NGNIX server runs as a as a docker container, datadog agent runs as a bare process on machine B

Example Scenario
Client machine:

IP address: <IP_ADDRESS>
Command executed: curl -k https://<IP_ADDRESS>:8443/index.php

Server machine:

IP address: <IP_ADDRESS>
Running processes: system-probe, process-agent, and nginx/php-fpm containers
Docker network NGINX IP: <IP_ADDRESS>

Analyzed System-Probe Logs
After converting numbers to IP addresses, the system-probe logs showed:
[<IP_ADDRESS>:1443 ⇄ <IP_ADDRESS>:47424] xlated [<IP_ADDRESS>:47424 ⇄ <IP_ADDRESS>:8443]
Converted to {0 <IP_ADDRESS> 0 <IP_ADDRESS> 8443 47424}

[<IP_ADDRESS>:1443 ⇄ <IP_ADDRESS>:47424] xlated [<IP_ADDRESS>:47424 ⇄ <IP_ADDRESS>:8443]
Converted to {0 <IP_ADDRESS> 0 <IP_ADDRESS> 47424 8443}

http orphan {0 <IP_ADDRESS> 0 <IP_ADDRESS> 47424 1443}

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

Wondering if we can add a kitchen test to ensure we won't have any breaking changes in the future

@guyarb added UT for HTTPKeyTuplesFromConn


Feature/add labeler workflow

Pull Request Overview
This pull request adds: a basic github workflow for labeling PRs.
The labeler is structured as follows:

Area-Based Labels:

core/execution/validation/tests/examples: Adds a tag based on the location of the modifications

Priority-Based Labels:

priority-high:

Added to HOTFIXES, changes to the actual source code, and modifications to GitHub workflows.
These are of high priority because the modifications directly affect core functionality.

priority-medium:

Added to modifications of tests.
Note: This needs further discussion as some tests might test core functionality (potentially priority-high), while others test additional/experimental features (potentially priority-medium).

priority-low:

Added to modifications of examples that do not affect the functionality of the actual interpreter.

Goal-Based Labels

hotfix/bugfix/features: Adds a label based on the main goal of the branch (what problem it solves).

Testing Strategy
N/A
TODO or Help Wanted
This pull request still needs an opinion from @wucke13 regarding the usage of priority-based labels.
Do you think it's overkill for now to have priority labels and that they should be added later, or is it fine to keep them?
Formatting

[ ] Ran cargo fmt
[ ] Ran cargo check
[ ] Ran cargo build

Github Issue
N/A
Author
Signed-off-by: Popescu Adrian<EMAIL_ADDRESS>

I just realised that it would be interesting to add also a label for modifying the workflows to be automatically added by the labeler.
And regarding the priority levels, I think it might be an overkill for the moment and maybe it would be an idea to add it later when needed. But also waiting for Wanja's input here.


[Web] Container with decoration (color + boxshadow), only shadow will appear if color is white #FFFFFF

I filed an issue here too. https://github.com/dart-lang/dart-pad/issues/1669

As you can see in the image, the container's fill won't be rendered if there is a boxshadow.
Container(
  child: Container(
    width: 198,
    height: 105,
    decoration: BoxDecoration(
      color: Color(
        0xffffff,
      ),
      border: Border.all(
        width: 1,
      ),
      boxShadow: [
        BoxShadow(
          color: Color(
            0x3f000000,
          ),
          offset: Offset(
            0,
            4,
          ),
          blurRadius: 4,
        ),
      ],
    ),
  ),
  padding: EdgeInsets.only(
    left: 88,
    right: 89,
    top: 121,
    bottom: 122,
  ),
  decoration: BoxDecoration(
    color: Color(
      0xffffff,
    ),
  ),
);

But non-white fill shows.... (WIERD!!)
0xffffff -> 0xfffcfcfc
Container(
  width: 198,
  height: 105,
  decoration: BoxDecoration(
    color: Color(
      0xfffcfcfc,
    ),
    border: Border.all(
      width: 1,
    ),
    boxShadow: [
      BoxShadow(
        color: Color(
          0x3f000000,
        ),
        offset: Offset(
          0,
          4,
        ),
        blurRadius: 4,
      ),
    ],
  ),
);

Hi @softmarshmallow
Looks like your white hex code is incomplete, you want alpha value and RGB, it would BE 0xFFFFFFFF
From doc
In other words, if AA is the alpha value in hex, RR the red value in hex, GG the green value in hex, and BB the blue value in hex, a color can be expressed as const Color(0xAARRGGBB).

Try this code sample

code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      // theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: Container(
          child: Container(
            width: 198,
            height: 105,
            decoration: BoxDecoration(
              color: Color(
                0xFFFFFFFF,
              ),
              border: Border.all(
                width: 1,
              ),
              boxShadow: [
                BoxShadow(
                  color: Color(
                    0x3f000000,
                  ),
                  offset: Offset(
                    0,
                    4,
                  ),
                  blurRadius: 4,
                ),
              ],
            ),
          ),
          padding: EdgeInsets.only(
            left: 88,
            right: 89,
            top: 121,
            bottom: 122,
          ),
          decoration: BoxDecoration(
            color: Color(
              0xFFFFFFFF,
            ),
          ),
        ),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 1.24.0-8.0.pre.149, on Mac OS X 10.15.7 19H15
    darwin-x64, locale en-GB)
    • Flutter version 1.24.0-8.0.pre.149 at
      /Users/tahatesser/Code/flutter_master
    • Framework revision 8e7748e74c (5 hours ago), 2020-11-08 20:32:04 -0800
    • Engine revision 0f7cdca65f
    • Dart version 2.12.0 (build 2.12.0-27.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Volumes/SanDisk/Xcode-beta.app/Contents/Developer
    • Xcode 12.2, Build version 12B5044c
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.51.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (5 available)
    • Taha’s iPad (mobile)       • 00008020-000255113EE8402E            • ios
      • iOS 14.2
    • iPhone 12 Pro Max (mobile) • 0A159C14-BF48-4DD7-8D91-F45A387EE4B2 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-2 (simulator)
    • macOS (desktop)            • macos                                •
      darwin-x64     • Mac OS X 10.15.7 19H15 darwin-x64
    • Web Server (web)           • web-server                           •
      web-javascript • Flutter Tools
    • Chrome (web)               • chrome                               •
      web-javascript • Google Chrome 86.0.4240.183
    ! Error: Taha’s iPad is busy: Copying cache files from device. Xcode will
      continue when Taha’s iPad is finished. (code -10)

• No issues found!

Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Updated resources of README.md

Earlier the resources (2 links) provided were just making user/dev land to that website, and then user have to figure out from there like where is actual solution listed in whole website? I faced this same issue a few minutes ago, while going through this documentation. But now these minor changes in resources (Updation of 2 links) will point user/dev to the right page/resource that will solve their problem.

Manual rebuild succeeded.
/approve

Why these netlify checks failed? Do i need to do something? 😶

Currently, there is an issue with the Netlify CI tool.
I would suggest using the following command to trigger a Netlify rebuild, which has the advantage of not losing the lgtm label and reducing the duplication of code views:
git reset
git commit --amend --no-edit
git push --force-with-lease

@aj111anuj, my advice is to rebase against main - see https://lwkd.info/2023/20230606#developer-news
Not sure how to do a Git rebase? Check YouTube or other video sites to find a tutorial.

Added cmd for Windows user to run the website locally using Hugos. Earlier there only make serve cmd was specified which works only for Linux and MacOS as according to our discussion on Slack.

Slightly relevant to issue #42861

/hold
(It looks as if) you are using one branch to make multiple changes @aj11anuj
Please make a new branch, and pull request, for each change that you want to propose.

/hold
(It looks as if) you are using one branch to make multiple changes @aj11anuj Please make a new branch, and pull request, for each change that you want to propose.

Yes, offcourse
In this case, it was very minute change and both commits were intending to update readme.md. So, i thought there won't be much problem if i commit it in this PR. I know it's not a part of best practice while working with OSS projects, and i won't do this thing again.

Closing this PR, due to above suggestions and some messed commits from my side on this PR. I will make separate new PRs for it.


Is there any way to show hide fields ?

Thanks for developing this library . Could you please help me on below questions ?

How can I show hide fields based on some conditions ?
How can I set values based on API response ?

Thanks

Hi @dinesh-88 I guess you refer to the current version so I will answer based on that assumption.

You can do it through CSS by adding a class using customClass or customStyles properties when defining the field like this:

setup() {
  const isFieldVisible = ref(true);

  const form = computed( ()= >{
    id: 'test-form',
    fields: {
        name: TextField({
              label: 'Username',
                   customClass: isFieldVisible.value ? 'show': 'hide'
              }),
    }
  })

  return {
    form
  }
}

Hi @dinesh-88 I guess you refer to the current version so I will answer based on that assumption.

You can do it through CSS by adding a class using customClass or customStyles properties when defining the field like this:

setup() {
  const isFieldVisible = ref(true);

  const form = computed( ()= >{
    id: 'test-form',
    fields: {
        name: TextField({
              label: 'Username',
                   customClass: isFieldVisible.value ? 'show': 'hide'
              }),
    }
  })

  return {
    form
  }
}

Hi @alvarosaburido
Thank for the reply. can you give me an example to set values  from API response ?
Thanks again

Hi @alvarosaburido
Thank for the reply. can you give me an example to set values  from API response ?
Thanks again

Hi sure, @dinesh-88, let's say you want to fill the options of a SelectField from and API call:
setup() {
  const isFieldVisible = ref(true);
  let consoleOptions = ref([]);

  const form = computed( ()= >{
    id: 'test-form',
    fields: {
        console: SelectField({
              label: 'Console (Async Options)',
              options: consoleOptions.value,'
        }),
    }
  })

  return {
    form
  }
}

Hi sure, @dinesh-88, let's say you want to fill the options of a SelectField from and API call:
setup() {
  const isFieldVisible = ref(true);
  let consoleOptions = ref([]);

  const form = computed( ()= >{
    id: 'test-form',
    fields: {
        console: SelectField({
              label: 'Console (Async Options)',
              options: consoleOptions.value,'
        }),
    }
  })

  return {
    form
  }
}

Thanks a lot

Thanks a lot


tf: noisy log

@stevenctl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
177b6b4bee77e27f1aa1cc75661b11cc8d4de21c
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


New grab animations

Related issues:
https://github.com/webaverse/app/issues/1981
https://github.com/webaverse/app/issues/1873
https://github.com/webaverse/app/issues/1825
In this PR we have new animations for item grab action.
Animations are:
grab forward
grab down
grab up
grab left
grab right
Also "group objects cannot be found when worn" is already solved by Avaer but we just need one simple null check and lantern/fairy can be picked up / droped without any problem.
Steps for testing:
Prepare scene with pickable objects at different heights.
Check object grab / pick up in directly in front of player, on players left side, on players right side.
Also place pickable object above players head, and on the floor.
Appropriate animation should be shown.
Plase take a look at video below for reference

https://user-images.githubusercontent.com/4487857/147165723-c9874aee-9904-4444-88c0-695ae258daf4.mp4

Issues:
1-The animation of grabing itself seems right but it seems to have some issues with direction of grab. (the direction in which hand moves to pick an object)
2-When avatar is facing opposite the object the direction of grab is totally opposite.
3-When tried to pick object diagonally same issue of direction persists
4-Trying to grab the item above or in any direction(below, left right), If the avatar is standing at bit distance, the hand doesn't seems to be going in the direction of the object.
https://user-images.githubusercontent.com/35926530/147277095-4f91888f-8856-4069-94c9-375934b4b851.mp4
https://user-images.githubusercontent.com/35926530/147277150-e7d5a661-d579-4473-bf2a-deb3bcab7c70.mp4

Yeah I tested this and I think the grab directions might not account for object rotation.

I have change the way how this works. If the player is not facing item, he will not get E button.
I hope this is what ok now. If not please let me know what should I change.
https://user-images.githubusercontent.com/4487857/147289027-88c1296a-e0c0-4077-93ae-a45d029a1ecb.mp4

Tried it and it works fine; it certainly looks a lot better than master.
We can continue improvements there.


Add DESTDIR to Makefile

Added DESTDIR to Makefile, which is used for packaging (reference).

While at it, you could just also add $(bindir) and $(mandir). Instead of setting PREFIX to ${DESTDIR}/usr/local I think it would be better to set it to  ${DESTDIR}$(bindir) (same for the man pages) and let the user choose the complete path if needed.

But bindir and mandir would have to be set to some default value. Or am I overlooking something?

Yeah, sure. It just feels to me that only allowing to change the start of the path and forcing to use /usr/local as the end isn't too flexible. Either we stick to /usr/local or give more flexibility.

When I’ve encountered DESTDIR, it wasn’t used in PREFIX‐type variables. Rather, DESTDIR is prepended to all paths in the install target.
The link you posted agrees with this usage:
$(INSTALL_PROGRAM) foo $(DESTDIR)$(bindir)/foo
$(INSTALL_DATA) libfoo.a $(DESTDIR)$(libdir)/libfoo.a

In addition, your latest commit removes PREFIX entirely. This is definitely not what packagers expect. PREFIX is standard; BINPREFIX and MANPREFIX are not (I made those up). bindir and mandir are better than BINPREFIX and MANPREFIX because they’re more flexible.
Please modify as follows:

PREFIX defaults to /usr/local
bindir defaults to ${PREFIX}/bin
mandir defaults to ${PREFIX}/man
Prepend ${DESTDIR} to all destination paths in the install target

Sorry for causing trouble, never did something like this before ;-)
Is the Makefile now like it should be?

Looks good to me.

I've squashed your commits into this one: https://github.com/rednex/rgbds/commit/bfcef01211b5cd95031db3f03771314b244852b0


Feature/add prettier task

This PR contains a:

[ ] bugfix
[ ] new feature
[x] code refactor
[ ] test update
[ ] typo fix
[x] metadata update

Motivation / Use-Case
Add prettier's task.

Breaking Changes
no

Additional Info

@evilebottnawi Do you know why circle CI doesn't work?

Thanks for PR, and sorry for delay, I updated defaults, so prettier now in master


fix a couple of typos

Just checking if we need to tag a new release.

Just tag it.

Thanks. Merged.


Redemption rate set to 100% when funding target is set to infinite

Summary
When setting the funding target to infinite, the system is automatically setting the redemption rate to 100%. This is not the expected behavior and can cause confusion for users.
Steps to reproduce

Navigate to the funding target settings
Set the funding target to infinite
Observe that the redemption rate is automatically set to 100%

What is the expected correct behavior?
The redemption rate should not be affected by the funding target setting. It should remain as set by the user.
Discord Link
https://discord.com/channels/775859454780244028/866040669712678942/1057159899462783047

did this get done?


Limit rate of fire in space shooter?

 To encourage using smarter strategies, we can limit the rate of fire. For example:
	if input.isJustPressed(input.KEY_SPACE) {
		if delay > 300 {
			delay = 0

			sound.shoot.play()
			b := bulletPrefab
			b.t.p = th.Vf2{e.t.p.x + 1, e.t.p.y - bulletPrefab.r.h}

			bullets = append(bullets, b)
			b.t.p.x += 3
			bullets = append(bullets, b)
		}
	}

	delay += th.delta

I can implement this, although I think I should try making the space shooter more readable and small than fun to play and balanced.


HackTogether: fix the hover effect of the user button

Are you accessing the project from the GitHub Codespaces?

[ ] No, I am running the project on my local machine (I will fill in the OS section below)
[x] Yes, I am using GitHub Codespaces.

Note: The project is optimized to run on Codespaces. We welcome contributions to enhance it for cross-platform local development, but it's not something we will prioritize right now. Thank you!

Describe the bug
The hover effect of the user profile button on the top right corner doesn't look good
To Reproduce
Steps to reproduce the behavior:

Hover on the user profile button

Expected behavior
A full hover effect that covers the entire text and button
Screenshots

OS (please complete the following information):
OS: Windows
OS Version: 11
npm version: 9.8.1
Node.js version: 18.5.0
output of azd version: azd version 1.1.0 (commit ea9cb12575734ee6a5f99c4d415c1a51d6f32d3e)
Additional context
None

Hi @kelvink96 - there is a team already working on this one. @SammyBloom
Is there any other issue you'd want to pick up on?

@SammyBloom - Hi, any update on this issue?


Create Regression Testing Suite for Grant-ID Tool

Write out test cases for all functionality & have reviewed by Product & devs

spreadsheet needs to be reworked; all test cases for old search


Removed anonymousquery and change the test to fetch an anonymous dataset

Description
This PR is following the previous discussion regarding the  "Catanie refactor to remove the duplicate pages for anonymous users" on catanie. It removes the anonymousquery on the backend and change the 2 tests involving it to use fullquery.
NOTE: It is important to note that, if someone test this locally, you need catanie with the current PR to remove the anonymousquery, otherwise it won't be able to fetch datasets anonymously. This PR should also be accepted after the one for catanie.
Motivation
"anonymousquery" would not be used anymore and was then removed from the backend too
Changes:
Removed anonymousquery from common/models/dataset.js and common/models/dataset.json
Changed the test referring to anonymousquery from test/PublishedData.js
Tests included/Docs Updated?

[ ] Included for each change/fix?
[ ] Passing? (Merge will not be approved unless this is checked)
[ ] Docs updated?
[ ] New packages used/requires npm install?
[ ] Toggle added for new features?

I have also removed a function called searchExpression from dataset.js. This look like it was a copy from the searchExpression by the fullquery function in mongo-queryable.js but it was never updated unlike the one for fullquery.
If maybe @stephan271 could check that it was actually an older version of it it would be nice.

I have also removed a function called searchExpression from dataset.js. This look like it was a copy from the searchExpression by the fullquery function in mongo-queryable.js but it was never updated unlike the one for fullquery.
If maybe @stephan271 could check that it was actually an older version of it it would be nice.

Yes, this function is obsolete and was only kept for anonymousquery, which is obsolete now

I think in theory you are right, that this is a breaking change. However if none of the clients, in particular the GUI actually have ever used these endpoints (or at least not during the last months), then I would be pragmatic and handle this as a "normal" update.


FAQ: Add answers

In the FAQ, document/answer the question "Should I use one repository or separate repositories when backing up multiple clients/servers?". Provide some rationale and use case examples.

Just adding my thoughts here:
It seems obvious to me that a repository should be 1:1 for an individual/administrator/organization because password sharing is bad.
Obviously, if you're a sysadmin at a company and you've got a team of people, some level of password sharing will be needed.  In that case, you'd want to implement something like pass and gpg keys to keep the secret safe.
But it seems to me that the more systems you can back up on a single repository, the more efficient the backups become.  For example, if you have a desktop and a laptop, it makes sense, in my mind, to back them both up on one repository because you'll likely have a lot of duplication of files.  This will shrink the repository size significantly and speed up backups.
Another case would be, if you're the administrator of a bunch of computers that might not all be "yours" in the sense that you're the primary user.  For example, if you have a wife and two kids.    That makes 5 computers.  There would be less file duplication here than in the first case, you can still claw back some disk space by reducing the number of backups you need to keep.
Now for something different.  Let's say you're taking sql dumps of postgresql and backing those up for different environments at work?  Do you want to back up production data in the same repo as development data?  Do you want your development data separated out by the different products or versions?  You might consider splitting the data out for security purposes.  If a bad actor gets the password for one repository, they don't have access to everything.
This isn't complete, but it should be a good jumping off point for someone.  I may come back and finish this off later.

A repo can have multiple passwords (restic key add), so multiple admins can keep their passwords secret from one another. What they implicitly share, though, is the master key for the repo, since that cannot be revoked without re-encrypting everything.


Bundle server

This PR solves https://github.com/let-def/texpresso/issues/33.
All TeX files are now downloaded by a separate process, to which texpresso (the viewer) and tectonic runners connect.
The immediate benefit is fixing crashes with macOS. Longer term, it should allow to cleanup patches to tectonic, hopefully the protocol will be mergeable some day!

The corresponding tree https://github.com/let-def/tectonic/tree/bundle-server is cleaned up.
There is hope the changes can be upstreamed someday!


Compression service for Ambry.

The compression service applies configs to compress and decompress ByteBuf. It uses metrics to collect statistics and errors.

Codecov Report
Base: 73.01% // Head: 73.05% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (6551ff1) compared to base (a84c4af).
Patch coverage: 94.94% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2245      +/-   ##
============================================
+ Coverage     73.01%   73.05%   +0.04%
+ Complexity    10375    10334      -41
============================================
  Files           749      748       -1
  Lines         56895    56999     +104
  Branches       7001     7011      +10
============================================
+ Hits          41542    41643     +101
- Misses        13088    13095       +7
+ Partials       2265     2261       -4

Impacted Files
Coverage Δ

...va/com/github/ambry/router/CompressionService.java
93.87% <93.87%> (ø)

...va/com/github/ambry/router/CompressionMetrics.java
100.00% <100.00%> (ø)

...a/com/github/ambry/rest/ServerSecurityHandler.java
91.66% <0.00%> (-5.56%)
:arrow_down:

...c/main/java/com/github/ambry/rest/NettyClient.java
76.28% <0.00%> (-3.10%)
:arrow_down:

...java/com/github/ambry/store/CompactionManager.java
90.90% <0.00%> (-2.28%)
:arrow_down:

.../com/github/ambry/cloud/CloudStorageCompactor.java
73.03% <0.00%> (-2.25%)
:arrow_down:

...va/com/github/ambry/replication/ReplicaThread.java
83.10% <0.00%> (-1.15%)
:arrow_down:

...m/github/ambry/replication/ReplicationMetrics.java
91.71% <0.00%> (-1.02%)
:arrow_down:

...a/com/github/ambry/clustermap/ClusterMapUtils.java
91.78% <0.00%> (-0.46%)
:arrow_down:

...ava/com/github/ambry/store/BlobStoreCompactor.java
85.14% <0.00%> (-0.36%)
:arrow_down:

... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


0.8.8 prerelease 5 crashes on iOS 5

Hello, I tested 0.8.8 prerelease 4 on my iOS 5.1.1 iPhone 4 and it just instantly crashes on startup.
0.8.8 prerelease 2 seems to launch correctly though. Even still when entering token it says "connecting" and then will crash right after.
Do you know what could cause this?
EDIT: Still persists with prerelease 5

would it be possible to send a crash log?

would it be possible to send a crash log?

Sure, where can I get it from?

should be in Settings>About>Diagnostics & Usage>Diagnostic & Usage Data

should be in Settings>About>Diagnostics & Usage>Diagnostic & Usage Data

`Incident Identifier: 979393E0-F422-4D40-9550-957FB6ED861A
CrashReporter Key:   e6cb5719301648345b088f96316ef91a117ac42c
Hardware Model:      iPhone3,1
Process:         Discord [340]
Path:            /var/mobile/Applications/B2FFA6ED-A4E2-41A5-848A-DACE158D4802/Discord.app/Discord
Identifier:      Discord
Version:         ??? (???)
Code Type:       ARM (Native)
Parent Process:  launchd [1]
Date/Time:       2023-11-04 10:56:10.251 -0500
OS Version:      iPhone OS 5.1.1 (9B208)
Report Version:  104
Exception Type:  EXC_CRASH (SIGKILL)
Exception Codes: 0x00000000, 0x00000000
Crashed Thread:  0
Thread 0 Crashed:
0   dyld                          	0x2feed286 0x2feec000 + 4742
1   dyld                          	0x2feed058 0x2feec000 + 4184
Thread 0 crashed with ARM Thread State:
r0: 0x000f0000    r1: 0x00000001      r2: 0x2feec3b0      r3: 0x2feebd40
r4: 0x2feebd14    r5: 0x2feebd40      r6: 0x000f001c      r7: 0x2feebcf0
r8: 0x2feec2fc    r9: 0x00000000     r10: 0xffffffff     r11: 0x00000000
ip: 0x2fef7d29    sp: 0x2feebcb4      lr: 0x2feed257      pc: 0x2feed286
cpsr: 0x60000030
Binary Images:
0x2feec000 - 0x2ff0dfff  dyld armv7  <77eddfd654df393ba9c95ff01715fd08> /usr/lib/dyld
`

that unfortunately doesn't tell me much
try copying the binary for the app out of its folder to an easier to access folder and try running it from Terminal and post what you get there

I noted a crashing issue on iOS 5.1.1 which I fixed but I haven't been able to reproduce this.

try prerelease 6

try prerelease 6

This fixed both the startup crash and the auth crash!! Thank you for helping me here!

The auth crash was actually related to a change with how iOS 6 handles dispatch queues (iOS 6 made them actual Objective C objects, which they weren't in iOS 5, which caused issues. I just had to change it from an NSMutableArray to a native C array for it to work)


Exception when validating 2nd level nested properties

How to reproduce
The following program compiled with VS 2017, .NET Core 1.1 and FluentValidation 7.6.104 reproduces my problem:
using System;
using FluentValidation;

namespace fluent_validation_test
{
    class Program
    {
        static void Main(string[] args)
        {
            var obj = new OutherDto { Inner = null };
            var errors = new OutherValidator().Validate(obj);
            foreach (var e in errors.Errors)
            {
                Console.WriteLine(e);
            }
        }
    }

    public class OutherValidator : AbstractValidator<OutherDto>
    {
        public OutherValidator()
        {
            CascadeMode = CascadeMode.StopOnFirstFailure;

            RuleFor(x => x.Inner)
                .NotNull();

            RuleFor(x => x.Inner.TestB)
                .NotNull();
        }
    }

    public class InnerDto
    {
        public bool? TestB { get; set; }
        public string TestS { get; set; }
    }

    public class OutherDto
    {
        public InnerDto Inner { get; set; }
    }
}

I get the following exception:
System.NullReferenceException
  HResult=0x80004003
  Message=Object reference not set to an instance of an object.
  Source=FluentValidation
  StackTrace:
   at FluentValidation.Internal.Extensions.<>c__DisplayClass9_0`2.<CoerceToNonGeneric>b__0(Object x) in C:\Projects\fluentvalidation\src\FluentValidation\Internal\Extensions.cs:line 154
   at FluentValidation.Validators.PropertyValidatorContext.<>c__DisplayClass24_0.<.ctor>b__0() in C:\Projects\fluentvalidation\src\FluentValidation\Validators\PropertyValidatorContext.cs:line 53
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.LazyInitValue()
   at FluentValidation.Validators.NotNullValidator.IsValid(PropertyValidatorContext context) in C:\Projects\fluentvalidation\src\FluentValidation\Validators\NotNullValidator.cs:line 30
   at FluentValidation.Validators.PropertyValidator.Validate(PropertyValidatorContext context) in C:\Projects\fluentvalidation\src\FluentValidation\Validators\PropertyValidator.cs:line 79
   at FluentValidation.Internal.PropertyRule.<Validate>d__64.MoveNext() in C:\Projects\fluentvalidation\src\FluentValidation\Internal\PropertyRule.cs:line 267
   at System.Linq.Enumerable.<SelectManyIterator>d__159`2.MoveNext()
   at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
   at FluentValidation.AbstractValidator`1.Validate(ValidationContext`1 context) in C:\Projects\fluentvalidation\src\FluentValidation\AbstractValidator.cs:line 128
   at fluent_validation_test.Program.Main(String[] args) in c:\users\mchwedczuk\tmp\fluent-validation-test\fluent-validation-test\Program.cs:line 11

Workaround
You must use DependentRules to wrap validation of inner properties.
RuleFor(x => x.Inner)
                .NotNull()
                .DependentRules(() =>
                {
                    RuleFor(x => x.Inner.TestB)
                        .NotNull();
                });

Other workaround is to create a separate validator for Inner class.
Expected behavior
This is not intuitive for me. I also cannot find relevant description in the documentation. Expected behavior IMHO would be to ignore all validation rules attached to property that has a null parent in its access chain.

Hi, thanks for the feeback. The usual way of handling this is with a When check: RuleFor(x  => x.Inner.TestB).NotNull().When(x => x.Inner != null)  (or a block When clause if you have multiple properties to check).

Expected behavior IMHO would be to ignore all validation rules attached to property that has a null parent in its access chain.

If you set a child validator with SetValidator (which is the recommended way of handling child properties) then this is actually what  happens. The child validator will be skipped if the propert is null. However if you want to validate the child properties in the root level then you have to be explicit about whether you want them to run or not.

Docs updated; https://fluentvalidation.net/start#complex-properties


Missing RuntimePlatform enum value for Nintendo Switch

Hello. The RuntimePlatform enum needs to gain the following entry:
NintendoSwitch = 38
(and I need to be less sleepy and actually send a pull request, but I'll probably forget)

That's a build target enum -- build target and runtime platform are two different enum spaces. It's very likely that some existing usages of the RuntimePlatform actually want the BuildTarget instead.


[bazel] Rename cw310_params to fpga_cw_params

This PR renames cw310_params to fpga_cw_params in preparation for better CW340 support.
fpga_cw_params was chosen because we're going to be using all ChipWhisperer FPGA boards roughly the same and therefore they will share the same parameters. I'm unsure whether we will ever have other kinds of FPGA which may require other kinds of parameters which is why I've included the _cw suffix.
This change will allow us to add CW340 execution environments to tests without duplicating their cw310_parameters to cw340_parameters.
This PR has a risk of causing merge skews. If approved, we should also aim to merge its backport to earlgrey_es_sival at the same time to prevent backports failing.

For cases where the CW340 and CW310 are different (e.g. substantially worse SPI signal quality for the former vs. the latter, limiting I/O speeds*), is the thinking that we would split their configs off into different named parameters for opentitan_test() targets on a case-by-case basis?
Is the thinking that most tests are driven similarly in opentitanlib, so it's better to default to the same config vs. requiring every target to individually handle the two boards?
*This probably would be handled in opentitanlib config files anyway, but pretend I thought of something that might change the params ;)


WIP DataArray.plot() can now plot errorbars with kwargs xerr, yerr

[x] Tests added (for all bug fixes or enhancements)
[x] Tests passed (for all non-documentation changes)
[x] Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

Added support for errorbar plotting. This works by providing the kwargs xerr and/or yerr to plot() or plot.line(). It will only work for 1D data.
Errorbars for plots that usehue argument require that we loop and plot each line individually. I'm happy to add this is you think it's a good idea.
Example from docs:
air.isel(time=10, lon=10).plot.line(y='lat', xerr=3, yerr=1.5, ecolor='r')

Very cool!

Errorbars for plots that usehue argument require that we loop and plot each line individually. I'm happy to add this is you think it's a good idea.

I'm pretty sure that under the covers matplotlib uses a loop when plt.plot results in multiple lines. So this seems pretty reasonable to me.

Hi there. I have read this thread with a great interest as I was wondering whether it was possible to plot data from a Dataset with errorbars. Yet it seems that the changes discussed here were not merged in the end. At least I can't find the corresponding piece of code in the latest version of xarray/plot/plot.py.
What is the current status of this feature?

This never went in because I never finished it :)
One bit of weirdness is that the return types are different for plt.plot and plt.errorbar so the return type for xarray.plot will change when xerr or yerr is specified. I don't know if we should care too much.
Feel free to take over

I will have a look at it, starting with your initial commit. Regarding the change of return type, I won't be able to judge whether this can cause trouble or not.


[TR3FIR-141] Update embassy to latest

There are 3 merges here which likely don't need to be fully reviewed:

Merge of main into this branch (at the time, it was named pull_upstream2). This is just upstream commits, but I do resolve some conflicts. The conflict resolution bears review.
Merge of token-main into this branch. This is commits from Taylor's PR which have already been reviewed.
Another merge of main into this branch. This is also just upstream commits.

There are also 3 commits which are normal commits.
Everything that should be reviewed is tagged with TR3FIR-141. Everything else is just nonconflicting merges, etc.
This also implements the new versioning scheme.

I'm not merging this yet because it's not being built. I've asked @DavidZemon to have a look, since he's the CI guy.

I'm not merging this yet because it's not being built. I've asked @DavidZemon to have a look, since he's the CI guy.

David says it's only building token-main, not all feature branches.
I'm fine with this.


Swap to Rx3 specific module requires when available

Instead of Rx pull in the specific Rx operators we're using.

no longer a falcor issue since Rx is no longer a dependency.