action.NewList does not implement AllNamespaces properly.

I'm using helm as a go library where I'm trying to get all deployments across all namespaces.
listClient := action.NewList(x.ActionConfig)
listClient.AllNamespaces = true
listClient.All = true
releases, _ := listClient.Run()

The above case returns only deployments that are in the namespace of the first initial ActionConfiguration.
I looked at the helm CLI tool to understand the implementation and found the following:
https://github.com/helm/helm/blob/538f6aecca19f0a4288168661cdde8f9a2e76f08/cmd/helm/list.go#L61-L62
https://github.com/helm/helm/blob/538f6aecca19f0a4288168661cdde8f9a2e76f08/cmd/helm/list.go#L72-L74
The empty "" above overrides for instance "default" namespace.
If I understand it correctly, it's mutating the configuration in order to be able to get the deployments in all the namespaces. I might be wrong here but I assume that an action should be responsible for something like AllNamespaces just like it does with Limit? Am I wrong if I think AllNamespaces should be fulfilled by action.NewList.Run rather than List Command?
Also, the test around AllNamespaces have release cases all with the same namespace.
https://github.com/helm/helm/blob/a499b4b179307c267bdf3ec49b880e3dbd2a5591/pkg/action/list_test.go#L79-L82
https://github.com/helm/helm/blob/a499b4b179307c267bdf3ec49b880e3dbd2a5591/pkg/action/list_test.go#L263-L276

Thanks for the report. I think you're right. The implementation for AllNamespaces is in the cmd implementation. There doesn't appear to be any reference to AllNamespaces in the List implementation (pkg/action/list.go).
A PR to fix this would be welcome I think.

I have raised an MR for this please review. Also I would like suggestions on the unit tests.

@VaibhavSharma-47 I added comments to the PR. I think we could reach a pretty good solution with the added comments.

@VaibhavSharma-47 Thanks for the changes.
@joejulian @gjenkins8 this is starting to shape up and I'm happy with it.
There's a caveat that running list actions twice and where AllNamespaces goes from True to False will effectively still be AllNamespaces=True. Perhaps the approver can consider what to do with that point and if it's worth solving.


initSdk undefined/can't link

Hi,
I've successfully installed AppsFlyer pod and npm package, but I keep getting this when running react-native link:
rnpm-install ERR! It seems something went wrong while linking. Error: Expected "{" but "/" found.
For now, without linking, I'm unable to initialize the sdk. First, I get this:

And then, if I try to track any event, this:

Is there any step missing in the readme? How should I proceed?

please provide more details, versions, what did you run? Try to  clone the repo and run react-native link under demo/ project

Running into the same issue:

yarn add react-native-appsflyer
Add the appsFlyerFramework to podfile
pod install
rebuild

Using AppsFlyerFramework (4.5.12)
React native 0.37.0
xCode  8.1

I'm also running the same problem.
We've followed the instructions to integrate de module as marked in the guide.
The problem occurs while initializing the sdk:

While debbugin the index.js of the module the 'eventsMap' has not been initialized
Our project specifications

Appsflyer: 4.5.12
React-native: 0.33.0
xCode: 8.1

hi, can anyone to clone this repo and run demo project?  just run from root npm run preparedemo. I have react-native 0.36.1 and cannot reproduce, continue to dig

@iuraya I succeeded to reporduce it on demo, we work on it, thanks

Hi @af-fess, with the additional step, it appears other error:

and about the demo, into package.json, it appears the next row:
"react-native-appsflyer": "file:///Users/maxim/Appsflyer/projects/react-native-appsflyer"
As you can see,  the path is your private path(is a different context).
Thanks!

@jpradamartin hey, about demo - its ok, when you run npm run preparedemo it installes plugin from your cloned repo.  About error you mentioned above: how did you implement initSdk method? please post the code snippets. Looks like you didn't implement error callback. please see demo -> index.ios.js. You also can open issue/request to set error callback as optional. Thanks

added step to README


Release 2.31.1

[x] Start a new release branch:

$ git flow release start X.Y.Z

[x] Rotate CHANGELOG.md (following Keep a Changelog principles)
[x] Ensure outstanding changes are committed:

$ git status # Is the git staging area clean?
$ git add CHANGELOG.md
$ git commit -m "X.Y.Z"

[x] Publish the release branch:

$ git flow release publish X.Y.Z

[x] Test the release branch on staging
[x] Start a new release pipeline job with the SHA (see command below) of release/X.Y.Z that was tested on staging

$ git rev-parse --short HEAD

[x] Run migrations, if applicable (see the showmigrations release pipeline stage):

$ ./scripts/manage ecsmanage -e production migrate

[x] Finish and publish the release branch:

When prompted, keep default commit messages
Use X.Y.Z as the tag message

$ git flow release finish -p X.Y.Z

Thank you for deploying this.


Allow renditions to be added to plannedcoverage objects

... and we would also need more technical characteristics to be added to renditions to handle everything needed by the DPP project (or a generic key/value pair property but I don't like that idea)

Now you have two things to be added to videocodec – video codec and Mpeg
https://tldp.org/REF/VLS-User-Guide/x116.html#:~:text=MPEG is a codec.,MPEG-4%2C ...&text=When you play an MPEG,for subtitles%2C and so on.
According to linked document, mpeg is both a codec and a container format. If I understand the example correct, it is actually a mpeg-4 codec
When I searched for XDCam I found a Sony camera…
Searched a bit more and found this:
https://creativecow.net/forums/thread/sony-mxf-or-xdcam-ex-whats-the-best-intermediate/
Where it says this:
Sony MXF (.mxf) and XDCAM EX (.mp4)
So, yes – I think you that information can be stored in the video codec
T
From: Brendan Quinn @.>
Date: Tuesday, 28 November 2023 at 10:50
To: iptc/newsinjson @.>
Cc: Subscribed @.***>
Subject: Re: [iptc/newsinjson] Allow renditions to be added to plannedcoverage objects (Issue #159)
Technical characteristics that we need to add to support the examples in @amitesharqivahttps://github.com/amitesharqiva 's doc:
Attribute
Example
Found in examples from
Suggested NewsML-G2 equivalent
Audio Channels
4
Arqiva, CNN
audiochannels (attribute in newsContentCharacteristics)
Channel frequency
11.501,500 V
Arqiva
Doesn't exist in NewsML-G2
Audio frequency
48000
CNN
audiosamplerate (attribute in newsContentCharacteristics)
Audio quantization
16
CNN
Doesn't exist in NewsML-G2
Format FPS
29.97
CNN
videoframerate (attribute in newsContentCharacteristics)
Mpeg
MPEG 4 420
Arqiva
I think this can go under video codec?
Bitrate
15 Mbps
Arqiva
videoavgbitrate (attribute in newsContentCharacteristics)
Aspect Ratio
16:9
Arqiva
videoaspectratio (attribute in newsContentCharacteristics)
Video format
1920 x 1080
Arqiva, CNN
height, width (attributes in newsContentCharacteristics)
Video codec
XDCAM @.*** MXF
Arqiva, CNN
videocodec (attribute in newsContentCharacteristics)
—
Reply to this email directly, view it on GitHubhttps://github.com/iptc/newsinjson/issues/159#issuecomment-1829459975, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACMVFNKRXLNPB5H2QJH5IQLYGWXSVAVCNFSM6AAAAAA7OBRM26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZGQ2TSOJXGU.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


reset button for "likes" on board

It would be nice, if you can reset your placed "likes" withour erasing the card, for example if you misclicked, or someone is explaining it in detail and you change your mind.
A button for resetting all likes would be enough.

added the button


dependencies pulled by project generated with<EMAIL_ADDRESS>fail yarn check

Bug Report or Feature Request (mark with an x)
- [x] bug report
- [ ] feature request

Versions.

@angular/cli: 1.0.2
node: 6.10.2
os: darwin x64
@angular/common: 4.1.1
@angular/compiler: 4.1.1
@angular/core: 4.1.1
@angular/forms: 4.1.1
@angular/http: 4.1.1
@angular/platform-browser: 4.1.1
@angular/platform-browser-dynamic: 4.1.1
@angular/router: 4.1.1
@angular/cli: 1.0.2
@angular/compiler-cli: 4.1.1
Repro steps.

install @angular/cli 1.0.2
configure angular cli to install packages with yarn
run "ng new FooBar"
cd FooBar
run "yarn check"
you'll see these errors:
========
yarn check v0.21.3
error "tmp" is wrong version: expected "0.0.28", got "0.0.31"
warning<EMAIL_ADDRESS>could be deduped from "0.6.34" to<EMAIL_ADDRESS>error "external-editor#tmp" not installed
error Found 2 errors.
info Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command.
=========

The log given by the failure.

the first error is because karma and @angular/cli pull different versions of "tmp"
haven't been able to track the second issue

Desired functionality.
"yarn check" should not fail on a newly generated project.
Mention any other details that might be useful.

I'm sorry, but this issue is not caused by Angular CLI. Please contact the author(s) of the yarn project or file an issue on their issue tracker.

well I would argue that Angular CLI  generates a project that ends up pulling inconsistent dependencies. to be precise, two direct dependencies declared by AngularCLI are pulling different versions of the same transitive dependency.
this is definitely not a problem with yarn, yarn correctly report the inconsistent dependencies issue, but it's probably temporary...


Reduce noise

Change Description

Remove debug log messages seen during replay and normal processing that only confuse

Has there been any thought put into actually having debug statements in the code and not turning on debug output in general, so that someone could start up a node with debug turned on to then get more info, rather then turning on everything and removing any extra info from the code?

That has somewhat been accomplished by having more than one logger -- for example the producer plugin logger and the net plugin logger. Anything other than the default logger is disabled by default.


ISS 304: added variable_is_null and define_variable_is_collected

I deviated slightly from the issue by creating variable_is_null instead of is_not_null to reduce confusing double negatives.
I renamed the Rule Type from Define-XML to Define Item Metadata Check to more closely parallel the Define Item Group Metadata Check. Currently, no rules existed with the Define-XML rule type.
Note that this has been tested for define 2.1, but not define 2.0. Test cases have been added and commented out for define 2.0. Refer to #390 to support define 2.0.
To test, run the test cases.
You can also create a rule using the source issue logic and a define.xml 2.1 file to test the full rule.

Approved assuming CI passes

Any ideas why it is failing? The tests run successfully locally (though slowly). Seems like a timeout. Should I just try rerunning the CI later?

Approved assuming CI passes

Any ideas why it is failing? The tests run successfully locally (though slowly). Seems like a timeout. Should I just try rerunning the CI later?

Seems to stall on this one: tests/unit/test_rule_tester/test_rule_tester.py, ran perfectly fine for me locally

I am seeing a significant slowdown on the test_extract_variable metadata tests on this branch as opposed to the main branch


Add ONNX to CI for other backends

Added ONNX CI for CPU, TORCH, METAL, LLVM, CLANG, GPU, CUDA
Moved most ops from onnx.py to onnx_ops.py
cleaned up onnx_ops.py a little to make it have that tinygrad swagger with the # ******* something *******

Still not entirely sure if there isn't any egregious hacks in here that might cause CI to fail for reasons related to hacks.
Will look it over a few more times before ready for review.

Do we want MODELTESTS too? 😎

Do we want MODELTESTS too? 😎

Looks like it slows CUDA down a lot, I'm fine with skipping there

I reverted the Shape op change in onnx_ops.py in #2085
tests expects int64 :((((

@geohotstan hehe I'm glad this caught the Shape issue :)


Change copy and add rotate methods

This PR is a follow-up to #269 - I did implement the suggestion from https://github.com/astropy/regions/pull/269#issuecomment-501575413 and put copy in the base class. I'm not sure if that's good - comments welcome!
This PR also adds PixCoord and pixel region rotate methods, as I mentioned in #265 .
I'll continue a bit and add copy and rotate for a few more regions here.
@astrofrog @keflavich @registerrier or anyone - please review.

Each region already defines a _repr_params attribute for the shape parameters.  With the exception of polygons, your _fields attribute simply adds center, meta, visual.  Can you simply use _repr_params and add [center, meta, visual] in the copy method?
Polygons would require a workaround, but I think the polygon API should be changed (but not in this release!) so that its "center" can be moved around by changing one parameter instead of all the vertices.  IIRC we discussed that at one time.

@larrybradley - Agreed that both _fields and _repr_params is bad. But I would prefer a tuple of fields, where for each field one says if it should be repr=True or repr=False as in https://docs.python.org/3/library/dataclasses.html . Not sure if we can achieve that for now.
Is it really useful to exclude center from _repr_params? Isn't this often the most important info about a region?
Another cosmetic change I'd suggest is to move these tuples to class-level, out of __init__. We don't need to access them from the class for now, but again I'd suggest to follow the design in https://docs.python.org/3/library/dataclasses.html a bit.

@larrybradley - I followed your suggestion in 19edcfc - for now we just have _repr_params as was already the case. I've written the copy in the base class so that it also works for polygons.

Polygons would require a workaround, but I think the polygon API should be changed (but not in this release!) so that its "center" can be moved around by changing one parameter instead of all the vertices. IIRC we discussed that at one time.

You proposed it in #57. It wasn't clear to me why it's useful. Is it a performance issue, to have an efficient "shift" of a polygon to a new position, in case there are many vertices and you don't want to make another array?
I'm not really opposed to add a center or position attribute for polygons, but given that it does add some extra complexity (and probably isn't available for sky polygons?) - there should be a clear motivation for it.

Added rotate for circle, ellipse, rectangle and polygon. Seems to work fine, based on the test added.
Ready for final review.

@cdeil I think the _repr_params didn't include the center property because it's assumed that most regions have a center, so the center was added once to _repr_params in the base class, i.e. _repr_params only included the parameters defining the shape, which differ from region to region.
I think it's a good idea to move the params tuple to the class level.  I'm not familiar with the @dataclass decorator, but the examples seem to all use type annotations, which I'm not a big fan of.

@cdeil For the polygon region, I'm thinking of the use case of aperture photometry.  In that case, one has an (x, y) position/centroid of a source on which they want to perform photometry within a particular aperture.  Therefore, it would be nice for polygon regions to have the same API as the other regions that use center, e.g.:
xypos = PixCoord(10, 20)
reg1 = CirclePixelRegion(xypos, radius=3)
reg2 = PolygonPixelRegion(xypos, vertices=vertices)
aperture_photometry(data, (reg1, reg2))

where the polygon vertices are defined relative to (0, 0).  In other words vertices defines the shape of the polygon and position defines its position.  That API mirrors all the other regions that separate the center parameter from the shape parameters, except we can't call it center for polygons because depending on how vertices are defined, it may not be the true center (although for aperture photometry it should be the true center).
xypos2 = PixCoord(30, 40)
 # no need to recompute polygon vertices for new position
reg3 = PolygonPixelRegion(xypos2, vertices=vertices)


Update README.md

Coverage remained the same at 96.737% when pulling 9b135638b3858dd7e8e33f31e4b3890af34ca169 on Catherine9898-patch-1 into 9bc1345903ee25f9ee68885b0eb6f67e33b5e570 on master.


Previous Business Day limited to only the last 7 days

I setup a (most likely improbable situation, but you never know ¯_(ツ)_/¯) scenario.
Today is the 10th, the 5th-9th are holidays, Monday is the only working day.
moment.updateLocale('us', {
   holidays: ['04-05-2019', '04-06-2019', '04-07-2019', '04-08-2019', '04-09-2019'],
   holidayFormat: 'MM-DD-YYYY',
   workingWeekdays: [1]
});

console.log(moment('04-10-2019', 'MM-DD-YYYY').prevBusinessDay().toString());
// "Thu Apr 04 2019 00:00:00 GMT-0500"

// expected:
// "Mon Apr 01 2019 00:00:00 GMT-0500"

jsbin: https://jsbin.com/vafaseriti/edit?js,console
Possible solution:
moment.updateLocale('us', {
   holidays: ['04-01-2019', '04-05-2019', '04-06-2019', '04-07-2019', '04-08-2019', '04-09-2019'],
   holidayFormat: 'MM-DD-YYYY',
   workingWeekdays: [1],
   prevBusinessDayLimit: 31,
});

moment.fn.prevBusinessDay = function () {
  var locale = this.localeData();

  var loop = 1;
  var defaultPrevBusinessDayLimit = 7;
  var limit = locale._prevBusinessDayLimit || defaultPrevBusinessDayLimit;
  while (loop < limit) {
    if (this.subtract(1, 'd').isBusinessDay()) {
      break;
    }
    loop++;
  }
  return this;
};

Open to PR's?

Thanks for reporting! Wow I've never seen this!
I'm trying to figure it out by looking at code that's untouched since the first commit b9b836a050905d38ae171e2839d6bfbaa9e3aeb6 and remember that I started contributing only some time ago.

I've created https://github.com/kalmecak/moment-business-days/pull/68 but I'm not sure of implications. Basically I've added a hard limit of 1 year (366 days, considering leap years too) to avoid infinite loops in the imaginary case where all days that are working days (say Mondays) are also holidays. Is this an acceptable compromise?

I've actually not read your suggested solution. Yes it could work with a parameter, in which case should have the same name for both nextBusinessDay and prevBusinessDay, something businessDayLimit, defaulting to either 7 or 31 or 366.

We do have a use case for this on a project I'm working on. Here's what I have so far: https://github.com/richarddavenport/moment-business-days

@mcdado I know that there is a WIP PR, but I went ahead and submitted my code changes for review. Let me know if you need any additional input/help. In #69 one of the tests are failing, but I believe it is due to my lack of understanding on how to reset the locale in mocha.

@richarddavenport That's good! I actually like your approach better!
To fix the test probably you need to reset this module's custom properties in the updateLocale call:
var resetLocale = function (done) {
  moment.updateLocale('us', {
    holidays: [],
    holidayFormat: '',
    workingWeekdays: [1,2,3,4,5],
  });
  done();
};```

@mcdado Does the version need to change for me to pull it in to my project?

I think until @kalmecak publishes a new version you can put kalmecak/moment-business-days in your package.json file: https://docs.npmjs.com/files/package.json#github-urls
This should pull in the latest version, but i don't know for sure.

Closed with #68.


Failed to install 'phonegap-plugin-push':undefined

Expected Behaviour
Plugin v1.0.9 install correctly.
Actual Behaviour
An error Failed to install 'phonegap-plugin-push':undefined is generated when trying to add or restore platform. The complete related error log:
Failed to install 'phonegap-plugin-push':undefined
Error: The CocoaPods repo has not been synced yet, this will take a long time (approximately 500MB as of Sept 2016). Please run `pod setup` first to sync the repo.

Reproduce Scenario (including but not limited to)
cordova prepare (when trying to restore from config.xml)
or simply cordova platform add ios
The same project install works as expected on another machine with the same env, but with OSX El Capitan instead of Sierra.
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Cordova Android: 6.0.0
Cordova iOS: 4.3.0
Cordova CLI version and cordova platform version
Cordova CLI: 6.4.0
CocoaPods: 1.1.1
OS: Sierra 10.12.1
Node: 6.9.1
NPM: 3.10.9
Plugin version
1.9.0
Logs with --verbose
Installing "phonegap-plugin-push" for ios
Running command: /Users/facilitylogbook/build-agent/_work/5/s/platforms/ios/cordova/version
Command finished with error code 0: /Users/facilitylogbook/build-agent/_work/5/s/platforms/ios/cordova/version
Finding scripts for "before_plugin_install" hook from plugin phonegap-plugin-push on ios platform only.
No scripts found for hook "before_plugin_install".
Install start for "phonegap-plugin-push" on ios.
Beginning processing of action stack for ios project...
Action stack processing complete.
Adding pods since the plugin contained <framework>(s) with type="podspec"
pods.json: The file at /Users/facilitylogbook/build-agent/_work/5/s/platforms/ios/pods.json does not exist.
Creating new pods.json in platforms/ios
Wrote to pods.json.
Podfile: The file at /Users/facilitylogbook/build-agent/_work/5/s/platforms/ios/Podfile does not exist.
Creating new Podfile in platforms/ios
Wrote to Podfile.
Set pods.json for `GoogleCloudMessaging`
Added pod line for `GoogleCloudMessaging`
Set pods.json for `GGLInstanceID`
Added pod line for `GGLInstanceID`
Wrote to pods.json.
Wrote to Podfile.
Running `pod install` (to install plugins)
Failed to install 'phonegap-plugin-push':undefined
Error: The CocoaPods repo has not been synced yet, this will take a long time (approximately 500MB as of Sept 2016). Please run `pod setup` first to sync the repo.

Do you have CocoaPods installed?
If you have it, do you have at least 1.0.0 version?
can you type on your terminal, pod repo update?

Yes it is installed.
I solved the issue, I had to run pod setup (which took quite a long time) before trying to add platform. Maybe this should be noted in the preqequisites, as installing cocoapods does not necessary trigger the pod setup command beforehand.

@sinedied  @jcesarmobile , can you please tell the solution to this. I am working on ionic project.
1)How to install cocoapods & is there anything we need to create podfile in project?
2)How much time it takes for pod setup?
Regards
Pallavi M N

To install CocoaPods read
https://guides.cocoapods.org/using/getting-started.html
You don't have to create a Podfile, cordova will do it and will add the Pods the plugin want to use.
About the time, I don't know exactly


Investigation: Is it possible to modify Workflow One's trigger to change the repo files?

For instance, imagine if the Workflow One trigger was changed to PR comment. When this runs in the context of a forked PR. Thanks to @itsalaidbacklife for asking the question.

Would the Workflow One trigger with the forked PR's updates? (on comment)
Would it trigger Workflow Two? (or would this only be using main's workflow settings)
If the workflows did run, would Workflow two run in the context of the repo and have access to the repo secrets?

I expect none of this will run since it would just be in the context of a PR, but want to proof it out just in case.

I asked copilot to get some initial answers prior to digging.

Would the Workflow One trigger with the forked PR's updates? (on comment)
Yes, if you change the trigger of Workflow One to issue_comment (which also includes PR comments), it would trigger when a comment is made on a PR. However, it would run in the context of the base repository, not the fork. This means it would not have access to the changes made in the forked PR unless the PR is merged.
Would it trigger Workflow Two? (or would this only be using main's workflow settings)
Yes, Workflow Two would be triggered because it's set to run on the completion of Workflow One. However, it would also run in the context of the base repository, not the fork.
If the workflows did run, would Workflow two run in the context of the repo and have access to the repo secrets?
Yes, Workflow Two would run in the context of the base repository and would have access to the repository's secrets. However, it's important to note that secrets are not passed to workflows that are triggered by a PR from a fork. This is a security measure to prevent secret leakage.
In summary, while you can trigger workflows from a PR comment, the workflows will run in the context of the base repository and won't have access to the changes in the forked PR until it's merged. Also, secrets won't be available to workflows triggered by a PR from a fork.

I posed this question to copilot to get an idea of what might happen:

Say for instance those two workflows were live in the main branch of my repo. If another user put up a PR with changes to the workflows with the following:

Changed Workflow One to trigger on pr comment
Changed Workflow Two to delete a file and commit it instead of bumping the version
What would happen in the PR? Which workflows would run and how would they function?

Copilot responded with the following:

If another user submits a PR with changes to the workflows, here's what would happen:
Workflow One is changed to trigger on PR comment: This workflow will trigger whenever a comment is made on a PR. However, it will use the version of the workflow that exists in the base branch (the branch the PR is targeting), not the version in the PR branch. This is because GitHub Actions uses the version of the workflow file in the base branch to run the workflow. So, if the base branch's version of Workflow One is set to trigger on PR close, it will not trigger on PR comment, even if the PR changes it to do so.
Workflow Two is changed to delete a file and commit it instead of bumping the version: This workflow will not run until the changes are merged into the base branch. This is because Workflow Two is triggered by the completion of Workflow One, and Workflow One will use the version in the base branch, not the PR branch. Once the changes are merged into the base branch, then Workflow Two will start deleting a file and committing it instead of bumping the version.
In summary, the workflows that run in response to a PR will use the versions of the workflows that exist in the base branch at the time the triggering event occurs. Changes to workflows in a PR will not take effect until the PR is merged.

As an aside, I also looked in to pull_request_target which we aren't using as a possible secondary solve. While it would also solve the version bump task, as it allows forked PRs to use the base repos workflows, it would allow forked PRs to make arbitrary changes and run it against the main repo where this would actually be a problem.
See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target.
That said, we are NOT using that event, so it shouldn't be an issue in that case. From the page:

Warning: For workflows that are triggered by the pull_request_target event, the GITHUB_TOKEN is granted read/write repository permission unless the permissions key is specified and the workflow can access secrets, even when it is triggered from a fork. Although the workflow runs in the context of the base of the pull request, you should make sure that you do not check out, build, or run untrusted code from the pull request with this event. Additionally, any caches share the same scope as the base branch. To help prevent cache poisoning, you should not save the cache if there is a possibility that the cache contents were altered. For more information, see "Keeping your GitHub Actions and workflows secure: Preventing pwn requests" on the GitHub Security Lab website.


[FEAT] - Improve documentation on consensus implementation

Internal/External
External
Describe the feature you'd like
I'm currently reading the report in the repository to understand Cardano consensus and how to implement it.
however, most of the report is in TODO state.
does anyone have any better resources to understand how consensus works?
Are there any people willing to provide practical examples of the consensus implementation?

Hi, thanks for the improvement request. The report will probably remain in that state and we will move the documentation gradually into markdown files. However, the report is probably the best source of information so far. We're in the process of updating our documentation site. In the meantime feel free to use the discussions section. Happy hacking!


⚠ Bofrost.at has degraded performance

In a33cbf1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1012 ms

Resolved: Bofrost.at performance has improved in 3917921.


Seed is dumped in trace

The seed shouldn't be added in clear text in traces, e.g.
https://github.com/Techworker/iota-php/blob/master/src/ClientApi/Actions/GetAddresses/Action.php#L201
Or this should be made configurable with a debug flag?

I think it's not necessary to dump the security serialization by default in trace.
Perhaps we can set the optional argument in the serialize method to determine the security will be dumped in trace. Consider the following code snippets:
public function serialize(bool isDumpedSecurity = false): array
{
    ...
}

Well it implements the SerializeInterface and this method does not define this parameter.

Ok. Is it possible to add the optional argument for the serialize method in SerializeInterface?

This would change all classes that implement the SerializeInterface (a lot!!), and not all really need the flag.
Btw., the line that is meant is this: https://github.com/iota-php/client/blob/master/src/ClientApi/Actions/GetAddresses/Action.php#L199
The Seed class has some mechanisms to never get dumped anywhere, because the seed should never NEVER EVER appear in any logs or anywhere else.
So in essence a better fix might be to overwrite the serialize() function from the Trytes class the Seed class extends from.
The whole serialization stuff is mostly for debugging purposes and its really helpful (see the kitchen sink which lets you try out each endpoint and client method via browser)

Ok, but we have to find another way to let the seed be configurable and it checks whether this should be dumped in trace.
My another approach is: Let the seed be removed in this serialize method and I think it's the proper way to do that because the seed is the credentials.

Yes, probably remove the serialization for the seed completely. More secure

@Techworker, I've created the related PR and this issue should  be fixed :smiley: .

Fixed with #55


How to do a git rebase master

Working on a branch, I wanted to update it with a recently-updated master branch.
I went ahead with the traditional git rebase master, but encountered the following issue:
Full details
julien-macbook:~/code/spine-generic/data-multi-subject $ git checkout jca/17-defacing
Switched to branch 'jca/17-defacing'
julien-macbook:~/code/spine-generic/data-multi-subject $ git rebase master
First, rewinding head to replay your work on top of it...
git-annex: git status will show sub-cmrra02/anat/sub-cmrra02_T2w.nii.gz to be modified, since content availability has changed and git-annex was unable to update the index. This is only a cosmetic problem affecting git status; git add, git commit, etc won't be affected. To fix the git status display, you can run: git update-index -q --refresh sub-cmrra02/anat/sub-cmrra02_T2w.nii.gz
git-annex: git status will show sub-cmrra04/anat/sub-cmrra04_T2w.nii.gz to be modified, since content availability has changed and git-annex was unable to update the index. This is only a cosmetic problem affecting git status; git add, git commit, etc won't be affected. To fix the git status display, you can run: git update-index -q --refresh sub-cmrra04/anat/sub-cmrra04_T2w.nii.gz
git-annex: git status will show sub-cmrra05/anat/sub-cmrra05_T2w.nii.gz to be modified, since content availability has changed and git-annex was unable to update the index. This is only a cosmetic problem affecting git status; git add, git commit, etc won't be affected. To fix the git status display, you can run: git update-index -q --refresh sub-cmrra05/anat/sub-cmrra05_T2w.nii.gz
git-annex: git status will show sub-oxfordFmrib07/anat/sub-oxfordFmrib07_T1w.nii.gz to be modified, since content availability has changed and git-annex was unable to update the index. This is only a cosmetic problem affecting git status; git add, git commit, etc won't be affected. To fix the git status display, you can run: git update-index -q --refresh sub-oxfordFmrib07/anat/sub-oxfordFmrib07_T1w.nii.gz
git-annex: git status will show sub-stanford06/anat/sub-stanford06_T1w.nii.gz to be modified, since content availability has changed and git-annex was unable to update the index. This is only a cosmetic problem affecting git status; git add, git commit, etc won't be affected. To fix the git status display, you can run: git update-index -q --refresh sub-stanford06/anat/sub-stanford06_T1w.nii.gz
Applying: Fixed defacing in a few subjects
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
error: Your local changes to the following files would be overwritten by merge:
	sub-cmrra02/anat/sub-cmrra02_T2w.nii.gz
	sub-cmrra04/anat/sub-cmrra04_T2w.nii.gz
	sub-cmrra05/anat/sub-cmrra05_T2w.nii.gz
	sub-oxfordFmrib07/anat/sub-oxfordFmrib07_T1w.nii.gz
	sub-stanford06/anat/sub-stanford06_T1w.nii.gz
Please commit your changes or stash them before you merge.
Aborting
error: Failed to merge in the changes.
Patch failed at 0001 Fixed defacing in a few subjects
hint: Use 'git am --show-current-patch' to see the failed patch

Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".

What's strange, is that the branch jca/17-defacing started of from master, the problematic files listed above where updated only in jca/17-defacing (not on master), so I am wondering why this conflict is showing up. Is this a singularity of git-annex?  @kousu @drulex any idea?

I tried the command indicated here, but it didn't help:

julien-macbook:~/code/spine-generic/data-multi-subject $ git checkout jca/17-defacing
Switched to branch 'jca/17-defacing'
julien-macbook:~/code/spine-generic/data-multi-subject $ gs
julien-macbook:~/code/spine-generic/data-multi-subject $ git status | sed -n 's/modified://p' | xargs git update-index -q --refresh
julien-macbook:~/code/spine-generic/data-multi-subject $ git rebase master
First, rewinding head to replay your work on top of it...
git-annex: git status will show sub-cmrra02/anat/sub-cmrra02_T2w.nii.gz to be modified, since content availability has changed and git-annex was unable to update the index. This is only a cosmetic problem affecting git status; git add, git commit, etc won't be affected. To fix the git status display, you can run: git update-index -q --refresh sub-cmrra02/anat/sub-cmrra02_T2w.nii.gz
git-annex: git status will show sub-cmrra04/anat/sub-cmrra04_T2w.nii.gz to be modified, since content availability has changed and git-annex was unable to update the index. This is only a cosmetic problem affecting git status; git add, git commit, etc won't be affected. To fix the git status display, you can run: git update-index -q --refresh sub-cmrra04/anat/sub-cmrra04_T2w.nii.gz
git-annex: git status will show sub-cmrra05/anat/sub-cmrra05_T2w.nii.gz to be modified, since content availability has changed and git-annex was unable to update the index. This is only a cosmetic problem affecting git status; git add, git commit, etc won't be affected. To fix the git status display, you can run: git update-index -q --refresh sub-cmrra05/anat/sub-cmrra05_T2w.nii.gz
git-annex: git status will show sub-oxfordFmrib07/anat/sub-oxfordFmrib07_T1w.nii.gz to be modified, since content availability has changed and git-annex was unable to update the index. This is only a cosmetic problem affecting git status; git add, git commit, etc won't be affected. To fix the git status display, you can run: git update-index -q --refresh sub-oxfordFmrib07/anat/sub-oxfordFmrib07_T1w.nii.gz
git-annex: git status will show sub-stanford06/anat/sub-stanford06_T1w.nii.gz to be modified, since content availability has changed and git-annex was unable to update the index. This is only a cosmetic problem affecting git status; git add, git commit, etc won't be affected. To fix the git status display, you can run: git update-index -q --refresh sub-stanford06/anat/sub-stanford06_T1w.nii.gz
Applying: Fixed defacing in a few subjects
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
error: Your local changes to the following files would be overwritten by merge:
	sub-cmrra02/anat/sub-cmrra02_T2w.nii.gz
	sub-cmrra04/anat/sub-cmrra04_T2w.nii.gz
	sub-cmrra05/anat/sub-cmrra05_T2w.nii.gz
	sub-oxfordFmrib07/anat/sub-oxfordFmrib07_T1w.nii.gz
	sub-stanford06/anat/sub-stanford06_T1w.nii.gz
Please commit your changes or stash them before you merge.
Aborting
error: Failed to merge in the changes.
Patch failed at 0001 Fixed defacing in a few subjects
hint: Use 'git am --show-current-patch' to see the failed patch

Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".

Since this was urgent, I went ahead and clicked on "rebase and merge" directly on github (without being able to rebase and wait for travis)

Even more problematic:

i renamed the local repos
did a fresh git clone, git annex init and git annex get, but ran into this:

[jcohen@gra-login3 data-multi-subject]$ git-annex get sub-cmrra02/anat/sub-cmrra02_T2w.nii.gz
get sub-cmrra02/anat/sub-cmrra02_T2w.nii.gz (not available)
  Try making some of these repositories available:
  	5cdba4fc-8d50-4e89-bb0c-a3a4f9449666 -- julien@julien-macbook.local:~/code/spine-generic/data-multi-subject

  (Note that these git remotes have annex-ignore set: origin)
failed
git-annex: get: 1 failed

does git-annex know i have another local copy somewhere??

does git-annex know i have another local copy somewhere??

Did you clone from your filesystem?
Unfortunately I don't have extensive experience with git-annex and documentation on using it with the PR model seems to be scarce. Also the fact that the status command can glitch isn't the most re-assuring thing..
Did you sync to S3 before making your PR/rebase?

Did you clone from your filesystem?

I'm not sure I understand the question, but I did exactly as instructed here

Did you sync to S3 before making your PR/rebase?

Hum, I don't think I did.

I tried the command indicated here, but it didn't help:

I'm 80% confident that this is entirely due to that "cosmetic" glitch that git-annex has. But I'm also only 80% confident in my workaround. Maybe git status was outputting those files as "added" instead of "modified", or reworded modified, or maybe it was outputting in french; there's a lot of ways my workaround could be buggy.
When it happens again paste the output of the plain git status.


CMake updated to use /Zc:inline and /Zc:lambda

The /Zc:inline switch enforces C++11 rules on inline visibility which reduces redundant comdats in each OBJ file (i.e. all the DirectXMath inline functions you didn't call in that translation unit). This switch is on by default with MSBuild, but is not on by default for command-line builds. This update adds this switch to CMake builds as well.
This reduces the size of the Release obj/lib files in half.
There's also a /Zc:lambda conformance switch for VS 2019 16.8 or later which I'm enabling for coverage.

Related updates for test suite: https://github.com/walbourn/directxtk12test/commit/0db17e0957d4c75824145992cb9af7c4c0ae908b https://github.com/walbourn/directxtk12test/commit/c00b0b7f45041302821018e03358634d1d8396cf


Adding a few more easy tests

Easy code coverage improvements

Current coverage is 19.166% (diff: 100%)

Merging #88 into master will increase coverage by 1.904%

@@             master        #88   diff @@
==========================================
  Files            18         18
  Lines           840        840
  Methods         115        115
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            145        161    +16
+ Misses          695        679    -16
  Partials          0          0

Powered by Codecov. Last update 91a750d...b928624


Written code for average of numbers by recursion in R language. #3511

📑 Description

🐞 Related Issue

Closes #

@srini696 Please add the issue id to this PR

I have added it now.
It is #3511 .


Rebar group visibility in drawing

I previously mentioned this, but I want to open a new issue now.
It would be much more practical if the "Reinforcement Properties" component returned the geometry as it appears in the drawing mode, rather then the full group as in model mode. When working in drawing mode, our focus is on analyzing what's visible on the screen.
To achieve this, we'd need to handle singlebar and groupbars differently. For groupbars, we should check the VisibilityTypes to calculate the relevant index and then use this index to retrieve the selected polygons. For case "customized", we're going to need further analysis -  see my custom C# component. My custom C# component currently works well for NormalGroup and TaperedGroup, but I'm still working on TaperedRidge and TaperedCurved, which aren't yet functioning as expected.

RebarInDrawing.zip

I see this tool can do what I expected, but I don't know the logic behind it - see the clip attached.
This tool works well for all types of rebar in Tekla such as  Single bar, Group bar, Rebar set, Mesh, and Strand with all rebar group types: Normal, Tapered, Tapered ridge, Tapered curved, Tapered N.
https://ney-my.sharepoint.com/:v:/g/personal/tvd_ney_partners2/EWKIhj8C825Mr8IwtpSfHKcBkmOTnu1L2xxACTVBPU1C3w?e=rrrFQj

Thank you for your time

Thanks a lot @olszewski-grzegorz,

Thanks a lot @olszewski-grzegorz , I will test and let you know if there are any problems
Happy New Year, best wishes for you and your family in 2025


nacos client connect server with 403

When the Nacos client connects, 403 is prompted that he does not have permission to start chasing the source code. In the constructor, there is no user name and password. The problem is that the property object has changed. Please see the code screenshot，the first few calls to properties carry the user name and password
my jar is nacos-client1.3.1jar code at ServerHttpAgent.class line216, error properties:

correct properties:

here is my config and env:
<!--nacos注册中心客户端,升级到最新-->
<dependency>
    <groupId>com.alibaba.cloud</groupId>
    <artifactId>spring-cloud-starter-alibaba-nacos-discovery</artifactId>
</dependency>
<dependency>
    <groupId>com.alibaba.cloud</groupId>
    <artifactId>spring-cloud-starter-alibaba-nacos-config</artifactId>
</dependency>

<spring-cloud.version>Hoxton.SR5</spring-cloud.version>
<spring-cloud-alibaba.version>2.2.1.RELEASE</spring-cloud-alibaba.version>
<spring-boot.version>2.3.1.RELEASE</spring-boot.version>

my local nacos server config: nacos.core.auth.enabled=true
bootstrap.yaml
spring:
nacos-host: <IP_ADDRESS>
nacos-port: 8848
application:
name: gateway
cloud:
nacos:
discovery:
server-addr: ${spring.nacos-host}:${spring.nacos-port}
username: nacos
password: nacos
config:
server-addr: ${spring.nacos-host}:${spring.nacos-port}
username: nacos
password: nacos
file-extension: yaml #nacos读取yaml和properties格式数据
when my project start up,i see config service init two times,the second time lost the properties,why?

my jar is nacos-client1.2.1.jar
when start up the project,config service right init,but after console print this:
. ____ _ __ _ _
/\ / ' __ _ () __ __ _ \ \ \
( ( )__ | '_ | '| | ' / ` | \ \ \
/ )| |)| | | | | || (| | ) ) ) )
' || .__|| ||| |_, | / / / /
=========||==============|/=////
:: Spring Boot :: (v2.3.1.RELEASE)
2020-07-15 16:34:36.417 INFO 11616 --- [ main] c.a.n.c.c.impl.LocalConfigInfoProcessor : LOCAL_SNAPSHOT_PATH:C:\Users\18040112\nacos\config
2020-07-15 16:34:36.459 INFO 11616 --- [ main] c.a.nacos.client.config.impl.Limiter : limitTime:5.0
2020-07-15 16:34:36.487 WARN 11616 --- [ main] c.a.c.n.c.NacosPropertySourceBuilder : Ignore the empty nacos configuration and get it based on dataId[gateway] & group[DEFAULT_GROUP]
2020-07-15 16:34:36.493 WARN 11616 --- [ main] c.a.c.n.c.NacosPropertySourceBuilder : Ignore the empty nacos configuration and get it based on dataId[gateway.yaml] & group[DEFAULT_GROUP]
2020-07-15 16:34:36.494 INFO 11616 --- [ main] b.c.PropertySourceBootstrapConfiguration : Located property source: [BootstrapPropertySource {name='bootstrapProperties-gateway.yaml,DEFAULT_GROUP'}, BootstrapPropertySource {name='bootstrapProperties-gateway,DEFAULT_GROUP'}]
2020-07-15 16:34:36.499 INFO 11616 --- [ main] com.mcy.gateway.GatewayApplication : No active profile set, falling back to default profiles: default
2020-07-15 16:34:37.458 INFO 11616 --- [ main] o.s.cloud.context.scope.GenericScope : BeanFactory id=0891a919-c6ca-3c29-81d1-c5327aa8b63c
2020-07-15 16:34:37.872 INFO 11616 --- [ main] trationDelegate$BeanPostProcessorChecker : Bean 'org.hibernate.validator.internal.constraintvalidators.bv.notempty.NotEmptyValidatorForCharSequence' of type [org.hibernate.validator.internal.constraintvalidators.bv.notempty.NotEmptyValidatorForCharSequence] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2020-07-15 16:34:37.877 INFO 11616 --- [ main] trationDelegate$BeanPostProcessorChecker : Bean 'org.hibernate.validator.internal.constraintvalidators.bv.NotNullValidator' of type [org.hibernate.validator.internal.constraintvalidators.bv.NotNullValidator] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2020-07-15 16:34:37.926 INFO 11616 --- [ main] trationDelegate$BeanPostProcessorChecker : Bean 'spring.cloud.sentinel-com.alibaba.cloud.sentinel.SentinelProperties' of type [com.alibaba.cloud.sentinel.SentinelProperties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
INFO: log output type is: file
INFO: log charset is: utf-8
INFO: log base dir is: C:\Users\18040112\logs\csp
INFO: log name use pid is: true
2020-07-15 16:34:38.102 INFO 11616 --- [ main] trationDelegate$BeanPostProcessorChecker : Bean 'com.alibaba.cloud.sentinel.custom.SentinelAutoConfiguration' of type [com.alibaba.cloud.sentinel.custom.SentinelAutoConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2020-07-15 16:34:38.108 INFO 11616 --- [ main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.cloud.client.loadbalancer.reactive.LoadBalancerBeanPostProcessorAutoConfiguration' of type [org.springframework.cloud.client.loadbalancer.reactive.LoadBalancerBeanPostProcessorAutoConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2020-07-15 16:34:38.110 INFO 11616 --- [ main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.cloud.client.loadbalancer.reactive.LoadBalancerBeanPostProcessorAutoConfiguration$ReactiveLoadBalancerConfig' of type [org.springframework.cloud.client.loadbalancer.reactive.LoadBalancerBeanPostProcessorAutoConfiguration$ReactiveLoadBalancerConfig] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2020-07-15 16:34:38.112 INFO 11616 --- [ main] trationDelegate$BeanPostProcessorChecker : Bean 'deferringLoadBalancerExchangeFilterFunction' of type [org.springframework.cloud.client.loadbalancer.reactive.DeferringLoadBalancerExchangeFilterFunction] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2020-07-15 16:34:38.413 WARN 11616 --- [ main] c.n.c.sources.URLConfigurationSource : No URLs will be polled as dynamic configuration sources.
2020-07-15 16:34:38.413 INFO 11616 --- [ main] c.n.c.sources.URLConfigurationSource : To enable URLs as dynamic configuration sources, define System property archaius.configurationSource.additionalUrls or make config.properties available on classpath.
2020-07-15 16:34:38.419 WARN 11616 --- [ main] c.n.c.sources.URLConfigurationSource : No URLs will be polled as dynamic configuration sources.
2020-07-15 16:34:38.419 INFO 11616 --- [ main] c.n.c.sources.URLConfigurationSource : To enable URLs as dynamic configuration sources, define System property archaius.configurationSource.additionalUrls or make config.properties available on classpath.
2020-07-15 16:34:39.447 INFO 11616 --- [ main] o.s.c.g.r.RouteDefinitionRouteLocator : Loaded RoutePredicateFactory [After]
2020-07-15 16:34:39.448 INFO 11616 --- [ main] o.s.c.g.r.RouteDefinitionRouteLocator : Loaded RoutePredicateFactory [Before]
2020-07-15 16:34:39.448 INFO 11616 --- [ main] o.s.c.g.r.RouteDefinitionRouteLocator : Loaded RoutePredicateFactory [Between]
2020-07-15 16:34:39.448 INFO 11616 --- [ main] o.s.c.g.r.RouteDefinitionRouteLocator : Loaded RoutePredicateFactory [Cookie]
2020-07-15 16:34:39.448 INFO 11616 --- [ main] o.s.c.g.r.RouteDefinitionRouteLocator : Loaded RoutePredicateFactory [Header]
2020-07-15 16:34:39.448 INFO 11616 --- [ main] o.s.c.g.r.RouteDefinitionRouteLocator : Loaded RoutePredicateFactory [Host]
2020-07-15 16:34:39.448 INFO 11616 --- [ main] o.s.c.g.r.RouteDefinitionRouteLocator : Loaded RoutePredicateFactory [Method]
2020-07-15 16:34:39.448 INFO 11616 --- [ main] o.s.c.g.r.RouteDefinitionRouteLocator : Loaded RoutePredicateFactory [Path]
2020-07-15 16:34:39.448 INFO 11616 --- [ main] o.s.c.g.r.RouteDefinitionRouteLocator : Loaded RoutePredicateFactory [Query]
2020-07-15 16:34:39.448 INFO 11616 --- [ main] o.s.c.g.r.RouteDefinitionRouteLocator : Loaded RoutePredicateFactory [ReadBodyPredicateFactory]
2020-07-15 16:34:39.448 INFO 11616 --- [ main] o.s.c.g.r.RouteDefinitionRouteLocator : Loaded RoutePredicateFactory [RemoteAddr]
2020-07-15 16:34:39.448 INFO 11616 --- [ main] o.s.c.g.r.RouteDefinitionRouteLocator : Loaded RoutePredicateFactory [Weight]
2020-07-15 16:34:39.448 INFO 11616 --- [ main] o.s.c.g.r.RouteDefinitionRouteLocator : Loaded RoutePredicateFactory [CloudFoundryRouteService]
2020-07-15 16:34:39.483 INFO 11616 --- [ main] c.a.c.s.g.s.SentinelSCGAutoConfiguration : [Sentinel SpringCloudGateway] using AnonymousBlockRequestHandler, responseStatus: 455, responseBody: forbid
2020-07-15 16:34:39.483 INFO 11616 --- [ main] c.a.c.s.g.s.SentinelSCGAutoConfiguration : [Sentinel SpringCloudGateway] register SentinelGatewayFilter with order: -2147483648
2020-07-15 16:34:39.661 INFO 11616 --- [ main] c.a.c.s.g.s.SentinelSCGAutoConfiguration : [Sentinel SpringCloudGateway] register SentinelGatewayBlockExceptionHandler
2020-07-15 16:34:39.706 INFO 11616 --- [ main] o.s.s.c.ThreadPoolTaskScheduler : Initializing ExecutorService 'Nacso-Watch-Task-Scheduler'
2020-07-15 16:35:03.832 INFO 11616 --- [ main] com.alibaba.nacos.client.naming : initializer namespace from System Property :null
2020-07-15 16:35:03.834 INFO 11616 --- [ main] com.alibaba.nacos.client.naming : initializer namespace from System Environment :null
2020-07-15 16:35:03.836 INFO 11616 --- [ main] com.alibaba.nacos.client.naming : initializer namespace from System Property :null
the nacos config service start to init agin, this time the properties has incorect values,means does not contain username and password,after that get config data with 403 error,please read me! ! ! !

Configuration items related to the Nacos-Config, please add in bootstrap.yaml.

bootstrap.properties
spring.cloud.nacos.server-addr=<IP_ADDRESS>:8848
spring.cloud.nacos.username=nacos
spring.cloud.nacos.password=nacos


Additional Turing Example: Faucet/CAPTCHA

Please see if we can generate better error messages when people don't solve the captcha correctly

Codecov Report

Merging #97 (52d06e5) into develop (272264a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #97   +/-   ##
========================================
  Coverage    47.46%   47.46%
========================================
  Files           97       97
  Lines         3849     3849
  Branches       755      755
========================================
  Hits          1827     1827
  Misses        2022     2022

Flag
Coverage Δ

boba-contracts
20.53% <ø> (ø)

contracts
78.48% <ø> (ø)

core-utils
86.77% <ø> (ø)

data-transport-layer
30.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d195d1e...52d06e5. Read the comment docs.

Added a better error message

ToDo:
so main things are (1) clarify that people need Rinkeby ETH in the first place otherwise they can't do anything (2) when user rejects transaction, show the rror message and stop the spinner, and (3) deal with the reject -transaction bug , and (4) intercept the error message from the smart contract and replace it with "CAPTCHA incorrect" in the front end

basically, if they reject the metamask transaction it generates an error because message is zero or something like that

I think it keeps waiting for the server resonse


A short description of the bug

Describe the bug
Hi, for superset ingestion we can have error when a dataset has a comma , in its name. In that case we have this error:
failed to write record with workunit urn:li:chart:(superset,***) with ('Unable to emit metadata to DataHub GMS: Invalid format for aspect: chart\n Cause: ERROR :: /inputs/0/string :: "Provided urn urn:li:dataset:(urn:li:dataPlatform:athena,athena.some_db.My,virtual,table,PROD)" is invalid: Failed to convert urn to entity key: urns parts and key fields do not have same length for urn:li:dataset:(urn:li:dataPlatform:athena,athena,athena.some_db.My,virtual,table,PROD)\n', {'exceptionClass': 'com.linkedin.restli.server.RestLiServiceException', 'message': 'Invalid format for aspect: chart\n Cause: ERROR :: /inputs/0/string :: "Provided urn urn:li:dataset:(urn:li:dataPlatform:athena,athena,athena.some_db.My,virtual,table,PROD)" is invalid: Failed to convert urn to entity key: urns parts and key fields do not have same length for urn:li:dataset:(urn:li:dataPlatform:athena,athena,athena.some_db.My,virtual,table,PROD)\n', 'status': 400, 'id': 'urn:li:chart:(superset,11399)'}) and info {'exceptionClass': 'com.linkedin.restli.server.RestLiServiceException', 'message': 'Invalid format for aspect: chart\n Cause: ERROR :: /inputs/0/string :: "Provided urn urn:li:dataset:(urn:li:dataPlatform:athena,athena,athena.some_db.My,virtual,table,PROD)" is invalid: Failed to convert urn to entity key: urns parts and key fields do not have same length for urn:li:dataset:(urn:li:dataPlatform:athena,athena,athena.some_db.My,virtual,table,PROD)\n', 'status': 400, 'id': 'urn:li:chart:(superset,***)'}

To Reproduce
Steps to reproduce the behavior:

Go to Superset
Create a virtual table with a comma in its name
Run a superset ingestion

Expected behavior
We should not have an error, at least a warning or a workaround.

I am planning to open a PR about that with the following behavior:

Log a warning if a comma is in a table name here
Add a new input parameter like reserved_character_replacement so we can automatically replace , with a replacement characters


How to add the output of two previous layers?

Hi.
If I have a net like this:

How to add the output of fc1 and fc2 to get fc layers with add_prev or add_prev2?
Thanks.

I don't know what to tell you.  add_prev literally does that.  But you already know about add_prev apparently.  Use add_prev?  I don't know what else to say.

Thanks.
I wrote the net like this:
using TAG1 = fc<128,                        con<64,5,5,1,1,                        input<matrix<rgb_pixel>>>>;
using TAG2 = fc<16,                       con<16,3,3,1,1,                       input<matrix<rgb_pixel>>>>;
using add1 = add_prev<TAG2, TAG1>;
using net_type = loss_multiclass_log<fc<58, add1>>;
But is wrong. I don't konw how to use add_prev?

The second introductory example shows how to use add_prev.

Thanks a lot.


Bug: Images defined using link definitions are not loaded

The following works as expected:
![Selected nothing](./ffmpeg-crop-helper-0.0.1-empty.png)

This does not:
![Selected nothing][demo-selected-nothing]

[demo-selected-nothing]: ./ffmpeg-crop-helper-0.0.1-empty.png

Why do I think this is a bug?
The image is not loaded.
I expect the second variation to work as well since it is valid Markdown.

Also, images linked to using <img src="./whatever.jpg"> won't be loaded.
I know the docs specifically mention the markdown syntax, but why not support HTML tags as well?

I do not plan to support html images, images with link definitions will be fixed

fixed in<EMAIL_ADDRESS>


Running a Beaker Executor job leaves loads of uncommitted datasets in the workspace

🐛 Describe the bug
Run the catwalk training job specified here: https://github.com/allenai/catwalk/commit/5ba019204b0ff36c1c4da7feab4515342e9d9ad2
Command line is tango --settings experiments/train_all_the_things/tango.yml run experiments/train_all_the_things/train_all_the_things.jsonnet.
It will run for quite a while. Two jobs will usually fail. I don't know why it's always two.

When the run is complete, it tells you that two jobs failed, but you have no way of finding the logs for the failed jobs. (#387)
When you run it again, it finds all the succeeded jobs, as it should. The failed ones will start up again, but hang indefinitely somewhere in the Beaker workspace.
When you check your workspace, you will see hundreds of uncommitted datasets. Many of these contain actual, successful results. But two of them are the cause for the hang. It's impossible to know which ones to delete so I can finish my run. You can see many of these uncommitted datasets in the ai2/task-complexity workspace.

The actual problem here is the undiagnosable failure of the original jobs, and then the undiagnosable hang (which can be fixed if you remove the right uncommitted datasets). From a user perspective, having all those uncommitted datasets doesn't matter as such, but I suspect that it points to a deeper issue.
Versions
asd

I did another run like this. This time only one of them failed. The results table points me to this dataset: https://beaker.org/ds/01GC7PCX5M9B357GX6YJFY7C5R/details.
This is clearly incomplete. Its presence will prevent a re-run from succeeding. I know of no way to find the logs that would show me why it failed.

Ah! I can search experiments by name, which reveals this error message:
2022-09-05T21:18:13.535899802Z {"name": "root", "msg": "[step trained_model_arc_challenge_bert-base-uncased_2147483647] Uncaught exception", "args": {"py/tuple": []}, "levelname": "ERROR", "levelno": 40, "pathname": "/opt/conda/lib/python3.9/site-packages/tango/common/logging.py", "filename": "logging.py", "module": "logging", "exc_info": {"py/tuple": [{"py/type": "beaker.exceptions.BeakerError"}, {"py/reduce": [{"py/type": "beaker.exceptions.BeakerError"}, {"py/tuple": ["appendErr after appendLimiter.Wait (chunkSize=2316455): googleapi: Error 429: The rate of change requests to the object fileheap-public/uploads/400c75/01gc7r8yz8thyxx16sbej4xg28_$folder$ exceeds the rate limit.  We're writing stuff to beaker too quickly.

I will leave all this up like it is in case it helps with debugging.

I did another run like this. This time only one of them failed. The results table points me to this dataset: https://beaker.org/ds/01GC7PCX5M9B357GX6YJFY7C5R/details.
This is clearly incomplete. Its presence will prevent a re-run from succeeding. I know of no way to find the logs that would show me why it failed.

What happens here? Does it hang? Do you know where it hangs? I'm guessing the 429 error you discovered leaves this dataset in a bad state somehow.

The job finishes with (in this case) one failure and a few dependent steps not run. The problems with how this goes down are these:

It shouldn't have failed in the first place. The error was a beaker error that happened while writing the results, I think. Details in https://github.com/allenai/tango/issues/386#issuecomment-1237590083.
When it fails, it should give me an easy click to the logs that show the error. Instead get a click to the dataset, which is incomplete. I can only find the logs if I search for the step part of the dataset name in my list of experiments. That's not very discoverable.
When I re-run, it should not get stuck. Currently, the second run will get stuck when it's time to start the step. This might be the 429 error, so it might be already fixed.

Currently, the second run will get stuck when it's time to start the step.

What do you mean get stuck?


Phase 1, just get augur-ui and augur-node communicating

Use existing submit request and verify augur-ui is pulling data from augur-node. Best case scenario there are no code change needed. Hopefully easy win.

this is done


Additional Typescript Resolver development and mesh start: Cannot GET /

Describe the bug
I managed to migrate my Resolver(s) but when I build & start, I only get Cannot GET /[graphql] in the browser which opens.
To Reproduce
Steps to reproduce the behavior:

Add additional-resolvers.ts to one of the examples
Add if necessary: npm i -D @types/node ts-node and create tsconfig.json {  "compilerOptions": {    "types": ["node"]  }}
Run mesh build && mesh start

-> Browser opens with Error Cannot GET, there are never TypeScript errors in the logs

Expected behavior

mesh devseems fine anycase, does it ignore all TypeScript stuff?
mesh start should show the same playground
mesh dev as well as mesh build should print typescript issues in additional-resolvers.ts

Environment:

OS: MacOS but in VSCode DevContainer
@graphql-mesh/0.32.1: OpenAPI 0.18
NodeJS: 12.22

Additional context

I think documentation on how to migrate resolvers is missing as well. The only typescript example I found, odata-msgraph-programmatic-ts doesn't feature additional resolvers.
I needed to remove the file extension in the .meshrc.yml because that also adds an error (Imports should be without  .ts - that is not difficult to fix), but the generated file and my resolvers are clean of errors now and it still doesn't work, mesh start should also serve the playground after build like mesh dev right?

@ardatan can you please have a look at this? I would also like to know how you would usually debug this (on top of the typescript issues display in the console I am missing ;))

Could you share a CodeSandbox? It'd better for me to see your use-case :)

Could you share a CodeSandbox? It'd better for me to see your use-case :)

Yeah I thought that you might ask for that. I'll see that I do that but probably not today.
@ardatan can you please confirm my assumptions and answer my questions?

Yes sure.

the generated file and my resolvers are clean of errors now and it still doesn't work, mesh start should also serve the playground after build like mesh dev right?

mesh build takes all the dependencies including additional resolvers and puts it statically inside index.ts(ts-node is called during the build and ts-node is the module imports your additioanl resolvers file). That's why you had that issue I guess. But I didn't understand why it didn't work since you're already using ts-node at runtime.
In the meanwhile, I'll try to create an example with typed additional-resolvers file with an integration test :)

So as I started to create a copy example/openapi-javascript-wiki-ts, I first tried to reproduce it again just with javascript:
There you get the Cannot GET / https://codesandbox.io/s/holy-moon-smx7m the only change to the original:
    "start": "mesh build && mesh start",

So despite missing ts checking results in the console, this is not related and two separate issues:

still want to know how we continue to debug (with typechecking) in the future
build artifact doesn't serve the playground (or anything?)

@JustusNBB

Cannot GET /
mesh start is for production and playground is disabled by default in production.
Because playground is disabled in production mesh start;
Cannot GET / It will work a usual GraphQL API when you send HTTP requests with other GraphQL Clients. You can force it even in production mode in mesh config.

still want to know how we continue to debug (and develop with typechecking) in the future

We never have this type checking in mesh build. Because mesh build generates artifacts for you, it doesn't do bundling and stuff. It collects imports and puts it statically in the index file of artifacts. So if you have ts-node with type checking enabled, you should get type checking errors and stuff while ts-node imports ts files for NodeJS during mesh build.

Alright, thanks, so I can have a production playground with:
serve:
  port: 4000
  playground: true

I am still a bit confused about the typescript stuff, resolvers get types from ./mesh so that is now a recursive relationship?

you should get type checking errors and stuff while ts-node imports ts files for NodeJS during mesh build

yes this is what I want, but what have I been doing wrong?

Could you help to reproduce it here? Because I get TS errors here;
https://codesandbox.io/s/runtime-monad-wt7sw?file=/additional-resolvers.ts

Could you help to reproduce it here? Because I get TS errors here;
https://codesandbox.io/s/runtime-monad-wt7sw?file=/additional-resolvers.ts

Ahahaha that is working already far better from what I have been working with for now, did I miss a typescript fix in the latest releases?
But I can't get your sandbox ts errors fixed sorry, at least not inside the sandbox which hides the .mesh folder, this is how I made it apply the typings:
import { Resolvers } from "./.mesh";

interface ResolversModule {
  resolvers: Resolvers
}

const resolversModule: ResolversModule = {
  resolvers: {
  [...]
  }
}

export default resolversModule

Nvm I can: https://codesandbox.io/s/amazing-burnell-0bhlo?file=/.meshrc.yaml

@ardatan so what's your plan to resolve this recursive conundrum? Do you want more help to find a good TypeScript solution (and fix up the example)?

Found an issue with me misunderstanding the new resolver arguments (that also why I did not try typing them explicitly, and TypeScript Errors are shown as expected with the right dependencies installed and configured!
Outside of the sandbox I can't reproduce the recursion issue, maybe you are just patching too fast, the most recent versions seem to be more stable again :)
Thank you for the support!
I think another example using typescript and additional resolvers would be nice to have, but I have to do other stuff first (combine openapi-javascript + ms-graph-typescript?)


The square brackets' alignment made me itchy

Description of the problem or steps to reproduce
write the []
observe

Specifications
Version: 2.0.10
Commit hash: Unknown
Compiled on 2022-09-07T12:23:35Z
OS: Gentoo with Testing versions enabled
Terminal: xfce4-terminal 1.0.4

Smh, why didn't i think of that


Update vmware-remote-console to 10.0.2-7096020

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thanks for the PR!


WING Firmware v3.0 causes an error

Looks like Behringer changed something in the communication protocol with WING firmware 3.0, which supports the three new mixers they announced yesterday.
After loading FW 3.0, the yellow triangle appears in any button that calls on the WING module.  On the modules page, it shows an error "Cannot Get Status" (or something like that... sorry I had to leave and forgot to write the exact error down)
After downgrading to FW 2.1, the error went away.

It looks like this is similar to #22. I'm currently in the middle of re-writing the module to support Companion v3.0. Once I'm done with that, I'll start adding some of the new requested features and support for Wing FW3.0

It looks like this is similar to #22. I'm currently in the middle of re-writing the module to support Companion v3.0. Once I'm done with that, I'll start adding some of the new requested features and support for Wing FW3.0

Thank you.  Yeah, I had the yellow triangle warning in the "connections" tab in Companion since we bought the WiNG lsat February.  But never had the Yellow Triangle on any WING button itself until just today, after upgrading to FW 3.0.

FWIW, I re-installed FW3.0 and of course, the error triangle in all the WING buttons came back.  But I tested to see if the stuff actually worked.  Everything actually worked, including buttons updating with fader levels, fader commands, etc.   I still downgraded back to FW2.1 but thought I'd share a little testing with you.    Question, on your re-write do you plan on adding support for the WING-Live card?    Right now, I use generic OSC commands to control it but feedbacks or like position, etc would be nice.   Thanks for all you do on this module!

Yes I do! I currently do the exact same thing with our Live card!

Yes I do! I currently do the exact same thing with our Live card!

Hey, maybe in later FW, they've increased the subscription method to have more than one....

@andrewinalaska

can't seem to get companion to load edited modules from my dev path. I'm afraid I'm pretty wet behind the ears in this context.

You would first need to recode the module for the companion 3.0 api before it will run from the dev directory.

If I recall, I was working a change to fix how Fader Adjust works, so that it could work in dB instead of %-of-fader-travel... and a few other odds and ends. Anyway, if there's anything I can do to help as you dig into it, please let me know!

Fader 'set' works that way. Internally the console 'thinks' in percent and calculates dB on the fly. You would need to reverse the 'dB' to '%' calculation to send the proper value to the console.

It looks like this is similar to #22. I'm currently in the middle of re-writing the module to support Companion v3.0. Once I'm done with that, I'll start adding some of the new requested features and support for Wing FW3.0

Hi Elliot…..  Are you at the beta stage yet?  I’d love to try it out.  I


chore: use bootc icon for menu

What does this PR do?
Not sure how we missed following up, but support for customizing menu action icons was added to PD 1.8. This just sets it to our icon.
Screenshot / video of UI

What issues does this PR fix or reference?
Fixes #44.
How to test this PR?
Just go to images view and ensure the menu action has an icon.

Confirmed it works! LGTM 👍

:)

yes we listen to the requirements of 3rd party extensions :-)


chore(main): release 1.3.2

:robot: I have created a release beep boop
1.3.2 (2024-07-11)
Bug Fixes

capabilities: make capabilities optional (#217) (c269e71)

This PR was generated with Release Please. See documentation.

Summary by CodeRabbit

Bug Fixes

Resolved an issue with optional capabilities to improve stability.

Chores

Updated the version number to 1.3.2.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.83%. Comparing base (c269e71) to head (b7cd399).

Files
Patch %
Lines

midealocal/version.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   32.83%   32.83%
=======================================
  Files          80       80
  Lines        6981     6981
=======================================
  Hits         2292     2292
  Misses       4689     4689

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:robot: Created releases:

v1.3.2
:sunflower:


fsx scripting doesn't use the correct FSharp.Core in the editor

When I edit a .fsx with this code, it doesn't seem to bind to version of FSharp.Core having Result type and Option.defaultValue.
let ok =
    Ok 1
    |> Result.mapError (fun _ -> Unchecked.defaultof<string>)

let v = Some 1
let r = v |> Option.defaultValue 3

build settings:

fsi settings:

@smoothdeveloper Thank you for the report. It seems to have been fixes with some FCS/FSharp.Core update before.


Firmware v2.xx is not compatible with recent exA-Arcadia FW1.6.0

We notice that the v2.xx firmware is not compatible with recently shipped exA-Arcadia that runs with their FW1.6.0.
As v3 PCB works only with v2.xx firmware, I'm planning to release v1.4.8 that supports v3 PCB too as a workaround.
Also, I will work closely with them to support FW1.6.0 on v2.xx firmware too.

v1.4.8 is available now as a short-term workaround

2.16 fixed the issue


Remove Jitsi function 'kickFromVoice'

please remove kickFromVoice function from client,
see https://github.com/OpenSlides/openslides-icc-service/issues/34

Done in #752


Amino acids with alternate conformations

Amino acids with alternate conformations should have either:

only atoms in one conformation taken into account
use the average values among the conformations (use the occupancy number)

Fix: multiply each mass by corresponding occupancy


Slight inconsistency between callback and streams API

The callback API includes directories even with entryType unset, while the stream API does not.

Also, the callback API returns {directories: [], files: []}which is also not in line with the streams API.

So what change would actually fix your issue(s)?
I'm unclear on the action item here.
FWIW the result objects provided via streams or callback API should be as similar as possible or ideally have the same properties.

As a first step, I'd make the callback API emit only files with entryType undefined.
A second step would be to return just an array in the callback API instead of above object. That would be a semver major. (User can still discern files and folders through stat.isDirectory).

Or you go the other route and change the default for both streams and callback to 'all'. My use case definitly needs directories too.

I'm totally unclear how you get different types using streams vs. callbacks.
As you can see when using streams it just changes the callback to be push the same data into the stream it would have called back with.
Also this is the first time someone points this out. Could someone else please confirm this problem or could we add a test that fails due to these API differences?

Haven't read the whole source yet, but I think the difference is on the final allProcessed call. I assume this one is for streams:
https://github.com/thlorenz/readdirp/blob/82caf226eeafec8669c604f71e46e5e83c48cc86/readdirp.js#L194
And this one for callback (at least that's what I get):
https://github.com/thlorenz/readdirp/blob/82caf226eeafec8669c604f71e46e5e83c48cc86/readdirp.js#L278
readdirResult is the mentioned object with files and directories.

Maybe readdirResult was never meant to be exposed directly?

Simple test:
$ mkdir empty-dir && node -e "require('readdirp')({root: 'empty-dir'},console.log)"
null { directories: [], files: [] }

I have no idea what you expect to happen here. You are only giving the last callback and it correctly reports no error and no dirs or files inside empty-dir.
node -e "require('readdirp')({root: 'empty-dir'}).on('data', console.log)"

never fires because no dirs or files were found which is also correct.
Please write a test that fails demonstrating a bug and we can figure out how to fix it. At this point I'm not convinced there is a bug.

I don't interpret this thread as describing a bug, more like expressing an opinion about the current API design. I haven't looked closely enough to determine whether I agree with @silverwind's point, but either way I don't see what there is to be gained by making a breaking change at this point. Perhaps to appease the OCD segment of this module's user base.
As it is, readdirp does its job well, the behavior is deterministic, and it's unlikely any given project is going to use both the stream and callback apis together. Is there a practical reason for messing with it?

Let's see if this is clearer:

On the streams API, if I pass no options except root, I get data events with just file entries (no directories).

On the callback API, if I pass no optiones except root, I get both files and directories, sorted into arrays of the result object.

I'd have expected that the result collection of the callback API ist just an array, with no directories. It's really an minor issue, just something that surprised me.

Clear enough, thanks @silverwind. Empty array makes no sense in streams API since we only invoke the 'data' handler when we find an entry.
So not worth changing anything here. Please close if this is ok with you.
Thanks.

The streams API is fine. My propsal was to change the callback API to return a single array instead of this undocumented object format.
But whatever, I see you're not interested in changing any of the API :(

If the docs are unclear or inaccurate about the behavior we could make an update there. I'll take a look at it later.

Please do! the docs just state an 'collection of entries', which is pretty ambiguous.

Actually I still don't get it. We consistently return an object with files and directories.
If none were found both are empty arrays.
The same is true if we find files and/or directories i.e. in this test.
So what you are asking to just return an array would actually be inconsistent.
I'm therefore not sure what we could change in the docs.

I mean on the stream API, you get an single entry per data event. If you want to discern directories from files you have to call entry.stat.isDirectory(). On the callback API, I get these two sorted into arrays of their type.
Also, I did a quick test and it seems that the callback API actually ignores the entryType option completely, and will always return both directories and files.


Methods are not getting imported into VSCode

Hello Team,
We are trying to use the below extension. Upon successfully connecting to my developer workspace i am able to browse all the BO, BS etc. However i am not able to get any of the methods.
We tried both of the below given option after clicking on almost all BS , BO etc .

Yes
Only Methods Names
We cant see any methods getting imported. Kindly help.
Also we want to integrated this extension along with Co -pilot. Please suggest if both extension can work together to harness generative AI capabilities of co-pilot.

Attaching screenshot.

Hi,
Does the Siebel objects have any server scripts? Because the extension only shows them in that case, methods without servers scripts are not shown.
About co-pilot integration, we have neither tested nor used co-pilot, but you can give it a try.
Regards,
László


Return code or error ignores WarnErrorOptions

Description
Ignore WarnErrorOptions string in stdout from dbt-core, do not treat it as a failure
Related Issue(s)
Workaround for https://github.com/astronomer/astronomer-cosmos/issues/642
Breaking Change?

Checklist

[ ] I have made corresponding changes to the documentation (if required)
[x] I have added tests that prove my fix is effective or that my feature works

Awesome @tatiana thank you!

@adammarples  This was released in 1.2.5 🎉

https://pypi.org/project/astronomer-cosmos/1.2.5
https://github.com/astronomer/astronomer-cosmos/releases/tag/astronomer-cosmos-v1.2.5

@adammarples  This was released in 1.2.5 🎉

https://pypi.org/project/astronomer-cosmos/1.2.5
https://github.com/astronomer/astronomer-cosmos/releases/tag/astronomer-cosmos-v1.2.5


CSIP77 Improve wording

CSIP77 Type of locator fileSec/fileGrp/file/FLocat/@LOCTYPE description reads:

The locator type is always used with the value "URL" from the vocabulary in the attribute.

I propose changing it to:

Specifies the locator type used in the xlink:href attribute. For CSIP-compliant packages the value MUST be "URL".

The text has been extended with the xpath.


How to handle Emotion and Google Fonts inlined styles

Hey all,
I'm just integrating the middleware into my Next.js website and I'm running into a few issues. You can see the issues live here.
I am using Google Fonts and it seems like Google or Next.js does some inlining into a style tag, and those tags don't have a hash.
Here's how I include the Google Fonts:
  render() {
    const { Head, NextScript } = provideComponents(this.props)

    return (
      <Html>
        <Head>
          <link rel="preconnect" href="https://fonts.googleapis.com" />
          <link rel="preconnect" href="https://fonts.gstatic.com" crossOrigin="" />
          <link // eslint-disable-line @next/next/no-page-custom-font
            href="https://fonts.googleapis.com/css2?family=Open+Sans:wght@400;700;800&family=Playfair+Display:wght@500&display=swap"
            rel="stylesheet"
          />
        </Head>
        <body>
          <Main />
          <NextScript />
        </body>
      </Html>
    )
  }

The other problem is that I am using Mantine which leverages Emotion under the hood. It outputs an inline style tag at the top of my  that also doesn't seem to have a hash. I do have access to the nonce option of Emotion in my _app.ts but not sure if that's even helpful.
Anyone know if there there are any workarounds to these problems? Cheers!

Hi @alexturpin
that no style tag at all is covered is odd. Your 404 page (https://can-you-unlock-edbupijva-alexturpin.vercel.app/doesntexist) also has inline styles blocked (The default Next error component uses inline style attributes). This should work with a proper setup, see here: https://next-safe-middleware.vercel.app/doesntexist
Can you try this setup and see how it goes?
// pages/_document.js

import Document, {
	provideComponents,
} from '@next-safe/middleware/dist/document';
import { Html, Main } from 'next/document';
import React from 'react';

export default class MyDocument extends Document {
	static async getInitialProps(ctx: any) {
		return Document.getInitialProps(ctx);
	}

	render() {
		const { Head, NextScript } = provideComponents(this.props);
		return (
			<Html>
				<Head>
					<link
<EMAIL_ADDRESS>						rel="stylesheet"
					/>
				</Head>
				<body>
					<Main />
					<NextScript />
				</body>
			</Html>
		);
	}
}

// pages/_middleware.js
import type { Middleware } from '@next-safe/middleware';
import {
	chain,
	nextSafe,
	strictDynamic,
	strictInlineStyles,
} from '@next-safe/middleware';

const isDev = process.env.NODE_ENV === 'development';

export default chain(
	nextSafe({ isDev }),
	strictDynamic(),
	strictInlineStyles({
		extendStyleSrc: false,
	}),
)

I experimented a lot with what's possible to avoid style-src: 'unsafe-inline' in the CSP. I think I haven't put this in docs yet at all though, I intend do update it soon though, I will tackle #30 the next few weeks
I am currently working on some stuff for a version 0.7.0. I will set up Mantine in the e2e app, see how it goes and report problems/limitations I found back here.
I realized though that it might not always be possible to avoid style-src: 'unsafe-inline' and is dependent on how the CSS-in-JS framework works and if what your 3rd party libs do with inline styles (insert/change dynamically etc.)

@nibtime thanks for taking the time to reply! Here's a deployment with the additional strictInlineStyles config. Still doesn't appear to work: https://can-you-unlock-f1n8qxa6z-alexturpin.vercel.app/
Here's my full _document.tsx (Mantine also requires styles from getInitialProps)
import Document, { provideComponents } from "@next-safe/middleware/dist/document"
import { DocumentContext, Html, Main } from "next/document"
import { createStylesServer, ServerStyles } from "@mantine/next"

const stylesServer = createStylesServer()

export default class MyDocument extends Document {
  static async getInitialProps(ctx: DocumentContext) {
    // This needs to handle both @next-safe and Mantine
    const initialProps = await Document.getInitialProps(ctx)

    return {
      ...initialProps,
      styles: [
        initialProps.styles,
        <ServerStyles html={initialProps.html} server={stylesServer} key="styles" />,
      ],
    }
  }

  render() {
    const { Head, NextScript } = provideComponents(this.props)

    return (
      <Html>
        <Head>
          <link rel="preconnect" href="https://fonts.googleapis.com" />
          <link rel="preconnect" href="https://fonts.gstatic.com" crossOrigin="" />
          <link // eslint-disable-line @next/next/no-page-custom-font
            href="https://fonts.googleapis.com/css2?family=Open+Sans:wght@400;700;800&family=Playfair+Display:wght@500&display=swap"
            rel="stylesheet"
          />
        </Head>
        <body>
          <Main />
          <NextScript />
        </body>
      </Html>
    )
  }
}

And here's my _middleware.tsx:
import { nextSafe, chain, strictDynamic, strictInlineStyles } from "@next-safe/middleware"
import { isDev } from "~/config"

const devCSP = {
  "connect-src": ["'self'", "o1263600.ingest.sentry.io", "webpack://*"],
  "font-src": ["'self'", "fonts.gstatic.com"],
  "script-src": ["'self'", "'unsafe-eval'"],
  "style-src": ["'self'", "fonts.googleapis.com", "'unsafe-inline'"],
}

const prodCSP = {
  "connect-src": ["'self'", "o1263600.ingest.sentry.io"],
  "font-src": ["'self'", "fonts.gstatic.com"],
  "style-src": ["'self'", "fonts.googleapis.com"],
}

export default chain(
  nextSafe({
    isDev,
    contentSecurityPolicy: isDev ? devCSP : prodCSP,
    referrerPolicy: "strict-origin-when-cross-origin",
  }),
  strictDynamic(),
  strictInlineStyles({
    extendStyleSrc: false,
  })
)

Hi @alexturpin
I just released 0.7.0 to NPM and as your issues with Mantine/emotion intersected with, I chose it as a test scenario for the e2e app:
To make it work, it needed to extend the interface for the getInitialProps in _document, now called getCspInitialProps.
https://github.com/nibtime/next-safe-middleware#how-to-avoid-the-unsafe-inline-keyword-in-style-src-with-a-css-in-js-framework

@nibtime wow that's fantastic, great job on the new release(s). Great DX and love the Sentry reporting stuff. Sorry for the late feedback, I just got back on this project.
Unfortunately, I haven't been able to get it to work 100%. The CSP directives get set and I have no CSP errors, but oddly enough, on Vercel, whenever the page seems to get hydrated, all of the content gets removed from the DOM.
I'm still trying to figure out why, but I've narrowed it down to the strictDynamic() middleware. If I comment that out, it doesn't happen. It also doesn't happen in dev 🤔 Any idea what could cause this?
"next": "^12.2.2",
"@next-safe/middleware": "^0.8.0",

import { getCspInitialProps, provideComponents } from "@next-safe/middleware/dist/document"
import Document, { DocumentContext, Html, Main } from "next/document"

import { createStylesServer, ServerStyles } from "@mantine/next"

const stylesServer = createStylesServer()

export default class MyDocument extends Document {
  static async getInitialProps(ctx: DocumentContext) {
    // This needs to handle both @next-safe and Mantine
    const initialProps = await getCspInitialProps({
      ctx,
      trustifyStyles: true,
      hashRawCss: [
        (initialProps) => [
          stylesServer.extractCritical(initialProps.html).css,
          ...stylesServer.extractCriticalToChunks(initialProps.html).styles.map((s) => s.css),
        ],
      ],
    })

    // Required for Mantine CSS-in-JS SSR (Emotion) since we're also using @next-safe
    initialProps.styles = (
      <>
        {initialProps.styles}
        {/* Mantine CSS-in-JS SSR (Emotion) */}
        <ServerStyles html={initialProps.html} server={stylesServer} />
      </>
    )

    return initialProps
  }

  render() {
    const { Head, NextScript } = provideComponents(this.props)

    return (
      <Html>
        <Head />
        <body>
          <Main />
          <NextScript />
        </body>
      </Html>
    )
  }
}

Hi @alexturpin
I can see on your deployment that you are using an optional catch-all route for your landing page ([[...landingPage]]-d7ac30ad2f212bb9.js).
Is there a specific reason why you are doing that, instead of using pages/index.js for your landing page?
From my experience, Next.js treats the somewhat special, (e.g. with i18n routing), so I can imagine it has something to do with that.
Can you try it without the catch-all route and report back how that goes?

It does work on other pages so I think your instinct is correct.
I was using the catch all route because I need to generate the pages from CMS data and was just grabbing index the same way, but I can handle index as its own case. This does seem to work now 🎉
Thank you so much for your work on this library and the help getting this up and running!

Awesome! I thought this was very strange, as this lib only does server-side stuff and nothing past hydration.
The problem might be also related to this: https://github.com/vercel/next.js/issues/38267
This seems a 12.2 issue and shows up as a console error Error: Invariant: attempted to hard navigate to the same URL /how-it-works. Happens on your app and the e2e app of the lib, but not on my apps < 12.2.

Yeahh I noticed that as well. Doesn't seem to be causing major issues but will keep an eye out for a Next.js patch for it.

Interestingly, that bug might be more consequential than I initially thought. I realized that now some of my dynamic pages that use shallow routing were no longer navigating properly. The URL in the address bar changes but nothing else, the app doesn't render the new page. I figure it might be related to the Next.js issue linked.
I've disabled the middleware once again and will monitor.

@alexturpin Are you using also emotionCache in your application?

@middlebaws hmm not directly, perhaps Mantine does under the hood. Why?

@all-contributors please add @alexturpin for bug,doc,ideas
regarding the navigate bug: I released 0.9.0 and I think it seems mostly gone with the new matching logic of isPageRequest, that now excludes requests with the x-nextjs-data header. That also excludes prefetch requests to other pages that load when next/link comes into view - doesn't make sense to apply a CSP there .
In the e2e app it only happens whenever I hard-navigate to https://e2e-next-safe-middleware-nibtime.vercel.app/isr/gsp (an ISR page) from the home page (the links there are regular <a>'s, so CSP refreshes), and if I did once, the error keeps recurring.
However If I directly enter https://e2e-next-safe-middleware-nibtime.vercel.app/isr/gsp into the browser it loads without error the also for any subsequent navigation.
Also when you go to https://e2e-next-safe-middleware-nibtime.vercel.app/gsp and then use the internal navigation (next/link) to https://e2e-next-safe-middleware-nibtime.vercel.app/isr/gsp, the error doesn't happen.
So it seems to happen, whenever the first navigation was a hard navigation with an <a>. Really odd.

@alexturpin
the shallow routing bug you described seems not gone yet, still persists in 12.2.3 released 3 days ago: https://github.com/vercel/next.js/issues/38595

closing this, I consider the style problem with emotion and Mantine solved. I will keep an eye on the routing bug(s) with middleware, as soon as they are solved it will release a patch version with updated peer deps that only allow Next 12.2 versions since the fix.

The hard-navigate bug is gone in 12.2.4-canary.7. The shallow routing bug won't get fixed completely as it seems,

Ah so shallow routing won't be compatible with the middleware at all then?

Seems like it, at least certain patterns. Apart from the note, I couldn't find a PR with a fix in code. I don't like that middleware breaks perfectly good working existing setups.
I made to decision to split up the lib (https://github.com/nibtime/next-safe-middleware/discussions/60#discussioncomment-3259782) in multiple packages, so that more configuration options than middleware are available, with different peer dep requirements, so the CSP features don't depend on latest Next.
You might decide now not to go for 12.2 beacuse your app requires the shallow routing, but then also can't use this lib because middleware is the only option, etc.

@alexturpin
correction: https://github.com/vercel/next.js/releases/tag/v12.2.4-canary.8 also includes a code fix alongside the caveat note.
I forked the minimal repro with 12.2.4-canary.8: https://codesandbox.io/s/restless-dream-0u45e8. The shallow routing works there.

@alexturpin
correction: https://github.com/vercel/next.js/releases/tag/v12.2.4-canary.8 also includes a code fix alongside the caveat note.
I forked the minimal repro with 12.2.4-canary.8: https://codesandbox.io/s/restless-dream-0u45e8. The shallow routing works there.

Woo! That's fantastic. Thanks for the update!


Argus toolbelt

Status
Ready
Description
Bumping the image to new major version as there are breaking changes to an upcoming update to the integration mnemonicMDR

@konraduh The pr looks great but can you please pull from master and push again ? and please add me as a particapent

@konraduh Hi, there was a problem with the pr changes are merged in https://github.com/demisto/dockerfiles/pull/12800