Syntax error on PS1 script for unwrap Encryption Key

Hello,
there is a Syntax Error on line 30 of the script in section "Key Encryption Key scenario", step 2
... Documents\WindowsPowerShell\Modules\Az.Agit pgit ccounts).name ...
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 730f8398-bf64-be5c-0574-19f8c991d20d
Version Independent ID: 4d33564d-fa8a-9a98-ad31-5779b0824efe
Content: Troubleshooting BitLocker boot errors on an Azure VM - Azure Virtual Machines
Content Source: articles/virtual-machines/troubleshooting/troubleshoot-bitlocker-boot-error.md
Service: virtual-machines-windows
GitHub Login: @genlin
Microsoft Alias: genli

@fantocciotesina Thanks for pointing out the problem. I will fix it.

@genlin Thanks for fixing the document.
@fantocciotesina The document is updated and changes will go live soon.

@VikasPullagura-MSFT @genlin Thank you all, now the document is OK!


Fix local development

When I removed backwards compatibility in 75fbce6d, I also removed the
thing that made dev-mode work, since we were always overriding the
username with wego-admin in tilt.
This removes the dev-user altogether - it just replaces the username,
but we can just log in with a different username instead if we want -
and reimplements dev-mode to mean "use cookie, disable verification"

Tested it locally, everything works fine for me.


Cannot send Cross-Origin-Resource-Policy from embed code

Bug description
I cannot force the embedded chart to sent the Cross-Origin-Resource-Policy header. I have set the CORS options and embedding parameters for iframe embedding as well as Cookie and CSP policy.
Superset is hosted at localhost:8088 while I'm embedding charts at localhost:9000.
I have followed the configuraiton of Flask CORS_OPTIONS here, but I cannot get rid of sending the right headers from the embedded chart.
This is my superset_config.py
# CORS OPTIONS
ENABLE_CORS = True
CORS_OPTIONS = {
    'supports_credentials': True,
    'allow_headers': ['*'],
    'resources':['*'],
    'origins': [ 'http://localhost:9000', 'http://localhost:8088']
}
SUPERSET_FEATURE_EMBEDDED_SUPERSET=True

# EMBED CODE  IFRAME OPTIONS
OVERRIDE_HTTP_HEADERS = {'X-Frame-Options': 'ALLOWALL'}
HTTP_HEADERS = {"X-Frame-Options":"ALLOWALL"}

SUPERSET_WEBSERVER_DOMAINS = [ 'localhost', 'localhost:8088', 'localhost:9000']
# SESSION_COOKIE_DOMAIN

#  (default: "Lax") Prevents the browser from sending this cookie along with cross-site requests.
SESSION_COOKIE_SAMESITE = "None"

#  (default: False): Controls if cookies should be set with the HttpOnly flag.
SESSION_COOKIE_HTTPONLY = False

#  (default: False) Browsers will only send cookies with requests over HTTPS if the cookie is marked “secure”.
# The application must be served over HTTPS for this to make sense.
SESSION_COOKIE_SECURE = False

#CSRF_COOKIE_HTTPONLY = False
WTF_CSRF_ENABLED = False

# TALISMAN_ENABLED defaults to True; set this to False in order to disable CSP
# @see https://superset.apache.org/docs/security/#csp-requirements
TALISMAN_ENABLED = False

# you grant public role the same set of permissions as for the GAMMA role.
# This is useful if one wants to enable anonymous users to view dashboards.
# @see https://apache-superset.readthedocs.io/en/0.35.1/security.html
PUBLIC_ROLE_LIKE_GAMMA = False

# For environments where CSP policies are defined outside of Superset using other software, administrators can disable this warning
CONTENT_SECURITY_POLICY_WARNING = False

and the iframe was
<iframe
  width="600"
  height="400"
  seamless
  frameBorder="0"
  allowfullscreen
  scrolling="no"
  src="http://localhost:8088/superset/explore/p/a8yN1wGMobp/?standalone=1&height=400&show_filters=true&expand_filters=true"
>
</iframe>

while the python server serving that iframe is
#!/usr/bin/env python3
from http.server import HTTPServer, SimpleHTTPRequestHandler, test
import sys

class CORSRequestHandler (SimpleHTTPRequestHandler):
    def end_headers (self):
        """
            Cross-Origin-Resource-Policy: cross-origin if the resource is served from another location than your website. ⚠If you set this header, any website can embed this resource.
            Cross-Origin-Resource-Policy: same-site if the resource and your site are served from the same site.
            Cross-Origin-Embedder-Policy: credentialless instead of require-corp. It allows loading the resource, despite the missing CORP header, at the cost of requesting it without credentials like Cookies.
        """

        self.send_header('Cross-Origin-Embedder-Policy', 'credentialless') #require-corp
        self.send_header('Cross-Origin-Opener-Policy', 'cross-origin') #same-origin
        self.send_header('Cross-Origin-Resource-Policy', ' cross-origin')
        self.send_header('X-Frame-Options', 'allow-from *')
        self.send_header("Access-Control-Allow-Origin", "*")

        SimpleHTTPRequestHandler.end_headers(self)

test(CORSRequestHandler, HTTPServer, port=int(sys.argv[1]) if len(sys.argv) > 1 else 8000)

How to reproduce the bug

Copy the superset_config.py provided above
Copy the html code above in a embed.html page
Create a cors.py python code
execute python cors.py 9000 to serve the embedded chart

Screenshots/recordings
The Chrome error was
Specify a Cross-Origin Resource Policy to prevent a resource from being blocked
Because your site has the Cross-Origin Embedder Policy (COEP) enabled, each resource must specify a suitable Cross-Origin Resource Policy (CORP). This behavior prevents a document from loading cross-origin resources which don’t explicitly grant permission to be loaded.

To solve this, add the following to the resource’ response header:

Cross-Origin-Resource-Policy: same-site if the resource and your site are served from the same site.
Cross-Origin-Resource-Policy: cross-origin if the resource is served from another location than your website. ⚠If you set this header, any website can embed this resource.

Alternatively, the document can use the variant: Cross-Origin-Embedder-Policy: credentialless instead of require-corp. It allows loading the resource, despite the missing CORP header, at the cost of requesting it without credentials like Cookies.

Superset version
master / latest-dev
Python version
3.9
Node version
18 or greater
Browser
Chrome
Additional context
No response
Checklist

[X] I have searched Superset docs and Slack and didn't find a solution to my problem.
[X] I have searched the GitHub issue tracker and didn't find a similar bug report.
[X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

[NOTE]
Using
OVERRIDE_HTTP_HEADERS = { 'X-Frame-Options': 'ALLOWALL' }
HTTP_HEADERS = { "X-Frame-Options" : "ALLOWALL" }

or  as detailed here
HTTP_HEADERS = {}

does not solve this issue.

My solution was to write a Flask Middlware to send the proper headers, specifically
response.headers.add("Cross-Origin-Embedder-Policy", 'require-corp')
response.headers.add("Cross-Origin-Resource-Policy", 'cross-origin')

As alternative, when using a reverse proxy (e.g. nginix) it is possible to add to the nginix/nginix.conf
add_header Cross-Origin-Resource-Policy "cross-origin";

Of course the Flask middleware solution is more flexible for development purposes.

This will only work if you disable Talisman and set your own content security policy.
**TALISMAN_ENABLED = False
#Allows any website to embed the iframe on its website
#OVERRIDE_HTTP_HEADERS = { "X-Frame-Options": "ALLOWALL" }
#Allows only your website to be the only website allowed to embed dashboards
OVERRIDE_HTTP_HEADERS = { "Content-Security-Policy": "frame-ancestors http://your.domain.com;" }
@loretoparisi**


Assessment2

Metric
Value

alert_status
:white_check_mark: OK

bugs
0

code_smells
9

reliability_rating
A (0 Bugs)Note: A being best, E being worst

security_rating
E (at least 1 Blocker Vulnerability)Note: A being best, E being worst

vulnerabilities
2


custom type with ngx-datatable

[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[x ] support request

Current behavior
I defined custom type "table" for fieldArray exploiting ngx-datatable
@Component({
  selector: 'app-table-type',
  template: `
<ngx-datatable
  #table  class="bootstrap"
  [headerHeight]="50"
  [limit]="5"
  [columnMode]="'force'"
  [footerHeight]="50"
  [rowHeight]="'auto'"
  [rows]="model">
  <ngx-datatable-column>
    <ng-template ngx-datatable-cell-template let-rowIndex="rowIndex" let-value="value" let-row="row">
      <formly-form
        class="form-inline"
        [model]="model[rowIndex]"
        [fields]="getFields(field)"
        [options]="options"
        [form]="formControl">
      </formly-form>
    </ng-template>
  </ngx-datatable-column>
</ngx-datatable>

the output result is not in grid format

Please, any suggestion?
Expected behavior
The table as https://stackblitz.com/edit/angular-hiihhc?file=app%2Fapp.component.ts

Angular version: 6.0.x

Browser: Chrome 67.0

I have elaborate a custom type for fieldArray, exploiting ngx-datatable and ng-template.
  template: `
<ngx-datatable
  #table  class="bootstrap"
  [rows]="model"
  [columns]="columns"
  [columnMode]="'force'"
>
  <ng-template #genericcolumn ngx-datatable-cell-template let-rowIndex="rowIndex" let-value="value" let-row="row" let-column="column">
    <formly-form
      [model]="getModel(model,column,rowIndex)"
      [fields]="getFields(field,column, rowIndex)"
      [options]="options"
      [form]="formControl">
    </formly-form>
  </ng-template>

</ngx-datatable>
`
})

This the working example
https://stackblitz.com/edit/angular-formly-datatable
I still have an error:
Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked.
And the value of the form is corrupted on the first row of the field array as you can see in https://stackblitz.com/edit/angular-formly-datatable

Hi looking better I found the fix:
ng-template definition using formly-field
  <ng-template #genericcolumn ngx-datatable-cell-template let-rowIndex="rowIndex" let-value="value" let-row="row" let-column="column">
    <formly-field
      [model]="getModel(model,column,rowIndex)"
      [field]="getFields(field,column, rowIndex)"
      [options]="options"
      [form]="formControl">
    </formly-field>
  </ng-template>

The complete working example of integration with ngx-datatemplate and ngx-formly,
with a custom type is here:
https://stackblitz.com/edit/angular-formly-datatable
I hope could help someone else.
@aitboudad
I can add the example of integration in the guide

yes please !!,
I'm currently looking at your example but didn't get it yet :confused:


Increase max supported battery capacity from 1000 to 2000 ampere-hour.

I have a 1500 Ah battery :-)

What kind of battery is that? O_O

What kind of battery is that? O_O

i have 1800 Ah aswell (52V lifepo4)

I changed it in my repo, this makes a few things a bit easier. https://github.com/mr-manuel/venus-os_dbus-serialbattery/commit/0d35803a456df38a9c7019d0ca69b336c3af4e17

Thank you so much @mr-manuel!

You're welcome


Adds artists.albums(artistId) to fetch album pages for artist

Didn't find any previous tests for paged endpoints so didn't add tests for this. Please let me know if I missed anything :)

Thanks for adding this new method! 😄👍


Web.xml error-page is not used

Unlike App Engine env, in managed VM the <error-page> tag in web.xml is not used and the user sees a page like this in case of error 500 :
HTTP ERROR: 500

Problem accessing /. Reason:

    org.apache.jasper.JasperException: java.lang.NullPointerException
Powered by Jetty://

I forked the hello app to show that unexpected behavior : https://github.com/erugeri/appengine-java-vm-hello/compare/webxml-error-page-bug?diff=unified

error-page issue seems to have been fixed in the GoogleCloudPlatform/appengine-java-vm-runtime async-support branch. To use it, you can create a docker file, appengine-java-vm-hello/src/main/webapp/Dockerfile to contain the following:
FROM gcr.io/google_appengine/jetty9-compat:githubheadasync
ADD . /app

Great! Thanks for the reply.
I'd really like to test it, unfortunately: https://github.com/GoogleCloudPlatform/gcloud-maven-plugin/issues/85


Fix 404 and recompress images

:+1:

@mxxcon The PlayStation URL was fixed in #1105.

Then again, were these compressed images already taken care of, too?

@RichJeanes since this PR?
@jamcat22 (i think) fixed merge conflict.

I just remember seeing a PR that had a bunch of compressed images, just didn't remember if it was this one or another one that already got merged. I didn't know if this PR was needed or not since the other thing it fixed (the PSN link) was fixed already.

I made a similar recompress commit a couple of month ago.

Please remove all the provider images. Then it should be ok.

Comments from the review on Reviewable.io

Yeah not totally sure what happened.

I'll make a new one tomorrow.


Documentation: Enhancement Of Contributing.md

The contributing.md looks is not in a structured manner. Also some sections are missing. I can enhance it in a well structured manner with proper details and some additional sections also that will make the contributors easier to contribute. Please can you assign me this task?
Wanted to do the following changes :-

Enhance the project structure
Add project structure section
Add additional method of contributing through GitHub desktop section
Add good coding practices section
Add the help and support section
Add the pull request section
Add issue report process section

Hi @milansamuel609,
Thank you for expressing your interest in working on this issue. I'm delighted to inform you that I have assigned this issue to you. Your willingness to contribute to our project is much appreciated.
Before making any contributions, please read the Readme.md file carefully to better understand the project's goals and purpose. This will give you clarity on our mission. Also, make sure to review the Contributing.md file, which contains important guidelines to make the contribution process smoother, especially for newcomers.
Feel free to start working, and if you have any questions or need assistance during the process, please don't hesitate to reach out.

Hi @milansamuel609,
Thank you for expressing your interest in working on this issue. I'm delighted to inform you that I have assigned this issue to you. Your willingness to contribute to our project is much appreciated.
Before making any contributions, please read the Readme.md file carefully to better understand the project's goals and purpose. This will give you clarity on our mission. Also, make sure to review the Contributing.md file, which contains important guidelines to make the contribution process smoother, especially for newcomers.
Feel free to start working, and if you have any questions or need assistance during the process, please don't hesitate to reach out.

Surely I will go through all the details before starting to work and thank you so much for this opportunity.

I'd like to work on this issue for Hacktoberfest! Please assign it to me.

I'd like to work on this issue for Hacktoberfest! Please assign it to me.

I'd like to work on this issue for Hacktoberfest! Please assign it to me.

I'd like to work on this issue for Hacktoberfest! Please assign it to me.

I'd like to work on this issue for Hacktoberfest! Please assign it to me.

I'd like to work on this issue for Hacktoberfest! Please assign it to me.

I'd like to work on this issue for Hacktoberfest! Please assign it to me.

I'd like to work on this issue for Hacktoberfest! Please assign it to me.


No module named 'pysteps.motion._proesmans'

I installed pysteps on linux machine, using conda and pip, and with both installations when I try to import the packge, I get the same error:
ModuleNotFoundError: No module named 'pysteps.motion._proesmans'

Hi @relmonta, welcome to pysteps!
Can you provide more details on your setup please? What python version are using? Are you installing from source within a conda environment or from PYPI?

Hi @dnerini , Thank you for your reply,
I am installing it in a new environment from conda-forge following this guide, my python version is 3.9.7

Hi @relmonta ,
Are you executing the import pysteps... from a directory containing a clone of the pysteps repository or containing a folder named pysteps?  That could cause that kind of import error.

Exactly, could you check that you're not running in the same issue described in #40?

Thank you, that's true.

Very good. I'm not sure how often this issue happens in reality, but I think we'll consider adding a specific note in the documentation ...
Happy nowcasting!


the status.physicalInterface of the egressnode cr have not been upgrade after i changed the node interface name

Describe the version
egressgateway v0.1.0
Describe the bug
the status.physicalInterface of the egressnode cr have not been upgrade after i changed the node interface name
Hwo To Reproduce
Steps to reproduce the issue:

change the interface name of one one of your cluster
check the status.physicalInterface of the egressnode cr on the node

Expected behavior
we expect that the status.physicalInterface of the egressnode cr would be upgraded same with the node interface name
Screenshots and log

Resolved after feature eip was merged

old version


Jinja version

Pull Request Test Coverage Report for Build 358

0 of 0   changed or added relevant lines in 0 files are covered.
22 unchanged lines in 3 files lost coverage.
Overall coverage remained the same at 95.899%

Files with Coverage Reduction
New Missed Lines
%

openregistry/lots/loki/tests/base.py
1
99.15%

openregistry/lots/loki/models.py
1
94.23%

openregistry/lots/loki/tests/blanks/auction_blanks.py
20
94.51%

Totals

Change from base Build 357:
0.0%

Covered Lines:
3601

Relevant Lines:
3755

💛  - Coveralls


Align Package manager version requirements

PR Description
Fixes the inconsistent behavior between version requirements of 3rd party dependencies, based on which package manager you use.
Using RxSwift as an example:

Package.swift uses .upToNextMajor(from: "5.0.0"), which will resolve it to any 5.y.z version
Cartfile uses ~> 5.0 which, surprisingly, will also resolve it to any 5.y.z version
However, .podspec has ~> 5.0, which will resolve it to any 5.0.z version.

Extra context
Initially, I only wanted to raise RxSwift's version requirement from 5.0 to 5.1, because:
RxSwift 5.1.0 removed the deprecated UIWebView extensions. However, Moya/RxSwift insists on using 5.0.
Currently, no new app using Moya/RxSwift can be submitted to the app store.

Warnings

:warning:
Moya.podspec, Cartfile were updated, but there were no changes in Cartfile.resolved, Package.swift, Package.resolved.
Did you forget to update them?

Messages

:book:
macOS: 	 Executed 283 tests, with 0 failures (0 unexpected) in 15.994 (16.276) seconds

:book:
tvOS: 	 Executed 283 tests, with 0 failures (0 unexpected) in 13.022 (13.372) seconds

:book:
iOS: 	 Executed 283 tests, with 0 failures (0 unexpected) in 13.115 (13.512) seconds

  Generated by :no_entry_sign: Danger Swift against cb5310857395617459617bb45fd6f6d6a07a7014

Hello :)
Thanks for taking time to improve Moya!
The RxSwift 5.1 subject have already been discussed in some recent opened issues like #2003 and #2018 . The conclusion was that there was no issue.

However, .podspec has ~> 5.0, which will resolve it to any 5.0.z version.
I'm afraid you are wrong, here is an example from the official Podfile guide:
'~> 0.1' Version 0.1 and the versions up to 1.0, not including 1.0 and higher

With this correction it looks to me that versioning rules as the same on all 3 dependency manager (at least for RxSwift) and there is no changes needed.
Morever, your changes would allow Cocoapods to use any superior major version of Alamofire, ReactiveSwift and RxSwift, which we certainly don't want. A new major version contains breaking changes which would make Moya to not compile.

Oh, I seem to have misread the error message.
You are right, this change would allow any version of Alamofire, ReactiveSwift and RxSwift.
Apologies for your time.


Handle SIGTERM in crc daemon

Catch SIGTERM so that crc daemon ends like other commands (by sending a message to segment)
runDaemon() can now return an error if it can't listen the unix socket (instead of panic)
couple of refactorings.

In Catch SIGTERM when running crc daemon to gracefully shutdown it, I'm not fully clear what kind of segment events we want to link to daemon stopping? "Amount of time the crc daemon run"?

Yes seems weird. Just wanted to know if someone is using crc daemon and verify we correctly receive failures.

In Catch SIGTERM when running crc daemon to gracefully shutdown it, I'm not fully clear what kind of segment events we want to link to daemon stopping? "Amount of time the crc daemon run"?

Yes seems weird. Just wanted to know if someone is using crc daemon and verify we correctly receive failures.

Everything should be good now. PTAL.

Everything should be good now. PTAL.

Waiting for https://github.com/code-ready/crc/pull/1781

Waiting for https://github.com/code-ready/crc/pull/1781

Rebased. This is now way lighter!

Rebased. This is now way lighter!

I separated the rename, it's better now.

I separated the rename, it's better now.

Oups sorry, fixed the message.

Oups sorry, fixed the message.


Set up Travis CI

Obviously, won't have much to do because there are no tests, but it can run yarn format:check and yarn lint.

Internal ticket: https://issues.liferay.com/browse/IFI-538


Next8 build fails with: TypeError: path must be a string or Buffer

I'm using webpack-s3-plugin to upload webpack assets to our CDN, but after upgrading to Next 8 the build fails with
TypeError: path must be a string or Buffer     at Object.fs.open (fs.js:636:11)     at ReadStream.open (fs.js:1996:6)     at new ReadStream (fs.js:1983:10)     at Object.fs.createReadStream (fs.js:1931:10)     at t.exports.uploadFile (.../node_modules/webpack-s3-plugin/dist/s3_plugin.js:1:6689)     at t.map.t (.../node_modules/webpack-s3-plugin/dist/s3_plugin.js:1:6330)     at Array.map (<anonymous>)     at transformBasePath.then (...//node_modules/webpack-s3-plugin/dist/s3_plugin.js:1:6318)     at <anonymous>
Has anything changed in how next handles custom webpack configs that could cause this issue? The webpack-s3-plugin version and next.config.js are exactly the same as the one working in Next 7.
webpack: (config, { isServer }) => {

     config.push(new S3Plugin({
          include: /.*\.(css|js|jpg|gif|svg|png|ico|pdf)/,
          exclude: /.*\.map/,
          s3Options: {
            accessKeyId: 'XXX',
            secretAccessKey: 'XXX',
            region: 'XXX'
          },
          s3UploadOptions: {
            Bucket: 'XXX',
            CacheControl: 'max-age=86400'
          },
          basePathTransform: () => releaseString + '/_next'
        }));
    return config;
}

Probably related to futureEmitAssets https://github.com/zeit/next.js/pull/6114
In theory you could disable it, but you'd opt-out of the massive memory optimization. I guess you'd probably want to use the aws cli to upload to s3 instead.


Histogram dimensions should be created dynamically

Currently the histogram dimensions are created upfront and then filtered based on selections.  It would be better for crossfilter if the dimensions were just created at the time of update and render, then discarded after they have been used.  This is due to the limit of 64 dimensions in crossfilter.

No longer relevant


Added main thread check

A check to avoid accessing applicationState when not on UI thread has been added, otherwise iOS raises a big warning about doing this.
This only applies to SkiaViews since they render on a separate thread.

SkiaView doesn't need the appState check anyways right? (the app state change will trigger a new JS render?)

SkiaView doesn't need the appState check anyways right? (the app state change will trigger a new JS render?)

It could benefit from it as well - but the app state is not accessible when you're not in the main thread.


feat: add ZFS module build

This is very nice. I have a few servers that are ubuntu based due to zfs and otherwise CoreOS and Flatcar. Gonna give this a try :)


Not able to download files - it says already downloaded

I was trying to use the kaggle-cli to download a specific dataset but not able to do so.
I use kg download -u username -p password -c competitionname to download but it dosent work, It says
downloading https://www.kaggle.com/c/digit-recognizer/download/train.csv
train.csv already downloaded !
downloading https://www.kaggle.com/c/digit-recognizer/download/test.csv
test.csv already downloaded !
downloading https://www.kaggle.com/c/digit-recognizer/download/sample_submission.csv
sample_submission.csv already downloaded !.
Cannot see the file, i tried using an empty folder but it doesnt work. I also tried uninstalling and installing kaggle-cli again.

kaggle-cli is a different project that is not maintained by Kaggle.  Please report issues here https://github.com/floydwch/kaggle-cli or switch to using this client (pip install kaggle).


Unable reach Vite dev server with start-server-and-test and axios

Describe the bug
When I start my development server with Vite, it works completely fine in the browser, but querying it with axios like this axios.get('http://localhost:3000') or with the start-server-and-test package it results in 404 responses.
Here are the headers sent:
       _header: 'GET / HTTP/1.1\r\n' +
        'Accept: application/json, text/plain, */*\r\n' +
        'User-Agent: axios/0.21.1\r\n' +
        'Host: localhost:3000\r\n' +
        'Connection: close\r\n' +
        '\r\n',

Reproduction
It's reproducible in my repository https://github.com/blacksonic/vue-3-playground by running npm run test:e2e:javascript or starting the dev server with npm start and running node ./axios.js. Both cases return 404 errors.
System Info

vite version: 2.0.0-beta.56
Operating System: MacOS
Node version: v14.15.3
Package manager (npm/yarn/pnpm) and version: npm 6.14.9

Logs (Optional if provided reproduction)

Run npm run test:e2e:javascript.
Provide the error log here.

HTTP(S) error for http://localhost:3000 Error: Request failed with status code 404
making HTTP(S) get request to  url:http://localhost:3000 ...

axios defaults to accept only JSON and plain text. Set your accept header to include text/html.

axios defaults to accept only JSON and plain text. Set your accept header to include text/html.

Is it a Vite specific setting not to accept text/plain? It works with Rollup/Webpack by default in my other repo https://github.com/blacksonic/todomvc-svelte.
I don't know if its a missing feature or a decision not to support it.

Is it a Vite specific setting not to accept text/plain? It works with Rollup/Webpack by default in my other repo https://github.com/blacksonic/todomvc-svelte.
I don't know if its a missing feature or a decision not to support it.

I don't know where should it be in the codebase, but I would happily contribute it if it fits the repo.

I don't know where should it be in the codebase, but I would happily contribute it if it fits the repo.

It's an explicit decision because text/plain may need to go through the resolve/transform pipeline. Only text/html is exempt.

It's an explicit decision because text/plain may need to go through the resolve/transform pipeline. Only text/html is exempt.

Can confirm upgrading to later version fixes this.

@dbousamra there was a fix in start-server-and-test but you still have to write http-get://localhost:3000 instead of http ://localhost:3000


Fixes issue #2074 DatetimePicker throws NPE if manually entered valid datetime is outside of allotted datetime range

Summary
Resolves the NPE error when user tries to enter time along with valid date outside of the allotted datetime range.
The fix is to validate whether the date entered is within the datetime range after the date value is validated.
Resolves #2074

The rest looks good. Add on the test, and you should be good to go.

New PR #503 has been logged for this issue as the  newly added jest test had dependency on terra-date-picker component which is not available in this branch. Hence closing this PR.

I think all we would need honestly is a jest test.

New jest test has been added for this issue in the PR #503 .


Added ability to read in a string blob

I've run into a situation where it's required that I create a RMagick image to do some pre-processing of an image (for instance, to increase the density) to allow for better OCR results. In order to avoid having to write a file to disk just to re-read it with RTesseract I thought it would be useful to have the ability to read in a blob created with RMagick's to_blob function.
I have not tested this fully with mini_magick (not what I use), but I stubbed that out anyway to match.
Here's my test case:
blob = Magick::Image.read("some.jpg").first.resample(600).auto_gamma_channel().white_threshold(245).quantize(256,GRAYColorspace).to_blob
test = RTesseract.new("/tmp/bar.tiff") # /tmp/bar.tiff doesn't exist
test.from_blob(blob)
print test.to_s

thanks


Add discord shield badge to README

This would highlight how active the community really is at just a glance, which is nice. It will however require an admin of the discord server to activate this under Server Settings->Widget-> enable server widget

Rendered:

Rendered:

Yes, it will render like that until the settings on the discord server has been activated.
after that it should look something like this:

Yes, it will render like that until the settings on the discord server has been activated.
after that it should look something like this:

The widget has to be turned on the discord too, does it not?
Also, alternatively, I use all shields from this personally. It unifies the design across everything and you can customise it: https://shields.io
Worth a consideration :)

The widget has to be turned on the discord too, does it not?
Also, alternatively, I use all shields from this personally. It unifies the design across everything and you can customise it: https://shields.io
Worth a consideration :)

I dig it!
@joshuajbouw doesn't this pr already use shields.io?

I dig it!
@joshuajbouw doesn't this pr already use shields.io?

Oh! So it does 😆


[WIP] Fix/clean npm scripts

I found the npm scripts a bit difficult to understand, not only from the point of view of the names, but also how they were organized.
I tried to use a scope to group them together, where the "short" command is usually the one, that contains them all.
I haven't done anything with pack and dist. I didn't figure out yet, why there are 6 script entries necessary for something, that probably will be run with CI tools. I also can't think of a case, where all operating systems are built with a single run. I would suggest to reduce those to just pack and dist for the current OS.

FYI, npm install is not run anymore automatically after npm run clean. I think it makes the documentation more consistent to just always have to run npm install.

@martinheidegger npm-run-all -p start:watch start:electron does run both processes in parallel, but if you start from scratch, it seems that ic may happen, that you first had to wait for start:watch to finish, because otherwise webpack would not have finished. The second time it all works.

Oh right! Yes, that is an issue. We would need a start:build script to be executed before npm-run-all

Oh right! Yes, that is an issue. We would need a start:build script to be executed before npm-run-all

Can we just use build:dev" script, because this already exists and isn't really used. build:prodis used for packaging and distributions. Or better rename it tostart:build`?

Right build:dev is fine.

Can you rebase again (with the removed package-lock.json)?

@martinheidegger would you mind to do this, because I don't have this cool Git software, that you have ;-)
I'm pretty much done here, so if you want to make this pull request prettier in terms of commit messages, rebasing, squashing and all that stuff, that I needed to consult a manual, please go ahead!


Can't navigate in apratment_1 scene

Hey there,
For some reason, when the  apartment_0 scene is loaded in the viewer, I can't leave the starting room - the agent just refuses to go back. It seems like everything outside the starting room is not navigable.
I don't see this behavior in any other scenes.
The command I use to run the viewer:
python examples/viewer.py --scene ~/datasets/Replica/apartment_2/habitat/mesh_semantic.ply

@VladimirYugay it is always possible that the navmesh for a scene is incomplete. Often it is broken by holes in the floor, for example. You can press 'n' to visualize the navmesh and ALT+'n' to resample the agent's position in order to teleport to another location on the navmesh and get yourself unstuck.


eslint for es6

Refactoring code to follow Airbnb Javascript Style Guide.
It is good to start from small to follow a particular style guide, so that code styles are coherent throughout the repo

+1 for this effort. Consistency will make it easy for everyone to read the same way.
Aside from that note, running npm run lint is producing a lot of errors that still needs to be addressed.

@vutran sure, more refactoring needed to be done to fix those lint errors, such as no-console for console.logs occurrence within each modules, etc.

@tanhauhau Looking good, there is a merge issue which needs to be addressed first.

@jcampbell05 i've updated the PR

Coverage increased (+0.5%) to 86.854% when pulling b702e90e964706c2e3ec58420fab6b93947e0deb on tanhauhau:es6 into df412c71efeac28840abc4c1f993056336126587 on Bottr-js:master.

@tanhauhau Thanks for this! Would you like to be invited to our Slack and added as a member as our organisation.

@jcampbell05 sure


Use separate method for checking correctness of a pattern

This brings a 2.4x speedup on my machine
This function is called inside the inner most loop, so small improvements have the greatest effect here I guess.
The Correctness::check() mirrors Correctness::compute() providing the same result as comparing a pattern against a computed result, but this allows short circuiting the check at the first mismatch.
I didn't make this a separate implementation/algorithm, as the change is mainly in the lib side.

Nice! I do wish we could share more between these, like maybe through some helper methods?
Also, I think you can just swap out the implementation in Guess::matches instead, rather than change each algorithm?

Also, I think you can just swap out the implementation in Guess::matches instead, rather than change each algorithm?
I agree. This seems slightly slower than (hyperfine showed my initial PR to be 1.04x faster), but I wouldn't consider that too significant compared to the overall speedup.

I do wish we could share more between these, like maybe through some helper methods?
I made a helper for checking mismatched letters. Otherwise I don't see what would be nicely sharable between the two.

Also, I'm not too familiar with rust, and I was wondering which would be more idiomatic in rust when referring to the type inside its own impl block: using the name of the type, or using Self
For example
impl Correctness {
    fn compute(answer: &str, guess: &str) -> [Self; 5] {
        let mut c = [Correctness::Wrong; 5];  // this
        let mut c = [Self::Wrong; 5];                // or this
        // ...
    }
}

This seems slightly slower

Interesting! That suggests we should break out #[inline] and #[inline(always)] to see if we can claw some of that back.

Otherwise I don't see what would be nicely sharable between the two.

That's fine — even extracting that helped I think.

Also, I'm not too familiar with rust, and I was wondering which would be more idiomatic

I'd say using Self is more idiomatic, but I'd also say it's a toss-up, and you should choose whichever you think reads better :)


EMFILE error when running shrinkwrap command

When I run the shrinkwrap command I get the following error:
EMFILE, open '/Users/mrausch/Projects/sparkler-web/node_modules/node-libs-browser/node_modules/path-browserify/package.json'
something went wrong. Did not write npm-shrinkwrap.json```

As a workaround I bumped ulimit -n from 256 up to 2560 and the command runs successfully.

That's expected behaviour.

It's expected behavior that it fails unless you modify an individual system's configuration?

I dont know who is the blame to it. I suspect it's our npm dependency and it's an npm bug.
It could be npm-shrinkwrap itself in which case replacing fs with graceful-fs might fix it.

Ok, thanks


docs(zh): update zh docs from en and format some en docs

Hi，when I start learning router V4, I found the chinese docs lag behind the English docs. So I try to update the chinese docs based the commit f672bf01902368e65ca33e247b53d537ef0edc6c .
if you have any suggestions, I'm happy to accepte.

@Jinjiang Hi, jinjiang, can you help me to review this PR ? Thanks~

@edison1105  多谢你的 review，后续我再检查一下中英文格式以及常见的名词错误，短时间的初步翻译，可能会有很多纰漏，请见谅

@KimYangOfCat @edison1105 I was planning on moving vue router repo to a monorepo which would complicate this PR. Is it okay if we merge this as it is to move forward and then review it again?

@posva I thinks its readly to merge now. @KimYangOfCat

yes, it's ok to merge now


Fix a test ordering issue.

A randomised order causes failure due to unintentional dependencies between
two of the test cases.
Fixes #8276

[x] tests are added or updated

Travis failures don't seem relevant.

Note: travis failures are caused by doc-nits and are being fixed elsewhere.
(cd .; /usr/bin/perl util/find-doc-nits -n -p ) >doc-nits
doc/internal/man3/DEFINE_SPARSE_ARRAY_OF.pod:1: OPENSSL_SA missing from NAME section
doc/internal/man3/DEFINE_SPARSE_ARRAY_OF.pod:1: DEFINE_SPARSE_ARRAY_OF missing from SYNOPSIS
doc/internal/man3/openssl_ctx_get_data.pod:1: openssl_ctx_set_data missing from SYNOPSIS
doc/internal/man3/openssl_ctx_get_data.pod:1: openssl_ctx_free_index missing from SYNOPSIS
doc/internal/man3/OSSL_METHOD_STORE.pod:1: OSSL_METHOD_STORE (filename) missing from NAME section
doc/internal/man3/OSSL_METHOD_STORE.pod:1: OSSL_METHOD_STORE missing from NAME section
make: *** [doc-nits] Error 1
+// MAKE DOC-NITS FAILED
The command "if [ -n "$CHECKDOCS" ]; then if $make doc-nits; then echo -e '+// MAKE DOC-NITS OK'; else echo -e '+// MAKE DOC-NITS FAILED'; false; fi; fi" exited with 1.

(reposted, because misformatted in the dismissal note)
Pauli, can please add [extended tests] to your commit? I don't see how the line which you fixed could possibly interfere with the "fnord" property.
    ok 5 - test_property
    # ERROR: (int) 'j = ossl_property_value("fnord", 1) == i + 1' failed @ test/property_test.c:49
    # [9] compared to [5]
    not ok 6 - test_property_string

Merged, thanks.

The extended tests should have been enabled.
Some explanation is warranted.  A late change to the property implementation was automatic initialisation and finalisation.  Prior to this, everything was reinitialised for each test and the string caches were flushed for each test.  Now the caches are flushed at text exit only.
Confound this with the extended test that randomises the test execution order and the value string used here green gets numbered differently and this test fails.

I merged this without realising the approval had been withdrawn.

I merged this without realising the approval had been withdrawn.

And considering the commit and if we want to be very formal about it, only @mspncp can approve :wink:

I merged this without realising the approval had been withdrawn.

And considering the commit and if we want to be very formal about it, only @mspncp can approve

Ok, sorry @paulidale for the inconvenience caused by the withdrawal of my premature approval. As a self-punishment, I need to prove now that I understood what's going on, ok?  ;-)
All string values are cashed internally as "unique strings" and an integer value is returned as a handle to this unique string value. The test originally checked whether "green" and "fnord" where assigned consecutive integer values. Now when executed in random order, the "green" value got cached before that by some colour=green statement, whence the indices where not consecutive anymore.

Yes, you are spot on in your description of the underlying issue.  It escaped my notice when I switched to the single initialisation and was my first thought once I saw the error message.
The caching and reduction to small integers is for performance, string comparisons become integer compares and merging two queries together fall out as a linear time operation.
Anyway, thanks for quickly fixing my mistake.


create issue breakdown: Ascent/Entry

See RPOD for reference in #16
Define these points in a comment in this issue:

[ ] Define Take-Over points (where does the team take control of the vehicle?)
[ ] Define Hand-Over points (where does the team stop controlling the vehicle?)
[ ] Define Event Sequences (describe, in a sentence, what the team does with the vehicle)

Create an issue...

[ ] for each Event Sequence to create fine-grained procedures in the form of a markdown file
[x] to determine algorithm similarity between Event Sequences (i.e. where could code be reused?) (#35)
[x] to program each general algorithm/function to be used across multiple Event Sequences (#36)
[x] to program a controlling function for each Event Sequence (#28)
[x] to program a Continuous Integration test for each Event Sequence's controlling function (#37)
[x] to program unit tests for each function used throughout all of the team's Event Sequence scripts (except the controlling functions) (#38)

The mission's commanding script will begin with pre-launch preparation and then hand off control to A/E while SLS is on the launchpad, no stages activated.
TO1: SLS is on the launchpad.
ES1: SLS flies to Kerbin orbit.
HO1
Other teams handle trans-lunar injection, lunar landing, lunar ascent, trans-Kerbin injection.
TO2: Orion SM is still attached, 100 km above Kerbin's surface, returning from Mun.
ES2: Separate from SM and fly through atmosphere. Splashdown.
HO2


Stuck on loading

After i purge existing Daytona installation according to steps: https://www.daytona.io/docs/installation/installation/
I install Daytona via the Docker extension and get stuck on loading screen.

MacOS

Closed with #8


[FEAT] Update Comment in the Blog section by the User(Creator of comment)

Description
An API endpoint to enable users to update their comments in the Blog comment section. The endpoint ensures a user can update their comment in the blog section at will. The endpoint should at first ensure that the comment exists. The endpoint should also be protected, and ensure that the user that is logged in is the owner of the said comment.

Models Involved

Comment: Represents the comments made by users on blog posts.
Blog: Represents the blog posts to which comments are made.

Acceptance Criteria

The endpoint should be accessible at PUT /api/v1/user/blog/comment/{comment-id}
The endpoint should accept HTTP POST requests.
The endpoint should be secured to ensure that only authenticated users can update their comments.
Requests to the endpoint must include a valid authentication token in the Authorization header. Authorization: Bearer
The comment should be tied to the blog it is meant to comment on.

Endpoint
Description: Update the content of the About page.
Endpoint: PUT /api/v1/about
Authentication: Required
Authorization: Creators of resource(comment) only
Request Body:
{
  "comment_body": "string"
}

Response

On a successful update of the comment, the API should return a 200 Ok status code.
The response body should contain status and a message
Response (Success):

{
  "message": "Comment updated successfully.",
  "status": "success",
  "status_code": 200
}

If the comment body field is missing or invalid, the API should return a 400 Bad Request status code with appropriate validation error messages.

{
  "message": "comment field must be provided",
  "status": "unsuccessful",
  "status_code": 400
}

If the comment is not found, the API should return a 404 Not Found status code with appropriate validation error messages.

{
  "message": "comment not found",
  "status": "unsuccessful",
  "status_code": 404
 }

If a user tries to edit a comment that does not belong to them, the API should return a 400 Bad Request status code with appropriate validation error messages.

{
  "message": "You do not have permission to edit this comment.",
  "status": "unsuccessful",
  "status_code": 400
}

Purpose
Provides a secure backend service that allows users to update their comments in the blog section.

Requirements

Develop server-side logic to update the user’s comments in the blog section.
Securely handle comments updates and comply with security standards.
Ensure that the user owns or originally wrote the comment they want to update.

Expected Outcome

API endpoint allows users to update their comments in the blog section with appropriate validation and security measures.

Tasks

[ ] Define the server-side application's PUT /api/v1/user/blog/comment/{comment-id} route.
[ ] Ensure requests include a valid token in the Authorization header.
[ ] Validate that user owns the comment they want to update.
[ ] Update the comment body if it is valid and meets security requirements.
[ ] Handle cases where the current user is not the comment owner.

Testing

Write unit tests to validate user can only update a comment they have written.
Write integration tests to ensure end-to-end functionality.
Perform security testing to ensure data protection and compliance.

Comments are not tied to any model

issue not fixed


Fix menu bar collapse on mobile

This edit ensures that the navbar will collapse when the text of a navbar entry is clicked.  Without this fix, clicking the text itself (instead of the space near the text in the navbar) causes the menu bar to fail to collapse because the event comes from a  element instead of the  element that contains the .

Thanks for your contribution @dancardy !


fix: more leaks

Something happens when I test this PR executing something simple like echo hola:
==418537==ERROR: AddressSanitizer: heap-use-after-free on address 0x503000000b50 at pc 0x567348514f6f bp 0x7ffc13315290 sp 0x7ffc13315280
READ of size 8 at 0x503000000b50 thread T0
#0 0x567348514f6e in free_array src/free.c:35
#1 0x5673485194bd in execute_single_builtin src/execution.c:37
#2 0x56734851a0c5 in execution src/execution.c:116
#3 0x567348512384 in main src/main.c:201
#4 0x7bb1e402a1c9 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
#5 0x7bb1e402a28a in __libc_start_main_impl ../csu/libc-start.c:360
I'll investigate, but can't be merged like this.

Remove free(macro->m_pwd)

Remove free(macro->m_pwd)

I have removed, that was the conflict of the last merge. Somehow the free_array function makes it crash


Enhancement: doc could illustrate how to select an entity instead of just typing text in batch action modals

The batch action example has something along the lines of:
        <form>
            <div class="mt-3">
                <input type="text" class="form-control" name="new-owner-input" placeholder="Enter owner id">
            </div>
        </form>

This was an ok first cut, but instead of typing  the id for an entity, I would like to be able to have a "choices" widget where I could pick one. How can I put such a widget in this batch action modal? It could be a list of users, it could be a list of parts, etc. Not a string representing a primary key. Is there such an advanced example or documentation?
In my particular case I want to be able to assign N tasks to 1 user. The batch action stuff is almost perfect, I just need a way to select which user I want. Right now I enter its primary key in the INPUT of the FORM above.
Thanks for listening!

In other words: I want to put a drop-down for a foreign key, just like in the CREATE or EDIT for an entity (relationship entities appear as a drop-down)

I also want to make sure only a user from the same tenancy can be selected. So, I guess I could manually query the database for a list of available users from the same tenancy - something I already have done for the Users ModelView:
    def get_list_query_for_request(self, request: Request):
        if request.session["user_role"] in [UserRole.SUPERADMIN.name]:
            return self.get_list_query()
        else:
            return self.get_list_query().where(User.company_id == request.session["user_company_id"])

Is there a way for me to leverage this stuff in the User's ModelView from the @action in my Task's ModelView? Can I somehow call <the logged user's ModelView>..get_list_query_for_request(request) from form=``` in my Task ModelView, perhaps leveraging some sort of template injection?
I mean, I am just trying to figure out how to generate this HTML markup just like starlet-admin already generates at its core when I say a field  is of type "User".
Thanks.

@sglebs
I have similar requirement, and  made a workaround with this

load your custom statics with add custom statics_dir, should be the same as original

from starlette_admin.contrib.sqlmodel import Admin
admin_app = Admin(engine,
                  statics_dir=app_path('resources/views/admin/static'),
                  ])

add your custom js with select2 css, the .is-select2 is used for rendering action modal with select2, the point here is observing rendered modal with your select

# resources/views/admin/static/js/custom-select2.js

const targetElement = document.querySelector('#modal-form');

const observer = new MutationObserver(function (mutations) {
  for (const mutation of mutations) {
    // Check if the target element has been added to the DOM
    if (mutation.addedNodes && mutation.addedNodes.length > 0) {
      for (const node of mutation.addedNodes) {
        if (node.hasChildNodes() && node.childNodes[1].classList.contains('is-select2')) {
          renderAction();
        }
      }
    }
  }
});

observer.observe(targetElement, {childList: true, characterData: true});

function renderAction() {
  $('.is-select2').select2({
    width: '100%',
    dropdownParent: $('#modal-form')
  });
}

render in your admin_view

class YourView(ModelView):
    actions = ['select2_dropdown']

    # load select2.min.css here
    def _additional_css_links(
            self, request: Request, action: RequestAction
    ) -> Sequence[str]:
        if action.is_form():
            return super()._additional_css_links(request, action)
        return [
            str(
                request.url_for(
                    f"{request.app.state.ROUTE_NAME}:statics",
                    path="css/select2.min.css",
                )
            ),
        ]
    # load your custom js here
    def _additional_js_links(
            self, request: Request, action: RequestAction
    ) -> Sequence[str]:
        if action.is_form():
            return super()._additional_js_links(request, action)

        return [
            str(
                request.url_for(
                    f"{request.app.state.ROUTE_NAME}:statics",
                    path="js/vendor/select2.min.js",
                )
            ),
            str(
                request.url_for(
                    f"{request.app.state.ROUTE_NAME}:statics",
                    path="js/custom-select2.js",
                )
            ),
        ]

    @action(name='select2_dropdown_actions',
            text='a modal with dropwodn',
            confirmation='Proceed ?',
            submit_btn_text='Yes',
            submit_btn_class='btn-success',
            form="""
    <form>
        <select  id="anyid" class="form-control is-select2" multiple="multiple">
            <option></option>
            ...
        </select>
    </form>

then you can init your select2 with ajax to your API endpoints and get what you want


Merging observables with retry

I'm trying to produce an IObservable<T> sequence from an IEnumerable<IObservable<T>> using the merge feature. What I also want is for the merged sequence to continue retrying when encountering an error. I've tried the following and have had no success:
_observables = observables.Merge().Retry();

_observables.Subscribe(observer) //stops getting messages through

and
foreach (var observable in observables)
{
    _observables= _observables.Merge(observable.Retry());
}

_observables.Subscribe(observer) //stops getting messages through

also
foreach (var observable in observables)
{
    _observables= _observables.Merge(observable.Retry()).Retry();
}

_observables.Subscribe(observer) //stops getting messages through

What am I missing? Everytime I use merge, I think it loses the fact I want to retry.

@herecydev it depends on the sort of sequence you have underneath - https://github.com/Reactive-Extensions/Rx.NET/issues/238 has some interesting discussions on Retry and what this actually means for the sequence.

Thanks for linking that issue, there's a wealth of content there. Rx is new to me so I'm still struggling with some of the concepts. I've thrown together a gist that demonstrates what I'm trying to do. I'm guessing that when an exception is raised in A, B is unsubscribing from C. How can I prevent this?

If I understand correctly, merge is creating an AnonymousSafeObserver which is working against what I had intended in the scenario above. Is there anyway to avoid using this and instead use an AnonymousObserver. I don't want the subscription to be disposed when an error occurs.

Retry works on the upstream errors and can't retry a failure that is after it, for example, in a further downstream operator or an end-subscriber. If your item processing can throw, move it from Subscribe into a Do before Retry:
sources.Merge()
.Do(v => processItem(v))
.Retry()
.Subscribe();

Closing due to inactivity.


io_loadspec_niimrs.m : bugfix for optional dim_{n}_header

io_loadpsec_niimrs can load additional detail for the "extras" dimension, but did not check for the presence of the corresponding dim_{n}_header before using it. This caused failures when reading data generated by a recent spec2nii.
Furthermore, the dim_number index was not set correctly to the identified "extras" dimension.

Thank you Alex!


Remove hardcoded user uid from dockerfile

https://github.com/open-cluster-management-io/multicloud-operators-subscription/pull/201
Signed-off-by: Philip Wu<EMAIL_ADDRESS>

/test test-unit

/lgtm


Fix typos found by codespell

I guess the compatiblity typo is from Mathworks and should not be fixed here:
https://github.com/fangq/jsonlab/blob/7d7e7f77e9754721146fe90f7ece1b910c3e0bc7/jsonlab.prj#L44-L47

thanks, merged. I agree that the .prj key name should not be fixed.

Thanks. Out of curiosity, I couldn't find any online documentation on Matlab project files. Do you know of any?

Thanks. Out of curiosity, I couldn't find any online documentation on Matlab project files. Do you know of any?

I don't believe I have ever released the toolbox using .mltbx formatted package, although you could build this package using the .prj file, jsonlab is portable enough that it could just be deployed with a zip/tarball.


Chat - Wrong error message when members try to open workspace link

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Precondition: User A should have workspace in which he/she is admin and user B is member

Open the app and login with user A
Open settings
Open workspaces
Open any workspace in which user B is member
Copy the URL and send the URL to user B
Open the app in another device and login with user B
Click on URL sent by user A and observe the error, error mentions that 'If you need to join the workspace, inform workspace owner' even when though user is already member of workspace

Expected Result:
App should not mention 'If you want to join the workspace' in error if user is already member of workspace
Actual Result:
App mentions 'If you want to join the workspace' in error even if user is already member of workspace
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.42-18
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/e37c3cae-0c1a-4cd2-ac38-a964ccc25119
Expensify/Expensify Issue URL:
Issue reported by: GH handle - @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689705088200759
View all open jobs on GitHub

I don't think this is a bug. Discussing here.

Discussed here, and determined this is not a bug, as user B is shown this "cannot access" error since they're not an admin. Closing!


code optimization for sealer CLI

Describe what this PR does / why we need it

polish CLI: delete unused flag, add example for join, delete ,run;
let all master could access api server.
split clean logic to kube reset and container runtime uninstall.
return error fast if user not set required flag Or args.

Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Very important PR, thx.


cltorch fails gradInput bad argument error

Hello,
Yesterday convnet-benchmarks were running and today something is broken! :-)
I am getting this error. I completely did a fresh install of convnet-benchmarks, torch, cltorch and clnn and I am still unable to fix the error.
Please help.
[manju@anders-15 cltorch]$ th imagenet_winners/benchmark.lua
libthclnn_searchpath    /usr2/manju/Moonshot/DeepLearning/opencl/torch/install/lib/lua/5.1/libTHCLNN.so
Running on device: Intel(R) HD Graphics
Using Intel(R) Corporation , OpenCL platform: Intel(R) OpenCL
Using OpenCL device: Intel(R) HD Graphics
ModelType: OverFeat[fast]       Kernels: clnn   Input shape: 128x3x231x231
Apply_1t_1s_0pt_-2_*out = val1 build log:
fcl build 1 succeeded.
fcl build 2 succeeded.
bcl build succeeded.
SpatialConvolutionMM.cl build log:
fcl build 1 succeeded.
fcl build 2 succeeded.
bcl build succeeded.
Apply_1t_0s_0pt_-2_*out = (*out > 0) ? *out : 0 build log:
fcl build 1 succeeded.
fcl build 2 succeeded.
bcl build succeeded.
/tmp/luarocks_clnn-scm-1-314/clnn/SpatialMaxPooling.cpp build log:
fcl build 1 succeeded.
fcl build 2 succeeded.
bcl build succeeded.
Apply_2t_0s_0pt_-2_-2_*out = ( *in1 > 0) ? *in1 : 1e-06f build log:
fcl build 1 succeeded.
fcl build 2 succeeded.
bcl build succeeded.
Apply_3t_0s_0pt_-2_-2_-2_*out = (*in1 > 0) ? *in2 : 0.0f build log:
fcl build 1 succeeded.
fcl build 2 succeeded.
bcl build succeeded.
/tmp/luarocks_clnn-scm-1-314/clnn/SpatialMaxPooling.cpp build log:
fcl build 1 succeeded.
fcl build 2 succeeded.
bcl build succeeded.
SpatialConvolutionMM.cl build log:
fcl build 1 succeeded.
fcl build 2 succeeded.
bcl build succeeded.
/usr2/manju/Moonshot/DeepLearning/opencl/torch/install/bin/lua: .../install/share/lua/5.1/clnn/SpatialConvolutionMM.lua:21: bad argument #1 (field gradInput does not exist)
stack traceback:
[C]: in function 'SpatialConvolutionMM_updateGradInput'
.../install/share/lua/5.1/clnn/SpatialConvolutionMM.lua:21: in function 'updateGradInput'
...opencl/torch/install/share/lua/5.1/nn/Sequential.lua:58: in function 'updateGradInput'
...opencl/torch/install/share/lua/5.1/nn/Sequential.lua:58: in function 'updateGradInput'
imagenet_winners/benchmark.lua:45: in main chunk
[C]: in function 'dofile'
.../torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:145: in main chunk
[C]: ?

Line 21.  Hmmm.  Can you re-update clnn (luarocks install clnn), and reconfirm the problem still exists please?  If it still exists, please can you provide lines 18-24 of /usr2/manju/Moonshot/DeepLearning/opencl/torch/install/share/lua/5.1/clnn/SpatialConvolutionMM.lua please?

Yes, the problem still exists...
/usr2/manju/Moonshot/DeepLearning/opencl/torch/install/bin/lua: .../install/share/lua/5.1/clnn/SpatialConvolutionMM.lua:21: bad argument #1 (field gradInput does not exist)
stack traceback:
[C]: in function 'SpatialConvolutionMM_updateGradInput'
.../install/share/lua/5.1/clnn/SpatialConvolutionMM.lua:21: in function 'updateGradInput'
...opencl/torch/install/share/lua/5.1/nn/Sequential.lua:58: in function 'updateGradInput'
...opencl/torch/install/share/lua/5.1/nn/Sequential.lua:58: in function 'updateGradInput'
imagenet_winners/benchmark.lua:45: in main chunk
[C]: in function 'dofile'
.../torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:145: in main chunk
[C]: ?
The lines 18-24 are:
 18       return self:baseUpdateGradInput(input, gradOutput)
 19    end
 20
 21    return input.nn.SpatialConvolutionMM_updateGradInput(self, input, gradOutput)
 22 end
 23
 24 function nn.SpatialConvolutionMM:accGradParameters(input, gradOutput, scale)

Hmmm... I wonder... am I accidetnally trying to run the cpu functions? :-P  Ok, I shall ponder a bit...

Hmmm, tests seem to be really running the gpu methods, on my machine, with very latest nn installed.  Can you just confirm that the tests pass ok please?  ie luajit -l clnn -e 'clnn.test()'.

Hmmmm, I get the same error message actually.

Well... actually .... slightly different:
$ luajit imagenet_winners/benchmark.lua
libthclnn_searchpath    /home/ubuntu/torch/install/lib/lua/5.1/libTHCLNN.so
Running on device: GRID K520
Using NVIDIA Corporation , OpenCL platform: NVIDIA CUDA
Using OpenCL device: GRID K520
ModelType: OverFeat[fast]       Kernels: clnn   Input shape: 4x3x231x231
warming up
luajit: /home/ubuntu/torch/install/share/lua/5.1/nn/Sequential.lua:58: bad argument #1 (field gradInput does not exist)
stack traceback:
        [C]: in function 'updateGradInput'
        /home/ubuntu/torch/install/share/lua/5.1/nn/Sequential.lua:58: in function 'updateGradInput'
        /home/ubuntu/torch/install/share/lua/5.1/nn/Sequential.lua:58: in function 'updateGradInput'
        imagenet_winners/benchmark.lua:47: in main chunk
        [C]: at 0x00406670

Hello, Sorry to be a bother, but any updates on this ?

You're right. I should fix this...  please feel free to ping me once a day, till I fix it.  Tomorrow is good, since its saturday :-)

I don't know if this is helpful. But I had a cltorch tree from 15 Dec 2015  and that doesn't have this issue.

I don't know if this is helpful. But I had a cltorch tree from 15 Dec 2015 and that doesn't have this issue.

yes, its something to do wit hthe THNN changes.

Fixed in https://github.com/hughperkins/clnn/commit/9bfe115b969796334c924e27ac1544d0576a10fe , I think.  Try now?


bowtie: make map for interpreting genome ids

When we run bowtie we get genome ids, but usually we actually want taxids.  Make a map so it's easy to get back to taxids.

I don't think I have enough context here to do a meaningful review. I haven't worked with refseq or the NCBI API. General note is that I would find these easier to review with even a small number of comments describing what a function or call does :P

I can look at it today or tomorrow
On Fri, 17 Nov 2023 at 1:51 PM Lenni Justen @.***>
wrote:

I don't think I have enough context here to do a meaningful review. I
haven't worked with refseq or the NCBI API. General note is that I would
find these easier to review with even a small number of comments describing
what a function or call does :P
—
Reply to this email directly, view it on GitHub
https://github.com/naobservatory/mgs-pipeline/pull/37#issuecomment-1816927256,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN7ASMRZUIIA2RA2VJ3KFPDYE6W4ZAVCNFSM6AAAAAA7P7AGV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWHEZDOMRVGY
.
You are receiving this because your review was requested.Message ID:
@.***>


Pre-release version

Hello there, this is Djamil from the Grav Team.
We noticed that your plugin is released as a pre-release on GitHub. This is all fine except we just implemented a new testing channel in the Grav GPM to allow developers, like you, to have resources not available to everyone but just those who want to try a pre-release version.
The testing channel is a setting you can switch to from admin and the only way to see pre-releases, like your extension here.
This is a friendly notice to let you know that as this moment your extension is not visible in the stable channel until you do a proper release (without the pre-release flag toggled), it is however available as a testing plugin.
If you are fine with the plugin being only available as a testing plugin, no further action are required on your end.
Thank you for your contribution to the Grav project, it is much appreciated! 😃

Hello Djamil,
Thank you so much for your notice.
I'll will make it an official release after grav reaches its 1.1.0
milestone and I have time to test it.
Kind regards,
francis
On 2016-04-21 01:19 AM, Djamil Legato wrote:

Hello there, this is Djamil from the Grav Team.
We noticed that your plugin is released as a pre-release on GitHub.
This is all fine except we just implemented a new testing channel in
the Grav GPM to allow developers, like you, to have resources not
available to everyone but just those who want to try a pre-release
version.
The testing channel is a setting you can switch to from admin and the
only way to see pre-releases, like your extension here.
This is a friendly notice to let you know that as this moment your
extension is not visible in the stable channel until you do a proper
release (without the pre-release flag toggled), it is however
available as a testing plugin.
If you are fine with the plugin being only available as a testing
plugin, no further action are required on your end.
Thank you for your contribution to the Grav project, it is much
appreciated! 😃

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/aptly-io/grav-plugin-googlemaps/issues/5

--
Kind regards,
francis                   home page
"Empty cans make the most noise" - Farah Ann Abdul Hadi


Use new palette values for main palette

Only swaps colors that will be very obviously different alongside new components.

im guessing this is not intended?

@haileyok hmmmm (oh geez I hope I'm not missing something obvious), does something look off there?

@estrattonbailey i didn't look closely but I'm betting the scroll view and the scroll view content container styles don't match up. Likely that the view itself's background is still solid black.


clippy and rustfmt are not really supported

Same issue: #693

/not-stale

Still not stale

Still not stale

They are supported when you use wearerequired/lint-action@master.


refactor(jest-mock): remove useless conditional

Summary
Conditional always evaluates to true, and is caught a few lines above anyway:
https://github.com/facebook/jest/blob/4670d3be0d80d47844673eb163666253e788f006/packages/jest-mock/src/index.ts#L871-L873

Test plan
N/A

Changelog should have been under refactors if anything, but I think it's to small to warrant even that clutter so I removed the changelog entry again


Script settings menu broken in latest 0.49 nightly build

OpenMW has recently merged a MR introducing a new Lua context, menu scripts: Gitlab link
This is unfortunately a breaking change for mods like yours, as settings renderers are now accessible only from the new menu context.
[10:49:13.797 E] Menu[scripts/omw/settings/menu.lua] eventHandler[OmWSettingsRegisterPage] failed. Lua error: [string "scripts/omw/settings/menu.lua"]:91: Setting status_key of PCLSettingsControls has unknown renderer inputKeySelection
[10:49:13.797 E] stack traceback:
[10:49:13.797 E] 	[C]: in function 'error'
[10:49:13.797 E] 	[string "scripts/omw/settings/menu.lua"]:91: in function 'renderSetting'
[10:49:13.797 E] 	[string "scripts/omw/settings/menu.lua"]:151: in function 'renderGroup'
[10:49:13.797 E] 	[string "scripts/omw/settings/menu.lua"]:284: in function 'renderPage'
[10:49:13.797 E] 	[string "scripts/omw/settings/menu.lua"]:475: in function 'registerPage'
[10:49:13.797 E] 	[string "scripts/omw/settings/menu.lua"]:512: in function <[string "scripts/omw/settings/menu.lua"]:511>

The fix is quite easy. I already fixed it in my local copy, and can submit a pull request if you want:

Create a new menu.lua file, add it to the omwscripts file like this: MENU: carefree_leveling/menu.lua
Move the call I.Settings.registerRenderer('inputKeySelection', function(value, set) from the settings.lua file to the menu.lua file

Unfortunately, once you do this, you break compatibility with OpenMW 0.48 as it can't recognize the MENU tag in the omwscripts file. The only way around this is, as far as I can tell, to have separate forks of the mod for 0.48 and for 0.49.

do you have this fork? I would be interested in it.

ah dang, I totally forgot about this,  I must have seen it at some point and removed it from my inbox, but I forgot to circle back.  I can push a patch in a mome, but feel free to fork if you'd rather

fork
I did fork it here free feel to remove the comments. I think this only fixes the menu issues IDK if it needs anything else.

I updated it per RonikTR's info, did a quick test and everything seems to be working in the current nightly.  the old 0.48 version is in it's own branch for anyone who needs it.
If you find any bugs feel free to send an issue or a pull request, or maintain your own fork - I admittedly haven't been playing a lot of MW in the past few months, so I probably won't be finding any subtle bugs with the new stuff.


Unable to compile php7

ext/iconv/.libs/iconv.o: In function php_iconv_stream_filter_dtor': /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:2557: undefined reference to libiconv_close'
ext/iconv/.libs/iconv.o: In function _php_iconv_strlen': /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:755: undefined reference to libiconv_open'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:779: undefined reference to libiconv' /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:813: undefined reference to libiconv_close'
ext/iconv/.libs/iconv.o: In function _php_iconv_appendl': /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:474: undefined reference to libiconv'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:508: undefined reference to libiconv' ext/iconv/.libs/iconv.o: In function _php_iconv_mime_decode':
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1505: undefined reference to libiconv_open' /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1998: undefined reference to libiconv_close'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:2001: undefined reference to libiconv_close' /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1616: undefined reference to libiconv_close'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1619: undefined reference to libiconv_open' ext/iconv/.libs/iconv.o: In function _php_iconv_substr':
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:876: undefined reference to libiconv_open' /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:900: undefined reference to libiconv'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:955: undefined reference to libiconv_close' /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:959: undefined reference to libiconv_close'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:908: undefined reference to libiconv_open' ext/iconv/.libs/iconv.o: In function _php_iconv_mime_encode':
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1194: undefined reference to libiconv_open' /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1208: undefined reference to libiconv_open'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1326: undefined reference to libiconv' /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1278: undefined reference to libiconv'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1310: undefined reference to libiconv' /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1470: undefined reference to libiconv_close'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1379: undefined reference to libiconv' /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1411: undefined reference to libiconv'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1467: undefined reference to libiconv_close' /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1454: undefined reference to libiconv'
ext/iconv/.libs/iconv.o: In function php_iconv_string': /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:578: undefined reference to libiconv_open'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:590: undefined reference to libiconv' /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:608: undefined reference to libiconv'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:618: undefined reference to libiconv_close' ext/iconv/.libs/iconv.o: In function _php_iconv_strpos':
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1003: undefined reference to libiconv_open' /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1031: undefined reference to libiconv'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:1145: undefined reference to libiconv_close' ext/iconv/.libs/iconv.o: In function php_iconv_stream_filter_append_bucket':
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:2708: undefined reference to libiconv' /root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:2707: undefined reference to libiconv'
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:2629: undefined reference to libiconv' ext/iconv/.libs/iconv.o: In function php_iconv_stream_filter_ctor':
/root/Genisys/php-build-scripts/work/ext/iconv/iconv.c:2583: undefined reference to `libiconv_open'
collect2: ld returned 1 exit status
make: *** [sapi/cli/php] Error 1

We don't support for polluted environment.


chore: added why use LCEL doc

Added a why use LCEL doc (ported from py library)
Sections in the py doc I removed:
first-class async support:
input and output schemas

Thanks!


[WIP] Add COMET scorer

Adds scorer for the COMET metric
Still need to see if it's worth adding tests for this given all the mocking that will be done

@neubig to confirm, can merge this?

Yeah! It was marked as "WIP"


Adds common interfaces around Models (implements #3158)

To facilitate support for creating more generic model conventions, separated the most common properties into interfaces and had appropriate classes implement them. This'll allow creating conventions like:
Implements #3158
public abstract class FilterModelConvention<TModel> where TModel : ICommonModel
{
    public virtual void Apply(TModel model)
    {
        model.Filters.Add(...);
    }
}

public class ApplicationFilterModelConvention : FilterModelConvention<ApplicationModel>, IApplicationModelConvention
{
}
```

Originally suggested base class(es), but interfaces allow for more flexibility.

Hi @Grinderofl, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Since you went this way instead of the base-class, some feedback on how to make this more complete.
=====================
ICommonModel is too specific and doesn't really capture all of things that most models have. IAttributeModel on the other hand includes attributes, which all models except ApplicationModel have.
I'd suggest something like the following:
public interface ICommonModel
{
    IReadOnlyList<object> Attributes { get; }

    // Implement explicitly, keep existing properties for things like MethodInfo
    MemberInfo MemberInfo { get; }

    // Implement explicitly, keep existing names for things like ActionName
    string Name { get; }
    IDictionary<object, object> Properties { get; } // Add this to ParameterModel and PropertyModel
}

This really defines the 'base' of everything besides ApplicationModel - I think it's an oversight that we never added properties to parameter/property models.
==============================
Separate filters and ApiExplorer into their own interfaces. They aren't related features and don't belong together.
===========================
The piece that I'm not thrilled about is that there are still several properties that can't really be fit into a coherent model. I think for the purposes of your PR it's fine, but it's a work item for the team to complete this design.
Ex:
public interface IRoutingModel
{
    AttributeRouteModel AttributeRoute { get; }

    IList<ActionConstraintMetadata> ActionConstraints { get; }

    IList<IRouteConstraintProvider> RouteConstraints { get; }
}

All of these are related to routing... the problem is that the picture here isn't as neat as I'm making it seem. ActionModel also has HttpMethods - which overlap with IActionConstraintMetadata, and ControllerModel lets you define multiple attribute routes.

Ahh! This explains so much! I was wondering why parameter and property models were a little lackluster. I'll update this hopefully within today.

I've done some changes there as per your recommendations, but refrained from touching the routing for time being, too ill to dive head first in that side of things. I'm not sure if it's feasible though, going by what you're saying... maybe routing part needs to just wait until the team's figured out the design?

maybe routing part needs to just wait until the team's figured out the design?

Yeah, please don't try to fix that for now. Those changes are going to have a big impact and we need to think about it a little more.

:watch: - looking pretty close. Need to fix failing tests

On it :+1:

Looks like the Linux build is failing due to package download issues...

:shipit: I'm going to clean this up an merge it so it can get in for beta8.
FYI your fix for the tests was the wrong fix. It's supposed to be a copy of the dictionary, the tests need to be updated for the addition of the new property.

49acfd562e8cc2b1c0284e7a1c4ffe4227c2d22b merged. Thanks!


fix(next): add empty pageprops object

Resolves #2892
Summary
This adds an empty pageProps object, the reason behind putting it before the spread is that if we have some HOC wrapping next-urql we don't want to override the existing pageProps.

is this a duplicate of #2574?

@kitten a bit different as it only focusses on resolving the empty object issue 😅 but yes feel free to merge the other one if you prefer

Ok, I see, I'm not inclined to add getAppProps since it's non-standard and would have to be documented, but can simply be replaced with an inner function being composed in. Since I haven't seen this before, lets' first merge this and discuss the alternative separately, since this is the less "committed" change, cc @Swiftwork


Enable auto reconnection

:tada: irc-fw has prepared us for this moment! Closes #18.
We should be reconnecting just fine without any problems. Client already prints all the necessary messages (connecting, reconnecting, socket errors, etc). Server prevents you from sending commands while you are not connected.

This doesn't work at all due to a bug in irc-framework. It just hangs in the registration phase and eventually timeout and try again.
I don't understand that part of the irc-framework part as the code is hard to follow, but it sounds like there's some state tracking that needs to be reset that isn't.

Hey guys, do you think there is a fix in progress on the irc-framework side of things?

It was fixed recently in irc-fw master, but I haven't had the occasion to retest it yet. But in theory yes, it's fixed!

Exciting! Can't wait to try this!

This is ready to be merged, @thelounge/maintainers.

Well, the code looks good. I'm happy to test it if you still think it needs some testing, equally I'm happy for it to go in (Especially as we'll be releasing to a beta/rc first). So :+1: for it. Obviously the testing is quite awkward trying to get it to disconnect from something to reconnect (Especially as I use znc).

I'll test this very soon!

Just tested this, and it finally works! 🎉 The only thing I see that needs fixing would be the comment I just added because it crashes on start, and then I think we're finally good to ship this!

@maxpoulin64, fixed the issued you noticed in this PR.
I'll do some tests of the overall PR tomorrow before merging!

Thanks @astorije, unsure how I missed that.

It's actually fairly hard to get disconnected from Freenode on purpose! I don't know what black magic is that, but when running The Lounge locally, turning wifi, turning it on a minute or 2 later and refreshing the page, messages posted during the time off wifi appeared, even though the server was running locally. Can't explain this too well, and it might be the consequence of a few things together (IRCv3, irc-fw, some flags on Freenode, I don't know...).
However, on a network that is not that smart, I got:

The socket error is when I shut down wifi. What this shows is that when reconnecting, it tried with the same username as before, but since the nick has not quit properly, it was still hanging around and the server refused to connect properly.
Is there something that can be done here, such as trying with a different nick (old_nik+random_int)? Or is letting the reconnect fail until it succeeds good enough?

Remember when we argued about nick changes before?
It currently only tries to change the name if it's irc.connection.registered).
It does look like it let you on the server after all though?

Yeah, definitely not an obvious fix.
At the very least, this PR reconnects fine, and as you said in your original message, it did reconnect, so it would be transparent overnight for example.
Let's merge this and improve edge cases over time.
👍 👏 👏


Change background color slider based in value

Hi,
I´m trying to colorize the background active slider based in the value with a computed property.
Something like this..

I am unable to colorize the active zone. Only can colorize grey zone and always is blue in active..
Can you help me?
Thanks for this awesome component!

Can be implemented using the process parameter.
example: https://jsfiddle.net/7wqvo2xc/
document: https://nightcatsama.github.io/vue-slider-component/#/basics/process?hash=when-the-type-of-process-is-function

Hi,
first of all, thank you for take the time to help me, really appreciate.
I´m trying to incorporate your solution, and it´s very near, but there are a few details I´m not able to do.
Probably, it´s a Vue problem, but i¨m very very newbie...
I have two problmes to solve:

The value it´s seted at the component mounted method, but the slider only it´s colorized when click on the dot and move the mouse(a little bit).
A example video for better explanation:

I´m trying to colorize the active dot for each step, with the template and :step, but i´m not able to pass the value to compose the custom-step class. For this, if I replace this.initialValue for a static value (3 for example), all sliders are well initialited and colorized.

I encapsulate you slider in a custom component with an input...
This is all the code:
<template>

        <vue-slider
            v-model="value"
            :contained="false"
            v-bind="options"
            :min="0"
            :max="4"
            :adsorb="true"
            :interval="1"
            :dotSize="24"
            :marks="marks"
        >
            <template v-slot:step="{ label, active, value }">

            </template>
        </vue-slider>
        <input type="hidden" :name="this.appname" :value="value" />

</template>

Call
<range-slider appname="app-name" initialvalue=2></range-slider>

Thank you!

The first problem should be caused by an incorrect type, ensuring that value is a numeric type.
{
  value: 0, // '0' is wrong
}
// ...
this.value = +this.initialvalue; // Make sure initialvalue is a numeric type

The second question can be used stepActiveStyle.
example: https://jsfiddle.net/NightCatSama/6mqhb1gv/13/
Of course, using slot is also possible, but you are using it wrong.
example: https://jsfiddle.net/NightCatSama/6mqhb1gv/17/

The first problem should be caused by an incorrect type, ensuring that value is a numeric type.

You are right. Changing to +this.initialValue makes all working well from init.. :tada:

The second question can be used stepActiveStyle.
example: https://jsfiddle.net/NightCatSama/6mqhb1gv/13/

I think this option is better... Tryed and all works fantasticly well
Again, thank you so much for all your time and support to help me! :blush:


WIP: DO NOT MERGE - Discussion PR for build from source changes

Discussion for changes made on branch oracle-build-from-source and how they differ from v0.18.1 release

Is it intentional to check in the vendor directory?

Closing pull request because "all the jenkins jobs are configured to ignore branches that are included in pull requests & by you creating pull requests where oracle-build-from-source is the source branch it will basically ignore that branch in every jenkins job"


Fix hex plotter

This class might work, maybe it does not work. We are not sure.
Even though our hex assets are 128X128, we configure this class with
HEX_WIDTH, HEX_HEIGHT = 63, 74

Oh we fixed it.


'Invalid Action' on window.FirebasePlugin.getVerificationID

Hello.
I have a Cordova proyect and I'm facing an issue with the window.FirebasePlugin.getVerificationID
It gives me an 'Invalid Action' message. This happens only on Android, in iOS works well.
I' been working with the https://github.com/jestcastro/cordova-plugin-firebase plugin with great results in the 0.1.22 version. But with the last update I get this error. And now with this plugin is the same.
Any suggestion? Thank you very much!

For now, I think the best option would be to check whether you're running on Android or iOS and to use verifyPhoneNumber instead if you're running on Android.


[ MB-16998 ] Data model updates for pending billed start date

Jira ticket
Summary

[x] Adding the PendingBilledStartDate to the API;

This patch makes a number of changes to the GHC API around adding pending billed
SIT start date into the response for shipment payments SIT balance.

[x] Adding pending billed start date to the service

This patch series adds the pending billed start date to the response for
shipment payments SIT balances endpoint. This work can be tested by an engineer
locally or in an ephemeral deployment, but only in what gets returned in the
endpoint call for the /shipments-payment-sit-balance.
➡ shipments-payment-sit-balance
/v1/payment-requests/${PAYMENT_REQUEST_ID}/shipments-payment-sit-balance

When verifying the response comes back from the server appropriately, open the
Network tab in the Chrome Debugger tool and load a payment request page as
a TIO with a similar URL like, /moves/${LOCATOR}/payment-requests/${UUID}.
If you get stuck reviewing this, please reach out to me directly to walk you
through it.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[x] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Create a multi-user, if you don't have one locally.
Navigate to the Testharness data scenarios page.
Create a new Move using the HHGMoveInSIT button.
As the TOO,review and accept the Domestic Destination SIT Delivery address
update request.
As the TOO, review the SIT start date as you will be using this as the date
window we'll need for the Prime Payment Request.
As the Prime, navigate to the Move and create a Payment Request using the
button at the top.
As the Prime, use the SIT start date mentioned above to select a date
for the DDASIT payment start date a day later than the date recorded in the
above step. Set a date for payment end date after the date you set for
payment start date.
As the TIO, navigate to the move using the locator to see the payment
request. When you open the document viewer, see the Network tab in the
Chrome Debugger tools and search for the endpoint named
shipments-payment-sit-balance. Notice that the server response now includes
a key of pendingBilledStartDate with the value you entered as the Prime
for the payment start date.

Messages

:book:
:link: MB-16998

  Generated by :no_entry_sign: dangerJS against 759adfe31095d2c0e46845643f64939347faaa03

@AnnaGingle Could you review this as well since this now includes @afoon's PR changes as well.

For others following along, I did not added specific unit tests for the payment start date as this refactor had Swagger definitions which are their own form of tests in the sense that Swagger will not compile properly if there are errors and the Golang type-checking here would also cover issues here. But there are already tests for the Start Date in the service this is calling. Also the client-side tests that @afoon added would also cover issues for this functionality.
➡ https://github.com/transcom/mymove/blob/ae29f21360d904214603580e2e06234fb625494f/pkg/services/payment_request/payment_request_shipments_sit_balance_test.go#L112-L136


Remove user access management from open source version

Description

[x] Migrate Vuex => Pinia
[ ] Add proper feature management
[x] Rework the settings view to better split between user settings and general settings
[x] Make the frontend use feature flags to hide user management entirely

Related Issue
#614
#432 ==> Components Migrated:

PasswordRecovery.vue
ResetPassword.vue
Signup.vue
Dashboard.vue
AdminUsers.vue
CreateUser.vue
EditUser.vue
InviteUsers.vue
UserProfile.vue
UserProfileEditPassword.vue
Project.vue

Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[ ] 🔧 Bug fix (non-breaking change which fixes an issue)
[x] 🥂 Improvement (non-breaking change which improves an existing feature)
[x] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

TODO: remove dashboard and arrive directly on projects screen when opening Giskard

Could you have a look at sonar results too?

An unhandled corner case:

enable enterprise mode
delete admin user
switch to free mode
no user settings are available

So this issue actually happens even with authentication enabled. If you delete the admin user while logged in as admin and refresh, it will make the settings button disappear.
I think these checks should be in place:
Either:
A. A user cannot delete itself
B. A user can delete itself but also gets logged out. If there is only a single user, deletion cannot happen (we can never have no users)
I think A is the best scenario because it prevents Admin deleting the only Admin user. To delete admin with the A scenario, you would first need to create another admin user.
And in any case, upon startup, InitService should check for the Auth state and if it's disabled, ensure the 'admin' user exists (and if not create it).

@Googleton, I agree with

And in any case, upon startup, InitService should check for the Auth state and if it's disabled, ensure the 'admin' user exists (and if not create it).

Currently we don't remove users from the DB, we disable them, but to handle all of the possible cases in the "free" version we should ensure that the "admin" user exists and it's enabled and if not create/enable it at startup.
As for the "enterprise" user management, I think we should combine both A and B, by applying the following logic:

If the current user is the only admin, he can't delete itself without assigning admin rights to some other user
when a user deletes itself we should redirect him to the login page
as a consequence of the first point, if you end up removing all of the users except for one, the last one must be an admin => he can't delete himself without creating another user and assigning admin rights to him


[bug] ResponseError#response#body has incorrect type

Issue Summary
ResponseError#response#body property has a type string assuming it is unparsed json string, but it is parsed json
Code Snippet
import sendgrid from '@sendgrid/mail';
import config from '../config';

sendgrid.setApiKey(config.SENDGRID_API_KEY)

sendgrid.send({
 to<EMAIL_ADDRESS>  from<EMAIL_ADDRESS>  subject: 'Test Subject',
  text: 'body',
  attachments: [{
    type: 'text',
    content: 'hello',
    filename: 'example.txt'
  }]
}).catch((error) => {
  console.log(typeof error.response.body)
})

Exception/Log
object

Ideally, I would want body to be extensively typed like {body: {errors: {message: string, field: string, help?:string}[]}
Technical details:

sendgrid-nodejs version: 7.4.0
node version: 12.18.1

Hello @bogdan,
Thanks for taking the time to report this!
I'm re-classifying this to a feature request since the current behavior is not broken, but it could be optimized.
This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.
With best regards,
Elmer

Hello @bogdan,
Thanks for taking the time to report this!
I'm re-classifying this to a feature request since the current behavior is not broken, but it could be optimized.
This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.
With best regards,
Elmer

Well, there is a feature component into that in the "Ideally" section, but there is also a bug that type definition is incorrect.

Well, there is a feature component into that in the "Ideally" section, but there is also a bug that type definition is incorrect.


Select Units

Click + drag to create a white outline of a rectangle which should be used to select all units within it.

Shell of the unit selection has been finished (See f636f66dc95afdd0b1f4587791cdba9e27044efd)


MacOS - cannot generate a 'microk8s inspect'

macOS Big Sur 11.5.1
microk8s 2.1.0 installed from home-brew today
'microk8s inspect' not working (will raise a different issue on this)
Additional features installed including 'dashboard' (no apps/customization yet)

Experienced an issue #2507 so went to gather output from 'microk8s inspect'.
However whilst this seemed to work, no file output was evident (could be long location, in vm etc...)
jonesn:~/ $ microk8s inspect                                                                                [17:26:32]
Inspecting Certificates
Inspecting services
  Service snap.microk8s.daemon-cluster-agent is running
  Service snap.microk8s.daemon-containerd is running
  Service snap.microk8s.daemon-apiserver-kicker is running
  Service snap.microk8s.daemon-kubelite is running
  Copy service arguments to the final report tarball
Inspecting AppArmor configuration
Gathering system information
  Copy processes list to the final report tarball
  Copy snap list to the final report tarball
  Copy VM name (or none) to the final report tarball
  Copy disk usage information to the final report tarball
  Copy memory usage information to the final report tarball
  Copy server uptime to the final report tarball
  Copy current linux distribution to the final report tarball
  Copy openSSL information to the final report tarball
  Copy network configuration to the final report tarball
Inspecting kubernetes cluster
  Inspect kubernetes cluster
Inspecting juju
  Inspect Juju
Inspecting kubeflow
  Inspect Kubeflow

Building the report tarball
  Report tarball is at /var/snap/microk8s/2346/inspection-report-20210809_172728.tar.gz
jonesn:~/ $ cp /var/snap/microk8s/2346/inspection-report-20210809_172728.tar.gz ~                                                                              [17:27:28]
cp: /var/snap/microk8s/2346/inspection-report-20210809_172728.tar.gz: No such file or directory
jonesn:~/ $ sudo cp /var/snap/microk8s/2346/inspection-report-20210809_172728.tar.gz ~                                                                         [17:27:33]
Password:
cp: /var/snap/microk8s/2346/inspection-report-20210809_172728.tar.gz: No such file or directory
jonesn:~/ $

The reason for this is that the output from the inspection is written into a local filesystem on the vm ie:
jonesn:~/ $ multipass shell microk8s-vm                                                                                [17:37:41]
Welcome to Ubuntu 18.04.5 LTS (GNU/Linux 4.15.0-153-generic x86_64)

 * Documentation:  https://help.ubuntu.com
 * Management:     https://landscape.canonical.com
 * Support:        https://ubuntu.com/advantage

  System information as of Mon Aug  9 17:37:56 BST 2021

  System load:  0.54              Processes:             146
  Usage of /:   5.7% of 48.29GB   Users logged in:       0
  Memory usage: 25%               IP address for enp0s2: <IP_ADDRESS>
  Swap usage:   0%

0 updates can be applied immediately.

New release '20.04.2 LTS' available.
Run 'do-release-upgrade' to upgrade to it.

Last login: Mon Aug  9 17:28:21 2021 from <IP_ADDRESS>
ubuntu@microk8s-vm:~$ ls /var/snap
core18  core20  microk8s  microk8s-integrator-macos  snapd
ubuntu@microk8s-vm:~$ ls /var/snap/microk8s/2346/inspection-report-20210809_172728.tar.gz
/var/snap/microk8s/2346/inspection-report-20210809_172728.tar.gz

The docs should make this clear - and really on macOS we would hope the 'wrapper' commands would retrieve this to the host?

You are right this is not a good experience. We will need a wrapper of the microk8s inspect command for win and mac that would go in [1].
[1] https://github.com/ubuntu/microk8s/blob/master/installer/cli/microk8s.py


gluster/block: remove redundant code comments

Comments that repeat exactly what is spelled out in code
in the next line are not helpful and should be avoided.
Signed-off-by: Michael Adam<EMAIL_ADDRESS>

@wongma7, @humblec - please take a look!

@jsafrane - ptal

any comments? :-)

/lgtm

/lgtm.

@wongma7 can you please merge this PR ?