WIP Fix/m1 mac

Description

Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.

Fixes # (issue)

https://github.com/openvinotoolkit/anomalib/issues/150

Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[ ] My code follows the pre-commit style and check guidelines of this project.
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing tests pass locally with my changes

@dreaquil, we'll need to move nncf and openvino related requirements to requirements/openvino.txt.
For the openvino imports in the inferencers, we'll first need to check if openvino is installed before importing the package. Alternatively we could import openvino in the corresponding part of the code rather than at the top of the module.
For the package version numbers we need some through testing internally to ensure that all the components work fine, and there is no performance degradation in the algorithms. After the check we could use these version numbers.

@dreaquil, looks like the branch has conflicts to be solved. If you want to get the pr merged, would you be able to resolve the conflicts please? Thanks

Hi @samet-akcay! Just checking in that the CI is still broken right?

@dreaquil, almost fixed. we'll try to get it up and running before the end of today.

@dreaquil, looks like black also fails. Can you run black -l 120 anomalib from your terminal, and hopefully this will be the last change. Thanks :)
if black is not installed in your virtualenv, you could run pip install black

@dreaquil, looks like black also fails. Can you run black -l 120 anomalib from your terminal, and hopefully this will be the last change. Thanks :)
if black is not installed in your virtualenv, you could run pip install black

Done! here's hoping :)

CI has passed finally 🎉. I'm gonna be merging the PR now


WIP Attempt to use zpool in zgpu

Hello Michal.  I'm having trouble figuring out how to add a dependency from zgpu -> zpool, so that I can replace zgpu's ResourcePool with zpool.Pool.
This PR shows what I've tried so far.  I added a test to the end of zgpu.zig where I'm trying to import zpool, but when I run zig test  libs/zgpu/src/zgpu.zig, I get the following error message:
$ zig test libs/zgpu/src/zgpu.zig
./libs/zgpu/src/zgpu.zig:1721:19: error: unable to find 'zpool'
    const zpool = @import("zpool");
                  ^

Any advice you can offer would be greatly appreciated.  Thanks in advance!

zig test doesn't invoke build.zig, you can use the --pkg-begin and --pkg-end options to specify packages (see zig test --help)
zig test --pkg-begin zpool ./libs/zpool/src/zpool.zig --pkg-end ./libs/zgpu/src/zgpu.zig should do it

Alternatively, you could add zgpu tests to our root build.zig and then run zig build test (this will run all tests).
const zgpu_tests = @import("libs/zgpu/build.zig").buildTests(b, options.build_mode, options.target);

Thank you both for the context on this issue.


Display dataset on focus

I have used minLength in options, but it is not working.
Can you please help me out?

The issue has to do with your usage of typeahead.js, through the options you pass to angular-typeahead but has nothing to do with angular-typeahead itself.
See #89 for a similar discussion.


Wrong character mapping in skinSprites.ts

Webamp maps some characters wrong and doesn't have "," even though Winamp has it.
Example images with the problematic characters included. The skin used in the example is Expensive_Hi-Fi_1_2.
Webamp:

Winamp 2.95:

Hmm. Netlify seems to have missed this PR and didn't run a deploy. I'll look into that.

Ah, there it is!
https://deploy-preview-1008--ecstatic-poincare-fe4c13.netlify.app/?skinUrl=https%3A%2F%2Farchive.org%2Fcors%2Fwinampskin_Expensive_Hi-Fi_1_2%2FExpensiveHi-Fi.wsz

Yeah, looks identical to me now. Except the default/base skin still shows the old characters, is there some kind of override for it?

Using the link on your comment, changed skin via the internal menu. IA skin (and all other skins) looks fine, but base skin does not.

Oh, the base skin is pre-compiled to CSS with inline data uris. That allows us to fetch the default skin as CSS rather than having to download the JSZip and the default_skin.wsz/parse/render before we can do first paint.  I'll need to rerun the script to do that.

I've updated with the new compiled base skin css. This breaks our integration tests since the image snapshots don't match any more. Here is are the image diffs, which look as expected.

I'll follow with another commit to update the image snapshots.


(IGNORE) Fix link to nightly build docs in README.md

Changes in this pull request
Unfortunately, the relative link is broken when the doc is rendered on the doc site: https://opensource.contentauthenticity.org/docs/c2patool/#nightly-builds.
Change to absolute URL fixes it.
Also added colon to UTC time, per Adobe style guide.

Codecov Report
Patch and project coverage have no change.

Comparison is base (c81b590) 83.91% compared to head (41ece42) 83.91%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   83.91%   83.91%
=======================================
  Files           3        3
  Lines         373      373
=======================================
  Hits          313      313
  Misses         60       60

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@scouten-adobe Your change still uses a relative URL.  It needs to be an absolute URL for it to work from https://opensource.contentauthenticity.org/docs/c2patool/#nightly-builds.
Also, wouldn't we always want to link to the file in the main branch?  The main branch should always have the current/approved documentation; if there's a WIP branch, e.g. for a PR, then the link might temporarily go to the current README.md instead of the one in the branch, but that seems like an edge case that could easily be ignored during PR review.


error

Traceback (most recent call last):
File "C:/Users/ROBOWALT/Music/Video/DevBot/dev.py", line 67, in
nlp = transformers.pipeline("conversational", model="microsoft/DialoGPT-medium")
File "C:\Users\ROBOWALT\AppData\Local\Programs\Python\Python39\lib\site-packages\transformers\pipelines_init_.py", line 454, in pipeline
framework, model = infer_framework_load_model(
File "C:\Users\ROBOWALT\AppData\Local\Programs\Python\Python39\lib\site-packages\transformers\pipelines\base.py", line 101, in infer_framework_load_model
raise RuntimeError(
RuntimeError: At least one of TensorFlow 2.0 or PyTorch should be installed. To install TensorFlow 2.0, read the instructions at https://www.tensorflow.org/install/ To install PyTorch, read the instructions at https://pytorch.org/.

Try installing Tensorflow with "pip install Tensorflow" or use pip3 if you are using Python3. Let me know if it works.

Closing the issue After no response from the user after almost 2 months. This has solved the issue for other people who reached out to me on LinkedIn and feel free to open another issue there.
LinkedIn Link : https://www.linkedin.com/in/arnab1408/


All files are added

All other files are added.

The work section header, "Recent works" text does not look like the Figma
template design as seen in the images below solved.
all cards in a gray color background container change into the same color
Figma template design color.
An email address at the button of this project has been removed.
I removed li from ("Languages", "Frameworks" and "Skills").
One of the [Live Demo Links] has been deleted.
On Sat, Feb 18, 2023 at 10:51 PM Robertson Arthur @.***>
wrote:

@.**** requested changes on this pull request.
STATUS: CHANGES REQUIRED ♻
Hi @asadmisrani https://github.com/asadmisrani ,
Good job so far! 👏👏👏
There are some issues that you still need to work on to go to the next
project but you are almost there! 😃
https://camo.githubusercontent.com/34482800e1b92cb79ddca06edb4051edc407cb190f896e1e949e596aa9073851/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f556461535559436c723932636a57706556782f67697068792e676966
Highlights
✅ No Linter error
✅ Correct use of GitHub flow
✅ Neat Commit messages
Required Changes ♻
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop
the approval of this PR. However, I strongly recommend you to take them
into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In .stylelintrc.json
https://github.com/asadmisrani/Portfoliofinishmobileversion.github.io/pull/1#discussion_r1111064249
:

@@ -0,0 +1,21 @@

+{

"extends": ["stylelint-config-standard"],

You have really done a great job on this project. But I notice that you
delete all previous review comments. I just invalidated your code and you
sent it back after deleting the pull request. This practice is frowned upon
at Microverse. The review process is like a story, the next reviewer
depends on the previous review comment to help the student make the project
perfect enough for approval.

The work section header, "Recent works" text does not look like the
Figma template design as seen in the images below: It should not have a
gray background. kindly fix this. Also, since you already have an h1
tag in the headline section, this text should not use an h1 tag again
because SEO reasons. Kindly change it to h3 or h4.

Figma Design Your work
[image: image]
https://user-images.githubusercontent.com/84156714/219879691-da285816-b17a-4bf0-87bd-e30a462471f9.png [image:
image]
https://user-images.githubusercontent.com/84156714/219879758-f164843e-6f1e-4dcb-b0fc-4d836a0d71ef.png
In .stylelintrc.json
https://github.com/asadmisrani/Portfoliofinishmobileversion.github.io/pull/1#discussion_r1111064691
:

@@ -0,0 +1,21 @@

+{

"extends": ["stylelint-config-standard"],

"plugins": ["stylelint-scss", "stylelint-csstree-validator"],

"rules": {

Please visit the Figma template and compare your project. Please
ensure the project cards has a white background or no background color.
Currently, you are arranging all cards in a gray color background
container, and this is not similar to what we have in the Figma template.
Kindly re-do this section.

Your project cards should be designed just the same way you have designed
the language section as shown below 👇🏾
[image: image]
https://user-images.githubusercontent.com/84156714/219880421-8aecd8fd-9e49-437e-ab48-9e27056c74f4.png
This is how your project cards should look like 👇🏾
[image: image]
https://user-images.githubusercontent.com/84156714/219880501-3f2d09fe-bf1b-4bad-99bd-61be12253752.png
In .stylelintrc.json
https://github.com/asadmisrani/Portfoliofinishmobileversion.github.io/pull/1#discussion_r1111065587
:

@@ -0,0 +1,21 @@

+{

"extends": ["stylelint-config-standard"],

"plugins": ["stylelint-scss", "stylelint-csstree-validator"],

"rules": {

 "at-rule-no-unknown": null,

The technology categories ("Languages", "Frameworks" and
"Skills") should be in a ul, each of them in a li. The technology in
each category(e.g., "JavasScript", "HTML" and "CSS") should also be in a
list ul and each of them a li. essentially they will be nested.

In README.md
https://github.com/asadmisrani/Portfoliofinishmobileversion.github.io/pull/1#discussion_r1111065976
:

@@ -42,7 +42,7 @@

🚀 Live Demo
-- Live Demo Link
+- Live Demo Link
(back to top)

Like I said when I invalidated your code earlier, Your README file
is incomplete. You arr expected to add all sections provided in the
template, except that the FAQ section is optional. A lot of sections are
not edited. Kindly spend some time editing this README to suit your project.
There is an email address at the button of this project. Please
remove it

I will advise you do not delete this pull request. fix this issues and
re-submit.
—
Reply to this email directly, view it on GitHub
https://github.com/asadmisrani/Portfoliofinishmobileversion.github.io/pull/1#pullrequestreview-1304619063,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYQGAKG3FJCBNTBS7UZZL53WYEDY5ANCNFSM6AAAAAAVAOS364
.
You are receiving this because you were mentioned.Message ID:
<asadmisrani/Portfoliofinishmobileversion.github.
@.***>


[Bug]: complexCamelCaseModels will break the routes

What happened?
I see a 404 error when nesting resources with LongCamelCaseNames.
How to reproduce the bug
For example I have a model named ProjectSpNature (with the resource named ProjectSpNatureResource) and the generated route as per artisan route:list is
admin/projects/{projectRecord?}/project-sp-natures/{project sp natureRecord?}/building-blocks/create
instead of
admin/projects/{projectRecord?}/project-sp-natures/{projectSpNatureRecord?}/building-blocks/create
This creates a 404 error probably because of the spaces inside the parameter
Package Version
1.0.0-alpha.5
PHP Version
8.2.12
Laravel Version
10.30.1
Which operating systems does with happen with?
macOS
Notes
I think the solution could be changing the helper function that gets the route parameter
from
if (! function_exists('Guava\Filament\NestedResources\get_model_route_parameter')) {
    function get_model_route_parameter(string | Model $model): string
    {
        return get_model_label(is_string($model) ? $model : $model::class) . 'Record';
    }
}

to
if (! function_exists('Guava\Filament\NestedResources\get_model_route_parameter')) {
    function get_model_route_parameter(string | Model $model): string
    {
        return Str::camel(get_model_label(is_string($model) ? $model : $model::class)) . 'Record';
    }
}

Hi, thanks a lot for the bug report! I'll try to work on a fix as soon as I can. You're also welcome to make a PR if you want.

@acepoblete Great catch! It's not by design, I didn't really know it did that until now. Are you actually interacting directly with these slugs in your app?
I will fix it in the next release.

I can confirm @niccolofavari 's report. My parent resource is named JobCampaign, which results in the route admin/job-campaigns/{job campaignRecord?}/child-resource/{record} and produces a 404.
I believe the root cause is using Filament's get_model_label helper in this package's get_model_route_parameter helper, which produces a space-separated version of the model class name. I assume that the Filament helper get_model_label is intended for UI/display labels, and not for route parameters. I'll look into possible fixes as well :-)

@acepoblete Great catch! It's not by design, I didn't really know it did that until now. Are you actually interacting directly with these slugs in your app?
I will fix it in the next release.

I have a custom tab component for navigating between child resources.  It's not very smart, so I have to manually generate the URLs for each tab.  I noticed that route parameters when trying to figure out what route names to use for the child resources.  I'll have a PR for this fix shortly.


Add sex attribute

Closes #41

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

26 of 26 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 96.471%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
164

Relevant Lines:
170

💛  - Coveralls


Update LICENSE to mention Nava

Ticket
n/a
Changes

Updates the LICENSE to mention Nava PBC on the copyright line.

Context for reviewers
I left the [yyyy] brackets there as a reminder that the year should be updated when the template is copied. But let me know if that doesn't seem right.
Testing
n/a

@bbemis017 sorry I forgot to read your PR description first.
I think we should include both the year and the org, because this license is for the template itself. The license file wouldn't be copied to project repos.


Coverage reporting to codecov.io

I use codecov.io for other projects, and it's really helpful to see how PRs change your test coverage (like this: https://github.com/ActivityWatch/aw-core/pull/94#issuecomment-667932464). We already have code coverage set up, it just isn't being reported.
@shanefontaine: Could you enable codecov.io on the repo? (I can add the CI config needed)
But now that I think about it: perhaps it'd be ideal to move the repo to a uniswap-python org, where the repo can have more than one owner, so I can do stuff like this myself.

perhaps it'd be ideal to move the repo to a uniswap-python org

I think that is the right call. The repo has been transferred to a new org. Please confirm that you are able to add coverage reporting and close this issue when it has been completed!

Nice, thanks!
Coverage reporting added in https://github.com/uniswap-python/uniswap-python/commit/f0719fd3cf0e47eb0ec941c1faaee9dd5037d8c4. Also added a badge to the README.
Results viewable here: https://app.codecov.io/gh/uniswap-python/uniswap-python


Set reuse address for TCP and UDP

Awesome work, merging soon

I think this was the wrong fix, but let's wait for user report.

reverted fixed in newer commit.


fix: sort pipx forge remote versions semantically

Seems pypi sorts releases lexically which can result in the wrong version being selected for latest in the pipx forge. Example
Noticed this when attempting to use pipx:magic-wormhole which would install v0.9.2 instead of v0.14.0.
Just like the last time I was in here, I'm not a rust person and just kinda fumbled my way through (and didn't write any tests!) so please destroy at will.
Previous behavior:
$ mise x pipx:magic-wormhole -- wormhole --version
creating virtual environment...
creating shared libraries...
upgrading shared libraries...
installing magic-wormhole from spec 'magic-wormhole==0.9.2'...
done! ✨ 🌟 ✨
mise<EMAIL_ADDRESS>✓ installed                                                                                magic-wormhole 0.9.2

New behavior:
$ cargo run x pipx:magic-wormhole -- wormhole --version
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.11s
     Running `/tmp/mise/target/debug/mise x 'pipx:magic-wormhole' -- wormhole --version`
creating virtual environment...
creating shared libraries...
upgrading shared libraries...
installing magic-wormhole from spec 'magic-wormhole==0.14.0'...
done! ✨ 🌟 ✨
mise<EMAIL_ADDRESS>✓ installed
magic-wormhole 0.14.0

... thank goodness for those e2e tests.
As mkdocs shows, assuming they're all semantic versions is a bad assumption. :
Next approach might be to add a version entry for latest based on what .info.version is set to from pypi.

Fixed by #2209


Only render avatar images that are fully loaded

To make the avatar loading experience smoother, avatars images should only be rendered once they are fully loaded.
This PR implements a change such that the background-image property is not set on the Avatar until the image has fully loaded. This prevents partially loaded images from rendering in the Avatar.
New hooks for onLoad and onError have been added so that consumers of the Avatar component can hook into these events for any custom logic.

Coverage remained the same at 100.0% when pulling 4d97ae66e56bd15595654596a83159ef13ff3809 on feature/avatar-events into f36f00db7ea7d72a472a9a7aadfcc8edd40108f2 on master.


feat: convert template to cookiecutter

Also need to move github scripts to template, even if they are to be removed.


0.0.36 on npm?

I noticed the package was bumped:
https://github.com/NativeScript/nativescript-angular/commit/9477a7656faa41cd58365001960bdf7f9068eb46
But I don't see 0.0.36 on npm yet?

This is sort of odd. https://www.npmjs.com/package/nativescript-angular says 0.0.35 but if I npm install --save natiescript-angular I get 0.0.36.

Hmm. That is strange. I'll try to update and proceed then. npmjs usually updates right away after a publish I have found so that is puzzling.


improve File cache async init

Proposed changes
Do load_cache_info_into_memory() asynchronously in a background thread in LRUFileCache::initialize().
When the cache is not ready, LRUFileCache::get_or_set() will return the FileBlock which state is SKIP_CACHE.

run buildall

run buildall

run buildall

run buildall


Mechanics of the Seek() function

Related to #652
I'm not sure if I'm understanding the Seek() function properly.
So a binary search searches an ordered list for a distinct value, right? So what the Seek() function should do is take a single byte slice as an input, perform a binary search on the contents, and return that entry. If it cannot locate the input key, then it should return a nil.
If it does do that, I think the documentation should be re-worded as how it's currently phrased is misleading. However, if it doesn't do that and instead, when it cannot find the input key it returns the next key in the database, the documentation is pretty accurate and I think that the Seek() function is not useful for my purpose.
In this case, could you recommend a method to perform a simple binary search, without the functionality of the seek function when it cannot find a key? Or at least a way to ascertain if, when the seek() function finds a key, if it's the correct one or if it's just grabbed the next one in the database.

Indeed Seek() will not return nil, unless that makes the cursor be after the last key of the bucket.
If your use-case is to search for an exact key, Bucket.Get() is what you want : it will return nil if that key isn't found.
If you want to search by prefix, then check the key you get from seek is correct, e.g.:
k, v := b.Seek([]byte("a.b.")
if !bytes.HasPrefix(k, []byte("a.b.")) {
...
}```

@vincent-petithory Cheers for the response. Does Bucket.Get() do a normal iteration or a binary search?

yes, its implementation uses seek().


CI for Node

Create Node.js workflows

Contains the compiled JavaScript
Initializes with two players
Starts the game with a random player
Sets the current player to be whoever it is not


Settings button shown to normal user if repo is empty

User A created a public repo AP;
User A did not add user B as a member;
user A did not push any commit to AP;
User B can see the settings button on the top right corner of the page.

Thanks your feedback!
Just to confirm that user B will get 404 if he clicks on the settings button?

Yes he will get a 404 page if he click on that button.

Thanks your info!

Please test on https://try.gogs.io/unknwon/bare again!

Close as fixed.


[PackageSyntax] Pt 2 - Formatting utilities + tests

Second part of the changes from https://github.com/apple/swift-package-manager/pull/3034, broken out for easier upstreaming.
Motivation:
This change builds on the PackageSyntax target setup in pt 1 by adding utilities for adding expressions to array literals while preserving formatting and comments. These will be used in following PRs to support the semantic manifest editing operations.
Modifications:
Adds PackageSyntax/Formatting.swift and the accompanying tests.
Result:
No user-facing changes

@swift-ci please smoke test


InternalError (see above for traceback): CUB segmented reduce errorinvalid device function

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): running training step from here
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10 64 bit
TensorFlow installed from (source or binary): installed using conda
TensorFlow version (use command below): b'unknown' 1.8.0
Python version: 3.6.2
Bazel version (if compiling from source): NA
GCC/Compiler version (if compiling from source): NA
CUDA/cuDNN version:  CUDA 9.0 cuDNN 7.1.4
GPU model and memory: name: GeForce GTX 650 Ti major: 3 minor: 0 memoryClockRate(GHz): 0.928
Exact command to reproduce: python style.py --style examples\poem.jpg --checkpoint-dir checkpoint

Describe the problem
Running a CNN training on fast style transfer, and using tensorflow-gpu. training crushed at moments/mean, is this a bug in tensorflow?
Source code / logs

Traceback (most recent call last):
File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Anaconda3_64\lib\site-packages\tensorflow\python\client\session.py", line 1322, in _do_call
return fn(*args)
File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Anaconda3_64\lib\site-packages\tensorflow\python\client\session.py", line 1307, in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Anaconda3_64\lib\site-packages\tensorflow\python\client\session.py", line 1409, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.InternalError: CUB segmented reduce errorinvalid device function
[[Node: moments/mean = Mean[T=DT_FLOAT, Tidx=DT_INT32, keep_dims=true, _device="/job:localhost/replica:0/task:0/device:GPU:0"](Conv2D_16, moments/mean-1-LayoutOptimizer)]]

The linked code runs on TensorFlow 0.11.0, and you are using 1.8.0. I would not expect consistency over a major version change like that. I would suggest finding a more recent version of the CNN you want to run, or checking out an older version of TensorFlow. Thanks.


Added get_required_extensions() API to GLSL compiler

As discussed in https://github.com/KhronosGroup/SPIRV-Cross/issues/2149

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Tibor Klajscek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Basic CLI for recording from server

Closes https://github.com/IRL2/nanover-protocol/issues/290

I have tested this script and it is working for me when recording both with the python and rust servers. The only issue I'm having is during playback with the python server, where the simulation_counter increments by two each time a playback sim is loaded. I'm putting it here in case it's relevant, but I'm not sure whether this is a recording or playback issue.
Notes: I am using nanover-server version #0.1.2763 (the latest version at time of writing).

A nicer interface:

I have tested this script and it is working for me when recording both with the python and rust servers. The only issue I'm having is during playback with the python server, where the simulation_counter increments by two each time a playback sim is loaded. I'm putting this issue here in case it's relevant, but I'm not sure whether this is a recording or playback issue.
Notes: I am using nanover-server version #0.1.2763 (the latest version at time of writing).

Let's consider this an issue with playback rather than recording (as you've said, playback works in the rust server, so the recording should be valid). I'll put up an issue

@Ragzouken, just tested using nanover-record via the command line.
Test protocol: start a NanoVer server, start the recording client with nanover-record --path "test-recording, run for a bit, then click Ctrl+C once to stop the recording, and a second time to stop the script.
I can start the script and stop the recording with Ctrl-C with no problems. However, when I press Ctrl+C again to stop the script, I get the below error and the recording files aren't created.
(nanover-dev) ..\nanover-protocol> nanover-record --path "test-recording" Connecting to localhost:38801. Recording from server to test-recording/recording-1-20241216-162315.traj and test-recording/recording-1-20241216-162315.state. Press Ctrl-C to stop. Done. Press Ctrl-C to quit or Return to begin recording again.Traceback (most recent call last):   File "<frozen runpy>", line 198, in _run_module_as_main   File "<frozen runpy>", line 88, in _run_code   File "\miniforge3\envs\nanover-dev\Scripts\nanover-record.exe\__main__.py", line 7, in <module> object address  : 000001C32744AF20 object refcount : 3 object type     : 00007FFAD720A3E0 object type name: EOFError object repr     : EOFError() lost sys.stderr
The other thing is that we need documentation to go with this client. The documentation that comes up with nanover-record --help is great, but it would also be good to put an example usage on this page in the docs, with instructions on getting help in the command line. Also, would it be possible to add an example usage into the docstrings?  E.g. like at the top of this recording script in the nanover-utils directory.

Here's a PR for basic documentation: https://github.com/IRL2/nanover-docs/pull/161


Add Algolia search

Some people like search; we can use Algolia for Open Source.

Upstream: https://github.com/riboseinc/jekyll-theme-open-project/issues/47


Arm64 runners don't support dind

Although there are arm64 images provided for summerwind/actions-runner-dind, when running  below config, docker daemon is observed not working.
apiVersion: actions.summerwind.dev/v1alpha1
kind: RunnerDeployment
metadata:
  name: self-hosted
spec:
  template:
    spec:
      securityContext:
        seLinuxOptions:
          level: "s0"
          role: "system_r"
          type: "super_t"
          user: "system_u"
      organization: demo
      nodeSelector:
        workload: ci
      tolerations:
        - key: ci
          operator: Exists
      resources:
        limits:
          cpu: "4.0"
          memory: "10Gi"
        requests:
          cpu: "2.0"
          memory: "8Gi"
      dockerdWithinRunnerContainer: true
      image: summerwind/actions-runner-dind
      serviceAccountName: ci
      workDir: /runner/worker
      volumeMounts:
        - mountPath: /runner/worker/
          name: self-hosted
      volumes:
        - name: self-hosted
          persistentVolumeClaim:
            claimName: self-hosted

---

turned out the selinux options are making this fail


load templated task example is not working

Kapacitor configuration:
[load]
  enabled = true
  dir = "/etc/kapacitor/load"

Configs from the example
/etc/kapacitor/load/templates/my_template.tick
dbrp "telegraf"."autogen"

var measurement string
var where_filter = lambda: TRUE
var groups = [*]
var field string
var warn lambda
var crit lambda
var window = 5m
var slack_channel = '#alerts-tests'

stream
    |from()
        .measurement(measurement)
        .where(where_filter)
        .groupBy(groups)
    |window()
        .period(window)
        .every(window)
    |mean(field)
    |alert()
         .warn(warn)
         .crit(crit)
         .slack()
         .channel(slack_channel)

/etc/kapacitor/load/tasks/my_templated_tas.tick  (by the way here is typo, it has to be my_templated_task.tick)
dbrps:
  - { db: "telegraf", rp: "autogen"}
template-id: my_template
vars:
  measurement:
   type: string
   value: cpu
  where_filter:
   type: lambda
   value: "\"cpu\" == 'cpu-total'"
  groups:
   type: list
   value:
       - type: string
         value: host
       - type: string
         value: dc
  field:
   type: string
   value : usage_idle
  warn:
   type: lambda
   value: "\"mean\" < 30.0"
  crit:
   type: lambda
   value: "\"mean\" < 10.0"
  window:
   type: duration
   value : 1m
  slack_channel:
   type: string
   value: "#alerts_testing"

System: Debian 9, Kapacitor 1.4.0
Debug steps:
ts=2018-01-22T11:38:34.894Z lvl=error msg="encountered error" service=run err="open server: failed to reload tasks/templates/handlers: failed to load tasks: failed to load file /etc/kapacitor/load/tasks/my_templated_tas.tick: failed to create task: invalid TICKscript: parser: unexpected unknown state, last char: ':' line 1 char 6 in \"dbrps:\". expected: \"number\",\"string\",\"duration\",\"identifier\",\"TRUE\",\"FALSE\",\"==\",\"(\",\"-\",\"!\""
If I remove  dbrps part from task I get
failed to create task: invalid TICKscript: parser: unexpected unknown state, last char: ':' line 1 char 12 in \"emplate-id: my_templ\". expected: \"number\",\"string\",\"duration\",\"identifier\",\"TRUE\",\"FALSE\",\"==\",\"(\",\"-\",\"!\""
Task creation with JSON like format
failed to create task: invalid TICKscript: parser: unexpected unknown state, last char: '{' line 1 char 1 in \"{\". expected: \"number\",\"string\",\"duration\",\"identifier\",\"TRUE\",\"FALSE\",\"==\",\"(\",\"-\",\"!\""
If I remove task, kapacitor starts successful and template is in template list. None-template task is loaded successful.
UPDATE
Defining task with kapacitor command works:
kapacitor define test-load1 -template lmd_template -vars test.json
{
    "measurement": {"type" : "string", "value" : "system" },
    "host": {"type": "list", "value": [{"type":"string", "value":"host"},{"type":"string", "value":"host.example.com"}]},
    "field": {"type" : "string", "value" : "load1" },
    "warn": {"type" : "lambda", "value" : "\"mean\" < 0.5" },
    "crit": {"type" : "lambda", "value" : "\"mean\" < 0.7" }
}

I'm encountering the same issue. Does anyone know how you are supposed to use templated tasks with the load directory?

I figured out how to get the example to work: the "my_templated_tas.tick" needs to use ".yaml" as the extension, not ".tick"


Strange behaviour with polymorphism

I am having a strange error with flow. I'm simply trying to have a function that accepts an array of objects with an amount property but I'm having errors when providing objects with more properties.
const sum = (items: Array<{amount: number}>) => {/* something */}

type Item = {
  amount: number,
  name: string
};

const list: Array<Item> = [];

sum(list);

This gives me the following errors:
10: const list: Array<Item> = [];
                      ^ property `name`. Property not found in
2: const sum = (items: Array<{amount: number}>) => {/* something */}
                             ^ object type

https://flow.org/try/#0FAYw9gdgzgLgBFArgWzgXjgCgJYwKbJQBccAggE7kCGAngDwDeVyYiEMJEKARnuQL4A+AJTpBcBgHoAVAjDI8MABbYIAczjTJ-YLpg0ADnjgBJfKgwNgcOM1btOPPgBprcCMzwlY5VWuD8ANy64NDwADbYsCQU1PRmBOIYANoAusHASMiYkbDCgUA
Is that expected behaviour?
The only solution I found to achieve my goal is the following, but it is not intuitive.
const sum = <T: {amount: number}>(items: Array<T>) => {/* something */}

type Item = {
  amount: number,
  name: string
};

const list: Array<Item> = [];

sum(list);

Closing the issue, reason explained at https://stackoverflow.com/questions/44155934/flowtype-array-of-object-type-does-not-allow-extra-properties/44159124#44159124


bug-fix: Support optional customize functions returning null case

Fixes: CLNP-2851
Changelogs

Fixed a bug where injecting an optional property with null value not rendering the expected default component

TODO:

[ ] src/modules/ChannelSettings/components/ChannelSettingsUI/index.tsx
[ ] src/modules/Channel/components/ChannelUI/index.tsx
[ ] src/modules/Channel/components/MessageList/index.tsx
[ ] src/modules/GroupChannel/components/Message/MessageView.tsx
[ ] src/modules/GroupChannel/components/MessageList/index.tsx
[ ] src/ui/MessageContent/index.tsx
[ ] src/ui/MessageItemMenu/index.tsx

LGTM
Is it intentional that deleteNullish is separated in some parts and not in others?

Yes, you can read more -> https://github.com/sendbird/sendbird-uikit-react/pull/1047#discussion_r1558840216


Build failure: rpyc

Steps To Reproduce
Steps to reproduce the behavior:
nix-shell -p python311Packages.rpyc
Build log
Sourcing python-remove-tests-dir-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing pypa-build-hook
Using pypaBuildPhase
Sourcing python-runtime-deps-check-hook
Using pythonRuntimeDepsCheckHook
Sourcing pypa-install-hook
Using pypaInstallPhase
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing python-namespaces-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing pytest-check-hook
Using pytestCheckPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/7xkpdlqbhhayn2z94z6l8azgg0jx3y04-source
source root is source
setting SOURCE_DATE_EPOCH to timestamp 315619200 of file source/tests/test_win32pipes.py
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: configurePhase
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
Running phase: buildPhase
Executing pypaBuildPhase
Creating a wheel...
* Getting build dependencies for wheel...
* Building wheel...
Successfully built rpyc-6.0.0-py3-none-any.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Running phase: pythonRuntimeDepsCheckHook
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for rpyc-6.0.0-py3-none-any.whl
Finished executing pythonRuntimeDepsCheck
@nix { "action": "setPhase", "phase": "installPhase" }
Running phase: installPhase
Executing pypaInstallPhase
Successfully installed rpyc-6.0.0-py3-none-any.whl
Finished executing pypaInstallPhase
@nix { "action": "setPhase", "phase": "pythonOutputDistPhase" }
Running phase: pythonOutputDistPhase
Executing pythonOutputDistPhase
Finished executing pythonOutputDistPhase
@nix { "action": "setPhase", "phase": "fixupPhase" }
Running phase: fixupPhase
shrinking RPATHs of ELF executables and libraries in /nix/store/svx5z8b51y0y9kcc0143mqf518wj3wfv-python3.11-rpyc-6.0.0
checking for references to /build/ in /nix/store/svx5z8b51y0y9kcc0143mqf518wj3wfv-python3.11-rpyc-6.0.0...
patching script interpreter paths in /nix/store/svx5z8b51y0y9kcc0143mqf518wj3wfv-python3.11-rpyc-6.0.0

Additional context
The log itself looks completely normal, however the build failed with the following errors:
============================= test session starts ==============================
platform linux -- Python 3.11.8, pytest-8.0.2, pluggy-1.4.0
rootdir: /build/source
collected 93 items / 2 errors / 16 deselected / 77 selected

==================================== ERRORS ====================================
___________________ ERROR collecting tests/test_affinity.py ____________________
ImportError while importing test module '/build/source/tests/test_affinity.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/nix/store/7wz6hm9i8wljz0hgwz1wqmn2zlbgavrq-python3-3.11.8/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_affinity.py:4: in <module>
    import support
E   ModuleNotFoundError: No module named 'support'
________________ ERROR collecting tests/test_service_pickle.py _________________
ImportError while importing test module '/build/source/tests/test_service_pickle.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/nix/store/7wz6hm9i8wljz0hgwz1wqmn2zlbgavrq-python3-3.11.8/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_service_pickle.py:7: in <module>
    import cfg_tests
E   ModuleNotFoundError: No module named 'cfg_tests'
=========================== short test summary info ============================
ERROR tests/test_affinity.py
ERROR tests/test_service_pickle.py
!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!
======================= 16 deselected, 2 errors in 0.39s =======================
/nix/store/c8dj731bkcdzhgrpawhc8qvdgls4xfjv-stdenv-linux/setup: line 1578: pop_var_context: head of shell_variables not a function context
error: builder for '/nix/store/bfsq4iq5k9wxmqhmywqvvxqg5f0vxic7-python3.11-rpyc-6.0.0.drv' failed with exit code 2;
       last 10 log lines:
       >     return _bootstrap._gcd_import(name[level:], package, level)
       > tests/test_service_pickle.py:7: in <module>
       >     import cfg_tests
       > E   ModuleNotFoundError: No module named 'cfg_tests'
       > =========================== short test summary info ============================
       > ERROR tests/test_affinity.py
       > ERROR tests/test_service_pickle.py
       > !!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!
       > ======================= 16 deselected, 2 errors in 0.39s =======================
       > /nix/store/c8dj731bkcdzhgrpawhc8qvdgls4xfjv-stdenv-linux/setup: line 1578: pop_var_context: head of shell_variables not a function context
       For full logs, run 'nix log /nix/store/bfsq4iq5k9wxmqhmywqvvxqg5f0vxic7-python3.11-rpyc-6.0.0.drv'.

Add any other context about the problem here.
Notify maintainers

Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

system: "x86_64-linux"
host os: Linux 6.1.82, NixOS, 23.11 (Tapir), 23.11.5511.f091af045dff
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.18.1
channels(root): "home-manager, nixos-23.11"
nixpkgs: /home/erina/.nix-defexpr/channels/nixpkgs

I'm really curious why the output of the nix log differed with what the build said.

I'm also encountering this. And I see that cfg_tests.py does exist...

May be relevant:
https://github.com/tomerfiliba-org/rpyc/issues/544#issuecomment-1962163513
so it may be some upstream issue with version 6.0.0

Addressed by https://github.com/NixOS/nixpkgs/pull/299691


Allow overriding PackageService methods

Allow overriding PackageService methods so that a new package service like MyPackageService can be inherited from PackageService instead of implementing IPackageService fully.

Thanks for opening this pull request! How’re you customizing PackageService? I’d like to better understand your scenario better before comitting to a solution.

@loic-sharma sure, for now I implement IPackageService something like below:
public class MyPackageService : IPackageService
{
    // implementation
}

Instead of implementing the entire interface, I would like to use it like below:
public class MyPackageService : PackageService
{
    public override async Task<IReadOnlyList<Package>> FindAsync(string id, bool includeUnlisted = false)
    {
        // My custom implementation
    }
}

Then, use MyPackageService like below:
services.AddTransient<IPackageService, MyPackageService>();

Could you instead do something like:
public class MyPackageService : IPackageService
{
    private readonly PackageService _defaultPackageService;

    public MyPackageService(PackageService defaultPackageService)
    {
        _defaultPackageService = defaultPackageService ?? throw new ArgumentNullException(nameof(defaultPackageService));
    }

    public Task<PackageAddResult> AddAsync(Package package) => _defaultPackageService.AddAsync(package);
    public Task<bool> Exists(string id, NuGetVersion version = null) => _defaultPackageService.Exists(id, version);

    // ...

    public override async Task<IReadOnlyList<Package>> FindAsync(string id, bool includeUnlisted = false)
    {
        // My custom implementation
    }
}

You'll need to tweak the dependency injection a little:
services.AddTransient<PackageService>();
services.AddTransient<IPackageService, MyPackageService>();

I acknowledge that this isn't as convenient as overriding methods, however, I'd prefer this over setting a precedent of virtual methods for extensibility. Let me know what you think!

@loic-sharma no problem, I will use it like that, thank you.

Please let me know if you run into any issues or have any additional feedback. Cheers!


haskellPackages.update-nix-fetchgit: dontCheck

Motivation for this change
Due to test failure on Hydra

https://github.com/expipiplus1/update-nix-fetchgit/issues/58
https://github.com/expipiplus1/update-nix-fetchgit/pull/60

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build haskellPackages.update-nix-fetchgit

@sorki Thanks for fixing this!
@sternenseemann Thanks for the review as well!
Looks fine on ofborg, so merging in!

I wish there was a way for Hydra to open a github issue on the source repo when building fails (opt-in of course)...

I think there is a way to receive emails about failed builds on hydra (or there was at least). Will need to research that I guess.

This was a topic of the last stream as well and @maralorn had an idea to poke maintainers listed for Haskell packages automatically when they break.
Hydra used to send emails but it managed to spam too many users with way too much emails at one point so it was disabled.


Update ssms-tricks.md

Original sentence: "You can filter objects to make finding a specific object easier in databases that have many objects."
Suggested sentence: "In databases that have many objects, you can use filtering to search for specific tables, views, etc."

@HMuhammad : Thanks for your contribution! The author, @MashaMSFT, has been notified to review your proposed change.

Thank you @HMuhammad


theme-addresses package (Work in progress)

Fixes https://github.com/Shopify/theme-scripts/issues/56
TO-DOs

[X] Clean up the country province selector function
[x] Change the options to just have callback hooks from country and province selectors

onCountryChange(provinceNodeElement)
onProvinceChange()

[x] package.json and rollup config
[x] README.md
All the test

[x] Core testing
[ ] Error handling

[ ] Lint setting
[ ] Shopify Doc

How to test
Follow setup for PR https://github.com/Shopify/starter-theme/pull/117
Running locally

After setup, run yarn link in theme-addresses
Before following setup for PR https://github.com/Shopify/starter-theme/pull/117, run yarn link "@shopify/theme-addresses"

@t-kelly So .. I was trying to refactor out all the stuff that's being used in shopify_common.js. Where should this go?
// add a callback to an event
Shopify.addListener = function(target, eventName, callback) {
  target.addEventListener ? target.addEventListener(eventName, callback, false) : target.attachEvent('on'+eventName, callback);
};```
We still have to have it to support IE 11 (the only browser that uses it that we need to make sure we support)

Oh wait nvm .. IE 11 is fully supported. MDN confused me.

Close PR in place of #66 - This PR has multiple commits with incorrect author email which made the CLA bot failing the test. I have no luck with git rebase so I have create a new branch with clean commits. Please refer to this PR for comments only


Implement slurm v6 wrapper module

Submission Checklist
Please take the following actions before submitting this pull request.

Fork your PR branch from the Toolkit "develop" branch (not main)
Test all changes with pre-commit in a local branch #
Confirm that "make tests" passes all tests
Add or modify unit tests to cover code changes
Ensure that unit test coverage remains above 80%
Update all applicable documentation
Follow Cloud HPC Toolkit Contribution guidelines #

Moving to different PR.


referece to the class Outlet

How can I create an outlet reference from IBanimatable object like a Button or textfield?

In identity inspector, change the class to AnimatableButton or AnimatableTextField, then connect an IBOutlet, the class will be AnimatableButton or AnimatableTextField, make sure you import IBAnimatable in your ViewController

@lopezquekk I close this issue now, please let me know if you have any questions.


[SPARK-30209][SQL][WEB-UI] Display stageId, attemptId and taskId for max metrics in Spark UI.

What changes were proposed in this pull request?

SPARK-30209 discusses about adding additional metrics such as stageId, attempId and taskId for max metrics. We have the data required to display in LiveStageMetrics. Need to capture and pass these metrics to display on the UI. To minimize memory used for variables, we are saving maximum of each metric id per stage. So per stage additional memory usage is (#metrics * 4 * sizeof(Long)).
Then max is calculated for each metric id among all stages which is passed in the stringValue method. Memory used is minimal. Ran the benchmark for runtime. Stage.Proc time has increased to around 1.5-2.5x but the Aggregate time has decreased.
Why are the changes needed?

These additional metrics stageId, attemptId and taskId could help in debugging the jobs quicker.  For a  given operator, it will be easy to identify the task which is taking maximum time to complete from the SQL tab itself.
Does this PR introduce any user-facing change?

Yes. stageId, attemptId and taskId is shown only for executor side metrics. For driver metrics, "(driver)" is displayed on UI.

"Driver"

How was this patch tested?

Manually tested, ran benchmark script for runtime.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Test build #115135 has started for PR 26843 at commit 4416ebc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19947/
Test PASSed.

Test build #115135 has finished for PR 26843 at commit 4416ebc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115135/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20077/
Test PASSed.

Test build #115269 has started for PR 26843 at commit 5ef089a.

Thanks @tgravescs for reviewing this code. I have addressed review comments and fixed the unit tests and the Suites passed locally.  Will wait for Test build results to check if there are any other issues. Please take another look.

Test this please

Test build #115269 has finished for PR 26843 at commit 5ef089a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115269/
Test FAILed.

Test build #115315 has started for PR 26843 at commit 96d27f0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20123/
Test PASSed.

Test build #115315 has finished for PR 26843 at commit 96d27f0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115315/
Test PASSed.

@nartal1 @tgravescs Sorry but I think this PR makes it hard to read the metrics.
For example, the metrics of exchange node in the PR description:

Any idea about improving the readability?
cc @liancheng @gatorsmile @cloud-fan

@tgravescs This is really hard to read, to be honest.

I'm definitely open to ideas on improving the readability. We could split it off into its own () after min,med,max for instance.
I don't agree with your complaint that we are exposing internal details, that is all the UI does.  Its for the user, spark dev, spark support people to be able to see the details and debug it as necessary.
The mapping of SQL operations to stages right now is terrible. This helps some as helps with the exec node to stage it ran in mapping, it will also help you debug issues where some task took much longer then others (max value). You can a lot more easily pinpoint that task.
Another idea we could look at would be adding a radio button to disable it by default and then have it show up. I'm not sure how hard that would be but something we could investigate.


Linux version soon? :)

First of all, thank you for developing this project greatly.
avatarify-python works well as a container but being able to run it quickly on Ubuntu 21.04 would be a blast.
As you're also on Linux, I'm sure you understand.
Have a great day!

I wanted to port it to Linux but I never had time to really get started with it. Code-wise I think the only major issue is that akvirtualcamera is only for Mac/Windows. There is akvcam for Linux, but it's in C so some adapter code would need to be written.
The other problem is that the CMake files are not written to be cross platform, and have a lot of hardcoded Windows stuff in them. Probably not that difficult for someone who's good with CMake to restructure the build files, but I only know the basics of it so I think it would take some time for me, and I find writing those kind of scripts extremely boring.
Unfortunately my current job doesn't leave me a lot of time for hobby programming, but perhaps someone else will step up with a PR or two :)

Thank you very much @JohanAR !
I'm not good enough for this job so I hope it too :)


QR Code Generator

Description
QR Code Generator allows the user  to enter the text or any URL and generates the QR Code .
Kindly assign this issue to me  @2devyank

@sanyayaa go ahead


Blog update and a few Kit text updates

Added Brad's blog and a few Kit fixes

I do not see any changes on this PR. Can you check if all the files are added

I think that @Jwilliamsr accidentally pushed directly to main when rebasing his fork :D. I can see the two blog posts that are in the commit history live in production: https://kitops.ml/blog.html
I think we can close this PR.

The new commit in this PR was added as part of https://github.com/jozu-ai/kitops/pull/264


Update scalactic to 3.2.4

Updates org.scalactic:scalactic from 3.2.3 to 3.2.4.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (3.2.3).
You might want to review and update them manually.
build.sbt

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalactic", artifactId = "scalactic" } ]

labels: test-library-update, semver-patch, old-version-remains

Superseded by #50.


refactor: rename localCurrencyToUsdSelector -> usdToLocalCurrencyRateSelector

Description
Previous name was a bit misleading.
Well, it's still misleading cause right now it's actually cUSD to local currency. But this is gonna change soon.
Test plan
Unit tests pass
Related issues

Fixes RET-830

Backwards compatibility
Yes

Just to clarify, previously we were using that value correctly:
To convert usd to local currency we were multiplying the usd value for the localCurrencyExchangeRate.
The localCurrencyToUsdSelector name was misleading because it seemed that we had to divide instead of multiply, right?


Support a windows client

The FDO protocol isn't a Linux specific protocol and there has been some level of interest in being able to use FDO to onboard Windows clients.
One usecase here would be to onboard a Window client, be able to use the generic user FSIM to create a user and use the management API FSIM to register the client to a management platform that can manage Windows clients.

I could see this being useful for an AAP use case as well, have the client enable WinRM and then the FSIM add the device to the AAP inventory facilitating for automatic onboarding into AAP and being ready to run automation against he host. Could even hit the provisioner callback endpoint from the host to initialize an automation job to run against itself from the AAP Control plane.


Introduce an indexation abortion function when indexing documents

Do you know if it's possible to abort during the extraction of word pairs (when the code inmilli/src/update/index_documents/extract/extract_word_pair_proximity_docids.rs is executed)? I know we split the dataset into chunks, so maybe we could abort after extracting the data from each chunk there?

bors merge


Feature/nav bar api changes

add support for the latest steroids nav bar api changes.
support for getNativeState() and getButtonById() and addEventListener()

will not be merged until further notice (required changes in iOS client were pulled back)


server: fix typo removeaccessvpn in VirtualRouterElement

Description
This PR fixes the typo removeaccessvpn which should be remoteaccessvpn

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[x] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

VirtualRouterElement can actually do with some extra clean up in addition to this.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 11790

[SF] Trillian test result (tid-11894)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45487 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10086-t11894-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

Can we do any other testing on this @weizhouapache , it seems to me this would be good enough.

Can we do any other testing on this @weizhouapache , it seems to me this would be good enough.

@DaanHoogland
I think no more testing is needed. it is just a typo
I cannot find it is being used somewhere


Updated Speech recognition SOTA result.

According to Speech SOTA, the new state of the art on Switchboard Hub5'00 is The CAPIO 2017 Conversational Speech Recognition System, at WER of 5.0%, published in Dec., 2017.

I have updated as you suggest. Thanks for the help.


Python 3.4 support not working

Hi @ozgur
I know this issue has been addresses previously in some other issue id. But I somehow am not able to make this work.
I am working on a virtualenvwrapper which is having python 3.4.2
When I run the http_api.py; I get the following output:
Traceback (most recent call last):
File "http_api.py", line 1, in
from linkedin import linkedin
File "/home/Saurabh/.virtualenvs/jobfinder/lib/python3.4/site-packages/linkedin/linkedin.py", line 294
except (requests.ConnectionError, requests.HTTPError), error:
^
SyntaxError: invalid syntax
Please fix this issue as soon as possible, in need urgently.
Thanks

Hi @ozgur
Can u please share your email or any contact detail, I just need to contact you because I'm stuck in a project and I really need this suport to start working. Hope to hear a reponse from you soon.

Hi there,
same issue for me. Is there a way to workaround according to you ?
Thanks and Regards,
Ludovic

I get the same problems too. I have to manually revise the code. Any better ways?

Hello All, I have moved this to https://github.com/marshallhumble/python-linkedin and am working on support, I am looking to support 3.4/3.5 only.  You can run the package from cloning this repo and running python setup.py install.
Please report issues on that repo and hopefully we can get this up and maintained again.

Thanks everyone!


cant use extension properly

first: thanks for adding the extension downlaoder! ive installed the image brwoser with it and got it into the UI but: i cant specify image directory (see screenshot)

what do i have to change-so it can get access to my images?

I didn't add the feature, AUTOMATIC1111 did.
The link to the image you gave is broken

where to input ''--administrator'' so i can use it?

in the last cell like this :
  if os.path.isfile(model):
    !python /content/gdrive/MyDrive/sd/stable-diffusion-webui/webui.py $share --disable-safe-unpickle --ckpt "$model" --administrator
  else:
    !python /content/gdrive/MyDrive/sd/stable-diffusion-webui/webui.py $share --disable-safe-unpickle --ckpt-dir "$model" --administrator
except:
   !python /content/gdrive/MyDrive/sd/stable-diffusion-webui/webui.py $share --disable-safe-unpickle --administrator

into: images_history.py ?

File "", line 72
if os.path.isfile(model):
^
IndentationError: unexpected indent
@TheLastBen

don't copy all the lines, just copy --administrator, to avoid indentation errors

fixed. thanks alot


Release v2.7.8+rev1

Build finished.

Build finished.

@resin-jenkins retest this please

Build finished.

Build finished.


nixos/libreddit: service hardening and test

Motivation for this change
This increases the isolation of Libreddit service. I have been running with those parameters for a week and I did not see any regression.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Fits CONTRIBUTING.md.

Could we remove cfg.redirect additionally?
This came up during the first PR.

Done

Any update?

I have submitted the hardening options to upstream: https://github.com/spikecodes/libreddit/pull/453

Proposed hardening options has been merged upstream. https://github.com/NixOS/nixpkgs/pull/173843 proposes to merge them into nixpkgs. I will rebase this pull request after https://github.com/NixOS/nixpkgs/pull/173843 merge.


hpa error occasionally

1, version
k8s : v1.13.3
metrics-server : 0.2.1
2, error detail
hpa occurs error occasionally(metrics not found). Here is apiserver logs when hap occurs error
E0418 11:43:15.661283       1 available_controller.go:316] v1beta1.metrics.k8s.io failed with: Operation cannot be fulfilled on apiservices.apiregistration.k8s.io "v1beta1.metrics.k8s.io": the object has been modified; please apply your changes to the latest version and try again

Thanks for filing the issue! This could be potentially related to https://github.com/kubernetes-incubator/metrics-server/issues/157. Do you see any additional api log entries which relate to that error?

@s-urbaniak Thanks, I think its same. but #157 is still open, it didnt work after i try.


[BUG/Help] <RuntimeError: Tensors must have same number of dimensions: got 4 and 2>

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
/srv/local/anaconda3/lib/python3.9/site-packages/transformers/tokenization_utils_base.py:717: UserWarning: Creating a tensor from a list of numpy.ndarrays is extremely slow. Please consider converting the list to a single numpy.ndarray with numpy.array() before converting to a tensor. (Triggered internally at ../torch/csrc/utils/tensor_new.cpp:245.)
tensor = as_tensor(value)
Traceback (most recent call last):
File "/home/lqcao/projects/ai/ChatGLM-6B/cli_demo.py", line 59, in
main()
File "/home/lqcao/projects/ai/ChatGLM-6B/cli_demo.py", line 44, in main
for response, history in model.stream_chat(tokenizer, query, history=history):
File "/srv/local/anaconda3/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 35, in generator_context
response = gen.send(None)
File "/home/lqcao/.cache/huggingface/modules/transformers_modules/THUDM/chatglm-6b-int4-qe/4ebf106fbcd496d7e3f93418f4ec1ca7dbed4456/modeling_chatglm.py", line 1163, in stream_chat
for outputs in self.stream_generate(**input_ids, **gen_kwargs):
File "/srv/local/anaconda3/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 35, in generator_context
response = gen.send(None)
File "/home/lqcao/.cache/huggingface/modules/transformers_modules/THUDM/chatglm-6b-int4-qe/4ebf106fbcd496d7e3f93418f4ec1ca7dbed4456/modeling_chatglm.py", line 1262, in stream_generate
model_kwargs = self._update_model_kwargs_for_generation(
File "/srv/local/anaconda3/lib/python3.9/site-packages/transformers/generation/utils.py", line 733, in _update_model_kwargs_for_generation
model_kwargs["attention_mask"] = torch.cat(
RuntimeError: Tensors must have same number of dimensions: got 4 and 2
Expected Behavior
No response
Steps To Reproduce

使用 THUDM/chatglm-6b-int4-qe
python cli_demo.py

Environment
- OS:
- Python:
- Transformers:
- PyTorch:
- CUDA Support (`python -c "import torch; print(torch.cuda.is_available())"`) :

Anything else?
No response

The code of THUDM/chatglm-6b-int4-qe was not synced with the main model. Fixed now.

RuntimeError: Tensors must have same number of dimensions: got 4 and 2
问题依然存在

Traceback (most recent call last):
  File "/home/sope/.local/lib/python3.9/site-packages/gradio/routes.py", line 393, in run_predict
    output = await app.get_blocks().process_api(
  File "/home/sope/.local/lib/python3.9/site-packages/gradio/blocks.py", line 1108, in process_api
    result = await self.call_function(
  File "/home/sope/.local/lib/python3.9/site-packages/gradio/blocks.py", line 929, in call_function
    prediction = await anyio.to_thread.run_sync(
  File "/home/sope/.local/lib/python3.9/site-packages/anyio/to_thread.py", line 31, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "/home/sope/.local/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 937, in run_sync_in_worker_thread
    return await future
  File "/home/sope/.local/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 867, in run
    result = context.run(func, *args)
  File "/home/sope/.local/lib/python3.9/site-packages/gradio/utils.py", line 490, in async_iteration
    return next(iterator)
  File "/home/sope/workspaces/ChatGLM-6B/web_demo.py", line 15, in predict
    for response, history in model.stream_chat(tokenizer, input, history, max_length=max_length, top_p=top_p,
  File "/home/sope/.local/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 35, in generator_context
    response = gen.send(None)
  File "/home/sope/.cache/huggingface/modules/transformers_modules/THUDM/chatglm-6b-int4/7458231b5ac7f19cc49496c35617a4ea66f0533e/modeling_chatglm.py", line 1163, in stream_chat
    for outputs in self.stream_generate(**input_ids, **gen_kwargs):
  File "/home/sope/.local/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 35, in generator_context
    response = gen.send(None)
  File "/home/sope/.cache/huggingface/modules/transformers_modules/THUDM/chatglm-6b-int4/7458231b5ac7f19cc49496c35617a4ea66f0533e/modeling_chatglm.py", line 1262, in stream_generate
    model_kwargs = self._update_model_kwargs_for_generation(
  File "/home/sope/.local/lib/python3.9/site-packages/transformers/generation/utils.py", line 733, in _update_model_kwargs_for_generation
    model_kwargs["attention_mask"] = torch.cat(
RuntimeError: Tensors must have same number of dimensions: got 4 and 2

问题依然存在

已经更新了，可以重新运行一下


Fix image export gaps in tiledrenderer

Hi @martingraham , I was going to try testing this and merge if possible, but there are a lot of commits and merges in your PR which would make the history a bit messy. Is it possible to clean it up a bit?
I think this would work and preserve your name on the relevant commit, maybe try it in a fresh checkout of your own repo just in case.
# Save your modified tiled-renderer.ts somewhere

# If you don't already have Alex's repo as a remote, add it like so:
git add remote arose git@github.com:arose/ngl.git

# Fetch Alex's master into a local branch
git fetch arose master:arose-master

# Checkout that branch
git checkout arose-master

# Create a new branch based on Alex's master
git checkout -b tiledrenderer

# Copy the updated version of src/viewer/tiled-renderer.ts

# Test it

# Commit it
git add src/viewer/tiled-renderer.ts
git commit -m "Message here"

# Push to your own github repo
git push origin

Then close this PR and open a fresh one with just the one commit...


MaxListenersExceededWarning: Possible EventEmitter memory leak detected. How to fix ?

It was working fine when has less than 4 jobs, but when put the 4th Job to works, the message above starts::

(node:114256) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 job ttl exceeded listeners added. Use emitter.setMaxListeners() to increase limit

I @wemersonrv You fix this issue ?

I don't know, i stop using adonis and its stuffs!


FFMPEG : misc + ffmpeg5 support

Enhanced list_muxers()
Added a convenient fail() function in the implementation details which helps reduce code
Moved the framerate option in demuxer::args to decoder_image_args. Makes more sense to have it there
Refactored demuxer::args::image_options to demuxer::args::args_image for consistency with decoder::args
Fixes #2752
ffmpeg5 support
ffmpeg6 support (no extra work required)

This all looks good.  Should I merge it or is there something about it that's not ready yet?  I just looked it all over though and aside from that one question about documenting what -1 means looks ready to merge.

This all looks good. Should I merge it or is there something about it that's not ready yet? I just looked it all over though and aside from that one question about documenting what -1 means looks ready to merge.

Just added ffmpeg5 support. Sorry, I'm going to squeeze this in.
I need to edit Github Actions to use ffmpeg5 on one of the jobs.

No worries. Let me know when you think it's ready 👍

Last thing to do is add jobs to Github Actions. I suggest:

Modify one of the existing jobs, install and link against ffmpeg 5
Add another job that installs a whole bunch of ffmpeg versions and just builds the ffmpeg specific examples. That will run a lot faster, we're not actually executing any code, but we're checking everything compiles without warnings.

Yeah I would just modify one of the jobs to link against the other version.  Easy and doesn't make the tests run longer.

I might actually have to read the documentations for Github Actions because this copy-paste business isn't working out for me.

Yeah it never works for me like the docs suggest. It's free though so 🤷♂

I don't understand what's going on. Looking at the output of ubuntu-latest-gcc-default-cmake-3-8-ffmpeg5, when it comes to linking dtest it comes up with a whole bunch of undefined reference to av_.... As if the libavformat.a etc libraries were empty. I run those exact scripts on 2 different PCs and it works. So no idea what's going on.

I don't understand what's going on. Looking at the output of ubuntu-latest-gcc-default-cmake-3-8-ffmpeg5, when it comes to linking dtest it comes up with a whole bunch of undefined reference to av_.... As if the libavformat.a etc libraries were empty. I run those exact scripts on 2 different PCs and it works. So no idea what's going on.

@arrufat Can you make sense of this?

Also, this happens a lot, the ubuntu-18_04-gcc-7 job gets cancelled immediately.

I just tried building on my machine (Arch, btw), which has both ffmpeg4 and ffmpeg6.
If I just run CMake normally, it uses ffmpeg6 and the webcam pose ex works well.
If I want to use ffmpeg4, I need to prepend the CMake command with:
PKG_CONFIG_PATH=/usr/lib/ffmpeg4.4/pkgconfig. Then it picks up ffmpeg4, and it also works.
It also seems a bit cryptic to me. I'll look into it later… It's time to sleep here.

I just tried building on my machine (Arch, btw), which has both ffmpeg4 and ffmpeg6. If I just run CMake normally, it uses ffmpeg6 and the webcam pose ex works well. If I want to use ffmpeg4, I need to prepend the CMake command with: PKG_CONFIG_PATH=/usr/lib/ffmpeg4.4/pkgconfig. Then it picks up ffmpeg4, and it also works. It also seems a bit cryptic to me. I'll look into it later… It's time to sleep here.

Tried it with cmake 3.8.0 on my machine and I get the error. So it has something to do with cmake 3.8.0 and pkg-config i think

Cmake 3.8.0 is a bit naff to be honest. I think 3.13 should be the required minimum.

Sweet, thanks for the PR :D


Edit sentence in README.md for clarity

Edit the first sentence in README.md for clarity.

I've accepted the pull request.


Data overview tool

Query by partner, by date, current, maybe others.

Now available as "health" in the management area


Improve error handling and logging for Retryable IO Errors

Search before asking

[X] I had searched in the issues and found no similar issues.

Motivation
In server.cc file, the code checks every minute if the storage is in a retryable IO error state and resumes the database if necessary.
 if (counter != 0 && counter % 600 == 0 && storage->IsDBInRetryableIOError()) {
    storage->GetDB()->Resume();
    LOG(INFO) << "[server] Schedule to resume DB after retryable IO error";
    storage->SetDBInRetryableIOError(false);
  }

Concerns:

The code resumes the database and sets the retryable IO error state to false without checking if the resume operation itself succeeded.
logs INFO message which may be ERROR or WARNING instead

Solution
example code to resolve this:
if (counter != 0 && counter % 600 == 0 && storage->IsDBInRetryableIOError()) {
  auto status = storage->GetDB()->Resume();
  if (status.ok()) {
    LOG(WARNING) << "[server] Successfully resumed DB after retryable IO error: " << status.ToString();
    storage->SetDBInRetryableIOError(false);
  } else {
    LOG(ERROR) << "[server] Failed to resume DB after retryable IO error: " << status.ToString();
    // Additional error handling, such as retrying or notifying the administrator
  }
}

Are you willing to submit a PR?

[X] I'm willing to submit a PR!

@VasuDevrani Looks good, you can go ahead to improve this.

@VasuDevrani Looks good, you can go ahead to improve this.

See, the code proposed as solution just prints ERROR in else block.
How about we add a set number of retry for resuming DB operation in case of failure, and if it still fails after retries, then we log a CRITICAL error finally.

I'm wondering if it's a good idea to do that. I prefer letting users determine whether to terminate themself instead of by default N times retry. @PragmaTwice @caipengbo @torwig What do you think?

Out-of curiousity, do we have ability to recovery from error if Resume() failed for one-times? Seems we can only recover from merely case like Compaction output error or flush error?

do we have ability to recovery from error if Resume() failed for one-times?

I guess there might be some cases where it needs to be done externally for the Resume() to succeed.

Thats a good point, so we should let user decide what to do during this case...

@VasuDevrani As discussed above, improving the logging message is good, but don't expect to escalate the FATAL error after N time tries. What do you think?

@VasuDevrani As discussed above, improving the logging message is good, but don't expect to escalate the FATAL error after N time tries. What do you think?

Yeah I've considered above conversation. I'm learning a bit more about Kvrocks, its internals. will update here with my thoughts after a while. Thanks for following up.

@VasuDevrani Cool, don't hesitate to raise if you have any ideas.

I agree with just improving the logging message for now. (should i make continue with a PR?)

Sure, you can continue improving the logging message.

I agree with just improving the logging message for now. (should i make continue with a PR?)

Yes, RESUME is not a high priority.


GUI: cycle through different decoding methods for bytes

Problems
bytes are currently displayed as base64-encoded strings, and that's really annoying when what you need is the HEX representation (like addresses, and all).
Solution
I want to hit f, and cycle through the different decoding methods for bytes, and just redraw the outputView and decode those bytes in hex, unicode strings, base64, .
I'm unsure if that's easily done by the current Go libraries that do the decoding.. but it would be ideal.

After hours spent trying to figure out a way to make it work,
I did:
This: https://github.com/streamingfast/protoreflect/commit/9691b6ec99b1cea2f0baca63f8adf997751eab30
and called the dynamic.SetDefaultBytesRepresentation() on key 'f', it took only a few minutes.
I will call it a day, then!
created an issue here just in case: https://github.com/jhump/protoreflect/issues/557
but I don't think it will go upstreams on this one or the google protobuf repo, because of this: https://github.com/golang/protobuf/issues/1030

Closed with https://github.com/streamingfast/substreams/commit/cf54aae9184e37a443264bbabd8edb5f179e6feb


Conflicts with mathematica

The .m suffix is used by both MATLAB and mathematica.
If both are installed in VSCODE, conflicts may occur.
The file is incorrectly marked as mathemateca, and MATLAB cannot provide syntax checking and suggestions for it.

Thank you for reporting this! I don't believe there is much we can do to force MATLAB to be the dominant language for .m files since there are a number of languages which use this extension (Objective C being another).
However, you should be able to set up your preferences to always associate .m files with MATLAB using one of the following methods:

In the VS Code Settings, search for "files.associations". Add an item to the setting's table with Item = *.m and Value = matlab
In a M file, execute the "Change Language Mode" command. In the menu that appears, select "Configure File Association for '.m'...", and then choose MATLAB

This works, thanks for your help!


Replicators should have independent cookie storage

This is a parity feature with iOS. This is under assumption that getting replications with exact same parameters returns the same (internal) replicator object.
Issue:
https://github.com/couchbase/couchbase-lite-ios/issues/543
PR:
https://github.com/couchbase/couchbase-lite-ios/pull/609

@pasin  is this fix available in 1.2? or as hot fix in 1.2+?

Hi @NitzDKoder,
This could be in 1.3 release. I believe this will not be ready by next hot fix release.

@hideki any update on this fix?is it available?how complex is this? will try to contribute if you me the design details..

@NitzDKoder,
This ticket is still in the backlog queue. We have planed to implement by 1.3 release.
If you could implement this feature, easiest way is to port from CBL iOS.
Thanks,
hideki

Hi @NitzDKoder,
We move to OkHttp from HttpClient. CookieStore is tied with Http client library. So I recommend you to wait for a while.

For Cookie storage, needs to use java.net.CookieManager? Instead of using OkHttp CookieJar
http://stackoverflow.com/questions/24263921/how-to-implement-cookie-handling-on-android-using-okhttp

@hideki the above change is part of this?
https://github.com/couchbase/couchbase-lite-java-core/issues/708#issuecomment-222848657
pls confirm..

Independent cookie storage is not implemented yet.

@hideki is it not possible in 1.3 release?

@NitzDKoder, From current schedule, I can not implement this during 1.3 timeline. Sorry.
And also, I need to double check the spec with other platforms to be consistent. CBL iOS switch to cookie storage per database. <- I need to verify.


Launch Multiple Windows on Different Desktops

When launching VS code from a new virtual desktop on Windows, you are forced to the virtual desktop that has an active instance of VS code.
I expect that it would render a new window for VS code in the new virtual desktop to let me have different projects open at the same time.

It seems to work the way this issue requests now - but I'd actually like it to work the way it used to (as I have described in #58978) - is there a way to change it back with a setting?


Empty Array [] won't pass to custom validator

Validator.register('fail_array', function(value, requirement, attribute) {
    return false;
}, ':attribute Failed');
var fields = {attr: []}
var rules = {attr: 'fail_array'}
new Validator(fields, rules);

This validation will won't fail.
There is use case that I want to check an array should include a value, empty array should fail as well.

It's not clear what your trying to achieve with your fail_array rule but you need to use the array rule.  Check out the tests for array-based stuff:
https://github.com/skaterdav85/validatorjs/blob/e0a41171218486adcdba06fbb6910e902ba893c2/spec/array.js
https://github.com/skaterdav85/validatorjs/blob/e0a41171218486adcdba06fbb6910e902ba893c2/spec/require-rule.js#L72

You probably want your rules as required|array|min:1 - no need for custom validation. That will check to make sure there is an array in the input and it's not empty.

No, it is not required.
I have to have a check that every item in array is number, but the field is not required.
For example, if input is "", I don't want to check it.
But if it is an array even is [], I want to check it.(it should fail)

var Validator = require('./src/validator');

var validator = new Validator({ users: [] }, { users: 'array|min:1' });
console.log(validator.passes()); // true

In Laravel the above fails the validation rule, this seems like a bug.

any luck here ?

required_without not working for array only working with strings


Create a default privacy page on the site

We should have a default page on the main site/governance info that explains the fact that Jupyter doesn't collect personal information directly, and any other applicable policies.
This page should be linked to in the discourse privacy page as well as the Discourse TOS one.

The JupyterLab specific privacy page could be incorporated or linked to from this site.


Failed to reveal type in Temporal Dead Zone.

This is a:

[x] Question

Which concerns:

[x] flow-runtime

What is the current behaviour?
The message is popping in the console when my app starts. It's probably not an error as app seems to be working, but I am curious if it's normal.

you are possibly doing something like this:
import type {Foo} from 'somelib';

And Foo can't be resolved, i.e. it's undefined. This can happen if you're using flow typed definitions which will work with flow but not always with flow-runtime. I'd like to improve the error message because it's hard to tell exactly which type is causing the problem.

Error message should now indicate the type causing the problem, released in 0.9.1

So I have updated to 0.10.0 now and now I am just getting the fallback message "Failed to reveal unknown type in Temporal Dead Zone". Any hints how to hunt these down?

Ok, I got it. Apparently there is a problem using export extensions. I like the idea of having every reusable type in a separate file in a folder. Then I like to add index.js which gathers them all together and exports.
export type { Billing } from './Billing'
export type { ChargeStatus } from './ChargeStatus'
export type { Cuid } from './Cuid'
export type { RequestContext } from './RequestContext'
export type { Shop, PublicShop, PrivateShop } from './Shop'
export type { Transaction } from './Transaction'

Doing it like this is failing with those message. Transforming to separate import and export works correctly. Wondering if it's actual issue of the transform-export-extensions plugin.

I understand that this issue might appear when Importing library flow typed definitions (e.g. type $Request from express).
Is there a way around this? Any of following:

Is there a way how to suppress errors related to ./flow-typed/npm folder?
What is actually wrong with the flow typed definition? Is there a way how this can be fixed by changing the definition script?

For scenarios where you're importing types from libdefs, the best answer is to use flow-runtime-cli to extract those types into another file:
flow-runtime-cli generate ./src > ./src/typedefs.js

then in your entry point:
import './typedefs';

@phpnode I tried using your solution, but all I ended up getting was the same error in the command line instead of the browser console...
I'm also not doing any weird import-reexport stuff, so I don't know what the deal is. It seems like just importing any type at all causes this problem.

Here's my import:
import type { QuerySpec, InferenceParameterSpec, Inference, KBContentTestConstraints } from 'lib/js/types/Queries';

Here's Queries.js:
export type InferenceParameterSpec = InferenceParameterSpecBoolean |
                                      InferenceParameterSpecNumber |
                                      InferenceParameterSpecChoice

type InferenceParameterSpecBase = {|
  foo: string,
  keyName: string,
  label: string,
  debugParam: boolean,
  dynamic: boolean,
  type: 'boolean'|'number'|'choice',
  inferenceDefault: string|boolean,
  browserDefault?: string|boolean,
  hint: string,
  section?: string,
|}

export type InferenceParameterSpecBoolean = {
  ...InferenceParameterSpecBase,

  type: 'boolean'
}

export type InferenceParameterSpecNumber = {
  ...InferenceParameterSpecBase,

  type: 'number',
  unboundedToken?: Array<any>|string,
  numberConstraints: Array<{
    min?: number,
    max?: number,
    integerOnly?: bool
  }>
}

export type InferenceParameterSpecChoice = {
  ...InferenceParameterSpecBase,

  type: 'choice',
  options: Array<{
    "label": "string",
    "value": "string"
  }>
}

So I am using a union type and a spread, but I haven't seen anybody mention either of those as being part of the problem. Honestly this makes flow-runtime useless for me until it's figured out, as imported types make up ~80% of the things I want to check at runtime.

Update: it turned out I didn't have // @flow-runtime enable on my separate type files themselves


Using log::trace instead of println

Bevy already includes a reference to the log crate, so anyone using bevy would already have it set up.
Switching from println() to log::trace() helps those that are not using the bevy logger and are filtering log outputs.

This is a great suggestion, thanks.
Instead of using an external dependency, can we make use of Bevy's LogDiagnosticsPlugin?

This is a great suggestion, thanks.
Instead of using an external dependency, can we make use of Bevy's LogDiagnosticsPlugin?

Hey @halzy, any thoughts on my comment?

Hey @halzy, any thoughts on my comment?

Hello, apologies for the delay. LogDiagnosticsPlugin doesn't seem to expose the log::* functions which are needed.

Hello, apologies for the delay. LogDiagnosticsPlugin doesn't seem to expose the log::* functions which are needed.

I asked around in the Bevy discord, and it turns out trace! is available as part of the bevy prelude import. You can remove the change to cargo.toml, and change log::trace!() to just trace!().

I asked around in the Bevy discord, and it turns out trace! is available as part of the bevy prelude import. You can remove the change to cargo.toml, and change log::trace!() to just trace!().

@halzy it looks like bevy/master is now using these too: https://github.com/bevyengine/bevy/blob/master/examples/app/logs.rs
// here is how you write new logs at each "log level" (in "least important" to "most important" order)
trace!("very noisy");
debug!("helpful for debugging");
info!("helpful information that is worth printing by default");
warn!("something bad happened that isn't a failure, but thats worth calling out");
error!("something failed");

I would strongly prefer to use this method to mirror bevy best practices. Does this seem to fit your needs? This repo has changed significantly over the last week or two, I am happy to make these changes myself if you don't have the time.

@halzy it looks like bevy/master is now using these too: https://github.com/bevyengine/bevy/blob/master/examples/app/logs.rs
// here is how you write new logs at each "log level" (in "least important" to "most important" order)
trace!("very noisy");
debug!("helpful for debugging");
info!("helpful information that is worth printing by default");
warn!("something bad happened that isn't a failure, but thats worth calling out");
error!("something failed");

I would strongly prefer to use this method to mirror bevy best practices. Does this seem to fit your needs? This repo has changed significantly over the last week or two, I am happy to make these changes myself if you don't have the time.

I'm going to go ahead and close the PR. The repo seems to have changed quite a bit and I've been heads down at work. Apologies for not seeing these comments sooner. Thank you for all you've done!

I'm going to go ahead and close the PR. The repo seems to have changed quite a bit and I've been heads down at work. Apologies for not seeing these comments sooner. Thank you for all you've done!

No worries! Thanks for bringing this to my attention. 🙂

No worries! Thanks for bringing this to my attention. 🙂


Double click in blank space should take the user one level up.

Is your feature request related to a problem? Please describe.
Not a problem, actually. It's only that I come from solutions like Clover and ExplorerMax. In these tools, the user can go Up one level when double-clicks in the blank space. Not really a big deal, but I kinda miss it using Files. Thought it would be a nice touch to add that function.
Describe the solution you'd like
As easy as that. When the user double clicks any blank space in the file viewer, he should be taken up one level in folder structure.

Merging with #2355

Merging with #2355


Create base custom module to be used as a starter to jumpstart development of crankshaft compatible custom modules

Basic jist, create a super bare bones custom module, based on any ideas from #40 it can be updated later as we come up with more best practices or ideas.

We'll expand on it as we go.
To do this someone could create the custom module in the design manager and use FTP to download it into the /modules folder of crankshaft.

created basic module here #70
inserted rich text for now.  obviously, this is skeletal and can be updated

Closing because #70 resolved this. Good work Dennis!
We'll expand on it over time. it's good to have something in there as good start.


Docs: Add instructions about build_meta wrappers as alternative to dynamic setup_requires

Summary of changes
Added instructions about wrapping setuptools.build_meta for customising the backend.
This is useful for dynamically specifying build requirements, according to PEP 517.
I believe this should be enough to close #2854.
Moreover by looking at the issues, I also have the impression that #1698 is already covered and could be closed.
Pull Request Checklist

[ ] Changes have tests
[x] News fragment added in changelog.d/.
(See documentation for details)

Hi @jaraco thanks for the comments and review.
I understand the hesitation here, ideally everything should be done declaratively, but there are some complicated use cases that might requiring wrapping the backend (e.g. packages that require a heavy dependency for compiling a wheel, but not for the sdist).

Of course, this change doesn't give selectability between dependencies for sdist and binary builds, that I'd like to support. For that, I'd like to provide build_requires or similar, with support for static builds and dynamic ones.

A positive side of simply relying on PEP517 is that it avoids growing (even more) complexity on setuptools and the associated maintenance cost. (e.g. the selectability you mention, in theory is already supported - as documented in this PR - with no implementation needed).

I'm also uneasy exposing the internal API of the backend.

I am not sure if I understood this comment. I think all the functions I used in the example are specified by the PEPs (517/518), which makes them automatically public right? There would be no need of exposing internal API, everything can be done by just following the standards.

Since the alternative is to let it linger, perhaps for a long time, I'm going to go ahead and accept the change, but I'm going to suggest we make the support "provisional".

Please feel free to accept or close the PR as it makes sense for setuptools long-term vision. Personally, I think that this approach is a simple consequence of the standards, so marking it as provisional feels a bit weird (in theory this approach should be a very stable and sound unless there is a change in the standards), but I appreciate that might want to provide a better way in the future.

Regarding the tradeoff between the cost of implementing/maintaining a setuptools-specific solution and the easiness of use:
Isn't it fair to assume that if a project reaches a point that it needs to separate build dependencies for sdist and whell, or to delay their installation, writing a very thin backend wrapper is straight forward?
Are these needs likely/recurrent enough to justify adding complexity to setuptools?

All good points. Let's proceed.

Regarding the tradeoff between the cost of implementing/maintaining a setuptools-specific solution and the easiness of use:
Isn't it fair to assume that if a project reaches a point that it needs to separate build dependencies for sdist and whell, or to delay their installation, writing a very thin backend wrapper is straight forward?

IMO not very fair at all. It requires:

updating MANIFEST.in
creating a build backend
adding confusing indirection to pyproject.toml
duplicating most of the same logic in setup.py to conditionally use the result

I could edit a single file, or I could edit 4 of them. Wouldn't it make so much more sense to have a single straightforward way to do this?
Some of these requirements aren't even obvious. The merged documentation has an "IMPORTANT" to remind you of this but I don't think it's safe to assume everyone will realize this anyway.

Are these needs likely/recurrent enough to justify adding complexity to setuptools?

Why do build backends such as setuptools exist if not to automate away the pointless busywork?

Why do build backends such as setuptools exist if not to automate away the pointless busywork?

I agree with this sentiment. Would you be willing to write up a new issue summarizing the concern and possibly laying out a proposed solution (or solutions)?


Merge C# SDK into Unity SDK

For context here, as Zeke and I were looking through the code of the CSharp SDK, we realized that it included references to Unity which were IF DEF'd out. The original idea was to have a pure CSharp SDK and a separate Unity SDK package which included or referenced the CSharp SDK, but what we have now is basically just two repos with the same code. Until and unless we find that we actually need a CSharp SDK, I would like to simplify by merging these two repositories and if necessary no longer publishing the CSharp SDK as a Nuget package. Right now it causes quite bit of confusion and upkeep to keep everything in sync.
If someone complains about the missing Nuget package, then we can reconsider publishing a CSharp SDK.
From a business standpoint, almost all of our users are going to be using SpacetimeDB from CSharp via Unity.

Yeah the code is the same, just with ifdefs (I think always was?).
The Unity repo has a bunch of meta files that are only used by Unity and I think separate repos was a way to split those out, so one is just a Git repo for Unity package manager and another is the actual maintainable source.
Last time we talked with @jdetter about this stuff, he suggested we might just disable PRs on the Unity repo to make this clearer.
Note that Unity repo also needs to have some precompiled DLLs for dependencies - something that would certainly be inconvenient to hold in the actual source code repo.

We've also had several issues arise when we make changes to "only" the C# SDK without integrating + testing them in the Unity SDK

Yes, I had some ideas around automating it, but that's still different than just merging repos.

I think I'm missing something - why would this be more inconvenient to maintain in one repo vs the other?

The thing is that those DLLs are not / should not part of the source at all. In regular C# project they're just declared as csproj dependencies, and only for Unity they need to be pulled from NuGet and published as binary assets.
Basically, it's a red herring to think of Unity SDK repo as regular repo altogether; it only exists because Unity doesn't have proper package manager for 3rd-party authors and encourages them to point to Git instead. That is, it's just a store for built binary assets + couple of script files, rather than something that should be maintained by hand separately from C# source.

Closing in favor of https://github.com/clockworklabs/spacetimedb-csharp-sdk/issues/114


Update socials

: None of the socials icons redirect anywhere

true though. It's because the social media handles are currently unavailable. We'll look into it asap.


Upgrade to Agones 1.6.0

This includes changing Terraform to point to the 1.6.0 Terraform scripts, as well as installing cert-manager with the Agones cluster
details.
This also includes both the terraform and gcloud configurations for the fleet, so that users can see the difference.

@chrisst, @pooneh-m do you have a moment to take a look and review?


Add JSPM (package manager) compatibility

This is along the same lines as https://github.com/DataTables/DataTables/pull/485 :)

Thanks - I'm not going to pull this in just yet and I need to make a proper plan for the various package managers for all of my software which I hope to make time to do soon.