dsa: Add e2e tests

Check if plugin announces DSA resources properly

Also, prepare with changes required from #985 (i.e., pod security admission)

Check if plugin announces DSA resources properly

Also, prepare with changes required from #985 (i.e., pod security admission)

And add running test workload.

@bart0sh

Here we should at least check if DSA resource(s) are available on the node.

This is checked now, the demo scheduling depends on the DSA resources.
@mythi

Also, [...] (i.e., pod security admission

Done
@bart0sh @mythi
Updated, take a look please

Codecov Report

Merging #992 (ff505a1) into main (5ebd0d3) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head ff505a1 differs from pull request most recent head 77440c4. Consider uploading reports for the commit 77440c4 to get more accurate results

@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   53.02%   53.02%
=======================================
  Files          40       40
  Lines        4351     4351
=======================================
  Hits         2307     2307
  Misses       1917     1917
  Partials      127      127

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bart0sh @mythi
Changes as discussed, please take a look:

Added idxd reset patch to the dsa demo
Added an overlay for the dsa demo for the bmetal environment

note: dsa-accel-config-demo is not yet built by CI because the job gets cancelled early.

/lgtm
@ozhuraki can we add .github/workflows/e2e-dsa.yml to this PR to see if dsa test passes?

@mythi @bart0sh
Changes, please take a look:

Dropped privileged for the demo
Dropped customization overlay for bmetal CI
Added a log output for the demo
Refined idxd-reset.patch (needed for kernels 5.17.x)
Extended the demo coverage

@ozhuraki can we add .github/workflows/e2e-dsa.yml to this PR to see if dsa test passes?

I asked to keep that separate so that the two commits are split.

@mythi how can we see if the DSA CI job working then?

@mythi how can we see if the DSA CI job working then?

let's then cherry-pick the commit from #1026 and have two commits here. Normally the e2e test case development (e.g. this PR) has been independent from setting up the CI (#1026) but this time it's a rather special case.

Changes:

Added a CI workflow for e2e DSA


Could you include the bytecode source?

Thanks for making this tool, but I'd like to see the java source for the bytecode with compilation instructions so I can confirm what the binary does.

Hi @jpwarren00,
The payload is obtained from:
https://techblog.mediaservice.net/2017/09/detection-payload-for-the-new-struts-rest-vulnerability-cve-2017-9805/
as referenced in:
https://github.com/mazen160/struts-pwn_CVE-2017-9805/blob/master/struts-pwn.py#L9
The author used ysoserial to generate the payload
https://github.com/frohoff/ysoserial

Thanks! @mazen160

You welcome! :)


Address minor Black issues

Fixes a couple of very minor docstring nits raised by an updated version
of Black.

Coverage remained the same at 54.336% when pulling 60cb988d8aaf5908f82b5b7bd6b4c0f8ec50180a on pwt:black_update_formatting_changes into db484181176a87f219af62e6031198b026a6eea1 on SoCo:master.


Add negative binomial distribution

I recently ran into the need. Apparently I'm not the only one:
http://ircbrowse.net/browse/haskell-beginners?id=184140&timestamp=1420085839#t1420085839

2015-01-01     Maddeningly, the statistics package on Hackage doesn't do negative binomial. Absolutely everything but, it seems.

I don't have to time to add it so I'm marking this as help needed. So pull requests are welcome I guess.

Actually, sometime last year I'm pretty sure I expanded my copy of the package with negative binomial, but never created a pull request, as I did not write tests, if I remember correctly. Might look into it.

@szabi That would be great!

Ok, I looked it up.
Back then I added the

discrete uniform distribution [finished] and the
convolution of it (sum of iid discrete uniforms) [might not be finished code, have to check in detail]

and I looked into the

negative binomial.

I did not add negative binomial yet, because there is a huge number of alternative parametrizations and no "industry standard" parametrization of the distribution, so I felt a broader discussion would be necessary, which parametrization to use.

Could you then create pull request for discrete uniform distribution?

It was never finished in a "production quality" sense, so I'll probably have to at least check, maybe even sanitize it somewhat. I'll try to find time and create a pull request, sometime the coming weeks.
Which would be the best place to check out and discuss the  package user group's preferences wrt. parametrization style for the NBD?

There's no hurry.
I think this issue is right place to discuss NBD.

Hi @szabi is there any interest remaining in adding the negative binomial?
Regarding the alternative parameterisations, can I put a vote in for the default in R. Even though this uses different parameters from the ones stated on Wikipedia, whatever R has converged on is probably as good a default as you're going to get and then there is a nice reference. Although, this could be a bit problematic if the rest of the distributions don't match up with the R versions.

@aezarebski no, sorry, I moved on.


Remove case-sensitivity on vp queries

core ValencerUnits middleware needs to be refactored: we now use FE id so there is leftover unneeded computation on token

Fixed with #54


Post release automated changes for keyvault releases

Post release automated changes for azure-keyvault-keys

API change check
API changes are not detected in this pull request.


Updated .travis.yml.

r? @inetic
(maidsafe_highfive has picked a reviewer for you, use r? to override)


Use the slsa-verifier tool as a Go dependencies instead of building the binary separately

Description/Requirements
At the moment, Macaron is using slsa-verifier to verify the content of SLSA provenances. We uses it directly out of the box, therefore, it is built from source to generate a binary which will then be invoked by Macaron. For example, this is the step where we prepare the slsa-verifier binary Makefile.
This works fine, however, we are doing an extra step to generate the binary from source (as compare to using Go to build the whole Go module automatically.) and the version of slsa-verifier is hard-coded not in the conventional go.mod. This would make it very difficult to maintain and update automatically by Dependabot.
Solution
We could address the above issue by writing a simple wrapper using slsa-verifier as a third-party dependency Go library.
In terms of licensing, we won't have any issue as slsa-verifier has been approved prior to open-sourcing.

@behnazh-w Please let me know if this sounds good to you.

@behnazh-w Please let me know if this sounds good to you.

Thanks, sounds good to me.

After having a closer look at this issue, I notices that we could not write a wrapper to directly use the slsa-verifier CLI program because it is a program (specified by main.go) but not an importable Go package. We could not import main.go directly (https://stackoverflow.com/questions/44420826/access-main-package-from-other-package).
To do it properly, our wrapper must need to extend the package here with our implementation of how to handle the parameters. However, it does not make sense as we are not extending the CLI tool or the slsa-verifier package. In additions, we might want to switch to using their remote API in the future. It won't give us any significant benefit atm. I will leave this issue open to future visit.

I will close this issue because it won't be fixed. And we have a different design in #3 .


When selecting a file from the file tree or bufferlist components, allow the user to select a window instead of just choosing the most recent window

with nvim-tree when you select a file, it uses the statusline/winbar to set a label (A/B/C etc) on each window, and pressing the key corresponding to each window opens the file in that window.
It would be cool to do something similar with nvim-ide

TBH, instead of re-implementing all the features ppl miss from nvim-tree, I was really curious if its actually possible write some type of bridging lua module which makes nvim-tree a nvim-ide component.
We'd basically need to manage just the nvim-tree buffer, and take over the window creation, and them give the window ID back to nvim-tree so it can do anything window related with the Panel's window.

It might be possible, it would depend on how nvim-tree renders its window/buffer internally. We can look into it.


Light Linking Editor improvements

So... I've been playing around with RfB for around 2 weeks now. It is pretty awesome! But... there are some meh things with it too. And that's mostly the UI/UX.
The current UI/UX of the light linking editor is only fine for scenes with a relatively small amount of objects in. It is impossible to use with scenes containing medium to large amounts of objects. Just have a look at the picture below of a current small-medium scene I'm working on. It would be a terrible time sink having to add all the objects in the scene to the Objects list, let alone set an Illumination rule to all of them - that is because we can't batch process!

We need a solution to this problem.
I'm not a programmer. I don't know what it takes to program UI in Blender, or the limitations behind it - maybe there is something that prevents the devs from refining this.
I have come up with a solution that I hope is doable programming-wise, and that is user-friendly and intuitive.
Say we have a scene, and we want to link some objects to a light.

Step 1. The user selects the objects he wants to link to a light.

Step 2. User Shift-select a light, making it the Active object.

Step 3. Using a right-click sub-menu under Renderman menu the user has a few options to choose from to set the illumination rule:
a. Link selected objects to Active - Default
b. Link selected objects to Active - On
c. Link selected objects to Active - Off
d. Remove from Light Linking

If the user wants to remove selected objects from Light Linking altogether, all they have to do is select the objects in the scene, use the right-click menu, and hit the "Remove selected from Light Linking" option.

Again, not a programmer, but I really think that if the above is doable, it would solve a lot of issues with the current UX.

Batch processing is now doable - that's awesome! The user can link multiple objects to a light, remove light linking from multiple objects, change the Illumination rule for multiple objects.
The user can use Blender's built-in selection tools to select objects in the scene. Be it the Outliner, the viewport, select linked, select by type etc.
User friendly and intuitive - can all be done via the viewport if the user wants to. Rarely would need to go into the Light Linking Editor.

Please let me know what you think. Open for feedback from other users too.

re: the long list of objects
Does the filter search not work for you?
re: using the right click submenu
This should be do-able, as we already do something similar for the light mixer editor.
The other thing we can add is an invert option.

Can you see if the latest commit works well for you? This adds the suggestion of adding the light linking operations to the right click menu.

In my opinion for light linking and preset browser should have its own dedicated window just like node editor, etc instead of a temporary window like that.

I agree with you @nuzzar . But maybe it's not doable or is too much work to program something like that. It's very Blender-specific. I don't know. But anyway, that's why I suggested the right-click menu approach.

Yeah, I know it's probably a lot harder and I'm not sure if it's even possible. But there are other add-on that has its dedicated window. Although it's probably just a duplicate of the node editor.

@TzurH  can you try the latest commit? We've never had per object per light controls of light linking, so this is somewhat of an invasive change.
Also, I've changed the right click menu a bit. If you have objects selected, but the current active object is not a light, we show the controls for all of the lights in the scene. I don't know how slow this might be if you have a lot of lights in the scene, but it seems useful.

re: adding a dedicated window
The only way I know of to do that would be to create your own node tree.  But, I don't know how useful it is to do light linking in a graph like setting.

@prman-pixar I'm not saying to use node tree for light linking. It's pretty obvious it won't be practical. What I mean is a window like these instead of a floating window which are temporary.

If it's possible to make a custom window like these for light linking that would be great. I'm thinking something like what Maya has. If not or too cumbersome to do, why not do it the blender way and use collection and its link feature for light linking? You could add a light icon to toggle the light link in the outliner.

@nuzzar  Right. Like I said I don't know of a way to add a new window like a custom outliner; the only way I know of is to create a custom node tree property.
The collection idea is interesting, but that would break existing scenes. Could be something to consider for the next major version.

We've never had per object per light controls of light linking, so this is somewhat of an invasive change.

Oh my bad. I thought per object light control was a thing, I've only started using the system last week.
I have just opened Houdini for comparison. The way it works in Houdini is you link the objects you ONLY want the light to affect. That actually makes a lot more sense to me too, as you are creating a link between the light and the objects.

What is the purpose of having Illumination rules in Blender? I must be misunderstanding something here.
If the rule is Default - it affects the objects in Objects list and everything else in the scene.
If the rule is On - it does the same as above.
Only when the rule is Off for the objects in Objects list - it will not affect the objects.
If you match the behavior of linking In Blender to Houdini, you could remove those rules and only have the 2 buttons for the right-click menu, one for "Link selected to light_name" and one for "Remove selected from light_name". You could then also simplify the Light Linking Editor UI, removing the Illumination column and change the "Objects" column to "Link" so it makes more sense to the user. Have a look at the mockup below.

So in that instance, the light will ONLY affect the Icosphere, or any other objects listed in the "Link" list.

Also, I've changed the right click menu a bit. If you have objects selected, but the current active object is not a light, we show the controls for all of the lights in the scene. I don't know how slow this might be if you have a lot of lights in the scene, but it seems useful.

I don't know if this is a good addition to the right-click menu. My idea behind it is to work in the viewport, so the user has a visual correlation between the objects and the light he has selected (this emphasizes the 'link'). It can bloat the UI if there are many lights in the scene, and if the user hasn't named the lights properly, it can get really confusing and lead to errors. I think the risk of errors is reduced significantly when the user has to select the light and make it active.
An extreme example below, but it can happen.

@TzurH can you try the latest commit? We've never had per object per light controls of light linking, so this is somewhat of an invasive change.

Have just tried it. This works great!!!
Please read my above replies though, especially the one comparing the behaviour of light linking to Houdini - it might solve a lot of headaches and your time. I'm pretty sure the behaviour showcased in Houdini is the same in Maya, as in, the light will ONLY affect objects that are linked to it, but I haven't tested as I don't have Maya, so can't confirm!
I'm deeply sorry for making you work on this prior to comparing how it works in other DCCs, my apologies.

@TzurH  can you try the latest commit?
I added a pref to invert the light linking behavior. Note, if this is on, it means by default nothing is illuminated. i.e.: if a light is missing from the light linking editor, it does not illuminate anything.

Hmm, doesn't seem to work for me.

@TzurH  Can you try this scene?
cornell_box_lpe.zip
It works when I do:

Start IPR
Select Suzanne, then select the PxrRectLight
Right click RenderMan->Light Linking->Link Selected to PxrRectLight

@prman-pixar Tested your scene, works well.
I've noticed you have 2 lights in your scene so I've tested a bit more. A bunch of issues:

If you only have 1 light linked to a few objects, it won't work - it illuminates everything in the scene, which is what I reported before:

In Houdini - Red light has no links set:

Red light is linked to Monkey only:

If you have more than 1 light of the same type, only one of them will illuminate the scene:

In case you have 2 of the same lights, and you remove the one that was illuminating the scene, now the other one isn't, looks like this bug is connected to the one reported at 2.

If you have 2 lights of a different type, and one of them is linked to a few objects, the other light won't illuminate those objects. They now only receive light from the light that they are linked to. They should still be illuminated from the other lights in the scene if those lights have no links set to them, as they are suppose to illuminate everything in the scene.

Here it is in Houdini:

** I've removed GI so it's clear to see what's happening in the pics.
I hope my writing is clear enough to understand. It's hard writing with a mouse haha.

@TzurH  can you try the latest commit. It should work with one light and objects should now include lights that are not linked.

@prman-pixar all reported issues have been fixed!
I didn't stumble upon any bugs as of yet while testing the invert light linking behaviour - so I think you can close this issue.
thanks for your work on this 💯 👍
I'm very pleased with how the new system works. both the invert light linking and the non invert. the added option to set per object rules for example could become very useful for artists using the default light linking behaviour. personally, I prefer the invert light linking behaviour so I'm going to stick with that! :]

Great! I'll consider this close then.


[CT-1509] Reorganize protobuf structured logging events

As per discussion with Dave Berton, attempt to reorganize the existing protobuf messages so that instead of an EventInfo submessage, those fields will be moved to a top-level Event, and the rest of the logging events will be submessages specified in a "oneof" in the Event message. This should make it easier to deserialize.
The current creation of events for the "fire_event" function should be able to stay the same, except for tweaks (improvements) to the way that we set "level". Instead of setting the event keys in the a post_init of the BaseEvent class, we will construct an Event in "fire_event" and set the passed in message as the "detail" part of the event.
This is part of the structured logging initiative, such as we see in https://github.com/dbt-labs/dbt-core/pull/6136.

This was implemented in a pull request but found to have unacceptable performance. This is almost certainly due to the need in Python to build fields for every single event in every event object.
Some other incidental fixes that were produced in that PR will be handled by a separate ticket/pull request.


Annoying error

Receiving on every page loading error in console
ActionController::RoutingError (No route matches [GET] "/assets/ekko-lightbox.min.css.map"):

actionpack (5.0.2) lib/action_dispatch/middleware/debug_exceptions.rb:53:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
web-console (3.4.0) lib/web_console/middleware.rb:135:in `call_app'
web-console (3.4.0) lib/web_console/middleware.rb:28:in `block in call'
web-console (3.4.0) lib/web_console/middleware.rb:18:in `catch'
web-console (3.4.0) lib/web_console/middleware.rb:18:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
actionpack (5.0.2) lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
railties (5.0.2) lib/rails/rack/logger.rb:36:in `call_app'
railties (5.0.2) lib/rails/rack/logger.rb:24:in `block in call'
activesupport (5.0.2) lib/active_support/tagged_logging.rb:69:in `block in tagged'
activesupport (5.0.2) lib/active_support/tagged_logging.rb:26:in `tagged'
activesupport (5.0.2) lib/active_support/tagged_logging.rb:69:in `tagged'
railties (5.0.2) lib/rails/rack/logger.rb:24:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
sprockets-rails (3.2.0) lib/sprockets/rails/quiet_assets.rb:11:in `block in call'
activesupport (5.0.2) lib/active_support/logger_silence.rb:20:in `silence'
activesupport (5.0.2) lib/active_support/logger.rb:63:in `block (3 levels) in broadcast'
activesupport (5.0.2) lib/active_support/logger_silence.rb:20:in `silence'
activesupport (5.0.2) lib/active_support/logger.rb:61:in `block (2 levels) in broadcast'
sprockets-rails (3.2.0) lib/sprockets/rails/quiet_assets.rb:11:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
actionpack (5.0.2) lib/action_dispatch/middleware/request_id.rb:24:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
rack (2.0.1) lib/rack/method_override.rb:22:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
rack (2.0.1) lib/rack/runtime.rb:22:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
activesupport (5.0.2) lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
actionpack (5.0.2) lib/action_dispatch/middleware/executor.rb:12:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
actionpack (5.0.2) lib/action_dispatch/middleware/static.rb:136:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
rack (2.0.1) lib/rack/sendfile.rb:111:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
railties (5.0.2) lib/rails/engine.rb:522:in `call'
newrelic_rpm (<IP_ADDRESS>2) lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call'
puma (3.8.2) lib/puma/configuration.rb:224:in `call'
puma (3.8.2) lib/puma/server.rb:600:in `handle_request'
puma (3.8.2) lib/puma/server.rb:435:in `process_client'
puma (3.8.2) lib/puma/server.rb:299:in `block in run'
puma (3.8.2) lib/puma/thread_pool.rb:120:in `block in spawn_thread'

Please remove map line from file or make sth else

I had to roll back to version <IP_ADDRESS> because this error message was less annoying:
DEPRECATION WARNING: Extra .css in SCSS file is unnecessary. Rename
/usr/local/rvm/gems/ruby-2.2.2/gems/lightbox-bootstrap-rails-<IP_ADDRESS>/vendor/assets/stylesheets/lightbox-bootstrap.css.scss
to
/usr/local/rvm/gems/ruby-2.2.2/gems/lightbox-bootstrap-rails-<IP_ADDRESS>/vendor/assets/stylesheets/lightbox-bootstrap.scss.
(called from _app_views_layouts_application_html_haml__3810064660071991527_69895092101360 at
/home/ubuntu/workspace/petersenwest/app/views/layouts/application.html.haml:10)

Fixed current problem in #8. I will be grateful for the review.


Add Validators Snippets

[ ] Validate IPv4
[ ] Validate Hexadecimal
[ ] Validate EmailID
[ ] Validate Phone Number

Can I work on these?

Not really, validation is outside the scope of this repo for the most part, as it requires a deeper understanding of a lot of concepts not explainable in 30s or less.


Add a bzlmod module definition

Before we can land this PR, we need https://github.com/bazelbuild/rules_jvm_external/pull/880 to have been landed and pushed to a release in the BCR.


Test $Apply using measles resources

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2345
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@DebbieArita
Few requests:-
Please refer the issue this PR is solving in the description.
Also complete the checklist.
Is this PR ready for review ?

@DebbieArita Few requests:- Please refer the issue this PR is solving in the description. Also complete the checklist.
Is this PR ready for review ?

@MJ1998 Yes, this is ready for review. Added a ticket too.

Updating this test with requested changes...


Unable to use __specified__ in mutation rewrite on extended type

EdgeDB Version: 4.5+28216a1
EdgeDB CLI Version: 4.0.2+be1da73
OS Version: GNU/Linux 6.7.3-arch1-1

abstract type DealBase {
  description: str;
}

type VacancyDeal extending DealBase {
   required what_to_do: str;

   required content_modified_at: datetime {
      default := to_datetime(0);
      rewrite update using (
         if any({ __specified__.what_to_do, __specified__.description })
         then datetime_of_statement()
         else datetime_of_statement()
      );
   };
}

Running query
update DealBase set { description := "test" }

will cause an error:
InvalidReferenceError: what_to_do is not a member of tuple<... (DealBase keys)>

And I didn't find any way to check if tuple has item by name or to convert named tuple to set.

Only workaround I found:
required content_modified_at: datetime {
   default := to_datetime(0);
   rewrite update using (
      with
         j := <json>__specified__
      select (
         if exists json_get(j, "what_to_do") or
            exists json_get(j, "looking_for") or
            exists json_get(j, "description")
         then datetime_of_statement()
         else __subject__.content_modified_at
      )
   );
};


[flutter_tools] Clean code analyze command

Description
Split Vertically compare AnalyzeContinuously and AnalyzeOnce, Refactoring analyze() make them similar in structure.
Clean code:
logger.print()'s message
redundant comment
Extract method from AnalyzeContinuously and AnalyzeOnce to AnalyzeBase
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Tests
I added the following tests:
Reuse flutter analyze command test case.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

Thanks for the PR! Please fix the analyzer lint reported by the analyze-linux check, and add a unit test of generateDartDocMessage.

Thanks for the PR! Please fix the analyzer lint reported by the analyze-linux check, and add a unit test of generateDartDocMessage.

Thank you I fix analyze lints, and I see other methods in AnalyzeBase class seems no unit test too, all they will be test by analyze_*_test.dart's cases.

@zanderso

An example for test case would be something like:
diff --git a/packages/flutter_tools/test/commands.shard/hermetic/analyze_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/analyze_test.dart
index e5b34174a1..aae5b401a3 100644
--- a/packages/flutter_tools/test/commands.shard/hermetic/analyze_test.dart
+++ b/packages/flutter_tools/test/commands.shard/hermetic/analyze_test.dart
@@ -11,6 +11,12 @@ import '../../src/common.dart';
 const String _kFlutterRoot = '/data/flutter';

 void main() {
+  testWithoutContext('creates correct dartdoc message', () {
+    expect(generateDartDocMessage(0), null);
+    expect(generateDartDocMessage(1), 'one public member lacks documentation');
+    expect(generateDartDocMessage(2), '2 public members lack documentation');
+  });
+

While not all of the tool is as tested as I would like, its generally good to improve it where possible. This refactoring makes it much easier to unit test this functionality; we should take advantage of it.

An example for test case would be something like:
diff --git a/packages/flutter_tools/test/commands.shard/hermetic/analyze_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/analyze_test.dart
index e5b34174a1..aae5b401a3 100644
--- a/packages/flutter_tools/test/commands.shard/hermetic/analyze_test.dart
+++ b/packages/flutter_tools/test/commands.shard/hermetic/analyze_test.dart
@@ -11,6 +11,12 @@ import '../../src/common.dart';
 const String _kFlutterRoot = '/data/flutter';

 void main() {
+  testWithoutContext('creates correct dartdoc message', () {
+    expect(generateDartDocMessage(0), null);
+    expect(generateDartDocMessage(1), 'one public member lacks documentation');
+    expect(generateDartDocMessage(2), '2 public members lack documentation');
+  });
+

While not all of the tool is as tested as I would like, its generally good to improve it where possible. This refactoring makes it much easier to unit test this functionality; we should take advantage of it.

Yes, adding tests will make developer understand the class in-depth.

@jonahwilliams Hi Williams

This will land automatically once the tree is green (https://flutter-dashboard.appspot.com/#/build) things are a bit backed up right now


Copy propagate arrays

The sprir-v generated from HLSL code contain many copyies of very large
arrays.  Not only are these time consumming, but they also cause
problems for drivers because they require too much space.
To work around this, we will implement an array copy propagation.  Note
that we will not implement a complete array data flow analysis in order
to implement this.  We will be looking for very simple cases:

The source must never be stored to.
The target must be stored to exactly once.
The store to the target must be a store to the entire array, and be a
copy of the entire source.
All loads of the target must be dominated by the store.

The hard part is keeping all of the types correct.  We do not want to
have to do too large a search to update everything, which may not be
possible, do we give up if we see any instruction that might be hard to
update.
Also in types.h, the element decorations are not stored in an std::map.
This change was done so the hashing algorithm for a Struct is
consistent.  With the std::unordered_map, the traversal order was
non-deterministic leading to the same type getting hashed to different
values.  See |Struct::GetExtraHashWords|.

I still have to create unit test.

Created some test.  Still want to create test where the elements in the arrays are struct containing other arrays.

Rebased, squashed and merged as c4dc046.


Crashes when notification time reached

Using react native version 0.59
I defined a notification as shown below then wait it to be displayed but app crashes.
RNLocalNotifications.createNotification(1, 'Some text', '2019-09-07 23:15', 'default');

Library installed directly from github or via npm? (github master branch always contains latest chages, npm version may not be updated...)
Android or iOS?
Can you check the logs in Xcode or Android Studio? That should tell you the problem!

I installed it by github today. I also tried on device (Android 5.0 LG d855) beside genymotion emulator. App on emulator crashed again, device give a sound on time but notification didn't appear on screen. I actually dont have any experiences about Android Studio. I will let you know if I see any errors. Thanks.

Note that the readme mentions:

NOTIFICATIONS WILL NOT BE SHOWN WHEN YOUR APP IS IN THE FOREGROUND.

You say Android real device with 5.0, which version was your emulator?

If you leave your phone (or android studio emulator) connected and the log open while the app is in background you should see the problem there, with a bit of luck it will even tell you in which file on which line (java files).

I tried on emulator 5.0. Results on same on my device. I also realised that there is a clock icon on status bar as if I set up an alarm. Then it disappears when notification sound heard but no notification displayed again. I added a screen capture. Thanks. Device didnt show any error mesages by the way.
screencast-Genymotion-2019-09-11_<IP_ADDRESS>8.zip

Are you using androidX? Then can you try and change the import in AlarmReceiver.java from

import android.support.v4.app.NotificationCompat;

to

import androidx.core.app.NotificationCompat;

Though I'm running an emulator on Android 8.1, I believe I'm encountering the same issue. I created a test notification with the same arguments above, and it crashes when the time is reached.
I managed to get a log of the crash and found this:
AndroidRuntime: java.lang.RuntimeException: Unable to start receiver com.github.wumke.RNLocalNotifications.AlarmReceiver: java.lang.IllegalArgumentException: Invalid notification (no valid small icon):
It looks like it's failing to use the default icon values. I tried calling RNLocalNotifications.setAndroidIcons("ic_launcher", "mipmap", "notification_small", "drawable");   to see if it needed to be explicitly called, but it didn't make a difference.
It's worth noting that my project is using React Native 0.60.5, and AlarmReceiver.java has the correct import because I've configured the project with Jetifier.

@brycecorbitt : Nice you figured out how to fix your problem. Indeed, the small icons are not included by default since they are project specific... nice link for quick icon generation, I'll put that link in the readme!
@yalcinozer : Could this also be your problem??

@brycecorbitt : Nice you figured out how to fix your problem. Indeed, the small icons are not included by default since they are project specific... nice link for quick icon generation, I'll put that link in the readme!
@yalcinozer : Could this also be your problem??

This solution may works for me also. I will try it. So I'm closing issue for now, If I have any problem, I contact to you, thanks.


Stereo Depth Perception Transforms

Currently we are in progress of revamping transforms API for torchvision library. During this revamp, we are considering the components and behavior for new use cases such as detection, segmentation, and video classification. In this document, we just want to raise awareness on several transforms in depth perception quirkiness that might behave differently from the other use cases.
Stereo Depth Perception Brief Introduction
In the Stereo Depth Perception problem, we are given two images, left and right, and for each pixel on the left image we want to guess the horizontal displacement of the pixel occurrence on the right image. The images are taken at the same time with two different cameras with the same upright orientation and their distance must be parallel with the horizontal axis / ground. The desired output is called disparity map, a 2d integer array with the same size as the image indicating how much displacement the pixel on that position is from left to right image (the unit of the displacement is in pixels).
 This is a 2d boolean array with the same size as the disparity map; the valid mask indicates whether the values in disparity maps are valid or not. Practically, we usually exclude the non-valid disparity maps from loss calculation during the training or validation.
Components

Images:
A pair of left and right image as input
Disparity map:
2d integer array with same size as the image indicating the displacement of pixels on the image pair. Some dataset only give one disparity map which usually indicate the displacement from left to right image and some dataset provide a pair of left and right disparity maps.
Valid mask:
2d boolean array with the same size as the disparity map indicating whether or not the disparity map value is valid and needs to be considered in loss calculation.

In general, a stereo depth perception dataset will have:
(

(image_left, image_right),

(disparity_map_left, [optional] disparity_map_right),

([optional] valid_mask_left, [optional] valid_mask_right)

)

Horizontal Flips
For horizontal flips, we do the horizontal flips on each component and then we need to flip the order of left and right. Supposing HF is an operation to do horizontal flip for a component, then:
horizontal_flips( (image_left, image_right), (disparity_map_left, disparity_map_right), (valid_mask_left, valid_mask_right) ) =

(HF(image_right), HF(image_left)), (HF(disparity_map_right), HF(disparity_map_left)), (HF(valid_mask_right), HF(valid_mask_left))

The new behavior on this transform is that we need to flip the ordering of left and right which did not exist in previous use cases.
Here are a code reference: https://github.com/pytorch/vision/blob/17ace9557f95be6dfa6683bd8b6c002bbcb668df/references/stereo_matching/transforms.py#L344
Resize
For resizing, we resize the image normally, but for the disparity maps we need to adjust the value after the resize by multiplying the resizing scale factor and then convert the value into the nearest integer.
Remember that disparity map is the pixel displacement and the unit of the displacement is in how many pixels. If we resize the image, then the pixel displacement will also scaled with the same scaling factor of the resizing.
Take note that the flow from OpticalFlow behave similarly in resize as well.
Here is the code reference: https://github.com/pytorch/vision/blob/17ace9557f95be6dfa6683bd8b6c002bbcb668df/references/stereo_matching/transforms.py#L370
Erase / Occlusion
For erase or occlusion, commonly we only apply the operation on the right image without affecting other components (no transformation happens on left image, disparity maps, and valid masks).
Here are code references:
https://github.com/pytorch/vision/blob/17ace9557f95be6dfa6683bd8b6c002bbcb668df/references/stereo_matching/transforms.py#L261
https://github.com/princeton-vl/RAFT-Stereo/blob/main/core/utils/augmentor.py#L109
https://github.com/megvii-research/CREStereo/blob/ad3a1613bdedd88b93247e5f002cb7c80799762d/dataset.py#L155
cc @vfdev-5 @datumbox @pmeier @TeodorPoncu

Thanks for the overview @YosuaMichael.
It's worth noting that this is a somewhat abstract view of the Stereo Depth Perception case. There are more nuances (float vs integer maps, signed maps etc) but these give a very good picture.
I think this would be a great food for thought and discussion to see how the new Transforms API can adjust to new use-cases that wasn't designed for. @pmeier and @vfdev-5 not a top priority but worth looking at some of the details listed here to see how we could potentially support them. I think that most of the things described here are possible but there might be details worth looking into when we decide to bring this as a standalone project.


dropbox: 3.12.4 -> 3.12.5; libGL fix

@bendlas Thanks, I was just about to start working on this myself! :)

I already committed the Dropbox update and libGL fix to stable. For master, I am going to fix Qt's libGL issue, so I will push the Dropbox update only.


Split Station Warden inconsistencies

Description
On Split Station the warden's office does not spawn with a wardens locker. Warden also does not have access to the button toggling the blast doors to the leathal armory.
Reproduction
N/A
Screenshots
Warden Office:

Hos Office:   -- Blast door button on right side --

Armory:   Note the blast door preventing access to the lethal armory on the bottom

Additional context
In every other station, the warden spawns with a wardens locker and they have access to the leathal armory. On split station, the button to open the leathal armory blast door is located in the HoS' office.
For consistency, the warden should be able to get into the leathal armory without relying on the HoS and a wardens locker should spawn in the warden office.

Known, adding the locker is on my to do list but I’m on holiday and mapping has been sus for ages for me.
Also the blast door is intended. Guns are for code red only and warden doesn’t have that power. Maybe when we get MRP.


Cannot run any container on Ubuntu 22.04 LTS

Environmental Info:
K3s Version:
k3s version v1.26.0+k3s1 (fae88176)
go version go1.19.4

Node(s) CPU architecture, OS, and Version:

Linux test-s0 6.0.0 #1.3 SMP Fri Nov 18 05:18:45 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux
Cluster Configuration:

3 servers, 11 agents
Describe the bug:

I'm trying to install K3s 1.26.0 on a newly flashed node with Ubuntu 22.04 LTS. The installation succeeds, but I'm unable to start any pod on the node. I get the following:
$ kubectl describe node salim-s0
[...]
Events:
  Type     Reason                            Age                  From                   Message
  ----     ------                            ----                 ----                   -------
  Normal   Starting                          57m                  kube-proxy
  Normal   Starting                          9m3s                 kube-proxy
  Normal   Starting                          57m                  kubelet                Starting kubelet.

  Warning  InvalidDiskCapacity               9m4s                 kubelet                invalid capacity 0 on image filesystem
  Normal   NodeHasSufficientMemory           9m4s (x2 over 9m4s)  kubelet                Node salim-s0 status is now: NodeHasSufficientMemory
  Normal   NodeHasNoDiskPressure             9m4s (x2 over 9m4s)  kubelet                Node salim-s0 status is now: NodeHasNoDiskPressure
  Normal   NodeHasSufficientPID              9m4s (x2 over 9m4s)  kubelet                Node salim-s0 status is now: NodeHasSufficientPID
  Normal   Synced                            9m3s                 cloud-node-controller  Node synced successfully
  Normal   NodeReady                         9m2s                 kubelet                Node salim-s0 status is now: NodeReady
  Normal   RegisteredNode                    8m59s                node-controller        Node salim-s0 event: Registered Node salim-s0 in Controller
  Warning  FailedNodeAllocatableEnforcement  58s (x9 over 9m2s)   kubelet                Failed to update Node Allocatable Limits ["kubepods"]: openat2 /sys/fs/cgroup/kubepods.slice/cpu.weight: no such file or directory

Steps To Reproduce:

Install Ubuntu 22.04 LTS on an ARM node
Configure iptables-legacy (k3s-agent won't even start with iptables-nft)
Install k3s as agent
Try to run any pod

Expected behavior:
Pod starting on the node.
Actual behavior:

Additional context / logs:
Pods remain in "pending" state and the node has the events listed above.

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.1 LTS
Release:        22.04
Codename:       jammy

Same procedure works fine when executed on Ubuntu 20.04 LTS instead of 22.04 LTS.

Are you using cgroup v1, v2, or hybrid - what is the output of grep cgroup /proc/mounts?
Are you using the embedded containerd, --docker, or another runtime with --container-runtime-endpoint?
Is this a raspberry pi, or perhaps some other device with a kernel that is missing features? I am personally running K3s 1.26.0 on a Pi with Ubuntu 22.04 and it works fine.
root@seago:~# kubectl get node -A -o wide
NAME              STATUS   ROLES                  AGE      VERSION        INTERNAL-IP   EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION          CONTAINER-RUNTIME
pi02.lan.khaus    Ready    <none>                 108d     v1.26.0+k3s1   <IP_ADDRESS>     <none>        Ubuntu 22.04.1 LTS   5.15.0-1016-raspi       containerd://1.6.12-k3s1
seago.lan.khaus   Ready    control-plane,master   2y198d   v1.26.0+k3s1   <IP_ADDRESS>     <none>        Ubuntu 22.04.1 LTS   5.19.5-051905-generic   containerd://1.6.12-k3s1

Thanks for your swift response!
Our nodes are running on Khadas VIM3 Pro hardware. They've been running Ubuntu 20.04 LTS with K3s for a long time. Now I've upgraded all nodes to Ubuntu 22.04. It's been working fine except for this one.
$ ansible edge -a 'grep cgroup /proc/mounts'
[...]
kim-s0 | CHANGED | rc=0 >>
cgroup2 /sys/fs/cgroup cgroup2 rw,nosuid,nodev,noexec,relatime 0 0
salim-s0 | CHANGED | rc=0 >>
cgroup2 /sys/fs/cgroup cgroup2 rw,nosuid,nodev,noexec,relatime,nsdelegate,memory_recursiveprot 0 0

and then ...
$ ansible edge -a  'cat /sys/fs/cgroup/cgroup.controllers'
[...]
kim-s0 | CHANGED | rc=0 >>
cpuset cpu io memory pids rdma
salim-s0 | CHANGED | rc=0 >>
cpuset cpu io memory pids rdma

These results are consistent for all edge nodes, so they all show the same results, except /proc/mounts has a few extra flags on the node salim-s0 - that's the one with this issue. I have no idea what these params mean and where to change them if its relevant.

After yet another reboot the mount options nsdelegate and memory_recursiveprot disappeared and now everything works as expected. Although the problem solved itself now, it isn't a great user experience because I had to reboot the node once again.

That sounds like with an issue with Ubuntu or your host, not K3s. We don't change anything about how the cgroup controllers are mounted. Systemd is usually responsible for that?

Also are you using a custom kernel? That can cause issues as well.
On Wed, Dec 21, 2022, 2:53 PM Brad Davidson @.***>
wrote:

That sounds like with an issue with Ubuntu or your host, not K3s. We don't
change anything about how the cgroup controllers are mounted. Systemd is
usually responsible for that?
—
Reply to this email directly, view it on GitHub
https://github.com/k3s-io/k3s/issues/6667#issuecomment-1362019884, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AALHLRY3M26UOKXLEMACK7DWONN4VANCNFSM6AAAAAATF2P6VU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

We are flashing new nodes with an image (now Ubuntu 22.04 LTS, before it was 20.04 LTS) and then use Ansible to upgrade packages and configure the OS and eventually install K3s. The Ansible playbook obeys /var/run/reboot-required just before K3s gets installed - resulting in just a single reboot. This worked fine with Ubuntu 20.04. Apparently with 22.04 LTS one more manual reboot is required after the installation of K3s.
I agree this looks like an issue with Ubuntu, not K3s, so let me close this issue - thanks for your help.
PS: We are using a mainline Kernel from Khadas, the board manufacturer. The current version is 6.0.0.

@brandond this seems like a similar issue, no problems at all with the same Kernel on Ubuntu 20.04 - the only difference here is the rootfs, which now uses Ubuntu 22.04.
I can see the cpuset cgroup in the above commands, too.

K3s v1.20 works - anything below that fails with the above errors.

Why would you run anything earlier than 1.19 on Ubuntu 22.04? Those releases are all long end-of-life.

It was part of a matrix test demo for actuated which tested a CRD with every available K3s version.
It seems like v1.20 is the min compatible version for 22.04 - I didn't realise that was the case, and couldn't find that documented. Makes sense now that we talk about it.
Thanks for your time @brandond


Any option for easier vendor bundling

I omit reasoning why it's required to separate app and vendor bundles. Let's say we agree on this.
Currently I have to either:

Support hand-picked list of vendor libraries. Miss one depending on React, and Browserify will write React to app bundle.
Rely on automatic listing. As soon as you develop frontend + backend app package.json has no clue how to distinguish them. You'll get your backend-only deps on frontend which is blocker on itself (size!), not even saying that some of them don't work in browser...

So both methods don't work at production scale.
Should we expect any better solvement for this in the future?
I'm sure Browserify has enough information to automate this at translation time.
Or any advices how this should be solved in case I missed something?
I wouldn't like to switch to webpack (look at this insanity: https://github.com/kriasoft/react-starter-kit/blob/master/webpack.config.js).

Kinda related problem. I had a hard time discovering why my bundle became a few megabytes.
The reason was I had this statement: let React = require("react/"); path (artefact of removal react/addons). Everything worked, but React was bundled twice...

Another option : use <script> tags for those external vendor files. Otherwise you can use partitioning plugins or an explicit list, as you already mentioned.
I think separate <script> tags for the vendored dists is the simplest strategy. Packages built this way don't really have modularity in mind in the first place, so might as well make them globals.

I was not aware of partitioning plugins, need to check them out. Thank you!


Group Management

Change Type
Correction
Proposed Changes
https://docs.cloudmydc.com/environment-management/environment-groups/group-management

Duplicate Issue, #206


Swiping through certain artists' works is sluggish sometimes

can be hard to repro

maybe try profiler

Felt like it would happen specifically on portrait images


68 tweet timestamp

Hey!
Added day and time as tweet card footer!
Let me know what you think!
Cheers

Great work! I need to fix the dev branch from a last PR that I merged, but afterwards can you please remove your SwiftLint warnings and rename the one file I mentioned?
Great work! I'll still accept this for Hacktoberfest

@NiklasOemler  Can you please resolve the merge conflicts? Once done I'll merge this PR


[BUG] missing user metadata for system nuv login action

system nuv login action seems to be affected by these issues:

the response from the system nuv login action misses the APIHOST which can be useful to configure the nuv cli our ask cli

according to current development status this is not really an issue as nuv login requires already an apihost argument, therefore the user should know already it.


Native Kubernetes secrets for authorization

This PR adds support for fetching native Kubernetes secrets to Prometheus for authorization.
The plan is that this PR would eventually be superseded by upstream efforts (see https://github.com/prometheus/alertmanager/issues/3108#issuecomment-1781912503).
This is a slimmed down version of what could eventually become an upstream change. While some of the code uses a generic SecretProvider interface, the new configs are harded-coded Kubernetes secrets (which maps a secret reference name to a Kubernetes secret) and a new kubernetes_sp_config (which configures the connection to the Kubernetes API server). Then, that secret name is referenced in the authorization config, e.g. for BasicAuth it would be password_ref. These would eventually be replaced with the upstream version when they get released.
One way this implementation differs from service discovery is that configuration changes are incremental: when a secret is added or removed, the Kubernetes secret provider simply adds or removes a Kubernetes WATCH API call, while existing watches are kept in-tact.

Thanks for the awesome work @TheSpiritXIII!
@bwplotka @macxamin @bernot-dev - I'd love for any or all of us to begin reviewing this change to internalize the approach and ask questions. PTAL if you have capacity

Ideally this only adds the change we need for native secrets, otherwise it's impossible to review and merge 🤔

Ideally this only adds the change we need for native secrets, otherwise it's impossible to review and merge 🤔

Does this PR still feel too big?  The intention is we could change the implementation if we have performance concerns. For example we could add a poll-based watcher if we feel the watches overload the Kubernetes API server, or even a hybrid approach where watches are used until a threshold and then it switches over to polling. Perhaps it can still be trimmed a little more though.

@bwplotka requesting re-review in case you want to look at instrumentation changes and the new feature flag!

Moving this change to prometheus-engine here: https://github.com/GoogleCloudPlatform/prometheus-engine/pull/864


Signature validation fails when no signature algorithm is specified

I am attempting to validate an access token coming from Azure AD B2C, and the validation is failing even though jwt.io successfully validates the signature. This is version 1.9.0.
In SignatureValidationPolicy.cs, line 101, Jwk.CanUseForSignature() is called with "RS256" as signatureAlgorithm, and it returns true, because the SignatureAlgorithm property returns null. Then, on line 103, alg ends up null because both algorithm and key.SignatureAlgorithm are null. That means that the code never tries to validate the signature, and InvalidSignature is the result.

The AzureAD JWKS does not specify the signature algorithm used.
When you specify the validation policy, do you specify the signature algorithm ?
            var policy = new TokenValidationPolicyBuilder()
                           .RequireSignature(key, SignatureAlgorithm.RsaSha256) // <= this is required
                           // ...
                           .Build();

Based on the title of the issue ("when no signature algorithm is specified"), I assume the answer is "No".
This is by design for avoiding security flaw as descriped in this article: https://auth0.com/blog/critical-vulnerabilities-in-json-web-token-libraries/.
We are working on the version 2.0 and this part has been redesigned. The RequireSignature() overloads without algorithm will be removed, forcing the developer to set an algorithm.

Ah, no, I haven't been specifying the algorithm; I didn't realize that that was necessary (and after reading the article, it definitely should be). After specifying that, it's working great. Thanks!

The current design flaw is that we try to guess the algorithm from the JWK. The fact that you open an issue probably means that it may be confusing for developers.
The v2.0 will enforce the algorithm definition, but I still would like to give the opportunity to keep it dynamic like with access token from Google.
Thanks for your feedback!


feat: add opentelemetry 1.0.0beta3 release

update opentelemetry with release 1.0.0beta3

:tada: This PR is included in version 1.102.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add version attribute

Is it possible to add a version attribute? Something like:
import holisticai as hai

print(hai.__version__)

Hi @fracarfer5. This is an issue yet?


Yokogawa GS200 driver does not detect correct mode on connection

When reconnecting to a yokogawa GS200 set to current mode, the driver does not correctly detect the state and does not allow setting a current output.
There is then no way to change the mode in software without either:

Turning off output and changing mode
Changing private variables in the driver

Steps to reproduce

Set yokogawa to current output on front panel of via qcodes
Reconnect to the instrument
Try setting a current output: yoko.current(1e-3)

Expected behaviour
Instrument mode should be detected at connection
System
Windows 10
Qcodes f8afd731a76587af1580dd89d5571936fe14093f

The issue is fixed in the PR #2143


Improvement: Backend Improvements for Typing, Tests, Modularity and Pathlib

Current app.py will be reorganized under backend/, with the following objectives:

Typing: Add type hints throughout the backend
Unit Tests: Develop unit tests for all utility and processing functions.
Response Handling: Add a ResponseHandler class in backend/response_handler.py to handle all communication bwn BE-FE, BE-core using consistent JSON responses.
Replace os with pathlib
Reorganize the code under backend/:

Move Utils to backend/utils.py
Move MediaHandler to backend/media_handler.py
Keep app.py for route definitions and Flask app initialization.

This is a big step going towards v1.0 and offers a relatively straightforward first issue for contributors looking to make an impactful contribution to the project.

assign me

you can check it have made an pr #39

Is this issue open? Shall I open a PR?

Hi @prakash-2002-ramanathan, thanks for your interest. Indeed, it's open and much needed!
Would be great if you could open a PR!

Hey, I have done all of the work, but not quite sure what you mean by "make the Backend to Core communication Consistent JSON "?
Like You want to start a server in C++ to handle JSON responses or pass the data in JSON format to the Media Handler subprocess ?

Thanks for the question @prakash-2002-ramanathan,
We should ensure consistency across the application, using json responses between all layers. Currently the MediaProcessor writes to stdout and the backend is parsing directly these traces. Instead, the core should return a json object.
Likewise, anything between the frontend and backend should be managed through json objects for consistency.
Does this answer your question?

Well, we have an open issue to add a proper logger, e.g. spdlog. Until that comes, we're still writing plain text to cout/cerr.
In the future we'll probably use gRPC for inter-process communication (IPC), but at this stage of the project I'd rather get something significantly less error prone working first. In that sense, for now, we can dedicate cerr for logging, leaving cout isolated for our IPC.
Let's make sure the json structure stays consistent, so that we can write generic parsers.
I'll suggest something like:
{
    "type": "progress",
    "payload": {
        "status": "in_progress",
        "message": "Processing audio",
        "progress": {
            "percentage": 75
        }
    }
}

and for a response type we'd omit the progress. The parser should expect the absence of certain parameters and default to a sensible value.
{
    "type": "response",
    "payload": {
        "status": "success",
        "message": "Processing completed",
    }
}

Currently responses are more important than the progress packets, but still we should think ahead as we implement this.
Please let me know if you have any other questions or need help during the implementation. Thanks!


BUG: Uneven alignment of product prices

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
The prices of product seem to not be aligned properly leading to a poor clean and symmetric UI
Please assign this to me so I can update the product display section for an overall better display @arghadipmanna101
Screenshots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

kindly assign me this please @arghadipmanna101


Client Destination Wildcard adaptation

As shown below:

Clients that subscribe to wildcards do not receive messages properly when sending messages

Whether it is more appropriate to use wildcards here

vertx.eventBus().publish("/topic/todoTask/open", "", deliveryOptions);
There is also a problem of fuzzy matching.


feat: Add exercise variables6 covering const

The 'Variables and Mutability' section of The Book introduces the const keyword. However, that seemed to not be covered by the variables exercises.

This, by the way, is my first ever PR to an Open Source project :)

@saidaspen Welcome!! It's a very good first contribution, thank you so much!!
@all-contributors add @saidaspen for code and content


vph5_to_vpts: implement more input data checks

[ ] All input files come from the same radar
[ ] All input files have the same number of levels/altitude
[ ] File generated by vol2bird (info in how/task)
[ ] ...

closing this issue, tackled as part of https://github.com/enram/vptstools/pull/19


parser: Use updated python-asn1 API

python-asn1 2.7.0 adds context manager support for asn1.Encoder. PyIMG4's parsing code can be updated to utilize this.
There is also a version by @dhinakg here that implements context manager support for asn1.Decoder, which could also be included in PyIMG4's source (though I'd rather a fork is made first).

PyIMG4 has moved to utilizing python-asn1's context manager for asn1.Encoder in https://github.com/m1stadev/PyIMG4/commit/63f92d257860a61dfe0e3757d847206aca390ef4.


Update Readme to fix Pro section syntax

duplicate of https://github.com/moschan/react-native-simple-radio-button/pull/93

Thanks! I merged #93 so I close this PR.


Update role to match Influx 0.9.6

Thanks for looking to get the role updated to the newer version of Influxdb. The changes they introduced in 0.9.5 were more than just the binary path. Please see #10 for what all was updated with this role for the new versions.


Large Window slows Munki Admin down

Having MunkiAdmin in a large window (maximized or FullScreen) results in MunkiAdmin slowing down where scrolling causes stuttering and long delays. I can post a video if it would help.

For some reason, the packages list didn't have core animation support enabled and therefore didn't take any advantage of graphics acceleration. After enabling it, I'm seeing major performance improvements. Fix committed in 14ff255 and will be included in the next release.

Awesome possum. Thanks for everything @hjuutilainen 👍

Should be a whole lot better in 1.6.0

It is indeed faster, but I can't test my large screen at the moment so I can't verify on a 28" 1080p screen that its faster.


version difference against pypi

According to pypi the last version is 0.3.7 but the last tag here is only 0.3.1

thanks.


FIX - host update returns 404

Reason

Existence of host should not be asserted when updating existing host

Hi Joon,
thank you for this PR.
Can you elaborate why we should get rid of this check? In my opinion we should check in both situations since both could already contain the newly added hostname, or am I missing something?
Greetings,
Jonas

Hi Jonas,
When you're adding a new host it makes sense to check if the same host already exists. However when you're updating an existing host, in such case as '/api/edit/:host', checking for existing host will always return true and thus causing a 404 error.
Try updating ip of an existing host, without changing its hostname, and you will be able to reproduce the error.
Best,
Joon.

@joongimin You are totally right – I didn't notice this.

Thanks again
:+1:

@frdmn no problem. Thank you for maintaining hostkeeper. :)

No worries, ist actually one of my first projects I am really proud of.
Let me know in case of feature requests/ideas/improvements.
Also, I'll release your fix with the very next minor release update. :)
Von meinem iPhone gesendet

Am 11.01.2016 um 17:47 schrieb Joon Min<EMAIL_ADDRESS>@frdmn no problem. Thank you for maintaining hostkeeper. :)
—
Reply to this email directly or view it on GitHub.


YAML generation not well formed with "path" parameters

Basically I have two methods like this:
@bp.route('/record/<id>/flag', methods=['PUT', 'PATCH'])
@output(Flag)
def flag_record(id):
   [...]

@bp.route('/record/<id>/unflag', methods=['PUT', 'PATCH'])
@output(Flag)
def unflag_record(id):

The output is something like:

  /supercon/record/{id}/flag:
    patch:
      parameters:
      - &id001
        in: path
        name: id
        required: true
        schema:
          type: string

[...]

/supercon/record/{id}/unflag:
    patch:
      parameters:
      - &id002
        in: path
        name: id
        required: true
        schema:
          type: string

The Open API validator fails with the following error:
-attribute paths.'/record/{id}/unflag'. Declared path parameter id needs to be defined as a path parameter in path or operation level
-attribute paths.'/record/{id}/flag'. Declared path parameter id needs to be defined as a path parameter in path or operation level

You can see there are &id001 and &id002 that they are breaking the format. They are not there with the JSON  export.
Environment:

Python version: 3.8.12
Flask version:  2.0.2
APIFlask version: 0.11.0

Which OpenAPI validator are you using?

Sorry for the slow response. I'm using openapi-generator-cli 5.4.0 https://github.com/OpenAPITools/openapi-generator
I tested without parameters and it fails:
(base) Lucas-MacBook-Pro:data lfoppiano$ openapi-generator generate -i ~/Downloads/spec -g javascript -o ~/Downloads
Exception in thread "main" org.openapitools.codegen.SpecValidationException: There were issues with the specification. The option can be disabled via validateSpec (Maven/Gradle) or --skip-validate-spec (CLI).
 | Error count: 2, Warning count: 0
Errors:
	-attribute paths.'/supercon/record/{id}/flag'. Declared path parameter id needs to be defined as a path parameter in path or operation level
	-attribute paths.'/supercon/record/{id}/unflag'. Declared path parameter id needs to be defined as a path parameter in path or operation level

	at org.openapitools.codegen.config.CodegenConfigurator.toContext(CodegenConfigurator.java:556)
	at org.openapitools.codegen.config.CodegenConfigurator.toClientOptInput(CodegenConfigurator.java:583)
	at org.openapitools.codegen.cmd.Generate.execute(Generate.java:433)
	at org.openapitools.codegen.cmd.OpenApiGeneratorCommand.run(OpenApiGeneratorCommand.java:32)
	at org.openapitools.codegen.OpenAPIGenerator.main(OpenAPIGenerator.java:

With the parameter --skip-validate-spec it works fine and the result is correct.
I think we can close this issue.. and #210 as the YAML is correctly formed. The validation seems to be incorrect or too strict, I will open an issue there.

Thanks for the update. I just tested the YAML output with openapi-spec-validator and it pass the validation, so I'm going to close this.


Segmentation fault (core dumped)

Hi, when I run the code of the pointnet2 model, I met the problem of Segmentation fault (core dumped). Some of the issues have raised this question, but no one to answer it. Therefore, I beg you can help us to solve this problem.

Please provide more information, otherwise I also cannot help you.

Hi, I tested your pointnet2 model from https://github.com/sshaoshuai/Pointnet2.PyTorch/tree/5a4416f51ceaeba242828cabf39133433336850d
I can run it successfully on my local Linux Ubuntu20 with Pytorch3.6 and Python=3.6. However, when  I upload the full code to  the Linux based server and test my code on my own 3d LiDAR dataset (Oxford RobotCar Dataset), I got an error like this:

Besides, the configurations on the Linux server are same as my local Ubuntu20 system. Therefore, I am so confused abouut this problem.

Sorry, I don't familar with that repository. It would be better to raise issue in that repository.


Two Factor Authentication Prevent Conflicting Accounts

Gitea version (or commit ref): 1.1.3
Git version: 2.1.4
Operating system: raspbian
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
If you have accounts on multiple gitea instances it could happen that you overwrite an existing TOTP Key. This is due to the way TOTP Authentication Apps handle entries, see https://github.com/google/google-authenticator/wiki/Conflicting-Accounts.
The circumstances under which this happens:

Same Application Name
Same Account Name
On both instances TOTP enabled

In the worst scenario a user can get locked out of one instance.
Happend to me once but fortunately had access to the database and was able to delete the entry in two_factor table.
I have already opened in issue at https://github.com/pquerna/otp/issues/20
Owner mentioned that library exposes all needed stuff to prevent this and a possible solution https://github.com/pquerna/otp/issues/20#issuecomment-323384960
Unfortunately with his proposed solution the problem still exists if same application name is used.
I'd rather use the URL from the gitea installation.

@lunny As it is already merged I think it can be closed?


Add starter docstring to Cerebro_brain_viewer

This is an example of the kinds of docstrings I'm planning to write. This one is really long because it's for the main class that controls everything here, but I hope to add some more explanation and tighten it up a bit. Let me know what you think!

Yeah, I just had a quick look (sorry, I'm also in the organizing team and takes a lot of my time, but I will try to keep responding and also continue working on the PRs after the brainhack).
The docstrings look really good. I like the annotations, as they would help future users a lot.
Please take your time preparing these changes and let me know if you like me to check and merge them at any point.
Also, feel free to let me know if any of the inputs/outputs/attributes were ambiguous and I can help out in the descriptions.


strange bar appear while maximized

Environment
Windows build number: Microsoft Windows [Version 10.0.19042.630]
Windows Terminal version (if applicable): 1.4.3243.0

Any other software?

Steps to reproduce

initially, the Windows Taskbar is normally at the top, and always showing

open Windows Terminal
maximized window
trigger fullscreen mode with F11
go to Windows Taskbar Settings and trigger on Automatically hide the taskbar in desktop mode
go back to Terminal and press F11 to exit fullscreen mode
a strange bar appears up to the title area, see this image:
zoom in and look at the area above Terminal and close button

(note that Windows Taskbar above already hided)
the bar has three tiny buttons: minimize, maximize and close, all are works.

sometimes after moving Terminal window or exit maximized status, that bar will disappear, but sometimes not.
if that bar does not disappear, Terminal cannot maximized to all area while the Windows Taskbar in auto hide mode
Expected behavior

no strange bar appear, and maximize the window properly
Actual behavior

sometimes cannot maximized Terminal with Taskbar autohided

Wow.. that is a weird one 😄 . Does not reproduce for me: instead I simply have an used area in under the window - where the taskbar used to reside. Few questions:

Is it 100% reproducible for you or happens occasionally?
To reproduce the issue do you wait for taskbar to disappear before exiting the fullscreen? Trying understand if there is a timing issue.
Any details about your setup: how many monitors, with what scaling? Trying to understand if there is a scaling issue.

Is it 100% reproducible for you or happens occasionally?
yes, it is 100% reproduce.
do you wait for taskbar to disappear before exiting the fullscreen?
yes, not time racing.everything happens flex
how many monitors, with what scaling?
two monitor, with same 100% scaling, resolution 1920*1080.
this happens on both monitor, but firstly I found it on the secondary one, then reproduce this on primary one too.
I have another PC, with same Windows version, but the Terminal is preview ver(1.5.3242.0). and same thing can be reproduced.

I remembered one step not listed, between step 2 and step 3, or say, before fullscreening Terminal, you need to open "Taskbar Settings" first.
after Terminal go to fullscreen, switch to that setting window by clicking Alt + Tab

Does not reproduce for me: instead I simply have an used area under the terminal window

for me, the taskbar is on the top of desktop

Does not reproduce for me: instead I simply have an used area under the terminal window

for me, the taskbar is on the top of desktop

I missed that "tiny" part. Was able to reproduce it with debugger attached.
Will try to take a look, unless the team has a direction.
IIRC there is some underlying window that is used for dragging - so my guess it is somehow not aligned with the island anymore.

@zadjii-msft - I see it is not the first issue with full screen and auto-hide taskbar that caused the windows to be not aligned:
void NonClientIslandWindow::_SetIsFullscreen(const bool fullscreenEnabled)
{
    IslandWindow::_SetIsFullscreen(fullscreenEnabled);
    if (_titlebar)
    {
        _titlebar.Visibility(_IsTitlebarVisible() ? Visibility::Visible : Visibility::Collapsed);
    }
    // GH#4224 - When the auto-hide taskbar setting is enabled, then we don't
    // always get another window message to trigger us to remove the drag bar.
    // So, make sure to update the size of the drag region here, so that it
    // _definitely_ goes away.
    _ResizeDragBarWindow();
}

@Don-Vito probably won’t be our last, either :smile: something about DwmExtendFrameIntoClientArea and WM_NCCALCSIZE occasionally make weird things like this happen :| and we haven’t quite nailed down all of them it seems!

What the dickens, that definitely repros for me. I have no idea why, but it's a real bug.
I'll throw it in with the rest of the window shenanigans tracked in #1625. Thanks!

@zadjii-msft - This definitely repros.. I tried to look at it and got a headache.. :smile: I will probably try to look at it again later on...

Good news everyone! Looks like this is resolved in recent Terminal builds. Not sure which exactly, but likely one of #11653 or #9737 fixed it. Thanks all!

@zadjii-msft its still happening for me on 1.20.11381.0. On fullscreen the bar gets smaller but is still there. It will only disappear when windowed. Padding is set to 0 in my settings.json.

@MarcoBuess And to confirm, you're using an auto-hiding, top taskbar as well? Windows version 19045?
This was closed out some 3 years ago now, it might be a recent regression, but I doubt that. We haven't done too much to mess with the windowing code over the last few releases. I also don't have a non-VM win10 machine handy with which to test easily 😕

@zadjii-msft Actually I did recently before upgrading to Windows 11, where I have the issue even without the hiding taskbar situation.


FIXME for various XSS vulnerabilities in github component

Not sure how to ask questions (no gitter room) or report issues. Are there any contribution guidelines for these PrimeFaces incubator components?
I'd have already provided a PR if it was clear where to place some common functionality like escaping HTML in javascript. primefaces-extensions.source.js? core.js? Just copy&paste it to all available versions? Then use it in all github.source.js versions?

-> GitterRoom: https://gitter.im/primefaces-extensions

Don't like monologues very much. :beer:

Hmm I am in that gitter room right now.  Let me invite you.

@cnsgithub When I try and add you to the the Extensions gitter it says "forbidden" when I try and add your user.

Maybee too evil? :cry:

So right now the current branch is based on PF Community 6.2.
Before 6.3.RC1 gets created then we move to 6.3 and update PFE I have this open ticket: https://github.com/primefaces-extensions/primefaces-extensions.github.com/issues/569

(i would this month with it, RC1 will be released in december)

Procedure:

Introduce escapeHTML function in PFE core.js.
Use newly introduced function in 0-jquery.github.js.
Add task to the TODO list so that the function can be reverted when switching to PF 6.3: primefaces-extensions/primefaces-extensions.github.com#569

@cnsgithub Let me cut a 6.2.X of PFE which will be the last 6.2 version and then I can bump /master to be on PF 6.3-SNAPSHOT so we can start converting to 6.3.  I will let you know when I make the changes should be this week sometime

Oops, just provided a PR: https://github.com/primefaces-extensions/core/pull/62.
It's up to you if you want to merge it before or after the PF rebase. Adjusting the PR for PF 6.3 should be straightforward: just turn calls to PrimeFacesExt.escapeHTML to PrimeFaces.escapeHTML and drop the first one.


Updated integrated themes indent guide colors

Fixes #8410

Coverage remained the same at 60.993% when pulling 26fd97bf346698c1069e435cc51231136f1f3770 on bgashler1:bgashler1/issue/8410/indentation-guides-colors into 954e737d4bc4d7802593c2589ae4305ffe3ff899 on Microsoft:master.

@bgashler1 The primary TM setting we are using for indentation guides is guide and invisibles is the fall back if guide setting is not set. invisibles is mainly used for rendering white spaces color. So, changing invisibles will also impact white spaces color. If it is intentional, then we also need to change it for our default themes (Dark, Dark+, High Contrast)
Indentation Guides

TM Setting : guide
Selector: .lines-content .cigr

White spaces

TM Setting : invisibles
Selector:  .token.whitespace

Moving this to September milestone, since it is too late to make into August

@sandy081 does this look right?

Coverage increased (+0.2%) to 61.186% when pulling 51c34e23af4fce59688d2eae87aaa75f56802224 on bgashler1:bgashler1/issue/8410/indentation-guides-colors into 954e737d4bc4d7802593c2589ae4305ffe3ff899 on Microsoft:master.

@bgashler1 LGTM


Add school Kvadraturen vgs

Kvadraturen skolesenter which was added due to beeing part of vaf does now have another
address. thereby renaming all addresses from @vaf to @kvadraturen.vgs.no
Agderskolen is for students, agderfk is the new vaf but teachers are assigned an address reflecting the working school. Kavdraturen vgs is a technical college.

@kvapehe Pull request merged. Thank you!


feat: carousel for resources on gallery detail

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Context

[x] Closes #5603

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality

Optional

[ ] I've tested it at </ksm/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at f754fbe
This pull request enhances the gallery item component to show the additional resources of the NFT in a carousel. It introduces a new custom type NftResources to represent the resources, and updates the useGalleryItem and useNft composables to handle the new type. It also modifies the GalleryItem.vue component to use the carousel and hide the fullscreen button if there are resources.

🤖 Generated by Copilot at f754fbe

To show more resources of an NFT
We added a carousel, you see
We used useNft
And changed ItemResources a bit
To make the types more consistent and pretty

@preschian yup, works

Hey I don't know if it's related but it's missing hover fullscreenn button on media

seems like there is no hover style even on canary or production?

Hey I don't know if it's related but it's missing hover fullscreenn button on media

seems like there is no hover style even on canary or production?

yes it do have the fullscreen button, i added it lol

and this fullscreen preview has different behavior with current one. but i think it's okay to merge this pr first, it can done in a separate pr.
https://user-images.githubusercontent.com/16473062/233821520-0bd24769-4179-4b2c-9e4e-bb6e45f44d89.mp4

noted, will check later. currently, the query seems didn't load on my end. stuck on loading

@preschian there was a service outage

https://github.com/kodadot/rubick/issues/256

full screen is not working how it should - missing button on hover and it triggers the full screen with a click on the img

full screen is not working how it should - missing button on hover and it triggers the full screen with a click on the img

yes. seems o-carousel got a default fullscreen behavior which is different to current. you may take a reference of #5321 i added.

functionality good - i will follow up with the stylign

pay 70 usd

😍 Perfect, I’ve sent the payout
💵 $70 @ 25.52 USD/KSM ~ 2.743 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0xafecdedeca3088e06a577137aa6b44d365693d2cbf5e90bf4e3b2c1d89f0028e
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


ConvSym: Sonic 3K Disassembly tests fail on FreeBSD-arm64

Investigate why  as_lst_legacy parser (as_lst prior to v.2.8)  for Sonic 3K Disassembly specifically seems to produce unexpected results.
Notice that FreeBSD uses a different standard library implementation. We may be dealing with UB case here.

False alarm. Tests were broken due to improperly unpacked archives. Files were physically corrupted.


Add audio example

Demonstrates usage of sdl.AudioSpec and sdl.AudioCallback to generate a sine wave tone.
Re: #127

Thanks for the example!


Communication between two sibling components in angular 2

I am right now working on angular 2. I found that the communication between the two sibling components or from child to parent is difficult. Even it was not mentioned in the angular 2 documentation. Would you please provide some information about it because the way two sibling components communicate is looking complex than the way a parent component communicates with its child using the 'ViewChild' decorator. But it is not possible to make a parent child relationship between two components always as per the project requirements.
Please find the below scenario of component tree.
A
/
B      C
/    \    /
D     E F    G
Here If I want to communicate between the components 'A' and 'B' then I can use 'ViewChild' decorator because they both are in parent child relationship.
If I want to communicate between the components 'B' and 'G' then How to do it? Because I can't impose parent child relationship between those two.
Would you pleas address the above issue.

https://angular.io/docs/ts/latest/cookbook/component-communication.html#!#bidirectional-service

I already read this..But this is not we want. Angular 2 documentation didn't mention properly about siblings communication except the communication thorough event emitting.
I saw in one video that angular 2 team is building production web sites already.

The documentation goes quite some length about using services to communicate. This is how it's done in Angular2 when the elements are not direct parent-child.

@zoechi  But this documentation  you posted: https://angular.io/docs/ts/latest/cookbook/component-communication.html#!#bidirectional-service
talks explicitly about 'Parent and children communicate via a service' and not sibling to sibling!
Is that link still correct?

Sibling to sibling is just two children communicating to the same parent (parent is mediator) or like two independent components using a shared service.
You can use a template variable to refer to a component on a sibling element from within the same template.
Perhaps it could be stated in the docs that there is no special support for sibling-to-sibling communication.

Implemented by using shared service. Look at the demo
https://embed.plnkr.co/P8xCEwSKgcOg07pwDrlO/

@chennamouli - I have implemented exactly similar as shown in demo. But in my project, only publisher component receives response from service. i.e. if sibling1 publish data then sibling1 will only get data back and if sibling2 publish data then sibling2 will receive data.
looks like each component is have its own instance of service. But its working in your demo. please help.

How can this work on  a routed component environment. In the above plunker example the app component template contains the child component selectors, that's why it's working, but in case I am using component router there will be no selectors present at the main AppComponent. Then how will it work?

i've the same situation too what Ayanb1991 is asked.. Please help.

@ayanb1991 @rajachennupati GitHub issues are for bug reports and feature requests.
For support questions please use other channels like the ones listed in CONTRIBUTING - Got a Question or Problem?

There should not be an issue with router. It is working fine in my application with router.

i ended up with no luck configuring shared service with router configuration in my app . @chennamouli  - could you please help with some demo how this works . thanks in advance .

@Jaithra
GitHub issues are for bug reports and feature requests.
For support questions please use other channels like the ones listed in CONTRIBUTING - Got a Question or Problem?

Creating a service for passing a height of an element, from one sibling to another, is such an over kill.. Makes me miss jQuery. Ng team needs to offer a solution for that. Accessing DOM properties of siblings is a very common task.

I stumbled upon this issue and could think of this solution:

  <menu [panel]="panel"></menu>
  <panellisting #panel></panellisting>

Then in menu component make panel to be an @Input():
export class MenuComponent implements OnInit {
    @Input() panel: any;
    ...
}

From this moment on I could access all panel component functions/properties from within menu component.
I suppose you can always try to do the vice-versa, not sure if this is correct or has performance impact though.

is there a working solution for this yet? i have a scenario where i have two components A and B
in my view there are 5 As and each do the same task say calculate a price although for different item at different rates and then B consolidates and all of A's data and project it. i have  a setup like this

  <app-header></app-header>

          <app-stat-card title= {{resource}} *ngFor="let resource of resources">  </app-stat-card>

      <app-overall-stats-card></app-overall-stats-card>

the only value passed from A to B is "price", a single variable. creating service for this is, as @neoswf  suggested overkill. kindly let us know how to do it. I think this needs to be a feature request.

is there a working solution for this yet? i have a scenario where i have two components A and B
in my view there are 5 As and each do the same task say calculate a price although for different item at different rates and then B consolidates and all of A's data and project it. i have  a setup like this

  <app-header></app-header>

          <app-stat-card title= {{resource}} *ngFor="let resource of resources">  </app-stat-card>

      <app-overall-stats-card></app-overall-stats-card>

the only value passed from A to B is "price", a single variable. creating service for this is, as @neoswf  suggested overkill. kindly let us know how to do it. I think this needs to be a feature request.

@Ragzzy-R  Here the components A and B must be the child components of some other component(parent) right? So you can consolidate all the data in that parent component and can pass it as input parameter to component B. Does that solves your problem?

ya that might work. but i was wondering if we could cut short parent's intervention. is it a design decision to always have parent as mediator?
also since each  is independent, how do u keep track of all of their data? each app-stat-card changes value of "price" independent to each other at random times. how do I keep track of them? i know i can get their data but what i want is at any given time if the price is $100 i need to know from which stat-card that came from. It may be silly but im too new. if its not advisable to talk about troubleshooting/help in issue tracker, you can mail me to<EMAIL_ADDRESS>thanks! :smile:

Hey guys, I am going to close this issue. Let's continue our discussion in stackoverflow.com or gitter as that is suggested by angular team. Happy coding('.')


PostgreSQL persistence: Unable to shard 'queue_message' table using Citus

I am using PostgreSQL and trying to shard the tables using Citus extension on PostgeSQL. I have hit a road block as I am unable to shard 'queue_message' table (which I believe is the 'queue_name' column is the table that needs to be distributed in the Postgres cluster or have I erred here?). I get the below error when I try to distribute the table
postgres=# SELECT create_distributed_table('queue_message', 'queue_name');
ERROR: cannot create constraint on "queue_message"
DETAIL: Distributed relations cannot have UNIQUE, EXCLUDE, or PRIMARY KEY constraints that do not include the partition column (with an equality operator if EXCLUDE).
It appears that Citus doesn't allow sharding on column that's not part of UNQIUE or PRIMARY key constraints. This table has "id" as primary key. It would be of great help if someone can let me know if I am on the right track and how do I go about distributing data using PostgreSQL.

Hey @mactaggart, @marosmars Is this something you can help with? Thanks!

@raghavendra-bhat I've not used Conductor with Citus, however, I suggest trying the 'id' column instead of 'queue_name' since it's the primary key. Other tables also use 'id' as the primary key, so they could be sharded by id as well. Let me know if that works.

@mactaggart Nope, using 'id' also has the same issue as it needs to be part of unique key constraints.
postgres=# SELECT create_distributed_table('queue_message', 'id');
ERROR:  cannot create constraint on "queue_message"
DETAIL:  Distributed relations cannot have UNIQUE, EXCLUDE, or PRIMARY KEY constraints that do not include the partition column (with an equality operator if EXCLUDE).


[UIE-120] Use Terra-ui useThemeFromContext instead of colors

Jira Ticket: https://broadworkbench.atlassian.net/browse/UIE-120

Summary of changes:

What

Replaced src/libs/colors with useThemeFromContext from @terra-ui-packages/components

Why

I am working on porting notifications to packages.

Testing strategy

[ ]

It looks like this also contains changes from another PR: #4601

Yeah, I made this branch off of the branch in that PR (since it's the same file) while I was waiting for the other to get approved.

FYI, if you don't want the other PR's changes to show up in the diff here, you can set this PR's base branch to the other PR's branch.

FYI, if you don't want the other PR's changes to show up in the diff here, you can set this PR's base branch to the other PR's branch.

Thank you. That's a great suggestion.


Start process in background

Before starting to inference, we need to start a server, this server will be started and ran in background

PR: https://github.com/janhq/cortex/pull/1043


Add Identity-H/V cmap support for PDFCIDFont

thanks, unfortunately it doesn't fix my problem with (cid:49)(cid:52)(cid:56)(cid:44)(cid:56) instead of text
wfirma_Faktura_FV_1_2021.pdf
Originally posted by @areqq in https://github.com/pdfminer/pdfminer.six/issues/598#issuecomment-826830234

Hi,
Is there any documentation of how to use this feature?

issue-625-identity-cmap.pdf
unfortunately it doesn't fix my problem


Correction for raw affiliation UMR PHIM - Plant Health Institute of Montpellier (CIRAD Campus International de Baillarguet TA A-54/K
34398 Montpellier

France)

Correction needed for raw affiliation UMR PHIM - Plant Health Institute of Montpellier (CIRAD Campus International de Baillarguet TA A-54/K
34398 Montpellier

France)
raw_affiliation_name: UMR PHIM - Plant Health Institute of Montpellier (CIRAD Campus International de Baillarguet TA A-54/K
34398 Montpellier
France)
new_rors: 03fkrcm40;05kpkpg04;05y5s3h28
previous_rors: 03fkrcm40;05kpkpg04
works_examples: W3206079910
contact: 45802525fbba8d05d84e92ad001b44be:0ee5147769e44a1aa4376446118dc90e77aa @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


Phase 1 & Phase 2 not fully utilize CPU on CPU with NUMA Node

Hi,
I'm using:
AMD Threadripper 2990wx with 32 Core and 64 Thread.
Ram 128 GB
Temp1: 5xNVMeSSD Raid0
Temp2: Ramdisk
t = 32, u = 256
We have talk about this on discord that It might be temp2 bottleneck.
But I also try this on 5xNVMe SSD Raid0 and got the same Phase 1 plot time and CPU utilization.
With the new update my Phase 3 time already reduce by 55%!. So I wonder if Phase 1 suffer the same problem of Phase 3 that cause by NUMA node or It's really temp2 bottleneck.
I also attach screenshot when I ran plotter with top -H.

you can try -r 64 and/or -u 512

Here the result of plotting with -r 64 and -u 512
-u 512 make Phase 3 slower but Phase 1 and Phase 2 remain nearly the same.

none of those threads are even close to 100% cpu, not sure what's going on there...

I have nearly an identical build and am experiencing the same thing:
TR 2990wx (OC'd to 4ghz)
128G ram @ 3200 in a 4x32G configuration (even though it's rated at 3600 it becomes unstable, think it's CPU bus related as mem test all come back 100% happy)
2xPCIE NVME raid0 (never hits higher than 80% load)
OS Ubuntu 20.04 LTS
Flags:  256 buckets, 24 threads, ram for temp2
I'm running the ram in "channel" mode.

my 5950 (12c 24t) shows same/similar. If I go above -r 12 plotting takes longer. Using -r 12 in phase 1-2 I see maybe 50% usage across the board (with some 100% spikes)

my 5950 (12c 24t) shows same/similar. If I go above -r 12 plotting takes longer. Using -r 12 in phase 1-2 I see maybe 50% usage across the board (with some 100% spikes)

How much is your ram? Do you use RAM disk? Linux? I have a friend who use 5950x and can plot in 12XX s!

I have nearly an identical build and am experiencing the same thing:
TR 2990wx (OC'd to 4ghz)
128G ram @ 3200 in a 4x32G configuration (even though it's rated at 3600 it becomes unstable, think it's CPU bus related as mem test all come back 100% happy)
2xPCIE NVME raid0 (never hits higher than 80% load)
I'm running the ram in "channel" mode.
OS Ubuntu 20.04 LTS
Flags: 256 buckets, 24 threads, ram for temp2

Do have screenshot of top -H when plotter in phase 1? my ram bus is 2800 MHz I want to know if it make a huge difference.

none of those threads are even close to 100% cpu, not sure what's going on there...

I'm not C and C++ programmer but will profiling help find the problem? maybe I can profile a plotter and give a result for you to check.

I have nearly an identical build and am experiencing the same thing:
TR 2990wx (OC'd to 4ghz)
128G ram @ 3200 in a 4x32G configuration (even though it's rated at 3600 it becomes unstable, think it's CPU bus related as mem test all come back 100% happy)
2xPCIE NVME raid0 (never hits higher than 80% load)
I'm running the ram in "channel" mode.
OS Ubuntu 20.04 LTS
Flags: 256 buckets, 24 threads, ram for temp2

Do have screenshot of top -H when plotter in phase 1? my ram bus is 2800 MHz I want to know if it make a huge difference.

I noticed a significant difference when bumping from 3000Mhz to 3200Mhz.  I think I dropped 7-8 minutes per plot when I was running at 3400Mhz.  Unfortunately I started to get IO errors.  My guess is, as indirectly stated earlier, the CPU can't keep up with the higher than 3200Mhz bus speed.
Honestly I'm impressed you are seeing 1800s @ 2800Mhz.  You should see quite a significant increase if you bump your ram frequency.
What board are you using?  Asus rog strix X399-E here.
Screenshots of top -H with -t 32 -u 256 below:

Chia k32 plotter - 48b4f0c (2990wx 128GB t 32 u 256 in Phase 1 Table 4)

Chia k32 plotter - 48b4f0c (2990wx 128GB t 32 u 256 in Phase 2 Table 5)

my 5950 (12c 24t) shows same/similar. If I go above -r 12 plotting takes longer. Using -r 12 in phase 1-2 I see maybe 50% usage across the board (with some 100% spikes)

How much is your ram? Do you use RAM disk? Linux? I have a friend who use 5950x and can plot in 12XX s!

32 gb ddr at 4000, not enough ram for a ram  disk (needs 128+ right), I'm in the 4xxx + s area, I am using pcie 4 nvme drives (temp 1 and temp 2)