Update software stack -- and start geo-deep-learning release numbering

We should update to:

PyTorch 1.0
Python 3.7

See how we can benefit from using Caffe2 now on AWS ?
Once that's done, let's tag our first GDL v. 1.0

Some inter-type operations (e.g. *) between torch.Tensors and NumPy arrays will now favor dispatching to the torch variant. This may result in different return types. (#9651).
Pytorch 1.0.0 Release Notes

Because of this, in the training and classification steps, we will need to transfer our tensors to the CPU before converting them into numpy arrays using Tensor.cpu(). This will need to be done in metrics.py and in image_classification.py:
metrics.py
56    class_report = classification_report(label.cpu(), pred.cpu(), output_dict=True)
78    iou = jaccard_similarity_score(target.cpu(), pred.cpu(), normalize=True)

image_classification.py
158   output_np[row_from:row_to, col_from:col_to, 0] = useful_classification.cpu()

If we upgrade to Python 3.7, other packages will need to be updated in our environment:

gdal: version 2.2.2 doesn't support Python 3.7. We could upgrade to the most recent version 2.4.0. I did some quick tests with Python 3.7 and gdal 2.4.0 and didn't have any issues. Further validations will have to be done.
h5py: the 2.8.0 version build that we currently are using py36h39dcb92_0 isn't compatible with Python 3.7. We could update to a more recent build or to the 2.9.0 version which supports Python 3.7. The updates between versions shouldn't affect us.

TL;DR
I think we all agree migrating to PyTorch 1.0 is a must.  Migrating to Python 3.7, however, is not a must but we should do it.
Details
My base rationale for migrating to 3.7 is that:

3.6 is already 3.5 yrs old, with the lastest release being 3.6.8 in Dec. 2018 and 3.6.9 announced as "Security fixes only"; "3.6 will receive bugfix updates approximately every 3 months for approximately 24 months. After the release of 3.7.0 final, two more 3.6 bugfix updates will be released. After that, it is expected that security updates (source only) will be released until 5 years after the release of 3.6 final, so until approximately December 2021."  So in a nutshell, 3.6 is now in bugfix mode
3.7 has been developed for close to 2.5 yrs and is already at point release 3.7.2 with 3.7.3 expected end March 2019.  As for 3.6, 3.7's life cycle is tied to the next major release : "3.7 will receive bugfix updates approximately every 1-3 months for approximately 18 months. After the release of 3.8.0 final ..."  3.8.0 is expected to be released end Oct. 2019

What's new and better
The "What's new" page list bugfixes and enhancements with respect to 3.6.  I guess easier debugging might be interesting for us.  Other potentially interesting modficications for us include:

argparse
itertools
sqlite3 : useful for opening GeoPackage files ?
"Various optimizations have" : reduced Python startup time by 10% on Linux ... Method calls are now up to 20% faster ... sorted() and list.sort() have been optimized for common cases to be up to 40-75% faster ... dict.copy() is now up to 5.5 times faster ... the creation of named tuples 4 to 6 times faster. ... os.fwalk() function is now up to 2 times faster ... The speed of comparison of array.array instances has been improved considerably in certain cases. It is now from 10x to 70x faster ...

It does not look like there are huge departures from 3.6 that may affect us.
As far as dependent libraries are concerned, here is a table of the main "non standard" imported modules in both our current Python 3.6 (PyTorch 0.4.1) environment and a Python 3.7 environment with their supported versions as available from conda install.  Newer versions are in bold.

Note: all standard modules, like os,  subprocess, argparse, fnmatch, etc. obviously inherently supported Python 3.7

module
3.6 env
3.7 env

pytorch
0.4.1
1.0.0

cuda 9.0.176
cuda 9.0.176

cudnn 7.1.2_2
cudnn 7.4.1_1

[lib]gdal
2.2.4
2.4.0

geos
3.6.2
3.7.1

h5py
2.8.0
2.9.0

hdf5
1.8.18
1.10.4

libtiff
4.0.9
4.0.10

numpy
1.15.4
1.15.4

proj4
5.0.1
5.2.0

ruamel_yaml
0.15.46
0.15.46

scikit-image
0.14.1
0.14.1

scikit-learn
0.20.2
0.20.2

scipy
1.1.0
1.2.0

torchvision
0.2.1
0.2.1

Potential issues for us
New library versions in bold above may introduce issues in the code.  Starting from the top:

pytorch: whatever the issues we migrate
gdal: GDAL releases show that 2.2.4 was released on March 22, 2018.  2.3.0 was released in May and 2.4.0 in Dec 2018.  There does not seem to be severe backward incompatibilities that we should be worried about;  most drivers were improved, including the two most important ones for us: GTiff and GPKG

We should check potential libraries we are likely to import later that depend on GDAL, e.g. rasterio, are OK

geos: this module is not imported directly in geo-deep-learning; no expected issues
h5py: looks like there are a few interesting enhancements we could use for us, especially given ticket #51.
hdf5: Since 2.8, h5py is built against HDF5 1.10.x; however in our current environment we only have HDF5 1.8.18; there should be goodies in HDF5 1.10.4
One such functionality : SWMR: "Data acquisition and computer modeling systems often need to analyze and visualize data while it is being written. It is not unusual, for example, for an application to produce results in the middle of a run that suggest some basic parameters be changed, sensors be adjusted, or the run be scrapped entirely. To enable users to check on such systems, we have been developing a concurrent read/write file access pattern we call SWMR (pronounced swimmer). SWMR is short for single-writer/multiple-reader. SWMR functionality allows a writer process to add data to a file while multiple reader processes read from the file."  Maybe quite important in the context of #55.
Another is Virtual Datasets (VDS)
libtiff: no surprises expected here except better performances
proj4: 5.2.0 was released in Sep.2018; 5.0.1 was released in March 2018, but is only in bugfix mode.  We should definitely go to 5.2.0
scipy: 1.2.0 released Dec 2018; we use scipy.stats for which there have been improvements in 1.2.0 since scipy 1.1.0 (May 2018)

As long as we install rasterio through the conda-forge channel, there don't appear to be any issues with dependencies.
We can use the tests_python3_7 environment in order to test how the stack update affects our deep-learning program. So far I haven't found any issues or modifications that we need to make other than explicitly moving tensors to the CPU before converting to numpy as mentioned above.

@epeterson12  - Concerning the "moving tensors to the CPU before converting to numpy"; Would it be possible to use built-in functions of PyTorch to calculate our metrics (e.g. replicate the classification_report functions, using PyTorch functions)?
1- Are those functions available in PyTorch 1.0?
2- Would it be wise to implement them, if not?

In metrics.py, I don't see an alternative to transferring tensors over to the cpu manually since the operations where we directly convert cuda tensors to numpy arrays are sklearn functions and sklearn doesn't support GPU operations. Unlike other deep learning packages like TensorFlow, Pytorch doesn't have an alternative for training metrics.
Since the behavior in releases prior to 1.0.0 was to transfer tensors to the cpu implicitly before converting them to numpy arrays, converting them explicitly shouldn't affect the efficiency of our program.
I don't think we would gain much by implementing them.

I am running into problems with undefined symbols when trying to use caffe2 for training models and for inference. There seem to be some dependency issues when using gdal and onnx (the intermediate step between pytorch models and caffe2 models). Once I installed the onnx package, I started getting this error while trying to import gdal:
ImportError: [...] python3.7/site-packages/osgeo/../../../libgdal.so.20: undefined symbol: _ZNK6libdap5Error17get_error_messageB5cxx11Ev

Once the cause and/or workaround is identified, I will update this comment with the fix.

Done with v1.0


Execution failed for task ':agora_rtc_engine:compileDebugKotlin'.

I have same issue.
e: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraTextureViewFactory.kt: (17, 3): 'create' overrides nothing
FAILURE: Build failed with an exception.
What went wrong:
Execution failed for task ':agora_rtc_engine:compileDebugKotlin'.
Compilation error. See log for more details
Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
Get more help at https://help.gradle.org/
BUILD FAILED in 40s
Exception: Gradle task assembleDebug failed with exit code 1

Seems related issue https://github.com/AgoraIO/Agora-Flutter-SDK/issues/623

are you on flutter dev channel?
If so, switching to the stable channel solved the problem for me

I'm facing same issue, after upgrading to flutter latest stable version 3.0.0 & agora latest version 5.1.0
Here is the log
e: /flutter/.pub-cache/hosted/pub.dartlang.org/agora_rtc_engine-5.1.0/android/src/main/kotlin/io/agora/agora_rtc_engine/AgoraRtcEnginePlugin.kt: (251, 18): Type mismatch: inferred type is String? but String was expected
e: /flutter/.pub-cache/hosted/pub.dartlang.org/agora_rtc_engine-5.1.0/android/src/main/kotlin/io/agora/agora_rtc_engine/AgoraSurfaceViewFactory.kt: (16, 1): Class 'AgoraSurfaceViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Context?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory
e: /flutter/.pub-cache/hosted/pub.dartlang.org/agora_rtc_engine-5.1.0/android/src/main/kotlin/io/agora/agora_rtc_engine/AgoraSurfaceViewFactory.kt: (20, 3): 'create' overrides nothing
e: /flutter/.pub-cache/hosted/pub.dartlang.org/agora_rtc_engine-5.1.0/android/src/main/kotlin/io/agora/agora_rtc_engine/AgoraTextureViewFactory.kt: (12, 1): Class 'AgoraTextureViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Context?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory
e: /flutter/.pub-cache/hosted/pub.dartlang.org/agora_rtc_engine-5.1.0/android/src/main/kotlin/io/agora/agora_rtc_engine/AgoraTextureViewFactory.kt: (17, 3): 'create' overrides nothing

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':agora_rtc_engine:compileDebugKotlin'.
> Compilation error. See log for more details

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 32s

This error started when I upgraded flutter to 3.0.0
I've downgraded flutter to 2.10.5 and It's working fine now.
1- Download flutter 2.10.5 from https://docs.flutter.dev/development/tools/sdk/releases

2- Edit environment variables pointing to your flutter 2.10.5 folder

3- Execute some commands to test solution
flutter channel stable
flutter --version
flutter build apk --debug
flutter build apk --profile
flutter run

or just use flutter downgrade v2.10.5 in the terminal


Switch more recipes to use oredict materials.

Similar to d81215d This PR switches the remaining recipes to use oredict materials instead of just the vanilla dyes.

Implemented in 1.2.0


mount fails when sudo is unavailable

tested and pod was created/deleted successfully with secret mounted
fixes: https://github.com/Azure/kubernetes-keyvault-flexvol/issues/25
I'm not too familiar with flexvolumes yet. But, there is rm ${MNTPATH}  and ls ${MNTPATH} without sudo farther down in the script. So I'm assuming this is run with root privileges.
Thanks!

Thanks for the contribution @hmm01i 🎉


feat(color-palettes): removed unused color palettes

Summary
Old/unused color  palettes removed:
default
rainforest
gentletouch
savannahsunrise
crystalcavern
magenta
magentanight
braziliansunrise
tequilasunrise
eveninghorizon
energizing
cherryblossom
springgreen
ADO Story
https://dev.azure.com/Kyndryl/Shidoka - Bridge Design System/_workitems/edit/1931294
Checklist

[x] Used Conventional Commit messages as outlined in the contributing guide.

[x] Noted breaking changes (if any).

[x] Documented/updated all props, events, slots, parts, etc with JSDoc.

[x] Ran the analyze command to update Storybook docs.

[ ] Added/updated Stories with controls to cover all variants.
[ ] Ran test locally to address any failures.
[ ] Added/updated the Figma link for the Story's Design tab.
[ ] Added any new component exports to the src/index.ts file
[x] Added Migration Guide mdx docs

When you squash merge, include the list of removed palettes in the BREAKING CHANGE: commit footer.

Still need to add the breaking change notes to the migration guide. I think you'll need to create that MDX file actually, copy how it was done in shidoka-appplications.

You can squash merge this and include the BREAKING CHANGES: footer in the github textarea.

:tada: This PR is included in version 1.7.0-next.1 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix bug with sending expired session ids

These changes fix a bug where we incorrectly send the wrong session id on the first request after a session has expired due to the session cookie persisting for a very long time.
Most of the additions are to fix a bug that pops up after expiring the session cookie where we need to keep the old session id to terminate the session.

Hi @OsvaldoRosado, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Osvaldo Rosado). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@OsvaldoRosado, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

These new commits address your comments @MaxShehovtsov @ameyagholkar @olegsych @AlexBulankou

LGTM

:sheep: :+1:


rework how to not prompt for task execution when automatically invoked

https://jira.ewr01.tumblr.net/browse/GEN-43
This time we will just suppress prompting for unreasonable prompt is given
This eliminates trying to guess of a person typed the command or not,
plus we can now set the default prompt timeout value in the config file!
@Primer42 @byxorna @defect @maddalab

FYI, I've updated collins test ipxe image with the new genesis-scripts RPM.

tested on and asset.
@Primer42 @byxorna @defect @maddalab rfr


sun hack

plain char is signed on Oracle's IX86-based hardware (and legacy x86 Sun workstations) just like every other OS that runs on the Intel Pentium Pro, but compilers on this platform do not treat plain char as a type distinct from signed /unsigned char such that int8_t and char resolve to the same type, triggering an error in compilation

This change is

Why does this need to be part of cxxopt?
It seems like a bad idea to preprocessor-define an identifier which is a standard C type.

yeah i left this hanging a while back and forgot about it, sorry

for reference this is what Netscape said about this some 20 years back:
/*
** There are two scenarios that require us to define PRInt8 as type 'char'.
** (1)
** Some cfront-based C++ compilers do not like 'signed char' and
** issue the warning message:
**     warning: "signed" not implemented (ignored)
** For these compilers, we have to define PRInt8 as plain 'char'.
** Make sure that plain 'char' is indeed signed under these compilers.
** (2)
** Mozilla C++ code expects the PRInt{N} and int{N}_t types to match (see bug
** 634793). If a platform defines int8_t as 'char', but NSPR defines it as
** 'signed char', it results in a type mismatch.
** On such platforms we define PRInt8 as 'char' to avoid the mismatch.
*/


[SFS] Improve list of keywords / descriptors

Description of the issue
The current list of keywords in the study factsheet template ist a proposal and needs improvement.
Factsheet
Study / Scenario
Field
Keywords, see Documentation
Ideas of solution
Please add keywords that are missing to describe your study / scenario in the list below.
Please comment on whether the keywords are helpful or not, and what your ideas for improvement are.

descriptor
source
factsheet
oeo id/label or issue#

carbon neutrality
ÖI
study
https://github.com/OpenEnergyPlatform/ontology/issues/1392

negative emissions
ÖI
study
OEO_00000293 (negative emission)

study fulfills a legal obligation (e.g. it is the projection under the MMR or part of the NECP)
ÖI
study
tbd

Transformation Pathways
RLI
study
tbd

Share of renewables
RLI
study
OEO_00140133 (RE-share)

Flexibility
RLI
study
https://github.com/OpenEnergyPlatform/ontology/issues/1549

Efficiency
RLI
study
OEO_00140050 (efficiency value) or OEO_00140049 (energy conversion efficiency)

resilience
oekg
study
https://github.com/OpenEnergyPlatform/ontology/issues/1550

life cycle analysis
oekg
study
https://github.com/OpenEnergyPlatform/ontology/issues/1551

CO2 emissions
oekg
study
OEO_00260007 (CO2 emission)

Greenhouse gas emissions
oekg
study
OEO_00000199 (greenhouse gas emission)

Reallabor
oekg
study
tbd

100% renewables
oekg
study
tbd

acceptance
oekg
study
https://github.com/OpenEnergyPlatform/ontology/issues/1552

sufficiency
oekg
study
https://github.com/OpenEnergyPlatform/ontology/issues/1553

(changes in) demand
oekg
study
OEO_00140146 (energy demand)

degree of electrifiaction
oekg
study
https://github.com/OpenEnergyPlatform/ontology/issues/1434

regionalisation
oekg
study
https://github.com/OpenEnergyPlatform/ontology/issues/1554

total gross electricity generation
oekg
study
OEO_00240012 (gross electricity generation)

total net electricity generation
oekg
study
tbd

peak electricity generation
oekg
study
tbd

grid restrictions
oekg
study
tbd

grid / infrastructure extension
oekg
study
tbd

sector coupling
oekg
study
https://github.com/OpenEnergyPlatform/ontology/issues/1521

scenario comparison
oekg
study
tbd

Scenario subclasses
SIROP
scenario
https://github.com/OpenEnergyPlatform/ontology/issues/1329

It's not entirely clear to me what the keywords refer to. I found it not straight forward to select the included technologies, i.e. should I select that in the:

sector
energy carriers
energy transformation process
all of the above

It feels to me like the latter would be correct. Our scenario includes the following technologies: PV, wind, biomass, biogas, solar thermal, heat pump, gas, coal, oil, CHP, electricity, gas, heat. As the non expert user I am, I would expect all of those to be keywords for our study/scenario, but I found it difficult to map them all with clarity and the impression that I need to sort of split them into those categories is an additional factor of confusion for me.
I realize that this is a complex task, but ideally the interface would guide the user to differentiate the categories above or auto-suggestion related fields. Can anyone anyone describe a clear separation to me? Also, how accurate is my impression, that a list like the above mentioned categories should be a part of every scenario description? If it applies, then it may be worth putting some effort in a simple interface.

Notes from the SIROP project meeting on 25th of april:

rename keywords to "descriptors"
descriptors for studies and scenarios separately, no overlaps (looks redundant, not visually appealing)
restict descriptors for scenarios to OEO scenario subclasses:  refrence scenario, ambitious, proressive, conservative, target, explorative... see https://github.com/OpenEnergyPlatform/ontology/issues/1329
first set of descriptor terms tbd until 5th of may @l-emele @christian-rli  @Ludee @u-mueller . @han-f gets a personal deadline: 16th May
additional to the set of descriptors: autocomplete search bar for (some) OEO terms

Here is a short list with further descriptors:

carbon neutrality
negative emissions
scenario fulfills a legal obligation (e.g. it is the projection under the MMR or part of the NECP)

I'm not a modeller, but I feel some relevant missing information are types of categorization that I keep hearing, but that I don't seem to find in the Factsheets so far:

perfect foresight
linear optimization
mixed integer optimization

I'm not a modeller, but I feel some relevant missing information are types of categorization that I keep hearing, but that I don't seem to find in the Factsheets so far:

perfect foresight
linear optimization
mixed integer optimization

Do these really belong in the scenario factsheets? Looks more like things for the model factsheets.

* scenario fulfills a legal obligation (e.g. it is the projection under the MMR or part of the NECP)

@l-emele this sounds like a descriptor to a scenario, not a study. Right? For scenario descriptors, we agreed to only allow scenario subclasses. Can this be "translated" into a scenario subclass?
While searching the suggested descriptor terms in the OEO, I found the following terms that might suit as well. Can you please give feedback @l-emele @christian-rli @han-f  @Ludee @u-mueller Thanks!

decarbonisation pathway
energy import / export
mobility
CSS
model comparison
sensitivity analysis

I added the existing and newly suggested descriptors to the table above. Thus, we can keep overview of what we have already, and what not. Once, we agreed on a final-for-now list in this issue, I'll transfer the table to the OEO repo.

scenario fulfills a legal obligation (e.g. it is the projection under the MMR or part of the NECP)

@l-emele this sounds like a descriptor to a scenario, not a study. Right? For scenario descriptors, we agreed to only allow scenario subclasses. Can this be "translated" into a scenario subclass?

Ok, then what about: study (report) fulfills a legal obligation?

CSS

What is CSS?

sensitivity analysis

Why do we need this as a descriptor when it is already a part of the scenario information?

Sorry, typo. CCS

Why do we need this as a descriptor when it is already a part of the scenario information?

What do you mean by "scenario information"?

As part of the scenario part of the factsheets it was foreseen to enter information on sensitivity analyses. So I don't think we should additionally have sensitivity analysis as descriptor.

All of the following are processes that are modelled:

negative emissions
CO2 emissions
Greenhouse gas emissions
(changes in) demand
energy import / export
CCS

Maybe we need not only a selection field for energy transformation processes but also a field for something like: other processes modelled.

Jumping into this with some delay, I am not really sure I am up to speed. From an outsiders perspective I think it would be helpful for readers of factsheets to have some very broad keywords/tags that help them understand the overall context of a study / scenario. I was under the impression that this was, what the original "keywords" wanted to do.
Now we moved to a more detailed approach with connection to OEO. This is in my eyes helpful because it provides the mapping to the OEO and thus consistency, but at the same time it limits users to what is available in the OEO.
Would it maybe make sense to add these descriptors and additionally also allow users to provide their own set of (freely input) keywords to their factsheets? This may add flexibility. If the input field for such freely input keywords would also have the possibility to show already existing user-generated keywords, this may possibly help to limit the inputs as new users may orient themselves on what is already there and fits their context, too.

Would it maybe make sense to add these descriptors and additionally also allow users to provide their own set of (freely input) keywords to their factsheets? This may add flexibility. If the input field for such freely input keywords would also have the possibility to show already existing user-generated keywords, this may possibly help to limit the inputs as new users may orient themselves on what is already there and fits their context, too.

Thanks for the input @han-f  We discussed this during the project meeting. ovgu is quite reluctant regarding freetext entries. In the end we found that there is still the abstract field for freetext description where these terms could occur.
If we see that this is not enough, we can still improve the descriptors at a later state.
Is this a solution that you can go with?

I discussed this topic on friday bilaterally with @u-mueller. We came to the conclusion, that currently on of the most important points, the research question(s) of the study and the scenarios, of the scenario are not properly depicted in the OEKG. I mention this here, because if we interpret the keywords as additional descriptors, then we need to find a way to depict the research question with ontology terms.

Why do we need this as a descriptor when it is already a part of the scenario information?

What do you mean by "scenario information"?

As part of the scenario part of the factsheets it was foreseen to enter information on sensitivity analyses. So I don't think we should additionally have sensitivity analysis as descriptor.

I am not aware that we've included it yet. If I am wrong please indicate where...
The plan is, that the scenario part will just have the scenario subclasses as selectable options.

@christian-rli @l-emele @u-mueller @han-f Thanks for checking. Is the list above ok for you for a first version?

The above list looks like a good first version to me. I approve :)

Shall we also add

sector coupling
scenario comparison

?

network development

Is that the same as grid exteansion, see table?

Is that the same as grid exteansion, see table?

Yes, sorry, it is more or less the same, maybe we can use network development and also grid expansion as alternative labels.

Ok, I updated the table above.
Feel free to open issues in the oeo repo for the missing terms and link them above.

@han-f @l-emele The descriptor "study fulfills a legal obligation (e.g. it is the projection under the MMR or part of the NECP)" came from you. Would a solution be to add a scenario subclass instead of a study descriptor, e.g. legal obligation scenario?

@christian-rli @chrwm the descriptor "Transformation Pathways" came from RLI. Is decarbonisation pathway a feasible alternative, or do you want to include a separate concept?

@han-f @l-emele The descriptor "study fulfills a legal obligation (e.g. it is the projection under the MMR or part of the NECP)" came from you. Would a solution be to add a scenario subclass instead of a study descriptor, e.g. legal obligation scenario?

I would rather see this as a subclass of study report. E.g. the projections reports are study reports that contain scenarios and fulfil legal obligations.

@han-f @l-emele The descriptor "study fulfills a legal obligation (e.g. it is the projection under the MMR or part of the NECP)" came from you. Would a solution be to add a scenario subclass instead of a study descriptor, e.g. legal obligation scenario?

I would rather see this as a subclass of study report. E.g. the projections reports are study reports that contain scenarios and fulfil legal obligations.

I agree with @l-emele

Is it possible to add an oekg relationship like "is_descriptor"? This would help me to retrieve all current descriptors.
As it is currently, I think I need to keep a static list of all descriptors as defined in the table above. If the list changes, we have to update the list manually. This is not what we want to have. It would be better if we could "register" a new descriptor in the oekg / oeo and then provide a code that retrieves all descriptors.
Or am i missing something?
@adelmemariani @l-emele @stap-m

How are the descriptors currently stored in the OEKG?

As far as i can see they are only stored in the oekg once they have been selected by the user during scenario bundle creation.
descriptor = URIRef(descriptor["class"])
bundle.add(
    (scenario_URI, OEO["has_scenario_descriptor"], descriptor)
)

The list of the availabe descriptors itself is currently hardcoded like this:
https://github.com/OpenEnergyPlatform/oeplatform/blob/9cc259248fa2708ed5ee3f8a7acfeab892499e20/factsheet/frontend/src/components/factsheet.js#L272-L311

Hm okay, since the code isnt clear without some further investigation im not sure if the study factsheet (=scenario bundle) descriptor will be saved at all because the code mentions the scenario insted of the scneario bundle ID. I will have another look at it.

There it is, its saved with relation to the scenario bundle as I thought once the user selects & saves it:
bundle.add((study_URI, OEO["has_study_keyword"], Literal(keyword)))

We already had for a different use case to include oekg specific annotations (not relations) in the oeo, see https://github.com/OpenEnergyPlatform/ontology/issues/1529. We might use that.

Sound intresting to make this more clear: then there would be an anotation like OEO_00020005:"study_factsheet_descriptor=true"?  This would definately help to automatically create a list of all availabe descriptors from the oeo.

What I head in mind with my latest proposal in the OEO issue would lead to:
Class: OEO_00020009
    Annotations:
        oekg_annotation "descriptor"

That sounds very good, as long as all "descriptors" are "study descriptors". I don't know if there are any other use cases for descriptors annotations in the oeo (I'm not sure what might apply here e.g. "scenario descriptors").


Provide a terms of use for the GC Design System

Create a terms of use that outlines how users can use the product, what is acceptable and not. e.g. Cannot impersonate a GC website.
Acceptance Criteria

Generated by Zenhub AI

[ ] Scenario: Terms of Use for GC Design System

Given a terms of use document is created

When the user reads the terms of use

Then they should understand how to properly use the GC Design System, what is acceptable and not.

[x] Draft

[x] Reviewed by team members, support, policy

[x] Sent to translation

[ ] Published

https://docs.google.com/document/d/1v3gzPSczTnc5vqPuvr57ATqWXwaBHrxViGjXQ_WiQio/edit?usp=sharing

English version https://docs.google.com/document/d/1y5QKwUDVBy0f20WxwEb_0OSESc-o2meKHTJ72fut-Sw/edit?tab=t.0


Equivalent command to check-wheel-contents

In the same spirit as twine check (see #8641), there is a nice utility called check-wheel-contents.
Do we still need this tool now that uv publish exists? I mean, is check-wheel-contents checking for stuff that uv publish does not?

I'm not opposed to including these checks in uv, but ideally, these checks would already be performed by the build backed: We should error when building the wheel, ideally locally, instead of only failing during a publish run (on CI).


fix: remove outdated table of cfeps

This PR cleans up some old cruft.

ready to merge @conda-forge/core

I really like this table and frequently click on these links as numbers in filenames are not that intuitive. Should I instead update it?

IMHO we should write code to automatically generate it or remove it.

FYI, we automatically populate this list in https://conda-forge.org/community/cfep/. Maybe a link in this section is sufficient?

I am going to close this for now, since we do not plan to merge. We can either update or replace with a link in another PR.


Wrong submission url on site with multiple forms

I created two forms one a single website, yet the second form submission_url points to the first, yet there is no way to change this.

All forms on a site should point to same URL. There is hidden input to identify each form.

I hope the above answers your question.


[Moby] Remove extra info from error logs

Backport of f731440f562046527c8a470acb18c3a357402655 for moby 20.10 release branch

these logs create noise and are no longer useful

Signed-off-by: Kathryn Baldauf<EMAIL_ADDRESS>(cherry picked from commit f731440f562046527c8a470acb18c3a357402655)
Signed-off-by: Brian Goff<EMAIL_ADDRESS>

@kevpar @dcantah


Feature/empty news feed

Changed

Changed most integration tests to use withEmptyNewsFeed fixture instead of withNewsFeed to prevent unwanted news feed popups during tests.

Makes sense, the newsfeed popup is irrelevant for most tests. Simplifying is good 👍
I don't have the repo locally, but searching before this change shows 7 locations using withNewsFeed(), and this PR removes... 8. I'm not entirely sure how that works, but: do we have any remaining withNewsFeed() tests after this? Seems like we should have at least one or two.

In client/test/domain-list.test.js all its tests are using withNewsFeed. I don't think there is a specific test which asserts the news feed specifically but maybe that is one to create and just use it there and remove from domain-list.


Can't regain control of terminal prompt after starting realtime html report

I'm new to all this stuff, but got things working okay and then tried a realtime html report. The file was created, but the terminal never gave me back my prompt:
me@server: /srv/www/domain.org/logs$ goaccess access.log -o /srv/www/domain.org/report.html --log-format=COMBINED --real-time-html
WebSocket server ready to accept new client connections
q
exit
q
q
q
^[q
^[^[^[^[^[quit
^[exit
exit

I don't know what to do now. Do you know why it did that? Can I just close terminal and start a new session? Or will that realtime process keep running in the background? If so, how do I stop it?
Am just a bit confused.
Thanks, Dunstan

Ctrl-c does it. Thanks for your help answering this on twitter.


Added zondax repo files that was missing

Without that, on make install you get that error
mkdir -p /root/genesisd/build/
go build -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=evmos -X github.com/cosmos/cosmos-sdk/version.AppName=genesisd -X github.com/cosmos/cosmos-sdk/version.Version=0.3.0 -X github.com/cosmos/cosmos-sdk/version.Commit=23d20d043bc08dc2cb7445583756d705e2a70c49 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger" -X github.com/tendermint/tendermint/version.TMCoreSemVer=v0.34.24 -w -s' -trimpath -o /root/genesisd/build/ ./... # github.com/zondax/hid
vendor/github.com/zondax/hid/hid_enabled.go:23:11: fatal error: os/threads_posix.c: No such file or directory
23 |  #include "os/threads_posix.c"
|           ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
These files solves the missing files in dependency

Closes: #XXX
Description

For contributor use:

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added  relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

[ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
[ ] Reviewers assigned
[ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Not reviewed, hopefully it work!


Fix up CircleCI

Move it to root of repo
Don't run the remote write compliance tests in CI
Do run lint.

I'm wondering if we shouldn't keep completely separate Go modules and perhaps even run separate CI builds for both remote_write and promql dirs? You know, just to keep unrelated things as separate as possible, since they work quite differently?

Can we do that in circleci? I think you must have a single conifg... I can split separate jobs in the same config for lint & test on each dir (and a separate go mod for each) if you like?  I'm not picky either way TBH

Yeah, single config, but separate jobs, I think.
@roidelapluie and @SuperQ are the absolute CircleCI experts now and can advise on the best strategy :)

Why would not we run the tests in CI?

@roidelapluie We do want to run normal Go unit tests, but not the remote_write compliance tests (which are meant not to test the code of this repo, but some vendor implementation's remote_write).

And it would be nice to have the difference compliance subdirs as independent as possible, IMO, so they don't have to care about each other (separate Go modules, maybe even separate CI jobs even if both always run, etc.).

I feel like we should run the compliance tests as nightly tests in the future.

I feel like we should run the compliance tests as nightly tests in the future.

The remote write tests download versioned releases right now, the results won't change without version changes.

Yeah, the CI goal here is just about running the normal Go tests and linting.

I feel like we should run the compliance tests as nightly tests in the future.

The remote write tests download versioned releases right now, the results won't change without version changes.

I would not bet my bottom dollar that some of them are not flappy.

Thanks @SuperQ!


Update security-considerations-of-allowing-custom-script.md

*Removed false statement that SPFx does not use iFrames (because domain-isolated web parts use iFrames)
*Updated name "AngularJS" to "Angular" - as that is the actual name of the framework
*Fixed typo "web pack" -> "webpack"

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@kaarins PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Expose Datetime and Spanned constants

See https://github.com/alexcrichton/toml-rs/pull/327#issuecomment-531988931 and the related discussion.

There was a comment below yours which would entail not exporting these, and would it be possible to explore that? I would prefer to not export these low-level details which is something we can't change easily

The code that these constants are needed for is:

The DatetimeOrTable struct that helps differentiating between DateTime and a Spanned struct.

The custom Spanned struct that I'm using so that I can set Eq, Hash, etc. impls in a custom way.

Elimination of the second case seems possible as long as you want to merge the PR to change the impls. For the first case, I don't know. In the thread you linked I've asked @dtolnay to help me and in fact that's why I waited so long until I filed this PR. DatetimeOrTable is some kind of hybrid deserializer that either deserializes DateTime or Spanned<Table>, depending on the data present. While this crate has such a struct as well, the struct in this crate is differentiating between DateTime and Table without the Spanned. So exposing this crate's DateTimeorTable wouldn't work. How would calling the Deserialize impl work as @dtolnay proposes?

So I figured out a way. It's not beautiful. In fact, it's quite ugly. And it also makes assumptions about how the Spanned is being deserialized (as a map in the visitor).

I'm working on a patch for the second case.

Ok I've opened #344 . Either this PR or #344 is needed for the toml-spanned-value crate. #340 is needed in any case. #324 would be cool to be merged, but isn't required, as toml-spanned-value has its own copy/fork of map.rs that has the PR applied.

Superseded by #344


Array indexing with a variable

function githubExample(value) {
  return request.resource.data[value];
}

The plugin highlights the "value" indexer with: '[' or number expected, got 'value'

@Artelis thanks for testing, issue will be fixed on version: 2.5.3


handle forget inline instead of in goroutine

when we are under memory pressure, or echo 3 > /proc/sys/vm/drop_caches,
kernel can send us many forget ops at the same time if we have lots of
inodes in memory. Running them all in goroutines can lead to even more
memory usage and eventually OOM.

There are some potential performance and deadlock issues that I'm trying to
think through here:

fileSystemServer.handleOp calls into Connection.Reply, which eventually writes the response to the kernel  [https://github.com/kahing/fuse-1/blob/bf4c03d484a827d08b14edb1c56aa8ba59ab1e0b/connection.go#L490-L498](if kernelResponse returns false). Fortunately it returns true for ForgetInodeOp. So we don't have to worry about a deadlock where the kernel waits to consume the response until we've pulled more off the incoming queue, but we're blocking on writing the response. So I think this is okay.

The only other substantive thing that handleOp does is  call FileSystem.ForgetInode. I worry that it may be an issue if this blocks on some other op coming in. But I can't think of any case where that would be reasonable, and indeed in the gcsfuse implementation at least the function wouldn't behave any different with a synchronous call.

So I'm happy with this overall. Could you please make a few changes though?

Add comments in the code you've changed that say why you're calling synchronously in this case. Something like "Special case: call in this goroutine for forget inode ops, which may come in a flurry from the kernel and are generally cheap for the file system to handle."

Fix the comment on NewFileSystemServer that's no longer true. Document that ForgetInode may be called synchronously, and should not depend on calls to other methods being received concurrently.

amended commit with comments

Thanks!


Zim rips out its own internal organs and most modules in certain cases when building a container with buildah

Possibly stems from the same underlying issue for #365 and/or #95
zimfw info before creating the problem:
Zim version:  1.0.1 (previous commit is 28e4345)
ZIM_HOME:     /home/dev/.zim
Zsh version:  5.7.1
System info:  Linux Ingram 5.4.10-zen1-1-zen #1 ZEN SMP PREEMPT Thu, 09 Jan 2020 10:14:27 +0000 x86_64 Linux

zimfw info after creating the problem:
zimfw:source: no such file or directory: /home/dev/.zim/zimfw.zsh

gist of .zimrc: https://gist.github.com/ae99caf84d9b33cf7034589e8ffc1b6f
gist of .zshrc: https://gist.github.com/AndydeCleyre/bc127b3def8fe27ca66e377f49e42854

Description
If I run a build script for a container using buildah and have it install zim and then an external module via zim, it works.
But if, between installing zim and the external module, I commit the container to an image, and resume the build process from a newly instantiated container from that newly committed image, the zimfw install step proceeds to butcher the zim installation, removing all modules but the newly added one, and also removing login_init.zsh and zimfw.zsh, as well as all *.zwcs.
Steps to reproduce
This works fine:
./repro.sh

This reproduces the problem:
./repro.sh --press

repro.sh
#!/bin/sh -e

# Remove local container if present
buildah rm zimfw-buildah-mystery || true

# Set container and user names to use
ctnr=zimfw-buildah-mystery
user=dev

# Aliases for working with above variables
alias run="buildah run $ctnr"
alias urun="buildah run --user $user $ctnr"
alias ucopy="buildah copy --chown $user $ctnr"
alias cfrom="buildah from --name $ctnr"
alias cpress="buildah commit --rm $ctnr"

# Start with alpine:3.11.x
cfrom alpine:3.11
run apk upgrade >/dev/null
run adduser -D $user

# git, Zsh, Zim
run apk add git zsh{,-vcs} >/dev/null
ucopy https://raw.githubusercontent.com/zimfw/install/master/install.zsh /tmp/install-zim.zsh
urun zsh /tmp/install-zim.zsh
run rm /tmp/install-zim.zsh

if [[ $1 = '--press' ]]; then
    cpress localhost/zim-alpine
    cfrom localhost/zim-alpine
fi

# install external module
echo -e '\n---vvv---\nbefore installing zpy:'
urun ls /home/$user/.zim /home/$user/.zim/modules
echo -e '---^^^---\n'

urun zsh -ic 'echo "zmodule andydecleyre/zpy -s python.zshrc -b develop" >> ~/.zimrc; zimfw install'

echo -e '\n---vvv---\nafter installing zpy:'
urun ls /home/$user/.zim /home/$user/.zim/modules
echo -e '---^^^---\n'

Output of ./repro.sh --press
b9958274b6af4b183ae7a47bb74c518bf0cf2a7cfac701745fe548e3070b6450
zimfw-buildah-mystery
8fee8fff16d4122f08e2bb9b1d033b177afb65689261aac6f309545a2725df64
) Git is installed.
) Using Zsh version 5.7.1
) ZIM_HOME not set, using the default one.
/tmp/install-zim.zsh:64: command not found: chsh
x Could not change your default shell to /bin/zsh. Please manually change it later.
Connecting to github.com (<IP_ADDRESS>:443)
Connecting to github.com (<IP_ADDRESS>:443)
Connecting to github-production-release-asset-2e65be.s3.amazonaws.com (<IP_ADDRESS>:443)
saving to '/home/dev/.zim/zimfw.zsh'
zimfw.zsh            100% |********************************| 14318  0:00:00 ETA
'/home/dev/.zim/zimfw.zsh' saved
) Downloaded the Zim script to /home/dev/.zim/zimfw.zsh
) Copied Zim template to /home/dev/.zimrc
) Copied Zim template to /home/dev/.zshrc
) Copied Zim template to /home/dev/.zshenv
) Copied Zim template to /home/dev/.zlogin
Installing modules ...
) Installed modules.
Initializing Zim ...
All done. Enjoy your Zsh IMproved! Restart your terminal for changes to take effect.
Getting image source signatures
Copying blob sha256:6b27de954cca6332272e7709b7d8ceccee1489d9452af73391df360a26123580
Copying blob sha256:51116208ce996d424c958e3a63b6681cce3be104b4a0284fe5ee02675da13b40
Copying config sha256:64ea690713195184aed9f5ad6cae9e740692fcc71aa183ddb0772e4ac2ef24f0
Writing manifest to image destination
Storing signatures
64ea690713195184aed9f5ad6cae9e740692fcc71aa183ddb0772e4ac2ef24f0
zimfw-buildah-mystery

---vvv---
before installing zpy:
/home/dev/.zim:
init.zsh
init.zsh.zwc
login_init.zsh
login_init.zsh.zwc
modules
zimfw.zsh
zimfw.zsh.zwc

/home/dev/.zim/modules:
completion
environment
git
git-info
input
steeef
termtitle
utility
zsh-autosuggestions
zsh-completions
zsh-history-substring-search
zsh-syntax-highlighting
---^^^---

Installing zpy ...
) zpy: Installed
Done with install. Restart your terminal for any changes to take effect.
) /home/dev/.zim/init.zsh: Updated. Restart your terminal for changes to take effect.
) /home/dev/.zim/login_init.zsh: Already up to date
Done with build.
re-compiling /home/dev/.zcompdump.zwc: succeeded
re-compiling /home/dev/.zim/init.zsh.zwc: succeeded
Done with compile.

---vvv---
after installing zpy:
/home/dev/.zim:
init.zsh
init.zsh.old
init.zsh.zwc.old
modules

/home/dev/.zim/modules:
zpy
---^^^---

I know nothing about buildah, and have no idea what it means to write to a committed image filesystem.
What happens if instead of
zimfw install

you do:
command git clone -b develop -q --recursive https://github.com/andydecleyre/zpy /home/$user/.zim/modules/zpy; \
  print "source /home/$user/.zim/modules/zpy/python.zshrc" >> /home/$user/.zim/init.zsh; \
  autoload -Uz zrecompile; \
  zrecompile -p /home/$user/.zim/init.zsh

?
Which is basically what zimfw install would do after you added andydecleyre/zpy to .zimrc. It would actually also write some temporary files on the way, but let's try to reproduce the issue in a simpler way first.

It should be sourced after compinit. I replaced the urun zsh -ic... line with
urun git clone -b develop -q --recursive https://github.com/andydecleyre/zpy /home/$user/.zim/modules/zpy
urun sh -c 'echo "source ~/.zim/modules/zpy/python.zshrc" >> ~/.zim/init.zsh'
urun zsh -ic 'autoload -Uz zrecompile; zrecompile -p ~/.zim/init.zsh'

And the output is similar:
---vvv---
before installing zpy:
/home/dev/.zim:
init.zsh
init.zsh.zwc
login_init.zsh
login_init.zsh.zwc
modules
zimfw.zsh
zimfw.zsh.zwc

/home/dev/.zim/modules:
completion
environment
git
git-info
input
steeef
termtitle
utility
zsh-autosuggestions
zsh-completions
zsh-history-substring-search
zsh-syntax-highlighting
---^^^---

re-compiling /home/dev/.zim/init.zsh.zwc: succeeded

---vvv---
after installing zpy:
/home/dev/.zim:
init.zsh
init.zsh.zwc
modules

/home/dev/.zim/modules:
zpy
---^^^---

I poked around and saw that ~/.zim/init.zsh only had the one line last added in it. So I monitored the state of ~/.zimrc in the first version and it too gets clobbered by the echo.
I will try to whittle this down, and maybe remove zimfw from the equation entirely.

So you see that it's not zimfw that "rips out its own internal organs and most modules in certain cases when building a container with buildah", because now we already removed it from the equation and the issue persists.
You're just using git, appending redirected output and zrecompile now, and the files are being erased too. So it's not Zim that is causing this.

I believe you that it's almost certainly nothing to do with zim, but I haven't yet been able to reproduce the problem without zim.

Looks like you'll be able to reproduce the problem by doing:
# create files and subdirectories in /home/$user

cpress localhost/zim-alpine
cfrom localhost/zim-alpine

# create new files and subdirectories and/or overwrite exiting ones in /home/$user

Just the fact that

I poked around and saw that ~/.zim/init.zsh only had the one line last added in it.

already points out to the files being lost since the moment you do
urun zsh -ic 'echo "zmodule andydecleyre/zpy -s python.zshrc -b develop" >> ~/.zimrc

Yes, it certainly looks like that. But so far I have not been able to reproduce it without installing zim.
You are welcome to close this as invalid if you like, and I'll ask to re-open in the unlikely case that I can't eventually eliminate zim from the reproduction process.
For example, the following does not reproduce it:
#!/bin/sh -e

# Set container and user names to use
ctnr=buildah-please-append
user=dev

# Remove local container/image if present
buildah rm $ctnr || true
buildah rmi localhost/$ctnr || true

# Aliases for working with above variables
alias run="buildah run $ctnr"
alias urun="buildah run --user $user $ctnr"
alias ucopy="buildah copy --chown $user $ctnr"
alias cfrom="buildah from --name $ctnr"
alias cpress="buildah commit --rm $ctnr"

# Start with alpine:3.11.x
cfrom alpine:3.11
run apk upgrade >/dev/null
run adduser -D $user

urun mkdir /home/$user/newfolder
urun sh -c 'echo "line1" >> ~/newfolder/file.txt'

if [[ $1 = '--press' ]]; then
    cpress localhost/$ctnr
    cfrom localhost/$ctnr
fi

urun mkdir /home/$user/newfolder2
urun sh -c 'echo "line2" >> ~/newfolder/file.txt'
urun cat /home/$user/newfolder/file.txt
urun wc -l /home/$user/newfolder/file.txt


New theme: hugotube

Theme inspired by Youtube layout.
https://github.com/marcanuy/hugotube

Hi Marcelo,
excuse the late response. Due to university I had to take a step back from the maintenance of this repo. Nonetheless, thanks for sharing your theme with us.
I've tested hugotube with the build script for Hugo's theme site and noticed a few issues:

my browsers console showed warning that the stylesheet wasn't parsed as such because the MIME-type wasn't set. Adding type="text/css" in the header might fix this problem

Hey @digitalcraftsman, thanks for the tips.
I've added the MIME type but not sure about the other suggestion:

please use http(s)://www.example.com as base url in the [example config]

I already have baseURL = "https://marcanuy.github.io/hugotube", i.e.: the Github pages URI.

I already have baseURL = "https://marcanuy.github.io/hugotube", i.e.: the Github pages URI.

After reflecting this I came to the conclusion that the chance of an abuse in this setup is quite low compared to an external website (i.e. outside of GitHub). So forget my comment from above.
However, it the demo looks still unstyled because style.css can't be fetched. In order to get your theme running an asset pipeling is required to compile the SASS stylesheet, right?
Hugo doesn't execute any further commands in order to generate the demo. Therefore, there has to be a compiled style.css in the repo (at least for the demo).

Done.

Your theme should appear soon on Hugo's theme site. Furthermore, I'll promote your theme on Hugo's official Twitter account.


Query: Calling Roll Tables from OtF results - i.e. critical hits

Is it possible to call Roll Tables from OtF results such as critical hits/failures/etc.?  (and to define the critical hit ranges in case of using 20+ skill levels increase crits, for example)?  Much in the way that a Fright Check can call a Roll Table called Fright Check (I entered that all in last night and works a treat).
Ultimately, I'd like to have an OtF to check weapon skill, roll damage in case of a hit, and report a Critical Success or Failure as well (and same with spell casting crit failures) by calling the tables as part of the OtF and maybe that's already possible?

We can't do it with OtFs alone, but you can create a script macro:
GURPS.executeOTF('A:Rapier')
if (GURPS.lastTargetedRoll.isCritSuccess) {
  let tname = 'Critical Hit'
  let tables = game.tables.contents.filter(t => t.name.match(tname))
  if (tables.length == 1) {
    let table = tables[0]
    let r = await table.roll()
    table.draw(r)
  }
}

I am not certain how to can modify the roll, however.

Thanks, Chris - this is great.  Is there a way to change the Critical threshold (to allow Crits on a 7 with effective skill 20+, 8 on 25+, etc. following any house rules)?

At the moment, no. But if you open an issue, we might be able to create some thing in the future. For people who play with those kind of home rules.￼

Actually, I guess we could leave this issue open, and just rename it.￼

Sounds good - thanks :-)


Bug with browser back navigation

If you select a filter, then clear it, then hit the browser "back" button, you'll see the query parameter restore to reflect the selected filter, but the query isn't made and the filter state isn't updated.

Resolved in d71bad13b21afc75e7edf66ac543f36efa6c933b and 7319ac6111d6b9ca9d297fd1fd1abe8058cb3afc


The boxed-style anchor causes counters in title abnormal

I want to encapsule the showybox and create an theorem box, which can count its order of appearance.
However, I found this behaved abnormally when I use anchor, causing the counters update twice per box, like the picture below:

But showyboxes without anchors behaves well, maybe it's anchor's problem?

Hi! ✨
Hmmm. I think I know what's happening. The difference between normal titles and boxed titles is that while drawing boxed titles, the code "pre-renders" the title before in order to get the "real" dimensions of the title and adjust their position with respect to the body using that information.
As I see it, there's a "hidden" pre-rendered title which has the skipped numbers (1 and 3)
It seems to me that a "good fix" for this bug would be enabling a new parameter called counter or counter-name to the showybox, so it updates internally this counter before drawing the showybox and not with the title-rendering process.
Meanwhile, as a "quick fix" you could put the cnt1.step() inside the functtion box1 instead of putting it in the title, like this:
#import "@preview/showybox:2.0.1": *

#set page(paper: "a7")

#let cnt1 = counter("type1")

#let box1(..args) = {
  cnt1.step()
  showybox(
    title-style: (
      boxed-style: (
        anchor: (
          x: center,
          y: horizon,
        ),
      )
    ),
    title: cnt1.display(),
    ..args
  )
}

#box1[#lorem(10)]
#box1[#lorem(10)]


Option for auto-approval of requests

Suggestion
We would like to have the option to auto approve all requests.
Maybe to make it work faster without the need to implement it into some setting, just give some info how to edit the Flow to auto approve it, so skipping the steps of Approvals (or add some actions in the Flow to set the SharePoint list items Status to approved automatically).

@wapster182 I've implemented this via a new setting in the settings list and it will be released with the other new functionality that we are discussing.

I tested this, unfortunately did not work yet.

{
"error": {
"code": "BadRequest",
"message": "Navigation binding uri for the property<EMAIL_ADDRESS>is not valid., Unable to extract object from request.",
"innerError": {
"date": "2024-02-09T15:41:49",
"request-id": "f9f8e717-7843-49a5-a6c1-af5d8d279607",
"client-request-id": "f9f8e717-7843-49a5-a6c1-af5d8d279607"
}
}
}
Do I need to re-run the scripts to create the logic apps? Is there anything changed in them that need to be updated?

Hey @alexc-MSFT, could you check on this?

Hi @alexc-MSFT, I just tested it: I Re-deployed the entire enviroment using the PS scripts, unfortunately the same error.
It seems the error has nothing to do with the auto-approval.
I set the value to false and the manuall approval was triggered. This has worked fine, until the Logic App tries to create the space.
Maybe there is something wrong because of the new skip template / default data classification setting?

I did some further testing. When I use a team site as space type, the logic app flow works and creates the space.
I think it has to be a problem with the Teams creation and the new skip template / default data classification.
Can you look into this?

@wapster182 so yes as you say that error is not related to auto approval. Can you check the request in the Provisioning Requests list and look at the values of the 'Teams Template' and 'Teams Template Title' columns? I assume this request is using a custom template which perhaps can't be found. Let me know what those columns are populated with please. Thanks

@wapster182 I've found the issue, the new setting for hiding the site template screen didn't take into account setting a default teams template (it should be set to 'Standard' for a provisioning request unless a template is specified). I've fixed the app, I just need to repackage it. You will only need to import the updated solution as opposed to any backend components.

@wapster182 though it is worth noting I am about to push some general bug fixes too

@wapster182 all done, the latest release contains the above fix and some other bug fixes (azure components)

I wanted to test it, but it seems another BUG was introduced....
When trying to create a new request, I cannot go past the Recommendation screen in Step 2:

When hitting the Next button nothing happens.
Can you please check this soon, thank you

@wapster182 so I've had this earlier during a deployment and it was due to the new columns not being created in the Provisioning Types list, we then had to refresh the list data source in the app and then republish.
Make sure the columns are created exactly as per this issue - https://github.com/pnp/provision-assist-m365/issues/59. Specifically the ones in the Provisioning Types list. Make sure the name is exactly the same too.

Thanks, due to the re-import and re-executing of the scripts the SharePoint lists got somehow not overwritten but appended, so I had a mess in the columns:

Great advice, thanks. The auto-approval is working now!


Add activity feed API

In this stack: 🔧 Implement activity feed API

main

#2   👈

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dbalatero-test and the rest of your teammates on  Graphite


Raid Guard Code Optimization

Please describe the changes this PR makes and why it should be merged:
Sorry for the additional PR, the code needed some optimization to reduce the number of variables, and speed it up.
Status

[X] Code changes have been tested on an instance of YAGPDB, or there are no code changes
[X] I have read and followed the contribution guide

Thanks for doing this! But it is not necessary we are already working on updating the code.
Since this is mostly formatting and really small changes to the code itself, I think I can close this for now! Lemme know if you think this is a mistake.


If there are multiple buttons, the last active one will be triggered

Although this isn't a big deal since usually the button will be immediately clicked 🤔
https://user-images.githubusercontent.com/37948597/152644106-57534bf2-d60b-40ac-b111-0754810961c7.mp4

Fixed in v1.8.0.


Weird results when processing frame by frame

Hi,
Thank you for the great work!
I tried running your code on my videos, but the results were unexpected. Specifically, I used test.sh (process frame by frame) to upscale the video by 4x (expecting from 960 x 540 to 3840 x 2160), but the resulting video remained the same dimension, and the quality was even worse. Please see the attached input and output for reference. Do you have any ideas on what might be causing this issue?
Many thanks.
Here's the input and output videos: https://drive.google.com/drive/folders/1PZHSIzuj6k7YN4q93XlVr3oRWjQH2Gdv?usp=sharing
Here's the code to run
CUDA_VISIBLE_DEVICES=0 python test.py   --data_path  './test_data/input4x' --result_path './test_data/output4x' --space_scale  "4,4"

Here's the code I used to extract frames from all the videos in a directory.
import os
import imageio

def extract_frames_from_videos(input_path, output_path):
    # Ensure the output path exists
    if not os.path.exists(output_path):
        os.makedirs(output_path)

    # Get list of all video files in the input path
    video_files = [f for f in os.listdir(input_path) if os.path.isfile(os.path.join(input_path, f))]

    for video_file in video_files:
        video_name, _ = os.path.splitext(video_file)
        video_output_path = os.path.join(output_path, video_name)

        # Create a directory for the video frames
        if not os.path.exists(video_output_path):
            os.makedirs(video_output_path)

        # Read the video
        video_reader = imageio.get_reader(os.path.join(input_path, video_file))

        # Extract and save frames
        for i, frame in enumerate(video_reader):
            frame_path = os.path.join(video_output_path, f"frame_{i:04d}.png")
            imageio.imwrite(frame_path, frame)

If you want to test on your own video, you need to remove the part that downsamples the input from Line110 to Line115.
Our model is trained on REDS using Bicubic downsampling, and if the input video contains more complex degradation, the results may also be affected. You can add real video degradation to our model for fine-tuning.

Thank you for your response. When I removed the part from Line 110 to 115, the results were clearer, but the dimensions were still not upsampled and remained the same. I tried several other approaches, including upsampling the image first before processing it, and I was able to run it with scale_factor = "3,3" on one A100 . However, with scale_factor = "4,4", it resulted in a CUDA OOM error. Do you have any suggestions on how to overcome this issue?
For that approach, I added this line after line 101
inputs = [cv2.resize(img, (int(img.shape[1] * 1/scale_w[0].item()), int(img.shape[0] * 1/scale_h[0].item())), interpolation=cv2.INTER_CUBIC) for img in inputs]

Oh, you should also change hr_coord, which affects the target size and position of the target. I just made adjustments to the test code, but I didn't have time to debug it. Let's see if this can solve your problem. test_seq_yours.py.
Regarding OOM, since the resolution of your input video is relatively high, if there is not enough GPU memory, you can perform local SR by cropping the hr_coord and feeding them into the model separately to output the super-resolution results for the corresponding region.

We have updated the code, and using test_seq_yours.py may solve your problem. The OOM issue has been alleviated by slicing. If you find it helpful, please give me a star.

Thank you for your support. I tested the new code and found that it worked well with your sample videos. However, when I tested it with my video (960 x 540), it still encountered an OOM issue on a T4, even across a wide range of --max_patch values from 16 to 1024.
Nevertheless, this is excellent work, and I've given it a star ⭐.


[Bug] Rotation axes aren't applied correctly

Using celestial_1.19.4_forge-2.0.
Bug description
I've set up a rotation for a skybox using the base_degrees properties, with these equations:
"base_degrees_x": "((dayTime * (360/24000)) * (-1))",
"base_degrees_y": "((26.52 * cos((1/12000) * 180 * dayTime) -  26.52) * (-1))",
"base_degrees_z": "((26.52 * sin((1/12000) * 180 * dayTime)))"

Each of the axes work correctly by themselves, however when all 3 equations are configured, the rotation seems to get broken.
Here's an explanation video showcasing the expected behavior.
https://github.com/user-attachments/assets/321ffa48-ed2a-4f9e-a096-38b08756aeea
And the result in-game (the rotations are sped up for better visualization).
https://github.com/user-attachments/assets/bdb51044-c47f-4085-8256-60ab978f6d67
here's also a pack for ease of testing:
rotation.zip

After further testing I realized I misunderstood how rotation works, and there are no issues related to what I describe in the report.
This bug report can be closed.


Fix 'Save Checkpoint' button & other regressions

Contributes to:

#86
#114
#93
#75
#76

cc @LanesGood

@LanesGood I merged #117 and #118 into this because it would be hard to fix conflicts in the state machine later as there is still work to do with checkpoints. I updated the header of this PR with the tickets I'm aiming to fix.

@LanesGood I added a change to display the 'Save checkpoint' button on both tabs. There is an issue with the backend blocking the checkpoint switch on certain conditions, ticketed at https://github.com/developmentseed/pearl-backend/issues/84. Can you please do another review?

I was able to successfully test the following:

[X] Bookmarked an AOI
[X] Added a new class
[X] Changed project name in editor


Extended Elements: Bottom sheet

Make some more examples of bottom sheets.
https://www.google.com/design/spec/components/bottom-sheets.html

Hi GoDesign.
I'm looking for dev. who are open to create a custom jQuery mobile for a live results project.
What you do is REALLY close to what we need and I was wondering if you would be interested working with us for this mission.
Please contact me if you want to open the discussions.
Many thanks.
Jonas

Examples added and functionality expanded https://github.com/godesign/nativeDroid2/commit/6658b61b953feef797147c3532a576ea6a6ec534


1.0.16_crab version of New checksum version for CRABCache

We've made a small change in the checksum function in crab as a result of a tarball being recycled too often. Issue here: https://github.com/dmwm/CRABServer/issues/5153
Master PR here: https://github.com/dmwm/WMCore/pull/6955

After this we'd like a new tag for our 1.0.16_crab branch. Thanks!

1.0.16.crab4 tagged


[$500] Test Issue

QAing this PR
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Break down in numbered steps
Expected Result:
Describe what you think should've happened
Actual Result:
Describe what actually happened
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019c7b32a0d6732467
Upwork Job ID:<PHONE_NUMBER>044387328
Last Price Increase: 2023-09-19

Created this issue to QA this PR. It looked like it worked so closing this out, sorry for the ping!


B: Send customer reference as shopperReference to Adyen in payment an…

…d HPP requests

Hi Maikel,
As discussed I will accept your pull request.
Regards,
Rik
Adyen


[bug] infinite update with nsis on windows

Describe the bug
I made simple repo with guides/distribution/updater
And it works for MacOS - it asks for new update and update,
However, for windows (nsis) it opens dialog and asks for new update and I confirm it
and it doesn't really update the program so it opens again and asks again (and the version doesn't change I display it in main window)
github.com/thewh1teagle/tauri-auto-updater
Reproduction
Download releases/download/v0.0.3/tauri-auto-updater_0.0.3_x64-setup.exe
Then install and confirm the update to see the infinite update dialog
Expected behavior
It should update to version v0.0.4 (if I install manually it update)
Full tauri info output
WARNING: no lock files found, defaulting to npm

[✔] Environment
    - OS: Mac OS 14.2.1 X64
    ✔ Xcode Command Line Tools: installed
    ✔ rustc: 1.75.0 (82e1608df 2023-12-21)
    ✔ cargo: 1.75.0 (1d8b05cdd 2023-11-20)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-aarch64-apple-darwin (environment override by RUSTUP_TOOLCHAIN)
    - node: 18.19.0
    - npm: 10.2.3

[-] Packages
    - tauri [RUST]: 1.5.4
    - tauri-build [RUST]: 1.5.1
    - wry [RUST]: 0.24.7
    - tao [RUST]: 0.16.7
    - tauri-cli [RUST]: 1.5.9
    - @tauri-apps/api : not installed!
    - @tauri-apps/cli [NPM]: 1.5.9

[-] App
    - build-type: bundle
    - CSP: unset
    - distDir: ../src
    - devPath: ../src

Stack trace
No response
Additional context
Everything available at github.com/thewh1teagle/tauri-auto-updater

The reason is that your latest.json file points to the .msi installer, not the setup.exe. They don't work interchangibly so i'd recommend to decide on one bundle type (msi or nsis) and disable the other.

Why does the latest.json not include the link for the setup.exe?

Why does the latest.json not include the link for the setup.exe?

Sorry, I figured out the problem. The tauri action will only build either the MSI OR the NSIS:
https://github.com/tauri-apps/tauri-action/blob/dev/action.yml#L43
You gotta choose which in the settings and then only distribute that bundle


Pass context all the way from API controller through pyramid

Pull after #1258. *

Use context in tier_fs: pass it through GetOrSet commands.
Use context in API controller: use the request context rather than the startup context at the time of creation.

This improves logs and allows cancellation, as well as being more Goful and correct.

Example of logs: with this, at level TRACE, a download from the API looks like this:
DEBUG  [2021-01-20T18:41:32+02:00]api/api_controller.go:95 api.(*Dependencies).LogAction performing API action                         action=get_object host="localhost:8000" message_type=action method=GET path="/api/v1/repositories/repo2/refs/ftr/objects?path=aa" request_id=5eb9fd03-8376-4747-b1f5-df52b898ded5 service_name=rest_api user=me
TRACE  [2021-01-20T18:41:32+02:00]pyramid/tier_fs.go:217 pyramid.(*TierFS).Open opened locally                                filename=3d17d588390d34c4e1c07e2e6103d6783697137dabf7562e94dd3cae03c01435 host="localhost:8000" method=GET module=pyramid namespace="local://new/repo2" ns_path=new//repo2 path="/api/v1/repositories/repo2/refs/ftr/objects?path=aa" request_id=5eb9fd03-8376-4747-b1f5-df52b898ded5 service_name=rest_api user=me
TRACE  [2021-01-20T18:41:32+02:00]pyramid/tier_fs.go:217 pyramid.(*TierFS).Open opened locally                                filename=8aae65ba06d14d1941e92b6a962e5415d86e348b21f3195163615cb404b2681e host="localhost:8000" method=GET module=pyramid namespace="local://new/repo2" ns_path=new//repo2 path="/api/v1/repositories/repo2/refs/ftr/objects?path=aa" request_id=5eb9fd03-8376-4747-b1f5-df52b898ded5 service_name=rest_api user=me
TRACE  [2021-01-20T18:41:32+02:00]httputil/tracing.go:143 httputil.TracingMiddleware.func1 HTTP call ended                               host="localhost:8000" method=GET path="/api/v1/repositories/repo2/refs/ftr/objects?path=aa" request_body="[]" request_headers="map[Accept:[application/octet-stream] Accept-Encoding:[gzip] Authorization:[Basic QUtJQUpJNldITFdMSjRDVzdVNVE6TCtTTCtVNXc1U29tNFJtWlRSRnhuY1RNSW1tL1RIaXd4alhuZlJkRw==] User-Agent:[Go-http-client/1.1]]" request_id=5eb9fd03-8376-4747-b1f5-df52b898ded5 response_body="foo\n" response_headers="map[Content-Disposition:[filename=\"aa\"] Content-Length:[4] Content-Type:[application/octet-stream] Etag:[\"d3b07384d113edec49eaa6238ad5ff00\"] Last-Modified:[Tue, 19 Jan 2021 16:42:59 GMT] X-Request-Id:[5eb9fd03-8376-4747-b1f5-df52b898ded5]]" sent_bytes=0 service_name=rest_api status_code=200 took=7.67969ms user=me

I was able to fetch all these lines, because they all share the same request_id.  Before this PR tier_fs logs (and many others) carry no request_id field, making tracing impossible.

Example of logs: with this, at level TRACE, a download from the API looks like this:
DEBUG  [2021-01-20T18:41:32+02:00]api/api_controller.go:95 api.(*Dependencies).LogAction performing API action                         action=get_object host="localhost:8000" message_type=action method=GET path="/api/v1/repositories/repo2/refs/ftr/objects?path=aa" request_id=5eb9fd03-8376-4747-b1f5-df52b898ded5 service_name=rest_api user=me
TRACE  [2021-01-20T18:41:32+02:00]pyramid/tier_fs.go:217 pyramid.(*TierFS).Open opened locally                                filename=3d17d588390d34c4e1c07e2e6103d6783697137dabf7562e94dd3cae03c01435 host="localhost:8000" method=GET module=pyramid namespace="local://new/repo2" ns_path=new//repo2 path="/api/v1/repositories/repo2/refs/ftr/objects?path=aa" request_id=5eb9fd03-8376-4747-b1f5-df52b898ded5 service_name=rest_api user=me
TRACE  [2021-01-20T18:41:32+02:00]pyramid/tier_fs.go:217 pyramid.(*TierFS).Open opened locally                                filename=8aae65ba06d14d1941e92b6a962e5415d86e348b21f3195163615cb404b2681e host="localhost:8000" method=GET module=pyramid namespace="local://new/repo2" ns_path=new//repo2 path="/api/v1/repositories/repo2/refs/ftr/objects?path=aa" request_id=5eb9fd03-8376-4747-b1f5-df52b898ded5 service_name=rest_api user=me
TRACE  [2021-01-20T18:41:32+02:00]httputil/tracing.go:143 httputil.TracingMiddleware.func1 HTTP call ended                               host="localhost:8000" method=GET path="/api/v1/repositories/repo2/refs/ftr/objects?path=aa" request_body="[]" request_headers="map[Accept:[application/octet-stream] Accept-Encoding:[gzip] Authorization:[Basic QUtJQUpJNldITFdMSjRDVzdVNVE6TCtTTCtVNXc1U29tNFJtWlRSRnhuY1RNSW1tL1RIaXd4alhuZlJkRw==] User-Agent:[Go-http-client/1.1]]" request_id=5eb9fd03-8376-4747-b1f5-df52b898ded5 response_body="foo\n" response_headers="map[Content-Disposition:[filename=\"aa\"] Content-Length:[4] Content-Type:[application/octet-stream] Etag:[\"d3b07384d113edec49eaa6238ad5ff00\"] Last-Modified:[Tue, 19 Jan 2021 16:42:59 GMT] X-Request-Id:[5eb9fd03-8376-4747-b1f5-df52b898ded5]]" sent_bytes=0 service_name=rest_api status_code=200 took=7.67969ms user=me

I was able to fetch all these lines, because they all share the same request_id.  Before this PR tier_fs logs (and many others) carry no request_id field, making tracing impossible.

Fixes #1250.

Fixes #1250.

Codecov Report

:exclamation: No coverage uploaded for pull request base (bugfix/add-api-test-timeout-handler@ce0479b). Click here to learn what that means.
The diff coverage is n/a.

@@                          Coverage Diff                           @@
##             bugfix/add-api-test-timeout-handler    #1259   +/-   ##
======================================================================
  Coverage                                       ?   47.70%
======================================================================
  Files                                          ?      202
  Lines                                          ?    15675
  Branches                                       ?        0
======================================================================
  Hits                                           ?     7477
  Misses                                         ?     7228
  Partials                                       ?      970

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0479b...b62ea43. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (bugfix/add-api-test-timeout-handler@ce0479b). Click here to learn what that means.
The diff coverage is n/a.

@@                          Coverage Diff                           @@
##             bugfix/add-api-test-timeout-handler    #1259   +/-   ##
======================================================================
  Coverage                                       ?   47.70%
======================================================================
  Files                                          ?      202
  Lines                                          ?    15675
  Branches                                       ?        0
======================================================================
  Hits                                           ?     7477
  Misses                                         ?     7228
  Partials                                       ?      970

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0479b...b62ea43. Read the comment docs.

Thanks!  Fixing conflicts introduced in #1258 (and missing here), and pulling.

Thanks!  Fixing conflicts introduced in #1258 (and missing here), and pulling.


10/25-man not showing in panel text

Source: https://www.curseforge.com/wow/addons/titan-panel-classic-raid-lockout?comment=22
I think this was either an intentional change done in PR #34 or a bug following this PR.
Either way I can see how some players would want to see if a raid lockout is for 10/25 in the panel text. It seems there is a color distinction right now, but no text, which I don't think is sufficient seeing as there is a "no colors" options in Titan Panel.
I would purpose to:

[x] Add back the showing of 10/25 in the Panel Text. Example: "NAXX10 ULD10 NAXX25 ULD25"
[x] Add a toggle option in the settings to hide this. Example: "NAXX ULD NAXX ULD"

A build for this is now included in the latest beta version v1.3.3-b02. If no problems are raised I will then include it in the next release.


[Feature Request] Block 60 fps videos.

Add the ability to block 60 fps videos.
Thanks.

Hi. This is already possible by setting in the config-file:
hfr => 0,

Documentation:
   hfr
       Prefer or ignore High Frame Rate (HFR) video streams.

       Try to disable this option if the videos are lagging or dropping frames.


Update azure-stack-deploy-template-powershell.md

Add connet Azure Stack Azure AAD China endpoint, slightly change template deploy using template link instead of download template json file to local machine, change parameters to splatting package as well.

Hi @shzhai, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (shzhai). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

We'll need to investigate these suggestions first. Please monitor the bugs I will send you to keep track of the progress.


Optimize Worldmap Performance

We getting big FPS drop when using map with Biome models. Find a way to make UX smooth.

Fixed in #389


[BUG] Inventory gets messed up when opening a Satellite Terminal.

Version of Advanced Rocketry

AdvancedRocketry-1.12.2-1.7.0-209-universal

Have you verified this is an issue in the latest unstable build

[x] N

Version of LibVulpes

LibVulpes-1.12.2-0.4.2-74-universal

Version of Minecraft

1.12.2

Version of Forge

forge-1.12.2-<IP_ADDRESS>47-universal

Does this occur without other mods installed
[X] No Clue

Running Enigmatica 2 Expert, I can't remove mods from my server without breaking literally everything.

Description of the problem

See screenshots. If I open a satellite terminal part of my displayed inventory (but not my actual inventory) gets filled up with satellite chips. Ranges from 0 to 6+. Picking up anything in the inventory resets the display to what the inventory should actually look like.

https://i.imgur.com/05MqNta.png
https://i.imgur.com/P9wBD32.png

Referenced: https://github.com/zmaster587/AdvancedRocketry/issues/1280

I've tried finding a relation between terminal, inventory, etc. But so far I've failed.
I have 12 terminals, 4 for each data type, and the amount of "Duplicated" satellite chips showing is different for each terminal.
The extra satellite chips shown in the inventory are however duplicates of the one in the actual terminal I'm looking at.
The amount of extras shown isn't even consistent per terminal over time it appears.
On my 'oldest' 3 terminals it's 8,9,8 extras, then the next 3 is 5,6,2 (which was 5,6,4 when I checked 10 minutes ago), etc. There doesn't seem to be a logical progression or reason. This is all with the same inventory to start off with.

I am also hitting this. Enigmatica 2 Expert pack version 1.81a; AdvancedRocketry-1.12.2-1.7.0-221-universal

Me and my friends are having this issue as well. We are playing on a customized version of Enigmatica 2 Light 1.4.5, using 1.7.0 232 universal.


Revised specification

WIP.

Table 2.1 was changed from

to

There was one leftover instance of "rate metrics", changed to "throughput metrics".
One sentence referred to the "LDBC Graph Analytics Task Force", changed it to the "LDBC Graphalytics Task Force".


Datepicker state inconsistency in chrome

When manually typing a time into the datepicker, the value will only be applied when pressing enter. When leaving the text-field by clicking somewhere else (blur), the value will visually remain but the internal value of the component will not change. The value may also revert visually when the value is read from the form by the component (e.g. on submit).

If the value is valid, would you expect it to be applied on blur (without enter) or reverted? @mrkskmn any thoughts?

Hi @fynnfeldpausch , any news on that? IMO if date is valid it should applied right away on blur


archlinux aur nodejs-soccer-go 0.4.0-2

Expected Behavior
as shown in README.md
Actual Behavior
all commands =
✖ Fetching competition...
✖ Fetching matchday...
undefined
410
Steps to Reproduce the Problem

install nodejs-soccer-go 0.4.0-2 from aur on fully updated Archlinux box
execute any soccer-go command

Specifications

Version: 0.4.0-2
Platform:  Archlinux
NodeJS Version: community/nodejs 11.6.0-1 [installed]

Is this a problem with the AUR pkg maintainer, should i flag his pkg out of date or is the problem from upstream?
Regards & thanks for the code :xd

I had a quick look and the "issue" is in the API: we are using v1 which was rendered obsolete at the beginning of the year.
We need to migrate to v2 to solve this. I can work on this but only over the weekend.
@tytondon1234
@cirrusUK (sorry for the late response)

@cirrusUK @tytondon1234 Hi guys, apologize for being so late to the party. Our data provider has recently deprecated the APIs we were using, as @matt-block noticed.
The V2 will also have a stricter free tier and require an API key to work. I can see 2 options going forward:

Move to a client/server model, with me providing the API key on the server
Make users provide their own API key. This will be a bit inconvenient but also will guarantee not running into the free tier capping that a shared API key will probably cause

@cirrusUK @tytondon1234 Hi guys, I've published version 0.5.0 on npm. AUR should follow soon, I'm in contact with the guy and I'll tell him to update his version.
I've decided to go with option 2 for now, meaning everyone has to provide its own API key and set it to SOCCER_GO_API_KEY env var. You can get it here: https://www.football-data.org/client/register
Feedback is welcome

@acifani Im glad to report that its seems to be the AUR pkg at fault. it throws same permissions error even after exporting new API key, however installing with npm it works great, thanks for the code and apoligies for my belated response.
regards


V 0.8.1

All Submissions Basics:

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?
[ ] Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
[ ] Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

New Model Submissions:

[ ] Have you created a .py in ~/pyod/models/?
[ ] Have you created a _example.py in ~/examples/?
[ ] Have you created a test_.py in ~/pyod/test/?
[ ] Have you lint your code locally prior to submission?

Pull Request Test Coverage Report for Build 1559

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 95.599%

Files with Coverage Reduction
New Missed Lines
%

pyod/models/base.py
1
95.49%

Totals

Change from base Build 1510:
-0.02%

Covered Lines:
4388

Relevant Lines:
4590

💛  - Coveralls


ActiveSupport::Notifications support?

Where would be the right place to instrument the 'total time spent serializing per request/controller action'?

Hi Mark!
Depending on the level of granularity, you could instrument the one and many class methods, or the render_as_hash instance method.
When using hash as the format (the default in the current version), you would need to also measure the spent in oj itself when the objects are converted to JSON.


Jars and AARs in multi-module project uploaded to wrong directory

I have the following in my build.gradle:
group = 'co.chatsdk.chatsdk'
version = '4.0.0'

ext {
    bintrayRepo = 'chat-sdk-android'
    bintrayName = 'chat-core'
    bintrayUserOrg = 'chat-sdk'

    publishedGroupId = 'co.chatsdk.chatsdk'
    libraryName = 'ChatSDKCore'
    artifact = 'chat-core'

    libraryDescription = 'Chat SDK Core library for Android'

    siteUrl = 'https://chatsdk.co'
    gitUrl = 'https://github.com/chat-sdk/chat-sdk-android.git'

    libraryVersion = '4.0.0'

    developerId = 'bensmiley'
    developerName = 'Ben Smiley-Andrews'
    developerEmail =<EMAIL_ADDRESS>
    licenseName = 'Chat SDK License'
    licenseUrl = 'https://chatsdk.co/chat-sdk-license/'
    allLicenses = ['GPL-3.0']
}

apply from: 'https://raw.githubusercontent.com/chat-sdk/JCenter/master/installv1.gradle'
apply from: 'https://raw.githubusercontent.com/chat-sdk/JCenter/master/bintrayv1.gradle'

But when I run bintrayUpload the jar and aar files are uploaded to the wrong directory:
chat-core/
    /4.0.0/
       chat-core-4.0.0.pom
       chat-core-4.0.0.pom.asc
    /maven-metadata.xml

chat_sdk_core/
    /4.0.0/
        chat_sdk_core-4.0.0-sources.jar
        chat_sdk_core-4.0.0-sources.jar.asc
        chat_sdk_core-4.0.0.aar
        chat_sdk_core-4.0.0.aar.asc

Why is the module name used rather than the package name?

Still not answer for this issue? It is really annoying.

Thank you for reporting this @bensmiley . This issue occurs since inside the pom.xml the artifactId is configured with a different name then the project name. We are working on a fix for this issue so the artifactId will be populated from the pom if exists and if not will be taken from the project name.

How to resolve this problem? I use kotlin-dsl not groovy

I have resolve this problem by add this config in build.gradle.kts of library:
base {     archivesBaseName = rootProject.name }

Hi All,
I just wanted to let you know that we have released new version of the Gradle Bintray plugin (1.8.1) that should fix this issue. Can you please try this with the new version and let us know the outcome?
Thanks,

@AlexeiVainshtein   version 1.8.1 work well, I've already confirmed it.


Document use of title attribute

I didn't realise Pym.js actually supports the title attribute of the iframe - I can see it was added as a result of: https://github.com/nprapps/pym.js/issues/101
But do a CMD + F on 'title' on http://blog.apps.npr.org/pym.js/ and it returns nothing! Can we update the docs please? Thanks

@ChrisBAshton Hi Chris we are going to improve docs for the 1.0.0 release at the end of August. Will make sure we add title to the docs by then

duplicate of #115


Refactor Process in preparation for Windows support

Commits are best read in order, with their descriptions.

Let's merge.

I was planning on rebasing the windows part of the process refactor on top of this PR to make 100% sure that this PR was complete, but I'm moving back to university so havent had time :(
I'm fine to merge this, but there's a very small but nonzero chance that there might be more amendments coming.


Build on Ubuntu 16.04 test on both 16.04 and 20.04

Following Michael's report that building on 20.04 leads to a *.deb that installs a non-working system, I have adjusted the builds to run off Ubuntu 16.04 and then tested on 16.04 and 20.04.

This seems like a bit of a bandaid. We should fix building on Ubuntu 20.04. This is a suitable intermediate step before we get to that point though.


Update cache_domains.json

What CDN does this PR relate to

Does this require running via sniproxy

Capture method

Testing Scenario

Testing Configuration
<!-- Paste either your docker run command from the DNS container OR explain how you have setup DNS zone files etc to test this issue -->

Sniproxy output
Please paste the output from docker logs <sniproxy container name/id> | sed 's/.*\:443 \[//;s/\].*//' | sort | uniq -c below
<!-- If you are running sniproxy paste the output to the following command
docker logs <sniproxy container name/id> | sed 's/.*\:443 \[//;s/\].*//' | sort | uniq -c
-->

please add to apple updates cache

apple doesn't have http caching of content and has its own mechanism see #132 for detail


Comparison to lex

Essentially the "standard" technique for efficient lexing is to combine regular expressions into a single optimal DFA. This is used by the standard Unix tool lex/flex and described in the classic Dragon Book.
I was expecting a fast lexing crate to do the same. But it seems to not do that; though the implementation is clearly not just a naive approach to lexing either.
It would be convenient if the README included a comparison section, in terms of overall performance and other aspects. I might run some tests comparing the two myself, but I think I'll just post an issue here first anyway.

@ids1024 Logos is effectively a state machine. The upcoming version (#94) is built from a graph of nodes (states) that can do arbitrary jumps to other nodes (states) until a token is lexed. The currently released version isn't really different in principle, except for the fact that it constructs a tree of states, which bloats things up considerably.

The readme is much more explicit now.


ADS: Paparazzi

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3134   👈

This comment was auto-generated by Graphite.

Closing as it’s not valid anymore. Will open again if needed.


Need to post  Alarm to https , How to provide header , also need hostname with alarm

Please answer these questions before submitting your issue.

Why do you submit this issue?
[X ] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

Need to post  Alarm to https , How to provide header. Also how to get the Hostname along with Alarm.
For example need to post the alarms through

curl -X POST
https://*********************/event
-H 'applicationauthorization: dhlhsadkjfhkjsdhkhdf'
-H 'cache-control: no-cache'
-H 'content-type: application/json'
-d '{"Entity": "","severity": "CRITICAL","description":"High CPU Utilization","createdTime": "1573304437","source": "Postman", "priority": "MEDIUM"}'

Bug

Which version of SkyWalking, OS, and JRE?

Which company or project?

What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.

Requirement or improvement

Please describe your requirements or improvement suggestions.

I think you should take a look at this, https://github.com/apache/skywalking/blob/master/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/WebhookCallback.java.
I don't find the authentication configuration right now. Do you want to send a pull request to add?

@wu-sheng how to provide headers details in alarm-settings.yml file.

@Prasanna0806 Why do you ask again?

Our Endpoint required SSL Authentication and getting this error - How to resolve this -
2021-02-08 18:00:25,477 - org.apache.skywalking.oap.server.core.alarm.provider.WebhookCallback - 88 [pool-2-thread-1] ERROR [] - send alarm to https://<IP_ADDRESS>/integration/work failure.
javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed
at sun.security.ssl.Alerts.getSSLException(Alerts.java:192) ~[?:1.8.0_181]
at sun.security.ssl.SSLSocketImpl.fatal(SSLSocketImpl.java:1964) ~[?:1.8.0_181]
at sun.security.ssl.Handshaker.fatalSE(Handshaker.java:328) ~[?:1.8.0_181]
at sun.security.ssl.Handshaker.fatalSE(Handshaker.java:322) ~[?:1.8.0_181]
at sun.security.ssl.ClientHandshaker.serverCertificate(ClientHandshaker.java:1614) ~[?:1.8.0_181]
at sun.security.ssl.ClientHandshaker.processMessage(ClientHandshaker.java:216) ~[?:1.8.0_181]
at sun.security.ssl.Handshaker.processLoop(Handshaker.java:1052) ~[?:1.8.0_181]
at sun.security.ssl.Handshaker.process_record(Handshaker.java:987) ~[?:1.8.0_181]
at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:1072) ~[?:1.8.0_181]
at sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1385) ~[?:1.8.0_181]
at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1413) ~[?:1.8.0_181]
at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1397) ~[?:1.8.0_181]
at

I am not following. We don't support that, at least, no tested. I have given you the codes, which only have 20+ lines. Read and debug them.

ya got it thanks.

@wu-sheng So the way to go here is add configuration in file for https, and then accept cert. path , for this webhook-https, config has to be created as there can be multiple webhook, http and https combination.
Let me know for what I think is correct, or suggest better approach if any, will work on it to submit MR.

Basically, yes. It is better we discuss the format of yaml you propose first.

webhooks:
   http:
     - http://localhost:8081/message/
     #- http://<IP_ADDRESS>/go-wechat/
   https:
     -url:https://ssldomain1.com/message
      key_store_path:<path to keystore>
      key_store_pass:<key_store_pass>
      key_pass:<key_pass>
     -url:https://ssldomain2.com/message
      key_store_path:<path to keystore>
      key_store_pass:<key_store_pass>
      key_pass:<key_pass>

@wu-sheng above is proposal for same.

webhooks:
  http:
    - http://<IP_ADDRESS>/notify/
    - http://<IP_ADDRESS>/go-wechat/
  https:
    - key_pass: testkeypass
      key_store_pass: testpass
      key_store_path: "test path"
      url: "https://ssldomain1.com/message"
    - key_pass: testkeypass
      key_store_pass: testpass
      key_store_path: "test path"
      url: "https://ssldomain1.com/message"

@wu-sheng above is proposal for same.

make sense to me.

But you should know that the alarm configuration file can't be overridden through system env, once this config in the image, it is hard to change things like this.

But you should know that the alarm configuration file can't be overridden through system env, once this config in the image, it is hard to change things like this.

I think, that is separate problem to solve - making this config changeable from GUI. For now I am working on above suggested proposal to push change.

But you should know that the alarm configuration file can't be overridden through system env, once this config in the image, it is hard to change things like this.

I think, that is separate problem to solve - making this config changeable from GUI. For now I am working on above suggested proposal to push change.

Agree.

Questions:

Do we need to add test cases for running a SSL webhook? Any suggestion on approach , if yes?
Any code format guideline? or some xml file I can import.?

Yes, a test case is required. Setting up a mock server like WebhookCallbackTest did.
Code style, https://github.com/apache/skywalking/blob/master/codeStyle.xml.

@wu-sheng Thank you so much for asking, certificates are problem, code is standard have written, but haven't been to certificates before. Not able to get right ones I believe. Would you mind if send a pull request at-least you can see code, by the time I will try generating more openssl certificates. Any tutorial or certificates for same are welcome.

will positively try closing this week, apologies for delay.

@wu-sheng Thank you so much for asking, certificates are problem, code is standard have written, but haven't been to certificates before. Not able to get right ones I believe. Would you mind if send a pull request at-least you can see code, by the time I will try generating more openssl certificates. Any tutorial or certificates for same are welcome.

I am not sure about your question. We are using Apache HTTP component as the client lib, which has already included the SSL/HTTPS logic. Check their document, it should not be hard.

SSL Certificate generation is problem , I don't think am generating correct.
Yes code is pretty straight forward.

I have this, https://github.com/apache/skywalking/blob/master/tools/TLS/tls_key_generate.sh. But it was 3 years ago.
This thing should be very common and widely documented.

Thanks a lot, will recheck.

No update for months.