Add a cache for EDS responses

This is on by default for tests only, will probably be disabled prior to merge
The idea here is to cache EDS responses. Cache invalidation is on a per hostname basis.
Likely bugs that need to be considered before turning this on:

Probably leaks memory
Probably some edge cases where we do not invalidate properly

Note: the reason this PR is so small is I had a PR a couple weeks ago preparing for this: #25598

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
3160e5a6db23f9429588b98925fa21c69e6ba609
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
3160e5a6db23f9429588b98925fa21c69e6ba609
link
/test release-notes_istio

unit-tests_istio
3160e5a6db23f9429588b98925fa21c69e6ba609
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
62d758e5daabc330710269d23041c6bdbe851608
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
62d758e5daabc330710269d23041c6bdbe851608
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
62d758e5daabc330710269d23041c6bdbe851608
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
62d758e5daabc330710269d23041c6bdbe851608
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
62d758e5daabc330710269d23041c6bdbe851608
link
/test integ-pilot-k8s-tests_istio

lint_istio
f623d1bc601eabe0ceec2978ad0226bf9f1427ba
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
7f4089d3ceb24dfa5b6f45bbac61f1c25940ceae
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

In the pilot integ test, 95% of EDS requests were cached. So the hit rate is pretty huge

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
7f4089d3ceb24dfa5b6f45bbac61f1c25940ceae
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

I think if DR updates we don't invalidate the cache - need to update

What's the influence on memory cost?

What's the influence on memory cost?

I am a bit confused - I did a memory profile and it doesn't even show up. Not sure how its so little...

It depends on how many endpoints and how many sidecars connected

I have 1k sidecars. I will do some testing later with large scale
On Mon, Aug 3, 2020 at 6:52 PM Zhonghu Xu<EMAIL_ADDRESS>wrote:

It depends on how many endpoints and how many sidecars connected
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/26024#issuecomment-668331617, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXL6ZCEO7T4D7YQ6CLDR65SVLANCNFSM4PQ77KYQ
.

@hzxuzhonghu I posted some graphs of testing this change above

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test unit-tests_istio

analyze-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test unit-tests_istio

analyze-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test analyze-tests_istio

release-test_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test unit-tests_istio

analyze-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test analyze-tests_istio

release-test_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test release-test_istio

gencheck_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test unit-tests_istio

analyze-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test analyze-tests_istio

release-test_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test release-test_istio

gencheck_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test unit-tests_istio

analyze-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test analyze-tests_istio

release-test_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test release-test_istio

gencheck_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-ipv6-k8s-tests_istio

lint_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test unit-tests_istio

analyze-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test analyze-tests_istio

release-test_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test release-test_istio

gencheck_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-ipv6-k8s-tests_istio

lint_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test lint_istio

integ-security-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test unit-tests_istio

analyze-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test analyze-tests_istio

release-test_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test release-test_istio

gencheck_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-ipv6-k8s-tests_istio

lint_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test lint_istio

integ-security-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test unit-tests_istio

analyze-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test analyze-tests_istio

release-test_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test release-test_istio

gencheck_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-ipv6-k8s-tests_istio

lint_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test lint_istio

integ-security-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test unit-tests_istio

analyze-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test analyze-tests_istio

release-test_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test release-test_istio

gencheck_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-ipv6-k8s-tests_istio

lint_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test lint_istio

integ-security-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test unit-tests_istio

analyze-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test analyze-tests_istio

release-test_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test release-test_istio

gencheck_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-ipv6-k8s-tests_istio

lint_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test lint_istio

integ-security-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test unit-tests_istio

analyze-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test analyze-tests_istio

release-test_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test release-test_istio

gencheck_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-ipv6-k8s-tests_istio

lint_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test lint_istio

integ-security-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
bf6e3773084375eb70642324a6c67ab81fd56b26
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Let me know if you're ready - I think it would be great to get it in so it's tested more, and we can iterate with the various review comments.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
3d7d69774a7292c43cc3775bf74256376509c66c
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
ab7fb8dd3c90fd415cc2e511257cdc14f4651322
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

As to no big influence on heap memory, maybe it is because the marshaled eds data size is very small. 2500 *1k(should be far less than 1k) = 2.5MB

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
4dbd8dbb92efda3bbdf45f12c622fe80a62c3961
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


add checks before writing and reading cache

fix for https://github.com/facebookincubator/create-react-app/issues/1656

I think we should use the Babel version, it already handles edge cases well and IMO is written more consistently

So we should close in favor of #159?

Or maybe you want this merged/released asap?

Let's do https://github.com/MoOx/eslint-loader/pull/159 instead.


Fix #14786: Suggestions API

Describe your changes:
Fixes #14786

I worked on ... because ...

Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

so far I am able to add new suggestions via Python. I think we need to delete the suggestions for a specific entity once the entity is deleted. Unit tests in python clean up the service but the db still shows older suggestions


luaPackages.luadbi: 0.6 -> 0.7.1

Motivation for this change
Update version and fix this error - https://github.com/NixOS/nixpkgs/issues/53131
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build luaPackages.luadbi

Thanks!


Fix errors detected by PHPStan

@Crell Try using phpstan analyze -l max src/ tests/

Thanks, @szepeviktor!

You're welcome.


Added hybrid texture/procedural brick example

This is a great contribution to the MaterialX project, a material example with both procedural elements and a thoughtful artistic interface.  Thanks @dlarsson-adobe!


add comments in the _config.yml

this file has comments-- it is VERY useful: https://github.com/naturalistic-data-analysis/naturalistic_data_analysis/blob/master/_config.yml
we should do it as well

Sure thing, will include them in the next build.

I added comments in the newest build 😄

I added comments in the newest build 😄

Brilliant! For the record, comments were added in 150eea141e7cb34d07059b6e6c10332127770dae
@zelenkastiot in the future can you please refer to the exact commit when you address an issue? In general we work with PRs, but in this case we are in a rush so we push to master directly so we need to have a reliable and convenient way to inspect changes made to the repos. Thank you.


Numpy backwards compat

Additional fixes for #16

@dmbelov can you check this one, please.

Okay, coverage went down a bit, probably want to add some tests for _conv

Let's see what it says now.

all green, apparently.

merged to maint-0.7.x d620932


feat: get password from env variable

Adds possibility to get password from environment variable

@KDima23 Thanks for the PR. The environment variable should better be prefixed e.g. SS_PASSWORD to avoid collision with others.


Data protection - Include CSRF Token  in Request-/Response header

Motivation
To prevent an evil website from session riding (when the cookie's same-site property is not set), each request needs to have a (session-unique) CSRF token to be sent with it inside the HTTP header.
Requirements

send session-unique token with the login response (as sessionToken)

use the token from the token cookie

stop setting the token cookie
validate the token for each HTTP request and reject it on mismatch

header attribute name: Xyna-CSRF-Token
for all HTTP methods (including GET)
not set for all kinds of login requests

See also
Respective frontend issue: https://github.com/Xyna-Factory/xyna-zeta/issues/49
Xyna Property to de-/activate
xmcp.guihttp.csrf (default off with Xyna 9.0.3.x)

Breaking Change management:

wiki: https://github.com/Xyna-Factory/xyna-factory/wiki/Breaking-Change:-CSRF‐Token
activation: https://github.com/Xyna-Factory/xyna-factory/issues/866
cleanup: https://github.com/Xyna-Factory/xyna-factory/issues/867


How to go back to the previous version?

Describe the feature
After some time, I returned to a project that used the module version ^8.0.0-beta.10. A lot of random things stopped working for me and I don't have the strength to track down all these bugs anymore. Why, despite not changing the version of the package, has it changed for me and is there any way to return to the previous, working version?
Additional information

[ ] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide (The contribution guideline of nuxt-modules/i18n is compliant with Nuxt too).
[X] Check existing discussions and issues.

I'm working on this PR!
https://github.com/nuxt-modules/i18n/pull/2025
8.0.0-beta.11 is buggy, so especially vue-i18n configuration and js/ts resources
Therefore, we recommend using v8.0.0-beta.10.

Why, despite not changing the version of the package, has it changed for me and is there any way to return to the previous, working version?

The changes in v8.0.0-beta.11 are explained in the release note.
PRs or issues are linked to the items listed there.
https://github.com/nuxt-modules/i18n/releases/tag/v8.0.0-beta.11
The disruptive change in v8.0.0-beta.11 is that the vueI18n option is now a config file.
To back to the previous version, you can simply pin v8.0.0-beta.10 in package.json.

@kazupon I do not understand this. I'm pretty sure I was using just that version in my project and still had the problem. Just to be sure, I switched to a different project which, after reinstalling the packages, still works. Sorry for the confusion.
I also found a problem that was largely responsible for my problems. I'll create an issue for this soon.


MF2 Improvements and Fixes Mark 3

This correctly identifies all the test data and adds some additional enhancements.

OK, the tests seems to be green, but I still have problems if I try some mentions by hand.

I may change to a less stringent URL verification.

I looked at the two failed tests. Because no URL in any of the h-cards matches the URL of the submitted page, it fails. The example output shows an author name that shouldn't be parsed.
Either way, I changed the is_url function to be less restrictive if WP_DEBUG is on and more if it isn't.

now the tests are failing! do you think it's because of the author changes?

The author test is failing because of the issue as mentioned. But it is my opinion that it is correct. The comment author in the test is not correct.

Unless the test forces the source URL to be on the same domain as the source author URL, those tests fail.

can you fix the test?

Having bad luck with the tests.But it works in real life.

This does not help... can you please fix tests https://travis-ci.org/pfefferle/wordpress-semantic-linkbacks

This may take a bit. But will work on it.

thanks. If the tests does not work, we have a really hard time to add changes.


Bug fix - mismatches in the staff filing dropdown menu

*Issue:*https://github.com/bcgov/entity/issues/23820
Description of changes:
Update the display logic for the menu options in the "Add Staff Filing" dropdown, using the same logic as the old codebase (https://github.com/bcgov/business-filings-ui/blob/3a62b2b470bf16c181b879057823ff795e5faf68/src/components/Dashboard/StaffNotation.vue#L85-L230)
Major update: instead of calling the isAllowedToFile(FilingTypes), use the wrapper function isAllowed(AllowableActionE)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

/gcbrun

Temporary Url for review: https://business-dashboard-dev--pr-59-xa7tgnlo.web.app


Validation needed for fault injection because target might not have L7 layer

For example, if a service doesn't have a port named with http prefix it will be treated as TCP, even if it is doing HTTP.
Adding route-rules with faults against this port should be considered an error.
Note that this means that to work with Istio a Kubernetes Deployment must have a port.  It isn't sufficient to leave the port off the Deployment description and specify it when creating the Service.  To set a name for an anonymous port, a K8s user may do kubectl patch deployment <DEPLOYMENT> --type='json' -p='[{"op": "add", "path": "/spec/template/spec/containers/0/ports/0/name", "value":"http"}]' before or after injecting the Istio proxy.

Since k8s protocol spec only allows tcp and udp as possible fields, the user must prefix the field "name" of the port with "http", "https", "http2", "grpc", to indicate the port is used for l7. Document this requirement.

Closing this, as a duplicate of #418


Add clean and qemu test targets to Makefile.

Selecting the loader.efi in OVMF manually is not super convenient, but at least it is a reproducible way to run the compiled EFI binary without rebooting the whole machine.
I still cannot produce a working binary on my system, but at least, this Makefile target allows me to fail faster.
Tested on vanilla Windows 11 with WSL Ubuntu and gnu-efi 3.0.11 and qemu 6.2.0.

I will not merge this. It's specific to your testing environment and even the comment mostly describes your situation. All things don't need to be merged upstream, it's still ok to keep them locally.
To make your testing experience smoother, you can copy the .efi file to efi_test/EFI/boot/bootx64.efi which is loaded by default, or you can create a UEFI shell script efi_test/startup.nsh with contents FS0:\EFI\HackBGRT\loader.efi. Tested on Arch Linux with QEMU 8.1.2 and edk2-ovmf 202308.

Howdy Metabolix, thanks a lot for taking the time to look at this PR!
I totally understand that this is your repo and that you don't want to merge a PR which may be opinionated towards my system.
I tried building your software. It compiled, but it always crashed for me. In qemu, with this X64 Exception Type - 06(#UD - Invalid Opcode) and with just a blank screen on real hardware. Cross-compiling an UEFI application with w64-mingw32 seems to be a rather uncommon choice and I had quite a lot of fun debugging why I could not get this running on my system. 😄
On my system (ubuntu 22.04 on wsl on win 11), it looked like the gnu-efi w64-mingw32 compiled, but produced a buggy library which messed up the calling convention. I finally found this via printf debugging and when I realized that specifying my own uefi_call_wrapper made the thing work. My uefi_call_wrapper was basically just passing through the function call without adapting calling convention, since w64-mingw32 already uses the correct calling convention. I fund that my gnu-efi version 3.0.15 did not compile correctly with mingw, because the mingw MAKEFILE file choked on the mingw gcc version, but did not abort compilation.
I have modified the HackBGRT Makefile such that it vendors gnu-efi as a git submodule and passes the compiler options to make this compile. The -DGNU_EFI_USE_MS_ABI for both gnu-efi and HackBGRT is the important option which makes sure both use the default calling convention.
If I find the time to cleanup all these custom hacks I added and create a clean branch, would you be interested in a PR which vendors gnu-efi as a submodule to help compiling HackBGRT more hermetically?

Thanks for the detailed explanation. Funny, my problem is quite the opposite: I can't make a working binary with the native (Linux) gnu-efi linker scripts and objcopy magic, and that's why I ended up using MinGW, which works great. In the long run, I would prefer to switch to the native GCC. Another interesting alternative is to rewrite the whole thing in Rust, which seems to produce EFI working binaries out-of-the-box with the uefi-rs crate.

Meta: I think we can close this PR, this discussion is now basically off-topic chat 😄  Thanks for your explanations 💟

Heh, interesting. I once played with the objcopy magic to build an UEFI application and even linked a Rust library into it. I borrowed heavily from shim. Limitations: I only used gnu-efi headers and I did not link against the gnu-efi lib.
While debugging my MinGW issues, I found this interesting article: Goodbye Gnu-EFI!
While I haven't tried it, it looks like clang is a sweet spot for a compiler: It can natively compile to the PE Windows style (no cross-compilation) and clang and rust  work together nicely. For some architectures, folks even claim that cross-language link-time-optimization is working between the two. When I tried 2.5 years ago for the wasm target thoug, it did not work. But wasm limitations do not apply here.

Haha, I reopened this by accident. Thanks for your useful research. I've now switched to Clang, included gnu-efi as a submodule to get the headers but also reimplemented some functions to avoid actually building and linking the whole gnu-efi. Maybe it now works for you too?

I think I got a working bootx64.efi compiled with your clang setup at 7ccdcc4a7706e11753a387f5f7424c885d855bf7. 👍
Very smooth 👍
I did not test the csharp or shim or signing part, I just took the compiled bootx64.efi and copied it to my working 2.1.0 branch and installed it.
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.3 LTS
Release:        22.04
Codename:       jammy

$ clang --version
Ubuntu clang version 14.0.0-1ubuntu1.1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

and
lld-14 (1:14.0.0-1ubuntu1.1)

on wsl on win 11


Error running sample project

Traceback (most recent call last):
  File "/Users/thisas/Desktop/leapc-python-bindings/leapc-python-api/src/leap/__init__.py", line 74, in <module>
    from leapc_cffi import ffi, libleapc
  File "/Applications/Ultraleap Hand Tracking.app/Contents/LeapSDK/leapc_cffi/__init__.py", line 1, in <module>
    from ._leapc_cffi import ffi, lib as libleapc
ModuleNotFoundError: No module named 'leapc_cffi._leapc_cffi'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/thisas/Desktop/leapc-python-bindings/examples/tracking_event_example.py", line 7, in <module>
    import leap
  File "/Users/thisas/Desktop/leapc-python-bindings/leapc-python-api/src/leap/__init__.py", line 80, in <module>
    raise ImportError(
ImportError: Cannot import leapc_cffi: Unknown error, please consult readme for help. Attempting to find leapc_cffi within /Applications/Ultraleap Hand Tracking.app/Contents/LeapSDK. Caught ImportError: No module named 'leapc_cffi._leapc_cffi'

same

Renaming ~\Ultraleap\LeapSDK\leapc_cffi\_leapc_cffi.cp38-win_amd64.pyd or whatever .pyd/.so is present to _leapc_cffi.pyd seemed to fix the issue for me.

@EthoIRL  I've tried that,

But it still seems to give the same error
(base)  ~/Desktop/leapc-python-bindings/ [main] python3 examples/visualiser.py
Traceback (most recent call last):
  File "/Users/thisas/Desktop/leapc-python-bindings/leapc-python-api/src/leap/__init__.py", line 74, in <module>
    from leapc_cffi import ffi, libleapc
  File "/Applications/Ultraleap Hand Tracking.app/Contents/LeapSDK/leapc_cffi/__init__.py", line 1, in <module>
    from ._leapc_cffi import ffi, lib as libleapc
ModuleNotFoundError: No module named 'leapc_cffi._leapc_cffi'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/thisas/Desktop/leapc-python-bindings/examples/visualiser.py", line 1, in <module>
    import leap
  File "/Users/thisas/Desktop/leapc-python-bindings/leapc-python-api/src/leap/__init__.py", line 80, in <module>
    raise ImportError(
ImportError: Cannot import leapc_cffi: Unknown error, please consult readme for help. Attempting to find leapc_cffi within /Applications/Ultraleap Hand Tracking.app/Contents/LeapSDK. Caught ImportError: No module named 'leapc_cffi._leapc_cffi'

@The-Real-Thisas
_leapc_cffi*.pyd is a specifically for window's and window's alone. Please try renaming _leapc_cffi.cpython-38-darwin.so to _leapc_cffi.so. I've only tested it on a window's machine for now so your mileage may vary.
https://github.com/ultraleap/leapc-python-bindings/blob/2341c6c3db5dc08236bb52890d8c43a224139694/leapc-python-api/src/leap/__init__.py#L24C1-L29C2

Have you tried rebuilding the module?
https://github.com/ultraleap/leapc-python-bindings#missing-compiled-module

Also on MacOS. I tried renaming that _leapc_cffi.cpython-38-darwin.so to _leapc_cffi.so and re-ran:
python -m build leapc-cffi
pip install leapc-cffi/dist/leapc_cffi-0.0.1.tar.gz
pip install -e leapc-python-api
python examples/tracking_event_example.py

and still getting:
ImportError: Cannot import leapc_cffi: Unknown error, please consult readme for help. Attempting to find leapc_cffi within /Applications/Ultraleap Hand Tracking.app/Contents/LeapSDK. Caught ImportError: dlopen(/Users/chaim/miniconda3/lib/python3.9/site-packages/leapc_cffi/_leapc_cffi.abi3.so, 0x0002): symbol not found in flat namespace '_LeapCameraMatrix'

when I try the example.

I remember a few years ago, there was a Javascript API and all that was necessary was to plug in the Leap Motion device and you could start getting signal from it to do cool things in a web browser. I actually wanted to make a demo to show "how easy it is" to get started with the Leap Motion for an upcoming presentation, but with the latest updates it looks like you are out of luck unless you are using Unity or Unreal Engine.
This Python API seemed promising, but that it cannot even run the example in the README is disappointing.

I still have yet to try this on a Raspberry Pi 4. (I tried it on a RP3 and it did not work, but that seems correct according to the system requirements.) Still though, the barriers to entry with the Leap Motion seem to have been raised in the past few years.

Oh, re-reading, I just noticed the error message above is not the same as what I am getting:
symbol not found in flat namespace '_LeapCameraMatrix'

If it would help, I could make a new issue for this...

It seems to work @EthoIRL after renaming to _leapc_cffi.so , trying to find the root of this bug it seems to be in https://github.com/ultraleap/leapc-python-bindings/blob/main/leapc-cffi/setup.py because in https://github.com/ultraleap/leapc-python-bindings/blob/main/leapc-python-api/src/leap/init.py#L24 the check passes however. Here https://github.com/ultraleap/leapc-python-bindings/blob/main/leapc-cffi/setup.py#L36 it's static. Whats weird is that on Darwin (mac) it's looking for 'libLeapC.5.dylib' which does indeed exist so I don't know what the libLeapC.so has to do with it, it's possible since I'm on m1 it's trying to compile rather for Linux-Arm ?

I'm going to see if I can make a fix by using fnmatch to find the file using the same patterns as the https://github.com/ultraleap/leapc-python-bindings/blob/main/leapc-python-api/src/leap/init.py#L24

I don't quite understand why in https://github.com/ultraleap/leapc-python-bindings/blob/main/leapc-python-api/src/leap/init.py#L17 references the dylib https://github.com/ultraleap/leapc-python-bindings/blob/main/leapc-python-api/src/leap/init.py#L24C1-L24C1 references the .so file ?

@chaimpeck This error happens if you installed the wrong version of the hand tracking on your Mac. There are two versions depending on your architecture: M1 & M2 (for ARM64), and Intel (for x64). Make sure you use the right one for your Mac.
@The-Real-Thisas If Python cannot find the library it could be because you're using a different version of the Python interpreter than the one that was used to build the CFFI module (CPython 3.8 at the time of writing this). In that case, you need to rebuild the module: https://github.com/ultraleap/leapc-python-bindings#missing-compiled-module
I've been testing this on a Mac M2 today and it works. No need to rename anything, just following the instructions should work.

@chaimpeck This error happens if you installed the wrong version of the hand tracking on your Mac. There are two versions depending on your architecture: M1 & M2 (for ARM64), and Intel (for x64). Make sure you use the right one for your Mac.

I have the right version installed and got the same error, tried it today on a M1 Mac, with Python 3.8 (even got the error after rebuilding the CFFI module).


Using the Universal Vocoder

Hello! Can you please tell me if I can use your universal vocoder (trained on ~70 hours singing data) to get a DiffSinger (SVS) model by training on English data or do I need to train it from scratch on English data? If so, how can I do it? I want to get a model that synthesizes English singing without a Chinese accent. I want to make sure that there won't be any problems due to different phonemes.

No difficulties were found in inference with other phonemes.

hi @ReyraV , may I know which phonemes set that you used for English? I wonder why there is no issue while you were using another set instead of pinyin.

@bao-dai Hello! I used my own phonemes. You can use any phonemes. They just have to match the pronunciation. For example, you can use the phonemizer library or make your own mapping. Since the training takes place from scratch, then the data preparation was performed from scratch according to the example. Accordingly, the old phonemes are not used anywhere.


1.19.3 Incompatibility

Seems quite redundant to make this issue; however, 1.19.3 compatibility does not yet exist. Hopefully we can see this at some point in time. If not, I completely understand!

I would love to have this too - thanks already 😊

love this mod, please update to 1.19.3
thanks in advance <3

miss this mod on 1.19.3 T.T


Hunger games

Is hunger games fixed if it isnt fix it plox so I can use it

@DaAwesomeRazor Hunger games no longer exists lol

@Tyler3D Its ok i fixed it

@Tyler3D All you gotta do is change the ticks, and spawn points and some collision stuff and it works

@DaAwesomeRazor Ik but Mega deleted it a long time ago

Nice job on fixing it tho!

so can you send  me tha server file

@DaAwesomeRazor Pull request?

hi @Megabyte918 ^^

@Megabyte918  @Gigabyte918  are clon lmao xD

no We are Twin bro XD

my old name is PrinceDark9243 now Gigabyte918 lmao

but i am little different profile lmao


How to affect a query Limit?

I'm converting some code over from another tool, and have a query that wants never more than 10 records.
Previously I passed Limit=10 and it all worked.
There appears no way to specify that in Bloop, and the history suggests this was deliberately removed?

Thanks for opening an issue; this needs to be clarified in the docs.  The Limit Parameter is a bit subtle (at least to me) and I've gone back and forth on keeping it numerous times.  The final decision was that anyone that actually needs the Limit parameter as it exists (and not as it's usually used) will nearly certainly not use Bloop for performance reasons.
To answer your question directly, I'd recommend using itertools.islice:
from itertools import islice

for user in islice(engine.scan(User), 5):
    pass

Probably more detail than you want
I believe most people expect limit to say "when I iterate over my Engine.query or Engine.scan there must mot be more than limit items".  Meanwhile the DynamoDB API defines Limit to mean "for a single call only evaluate up to Limit items before applying any filters".  Because Bloop doesn't expose the individual query calls with continuation token and instead gives you a single Iterable that automatically handles pagination, the concept of a limit doesn't really apply.  Because each next() for a query or scan will follow any number of continuation tokens, limiting the items evaluated per continuation token doesn't provide any additional throughput control to the client.
There's an argument to be made that anyone using Bloop shouldn't mistake a limit:int=0 param for translating into the DynamoDB API equivalent due to the above point (such an interpretation would necessarily be meaningless) but this now burdens the user with thinking through the implementation details of Bloop to understand how a local parameter maps to the wire api.
Here are the previous issues around the query/scan api and the limit param specifically, only intended to provide additional context for the curious:

#43 - While debugging an unrelated issue, it's noted that the old chaining syntax for building up queries is unclear and silently does the wrong thing.  Specifically, https://github.com/numberoverzero/bloop/issues/43#issuecomment-227541536
#44 - Although limit isn't mentioned specifically, this issue dives into two options for building up query and scan in pieces.  Neither option is used today, but the tradeoffs explored will lead to the current syntax, specifically in the next issue.
#54 - The 1.0 syntax is born, heavily inspired by the transformation Requests' Session object underwent for 1.0.
#58 - The issue where I realize I've misunderstood how Limit works, and try to find the right value to optimize speed.  The intent here was to reduce the Limit wire parameter as the local iterable approached its limit so eg. if the local limit was 50 and we'd yielded 35 results so far, the api Limit might be reduced to 30 to reduce consumed throughput.  Since this could backfire (for a heavily filtered query) and cause many more calls, I opted to leave the default alone.
#73 - Only a brief mention here about the planned syntax change in 1.0 as the op's code provides an additional data point that the silent failure with filter chaining was dangerous: https://github.com/numberoverzero/bloop/issues/73#issuecomment-257186412

Nope... that level of detail was awesome :)


Cleanup store initialization

Summary
Rework the store initialization methods to lay the groundwork for upcoming side effect libraries. This PR should effectively be a no-op from the application's perspective.
Ticket Link
None.
NONE

@lieut-data Is there anything specific that needs to be tested, beside the app starting? Thanks

@jgilliam17, I'd recommend running e2e tests, and double checking an installation with plugins. (I've already tested with Incident Collaboration.)

Thank you @lieut-data
Verified PR E2E results against master E2E run
4 test cases failed or timed out on the PR, but passed when testing manually

Files and Attachment/channel files - passed
Integrations/outgoing webhook overridden username and Profile pic (Using MM UI) - passed
Team setting team spec/member can view and search members - passed
Toast/permalink post view combined with new message toast - passed

There was an error when logging out (todo errors repro on master) may be related to these changes

Thanks, @jgilliam17! The incident collaboration error looks like the same type as the todo plugin, and is probably something we should handle better in our product. My bet is that it's non-deterministic: can you confirm if you sometimes see it in master, or does it reliably only reproduce in this PR?

@lieut-data re-tested, my original sample size of two logouts was too small to catch it, it reproduces on master(and other test servers); not isolated to this PR.


Can we convert the ssg graph index into general graph format?

Hi,
I am interested in your work and want to use ssg graph to my own implemented search algorithm.
I want to know this graph is stored? What is it data layout or looks like?
Can I convert it into a general graph format and dense matrix/ adjacent list/ CSR something like that?

Thanks for the interests.
The graph is stored as a binary file. The format is for each line we store D+1 int64 number. The first number is the degree (the number of neighbour nodes), followed by D int64 numbers, which are the indices of the original data.
Of course, you can convert it to any format, only needs a little coding.
------------------ Original ------------------
From: Zhenlin Wu @.>
Date: Sat,Nov 4,2023 11:26 AM
To: ZJULearning/SSG @.>
Cc: Subscribed @.***>
Subject: Re: [ZJULearning/SSG] Can we convert the ssg graph index into generalgraph format? (Issue #9)
Hi,
I am interested in your work and want to use ssg graph to my own implemented search algorithm.
I want to know this graph is stored? What is it data layout or looks like?
Can I convert it into a general graph format and dense matrix/ adjacent list/ CSR something like that?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Branch : Quicklogic : symbiflow supports only 32 IO's though device has 46 IO's

Symbiflow supports only 32 IO's though device has 46 IO's
Symbiflow throws error when a design has more than 32 IOs:
Error 1:
Type: Other
File: /tmp/really-really-really-really-really-really-really-really-really-really-really-really-really-long-path/conda/conda-bld/vtr_1583635602183/work/vpr/src/pack/pack.cpp
Line: 180
Message: Failed to find device which satisifies resource requirements required: PB-LOGIC: 867, PB-ASSP: 1, PB-SYN_VCC: 1, PB-SYN_GND: 1, PB-BIDIR: 46 (available PB-LOGIC: 891, PB-ASSP: 1, PB-SYN_VCC: 1, PB-SYN_GND: 1, PB-BIDIR: 32)
The entire flow of VPR took 2.64 seconds (max_rss 52.1 MiB)
rtl.zip

hi @rakeshm75 are you using the latest code? This issue has been resolved more than a week ago. VPR reports the available IO in the following way:
  PB-BIDIR     : 32
  PB-SDIOMUX   : 14

So it handles both types of IOs and all 46 of them. This pcf maps all the available pins https://github.com/antmicro/symbiflow-arch-defs/blob/quicklogic-upstream-rebase/quicklogic/tests/quicklogic_testsuite/top_120_13/chandalar.pcf

Hi Karol,
Thanks for the update.
Yes, I am using the latest code (pulled it today).
Now, I ran top_120_12 design (that you referred above) which also uses all the 46 IOs. This design
(top_120_12) runs fine without any issues.
The difference between the 2 designs with respects to IOs are:
1. top_120_12 design does not use the bipad macro in rtl
2. design6 uses the bipad macro in the rtl
bipad u_bipad_I0  (.A(GPIO_Out[0]), .EN( GPIO_oe[0]), .Q(GPIO_In[0]), .P(GPIO_PIN[0]));
bipad u_bipad_I1  (.A(GPIO_Out[1]), .EN( GPIO_oe[1]), .Q(GPIO_In[1]), .P(GPIO_PIN[1]));
bipad u_bipad_I2  (.A(GPIO_Out[2]), .EN( GPIO_oe[2]), .Q(GPIO_In[2]), .P(GPIO_PIN[2]));
.
.
bipad u_bipad_I29 (.A(GPIO_Out[29]), .EN( GPIO_oe[29]), .Q(GPIO_In[29]), .P(GPIO_PIN[29]));
bipad u_bipad_I30 (.A(GPIO_Out[30]), .EN( GPIO_oe[30]), .Q(GPIO_In[30]), .P(GPIO_PIN[30]));
bipad u_bipad_I31 (.A(GPIO_Out[31]), .EN( GPIO_oe[31]), .Q(GPIO_In[31]), .P(GPIO_PIN[31]));
bipad u_bipad_I32 (.A(GPIO_Out[32]), .EN( GPIO_oe[32]), .Q(GPIO_In[32]), .P(GPIO_PIN[32]));
bipad u_bipad_I33 (.A(GPIO_Out[33]), .EN( GPIO_oe[33]), .Q(GPIO_In[33]), .P(GPIO_PIN[33]));
.
.
bipad u_bipad_I44 (.A(GPIO_Out[44]), .EN( GPIO_oe[44]), .Q(GPIO_In[44]), .P(GPIO_PIN[44]));
bipad u_bipad_I45 (.A(GPIO_Out[45]), .EN( GPIO_oe[45]), .Q(GPIO_In[45]), .P(GPIO_PIN[45]));
Bipad macro should be applicable to both FBIO[31:0] (which is PAD[31:0]) & SFBIO[13:0] (which is PAD[45:32]).
Regards,
Rakesh

design6_rtl_w_PCH.zip

I see.
AFAIK, the SDIOMUX pins (SFBIO) does not have any configurable buffers (in opposite to BIDIR ones).
I assume we should simply remove the bipad instantiations for SFBIO pins  in synthesis. Is that correct?

Hi Karol,
Both FBIO (PAD[31:0]) and SFBIO (PAD[45:32]) can be configured as bidir pads. We should be able to use the bipad macro with SFBIO pads as well. SFBIO does not have the PREIO as the FBIO, but even on SFBIO the OEN and REN signals are driven from the FPGA interface like the FBIO.
I have attached the diagram of FBIO and SFBIO here.
Regards,
Rakesh
S3_FPGA_IO.pdf


Update app-service-web-tutorial-auth-aad.md

@MiguelFernandez : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified the update (matches the code).
@MiguelFernandez Thanks for submitting the update.


Lspsaga not died. will be update

Hello :) I was away for a long time due to my health. The operation was successful. Currently I will rewrite and maintain my project.
Thanks

Welcome back @glepnir !!! You've left a big void in neovim community. We all ware very worried . Happy to see you back ❤.
Sorry didn't do a good job maintaining a fork of lspsaga but kept alive a bit 😅.

So good to see you're OK. <3

Welcome, you don't know me at all but I came every 15 days to see if you were back 😊, I'm glad you are well.

Glad to see you back and healthy!
What is your plan for the rewrite?

Welcome back! Nice to see that you are fine now!

Glad to see you back !

@danielo515  rewrite some old code and add some new features ?  currently i need rewrite dashboard and improve galaxyline .

Honestly, I think lspsaga should have dealt with that first. The current progress  dashboard will complete rewrite and improve at tomorrow. then I will improve lspsaga. about galaxyline

Add hide_line option that can hide statusline in some special buffers
Reduce the length of the configuration file. Currently a galaxy line configuration requires more than 100 lines or more. Is there a better design?
Support async job
Support new statusline = 3.

So glad to hear that, hope everything's fine, thanks for the amazing work!


Seeking before playback start not working consistently

We have a feature where the last queue is restored when restarting our app. If the user already listened to X seconds of the current track, the player state will be restored to that position by first loading the queue (a ConcatenatingAudioSource), and then calling player.seek() to set the player to the correct position.
However, the position will reset to 0 before playback starts. I've had it work before when using debug builds (release build didn't work), but cannot reproduce that any longer. Currently it's resetting to 0 every time.
Similar behavior can also be observed with the just_audio_media_kit_example project, where seeking before playback starts will also be briefly reflected in the UI, but then playback will start at 0. This can be tested with the following modification:
try {
  // Preloading audio is not currently supported on Linux.
  await _player.setAudioSource(_playlist,
      preload: kIsWeb || defaultTargetPlatform != TargetPlatform.linux);
+ await _player.stop();
+ await _player.seek(const Duration(seconds: 45));
} catch (e) {

Interesting. I'll try this out tomorrow. Thanks for taking a look.
Hopefully the fix will be released soon, but the workaround would definitely be nice to have if it works. I'll report back!

@Chaphasilor Any news?

Haven't had time to look at it yet, busy with exams. But we're making progress with desktop support on all fronts, so I will definitely check this out in the coming days!

just_audio_media_kit v2.0.2 has been published which includes the fix (albeit temporary)

Okay, technically that was "in the coming days", but I'm still sorry it took me so long to take a look. Everything works fine with the update! Thanks a lot :)
Onto the remaining issues... ^^


Add UVM

###Universidad del valle de México
https://uvm.mx

Sorry If something is wrong, first time using github

@Dexterpol-A21 I am sorry, the domain my.uvm.edu.mx is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Pack at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).

I understand, guess the only thing left to say is "te maldigo UVM", I learned some things doing this process, so thank you for that


[WARNING] Niantic seems to ban IP but not accounts

After speaking a lot of people on Slack, it's seems that Niantic bans IP. Those people connects the bot and can't pokestops... But logging with the phone (with a different account) seems to solve the problem.
So I think that Niantic bans the bot's IP but not account! Why? I don't know... Maybe collecting other bot's IPs to ban them all!
PokeBot, ban them all!
There is multiple types of ban : "Soft IP ban" : Ban the IP but not the account (not perm). "Hard IP ban" : Ban the IP perm. "Soft ban" : Account banned not perm, can login but no catch or spin. "Hard ban" : Perma ban (Read data error on phone)

we already know about it, it's called the softban IP address. it will wore out after one hour or so.
someone (my friend) got his account can connect but always get server error. even using bot and phone.

@k4n30 please reopen the issue. It's a major change in the Niantic mind.

#3700 for continued conversation

I get this message when i logged in to pokemon go this morning. Failed to get data from server. Is it a perma ban from pokemon. Im just using this apps for 2 weeks. Any help?

try the account on the legit game on phone.
none of my 3 bots got banned - they are running since september.

Im running it on my phone all the while.... only this morning happen. Last night still can on. Any help

I was using phone to bot all this while. Only this morning happen. Last
night still can on my Pokemon Go
On 28 Feb 2017 2:06 p.m., "pogarek"<EMAIL_ADDRESS>wrote:

try the account on the legit game on phone.
none of my 3 bots got banned - they are running since september.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/PokemonGoF/PokemonGo-Bot/issues/3720#issuecomment-282951142,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYl4Ph0n3yyG9A5q7ebBnIPkncsP6M9cks5rg7lIgaJpZM4Ji9FE
.


Difficulties to configure only Loader

I'm trying to configure just the loader but I'm getting some errors.
I did the tests using 2 approaches and both without success.
my configuration:
AWS_LOADER_REGION_NAME = 'us-east-1'
AWS_LOADER_S3_SECRET_ACCESS_KEY = ''
AWS_LOADER_S3_ACCESS_KEY_ID = ''
AWS_LOADER_S3_ENDPOINT_URL = 'https://s3.us-east-1.amazonaws.com'
AWS_LOADER_ROOT_PATH = ''
AWS_LOADER_BUCKET_NAME = 'mybucket'

LOADER = "thumbor_aws.loader"
Error:
ERROR [BaseHandler] get_image failed for url . error: `AWS_STORAGE_REGION_NAME`

LOADER = thumbor.loaders.http_loader
Error:
thumbor:WARNING ERROR retrieving image "IMAGE URL" : HTTP 599: [Errno -2] Name or service not known

I tried to use the same configuration that I have in 6.7 with compatibility mode but without success.
Can you tell me if I'm doing something wrong?

@P0ssuidao did you have any progress in this? I'm having similar issues

@P0ssuidao did you have any progress in this? I'm having similar issues

Not yet =/

To provide a bit more detail, a stacktrace from before I got those settings configured:
2022-09-28 09:28:43 thumbor:ERROR ERROR: Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/thumbor/handlers/__init__.py", line 212, in get_image
    result = await self._fetch(self.context.request.image_url)
  File "/usr/local/lib/python3.10/site-packages/thumbor/handlers/__init__.py", line 805, in _fetch
    loader_result = await self.context.modules.loader.load(
  File "/usr/local/lib/python3.10/site-packages/thumbor_aws/loader.py", line 88, in load
    status_code, body, last_modified = await client.get_data(
  File "/usr/local/lib/python3.10/site-packages/thumbor_aws/s3_client.py", line 150, in get_data
    async with self.get_client() as client:
  File "/usr/local/lib/python3.10/site-packages/thumbor_aws/s3_client.py", line 95, in get_client
    region_name=self.region_name,
  File "/usr/local/lib/python3.10/site-packages/thumbor_aws/s3_client.py", line 46, in region_name
    "region_name", self.config.AWS_STORAGE_REGION_NAME
  File "/usr/local/lib/python3.10/site-packages/derpconf/config.py", line 223, in __getattr__
    raise AttributeError(name)
AttributeError: AWS_STORAGE_REGION_NAME

I'm guessing thumbor_aws.s3_client expects the settings from thumbor_aws.storage to be set, even if that module isn't used.
A possible way to fix this, would be to move all the configuration options higher up in the library, to make sure they always are defined, regardless of which parts of thumbor-aws we are using.

Please don't close this issue as being stale. It's not an issue that solves itself by not doing anything.

Please don't close this issue as being stale.

I'll move the client config to each of the Thumbor modules, it should prevent this error from happening.


Cannot seem to make Pull Request

I've created a bunch of .json files for some Biomes O Plenty dirts, Project Vibrant Journeys trees, etc. I wanted to make you a pull request for them, but the button is greyed out and I can't seem to figure out what I'm doing wrong. I'd appreciate your help.

When I try to select anything other than "master" - the "create" button goes completely grey.
Also, quick note: the url in your predefined git issue text (https://vazkii.us/br101/) is a 404.

Hey, nice. I appreciate it!
To make a Pull Request you need to create a Fork first, i.e. click the fork button on the repositories main page. This will create a copy of the BonsaiTrees repository in your own account. You can modify that by adding and modifying files - it's your repository on your account, so you have full access.
I think the webinterface allows adding files - if not, there is a windows github client that should be able to do that.
Once you've made all the changes you can create a PR from your copy of the repository.

Thank you so much! I'll get that started. Quick question: if I just upload all of my files, can you pick and choose which to add? I've made some options for vanilla cactuses and various mushrooms because I wanted to have potted cactuses and mushrooms - but if you don't want them and can't discard them, I won't upload them.
Thanks again!


Stretchly Resume Notifications

Thank you for the great app.
Prerequisites

[Yes] I'm using latest version: v 0.19.0

Description
Can the Stretchly notification + sound alert be disabled for each opening of the mac lid.
Operating system: Mac OS High Sierra
Steps to Reproduce

Close the lid of Mac
Open the lid
Stretchly notification shows up

Expected behavior: Stretchly to resume, without notification or a checkbox for users to disable it
Actual behavior: Notification is shown
Reproduces how often: Its a behaviour
Additional Information
None

Hi, not possible to do right now, but I guess it could be configurable ;]
You can disable sound in notifications meanwhile, but it's for all notifications.

I would remove this notification altogether. The expected behavior is that Stretchly works whenever the system is running and the user is at the computer. This notification only adds a bit of noise to that—there's no point in telling the user that Stretchly is indeed doing its thing.
It looks more like a debugging device, so maybe it should be tied to a debugging flag, or replaced with log messages—if it's still necessary at all.

Yeah I start to agree there should be no notification...

Some problem with Stretchly 0.20.1 and Linux Mint. The App show resume message after wake-up from suspend.

This has been fixed in #448

But I still see notifications about the resumption of work, although in the application settings all notifications are turned off.

@sakralbar it's only in master, so will go out with next release


Templates do not update after changing bundles version

Create new JS function app, skip function creation.
Update host.json to use Bundles 2.x
Create new function - Durable entities templates are not available
Reload window
Create new function - Durable entities templates are there

So far it hasn't been worth listening for changes to host.json or anything else. We only update when a user re-loads VS Code. Not entirely sure it's worth listening, given how rarely a user would change major bundle versions. Another options is to add some sort of "Reload Templates" command, which could be accessed from the command palette or at the bottom of the template list (if we want it extra-discoverable)

I think with the Reload templates option, we can go ahead and close this issue.


Feature request: subproperty validation

I pull in some entities through breeze that have navigation properties, and I need to validate properties on the navigation property. So it would help me big time if this could be supported:
    ValidationRules
    .ensure('user.lastName').required()
    .on(this);

https://gist.run/?id=8ead16d0aa96a1c59b14eecbc59538fd

@JeroenVinke I found this to work (https://gist.run/?id=89fd2c2e4ddc195c19f5717920312a2f).
ValidationRules
.ensure('lastName')
.required()
.on(this.user);

Since ensure requires a property of an object, make the validation rules check this.obj (this.user in your case). Not sure if this is the correct way - but might be a workaround.

@devanp92 Thanks, I'm aware of that, but this feature request is mainly for doing things like this:
    ValidationRules
    .ensure('password.original').required()
    .ensure('lastName').required()
    .on(this.user);

where one property exists directly on the object and one property exists in a subproperty

@JeroenVinke Gotcha. That sounds like a useful feature to add! :+1:

Any idea when this might be available? I want to start using the spoonx orm but I can't until model.property works for the ValidationRules

main repo has same issue


ApiException on live server

I got the following error when using the library on a live server even though it works locally on my system. All resource method returns the same error.
`Yabacon\Paystack\Exception\ApiException
Paystack Request failed with response: '
400 Bad Request

400 Bad Request
cloudflare-nginx

`

@kingstuffy what version of the library are you using?

@ibrahimlawal v2.1

@kingstuffy this was because the originating server didn't send valid data to our API. We built in a file_get_contents fallback which is really non-standard and will only work on some servers. Future versions might remove this fallback

@ibrahimlawal faced with this problem, (action: trying to verify transaction using ref_no).
Running PHP 5.5.12, OpenSSL 1.0.2, Curl 7.36.0

I'm pushing an update that allows you disable the file_get_contents fallback. Please do that like so:
Yabacon\Paystack::disableFileGetContentsFallback()

And let me know what the error message is.

@ibrahimlawal Trying the Library v2.1.16. See error message.
"Curl failed with response: 'SSL certificate problem: unable to get local issuer certificate'."

Great, this should help: https://github.com/unicodeveloper/laravel-paystack/issues/14#issuecomment-281752633

@kingstuffy @Kendysond @gofaniyi the fix is wiki-ed here: https://github.com/yabacon/paystack-php/wiki/cURL-error-60:-SSL-certificate-problem:-unable-to-get-local-issuer-certificate-(see-http:--curl.haxx.se-libcurl-c-libcurl-errors.html)

@gofaniyi let me know if this works for you.

@ibrahimlawal This (unicodeveloper/laravel-paystack#14 (comment)) resolves the problem at hand. Thanks


ChannelInitializer prevents propagation of channelRegistered event

If I understand Netty's event handling correctly, in general it doesn't (shouldn't?) matter whether a channel handler was added to the pipeline via addFirst or addLast, the rules of event propagation are the same.  This is not the case though when the pipeline is modified within ChannelInitializer::initChannel.  ChannelInitializer is implemented as a handler, it's part of the pipeline when initChannel is invoked and it removes itself afterwards.  With the current implementation of ChannelInitializer::channelRegistered, handlers added via addFirst do not receive the channelRegistered event.
Tested with current HEAD of Netty's v4.1 branch.
% java -version
java version "1.8.0_51"
Java(TM) SE Runtime Environment (build 1.8.0_51-b16)
Java HotSpot(TM) 64-Bit Server VM (build 25.51-b03, mixed mode)
% uname -a
Linux marvin 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt20-1+deb8u3 (2016-01-17) x86_64 GNU/Linux

Fixed by https://github.com/netty/netty/pull/4995


Kubectl patch command accepts a filename param

address part of issue #10628 , kubectl patch command accepts FilenameParam.

@JanetKuo @caesarxuchao please review this PR, thanks!

Thanks @feihujiang. Looks good. Can you add a test in hack/test-cmd.sh? Ref https://github.com/GoogleCloudPlatform/kubernetes/blob/master/hack/test-cmd.sh#L381

cc @deads2k @kargakis

A nit. Otherwise LGTM. Thank you!

Fixed the nit, and rebased

I'm a little late to the party, but doesn't it seem like a user would likely associate a -f on kubectl patch to mean "a file containing my patch"?
I could see an argument for creating a patch API object that was fully describing.  That way, we could create patch files and lists containing patches that could be easily version controlled and applied.

As with other mutations, the file(s) just provide an alternative way of identifying the resources to operate on. The documentation should clarify that.
I'd be in favor of introducing another flag, such as --patch-file, to contain the patch. That would be useful for larger and/or reused patches.

@JanetKuo  Please review.

@feihujiang Looks good. Thanks for your contribution!

@k8s-bot test this [testing build queue, sorry for the noise]

Automatic merge from SubmitQueue


Bump Ruby to 2.7.1

Summary
Bart mentioned a 2.7.0 security issue. So we should update to 2.7.1.
Things to Consider
This will likely require some assistance from the Core Team as it will need to be installed on the production servers.
Criteria for Completion

[ ] The Gemfile references the correct version
[ ] The Gemfile has been updated
[ ] Production has the 2.7.1 installed

hmm if production has 2.7.1 already would it mean that we just need to change the Gemfile?


protodot building

Binary of protodot exists only for amd64. Let`s move to building
Signed-off-by: Petr Fedchenkov<EMAIL_ADDRESS>

This is a good observation (and explains breakage of our ARM builds :-(). But this PR doesn't seem to be doing any actual "build" steps, does it?
Also, another suggestion is to skip this step entirely on ARM

It builds during go get

It builds during go get

Of course! Man, I really should stop waking up early :-(


started here some dataset structure

The intent of presenting data as such is to enable modularized dataset structure and take advantage of the potential speed up provided by pytorch data serving mechanisms.
Moreover, I'd vote for presenting only graphs in dataset, which, despite possible increased memory requirement, would make training much more modularized. The example will be attached in a later commit.


Spring cleaning documentation

Hey Everyone 👋
I have slightly spring cleaned the docs a little.
Changes:

Made some the root documentation folder only contain docs
Added a table of contents for the docs
De-duped some content between contributing and onboard.
I have added the NL Net milestone agreement (pending NL Net sign off)

This PR has a lot of green but none of the content was actually added, its just been moved.
Once this gets merged i'll delete the content from the wiki, its all in MD files now so the wiki will go stale.
Think the consensus for docs going forward is dev stuff goes into the docs folder on this repo and user facing stuff goes on the website.

Looks good to me. We have never really committed to using the wiki. Personally having all the docs in one place makes sense - wherever that be and I know @sjjhsjjh  has said it always makes more sense to put it directly in the repo. One thing - is that OnBoarding doc right in here though?  Is it really a dev thing?

@willwade Thats a good shout, ill shift it to the website 👍

Besides the deploy stages that failed... looks like there is an issue with submodules and captive-web-view? Not sure what changed though to trigger this.
All other updates to docs look good. 👍

I prefer Markdown lists to be indented by four, whether the list is ordered or unordered. For example:
-   This is an unordered list item.
    Pretend it wrapped to a second line like this.

1.  This is an ordered list item.

Could this be adopted as part of the coding style please?

Besides the deploy stages that failed... looks like there is an issue with submodules and captive-web-view? Not sure what changed though to trigger this.

Hi Jeremy, Where is this issue visible please?

The captive-web-view sub-module has somehow been added back in this branch. I think GitHub has some sort of bug in the area of merging and deleting files. I'll see if I can remove it from this branch.

Besides the deploy stages that failed... looks like there is an issue with submodules and captive-web-view? Not sure what changed though to trigger this.

Hi Jeremy, Where is this issue visible please?

Looks like it’s sorted itself out. It’s only visible on the GitHub PR page Jim - at the bottom. Just travis and netlify builds.

@sjjhsjjh

I prefer Markdown lists to be indented by four, whether the list is ordered or unordered.

Do you mind if I leave the markdown as it is just now then we can have a separate PR to enforce all the rules we end up choosing for the style guide as well as some tooling so we don't have to manually apply the rules?
@willwade After looking the About page on the website has most of the content there so I don't think there is much use copying it over to the website as it would just be duplicated content. I think there is some value to have the context in the repo like it currently is.

@willwade After looking the About page on the website has most of the content there so I don't think there is much use copying it over to the website as it would just be duplicated content. I think there is some value to have the context in the repo like it currently is.

Fine with me :)


[improvement](jdbc catalog) Change JdbcExecutor's error reporting from UDF to JDBC

Proposed changes
In the initial version, JdbcExecutor directly used UdfRuntimeException, which could lead to misunderstanding of the exception. Therefore, I created a separate Exception for JdbcExecutor to help us view the exception more clearly.

run buildall

run buildall

run buildall

run buildall


Fix scrapping of locations data

Hello,
List of all locations don't work anymore so I fix it.

Thanks!

Thanks!

You're welcome. It's a pleasure.
Please @FabianBeiner can you create a new release si I can access to "locations" through composer.
Regards,
Joël

this commit will not fix the issue to grab all locations, because IMDB is using graphQL.

That's fine. We use whatever IMDb posts on the “original” page. :)


Programmatic running of reports

Description of the bug or enhancement
Current reporting manual does not mention that you can run reports from your code.
Use cases:

Run report with parameters input (using ReportGuiManager) and download result document.

Run report without parameters input and download result document.
Here we can call ReportService directly.

Run report and save result document (FileDescriptor) to the database linking to a business entity.
Like generating an invoice or wages statement.

see this post:
https://www.cuba-platform.ru/discuss/t/generacziya-neskolkih-otchetov-v-odin-dokument/3695/6?u=budarov
he doesn't know how to launch reports from his code without GUI window

one more topic on russian forum where person needs to run report programmatically, but doesn't know how to do that:
https://www.cuba-platform.ru/discuss/t/vyvod-html-otcheta-na-ekran/3735
(run html report and display result document in component, like text area or browser frame)

https://www.cuba-platform.ru/discuss/t/generacziya-otchetov-v-middleware/4434


computed_major_engine_version not working for postgres 9.6.18

Describe the Bug
computed major_engine_version fails when...
var.engine == "postgres"
var.engine_version == "9.6.18"

The computed value should be 9.6 but actually results in 9 and the following error:
Error: Error creating DB Option Group: InvalidParameterCombination: Cannot find major version 9 for postgres

Expected Behavior
When var.engine_version == "9.6.18", the computed_major_engine_version should be 9.6.
Steps to Reproduce
Steps to reproduce the behavior:

Copy examples/complete to a new terraform configuration.
Change the following variables in fixtures.us-east-2.tfvars:

engine = "postgresql"
engine_version = "9.6.18"
major_engine_version = "9.6" # or set to empty string
db_parameter_group = "postgres9.6"

Run the plan terraform plan -var-file="fixtures.us-east-2.tfvars".  Observe that...

resource "aws_db_option_group" "default" {
     ...
     engine_name              = "postgres"
     major_engine_version     = "9"
     ...
}

Apply the configuration with terraform apply -var-file="fixtures.us-east-2.tfvars
See error

Environment (please complete the following information):
Anything that will help us triage the bug will help. Here are some ideas:

OS: OSX
cloudeposse/terraform-aws-rds v0.26.0
terraform v0.12.29

The expectation that the major_engine_version follow a pattern of x.x ~> 9.6 conflicts with the assumptions that were implemented in https://github.com/cloudposse/terraform-aws-rds/pull/42.
Open questions:

What is the pattern for major version on DB option groups?
Is that pattern consistent for different versions of postgres?

Maybe the major_engine_version is not feasible to calculate consistently?
If that's the case, I might suggest making major_engine_version required and removing the ability to calculate it (as is the case with aws_db_option_group).
For now, I'll be specifying the var.major_engine_version like in this example: https://github.com/JCFerrerG/terraform-aws-rds/commit/bfd31510dbfe86211a616505fbac6980bfee223a

If it's of use, we're using a different way to calculate this internally:
# leave the regex open ended, Aurora, Oracle and SQLServer can all contain characters
version_parts = regex("^(?P<major>[0-9]+)(?:\\.(?P<minor>[0-9]+))?", var.engine_version)
version_parts_number = {
  major = tonumber(local.version_parts["major"])
}
is_postgres                  = var.engine == "postgres"
uses_shorthand_major_version = local.is_postgres && local.version_parts_number["major"] >= 10

computed_major_engine_version = local.uses_shorthand_major_version ? local.version_parts["major"] : "${local.version_parts["major"]}.${local.version_parts["minor"]}"
major_engine_version          = var.major_engine_version == "" ? local.computed_major_engine_version : var.major_engine_version

It's working for postgres 9.6, 11, and 12.
Feel free to use it here.
We're also using this to set aws_db_instance.engine_version, so we don't get state changes whenever an auto-minor update happens.
while the comment talks about other databases, this has only been tested with Postgres. Looking at the docs for sqlserver and oracle, it should still work as expected.


module support

I would like to implement this package, but seems like it is looking for D3 as a global.  This makes it a bit awkward to use in projects using some kind of module loader.  From what I understand, D3 detects the presence of an AMD loader and if found, refrains from creating a global (https://github.com/d3/d3/issues/1693).
Would you be interested in a PR to make this work with AMD style projects?

If you're interested in putting that together - that would be awesome =)

Cool, might take me a week or two, but I'll take a crack.  I personally don't understand the landscape of js package loaders, so have to do some learning.

Any movement on this? I'm running into a similar issue.

Hi @aethant, I applied the same temporary fix in my code.  I will eventually get to this, but I can't say just when...

So - I've enabled d3 4.0 support in this commit: https://github.com/benfred/venn.js/commit/a308b391aece84cda82f8ae58521251f3021f97c . I'm hoping that this will also work with amd modules now since I'm importing d3 rather than assuming a global is defined.  Let me know =)

Sorry, I was on another project. Just wanted to update: the support for d3 4.0 worked. Able to use the module without the previous workarounds. Thank you!

good to hear! glad its working


CI tests broken on OS X

Description
Tests broken on OS X:
2020-04-20T19:24:22.8349430Z [14.088s] The following tests FAILED:
2020-04-20T19:24:22.8349850Z [14.088s] 	  1 - test_collector (Failed)
2020-04-20T19:24:22.8350270Z [14.088s] 	  2 - test_moving_average_statistics (Failed)
2020-04-20T19:24:22.8350680Z [14.088s] 	  3 - test_received_message_period (Failed)
2020-04-20T19:24:22.8351080Z [14.088s] 	  4 - test_received_message_age (Failed)
2020-04-20T19:24:22.8351180Z [14.133s] Errors while running CTest

https://pipelines.actions.githubusercontent.com/770SLwBj3ET8NDQCRWFqpZmRWXkXzxULg9phWHBbZVu2jXGrW5/_apis/pipelines/1/runs/126/signedlogcontent/6?urlExpires=2020-04-20T19%3A53%3A59.6774078Z&urlSigningMethod=HMACV1&urlSignature=kOrEbPjDAN8O2b10B43olmT0lAJgPn4IaRNqs1GPPsI%3D
To Reproduce
CI Run https://github.com/ros-tooling/libstatistics_collector/actions
System (please complete the following information)

OS: OS X
ROS 2 Distro: master

Additional context
N/A

I went down the path of trying to lookup the error
dyld: Library not loaded: @rpath/libspdlog.1.dylib

and found a few threads. This was interesting and I'm not familiar with the image, but wondering if SIP is enabled? Either way I found a few missing brew dependencies so will open a ticket and PR against setup-ros.

Using the draft PR #9 I was able to verify that SIP is enabled on OSX
Mac-1557:libstatistics_collector runner$ csrutil status
System Integrity Protection status: enabled.

Will file a ticket against setup-ros.

This appears to be fixed by https://github.com/ros-tooling/libstatistics_collector/pull/10 and is unrelated to ros-tooling/setup-ros#128.

Closing given green CI and the fix #10 via @thomas-moulard.


[Feature] Screenshots of failed UI tests

curious if you guys have thought about doing something with the screenshots from the test logs.   There is this one tool that I use currently that does this.  https://github.com/nacuteodor/ProcessTestSummaries
But retry logic and parallel execution with bluepill is winning and I plan to move all my CI to bluepill, but was trying to figure out how to get the screenshots feature back.
thanks for all the work!

Not sure how that ProcessTestSummaries does that, the logic to take screenshots on failures or on demand and the logic to handle them are in our testing framework library. I'd prefer not to include screenshots logic in bluepill.

they just take the screenshots from the TestSummaries rename them and move them to a specified folder.  I haven't looked at how you guys are creating the junit.xml file but figured it was similar.  No problem if not wanting to add...I can figure out something else.

@jimmyeisenhauer did you manage to get screenshots from bluepill? I'm trying to get that working but with no success for now :)

I have not looked to see what bluepill does to the testsummaries plist.  My guess it is destroyed a lot with all the parallel and retrying going on.  And probably not usable for parsing.
I would be curious how they do screenshots of failed tests and coordinate that with what bluepill is reporting as failed.  It isn't difficult to create a screenshot on a failed assertion but not sure I understand bluepill enough to figure out how to only save the last failure of a test's screenshot.

From what I found, it is not difficult to get screenshot if you are using KIF (http://stackoverflow.com/questions/16341198/take-screenshot-with-kif), but XCUITEST generates screenshots for each step for you, but bluepill is not :(


Add rajeshvenkata to OWNERS

Description of changes:

Add rajeshvenkata to OWNERS

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve

/cherrypick release-0.20

/cherrypick release-0.19


Feature Request: Fisheye/Sphere Support

Description

A lot of IP cameras provide 360° video in a so called fisheye style. Currently, to my knowledge, the only option to dewarp fisheye videos in Javascript is the very outdated https://github.com/yanwsh/videojs-panorama VideoJS plugin. I would like to use egjs-vew360, so it would be great if this library would also implement the option to use fisheye optics.

Hello @doktormerlin, thanks for the suggestion!
We're planning to support additional projection types in the future. We'll definitely consider adding fisheye projection type then.

For example, you can use ffmpeg to do that.
ffmpeg -i input.mkv -vf v360=fisheye:equirect output.mkv

I haven't tested the result, so I can't guarantee whether it works great or not, but it's worth a try for now.


Enable live plots for experiments running outside of the workspace

Things to note:

Experiments running in the queue are not selected by default.
Experiments running in the workspace are selected by default.
Experiments running in DVCLive-only context are not selected once the workspace run finishes (selection remains on workspace).

Demos
2 queue workers + workspace experiment
https://github.com/iterative/vscode-dvc/assets/37993418/2e507ff4-b5f3-4333-b7b1-634eedfaf79a
DVCLive only
https://github.com/iterative/vscode-dvc/assets/37993418/030f9d91-8010-41cb-b4f8-50dec377d29b

UI tests changes are related to the workspace record not being selected when an experiment is found to be running in the workspace for the first time (the experiment is selected now instead).


cmd/vet: validate that time.Format strings are sane

vet will let the user know if fmt.Printf strings are incorrect and if the types passed to them are incorrect. It'd be very handy if the also rather specific format for time.Format strings were similarly checked for validity.

@cellofellow could you provide some examples of wrong inputs and errors you'll expect?

fmt.Printf would still print something, albeit not what was intended. But time.Format would simply throw an error. So it's not like a mistake in the time.Format would go unnoticed so easily.
@alandonovan @mvdan

FYI: a timeformat checker now exists.


feat: get by username for search

localhost:5000/user/getByUserName/:username      added

Maybe change to find one if you only want one user


UrlParams breaks PerPage

When $scope.urlParams is set through controller then the $scope.perPage ends undefined, or if perPage was not set at initialization.
Try line 279 in your code (watching for reloadPage) then "from" and "to" in range get value od Nan ( = 0 * undefined)

Thanks for the bug report. Can you explain how it breaks? Is it possible to add a failing test case for me to see?

I tryed to reproduce that situation on your demo on my local machine but couldn't get it. The setup was exactly the same like in my code, but the range was in correct state. I used latest version.


error Windows_NT 6.3.9600 using npm link after cloning repository

Hi,
I have just cloned the repository and then run the following:
npm link

but then I encounter this error:
19798 error Windows_NT 6.3.9600
19799 error argv "C:\\Program Files\\nodejs\\\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "link"
19800 error node v0.12.4
19801 error npm  v2.10.1
19802 error code ELIFECYCLE
19803 error<EMAIL_ADDRESS>postinstall: `tessel install-drivers || true; tessel trademark || true`
19803 error Exit status 1
19804 error Failed at the<EMAIL_ADDRESS>postinstall script 'tessel install-drivers || true; tessel trademark || true'.
19804 error This is most likely a problem with the tessel package,
19804 error not with npm itself.
19804 error Tell the author that this fails on your system:
19804 error     tessel install-drivers || true; tessel trademark || true
19804 error You can get their info via:
19804 error     npm owner ls tessel

Is there something I am doing incorrectly? Is it maybe an issue with the version of node I am running?

Hi @dalestone! According to @othiym23, you'll need Administrator privileges (reference: https://github.com/npm/npm/issues/3861#issuecomment-67905700 ). Please confirm. Thanks!

@rwaldron  I can confirm setting permissions to "Full control"  on the node_modules folder worked. Thanks very much!

If you'd like to contribute, you could add info to the readme that describes what you did :)

@rwaldron Yeah ok, I will write something up and do a pull request.

@dalestone awesome—thanks!


Raise min PHP version to 7.3

As of now, PHP 7.3 is minimum supported version.

Looks good, we should remember to version this correctly.


Connect close when transferring big file

I use quiche to transfer a large file, but after transferring a certain size, such as 2G, the quiche connection becomes close. Tested many times, it is an inevitable scene. Why?

We'd need more information in order to provide any insight into this problem. For instance, what is the client, what is the server, does this happen over the internet or a local test setup, do you have any logs from client or server side, etc.

Closing due to inactivity. Please reopen if there is more information.


cleanAlais.alias is undefined bug

Open the DD  app for Communications
Search connection point and open the card
Click the link next to AssetID

Result: cleanAlais.alias is undefined

Cant repo in updated version


update sigstore/scaffold version & chart version

/cc @cooktheryan @Gregory-Pereira @JasonPowr
This PR:

updates sigstore/scaffold chart
adds results of pre-commit run --all-files (the test for this should be run automatically from this branch! it's only running from main.

Resolves https://issues.redhat.com/browse/SECURESIGN-372

@Sallyom this seems to fail the test with the following error:
Error: INSTALLATION FAILED: client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline. I found this thread (https://github.com/helm/helm/issues/12154#issuecomment-1606676907) which gave a little background on it. Basically it is just failing due to timeout so the cause is still unclear. If some of the pods could be crashlooping or crashbackoffing and its possible that helm is just not propegating that error back to us, it seems like it is a newish error message. I would try it somewhere you can go into the cluster and validate the deployment. If this doesnt work, I would try specifiying the timeout as a fixed number rather using the --wait flag.

I am hitting permissions errors here:
{"level":"panic","ts":1706892138.5745668,"logger":"fallback","caller":"createctconfig/main.go:105","msg":"Failed to get the configmap fulcio-system/ctlog-config: configmaps \"ctlog-config\" is forbidden: User \"system:serviceaccount:fulcio-system:fulcio-createcerts\" cannot get resource \"configmaps\" in API group \"\" in the namespace \"fulcio-system\"","stacktrace":"main.main\n\tgithub.com/sigstore/scaffolding/cmd/ctlog/createctconfig/main.go:105\nruntime.main\n\truntime/proc.go:267"}
panic: Failed to get the configmap fulcio-system/ctlog-config: configmaps "ctlog-config" is forbidden: User "system:serviceaccount:fulcio-system:fulcio-createcerts" cannot get resource "configmaps" in API group "" in the namespace "fulcio-system"


archlinux/gcc weirdness

I'm pretty sure I was able to install this some weeks ago but now I get this:
higgsArchOne~/node-sodium(master|✔) % git rev-parse HEAD
ef8000103d5e0645988ad52ac62e8f7373062602
higgsArchOne~/node-sodium(master|✔) % npm install

><EMAIL_ADDRESS>preinstall /home/cryptix/node-sodium
> make

autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I m4
autoreconf: configure.ac: tracing
autoreconf: running: libtoolize --copy --force
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
autoreconf: running: /usr/bin/autoconf --force
autoreconf: configure.ac: not using Autoheader
autoreconf: running: automake --add-missing --copy --force-missing
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/\${ <-- HERE ([^ \t=:+{}]+)}/ at /sbin/automake line 3936.
configure.ac:142: installing 'build-aux/compile'
configure.ac:10: installing 'build-aux/missing'
src/libsodium/Makefile.am: installing 'build-aux/depcomp'
autoreconf: Leaving directory `.'
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /sbin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether UID '1000' is supported by ustar format... yes
checking whether GID '1000' is supported by ustar format... yes
checking how to create a ustar tar archive... gnutar
checking whether make supports nested variables... (cached) yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... clang
checking whether the C compiler works... no
configure: error: in `/home/cryptix/node-sodium/deps/libsodium':
configure: error: C compiler cannot create executables
See `config.log' for more details
Makefile:8: recipe for target 'configure' failed
make: *** [configure] Error 77

npm ERR! Linux 4.2.5-1-ARCH
npm ERR! argv "/usr/bin/node" "/sbin/npm" "install"
npm ERR! node v5.0.0
npm ERR! npm  v3.4.0
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>preinstall: `make`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>preinstall script 'make'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the sodium package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     make
npm ERR! You can get their info via:
npm ERR!     npm owner ls sodium
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/cryptix/node-sodium/npm-debug.log

I'm not sure why configure selects clang (which isn't installed) and not gcc (which is installed, version 5.2.0). Here is the config.log file.

This is an error from LibSodium. Can you check if you can compile the library by it self first?
You can go to the libsodium directory under deps/libsodium and try to run configure and make from there.

This was a fault on my part from merging system configuration... Sorry.


Ignore errors when loading an invalid blob store

Fixes #10047.
Fixes #10015.
Although I am not able to reproduce the problem reported in the above issues, with this PR we're introducing a more flexible way of loading the blob store, which now doesn't crash Atom if any of the files is corrupted.
This seems like a reasonable default to have and, in the meantime, we can keep an eye on what triggers this particular edge case. I don't think it's a race condition caused by Atom, as we're already using a lock file to prevent such scenarios, but I could be overlooking something here.
/cc: @maxbrunsfeld @nathansobo @atom/feedback

Should you open this PR against stable so we can hotfix?

Good call! Doing that now...


Actually set the desired option

This change is

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

quizbot.rb, line 338 [r1] (raw file):
I'm open for suggestions if there's a more beautiful way to accomplish this!

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from the review on Reviewable.io


feat: support optional properties

This PR is a second take at https://github.com/spatie/laravel-data/pull/119, that does not replace the default behavior but supports the newly configurable one.
It depends on https://github.com/spatie/typescript-transformer/pull/30 and https://github.com/spatie/laravel-typescript-transformer/pull/15. Both of these should be merged before this PR (tests will not pass anyway).
What's important:

The #[Optional] attribute from typescript-transformer is taken into account
The new transform_null_to_optional option from laravel-typescript-transformer is taken into account
The current behavior does not change unless one of the above is true

Example:
use Spatie\TypeScriptTransformer\Attributes\Optional;

class UserData
{
    public function __construct(
        #[Optional]
        public int $id,
        public string $first_name,
    ) {
    }
}

interface UserData {
  id?: number
  first_name: string
}

The Optional attribute above would not be necessary if config/typescript-transformer.php's transform_null_to_optional is set to true (which is false by default to preserve current behavior).
cc @rubenvanassche

After reading the new code (that's a big refactor!), partially. The most important feature of that PR won't work:

The new transform_null_to_optional option from laravel-typescript-transformer is taken into account

Though I'm not sure how to get the config in DataType yet.
I also wanted to support #[Optional] for consistency with spatie/laravel-typescript-transformer.

Additional note, how do you feel about renaming Undefinable to Optional? That's more in line with what it is and what it does, in my opinion. It's also the term used in TypeScript.

@rubenvanassche should I open again targeting main?

Yes! Create plan! typescript-transformer and a brand new typescript-transformer v3 is the next big thing I want to work on!


Initial support for ppc64le

Initial support for PowerPC architecture following the design pattern introduced by the aarch64 PR

Thanks @mgiessing! I am not sure that we'll be able to commit to distributing binary wheels for ppc64le, but certainly welcome source compatibility!
I'll do some quick regression testing on this over the next couple days, but at first glance it looks good!
PowerPC support was deprecated in CUDA 12.4 and removed in 12.5. However my understanding is that there's still many AC922 systems with V100 GPUs out there, and maybe even some Power8 S822LC with P100s, so to add context and further advocate:
Example operational supercomputers:

Summit / OLCF-4
Sierra / ATS-2
MareNostrum 4 / MN4 CTE-Power

Just a reference note: relates to #652

Thanks a lot @matthewdouglas!
Yeah - I do not expect to have binary wheels but as you said there are many people/organisations having P100/V100/T4 on Power Systems so source compatibility is desired :-)
Btw. I figured out I had to rename the libbitsandbytes_cuda122.so to libbitsandbytes_cuda122_nocublaslt.so otherwise it would crash during the test...not sure I've done something wrong during the build which was the following:
## System: AC922 // CUDA 12.2 // RHEL8.9

# Create bnb environment and install dependencies via mamba/conda and rocketce channel
micromamba create -n bnb \
    -c rocketce \
    -c defaults \
    python=3.10 \
    pytorch==2.1.2 \
    pandas \
    scipy \
    matplotlib && micromamba clean --all --yes

micromamba activate bnb

#Install remaining depenedencies via pypi
pip3 install lion-pytorch wheel einops pytest setuptools>=63 transformers accelerate

git clone https://github.com/mgiessing/bitsandbytes

export PATH=$PATH:/usr/local/cuda/bin

cmake -DCMAKE_CUDA_ARCHITECTURES=70 -DCOMPUTE_BACKEND=cuda -S .

make -j$(nproc)
pip install -e .

cp bitsandbytes/libbitsandbytes*.so bitsandbytes/libbitsandbytes_cuda122_nocublaslt.so

#Simple test to check if it works
python3 -m bitsandbytes

If you add -DNOCUBLAS_LT=ON to the cmake step it will build libbitsandbytes_cuda122_nocublaslt.so.


PEP: pandas/core round 7 (window, reshape, series, format)

And residual categorical.
What should we do with api/sparse/matrix as those are all unused imports--noqa for each line?

You can put flake8: noqa at the top of those files

lgtm. merging, thanks!


Create Contribution Guide

Need to create a CONTRIBUTING.md a file explaining how to add events.
Events are stored in their own folder in src/_events and then are referenced in src/_events/eventsManifest.json.
There is a custom testing kit in CircleCI that validates eventsManifest.json

Solved in #5
Closing