Is it possible to run both Pterodactyl & North client on the same machine?

So, i want to have one node for the panel, and 2 additional nodes for server hosting. is it possible?
(probably yes but I never tried hosting clients on top of the regular pterodactyl)

Figured out it's possible


[LookupVisibleDecls] Include protocol members when finding 'subscript(dynamicMember:)'

  struct Point { var x, y: Int }
  protocol P {}
  extension P {
    subscript<T>(dynamicMember key: KeyPath<Point, T>) -> T
  }
  @dynamicMemberLookup struct S: P {}

  S().<HERE>

Previously, completion couldn't suggest x and y because it couldn't find subscript(dynamicMember:) on S type. Include NL_ProtocolMembers when finding the subscript.
rdar://problem/71008072

@swift-ci Please smoke test


Links in Atom's markdown preview aren't highlighted

It would be nice to have some differentiation of what's a link when using Atom's markdown preview.

Setting global styles to what's below does the trick. It'd be nice if you incorporated it into the theme.
.markdown-preview a {
  text-decoration: underline;
}


Const arrays are not read-only, despite the description in the docs

Godot version
v4.0.beta9.official [e780dc332]
System information
Kubuntu 22.10
Issue description
The docs says:

bool is_read_only() const
Returns true if the array is read-only. See set_read_only(). Arrays are automatically read-only if declared with const keyword.

But
@tool
extends EditorScript

const A = [1, 2, 3]

func _run() -> void:
    const B = [4, 5, 6]
    print(A.is_read_only()) # false
    print(B.is_read_only()) # false

I'm not sure if this is a bug in the documentation or in the implementation.
Steps to reproduce
See above.
Minimal reproduction project
N/A

Related to https://github.com/godotengine/godot/issues/30212.


Argilla chapter

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Approving this, as it has been in PR state for so long, we can always merge and iterate in follow-up iterations IMO. 🤗

Of course! We can iterate later, thanks! Any chance I could get it merged @Vaibhavs10 ? I cannot do it myself

Hey @Vaibhavs10 ! Any chance we can get this merged soon? I'm not planning to communicate on this until the new year anyway, so no hurry, but just to have it ready for when I come back from my holiday break. Thanks!


hours (visits per day hour, 00-01.. 23-00)

Another counter and will group hits by hour of day they occur.
Very useful on analytics to study the best hours to apply some strategy.
00: X hits
01: Y hits
..
23: Z hits
What do you think?

The time distribution panel has been implemented. e.g., 00-23
It will be pushed out in the upcoming version, which will be out pretty soon :)

Thanks!


The server folder is empty

Is that normal ?

Server repo :- https://github.com/mnnkhndlwl/youtube-backend

Thanks

Yeah it's possible to store them locally using multer but I had to deploy it on renderer.com and you will not get storage options on free plan so I used firebase here


Fix ix an error message that floods the editor logs:

Fix ix an error message that floods the editor logs:
ERROR: Index p_gutter = -1 is out of bounds (gutters.size() = 4).
   at: set_line_gutter_item_color (scene/gui/text_edit.cpp:5900)

This doesn't look like the correct fix to me, _update_gutter_indexes should be called when the editor is activated, and only at that point should the themes / validation start being ran.

If you got a better fix, I won't be mad if you want to close this PR, and fix it by yourself.
Cheers

I'd suggest you take the feedback to heart and try it out, that's core to contributing, flexibility and being able to incorporate feedback

I'd suggest you take the feedback to heart and try it out, that's core to contributing, flexibility and being able to incorporate feedback
I'm glad to have received feedback on the fix I proposed. However, I don't have time to delve further into the code.

I'm using this fix locally, it works, and I don't need to look any further. Nevertheless, I understand that Godot needs a better fix than the one I proposed.
So, from my side, I have a commit that changes 2 integers from -1 to 0, with no side effects, where I don't want to start modifying conditions for the editor theme updates, taking the risk of breaking more things than I understand.
If you feel like it, @AThousandShips, you can also make the fix, as you mentioned, it's an open-source software, and it doesn't have to come from me. And as I believe, my fix works well enough given the time invested.

How do you know that it doesn't have side effects? I don't think they were manually set to -1 on construction previously just for no reason, but to indicate the invalid start state, and that there's missing handling elsewhere, as pointed out
I haven't mentioned anything about this being open-source, and it working well enough compared to the time invested isn't a metric for how appropriate a fix is
I just find this attitude of "if you have a better fix you can do it yourself, I won't change anything" unhelpful and not appropriate for a community driven project, especially when getting feedback from a team member who has this area

Honestly, I thought that @Paulb23 had looked at the code to find a fix but didn't want to take credit for it. That's why I responded by saying that he was free to make a higher-quality fix if he wanted to.

I understand but that was not communicated in your messages, I'm sorry that I didn't pick up on that implied message of yours

I understand but that was not communicated in your messages, I'm sorry that I didn't pick up on that implied message of yours
Have a nice day
I'm relieved; I really thought you were lecturing me with full knowledge of the situation. Anyway, I don't have time to deal with this, and since this fix doesn't suit you, it's best to leave it closed. Have a good day to you too.


support OKX wallet adapter

@jordaaash For issue #993

Added packages/wallets/okx/src/adapter.ts in one of my projects. Everything is ok.

Thanks, but we are not accepting new adapters for wallets that can support the Wallet Standard. Since OKX Wallet already does, this is unnecessary.


Add ability to express dependencies between enrichments

e.g. weather dependent on geo_to_ip.

Closing in favor of #2260


startTransition doesn't defer rendering of Suspense fallback

Description
In React(DOM), startTransition yield rendering till required data prepared to next paint if its trigger is inside Suspense boundary.
In latest ReactNative, I see startTransition doesn't yield rendering and immediately render nearest parent Suspense fallback even if required data isn't ready.
I didn't check previous releases.
Steps to reproduce
cd ios
bundle install && RCT_NEW_ARCH_ENABLED=1 bundle exec pod install
cd ..
yarn ios

yarn android

On both two platforms:

By clicking urgent button, it renders suspense fallback. It's expected.
By clicking transition button, it renders suspense fallback. It's not expected.

React Native Version
0.73.1
Affected Platforms
Runtime - Android, Runtime - iOS
Areas
Fabric - The New Renderer
Output of npx react-native info
System:
  OS: macOS 14.2.1
  CPU: (10) arm64 Apple M1 Pro
  Memory: 408.05 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.15.0
    path: ~/.nvm/versions/node/v18.15.0/bin/node
  Yarn:
    version: 1.22.19
    path: ~/.nvm/versions/node/v18.15.0/bin/yarn
  npm:
    version: 9.6.3
    path: ~/.nvm/versions/node/v18.15.0/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.14.3
    path: /Users/bahwanhan/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - watchOS 10.2
  Android SDK: Not Found
IDEs:
  Android Studio: 2022.3 AI-223.8836.35.2231.11005911
  Xcode:
    version: 15.1/15C65
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.3
    path: /Users/bahwanhan/.sdkman/candidates/java/current/bin/javac
  Ruby:
    version: 2.6.10
    path: /Users/bahwanhan/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.1
    wanted: 0.73.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: true
  newArchEnabled: true

### Stacktrace or Logs

```text
Last login: Sat Dec 30 13:17:06 on ttys006
/Users/bahwanhan/dev/rn-transition-not-work/ReproducerApp/node_modules/.bin/launchPackager.command ; exit;
➜  ~ /Users/bahwanhan/dev/rn-transition-not-work/ReproducerApp/node_modules/.bin/launchPackager.command ; exit;
info Welcome to React Native v0.73
info Starting dev server on port 8081...

                        ▒▒▓▓▓▓▒▒
                     ▒▓▓▓▒▒░░▒▒▓▓▓▒
                  ▒▓▓▓▓░░░▒▒▒▒░░░▓▓▓▓▒
                 ▓▓▒▒▒▓▓▓▓▓▓▓▓▓▓▓▓▒▒▒▓▓
                 ▓▓░░░░░▒▓▓▓▓▓▓▒░░░░░▓▓
                 ▓▓░░▓▓▒░░░▒▒░░░▒▓▒░░▓▓
                 ▓▓░░▓▓▓▓▓▒▒▒▒▓▓▓▓▒░░▓▓
                 ▓▓░░▓▓▓▓▓▓▓▓▓▓▓▓▓▒░░▓▓
                 ▓▓▒░░▒▒▓▓▓▓▓▓▓▓▒░░░▒▓▓
                  ▒▓▓▓▒░░░▒▓▓▒░░░▒▓▓▓▒
                     ▒▓▓▓▒░░░░▒▓▓▓▒
                        ▒▒▓▓▓▓▒▒

                Welcome to Metro v0.80.2
              Fast - Scalable - Integrated

warning: Watchman `watch-project` returned a warning: Recrawled this watch 1 times, most recently because:
MustScanSubDirs UserDroppedTo resolve, please review the information on
https://facebook.github.io/watchman/docs/troubleshooting.html#recrawl
To clear this warning, run:
`watchman watch-del '/Users/bahwanhan/dev/rn-transition-not-work/ReproducerApp' ; watchman watch-project '/Users/bahwanhan/dev/rn-transition-not-work/ReproducerApp'`

warning: Watchman `query` returned a warning: Recrawled this watch 1 times, most recently because:
MustScanSubDirs UserDroppedTo resolve, please review the information on
https://facebook.github.io/watchman/docs/troubleshooting.html#recrawl
To clear this warning, run:
`watchman watch-del '/Users/bahwanhan/dev/rn-transition-not-work/ReproducerApp' ; watchman watch-project '/Users/bahwanhan/dev/rn-transition-not-work/ReproducerApp'`

Recrawled this watch 1 times, most recently because:
MustScanSubDirs UserDroppedTo resolve, please review the information on
https://facebook.github.io/watchman/docs/troubleshooting.html#recrawl
To clear this warning, run:
`watchman watch-del '/Users/bahwanhan/dev/rn-transition-not-work/ReproducerApp' ; watchman watch-project '/Users/bahwanhan/dev/rn-transition-not-work/ReproducerApp'`

info Dev server ready

i - run on iOS
a - run on Android
d - open Dev Menu
r - reload app

info Opening app on iOS...
info A dev server is already running for this project on port 8081.
info Found Xcode workspace "ReproducerApp.xcworkspace"
info Found booted iPhone SE (3rd generation)
info Building (using "xcodebuild -workspace ReproducerApp.xcworkspace -configuration Debug -scheme ReproducerApp -destination id=3277291D-01B9-448E-BE2D-659D2ADE7B0B")

info 💡 Tip: Make sure that you have set up your development environment correctly, by running npx react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor

Command line invocation:
    /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -workspace ReproducerApp.xcworkspace -configuration Debug -scheme ReproducerApp -destination id=3277291D-01B9-448E-BE2D-659D2ADE7B0B

User defaults from command line:
    IDEPackageSupportUseBuiltinSCM = YES

Prepare packages

ComputeTargetDependencyGraph
note: Building targets in dependency order
note: Target dependency graph (67 targets)
    Target 'ReproducerApp' in project 'ReproducerApp'
        ➜ Implicit dependency on target 'Pods-ReproducerApp' in project 'Pods' via file 'libPods-ReproducerApp.a' in build phase 'Link Binary'
        ➜ Implicit dependency on target 'CocoaAsyncSocket' in project 'Pods' via options '-lCocoaAsyncSocket' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'DoubleConversion' in project 'Pods' via options '-lDoubleConversion' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'Flipper' in project 'Pods' via options '-lFlipper' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'Flipper-Boost-iOSX' in project 'Pods' via options '-lFlipper-Boost-iOSX' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'Flipper-Fmt' in project 'Pods' via options '-lFlipper-Fmt' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'Flipper-Folly' in project 'Pods' via options '-lFlipper-Folly' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'Flipper-PeerTalk' in project 'Pods' via options '-lFlipper-PeerTalk' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'FlipperKit' in project 'Pods' via options '-lFlipperKit' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'RCT-Folly' in project 'Pods' via options '-lRCT-Folly' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'RCTTypeSafety' in project 'Pods' via options '-lRCTTypeSafety' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-Codegen' in project 'Pods' via options '-lReact-Codegen' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-Core' in project 'Pods' via options '-lReact-Core' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-CoreModules' in project 'Pods' via options '-lReact-CoreModules' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-Fabric' in project 'Pods' via options '-lReact-Fabric' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-FabricImage' in project 'Pods' via options '-lReact-FabricImage' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-ImageManager' in project 'Pods' via options '-lReact-ImageManager' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-Mapbuffer' in project 'Pods' via options '-lReact-Mapbuffer' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-NativeModulesApple' in project 'Pods' via options '-lReact-NativeModulesApple' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-RCTAnimation' in project 'Pods' via options '-lReact-RCTAnimation' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-RCTAppDelegate' in project 'Pods' via options '-lReact-RCTAppDelegate' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-RCTBlob' in project 'Pods' via options '-lReact-RCTBlob' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-RCTFabric' in project 'Pods' via options '-lReact-RCTFabric' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-RCTImage' in project 'Pods' via options '-lReact-RCTImage' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-RCTLinking' in project 'Pods' via options '-lReact-RCTLinking' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-RCTNetwork' in project 'Pods' via options '-lReact-RCTNetwork' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-RCTSettings' in project 'Pods' via options '-lReact-RCTSettings' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-RCTText' in project 'Pods' via options '-lReact-RCTText' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-RCTVibration' in project 'Pods' via options '-lReact-RCTVibration' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-RuntimeApple' in project 'Pods' via options '-lReact-RuntimeApple' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-RuntimeCore' in project 'Pods' via options '-lReact-RuntimeCore' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-RuntimeHermes' in project 'Pods' via options '-lReact-RuntimeHermes' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-cxxreact' in project 'Pods' via options '-lReact-cxxreact' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-debug' in project 'Pods' via options '-lReact-debug' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-graphics' in project 'Pods' via options '-lReact-graphics' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-hermes' in project 'Pods' via options '-lReact-hermes' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-jserrorhandler' in project 'Pods' via options '-lReact-jserrorhandler' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-jsi' in project 'Pods' via options '-lReact-jsi' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-jsiexecutor' in project 'Pods' via options '-lReact-jsiexecutor' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-jsinspector' in project 'Pods' via options '-lReact-jsinspector' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-jsitracing' in project 'Pods' via options '-lReact-jsitracing' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-logger' in project 'Pods' via options '-lReact-logger' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-nativeconfig' in project 'Pods' via options '-lReact-nativeconfig' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-perflogger' in project 'Pods' via options '-lReact-perflogger' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-rendererdebug' in project 'Pods' via options '-lReact-rendererdebug' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-runtimescheduler' in project 'Pods' via options '-lReact-runtimescheduler' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'React-utils' in project 'Pods' via options '-lReact-utils' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'ReactCommon' in project 'Pods' via options '-lReactCommon' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'SocketRocket' in project 'Pods' via options '-lSocketRocket' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'Yoga' in project 'Pods' via options '-lYoga' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'fmt' in project 'Pods' via options '-lfmt' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'glog' in project 'Pods' via options '-lglog' in build setting 'OTHER_LDFLAGS'
        ➜ Implicit dependency on target 'libevent' in project 'Pods' via options '-llibevent' in build setting 'OTHER_LDFLAGS'
    Target 'Pods-ReproducerApp' in project 'Pods'
        ➜ Explicit dependency on target 'CocoaAsyncSocket' in project 'Pods'
        ➜ Explicit dependency on target 'DoubleConversion' in project 'Pods'
        ➜ Explicit dependency on target 'FBLazyVector' in project 'Pods'
        ➜ Explicit dependency on target 'Flipper' in project 'Pods'
        ➜ Explicit dependency on target 'Flipper-Boost-iOSX' in project 'Pods'
        ➜ Explicit dependency on target 'Flipper-DoubleConversion' in project 'Pods'
        ➜ Explicit dependency on target 'Flipper-Fmt' in project 'Pods'
        ➜ Explicit dependency on target 'Flipper-Folly' in project 'Pods'
        ➜ Explicit dependency on target 'Flipper-Glog' in project 'Pods'
        ➜ Explicit dependency on target 'Flipper-PeerTalk' in project 'Pods'
        ➜ Explicit dependency on target 'FlipperKit' in project 'Pods'
        ➜ Explicit dependency on target 'OpenSSL-Universal' in project 'Pods'
        ➜ Explicit dependency on target 'RCT-Folly' in project 'Pods'
        ➜ Explicit dependency on target 'RCTRequired' in project 'Pods'
        ➜ Explicit dependency on target 'RCTTypeSafety' in project 'Pods'
        ➜ Explicit dependency on target 'React' in project 'Pods'
        ➜ Explicit dependency on target 'React-Codegen' in project 'Pods'
        ➜ Explicit dependency on target 'React-Core' in project 'Pods'
        ➜ Explicit dependency on target 'React-CoreModules' in project 'Pods'
        ➜ Explicit dependency on target 'React-Fabric' in project 'Pods'
        ➜ Explicit dependency on target 'React-FabricImage' in project 'Pods'
        ➜ Explicit dependency on target 'React-ImageManager' in project 'Pods'
        ➜ Explicit dependency on target 'React-Mapbuffer' in project 'Pods'
        ➜ Explicit dependency on target 'React-NativeModulesApple' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTActionSheet' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTAnimation' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTAppDelegate' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTBlob' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTFabric' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTImage' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTLinking' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTNetwork' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTSettings' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTText' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTVibration' in project 'Pods'
        ➜ Explicit dependency on target 'React-RuntimeApple' in project 'Pods'
        ➜ Explicit dependency on target 'React-RuntimeCore' in project 'Pods'
        ➜ Explicit dependency on target 'React-RuntimeHermes' in project 'Pods'
        ➜ Explicit dependency on target 'React-callinvoker' in project 'Pods'
        ➜ Explicit dependency on target 'React-cxxreact' in project 'Pods'
        ➜ Explicit dependency on target 'React-debug' in project 'Pods'
        ➜ Explicit dependency on target 'React-graphics' in project 'Pods'
        ➜ Explicit dependency on target 'React-hermes' in project 'Pods'
        ➜ Explicit dependency on target 'React-jserrorhandler' in project 'Pods'
        ➜ Explicit dependency on target 'React-jsi' in project 'Pods'
        ➜ Explicit dependency on target 'React-jsiexecutor' in project 'Pods'
        ➜ Explicit dependency on target 'React-jsinspector' in project 'Pods'
        ➜ Explicit dependency on target 'React-jsitracing' in project 'Pods'
        ➜ Explicit dependency on target 'React-logger' in project 'Pods'
        ➜ Explicit dependency on target 'React-nativeconfig' in project 'Pods'
        ➜ Explicit dependency on target 'React-perflogger' in project 'Pods'
        ➜ Explicit dependency on target 'React-rendererdebug' in project 'Pods'
        ➜ Explicit dependency on target 'React-rncore' in project 'Pods'
        ➜ Explicit dependency on target 'React-runtimeexecutor' in project 'Pods'
        ➜ Explicit dependency on target 'React-runtimescheduler' in project 'Pods'
        ➜ Explicit dependency on target 'React-utils' in project 'Pods'
        ➜ Explicit dependency on target 'ReactCommon' in project 'Pods'
        ➜ Explicit dependency on target 'SocketRocket' in project 'Pods'
        ➜ Explicit dependency on target 'Yoga' in project 'Pods'
        ➜ Explicit dependency on target 'boost' in project 'Pods'
        ➜ Explicit dependency on target 'fmt' in project 'Pods'
        ➜ Explicit dependency on target 'glog' in project 'Pods'
        ➜ Explicit dependency on target 'hermes-engine' in project 'Pods'
        ➜ Explicit dependency on target 'libevent' in project 'Pods'
    Target 'React-rncore' in project 'Pods' (no dependencies)
    Target 'React-RCTAppDelegate' in project 'Pods'
        ➜ Explicit dependency on target 'RCT-Folly' in project 'Pods'
        ➜ Explicit dependency on target 'RCTRequired' in project 'Pods'
        ➜ Explicit dependency on target 'RCTTypeSafety' in project 'Pods'
        ➜ Explicit dependency on target 'React-Core' in project 'Pods'
        ➜ Explicit dependency on target 'React-CoreModules' in project 'Pods'
        ➜ Explicit dependency on target 'React-Fabric' in project 'Pods'
        ➜ Explicit dependency on target 'React-NativeModulesApple' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTFabric' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTImage' in project 'Pods'
        ➜ Explicit dependency on target 'React-RCTNetwork' in project 'Pods'
        ➜ Explicit dependency on target 'React-RuntimeApple' in project 'Pods'
        ➜ Explicit dependency on target 'React-RuntimeCore' in project 'Pods'
        ➜ Explicit dependency on target 'React-RuntimeHermes' in project 'Pods'
        ➜ Explicit dependency on target 'React-debug' in project 'Pods'
        ➜ Explicit dependency on target 'React-graphics' in project 'Pods'
        ➜ Explicit dependency on target 'React-hermes' in project 'Pods'
        ➜ Explicit dependency on target 'React-nativeconfig' in project 'Pods'
        ➜ Explicit dependency on target 'React-rendererdebug' in project 'Pods'
        ➜ Explicit dependency on target 'React-runtimescheduler' in project 'Pods'
        ➜ Explicit dependency on target 'React-utils' in project 'Pods'
        ➜ Explicit dependency on target 'ReactCommon' in project 'Pods'
    Target 'React-RuntimeApple' in project 'Pods'
        ➜ Explicit dependency on target 'RCT-Folly' in project 'Pods'
        ➜ Explicit dependency on target 'React-Core' in project 'Pods'
        ➜ Explicit dependency on target 'React-CoreModules' in project 'Pods'
        ➜ Explicit dependency on target 'React-Mapbuffer' in project 'Pods'
 BUNDLE  ./index.js

 LOG  Running "ReproducerApp" with {"rootTag":1,"initialProps":{"concurrentRoot":true},"fabric":true}

Reproducer
https://github.com/ellemedit/rn-transition-bug-reproduce
Screenshots and Videos
https://github.com/facebook/react-native/assets/2682865/365b82b8-95c7-4398-a20b-c9215fd15c5b

Still reproducible with RN 0.74.5.

@ellemedit @dlindenkreuz Thanks for the report. This is known issue internally and we already have a fix almost ready. We are running an experiment on that to make sure it does not have unexpected side effects, but we will probably try to land it for 0.76

Is there any update on this issue, @cipollesch?

Still happening for rn 0.76.5

Related discussion
https://github.com/reactwg/react-native-new-architecture/discussions/94

Hi everyone! sorry for the delay. We had a fix for this and we were experimenting with it internally.
Unfortunately, the fix was causing some regressions on internal metrics and we are not able to ship it right now.
Starting from 0.78, React Native will ship with React 19. We expect for this issue to be solved by React 19. We verified that this issue does not reproduce when using use, that is the expected way to use Suspense.


Graphs past a week dont show

I saw that this was covered through a google search but I'm not really following the solution given.
This is my storage-schemas file. Everything under 1 week works, 1 week on dont show anything.
Schema definitions for Whisper files. Entries are scanned in order,
and first match wins. This file is scanned for changes every 60 seconds.

[name]
pattern = regex
retentions = timePerPoint:timeToStore, timePerPoint:timeToStore, ...
Carbon's internal metrics. This entry should match what is specified in
CARBON_METRIC_PREFIX and CARBON_METRIC_INTERVAL settings
[carbon]
pattern = ^carbon.
retentions = 60:90d
[icinga2_internals]
pattern = ^icinga2..*.(max_check_attempts|reachable|current_attempt|execution_time|latency|state|state_type)
retentions = 5m:7d
[icinga2_default]
pattern = ^icinga2.
retentions = 1m:2d,5m:10d,30m:90d,360m:4y
[default_1min_for_1day]
pattern = .*
retentions = 60s:1d

Hi @raptureveteran
which metrics are affected by this behaviour?
According to configuration above by default you'll have 1 day of data instead of week.

The graphs. Imgur link for an example
https://imgur.com/a/6EdKk38
I changed the storage-schemas to
[icinga2_internals]
pattern = ^icinga2..*.(max_check_attempts|reachable|current_attempt|execution_time|latency|state|state_type)
#retentions = 5m:7d
retentions = 1m:2d,5m:10d,30m:90d,360m:4y
[icinga2_default]
pattern = ^icinga2.
retentions = 1m:2d,5m:10d,30m:90d,360m:4y
and the above is the result, now suddenly i have these huge gaps.

@raptureveteran Did you manage to get your config right? I want to close this issue as I don't think this is a bug.


drivers: ethernet: stm32_hal: Add a HW checksum option

Add a HW checksum option that can potentially enhance performances on STM32 SoCs (except STM32H7).
Suggested by @rlubos in https://github.com/zephyrproject-rtos/zephyr/pull/46340#issuecomment-1148805746.
Not tested so testing and feedbacks of STM32 ethernet users welcome.

I do not have any performance numbers, but I can confirm that this patch works for me - tested with my custom board using an STM32F4.


Improved locality-aware description

Fixes DOC-3760
Improvement to the description of how locality-aware backups work.

This change is

Just some optional phrasing nits, otherwise LGTM!

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @adityamaru, @andf-crl, and @kathancox)

v21.2/take-and-restore-locality-aware-backups.md line 27 at r2 (raw file): Some optional nits:

I agree that coordinator could be confusing, but I find running the flow somewhat vague. What about:
at the time the distributed backup flow was planned --> at the time the distributed backup began
running the flow --> managing the backup

Putting this together with some minor language nits, perhaps something like:

Every node involved in the backup is responsible for backing up the ranges for which it was the leaseholder at the time the distributed backup began. The locality of the node managing the distributed backup determines where the backup files will be placed in a locality-aware backup. The node managing the backup and the node serving as the leaseholder of the range being backed up are usually the same, but can differ when lease transfers have occurred during the execution of the backup. In such cases, the leaseholder node returns the files to be backed up to the node managing the backup (usually a local transfer), which then ...

@andf-crl I like your changes.... but I think why the "flow" and "planned" would be better placed here is not obvious until a backup reference piece I'm working on publishes (my bad). Jobs have planning & execution stages and a "DistSQL flow" is planned as part of the job. I'll take a look at the language again tomorrow and see if it can be tightened or further links provided. Otherwise, I'll make sure to update this piece when the reference piece publishes. Thanks for your review as always!


[MT-4450] Creating a Link does not focus URL input

Ticket: https://linear.app/prezly/issue/MT-4450/editor-creating-a-link-does-not-focus-url-input

@e1himself nice catch 👍


ReferenceError when using preact.config.js

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
I added a preact.config.js because I wanted to add a webpack loader. I added an empty function that does nothing. Next I ran preact watch which results in this error:
ReferenceError: [BABEL] MY_LOCAL_PATH_TO_PROJECT/preact.config.js: Unknown option: base.plugin. Check out http://babeljs.io/docs/usage/options/ for more information about options.

A common cause of this error is the presence of a configuration options object without the corresponding preset name. Example:

Invalid:
  `{ presets: [{option: value}] }`
Valid:
  `{ presets: [['presetName', {option: value}]] }`

For more detailed information on preset configuration, please see http://babeljs.io/docs/plugins/#pluginpresets-options.

I traced the bug back to here: https://github.com/developit/preact-cli/blob/master/src/lib/webpack/transform-config.js#L19.
I was able to workaround this by just creating an empty .babelrc in my project like this:
{}

@acoll You shouldn't do anything specific as webpack + babel work out of the box. You only add that preact.config.js file if you want to customize some webpack configuration.

creating an empty .babelrc in my project

when you do this, you are telling the preact-cli to overwrite the whole internal babel-config with what's given by the user.

@rodush Yea my intent was to add a new webpack loader that isn't included in the default webpack config (the polymer loader to be specific).
@reznord I think this makes sense, maybe the docs should mention that if you use a preact.config.js then you also need to include a babel config. Also if you don't the cli could fail with a more helpful message. If thats the right direction I'd be happy add some error handling and send a pull request.

You are wrong! You don't need to specify the .bablerc file every time you want to use preact.config.js.
It would be great if you can link to your code where you are getting this problem (the whole project) so I can test it locally.

Oh I misunderstood. Also I was unable to get the same error when starting a fresh project which led me to realize that this only happens inside a nested directory of another project with a package.json that has its own babel config.
I created a subdirectory inside an existing project and did a fresh preact create and added a preact.config.js and saw this issue. It seems like its going up a few directories to that package.json and getting an error on that babel config.
It seems like this was just caused by my weird directory structure and can be closed.
Thanks for the help. Apologies.


Implement an Edit button for saved badges

The badges on the saved badges screen are missing the option to edit them. Please implement it.

@mariobehling So, when the user clicks on the edit button. The badge should be loaded in another activity where he can edit the badge?. Currently we cannot restore saved badge to its respective text or clipart, because the LED Badge works in bits, and we store the bits inside the badge.txt file. Please share your thoughts on it

@mariobehling this can be implemented when we have a feature to create custom cliparts as we can then redirect the the user to the edit screen where he can edit the clipaet accordingly

@mariobehling Can I work on this, I'm thinking of making two round button in the corner for edit and share, and making the swiping left and right for deletion. For editting, it will make a pop up dialog?

@anhanh11001 how are you going to edit it?

@adityastic for now, I'm thinking about a pop - up alert dialog with all of the setting info and then overwrite the current file. Do you think will there be any problems with that ?

@anhanh11001 how are you going to restore the saved badge. It is stored in hexadecimal strings, not with text or drawableSelectedID

I don't quite understand your question, because this issue is about editting, why do we want to discuss about restoring?

@anhanh11001 How are you going to edit the badge, if you don't have a mechanism to read the badge. Example: I saved a custom clipart  💀 . then shared it with someone who does not has this clipart in his app. You can import, and transfer the unknown clipart to the hardware. But how will you be able to edit it to ☠ ? if the person needs to change some parts in the clipart and we need to be able to read the unknown bytes stored inside the file

ok, I kinda get your point now, at first I thought editing is more about to edit the setting of the badges (marque,inverted,speed,...).
But what do you mean by "don't have a mechanism to read the badge". Because if a user doesn't have it then how can they load the information and run the animations with text/clipart?
One more thing, what do you mean by "having clipart 💀 and edit it to ☠". That's basically changing new clipart, which can be done in the main fragment.

By "don't have a mechanism to read the badge" I mean, you need to find a way read the byte code and create the text out of it. And if it is not a text, it will be a clipart. then you need to find out which one.
BUT, if you someone creates a custom clipart like this 💀 and saves it into his application, let's name the owner of this device as owner 1. owner 1 now shares the clipart to owner 2. Owner 2 can import the clipart using the file, even watch it on the preview because preview reads data in the form of bits and not in the form of text or drawable. when owner 2 clicks on edit, he should be taken back to the screen where he can edit the clipart, but as this clipart was created by owner 1 in his device you cannot identify it using some drawableID.
Sorry for my bad english

ok, it's clear to me know. Thank you for your detailed explanation! I will think more about the solution.

Why not save both source and hex and no need for reverse lookup

@iamareebjamal if we save the drawable itself which is the source, and transfer the file. In the other person's application we still would have to look up which drawable it is matching and what if it was a custom clipart, the drawable would not match any of the stored cliparts or text

we still would have to look up which drawable it is matching

Why? You already have the 8-bit source

@iamareebjamal I did not get what you mean by 8-bit source sir. Can you please elaborate

By source of the drawable, I mean you have the information needed to show it on the screen

@iamareebjamal I created 40x11 drawables by hand and saved them into the application, when a user selects it, we convert the drawable to a 16-bit number of variable length. The keyword here is variable length as the length of the 16-bit number depends upon the number of text which were used to create the text or the width of the drawable excluding the transparent pixels. This 16-bit variable length number is what is general for both text and drawable, this is the format which can be read by the preview and the hardware too. And we are storing this 16-bit variable length number itself currently.

And if we want to convert the 16-bit number to it's respective text or drawable. We need to try every possible combination of our resources (text or drawable) and check which one matches it exactly if we want to edit the saved badge. Hence my suggestion is to create a section seperately which can let you edit any 16 bit number, but this will definitely take time sir

@iamareebjamal I am even ready to work on it even but I have an exam tomorrow, please let me know your thoughts on it.

@iamareebjamal I am even ready to work on it even but I have an exam tomorrow, please let me know your thoughts on it sir. This is one of the major issues who's solution is listed in my gsoc proposal as well
Sorry for my bad English

0001000
0010100
0100010
0010100
0001000
You have this as source, you can't show a diamond?

How will you compare it to a drawable without converting every drawable inside the app and checking which drawable produces the same source ?

And the source will be 102f882f10

We are working with hexadecimals and not binary

Now take this condition.
0001000000001000
0010100000001000
0100010000001000
0010100000001000
0001000000001000
Its hex will be 100f2f0f880f2f0f100f

If you want to convert this to its original high level values which is a diamond image and line image. You will have to try every combination with the available images to get all the possible images which match the resource

Now consider more than 5 images.
we will have to test n to power n conditions where n is the number of possible text and drawables inside the application

You are not understanding what I mean by source. By source, I mean bitmap

@iamareebjamal ok sir, I get it now so now if we save the source ( text or bitmap ) and the configuration in the badge file then we can bring it back to the original state. The only issue which would be there is if someone created a custom clipart and sent it to a device which does not have this clipart

@iamareebjamal yes sir, actually this is an amazing idea. I guess I can pull this off in under a week. I just need to create a view which can interpret text and drawable at the same time. It will be able to store json in this format
{ "hexstrings":[{"type":"clipart", "bytes":"10fd1331..."}.....].... }

Yes I can confirm that this is possible after #238 and #262. Thanks @iamareebjamal


Problem are coming in library new episodes are not showing in library

Source information
Gogoanime 13.78
Source language
English
Steps to reproduce

Expected behavior
Slide down in library option are episodes are not showing
Actual behavior
Please

Aniyomi version
<IP_ADDRESS>
Android version
Android 11
Other details
Please take action
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Duplicate of #2986


Waypoint manager list transmission picks wrong alternate storage on first readback

This was all wrongly interpreted based on bad testing. Its not a real issue.


Inefficient Regular Expression Complexity vulnerability pending CVSS allocation

Dependency npm:debug:4.3.4 is vulnerable Cx8bc4df28-fcf5 7.5 Inefficient Regular Expression Complexity vulnerability pending CVSS allocation  Results powered by Checkmarx(c)
Is this being looked into or resolved?

I have no idea what you're referring to. Please give me some more information. There have been a few ReDos vulnerabilities found that have taken one of two outcomes: a CVE has been allocated, or a CVE has been explicitly blocked and the researcher was asked not to take it further because the surface area was negligible except under the most egregious, irresponsible uses of the library.
For example, in one case, you would have had to have passed long, unsanitized user input into the namespace parameter of the debug() builder in order to be affected. As this is a bizarre, unusual, unsupported, discouraged and undocumented use case, a CVE was not allocated.
It's the same thing as when we received a "vulnerability" report in chalk that stated that input that had malicious escape sequences were re-emitted by chalk and that they wanted a CVE and monetary compensation for reporting said vulnerability. Some of the reports we receive are ridiculous and thus I tend to request they cease with the CVE process because you'd have to go out of your way to make your software vulnerable. Further, "researchers" tend to take these CVEs and allocate the highest possible score to them in order to get higher payouts on e.g. https://huntr.dev, along with reporting them piecemeal so that they can register multiple CVEs, etc.
At this point, ReDos reports against this package are being considered spam and I've been reporting them to Huntr in most cases when they come through. I'm not sure where you're seeing this information but I doubt whatever "report" you're seeing actually affects you.

To be abundantly clear, there has never been a reported ReDos attack using debug as a vector in the 10+ years this package has existed across the billions of downloads this package receives per-annum, because consumers of this library would have to be doing some pretty blatantly reckless stuff in order for it to be attacked.

I'm using JetBrains tools, specifically WebStrom, but it should be any of them. The reason for mentioning it here was that I did not find it listed in any way. Also, others may ask, so hopefully this helps asking the same question or multiple reports.
This is the link it takes you too
https://devhub.checkmarx.com/cve-details/Cx8bc4df28-fcf5/
CWE-1333 - Inefficient Regular Expression Complexity
The product uses a regular expression with an inefficient, possibly exponential
worst-case computational complexity that consumes excessive CPU cycles.

I'm not saying it is an issue. I hope this helps.
Summary
In NPM `debug`, the `enable` function accepts a regular expression from user input without escaping it.
Arbitrary regular expressions could be injected to cause a Denial of Service attack on the user's browser, otherwise known as a ReDoS (Regular Expression Denial of Service). This is a different issue than CVE-2017-16137.

So, it looks like considered spam. Maybe put this up front, pin it, or add to the README so others won't ask.

Closing as a dupe of #924 (aware it was posted after this issue, however it has more details and a linked investigation with more pertinent information about the filing).
Thanks for bringing this to my attention.

Since December 2020 Checkmark has raised the following issue (which is getting flagged for me in WebStorm IDE):
https://devhub.checkmarx.com/cve-details/Cx8bc4df28-fcf5/
INEFFICIENT REGULAR EXPRESSION COMPLEXITY IN DEBUG
In NPM debug, the enable function accepts a regular expression from user input without escaping it. Arbitrary regular expressions could be injected to cause a Denial of Service attack on the user's browser, otherwise known as a ReDoS (Regular Expression Denial of Service). This is a different issue than CVE-2017-16137.
CWE-1333 - Inefficient Regular Expression Complexity
The product uses a regular expression with an inefficient, possibly exponential worst-case computational complexity that consumes excessive CPU cycles.

Since this needs fixing but has been closed I've raised https://github.com/debug-js/debug/issues/939


feat: STRINGS-374 & STRINGS-439 Enable users to provide a prefix during CLI push and pull

Purpose: Provide documentation for the new params on import and export.
Related tickets:
https://phrase.atlassian.net/browse/STRINGS-374
https://phrase.atlassian.net/browse/STRINGS-439

hey @malvarezphrase can you please explain the logic with the truncating file name? I don't get it.

hey @malvarezphrase can you please explain the logic with the truncating file name? I don't get it.

@jablan The reason for the truncate of the file name is that we want to use the idx_translation_keys_on_name_project_deleted index on translation keys when the prefix is used as a filter. Therefore we only allow it to be maximum 255 characters long.
Now looking at the other usages of the prefix, is it also possible to add a limit on create.yaml and download.yaml? Or will phrase respond with a validation error?

@malvarezphrase sorry, I need a bit more context. where does <file_path> come from? is that a "magic" prefix working similar to <locale_code> and such? is it explained somewhere?

Where would I put it?

@malvarezphrase I would start with the ticket description :smile:
if it can be specified only through the phrase.yml, probably we should document it in https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/phrase.json
but I don't see other magic placeholders either, so perhaps it's a good opportunity to add them all?
regarding the truncating, if I understand you correctly, we don't support prefixes longer than 255 chars? in that case we should probably error out rather then truncating them?

@jablan Thanks a lot for the feedback! I already updated the ticket descriptions and also the description of this PR.
Are the changes to https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/phrase.json being done manually? If so, I will prepare a PR for it.

in that case we should probably error out rather than truncating them?
How do errors on the CLI usually work? The validation for the length is already in place inside phrase.

perhaps then just passing whatever prefix is provided (either explicitly by the user or by using the filename) will be enough. is the error clear to the user?
as for json schema, perhaps you could open a small ticket, I see couple other things that could be fixed there, so we will do it all together.
just remember, we also have https://support.phrase.com/hc/en-us/articles/5808300599068-Using-the-CLI-Strings where we might want to describe this feature?

@jablan & @theSoenke after changing to not truncate the length of the prefix and updating the description here, is there anything else missing?

@jablan @malvarezphrase I've changed the file_path placeholder to make it work with other placeholders. It's also now possible to use the placeholder as part of the prefix like <file_path>-foo. Having the ability to separate the path from the key name by characters seems useful when I was testing it


Migrate d3-flame-graph to d3 version 4.

There are breaking API changes where v4 works differently:
Individual nodes are exposed/accepted as d3-hierarchy nodes (e.g. in
label()'s callback).  This means d.dx is now d.x1 - d.x0, and
d.name is now d.data.name.
Transition ease functions are specified as functions (e.g. d3.easeCubic)
rather than as strings.

Ping - is this something you're interested in?
At work we're dropping support for d3v3, and would love to keep using this library rather than maintaining a fork.

Hey @sam-mccall!Yes, definitely. I got pulled away from this but I'll look into merging this shortly.


[bug]ToolServer和XAgentServer必须要在一个network下面吗？

XAgentWeb上一直登陆失败，显示
ERROR  9:59:48 PM [vite] http proxy error at /login:                                                                              21:59:48
Error: connect ECONNREFUSED <IP_ADDRESS>:8090
at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1187:16) (x2)
agentserver正常：
[+] Running 1/0
✔ Container XAgent-Server  Created                                                                                0.0s
Attaching to XAgent-Server
XAgent-Server  | INFO:     Uvicorn running on http://<IP_ADDRESS>:16204 (Press CTRL+C to quit)
XAgent-Server  | INFO:     Started parent process [1]
XAgent-Server  | INFO:     Started server process [8]
XAgent-Server  | INFO:     Waiting for application startup.
XAgent-Server  | INFO:     Started server process [15]
XAgent-Server  | INFO:     Waiting for application startup.
XAgent-Server  | INFO:     Started server process [13]
XAgent-Server  | INFO:     Waiting for application startup.
XAgent-Server  | INFO:     Started server process [9]
XAgent-Server  | INFO:     Waiting for application startup.
XAgent-Server  | INFO:     Started server process [12]
XAgent-Server  | INFO:     Waiting for application startup.
XAgent-Server  | INFO:     Started server process [10]
XAgent-Server  | INFO:     Waiting for application startup.
XAgent-Server  | INFO:     Started server process [11]
XAgent-Server  | INFO:     Waiting for application startup.
XAgent-Server  | INFO:     Started server process [14]
XAgent-Server  | INFO:     Waiting for application startup.
XAgent-Server  | INFO:     Application startup complete.
XAgent-Server  | INFO:     Application startup complete.
XAgent-Server  | INFO:     Application startup complete.
XAgent-Server  | INFO:     Application startup complete.
XAgent-Server  | INFO:     Application startup complete.
XAgent-Server  | INFO:     Application startup complete.
XAgent-Server  | INFO:     Application startup complete.
XAgent-Server  | INFO:     Application startup complete.

Thanks for your advice, it will work now.


Allow --noCheck to be commandLine option

Works on top of #58626 and #58838
Adds checkPending to buildInfo so as to handle if there was noCheck pending. This does not add "noCheck" as semantic affecting diagnostics because builder can handle that and save the diagnostics between runs with and without "noCheck"

This will close #29651, right?

Yes. We would report ssyntax errors though while emitting.

ssyntax errors

Oh no, I hadn't realized some of the TypeScript devs were snakes

@typescript-bot test it


Repo sync for protected CLA branch

The pull request is created from master637650110825524210 to master to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Improve graphql mocking

Grapql has a certain (really annoying IMO) feature, it fails silently if your mocked data doesn't conform to its type definitions. In such case it returns undefined, undefined, undefined for data, loading, error which is really confusing. And even if you know about such quirk of MockedProvider creating complex mocked objects in plain javascript  files is rather annoying (I ended up copying data from production most of the time).
I propose the following:

[x] Move all dummy data to typescript files.
[ ] Move as much mock data from tests to dummy folder. You shouldn't define big complex objects in tests files.
[ ] Maybe even move storybook data to dummy folder.

This way we'll get a single source of truth of always correctly typed data.

Closed in favor of https://github.com/garageScript/c0d3-app/issues/1822


Blank TM:PE toolbar buttons after recent PR merge

Originally posted by @kianzarrin in https://github.com/CitiesSkylinesMods/TMPE/issues/1422#issuecomment-1056996064 :

red arrow is bad green arrow is good

@kianzarrin I'm unable to reproduce the issue - here's what I see in-game:

@kianzarrin At a guess it might need a call to RebuildMenu() adding to OptionsManager.OnAfterLoadData() - can you try that and see if it solves the blank button issue for you?

Try Scenario editor but instead of savegame select map. All TM:PE features are disabled and then enable them (no idea why there is no TTL) you will see this:

I think it affects New Game mode in general, but I haven't check regular new game yet.

Btw, some textures from atlas are not available in Scenario editor so backgrounds are blank.

TTL is disabled in all editors currently as per details in #959

There is nothing about Map/Scenario editor... We need to test it, but now I'm 99/5% sure that all features will work properly in the Map and Scenario editor. It should be limited in Asset Editor and disabled for Theme Editor

What's the best way to identify the context (eg. which editor is active) - TMPELifecycle.Mode ?

What's the best way to identify the context (eg. which editor is active) - TMPELifecycle.Mode ?

hmm, why not TMPELifecycle.AppMode?

hmm, why not TMPELifecycle.AppMode?

Ok, will use that.
BTW, if features aren't getting enabled it's likely because OptionsManager.LoadData() isn't being called, as that's what's setting defaults.
What's the best way to apply -NoWorkshop launch option these days? I'll need to do some testing in editors and don't want to manaully disable 140+ mods / 5600+ assets.

What's the best way to apply -NoWorkshop launch option these days? I'll need to do some testing in editors and don't want to manaully disable 140+ mods / 5600+ assets.

Hmm you can use Load Order mod + profiles. It's pretty powerful, right @kianzarrin 😄

It looks like there is something wrong or different than before because reading the log it should load defaults but does not at all

Yeah, I'm testing it now.

I almost finished fixing UI/textures etc.

Ah, I think I know what's causing it - if config is null (eg. due to new game)... it's not going to call OptionsManager.LoadData() = no defaults get set.
As for enabling the options resulting in blank buttons, that's likely a fubar on my part in recent PR - pretty sure I know what's causing it but just need to do some extra checking.
Both these things should be relatively easy to fix; will send PR shortly.

I almost finished fixing UI/textures etc.

Ah, I just created issue to track that hehe https://github.com/CitiesSkylinesMods/TMPE/issues/1450
Does your fix include missing button textures?

Does your fix include missing button textures?

Everything what I found and it probably has nothing to your recent changes 😉

The missing defaults are due to my recent changes. Need to ponder how to better handle the default option values (have some ideas. just not sure which is best approach).

The missing defaults are due to my recent changes. Need to ponder how to better handle the default option values (have some ideas. just not sure which is best approach).

Yeah, I leave fixing missing defaults for you 😄

The missing defaults are due to my recent changes. Need to ponder how to better handle the default option values (have some ideas. just not sure which is best approach).

@aubergine10 I think you can also revive and improve that commented out error message when loading save data fails so at least user will know that something went wrong, since now is not even aware of. 🤞

Yup - will do.

I tried with new game.

https://cdn.discordapp.com/attachments/948480860670291968/948541891555774534/output_log.txt
https://cdn.discordapp.com/attachments/948480860670291968/948541891752898570/TMPE.log
These are logs just in case

Note that #1425 will also need merging to fix the default values for mod options.


Unknown release 5.5.45 ?

If I run composer update on my 5.5 application, I get this in the console:
Updating laravel/framework (v5.5.44 => v5.5.45): Loading from cache
So I want to take a look at what changed in v5.5.45.
But I can't find any mention of v5.5.45 - last mentioned is 5.5.44.   Can someone kindly explain what I'm doing wrong? Thank you.

You aren't doing anything wrong, the changelog just hasn't been updated yet.

Thank you so much -- I just found how to do that :)
https://github.com/laravel/framework/compare/v5.5.44...v5.5.45

Please don't ignore the issue template.


Added mkdir for lib folder and uninstall option in make.

There was no mkdir for $INSTALL_LIB in make file. This creates problem with "make install" for a custom $INSTALL_PREFIX. So added one mkdir.
Also added an uninstall option.

Merged. Thanks for your contribution.


[HxInputRange] new component + documentation #32

(Not related to the line of code attached in original comment.)

Consider naming conflict:

HxInputDate enters one "scalar" value
HxInputDateRange enters two values - range - from/to
HxInputRange enters one "scalar" value

We are aware of this conflict, we already discussed it (@crdo). The original name was HxInputSlider, but we decided to stick with <input type="range" /> and go for HxInputRange. There is still a possibility we might it somehow relate to HxInputNumber (descendant?) and make it HxInputNumberRange (does not resolve the naming conflict) or HxInputRangeNumber (better as of the conflict as it does not evoke from-to numeric value).

Consider naming conflict:

HxInputDate enters one "scalar" value
HxInputDateRange enters two values - range - from/to
HxInputRange enters one "scalar" value

As you can achieve this by combining with other HxInput components I don't think we need that.

The screenshot was not meant as a design proposal, just to illustrate the fact, that you barely want the range to be use separately (without visibility of the numeric value).
I think we should consider some "composite" component which will be easy to use. Similar to HxInputDate where you get the HxCalendar bundled with input to get something you can use immediately.
(On the other hand: Still not sure about the scenarios where you would want to use such input-component in project like Goran?)


Fix #1677: Add name argument to parse & format props for Field + Fields

Description
Currently, parse and format props are called with only the field value.:

format : (value) => formattedValue [optional]
parse : (value) => parsedValue [optional]

As described in #1677, there are cases where it would be beneficial for it to be called with the field name such that the interface for both would become:

format : (value, name) => formattedValue [optional]
parse : (value, name) => parsedValue [optional]

It would allow for fields of the same component that rely on different types of values to be differentiated by name in the value lifecycle through parse & format.
Changes Proposed

Add field name as a second input to parse & format
Update tests for parse & format for both Field & Fields components with new name argument
Update docs for Field & Fields to explain how parse & format props function with access to the field name.

Fixes #1677

Current coverage is 100% (diff: 100%)

Merging #1795 into master will not change coverage

@@           master   #1795   diff @@
=====================================
  Files          53      53
  Lines        1143    1144     +1
  Methods         0       0
  Messages        0       0
  Branches        0       0
=====================================
+ Hits         1143    1144     +1
  Misses          0       0
  Partials        0       0

Powered by Codecov. Last update e9bcc1b...cb1352e

Concur. The parse() & format() props of the Fields component seem pretty useless as is.
Since afaict Fields is the recommended way to do do dependant fields, then at the moment you cannot have a field that both :

depends on another field (e.g disabled if some other field is empty)
and has its values massaged in and out with format() / parse()

Published in v6.1.0.


Rolling window kwargs v1.7.x

See https://github.com/SciTools/iris/pull/1495

@rhattersley I have implemented the changes you suggested and targetted it at v1.7.x

@lbdreyer - any chance you could fix the copyright issue?


Changes for OpenOCD and QEMU DBG servers

PR on behalf of AlSuarez

Can we address the TODO statement in GdbSrvRspClient.cpp in some better way? E.g. are we going to open a bug to investigate something later?


Renaming Flow to Power Automate

Microsoft Flow got renamed to Power Automate at Ignite

@pratapladhani : Thanks for your contribution! The author(s) have been notified to review your proposed change.

You can only sign off in the main PR conversation, not in review comments. In general, the creator of the PR should sign off, not the tech reviewer.

#sign-off


Dialog Cancel Buttons have Border around them in 1.119 and 1.120

OpenUI5 version:
1.119, 1.120
Browser/version (+device/version):
Chrome
Any other tested browsers/devices(OK/FAIL):
N/A
URL (minimal example if possible):
User/password (if required and possible - do not post any confidential information here):
Steps to reproduce the problem:

open the sap.m.Dialog sample in UI5 sample docs

click Settings Cog in top right and select 'Belize' and 'Compact'

Observe that in 1.119.x and 1.120.x the "Cancel" button has a border around it that did not exist in previous versions and versions >= 1.121.x

https://sapui5.hana.ondemand.com/1.117.1/#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog
https://sapui5.hana.ondemand.com/1.118.1/#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog
https://sapui5.hana.ondemand.com/1.119.2/#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog
https://sapui5.hana.ondemand.com/1.120.1/#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog
https://sapui5.hana.ondemand.com/1.121.1/#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog
https://sapui5.hana.ondemand.com/1.122.1/#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog

What is the expected result?

Belize Dialog's Cancel button should not have borders around it in 1.119 and 1.120, but previous versions and versions afterwards do not have it

What happens instead?

Cancel button has borders around it

Any other information? (attach screenshot if possible)

It appears the css here has been removed Belize Button.less in 1.119 and 1.120

.sapMIBar-CTX .sapMBtnInner,
.sapMBar .sapMBtnInner,
.sapMHeader-CTX .sapMBtnInner,
.sapMFooter-CTX .sapMBtnInner {
    background: @sapUiButtonLiteBackground;
    border-color: @sapUiButtonLiteBorderColor;
}

Thanks for reporting the issue. I've created an internal incident DINC0148190 for your reported issue. The colleagues will update you once they have news

sap_belize is deprecated since SAPUI5 1.120: https://openui5nightly.hana.ondemand.com/topic/a87ca843bcee469f82a9072927a7dcdb
And the rest of the listed cloud only versions are out of maintenance now https://ui5.sap.com/versionoverview.html
Please upgrade and switch to sap_horizon.
Just fyi, the changes are related to new themes development where sap.m.button[type=Default] is not changed when used in specific toolbars: https://github.com/SAP/openui5/commit/ebe17c6c3c054a4922e02a4dfc896d6ef4592c49

PS: when you create toolbars with buttons, consider setting Toolbar.design and Button.type based on https://experience.sap.com/fiori-design-web/toolbar-overview/#header-and-footer-toolbars1
As for demos, there are already logged internal tasks for reviewing the settings in the DemoKit with consideration of Fiori Guidelines


Redirected stream name - notify push error

HI !
I want to change the name of my stream by doing a redirection to my stream server with php, like this :
header("Location: rtmp://<IP_ADDRESS>:1936/app/newName");

However, when the redirection is done, I get this as an error :
2020/07/18 20:38:23 [error] 9463#9463: *129 notify: push 'oldName' to 'rtmp://<IP_ADDRESS>:1936/app/newName', client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935

The redirection works, because i can play the stream provided by the stream server, but i want to fix this error on the logs. Please, anyone can help me ?
Thank you in advance !
Regards,
Mateo

You can find it on line 1054 in ngx_rtmp_notify_module.c.
By the way, log level on line 1071 should be NGX_LOG_ERR.

You advise me to make this error no longer appear in the logs by modifying the file if I understand correctly ?
I just wanted to fix this error in a normal way, because if it appears, there's a reason, isn't there ? Unless it's not an error but only an information ?

You are right. It's not an error.

Oh okay thanks.
So I have to change what to remove this info from the logs ?

Change NGX_LOG_ERR to NGX_LOG_INFO or NGX_LOG_DEBUG_RTMP.


[DUOS-2112][risk=low] Add support for searching mail sent by date range.

DUOS-2112 builds on work completed as part of DUOS-2061 and makes the following enhancements:

Endpoint and class updates for searching mail by date range added.
Documentation and tests added to describe and validate the feature.
Limit and Offset are now validated to be greater than -1 for both searching by EmailType and Date Range.

Have you read CONTRIBUTING.md lately? If not, do that first.

Label PR with a Jira ticket number and include a link to the ticket
Label PR with a security risk modifier [no, low, medium, high]
PR describes scope of changes
Get a minimum of one thumbs worth of review, preferably two if enough team members are available
Get PO sign-off for all non-trivial UI or workflow changes
Verify all tests go green
Test this change deployed correctly and works on dev environment after deployment

Closing this PR in favor of https://github.com/DataBiosphere/consent/pull/1870


Is this will be available in Anniversary update?

Hi there,
I was wonder if this example will be work on Anniversary update: https://github.com/Microsoft/Windows-universal-samples/tree/dev/Samples/BackgroundMediaPlayback ? Or if it not- when will be?
I am trying to make a Background Audio only with JS, like this example. But for now that is not possible.
Sorry if i ask a question not for "issues" category.
Thanks all !!!

Yes, this sample demonstrates features of the Anniversary Update which you can try now through Windows Insider builds.

Are you saying that the sample doesn't work? Can you be more specific what doesn't work? I just built and ran the JS version of the BackgroundMediaPlayback sample on build 14373

.