Panic when trying to use Uuid native type with insensitive filters

Bug description

When the following query where id is @postgres.Uuid type is executed prisma is throwing the following panic:
 const data = await prisma.user.findMany({
    where: {
      id: {
        mode: "insensitive",
        contains: "something",
      },
    },
  });

(node:9993) UnhandledPromiseRejectionWarning: Error:
Invalid `prisma.user.findMany()` invocation:

  Error occurred during query execution:
ConnectorError(ConnectorError { user_facing_error: None, kind: QueryError(Error { kind: Db, cause: Some(DbError { severity: "ERROR", parsed_severity: Some(Error), code: SqlState("42883"), message: "function lower(uuid) does not exist", detail: None, hint: Some("No function matches the given name and argument types. You might need to add explicit type casts."), position: Some(Original(105)), where_: None, schema: None, table: None, column: None, datatype: None, constraint: None, file: Some("parse_func.c"), line: Some(627), routine: Some("ParseFuncOrColumn") }) }) })
    at PrismaClientFetcher.request (/home/harshit/code/reproductions/issue-3447-studio/node_modules/@prisma/client/runtime/index.js:78461:15)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at main (/home/harshit/code/reproductions/issue-3447-studio/main.ts:6:16)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:9993) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:9993) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

How to reproduce
See: https://github.com/harshit-test-org/issue-prisma-5311

Expected behavior

Prisma should not ever generate this invalid sql.
Prisma information

See the reproduction posted above
Environment & setup

OS: Ubuntu 20.04 via WSL
Database: Postgres 12 (docker)
Node.js version: 14.15.2
Prisma version:

@prisma/cli          : 2.16.0-dev.23
@prisma/client       : 2.16.0-dev.25
Current platform     : debian-openssl-1.1.x
Query Engine         : query-engine 874f616fce40a665d24867f42e602ce8b5ed2cd7 (at<EMAIL_ADDRESS>Migration Engine     : migration-engine-cli 874f616fce40a665d24867f42e602ce8b5ed2cd7 (at<EMAIL_ADDRESS>Introspection Engine : introspection-core 874f616fce40a665d24867f42e602ce8b5ed2cd7 (at<EMAIL_ADDRESS>Format Binary        : prisma-fmt 874f616fce40a665d24867f42e602ce8b5ed2cd7 (at<EMAIL_ADDRESS>Studio               : 0.343.0
Preview Features     : nativeTypes

I also get the same error when filtering a uuid column in Prisma Studio.

I also get the same error when filtering a uuid column in Prisma Studio.

We're not yet in a position to fix that issue. We'll get back to it once the Query Engine can deal with native types more granularly.

To elaborate on @Weakky's comment. We use the underlying database as much as possible. For Postgres, the query would look like this:
select * from users where id = lower($1::uuid)

Unfortunately lower does not accept a uuid as an input. In the future, we may disable this API, but we're not there yet.

This is still reproducible in 2.22.

Can reproduce in our internal dev version 4.4.0-dev.30
Note: The message is now different
ts-node main.ts
/Users/j42/Repros/5311/node_modules/@prisma/client/runtime/index.js:30854
      throw new PrismaClientUnknownRequestError(message, this.client._clientVersion);
            ^
PrismaClientUnknownRequestError:
Invalid `prisma.user.findMany()` invocation in
/Users/j42/Repros/5311/main.ts:6:34

  3 async function main() {
  4   const prisma = new PrismaClient();
  5
→ 6   const data = await prisma.user.findMany(
Error occurred during query execution:
ConnectorError(ConnectorError { user_facing_error: None, kind: QueryError(Error { kind: Db, cause: Some(DbError { severity: "ERROR", parsed_severity: Some(Error), code: SqlState(E42883), message: "operator does not exist: uuid ~~* unknown", detail: None, hint: Some("No operator matches the given name and argument type(s). You might need to add explicit type casts."), position: Some(Original(126)), where_: None, schema: None, table: None, column: None, datatype: None, constraint: None, file: Some("parse_oper.c"), line: Some(728), routine: Some("op_error") }) }) })
    at RequestHandler.handleRequestError (/Users/j42/Repros/5311/node_modules/@prisma/client/runtime/index.js:30854:13)
    at RequestHandler.request (/Users/j42/Repros/5311/node_modules/@prisma/client/runtime/index.js:30833:12)
    at async PrismaClient._request (/Users/j42/Repros/5311/node_modules/@prisma/client/runtime/index.js:31805:16)
    at async main (/Users/j42/Repros/5311/main.ts:6:16) {
  clientVersion: '4.4.0-dev.30'
}

This issue was a duplicate of https://github.com/prisma/prisma/issues/9007


-A: invalid option

Hi. I've installed luver by cloning and then sourcing luver.plugin.zsh (on macOS 13.2).
When I try to run luver help I get this message:
/Users/username/.local/share/luver/self/bin/command/help: line 157: local: -A: invalid option
local: usage: local name[=value] ...

Am I doing something wrong or is there a bug?

What is the version of your bash shell? bash --version.
Can you try upgrading it?

Can you try upgrading it?

Yes, that worked. Sorry, I should have tried that!
Apple having abandoned bash for zsh means they have only an ancient version of bash installed by default. Easy to add a proper version though.

https://github.com/MunifTanjim/luver/commit/4de334ec84242e4e7a47432c05b71e0946f7f23b
Mentioned the required bash version in README.


Revert "Math functions for Swift"

Reverts apple/swift#23140
Just the test to see if this is really what introduced source compatibility regressions:
https://ci.swift.org/view/Source Compatibility/job/swift-master-source-compat-suite/3384/console

@swift-ci please test source compatibility

Currently failing:
02:04:20   FAIL: IBAnimatable, 4.0, eb4acb, IBAnimatableApp, generic/platform=iOS
02:04:20   FAIL: IBAnimatable, 4.0, eb4acb, IBAnimatable, generic/platform=iOS
02:04:20   FAIL: Surge, 5.0, 38a328, Surge-watchOS, generic/platform=watchOS
02:04:20   FAIL: Surge, 5.0, 38a328, Surge-tvOS, generic/platform=tvOS
02:04:20   FAIL: Surge, 5.0, 38a328, Surge-macOS, generic/platform=macOS
02:04:20   FAIL: Surge, 5.0, 38a328, Surge-iOS, generic/platform=iOS
02:04:20   FAIL: Surge, 4.2, 38a328, Surge-watchOS, generic/platform=watchOS
02:04:20   FAIL: Surge, 4.2, 38a328, Surge-tvOS, generic/platform=tvOS
02:04:20   FAIL: Surge, 4.2, 38a328, Surge-macOS, generic/platform=macOS
02:04:20   FAIL: Surge, 4.2, 38a328, Surge-iOS, generic/platform=iOS
02:04:20   FAIL: SwifterSwift, 4.0, d3c3fd, SwifterSwift-watchOS, generic/platform=watchOS
02:04:20   FAIL: SwifterSwift, 4.0, d3c3fd, SwifterSwift-tvOS, generic/platform=tvOS
02:04:20   FAIL: SwifterSwift, 4.0, d3c3fd, SwifterSwift-macOS, generic/platform=macOS
02:04:20   FAIL: SwifterSwift, 4.0, d3c3fd, SwifterSwift-iOS, generic/platform=iOS

@stephentyrone @airspeedswift Math functions PR introducted multiple source compatibility regressions in external and internal projects

Let's get the change reverted until we can resolve the source compatibility breaks before we land.  All API changes to the Standard Library should go through the compatibility suite before merging.

Looks like this is going to be a non-trivial revert because there are conflicts already. @stephentyrone would be the best person to do that.

@xedin https://github.com/apple/swift/pull/23800

@stephentyrone thank you!


Core integer merge/split sequences

I had a look at my extensions and I think MajorOrMinorLimbsSequence and its constituent sequences are useful enough to be made public (perhaps with better names). Splitting UInt(s) into Int16(s) or merging UInt8(s) into Int32(s) is quite common, but a headache, and these sequences are surprisingly great at it. I suppose they assume little endian order. I should fix that.
BigInt(words: MajorLimbs(littleEndianBytes, isSigned: true, as: UInt.self)) // no headache

The latest and greatest:
for word in NBKMajorOrMinorInteger(source, isSigned: false, count: nil, as: UInt.self) { ... }
for byte in NBKMajorOrMinorInteger(source, isSigned: false, count: nil, as: Int8.self) { ... }

While there's likely a better final solution, the ordering is easy to fix with (#72).

So, it looks like I can't flatMap(_:) because capturing the element order is too expensive.

Hm. Should I turn theses into collections?

Also, is merge/split order important? Or is external map/reverse sufficient?

Assuming you have [1, 2, 3, 4], then you can form the following using only reverse():
typealias T = NBK.MajorOrMinorLimbsSequence
print(Array(T(([1, 2, 3, 4] as [Int32]), as: Int64.self))) // == 32,  64
print(Array(T(([2, 1, 4, 3] as [Int32]), as: Int64.self))) // == 32R, 64R
print(Array(T(([3, 4, 1, 2] as [Int32]), as: Int64.self))) // == 32,  64R
print(Array(T(([4, 3, 2, 1] as [Int32]), as: Int64.self))) // == 32R, 64

It works when you go from small to large as well:
typealias T = NBK.MajorOrMinorLimbsSequence
print(Array(T(([0x0000000200000001, 0x0000000400000003] as [Int64]),            as: Int32.self)           ))
print(Array(T(([0x0000000200000001, 0x0000000400000003] as [Int64]).reversed(), as: Int32.self).reversed()))
print(Array(T(([0x0000000200000001, 0x0000000400000003] as [Int64]).reversed(), as: Int32.self)           ))
print(Array(T(([0x0000000200000001, 0x0000000400000003] as [Int64]),            as: Int32.self).reversed()))

[1, 2, 3, 4]
[2, 1, 4, 3]
[3, 4, 1, 2]
[4, 3, 2, 1]

I mean, I have a working version of the above transformations but maybe it's over-engineered.

Hm. These must at least conform to BidirectionalCollection for reversed() to apply lazily. Perhaps I should add conditional conformances so it still works with sequences? I suppose I can add conformances conditionally. I'll have to think for a moment if that's the way I want to go about it, however.

Hm. Should I remake these as collections?

Also, this. I haven't compared next() to an index-based design yet.

Hm. Random-access-only makes these sequences super simple.

How much faster does random access only need to be to make sequences obsolete? I mean, at some point it's just better to convert non-random-access to random-access. No? Fast and simple sounds tempting.

Here's another thought: without sign extension, these can also be mutable.

The random access design is like 10 lines each, plus lots of indexing boilerplate (#76) :(

I added infinite sign extension, required random access and removed NBKMinorIntegerOfOne.

An empty, signed, collection defaults to zero. The alternative is a T? or crashing. ¯\_(ツ)_/¯

Given infinite sign extension, I can take the collection's count as an argument. That way, you can truncate or extend collection as it is passed to other generic algorithms.

for word in NBKMajorOrMinorInteger(source, isSigned: false, count: nil, as: UInt.self) { ... }
for byte in NBKMajorOrMinorInteger(source, isSigned: false, count: nil, as: Int8.self) { ... }

Hm. It might be viable to inline the different types inside the size agnostic one.

Meh. I'll keep it as-is for the time being.

I've been going back and forth between wanting to merge the major and minor sequence into one and keeping them separate. Ultimately, I think that having a single sequence is better. It's fewer things to understand, and therefore less of a headache.

Hm. Does an unused, internal, conformance to RandomAccessCollection have a size cost? Or is the compiler smart enough to remove the unused parts? I do like having separate sequences, for separate algorithms, and the enum seems free or close to it.

Oh. Here's a neat idea. What about a macro that returns the major or minor sequence based on the size of the input and output element. I think that's closer to what I want, because then I wouldn't have to specialize the impossible paths.
#MajorOrMinorInteger(...)

Hm. Perhaps dynamic-but-constant-folded-when-specialized branches is still the way to go.

Here's a preconditioned namespace trick, although using an enum is less arcane:
func stuff() -> Stuff {
    Element.bitWidth > Base.Element.bitWidth ? Major().stuff() : Minor().stuff()
}

@frozen @usableFromInline struct Major {
    @inlinable init() {
        assert(Element.bitWidth >= Base.Element.bitWidth)
    }
}

@frozen @usableFromInline struct Minor {
    @inlinable init() {
        assert(Element.bitWidth <= Base.Element.bitWidth)
    }
}

Is there a good name for this thing? "MajorOrMinorInteger" is quite terrible, but at least somewhat descriptive. The most succinct I've considered is "Rechunked", but I don't like that either. Hm.

I renamed NBKMajorOrMinorInteger as NBKChunkedInt. It's not perfect, but I think it's better.


Magnets attempt to pull items into full inventories if other slots are empty

Magnets will not attempt to pull items into a completely full inventory (full main inventory, full offhand, full armor slots), however, if a slot not in the main inventory is empty (i.e., an offhand or armor slot), the magnet will attempt to bring the item in even though it cannot be picked up, leading to the item to hover around the player. With many items, this can cause floating "orbs" of items following the player:

anyone remember this beta 1.8 pre-release bug?

I found that this was still happening with 3d prints, I assume it's because they share the same identifier as items in my inventory?

Are the prints unique or identical?

From what I can recollect, no they were all different.


Failure when defining a function with no args

Hi there,
I have users defining (simple) functions as strings in a config file, which ultimately get made into functions.
Often a user has a function return a constant.
My code fails in this case, MWE below.
Any ideas where I'm going wrong?
using RuntimeGeneratedFunctions
RuntimeGeneratedFunctions.init(@__MODULE__)

s = "() -> 1"
ex = Meta.parse(s)
f = @RuntimeGeneratedFunction(ex)

If I set s = (x) -> 1 it works, but then I don't have a function of 0 arguments, which is required by downstream code.

PR #29 would solve this problem.


Visualization's number of map views not appearing on graph hover in Maps dashboard

...or is this FAQ just outdated? http://docs.cartodb.com/faqs.html#how-can-i-know-how-many-map-views-has-a-specific-visualization
Support Bee user is asking: http://docs.cartodb.com/faqs.html#how-can-i-know-how-many-map-views-has-a-specific-visualization
I'm not seeing it either in Chrome 41.0.2272.118 on Yosemite 10.10.2

hi @ztephm we decided to take it out in the new dashboard redesign but it seems that some users (included you) are missing this, so we will reevaluate and try to add it in next releases.
Sounds that good?
Thanks for reporting!

Thanks @saleiva ! Sounds good, I just updated the FAQ (pull request).

Asked in SB/5116263. Writing to keep the record.


Missing the "leave_group"

Hi Sven,
as supposed by you, I had a look at your typescript version. Up to now I think it's cool, as the better group handling with the manager instance is something I was looking for. But I'm missing the "leave_group" function. I think I can make the speaker leaving the group using the "group_management" service, but it would be nice to have a leave function.
Could you add this?
Thanks Rolf

Does this help?
https://svrooij.github.io/node-sonos-ts/classes/_services_av_transport_service_.avtransportservice.html#becomecoordinatorofstandalonegroup
'device.AVTransportService.BecomeCoordinatorOfStandaloneGroup()'


Add a client backend for HttpURLConnection

It's not production grade.  It blocks.

It's still not great.  The body I/O blocks.  readInputStreamAsync and writeOutputStreamAsync shift, but don't shift back.  We could make a double shifting version of those, but not without copying in parts of JavaInputOutputStream.

Bump.  I dismissed @SystemFw's earlier approval due to substantial changes.

It's a bit of a shame since the main use for this is probably the repl, where you normally just import global, but it is what it is

Yeah, it made it slightly more awkward to use in the REPL, but it'll be a bit more consistent with our other java.io builders.
You know, we could have a repl constructor for this one that just blocks the current thread because lol nothing matters.


feat: double click on script window to open it

IMPORTANT: the current code assumes the path to all scripts is Game/Scripts/{scriptName}. Let me know if you want to be able to use sub folders, in which case more checks would be necessary.

right now by double clicking, Visual Studio Code is used instead of regular Visual Studio (at least for me), is there anyway you could ensure that regular Visual Studio is always used to open the scripts?

It should be using your system's default program to open a .cpp file. I think I should be able to force it to use visual studio 2019, and probably a checkbox in the configuration to choose between this forceful selection or system default. I'll take a look.

I think I should be able to force it to use visual studio 2019, and probably a checkbox in the configuration to choose between this forceful selection or system default. I'll take a look.

That would be great, but only if you have the time! If something else is more important please, don't mind this request and do as you need to do.

Is there a way to open the script with Visual Studio and not a Visual Studio Code?

Coming soon!


Refactor for nextjs

This was one of the hardest things I've done yet since picking up an interest in react apps. It was also entirely avoidable. Notes to file:

When i created the nextjs project originally, I assumed the project stucture should be similar to a standard react app. I made a src file under app, and under app as the root. Huge mistake. While this worked fine locally, as soon as i tried to deploy it I realized netlify would never be able to figure out my project strucutre. I tried half a day of workarounds before deciding I would need to refactor to a more typical nextjs project structure.
I moved pages, components, contexts, package, and anything else that should be in the root level from the app directory to a new root outside of app.

Oh and I never got the history page to work again, SSR is tough. Will need to start here in next pr.


Revisit our Typescript linting rules

[x] Are we not using typescript-eslint/recommended?  If not, try it
[ ] Ensure we're using no-unnecessary-type-assertion.  Should come from recommended above
[ ] Ensure we're using explicit-function-return-type.  Might need to tweak config if it's too aggressive, eg in lambdas
[ ] Other best practices we're missing?
[ ] Do we want to use / borrow from xo?
[ ] https://github.com/cursorless-dev/cursorless/pull/872 (closed due to not being super high priority, but still a good direction).  Can reopen to finish

Originally posted by @pokey in https://github.com/cursorless-dev/cursorless/pull/705#discussion_r886347414

explicit-function-return-type

Should we use explicit-module-boundary-types rather than explicit-function-return-type?

Unassigning myself because I realistically won't have time to enable more lint rules.
It'll be good to consider the lint rules that use type information, but we should consider how enabling type checking in linting affects the linter performance.


[STORM-3658] Avoid deadlock and race condition caused by shutdown hooks

What is the purpose of the change
Details explained in https://issues.apache.org/jira/browse/STORM-3658.
In short, the problem here is

there could be a race condition between registering the shutdown hooks and invoking shutdown hooks
There is a possible deadlock between a thread like executor thread that invokes shutdown hook (when it invokes Runtime.getRuntime().exit) and the shutdown hook/thread itself that tries to terminate threads like the executor thread.

How was the change tested

The deadlock and race condition can be reproduced with a WordCountTopology whose WordCountBolt simply throws a RuntimeException in prepare method.  Use it to validate the change. The race condition and deadlock is not happening.

The log below shows shutdown hook waited for 100ms and continue. This avoids the deadlock.
2020-06-29 20:33:44.237 o.a.s.e.ExecutorShutdown ShutdownHook-shutdownFunc [WARN] Thread Thread-15-count-executor[1, 1] is still alive (100 ms after interruption). Stop wait
ing for it.

The shutdown hooks are registered at very early stage (before any other threads are spawned). This is validated by looking at the logs and see Adding shutdown hook with kill in 3 secs message appears very early. And I added a bug in my test to print out thread dump right after registering the shutdown hook. The only alive threads at that point are

Log4j2-TF-6-Scheduled-1
Reference Handler
Signal Dispatcher
Finalizer
main

And also tested with the above topology and don't see race condition happen again (while it was very easy to happen before the code change)

thread name change can be validated by the log

2020-06-29 20:33:44.023 o.a.s.u.Utils ShutdownHook-sleepKill-3s [INFO] Halting after 3 seconds
....
2020-06-29 20:33:44.040 o.a.s.d.w.Worker ShutdownHook-shutdownFunc [INFO] Shutting down worker wc4-15-1593462538 513216e5-17e1-421f-809e-47cefd6eb136-<IP_ADDRESS> 6702
...

workerstate could be null if exception happens before workerstate object is initialized properly. This was tested by throwing an exception before workerstate construction is all done. And the modified shutdown method doesn't throw NPE.

Last commit re-organized shutdown method to avoid checking workerState!=null in many different places. Tested again.


HP Reverb profile warning in sample scenes

When opening the MRTK3 sample scenes (2022.3.17), this warning is logged. Profile comes from the Unity OpenXR package, our OpenXRPackageSettings should be updated to remove the deprecated controller profile

Tried in Unity 2022, also can't force the warning.

Closing as not reproducible


Add a few more usability flags and checks

-n or --namespace in create/delete
--static-ip in create

Also, error out if user forgets to provide a static ip (either by flag or in their spec).
Addresses #33 and #19
@nikhiljindal @madhusudancs @perotinus

This change is

Everything I have here are nits. Feel free to ignore them and merge.

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

app/kubemci/cmd/create.go, line 92 at r1 (raw file):

	// Name of the namespace for the ingress. Overrides the namespace in the IngressFilename (if present).
	// Optional.
	NameSpace string

s/NameSpace/Namespace/

app/kubemci/cmd/create.go, line 95 at r1 (raw file):

	// Static IP name for the ingress. Overrides the annotation in the IngressFilename (if present).
	// Optional.
	StaticIpName string

s/staticIpName/staticIPName/

app/kubemci/cmd/create.go, line 127 at r1 (raw file):

	cmd.Flags().StringVarP(&options.GCPProject, "gcp-project", "", options.GCPProject, "[required] name of the gcp project")
	cmd.Flags().BoolVarP(&options.ForceUpdate, "force", "f", options.ForceUpdate, "[optional] overwrite existing settings if they are different")
	cmd.Flags().StringVarP(&options.NameSpace, "namespace", "n", options.NameSpace, "[optional] namespace for the ingress")

I think it's worth clarifying the precedence, i.e. the fact that this flag value is used only as a fallback if ing.Namespace is unspecified.

app/kubemci/cmd/create.go, line 162 at r1 (raw file):

	// We require the specification of a static IP as an annotation.
	if ingAnnotations == nil || ingAnnotations.StaticIPName() == "" {
		return fmt.Errorf("Ingress spec must provide a Global Static IP through annotation of %v (alternatively, use --static-ip flag)", annotations.StaticIPNameKey)

Use %q instead of %v for quoting.

app/kubemci/cmd/delete.go, line 57 at r1 (raw file):

	// Name of the namespace for the ingress. Overrides the namespace in the IngressFilename (if present).
	// Optional.
	NameSpace string

s/NameSpace/Namespace/

Comments from Reviewable

Review status: 0 of 4 files reviewed at latest revision, 5 unresolved discussions.

app/kubemci/cmd/create.go, line 92 at r1 (raw file):
Previously, madhusudancs (Madhusudan.C.S) wrote…
s/NameSpace/Namespace/

Done.

app/kubemci/cmd/create.go, line 95 at r1 (raw file):
Previously, madhusudancs (Madhusudan.C.S) wrote…
s/staticIpName/staticIPName/

Done.

app/kubemci/cmd/create.go, line 127 at r1 (raw file):
Previously, madhusudancs (Madhusudan.C.S) wrote…
I think it's worth clarifying the precedence, i.e. the fact that this flag value is used only as a fallback if ing.Namespace is unspecified.

Done.

app/kubemci/cmd/create.go, line 162 at r1 (raw file):
Previously, madhusudancs (Madhusudan.C.S) wrote…
Use %q instead of %v for quoting.

Done.

app/kubemci/cmd/delete.go, line 57 at r1 (raw file):
Previously, madhusudancs (Madhusudan.C.S) wrote…
s/NameSpace/Namespace/

Done.

Comments from Reviewable

PTAL

As discussed, we want to make the behavior of both the flags --namespace and --static-ip consistent

 to me

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Talked to Brian who provided the back & forth history on --namespace. The current behavior that was settled on was that it should only be used for "defaulting". This is what I've implemented for --namespace and --static-ip.
PTAL.

Thanks for updating as per discussion with Brian.
Fwiw, I think it is fine to override the namespace based on flag value, if it conflicts with the namespace value in yaml. But, if you want to generate an error on conflict (as in this PR), then that is fine as well. Just ensure that both --namespace and --static-ip flags are consistent.
Most of my comments are to update the code comments and flag descriptions to match the code.

I'll address the code comments mismatches.
As for the conflicts, the behavior and implementation is consistent with kubectl -n (both static-ip and 'n' flags).

As for the conflicts, the behavior and implementation is consistent with kubectl -n (both static-ip and 'n' flags).

Yes overriding makes more sense to me, but if generating an error is what kubectl does then its better for us to do the same to be consistent (as you have in this PR). So thats good.

PTAL.

Reviewed 4 of 4 files at r2.
Review status: 2 of 4 files reviewed at latest revision, 2 unresolved discussions.

app/kubemci/cmd/create.go, line 90 at r3 (raw file):

	// value, then 'force' is a no-op.
	ForceUpdate bool
	// Name of the namespace for the ingress when none is provided (mismatch of option with spec causes an error).

Is it worth mentioning a namespace from the context? (I forget if that worked at all or not)

app/kubemci/cmd/create_test.go, line 131 at r2 (raw file):

	runFn := func() ([]string, map[string]kubeclient.Interface, error) {
		var ing v1beta1.Ingress
		if err := unmarshallAndApplyDefaults("../../../testdata/ingress.yaml", "", &ing); err != nil {

should we have some new test exercising namespace and static-ip?

Comments from Reviewable

Review status: 2 of 4 files reviewed at latest revision, 2 unresolved discussions.

app/kubemci/cmd/create.go, line 90 at r3 (raw file):
Previously, G-Harmon wrote…
Is it worth mentioning a namespace from the context? (I forget if that worked at all or not)

I dont think we pick namespace from kubeconfig context, so am fine with this as is.

Comments from Reviewable

/test all

/retest

/retest

/retest

✅ presubmit passed  :+1:

Woohooo thanks @BenTheElder!
I see that the tests ran and all passed but in the summary it says 0 failed / 0 succeeded. Expected?

That's expected, it consumes JUnit style XML files in the uploaded artifacts/ to look for individual test cases for that feature (eg with bazel build / test). Without them you should just look at the Result field (inferred from the scenario exit code) and the build log.
We should probably document this somewhere...

@csbell This will help me in my e2e tests PR so that I can run multiple tests in random namespaces.
Can you please resolve existing comments? :)

Review status: 2 of 4 files reviewed at latest revision, 2 unresolved discussions.

app/kubemci/cmd/create_test.go, line 131 at r2 (raw file):
Previously, G-Harmon wrote…
should we have some new test exercising namespace and static-ip?

Acknowledged. Will push this separately to unblock Nikhil for now.

Comments from Reviewable

Thanks @csbell


Maintanence: Update README.md to improve DX

Description
Updates the README.md files to fix some problems explained at issue https://github.com/woltapp/wolt_modal_sheet/issues/284
Related Issues
https://github.com/woltapp/wolt_modal_sheet/issues/284
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes tests for all changed/updated/fixed behaviors.
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

Thanks for this amazing work! Added some suggestions!


Add Live demo button to the docs and GitHub repo

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
As discussed on the call yesterday, we should add Live demo button on Toolpad docs and Toolpad GitHub repo.
Tracking these sources in GA would be helpful too.
Relates to: https://github.com/mui/mui-toolpad/issues/1041

A few options for the docs:
Demo as menu item
The potential con for this is that the menu collapses in smaller screen sizes. However, the demo (and Toolpad itself) are built primarily as a desktop experience and most visitors are on desktop anyway (~90%).
Aside styling as menu item

Plain menu item

Button styling as menu item
I haven't really seen this button styling in the docs? Only on the marketing site?

Demo as aside styling
This approach would need some copywriting. 😅

As for github, are we getting much value right now from a blank screenshot that links to the image itself?
Since we don't have a screenshot yet of an example app, perhaps we can get this image to essentially be a button?

For the docs page, I think the last option makes most sense to me as it seems most prominent and can't be missed.
Suggestion for GitHub README looks fine to me, but I doubt it will be possible in markdown. If not, we can do it whichever way possible. 1) Having 'Interactive Demo' as H2 that demo link in the content. 2) Image

Copy suggestion: Explore Toolpad in 1-click, no sign-up required. Word of caution: The purpose of this demo is to quickly experience app building in Toolpad. If you have a production use-case, please use the self-host version.
Great, for GitHub let's do it like that.

As discussed, the demo implies everything after "Word of caution", so I just truncated that. I also wonder if there is a better term than "one-click" since you actually need to click around a few different areas to actually explore Toolpad.

I also wonder if there is a better term than "one-click" since you actually need to click around a few different areas to actually explore Toolpad.

Ah, ok makes sense. One-click would be more applicable for a video etc.
Final copy: Check out Toolpad's interactive demo. No sign-up required!

Updated!

Do you intend for this banner to be visible on every page of the documentation, or just the overview?

Do you intend for this banner to be visible on every page of the documentation, or just the overview?

@prakhargupta1 and I discussed just having it on the overview page.


[camera/camera_nodelet_manager-8] process has died - How to run SR300 with ros-kinetic-librealsense and librealsense2 on 4.15 kernel? (Turtlebot2i)

Required Info

Camera Model
{ SR300}

Firmware Version
(<IP_ADDRESS>)

Operating System & Version
Linux (Ubuntu 16.04)

Kernel Version (Linux Only)
4.15.0-112-generic

Platform
NUC6CAYH

SDK Version
librealsense2-dkms-1.3.12 with ros-kinetic-librealsense wrapper (uvcvideo-1.1.1-3-realsense)

Language
ROS

Segment
Robot  (Turtlebot)

Issue Description

installed librealsense2-dkms and librealsense2-utils (https://github.com/IntelRealSense/librealsense/blob/master/doc/distribution_linux.md)
installed ros-kinetic-turtlebot* which installs ros-kinetic-librealsense and ros-kinetic-librealsense-camera as a dependency
While installing ros-kinetic-librealsense I was asked for patches for my kernel, skipped those
Ran turtlebot2i_bringup turtlebot2i_demo1.launch which, starts camera/camera_nodelet_manager and amongst others, includes a launchfile from realsense_camera package (sr300_nodelet_rgbd.launch), got the following warnings/errors:

[ WARN] [1595941674.520043333]: /camera_sr300/driver - Detected unvalidated firmware:
				-<PHONE_NUMBER>61's current camera firmware is <IP_ADDRESS>, Validated camera firmware is <IP_ADDRESS>

[ERROR] [1595941683.312106740]: /camera_sr300/driver - Error calling rs_wait_for_frames ( device:0x19b8100 ):
Timeout waiting for frames.

[camera/camera_nodelet_manager-8] process has died [pid 16751, exit code -6, cmd /opt/ros/kinetic/lib/nodelet/nodelet manager __name:=camera_nodelet_manager __log:=/home/turtlebot/.ros/log/52f6d9ba-d0d3-11ea-9897-548d5a4379cf/camera-camera_nodelet_manager-8.log].
log file: /home/turtlebot/.ros/log/52f6d9ba-d0d3-11ea-9897-548d5a4379cf/camera-camera_nodelet_manager-8*.log
[ERROR] [1595941686.584203443]: Kobuki : malformed sub-payload detected. [107][170][6B AA 55 4D 01 0F DC 60 ]

I know the ros-kinetic-librealsense driver is outdated and probably not working for my kernel. I have a laptop on which I can run the driver successfully with a 4.4.0 kernel. Also I already managed to get the new ros wrapper realsense2_camera working on 4.15 kernel. However, in realsense2_camera there are not the same launchfiles available as in realsense_camera (e.g. sr300_nodelet_rgbd.launch). That's why I can't replace it. Is there a possibility to get ros-kinetic-librealsense and ros-kinetic-librealsense-camera work with my kernel?
If not, what can I do to fix this?

Hi @joana-ha
rs_rgbd.launch should be functionally similar and maintained for modern Kernel versions.
realsense_camera is very outdated and there are no plans to backport 4.15 support into it. If using realsense2_camera is not possible, you should consider downgrading the Kernel version to 4.4

Hi @joana-ha,
Is there any specific reason to use kernel 4.15 in your system instead of kernel 4.4? If there is no such a reason, you should use kernel 4.4 in order to resolve the issue you're experiencing.
Please let us know if the comment provided by @dorodnic has helped to find an answer to your question
and if you need any further clarifications regarding this topic.
Thank you!


Git clone only downloads readme and license

While cloning, the repository doesn't download.

What operating system are you on?  Sometimes 'dot files' (files starting with a dot) get hidden by default by the OS.


[New Port Request] qt5-service

Library name: qt5-service
Library description: Add service capability to qt5
Source repository URL: https://github.com/Skycoder42/QtService
Project homepage (if different from the source repository): https://github.com/Skycoder42/QtService
Anything else that is useful to know when adding (such as optional features the library may have that should be included):

QtProject that can be build with qmake
Dependant of qt5

Thanks a lot

To build (as it's qmake) i have put this on linux (environment variable):
ENV QMAKE_LINK=clang++
ENV QMAKE_CXX=clang++
ENV QTDIR=/src/vcpkg/installed/x64-linux/lib
ENV QMAKESPEC=/src/vcpkg/installed/x64-linux/tools/qt5/mkspecs/linux-g++
ENV PATH=/src/vcpkg/installed/x64-linux/tools/qt5/bin/:$PATH
ENV QT_PLUGIN_PATH=/src/vcpkg/installed/x64-linux/plugins/
ENV QTTOOLDIR=/src/vcpkg/installed/x64-linux/bin
ENV QTLIBDIR=/src/vcpkg/installed/x64-linux/lib
ENV QT_SELECT=vcpkg

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now, consider making a pull request instead.


Add listing of works

It looks like this:

The thumbnail images were pasted into GitHub issues, and are hosted in GitHub (so we don't bloat the repository size).
Closes #80

@matthewsmawfield You mentioned that the aspect ratio might be better if it were different. Can you please suggest an aspect ratio, or pixel dimensions, that would be preferable? Thank you.

please could we try 4:3.3 width:height ratio.

Sure, I'll give that a try, using width of 290 pixels (from the Semantic UI example).
Deciding on these things is a sort of black magic to me ;)

New thumbnails:

@matthewsmawfield @vidonne This is ready for a second review. This is what it looks like with the updated thumbnails using 4:3.3 aspect ratio:


🐞 [Bug]: Report UI -Incorrect  RestQA version on the footer

Contact Details
No response
What happened?
While generating the report, we should display the current RestQA version however on the footer currently the version displayed is: 0.0.0-generated.
It should be the actual version.

Relevant log output
No response
🙏 Would you be willing to submit a PR?
Yes
Code of Conduct

[X] I agree to follow this project's Code of Conduct

A few entry points:

The UI: https://github.com/restqa/restqa/blob/master/packages/report-ui/src/layouts/partials/Footer.vue#L15
Where does the data come from: https://github.com/restqa/restqa/blob/master/packages/report-ui/src/layouts/partials/Footer.vue#L25-L27

But in fact, I think that the store does not contain this info:

https://github.com/restqa/restqa/blob/master/packages/report-ui/src/store/modules/restqa/getters.js
https://github.com/restqa/restqa/blob/master/packages/report-ui/src/store/modules/restqa/state.js

The strategy could be:

add a version property in the store (store/modules/restqa/state)
add a getter (store/modules/restqa/getters)
use the proper getter in Footer.vue

I believe the issue is coming from
https://github.com/restqa/restqa/blob/master/packages/cli/src/formatters/export-formatter.js#L129
The fact that we import the package.json this way: https://github.com/restqa/restqa/blob/master/packages/cli/src/formatters/export-formatter.js#L2
It means that during the build we are embedding the current package.json that has a placeholder version that will be replaced during the publication of the package (https://github.com/restqa/restqa/blob/master/.github/workflows/publish.yml#L19)
So the solution should be to have a function that will load and read the package.json on at the runtime. 😅


shared: Add alt.off function reference validation

Closes #229

@LeonMrBonnie what fait awaits this PR?

was too lazy to press merge


Audit/conversion changements

This audit specification made the code cleaner, but increases the gas consumption.

This audit specification makes the code cleaner, but increases the gas consumption.

Why are we adding starknet::Store if it worked fine without before ? I don't think just moving the traits implementations to another file increase the gas cost but most likely the starknet::Store and maybe the try_into. If we can save some gas here I'd rather lose some readability.

The issue is not coming from the starknet::Store part. Actually I don't even know how did it work without it since we need to derive store, in order to store in the storage of the contract, thus required for Currency, Pair, Checkpoint and EntryStorage. But I took the occasion to remove some useless starknet::Store derive for other structures.


Created Json File from reducer

Hi just created the Json file has requested on #95.
Check if it is as  you want it.

Close but It needs to be called and returned as an object within the reducer decks. Then test locally to ensure it works. Thanks

Nice job @Jpfonseca, it probably shouldn't be in the reducers folder either, doesn't really fit in with what a reducer is in the redux mentality. Might be worthwhile pulling it out into a separate data folder or something.

Don't Merge!!!
@papistan , @Gangezilla   I need help refactoring the dependencies
Right now the only mistake I get is :
Uncaught TypeError: Cannot read property 'map' of undefined     at DeckList.renderList (bundle.js:21842)     at DeckList.render (bundle.js:21878)     at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (bundle.js:7775)     at ReactCompositeComponentWrapper._renderValidatedComponent (bundle.js:7795)     at ReactCompositeComponentWrapper.wrapper [as _renderValidatedComponent] (bundle.js:1526)     at ReactCompositeComponentWrapper.mountComponent (bundle.js:7408)     at ReactCompositeComponentWrapper.wrapper [as mountComponent] (bundle.js:1526)     at Object.mountComponent (bundle.js:5718)     at ReactCompositeComponentWrapper.mountComponent (bundle.js:7413)     at ReactCompositeComponentWrapper.wrapper [as mountComponent] (bundle.js:1526)

@Jpfonseca hey mate, i have a feeling its failing at src/containers/deck_list.js, line 21. Looks like it's trying to map over all of the cards but it doesn't have them available to do so. I think you'll need to import the cards in from your JSON file and then map over it from there. Does that help? Let me know if I can help some more

@Jpfonseca I'm going to work on this issue now, so closing this pr


langchain_google_genai._common.GoogleGenerativeAIError: Error embedding content: 504 Deadline Exceeded

Description of the bug:
I have the following error when :
gemini_embeddings = GoogleGenerativeAIEmbeddings(model="models/embedding-001",google_api_key=gapiket) vector = gemini_embeddings.embed_query("hello, world!")
I've read that the API doesn't work depending on the country. Could this be the problem?
**Exception has occurred: GoogleGenerativeAIError

Error embedding content: 504 Deadline Exceeded
grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.DEADLINE_EXCEEDED
	details = "Deadline Exceeded"
	debug_error_string = "UNKNOWN:Error received from peer  {created_time:"2024-05-31T10:56:34.7789233+00:00", grpc_status:4, grpc_message:"Deadline Exceeded"}"
>

During handling of the above exception, another exception occurred:

google.api_core.exceptions.DeadlineExceeded: 504 Deadline Exceeded

The above exception was the direct cause of the following exception:

  File "C:\Users\drosset\Documents\intellicart\data\preprocess.py", line 28, in <module>
    vector = gemini_embeddings.embed_query("hello, world!")
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
langchain_google_genai._common.GoogleGenerativeAIError: Error embedding content: 504 Deadline Exceeded

Actual vs expected behavior:
No response
Any other information you'd like to share?
No response

i also face same error

Same error here:
`GoogleGenerativeAIError                   Traceback (most recent call last)
/usr/local/lib/python3.10/dist-packages/langchain_google_genai/embeddings.py in embed_documents(self, texts, task_type, titles, output_dimensionality)
148             )
149         except Exception as e:
--> 150             raise GoogleGenerativeAIError(f"Error embedding content: {e}") from e
151         return [e.values for e in result.embeddings]
152
GoogleGenerativeAIError: Error embedding content: 504 Deadline Exceeded`

I was facing the same issue using langchain-google-genai.
The solution was using langchain-google-genai==1.0.3 version.
Here's the full requirements I'm using:
google-ai-generativelanguage==0.6.2
google-api-core==2.19.0
google-api-python-client==2.128.0
google-auth==2.29.0
google-auth-httplib2==0.2.0
google-generativeai==0.5.2
googleapis-common-protos==1.63.0
langchain==0.1.17
langchain-community==0.0.37
langchain-core==0.1.52
langchain-google-genai==1.0.3
langchain-pinecone==0.1.0
langchain-text-splitters==0.0.1

Yes, you are correct. Downgrading langchain-google-genai works for me now

I was facing the same issue using langchain-google-genai. The solution was using langchain-google-genai==1.0.3 version.
Here's the full requirements I'm using:
google-ai-generativelanguage==0.6.2
google-api-core==2.19.0
google-api-python-client==2.128.0
google-auth==2.29.0
google-auth-httplib2==0.2.0
google-generativeai==0.5.2
googleapis-common-protos==1.63.0
langchain==0.1.17
langchain-community==0.0.37
langchain-core==0.1.52
langchain-google-genai==1.0.3
langchain-pinecone==0.1.0
langchain-text-splitters==0.0.1

Thank @bruna-calistrate !! donwgrading it works.
Maybe someone could have conflicts between langchain-google-gena and langchain-openai.
My requirements.txt had:
google-ai-generativelanguage==0.6.4
google-api-core==2.19.0
google-api-python-client==2.131.0
google-auth==2.29.0
google-auth-httplib2==0.2.0
google-generativeai==0.5.4
googleapis-common-protos==1.63.0
langchain==0.2.1
langchain-core==0.2.3
langchain-google-genai==1.0.3
langchain-openai==0.1.8
langchain-text-splitters==0.2.0


Provide the overflowWidget as a builder

I have an use case where I need to show 2 lines of elements and then, if needed, a chip with "+N" (when N is the number of the remaining items).
It would be nice to have a constructor that takes a parameter overflowBuilder: (int remaining) => SomeWidget(remaining).

I have same case
Is there any solution?
@elileo1

@mattia-venturini
Did you find a solution?

@yahyaMajdAlamaal unfortunately no.
Later I find out that in my use case the ExtendedWrap had some important performance issues (maybe I should file another issue for that) so I replaced it with a custom solution.
If someone is interested in my solution:
I needed to display 2 lines of chips, each one containing a different text, so in the build function I compute how many chip I can display using the current constraints and a TextPainter to estimate every chip's size.
Then I place the sublist of children in a regular Wrap, with some other logic to add the overflowWidget and remove the last child if needed.
As I sayd this is NOT a generic approach.

you can show your code and i will try it

can callback the  number of hidden widget, but the overflow widget can't dynamic change, If change it, have to recalculate the width of each widget, which will lead to an infinite loop calculation


Add destructors.

Fix issue #382.
Add a destructor for the application/design's variables.

This also needs a test to verify it works and to ensure we maintain code coverage.


run tests on container infrastructure

should be enough to install sqlite3 from Ubuntu precise (12.04)

BTW, there is a neat feat to use dmd, gdc, and ldc to refer to the latest version of each compiler.

Thanks. The problem is that old Ubuntu releases have a version of sqlite (< 3.8.7) that misses some functions I happen to use in the unit tests.

Actually it's more than that. The sqlite version coming with Ubuntu precise lack the sqlite3_xxx64 functions.

Actually it's more than that. The sqlite version coming with Ubuntu precise lack the sqlite3_xxx64 functions.

Why are they needed? Makes it more difficult to deploy anything using d2sqlite3. Could they be turned into optional dependencies?
Let's keep the Travis config as is for now.

They aren't absolutely needed, but they're more up to date, and some people apparently rely on them. I could probably add some version blocks to account for old versions of Sqlite. But the fact is that Sqlite is so easy to download, compile and link into any project, I considered it wasn't worth maintaining backward compatibility. Moreover, recent versions of Sqlite have many improvements feature-wise and performance-wise...
Yet, I wish I could add the possibility to ship Sqlite with the library, ideally compiled from source. I still need to find out how to use dub for this, and how to do it on Windows. Maybe I should have a look at how it's done in Phobos for zlib.


Rename fosscord in settings window

Is your feature request related to a problem? Please describe.
Fosscord rebranded as SpaceBar. So it would be nice if the update was reflected in the "Discord Instance" section.
Describe the solution you'd like
Rename the entry.

perhaps with a note that indicates it's former name - i.e "SpaceBar (formerly Fosscord)"

I won't rename it for v4 for now, I dunno what about v5 as god knows how I'm going to handle FossCord SpaceBar instance switching given I had some plans to re-design app with BrowserView-s and therefore make UI less native and more Discord-fitting – BrowserView-s can be transparent and displayed on-top of the current site, so this makes it possible to visually inject some stuff on the webpage without actually making it accessible to Discord.


Reverting TFBackend import & TheWalrus rc in docs requirements

Context:
With #378, the import for the TFBackend was changed. This unfortunately caused TF to be a requirement for StraberryFields.
As a further item, for the requirements of the docs, a wheel is specified for TheWalrus. As instead, the latest release candidate could help out to choose the correct wheel,
Description of the Change:

Reverts changes to the TF import
Uses the release candidate of TheWalrus for the docs

Benefits:
TF doesn't have to be a requirement for SF
Possible Drawbacks:
N/A
Related GitHub Issues:
N/A

The issue from CodeFactor is related to the TFBackend import within the if statement


MITgcmutil update

What changes does this PR introduce?
I have updated the python package MITgcmutils including new modules
What is the current behaviour?
The current version lacks of basic python functions to open and manipulate binary output from MITgcm
What is the new behaviour
(if this is a feature change)?
The updated library has converted MATLAB functions such gen_blanklist, readbin and writebin. It also includes all the density profiles in MITgcm, and a function to convert depth to dbar following MITgcm. Finally, there are some new functions in utils.py for tile visualization and/or debugging.
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
The documentation needs a slight update to include the new functions and the changes in the old ones
Other information:
I wrote a symbolic version of 0.5. I let the developers decide the most suitable version number
Suggested addition to tag-index
(To avoid unnecessary merge conflicts, please don't update tag-index. One of the admins will do that when merging your pull request.)

When I include MITgcmutils.utils in doc/utilities/utilities.rst I get error messages like:
/Users/mlosch/MITgcm/review/utils/python/MITgcmutils/MITgcmutils/utils.py:docstring of MITgcmutils.utils.tilecmap:30: CRITICAL: Unexpected section title.

Test
----

This is from the doc in the python function and seems to be triggered by the preceding
    Example
    -------
    >>> [fig]=tilemap(bathy, 51, 51,)
    >>> [fig]=tilemap(bathy, 51, 51,58,5)

When I move Test before Example the errors go away. I have no idea how to fix this.

My previous (first) comment got scrapped, so I repeat what I can remember of it: @dramauh Thanks for this contribution. I took the liberty to make small changes to make the doc-work. Not sure if I did it correctly ( @jahn ?). Please check if it works for you and please add missing documentation. When I tried, I ran into the problem described above.

@mjlosch is fine, I should have tried to compile the document before commiting. That error catched me by surprised  Thank for correcting the problem

I fixed a small flag in the density.py. I also corrected documentation adding utils and tests. I did not get any error @mjlosch, and I wrote exactly the same code that you use..very strange

Thanks, I can now also compile the readthedocs without error messages. It may have to do with the infamous DOS eol characters (^M) that I saw in a few places (e.g., the utils.py file is a DOS file, something you may want to change).

@dramauh I am sorry, I was wrong. The problem described above remains. The docstring sections in utils.gen_blanklist and utils.timecmap starting with "Test" lead to the above error message. I don't know what this is.

The docs were not rendering correctly for both MacOS and Linux (my MacOS implementation gave a warning, see above, the Linux version didn't). Apparently, only one block of code is allowed.

I added @mjlosch suggestions in conversion and test. Now, you can add latitude to the function pfromz. I also add path to locate the binaries that are used in the test. I am  having a error rendering the docs because of new paths. @mjlosch do you know how to fix this?

@jahn when you find the time, it would be great if you have a quick look at this. I think this is good to merge.

I removed the bathy file and included a portion in the test_utils.py to save some space. I wonder if the code looks untidy because of this. @mjlosch may you take a look, please？ I can always change the file back and add a separate data file (~20kb).

I am fine with that, no more large bathymetry file! I would probably for the plots of timecmap use default figure size and fonts. On my small screen I cannot see the entire figure without resizing.

I deleted the figure and font size properties and fixed a few things

I'm taking a look at this at the moment. I'll have a review by the end of the week. Updates soon.

@jahn and I went through the file density.py and simplified a few things. The check for dimensions relies on python's ability to broadcast the shapes of different fields and avoids the Matlab-methods inherited from the seawater library. @dramauh Please check if you can live with that.
I also have a suggestion for the "tests": as they are not unit or regression tests, but rather a useful illustration of gen_blanklist and tilecmap, I suggest to change the corresponding names to something like "examples".

I have just taken a a look to it. I think it is much cleaner now. Thanks for your help. About the tests, I have not preference. I can change the name of those functions. The aim of that folder was to collect all test and/or examples as the library becomes bigger

I think renaming the directory "tests" to "examples" would be good and maybe even rename test_utils.py. @dramauh please go ahead an do so.
I am not a good resource for giving advice on how to design automated tests. I just learned something about that yesterday (thanks to @jahn).

I did some more cleanup.  utils.py still needs a bit of attention.
Another issue is that before this PR, one could import MITgcmutils without having matplotlib installed, as long as one didn't explicitly import cs or llc.  Now everything is imported automatically and plotting and non-plotting capabilities are more mixed up.

I think i pressed something wrong. it says @dramauh
Merge branch 'mitgcmutils_update' of https://github.com/dramauh/MITgcm. Can someone delete that part, please?

I can force push a change to remove that commit from the branch but it will cause havoc for you. You would need to delete your local copy of the branch and download this copy in its place. I don't think it is worth it. Instead, we can squash merge and that commit won't matter.
I'm happy with this PR now.
@jahn - are the additional dependencies a deal breaker for you?

I changed the Martin attributions in the comments. Also, I was not sure who and when wrote TEOS10 in MITgcm, so I did not write anything. If anyone knows who and when did it, I can update it. May you @edoddridge take a look, please? I can still improve the comments.

@dramauh circling back here to try and get this merged finally
I show two issues:

the thread says @edoddridge has requested changes that haven't been addressed, but going through I think you might have already done so (?) Can you go through the thread and resolve all the conversations that show as open?
Can you see if you can resolve the conflicts? Or advise us if you need help here?

@edoddridge can you do a quick check that you are happy in this final form?
Thanks!

Hi,
I corrected them. I requested another review time ago

Sorry for the delay. I missed the original notification. There are some conflicts to resolve, but I'm happy with the changes.

thanks @edoddridge
@dramauh @mjlosch can you resolve the open conversations (either click resolve if completed and/or verify the changes were made) and we can finally merge this PR? thx

I resolved the remaining conflicts, and conversations.
@dramauh It would be cool if you could quickly check that I didn't break anything.

Hi,
I have just taken a look to the changes, there should not be a problem. I see there is a compilation error in the latex, but it is not related to the python package

That's odd, I can compile the latexpdf target without problems.
And yes, the error message of the CI:
! Extra }, or forgotten \endgroup.
\sbox  ...box {\color@setgroup #2\color@endgroup }

l.1998 ...ion}{note}{Pressure method calling tree}

!  ==> Fatal error occurred, no output PDF file produced!

does not point to any python related stuff. @jahn, @jm-c any idea?

Looks like the latex in the github runner has a problem with admonitions now, master has the same problem.  I could generate the pdf for this PR just fine, so I guess we can ignore it.

Looks like this has been resolved. I've rerun the failed test.

It seems to me that this PR is ready to be merged, @dramauh am I correct ? If so and if no one wants to add things here I could merge it soon after.

Reading more carefully the past comments, It's seems it's ready to be merged. Will do that later today.


[FEATURE]: incremental fetch of stream output.

Thanks for the plugin as always @rcarriga !
I was looking into the possibility of fetching the output of stdout while the process is running, and I think I was able to come up with a relatively good solution.
I'd like to hear your opinion on this and possibly add this feature.
Proposal

It is as simple as changing the condition inside streams.lua as follows.
      -- not read_err
      -- -- n is specified, wait until buffer has n length but no need to wait for complete.set()
      -- -- n is not specified, then wait until complete.set()
      while not read_err and not complete.is_set() and (not n or #buffer < n) do

Example Usage
Here is an example code that uses this feature and as you can see in # outputs, the elapsed ms value when using stdout.read(100) changes incrementally opposed to when no n is provided stdout.read().
Please go to the bottom to see explanation of each function.
local nio = require("nio")

local function make_proc()
  local proc = nio.process.run({
    cmd = "ping",
    args = { "google.com" },
  })
  assert(proc, "proc is nil")
  return proc
end

local function test_no_read_n()
  local proc = make_proc()
  local start = vim.loop.hrtime()
  nio.run(function()
    nio.sleep(5 * 1000) -- wait 5 sec and kill ping
    proc.signal(15)
  end)
  local out = proc.stdout.read()
  local elapsed = (vim.loop.hrtime() - start) / 1000 / 1000
  vim.print(string.format([[[%8.2f ms] '%s']], elapsed, out))
end

local function test_hundred_bytes()
  local proc = make_proc()
  local start = vim.loop.hrtime()

  for i = 0, 9 do
    local out = proc.stdout.read(100)
    local elapsed = (vim.loop.hrtime() - start) / 1000 / 1000
    vim.print(string.format([[[%8.2f ms, i: %s] '%s']], elapsed, i, out))
  end
  proc.signal(15)
end

local function test_print_each_newline()
  local proc = make_proc()
  local start = vim.loop.hrtime()

  local buffer = ""
  local line_count = 0
  local iter_count = 0
  while true do
    local out = proc.stdout.read(100)
    if not out then
      break
    end
    iter_count = iter_count + 1
    buffer = buffer .. out
    while true do
      local cr = string.find(buffer, "\n")
      if not cr then
        break
      end
      line_count = line_count + 1
      local elapsed = (vim.loop.hrtime() - start) / 1000 / 1000
      local msg = [[[%8.2f ms, line: %s, iter: %s] '%s']]
      vim.print(string.format(msg, elapsed, line_count, iter_count, buffer:sub(1, cr - 1)))
      buffer = buffer:sub(cr + 1)
    end
    if line_count >= 10 then
      break
    end
  end
  proc.signal(15)
end

nio.run(function()
  vim.print("====== test_no_read_n ======")
  -- `stdout.read()` (with no n) will wait until the process is finished.
  -- So, we don't see any outputs until ping is done (5 sec).
  test_no_read_n()
  vim.print("====== test_hundred_bytes ======")
  -- `stdout.read(100)` will fetch 100 bytes from the buffer.
  -- This will output stdout **as soon as** there are more than 100 bytes from the last call.
  test_hundred_bytes()
  vim.print("====== test_print_each_newline ======")
  -- Same as above but the function has mechanism to cut the buffer at "\n" using string.find.
  -- This is meant to be implemented on the user side, but maybe it'd be nice if
  -- nio could add this functionality as it is relatively simple. Perhaps...
  -- `stdout.read(n: integer?, until: string?)` where
  -- -- `stdout.read()`: wait and flush all
  -- -- `stdout.read(100)`: flush 100 bytes at a time
  -- -- `stdout.read(100, "\n")`: flush every 100 bytes but only return at every "\n"
  -- -- `stdout.read(nil, "\n")`: ERROR, user must provide `n` as the best guess of the line length (which will vary between applications) for performance reasons.
  test_print_each_newline()
end)

Output
====== test_no_read_n ======
[ 4980.84 ms] 'PING google.com (xxx.xxx.xxx.xxx) 56(84) bytes of data.
64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=1 ttl=117 time=2.45 ms
64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=2 ttl=117 time=2.36 ms
64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=3 ttl=117 time=2.56 ms
64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=4 ttl=117 time=2.50 ms
64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=5 ttl=117 time=2.46 ms
'
====== test_hundred_bytes ======
[   37.84 ms, i: 0] 'PING google.com (xxx.xxx.xxx.xxx) 56(84) bytes of data.\n64 bytes from _____________________.net (xxx.'
[ 1009.14 ms, i: 1] 'xxx.xxx.xxx): icmp_seq=1 ttl=117 time=2.40 ms\n64 bytes from _____________________.net (xxx.xxx.xxx.xxx'
[ 2011.21 ms, i: 2] '): icmp_seq=2 ttl=117 time=2.47 ms\n64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_se'
[ 3013.33 ms, i: 3] 'q=3 ttl=117 time=2.51 ms\n64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=4 ttl=11'
[ 4014.43 ms, i: 4] '7 time=2.48 ms\n64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=5 ttl=117 time=2.4'
[ 6018.45 ms, i: 5] '4 ms\n64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=6 ttl=117 time=2.46 ms\n64 by'
[ 7020.63 ms, i: 6] 'tes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=7 ttl=117 time=2.51 ms\n64 bytes from _'
[ 8021.74 ms, i: 7] '____________________.net (xxx.xxx.xxx.xxx): icmp_seq=8 ttl=117 time=2.52 ms\n64 bytes from __________'
[ 9022.75 ms, i: 8] '_________.net (xxx.xxx.xxx.xxx): icmp_seq=9 ttl=117 time=2.46 ms\n64 bytes from _____________________'
[10024.73 ms, i: 9] '.net (xxx.xxx.xxx.xxx): icmp_seq=10 ttl=117 time=2.45 ms\n64 bytes from _____________________.net (xxx'
====== test_print_each_newline ======
[    7.11 ms, line: 1, iter: 1] 'PING google.com (xxx.xxx.xxx.xxx) 56(84) bytes of data.'
[ 1008.22 ms, line: 2, iter: 2] '64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=1 ttl=117 time=2.36 ms'
[ 2009.54 ms, line: 3, iter: 3] '64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=2 ttl=117 time=2.44 ms'
[ 3010.35 ms, line: 4, iter: 4] '64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=3 ttl=117 time=2.55 ms'
[ 4012.43 ms, line: 5, iter: 5] '64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=4 ttl=117 time=2.47 ms'
[ 6016.71 ms, line: 6, iter: 6] '64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=5 ttl=117 time=2.53 ms'
[ 6016.74 ms, line: 7, iter: 6] '64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=6 ttl=117 time=2.43 ms'
[ 7017.63 ms, line: 8, iter: 7] '64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=7 ttl=117 time=2.54 ms'
[ 8019.71 ms, line: 9, iter: 8] '64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=8 ttl=117 time=2.44 ms'
[ 9021.83 ms, line: 10, iter: 9] '64 bytes from _____________________.net (xxx.xxx.xxx.xxx): icmp_seq=9 ttl=117 time=2.50 ms'

It was already working... Looks like I misinterpreted something.


Additional Tests

Current coverage is 52.68% (diff: 100%)

Merging #87 into master will not change coverage

@@             master        #87   diff @@
==========================================
  Files            19         19
  Lines          2885       2885
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1520       1520
  Misses         1264       1264
  Partials        101        101

Powered by Codecov. Last update 089e4fa...d62ad00


Update percent loading

Hi,
Thanks for good library about media player, i used it for some my project.
I have a idea that you can update percent loading, that allow user know when player load and may be play.

Thank you for your support and will consider your great suggestions. For the next version to achieve.

1.5.7 percent loading

Thank for good feature


Remove version: Pidgin.Pidgin version 2.14.12

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/pidgin/files/Pidgin/2.14.12/pidgin-2.14.12-offline.exe/download
OK
(Automated message - build 923)

Close with reason: Package still available.;


[Feature] Add initial macOS support for compiling

Related issue:
#21
Description
This PR add initial Darwin platform support for compiling.
Many feature is missing and it does not mean we support macOS on this PR.
TODO & Future Plan

[ ] Add name getter in Platform protocol as described in Design.md
[ ] Extract the same logic in Linux and Darwin to SwiftlyCore via extension Platform
[ ] Update Darwin implementation to better respect the OS - toolchain install path / file extension / Xcode integration

Hi @Kyle-Ye, thanks for taking the time to submit this PR! The macOS implementation is likely to look a bit different than the Linux one though, so I think we'll want to hold off on duplicating too much code between the platforms. Also, I think we'll want to wait on advertising macOS support, even in just Package.swift, until we begin the actual implementation, since having a placeholder risks a bit of confusion if people don't know the status of the project currently. So given that, I'm going to close this PR for now, since I think we'll want to do this at the same time as we begin implementing the actual logic.


bug  when 2 clients start 2 different match at the same time

Describe the bug
After updating mirror and having to replace networkmatchchecker with networkmatch i did some test, everything was ok expect in this scenario: starting 2 separate match at the same time
info
first i tested with 53.0.0 from asset store and then the github repository LTS version which i think is newer.  so my current version is github mirror LTS.
tested on 2 different pc
unity 2019.4.31
windows 10
i used MatcInterestManagement   and Telepathy transport on networkManager, and networkmatch on objects
reproducing the error:
have a dedicated server and 2 clients on the same pc(only the clients needs to be on the same pc for the error to happen(i think)). also i use additive scenes in the server and one scene is opened for each match and then each client must start a match at the same time, the one which is a little later gets this error(only in that client and not server)
these 2 errors are showen once for each net object ( with NetworkIdentity and NetworkMatch) present in the loaded scene except player object, (also i load scene by my code in additive mode):
Spawn scene object not found for 410EE8D5ECE59B18. Make sure that client and server use exactly the same project. This only happens if the hierarchy gets out of sync. UnityEngine.Debug:LogError (object) Mirror.NetworkClient:SpawnSceneObject (Mirror.SpawnMessage) (at Assets/Mirror/Runtime/NetworkClient.cs:1088) Mirror.NetworkClient:FindOrSpawnObject (Mirror.SpawnMessage,Mirror.NetworkIdentity&) (at Assets/Mirror/Runtime/NetworkClient.cs:1038) Mirror.NetworkClient:OnSpawn (Mirror.SpawnMessage) (at Assets/Mirror/Runtime/NetworkClient.cs:1255) Mirror.NetworkClient/<>c__DisplayClass46_01<Mirror.SpawnMessage>:g__HandlerWrapped|0 (Mirror.NetworkConnection,Mirror.SpawnMessage) (at Assets/Mirror/Runtime/NetworkClient.cs:450)
Mirror.MessagePacking/<>c__DisplayClass6_02<Mirror.SpawnMessage, Mirror.NetworkConnection>:<WrapHandler>b__0 (Mirror.NetworkConnection,Mirror.NetworkReader,int) (at Assets/Mirror/Runtime/MessagePacking.cs:118) Mirror.NetworkClient:UnpackAndInvoke (Mirror.NetworkReader,int) (at Assets/Mirror/Runtime/NetworkClient.cs:273) Mirror.NetworkClient:OnTransportData (System.ArraySegment1,int) (at Assets/Mirror/Runtime/NetworkClient.cs:341)
Mirror.TelepathyTransport:b__18_1 (System.ArraySegment1<byte>) (at Assets/Mirror/Runtime/Transport/Telepathy/TelepathyTransport.cs:96) Telepathy.Client:Tick (int,System.Func1) (at Assets/Mirror/Runtime/Transport/Telepathy/Telepathy/Client.cs:343)
Mirror.TelepathyTransport:ClientEarlyUpdate () (at Assets/Mirror/Runtime/Transport/Telepathy/TelepathyTransport.cs:140)
Mirror.NetworkClient:NetworkEarlyUpdate () (at Assets/Mirror/Runtime/NetworkClient.cs:1315)
Mirror.NetworkLoop:NetworkEarlyUpdate () (at Assets/Mirror/Runtime/NetworkLoop.cs:186)
Could not spawn assetId=72e09229-3200-1fd4-6908-0aee5e67fd5b scene=410EE8D5ECE59B18 netId=971
UnityEngine.Debug:LogError (object)
Mirror.NetworkClient:FindOrSpawnObject (Mirror.SpawnMessage,Mirror.NetworkIdentity&) (at Assets/Mirror/Runtime/NetworkClient.cs:1042)
Mirror.NetworkClient:OnSpawn (Mirror.SpawnMessage) (at Assets/Mirror/Runtime/NetworkClient.cs:1255)
Mirror.NetworkClient/<>c__DisplayClass46_01<Mirror.SpawnMessage>:<RegisterHandler>g__HandlerWrapped|0 (Mirror.NetworkConnection,Mirror.SpawnMessage) (at Assets/Mirror/Runtime/NetworkClient.cs:450) Mirror.MessagePacking/<>c__DisplayClass6_02<Mirror.SpawnMessage, Mirror.NetworkConnection>:b__0 (Mirror.NetworkConnection,Mirror.NetworkReader,int) (at Assets/Mirror/Runtime/MessagePacking.cs:118)
Mirror.NetworkClient:UnpackAndInvoke (Mirror.NetworkReader,int) (at Assets/Mirror/Runtime/NetworkClient.cs:273)
Mirror.NetworkClient:OnTransportData (System.ArraySegment1<byte>,int) (at Assets/Mirror/Runtime/NetworkClient.cs:341) Mirror.TelepathyTransport:<CreateClient>b__18_1 (System.ArraySegment1) (at Assets/Mirror/Runtime/Transport/Telepathy/TelepathyTransport.cs:96)
Telepathy.Client:Tick (int,System.Func1<bool>) (at Assets/Mirror/Runtime/Transport/Telepathy/Telepathy/Client.cs:343) Mirror.TelepathyTransport:ClientEarlyUpdate () (at Assets/Mirror/Runtime/Transport/Telepathy/TelepathyTransport.cs:140) Mirror.NetworkClient:NetworkEarlyUpdate () (at Assets/Mirror/Runtime/NetworkClient.cs:1315) Mirror.NetworkLoop:NetworkEarlyUpdate () (at Assets/Mirror/Runtime/NetworkLoop.cs:186)
=======
Important
I tracked the problem and i think the isses is internal mirror issue, at this line:
NetworkManager/StartClient() /NetworkClient.Connect(networkAddress); /RegisterSystemHandlers at line:
RegisterHandler<SpawnMessage>(OnSpawn);
appearently (OnSpawn) is fired at the wrong time, when the first client scenes are loaded ,the line  RegisterHandler<SpawnMessage>(OnSpawn);  fires for both clients. but im not super sure.
i have been using my code for months and this issues only happend after updated mirror and used networkmatch
I Worked on this issue for maybe 12 hours and im 99% sure its a mirror bug
P.S : the error always happens when both clients are in the same pc, but not sure if happens otherwise

Setup and ran the Multiple Matches example with a server build and 4 clients (2 starting matches, the other 2 joining them) with no errors.
If you're doing multiple additive scenes for each match instance, you should be using Scene Interest Management instead of Match Interest Management.  See Multiple Additive Scenes example included in Mirror.  Join our Discord for support.

thank you for your answer, but i handle the physics my self so no need to
use Scene Interest Management, but regardless, i did test with Scene
Interest Management aswell and the problem persisted

Setup and ran the Multiple Matches example with a server build and 4 clients (2 starting matches, the other 2 joining them) with no errors.
If you're doing multiple additive scenes for each match instance, you should be using Scene Interest Management instead of Match Interest Management. See Multiple Additive Scenes example included in Mirror. Join our Discord for support.

im gonna do some more test with Scene Interest Management and get back to you

Setup and ran the Multiple Matches example with a server build and 4 clients (2 starting matches, the other 2 joining them) with no errors.
If you're doing multiple additive scenes for each match instance, you should be using Scene Interest Management instead of Match Interest Management. See Multiple Additive Scenes example included in Mirror. Join our Discord for support.

thank you for great support, you guys are the best.  👍
the problem is resolved, as you said, i should have used "Scene Interest Management", but the first time i used it i also used "NetworkMatch" component on all my objects, and that caused the problem, now that i removed those it works beautifully.
thank you again.  :)


Object Markers Permanently Showing Even With the Plugin Disabled?

Type
Incorrect behavior
Operating System
Windows
OS Version
Windows 10
Bug description
I marked the latter bottom and top by shift-clicking > mark object.
When I went to remove the marker, the option was no longer present. I disabled the Plugin but the marker still shows and I do not have an option to unmark it now?
Screenshots or videos

RuneLite version
<IP_ADDRESS>
Logs
No response

Does this behavior happen while running in safe mode?
To open in safe mode on Windows: In Command Prompt, run:
"%localappdata%\runelite\runelite.exe" --safe-mode

Or on Mac: In Terminal, run:
/Applications/RuneLite.app/Contents/MacOS/RuneLite --safe-mode

Does this behavior happen while running in safe mode?
To open in safe mode on Windows: In Command Prompt, run:
"%localappdata%\runelite\runelite.exe" --safe-mode

Or on Mac: In Terminal, run:
/Applications/RuneLite.app/Contents/MacOS/RuneLite --safe-mode

Thanks for the quick response. This behavior does not happen while in safe mode. I do not see the objects marked in this mode.

Then you have some hub plugin installed which is marking those objects. I recommend disabling and uninstalling hub plugins which you might have until this behavior goes away.


I started off wanting to change the color of rulerz's ruler lines, which entailed adding a stylesheet rule. I then realised we could potentially set the width there too, but that was blocked by the "width" config overwriting it. So I forked and removed the width config. It seems to me that using the stylesheet is the Atom-y way of doing this kind of thing.
Then I realised the "enable" config option was surplus to requirement since atom has its own enable/disable in the package manager now. So I kinda deleted all the config subscriptions and replaced them with a note in the README.

Deleted code is the best kind of code; I'm only jealous I didn't get to do it ;-)
In truth, we got fatigued tracking all the API changes leading up to the 1.0 and we started ignoring them as long as the plugin didn't completely blow up, so this is a very welcome PR. I'm looking at it now.


Looking for links backward doesn't work properly when you are on a link

After some research, the search method of vimscript does not provide an easy way to fix this. A solution would be to manually search for the link under the cursor and go to the 1st character before starting the search.
It's a lot of additional code and efforts for a problem that is so minor. So, it won't be fixed.


Error messages should be generated for statements within a for loop not in FLOWR order.

Given:
for $foo in $bar
    order by $foo
    let $x := $foo/bar
    return $x

The order by line is not flagged with an error, even though the order should be let, order by, where then return.

Hey
It is not flagged as an error as it is valid according to all standards.
Please have a look at the grammar of the FLWOR expressions (here)[http://www.w3.org/TR/xquery-30/#id-flwor-expressions]. It explicitly says that after initial clause of for/let there is unlimited number of for/let/where/group by/order by/count clauses without any particular order.
Please also run expression like
for $foo in (<c><bar>c</bar></c>, <bar>b</bar>, <bar>a</bar>)
order by $foo
let $x := $foo/bar
return $x

and see if it works. It works fine in Saxon/Zorba/BaseX and probably some other (I didn't check all of the implementations).
If it doesn't that it probably means that your implementation only supports FLWOR expressions from (XQuery 1.0)[http://www.w3.org/TR/xquery/#id-flwor-expressions] whereas the plugin is specifically targeted at version 3.0 of XQuery. In which case you should probably raise a feature request for the implementation that you are using :)


upload_app_privacy_details_to_app_store not working

New Issue Checklist

[X] Updated fastlane to the latest version
[X] I read the Contribution Guidelines
[X] I read docs.fastlane.tools
[X] I searched for existing GitHub issues

Issue Description
I try to use the CLI command as given in the documentation (I am using 2.170.0), but I cannot get it to work.
I login with a user that is in several development teams.
If I provide a teamName (itc_team_name I suppose), it tells me it cannot find the app with that bundleId in my account.

I tried the questions route with an bundleId and without teamName - it generated the JSON File, but crashed during upload - it takes really long to display the error message
I tried just the upload with the before generated file for the same app and it also crashes with the same message
I tried passing over all parameters to CLI, using a bundleId of an app in a linked, second development team the same user has admin access to, and it says:
[!] Could not find app with bundle identifier 'com.appdinx.xxxxxxxxxx' on account<EMAIL_ADDRESS>
Command executed
upload_app_privacy_details_to_app_store
Complete output when running fastlane, including the stack trace and command used
[19:34:48]: Preparing to upload App Data Usage
[19:34:49]: Setting EMAIL_ADDRESS and APP_FUNCTIONALITY to DATA_LINKED_TO_YOU
Looking for related GitHub issues on fastlane/fastlane...
➡  undefined method `get_app_info_localizations' for nil
https://github.com/fastlane/fastlane/issues/17208 [open] 13 💬
2 days ago
➡  set_changelog failing to update and ends in error: handle_response': [!] undefined method `status' for nil:NilClass
https://github.com/fastlane/fastlane/issues/17071 [open] 5 💬
2 weeks ago
➡  Fastlane match development -> undefined method `com' for nil:NilClass\e[0m (NoMethodError)
https://github.com/fastlane/fastlane/issues/17320 [open] 5 💬
4 weeks ago
and 286 more at: https://github.com/fastlane/fastlane/search?q=undefined method `status' for nil&type=Issues&utf8=✓
🔗  You can ⌘ + double-click on links to open them directly in your browser.
Traceback (most recent call last):
31: from /Users/administrator/.rbenv/versions/2.6.3/bin/fastlane:23:in <main>' 	30: from /Users/administrator/.rbenv/versions/2.6.3/bin/fastlane:23:in load'
29: from /Users/administrator/.gems/gems/fastlane-2.170.0/bin/fastlane:23:in <top (required)>' 	28: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/cli_tools_distributor.rb:119:in take_off'
27: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/commands_generator.rb:41:in start' 	26: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/commands_generator.rb:352:in run'
25: from /Users/administrator/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in run!' 	24: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in run!'
23: from /Users/administrator/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in run_active_command' 	22: from /Users/administrator/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in run'
21: from /Users/administrator/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in call' 	20: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/commands_generator.rb:224:in block (2 levels) in run'
19: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/one_off.rb:22:in execute' 	18: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/one_off.rb:42:in run'
17: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/runner.rb:229:in execute_action' 	16: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/runner.rb:229:in chdir'
15: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/runner.rb:255:in block in execute_action' 	14: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/actions_helper.rb:69:in execute_action'
13: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/runner.rb:263:in block (2 levels) in execute_action' 	12: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:43:in run'
11: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:138:in upload_app_data_usages' 	10: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:138:in each'
9: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:149:in block in upload_app_data_usages' 	 8: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:149:in each'
7: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:150:in block (2 levels) in upload_app_data_usages' 	 6: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:150:in each'
5: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:157:in block (3 levels) in upload_app_data_usages' 	 4: from /Users/administrator/.gems/gems/fastlane-2.170.0/spaceship/lib/spaceship/connect_api/models/app_data_usage.rb:45:in create'
3: from /Users/administrator/.rbenv/versions/2.6.3/lib/ruby/2.6.0/forwardable.rb:230:in post_app_data_usage' 	 2: from /Users/administrator/.gems/gems/fastlane-2.170.0/spaceship/lib/spaceship/connect_api/tunes/tunes.rb:258:in post_app_data_usage'
1: from /Users/administrator/.gems/gems/fastlane-2.170.0/spaceship/lib/spaceship/connect_api/api_client.rb:124:in post' /Users/administrator/.gems/gems/fastlane-2.170.0/spaceship/lib/spaceship/connect_api/api_client.rb:181:in handle_response': undefined method status' for nil:NilClass (NoMethodError) 	31: from /Users/administrator/.rbenv/versions/2.6.3/bin/fastlane:23:in '
30: from /Users/administrator/.rbenv/versions/2.6.3/bin/fastlane:23:in load' 	29: from /Users/administrator/.gems/gems/fastlane-2.170.0/bin/fastlane:23:in <top (required)>'
28: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/cli_tools_distributor.rb:119:in take_off' 	27: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/commands_generator.rb:41:in start'
26: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/commands_generator.rb:352:in run' 	25: from /Users/administrator/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in run!'
24: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in run!' 	23: from /Users/administrator/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in run_active_command'
22: from /Users/administrator/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in run' 	21: from /Users/administrator/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in call'
20: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/commands_generator.rb:224:in block (2 levels) in run' 	19: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/one_off.rb:22:in execute'
18: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/one_off.rb:42:in run' 	17: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/runner.rb:229:in execute_action'
16: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/runner.rb:229:in chdir' 	15: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/runner.rb:255:in block in execute_action'
14: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/actions_helper.rb:69:in execute_action' 	13: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/runner.rb:263:in block (2 levels) in execute_action'
12: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:43:in run' 	11: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:138:in upload_app_data_usages'
10: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:138:in each' 	 9: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:149:in block in upload_app_data_usages'
8: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:149:in each' 	 7: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:150:in block (2 levels) in upload_app_data_usages'
6: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:150:in each' 	 5: from /Users/administrator/.gems/gems/fastlane-2.170.0/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb:157:in block (3 levels) in upload_app_data_usages'
4: from /Users/administrator/.gems/gems/fastlane-2.170.0/spaceship/lib/spaceship/connect_api/models/app_data_usage.rb:45:in create' 	 3: from /Users/administrator/.rbenv/versions/2.6.3/lib/ruby/2.6.0/forwardable.rb:230:in post_app_data_usage'
2: from /Users/administrator/.gems/gems/fastlane-2.170.0/spaceship/lib/spaceship/connect_api/tunes/tunes.rb:258:in post_app_data_usage' 	 1: from /Users/administrator/.gems/gems/fastlane-2.170.0/spaceship/lib/spaceship/connect_api/api_client.rb:124:in post'
/Users/administrator/.gems/gems/fastlane-2.170.0/spaceship/lib/spaceship/connect_api/api_client.rb:181:in handle_response': [!] undefined method status' for nil:NilClass (NoMethodError)
Please help.

Okay, it seems as if there was something wrong with the user role setting - in one account that user was only an app manager, not admin.
Could you perhaps improve the output to display an understandable message in this case - it took me hours to investigate.
I just have to try if it works out with passing a teamName, though - I will report back.

I still have the problem that the CLI says:
[!] Could not find app with bundle identifier 'com.apxxxx.otxxxxxx' on account<EMAIL_ADDRESS>when I pass in "team_name" for accessing an app, that is in another account.
I am using the same value (itc_team_name) I am using for example when I check the app status in AppStoreConnect with spaceship means.
If I have to use another value as team_name, please let me know where to find that value.
Thanks for your support.

Can you please try to use the team_id?  (http://docs.fastlane.tools/actions/upload_app_privacy_details_to_app_store/#upload_app_privacy_details_to_app_store)

Thank you - this is working great when using the itc_team_id for parameter "team_id"!
Very pleased


fix: Fix the compilation when the default features are disabled

This closes: #191.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.28%. Comparing base (65e6f0c) to head (0ab162a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   90.28%   90.28%
=======================================
  Files          34       34
  Lines        1905     1905
=======================================
  Hits         1720     1720
  Misses        185      185

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Transient failure: TypeError: Cannot read property 'bind' of undefined

Bug report

What is the current behavior?
We experienced a failure on getaround.com yesterday from ~3:35pm - 4pm PST. There was an error in the console:
getaround.js:1 Uncaught TypeError: Cannot read property 'bind' of undefined
    at getaround.js:1
    at getaround.js:1

This is because of the following two lines in the webpack runtime:
var jsonpArray = window["webpackJsonp"] = window["webpackJsonp"] || [];
var oldJsonpFunction = jsonpArray.push.bind(jsonpArray);

jsonpArray was returning a function, rather than a list, so jsonpArray.push was returning undefined. The question that I have is how could this have happened? No changes to the bundle were made during that time and the issue self-resolved. Is it possible that the window["webpackJsonp"] line could return a different value?
If the current behavior is a bug, please provide the steps to reproduce.

Set window["webpackJsonp"] to return function, rather than an array.

What is the expected behavior?
window["webpackJsonp"] should return an array, rather than a function.

Other relevant information:
webpack version:  4.39.2
Node.js version: 10
Operating System: macOS Mojave 10.14.6
Additional tools:

If you want to be safe you can also change the global variable i. e. by using this:
{
  output: {
    jsonpFunction: "o3iv79tz90732goag" // use your own random string here
  }
}

but this is usually not required.

Turns out that the root cause was Stripe: https://twitter.com/stripe/status/1179182163482333185
However, that's a great suggestion to avoid this sort of collision in the future @sokra 🙌

Thanks so much for the quick reply @sokra

@sokra I think we can improve this out of scope, what about:

search package.json
get name
calculate hash of name
use webpackJsonp[hashOfName]

Should be safely

@sokra I had the same problem with IE8, but chrome is fine。

webpack.config.js
output: {
    libraryTarget: 'window',
    path: resolve('dist'),
    filename: '[name].js',
    chunkFilename: '[name].[hash:6].js',
    jsonpFunction: '__ynavi2_webpackJsonp__'
  },

I'm getting this error and changing jsonpFunction isn't fixing anything.

@stevenvachon could you provide repro?

#9446

IE 8 don't support bind function, add bind polyfill can solve this.

I'm getting this error and changing jsonpFunction isn't fixing anything.

@stevenvachon did you manage to fix this?

@stevenvachon did you manage to fix this?

I'm not working on that project anymore, so it's very likely still not fixed.

It means you forget to include runtime code in your html file, run ls -l ./dist and look at files

I can confirm this fix works in situations where, on a single webpage, one bundle is built with webpack 2.x and another bundle with 4.x. In this case, I added the output.jsonpFunction option to the webpack 4.x bundle.


bug:  a g:terminal_color_13 not exist error when using tokyonight

Did you check docs and existing issues?

[X] I have read all the tokyonight.nvim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of tokyonight.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.10
Operating system/version
win10/ubuntu22.04
Describe the bug
vim-plug  is my (nev)vim plugins manager, and I have installed tokyonight.nvim and wrote  colorscheme tokynight in neovim's  init.vim,  when nvim started up, an error message appeared:
Error detected while processing C:\Users\LEO\.leovim\conf.d\plugin\schemes-status.vim[312]..ColorScheme Autocommands for "*"..function glyph_palette#defaults#highlight[4]..
<lambda>3:
line    1:
E121: Undefined variable: g:terminal_color_13
Press ENTER or type command to continue

Steps To Reproduce

use vim-plug
install tokyonight
add colorschem tokyonight in init.vim

Expected Behavior
It seams to be glyph_pallete related bug, I have found solution to suppress the error message, just set g:terminal_color_13 before colorscheme command, even an empty string
        let g:terminal_color_13 = ''
        colorscheme tokyonight

Repro
vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    -- add any other plugins here
  },
})

Wrong repo https://github.com/ghifarit53/tokyonight-vim


Add radio groups

To be moved from github/github.
Needs documentation.

@broccolini would be interested in helping out here and you have the added bonus that I am a GitHub employee 😊.
Does that work for you?

have the added bonus that I am a GitHub employee

Got me beat there 🤔

@AustinPaquette I should have been clearer in what I meant here. I said this because @broccolini mentioned that this issue can only be done by github staff.

Heads up, this issue can only done by GitHub staff.

Sorry for the confusion.

@mrsimonfletcher Very happy to have new contributors!  If you'd like one of us to walk through the flow, please holla! You can also find us in the #design-systems slack.


'Export as GTFS' produces very little data

We have a database set up with around 120 routes, each with quite complicated (and carefully digitised!) trip patterns. However when we come to export these routes, only one shows up in the resulting GTFS zip file. Can not find anything particularly special about that one in terms of settings - all the routes are marked as Pending + Publicly Visible.
Strangely, the GIS export works fine. Using export dates from today to one year from today. Any advice much appreciated!

Hmm. Which commit of the editor are you using? We recently rewrote the entire export logic from scratch.

I've got 0.1.3 as installed before Christmas. Shall I upgrade to 0.2 and try that? Cheers.

Yeah, give that a shot. I'm hoping this was an export problem rather than a data model problem, as the latter are harder to fix.

Still having problems with v2 I'm afraid (see #176) but in order to try and get the data exported from our v1 installation, have copied across the whole database from our v1 to v2 machine. Then running the export gives
Execution exception (In /app/jobs/ProcessGtfsSnapshotExport.java around line 94)
OutOfMemoryError occured : Java heap space

@markjd84 have you try to use my vm in the #174 ticket ? I think it would export, just import your postgresql database.

Brilliant @dgoujard  - massive thanks for the VM.
I'm afraid however I'm still getting the message below when trying to export our routes, even using your machine and following the dependency instructions in #171. It is a lot of routes (around 120, each with ~60 stops) - but I'm not convinced that would be enough to cause this.
Execution exception (In /app/jobs/ProcessGtfsSnapshotExport.java around line 94)
OutOfMemoryError occured : Java heap space

Does your export work? If so - is it a lot of routes or a small number?
Can I be really cheeky and ask if you did anything different in setup of this VM outside the instructions in INSTALL.md ?

Hi,
I just follow install.md and complete the instruction with additional download of jar.
My export work, but i didn't have many routes (it's just test setup).
It's maybe not enough RAM for the export (it would be strange). Have you check with top ou htop the memory usage when you request export?

Right... it works if I give the VM and Play far more RAM (stuck it up to 1.5G).
However, we still only get one route output from the export!

Upon closer inspection, it appears there are no actual trips ever being generated in the database. We have routes, and trip patterns, but for some reason the table trip is almost empty. I wonder if it's something to do with using frequency-based trips?

Yep, that's expected behavior. If the pattern runs from 8am to 10pm every 5 minutes, that's represented as a single trip. It should, however, produce frequencies.txt entries from them. That doesn't explain why you're only seeing a single route, however.

I think this should be fixed with latest master, which does not use Postgres at all. Note that there currently isn't a migration tool other than exporting and reimporting GTFS (or just reimporting the GTFS you started with).