fix: no sales in last year bug

What
fix: no sales in last year bug

:tada: This PR is included in version 1.40.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fonts should be served over HTTPS

Your site is being loaded over HTTPS now, so fonts are not loaded because it is loaded on HTTP. In Chrome (v52) the console error message is "Mixed Content: The page at 'https://casesandberg.github.io/react-color/#usage-include' was loaded over HTTPS, but requested an insecure stylesheet 'http://fonts.googleapis.com/css?family=Roboto:500,300,400'. This request has been blocked; the content must be served over HTTPS."
There is no reason not to load external files over HTTPS if they support it!
Thanks for the excellent library!

Oh perfect! Can you run npm run docs-dist and push it up as well? Then I can get this merged

Sure - done!

@casesandberg I just noticed that I had done this wrong and you had to publish a fix. Do you know what I might be missing?

Ah! It was a problem with you not having a specific package locally I think. I need to add an npm install to the predocs-dist to make sure all of the right packages are installed :)


How to style when disabled?

There are two states which may have a different style:

The regular style: When there is a scrollable scrollbar.
The disabled style: when there is enough space two show all the contents of the container, and the scrollbar cannot be used (disabled, greyed out)

How can I apply css on the second state?

In the 1st state, the combination of these classes will be on the container: ps-container and ps-active-y (or ps-active-x)
In the 2nd state, there will only be a ps-container
To style it, I'd suggest doing:
/* The 1st state */
.ps-container {
  opacity: .5;
}

/* the 2nd state */
.ps-container.ps-active-y {
  opacity: 1;
}


Added support for custom malloc functions

On systems which have their own implementation of malloc, relaloc functions it is essential to be able to specify their names on compilation time without including extra header files. For example FreeRTOS have its own malloc (with different name). Another thing is that not always malloc allows for allocating zero bytes.

I guess that I was checking if my -D defines work well and don't get lost in nested makefiles. All in all it was meant to be temporary. Next week I will remove it an firstly run Travis on my own branch.

Awesome. I'll approve and merge as soon as you make that change ! Thanks :]
On Apr 28, 2017 7:49 PM, "Zdzisław Krajewski"<EMAIL_ADDRESS>wrote:

I guess that I was checking if my -D defines work well and don't get lost
in nested makefiles. All in all it was meant to be temporary. Next week I
will remove it an firstly run Travis on my own branch.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/littlstar/b64.c/pull/12#issuecomment-298131109, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABZSvWKVfdqSg1WiwxIu2_p238o7_JXuks5r0nsTgaJpZM4MMIyz
.


Dev: add method to get real validation errors

There is no way to get real validation errors only, excluding the errors saved in the session.
See https://github.com/codeigniter4/shield/pull/383

The validation class should not interact with the session at all.
Do not read or delete session values.
If you take a deeper look at the problem that appeared in the shield, you will see:
Suppose our application performs the same manipulations as in the shield, that is, with each request, it changes the timestamp of the activity.
public function recordActiveDate(): void
{
    if (! $this->user instanceof User) {
        throw new InvalidArgumentException(
            __METHOD__ . '() requires logged in user before calling.'
        );
    }

    $this->user->last_active = Time::now();

    $this->provider->save($this->user);
}

Now imagine that validation is enabled in the model that serves changes to the timestamp of the activity.
Then, if the previous request ended with a validation error, then the model with validation enabled, while maintaining the timestamp, will reset the errors from the previous request.
because
https://github.com/codeigniter4/CodeIgniter4/blob/42e5b69f05a524f1d254749dd10682fc5d3711f2/system/Validation/Validation.php#L109-L115
Example:
// routes
$routes->get('/', 'Home::index');
$routes->get('form', 'Home::form');

// controller
namespace App\Controllers;

use CodeIgniter\Database\Exceptions\DataException;
use CodeIgniter\Model;
use Config\Services;

class Home extends BaseController
{
    public function index()
    {
        $this->userActivity();
        dd(Services::validation()->getErrors()); // []
    }

    public function form()
    {
        $this->userActivity();
        if (! $this->validateData([], ['email' => 'required'])) {  // email => The email field is required.
            return redirect()->to('/')->withInput();
        }
    }

    private function userActivity()
    {
        $m = new class extends Model {
            protected $validationRules = [
                'time' => 'required'
            ];
        };

        try {
            $m->save(['time' => 'new timestamp']);
        } catch (DataException $e) {}
    }
}

Going to the URL /form will fail the validation and redirect to /. In the index method, validation errors from form are reset due to a change in the timestamp.

@kenjis The PR you suggested only adds a workaround, but doesn't actually solve the design problem.
Currently, the framework is turning into a set of crutches and bicycles. The maintainers are talking about Semver and that we'll get it right in version 5. But this 5th version is not even visible on the horizon.

@iRedds Good catch. You're correct.
https://github.com/codeigniter4/CodeIgniter4/blob/42e5b69f05a524f1d254749dd10682fc5d3711f2/system/Validation/Validation.php#L109-L115
Do you have any solution?

Is withErrors() really necessary?
We don't know how many times validations will be run, and it is impossible to store only one of those errors in the session and use that errors for all validations.

@kenjis It seems to me that in the framework of the 4th version nothing can be done. Since receiving errors is related to the validation class and any change will result in a BC.
Earlier I thought about the solution, but some points did not give in to me. I found the solution in the Laravel.

Validator does not depend on sessions.
To save validation errors in the session, a method is called on the response. ->withErrors($validator->errors())
Validation errors through the system middleware (done always before the user's middleware) are retrieved from the session on each request and placed in the shared variable of the views.

And of course, I would remove the validation from the model, focusing it as a repository.

In addition, there is one interesting case in the validator in Laravel. If the validation fails, it can throw an exception, which is handled like a redirect with an automatic call to ->withErorros().

Yes, the Validation class should not depends on sessions, and when we use withErrors(() we need validation errors in the views.

And of course, I would remove the validation from the model, focusing it as a repository.

I don't see your logic. How do you do in-model validation?

I don't see your logic. How do you do in-model validation?

Why do validation in the model?
You can make separate validation services. Like in Symfony or FormRequest in Laravel.
In addition, the CI Model cannot by default change the validation rules for insert or update/partial update. Therefore, you need to add different scenarios of behavior.
And if you look on the forum, most of the code examples do the validation in the controller.

Why do validation in the model?

Not to save invalid data in the database.

You can make separate validation services.

We have already the Validation service. In-model validation just uses it.

And if you look on the forum, most of the code examples do the validation in the controller.

Validation in the controller is for validating input data (mostly Form data) from the outside of the system.
Validation in the model is for validating database row data (Entity).

@kenjis I want to say that in my opinion the DDD principle is more successful. By citing symfony and laravel as an example, I meant that in these frameworks, the model/repository is not involved in data validation.
UserController::create() call UserService::create() call UserCreateRequest() only for validation and call UserModel() only for save.
No fat controllers. No fat models. Business logic is distributed across classes, each does only what it is instructed to do.
Each element can be covered by tests.

@iRedds Thank you for your opinion. I don't know the DDD principle you say, but I understand you prefer the UserCreateRequest() UserController::create() UserService::create() UserModel() pattern.
However, the model does have validation, but it is not used by default, so I don't think it would interfere with the pattern.
This is getting off topic, so I will leave this discussion here for now.

I sent another PR  #6384 to fix the bug.

Good discussion here, some quality considerations for v5. I believe this issue can close @kenjis? But I will tag it to come back to later.

Yes, we don't need a new method or parameter for it.
Validation::getErrors() will return  only real validation errors.


Update patch versions in config

This PR updates the patch version is the 1.9 and 1.10 releases.
I noticed that that docs sometimes presented commands with older patch version is some pages from https://github.com/kubernetes/kubernetes/issues/64054

/assign @chenopis

/assign
/approve
/lgtm


this is undefined

I learn from u proj , why i cant find this ? thankU

Well this is probably undefined because Login is static.

no related , but i get some idea from U project , how can i do to log this , or instant and use guessPosition Correctly, thank U

Remove static.

of cause I remove static but also undefined
is there I forgot something ?

ok , now just console.log(this.tencentkey) but undefined

I get it , remove static is first , second I  need to use bind in children's constructor

That depends on how you use it. Are you invoking it directly or are you passing a ref to the function? I don't have enough context to help you.


Selecting rows can sometimes fail

There's a bug that I haven't fully repro'd yet (but was reported as well by a firefox user) where clicking on the rows does not highlight them.
It may be time to actually move to checkboxes for the rows on the left instead of clicking on rows to select them. The mobile PR actually has some code for this.

There's at least 2 scenarios where this happens, unified by the fact that a smaller number of rows than normal is displayed on page load.

"compare selected" -> close tab -> reopen tab -> end compare = can't click non compared rows
"filter instance name" -> close tab -> reopen tab = can't click non compared rows

There's some issue with the way we are assigning the highlight rows functionality on page load where the number of rows displayed is less than the full amount.


PhpComposer: Handle packages defined in "provide" and "replace"

This PR implements handling of the "provide" and "replace" sections in composer.json files. Without handling these fields specifically the analyzer would report any package mentioned there as missing.
I have tried to keep the change as small as possible without touching anything outside of PhpComposer. This resulted in the "virtual" packages being handled completely different from the normal packages. If we have similar cases for other package managers it would probably make sense to merge these virtual packages with the normal packages and handle it in the analyzer itself and not in every analyzer itself.

This change is

Thanks!


Checkbutton (Roundtoggle & Squaretoggle) disappearing with custom style

Desktop (please complete the following information):
ttkbootstrap Version 1.10.1
OS : Windows 11
Python : 3.10.6
Describe the bug
The roundtoggle and squaretoggle checkbuttons disappear when we give them a custom style.
I tried custom styling with TCheckbutton, Toolbutton and Outline.Toolbutton and it works fine.
To Reproduce
from tkinter import Tk
from ttkbootstrap import Checkbutton, Style
window = Tk()
window.geometry("400x400")
my_style = Style()
my_style.configure('Roundtoggle.Toolbutton', font=("Helvetica 26"), foreground="#FF0000")
button = Checkbutton(window, text = "Hello", style="Roundtoggle.Toolbutton")
button.pack()
window.mainloop()

Expected behavior
A bigger checkbutton (or at least bigger font)
Screenshots
No response
Additional context
No response

Try this if it work on your side
Hello there, I've come across your bug report regarding the checkbutton and have taken the opportunity to evaluate it on my own system. Based on my understanding and the information available in the documentation, it appears that when customizing styles, it's essential to define valid ttk class names. If your goal is to enlarge the text, as it appears in the image you've shared, you might want to consider using the following code snippet.

from tkinter import Tk
from ttkbootstrap import Checkbutton, Style
window = Tk()
window.geometry("400x50")
my_style = Style()

# or success.TRadiobutton , danger.TRadiobutton, etc...
checkbtn_style = "danger.TRadiobutton"

my_style.configure(checkbtn_style, foreground="#FF0000",
                   font=("Helvetica", 26))
button = Checkbutton(window, text="Hello", style=checkbtn_style)
button.pack()
window.mainloop()

Thanks for you answer, it works indeed
But what if I want to use a checkbutton (and particularly a Roundtoggle button) instead of a radiobutton ?
from ttkbootstrap import Checkbutton, Style

window = Tk()
window.geometry("400x50")

my_style = Style()

#my_style.configure('danger.Roundtoggle.Toolbutton',font=("Helvetica 26"), foreground="#FF0000")

button = Checkbutton(window, text = "Hello", style="danger.Roundtoggle.Toolbutton")
button.pack()

window.mainloop()

You can see that if I comment out the my_style.configure() line, the checkbutton reappear, with default style
You talk about class names, I tried to follow the class names given in the documentation here : https://ttkbootstrap.readthedocs.io/en/version-0.5/widgets/checkbutton.html

Oh, I understand now. Please correct me if I'm mistaken, what you are looking is to increase the font size of the checkbutton? As far as my knowledge goes, I haven't worked on configuring a custom style for a checkbutton to specifically customize the font sizes. Typically, I've focused on altering the styles related to appearance.
As a potential workaround for achieving the desired larger font size for the checkbutton, I might consider adjusting the Windows scaling to a desired value. For instance, if I set the scaling to 2, it would proportionally scale up the sizes of the widgets, resulting in a larger font size. If further adjustments to the text sizes of labels are needed, I could create another custom style specifically for TLabels.

import ttkbootstrap as tb

class App(tb.Window):
    def __init__(self) -> None:
        super().__init__(self, themename="darkly") #, scaling=2)
        self.title("GB #482")
        self.geometry("300x100")
        self.position_center()

        cframe = tb.Frame(self)
        cframe.pack()
        chk_btn = tb.Checkbutton(cframe, text="", bootstyle="danger-square-toggle")
        chk_btn.pack(side="left")

        chk_lbl_style = tb.Style()
        chk_label_style = "vinz.TLabel"
        chk_lbl_style.configure(chk_label_style, foreground="#FF0000", font=("Consolas", 7, "bold", "italic"))

        chk_label = tb.Label(cframe, text="ADD ME", style=chk_label_style)
        chk_label.pack(side="left")

        lframe = tb.Frame(self)
        lframe.pack()
        chk_btn2 = tb.Checkbutton(lframe, text="", bootstyle="danger-round-toggle")
        chk_btn2.pack(side="left")
        chk_lbl_style2 = tb.Style()
        chk_label_style2 = "vinz2.TLabel"
        chk_lbl_style2.configure(chk_label_style2, foreground="#FF0000", font=("Consolas", 30, "bold", "italic"))
        chk_label2 = tb.Label(lframe, text="ADD ME", style=chk_label_style2)
        chk_label2.pack(side="left")

app = App().mainloop()

##DEFAULT Scaling

##Scaling = 2

##Custom Label Font Size

I hope this helps with your issue.

Thanks a lot, that's exactly what I wanted, I had no idea about that scaling argument. I'll use that to solve my problem, but I guess it changes the size of every widget ? So there's no way to only scale up the checkbuttons ?
And I still don't understand why I can't style a checkbutton the same way you style a label. In the code below, the rounded checkbutton disappear once again when I try to give it a custom style
import ttkbootstrap as tb

window = tb.Window(scaling=2)
window.geometry("500x400")

chk_lbl_style = tb.Style()
chk_lbl_style.configure("vinz.TLabel", foreground="#00FF00", font=("Consolas", 15, "bold", "italic"))
chk_label2 = tb.Label(window, text="Normal Label", style="vinz.TLabel")
chk_label2.pack()

chk_lbl_style2 = tb.Style()
chk_lbl_style2.configure("vinz2.danger.Roundtoggle.Toolbutton", foreground="#FF0000", font=("Consolas", 15, "bold", "italic"))
chk_btn2 = tb.Checkbutton(window, text="Roundtoggle.Toolbutton",style="vinz2.danger.Roundtoggle.Toolbutton")
chk_btn2.pack()

chk_lbl_style3 = tb.Style()
chk_lbl_style3.configure("vinz3.success.TCheckbutton", foreground="#00FF00", font=("Consolas", 15, "bold", "italic"))
chk_btn3 = tb.Checkbutton(window, text="TCheckbutton",style="vinz3.success.TCheckbutton")
chk_btn3.pack()

window.mainloop()

I don't really care now that I have your solution, but still, it looks weird

Hello! Building upon @vinzjaystone response, you could create a class that generates this specific widget using the provided concepts, which would help avoid code duplication. As for the root cause of the problem, it could potentially be a bug.
The example below is just a rough outline:
from tkinter import Tk, IntVar
from tkinter.font import Font
from ttkbootstrap import Checkbutton, Style, Frame, Label
from typing import Any

class Roundtoggle(Frame):
    def __init__(self,
                 parent: Any=None,
                 font: Font=("Arial", 12),
                 text: str="",
                 onvalue: int=1,
                 offvalue: int=0,
                 foreground: str="#000000",
                 **kwargs):
        super().__init__(parent, **kwargs)

        self.__style = Style()
        self.__value = IntVar()
        self.__checkbutton = None
        self.__label = None
        self.__font = font
        self.__text = text
        self.__onvalue = onvalue
        self.__offvalue = offvalue
        self.__foreground = foreground

        self.__create_checkbutton()
        self.__create_label()
        self.__set_event()

    def get(self) -> Any:
        return self.__value.get()

    def set(self, new_value: Any) -> None:
        self.__value.set(new_value)

    def __create_checkbutton(self) -> None:
        self.__checkbutton = Checkbutton(self,
                style="Roundtoggle.Toolbutton",
                onvalue=self.__onvalue,
                offvalue=self.__offvalue,
                variable=self.__value)

        self.__checkbutton.grid(row=0, column=0)

    def __create_label(self) -> None:
        self.__style.configure(style="roundtoggle.TLabel",
                font=self.__font,
                foreground=self.__foreground)

        self.__label = Label(self,
                text=self.__text,
                style="roundtoggle.TLabel")

        self.__label.grid(row=0, column=1)

    def __click(self, event) -> None:
        value = self.get()

        if value == self.__offvalue:
            self.set(self.__onvalue)
        else:
            self.set(self.__offvalue)

    def __set_event(self) -> None:
        self.bind_all("<1>", self.__click)

window = Tk()
window.geometry("400x400")

c = Roundtoggle(parent=window,
                text="Hello",
                font=("Heveltica", 26),
                onvalue=1,
                offvalue=0,
                foreground="#FF0000",
                cursor="hand2")
c.pack()

window.mainloop()


fix: code block contrast is too high

First of all, thanks for the great tool and I really like the redesign of docs.page.
Description
I noticed that the contrast of the code block is quite high for the light theme as the code block seems to be quite black-ish in contrast to the white-ish background.

When compared to the dark theme, the code block integrates better with the background as the background is black-ish and the code block is gray-ish.

Suggestion
Lightening the code block background for the light theme might make the docs more pleasing to the eye and easier to read.
Additional notes
As this issue is quite opinionated feel free to let me know what you think 😀

Ah interesting... I did actually do this on purpose, as a fairly well known company also has this type of contrast in their docs too for code blocks. I'll have to change the tokenization colours too if we go ahead here.


Toggl can't time

Mac: 3.11.6 (v149.12.0) Mac OmniFocus, which was updated yesterday.
iOS: 3.11.5 Pro (v148.9.0)
Using OmniFocus today, I found that I can't start the timer anymore.
If I delete the plugin and reinstall https://github.com/benhughes/OmniToggl/releases version 1.1.1, OmniFocus for Mac still does not work. iOS can start the timer, but cannot end it. On the iOS side, after manually turning off Toggl timer, iOS OmniFocus is also not available.

Ok, I think this may be an issue with the latest OmniFocus. I've had issues with the new version I'm testing and hoped it was an issue with the new version, not OmniFocus. Will investigate and raise a bug.

Thank you for providing this tool. It has been a great help to me.

FYI seems to be working again in 3.11.7 beta, possibly due to your bug report :). Thanks for the great tool!

That's good to hear, even in my tests it's a bit on and off if it works or not so let me know if it plays up again. I'll give the beta a download.

Oh saying that. I got a reply.

This is a regression we are aware of and should have fixed in our next update.

So hopefully they'll have an official build out soon

Thanks Benhughes!
I met same question and I hope it will be works again.
Many thanks to Benhughes OmniToggle is best time manage tools to me.

I am having difficulties as well. I can only start / stop a timer once and then I need to restart omnifocus.
(works as normal on iOS though!)

Yeah it's a known bug in OmniFocus which is frustrating as there release cadence is not great. Here's an email I received from them with instructions on how to get the beta build:

Sorry for the trouble here, but thanks for getting in touch!
This is a regression we are aware of and should have fixed in our next update.
We do have test builds available for this next update, which you can try out. However, since you are currently using OmniFocus from the Mac App Store, you can't just seamlessly use a test build for the moment. This is because release/test builds from our website are treated as a separate app (different bundle identifier) as builds of OmniFocus from the Mac App Store. Therefore, to use the test builds, you'd be setting up the app from scratch. It wouldn't have any of your existing preferences, linked folders you may use for plug-ins, etc.
That said, if you do want to try out a test build, you can grab a build here:
https://omnistaging.omnigroup.com/omnifocus/
As part of all this I should mention that, even if you purchased OmniFocus from the Mac App Store, you could now switch to using non-Mac App Store builds. This is due to a change in our app handles licensing. You'd just need to make sure your existing purchase of the app is registered with your Omni Account, which you'll sign into when setting up the app. The advantage of using builds direct from us is it does give you greater flexibility to switch between release and test builds, or even revert back to older builds. If you have any more questions on this, just let me know.
And of course, hopefully we'll have this update ready to officially ship soon, so we can get this fix out the door!
If you have any additional suggestions, questions or concerns, please don't hesitate to let me know. We really appreciate your support!

The new version has hit the mac app store and seems to work as it used to so closing this now. Thanks for reporting.


Modifier keys stuck when using Input.is_key_pressed check

Godot version:
3.1
OS/device including version:
MacOS 10.12.6 (I think this is highly relevant here).
Issue description:
I'm checking if some modifier keys are pressed using:
Input.is_key_pressed(KEY_SHIFT)
Input.is_key_pressed(KEY_META)
Input.is_key_pressed(KEY_CONTROL)

Sometimes the method returns true despite the fact the key is NOT pressed. I think it might be related to some internal state and not actually checking with the driver. It happens for example when quickly cmd-tabbing between the game and the editor. I often find myself in the position when the Command key (KEY_META) is stuck. Pressing and releasing it helps (obviously some state is cleared).

Confirmed that this issue also exists on Windows.
Easiest way to reproduce this is to add something like this to some scene:
func _process(delta):
    print(Input.is_key_pressed(KEY_ALT))

Run the scene, then alt-tab out of it and check the output. Unsurprisingly, this bug also affects Input.is_action_pressed() checks.

Unsurprisingly, this bug also affects Input.is_action_pressed() checks.

No, Input.is_action_pressed() officially ignores modifiers, which makes it totally useless. I use a custom version of it, which actually cares about modifiers, but this bug makes it tough as well.

If this is really about Alt-Tabbing, it was fixed in 3.2 (I tested and don't see the issue anymore). Comment if you can still reproduce in 3.2.2.


[WIP] Ruby Patch Version Bump

Proposed changes
Netlify Preview seems to be failing. Trying to fix with bumping Ruby patch version.
Failed builds in:
https://app.netlify.com/sites/docsdocker/deploys/5df770baf6d9ce0008277f1b
https://app.netlify.com/sites/docsdocker/deploys/5df759d65ef42c00081681d3
Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit 15bd17ac7277da6bc60942a70d20e35d04666ae2
https://deploy-preview-10040--docsdocker.netlify.com


Feature Request: add api list feature

Is your feature request related to a problem? Please describe.
writing api address manually frustrating
Describe the solution you'd like
Get the API list from the config to the UI, as in the photo

I have implemented this in the latest experimental build.


File structure should mirror package structure

Is your feature request related to a problem?
Currently, the file structure mirrors the Python implementation, e.g. data/image/containers/_image/_image.sdsstub. Note the duplicated _image. It should mirror the package structure instead. The leading underscores also serve no purpose in the DSL.
Desired solution
In the above example, the package is safeds.data.image.containers, so the file should be at data/image/containers/image.sdsstub. The _image folder should be removed, as well as the leading underscore of the file name.
Possible alternatives (optional)
No response
Screenshots (optional)
No response
Additional Context (optional)
No response

:tada: This issue has been resolved in version 0.3.0 :tada:
The release is available on:

v0.3.0
GitHub release

Your semantic-release bot :package::rocket:


Roadmap (RFC2 implementation, "phase II")

First workable pre-α (late spring)

[ ] Transactor (milestone) vyzo + bigs
[ ] L-SPACE read peer (milestone) yusef + arkadiy
[ ] CLI (read) (issue) arkadiy
[ ] Translator/writer client (needs planning) yusef + arkadiy

set up base service [note: we should have a template for this]
port over translation code (maybe also separate translator?)
client <> transactor service API defs (issue) (this is just copycat PUT rn)
client<>CLI API defs
ignore deduplication etc for now

[ ] CLI (write) (needs planning) ?

either gRPC CLI or invoking client code directly

[ ] Orchestration (needs planning) ?

docker-compose ensemble?

What we have at this point:

transactors = 1, syndicated peers = 1, block size = 1
write some data, read some data (no merging)
datastore backed by Dynamo
interfaces semi-stable

α.1 (summer)

client/translator: merge/deduplication/etc yusef + arkadiy
transactor: peer discovery etc (@bigs @vyzo -- not entirely sure what's missing here) bigs? + vyzo
data store: switch to IPFS ?

What we have at this point:

transactors = 2+, syndicated peers = 2+, block size = ? (2+)
write some data, merge some data, basic deduplication at write
datastore backed by IPFS
interfaces stable

α.2 (late summer)

@parkan atm peer discovery is not really necessary as we have a single, complete quorum

Ok, @bigs @vyzo can we separate transactor-related steps into "absolute bare minimum that a transaction can be recorded", "healthy network" and "healthy/scalable network" type buckets? I imagine there's some work that's still on top of copycat but not strictly necessary for a single node to accept and record a transaction.

Closing this in favor of the milestone-based roadmap


add YouCompleteMe to enable autocomplete in vim-go

here for more details https://blog.gopheracademy.com/vimgo-development-environment/

vim-go recommend neocomplete
https://github.com/fatih/vim-go#optional


Data labels question

Hello, I would like to test out this code, I see that in the model_config.json, it has "num_labels": 1. Does this mean the model was only trained on the "nodules" class?
In the dataset.py line 223 i see that it crops both a nodule else it crops a non-nodule (negative) patch, is that correct?
If that is the case, should i be changing the num_labels to 2, to train it on both "nodule" and "non-nodules"?

Hello,
Thank you for your question. Yes, the model is trained to classify whether the cropped patch contains a nodule or not. As we formulate the problem as a binary classification task, a single logit output is sufficient, with binary cross-entropy loss. Setting 'num_labels'=2 would utilize multi-label cross-entropy loss, which works equivalently well. Please refer to model.py for details.

Thanks, I have another question regarding inference for a single scan. Since the dataset class currently crops nodules and non-nodules based on the annotations, would a separate dataset class be required so that the single scan can be cropped fully without needing ground truth labels, so it can be used as inputs to the trained model?

Indeed, that's a more unbiased method for evaluation. I plan to add that and adopt the evaluation metric used in the luna16 challenge in future updates.

Sure, something like a demo would work as well. I'm looking at the codes so i'll see how i can contribute to this.

hello,
i am looking at the dataset.py code at line 223
if len(bboxes)>0 and np.random.rand()<0.5:

In this case, if there is a nodule located but the prob is < 0.5, it won't crop the positive nodule. Will it be better to set it such that it always crops out the positive nodule, and then additionally crop out a negative patch as well?

Hello, the goal is essentially to produce a balanced dataset. I guess the sampling may add some unnecessary overheads but does its job well.
Please feel free to make any improvements. Thanks!


export sparkR.stop

@oscaroboto -- sparkR.stop should be automatically called when R exits, so I am not sure we need to export it. Is there a specific bug you ran into ?

I've run into issues where Rstudio can seemingly get "disconnected" from the backend so that I can't initialize a spark context even after quitting and restarting R several times. In those cases I have to manually kill the backend process from the command line and restart R.
That said, this is a rare case and is likely the result of me building the package over and over, but I still like the idea of being able to kill the backend from within R.  If you can manually initialize the spark context from inside your IDE, why not also expose the ability to manually kill it?

I also have run into the issue mentioned by @cafreeman regarding getting "disconnected". In which case I need to go to command line and kill the java pid manually. I think being able to kill the sc from within R will help. Furthermore, I would like to have the ability to kill and restart the sc from within an R session so that I don't have to close and reopen Rstudio while debugging and selecting cluster parameters such as number of instances/cores and spark worker memory.

I am not using RStudio, so I don't know why RStudio brutally restart a R session without cleaning up (i.e., sparkR.stop() finalizer is called).
However, I think it makes sense to expose sparkR.stop(). As pointed out by @oscaroboto, a user may want to stop the current SparkContext and create a new SparkContext with different configurations. Also it makes sense if in the future we may support multiple SparkContexts.
I left some minor comments on the change.

@sun-rui It will be really cool to support having multiple SparkContexts! Is there a Jira task for that?

@oscaroboto, I depends on the support for multiple SparkContexts in Spark. As I know, it is not supported yet in Spark. @shivaram  If I were wrong, please correct me .

As you all know RStudio is not the most robust platform, which is why I think in some (maybe not so rare) cases it may shutdown and/or crash without cleaning up and hence not execute sparkR.stop() leading to a java pid running as a ghost process. I hate it when I get the bomb! (for those of you who know what I am talking about)

yes, despite RStudio, it is still possible in practice that the R interperter losts connections with the backend for some reason, and the backend is not aware of this situation now. For robustness, the backend may check if the parent process exists at a predioc interval, if so it will terminate itself. However, I am not sure if it is worth to do so.

Thanks @oscaroboto - The latest version mostly looks good and it seems to work as expected in R and RStudio on my laptop.

@shivaram Good to hear that!

Thanks @oscaroboto - I've squashed the commits and merged it into master.
@cafreeman - Let us know if this helps with the problems you were running into.

@cafreeman So far so good! problem solved.


added Niravprajapati1

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

I changed global to globe and updated broken link

Thanks 🙌


TypeError: Failed to fetch

I tried to convert the following URL and it failed with the above error.
https://foxhill.deskpro.com/api/docs
I have attached the file for ease of reference.
docs.txt
Any ideas why this failed?

Was this on the website?
Likely the URL has CORS enabled - if you use the CLI it should convert fine.

Closing due to lack of info


Adjusted rebooting message to avoid confusion

Append location of the rebooting instance to the start of the rebooting message posted.

Please ignore Travis failure. It is just a network issue at Travis server.

!!/approve


Remove the concept of user game

every game and franchise is connected to a user now

Pull Request Test Coverage Report for Build 388929414

37 of 38 (97.37%)  changed or added relevant lines in 7 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-1.02%) to 77.049%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/api/server/user_games_handlers.go
9
10
90.0%

Files with Coverage Reduction
New Missed Lines
%

cmd/front-end/server/games_handlers.go
1
89.57%

Totals

Change from base Build 376254022:
-1.02%

Covered Lines:
846

Relevant Lines:
1098

💛  - Coveralls


Add overrides for Node.js

The TYPE_STRING overrides are actually pretty tricky - what's happening is in the discovery doc is, for some types in adexchangebuyer and other APIs, type is listed as "string", but the format is listed as "int64". For Java, the correct choice in terms of the client libraries is to use "int64", and for Node.js the correct choice is to use "string".
The "resource" to "resource_" overrides are straightforward. Theoretically you could do this in the transformer, but I don't think that's in the spirit of MVVM.

Current coverage is 80.95% (diff: 100%)

Merging #584 into master will not change coverage

@@             master       #584   diff @@
==========================================
  Files           258        258
  Lines          9725       9725
  Methods           0          0
  Messages          0          0
  Branches       1279       1279
==========================================
  Hits           7873       7873
  Misses         1521       1521
  Partials        331        331

Powered by Codecov. Last update 0247b66...867e6ee

Surely we don't want the handling of TYPE_STRING to be done as overrides ...? Or perhaps I misunderstand.

See comment above, Java and Node.js do the opposite thing in relation to these strings - since we derive the kind from the Field object, one of these languages is doing this wrong.

It's not clear to me that one approach is correct; the origin of the confusion comes from JSON's lack of certain types, requiring them to be encoded as strings. Let's generalize MVVM if need be to handle different options, equivalently to how it was done in *DiscoveryContext.java.

LGTM


[E video_decoder.cc:751] The video seems faulty and we could not decode enough frames: 31 VS 32

I have been trying to finetune the R(2+1)D-34 layer for clip length 32 with my own dataset. While pre-processing my data, I extracted clips of only 32 frames from each of my videos and I organized them to make my training data. My training/testing data looks like this:
Number of labels: 5
Training data - Number of videos for each label: 650
Training data - video length of each video: 32 frames (encoded in 30fps)
Testing data - Number of videos for each label: 150
Testing data - video length of each video: 32 frames (encoded in 30fps)
When I try to finetune the model with following parameters,
python tools/train_net.py
--train_data=/home/data/performance_baseline/training_input/
--test_data=/home/data/performance_baseline/testing_input/
--model_name=r2plus1d --model_depth=34
--clip_length_rgb=32 --batch_size=5
--load_model_path=/home/320061298/Desktop/r2plus1d_34_clip32_ft_kinetics_from_ig65m.pkl
--db_type='pickle' --is_checkpoint=1
--gpus=0 --num_gpus=1 --base_learning_rate=0.001
--epoch_size=10000 --num_epochs=24 --step_epoch=5
--weight_decay=0.005 --num_labels=5 --use_local_file=0 --file_store_path="/home/320061298/model_checkpoints/" --save_model_name="performance_baseline_model" --pred_layer_name="prediction_Layer_baseline"
I get the above mentioned error. I am sure that all of my videos have exactly 32 frames. Hence, why the video_decoder is not able to extract enough frames? Any light on this issue is much appreciated.
Thank you.

My apologies. It was a bug in my augmentation script where some videos had been trimmed with lesser frames. I cleaned my dataset and it works fine now.


Update menu

Ensure all --makrdown and --sort-by options are documented in the menu.yml file.

Closed in #268


AsyncEffectShootout with MacrotaskExecutor

Follow-up to #206: would be interesting to run the AsyncEffectShootout with the new MacrotaskExecutor just released:
https://github.com/scala-js/scala-js-macrotask-executor
This is the polyfill mentioned in https://github.com/japgolly/scalajs-benchmark/issues/203#issuecomment-899177982. Should level the playing field for CE3 hopefully 😅
Not sure how straightforward it is to swap out the executor for the various effect implementations 🤔

Noice! Probably just a matter of upgrading to CE 3.2.8 once it's out

Ahh, sorry I didn't explain the change clearly. This code was already inside of CE3, we extracted it out into a seperate lib so everyone can use it :)

Ah right. I've just updated the online demos now to use CE 3.2.7 but the results are still the same as before :(
https://japgolly.github.io/scalajs-benchmark/res/scala-2.13.6-sjs-1.7.0.html#/shootouts/async_effects

Right, the change that needs to happen would be using this MacrotaskExecutor for all the other effect types. CE is already using it. Which is why it's possibly non-trivial 😅

As of Scala.js 1.8.0 the MacrotaskExecutor is now officially recommended:
https://www.scala-js.org/news/2021/12/10/announcing-scalajs-1.8.0/


Payment: Create an IOU payment form

IOUPaymentForm Component
Overview / Summary
Summary description of UI component
This will appear within a payment checkout action when the example IOU payment method is enabled.
Rationale for why this component is necessary
This shows an example of how a form to collect payment info would be done.
Where should this component live
This component should be created in the Component Library.
Expected use cases
In storefront checkout
Implementation details
Use the existing AddressForm as a guide for making this. It should render just the form, with no submit button.
Images / Designs of UI component in context
There are no Zeplin designs for this, but it is just a form with a single full-width field, using existing components.
// Pseudo-markup for the render function
<Form>
  <Field>
    <TextInput name="fullName" />
    <ErrorsBlock />
  </Field>
</Form>

Data
Props
If there's already a stored name value, will receive that as props
propTypes: {
  value: PropTypes.shape({
    fullName: PropTypes.string
  })
}

Data Fetching
None. All data comes from props.
State Store
None. All data comes from props and form state is handled by ReactoForm.
Routing / Query String
Not directly connected to any route or query string.
Breakpoints
It is just a single full-width field at all breakpoints.
Theme
Use theme variables and context in the same way as AddressForm
UI States
There is no difference between desktop and mobile
Desktop and Mobile
Normal
A ReactoForm with a single full-width field, using existing components. See AddressForm for guidance.
Empty
There is no empty state
Loading / retrieving data
There is no loading state
Processing / Waiting for response
Should take an isReadOnly prop and pass it along to the TextInput. This can be used by the parent while processing submission.
Error
Field errors shown with ErrorsBlock component. Full name field should be required to be a non-empty string.
Active (e.g. button is depressed)
There is no active state
Disabled
Should take an isReadOnly prop and pass it along to the TextInput. This can be used by the parent while processing submission.
Focus
This component cannot be focused. The TextInput should be able to receive focus.

Note that I created this in the Meteor UI app already for 2.0, so just needs to be ported to component library.


Add app download driver for lbry.tv paid content

The encouragement to get the desktop app that currently exists should come with a link, at minimum.

Possibly use something similar for paid content


Error running fastlane init

Issue created here for @suchita-sindhi-bs to put fastlane/match#130 in a better place.

New Issue Checklist

[ ] Updated fastlane to the latest version
[ ] I have read the Contribution Guidelines

Issue Description
Complete output when running fastlane, including the stack trace and command used
=> I have 1.51.0 fastlane version on my Mac and when I run the command "fastlane init" then it shows me an error regarding snapshot and i have already install snapshot on my system and the version is
1.4.4
When I run the command "fastlane init" then it ask me for "Do you want to setup 'snapshot', which will help you to automatically take screenshots of your iOS app in all languages/devices? (y/n)": ==> and when I type "y" then it shows me an error that I have mention below:
Do you want to setup 'snapshot', which will help you to automatically take
screenshots of your iOS app in all languages/devices? (y/n)
y
[13:05:09]: Loading up 'snapshot', this might take a few seconds
13:05:13: Error occurred with the setup program! Reverting changes now!

13:05:13: Deleting the 'fastlane' folder
fatal: Not a git repository (or any of the parent directories): .git
Successfully submitted a crash report. If this is a problem with one of the tools specifically,
please submit an issue on GitHub and attach the following number to it: 'cedca4e3a5744258db57bce6c0231949'
The crash report has been stored locally '/tmp/sentry_cedca4e3a5744258db57bce6c0231949.json'
Successfully submitted a crash report. If this is a problem with one of the tools specifically,
please submit an issue on GitHub and attach the following number to it: 'b9afabf0f843d4db9d1067b38b7d2fd0'
The crash report has been stored locally '/tmp/sentry_b9afabf0f843d4db9d1067b38b7d2fd0.json'

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
# INSERT CONTENT HERE

Environment
fastlane version (fastlane -v):
Do you use bundler, rbenv or rvm?

@suchita-sindhi-bs Are you still having issues?

I'm going to close this due to lack of activity. Please feel free to continue the conversation if you'd like, and we can always reopen. 👍

Hey I'm still having the issue. Here is my output
Guest:testApplication Guest$ fastlane init
[10:06:28]: Detected iOS/Mac project in current directory...
[10:06:28]: This setup will help you get up and running in no time.
[10:06:28]: fastlane will check what tools you're already using and set up
[10:06:28]: the tool automatically for you. Have fun!
[10:06:28]: Created new folder './fastlane'.
[10:06:28]: $ xcodebuild clean -showBuildSettings -project ./testApplication.xcodeproj
Your Apple ID (e.g. fastlane@krausefx.com): .com
[10:06:47]: Verifying if app is available on the Apple Developer Portal and iTunes Connect...
[10:06:47]: Starting login with user<EMAIL_ADDRESS>+----------------+-----------------------------------------------------------------------+
|                                    Detected Values                                     |
+----------------+-----------------------------------------------------------------------+
| Apple ID       | @.com                                                  |
| App Name       | testApplication                                                       |
| App Identifier | ******.testApplication                                               |
| Project        | /Users/Guest/Desktop/testApplication/testApplication.xcodeproj |
+----------------+-----------------------------------------------------------------------+
[10:06:57]: This app identifier doesn't exist on iTunes Connect yet, it will be created for you
[10:06:57]: This app identifier doesn't exist on the Apple Developer Portal yet, it will be created for you
Please confirm the above values (y/n)
n
App Identifier (com.krausefx.app): com.testApplication
[10:07:33]: Created new file './fastlane/Appfile'. Edit it to manage your preferred app metadata information.
Would you like to create your app on iTunes Connect and the Developer
Portal? (y/n)
n
Optional: The scheme name of your app (If you don't need one, just hit
Enter): testApplication
[10:07:42]: 'snapshot' not enabled.
[10:07:42]: 'cocoapods' not enabled.
[10:07:42]: 'carthage' not enabled.
[10:07:42]: Created new file './fastlane/Fastfile'. Edit it to manage your own deployment lanes.
[10:07:42]: fastlane will send the number of errors for each action to
[10:07:42]: https://github.com/fastlane/enhancer to detect integration issues
[10:07:42]: No sensitive/private information will be uploaded
[10:07:42]: Successfully finished setting up fastlane

@Sea-Eagle Can you create a new issue for this problem? Thanks!


🪲 Bug Report - Start-WARACollector does not work correctly if specify only TenantID

Describe the bug
Start-WARACollector does not work correctly if specify only -TenantID to it. The $Scope_SubscriptionIds initialized as an empty array if subscription ID were not specified. So, the replace method cannot call.
https://github.com/Azure/Well-Architected-Reliability-Assessment/blob/e8f8120eeb95feabab1014b767f38de50c6364d7/src/modules/wara/wara.psm1#L79
$Scope_SubscriptionIds.replace('/subscriptions/', '')
$Scope_ImplicitSubscriptionIds.replace('/subscriptions/', '')

To Reproduce
Steps to reproduce the behavior:

Run Start-WARACollector without -SubscriptionIds parameter.

Expected behavior
Start-WARACollector does work correctly even if specify only -TenantID.
Screenshots 📷

Additional context
n/a

@tksh164 Thank you! I'll get this fixed today. We shouldn't be able to run the script without some type of scope below the level of tenantid. Great catch!


MigrateMessageCode to manage new case sensitive md5 hash

New strings found as per new case sensitive makeMessageCode() get a copy of old translation strings.
This ensure no regression in translation quality.
Related: #2

This looks fine at first glance, will review soon.
Was this tested extensively or not?

Was this tested extensively or not?

I made several manual tests over a dev installation based on sqlite - which I expect is more "strict" about table changes.
IMHO users should be explicitly alerted to make an export / a backup of their translation before apply this update, not just the usual !!!

@matteotrubini I merged #2 and wanted to merge this one, but there are conflicts that needs to be resolved.
Please let me know when it's done.

@matteotrubini @mjauvin whoops, didn't realize that branch was the target for this PR, this PR will need to be resubmitted against main. @mjauvin does having the changes from #2 already merged in break any existing installs or will it cause breakages to happen if this gets merged in after that one is already available?

not following you here @LukeTowers

@LukeTowers I'll reopen an updated PR in hours.
@mjauvin I'll also remove mb_strtolower() as discussed in #2, ok?


fix: validate pr source

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix: validate pr source
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.39%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2292

Relevant Lines:
2887

💛  - Coveralls


Does any one have an example app using RNRF & Mobx?

I am a react-native coder, recently,I want to use the new version RNRF and Mobx to my new App.But,I am not good at mobx, also, I do not know more about RNRF v4, I couldn't understand the documents clearly.
Any one have a example app use these(RNRF v4 & Mobx) or show me a link to learn these?
Thanks .

1 for this.


Hack

Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[ ] Your submissions are formatted according to the guidelines in the contributing guide
[ ] Your additions are ordered alphabetically
[ ] Your submission has a useful description
[ ] The description does not end with punctuation
[ ] Each table column should be padded with one space on either side
[ ] You have searched the repository for any relevant issues or pull requests
[ ] Any category you are creating has the minimum requirement of 3 items
[ ] All changes have been squashed into a single commit

Seems duplicated from your other PR?

Thanks for your contribution @tkacholga. Can you please resolve the conflicts?

@marekdano Should we close this?

Closing the PR as it's a duplicate one of #1110


Is there any example how to install pecl extension?

Question

I would like to know about is that there is no example for installing a pecl extension in php-vercel.

Hi. It's not possible to install or use pecl.

I think so, if i combine native pecl extension,  it might work. However I have to contribute aws-php.


Update build action versions

Description

Use checkout version 4.
Use MsBuild version 2.
Only build release on master branch (ignore PR's).

Related Issue

Motivation and Context

Keep actions up-to-date
How Has This Been Tested?

Screenshots (if appropriate):

Thank you!


[release-4.14] OCPBUGS-37076: Fixed audit-logs sigterm failing to terminate gracefully

This is a manual 4.14 cherry-pick of https://github.com/openshift/hypershift/pull/3972

/jira cherrypick OCPBUGS-33181

/jira refresh

/assign @rtheis

/retest-required

/retest-required

/approve


NCIM term for cell line "DOHH2" for IHECRE00004693

disease "Refractory Immunoblastic B Cell Lymphoma Progressed From Follicular Centroblastic/centrocytic Lymphoma", could use Follicular Lymphoma or immunoblastic lymphoma

The disease I have found for the DoHH2:
Disease: Lymphoma; Non-Hodgkin's
The NCIM term for the Non-Hodgkin Lymphoma is CUI C0024305.


Bug or undocumented behavior regarding mixing runtime variables and variables from templates ?

Hello,
I stumbled across a very weird bug or undocumented behavior.
I was trying to add a runtime variable to the list of variables in a stage, and it silently skipped the stage until I moved the runtime variable declaration after the inclusion of templates. The example below will make this clearer.
For context, we have several apps from a mono repo, and I want to release an app only if it actually changed.
# non-relevant properties omitted for brevity

# this version never worked and the stage was always silently skipped with no output
- stage: release_app_x
  dependsOn: prepare
  variables:
    # Here I expose an output variable from a previous stage...
    - name: apps
      value: $[ dependencies.prepare.outputs['prepare_job.ListApps.apps'] ]
    - template: ../variables/somefile.yml
    - template: ../variables/anotherfile.yml
  # ...to use it here to run the stage conditionally
  condition: contains(variables.apps, 'app_x')
  jobs:
  # ...

# this version works, and the only change is that the runtime variable is _after_ the `template:` statements
- stage: release_app_x
  dependsOn: prepare
  variables:
    - template: ../variables/somefile.yml
    - template: ../variables/anotherfile.yml
    # Variable moved _after_ the `template:` statements
    - name: apps
      value: $[ dependencies.prepare.outputs['prepare_job.ListApps.apps'] ]
  condition: contains(variables.apps, 'app_x')
  jobs:
  # ...

The docs states:

[...] but you can combine name, group, and template when using list syntax.

Is it expected behavior that template must come before name ? Is it a bug ?
--edit: we verified that the apps variable didn't exist in the templates in case of a shadowing, it doesn't.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0029948d-6054-90c7-1dd1-450177589741
Version Independent ID: 0029948d-6054-90c7-1dd1-450177589741
Content: variables definition
Content Source: content/variables.md
Service: azure-devops-pipelines
GitHub Login: @steved0x
Microsoft Alias: sdanie

@DjebbZ I can't reproduce the issue that you are having (I was attempting to build a complete running repro that I could submit to the product team) Can you take a look and let me know if I have missed something (your example doesn't show the initial stage that yields the output variable so maybe I have gotten it a little bit wrong?)
# Starter pipeline
# Start with a minimal pipeline that you can customize to build and deploy your code.
# Add steps that build, run tests, deploy, and more:
# https://aka.ms/yaml

trigger: none

pool:
  vmImage: ubuntu-latest

stages:
- stage: Stage1
  jobs:
  - job: Job1
    steps:
    - bash: echo "##vso[task.setvariable variable=s1output;isOutput=true]app_x present"
      name: Bash1
    - bash: echo $(Bash1.s1output)

- stage: Stage2
  dependsOn: Stage1
  variables:
  - template: variables_template_1.yml
  - template: variables_template_2.yml
  - name: apps
    value: $[ dependencies.Stage1.outputs['Job1.Bash1.s1output'] ]
  condition: contains(variables.apps, 'app_x')
  jobs:
  - job: Stage2Job1
    steps:
    - bash: echo "$(varT1) - $(varT2)"
    - bash: echo $(apps)

- stage: Stage3
  dependsOn: Stage1
  variables:
  - name: apps
    value: $[ dependencies.Stage1.outputs['Job1.Bash1.s1output'] ]
  - template: variables_template_1.yml
  - template: variables_template_2.yml
  condition: contains(variables.apps, 'app_x')
  jobs:
  - job: Stage2Job1
    steps:
    - bash: echo "$(varT1) - $(varT2)"

variables:
  varT1: 'Variable value from template 1'

variables:
  varT2: 'Variable value from template 2'

Another interesting thing I observed, in this section:
  condition: contains(variables.apps, 'app_x')
  jobs:
  - job: Stage2Job1
    steps:
    - bash: echo "$(varT1) - $(varT2)"
    - bash: echo $(apps)

This line    - bash: echo $(apps)' produces and empty output unless I comment out the condition that first references that variable. Then it produces the desired output. That behavior seems unusual. Is there any other use of theapps` variable in the stage or do you just use it for the condition?

I made two more pipelines, using the same names as yours, so that if I missed something it would be more apparent. They both run both stages. I will still file a report describing the issue but if I can get a running example that has the same issue, that would be a great help. Thank you.
trigger: none

pool:
  vmImage: ubuntu-latest

stages:
- stage: prepare
  jobs:
  - job: prepare_job
    steps:
    - bash: echo "##vso[task.setvariable variable=apps;isOutput=true]app_x present"
      name: ListApps
    - bash: echo $(ListApps.apps)

- stage: release_app_x
  dependsOn: prepare
  variables:
  - name: apps
    value: $[ dependencies.prepare.outputs['prepare_job.ListApps.apps'] ]
  - template: variables_template_1.yml
  - template: variables_template_2.yml
  condition: contains(variables.apps, 'app_x')
  jobs:
  - job: Stage2Job1
    steps:
    - bash: echo "$(varT1) - $(varT2)"

trigger: none

pool:
  vmImage: ubuntu-latest

stages:
- stage: prepare
  jobs:
  - job: prepare_job
    steps:
    - bash: echo "##vso[task.setvariable variable=apps;isOutput=true]app_x present"
      name: ListApps
    - bash: echo $(ListApps.apps)

- stage: release_app_x
  dependsOn: prepare
  variables:
  - template: variables_template_1.yml
  - template: variables_template_2.yml
  - name: apps
    value: $[ dependencies.prepare.outputs['prepare_job.ListApps.apps'] ]
  condition: contains(variables.apps, 'app_x')
  jobs:
  - job: Stage2Job1
    steps:
    - bash: echo "$(varT1) - $(varT2)"

I've filed a report on this internally, I am going to close this issue for now.


No TLS support yet

The code doesn't currently support TLS.  We probably should support listening on multiple different sockets with a flag specifying which sockets are TLS.  That way we can listen on 80, 443, 8000, 8080, an 8443.

looks like we would need to add
import (
"crypto/tls"
)
cer, err := tls.LoadX509KeyPair("server.crt", "server.key")
config := &tls.Config{Certificates: []tls.Certificate{cer}}
ln, err := tls.Listen("tcp", ":443", config)
after that its handled the same as http
Need to test this first

I think we will have to run the all the listeners in different go routine, so that they could run at the same time without causing issues.

Yeah I agree, we should have a list of interface + port + protocols to listen on and then iterate over each spawing a goroutine to do the listening and accept on each.

TLS support has been added as of commit 39767c2b9eb25efee823f72ae33ee7778a058c6d


Small issue with code from blog post

Hey, Binyamin. I read your article Filter Posts by tag and implemented the search by data-tags feature on my site. It works great!
I did notice one minor issue. When attempting to use filter on the NodeList from querySelectorAll, it throws an error that posts is not a generic array and doesn't have access to array methods like filter (since its a NodeList).
const posts = document.querySelectorAll(".post");
...
let postsNoTag = posts.filter(l => {
        return JSON.parse(l.dataset.tags).includes(tag) === false;
    });

Solution 1:
Convert the posts NodeList (which is iterable) into an array
const posts = [...document.querySelectorAll(".post")];

Solution 2:
Apply filter on the static results of the posts NodeList
let postsNoTag = Array.prototype.filter.call(posts, function(l) {
        return JSON.parse(l.dataset.tags).includes(tag) === false;
    });

Solution 3:
Use the good ole Array.from() method.
const posts = Array.from(document.querySelectorAll(".post");

Maybe something to note in the article, or just update to one of the above solutions. Let me know your thoughts @binyamin

@tannerdolby Good catch! I prefer version one. What are your thoughts?

@binyamin Thanks! I prefer the first version as well.
All three of the solutions are viable and of relatively equal performance, but all we really need to do is make the iterable NodeList object into an array. Which is why I think [...document.querySelectorAll(".posts")] is probably the best.
It only requires the spread syntax ... and an array literal [...]. Using Array.from() would be fine, but option 1 makes the most sense (especially if people aren't familiar with iterable NodeList objects, which aren't genuine arrays that can't use generic array methods).

@tannerdolby Thanks so much!


what's the proper way to package completions?

See https://github.com/arighi/virtme-ng/pull/181 for context.
virtme-ng wants to generate bash completion during its build, but it's not exactly clear how to do that using argcomplete. Compare this to argparse-manpage which provides instructions and library entry points to integration with build systems.
Is there any guidance available on this?

Hi, thanks for your interest in argcomplete. I tried to read the issue you linked and the statements you made, but I'm having trouble understanding the question. Generally, packages that depend on argcomplete use the package manager (pip, etc.) to specify the dependency, and then use the argcomplete protocol to generate completions at runtime. There is nothing to do at build time. I think it might help if you review how argcomplete works and reframe your question in terms of what exactly you're trying to accomplish using argcomplete.

I think you understood exactly right. virtme-ng isn't my project, but for better or for worse it is currently building completions at build time and packaging them in the distribution.
I'm also not sure how argcomplete can be used to generate completions at runtime in a way that's invisible to the end user - from what I can tell, the end user always has to do something to enable argcomplete in their shell.
I see two possible answers here: there is a way to generate completions transparently and virtme-ng should just do that, or else there's an unmet need for building completions ahead of time and this can be turned into a feature request in argcomplete.
What do you think?

I'm not sure what you mean by "generate completions transparently", but argcomplete is not useful or intended for building completions ahead of time. Such completions would by definition be static and you can contribute them directly to bash-completion or zsh-completions. argcomplete is intended as a general purpose dynamic completion generator. I don't think a feature request to build completions ahead of time would be fulfilled, although I'm open to considering more specific ideas.
When using an OS package manager, it's not strictly necessary for the user to explicitly enable argcomplete in their shell. An application using argcomplete could add a profile.d entry that runs eval "$(register-python-argcomplete my-python-app)". When using pip, this is strongly discouraged since by convention PyPI/pip packages should not modify the system environment outside their package.
I'm going to close this issue for now since it does not seem to indicate a problem with argcomplete.

Thinking about this more, I recall this topic coming up a few times in the past. I think at minimum I'll add a documentation section drawing the distinction between static and dynamic completions, and giving people an idea of how to install a static completion module into the existing frameworks (bash-completions and the zsh completion paths).
Also, just to clarify, for pip packages, configuring things system-wide is discouraged at install time. You could still have a command like my-python-app install-completions that would install the static completions into zsh or bash (or add the dynamic completion hook eval "$(register-python-argcomplete my-python-app)" to the user's rc file).

Also, just to clarify, for pip packages, configuring things system-wide is discouraged at install time. You could still have a command like my-python-app install-completions that would install the static completions into zsh or bash (or add the dynamic completion hook eval "$(register-python-argcomplete my-python-app)" to the user's rc file).

Yep, this makes sense to me. You'd be amazed how much grief I got for making virtme-ng hermetic. Whether we like it or not there are some people who are happy to make a mess of their system for the sake of convenience.
Anyway I think addressing this desire - whether in docs or otherwise - would be very good.


[#8] Add Flow to Combine wrapper for ViewModel

#8
What happened

Add supporting files for using KMM ViewModel with SwiftUI.

Insight

Wrap ViewModel Flow properties to AnyPublisher.
Use https://github.com/touchlab/KaMPKit template.

Proof of Work
https://user-images.githubusercontent.com/6356137/191666748-787de784-07cc-462a-9652-d4b78d78541b.mov
https://user-images.githubusercontent.com/6356137/191666792-68580ec6-f265-4ddb-a676-6c9fe14170e3.mov

Don't need this as KMPCoroutine covers everything already.


fix(02): fix typos; fixes leanprover/lean#948

Sorry, it looks like I never updated the tutorial with the new notation for "image". But now it passes all the tests.


Mention gitops sync workaround in chains readme

Doing this helps the Gitops sync complete, otherwise you get
endless failure:
one or more objects failed to apply, reason: namespaces
"application-service" not found. Retrying attempt #432 at 7:25PM.
I believe it's because the pvc-cleaner objects try to use the
application-service namespace which isn't created if you don't
install the has appliction.

Should be fixed by #241 (but not sure how long it will take to finish it)

I mentioned the #241 fix in the readme.

It's a readme change, so low risk. Let's merge.


rs_setbandnodatavalue not working as expected

Expected behavior
Expected the band values to be updated with new value provided where it has no data.
Actual behavior
Trying to sum couple of  raster's 1st band value. Band value is float type and "-3.4028230607370965e+38" is the no data value of the band.
Sum value comes out to -inf since it is summing the no data value.
Tried using rs_setbandnodatavalue to set no data value as 0.0 and then perform sum but cant see the values updated in the band.
df_sedona1 = sedona.read.format("binaryFile").load(vSourcePath1)
.withColumn("raster1", expr("rs_setbandnodatavalue(RS_FromGeoTiff(content),1,0.0)"))
.withColumn("ID", expr("1"))
.withColumn("raster1arr", expr("RS_BandAsArray(raster1,1)"))
.select("ID","raster1", "raster1arr")
...
select RS_Count(raster1,1,True) as cells_withdata
,RS_Count(raster1,1,False) total_cells
,RS_BandNoDataValue(raster1,1) as nodatavalue
from file1
Before using setnodatavalue
225589
12325690
-3.4028230607370965E38
after using setnodatvalue
12325690
12325690
0.0
==> It picked 0.0 as the nodatavalue for the raster but also noticed all cells have been identified as cells with data?
..
band1 = df_sedona1.selectExpr("RS_BandAsArray(raster1, 1)").first()[0]
print(band1[1:50],)
returns array with ""-3.4028230607370965e+38" present it.
==> Didnt expect to see any -3.4028230607370965e+38 in the array values
Settings
Sedona version = 1.5.0
Apache Spark version = 3.5.0
API type = SQL
Scala version = 2.12
Environment = Azure Databricks

@chitra-psg While we are investigating this, can you retry RS_SummaryStats? https://sedona.apache.org/1.5.0/api/sql/Raster-operators/?h=rs_summarystats#rs_summarystats
RS_SummaryStats can return the sum of a band and it also can exclude no data values.

@chitra-psg The current behavior of RS_SetBandNoDataValue works as expected. It is not supposed to replace the old values. But we will add a replace option to actually replace them. Created a JIRA ticket for it: https://issues.apache.org/jira/browse/SEDONA-448


workaround RN bug that broke pasting into confirm new password input

It seems if the placeholder takes up the entire width of the textinput, the context menu doesn't appear. Workaround by shortening "Confirm new password" to "Confirm"

[x] Check other password inputs

@keybase/react-hackers ready for review


Add single cell RNAseq tutorial in startbio

Add ressources for the single cell RNAseq analysis from the tutorial present in https://github.com/ARTbio/celebration/blob/master/Companionship/sc_basics.Rmd
To be solved :

[x] Identations
[x] Image paths
[x] Equations
[x] Tables
[x] CellMarker results

It's good for me, unless I notice that we need to update the webpage in order to display properly equations...


csi-manila: deployment manifests refactoring + helm chart

What this PR does / why we need it:
This PR adds no new features to csi-manila, but only adds a Helm chart under examples/manila-csi-plugin/helm-deployment and refactors deployment manifests + updates the docs accordingly.
Manifests in manifests/manila-csi-plugin are generated from the Helm chart.
Why is the Helm chart needed:

as it's mentioned in the documentation, CSI Manila may serve only a single share protocol per plugin instance. If an operator wants access to multiple share protocols, multiple deployments need to be made. This requires numerous changes to the manifests which can be quite cumbersome
the chart solves this by deploying the driver + its sidecar containers per share protocol (see examples/manila-csi-plugin/helm-deployment/values.yaml)

This PR also addresses comments from https://github.com/kubernetes/cloud-provider-openstack/pull/652 where we agreed to do changes regarding deployment in a separate PR (i.e. this one), notably:

changes to manifests requested in https://github.com/kubernetes/cloud-provider-openstack/pull/652#discussion_r302387455 , https://github.com/kubernetes/cloud-provider-openstack/pull/652#discussion_r302388003 , https://github.com/kubernetes/cloud-provider-openstack/pull/652#discussion_r302389332
docs updated to address https://github.com/kubernetes/cloud-provider-openstack/pull/652#discussion_r302387565

We're now following similar "2-component" deployment as CSI Cinder does:

Controller plugin (StatefulSet) now contains the CSI Manila plugin itself along with csi-provisioner, csi-snapshotter. csi-attacher has been removed because volume attachments are not needed. CSIDriver CRD is used to pass the attachRequired: false option to k8s,
Node plugin (DaemonSet) contains the CSI Manila plugin and csi-node-driver-registrar

NONE

PTAL @tsmetana @adisky @ramineni

I'm fully in support of this.

/ok-to-test

Nice work, and thanks for addressing gouthampacha's comments.  The helm chart makes it a lot more straightforward to do multi-protocol deployments!

/approve

/lgtm
thanks for the work, it's really helpful for the users.


Tribute Page Project Instruction about using figure tag

Affected page
Add a link to the coding challenge with the problem.
https://www.freecodecamp.org/learn/responsive-web-design/responsive-web-design-projects/build-a-tribute-page
User Story no. 3 mentions using a div tag with id="img-div" but your test and sample allow and uses a <figure> tag. The instruction needs to reflect this change.

I guess that's true. We (sort of silently) added the support for the figure element to allow for more semantic HTML. The problem is the awkwardly named id which we can't change without breaking backward compatibility with already finished projects.

User Story #3: I should see a div or figure element with a corresponding id="img-div".

Asking the student to add a figure element with an id of img-div is awkward. But I guess there really isn't much we can do about it. I'm willing to allow the addition to the user story.

We have been discussing avoiding showing the source code of the Pens altogether - this came up during a contributors meeting.
Yes - we should align the instructions as closely as possible with source/example templates but it often leads to users peeking under the hood. That's not necessarily a bad thing, but it often causes nuanced issues such as this where would be doing breaking non-compatible changes.
I think we should close this issue as a wontfix because of the legacy reasons, but I will seek an opinion from @moT01 first.

It looks like the test will allow any element as long as the id is correct:
it(`I should see either a <figure> or <div> element with corresponding
id="img-div".`, function () {
  assert.isNotNull(document.getElementById('img-div'));
});

In the test suite, user story 3 says what @lasjorg mentioned:

It looks like user story 5 has a similar issue, the test suite doesn't match what's on the website. Again, this test just looks for the id. I do think something could be done here since the user stories don't align in the two spots. I kind of feel like we should just change user story 3 to:
I should see a figure element with a corresponding id="img-div".
and user story 5 to:
Within the "img-div" element, I should see a <figcaption> element with a corresponding id="img-caption" that contains textual content describing the image shown in "img-div".
Since those are probably the more "better practice" elements to use. This change would need to be done in both spots - and since the tests allow any element, no old projects would break. Although, like mentioned - the id names seem a little goofy if we do that, so the other option would be to just change what's on the website to match the test suite. I guess I'm kind of leaning towards doing that now since it would be easier. What do you think @navjotjsingh & @lasjorg - any other thoughts or ideas?

I updated this project 2 years ago and we haven't had any issues with the changes as far as I know.
When I did the update I improved the HTML semantics and initially was planning to update the user stories and tests. In order to support the legacy version of the project, I wanted to conditionally test for it. But at the time it was deemed simpler to just leave as many of the old tests as-is instead.
I don't think it would be too much work to update user stories and tests so we require semantic elements with new ids but still allow legacy projects to pass. The legacy project tests would be hidden from anyone currently doing the project and they would not know about the old requirements and user stories. But I'm not sure if it's really worth it as it will inevitably increase the complexity of the tests and their maintenance.
This is such a simple project and most people doing this project are super new to coding. Most people that do notice any discrepancies with our projects are not beginners.

Thanks, everyone. Closing as a wontfix.


Do not overwrite identical files

If _render_allowed identifies identical source and target, then only returns True if the path refers to a directory, not a file.

Just a test is missing (see https://github.com/copier-org/copier/discussions/1092#discussioncomment-9027925).
Resolves #1092.

Cool! Do you know how to add the test then?

Cool! Do you know how to add the test then?

I would use the testcase: test_skip_if_exists as an example, and write something along the lines of:
def test_timestamp_identical(tmp_path: Path) -> None:
    copier.run_copy(str(Path("tests", "demo_skip_dst")), tmp_path)
    modification_time_before = ...
    sleep(2)
    copier.run_copy(str(Path("tests", "demo_skip_dst")), tmp_path)
    modification_time_after = ...

    assert modification_time_before == modification_time_after

Does it make sense?

Ok
El lun, 8 abr 2024, 3:17, Andras Gefferth @.***>
escribió:

Cool! Do you know how to add the test then?
I would use the testcase: test_skip_if_exists
https://github.com/copier-org/copier/blob/master/tests/test_copy.py#L285
as an example, and write something along the lines of:
def test_timestamp_identical(tmp_path: Path) -> None:
copier.run_copy(str(Path("tests", "demo_skip_dst")), tmp_path)
modification_time_before = ...
sleep(2)
copier.run_copy(str(Path("tests", "demo_skip_dst")), tmp_path)
modification_time_after = ...
assert modification_time_before == modification_time_after

Does it make sense?
—
Reply to this email directly, view it on GitHub
https://github.com/copier-org/copier/pull/1576#issuecomment-2041745619,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHNXDLIVFV47LTXYJAHL3TY4H42NAVCNFSM6AAAAABF24WGXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRG42DKNRRHE
.
You are receiving this because you commented.Message ID:
@.***>


Patch 1

Change formatting of the detailed description of the lines in the time explicit paragraph to match the formatting in the wavelength explicit paragraph.
Also fix a small error in the wavelength explicit paragraph.

Thanks for catching this error! Funny thing is, I actually fixed it before back when the documentation was still hosted on a dokuwiki instance, but then the spambots came and mangled up the page … apparently I restored a version from before my fixes to this page, so glad you spotted them! I'll merge your commits in.
Meanwhile, welcome to the glotaran community, if you like, please feel free to reach out at<EMAIL_ADDRESS>


Changes to the downstream namespace generation

This PR changes the pattern used to generate the downstream namespace. It generates a shorter string while maintaining a big enough random part to avoid conflicts.
related: https://github.com/kcp-dev/kcp/issues/1280

@jmprusi what is the status of this vs. #1309? Are you closing 1309, or ... ?

@ncdc I'm splitting it as I'm running into a problem with the namespace locator struct. I prefer  to unblock some of the folks that are running into issues with the namespace length, and take some time to fix the other changes.

Seems reasonable but will break previous syncer deployments, right?

@sttts yes, I have another Branch with those changes, I've run into a bug and I wanted to get this change into the release, but as @stevekuznetsov points out, this change will cause the duplication of all the resources... as the status syncer will read the value from the namespace locator, so it will work, but the spec syncer will create a new namespace using the new pattern.
We can document this as a required step or wait for the final version, that doesn't require a "migration"...
Let's wait for the full functionality?

let's keep the #1309 with the full functionality to make it easier to migrate from a previous version.


feature: add space manager context flag, update logging, change kubeconfig default

Feature Description
This issue describe a number of relatively minor changes that we would like to implement as part of the kubestellar switch to using the space framework.

Add a space manager context flag to cmd/space-manager (space-manager -kubeconfig $KUBECONFIG -context $space_mgt_context -v=2)
Fix the space manager logging.  The current implementation is missing a call to klog.InitFlags()
change the code that determnes the kubeconfig default to using $KUBECONFIG
update the defaultProviderNS to spaceprovider-default.

Proposed Solution
.
Want to contribute?

[X] I would like to work on this issue.

Additional Context
No response

is this slated for completion by Sept. 1st (Sprint 3 end)?

@clubanderson yes.

Merged by PR #878


Increment i before return True

The counter does not get incremented at all at the moment

There doesn't seem to be any tests for htmlelement.go, so I haven't added one. If I have somehow missed them, please let me know.


SDL_Gpu and Shader Compiling

Hey there, hope you don't mind me asking this question here. I was quite interested in SDL's idea to implement a shader compiler (https://github.com/libsdl-org/SDL_shader_tools) so you could have one function for SDL_GpuCompileShader. After inspecting the rough sketch of the WIP 3D API (https://github.com/icculus/SDL/blob/gpu-api/include/SDL_gpu.h) it looks like it's mostly following Metal's API design and turned out very similar to sokol_gfx.h.
I'm wondering if you had any thoughts about potentially changing things up a bit with sokol_gfx. So far I'd say the most difficult part is hooking up the offline tool sokol-shdc. I find SDL's idea really cool. One thing I've seen done in single-file headers is to test to see if another header has been included yet, and offer some wrapper functions to hook it up if so. One idea is that maybe sokol_gfx.h could have a wrapping around creating a shader with SDL's shader compiler.
The whole SPIR-V thing just seems way too complex and overkill and has rather heavy dependencies.
Personally I'm wondering if SDL's strategy of generating bytecode is also overkill for the task at-hand. The vast majority of shaders myself and my colleagues are interested in are very simple shaders. In many cases I believe there to be fairly straightforward 1:1 mappings.

Yeah! I didn't really keep track of SDL_gpu progress recently, but if the shader compiler part can be ripped out and put into its own library, then I'll definitely add support for it to sokol_gfx.h somehow (an obvious first step would be to integrate it into sokol-shdc as a separate language frontend instead of GLSL).
For sokol_gfx.h integration, I would prefer to keep the current philosophy of feeding backend-specific shader blobs into the sokol-gfx API, but those backend specific shader blobs could be provided by a new header which wraps the SDL shader compiler into a sokol-friendly API (e.g. taking SDL shader sources as input and returning an sg_shader_desc struct which can be plugged directly into sg_make_shader()).


Separate HdfsSnapshotStore as akka-persistence-hdfs

Snapshots can be also stored directly to HDFS, if they are really big or you need "easy takeout".

@ktoso do you plan on making the accumulation of events work on hdfs too, or just snapshots?

Putting events onto HDFS is not optimal I think, HBase performs way better for such operations (SCANs). I'd be inclined to say no to the feature of events directly on HDFS. (see my talk about avoiding hot-spotting http://www.slideshare.net/ktoso/hbase-rowkey-design-for-akka-persistence )

I was thinking since journaling is writing a consistent stream (nothing random), it would be an good fit. I  was thinking it would function similar to HBase's use of HDFS for it's WAL, since they are essentially the same thing.  But you'd probably end up to write a lot of code to make it efficient and preserve the semantics.
Yeah I am familiar with region hotspotting, was more curious abt using HDFS directly.

I think I'd end up reimplementing a lot of what hbase does when trying to implement this.
I always viewed hbase as "the best way to scan across HDFS".
If we'd naively just append to a file in HDFS I think we'd bump into hot-spotting anyway - directly overloading one datanode more than another one.
I may be wrong, please correct me (code very welcome) if that's the case here :-)


Add Hyperlink to Office.FileDialog.md

Added hyperlink to FileDialogType (https://docs.microsoft.com/en-us/office/vba/api/office.msofiledialogtype)

Docs Build status updates of commit cb8a4af:
:warning: Validation status: warnings

File
Status
Preview URL
Details

api/Office.FileDialog.md
:warning:Warning
View
Details

api/Office.FileDialog.md

Line 22, Column 209: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/office/vba/api/office.msofiledialogtype' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 22, Column 209: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/office/vba/api/office.msofiledialogtype' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

closing to fix suggestions

Docs Build status updates of commit cb8a4af:
:warning: Validation status: warnings

File
Status
Preview URL
Details

api/Office.FileDialog.md
:warning:Warning
View
Details

api/Office.FileDialog.md

Line 22, Column 209: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/office/vba/api/office.msofiledialogtype' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 22, Column 209: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/office/vba/api/office.msofiledialogtype' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a091e42:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/Office.FileDialog.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@noah-severyn Thanks for the improvement!


Adds NucleiSubset PIMPL

Is this pull request associated with an issue(s)?
No
Description
This adds a new backend to the NucleiView class which preserves the supersystem/subsystem relationship between the Nuclei objects aliased by two NucleiView objects.
TODOs
None. This is r2g.

🚀 [bumpr] Bumped! New version:v1.0.6 Changes:v1.0.5...v1.0.6


Support for watching multiple threads/goroutines simultaneously

This is more for discussion, and is kind of pie-in-the-sky, but since most Go programs are going to be highly parallel, the ability to split the terminal and show execution and source context of multiple threads or goroutines at the same time could be an interesting feature for debugging highly parallel programs.
Would like to open discussion on this, and get thoughts back.
/cc @pnasrat @ironcladlou @epipho @pmorie

Think about this a little it seems possible that you could easily hit the
same breakpoint in different goroutines. What then?
On Sun, May 3, 2015 at 1:03 PM Derek Parker<EMAIL_ADDRESS>wrote:

This is more for discussion, and is kind of pie-in-the-sky, but since most
Go programs are going to be highly parallel, the ability to split the
terminal and show execution and source context of multiple threads or
goroutines at the same time could be an interesting feature for debugging
highly parallel programs.
Would like to open discussion on this, and get thoughts back.
/cc @pnasrat https://github.com/pnasrat @ironcladlou
https://github.com/ironcladlou @epipho https://github.com/epipho
@pmorie https://github.com/pmorie
—
Reply to this email directly or view it on GitHub
https://github.com/derekparker/delve/issues/123.

If you're talking about splitting the terminal then it would be nice to see a tree of goroutines in a side panel, and a tree of packages, and a stacktrace, etc.

As another thought perhaps related to this: if I'm single-stepping a program with multiple goroutines, I often don't want started goroutines to continue - I would like to be able to decide which goroutines to step at any moment. Currently, to do this, I have to add a breakpoint to the start of any code that might be started in a goroutine, which can be hard if a go statement is calling a dynamic function.
I'd like to see a mode where any goroutines started from the goroutine currently being stepped are left halted until I decide to step them too.


iis installation

Hello, i tried to run this in IIS but having issue with ROOT_DIR pointing to http://my_ip**c/inetpub/wwwroot/**templates/default/css/castle-siege.css
i tried to change this but it says can't define functions after swapping. any suggestion? thanks

I created a fix for this
https://www.creandomu.com/index.php?topic=4397.msg17937#new


sqlite support (better memory usage)

This commit introduces jieba.initialize(sqlite = True|"/path/to/jieba.db")
Sqlite is implemented using SqlAlchemy to create two, indexed sqlite tables
in a single db file (default /tmp/jieba.db).
If the user does not choose sqlite, nothing will happen. Just default to
the in-memory version of Jieba.
Performance seems very good and Memory usage is much better.
I am using this in a mobile application. (The final DB file is about 24 MB,
which can be downloaded to the mobile application using after it is installed.)
Comments welcome!

It will be good if the memory cost is reduced. But I can see some problems in the code.

The SqlAlchemy breaks the zero dependency. You can try to use sqlite3 directly or at least wrap it in a try…except ImportError clause.
It seems that a user dictionary can be mixed up with the default dictionary.
The performance of the code is not well tested. Some of the function calls or if-clauses may reduce speed. This can be tested using various tools.
There's a print in L118, you can't do this in a library.

The code should be reviewed to ensure there's no obvious compatibility or performance problems.

Great comments! Thank you. I will try to make a new patch soon =)
Regarding comment #3: The patch still has the default dictionary as the default - there is no change there. Sqlite is only used for the cache, not the dictionary itself. If the user does not configure sqlite, then the cache will still be the old cache.

The point of # 2 (not 3) is that, if a user loads a user dictionary in app A, and he then loads the default one in app B, he will get the cache for the user dictionary instead of generate a new cache for the default dictionary. We currently use a MD5 hash for the file name of the cache for the user dictionary to prevent conflicts. (L103) You can follow this behavior.

Ah, yes. I see. Thanks.


Parameters passed to Git hook should be available in Action

I might be wrong but I could not find a way to access the parameters passed to the Git hook itself. Like, I am currently trying to implement a pre-push hook and need to know the remote where the push will happen to. Does Captain Hook expose that information?

Now it does :)
At least for PHP actions.
Update to the latest version 4.0.3 and use $io->getArguments()
For the index names have a look at the hook console command
https://github.com/CaptainHookPhp/captainhook/blob/176b02d129e0881685f6193bc1166aec86bed61e/src/Console/Command/Hook/PrePush.php#L41
For binaries I have to create some search replace logic like
myPrePushCommand --target={$target}
where I inject the original arguments upfront.

That was fast. Thanks man!

To be honest, I planned to do this for quite a while, I even thought it was already implemented when I read your message.
Original argument passing for binaries is coming up next

So I was half right, the binary part was the one that I already implemented.
If you want to pass original hook arguments to your binaries you can do so by using some {PLACEHOLDER}.
e.g.
myPrePush.sh --target={TARGET} --url={URL}

The placeholders are listed in the formatCommand PHPDoc block. Currently they don't get escaped, still unsure if they should.
    /**
     * Replace argument placeholder with their original values
     *
     * This replaces the hook argument placeholder.
     *  - prepare-commit-msg => FILE, MODE, HASH
     *  - commit-msg         => FILE
     *  - pre-push           => TARGET, URL
     *  - pre-commit         => -
     *
     * @param  string $command
     * @param  array  $args
     * @return string
     */
    protected function formatCommand(string $command, array $args) : string
    {
        foreach ($args as $key => $value) {
            $command = str_replace('{' . strtoupper($key) . '}', $value, $command);
        }
        return $command;
    }


The introduction is now always portable text.

Tidying after migration for https://github.com/microbit-foundation/python-editor-next/issues/332

This looks good locally and the code change seems fine. I'll review the PR branch in the morning.


cmd/go: thinks a reassigned variable is of the previous type

What version of Go are you using (go version)?

$ go version
go version go1.15.2 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/xxx/.cache/go-build"
GOENV="/home/xxx/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/xxx/gocode/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/xxx/gocode"
GOPRIVATE=""
GOPROXY="direct"
GOROOT="/home/xxx/go"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/home/xxx/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/xxx/gocode/src/gitlab.com/opennota/mt/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build629998084=/tmp/go-build -gno-record-gcc-switches"

What did you do?
https://play.golang.org/p/tWmhlKw98EN
What did you expect to see?
No compile-time error. At line 7 x (which has been reassigned) has the type map[interface{}]interface{}. If I change the name of the first variable to y, the program compiles:
https://play.golang.org/p/5gBNPVXN5os
What did you see instead?
A compiler error: invalid operation: x[0] (type interface {} does not support indexing)

That is how the language works.  See the "redeclare" discussion at https://golang.org/ref/spec#Short_variable_declarations.


Loading Celeste (pico-8)

Hi, Gigoteur!
I have found that PX8 is, with a LARGE difference, the best fantasy-console available on the Raspberry PI 3 in terms of performance: picolove is slooooow and buggy, for example, and your implementation is perfectly synchronized with the screen: smooth scrolls are smooth!
So I would REALLY love to use it to load Pico-8 games, too. However, Celeste, one of the first classics I tried from the Pico-8 (https://www.lexaloffle.com/bbs/?tid=2145), does not load ("Failed to load the cartidge").
Is there any possibility to run that game? I tried the "-m pico8" parameter with no luck...
Thanks!

Thank you
Running Celeste could be really interesting but I will need to fix all features to have the compatibility with pico8 (memory access etc) and the lua language modification too
But it is doable in the future !

I hope to see it soon... It has potential to become the best pico8 implementation available. The original pico8 has "pauses" on the Pi I can't diagnose because of the lack of sourcecode,

Hey, @hallucino, I could implement RAM, because I had big experience with that in the past time. But the thing is, your loader is really old now, and it doesn't properly load new carts (ver 9). It just gets stuck in a while loop.
Implementing RAM will mean much more faster access to VRAM also.

Hi, yes you're probably right but for this cart https://www.lexaloffle.com/bbs/cposts/1/15133.p8.png it seems still ok.
Feel free to work on it @egordorichev I'm still working on the code/sfx editor and I have less free time now

Oh, you are adding editors? Nice :) Will work on that on my free time.

@egordorichev do you want to do it ?

Ah, really busy with upcoming jams, sorry :(


Some contributions from Nick

Added some stuff! Also used the image resize feature, it's very nice, just add ?resize=800 to images.

Oops wrong target branch.


Pass data from middleware to handler

Is your feature request related to a problem? Please describe.
I have a middleware that checks and parse the JWT. I would like to pass from that middleware to the handler the parsed JWT so I don't need to parse it again. I saw that the fiber has this feature but I didn't saw anything related here.
Describe the solution you'd like
Be able to set in context some data that will be available in the next middleware or handler

Hey @stasandk 👋
Thanks for raising this. Your request is prioritized and this will be supported ASAP.

Awesome! Love the simplicity of this framework, good job @abahmed 👏🏼

@tomasky Gearbox v1.2.0 is released. It includes support for passing data from middleware to handler