[Bug]: The towhee.text_embedding model can not work on gpu? How to fix it?

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When I do all operators about text_embedding.transformers(). , its always on CPU
Expected Behavior
No response
Steps To Reproduce
No response
Environment
- Towhee version(e.g. v0.1.3 or 8b23a93):
- OS(Ubuntu or CentOS):
- CPU/Memory:
- GPU:
- Others:

Anything else?
No response

@check-777
could you please paste the error reported on your machine?

@check-777
You can try this with latest op:
text_embedding.transformers(model_name='xxx', device='cuda:0')

If it says no attribute "device", then clean towhee cache by removing rm -rf ~/.towhee/operators/text-embedding/transformers

I fix this problem by using HuggingFace transformer model instead of text_embedding.transformers
device = torch.device('cuda' if torch.cuda.is_available() else 'cpu') model = AutoModel.from_pretrained('bert-base-chinese').to(device) model.eval() tokenizer = AutoTokenizer.from_pretrained('bert-base-chinese') def Bert_Chinese(title):     inputs =  tokenizer(title, return_tensors="pt").to(device)     outs =  model(**inputs)     features = outs['pooler_output'].squeeze(0)     vec = features.cpu().detach().numpy()     return vec


Same description for both NoTracking and NoTrackingWithIdentityResolution

The descriptions are not clear enough to distinguish QueryTrackingBehavior Enum fields. In fact same description have been used for both NoTracking and NoTrackingWithIdentityResolution.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 36e6e00e-5cef-be1c-e2ea-adb97e356755
Version Independent ID: 6333e2cc-32d7-ef36-4198-926eb45a4255
Content: QueryTrackingBehavior Enum (Microsoft.EntityFrameworkCore)
Content Source: dotnet/xml/Microsoft.EntityFrameworkCore/QueryTrackingBehavior.xml
Product: ef-core-api
GitHub Login: @dotnet-bot
Microsoft Alias: avickers

Duplicate of https://github.com/dotnet/efcore/issues/31207


Fix code-completion suggesting non-static members for custom classes

Fixes #69928
This issue is a result of two problems: (1) global classes and class identifiers are not being marked as 'meta', so they are treated as class instances, and (2) signals are not considered non-static, so they are treated as constants. Since accessing signals from a class type causes an error, they should not be treated as constant/static.
This PR fixes these problems, which addresses the following auto-complete issues:

Non-static members being suggested for global class type and inner classes
Signals being suggested for global class types, preloaded scripts, native classes, and inner classes

Screencast from 2022-12-13 12-22-56.webm

Thanks!


use tl.writeFileSync() to allow mocking in L0 tests (don't merge till new vats-task-lib is published)

Looks good.

Yep.  Just need to adjust couple comments in task lib change, then I will publish then this can react and go in.

@bryanmacfarlane : Task lib changes and reaction are done

lib is published.
BTW, I think you added the file tests in the localization suite :)

Thanks for publishing the lib. I see the tests now, I added them after exists() tests which are also in the Localization suite. I will move both out of there :)


Piles ! Dirt slabs !

Brings the beloved dirt slabs to the mod. They can only be placed on a solid block. Place 2 dirt blocks in a row to craft 4 of them, or two piles of dirt to craft one. They can turn into grass slabs and mycelium slabs. When around snowy blocks, their top textures will become white to blend with the landscape.
Also, blocks of dirt/sand/gravel now drop piles, and grass only spreads in sunlight.

when you stack two dirt slabs does it make vanilla dirt or a "double slab" block?

I forgot the in game stacking. It will make vanilla dirt. Adding it right now.


[bug]: i cant install sd 3.5 large turbo

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Windows
GPU vendor
Nvidia (CUDA)
GPU model
rtx3060
GPU VRAM
6Gb
Version number
5.4.1
Browser
chrome
Python dependencies
No response
What happened
i cant install sd 3.5 large turbo
i get error: Cannot determine base type
What you expected to happen
I expexted for model will be install
How to reproduce the problem
No response
Additional context
No response
Discord username
No response

Im having the same problem with SD3.5 large
I'm using InvokeAi V5.4.2 within  Stability Matrix. When I use 'Add Model' -> 'scan folder' Invoke finds the file but fails to import it.

Same issue but I have no issues with 3.5 large and medium, just turbo can't be imported. Works fine in Comfy.

using with matrix i had to have my huggingface token setup first

using without matrix just invoke itself i had to have my huggingface token setup first

Thanks for the suggestion, I had already set it up, and I have just checked on Hugging face and it looks OK

Do they support Safetensors format for SD 3.5? What they install from the model manager that they have setup are the Diffusers version.

it looks like a clone of the hugginface repo


Flame Blade Dervish

https://www.d20pfsrd.com/feats/combat-feats/flame-blade-dervish-combat/
The real interest is the Cha modifier to damage rolls with flame blade. Possibly +10 ft enhancement bonus to speed, +4 competance to acrobatics (mobility?) for flavour. The resistance portions appear painful to implement and are well covered by the ascendent element mythic power.

Thankyou so much you are amazing
I can confirm that the mobility and speed bonus are working.
However Flame blade dervish is adding the higher of cha or wis for some reason.

Druid and shaman are wisdom based classes. Why would it scale with charisma? Seems weird to me. For now I just use the highest mental score. Might change, need to think about this.
 The code looks simple. Didn't test it tho.
Also, I think about looking at Gozreh's Trident, Produce Flame, and Chill Touch. Do you know by chance if anyone else has made any of these spells?

That's a good point.
The basic ignore first 10 resistance works but I'm not sure about the first 30 against undead.
I can't find any undead with fire resistance.
No mods that I know of have implemented those spells.


[BUG] Memoryview clear unnecessarily acquiring GIL

Describe the bug
Full context: https://stackoverflow.com/questions/76972950/cython-returned-memoryview-is-always-considered-uninitialized/76974615
I'm upgrading to Cython 3 and noticing a few new yellow areas in the annotation HTML that make it look like the GIL is being acquired more than it used to and in cases that I believe it is unnecessary.
It has been explained to me that the the function in my code below that returns a memory view is only acquiring the GIL in the error case. I still think with all the compiler flags I have that this shouldn't happen (I know my memoryview is initialized, I know the size of it, I know this is a read-only not-owned subset view of the memory), but I can live with it since it theoretically shouldn't have a significant effect on performance.
However, in the calling function _run I noticed that it is always acquiring the GIL to clear the memory view even in the success case:
  /* function exit code */
  goto __pyx_L0;
  __pyx_L1_error:;
  #ifdef WITH_THREAD
  __pyx_gilstate_save = __Pyx_PyGILState_Ensure();
  #endif
  __PYX_XCLEAR_MEMVIEW(&__pyx_t_1, 1);
  __Pyx_WriteUnraisable("cython_test._run", __pyx_clineno, __pyx_lineno, __pyx_filename, 1, 0);
  #ifdef WITH_THREAD
  __Pyx_PyGILState_Release(__pyx_gilstate_save);
  #endif
  __pyx_L0:;
  #ifdef WITH_THREAD
  __pyx_gilstate_save = __Pyx_PyGILState_Ensure();
  #endif
  __PYX_XCLEAR_MEMVIEW(&__pyx_v_tmp, 1);
  #ifdef WITH_THREAD
  __Pyx_PyGILState_Release(__pyx_gilstate_save);
  #endif

In profiling my (dask-based) code it is very clear that this is preventing my threads from processing data simultaneously so this one hurts more than the failure case of the other function.
I understand that memoryview handling has changed a lot in Cython 3.x, but Cython 0.29.x did not have this GIL acquire code here and it passed , 0) to the __PYX_X_CLEAR_MEMVIEW function.
Code to reproduce the behaviour:
# cython: language_level=3, boundscheck=False, cdivision=True, wraparound=False, initializedcheck=False, nonecheck=False
cimport cython
from cython cimport floating
import numpy as np
cimport numpy as np

np.import_array()

def test_func():
    cdef np.ndarray[float, ndim=2] arr = np.zeros((5, 5), dtype=np.float32)
    cdef float[:, ::1] arr_view = arr
    _run(arr_view)

cdef void _run(floating[:, ::1] arr_view) noexcept nogil:
    cdef floating[:, :] tmp = _get_upper_left_corner(arr_view)

cdef inline floating[:, :] _get_upper_left_corner(floating[:, ::1] arr) noexcept nogil:
    return arr[:1, :1]

Expected behaviour
Minimal (no?) GIL acquiring when working with memoryviews.
OS
Linux
Python version
3.11
Cython version
3.0.0
Additional context
Installed from conda-forge.

I also wanted to mention that if this isn't intentional, but there is no time to figure out why this is happening I'm willing to track it down if someone could just point me in the right direction on where to look in the code base.

I'm pretty sure it isn't intentional (at least in the success path - the error path needs the GIL for writeunraisable so may as well have it for the whole thing).
My usual approach to working out where to look is to add a conditional break point in CCodeWriter.write - conditional on the string you think this wrong (probably   __PYX_XCLEAR_MEMVIEW(&__pyx_v_tmp, 1); and this'll take you to where the code is generated.

My usual approach to working out where to look is to add a conditional break point in CCodeWriter.write - conditional on the string you think this wrong (probably   __PYX_XCLEAR_MEMVIEW(&__pyx_v_tmp, 1); and this'll take you to where the code is generated.

I was able to dig out the code. So the following C line:
__PYX_XCLEAR_MEMVIEW(&__pyx_v_tmp, 1);

Is generated via following stacktrace:
  /Users/matus/dev/cython39/bin/cython(33)<module>()
-> sys.exit(load_entry_point('Cython', 'console_scripts', 'cython')())
  /Users/matus/dev/cython/Cython/Compiler/Main.py(757)setuptools_main()
-> return main(command_line = 1)
  /Users/matus/dev/cython/Cython/Compiler/Main.py(785)main()
-> result = compile(sources, options)
  /Users/matus/dev/cython/Cython/Compiler/Main.py(676)compile()
-> return compile_multiple(source, options)
  /Users/matus/dev/cython/Cython/Compiler/Main.py(650)compile_multiple()
-> result = run_pipeline(source, options,
  /Users/matus/dev/cython/Cython/Compiler/Main.py(542)run_pipeline()
-> err, enddata = Pipeline.run_pipeline(pipeline, source)
  /Users/matus/dev/cython/Cython/Compiler/Pipeline.py(398)run_pipeline()
-> data = run(phase, data)
  /Users/matus/dev/cython/Cython/Compiler/Pipeline.py(375)run()
-> return phase(data)
  /Users/matus/dev/cython/Cython/Compiler/Pipeline.py(52)generate_pyx_code_stage()
-> module_node.process_implementation(options, result)
  /Users/matus/dev/cython/Cython/Compiler/ModuleNode.py(222)process_implementation()
-> self.generate_c_code(env, options, result)
  /Users/matus/dev/cython/Cython/Compiler/ModuleNode.py(516)generate_c_code()
-> self.body.generate_function_definitions(env, code)
  /Users/matus/dev/cython/Cython/Compiler/Nodes.py(404)generate_function_definitions()
-> stat.generate_function_definitions(env, code)
  /Users/matus/dev/cython/Cython/Compiler/Nodes.py(404)generate_function_definitions()
-> stat.generate_function_definitions(env, code)
  /Users/matus/dev/cython/Cython/Compiler/FusedNode.py(964)generate_function_definitions()
-> stat.generate_function_definitions(env, code)
  /Users/matus/dev/cython/Cython/Compiler/Nodes.py(2368)generate_function_definitions()
-> code.put_var_xdecref(entry, have_gil=gil_owned['success'])
  /Users/matus/dev/cython/Cython/Compiler/Code.py(2260)put_var_xdecref()
-> self.put_xdecref(entry.cname, entry.type, **kwds)
  /Users/matus/dev/cython/Cython/Compiler/Code.py(2215)put_xdecref()
-> type.generate_xdecref(self, cname, nanny=nanny, have_gil=have_gil)
> /Users/matus/dev/cython/Cython/Compiler/PyrexTypes.py(1138)generate_xdecref()
-> code.putln("__PYX_XCLEAR_MEMVIEW(&%s, %d);" % (cname, int(have_gil)))

So the following GIL lock code:
  __pyx_L1_error:;
  #ifdef WITH_THREAD
  __pyx_gilstate_save = __Pyx_PyGILState_Ensure();
  #endif
  __PYX_XCLEAR_MEMVIEW(&__pyx_t_1, 1);
  __Pyx_WriteUnraisable("test._run", __pyx_clineno, __pyx_lineno, __pyx_filename, 1, 0);
  #ifdef WITH_THREAD
  __Pyx_PyGILState_Release(__pyx_gilstate_save);
  #endif
  __pyx_L0:;
  #ifdef WITH_THREAD
  __pyx_gilstate_save = __Pyx_PyGILState_Ensure();
  #endif
  __PYX_XCLEAR_MEMVIEW(&__pyx_v_tmp, 1);
  #ifdef WITH_THREAD
  __Pyx_PyGILState_Release(__pyx_gilstate_save);
  #endif

is generated here:
https://github.com/cython/cython/blob/36a741a10db8114c1eca1753aea7be92c5f3a639/Cython/Compiler/Nodes.py#L2363-L2368
where by deleting assure_gil('success') the GIL code is avoided and the generated C code looks as follows:
  __pyx_L1_error:;
  #ifdef WITH_THREAD
  __pyx_gilstate_save = __Pyx_PyGILState_Ensure();
  #endif
  __PYX_XCLEAR_MEMVIEW(&__pyx_t_1, 1);
  __Pyx_WriteUnraisable("test._run", __pyx_clineno, __pyx_lineno, __pyx_filename, 1, 0);
  #ifdef WITH_THREAD
  __Pyx_PyGILState_Release(__pyx_gilstate_save);
  #endif
  __pyx_L0:;
  __PYX_XCLEAR_MEMVIEW(&__pyx_v_tmp, 0);

But I have a several questions:

The GIL locking is necessary for __PYX_XCLEAR_MEMVIEW or not?
What is the purpose of WITH_THREAD macro? I don't see it anywhere declared (even not during compilation) so it seems that locking is not compiled in any case...

The GIL locking is necessary for __PYX_XCLEAR_MEMVIEW or not?

No - __PYX_XCLEAR_MEMVIEW will reacquire the GIL itself if necessary (which is only when its internal atomic reference count goes to 0. The second argument (0 or 1) tells it whether it already has the GIL.
However - note that if entry.type.needs_refcounting:  covers multiple different types (currently just PyObject + memoryview, but maybe more in future) and only memoryview can get away without the GIL.

What is the purpose of WITH_THREAD macro? I don't see it anywhere declared (even not during compilation) so it seems that locking is not compiled in any case...

It's defined in the Python headers (https://github.com/python/cpython/blob/d48760b2f1e28dd3c1a35721939f400a8ab619b8/Include/pyport.h#L663). It looks like it's pointless now since it's always defined, but before Python 3.7 it used to be informative.


Update the client version range

This works, our integration tests cover this.

Huh, something's wrong with compiling at head, checking on that.


[CT-1154] [Bug] Adapter test bool_or contains reserved keyword

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
The test fixture for the adapter test bool_or contains the reserved keyword key which might fail in some adapters (as it does in the one for SQL Server)
Expected Behavior
Tests should not use commonly reserved keywords for their column names
Steps To Reproduce
Implement the bool_or test in your adapter in a database engine where key is reserved (e.g. SQL Server)
Relevant log output
('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near the keyword 'key'. (156) (SQLMoreResults)")

Environment
No response
Which database adapter are you using with dbt?
other (mention it in "Additional Context")
Additional Context
dbt-sqlserver

Thanks for reporting this @sdebruyn!
Which test(s) are failing on key being a reserved keyword?
Is it fixture_bool_or? Or something else?

Hi @dbeatty10 that's indeed the one. I fixed that in the linked PR.


Adding 678-Valid-Parenthesis-String.c

File(s) Modified: 678-Valid-Parenthesis-String.c
Language(s) Used: C
Submission URL: _https://leetcode.com/submissions/detail/782548817/_

Thanks, @FahadulShadhin!


Log a warning when alerts fire but there are no Alertmanagers configured.

This PR adds a warning that is logged whenever an alert fires but there are no Alertmanager instances configured.
Without this, it may not be apparent what the problem is - the only other signal that alerts are being dropped is the prometheus_notifications_dropped_total metric.

While I understand the issue, there are valid reasons to use Prometheus without alertmanager while still having alerting rules. E.g. if you use federation or remote write. This would be an annoyance for the users with this specific use cases.

One idea is that we could issue the warning if the user has specified a non default non empty config

One idea is that we could issue the warning if the user has specified a non default non empty config

Could you expand on what you mean by "non default non empty" config @roidelapluie? Config for what specifically?

Guessing he meant config for Prometheus to talk to alertmanagers.
https://prometheus.io/docs/prometheus/latest/configuration/configuration/#alertmanager_config

We have discussed this during our weekly bug scrub.
We think that this is only fixing one failure mode for alerts not reaching alertmanagers. We recommend you to use a WatchDog alert connected to you alerting system to notify you when your alerting pipeline is not working. In production-grade alerting solutions, this is often an approach that we encounter.
See this page from @juliusv's training:
https://training.promlabs.com/training/monitoring-and-debugging-prometheus/metrics-based-meta-monitoring/end-to-end-watchdog-alerts
Thanks for your work.


Show and Hide seconds Dynamically

I have been trying all afternoon to show and hide the seconds using the various API functions. Do I have to 'stop' the clock clock.stop(); , set a parameter and then start it with  clock.start(); ? clock.loadClockFace('clock', options)
This is super exasperating; or do I have to dynamically delete the object and recreate it in the options?

This is completely possible in the new js-es6 branch, which is the official v1 draft. The new version has render functions and can be re-rendered after a value or anything changes.
const clock = new FlipClock(el, new Date, {face: 'MinuteCounter'}); clock.face.showSeconds = false; clock.render();


Theano GPU ID and Caffe GPU ID must be the same

Hi,
I am not sure if it is an issue.  If I specify different GPU ID for theano and caffe, caffe will get stuck before  training.

Hi,
Thanks for pointing this out. I've experienced the same problem as well. Any suggestions how to tackle this issue are welcome.

so how can i make sure whether they are the same ?


fix(snippets): 🐛 Packages not being re-exported

What is the purpose of this Pull Request?
Fix the case where some packages weren't included and re-exported.
Type of this Pull Request

🐛 Bug fix
📝 Documentation update

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.946%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2175

Relevant Lines:
2246

💛  - Coveralls


Program crashes if you don't input an integer

It should sanitize input and reprompt if invalid instead.

Clarification: for the for loop


⚠ Bofrost.de has degraded performance

In eab9c0f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2191 ms

Resolved: Bofrost.de performance has improved in 40a76ff after 20 minutes.


Remove Microsoft Thumbs.db file

Hello.
If found another Thumbs.db file.
It's only used when using microsoft file browser, and should be removed from the repository I believe.

ping?


breadcrumbs instrument log.debug() even when the logging level is info

I noticed in on of our applications that 5% of the CPU time is spend in _record_log_breadcrumb, called from logging.debug, even though our logging level is not that high.
It would be helpful if the instrumentation would respect the logging level, so if the level is INFO then only messages from that level or higher are instrumented.
This is rather annoying because from my understanding debug logging should be allowed to affect performance because it is only used for development. Anything that instruments logging should respect that behaviour

I actually love this feature. Being able to see debug logs in case of error is very interesting. Please make this configurable.


Character size not changing under normal in-game conditions (i.e. status effect Minimum, etc.)

When inflicted with the status effect Minimum, which changes the character's size (like Cerberus in World of Darkness, purple orbs in Syrcus Tower, the SB A rank hunt Sum, etc.), the camera will move as normal to show the player's smaller size, but the actual character model will not change size. For me, this is consistent across all instances of character-shrinking debuffs. I have not tested whether this also occurs for effects that make the player larger (Dohn Mheg 2nd boss), though since there's far fewer of those.
Currently the only scaling I have Customize+ doing is increasing the Root for my character to 1.032. I have Automatic Mode and Apply to NPCs enabled as well.

#84


How to download "ckpt_file" for anime.py?

Thank you for your work! @YuliangXiu , I am trying to run the Animation demo. May I know where to download the files for ckpt_file below? I think it's the path to the pre-trained characters. I have downloaded TADA Extra Data and unzip it as ./data, but there is no checkpoints in it. And the code breaks at assert os.path.exists(ckpt_file) (L404 of anime.py).
https://github.com/TingtingLiao/TADA/blob/cad379771e66d3551476b6d873c106dc812a4089/apps/anime.py#L403
Also, I have download TADA 100 Characters and there is also no checkpoints, but there is a params.pt in each character's folder. However the key in these .pt files dict_keys(['v_offsets', 'betas', 'expression']) do not match the ones in the code. There should be a 'raw_albedo' key in addition to these, according to your code.

You can load the albedo from the texture image (which is included in the 100 characters) using the following script:
   albedo = cv2.imread(albedo_path, cv2.IMREAD_UNCHANGED)
    albedo = cv2.cvtColor(albedo, cv2.COLOR_BGR2RGB)
    albedo = albedo.astype(np.float32) / 255
    self.raw_albedo = torch.as_tensor(albedo)

Thank you for your answer! This solved it.

Thank you for your work! @YuliangXiu , I am trying to run the Animation demo. May I know where to download the files for ckpt_file below? I think it's the path to the pre-trained characters. I have downloaded TADA Extra Data and unzip it as ./data, but there is no checkpoints in it. And the code breaks at assert os.path.exists(ckpt_file) (L404 of anime.py).
https://github.com/TingtingLiao/TADA/blob/cad379771e66d3551476b6d873c106dc812a4089/apps/anime.py#L403
Also, I have download TADA 100 Characters and there is also no checkpoints, but there is a params.pt in each character's folder. However the key in these .pt files dict_keys(['v_offsets', 'betas', 'expression']) do not match the ones in the code. There should be a 'raw_albedo' key in addition to these, according to your code.

Hi, did you replace this line (403 in anime.py):
 ckpt_file = f"{args.workspace}/tada/{args.subject}/checkpoints/tada_ep0150.pth"

To the one to the pt file, such as:
ckpt_file = '/content/TADA/Avatar-100/MESH/Ant-man/params.pt'

I actually did like this, but it pops out the error:
model_data = torch.load(ckpt_file)["model"]
KeyError: 'model'


[BUG] all Z-something channels return 401s

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
title
zcanary, zintegration, and zlive channels return 401s.

Not a bug. Use LIVE.


Allow AREA series to be "infinite" horizontally ( like price lines )

Currently, the "PRICE LINE" is infinite on the chart, and it works perfectly.
Along with the 2 price lines i have i added an AREA series in order to "paint" it with a "rectangle", i would like it to be "infinite horizontally" the same way as the price lines.
So there would be no "gap" on the sides when using "rightOffset"
Is it possible?

I would suggest that you could implement this with a LWC plugin.

https://tradingview.github.io/lightweight-charts/docs/plugins/intro

Plugins would allow you to define a rectangle that drawn completely across the screen.
The template example provided by create-lwc-plugin for a drawing primitive is a rectangle, and then you could add in some options to draw a gradient for the fill, and remove the logic for defining x coordinates and rather just plot from 0 until scope.mediaSize.width * scope.horizontalPixelRatio in the renderer code.

I would suggest that you could implement this with a LWC plugin.

https://tradingview.github.io/lightweight-charts/docs/plugins/intro

Plugins would allow you to define a rectangle that drawn completely across the screen.
The template example provided by create-lwc-plugin for a drawing primitive is a rectangle, and then you could add in some options to draw a gradient for the fill, and remove the logic for defining x coordinates and rather just plot from 0 until scope.mediaSize.width * scope.horizontalPixelRatio in the renderer code.

The tricky part is that the rectangle would have to work like the area, as in, when the chart is resized and moved around, the rectangle would also have to resize and move around.
I remember seeing a list of plugins somewhere, I would assume if there is a plugin system than something like that is probably already done ( i.e. drawing shapes on the chart that resizes / adapts like the the price line and the area chart )

I would suggest that you could implement this with a LWC plugin.

https://tradingview.github.io/lightweight-charts/docs/plugins/intro

Plugins would allow you to define a rectangle that drawn completely across the screen.
The template example provided by create-lwc-plugin for a drawing primitive is a rectangle, and then you could add in some options to draw a gradient for the fill, and remove the logic for defining x coordinates and rather just plot from 0 until scope.mediaSize.width * scope.horizontalPixelRatio in the renderer code.

The tricky part is that the rectangle would have to work like the area, as in, when the chart is resized and moved around, the rectangle would also have to resize and move around.
I remember seeing a list of plugins somewhere, I would assume if there is a plugin system than something like that is probably already done ( i.e. drawing shapes on the chart that resizes / adapts like the the price line and the area chart )

im creating a full pure js plugin for lightweight chart. you can check this :
https://github.com/safaritrader/lightweight-chart-plugin


Add beacon API tests

#612

could it take this one?

Yes, sure! (I meant to to assign it to you, not to me 😅)

@MegaRedHand  This is what we would need, right? https://hexdocs.pm/phoenix/testing.html

Yes. Although we'll probably have to mock the DB calls with patch


Use pkgs pinned in flake lock

I want to use the pinned nixpkgs from the flake.lock because rustc 1.64.0 in stable is to old to build harmonia.

The ci failure is because the current pinned nixpkgs version is still the old harmonia fork.

Closing because I am upstreaming harmonia in https://github.com/NixOS/nixpkgs/pull/230550


Usage of first_loss and second_loss?

Hi, thank you for releasing the code! 🎉
But I wonder why the first_loss and second_loss are set to 0 in both line 135 and line 95 of file src/modeling/nets.py?
# Dummy losses
first_loss = torch.tensor(0., device=logits.device).float()
second_loss = torch.tensor(0., device=logits.device).float()

Thanks.

Oh, I see. Never mind. Thank you.


include distribution files, erroneously omitted in the former release

@tremolo is not around and this is an easy one, merging without approval


Add limits to group chats

Limit adding/removing members to 5 members per 3 seconds, and limit group chats to 100 members.

Yeah, I'll make a patch for Meower Svelte later

I tried a 300 member group chat on Meower Svelte, it ran completely fine. So I've raised the limit to 256 members (I asked for 250, Mike wanted to make it 256).

Btw filewrite will be broken

btw there should be a block where the user was added two times to a chat

that was already implemented a long time ago

ok

oh no

He said he will deploy tomorrow when the server goes down for scheduled maintenance.


Webpack Follow-up: Rename clientConfig to legacyConfig and novoConfig to clientConfig

Follow-up to https://github.com/artsy/force/pull/7225.
This does a little renaming so that that we can clearly understand whats old and new.

clientConfig and related have been renamed to legacyConfig and related
novoConfig has been renamed to clientConfig.

Everything that legacy touches is very much deprecated. Now, current clientConfig generally only refers to our src/v2 folder.
There will need to be one more follow-up PR around actual file output. We're still emitting assets into a public/assets-novo folder. I think for now this is fine as we let things settle.
Have ran this locally in dev and prod mode and all good; lets see what staging thinks.

Staging deploy all good.


proposal: intmath: new package

In same cases, like pagination, it is necessary to do:
pages = int(math.Ceiling(float64(items) / float64(itemsPerPage);

According to http://www.cs.nott.ac.uk/~rcb/G51MPC/slides/NumberLogic.pdf, the code can be optimized to avoid using floating point support:
pages = (items + itemsPerPage - 1) / itemsPerPage

According to https://stackoverflow.com/questions/17944/how-to-round-up-the-result-of-integer-division, a simplified version exists that avoid a possible overflow:
pages = (items - 1)  / itemsPerPage + 1

I have not verified these algorithms.  However it should be evident that it is not a trivial problem.
In addition to CeilDiv there are also the CeilMod, FloorDiv, FloorMod and Abs functions.
Finally I also propose to add functions so that integer overflow is reported with an error, like AbsExact, AddExact, DivideExact, MultiplyExact, NegateExact, SubtractExact, CeilDivExact, FloorDivExact.
These functions accept a signed integer (int) as arguments.
References

https://download.java.net/java/early_access/jdk18/docs/api/java.base/java/lang/Math.html

For the Exact family of functions, it may be more useful to return the (possibly overflowed) result of a + b and a bool that is true if the result overflowed.

Other algorithms that would be nice to have, overflow safe average:
return (a >> 2) + (b >> 2) + (a & b & 1)

And / or a version that supports variadic input.

It doesn't seem like this would need to be in the standard library.
Are there third-party packages that are widely used for this?
(That would be an indication that it's a common need.)

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rsc A quick search for CeilDiv returned the following links:

https://stackoverflow.com/questions/19890935/golang-ceil-function-like-php
https://pkg.go.dev/github.com/containrrr/shoutrrr/pkg/util (imported by 0 packages)
https://github.com/jvlmdr/go-cv/blob/8ab6d79/slide/size.go#L23

As for arithmetic operations that will return an error on overflow instead of doing two's complement wrapping, it is possible that there are existing programs that are currently incorrect and should use the proposed API.

I would rather have integer arithmetic operators, like Zig's +| for saturating addition, than a special math package. Zig integers panic rather than wrapping by default, so they have +% to mean wrap on overflow. For Go, where integers wrap by default, it might be nice to have +! for panic on overflow. It could be a good intermediate step to take towards some sort of Go 2 with bigints as the default integer type.

@carlmjohnson I don't think it is necessary to add additional operators.
With the API
func AddIntN(a intn, b intn) (r intn, ok bool);
func AddUintN(a uintn, b uintn) (r uintm, ok bool);

the programmer can do
package main

import (
	"math"

	"golang.org/x/exp/imath" // or golang.org/x/exp/math/exact
)

func main() {
	var a int32 = math.MaxInt32
	var b int32 = 1

	// saturating arithmetic
	if r, ok := imath.AddInt32(a, b); !ok {
		r = math.MaxInt32
	}

	// panic
	if r, ok := imath.AddInt32(a, b); !ok {
		panic("a + b overflowed")
	}
}

This still seems like something that should be done as a third-party package before we consider adding it to the standard library.

(This message is more about a generic intmath package as opposed to one for int only, so perhaps I should post consequent messages about that in #41157.  Please let me know.)
@rsc

Are there third-party packages that are widely used for this?
(That would be an indication that it's a common need.)

I would say that packages aren't a good indication of a common need here, since a lot of these operations have a common “oneliner” equivalents.  Which are, of course, easy to get wrong.  A common need for at least Max, Min, CeilDiv, and RoundDiv (integer division rounding towards the nearest integer) can be found in code itself.
Just for the hell of it, I looked up examples of CeilDiv oneliners from the Go 1.18 source code, using a very rough regexp grep -e '+\(.*\)-.*1.*/.*\1' -n -r.  Here are just a few:

src/strings/strings_test.go:1688
benchStr := Repeat(benchmarkString,
    (indexSizes[len(indexSizes)-1]+len(benchmarkString)-1)/len(benchmarkString))

Which could be:
benchStr := Repeat(benchmarkString, intmath.CeilDiv(indexSizes[len(indexSizes)-1], len(benchmarkString))

src/text/tabwriter/tabwriter.go:283
cellw = (cellw + b.tabwidth - 1) / b.tabwidth * b.tabwidth

Which could be:
cellw = intmath.CeilDiv(cellw, b.tabwitdh) * b.tabwitdh

src/cmd/compile/internal/ssa/poset.go:21
return make(bitset, (n+uintSize-1)/uintSize)

Which could be:
return make(bitset, intmath.CeilDiv(n, uintSize))

I could look up some other oneliners a bit later, if such arguments for this proposal or proposal #41157 are at all convincing.

No change in consensus, so declined.
— rsc for the proposal review group


Support configure a user-defined API domain name

When using OpenAI, I'll create a reverse proxy server for the following reasons.

Bypass the firewall and OpenAI region restrictions
Use azure-openai-proxy to use the OpenAI service in azure
Insert the api key into the server instead of configuring it on the client side, so that it can be easily shared to multiple people.

this is an uncomplicated but useful function, hope can be supported

Hi, using a custom  service should allow you to use reverse proxy server:

I actually overlooked this place, I tried it out and it looks well. Thank you 😊

Glad you got it worked out. Closing the issue.

Where is this custom service? I was trying but I cannot find it
I would like to also use my own open AI service, and it uses a Token instead of key. can you please check? also how can i find the curl request what the plugin makes?


The css file always load from cache even I refresh the browser.

Screen shot of Chrome's network tab:

Configuration:
System.config({
    map: {
        jquery: 'bower_components/jquery/dist/jquery.js',
        css: 'bower_components/plugin-css/css.js',
        slick: 'bower_components/slick-carousel/slick/slick.js',
        slickCss: 'bower_components/slick-carousel/slick/slick.css'
    },
    meta: {
        '*.css': {
            loader: 'css'
        },
        slick: {
            deps: ['jquery', 'slickCss']
        }
    },
    buildCSS: false
});

Demo:
http://<IP_ADDRESS>/SystemJS/

Remove your cache-control header on the server. Caching is a server-controlled process.

But doesn't it makes more sense to make a new request to the server when refreshing the browser even there is cache-control header on the server? Just like the <link /> element behavior.


Download a file without putting the contents in memory!

Hello!
Just a thing, lets say I try to download a file, when I end up doing request.recv_bytes() that sticks the contents of the file in ram, IN ITS ENTIRETY.
That could be a huge problem, of which I would like to avoid by potentially converting it to a stream, or adding a function to write it to a file.
Would this be possible?

P.S. I love alhc, its been a life saver for file size, and I'm happy to be the first issue!

I just notiched the download example, but this seems like something that can be merged into the main repository and be made into a single function. Would this be possible?

You can just await a Request to turn it into a Response that have AsyncRead trait implemented, which can let you read binary data as stream:
use
let mut response = client.get("https://example.com/hugedata").await?;
let mut buf = [8u8; 1024];
loop {
    let read_bytes = response.read(&mut buf).await?;
    if read_bytes == 0 {
        break;
    }
    // Do something for this chunk of data...
}

Current version presented on crates.io doesn't have clear document (my mistake on code architecture) so the Response struct doesn't shown, which is what I'm currently working on.

Ah, that helps a lot! Yeah, there isn't really any documentation on docs.rs, so its impossible to see whats happening without looking at the source code, but asking you would have been easier.
Thank you!

For a new code architecture experiment, I just published a 0.3.0-alpha.1 version to crates.io, should be more clear to use and more stable (probably). Feel free to try it if you have spare time. 😄

For a new code architecture experiment, I just published a 0.3.0-alpha.1 version to crates.io, should be more clear to use and more stable (probably). Feel free to try it if you have spare time. 😄

Hey! I tried alpha 3 and its amazing! I also noticed I needed to use futures_util instead of tokio for the AsyncReadExt, this is an amazing version, and my binary size is still tiny! Thank you so much!


(MAINT) Use latest ssl.sh in image

The new version fails immediately if the CA already has an unsigned CSR
for this host, instead of waiting for the signing timeout to occur.

CLA signed by all contributors.

Test PASSed


Make bank account page scrollable

Details

Part of https://github.com/Expensify/App/pull/6557 got reverted in https://github.com/Expensify/App/pull/6630 due to regression and thus I am fixing the remaining page for core issue #6496.
Fixed Issues

$ https://github.com/Expensify/App/issues/6496
Tests | QA Steps

Navigate to workspace settings
Change the orientation to landscape
Click on any of the options.
Scroll the page.

Test https://github.com/Expensify/App/issues/6620 on this PR as well.
Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

https://user-images.githubusercontent.com/24370807/144223270-4ff0800a-0ab4-42d5-8e2a-aefa181a7534.mp4

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @chiragsalian in version: 1.1.19-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


I don't get it oO

Well, hi there!
Very interesting project but I didn't get anything. I tried on MAC Sierra, tried on Windows. But no success.
Well, on Mac. I have to Clone the repo? couse the "vectiler-osx-x86_64.out" doesn't do nothing. Just open the App Store and nothing, just a bunch of others apps nothing to do with.
So I gonna do my tries here. Can anyone clarify my path?
Best Regards.

I get it xD
I just have problem to understand clearly about the tiles ranges. Have the tiles to be match with the zoom value?

Hey @MichelDiz !
Since it is a command line tool you would need to open the terminal to be able to interact with it. In the future a better UI with an app you can run and might be available.
The tile range will just generate a larger mesh, for example: requesting a tile at with an id x and y for a zoom z with a tile range range_x and range_y of 2 will generate a unique mesh containing the tiles (x,y,z),(x+1,y,z),(x,y+1,z),(x+1,y+1,z).

Have the tiles to be match with the zoom value?

If you mean that the range will increase for the same zoom value, then yes.

Right! Well I succeeded. (Can sign as solved)
But I have few problems. In mm or inches - What would be the proportion of the map? Cause I'm putting this map inside the Unreal Engine 4 to create a environment. But I'm guessing the calculation on proportions. it comes like very tiny. I think like less than 8 cm. (But It should be kilometers)
I put like 6000 times the size to get something related to reality. Using my guessing measurement. Like Google earth measures and putting BSD to compare. But is acceptable visually now.
Another thing is that it creates a lot of meshs an faces like a mess. But in the 3D Max I would be able to clean it.
Ah! I was almost forgetting! the information for creation of the tiles comes from where? Google maps it's self? or some third informations? Couse few build are missing. Importants ones. Like very important to the city that they are on the Google maps, but no sign on the meshes.
By the way, I think you could use the Electron JS project to create the UI Apps. It's use JS + Chromium project and you're able to use the same code for Windows, mac and others.
Thank you for your work and attention. Best Regards.

About

Have the tiles to be match with the zoom value?

Forget it, I was just confused at the time. Now I understand.

I totally forget to respond to this issue since I only focused on your last message, really sorry about the late response.
But I have few problems. In mm or inches - What would be the proportion of the map? Cause I'm putting this map inside the Unreal Engine 4 to create a environment. But I'm guessing the calculation on proportions. it comes like very tiny. I think like less than 8 cm. (But It should be kilometers)

The proportion of the tile are always arbitrary depending on the zoom level you are at. A tile coordinate a zoom 1 will have a different size than a coordinate a zoom 2. You could find out what is the appropriate scale by knowing how much coverage a tile has at a specific zoom level. Each tile will have its coordinate reduced to 0 and 1.
Another thing is that it creates a lot of meshs an faces like a mess. But in the 3D Max I would be able to clean it.

Yes this is a known issue, the quality of the mesh will be most likely depending on the underlying vector  tile data. Some clean up pass would be beneficial.
Ah! I was almost forgetting! the information for creation of the tiles comes from where? Google maps it's self? or some third informations? Couse few build are missing. Importants ones. Like very important to the city that they are on the Google maps, but no sign on the meshes.

The data is served by the mapzen vector tile service: https://mapzen.com/documentation/vector-tiles/. Which is sourced from open street map. If some building are missing, it could also be that they are missing a height property. This can be solved by giving them a minimum fixed height (see the --buildingsHeight option).
By the way, I think you could use the Electron JS project to create the UI Apps. It's use JS + Chromium project and you're able to use the same code for Windows, mac and others.

I like the idea of Electron, and I guess that for users that wouldn't care downloading heavy sized binary executable that would work, the only thing I don't like a lot is that the app would be unnecessarily bloated. But you're right that this would give direct UI access and would surely make it nicer to use. If you are interested in this let me know.


OCPBUGS-35416: Wait for ControlPlaneMachineSet to be created when waiting for it to be updated

Seeing this in presubmits sometimes. One of the tests using this helper expects the CPMS generator to regenerate the CPMS right at the end of the test, but we then immediately call EnsureControlPlaneMachineSetUpdated which expects the CPMS to exist.
In the right conditions, this second helper can catch the generator mid way between delete and create as it regenerates, and that causes the test to fail with a not found error.
This should help to prevent that.

/cherry-pick release 4-16

/cherry-pick release-4.16


[Snyk] Upgrade react-router from 6.2.1 to 6.4.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade react-router from 6.2.1 to 6.4.1.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 21 versions ahead of your current version.
The recommended version was released 23 days ago, on 2022-09-21.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
Base: 94.02% // Head: 94.02% // No change to project coverage :thumbsup:

Coverage data is based on head (58b7c3f) compared to base (7db429a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #222   +/-   ##
=========================================
  Coverage     94.02%   94.02%
  Complexity      475      475
=========================================
  Files            96       96
  Lines          1607     1607
  Branches        122      122
=========================================
  Hits           1511     1511
  Misses           56       56
  Partials         40       40

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Feature]:  Use Tailwind CSS For Better UI

I think it is better to use tailwind CSS To Achieve Impressive UI

Hey Can you please assign this to me


EnvironmentPlugin: function for defaultValues

EnvironmentPlugin: allow defaultValues to be computed from a function.
This is useful when the computation of the defaultValue is expensive, such as CI_COMMIT_TAG requiring an invocation of git rev-parse HEAD.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
not yet
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?

https://webpack.js.org/plugins/environment-plugin

This adds complexity that's often not needed. Please use DefinePlugin.runtimeValue for your usecase instead:
https://webpack.js.org/plugins/define-plugin/#runtime-values-via-runtimevalue


added --all option to status flag | fixed resolved status bug | removed tablewriter pkg

/hold

This PR is now deprecated, please have a look at #64.
Hence closing this.


Source as S3 fails with "only single character unicode strings can be converted to Py_UCS4"

Environment

Deploy method: docker-compose.yml
Jitsu version:  latest
OS: for instance Ubuntu 21.04
Cloud Provider: local

Description
Tried to connect jitsu source as S3 bucket file. It is able to connect properly but the stream creation fails with
  File "/airbyte/integration_code/source_s3/source_files_abstract/formats/csv_parser.py", line 157, in stream_records
    pa.csv.ParseOptions(**self._parse_options()),
  File "pyarrow/csv.pyx", line 235, in pyarrow._csv.ParseOptions.init_
  File "pyarrow/csv.pyx", line 299, in pyarrow._csv.ParseOptions.escape_char.set_
  File "pyarrow/_csv.pyx", line 43, in pyarrow._csv._single_char
ValueError: only single character unicode strings can be converted to Py_UCS4, got length 0

Steps to reproduce the behavior:
Selected source as an S3 bucket file. The destination is a postgresql setup locally.
Expected behavior
It should connect and start data stream
Actual behavior
It fails with above given error.
Though jitsu uses airbyte connectors for S3, I ran the same architecture on airbyte directly and it was able to connect and stream from the S3 bucket to the postgresql database.
It was running on te airbyte docker setup locally, so this seems like a jitsu issue.

Fixed in 1.42.3


swift-dependency-tool: avoid redefinition of ScalarTraits on FreeBSD

On FreeBSD, size_t and uint64_t are both typedefs of unsigned long.

@swift-ci please smoke test


Android projects using Gradle's Kotlin DSL will not build.

I've created a sample project, miniature-succotash-0.0.1.zip, to demonstrate Bitrise's build step doesn't recognize build.gradle.kts. See failing build/logs here.
This example shows a simple packaging. Like the Groovy DSL, projects may include Kotlin files in project/buildSrc/com/kotlin/build.gradle.kts.
cc @viktorbenei

Hello there!
the kotlin scanner is in this current sprint, so the full support for it will be available in the following weeks 🙃

I'm closing this old issue as Kotlin DSL support has been added, we just forgot to update this issue.


ENH: Extra Columns Available for Custom Table

Some columns are not available in the 'Custom' table.
finvizfinance provides columns 0 to 70
But finviz has a few more columns:
https://finviz.com/screener.ashx?v=152&c=73, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88
non_implemented_col_ids = [73, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88]

EXTRA_COLUMNS = {
 73 : 'Book Value per Share',
 75 : 'Dividend',
 76 : 'Employees',
 ...
 86 : 'Open'
 87 : 'High',
 88 : 'Low',
}

For the sake of cleanness, completeness and because this is an easy fix,
I was going to fiddle with the base code.
But after seeing that the Sept 28 issue got fixed very quickly (big up @lit26 !), it may be better to implement this properly in the original code?
Any chance to see this implemented soon?

Should be fixed in the latest. Please check

Thanks @lit26 !! Great stuff.
I saw you added the missing columns to screener.custom.py
But after doing a 'pip install finvizfinance', I get only the old 70 columns... (v 0,14.6)
from finvizfinance.screener.custom import COLUMNS
Am I doing something wrong?

Use the pre-release version. The latest is v0.14.7rc2.

Great
pip install finvizfinance==0.14.7rc2
did the trick!
Thx @lit26 for the quick response.


chore: add cherry-pick-bot

This PR enables a cherry-pick-bot that will automate cherry picks into a PR.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.64%. Comparing base (1924339) to head (2612c8c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #931   +/-   ##
=======================================
  Coverage   74.64%   74.64%
=======================================
  Files          31       31
  Lines        3913     3913
=======================================
  Hits         2921     2921
  Misses        856      856
  Partials      136      136

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: cli improvement

Closes #47
I have done some research and added --dev/--no-dev and --build/--no-build instead of the former commands. This new option style allows the build file to now has python3 starfyre --build --path="test-application". It makes the command leaner.
If the user runs the build file,  it will successfully build and run the required files to create our application.
Things Observed:
If I change the build file from python3 starfyre --build --path="test-application" to python3 starfyre --build --path="my-first-app". It will report the following error:
 File "/usr/local/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/akin/software_eng/starfyre/starfyre/__main__.py", line 74, in <module>
    main()
  File "/home/akin/software_eng/starfyre/.venv/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/akin/software_eng/starfyre/.venv/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/akin/software_eng/starfyre/.venv/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/akin/software_eng/starfyre/.venv/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/akin/software_eng/starfyre/starfyre/__main__.py", line 61, in main
    compile(path)
  File "/home/akin/software_eng/starfyre/starfyre/compiler.py", line 160, in compile
    build_dir.mkdir(exist_ok=True)
  File "/usr/local/lib/python3.10/pathlib.py", line 1175, in mkdir
    self._accessor.mkdir(self, mode)
FileNotFoundError: [Errno 2] No such file or directory: '/home/akin/software_eng/starfyre/my-first-app/build'

Is this an expected behaviour?
Is the --path="test_application" in the command contained in the starfyre build file constant or path value can change?

Also, answering your question here.

If I change the build file from python3 starfyre --build --path="test-application" to python3 starfyre --build --path="my-first-app". It will report the following error:

It is because it will either expect a relative path or an absolute path. So, it is unable to find the folder as you do not have any folder named my-first-app in your starfyre directory.
You can decipher it from the error message here

FileNotFoundError: [Errno 2] No such file or directory: '/home/akin/software_eng/starfyre/my-first-app/build'

So, it is not a fixed value but this is the expected error.

Hi @sansyrox, I have updated the implementation - I made some changes with your suggestions, thanks! The issue now is this command python3 starfyre --path="my-first-app" works fine but I think it doesn't generate all the files needed for a successful run, right?
I compared it against the test_application and it is missing some files. How do these files get generated?
So because python3 starfyre --path="my-first-app" doesn't generate all the files needed, this command python3 starfyre --build --path="my-first-app" fails with this error:
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/akin/software_eng/starfyre/starfyre/__main__.py", line 75, in <module>
    main()
  File "/home/akin/software_eng/starfyre/.venv/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/akin/software_eng/starfyre/.venv/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/akin/software_eng/starfyre/.venv/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/akin/software_eng/starfyre/.venv/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/akin/software_eng/starfyre/starfyre/__main__.py", line 66, in main
    subprocess.run(
  File "/usr/local/lib/python3.10/subprocess.py", line 503, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/local/lib/python3.10/subprocess.py", line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/local/lib/python3.10/subprocess.py", line 1847, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/home/akin/software_eng/starfyre/my-first-app/build/__init__.py'

I tried printing the absolute path and it is pointing to the right directory Absolute Path = /home/akin/software_eng/starfyre/my-first-app/build/__init__.py
Am I missing a step during compilation?

I mistakenly deleted the whole project while testing if the compilation was working but I was able to get the files back later.
I have cut out the section of code I was working with in the __main__.py file
@click.command()
@click.option("--path", default=".", help="Path to the project")
@click.option("--build", is_flag=True, help="Compile and build package")
def main(path, build):
    """
    Command-line interface to compile and build a project.
    Args:
        path (str): Path to the project directory.\n
        build (bool): Whether to start the build package.
    """
    # compile and build project
    temp_path = path
    path_ = temp_path + "/__init__.py"
    # get absolute path
    path = os.path.abspath(path_)
    compile(path)
    create_main_file(os.path.dirname(path))
    if build:
    # start/run project
        path_ = temp_path + "/build/__init__.py"
        path = os.path.abspath(path_)
        subprocess.run(
            [sys.executable, "-m", "build"],
            cwd=path,
            stdout=subprocess.PIPE,
            stderr=subprocess.PIPE,
        )

if __name__ == "__main__":
    main()

Okay, so an update. I saw that the compile function expected an absolute path and I was passing a relative one - so the issue is not fixed.
The only question I have now is the build method only produced this file structure:
    my-first-app/
        build/
            __main__.py
        dist/
            store.js

are there not meant to be more files?

Okay, so an update. I saw that the compile function expected an absolute path and I was passing a relative one - so the issue is not fixed.
The only question I have now is the build method only produced this file structure:
are there not meant to be more files?

@DeleMike , there should be more files, given that we have merged the dev and the build flags. The .fyre files are compiled to .py files.

@DeleMike , there should be more files, given that we have merged the dev and the build flags. The .fyre files are compiled to .py files.

@sansyrox  Can you please check this:
 if build:
        # Start/run project
        build_dir = os.path.join(path, "build")
        subprocess.run(
            [sys.executable, "-m", "build"],
            cwd=build_dir,
            stdout=subprocess.PIPE,
            stderr=subprocess.PIPE,
        )
    else:
        # Compile and build project
        compile(os.path.join(path, "__init__.py"))
        create_main_file(path)

Does the above actually represent that we have merged the two flags? You suggested that I do not compile if --build is not passed. If I shouldn't compile what tips do you have for me to merge both commands?

Hello @sansyrox , I have made some updates.

Thanks @DeleMike 😄
I have made a few changes finally. And this should be good to merge. Great work! 🔥

Actually @DeleMike , one update. The build script has stopped working.
If you delete the build and the dist folder. And then re start the ./build script. There is no index.html in the dist folder. There must be a bug somewhere. Can you please have a look ?

Thanks. I'm looking into it now...


Processed data lacks files

Dear author,
May I ask why the number of data points in processed training data is only 287084, while the paper claims it uses 287227 training points?
Looking forward to your reply,
Thank you,

We removed some documents which are too short.

Also the same reason is applied to dev and test set ? Thanks

Yes, you could see preprocess scritps for details. But for test set, no documents were removed.


Define how versions should be managed + Genesis Index should be contacted

Right now, there isn't any formal documentation about when Genesis Index is contacted, or how things like track, latest, and 1.3.4 versions should behave. This makes it hard for people to anticipate what genesis will do under certain circumstances. We should add some, to set expectations.

Proposal (to go straight into the Readme):
Version Keywords
Genesis allows you to specify some keywords for your release & stemcell
versions, and attempts to make life easier for you where it can. Here's a
run-down of the keywords, and how Genesis helps.
track
Specifying a version of track tells Genesis to fetch the latest version information
from the Genesis Index whenever it's building the manifest. This way you will always
get the latest version.
This keyword is mostly useful for keeping stemcells up-to-date, when not using the
genesis ci pipelines. When you use genesis ci, there is an automated task that
monitors stemcells and propagates upgrades to them through your infrastructure, using
explicit versions.
latest
This piggyback's on BOSH's latest version functionality. When specified, genesis
will simply pass this version on to BOSH, to let BOSH chose the latest uploaded
release/stemcell, and use that.
If the release/stemcell does not exist yet on BOSH, Genesis will contact the Genesis Index
and upload it for you, just-prior to deploying.
x.y.z
If you specify a raw version (3262.12, 241, 1.2.3), Genesis will tell BOSH to use that
version explicitly. If you specify a sha1 and URL for the release/stemcell, BOSH will
include that when it does the deploy. If you do not specify the sha1 or URL, Genesis
will contact the Genesis Index to resolve the missing information, just prior to deploy.
The Genesis Index
The Genesis Index is a service designed to make managing releases and stemcells easier.
It watches new versions of common releases and stemcells, and updates the index with
their metadata. It is only contacted under the following circumstances:

When generating manifests for each stemcell/release that specified track as its version
When deploying a manifest which does not have a sha1 or url attribute for a release/stemcell,
unless that release/stemcell is already present with the correct version on the BOSH director
When deploying a manifest which specifies latest as the version of a release/stemcell,
and that stemcell/release is not already present on the BOSH director.

There is a wide range of commonly used releases already present in the Genesis Index.
If you need additional releases, feel free to submit a GitHub issue on the genesis-index repo.
If you have private releases that you wish to manage using the Genesis Index, or cannot
contact the public Genesis Index, you can run your own internally, and specify the $GENESIS\_INDEX
environment variable to override the default index.

I think this covers the most common issues/scenarios. I believe bosh-init deployments will end up always contacting the index when using latest, or if sha1/url aren't specified, since there's no director to search for a version on.

Looks good, with a few corrections.
Genesis does not contact BOSH to determine if the release is present or not; if no URL / SHA1 is specified for the release, Genesis will try the index to get the SHA1 / URL, even if the release has already been uploaded to the director.  The BOSH CLI is what makes the final determine on uploading the release or not.
I don't believe Genesis ever contacts the index for "latest", since there is (by definition) no need to upload the release to the BOSH director.  If the release isn't already on the director, the deploy will just fail.

It doesn't do those things now. I was approaching the doc from a "this is ideally how I would like it to work" approach.
Sent from my iPhone

On Sep 17, 2016, at 10:55 AM, James Hunt<EMAIL_ADDRESS>wrote:
Looks good, with a few corrections.
Genesis does not contact BOSH to determine if the release is present or not; if no URL / SHA1 is specified for the release, Genesis will try the index to get the SHA1 / URL, even if the release has already been uploaded to the director. The BOSH CLI is what makes the final determine on uploading the release or not.
I don't believe Genesis ever contacts the index for "latest", since there is (by definition) no need to upload the release to the BOSH director. If the release isn't already on the director, the deploy will just fail.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

The only issue I have with this suggestion is:
* When generating manifests for each stemcell/release that specified track as its version
In the context of a genesis managed CI pipeline the track keyword should only take effect in the alpha environment (releases, stemcells) and beta (only for stemcells) otherwise un-vetted releases my end up in production.

@geofffranks ah, that makes more sense.
@bodymindarts is track something you really want to do in a pipeline?  stemcells are pretty much orthogonal to the manifest, but releases often include incompatible changes to jobs / properties that require manual intervention to accommodate.

@jhunt wether or not its a good idea to use track in a pipelined context is imo another discussion. If track is a feature we are supporting we should make sure its semantics make sense in both pipelined and non-pipelined contexts. Or explicitly disallow it in pipelines if we don't want to make reasonable guarantees to its effects.

I agree.  +1 for disallowing track in pipelines, explicitly.


FancyZones should not zone windows when it starts

Steps to reproduce
This bug is related to https://github.com/microsoft/PowerToys/issues/867 that describes the repro steps.
#867 covers a large set of bugs, this issue covers just one aspect that needs to be fixed before fixing #867
Expected behavior
When PowerToys starts, FancyZones should not try to zone any window.
Actual behavior
FancyZones thinks a resolution change has happened and it tries to zone windows.

The specific steps for "zoning on start":

have Keep windows pinned to multiple desktops in the same zone when the active desktop changes setting on
open Outlook
create a new mail, assign the new mail window to a zone and close the window
restart PowerToys

Those bring back the new mail window in a broken step.

Fix available in 0.15.0 https://github.com/microsoft/PowerToys/releases


Ruleset::processRuleset(): add tests for handling <autoload> directives

Description
Add tests specifically aimed at verifying <autoload> elements are read and handled correctly.
Note: as autoload directives are not stored in the ruleset, but directly lead to a file include using include_once, these tests need to run in a separate process to circumvent the possibility of test cross-contamination.
Suggested changelog entry
N/A
Related issues/external references
This PR is part of a series of PRs expanding the tests for the Ruleset class.

I just wonder if you considered adding a path to the XML file that triggers the code on the line below:
https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/9c8f30f9267c2f45952037c26392b5b32b7e971f/src/Ruleset.php#L531
It seems to me that all the provided paths are making Common:realpath() returns false, and so the line that I mentioned is never executed.

Probably won't surprise you that I did consider it, I just needed some time to investigate what was going on a little more. Done that now, see the new commit.

Thanks for reviewing this @rodrigoprimo !


Summarise top/bottom samples

Core changes -

Added summarize_closest_to_center which performs list_closest_to_center with default page_size=3 on select_fields.

Added summarize_furthest_from_center which performs furthest_from_center with default page_size=3 on select_fields.

TransformerLMSummarizer class which instantiate seq2seq Transformer model (bart or t5 base) to generate summary from the joined phrases and output that to this object.

eg.
summarised_center_docs = cluster_ops[t].summarize_closest_to_center(
    select_fields=[t],
    # page_size = 3 (default)
)

{'results': {'cluster-0': [{'actionable-recommendation': 'All membrane systems used under balcony pedestal pavers are to have an appropriate level of UV stabilisation and will be reviewed by 3rd Party Waterproof consultant. Ensure all mechanical penetrations at roof level are a minimum 250mm apart to allow for 100mm hob, 50mm space,100mm hob for complaint waterproofing.'}],
 'cluster-1': [{'actionable-recommendation': "CNN.com will feature iReporter photos in a weekly Travel Snapshots gallery. Visit CNN.com/Travel next week for a new gallery of snapshots of the world's best travel destinations. Click here for a gallery of photos of the best destinations in the U.S."}],
 'cluster-10': [{'actionable-recommendation': "Review opportunities to streamline reporting and approvals where possible. Streamlined process for defecting that allows for Construction / CRM's / PSI's to be conducted for thorough defecting reviews. Review opportunities for construction/CRM's/PSI's reviews are clear."}],
 'cluster-11': [{'actionable-recommendation': 'More steel and slab footing extensions were_x000D_needed in the structural design to maintain a ridged structure. Assessment needed in coming years of whether the quality of finish provided by_x, and in later stages the Hebel panels is upheld. More steel & slab footing extension were_X000D\xa0needed in'}],
}

Additional cleanup changes -

renamed '-' to '_' for consistency between ClusterOps and autocluster alias
cleaned ReadMe (fixing client instantiation project, key, region to token)
added additional  cluster_properties_filter: Optional[Dict] = {} param from API list_closest_to_center and list_furthest_from_center

@charyeezy can we split this pr into 2, atm i see there is a renaming pr and a summarize pr.

the summarizer PR looks good to me @charyeezy

Going to close and re-open on branch post-refactor.


Improve announcement when cursor is added.

Issue Type: Bug

With NVDA, make a sure you have an empty line below the current one.
Press NVDA+F2 to pass the next key through, then press CTRL+Alt+DownArrow to add a cursor below. If you don't pass the key through, NVDA interprets it as a table navigation command erroneously.

Actual behavior: NVDA speaks "Cursor added: 13:1" (or whatever the current line number is).
Expected behavior: The numbers could be better formatted. Depending on the synthesizer and the numbers, this could be interpreted as a time stamp. Would be better if it said "Cursor added on line x column y" or similar.

VS Code version: Code - Insiders 1.55.0-insider (84fe402d655e029eb1a5c04e675bf64788fa7fcf, 2021-03-15T05:14:29.836Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item
Value

CPUs
AMD Ryzen 9 3900X 12-Core Processor             (24 x 3800)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.95GB (20.89GB free)

Process Argv
--crash-reporter-id af385ced-002b-4d51-928c-05d733e674ab

Screen Reader
yes

VM
40%

Extensions (38)

Extension
Author (truncated)
Version

npm-intellisense
chr
1.3.1

gitignore
cod
0.6.0

doxdocgen
csc
1.1.0

dart-code
Dar
3.20.1

flutter
Dar
3.20.0

vscode-markdownlint
Dav
0.39.0

vscode-eslint
dba
2.1.17

gitlens
eam
11.3.0

EditorConfig
Edi
0.16.4

vscode-npm-script
eg2
0.3.17

prettier-vscode
esb
6.2.0

vscode-pull-request-github
Git
0.24.0

beautify
Hoo
1.5.0

better-cpp-syntax
jef
1.15.5

jstl
jsx
1.0.4

flutter-intl
loc
1.14.0

vscode-docker
ms-
1.10.0

vscode-edge-devtools
ms-
1.1.4

python
ms-
2021.2.636928669

vscode-pylance
ms-
2021.3.1

jupyter
ms-
2021.4.641214696

remote-containers
ms-
0.163.2

remote-ssh
ms-
0.65.1

remote-ssh-edit
ms-
0.65.1

remote-wsl
ms-
0.54.3

cmake-tools
ms-
1.6.0

cpptools
ms-
1.2.2

cpptools-extension-pack
ms-
1.0.0

vscode-github-issue-notebooks
ms-
0.0.72

vscode-markdown-notebook
ms-
0.0.14

vsliveshare
ms-
1.0.3968

vsliveshare-audio
ms-
0.1.91

debugger-for-edge
msj
1.0.15

indent-report
ogo
1.0.0

nunjucks
ron
0.3.0

cmake
twx
0.0.17

vscode-webhint
web
1.5.11

omnipascal
Wos
0.18.0

(1 theme extensions excluded)

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30263608
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256198
vstry914:30244316
pythonvsdeb440:30224570
pythonvsded773:30223139
pythonvspyt875:30259475
pythonvsnew554:30265444
pythontb:30258533
vsget980:30265949
vspre833cf:30267465
vsfjg287:30275553

@MarcoZehe thanks for feedback, we can easily change this. I just went with LINE:COLUMN to be concise.
So let's go with
Cursor added on line x column y
Alternative
Cursor added: line x column y

Either would be fine with me.


page.onResourceRequested is undefined

Some cases require use of onResourceRequested, onError, onConsoleMessage methods of phantomjs-node. How this is implemented in this library?

Whenever PhantomJS sends an event and node-phantom-simple recieves it through polling, node-phantom-simple will call whichever function that is correct for that event, if the function exists. If you want to use onResourceRequested, you will need to do something along the lines of:
// create driver, page etc.
page.onResourceRequested = function(id, method, url, time, headers) {
  // do something here
};

Keep in mind that all of these events are asynchronous events. This mean you won't be able to return values in cases for onConfirm or onPrompt. To return values in these instances, you will need to use:
page.setFn('onConfirm', function(message) {
  // this function won't have access to the outer-scope
  return message === 'yes';
});

Also how to add multiple parameters?
phantom.create({ parameters: { 'ignore-ssl-errors': 'yes' ,path:require('phantomjs2.0').path} }, function (err, ph) {
// do stuff
}

does not seem to work

{
  path: ...
  parameters: { ... }
}

you have wrong options structure.

does that takes a *port * parameter?

No. Port is dynamic every time you create new phantom instance. Search in old issues, that was discussed.
https://github.com/baudehlo/node-phantom-simple/blob/v1.2.0/bridge.js#L52

Can we close this issue?

Yeah. I figured it out.


FIX: gp_minimize fails for default values

Fixes https://github.com/scikit-optimize/scikit-optimize/issues/308

Codecov Report

Merging #333 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage    87.5%   87.53%   +0.03%
==========================================
  Files          26       26
  Lines        1616     1620       +4
==========================================
+ Hits         1414     1418       +4
  Misses        202      202

Impacted Files
Coverage Δ

skopt/learning/gaussian_process/gpr.py
80.85% <100%> (+0.85%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b953812...072aefe. Read the comment docs.


"Maximum update depth exceeded" when setting transformed swr data into state from useEffect

Bug report
Description / Observed Behavior
I am seeing  "Maximum update depth exceeded" React error when I try to take a version of response.data that  has been transformed in some way (elements from response.data placed into named arrays, object spread assignment to a new variable, etc) and set the array/object into state with setState from within a useEffect that also has swr data or transformed/subset version of the swr data as a dependency in the dependency array.
This may be a known issue, as something similar is mentioned here: https://github.com/vercel/swr/issues/1386
Expected Behavior
I thought I would be able to set a modified/sorted/filtered version of response.data into state without errors.
Repro Steps / Code Example
https://codesandbox.io/s/clever-firefly-bzrsq?file=/pages/index.js
(May need to rerun locally due to the nature of the error)
Additional Context
SWR version. 1.0.1

This is unrelated to #1386, the cause is
const typeAData = typedData?.filter((status) => status.type === "a") ?? [];

here a new array is always created whenever it runs, which makes the effect being triggered and a new re-render happens.
I'd do this instead:
const typeAData = useMemo(() => typedData?.filter((status) => status.type === "a") ?? [], [typedData])


slow sql long string trim

Please answer these questions before submitting pull request

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues
this PR resolves #3307

Bug fix
Add a config item in TraceServiceModuleConfig, named MAX_SLOW_SQL_LENGTH
MultiScopesSpanListener modify statement.setStatement(tag.getValue()) code

New feature or improvement

Describe the details and related test reports.

/run ci


Refs 1471: tasking fixes

Summary

moves some config values to the config parsing
fixes heartbeat timer
moves to a single heartbeat value
passes queue to tasks, for future payload updating
Adds a queue method for payload updating

Testing steps
Ensure introspection still works

build passed this time, maybe some sort of ordering issue, if we see it again we should file an issue

https://issues.redhat.com/browse/HMS-1471

⚠ This task currently requires qe-approval, but this PR does not fully resolve the task.  Please contact QE to determine appropriate testing required.

good catch, updated!

updated


Minor fixes - NPE checks and additional client validations

AuthenticationFilter : Added check to see if the redirectURI is absent
OAuthValidator : Fixed a typo
OAuthValidatorImpl : Handling the scenario where the access token request contains a blank client id
TokenResource : Authorization Code Grant flow does not verify that the authorization code was granted to the same client which is making the request for token now. Fixed this.Also put in the same check while reissuing a token with a refresh token

Hi @preetilovekar,
Thanks for your contribution and sorry that it took so long to get to it. Your commit contains a lot of whitespace changes which makes it touch a lot of lines and makes it difficult to review (see diff in this PR). Could you filter out the whitespace changes and include only functional changes in your commit?


onDidReportReaderSoftwareUpdateProgress does not work on real devices

I'm trying to recover the reader's connection progress this way.
const [progress, setProgress] = useState('0')

const { } = useStripeTerminal({
	onDidReportReaderSoftwareUpdateProgress(progress) {
		setProgress(progress)
	},
})

console.log('PROGRESS: ', progress)

In the simulator it works perfectly.
but on real device, it doesn't work.
These are my logs using LOGCAT to test on the physical device.
04-04 11:26:28.646 18293 18583 I ReactNativeJS: Starting handleDiscoverReaders
04-04 11:26:28.650 18293 18583 I ReactNativeJS: 'PROGRESS', '0'
04-04 11:26:28.897 18293 18583 I ReactNativeJS: 'PROGRESS', '0'
04-04 11:26:31.152 18293 18583 I ReactNativeJS: 'PROGRESS', '0'
04-04 11:26:31.327 18293 18583 I ReactNativeJS: 'PROGRESS', '0'
04-04 11:26:31.552 18293 18583 I ReactNativeJS: 'PROGRESS', '0'
04-04 11:26:31.740 18293 18583 I ReactNativeJS: 'PROGRESS', '0'
04-04 11:26:31.946 18293 18583 I ReactNativeJS: 'PROGRESS', '0'
04-04 11:26:49.432 18293 18583 I ReactNativeJS: 'PROGRESS', '0'
04-04 11:26:49.432 18293 18583 I ReactNativeJS: 'PROGRESS', '0'
04-04 11:26:49.432 18293 18583 I ReactNativeJS: 'PROGRESS', '0'
04-04 11:26:49.612 18293 18583 I ReactNativeJS: 'Reader connected successfully', '9431287a-b74b-4869-b284-7eb224dc9dad'

dependencies:
"expo": "^50.0.14",
"@stripe/stripe-terminal-react-native": "^0.0.1-beta.17"

hey guys, any idea about this?

do you run into this on both iOS and Android devices?

@nazli-stripe Android device

Hello, am facing the sme issue on ios device
Is there any updates about this issue?

I've test both Android and iOS via the dev-app and it works as expected, since 0.0.1-beta.17 is relatively old, would you like to try upgrade? And also wondering what device are you encounter this issue?


Add a Display Name for an organization

As part of the login experience users will see the organization name, in the below screenshot that is lci. In stead of showing the organization name we should who a "user friendly" display name, that can be set in customization section of an organization.

Duplicated by #487


Predefined variable app.home is not docuemented

${app.home} does not appear on https://github.com/mulesoft/docs-mule-runtime/blob/v4.3/modules/ROOT/pages/dataweave-variables-context.adoc besides it works properly and it's a very used one.

hi


feat(grafana): Add HTTP query parameter in DORA dashboard panels

Summary
This PR introduces a new HTTP query parameter (var-project=${project:raw}) to the links within the DORA dashboard's panels. This enhancement ensures that when a user clicks on a panel link, they are directly navigated to the external dashboard that corresponds with the Search project, as illustrated in the attached screenshot.
Screenshots

Other Information
There are some Grafana limitations e.g.: in case of multiple projects the link will not work properly, but it's very helpful when a single project is selected.

Hi @hayk96 , thanks for the PR. Perhaps we should add the time filter variable to the link as well.

@hayk96  Also, can you amend your commit message following the conventional commits guidelines?

thanks @Startrekzky! Closing this PR, will open another one.


Select strange scroll to selected item

🐛 Bug report
When Select component is at the bottom of the large content page and user click on the select the page will scroll to the selected element.
This happens only when value prop is set initially.
https://github.com/chakra-ui/zag/assets/4128883/90d7040a-cac1-4b80-9c07-0e89ad2dcd89
💥 Steps to reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

💻 Link to reproduction
https://stackblitz.com/edit/stackblitz-starters-xjxhgd?description=React   TypeScript starter project&file=src%2FSelect.tsx,src%2FApp.tsx&title=React Starter
🧐 Expected behavior
We should be able to disable this behaviour.
🧭 Possible Solution

🌍 System information

Software
Version(s)

Zag Version
0.34.0

Browser
Chrome 120.0.6099.234

Operating System
MacOS Sonoma 14.1

📝 Additional information

Good catch @isBatak.
I just pushed a fix for this. We'll release an update shortly.
If the issue persists after upgrading, I'll re-open it.


[BUG] Elasticsearch behind reverse proxy with pathprefix stripping

Context

ElasticDump version: 6.99.0
Elasticsearch version: 7.17.9
Node.js version: v16.19.0
Full command you are having issue with (with inputs and outputs):
elasticdump --input=https://example.com/searchdb/my-index --output=http://localhost:9200/my-index --type=mapping

Describe the bug
When the elasticsearch instance is behind a reverse-proxy (e.g. traefik) and reachable only through a specific path wich is stripped before forwarding the request, not just the host, e.g. "example.com/searchdb", elasticdump ignores this path, and just uses the host.
To Reproduce
Steps to reproduce the behavior:

Set up elasticsearch behind reverse-proxy, reachable under "example.com/searchdb"
call the command, see above

Current behavior
Using curl as in
curl -XPOST https://example.com/searchdb/asstr-stories/_search -D '{"query": {"match": {"text": "hello"}}}'
works.
Elasticdump ignores the path, possibly treats it as an index?
It seems to try to send requests to example.com instead of example.com/searchdb.
Expected behavior
Elasticdump honours the path.
Maybe some way to seperate host with path and index

This isn't a bug. The standard ES routes have been defined, using a reverse proxy to change the URLs doesn't affect the library only your setup.

elasticdump --input=https://example.com/searchdb --input-index=my-index --output=http://localhost:9200/my-index --type=mapping

The above should work

Thank's a lot for the quick reply and fix!! Works like a charm. Totally missed the section on "Non-Standard Install". My bad :)


Mat-list-touch rename + module update ng9

The new update has been merged. Need to update npm if the update is verified to be what this was intended for.
If not I will create a new NPM package as the name has changed anyway.

It would be nice to update NPM because that one doesn't work.. 'npm install --save mat-list-touch'

I have asked the owner, not gotten a reaction so far. Will wait a bit and then if required create my own NPM repo!
mat-list-touch does not exist yet.

@davidzwa sounds good :) @ShankyTiwari maybe you will be able to update NPM mate ;) give us a shout when you do it

I think our friend is quite busy. Will make sure to move it to another repo with another npm package. Please bear with me.
The package will be called mat-list-touch and will revolve around Angular 10 with slight interface changes.

@davidzwa just let me know if you need a hand and when you publish on NPM. Thanks mate !!

Sorry guys, I will update the repo & npm tomorrow for sure. I am quite busy with my day job.

I have updated the repo name tomorrow I will update it on NPM as well  @davidzwa

Absolute hero

@davidzwa No man, you are hero. You have been working on this from very long. Now I will make sure to give some time on this project, let's make it success.
Hi @riwos thanks for showing interest into the package, here is npm link.. Please download it and let us know if you have issues.
I haven't downloaded/tested package from NPM since it's 4AM in India, I'll have some sleep now.
Thanks,


Use jar dependencies to fix snappy compression issue

Fixes https://github.com/logstash-plugins/logstash-output-kafka/issues/50

LGTM


feat: enable mtls on external application application load balancer

This PR provides the following:

Enable mTLS support on an external application load balancer by specifying a server SSL policy.
Add .python-version to git ignore for contributors with multiple python versions on their machines.

This is my first attempt contributing to the project, please let me know if I need to do further checks or changes. Also, I had tests failing but none of them seemed related to what I am changing.

Checklist

I applicable, I acknowledge that I have:

[X] Read the contributing guide
[X] Ran terraform fmt on all modified files
[X] Regenerated the relevant README.md files using tools/tfdoc.py
[X] Made sure all relevant tests pass

I think the new flag should go under var.https_proxy_config. @ludoo wdyt?

@Tazminia instead of a top level variable, can you add a field to var.https_proxy_config?
Thanks!

@juliocc of course. I will handle it and push again.

I moved the variable as requested.