FineUploader - completely replace instance / dynamically update options

Type of issue

[ ] Bug report
[X] Feature request

Uploader type

[X ] Traditional
[ ] S3
[ ] Azure

Feature Request
Feature request details
Hi, we have a requirement for which we need to dynamically switch between options depending a form drop-down selection. Struggling to figure this out and whether is actually doable.
What has been tried thus far - calling a function "RenderFineUploader" and have the option replace with a dynamic global.
For instance -
allowedExtensions: extensions
Depending on the drop down selection this option needs to be different, so we need to re-render on change of this option, the problem I find is I suspect this creates two instances, I am able to to a reset prior to the render, in which case I get the no files selected (for the prior rendered fineuploader) and also a successfully submitted file for the next render for which the user has been able to add a file and click a submit, I get both successful and this error showing up on single submission.
So its holding a reference to the prior fine uploader, any ideas / solution to this, note I have read the docs, but nothing so specific to this issue, maybe I have just missed it.

Options cannot be changed once they are set. If there is a specific one you need to adjust dynamically and it isn't already accounted for in the methods/API documentation, please open up a case w/ the specifics.


Extend timestamp variable parameters in File name format

Scenario Overview
We use s3 filename template prefix/'%Y_%m_%d__%H_%M_%S_%f to sort filenames alphabetically.
The next new file is guaranteed to receive the following name in alphabetical order.
In kafka, we have several partitions of one topic, each of them must be written with the same prefix (prefix=topic_name) in order.
It's possible to ensure the files order with this template by running no more than 1 connector task.
Issue:
Timestamp variable have next parameters:
unit parameter values:
yyyy - year, e.g. 2020 (please note that YYYY is deprecated and is interpreted as yyyy)
MM - month, e.g. 03
dd - day, e.g. 01
HH - hour, e.g. 24

Consequences:
With these parameters, files recorded within 1 hour will not differ in name.
Adding the partition number and offset to the file name in the template can solve this problem, but it makes working with the root prefix more difficult.
Uniqueness can be ensured by adding minutes, seconds, milliseconds to the timestamp variable.
Details:
Looks like it's enough to extend the following functionality :
    private static final Map<String, DateTimeFormatter> TIMESTAMP_FORMATTERS =
            Map.of(
                    "yyyy", DateTimeFormatter.ofPattern("yyyy"),
                    "MM", DateTimeFormatter.ofPattern("MM"),
                    "dd", DateTimeFormatter.ofPattern("dd"),
                    "HH", DateTimeFormatter.ofPattern("HH")
            );

with next parameters:
"%M" - Minutes in two-digit format.
"%S" - Seconds in two-digit format.
"%f" - Microseconds.

This is a fairly old issue.  Is it still active?
My note is that timestamps within the millisecond do not guarantee uniqueness and data loss may occur on high frequency topics.


Naive state

Here I am experimenting with a different representation of state that is easier to monomorphize.

The PR is starting to look solid. I implemented the new local state for all backends, except LLVM (and machine for that matter).
It would be very valuable to get feedback from @marzipankaiser, @serkm, and @phischu on how to proceed with machine. You don't have to look at the whole PR, the essential change is this in lifted.Tree:
-  case State(id: Id, init: Expr, region: Symbol, ev: Evidence, body: Stmt)
+  // allocates into a (type-monomorphic?) region.
+  // e.g. var x in r = init; body
+  case Alloc(id: Id, init: Expr, region: Id, ev: Evidence, body: Stmt)
+
+  // creates a fresh state handler to model local (backtrackable) state.
+  // e.g. state(init) { (ev){x: Ref} => ... }
+  case Var(init: Expr, body: Block.BlockLit)

https://github.com/effekt-lang/effekt/pull/235/files#diff-0555635c10275b9368035de048ce1782d57df07d499fc1671fb799d45586aa0bR125-R132
For now, I changed the test files to use an explicit region instead of local mutable state.
-def main() = {
-    var n = 0
+def main() = region r {
+    var n in r = 0

https://github.com/effekt-lang/effekt/pull/235/files#diff-52c3c58f95cb33c9fbda0911bef989780e255f229c04410a7f5e94d98320429cL18-L19
but this is only a temporary fix. Any feedback on how to proceed with machine is very welcome!

@serkm I have yet another idea for the implementation of local mutable state.
It crucially relies on going back to the "copy-on-share" strategy. This means that shareStack immediately deep-copies the stack instead of bumping the reference count. This way every reference is to a stack indeed is always unique. I don't remember why we changed that but there was a reason.
Now when we want to create a local mutable reference we push a frame that contains the value. References are offsets from the bottom of the stack. Getting the content of a reference means finding the correct stack using evidence and then reading the value at the offset. Setting the content of a reference finds the location in the same way and directly writes to it on the stack.
For arenas we could do the same except that the frame contains a reference to the arena and erase and share and return do the correct thing with it.
A corner case is allocating into the global region which would create a reference on the heap.


built-in Android IAP bug - android 8 and 9

Godot version:
3.1.1
OS/device including version:
android 8.1.0 and 9
Issue description:
Fatal Exception: java.lang.NullPointerException
Attempt to invoke interface method 'android.os.Bundle com.android.vending.billing.IInAppBillingService.getSkuDetails(int, java.lang.String, java.lang.String, android.os.Bundle)' on a null object reference
org.godotengine.godot.payments.PaymentsManager$7.run (PaymentsManager.java:390)
java.lang.Thread.run (Thread.java:780)
Steps to reproduce:
Minimal reproduction project:

Possibly a duplicate of https://github.com/godotengine/godot/issues/30922?
What are the steps to reproduce the problem?

Looks like duplicate of #30922. If, not OP can respond with more info and we can re-open.


Update ihexload.cpp

These are the changes I had to make to get Arduino IDE to compile the VDP patch code

Hi,
You seem to be perhaps using an older ESP32 library with your Arduino installation. The later versions all include the 'arduino.h', that specifies the byte typedef from uint8_t that you are also missing.


WPF (.NET 5): Icon and Manifest missing?

Version
1.0.1
Details
I've tried to use DotnetRuntimeBootstrapper in a .NET 4.8 and also in a .NET 5 Desktop App (both are using WPF). Using the bootstrapper in .NET 4.8 works fine without any problems.
But in my other project (.NET 5) the App-Icon is missing, and the Microsoft.Windows.Common-Controls which I enabled in the app.manifest for MessageBoxes seems not to work.
So, I made a small test-project, which has an icon, an app.manifest and a button which shows a MessageBox:

Steps to reproduce

Create a test project (.NET 5; WPF)
Add an icon
Add an app.manifest and enable common-controls (last commment in app.manifest)
Install DotnetRuntimeBootstrapper
Start

Hi!
Thanks for the report. The manifest part I think I know how to fix, but the icon should already work. At the very least it's working in the demo project here: https://github.com/Tyrrrz/DotnetRuntimeBootstrapper/tree/master/DotnetRuntimeBootstrapper.Demo
Are you referring to the icon on the .exe file itself and in taskbar or something else?

I've tried to use DotnetRuntimeBootstrapper in a .NET 4.8...

Bootstrapper can currently only install the new .NET (i.e. the core one), so it probably wouldn't make much sense to use with legacy .NET. 😄

The manifest part I think I know how to fix, but the icon should already work. At the very least it's working in the demo project here: https://github.com/Tyrrrz/DotnetRuntimeBootstrapper/tree/master/DotnetRuntimeBootstrapper.Demo

You're right, I've tested it in your demo project and it works fine there. So, I was really confused, because in all of my other projects it didn't work. So, I removed the nuget package from my project and added the assembly reference directly from your repro, which I downloaded before to test the demo project, and it works! And the manifest seems also to work.
I don't really know, but it seems that there are differences between the latest version and the version 1.0.1 from the nuget package, but I couldn't see any commits related to icon/manifest after version 1.0.1.

Bootstrapper can currently only install the new .NET (i.e. the core one), so it probably wouldn't make much sense to use with legacy .NET. 😄

It was basically just a test, to see if this bug is related to .NET 5. But I am really sure a version of DotnetRuntimeBootsrapper for older version of .NET like .NET 4.8 would be also a really good idea :smile:

@andyld97 could you try running dotnet build --verbosity normal? That should include some logs from the bootstrapper task which can maybe give some clues.

Also, in the WpfApp4 sample you sent me, it appears that WpfApp4.exe does have an icon for me:

log.txt
And yes, the WpfApp4.exe file has an icon, that's correct. The thing is, that if you open it, there is the default icon in the taskbar and this default icon is also in the titlebar of the window (left to MainWindow), as I already mentioned in the first post.

I believe the icon in the top left of the window and in the taskbar is set directly on WPF's window via Icon="/myicon.ico". It's separate from the icon that's embedded inside the exe file.
I made a few changes to your csproj:
MainWindow.xaml:
<Window x:Class="WpfApp4.MainWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        xmlns:local="clr-namespace:WpfApp4"
        mc:Ignorable="d"
        Icon="/VU.ico"
        Title="MainWindow" Height="450" Width="800">
    <Grid>
        <Button x:Name="ButtonShowMsgBox" Click="ButtonShowMsgBox_Click"  Content="Test Manifest" Margin="100" />
    </Grid>
</Window>

WpfApp4.csproj:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>WinExe</OutputType>
    <TargetFramework>net5.0-windows</TargetFramework>
    <UseWPF>true</UseWPF>
    <ApplicationIcon>VU.ico</ApplicationIcon>
    <ApplicationManifest>app.manifest</ApplicationManifest>
  </PropertyGroup>

  <ItemGroup>
    <Resource Include="VU.ico" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="DotnetRuntimeBootstrapper" Version="1.0.1">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>
  </ItemGroup>

</Project>

And the icon is shown as expected:

Okay, setting the property "Icon" on a window seems to be a workaround, for the icon, but then there's still this problem with app.manifest.
But I am working with wpf since a few years now, and I am really sure, that setting the "Icon"-Property is not required to set the app-icon, it's rather meant to be used to override the default icon which is the icon set in the project settings (if any).
I really would like to use DotnetRuntimeBootstrapper, but I have a project where I have many windows and I don't really want to set the icon for each window, because without DotnetRuntimeBootsrapper it already works.
Maybe there is something wrong with the nuget package? I checked out your YouTubeDownloer, but you're also setting the Icon-Property explicitly.
Sorry, I don't want to annoy you with these little "problems", but I don't know if you feel that pain, that the default icon and the default MessageBox-Style looks really not professional.

But I am working with wpf since a few years now, and I am really sure, that setting the "Icon"-Property is not required to set the app-icon on a window, it's rather meant to be used to override the default icon on this window which is the icon set in the project settings (if any).

I just tried that and you're right. I've been using WPF for years and I've always been putting icons on every window, I had no idea it was somehow inherited from the exe file 🤔
Interestingly enough, when you run it via dotnet WpfApp4.dll the icon is not there. However if you define it via <Icon> property then it works both when launched directly or via exe. I wonder what the original shim is doing to achieve this?
The manifest issue is a separate problem from the icon actually. I know what's causing it, but not entirely sure how to fix it.
You mentioned that you tried using the bootstrapper directly from the repo instead of the package, but are you sure it was actually generated? You can check that by right clicking the exe file, clicking "Properties" and then "Details" and then checking if the "Original filename" is DotnetRuntimeBoostrapper.Executable.dll:

The manifest issue is a separate problem from the icon actually. I know what's causing it, but not entirely sure how to fix it.

Okay, good to know!

clicking "Properties" and then "Details" and then checking if the "Original filename" is DotnetRuntimeBoostrapper.Executable.dll

Okay, so it seems like I did something wrong, because it is not used, and that's why the issue didn't occur.


订阅行情之后会断流

GATEWAY：BINANCE_SPOT
订阅之后几个小时以后会断流，原因不明。（大概4个小时？）
断流之后就不会再收到更新了，暂时不清楚是不是币安的限制还是纯粹的网络问题。
但不管是哪个，之后也无法恢复。
暂时找到的办法只有先清掉market_ws_api.ticks，再重新订阅一次。
main_engine.get_gateway("BINANCE_SPOT").market_ws_api.ticks.pop("ethbtc")

I met the exact same question for the BINANCE-USDT gateway. What's the problem do you think?

I met the exact same question for the BINANCE-USDT gateway. What's the problem do youat think?

I don't know how this happened. After several tries, I found that it happened at different length of time, which means this may just be a websocket disconnected problem and vnpy_binance did not handle it (for example reconnect).
Now I use a workaround, check if last_tick timestamp is behind currerent time 20 seconds, pop symbols and re-subscript it.
main_engine.get_gateway("BINANCE_SPOT").market_ws_api.ticks.pop("ethbtc")
It works fine, for now.

will check on this later

@Zigngit 刚刚开始基于VNPY做策略，也遇到了同样的断流问题，您的临时解决方案具体是怎么修改的，可以分享个demo给我吗？万分感谢！

will check on this later

The reason for this problem is binance’s api work wron.

the api even you call it within an hour，the listenKey stil will become invalid.

this is my solution。

this api said If the account has an active listenKey, that listenKey will be returned and its validity will be extended for 60 minutes.,but is worng,the listenKey still will be change,you hava to reset it.

@xuxin3101 @vn-crypto
I don't think the problem comes here. I think the fundamental problem comes from the break of the trade/market data websocket. It may be the network problem of your own trading server even if you are using AWS or AlibabaClound.
I think the ultimate solution is to monitor the connection of the trade/market data websocket. Whenever the websocket breaks,
the gateway should reconnect it as soon as possible.

@Zigngit @xyxido @xuxin3101 @vn-crypto 我们一起建立个关于币安接口的微信群如何？ CoolQuant, 这个是我的微信号，大家有兴趣的话加我一下，平时遇到的币安接口问题我们可以及时在群里沟通。

How about this solution?

will check on this later

The reason for this problem is binance’s api work wron.  the api even you call it within an hour，the listenKey stil will become invalid.  this is my solution。  this api said If the account has an active listenKey, that listenKey will be returned and its validity will be extended for 60 minutes.,but is worng,the listenKey still will be change,you hava to reset it.

@xuxin3101 我实测了一下listenkey，发现一两个小时之内断开后重连，短时间内的listenkey都是不变的，并没有发现每次延迟listenkey就发生变化的情况啊，请问你是怎么发现延长后的listenkey变化了呢？

加个事件打印看看


Feature request: Save File As improvement

The text is selected (the file name, untitled.txt), but the focus is not on the text box. Pressing any keys will not type into the text box, instead selecting existing files. This is annoying.

Makes sense, i'll fix it.

Improved, it will be available in the next release.


.eth vs .test TLD corrections (helps us noobs ;)

Sorry, total noob here, but was working through this quickstart guide and noticed that I couldn't get my FIFS registrar name resolved to my address just by copy-pasting the code, as the FIFS registrar won't accept the .eth TLD. Made other small formatting corrections.

Thanks!


Add plugin header and license information

Must add a header for the plugin with license information before releasing.

Initial infrastructure done. May need to add a line or two later.


minify flatgraph migration: promote neighbor accessors (remove _ prefix)

discussed via slack, will leave as is since these are technical accessors which are different from the named steps..


Create an example of doing distributed offline inference

Creating an example of doing distributed offline inference with Ray Data and vLLM. If people are already doing offline inference, it's likely that 1) the volume of data is large and 2) it's beneficial to harness the power of multiple cheap GPU nodes

@simon-mo @Yard1 Can I have a quick review? We are seeing several LLM batch inference use cases coming up. Thanks!

#2696 is a better version. Closing this one

Yes I reviewed #2696


[WIP] JDBC Driver side PreparedStatement

I'm using this implementation as a hacky workaound. Once https://github.com/prestodb/presto/pull/5414 is merged I would reimplement with it.
It still includes unimplemented methods. No test.
This PR implements PreparedStatement at client side. JDBC Driver parses the given SQL, replaces variables, generate new SQL then send it to REAT API.

find a marker; this cannot be a String to prevent conflicting with '?' in String literal.
replace all "?" with the marker so that SqlParser can parse.
parse sql to get AST
check all marker occurrences and remember the position
replace marker with values by rewriting AST
generate SQL from new AST

-> https://github.com/treasure-data/presto/pull/5


consolidate bpf_helper assets

Is your feature request related to a problem? Please describe.
Combine the following into a single JSON file

[asset/bpf_helpers_desc_mod.json]
[asset/helper_hookpoint_map.json]
Describe the solution you'd like
create single json and then replace calls to load/use one of the dict with other

done.. all bpf_helper_info is in asset/bpf_helpers_desc_mod.json.


KOGITO-1567: Export source code as GitHub gist

Task: KOGITO-1567
Demo

@jomarko when you have a chance could you please take a look at this?

Thanks for the review, @jomarko!
Here are the answers for your questions from my point of view:

This operation is like an export, so a new gist will be generated every time you click on the button, even if you do not change anything. In other words, this feature is not meant to update an existing gist but always create a new one regardless of their content.
It seems like a bug. I'll take a look on that.
It seems like an issue with the infrastructure that retrieves the file content. I'll take a look.

@caponetto @jomarko Thanks Jozef for the review! As a suggestion, we could simply disable the "Gist it!" button once it's clicked. WDYT?
CC @srambach is "disabling a button after clicking" a thing? Does it have UX/a11y implications we should be aware of?

@tiagobento IMO disabling the button would bring more confusion than benefits.
The download operation is similar if you think about it.

@jomarko
About your 3rd question: Is your Firefox version < 74? Apparently, the formatter only works on Firefox version >= 74. If you think this is an issue, I suggest opening a new Jira because it affects the other operations as well, such as download and copy.

@caponetto my firefox is 70
@caponetto @tiagobento about the point 1 - name of gist file, I think disabling button is not proper option. For me is also fine we will not override existing gist but creating new.
However for me was issue to distinguish which gist is latest vs. oldest, maybe just adding timestamp would help? But not sure if that is ok from UX point of view @srambach ?

My 2 cents on this.
@jomarko if the user created it twice, he is exporting twice, so we expect that this will generate two gist files (with same name but different ids). I would say that adding a timestamp is not ideal because it will change the expected name from gist file due to a corner case and it will make the file name (on the URL) weird.
About the formater issue on firefox < 74, @caponetto could you please create a JIRA?


OMG this is awesome

Is there anyway to turn (rotate) the square on the hoe / cultivator? I see that it now just aligns to the world so all the streets need to do the same? Right now, I only see a way to make perfectly straight and perpendicular roads. I just want to make sure I'm not missing something. :)

Initially I inteded to respond with some form of: "Alas, this isn't practically possible with the way the game engine of Valheim is". However with some quick exaperimentation... I'm not so sure anymore.
TLDR: You're not missing anything as of now. As of "tomorrow" - I'll keep the door open on this :)

I think MassFarming has a rotate grid function of some sort -- at least I figured out how to use that in order to rotate the planting grid whenever it was stuck aligning to the world.

PS. I love this mod :) thank you for making it.


Catch swapOrderHelper.getOrder errors

Changes

Adds a catch block when calling swapOrderHelper.getOrder on TwapOrderMapper, so the transaction is mapped to a TWAP order even if some partial orders are not found on the CowSwap API.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

3 of 12 (25.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 48.767%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/routes/transactions/mappers/common/twap-order.mapper.ts
3
12
25.0%

Files with Coverage Reduction
New Missed Lines
%

src/routes/transactions/mappers/common/twap-order.mapper.ts
2
28.05%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
4195

Relevant Lines:
6937

💛  - Coveralls


Added support for encrypted passwords

The plugin will get credentials from the settings.xml file but it does not currently support encrypted passwords.

@hrmohr Maybe update the README to explain how to use this?

I was wondering more about the SecDispatcher. I couldn't find any docs on
this.
On Thu, May 7, 2015 at 11:16 AM, Mads Mohr Christensen <
<EMAIL_ADDRESS>wrote:

The documentation can be found in the official Maven documentation
https://maven.apache.org/guides/mini/guide-encryption.html
Should I just add a link to this in the readme?
—
Reply to this email directly or view it on GitHub
https://github.com/spotify/docker-maven-plugin/pull/87#issuecomment-99905748
.

--
David Xia
Software Engineer
<EMAIL_ADDRESS>

@davidxia If you are thinking about the role-hint then this is explained in https://jira.codehaus.org/browse/MNG-4384

@hrmohr sorry for the long delay. I'm not that familiar with SecDispatcher and if they have docs, I didn't find them.
Everything looks good. This change won't require users to encrypt their passwords right? They simply don't create a ~/.m2/settings-security.xml?

@davidxia No problem. I have added some basic documentation just as you asked.
Maven only considers passwords enclosed in curly braces as encrypted. So encryption is not required but controlled by the format.

Eh, why did the build fail because of a long javadoc line?

Hey thanks for adding to the docs. We have a check style plugin that fails
if there are lines of more than 100 chars.
On Saturday, August 8, 2015, Mads Mohr Christensen<EMAIL_ADDRESS>wrote:

Eh, why did the build fail because of a long javadoc line?
—
Reply to this email directly or view it on GitHub
https://github.com/spotify/docker-maven-plugin/pull/87#issuecomment-128970182
.

--
David Xia
Software Engineer
<EMAIL_ADDRESS>

@hrmohr Thanks!


Service Provider (SaaS) doesn't work across tenants

Service Provider created with checkbox (Saas) inside "carbon.super" doesn't work across tenants (with versione 5.11-beta5). Instead it works correctly with IS 5.10
How to reproduce:

Login as "carbon.super" admin
Create Service Provider with Saas enabled (with OAuth2-OpenID Connect Single-Sign-On)
Create Tenant t1
Create Sample application to try Single-Sign-on

Expected behavior:
Ability to log in with user of "carbon.super" and of tenant t1.
Instead it is not possible to log in with user of tenant (I get error 401)
Environment information

Product Version: IS 5.11.0-beta5
OS: [Linux]
Database: [H2]
Userstore: [JDBC]

Optional Fields
Suggested labels:
Affected/5.11.0-beta

I was able to login successfully when using the tenant qualified username.

Closing the issue as cannot reproduce. Please reopen if needed.

I'm sorry for for inaccurate steps to reproduce.
How to reproduce:

Login as "carbon.super" admin
Create Service Provider with Saas enabled (with OAuth2-OpenID Connect Single-Sign-On), and choose as Token Issuer the option JWT

Create Tenant t1
Create Sample application to try Single-Sign-on

@janakamarasena I don't have the permissions to reopen the bug (I don't know if it's better open another issue)

Are you trying to SSO or generate a token from a saas app?

I'm using Spring Coud Gateway and after login process (with tenant user) I have this log:
2020-11-13 07:35:14.584 DEBUG 53 --- [or-http-epoll-4] o.s.w.r.f.client.ExchangeFunctions       : [42e504bb] HTTP GET https://dev-local:443/oauth2/userinfo
2020-11-13 07:35:14.599 DEBUG 53 --- [or-http-epoll-4] o.s.w.r.f.client.ExchangeFunctions       : [42e504bb] Response 401 UNAUTHORIZED

I am not familiar with the Spring Cloud Gateway. But with logs you have added it looks like you are trying ti access the userinfo endpoint of the super.tenant.
Since your user is in a tenant(t1) the userinfo endpoint that is called should also be the tenants (t1) userinfo endpoint (https://dev-local:443/t/t1/oauth2/userinfo)
I tested in that way and it works.
Adding the tenants userinfo enpoint should work. If this doesn't work for you can you attach the whole DEBUG log related to the login process from the gateway and also the har log related to your browser interactions so its possible to get a better understanding on what's happening.
If your trying to have single userinfo endpoint for all tenants, OOTB this is not possible AFAIK (@mefarazath please correct me if am wrong).
You could either do a customisation in the Identity Server to handle this internally. Or since your using JWTs you can get the user's tenant domain by extracting it from the sub claim of the jwt and the using it to construct the userinfo endpoint via an extension to the gateway if such extensions are possible at the gateway.
To append the tenant domain to the sub claim you need to tick the "Use tenant domain in local subject identifier" checkbox under "Local & Outbound Authentication Configuration" inside the relevant saas SP configurations.

I tried to use the tenants (t1) userinfo endpoint and the log the log has improved but the login process did not work.
I'll prepare a better scenario (whole DEBUG, har log and a github project of spring boot gateway to test)
I focus that single userinfo endpoint for all tenants works with 5.10, so appear me a breaking changes.
Moreover the reponse of url https://dev-local/t1/oauth2/token/.well-known/openid-configuration contains only the key "jwks_uri" tenant-based
end_session_endpoint: "https://dev-local:443/oidc/logout",
revocation_endpoint: "https://dev-local:443/oauth2/revoke",
userinfo_endpoint: "https://dev-local:443/oauth2/userinfo",
code_challenge_methods_supported: [
"S256",
"plain"
],
jwks_uri: "https://dev-local:443/t1/oauth2/jwks",

Hi,
I created this project
https://github.com/giannaccio/spring-gateway-wso2
where it's possibile trying spring-cloud-config integrated with wso2-is
(I hope README it's clear)
Debugging login process I understand the following points:

With Token Issuer Default, it's possible login with
issuer-uri: ${provider.host}/oauth2/token
or
token-uri: ${provider.host}/oauth2/token authorization-uri: ${provider.host}/oauth2/authorize user-info-uri: ${provider.host}/oauth2/userinfo jwk-set-uri: ${provider.host}/oauth2/jwks

Instead, with Token Issuer JWT, using
token-uri: ${provider.host}/oauth2/token authorization-uri: ${provider.host}/oauth2/authorize user-info-uri: ${provider.host}/oauth2/userinfo jwk-set-uri: ${provider.host}/oauth2/jwks
wso2is log this error
[2020-11-15 15:52:33,326] [a000f2e2-dcf6-43f3-8ae6-3659fbd84c32] DEBUG {org.wso2.carbon.identity.oauth.endpoint.user.OpenIDConnectUserEndpoint} - Error while building user info response. org.wso2.carbon.identity.oauth.user.UserInfoEndpointException: Access token validation failed         at org.wso2.carbon.identity.oauth.endpoint.user.impl.UserInfoISAccessTokenValidator.validateToken(UserInfoISAccessTokenValidator.java:63)         at org.wso2.carbon.identity.oauth.endpoint.user.OpenIDConnectUserEndpoint.getUserClaims(OpenIDConnectUserEndpoint.java:76)         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)         at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.base/java.lang.reflect.Method.invoke(Method.java:566)         at org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:179)         at org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)         at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:201)         at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:104)         at org.apache.cxf.interceptor.ServiceInvokerInterceptor$1.run(ServiceInvokerInterceptor.java:59)
Settings
token-uri: ${provider.host}/oauth2/token authorization-uri: ${provider.host}/oauth2/authorize user-info-uri: ${provider.host}/t/test.com/oauth2/userinfo jwk-set-uri: ${provider.host}/oauth2/jwks user-name-attribute: sub
it's work but it's a strange configuration and different from wsois-5.10

@janakamarasena @mefarazath  let me know if you need more details.

Please let me know if you need more details, or in generale the status of the issue.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


[BUG] cardano-prelude missing in build-depends section

cardano-rt-view is missing cardano-prelude in it's build-depends section of cardano-rt-view.cabal, see below:
[    4s] + cd cardano-rt-view-0.1.0
[    4s] + '[' -f Setup.hs -o -f Setup.lhs ']'
[    4s] + '[' -x Setup ']'
[    4s] + ghc --make -no-user-package-db Setup
[    4s] [1 of 1] Compiling Main             ( Setup.hs, Setup.o )
[    4s] Linking Setup ...
[    7s] + LANG=en_US.utf8
[    7s] + ./Setup --version
[    7s] Cabal library version <IP_ADDRESS>
[    7s] + '[' -x Setup ']'
[    7s] + LANG=en_US.utf8
[    7s] + ./Setup configure --prefix=/usr --libdir=/usr/lib64 --docdir=/usr/share/licenses/cardano-rt-view '--libsubdir=$compiler/$pkgid' '--datasubdir=$pkgid' --ghc '--dynlibdir=/usr/lib64/$compiler/$pkgid' --global '--ghc-options= ' -v -p --enable-shared --htmldir=/usr/share/doc/ghc-8.10.2/html/libraries/cardano-rt-view-0.1.0 --global
[    8s] Using Parsec parser
[    8s] Configuring cardano-rt-view-0.1.0...
[    8s] CallStack (from HasCallStack):
[    8s]   $, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:1024:20 in Cabal-<IP_ADDRESS>:Distribution.Simple.Configure
[    8s]   configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:477:12 in Cabal-<IP_ADDRESS>:Distribution.Simple.Configure
[    8s]   configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:625:20 in Cabal-<IP_ADDRESS>:Distribution.Simple
[    8s]   confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:65:5 in Cabal-<IP_ADDRESS>:Distribution.Simple.UserHooks
[    8s]   configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:180:19 in Cabal-<IP_ADDRESS>:Distribution.Simple
[    8s]   defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:116:27 in Cabal-<IP_ADDRESS>:Distribution.Simple
[    8s]   defaultMain, called at Setup.hs:2:8 in main:Main
[    8s] Setup: Encountered missing or private dependencies:
[    8s] cardano-prelude -any
[    8s]
[    8s] error: Bad exit status from /var/tmp/rpm-tmp.1Of1RU (%build)

cardano-rt-view is missing cardano-prelude in it's build-depends section of cardano-rt-view.cabal

Of course, it is! :-) RTView doesn't depend on cardano-prelude anymore.

cardano-rt-view is missing cardano-prelude in it's build-depends section of cardano-rt-view.cabal

Of course, it is! :-) RTView doesn't depend on cardano-prelude anymore (please see this commit: e00363f). IMHO, the custom Prelude is not so good idea, and I prefer using the standard one.

I see, I must've been using earlier master tagged as 0.1.0, welcome to nuances of making RPM packages when you structured your application the way you did! :)


Remove unused var in BaseRewriteManifests

This PR removes the unused var in BaseRewriteManifests.

+1 when tests pass


Dynamic Pages?

Has anyone extended this boilerplate to generate pages from a json file, vs from files in the /pages directory?
What I'd like to do is have a /data/pages.json (which would get pulled in dynamically on build from a db, but let's walk before we run ;). Each page is composed of sections, which would be React components. Something like...
[
  {
    "name": "01",
    "sections": [
      {
        "template": "one-col",
        "headline": "page 1 section 1 headline",
        "cta": "page 1 section 1 cta"
      },
      {
        "template": "two-col",
        "headline": "page 1 section 2 headline",
        "cta": "page 1 section 2 cta"
      }
    ]
  },
  {
    "name": "02",
    "sections": [
      {
        "template": "two-col",
        "headline": "page 2 section 1 headline",
        "cta": "page 2 section 1 cta"
      },
      {
        "template": "one-col",
        "headline": "page 2 section 2 headline",
        "cta": "page 2 section 2 cta"
      }
    ]
  }
]

Looking at getPages in render.js, could extend the files object with any pages in /data/pages.json before iterating through, but maybe there's a better approach?
Any ideas?

One way of approaching this problem is by creating a custom loader for Webpack that will pull data from a database. You can take a look at the Markdown example here:
/routes/about/index.js#L21
/tools/webpack.config.js#L100-L103
/tools/webpack.markdown-loader.js
I will close this issue for now, since it was open for a long time. But feel free to reopen!

@shaekuronen this has been implemented, the routes are now generated from the /routes.json, check it out:
https://github.com/kriasoft/react-static-boilerplate/blob/master/routes.json
https://github.com/kriasoft/react-static-boilerplate/blob/master/utils/routes-loader.js


How to retrieve the distilled model in a manner similar to the OpenAI API interface ?

I used the script tune run --nnodes 1 --nproc_per_node 2 knowledge_distillation_distributed --config llama3_2/8B_to_1B_KD_lora_distributed to distill the model and saved the results to /tmp/torchtune/llama3_2_8B_to_1B/KD_lora_distributed. How can I run my 1B model in a way similar to the OpenAI API to verify its effectiveness?

Congrats on the successful fine-tune @lingq1!
There are a couple ways to determine effectiveness of your model.

Benchmarks - These are standardized datasets where the output from your model is compared against the desired output for a given task. Some common benchmarks include MMMU, which collects subsets of knowledge from science, anthropology, algebra, etc and asks models a series of multiple choice questions to see how close it gets to the right answer. The advantage of benchmarks is they are easy to compare against other model's performances. The disadvantage is that they can be fairly easy to game, so the longer a benchmark is around the less useful it tends to be.
Vibes - Another popular way of measuring the effectiveness of your model is just to play around with it for awhile! Ask it some questions, try to stump it, see what interesting behavior emerges.

I believe that both approaches are important to determining if your fine-tuned model is "good". So how can you implement these methods in torchtune?
For benchmarking, torchtune provides an integration with the EleutherAI Eval Harness. Simply create a config similar to the following example:
# Model Arguments
model:
  _component_: torchtune.models.llama3_2.llama3_2_1b

# Checkpointer
checkpointer:
  _component_: torchtune.training.FullModelHFCheckpointer
  checkpoint_dir: /tmp/torchtune/llama3_2_8B_to_1B/KD_lora_distributed/epoch_X # substitute with your final epoch number
  checkpoint_files: [model.safetensors]
  output_dir: ./ # Not needed
  model_type: LLAMA3_2

# Tokenizer
tokenizer:
  _component_: torchtune.models.llama3.llama3_tokenizer
  path: /tmp/torchtune/llama3_2_8B_to_1B/KD_lora_distributed/base_model/original/tokenizer.model

# Environment
device: cuda
dtype: bf16
seed: 1234 # It is not recommended to change this seed, b/c it matches EleutherAI's default seed

# EleutherAI specific eval args
tasks: ["truthfulqa_mc2"]
limit: null
max_seq_length: 4096
batch_size: 8
enable_kv_cache: True

# Quantization specific args
quantizer: null

And run this config with tune run eleuther_eval --config PATH/TO/YOUR/CONFIG.YAML
Now for playing around with the model, you have some options. torchtune provides a generation script that works OOTB; however, it is very simple and only lets your use a set prompt to receive some output - there is no chat functionality.
# Model Arguments
model:
  _component_: torchtune.models.llama3_2.llama3_2_1b

# Checkpointer
checkpointer:
  _component_: torchtune.training.FullModelHFCheckpointer
  checkpoint_dir: /tmp/torchtune/llama3_2_8B_to_1B/KD_lora_distributed/epoch_X # substitute with your final epoch number
  checkpoint_files: [model.safetensors]
  output_dir: ./ # Not needed
  model_type: LLAMA3_2

# Tokenizer
tokenizer:
  _component_: torchtune.models.llama3.llama3_tokenizer
  path: /tmp/torchtune/llama3_2_8B_to_1B/KD_lora_distributed/base_model/original/tokenizer.model
device: cuda
dtype: bf16

seed: 1234

# Generation arguments; defaults taken from gpt-fast
prompt:
  system: null
  user: "Tell me a joke."
max_new_tokens: 300
temperature: 0.6 # 0.8 and 0.6 are popular values to try
top_k: 300

enable_kv_cache: True

quantizer: null

And launch with tune run generate --config PATH/TO/YOUR/CONFIG.YAML
However, thanks to some awesome work from @felipemello1, it's also really easy to chat with your model through torchtune's integration with vLLM!! Follow the steps outlined in this PR description to get started. Once you have everything setup you can run vLLM locally:
from vllm import LLM, SamplingParams

def print_outputs(outputs):
    for output in outputs:
        prompt = output.prompt
        generated_text = output.outputs[0].text
        print(f"Prompt: {prompt!r}, Generated text: {generated_text!r}")
    print("-" * 80)

llm = LLM(
    model="/tmp/torchtune/llama3_2_8B_to_1B/KD_lora_distributed/epoch_X", # substitute with your final epoch number
    load_format="safetensors",
    kv_cache_dtype="auto",
)
sampling_params = SamplingParams(max_tokens=16, temperature=0.5)

conversation = [
    {"role": "system", "content": "You are a helpful assistant"},
    {"role": "user", "content": "Hello"},
    {"role": "assistant", "content": "Hello! How can I assist you today?"},
    {
        "role": "user",
        "content": "Write an essay about the importance of higher education.",
    },
]
outputs = llm.chat(conversation, sampling_params=sampling_params, use_tqdm=False)
print_outputs(outputs)

Lastly, I know you mentioned that OpenAI API compatible evaluation ... this probably isn't the fastest way to get things up and running, but because torchtune integrates with vLLM and vLLM provides a similar interface, this is totally possible! You can read more on setting this up here.
Feel free to post some results when you're done evaluating!

@joecummings So did the application scenario I mentioned above not suit the use of distillation technology, or is there room for parameter optimization?

IIUC correctly, your model performed better after distillation on your benchmarking than before? In that case, it seems that distillation worked?
To make sure though that this is working properly, can you try directly finetuning your small 1B model and comparing it to the distilled model? The distilled model should perform slightly better than direct finetuning b/c it's incorporating the distribution from the much larger model.

IIUC correctly, your model performed better after distillation on your benchmarking than before? In that case, it seems that distillation worked?
To make sure though that this is working properly, can you try directly finetuning your small 1B model and comparing it to the distilled model? The distilled model should perform slightly better than direct finetuning b/c it's incorporating the distribution from the much larger model.

I will try

IIUC correctly, your model performed better after distillation on your benchmarking than before? In that case, it seems that distillation worked?
To make sure though that this is working properly, can you try directly finetuning your small 1B model and comparing it to the distilled model? The distilled model should perform slightly better than direct finetuning b/c it's incorporating the distribution from the much larger model.

How can I distill all modules during the distillation process? The following command results in an error.
model.lora_attn_modules=['q_proj', 'v_proj', 'output_proj', 'k_proj', 'gate_proj', 'up_proj', 'down_proj'];

error:
rank0: ] = convert_weights.tune_to_peft_adapter_config(
[rank0]: File "/usr/local/src/torchtune/torchtune/models/convert_weights.py", line 242, in tune_to_peft_adapter_config
raise ValueError(f"Unknown target module {k}")

Our LoRA recipe does not allow you to "LoRA-fy" the gate_proj, up_proj, or down_proj through the self attention modules b/c they are actually part of the MLP layer! You can read more about it in our LoRA tutorial. Acceptable options are 'q_proj', 'v_proj', 'output_proj', and 'k_proj'.
Then, if you want to "LoRA-fy" the gate, up, and down projections, you can just use apply_lora_to_mlp=True.

Thank you for your patient response. I tried modifying the configuration again. This time it ran and inferred successfully. However, the result is not as good as when I previously fine-tuned the 1B model with Llamafactory. I observed from the logs that the loss during distillation is quite high, while the loss was at a lower threshold when fine-tuning with Llamafactory. Here is my configuration. Is there any good way to optimize my loss?
tune run --nnodes 1 --nproc_per_node 2 knowledge_distillation_distributed --config llama3_2/8B_to_1B_KD_lora_distributed \
teacher_checkpointer.checkpoint_files='[
    "model-00001-of-00009.safetensors",
    "model-00002-of-00009.safetensors",
    "model-00003-of-00009.safetensors",
    "model-00004-of-00009.safetensors",
    "model-00005-of-00009.safetensors",
    "model-00006-of-00009.safetensors",
    "model-00007-of-00009.safetensors",
    "model-00008-of-00009.safetensors",
    "model-00009-of-00009.safetensors"
]' \
optimizer.lr=1e-5 \
kd_ratio=1.0 \
dataset=torchtune.datasets.alpaca_dataset \
dataset.source=json \
dataset.data_files=/usr/local/alpaca_zh_demo.json \
batch_size=2 \
output_dir=/usr/local/torchtune/llama3_2_8B_to_1B/KD_lora_distributed \
tokenizer.path=/usr/local/Llama-3.2-1B-Instruct/Llama-3.2-1B-Instruct/original/tokenizer.model \
checkpointer.checkpoint_dir=/usr/local/Llama-3.2-1B-Instruct/Llama-3.2-1B-Instruct/ \
teacher_checkpointer.checkpoint_dir=/usr/local/Meta-Llama-3.1-8B-Instruct/ \
teacher_checkpointer.output_dir=/usr/local/Meta-Llama-3.1-8B-Instruct \
model.lora_rank=8 \
model.lora_alpha=16 \
model.lora_attn_modules="['q_proj', 'v_proj', 'output_proj', 'k_proj']"  \
epochs=3 \
warmup_steps=0

3|141|Loss: 1.7566685676574707:   7%|▋         | 5/68 [03:32<46:14, 44.04s/it]
3|141|Loss: 1.7566685676574707:   9%|▉         | 6/68 [04:07<42:18, 40.95s/it]
3|142|Loss: 2.570791006088257:   9%|▉         | 6/68 [04:07<42:18, 40.95s/it]
3|142|Loss: 2.570791006088257:  10%|█         | 7/68 [04:51<42:39, 41.95s/it]
3|143|Loss: 1.8999344110488892:  10%|█         | 7/68 [04:51<42:39, 41.95s/it]
3|143|Loss: 1.8999344110488892:  12%|█▏        | 8/68 [05:48<46:51, 46.86s/it]
3|144|Loss: 1.9488004446029663:  12%|█▏        | 8/68 [05:48<46:51, 46.86s/it]
3|144|Loss: 1.9488004446029663:  13%|█▎        | 9/68 [06:31<44:58, 45.73s/it]
3|145|Loss: 1.926500380039215:  13%|█▎        | 9/68 [06:31<44:58, 45.73s/it]
3|145|Loss: 1.926500380039215:  15%|█▍        | 10/68 [07:02<39:39, 41.03s/it]
3|146|Loss: 1.98761785030365:  15%|█▍        | 10/68 [07:02<39:39, 41.03s/it]
3|146|Loss: 1.98761785030365:  16%|█▌        | 11/68 [07:41<38:32, 40.56s/it]
3|147|Loss: 1.945314347743988:  16%|█▌        | 11/68 [07:41<38:32, 40.56s/it]
3|147|Loss: 1.945314347743988:  18%|█▊        | 12/68 [08:38<42:29, 45.53s/it]
3|148|Loss: 1.8299177289009094:  18%|█▊        | 12/68 [08:38<42:29, 45.53s/it]
3|148|Loss: 1.8299177289009094:  19%|█▉        | 13/68 [09:12<38:27, 41.96s/it]
3|149|Loss: 1.9277714490890503:  19%|█▉        | 13/68 [09:12<38:27, 41.96s/it]
......
3|200|Loss: 1.7644927501678467:  96%|█████████▌| 65/68 [59:47<02:42, 54.13s/it]
3|201|Loss: 1.7249903678894043:  96%|█████████▌| 65/68 [59:47<02:42, 54.13s/it]
3|201|Loss: 1.7249903678894043:  97%|█████████▋| 66/68 [1:00:34<01:43, 51.96s/it]
3|202|Loss: 1.9537839889526367:  97%|█████████▋| 66/68 [1:00:34<01:43, 51.96s/it]
3|202|Loss: 1.9537839889526367:  99%|█████████▊| 67/68 [1:01:34<00:54, 54.40s/it]
3|203|Loss: 1.8339385390281677:  99%|█████████▊| 67/68 [1:01:34<00:54, 54.40s/it]
3|203|Loss: 1.8339385390281677: 100%|██████████| 68/68 [1:02:21<00:00, 52.28s/it]
3|204|Loss: 2.169794023036957: 100%|██████████| 68/68 [1:02:21<00:00, 52.28s/

Interesting - that loss is definitely a little high. At a glance, I'd recommend trying out the following things:

Reducing the kd_ratio like the advice here.
Bumping up the batch_size or using gradient accumulation if your memory doesn't allow directly increasing the batch_size
Using a larger LoRA rank and alpha. Read more about that here

cc @lindawangg to see if she has any suggestions as well
Could you also share your setup for when you ran with Llama-Factory?

Your lr is also very small. Try 10x it to 1e-4

Interesting - that loss is definitely a little high. At a glance, I'd recommend trying out the following things:

Reducing the kd_ratio like the advice here.
Bumping up the batch_size or using gradient accumulation if your memory doesn't allow directly increasing the batch_size
Using a larger LoRA rank and alpha. Read more about that here

cc @lindawangg to see if she has any suggestions as well
Could you also share your setup for when you ran with Llama-Factory?
 Try 10x it to 1e-4

I'll try

Interesting - that loss is definitely a little high. At a glance, I'd recommend trying out the following things:

Reducing the kd_ratio like the advice here.
Bumping up the batch_size or using gradient accumulation if your memory doesn't allow directly increasing the batch_size
Using a larger LoRA rank and alpha. Read more about that here

cc @lindawangg to see if she has any suggestions as well
Could you also share your setup for when you ran with Llama-Factory?

@joecummings After optimizing the configuration, the loss dropped to 1.3. However, there is still a significant gap compared to LlamaFactory's loss of 0.0001. Upon reviewing LlamaFactory's logs, it seems that LlamaFactory might be vectorizing the input data. Torchtune, on the other hand, might not be processing the data in the same way ? I guess it could be why the loss remains relatively high in my scenario ?


Add a CI step to ensure 100% doc coverage

While generating docs for the v5.2, I noticed our doc coverage dropped to 99% due to a forgotten doc here. and was wondering if it is a good idea to add a CI step to make sure any newly introduced code is properly documented

Hello


fix(venues-proxy): venuesByIds should not return empty venues

LIIKUNTA-551
The venue resolver can return an "empty venue"
in some cases when the datasource has not listed
the requested venue or it is not with the same id
as it is in another source. In those cases, also
the venuesByIds query gets empty venues in the
list that it returns, but no client should never ever
have any need for the empty venue details, so it
can be removed.

To set a local venue proxy and a local federation router, start the venue-proxy locally and the router with "docker:graphql-router:sports:serve": "cross-env FEDERATION_CMS_ROUTING_URL=https://liikunta.hkih.stage.geniem.io/graphql FEDERATION_EVENTS_ROUTING_URL=https://events-graphql-proxy.test.hel.ninja/proxy/graphql FEDERATION_UNIFIED_SEARCH_ROUTING_URL=https://kuva-unified-search.api.test.hel.ninja/search FEDERATION_VENUES_ROUTING_URL=http://docker.for.mac.localhost:4200/proxy/graphql docker-compose -f docker-compose.router.yml up",

Codecov Report

Merging #432 (cc5f7b7) into main (b0dba57) will increase coverage by 0.93%.
Report is 7 commits behind head on main.
The diff coverage is 11.36%.

@@            Coverage Diff            @@
##            main     #432      +/-   ##
=========================================
+ Coverage   9.09%   10.02%   +0.93%
=========================================
  Files         25       25
  Lines        396      399       +3
  Branches     113      128      +15
=========================================
+ Hits          36       40       +4
+ Misses       355      351       -4
- Partials       5        8       +3

Files Changed
Coverage Δ

...e-graphql-proxy/src/datasources/HaukiDataSource.ts
0.00% <ø> (ø)

...phql-proxy/src/datasources/ServiceMapDataSource.ts
0.00% <0.00%> (ø)

proxies/venue-graphql-proxy/src/resolvers/Venue.ts
0.00% <0.00%> (ø)

...venue-graphql-proxy/src/resolvers/VenueResolver.ts
0.00% <0.00%> (ø)

...y/src/resolvers/enrichers/VenueOntologyEnricher.ts
0.00% <0.00%> (ø)

...rc/resolvers/integrations/VenueHaukiIntegration.ts
0.00% <0.00%> (ø)

...resolvers/integrations/VenueResolverIntegration.ts
0.00% <ø> (ø)

...solvers/integrations/VenueServiceMapIntegration.ts
0.00% <0.00%> (ø)

...-graphql-proxy/src/resolvers/venueQueryResolver.ts
0.00% <0.00%> (ø)

...graphql-proxy/src/resolvers/venuesByIdsResolver.ts
0.00% <0.00%> (ø)

... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


guest-rust: UB in cabi_realloc

In cabi_realloc:
https://github.com/bytecodealliance/wit-bindgen/blob/98c2b1e4cb10d3757114b7524d112511a4c7459e/crates/guest-rust/src/lib.rs#L28-L37
If old_len > 0 and new_len == 0, you'll end up calling alloc::realloc(..., 0).

https://doc.rust-lang.org/std/alloc/trait.GlobalAlloc.html#method.realloc
... undefined behavior can result if the caller does not ensure all of the following:
...

new_size must be greater than zero.

I imagine this isn't really UB since we know the underlying realloc contract.

Actually, it isn't clear to me what cabi_realloc should do if old_len > 0 && new_len == 0. Some allocators treat it as a free.

I think we can statically say that won't happen in the component model, but it would nonetheless be good to have an assertion just in case perhaps?


activerecord: Add AR::Relation#sanitize_sql_like

The ActiveRecord::Relation provides methods defined at AR::Base via delegation (see ActiveRecord::Delegation).
This allows to use sanitize_sql_like and its family via AR::Relation. It is often used in the scope definition.

/merge


fix: progress bar image name flashes on push

Description
This PR fixes the CLI flashing when pushing images. This can be seen in the linked gif in the issue #2651
Related Issue
Fixes #2651
Checklist before merging

[ ] Test, docs, adr added or updated as needed
[ ] Contributor Guide Steps followed

Does the total progress even matter? We set it when we define the progress bar but we never update it as far as I can see?  I want to make sure that reusing the progress bar wont result in starting at the progress state where we ended.

Great question @phillebaba. The total progress does matter. We send crane a custom implementation of the http.RoundTripper. This can be found in the helpers pkg package. This implementation updates the progress bar based on the amount of bytes received from the request.
The current code creates a new progress bar before the program starts and on each retry without closing the old one. This always results in at least two progress bars active at the same time which causes the flashing.

Are you sure the issue is not that we are not deffering stopping the progress bar before a retry is run? Looking at the current code if the retry is run the old progress bar is never stopped.

Not stopping the progress bar is part of the issue with the current code, but either way the flashing will happen because we have two progress bars going at the same time. IMO we should just have one progress bar at top level. If there is an error in the request the progress bar won't get updated on that attempt, but will get updated on subsequent attempts.
Here is a video from the current state of this branch where I artificially make an error happen. When an error happens the progress bar still completes. It leaves behind a progress bar on error but that happens no matter what.
Screencast from 09-05-2024 09:10:29 AM.webm
Here is a video from the latest release where I artificially make an error happen. Yes it leaves behind progress bars, but it's also flashing from the start.
Screencast from 09-05-2024 09:06:00 AM.webm


Fix calling convention for set_resp_cookie/3

If not providing optional values, they are set to #{} and are the last parameter according to the source code. Reflect this in the documentation.

Merged locally, thanks!


SSG include/exclude pages

Is your feature request related to a problem?
I'm building a blog with a search page to find a post. When I change searchParams in the search page the results are the same if I use an anchor (not a Link). I think this is because SSG doesn't takes into account searchParams.
Describe the solution you'd like

Support searchParams for prerendering (Incase there is a limited amount of options).
Being able to exclude pages from SSG to use SSR instead.

Both could be done in the onStaticGenerate return function.
Describe alternatives you've considered
I used SPA navigation to the search page.
Another solution is to use useVisibleTask to perform the query.
But both solutions are client side, so we cannot cache the result of the query on the server.
Additional context
No response

You can configure this behaviour with include and exclude props in your Qwik SSG adapter.
So I'm closing this issue for now, feel free to re-open it if it's still an issue for you.


feat/action-accept-both-formdata-and-objects

A week or two ago we were discussing on how to make sevrer actions accept both formdata and typed variables. I found a neat npm package called zod-form-data which i think is the perfect solution for our problem. It first of all makes it much cleaner to parse form data to an object. Here's an exmaple from the create user action:
const schema = z.object({
    username: z.string().max(50).min(2),
    password: z.string().max(50).min(2),
    email: z.string().max(200).min(2).email(),
    firstname: z.string().max(50).min(2),
    lastname: z.string().max(50).min(2),
    confirmPassword: z.string().max(50).min(2),
}).refine((data) => data.password === data.confirmPassword, 'Password must match confirm password')

const parse = schema.safeParse({
    username: rawdata.get('username'),
    password: rawdata.get('password'),
    email: rawdata.get('email'),
    firstname: rawdata.get('firstname'),
    lastname: rawdata.get('lastname'),
    confirmPassword: rawdata.get('confirmPassword'),
})

versus
const userSchema = zfd.formData({
    username: z.string().max(50).min(2),
    password: z.string().max(50).min(2),
    email: z.string().max(200).min(2).email(),
    firstname: z.string().max(50).min(2),
    lastname: z.string().max(50).min(2),
    confirmPassword: z.string().max(50).min(2),
}).refine((data) => data.password === data.confirmPassword, 'Password must match confirm password')

const parse = userSchema.safeParse(rawdata)

Second of all the zfd.formData schema accepts both formData and objects! Using z.infer to infer the type from our defined schema we can then type actions so that they accept both formData and objects with proper typehinting. Again an example for createUser:
const userSchema = zfd.formData({
    username: z.string().max(50).min(2),
    password: z.string().max(50).min(2),
    email: z.string().max(200).min(2).email(),
    firstname: z.string().max(50).min(2),
    lastname: z.string().max(50).min(2),
    confirmPassword: z.string().max(50).min(2),
}).refine((data) => data.password === data.confirmPassword, 'Password must match confirm password')

type createUserArgs = z.infer<typeof userSchema>

export async function createUser(rawdata: FormData | createUserArgs): Promise<ActionReturn<User>> {
    const parse = userSchema.safeParse(rawdata)

    if (!parse.success) {
        return { success: false, error: parse.error.issues }
    }

    ...

Can i get your input on this @JohanHjelsethStorstad and @theodorklauritzen ? I have created the branch feat/actions-accept-both-formdata-and-objects where i have implemented this for createUser so that you can view it for yourselves.

This looks very nice I think. We had a solution for the verbose code for parsing with schema.safePare(Object.from(raw data.entries())). But this is still better.

Great! I can go over all the actions and implement this before the meeting tomorow.


[Help Wanted] Update documentation guidelines

Our existing guidelines are a bit out of date, would appreciate a PR to replace them. We can use the PR to discuss

See PR #642

Closed via #642, thanks @JeffSchering!


Issue: traceable decorator errors crash application code

Issue you'd like to raise.
During the recent outage, we have noticed a rather weird behaviour:
we are using traceable decorator in our Python code, like so:
  @traceable(project_name=LANGSMITH_PROJECT_NAME, tags=[ENVIRONMENT_NAME])
  def search(
        self,
        query: str,
        user_id: str,
        community_id: str,
        company_id: str,
        start_date: str,
        end_date: str,
        available_communities: List[str],
    ) -> dict:

and during recent outage we have noticed, that error raised in the decorator, crashes the application code. I believe this should not be the case, as tracing should not impact availability of our services.
In our case error raised was 403 Forbidden returned by LangSmith API.
Thank you
Suggestion:
I think although important tracing is not imperative to the functionality of the application and error raised in tracing decorator should not take out the entire/service/endpoint/feature. Maybe a warning log, or a notification through email/langsmith UI would be a better option than crashing?

@nikkogg thanks for raising! 100% agree. Could you confirm a few things with me?

What version of langsmith SDK you are using?
do you have any more details on how you're using langsmith in your application?
Are you making any calls directly with the Langsmith client? (like client.create_run or client.create_feedback, etc)

All the API calls in @traceable are done within a try/catch blog and in a background thread, which would still emit warning logs but not crash the main thread.
When I run any app I can create with no internet or with incorrect credentials and get a 403, the app runs as expected but warning logs are emitted, as expected.

@hinthornw  Thank you for your quick response. Let me provide details about our setup and solution:
Current Setup

LangSmith SDK Version: langsmith==0.1.140 (maintained for LangChain compatibility)
We use LangSmith SDK to track LangChain agent calls (handling multiple tools)

Initial Implementation
from langsmith import traceable

@traceable(
    project_name=LANGSMITH_PROJECT_NAME,
    tags=[ENVIRONMENT_NAME]
)
def search(self, query: str) -> dict:

Issue Identified
During local debugging, we discovered that when the LangSmith API URL is unreachable:
The connection attempts continue many times, causing service timeouts
Solution Implementation
We created a safer version of the traceable decorator that:

Prevents service blocking
Handles connection errors gracefully
Tests connectivity before tracing

from langsmith import Client, traceable
from langsmith.utils import Retry
from functools import wraps

SEARCH_LANGSMITH_CLIENT = Client(
    retry_config=Retry(total=1),
)

def safe_traceable(project_name, tags, client):
    def decorator(func):
        @wraps(func)
        def wrapper(*args, **kwargs):
            try:
                # Test LangSmith connectivity
                info = client.request_with_retries("GET", "/info", stop_after_attempt=1)
                logger.info(f"[SearchAgentInvoker] Langsmith info: {info}")

                return traceable(project_name=project_name, tags=tags, client=client)(func)(
                    *args, **kwargs
                )
            except Exception as e:
                logger.warning(
                    f"Langsmith tracing failed, continuing without tracing. Error: {str(e)}",
                    exc_info=True,
                )
                # Fallback to original function
                return func(*args, **kwargs)
        return wrapper
    return decorator

@safe_traceable(
    project_name=LANGSMITH_PROJECT_NAME,
    tags=[ENVIRONMENT_NAME],
    client=SEARCH_LANGSMITH_CLIENT
)
def search(self, query: str) -> dict:

Feel free to share any suggestions to help us ensure our LangSmith logging implementation is robust and efficient, with minimal impact on service performance and latency, thanks

@billpku what service is timing out in your case?
I wouldn't recommend the proposed wrapper, since that adds an unchached, blocking IO request in the main thread.
Tracing already occurs in a background thread, meaning that while it will finish up ingestion before the program exits, it shouldn't be adding noticeable latency or errors to your program's execution.
I'd also recommend updating your langsmith SDK version since we've made a number of serialization and speed improvements in the intermediating releases.

@hinthornw  Thank you for your feedback. Let me clarify our specific issue:
Connection Timeout Issue
We encountered blocking behavior when the LangSmith API URL is unreachable. Here's how we reproduced the issue using a mock API URL:
"level":"WARNING","location":"_post_batch_ingest_runs:1440","message":"Failed to batch ingest runs: langsmith.utils.LangSmithConnectionError: Connection error caused failure to POST https://api.smith.langchain1.com/runs/batch in LangSmith API. Please confirm your LANGCHAIN_ENDPOINT. ConnectionError(MaxRetryError('HTTPSConnectionPool(host=\'api.smith.langchain1.com\', port=443): Max retries exceeded with url: /runs/batch (Caused by NameResolutionError(\"<urllib3.connection.HTTPSConnection object at 0x15e247650>: Failed to resolve \'api.smith.langchain1.com\' ([Errno 8] nodename nor servname provided, or not known)\"))'))\nContent-Length: 1118\nAPI Key: lsv2_********************************************c5\npatch: trace=a4b7407d-c1a0-43a2-a952-xxxxx,id=a4b7407d-c1a0-43a2-a952-b9d47xxxx","timestamp":"2024-12-10 11:44:40,077+0000","service":"service_undefined","name":"langsmith.client"}

Our Findings

This behavior occurs in both langsmith==0.1.140 and langsmith==0.2.1
Interestingly, when testing with an incorrect LANGCHAIN_API_KEY, the trace doesn't block the function

We plan to upgrade to langsmith==0.2.1, but feel we still need to implement API connectivity checks before enabling tracing. Would you have any suggestions for handling this scenario?

@hinthornw
We've made progress after updating our dependencies:

Updated langchain-core to version 0.3.24 (adds compatibility with latest LangSmith, detail)
Updated langsmith to version 0.2.1

After testing two scenarios:

Unreachable API URL
Invalid API key

Results: The traceable decorator no longer blocks function execution in either case.
Highly recommend upgrading to langsmith==0.2.1.
Thank you for your guidance!

Thank you for your patience!


How can i connect app in multiple pc in network with one pc having database?

Am trying to connect multiple computers in network to one  mysql server.
I want the windows applications which uses this package to access single server through local network.
i tried using ip address instead of local host in host property,
but network computers couldn't access data.
Is there any way i could make it work..?
Thanks in advance.

Mysql opens port 3306 for remote access

Mysql opens port 3306 for remote access.

I had to make some configurations in mysql workbench.. now its working fine, thank you!


Upgrade to pac4j v1.9

PR: https://github.com/pac4j/play-pac4j/pull/107 & https://github.com/pac4j/play-pac4j-java-demo/pull/30 + https://github.com/pac4j/play-pac4j-scala-demo/pull/29


fixed mtsj bootified error

Fixed issue https://github.com/devonfw/my-thai-star/issues/303

@dario-rodriguez  thanks for testing in docker, hence merging the PR


Adds a few more customizable components to the builder. Exposes more …

…methods to subclasses.

Great, thanks!


webview_flutter  Image Sticking

When using flutter 3.0, WebView encounters residual image problems. Flutter 2.10.3 is good。
This is an example of loading a 3D file using WebView modelviewer，This is using the modelviewer address ：https://modelviewer.dev/
1 , Using WebView_ Flutte any version
2,html :

                  <model-viewer id='dimension-demo'
                                src="http://51xingkong.oss-cn-qingdao.aliyuncs.com/6904a922e6b60ab8ee20a14e9ff97c80%20_1_.gltf"
                                shadow-intensity="1" camera-controls auto-rotate interaction-prompt="none"
                                camera-orbit="0deg 90deg 105%"
                                scale="1.2 1.2 1.2"
                                exposure="1.0"
                                rotation-per-second="20deg" auto-rotate-delay=1000
                                style="background-color: transparent;">

                  </model-viewer>

3,
     WebView(
         javascriptChannels: <JavascriptChannel>[
           JavascriptChannel(
               name: 'progress',
               onMessageReceived: (JavascriptMessage message) async {

               }),
         ].toSet(),
         backgroundColor: Colors.transparent,
         initialUrl: Uri.dataFromString(html,
             mimeType: 'text/html',
             encoding: Encoding.getByName('utf-8'))
             .toString(),
         javascriptMode: JavascriptMode.unrestricted,
       )

4，
This is fluent 3.0：

This is fluent 2.0：

Hi @lisen87
Please provide a completed and minimal reproducible code sample so that we may verify this. In this case, please push the sample code to a Github repository and make it public. Also, please provide the output of flutter doctor -v as well.
Thank you!

@huycozy
Thank you for your answer！
flutter doctor -v
Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!
[√] Flutter (Channel stable, 3.0.5, on Microsoft Windows [版本 10.0.18363.1556], locale zh-CN)
• Flutter version 3.0.5 at F:\flutter\flutter_windows_3.0.5-stable\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision f1875d570e (8 weeks ago), 2022-07-13 11:24:16 -0700
• Engine revision e85ea0e79c
• Dart version 2.17.6
• DevTools version 2.12.2
• Pub download mirror https://pub.flutter-io.cn
• Flutter download mirror https://storage.flutter-io.cn
[!] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
• Android SDK at C:\Users\lisen\AppData\Local\Android\sdk
X cmdline-tools component is missing
Run path/to/sdkmanager --install "cmdline-tools;latest"
See https://developer.android.com/studio/command-line for more details.
X Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.
[X] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe)
! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[X] Visual Studio - develop for Windows
X Visual Studio not installed; this is necessary for Windows development.
Download at https://visualstudio.microsoft.com/downloads/.
Please install the "Desktop development with C++" workload, including all of its default components
[√] Android Studio (version 2020.3)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
[√] Connected device (3 available)
• Redmi 8A (mobile) • af8330ef0306 • android-arm    • Android 9 (API 28)
• Windows (desktop) • windows      • windows-x64    • Microsoft Windows [版本 10.0.18363.1556]
• Edge (web)        • edge         • web-javascript • Microsoft Edge 105.0.1343.27
[√] HTTP Host Availability
• All required HTTP hosts are available

我已将示例代码提交到github，这是 项目地址  https://github.com/lisen87/image_sticking

I have submitted the sample code to GitHub. This is the project address
https://github.com/lisen87/image_sticking

@lisen87 Thanks for the sample code but the web is not displayed when I ran it.

Demo

It could be related to the network. Please make sure the asset is public so that we may verify this.

@huycozy
Yes, I have revised the network download problem again. The sample code has been updated to GitHub: https://github.com/lisen87/image_sticking , please try again it.
In addition, The following is the mobile phone information with problems

Hi @lisen87, thanks for updating sample code.
But I can not reproduce the issue on the latest stable and master channels.

Demo

iOS
Android (Galaxy Tab A7)
Android (Realme 6)

flutter doctor -v
[✓] Flutter (Channel stable, 3.3.1, on macOS 12.5.1 21G83 darwin-x64, locale en-VN)
    • Flutter version 3.3.1 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4f9d92fbbd (31 hours ago), 2022-09-06 17:54:53 -0700
    • Engine revision 3efdf03e73
    • Dart version 2.18.0
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13E113
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.5.1 21G83 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 105.0.5195.102

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.4.0-19.0.pre.153, on macOS 12.5.1 21G83 darwin-x64, locale en-VN)
    • Flutter version 3.4.0-19.0.pre.153 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d2434a2b60 (4 hours ago), 2022-09-08 15:39:07 -0700
    • Engine revision 4096e133ef
    • Dart version 2.19.0 (build 2.19.0-177.0.dev)
    • DevTools version 2.17.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13E113
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.5.1 21G83 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 105.0.5195.102

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

As far as I can see, you are using the old Flutter version 3.0.5, the latest Flutter stable is 3.3.1 and the master is 3.4.0. Please try upgrading them and retry to see if this issue still reproduces.

I just used the latest SDK to test, and there is no problem. thank you


Supervisor API docs no longer contain info about update locking

http://docs.resin.io/runtime/supervisor-api/#update-locking is missing - and there's a broken link from http://docs.resin.io/management/devices/#update-locking pointing to it

Looks like it got removed in 5a802d8ec63e098909561b37adc805309b955b72#diff-5408e175931cda52d29182c8c5b2028a by @craig-mulligan, related to #168 . Looks like maybe a side-effect? Will investigate and put it back (somewhere, with fixed reference)

cc @pcarranzav

connects to #280


Add BirdSite

The implementation looks really tidy, thanks for the contribution!

Yes, it's very well made. I use it every day!


Search feature not working

Describe the bug
Search feature on the home page is not working
To Reproduce
Steps to reproduce the behavior:

Search a random string

Note:

If you want to work on an issue, you should check if it has already been assigned to anyone. If the issue is free you can comment /assign to get the issue assigned to you.
If you are raising a new issue and want to work on it then also you should comment /assign under the issue to get it auto assigned.
Please refrain from adding labels to your issue/pull-request on your own. It is the job of the Project Admin and the Mentors to review your issue/pull-request and add labels accordingly.

Can I work on it.
/assign

Adding an If condition to check for the internet

Please assign me this issue under LGMSOC'21

I couldn't get the code on which I need to work.
guide me the html file in which the error is to be fixed.

The frontend for search is here- views/navitems/home.ejs
I checked the routes for the backend and I can't seem to find it either. I think some commit must removed it by mistake. You can add it again under this issue. Take reference from #31

Hey, any updates on this??
If not i want to work under lgm soc21

@akshikamudgal are you still working on this?

@akshikamudgal are you still working on this?

No

/assign

I would like to work on this issue if no one is working on this.


Ignore Qt project files.

Qt's project files (generated with qmake) shouldn't be included.

Now also discussed in #2186


[BEAM-59] DataflowRunner: Sink is always a FileBasedSink now

Coverage increased (+0.02%) to 69.82% when pulling 84713fd62ef9935fa4cf882da0f0302f387b39b2 on dhalperi:dataflow-runner-minor into 3d47b335cbe22f92fc83e2ba2a7c35847bcadca3 on apache:master.

Unrelated KafkaIO test flaked, but the build ran to completion and passed, so I won't rerun.

R: @vikkyrk

retest this please

Coverage increased (+0.01%) to 69.815% when pulling 84713fd62ef9935fa4cf882da0f0302f387b39b2 on dhalperi:dataflow-runner-minor into 3d47b335cbe22f92fc83e2ba2a7c35847bcadca3 on apache:master.

LGTM


[sql lab] data results view truncates integers at 16 digits

Integers greater than 16 digits get replaced with 0s

[x] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
Expected results
Actual results
Steps to reproduce

You really have to fill the missing information to help people helping you.

@mistercrunch can we close?


Can't update workitems even relevant spaces are already removed

From @danieloh30 on June 13, 2017 5:7
Can't update workitems[1] even relevant spaces are already removed[2] at user profile menu.
However it looks all fine once the page is reloaded and I think the workitem - select box - should be refreshed automatically when the relevant spaces are removed.
[1]

[2]

Copied from original issue: openshiftio/openshift.io#223

Fixed in #1559. Closing.


fix env variables for JSONCS3 public driver configuration

Description
We've fixed the environment variable config options of the jsoncs3 driver that previously
used the same environment variables as the cs3 driver.
Now the jsoncs3 driver has it's own configuration environment variables.
If you used the jsoncs3 sharing driver and explicitly set SHARING_PUBLIC_CS3_SYSTEM_USER_ID,
this PR is a breaking change for your deployment. To workaround you may set the value you had
configured in SHARING_PUBLIC_CS3_SYSTEM_USER_ID to both SHARING_PUBLIC_JSONCS3_SYSTEM_USER_ID
and SHARING_PUBLIC_JSONCS3_SYSTEM_USER_IDP.
Related Issue

Fixes jsoncs3 config options

Motivation and Context

How Has This Been Tested?

test environment:
test case 1:
test case 2:
...

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[x] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

:boom: Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@wkloucek the storage syetem idp is still necessary. we may want to revisit the userid & useridp after ga, though. IMO we should exchange whatever credentials are used for an internal uuid in the proxy.


Search - Pay button appears for report that will be auto-paid and it reappears after clicked

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:
Precondition:

Admin and employee are in the same workspace.
Workspace has bank account.
Employee has personal bank account.
Add approvals feature is enabled and admin is the approver.

Go to staging.new.expensify.com
[Employee] Go to workspace chat and submit an expense more than $100.
[Admin] Go to Search.
[Admin] Click Approve next to the expense, than click Pay.
[Admin] Click Pay with Expensify on the expense report RHP.
[Employee] Go to workspace chat and submit an expense less than $100 (so that it auto pays later).
[Admin] Go to Search.
[Admin] Click Approve next to the expense.
[Admin] Click Pay.

Expected Result:
Pay button should not appear for report that will be auto paid (if less than $100).
Actual Result:
Pay button appears for report that will be auto paid (if less than $100). The button reappears after clicking Pay.
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/1e4c2a7f-50de-44ac-bf88-434b356bf7de

View all open jobs on GitHub

I'm not sure if this is an issue. I think admins should have the ability to pay reports even if they have auto pay enabled.

Ah I see that the video shows a different things than what the OP described. In that case the expense has already been paid, so we shouldn't show the button again. I'll investigate

This is done


py12306助手运行测试提示错误

验证码验证成功 开始登录...

第 6 次查询 北京 -> 深圳 2020-08-28 09:24:35
乘车日期错误，比当前时间还早！！
Traceback (most recent call last):
File "main.py", line 64, in
main()
File "main.py", line 26, in main
Query.run()
File "/py12306/py12306/query/query.py", line 54, in run
self.start()
File "/py12306/py12306/query/query.py", line 78, in start
jobs_do(self.jobs, 'run')
File "/py12306/py12306/helpers/func.py", line 146, in jobs_do
getattr(job, do)()
File "/py12306/py12306/query/job.py", line 112, in run
self.start()
File "/py12306/py12306/query/job.py", line 128, in start
response = self.query_by_date(date)
File "/py12306/py12306/query/job.py", line 164, in query_by_date
self.judge_date_legal(date)
File "/py12306/py12306/query/job.py", line 151, in judge_date_legal
raise RuntimeError(msg)
RuntimeError: 乘车日期错误，比当前时间还早！！

注销掉配置文件env.py 120-160行的配置就行


Fixes for StatefulSet deployment. Add questions.yml and app-readme.md for rancher chart

@amvin87 first pass for rancher chart

i would also add the possibility to have extra volumes and extravolumemounts to allow the SA_PASSWORD to be injected as a secret pulled from a vault
to values.yaml add
extraVolumes: []

extraVolumeMounts: []

to deployment.yaml add:
          volumeMounts:
           - name: mssql
             mountPath: "/var/opt/mssql"
           - name: mssql-config-volume
             mountPath: /var/opt/config
           {{- if .Values.extraVolumeMounts }}
           {{- toYaml .Values.extraVolumeMounts | nindent 11 }}
           {{- end }}
      volumes:
      - name: mssql-config-volume
        configMap:
         name: mssql
      {{- if .Values.extraVolumes }}
      {{- toYaml .Values.extraVolumes | nindent 6 }}
      {{- end }}

i would also add the possibility to have extra volumes and extravolumemounts to allow the SA_PASSWORD to be injected as a secret pulled from a vault
to values.yaml add
extraVolumes: []

extraVolumeMounts: []

to deployment.yaml add:
          volumeMounts:
           - name: mssql
             mountPath: "/var/opt/mssql"
           - name: mssql-config-volume
             mountPath: /var/opt/config
           {{- if .Values.extraVolumeMounts }}
           {{- toYaml .Values.extraVolumeMounts | nindent 11 }}
           {{- end }}
      volumes:
      - name: mssql-config-volume
        configMap:
         name: mssql
      {{- if .Values.extraVolumes }}
      {{- toYaml .Values.extraVolumes | nindent 6 }}
      {{- end }}

maybe in the next pr. is this w/ hashicorp vault?

extraVoumes/Mounts can be used for many things, but in the usecase i was thinking about it's related to Azure Keyvault
the setup would look like this.
values.yml
extraVolumes:
  - name: secrets-store-inline
    csi:
      driver: secrets-store.csi.k8s.io
      readOnly: true
      volumeAttributes:
        secretProviderClass: "azure-vault"

extraVolumeMounts:
  - name: secrets-store-inline
    mountPath: "/mnt/secrets-store"
    readOnly: true

vault-providerclass.yml (obviously i removed sensitive information from below)
piVersion: secrets-store.csi.x-k8s.io/v1
kind: SecretProviderClass
metadata:
  name: azure-vault
spec:
  provider: azure
  secretObjects:
  - secretName: mssql
    type: Opaque
    data:
      - key: SA_PASSWORD
        objectName: mssql-password
  parameters:
    usePodIdentity: "false"
    useVMManagedIdentity: "true"
    userAssignedIdentityID: "IDENTITY_ID"
    keyvaultName: DevKbnVault
    objects: |
      array:
        - |
          objectName: mssql-password
          objectType: secret
    tenantId: TENANT_ID


Enables custom readers and writers through CLI

Revamps CLI parameters
Enables Type Resolution
Enables configuration of CSharpWriter
Isolates and tests various responsibilities of the CLI [metadata getting, file
writing, type resolution]

I'll update this PR and reopen


Enable diagonal movement with just arrow keys, via a modifier

< sm> oh, and I guess you could put in a diagonal movement kludge for folks who love arrow keys: SOMEMODIFIER-UP LEFT could be equivalent to UP-LEFT20:02
[...]
< sm> re arrow keys, no by that I mean the main cursor up/down/left/right keys. Those were the first keys I used, and I naturally tried to press two at once to move diagonally. (I think that can work in some games with some  external keyboards, I could be wrong)
Some people also use S-arrows for diagonal movement, but that might collide with S-keypad for running, at least in frontends (e.g., terminal) that can't distinguish arrows and keypad.

Then, of course, mention "arrow keys" as a viable movement scheme in various help blurbs.

This is not priority any more, because movement via acwdqezc is coming soon.

Actually, now there's movement through mouse, keypad, vi keys, axwdqezc, all enabled by defaults. I'm closing this issue, though if anybody would benefit from it, please feel free to implement.


fastddsspy with idl type

IDL include a structure HelloWorld, HelloWorld includes a struct point, point includes a struct timestamp(such as HelloWorld.idl),in this way, fastddsspy will come to  Segmentation fault. However, if IDL include a structure HelloWorld, HelloWorld includes a struct point, point don't include  any struc (like HelloWorld_OK.idl), fastddsspy will run ok.
HelloWorld_OK.idl
struct point{
short x;};
struct HelloWorld{
point  pos;
unsigned long index;};
HelloWorld.idl
struct timestamp{
short h;};
struct point{
timestamp ts;
short x;};
struct HelloWorld{
point  pos;
unsigned long index;};
step1:
fastddsgen -typeobjcet HelloWorld.idl
step2:
DomainParticipantQos pqos;
pqos.wire_protocol().builtin.typelookup_config.use_server = true;
eprosima::fastdds::dds::DomainParticipant* participant_;
participant_ = DomainParticipantFactory::get_instance()->create_participant(0, pqos);
eprosima::fastdds::dds::TypeSupport type_;
type_(new HelloWorldPubSubType())
type_.register_type(participant_);
type_->auto_fill_type_object(false);
type_->auto_fill_type_information(true);

step3:
HelloWorld hello_;
hello_.index(0);
hello_.pos().ts().h(10);
hello_.pos().x(10);
writer_->write(&hello_);

it's same with this .
publisher:  TypeLookupService -x complete
fastddsspy will come to Segmentation fault again.

Hi @wannastar
What you are describing is one of the detected issues with Dynamic Types currently present in master branch.
An exhaustive refactor tackling all these issues and aiming to fully comply with the OMG standard is currently being performed, and it is expected to be completed in the upcoming months.
For the time being, there exists an unsupported branch containing a bunch of temporary workarounds which probably would solve your issue.

okay, i got it. i'm looking forward to a better fastdds tool.


Index out of range error on collapse

Description
When the bar has more than one SideItem with children, a "RangeError" is displayed when the bar is in collapsed mode.
To Reproduce

Create a 'AnimatedSideBar'
Add at least 2 'SideBarItem' with at least 2 'SideBarChildItem' each
Run on Web (I checked on chrome)
Collapse the sideBar
Error displayed within the sideBar
Sometimes if the SIdebarItems with children are opened before collapsing the sidebar, the error does not occur

Expected behavior
No errors must be displayed. Must support multiple items with multiple sub-Items within.
Screenshots

Desktop:

OS: Windows 11
Browser: Chrome
Version: Chrome version - (Version 115.0.5790.171 (Official Build) (32-bit))

check my pull request https://github.com/DefineJH/animated_sidebar/tree/main
It happened to me too so I changed main source code little to handle those errors.


Local privilege escalation by invalidating the PTR_VALIDATE/ptr_validate/PTR_INRANGE check

The PTR_INRANGE compared the input address within the range (current_process->image.entry, 0x8000000000000000)
#define PTR_INRANGE(PTR) \
	((uintptr_t)(PTR) > this_core->current_process->image.entry && ((uintptr_t)(PTR) < 0x8000000000000000))

However, it could be bypassed using this:
https://github.com/klange/toaruos/blob/a54a0cbbee1ac18bceb2371e49876eab9abb3a11/kernel/misc/elf64.c#L353
which will set the image.entry to whatever we set in a static-linked binary, for example 0x0.
Basically, we can exec a static binary with header.e_entry setting to address lower than the kernel base 0x100000 and use TOARU_SYS_FUNC_MMAP in sys_sysfunc to map the whole kernel image into the user space. Then we just patch the sys_setuid's check and spawn another process to get root shell.
Here is a proof-of-concept that I used in hxp ctf 2024.

Glossing over the obvious error of using user-controlled data in a 'security' check, this check doesn't even make sense in the normal case - surely an entirely normal binary could have an entry point that is after some address that would be passed to a system call?
Since Misaka no longer extends the low kernel address space (and doesn't map anything from the kernel low in the aarch64 port), possibly a more sensible check is if the address is after the end of the low kernel mapping - or maybe I should get off my butt and get around to moving the x86-64 kernel to a higher-half mapping...


Add-Migration behavior with LogLevel

When I am running Add-Migrations I am getting the following error message
An error occurred while accessing the IWebHost on class 'Program'. Continuing without the application service provider. Error: Configuration value 'Info' is not supported. Unable to create an object of type 'MyContext'. Add an implementation of 'IDesignTimeDbContextFactory<MyContext>' to the project, or see https://go.microsoft.com/fwlink/?linkid=851728 for additional patterns supported at design time.
When I change the appsettings.developments, LogLevel-->Default = Debug everything works well even without having the IDesignTimeDbContextFactory and keeping the method CreateWebHostBuilder as it is.
Steps to reproduce

Create a simple API with .net core 2.1
Add a DbContext and a simple entity
Try to run add-migration

Further technical details
EF Core version: 2.1
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 7
IDE: (e.g. Visual Studio 2017 15.8)
WebApplication6.zip
2018-09-04 14.39.zip

@daniloak Can you post a runnable/project solution that demonstrates the behavior you are seeing so that we can investigate further.

I edited the issue, I also added a video showing the issue, please, do not consider the "notepad" part in the video

@daniloak I downloaded your project and tried running various migration commands. They all worked fine for me, which suggests something about your machine setup. I would try clearing your NuGet caches, reinstalling the .NET Core SDK, and possibly Visual Studio.

Did you use Debug or Info in the log level?

@daniloak I didn't change anything. I expected the project to be setup to reproduce the issue you are seeing.

Again with the parameter changed.
WebApplication6.zip

@daniloak Thanks, I am able to reproduce this now--we will investigate.

You cannot use just Info you need to use exact string version of the LogLevel enum as in this file. https://github.com/aspnet/Logging/blob/master/src/Microsoft.Extensions.Logging.Abstractions/LogLevel.cs


Ubuntu - Controller Action default view path incorrect

Sails Version: 0.10.5
Problem: Ubuntu is requesting lowercased string names for all default views for actions.
Controller:
{
    action: function(req, res){
        res.view({ a: 10, b: "Hello World"});
    },

    actionNumberTwo: function(req, res){
        res.view({ a: 15, b: "Hello Action 2"});
    }
}

'action' will perform perfectly. 'actionNumberTwo', for some reason on Ubuntu, will request the view named: 'actionnumbertwo.ejs'...
This definitely feels like an issue to me. But if I'm oblivious to something, I apologise.
There is a simple workaround to it, I'm just worried no one knows about the issue.

Sails always lowercases the action names internally; it's not an Ubuntu thing.  My guess is that you have your Ubuntu filesystem set up to be case-sensitive.  The workaround, which it sounds like you've probably already discovered, is to just have those view filenames be lowercased as well!

Oh thanks. I'm developing on a Mac and have now learned that Mac's filesystem isnt case-sensitive. Thanks for the information. :+1:


ec: Fail build on big-endian with enable-ec_nistp_64_gcc_128

I can't see way of making Configure fail but this at least makes the
build fail.
Fixes #15821
Checklist

Configure failing would be better.  @levitte, any ideas?

Configure failing would be better. @levitte, any ideas?

IMO this is good enough and we had various problems before when we tried to implement proper feature checking in Configure - think about cross compilation and similar things. IMO this would be Post 3.0 if we wanted to implement something like that properly.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged to master, thanks for the contribution.