Simplify location of protobuf legal license files

The current location of exception cases for legal license files are somewhat confusing, i.e. the root LICENSE file is actually a license that should only be used for the sbt protobuf subprojects.
This PR makes very clear/simple about which LICENSE files are used where, i.e.

LICENSE: This file is added as LICENSE to META-INF for every sbt sub project apart from the protobuf ones (i.e. its the global default)
legal/LICENSE.protobuf: This overrides the root LICENSE file and hence is added as LICENSE to the META-INF of protobuf projects
legal/COPYING.protobuf: This file is added as COPYING.protobuf to the META-INF of protobuf projects.

Output of show apacheSonatypeLicenseFile
[IJ]pekko > show apacheSonatypeLicenseFile
[info] pki / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] actor-testkit-typed / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] coordination / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] cluster-sharding-typed / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] actor-typed / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] docs / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] actor-typed-tests / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] testkit / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] stream / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] multi-node-testkit / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] persistence-query / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] osgi / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] persistence-typed-tests / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] persistence-testkit / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] persistence / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] cluster-tools / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] remote-tests / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] protobuf-v3 / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/legal/LICENSE.protobuf
[info] stream-tests-tck / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] protobuf / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/legal/LICENSE.protobuf
[info] actor / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] discovery / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] bench-jmh / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] cluster-metrics / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] bill-of-materials / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] stream-tests / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] stream-testkit / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] remote / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] distributed-data / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] cluster / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] actor-tests / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] slf4j / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] cluster-typed / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] serialization-jackson / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] persistence-tck / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] stream-typed / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] persistence-shared / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] persistence-typed / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] cluster-sharding / apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE
[info] apacheSonatypeLicenseFile
[info] 	/Users/mdedetrich/github/incubator-pekko/LICENSE

I am not all sure about this change. I woul be against changing the git root dir license, notice, disclaimer. Our git repo itself can be viewed as akin to a source release. We do need to add distinct licenses into some jars. I don't mind where they are in git as long as the jar is built ok.

It is an ASF norm to have the source distribution LICENSE git root.

I am not all sure about this change. I woul be against changing the git root dir license, notice, disclaimer. Our git repo itself can be viewed as akin to a source release. We do need to add distinct licenses into some jars. I don't mind where they are in git as long as the jar is built ok.

It is an ASF norm to have the source distribution LICENSE git root.

These 2 sentences seem to contradict eachother? Incase its not clear, this PR does not change the resulting jar's in any way. All it is re-arranges where the license files are stored in the git repo.
Also there is a LICENSE file in the root, thats not being changed (its actually the same standard LICENSE that is included in the source package and in every other pekko module). The issue right now is that the LICENSE file in the root dir is an exceptional one that is only used for certain maven artifacts (i.e. the protobuff ones).
I don't know if its intentional to use the protobuff specific exclusion for the root LICENSE file, but thats how it is right now. If this is intentional then it should be documented because right now its extremely confusing.

The root dir license needs to list code that is not ours. We've had other people look at this file and they seemed happy with it.

The root dir license needs to list code that is not ours. We've had other people look at this file and they seemed happy with it.

Thanks for clarifying, but if thats the case then this text (for the source package) is wrong

pekko-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
moved into the source package org.apache.pekko.protobuf so as to avoid version conflicts.
For license information see COPYING.protobuf

It would either need to be updated to (emphasis is bold)

pekko-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
moved into the source package org.apache.pekko.protobuf so as to avoid version conflicts.
For license information see licenses/COPYING.protobuf

Or the licenses/COPYING.protobuf needs to be moved to the root dir.

I can comment fuller later, I only have my mobile.

I can comment fuller later, I only have my mobile.

No worries its not urgent, I also added the blocked label. Even if the current state is how its meant to be (including the fact the text is pointing to a wrong location), we should very clearly comment/document that those files should not be moved around.

Actually I just noticed that I was wrong in my previous statement about the text being wrong, it was actually correct and I was accidentally looking at the wrong branch.
Will close the PR, apologies for wasting your time.


Use local broker address as serviceURL when running WebSocket component embedded in broker

Motivation
As described in #77, when WebSocket component is running embedded inside the broker and a VIP system is used as service discovery, there will be an authentication issue when the broker connects to itself, because the IP will be different.
Modifications
When WebSocket compute is running embedded in broker, always connect to local broker, without going through service discovery.
Result
Fixes #77

CLA is valid!

CLA is valid!

CLA is valid!


remove from travis integration-tests which are now running in prow

itests in prow take ~30minutes
We need to make the integration tests create only one set of certificates and reuse them for the whole run.

Shouldn't we also remove  build-integration?

/hold

@jboyd01 my gut says it provides a quick enough signal that things are bad that we should leave it in for now.
remove the hold if you agree with /hold cancel

I am going to add a comment that says why what's in that list is in it.

Yeah, sure, it's so quick in comparison to any tests we run, I'm all for it.  Thanks for the details.
/LGTM
/approve


CC: Rethink CC/CRDB Docs structure

Repeated comments at the Education offsite and 1:1 conversations have indicated that CC docs are not easy to spot and that it might be better to nest them within CRDB docs. Want to set aside some time to investigate and think through it.

This is large in scope and warrants being called out as a docs-project. It's also something we should do in collaboration with Design.

Yep. I opened issues for things that came out of the Education offsite/1:1 conversations so I won't forget about them later. Need to be thought through/triaged though.

@lnhsingh Is this a part of your and Lucia's docs redesign project? If yes, should I assign this issue to you?

Related issue: https://github.com/cockroachdb/docs/issues/5739

Closing this since the side nav and general redesign work has resolved this for the most part.

Closing this since the side nav and general redesign work has resolved this for the most part.


min side panel size argument

To allow flywire to adjust min side panel size

Could minSidePanelSize go inside options? That feels like a more appropriate place for it


How can I make it work? I already installed, and I don't know what to do.

reboot the phone? provide the logs?

it seems like you are new to modules.
if you install the module that involves a system app, you may be able to restart it from LSPosed itself, but for system services such as a “SystemUI“ or “Android Framework” the simplest way to restart those apps is to reboot the whole device, since those are the wrap of the whole interface.
also, if you’re thinking that some modules don’t work, don’t forget to look inside the logs inside LSPosed.
if my module produces “not found” exceptions, that may mean that you’re using some different user interface such as OneUI, MIUI, etc. those are NOT supported.
the only UI supported and confirmed to be compatible with this module is stock Android  UI (or the UI with minimal changes in the code) because it is open source and i use it on a daily basis.


no such file or directory, mkdir '/opt/iobroker/node_modules/iobroker-data/plenticore.0' after js.update

Hello after updating to js.controller 5.0.12 I get this error message.
I have now updated from Versuon 2.2.0 to version 2.3.0. The problem remains
Thank you for your effort
js.controller 5.0.12
NPM 9.6.7
Node.js 18.17.1
`

plenticore.0
2023-10-30 17:09:45.518
warn
Terminated (UNCAUGHT_EXCEPTION): Without reason

plenticore.0
2023-10-30 17:09:44.525
error
Exception-Code:  ERR_INVALID_ARG_TYPE: The "path" argument must be of type string or an  instance of Buffer or URL. Received undefined

plenticore.0
2023-10-30 17:09:44.523
error
TypeError  [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or  an instance of Buffer or URL. Received undefined     at Object.openSync (node:fs:595:10)     at Object.writeFileSync (node:fs:2324:35)     at Object.unload  (/opt/iobroker/node_modules/iobroker.plenticore/lib/plenticore.js:789:5)     at AdapterClass.  (/opt/iobroker/node_modules/iobroker.plenticore/main.js:40:14)     at AdapterClass.emit (node:events:514:28)     at AdapterClass._stop  (/opt/iobroker/node_modules/@iobroker/js-controller-adapter/build/lib/adapter/adapter.js:1369:26)     at AdapterClass._exceptionHandler  (/opt/iobroker/node_modules/@iobroker/js-controller-adapter/build/lib/adapter/adapter.js:9113:18)     at process.processTicksAndRejections  (node:internal/process/task_queues:95:5)

plenticore.0
2023-10-30 17:09:44.519
error
unhandled promise rejection: The "path" argument must be of type string or an instance of Buffer or URL. Received undefined

plenticore.0
2023-10-30 17:09:44.518
error
Unhandled  promise rejection. This error originated either by throwing inside of  an async function without a catch block, or by rejecting a promise which  was not handled with .catch().

plenticore.0
2023-10-30 17:09:44.501
error
Exception-Code: ENOENT: ENOENT: no such file or directory, mkdir '/opt/iobroker/node_modules/iobroker-data/plenticore.0'

plenticore.0
2023-10-30 17:09:44.500
error
Error: ENOENT: no such file or directory, mkdir '/opt/iobroker/node_modules/iobroker-data/plenticore.0'     at Object.mkdirSync (node:fs:1398:3)     at Object.setup (/opt/iobroker/node_modules/iobroker.plenticore/lib/plenticore.js:711:6)     at Immediate. (/opt/iobroker/node_modules/iobroker.plenticore/main.js:189:17)     at process.processImmediate (node:internal/timers:478:21)

plenticore.0
2023-10-30 17:09:44.497
error
uncaught exception: ENOENT: no such file or directory, mkdir '/opt/iobroker/node_modules/iobroker-data/plenticore.0'

plenticore.0
2023-10-30 17:09:44.491
info
[INFO] Configured polling interval: 20000

plenticore.0
2023-10-30 17:09:44.489
info
Configured battery strategy is: 1

plenticore.0
2023-10-30 17:09:44.488
info
Configured maximum feed-in power is 5000

plenticore.0
2023-10-30 17:09:44.486
info
Configured Wp of panel(s) is 0

plenticore.0
2023-10-30 17:09:44.426
info
[START] Starting adapter plenticore v2.3.0r237

plenticore.0
2023-10-30 17:09:44.348
info
starting. Version 2.3.0 in /opt/iobroker/node_modules/iobroker.plenticore, node: v18.17.1, js-controller: 5.0.12

plenticore.0
2023-10-30 17:09:09.432
warn
Terminated (UNCAUGHT_EXCEPTION): Without reason

plenticore.0
2023-10-30 17:09:08.439
error
Exception-Code:  ERR_INVALID_ARG_TYPE: The "path" argument must be of type string or an  instance of Buffer or URL. Received undefined

plenticore.0
2023-10-30 17:09:08.438
error
TypeError  [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or  an instance of Buffer or URL. Received undefined     at Object.openSync (node:fs:595:10)     at Object.writeFileSync (node:fs:2324:35)     at Object.unload  (/opt/iobroker/node_modules/iobroker.plenticore/lib/plenticore.js:789:5)     at AdapterClass.  (/opt/iobroker/node_modules/iobroker.plenticore/main.js:40:14)     at AdapterClass.emit (node:events:514:28)     at AdapterClass._stop  (/opt/iobroker/node_modules/@iobroker/js-controller-adapter/build/lib/adapter/adapter.js:1369:26)     at AdapterClass._exceptionHandler  (/opt/iobroker/node_modules/@iobroker/js-controller-adapter/build/lib/adapter/adapter.js:9113:18)     at process.processTicksAndRejections  (node:internal/process/task_queues:95:5)

plenticore.0
2023-10-30 17:09:08.432
error
unhandled promise rejection: The "path" argument must be of type string or an instance of Buffer or URL. Received undefined

plenticore.0
2023-10-30 17:09:08.431
error
Unhandled  promise rejection. This error originated either by throwing inside of  an async function without a catch block, or by rejecting a promise which  was not handled with .catch().

plenticore.0
2023-10-30 17:09:08.387
error
Exception-Code: ENOENT: ENOENT: no such file or directory, mkdir '/opt/iobroker/node_modules/iobroker-data/plenticore.0'

plenticore.0
2023-10-30 17:09:08.385
error
Error: ENOENT: no such file or directory, mkdir '/opt/iobroker/node_modules/iobroker-data/plenticore.0'     at Object.mkdirSync (node:fs:1398:3)     at Object.setup (/opt/iobroker/node_modules/iobroker.plenticore/lib/plenticore.js:711:6)     at Immediate. (/opt/iobroker/node_modules/iobroker.plenticore/main.js:189:17)     at process.processImmediate (node:internal/timers:478:21)

plenticore.0
2023-10-30 17:09:08.380
error
uncaught exception: ENOENT: no such file or directory, mkdir '/opt/iobroker/node_modules/iobroker-data/plenticore.0'

plenticore.0
2023-10-30 17:09:08.373
info
[INFO] Configured polling interval: 20000

plenticore.0
2023-10-30 17:09:08.370
info
Configured battery strategy is: 1

plenticore.0
2023-10-30 17:09:08.369
info
Configured maximum feed-in power is 5000

plenticore.0
2023-10-30 17:09:08.367
info
Configured Wp of panel(s) is 0

plenticore.0
2023-10-30 17:09:08.295
info
[START] Starting adapter plenticore v2.3.0r237

plenticore.0
2023-10-30 17:09:08.229
info
starting. Version 2.3.0 in /opt/iobroker/node_modules/iobroker.plenticore, node: v18.17.1, js-controller: 5.0.12

plenticore.0
2023-10-30 17:08:33.385
warn
Terminated (UNCAUGHT_EXCEPTION): Without reason

plenticore.0
2023-10-30 17:08:32.392
error
Exception-Code:  ERR_INVALID_ARG_TYPE: The "path" argument must be of type string or an  instance of Buffer or URL. Received undefined

plenticore.0
2023-10-30 17:08:32.391
error
TypeError  [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or  an instance of Buffer or URL. Received undefined    at Object.openSync  (node:fs:595:10)    at Object.writeFileSync (node:fs:2324:35)    at  Object.unload  (/opt/iobroker/node_modules/iobroker.plenticore/lib/plenticore.js:789:5)     at AdapterClass.  (/opt/iobroker/node_modules/iobroker.plenticore/main.js:40:14)    at  AdapterClass.emit (node:events:514:28)    at AdapterClass._stop  (/opt/iobroker/node_modules/@iobroker/js-controller-adapter/build/lib/adapter/adapter.js:1369:26)     at AdapterClass._exceptionHandler  (/opt/iobroker/node_modules/@iobroker/js-controller-adapter/build/lib/adapter/adapter.js:9113:18)     at process.processTicksAndRejections  (node:internal/process/task_queues:95:5)

plenticore.0
2023-10-30 17:08:32.386
error
unhandled promise rejection: The "path" argument must be of type string or an instance of Buffer or URL. Received undefined

plenticore.0
2023-10-30 17:08:32.384
error
Unhandled  promise rejection. This error originated either by throwing inside of  an async function without a catch block, or by rejecting a promise which  was not handled with .catch().

plenticore.0
2023-10-30 17:08:32.357
error
Exception-Code: ENOENT: ENOENT: no such file or directory, mkdir '/opt/iobroker/node_modules/iobroker-data/plenticore.0'

plenticore.0
2023-10-30 17:08:32.356
error
Error:  ENOENT: no such file or directory, mkdir  '/opt/iobroker/node_modules/iobroker-data/plenticore.0'    at  Object.mkdirSync (node:fs:1398:3)    at Object.setup  (/opt/iobroker/node_modules/iobroker.plenticore/lib/plenticore.js:711:6)     at Immediate.  (/opt/iobroker/node_modules/iobroker.plenticore/main.js:189:17)    at  process.processImmediate (node:internal/timers:478:21)

plenticore.0
2023-10-30 17:08:32.353
error
uncaught exception: ENOENT: no such file or directory, mkdir '/opt/iobroker/node_modules/iobroker-data/plenticore.0'

`

I am using the following versions witout any issue:

js-controller: 5.0.12
Node.js: v18.18.2
NPM: 9.8.1

With another adapter I had problems after update to
npm 9.8.1 and node 18.18.0
This was gone after update to v18.18.1.

I have now rolled back to js.controller 4.0.24. Everything runs smoothly there. As soon as I upgrade again to 5.0.12 the error message appears again.

I checked with FileZilla. There is no "iobroker-data" folder in the "/opt/iobroker/node_modules" folder
@PastCoder Could you please check whether this folder is available to you?

No, in my /opt/iobroker/node_modules there is no folder iobroker-data but several iobroker.* like iobroker.plenticore

BTW: That's the problem I had after some updates: https://github.com/ioBroker/ioBroker.zigbee/issues/1893

duplicate of https://github.com/pixcept/ioBroker.plenticore/issues/84
maintainer must update code as suggested at #84

@mcm1957 However, on my test system the adapter runs without any problems with js.controller version 5.0.12

I do have exactly the same problem as @andre-bu after updating to js-controller 5.0.16 today.

Please check if the latest git version fixes it.

@pixcept Many thanks for your effort. I'll try it out and give feedback.

@pixcept should I use Git Url or “latest” repo

Git URL please.

@pixcept Thank you very much, it worked.

@pixcept Thank you very much, it worked.

Confirmed. Thank you!


[gsoc] run_all.py new mechanism for checking required imports

What does this PR do?
This PR changes the mechanism in which run_all checks for whether import requirements are satisfied. Now each test file should include the comment:
# nuitka-skip-test-unless: required_module
The new helper function find_required_module inside run_all.py will search for this comment in every test module and check that required_module exists, otherwise continue (skip current test)
This new mechanism makes it more clear what imports are required for each test file, as they will be stated in a special comment inside each test file. It also improves code readability and eliminates repetition in run_all.py
This PR also changed every existing test file to include the special comment stating their required imports
In addition, the new Urllib3Using.py module is added, which run_all.py uses to test Nuitka's compatibility with urllib3.
Why was it initiated? Any relevant Issues?
This is part of my Google Summer of Code proposal.
PR Checklist

[x] Correct base branch selected? develop for new features and bug fixes too. If it's
part of a hotfix, it will be moved to master during it.
[x] All tests still pass. Check the developer manual about Running the Tests. There
are Travis tests that cover the most important things however, and you are
welcome to rely on those, but they might not cover enough.
[x] Ideally new features or fixed regressions ought to be covered via new tests.
[x] Ideally new or changed features have documentation updates.

@kayhayen Please check over the new mechanism I've implemented for run_all.py!
Also, Urllib3Using.py works fine using manual testing, but during automated testing the following error is raised:
Comparing output of 'Urllib3Using.py' using 'C:\Users\Tommy\AppData\Local\Programs\Python\Python37-32\python.exe' with flags silent, expect_success, standalone, remove_output ...
--- C:\Users\Tommy\AppData\Local\Programs\Python\Python37-32\python.exe (stderr)
+++ nuitka (stderr)
@@ -1 +1,2 @@
+Nuitka:WARNING:Unresolved 'import' call at 'C:\Users\Tommy\AppData\Local\Programs\Python\Python37-32\lib\site-packages\urllib3\packages\six.py:82' may require use of '--include-plugin-directory' or '--include-plugin-files'.
Error, outputs differed.
Skipped, Win32ComUsing.py (win32com not installed for this Python version, but test needs it).
I understand that urllib3 is fully working and this is just a warning message for the six compatibility layer, so should I just suppress errors like these?

As for the __import__ warning consider this function:
https://github.com/Nuitka/Nuitka/blob/69183f6567befd62bc1d768dd070fb99475b8cb4/nuitka/importing/Importing.py#L154
I would say that six should be added here. Probably there is a bunch more of those, although I sort of feel that we should have to look and make sure that the line is not disguising hidden dependencies, but I am pretty confident I would know by now from user bug reports, so it feels unlikely.

As for the __import__ warning consider this function:
Nuitka/nuitka/importing/Importing.py
Line 154 in 69183f6
def isWhiteListedImport(node):
I would say that six should be added here. Probably there is a bunch more of those, although I sort of feel that we should have to look and make sure that the line is not disguising hidden dependencies, but I am pretty confident I would know by now from user bug reports, so it feels unlikely.

As for the __import__ warning consider this function:
Nuitka/nuitka/importing/Importing.py
Line 154 in 69183f6
def isWhiteListedImport(node):
I would say that six should be added here. Probably there is a bunch more of those, although I sort of feel that we should have to look and make sure that the line is not disguising hidden dependencies, but I am pretty confident I would know by now from user bug reports, so it feels unlikely.

Do you want me to whitelist it? Or should we leave it for now? And you mean to add them as a special case check inside isWhiteListedImport right?

Generally, I would suggest you allow Python code behind the marker, and then execute it in Python, seeing if it crashes (ImportError), so do like hasModule does, but use sys.exit(__import__("flask"), and the user would specifiy # nuitka-skip-test-unless: import("flask").

I understand what you mean, but need a little more elaboration. So shuold I make findRequiredModules so that it uses the approach you named above to check whether all the required imports exist, and return a boolean value, and skip the usage of hasModule altogether? And it would probably be renamed to checkRequiredModules, and it would just be called for every single test file. This would eliminate the need for using hasModule.

Then it's not limited to modules, can be any expression, and of course can do checks in sys.version etc. as we see fit, and you would probably statically add import os, sys before the call. Let me know if I was clear enough.

So how would this work in the case of Tkinter, where it's "Tkinter" for python2 and "tkinter" for python3? Also would we need to change the syntax for our special comment? Refer to my reply above:

I understand, but the issue with TkInter was that the import which should be checked for depends on python version, "Tkinter" for python2 and "tkinter" for python3. In this case without the "specials", a test might be skipped altogether even if the requirement was met, and changing elif to if wouldn't help the issue. If we do this without specials, should we develop a new syntax for the special comment? e.g. # nuitka-skip-unless: Tkinter || tkinter, or something along the lines of that?

the issue. If we do this without specials, should we develop a new syntax for the special comment? > e.g. # nuitka-skip-unless: Tkinter || tkinter, or something along the lines of that?

I would be fine with this:
# nuitka-skip-unless:  __import__("Tkinter" if sys.version_info[0] < 3 else "tkinter")
That means, the comment becomes code to evaluate. And it's run much like the import check currently is done with the "-c", and would have to be an expression, so you can feed it into a template of say import sys, os; sys.exit(%s) which we can use to tell if it passes. An exception (ImportError here) or a false expression can then both be detected from the exit code not being 0.

Then we can throw away the imports checking, and only use this, and have __import__("flask") and the like as the simple solution. The test runner would then only concern itself with that kind of thing, or you have both, # nuitka-skip-unless-expression and # nuitka-skip-unless-imports, your pick.

or you have both, # nuitka-skip-unless-expression and # nuitka-skip-unless-imports, your pick.

Updated with the new checkRequirements method supporting both, please check over.
University resumes tomorrow for me, so I'll probably be less active until the weekends.

Updated Urllib3Using.py to use only on localhost, eliminating external source dependency. For SSL tests, should it be in a separate module?

Fantastic job, Tommy, I will merge once I put out the stable release, so this doesn't bring up unexpected failures. Most probably later today.

As for SSL, I would use the same test. Using 2 tests will incur too much cost in compile times.

I am very excited about this one. Really liking how this simplifies the Top 50 task by allowing to not have to edit the run_all.py for every package.
Thanks for your contribution!

@tommyli3318 this has helped me a lot. Thanks for your contribution!


[SMALLFIX]Use static imports for standard test utilities for class AsyncJournalWriterTest

[SMALLFIX]Use static imports for standard test utilities for class AsyncJournalWriterTest

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17738/
Test PASSed.


Notification Enhancements - Only Authorized users will see notification for Product / Engagement / Test - #2738

#2738 Added checks to look for authorized user in notifications.

Please fix flake8 violations. Otherwise it looks good.

Please fix flake8 violations. Otherwise it looks good.

@Maffooch Thanks, learnt again something new. It's done.

I had to change this code quite a lot in #2889 to fix some more stuff. And now the issue here (2738) is also fixed in there as the way it works now is different so the issue with authorized users won't occur.
So although we relaly like you contributing, it is better to close this PR now.

Closing this PR, much of the large changes are handled in #2889


test: remove dependency on diff from tests

DRAFT--IGNORE
What type of PR is this?
/kind test
/kind regression
What this PR does / why we need it:
A recently introduced test used the diff utility, which isn't installed by default on our mariner images.
Requirements:

[x] uses conventional commit messages
[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
In addition to normal checkin pipelines, I also ran a mariner-specific pipeline to test with the most recent build of mariner: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=398762&view=results
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall First build on tobiasb/remove-diff-from-tests at 60.655%

Totals

Change from base Build<PHONE_NUMBER>:
60.7%

Covered Lines:
2576

Relevant Lines:
4247

💛  - Coveralls


property-naming flags extension properties

The following code gets flagged with 0.49.1:
val Context.adsDelegateFactory @SuppressLint("WrongConstant") get() =
  applicationContext.getSystemService(SYSTEM_SERVICE_AD_DELEGATE_FACTORY) as AdsDelegateFactory

Property name should use the screaming snake case notation when the value can not be changed (standard:property-naming)

I would not expect this, if you're adding a property via an extension and leveraging get() since the value can indeed change inside the implementation.

So when I remove @SuppressLint("WrongConstant") it does not get flagged as expected. So there's something weird going on.

Indeed, the annotation causes the check to fail. Same happens with:
val Context.adsDelegateFactory private get() =
    applicationContext.getSystemService(SYSTEM_SERVICE_AD_DELEGATE_FACTORY) as AdsDelegateFactory

Problem will either be resolved in 0.49.2 only when more pressing bugs need to be fixed. Otherwise it will be fixed in the next normal release.


GCC_VERSION = com.apple.compilers.llvm.clang.1_0
                        GCC_VERSION_IDENTIFIER = com_apple_compilers_llvm_clang_1_0
                        GCC_WARN_64_TO_32_BIT_CONVERSION = YES
                        GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR
                        GCC_WARN_UNDECLARED_SELECTOR = YES
                        GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE
                        GCC_WARN_UNUSED_FUNCTION = YES
                        GCC_WARN_UNUSED_VARIABLE = YES
                        GENERATED_MODULEMAP_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/GeneratedModuleMaps-iphoneos
                        GENERATE_MASTER_OBJECT_FILE = NO
                        GENERATE_PKGINFO_FILE = YES
                        GENERATE_PROFILING_CODE = NO
                        GENERATE_TEXT_BASED_STUBS = NO
                        GID = 20
                        GROUP = staff
                        HEADERMAP_INCLUDES_FLAT_ENTRIES_FOR_TARGET_BEING_BUILT = YES
                        HEADERMAP_INCLUDES_FRAMEWORK_ENTRIES_FOR_ALL_PRODUCT_TYPES = YES
                        HEADERMAP_INCLUDES_NONPUBLIC_NONPRIVATE_HEADERS = YES
                        HEADERMAP_INCLUDES_PROJECT_HEADERS = YES
                        HEADERMAP_USES_FRAMEWORK_PREFIX_ENTRIES = YES
                        HEADERMAP_USES_VFS = NO
                        HEADER_SEARCH_PATHS =
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/AppAuth/AppAuth.framework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/FBSDKCoreKit/FBSDKCoreKit.framework/Headers
                        "
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/FBSDKCoreKit_Basics/FBSDKCoreKit_Basics.fra
                        mework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/FBSDKLoginKit/FBSDKLoginKit.framework/Heade
                        rs"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/FirebaseABTesting/FirebaseABTesting.framewo
                        rk/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/FirebaseAuth/FirebaseAuth.framework/Headers
                        "
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/FirebaseCore/FirebaseCore.framework/Headers
                        "
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/FirebaseCoreDiagnostics/FirebaseCoreDiagnos
                        tics.framework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/FirebaseCrashlytics/FirebaseCrashlytics.fra
                        mework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/FirebaseInstallations/FirebaseInstallations
                        .framework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/FirebasePerformance/FirebasePerformance.fra
                        mework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/FirebaseRemoteConfig/FirebaseRemoteConfig.f
                        ramework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/GTMAppAuth/GTMAppAuth.framework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/GTMSessionFetcher/GTMSessionFetcher.framewo
                        rk/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/GoogleDataTransport/GoogleDataTransport.fra
                        mework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/GoogleToolboxForMac/GoogleToolboxForMac.fra
                        mework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/GoogleUtilities/GoogleUtilities.framework/H
                        eaders"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/GoogleUtilitiesComponents/GoogleUtilitiesCo
                        mponents.framework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/PromisesObjC/FBLPromises.framework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/Protobuf/Protobuf.framework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/SSZipArchive/SSZipArchive.framework/Headers
                        " "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/Stripe/Stripe.framework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/camera/camera.framework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/firebase_auth/firebase_auth.framework/Heade
                        rs"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/firebase_core/firebase_core.framework/Heade
                        rs"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/firebase_crashlytics/firebase_crashlytics.f
                        ramework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/firebase_performance/firebase_performance.f
                        ramework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/flutter_facebook_auth/flutter_facebook_auth
                        .framework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/google_ml_kit/google_ml_kit.framework/Heade
                        rs"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/google_sign_in/google_sign_in.framework/Hea
                        ders"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/image_picker/image_picker.framework/Headers
                        "
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/integration_test/integration_test.framework
                        /Headers" "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/nanopb/nanopb.framework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/open_file/open_file.framework/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/path_provider/path_provider.framework/Heade
                        rs"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/permission_handler/permission_handler.frame
                        work/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/shared_preferences/shared_preferences.frame
                        work/Headers"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/stripe_payment/stripe_payment.framework/Hea
                        ders"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/url_launcher/url_launcher.framework/Headers
                        "
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/webview_flutter/webview_flutter.framework/H
                        eaders" "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/Pods/Headers/Public"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/Pods/Headers/Public/Firebase"
                        "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/Pods/Headers/Public/GoogleMLKit"
                        /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/Pods/Firebase/CoreOnly/Sources
                        /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/Pods/GoogleMLKit/MLKitCore/Sources "/Sources/FBLPromises/include"
                        HIDE_BITCODE_SYMBOLS = YES
                        HOME = /Users/sebghatullah
                        ICONV = /usr/bin/iconv
                        INFOPLIST_EXPAND_BUILD_SETTINGS = YES
                        INFOPLIST_FILE = Runner/Info.plist
                        INFOPLIST_OUTPUT_FORMAT = binary
                        INFOPLIST_PATH = Runner.app/Info.plist
                        INFOPLIST_PREPROCESS = NO
                        INFOSTRINGS_PATH = Runner.app/en.lproj/InfoPlist.strings
                        INLINE_PRIVATE_FRAMEWORKS = NO
                        INSTALLHDRS_COPY_PHASE = NO
                        INSTALLHDRS_SCRIPT_PHASE = NO
                        INSTALL_DIR = /tmp/Runner.dst/Applications
                        INSTALL_GROUP = staff
                        INSTALL_MODE_FLAG = u+w,go-w,a+rX
                        INSTALL_OWNER = sebghatullah
                        INSTALL_PATH = /Applications
                        INSTALL_ROOT = /tmp/Runner.dst
                        IPHONEOS_DEPLOYMENT_TARGET = 10.0
                        JAVAC_DEFAULT_FLAGS = -J-Xms64m -J-XX:NewSize=4M -J-Dfile.encoding=UTF8
                        JAVA_APP_STUB = /System/Library/Frameworks/JavaVM.framework/Resources/MacOS/JavaApplicationStub
                        JAVA_ARCHIVE_CLASSES = YES
                        JAVA_ARCHIVE_TYPE = JAR
                        JAVA_COMPILER = /usr/bin/javac
                        JAVA_FOLDER_PATH = Runner.app/Java
                        JAVA_FRAMEWORK_RESOURCES_DIRS = Resources
                        JAVA_JAR_FLAGS = cv
                        JAVA_SOURCE_SUBDIR = .
                        JAVA_USE_DEPENDENCIES = YES
                        JAVA_ZIP_FLAGS = -urg
                        JIKES_DEFAULT_FLAGS = +E +OLDCSO
                        KASAN_DEFAULT_CFLAGS = -DKASAN=1 -fsanitize=address -mllvm -asan-globals-live-support -mllvm -asan-force-dynamic-shadow
                        KEEP_PRIVATE_EXTERNS = NO
                        LD_DEPENDENCY_INFO_FILE =
                        /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build/Release-iphoneos/Runner.build/Objects-normal/arm
                        64/Runner_dependency_info.dat
                        LD_GENERATE_MAP_FILE = NO
                        LD_MAP_FILE_PATH =
                        /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build/Release-iphoneos/Runner.build/Runner-LinkMap-nor
                        mal-arm64.txt
                        LD_NO_PIE = NO
                        LD_QUOTE_LINKER_ARGUMENTS_FOR_COMPILER_DRIVER = YES
                        LD_RUNPATH_SEARCH_PATHS =  '@executable_path/Frameworks' '@loader_path/Frameworks' @executable_path/Frameworks
                        LEGACY_DEVELOPER_DIR = /Applications/Xcode.app/Contents/PlugIns/Xcode3Core.ideplugin/Contents/SharedSupport/Developer
                        LEX = lex
                        LIBRARY_DEXT_INSTALL_PATH = /Library/DriverExtensions
                        LIBRARY_FLAG_NOSPACE = YES
                        LIBRARY_FLAG_PREFIX = -l
                        LIBRARY_KEXT_INSTALL_PATH = /Library/Extensions
                        LIBRARY_SEARCH_PATHS =  "/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/Pods/Stripe/InternalFrameworks"
                        LINKER_DISPLAYS_MANGLED_NAMES = NO
                        LINK_FILE_LIST_normal_arm64 =
                        LINK_WITH_STANDARD_LIBRARIES = YES
                        LLVM_TARGET_TRIPLE_OS_VERSION = ios10.0
                        LLVM_TARGET_TRIPLE_VENDOR = apple
                        LOCALIZABLE_CONTENT_DIR =
                        LOCALIZATION_EXPORT_SUPPORTED = YES
                        LOCALIZED_RESOURCES_FOLDER_PATH = Runner.app/en.lproj
                        LOCALIZED_STRING_MACRO_NAMES = NSLocalizedString CFCopyLocalizedString
                        LOCALIZED_STRING_SWIFTUI_SUPPORT = YES
                        LOCAL_ADMIN_APPS_DIR = /Applications/Utilities
                        LOCAL_APPS_DIR = /Applications
                        LOCAL_DEVELOPER_DIR = /Library/Developer
                        LOCAL_LIBRARY_DIR = /Library
                        LOCROOT =
                        LOCSYMROOT =
                        MACH_O_TYPE = mh_execute
                        MAC_OS_X_PRODUCT_BUILD_VERSION = 20D91
                        MAC_OS_X_VERSION_ACTUAL = 110203
                        MAC_OS_X_VERSION_MAJOR = 110000
                        MAC_OS_X_VERSION_MINOR = 110200
                        METAL_LIBRARY_FILE_BASE = default
                        METAL_LIBRARY_OUTPUT_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/Runner.app
                        MODULES_FOLDER_PATH = Runner.app/Modules
                        MODULE_CACHE_DIR = /Users/sebghatullah/Library/Developer/Xcode/DerivedData/ModuleCache.noindex
                        MTL_ENABLE_DEBUG_INFO = NO
                        NATIVE_ARCH = armv7
                        NATIVE_ARCH_32_BIT = i386
                        NATIVE_ARCH_64_BIT = arm64e
                        NATIVE_ARCH_ACTUAL = arm64e
                        NO_COMMON = YES
                        OBJECT_FILE_DIR =
                        /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build/Release-iphoneos/Runner.build/Objects
                        OBJECT_FILE_DIR_normal =
                        /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build/Release-iphoneos/Runner.build/Objects-normal
                        OBJROOT = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios
                        ONLY_ACTIVE_ARCH = NO
                        OS = MACOS
                        OSAC = /usr/bin/osacompile
                        OTHER_LDFLAGS =  -ObjC -l"c++" -l"iconv" -l"sqlite3" -l"stdc++" -l"z" -framework "AVFoundation" -framework "Accelerate"
                        -framework "AppAuth" -framework "Contacts" -framework "CoreGraphics" -framework "CoreImage" -framework "CoreLocation"
                        -framework "CoreMedia" -framework "CoreTelephony" -framework "CoreText" -framework "CoreVideo" -framework "FBLPromises"
                        -framework "FBSDKCoreKit" -framework "FBSDKCoreKit_Basics" -framework "FBSDKLoginKit" -framework "FirebaseABTesting"
                        -framework "FirebaseAuth" -framework "FirebaseCore" -framework "FirebaseCoreDiagnostics" -framework "FirebaseCrashlytics"
                        -framework "FirebaseInstallations" -framework "FirebasePerformance" -framework "FirebaseRemoteConfig" -framework "Foundation"
                        -framework "GTMAppAuth" -framework "GTMSessionFetcher" -framework "GoogleDataTransport" -framework "GoogleSignIn" -framework
                        "GoogleToolboxForMac" -framework "GoogleUtilities" -framework "GoogleUtilitiesComponents" -framework "LocalAuthentication"
                        -framework "MLImage" -framework "MLKitBarcodeScanning" -framework "MLKitCommon" -framework "MLKitDigitalInkRecognition"
                        -framework "MLKitFaceDetection" -framework "MLKitImageLabeling" -framework "MLKitImageLabelingCommon" -framework
                        "MLKitImageLabelingCustom" -framework "MLKitMDD" -framework "MLKitObjectDetectionCommon" -framework "MLKitPoseDetection"
                        -framework "MLKitPoseDetectionAccurate" -framework "MLKitPoseDetectionCommon" -framework "MLKitTextRecognition" -framework
                        "MLKitVision" -framework "MLKitVisionKit" -framework "MLKitXenoCommon" -framework "PassKit" -framework "Protobuf" -framework
                        "SSZipArchive" -framework "SafariServices" -framework "Security" -framework "Stripe" -framework "SystemConfiguration"
                        -framework "UIKit" -framework "WebKit" -framework "camera" -framework "firebase_auth" -framework "firebase_core" -framework
                        "firebase_crashlytics" -framework "firebase_performance" -framework "flutter_facebook_auth" -framework "google_ml_kit"
                        -framework "google_sign_in" -framework "image_picker" -framework "integration_test" -framework "nanopb" -framework
                        "open_file" -framework "path_provider" -framework "permission_handler" -framework "shared_preferences" -framework
                        "stripe_payment" -framework "url_launcher" -framework "webview_flutter" -weak_framework "Accelerate" -weak_framework
                        "Accounts" -weak_framework "AdSupport" -weak_framework "AudioToolbox" -weak_framework "AuthenticationServices"
                        -weak_framework "CoreGraphics" -weak_framework "Foundation" -weak_framework "QuartzCore" -weak_framework "Security"
                        -weak_framework "Social" -weak_framework "StoreKit" -weak_framework "UIKit"
                        OTHER_SWIFT_FLAGS =  -D COCOAPODS
                        PACKAGE_CONFIG = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/.dart_tool/package_config.json
                        PACKAGE_TYPE = com.apple.package-type.wrapper.application
                        PASCAL_STRINGS = YES
                        PATH =
                        /Applications/Xcode.app/Contents/Developer/usr/bin:/Users/sebghatullah/dev/google-cloud-sdk/bin:/Library/Java/JavaVirtualMach
                        ines/adoptopenjdk-8.jdk/Contents/Home/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/
                        Library/Apple/usr/bin:/Users/sebghatullah/dev/google-cloud-sdk/bin:/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Conte
                        nts/Home/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/Applications/Visual Studio
                        Code.app/Contents/Resources/app/bin:/Users/sebghatullah/FlutterDev/flutter/bin:/Users/sebghatullah/Library/Android/sdk/platfo
                        rm-tools:/Users/sebghatullah/FlutterDev/flutter/.pub-cache/bin:/Applications/Visual Studio
                        Code.app/Contents/Resources/app/bin:/Users/sebghatullah/FlutterDev/flutter/bin:/Users/sebghatullah/Library/Android/sdk/platfo
                        rm-tools:/Users/sebghatullah/FlutterDev/flutter/.pub-cache/bin
                        PATH_PREFIXES_EXCLUDED_FROM_HEADER_DEPENDENCIES = /usr/include /usr/local/include /System/Library/Frameworks
                        /System/Library/PrivateFrameworks /Applications/Xcode.app/Contents/Developer/Headers
                        /Applications/Xcode.app/Contents/Developer/SDKs /Applications/Xcode.app/Contents/Developer/Platforms
                        PBDEVELOPMENTPLIST_PATH = Runner.app/pbdevelopment.plist
                        PFE_FILE_C_DIALECTS = objective-c
                        PKGINFO_FILE_PATH =
                        /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build/Release-iphoneos/Runner.build/PkgInfo
                        PKGINFO_PATH = Runner.app/PkgInfo
                        PLATFORM_DEVELOPER_APPLICATIONS_DIR =
                        /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Applications
                        PLATFORM_DEVELOPER_BIN_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin
                        PLATFORM_DEVELOPER_LIBRARY_DIR =
                        /Applications/Xcode.app/Contents/PlugIns/Xcode3Core.ideplugin/Contents/SharedSupport/Developer/Library
                        PLATFORM_DEVELOPER_SDK_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs
                        PLATFORM_DEVELOPER_TOOLS_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Tools
                        PLATFORM_DEVELOPER_USR_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr
                        PLATFORM_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform
                        PLATFORM_DISPLAY_NAME = iOS
                        PLATFORM_NAME = iphoneos
                        PLATFORM_PREFERRED_ARCH = arm64
                        PLATFORM_PRODUCT_BUILD_VERSION = 18E182
                        PLIST_FILE_OUTPUT_FORMAT = binary
                        PLUGINS_FOLDER_PATH = Runner.app/PlugIns
                        PODS_BUILD_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios
                        PODS_CONFIGURATION_BUILD_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos
                        PODS_PODFILE_DIR_PATH = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/.
                        PODS_ROOT = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/Pods
                        PODS_XCFRAMEWORKS_BUILD_DIR =
                        /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/XCFrameworkIntermediates
                        PRECOMPS_INCLUDE_HEADERS_FROM_BUILT_PRODUCTS_DIR = YES
                        PRECOMP_DESTINATION_DIR =
                        /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build/Release-iphoneos/Runner.build/PrefixHeaders
                        PRESERVE_DEAD_CODE_INITS_AND_TERMS = NO
                        PRIVATE_HEADERS_FOLDER_PATH = Runner.app/PrivateHeaders
                        PRODUCT_BUNDLE_IDENTIFIER = com.vehiclehistory.app
                        PRODUCT_BUNDLE_PACKAGE_TYPE = APPL
                        PRODUCT_MODULE_NAME = Runner
                        PRODUCT_NAME = Runner
                        PRODUCT_SETTINGS_PATH = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/Runner/Info.plist
                        PRODUCT_TYPE = com.apple.product-type.application
                        PROFILING_CODE = NO
                        PROJECT = Runner
                        PROJECT_DERIVED_FILE_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build/DerivedSources
                        PROJECT_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios
                        PROJECT_FILE_PATH = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/Runner.xcodeproj
                        PROJECT_NAME = Runner
                        PROJECT_TEMP_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build
                        PROJECT_TEMP_ROOT = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios
                        PROVISIONING_PROFILE_REQUIRED = YES
                        PUBLIC_HEADERS_FOLDER_PATH = Runner.app/Headers
                        RECURSIVE_SEARCH_PATHS_FOLLOW_SYMLINKS = YES
                        REMOVE_CVS_FROM_RESOURCES = YES
                        REMOVE_GIT_FROM_RESOURCES = YES
                        REMOVE_HEADERS_FROM_EMBEDDED_BUNDLES = YES
                        REMOVE_HG_FROM_RESOURCES = YES
                        REMOVE_SVN_FROM_RESOURCES = YES
                        RESOURCE_RULES_REQUIRED = YES
                        REZ_COLLECTOR_DIR =
                        /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build/Release-iphoneos/Runner.build/ResourceManagerRes
                        ources
                        REZ_OBJECTS_DIR =
                        /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build/Release-iphoneos/Runner.build/ResourceManagerRes
                        ources/Objects
                        SCAN_ALL_SOURCE_FILES_FOR_INCLUDES = NO
                        SCRIPTS_FOLDER_PATH = Runner.app/Scripts
                        SDKROOT = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.5.sdk
                        SDK_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.5.sdk
                        SDK_DIR_iphoneos14_5 = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.5.sdk
                        SDK_NAME = iphoneos14.5
                        SDK_NAMES = iphoneos14.5
                        SDK_PRODUCT_BUILD_VERSION = 18E182
                        SDK_VERSION = 14.5
                        SDK_VERSION_ACTUAL = 140500
                        SDK_VERSION_MAJOR = 140000
                        SDK_VERSION_MINOR = 140500
                        SED = /usr/bin/sed
                        SEPARATE_STRIP = NO
                        SEPARATE_SYMBOL_EDIT = NO
                        SET_DIR_MODE_OWNER_GROUP = YES
                        SET_FILE_MODE_OWNER_GROUP = NO
                        SHALLOW_BUNDLE = YES
                        SHARED_DERIVED_FILE_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos/DerivedSources
                        SHARED_FRAMEWORKS_FOLDER_PATH = Runner.app/SharedFrameworks
                        SHARED_PRECOMPS_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/SharedPrecompiledHeaders
                        SHARED_SUPPORT_FOLDER_PATH = Runner.app/SharedSupport
                        SKIP_INSTALL = NO
                        SOURCE_ROOT = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios
                        SRCROOT = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios
                        STRINGS_FILE_INFOPLIST_RENAME = YES
                        STRINGS_FILE_OUTPUT_ENCODING = binary
                        STRIP_BITCODE_FROM_COPIED_FILES = YES
                        STRIP_INSTALLED_PRODUCT = YES
                        STRIP_STYLE = all
                        STRIP_SWIFT_SYMBOLS = YES
                        SUPPORTED_DEVICE_FAMILIES = 1,2
                        SUPPORTED_PLATFORMS = iphoneos
                        SUPPORTS_MACCATALYST = NO
                        SUPPORTS_TEXT_BASED_API = NO
                        SWIFT_COMPILATION_MODE = wholemodule
                        SWIFT_OBJC_BRIDGING_HEADER = Runner/Runner-Bridging-Header.h
                        SWIFT_OPTIMIZATION_LEVEL = -O
                        SWIFT_PLATFORM_TARGET_PREFIX = ios
                        SWIFT_VERSION = 5.0
                        SYMROOT = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios
                        SYSTEM_ADMIN_APPS_DIR = /Applications/Utilities
                        SYSTEM_APPS_DIR = /Applications
                        SYSTEM_CORE_SERVICES_DIR = /System/Library/CoreServices
                        SYSTEM_DEMOS_DIR = /Applications/Extras
                        SYSTEM_DEVELOPER_APPS_DIR = /Applications/Xcode.app/Contents/Developer/Applications
                        SYSTEM_DEVELOPER_BIN_DIR = /Applications/Xcode.app/Contents/Developer/usr/bin
                        SYSTEM_DEVELOPER_DEMOS_DIR = /Applications/Xcode.app/Contents/Developer/Applications/Utilities/Built Examples
                        SYSTEM_DEVELOPER_DIR = /Applications/Xcode.app/Contents/Developer
                        SYSTEM_DEVELOPER_DOC_DIR = /Applications/Xcode.app/Contents/Developer/ADC Reference Library
                        SYSTEM_DEVELOPER_GRAPHICS_TOOLS_DIR = /Applications/Xcode.app/Contents/Developer/Applications/Graphics Tools
                        SYSTEM_DEVELOPER_JAVA_TOOLS_DIR = /Applications/Xcode.app/Contents/Developer/Applications/Java Tools
                        SYSTEM_DEVELOPER_PERFORMANCE_TOOLS_DIR = /Applications/Xcode.app/Contents/Developer/Applications/Performance Tools
                        SYSTEM_DEVELOPER_RELEASENOTES_DIR = /Applications/Xcode.app/Contents/Developer/ADC Reference Library/releasenotes
                        SYSTEM_DEVELOPER_TOOLS = /Applications/Xcode.app/Contents/Developer/Tools
                        SYSTEM_DEVELOPER_TOOLS_DOC_DIR = /Applications/Xcode.app/Contents/Developer/ADC Reference
                        Library/documentation/DeveloperTools
                        SYSTEM_DEVELOPER_TOOLS_RELEASENOTES_DIR = /Applications/Xcode.app/Contents/Developer/ADC Reference
                        Library/releasenotes/DeveloperTools
                        SYSTEM_DEVELOPER_USR_DIR = /Applications/Xcode.app/Contents/Developer/usr
                        SYSTEM_DEVELOPER_UTILITIES_DIR = /Applications/Xcode.app/Contents/Developer/Applications/Utilities
                        SYSTEM_DEXT_INSTALL_PATH = /System/Library/DriverExtensions
                        SYSTEM_DOCUMENTATION_DIR = /Library/Documentation
                        SYSTEM_KEXT_INSTALL_PATH = /System/Library/Extensions
                        SYSTEM_LIBRARY_DIR = /System/Library
                        TAPI_VERIFY_MODE = ErrorsOnly
                        TARGETED_DEVICE_FAMILY = 1,2
                        TARGETNAME = Runner
                        TARGET_BUILD_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Release-iphoneos
                        TARGET_NAME = Runner
                        TARGET_TEMP_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build/Release-iphoneos/Runner.build
                        TEMP_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build/Release-iphoneos/Runner.build
                        TEMP_FILES_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build/Release-iphoneos/Runner.build
                        TEMP_FILE_DIR = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios/Runner.build/Release-iphoneos/Runner.build
                        TEMP_ROOT = /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios
                        TEST_FRAMEWORK_SEARCH_PATHS =
                        /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Library/Frameworks
                        /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.5.sdk/Developer/Library/Fram
                        eworks
                        TEST_LIBRARY_SEARCH_PATHS =  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/lib
                        TOOLCHAIN_DIR = /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain
                        TRACK_WIDGET_CREATION = true
                        TREAT_MISSING_BASELINES_AS_TEST_FAILURES = NO
                        TREE_SHAKE_ICONS = false
                        UID = 501
                        UNLOCALIZED_RESOURCES_FOLDER_PATH = Runner.app
                        UNSTRIPPED_PRODUCT = NO
                        USER = sebghatullah
                        USER_APPS_DIR = /Users/sebghatullah/Applications
                        USER_LIBRARY_DIR = /Users/sebghatullah/Library
                        USE_DYNAMIC_NO_PIC = YES
                        USE_HEADERMAP = YES
                        USE_HEADER_SYMLINKS = NO
                        USE_LLVM_TARGET_TRIPLES = YES
                        USE_LLVM_TARGET_TRIPLES_FOR_CLANG = YES
                        USE_LLVM_TARGET_TRIPLES_FOR_LD = YES
                        USE_LLVM_TARGET_TRIPLES_FOR_TAPI = YES
                        USE_RECURSIVE_SCRIPT_INPUTS_IN_SCRIPT_PHASES = YES
                        VALIDATE_PRODUCT = YES
                        VALIDATE_WORKSPACE = NO
                        VALID_ARCHS = arm64 arm64e armv7 armv7s
                        VERBOSE_PBXCP = NO
                        VERSIONING_SYSTEM = apple-generic
                        VERSIONPLIST_PATH = Runner.app/version.plist
                        VERSION_INFO_BUILDER = sebghatullah
                        VERSION_INFO_FILE = Runner_vers.c
                        VERSION_INFO_STRING = "@(#)PROGRAM:Runner  PROJECT:Runner-1"
                        WRAPPER_EXTENSION = app
                        WRAPPER_NAME = Runner.app
                        WRAPPER_SUFFIX = .app
                        WRAP_ASSET_PACKS_IN_SEPARATE_DIRECTORIES = NO
                        XCODE_APP_SUPPORT_DIR = /Applications/Xcode.app/Contents/Developer/Library/Xcode
                        XCODE_PRODUCT_BUILD_VERSION = 12E262
                        XCODE_VERSION_ACTUAL = 1250
                        XCODE_VERSION_MAJOR = 1200
                        XCODE_VERSION_MINOR = 1250
                        XPCSERVICES_FOLDER_PATH = Runner.app/XPCServices
                        YACC = yacc
                        arch = arm64
                        variant = normal

                    objc[15225]: Class AMSupportURLConnectionDelegate is implemented in both ?? (0x1efec8188) and ?? (0x11a7a42b8). One of the two
                    will be used. Which one is undefined.
                    objc[15225]: Class AMSupportURLSession is implemented in both ?? (0x1efec81d8) and ?? (0x11a7a4308). One of the two will be used.
                    Which one is undefined.
[  +78 ms] Building Runner.app for C7F55631-4C1B-4C0C-B815-9DB554D25C0F.
[  +29 ms] executing: xattr -r -d com.apple.FinderInfo /Users/sebghatullah/Projects/empirepixel/vhrmobileapp
[   +6 ms] executing: /usr/bin/arch -arm64e xcrun simctl spawn C7F55631-4C1B-4C0C-B815-9DB554D25C0F log stream --style json --predicate eventType =
logEvent AND processImagePath ENDSWITH "Runner" AND (senderImagePath ENDSWITH "/Flutter" OR senderImagePath ENDSWITH "/libswiftCore.dylib" OR
processImageUUID == senderImageUUID) AND NOT(eventMessage CONTAINS ": could not find icon for representation -> com.apple.") AND NOT(eventMessage
BEGINSWITH "assertion failed: ") AND NOT(eventMessage CONTAINS " libxpc.dylib ")
[ +819 ms] Failed to remove xattr com.apple.FinderInfo from /Users/sebghatullah/Projects/empirepixel/vhrmobileapp
[  +55 ms] Found plugin camera at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/camera-0.8.1+3/
[   +5 ms] Found plugin firebase_auth at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_auth-2.0.0/
[        ] Found plugin firebase_auth_web at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_auth_web-2.0.0/
[        ] Found plugin firebase_core at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_core-1.3.0/
[        ] Found plugin firebase_core_web at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_core_web-1.1.0/
[        ] Found plugin firebase_crashlytics at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_crashlytics-2.0.7/
[        ] Found plugin firebase_performance at
/Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_performance-0.7.0+6/
[   +1 ms] Found plugin flutter_facebook_auth at
/Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_facebook_auth-3.5.0/
[        ] Found plugin flutter_facebook_auth_web at
/Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_facebook_auth_web-2.6.0+2/
[        ] Found plugin flutter_plugin_android_lifecycle at
/Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_plugin_android_lifecycle-2.0.2/
[   +1 ms] Found plugin google_ml_kit at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/google_ml_kit-0.6.0/
[        ] Found plugin google_sign_in at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/google_sign_in-5.0.4/
[   +1 ms] Found plugin google_sign_in_web at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/google_sign_in_web-0.10.0/
[        ] Found plugin image_picker at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/image_picker-0.8.1+3/
[        ] Found plugin image_picker_for_web at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/image_picker_for_web-2.0.0/
[   +1 ms] Found plugin integration_test at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/integration_test-1.0.2+3/
[   +3 ms] Found plugin open_file at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/open_file-3.2.1/
[   +1 ms] Found plugin path_provider at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/path_provider-2.0.2/
[        ] Found plugin path_provider_linux at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/path_provider_linux-2.0.0/
[        ] Found plugin path_provider_macos at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/path_provider_macos-2.0.0/
[        ] Found plugin path_provider_windows at
/Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/path_provider_windows-2.0.1/
[   +2 ms] Found plugin permission_handler at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/permission_handler-8.1.2/
[   +2 ms] Found plugin shared_preferences at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/shared_preferences-2.0.6/
[   +1 ms] Found plugin shared_preferences_linux at
/Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/shared_preferences_linux-2.0.0/
[   +1 ms] Found plugin shared_preferences_macos at
/Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/shared_preferences_macos-2.0.0/
[        ] Found plugin shared_preferences_web at
/Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/shared_preferences_web-2.0.0/
[        ] Found plugin shared_preferences_windows at
/Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/shared_preferences_windows-2.0.0/
[   +1 ms] Found plugin stripe_payment at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/stripe_payment-1.1.4/
[   +1 ms] Found plugin url_launcher at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher-6.0.9/
[        ] Found plugin url_launcher_linux at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_linux-2.0.0/
[   +1 ms] Found plugin url_launcher_macos at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_macos-2.0.0/
[        ] Found plugin url_launcher_web at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_web-2.0.1/
[        ] Found plugin url_launcher_windows at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_windows-2.0.0/
[        ] Found plugin webview_flutter at /Users/sebghatullah/FlutterDev/flutter/.pub-cache/hosted/pub.dartlang.org/webview_flutter-2.0.9/
[  +29 ms] executing: /usr/bin/plutil -convert json -o - /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/Runner/Info.plist
[  +24 ms] Exit code 0 from: /usr/bin/plutil -convert json -o - /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/Runner/Info.plist
[        ]
{"CFBundleName":"DVH","UILaunchStoryboardName":"LaunchScreen","LSApplicationQueriesSchemes":["fbapi","fbapi20130214","fbapi20130410","fbapi20130702",
"fbapi20131010","fbapi20131219","fbapi20140410","fbapi20140116","fbapi20150313","fbapi20150629","fbapi20160328","fbauth","fb-messenger-share-api","fb
auth2","fbshareextension"],"CFBundleDevelopmentRegion":"$(DEVELOPMENT_LANGUAGE)","CFBundleVersion":"$(FLUTTER_BUILD_NUMBER)","UIStatusBarHidden":fals
e,"CFBundlePackageType":"APPL","UIMainStoryboardFile":"Main","CFBundleShortVersionString":"$(FLUTTER_BUILD_NAME)","FacebookAppID":"457040775639672","
NSAppTransportSecurity":{"NSAllowsLocalNetworking":true},"CFBundleInfoDictionaryVersion":"6.0","CFBundleExecutable":"$(EXECUTABLE_NAME)","UISupported
InterfaceOrientations~ipad":["UIInterfaceOrientationPortrait","UIInterfaceOrientationPortraitUpsideDown","UIInterfaceOrientationLandscapeLeft","UIInt
erfaceOrientationLandscapeRight"],"FacebookDisplayName":"DVH","CFBundleURLTypes":[{"CFBundleTypeRole":"Editor","CFBundleURLSchemes":["fb4570407756396
72","com.googleusercontent.apps.92679960742-r611amukirt264b9vgamtr4rhlg11rp9"]}],"CFBundleIdentifier":"$(PRODUCT_BUNDLE_IDENTIFIER)","UIViewControlle
rBasedStatusBarAppearance":false,"CFBundleSignature":"????","LSRequiresIPhoneOS":true,"UISupportedInterfaceOrientations":["UIInterfaceOrientationPort
rait","UIInterfaceOrientationLandscapeLeft","UIInterfaceOrientationLandscapeRight"],"FacebookClientToken":"DVH"}
[   +2 ms] executing: /usr/bin/plutil -convert json -o - /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/RunnerTests/Info.plist
[  +21 ms] Exit code 0 from: /usr/bin/plutil -convert json -o - /Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/RunnerTests/Info.plist
[        ]
{"CFBundleShortVersionString":"1.0","CFBundleIdentifier":"$(PRODUCT_BUNDLE_IDENTIFIER)","CFBundleName":"$(PRODUCT_NAME)","CFBundleInfoDictionaryVersi
on":"6.0","CFBundleDevelopmentRegion":"$(DEVELOPMENT_LANGUAGE)","CFBundleExecutable":"$(EXECUTABLE_NAME)","CFBundlePackageType":"$(PRODUCT_BUNDLE_PAC
KAGE_TYPE)","CFBundleVersion":"1"}
[   +2 ms] executing: mkfifo /var/folders/_9/n9ycv4t16r36_pjvjdsr0w4w0000gn/T/flutter_tools.sI0tNo/flutter_build_log_pipe.xW5Fpe/pipe_to_stdout
[  +19 ms] Exit code 0 from: mkfifo
/var/folders/_9/n9ycv4t16r36_pjvjdsr0w4w0000gn/T/flutter_tools.sI0tNo/flutter_build_log_pipe.xW5Fpe/pipe_to_stdout
[   +4 ms] Running Xcode build...
[   +1 ms] executing: [/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/ios/] /usr/bin/arch -arm64e xcrun xcodebuild -configuration Debug
VERBOSE_SCRIPT_LOGGING=YES -workspace Runner.xcworkspace -scheme Runner BUILD_DIR=/Users/sebghatullah/Projects/empirepixel/vhrmobileapp/build/ios
-sdk iphonesimulator
SCRIPT_OUTPUT_STREAM_FILE=/var/folders/_9/n9ycv4t16r36_pjvjdsr0w4w0000gn/T/flutter_tools.sI0tNo/flutter_build_log_pipe.xW5Fpe/pipe_to_stdout
FLUTTER_SUPPRESS_ANALYTICS=true COMPILER_INDEX_STORE_ENABLE=NO
[+10763 ms] Running Xcode build... (completed in 10.8s)
[   +7 ms]  └─Compiling, linking and signing...

I see below error from your log:
[  +20 ms] Error output from CocoaPods:
           ↳
[   +2 ms]     nil versions are discouraged and will be deprecated in Rubygems 4

               [!] CocoaPods did not set the base configuration of your project because your project already has a custom config set. In order for CocoaPods integration to work at all,
please
               either set the base configurations of the target `Runner` to `Target Support Files/Pods-Runner/Pods-Runner.profile.xcconfig` or include the `Target Support
               Files/Pods-Runner/Pods-Runner.profile.xcconfig` in your build configuration (`Flutter/Release.xcconfig`).

               [!] The `RunnerTests [Debug]` target overrides the `CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER` build setting defined in `Pods/Target Support
               Files/Pods-RunnerTests/Pods-RunnerTests.debug.xcconfig'. This can lead to problems with the CocoaPods installation

               [!] The `RunnerTests [Release]` target overrides the `CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER` build setting defined in `Pods/Target Support
               Files/Pods-RunnerTests/Pods-RunnerTests.release.xcconfig'. This can lead to problems with the CocoaPods installation

               [!] The `RunnerTests [Profile]` target overrides the `CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER` build setting defined in `Pods/Target Support
               Files/Pods-RunnerTests/Pods-RunnerTests.profile.xcconfig'. This can lead to problems with the CocoaPods installation

Were you getting this error before ? It may or may not be related but you can check out this issue and underlying solutions / comments and see if they help.
If not, then I see you've lot of 3rd party plugins being used which is fine, but we need to check if any of them after adding, is causing this behavior or not. Can you try to comment out all those (3rd party) plugins and try to run again and see if it works ? you may also try by commenting out one by one and check.

@darshankawar Thanks, let me try and will comment the result :)

@darshankawar I have a doubt, before when I was using all of these third party packages, it was working perfectly fine, without any freezing, I want to mention that I've tried to integrate integration testing for iOS as well, do you think it might be relevant?
I tried to go implement step by step by this tutorial [iOS Device Testing](https://github.com/flutter/flutter/tree/master/packages/integration_test#ios-device-testing]

@SebghatYusuf
Could be. Not sure. If you remove the integration test plugin and try again, does it succeed ?

@darshankawar
No, after I removed the integration test  it did not succeed.

@SebghatYusuf
Does the app crash, or just shows a blank screen while stuck at Running Xcode build... └─Compiling, linking and signing... ⣟ ?
It's a bit tough to identify just based on our conversation. Is there a way for you to verify it on a physical iphone ?
Can you also provide ios/podfile alongwith a minimal reproducible code sample ?

@darshankawar
The issue might be with these package:
  # firebase_core: ^1.3.0
  # firebase_auth: "^2.0.0"
  # google_sign_in: ^5.0.4
  # flutter_facebook_auth: ^3.5.0
  # firebase_crashlytics: ^2.0.7
  # firebase_performance: ^0.7.0+6

because after deleting the ios folder and creating a new project, & moving ios folder to my project, I was able to run the app, without any error and issue. I've tried many times and it's working.

now I can confirm the issue is not from the flutter engine itself.

Except google_sign_in plugin, rest are all 3rd party. So you may need to follow-up in respective dedicated repo.
Confirm if this can be closed or still need to be kept open based on your comment above.

@darshankawar
Yea I think it can be closed because the issue is not directly from the engine, and if I found any relevance I will re-open the issue.
Thanks

@darshankawar
Finally I think I've found the issue, the issue is with the custom script I have to upload dSYM files, in my Xcode
"${PODS_ROOT}/FirebaseCrashlytics/run"
"${PODS_ROOT}/FirebaseCrashlytics/upload-symbols" -gsp "${PROJECT_DIR}/Runner/GoogleService-Info.plist" -p ios "${DWARF_DSYM_FOLDER_PATH}/${DWARF_DSYM_FILE_NAME}"

This is used to upload the symbols to the firebase console, but I don't know why sometimes, there is an issue with uploading this files.
if someone knows anything relevant please share.
Thank you


Parsable return parameter type for History.prototype.getPreviousHash is incorrect

OpenUI5 version: 1.101.0
Browser/version (+device/version): n/a
Any other tested browsers/devices(OK/FAIL): n/a
URL (minimal example if possible): n/a
User/password (if required and possible - do not post any confidential information here): n/a
Steps to reproduce the problem:

View the documentation for History.prototype.getPreviousHash

What is the expected result?
{string|undefined}
What happens instead?
{string} or undefined: https://github.com/SAP/openui5/blob/f65b183be17c2b75be61b4f07f0caeec5b5431fd/src/sap.ui.core/src/sap/ui/core/routing/History.js#L165
Any other information? (attach screenshot if possible)
Text documentation is correct, however.
Information is correct History.prototype.getHistoryStateOffset: https://github.com/SAP/openui5/blob/f65b183be17c2b75be61b4f07f0caeec5b5431fd/src/sap.ui.core/src/sap/ui/core/routing/History.js#L114

#3517 ready to be merged

Fixed by #3517.


Can't reference a PCL project from an ASP.NET core project.

I have 3 projects:

My Xamarin mobile app (my UI)
My PCL (my Models)
My ASP.NET core (my Web api)

I would like to share my model project between my Xamarin UI and my ASP.NET core, so I can have a single project that holds the Models.
I can reference my PCL project from my Xamarin project without any problem, but when I try to reference the PCL from the asp.net core, the reference window does not give me any warning when I select the PCL project, but the reference does not gets added after a select and click okay.
Any hints on how to solve this issue?
thanks,
Gustavo.

It's currently not supported but will be in RC2.

Similar situation on my end except with just a UWP app and several ASP.NET Core WebAPI services - wanted PCLs between them with RC1.
In case someone was curious in the latest RC1 (1.0.0-rc1-update2) it's still not functional.

Just wanted to point out that I'm on RC2 and didn't get it to work yet.
Hints on how to get those scenarios to work are appreciated.

Yep, can confirm, no go with RC2.

@MihaMarkic I've actually gotten this working myself, in RC2... it was much-required for one of the projects I'm working on.
Are you getting any specific errors when trying to reference it? Can you elaborate on exactly what's happening with it?

Create a .net core libarary project A, a PCL (.net 4.5 + asp.net core 1.0) B.
When I try to reference B from A it says:
Microsoft Visual Studio
The following projects are not supported as references :

Arso.Weather has target frameworks that are incompatible with targets in current project A.

A:
.NETStandard,Version=v1.5

B:
.NETPortable,Version=v4.5,Profile=Profile75

Perhaps PCLs can be referenced from only asp.net core projects, but not from .net core console/libraries?

Just a quick update: it doesn't work for me with 1.0 RTM either. @rdefreitas if you could elaborate how you did it (or answer my SO question directly) I would be grateful.
@MihaMarkic doesn't seem to be a console app issue since I can't get it to work with asp.net either.

Does not work with Update3 + 1.0.0 preview2 tooling on 1.0.0
What is the recommended way to use dll's friendly with NetStandard1.0 ASP sites and 4.6.x framework code?  Just want to share the dll.  It seems this has been broken for a release now and does not work as described here: https://github.com/dotnet/corefx/blob/master/Documentation/architecture/net-platform-standard.md

What's the current status? I'm experiencing the same issue trying to reference PCL from aspnet core application. Is there another way to share code between aspnet core and xamarin application?

@prilutskiy
I got around the problem until the issue is fixed by making the referenced project .netcore instead of PCL. But you need to reference the dll itself instead of the project. And you'll have to build the referenced project when you make changes.

@kewur Thanks for the workaround. But what about Xamarin application? Won't there be troubles with referencing core assembly?

I was able to run it on the emulator, never tried on the device though.

@kewur I have just created .NET Core .dll assembly and referenced it from both aspnet and Xamarin.Android applications. I haven't run it, but build succeeded. Maybe that's workaround I've been looking for. Anyway, thanks for your help.

I am sorry to say that I have been trying to get this to work and "no luck". I have projects I need to share between ASP.Net Core 1.0 RTM and Xamarin and it is trouble all the way.
Problem #1: I cannot reference the PCL project from the .net core project. I added the compat layer and the "imports" and the reference dialog box works, but the solution does not compile. It seems like the compiler does not "see" the PCL project. It cannot resolve using statements or classes that live in the PCL project.
Problem #2: If I convert the PCL project to Standard Library, then Xamarin Forms PCL has problems saying that the v4.5 (Xam PCL) is not compatible with the v5.0 (std lib). I am lost...
Problem #3: If I try to convert the entire Xamarin project to Standard Library then the problem is that many dependencies are not ported to .Net Core / Std Libs yet. For example, many of the Xamarin libs and even MvvmLight. I talked to both, James Montemagno and Laurent Buignion, and both have confirmed that there is clear a plan to port, but we are not there yet. As Montemagno said, "Standard Libraries are still new".
Anyhow, a real mess... I still wonder if it is a tech. problem, or a tooling problem... I don't know where to log issues or give input... ;)
Thanks...

That's what I'm having right now.

I've logged into OS X and from Xamarin Studio created Portable Library to reference it from Xamarin iOS. Obviously, build succeeded.
After that I've logged into Windows, opened the same solution in Visual Studio (2015) and found out that Portable library I've created from Xamarin is not actually a PCL, but a library targeting .NET Standart.
Then I've tried to reference this library from ASP.NET Core project. Reference was added, build succeeded BUT: I was unable to see any namespaces/types from the referenced library, Visual Studio underscored all external types and painted them in red. This is mindblowing, I didn't expect such flaw from Microsoft.

But there's more.
I've made a research and it turned out that that's not a problem with Visual Studio... It's all about ReSharper I've been using: the syntax analyzer wasn't smart enough to see referenced types.
The solution is to update ReSharper tool to 2016.2 EAP (Early Access Program) 11. As JetBrains team says this issue was resolved in EAP 2.
So, to share code base between ASP.NET Core and Xamarin we need both projects reference .NET Standart targeted library. And use ReSharper 2016.2 EAP 2 or higher or not to use ReSharper at all.
Hope somebody will find this useful.

@prilutskiy It seems like we are in rather similar situations. That is good in the terms of consistency.
BTW, is is thread closed ? Is anyone from MS reading this? Should we be posting somewehere elese ?

@cspaniard I'm not sure. Let's try reaching someone.
@glennc Hi Glenn, what do you think on this point?

@prilutskiy The reason I think It might be closed is this:

So I wonder if were are "screaming" in the desert... hahahaha
cheers

This thread is still opened.
@davidfowl any update on it ?
thanks,
Gustavo.

It would be helpful if we could all work off the same sample projects. I can reproduce some of the many problems described in this thread. The move back to msbuild should make most of this work more seamlessly than today.

.NET Core applications can reference .NET Standard class libraries (csproj based and non csproj based)
.NET Core applications can reference .NET Standard packages and PCL packages (with imports). It seems as though PCL projects are broken in the IDE, the compiler works fine.
You need the latest NuGet and Xamarin tooling to use .NET Standard in your projects.
.NET Standard != .NET Core. You can use .NET Standard projects and packages with .NET Framework, Xamarin and .NET Core.

/cc @abpiskunov

@davidfowl I agree with all your points.
Nuget: <IP_ADDRESS>4  (is this the latest ?, VS says nothing about a newer update available)
Xamarin: <IP_ADDRESS> (just installed 2 days ago)
My solution still does not compile from within VS. All I am doing is a .Net Core console app with imports trying to reference a PCL.
Any ideas ?  I am missing something ? Can we confirm is a VS/Tooling issue ?

My solution still does not compile from within VS. All I am doing is a .Net Core console app with imports trying to reference a PCL.

I specifically called this out saying .NET Core applications don't work with PCL projects in the IDE. Intellisense isn't working. That's likely a bug because packages work fine.
Convert the PCL to a .NET Standard project.

@davidfowl I know, I was trying to support your point. I was with you... I was trying to say you were right.
I cannot convert the PCL to a .NET Standard project because it does not work with Xamarin if converted. Some kind of v4.5 vs v5.0 collision I don't understand very well. I can reproduce it if you want.
I really appreciate all your help with this.

I cannot convert the PCL to a .NET Standard project because it does not work with Xamarin if converted. Some kind of v4.5 vs v5.0 collision I don't understand very well. I can reproduce it if you want.

Can you clarify this point? What fails? Do you have a minimal project you can push to github to show the issue?

@davidfowl I will work on it and I will put it together... I can get it done by tomorrow...

@davidfowl Hi... uploaded the minimal project to github that shows the issue. A Xamarin Forms PCL project trying to reference a Standard Library project.
This is the issue itself:
The primary reference "C:\zzzzJunk\MyTestApp\TestLib\bin\Debug\TestLib.dll" could not be resolved because it was built against the ".NETPortable,Version=v5.0" framework. This is a higher version than the currently targeted framework ".NETPortable,Version=v4.5,Profile=Profile111".
Here is the github link:
https://github.com/cspaniard/MyTestApp
Once gain... thank you for looking into it.

Hey @cspaniard,
I was able to reference the Standard Library from the Xamarin PCL, the trick was to unreference all nugget packages, retarget to Standard Library and then re-add the nuget references.
The problem I have is that after I target my Xamarin PCL to Standard Library, my Xamarin projects iOS and Android still work fine, but my Xamarin UWP does not accept the Xamarin PCL reference anymore.
The repro is easy, just target a Xamarin PCL to standard library and try to add the reference on the xamarin uwp project.
Any thoughts on that @davidfowl
thanks a lot,
Gustavo.

I was able to reference the Standard Library from the Xamarin PCL, the trick was to unreference all nugget packages, retarget to Standard Library and then re-add the nuget references.

What is a Xamarin PCL?

The problem I have is that after I target my Xamarin PCL to Standard Library, my Xamarin projects iOS and Android still work fine, but my Xamarin UWP does not accept the Xamarin PCL reference anymore.

What is a Xamarin UWP project? Is it just a UWP project?
Are all projects using project.json or are some using packages.config. Are these projects used in both Xamarin Studio and in Visual Studio or just visual studio. AFAIK you can't mix project.json and packages.config.
/cc @emgarten

Hi @gugavaro,
If I understand your process correctly, you converted your Xamarin PCL project to Standard Library. Is that correct ?
If that is the case, I run into all sorts of trouble since a lot of the libs/pkgs I use are not converted to Std Libs yet. I contacted James Montemagno about this and he mentioned that the commitment is to move to the Std Libs, but since they are kind of new, they are not there yet. Lots of work ;)

Hi @davidfowl,
Xamarin PCL is the PCL version of a Xamarin project. Today Xamarin can be used in 2 modes:

Shared Project
PCL based Project

I am using the PCL version of Xamarin Forms.
BTW, where you able to clone the project OK ?
TIA ;)

Xamarin PCL is a normal PCL. Nothing special, same goes for Xamarin UWP.

Ok, I got it to work across all the platforms, have not tested yet running code, but at least it is compiling.
Would like someone else to double check it before we close the issue.
Here are the Steps:
1 - Created a PCL
2 - Target the PCL project .Net Standard
2.1 - If it is a Xamarin PCL, make sure to remove the nugget references, update the target and then re-add the nugget references.
3 - On the .Net Standard version, select 1.2, this will make your PCL be compatible with Asp.Net Core, Console Core and all Xamarin projects (iOS, Android and Windows UWP and 8.1)
3.1 - If you dont need windows phone 8.1 and windows 8.1, you can bump the target version to 1.4, otherwise 1.2 is the only version compatible cross all platforms.
If you select any higher version of the .Net Standard (i.e.: 1.3 and above) the UWP and Windows projects will not be able to reference the PCL, it seems they are only compatible with .Net Standard up to 1.2 version.
The problem is that I am seeing a lot of nugget packages already targeting higher versions, for example here:
Package Microsoft.IdentityModel.Clients.ActiveDirectory 3.13.1 is not compatible with netstandard1.2 (.NETStandard,Version=v1.2). Package Microsoft.IdentityModel.Clients.ActiveDirectory 3.13.1 supports:

netstandard1.4 (.NETStandard,Version=v1.4)

There is a table with the compatibility support between platforms and versions:
https://github.com/dotnet/corefx/blob/master/Documentation/architecture/net-platform-standard.md
This table helped me understand the issues.
Could one of your guys verify it and I will close this issue, @cspaniard @MihaMarkic @prilutskiy @jcapellman ?
thanks a lot everyone here.
Gustavo.

Hi @gugavaro,
I have not being able to replicate your example. However, it might be my fault. From my perspective, I am trying to find an equilibrium between 2 issues here.

Calling a PCL from Net Core (Asp or Console, same problem)
Calling a Standard Library from Xamarin Forms PCL

After a closer reading of your directions, I am not sure which one (if any) you are trying to work around. Both need attention and resolution.

PCL from Net Core: seems to be a tooling problem from within VS. As @davidfowl pointed out, and later confirmed, it works from the CLI.
 BTW in this context I can only reference the Std Lib if it is targetting v1.1. Anything higher tells me it can't be referenced by the "parent" project. However, with v1.1 I still get the errror.

The primary reference "C:\Movil\Gustavo\TestLib1\bin\Debug\TestLib1.dll" could not be resolved because it was built against the ".NETPortable,Version=v5.0" framework. This is a higher version than the currently targeted framework ".NETPortable,Version=v4.5,Profile=Profile7".
As you can see I changed to Profile7, but with Profile111, it doesn't work either.
Right now the tooling issue is in MS' hands and I would like to continue working with all of you until we can identify the 2nd  issue.
Can you explain what is your starting point and where you are trying to get ? How were you able to point to StdLib v1.3 and still add the reference from within VS ?
Let´s stay in touch people ;)
Cheers,
David

Hi @cspaniard
I am able to call a PCL from asp.net core with no problem and even the tooling is working fine for me.
For the second issue, I see you are using Xamarin Forms and if you look on the nugget Xamarin forms info it does not support standard library, however it does support a normal .net PCL, in this case why you need to have a netstandard pcl ?
See if those steps help you:

Create a PCL => C#, Class Library (Portable for iOS, ...)
After create, I edit the project target and removed both Silverlight, Windows Phone8.1 (you dont need to retarget to to netstandard)
Create an ASP.NET Core
Add the PCL reference on your ASP.NET core

let me know if so far it works for you.
If now you are also working with Xamarin Forms.

Create a new Xamarin Forms Project.
On The Portable project, remove the Xamarin Forms nugget reference.
Edit the project Targets to be exact the same as your PCL, in this case remove Silverlight and Windows Phone 8.1
Add the Xamarin Forms nugget reference back.
Add the PCL reference to your Xamarin Forms project.

it should work.
let me know.
Thanks,
Gustavo.

Hi @gugavaro
You are "the man"... Kudos to you... it works just like you said it would...
Just let me write a few notes about your comments/questions and confirm your points:

I am able to call a PCL from asp.net core with no problem and even the tooling is working fine for me.

Samething here once I followed your directions... The tooling is still broken and autocompletion is not there. However, it does compile from within VS.

For the second issue, I see you are using Xamarin Forms and if you look on the nugget Xamarin forms info it does not support standard library, however it does support a normal .net PCL

The latest Xamarin is supposed to be able to reference Standard Libs. Actually James Montemagno wrote a blog about it. I sent him a tweet about migrating to StandardLibs and he mentioned that the idea is to get there, but there are a lot of libs to port.

why you need to have a netstandard pcl ?

I don't really, as long as I can run my code in all the different environments.

As you can see, I need my libs to run on Asp.Net Core, Desktop WPF, Console and Xamarin. Now, with your directions, I can.
I changed all my PCL projects (including Xamarin) to follow your directions and now they compile and work great.
All I can say is thank you...
Cheers,
David

Hi @cspaniard,
I am glad you got it working.

Try to update your VS with the latest tools, my vs was also broken, but it got fixed after some updates.

For your second question. Xamarin does support netStandard, however Xamarin Forms is still not netStandard compatible, so be careful to not make a confusion here. you can reference your netstandard from your iOS or Droid projects with no problem, the issue is to reference the netstandard pcl in the same project that references xamarin forms.

Let me know if you have any other question and I will be happy to try to help you.
take care,
Gustavo.

So if I understand correctly, it compiles and runs but we are missing IntelliSense?
ben


bug fix

codecov bug for comparing file changes

Codecov Report

Merging #7 (d763b58) into master (48532f7) will increase coverage by 70.15%.
The diff coverage is n/a.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Now The code coverage is working correctly to show file changes.


Better integration with Git

Problem
One of the common problems when generating code is the fear of removing business logic when regenerating code in an existing project. To avoid this, we introduced the -n, --no-overwrite option but this doesn't prevent people from forgetting about it or forgetting about a path they don't want to overwrite, and accidentally deleting code they can't recover.
Solution
Check if the directory is a git repo. If that's the case, the generator should not allow you to regenerate the project if there are unstaged changes in the working tree. We can also provide a -f, --force option to eliminate this restriction.
I'm also thinking that, when the project is not a git repo, it shouldn't allow you to generate code in a directory that already contains files. Again, this restriction can be removed using -f, --force.

That would be a breaking change right? The default behaviour of the generator would change

Yep but it doesn't really matter yet as we're on 0.x versions. Breaking changes must be expected.

Feature implemented and soon will be released.
From now on, when you generate files:

To non-empty directory, you get an error with information that you can lose some of your work as it can get overwritten.
To a directory in a git repository, you get an error that you might lose some of your work but only in case you have some unstaged changes

We also introduced new flag in CLI called --force-write (it is also supported on a library level) and it will allow you to ignore rules provided by this feature
@handrews I saw you like the idea for having such a feature, so just letting you know it is done