Add Merge Account to NewExpensify

DESIGN DOC ➡
Proposal
Tasks

[x] Post Proposal (full Problem/Solution statement) in #whatsnext
[x] Wait at least one full business day, and until the post has a majority (2/3) of positive reactions (👍)
[x] Paste Proposal in the space above with a link to the Slack thread
[x] Email<EMAIL_ADDRESS>and paste in the Proposal
[x] Host a pre-design meeting (example) in an appropriate slack channel to discuss any necessary details in public before filling out the High-level of proposed solution section.
[x] Fill out the High-level overview of the problem, Timeline, Terminology, and High-level of proposed solution sections of the Design Doc
[x] Email<EMAIL_ADDRESS>(continue the same email chain as before - your last message should be the WN Proposal) with the link to your Design Doc containing your high-level problem and solution
[x] Add the DesignDocReview label to get the High-level overview of the problem and High-level of proposed solution section reviewed
[x] Respond to any questions or concerns and bring up blockers in Slack to get a consensus if necessary
[x] Confirm that the doc has the minimum necessary number of reviews before proceeding
[x] Host another pre-design meeting in the appropriate slack channel to ask for engineering feedback on the technical solution.
[x] Fill out the Detailed implementation of the solution and related sections.
[x] Re-add the DesignDocReview label to this issue
[ ] Respond to any questions or concerns and bring up blockers in Slack to get consensus if necessary
[ ] Confirm that the doc has the minimum necessary number of reviews before proceeding
[ ] Email<EMAIL_ADDRESS>one last time to let them know the Design Doc is moving into the implementation phase
[ ] Implement the changes
[ ] Add regression tests so that QA can test your feature with every deploy (instructions)
[ ] Send out a follow up email to<EMAIL_ADDRESS>once everything has been implemented and do a Project Wrap-Up retrospective that provides:

Summary of what we accomplished with this project
What went well?
What could we have done better?
What did we learn?

Issue OwnerCurrent Issue Owner: @marcaaron

Need to improve this but startign with the P/S
Proposal: add the remaining account settings to new dot, Part 1: Merge Account (Part 2: Device Management TBC)
Problem:
When users accidentally create personal accounts while their company is using Expensify, they face several issues. They must either:

Re-scan their receipts using their company account.
Manually create expenses within their company account.
Accept that they won’t be reimbursed by their employer.

Generally, users can’t share reports directly with their company in-app, and managing two accounts can be confusing. Users might also unknowingly create expenses that don't align with company policies.
Solution:
Rebuild the ability to "Merge Accounts" in NewExpensify. This feature allows users to easily merge their personal and company accounts on Expensify.
This will improve the transfer from individual expense dat to company-created accounts.

Pre-design on merging accounts for workspace feed/card conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1723841346915409

This is a bit mean, I haven't even done it yet 🥲

https://github.com/search?q=org:Expensify+"merge+account"&type=Code

https://github.com/search?q=org:Expensify+"merge+account"&type=Code
https://github.com/Expensify/Web-Expensify/blob/main/script/bwm/HandleBackgroundTasksOnMergeAccount.php
https://github.com/Expensify/Auth/blob/main/auth/command/MergeAccount.cpp

Not sure we need @dannymcclain here yet so will remove this from clogging up his K2.

@twisterdotcom and I considered getting the pre-design out today or tomorrow but I realised we need to email strat@ prior, so done that and then can get the pre-design in flight!

Back from some OOO. @zanyrenney has been predesigning in a canvas in my absence.

pre-design is posted! https://expensify.slack.com/archives/C06ML6X0W9L/p1725276863731789

Going to get some mock help due to the time pressure on this!

reassigning @dannymcclain

Figma file for reference: https://www.figma.com/design/bHql8diuUEo4HktqZULhLY/Merge-Accounts?node-id=4-4221&node-type=CANVAS&t=d52rTOi706bLXkWx-0

Sync with Danny to go over this today cc @dannymcclain
Then hoping to share a visual pre-d and then move ahead with HL.

User journeys:
Success:
LHN > Avatar > Security > Merge Accounts > RHP (same as close account)

Failure flow 1:
Incorrect Magic Link Code (existing pattern)

Failure flow 2:
SAML is set as required on the Domain being merged into
LHN > Avatar > Security > Merge Accounts > RHP (same as close account) > Magic Code > Error message.
"SAML....." [placeholder] need to ask James for copy.

How to handle the aftermath?

Yo @zanyrenney I got some stuff here for you to check out.
Let me know if you want me to post in the predesign threads in Slack for feedback or if you want to handle that!
For the "confirmation" (it worked or it didn't), I think we can handle it with either an RHP like we do for upgrades, or a confirmation modal which we use for tons of stuff. Not sure which I think is more appropriate, so we may just want to get feedback on that during the predesign.

Hey @dannymcclain these are great, thanks so much. I want to add a few other things / Qs to the pre-design so I will post them today and ofc tag you!

I got held up on customer hiring / syncs, and wanted to check a few things with Ted too. So I will post these tomorrow!

conversations ongoing, pre-design was posted here - https://expensify.slack.com/archives/C06ML6X0W9L/p1726066356389699

will move to doc soon!

Updates to mocks 1:

[ ] Create the corresponding "Domain admin" view where they are receiving a message via concierge that says<EMAIL_ADDRESS>has attempted to merge<EMAIL_ADDRESS>into their primary account. As Expensify.com has SAML configured, you'll need to verify this request" Approve | Deny - @dannymcclain
[ ] Add concierge message to user with outcome of the attempted merge - @dannymcclain
[ ] Success: "Your domain admin approved your merge request<EMAIL_ADDRESS>has been merged into<EMAIL_ADDRESS>(question for James: should this say [domainadminsemail] instead of just "domain admin" - user might not know what domain admin is?)
[ ] Failure: "Your domain admin has denied your merge request<EMAIL_ADDRESS>remains a separate Expensify account" (question for James: should this say [domainadminsemail] instead of just "domain admin" - user might not know what domain admin is?)

Updates to mocks 2:

[ ] Get James to approve the copy on these initial mobile mocks for all the flows

Updates to mocks 3:

[ ] Ask Danny to please create all the mocks in web as well as mob.

Message to domain admin from concierge > message reads [approve/deny merge request] > approve deny pill ?

Ask Ted in doc review

for the flows where we are saying you can't merge into the account, for smart scanner and invoicing, should we have the logout link in the error message?

I am still working through copy suggestions in the mocks here. I think we're pretty close but @zanyrenney @dannymcclain feel free to bring anything out that looks weird or you have questions on, into Slack!

will dive into what's in the doc tomorrow and answer whatever pings are waiting on me

One last comment thread in the Figma mocks for @zanyrenney. Should be good otherwise!

Thank you so much @jamesdeanexpensify

Will dive into the doc today and post any questions I have there.

ty @twisterdotcom

@bondydaa is diving into the API section today.

started spelunking in the code and started on the API section. kicked off a question to slack that i'm not sure about but i'll keep plugging away on it to have it ready for monday/tuesday sending.

discussion ongoing in this thread to make sure I cover/address API/Onyx changes required for the HL, still hoping we can get this sent out for review by EOD today though might end up being tomorrow since Zany may be offline by the time I finish my updates.

Removing star from myself - @bondydaa comment above should clear the overdue as the co-lead!

okay think data storage / api changes is all set for now, at least I've tried to document where I wasn't sure and can hopefully get the feedback from the team then to get to the right spot. I resolved the rest of the outstanding items i had open and left some suggestions for @zanyrenney on that last remaining question you'd tagged me in.
I think we're in a good spot to send it out once you review those suggestions.

woooo!

shipped!

I have read and reviewed this Design Doc!

I have read and reviewed this Design Doc!

I have read and reviewed this Design Doc!

I have read and reviewed this Design Doc!

I have read and reviewed this Design Doc!

doc is in review and comments are being addressed

Same as Friday. It's in review.

I have read and reviewed this Design Doc!

Not overdue. Zany and I are working on a few new mocks for the admin messages/actions.

I believe most comments are addressed, there is one outstanding from Flo that I will address next week but should be looking good to start on detailed section next week once that is done.

Nice @bondydaa sounds good. I'm going to amend the mock ups to show the group chat vs concierge chat for approving the merge request for a SAML domain.

sorry IFR has not been my friend so far this week, going to devote a good chunk of tomorrow to the doc.

Hey @bondydaa how did that day go devoted to the doc? Do you think we'll be able to finish it in the next few days?

Starred @bondydaa as the issue owner for now!

had to switch focus to https://github.com/Expensify/Expensify/issues/419777 but have PR in review there so should be able to get back onto this doc tomorrow 🙏
I started searching for a c+ to help me with the detailed portion for new dot changes and I plan to spin up a engineering predesign to get through the remaining outstanding comments on the doc and make sure I havent missed something.

started working on a more technical pre-design that i'll get posted tomorrow to hopefully get the rest of the remaining comments put to be so we can move on to detailed.

okay think I have the predesign drafted up now. I'll send it out first thing monday so it doesn't get burried over the weekend.

Awesome, nice thinking re the timing @bondydaa

predesigned started here https://expensify.slack.com/archives/C03TQ48KC/p1729525076634409

It looks like the pre-design has largely wound down now, when can we expect the doc to be finished and sent out, @bondydaa ?

Thanks for the update!

spun up this issue for sibtain https://github.com/Expensify/App/issues/51822
I got the predesign bits back into the HL and will start moving onto the detailed portion to scope out all of the required backend changes.
One idea that I'll first be looking into was brought up here https://expensify.slack.com/archives/C03TQ48KC/p1729532966998279?thread_ts=1729525103.903289&cid=C03TQ48KC that could make our lives easier in getting the data back out to all the various clients by forcing them to reconnect via some type of trigger based on the lastUpdateID in onxy updates.
This would be more ideal than the route of trying to queue up individual updates within onyx because there is just so much data that needs to be shared out.
There is already a way this works for clients that are actively subscribed to pusher but our need is for clients not active who would be fetching onyxUpdates.
From ioni these are 2 potential areas to investigate first

I have read and reviewed this Design Doc!

Waiting on another engineer to pick this up. It's being called out in #retain but I am going to approach some others via DM EOW if we still don't have anyone volunteer.

I don't have a critical issue assigned at the moment so I will jump in here and try to pick things up where Bondy left off.

I have left a bunch of questions on the doc. Maybe it would be better to pull out into a predesign to get faster movement on all of it though. I think this is the main stuff that needs to be resolved:

[ ] What if any changes are we making to user's data when merging? There was a discussion about Cards. Some things about Group Chats (though I think they already work as intended). We should clarify the scope of the changes and what kind of compatibility we are targeting or if the way things work today is acceptable and this is just mostly a UI migration.

[ ] I had a few notes about the flows. Most importantly there is some place where we currently requiring a magic code when a domain admin approves a request to merge account for a samlRequired user. We would not be requiring it anymore with the current proposal and unsure if this creates a security risk or not (and I assume we added this for a good reason).

[ ] There's some dangling conversation about how to update all the clients Onyx data when someone merges. Sounds like we did not exactly land on a satisfying or clear proposal for how to handle this yet. I think we should decide as part of the high level?

Once that stuff is resolved I think the Detailed design can get unblocked.

I posted a few thoughts about the 3rd bullet point there here in Slack. It sounds like we kind of made some progress on a solution, but not really clear to me what path was decided on and would like to consider an alternative that would allow us to greatly reduce the scope of this project.

We also talked a bit about the first bullet in this thread with @blimpich since we thought there might be overlap. I'm kind of wary of making this project a "fix all the things related to merging accounts" and instead would like to clarify what exactly doesn't work about account merging today and be a bit more strategic how we identify and tackle whatever those individual problems might be.

Conversations ongoing in Slack.

I need to get back to the doc and a few questions @marcaaron had, last week was not viable to do this but should have more time this week.

Still trying to get some more thoughts on:

What if any changes are we making to user's data when merging?

Then we should be ready to move forward here.

Going to bring a conversation to slack about ab few things on this, drafting it up!

I think we have resolved most of the high level questions. Aiming to have the detailed design part shipped by EOW.

Made a bunch of edits and pinged @allroundexperts that we should be good to finish the front end sections now.

We are getting closer here. Still discussing what to do about the SAML required merge request notification edge case in this thread.
@allroundexperts we might need to rework one or two things depending on the outcome of that conversation.

I will update the HL tomorrow too.

Spanish translations have been added and Marc was finishing the manual QA.

Finished the manual QA section and cleaned up the doc. It's out for final review now!

I have read and reviewed this Design Doc!

I have read and reviewed this Design Doc!

I have read and reviewed this Design Doc!

Detailed in review now!
@tylerkaraszewski @zsgreenwald @danielrvidal @AndrewGable if there's any chance of finishing your reviews sooner vs later that would be great. It's a pretty short one and I'd like to get all the GitHubs created (and possibly implement a few things) over the holiday. Or at least have things ready to pass off to someone else since I'm going on leave around EOM.

I have read and reviewed this Design Doc!

🤦🏼 I obviously did not mean to close. reopened and added back to the right section of the board.

I have read and reviewed this Design Doc!

I have read and reviewed this Design Doc!

This is moving into implementation. @zanyrenney Here are the GH issues:
https://github.com/Expensify/Expensify/issues/455378
https://github.com/Expensify/Expensify/issues/455380
https://github.com/Expensify/Expensify/issues/455382
https://github.com/Expensify/Expensify/issues/455383
https://github.com/Expensify/App/issues/54443

Looking for someone to take this over. I could start on the backend PRs, but unsure if I will be able to finish them so might make sense to hand off at this point.

Looking for someone to take this over. I could start on the backend PRs, but unsure if I will be able to finish them so might make sense to hand off at this point.

Hey I finally took a look at the high level. I can take over once you're out!

Update thread here


Countdown date passed

The countdown date has passed, leading to the countdown (default theme), to say 0 days, 0 hours, 0 minutes, 0 seconds. The default letter is also out of date. Maybe change the default dates/letter reflect the CRA expiry date?

I would like to remove the battleforthenetwidget from two of my websites and can't figure out how to do it.  They are leathersmtihe.com and penderconservancy.org

battleforthenetwidget was supposed to time-out (and may have been updated) but I would like now to remove it.

Thanks, kenmickles.  Sandvox (Mac program) doesn't allow me to edit (or even see) HTML.  However, the website builder uses an "inspector", and a "sidebar" which listed an unfamiliar "HTML" comment along with the graphic and text additions I have made.  I removed that comment (which said only that it was an HTML insert) and the battleforthenet disappeared!  However, leathersmithe.com does NOT have that same nor a similar one, so I'm still stuck with it on that site.  I think I'll need an HTML editor but am unsure of how to use that with, or separately from, the Sandvox program, since I'll have to provide info to edit my site.

@leathersmithe Cool. Glad you got the one site sorted out. I'm not familiar with Sandvox, but I see in source code code for leathersmithe.com that the widget script is sitting above the "Discoveries of sophisticated implements such as leather-burnishing tools..." text, if that helps.
In Safari, Chrome, and FireFox on Mac you can press command+option+u to view the source code of your website. Then you can press command+f to search that code for https://widget.battleforthenet.com/widget.js. That might help you track down the script in Sandvox.

Useful knowledge!  I found it on line 664.  Now, if I could figure out some way to edit the HTML I could delete that line.  I think I need an HTML editor that will allow me to make changes directly to my site.

Useful knowledge!  I found it on line 664.  Now, if I could figure out some way to edit the HTML I could delete that line.  I think I need an HTML editor that will allow me to make changes directly to my site.

I think I figured out how to do it but must wait until tomorrow to try: it popped up only ONCE a day, so I can't test it until then.

Hot-damn, kenmickles, I seem to have done it!  Thanks, I owe my success to you.

@leathersmithe Great news! Thanks for using the widget.


GPU validation errors in mobile renderer if limited subpasses are used.

Godot version
4.1.dev b6ba664830d9ff1bd7eeb72294fa1e7a3827e42e
System information
Windows 10
Issue description
When running a project on the mobile renderer and gpu-validation enabled, get error spam:
drivers\vulkan\vulkan_context.cpp:267 - VALIDATION - Message Id Number: -1495270302 | Message Id Name: VUID-VkRenderPassCreateInfo2-pAttachments-02522
  	Validation Error: [ VUID-VkRenderPassCreateInfo2-pAttachments-02522 ] Object 0: handle = 0x2116557b130, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xa6dffc62 | vkCreateRenderPass2(): Cannot clear attachment 2 with invalid first layout VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL. The Vulkan spec states: For any member of pAttachments with a loadOp equal to VK_ATTACHMENT_LOAD_OP_CLEAR, the first use of that attachment must not specify a layout equal to VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL, VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL, or VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/windows/1.3-extensions/vkspec.html#VUID-VkRenderPassCreateInfo2-pAttachments-02522)
  	Objects - 1
  		Object[0] - VK_OBJECT_TYPE_DEVICE, Handle<PHONE_NUMBER>392
  drivers\vulkan\vulkan_context.cpp:267 - VALIDATION - Message Id Number: -182251971 | Message Id Name: VUID-VkSubpassDescription2-loadOp-03064
  	Validation Error: [ VUID-VkSubpassDescription2-loadOp-03064 ] Object 0: handle = 0x2116557b130, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xf5230e3d | vkCreateRenderPass2KHR(): attachment 2 is first used as an input attachment in pSubpasses[3].pInputAttachments[0] with loadOp set to VK_ATTACHMENT_LOAD_OP_CLEAR. The Vulkan spec states: If the first use of an attachment in this render pass is as an input attachment, and the attachment is not also used as a color or depth/stencil attachment in the same subpass, then loadOp must not be VK_ATTACHMENT_LOAD_OP_CLEAR (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/windows/1.3-extensions/vkspec.html#VUID-VkSubpassDescription2-loadOp-03064)

Steps to reproduce
Create a project with the mobile renderer and enable GPU validation.
Minimal reproduction project
n/a

I ran into this issue while evaluating Dario's new work.
It's strange that I never ran into it before.
I tried to fix it but met a wall (higher level changes were needed) and we're strongly leaning towards getting rid of subpasses rather than fix it.
The problem is that, for some God-forsaken reason, Vulkan decided to put the loadOp/storeOp with the attachments in a VkFramebuffer object; instead of asking them in the subpass when creating the VkRenderPass.
What Godot is trying to do is (2 subpasses):

Color MSAA
Depth MSAA
Color Resolve
Final Output

That is, 4 attachments. The (sub)passes are as follows:

First pass draws to Color MSAA + Depth MSAA and resolves to Color Resolve.
Second Pass takes Color Resolve as input to a postprocess and outputs to Final Output

The problem is that to achieve this we need 5 (FIVE!) attachments and not 4.
Because Vulkan asks for the following:
attachment[i].vkImageView = ptr;
attachment[i].loadOp = CLEAR;

And what we need is the following:
attachment[n].vkImageView = Color Resolve;
attachment[n].loadOp = CLEAR;

attachment[o].vkImageView = Color Resolve; // Same point as attachment[n]
attachment[o].loadOp = LOAD;

Attachment N would be used for the 1st pass, while attachment O for the 2nd pass.
I tried to inject a 5th attachment while creating the VkRenderPass. But I found a problem: The VkFramebuffer had already been created with 4 attachments.
To fix this mess I'd have to evaluate the attachments required twice (at VkFramebuffer creation and VkRenderPass creation) and work at a higher level that is aware of both.
However since we're leaning towards getting rid of subpasses entirely, we may just do that instead of wasting time fixing it.


[Bug] Age is negative for sleep calculator

Description
Age is negative for sleep calculator
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

When we are entering negative age, it is giving the alert that Age should be between 1 and 100 @AkhilaSunesh


support go1.13 error chain

This change will allow you to catch nested errors in errors.Is.
Also updated deps.
Closes #25

Hello, maintainers. Please review this PR.

Gentle Ping...
@JeffreyRichter
@zezha-msft
@JohnRusk
@jjcollinge
@jhendrixMSFT

Thanks your response.
chmod -x pipeline/*.go because We don't need execute permission for Go source code

@zezha-msft I'm looking forward to merge and new tags.
Thanks All.


Mast: Watch professoralimanderaandmama(?:@gmail.com)?

Mast requests the watch of the watch_keyword professoralimanderaandmama(?:@gmail\.com)?. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

professoralimanderaandmama(?:@gmail\.com)? has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Daniil in Charcoal HQ


Update HOW_TO_CONTRIBUTE.md

@eltociear Can you not do that please.

@eltociear Can you not do that please.

I don't know what to say any more
OMG!!


Bug: Form inputs - Help icon in wrong position

Potentially due to refactoring of the input container, the help icon when used is appearing inside the input instead of outside the input like intended.
Also the incorrect icon is being used.  It should be the solid help icon

History of bug
Looks like the last time it was correct was v2.3.6

In v2.3.7 the icon was incorrectly changed to the outlined version

And then in 2.3.11 it was incorrectly placed inside the container where it could conflict with inputs that already use a button on the right side like search, date, or password.

Looks like we're going to update the desired position of the help/info icon, so fixing this is no longer necessary.  The new approach can be handled in a new ticket.


utp selectiveAck extension crashes sometimes

sometimes the utp peer crash with this exception
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: RangeError (length): Invalid value: Not in inclusive range 0..576460752303423487: -40608
#0      new _List.filled (dart:core-patch/array.dart)
#1      UTPSocketImpl.newSelectiveACK (package:utp_protocol/src/utp_socket_impl.dart:851:19)
#2      UTPSocketImpl.sendPacket (package:utp_protocol/src/utp_socket_impl.dart:1006:26)
#3      UTPSocketImpl.requestSendAck.<anonymous closure> (package:utp_protocol/src/utp_socket_impl.dart:881:12)
#4      Timer._createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:18:15)
#5      _Timer._runTimers (dart:isolate-patch/timer_impl.dart:398:19)
#6      _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:429:5)
#7      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

this looks like a race condition or incorrect calculation of seq numbers, in any case i don't have reproducible steps for this crash, it happens rarely on my machine that makes it hard to debug and trace

I think have similar issue. I got in file utp_socket_impl.dart line 851 (var payload = List.filled(c * 32, 0);) and this issue seems to be random when download "large(let's say 4GB)" file
Exception has occurred.
RangeError (RangeError (length): Invalid value: Not in inclusive range 0..576460752303423487: -38624)
here's related code.
SelectiveACK? newSelectiveACK() {
if (_receivePacketBuffer.isEmpty) return null;
_receivePacketBuffer.sort((a, b) {
if (a > b) return 1;
if (a < b) return -1;
return 0;
});
var len = _receivePacketBuffer.last.seq_nr - lastRemoteSeq;
var c = len ~/ 32;
var r = len.remainder(32);
if (r != 0) c++;
var payload = List.filled(c * 32, 0);
var selectiveAck = SelectiveACK(lastRemoteSeq, payload.length, payload);
for (var packet in _receivePacketBuffer) {
selectiveAck.setAcked(packet.seq_nr);
}
return selectiveAck;
}


Remove default syntax highlighting

Hi,
I'm trying to figure out how to remove highlighting for variables. For context, In the go language, I just want to have the variable declarations highlighted. Anytime a variable is used though I want it to not be highlighted. In the current highlighting code it highlights all variables (identifiers). Is there a way to remove the highlighting on identifiers?
I've figured out how to isolate just declarations as follows:
(tree-sitter-hl-add-patterns 'go
  [(short_var_declaration left: (expression_list (identifier) @variable))
   (var_declaration (var_spec name: (identifier) @variable))])

but I don't know what capture name (if any) to use for just the (identifier) highlighting. Any tips?

We don't have a mechanism to selectively remove a specific highlighting pattern yet.
There are 2 things you can do at the moment:

Copy the query pattern file returned by (tree-sitter-langs--hl-query-path 'go). Modify it to suit your need. Then advise the function tree-sitter-langs--hl-query-path to return that file instead. For example:

(define-advice tree-sitter-langs--hl-query-path (:before-until (lang-symbol) override-default-patterns)
  (pcase lang-symbol
    ('go "/path/to/your/modified/highlights.scm")))

Not highlighting all identifiers as @variable is actually consistent with tree-sitter-langs's styles. The Go patterns should be modified to do so. A pull request is welcome.

Add new patterns that override the default patterns. For example:

;; tree-sitter-hl.el doesn't have this face, but it probably should.
(defface tree-sitter-hl-face:nil
  '((default :inherit default))
  ""
  :group 'tree-sitter-hl-faces)

(tree-sitter-hl-add-patterns 'go
  [(short_var_declaration left: (expression_list (identifier) @variable))
   (var_declaration (var_spec name: (identifier) @variable))
   ;; This is prioritized over the default from highlights.scm.
   (identifier) @nil])

@ubolonton thanks for the response! Is there something that documents tree-sitter-langs styles? In case I want to make a pr for go to match it completely

There is no documentation on that yet. The rule of thumb is following the docstrings of the faces defined in tree-sitter-hl.el.
Some notable conventions are:

Definitions and uses should be differentiated. Examples:

@function vs. @function.call.
@method vs. @method.call.
@type.parameter vs. @type.argument.
@variable vs. none: variable uses should not be highlighted.

Special faces should have high priority (placed earlier in the pattern list): @function.macro, @type.builtin, @variable.special.
"Contextual" patterns should have low priority (placed at the end). Example: string interpolation.

Note that the package tree-sitter-langs provides its own highlighting patterns. This page lists languages whose highlighting patterns have been substantially modified compared to upstreams'. You can use them as examples.


native的build文件夹flutter run后黑屏

通过flutter_native 进行flutter run可以正常显示，然后通过scripts/build_flutter_native.dart生成了build文件夹，运行flutter pub get后，运行flutter run黑屏

请提供 mpflutter 以及 mp_flutter_runtime 的版本号信息


Creating a student model

Currently, there is no backend code to handle users. I will create a separate directory to handle the backend part, inside the 'models' folder I will create a 'student' model based on a studentSchema. The student will have the following attributes:
name, year, email Id, password, branch. I will be doing the setup using node and express
@ChetnaNSharma, @yash982000 can you please assign this issue to me?

Currently, there is no backend code to handle users. I will create a separate directory to handle the backend part, inside the 'models' folder I will create a 'student' model based on a studentSchema. The student will have the following attributes:
name, year, email Id, password, branch. I will be doing the setup using node and express
@ChetnaNSharma, @yash982000 can you please assign this issue to me?

@mitalirs Sure. Just make sure about our project requirements and goal.
Also, stick to Node if possible. :)

@yash982000 sure, thank you for assigning this issue to me
Also, will it be okay if I add the student model once the initial folder setup is done, I guess @Kriti-bit has been assigned to do that, right?

@yash982000 sure, thank you for assigning this issue to me
Also, will it be okay if I add the student model once the initial folder setup is done, I guess @Kriti-bit has been assigned to do that, right?

Yes, you can have mutual discussions nd update me accordingly


[doc] Add infinite annotations for the configuration options whose default value is MAX_VALUE

Linked issue: close #2886

https://github.com/wanglijie95/incubator-paimon/actions/runs/7989699968/job/21816800062
test failed, you need to modify documentation too.

+1


can it be possible to crop two or more images separately in single activity like tinder

i need to select two or more images for my product seperately. i cant understand how can i assign different uri to different images kindly help ...please

Did you find an answer? , I have the same issue

i need to select two or more images for my product seperately. i cant understand how can i assign different uri to different images kindly help ...please

You're a loser referencing that depraved app, there is a simple way, obviously you don't know s*it

And the simple way is ??
On Sat, 15 Jun 2019, 5:11 a.m. emailsubjekt<EMAIL_ADDRESS>wrote:

i need to select two or more images for my product seperately. i cant
understand how can i assign different uri to different images kindly help
...please
You're a loser referencing that depraved app, there is a simple way,
obviously you don't know s*it
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ArthurHub/Android-Image-Cropper/issues/657?email_source=notifications&email_token=AIOIGBYDKZX3EJLOCQZR7G3P2RMXBA5CNFSM4GZXRV22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXYPC6I#issuecomment-502329721,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIOIGB4JSA5WKMH76Y5EU2DP2RMXBANCNFSM4GZXRV2Q
.

The simple way is to make 5 imageview's and implement a camera call for click on each, that way you can add or edit images. Or you could use numerous libraries that exist, I'm not gonna name names here but for example when you select more images it does a 'for' loop and you can save each received uri into memory or you can upload them to the server. Providing you know java this should be a breeze for you.

Thanks let me try it out right now
On Tue, 9 Jul 2019, 7:50 a.m. emailsubjekt<EMAIL_ADDRESS>wrote:

The simple way is to make 5 imageview's and implement a camera call for
click on each, that way you can add or edit images. Or you could use
numerous libraries that exist, I'm not gonna name names here but for
example when you select more images it does a 'for' loop and you can save
each received uri into memory or you can upload them to the server.
Providing you know java this should be a breeze for you.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ArthurHub/Android-Image-Cropper/issues/657?email_source=notifications&email_token=AIOIGB6XSEYFORVXZFXAOCTP6SQTDA5CNFSM4GZXRV22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZQQI3Y#issuecomment-509674607,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIOIGBYU7IGLGCUKJRUW6QLP6SQTDANCNFSM4GZXRV2Q
.


add data-url canonicalization before hashing for json mime-type

As explained in this issue, if we always must canonicalize before hashing, here a pull request proposal to add this extra canonicalization step in case of JSON mime type.
Or maybe we should consider that the input test must be  :
'data:application/json;charset=utf-8;base64,eyJzb21lIjoib2JqZWN0In0='
instead of
'data:application/json;charset=utf-8;base64,eyJzb21lIjogIm9iamVjdCJ9' ?
knowing that :

base64 of {"some": "object"} is equal eyJzb21lIjogIm9iamVjdCJ9
base64 of {"some":"object"} equal eyJzb21lIjoib2JqZWN0In0=

In this pull request both urls above will generate the same ISCC and metahash

This is a good catch. And thank you for your contribution. I have been thinking about how we handle that. The relevant part of the specification is here: https://ieps.iscc.codes/iep-0002/#43-meta-element. I think the responsibility for canonicalization (as defined in the spec) should be with the caller of the function, because

we accept any kind of binary data (as a Data URL encoded string) as input for the optional meta  argument
detecting, deserializing and canonicalizing all conceivable formats (xml ...) would open a can of worms and a large attack surface
The last clause of 4.3. explicitly states: Decode the base64 encoded data section of the Data URL to a raw bitstream without further interpretation.

So the expectation is that the Data URL contains a canonicalized data, but we do not mess with the data. The test basically makes sure the implementation does indeed not mess with the input besides accessing the raw bitstream of the Data URL.
But I guess we should add a comment to the documentation string of the function that explains that canonicalized the wrapped data shall be cononicalized.
What´s your take on this?

Thank you for you explanation and target to the specification : https://ieps.iscc.codes/iep-0002/#43-meta-element.
It is indeed clear in the spec that it must be canonicalized before the conversion of Data-URL :
"If the value of the meta element is JSON or JSON-LD it shall be serialized with RFC 8785 JCS canonicalization before being wrapped in a Data-URL"
And do nothing after without further interpretation as you mentioned.
I was confused by this corner case test but it is clear with the specification. I will fix the typescript iscc-core implementation accordingly.


🐛 Create-A-Derived-Table Action Queue is unacceptably long

Describe the bug.
In create-a-derived-table, action run times can stretch to upwards of an hour despite only taking a matter of minutes to run. This is due to long queue times when multiple PRs are made, and if many pushes are made to said PR branches.
To Reproduce

Go to the Create-A-Derived-Table repo
Open a number of PRs with changes
Cause a mashup for the deploy-dev action
Get stuck queuing for ages

Expected Behaviour
Multiple PRs should be able to use actions simultaneously.
Additional context
Recommend Scaling runner count from 1 to 2. This should help alleviate the worst of the queuing at peak times. Could autoscale but this may be overkill.

To add, this issue has been noted by end users, and a solution sought via Slack. We should act on this promptly to ensure customers continue to use the service without issues.

Should be closed by #3218

CADT's Cloud Platform and Data Platform replica count has been increased to 2.
Moving to in review while we collect feedback from users.


Add  is_hidden parameter for create or update alias API

Description
In this PR, we fix the bug of create or update alias API doesn't throw exception for unsupported parameters, and also add the missing request body parameter is_hidden, so we need to update the api specification.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks @dblock , please help to take a look at the new change.


some suggestion

Dear author,
May be it's a good thing to add a requirement guide.

Hi @Aitensa ,
I apologize for the delayed response. I would like to let you know that a requirement.txt file has been added, thanks to @halidziya.
Thanks,
Junyu


[Wait for #1143] [ TIME DIST ] Implement Backwarding of TimeDistLayer

This commit includes

implementation of TimeDistLayer Backwarding

Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: jijoong.moon<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1144. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

:octocat: cibot: @jijoongmoon, nntrainer/models/neuralnet.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @jijoongmoon, nntrainer/layers/time_dist.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @jijoongmoon, nntrainer/graph/network_graph.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md


getNextAvailableLink() could leave availableXLinks[] array inconsistent

When getNextAvailableLink() starts to populate a xLinkDesc_t within availableXLinks[], if an error occurs it could leave that entry in the array in an inconsistent state. I believe it prematurely populates link->id = id;
https://github.com/luxonis/XLink/blob/fc76e5b87361169077b7481dc611122ce7b6d6af/src/shared/XLinkDevice.c#L509-L516
Setup

XLink at fc76e5b87361169077b7481dc611122ce7b6d6af
all OS, all compilers

Repo
Found in code review of that commit.

line 509 gets the address of an entry in availableXLinks[].
Changes that entry's id from INVALID_LINK_ID to an id retrieved from getNextAvailableLinkUniqueId()
Then attempts XLink_sem_init()
In scenarios where that fails, function returns NULL to the caller.

Result
The entry in availableXLinks[i] has been changed. It is not INVALID_LINK_ID. Instead, it is inconsistent...
...it has a valid link->id
...but the link->dispatcherClosedSem is invalid/uninitialized
This is inconsistent.
Expected
The entry in availableXLinks[] should be marked an invalid/empty xLinkDesc_t since the initialization was not successful.
Fix
Move link->id = id;. Put it just before the final call to pthread_mutex_unlock().
Yes, it is possible for that last pthread_mutex_unlock() to fail. Yet if it does, that is a separate issue. availableXLinks[] itself will be valid and correctly initialized -- it will be consistent.

fixed in PR #33


Minor documentation and new directory change

Description
This PR adds documentation to the model download script that I disentangled while running the script in isolation.
Minor documentation fix for better error understanding + added back the model folder creation
Type of change
Please check the options that are relevant.

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] Proposes a change (non-breaking change that isn't necessarily a bug)
[ ] Refactor
[ ] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[ ] Documentation only change
[ ] Datasets Release
[ ] Models Release

Type of requested review

[ ] I want a thorough review of the implementation.
[ ] I want a high level review.
[ ] I want a deep design review.

Testing
Tested locally, on devfair and CI
Checklist:

[ ] I have performed manual end-to-end testing of the feature in my environment.
[ ] I have added Docstrings and comments to the code.
[ ] I have made changes to existing documentation where needed.
[ ] I have added tests that show that the PR is functional.
[ ] New and existing unit tests pass locally with my changes.
[ ] I have added relevant collaborators to review the PR before merge.
[ ] [Polymetis only] I have verified that all scripts in tests/scripts runs on hardware.

Codecov Report

Merging #716 (cd193d6) into test_model (dbca054) will increase coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           test_model     #716      +/-   ##
==============================================
+ Coverage       34.38%   34.40%   +0.02%
==============================================
  Files             317      318       +1
  Lines           31028    31044      +16
==============================================
+ Hits            10669    10682      +13
- Misses          20359    20362       +3

Impacted Files
Coverage Δ

agents/craftassist/tests/fake_agent.py
71.52% <0.00%> (-0.66%)
:arrow_down:

...antic_parsing/nsp_transformer_model/query_model.py
93.10% <0.00%> (ø)

...ception/semantic_parsing/tests/test_nsp_loading.py
93.75% <0.00%> (ø)

interpreter/craftassist/tasks.py
72.46% <0.00%> (+0.18%)
:arrow_up:


nixos/jenkins: Copy plugins as .jpi instead of .hpi

Motivation for this change
Resolves #65580
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Er, sorry, I had the wrong committer metadata on that. I'll fix that tomorrow.

All better

@coreyoconnor says this is safe. Should I notify anyone else to get this under review?

For the record: the reason this is safe is because jenkins normalizes plugins to .jpi anyways. .hpi is deprecated and only supported for hudson compatibility.
I've tested this on my jenkins instance without issue.

Can you sum up the motivation behind this change into the commit message? (So archeologists only need the git repo and not github.)

Alright, how's does that look?


Update the Private Data Asset Transfer for Purge

Add a Purge transaction function, very similar to delete, but calls
Purge instead to completely remove data from the private collections
Signed-off-by: Matthew B White<EMAIL_ADDRESS>

/azp run
test flake?


Backdoor in event-stream dependency

The dependency event-stream version 3.3.6 contains a backdoor via a library it uses, flatmap-stream. The linked issue explains the situation.
Since package.json specifies "event-stream": "^3.3.4",, it was possible to pull in the back door if you updated psl's dependencies during the period of time that event-stream 3.3.6 was available.
One fix would be to lock event-stream to exactly 3.3.4.

Also, is there a way that you can figure out what version of event-stream was used in generating dist? That would help people understand whether they may have gotten this backdoor or not.

I just realized that event-stream is only used in devDependencies. So I'd expect it to not end up in anything in dist. I scanned the unminified dist/psl.js file and it looks ok.

Preliminary analysis https://github.com/dominictarr/event-stream/issues/116#issuecomment-441749105

Although psl uses event-stream as a devDependency. It would still be wise to either upgrade to the latest v4.0.1 or lock to 3.3.4.


Chips - Add, Autocomplete

(1st off - LMK if you would welcome a PR on this)
Add the ability add chips ACS:

Similar in function to https://material.angular.io/components/chips/examples
Add chip via key input
Emit appropriate events
Autocomplete with configurable source

What problem does this solve that MatBlazor isn't currently capable of?
Parity with other material implementations.
A clear and concise description of what you expected to happen.
(See provided link/sample)
If applicable, add screenshots or .GIF captures to help explain your request.
(See provided link/sample)
Add any other context about the request here.
If interested please provide additional ACS, i would like to contribute to the code base - great work so far!

We always welcome contributions to the code. 🙂


Release 1.4.0

Releases Breadcrumbs backbone/underscore utilities used in https://github.com/edx/ux-pattern-library/pull/334.
Doc preview: http://ux-test.edx.org/bjacobel/release-06-21-2016/

[ ] @andy-armstrong

Are you following the steps from here: https://openedx.atlassian.net/wiki/display/FEDX/UI+Toolkit+release+process
Don't forget to update bower.json.

@bjacobel Can you generate preview doc so I can see what that will look like. Thanks.

Coverage remained the same at 94.456% when pulling 7059298debceb7afe98a2e9ba66860c7e3ff403a on bjacobel/release-06-21-2016 into 2ac908161b6fd0d1e5c4a34605e7e979577950bd on master.

@andy-armstrong Yikes...

Totally forgot about Bower
Totally forgot which number was the patch and minor
Doc preview here: http://ux-test.edx.org/bjacobel/release-06-21-2016/

Will fix 1 and 2 right now.

Thanks @bjacobel. It looks like the doc needs adjusting for this page as it has a dropdown menu example:
http://ux-test.edx.org/bjacobel/release-06-21-2016/views/breadcrumbs/breadcrumbs-view/

Coverage remained the same at 94.456% when pulling 708d7d1f79295509e8065d4017bf5732807f1962 on bjacobel/release-06-21-2016 into 2ac908161b6fd0d1e5c4a34605e7e979577950bd on master.

Coverage remained the same at 94.456% when pulling 708d7d1f79295509e8065d4017bf5732807f1962 on bjacobel/release-06-21-2016 into 2ac908161b6fd0d1e5c4a34605e7e979577950bd on master.

Yikes. I'll have to make another PR into master to fix that and then rebase this release. Stand by...

@andy-armstrong Docs issue fixed, doc preview updated.

👍

Coverage remained the same at 94.456% when pulling ab106ae44f16432483bb81aacbab7d74f0975986 on bjacobel/release-06-21-2016 into e991260539280516e33ddeefb63346ec3a83fc72 on master.

Coverage remained the same at 94.456% when pulling ab106ae44f16432483bb81aacbab7d74f0975986 on bjacobel/release-06-21-2016 into e991260539280516e33ddeefb63346ec3a83fc72 on master.


Doesn't work on PC

Chrome version: 115.0.5790.170 (Official Build) (64-bit) (cohort: 115_170 Stable Control(A))

That's after deleting the browser's cache.

I confirm that it does not work anymore (using it on Microsoft Edge) since this summer.

Fixed #5
Will upload to chrome web store now, but it takes a few days to be reviewed. You can load unpacked in the meantime.
Thanks for reporting, appreciate it!


Getting the length of a string with last nil and required memory size for allocate

As I noticed, the crate doesn't provide ready-made functions for getting the real string length (with last nil) and the required memory size for it.
What's the best way to implement this with less code?
use widestring::U16CString;

let str = "test";
let str_winapi = U16CString::from_str(&str).unwrap();
println!("{}", str_winapi.len()); // 4 - length without nil
println!("{}", str_winapi.as_slice_with_nul().len()); // 5 - length with nil
println!("{}", core::mem::size_of::<wchar_t>() * str_winapi.as_slice_with_nul().len()); // ? required memory for allocate?

I just recently started learning rust.

As I understand it, need to use FormatMessageW to get the correct size.


no available server to connect.

2019-03-13 20:38:24.657 ERROR 20560 --- [imeoutChecker_1] com.alibaba.fescar.config.ConfigFuture   : config operation timeout,cost:5001 ms,op:GET,dataId:service.vgroup_mapping.tx-demo-fescar-account-fescar-service-group
2019-03-13 20:38:24.657 ERROR 20560 --- [imeoutChecker_1] c.a.fescar.core.rpc.netty.RmRpcClient    : no available server to connect.
How to deal with？？？

2019-03-13 20:38:24.657 ERROR 20560 --- [imeoutChecker_1] com.alibaba.fescar.config.ConfigFuture : config operation timeout,cost:5001 ms,op:GET,dataId:service.vgroup_mapping.tx-demo-fescar-account-fescar-service-group
2019-03-13 20:38:24.657 ERROR 20560 --- [imeoutChecker_1] c.a.fescar.core.rpc.netty.RmRpcClient : no available server to connect.
How to deal with？？？

请问下这个问题怎么解决的？
I have the same problem, how did you fix it , will you share it ?

@lilongthinker The vgroup_mapping attribute name in the file.conf file must match spring.application.name

@lilongthinker The vgroup_mapping attribute name in the file.conf file must match spring.application.name

more than thx,  it worked

@lilongthinker Has the problem been solved?

@lilongthinker Has the problem been solved?

YES!!!


publishing to remote is failing with "Repository for publishing is not specified"

After #98 got merged, publish/publishSigned is aborting with error like
[error] java.io.IOException: Server returned HTTP response code: 401 for URL: https://oss.sonatype.org/content/repositories/snapshots/org/scorexfoundation/scrypto_2.13/2.2.1-33-88372613-20230123-1543-SNAPSHOT/scrypto_2.13-2.2.1-33-88372613-20230123-1543-SNAPSHOT.jar
...
[error] java.lang.RuntimeException: Repository for publishing is not specified.
...

@kushti , should be closable due to

https://github.com/input-output-hk/scrypto/pull/102


updater='grow_gpu_hist' produces unstable results on equivalent but not identical sparce matrices

Here's a notebook with reproduction: xgboost-unstable-grow-gpu-hist-reproduction.zip
Here's the data: reproduction_data.zip
Does not reproduce on 0.72, but does reproduce on 0.80 and some pretty recent commit that I lost id of;  I assume this reproduces on current master, but will edit after verifying.

Do you see the same problem with CPU hist?

No; grow_histmaker, grow_fast_histmaker, grow_local_histmaker, grow_colmaker and grow_gpu each give me identical results at those two datasets, and their 0th epoch merrors are all identical.
grow_skmaker is not stable even on the same dataset, although occasionally its 0th epoch matches with those above.
Incidentally, Is there a complete list of updaters somewhere? Docs list some, but all cpu updaters and no gpu updaters.

Incidentally, is there a complete list of updaters somewhere? Docs list some but not all cpu updaters and none of the gpu updaters.

Good point @mrgutkun,  currently it's not clear what's the distinction between the updater and tree_method parameters.

@thvasilo The tree_method parameter is supposed to cover 90% of use cases. The updater parameter is an "expert" parameter that's less well documented. The documentations says
This is an advanced parameter that is usually set automatically, depending on some other parameters.

So usually it is sufficient to set tree_method.

Oops clicked wrong button.

Thanks for the clarification @hcho3. Out of curiosity are there sanity checks in place that would stop/inform users of passing contradicting values to these parameters?

@thvasilo #3849 clarifies the behavior of tree_method and updater.

Closing in favour of https://github.com/dmlc/xgboost/issues/5023


Agent does not ask for clarification when the input location is not specific enough.

If the user input is a country/state instead of a specific location, the agent does not ask for clarification. Instead, it matches it to a similar looking city. An example from the weather skill:

what is the weather like tomorrow?
What location do you want sun time info for?
canada
The current weather in La Canada is raining. The temperature is 4 C and the humidity is 88 %.

Does this require a change in the state machine?

Does this require a change in the state machine?

It does - in a sense. The agent is asking a question of location type. Because locations are free-form and we want to understand them regardless of the neural network, this overrides the parser so everything the user types is sent to the Thingpedia location API (which routes to OpenStreetMap).
That is only half of the problem though.
The other half is that "Canada" resolves to "La Canada" in the location API, and I'm not sure exactly why.


Nima - HTTP/2 Client - upgrade failure fallback

We need to fallback properly back to HTTP/1 when upgrade fails

This issue was fixed by webclient redesign #6669


form-data use for image upload but req.body and req.file in no data available.

Here my backend code for create product

It's unclear if this is an Express app or if it's using some other framework.
Assuming it's something like Express, unless you've used a body parser middleware, you'll likely need to call req.body.text() or req.body.json() to read in the body. It may still be in stream format.


bug: provide informative message when no tests are found rt-list

This PR closes #5 by adding a message when no tests are found.
I also changed the variant names for the enum to make it easier to follow.
I was also playing around with emojis here. Can remove :)

Running from rt-cli I get
rt-cli ⚡ rt list
❗ No tests found.

Running with a path to a package with tests:
rt-cli ⚡ rt list ../../../arcgisutils
Found 9 tests
📌 ../../../arcgisutils/tests/testthat/test-arc-base-req.R
📌 ../../../arcgisutils/tests/testthat/test-arc_token.R
📌 ../../../arcgisutils/tests/testthat/test-date-handling.R
📌 ../../../arcgisutils/tests/testthat/test-date-parsing.R
📌 ../../../arcgisutils/tests/testthat/test-empty-results.R
📌 ../../../arcgisutils/tests/testthat/test-fetch_layer_metadata.R
📌 ../../../arcgisutils/tests/testthat/test-json-conversions.R
📌 ../../../arcgisutils/tests/testthat/test-null-geometry.R
📌 ../../../arcgisutils/tests/testthat/test-rbind-results.R

changed the variant names for the enum to make it easier to follow.

sounds good 👍🏽
This takes care of list nicely! Is it straightforward to take care of dir and file too? If not, we can do that later.
I'm on the fence regarding the push pin emoji. I'm generally pro emoji but I I think using the same emoji repeatedly isn't my preference

I've gone ahead and removed the pin—i too felt it was obnoxious.
Modifying dir and file is less simple because the error message is emitted from R and not Rust.

Modifying dir and file is less simple because the error message is emitted from R and not Rust.

okay, I'll keep #5 open then


Adding cdnjs for jsrender as an installation way...

Requested cdnjs to add a cdn for jsrender. Approved just yesterday after a few weeks.

The cdnjs issue is here https://github.com/cdnjs/cdnjs/issues/6350

Thanks. In fact just today I committed a new update - v0.9.71 - which supersedes 1.0.0-rc.70. It has just been uploaded to npm too. It should fix the autoupdate issue, since I will no longer use version numbers with -rc*.
Would you be able to update to v0.9.71 on cdnjs? Then I will add the info to the JsRender readme.
Also, would you be able to make JsViews available on cdnjs too? https://github.com/BorisMoore/jsviews

@BorisMoore I can request on the cdnjs issue to update it to v0.9.71. also jsviews can be made available by opening another issue on the cdnjs repo.

Excellent! Thank you very much!

Added to Readme. Thanks again!


V4 video play issue

Ok so we got Verion 4 to load after adding line to manifest
bs_libs_required=roku_ads_lib
Channel now siseloads but video player has issues!
Videos open but stay in loading then freeze!

Are you side loading a package or zip?  I tested with a zip and it appeared to work fine. Is it a specific type of feed content that hangs?

Nothing special, I tested it with my tvSpecials feed and I tested one of my client feeds who has movies series and shortform videos, Alpha 3 runs with no issues on those feeds nut Alpha 4 video play keeps loading and freezes on those test and a few others. I see your coder changes and looked at it, it loasd if we add the line to manifest so the sideload error goers away but them that playe of the video freezes!

Can you provide a URL for me to test with?

OK this is one of my tvSpecials channels I tried w version 3 and 4
works well w V# video freezes V4
https://c.themediacdn.com/feed/W3s3aS/iTtnaWjsAtP/OlOBqr3si46?format=rokujson

Thanks. I'll test and report back.

Can you provide a list of the steps you used to side-load the code?  I want to walk through your steps since the application works when I install it from a zip file.

I think I found the problem.  It appears that somehow I zipped the wrong version of the code.  I must have zipped the Ads version I am working on instead of the correct one.  That's why you had to add that line to the manifest.
I am preparing to package a new zip.

ok

@ferdiworks Can you take a look at the attached zip and let me know if it resolves the issues?  You should not need to add any lines to your manifest.  If this works, I will repost it.
DPtoSceneGraph.zip

That zip did not load, Application Received: 224924 bytes stored.
Install Failure: No manifest. Invalid package. I'll try and test again!

I unzip the zip sent and the manifest file is gone but I will add one and test it!

OK added manifest file zipped it loaded it and freezes at load

I was curious and tried it with the Ad Libs line in mainfest and without and both froze at loading!

Can you provide the steps you are using when you test?  I need to figure out why the code works for me and not you.

OK i will do a screen record just cant capture the Roku load!

I sidseload the zip you sent and it froze!
I created the manuifest with your tool software then copied it over to the zip you sent!
Note version 3 works just fine no problems but v43 has the issue.
Here is the video screen record
https://www.loom.com/share/4db425dcc4164fcfb85612254a8867ef?sid=79f9c812-38da-406c-9883-4c5cb978f836

@rrirower You wrote: Can you provide the steps you are using when you test? I need to figure out why the code works for me and not you.

I used the software to create test channel
2)Copied manifest over to the zip you suplied!
3)Zipped it
6_sideloaded the zip
7)Roku open on screen and froze at loading!
Updated software on Roku device, Restarted system, tried again! Same result!
9_Retested  V3 with edits from me and all loaded good!
Changed feed with new manifest file and your zip provided and it froze again!
Tried the V4 again with zip from version 4 output
Application Received: 219610 bytes stored.
Install Failure: Compilation Failed.PlayerTask
add line ad libs loads fine!

Thanks for the video.  Unfortunately, it ended right at the time you were to upload the zip file, so, I did not get to see the error.  Additionally, I used the URL you posted above and the one in your video and both opened and played on my Roku.  I sideloaded the zip and both played correctly.
I used the code from the DPtoSceneGraph.zip file posted above and updated the manifest to use your URL.  I tested from within my debugger and by sideloading the zip file.

Here's my test:
https://github.com/rrirower/DP2SceneGraphWizard/assets/34550407/fd06d970-c753-439b-b0b2-2e9329b7c357

Hello Am sorry for interrupt
please can
HpD.zip
you help me to test this file also

@fronderblash The zip file you posted contains corrupt code as I indicated above.  If you'd like to test with a potential fix, download the zip I posted above for Joe, and add your manifest to the zip file.  Then, sideload the zip.

@rrirower I watch your video and seen the install failure and I seen in the debugger window the ad libs line in therter! I see the image posted above from one of my feeds! Thanks for your patience and support! I support the project and what you are doing here! I keep trying and testing, sorry my video cut off as my monitor is a Roku TV and when it laurnches unless I capture w a second camera or phone record i dont get the second video to edit into one!

@rrirower I don't understand as well, I am  more seasoned working w SDK files and working w coding and have published many sites for myself and clients over the years! I keep tedsting your files and will report back!  I don't know why I get the a difference from your test! I tried another device and tested again ensuring system updates and restarts to devixces and computer!

@ferdiworks Can you try the following:

Download the zip I posted above.
Add your manifest to the zip.
Sideload the zip.

You do not need to re-run the Wizard tool since there were no changes to the tool.

@fronderblash I tested your zip and get same errors as my own w version 4 and with the zip given here and your feed, Your feed works w version 3 just fine!
What I don't understand is why 3 different people here in the issues section  keep asking for this snack tv channel help even after I myself was hired and produced a fully working SDK Channel with my own sdk template and script.

rrirower
thanks it worked

@ferdiworks I'm still not sure what error you are getting.  Can you take a picture of the screen, or, something like that?  I'd liek to release this updated version if I can resolve this issue.

@ferdiworks As you can see from his post, @fronderblash got his channel to work with the updated zip above.  Please double-check your steps.

@rrirower I just tested his zip posted and ran the test and got same errors I am now taking and redownloading the Dp to scenegraph zip again and going to test it again!

@ferdiworks His zip was corrupt. I gave him the steps to follow above to test with the new zip.

it show this thing

@ferdiworks I've seen that message if your manifest is missing a FEED_URL line or it is commented out with "#".

@rrirower I know this lol
I am not new to this!
I just tried this again and again and what i get is the same error that fronerblash just reported! Over and over with many manifest changes from different working channels!
He just posted an image asnd thats what I get!

I apologize if I've offended either of you, but, please understand the frustrating aspects of trying to resolve this.  It's been difficult trying to get clear info about the problem.
Can either of you provide your manifest file so I can test with it?
Are you side-loading the zip, or, a package.
Lastly, can either of you post the zip that fails for you so I can try to load it?

Uploading DPtoSceneGraph (5).zip…

DPtoSceneGraph (5).zip

here is a test channel w same error he repoted as well
https://ondemandtvservices.net/source.zip

I apologize if I've offended either of you, but, please understand the frustrating aspects of trying to resolve this. It's been difficult trying to get clear info about the problem.
Can either of you provide your manifest file so I can test with it?
Are you side-loading the zip, or, a package.
Lastly, can either of you post the zip that fails for you so I can try to load it?

YOU HAVE NOT OFFENDED ME!
I support the project and don't mind testing the templates or software! I have some expeirence so I believe I can contribute and help!

it show this thing

This is the same error I been reporting all along!

ok

I found the bug by looking into your individual zip files.  These should fix it.  Please let me know so I can post an updated zip.
ferdiworks.zip
fronderblash.zip

I found the bug by looking into your individual zip files. These should fix it. Please let me know so I can post an updated zip.
ferdiworks.zip fronderblash.zip

That zup worked and loaded, Now I will test it w other feeds!

yes it work

I found the bug by looking into your individual zip files. These should fix it. Please let me know so I can post an updated zip.
ferdiworks.zip fronderblash.zip

@rrirower Ok testing with other feeds and adding background image works weell for me now!

ok

ferdiworks
please how did you add background images

rrirower
ferdiworks
Thanks for your  help
but
how can i change this image to my own image

rrirower ferdiworks Thanks for your help but
how can i change this image to my own image

You can use photoshop or another photo editor

Thanks to you both for helping.  I will be posting a new zip shortly.


Remove dangerous dummy meson dep

When a dependency library is installed with hardcoded scripts, declare dependency with as much information as possible from the installed package to detect dependency errors at build-time.
Don't add a dummy dependency for actual library dependencies.
Fixes #2673

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2674. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

quick question) Shouldn't dummy_dep be corrected as well like below ?
openmp_dep = dummy_dep
opencv_dep = dummy_dep

Those might use https://mesonbuild.com/Reference-manual_returned_disabler.html for "initialization purpose".

LGTM! Would this be for debugging purposes or to avoid any build errors?

This allows earlier errors: i.e., meson errors rather than compiler or runtime errors.


JWT Expired validation error

Hi there,
Out JWT expired date is based on seconds, but we found the expo-jwt only supported the millisecond to be valid, or else it's expired.
If possible to add a configure parameter to indicate which unit to be used.
Thanks

Hey,
You are correct, the RFC states

A JSON numeric value representing the number of seconds from
1970-01-01T00:00:00Z UTC until the specified UTC date/time,
ignoring leap seconds.

https://tools.ietf.org/html/rfc7519#section-2
I would change expo-jwt to use seconds instead of milliseconds in general. If you have a PR, feel free, otherwise I would plan to work on this soon.

Sent PR request

v1.1.0 was just released to NPM


Remove closing  tag

It's the JavaDoc clean-up PR.

Current coverage is 83.46%

Merging #131 into master will decrease coverage by -0.27% as of 33d9b8d

@@            master    #131   diff @@
======================================
  Files           97      97
  Stmts         2804    2794    -10
  Branches       332     331     -1
  Methods
======================================
- Hit           2348    2332    -16
  Partial         81      81
- Missed         375     381     +6

Review entire Coverage Diff as of 33d9b8d

Powered by Codecov. Updated on successful CI builds.

LGTM.


Normalize DOIs in doi_sunet and merge_pubs tasks

Resolves #72 to make DOIs consistent across sources for accurate doi->sunet mapping and publication merging.
There are still some sul_pub DOIs that will be malformatted for matching because of the variability of that data source. Just hoping that they do not cause any problems in lookups downstream. Will test by running the branch on prod with the full data.
Ran DAG locally with a small dev limit and that succeeded.

The normalization in this PR will remove colons from doi:  or DOI:  in a doi value. If there are other colons in a DOI, then we will get the same error from OpenAlex,
"error: "Invalid query parameters error.",
message: "It looks like you're trying to do an OR query between filters and it's not supported.
You can do this: institutions.country_code:fr|en, but not this: institutions.country_code:gb|host_venue.issn:0957-1558.
Problem value: 10.1103/PhysRevB.75.075422|doi: 10.1103/PhysRevB.84.075477; 4599"

It will be helpful to see what those values might be (if they exist).


find / replace menu

How do I get to the find/replace menu? I can't find any key bindings that seem to work and emacs has a different counterpart and the emacs equivalent command doesn't pull it up.

Not sure what you mean but assume you mean the ones designed for sublemacs not the ones built-in to sublime text.  ctrl+s or ctrl+r by default like emacs are the bindings. Check the default keybindings file of sublemacs to change this to something else and look for sbp_inc_search keys. Click Default.sublime-keymap in the files on the main page for sublemacs specific bindings.

Now I realized maybe you mean a replace menu which isn't built into sublemacs so would need to use the default binding which on mac is command+alt+f (or I think that is my setting). Or I usually use sublemacs search and press alt+d to keep the current search item. Then I added forward and reverse bindings for alt+s and alt+r to skip the current item (only alt+r example is below but change forward to true for alt+s). Then just hit enter when you have all the selections you want and you will get the multicursor at each position which is essentially the same as find and replace :
	{"keys": ["alt+r"], "command": "sbp_inc_search", "args": {"cmd": "next", "keep": false, "forward": false},
	"context": [ {"key": "i_search_active"}, {"key": "panel_has_focus"} ]
	},

Also you don't have to add alt+r or alt+s can just use ctrl+s or ctrl+r to go skip but I just find it much quicker.


update mod-verion to 3

Tested working with Lite-XL release v2.1.

I'm not sure of all functionality works the same as before, blank lines do not show a green marker.

Hey any thing I can do to help this along?
Keen to get it working 2.1

commit https://github.com/vincens2005/lite-xl-gitdiff-highlight/commit/12ddfa619054dfdd1ed86426d60b569dc536c43e closes this, right?


fix for state.persist

fixes #331

The failing tests are due to the use of internal class properties externally.
The correct way to handle is it to write a class that extends RestoreEntity and provides methods to set these properties. However, as is, it should resolve the 2022.3 compatibility issues. Then, after some thought on how to implement this in a way that exposes entities to userland pyscripts, this temporary fix can be adjusted to fit in line with that plan.

Made the changes to my state.py, and can confirm it works...

@dlashua - thanks for the patch!  Couple of questions:

is this backward compatible with older versions of HA?
are there other breaking changes in HA 2022.3?

is this backward compatible with older versions of HA?

I don't think so. async_restore_entity_added was modified to expect an object passed to it. It then accesses attributes of that object. Is there a way to detect HA version and use different code depending on the version?

are there other breaking changes in HA 2022.3?

According to the release notes, no. But, the issue fixed here is also not mentioned in the release notes, so maybe?
I've not upgraded to 2022.3 yet, due to a lack of time. I just recently upgraded to 2022.2.

I'm not sure how to detect the HA version, although hopefully it is easy.  One approach would be to use try/except clauses to handle the new and old cases (which has the advantage that we don't need to explicitly test for the HA version).

After I finished fixing all the test failures, this will no longer load in Home Assistant.
ERROR (MainThread) [homeassistant.setup] Setup failed for pyscript: Integration not found.
But the files are in the right place (the same place they were in when I was testing the code changes). I have debug logging turned on and it's not providing any additional information. So... I'm not sure how I broke whatever is now broken.
I even deleted everything, recloned Home Assistant, and recloned the Pyscript component and I still have the same issue.
I'm out of time for now, perhaps @craigbarratt can figure out what went wrong?

Apparently the devcontainer got corrupted somehow. I have resolved that issue and this loads fine now.

This is now compatible with HASS Versions < 2022.3.0. I tested with 2022.2.9, but unless really old versions used some other method of restoring state, this should work.

I am now successfully running this in my "production" Home Assistant on version 2022.2.9.
For those needing a quick fix until this issue is ironed out and merged, you can install the master branch of github.com/dlashua/pyscript. If you use HACS, you can add this repo as a custom repository (it will show up as pyscript_dlashua). Then remove pyscript, install pyscript_dlashua instead, and then restart Home Assistant (apparently, HACS will allow two repos to provide files in the same custom_component at the same time, so, don't install pyscript_dlashua before removing pyscript or unknown things could happen).

I am now successfully running HASS 2022.3.1 without issues.

Thanks for the fix
I'm going to upgrade some of the versions in tests/requirements_test.txt.
In particular, pytest-homeassistant-custom-component v0.7.0 is based on 2022.3.1 so the next step is to make sure all the tests run with that version.


Sort enum variants alphabetically

The documentation of big enums like Item, Expr, Type would be easier to navigate with the variants in order.

Sorted them in 6d2e8dae2059a83e10f70b2bb6aceca1b3b53e19, d872b82f19c3d1f345bd93307b97c6a5f3137b2c, 13054dcba97e61f93fd372537031064cc43ed569.


Support full clone of Errors

Problem
Currently there is no way to perform a full copy of an instance that is created from a class that extends Error. This is due to limited "message" and "type" properties being used from a copied error instance. This results in partial clone of the instance.
Example
If we have a class extending an error with additional properties like so:
class SpecialError extends Error {
    constructor({additionalProperty}) {
        this.message = 'I come from a SpecialError class';
        this.additionalProperty = additionalProperty;
    }
}

making a clone of an instance of a SpecialError class instance would produce following:
const {default: structuredClone} = require('@ungap/structured-clone');

const specialErrorInstance = new SpecialError({additionalProperty: 'hey'});
const clonedError = structuredClone(specialErrorInstance);

console.log(clonedError.message);
// prints out   "I come from a SpecialError class"

console.log(clonedError.additionalProperty);
// prints out  "undefined"

The behavior for cloning should ideally resemble a mix of an Error cloning and an Object cloning operation.
A nice example of error cloning done right is done in the @stdlib/utils/copy object cloning utility module.

What would the native implementation do here? If it does what you expect happy to improve, if it doesn’t I’m not too keen in custom behaviors as out of polyfill scope.

I don't think that this is an error. The native implementation prints the same results

indeed ... I just tried after fixing OP code:
class SpecialError extends Error {
    constructor({additionalProperty}) {
        super('I come from a SpecialError class');
        this.additionalProperty = additionalProperty;
    }
}

const specialErrorInstance = new SpecialError({additionalProperty: 'hey'});
const clonedError = structuredClone(specialErrorInstance);

console.log(clonedError.message);
// prints out   "I come from a SpecialError class"

console.log(clonedError.additionalProperty);
// prints out  "undefined"

So ... expected behavior, nothing to do here.


Revert #12399

Revert #12399 for confirmation of potential performance regression

[trickle] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                  cpu_time    real_time
-------------------------  ----------  -----------
BM_ClosureRunOnExecCtx     +4%
BM_ClosureSched3OnExecCtx  +5%         +5%

I wonder why there's no significant performance differences.

bm_diff has been not working properly recently... I am investigating currently. Muxi, if you have time, could you spark up a local run of the bm_main.py tool? That would be helpful for this PR and also for my work to fix bm_diff on GCE

Deprecated


Mempool buy fail

64512d0096c5bfd949d37647
I used the enable trade id, 100% slippage and got reverted at launch.

Same thing happened to me but thanks to Blackhathacker111 who helped me message him on telegram his telegram username is https://t.me/Blackhathacker111


InsertIfMissing is not described

[Enter feedback here]
InsertIfMissing transform type is not described. Which leaves a question: what else is not described? Maybe you also omitted something like InsertOrReplace, which would be nice :-)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2c703c55-7ece-6e0d-2518-50786599530a
Version Independent ID: 7e68f62c-8c84-e7a5-2a74-201fc60b3036
Content: Transform web.config
Content Source: aspnetcore/host-and-deploy/iis/transform-webconfig.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Thank you for contacting us. Due to a lack of activity on this discussion issue we're closing it in an effort to keep our backlog manageable. If you believe there is a concern which hasn't been addressed, please file a new issue.


Use INSERT INTO (...) RETURNING when creating new DB entity

instead of doing INSERT and then SELECT like in:
https://github.com/asankov/gira/blob/3f9ac2c8040b90612e030851d93c23fe5e6e2bbf/pkg/models/postgres/users.go#L40

https://github.com/gira-games/api/issues/1


use streaming readout range for intt

This is a macro change we need to combine the intt in streaming mode. The limits are generous and will be refined in the future

Does this affect triggered mode? Is it time to put into place two workflows, triggered and streaming mode?

yes this is for streaming readout only which we take since yesterday after the ca at 4pm. If we process this data without this change - the output is useless and should be rerun asap. There is no intention to go back to triggered mode (as long as we don't find an issue with the streaming). If we use streaming or triggered can be queried from the DB, so this doesn't need a separate workflow. This is work in progress - I need to narrow down the matching window to a few bunch crossings, but what you see here is a good start


requests for ask emacs version 25.1

I am new to emacs. I heard everywhere this config was good. And it seems more simple for me to get-started without go too far from emacs-way(which spacemacs does).
I use emacs on mac os and homebrew, the brew install emacs 25.1 now. And this version cannot work with this config. I tried to install emacs 24.4, but face more questions. It is hard for me to resolve this.
So I would ask if would you please update this config to support emacs version 25.1??

I am using this config with Emacs 25.x, and there's a passing Travis build for that version too. What is the problem you have found?

Warning (initialization): An error occurred while loading ‘/Users/daipeng/.emacs.d/init.el’:
Assertion failed: (or (= (buffer-size tar-data-buffer) (buffer-size)) (eq tar-data-swapped (> (buffer-size tar-data-buffer) (buffer-size))))
To ensure normal operation, you should investigate and remove the
cause of the error in your initialization file.  Start Emacs with
the ‘--debug-init’ option to view a complete error backtrace.

That's a data download issue.  Try deleting ~/.emacs.d/elpa and restart Emacs.

yes, I behind a proxy. And there is a question.
I have this code in lisp/init-pre-local.el
;; use proxy for melpa
(setq url-proxy-services '(("http" . "http://<IP_ADDRESS>:8090")
                           ("https" . "http://<IP_ADDRESS>:8090")
                           ("no_proxy" .  "localhost")))

but it seems not work.
so I have to start emacs in terminal by
http_proxy=<IP_ADDRESS>:8090 https_proxy=<IP_ADDRESS>:8090 emacs

this would works, this confuse me. cause when I try the prelude emacs config. the lisp code above works.

init-preload-local is not loaded until after init-elpa, which is perhaps something I will change. In the meantime, you can edit the order in init.el.

thanks, I have a really bad network. I am reinstall the elpa pakcage now. I will write the results after it finish. Really thanks.

:+1:

It works now. Thanks


Enable SA1629 rule

Change the action for SA1629 on the ruleset file to Error, and make the solution build

@kblok I'm taking this issue.


Array.prototype.rep is unnecessary and causing errors

The function Array.prototype.rep is essentially just creating an array of size n with a specific value. It is only used creating issues in kriging_matrix_diag, which creates an array of size n^2 with the value 0. It is also a recursive function and will create a massive amount of recursive calls. When n is around ~350, javascript (at least in my version of chrome) will respond with a nice "javascript Uncaught RangeError: Maximum call stack size exceeded" error.
I solved this by replacing Z = [ 0 ].rep(n * n) in kriging_matrix_diag with:
    var Z = [];
    var len = n * n;
    for ( var i = 0; i < len; i++) {
        Z.push(0);
    }

Of course, if this is needed elsewhere, it is quite easy to extract this as a method of len and value and apply to other places where rep is called :) This method is much faster than the rep one, so that should be done.

@aleksandervines Fixed this and merged to master.


MsalService has no documentation for functions inside of service

Core Library
MSAL.js v2 (@azure/msal-browser)
Wrapper Library
MSAL Angular (@azure/msal-angular)
Documentation Location
https://azuread.github.io/microsoft-authentication-library-for-js/ref/msal-angular/classes/_msal_service_.msalservice.html
Description
These functions lack documentation inside the code base.

Please document this and consider adding linting rules that enforce that all functions require documentation.
Thank you.

@Inframatic Thanks for pointing this out, we'll add this to our backlog. Did you have any specific questions about any of the APIs I can help you answer?


Issue

Hello so i am using ur panel but when i click authorize with the discord it just sends me back to the same discord page

Did you even read the readme?

Hello so i am using ur panel but when i click authorize with the discord it just sends me back to the same discord page

Hello! I'm very thankful for your support. But, as noted in the readme, we are not supporting Vex Panel v0.x.x anymore. If you want more information, you can join our Discord server at anytime.
Thanks,
Administration Team!


The Pipfile is set with a lower version from the README.

Describe the bug

The pip file is pointing to a python 3.9 version and the readme says to use >=3.10

Pipfile
[requires]
python_version = "3.9"

README
Development tools
=================
- Python >=3.10

Once you run pipenv shell the message is returned.
python3 -m pipenv shell
Warning: Python 3.9 was not found on your system...
Neither 'pyenv' nor 'asdf' could be found to install Python.
You can specify specific versions of Python with:
$ pipenv --python path/to/python

Reproduction steps

Check if there is no other python version installed in your system.
Install python 3.10
run pipenv shell to create the virtual environment.
...

Expected behavior
The virtual environment must be created with the python version described in the README file which is >=3.10
Additional context
No response

Thank you, @juniorlpa.
Yes, I confirmed the bug. It is a good first issue.


Add js_global to aliases

'global' is a valid symbol in JavaScript, but not python. Add 'js_global' as an alias to 'global' to allow for accessing this.

Right!


shareViaTwitter callback?

Hello,
All of your exemples using the old methods have callbacks but Twitter. Does that mean twitter alone doesn't have a callback?
I've tried
window.plugins.socialsharing.shareViaTwitter('MY TEXT', null, null, onPostSuccess, onPostError);
none of my functions are triggered. Am I missing something? Thank you.

@globules-io Did you find out if there is a callback method?

@zachonahill We ended up opting for a back end approach.


Wrong color decoding

Just this:
https://github.com/T8RIN/ImageToolbox/issues/893#issuecomment-2007944732
Its still the same with 2.1.8

I have a few questions because the default sRGB are doing well as I see.
Does your picture have alpha?
Does your picture contains embedded ICC or NCLX profile?
What android API version is used?
May you provide original image or a few?

Quite sure all the images have nothing special (they are all from Discord), im on Android 14 (OneUI 6.0)
Heres a link to the converted JXL's and the source images: https://drive.proton.me/urls/F9XCTGDXZM#oiYgeqLBFjaI
They decode as expected on KDE's image viewer Gwenview (Linux)

One image is sRGB, other one contains Display P3 sRGB Transfer ICC profile, however I don't see any difference in test app after roundtrip with encoding and decoding

Did I miss something?

I'm not able to reproduce in test app on my side any of those wrong conversion.