Import issue nexjts

nodejs : v16.14.2
flow-cadut : 0.1.16-alpha.4

Description
import was failed if we won't specifiy the flowcadut packagejson {"type":"module"}, There another way to fixed that using mjs ext.
https://user-images.githubusercontent.com/40029631/167464767-8d446c01-1f7a-4cb2-b0e5-028dae352919.png
Pull #64
Fix

Pump version of microbundle
fix the path of child modules

@MaxStalker hope u review it soon

I have the same problem in NextJS. Seems like import works in server-side code (like api routes) but fails in browser side ( like components).


error in testing code for tile segmentation

The following error message
AttributeError: 'Net' object has no attribute 'load_blobs_from'
I guess we need to include barrista or is there a work around for it?

Yes, 'load_blobs_from' is a function from Barrista which loads the trained filter weights. In the present script, this line is somewhat redundant as the previous line already loads the filter weights. So, this line in predict.py can be omitted. Thanks for reporting.


fix(web): fix audio playback on iOS / Safari

Fixes #558

does not play in silent mode https://stackoverflow.com/questions/40789136/ios-ringer-switch-mutes-web-audio
https://github.com/goldfire/howler.js/issues/1220

Thanks!


[Packaging | jsonschema compatibility ] - test and follow up Reana's proposed solution

After Marco's comment on Mattermost (see below), test and follow up with REANA team the proposed solution
https://github.com/mdonadoni/reana-client/tree/vre-summer-24
"""
I am hosting the custom version of reana-client here: https://github.com/mdonadoni/reana-client/tree/vre-summer-24
which install a version of commons that does not require any particular version of jsonschema: https://github.com/mdonadoni/reana-commons/tree/vre-summer-24
You should be able to install it with pip install git+https://github.com/mdonadoni/reana-client.git@vre-summer-24.
Let me know if this is a feasible workaround for you. (of course yadage still does not work)
"""

I have been testing the custom version of reana-client and it seems to work.
However, the module  (the main version and the custom one) seems to be read/loaded after the first request (and not before), which means that the first request uses the default URL, and from the second request onwards the custom env variable is used.
In order to solve that, we had 3 possibilities:

Set the environment variable before calling the script (as we let the user change the server URL and the code to connect to REANA is executed when JupyterLAb is launched, this would not be possible).
Import reana_client.api.client after setting the variables (works fine in scripts but does not seem to work in JupyterLab Server).
Creating a client after setting the variables, which forces to reload the URL (works fine, but might break if they change that part of the codebase).

In my opinion, we should use the last option. The first one is impossible to implement in this project, and even if the second option was not impossible, it would take more time to make it work in JupyterLab Server. If in the future we plan to update reana_client or reana_commons, it may be necessary to refactor the POST method in EnvVariablesHandler (jupyterlab_reana/handlers/connection.py).

This is the line that solved our problem:
https://github.com/vre-hub/reana-jupyterlab-extension/blob/a34082dd13969119a8bda17642ba3d8b902b1e49/jupyterlab_reana/handlers/connection.py#L11


Template render tweaks

loading-shim for template rendering
performance fix for peering request email workflow started from network search
fix device template "None" error

Codecov Report

Merging #76 (505bc90) into prep-release (4d5cbce) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@               Coverage Diff                @@
##           prep-release      #76      +/-   ##
================================================
- Coverage         24.41%   24.40%   -0.01%
================================================
  Files                82       82
  Lines              4592     4593       +1
================================================
  Hits               1121     1121
- Misses             3471     3472       +1

Impacted Files
Coverage Δ

src/django_peerctl/models/peerctl.py
45.13% <0.00%> (-0.04%)
:arrow_down:

src/django_peerctl/rest/serializers/peerctl.py
0.00% <ø> (ø)

src/django_peerctl/rest/views/peerctl.py
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Active Directory tenant names incorrect value

The Government value for the Active Directory tenant names endpoint is incorrect, it should be [yourtenantname].onmicrosoft.us

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d0ab80e-bbb7-8eb9-f0b3-814f74e3a117
Version Independent ID: e9952267-ab66-50a3-d3b0-7d2d621d5a9b
Content: Azure Government developer guide
Content Source: articles/azure-government/documentation-government-developer-guide.md
Service: azure-government
GitHub Login: @smichelotti
Microsoft Alias: stemi

@wamota
Thanks for your feedback! We will investigate and update as appropriate.

Thanks! I made a pull request to update this. https://github.com/MicrosoftDocs/azure-docs-pr/pull/107767


Feature: Lower supported php version

Follow symfony/skeleton minimum supported php version to >= 7.2.5.

Superseded by #86.


Add a dynamic resolution setting for 3D viewports

Several modern engines now support dynamic resolution, which is a technique used to achieve more consistent framerates in heavier scenes, especially on slower hardware.
It consists in resizing the rendered viewport depending on the current frame rate; some engines also only render less columns (instead of less columns and less rows) to make the loss of quality harder to notice.
This would be especially welcome for VR, but it could be useful in non-VR scenarios as well.

Closing in favor of https://github.com/godotengine/godot-proposals/issues/917, as feature proposals are now tracked in the Godot proposals repository.


feat: implement cloudprovider Get and List

What type of PR is this?
/kind feature

What this PR does / why we need it:
implement cloudprovider Get and List
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

/cc @jwcesign @daimaxiaxie @IrisIris
Please take a look

/cc @jwcesign @daimaxiaxie Please review the code again

/lgtm


[transmission] List Torrents shows error ECONNREFUSED

Extension
https://www.raycast.com/FezVrasta/transmission
Description
I configured Transmission Desktop to use localhost:9091 with no user/pass. I can access it fine via my browser. But when I try to list my torrents in raycast, I get ECONNREFUSED.
My preference is to only allow IP <IP_ADDRESS>, but I tried it with/without this setting. It doesn't work in either case.
Any ideas?

have you tried setting a password?

Yes, I did. I forgot to say so.

It's a bit difficult to help you with so limited informations. I'm sorry.

I also have this exact same issue. Setting a password in Transmission makes no difference. I'm using the latest version of Transmission (4.0.1).
Are you using this extension with no issue?

Could you create a transmission.js file like this, run it with node, and see what happens?
new Transmission({
    host: '<IP_ADDRESS>',
    port: 9091,
    username: 'user',
    password: 'password',
    ssl: false,
  }).then(console.log);

Ok so, I managed to reproduce it, the problem only happens if you set as host localhost. If you set <IP_ADDRESS> it works correctly.
It doesn't seem to be a problem with my extension though, because the code above works correctly with localhost too, I wonder if Raycast changed how networking works lately.

I confirm that setting <IP_ADDRESS> makes it works.
One more issue is when i add new torrent, whatever path i type into Download Directory field, it always add a slash (/) before path. It prevents the torrent to be verified.


ANN vs Seasonal color bars

Some of the color bars in plots from e3sm_diags arent the same between the hand made plots and the automatically generated ones. They should be identical.

Basically the same issue as: https://github.com/ACME-Climate/acme_processflow/issues/41. See example figures in original post for illustration of the problem.


Fix float to bool cast

We should remember to merge this also to the release branch

We should remember to merge this also to the release branch

Better to do it now before I forget. On it


Is this done right?

Not positive if I did this correctly.

@tec5271 I think what happened here was you reissued the same PR but with main branch compared to main. Your previous PR was correct because there you were comparing your tylerBranch against the base main branch.


[OpenCL] Transpose to go through Eigen

Transpose for SYCL should use Eigen implementation

Jenkins, test this please.


Can I send a few buck on your way as a sign of appreciation?

Hey there,
This project saved me so much time recovering bunch of notes from a recovery hard disk recently!
As an appreciation I'd like to send your way few bucks, if you're interested, however I am not willing to become a GitHub sponsor (monthly contribution).
Please shoot me an email at<EMAIL_ADDRESS>if you're interested.
Thank you!

Good morning!
Thank you for the appreciation. I completely understand not wanting to sign up for a monthly contribution. I just made a Ko-fi account to allow for one-time donations, hopefully that will work. If not, no worries, the feedback that this was useful is very heartening either way!

Done. https://Ko-fi.com/home/coffeeshop?txid=f7776fba-c8b7-46bd-a002-5c1c9d6f1b87&mode=public&img=ogiboughtsomeone
Thank you, again! 🙂

Thank you! :coffee:

Thanks for making this tool, and for setting up a Ko-fi page - this tool just really saved my keister, after which it only took half a minute to find the Ko-fi page and give a little monetary expression of my gratitude as well, super easy! 🤝☕
Really appreciate the great work on this, the HTML output in particular is so nice - very readable, on any device! (Unlike certain other data formats... cough cough Apple Notes cough cough 😝🍎💩)


Support optional fields in struct reflect in typescript

Motivation
Support optional fields in struct reflect in typescript, for example:
#[wasn_bindgen]
pub struct Ping {
    pong: Option<bool>,
}

in .d.ts
export class Ping {
    pong?: bool;
}

Proposed Solution
Struct generation in wasm_bindgen separate fields into getters and setters, and the ret_ty for getter or args for setter which decide the final field type out are embedded in JsBuilder, we can't checkout if some fields' types are optional, but...optional fields generate some special docs like @returns{{{}}} and @params{{{}}} we can trace.
If it is appropriate to render fields' types with checking if its doc contains .. | undefined ?
For example, we can change this line
https://github.com/rustwasm/wasm-bindgen/blob/f507a2a5ff2fa84d3197909a4b6f095e90ee4b98/crates/cli-support/src/js/mod.rs#L3070
if docs.contains("undefined") {
    *ty = "?".to_string() + ret_ty
} else {
    *ty = ret_ty.to_string()
}

and this line
https://github.com/rustwasm/wasm-bindgen/blob/f507a2a5ff2fa84d3197909a4b6f095e90ee4b98/crates/cli-support/src/js/mod.rs#L703
if &ty[0..1] == "?" {
    ts_dst.push_str("?: ");
    ts_dst.push_str(&ty[1..]);
} else {
    ts_dst.push_str(": ");
    ts_dst.push_str(&ty);
}

Alternatives
I think the solution above is quite a mess, but I can't figure out a better one.

I like the idea of generating optional fields... however, I would suggest that whatever tool you are using should work with | undefined, because from JS's perspective there isn't much difference, and many TypeScript programs will use | undefined.

The | undefined checking just applies to setter and getter in .d.ts,  if this solution can make a pr, I'd like to do it, or any other way can add optional fields definition to Typescript...really need this.
btw, @Pauan, would you mind to have a look at #1986, I just wrote a pr about #[wasm_bindgen(plain_object)] yesterday.

Seems like a reasonable feature to me to support as well! A PR would be most welcome to implement this


Actually cache tool versions with threadlocal

The cached_property was doing literally nothing.

Codecov Report

Merging #322 into master will decrease coverage by 0.12%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage   91.00%   90.87%   -0.13%
==========================================
  Files          48       48
  Lines        3069     3026      -43
==========================================
- Hits         2793     2750      -43
  Misses        276      276

Impacted Files
Coverage Δ

lintreview/tools/ansible.py
89.28% <ø> (-0.72%)
:arrow_down:

lintreview/tools/black.py
93.18% <ø> (-0.30%)
:arrow_down:

lintreview/tools/checkstyle.py
97.82% <ø> (-0.10%)
:arrow_down:

lintreview/tools/credo.py
92.68% <ø> (-0.35%)
:arrow_down:

lintreview/tools/csslint.py
100.00% <ø> (ø)

lintreview/tools/eslint.py
85.29% <ø> (-0.29%)
:arrow_down:

lintreview/tools/flake8.py
96.66% <ø> (-0.08%)
:arrow_down:

lintreview/tools/foodcritic.py
96.55% <ø> (-0.23%)
:arrow_down:

lintreview/tools/jshint.py
100.00% <ø> (ø)

lintreview/tools/ktlint.py
100.00% <ø> (ø)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e174e9c...3d04498. Read the comment docs.


uv lock finds incorrect wheels for sys_platform == 'darwin' (pytorch)

Background
I'm trying to run the same project on macOS and Ubuntu. For that, I have two sources for pytorch as described in the uv docs. I'm using uv version uv 0.5.11 (c4d0caaee 2024-12-19) on macOS 14.4.1
Steps to Reproduce
uv init
cat > pyproject.toml <<EOF
[project]
name = "testuv"
version = "0.1.0"
description = "Add your description here"
readme = "README.md"
requires-python = ">=3.12"
dependencies = [
  "torch",
]

[tool.uv.sources]
torch = [
    { index = "pytorch-cu118", marker = "sys_platform != 'darwin'" },
    { index = "pytorch-cpu", marker = "sys_platform == 'darwin'" },
]

[[tool.uv.index]]
name = "pytorch-cu118"
url = "https://download.pytorch.org/whl/cu118"
explicit = true

[[tool.uv.index]]
name = "pytorch-cpu"
url = "https://download.pytorch.org/whl/cpu"
explicit = true
EOF
uv lock
uv sync

What Happens
uv incorrectly resolves the macOS to version 2.5.1+cpu (only available on linux) instead of 2.5.1. When you attempt to uv sync then it fails with this message.
error: Distribution `torch==2.5.1+cpu @ registry+https://download.pytorch.org/whl/cpu` can't be installed because it doesn't have a source distribution or wheel for the current platform

Specifically, the lock file contains this block.
[[package]]
name = "torch"
version = "2.5.1+cpu"
source = { registry = "https://download.pytorch.org/whl/cpu" }
resolution-markers = [
    "sys_platform == 'darwin'",
]
dependencies = [
    { name = "filelock", marker = "sys_platform == 'darwin'" },
    { name = "fsspec", marker = "sys_platform == 'darwin'" },
    { name = "jinja2", marker = "sys_platform == 'darwin'" },
    { name = "networkx", marker = "sys_platform == 'darwin'" },
    { name = "setuptools", marker = "sys_platform == 'darwin'" },
    { name = "sympy", marker = "sys_platform == 'darwin'" },
    { name = "typing-extensions", marker = "sys_platform == 'darwin'" },
]
wheels = [
    { url = "https://download.pytorch.org/whl/cpu/torch-2.5.1%2Bcpu-cp312-cp312-linux_x86_64.whl", hash = "sha256:4856f9d6925121d13c2df07aa7580b767f449dfe71ae5acde9c27535d5da4840" },
    { url = "https://download.pytorch.org/whl/cpu/torch-2.5.1%2Bcpu-cp313-cp313-linux_x86_64.whl", hash = "sha256:5dbbdf83caa90d0bcaa50e4933ca424889133b35226db79000877d4ec5d9ea37" },
]

What Did I Expect to Happen
I expected uv to resolve the version to 2.5.1 and the wheels to
wheels = [
    { url = "https://download.pytorch.org/whl/cpu/torch-2.5.1-cp312-none-macosx_11_0_arm64.whl", hash = "sha256:8c712df61101964eb11910a846514011f0b6f5920c55dbf567bff8a34163d5b1" },
]

Workarounds
If I manually replace the version and wheels properties with the correct values, thenuv sync works as expected.

This is tracked in https://github.com/astral-sh/uv/issues/9711. There are a variety of linked issues that are describing the same problem.

Fixed by https://github.com/astral-sh/uv/pull/10046.


"loader" got killed immediately when running on Mac M1 (Ventura)

Hi @evelyneee,
I've tried to run the loader either built from Xcode or the one you attached in the "issue-2" on a Mac M1 mini terminal and it got killed immediately. I also setup the plist to run it with launchd like you show in the instruction. Both the output log and the error log were empty so I assumed it also got killed during the startup process. I tried to disable SIP but still have the same result when running the loader. The only thing that got me a little bit further is creating a new Command Line Tool target and moving all the code of loader to the new target. That got me as far as to the set thread state as following:
[+] got task 7427
[i] using path /Library/TweakInject/pspawn.dylib
[+] loader: started thread
[+] loader: converted thread state
[-] loader: failed to set thread state

Is there anything specific I need to do for the loader to work on the Mac M1 (currently on Ventura)?

You need to enable the arm64e abi and disable sip

Thank you @evelyneee! Turning arm64e abi and recompile for arm64e did help to make it work for me. But now I face a new problem when I create a very basic tweaks that just print a hello world. When I put the .dylib and .plist file into the /Library/TweakInject folder and reboot the userspace, it seems to crashes many apps on the OS such as SpotLight (search), Archive Utility, also my test app which I put the bundle id in the ".plist" file


(demo-showcase) Get MolStar from CDN in production

MolStar is added as peer dependency in ngx-structure-viewer. This means, it must be provided within the application importing  the ngx-structure-viewer. It is not bundled with the ngx-structure-viewer.
MolStar is installed in the demo-showcase application in order to make the ngx-structure-viewer working. When building, it is bundled as long as the application, within the main.js. This is the correct solution for development purposes, as it allows complete debug. However, it is not suitable for production build, as the MolStar package makes the whole bundle exceed the maximum bundle size.
Instead of modifying the maximum bundle budget warning and error, use the custom @angular-builders/custom-webpack:browser to exclude the MolStar package from the bundle, while not removing types. Then, provide a custom <script> tag in <header> to include MolStar from CDN.

Could not find a suitable solution. However, lazy loading pages importing MolStar library will bundle the library separately from main.js chunk. This allows to:

Increase loading times, as MolStar is loaded only when required.
Avoid hitting budget limitations when building in production with ng build -c=production demo-shwocase.

NOTE projects/demo-showcase/src/app/app.routes.ts has been updated accordingly.


Cleanup console commands changing bitcoin to reddcoin where appropriate

Console needs a cleanup of commands and responses, exchanging bitcoin for reddcoin

Resolved: Code updated


N api port

PR with the work from #830
Squashed version of #979

Blocked on https://github.com/nodejs/node-addon-api/issues/57
Note the commented RegExp, Integer, and Date support at https://github.com/mapbox/node-sqlite3/blob/48f5e44ae44b21bb6dd409e288249be57f33c3ba/src/statement.cc#L167-L189.
This results in:
  data types
Error: async hook stack has become corrupted (actual: 548, expected: 549)
 1: 0x86de5e node::InternalCallbackScope::~InternalCallbackScope() [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 2: 0x89bd6e node::InternalMakeCallback(node::Environment*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 3: 0x869ba6 node::AsyncWrap::MakeCallback(v8::Local<v8::Function>, int, v8::Local<v8::Value>*) [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 4: 0x942c01  [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 5: 0x9c66a5  [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 6: 0x9b880c uv_run [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 7: 0x8a4a2d node::Start(v8::Isolate*, node::IsolateData*, int, char const* const*, int, char const* const*) [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 8: 0x8a3cd6 node::Start(int, char**) [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 9: 0x7f21fbaa87ed __libc_start_main [/lib/x86_64-linux-gnu/libc.so.6]
10: 0x861845  [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
npm ERR! Test failed.  See above for more details.

@springmeyer I have managed to implement the IsDate and IsRegExp functions and am working on a PR. However, I found a bug in the current existing port that I'm in the midst of fixing so I'll have an update with both fixes in soon. The PR I'm working on is at https://github.com/mhdawson/node-sqlite3/pull/3.

Thank you for the update @anisha-rohra - I'll wait for word here that you've solved the problem.

@anisha-rohra what is the status of https://github.com/mhdawson/node-sqlite3/pull/3? Is it ready to pull in here? /cc @mhdawson

Still working on it with Anisha.  In the latest review we realized there is still direct use of libuv that we want to remove as well.  Not sure if that is related to the hand Anisha was investigating but it might be so @anisha-rohra is going to look at that first.

@springmeyer will do, Anisha is working on removing the direct libuv usage which was the last part. Just back from vacation but hope to catch up with her on where she is with that this week.


Move documetion to MkDocs material

[x] move current docs to mkdocs material
[x] Create CD for auto deployment of docs

Closed by the development branch


Bold gets turned into italic

I found a bug in md_to_jira.py resulting in bold text always turning into italic:
# Convert bold and italic
line = re.sub(r'\*\*(.+?)\*\*', r'*\1*', line)
line = re.sub(r'__(.+?)__', r'*\1*', line)
line = re.sub(r'\*(.+?)\*', r'_\1_', line)
line = re.sub(r'_(.+?)_', r'_\1_', line)

The first two lines take text marked as bold in markdown (**bold** and __bold__) and turn them into *bold* (the way jira defines bold). However the 3rd line then takes this *bold* and turns it into _bold_, which results in the text showing up as italic in Jira.
Potential solution
Swapping the bold and italic replacement calls is not a solution, as starting with replacing *text* will result in **text** being turned into *_text_*.
One potential solution is to do a 2-step replace like this:
# Convert bold
# Jira's bold (*...*) is the same as md's italic, so we have to replace in two steps
bold_placeholder = "bold78c10ae05c702eb1cbold" # random text unlikely to be found in a real content
line = re.sub(r'\*\*(.+?)\*\*', r'{placeholder}\1{placeholder}'.format(placeholder=bold_placeholder), line)
line = re.sub(r'__(.+?)__', r'{placeholder}\1{placeholder}'.format(placeholder=bold_placeholder), line)
# Convert italic
line = re.sub(r'\*(.+?)\*', r'_\1_', line)
line = re.sub(r'_(.+?)_', r'_\1_', line)
# Convert placeholder back to bold
line = re.sub(r'{placeholder}(.+?){placeholder}'.format(placeholder=bold_placeholder), r'*\1*'.format(placeholder=bold_placeholder), line)

More generally: this project needs some unit tests to cover all the potential use-cases (e.g. check that **bold** turns into *bold* and that *italic* turns into _italic_)

@markszabo Thanks for the report! Fixing this is on my TODO list. Also on my TODO list is adding comprehensive unit tests to the project. I'll try to make some time to work on this soon!


#11 learn2reg t2 demo added

Description
The learn2reg t2 demos have been added
Fixes #11
Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Ran all the scripts to check they work as intended (unit test not added because the functions that are created are only used within the script itself)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works (no new tests added as described above)
[x] New and existing unit tests pass locally with my changes

@s-sd can you rename the folder to something like: unpaired_ct_lung and paired_lung_ct?
https://github.com/ucl-candi/DeepReg/wiki/Demo-minimum-requirement

@YipengHu
I have fixed the directory structure for the two demos by putting them in separate folders, renamed the folders and config files and added the scaling part to demo_data.py
I think for the intensity scaling maybe it'll be more user friendly to feed in two values to the generator that can be used to rescale on the fly. But rescaling during the data preparation stage is not too difficult either so I'm not sure what the best strategy would be

@s-sd Looks good - last thing before we can merge this: can you update both README, so at least it has different demo names and they won;t get confusing. As discussed, we will make an effort later to make all the demos have a consistent "feel" later.

@YipengHu
I am fixing some linting issues will then merge afterwards

for  image-wise intensity scaling, i think we can make this an option in preprocess, where is the code ? can you point me to the function?

for image-wise intensity scaling, i think we can make this an option in preprocess, where is the code ? can you point me to the function?

the code is very ad hoc, but the key idea is simple, just rescale it to [0, 1] or [0, 255] or unit-variance with zero-mean

@s-sd this has not been merged - why is this deleted?


Adding ngAnimate Support

Added support for ngAnimate by waiting for animations to complete
before focusing on the search input field. This uses $injector to get a
reference to $animate so that the project is not dependent upon
ngAnimate. Check plunkr http://plnkr.co/edit/G02EbD for a working
example.
This should resolve issues with ngAnimate 1.4.4 and 1.4.5. This should
cover the following issues:
https://github.com/angular-ui/ui-select/issues/859
https://github.com/angular-ui/ui-select/issues/1253

:+1:


Fixed missing status attribute in CaseObservable

Added line self.status = attributes.get('status', 'Ok') so that the model of CaseObservable includes the missing status attributes indicating if an observable has been deleted or not.
By default, it's set to Ok (not deleted).
Also adjusted the docstring above.
Tested by myself with some thehive4py scripts and responders that were able to differentiate deleted and existing observables.
First PR, new to Python and to The Hive, sorry if I did some mistakes or corrupted the code (hopefully not)
fixes #174

Fixes #174

This attribute is valid in TheHive < 4
I don't know how does this change work when using TheHive 4.
Do you need to set the status during observable creation?

I don't know either if this works for the Hive 4 sorry. I will test if I have time.
I don't need it for creation, just when I ask the API to give me all existing CaseObservables, it includes the ones that are deleted as well, so I need to exclude them.

You can also ask the api to exclude them, and this is the best option, add a criteria for status=Ok


Error "cannot import name 'properties' from 'keyring.util'" with keyring==23.9.0

Since keyring version 23.9.0 is out, this backend does not work anymore.
ERROR: Error initializing plugin EntryPoint(name='Google Auth', value='keyrings.gauth', group='keyring.backends').
Traceback (most recent call last):
  File "/home/runner/actions-runner/_work/yolo/yolo/python/moulinette/.tox/linters/lib/python3.9/site-packages/keyring/backend.py", line 202, in _load_plugins
    init_func = ep.load()
  File "/home/runner/actions-runner/_work/yolo/yolo/python/moulinette/.tox/linters/lib/python3.9/site-packages/importlib_metadata/__init__.py", line 203, in load
    module = import_module(match.group('module'))
  File "/opt/hostedtoolcache/Python/3.9.13/x64/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/home/runner/actions-runner/_work/yolo/yolo/python/moulinette/.tox/linters/lib/python3.9/site-packages/keyrings/gauth.py", line 24, in <module>
    from keyring.util import properties
ImportError: cannot import name 'properties' from 'keyring.util' (/home/runner/actions-runner/_work/yolo/yolo/python/moulinette/.tox/linters/lib/python3.9/site-packages/keyring/util/__init__.py)
User for europe-python.pkg.dev: ERROR: Exception:
...

ok, it seems a bug fix is already on its way, nice! (even before I filled the bug)
https://github.com/GoogleCloudPlatform/artifact-registry-python-tools/commit/0e4aa757bf921a52ec24cc390ead2d75a7e2dee7

and it is released https://pypi.org/project/keyrings.google-artifactregistry-auth/#history
and it is a duplicate of #33
sorry, closing
(and thank you)


Avoid declare exchange in every message

Since #2 the library is declaring the exchange in every message received from the emit channel.
This will kill the performance, right?
WDYT, can we use some "cache" of topic already declared and avoid this unnecessary requests?
Sorry to see this 20 days after the original PR :see_no_evil:
PS. I can make a PR with this change

I create one benchmark and this is the diff using a map of declared exchanges:
benchmark                old ns/op     new ns/op     delta
BenchmarkEmitAsync-4     326063        50410         -84.54%


HA Integration

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
Because I have alot of Powercalc entities setup, it's hard to see what has been setup because if the small area you are given. So I'm not sure if this is a HA thing or maybe Powercalc can change the way entities/devices are create like other integrations

Why can't it be like the MQTT setup or Sonos where it shows how many devices??
I hope that makes sense
Describe the solution you'd like
I want an easier way to manage all the Powercalc I have set up and plan to set up.
Describe alternatives you've considered
I know you can search but even search by name but still shows such a small area.
Additional context
n/a

Unfortunately this cannot be changed. Question has been asked before. But I am limited by the possibilities HA provides for integrations.
See following posts for more information / explanation.
https://github.com/bramstroker/homeassistant-powercalc/issues/1403
https://community.home-assistant.io/t/powercalc-virtual-power-sensors/318515/704?u=bramski
https://community.home-assistant.io/t/wth-cant-view-integrations-as-a-list-instead-of-cards/467225/5
I also suggest you to vote on the last post and / or post a comment to give it some more visibility.

Huge improvements regarding this in latest HA beta 2023.6.
Now there is a separate page for each integration. In the main integration overview page you see all entities/devices. Clicking the cog will bring you to a separate page where you can configure each separate powercalc config entry.

Yeah I read this 🙏🙏🙏


AJAX loaded items not fading

Is there a special trick to handle content that is lazy loaded? I tried firing AOS.refresh(), but that doesn’t seem to help very much.
Thanks again :)

Hi again @nathanaelphilip. refresh() is a pretty light function - it only check position of elements that were found during initialization. And it's called whenever aos element is being injected to DOM because of the DOM observer implementation.
Ouch.. Now I see what I did wrong there. I should add another method, for example hardRefresh - which will not only recalculate and check positions of elements, but also mutate the store with those elements by pushing new items.
I'm definitely going to make it work.
For now as a quick workaround you can instead of refresh use init with the same options. It should work well I guess ;)

sweet! i’ll try that for now. thanks :). this plugin is really nice and i think will replace my own custom way (once all the bugs are worked out).

Glad to hear that :) Stay tuned

I'd add a parameter to refresh instead of introducing a new method. For instance refresh(checkDOMs) will reduce confusion.
If you want to go further, there is an API called MutationObserver for detecting DOM changes. Maybe you can hook it and do an auto refresh when a DOM is added or hook it, flag when a change is detected and recheck DOMs only when refresh is called manually. By this you will have an intelligent method that knows if to check DOMs or not. Putting an auto refresh when DOM change in the options will complete this.
Check this out: http://stackoverflow.com/questions/3219758/detect-changes-in-the-dom

MutationObserver is actually implemented @ErtugKaya ;) I use it to detect DOM changes and trigger reload. But I spot an issue after @nathanaelphilip message that reload is not checking position of new elements, only the initial ones. I'm going to fix this soon.
I'd rather avoid messing with parameters. Another private method that prepares fresh store with elements and reuses actual reload would be IMHO the cleanest and proper solution.
I'll let you know when it's done in this topic.

Hi, I just fixed this issue in #24 .
Version 1.2.2 works like expected.
Now whenever you load some items using ajax they automatically animate and behave properly.
Hope you find this useful :)


Fix 404 error on Generator Repo link

Fixed Generator Repo link on getting started page and 0.4.1 documentation page

LGTM
@iam-peekay Welcome and thanks for the contribution!


How do I make it so it uses moment-timezone instead of the computers time?

How do I make it so it uses moment-timezone instead of the computers time?

Having also the problem..

Internally the component uses javascript Date object.
If you want to format the way the date is displayed in the input value you can use the function formatter


"Chart title" string and Export icon appear before chart load

Hi,
I am trying to plot a chart in a div container. However, the string "chart title" and the export icon appear even before the chart data is loaded and displayed. Could you help me figure out this issue?
The chart title is replaced by the value that I provide in my config object once the data is loaded.
Thank you

I am trying to render the chart from a directive to the above html file.


Fix services

@gerard33 Can you explain why you've added such checks to open_app and send_command:
        if self._state == STATE_OFF:
            return

?
It should be possible (it is with my TV) to open an app when TV is off. And since send_command is quite low-level, it's also possible to send many commands when TV is off.

@gerard33 Can you explain why you've added such checks to open_app and send_command:
        if self._state == STATE_OFF:
            return

?
It should be possible (it is with my TV) to open an app when TV is off. And since send_command is quite low-level, it's also possible to send many commands when TV is off.

I got error messages when sending commands to my TV when it's off, hence the check. My TV is a few years old and non-Android btw, so that could be causing this.

I got error messages when sending commands to my TV when it's off, hence the check. My TV is a few years old and non-Android btw, so that could be causing this.

Hmm. Maybe enabling it for android TVs would make sense then?
Someone might want to send a power on command through that API for example (even if there is a higher-level API for that), or might want to turn on the TV with the open_app command (as mentioned before).

Hmm. Maybe enabling it for android TVs would make sense then?
Someone might want to send a power on command through that API for example (even if there is a higher-level API for that), or might want to turn on the TV with the open_app command (as mentioned before).


Allow graceful rolling updates

To allow graceful rolling updates, hail should support a graceful shutdown procedure. Specifically, the application should respond to a signal.SIGTERM call.
This feature was suggested on the zulip chat, and a draft of the implementation is here: https://docs.google.com/document/d/1TXoq_NBUwgi3ZVOUq6qD7hWq38qNZsq4thqrPfMJiQY/edit#
Additional notes:

We should accommodate queries of up to 8 hours (eg: 8 hour grace period)
Future task would be to caching a query result by it's UUID, which would allow retry calls for transient errors.
Web sockets aren't re-used, so we don't need to have special handling for these.

Closed by #35


[SPARK-24155][ML] Instrumentation improvements for clustering

What changes were proposed in this pull request?
changed the instrument for all of the clustering methods
How was this patch tested?
N/A
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Test build #90075 has started for PR 21218 at commit 07c20a4.

Test build #90075 has finished for PR 21218 at commit 07c20a4.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90075/
Test FAILed.

Test build #90152 has started for PR 21218 at commit 9053281.

Test build #90152 has finished for PR 21218 at commit 9053281.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90152/
Test PASSed.

Test build #90529 has started for PR 21218 at commit 4e2cb81.

Test build #90529 has finished for PR 21218 at commit 4e2cb81.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90529/
Test PASSed.

LGTM. Merged into master. Thanks!


In feature view, the last element of the breadcrumb should be the genome, not the species.

Agree. Genome should be added to the breadcrumb, similar to that on the public site.

this is fixed and available on production.
https://www.patricbrc.org/view/Feature/PATRIC.83332.12.NC_000962.CDS.2726806.2727339.fwd#view_tab=overview


[W5][W14-1]Jerald  Tan

Please review

PR Review
Good application of the principle of

Changing the code in very small steps, each resulting in a verifiable change without breaking the app.

Appropriate commit headers and accompanying messages.
Suggestions:

Fix the Sort header in UserGuide.adoc by changing ==Sorting entries : 'sort' to == Sorting entries : 'sort'.
Provide short description for Pull Request explaining what was added.

PR Closed after reading through comments


Inherit scheme from previous location on redirection if needed

This change allows to follow redirect locations such as //other-host.com/a/b?c=d where the scheme should be derived from the previous request.
I had to change the order of operations in build_redirect_request/2 because I assumed that we want to put the scheme that will be used before comparing with the previous one in remove_credentials_if_untrusted/2.
Please let me know what you think.

Thank you!

Happy to participate!


RTL - Wrong position of label and icon in menu item in case when it is not a link

I would suggest we close this one for now, since we intend on replacing the current admin theme with a new one.

Ok. I've closed it. Thanks


[All hosts](community call) clear agenda

Clears the agenda for October 2022.

Docs Build status updates of commit 744ade1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/office-add-ins-community-call.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Make it possible to create more passwords, and see them in the admin view

One question still remains, how will the speaker get the very first password from the backend?

Failing build is fixed in develop.


ntr? 2-methylbutyraldehyde reductase

Im looking for this,
2-methylbutyraldehyde reductase
which is a
aldehyde reductase
?
Reported by: ValWood
Original Ticket: "geneontology/ontology-requests/3201":https://sourceforge.net/p/geneontology/ontology-requests/3201

thanks www.movied.org


Unable to install lens metrics

Describe the bug
I tried to enable lens metrics from UI. It created new namespace lens-metrics but looks like quay.io/coreos/kube-state-metrics:v1.9.5 is missing.
To Reproduce
Steps to reproduce the behavior:

Deploy metrics in cluster settings
Check if all pods are running in lens-metrics namespace
One pod is failing:

kubectl get pods -n lens-metrics
NAME                                 READY   STATUS             RESTARTS   AGE
kube-state-metrics-94b8476c4-jnrwj   0/1     ImagePullBackOff   0          5m30s
node-exporter-fqfmp                  1/1     Running            0          5m29s
node-exporter-lntqb                  1/1     Running            0          5m29s
node-exporter-mfwzb                  1/1     Running            0          5m29s
node-exporter-wdwfx                  1/1     Running            0          5m29s
node-exporter-xdbzf                  1/1     Running            0          5m29s
prometheus-0                         1/1     Running            0          5m29s

Expected behavior
All pods are deployed.
Logs:
  Type     Reason     Age                From                                                   Message
  ----     ------     ----               ----                                                   -------
  Normal   Scheduled  50s                default-scheduler                                      Successfully assigned lens-metrics/kube-state-metrics-94b8476c4-jnrwj to ip-xxx.eu-west-2.compute.internal
  Normal   BackOff    20s (x2 over 49s)  kubelet, ip-xxx.eu-west-2.compute.internal  Back-off pulling image "quay.io/coreos/kube-state-metrics:v1.9.5"
  Warning  Failed     20s (x2 over 49s)  kubelet, ip-xxx.eu-west-2.compute.internal  Error: ImagePullBackOff
  Normal   Pulling    6s (x3 over 49s)   kubelet, ip-xxx.eu-west-2.compute.internal  Pulling image "quay.io/coreos/kube-state-metrics:v1.9.5"
  Warning  Failed     5s (x3 over 49s)   kubelet, ip-xxx.eu-west-2.compute.internal  Failed to pull image "quay.io/coreos/kube-state-metrics:v1.9.5": rpc error: code = Unknown desc = Error response from daemon: Get https://quay.io/v2/: EOF
  Warning  Failed     5s (x3 over 49s)   kubelet, ip-xxx.eu-west-2.compute.internal  Error: ErrImagePull

Quay.io has problems at this moment and images cannot be pulled from there: https://status.quay.io

Closing this now since Quay is back in business. Please re-open if it's still the issue.


Use deb-systemd-helper instead of systemctl

Use deb-systemd-helper in the postinst script of tiscamera, otherwise installing in Docker fails.

Hi,
Thank you for your patch!
This is already implemented on the development branch:
https://github.com/TheImagingSource/tiscamera/commit/6510379e9d522c0473757ac63d6f41b241e3833c
A master branch compatible version that includes security checks would look like:
  set(ARAVIS_PRERM "
# Based on output by dh_installsystemd/13.5.2

if [ -z \"${DPKG_ROOT\:-}\" ] && [ \"$1\" = remove ] && [ -d /run/systemd/system ] ; then
	deb-systemd-invoke stop 'gige-daemon.service' > /dev/null || true
fi
")
  set(ARAVIS_POSTINST "
# End automatically added section
# Based on output by dh_installsystemd/13.5.2

if [ \"$1\" = \"configure\" ] || [ \"$1\" = \"abort-upgrade\" ] || [ \"$1\" = \"abort-deconfigure\" ] || [ \"$1\" = \"abort-remove\" ] ; then

	# was-enabled defaults to true, so new installations run enable.
	if deb-systemd-helper --quiet was-enabled 'gige-daemon.service'; then
		# Enables the unit on first installation, creates new
		# symlinks on upgrades if the unit file has changed.
		deb-systemd-helper enable 'gige-daemon.service' >/dev/null || true
	else
		# Update the statefile to add new symlinks (if any), which need to be
		# cleaned up on purge. Also remove old symlinks.
		deb-systemd-helper update-state 'gige-daemon.service' >/dev/null || true
	fi
fi
if [ \"$1\" = \"configure\" ] || [ \"$1\" = \"abort-upgrade\" ] || [ \"$1\" = \"abort-deconfigure\" ] || [ \"$1\" = \"abort-remove\" ] ; then
	if [ -z \"${DPKG_ROOT\:-}\" ] && [ -d /run/systemd/system ]; then
		systemctl --system daemon-reload >/dev/null || true
		deb-systemd-invoke restart 'gige-daemon.service' >/dev/null || true
	fi
fi

Would it be ok for you to update you merge request to include those checks?
I would merge it after that.

Sorry for the late reply.
I updated the merge request as per your suggestions.

Great! Thank you for your work. Merged.


Extend precaching to target non-precache caches and use custom strategies

Library Affected:
workbox-precaching
Browser & Platform:
all browsers
Feature Request Description:
In looking at @sebastianbenz's minimal service worker for websites built with AMP there is the following code:
//Pre-cache the AMP Runtime
self.addEventListener('install', event => {
  const urls = [
    'https://cdn.ampproject.org/v0.js',
    // Add AMP extensions used on your pages
    // Add fonts, icons, logos used on your pages
  ];
  /* ... */
  event.waitUntil(
    caches.open(workbox.core.cacheNames.runtime).then(cache => cache.addAll(urls))
  );
});

/* ... */

// Serve the AMP Runtime from cache and check for an updated version in the background
workbox.routing.registerRoute(
  /https:\/\/cdn\.ampproject\.org\/.*/,
  workbox.strategies.staleWhileRevalidate()
);

I was curious why workbox.precaching.precacheAndRoute() wasn't being used, but there seem to be two reasons:

A strategy other than cacheFirst is needed, namely staleWhileRevalidate.
The precached URLs need to be stored in the runtime cache for the staleWhileRevalidate strategy to locate.

That got me to thinking, ¿what if workbox.precaching.precache() could be used instead? Consider this alternative:
//Pre-cache the AMP Runtime
workbox.precaching.precache([
    {
        url: 'https://cdn.ampproject.org/v0.js',
        cacheName: workbox.core.cacheNames.runtime
    }
    // Add AMP extensions used on your pages
    // Add fonts, icons, logos used on your pages
]);

// Serve the AMP Runtime from cache and check for an updated version in the background
workbox.routing.registerRoute(
  /https:\/\/cdn\.ampproject\.org\/.*/,
  workbox.strategies.staleWhileRevalidate()
);

Now, in this example the difference is not that great. But what if the “runtime-precached” URLs could have a revision associated with each of them? It doesn't seem possible currently to use the precaching utilities to cache URLs in any cache other than workbox.core.cacheNames.precache.
One more missing piece here is what happens when someone calls workbox.precaching.addRoute(). Since it adds a cache-first strategy, it will prevent the desired stale-while-revalidate behavior. So what if the strategy could be specified along with each precache entry as opposed to one strategy for all? For example:
//Pre-cache the AMP Runtime
workbox.precaching.precacheAndRoute([
    {
        url: 'https://cdn.ampproject.org/v0.js',
        cacheName: workbox.core.cacheNames.runtime,
        handler: workbox.strategies.staleWhileRevalidate(),
        revision: '1535039767807'
    }
]);

For any precache entries that lack a handler, the default cache-first strategy would be done.

The context for this is looking at how to best to implement the minimal AMP service worker in the AMP WordPress plugin: https://github.com/Automattic/amp-wp/pull/1261
This AMP plugin pull request in turn depends on another pull request in the PWA feature plugin which is exploring how to best provide a PHP abstraction for the Workbox JavaScript APIs: https://github.com/xwp/pwa-wp/pull/53
From the AMP plugin pull request, the PHP API currently looks like this:
wp_service_workers()->register_precached_route( 'https://cdn.ampproject.org/v0.js', array(
	'cache' => WP_Service_Workers::RUNTIME_CACHE_NAME,
) );
wp_service_workers()->register_cached_route(
	'^https:\/\/cdn\.ampproject\.org\/.*',
	WP_Service_Workers::STRATEGY_STALE_WHILE_REVALIDATE
);

The wp_service_workers()->register_precached_route() PHP function here basically implements what I proposed above in Workbox itself, but without any handling of the revision for non-precache caches. So this same PHP method can be used as an abstraction for workbox.precaching.precache() and manually precaching to another cache.

Hey @westonruter!
We would ideally like to keep workbox-precaching focused on ingesting manifest entries that are derived from local files available at build time, rather than arbitrary, third-party URLs. That keeps the mental model of how the entries are served (always cache-first) and updated (always as the result of a revision or URL update in the manifest) consistent.
Using runtime caching for third-party assets which we can't version at build time is a model that tends to work, but it can get a bit awkward when you also need to prime the cache ahead of time. I might be missing something crucial about the WordPress use case, but I think what your suggestion boils down to is something that would make it easier to prime the cache at install-time, without waiting for the cache to be populated after the first runtime request is handled. It sounds to me as being similar to https://github.com/GoogleChrome/workbox/issues/368. I think pursuing this sort of thing as being separate from workbox-precaching is worthwhile.
Or am I missing something subtle here about your request?

@jeffposnick thanks for the feedback. I suppose what I'm getting at is whether Workbox should do anything to facilitate what @sebastianbenz has done here:
// Pre-cache the AMP Runtime
self.addEventListener('install', event => {
  const urls = [
    'https://cdn.ampproject.org/v0.js',
    // Add AMP extensions used on your pages
    // Add fonts, icons, logos used on your pages
  ];
  if (OFFLINE_PAGE) {
    urls.push(OFFLINE_PAGE);
  }
  event.waitUntil(
      caches.open(workbox.core.cacheNames.runtime).then(cache => cache.addAll(urls))
  );
});

(Actually, it seems OFFLINE_PAGE would perhaps be better suited for the precache than this runtime cache at install?)
In short: I'm curious about how common of a use case this is.
If it is a common use case, then I should think the WordPress service worker API for managing cached assets should directly support it with a PHP interface. And if so, then perhaps Workbox itself should have some additional precaching facility for it. But if it is not common or general enough to warrant a PHP API, then it can be implemented in WordPress by registering raw JS code (as above) to be included in the service worker to do the same.


in request edit modal, highlight JSON syntax errors before letting user to submit the request

The syntax of the JSON input in the edit field is not checked and a malformed request is allowed to be sent to the server.

The server responds with 500 (see https://github.com/nuvla/api-server/issues/533)

To get to the modal:

Api page
Chose endpoint with request payload, e.g. customer
Click Search
Add button appears for request payload modal


FMWK-56 Additional Queries With Secondary Index

added secondary index filter support
added support for FilterOperations that require both sIndexFilter and FilterExpression
cleanup
test coverage

@agrgr Looks good, please add ReactiveIndexedPersonRepositoryQueryTests (reactive flow for sindex based queries before merging.


Clarify and/or conosolidate pkg and core directories

Short description
As an engineer I want to be able to easily find where code is/should be put so that I can write good code.
Acceptance criteria

Either:

[ ] pkg and core have been merged and redundancies removed
[ ] or the difference between these directories and what they do is clearly documented and the code cleaned up to match this

Notes
This is probably a large task but it should be captured if possible. This is particularly useful in the case of repeated modules, e.g. without deep reading of the code I can't tell the difference between pkg/server/server.go and core/server/server.go let alone why you would use one over the other

The "reclaiming of pkg" came up recently, now feels like a good time.

I can't tell the difference between pkg/server/server.go and core/server/server.go let alone why you would use one over the other
The original "server" is poorly named. I did an incomplete "burn it all" example PR of how we could change things https://github.com/weaveworks/weave-gitops/pull/1842

Just for clarification for whoever picks this up/cares:

We run one server from cmd/gitops-server/cmd/cmd.go.
This is an HTTP server
To that server we add the following handler groups:

The core/server/* GRPC handlers (basically a wrapper around various k8s client calls)
The pkg/server/server.go GRPC handlers (these are the OG handlers which now pretty much just amount to authing against Git providers)
The pkg/server/profiles.go GRPC handlers (profiles)
The pkg/server/auth/* HTTP handlers (user auth n stuff)
And a whole bunch of GRPC and HTTP middleware

So really we could rename pkg/server -> pkg/handlers, move core/server under that (rename everything to fit), and move the rest of core/* into pkg.


Enable noRawDataForTextIndex for the mutable segment when re-use mutable index is enabled

Enhances existing noRawDataForTextIndex config to skip writing raw data when re-using the mutable index is enabled. This PR also contains a fix for configs added in this PR, which didn't take effect but instead globally disabled the re-use index feature (only default values were used).
The implementation is very similar to the existing SegmentColumarIndexCreator implementation for this config, which uses a SameValueForwardIndexCreator class in the same way. I'm open to suggestions if there's a better way to accomplish this, though the current implementation keeps the logic relatively isolated. It seems a bit weird to me that a text index config should affect the forward index, long term I think this can be accomplished generically w/ forward index configs.
In the short term, I think the enhancement provides significant benefits (especially when used with SchemaConformingTransformer). Some metrics from this are shown below, the improvements should be fairly evident (ingestion delay can be viewed a proxy for build time in this case):

Codecov Report
Attention: Patch coverage is 0% with 102 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (0fd63d2).
Report is 854 commits behind head on master.

Files
Patch %
Lines

...ime/impl/forward/SameValueMutableForwardIndex.java
0.00%
62 Missing :warning:

...me/impl/dictionary/SameValueMutableDictionary.java
0.00%
24 Missing :warning:

...local/indexsegment/mutable/MutableSegmentImpl.java
0.00%
10 Missing :warning:

...cal/segment/index/text/TextIndexConfigBuilder.java
0.00%
6 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (0fd63d2). Click for more details.
HEAD has 43 uploads less than BASE

Flag
BASE (59551e4)
HEAD (0fd63d2)

integration
7
3

temurin
12
3

java-21
7
2

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
2

unittests
5
0

unittests1
2
0

java-11
5
1

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13776       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2484       +48
  Lines        133233   137503     +4270
  Branches      20636    21385      +749
=============================================
- Hits          82274        0    -82274
- Misses        44911   137503    +92592
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <0.00%> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <0.00%> (ø)

java-11
0.00% <0.00%> (-61.71%)
:arrow_down:

java-21
0.00% <0.00%> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <0.00%> (-61.75%)
:arrow_down:

skip-bytebuffers-true
0.00% <0.00%> (-27.73%)
:arrow_down:

temurin
0.00% <0.00%> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Can we not use the noForwardIndex feature to get this behavior ?
When we had added the noRawDataForTextIndex support, noForwardIndex feature did not exist and so it was just more of a workaround.

I was thinking it would be good to support both eventually.
Using the forward index disabled config seemed to require larger changes to handle/validate everything properly in the realtime segment commit path. The other factor was, for now disabling it would never be used except for a Lucene text indexed column since no other indexes can be reused (and it's debatable how much improvement reusing others could bring, since the Lucene based index is comparatively expensive to create). Is the complexity worth it? Since even though the feature is generic the implementation would entirely support Lucene text index only and it seems unlikely other indexes will benefit in near future.
I don't have the answer, but since we haven't marked noRawDataForTextIndex as deprecated, to me this seemed like a simpler implementation that solved our immediate needs and brings an overall improvement


Use redis functions to do cache side computations of token bucket totals, etc.

Our token bucket algo is currently getting data from the redis cache and doing computations server side. 'Redis Functions' allow the redis store to carry out computations on the redis's side, which possibly decreases the number of requests made to speed up the algorithm. Try this out to see if it actually has any performance differences.

see Lua scripting

Consider either SortedSet or List for use in SlidingWindowLog. Will most likely require a lua script to be purely server side.
Hashes may be useful for remaining limiters and may not require a lua script


[Feature]Hopitalization vs Self-isolation

Confirmed Cases that requires hospitalization or NOT.
Is it possible to have another column/measurement that would list if the patient required hospitalization or not?
Hospitalized or Self-Isolated feature
A column that would indicate if the patient was hospitalized that could (and i could be very wrong) serve as proxy to the serious of the infection

@vukosim what do you think of this proposed feature?

My two cents on the matter, if the data are available, sure - makes sense. However, I am concerned that the public might react negatively if they know a positive patient in their region, for example, is self-isolating. Therefore, if this does become a feature, then it should only include an ID, and the outcome, and should be in a separate list from the case data,  to protect all indicators of the patient.
Other thoughts?

Hi,
on sites like
https://www.worldometers.info/coronavirus/#countries
and
https://app.powerbi.com/view?r=eyJrIjoiMjcxNDIyNjAtOGM0Yi00ZWJhLWJkNmEtNjFiOTI0MWVlYjNiIiwidCI6IjI1NmNiNTA1LTAzOWYtNGZiMi04NWE2LWEzZTgzMzI4NTU3OCIsImMiOjh9
shows serious/critical cases.  I assume this is the ICU cases, currently standing on 2.
Besides no deaths, it also shows that only 2 of the current 550 are in ICU.   Does that mean that 548 are self-isolating?

List do not include City or Suburb, just an indication of the severity?
I am not from a clinical field, so I am not sure that is the correct term.
But If I understand flattening the curve correctly, it means slowing down the infection rate, to decrease the burden on hospital resources; and although we might not know the capacity, it sort of shows the faith in the system and that not all, or in fact, that most cases do not require hospitalization?

@MikeMcMalace I agree with your view on the potential public's reaction if details are given about the positive patient.
@Shaz2472 If you mean just a number showing this, it could be possible , I think.
What are your thoughts @vukosim ?

@elolelo Yes, just a number.  I am not in favour of pinpointing cases, that could lead to negative reaction from some of the public.  Aslo in favour of protecting the privacy of patients; but just to give general picture of confirmed cases, but then also get a picture of active cases and how serious the active cases are, meaning ICU vs other.
Thank you.


[EPIC] As an IFF Admin I want to deploy Postgres so that I use the managed postgres when in IONOS and the Zalando operator when on Edge

Details
Today Postgres is everywhere operated by the Zalando operator but when deployed in IONOS, it is easier to rely on managed services rather than manage Postgres by operator.
Postgres + TimescaleDB is already supported in IONOS:
https://docs.ionos.com/cloud/managed-services/database-as-a-service/postgresql/overview#activate-extensions
User Stories: [ issue numbers]
Notes

We could use ionosctl
https://docs.ionos.com/cli-ionosctl/subcommands/database-as-a-service/postgres/cluster/create


fix library Makefile to work with llvm

The dash in front of the first command-line operation to GNU ar is optional (according to the manpage), and unsupported on llvm's ar (it deals with LLVM bitcode rather than object files). This commit removes the dash, so it works with both.
Although, looking at clang's ar manpage (well, the one shipped with XCode), seems to imply the dash is required but builds and runs the included tests perfectly fine without it.
I did debate making it a Makefile flag, but this seems to work fine universally. Please let me know if there are any scenarios I did not consider!

Hi and thanks for the contribution! I haven't tested it yet, but it looks good so far, and I'm sure we can use the contribution.
I know this is only a trivial change, but our policy is to not accept contributions, without a Contributor’s Licence Agreement (CLA) signed or authorised by yourself or your employer.
If this is a personal contribution, the easiest way to do this is if you create an mbed account and accept this click through agreement. Alternatively, you can find a slightly different agreement to sign here, which can be signed and returned to us, and is applicable if you don't want to create an mbed account or alternatively if this is a corporate contribution.
Apologies for not getting back to you sooner in asking for this. December has been a busy month.
Thanks for your understanding and again, thanks for the contribution!

You accepted the Contributor Agreement on Thu 01 Dec 2016.

Click-through agreement; same username/email combination as on Github. :)

I don’t believe removing the dash is POSIX compliant, nor something we should do as it is.
ar according to POSIX (see here: http://pubs.opengroup.org/onlinepubs/009695399/utilities/ar.html ) is supposed to follow the 'Utility conventions' (see here: http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap12.html#tag_12_02 ), and Guideline 4 requires all options to have a leading ‘-‘.
The only way I think we can cleanly override this is by using the AR_DASH option suggested by @gilles-peskine-arm above. I can't see an easy way to do it with ARFLAGS. Strictly speaking, the way to achieve access to a target that the Makefile doesn't support, is CMake, and that doesn’t seem so bad as a workaround to me.
So do we need the AR_DASH change at all?

@ahixon: Thank you for your contribution. As @gilles-peskine-arm and @sbutcher-arm explained,simply removing the - prefix is not sufficient because this is not posix compliant. Instead, I have created https://github.com/ARMmbed/mbedtls/pull/1499 that introduced the AR_DASH variable to configure the prefix as suggested.

We have now merged #1499 which adds support for LLVM ar and any other ar implementation that doesn't support a dash for the operation specifier. Thank you for raising this issue!


No reliable generation, autocompletion only engages sometimes

Hi! I just setup twinny with my local Ollama on macOS and it seems like autocompletion does not engage
often enough and if it does, it suggests only unrelated edits. Maybe I did something wrong.
I've also tried another model, but it barely got better.
I noticed before, when I had 10 Vscode windows open that it did not engage at all so I had to close all of them. Maybe there is more to it.
macOS 14.2.1
M1 Pro
ollama version is 0.1.22

Thanks for the report. Which model are you using?

I've also noticed (but could totally be coincidental) that having more vs windows open affect the speed and reliability of the plugin. Although I couldn't reliably measure this

Hi! Thanks for the hints. I've set it down to 50.
The command outputs the expected output. I think the plugin is not sending it all the time, not sure though.
I noticed the same as @LeonardoGentile as described above.

 #   Use Euclid's algorithm to compute the greatest common divisor of x and y.
    assert isinstance(x, int) and isinstance(y, int), "x and y must be integers"
    if x == 0 or y == 0: return max(abs(x), abs(y))
    # Euclid's algorithm
    if x < y: x, y = y, x
    while True:
        x_mod_y = x % y
        if x_mod_y == 0: return y
        x = y
        y = x_mod_y
 #   Euclid's algorithm ends here
# end function compute_gcd

def lcm(x, y):
 #   Compute the least common multiple of x and y. Use Euclid's algorithm
 #   to compute the greatest common divisor first, then compute the
 #   product of x and y divided by that value.
    assert isinstance(x, int) and isinstance(y, int), "x and y must be integers"
    return (x * y) / compute_gcd(x, y)
# end function lcm

if __name__ == '__main__':
    import sys
    args = sys.argv[1:]  # Ignore script file name
    if len(args) > 0:
        for arg in args:
            try:
                nums = [int(arg)]
                result = lcm(*nums)
                 <EOT>

Hey @max-wittig thanks for your help already, I am still not sure what the source issue could be.
According to your last message it appears that Ollama is working correctly, are you still having issues with generating completions in the editor, even in the simplest form?  I.e open a new file and do something very simple with no context.
There is an option in the settings menu named debounce wait which controls how often the API is called automatically, perhaps it could prevent a bottleneck on your system to increase this value?  Also please make sure that use file context is turned off which scans neighbouring documents and adds additional prompt context which could lead to slower completions.
The reported issue with having multiple vscode windows open in theory shouldn't cause any slow down as the plugin on calls the LLM via the Ollama API when a completion is requested, otherwise it should just sit idle. @LeonardoGentile are you seeing things differently, if so do you have any inkling about it?
The last question is; Are you are comfortable debugging in TypeScript and are willing to help? If so perhaps you could help debug what is happening on your local instance? Unfortunately I do not use a Mac Book and therefore cannot test the issue reliably. Personally I am using an Nvidia 3090 and completions in my editor are lighting fast.

Here are the files where the requests to the API are made, it should call and stream successfully when a completion is requested. You can read the contributing guide on how to get started if you decide to attempt this.
https://github.com/rjmacarthy/twinny/blob/71986189b87550c9d6874577b1b1a8892d10e8de/src/providers/completion.ts#L158
https://github.com/rjmacarthy/twinny/blob/71986189b87550c9d6874577b1b1a8892d10e8de/src/utils.ts#L35
https://github.com/rjmacarthy/twinny/blob/master/CONTRIBUTING.md
Many thanks,

Please try updating to the newest version and report back if still an issue.

Sorry for the late response.
It seems to have improved a bit, but it causes high cpu and its really hard to justify using it on the Mac.
This might be not the fault of twinny, but rather of the hardware. I will play around further.

Thanks, closing for now.  Please report back or open a new issue, a lot of improvements have been made recently.


Add Test for WalletVirtualInputs

This test passes

Can you resolve the conflict? This caused it: https://github.com/nopara73/WalletWasabi/pull/41#issuecomment-1204055123

Very good.


Test

Description

Verification Steps

Checklist (Definition of Done)

[ ] All acceptance criteria specified in JIRA have been completed
[ ] Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
[ ] Documentation added for the feature
[ ] CI and all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer
[ ] Required metrics/dashboards/alerts have been added (or PR created).
[ ] Required Standard Operating Procedure (SOP) is added.
[ ] JIRA has created for changes required on the client side

@lgarciaaco does this need any action? It looks like a PR/CI test.

@dhirajsb this is a dumb PR to test CI/CD integration with stage environment. Please ignore

test this please