Add support for Jedis 4

What does this PR do?
Closes #2616
The proposed instrumentation hereby seems simpler and is more suitable for easily supporting Jedis 4 as well.
All existing tests pass, so I can't say if I missed anything with this simplification.
Checklist

[x] This is a new plugin

[ ] I have updated CHANGELOG.asciidoc - add also as a refactoring change for older Jedis versions
[x] My code follows the style guidelines of this project
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] I have updated supported-technologies.asciidoc
[ ] Added an API method or config option? Document in which version this will be introduced
[x] Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident - the old versions instrumentation is disabled for Jedis 4 based on class loader matching and the new one is specifically enabled for Jedis 4 similarly

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-05-10T03:59:18.281+0000

Duration: 47 min 1 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
2872

Skipped
22

Total
2894

:green_heart: Flaky test report
Tests succeeded.
:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark tests.

run jdk compatibility tests : Run the JDK Compatibility tests.

run integration tests : Run the Agent Integration tests.

run end-to-end tests : Run the APM-ITs.

run windows tests : Build & tests on windows.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


Specify Healthcheck Details

Being able to specify the following would be really helpful:
healthcheck:
    test: ["CMD", "curl", "-f", "http://localhost:3000/"]
    interval: 1m30s
    timeout: 30s
    retries: 20

Done in 4a1cfa37b4d711eec594626a74ad30cd1e66aa0b


Templatr support (WIP)

Templatr is in a testing state - this repo and multiple others will be used to test git clone capabilities.


clue scroll overlay: Show visible emote widget area

The visible area of emote widgets will now be highlighted, regardless of
whether the widget is partially outside the emote window.

Fixes runelite/runelite#4163
P.S. This is the code I used to test the updated rendering logic: https://gist.github.com/Nightfirecat/8775bcc940988914535167efa84c4731

You can also use borderType=2 on the widgets to put a white border


Fixes issue with SI dependencies in refdoc

Also @sobychacko, any chance we can re-publish the M2 docs, and only the docs, after this change goes in?
Thanks!


Stuck Keyboard

Problem Link
Problem Link
Coding platform
Binary Search
Programming language

[ ] C
[x] C++
[ ] Java
[ ] Python

Additional context (OPTIONAL)
Add any other context or screenshots about the feature request here.

Please review this issue and assign me in C++. Binary Search is also one of the popular coding and problem-solving platform.

Hey @kiruba-r11 Please select one existing coding platform because this platform is not used by maximum.

@Nivedita967 Shall I close these issues?


Fix/dawgpath 175

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 8 (62.5%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 63.486%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pathways/templatetags/hashing_tag.py
5
8
62.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
499

Relevant Lines:
786

💛  - Coveralls


[FEATURE] Create a workflow for greetings

As a contributor I want to receive an automated message when I open a pull request (PR) and working on my first issue.
Acceptance Criteria (AC)

[ ] When opening a PR following message should show: "It's great having you contribute to this project. Welcome to the club 🔥"
[ ] When get my first issue assigned following message should show: "It's great having you contribute to this project. Welcome to the club 🤓"

Additional links:
https://github.com/actions/starter-workflows/blob/main/automation/greetings.yml

Can I work on this issue?

Sure, @Pinaka-Pani-18 glad to have you contributing to the project.


Add rpath to Linux build system.

Solves issue #2 and fixes compilation issues.

Does not work, My bad, will probably continue to figure out why? Know nothing about bazel, and very little of C++

Maybe this helps to fix the issues: https://stackoverflow.com/questions/68405534/link-to-versioned-pre-built-libraries-with-bazel


BTS Max supply displays 10billion , it should display the real max supply

BTS Max supply displays 10billion , it should display the real max supply to avoid negative comments that BTS can up to 10billion under current system .

It's hurting the promotion , please fix it asap .

I actually removed BTS from the list of market assets with commit #561 , it didn't really belong there. This means you can't access BTS anymore to get that screen. Unless you really want it somewhere we can probably close this. Maybe we can put BTS total supply somewhere though?

I think we can close this issue


Add priceLineSource option

Type of PR: Enhancement
PR checklist:

[x] Addresses an existing issue: fixes #203
[x] Includes tests
[x] Documentation update

Overview of change:
Add priceLineSource option. I might add more option later in future like firstBar, firstVisible.
Example usage:
series.applyOptions({
    priceLineSource: LightweightCharts.PriceLineSource.LastVisible,
});

Added 2 graphic tests, 1 for series default options, 1 for priceLineSource LastVisible

@SuperPenguin Thanks for your contribution!


Fixes for calculations based on .week

I noticed that .week is using NSCalendarUnit.CalendarUnitWeekday which only adds a single day to the the NSDate instance where I think it is expected to add 7 days. Therefore to seems like bug to me and can be fixed by using NSCalendarUnit.CalendarUnitWeekOfYear instead.

@mattijsf Thanks! I will check your another pull request soon. If there is nothing wrong, I will merge it and release the next version.


PR/BatchedControlFlowAndStringOps

Implement batched loop control flow (including, break, continue) along with early outs (return, exit).  Also add batched support for printf and other string operations.  Implement batched support for shadingsystem ops like bind_interpolated_param, get_userdata, rangecheck, uninitcheck_values, and nancheck.  Implement batched support for negate, min/max, arraycopy, compassign, mxcompref, mxcompassign, .Added BATCHED_REGRESSION tests to the suite to exercise control flow and string ops and compare scaler and batched results.  Enabled various tests to also execute in BATCHED mode.  Enable unoptimized BATCHED mode testing, as constfolding was avoiding any work in optimized mode for some tests.
Fixed bug in testshaded batched mode that inverted population of x and y shader global values, but only noticed in order of side effects like printf in shaders.
Added buffered file support to ShadingSystem to allow batched fprint to write out to files in the correct order.
Fixed bug in BatchedAnalysis which was not handling unlocked geom correctly by requiring unlocked input parameters be varying inorder to accept Wide results from BatchedRendererServices::get_userdata.
LLVM_Util had previously added support managing masks, and its strategy should
be reviewed before trying to understand this commit's changes:
    // Overview of masking strategy
    //
    // For if/then based on a conditional, the result of the conditional is
    // conditionals written to a symbol that is a wide boolean.  To handle
    // nesting we will keep a stack of conditional masks.  When a new
    // conditional mask is pushed, it is combined with the previous mask on
    // the top of the stack.  It is the top of the mask stack that is used
    // as the mask for any instructions requiring masking.  When a
    // conditional scope is exited, we just pop the top of the conditional
    // mask stack.
    //
    // Loops are handled by pushing their conditional result onto the
    // conditional mask stack, and popping it back off at the end of the
    // loop.
    //
    // Handling of early outs (exit, return, break, continue) is done by
    // storing a mask representing the lanes which are going to be
    // deactivated (or continue executing) to an allocated location in the
    // stack. We actually have to store these early out masks, so that we
    // can apply it to the conditional mask stack.  As that stack unwinds,
    // any early out masks are applied to the top of the conditional mask
    // stack.  As there are different types of early outs that apply to
    // different control flow scopes and multiple types can be present at
    // the same time for different data lanes, we must store these early
    // out masks at separate locations on the stack.
    //
    // To handle 'exit', we allocate a 'shader mask' that is initially
    // populated with a startMaskValue representing the active lanes in a
    // shader global batch.  For example perhaps only 7 of 16 data lanes
    // are populated, the startMaskValue would store that value and push it
    // onto the conditional mask stack.  We require a location on the stack
    // for this 'shader mask' in order for an 'exit' statement to modify it
    // and cause a subset of the lanes to be deactivated.  If an exit was
    // processed, the 'shader mask' is where it will be stored and pulled
    // from when applying to the unwinding conditional mask stack.
    //
    // To handle 'return', we allocate a 'function mask' that is initially
    // populated with a startMaskValue representing the active lanes when
    // an inlined function was called.  This startMaskValue should just be
    // value at the top of the conditional mask stack.  As function calls
    // can be nested, we maintain a stack of function masks.  We require a
    // location on the stack for each 'function mask' in order for a
    // 'return' statement to modify it and cause a subset of the lanes to
    // be deactivated.  If an return was processed, the 'return mask' is
    // where it will be stored and pulled from when applying to the
    // unwinding conditional mask stack. When a function scope is exited,
    // the function mask is popped so any return's processed would apply to
    // the outer function mask vs. the one just exited.
    //
    // To handle 'break', we use the condition symbol's location on the
    // stack to directly disable data lanes for the loop execution.  As we
    // already had a location to store the conditional symbol's mask, no
    // need to allocate or store a separate one.  However code will need to
    // reload the condition's value when a break 'could have been' called
    // vs. relying on a conditional result already in a register.
    //
    // To handle 'continue', we allocate a 'continue mask' that is
    // initially populated with a 0 representing the deactived lanes by
    // 'continue' operations. We require a location on the stack for each
    // 'continue mask' in order for a 'continue' statement to modify it and
    // cause a subset of the lanes to be deactivated.  If an continue was
    // processed, the 'continue mask' is where it will be stored and pulled
    // from when applying to the unwinding conditional mask stack. When a
    // loop's scope is exited, the continue mask is popped so it would't be
    // applied to an outer loop.
    //
    // The logic of when and how to actually apply these masks is handled
    // by the caller, tracking/storing the different stacks and masks is
    // handled here.  And queries exist to see how many early outs
    // operations have been processed, these counts can be used by the
    // caller to determine which to generate code to apply each of them.

In our case BatchedBackendLLVM is the caller and during code gen will be calling:
push_shader_instance(llvm::Value* startMaskValue) and pop_shader_instance()
push_function_mask(llvm::Value* startMaskValue) and pop_function_mask()
push_masked_loop(llvm::Value* location_of_control_mask, llvm::Value* location_of_continue_mask) and pop_masked_loop()
And to handle if/then/else be calling
push_mask(llvm::Value *mask, bool negate, bool absolute) and pop_mask()
By checking masked_exit_count(), masked_return_count(), masked_break_count(), and masked_continue_count()
before and after code gen of a function call, then block, else block, loop body, etc.
we can detect if a exit, return, break or continue existed in the generated scope
and then can call apply_exit_to_mask_stack(), apply_return_to_mask_stack(),
apply_break_to_mask_stack(), or apply_continue_to_mask_stack() when needed.
Add utility function "foreach_unique" to provide scalar execution of a Functor
for each unique value in the a Wide data block along with a mask identify which
data lanes match the unique value.
Add utility function "unproxy(const T &elem)" to extract value type from a proxied
element.  This is alternative to static_cast(elem), and better self documents.
Fixed compatibility bug where llvm 9+ asserted that bool was not a valid datatype for llvm::ConstantDataVector::getSplat.
Added LLVM_Util::test_mask_lane(llvm::Value *mask, llvm::Value * lane_index) to test a mask with a variable lane index.
Signed-off-by: Alex M. Wells<EMAIL_ADDRESS>Description

Tests

Checklist:

[x] I have read the contribution guidelines.
[x] I have previously submitted a Contributor License Agreement.
[x] I have updated the documentation, if applicable.
[x] I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
[x] My code follows the prevailing code style of this project.

I was all ready to pass this and merge, Alex, but I tried to build on my work system just to be sure, and I'm getting cmake errors on line 315 of liboslexec/CMakeLists.txt:
if (${target_src} IN_LIST liboslexec_override_limits)

This is in the clang clause. So I think the equivalent gcc and icc are ok, because it passes GitHub CI.
Can you give a quick compile with clang and see if there's something here that needs a quick fix?
Other than that, all looks good to me.

Which clang version?  Isn't clang in the CI?

I'm using clang12. But I think any will do; the problem is that ${target_src} is not think, I set.
We have clang in the CI, and we have batched shading in the CI, but not both in the same test!

target_src gets set in the foreach loop that FOLLOWS where it's used on line 315.

For the onlookers: it was basically a cut and paste error. Fix is in, I'll merge when CI tests are done.


vite, react-ts  --- Module '"*.svg"' has no exported member 'ReactComponent'. ---

Hello i just installed this module in a vite/react-ts project, i'm getting this error when i'm importing an SVG
import { ReactComponent as HomeIcon } from "images/icons/IconSvg/home.svg"
The import works and the icon is shown.
I managed to get rid of the error by declaring this module
declare module "*.svg" {
  import * as React from "react";

  export const ReactComponent: React.FunctionComponent<
    React.SVGProps<SVGSVGElement> & { title?: string }
  >;

  const src: string;
  export default src;
}

It doesn't really bother me, but i was wondering if there is a " cleaner " solution
Thanks for your responses :)

If I understand it correctly, there is a section in the readme you can refer to:

If you are using TypeScript, there is also a declaration helper for better type inference:
/// <reference types="vite-plugin-svgr/client" />

You can add this to your tsconfig.json under compiler options and it will pick up the types
    "types": ["vite-plugin-svgr/client"]

If you are on VSCODE and it doesnt pick it up straight away, either restart vscode or ts server

pd4d10
Added inside client.d.ts -> ///
But got this error:

Put this to your vite-env.d.ts
/// <reference types="vite-plugin-svgr/client" />

I'm having a similar issue, except I can compile but I'm getting this in my browser console log:
Uncaught SyntaxError: ambiguous indirect export: ReactComponent
I have:
//vite.config.ts
import { defineConfig } from "vite";
import react from "@vitejs/plugin-react";
import svgr from "vite-plugin-svgr";

export default defineConfig({
  plugins: [react(), svgr()],
  resolve: {
    alias: {
      src: "/src",
    },
  },
});

//vite-env.d.ts
/// <reference types="vite/client" />
/// <reference types="vite-plugin-svgr/client" />

I've also tried:
    "types": [
      "vite/client",
      "vite-plugin-svgr/client"
    ],

Hey guys, I figured it out.
The type definition of this library is export a variable called "ReactComponent" when you import a svg file, not default export.
declare module '*.svg' {
  import * as React from 'react'

export const ReactComponent: React.FunctionComponent<
    React.ComponentProps<'svg'> & { title?: string }
  >
}

so Don't set the exportAsDefault to true, which will export svg component as default export, which will result in confilit with svg declaration from vite.
use this plugin like this:
import { ReactComponent as SvgIcon } from './xxx.svg';

@panjiangyi So what's the point of exportAsDefault then?

@lucsky IMO it gives you a choice, or compromise. If you think having to type .svg imports yourself is worth the effort to not need to rename the import every time, then exportAsDefault: true is for you.

That being said, as an OSS, I think the best course of action here is for a community hero to provide the typing for when exportAsDefault: true. That is, when that option is enabled, you should only need to do:
/// <reference types="vite-plugin-svgr/client-default" />

Does anyone have a way to get the vite-plugin-svgr/client types to take precedence over the vite/client types? My vite-env.d.ts looks like this:
/// <reference types="vite/client" />
/// <reference types="vite-plugin-svgr/client" />

And my svg imports are still typed as string instead of { ReactComponent }. Swapping the lines around doesn't work. Deleting the vite/client line does work, but then breaks my other modules' types.

Add the following to your tsconfig:
{
  "compilerOptions": {
    "types": ["vite/client", "vitest/globals", "vite-plugin-svgr/client"],
    }
  }
}

I've tried all the suggested work around here and builds fail.
IMO, kind of a critical issue.. Mind boggling that something as fundamental as an SVG import statement is killing builds and nothing is being done about it.

Have tried all suggested answers here and in documentation to no avail.. Still an issue for me that prevents build.

Tried everything from here and from stackoverflow. Nothing works. I always end up with Uncaught SyntaxError: ambiguous indirect export: ReactComponent.
Also tried doing what OP did, but no luck. Also added reference types, but no luck.
currently vite.config.ts has this
plugins: [react(), svgr({svgrOptions: {exportType: "named", ref: true}})],
also played around with svgrOptions, but no luck.
I am really clueless after one day to trial and error.

ReactComponent named export is for v3 and prior versions.
For the latest v4, please check out the document here: https://github.com/pd4d10/vite-plugin-svgr?tab=readme-ov-file#usage

If using v4 of this package, you need to change your imports from
import { ReactComponent as Icon} from '/src/assets/icon.svg';

to
import Icon from '/src/assets/icon.svg?react';

i hope this helps someone, i resolved this issue by moving vite-env.d.ts inside of my ./src directory

If using v4 of this package, you need to change your imports from
import { ReactComponent as Icon} from '/src/assets/icon.svg';

to
import Icon from '/src/assets/icon.svg?react';

It looks like this syntax is not supported with Jest :(

@chawax vitest-dev/vitest

Tried everything from here and from stackoverflow. Nothing works. I always end up with Uncaught SyntaxError: ambiguous indirect export: ReactComponent.
Also tried doing what OP did, but no luck. Also added reference types, but no luck.
currently vite.config.ts has this plugins: [react(), svgr({svgrOptions: {exportType: "named", ref: true}})], also played around with svgrOptions, but no luck.
I am really clueless after one day to trial and error.

You need to add include: '**/*.svg' prop to svgr plugin configuration. Vite config should looks like this:
plugins: [
    react(),
    svgr({
      svgrOptions: { exportType: 'named', ref: true },
      include: '**/*.svg',
    }),
],

Does anybody know how I can adjust the vite config so that I get the v3 behavior where a named export of ReactComponent is the component and the default export is a string? I know how to resolve the resulting TypeScript issue.

I would like to suggest improve the "vite-plugin-svgr/client" with another case when import the SVG icon with URL (like from the public folder of React application):
const ReactComponent: React.FunctionComponent<
React.ComponentProps<"svg"> & { title?: string }

;

declare module "*.svg?react" {
export default ReactComponent;
}
declare module "*.svg?url&react" {
export default ReactComponent;
}

@MrRobz

If using v4 of this package, you need to change your imports from

With this approach, TS won't allow you to use SVG properties like fill. It will complain:
Type '{ fill: string; }' is not assignable to type 'IntrinsicAttributes'.
  Property 'fill' does not exist on type 'IntrinsicAttributes'.

hey guys, the plugins don't have a named export. Look at the following code:
declare module "*.svg?react" {
  import * as React from "react";

  const ReactComponent: React.FunctionComponent<
    React.ComponentProps<"svg"> & { title?: string }
  >;

  export default ReactComponent;
}

In addition, it just defines a ReactComponent type for imports like *.svg?react so:

Plugin Recommendation: Import SVG file as ReactComponent using import SvgIcon from 'icon.svg?react

Custom Solution: Override the plugin and vite types for SVG files. For this purpose, you can create a declaration file like custom.d.ts and include it using tsconfig.json (before src).

//custom.d.ts
declare module "*.svg" {
  import * as React from "react";

  const ReactComponent: React.FunctionComponent<
    React.ComponentProps<"svg"> & { title?: string }
  >;

  export { ReactComponent };
}

Be flexible to changes :)

Thank you @KingMatrix1989 !

Changed plugin config to exportType: 'named'
imported as import { ReactComponent as GenericPoiIcon } from<EMAIL_ADDRESS>And now I can call SVG attributes like <GenericPoiIcon fill='gray' />


Migrate extra DSpace-CRIS "Live Import" sources to DSpace (EPO & ADS)

References
Fixes https://github.com/DSpace/DSpace/issues/3359
To facilitate code review, the work was divided into 4 PRs.
This PR contains the following connectors:

EpoImportMetadataSourceServiceImpl
ADSImportMetadataSourceServiceImpl

Instructions for Reviewers
All the connectors present in this PR are not active by default, in particular, to work it is necessary to configure the apiKey in  dspace.cfg
submission.lookup.ads.key =
for ADS (https://ui.adsabs.harvard.edu/help/api/)
and
po.consumerKey =
epo.consumerSecretKey =
for EPO (https://developers.epo.org/)
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[x] My PR passes Checkstyle validation based on the Code Style Guide.
[x] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[x] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[x] If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

@tdonohue the next one to merge will be this one that I'm working on

hi @tdonohue , thanks for your feedback. Could you please restest again? Everything works for me now

:

Merging with +1 approval. Thanks again @Micheleboychuk !


why is d3.select() of d3 is different from select() of d3-selection???

I have used D3 latest version in react to do visualization， and found something weird.
d3.select() of d3 lib is different from select() of d3-selection lib.
can anyone explain this, and what is equivalent of d3.select
code as follow:
import React from "react"
import { select } from "d3-selection"
import * as d3 from "d3"

export default class Test extends React.Component {
    componentDidMount() {
        this.renderBar();
    }
    componentDidUpdate() {
        this.renderBar();
    }

    renderBar() {
        let node = this.refs.bar;
        let r1 = select(node);
        let r2 = d3.select(node);
        console.log("result1", r1);
        console.log("result2", r2);
        // I find r1 is different from r2.
        // such as r1 does not have transition() function but r2 has it!
    }

    render() {
        return (
            <rect ref="bar" ></rect>
        );
    }
}

the two object have different function.
Then I have checked source code of select()[d3-selection/build/d3-selection.js] and d3.select()[d3/build/d3.js], unfortunately, they are the same.
can anyone explain this, and what is equivalent of d3.select
or
where am I going wrong?
thank you~

You might be seeing the same side-effect behaviour I came across in http://www.walley.org.uk/blog/2016/9/4/rollup-and-d3-plugins

yeah, I find this problem just because of the error message:

thanks @johnwalley , I have solve it using your approach


[SPARK-31056][SQL] Add CalendarIntervals division

What changes were proposed in this pull request?
This defines the devision of two CalendarIntervals as the ratio between the time duration of both. The CalendarInterval consists of three time components: months, days and microseconds. The division is only defined between intervals that have a single non-zero time component, while both intervals have the same non-zero time component. Otherwise the division expression would be ambiguous.
Why are the changes needed?
Putting interval into relation is a natural expression: 1 day / 1 hour = number of hours per day.
This allows to evaluate the magnitude of CalendarIntervals in SQL expressions:
Seq((Timestamp.valueOf("2020-02-01 12:00:00"), Timestamp.valueOf("2020-02-01 13:30:25")))
  .toDF("start", "end")
  .withColumn("interval", $"end" - $"start")
  .withColumn("interval [h]", $"interval" / lit("1 hour").cast(CalendarIntervalType))
  .withColumn("rate [€/h]", lit(1.45))
  .withColumn("price [€]", $"interval [h]" * $"rate [€/h]")
  .show(false)
+-------------------+-------------------+-----------------------------+------------------+----------+------------------+
|start              |end                |interval                     |interval [h]      |rate [€/h]|price [€]         |
+-------------------+-------------------+-----------------------------+------------------+----------+------------------+
|2020-02-01 12:00:00|2020-02-01 13:30:25|1 hours 30 minutes 25 seconds|1.5069444444444444|1.45      |2.1850694444444443|
+-------------------+-------------------+-----------------------------+------------------+----------+------------------+

The currently available approach is
Seq((Timestamp.valueOf("2020-02-01 12:00:00"), Timestamp.valueOf("2020-02-01 13:30:25")))
  .toDF("start", "end")
  .withColumn("interval [s]", unix_timestamp($"end") - unix_timestamp($"start"))
  .withColumn("interval [h]", $"interval [s]" / 3600)
  .withColumn("rate [€/h]", lit(1.45))
  .withColumn("price [€]", $"interval [h]" * $"rate [€/h]")
  .show(false)

Going through unix_timestamp is a hack and it pollutes the SQL query with unrelated semantics (unix timestamp is completely irrelevant for this computation). It is merely there because there is currently no way to access the length of an CalendarInterval. Dividing an interval by another interval provides means to measure the length in an arbitrary unit (minutes, hours, quarter hours).
Does this PR introduce any user-facing change?
It allows interval division in SQL expressions and adds the DivideIntervals catalyst expression.
How was this patch tested?
Unit tests in IntervalExpressionsSuite.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@EnricoMi, please review https://spark.apache.org/contributing.html (e.g., filing a JIRA and PR titie)

Do other RDBMSes support this? or can you just divide their number of seconds, etc?

cc: @yaooqinn

thanks for pinging me @maropu
Using extract/date_part functions instead may be a good choice here for end-users. Supporting / for intervals goes against a contract that we are trying to follow  - 'avoiding 1 month = 30 days'.
BTW, I check presto which supports ANSI-like year-month/day-time intervals and it does not have such a feature.

The division does not go against the contract, it is only defined for cases where both intervals have the same single resolution (either months, days or micros), it returns null on mixtures, see https://github.com/apache/spark/pull/27805/files#diff-eba257f41b49f470321579875f054f00R540.
The extract and date_part functions cannot be used to evaluate the magnitude of an interval:
val data = Seq((Timestamp.valueOf("2020-02-01 12:00:00"), Timestamp.valueOf("2020-02-01 13:30:25"))).toDF("start", "end")

data.show
+-------------------+-------------------+
|              start|                end|
+-------------------+-------------------+
|2020-02-01 12:00:00|2020-02-01 13:30:25|
+-------------------+-------------------+

data.select(expr("date_part('minute', end - start)"), expr("date_part('hour', end - start)")).show
+-------------------------------------------------------+-----------------------------------------------------+
|date_part('minute', subtracttimestamps(`end`, `start`))|date_part('hour', subtracttimestamps(`end`, `start`))|
+-------------------------------------------------------+-----------------------------------------------------+
|                                                     30|                                                    1|
+-------------------------------------------------------+-----------------------------------------------------+

Neither date_part('minute', ...) nor date_part('hour', ..) provides me with an accurate magnitude (either 90 minutes or 1.5 hours) of the interval.

If it's limited to dividing say 24 hours by 12 hours, how useful is it?
I'm not seeing an argument that other SQL DBs allow this.
If this is only meant to work on intervals of type like "24 hours" then isn't date_part sufficient to extract the interval exactly?

You can use both
java API  org.apache.spark.unsafe.types.CalendarInterval.extractAsDuration().toSeconds
and SQL functions
date_part('hour', ...) * 3600 + date_part('minute', ...) * 60 + date_part('second')

@srowen CalendarIntervals are defined by three values: microseconds, days and months. These are what I refered to as "resolutions" above. You cannot convert between either of them without ambiguity. This is what @yaooqinn meant with "contract".
To be unambiguous, division here is only defined when both intervals define only microseconds or days or months, no mixture. CalendarIntervals encodes microseconds, seconds, minutes and hours as microseconds, days and weeks as days, and months and years as months. So the division allows to divide a CalendarInterval of, lets say 1h with 5m, or 2h and 30m with 30s, or 8 days with 1 week, or 2 years with 2 months. As long as the division is unambiguous.
@yaooqinn can I use the mentioned Java API in Dataset.select(...) or org.apache.spark.sql.functions.expr?
With your suggested date_part,
.withColumn("duration in hours", $"interval" / lit("1 hour").cast(CalendarIntervalType))

becomes
.withColumn("duration in hours", date_part("hour", $"interval") + date_part("minute", $"interval") / 60.0 + date_part("second", $"interval") / 3600.0 + date_part("microsecond", $"interval") /<PHONE_NUMBER>.0)

which is not very readable.
All I want to achieve here is get access to the magnitude of an interval. CalendarInterval is neither comparable, nor convertable in a number representing the whole of the interval (and not just parts like date_part does). The mentioned extractAsDuration and extractAsPeriod might be the closest to achieve that.

Right, "24 hours" is too simplistic an example. I get that "1 year 2 months" is just months. I think the arguments still stand: non-standard, limited scope, and achievable with existing functions.

scala> spark.udf.register("div", (x: CalendarInterval, y: CalendarInterval) => x.microseconds / y.microseconds)

res5: org.apache.spark.sql.expressions.UserDefinedFunction = SparkUserDefinedFunction($Lambda$3193/1435685475@9bd49ca,LongType,List(Some(class[value[0]: interval]), Some(class[value[0]: interval])),Some(div),false,true)

scala> spark.sql("select div(interval 24 hour, interval 1 hour 30 minutes)").show
+---------------------------------+
|div(24 hours, 1 hours 30 minutes)|
+---------------------------------+
|                               16|
+---------------------------------+

scala> spark.udf.register("modulo", (x: CalendarInterval, y: CalendarInterval) => x.microseconds % y.microseconds)
res7: org.apache.spark.sql.expressions.UserDefinedFunction = SparkUserDefinedFunction($Lambda$3231/1344928508@26fb851d,LongType,List(Some(class[value[0]: interval]), Some(class[value[0]: interval])),Some(modulo),false,true)

scala> spark.sql("select modulo(interval 24 hour, interval 1 hour 30 minutes)").show
+------------------------------------+
|modulo(24 hours, 1 hours 30 minutes)|
+------------------------------------+
|                                   0|
+------------------------------------+

The months, days, and microseconds are all public, with UDFs, I think it's easy to achieve what we are trying to do here.

Do we have an answer to https://github.com/apache/spark/pull/27805#issuecomment-635381702? It's easier to justify with actual references and/or standard.

I am not aware of any SQL standard going this direction. I agree that the suggested UDFs give me the same result.

I am not aware of any SQL standard going this direction. I agree that the suggested UDFs give me the same result.

FWIW, the SQL 2016 standard (section 4.6.4 "Operations involving datetimes and intervals") defines interval division and multiplication only for intervals combined with numeric types.

I am closing this per ^.


Cursor is always at the beginning of the RTE after loading default value

Checklist

[x] This is not covered in the repository examples.
[ ] I am using the package latest version.
[x] This is a bug report or an enhancement proposal.

Description
When I try to edit the text of the rte the cursor always returns to the beginning of the text after typing the first character.
For this case I loaded default content with the "defaultValue" property

Im getting the same issue. Using version 1.29.0

Same here in 2.0.1

we are setting content as a string. each time content changes the string changes and a new editor state is created. new editor state has no idea where the previous cursor was. So, unless we can pass selection data (or editor state) I don't see how we can solve this. It would be interesting to know what author thinks about this.
I have proposed a option to pass contentState here #301


Converting to CPUParticles2D sets ZIndex to zero

Godot version:

Godot 3.1.beta3 (commit 6607c3c1c)
OS/device including version:

MacOSX 10.13.6
Issue description:

When I convert a Particles2D into CPUParticles2D, convertor sets ZIndex of new object to zero.
Steps to reproduce:
Make some new Particles2D node. Set it's position and ZIndex above zero. Convert Particles2D to CPUParticles2D. It's position is correct but ZIndex is not correct.
Minimal reproduction project:

Working on it


Suggestion: Add a blocks.TagBlock

This blocks.TagBlock would, in the UI, work exactly the same way like when the staff is tagging an uploaded image.
This feature would be helpful for editors and other members of the staff, tagging a story or an article.

Just found the reference in the docs, sorry.


"No Assets" message when trying to export using Xamarian.Forms exporter plug-in

Hello,
I have installed the 1.3 release by opening the xdx file.
I have made a mockup of what I want my program to look like ( XD file attached as zip) and when I try to export it I get the following message:
No Assets
The plugin could not find any Assets in your project.
Check that you have defined Color and/or Character
Style assets in your project.
car-dealer.zip
:
On closer inspection, the problem might be missing fonts.

I don't really understand what you mean.
With XD you can export images with your buttons, etc. Kym Phillpotts use this export function (as images) in his streamings. You can take a look to his YouTube channel: link
If you are meaning to export as XAML, the plugin is very basic and it doesn't have this feature. And I think it could be quite difficult to implement it.
I hope this help you.


[Designer] Fix showCard with selectAction behavior to being unsupported

Platform
What platform is your issue or question related to? (Delete other platforms).
Designer.
Author or host
Neither. Feature dev
If you're an author, who are you sending cards to?
Version of SDK
What version are you using? Ex: NuGet 1.0.2, or latest master, etc...
master
Issue
(1) Per discussion today, at the team meeting, we will move our behavior to match what was originally decided upon ie showCard and selectAction is NOT supported in Adaptive Card renderers.
This tracks the work needed in the Designer to account for the behavior change. @dclaux FYI.

@dclaux should this issue be closed now?


I have a question about RACMulticastConnection

here is my code:
@interface ObjectA ()

@property (nonatomic, strong) NSString *tempValue;
@property (nonatomic, strong) RACMulticastConnection *racConnection;

@end

@implementation ObjectA

- (void)someMethod:(void (^)(NSString *tempString))complete
{
    if (!complete) {
        return;
    }
    __weak typeof(self) weakSelf = self;
    if (!self.racConnection) {
        RACSignal *signal = [RACSignal createSignal:^RACDisposable * _Nullable(id<RACSubscriber>  _Nonnull subscriber) {
            weakSelf.tempValue = [NSProcessInfo processInfo].globallyUniqueString;
            NSLog(@"createSignal tempValue: %@", weakSelf.tempValue);
            [subscriber sendCompleted];
            return [RACDisposable disposableWithBlock:^{
                NSLog(@"RACSignal is dispose: %@", weakSelf.tempValue);
                weakSelf.tempValue = nil;
            }];
        }];
        RACSubject *subject = [RACReplaySubject replaySubjectWithCapacity:1];
        self.racConnection = [signal multicast:subject];
    }

    [[self.racConnection autoconnect] subscribeNext:^(id  _Nullable x) {
        NSLog(@"subscribeNext tempValue: %@", weakSelf.tempValue);
        complete(weakSelf.tempValue);
    } completed:^{
        NSLog(@"completed tempValue: %@", weakSelf.tempValue);
        complete(weakSelf.tempValue);
    }];
}

- (void)shutdown
{
    [[self.racConnection connect] dispose];
//    self.racConnection = nil;
}
@end

and ViewController:
self.object = [[ObjectA alloc] init];
[self.object someMethod:^(NSString *tempString) {
    NSLog(@"someMethod 1: %@", tempString);
}];
[self.object someMethod:^(NSString *tempString) {
    NSLog(@"someMethod 2: %@", tempString);
}];
// here, the shutdown method is behind the log "someMethod 2"
[self.object shutdown];
[self.object someMethod:^(NSString *tempString) {
    NSLog(@"someMethod 3: %@", tempString);
}];

out put is:
createSignal tempValue: 7683D13D-C77E-476A-A926-BC297065BCED-22772-00000DED5694A98E
completed tempValue: 7683D13D-C77E-476A-A926-BC297065BCED-22772-00000DED5694A98E
someMethod 1: 7683D13D-C77E-476A-A926-BC297065BCED-22772-00000DED5694A98E
RACSignal is dispose: 7683D13D-C77E-476A-A926-BC297065BCED-22772-00000DED5694A98E
completed tempValue: (null)
someMethod 2: (null)
completed tempValue: (null)
someMethod 3: (null)

my question is
whe the dispose method before subscribeNext called?

wrong typo..
my question is
why the dispose method before subscribeNext called?


Testing PR

This is a test PR from a forked repo.
Note to project maintainers: this is re: CircleCI Support Ticket #119384

Closing test PR.


Add support for keeping resources marked via Helm Resource Policy

Helm support the ability to leave behind resources post-release by marking them with the annotation helm.sh/resource-policy: keep.
If a resource in an object set is marked with that policy but the object set is marked for deletion, the objectSet that is applied for deletion should still contain those resources so that they can be reapplied one last time.
Once the Helm Release has been removed, however, resources that are left behind will no longer be watched or reconciled.

Need this to support the Alertmanager Secret in Monitoring V2 and Grafana Dashboard namespace.
https://github.com/rancher/charts/blob/f07e9425600500b8d6a232eb926166bc614b16f3/charts/rancher-monitoring/100.1.1%2Bup19.0.3/templates/alertmanager/secret.yaml#L13
https://github.com/rancher/charts/blob/f07e9425600500b8d6a232eb926166bc614b16f3/charts/rancher-monitoring/100.1.1%2Bup19.0.3/templates/grafana/namespaces.yaml#L11


RELEASE.md: update to reflect current release process

As done for the v0.11.8 release. Includes the following changes:

Releases are cut from v0.10 and master branches, not just master.
Create a preparation PR (README.md and stable.txt update) before
tagging the release.
Example command to set COMMIT_SHA to latest master.

ignoring CI failures, this PR only touches RELEASE.md


Calibration

I ran through the calibration routine using the spreadsheet and entered the calculated values into the yaml file.
When I command the servo into the center position it looks great, like the picture in the neutral state.
But when I run the "rosrun spot_micro_keyboard_command spotMicroKeyboardMove.py" and issue a stand command the front leg immediately goes to a backward 45 angle
https://imgur.com/a/cApK967
I also get this error in the terminal
[ WARN] [1596336583.533563203]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.533835589]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.553476302]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.553757596]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.573577177]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.573853378]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.593459128]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.593915327]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.613521374]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.613794593]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.633489028]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.633760377]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.653448108]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.653721124]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.673585408]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.673774240]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.693472396]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.693737227]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.713493661]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.713679270]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.733790867]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.733975291]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.753532801]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.753724707]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.774142189]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.774325595]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.793581941]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.793861235]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.813496429]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.813672335]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.833531693]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.833710951]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.853449181]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.853721808]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.873620518]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.873901886]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.893545302]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.893816966]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.913516716]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.913795417]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.933498221]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.933762756]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.953468060]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.953746243]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.973585231]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.973868488]: Joint LF_3, Angle: -98.66
[ WARN] [1596336583.993482553]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336583.994062677]: Joint LF_3, Angle: -98.66
[ WARN] [1596336584.013564632]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1596336584.013845518]: Joint LF_3, Angle: -98.66

Nm, OpenOffice issue


Know last sync of MDSplus and PTDATA to toksearch

@sflanagan has noted a large usage on atlas of, in this case, pulling BES data .  If we direct the user to use toksearch instead, how does a user know when the last time the data was synced? or what was the last shot that was synced?  Because it won't do us any good to have the user try to use toksearch and then toksearch pings atlas anyway.

Also, if the latest shots synced are older than the ones they want (e.g. they want to analyze a recent experiment they performed) ... how do they request a re-sync?

When FDP is live, I believe so, but not currently. This is probably simpler to accomplish with whatever final index exists.


Document that file_extension and file_prefix can also be supplied as regular expression

I was going to suggest enabling regexes for file_extension and file_prefix, when I realized it already supports that.
I think this should go into the README. Give me a ping if I should prepare a PR.

sure if you could send a README PR that would be great. I kept this open thinking I could do that soon, but I haven't been working much on churn for awhile, and I think the docs might turn out better if written from the perspective of a user. Let me know if you are still interested in updating the docs @julianrubisch


APPS-1004 Update Scala projects to sbt v1.5.7.

sbt 1.5.7 updates log4j to 2.16.0, which disables JNDI lookup and fixes a denial of service vulnerability #Scala
https://eed3si9n.com/sbt-1.5.7
https://twitter.com/scala_sbt/status/1471015853495881730

Trying again here https://github.com/dnanexus/cwlScala/pull/21


This seems to be useless

React is not being used

It's implicitly used by the JSX at the bottom. That gets transpiled to React.createElement calls, so the import is actually needed.


Merge pull request #1 from andela-anwosu/develop

Checkpoint 1 - Inverted Index

Coverage remained the same at 100.0% when pulling 0f19687ee621f2b9d8175b60574194bb3327fe58 on master into 578c02509d5673aab76133567c564533b0724b13 on develop.


Team signin: Unauthorized although TFS credential is valid

Version: 1.31.0 (system setup)
Commit: 7c66f58312b48ed8ca4e387ebd9ffe9605332caa
Date: 2019-02-05T22:35:56.624Z
Electron: 3.1.2
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.14393
[Main Instruction]
Visual Studio Code
[Content]
Although VS code is tracking changes from source control, there is a bug preventing it from connecting to TFS (this happened after upgrading to 1.31.0)
[OK] [Copy]

Steps to Reproduce:

Upgrade to 1.31.0
Try signin in to TFS

Does this issue occur when all extensions are disabled?: Yes

Same for SharePoint, using node-sp-auth
		spauth
			.getAuth(url, {
				username: UserName,
				password: password,
				domain: UserDomain
			})
			.then(data => {
				let headers: any = data.headers;
				headers.Accept = "application/json;odata=verbose";
				let requestOpts: any = data.options;
				requestOpts.json = true;
				requestOpts.headers = headers;
				requestOpts.url = uri;
				requestOpts.form = postOptions.form;

				request.get(requestOpts).then(response => {
					this.logSuccess(response);
				}).catch(er => {
					console.log(er);
					}
				}).then(() => {
					console.log("end");
				});
			});

Reporting a bug to Microsoft is like hell.
-- Not my bug... Report it to xyz. (Mostly another Microsoft repository. Can't you write a bot for something like that?)
Yeah please reopen this. I have exactly the same code running in a VSCode extension, without VSCode. Without VSCode it is working. Till version 1.30.2 is it working. With Version 1.31.0 it is not working.
In the end, our customer and partners will not update VSCode until it is fixed. And I think that is not in your interest.

Solved!
My version of Code:

Steps to fix:
1)- Open VS Code settings (Ctrl + ,)
2)- Search by "Proxy"
3)- Change Http Proxy support from Override to OFF

:D

This should be fixed in current insiders builds of VS Code with the Proxy Support setting set to 'override'. Let me know if you still see any issues with that. Download: https://code.visualstudio.com/insiders/

I was experiencing this issue. I followed the instructions (set proxy to off) and downloaded the insiders build. While I can now authenticate, either VS Code or the Azure Repos extensions sees all of my local workspaces as server.

This should be fixed in current insiders builds of VS Code with the Proxy Support setting set to 'override'. Let me know if you still see any issues with that. Download: https://code.visualstudio.com/insiders/

There is also another bug associated with v 1.31: https://github.com/angular/vscode-ng-language-service/issues/312#issuecomment-462230536

I have downloaded the latest insider build. All of my workspaces are local. For a minute or so VS Code acts like everything is fine then it pops up the error.

workspaces.txt

@erikread That looks like an issue with the extension, could you check if they have an issue open for this and create one if they don't at https://github.com/Microsoft/azure-repos-vscode/issues ?

Normally I would agree with you but I went back to 1.29.1 (October Release) and all is good. Same version of the extension. So, at the very least, it is a combination of changes in the release and something in the extension. There is an open issue for this problem and have added my information.


💡 [FEATURE] - Addition of FIGMA specific content

Idea Contribution

[X] I have read all the feature request issues.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Explain feature request
ResourceHub's current Figma resources are limited, failing to reflect Figma's popularity as a mainstream UI/UX design tool.
This lack of in-depth Figma content hinders web developers, particularly those interested in UI/UX design, from fully utilizing ResourceHub's potential. Expanding the Figma section with a wider range of high-quality resources would significantly enhance the platform's value for this user group.
Explain your solution
I can create a new Figma section within ResourceHub's UI/UX category. This section will feature:
UI/UX Kits & Templates: Pre-designed components and mockups to jumpstart Figma projects.
Open-Source Icons: Extensive libraries of icons for enhanced visual communication.
Any alternative approaches/features
NA
Additional Context
NA

@jfmartinz Can u please assign me this issue ?


[EVENT REQUEST] Skip Item in report "Calculate Plan - Plan. Wksh." 99001017

Could we get this event report "Calculate Plan - Plan. Wksh." 99001017 which is similar to the one in report 699 "Calculate Plan - Plan. Wksh."
trigger OnAfterGetRecord()
var
    ErrorText: Text[1000];
    SkipPlanning: Boolean;
begin
    UpdateWindow;

    SkipPlanning := false;
    OnBeforeSkipPlanningForItemOnPlanningWksh(Item, SkipPlanning, CounterOK);
    if SkipPlanning then
        CurrReport.Skip();

...

[IntegrationEvent(false,false)]
local procedure OnBeforeSkipPlanningForItemOnPlanningWksh(Item: Record Item; var SkipPlanning: Boolean; var CounterOK: Integer)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Add Accessibility/ARIA compliance to all components

We need to review all the components for ARIA accessibility compliance and implement as appropriate per the ARIA spec.
Things we need to consider and evaluate:

Keyboard Navigation for Widgets
Keyboard Focus
ARIA States and Properties
Open Ajax Accessibility examples

Supported Components:

[ ] Accordion (docs)
[ ] Alert (docs, as modal)
[ ] Buttons (docs)
[ ] Carousel (docs, example)
[ ] Collapse (docs)
[ ] Datepicker (docs)
[ ] Dropdown (docs)
[ ] Modal (docs)
[ ] Pagination ([docs])
[ ] Popover (docs)
[ ] Progressbar (docs)
[ ] Rating ([docs])
[ ] Tabs (docs)
[ ] Timepicker (docs)
[ ] Tooltip (docs)
[ ] Typeahead (docs)

There's a good discussion and links in #3526.

Is it possible to trace the closed sub issue for #3474 to a specific commit/release? I'm currently on version 0.12.1 of ui-bootstrap and need this particular accessibility fix. I would like to avoid going to a minor release if possible or else I would need a change log with breaking api changes. Your help is much appreciated!

@vcarreno96 you can find all the details is https://github.com/angular-ui/bootstrap/blob/master/CHANGELOG.md

I'm having a bit of a hard time figuring out how much ARIA work was actually done. None of the checkboxes in the original issue are checked. Some of the linked issues have landed as PRs, whereas others appear to have been closed as duplicates of this one.
The reason I ask is that I'm working with a project on version 0.14.3, and I'm trying to determine if upgrading to the latest version will yield accessibility improvements to the modal.

@NickHeiner, IIRC, we've not done much and the release we targeted for ARIA support got hijacked and we never circled back.  It needs to be done so if you feel like submitting some quality PRs, please go ahead.

Here's a PR! You can decide if it's quality 😸.
https://github.com/angular-ui/bootstrap/pull/6166

Typeahead with custom HTML popup template specified - screen readers are not picking up the results displayed in the popup template. Seems the correct 'aria' tags are being generated but reader is silent, even when an item is 'active'.

@jcwarfield can you try my PR (#6203) and tell me if that fixes your problem?

Hi Nick, thanks for the quick response. I think your PR is a good addition, but does not fix the issue I'm having. Our uib-typeahead is using a custom popup template property (typeahead-popup-template-url), that points to an embedded template in the same html file (script type="text/ng-template" id="sectionList.html"). I think the problem may be that the custom template is being inserted into the DOM after the page is rendered, but before typing occurs, so the screen reader does not pick up the results in the popup. Is the template being injected after the page is rendered and a user begins typing?

Ah yes, then my PR is not going to help you. That's a separate issue. And yes, I have seen it make a difference whether a DOM attribute exists when the elements are put into the DOM, as opposed to being added later.

@jcwarfield, did you have any luck resolving the typeahead accessibility (screenreader) issue?

Is there any update for these changes?

Actually it's been over a year since working on that project, so it was still unresolved at the time I left.

I'd like to mention that Modal component may not only take modal role. It may also be alert or alertdialog.
I considered implementing it over angular-ui-bootstrap in my application and I came into a conclusion that if backdrop is static (which in my case also means there's no "X" in the corner, but it's my app specific) then it's alertdialog (in my case it's always some way to interact).
I think there should be an optional param in $uibModal.open which says what kind of role should be applied. Now I would have to implement that with raw DOM api


[BUG] Tabs not restored

Describe the bug
Tabs are not properly restored after upgrading to Nvim 0.7
To Reproduce
Steps to reproduce the behavior:

touch a b && nvim
:e a | tabnew b | SaveSession
:qa
nvim

Expected behavior
Two tabs a and b with b in focus. Instead, only b is shown
Baseline (please complete the following information):

Result of set sessionoptions?: sessionoptions=winpos,terminal
OS. e.g uname -a: MacOS Monterey
Neovim version nvim --version NVIM v0.7.2

@simonmandlik hey, your sessionoptions doesn't include tabpages. Try adding that and see if you get the behaviour you were expecting.

That was it, thanks :) A dumb error when rewriting config from vimscript to lua


Game lagging

Through trial and error, I have determined that this particular add-in is causing me serious lag. I don't use an extensive list of add-in's just these:
Both DLC's
Escape Teleport 1.3
Faction Enhancer (Catchup, Econ AI, Econ Balance, War) 5.3
Inventory Collector 1.13
Mules, Supply and Warehouses Extended 6.32
Sector Patrol 1.05
SirNukes Mod Support APIs 1.86
Smooth Mouse Steering 1.0
Trader Seminars 1.02
Urgent Orders 1.1
So I started noticing that the game would frequently "hang". Sometimes for less than a second, sometimes a second or so but not longer than that. In fact, it's only when I'm actually flying a ship that it's intolerable. It's enough that combat is very poor and not fun at all.
To troubleshoot, I disabled all add-ins and started from my latest save point just vanilla. Smooth as glass. I then started adding the extensions back in and it's clear that Mules is it. Mules off, nice and smooth. Mules on, momentary game pauses very frequently.
I've got a dozen or so M1 mules for my PHQ station, dozens of M2 mules for my various stations, and 20-30 M4 mules. I'm guessing this is some sort of calculation issue. I'd really, really hate to have to live without this mod so I'm happy to perform any sort of troubleshooting that would be helpful.
I'm on a modern motherboard, 32GB of system RAM, and a good Nvidia card. I've watched the system using Performance Monitor and my system utilization isn't spiking while this is going on.

There is a patch for the station mule that fixes some potential lag situations; @Misunderstood-Wookiee was going to deploy that a couple of days ago but I haven't seen it yet.
By M2, do you mean distribution mules? I rarely use them and generally advise users to avoid it due to logic headaches; I am not sure exactly what it's potential performance issues might be.
On the supply mule, the best way to reduce lag is to reduce the trade space; that means making sure the max jumps is only as large as you need it to be, and if you have no intention for them to ever trade with the AI, unchecking that box. Even if you have trade rules applied, if you have the box checked to trade with AI, they will still have to pull in all the possible trades, and then rule them out one-by-one with the trade rule logic. If you uncheck the box, the trades never make it into the logic checking at all.

another note on supply mule; by default, the mule starts with max jumps of usually 4/4 or 6/6 depending on pilot skill. As the pilot levels, that jump range stays pinned at max; so at some point after you start the mule, you usually want to go back and reduce the jumps below his maximum so it will stop growing every time the pilot levels.

 I'm almost back at the  computer ill get this patch sorted in the next hr.

So generally, I provide at least 2 M2 Station Mules to my production stations to move goods back and forth to my Warehouse and retrieve food and meds. Bigger stations, like Engine Parts, get more M2's to service the station and keep the goods flowing to the warehouse. I use some M1's to sell goods around space to the AI stations for cash. I use a lot of M4's which are great for starting up a new station build and just general busywork. So one of the other mods I use is "trader seminars" which makes the skill books easily available to skill up pilots. Most of my M4's have 16 or more jumps available to trade so perhaps I sabotaged myself by making too much of the universe available to too many ships?

 I'm almost back at the computer ill get this patch sorted in the next hr.

I'd just LOVE not to have to redo all my M4's to reduce their coverage if this takes care of things. 👍

This patch will not reduce the M4 jump range for you, unfortunately. That's just something there's not currently a great workaround for.
The travel mule max jumps is also good to keep relatively small.
I'd say your biggest performance gains would be:

keep your travel mule jumps smaller
reduce your supply mule jumps
remove AI trades from supply mules you only want trading in player goods

Something worth mentioning, in my own personal save, the biggest impact on my own stuttering and framerate in my game was when I installed the faction enhancer mods.

This patch will not reduce the M4 jump range for you, unfortunately. That's just something there's not currently a great workaround for.
The travel mule max jumps is also good to keep relatively small.
I'd say your biggest performance gains would be:
* keep your travel mule jumps smaller

* reduce your supply mule jumps

* remove AI trades from supply mules you only want trading in player goods

Yeah, I discovered that I could reduce the range without having to remove and re-add the assignment so I did that on all my M4's. I also removed the AI stations from about half of them.

Something worth mentioning, in my own personal save, the biggest impact on my own stuttering and framerate in my game was when I installed the faction enhancer mods. Possibly it's due to the number of ships increasing with the logic there, or the jobs changing, but definitely after I added that to my save, I noticed some stuttering.
I am not solely blaming that mod; any mods in X4 could be causing lag, and generally, the more you have, the more likely you're going to get frames packed full of poorly optimized modder code.

If I can't get he stuttering under control otherwise, I will ditch those in favor of Mules. I find that oh so much more useful.

To quote this, I haven't used those sets of mods since 4.0 as they largely
just add a couple more stations but most of the essential use case is now
fixed by egosoft
On Thu, 6 May 2021, 12:02 am Brian Hayden, @.***> wrote:

Something worth mentioning, in my own personal save, the biggest impact on
my own stuttering and framerate in my game was when I installed the faction
enhancer mods.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/issues/120#issuecomment-832713107,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFH3SZ56RYSITI3NEPDIAILTMFFXZANCNFSM44EZHC7A
.

In order to manage your expectations, I would say that even a totally vanilla x4 is likely to stutter. Another cause of stuttering is simply the more satellites you have.

In order to manage your expectations, I would say that even a totally vanilla x4 is likely to stutter. Another cause of stuttering is simply the more satellites you have.

Yeah, one of the things I do once the Adv. Sat's are not too expensive for my wallet is to have my mapping ships go around and take down my original ones and put back fewer advanced. Now that I have trade subscriptions I can really take down any that I have just for trading purposes since I don't need them to update orders anymore. I like to have them at the jump gates and any conflict points just to keep an eye on things.

I find the sector satellites mod to be absolutely essential for reducing satellite-based lag. You can place an advanced sat out in the middle of nowhere in the sector and it will keep your trade subscriptions for the whole sector updated, and even auto-discover new stations as they're built.
It's a bit cheat-y, compared to vanilla, but it drastically reduces the amount of micro required, and also the number of satellites.

Btw, let me ask some advice. I've basically setup all my production in the NF VI sector aside from things like graphene/antimatter cell/Teladinium, which are in the resource sectors. I have a big warehouse in Pious Mists II on the super highway and I'd like to setup another warehouse up "north" to supply shipbuilding stations. What do you think would be the most effective setup to keep the warehouses full? M2's from the production stations to the PM II warehouse, and then M2's from the PM II warehouse to the norther ware house to keep it full?

In previous versions of mules the station mule wasn't allowed to trade between trade stations, but this incoming change actually removes that restriction. Station mules could certainly do the job of moving things between trade stations, although I am not sure how well they'll actually do the job. You may have to carefully monitor stock levels to make sure the station mule doesn't totally empty you out somewhere. There is also some amount of randomness to exactly which ware he will pick on any given run.
For this, I think I would probably assign supply mules to the distant tradestations with enough jumps to reach your primary areas. Turning AI trades off, of course :)
This was actually the original purpose of the distribution mule, but in general I have found the logic to be poor and have not had a chance to significantly improve it, as it's pretty complex and breaking it completely is likely.

Patch Deployed as of today.

So with faction fixes mod  from what  I understand using the mod today you wind up with a couple of extra stations to help support fleets which actually are pretty laggy for the game ship production that is, and I think it messes with fleet sizes and amount of ships in the game as a whole which is the real impact in frame rate it as that taxes the CPU more than vanilla size ship counts.
Last time I tested it the fps difference was around Bet 3.20 or something and I think it was bout 9-10 fps on stations.

There is a patch for the station mule that fixes some potential lag situations; @Misunderstood-Wookiee was going to deploy that a couple of days ago but I haven't seen it yet.
By M2, do you mean distribution mules? I rarely use them and generally advise users to avoid it due to logic headaches; I am not sure exactly what it's potential performance issues might be.

Sorry, are you talking about the "M2-Station Mule" or the "M3-Distribute Mule"? I've been using a decent number of both and I've been having exactly the same periodic lag-spikes that the OP describes. I've also been having what seem to be some quite serious logic issues with the M2-Station Mules.
I've been banging my head against the wall trying to work out if I've set it up wrong, but I've eventually had some behaviour that is clearly not WAD. Maybe I ought to post a separate thread, but as I say, it seems to relate to some of what's mentioned above.
Issues I've had with M2-Station Mules:

when set to move goods one-way from a factory to a warehouse, sometimes they seem to ignore what should be valid trades
when in-system trade is enabled, sometimes the mules will buy goods from the warehouse and then immediately sell those goods directly back to the warehouse

Although sorry, now I've been experimenting with it and may have found a more fundamental issue - although i don't know if it's the mod or vanilla: station trade offers aren't working correctly for fleet subordinates. If I try to trade with one of my stations with an independent ship or fleet leader, it correctly displays the station buy offer. If I try to trade with a subordinate fleet member, the station will display as only wanting to buy a much lower quantity of goods.  Seems to affect all my ships and all my stations, but not AI stations? And seems to affect manual trades as well as supply mule trades.
Anyone have any idea what that's about? It's infuriating, because setting up this many traders one at a time without fleet mimic is going to be a nightmare.

The last bit of what you said sounds like a funding issue. It is using the account of the station it is a subordinate of. If a station manager doesn't have the full funding they're requesting, then you'll see things like, one ship will reserve a trade to bring the ware, and then subsequent ships will no longer even see the ware in their trade offers. If you go to logical overview or the right click menu, it will show that the station has demand for it, so it seems like everything should be good; but the actual function in the game that returns trade offers just won't return anything, or will return very few. My best guess is that this is the way the engine is protecting funding to buy other wares; once there's already a reservation for a ware, if there's not a ton of funding, they'll save their money for other wares until that trade completes. It's totally a guess because all of that happens deep in the engine, away from the scripts that are moddable. But this kind of thing usually happens if you don't give the station all the funding it's asking for.
That is actually also probably the cause to your 1) above, but you'll have to be way more specific if you want me to look into something.
for 2), I have seen really dumb behavior out of the distribution mule, but I have never seen a station mule do anything like this, so if you catch this happening, please provide as much detail as possible.

I have definitely seen funding as a big issue. If the station manager doesn't have what they think are enough credits, then they just seem to stop doing things. I setup a station with only container storage to use a a warehouse. No production modules at all. I then setup M2 mules at all the production stations pointing to the warehouse as a target. At first nothing moved at all. I had zeroed out the warehouse station's account since I had set it for only internal trades and not to buy things from AI vendors. The estimated budget was something like 54 million credits and once I accepted that estimate then it broke the log jam and goods started moving the way they should. Production stations stock the warehouse and take back food and meds from the warehouse back to the production station. Then I use a lot of M4's with no AI purchases to do most of the distribution to stations like my ship construction stations.
So one think I learned is that reservations count as if the storage had the item in stock. I started removing all the production modules that I had built at PHQ, so its build storage was just full of claytronics and hull parts. I took and incarcatura and ordered it to do round trip after round trip to my warehouse to empty the build storage at PHQ and when I did that all my hull part deliveries from my production station stopped. I finally figured out that it was because I had setup like 20k in reservations from the build storage to the warehouse so the warehouse stopped taking from the hull part production station. I had to remove most of those trades from the order queue of that one ship to get it moving again.

So one problem I'm facing is that I have to move my warehouse. I'm trying to finish the Paranid story line where they want you to build the station with the three throne modules. My problem is that I had purchased a plot in Pious Mist II for my warehouse and now that's where the mission wants me to build the damn station. So I bought another plot nearby and I'm building a replacement warehouse. My challenge is that I have dozens of M2's setup for my production stations with that first warehouse as a target and I can't change the target station without removing the default order and setting the whole thing back up. I can't just click and change that one item. I think I've found where I need to make changes in the save file, but it's hard working on a 1.2GB text file. Is there any way to make it so that I could modify the target station without removing the default M2 order??

there used to be a mod that unlocked a ship's orders when it was a subordinate, but I don't think it's been updated in forever and it was UI dependent so it probably doesn't work anymore.
So unfortunately I don't think there's any good way to mass-change the target station. Just put on some music and push through it, then make sure to save right after you're done!

So unfortunately I don't think there's any good way to mass-change the target station. Just put on some music and push through it, then make sure to save right after you're done!

Nope, not gonna do it through the UI. I'll edit the save game and do it that way. Notepad++ isn't usable at those file sizes, but Ultraedit seems to work.

Right, well, change my statement to "back up your save before editing it!"

My plan is to pause the game and make two separate saves. I can go to town on one and still have a reliable backup in case I pooch it somehow.

Worked like a treat! I had to use Ultraedit since the file was so big, but I changed all the Home, targetStation, and sourceStation tags that had the original warehouse ID to the new ID and it worked the first try. It even waited to move the subordinates from the old warehouse to the new until after their queued commands finished. Just a few simple search and replaces.
I did not try and change all the active trade destinations, I just let them finish as ordered. I figured changing those would have other ramifications I wouldn't understand.

Getting rid of my M2s and most of my M3s has fixed the lag spikes I was getting similar to the OP fwiw

Getting rid of my M2s and most of my M3s has fixed the lag spikes I was getting similar to the OP fwiw

By "getting rid of" do you mean you turned them into M4's or did you do something else?


About Undefined Symbol Error Message: _ZN20ddynamic_reconfigure19DDynamicReconfigureC1ERKN3ros10NodeHandleE

Hi guys! I am having the undefined symbol error message:  _ZN20ddynamic_reconfigure19DDynamicReconfigureC1ERKN3ros10NodeHandleE, as I was trying to install realsense camera ROS wrapper. I was following this video, https://www.youtube.com/watch?v=eSAsLAzYzm4, for installation. We first found the “find_if” error when trying to run instalRealSenseROS.sh and we solved it by adding “std::” in front of the “find_if”. Then, we keep following the video until the final step before the camera software appeared. The error message is included as a picture. Then, we tried multiple ways to solve the problem, such as not fixing the find_if error, creating a brand new workspace to test the camera operation and some online suggestions but none of them worked out. Could someone please send help? Thank you!

Hi @KittenRoll  Which librealsense SDK and RealSense ROS wrapper versions are you using, please?  The log lists your camera firmware driver version as <IP_ADDRESS>, which is old and dates back to May 2021.
The ddynamic error could indicate that the ddynamic_reconfigure component is not installed.  Does the message disappear if you install the Melodic version of ddynamic_reconfigure using the command below, please?
sudo apt install ros-melodic-ddynamic-reconfigure

Hi @KittenRoll  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.


User password

Hi,
Could you help me with User password? I get error about wrong password and I can't figure out which password I should use. Seems like I have the same password set for network and user, but it's not accepting.

Ok, so figured out that Site needs to be created. And to create a site - you need to register and this is "User password"


Create a "Structure Mode" for editing.

The basic concept is that you can shift between a standard text-based editing mode and a block-based editing mode. Perhaps you toggle with Mod+L/Mod+Shift+L/Mod+Alt+L for "Line".
Once in this mode,

Arrows move selection up/down
Shift+Arrows add/remove selection (lines) up/down
Alt+Arrows shift selection up down (and any logical children, e.g. in a list, headers & contents)
Tab indents selection & any logical children

This could also be combined with other shortcuts for modifying list forms and other block-level constructs.

U – Unordered list

Command+*(-, +) – Unordered list, enforcing a certain character

O – Ordered list (numbers)

1(2, 3) – Ordered list starting at number
A(B, C) – Ordered list with alpha-numeric starting with character

J - Join lines into one (when multiple lines are selected)
T – Todo List
Escape/Enter to drop you out (maybe with selection / without selection at end of line)
Delete to delete & stay in line mode

While I do not disagree on the usefulness, I believe that having a separate mode detracts from a fluid editing experience by creating additional steps to a goal.
One way to minimize that would suggest to drop the mod key entirely in favor of having simple single key sequences (not pressing keys at the same time) when not in edit mode.
For example pressing l u for unordered list and l o for ordered list, i k to insert a link, etc, in this case there are more keybind option because you can have more action associated with a given letter.

A idea is to use a menu key to open a context menu that you navigate through the mentioned keys sequences without a mouse, removing the need for a separate mode.


objectMerge Add to trimHeadFrames if capturing new trace

Otherwise the original trim value will be off by one.

You missed a comma after stacktrace: true, therefore all tests fail :P
  423:13  error  Parsing error: Unexpected token trimHeadFrames

Fixed it myself and rebase manually. Thanks! :)

Sorry, thanks for picking that up!

I can't see this fix on any of the active branches... did it get lost?

https://github.com/getsentry/raven-js/commit/50beaa5fc41601d5e6076c8c5b77741a637aab67 first at the top. I'll make a release within next 20-30min.

Released as 3.22.2

Awesome, thanks!


hideControls hides whole top row instead of just solid/gradient

I want to keep the eye picker but hide the solid/gradient controls but I am unable to do this because the hideControls hides all the top row

Interesting, never thought about that. Will add some additional options for each control btn


Make version 5.1.0 available in Cocoapods

Hello @ashleymills, can you please make version 5.1.0 available in Cocoapods. We are unable to release a dependency that includes sub-dependency with target deployment versions < 9.0.

Hi guys. Please, update the project.


Unable to Import Elasticbeat Dashboards in Kibana

As per the installation guide of running in Kibana, following steps have been mentioned:
cd ~/workspace/go/src/github.com/radoondas/elasticbeat/kibana
get the content of the file import_dashboards.sh and save on the disk
chmod u+x import_dashboards.sh
./import_dashboards.sh -url http://localhost:9200
However, the above path does not exist & hence import_dashboards cannot be fetched and exported. Please correct this behaviour for easy to follow guide.

Thanks @guptayuvraj !
I am working on a new version of Elasticbeat which will be compliant with libbeat v5 and this will be addressed as well. With v5 we will have binary to execute and import visualisations. The script has been removed.
Seems that this will speedup my work :)

Hi @radoondas
Any specific timelines for making it compliant with libbeat v5?

@guptayuvraj I cannot promise any specific date. I have already a working version available but need to finish it off.

@radoondas Actually I am writing a book titled "Mastering Elastic Stack" under which  I am covering elasticbeat usage as a reference to community beats. Hence, I would prefer if you could make elasticbeat compliant to Libbeat v5 as soon as you can so that I can incorporate the changes within the chapters asap.


[Feature] Addition of MongoDB Atlas datastore

This pull-request adds MongoDB as a datastore with Atlas Vector Search. Follows references closely.

Detailed setup: docs/providers/mongodb/setup.md
Example notebook: examples/providers/mongodb/semantic-search.ipynb
Integration tests: tests/datastore/providers/mongodb_atlas/test_mongodb_datastore.py

Documentation has also been updated.
@isafulf It is recommended in the PR Checklist that the author request a review from a maintainer. Would you be so kind?

This PR contains a commit from #427. Would you please merge that one, too?

@ianmobbs @isafulf can we please get a review on this PR


[terra-form-checkbox] Incompatible with base 12px font size

Bug Report
The terra-form-checkbox is incompatible with applications that have a base 12px font-size set on the root html element in IE10 or IE 11 in IE 10 compatibility mode. The label is misaligned in Chrome and Safari.
Description

Applications with a base 12px font-size result in overlap and misalignment of the label and checkbox.
Steps to Reproduce

Clone the terra-core repository
Override the html font-size in terra-base to 12px.
Start the site and navigate to the terra-form-checkbox examples
Using an IE 10 browser (Or IE 11 in IE 10 compatibility mode) observe the examples display misaligned and with overlap

Additional Context / Screenshots

Screenshot taken from IE 10.

Expected Behavior

The checkbox should display appropriately in IE 10 with a base 12 font size.
Possible Solution

--
Environment

Browsers: IE 10
Note: The label is misaligned in other browsers. Chrome and Safari.

This issue may be resolved by using an appropriate theme that accounts for the reduced base font-size.

Long term we should account for font scaling in some fashion and separate base font from the theme all together.

Suggestion for this would be to resolve sizing layout along with an update the Terra default theme to no longer use the HTML native checkbox and radio button but to have custom styling (originally used native inputs for matching to old Terra, which is no longer needed for default Terra theme -- native inputs are still needed for Fusion theme).
Could combine and complete this existing related Issue: https://github.com/cerner/terra-core/issues/2197
Note - design details need to be added before starting.

Removing the bug label and changing to enhancement, as changing the rem size for Terra is an application option/possibility, but not fully supported through complete UI validation and testing,
and will be resolved by including with enhancement #2197.


jitter expiration

Reduce CPU burden of Redis expiration during high traffic

I would like us to convert a lot of the time-related math to using time.Duration and the like, but that can come in a later patch.
:shipit:


  Platform engineer can either use this as is or use it as a sample to provide a starting point for their own GPT.
What problem does this solve?
As a Developer
I want a guided UI to create GH repo for a Go application, which will be managed by Argo using GH Actions
So that I can get started quickly with a Go application
Scenario:
Given: A Developer and an existing Backstage application
When: The developer wants to add a new component to the application
Then: A Go GPT is available to select
Given: A Developer and an existing Backstage application
When The developer adds a new Go component to the application
Then: A starting point application is committed to a source repository

completed by https://github.com/janus-idp/software-templates/pull/65


Use LayerSpec in Component.show()

Is your feature request related to a problem? Please describe.
I am not sure how I can permanently overwrite the layer that c.show() puts the port triangles. Currently the default is hard coded to (1, 12).
Describe the solution you'd like
I believe it would make sense to change this line to use a string LayerSpec, so that it can be dynamically set by a PDK

I'd also argue that show_ports should be False by default. i think this confuses a lot of first-time users...
"why are these shapes on my gds? i didn't draw them..."

nice catch Jan-David! and thanks for the suggestion Troy
let me know what you think of
https://github.com/gdsfactory/gdsfactory/pull/441

show_ports=False by defaul
when show_ports=True, use layer PORT for drawing the port markers

@joamatab , my only criticism here is, aren't we also using that PORT layer for other (permanent) annotations, i.e. for LVS?
if so, i think it would be good to put these on a separate layer so as not to create confusion (i.e. SHOW_PORT?). otherwise, you could get these temporary, informational labels mixed up with those which actually get exported with your component

Putting it on PORT was actually also my first thought. But I also see your point Troy. I am not sure however how much of a problem it is, specially with show_ports being Falseby default.  If you have stuff in the PORT layer without show_portsyou know it is put in permanently.
On the other hand one could also put it on SHOW_PORT and allow to coalesce SHOW_PORTand PORT into the same GDS layer, providing fine grain control to PDK owners to keep them separate or merged at will.

my other follow-up comment that I apparently forgot to make... 😆
@joamatab, it would be really nice to have better documentation of the default/required PDK layers (maybe somewhere here?), so we know which layers we need to add to our PDK and what they are used for without so much trial and error. Just a simple table of layer names and descriptions I think would be really helpful!
or if we do add a BaseModel of these required layers as discussed in the thread with @thomasdorch , you could just add descriptions for each and let sphinx auto-generate the docs, which may be easier to maintain!


fix: loader type

Overview
Fix loader type for the case: loaderQrl returns fail(...) without any validator.
Related issue: https://github.com/BuilderIO/qwik/issues/3979

What is it?

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests / types / typos

Description
I only do StrictUnion when the loaderQrl returns fail(...) to keep the most simple case's type the same.
// Loader<number>
export const useLoader1 = routeLoader$(() => 123);

// Loader<{
//     foo: number;
// }>
export const useLoader2 = routeLoader$(() => ({ foo: 123 }));

And for those returning fail(...):
// Loader<{
//     loaderFailedReason?: string | undefined;
//     failed?: true | undefined;
//     pet?: undefined;
// } | {
//     pet?: string | undefined;
//     failed?: undefined;
//     loaderFailedReason?: undefined;
// }>
export const useRandomFailedLoader = routeLoader$(({ fail }) => {
  if (Math.random() > 0.5) {
    return fail(500, {
      loaderFailedReason: "Reach Limit",
    });
  }

  return {
    pet: "guinea pig",
  };
});

Use cases and why

One use case

Another use case

Checklist:

[x] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] Added new tests to cover the fix / functionality

Thank you for the contribution!
I see you have an issue with reproduction, but I don't see a test. Did you forget to check it in?

Hi @mhevery, test is starters/apps/qwikcity-test/src/routes/(common)/loaders/issue3979/index.tsx.


rank setup stack usage

With large models comes large stack usage.

compile in separate thread for deterministic stack size
(verify rank setup vs. proton config setup)

warn about stack usage when over 128K
(note that recursive decent parsing of rank expressions comes on top
of the usage reported by the blueprint resolver)

@baldersheim please review
@lesters FYI

Merge at will when green.

the log claims the build is ok, but it is still yellow


Using several prefixes at once

It will be useful if I can provide several prefixes. For example for one server I use specific pack of variables. And for another server I use the same pack, but replace one variable.
For now I must use something like this
export SECRET_DOMAIN_NAME=another_domain.com
dump-env -p 'SECRET_' -t config/.env.template > config/.env

While I want something like this
dump-env -p 'SECRET_' -p 'DOMAIN_SPECIFIC' -t config/.env.template > config/.env

Added you as a collaborator


Errors after first run of sbt

I believe I had/have an issue similar to #2067 .  I fixed part of it, but I still am unable to complete sbt assembly successfully..
I have two questions marked (1) and (2) below..
Some background..
I wasn't able to set my proxy properly to download the jar files via sbt.  I tried lowercase/uppercase http_proxy, https_proxy, setting the parameters in JAVA_OPTS, using cntlm, and using different proxies.  So I downloaded Typesafe Activator and ran that once which seemed to retrieve a bunch of stuff.
Then I still was not able to run sbt.  It said your proxy requires authentication , which was a new message (before I was just getting "tried" notices).  I had already set proxy host, user, and password in JAVA_OPTS.
Then I looked at the aforementioned issue and noticed the file /usr/share/sbt-launcher-packaging/bin/sbt-launch-lib.bash uses ${java_opts} and not the environment's ${JAVA_OPTS}
I resolved this issue by setting,
export java_opts=${JAVA_OPTS}

At first I thought that since the other poster was in Shanghai, and I am in Taiwan, that maybe we have some issue in common, but now I don't really know what was going on and just wanted to share my experience in case someone else comes across a similar issue.
(1) Should sbt-launch-lib.bash be looking at JAVA_OPTS rather than java_opts?
After setting the above, sbt now runs on its own, though I see the below errors when running sbt assembly
(2) Is this because sourceforge is currently down?
[info] Resolving jwnl#jwnl;1.3.3 ...
[error] SERVER ERROR: Service Unavailable url=http://opennlp.sourceforge.net/maven2/jwnl/jwnl/1.3.3/jwnl-1.3.3.pom
[warn] 	module not found: jwnl#jwnl;1.3.3
[warn] ==== local: tried
[warn]   /home/rob/.ivy2/local/jwnl/jwnl/1.3.3/ivys/ivy.xml
[warn] ==== activator-launcher-local: tried
[warn]   file:/home/rob/.activator/repository/jwnl/jwnl/1.3.3/ivys/ivy.xml
[warn] ==== activator-local: tried
[warn]   file:/home/rob/activator-dist-1.3.5/repository/jwnl/jwnl/1.3.3/ivys/ivy.xml
[warn] ==== public: tried
[warn]   http://repo1.maven.org/maven2/jwnl/jwnl/1.3.3/jwnl-1.3.3.pom
[warn] ==== typesafe-releases: tried
[warn]   http://repo.typesafe.com/typesafe/releases/jwnl/jwnl/1.3.3/jwnl-1.3.3.pom
[warn] ==== typesafe-ivy-releasez: tried
[warn]   http://repo.typesafe.com/typesafe/ivy-releases/jwnl/jwnl/1.3.3/ivys/ivy.xml
[warn] ==== opennlp sourceforge repo: tried
[warn]   http://opennlp.sourceforge.net/maven2/jwnl/jwnl/1.3.3/jwnl-1.3.3.pom
[info] Resolving org.apache.hadoop#hadoop-yarn;2.2.0 ...
[error] SERVER ERROR: Service Unavailable url=http://opennlp.sourceforge.net/maven2/org/apache/hadoop/hadoop-yarn-server/2.2.0/hadoop-yarn-server-2.2.0.jar
[info] Resolving org.fusesource.jansi#jansi;1.4 ...
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: jwnl#jwnl;1.3.3: not found
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
sbt.ResolveException: unresolved dependency: jwnl#jwnl;1.3.3: not found

I was able to get sbt working.  The problem must've been caused by the Sourceforge outage


Release action is tagging main instead of release branch

https://github.com/softprops/action-gh-release/issues/392

should be fixed by 3a673eb5b4f6aeb5d1b417fdf997e34d188c656f, validate on next release


HADOOP-17396. ABFS: testRenameFileOverExistingFile Fails after Contract test update

Post updates to rename on existing file test, ABFS contract test is having failure. Updates were made in the AbstractContractTest class in https://issues.apache.org/jira/browse/HADOOP-17365.
To align to test expectation of no exception but a false return from rename, ABFS tests need config "fs.contract.rename-returns-false-if-dest-exists" set to true.
Also the abstract class was reusing a static test folder path.  Hence on test re-run, where same storage container is used, source and destination path creations will fail with FileAlreadyExists, leading to test failures. This is also fixed.
[Test results pasted at the end of conversation tab].

HNS-OAuth
[INFO] Results:
[INFO]
[INFO] Tests run: 88, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 66
[INFO] Results:
[INFO]
[WARNING] Tests run: 208, Failures: 0, Errors: 0, Skipped: 141
HNS-SharedKey
[INFO] Results:
[INFO]
[INFO] Tests run: 88, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   ITestAzureBlobFileSystemDelegationSAS.testCheckAccess:94 » AbfsRestOperation O...
[ERROR]   ITestAzureBlobFileSystemDelegationSAS.testRootPath:343 » AbfsRestOperation Ope...
[INFO]
[ERROR] Tests run: 457, Failures: 0, Errors: 2, Skipped: 24
[INFO] Results:
[INFO]
[WARNING] Tests run: 208, Failures: 0, Errors: 0, Skipped: 24
NonHNS-SharedKey
[INFO] Results:
[INFO]
[INFO] Tests run: 88, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 245
[INFO] Results:
[INFO]
[WARNING] Tests run: 208, Failures: 0, Errors: 0, Skipped: 24

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 21s

trunk passed

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 29s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 22s

trunk passed

+1 :green_heart:
mvnsite
0m 34s

trunk passed

+1 :green_heart:
shadedclient
18m  8s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 57s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 54s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
checkstyle
0m 15s

the patch passed

+1 :green_heart:
mvnsite
0m 27s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
16m 53s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 21s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
0m 56s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 23s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

83m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2491/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2491

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 7105c78e7057 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 235947e2822

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2491/1/testReport/

Max. process+thread count
570 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2491/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

+1, merged to trunk and branch-3.3; sorry for this. I would have liked object store tests, but we can't insist on that for hadoop-common stuff.
regarding the setup change, test teardown is meant to clean that up...what has probably happened is that the failure of the first attempt left things in a mess. Happens more to me when I'm working in an IDE and stopping test runs before getting to teardown(). Nothing wrong in adding the code though.