Rolled logs, old files deleted on process (app) restart

Running app (iOS app) generates log files:

some.log   (lets call this "File A")
some_timestamp1.log
some_timestamp2.log

Then app is quit (force quit by user, or invisibly by iOS).
User returns to app (re-launching it).
File state is now:

some.log  (new, starts empty, is NOT "File A" !)
some_timestamp3.log    (this IS "File A", renamed to get it out of the way)

These files are gone:

some_timestamp1.log
some_timestamp2.log

Describing effect in words: "when you create a new instance of XCGLogger with same configuration, it loses the previous file set (old, rolled log files) and keeps only the most recent 'active' log file by rolling (renaming) it. Data is lost that should have been kept according to the config for max number of rolled log files to keep."
Swift code for setup:
let logger = XCGLogger(identifier: config.identifier, includeDefaultDestinations: true)

file.targetMaxFileSize = 1024 * 100

file.targetMaxLogFiles = 3

file.outputLevel = .debug

file.showThreadName = false

file.showLogIdentifier = false

file.showFileName = false

logger.add(destination: file)

Additional info, after more testing: appears to be related to the .targetMaxLogFiles setting and how it gets applied. Sometimes rolling allows more files, sometimes not (deleting files, even though count is still well under target max).
I have a test run in front of me where the max files is set to 15, and after logging system init, there are 11 files. The app runs for a while, generating more data, then observe log directory and (a) it has generated 6 new rolled log files, but (b) there are only 13 files.
So started with 11, added 6 (11 + 6 = 17 files involved).
But when those 6 rolled files were added, 4 old files were dropped (11 + 6 added - 4 dropped = 13 left).
With my .targetMaxLogFiles = 15 I expected to see 15 files (11 + 6 new - 2 dropped = 15).
My guess is that dropping old files is (as the parameter name suggests) done in a fuzzy-batching kind of way where once the code sees the number of log files is getting "too many" it deletes "some" files. Not a predictable number. Just "some" to get the count back under the target maximum.
When working with a target-keep of 20 or something, +/- two or three files is likely not a big deal. But in the app that generated this bug report, I had a target max of 3, and there getting two less than expected is a disaster for tracing when log files for an error are sent to developer.
My problem is that I have to have a maximum level of detail (number of files) but also make sure file set from mobile device is small enough to become an email attachment.
So assuming this is all true, that issue is fuzzy-remove-count when rolling log files, there are two changes that would solve my problem:

Make the "target-keep" more reliable in rolling. Only delete a file when it's over maximum. (I suspect this would be difficult in implementation for Reasons, or it likely would already have been done this way).

Add a "rolling-minimum-count" parameter, such that the "kept files count" is allowed to be fuzzy, maybe more or less than target, but set a lower bound so user can say "when rolling log files, it's ok to be fuzzy about it but never keep less than N files, even if that means rolling logic will decide not to do deletes and therefore exceed my target.

Added info:

there are multiple log streams going to the logs directory (a general.log, a backup.log, a database.log, etc... all creating their own rolled files).  I'm not certain, given code read, that the AutoRotatingFileDestination.archivedFileURLs() function is handling this right. Might be counting too many files. Unclear. I may be wrong.

I was not specifying a maxTimeInterval parameter in creating the AutoRotatingFileDestination. This caused the (somewhat odd) default of 10 minutes to be used. (Who needs to start a new log every 10 min??). So this was causing force-rotate-on-startup effect as it was often 10 minutes between one run and another, given me futzing with code and writing new test stuff in between.

My problems were ultimately due to not using critical parameter values.
I have added code documentation that would have helped me, and created a pull requests from it (no changes other than code comments). Pull requests: https://github.com/DaveWoodCom/XCGLogger/pull/311


Why are there plaintext passwords in server-config.rethink.json file etc.?

I am not sure on why the username and passwords are stored in plaintext format in the above file. Same with the case of signer file too.

The compose file is just for development and testing purposes.  You should definitely use your own config with your own passwords, or add a startup script to pull it from etcd or however you set up your own system.

I dont think this particular thing was made explicit in the production precautions document : https://github.com/docker/notary/blob/master/docs/running_a_service.md
Was it? Am I missing it?

Ah, apologies, we have no documentation for the rethinkDB stores yet because we are still working on support for it.
0.4 is probably the first release that we're officially going to provide support for for rethinkdb, so it will be coming.
We do have this line in the docs:

However, for running in production, or if you just want to change those defaults on your development service, you probably want to change those defaults.

But you're right, it should specifically be added to https://github.com/docker/notary/blob/master/docs/running_a_service.md#recommendations-for-deploying-in-production, since certificates are mentioned, when we add the rethink documentation.

Yes - I saw that line. but yes - its definitely good to add that line to rethink documentation when documentation for it is made. Thanks for clarifying.

Updated checklist in https://github.com/docker/notary/issues/828 to include rethinkdb, closing this issue.


Error : base64 is not a function since updated to 1.7.10

Hello all,
I got an issue when uploading in prod (this works in dev strangely). I catch the error from the call back from the insert on end with a nice Error during upload: Error: Internal server error [500] delivered to the client in the error param.
So I looked at the server log and here is what I get:
Exception while invoking method '_FilesCollectionWrite_images' TypeError: base64 is not a function
    at Function.from (native)
    at Function.from (native)
    at [object Object].FilesCollection._methods.(anonymous function) (/home/gui/bookmeonline/programs/server/packages/ostrio_files.js:1385:35)
    at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1737:12)
    at packages/ddp-server/livedata_server.js:719:19
    at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
    at packages/ddp-server/livedata_server.js:717:40
    at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
    at packages/ddp-server/livedata_server.js:715:46
    at [object Object]._.extend.protocol_handlers.method (packages/ddp-server/livedata_server.js:689:23)

It was working a couple days ago before my latest meteor update

Hello @guidouil

Is it on production (after meteor build) or on development stage?
If it's on production stage, what Meteor version you're on?
Are you sure you're on v1.7.10?
What Meteor version?

Yes it's in production after a meteor build.
(this all work in local)
I'm running Meteor <IP_ADDRESS>
and yes in the .meteor/versions I see<EMAIL_ADDRESS>

Whoops, I meant to ask Node.js version

Node version 4.4.2

I just updated to 4.7.3 (as meteor uses in local) and I have the same issue... do you recommend another version ?
The server is an Ubuntu 15.04 updated regularly packages wide but not up to the latest LTS.

Hello,
I have exactly the same issue.

Hello @marcchapeau ,
Could you please clarify next:

Is it on production (after meteor build) or on development stage?
If it's on production stage, what Meteor version you're on?
Are you sure you're on v1.7.10?
What Node.js version?

@marcchapeau and @guidouil
If it's possible could you post full logs from server and client, after setting debug: true option on FilesCollection Constructor?
So far I have tested latest package version on Node.js (v4.7.3) on heroku, Digital Ocean Ubuntu, Digital Ocean Debian, and on my own server running Debian. And I can not reproduce this issue.
I'm also confused about TypeError: base64 is not a function - are you using TypeScript?

And now with the debug activated it works fine 😦
here is the log of an upload and delete doing great... go figure
[FilesCollection] [File Start Method] TQXxM3oeX2P6G8MhB.png - NozcRCoa6wPkAHcgy
[FilesCollection] [Upload] [DDP Start Method] Got #-1/1 chunks, dst: TQXxM3oeX2P6G8MhB.png
[FilesCollection] [Upload] [DDP] Got #1/1 chunks, dst: TQXxM3oeX2P6G8MhB.png
[FilesCollection] [Upload] [DDP] Got #-1/1 chunks, dst: TQXxM3oeX2P6G8MhB.png
[FilesCollection] [Upload] [finish(ing)Upload] -> /data/uploads//NozcRCoa6wPkAHcgy.png
[FilesCollection] [Upload] [finish(ed)Upload] -> /data/uploads//NozcRCoa6wPkAHcgy.png
[FilesCollection] [_preCollectionCursor.observe] [changed]: NozcRCoa6wPkAHcgy
[FilesCollection] [Unlink Method] [.remove([object Object])]
[FilesCollection] [find({"_id":"KpdjybwR9TNhwg5gs"}, undefined)]
[FilesCollection] [remove({"_id":"KpdjybwR9TNhwg5gs"})]
[FilesCollection] [unlink(KpdjybwR9TNhwg5gs, undefined)]
[FilesCollection] [_preCollectionCursor.observe] [removed]: NozcRCoa6wPkAHcgy

And no, not using TypeScript. Just Babel as recommended and many other packages and npm's of course :)

And now with the debug activated it works fine

Wow-wow... Have you tried to disable "debug-mode" and confirm it's not working again? I'm just curious is there possibility something went wrong during build or deploy?
Moreover _FilesCollectionWrite method has only this one debug line.
The thing is it's saying - "base64 is not a function" there is no place in package code with function or property called as function with name of base64, only four strings with value of base64.

Yes it's in production after a meteor build. (work fine with dev mode)
meteor version is <IP_ADDRESS>
i'm on MF 1.7.10
node version is 4.4.7

Here is the server debug after trying to upload a file :
[FilesCollection] [Upload] [DDP Start Method] Got #-1/4 chunks, dst: la-video-la-plus-courte-du-pere-le-moins-responsable.mp4
Exception while invoking method '_FilesCollectionWrite_uploads' TypeError: base64 is not a function
    at Function.from (native)
    at Function.from (native)
    at [object Object].FilesCollection._methods.(anonymous function) (/home/studios_42/prod/tv42/2017-02-15_22-00/bundle/programs/server/packages/ostrio_files.js:1385:35)
    at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1711:12)
    at packages/ddp-server/livedata_server.js:711:19
    at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
    at packages/ddp-server/livedata_server.js:709:40
    at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
    at packages/ddp-server/livedata_server.js:707:46
    at [object Object]._.extend.protocol_handlers.method (packages/ddp-server/livedata_server.js:681:23)
Exception while invoking method '_FilesCollectionWrite_uploads' TypeError: base64 is not a function
    at Function.from (native)
    at Function.from (native)
    at [object Object].FilesCollection._methods.(anonymous function) (/home/studios_42/prod/tv42/2017-02-15_22-00/bundle/programs/server/packages/ostrio_files.js:1385:35)
    at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1711:12)
    at packages/ddp-server/livedata_server.js:711:19
    at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
    at packages/ddp-server/livedata_server.js:709:40
    at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
    at packages/ddp-server/livedata_server.js:707:46
    at [object Object]._.extend.protocol_handlers.method (packages/ddp-server/livedata_server.js:681:23)
[FilesCollection] [Abort Method]: thNgQYcPWqjnEBcf2 - uploads/thNgQYcPWqjnEBcf2.mp4
[FilesCollection] [remove({"_id":"thNgQYcPWqjnEBcf2"})]
[FilesCollection] [_preCollectionCursor.observe] [removed]: thNgQYcPWqjnEBcf2
Exception in queued task: TypeError: Cannot read property 'path' of undefined
    at Object.removed (/home/studios_42/prod/tv42/2017-02-15_22-00/bundle/programs/server/packages/ostrio_files.js:977:120)
    at [object Object].observeChangesCallbacks.removed (packages/minimongo/observe.js:169:28)
    at self.applyChange.removed (packages/minimongo/observe.js:71:44)
    at packages/mongo/observe_multiplex.js:182:30
    at Array.forEach (native)
    at Function._.each._.forEach (packages/underscore.js:139:11)
    at Object.task (packages/mongo/observe_multiplex.js:176:9)
    at [object Object]._.extend._run (packages/meteor.js:807:18)
    at packages/meteor.js:785:14
[FilesCollection] [unlink(thNgQYcPWqjnEBcf2, undefined)]

With debug mode ON, the problem still be there.
Thx

@marcchapeau @guidouil
So, as I understood - this error pops-up only on production, right?
If so - is this issue reproduces on dev stage wth --production flag?

And on my side without the debug it works again... So I guess it's thanks to the node update to 4.7.3 and I did not detect it before because I did not rebuild my meteor app but just stopped it and restarted. @marcchapeau can you try to update your node to 4.7.3 to see if it does fix the issue ? (I used nvm to choose exact version)

Exactly, this error pops-up only on production.
I just tried with meteor --production and it works fine.
I will try to update node to 4.7.3

I used nvm to choose exact version

I prever to compile node.js of required version on the server. NVM is good solution tooю

I use nvm too but  the same error occured with node 4.7.3

@marcchapeau did you rebuild the server tarball after node update?

Oh excuse me ! I'am a liar :)  I change the node version to 4.7.3 but start my server with the absolute path of node 4.4.7. Sorry, just give me a second.

Ok with node 4.7.3 it works for me ! Thx a lot guys

Meanwhile I found the roots of the issue.
Since node v5.* new Buffer() constructor is deprecated and Buffer.from method must be used instead. So we've added pollyfill to check if Buffer.from is supported, so folks can run meteor on newer node.js.
Weird thing is somewhere between node v4.5.* and v4.7.* Buffer.from is implemented partially, without base64 support.

@guidouil @marcchapeau
I'm glad you have fixed this issue. That was a good reason to update node.js to newer and recommended version for Meteor.
Please, support this project by:

Star on GitHub
Star on Atmosphere

Fix with better poly fill released as v1.7.11
Guys @guidouil @marcchapeau thank you for contribution


CAR skipExpansionsNode

Do not merge.
Opening PR to trigger testing

Also added a test to catch this case

I believe this fixes things up.  Reviews welcomed from @perrydv, but otherwise I'll probably merge this in on Monday.
I came to terms with the skipExpansions system part of conjugacy checking, and extended the system (skipExpansiosNode) so that it only affects the particular multivariate node in question - fixing what was causing the problem here.
I also added a test to catch this case, and make sure it's working correctly.

Hi @danielturek.  Thanks for jumping into this.  It is in some tricky processing that I don't know well, so let's go with your dive into it.  It passes tests and you added a new test.  LGTM.

Tried to remove some redundant processing from conjugacy checking


'Unexpected end of form' when transfer-encoding: chunked

I encountered a breaking change on 1.0.0 of busboy.  One of my unit-tests failed.  It sends am empty form with "transfer-encoding: chunked", e.g. the raw HTTP request:
POST / HTTP/1.1
Host: localhost:9090
User-Agent: curl/7.58.0
Accept: */*
transfer-encoding: chunked
Content-Type: multipart/form-data; boundary=---------BOUNDARY

0

<EMAIL_ADDRESS>correctly handles the request<EMAIL_ADDRESS>errors with 'Unexpected end of form'
index.js
const http = require('http');
const busboy = require('busboy');

http
	.createServer((req, res) => {
		if (req.method !== 'POST') {
			return res.status(404).send();
		}
		const bb = busboy({ headers: req.headers });
		bb.on('file', (name, file, info) => {
			console.log('file');
			file.on('data', (data) => {
				console.log('data:', data.length);
			});
		});
		bb.on('field', (name, val, info) => {
			console.log('field');
		});
		bb.on('close', () => {
			console.log('closed');
			res
				.writeHead(303, { Connection: 'close', Location: '/' })
				.end();
		});
		bb.on('error', (err) => {
			console.log('error', err);
		});
		bb.on('finish', () => {
			console.log('finished');
		});
		req.pipe(bb);
	})
	.listen(9090, () => {
		console.log('Listening for requests');
	});

To reproduce:
curl -X POST http://localhost:9090\
 --header 'transfer-encoding: chunked'\
 --header 'Content-Type: multipart/form-data; boundary=---------BOUNDARY'\
 --data-binary ''

Also, the busboy README.md does not mention anything about handling error events.  This example will crash the server if the 'error' event isn't registered. It might be a good idea to update the example.

The new behavior is more correct in my opinion. If the request doesn't even include the end boundary marker, that doesn't seem right.
As far as 'error' events go, they are standard, special events for any streams in node (any EventEmitters actually), so it doesn't make sense to duplicate such documentation. Writable stream documentation can be found here.

@mscdex, are you sure? seems like a bug to me. it doesn't contain a start or end boundary marker.  the chunk is 0.  this would be the equivalent of a form where all fields are optional, e.g. equivalent to an empty form with content-length: 0. For example:
PUT / HTTP/1.1
Host: localhost:9090
User-Agent: curl/7.58.0
Accept: */*
Content-Type: multipart/form-data; boundary=---------BOUNDARY
Content-Length: 0

The only difference here is content-length is omitted for content-encoding: chunked.
Actually, content-length: 0 also fails with "Unexpected end of form".  So it appears the issue is actually that clients can't send empty multipart forms.

Seeing as how this was introduced in a new major version, breaking changes are to be expected.

I looked for a list of documented breaking changes, but couldn't find any.

As far as 'error' events go, they are standard

Sure, but it would be a natural (and wise) thing to include 'error' in your very detailed example.

If a multipart/form-data request without the closing boundary were to be accepted, there would be no way to distinguish it from a malformed request. Even browsers send at least the closing boundary for empty forms. If there are non-browser clients sending empty forms in this way, I would say they are broken.


Utf8 printing support

Adds utf8 printing and input support
it will not affect ascii implementations

Before adding new features and new modules, please go to issues to submit the relevant feature description first.
Write good commit messages and use the same coding conventions as the rest of the project.
Please commit code to dev branch and we will merge into master branch in feature
Ensure your edited codes with four spaces instead of TAB.

增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。

Oh, it's great. I will test it in these days. BTW, can you help me add a simple test example with utf8 characters in tests directory?
Thanks.


Can't install apk files downloaded by PlaystoreDownloader

Hi,
I can't install apk files downloaded by PlaystoreDownloader.
I'm on an android 11, and when installing the apk, an error occured : "application not installed".
Could you send me some ideas of what can I do to fix this issue please ?
I search on the internet without results for now...
Thanks in advance !
Kind regards

is it a single APK or split

Hi @Nicopotame, can you provide the package names of the apps that you can't install?

Hi,
Thanks for this fast answer !
I tried a lot of apk, all of them failed on the installation. I tried on 2 different devices.
For example, there is : com.adobe.reader.apk
I think the apk file downloaded missing something that the apk found on the web have, but don't know what.
I used the python method with a Windows computer.
I really hope that it'll works at the and :)
Thanks in advance !

Hi @Nicopotame, when downloading com.adobe.reader with my account I get a file of 551 MB that I can install successfully on Android 9 (haven't tried Android 11 yet). Maybe with your android id you're getting a different apk, please check the following:

add the -s flag during download, do you get any additional file? I don't.
look at the lib/ folder inside the downloaded apk file, what directories do you see? In my case there are x86_64, x86, armeabi-v7a and arm64-v8a, do you see the same?

If your results are different than mine, then probably you are getting split apks with your android id, in such case with the -s flag you should get more than one file for each app and you should be able to install with adb install-multiple <file1> <file2> ... command. I haven't tried, so I'm not 100% sure it will work.

Hi @ClaudiuGeorgiu ,
Thanks for your answer !
I'll try it when I'll be back home(tuesday).
Do you think it'll be better to link another device to get single apk files that I could install on any device easily after ?
And do you think the split apk could be install directly on the Android device ?
I'm most familiar with singles apk files ^^
I'll answer your questions asap !
Thanks a lot for your help !

Hi @ClaudiuGeorgiu,
All apks are split as you said.
I'll be able to installed them with the adb command, thank you very much !
If anybody knows how to merge a split apk, I'd be happy to hear how do you do.
Kind regards,


Opaque GUIs block players from hearing/noticing others

Description

I was watching a replay of a round and saw two players being accidentally ignored because the player they were trying to talk with was writing on a paper or using something like a ChemMaster.
I don't think this feels natural, perhaps this type of GUI windows need to be transparent or the chat popup needs to appear over them?
it'd be kinda funny if you couldn't read a book because people are yapping

Screenshots

Current Paper GUI
Current ChemMaster GUI

I feel like both of the proposed options arent great + theres the chat box on the side. I dont really see this as a huge issue.

I feel like both of the proposed options arent great + theres the chat box on the side. I dont really see this as a huge issue.

Those are just some suggestions I came up with, y'all please feel free to find different solutions to this; Sadly not everyone pays attention to the chat box while using those GUIs, this is kinda what this issue is about.

I feel like both of the proposed options arent great

What if your game client plays a sound whenever someone points at you in-game? This way you know someone is referring to you even if you are not looking at the screen.


Make ingesters go back to PENDING state is a transfer fails.

Fixes #454

Closing in favour of #469


Support for KeyCodec[Double]

Codecov Report

Merging #1545 into master will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1545      +/-   ##
==========================================
+ Coverage   85.40%   85.69%   +0.29%
==========================================
  Files          58       58
  Lines        2206     2209       +3
  Branches      107      107
==========================================
+ Hits         1884     1893       +9
+ Misses        322      316       -6

Impacted Files
Coverage Δ

...re/shared/src/main/scala/io/circe/KeyDecoder.scala
97.36% <100.00%> (+0.07%)
:arrow_up:

...re/shared/src/main/scala/io/circe/KeyEncoder.scala
100.00% <100.00%> (ø)

...rc/main/scala/io/circe/shapes/SizedInstances.scala
78.57% <0.00%> (-14.29%)
:arrow_down:

...d/src/main/scala/io/circe/NonEmptySeqDecoder.scala
91.66% <0.00%> (-8.34%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Decoder.scala
85.59% <0.00%> (+0.81%)
:arrow_up:

...les/core/shared/src/main/scala/io/circe/Json.scala
79.88% <0.00%> (+1.11%)
:arrow_up:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
85.96% <0.00%> (+1.16%)
:arrow_up:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
96.38% <0.00%> (+2.40%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5f8591...5f88652. Read the comment docs.

I guess I'm okay with this but it makes me kind of nervous (because of the general problems with mapping between floating point numbers and strings, and also using floating point numbers as map keys).

Agree!

This would be really helpful.


Update migration guide title to reflect that it applies to both v2 and v3

I'm actually not sure it does apply to v3 -- I was about to submit a PR that makes this clear with an intro paragraph. I may change the title as well.

@eteeselink thanks for your contribution, I'm going to close in favor of #1426 which should be merged soon. Feel free to continue the discussion here, or on that PR though.

@skipjack hmm are you sure? I just upgraded from v1 straight to v3 by doing the steps in this guide. Shouldn't v2 to v3 be a noop for virtually all cases? Anyway great work and feel free to ignore this PR indeed! :-)

Yeah, the migration from v2 to v3 is pretty painless which is why you probably didn't notice any issues after following the steps for v2. I did a quick scan and definitely didn't see any mention of v3 in the guide (aside from some "this may be deprecated in v3" statements).
If someone wanted to update the guide to include v2 to v3 and then rename it Migrating Versions or something like that I wouldn't be opposed to it. Not sure that's necessary though.


[5.9] Post branch adjustments for 5.9

Use aligned branches for dependencies
Switch to "release mode" so that 999.0 tools-version becomes not usable

@swift-ci please smoke test

@swift-ci please smoke test linux

Looks like macOS self hosted is still required for the 5.9 branch? cc @shahmishal

Linux self hosted seems to be failing every time.

AFAIK like that Linux job depends on 5.9 snapshots being published on swift.org/download.

Ah that makes sense. I guess we should force merge this, then? cc @tomerd


Chore Update Benchmark Standard

Goal
The goal of this PR is to update the benchmarks using the new standard
Closes #1786

@aramikm

While it looks like that this should be using a new instance the comments on header suggests the same CPU "Intel(R) Xeon(R) Platinum 8375C CPU @ 2.90GHz"

It is still that CPU. The big change is that the memory was increased.


Unable to upload files to items in Inventory

Uploading still works for items in "Samples", but fails in uploading to items in Inventory and Equipment.

Hi @KusalvinD, thanks for reporting. I think this is a consequence of the migration of the Bocarsly group to new hardware. Previously we applied a patch that allowed any user to upload files to inventory items, and we essentially need to make this possible for everyone again. I'll prepare the patch as a PR to this repo and we can deploy on your system to test it.

Great, Thanks!

We ran into this issue this week, too. The admin user can still upload files, but the user that created the object cannot.


[Feature] Dark mode

**Is this request for a new component, or additional functionality for an existing component? **
Additional functionality
Have you validated that your desired feature or component is not already in the backlog?
Yes
Describe the component and functionality you would like to see in the starter kit
The current components do not support dark mode. It would be nice if they did.
Describe alternatives you've considered
Creating my own canvas components though this will never be that feature rich as code components.
Additional context
I created a default and a dark mode theme. I added screenshots below of the same screen having #1 the default theme and #2 the dark mode theme.
Default theme

Dark mode theme

Thanks for the feedback @formsandflows. It sounds like you're looking for a basic light and dark mode you can easily apply to an app.
Have you tried experimenting with the Theme property (https://learn.microsoft.com/en-us/power-platform/guidance/creator-kit/theme), and perhaps updating the AppTheme object to toggle between two different palettes based on a user setting you can implement in your interface?
For example, on App.OnStart you can have two themes:
/* Define the themes */
Set(AppThemes, {
    Dark: {
        Theme:
        /* START THEME OBJECT */
        {palette:{themePrimary:"#0078d4",themeLighterAlt:"#eff6fc",themeLighter:"#deecf9",themeLight:"#c7e0f4",themeTertiary:"#71afe5",themeSecondary:"#2b88d8",themeDarkAlt:"#106ebe",themeDark:"#005a9e",themeDarker:"#004578",neutralLighterAlt:"#faf9f8",neutralLighter:"#f3f2f1",neutralLight:"#edebe9",neutralQuaternaryAlt:"#e1dfdd",neutralQuaternary:"#d0d0d0",neutralTertiaryAlt:"#c8c6c4",neutralTertiary:"#a19f9d",neutralSecondary:"#605e5c",neutralPrimaryAlt:"#3b3a39",neutralPrimary:"#323130",neutralDark:"#201f1e",black:"#000000",white:"#ffffff"}}
        /* END THEME OBJECT */
    },
    Light: {
        Theme:
        /* START THEME OBJECT */
        {palette:{themePrimary:"#0078d4",themeLighterAlt:"#eff6fc",themeLighter:"#deecf9",themeLight:"#c7e0f4",themeTertiary:"#71afe5",themeSecondary:"#2b88d8",themeDarkAlt:"#106ebe",themeDark:"#005a9e",themeDarker:"#004578",neutralLighterAlt:"#faf9f8",neutralLighter:"#f3f2f1",neutralLight:"#edebe9",neutralQuaternaryAlt:"#e1dfdd",neutralQuaternary:"#d0d0d0",neutralTertiaryAlt:"#c8c6c4",neutralTertiary:"#a19f9d",neutralSecondary:"#605e5c",neutralPrimaryAlt:"#3b3a39",neutralPrimary:"#323130",neutralDark:"#201f1e",black:"#000000",white:"#ffffff"}}
        /* END THEME OBJECT */
    }
});

/* Initially assign one of the themes to the AppTheme object that will be referenced by the components */
Set(AppTheme, AppThemes.Dark.Theme);
Set(AppThemeJson, JSON(AppTheme,JSONFormat.IndentFour));
Set(AppThemeMode, "Dark");

Then, you can have a toggle in a user setting somewhere in your app that can switch between the two themes:
If(AppThemeMode="Light",
    Set(AppTheme, AppThemes.Dark.Theme); Set(AppThemeMode, "Dark");
    ,
    Set(AppTheme, AppThemes.Light.Theme); Set(AppThemeMode, "Light");
);
Set(AppThemeJson, JSON(AppTheme,JSONFormat.IndentFour));

As long as all the controls in your app are referencing the AppTheme object correctly, you should be able to create a good darkmode theme experience.


Deprecate AERYS_OPTIONS

What do you think about not using a constant?
It has the advantage of not having to define() the array (gives you more freedom when assembling options) … but maybe it is a fine as is as it forces the options to be centralized more or less in one single place.
So, please think about it … I'm unsure too.

It's a design decision to have it as a constant so everything must be at one place.

Actually I like the approach we had before this PR. I think we should only change it after we discover problems which cannot be solved with the current mechanism or requires workarounds

Well, then … and as I'm anyway unsure and just wanted some input… REJECTED! :-)


Remove unused mock

This should have been removed in the previous PR - its replacement lives under internal/repositories/github/clients/mock
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[x] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 38.896% (-0.03%) from 38.925%
when pulling 6a9709b7e5778b854ed57036b6409d1e125143de on remove-unused-mock
into 3f2ca3ed147264df85c99c20e9cddd1fb0efe6c4 on main.


Update zeropoolnetwork/bn to work with alpha release

Update https://github.com/zeropoolnetwork/bn to work with alpha/1.0.0 release.
It's a subissue of https://github.com/near/borsh-rs/issues/51

Since the PR to upgrade borsh to 0.10 https://github.com/zeropoolnetwork/bn/pull/3 has never been merged, this is low-priority and is not a blocker for the 1.0.0 release.


Update AIML@K fall 2024 seminar page

TODO

[x] update date (9/27 -> 9/6)
[x] add link to the seminar website (google sites)
[x] confirm the location + update the event
[x] send out emails to 수학과, 이과대학

The event is complete, and need to update the page at https://aiml-k.github.io/event/24-09-27-aimlk_fall_workshop_2024/


Make cq-server port configurable

On a Mac port 5000 is used and I don't want to turn the respective service off.
And sometimes I'd like to also control the host variable. <IP_ADDRESS> is pretty broad.
So support for cq-server --host <IP_ADDRESS> --port 4999 or cq-server -h <IP_ADDRESS> -p 4999 would be highly appreciated.

Thanks!
It is now included in v0.1.2 of cadquery-server.

works fine for me, thx


[Issue 349] Add single-click range picker

This adds the feature requested in #349 by allowing a range prop to be added to the DayPickerRangeController.
The range prop requires an object with optional before / after keys, these expect a function that is passed a moment object of the hovered day.
Return a moment object from each function to specify the range.
Eg. Selecting 5 days (hovered day is not inclusive)
range = {
  before: day => day.subtract(2, 'days'),
  after: day => day.add(2, 'days')
}

I've added storybook examples to show how this works across a couple of scenarios.
I'm happy to hear feedback on this and make changes to ensure it fits within your project

Coverage increased (+0.05%) to 86.76% when pulling 9dc7e04eadbb9b34e1e1e0f7238ef6d4d9990cf3 on jakeclements:custom-range-picker into e92deb3a10d0246016d4d6da28c814c41bf86773 on airbnb:master.

Appreciate the feedback @ljharb, super quick.
All sounds good to me!

Coverage increased (+0.1%) to 86.839% when pulling 4108a1e7c1ab5177bdc2f26686718b14c2e45f10 on jakeclements:custom-range-picker into e92deb3a10d0246016d4d6da28c814c41bf86773 on airbnb:master.

Coverage increased (+0.1%) to 86.839% when pulling 8b9ebb5d2819a6cacd42bf8aa3df0d9bfd05dd73 on jakeclements:custom-range-picker into e92deb3a10d0246016d4d6da28c814c41bf86773 on airbnb:master.

Thanks for taking the time to review @majapw!

Do we want to bubble up this functionality to the DateRangePicker as well?

While it's completely possible the functionality of it may be confusing. As far as I'm aware, the standard for the DateRangePicker is always to select the start and end date seperately (please correct me if I'm wrong here).
If we were to introduce this I think it'd be helpful to specify it with another prop identifier other than range.
It isn't immediately clear to me that this would create a single-click selection in this case.

Does the range functionality essentially mean you select a startDate and endDate with one click and is that... dramatically different enough to require its own picker?

That's correct. I've bundled the functionality into DayPickerRangeController because while the interaction is different, the outcome is still range selection.
If we were to create another picker I think that we may find ourselves repeating a lot of what has already been achieved in DayPickerRangeController.
We might be able to work on some of the terminology used to make this clearer. Open to hearing your thoughts here.

I find the name of the range prop and the getRangeDay method to be incredibly confusing.

Naming things is hard, I agree. Let's work on this.

I think there's also some overloading of what the hovered modifier actually does. ... something like rangeModifiers might be better?

Good call, I can update this so it doesn't affect normal hovering. I'll add a modifier that follows whatever we decide on for our naming conventions.
Happy to hear your feedback on the above.
I'll have more of a think about how we could word the language to make some of this functionality clearer and will add any suggestions as comments here.

Hey @majapw, what is your opinion on the following;
In place of range we could pass selectRangeOnClick. I think this conveys what the prop does in a much clearer manner.
It would also allow us to bubble up functionality to DateRangePicker (hopefully) without causing confusion.
<DateRangePicker
  {...props}
  selectRangeOnClick={{
    beforeSelected: fn,
    afterSelected: fn,
  }}
/>

In place of the hovered modifier I would propose something along the lines of active-range, or hovered-range if active is too closely related to selected.

Coverage increased (+0.1%) to 86.839% when pulling 82df46c1f9171d2496797c9633dc5e8e2c9cba97 on jakeclements:custom-range-picker into f0eff4f99801a97fd4d9aedd52e9b88ffe85efe7 on airbnb:master.

Coverage increased (+0.1%) to 86.839% when pulling 2f9635893e86b31f4190173b4431baf1d6992bfe on jakeclements:custom-range-picker into f0eff4f99801a97fd4d9aedd52e9b88ffe85efe7 on airbnb:master.

Ping?

@circlingthesun, I'd be keen to continue the discussion and development on this issue in the new year. If you have any suggestions as to how the props could be named/structured to suit your applications I'd be interested to hear it.

@jakeclements, I really like this PR. So I'd be keen to help things move along.
I was looking to replace a custom date picker widget when I saw this. I need to be able to select an entire week by clicking on any day of said week.
I'd agree with @majapw that getRangeDay is a bit confusing (more so than range). Perhaps use getDateOffset?
Instead of range selectRangeOnClick or range, what if we use two props called startDateOffset and endDateOffset. This way the API is more flat and you don't need to provide a NOOP function if you don't want to offset the start or end?
Thoughts?

Thanks for jumping in @circlingthesun, I like this.
offset as the core language of this functionality sits well with me in differentiating it from the normal use of date-range.
Following this we could also create hovered-offset as the modifier.
In terms of selectRangeOnClick, it's currently possible to pass a single start or end into the object to create one offset.
I don't have a strong opinion on if this would be better suited to be passed as single object vs two props, happy to follow @majapw and yourself on this.

I'll take a look tonight or tomorrow. :) I just got back from vacay.
Offset seems much clearer to me as the core word to use. Maybe even
getSelectedDateOffset?
On Tue, Dec 26, 2017, 6:19 PM Jake Clements<EMAIL_ADDRESS>wrote:

Thanks for jumping in @circlingthesun https://github.com/circlingthesun,
I like this.
offset as the core language of this functionality sits well with me in
differentiating it from the normal use of date-range.
Following this we could also create hovered-offset as the modifier.
In terms of selectRangeOnClick, it's currently possible to pass a single
start or end into the object to create one offset.
I don't have a strong opinion on if this would be better suited to be
passed as single object vs two props, happy to follow @majapw
https://github.com/majapw and yourself on this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/airbnb/react-dates/pull/884#issuecomment-354038605,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUdtYqP2cvbXCRVcdN7I3OVlOW1d_4Zks5tEakUgaJpZM4Q3KQb
.

@jakeclements is it possible to have the selection be week to week? Like a start week and an end week? So when I click a week it will show the start date be the first date of the first selected week. Then when I hover over other weeks after the first week it will fill in all the weeks in between the first selected week and the week I am hovering over. Then when I select a second week the end date will be the last day of the second selected week and all weeks in between the first selected week and the second selected week will be filled in. Thanks!

This would be using "with current week range selection" in the storybook.

@jonricaurte this functionality unfortunately isn't covered by this PR. It should be possible based on the work completed here and some modification to the existing codebase. It's probably worth opening an issue to see if this is something the Airbnb team is interested in including.

@jakeclements Thanks! Opened the following issue to track this:
https://github.com/airbnb/react-dates/issues/1035


[FEATURE] Add windows support

Is there an existing feature request for this?

[X] I have searched the existing requests

Description
The plugin does currently not work for window.
Proposed Solution
I would believe it is only a path issue.
Alternatives Considered
No response
Additional Context
No response

Solved with #17


Converting from NullableWeakRefString to String

I found this package yesterday and think it is great. When reading a feather file generated by pandas, the string columns come out as Nullable{WeakRefString{UInt8}} is there a "right way" to convert this to a DataFrame with regular Strings for this Column? I dropped the Nulls before writing the feather file, so I know there will be no nulls in the feather file.

Yes, you can Feather.read(file; weakrefstrings=false) to ensure regular Strings are generated.

Thanks


[Proposal] Force Content Trust Verification for all images.

Description
From the Content trust docs.

However, an operation with an explicit content hash always succeeds as long as the hash exists:

There should be a mechanism to force the verification of content trust for all images including images referenced by explicate content hash. There are two different ways I see this happening:

By adding a way to disable addressing an image via explicate content hash.
By Verifying image signatures of images specified via explicate content hash.

I think that adding a flag to docker-engine is probably simpler but the later is a more elegant approach.
Some background on my particular use case:
I would like to be able to use Content Trust to ensure that all images running on a machine were signed. Assuming I don't have direct control over the image names being provided, I would like to prevent images not-signed from being run. I would prefer to enforce this on the node (via Content Trust) instead of a 3rd party observer or gate keeper.

If you use a content hash there is nothing to content trust to verify - you are asking for a particular set of bits, and it will validate that the bits are the ones you ask for. Content trust is a relation between names and particular content hashes (ie sets of bits), so it can only apply to names.
Blocking specifiying explicit hashes could be done with an auth plugin potentially.
cc @riyazdf

Adding to @justincormack's answer, an authz plugin on the docker daemon could address either or both of the methods you've proposed: disabling explicit hashes or verifying signatures specified by a specific hash.


V0.9.0 compat

This PR has 2 commits - 1 to bump the dependency versions, another to update the Gopkg.toml to use dep's native pruning, as well as do the prune and update the documentation.
NOTE: I tested this against all of the 0.9.x releases. v0.9.2+ work. v0.9.0 and v0.9.1 do not work due to https://github.com/heptio/ark/pull/704 not being introduced til v0.9.2.

Do you want to squash this to one commit to avoid the add / remove of millions of vendor/ files?

I was a little torn. I'm not a huge fan of a single commit that does multiple things (updating the versions and changing our prune behavior), but here it may make sense here.

Let's go with a single commit, please

@skriss Were you able to give this a second look now that the changes are squashed?

It LGTM.  Just to make sure I understand - is this the plan - merge this, then cut a branch/tag for v0.9.x, then do a new PR to upgrade to v0.10.x, and then plan to cut a new branch/tag per Ark release going forward?

That's mostly correct.
I think master should point to ark/master and the v0.10.x should point to ark ~v0.10.0 once the version is released. So we wouldn't cut a v0.10.x branch on plugins til the ark release was available. Does that sound good?

SGTM


Add suport for user context.

Coverage remained the same at 100.0% when pulling 45f57aba2cfa1691bf82b5e3e288f2a8795a19b1 on schoolhub:add-suport-for-user-context into fdfb61b53465ac3686564f0e57bff07c82cdace2 on transcovo:master.


Any plan to use klog

Hive is using logrus but not klog, using klog may have better run time control https://github.com/kubernetes/community/blob/1d747b3720c06e795b0ef6be3cfff71fc13e8b34/contributors/devel/sig-instrumentation/logging.md
@dgoodwin comments? Thanks!

No we have not discussed klog as far as I recall,
WDYT @openshift/openshift-team-hive ?
We've been pretty happy logrus users but klog looks decent.

I don't feel too strongly one way or the other, but I haven't really found the need for more granularity in logging besides the error/warn/info/debug that we get from logrus. And I do enjoy using the WithError() wrapper in logrus.

What would we gain / lose with klog?
I've honestly never used it (nor glog), so I can't really say one way or
the other.
On Mon, Nov 4, 2019 at 11:38 AM Joel Diaz<EMAIL_ADDRESS>wrote:

I don't feel too strongly one way or the other, but I haven't really found
the need for more granularity in logging besides the error/warn/info/debug
that we get from logrus. And I do enjoy using the WithError() wrapper in
logrus.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/hive/issues/649?email_source=notifications&email_token=AAFS5Q3FPPZSICOGHL3LGOTQSBFWXA5CNFSM4JICGIB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC74LRA#issuecomment-549438916,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFS5QZ7SJJSMW7XXEZ2HUTQSBFWXANCNFSM4JICGIBQ
.

I can see the most advantage of klog is that I can know where the log is from, i.e. which file and the code line number etc, but for now, it is difficult to analysis the log for hive now:
time="2019-11-05T08:32:59Z" level=info msg="metrics calculation complete" controller=metrics elapsed="610.672µs"
time="2019-11-05T08:32:59Z" level=info msg="reconcile complete" controller=metrics elapsed="636.221µs"

thank you for the suggestion. No plans to switch at this time.


python312Packages.censys: 2.2.14 -> 2.2.15

Diff: https://github.com/censys/censys-python/compare/refs/tags/v2.2.14...v2.2.15
Changelog: https://github.com/censys/censys-python/releases/tag/v2.2.15

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 349380 run on x86_64-linux 1

6 packages built:

python311Packages.censys
python311Packages.censys.dist
python312Packages.censys
python312Packages.censys.dist
theharvester
theharvester.dist


add onAfterPublish method

Hey @alex-dna, VersionedDataObject extends the built-in Versioned extension, so the "onBeforeVersionedPublish" hook from Versioned::publish should be useable here. If you need the hook to run after the live table has actually been written to, then that will need a change like this.
Your PR looks like it would work, but it seems like an overly complicated way to achieve the result. Did you try overriding the publish method from Versioned? It would be easier to read:
public function publish($fromStage, $toStage, $createNewVersion = false)
{
    parent::publish($fromStage, $toStage, $createNewVersion = false);
    $this->owner->extend('onAfterVersionedPublish');
}

Thanks @stecman , it seems like a much better solution. I've created a new pull request.


Do the docs reflect usage of set operation?

Refer to this convo for details, but it seems we need to increase our docs about 1set``, use it in more examples, etc.
https://prisma-company.slack.com/archives/C02JV0K2Q31/p1651505158811669

👋 we're cleaning up our backlog of issues and are closing everything older than two years. If you still feel that this issue is relevant, please feel free to re-open and our team will take a look. Thank you!


Share Tier Lists

As a Tier list creator, I would like to be ablet to share my tier lists with other site users.

Will resolve after #4


fixing envoy-config.yaml to take release name for endpoints address S…

Updating the envoy-config.yaml to pick dynamically Release Name (chart name) for envoy endpoint socket_address

approved by Ronen and Pradeep


Add the support of the BLMPOP command

Search before asking

[X] I had searched in the issues and found no similar issues.

Motivation
This issue considers to support the blmpop command.
Solution
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

please assign to me

@git-hulk Hello, I've just finished the LMPOP command, and seems this BLMPOP command is quite similar (just adding the Blocking semantic), so maybe you could assign this one to me as well.

@HolyLow Sure, thanks for your contribution.

@PragmaTwice @torwig We have many blocking commands, so we copy the blocking implementation codes in many places, not sure if we can simplify this.


Webhook for Microsoft Teams

Would be useful to have Webhook Support for Microsoft Teams.
Microsoft Teams Incoming Webhooks First Steps
Microsoft Teams Message Card Reference
Where could I start to implement. Do we just need a "template"?

This search should be a good place to start
Anywhere there is a Discord (or other) webhook will likely need some slight modifications to allow for another webhook.

+1 for this, just moved from mattermost (which supports Slack webhooks) to Microsoft Teams. Would be extremely useful to have full support for this.

I'll use that too. I thought about writing some kind of WebApi converting gitea webhooks to teams. @frunika tell me please if there is something to test.

@road42 Microsoft Teams webhooks are now in master if you still wanted to try them out

Closing per merged Pr

Works perfect! :)


Cannot see languages in UESRPG

Describe the bug
No languages appear in the list for the DM.
To Reproduce
Steps to reproduce the behavior:

Enable Polygot in UESRPG system.

Expected behavior
As DM, see all available languages.
Screenshots

Foundry 0.8.8. UESRPG 1.33
Polyglot Version <IP_ADDRESS>
Are you using Babele?

Thanks for reporting it. It should be fixed now.

The latest patch has caused this error again.


Changelog for versions above 0.9.1

Hello,
is it there changelog for versions above 0.9.1 up to current 1.3.1. I don't know whether is safe to update to next major version without checking changelog for possible breaking changes.
Thank you.

Hi @novalu,
My bad, I could have sworn that I maintained a Changelog over time -- I guess not.
Here's the PR for 1.0 that has the breaking changes: #147
The key changes is that Flyfile.js now has to be lowercase, flyfile.js. The flyfile must also be written in native ES5. Check out the updated example in the readme.
If you would like to continue to write flyfiles with ES6/7 syntax, you must install fly-esnext before doing so. There's also an example of this in the readme.
Changes after 1.0 have mostly been new internals and/or fixes.
In the meantime, I'll work on getting together a true changelog.

I'm going to close since it's been over a year since 1.0 and roughly 6 months since 2.0... Any existing users will have upgraded by now. 😬
From now on, I'll be making sure to use the Releases tab as an official changelog. It's now a habit that I've been practicing & really find this as the most helpful method.
Sorry about the inconvenience & neglect -- it's 100% my fault. I promise I'll do better in this arena. 👍


First Contribution By Harshita Badwal

Name: Harshita Badwal
Project Assigned: InterpretML
Important links:
WEBSITE:
https://interpret.ml/
GITHUB:
https://github.com/interpretml/interpret/
README PAGE:
https://github.com/interpretml/interpret/blob/develop/README.md
GOVERNANCE PAGE:
https://github.com/interpretml/interpret/blob/develop/GOVERNANCE.md
InterpretML
A governance model is a set of guidelines that establishes the management and control of projects. There are various governance model types, and the choice of model depends on the objectives and requirements of the project or organization.
Interpret ML is an open source python package developed by Microsoft Research that provides a tool that is used for interpreting and explaining machine learning models. This package helps to train interpretable glass box models and black box systems.
As an open-source project,  InterpretML follows a community-based governance model in which the project's development and maintenance are guided by a team of core contributors and a larger community of contributors and users. The project's core contributors are in charge of supervising the project's direction, evaluating and integrating code contributions, and making sure the project is of a high standard and stable. They specify the project's roadmap and rank the importance of adding new features and fixing bugs.
Overall, the governance model for InterpretML is designed to promote collaboration and community participation, ensuring that the project evolves and improves over time.
Roles:

Maintainer
Contributors

Decision-Making Process:
Decision-making is one of the most important factors.InterpretML has two types of decision-making processes.

Consensus-Based Decision Making. :
Project choices are made by the maintainers' contracts. Consensus doesn't really require explicit agreement from all Maintainers. Maintainers will decide on a consensus after carefully considering a number of factors, including the Contributors' dominant viewpoint and the nature of support and opposition. As per these specifications, the Maintainers will provide paperwork of the consensus.
Appeal Process:
Choices may be offered by opening an issue which request will be considered by the maintainers in great confidence, who will react in composing within a sensible time. On the off chance that the maintainers deny the offer, the request may be brought sometime recently to the TSC, who will also react in composing in a sensible time.

How do we work?

Openness:
All individuals affected by the activity are eligible to participate. There won't be any unreasonable financial barriers to taking part.
Balance: There should be a balance of interests during the development process. In order to strike a balance, contributors with a variety of interests will be sought out.
Coordination and Harmonization: Any conflicts or incompatibilities between releases in this Project must be resolved in good faith.
Consideration of Views and Objections Brief thought will be given to the composed perspectives and complaints, all things considered.
Written procedures. Anyone who is interested in learning more about the project's development process can access this governance document and other materials.

No Confidentiality:
Regardless of any markings or statements to the contrary, information disclosed in connection with any Project activity, including but not limited to meetings, contributions, and submissions, is not confidential.
Trademarks.
Regardless of ownership, the Project's names, trademarks, logos, and goodwill may only be utilized in accordance with the Organization's Trademark Policy.
How easy or difficult it was to find and understand the governance model?
As I am new to open source contribution so I faced a little difficulty understanding the project but then I do a lot of research and I find it quite interesting . Earlier I only heard the name of the governance model but now with this first contribution, I am able to understand the governance model more clearly. According to my understanding, the mission of interpretML is to make machine learning models more transparent and explainable to both experts and nonexperts.

cc @arliss-NF
kindly review my first contribution.

@Harshita221 - very thorough first task.  I hope you will continue to develop with open source.  We hoped that we would have applicants like you taking their first steps in open source.  Learning how projects govern themselves is valuable knowledge.


drawio: 20.2.3 -> 20.2.8

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/jgraph/drawio-desktop/releases.
meta.description for drawio is: "A desktop application for creating diagrams"
meta.homepage for drawio is: "https://about.draw.io/"
meta.changelog for drawio is: "https://github.com/jgraph/drawio-desktop/releases/tag/v20.2.8"
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 20.2.8 with grep in /nix/store/p3k871l1lfr53ywh2ld64hacfwlch5y0-drawio-20.2.8
found 20.2.8 in filename of file in /nix/store/p3k871l1lfr53ywh2ld64hacfwlch5y0-drawio-20.2.8

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
drawio
drawio-headless
pandoc-drawio-filter
python310Packages.mkdocs-drawio-exporter
python39Packages.mkdocs-drawio-exporter

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/p3k871l1lfr53ywh2ld64hacfwlch5y0-drawio-20.2.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A drawio https://github.com/r-ryantm/nixpkgs/archive/65e141c1c491b4be7dbf6d789a56bf52f593a570.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/p3k871l1lfr53ywh2ld64hacfwlch5y0-drawio-20.2.8
ls -la /nix/store/p3k871l1lfr53ywh2ld64hacfwlch5y0-drawio-20.2.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages built:

drawio
drawio-headless
pandoc-drawio-filter
python310Packages.mkdocs-drawio-exporter
python39Packages.mkdocs-drawio-exporter

Maintainer pings
cc @DarkOnion0 for testing.

Replaced by #190546


FTMS_gatt_server as an example

FTMSserver creates a bless server with a FTMS profile
FTMSclient inspects what ble-devices are present, searches for FTMS server and prints the service/characteristics structure
FTMSserver is inspired by bless/examples/gattserver.py
FTMSclient is inspired by bleak/examples/discover.py and service_explorer.py
First start FTMSserver, then FTSMclient.
See QUESTION: How to define the Generic Access Profile (during BlessServer creation)?

@WouterJD any chance you can get the checks to pass before merge?

I will give it a try Monday. ThanksMet vriendelijke groetWouter Dubbeldam -------- Oorspronkelijk bericht --------Van: Kevin Davis @.>Datum: za 28 mei 2022 02:55Aan: kevincar/bless @.>Cc: Wouter Dubbeldam @.>, Mention @.>Onderwerp: Re: [kevincar/bless] FTMS_gatt_server as an example (PR #77)
@WouterJD any chance you can get the checks to pass before merge?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

I must use the development branch to test, right? Met vriendelijke groetWouter Dubbeldam -------- Oorspronkelijk bericht --------Van: Kevin Davis @.>Datum: za 28 mei 2022 02:55Aan: kevincar/bless @.>Cc: Wouter Dubbeldam @.>, Mention @.>Onderwerp: Re: [kevincar/bless] FTMS_gatt_server as an example (PR #77)
@WouterJD any chance you can get the checks to pass before merge?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Refer to the contributing guidelines

@WouterJD any chance you can get the checks to pass before merge?

Yes, BLESS now works fine under windows.
I have tested FTMS_gatt_server as well as FortiusAnt; both recognized well from Trainer Road as a FTMS.
Thanks!

Closing this for now because of CI failures and lots of non generic code for an example.

... non generic code for an example.

Agree; it's a full BLE client/server implementation of a Fitness Machine.


Include full user object on login audit events

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

The audit log events for when a user logs in to the editor included the username of the user, but not their full profile object - which other audit events have.
This brings these events into line with the others.

Coverage remained the same at 67.37% when pulling 96840ede56bd7802c5aac2f626aacdcaa59f0b33 on auth-id into 3e0f080ea7511bbf242a079d3f504e266c6d04e1 on master.


⚠ Fetchers has degraded performance

In 2465267, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 343 ms

Resolved: Fetchers performance has improved in 27bb276.


Adds DeM indicator

Creates the DeMarker Indicator (DeM), an oscillator-type indicator measuring changes in terms of an asset's High and Low tradebar values.
Description

Adds the DeMark indicator.
Related Issue
#4918

Motivation and Context

Added feature due to request.
How Has This Been Tested?

Added a test comparing results to those obtained in https://github.com/dmitriiweb/tapy (using the same CSV but combining Date and Time and making it into a .txt). The values in the test data was generated using the DeM indicator as implemented in TaPy.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[ x] My code follows the code style of this project.
[ x] I have read the CONTRIBUTING document.
[x ] I have added tests to cover my changes.
[x ] All new and existing tests passed.
[ x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Thanks @AlexCatarino! I implemented the requested changes.

Thank you @aarjaneiro


Add new recipe

Sweet Rice Recipe

@sofiavrebelo a requested small change

Thanks Jen! I ll correct it tomorrow morning!
A quarta, 7 de set de 2022, 20:53, Jen Looper @.***>
escreveu:

@sofiavrebelo https://github.com/sofiavrebelo a requested small change
—
Reply to this email directly, view it on GitHub
https://github.com/FrontEndFoxes/kitchen-sune/pull/47#issuecomment-1239808488,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A25C2TG3FECEOMWEW2VA3QDV5DXCZANCNFSM6AAAAAAQF4SDFU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi Jen, I noticed that the title of the recipe appears as "title of
recipe", so i'll try to send a pull request asap to correct that
Jen Looper @.***> escreveu no dia sábado, 10/09/2022
à(s) 21:53:

Merged #47 https://github.com/FrontEndFoxes/kitchen-sune/pull/47 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/FrontEndFoxes/kitchen-sune/pull/47#event-7361412882,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A25C2TF6XIXB6CDNZS4CZQ3V5TYONANCNFSM6AAAAAAQF4SDFU
.
You are receiving this because you were mentioned.Message ID:
@.***>