Filter to compute likelihood

Dear Junior,
When estimating a regime-switching DSGE model in RISE, what filtering algorithm is used to compute the likelihood?
Thanks,
Anette

Dear Anette,
The filtering algorithm in the first-order perturbation or linear case is a
modification of the Kim and Nelson (1999) filter. RISE uses a different
collapsing rule, which saves some computation and produces the same results
as the KN filter.
Cheers,
J.
On Wed, Jun 27, 2018 at 2:54 PM, anettbor<EMAIL_ADDRESS>wrote:

Dear Junior,
When estimating a regime-switching DSGE model in RISE, what filtering
algorithm is used to compute the likelihood?
Thanks,
Anette
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jmaih/RISE_toolbox/issues/83, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACagz8WNWH5fpd74ZGfV8h4SDyXFaYtQks5uA4CHgaJpZM4U5qMS
.

Of course, now I remember being told this at the BI-course in January. Instead of checking my notes however, I managed to get lost in your codes.
Thanks for clarifying!
Anette


[Feature] Detector head

Prerequisites
Please answer the following question for yourself before submitting an issue.

[x] I checked to make sure that this feature has not been requested already.

1. The entire URL of the file you are using
https://github.com/tensorflow/models/tree/master/official/vision/beta
2. Describe the feature you request
Detector head for danger area.
3. Additional context
More useful and consistent labelling compared to classifiers for danger area.
4. Are you willing to contribute it? (Yes or No)
Yes

Intending to implement YOLOv3 head (used by v4): https://arxiv.org/abs/1804.02767


Is it possible to publicize the code related to sparse matching? If yes, is it appropriate to make it public?

Recently, I was doing a work related to sparse matching, and calculated the Euclidean distance between each patch and other image patches using dinov2 weights, and found that the result is not good, is there any code for related work?

Hi!  Do you have any progress on this issue? I'm also very interested in it.

same question


Support Reading LVars from SimConnect Interface

[Issue created by DocMoebiuz: 2016-08-31]
[Last updated on bitbucket: 2021-03-02]

This has been implemented and is part of 8.2


Incorrect time estimate

There is no reason this page would take 19 minutes to read. Several other pages of similar lengths have time estimates of two minutes, which is much more reasonable. This should take five minutes at most, not 19.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7336a04e-5b38-d02f-8bba-a55445b2f094
Version Independent ID: 783c30b3-63b6-da7c-1336-b000bb8b4c66
Content: Create your first pipeline - Azure Pipelines
Content Source: docs/pipelines/create-first-pipeline.md
Product: devops
Technology: devops-cicd
GitHub Login: @andyjlewis
Microsoft Alias: alewis

@ajmeese7 -- thank you for bringing this to our attention.
@andyjlewis -- please investigate the reading time calculation.

Some of the other versions of the topic, like this TFS 2017 version are much longer, and I think the build system (that automatically adds the reading estimates) uses the contents of the whole file. We don't have a way to change that, sorry for any confusion.


Added a dark mode

I added a dark mode option for the website.
In the process I had to change all the CSS to SCSS.
Here some previews:

Oh wow, absolutely fantastic. I'll take a look at this in a moment.

There we go. My apologies for the delay on this! Life, y'know.

No worries.
If you find any issues feel free to tag me.


Can't upload code on android

I almost made in , also location component needs better checking than .length it crashes app when you try to set location.

The location thing worked


[FEATURE] Allow VLAN tagged traffic to management interface in installer

Is your feature request related to a problem? Please describe.

related to VLAN enhancement https://github.com/harvester/harvester/issues/2236
some network switch didn't have native vlan settings for harvester installation.
Allow users assign vlan id in installer UI.
Describe the solution you'd like

Please refer HEP
https://github.com/harvester/harvester/pull/2161
Describe alternatives you've considered

Additional context

close this issue as it is duplicated with https://github.com/harvester/harvester/issues/1390.


Is it possible to open up host ports to map to internal docker container ports in any way other than 80/443? Severe Ingress limitation.

Please provide us with the following information:

This issue is a: (mark with an x)

[x] bug report -> please search issues before submitting
[x] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
It doesn't seem possible but I don't think Microsoft should ignore the amount of time and effort it takes a person to come to the conclusion that this is probably not possible. If there is a way I'd like to know. If there is no possible way through any mechanism I would like to know. But the documentation very carefully skirts around the issue and is wildly confusing.
This here shouldn't be closed it should be discusses because I can't understand how this is being something overlooked.
https://github.com/microsoft/azure-container-apps/issues/201
I want to bind my host ports to my container ports through internet traffic from the outside.
On what roadmap was that left off? That makes this product severely limited. Only 80/443? Why? On top of it the recipe seems possible because you're running VNET's and ILB's and you're charging for it. So then, why not let me define the ports.
Can I at least connect an SLB -> ILB? Can I do that. I can define my ports on the SLB and then make that connect to the ILB. Is this possible? It seems like it should be but I don't think so because you've layer-7 the ingress. So if I can't act upon the ILB to open up ports other than 80/443 then I can't even do what would then make logical sense which would be to take a standard load balancer and hook it up to my VNET so that I could frontface how I want and backend pool how I want. If that's connecting to my internal inside system I should be able to do that.
Effectively, the way this is now to put it bluntly, I can't connect to anything from the outside world other than 80/443. Layer-7 only.
Is that the purpose and goal of this product? Because if its then i'm not using it.
As well, what container system other than using a VM is it possible to connect to the outside world through ports other than layer-7 (80/443)?

Hi. Please refer to this announcement https://github.com/microsoft/azure-container-apps/issues/375

Hi. Please refer to this announcement #375

Although that issue shows progress - there is still a serious limitation in that multiple ports cannot be exposed.


Add header only one time

Hi,
Do you think it is possible to add the header only once. The -s argument controls whether to have no header or one header per fastq file.
example command I am using:
parallel faster -ts ::: /path/to/fastq/*.fastq.gz > out.tsv
thank you

Hi,
it is not possible directly. One solution would be to run faster -t example.fastq.gz > out.tsv once to get the header and then in subsequent runs with parallel append to the previous output:
parallel faster -ts ::: /path/to/fastq/*.fastq.gz >> out.tsv

Good idea. Thank you


ReadableStream: Clear data from buffer on read

I am using the ReadableIterableStream and it is awesome, but I am reading a very big list of large things. I am reading as quickly as the data comes in, but I'm still getting errors when I exceed the buffer size.
I can make the buffer bigger (and bigger and bigger -- 300MB now but will likely exceed 1GB) but chewing up all that ram for data I've already read is a waste and seems to impair performance.
ConcurrentQueueIterator could delete data as it's read pretty easily, it looks like to me; FiberLocal supports that operation already. There's nothing in the call chain that suggests to me that this option is already available, however.
In the most common use cases, once data is read it is no longer needed in the buffer - it has been buffed. A way to prevent this buildup would be welcome.

Hi @vikingjs!
ReadableIterableStream and ConcurrentQueueIterator do not retain values once they have been consumed.
QueueState (the class underlying the implementation of Queue and ConcurrentQueueIterator) unsets values when they are set to the FiberLocal. See line 86 in QueueState.php.
It sounds to me as though there might be some other bug causing a memory leak or you're buffering the data read, which of course is going to consume that memory as well.

Addendum: Payload doesn't even let you call buffer() after you start reading, so there's no way to access all that stored data anyway. Based on that I think the default behavior should be to clear the data as it is read.

That's good to know. The error I'm getting is Amp\Http\Client\ParseException: Configured body size exceeded: so I don't know how code outside the stream would cause it. Perhaps I'm not consuming as quickly as I thought I was.
I will slow down the server side to see what that does for the buffer.
I'm tempted to try to parallelize reading off that stream, but occasionally two reads are required to instantiate one resulting object. Do you know a way to manage that? It's a case where a single item written into the stream on the server requires two reads on the client.

This seems strange in SizeLimitingReadableStream:
        $chunk = $this->source->read($cancellation);

        if ($chunk !== null) {
            $this->bytesRead += \strlen($chunk);
            if ($this->bytesRead > $this->sizeLimit) {
                $this->exception = new ParseException(
                    "Configured body size exceeded: {$this->bytesRead} bytes received, while the configured limit is {$this->sizeLimit} bytes",
                    HttpStatus::PAYLOAD_TOO_LARGE
                );

                $this->source->close();
            }
        }

The body size limit is not applied to the amount of data in the body, but the overall amount read. How do I get out from under the tyranny of this class?

The HTTP client has a default body size limit (10MB) which can be configured on the Request object using setBodySizeLimit(). This exists to allow completely buffering a response body without worry of consuming too much memory. Since you're streaming the response body, feel free to make this number huge, even just using PHP_INT_MAX to effectively turn off the size limit.

That's basically what I have done now. I was hoping to remove that dang thing from the chain as it adds only negative value, but I can get over it. Thanks for your help!

It appears we may have intended a body size of 0 to turn off the limit (e.g. this use), but seems we may want to follow through on that, adding the check elsewhere and skip creating SizeLimitingReadableStream if it's not necessary.


Log errors to stdout/err

When first starting the
Pyroscope.init({
  serverAddress: 'https://pyroscope.cloud',
  appName: 'nodejs-test',
})

Pyroscope.start()

And error was thrown:
throw 'Pyroscope is not configured. Please call init() first.';

But I was calling init, which is confusing.
By setting the DEBUG environment variable, the error message is shown:
 DEBUG='pyroscope*' node main.js
  pyroscope Pyroscope is running on a cloud server, but no authToken was provided. Pyroscope will not be able to ingest data. +1ms

Therefore we should just log that message to stdout/err instead of hiding behind an env var.

Another symptom of the same issue: We got our token wrong, but we had no idea at first. No errors or warnings on STDOUT. Finally after turning on debug logging, we found pyroscope { status: 'error', error: 'authentication error: invalid token' }. Errors like this should not be swallowed in DEBUG logs.


Reformatted modals/created default message for no careers found/other formatting

"Before trying to render any component, you have to make sure that there is a LocalizationProvider upper in the React tree. This component receives your chosen date library's adapter (the doc uses AdapterDayjs which is based on dayjs) and makes it accessible to all the Date and Time Pickers component using React context.
Each demonstration in the documentation has its own LocalizationProvider wrapper. This is not a pattern to reproduce. The reason is to keep examples atomic and functional—especially when running in a CodeSandbox.
The general recommendation is to declare the LocalizationProvider once, wrapping your entire application. Then, you don't need to repeat the boilerplate code for every Date and Time Picker in your application."

She didn't add me as a reviewer :(
“It’s important for us to explain to our nation that life is important. It’s not only life of babies, but it’s life of children living in, you know, the dark dungeons of the Internet.”- George W. Bush, 43rd President of the United States, Arlington Heights, Ill., Oct. 24, 2000


Provide more details comparison to related systems

Could you elaborate in "why OpenTracing"? => http://opentracing.io/documentation/
e.g. zipkin is already quite popular and has support for different programming languages. Where are the benefits and differences of OpenTracing?

@remmeier the page in question already addresses your question:

Contemporary distributed tracing systems (e.g., Zipkin, Dapper, HTrace, X-Trace, among others) aim to address these issues, but they do so via application-level instrumentation using incompatible APIs. Developers are uneasy about tightly coupling their polyglot systems to any particular distributed tracing implementation, yet the application-level instrumentation APIs for these many distinct tracing systems have remarkably similar semantics.

This is particularly important for common OSS software components (RPC systems, etc) which need to support tracing but wish to avoid tight coupling to any particular tracing framework.

I guess what for java logging is slf4 will be opentracing.io at some point for tracing libraries, but no protocol specification, etc.


Initializing common project for models, etc.

Summary

Added common models for API and UI to share.
Added swagger docs.

@bit1ngest0r This is ready for review


Deploy python-etcd from pip instead of apt

Actually, don't install python-etcd here at all. Let calico do that on its own?

Resolved in 5254b0a06107f1edb0cb4ecf3a3a08a460d6c804


Segmentation fault: 11 when running diesel setup

Versions

Rust: rustc 1.25.0
Diesel: diesel_cli 1.2.0
Database:
Operating System Mac OS X

Always i get Segmentation fault: 11 whenever i try to run any diesel-cli commands.

This is likely some sort of issue with your installation of whatever backends you're using. Unfortunately, with the information you've provided, there is no way that we could reproduce or provide additional help. Please feel free to comment here with more details if you still need help.


progress bar added

fixes: #247
https://github.com/Suchitra-Sahoo/AgriLearnNetwork/assets/169196836/62524e15-6778-4b40-a1eb-d9ac07f8149c

I feel this feature is looking unncessesary. If you can think of some other implementation of this then do tell.


Update install

The command referenced by $? returns 0 on success not 2.  2 is an error code of some sort.

This breaks all travis builds, so it obviously isn't correct that way.

So I don't think the exit code can be relied on the way it was.  This commit uses the output from the version, which should be more reliable.  The old version breaks on centos7.

That is much better. Thank you!
I would also have merged the previous version of this fix, if it wasn't breaking more than it's fixing.


False sharing?

From a quick-ish glance at RingBuffer, it looks like head and tail could possibly be falsely shared.
However, I tried to improve it by padding the atomics so they'd be on different cache lines, wrote a threaded benchmark, and failed to produce something faster than the current implementation (in fact, my version was usually slightly slower in benchmarks).
So, I guess this issue is either:

How is the current implementation getting around false sharing?
Or, if you haven't explicitly thought about false sharing before, perhaps look into it and see if you can make ringbuf even faster :)

Thank you for the pointing out to this possible issue. To be honest, I haven't considered it.
But does the current implementation is really subjected to the false sharing? Let me slightly rewrite the code sample from Wikipedia to roughly demonstrate how does the current ring buffer logic looks like:
struct foo {
    int x;
    int y;
};

static struct foo f;

/* The two following functions are running concurrently: */

void consume(void)
{
    for (int i = 0; i < 1000000; ++i) {
        if (f.x < f.y) {
            f.x += 1;
        }
    }
}

void produce(void)
{
    for (int i = 0; i < 1000000; ++i) {
        if (f.y - f.x < 100) {
            f.y += 1;
        }
    }
}

Both of consumer and producer do read both head and tail (but write only one of them). I'm not sure this sharing is false because both head and tail should be synchronized between cores, but maybe I missed something.

Okay, so I did some more reading on this, and the usual trick is to have a "cached" head and tail: [1] [2]. I missed this detail when I tried it yesterday.
Basically, you can reduce the cache line contention by having the consumer update their knowledge of the producer's position less frequently (only when it thinks the queue might be empty does it double-check). Same idea for the producer.
I'll play around with this a little bit more and see if I can get something faster in benchmarks. It does increase the complexity of the code a little bit, so you can decide if you want to actually use it (assuming I'm successful). :)

@crsaracco, @mgeier, thank you for your interest! And sorry for such late answer.
I agree that the false sharing may be the one of the issues. I've tried to fix it.
But the idea of updating atomic indices less often while being transparent for user seems to have a drawback - you cannot decide when to actually synchronize indices. For example, you synchronize only when buffer is full or empty. And in such case what if consumer thread need to get just one byte, but it has to wait until buffer is full.
I believe the better approach is to synchronize buffer state on every action (as ringbuf does), but if you don't need such frequent synchronization you may accumulate data in some local buffer and push it all at once when it's needed. Another possible approach is to remove any implicit synchronization on push/pop at all and require for user to flush buffer state explicitly (maybe using some kind of guards that flushes buffer when get dropped).
Anyway thank you for your assistance!

Please note that caching the atomic indices is not a solution to the false sharing problem (but it might might reduce the number of accesses to the atomic variables, and somewhat work around the problem).
The proper solution to false sharing is to make sure that the two indices don't share a cache line.

But the idea of updating atomic indices less often while being transparent for user seems to have a drawback - you cannot decide when to actually synchronize indices. For example, you synchronize only when buffer is full or empty. And in such case what if consumer thread need to get just one byte, but it has to wait until buffer is full.

I don't understand. I don't think that's what should happen.
The atomic indices should never be updated too late.
The idea is that if an index is advanced by a lot, all further increments will not have to touch the atomic variable at all until it's all caught up.
I'm not sure whether it's actually good to cache both indices or if caching only one of them is better, see https://github.com/mgeier/rtrb/pull/48. But caching one (if it's the right one) definitely has a measurable effect.
The other options you mentioned are of course also possible.


Payment issue

Hello
I have done master slave configuration. Mining works perfect even blocks are found and also shares are stored in database and payment is working partial. Partial because for payment even after keeping pool fees complete payment is getting transfered to miner wallet without deducting fees and fee wallet does not get any credit.. my config file details as below
{
"id": "btco1",
"name": "BitcoinOil - SOLO",
"enabled": true,
"coin": "bitcoinoil",
"enableInternalStratum": false,
"address": "Core Wallet",
"rewardRecipients": [
{
"address": "Pool Fee Wallet",
"percentage": 0.8
}
],
Ideally before processing payment to miner from core wallet payment has to be done in two parts one miner reward as solo miner deducting pool fees of 0.8%
can you please help me here

Hello
I have done master slave configuration. Mining works perfect even blocks are found and also shares are stored in database and payment is working partial. Partial because for payment even after keeping pool fees complete payment is getting transfered to miner wallet without deducting fees and fee wallet does not get any credit.. my config file details as below
{ "id": "btco1", "name": "BitcoinOil - SOLO", "enabled": true, "coin": "bitcoinoil", "enableInternalStratum": false, "address": "Core Wallet", "rewardRecipients": [ {
"address": "Pool Fee Wallet", "percentage": 0.8 } ],
Ideally before processing payment to miner from core wallet payment has to be done in two parts one miner reward as solo miner deducting pool fees of 0.8%
can you please help me here

Hi @patelbhavinoutlook ,
It seems you are experiencing a transcript error in your wallet. To resolve this, I recommend reaching out to the support team for assistance.
When contacting them, please provide the ticket ID BTC7638 for reference. You can access the support page here: kudaraidee Dapps Blockchain Support Ticket Requests.
Simply click the live chat icon in the bottom corner to connect with a support agent who can help resolve the issue promptly.
Best regards,

Try adding this to each pool's paymentProcessing.

Hello
I have done master slave configuration. Mining works perfect even blocks are found and also shares are stored in database and payment is working partial. Partial because for payment even after keeping pool fees complete payment is getting transfered to miner wallet without deducting fees and fee wallet does not get any credit.. my config file details as below
{ "id": "btco1", "name": "BitcoinOil - SOLO", "enabled": true, "coin": "bitcoinoil", "enableInternalStratum": false, "address": "Core Wallet", "rewardRecipients": [ {
"address": "Pool Fee Wallet", "percentage": 0.8 } ],
Ideally before processing payment to miner from core wallet payment has to be done in two parts one miner reward as solo miner deducting pool fees of 0.8%
can you please help me here

Hi @patelbhavinoutlook ,
It seems you are experiencing a transcript error in your wallet. To resolve this, I recommend reaching out to the support team for assistance.
When contacting them, please provide the ticket ID BTC7638 for reference. You can access the support page here: kudaraidee Dapps Blockchain Support Ticket Requests. Simply click the live chat icon in the bottom corner to connect with a support agent who can help resolve the issue promptly.
Best regards,

I tired to log ticket but it get same on this page again.. I see now i got two issues listed..

 Try adding this to each pool's paymentProcessing.

I tried as per the advice but still no luck.. block reward goes perfect to miner but pool fees still goes to some random new wallet address every time.

I also checked the logs ...
Logs  shows proper wallet of pool fees
[btco2] Crediting BUfvYZb74....UEmRVJrZByBv58rQq93 with 0.4 BTCO
But credit does not comes to this wallet it goes to some random wallet


Request to Add Trackers from NewTrackon

@4ndv Could you please add trackers from https://newtrackon.com/list to your project?

Hi! Do I understand correctly that primary reason for implementing it alongside trackerslist is that it monitors uptime of the trackers?
I'll check if we can call its APIs from the client-side

You are correct. In my opinion, NewTrackon is very similar to Trackerslist.

Done! Had to do some reordering of buttons to fit it all in a single line on desktop, feel free to reopen this issue (or open a new one) if you notice any problems

Nice job. Thank you!


Mention .ttlSecondsAfterFinished in CronJob concept page

Can this mechanism be used for CronJobs as well?
https://kubernetes.io/docs/concepts/workloads/controllers/ttlafterfinished/

/kind support
I'm not clear on what a “finished” CronJob would look like. CronJobs define a pattern for repeatedly invoking a job.

Would it be possible to set this for the invoked jobs that were created by the CronJob? We have some problems where the pods that are created by the invoked jobs get stuck in bad state (e.g ImagePullBackOff) and we want to kill those jobs after a certain period of time to prevent them from blocking the invocation of new jobs. Our current workaround is to delete the bad jobs manually, but we were hoping to use this to automatically delete invoked jobs after a period of time.

There's a trick mentioned in https://github.com/kubernetes/kubernetes/issues/829#issuecomment-51796318
@agnesjang98 maybe we could document this in the page about Job / CronJob?

I'll try defining activeDeadlineSeconds and yes some documentation would be nice about the trick? I wasn't completely sure how to progress with the workaround you linked, will look over it again.

Putting ttlSecondsAfterFinished in the jobTemplate spec for specifying the Job invoked by the CronJob works! It would be helpful to add this in the documentation :)
Part of our cronjob.yaml as an example:
...
apiVersion: batch/v1beta1
kind: CronJob
metadata:
  name:
  namespace:
spec:
  concurrencyPolicy:
  startingDeadlineSeconds:
  jobTemplate:
    spec:
      ttlSecondsAfterFinished: {{ $job.ttlSecondsAfterFinished | default 120 }}
...

/retitle Mention .ttlSecondsAfterFinished in CronJob concept page

/sig apps

/remove-kind support

/remove-lifecycle stale
/help


Dictionary member variable behaves like static if not initialized

Godot version: 3.1.1
Issue description:
If I create class with Dictionary variable, and forget to initialize it, like this
class_name MyClass

var myDict:Dictionary

then this variable behaves like static variable. So when I create two instances of MyClass and in each one I will add one element to dictionary, then dictionary in both instances will have two items in it.
Minimal reproduction project:
godotBugDictStatic.zip

Duplicate of #24134.


Added python script for Random Email Generation

This script solves #317 @avinashkranjan review and let me know if any enhancement needed

@all-contributors please add @pankaj892 for code and documentation


Add validation for token address

Resolves #108

[x] warn user for sending to a known token address
[x] warn user for sending to own address

If recipient address is the same as source

If recipient address is a token

For future PR: Add a checkbox in the warning that the user has to click in order to acknowledge and proceed.  Functionally, the send button would just be disabled until the checkbox is checked.


add link to aws prepearion guide; Add note that an AMI can also be us…

…ed to get a BOSH lite

@wolfoo2931 Thanks for taking interest in making the class material better. I did have some trouble with the pull request. The link didn't work for me. It sent me to https://github.com/anynines/summit-training-classes/blob/edb325019c6c278f9202c48f70bd4935b2226303/labs/bosh-lite-on-aws . I may have been doing something wrong.
I wasn't able to locate the AMI ami-2bcdb658 in the community AMIs. Should have I been looking somewhere else?


Gas fee charging / computation issue

Repro: https://github.com/MystenLabs/sui/pull/9560
sui/crates/sui-types/src/temporary_store.rs:746:9 panic.file="sui/crates/sui-types/src/temporary_store.rs" panic.line=746 panic.column=9
<unnamed><unnamed>' panicked at '' panicked at 'assertion failed: `(left == right)`

Repro happens when the gas budget is too low.  Could we be incorrectly mishandling a case where we are not resetting the store (or not accounting for the fact that the store is reset) before the dynamic check?

@dariorussi feel free to self-assign if / when you look into this.

I expect that this has been solved by now. @rvantonder can you confirm please?


Revert "Get OS IPL mode state from PHYP"

This reverts commit 90f621ea717d5f35e8878a4d2cd0078a408d81f5.
Reason for revert: Panel app exits due to
sensor PDR fetch failure. This has happened
before the PLDM service starts. Need to handle
this case. So reverting the commit back.
Change-Id: I3423017152d54ded00b354c4794e4203f4847ae8

Not needed anymore


Improve sitemap performance and exclude restricted and undiscoverable content

References

Fixes #3182
Fixes #5394
Fixes #5343

Description
The sitemap generator logic has been reviewed to rely mostly on discovery to retrieve communities, collections and items in a paginated way. As we are now using discovery and there is no user in our context we automatically get only public visible item.
Instructions for Reviewers
Review the improved ITs they show the scenarios that were reported to be buggy. This build show that the new IT tests with the current code fail
https://github.com/4Science/DSpace/actions/runs/6783139075/job/18436770293
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[X] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[X] My PR passes Checkstyle validation based on the Code Style Guide.
[X] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[X] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[n/a ] If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[n/a ] If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
[n/a ] If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
[X] If my PR fixes an issue ticket, I've linked them together.

Thanks @abollini! This looks like an important fix (especially for large repositories), but the patch doesn't apply on DSpace 7.6 as-is, so will need to be ported manually.


OSM Controller pod is OOMKilled

While running a large installation of OSM and ramping up aggressively the number of pods in the mesh I noticed OSM Controller pod was OOMKilled.
There is of course a new pod spun up and it takes its place. In an HA environment this does not seem to be an issue, but we should investigate and understand what is causing OOMKilled
Here is how to simulate the environment:

Most likely any Kubernetes distribution will work -- I happen to use a managed AKS cluster.
Deployed OSM using the following script:

#!/bin/bash

./osm install \
    --set=OpenServiceMesh.controllerLogLevel=error \
    --set=OpenServiceMesh.osmController.autoScale.enable=true \
    --set=OpenServiceMesh.osmController.autoScale.minReplicas=3 \
    --set=OpenServiceMesh.osmController.autoScale.maxReplicas=10 \
    --set=OpenServiceMesh.osmController.autoScale.targetAverageUtilization=75 \
    --set=OpenServiceMesh.osmController.enablePodDisruptionBudget=true \
    --set=OpenServiceMesh.injector.autoScale.enable=true \
    --set=OpenServiceMesh.injector.autoScale.minReplicas=3 \
    --set=OpenServiceMesh.injector.autoScale.maxReplicas=10 \
    --set=OpenServiceMesh.injector.autoScale.targetAverageUtilization=75 \
    --set=OpenServiceMesh.injector.enablePodDisruptionBudget=true

Ensure the OSM version you run has the following patch: https://github.com/openservicemesh/osm/pull/4205 to prevent Evictions (so we get to OOMKilled)
Install the bookstore demo (with many many many pods) using the following script:

#!/bin/bash

set -aueo pipefail

MAX=100

BOOKBUYER_REPLICAS=250
BOOKSTORE_REPLICAS=250

source ./common/wait-functions.sh
source ./common/colors.sh

########################################

for ITERATION in $(seq ${MAX}); do
    BOOKBUYER_NAMESPACE="bookbuyer-many-many-${ITERATION}"
    BOOKSTORE_NAMESPACE="bookstore-many-many-${ITERATION}"

    echo -e "Cleaning up namespaces ${RED}${BOOKBUYER_NAMESPACE}, ${BOOKSTORE_NAMESPACE}${RESET}"
    kubectl delete namespace ${BOOKBUYER_NAMESPACE} ${BOOKSTORE_NAMESPACE} --wait || true

    echo -e "Creating namespaces ${GREEN}${BOOKBUYER_NAMESPACE}, ${BOOKSTORE_NAMESPACE}${RESET}"
    kubectl create namespace ${BOOKBUYER_NAMESPACE}
    kubectl create namespace ${BOOKSTORE_NAMESPACE}

    echo -e "Join namespaces to OSM ${BOOKBUYER_NAMESPACE} ${BOOKSTORE_NAMESPACE}"
    osm namespace add ${BOOKBUYER_NAMESPACE}
    osm namespace add ${BOOKSTORE_NAMESPACE}

    BBSA="bookbuyer--a${ITERATION}b${ITERATION}c"
    BSSA="bookstore--a${ITERATION}b${ITERATION}c"

    echo -e "Create ${LGREEN}Bookbuyer ServiceAccount${RESET} in namespace ${YELLOW}${BOOKBUYER_NAMESPACE}${RESET}"
    kubectl apply -f - <<EOF
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: $BBSA
  namespace: $BOOKBUYER_NAMESPACE
EOF

    echo -e "Create ${LGREEN}Bookbuyer Deployment${RESET} in namespace ${YELLOW}${BOOKBUYER_NAMESPACE}${RESET}"
    kubectl apply -f - <<EOF
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: bookbuyer
  namespace: $BOOKBUYER_NAMESPACE
spec:
  replicas: $BOOKBUYER_REPLICAS
  selector:
    matchLabels:
      app: bookbuyer
  template:
    metadata:
      labels:
        app: bookbuyer
    spec:
      containers:
      - name: bookbuyer
        image: openservicemesh/bookbuyer:v0.10.0
        imagePullPolicy: IfNotPresent
        command:
        - /bookbuyer
        env:
        - name: BOOKSTORE_NAMESPACE
          value: $BOOKSTORE_NAMESPACE
        - name: BOOKSTORE_SVC
          value: bookstore
      serviceAccount: $BBSA
      serviceAccountName: $BBSA
EOF

    echo -e "Create ${LGREEN}Bookstore ServiceAccount${RESET} in namespace ${YELLOW}${BOOKSTORE_NAMESPACE}${RESET}"
    kubectl apply -f - <<EOF
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: $BSSA
  namespace: $BOOKSTORE_NAMESPACE
EOF

    echo -e "Create ${LGREEN}Bookstore Service${RESET} in namespace ${YELLOW}${BOOKSTORE_NAMESPACE}${RESET}"
    kubectl apply -f - <<EOF
---
apiVersion: v1
kind: Service
metadata:
  name: bookstore
  namespace: $BOOKSTORE_NAMESPACE
spec:
  selector:
    app: bookstore
  ports:
  - port: 14001
    name: bookstore-port
EOF

    echo -e "Create ${LGREEN}Bookstore Deployment${RESET} in namespace ${YELLOW}${BOOKSTORE_NAMESPACE}${RESET}"
    kubectl apply -f - <<EOF
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: bookstore
  namespace: $BOOKSTORE_NAMESPACE
spec:
  replicas: $BOOKSTORE_REPLICAS
  selector:
    matchLabels:
      app: bookstore
  template:
    metadata:
      labels:
        app: bookstore
    spec:
      containers:
      - args:
        - --path
        - ./
        - --port
        - "14001"
        command:
        - /bookstore
        env:
        - name: IDENTITY
          value: ${BOOKSTORE_NAMESPACE}/bookstore
        image: openservicemesh/bookstore:v0.10.0
        imagePullPolicy: IfNotPresent
        name: bookstore
        ports:
        - containerPort: 14001
          name: web
          protocol: TCP

      serviceAccount: $BSSA
      serviceAccountName: $BSSA
EOF

    echo -e "Create ${LGREEN}HTTPRouteGroup${RESET} in namespace ${YELLOW}${BOOKSTORE_NAMESPACE}${RESET}"
    kubectl apply -f - <<EOF
---
apiVersion: specs.smi-spec.io/v1alpha4
kind: HTTPRouteGroup
metadata:
  name: bookstore-service-routes
  namespace: $BOOKSTORE_NAMESPACE
spec:
  matches:
  - name: books-bought
    pathRegex: /books-bought
    methods:
    - GET
    headers:
    - "user-agent": ".*-http-client/*.*"
    - "client-app": "bookbuyer"
  - name: buy-a-book
    pathRegex: ".*a-book.*new"
    methods:
    - GET
  - name: update-books-bought
    pathRegex: /update-books-bought
    methods:
    - POST
EOF

    echo -e "Create ${LGREEN}TrafficTarget${RESET} in namespace ${YELLOW}${BOOKSTORE_NAMESPACE}${RESET}"
    kubectl apply -f - <<EOF
---
apiVersion: access.smi-spec.io/v1alpha3
kind: TrafficTarget
metadata:
  name: bookbuyer-access-bookstore
  namespace: $BOOKSTORE_NAMESPACE
spec:
  destination:
    kind: ServiceAccount
    name: $BSSA
    namespace: $BOOKSTORE_NAMESPACE
  rules:
  - kind: HTTPRouteGroup
    name: bookstore-service-routes
    matches:
    - buy-a-book
    - books-bought
  sources:
  - kind: ServiceAccount
    name: $BBSA
    namespace: $BOOKBUYER_NAMESPACE
EOF

done

echo -e "Created TrafficSplit"

# source ./common/get-logs.sh

Watch carefully the OSM pods: watch -n0.5 "kubectl get pods -n osm-system" -- you'll notice that once in a while one of the OSM Controller pods is OOMKilled

The questions we need to answer:

Is there a specific area of the controller that is using unnecessarily large amount of memory?
Is there a memory leak?
If the large memory consumption is ok - is there an adjustment to the pod spec we can do to accommodate for higher pod resource limits or OOM limits adjusments?

I opened #4234 which addresses the high-churn scenario I described above, but I'm not confident that improves the issue @draychev saw with just creating lots of Pods and never deleting any. I'll take a look at that more next week, but it seems to me like adding proxies will inherently require each osm-controller replica to use more memory. So there may not be something like a leak, maybe we just need to increase the memory requests/limits for large meshes like that.

I sort of agree, it looks a lot of memory for what it does, but similarly however, and In comparison (disclaimer, it's sooo very likely apples-to-oranges) istiod uses 1.5Gb for 1000 services and 2000 proxies. At the time I think we used that as an argument to not chase this down as an issue. ducks

350-400 pods

That's with the default 512M memory limit we set right? That's still ballparky with the number I remember, if not a bit lower. I used to see it get OOMkilled solidly around  500. I used to also monitor startup memory as well (so plain OSM with nothing on the mesh), but it got better with the injector split.
For most of late testing, I was running was with 1GB, which then OSM did start running into other issues (CPU-starved mostly) most of the time around ~1000-1100 pods before even getting to OOM.
One last thing, does the above memory profile with the 400 pods ? Just because the overall heap memory is at 218MB as opposed to the 512MB (am I reading this right?). It could potentially mean we have a lot of stack memory on go-routines even though these are supposed to be thin (and I double checked, go-routine stack memory is not counted on inuse_space).


Added emulation for accesses with effective privelege mode = S

Draft PR:
For now in order for this to work on VisionFive2 board a modified version of linux is required.
It also breaks sandbox test CI.

Before making additional changes, on this branch, i wanted to check a couple of things with @CharlyCst.

How should we go about validating the virtual addresses? From my perspective, there are three edge cases that we need to think about: access to a general memory (which is permitted), access to a Miralis-PMP-protected memory region (which is denied), and access to device-PMP-memory (which is not clear if it's valid via a virt address).
Empirically, it seems like there weren't any traps encountered on the board during execution of handle_virtual_load_store().
https://github.com/CharlyCst/miralis/blob/36abbd7cf324f757034d70f1aa75db5bece0de17/src/arch/metal.rs#L532 However, should there be support for such a possibility in the code?
I was just wondering if we should keep the case for ecall from OS with fid=20 (that's a random number for MIP patching) in the codebase or if we should look at the underlying issue in Linux to see if we can get rid of the need for ecall?
https://github.com/CharlyCst/miralis/blob/36abbd7cf324f757034d70f1aa75db5bece0de17/src/virt.rs#L622-L638

To give a quick answer (we can discuss more in details next week or by following up here):

My understanding is that when MPRV=1 then the PMP take effect as if S or U mode was executing. We should double check what the spec says around that, but it seems to contradict what you observed? If PMP are taken into account we only need to worry about (3), and we already have a function to check if we touch a device (for now we can panic if that's the case, I don't think we will need it for Linux).
Yes, we should handle that case and inject back an exception. OpenSBI handles it too by injecting the error into Linux.
In the end we will need to run unmodified Linux, so we don't want to keep the hack around. We will need to investigate into this issue…

Changes to the draft state:

Removed the interrupts patch from this branch
Fixed sandbox issue (PMP with idx=0 is disabled now instead of allowing RWX, due to check priority it was allowing all the accesses)
Overall refactored the code a bit

Tested with Linux payload on Spike - works fine. The PR is not yet ready to be merged to my mind, but i would like to get some feedback now.

If PMP are taken into account we only need to worry about (3), and we already have a function to check if we touch a device (for now we can panic if that's the case, I don't think we will need it for Linux).

Yes, we check if the mtval corresponds to any memory-mapped physical address, i was asking more about if access like this could ever be a case:

                                        ┌───────┐
                                       ┌───────┐│
                                       │  PT   ││
                        vMPRV=1        │       ││
                 ┌────────────────────►│       │├────────────────────────┐
                 │                     │       ││                        │
                 │                     │       │┘                        │
                 │                     └───────┘                         │
   ┌─────────────┴───────────┐                             ┌─────────────▼───────────┐
   │                         │                             │                         │
   │  ld a0, 0(0xFF...F8..)  │                             │  ld a0, 0(0x2000_0000)  │
   │                         │                             │                         │
   └─────────────────────────┘                             └─────────────────────────┘

If such an access could happen, i won't be caught by
https://github.com/CharlyCst/miralis/blob/9d842700c3b9ec0f637eb2110ebb6f183f79b631/src/virt.rs#L499
and subsequently will go through direct emulation instead of a device access interface.
I guess this question falls into the same basket as protecting Miralis's memory from access with MPRV=1 (which means we should somehow validate the virtual address).

Yes I think this should be caught by PMPs too... We could potentially write a test to ensure this is the case (see if the PMPs indeed prevents from reading Miralis memory or devices using MPRV).
Thanks for the PR! I'll review it when I get some time, most likely this Friday.
As this is a non-trivial feature, would you mind writing a description of how the emulation works? You can add that as a new section to the doc in ./docs/architecture.md.

Addressed most of the issues, what's left:

Figuring out if handle_virtual_load_store requires any assumptions to be safe.
Deciding if virtual address should be validated (even if PMP denies access properly, we still would probably like to handle access to a device with a virtual address somehow).

Ping me when you would like me to take another look :)
There is a "re-request review" button at the top right in the "Reviewers" section adds a "to-review" item in my notification list :)

Regarding the virtual address validation, my intuiting and understanding is that the PMP should catch if the access is invalid

That should indeed be the case for addresses that we're purely protecting (like Miralis's memory), but if we're using PMP as a mean of catching access attempt (like with devices), an access fault would be returned to firmware instead of a correct access emulation chain. That might be an undesired behavior.


glyphicons-halflings-regular.woff2 missing

admin.css references to glyphicons-halflings-regular.woff2 but the file is missing from the repository.

The reason for this is we are currently ignoring the /build folder in the [.gitgnore] (https://github.com/swiss/styleguide/blob/master/.gitignore#L8) file, so if we forget to $ git add -f those files, we don't commit everything.
This should be changed, as we need to commit the built files when releasing a new version and this should be an easy process.

https://jira.liip.ch/browse/SWG-103

@LeBenLeBen will this be corrected with 3.0?

All the required files have been committed but the rule to ignore this folder is still present. We can change it easily for the release.

That would be great, thanks!

This has been fixed in release 3.0.0


2.13 upgrade

Set new min imjs version to 2.13 and react to breaking changes
TODO: proper support for BriefcaseConnection in Electron apps

Abandoning this PR, since we have bumped the core ver in the new viewer


AppReceiptField preorder_date

As you can see in this documentation https://developer.apple.com/documentation/appstorereceipts/responsebody/receipt
A receipt can have preorder_date fields in case of a preorder
For now I'm using the verifyReceipt API call to get the information if the user has preordered my app
When comparing the response with your dev mode, I found that the field 32 contains the preorder_date
with your library

VS
with verifyReceipt API call

Hi!
Thanks a lot for this report, it's very valueable!
I've just released the new version with this change.


AppInbox resolution issue on tablet device

Hello,
I'm trying to setup the App Inbox in a react native project and everything went smooth until I tested it on tablet.
Case flow:

Open App Inbox
Click on Push Notification
When I open a Push Notification from the App Inbox the resolution of the image in the modal is huge. I've tried adding a much smaller image (16x16) and it's still spreading it. I've been looking for some properties from which I can control the size of the image but couldn't find any. Please advise if there is a way to fix that.
Attached is a screenshot of the issue.

Hi @ivayloivan0v thank you for reporting. This image is handled 'natively' by UIImageView with contentMode = .scaleAspectFill (is: contents scaled to fill with fixed aspect. some portion of content may be clipped.)
We check it in iOS, how it could be done more dynamic.
Meanwhile you have some options here:

Provide image that will fit fill behaviour. Maybe your image (Thund... Thursd...) has ultra-wide proportions, ImageView scales image to fit its height but it results into large width.
Try to register own AppInboxProvider (needs to be in swift) https://github.com/exponea/exponea-ios-sdk/blob/develop/Documentation/APP_INBOX.md#ui-components-styling and modify that view by getAppInboxDetailViewController
use HTML app inbox message

Hi @ivayloivan0v - fixed in new SDK v1.6.0


Verify contact details

When a citizen submits a service request, sometimes she would like to be notified of the status of the request (let's say specifically, when it is resolved, but in general a notification could be sent based on a number of events in a service request lifecycle).
To support this, we can verify the citizen's contact channel (email or phone for sms) is valid. We can do this via Twilio/SendGrid ( see #5 ).
We can do this for:

Logged in citizens
Citizens not logged in, but who also have not opted in to an anonymous request

Moving this to a discussion here https://github.com/govflow/govflow/discussions/33 until we get to a design and prioritize an implementation


Add a requirement for pytest-cov

Describe the bug
By default, pytest will not recognise the --cov-report and --cov options. These options require the pytest-cov package to be installed.
To Reproduce

git clone
pip install -r requirements-dev.txt
poetry install
make test

Thanks. Fixed in master.


some bugs need to fix

There are some bugs in the script.
such as in Class Data_Loader, with open(os.path.join(path,"train.pickle"),"r") as f: would raise an error. As the pickle file was save in byte mode, but in this line, it was opened in str mode. So the 'r' should be replaced by 'rb'.
In other parts, there are some other bugs. Please fix it if you have time. 3Q.
P.S. I don't yet know how to pull a request, sorry for that.

Sorry for the late reply. I've rerun the code but cannot reproduce the error you mentioned. I think it is due to the python version. In python 2.7, it should be fine. But I have to admit that it is better to use "rb" when reading the pickle file as you pointed out.
Please let me know any other issues you found. Thank you again for your time.


Fix pages not loading on admin site

Searching for pages works but loading pages loads forever.
All pages are accessible however

Did you remove the pages that were linked to non-existant user ids?

Pages aren't linked to user ids at all. Regardless all pages are accessible and editable, you just need to search for them. The problem is on https://society.ecs.soton.ac.uk/admin/collections/pages?limit=10

Looks like the api doesn't even give you any info
https://society.ecs.soton.ac.uk/api/pages/
compare to
https://society.ecs.soton.ac.uk/api/sponsors/

Same problem with posts. Wiping the collections (including their versions tables) might solve the issue

Yeah noticed the api isn't hydrating the page but not sure as to why. Not a major issue


TRSv2-517: DAC table accessibility - mobile sort

Codecov Report
Patch and project coverage have no change.

Comparison is base (d510686) 41.66% compared to head (042d76c) 41.66%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #316   +/-   ##
========================================
  Coverage    41.66%   41.66%
========================================
  Files           95       95
  Lines         5643     5643
  Branches       671      671
========================================
  Hits          2351     2351
  Misses        3292     3292

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add Option to hide or show Input

I want to place a input in search bar and listview in scaffold
but there is no option to split or atlease show/hide input from appBar on click

@92sajid110 can you provide more details ?
you want to hide search textfield ?


force alignment

What is the best way to do a force alignment/decoding in Eesen?
I want to generate the alignment of the reference, given the softmaxed output
Best

I just checked in new updates to do so. The high-level script is align_ctc_single_utt.sh
Note that currently we can only generate alignments utterance by utterance, rather than in a batch mode (as in Kaldi)

thank you very much!
My understanding is that this scripts can generate a lattice with a "weak language model".. then get the best path out of the lattice.
I presume that because it uses a "weak language model", it is very likely that the correct path (reference ) is included in the lattice. Therefore, for mpe training, this correct path in the lattice can be used as the nominator. right?
Best

Thank you very much!
I presume that the uttdata-dir stores only one utterance's reference, therefore the G.fst generated out of this reference will be used to generate only a very compact lattice, and the the 1best path found in that lattice is actually the reference!!
this is very cool!
Best

Yep, your understanding is correct.


Kubernetes Issue Tracker

Check this screenshot.
Tried with different browsers and different devices still all CSS are removed and not able to visit dashboard.

/retitle Kubernetes dashboard UI elements not loading
@samir321-pixel Might be worth looking in the logs for some clues. Also, this looks like a question you could post on the Kubernetes Slack or the Discuss Kubernetes forum to get better answers.

/transfer dashboard


Convert deep-head-pose-lite from pytorch to caffe fail

conv1.0
conv:  blob1
conv1 was added to layers
545911448128:conv_blob1 was added to blobs
add1 was added to layers
545911448416:add_blob1 was added to blobs
WARNING: CANNOT FOUND blob 8775320
8775320:extra_blob1 was added to blobs
conv1.1
batch_norm1 was added to layers
545911448272:batch_norm_blob1 was added to blobs
bn_scale1 was added to layers
conv1.2
relu1 was added to layers
545913981760:relu_blob1 was added to blobs
maxpool
max_pool1 was added to layers
545911447624:max_pool_blob1 was added to blobs
WARNING: the output shape miss match at max_pool1: input torch.Size([1, 24, 112, 112]) output---Pytorch:torch.Size([1, 24, 56, 56])---Caffe:torch.Size([1, 24, 57, 57])
This is caused by the different implementation that ceil mode in caffe and the floor mode in pytorch.
You can add the clip layer in caffe prototxt manually if shape mismatch error is caused in caffe.
stage2.0.branch1.0
conv:  max_pool_blob1
conv2 was added to layers
545911447768:conv_blob2 was added to blobs
add2 was added to layers
545911418744:add_blob2 was added to blobs
WARNING: CANNOT FOUND blob<PHONE_NUMBER>24
Traceback (most recent call last):
File "hopenet_to_caffe.py", line 15, in
pytorch_to_caffe.trans_net(net,input,name)
File "./pytorch_to_caffe.py", line 786, in trans_net
out = net.forward(input_var)
File "./stable_hopenetlite.py", line 127, in forward
x = self.stage2(x)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 722, in _call_impl
result = self.forward(*input, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/container.py", line 117, in forward
input = module(input)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 722, in _call_impl
result = self.forward(*input, **kwargs)
File "./stable_hopenetlite.py", line 76, in forward
out = torch.cat((self.branch1(x), self.branch2(x)), dim=1)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 722, in _call_impl
result = self.forward(*input, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/container.py", line 117, in forward
input = module(input)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 722, in _call_impl
result = self.forward(*input, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/batchnorm.py", line 113, in forward
self.num_batches_tracked = self.num_batches_tracked + 1
File "./pytorch_to_caffe.py", line 532, in _add
bottom=[log.blobs(input),log.blobs(args[0])], top=top_blobs)
File "./Caffe/layer_param.py", line 33, in init
self.bottom.extend(bottom)
TypeError: None has type NoneType, but expected one of: bytes, unicode

@yueyihua have you solved your problem ? how did you solve it ?


Custom class is not working.

I am trying to use a customClass for the buttons like this:
this.$dialog
        .confirm('Are you sure you want to delete the selected users.', {
          okText: 'Delete',
          cancelText: 'Cancel',
          customClass: {
            cancel: 'btn btn-light btn-sm'
          }
        })
        .then(function(dialog) {
          this.deleteSelectedUsers()
        })

However I do not see the classes mentioned above applied to the cancel button. I am using bootstrap and these classes are part of it. I can manually change the class of cancel button through inspector and see the desired result , but the above code is not resulting in the above classes applied.

I am trying to use a customClass for the buttons like this:
this.$dialog
        .confirm('Are you sure you want to delete the selected users.', {
          okText: 'Delete',
          cancelText: 'Cancel',
          customClass: {
            cancel: 'btn btn-light btn-sm'
          }
        })
        .then(function(dialog) {
          this.deleteSelectedUsers()
        })

However I do not see the classes mentioned above applied to the cancel button. I am using bootstrap and these classes are part of it. I can manually change the class of cancel button through inspector and see the desired result , but the above code is not resulting in the above classes applied.

@rachitpant , I am also having same issue & it is not working,

Saw the code base, Custom Class variables are defined in constant but never used in the dialog window.
Reference to Code Merge https://github.com/Godofbrowser/vuejs-dialog/pull/26/files

@hjortzen  - any idea?


[FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

Signed-off-by: Andriy Redko<EMAIL_ADDRESS>
What is the purpose of the change
The goal of this change is to provide dedicated Opensearch connectors [1], [2], [3], [4].
Brief change log
The implementation is largely based on the existing Elasticsearch 7 connector with a few notable changes (besides the dependencies and APIs):

any mentions and uses of mapping types have been removed: it is deprecated feature, scheduled for removal (the indices with mapping types cannot be created or migrated to Opensearch 1.x and beyond)
any mentions and uses have been removed: it is deprecated feature, scheduled for removal (only HighLevelRestClient is used)
the default distributions of Opensearch come with HTTPS turned on, using self-signed certificates: to simplify the integration a new option allow-insecure has been added to suppress certificates validation for development and testing purposes
old streaming APIs are also supported to facilitate the migration of existing applications from Elasticsearch 7/6 to Opensearch (the classes will change but the familiar model will stay)

The new connector name is opensearch and it follows the existing conventions:
CREATE TABLE users ( ... ) WITH (
  'connector' = 'opensearch',
  'hosts' = 'https://localhost:9200',
  'index' = 'users',
  'allow-insecure' = 'true',
  'username' = 'admin',
  'password' = 'admin');

Verifying this change
This change added comprehensive tests and can be verified as follows (largely ported the existing unit and integration tests for Elasticsearch 7):

Added unit tests
Added integration tests for end-to-end
Added end-to-end tests
Manually verified the connector by running a node clusters

Does this pull request potentially affect one of the following parts:

Dependencies: yes (the latest Opensearch 1.2.4 APIs as of this moment)
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? (docs - in progress, JavaDocs)

Huge thanks @snuyanzin for help.
Retargeting https://github.com/apache/flink/pull/18541 to separate repository
[1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-243%3A+Dedicated+Opensearch+connectors
[2]<EMAIL_ADDRESS>[3] https://lists.apache.org/thread/jls0vqc7jb84jp14j4jok1pqfgo2cl30
[4] https://lists.apache.org/thread/4bms24983g38q956rp8qmm4bpdo4361s

@MartijnVisser could you please take a look? thank you :-)

@MartijnVisser doing my deligance by pinging once per month :-)

@MartijnVisser the POMs and CI scripts have been updated accordingly

Can you split the commit such that 1 adds the workflows and another the rest? We can then merge the workflow commit first and actually get CI in this PR.

Sure, https://github.com/apache/flink-connector-opensearch/pull/2, thanks @zentol

@zentol thnaks a lot for the review, I think I addressed all your comments, please let me know if I missed some, thanks!

@reta There are some unresolved comments, like #1 (comment), #1 (comment), #1 (comment).

Thanks @zentol , addressed or/and answered

@zentol thanks on more time for the review, I think none of your comments left unattended, thanks

It would be amazing if this could be based on the opensearch-java client rather than RHLC, since that is where all of the improvements are going. Is that how this is set up?

It would be amazing if this could be based on the opensearch-java client rather than RHLC, since that is where all of the improvements are going. Is that how this is set up?

Not for now, see please https://github.com/opensearch-project/opensearch-java/issues/181 (this is what the connector uses).

Just noticed that we're lacking documentation; like https://github.com/apache/flink-connector-elasticsearch/blob/main/docs/content/docs/connectors/datastream/elasticsearch.md.

Thanks @zentol, I have it ready and thought to open separate pull request (to split MDs from code), makes sense to you?

ok

hi @zentol @reta
I see that flink-opensearch-connector was merged to master recently but I don't see it was registered in maven repository.
When will this be added to maven repository so I can use this from pom.xml? I also don't see opensearch connector in official flink documentation. Can this library be used in Java 8 also?

hi @zentol @reta I see that flink-opensearch-connector was merged to master recently but I don't see it was registered in maven repository. When will this be added to maven repository so I can use this from pom.xml?

Hey @ypark2103 , the vote was ongoing and just approved [1], expect artifacts to be available in the coming days.
[1] https://lists.apache.org/list?dev@flink.apache.org:lte=1M:Opensearch

I also don't see opensearch connector in official flink documentation.

The Opensearch documentations available here [2] but I am not sure how it is going to be integrated into Flink documentation, @zentol may be you could spot some light?
[2] https://github.com/apache/flink-connector-opensearch/tree/main/docs

Can this library be used in Java 8 also?

Yes

@reta Is there a way we can install this library with pom.xml?
I don't see opensearch in maven depository yet like elasticsearch connector.
https://mvnrepository.com/artifact/org.apache.flink/flink-connector-elasticsearch7

The artifacts you mentioned that will be available in the coming days is referring to registering this library to maven repo?

@ypark2103 Correct

The Opensearch documentations available here [2] but I am not sure how it is going to be integrated into Flink documentation, @zentol may be you could spot some light?

They will be integrated via https://github.com/apache/flink/pull/21518 when the final steps for the release process have been completed :)

@reta @MartijnVisser Is this Flink-Connector-Opensearch only available for flink 1.16 version? What about flink 1.11 or 1.12?

@ypark2103 that is correct, the Flink Opensearch Connector was following the Flink's externalization model for connectors, the necessary scaffolding is only available in Flink 1.16 and above.

@reta I heard java 8 was deprecated starting Flink 1.15. Does it mean I need to upgrade to java 11 to use this connector? Or can I still use java 8 for Flink 1.16?

@reta I heard java 8 was deprecated starting Flink 1.15. Does it mean I need to upgrade to java 11 to use this connector? Or can I still use java 8 for Flink 1.16?

@ypark2103 the connector itself has baseline of JDK-8 so you don't need JDK-11 to use it as-is (using 1.3.x OpenSearch client), but if you plan to upgrade to JDK-11, it is even better.


Feature dockerized devnet

An effort to create an easy to run local subtensor for the purpose of testing subnet changes locally.

Closing this PR. Not sure Docker is the best approach here. It takes a while to build and run the subtensor. I think a better approach to this would be to have a subtensor running on a VPS, we could then add tests for subnet changes to use this subtensor.


How to config?

How to config it for Amnesia?

I think it is necessary to add to the description that the following parameters should be added in the configuration file in the [Interface] section:
#junkPacketCount
Jc = 8

#junkPacketMinSize
Jmin = 10

#junkPacketMaxSize
Jmax = 16

#initPacketJunkSize
S1 = 16

#responsePacketJunkSize
S2 = 8

#initPacketMagicHeader
H1 = 1

#responsePacketMagicHeader
H2 = 2

#underloadPacketMagicHeader
H3 = 3

#transportPacketMagicHeader
H4 = 4

Please provide an explanation of what values should be assigned to these parameters.

@GalayZloy Amnezia client supports exporting configurations for AmneziaWG in its native .conf format, which is WireGuard-compatible.
However, please note that it's essential to retrieve the parameters from your specific server, as configurations won't work with different servers. You only can try to tune Jc, Jmax, Jmin params.
To use it with wireproxy, export the configuration to a file (e.g., amnezia_for_awg.conf) and reference its path in the wireproxy config under the WGConfig key.


Tracking lost happens a lot

Hi all,
I built zed-examples -> position tracking project without changing anything. The pose tracking lost quite often. I remember when I use ZED world app to experience MR, the virtual objects were very steady. Can anyone tell me why? Thanks!

More information: I was using ZED-Mini, tracking lost usually happened several minutes after started tracking. It's very hard to recover even if I truned on set_floor_as_origin.


Is it possible to force thumbnails to use img tag?

Type of issue

[ ] Bug report
[ ] Feature request
[x] Support request

Uploader type

[ ] Traditional
[x] S3
[ ] Azure

Is it possible to force thumbnails to use img tag?
Fine Uploader version
5.14.5
Question
I would like to force thumbnails to use the img tag for all browsers. Is this possible?
Our thumbnail images are already resized on the server and the canvas thumbnail system seems to break with some SVG images. A simple img tag would work better for our use case.
If this is not a configuration, could you point me at the code that decides what approach to use for thumbnails, so I can enhance it?

OK, I've just found the qq-server-scale="false" option for the q-thumbnail-selector img tag in the template.
I think that covers my needs.
Thanks for an amazing library!!!!!


Add infinite scroll

@pratibhamansinghka please raise it again. Use cart as your base branch. Make sure there are no merge conflicts.


Release 1.14.0

1.14.0 (2023-11-06)
Features

add dynamic translation into share component (e01e5dd)

:tada: This PR is included in version 1.15.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Backport] Fix errors in docstrings (2)

Backport of #3114
In the previous backport #3162, I discarded the change to function_hook.py, but I should have redirected the change to function.py instead.

jenkins, test this please

LGTM except comment.

Oh, it's from the original PR (#3114) where I didin't notice that.
How about merging this tentatively, and making a fix in another PR?
We need to fix master too, anyway.

OK, I merge this PR. Cloud you create another PR?

Done. #3320


Add Radarr parser, scenario and collection

Adds Radarr parser, scenario and collection.

Thank you for opening this pull request! I will need to find some time to test it, but I will make some first observations on this.


SilentCryptoMiners Rep

Hi Unam what happened to SilentCryptoMiners rep on your github page?
i was just trying to check if you have release new update and features and i realized they have disabled the rep.
where can i get your latest update and info about the project?

Hey, GitHub disabled the repository, I have sent in an appeal but they have still not responded. In the meantime I posted the source code and pre-compiled binaries in an issue here: https://github.com/UnamSanctam/UnamWebPanel/issues/361#issuecomment-2208790180. The repository was at version 3.4.0, but the post in the issue also has an alternative 3.4.1 version with some minor updates (don't want to release any major updates until the repository is back, since it would be hard to keep track of any problems).

Hey, GitHub disabled the repository, I have sent in an appeal but they have still not responded. In the meantime I posted the source code and pre-compiled binaries in an issue here: #361 (comment). The repository was at version 3.4.0, but the post in the issue also has an alternative 3.4.1 version with some minor updates (don't want to release any major updates until the repository is back, since it would be hard to keep track of any problems).

It seems to me that GitHub is unlikely to unban your repository. Maybe it's time to create a new one?


Refactor openshift controller manager and cluster policy controller

Removes the use of templates and adds reconciliation code for both
controllers.

/test e2e-aws

/lgtm
/hold
Just waiting for e2e

/hold cancel


[SAGE-518] Modal - remove ability to scroll background when modal is open

Description

[x] remove ability to scroll background when modal is open

Screenshots

Before
After

Testing in sage-lib

Visit the Modal page and verify that .sage-page--has-open-modal is present in the <body> when a modal is open to prevent background scrolling.

Rails
React

Testing in kajabi-products

(HIGH) Modal - adds class to <body> when modal a modal is open.

[ ] Creation Wizard

Related

Closes SAGE-518

I'm seeing the sage-page--has-open-modal class in storybook on page load

I'll look into this


[Docs] Suggest the right place for users to be from Test Runners page

Clear and concise description of the problem
This page says "you probably don't want to be here" but it doesn't say where users DO want to probably be, which can be frustrating if users are trying and failing to figure out how to run vitest tests.
Suggested solution
Write a message like, "You may be looking for one of the following 1-3 pages" with a list.
Alternative
At least link to the community Discord or start of docs so users aren't totally at a loss.
Additional context
(sorry, normally I like to contribute docs PRs myself but in this case I don't know where to go to find the info myself)
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Well the thing is, I'm still not really sure. The help that I got from the discord that let me get started was:
I needed to add this to my package.json:
{
  "scripts": {
    "test": "vitest"
  }
}

And that's what I was looking for on google when I ended up on that Advanced Info page.
Also, another suggestion would be:
On this page add a similar note at the top. "If you are using standalone source files for your tests, these examples are still usable; however you should instead use import { test } from 'vitest' at the top of your file rather than the inline imports.
The reason for this suggestion is, these were the only examples I found of vitest doing things like what I want to be doing (running unit tests on the values of individual functions, not doing component tests or etc) and so I copied what that page was doing. But, I still want my tests in a standalone file. I didn't realize I could get the best of both worlds until the person in Discord pointed out to me what I was doing wrong.


Spelling Correction

Category

[ x] Content fix

What's in this Pull Request?
Spelling correction
Updated word "fo" to "of"

thx @rdorrani, appreciated.


Updated Tutorials and Getting Started

Created a first pass at an initial getting-started guide and updated the tutorial-0 to use a working example.py file.

Thanks! Great contribution!


[video_player] set AudioSessionCategory to PlayAndRecord

Description
iOS doesn't record audio when used intermittently with video_player, because the AVAudioSession.sharedInstance.category is set to AVAudioSessionCategoryPlayback. It  need to be AVAudioSessionCategoryPlayAndRecord.
AVAudioSessionCategoryPlayAndRecord
Extra, I added support for Airplay and Bluetooth
Related Issues
issues 70851
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[ ] I signed the CLA.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@googlebot I signed it!

@googlebot I signed it!

@googlebot I fixed it.

@googlebot I fixed it.

I would prefer if Extra, I added support for Airplay and Bluetooth was added to a separate PR. Do you mind updating this PR to remove those specific changes?

I would prefer if Extra, I added support for Airplay and Bluetooth was added to a separate PR. Do you mind updating this PR to remove those specific changes?

I would prefer if Extra, I added support for Airplay and Bluetooth was added to a separate PR. Do you mind updating this PR to remove those specific changes? Unless there's a specific reason they're needed to address the interrupts the audio recording when playing a video with video_player issue?

YES, I do it.

I would prefer if Extra, I added support for Airplay and Bluetooth was added to a separate PR. Do you mind updating this PR to remove those specific changes? Unless there's a specific reason they're needed to address the interrupts the audio recording when playing a video with video_player issue?

YES, I do it.

I would prefer if Extra, I added support for Airplay and Bluetooth was added to a separate PR. Do you mind updating this PR to remove those specific changes? Unless there's a specific reason they're needed to address the interrupts the audio recording when playing a video with video_player issue?

YES, I do it.

Is there a quick fix in the current version of the audio player to prevent it from stopping other audio when autoplaying video?

Thanks for the submission! We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.
As explained in the contributing guide, all behavioral changes need tests. Please let us know when you’ve updated the PR with tests and we can take a look.


Vendor/third-party risk assessments

Expand the search for vendor/third-party risk assessments.

https://www.onetrust.com/blog/third-party-ai-risk-a-holistic-approach-to-vendor-assessment/ (don't add to repo; marked out as example)


@expenses Add a preserve_bindings opt to the builder and codegen opts

This resolves https://github.com/EmbarkStudios/rust-gpu/issues/827 and makes reflection a lot easier. I think having it set to true unconditionally is the right move but two alternatives are:

Setting it to cg_args.spirv_metadata != SpirvMetadata::None. This is pretty unclear behaviour but it does keep things the same in the default case.
Adding a new CodegenArgs::opt_preserve_bindings argument. Adds more complexity and is easily missed. Doesn't really 'just work'.

I think the best option here is the second alternative: adding a new option to spirv-builder. Removing unused bindings is the default of other shader compilers, as well as a lot of tooling, and is usually the desired behavior AFAIK. Adding an option for alternate use cases seems like the way to go.

@khyperia done.

@khyperia done.


Trying to get in touch with you regarding a security issue

Hi there,
I couldn't find a SECURITY.md in your repository and so am not sure how to best contact you privately to disclose the security issue.
Can you add a SECURITY.md file with your e-mail to your repository, so that I know who to contact? GitHub suggests that a security policy is the best way to make sure security issues are responsibly disclosed.
Once you've done that, please let me know so I can ping you the info.
Thanks! (cc @JamieSlome)

Done https://github.com/picocms/Pico/commit/d0f32c0a2b0ac841b0956d599ab7303c81e5fbc4
You can reach me via<EMAIL_ADDRESS>

Moved to #591


Create an explaination on MetricCalculator

It may be hard to understand how MetricCalculator works at first. Add some examples how to use it, not just in an overall tutorial

I'll do that in simple words in TransferLearning tutorial


Crashing at opening multiple dropdown menus

using Antergos Arch Linux Based distro,appleseed beta 1.2.0 every time i open appleseed.studio and try to open a new project appleseed crash, also if i want to open the about window, it does crash

Does the command line version of appleseed work? Try
./appleseed.cli builtin:cornell_box -o render.png

to render the Cornell Box and provude a render.png file.
Could you run appleseed.studio under gdb to figure out the error? Try
gdb appleseed.studio

Then type run. When appleseed.studio crashes, type bt in gdb to print the backtrace. Could you then send us this output?

yes the command line version works fine, for the gbd command not sure how to run it,
i tried ./appleseed.studio gbd and appleseed it does run but it crash just in the moment it runs , also i found that if a tried to open "Tests" , "Benchmarks" ,"Render Settings" appleseed also crash

If you have gdb (GNU Debugger) installed, typing exactly this:
gdb appleseed.studio

in a terminal inside the bin/ directory of your appleseed installation will start gdb and load appleseed.studio in it. Typing run inside gdb will then start appleseed.studio.
If you don't have gdb installed, maybe installing it is an option?
Could you try older versions of appleseed maybe?
Are you able to run other Qt programs?
In any case it sounds like some kind of Qt problem. Could you be more specific about what works, and what crashes?

yes i think indeed its a Qt problem, kind of strange cause i use and run other Qt programs
i got this as a result of gdb

Starting program: /home/alejandro/appleseed/bin/appleseed.studio
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: cHRM chunk does not match sRGB
Cannot mix incompatible Qt library (version 0x40807) with this library (version 0x40806)
Program received signal SIGABRT, Aborted.
0x00007ffff010c528 in raise () from /usr/lib/libc.so.6
(gdb) bt
#0  0x00007ffff010c528 in raise () from /usr/lib/libc.so.6
#1  0x00007ffff010d93a in abort () from /usr/lib/libc.so.6
#2  0x00007ffff397bd64 in qt_message_output(QtMsgType, char const*) ()
from /home/alejandro/appleseed/bin/../lib/libQtCore.so.4
#3  0x00007ffff397bf09 in qt_message(QtMsgType, char const*, __va_list_tag*) () from /home/alejandro/appleseed/bin/../lib/libQtCore.so.4
#4  0x00007ffff397c811 in qFatal(char const*, ...) ()
from /home/alejandro/appleseed/bin/../lib/libQtCore.so.4
#5  0x00007ffff3aa870c in QObjectPrivate::QObjectPrivate(int) ()
from /home/alejandro/appleseed/bin/../lib/libQtCore.so.4
#6  0x00007fffdf57f11d in QSvgRenderer::QSvgRenderer(QString const&, QObject*) () from /usr/lib/libQtSvg.so.4
#7  0x00007fffdb4cd792 in ?? ()
from /usr/lib/qt4/plugins/iconengines/libqsvgicon.so
#8  0x00007fffdb4cb420 in ?? ()
from /usr/lib/qt4/plugins/iconengines/libqsvgicon.so
#9  0x00007ffff4067410 in QIcon::addFile(QString const&, QSize const&, QIcon::Mode, QIcon::State) ()
from /home/alejandro/appleseed/bin/../lib/libQtGui.so.4

Can you do a quick test?
In a terminal, try this:
export LD_LIBRARY_PATH=/home/alejandro/appleseed/lib
/home/alejandro/appleseed/bin/appleseed.studio

yes....okay i ran those command's, it makes applessed run as normal, still getting the crashing problem's

export LD_LIBRARY_PATH=/home/alejandro/appleseed/lib
export LD_LIBRARY_PATH=/home/alejandro/appleseed/bin/appleseed.studio
/home/alejandro/appleseed/bin/appleseed.studio

That makes no sense; type exactly this:
export LD_LIBRARY_PATH=/home/alejandro/appleseed/lib
/home/alejandro/appleseed/bin/appleseed.studio

i also did that , program run's ,still getting the crashing problem's

I think the reason appleseed.studio is crashing is because of Qt's SVG plugin.
We don't bundle it because we don't use SVG, but Qt is finding the plugin in your system's Qt install and crashes when trying to load it because of incompatible versions (4.8.7 vs 4.8.6).
We have to improve our linux package to handle these kind of situations.

Can you do another quick test?
cd /home/alejandro/appleseed/bin
touch qt.conf
/home/alejandro/appleseed/bin/appleseed.studio

Problem solved,after entering and runing those commands, appleseed work's just fine now, able to open the mentioned menus normally without any crash

We'll include an empty qt.conf file (or an equivalent nicer solution) in the next release.
Thanks for helping us fixing this issue.

glad to help, if you need any tester or somethink like that for the linux version of appleseed, im willing to help in the future

Fix here: 758bb96f34190cb6d1d8cd

Fixed.


Does this work on Windows 7 32-Bit?

lime build windows -32bit i think

hmmm..... kay

wher can i find it?

you put it in command prompt. also pretty sure this is a discussion


unskip embeddings test with multiple inputs

This is now supported by the azure service

/check-enforcer override


Bugfix transaction multiple function declaration

Closes #437
Description
This PR fixes a bug where a transaction includes multiple function declarations due to nature of SoleTransactionDeclaration.
Example of such transaction is:
pub fun dummy(_ address: Address): Void {}

transaction {
  prepare(acct: AuthAccount) {}
}

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

I guess this is question for @Bastian

I disagree 😉

The changes look good.
I'm wondering if it would make sense to change how SoleTransactionDeclaration works instead, so that his would be possible. I guess this is question for @Bastian and definitely not in scope here.

@janezpodhostnik you probably mean @turbolent
I assumed from the naming of the func that this is indeed how it should work but yeah maybe Bastian can share some light.


Merge master into revision

Ditto.

test me

Build Passed :ok_hand:
You can safely merge 'merge-master-into-revision' into 'revision'.

:+1:


Update styles for multi-selection button

To be merged with https://github.com/silverstripe/silverstripe-cms/pull/1218

Good thinking @dhensby, Updated :)