Draft: Add peek to ArrayQueue where T: Copy

Hi 👋 , I'm not sure if there is appetite in general for this feature but I personally found it useful. I would be happy to add the symmetric method to SegQueue as well. I noticed issue #30 but I figured it does not apply to this specialization. Also happy to just leave this be if it's not useful to anyone.

So after a bit of rework, I added a custom spinlock and was able to make miri happy locally. I'm skeptical if this is something that  the crossbeam team will really be interested in since it requires an extra spinlock which will cause contention between .peek() and .push() operations. Nonetheless I would be interested in feedback.

yep thanks for the consideration.


Change middleware registration order

This addresses issue #2666. The validation middlewares were registered before the authorization middlewares resulting in unauthorized requests executing the validation code in the application. This leads to a security flaw as validation libraries could be exploited and could be considered a form remote code injection.
The fix is simple and results on authorization checks happening before request validations.
@esune @amanji please review these changes and let me know what you think!

Please update for base branch.  Good if you can change it so I can do that. Not sure why I can’t with your PRs.

Adding reviewers @jamshale and @esune

@PatStLouis —need another base update and we can merge this.


enh: unpause connectors on resubscribe

Description
When a workspace churns, their datasources are kept around for 15 days and their connectors are paused.
If the workspace re-subs during this 15 days grace period, we need to unpause the connectors.
Risk

Deploy Plan

All good @PopDaph, tested locally 👍


Update getting-started.mdx

Log output is easier to read

Closing as changes are not needed. Please, reopen if you planned to update a different doc.


UpdatePipeline (and DeletePipeline) should require you to have access to the pipeline's output repo

Pipelines run as the last person to update them, and they need to write to their output repo. Therefore if you update a pipeline and don't have access to the output repo, the pipeline won't be able to run

Fixed by https://github.com/pachyderm/pachyderm/pull/2143


Have API calls sent from the server-side.

To hide API keys.

Use the server-api branch for that.

I won't do it because a server is not necessary even for the API calls.


Crash when time traveling to Windows XP

Part
Time Distorter 0.2
Expected behavior
It doesn't traveling to Windows XP because a bug
Steps to reproduce:
When in Windows 98
1.Go to Internet Explorer
2.Click www.12padams.com link
3.Download Web Chat 1999
4.Install Web Chat 1999
5.Open Web Chat 1999
6.Type my username to Web Chat 1999
7.Wait the chat until the tdistortv2.exe available
8.Download tdistortv2.exe
9.Install Time Distorter 0.2
10.Open Time Distorter 0.2
11.Click the Button to Travel to 2002
12.Screen Flashing
13.Green big Number showing from 1900 to 2000 then 2002
14.Histacom2.Engine preparing Windows XP
15.It disappear
Histacom version
Histacom 2.0.3-dev-14
.NET Framework version (if applicable)
.NET Framework 4.7.1

Thank you for reporting this bug, but I can't find the version of Histacom that you were playing that you encountered this error in. Please give a Commit ID for the build you're playing or give us a download link so we can look into this further. Thank you!

The Commit ID is 13a79337


Let users add languages

Currently all languages are included in source code, I think we should let users create languages file so they don't need to wait new language support and all messages can be customized.
For example, create a directory in config root called lang and contains all message language files such as en_US.lang, de_DE.lang and zh_CN.lang ..., so that users can update those files or create new languages files on their own.

My first approach would be to copy the whole folder already present in the source into the config folder of the plugin. Then players just set their languages and configure it appropriately. Users can then write a pull request to add their language to the repo if the language is not included yet.
I'll be working on this one tomorrow :)

Getting some issues with the config not currently reading the language that has been set and there are still some problems with getting the strings that belong to the language. Other than that, the system for copying and loading all languages found in the source code is now in and will be included once all other errors with the system have been fixed :)

Added in a1824a8edb01b941247ef65527eb28e451dec3a9. As noted earlier, the locale folder is now exported from the plugin jar into the plugins folder, which means that anyone can use pull requests to bring in their own default languages to the project :)
I also removed the broad usage of locales everywhere, aswell as the per-player locales, since neither were really implemented in a meaningful way.
If the feature of having individual players choose the language they see items and messages in, that could be added in a more central fashion (i.e. attaching the locale to messages and items in one class rather than in the whole project).


Updated README.md to release version <IP_ADDRESS> of gradle plugin

Thanks - I just updated the release version to 4.0.1.


Extension is not compatible with version of VS code.

You may need to upgrade your VSCode.

Thanks. Now the extension is installed. However, when I try to run the current cell or run the current script. All lines are sent directly to the PowerShell terminal rather than the Matlab command window. I confirm that a Matlab command window does pop up.

In windows, you need to install the matlab python engine (link), and check the pybackend option in the settings of the extension.

Actually, I had it installed. My bad, I forgot to tick it in setting. Btw, is there a way to run the code line by line? Also, I did not see any variable showing up when I click on "show variables".

Press shift + enter to run the current line or the selected lines.
As for the variable scope, unfortunately, this is an unknown bug. In my windows PC, it just works, but there also some users reported that it didn't work in their PCs. You may just type workspace in the terminal to use the native variable scope.
I apologize for not being helpful with this issue.

Nope. Thanks for your timely reply.


Unable to delete my account

Describe the bug
I don't find an option to delete my account permanently from your database.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-mzgaw4
Steps to reproduce
I don't find it in the settings or on my profile after selecting the bottom left pane
Expected behavior
I am expected to offload from your platform if I wish to
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 129
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 116879464,
  "usedJSHeapSize": 94099648,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = mukiralad
Chat ID = 094d49f7926f

Additional context
Message:
I've successfully imported your project. I'm ready to assist you with analyzing and improving your code.

Hi,
Sorry to hear you want to leave us.
You can do that by going to

stackblitz.com
Click on your profile icon in the top right
Your settings
Select Profile tab
Scroll down to 'account deletion'

If there is anything we can do to keep you a StackBlitz user, let us know.


Demo - BN and Beneficial Owner credentials

Create an issuer for a BN and Beneficial Owner credential and issue to OrgBook
Update OrgBook search to allow Organization search by BN

Closing this issue.


Fix compatibility with pytest 3.8.0

As discussed in https://github.com/pytest-dev/pytest/issues/3973, pytest 3.8.0
introduced some code that ends up checking the cwd by accident. One of
the tests in your test suites changes the cwd to a temporary directory, and
this blows up some tests after it.
This change uses the monkeypatch fixture to safe cwd-switching, by
restoring it to the original value at the end of the test.

Fair enough, thanks! Done

@nicoddemus @RonnyPfannschmidt Thanks! :heart_eyes:

we are eager and happy to help people get gravitate towards better testing, its been a pleasure :+1:


fix(amount-input): inputClassName is passed correctly now

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 83.272%

Totals

Change from base Build<PHONE_NUMBER>4:
-0.005%

Covered Lines:
10138

Relevant Lines:
11181

💛  - Coveralls


Add data source to sign pipelines

@triarius: This PR adds a data source that signs pipelines. Because a signed pipeline and an unsigned pipeline are the same resource in the API, there is no need to create a separate resource for signed pipelines. Indeed, the buildkite_signed_pipeline_steps data source is a local only data source, which only calculates the signed steps that are to be passed into the buildkite_pipeline resource.
The example that I've added to the docs should make this clear:
locals {
  repository = "git@github.com:my-org/my-repo.git"
}

data "buildkite_signed_pipeline_steps" "my-steps" {
  repository  = local.repository
  jwks        = file("/path/to/my/jwks.json")
  jwks_key_id = "my-key"

  unsigned_steps = <<YAML
steps:
- label: ":pipeline:"
  command: buildkite-agent pipeline upload
YAML
}

resource "buildkite_pipeline" "my-pipeline" {
  name       = "my-pipeline"
  repository = local.repository
  steps      = data.buildkite_signed_pipeline_steps.my-steps.steps
}

I was going to get to reviewing this tomorrow but thought with the changes now I should check in on the plan and status. I see its been changed to a data source. That is a read-only thing so won't allow creating a pipeline with signed steps. I'm not sure how that ties into the overall signed pipelines stuff. Can you give some extra info?
And should we just wait to review this when it is out of draft or should we review now?

And should we just wait to review this when it is out of draft or should we review now?

I'll undraft it now, so fire away. I planned to add a test and fix up the PR description before undrafting. It would have explained some of the reasoning behind why it's a data source and not part of the pipeline resource.

And should we just wait to review this when it is out of draft or should we review now?

I'll undraft it now, so fire away. I planned to add a test and fix up the PR description before undrafting. It would have explained some of the reasoning behind why it's a data source and not part of the pipeline resource.

No worries. I'll leave it for tomorrow then for some extra time/changes

@jradtilbrook, this is ready for your review.

I've added some vaildators. I've left out validating that the key id is contained in the key set. It seems more appropriate to do that at runtime, especially if a jwks_file is provided as that would require the validator reading the file.

There is also this handy page to test the output of the docs for this new data-source: https://registry.terraform.io/tools/doc-preview

There is also this handy page to test the output of the docs for this new data-source: registry.terraform.io/tools/doc-preview

Neat, I've changed it around a bit to look nicer when rendered.


Use boost::variant

Most of JSON libraries re-invent boost::variant<> to store polymorphic values.
Why?

Because use of boost::variant would add a user dependency on Boost.


Fix deadlock during stopping CacheManager

https://issues.jboss.org/browse/ISPN-6869
actual fix implemented by @danberindei , but as the fix was not sent for pretty long time and bug is still there sending PR myself

@vjuranek Anxious to see the CI results, I think I didn't open a PR because I saw some test failures on my machine...

@danberindei hm, tests passed on my machine, but it seems that there's really some issue and testsuite has hanged. Would it be possible to take thread dump?

@vjuranek Yes, there is a "View thread dump" link on the build page. After the build was killed (manually or after a timeout) you can also see the thread dump in the build log.

@danberindei there was a deadlock then the same cache is started from cache started listener. I hope the fix is trivial (PR updated), but let's wait for CI.

IMHO these two failures are not related to this change (and they are random, cannot reproduce locally)

Closing, please reopen once rebased.

Friendly reminder: first reopen and force push AFTER. The other way around does not work :smile:

Please don't close PRs unless you really want to close them completely. I (and lots of other people) haven't sufficient rights to re-open PR, so @slaskawi could you please re-open? I've already rebased locally, as per @gustavonalle advice I'll push it once re-opened. Thanks!

rebased (thanks @rvansa for re-opening)

test failures are not related to this PR. (and can someone please remove "Needs rebase" label? thanks)

comments incorporated and rebased

import after rebase fixed

Hrmm a lot of these test failures are related to shutting down a server [1]. @vjuranek can you confirm they aren't related or fix? Thanks.
Also @danberindei how severe of an issue is this? Does it make sense for this to make it to 9.0 or can it wait until 9.1?
[1] http://ci.infinispan.org/viewLog.html?buildId=53463&buildTypeId=bt9

@tristantarrant rebased nad fixed
@wburns most of the test are flaky tests. I checked those which are not and these are not related to this change. Only ClusterTopologyManagerTest#testAbruptLeaveAfterGetStatus2 could be related, but I'm not able to judge as I cannot reproduce locally.

@vjuranek Needs rebasing again, sorry about that! :$

rebased

This is mostly my code so I won't integrate it myself, feel free to add comments/questions or to integrate it guys!

Waiting for CI

Integrated, thanks @danberindei !


Pretty pictures for documentation

I like the example classifications from sckit-learn: http://scikit-learn.org/stable/auto_examples/classification/plot_classifier_comparison.html.
I've implemented the same sort of thing for my WIP randomforest library in a "demo" crate and it should be easy to do the same for the classifiers in this library.
e.g. classifying points in a plane using a forest containing hyperplane classifiers (coloured dots are the input data, other points are coloured by the weighted sum of their predicted classes):

Do you have any interest in me doing this? I'm not sure the pictures are all that helpful, but they might catch the eye of people reading the readme! If I do add this where should the code go? It depends on imageproc, which pulls in a load of dependencies.
Not a big deal if you're not interested :-)

Of course I would love more pretty pictures in the documentation! However - I'm not sure that the README is necessarily the best place for this (it probably is right now).
So I have thought about this a little before and decided that I didn't want to add any examples directly into the rusty-machine repo. I'd prefer the examples to be about explaining library usage. I may be open to changing my mind though. I definitely don't want to include these as part of the rusty-machine project though - mostly as I don't want to litter the manifest (even with devDependencies).
With that said - there are some existing demo examples. Though I'm not sure they qualify as pretty. I created a demo image-compression project which uses rusty-machine. And I also worked on learning-machines. I plan on working on the latter a little more when I have some time - though making it pretty is way outside my area of expertise...
I think in the future I'd like to see pretty examples given as feature cases in the README. Maybe a Projects featuring rusty-machine section? Of course - for this to be valuable we need some more projects using rusty-machine :).

Ok, sure. I've added an inline example of what I meant in the original post. Learning-machines looks like it might be a good match for this sort of visualisation. I don't know anything about web development but I might have a go at adding something there. Feel free to close this issue.

I'd love for you to take a look at learning-machines!
I'll keep this issue open (for a little while) as I feel like others may have opinions on it too. I'm sure it would help to catch more people's attention if we could clearly show what the library is capable of.

I thought a little more about this today. I think perhaps a good idea would be to have examples which can produce pretty graphics on their own, through libraries like dataplotlib. This library in particular isn't quite there yet but I think it is good thing to work towards.

I'm not completely sure what you mean. The linked example produces these visualisations 'on its own'.

It might be that we are both describing the same thing!
I meant that instead of producing graphics and putting them in documentation we could write examples, which would live in the examples folder, and would produce these graphics when the user ran them (cargo run --example classify-plot) and display them to the user.
The advantage being they become part of our test cycle (cargo test compiles examples), and we don't have to carefully maintain the graphics in lots of docs.
On Nov 5, 2016, at 5:14 PM, theotherphil <notifications<EMAIL_ADDRESS>wrote:
I'm not completely sure what you mean. The linked example produces these visualisations 'on its own'.

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/AtheMathmo/rusty-machine/issues/129#issuecomment-258625850, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJrkStgTdluNyVvtjCmgb48U0wKcTpAjks5q7LlxgaJpZM4KCK9Q.

Ah right. Yes, that's how I was imagining this would work. The image in the first comment is generated by running randomforest-demo using the example input data.


archiving round robin or priority

please add either the ability to have the archive do a round robin, or favor the larges free space, or some way to set priority.
What's happening is that I'll end up with 4-5 archive writes to a single drive while I have 8 drives in the archive pool.  This causes HDD thrashing and is super super slow.

For anyone who's searched for this or is interested in this feature, I have a work around.
I'm using aufs to create a mount point in the archive directory with the mount option 'create=rr'.
I initially put all of my plot directories in as read/write (=rw) and let aufs spread them around.  When one get's full, aufs will generally handle that in the rr write cycle but I change the mount options for the path to =ro to take it out of the write loop.
You can use aufs tools, or fstab mount.  I use fstab just because I'm comfortable with that and it survives reboots.  mount -o remount will update the mount point for changes.


[Question] How to implement class and inherits from C side?

Hello,
I'm trying to implement inheriting classes from C side, can someone tell me how to do this? any ideas will be appreciated.
For details, one SuperClassB inhirts from SuperClassA, both of them are expected to be explored to ES world from C side, and one ChildClass can be implemented from ES side then.
// how to implement following two classes from C side?
class SuperClassA {
  static testA() {
    // do something
  }
}

class SuperClassB {
  static testB() {
    // do something
  }
}

In general there is no simple way to do this. JerryScript supports native C function callbacks. You can build a system on top of it (something auto-generates code for classes).


[extractors/podbayfm] Add extractor

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

ADD DESCRIPTION HERE
Fixes #
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[x] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Pls avoid force-pushing

pls fix linter and run the tests

In future, pls avoid force-pushing


COI - Add employee number validation

AC

[ ] In Employee Sign Off Statement, employee number must be a 6 digit number.
[ ] Error message should be "Employee number invalid, must be a 6 digit number"

Tested successfully
@jerry-ey could you please fix the error messages for validation and maybe remove  "\d{6}"

fixed,

Thanks Jerry!

looks good


ARROW-8332: [C++] Don't require Thrift compiler for Parquet build

@github-actions crossbow submit test-debian-10-cpp

Oh thank you for taking care of this @kou

@github-actions crossbow submit test-debian-10-cpp

+1
test-debian-10-cpp uses system Thrift without thrift-compiler.


Update prepare_loopback_swap.yml

The task will fail with the following error:
TASK [bootstrap-host : Ensure that the swap file entry is in /etc/fstab] *******
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: AttributeError: 'int' object has no attribute 'replace'
fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "parsed": false}

Apparently this is an issue in the core ansible module mount. Single quoting the int values (changing to string) solves the problem.

Thank you for contributing to openstack/openstack-ansible!
openstack/openstack-ansible uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


Xaml gallery closes/crashes

Steps to reproduce the bug
Steps to reproduce the behavior:

Start xaml gallery (<IP_ADDRESS>)
Click on Searchbox
type "TabView"
press arrow down on your keyboard to select "TabView" item
press enter on your keboard
app closes/crashes

Expected behavior

Actual behavior

Screenshots

Version Info

[ ] Xaml Controls Gallery - Downloaded from Store

If so, which version? (1.2.x -- Found on the Settings page of the app.)

[x] WinUI 3 Controls Gallery - Downloaded from Store

If so, which version? (<IP_ADDRESS>x -- Found on the Settings page of the app.)

[ ] App built locally from source

If so, which branch? (WinUI 3 versions are built off the winui3 branch)

Additional context

Windows version:

[ ] Insider Build (xxxxx)
[ ] May 2021 Update (19043)
[ ] October 2020 Update (19042)
[ ] May 2020 Update (19041)
[ ] November 2019 Update (18363)
[ ] May 2019 Update (18362)
[ ] October 2018 Update (17763)
[ ] April 2018 Update (17134)
[ ] Fall Creators Update (16299)
[ ] Creators Update (15063)
[ ] Anniversary Update (14393)

Device form factor:

[ x] Desktop
[ ] Mobile
[ ] Xbox
[ ] Surface Hub
[ ] IoT

Question: This is maybe per design but if so it's extremely interesting design

click "what's new"
click i.e. "pipspager" from the list
it moves you to PipsPager description but still in NavView "what's new" is selected. so clicking on "what's new" causes no action. IMO it might be maybe more user friendly if it can bring you back to the "whats new" page. (you can use back button, btu still)

Thank you for filing this bug @get-flat. We are aware of the bug crash when using the SearchBox. We are trying to fix this and it should be patched in the next update.
Regarding your comment, this is a different bug. I created a second issue (#845) to track it. Let me know what you think.

I'm reopening this as it is still not fixed. When this gets patched, I'll make sure to close this issue :) Have a great weekend @get-flat and thanks again for filing this.


Add a memop module defining safe abstractions over syscall::memop.

This change adds a memop module with functions abstracting sub-syscall numbers of syscall::memop. The other syscalls already have safe abstractions for each driver, and memop functions can be useful for the entry_point and for debugging from userspace.

This is cool! Is it worth adding documentation comments to each syscall describing what it does?

Probably better to just point to
https://github.com/tock/tock/blob/master/doc/syscalls/memop.md rather than
have duplicate information that could possibly get out of sync
On Thu, Oct 10, 2019 at 10:42 Alistair Francis<EMAIL_ADDRESS>wrote:

This is cool! Is it worth adding documentation comments to each syscall
describing what it does?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tock/libtock-rs/pull/96?email_source=notifications&email_token=AACS3XWDV6SHUZBGISRJGP3QN5SOTA5CNFSM4I7BKRNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA5FSWY#issuecomment-540694875,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACS3XUFFRW5FAR36Y2SVGDQN5SOTANCNFSM4I7BKRNA
.

Good point, can we add a link to that in the code? Maybe with a date or SHA to help keep it in sync?

In general, most files in this library refer to some part of the Tock kernel, be it:

syscalls.rs https://github.com/tock/tock/blob/master/doc/Syscalls.md
memop.rs https://github.com/tock/tock/blob/master/doc/syscalls/memop.md
driver_foo.rs https://github.com/tock/tock/blob/master/doc/syscalls/foo.md

However, we don't usually link to the Tock doc. Is it something that we want to do in a more systematic way?
Regarding keeping track of a compatible Tock version, there is already a mention in the README Tested with tock <commit>. Shouldn't this cover the whole repository, including in particular memop.rs?
More generally, I'm all in favor of having libtock-rs releases versioned together with Tock (e.g. Tock 1.4 can be used by libtock-rs 1.4.x), but for now libtock-rs is still missing a lot of drivers, and "nascent and still under heavy development", so I'm also wondering about the overhead of duplicating info, getting it out-of-sync, etc.
Does it even make sense to pin libtock-rs to a specific Tock commit (why not a Tock release instead?), or should it simply follow Tock HEAD (which would incur less overhead, at the risk of some occasional breakage) until libtock-rs is stable enough and start having releases?

FWIW libtock-c does the “independent with undesired but occasionally
possible breakage, but release together” model:
https://github.com/tock/libtock-c/releases/tag/release-1.4
On Fri, Oct 11, 2019 at 04:53 gendx<EMAIL_ADDRESS>wrote:

In general, most files in this library refer to some part of the Tock
kernel, be it:

syscalls.rs https://github.com/tock/tock/blob/master/doc/Syscalls.md
memop.rs
https://github.com/tock/tock/blob/master/doc/syscalls/memop.md
driver_foo.rs
https://github.com/tock/tock/blob/master/doc/syscalls/foo.md

However, we don't usually link to the Tock doc. Is it something that we
want to do in a more systematic way?
Regarding keeping track of a compatible Tock version, there is already a
mention in the README Tested with tock . Shouldn't this cover the
whole repository, including in particular memop.rs?
More generally, I'm all in favor of having libtock-rs releases versioned
together with Tock (e.g. Tock 1.4 can be used by libtock-rs 1.4.x), but for
now libtock-rs is still missing a lot of drivers, and "nascent and still
under heavy development", so I'm also wondering about the overhead of
duplicating info, getting it out-of-sync, etc.
Does it even make sense to pin libtock-rs to a specific Tock commit (why
not a Tock release instead?), or should it simply follow Tock HEAD (which
would incur less overhead, at the risk of some occasional breakage) until
libtock-rs is stable enough and start having releases?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tock/libtock-rs/pull/96?email_source=notifications&email_token=AACS3XVFI7IMOB72RIHB7Z3QOBSLXA5CNFSM4I7BKRNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA7YDKY#issuecomment-541032875,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACS3XRGK5BTIC2Y7QWGYYLQOBSLXANCNFSM4I7BKRNA
.

My main concern here is that tock adds a new memop call. Then we have these functions that just don't support the new call (you can still manually call it). A new user looks at this code and just assumes that this is all the calls that are supported and never uses the new call.
Unrelated to testing on certain versions I think it would be useful to have something that says along of the lines of "these calls were added based on tock , you can check the tock documentation at  to see if anything has changed". It doesn't have to be that explicit, it just seems worthwhile.

@alistair23 I added a reference to the Tock version and relevant documentation.


Refs #6376 -- Added support for custom gettext domains.

https://code.djangoproject.com/ticket/6376
This PR changes the LOCALE_PATHS setting to allow usage of custom gettext domains.

@charettes just fixed it, thanks.

@timgraham or @carltongibson, would be great to plan a final detailed review for this patch.

Failing CI build doesn't seem to be related to this changes.

@carltongibson @timgraham Anything else I need to do so this can be merged?

@R4G3-BABY Thanks for this patch :+1: I rebased from master and pushed minor edits.
@claudep Is there anything left for this ticket? (you mentioned to use Refs instead of Fixed) maybe using custom domains inside INSTALLED_APPS :thinking: .

@claudep  :point_up: :pray:

Sorry, it's on my TODO, I may have difficulty to review stuff during the week. I'll do my best!

Thanks! np, take your time.

I think this patch is missing some changes in makemessages/compilemessages commands code. We might address this in a further PR, but it would be blocking for the next release.

@claudep Thanks for comments. I added two commits with support for custom domains in compilemessages (compile custom locales) and makemessages (ignore custom locales :thinking: ). Can you take a look?

Reviewing but, quick comment, in case Claude gets to this now:

...makemessages (ignore custom locales 🤔 )

I'm a bit ¿Que? here. Maybe this is right, but why?
(So I'm a user. I think "I'll use a custom gettext domain for my translations". But I can't gather them. Do I have to create a makemessages override to use this, or what? — Looks like there's some documentation missing, on how to use this new feature.)

Yeah, that's why there is a thinking emoji there :smile: I wasn't sure if that's a correct behavior. I think that compilemessages works fine now, I also fixed watch_for_translation_changes() failure so it seems that only makemessages remains.

Closing due to inactivity.


Problem with open MPQ archives (Protected)

Sample01.zip
Help! It's a starcraft ii mod. which can't open...

The MPQ header's MD5 does not match. The archive is corrupt.

I'm sure the SC2 can open the document, the game can load it but even the editor of SC2 will get crash.

the offset C0h is wrong (md5), but it really a mpq document from the battlenet cache.

it was named as e41f710d11ffd2108dbeec450f25e01c9c76cf221f023a3f909ca0056433af31.s2ma in the cache.
the sha256 of it should matched to this sample

Sample02.zip
i think the same protect also exists in this one. which i have make sure the sc2 can open/read it.

i have found some breakpoints to put (seems like SFileReadFile function), which it hits when the game attempt to read any file from mpq archives, this can expose the file name in archive, file size, and follow it can get the file data in memory. (maybe can help to working out this issue?)

i have test with a normal map file. which it can be open normally, if i change the md5 hash manually by edit the hex of file, offset 0xC0. the editor can not open the document any longer. (not throw the missing dependency messagebox.)
but the sample02, no matter keep the error md5 or edit it to other hex. offset 0xC0, the editor throws the missing dependency messagebox everytime. seems could open it.

I removed header hash check from StormLib. When I rebuilt MPQ Editor with the new StormLib, it could open both Sample01 and Sample02, but there are no files.

I removed header hash check from StormLib. When I rebuilt MPQ Editor with the new StormLib, it could open both Sample01 and Sample02, but there are no files. I'll keep StormLib as it is, until I find a map that contains something.

what means find a map that contains something..?

what means find a map that contains something..?

The two samples you sent contain nothing (aka no files).

what means find a map that contains something..?

The two samples you sent contain nothing (aka no files).

why i send two empty archives.. the sc2 editor can open/read the files in those archives.

Sample02-DocumentInfo.zip
please see the 'Sample02-DocumentInfo.zip'.
i have made it.
this should be enough to prove the the document Sample02.SC2Map has the '\DocumentInfo'
in test environment, open the editor, and prepare the breakpoints, put on two location.

SC2Editor_x64.exe+2B62132 -> rsi size of file, [rcx]+E8 is filepath (maybe file name only) (the filepath in the archive)
SC2Editor_x64.exe+2B62205 -> rbx points to data which it reads.
that means every time sc2 editor try load a file from the mpq archive, it will meet breakpoint 1, after read the file, it will meet breakpoint 2.

after the breakpoints ready, drag the Sample02.SC2Map to the sc2 edtior.
the first time breakpoint hit, (attributes) file. at this time, the RAX points to the memory region seems mentioned the header hash is invalid. (see the picture RAX.png)
and the second time hits, its the file i assumed (DocumentInfo).
i have dump the data which read by edtior (breakpoint 2 hit, rbx points to data) to the file DocumentInfo. (it's pure, same xml file to other sc2 maps.) (length is 0x41B2, see the rsi of Breakpoint 1 Hit.png)

I am sorry, you were right. StormLib incorrectly handled MPQ Archives v 4.0, which have fake MPQ headers. I fixed it in commit https://github.com/ladislav-zezula/StormLib/commit/ac0dfb94b0a2482f06c2dbff11104448857640a1. I also rebuilt MPQ Editor.

I am sorry, you were right. StormLib incorrectly handled MPQ Archives v 4.0, which have fake MPQ headers. I fixed it in commit ac0dfb9. I also rebuilt MPQ Editor.

Thank you very much!

would you please send me the StormLib.dll of this new version? in fact i dont know how to compile it..

Download link: http://www.zezula.net/download/stormlib_dll.zip

Download link: http://www.zezula.net/download/stormlib_dll.zip

thanks

So you basically does nothing to reverse enginner this protection, rather bags ladislav-zezula to reverse enginner it instead of you and yet you brags for it all over the place like you did whole thing lmao

this cringefest. also @ladislav-zezula , please stop doing skiddy's job instead, rather make them to do it themself.

So you basically does nothing to reverse enginner this protection, rather bags ladislav-zezula to reverse enginner it instead of you and yet you brags for it all over the place like you did whole thing lmao

i dont say 'i patched', i just says, its patched. do i?
and in fact i do not have any interests on those two maps, at least now.

So you basically does nothing to reverse enginner this protection, rather bags ladislav-zezula to reverse enginner it instead of you and yet you brags for it all over the place like you did whole thing lmao

and in my qq group, i dont use discord, i says that zezula made it. i believe he can. i just prove the document its not empty. i dont say that i patched at all.


Implement .prof output

Nice profiler! I used it on a project and got some good usage out of it, as #9 raised though there is a lot of Python tooling out there to support .prof files such as snakeviz, etc. so I thought I'd add support for cProfile.
In addition to the new code I added an example and test for it - although the test is rudimentary (it just checks whether the .prof file exists and is non-empty) I had success on my machine getting the .prof output and loading it into snakeviz! Thanks again for the profiler.

LGTM~


Warnings for manually calling a React.PropTypes validation functions

Hi,
First I have to say that react-bootstrap-table is fantastic. It is a pleasure to work with. I'm getting a few warning messages when I add New, Delete and Search.
I'm running
<EMAIL_ADDRESS>and
├──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>
I get the following warning message:
Warning: You are manually calling a React.PropTypes validation function for the **toastTypeprop onToastContainer**. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.
I get the same warning message for the props below.
**`id` prop on `ToastContainer`
`toastMessageFactory` prop on `ToastContainer`
`preventDuplicates` prop on `ToastContainer`
`newestOnTop` prop on `ToastContainer`
`onClick` prop on `ToastContainer`**

Not sure if it is a version issue or something else.

I think this is the same issue as [(https://github.com/tomchentw/react-toastr/issues/75)] which it looks like it hasn't been fixed yet.

@g3blv, good finding, hope there's someone can fix it in react-toastr. I'll close this issue. BTW, maybe you can open a PR to ```react-toastr``. Thanks you :)

@AllenFang I've checked with the author of react-toastr issue #75. He no longer sees the issue while I do. Could the issue be somewhere else in react-boostrap-table?

@g3blv, I've no idea about this issue, because the warning message is all about the react-toastr.  But i'll spend some time to check this out.

+1


[cli] cannot read properties of undefined on fresh install

Nathan says:
my (highly uninformed) sense is that there's some race condition between what is populating the config used in https://github.com/dxos/dxos/blob/main/packages/devtools/cli/src/base-command.ts#L61 and the invocation of such at https://github.com/dxos/dxos/blob/main/packages/devtools/cli/src/base-command.ts#L150
GitHub
dxos/base-command.ts at main · dxos/dxos
TypeScript implementation of the DXOS protocols, SDK, and toolchain. - dxos/base-command.ts at main · dxos/dxos
dxos/base-command.ts at main · dxos/dxos
wasn't able to figure out where/when that context gets populated with that configDir key

Nathan and Jonan encountered this on their machines

Need to ask Jonan about repro

There is no race condition connected to config init. But there was a bug with config path, fixed it

Repro steps

npm i -g @dxos/cli
Start daemon

@nferch was not able to repro it, but Dima unblocked it

@mykola-vrmchk I can still reproduce this one, https://github.com/dxos/dxos/issues/3330 is the one that I believe is fixed

Seeing this here as well https://github.com/dxos/dxos/actions/runs/5256973213/jobs/9499069325#step:13:81

@nferch This should fix that error https://github.com/dxos/dxos/pull/3475
I tested it with npm link, it worked for me as expected

@mykola-vrmchk you could try the song-and-dance here: https://github.com/dxos/dxos/compare/main...nferch/npm_cli_smoketest#diff-1a5079bb84ca40f5409a2588a7bb187d5b61d3923704a6025f053ff5a719abc3R32
Also my PR to build and publish main was merged, but tests are failing: https://github.com/dxos/dxos/pull/3440

Bug is fixed


Old version of pip is installed into pack's virtualenv

SUMMARY
It seems that when the virtualenv's are built that some weird version of pip gets installed and I'm not sure where this is coming from. I even upgraded the system pip version to latest with no avail.
Because such an old version of pip gets installed it doesn't have support for some of the libs that get installed for things like st2client. Specifically orjson as it tries to build from source which requires rust to be installed.
STACKSTORM VERSION
st2 3.4.1, on Python 3.6.8
OS, environment, install method
HA cluster with two nodes and a controller.
Steps to reproduce the problem
Install a pack either manually or automatically. I'm not sure what the prereq's are. I have python 3.6 installed via yum. This installs an even older version of pip than what gets built in the virutalenv.
Expected Results
That the pip version from /opt/stackstorm/st2 gets installed and not some other version.
Actual Results
The install
<redacted> virtualenvs # /opt/stackstorm/st2/bin/virtualenv -p /opt/stackstorm/st2/bin/python --system-site-packages --verbose --no-download /opt/stackstorm/virtualenvs/zabbix -vvvv
Already using interpreter /opt/stackstorm/st2/bin/python
Using real prefix '/usr'
Creating /opt/stackstorm/virtualenvs/zabbix/lib/python3.6
This system uses lib64; symlinking lib64 to lib
Symlinking Python bootstrap modules
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib/python3.6/lib-dynload
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib/python3.6/config-3.6m-x86_64-linux-gnu
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/os.py
  Ignoring built-in bootstrap module: posix
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/posixpath.py
  Cannot import bootstrap module: nt
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/ntpath.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/genericpath.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/fnmatch.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/locale.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/encodings
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/codecs.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/stat.py
  Cannot import bootstrap module: UserDict
  File /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/lib-dynload/readline.cpython-36m-x86_64-linux-gnu.so already exists
  Cannot import bootstrap module: copy_reg
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/types.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/re.py
  Cannot import bootstrap module: sre
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/sre_parse.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/sre_constants.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/sre_compile.py
  File /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/lib-dynload/zlib.cpython-36m-x86_64-linux-gnu.so already exists
  Cannot import bootstrap module: _abcoll
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/warnings.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/linecache.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/abc.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/io.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/_weakrefset.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/copyreg.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/tempfile.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/random.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/__future__.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/collections
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/keyword.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/tarfile.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/shutil.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/struct.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/copy.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/tokenize.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/token.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/functools.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/heapq.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/bisect.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/weakref.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/reprlib.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/base64.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/_dummy_thread.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/hashlib.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/hmac.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/imp.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/importlib
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/rlcompleter.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/operator.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/_collections_abc.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/_bootlocale.py
  Symlinking /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/enum.py
  No LICENSE.txt / LICENSE found in source
Creating /opt/stackstorm/virtualenvs/zabbix/lib/python3.6/site-packages
Writing /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/site.py
Writing /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/orig-prefix.txt
Creating parent directories for /opt/stackstorm/virtualenvs/zabbix/include
Symlinking /opt/stackstorm/virtualenvs/zabbix/include/python3.6m
File /opt/stackstorm/virtualenvs/zabbix/lib/python3.6/lib-dynload already exists
File /opt/stackstorm/virtualenvs/zabbix/lib/python3.6/config-3.6m-x86_64-linux-gnu already exists
Creating /opt/stackstorm/virtualenvs/zabbix/bin
New python executable in /opt/stackstorm/virtualenvs/zabbix/bin/python
Changed mode of /opt/stackstorm/virtualenvs/zabbix/bin/python to 0o755
Testing executable with /opt/stackstorm/virtualenvs/zabbix/bin/python -c "import sys;out=sys.stdout;getattr(out, "buffer", out).write(sys.prefix.encode("utf-8"))"
Got sys.prefix result: '/st2content/virtualenvs/zabbix'
Creating /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/distutils
Writing /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/distutils/__init__.py
Writing /opt/stackstorm/virtualenvs/zabbix/lib64/python3.6/distutils/distutils.cfg
Running command /opt/stackstorm/virtualenvs/zabbix/bin/python -m pip config list
Installing setuptools, pip, wheel...

  Running command /opt/stackstorm/virtualenvs/zabbix/bin/python - setuptools pip wheel
  Looking in links: /opt/stackstorm/st2/lib/python3.6/site-packages/virtualenv_support
  Collecting setuptools
  Collecting pip
  Collecting wheel
  Installing collected packages: setuptools, pip, wheel
  Successfully installed pip-19.1.1 setuptools-41.0.1 wheel-0.33.4
...Installing setuptools, pip, wheel...done.
Writing /opt/stackstorm/virtualenvs/zabbix/bin/activate
Writing /opt/stackstorm/virtualenvs/zabbix/bin/activate.fish
Writing /opt/stackstorm/virtualenvs/zabbix/bin/activate.csh
Writing /opt/stackstorm/virtualenvs/zabbix/bin/activate.ps1
Writing /opt/stackstorm/virtualenvs/zabbix/bin/activate_this.py
Writing /opt/stackstorm/virtualenvs/zabbix/bin/activate.xsh
Writing /opt/stackstorm/virtualenvs/zabbix/bin/python-config
Changed mode of /opt/stackstorm/virtualenvs/zabbix/bin/python-config to 0o755

This is the installed pip versions. I also upgraded the system pip3 to version 21.2.2 and still get 19.1.1 installed.
(st2) <redacted> virtualenvs # for i in $(ls); do $i/bin/pip --version; done
pip 19.1.1 from /opt/stackstorm/virtualenvs/ansible/lib/python3.6/site-packages/pip (python 3.6)
pip 19.1.1 from /opt/stackstorm/virtualenvs/bitbucket/lib/python3.6/site-packages/pip (python 3.6)
pip 19.1.1 from /opt/stackstorm/virtualenvs/chef/lib/python3.6/site-packages/pip (python 3.6)
pip 19.1.1 from /opt/stackstorm/virtualenvs/docker/lib/python3.6/site-packages/pip (python 3.6)
pip 19.1.1 from /opt/stackstorm/virtualenvs/jenkins/lib/python3.6/site-packages/pip (python 3.6)
pip 19.1.1 from /opt/stackstorm/virtualenvs/msexchange/lib/python3.6/site-packages/pip (python 3.6)
pip 19.1.1 from /opt/stackstorm/virtualenvs/opsgenie/lib/python3.6/site-packages/pip (python 3.6)
pip 19.1.1 from /opt/stackstorm/virtualenvs/servicenow/lib/python3.6/site-packages/pip (python 3.6)
pip 19.1.1 from /opt/stackstorm/virtualenvs/splunk/lib/python3.6/site-packages/pip (python 3.6)
pip 19.1.1 from /opt/stackstorm/virtualenvs/zabbix/lib/python3.6/site-packages/pip (python 3.6)
pip 19.1.1 from /opt/stackstorm/virtualenvs/zabbix/lib/python3.6/site-packages/pip (python 3.6)
(st2) <redacted> virtualenvs # pip3 --version
pip 20.0.2 from /opt/stackstorm/st2/lib/python3.6/site-packages/pip (python 3.6)
(st2) <redacted> virtualenvs # /usr/bin/pip3 --version
pip 9.0.3 from /usr/lib/python3.6/site-packages (python 3.6)

Thanks!

Orjson I think was only used in st2 3.5.0.
St2 3.4.1 used pip 19.1.1
St2 3.5 uses pip 20.3.3.
I wonder if you are using the st2client version that was built for 3.5?

Locally I'm using what came with the st2 package.
The orjson install issue comes from a pack install failing, specifically Zabbix which installs the st2client no pinning. So its trying to the latest version of st2client while my local version is 3.4.1.
I guess this now makes sense was to why my package install is failing. But I still dont understand how 19.1.1 is being installed when the base virtualenv comes packaged with 20.3.3.

@minsis If I remember correctly I think its because of the version of virtualenv itself. So virtualenv comes with a pip version bundled with it. So the version of virtualenv used in ST2 3.4.1 comes with pip 19.1.1, and we upgraded virtualenv in ST2 3.5, to use the version that comes bundled with 20.3.3.

@amanda11  Upgrading to 3.5.0 fixed the issue. The new virtualenv's that get created are running 20.3.3 now which will now install the correct wheel for orjson instead of trying to build the core with rust. I guess some of the packs are not backwards compatible if they're requiring some sort of build from source for certain libraries. In this case if the pack needs to have st2client installed without pinning, its going to break.


Crear DIEGOHJJACOBO

content/apps/creating-github-apps/authenticating-with-a-github-app/authenticating-with-a-github-app-on-behalf-of-a-user.md

Why:
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@DIEGOHJJACOBO


Duplicate css entry in angular-cli.json produces cryptic webpack error

Ideally ng serve should still work with a duplicate entry under styles but give a warning instead of an error.
OS?
Mac OSX El Capitan
Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

angular-cli: 1.0.0-beta.17 node: 6.4.0 os: darwin x64
Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

In the angular-cli.json created by ng init, add a duplicate entry to apps[styles] - e.g.:
"styles": [         "styles.css",         "styles.css"       ],
The log given by the failure.

Normally this include a stack trace and some more information.

Running ng serve gives this error:
`Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.

configuration.entry['styles'] should be one of these:
string | [string]
The entry point for one output file.
configuration.entry should be one of these:
object { : string | [string] } | string | [string]
The entry point(s) of the compilation.`

Mention any other details that might be useful.

A couple of nits:
ng serve allows multiple entries in angluar-cli.json, AS LONG as they are different.
I can reproduce the error if "styles": [ "styles.css", "styles.css" ],
If the configuration becomes "styles": [ "styles.css", "styles2.css" ],
ng serve builds the dist, but complains:
ERROR in multi ./src/styles.css ./src/styles2.css
Module not found: Error: Can't resolve '/private/tmp/cool-app/src/styles2.css' in '/private/tmp/cool-app'
 @ multi ./src/styles.css ./src/styles2.css

After adding an empty src/styles2.css, everybody wins.
In short, the implementation works as expected, you got to feed it the correct config/data.

Closing this as working as intended after @catull comment.


Could you please provide a simple example of how to push a local video file

能否提供一个本地视频文件推流的示例
Could you please provide a simple example of how to push a local video file
Hello,
There's a mov video file in the sandbox copied from system photo. Could you show me a simple example to push this video to smtp server please?
And i'm new to video process. The following code was found by internet, but will crash when run a few seconds.  Also, how to set the rtmp url when using [self.session pushVideo:pixelBuffer] to push video file other than [self.session startLive:stream]?
Very appreciate if someone could help me!
`
(void)startByVideoFile:(NSString*) filename {
NSError *error=[[NSError alloc]init];

/* construct an AVAssetReader based on an file based URL */
NSURL *movieUrl=[[NSURL alloc] initFileURLWithPath:filename];
AVURLAsset *movieAsset=[[AVURLAsset alloc] initWithURL:movieUrl options:nil];

/* determine image dimensions of images stored in movie asset */
CGSize size=[movieAsset naturalSize];
NSLog(@"movie asset natual size: size.width=%f size.height=%f",
size.width, size.height);

/* allocate assetReader */
AVAssetReader *assetReader=[[AVAssetReader alloc] initWithAsset:movieAsset
error:&error];

/* get video track(s) from movie asset */
NSArray *videoTracks=[movieAsset tracksWithMediaType:AVMediaTypeVideo];

/* get first video track, if there is any */
AVAssetTrack *videoTrack0=[videoTracks objectAtIndex:0];

/* set the desired video frame format into attribute dictionary /
NSMutableDictionary dictionary=[NSMutableDictionary dictionaryWithObjectsAndKeys:
[NSNumber numberWithInt:kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange],
(NSString*)kCVPixelBufferPixelFormatTypeKey,
nil];

/* construct the actual track output and add it to the asset reader /
AVAssetReaderTrackOutput assetReaderOutput=[[AVAssetReaderTrackOutput alloc]
initWithTrack:videoTrack0
outputSettings:dictionary]; //nil or dictionary
/* main parser loop */
NSInteger i=0;
if([assetReader canAddOutput:assetReaderOutput]){
[assetReader addOutput:assetReaderOutput];

  NSLog(@"asset added to output.");

  /* start asset reader */
  if([assetReader startReading]==YES){
      /* read off the samples */
      CMSampleBufferRef buffer;
      while([assetReader status]==AVAssetReaderStatusReading){
          buffer=[assetReaderOutput copyNextSampleBuffer];
          i++;
          NSLog(@"decoding frame #%ld done.", i);

          CVPixelBufferRef pixelBuffer =CMSampleBufferGetImageBuffer(buffer);
          [self.session pushVideo:pixelBuffer];

          usleep(1000*100.0);
      }
  }
  else {
      NSLog(@"could not start reading asset.");
      NSLog(@"reader status: %ld", [assetReader status]);
  }
}
else {
NSLog(@"could not add asset to output.");
}
}

`

Did you solve your issue ?

I'm wondering if anyone ever found a solution for this, please? I'm using a Swift version of the code above, pushing the video using pushVideo, however the video (although the frames seem to be loading in the background) do not get pushed to the stream.


feat(openscd): Move progress indicator beneath plugin tabs

Closes #1178.
Unfortunately, the buttons and the title already overlap in the mobile view, which means the progress indicator on a small mobile screen will hover in the centre of the screen.
This is not ideal, but I can't think of a better location, and would be willing to live with myself over this...

Otherwise I quite like it:

This especially bothered me on the subscriber plugins where I was constantly carrying out an action, near the centre of the screen and found the progress indicator distracting and overpowering.
As always a review would be appreciated as CSS has been carefully designed to impart humility and there is no reason why I should be exempt.
I wonder if this is inadequate -- I'm not sure how CoMPAS downstream integrates or consumes open-scd, I know it's top bar is different. Perhaps this needs to be slotted somewhere?

After our discussion at a recent refinement I'll look into other options to improve compatibility with CoMPAS.

I first tried to put the progress bar under the filename. Can be done but impossible to style with mwc linear progress out of the box (it seems to me) as I can apply suitable overrides.
So I thought why don't I put it just below the tab bar and have it occupy the full width? Not perfect but better. I've decreased the opacity to make it less visually intrusive.
I wanted to avoid the progress bar being on top of the menu if a validation action is triggered from a menu action.
So I made it close the menu always. This is, I hope a general improvement and works nicely except that the menu plugin, "Show SCL History" goes into an infinite update loop and never opens. I may need some help with why this occurs (how odd?!)

@ca-d, is there anything I can do to move this along?

Thank you for this review, I have merged to main and cleaned up the package.

Thanks for the review!


Complete Wireless Feature (No any physical cable from PC to Phone hence no USB) available on Android 11+

I have NOT checked that a similar suggestion exists. I'm not yet used to Github and I see it's too tedious.
Is your feature request related to a problem? Please describe.
My phone got a fried USB C port. Only charging seems fine, so I made a complete wireless method to use scrcpy.
Describe the solution you'd like
My method:
Used Android 11 Wireless ADB feature then restarted the adbd on a TCP port using the command "adb tcpip x" (x = any port).
The desired solution: might be or not a feature but it might be good to add this in the tutorials section.
Additional context
Well, the implications are:
The device must have a wireless adb feature like the one added on the Android version 11.
ADB versions may vary, must download the compatible adb version to use the wireless adb feature ( I used SDK Platform-Tools)
References
Android Wireless Adb:
https://developer.android.com/studio/command-line/adb
SDK Platform-Tools:
https://developer.android.com/studio/releases/platform-tools

IIRC wireless debugging was already in android 5

As far as i know, yes, just as stated in the instruction where you can restart adb daemon (the background process or the adb server) after connecting to it physically or you can turn it on with root privilege, the first one though isn't actually total wireless debugging, as of my case of burnt port I cannot use it, the second one is, surprisingly for me, a total wireless debuging feature (I'm going to add that later in my feature request), until the release of Android 11, total wireless ADB debugging was supported in the AOSP and can be used on user builds. Check the link I referenced concerning it.

Fun fact, use mobile or computer hotspot when using the feature mentioned (Wireless adb debugging), the network interface that probably going to be used is faster. Mine can reach the speed of 140 Mbps. I also discovered an exploit where I can local adb on the phone ( no root  and pc, just the phone to used adb on), its an exploit of the Android 11 Wireless debugging feature.


Port cargo to clap3

What does this PR try to resolve?
This moves cargo to the latest major version of clap.
This supersedes #10259  and #10262
How should we test and review this PR?
For testing, I mostly relied on existing tests.  I did manually validate that cargo run <non-escaped command args> behaved the same between both
$ cargo run release --help
    Finished dev [unoptimized + debuginfo] target(s) in 0.22s
     Running `target/debug/cargo-release release --help`
cargo-release 0.18.8
...

$ cargo run --manifest-path ../cargo/Cargo.toml -- run release --help
    Finished dev [unoptimized + debuginfo] target(s) in 0.05s
     Running `/home/epage/src/personal/cargo/target/debug/cargo run release --help`
    Finished dev [unoptimized + debuginfo] target(s) in 1.31s
     Running `target/debug/cargo-release release --help`
cargo-release 0.18.8
...

For reviewing, I split out each deprecation resolution into a separate commit so its easy to focus on more mechanical changes (most of the deprecation fixes) from interesting ones (the port, the Arg::multiple deprecation)
Additional information

One parser change found by cargo_config::includes is that clap 2
would ignore any values after a = for flags.
cargo config --show-origin is a flag but the test passed --show-origin=yes which
happens to give the desired result for that test but is the same as
--show-origin=no or --show-origin=alien-invasion.
ArgMatches now panics when accessing an undefined argument but clap
takes advantage of that for sharing code across commands that have
different subsets of arguments defined.  I've extended clap so we can
"look before you leap" and put the checks at the argument calls to
start off with so its very clear what is tenuously shared.  This
allows us to go in either direction in the future, either addressing
how we are sharing between commands or by moving this down into the
extension methods and pretending this clap feature doesn't exist
On that topic, a test found clap-rs/clap#3263.  For now, there is a
hack in clap.  Depending on how we fix that in clap for clap 4.0, we
might need to re-address things in cargo.
value_of_os now requires setting allow_invalid_utf8, otherwise it
asserts.  To help catch this, I updated the argument definitions
associated with lookups reported by:

rg 'values?_os' src/
rg 'values?_of_os' src/

clap now reports 2 for usage errors, so we had to bypass clap's
exit call to keep the same exit code.
cargo vendor --sync did not use multi_opt and so it has both
multiple occurrences and multiple values.  If we want to deprecate
this, we'll need unstable-grouped to be stablized (or pin our clap
version) and ensure each group has only 1 value.

r? @alexcrichton
(rust-highfive has picked a reviewer for you, use r? to override)

@ehuss as the original porter to clap (IIRC) would you be up for reviewing this? For me to review this I feel like I'd have to build up a more-complete understanding of clap2, then clap3, then look at this diff, which at least for me would take a significant amount of time.

I think that was matklad.  I can review it, but it may take a while.

Ah ok no that's my mistake. I'll try to get to this at some point. I can't commit to a particular point in time right now though.

r? @joshtriplett

I pulled this down locally, reviewed it in detail, and built it to run various tests. Seems to work exactly as expected, and the code changes look good to me.
I also appreciated the incremental approach here of first doing the minimal port, then migrating away from the deprecated functions one by one.
@bors r+

:pushpin: Commit 92fa72d48023602952182d9e6e6cc253d74ddc94 has been approved by joshtriplett

:hourglass: Testing commit 92fa72d48023602952182d9e6e6cc253d74ddc94 with merge b81ca081d3e901d0cb01abd13af66c8ff5dc1bbf...

:broken_heart: Test failed - checks-actions

@bors retry
The runner has received a shutdown signal.   Dunno why that happened.

:hourglass: Testing commit 92fa72d48023602952182d9e6e6cc253d74ddc94 with merge 06b9d31743210b788b130c8a484c2838afa6fc27...

:sunny: Test successful - checks-actions
Approved by: joshtriplett
Pushing 06b9d31743210b788b130c8a484c2838afa6fc27 to master...


Bot is "crawling". Moving .3m/min to 1m/min. very slow walk.

JSON validated- Valid JSON
yes, i did search issues, did not find current behavior recently for dev.
Issue occurs for me with current dev. I reverted to e43f8f9 and issue still occurs.
Expected Behavior

Trainer to walk 3.22km/h to 4.14km/h
Actual Behavior

Trainer walking only 0.3m/min to 1m/minute, walking VERY slowly.
Your FULL config.json (remove your username, password, gmapkey and any other private info)

issue solved, removing config.
Output when issue occurred

Steps to Reproduce

Other Information
OS: Windows 8.1

Branch: current dev (and e43f8f9 to test as it was working for me last, still same issue)

Git Commit: current and e43f8f98985de8d1bc254f0c04b2b4068101c879

Python Version: 2.1.12 32bit

Any other relevant files/configs (eg: path files)

It seems that skip ignore is taking a lot of time.... but even when there are not pokemon being ignored the bot still moves very slowly.

Same issue here, disable the TelegramTask to fix the speed to normal. I expect there is a bug in the Telegram code :).

@davidspeijer thank you very much! disabled TelegramTask and everything is back to normal!

Perhaps it should remain open as it appears it is an issue with the telegram task?


Create language_in-id.properties

Create a new property in Indonesian language

Thank you for your translation!

Hi, as it is another translation from Indonesian, if you will not resolve conflicts today, I will have to close this PR :(

Hi, my apology for the late reply
It's ok if you close the PR, as I already checked the file in-id.properties
before me, and it is nearly the same with my translation. So it's ok
Thank you
__
Samuel Sibuea
Pada tanggal Min, 2 Okt 2022 pukul 19.59 Adrian Goral <
@.***> menulis:

Hi, as it is another translation from Indonesian, if you will not resolve
conflicts today, I will have to close this PR :(
—
Reply to this email directly, view it on GitHub
https://github.com/xEdziu/KeepMyPassword-Desktop/pull/97#issuecomment-1264637871,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU2ONG63JXGTK5TCSNTDLX3WBGBLBANCNFSM6AAAAAAQ2JKUVM
.
You are receiving this because you were assigned.Message ID:
@.***>

Okay, thank you for your answer!


The example should probably switch to psc and make psa optional, or make external dependencies more clear

Currently, if there is no purescript-psa installed, then the example fails with a very ambiguous error:
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: spawn psaa ENOENT
    at exports._errnoException (util.js:1026:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
    at onErrorNT (internal/child_process.js:359:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

This is going to be very discouraging for anybody who wants to quickly try purs-loader and purescript with webpack. On purs-loader page, it mentions quickly that it uses purescript-psa, but I think it's a good idea to make the example repository as fail-safe as possible and mention it loudly here as well.
My suggestion is to list every external dependency clearly upfront in the README.md. If I'm not missing anything, this consists of purescript-psa (psa) and purescript (psc), nodejs (node), webpack (webpack). I have specified their CLI names in brackets to that it's easier to verify whether each one exists by running --version on each of them. I can create a PL later.

I think it is a great idea to be explicit about all of the dependencies. Putting this in the README would be a welcome addition. In terms of not having psa installed, shouldn't it be installed when the user runs npm install? I just want to make sure I understand how to reproduce the issue you had. Thanks!

No it's not installed. In my understanding, npm install does not install packages globally. You would need npm install -g purescript-psa for that. I'm on Nix, where it wouldn't allow npm command to install anything globally to begin with and since npm install runs without errors this means it alters only local packages, the ones that don't get added to $PATH.

I would try npm uninstall -g purescript-psa and then npm install again to test whether there was purescript-psa installed globally and to reproduce the issue.

Right, the npm install would not install anything globally. But it should install psa locally in node_modules/.bin, and this is what the purs-loader expects. It should take the binaries in node_modules/.bin first when running webpack through npm. In the README it suggests npm start or npm run webpack:server. I believe this should pick up the local install of psa. Let me know if this works for you.

You're right npm run webpack:server works without global purescript-psa. npm start, on the other hand, outputs:

Glad it works! Note that for npm start, all steps are required as mentioned in the readme.
bower install

npm install

npm run webpack

npm start

Yeah, for npm start it's probably because npm run webpack failed and I tried doing it the other way. It failed like this:
>>> npm run webpack
><EMAIL_ADDRESS>webpack /tmp/purescript-webpack-example
> DEBUG=purs-loader webpack --progress --bail
                                                                                10% 0/1 build modules  purs-loader loader called Example +0ms
  purs-loader spawning compiler psa [ '--output=output', 'bower_components/purescript-*/src/**/*.purs', 'src/**/*.purs' ] +2ms
  purs-loader compiling PureScript... +4ms
  purs-loader finished compiling PureScript. +309ms
ModuleBuildError: Module build failed: Error: compilation failed
    at ChildProcess.<anonymous> (/tmp/purescript-webpack-example/node_modules/purs-loader/lib/Psc.js:48:16)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:877:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
    at DependenciesBlock.onModuleBuildFailed (/tmp/purescript-webpack-example/node_modules/webpack-core/lib/NormalModuleMixin.js:315:19)
    at nextLoader (/tmp/purescript-webpack-example/node_modules/webpack-core/lib/NormalModuleMixin.js:270:31)
    at /tmp/purescript-webpack-example/node_modules/webpack-core/lib/NormalModuleMixin.js:292:15
    at context.callback (/tmp/purescript-webpack-example/node_modules/webpack-core/lib/NormalModuleMixin.js:148:14)
    at Object.reject (/tmp/purescript-webpack-example/node_modules/purs-loader/lib/index.js:116:14)
    at /tmp/purescript-webpack-example/node_modules/purs-loader/lib/index.js:165:25
    at tryCatcher (/tmp/purescript-webpack-example/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/tmp/purescript-webpack-example/node_modules/bluebird/js/release/promise.js:510:31)
    at Promise._settlePromise (/tmp/purescript-webpack-example/node_modules/bluebird/js/release/promise.js:567:18)
    at Promise._settlePromise0 (/tmp/purescript-webpack-example/node_modules/bluebird/js/release/promise.js:612:10)
    at Promise._settlePromises (/tmp/purescript-webpack-example/node_modules/bluebird/js/release/promise.js:687:18)
    at Async._drainQueue (/tmp/purescript-webpack-example/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/tmp/purescript-webpack-example/node_modules/bluebird/js/release/async.js:143:10)
    at Immediate.Async.drainQueues (/tmp/purescript-webpack-example/node_modules/bluebird/js/release/async.js:17:14)
    at runCallback (timers.js:637:20)
    at tryOnImmediate (timers.js:610:5)
    at processImmediate [as _immediateCallback] (timers.js:582:5)

npm ERR! Linux 4.4.35
npm ERR! argv "/nix/store/9ps69qzr5x9szkdk81gviyr9mck51nzn-nodejs-6.9.1/bin/node" "/home/jon/.nix-profile/bin/npm" "run" "webpack"
npm ERR! node v6.9.1
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>webpack: `DEBUG=purs-loader webpack --progress --bail`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>webpack script 'DEBUG=purs-loader webpack --progress --bail'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the purescript-webpack-example package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     DEBUG=purs-loader webpack --progress --bail
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs purescript-webpack-example
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls purescript-webpack-example
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /tmp/purescript-webpack-example/npm-debug.log

Anyway, there is something strange going on because it occasionally fails and occasionally not, even with npm run webpack:server. By occasionally, I mean if you use it for a while and run npm install, etc, not between individual runs. I found that the most reliable way is by running webpack and webpack --watch and having everything globally (purescript-psa and webpack), at least it's this way on Nix.
>>> npm run webpack:server

><EMAIL_ADDRESS>webpack:server /tmp/purescript-webpack-example
> webpack-dev-server --progress --inline --hot
                                                                              70% 1/1 build modules http://localhost:4008/
webpack result is served from /
content is served from .
ERROR in ./src/Example.purs
Module build failed: Error: compilation failed
    at ChildProcess.<anonymous> (/tmp/purescript-webpack-example/node_modules/purs-loader/lib/Psc.js:48:16)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:877:16)
    at Socket.<anonymous> (internal/child_process.js:334:11)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at Pipe._handle.close [as _onclose] (net.js:498:12)
 @ multi main

ERROR in events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: spawn /tmp/purescript-webpack-example/node_modules/purescript/vendor/psc ENOENT
    at exports._errnoException (util.js:1026:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
    at onErrorNT (internal/child_process.js:359:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
    at Module.runMain (module.js:606:11)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:509:3

Thanks for reporting this. I haven't tried it on Nix. I am not quite sure what is going on. Do you think it is related to the purs-loader or how npm is installing dependencies?

purs-loader works perfectly with webpack and webpack --watch.
I think I figured out what was causing this. This appears to be Nix related. Basically, npm puts the binary in "/tmp/purescript-webpack-example/node_modules/purescript/vendor/psc", then something tries to spawn the process, after all, it obviously needs psc compiler to compile. However, that binary dynamically links /lib64/ld-linux-x86-64.so.2 that does not exist on this system:
> cd /tmp/purescript-webpack-example/node_modules/purescript/vendor/
> file ./psc
./psc: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.24, BuildID[sha1]=d699fdefc2052263c93221500933c7431782f73a, stripped

Normally, Nix would patch it and provide another path to the library as seen here, when psc is installed through Nix:
> pwd
/nix/store/ilmpr6p1yga5sk3sqg5xhqwsbn301n7k-purescript-0.10.7/bin
> file ./psc
./psc: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /nix/store/amjgskg17wv125v9kahqdfxh8sx6mxgp-glibc-2.24/lib/ld-linux-x86-64.so.2, for GNU/Linux 2.6.32, stripped

In npm's case, if you even call ./psc from shell, it will output that file or directory does not exist. Not because the binary itself does not exist there, but because it links something that does not exist. It's very confusing and Linux should provide a clearer error in this case, IMO. When spawn called, it gets the same error that file does not exists and outputs the error as if psc does not exist there, which is not true.

Great! Glad that you got this working. Do you think we should say anything about this in the troubleshooting section in the purs-loader README?

Yeah, probably. I think Nix usage among Purescript crowd will be higher than other JS transpilers, based on similarities in philosophy.

Would you be willing to write up a short description of how you fixed this?
On Sat, Feb 25, 2017 at 10:55 cyrbon<EMAIL_ADDRESS>wrote:

Yeah, probably. I think Nix usage among Purescript crowd will be higher
than other JS transpilers, based on similarities in philosophy.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ethul/purescript-webpack-example/issues/5#issuecomment-282492616,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVYy0ofEA9OI1NE4rbJI-d88yP0-_xnks5rgE7qgaJpZM4MMBt4
.

Of course. I'll create a pull request soon.

Thanks!
On Sat, Feb 25, 2017 at 10:58 cyrbon<EMAIL_ADDRESS>wrote:

Of course. I'll create a pull request soon.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ethul/purescript-webpack-example/issues/5#issuecomment-282492787,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVYyxzhiN00VDepY_MgUZr2jsmOQDN0ks5rgE-UgaJpZM4MMBt4
.


[#108] Submit issue instead of Contact Support

Closes https://github.com/ArchGPT/insomnium/issues/108
As @Fearvel pointed out, Insomnium shouldn't point users at Kong's support since they don't actually support it! Switching the button to read "Submit an Issue" and pointing it at this part of the README
Left the "Documentation" button alone.

ooh thanks nice catch!!


Drop support for EOL Python 2.6 & 3.3, add support for 3.6

Fixes #325.
PS It's great to see a  Music Hack Day hack live beyond the hack day!

I'm not sure of the merit of deliberately making it not compatible with old Python version - I don't see any plus side - I thing the original was about not worrying for additions moving forward. (Which I do sort of see the point of). Deliberately changing existing code so that it won't work on older python version (without giving any real user feature benefit) seems like the wrong way to go for me.

You get a cleaner codebase, less burden to support old versions which hardly anybody uses, no need to maintain clunky old code, and you can start to use new and modern features of Python. People can install an old version of SoCo if needed.
Here's the pip installs for SoCo from PyPI for the last month, supporting a drop of 2.6 and 3.3:
$ pypinfo --percent --pip soco pyversion
python_version percent download_count
-------------- ------- --------------
3.5              37.2%            823
3.6              29.0%            641
2.7              17.0%            377
3.4              15.3%            338
3.3               1.5%             33
2.6               0.0%              1

If you're not testing it, there's not much point maintaining it. Look to the future!
Having said that, if you prefer I can update this to retain the old code and just change the Travis config, docs and classifiers.

If we drop support for 2.6 we should use this to clean up the codebase.
If we would not do this right now, we would still introduce incompatible changes but would not take the chance to clean up properly.

Look to the future!

+1

Has this PR be superseeded by the others?

It has, let's close this one.


Handle the offset for the end of a three-piece comment ignored

:help format-comments mentions that it is possible to specify an offset for the
end of a three-piece comment:

  {digits}
    When together with 's' or 'e': add {digit} amount of offset to an
    automatically inserted middle or end comment leader. The offset begins
    from a left alignment. See below for more details.

  -{digits}
    Like {digits} but reduce the indent.  This only works when there is
    some indent for the start or end part that can be removed.

This seems to have never been implemented. If you are interested in
implementing the feature, I made a small first step: I modified insertchar() in
edit.c so that the closing part is correctly indented (with the offset) when
the auto-close comment functionality is triggered but:
• my solution uses spaces – it does not take into account the value of
  'et', 'ts', etc.,
• get_c_indent() does not handle the offset setting.

If you decide to implement this, at least the settings mentioned above will
have to be considered (perhaps other as well).

You might have a look at the attached patch (against Vim 7.3.189) if you'd like
a pointer to where to start. Also have a look at open_line().

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 15 May 2011 at 10:34
Attachments:

three-piece-comment-end-offset.patch

I appear to run into this issue. :set comments=sr:/***,m:**,ex-2:******/, an example from vim's own help, doesn't work as the help shows what it is supposed to do. Wondering if this issue is fixed and just not closed? or it is still there.

I had to search the help to find this. It appears to be at :h format-comments and scroll down by a page.
However, as you say, this doesn't seem to work as documented, so this issue shouldn't be closed I guess?

Oh wait, I was just testing using vim --clean -c ':set comments=sr:/***,m:**,ex-2:******/' foobar.c (tested with a C file so that indenting and formatting options are set from the filetype plugin)
And it seems to work as expected. So perhaps we can actually close this?

Sad, it doesn't work for me with your command.
Some other thoughts. Even we can prove it is fixed. I still think it is an issue. This thing, the offset for the end comment string, is pretty tricky. I don't think the --clean is an option for daily use. Does it mean it will hardly work once user applies any personal config? If it is true, if it doesn't work for most of times, then what's the point of this thing to exist?

no --clean is simply there to reproduce this with minimal vimrc settings. To allow us to track down problems, rule out custom vimrc settings and write easier tests.

Yes, I know what the --clean does. What I am saying is, apparently, you got different results, with and without the --clean. We might not be good just because it works with --clean option. We wants it to work without --clean option.

yes, it may depend on the what other files are sourced. You did not mention what version of vim you used. Perhaps it did not source those filetype plugins for c files?

I tried your command one more time on three different distributions, in case that different distro has different default config for vim. None worked.
Here are their version info and the result of :scriptnames
$ vim --version
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Oct 12 2021 05:55:28)
Included patches: 1-3428
Modified by Gentoo-8.2.3428-r1
Compiled by ...@localhost
Huge version without GUI.    Features included (+) or not (-):
+acl               +file_in_path      +mouse_urxvt       -tag_any_white
+arabic            +find_in_path      +mouse_xterm       -tcl
+autocmd           +float             +multi_byte        +termguicolors
+autochdir         +folding           +multi_lang        +terminal
-autoservername    -footer            -mzscheme          +terminfo
-balloon_eval      +fork()            +netbeans_intg     +termresponse
+balloon_eval_term -gettext           +num64             +textobjects
-browse            -hangul_input      +packages          +textprop
++builtin_terms    +iconv             +path_extra        +timers
+byte_offset       +insert_expand     -perl              +title
+channel           +ipv6              +persistent_undo   -toolbar
+cindent           +job               +popupwin          +user_commands
-clientserver      +jumplist          +postscript        +vartabs
-clipboard         +keymap            +printer           +vertsplit
+cmdline_compl     +lambda            +profile           +vim9script
+cmdline_hist      +langmap           -python            +viminfo
+cmdline_info      +libcall           +python3/dyn       +virtualedit
+comments          +linebreak         +quickfix          +visual
+conceal           +lispindent        +reltime           +visualextra
+cryptv            +listcmds          +rightleft         +vreplace
+cscope            +localmap          -ruby              +wildignore
+cursorbind        +lua               +scrollbind        +wildmenu
+cursorshape       +menu              +signs             +windows
+dialog_con        +mksession         +smartindent       +writebackup
+diff              +modify_fname      -sodium            -X11
+digraphs          +mouse             -sound             -xfontset
-dnd               -mouseshape        +spell             -xim
-ebcdic            +mouse_dec         +startuptime       -xpm
+emacs_tags        -mouse_gpm         +statusline        -xsmp
+eval              -mouse_jsbterm     -sun_workshop      -xterm_clipboard
+ex_extra          +mouse_netterm     +syntax            -xterm_save
+extra_search      +mouse_sgr         +tag_binary
-farsi             -mouse_sysmouse    -tag_old_static
   system vimrc file: "/etc/vim/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -Os -fomit-frame-pointer -Os -fomit-frame-pointer -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc -L/usr/local/lib -Wl,--as-needed -o vim -lm -lncurses -L/usr/lua5.3/lib -llua

# vim --clean a.c
:scriptnames
  1: /usr/share/vim/vim82/defaults.vim
  2: /usr/share/vim/vim82/filetype.vim
  3: /usr/share/vim/vim82/ftplugin.vim
  4: /usr/share/vim/vim82/indent.vim
  5: /usr/share/vim/vim82/autoload/dist/ft.vim
  6: /usr/share/vim/vim82/ftplugin/c.vim
  7: /usr/share/vim/vim82/indent/c.vim

$ vim --version
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Dec 25 2021 11:17:40)
Included patches: 1-3890
Compiled by Arch Linux
Huge version without GUI.  Features included (+) or not (-):
+acl               +file_in_path      +mouse_urxvt       -tag_any_white
+arabic            +find_in_path      +mouse_xterm       +tcl/dyn
+autocmd           +float             +multi_byte        +termguicolors
+autochdir         +folding           +multi_lang        +terminal
-autoservername    -footer            -mzscheme          +terminfo
-balloon_eval      +fork()            +netbeans_intg     +termresponse
+balloon_eval_term +gettext           +num64             +textobjects
-browse            -hangul_input      +packages          +textprop
++builtin_terms    +iconv             +path_extra        +timers
+byte_offset       +insert_expand     +perl/dyn          +title
+channel           +ipv6              +persistent_undo   -toolbar
+cindent           +job               +popupwin          +user_commands
-clientserver      +jumplist          +postscript        +vartabs
-clipboard         +keymap            +printer           +vertsplit
+cmdline_compl     +lambda            +profile           +virtualedit
+cmdline_hist      +langmap           +python/dyn        +visual
+cmdline_info      +libcall           +python3/dyn       +visualextra
+comments          +linebreak         +quickfix          +viminfo
+conceal           +lispindent        +reltime           +vreplace
+cryptv            +listcmds          +rightleft         +wildignore
+cscope            +localmap          +ruby/dyn          +wildmenu
+cursorbind        +lua/dyn           +scrollbind        +windows
+cursorshape       +menu              +signs             +writebackup
+dialog_con        +mksession         +smartindent       -X11
+diff              +modify_fname      -sodium            -xfontset
+digraphs          +mouse             -sound             -xim
-dnd               -mouseshape        +spell             -xpm
-ebcdic            +mouse_dec         +startuptime       -xsmp
+emacs_tags        +mouse_gpm         +statusline        -xterm_clipboard
+eval              -mouse_jsbterm     -sun_workshop      -xterm_save
+ex_extra          +mouse_netterm     +syntax
+extra_search      +mouse_sgr         +tag_binary
-farsi             -mouse_sysmouse    -tag_old_static
   system vimrc file: "/etc/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -flto -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc -L. -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -fstack-protector-strong -rdynamic -Wl,-export-dynamic -Wl,-E -Wl,-rpath,/usr/lib/perl5/5.34/core_perl/CORE -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -L/usr/local/lib -o vim -lm -ltinfo -lelf -lacl -lattr -lgpm -ldl -Wl,-E -Wl,-rpath,/usr/lib/perl5/5.34/core_perl/CORE -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -fstack-protector-strong -L/usr/local/lib -L/usr/lib/perl5/5.34/core_perl/CORE -lperl -lpthread -ldl -lm -lcrypt -lutil -lc -L/usr/lib -ltclstub8.6 -ldl -lz -lpthread -lm

$ vim --clean a.c
:scriptnames
  1: /usr/share/vim/vim82/defaults.vim
  2: /usr/share/vim/vim82/filetype.vim
  3: /usr/share/vim/vimfiles/ftdetect/PKGBUILD.vim
  4: /usr/share/vim/vimfiles/ftdetect/espeakfiletype.vim
  5: /usr/share/vim/vimfiles/ftdetect/meson.vim
  6: /usr/share/vim/vimfiles/ftdetect/nginx.vim
  7: /usr/share/vim/vimfiles/ftdetect/vagrantfile.vim
  8: /usr/share/vim/vim82/ftplugin.vim
  9: /usr/share/vim/vim82/indent.vim
 10: /usr/share/vim/vim82/syntax/syntax.vim
 11: /usr/share/vim/vim82/syntax/synload.vim
 12: /usr/share/vim/vim82/syntax/syncolor.vim
 13: /usr/share/vim/vim82/colors/lists/default.vim
 14: /usr/share/vim/vim82/autoload/dist/ft.vim
 15: /usr/share/vim/vim82/ftplugin/c.vim
 16: /usr/share/vim/vim82/indent/c.vim
 17: /usr/share/vim/vim82/syntax/c.vim

Okay here is a screen recording I did:
https://user-images.githubusercontent.com/244927/164406759-5be89f20-3e52-4bee-a5f6-b489230c216c.mp4
That is basically following what has been documented at :h format-comments

Here is an example of alignment flags at work to make a comment stand out
(kind of looks like a 1 too). Consider comment string:

         :set comments=sr:[/](https://vimhelp.org/pattern.txt.html#%2F)***,m:**,ex-2:******/

                                    /***
                                      **<--right aligned from "r" flag
                                      **
 offset 2 spaces for the "-2" flag--->**
                                    ******/

In this case, the first comment was typed, then return was pressed 4 times,
then "/" was pressed to end the comment.

However I just noticed the end-of-comment part was not un-indented. Perhaps this is actually the issue?

so the issue is still there. Why did you initially say this has been solved then?

Wondering if this issue is fixed and just not closed

Wondering if this issue is fixed and just not closed? or it is still there.

I was asking. I just want to confirm if it is my fault (conflict settings?) or vim's fault.

I was asking. I just want to confirm if it is my fault (conflict settings?) or vim's fault.

fair enough. I wasn't really aware of the complexity of the comments options and it looks like no-one was interested in fixing this for at least 7 years. So that explains why it is still open.


handle failure to load cluster in CLI more gracefully

#1550  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Circle Component

Circle

Introduced a new React component, Circle, to create circles on maps provided by HERE Maps.
Encapsulate the Circle behaviour from the HERE Maps API, but not that of the other provided Geoshapes.
Component is used as a child of a HEREMap component.
Component simply creates a circle of the given radius at the given location.

Automatic Position Changes of Circle and Marker instances

When the lat/lng props of a Circle or Marker instance change, their position automatically changes.
When the rad prop of a Circle instance changes, the radius automatically changes to the new value.

Coverage decreased (-1.3%) to 94.33% when pulling 7b3ea5ff10fd9317617102c3d6f4ec2e2049fe85 on circle into 25b6eb83c25e9527123b0a09b1062ba21a44a7fb on master.

Coverage decreased (-3.3%) to 92.377% when pulling ca9d1676af1c356bb4678a4b47ff5900bb854be2 on circle into 25b6eb83c25e9527123b0a09b1062ba21a44a7fb on master.

Coverage decreased (-3.3%) to 92.377% when pulling ca9d1676af1c356bb4678a4b47ff5900bb854be2 on circle into 25b6eb83c25e9527123b0a09b1062ba21a44a7fb on master.

Coverage decreased (-3.3%) to 92.377% when pulling 20a833edaf47d675fd367cdd550f14ba18d94d93 on circle into 25b6eb83c25e9527123b0a09b1062ba21a44a7fb on master.

Coverage increased (+1.9%) to 97.549% when pulling 40b602c1444cca684c13f95c857a72a7d53aeb44 on circle into 25b6eb83c25e9527123b0a09b1062ba21a44a7fb on master.

Coverage increased (+1.9%) to 97.549% when pulling 40b602c1444cca684c13f95c857a72a7d53aeb44 on circle into 25b6eb83c25e9527123b0a09b1062ba21a44a7fb on master.

Coverage increased (+1.9%) to 97.549% when pulling 40b602c1444cca684c13f95c857a72a7d53aeb44 on circle into 25b6eb83c25e9527123b0a09b1062ba21a44a7fb on master.

Coverage increased (+1.9%) to 97.549% when pulling 5d25065b0a47748beba1136de1f76b1243655ccf on circle into 25b6eb83c25e9527123b0a09b1062ba21a44a7fb on master.

Coverage increased (+1.9%) to 97.549% when pulling 5d25065b0a47748beba1136de1f76b1243655ccf on circle into 25b6eb83c25e9527123b0a09b1062ba21a44a7fb on master.

Coverage increased (+1.9%) to 97.549% when pulling 8f5088e034119f180fe3f4ba054a429e85e23a33 on circle into 25b6eb83c25e9527123b0a09b1062ba21a44a7fb on master.


Installing any libcontainer related software (runc, podman, cri-o) bricks nixos-container

Describe the bug
NixOS Containers expect /etc/containers to be used by it. but this is a directory that is used by libcontainer-compatible systems like podman. More specifically it creates a file /etc/containers/registries.conf
nixos-container.pl then hard-crashes as it expects its own *.conf files to live there on the following line: https://github.com/NixOS/nixpkgs/blob/a0a3f5c86ce04a820035855a081d3acb7f353201/pkgs/tools/virtualization/nixos-container/nixos-container.pl#L153  but that file but it dies instead
To Reproduce
Install something libcontainer-y and use it
nixos-container is now broken
Expected behavior
nixos-container should not namesquat /etc/containers
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

Not stale. Still extremely relevant.
On Wed, Jul 15, 2020, 20:49 stale[bot]<EMAIL_ADDRESS>wrote:

Hello, I'm a bot and I thank you in the name of the community for opening
this issue.
To help our human contributors focus on the most-relevant reports, I check
up on old issues to see if they're still relevant. This issue has had no
activity for 180 days, and so I marked it as stale, but you can rest
assured it will never be closed by a non-human.
The community would appreciate your effort in checking if the issue is
still valid. If it isn't, please close it.
If the issue persists, and you'd like to remove the stale label, you
simply need to leave a comment. Your comment can be as simple as "still
important to me". If you'd like it to get more attention, you can ask for
help by searching for maintainers and people that previously touched
related code and @ mention them in a comment. You can use Git blame
https://git-scm.com/docs/git-blame or GitHub's web interface
https://docs.github.com/en/github/managing-files-in-a-repository/tracking-changes-in-a-file
on the relevant files to find them.
Lastly, you can always ask for help at our Discourse Forum
https://discourse.nixos.org/ or at #nixos' IRC channel
https://webchat.freenode.net/#nixos.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/issues/77925#issuecomment-658940078,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEZNI4C5F2H6I75S5XP6D3R3X23FANCNFSM4KIJAPKA
.

Not stale

Not stale

Moving this to /etc/nixos/containers makes more sense to me.

Not stale

I have touched up #87268 which fixes this. PTAL.