Automated documentation creation&publishing to GH-pages

Purpose
Create GitHub actions to automatically create documentation of the pipeline and publish the created documentation on GitHub pages.
Closes #31
Items

Automate the documentation pipeline
Publish documentation to GitHub pages

Type of change

New feature (non-breaking change which adds functionality)
Repository chores (changes made to improve repository/workflow quality)
Documentation update

Checklist
Put an x in the boxes that apply.

[x] My code functions as intended
[ ] I have used camelCase in my variable and function names
[ ] I have commented my code properly
[ ] I have provided the necessary prompts for automatic documentation
[ ] I have provided a toy case under the examples folder
[x] I have addressed all the issues entirely

http://kicktv.tumblr.com/post/31814804688/emotion

@sahilbhola14 need you to have a look to confirm the behavior of the github pages, if it's producing expected behavior, we can mark this as ready to review :+1:

Great job @dorukaks.
It seems the modules are missing, i.e. the main code-base is not being documented

Great job @dorukaks. It seems the modules are missing, i.e. the main code-base is not being documented

is it normally getting created when you run it locally?

Alright Alright Alright! It's working

CAUTION: Since this PR has a lot of commits, it might be more suitable to squash while doing the merge. Let me know if help is needed :)

@dorukaks Lets merge this to main only and then freeze main. Update the dev and then start working?

Alright Alright Alright! It's working

@dorukaks Lets merge this to main only and then freeze main. Update the dev and then start working?

Allright! Once we get approvals from @camckenn @cfkawa, I'll perform a squash merge and then lock main

@sahilbhola14 I pruned @cfkawa's branches and re-run the build job, currently the documentation page looks functional. If you confirm this, we can merge to main and freeze main.

@sahilbhola14 I pruned @cfkawa's branches and re-run the build job, currently the documentation page looks functional. If you confirm this, we can merge to main and freeze main.

@dorukaks seems like it's working, we can close the PR


Display the number of pending comment on each file when reviewing

Feature Description
When reviewing, if you collapse a file you are not able to see if you have added a comment.
It should be very useful to have a pill on each file indicating the number of pending comment.
Screenshots

I wonder if checking the Viewed checkbox will serve a similar purpose.

Viewed indicates that you have checked the file not that it has no problem.
And collapsing a file is also used to not scroll over long files.
Many of my coworkers have the same usage and think that this indicator is missing

just looking for that today. having either that or a show comment button or something would be so useful with massive PR


Fix errors not showing in fleet git repo form

Summary
Fixes #12391

Occurred changes and/or fixed issues
Missed from

https://github.com/rancher/dashboard/pull/11956#issuecomment-2422936450
https://github.com/rancher/dashboard/issues/12298
https://github.com/rancher/dashboard/pull/12299

Technical notes summary
i could reproduce this in release-2.9 head
Areas or cases that should be tested
git repo create / edit with failures
given recent git repo url change though to reproduce an easy error try creating a git repo with a name of an existing one
Checklist

[x] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[x] The PR has a Milestone
[x] The PR template has been filled out
[x] The PR has been self reviewed
[x] The PR has a reviewer assigned
[x] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[x] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin I gave this another go and it looks ok. could you provide some repro steps for the failure (to show the failure)?


Add license documentation

this PR resolves #11

LGMT

After I merged to master, I missed a comment above the lines regarding the license, in the Dockerfile. Could you please add it?

Could you comment the line you are talking about in the diff of this pull request  (even if it is merge, so I can know precisely the nature of your comment for a future commit) ?


Not able to register in automatic mode

This is what the logs look like for the proxy:
2016/12/06 23:12:21 Processing request /v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&servicePath=/&distribute=true&port=8083
2016/12/06 23:12:30 Processing request /v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&servicePath=/&distribute=true&port=8083
2016/12/06 23:12:35 Processing request /v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&servicePath=/&distribute=true&port=8083
2016/12/06 23:12:40 Processing request /v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&servicePath=/&distribute=true&port=8083
2016/12/06 23:12:45 Processing request /v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&servicePath=/&distribute=true&port=8083
2016/12/06 23:12:50 Processing request /v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&servicePath=/&distribute=true&port=8083
2016/12/06 23:12:56 Processing request /v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&servicePath=/&distribute=true&port=8083
2016/12/06 23:13:01 Processing request /v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&servicePath=/&distribute=true&port=8083
2016/12/06 23:13:06 Processing request /v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&servicePath=/&distribute=true&port=8083
2016/12/06 23:13:11 Processing request /v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&servicePath=/&distribute=true&port=8083

Logging in and trying to play with the docker-flow-proxy executable, it looks a bit flaky:
/ # /usr/local/bin/docker-flow-proxy reconfigure -s app-backend_app-backend -m swarm
2016/12/06 23:23:32 Creating configuration for the service app-backend_app-backend
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x28 pc=0x401737]

goroutine 1 [running]:
panic(0x80f9e0, 0xc82000e0e0)
	/usr/local/go/src/runtime/panic.go:481 +0x3e6
main.(*Reconfigure).Execute(0xacc980, 0xc820014460, 0x0, 0x5, 0x0, 0x0)
	/usr/src/myapp/reconfigure.go:89 +0x2e7
github.com/jessevdk/go-flags.(*Parser).ParseArgs(0xc82000a240, 0xc82000a0d0, 0x5, 0x5, 0x0, 0x0, 0x0, 0x0, 0x0)
	/go/src/github.com/jessevdk/go-flags/parser.go:316 +0xa83
main.Args.Parse(0x0, 0x0)
	/usr/src/myapp/args.go:21 +0x296
main.main()
	/usr/src/myapp/main.go:4 +0x24

The swarm listener:
2016/12/06 23:09:00 Starting Docker Flow: Swarm Listener v0.6
2016/12/06 23:09:00 Starting iterations
2016/12/06 23:09:00 Sending service created notification to http://app-backend_proxy:8080/v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&servicePath=/&distribute=true&port=8083
2016/12/06 23:09:04 Sending service created notification to http://app-backend_proxy:8080/v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&distribute=true&port=8083&servicePath=/
2016/12/06 23:09:49 ERROR: Request http://app-backend_proxy:8080/v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&distribute=true&port=8083&servicePath=/ returned status code 500
{"Status":"NOK","Message":"Could not perform DNS tasks.proxy lookup","ServiceName":"app-backend_app-backend","AclName":"","ServiceColor":"","ServicePath":["/"],"ConsulTemplateFePath":"","ConsulTemplateBePath":"","PathType":"","SkipCheck":false,"Mode":"swarm","Port":"8083","Distribute":true,"Users":null}
2016/12/06 23:13:11 ERROR: Request http://app-backend_proxy:8080/v1/docker-flow-proxy/reconfigure?serviceName=app-backend_app-backend&servicePath=/&distribute=true&port=8083 returned status code 500
{"Status":"NOK","Message":"Could not perform DNS tasks.proxy lookup","ServiceName":"app-backend_app-backend","AclName":"","ServiceColor":"","ServicePath":["/"],"ConsulTemplateFePath":"","ConsulTemplateBePath":"","PathType":"","SkipCheck":false,"Mode":"swarm","Port":"8083","Distribute":true,"Users":null}

The errors look legit as they probably appear during service startup when DNS for the backend service is not available.
$ docker exec -it app-backend_swarm-listener.1.ad4p9wxi0r1pua729odvroxk7 drill app-backend_app-backend
;; ->>HEADER<<- opcode: QUERY, rcode: NOERROR, id: 48823
;; flags: qr rd ra ; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0
;; QUESTION SECTION:
;; app-backend_app-backend.		IN	A

;; ANSWER SECTION:
app-backend_app-backend.	600	IN	A	<IP_ADDRESS>

;; AUTHORITY SECTION:

;; ADDITIONAL SECTION:

;; Query time: 0 msec
;; SERVER: <IP_ADDRESS>
;; WHEN: Tue Dec  6 23:31:56 2016
;; MSG SIZE  rcvd: 80

When I proxy instance receives a request to reconfigure itself, it'll resend it to all the instances. That way, all have the same data. To do that, the proxy queries internal DNS to find the IPs of all the instances of the proxy service. By default, it assumes that the service is called proxy. You can see that from the log entry that says "Could not perform DNS tasks.proxy lookup". If the name is different (in your case app-backend_proxy, you'll need to specify that as the environment variable SERVICE_NAME. Can you please recreate the service with the -e SERVICE_NAME=app-backend_proxy.
Can you please try it out and let me know how it went.
Feel free to ping me on Skype or HangOuts. If you can share your screen, I'd be more than happy to help.

Thanks! That worked.  I've proposed an edit to the error message for this issue.  It wasn't clear to me that "task.proxy"-part of the error message was related to the name of the proxy.

Thank you


chore(devcontainer): 🧰 improvements to experience with setup directions, prebuilt tooling, and reliability

devcontainer

Include more of the tooling and dependencies initialized automatically.
Check for required storage to avoid esoteric failures when docker not allocated enough storage (set as requires 32gb for safety right now).
Handle mounted files not existing in host on windows/mac/linux without user needing to do manually.
Prebake mage/glow for better CLI launch.
Include default .zshrc with direnv loaded and a few omz settings preset for easier history usage, go autocompletions, and more.
Ensure proper default terminal.
Update golang after installing, as not picking up Go 1.19 automatically.

docs
Improve onboarding docs on how to get up and running with a devcontainer from scratch, focused on step by step.

This looks amazing!!


Alternative architecture thoughts

Curious if you've thought of a more page-centric architecture, which would group the page-specific logic with the Page, or at least outside the Router, and then the router is just concerned with declaring the structure of the tree and menu/scaffold nesting.
The main idea here is separating layout and structure, from data and logic. Parsing logic, guard logic, and the actual path are grouped together, the tree is then freed to more expressively show layout.
This is mostly just some food for thought, feel free to close if not interesting :) I've been playing with my own demos, it's becoming clear that you can kinda separate out page-specific behavior, and route management fairly cleanly.
So for example, you might have a VRouteConfig class:
class VRouteConfig {  required String path; required WidgetBuilder builder; VRouteGuard guard; }

class HomePage extends StatelessWidget {

static final routeConfig = VRouteConfig(
   path: "/home"
   builder(params) => HomePage(tabIndex: int.tryParse(params[tab]) ?? 0);
   guard: VRouteGuard(onBefore: ... )   // optional
);

The routing table could then be simplified and made more readable. The VRoute can also offer a .guard property to override the one declared with the page, but for the most part pages declare their own guards (as is common in html).
/// The router focuses entirely on expressing string mappings : route bindings and wrapping any nested widgets that are required.
VRouter(
  builder: (_, page) => page; // Can wrap entire app in scaffold/menus
  routes: [
     VRoute(HomePage.routeConfig),
     VRoute(SearchPage.routeConfig,
         builder: (_, subPage) => subPage; // could have another nested tab menu here
         children: [
             VRoute(SearchPage.routeConfig), //search
             VRoute(SearchExplorePage.routeConfig), //search/explore
             VRoute(SearchRecentPage.routeConfig), //search/recent
             VRoute(SearchNewsPage.routeConfig), //search/news
         ]
     ),
  ]
)

Or alternatively, you could declare them all as vars at the high level, then and put it all together in the router:
final homeRoute = RouteConfig(
   path: "/home"
   builder(params) => Home(int.tryParse(params[tab]) ?? 0);
);

final searchRoute = RouteConfig(
   path: "/search"
   builder(params) => SeachPage(query: params[query]));
);

final searchRouteExplore = RouteConfig(
   path: "/search/explore"
   builder(params) => SeachPage(query: params[query], selectedTab: SearchType.explore));
);

return VRouter(
  builder: (_, page) => page; // Can wrap entire app in scaffold/menus
  routes: [
     VRoute(homeRoute),
     VRoute(searchRoute,
         builder: (_, subPage) => subPage; // could have another nested tab menu here
         children: [
             VRoute(searchRoute), //search
             VRoute(searchRouteExplore ), //search/explore
             ... etc

Another variation of this would be to declare static methods for these configs, which is kind of interesting, so we could get different flavors, or override guards externally.
VRoute(SearchPage.getRouteConfig(guard: ...))); // Could override the default guard
// or maybe use a pre-made one that the page defines
VRoute(SearchPage.protectedRouteConfig);

Of course these are all implementation details that the router would not be concerned with. It doesn't care how it gets its route configs, just that it gets them. These examples are just to show the nice things you could do when we decouple at this pt.

Another interesting side effect you'd get here is really easy linking. The router could go through all PageConfig objects, and inject the the navigator.
Then you could have onPressed: () => SearchPage.route.push()
Internally PageConfig is just doing something like => _router.setPath(this.path)

Hi, thanks for taking the time to experiment and to report here what you have learned.
Concerning what you are saying, I think I see 2 main concerns:

Having a VContainer (a VRouteElement which has every configuration in it, compared to specialized VRouteElement)
How to extract the logic from VRouter in order not to have what can become a huge configuration inside it

If I am missing a concern please express it explicitly in response.
In any case, I will response to (1) and (2) above.
Concerning (1) AND (2)
I would like to have a VRouteElement, that you can extends, as you do with a StatelessWidget, which would allow you to do thing like:
class VContainer extends VRouteElement {
  final String path;
  final Widget Function(BuildContext) builder;
  final Future<void> Function(VRedirector) beforeEnter;

  VContainer({
    required this.path,
    required this.builder,
    required this.beforeEnter,
  });

  List<VRouteElement> get subRoutes => [
        VGuard(
          beforeEnter: beforeEnter,
          stackedRoutes: [
            VWidget(
              path: path,
              widget: Builder(
                builder: (context) => builder(context),
              ),
            ),
          ],
        )
      ];
}

but also (and more interestingly IMO):
// Reusable VRouteElement
class AuthenticationGuard extends VRouteElement {
  final BuildContext context;
  final VRouteElement subRoute;

  AuthenticationGuard({required this.context, required this.subRoute});

  List<VRouteElement> get subRoutes => [
        VGuard(
          beforeEnter: (vRedirector) async {
            if (!context.read<AuthenticationState>().isConnected) vRedirector.push('/login');
          },
          stackedRoutes: [subRoute],
        )
      ];
}

// VRouteElements corresponding to different routes

class LoginRoute extends VRouteElement {
  List<VRouteElement> get subRoutes => [VWidget(path: '/login', widget: LoginScreen())];
}

class HomeRoute extends VRouteElement {
  final BuildContext context;

  HomeRoute(this.context);

  List<VRouteElement> get subRoutes => [
        AuthenticationGuard(
          context: context,
          subRoute: VWidget(path: '/login', widget: LoginScreen()),
        )
      ];
}

which could then be used like so:
// Much simpler to read configuration
VRouter(
  routes: [
    LoginRoute(),
    HomeRoute(context),
  ],
)

This are simple examples but you could can imagine that some things become really easy:

Create a reusable, custom VRouteElements
Creating a VRouteElement corresponding to each of you app parts, breaking your route structure into independent, easy to manage bloc

Concerning (1): Having a VContainer (a VRouteElement which has every configuration in it, compared to specialized VRouteElement)
We have discussed this issue before, the idea of a VContainer is not attractive to me, but:

This could change as we discussed, I am still wanting for the user study result
This could be easily done by the architecture proposed above

Concerning (2): How to extract the logic from VRouter in order not to have what can become a huge configuration inside it
This point is a major focus. Right now VRouter is kind of lacking in this domain (I honestly don't know how other packages perform in this domain, I am just not happy with VRouter at this point).
What is proposed above would be a first step towards this. However it is not enough, since it would solve the issue of the router configuration but not the issue of the navigation which is still kinda hard into a large application, remembering all these paths.
The solutions I envision can be found here, though it's not really detailed right know because I don't have much time atm. However the two main ideas are:

Allowing VRouter nesting, with each VRouter having a basePath based on where you place it. All Screen inside this VRouter will navigate using path relative to the basePath, which means that using them in isolation or within another VRouter would not require any change (navigation-wise).
Navigating by type, which is the same as named navigation really, but could have some interesting benefits, I still need a lot of thought there to make things right

But point 1 could really answer your issue of separation of concern I think, it's just a complex issue which needs many more though-time that I have right now.
Anyway, tell me what you think, if I completly missed your/one of your point tell me as well! I'm always glad to discuss even if we don't always agree!

Another interesting side effect you'd get here is really easy linking. The router could go through all PageConfig objects, and inject the the navigator.
Then you could have onPressed: () => SearchPage.routeConfig.push()
Internally PageConfig is just doing something like => _router.setPath(this.path)

This kind of things can already be achieved by using named navigation I think. Using static fields to contain those name is already possible, though it might be easier to attach those to the VRouteElement mentioned above like so:
class LoginRoute extends VRouteElement {
  static String name = 'loginRoute';
  List<VRouteElement> get subRoutes => [VWidget(path: '/login', widget: LoginScreen(), name: LoginRoute.name)];
}

and then navigate using:
context.vRouter.pushNamed(LoginRoute.name)

Any though about this ? Positive/Negative remarks? If not we might close this :+1:

Ya I think this is ok to close, this discussion inspired me to make my own lib, similar to yours but different as well.
https://pub.dev/packages/nav_stack
I'm able to reproduce your example on the README like:
return NavStack(
  stackBuilder: (context, controller) {
    return PathStack(
      scaffoldBuilder: (_, stack) => _MyScaffold(stack),
      routes: {
        ["/login", "/"]: LoginScreen().buildStackRoute(),
        ["/in/"]: PathStack(
          routes: {
            ["profile/:profileId"]:
                StackRouteBuilder(builder: (_, args) => ProfileScreen(profileId: args["profileId"] ?? "")),
            ["settings"]: SettingsScreen().buildStackRoute(),
          },
        ).buildStackRoute(onBeforeEnter: (_) {
          if (!isLoggedIn) controller.redirect("/login", () => showAuthWarning(context));
          return isLoggedIn; // If we return false, the route will not be entered.
        }),
      },
    );
  },
);

Thanks a lot for the discussion and inspiration!


There is no guide  for enabling Azure Arc enabled Data Services on existing K8s cluster

Is your feature request related to a problem? Please describe.
Hello team.
I carefully read the deployment scenarios suggested. Especially i'm wondering  about Azure Arc enabled Data Services scenarios.
All those scenarios are bigin from the words "If you do not yet have a Kubernetes cluster"  But what if i already have a K8s cluster and  connected it to the Azure Arc? Where can i get guidance for this scenario?
My scenario - Azure Stack Hub and AKS Engine VM on Linux, so i dont want to do all deployment operations following existing guidance and i don't want to install additional Windows VMs just for installation purposes.
Describe the solution you'd like
We need a separate ARM template to deploy  only Azure Arc Data Services on existing K8s cluster, without creating it each time from scratch and without creating WIndows VM if we already have AKS Engine VM.
As part of the Windows Server 2019 VM deployment, there are 2 scripts executions; First script (ClientTools.ps1) at deployment runtime using the ARM "CustomScriptExtension" module and a second script (LogonScript.ps1) on user first logon to Windows.

Runtime script will:

Inject user params values (from bullet point #1) to be used in both runtime and logon script
Install the required tools – az cli, az cli Powershell module, kube-cli (Chocolaty packages)
!Download & install the Azure Data Studio & azdata cli
!Download the Azure Data Studio Azure Data CLI, Azure Arc & PostgreSQL extensions
!Download the Postgres_Cleanup and Postgres_Deploy Powershell scripts
!Create the Postgres Connectivity script
Create the logon script
Create the Windows schedule task to run the logon script at first login
Disable Windows Server Manager from running at login
Logon script will:

Create the LogonScript.log file
!Retrieve the AKS credentials & create the kubeconfig file in user Windows profile
Create the azdata config file in user Windows profile
!Install the Azure Data Studio Azure Data CLI, Azure Arc & PostgreSQL extensions
Create the Azure Data Studio desktop shortcut
Open another Powershell session which will execute the kubectl get pods -n <Arc Data Controller namespace> -w command
!Deploy the Arc Data Controller using the user params values
?Deploy Azure Postgres server group (with 5 workers) on the AKS cluster
!Creating Postgres connectivity details using the Postgres Connectivity script
Unregister the logon script Windows schedule task so it will not run after first login

i think an actions which i marked with ! can be just perfomed from AKS Engine workstation..
So it would be great, if such additional guidance will be available.
Thanks
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi @werton13  - You can find how to deploy to an existing Kubernetes cluster here:  https://docs.microsoft.com/en-us/azure/azure-arc/data/create-data-controller.  If you are familiar with using a CLI tool, I recommend using the azdata CLI tool option to deploy.
To make the option of deploying to an existing Kubernetes cluster easier to find from the Jumpstart site I've submitted this PR:
https://github.com/microsoft/azure_arc/pull/138

@werton13 just to clarify, the side Windows VM deployment on all the data services scenarios is designed to help you manage the deployed environment with azdata CLI, Azure Data Studio and kubectl.


Mapping to nullable decimal with InvalidFallback results in value 0 instead of null

The following code results in the value 0 in the column AmountPerLayer, but I expected the value null.
Am I doing something wrong?
Map(fust => fust.AmountPerLayer) 			.WithColumnIndex(3) 			.WithInvalidFallback((decimal?)null) 			.WithEmptyFallback((decimal?)null);

what was the value of cell in column index 3?

what was the value of cell in column index 3?

Most cells have a value like 1 2 5 6 6 4 3
And these are working well, but there are a few containing text or that are empty. These result in a 0 value, but I expected a null.

Is AmountPerLayer defined as a decimal? i.e. nullable decimal? Could you share your structure

If the type is nullable decimal, maybe could you share the excel file?

Yea it is a nullable decimal, let me see if I can get a part out of the file without sharing sensitive data.
column is like this
Empty
Some Text
Some Text
Empty
Empty
5
3
6

I just found out that the "empty" fields had a hidden value of 0, that's why it didn't work.
So it does work as intended, sorry for the confusion!


Doesn't seem to work with html tidy on Mac OS X El Capitan

Seeing
syntastic: warning: variable g:syntastic_html_checker is deprecated
Error detected while processing function 63_VimEnterHook[14]..63_UpdateErrors[15]..63_CacheErrors[22]..341[17]..348:
line    1:
E730: using List as a String
Press ENTER or type command to continue
Error detected while processing function 63_VimEnterHook[14]..63_UpdateErrors[15]..63_CacheErrors:
line   22:
E712: Argument of extend() must be a List or Dictionary
Press ENTER or type command to continue
when I try to vim foo.html
Here are my relevant lines in my .vimrc file
" Recommneded settings via https://github.com/scrooloose/syntastic
set statusline+=%#warningmsg#
" Turn off style messages
"let g:syntastic_quiet_messages = { "!level":  "errors" }
let g:syntastic_loc_list_height=1
set statusline+=%{SyntasticStatuslineFlag()}
set statusline+=%*
let g:syntastic_always_populate_loc_list = 1
let g:syntastic_auto_loc_list = 0
let g:syntastic_check_on_open = 1
let g:syntastic_check_on_wq = 0
let g:syntastic_error_symbol = "✗"
let g:syntastic_warning_symbol ="⚠"
" Syntax checkers
let g:syntastic_css_checkers = ['csslint']
let g:syntastic_html_checker = ['tidy']
" From https://github.com/vim-ruby/vim-ruby/issues/166
" We like fish but need a POSIX compatible shell
set shell=/bin/bash
Here is me setting syntastic_debug =1 and opening the file in question:
Messages maintainer: Bram Moolenaar<EMAIL_ADDRESS>"current.html" 514L, 62071C
syntastic: 0.216403: g:syntastic_version = '3.7.0-225 (Vim 704, Darwin)'
syntastic: 0.216676: &shell = '/bin/bash' (!), &shellcmdflag = '-c', &shellpipe = '2>&1| tee', &shellquote = '', &shellredir = '>%s 2>&1', &shelltemp = 1, &shellxquote = '', &shellxescape =
'', &autochdir = 0
syntastic: 0.217337: UpdateErrors (auto): default checkers
syntastic: 0.217712: CacheErrors: default checkers
syntastic: 0.218643: g:syntastic_aggregate_errors = 0
syntastic: 0.218991: getcwd() = '/Users/david/workspace'
Please let me know if you need anything else.  You've got a great tool here; excited to get it working.

syntastic: warning: variable g:syntastic_html_checker is deprecated

Fix this first.

And that made it work!
Moving
let g:syntastic_html_checker = ['tidy']
to
let g:syntastic_html_checkers = ['tidy']
Fixed it!
Now if I could just speed up editing this 61K HTML file I'd be all set.  But I don't think that's a syntastic issue; more of a why is this HTML 61K issue :P


Update README.md

I have updated this file

Hello, I created this repository for a coin that I created as a test and I am mining it individually with 5 servers.


Environment Q

I'm trying to do MMdetection, what library do I need?
My environment is as below. How should I match Cuda 12.5, mmcv version?

@chartgod please see previous issue: https://github.com/ViTAE-Transformer/MTP/issues/10


Mapping Collection of Custom Type throwing Exception

hi,
i have a collection of custom class(Say Class1) and i have to map it to collection of different class(say Class2). Here Class1 is a public class whereas Class2 is public static inner class. When generating implementation for mapping interface it is throwing unsupported Operation exception. On investigation , i found that while iterating collection of class1. it is mapping class with java.Lang.Object .
Failed to generate mapping method for type java.lang.Object to Class1 to Class2.
thanks

Hi,
can you give me a sample code ? The collection type argument should properly defined for this to work. This can explain the error.


Error when building content. Pipeline needs reference to MonoGame.Aserpite assembly

Description
When attempting to build any content using the MonoGame.Aseprite.Content.Pipeline.dll reference in the mgcb-editor, an exception is thrown stating that it has no reference to the assembly MonoGame.Aseprite
Steps to Reproduce

Create new monogame project, type doesn't matter, scenario below uses desktop gl

mkdir ./example
cd ./example
dotnet new sln -n Example
dotnet new mgdesktopgl -n Example
dotnet sln add ./Example
cd ./Example
dotnet add package MonoGame.Aseprite --version 5.0.0
dotnet restore

Open the mgcb-editor

# from within the project directory
dotnet mgcb-editor ./Content/Content.mgcb

Add the MonoGame.Aserpite.Content.Pipeline.dll reference to the mgcb-editor as documented here https://monogameaseprite.net/docs/getting-started/setup-mgcb-editor

Add an aseprite file as content

Choose any processor from the MonoGame.Aserpite.Content.Pipeline.dll reference

Expected Behavior
The content builds as expected
Actual Behavior
An exception is thrown stating that the MonoGame.Aseprite assembly could not be found
Configuration

Which version of .NET are you using?

any

Which version of MonoGame are you using?

3.8.1

Which version of Aseprite are you using?

>= 1.2

What operating system and version, and what distro if applicable?

any

What is the architecture (x64, x64)?

any

Other Information
No response

Issue is caused by most recent version update where new processors were added to the content pipeline.
Pipeline now references the main library assembly.
For now, users can resolve this by adding the main library assembly as a reference as well.  To do this, follow the same steps as when adding the pipeline dll, only this time add the following dll

Windows: %userprofile%\.nuget\packages\monogame-aseprite\5.0.0\lib\net6.0\MonoGame.Aseprite.dll
Mac/Linux: ~/.nuget/packages/monogame-aseprite/5.0.0/lib/net6.0/MonoGame.Aseprite.dll

⚠ The above file paths assume default global nuget package directory. If you are using a nuget.config to download packages local to the project directory, you'll need to adjust the path to that directory instead.

Resolved with 5.0.1 release #78


Feature/add extra datas restrict geocoding

According with @LordSimal , i have add some features:

For autocomplete field:

Possibility to add geocoding restriction in field options
Save city, zip code and country in location field

For Lat, Lng fields:

Adding geocoder in order to save city, zip code and country in location field

If needed feel you free to comment or review this PR
Thanks to @LordSimal

What a nice addition 👍
About the Autocomplete-Adaption: Didn't know this was even possible 😄
Thank you very much.

But I know get an error when trying to enter a Lat and Long manually.
The JS Error is:
that.geocodeLatLng is not a function

Do I have to add an additional API to my Google Map Key?

No i have miss a function on file, should be good now ;)

Indeed that fixed it.
With that lets merge it and create a release.


There was an error starting your tunnel.

Hello,
just tried your extension which seemed nice, but I can't get it to run.
What I do :
Ctrl+Shift+P
ngrok: start
Fill port number : 8024 for example.
A notification show a message : "There was an error starting your tunnel"
Sorry that I can't give more informations.
Do extensions give log somewhere with more explanations as to what happened?

Hey @thomas-brandeho, thanks for trying the extension!
What operating system are you using? You can also check the developer tools for logs, see this answer for how.

Thanks for the reply.
My system is Ubuntu 19.10.
VSCode is 1.44.1.
I will check the developer tools and will let you know if I find a clue about what is happening.

I think I might have bundled the Mac binary for ngrok in the package.
Currently exploring postinstall scripts, or a way to download the correct binary for the system.

Here are the log when trying to start a tunnel :
ngrok_start_error.log

Could you try installing and using version 1.2.0 please? It should be working now.

Yes it's working.
Thank you very much.

Awesome, thank you!

Hello,
just tried your extension which seemed nice, but I can't get it to run.
What I do :
Ctrl+Shift+P ngrok: start Fill port number : 8024 for example.
A notification show a message : "There was an error starting your tunnel"
Sorry that I can't give more informations. Do extensions give log somewhere with more explanations as to what happened?

I am experiencing this same problem. Ctrl+Shift+P --> run ngrok --> 3000

https://github.com/philnash/ngrok-for-vscode/issues/4#issue-600268249
My system is Windows 10Pro
Thanks

Hi @gtichess, can you check the developer tools and see if anything is logged about the error.


fix(client): render MathJax in jaws header

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #52794

MathJax is rendered in jaws header.
A bit re-organizing and unifying to MathJax util.

I am not really a fan of using pathName as a condition. I think it would be better if we used the SuperBlocks enum to tell if MathJax needs to be imported or not.
We are aiming to no longer use stringified versions of SuperBlock names.

Do you mean just using SuperBlocks in isMathJaxAllowed to compare/match (whichever is correct) with the passed pathname? Or having SuperBlock as the parameter?
The latter latter might not be possible, onRenderBody from the gatsby-ssr doesn't seem to be able to access page props.

If the latter is not possible, then we should keep it as it is.

@moT01 I wouldn't really mind, whichever is wanted. I can throw away enabling it in new JS and new Python, while keeping the rest. It will make changing it in future easier anyway, if needed.

We are going to need it in the new Python curriculum when we start working on the new projects. Also we were hoping to try to draw a graph for the Shortest Path Algorithm, instead of using images. (There is no graphic rapresentation at all at the moment)


bottom-sheet add disabledNavigationOnOpened feature

Bug, feature request, or proposal:
Feature Request
What is the expected behavior?
When the navigation is back or forwarded, only the bottom-sheet is closed and the navigation does not change.
What is the current behavior?
The bottom sheet is closed, but the navigation has changed.
What is the use-case or motivation for changing an existing behavior?
Let the bottom sheet add a more user-friendly configuration.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular - 7.0.0
Material - 7.1.1
OS: Windows 10
Typescript: 3.1.1
Browsers - All
Is there anything else we should know?
I am trying to add canDeactived guard to the route.but cannot be perfectly controlled bottom sheet. After closing the bottom sheet, there is a problem opening it again.

Closing this since I don't think it's something we can actually do at the component level- this would require hooking up to the router to accomplish.


Update README - modify sections, update documentation link

Changes

Redo sections, update documentation link directory (SSSFDG to sticky-selectron-documentation), and remove last section “Salesforce DX Project: Next Steps” that was from default file in VSCode

@roanbear I removed the Installation section. I had added it since some of the other repos included it.


Make billed column more understandable

[x] Please make it understand that available is the same as free
[x] Investigation - Can we have a tooltip if we hover over the “Billed” column header?

Figure: Billed column is hard to understand

[x]  Investigation - Can we have a tooltip if we hover over the “Billed” column header?
No, we can't. Tooltip feature is not supported yet. Refer to https://github.com/microsoft/AdaptiveCards/issues/4668


added files for cosmoflow: requirements.txt, cosmoflow.patch, cosmoflow_env.sh

Added the necessary files required to run cosmoflow with sabath. After setting up the environment with these files you can simply run cosmoflow by cloning the cosmoflow repository, applying the patch, downloading the dataset and setting the dataset location to configs/cosmo.yaml, and then execute the run command for cosmoflow.

I updated the PR with the second commit. The model now uses the latest version of Horovod with Tensorflow (2.10.0) plus GPU support eliminating the need for source code modification.

I resolved the merge conflicts and updated cosmoflow.json to handle both datasets (cosmoUniverse_2019_05_4parE_tf_v2 and cosmoUniverse_2019_05_4parE_tf_v2_mini) and their varying training parameters.


add FUNCTION_EXISTS

not basic ABAP, as it needs "kernel" stuff
requires classic exceptions in transpiler

https://github.com/open-abap/open-abap-core/pull/580

needs https://github.com/abaplint/transpiler/pull/1213


[Coverity CID :195845]Memory - corruptions in /tests/net/traffic_class/src/main.c

Static code scan issues seen in File: /tests/net/traffic_class/src/main.c
Category: Memory - corruptions
Function: traffic_class_recv_data_mix_all_1
Component: Tests
CID: 195845
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

same as CID:195896 and CID:195839.
GH issues are #14393 and #14403.

False positive


[WIP] Use conda-forge packages when creating environment

Use conda-forge channel, which has up-to-date versions of most of our dependencies, so we won't need to install them via pip. This should reduce the risk of ending up with an inconsistent environment, esp. if users install packages after initial environment creation.
x-ref #7945
cc @cbrnr

I believe we need to create a pyvistaqt feedstock on conda-forge to avoid pulling in another PyQt5 dependency via pip.

The fact that conda and pip packages for PyQt5 are named differently has caused me so much headache. I have no idea why conda insists on naming it pyqt.

The fact that conda and pip packages for PyQt5 are named differently has caused me so much headache. I have no idea why conda insists on naming it pyqt.

Yeah I know. But there are workarounds. Also I was thinking about just creating a meta package names PyQt5… but I doubt it would be accepted in conda-forge.

Which workaround works with setup.py and requirements.txt (i.e. pip)? I solved this problem by only requiring QtPy, which fortunately has the same package name in conda and PyPI. However, this is not ideal, because users have to manually install PyQt5 or PySide2 - but maybe that's a good thing and this solution isn't that bad after all.

Regarding pyvistaqt, you can still install via pip install pyvistaqt --no-deps to avoid pulling in another PyQt5 copy.

Which workaround works with setup.py and requirements.txt (i.e. pip)?

No idea, I never use requirements.txt; but in PsychoPy worked around the conda <> PyPI naming conflicts like this:
https://github.com/psychopy/psychopy/blob/6e6e62f6bcd3a6d359664ea8020fdeefd7d73ac6/setup.py#L25-L42

Regarding pyvistaqt, you can still install via pip install pyvistaqt --no-deps to avoid pulling in another PyQt5 copy.

I don't think this works in a conda environment file, unfortunately.

I don't think this works in a conda environment file, unfortunately.

Yes, seems like this is not that easy because it uses a pip requirements file in the background, which also doesn't support adding flags: https://github.com/conda/conda/issues/6805

I believe we need to create a pyvistaqt feedstock on conda-forge

I've started working on a recipe:
https://github.com/conda-forge/staged-recipes/pull/12040

I believe the problems with doc building will be resolved by #7943

Rebased on master as #7943 has been merged.

Apparently vtk 9.0.1 is not live in conda-forge?
ResolvePackageNotFound:
  - vtk[version='>=9.0.1']

Apparently vtk 9.0.1 is not live in conda-forge?

Yes, the build didn't succeed:
https://github.com/conda-forge/vtk-feedstock/pull/137

Until https://github.com/conda-forge/mayavi-feedstock/pull/43 has been merged, pysurfer -- which depends on mayavi -- cannot be installed into the environment (which is supposed to deploy VTK 9.0.1)

Apparently vtk 9.0.1 is not live in conda-forge?

it is now :)

May I suggest to use (at least) this patch to enable GL rendering in the azure job?
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index 02fc0c718..bd01c0a30 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -277,8 +277,15 @@ jobs:
   pool:
     vmImage: 'ubuntu-18.04'
   variables:
+    DISPLAY: ':99'
     CONDA_ENV: 'environment_conda-forge.yml'
   steps:
+  - bash: |
+      sudo apt install libxkbcommon-x11-0 xvfb tcsh libxcb*
+    displayName: 'Install Ubuntu dependencies'
+  - bash: |
+      /sbin/start-stop-daemon --start --quiet --pidfile /tmp/custom_xvfb_99.pid --make-pidfile --background --exec /usr/bin/Xvfb -- :99 -screen 0 1400x900x24 -ac +extension GLX +render -noreset;
+    displayName: 'Spin up Xvfb'
   - bash: |
       set -e
       wget https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-x86_64.sh -O miniforge.sh --progress=dot:mega

traits is still needed somehow even though mayavi is not the environment:
    @contextmanager
    def traits_test_context():
        """Context to raise errors in trait handlers."""
>       from traits.api import push_exception_handler
E       ModuleNotFoundError: No module named 'traits'

Thanks @GuillaumeFavelier! Let's see…

Do we still need/want this now that #7971 is the plan going forward?

Do we still need/want this now that #7971 is the plan going forward?

I think there's still an open question about whether to offer an advanced install option for devs/contributors that has its own environment file.  Potentially that recipe could include the work here.


Syntax Errors reported by pycparser but not gcc

The following code generates no warnings or errors when compiled with gcc with a large number of warning options, yet pycparser reports a syntax error.  #includes omitted.
int main()
{
int i = 5, j = 6, k = 1;
if ((i=j && k == 1) || k > j)
printf("Hello, World\n");
return 0;
}

This is already fixed. (See b4940a24f.) (Better late than never.)


Fix SDK build

Motivation and context
Currently we have red develop branch (look here). This PR fix this problem
How has this been tested?

Checklist

[ ] I submit my changes into the develop branch
[ ] I have added a description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

/check


[elasticsearch] Replace apiVersion networking.k8s.io on ingress.yaml

The networking.k8s.io API version of IngressClass is no longer served as of v1.22.

[ ] Chart version not bumped (the versions are all bumped and released at the same time)
[ ] README.md updated with any new values or changes
[ ] Updated template tests in ${CHART}/tests/*.py
[ ] Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Closing as CLA wasn't signed and this has been fixed into https://github.com/elastic/helm-charts/pull/1409


Ledger tx gives 403 Error

When sending a Ledger Tx, the user is presented with a 403 error.
Same also happens with a message deposit.

Keystore works fine
Reason
Keystore has implemented 9R headers, ledger has not.
https://github.com/asgardex/asgardex-desktop/blob/develop/src/main/api/ledger/thorchain/transaction.ts#L66 sends a request to 9R
It is believed this is the source of the error.
Looking at this code
 console.log('Sending data:', sdk, signer)
   let {
      data: { result: account }
    } = await auth.accountsAddressGet(sdk, signer)
    console.log('Received result:', account)

account is never returned.
dev:*electron] NodeURL is: https://thornode.ninerealms.com
[dev:*electron] Got ChaidID: thorchain-mainnet-v1
[dev:*electron] Sending data: CosmosSDK {
[dev:*electron]   url: 'https://thornode.ninerealms.com',
[dev:*electron]   chainID: 'thorchain-mainnet-v1'
[dev:*electron] } AccAddress {
[dev:*electron]   _value: [
[dev:*electron]      70, 160, 146, 212,  89, 208,
[dev:*electron]     214, 188,  64,  74,   0,  72,
[dev:*electron]      49, 169, 117, 103, 189,  11,
[dev:*electron]      24, 255
[dev:*electron]   ]
[dev:*electron] }

As 9R have taken protective steps against DODs, the request is not authorised.
Solution
Add a header to the request before it is sent.

Can't add a header to this as cosmos-client doesn't export axios instance.
package will be remove and @cosmos-client/core will be used instead

Fixed


adding CToolBridge.md in ctoolbridge package

Putting this in ctoolbridge package for now.

Why close this?

I missed couple of important prerquisites to add in this doc. Adding those now, will reopen once done.


[UT] Fix drop task sql test

Why I'm doing:
This UT has not been maintained for a long time. I opened it today and found that the behavior has been modified long ago.
What I'm doing:
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[x] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

https://github.com/Mergifyio backport branch-3.2


Some Improvements to the code quality

Use snake_case for all methods and variables
Consistent spacing and newlines
Replace the Error class with editor warnings and logs to the console
Remove Wait class because it doesn't do anything
Static typing where possible

The removal of Error and Wait class are theoretically breaking changes, but i doubt that they where used by anybody.

haha nice, i havent had any time to come back to this myself, I've been lost in server networking/udp land for months. I know this library needed more work, when I first cloned this from some other repo(s) I didnt actually understand what the blackboard was/did. I intended to come back and do a rewrite into pure code or c# version or something


Consistently makes element-android formatting of code blocks wrong

Steps to reproduce the problem (provide example Markdown if applicable):
struct Foo {
  Foo();
  int a;
}

Expected behavior:
The behavior should be identical to what you see in this window. However, it consistently is not.
struct Foo {
  Foo();
  int a;
}

Actual behavior:
struct Foo {
Foo();
int a;
}

The reason why I've found this problem is because element-android depends on this library - and on the android app the code blocks consistently (for everyone should be formatted erroneously). It's a bit strange that more people have not noticed this (to me).
Here's what the common mark spec outputs (which is what should be expected): https://spec.commonmark.org/dingus/
I think I've identified where the problem is and will be submitting a PR.

您好！邮件已收到。

Can you describe the problem better? Using this as input:
## Try CommonMark

```cpp
struct Foo {
  Foo();
  int a;
}
```

It renders as:

Try CommonMark

struct Foo {
  Foo();
  int a;
}

Which is consistent with what your Dingus link does.


feat: add instances about volume

Lean 3 was able to apply, e.g., instances about measure_theory.measure.prod to the volume on the Cartesian product. Lean 4 can't do this, so we need to duplicate many instances.

Thanks!
bors r+


Show tooltips anywhere on line (area) chart?

Currenty possible to show tooltip only when mouseover point in line (area) chart:

Is it doable to show tooltip when mouseover any portion of line (area) chart (with the unique value of that portion):

@coax That would certainly be possible, I unfortunately just don't have the time to add that. Would love a PR though :)

I've added a mousemove event handler on the whole chart and searched the nearest 'ct-point'.
Here is my code:
on('mousemove',null, function (event) {
var point = $.nearest({x:event.clientX, y:event.clientY}, ".ct-point",{onlyX: true}).trigger("mouseover");
}
I've used https://gilmoreorless.github.io/jquery-nearest/ to find the nearest 'ct-point'.

@SimonKlausLudwig Do you have working script example? I haven't worked on Chartist a long time and don't know how to implement your solution. Thanks

Meh, nevermind... I managed to implement nearest plugin without chartist-plugin-tooltip plugin:
	...
	new Chartist.Line('.graph', data, options);

	var GraphContainer = $('.graph');
	var Tooltip = $('body').append('

').find('.tooltip-styling').hide();

	GraphContainer.on('mouseleave', '.ct-chart-line', function() {
		Tooltip.hide();
	});

	GraphContainer.on('mousemove', '.ct-chart-line', function(event) {
		var point = $.nearest({x:event.clientX, y:event.clientY}, '.ct-point', {onlyX: true});
		var value = point.attr('ct:value');
		var seriesName = point.parent().attr('ct:series-name');
		Tooltip.html(seriesName + '
' + value).show();

		Tooltip.css({
			left: event.pageX - 20,
			top: event.pageY - Tooltip.height() - 30
		});
	});

but there's no way to add values from other series in same chart (I have multiple lines), plus can't show 'labels' name above value without using 'meta'.


Identifiers should start with capital letters

See https://github.com/lezer-parser/java/issues/1 and https://docs.oracle.com/javase/specs/jls/se15/html/jls-3.html#jls-Identifier

See the capitalIdentifier defined below. These are used for a heuristic to prefer parsing capitalized identifiers as class names, and this change would break that. Attached patch solves this in another way.


Fix custom colours on mobile

Nothing happens on click

https://github.com/Hatchibombotar/minicrafter-maker/commit/c8de07831ac738078d93182c9e405044ced55c9b
Now working but input area should be made bigger.


#![feature(metadata_ext)] unstable

This project is used in iron/staticfile,
but wasn't able to compile the examples sucessfully.
git clone https://github.com/iron/staticfile
cargo run --release --example router

filetime-0.1.2/src/lib.rs:1 #![feature(metadata_ext)]
                                                                                ^~~~~~~~~~~~~~~~~~~~~~~~~

$rustc -V
rustc 1.1.0-beta (cd7d89af9 2015-05-16) (built 2015-05-16)

Unfortunately this is a limitation of this library, but hopefully these features will become stable in the 1.1 release!


Advanced Search can be unintuitive

Expected Behavior or Use Case
We have had many of our users comment that the advanced search functionality is unintuitive to them. Here are the types of things our users have commented on:

functionality related to excluding some results (like this NOT that)
the search bar doesn't allow you to press down in order to select options/suggestions
when you initiate a search from the homepage and then hit enter, you can't use the back button to return to the homepage
"search is unintuitive. the search filters on the side, for example, seem to expand the filtering sometimes?"

Other companies have also asked for feedback from their users:

ING

Parisa@ presented her user research on Amundsen (Slides, recording)

REA Group is doing user testing with their Alpha users

some of their users "struggle with the advanced search features"
they might improve the tooltip so that it doesn't say 'regex' since not everyone knows what that means.
One user in their testing suggested pre-populating some of the search bars with examples
would be interested to experiment with taking away exact search by default

This has come up in at least one comment in the slack group:

Tanmay: "I am having a hard time figuring out the advanced search. The usual search works perfectly fine and I am able search through all the metadata in elastic search. When I try using advanced search, by setting the source/table name/tags it returns an empty set of results. I am not sure what is the issue,  as my usual search works fine."

Service or Ingestion ETL
Amundsen Search Library
Possible Implementation
I realize this issue is a bit vague, but we have gotten overwhelming feedback that our users want search to change (figuring out what exactly that looks like is a separate issue)

@alran hey Alyssa, i know there are a lot more we could do to improve the search. And thanks for documenting the issues. I have an internal doc for search syntax and I think we could copy it over to help clarify a bit. In the mean time, we could brainstorm and improve the search?

Yes, I think a brainstorm would be good! Perhaps we could get some other people in the community onboard with a brainstorming session as well

Happy to participate as well. What format do you suggest? Can we attract more people to discuss here on this issue or is a small online session more productive?

I'm going back to some people internally to try to gather more specific notes that could be used in a brainstorming session. I think it might be nice to have a small online session (I know there is at least one person on my team who'd like to demo a style of search that he thinks is more intuitive). But I also want people to comment here with suggestions and ideas too!

Sounds great! In particular the “use pre-existing” part. Would be great to not have to reinvent this - both on UX level - but in particular if it was already backed by a library. Any product name to drop on this perhaps? To me the JQL advanced bar in JIRA comes to mind with “intellisense” like suggestions - or something like what’s already there with the IU for adding tags in Amundsen.
To kick off a discussion I think we can separate this into two buckets:

“Low fruit” usability nits with a pretty obvious resolution with low risk for side effects like some of the ones I list below.
Others which require more pro/con discussions, maybe even ultimately writing an RFC.

Low fruit 🍉 🍏 🍌 list:

the search bar doesn't allow you to press down in order to select options/suggestions

=> implement an arrow key keyboard handler to cycle down/up through the list of suggested results.

they might improve the tooltip so that it doesn't say 'regex' since not everyone knows what that means.

Agree, and ‘regex’ is actually the wrong word for how this works - it’s merely just ‘wildcard using *’ which I guess is understandable by more people. Plus it might be possible to add a local help link to either the docco Tao can carve out - or just a slightly improved version of the already existing examples under point 7. and 8. in https://www.amundsen.io/amundsen/installation/#bootstrap-a-default-version-of-amundsen-using-docker

A few additional comments:

Clearing the form is unintuitive:  clearing an advanced search term on the side bar by deleting the text from the box doesn't always clear it from the URL.  You must select "Clear" in order for the term to be removed.
The Lyft data model (database -> cluster -> schema -> table) doesn't map exactly to all companies' data models.  As a result, it isn't always clear what type of data you're searching for using each of these fields.  Since the project is open source, implementers can update the code to include only which fields they want and update the tooltip/name/etc. to something meaningful to them on the advanced search page, but it would be simpler if this was configurable.

I'm interested in participating in a brainstorming session if one is set up!

@feng-tao I've been trying to set up search doco as well so it'd be great to see what you've got!
I'd also been thinking that highlighting the matching search terms, a la google search results, would help make it more transparent to users why certain tables show higher in results than others:

I might also test whether we can introduce some of the more specific ways to search on the home page, for example:

@alran https://github.com/amundsen-io/amundsen/pull/773/files for search tutorial doc


Error if I try to get to Service detail page before it's finished creating

date - 12/4
Steps:

Create a service with a scale of 20
Click on the service name to get to service detail

results: Blank screen and error in console.
vue.runtime.esm.js:1888 TypeError: Cannot read property 'scaleStatus' of undefined

Date - 12/11
Verified fixed


Automated cherry pick of #1638: 避免无限删除guest失败

Cherry pick of #1638 on release/2.11.0.
#1638: 避免无限删除guest失败

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11.0@bd20c28). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.11.0   #1639   +/-   ##
================================================
  Coverage                  ?   7.66%
================================================
  Files                     ?     411
  Lines                     ?   63056
  Branches                  ?       0
================================================
  Hits                      ?    4831
  Misses                    ?   57816
  Partials                  ?     409

Flag
Coverage Δ

#aFlag
7.66% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/hosts.go
0.4% <0%> (ø)

pkg/compute/guestdrivers/managedvirtual.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd20c28...4cad2c9. Read the comment docs.

/lgtm
/approve


Lock & cache keytabs requested from IPA.

To avoid race condition when multiple containers on the same host
request same keytab from IPA, serialize krb5keytab requests and use
local cache. If the keytab is available locally, use it.
TODO: Possible enhancement - check keytab validity (need to establish
sec context to validate that keytab version is current.)

rename --cache to --cachedir?
--cache sounds like boolean, --cachedir is more explicit.

Fixed --cachedir now.


Do not populate repeater fields in admin with SEO form + Update translations' handling code

If a Static page layout extends form fields of a page with a repeater field then fields included in the repeater are also populated with the SEO fields from this plugin. The code needs to detect the level of form fields and stop populating its forms if deeper than first level.
Fix for Issue #2 in original repo.

It seems git has combined both commits (one with only the detection for form fields and one with update of translation's code) into one. Sorry for that, hopefuly it won't create a big mess as those are separate files.
Anyway the commit 8309c8c has its own description included and solves an issue with detection of pages at lower levels of page structure as well as getting the actual translated data from those pages.

Thanks for very clear explenation in commit message.
I will merge if you correct some style modifications I've pointed

Thank you for the code review, much appreciated! I have commited the requested changes.

I'll try to release it at evening.


False negative hint file how to

Hello,
I need scan my C++ project, where is included pcre2 source code.
Is there are any posibility to modify False Negative xml file to report it:
Following example does not work:
 <hint>
    <given>
      <fileName contains="pcre2.h" regex="false" caseSensitive="false"/>
    </given>
    <add>
      <evidence type="vendor" source="hint analyzer" name="vendor" value="pcre" confidence="HIGHEST"/>
      <evidence type="product" source="hint analyzer" name="product" value="pcre" confidence="HIGHEST"/>
      <evidence type="version" source="hint analyzer" name="version" value="10.36" confidence="HIGHEST"/>
    </add>
  </hint>

dependency-check found the file:
2021-11-02 10:33:44,390 org.owasp.dependencycheck.App:358
DEBUG - Found file C:\my\work\Src\pcre2\pcre2.h

But in xml/html missing info about used library.
Can I fix it by modify hint file or is there any other possibility to force add pcre2 lib into dependency-check?
Thank you

ODC does not actually "scan" header files. The logging in the scanner could be much improved as it does indicate that a header file is being analyzed. ODC can analyze autoconf and cmake files.


empty path followed by query cannot be matched

in version 0.18.16, this matcher fails
  private object Code extends QueryParamDecoderMatcher[String]("code")
  private val service: HttpService[Task] = HttpService[Task] {
    case GET -> Root / "" :? Code(code) => Ok(z"WE GOT ALL YUR CODEZ $code")
  }

to match against queries such as http://localhost:39833/?code=...lotsofstuff...
The workaround is to use a non-empty path if possible.

Turns out the empty path can be matched:
    case GET -> Root :? I(start) =>
      Ok(s"start: $start")

is tested and works:
    "GET /?{start}" in {
      val response = serve(Request(GET, uri("/?start=1")))
      response.status must_== (Ok)
      response.as[String] must returnValue("start: 1")
    }

hmm, that is strange. I was getting a compile error with that kind of code
ah :point_up: August 17, 2018 4:26 PM I was using
case GET -> Root / :? Code(code) =>

so the stray / caused the compiler error!
Should we close or should "" /  work?

btw code is here https://github.com/fommil/fpmortals/blob/master/example/src/main/scala/fommil/http/oauth2/interpreters/BlazeUserInteraction.scala

// starts a "protocol-relative" URL, which means the "//" is not part of the path.  Testing it with //example.com//?start=1 works as expected.  There's no bug here, but I will improve dsl.md to clarify.


Add note about using mdx with mli files

By default, Dune only processes markdown files with mdx.  This note gives an example of how to use Dune and mdx in mli files.
It's just a small change to the readme, but if it was there, it would have saved me a few minutes skimming through the Dune docs to figure out what to do.  Do you think it is a helpful addition to the readme?

Sounds good to me, thanks for your contribution!


GBA BIOS file fails to open if located in the same directory as the SkyEmu executable

Reported by Sorer on Discord.

Fixed in dev


Weekly CI tests (S3) fail

Environment
Latest version as of September 5, 2022.

Problem Description
Noticed that the Weekly Tests failed during the S3 tests with the following error:
22/09/05 10:51:27 ERROR Main$: Uncaught exception from tests: Error getting file list from ***/
org.scalatest.exceptions.TestFailedException: Error getting file list from ***/
	at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
	at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
	at org.scalatest.flatspec.AnyFlatSpec.newAssertionFailedException(AnyFlatSpec.scala:1685)
	at org.scalatest.Assertions.fail(Assertions.scala:933)
	at org.scalatest.Assertions.fail$(Assertions.scala:929)
	at org.scalatest.flatspec.AnyFlatSpec.fail(AnyFlatSpec.scala:1685)
	at com.vertica.spark.functests.endtoend.EndToEnd.afterEach(EndToEndTests.scala:71)
        ...

When the action was run again (no code changes), it worked without issue. So this was an intermittent error, not sure how to reproduce.

Cannot reproduce.


Create 2017-06-16-Daniel-Dylewsky

@ded114 I rushed to close it but I realize you need the .md extension.


run 0.06 - powers on GPS when no gps derived data is displayed / configured

Affected hardware version
Bangle 2
Your firmware version
2v12.32
The bug
Configured Run app as:
Box1 time, Box 2: BPM, Box 3: steps, Box 4: Cadence
My understanding is that none of these boxes require the GPS to be powered on
and that the GPS would not be powered on if was not needed.
A previous setting to disable the GPS was taken out as it was stated that the GPS would not be powered on if none of the boxes selected derived data from GPS fixes.
In this case I wanted to time the run, see heart rate but did not want to take the hit on the battery by turning the GPS on.

Fixed - was just requesting GPS when it didn't need it


Windscribe.Windscribe version 2.8.6

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Same version already present in the repo. But changed two things:

Changed installation behavior to install instead of uninstallPrevious (see #132894)
Added x86 architecture (same installer)

Fixes #132894
Microsoft Reviewers: Open in CodeFlow

This is probably the reason for uninstallprevious

Pre 2.4.11 appears to be 32bit only, 2.5.18 overwrites 2.8.6

The last commit, that means they don't even support x86 anymore so this issue should actually be resolved then? i guess its fine to accept the PR then

The last commit, that means they don't even support x86 anymore so this issue should actually be resolved then? i guess its fine to accept the PR then

Probably yes. Maybe x86 just doesn't support the silent parameter. No idea. The installer clearly says "Windows x86_64" though. But I already submitted a PR for this version a few days ago with x86 and it also failed claiming that it wasn't a silent installation.


refactor for loop

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #3567 (ade01b3) into master (a7f1f5c) will decrease coverage by 0.02%.
The diff coverage is 90.90%.

@@             Coverage Diff              @@
##             master    #3567      +/-   ##
============================================
- Coverage     80.40%   80.37%   -0.03%
+ Complexity     7498     7491       -7
============================================
  Files           157      157
  Lines         27960    27956       -4
  Branches       6748     6747       -1
============================================
- Hits          22481    22470      -11
- Misses         3467     3469       +2
- Partials       2012     2017       +5

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/com/alibaba/fastjson/util/ASMUtils.java
83.50% <80.00%> (ø)
33.00 <0.00> (ø)

...om/alibaba/fastjson/util/AntiCollisionHashMap.java
78.36% <87.50%> (-0.13%)
77.00 <2.00> (ø)

...ava/com/alibaba/fastjson/util/IdentityHashMap.java
100.00% <100.00%> (ø)
18.00 <6.00> (ø)

...n/java/com/alibaba/fastjson/util/JavaBeanInfo.java
86.89% <100.00%> (-0.17%)
216.00 <0.00> (-2.00)

...main/java/com/alibaba/fastjson/util/TypeUtils.java
79.20% <100.00%> (-0.02%)
653.00 <0.00> (-1.00)

...com/alibaba/fastjson/serializer/SerialContext.java
82.69% <0.00%> (-3.85%)
21.00% <0.00%> (-1.00%)

...m/alibaba/fastjson/serializer/SerializeConfig.java
77.96% <0.00%> (-0.42%)
138.00% <0.00%> (-2.00%)

...main/java/com/alibaba/fastjson/util/FieldInfo.java
86.42% <0.00%> (-0.34%)
99.00% <0.00%> (ø%)

...java/com/alibaba/fastjson/parser/ParserConfig.java
80.61% <0.00%> (-0.15%)
227.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f1f5c...ade01b3. Read the comment docs.


Host Age Bin Paste Issue

I've noticed that if I type in 12 months into host age and host age unit, then host age bin will produce the correct bin (0-9), but if I paste it in I get the wrong bin (10-19) and it considers it valid (See picture).

This is a tricky one - what is going on is the pasting action is delivering two values, first the age number, 12, which then triggers the binning of 10-19 because month hasn't been pasted yet; but by the time "month" gets pasted in, the number and bin have already been set, and the rule is not to change the bin if it already has a selection in it.  So that's tough!  Not sure what behaviour to allow there.
Simplest thing would be to say any time user changes age unit, bin gets recalculated.

Should see if applying LinkML rules here for calculated slots could fix this via recalculation trigger.


Update kind image digest to 1.21.1

Sync from https://github.com/kubernetes-sigs/kind/releases

Changes

:bug: update kind k8s image digest (follow up to https://github.com/knative-sandbox/eventing-rabbitmq/pull/579)

/kind bug

/assogn @gabo1208

/assign @gabo1208

More context:
After #579 make kind was printing
...
✓ Ensuring node image (kindest/node:1.21)
...

Broker controller was failing with
"Version check failed","knative.dev/pod":"rabbitmq-broker-controller-5959c7f958-q4ft8", ││ "error":"kubernetes version \"1.20.7\" is not compatible, need at least \"1.21.0-0\"

I cleaned up and did make install several times till I realized to run kubectl version. It was showing something like
...
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.7"
...

:man_shrugging:
And then I went to docs :-) https://kind.sigs.k8s.io/docs/user/configuration/#nodes and here https://github.com/knative-sandbox/eventing-rabbitmq/blob/main/test/e2e/kind.yaml

/retest

/lgtm


Added dropdown functionality in nav bar

Issue No:- #1206
Before :-

After :-

@rahulkhandait-sde  Please Merge this pr

why the label was removed

@Kedar-sonavani After merging profile icon was enlarged which doesn't looked good. Do look into it and resolve the conflict . I have reverted this merge for now . Please open a new pr for review
Thank you

I have make a new pr please just check once


Cant use external url/path

Description
Any suggestions on how to use an external link?
Library version
2.0.0
Node version
19.6.0
Typescript version (if you are using it)
4.9.5

Hi @museadam,
Unfortunately there is no way to read input from an external URL, the package only works with files stored on the physical disk; and doesn't work in the browser either.
Please feel free to make a PR to add this feature :)
Regsrds,
Vedant


What does the Linux browser look like and how to download it in advance through cli?

What does the Linux browser look like and how to download it in advance through cli?

Just run the CLI on the linux machine where you want to run the Playwright. It only downloads browsers for the current platform. E.g. if you run linux in docker, you can donwload them when building the image. Why would you need linux binaries on windows?

Because my Linux server can't access the Internet, I want to download it first and then upload it (can I do this? I can run the code on a Linux system that can connect to the Internet, download the browser, and then find a way to get the downloaded browser to Linux that can't connect to the Internet)

See this page for the ways how to configure alternative browser locations etc. You can run playwright locally on a connected linux machine to make it download browsers to PLAYWRIGHT_BROWSERS_PATH and then copy that directory to the other machine, just make sure to point PLAYWRIGHT_BROWSERS_PATH to the location where you copied the browsers to.


Unity-Azure batch service requirements

Hi.
I was trying to bake my scene using azure but after Job getting created I couldn't see any usage in the Batch Service overview tab.
I checked the Job itself and there was "Core Quota" error if I remember it correctly?
so the question I wanted to ask: is there anything specific I should do while creating Batch service?
I haven't used Azure before so I might be wrong while creating the service.
Thank u for the feedback!

Hello! Sounds like you need to request a quota increase. Refer to the Batch documentation on how to do this:
https://docs.microsoft.com/en-us/azure/batch/batch-quota-limit
We recommend using the F8s v2 node size to get started.

Thank you for the response MikeChemi!
I actually don't setup the pool myself (because I know almost nothing about Azure service :D)
I just give the unity plugin names and keys it needs and it creates the pool itself and I get the "The specified account has reached core quota" error.
this is the pool the plugin itself has created:

it is also a F8s v2 node size
thank you again for further guides!

While the Unity plugin will take care of creating the pool itself, you need to do the quota request yourself. If your account has not been granted any F8s v2 quota (which by default, it hasn't), the Unity plugin will be unable to create a pool as you've seen. Please follow the documentation instructions on requesting a quota increase, specifically this section https://docs.microsoft.com/en-us/azure/batch/batch-quota-limit#request-in-azure-portal

thank you MikeChemi!


Incomplete details in the MS Learn Fabric Guide

Describe the bug
Missing code in Get started with data science in Microsoft Fabric
What happened?
Severity:
Low
Persona:
Data Scientist
Link:
https://learn.microsoft.com/en-us/training/modules/get-started-data-science-fabric/4-mlflow
The code for using ML Flow to log experiments is lacking complete code. Like in this example, it is missing the X_train definition

What did you expect to happen?
Having runnable code in the learn guide would help new learners and they would be able to understand things better.
How would you reproduce the bug?

Go to this link
Copy the code and run in Fabric Notebooks

Did this happen via Desktop and/or Smartphone?
Desktop
Operating System
Windows 10
What browsers are you seeing the problem on?
Chrome
Version
No response
Device
No response
What is your current role?
Student Ambassador
What technical topic is this bug related to?
AI/Data Science/Machine Learning
Relevant log output
No response

@aaryan2134 You need to follow the lab. This is an explanation only.


update es2020.intl DisplayNames#of

fix return type of Intl.DisplayNames.prototype.of
was typed to return always string but can actually return undefined too
see spec https://tc39.es/ecma402/#sec-Intl.DisplayNames.prototype.of

Fixes #47143

Thanks!


menu-bar and standalone icons

From docs:
The menu bar supports icons, which can be positioned above, below, to the left, or to the right of the text. Icons can also be used standalone.
My question is how to align standalone icons? In other words, how to put the icon in the center (horz and vert)?

You can just drop an image into the <a> and it will work just fine. There is an issue right now where the image still has a bottom margin, because it's expecting text to be below it. You can fix it for now with this selector:
.menu-bar > li > a > img:first-child:last-child {
  margin: 0;
}


Mobile safari

Mobile safari form assistant causes waypoint to fire in a 'random' manner, causing a handler which modifies the dom to fire, closing the form assistant.

From the Contributing Guidelines:

If you're opening a ticket for a bug:

Give a clear explanation of the bug.
Try to provide a link to a JSFiddle or CodePen or similar reduced test case.
If you cannot provide a reduced test case, please provide a link to a live site demonstrating your bug and include in the ticket the relevant Waypoints code.

I'd love to see an example, though I do believe I understand what you're getting at by the description. And if I understand right, I'm not sure what I can do from the Waypoints library perspective. Perhaps you could call waypoint.disable() on the offending waypoint when the form element is focused? Again, it's hard to say without seeing the concrete use case.

Closing. Reopen if there is more to add.


[Extension Name] ...

Extension
https://www.raycast.com/jomifepe/bitwarden
Raycast Version
1.79.1
macOS Version
mac OS 13.6.7
Description
After I configured the Bitwarden API, when I used the function, the vault status was locked. After I entered the master password, it feedback: Failed to unlock vault Invallid master password, but I can log in to the Bitwarden app with this master password, so I don't know what happened. Can anyone help me? Thanks.

Steps To Reproduce
After I configured the Bitwarden API, when I used the function, the vault status was locked. After I entered the master password, it feedback: Failed to unlock vault Invallid master password
Current Behaviour
No response
Expected Behaviour
No response

Hey, please read this comment: https://github.com/raycast/extensions/issues/13329#issuecomment-2238743439

Hey, please read this comment: #13329 (comment)

thanks, this method solved my problem!


Generate front end UI based on the meta data from back end

Generate front end UI based on the meta data from back end

Written by @xqliu
Created at 2014-11-05T01:14:42.000+0800
Link to http://betterlife.atlassian.net/browse/BE-2

Look into ng-admin for details.

Written by @xqliu
Created at 2014-11-09T00:27:25.000+0800

https://github.com/marmelab/ng-admin

Written by @xqliu
Created at 2014-11-09T15:59:26.000+0800

Do research on :

Init angular-ui-grid table upon receive data from restful service
How to display date column in angular-ui-grid.

Written by @xqliu
Created at 2014-12-08T13:14:34.611+0800


feat: login, home, edgeResource, crd

/kind feature
feat: login, home, edgeResource, crd

/assign

Thank you for your huge contribution.
Please squash the merge commit for cleanup, and sign all commits.

The token field on the login page should be blank when it is initialized

Click namespace default on the home page and showed not found error.

Update deployment failed with error code: 409, message: "Operation cannot be fulfilled on deployments.apps \"test123\": the object has been modified; please apply your changes to the latest version and try again"

Although the update operation failed, the contents of the yaml were updated, but not in K8s.

Can't find a way to check the details of configmap

 The token field on the login page should be blank when it is initialized

It is fixed.

 Click namespace default on the home page and showed not found error.

It is fixed.

Update deployment failed with error code: 409, message: "Operation cannot be fulfilled on deployments.apps \"test123\": the object has been modified; please apply your changes to the latest version and try again"
Although the update operation failed, the contents of the yaml were updated, but not in K8s.

For problem 1, I tried to modify replicas number in yaml successfully. The code: 409 results from wrong modified param, which is unable to pass k8s verification.
For problem 2, it is fixed.

Error message pops up on the login page.

 Error message pops up on the login page.

It is fixed.


Discuss re-structuring tests, adding envtest and introducing a guide for new tests

Problem statement
Currently we have 3 levels of tests: unit (with some usage of envtest already), integration tests, and e2e tests.
This issue tracks the effort to

discuss re-structuring the tests in a way that's more organized
discuss and document adding dedicated envtest based tests (e.g. in test/envtest/)
~add a guide helping developers too choose which type of tests to write when adding new ones~ #4107

Why Anything?

some integration tests could be on a lower level - this would make them faster
the envtest approach is promising at achieving the above

I agree that the testing landscape can be a little bit confusing, so I think this effort is probably quite helpful for future contributors and maintainers. More envtest based coverage is compelling because it would enable us to exercise more controller code at something a bit closer to a unit test level, just a matter of putting in the time. Also just a reminder that we have a # Testing section in our CONTRIBUTING.md which might be a good place to expand, or at the very least just remember that it's there when we work on new documentation.

Food for thought
Maybe envtest should be part of KTF.

The above is not fully true in this case, because created pods, etc. don't do anything useful. But on the other hand, all K8s clients, etc. work with such an environment as with a normal cluster. Having the same interface as for Kind cluster for such envtest env would be handy in my opinion. Wrapping creation and tear down envtest in familiar interface.

That could definitely happen at some point.
One note for this that I have is that for now, envtest related code is getting shape (in pain and slowly). I believe we'll get much more speed by extending this in-repo rather than in ktf. We can decide if we'd like to move it when we have the structure of its API in place.
One more thing that got into my head is that users might be surprised when using it given the duck analogy that you brought up. envtest is a very limited environment, you don't get any upstream controllers, you cannot delete a namespace and more.
If we end up needed envtest in KGO, then surely it will make sense but we'd have to rethink the API as currently, the API relies on having "a cluster" where envtest environment doesn't really constitute a cluster in a way.

I think about a more streamlined API for envtest, in my opinion such environment could implement this portion (+ DumpDiagnostics) of the Cluster interface.

In this case we'd need to come up with a structured API re-design, extracting said part of an interface, giving it a proper and meaningful name etc


cmdlet - New-ZendeskTicket

[x] Creation of .ps1 cmdlet complete
[x] Testing Stage

Tested and confirmed working.


Add metrics for visibility archiver

Coverage increased (+0.09%) to 67.071% when pulling 17f48834f207aa4f87063fae45f5462d8ffd19b0 on yycptt:visibility-archival-metrics into 6d2ffbd5110eaba92c03ac179106521cf1fee6aa on uber:master.


added personal bot support

This will make the bot decrypt only self-messages, meaning, it will only listen to your own commands,
those with msg.key.fromMe === true. This is extremely useful to performance on large-scale personal bots, i.e 10 super groups.

Not agree with this PR. It is more suitable for self-implementation only

Makes sense - but in this case it might be cool to instead have a callback parameter that can be used to filter out which messages we want the socket to interact with?


Early abort on iceoryx build failure

Pre-Review Checklist for the PR Author

[x] Code follows the Rust coding style and is formatted with rustfmt
[x] Branch follows the naming format (iox-#123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#42 commit text)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[ ] All checks have passed (except task-list-completed)
[x] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes #17

@elBoberido attached, please find a build.log file.
Shouldn't the undeclared Error enum actually be a PoshError :thinking:
build.log

@elBoberido attached, please find a build.log file.
Shouldn't the undeclared Error enum actually be a PoshError thinking
build.log

Okay, now I know what's going on. Do you have an installed iceoryx at a location where cmake find_package looks for packages?

@adoerr please check if the latest commit fixes your build.

@elBoberido looks good :heavy_check_mark:  Thanks for taking care of this :exclamation:


Custom adapter content disappears after pause/resume for wrap_content bottom sheet in DialogFragment

Please consider making a Pull Request if you are capable of doing so.
Library Version:
implementation 'com.afollestad.material-dialogs:core:3.3.0'
implementation 'com.afollestad.material-dialogs:bottomsheets:3.2.1'

Affected Device(s):
Reproduced on Nexus 6P (real device) and Google Pixel 3 XL with Android 10.0 (emulator).
Describe the Bug:
A clear description of what is the bug is.
To Reproduce:

Create a bottom sheet material dialog with WRAP_CONTENT in a DialogFragment.
Add a custom adapter that has item views with checkboxes.
Show the dialog.
Check/uncheck a checkbox for an item.
Switch to a different app.
Switch back to your app.
Dialog title and content are gone and only the dialog's transparent background remains. If you set positive/negative buttons, they are still showing.
Switch to different app.
Switch back to your app.
Title and content are back...
Switch to/from different app, title and content stays.
Check a different item.
Switch to/from different app, title and content are gone.

Expected Behavior:
Should show your dialog with content every time it resumes, exactly as it was.
Notes:

Has nothing to do with app being killed from memory pressure.
Only happens for WRAP_CONTENT bottom sheets. The same code works fine for MATCH_PARENT bottom sheets or non-bottom sheet dialogs.
Caller is a Fragment (I'm using android navigation component).
If you don't touch any checkboxes in the item view, and you pause/resume your app, it works as expected. It's only when you check/uncheck the checkboxes.
Positive/negative buttons are unaffected: they show no matter what.

My guess is it's setting the height to 0 for some reason?

// dialog fragment
class TestMaterialDialogFragment: DialogFragment() {
    override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
        // return MaterialDialog(requireContext(), BottomSheet(LayoutMode.MATCH_PARENT)) // <-------- works
        // return MaterialDialog(requireContext()) // <-------- works
        return MaterialDialog(requireContext(), BottomSheet(LayoutMode.WRAP_CONTENT)) // <-------- doesn't work
            .show {
                customListAdapter(MyCustomItemAdapter(requireContext()))
                (getListAdapter() as? ItemAdapter)?.submitList(
                    listOf(
                        MyCustomItem(id = 1, isChecked = false),
                        MyCustomItem(id = 2, isChecked = false),
                        MyCustomItem(id = 3, isChecked = false)
                    )
                )
                title(text = "Test dialog")
                negativeButton(text = "Cancel")
                positiveButton(text = "Done")
            }
    }
}

// view holder layout
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:id="@+id/listItemRoot"
    android:orientation="horizontal"
    android:layout_width="match_parent"
    android:layout_height="wrap_content">

    <CheckBox
        android:id="@+id/listItemCheckbox"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center_vertical"
        android:paddingEnd="15dp"/>

    <TextView
        android:id="@+id/listItemTitle"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_gravity="center_vertical"
        android:maxLines="1" />

</LinearLayout>

I will work on this. Is there any other library or software I need to work on it? Thank you.


Dependencies override for zerotier-one.service may be unnecessary

https://github.com/zerotier/zerotier-systemd-manager/blob/bceddd8896bb4d37125de17935253b1fc7252cdc/contrib/zerotier-one.service#L3-L4
The original .service file lists network-online.target as a dependency in both After= and Wants= directives, which, if one's using systemd-networkd (assumed every user of this particular app), already satisfies the dependency on systemd-networkd:
systemd-analyze critical-chain zerotier-one.service

zerotier-one.service @13min 6.079s
└─network-online.target @7.650s
  └─systemd-networkd-wait-online.service @735ms +6.915s
    └─systemd-networkd.service @694ms +39ms

Overwriting that may make zerotier-one start before network is up which is bound to cause problems, like:
https://github.com/zerotier/ZeroTierOne/issues/1259
As per https://wiki.archlinux.org/title/Systemd#Running_services_after_the_network_is_up

If using systemd-networkd, systemd-networkd-wait-online.service is enabled together with systemd-networkd.service. Check if this is the case with systemctl is-enabled systemd-networkd-wait-online.service. If it is not enabled, then reenable systemd-networkd.service.

ok you are correct :) thanks for the ticket. Patch coming RSN.


USB and schematics

It seems that USB connector and circuitry is missing in schematic. Also on PDF posted some days ago as reply at issue #236 doesn't have it

Thank you @lewisxhe . My fault I didn't realize it was the connector and not a charger chip.
Thanks


weechat: Upgrade scripts

This is long overdue, but I wonder if a better approach would be to just have scripts auto install from upstream on first startup on weechat with '/plugin install ...'

@lrvick What I did in my own dotfiles is have weechat/scripts as a submodule.
If we don't want that, having scripts autoinstall would be weird/icky.  We can, however, make weechat upgrade scripts on first start, which might involve less hackery.

that would be a simple command for startup, /script update;/set <whatever option runs commands on startup> ""

@RyanSquared My issue is more that you end up with a dirty dotfiles repo immediately.

unless we kept scripts completely out of the repo? it would be simple to pump some commands into the FIFO to install scripts.

@RyanSquared At that point, it becomes install on first run.
The problem is that your installed scripts (and even more so, your autoloaded scripts) are definitely part of your weechat config and ought to be versionned.  I think I would be happier with using a submodule, since it means we (and users) can much more easily update scripts.

Closing in favor of submoduling weechat/scripts.


Optimization

@emanuelschuetze Please test this branch (test functionality and compare performance with numerous clients). Some details are still missing:

[x] default password handling
[x] handling of hidden agenda items
[x] removing of one old rest api method
[x] Rebase on top of squished migrations because of error during database creation.

moving of translations See #2025

Can you rebase the squihsed migrations please? I can't test this with a fresh db...

Translations checked in /rest/: only motion logs are important. config labels comes with option request (not via auto update). All other apps (motions/assingments/mediafiles/agenda) has no special translations in auto update data. So you can create a new issue (for 2.1) to fix the motion log translation after auto update (that not the browser language is used from user who triggers the auto update).

As discussed: I tested it with 100 clients (50 open tabs with opened projector sidebar) which opens /agenda with 20 items.
I changed one item. Now only a PUT request is send. No 100 GET requests as before (on master).
So it is a good performance improvement!

Code looks ok for me after quick code review. And works as expected...
@ostcar Can you make also a quick review because these are important changes for our auto update process. Thx.

looks promising! ok

Are this PR ready for last test? Can you rebase it?

Ready for last test. I rebase it later.

I make again some performance tests:
Opened ~40 /agenda/ tabs, imported ~10 agenda items and numbering all items.

with current master: a huge number of GET requests goes to server. CPU load goes up to 100%!
with this branch: Only some post request for import/numbering goes to server, no longer a huge number of GET requests. CPU load goes up to ~50% (while import) and only ~20% (while numbering).

Summarized a very good performance improvement! Good work!
Please rebase and merge!


How do I cite F*?

The fstar-lang website seems to be down for me at the moment, and I'm not entirely sure what to cite to reference F*. @nikswamy and @catalin-hritcu, ideas?

We know that the server is down (#381), sorry for the inconvenience. For a temporary clone of the website please visit: http://fstar.gforge.inria.fr
To answer you question, here it goes:
@misc{mumon,
  author = {Nikhil Swamy and
            Catalin Hri\c{t}cu and
            Chantal Keller and
            Aseem Rastogi and
            Antoine Delignat-Lavaud and
            Simon Forest and
            Karthikeyan Bhargavan and
            Cédric Fournet and
            Pierre-Yves Strub and
            Markulf Kohlweiss and
            Jean-Karim Zinzindohoue},
  title = {Dependent Types and Multi-Monadic Effects in {F*}},
  url = {https://www.fstar-lang.org/papers/mumon/},
  year = {2015},
  month = jul,
  howpublished = {Draft},
}

Awesome, thanks!


Receiving support?

Hi there! This isn't a issue but I didn't know where to ask!
Are you accepting donations or supports? Because may you got some money hilo, but there is no donate button o something like that.
I don't trying to spam you, but I want to invite you to beerpay.io, a simple platform to monetize open source projects, like Bulma.
I know that the open source is free, but it's okay if someone want to contribute in other way.
Thanks for this work!

@Francolpm , very appreciate.  But I suppose we don't need it now for the great support from our corp.


Run NormalizeScore correctly

What type of PR is this?

/kind bug
What this PR does / why we need it:
Scores from NormalizedScore are not recorded correctly, because simulatorPlugin.ScoreExtensions() returns internal plugins's ScoreExtensions(). We should use simulatorPlugin.NormalizeScore() in ScoreExtension, so should return simulatorPlugin itself.
Which issue(s) this PR fixes:

Fixes #89
Special notes for your reviewer:
/label tide/merge-method-squash

/lgtm