Delete-button symbol and placement optimisation

To avoid hitting the wrong element on mobile screens I suggest to move the delete-button to the right border, away from the checkbox on the left.
I have replaced the × character on the button by a minus-sign-graphic in the background for two reasons:

screenreaders (Safari VoiceOver) announce the × as "times"
a graphic similar to × is used for closing tiddlers in several places in TW5, but here we remove

Additionally I think that highlighting list items targeted by checkbox/button could help users. Note: In order to achieve the red highlight for the delete button I had to change the order of the elements (now: checkbox > delete-button > item-body (label for checkbox).
I have set up a demo for you (and possibly @TiddlyTweeter) to check out here: http://tid.li/tw5/test/checklist-05.html
OT: You will also find a button there to hide checked items (globally) as suggested in https://github.com/tgrosinger/tw5-checklist/issues/17
Let me know what you think!

I like that. And not just because of the issue over "X". But because putting any controls on the left tends to bring in a slight visual dissonance. Seeing ONLY a checkbox on the left is, IMO, a visual improvement & small clarification of functioning.
When I saw the demo I immediately formed a further suggestion on styling for print ...
8 - STYLING FOR PRINT should remove "+", "-" and the "New Item" entry box.
Use case: Someone printing out a shopping list. Or printing a work tasks list. They need the checkbox, but they don't need anything else. Those controls are redundant on paper.
I'm not sure how difficult this is to do, but I think it would be an enhancement.
Josiah

@telmiger I like the idea, and the check boxes being right next to delete has been an issue for me on mobile. Could we tone down the bright red to a softer or less-saturated red?

I agree with Tony. The Red is too amped. Given nothing else is like that in
the interface a subtler colour will work just as well.
On 30 May 2017 at 16:03, Tony Grosinger<EMAIL_ADDRESS>wrote:

@telmiger https://github.com/telmiger I like the idea, and the check
boxes being right next to delete has been an issue for me on mobile. Could
we tone down the bright red to a softer or less-saturated red?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tgrosinger/tw5-checklist/issues/32#issuecomment-304888191,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbfrTfrpcB1-uOUL2XU8f_YZtOWhmOLQks5r_CGmgaJpZM4NqIyl
.

I will reduce opacity to 25% next time my laptop is online.
TiddlyTweeter<EMAIL_ADDRESS>schrieb am Di. 30. Mai 2017 um
16:57:

I agree with Tony. The Red is too amped. Given nothing else is like that in
the interface a subtler colour will work just as well.
On 30 May 2017 at 16:03, Tony Grosinger<EMAIL_ADDRESS>wrote:

@telmiger https://github.com/telmiger I like the idea, and the check
boxes being right next to delete has been an issue for me on mobile.
Could
we tone down the bright red to a softer or less-saturated red?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/tgrosinger/tw5-checklist/issues/32#issuecomment-304888191
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AbfrTfrpcB1-uOUL2XU8f_YZtOWhmOLQks5r_CGmgaJpZM4NqIyl
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tgrosinger/tw5-checklist/issues/32#issuecomment-304905234,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADC-xzlHCn_T4dd8-RtthebZ7pfduUy5ks5r_C5BgaJpZM4NqIyl
.

The demo is updated. Besides a softer red color I applied print styles as suggested by @TiddlyTweeter so all unnecessary elements will not appear on paper.
I made also a short test with my ToDoNow/Listreveal plugin: It seems, that I can remove all additional styling for presenting checklists that I had to use until now. :–)

Its looking good. And thankyou on the print styling. I really appreciate
that. Simple change, but good.
On 30 May 2017 at 21:47, Thomas Elmiger<EMAIL_ADDRESS>wrote:

The demo https://tid.li/tw5/test/checklist-05.html is updated. Besides
a softer red color I applied print styles as suggested by @TiddlyTweeter
https://github.com/tiddlytweeter so all unnecessary elements will not
appear on paper.
I made also a short test with my ToDoNow/Listreveal plugin: It seems, that
I can remove all additional styling for presenting checklists that I had to
use until now. :–)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tgrosinger/tw5-checklist/issues/32#issuecomment-304987733,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbfrTWjO-vlorGKs5MKmgn2G4WYdhswoks5r_HJogaJpZM4NqIyl
.

I think this is resolved in the new version 0.0.14. (Print CSS is in #38)


AsyncRunnerTest.asyncRunnerWithBatchUpdateCommitAborted might be flaky

I just saw this failure in one of the presubmit runs. I haven't seen it before so I assume it's a flaky test.

Here's another one, but this time it's AsyncResultSetImplStressTest(sponge_log).cancel[rows = 5].


getresgid values different from C

Hello. libc::getresgid is giving me seemingly incorrect values. I am on Linux x86_64: Fedora 28, kernel 4.17, X86_64 (Thinkpad T450 with Intel i5 processor).
Rust code:
let mut rgid = 0u32;
let mut egid = 0u32;
let mut sgid = 0u32;

unsafe { libc::getresgid(&mut rgid, &mut egid, &mut sgid) };

println!("{} {} {}", rgid, egid, sgid);

Rust output:
65534 65534 65534

C code:
static gid_t egid, rgid, sgid;
getresgid(&rgid, &egid, &sgid);
printf("Result of getresgid():\n\t%u %u %u\n", egid, rgid, sgid);

C output:
Result of getresgid():
        1000 1000 1000

Bash output:
$ id -g
1000

Could this be a bug?

Can you poke around the executables to see if there's a difference? Does strace report different syscalls? Does your system have a different symbol for getresgid?

Thanks for the help Alex. Embarrassingly :cry: , I forgot that my call to getresgid was in a namespace:
unshare(...)
getresgid(...)

So the values were correct, for the namespace I created with unshare.


screens/log: always scroll the whole screen when detached.

When scrolling in a detached state, we will always on a move() unless we're in the beginning of the entries. To fix this with the current implementation, we would change at_first_entry in move() to be true when we're on the first entry + how many entries fit on the screen.

Later in development, I'll want to implement this kind of scrolling in item_details also. I'll cross that bridge when I get there, and create some new class to reflect the scrolling behavior that both screens will inherit from.


Add beginning of year biomass for 2017 in Tables 21 and 25

An AP member asked if we could report beginning of year biomass for 2017 in Tables 21 and 25. The numbers at age (Table 20) includes 2017 since these are beginning of year values that don't depend on catch. For biomass at age (Table 21), the 2017 values depend on assumptions about weight at age, but since that assumption is already being made in the forecast, I don't see a problem adding those values.
I added this to tables-ages.r, which made the code a little bit messier, but seems to result in the 2017 values being added without messing up anything else.
I will commit the changes and we can discuss next week whether to make available on Google Drive the CSV files in /doc/out-csv/ (perhaps combining them into a single Excel file).

Sorry, foolishly didn't look at network to see changes that others had made in the files that I just committed. I think I just successfully merged them but am building again to check.

I'm closing this issue, which is now complete.
Also, I uploaded to the JTC Google Drive folder a file called "Hake Assessment 2017 Tables 20-25.xlsx"
which just combines the CSV files from out-csv into a single Excel file with captions copied from the PDF of the assessment document. Not as fun as creating things in knitr but didn't take long.
Since this is a copy of the information already in the document, I'm planning on transferring this file to the JMC Google Drive tomorrow morning since I think folks are interested in working with these numbers in Excel without having to copy them manually. If there is interest in having this repeated in future years we can explore automating the creation of the Excel file using one of the various R packages available for this purpose.


Failed imports and npm newbie issues.

There are some people who downloaded this new package already, presumably from Google searches. I haven't promoted the package yet, so this is kind of cool. But those early installers will have some trouble.
This is the first package I've published to NPM, and I'm learning how to do it correctly. I've noticed that importing the package that's currently publish 0.1.0 will give some problems with the file imports failing at run-time. And my ability to run a simple 'npm publish' to publish a fixed version is failing for devops/auth reasons.
I'll fix it. Just bear with me.

Okay, I've successfully imported the package from NPM, used it in a web project. The package seems to be usable now.


Add CaaS CRD operator role

We are missing injecting the azimuth-sshkey... it might be better to auto generate that!

Superceded


[Task] Jail System

Task Description
also will need that

supposed to be tied w/ the crime commands. Since there is no need for it, we dont need this


Added default op level

Description
Added default op level so server admins can set it for test servers.

Testing
Add default_op_level=3 under commands section in features.toml
Can now do everything except stop server!

Checklist
Things need to be done before this Pull Request can be merged.

[x] Code is well-formatted and adheres to project style guidelines: cargo fmt
[x] Code does not produce any clippy warnings: cargo clippy
[x] All unit tests pass: cargo test
[x] I added new unit tests, so other people don't accidentally break my code by changing other parts of the codebase. How?

This only adds an option for server administrators to change the default behavior. The configuration.toml remains unchanged.

Oh, I tough this was already implemented but it wasop_permission_level which only specifies the level you get from OP.
Thanks @OfficialKris for implementing the default level, especially useful for the test server :D


Is it secure to start portainer container by mounting docker.sock unix socket inside the container?

Using Portainer in development.
We map the docker socket inside the portainer as per the document and use portainer to monitor the containers on the host.
docker run -d -p 9000:9000 -v /var/run/docker.sock:/var/run/docker.sock portainer/portainer
Our security group flagged this approach and asked us to remove the mount /var/run/docker.sock.
Question:
How can I run Portainer in docker container without docker volume mount?  I think, this is not possible.  I am not sure how should I respond to my security group.

Hi there,
First of all, in order to use the latest version of Portainer please use the image portainer/portainer-ce.
And the reason why Portainer is mounting /var/run/docker.sock is so that it can use the Docker API to, among other things, inspect the containers that are running in your environment.
However, it depends a little bit on what the concern of your security group is. For instance if they want to avoid that Portainer is running under the root user, there are ways to run it rootless: https://github.com/portainer/portainer/issues/2744
https://www.portainer.io/blog/portainer-and-rootless-docker
Hope that helps.

You can also use tcp://:2375 (without TLS) or tcp://:2376 (with TLS), provided you have them enabled on docker host.

please don't use either tcp:// option - its the least secure way to access the Docker API, and its very much supposed to be deprecated.

Hi there,
First of all, in order to use the latest version of Portainer please use the image portainer/portainer-ce.
And the reason why Portainer is mounting /var/run/docker.sock is so that it can use the Docker API to, among other things, inspect the containers that are running in your environment.
However, it depends a little bit on what the concern of your security group is. For instance if they want to avoid that Portainer is running under the root user, there are ways to run it rootless: #2744
https://www.portainer.io/blog/portainer-and-rootless-docker
Hope that helps.

I checked with security group.  Their tool flagged my system running portainer which mounts the docker socket inside the container. They have strict policy to not to allow any container with docker.sock mounted which keeps the door open for security attack.  Using TCP/TCP with TLS is not recommended by docker itself, hence it does not look like a viable alternative either.

there's no really good answer if your security group are not happy with a Docker management tool being able to manage Docker.
All tools that help you manage Docker, necessarily do so by connecting to the Docker socket - and while we could fake it by running an agent on the host, that the Portainer then talks to - the security profile hasn't changed.

Thank you!

@MacNale what did you end up doing in the end?

@MacNale what did you end up doing in the end?

Unfortunately, I had to remove portioner.
Not related - We are moving int in the direction of adopting podman..

@MacNale Have you see that Portainer works with Podman? :) https://github.com/portainer/portainer/issues/2991

Can use rootless docker too, so you dont bind to root, only your user root

@SvenDowideit @ncresswell - I was not aware of podman support in portainer. I will try now.

Hi, looks like there is an option to switch Portainer from docker.sock to more secured socket_proxy. Detailed guide can be found here


Search result in popup

Hi There,
I am looking to replace my existing search option with Algoia but i am not able to find any widget where search result display in popup as attached, can you please here?

Thanks,
VIneet

Hi @vkaushik001 ,
If I understand correctly, as you type the search keyword, that popup is displayed and you refine the search with categories, and things inside the popup, right?
We have autocomplete library, but in this case, we can even just wrap the search results and facets in a box like that. It's not something out of the box, but here is a simple example:
https://codesandbox.io/s/blissful-herschel-2qfxv?file=/src/app.js:203-421
Would this work for you? Let me know if you have other needs, then we can find out what's the best way to implement them.

Hi There,
Yes that is the same thing I was looking for and now it’s working for me but there is an another thing I would like to know as below:
How I can make render search result to another page if I click on search icon?
Regards,
Vineet Kaushik
Apex Tier Technologies
From: Eunjae Lee<EMAIL_ADDRESS>Sent: Thursday, October 29, 2020 4:25 PM
To: algolia/instantsearch.js<EMAIL_ADDRESS>Cc: vkaushik001<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [algolia/instantsearch.js] Search result in popup (#4554)
Hi @vkaushik001 https://github.com/vkaushik001  ,
If I understand correctly, as you type the search keyword, that popup is displayed and you refine the search with categories, and things inside the popup, right?
We have autocomplete library, but in this case, we can even just wrap the search results and facets in a box like that. It's not something out of the box, but here is a simple example:
https://codesandbox.io/s/blissful-herschel-2qfxv?file=/src/app.js:203-421
Would this work for you? Let me know if you have other needs, then we can find out what's the best way to implement them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/algolia/instantsearch.js/issues/4554#issuecomment-718647737 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE2F47K5RLA2F673BM4TPDSNFCW3ANCNFSM4TDKCGNQ .  https://github.com/notifications/beacon/AAE2F4ZAGZC2GLR2KYDKRYDSNFCW3A5CNFSM4TDKCGN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFLK3DOI.gif

Hi All,
I have implemented autocomplete search on my demo website (https://blooming.offyourfeet.com/) but search is not working on Safari browser and apple devices.
Resources I am using as follows:

Code HTML:

                        <input type="text" class="form-control clerksearch aa-hint" style="position: absolute; top: 0px; left: 0px; box-shadow: none; opacity: 1; background: none 0% 0% / auto repeat scroll padding-box border-box rgb(255, 255, 255); border: 1px solid rgb(245, 255, 245) !important; padding: 6px 12px !important;" readonly="" aria-hidden="true" autocomplete="off" spellcheck="false" tabindex="-1"><input name="ctl00$UCHeader1$ctl00_livesearchAlgolia" type="text" id="ctl00_UCHeader1_ctl00_livesearchAlgolia" class="form-control clerksearch aa-input" placeholder="What are you looking for today?" style="position: relative; vertical-align: top; background-color: transparent; border: 1px solid rgb(245, 255, 245) !important; padding: 6px 12px !important;" autocomplete="off" spellcheck="false" role="combobox" aria-autocomplete="both" aria-expanded="false" aria-owns="algolia-autocomplete-listbox-0" dir="auto">
fic

                            <svg class="aa-input-icon" viewBox="654 -372 1664 1664">

                            <path d="M1806,332c0-123.3-43.8-228.8-131.5-316.5C1586.8-72.2,1481.3-116,1358-116s-228.8,43.8-316.5,131.5  C953.8,103.2,910,208.7,910,332s43.8,228.8,131.5,316.5C1129.2,736.2,1234.7,780,1358,780s228.8-43.8,316.5-131.5  C1762.2,560.8,1806,455.3,1806,332z M2318,1164c0,34.7-12.7,64.7-38,90s-55.3,38-90,38c-36,0-66-12.7-90-38l-343-342  c-119.3,82.7-252.3,124-399,124c-95.3,0-186.5-18.5-273.5-55.5s-162-87-225-150s-113-138-150-225S654,427.3,654,332  s18.5-186.5,55.5-273.5s87-162,150-225s138-113,225-150S1262.7-372,1358-372s186.5,18.5,273.5,55.5s162,87,225,150s113,138,150,225  S2062,236.7,2062,332c0,146.7-41.3,279.7-124,399l343,343C2305.7,1098.7,2318,1128.7,2318,1164z"></path>

                        </svg>Search

Javascript Code:

Regards,
Vineet Kaushik
Apex Tier Technologies
From: Eunjae Lee<EMAIL_ADDRESS>Sent: Thursday, October 29, 2020 4:25 PM
To: algolia/instantsearch.js<EMAIL_ADDRESS>Cc: vkaushik001<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [algolia/instantsearch.js] Search result in popup (#4554)
Hi @vkaushik001 https://github.com/vkaushik001  ,
If I understand correctly, as you type the search keyword, that popup is displayed and you refine the search with categories, and things inside the popup, right?
We have autocomplete library, but in this case, we can even just wrap the search results and facets in a box like that. It's not something out of the box, but here is a simple example:
https://codesandbox.io/s/blissful-herschel-2qfxv?file=/src/app.js:203-421
Would this work for you? Let me know if you have other needs, then we can find out what's the best way to implement them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/algolia/instantsearch.js/issues/4554#issuecomment-718647737 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE2F47K5RLA2F673BM4TPDSNFCW3ANCNFSM4TDKCGNQ .  https://github.com/notifications/beacon/AAE2F4ZAGZC2GLR2KYDKRYDSNFCW3A5CNFSM4TDKCGN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFLK3DOI.gif


New Feature Request: ISO8583 to Upstream HTTP JSON Mapping

Hi,
It would be nice to incorporate a reverse functionality to existing HTTP JSON Service wherein an upstream service could be a REST interface and a ISO8583 request could be mapped to REST field by name such as
ISO Request:
Message Type Indicator [0].......................1210
Bitmap [1].......................................F23005418AE080000000000004000000
Primary Account Number [2].......................1140463000
Processing Code [3]..............................400201
Amount, Transaction [4]..........................50100
Transmission Date and Time [7]...................20170627104904
Upstream Mapping:
{
"0": "1210",
"1": "F23005418AE080000000000004000000",
"2": "1140463000",
"3":  "400201",
"4": "50100",
"7": "20170627104904"
}

Hi Shoaib!
I have some doubts if there will be any reason using SocketQueue in this scenario. Not sure if there is any kind of system that supports HTTP JSON ant doesn't support ISO8583.


Trigger master branch of ops website deploy

Thank you for contributing!Preview these changesLink expires: Fri Oct 19 07:00:55 UTC 2018


Kramdown warnings

Summary
This PR does two things in two commits:

tell which item and rep produces a kramdown warning
implements warning filtering (see #675) as kramdown itself as no warning switches

To do
The :warning_filters array should be documented on https://nanoc.ws as part of the filters reference documentation.

Looks good! There’s a couple of style issues that Travis CI complains about still.

Does it make sense to provide the warning filters via the configuration file, rather than arguments to the filter call? That’d make the dup dance unnecessary, and I guess it’d avoid having to copy the filter warnings if you call the :kramdown filter more than once…

I took your comments into account.
Well in my setup, I was already doing e.g.
# erb filter options
erb:
  trim_mode: '<>'

and then when filtering
filter :erb, @config[:erb] || {}

Are there other filters reading straight from @config ?

This is awesome, I've wanted this myself. Thanks @gpakosz!

I’m OK with leaving it as a filter argument, as it’s more flexible, and still leaves open the option for using the configuration in the way you described.
Is this still WIP or is it ready to go?


AST compressing

Generated functions encode the programs into types, in this way the world age problem got solved.
However, the encoded types finally become too large and crash the compiler: https://github.com/thautwarm/GeneralizedGenerated.jl/issues/46
An alternative solution is reducing the encoded types but keeping the information.
So far no idea of this approach but just now chatting with some one inspired me and I now thought this deserves some research.
A straightforwaed idea is constructing a bi mapping from a Julia AST to a flatten byte sequence, and the latter can be used as a value type.

If this works, https://github.com/thautwarm/GeneralizedGenerated.jl/issues/46 can get resolved.


Works not with Hitman 3 (for me)

Hello,
I tried this mod with Hitman 3. For me, it does not work. I put the files in the main folder. But in the dlsstweaks.log file, it only reads:
[2023-02-23 18:42:25.784] [info] DLSSTweaks v0.123.11, by emoose: DLL wrapper loaded, watching for DLSS library load...
In other games like Ready or not, it works fine. What Did I do wrong? Please help.
Thanks!

Maybe the game is loading our DLL in too late, after DLSS was already loaded in, could try renaming our DLL to one of the other ones mentioned in INI, hopefully game might load one of those in earlier.

Sadly, it does not work with any of the proposed renamed *.dll files. Any suggestions?

Just to make sure, do you have DLSS enabled in-game? probably only loads in if that's enabled.
Also are you using recent nvidia drivers? AFAIK older ones are missing things that DLSSTweaks need to work.

Yes, DLSS in enabled in-game and I use the most recent Nvidia drivers.

Did you put the files into "Retail" folder? Should definitely work there.

If I put the files in the "Retail" Folder, it still does not work. Then, the dlsstweaks.log file stays empty and has no entries at all.

The log indeed doesn't contain anything (well, I guess that shouldn't be), but it should still work:

I just tested it with this overlay, and it really works (DLAA enabled), even though the log file stays empty.
Thanks for the help. How do I change the DLSS preset to F in the ini.file?


Asthma open source calendar re-host on new scheduler

Implement an activity indicator
Make bracket spacing consistent
Add observer for activity completion notification
Update fetch requests for new scheduler

@YuanZhu-apple  Comments addressed. Thanks.

@YuanZhu-apple  Latest commit requires a couple of updates to AppCore. Will send a PR shortly.

@YuanZhu-apple  done

@YuanZhu-apple Updated


support hardhat (buidler v2)

release notes: https://github.com/nomiclabs/hardhat/releases/tag/hardhat-v2.0.0
migration guide: https://github.com/nomiclabs/hardhat-ts-plugin-boilerplate/blob/master/MIGRATION.md

I've released hardhat-abi-exporter version 2.0.0.  Let me know if you encounter any issues.  Typescript support has been removed, for now.

It's currently very broken.  I'll fix it now.

Seems to be working now.

thanks for the quick response :)
unfortunately, it's not fully working, only for contracts on the root of the contracts folder. hardhat keeps a complex structure on the artifacts directory.
i think the best way is to use the new hre.artifacts.getArtifactPaths()

I got ahead of myself trying to release it quickly.  I'll try again.

Fixed in version 2.0.2, which I am unable to publish for 24 hours due to NPM restrictions.  For now, you can try adding the repository as a dependency.

thank you very much, now it works :)
i would like to make some suggestions:

follow the same folder structure as the contracts folder

no export for external contracts (from node_modules), or maybe via a config flag that is off by default
contracts as the root of abi folder
no intermediate folder with the original .sol filename. this seems relevant for hardhat because it has more than one file for each contract, which is not the case for abi.
this makes for a much cleaner require/import: ./abi/mydir/MyContract.json instead of ./abi/contracts/mydir/MyContract.sol/MyContract.json

format json output, by default (JSON.stringify(abi, null, 2))

heavily improves readability
heavily improves diffs and version control. this is probably the main reason for not adding the whole artifact to version control
follows hardhat style

Thanks for the suggestions.  Here are my thoughts.
ABIs from node_modules should still be included because it's common to need access to, for example, an ERC20 ABI, which is likely imported from a package.  It is recommended to use the only option to choose which ABIs to export.  However, an option to skip imported contracts is a good idea, and I'll consider adding it soon.  Perhaps the only and except options should use regexp-based matchers instead.
The intermediate *.sol directory is still necessary in some cases, because a single .sol file can contain multiple contracts.  If two different .sol files in the same directory contained contracts of the same name, there would be conflicts.  It is recommended to use the flat option if possible, avoiding the mess altogether.
You're right about the readability.  I will look into formatting the JSON output.

you're right, my first suggestion can cause conflicts. in the interest of cleaner imports, combining "skip imported" + flat would be a good option, but it's too drastic for me as i need to keep the internal folder structure of my contracts. is it possible to have an option to keep the contracts structure (no abi/contracts, no *.sol/*.json)?

The previously mentioned fix is released in 2.0.3.  I'll look into adding the new options soon.  Not exactly sure how I'd match the contract directory structure, but I'll think about it.
If you feel that I'm taking too long, please open a new issue to remind me.


feat: Support wasmedge plugins

It's a feature PR
By the way, please note that this feature currently only functions when dynamically linking the WasmEdge library to the WasmEdge shim.
For building this, you can use the following command:
cargo build --package containerd-shim-wasmedge --no-default-features
In addition, I have provided all the WasmEdge runtime demo cases via containerd (here), including the wasinn plugin demo related to this feature. Considering that these demos may only be supported with the WasmEdge shim, I plan to relocate and maintain them under the WasmEdge or Second State Org's repository. At the same time, I will ensure that they run demos daily in CI and guarantee that these demos are always executed based on the latest upstream code.

Where are the plugins supposed to be found?
In the host? Or in the container image?
If inside the container image, I don't see why we need to fiddle with the mount points, as libcontainer will have already handled that for us.
If it's in the host, by this point it's too late and the process doesn't have access to any path ouside the container root.

Where are the plugins supposed to be found? In the host? Or in the container image?
If inside the container image, I don't see why we need to fiddle with the mount points, as libcontainer will have already handled that for us. If it's in the host, by this point it's too late and the process doesn't have access to any path ouside the container root.

The plugin is a .so file loaded through dlopen, and it is not specifically restricted to running within either the host or the container. As mentioned earlier, this mount aspect belongs to legacy code to handle filesystem for wasm, and I will remove it and modify the way my example is used.

The statically linked version is also poised to support plugin functionality. However, the changes made rely solely on the Wasmedge library. Therefore, after merging this PR, upstream will only need to await the release of the new SDK version to enable it in both ways.

LGTM


Website can't make JIT changes if markdown files are inside of a folder

What version of mystjs are you using?
v0.1.9
How did you install myst?
npm
What operating system are you using?
Mac
Which area is this feature request for?
Website User Interface
Describe the Bug
The sections in my manuscript are written in different markdown files inside of the sections/ folder.
When I use myst start, the website renders just fine. However, whenever I edit my section files, the website does not update with the changes and I see the following warning message in the console:
File is not in project: sections/methods.md
Expected Behavior
The website should update to show the changes.
To Reproduce

Create a folder called sections/
Create markdown file inside the folder, e.g., sections/methods.md, and write something in it
Run myst start
Edit the sections/methods.md file
The website will not show the changes and the warning message should appear in the terminal

@eurunuela - I could not recreate this bug exactly as you describe; editing the existing sections/methods.md while myst start was running worked as expected (site update, no warning). However, creating a new markdown file in the sections/ folder did match your description - warning and no update - until I cancelled and re-ran myst start.
I'll fix up that bug and see if that resolves things for you.

Hey @fwkoch! I'm still seeing this bug in v0.1.17...
Here's a screen recording: https://www.loom.com/share/5c38a68c9d7b475bad2066c62534f30a

Turns out I'm having this issue even when the different files are in the main folder as opposed to being in a sections folder...

Any updates on this @rowanc1 @fwkoch ?


Text field loses its value after scrolling out of view

Run Gallery -> Text fields
Rotate into landscape mode
Enter some text into the Name field and dismiss the keyboard
Scroll to the bottom of the form, and then scroll back to the top.  The Name field will now be blank.

I noticed that the framework is disposing the EditableTextState when the field scrolls out of view.  Is that a new behavior and is it intentional?
EditableTextState.dispose() also hides the keyboard, so the dispose might be causing other bugs related to showing/hiding the keyboard during scrolling and relayout (https://github.com/flutter/flutter/issues/9221, https://github.com/flutter/flutter/issues/9231)

@abarth would know. :)

Duplicate of #8418

controller: new TextEditingController(text: person.name),
and Name field will not be blank


Add a new row dynamically

I haven't seen on your demo any way to add a row dynamically. That would be a great feature for this project and the Angular2 version.

Thanks for your comment!
Yes you right, there is no feature like that.
The best I can imagine is to use the contextual header and having the add button there.
But there are few questions which still needs to be clarify.
How to add new data?

with a callback what the client must provide with his/her own solution?
something built in (which is less flexible, since we don't really know the data types, nor the 'custom' dat a types if there is)

So I'm thinking of it and will come back to you after I figures it out.

I am also looking to add a new row, still a bit new to Angular I read the doc but could not figure out how to display something else but the table title.
Someone,
would it be possible to have a little code sample showing how to add the "Add" in the table header and trigger a basic action when clicking it?
Thanks for the awesome component btw.


Enable coverage reporting in CI

I already added a CODECOV_TOKEN so hopefully this'll just work :crossed_fingers:

LGTM!

It's interesting to look in the file explorer view and see which modules have most lines missing coverage. the AdqChannel component is currently the biggest (already tracked as #185).


A detailed installation steps with web is much needed

Can anyone guide on how to connect the ion with ion web app?

There is a guide in the wiki here and readme on ion-web-app. Let us know where you are stuck if you cant get it working.


Oberon

Helloworld in oberon
What does the program do ?

In what programming language it is written?

This pull request do not contains files in specific folders. Please fix it and reopen for help see https://help.github.com/articles/moving-a-file-to-a-new-location/


Refactor Api controllers default code into separate class

all this is generic and applies to all controllers, so it should be moved into a class called 'Api-Base'
Data_Project  = require '../backend/Data-Project'
express       = require 'express'

class Api_Project
  constructor: (options)->
    @.options      = options || {}
    @.data_Project = new Data_Project()
    @.router      = express.Router()
    @.app         = @.options.app

  add_Routes: ()=>
    @.router.get '/project/list'          , @.list

module.exports = Api_Project

this is now done
All express controllers extend the Api_Base class

like this


This is a bug bounty research. please ignore... dsjscp

This is a bug bounty research. please ignore... dsjscp

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix RubyCops warnings for Travis CI

mostly there are three changes:

change from %w() -> %w[]
change from '%i()' -> %i[]

Also, there are twp weird warnings from spec/:
➜  github-changelog-generator git:(travis-ci-fix) ✗ bundle exec rake
Running RuboCop...
Inspecting 27 files
........................W..

Offenses:

spec/unit/parse_file_spec.rb:17:9: W: Lint/AmbiguousBlockAssociation: Parenthesize the param change { options } to make sure that the block will be associated with the change method call. (https://github.com/bbatsov/ruby-style-guide#syntax)
        expect { parser.parse! }.to_not change { options }
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/unit/parse_file_spec.rb:56:1: C: Style/IndentHeredoc: Use 2 spaces for indentation in a heredoc by using <<~ instead of <<. (https://github.com/bbatsov/ruby-style-guide#squiggly-heredocs)
exclude-labels=73a91042-da6f-11e5-9335-1040f38d7f90,7adf83b4-da6f-11e5-ae18-1040f38d7f90 ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

27 files inspected, 2 offenses detected
RuboCop failed!

I exclude it but this is opened for discussion. I guess running functional test cases are more important than style check.

Chnages on lib/github_changelog_generator/generator/generator_processor.rb needs more attention. 😃

@Lucashuang0802 Did you see the notes I made about possible PRs you could do?

@olleolleolle looks like I forgot to press the Comment button. Yeah, let's divide it into a couple PRs. 😃

Thank you for your PR!
I'll close this as master had moved on.

@olleolleolle thanks for this check-in: https://github.com/skywinder/github-changelog-generator/pull/516. Let me see what else to do to fix the CI. 💯

@Lucashuang0802 We're green; you should be able to view the board at: https://travis-ci.org/skywinder/github-changelog-generator/branches

👍 oh, that's nice! @olleolleolle


Preparing 0.4.1

Summary
Prepping patch release.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 5 committers have signed the CLA.:white_check_mark: DanPuzzuoli:white_check_mark: Eric-Arellano:white_check_mark: to24toro:x: arthurostrauss:x: 1ucian0You have signed the CLA already but the status is still pending? Let us recheck it.


Update sbt, scripted-plugin to 1.7.1

Updates

org.scala-sbt:sbt
org.scala-sbt:scripted-plugin

from 1.4.9 to 1.7.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Applied Scalafix Migrations

org.scala-sbt:sbt:1.5.0

https://gist.githubusercontent.com/eed3si9n/57e83f5330592d968ce49f0d5030d4d5/raw/7f576f16a90e432baa49911c9a66204c354947bb/Sbt0_13BuildSyntax.scala
Documentation: https://eed3si9n.com/syntactic-scalafix-rule-for-unified-slash-syntax

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scala-sbt" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, scalafix-migrations, commit-count:n:2

Just like #17, not sure why that many files are changed here…


Remove jasmine dependency from jest-matchers

I brought equals from the checked in version of jasmine ( https://github.com/facebook/jest/blob/db0f3b4902ddb360020be8f737db1fae7a8508c4/packages/jest-jasmine2/vendor/jasmine-2.5.2.js#L2787-L3048 )
I did a few tweaks:

Imported isUndefined, isA and isDomNode
Moved all the functions that were defined inside of functions to the global "namespace"
Disabled lint and flow

❤


[SPARK-42900][CONNECT][PYTHON] Fix createDataFrame to respect inference and column names

What changes were proposed in this pull request?
Fixes createDataFrame to respect inference and column names.
Why are the changes needed?
Currently when a column name list is provided as a schema, the type inference result is not taken care of.
As a result, createDataFrame from UDT objects with column name list doesn't take the UDT type.
For example:
>>> from pyspark.ml.linalg import Vectors
>>> df = spark.createDataFrame([(1.0, 1.0, Vectors.dense(0.0, 5.0)), (0.0, 2.0, Vectors.dense(1.0, 2.0))], ["label", "weight", "features"])
>>> df.printSchema()
root
 |-- label: double (nullable = true)
 |-- weight: double (nullable = true)
 |-- features: struct (nullable = true)
 |    |-- type: byte (nullable = false)
 |    |-- size: integer (nullable = true)
 |    |-- indices: array (nullable = true)
 |    |    |-- element: integer (containsNull = false)
 |    |-- values: array (nullable = true)
 |    |    |-- element: double (containsNull = false)

, which should be:
>>> df.printSchema()
root
 |-- label: double (nullable = true)
 |-- weight: double (nullable = true)
 |-- features: vector (nullable = true)

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added the related tests.

also cc @WeichenXu123


YT: Batch Archive - Only 5 retries of 10 when fragment unavailable and set to abort on both (error and fragment)

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2019.04.30
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v']
[debug] Encodings: locale cp1250, fs mbcs, out cp852, pref cp1250
[debug] youtube-dl version 2019.04.30
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.14393
[debug] exe versions: ffmpeg N-93276-g3b23eb283a, ffprobe N-93276-g3b23eb283a

Verbose not possible. Cannot recreate the problem at this time.

[download]  22.7% of 114.18MiB at  1.31MiB/s ETA 01:07         [download] Got server HTTP error: The read operation timed out. Retrying (attempt 5 of 10)...
ERROR: unable to download video data: The read operation timed out

Description

The program only tried 5 times out of the default 10 when a fragment is unavailable. It is not conclusive whether the options --abort-on-error and/or --abort-on-unavailable-fragment have anything to do with this but the problem cannot be recreated at this time (the download succeeds without issue at the time of writing this)

Manually set frag retries higher. RTFM.

Manually set frag retries higher. RTFM.

Sure that's just the workaround, has nothing to do with the fact that this is a bug.

You didn't include the command. It's not a workaround it's a safety feature for bad internet connections or wonky days at YouTube.

You didn't include the command. It's not a workaround it's a safety feature for bad internet connections or wonky days at YouTube.

Still, what does that have to do with the bug?


cryptocarpic, druggier (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


Not entirely correct behaviour.

As this note stated descriptors must be bound to following bindings when there are more provided than array count of the binding point. Yet this is true only for Vulkan backend currently.
This could be a problem for portability.

dx12 and metal are doing this as well iirc. I think @kvark implemented it some time ago

I do recall actually covering this case. @omni-viral do you see the logic missing in D3D12/metal at the moment?

Yes. It doesn't work on metal

I confim.
This code works.
factory.write_descriptor_sets(
                once(DescriptorSetWrite {
                    set: &set,
                    binding: 0,
                    array_offset: 0,
                    descriptors: Some(Descriptor::Buffer(buffer.borrow(), Some(tilemap_uniform_range.start) .. Some(tilemap_uniform_range.end))),
                }).chain(once(DescriptorSetWrite {
                    set: &set,
                    binding: 1,
                    array_offset: 0,
                    descriptors: Some(Descriptor::Buffer(buffer.borrow(), Some(transform_uniform_range.start) .. Some(transform_uniform_range.end))),
                })).chain(once(DescriptorSetWrite {
                    set: &set,
                    binding: 2,
                    array_offset: 0,
                    descriptors: Some(Descriptor::Sampler(&self.sampler)),
                })).chain(once(DescriptorSetWrite {
                    set: &set,
                    binding: 3,
                    array_offset: 0,
                    descriptors: Some(Descriptor::Image(self.tileset.view(), Layout::ShaderReadOnlyOptimal)),
                }))
            );

This segfaults
factory.write_descriptor_sets(
                once(DescriptorSetWrite {
                    set: &set,
                    binding: 0,
                    array_offset: 0,
                    descriptors: &[
                        Descriptor::Buffer(buffer.borrow(), Some(tilemap_uniform_range.start) .. Some(tilemap_uniform_range.end)),
                        Descriptor::Buffer(buffer.borrow(), Some(transform_uniform_range.start) .. Some(transform_uniform_range.end)),
                        Descriptor::Sampler(&self.sampler),
                        Descriptor::Image(self.tileset.view(), Layout::ShaderReadOnlyOptimal),
                    ],
                })
            );


Strange values after loading FCS3.1 file from Fortessa x20

I am attempting to load a file generated on a Fortessa x20 analyser which is in FCS3.1 format and am finding that the raw values loaded are very strange. Lots of negative values and converting to a.u. doesn't seem to help. I suspect it might be an issue with the file format and pulling out the wrong data type, but was wondering if this is a known issue and whether it can be easily fixed. Same problem does not occur with the fcs_parser module.

Hi Thomas,
This is the first time I'm hearing of an issue like you're describing. Could you send an example fcs file so we can investigate further?
Thanks.

Hey Tom,
I think the behavior you've described is the correct behavior, and it appears to me that FlowCal and fcsparser behave the same in this regard.
I have a Fortessa x20 FCS3.1 file from an old project, and both FlowCal and fcsparser yield the same number of negative values across all channels. I noticed, however, that only "area" channels (whose names end with "-A") have negative values. I believe modern machines do a baseline correction / background subtraction in the electronics prior to data storage, and this gives rise to these negative values. I've heard complaints of this around our lab, but I don't think we've tried in earnest to address it.
Also, converting to a.u. doesn't change the data from my file, and I think this is again correct behavior. The data type for my file is float ($DATATYPE='F'), so conversation to a. u. (FlowCal.transform.to_rfi()) simply divides by the amplifier gain (usually stored in the $PnG parameter), which is 1.0 for almost all of the channels in my file.
Hope this helps!

You are correct and thank you for the clarification. The negative numbers are an issue for some calculations, but I'll have to figure a patch for that separately.


Screenshot for README

Hey there Mavericks,
My name is Michael, I am a Microverse student and in Module 1 (Week 2). I wanted to know how you made your README screenshot for all devices in one picture. I can't seem to find a tool, can you kindly refer me.
All the best @michael-duke 😄

Hello Michael 😎
Thanks for reaching out. Nice to meet you👍
For your query, below are the two links I used to generate a multi-device website mock-up screenshots:

[x] Website Mockup Generator
[x] Multi Device Website Mockup Generator

There you go. Have fun with it.
All the best on your Microverse journey💪

Cheers 🥂
@mavericks-db

Thank you @mavericks-db


Error: ExecuteSQL: ExecuteSQL: Execute: cannot commit - no transaction is active

When loading for the first time, the error below is appearing. I'm having trouble understanding the issue. I attempted to change the version of jeep-sqlite, but the error persists. Could you please assist me in resolving this issue?

@Jayrag1990 are you using the latest release of jeep-sqlite if yes can you share your project on github

I'm currently utilizing the latest release of jeep-sqlite, and although I attempted to downgrade to a previous version, I encountered the same error. I've uploaded a demo of my project on GitHub for reference. https://github.com/Jayrag1990/jeep-sqlite-demo

@Jayrag1990 to work with typeOrm you have to remove the jeepEl.autosave = true; and manage yourself the saveToStore of the database.

https://github.com/jepiqueau/ionic-sqlite-typeorm-app/tree/main When I run this project it works perfectly with typeOrm. Do you know why?

@Jayrag1990 this project has been fully tested. Did you test it with the last release as i did not do it myself. If it works as it should try to look at the différences between your project and this project. Or take the project and modify it to suit your need. I am travelling so i do not have my laptop so i answer from my phone.

@Jayrag1990 In fact you have to upgrade to Capacitor5 and to the latest version of @capacitor-community/sqlite.
i test with the following package.json
{
  "name": "cr-app",
  "version": "0.0.5",
  "description": "CR is the App used to manage the capture of and transfer of information relating to police station or court attendances.",
  "author": "Jean Pierre Quéau",
  "license": "MIT",
  "homepage": "./",
  "scripts": {
    "ng": "ng",
    "start": "npm run copy:sql:wasm && ng serve",
    "build:web": "npm run copy:sql:wasm && ng build",
    "build:native": "npm run remove:sql:wasm && ng build",
    "watch": "ng build --watch --configuration development",
    "test": "ng test",
    "lint": "ng lint",
    "ionic:serve:before": "npm run copy:sql:wasm",
    "copy:sql:wasm": "copyfiles -u 3 node_modules/sql.js/dist/sql-wasm.wasm src/assets",
    "remove:sql:wasm": "rimraf src/assets/sql-wasm.wasm",
    "electron:install": "cd electron && npm install && cd ..",
    "electron:prepare": "npm run remove:sql:wasm && ng build && npx cap sync @capacitor-community/electron && npx cap copy @capacitor-community/electron",
    "electron:start": "npm run electron:prepare && cd electron && npm run electron:start"
  },
  "private": true,
  "dependencies": {
    "@angular-builders/custom-webpack": "^17.0.1",
    "@angular-builders/dev-server": "^7.3.1",
    "@angular/animations": "^17.0.2",
    "@angular/common": "^17.0.2",
    "@angular/compiler": "^17.0.2",
    "@angular/core": "^17.0.2",
    "@angular/forms": "^17.0.2",
    "@angular/platform-browser": "^17.0.2",
    "@angular/platform-browser-dynamic": "^17.0.2",
    "@angular/router": "^17.0.2",
    "@azure/msal-angular": "^3.0.12",
    "@azure/msal-browser": "^3.9.0",
    "@capacitor-community/sqlite": "^5.6.3",
    "@capacitor/app": "5.0.7",
    "@capacitor/browser": "5.2.0",
    "@capacitor/core": "^5.6.0",
    "@capacitor/haptics": "5.0.7",
    "@capacitor/keyboard": "5.0.7",
    "@capacitor/status-bar": "5.0.7",
    "@capacitor/toast": "5.0.7",
    "@ionic/angular": "^7.8.0",
    "@ionic/pwa-elements": "^3.2.2",
    "cordova-plugin-inappbrowser": "^6.0.0",
    "cross-var": "^1.1.0",
    "ionicons": "^7.2.2",
    "moment": "^2.24.0",
    "ngx-toastr": "15.2.2",
    "open": "^10.0.3",
    "path": "^0.12.7",
    "rxjs": "~7.5.0",
    "th-inappbrowser": "^3.1.1",
    "tslib": "^2.3.0",
    "typeorm": "^0.3.20",
    "zone.js": "~0.14.2"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "^17.0.0",
    "@angular-eslint/builder": "^17.0.0",
    "@angular-eslint/eslint-plugin": "^17.0.0",
    "@angular-eslint/eslint-plugin-template": "^17.0.0",
    "@angular-eslint/template-parser": "^17.0.0",
    "@angular/cli": "^17.0.0",
    "@angular/compiler-cli": "^17.0.2",
    "@angular/language-service": "^17.0.2",
    "@capacitor/cli": "^5.6.0",
    "@ionic/angular-toolkit": "^9.0.0",
    "@types/jasmine": "~5.1.0",
    "@types/node": "^12.11.1",
    "@typescript-eslint/eslint-plugin": "6.0.0",
    "@typescript-eslint/parser": "6.0.0",
    "copyfiles": "^2.4.1",
    "eslint": "^7.26.0",
    "eslint-plugin-import": "2.22.1",
    "eslint-plugin-jsdoc": "30.7.6",
    "eslint-plugin-prefer-arrow": "1.2.2",
    "jasmine-core": "~5.1.0",
    "jasmine-spec-reporter": "~5.0.0",
    "karma": "~6.4.0",
    "karma-chrome-launcher": "~3.2.0",
    "karma-coverage": "~2.2.0",
    "karma-coverage-istanbul-reporter": "~3.0.2",
    "karma-jasmine": "~5.1.0",
    "karma-jasmine-html-reporter": "~2.1.0",
    "rimraf": "^5.0.1",
    "terser-webpack-plugin": "^5.3.10",
    "ts-node": "^10.9.1",
    "typescript": "~5.2.2"
  },
  "browser": {
    "crypto": false,
    "stream": false
  }
}

and i modify the import of jeepSqlite  in the main.ts
import { enableProdMode } from '@angular/core';
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';

import { AppModule } from './app/app.module';
import { environment } from './environments/environment';

import { defineCustomElements as pwaElements} from '@ionic/pwa-elements/loader';
import { JeepSqlite } from 'jeep-sqlite/dist/components/jeep-sqlite';
import { Capacitor } from '@capacitor/core';

if (environment.production) {
  enableProdMode();
}
// --> Below only required if you want to use a web platform
const platform = Capacitor.getPlatform();
if(platform === "web") {
  // Web platform
  // required for toast component in Browser
  pwaElements(window);

  // required for jeep-sqlite Stencil component
  // to use a SQLite database in Browser
  customElements.define('jeep-sqlite', JeepSqlite);

  window.addEventListener('DOMContentLoaded', async () => {
      const jeepEl = document.createElement("jeep-sqlite");
      document.body.appendChild(jeepEl);
      jeepEl.autoSave = true;
  });
}
// Above only required if you want to use a web platform <--

platformBrowserDynamic().bootstrapModule(AppModule)
.catch(err => console.log(err));

i delete the node_modules, .angular folders and delete the package-lock.json  and then
npm run install
npm run build:web
npm start

and it works fine

I have the same issue. And just modify the import of jeepSqlite in the main.ts.
customElements.define('jeep-sqlite', JeepSqlite);
fix my problem


Improve db build

The db build module was a huge mess with only two functions and the main code on module-level. I have changed that. Now you can import it and only call the functions you want to execute.
Furthermore I have made some little changes to make it python3 compatible.
The db build has needed 22h on my computer (local settings).  All test passed, but I don't know if there are tests about the completeness of the db.

Thanks @nimaje. Gave this a quick glance and it looks awesome. This project is my first time coding in python so i've probably done a bunch of questionable stuff. I'll pull this down and check it out soon. Would you also be able to update the readme? Is there still a method that would allow us to run all methods?

yes. The methode in the readme should work, but I don't know django (__name__ has to be __main__ in the module that it run) . To run all methods there is build_all.

I noticed there was a duplicate call to PokemonGameIndex (at line 2048) so I edited your updated build .py for v2, @nimaje. I haven't used github in a while so I don't know if there's anything else I need to do besides fork and edit the file.

thanks @cstrachan88. such things were meant with mess (I think this was the only dublicate). And the use of enumerate to skip the header of the csv (not changed yet).

I've tested everything out and this seems to be good to go. I've made a small pull request with some documentation changes. Can you merge that in and then I'll merge this into the main branch. Thanks :)

I have made some changes because of the starimports in the examples and the list with the build functions was under the v1 section I have move it under the v2 section

whoops. Thats what I get from trying to sneak edit this stuff at work. Thanks @nimaje nimaje


adding artwork(admin panel)

the operator can add and save an artwork without uploading a picture.

@aghpr Done

still,it's possible @ehsan-g

I had this off first meaning you had to upload image, I saw this I changed it to optional... but I think this is an old issue which was not updated. Please check again I reversed it.


Conditionally write to the console when proxy events occur

Added an option for printing the logging statements since they are filling up my production logs and test runs.
Please take a look when you get a chance @chimurai

Thanks for the pull request @adeneui
I was actually working on this issue on the logger branch.
Had a feeling the console.log statements would start to itch someone sooner or later :)
What I had in mind was actually a more flexible setup.
I created two issues to share my thoughts.
#26: Allows you to control the logging levels. You'll be able to disable logging, but it will also allow you to log everything. This might be handy for debugging purposes.
#27: Allows you to set your own log provider, such as winston or log4js. This should greatly enhance the logging abilities. (Write log statements to file or database, etc...)
I hope the proposed setup will fit the needs of many.
Let me know what you think and feel free to comment.

Sounds good to me.  Do you have an idea of which one you would prefer (since they seem somewhat orthogonal)?  I can refactor this PR to accommodate #26 without much hassle.

I prefer the logger branch. It will implement #26 and #27.
The included tests should prevent regression in the logging functionality.
It's almost ready to be merged back.

+1
We throw JSON logs at ElasticSearch and it gets upset when the input isn't in the JSON format it's expecting.

Closing PR.
Functionality is implemented in #30


when is this going to be available?

my colleague talks about this, sounds awesome. looking forward to some code.

Q1 2023

Is there any updated estimate?


Can’t see device in HomeKit

What issue do you have? Please be as thorough and explicit as possible.
I installed the plug-in per the directions. Created the API codes. The device shows up in Homebrodge but I cannot see it in HomeKit.
Details of your setup.

Do you use (1) Homebridge UI-X (2) Homebridge CLI or (3) HOOBS?

Homebridge

Which version of Homebridge/HOOBS do you have?

Most current.

Which platform do you run Homebridge/HOOBS on (e.g. Raspberry Pi/Windows/HOOBS Box)? Please also mention your version of Node.js/NPM if known.

Mac Mini

Which version of this plugin (homebridge-flume) do you have? Has the issue started since upgrading from a previous version?

Newest version. Just download yesterday.

Which Flume devices do you have that are causing issues? Please include product models if applicable.

Water sensor.
Please paste any relevant logs below.

Hi @ndradar
Which iOS version?

16.0.2 with iPhone 14 Pro. I haven’t checked the computer yet. I will when
I get home.
On Thu, Oct 6, 2022 at 12:41 Ben @.***> wrote:

Hi @ndradar https://github.com/ndradar
Which iOS version?
—
Reply to this email directly, view it on GitHub
https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1270594614,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE572TELJZQWPLY47ZIXMM3WB4TP3ANCNFSM6AAAAAAQ66DHM4
.

I have heard reports that on iOS 16 these devices which detect something (water, motion, contact, etc) don't appear in the Home app unless they are activated.
I think you may be able to check if the accessory exists by going to the following in the Home app on iOS 16:
Home settings -> Home Hubs & Bridges -> {HB/Flume Bridge} -> Accessories
Leak sensor should be in the list there

PS
GO IRISH!!!
😀

Yeah I had looked there and it’s not there.
On Thu, Oct 6, 2022 at 13:13 Ben @.***> wrote:

I have heard reports that on iOS 16 these devices which detect something
(water, motion, contact, etc) don't appear in the Home app unless they are
activated.
I think you may be able to check if the accessory exists by going to the
following in the Home app on iOS 16:
Home settings -> Home Hubs & Bridges -> {HB/Flume Bridge} -> Accessories
Leak sensor should be in the list there
—
Reply to this email directly, view it on GitHub
https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1270626741,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE572TEJ2L4D36OCNGMB6WLWB4XILANCNFSM6AAAAAAQ66DHM4
.

Hi @ndradar
sorry for delay in reply to this. is this still an issue?

It is.  I still don’t see the hub in HomeKit. Im on iOS 16.3.1
Jeff Mueller
@.***
(406)868-9091 Cell
GO IRISH!!!

On Mar 10, 2023, at 17:12, Ben @.***> wrote:
Hi @ndradar https://github.com/ndradar
sorry for delay in reply to this. is this still an issue?
—
Reply to this email directly, view it on GitHub https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1464738046, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE572TFD4WK6GTRCRXQNL6TW3PGQTANCNFSM6AAAAAAQ66DHM4.
You are receiving this because you were mentioned.

I dont see the hub, I see the device - technically this plugin is using the api directly to Flume Portal, not the flume hub in your house.
On my homekit (ios 16.3.1 on Iphone 12 Pro) it shows up as 'leak detector' in a room it created called 'bathroom' but doesnt show status change on alert (other issue detailed in git).
On long press the leak detector pops its config screen showing it is Flume and upon clicking 'bridge' shows 'homebridge'.
The bottom of the screen should show Flume as manufacturer, the Serial number, model and Firmware version (which is the plugin version BTW).

It is. I still don’t see the hub in HomeKit. Im on iOS 16.3.1 --------------------------------- Jeff Mueller @.***<PHONE_NUMBER> Cell GO IRISH!!!
…
On Mar 10, 2023, at 17:12, Ben @.***> wrote: Hi @ndradar https://github.com/ndradar sorry for delay in reply to this. is this still an issue? — Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE572TFD4WK6GTRCRXQNL6TW3PGQTANCNFSM6AAAAAAQ66DHM4. You are receiving this because you were mentioned.

Hey as @kaduffey has said, the plugin simply exposes a leak detector device to Homekit.
ps GO ENGLAND!

Yes I see the device, it just doesn’t show flume as the bridge. It shows
Homebridge.  We did have a leak and I got a notification so it works.
On Fri, Mar 24, 2023 at 15:46 Ben @.***> wrote:

It is. I still don’t see the hub in HomeKit. Im on iOS 16.3.1
--------------------------------- Jeff Mueller @.***<PHONE_NUMBER> Cell
GO IRISH!!!
… <#m_-4730662721574681123_>
On Mar 10, 2023, at 17:12, Ben @.***> wrote: Hi @ndradar
https://github.com/ndradar https://github.com/ndradar sorry for delay
in reply to this. is this still an issue? — Reply to this email directly,
view it on GitHub <#23 (comment)
https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1464738046>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE572TFD4WK6GTRCRXQNL6TW3PGQTANCNFSM6AAAAAAQ66DHM4.
You are receiving this because you were mentioned.
Hey as @kaduffey https://github.com/kaduffey has said, the plugin
simply exposes a leak detector device to Homekit.
ps GO ENGLAND!
—
Reply to this email directly, view it on GitHub
https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1483536373,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE572TC6IHKMEDG5ULKUAR3W5YP53ANCNFSM6AAAAAAQ66DHM4
.

Darn!  How did you get an alert - I am not getting one - but I do get all
the usage stats using Home+ or Controller
On Fri, Mar 24, 2023 at 4:26 PM Jeff Mueller @.***>
wrote:

Yes I see the device, it just doesn’t show flume as the bridge. It shows
Homebridge. We did have a leak and I got a notification so it works.
On Fri, Mar 24, 2023 at 15:46 Ben @.***> wrote:

It is. I still don’t see the hub in HomeKit. Im on iOS 16.3.1
--------------------------------- Jeff Mueller @.***<PHONE_NUMBER> Cell
GO IRISH!!!
… <#m_-4730662721574681123_>
On Mar 10, 2023, at 17:12, Ben @.***> wrote: Hi @ndradar
https://github.com/ndradar https://github.com/ndradar sorry for delay
in reply to this. is this still an issue? — Reply to this email directly,
view it on GitHub <#23 (comment)
<
https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1464738046

,
or unsubscribe

https://github.com/notifications/unsubscribe-auth/AE572TFD4WK6GTRCRXQNL6TW3PGQTANCNFSM6AAAAAAQ66DHM4
.

You are receiving this because you were mentioned.
Hey as @kaduffey https://github.com/kaduffey has said, the plugin
simply exposes a leak detector device to Homekit.
ps GO ENGLAND!
—
Reply to this email directly, view it on GitHub
<
https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1483536373
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AE572TC6IHKMEDG5ULKUAR3W5YP53ANCNFSM6AAAAAAQ66DHM4
.

—
Reply to this email directly, view it on GitHub
https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1483579537,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6RBTCWSPYT74WEBGSLWVE3W5YUSJANCNFSM6AAAAAAQ66DHM4
.
You are receiving this because you were mentioned.Message ID:
@.***>

I don’t get usage stats in HomeKit!
On Fri, Mar 24, 2023 at 16:29 kaduffey @.***> wrote:

Darn! How did you get an alert - I am not getting one - but I do get all
the usage stats using Home+ or Controller
On Fri, Mar 24, 2023 at 4:26 PM Jeff Mueller @.***>
wrote:

Yes I see the device, it just doesn’t show flume as the bridge. It shows
Homebridge. We did have a leak and I got a notification so it works.
On Fri, Mar 24, 2023 at 15:46 Ben @.***> wrote:

It is. I still don’t see the hub in HomeKit. Im on iOS 16.3.1
--------------------------------- Jeff Mueller @.***<PHONE_NUMBER>
Cell
GO IRISH!!!
… <#m_-4730662721574681123_>
On Mar 10, 2023, at 17:12, Ben @.***> wrote: Hi @ndradar
https://github.com/ndradar https://github.com/ndradar sorry for
delay
in reply to this. is this still an issue? — Reply to this email
directly,
view it on GitHub <#23 (comment)
<

https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1464738046

,
or unsubscribe

https://github.com/notifications/unsubscribe-auth/AE572TFD4WK6GTRCRXQNL6TW3PGQTANCNFSM6AAAAAAQ66DHM4

.

You are receiving this because you were mentioned.
Hey as @kaduffey https://github.com/kaduffey has said, the plugin
simply exposes a leak detector device to Homekit.
ps GO ENGLAND!
—
Reply to this email directly, view it on GitHub
<

https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1483536373

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AE572TC6IHKMEDG5ULKUAR3W5YP53ANCNFSM6AAAAAAQ66DHM4

.

—
Reply to this email directly, view it on GitHub
<
https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1483579537
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/A6RBTCWSPYT74WEBGSLWVE3W5YUSJANCNFSM6AAAAAAQ66DHM4
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1483584283,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE572TCEUGTRXT66NLZ6ND3W5YU4NANCNFSM6AAAAAAQ66DHM4
.

For me that are only in IOS Home+ or controller (in app store). 3rd party front ends tohomekit vs ‘home’ appOn Mar 24, 2023, at 4:30 PM, Jeff Mueller @.***> wrote:
I don’t get usage stats in HomeKit!
On Fri, Mar 24, 2023 at 16:29 kaduffey @.***> wrote:

Darn! How did you get an alert - I am not getting one - but I do get all
the usage stats using Home+ or Controller
On Fri, Mar 24, 2023 at 4:26 PM Jeff Mueller @.***>
wrote:

Yes I see the device, it just doesn’t show flume as the bridge. It shows
Homebridge. We did have a leak and I got a notification so it works.
On Fri, Mar 24, 2023 at 15:46 Ben @.***> wrote:

It is. I still don’t see the hub in HomeKit. Im on iOS 16.3.1
--------------------------------- Jeff Mueller @.***<PHONE_NUMBER>
Cell
GO IRISH!!!
… <#m_-4730662721574681123_>
On Mar 10, 2023, at 17:12, Ben @.***> wrote: Hi @ndradar
https://github.com/ndradar https://github.com/ndradar sorry for
delay
in reply to this. is this still an issue? — Reply to this email
directly,
view it on GitHub <#23 (comment)
<

https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1464738046

,
or unsubscribe

https://github.com/notifications/unsubscribe-auth/AE572TFD4WK6GTRCRXQNL6TW3PGQTANCNFSM6AAAAAAQ66DHM4

.

You are receiving this because you were mentioned.
Hey as @kaduffey https://github.com/kaduffey has said, the plugin
simply exposes a leak detector device to Homekit.
ps GO ENGLAND!
—
Reply to this email directly, view it on GitHub
<

https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1483536373

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AE572TC6IHKMEDG5ULKUAR3W5YP53ANCNFSM6AAAAAAQ66DHM4

.

—
Reply to this email directly, view it on GitHub
<
https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1483579537
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/A6RBTCWSPYT74WEBGSLWVE3W5YUSJANCNFSM6AAAAAAQ66DHM4
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/bwp91/homebridge-flume/issues/23#issuecomment-1483584283,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE572TCEUGTRXT66NLZ6ND3W5YU4NANCNFSM6AAAAAAQ66DHM4
.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

The Home app cannot display this info, there is simple no UI for it.
Other HomeKit apps can show this, I tend to recommend the Eve app, but there are others too.


Wrong behavior ?

Expected Behavior
ASTERISK://ASTERISK.example.com/*
ASTERISK://ASTERISK.mozilla.org/*
Actual Behavior
ASTERISK://www.example.com/*
ASTERISK://www.mozilla.org/*
Steps to Reproduce the Problem
1.Open www.example.com or www.mozilla.org
1.Click on uBlacklist
1.Block
Specifications

OS:Gnu/Linux
Browser:firefox-91.0.2.tar.bz2, uBlacklist-v6.3.1
Other extensions that might interfere:None

INFO: Sorry, Github removed some *(asterisk)

It is the intended behavior.
See also: #83


Validate and/or refine the envisioned workflows for the Routinely Updated Fields

Describe the task
Based on the internal discussions with the developers, the envisioned workflows for updating the Routinely Updated Fields (see below) have been prototyped as outcome of #960.

Generic example for fields with Dropdown as front-end component
Generic example for fields with Date Picker or Text Input as front-end component

They need to be validated with the CIF team and refined where fit.
Acceptance Criteria

[x] Schedule walk-through and feedback gathering meeting with CIF Ops
[x] Document suggestions/concerns to inform design update decisions
[x] Sync and discuss findings and potential design updates with Devs
[x] Refine the design and prototypes if needed
[x] Draft user story tickets with design linked

Additional context

Hi Lindsay, this ticket is ready for you to review and can be closed with

The envisioned workflows reviewed, refined, and validated by the CIF team
Ticket #1158 created for implementation with details in its description

Thank you so much @nanyangpro for walking me through the design and decisions that went into this ticket. Much appreciated.


Update README.md File

As a developer on this Orders team
I need to be able to know what API calls can be made and what inputs they request.  Additionally developers need a reliable local development environment
So that I understand how to call the Orders API and can set up a local development environment that will behave the same on production.
Details and Assumptions

The developer has access to the README.md file
The developer needs to be able to / have instructions on how to run their development environment locally

Acceptance Criteria
Given access to the README.md file
When I read the README.md file
Then I can see what API calls can be made, what inputs they request, how to run and test the code

Mistakenly committed to master before branching was shown in class!


[BD-46] feat: update script for copying mui-icons and add additional docs

Description
Add additional docs about the copy-mui-icons.js script and update script that generates js / jsx file to handle SVG names that start with numbers
Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[ ] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[ ] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

@adamstankiewicz force-pushes fixed the jobs 😄

@adamstankiewicz force-pushes fixed the jobs 😄

@viktorrusakov Awesome, not sure what caused that hiccup 🤷♂ But at least it's working now haha!

@viktorrusakov An alternative idea to the "humanizing" of numbers here, what if we instead prefixed the component name with Pgn (or some other prefix), so it'd result in:
export { default as Pgn5G } from './5G';

This wouldn't have the issue of dealing with 3+ numbers in the component names. Food for thought. Would love to get your two cents before I merge this as is :)


Fixed a typo in getting_started.md

Fixed a typo in the "2.a. Install the Device Bootstrapper (First-Time-Setup)" section of getting_started.md where the name of the configuration was inconsistent.

@dtwalter This can be merged


nerdctl show  and delete cri images

What is the problem you're trying to solve
 crictl pull registry.aliyuncs.com/google_containers/pause:3.5
Image is up to date for sha256:ed210e3e4a5bae1237f1bb44d72a05a2f1e5c6bfe7a7e73da179e253426

nerdctl can't delete  k8s image
nerdctl  -n k8s.io images
registry.aliyuncs.com/google_containers/pause    3.5       1ff6c18fbef2    51 seconds ago    linux/amd64    668.0 KiB    294.4 KiB
registry.aliyuncs.com/google_containers/pause    <none>    1ff6c18fbef2    51 seconds ago    linux/amd64    668.0 KiB    294.4 KiB
<none>                                           <none>    1ff6c18fbef2    51 seconds ago    linux/amd64    668.0 KiB    294.4 KiB

Describe the solution you'd like
use nerdctl cri  images    list images
use nerdctl cri rmi     delete images
Additional context
nerdctl 1.7

Nerdctl do not implement the cri interface. IMO  it should be done through cri otherwise I'm afraid it could Conflicts with the cri operations

nerdctl  may call cri interface like crictl  to manage k8s images.

I am sure that's the target
https://github.com/containerd/nerdctl/issues/3671#issuecomment-2474468229

later we can nerdctl cri pods , nerdctl cri images. to manage cri resources.


add istio-reader clusterrole to access remote clusters with reduced privileges

This also fixes an issue where mixer doesn't have sufficient access to
read replicationcontrollers in remote clusters.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_installer
8cb844ec1a31ae5d7afe3fd6f4270b7fe675f633
link
/test gencheck_installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

noauth_installer
61d71ed55cd8daf238840155f268f27e911f28ed
link
/test noauth_installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

It's shared between pilot and mixer. Both can use the same service account when accessing remote clusters. I added it to pilot since this was more likely to be enabled even in minimal profiles. Is there a different general charts directory that would be more appropriate?

One of the ingress-gateway pods failed to initialization. I don't think this is caused by adding the new clusterrole.
2019-11-05T22:12:07.426590143Z stdout F 2019-11-05T22:12:07.426304Z	warn	config status timed out. using last known values cds status:<PHONE_NUMBER>9942061858,lds status:<PHONE_NUMBER>9942061858
2019-11-05T22:12:08.926649544Z stdout F 2019-11-05T22:12:08.926305Z	warn	config server state timed out. using last known state LIVE
2019-11-05T22:12:09.526562221Z stdout F 2019-11-05T22:12:09.526350Z	warn	config status timed out. using last known values cds status:<PHONE_NUMBER>9942061858,lds status:<PHONE_NUMBER>9942061858
2019-11-05T22:12:11.426743285Z stdout F 2019-11-05T22:12:11.426469Z	warn	config status timed out. using last known values cds status:<PHONE_NUMBER>9942061858,lds status:<PHONE_NUMBER>9942061858
2019-11-05T22:12:12.427034084Z stdout F 2019-11-05T22:12:12.426781Z	warn	config server state timed out. using last known state LIVE
2019-11-05T22:12:13.42656628Z stdout F 2019-11-05T22:12:13.426304Z	warn	config status timed out. using last known values cds status:<PHONE_NUMBER>9942061858,lds status:<PHONE_NUMBER>9942061858
2019-11-05T22:12:14.826716353Z stdout F 2019-11-05T22:12:14.826443Z	warn	config server state timed out. using last known state LIVE
2019-11-05T22:12:15.526662266Z stdout F 2019-11-05T22:12:15.526419Z	warn	config status timed out. using last known values cds status:<PHONE_NUMBER>9942061858,lds status:<PHONE_NUMBER>9942061858
2019-11-05T22:12:16.826582272Z stdout F 2019-11-05T22:12:16.826286Z	warn	config server state timed out. using last known state LIVE
2019-11-05T22:12:17.726745429Z stdout F 2019-11-05T22:12:17.726452Z	warn	config status timed out. using last known values cds status:<PHONE_NUMBER>9942061858,lds status:<PHONE_NUMBER>9942061858

/test noauth_installer

from https://github.com/istio/istio/issues/18665. Should probably revert
some PRs that caused this
On Tue, Nov 5, 2019 at 2:48 PM Jason Young<EMAIL_ADDRESS>wrote:

/test noauth_installer
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/installer/pull/492?email_source=notifications&email_token=AAEYGXL77DXMS6CGLC3MAEDQSHZ3RA5CNFSM4JJKPEB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDETTSA#issuecomment-550058440,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXOTC2ORYAA5M3HMIF3QSHZ3RANCNFSM4JJKPEBQ
.

In response to a cherrypick label: new pull request created: #495


Updated .Net section in sdk.md

Updated .NET section in sdk.md

Docs Build status updates of commit 30ce892:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

AdaptiveCards/templating/sdk.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Select files: multiple exclusions are allowed but not multiple inclusions

Hi,
digging into narrow and was not able to find this feature.
Entering
aaa! bbb!
will reduce results to those entries that do not have nor aaa nor bbb
Entering
aaa bbb
will reduce results to those entries that do have aaa AND bbb
This make it impossible to perform search within aaa and bbb root folder excluding everything else.
Aren't I missing anything?
If so, maybe it's better to use this logic

all exclusions are joined with AND logic
all inclusions are joined with OR logic
those 2 are joined with AND

Also seems like both !aaa and aaa! are equal (that's weird).

Give me actual example query with example item list.
It's difficult to understand what you are saying impossible scenario.

I want discuss with example usecase and result and how that result is different from your expectation style.
So need

example
result
your expectation

This make it impossible to perform search within aaa and bbb root folder excluding everything else.

OK understand, your point.

select-files is just one of providers, so it shares Query characteristics with other providers.
I don't want select-files specific handling. It make learning narrow difficult.
Currently narrow query doesn't support OR expression.
If narrrow query have OR expression(e.g. |), input query aaa|bbb solve problem I think.

Yes, I guess adding | to Query would solve the problem.

Updated(not released)
https://github.com/t9md/atom-narrow/wiki/Query

released as v0.38.0.
Give me feedback if you notice anything.

Thanks, works great,
just one issue.
On the other thread, you said that "I want select-file preference is remembered and applied on next narrow invocation". I understand this as "when i run another search - select files query should persist". Is that right? If so, I see that it's not persisted and on every search run select files query is empty. Am I missing anything?


createInstance can throw: how to graceful fallback

There are a few issues that make it impossible for the application to still work if optimizely fails to initialize:

optimizely.createInstance from optimizely-sdk can return null
https://github.com/optimizely/javascript-sdk/blob/v4.7.0/packages/optimizely-sdk/lib/index.browser.ts#L136
createInstance in the react-sdk does not handle the null case and then just throws in the constructor when accessing this._client.onReady
https://github.com/optimizely/react-sdk/blob/2.7.0/src/client.ts#L195-L201
if we catch this thrown error in our application code, we cannot render OptimizelyProvider because it needs an OptimizelyReactSDKClient instance
https://github.com/optimizely/react-sdk/blob/2.7.0/src/Provider.tsx#L27
conditionally rendering the OptimizelyProvider is not an option because the optimizely hooks from react-sdk throw when there is no optimizely instance provided via the OptimizelyProvider
https://github.com/optimizely/react-sdk/blob/2.7.0/src/hooks.ts#L332-L336
the rules of hooks disallow to render hooks conditionally, so we cannot catch this issue on the application side

We currently see in production ~70.000 failed optimizely initializations / hour. All happening in Firefox, and we need to investigate more, but the main issue is that failing optimizely makes the application unusable, which is not a graceful fallback.
I have different ideas to solve this:

react-sdk allows to render OptimizelyProvider with optimizely={null} and the optimizely hooks are modified to not throw anymore when no optimizely instance is available. Applications will need to catch the thrown error from the initial createInstance call and as a fallback use null. The hooks then fall back to the same values they would when optimizely is not yet ready.
react-sdk does not throw in createInstance when optimizely is null and rather wraps all accesses to this._client with a null check.
react-sdk provides a DummyReactClient that implements all the functions from ReactSDKClient with no functionality. Applications will need to catch the thrown error from the initial createInstance call and as a fallback use the DummyReactClient and provide it to OptimizelyProvider.

I would vote for option 1. because it still allows applications to detect when createInstance fails and allows for the maximum flexibility. Also it's backwards-compatible.

Your PR would save me a re-render I'm currently doing something like this:
export const OptimizelyWrapper: FC<{}> = ({ children }) => {

.....
  const client: ReactSDKClient = getOptimizelyInstance();
.....

  return (
    <>
      {client ? (
        <OptimizelyProvider
          optimizely={client}
          user={{
            id: userID,
            attributes: {
              user_id: userID,
              is_logged_in: !!fundraiser?.uniqueId,
            },
          }}
          isServerSide={!isBrowser}
        >
          {children}
        </OptimizelyProvider>
      ) : (
        <>{children}</>
      )}
    </>
  );
};

export default OptimizelyWrapper;

@fabb @Develliot We are picking this up and will try to fix it over the next few days. its a legit ask to add safeguard into React SDK to make sure optimizely-sdk returning a null client does not break the React App and we are picking it up for fixing. On the other hand, i would like to know more about the exact errors you see in the firefox consoles. I would like to investigate the reason why our javascirpt SDK is failing and returning a null client in the first place. Can you share some more information regarding that ?

Hi,
unfortunately I just see the errors in Sentry from real users, and could not reproduce the issue locally. I investigated quite a bit to find out what the underlying issue could be, and my strongest hypothesis is this: https://github.com/optimizely/javascript-sdk/pull/720

Why can't the provider just be handed the SDK key and deal with client instance all internally either SSR or async why is it a separate thing that end users need to think about?

@fabb - hello! Thanks again for the suggestions, we've gone ahead and readied this PR to address this issue here: https://github.com/optimizely/react-sdk/pull/149
This resolution will be part of the next minor version update of the SDK which should be coming soon.

Also, wanted to repost this reply here in case anyone misses it on the PR:
@Develliot - We discussed this approach internally and due to the nature of the change, we will consider the change as a new feature request as it requires refactoring many components.
Our suggestion is to add it to our feature request board here - we will prioritize it based on the number of votes it gets!
Best,
John

@fabb - just released a new patch yesterday that should resolve this. Thanks again for reporting the issue!

Release 2.8.1 · optimizely/react-sdk
npm: @optimizely/react-sdk

cc: @zashraf1985

Nice, thanks!


[SPARK-24244][SQL] CSV column pruning

What changes were proposed in this pull request?
uniVocity parser allows to specify only required column names or indexes for parsing like:
// Here we select only the columns by their indexes.
// The parser just skips the values in other columns
parserSettings.selectIndexes(4, 0, 1);
CsvParser parser = new CsvParser(parserSettings);

In this PR, I propose to extract indexes from required schema and pass them into the CSV parser. Benchmarks show the following improvements in parsing of 1000 columns:
Select 100 columns out of 1000: x1.76
Select 1 column out of 1000: x2

Note: Comparing to current implementation, the changes can return different result for malformed rows if only subset of all columns is requested.
How was this patch tested?
It was tested by new test which selects 3 columns out of 15, by existing tests and by new benchmarks.

Test build #90471 has started for PR 21296 at commit e3958b1.

@cloud-fan @hvanhovell Could you look at the PR, please.

Can one of the admins verify this patch?

Test build #90473 has started for PR 21296 at commit a4a0a54.

Test build #90471 has finished for PR 21296 at commit e3958b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90471/
Test PASSed.

Test build #90473 has finished for PR 21296 at commit a4a0a54.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90473/
Test PASSed.

mind fixing the PR title? sounds we have never implemented the "column pruning" before in CSV.

I'm fine with breaking the CSV behavior of malformed input a little, as long as we documented it well in the migration guide. cc @gatorsmile

Can we update the migration guide then? I want to see if the note makes sense.

Test build #90555 has started for PR 21296 at commit f90daa7.

Test build #90555 has finished for PR 21296 at commit f90daa7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90555/
Test PASSed.

Test build #90751 has started for PR 21296 at commit 7dcfc7a.

Test build #90752 has started for PR 21296 at commit f89eeb7.

Test build #90751 has finished for PR 21296 at commit 7dcfc7a.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 case class WidenSetOperationTypes(conf: SQLConf) extends Rule[LogicalPlan]
 case class FunctionArgumentConversion(conf: SQLConf) extends TypeCoercionRule
 case class CaseWhenCoercion(conf: SQLConf) extends TypeCoercionRule
 case class IfCoercion(conf: SQLConf) extends TypeCoercionRule
 case class ImplicitTypeCasts(conf: SQLConf) extends TypeCoercionRule
class ContinuousMemoryStream[A : Encoder](id: Int, sqlContext: SQLContext, numPartitions: Int = 2)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90751/
Test PASSed.

Test build #90752 has finished for PR 21296 at commit f89eeb7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #90797 has started for PR 21296 at commit 6ff6d4f.

Test build #90797 has finished for PR 21296 at commit 6ff6d4f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90797/
Test PASSed.

@cloud-fan @HyukjinKwon Could you look at the PR, please.

LGTM except a minor comment about the config name

Just for clarification, I'm okay.

thanks, merging to master!

This PR breaks the tests. Let me revert it. Please resubmit the PR with the fix. Thanks!

https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91045/testReport/org.apache.spark.sql.execution.datasources.csv/UnivocityParserSuite/_It_is_not_a_test_it_is_a_sbt_testing_SuiteSelector_/history/

if i do not select a schema (and i use inferSchema), and i do a select for only a few column, does this push down the column selection into the reading of data (for schema inference and for the actual data read)?

... does this push down the column selection into the reading of data

Yes, it does.


Add ActivityLogger plugin

Add https://github.com/elstc/cakephp-activity-logger

Your plugin name looks like a lie - as per our guidelines
Elastic/ActivityLogger seems to be the name.

Code comments in non English is not something that fits our quality criteria for reusability in the community ( https://github.com/elstc/cakephp-activity-logger/blob/master/src/Model/Behavior/LoggerBehavior.php#L217 ).

In what way is that different/better than the existing AuditStash plugin?
https://github.com/FriendsOfCake/awesome-cakephp#auditing--logging
If this was for 4.x this might be more interesting, but it also seems to be only for 3.x still.

In what way is that different/better than the existing AuditStash plugin?
https://github.com/FriendsOfCake/awesome-cakephp#auditing--logging
If this was for 4.x this might be more interesting, but it also seems to be only for 3.x still.

Yes @dereuromark , you are right. AuditStash plugin is better than ActivityLog, when I looked the AuditStash plugin I was in impression that it will only store data into elastic search(that I don't want). But it also stores activity data into mysql database table, and also well maintained and supports cake 4.x.
So closing the merge request as we don't need new "not-maintained" plugin in awesome list.


Add exercise: etl

Not sure if input and output must be Dicts. @SaschaMann, is this example okay?

@andrej-makarov-skrt I'll take a look in a bit, I was busy over the weekend.

@andrej-makarov-skrt I think Dicts make more sense for out- and input here. Also Chars instead of 1-letter strings.

@SaschaMann changed test sets and example, please check it out.

That works, thanks for adding this exercise! :)


a fixation on gt generation

A fixation on the last commit of fcos refactor.

Maybe add some comments on the generation of ground truth?

I've refined the comments in code files. Let me know if there is still any ambiguity.


MM-12825 - Making IE not responsive

Summary
MM-12825 - Making IE not responsive (at 600px)
Ticket Link
https://mattermost.atlassian.net/browse/MM-12825
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Ran make check-style to check for style errors (required for all pull requests)
[ ] Ran make test to ensure unit and component tests passed
[ ] Added or updated unit tests (required for all new features)
[ ] Needs to be implemented in mobile (link to PR or User Story)
[ ] Has server changes (please link)
[ ] Has redux changes (please link)
[x] Has UI changes
[ ] Includes text changes and localization file (.../i18n/en.json) updates
[ ] Touches critical sections of the codebase (auth, posting, etc.)

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-0c7e80075b61dedd2.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-0c7e80075b61dedd2


fix(docs): correct broken links to ockam.io site

There are a couple of broken links from the docs to the web site. Until the 404 issue on the site is fixed, the links should be fixed.

@njvrzm thank you for sending this PR and being patient with our CLA bot problems.
I just rebased and merged it with some minor changes to the commit message to comply with our conventions https://github.com/ockam-network/ockam/commit/051e345a6cff0171310eebac3101f52cb5475f35
Thank you 🙏

@njvrzm thank you for sending this PR and being patient with our CLA bot problems.
I just rebased and merged it with some minor changes to the commit message to comply with our conventions https://github.com/ockam-network/ockam/commit/051e345a6cff0171310eebac3101f52cb5475f35
Thank you 🙏