IBM User Build - HowTo - Manage Git context during User Build (and deploiement)

Description of the enhancement requested
Hi,
We use VS Code as source editor.
We work in a Git context, both for editing source codes in ZOE, and in DBB to do the builds.
Our DBB build processes are dependent on the Git context (Git branch) they are in.
When doing a DBB fullBuild or more often a DBB impactBuild, the build.groovy script runs in a workspace containing the cloned Git repository(ies). The build.groovy script uses Git functions to know the context of the Git branch in which it operates.
When doing a DBB userBuild, the build.groovy script does not run in a workspace containing the cloned Git repository: it runs in a workspace created and populated by ZOE "as best it can".
Consequences :

the build.groovy script don't know in which Git context it operate: feature branch or hotfix branch? (our COBOL compilation options depend on the Git branch, debugging options on feature, performance options on hotfix)
components may be missing which are necessary for the construction because, except for the includes/copies, ZOE does not know the logical dependencies between the components (cf. #297)
you can't do impactBuild: deliver a COPYBOOK modification and rebuild the programs that use this COPYBOOK, (dependencies information are kept in DBB metadata store, not in Git repository, and ZOE doesn't know DBB metadata store). ZOE could manage the dependencies between COPYBOOK and programs inside the Workspace VS Code, but that would force him to scan all the COBOL sources of the Wokspace to discover the uses of COPYBOOKs, and in addition to do it in cascade because the COPYBOOKs can be referenced by other COPYBOOKs and not directly by COBOL programs, (I don't think it is possible to ask ZOE to do the impact calculation work).

Another problem: after build, you have to deploy the built component(s) (loadmodule, dbrm, listing for debug tools...) for testing.
Here too, the test environment depends on the Git context: we use different test environments (shared between projects) depending on whether we are in development (Git feature branch) or in maintenance (Git hotfix branch).
To solve some of these problems, it would be necessary to be able to pass informations about the current Git context to the build script, at least the name of the Git branch, as parameters.
Either we can do it dynamically: provide a symbolic expression or variable on the name of the Git branch in the parameters of the DBB profile declared in the zapp.yaml file, but it seems that ZOE does not know how to resolve expressions other than those based on the variable ${buildfile) and its variants. In particular ZOE doesn't seem able to resolve VS Code's context variables.
Either you have to do it statically: create as many DBB profiles in the zapp.yaml file with a fixed parameter indicating the type of the Git branch (and not the name of the Git branch which is never the same), but then you need a mechanism that selects the right DBB profile during the "setup" and when running IBM User Build.
What solutions would you suggest to manage these needs?

@FALLAI-Denis thanks for the feedback. I might misunderstand your environment, but this what I assume and suggest:

User Build only builds one program at the time. It operates independent of the user using Git or not.
When running the build operation in the editor it uses the language server to determine the list of copybooks.
It then checks with the property groups which copybooks are local and which are remote.
It then uploads the program and the local copybooks to USS for dbb-zappbuild. It ignores remote copybooks and assumes that DBB knows how to find it via its own properties files (something we should optimize in the future to avoid redundancies).

So for the local copybooks that get uploaded we assume in the Git case that they are either (a) from the same git repo and checked out together with the program or (b) come from another Git repo in a VS Code multi-root workspace and were checked out with the correct branch by the developer as well.
As the programs and copybooks can be different in each branch so have the zapp files be different and match in their content to this one branch. Each branch could have a different variant of the zapp file. The zapp files are not intended to be orthogonal to the git repo files or know about branches, but a part of it. This would be the same for Maven pom files, Groovy files, C Makefiles, or Nodejs package.json files in other programming models.
To better support the multi-root/multi-repository use case in which the copybooks are in a separate repo and VS Code workspace we added the multi-root support in 2.2 in which now every workspace can have its own ZAPP file at the top to contain the property-groups for this repository. Z Open Editor will concatenate all the property groups of all the workspaces when evaluating the user build to find all the copybooks in the multi-root workspace.
Here is a sample for such as multi-root configuration with multiple zapp files: https://github.com/IBM/zopeneditor-sample/tree/wazi-main/multiroot
There are other enhancement requests open that ask for more context of the property groups such as zapp files in sub-folders that select different property groups for different programs, which we agree we need to add as well. So setting a context based on folders and perhaps even environment variables or user settings is something we do want to consider.

Hi,
Each branch can have a different variant of the zapp file.
Since zapp files are files among others, they are impacted during Git branch merge operations. I don't see how to have different zapp files per Git branch.
If they are declared in .gitignore, they will not be created during a checkout and it is the developer who will have to create them each time.
multi-root/multi-repository use case where copybooks are in a separate repository and VS Code workspace
This is not our use case. We operate with a simple workspace. The external Git repositories containing the copybooks are dynamically cloned inside the workspace, in a folder declared in .gitignore, by a mechanism that we have put in place.
We have a configuration system that allows you to associate a Git branch of the main Repository (programs) with a list of couples External Git Repository / branch of the external Git Repository (copybooks).

Our need is to be able to let DBB know in a userBuild context which Git branch the program sources that have been downloaded come from so that it can adapt the compilation procedure accordingly:

we do not compile with the same options depending on whether the source program comes from a feature branch or comes from a hotfix branch
we do not deploy on the same environment depending on whether the source program comes from a feature branch or comes from a hotfix branch

It is therefore necessary to be able to pass as a parameter, to be declared in the DBB profile of the zapp file, the type of the Git branch in use in the Git Repository which is also the VS Code workspace.

dynamically cloned inside the workspace, in a folder declared in .gitignore
That sounds like you are working around Git here, which seems a very special solution for your org.

We reproduced a mechanism similar to that of Git submodules, but in a proprietary way, because we were advised against using Git submodules.
We are cloning inside mono-root Workspace, so in a subfolder of the main Git Repository, to avoid having conflicts when cloning outside Workspace because several instances of VS Code could be launched in parallel referring to the same imported secondary Git repositories, but not for the same branch nor with the same sparse-checkout filtering.


ScrollView of Buttons causes graphics glitch

Describe the bug
Use the DynamicScrollView Component.
Add a HoloLens 2 Pressable button as the dynamic content and appropriately add the size of the object.
When the scroll view of buttons is created the Pressablebutton has a graphics glitch where the button's outline is intermittently showing.
Screenshots
Your setup (please complete the following information)

Unity Version [e.g. 2019.4.12f1]
MRTK Version [e.g. v2.5.1]

Target platform (please complete the following information)

Editor
HoloLens 2
WMR immersive
OpenVR

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visithttps://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


Can we improve on the performance of pop()?

I came across this article in which the performance of SwiftPriorityQueue was far lower than both an Objective-C priority queue and the C++ STL priority queue because we're spending 68% of his tests in pop() whereas they are spending <10% of their time in his tests on pop(). What can be improved about our pop() implementation? Here's the article, and the relevant section is 6.2:
https://miun.diva-portal.org/smash/get/diva2:1135549/FULLTEXT01.pdf

Closed by #20


Saved search throws a Null pointer exception

when running a saved search instance through splunk API , i get the following exception
"main" java.lang.NullPointerException
at com.splunk.ResourceCollection.namespace(ResourceCollection.java:262)
at com.splunk.ResourceCollection.createItem(ResourceCollection.java:161)
at com.splunk.ResourceCollection.load(ResourceCollection.java:295)
at com.splunk.ResourceCollection.refresh(ResourceCollection.java:334)
at com.splunk.ResourceCollection.refresh(ResourceCollection.java:1)
at com.splunk.Resource.validate(Resource.java:174)
at com.splunk.ResourceCollection.validate(ResourceCollection.java:350)
at com.splunk.ResourceCollection.get(ResourceCollection.java:184)
at com.splunk.SavedSearch.dispatch(SavedSearch.java:87)
at com.splunk.SavedSearch.dispatch(SavedSearch.java:106)
at com.splunk.SavedSearch.dispatch(SavedSearch.java:63)

Hi @aramachandranintuit - which version of the Splunk SDK for Java are you using and which version of Java are you using?

1.5.0 and 1.6.0 are also giving me the same exceptions.
If there is a version of Splunk SDK that has the fix for the above issue , please let me know the version number of the same so that i can add it as a maven dependency.

1.6.1 should have a fix for that specific issue - a null reference check was added at line 262 of ResourceCollection.java. Can you try that version and let me know?

@aramachandranintuit - was there a resolution for this?  I am seeing something similar in v<IP_ADDRESS>

I worked around this issue by not using that workflow. I don't think they
solved it.
On Aug 25, 2017 3:58 AM, "Clay Roach"<EMAIL_ADDRESS>wrote:

@aramachandranintuit https://github.com/aramachandranintuit - was there
a resolution for this? I am seeing something similar in v<IP_ADDRESS>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/splunk/splunk-sdk-java/issues/97#issuecomment-324774544,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFFJP9ZtjQKJDOOLDE2vXsqeWnOCTDXoks5sbfkNgaJpZM4MMzaZ
.

@aramachandranintuit I cannot reproduce this on latest version. Could you please confirm that? And if still happens, please provide more informations. Thanks!

We are seeing this still in v<IP_ADDRESS>, with Splunk v6.4.7.  We just ran into this again today.

@clayroach Can you try v<IP_ADDRESS>?

We can try but didn't look like any commits since 1.6.2 would address this.

This continues to hamper data collection at our customer. Any updates on this?

@j9reid Could you please provide the steps to reproduce this issue？

Closed to due to lack of information. Please re-open if anyone has more details.


feat: NSkeleton, add new component and preset

🆒 Your use case
Hi! I want to contribute to this wonderful UI library
so, this is how I see the skeleton component.

🆕 The solution you'd like
I can make a pr because I've already got it ready.
For now:

animation: animate-pulse
shape prop: 'rectangle' | 'circle'

You have a cool idea and I hope for further contribution
🔍 Alternatives you've considered
No response
ℹ Additional info
No response

@mnenie  Wow, this is great! Thanks for your time contributing to this project.
Could you please create a PR with your work so that I can review it and push it to release as soon as possible? ✨

@Mnenie It's already merged and now live in production. I made a few changes. Thanks, nicely done. 🔥
ref: https://unaui.com/components/skeleton

@mnenie It's already merged and now live in production. I made a few changes. Thanks, nicely done. 🔥
ref: https://unaui.com/components/skeleton

ok, thanks. I saw the changes and I agree with them, it looks cool 🔥🔥🔥


fix(zk status prover): Update protocol version query

What ❔

Fix the zk status prover protocol version query from prover_protocol_versions to the new prover_fri_protocol_versions table.
Why ❔

zk status prover halts with the message Error: relation "prover_protocol_versions" does not exist preventing the status of the prover from being checked.
Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[x] Code has been formatted via zk fmt and zk lint.
[x] Spellcheck has been run via zk spellcheck.
[x] Linkcheck has been run via zk linkcheck.

this is a good solution, perform synchronization


ImportError: No module named PIL

In a clean Python 2.7 virtualenv, with the command pip install simple_tensorflow_serving, then simple_tensorflow_serving -h, I get the error ImportError: No module named PIL.
It appears that the package pillow is not installed together with simple_tensorflow_serving as a dependency.

Nice catch and thanks for reporting.


Git history

Hey @talwat, hope things are going well with you. Just saw this repo got deleted. If you want a history of the git repo I have cloned locally. I can send you a zip.

It's fine, the new repo actually increased clone speed :)


How should one accomplish plain topk sampling?

I'm wondering if it's possible to do plain topk sampling with the "completion" APIs.
As you can see, I'm trying to disable all of the other sampling parameters:
from llama_cpp import Llama

llm = Llama(
      model_path="/home/axyo/dev/LLM/models/Meta-Llama-3-8B-GGUF/Meta-Llama-3-8B-Q4_K_M.gguf",
      n_gpu_layers=-1,
      seed=8,
      n_ctx=4096,

)

output = llm(
    """6@7@8 = 42 56 98
1@6@3 = 6 18 24
5@7@1 = 35 7 42
2@5@8 = 10 40 50
4@4@2 = 16 8 24
6@4@2 = 24 8 32
5@5@1 = 25 5 30
3@1@5 = 3 5 8
4@5@4 = 20 20 40
3@8@6 =""",
    echo=False,
    max_tokens=10,
    stop=["\n"],
    top_k=1,
    temperature=0,
    repeat_penalty=0,
    #min_p=0,
    #top_p=0,
    #tfs_z=0,
    #typical_p=0,
    mirostat_mode=None,
    mirostat_tau=0,
    mirostat_eta=0,
)
print(output)

I don't get topk=1, rather the output seems to depend entirely on repetition penalty...
repeat_penalty=0:
1111111111

repeat_penalty=0.5:
 24 24 24

repeat_penalty=1.0:
 24 48 72

repeat_penalty=1.1 (the default):
 21 48 69

Using replicate.com/meta/meta-llama-3-8b with topk=1 gives the expected output without regard of other settings:
 24 48 72

which is attained from setting repeat_penalty=1 in the llama-cpp-python code...  Is it expected that repeat_penalty=1.0 disables it?  Or is there a better alternative in the API?

I think I see, repeat_penalty must be set to 1.0 to disable it.  repeat_last_n = 0 would be nice but it's only partially exposed.  penalize_nl would also be nice to expose since llama.cpp seems to have this penalty enabled by default as well


Use new convenience frames in behavior

The convenience frames package provides multiple tf frames for the objects as well as an approach frame that can be used to approach the ball with clearer code.
Would be good to refactor the behavior code accordingly

This will also help to avoid losing the goal when the robot is turning without seeing it.


Support concrete members

This code works as expected:
//> using scala "3.2.0"
//> using lib "io.github.irevive::union-derivation-core:0.0.3"

import io.github.irevive.union.derivation.{IsUnion, UnionDerivation}

trait Show[A]:

  def showValue(value: A): String

  //def show(value: A): String = showValue(value)

given Show[String] with

  override def showValue(value: String): String = s"str: $value"

given Show[Int] with

  override def showValue(value: Int): String = s"int: $value"

inline given derivedUnion[A](using IsUnion[A]): Show[A] = UnionDerivation.derive[Show, A]

println(summon[Show[String | Int]].showValue(1)) //int: 1
println(summon[Show[String | Int]].showValue("1")) //str: 1

but when uncommenting the concrete method, the compiler throws the following error:
[error] ./union.sc:23:35: More than one abstract method detected in trait Show: showValue, show. Automatic derivation is impossible
[error] println(summon[Show[String | Int]].showValue("1"))
[error]                                   ^
[error] ./union.sc:22:35: More than one abstract method detected in trait Show: showValue, show. Automatic derivation is impossible
[error] println(summon[Show[String | Int]].showValue(1))
[error]                                   ^

I expect the code to still compile since the show member is concrete and shouldn't be redefined. Maybe an annotation would help to disambiguate and choose the method to reimplement?

Hi, thank you for the report!
You need to use -Yretain-trees compiler option, for example:
//> using scala "3.2.0"
//> using lib "io.github.irevive::union-derivation-core:0.0.3"
//> using options "-Yretain-trees"

The compiler does not retain default implementations, and the library thinks the method is abstract.

Thank you for the quick reply!
I (normally) added the options through the CLI so I guess I misstyped something :sweat_smile:
Your correction works like a charm.

Good to hear the issue is sorted! I added your example to the readme file.
https://github.com/iRevive/union-derivation#scala-cli


GetObjectRequest hangs randomly.

Randomly my application will hang infinity waiting for a response in the Amazon library for AmazonS3Client.GetOject see the stacktrace below, the object is not being reused.

here is a sample of the code run in that thread:
using (var amazonS3Client = CreateS3Client())
{
    var s3PartDownloadRequest = new GetObjectRequest
    {
        BucketName = download.Bucket,
        Key = download.ObjectKey,
        ByteRange = new ByteRange(position, end)
    };

    using (var getObjectResponse = amazonS3Client.GetObject(s3PartDownloadRequest)) //hangs on this line
    {
        getObjectResponse.WriteResponseStreamToFile(dest);
    }
}

Has anyone been able to resolve this issue? I'm facing it too...

I also experience this sometimes, UploadPartAsync never returns, and actually, it doesn't even upload, since the StreamTransferProgress handler doesn't get anything.
I also provide a CancellationToken, and when the problem occurs, it even ignores the cancellation, so there's actually no way to get this task finished.

In case anyone still has this issue, I've found two changes that removed the problem:

Before you initialize any of ASW SDK's class set ServicePointManager.DefaultConnectionLimit = 1000;.
I set it to 1000, but any big number works. MSDN says the default number is Int32.MaxValue, but in fact it is just 2.
The AWS SDK for .Net does use a value of 50, but that might not be enough (I also use SWF, which requires a large number of open connections).
Do not share instances of AmazonS3Client between threads. The SDK uses HttpWebRequest, which isn't thread safe. It isn't clear if some methods are thread safe, and I don't think the SDK guarantees this, so I try not to use the same instance in parallel.

Two more comments:

I got hanging connections when opening a stream using HttpWebRequest directly to a public S3 URL (public file/static content), without using the SDK at all. This is how I've found the two workarounds above.
I get more hanging connections at the office than at home.

I am seeing something very similar, although we are using the PutObject method.
We can set the DefaultConnectionLimit very high....but as soon as that number of connections has been reached the application hangs.
Running "netstat -a -n | find /c "54.231." indicates the same number of connections
If we run a simple "netstat -a -n" shows that the connections in the "CLOSE_WAIT" state.
These connections remain in this state until the application is terminated (this has caused problems when using the library in a website......it must be restarted to clear).
My guess is that the underlying httpwebrequest connection is not being closed properly.
We have tried (without success) setting...
System.Net.ServicePointManager.DefaultConnectionLimit = 1000;
System.Net.ServicePointManager.SetTcpKeepAlive(false, 1, 1);
System.Net.ServicePointManager.MaxServicePointIdleTime = 10 * 1000;

I think the key might be to dispose of the GetObjectResponse as quickly as possible. In my program, I'm concurrently downloading the contents of an entire bucket (with 35 concurrent worker tasks). I noticed that I started seeing object requests hang indefinitely if I didn't immediately read the contents of GetObjectResponse.ResponseStream into memory and dispose of the stream.
Fiddling with the DefaultConnectionLimit didn't seem to offer any improvement, only the quick disposal of the stream made any difference for me.

I'm using the Quartz Scheduler for .Net and I was receiving the problem intermittently during a Job Execution.  I tried Kobi's and Stormsys's posts and they both improved matters - but didn't fully fix the problem.
The only thing that HAS managed to fix the problem has been to make a new instance of my S3Client in my Job Execution class whenever it executes rather than resolving it using dependency injection - I think it has something to do with thread safety.  I haven't experienced the problem any more and I think I would have by now.

I have a related problem, using the asp.net core SDK version 3.2.3-beta. My problem is related to executing GetObjectAsync calls in parallel, but reading through the thread, it might be highly related. I've posted the problem at http://stackoverflow.com/questions/37471477/download-files-from-s3-in-parallel-aws-net-sdk before I found this thread.
Does the AmazonS3Client have any synchronization or shared state?

I've been experiencing this, and on investigating the issue I think the line to blame is https://github.com/aws/aws-sdk-net/blob/aws-sdk-net-v2/AWSSDK_DotNet35/Amazon.Runtime/Pipeline/HttpHandler/HttpHandler.cs#L104.
If the GetResponse method throws a WebException internally, then the response stream will never be closed. That's consistent with seeing connections hanging in the close_wait state.

The new 3.3.1 version of Core contains the PR https://github.com/aws/aws-sdk-net/pull/449 which addresses this problem.  Please let us know if the problem persists.  Thanks!

Closing due to inactivity.  If any of you guys encounter this issue again, feel free to reopen it.  Thanks!

I'm not sure how to reopen this issue. So adding my problem here.
We have a server side application in .Net developed using Nancyfx framework. Running as selfhost. This application receives multipart request with multiple files(around 100).  All these files are supposed to be upload to S3 bucket. Using Parallels to upload files to S3 bucket. Right now creating s3 object for every task.  This is causing too many HTTP connections and after a while system is become slow or s3 latency increases.  We have optimized at TCP level, to reduce the TcpWaitTimeDelay to 30 seconds.
Can anyone help how to resolve this issue ?
How can we reduce AmazonS3Client HTTP connection pool ?
Using Windows 2012
AWS SDK version : 3.3.7
Let me know if any further information require.
Thanks in advance.

Separate issue was opened for this question, no need to re-open - https://github.com/aws/aws-sdk-net/issues/546

Hangs on AWSSDK.Core 3.3.12 + AWSSDK.S3 <IP_ADDRESS>.
mscorlib.dll!System.Threading.WaitHandle.WaitOne(int millisecondsTimeout, bool exitContext)
System.dll!System.Net.LazyAsyncResult.WaitForCompletion(bool snap)
System.dll!System.Net.HttpWebRequest.GetResponse()
AWSSDK.Core.dll!Amazon.Runtime.Internal.HttpRequest.GetResponse()
AWSSDK.Core.dll!Amazon.Runtime.Internal.HttpHandler<System.IO.Stream>.InvokeSync(Amazon.Runtime.IExecutionContext executionContext)
AWSSDK.Core.dll!Amazon.Runtime.Internal.RedirectHandler.InvokeSync(Amazon.Runtime.IExecutionContext executionContext)
AWSSDK.Core.dll!Amazon.Runtime.Internal.Unmarshaller.InvokeSync(Amazon.Runtime.IExecutionContext executionContext)
AWSSDK.S3.dll!Amazon.S3.Internal.AmazonS3ResponseHandler.InvokeSync(Amazon.Runtime.IExecutionContext executionContext)
AWSSDK.Core.dll!Amazon.Runtime.Internal.ErrorHandler.InvokeSync(Amazon.Runtime.IExecutionContext executionContext)
AWSSDK.Core.dll!Amazon.Runtime.Internal.CallbackHandler.InvokeSync(Amazon.Runtime.IExecutionContext executionContext)
AWSSDK.Core.dll!Amazon.Runtime.Internal.RetryHandler.InvokeSync(Amazon.Runtime.IExecutionContext executionContext)
AWSSDK.Core.dll!Amazon.Runtime.Internal.CallbackHandler.InvokeSync(Amazon.Runtime.IExecutionContext executionContext)
AWSSDK.Core.dll!Amazon.Runtime.Internal.CallbackHandler.InvokeSync(Amazon.Runtime.IExecutionContext executionContext)
AWSSDK.S3.dll!Amazon.S3.Internal.AmazonS3ExceptionHandler.InvokeSync(Amazon.Runtime.IExecutionContext executionContext)
AWSSDK.Core.dll!Amazon.Runtime.Internal.ErrorCallbackHandler.InvokeSync(Amazon.Runtime.IExecutionContext executionContext)
AWSSDK.Core.dll!Amazon.Runtime.Internal.MetricsHandler.InvokeSync(Amazon.Runtime.IExecutionContext executionContext)
AWSSDK.Core.dll!Amazon.Runtime.Internal.RuntimePipeline.InvokeSync(Amazon.Runtime.IExecutionContext executionContext)
AWSSDK.Core.dll!Amazon.Runtime.AmazonServiceClient.Invoke<Amazon.S3.Model.PutObjectRequest, Amazon.S3.Model.PutObjectResponse>(Amazon.S3.Model.PutObjectRequest request, Amazon.Runtime.Internal.Transform.IMarshaller<Amazon.Runtime.Internal.IRequest, Amazon.Runtime.AmazonWebServiceRequest> marshaller, Amazon.Runtime.Internal.Transform.ResponseUnmarshaller unmarshaller)
AWSSDK.S3.dll!Amazon.S3.AmazonS3Client.PutObject(Amazon.S3.Model.PutObjectRequest request)

I'm still noticing this behaviour.
AWSSDK.Core: version=<IP_ADDRESS>
AWSSDK.S3 version=<IP_ADDRESS>
Increasing the ServicePointManager.DefaultConnectionLimit to a nice high number temporarily alleviates the problem. But I'm not sure what to do otherwise. I don't think the quick disposal thing is our problem as we're not really dealing with concurrent requests at this time.

From our experience concurreny doesn't really matter, if you don't dispose the connection will hang around until the application terminates.  We are simply disposing of the object as soon as possible and all the problems have disappeared.

@randall-peakey-com: Interesting. Okay, this will be my next attempt at a fix. Right now we return the whole GetObjectResponse and handle it elsewhere in the code, so I might just have to rewrite it to use only the stream and copy it out to a MemoryStream and return that. Thanks for the info.

Alternatively, just rewrite everything that was using the GetObjectResponse to just be inside a using statement and it's actually done the trick, even without the DefaultConnectionLimit change. Thanks @randall-peakey-com!

We have been hitting this issue sporadically in our application for over a year - always while hitting the S3 api concurrently on multiple threads.  We just hit again tonight and I got a stack trace of the hung thread.  See below.  We have hit this on different sdk calls: GetObject, GetObjectMetadata, and PutObject.  Our situation was greatly improved a while ago by auditing every call to the sdk to make sure we weren't leaking requests or s3 clients.
Here's the stack trace I captured tonight.  At the time we detected this hang, we had 16 threads concurrently hitting s3.   This on on version 3.3.0 of the sdk on .Net Framework 4.7, Windows Server 2016, running on a machine inside EC2.  Does anything jump out here?  I haven't tried moving all our S3 access to http (as ooposed to https) as I see suggested above.  Is that still a recommended workaround?
StackTrace:    at System.Net.UnsafeNclNativeMethods.OSSOCK.recv(IntPtr socketHandle, Byte* pinnedBuffer, Int32 len, SocketFlags socketFlags)    at System.Net.UnsafeNclNativeMethods.OSSOCK.recv(IntPtr socketHandle, Byte* pinnedBuffer, Int32 len, SocketFlags socketFlags)    at System.Net.Sockets.Socket.Receive(Byte[] buffer, Int32 offset, Int32 size, SocketFlags socketFlags, SocketError& errorCode)    at System.Net.Sockets.Socket.Receive(Byte[] buffer, Int32 offset, Int32 size, SocketFlags socketFlags)    at System.Net.Sockets.NetworkStream.Read(Byte[] buffer, Int32 offset, Int32 size)    at System.Net.FixedSizeReader.ReadPacket(Byte[] buffer, Int32 offset, Int32 count)    at System.Net.Security._SslStream.StartFrameHeader(Byte[] buffer, Int32 offset, Int32 count, AsyncProtocolRequest asyncRequest)    at System.Net.Security._SslStream.StartReading(Byte[] buffer, Int32 offset, Int32 count, AsyncProtocolRequest asyncRequest)    at System.Net.Security._SslStream.ProcessRead(Byte[] buffer, Int32 offset, Int32 count, AsyncProtocolRequest asyncRequest)    at System.Net.TlsStream.Read(Byte[] buffer, Int32 offset, Int32 size)    at System.Net.PooledStream.Read(Byte[] buffer, Int32 offset, Int32 size)    at System.Net.Connection.SyncRead(HttpWebRequest request, Boolean userRetrievedStream, Boolean probeRead)    at System.Net.ConnectStream.ProcessWriteCallDone(ConnectionReturnResult returnResult)    at System.Net.ConnectStream.CallDone(ConnectionReturnResult returnResult)    at System.Net.ConnectStream.CloseInternal(Boolean internalCall, Boolean aborting)    at System.Net.ConnectStream.System.Net.ICloseEx.CloseEx(CloseExState closeState)    at System.Net.HttpWebRequest.EndWriteHeaders_Part2()    at System.Net.HttpWebRequest.EndWriteHeaders(Boolean async)    at System.Net.HttpWebRequest.WriteHeadersCallback(WebExceptionStatus errorStatus, ConnectStream stream, Boolean async)    at System.Net.ConnectStream.WriteHeaders(Boolean async)    at System.Net.HttpWebRequest.EndSubmitRequest()    at System.Net.Connection.SubmitRequest(HttpWebRequest request, Boolean forcedsubmit)    at System.Net.ServicePoint.SubmitRequest(HttpWebRequest request, String connName)    at System.Net.HttpWebRequest.SubmitRequest(ServicePoint servicePoint)    at System.Net.HttpWebRequest.GetResponse()    at Amazon.Runtime.Internal.HttpRequest.GetResponse()    at Amazon.Runtime.Internal.HttpHandler1.InvokeSync(IExecutionContext executionContext)
at Amazon.Runtime.Internal.RedirectHandler.InvokeSync(IExecutionContext executionContext)
at Amazon.Runtime.Internal.Unmarshaller.InvokeSync(IExecutionContext executionContext)
at Amazon.S3.Internal.AmazonS3ResponseHandler.InvokeSync(IExecutionContext executionContext)
at Amazon.Runtime.Internal.ErrorHandler.InvokeSync(IExecutionContext executionContext)
at Amazon.Runtime.Internal.CallbackHandler.InvokeSync(IExecutionContext executionContext)
at Amazon.Runtime.Internal.RetryHandler.InvokeSync(IExecutionContext executionContext)
at Amazon.Runtime.Internal.CallbackHandler.InvokeSync(IExecutionContext executionContext)
at Amazon.Runtime.Internal.CallbackHandler.InvokeSync(IExecutionContext executionContext)
at Amazon.S3.Internal.AmazonS3ExceptionHandler.InvokeSync(IExecutionContext executionContext)
at Amazon.Runtime.Internal.ErrorCallbackHandler.InvokeSync(IExecutionContext executionContext)
at Amazon.Runtime.Internal.MetricsHandler.InvokeSync(IExecutionContext executionContext)
at Amazon.Runtime.Internal.RuntimePipeline.InvokeSync(IExecutionContext executionContext)
at Amazon.Runtime.AmazonServiceClient.Invoke[TRequest,TResponse](TRequest request, IMarshaller2 marshaller, ResponseUnmarshaller unmarshaller)    at Amazon.S3.AmazonS3Client.GetObjectMetadata(GetObjectMetadataRequest request)

I've posted a workaround that is currently working for us, I believe: https://github.com/dotnet/corefx/issues/21796#issuecomment-381515493

It's April and 2019 and, years later, we are STILL experiencing random and sporadic hangs when accessing S3 via the .Net AWSSDK with a high degree of parallelism.
We've tried disabling SSL.  We've done multiple audits for leaked IDisposables.  We've messed with ServicePointManager.DefaultConnectionLimit.  The hangs still persist.
Are others still experiencing this issue as well?

Hey @tomlor,
We just worked this issue by first:
https://github.com/dotnet/corefx/issues/21796#issuecomment-381515493
And for downloading the blob data, we instead just generate a signed URL via the s3 client, and use HttpClient to download it instead of the s3 SDK. No issues now for 12 months.

I'm not sure how to reopen this issue. So adding my problem here.
We have a server side application in .Net developed using Nancyfx framework. Running as selfhost. This application receives multipart request with multiple files(around 100). All these files are supposed to be upload to S3 bucket. Using Parallels to upload files to S3 bucket. Right now creating s3 object for every task. This is causing too many HTTP connections and after a while system is become slow or s3 latency increases. We have optimized at TCP level, to reduce the TcpWaitTimeDelay to 30 seconds.
Can anyone help how to resolve this issue ?
How can we reduce AmazonS3Client HTTP connection pool ?
Using Windows 2012
AWS SDK version : 3.3.7
Let me know if any further information require.
Thanks in advance.

I have been fighting this issue for 6 months and still not good resolution.  Help

I think there is still an issue here.
I'm strangely getting this issue in a ASP .NET Core 3.1 Web API project, but not getting it in a ASP .NET Core 3.1 MVC project. The code calling the GetObjectAsync task is exactly the same in both projects and using the same credentials and bucket.
Been tearing my hair out all day, when this should be simple.

@dyardyGIT @clevrdavid Depending on the stack trace you get when things get locked up, https://github.com/dotnet/runtime/issues/22592#issuecomment-381515493 may fix this for you like it did for us.
As for too many tasks, perhaps wrap your upload code path in a Polly Bulkhead code block which will help throttle the parallelism: https://github.com/App-vNext/Polly/wiki/Bulkhead

I am shocked that there is not legitimate answer to this issue.  I understand the 'randomness' makes it difficult but we have tried many things on both .net framework and .net core.  This issue really was surfaced to a much greater extent when we made our move from Windows 2008 to Window 2012.  On 2012 we have any to address http connection/socket issues.
The comment about setting ServicePointManager.DefaultConnectionLimit=50 we have tried with no success.

@dyardyGIT Disposing has certainly eliminated this problem for many.  https://github.com/aws/aws-sdk-net/issues/152#issuecomment-297933416
Have you given this a try?

oading the blob data, we instead just generate a signed URL via the s3 client, and use HttpClient to download it instead of the s3 SDK. No issues now for 12 months.

Can you share how you generate an url using the sdk? thanks!

Yes, it looks like this now, and still having the issue.
using (GetObjectResponse response = _amazonClient.GetObject(request))
{
using (Stream responseStream = response.ResponseStream)
{
amazonFile = new AmazonFile();
amazonFile.FileBytes = ReadStream(response.ResponseStream);
amazonFile.Size = amazonFile.FileBytes.LongLength;
}
}

Looks like our problem was mostly upload related, where it would hang, so we made our upload code just get the signed URL to upload to and PUT the data via regular HTTP calls:
		/// <summary>
		/// Upload to the specified key the provided stream of data
		/// </summary>
		async Task UploadUsingWebRequestAsync (string key, Stream stream) {
		    var client = CreateClient ();

		    // Calculate URL to upload to
		    var signedRequest = new GetPreSignedUrlRequest {
		        BucketName = BucketName,
		            Key = key,
		            Verb = HttpVerb.PUT,
		            Expires = DateTime.UtcNow.AddHours (1)
		    };

		    // Generate Url
		    var uploadUrl = client.GetPreSignedURL (signedRequest);

		    // Perform Upload
		    // Create content
		    var streamContent = new StreamContent (stream);

		    // Add Tag header?
		    if (tagHeaderValue != null)
		        streamContent.Headers.Add (AmzTaggingHeaderKey, tagHeaderValue);

		    // Create Retry Policy
		    var retryPolicy = Policy<HttpResponseMessage>
		        .Handle<HttpRequestException> ()
		        .WaitAndRetryAsync (3, x => TimeSpan.FromSeconds(x));

		    // Put File
		    using (var response = await retryPolicy.ExecuteAsync (() => SharedClient.PutAsync(uploadUrl, streamContent))) {
		        // Verify
		        if (!response.IsSuccessStatusCode)
		            throw new ArgumentException ($"Upload of blob failed ({key}): {await response.Content.ReadAsStringAsync()}");
		    }
		}

As for downloading, we do less of that, but you can imagine the flow is similar (client.GetPreSignedUrl), then just do a HTTP GET on that Url.

Yes, it looks like this now, and still having the issue.
using (GetObjectResponse response = _amazonClient.GetObject(request))
{
using (Stream responseStream = response.ResponseStream)
{
amazonFile = new AmazonFile();
amazonFile.FileBytes = ReadStream(response.ResponseStream);
amazonFile.Size = amazonFile.FileBytes.LongLength;
}
}

I see you are disposing of the Stream and the GetObjectResponse, but not the AmazonS3Client.

I'm a bit late to the party but I'd like to give my two cents on this issue.
We're running .NET 4.7 on windows server 2016. We have multiple worker instances (some of which are running Quartz) and multiple instances running ASP.NET Web API. API instances never displayed any problems regarding S3 requests hanging, however, worker instances did.
At first, I thought that we might have some kind of deadlock because logging in place wasn't verbose enough to pinpoint the exact location where the application stopped. It was clear that these hangs were happening only when the system was under a considerable load.
Dumping the stack trace pointed me in the wrong direction. It showed that my service blocked on the following snippet executing Exists:
public bool ObjectExists(string bucketName, string objectKey)
        {
            var s3FileInfo = new S3FileInfo(_s3Client, bucketName, objectKey);
            return s3FileInfo.Exists;
        }

I've tried everything I could find related to this issue including updating to .NET 4.8, using single instance S3 client, using different S3 clients for every unit of work, changing the existing implementation to use different SDK methods, etc.
Tuning the ServicePointManager.DefaultConnectionLimit = N certainly did have an effect on how soon the service ground to a halt. Using netstat I noticed that there were N connections to S3 with CLOSE_WAIT status. According to TCP specification, this state indicates that the server (S3) received and acknowledged signal for closing the connection but the client (your application) has not yet closed the socket.
This information steered me away from the problem source and into the esoteric search for the bug in the framework (hence the update to a newer version of the framework). While there might be cases where the framework bug caused your implementation to misbehave, that wasn't my case.
Enter the following comment:

@dyardyGIT Disposing has certainly eliminated this problem for many. #152 (comment)
Have you given this a try?

I inspected the facade implementation that we used to wrap S3 related actions and discovered that one of the s3Client.GetObjectAsync(getObjectRequest) objects was not disposed of. That method is called in the normal service flow but it's kind of buried deeper in the service layer. This caused the number of open connections to grow and eventually lead service to a grinding halt.
The interesting part is that because of the way the service was implemented, it would always stop on the same method (ObjectExists shown above) where there was no need for disposal per se.
Disposing of the object properly meant that no connections were left hanging and that the service could handle bigger loads without stopping.
I still don't understand why the SDK lets this happen in the first place. I would've been happier with an exception telling me that the number of connections has been exceeded and that new connections cannot be established.

I think I'm running into this issue as well. I'm trying to upload a 30kB text file from a .NET 4.7.2 desktop app with AWSSDK.S3 <IP_ADDRESS>. I run as a plugin in another app, which might be single-threaded.
This line from the official docs never uploads the file and hangs until I force close the application. This happens every single time. I also see lingering CLOSE_WAIT items in netstat.
 PutObjectResponse response = await client.PutObjectAsync(putRequest);
I can only upload the file and close the request when I wrap the PutObjectAsync in a using statement, even though the only disposable object is the Task that it creates.
public static void UploadFile()
{
   // pseudocode
   using (credentials)
   using (client)
   create putRequest
   PutObjectAsync(client, putRequest).Wait();
}

public static async Task PutObjectAsync(AmazonS3Client client, PutObjectRequest putRequest)
{
  using (var task = client.PutObjectAsync(putRequest))
  {
    var success = task.Result.HttpStatusCode == HttpStatusCode.OK;
    if (!success) throw new CannotUploadFile();
  }
}

But this is no longer async since there is no await in the PutObjectAsync method. So the UI becomes unresponsive. Any ideas on how to work around this?
A second, related issue is that this behavior gets even worse when there is no internet connection. My working sample above times out at about 100 seconds. That's a long time to wait. I have found no setting that had any effect on this.

@brinkdinges my workaround I'd suggest is to bypass the SDK for uploading, see my comment here https://github.com/aws/aws-sdk-net/issues/152#issuecomment-587210064
The workaround is to have the SDK generate the HTTPS Upload URL (that includes the signing key), then use HttpClient to PUT the data directly (pretty much what the SDK does, anyway).

@brinkdinges your using statement is also wrong, you should await the task to ensure you are async:
public static async Task PutObjectAsync(AmazonS3Client client, PutObjectRequest putRequest)
{
  // Do not dispose of task, dispose of the async result (and await the task instead of accessing .Result property directly)
  // I am not at a computer, perhaps PutObjectAsync does not implement IDisposable, in which cause using not required.
  using (var putResponse = await client.PutObjectAsync(putRequest))
  {
    var success = putResponse.HttpStatusCode == HttpStatusCode.OK;
    if (!success) throw new CannotUploadFile();
  }
}

@Plasma Thank you. I had already tried to use your implementation, but I couldn't find what the SharedClient and Policy where. I found the policies in the SDK, but none that used generics. Could you clarify that?
PutObjectAsync indeed doesn't implement IDisposable. But without the using, the request never ends or gives a result. That is the real problem.

Ah, SharedClient is just an instance of HttpClient, and Policy is Polly.Net Retry Policy -- this part is kinda optional and you can skip it.
But, your original question above, you had pasted code with a known anti-pattern of using async, where a deadlock can definitely occur, because you are not await'ing a task, but instead trying to access the .Result property directly. Ignoring my workaround, what if you change that whole method to this?
public static async Task PutObjectAsync(AmazonS3Client client, PutObjectRequest putRequest)
{
  var result = await client.PutObjectAsync(putRequest);
  var success = result.HttpStatusCode == HttpStatusCode.OK;
  if (!success) throw new CannotUploadFile();
}

I am very sure that's what I started with. It didn't work then, it does now 😄 Thanks for pushing me to do it the correct way.


Guest users can't see videos

Hi there,
What's the best method to embed videos in Powerapps?
We have external /guest users. Have already added them as users in Azure AD and the appropriate group but still can't access videos that we have placed in our app.
Any help would be appreciated.
Thanks,
Andrew

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b5b79de9-91fd-adc9-2515-d2bb84cfd2b2
Version Independent ID: 62c9fd03-2d88-475f-c857-75647f263a81
Content: Share a canvas app with guest users (contains video) - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/share-app-guests.md
Service: powerapps
Sub-service: canvas-maker
GitHub Login: @alaug
Microsoft Alias: alaug

Thanks for your comment, @mehr81. This issue has been assigned to the doc author for review.


No date is reflected for the first time when im clicking

No date is reflected for the first time when i'm clicking . It always shows the current date.Can you please look into this. it works perfectly with date pickers but nothing happens when the day is clicked in weekview

@AndroidSources will get back to you soon :)

@AndroidSources is that only with the current week only right, like if you scroll to next week you can do this right?

@rameshvoltella  Yeah. It is only with current week . Thanks for your quick reply

Thanks for fixing this @rameshvoltella . This weekpicker is lot helpful.


Fix test memory bugs v1

Hi Emre, could you please add some description of this pull request

Hi @efriedrich ,
First patch initialize layer parameter with a default value, so that they would not be used uninitialized.
Second patch destroys ivi_application object at deinitialization, because it was created at setup and it should be destroyed. Otherwise there would be a memory leak.


When sending somebody money, we show a negative amount

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

open app
Select "+" > "Send money"
enter amount

Expected Result:
We should not allow negative amount
Actual Result:
User can see negative amount displayed
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.33-0
Reproducible in staging?:
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @cead22
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1642804796305400
View all open jobs on GitHub

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal (if marked External)
Changes
We can edit IOUPreview.js .The cachedTotal variable takes the sign of value in the account.
We can modify the following
https://github.com/Expensify/App/blob/7e6e7e87c11a031fee3ce5216e6f8ea2b250d1fb/src/components/ReportActionItem/IOUPreview.js#L114-L118
to:
   const absoluteCachedTotal = props.iouReport.total && props.iouReport.currency
        ? props.numberFormat(
            Math.abs(props.iouReport.total) / 100,
            {style: 'currency', currency: props.iouReport.currency},
        ) : '';

This will resolve the sign issue.

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@cead22 could you please share a screenshot of how this appears on your end? I believe this is intended behavior, as $10 was deducted from Zach's wallet to pay you. If I'm correct, the $10 amount should appear without a negative sign on your side.

Posted to Upwork! https://www.upwork.com/jobs/~0193348773bfafcd5e

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

Triggered auto assignment to @Luke9389 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@sig5 proposal looks good. But @sig5 please post proposals after the issue is triaged. I will consider this point while reviewing future proposals.
cc: @Luke9389
:ribbon: :eyes: :ribbon:  C+ reviewed

📣 @sig5 You have been assigned to this job by @kadiealexander!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Was this fixed internally on the backend? I was in the process of submitting my PR, when I observed that the negative sign doesn't show up anymore.

Oh, interesting. I just searched the issues in this repo, and it doesn't seem to be a dupe. Let me check out the git blame on the file to see if/where it's been addressed. We'll almost certainly pay you anyway for this one.

Hmm, doesn't look like anyone's touched this file. Maybe it got fixed upstream?
Can you test again just to be sure?

Well the code that concerns it uses cachedtotal which is basically iouReport.total :
https://github.com/Expensify/App/blob/7e6e7e87c11a031fee3ce5216e6f8ea2b250d1fb/src/components/ReportActionItem/IOUPreview.js#L114-L118
https://github.com/Expensify/App/blob/7e6e7e87c11a031fee3ce5216e6f8ea2b250d1fb/src/components/ReportActionItem/IOUPreview.js#L194-L197
The keys in onyx suggest that these are received as positive for the sent amounts too, and hence the bug doesn't appear.

This is a pretty rare case (that an issue is solved when we sit down to code it). It's never happened to me before (unfortunately 😄 ).
@kadiealexander and I spoke about it and we feel that it's fair to pay you anyway @sig5. 👍

All paid!! Thanks for all your work on this one @sig5, sorry it wasn't able to be used!

That's very generous of you Luke and Kadie! Would have loved to see my contribution here, but in the end, all we want is a perfect Application!


Tooltip of close button appears on ToastNotification icon

Reason: Same iconDescription variable is used for both icons
Source:
<NotificationIcon kind="{kind}" iconDescription="{iconDescription}" />
<NotificationTextDetails
  title="{title}"
  subtitle="{subtitle}"
  caption="{caption}"
>
  <slot />
</NotificationTextDetails>
{#if !hideCloseButton}
  <NotificationButton
    iconDescription="{iconDescription}"
    on:click="{close}"
  />
{/if}

Fixed in v0.37.0

@metonym I do not know if i properly tested the fix at the time, but the problem appears to exist right now because NotificationIcon has a default iconDescription
export let iconDescription = "Closes notification";

I'll take another look.

Released in v0.71.0


[Wave Collect][QBO] IOU - Application crashes when trying to select IOU category

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4513964
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:
Preconditions:
Create a WS, invite an employee, log in to the administrator and employee accounts in parallel.

Open https://staging.new.expensify.com/
Create two categories in the WS on behalf of the administrator
Disable one created category
Delete the disabled category
On behalf of the employee, start creating a manual query in the WS room.
Go to the category selection menu
Stop creating the IOU
Repeat steps 4-6 several times

Expected Result:
Once a category is deleted by the administrator, the employee should not have the application crash when attempting to select an IOU category
Actual Result:
After an administrator deletes a category, an employee crashes the application when trying to select a category when creating an IOU
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/3e4482bf-1e45-483b-aaeb-9fe419dbf16f
View all open jobs on GitHub

@aldo-expensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

I have been trying to reproduce and I haven't been able to. Marc also tried https://expensify.slack.com/archives/C03TQ48KC/p1714090587774089?thread_ts=1714088810.604399&cid=C03TQ48KC

This may be a hard to reproduce race condition, I think it can be worth to work on it once we have more reliable  steps to reproduce.

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Wait, what has this got to do with QBO?

Wait, what has this got to do with QBO?

nothing? 😆

Haha cool, taken it out of the QBO tracker.

No updates

No updates, focusing in QBO

Closing this, reopen if we find a way to reproduce


Setting BarTextColor and BarBackgroundColor in xaml has no effect in Android

Setting BarTextColor and BarBackgroundColor in xaml has no effect in Android.
Setting it in the code behind does work.

Also got this issue, it's fixed when I add 4 tabs to the tabbar, but when I add less items, it doesn't set the colors.

@eEmmanuelvmb  I fixed it by creating my own custom tab bar.
https://github.com/c-lamont/PXTabs

@eEmmanuelvmb set  _bottomBar.MaxFixedTabCount = 0; in BottomBarPageRenderer.cs
// create bottomBar control
_bottomBar = BottomNavigationBar.BottomBar.Attach (_frameLayout, null);
_bottomBar.MaxFixedTabCount = 0;
_bottomBar.NoTabletGoodness ();


.Net 4.5.2 End-of-life

.net 4.5.2 will be EOL on April 16, 2022. This means no security updates.
Microsoft advises .NET developers to migrate their apps to at least .NET Framework 4.6.2 or later before April 26, 2022, to keep receiving technical support and security updates.
.NET Framework 4.6.2 (shipped almost six years ago) and .NET Framework 4.8 (shipped three years ago) are both compatible in-place replacements and stable runtimes already "broadly deployed to hundreds of millions of computers via Windows Update (WU)."

Thanks I'll look into updating the version when I make a new release. Not sure when that will be though.

I updated it to 4.7.2 in release 1.17. Let me know if you have any issues with it.


Backlight threshold doesn't work

[x] I confirm that this is an issue rather than a question.

Bug report
Backlight threshold 0 all lights shine with 50 %, max was 98 % with minimum effect.
Steps to reproduce
Backlight threshold 0
LED stripe apa102 with 210 LEDs
What is expected?
All lights off if signal black and Backlight threshold 0
What is actually happening?
System
Hyperion Server:

Build:       master (GitHub-e6c0e97/060d9f4-1586506755)
Build time:  Apr 11 2020 18:43:25
Git Remote:  https://github.com/hyperion-project/hyperion.ng.git
Version:     2.0.0-alpha.4
UI Lang:     en (BrowserLang: de)
UI Access:   default
Avail Capt:  dispmanx,v4l2,framebuffer,qt

Hyperion Server OS:

Distribution: Raspbian GNU/Linux 9 (stretch)
Arch:         arm
Kernel:       linux (4.19.88-v7+ (WS: 32))
Browser:      Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Can you re-test with alpha10 and report back please, if the issue is still present?

Closing, as no feedback provided. Can be reopened, if needed.


two-way bind is always tip error

i use two-way bind in my compontent,but it always tip error: vue.js:1018 [Vue warn]: Prop "value" expects a two-way binding type. But when i use  :value.sync it can run will,i has try set type.

Hi!
Please make sure to ask the question on the forums or the gitter chat. We keep questions out of issues :smile:
That's normal. Two way binding is achieved the sync modifier


Release 0.3.0

This is a list of activities that should be done before release announce
First, things before release
Breaking changes - merge in this PR

[x] New deployment state management
[x] New CLI interface: breaking changes in serve, apply-remote, build and declare

Other changes - merge in this PR

[x] SageMaker deployments
[x] K8s deployments

Docs - merge in docs PR

[x] Finish semi-generated API reference PR https://github.com/iterative/mlem.ai/pull/172

In https://github.com/iterative/mlem.ai/pull/188:

[ ] GS: Build, Serve, Deploy - needs update before release
[ ] CLI/API references - needs update before release
[ ] User Guide: create pages for Deployments (sagemaker, heroku, k8)
[ ] User Guide: create pages for URI resolvers (and put them in “Working with remote projects”)
[ ] Advanced Usage (new section?): add Objects reference, move “ABCs”, “Extending” from UG there

Blog post

[ ] blog post re release

Example-repo - PR in example-repos-dev

[ ] update example-mlem-get-started

Update the website code animations

[ ] https://mlem.ai

Second, the release itself
MLEM Release

[ ] merge this branch
[ ] release it on PyPi
[ ] merge docs PR
[ ] merge PR in example-repos-dev and update iterative/example-mlem-get-started

Third, things after release

[ ] remove xfail mark from tests/cli/test_mail.py::test_commands_docs_links

@madhur-tandon, btw this branch have few issues I've reported - they prevent me from finishing GS for build and deploy in new docs PR. If you could fix them, that would be awesome!


contributing

can you create an slake or something to we have connection to contribute in this project

Thanks for your question. We are using #django discord channel. Please join to discussion at https://strawberry.rocks/discord :)


Snippets not syncing betwen iPad and iPhone

Describe the bug
When I go to Settings > Snippets on iPad I see many more snippets than when I go to the iPhone so they are not syncing.
Information

Device : iPad 7th Gen, iPhone 12 mini
OS : iPad 14.6
WebSSH Pro version : 14.18.4

Screenshots

To Reproduce
Steps to reproduce the behavior:

Go to 'Settings'
Touch on "Snippets"

Please relaunch the full sync :

WebSSH Settings > iCloud > Disable
Wait 10 seconds
Enable sync again

Your snippets will be synced in about 30 to 60 seconds.

@mbierman Does the provided steps above fix your sync?

Yes, thank you.


[sysrst_ctrl] ULP wakeup feature

I have one more feature to implement. It's the wakeup circuitry to exit from the ultra-low-power state.
-Eric

Just finished the coding. Waiting for a good time to create the pull request. The team is working on the Silver integration. sysrst_ctrl has two new pins, z3_wakeup and lid_open.

@tjaychen

This has been implemented.


Add support for Group Protected Environments

Add support for Group Protected Environments, similar to Project Protected Environments.
https://docs.gitlab.com/ee/api/group_protected_environments.html

@svanharmelen This is ready for your review.

@svanharmelen Thanks for the review.  I had the initial thought of re-using the project protected environment structs, but I wasn't sure if it would be better to create structs specific to groups, in case they do change in projects.  In the future, would you prefer re-use if the structs are the same?

I don't know... Generally I prefer to re-use structs if it makes sense, but in this case I think this is OK.


Import name clash for class Text

The name 'Text' is defined in the libraries 'package:flutter/src/widgets/text.dart' and 'package:flutter_quill/src/models/documents/nodes/leaf.dart (via package:flutter_quill/flutter_quill.dart)'

I suggest the using different name for class Text so it doesn't happen.

Current workaround is import 'package:flutter_quill/flutter_quill.dart' as quill;
then quill.QuillController...


Possible to get multiple images?

I can only seem to get one gallery image. Is it possible to get all the images back? or at least a few?

@chovy this repo is no longer maintained so you'd have to implement it yourself if you wanted it. Though I do think it's possible from the API.


doesn't accept mfaCode

In the Homebridge Configuration, the parameter "mfaCode" is rejected as invalid.

it might be because the code expired? try to time it when your code is newly generated, then paste in config, save, and restart asap... i was having similar issue before.


Nepi Jano - Chrome

When installing an add-in to Chrome, it installs it, but when it starts again Chrome will block it with the add-on not from Google.

That is a standard behaviour for any extension NOT installed from Google Web Store. You need to enable "Developer mode" in the top-right corner of the Extensions tab.

Please have you tried to install the extension from Google Store https://chrome.google.com/webstore/detail/nepi-jano/dmiebaglkdeebobffhbomapifjjjjakj?

Thanks

Od: Viliam Pucik<EMAIL_ADDRESS>Komu: viliampucik/nepi-jano<EMAIL_ADDRESS>Dátum: 29.09.2017 23:12
Predmet: Re: [viliampucik/nepi-jano] Nepi Jano - Chrome (#21)

Please have you tried to install the extension from Google Store https://chrome.google.com/webstore/detail/nepi-jano/dmiebaglkdeebobffhbomapifjjjjakj https://chrome.google.com/webstore/detail/nepi-jano/dmiebaglkdeebobffhbomapifjjjjakj?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/viliampucik/nepi-jano/issues/21#issuecomment-333240375, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae5ad3F2tmzS8fu-gXDvZlOhWa9UeVsmks5snV0qgaJpZM4Po_hl.


Indenting of user drop down seems non intuitive

I took me a while to understand the sections in the user drop down menu.  To me the indenting seems backwards.  e.g. notifications is indented and less prominent looking than the to following items, which are types of notifications: mentions and subscribed events.
Would it make sense to have notifications, account, and adminstrator tools left justified, and the options under of each of these headings be smaller and/or indented?

Yeah these are the default Bootstrap styles, which I am not happy with either. I'll implement something similar to what you described.


Remove Windows capture support

Windows support relies on a `dragent_win_hal.dll`, which isn't
exactly easily available (binaries, let alone the source).

This should not influence the ability to read captures created
on Linux with Windows binaries, but it *does* remove udig
(userspace instrumentation) and Docker on Windows support.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig
/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

s/ 🎉 / ✅ /
? :)

LGTM label has been added.  Git tree hash: 16cc2d87739abfe27210a7ee706d2485b5611cf5

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, gnosek, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,LucaGuerra,gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


How to get all sockets

Whether there is relevant api available?

Explain more.

多解释一下。
Want to monitor the total number of service sockets

Total number of sockets successfully created on the server

save connections to a list
connected(add):https://github.com/netty/netty/blob/d010e63bf5bf744f2ab6d0fc4386611efe7954e6/transport/src/main/java/io/netty/channel/ChannelInboundHandler.java#L37
disconnected(remove):
https://github.com/netty/netty/blob/d010e63bf5bf744f2ab6d0fc4386611efe7954e6/transport/src/main/java/io/netty/channel/ChannelInboundHandler.java#L43


Arrow shape

It would be great to have an arrow shape support like in the attached image.

I created a pull request with this feature: #492


MergeStrategy seems to be completely broken (mergeWith failure)

Re-post of https://github.com/angular/devkit/issues/745
Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Area
- [ ] devkit
- [x] schematics

Versions
Node v8.11.1
NPM 5.8.0
Mac OS High Sierra
Repro steps
Use the following schematic
import { Rule, url, apply, mergeWith, chain, MergeStrategy } from '@angular-devkit/schematics';

export function index(): Rule {
  return chain([
    simpleMerge(),
  ]);
}

function simpleMerge(): Rule {

  const source = url('./files');

  return mergeWith(source, MergeStrategy.Overwrite);
}

The log given by the failure

schematics .:boilerplate
ERROR! /src/app/app.component.html already exists.
ERROR! /src/app/app.component.spec.ts already exists.
ERROR! /src/app/app.component.ts already exists.
ERROR! /src/app/app.module.ts already exists.
ERROR! /src/assets/.gitkeep already exists.
ERROR! /src/environments/environment.prod.ts already exists.
ERROR! /src/environments/environment.ts already exists.
ERROR! /src/index.html already exists.

Desired functionality
All files should be overwritten.
Mention any other details that might be useful
I tried every MergeStrategy possible (AllowOverwriteConflict, etc.), same result.
https://github.com/angular/devkit/issues/745
https://stackoverflow.com/questions/48957132/how-to-overwrite-file-with-angular-schematics

Could you provide the versions used?
I cannot answer with certainty without knowing the versions but this PR (https://github.com/angular/angular-cli/pull/11274) will most likely correct the behavior.

version 0.6.8
dup repo https://github.com/gatimus/schematics-merge-strategy

Could you try with the RC of 0.7? I fixed a lot of issues by reworking the whole Tree implementation, should have fixed a few of those merging issues (amongst others, e.g. branching).

Dupe of https://github.com/angular/angular-cli/issues/11246. Let's keep this one for tracking though as it has more information.

This is making me cry 😢

Is this already fixed?
I have following workaround:
const templateSource = apply(url('./project-files'), [
      template({ ...strings, ...options }),
      move(options.path),
      forEach((fileEntry: FileEntry) => {
        if (host.exists(fileEntry.path)) {
          host.overwrite(fileEntry.path, fileEntry.content);
        }

    return fileEntry;
  }),
]);

Hi,
For me, the issue appears after upgrading my schematics "dependencies" from:
 {
    "@angular-devkit/core": "^0.6.8",
    "@angular-devkit/schematics": "^0.6.8",
    "typescript": "^2.5.1"
  },

to:
 {
    "@angular-devkit/core": "^0.7.3",
    "@angular-devkit/schematics": "^0.7.3",
    "typescript": "^2.9.0"
  },

Version v0.6.8's mergeWith  was working fine...
@joeson1 : i tried your workaround, but it didn't help 😞 ...

@joeson1 where do you assign host?

@tinesoft I get the exact same behavior with v0.6.8 as with v0.7.3

I'm still having this issue, in case someone needs to know it's still not fixed. Using version 0.8.6

I have the same issue, however if I run schematics my-schematic:my-schematic it will work BUT if I run ng g my-schematic:my-schematic it will give me the already exists error message. Can anyone explain why?

@egervari and @bautistaaa could you let me know if this workaround works for you?
https://stackoverflow.com/a/53230034/684869

@mattezell Thank you for workaround example. However, I'd assume that you don't need this "move('.')" - everything should work even w/o it.

I have the same problem not using a Source but trying to create/override custom stuff in the Tree. There's no simple way via MergeStrategy to avoid the exists check?
My hacky intuition thought that using tree.overwrite with MergeStrategy.AllowOverwriteConflict would default to create the files I'm trying to overwrite. Or create with AllowCreationConflict would overwrite, something like that would be useful.

There's no simple way via MergeStrategy to avoid the exists check?

I believe this is exactly what MergeStrategy.Overwrite is suppose to do.

Hi,
I experience the same issue.
I setup a minimal reproduction: https://github.com/GregOnNet/merge-strategie-issue
Setup

The repository contains a file .prettierrc
My schematic overwrite loads another .prettierrc from ./templates
MergeStrategy.Overwrite is configured as 2nd parameter of apply.
The repository contains a unit test to check if the template overwrites the origin file.

Observed behaviour

The unit test succeeds
The integration test using schematics fails

Please refer to section Repro Steps to see the details.

Versions
Node v11.11.0
NPM 6.9.0
Mac MacOS Mojave 10.14.3

@angular-devkit/core: 7.3.6
@angular-devkit/schematics: 7.3.6

Repro Steps
git clone https://github.com/GregOnNet/merge-strategie-issue.git
cd merge-strategie-issue

npm install
npm test # Everything is fine
npm run build

schematics .:overwrite
# ERROR
ERROR! /.prettierrc already exists.
The Schematic workflow failed. See above.

If I can provide any further information, please let me know. 👍

Is there any plan to fix this? Any current workarounds?

@tscislo this is my current workaround:
export function overwriteIfExists(host: Tree): Rule {
  return forEach(fileEntry => {
    if (host.exists(fileEntry.path)) {
      host.overwrite(fileEntry.path, fileEntry.content);
      return null;
    }
    return fileEntry;
  });
}

export function mySchematic(options: MyOptions): Rule {
  return (host: Tree, context: SchematicContext) => {
    /* ...logic... */
    const templateSource = apply(
      url('./files'),
      [
        template({
          ...strings,
          ...options
        }),
        move(options.path),
        options.overwrite ? overwriteIfExists(host) : noop()
      ]
    );

    return mergeWith(templateSource);
  };
}

Also other variations in answers her https://stackoverflow.com/questions/48957132/how-to-overwrite-file-with-angular-schematics

For me even workarounds did not work.
When I apply them - changes are simply ignored and I get message Nothing to be done....

A note about the workaround using manual forEach and overwrite.
Make sure that you put the forEach before the move since the file paths that you get are relative to the root project. And also make sure that you create the files first before trying to overwrite them. (e.g calling externalSchematic first).Took me a while to notice that.


Set Icon/manifest

Is it possible to set an icon, a name or provide the source code url (specified in manifest.toml)?

Yes, by putting it into the public directory


[DO NOT MANUAL MERGE] Release Qualification

Trigger release qualification jobs
none

@silverdev: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-release-qualification.sh
f4bafeae72196eed4835ad4e4ef4df7e4424bb78
link
/test daily-release-qualification

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Segmentation Fault on AsyncActor::ensure_thread

Getting frequent segmentation faults on GKE using stackdriver gem. More specifically:
-- Ruby level backtrace information ----------------------------------------
/usr/local/bundle/gems/stackdriver-core-1.2.0/lib/stackdriver/core/async_actor.rb:315:in `block (2 levels) in ensure_thread'
/usr/local/bundle/gems/stackdriver-core-1.2.0/lib/stackdriver/core/async_actor.rb:291:in `async_run_job'
/usr/local/bundle/gems/google-cloud-logging-1.2.2/lib/google/cloud/logging/async_writer.rb:334:in `run_backgrounder'
/usr/local/bundle/gems/google-cloud-logging-1.2.2/lib/google/cloud/logging/project.rb:277:in `write_entries'
/usr/local/bundle/gems/google-cloud-logging-1.2.2/lib/google/cloud/logging/service.rb:124:in `write_entries'
/usr/local/bundle/gems/google-cloud-logging-1.2.2/lib/google/cloud/logging/service.rb:324:in `execute'
/usr/local/bundle/gems/google-cloud-logging-1.2.2/lib/google/cloud/logging/service.rb:125:in `block in write_entries'
/usr/local/bundle/gems/google-cloud-logging-1.2.2/lib/google/cloud/logging/v2/logging_service_v2_client.rb:358:in `write_log_entries'
/usr/local/bundle/gems/google-gax-0.8.7/lib/google/gax/api_callable.rb:248:in `block in create_api_call'
/usr/local/bundle/gems/google-gax-0.8.7/lib/google/gax/api_callable.rb:222:in `block in create_api_call'
/usr/local/bundle/gems/google-gax-0.8.7/lib/google/gax/api_callable.rb:325:in `block in retryable'
/usr/local/bundle/gems/google-gax-0.8.7/lib/google/gax/api_callable.rb:325:in `call'
/usr/local/bundle/gems/grpc-1.6.0-x86_64-linux/src/ruby/lib/grpc/generic/service.rb:170:in `block (3 levels) in rpc_stub_class'
/usr/local/bundle/gems/grpc-1.6.0-x86_64-linux/src/ruby/lib/grpc/generic/client_stub.rb:152:in `request_response'
/usr/local/bundle/gems/grpc-1.6.0-x86_64-linux/src/ruby/lib/grpc/generic/active_call.rb:354:in `request_response'
/usr/local/bundle/gems/grpc-1.6.0-x86_64-linux/src/ruby/lib/grpc/generic/active_call.rb:354:in `run_batch'

It is a Rails app and the only configuration done was adding stackdriver to Gemfile. Tested on Ruby 2.4 and 2.3 official Docker container images.
group :production do
  gem 'stackdriver', '~> 0.10.0'
end

Full log available here:
segfault.log

@jwnx Thanks for the report.
A couple quick questions:

How frequently do you see these? (A few times a day? Within a few seconds of just about every puma process starting?)
I see you have grpc 1.6.0 installed. What's the version of google-protobuf?

On some preliminary analysis of the posted log, it looks like grpc is segfaulting in its C code. Here's the control frame list:
-- Control frame information -----------------------------------------------
c:0017 p:---- s:0099 e:000098 CFUNC  :run_batch
c:0016 p:0093 s:0095 e:000094 METHOD /usr/local/bundle/gems/grpc-1.6.0-x86_64-linux/src/ruby/lib/grpc/generic/active_call.rb:354
c:0015 p:0048 s:0087 e:000086 METHOD /usr/local/bundle/gems/grpc-1.6.0-x86_64-linux/src/ruby/lib/grpc/generic/client_stub.rb:152
c:0014 p:0051 s:0072 e:000071 LAMBDA /usr/local/bundle/gems/grpc-1.6.0-x86_64-linux/src/ruby/lib/grpc/generic/service.rb:170 [FINISH]
c:0013 p:---- s:0068 e:000067 CFUNC  :call
c:0012 p:0085 s:0063 e:000062 BLOCK  /usr/local/bundle/gems/google-gax-0.8.7/lib/google/gax/api_callable.rb:325 [FINISH]
c:0011 p:0011 s:0055 e:000054 BLOCK  /usr/local/bundle/gems/google-gax-0.8.7/lib/google/gax/api_callable.rb:222 [FINISH]
c:0010 p:0080 s:0051 e:000050 BLOCK  /usr/local/bundle/gems/google-gax-0.8.7/lib/google/gax/api_callable.rb:248 [FINISH]
c:0009 p:0060 s:0045 e:000044 METHOD /usr/local/bundle/gems/google-cloud-logging-1.2.2/lib/google/cloud/logging/v2/logging_service_v2_client.rb:358
c:0008 p:0027 s:0034 e:000033 BLOCK  /usr/local/bundle/gems/google-cloud-logging-1.2.2/lib/google/cloud/logging/service.rb:125
c:0007 p:0006 s:0032 e:000031 METHOD /usr/local/bundle/gems/google-cloud-logging-1.2.2/lib/google/cloud/logging/service.rb:324
c:0006 p:0060 s:0028 e:000027 METHOD /usr/local/bundle/gems/google-cloud-logging-1.2.2/lib/google/cloud/logging/service.rb:124
c:0005 p:0036 s:0020 e:000019 METHOD /usr/local/bundle/gems/google-cloud-logging-1.2.2/lib/google/cloud/logging/project.rb:277
c:0004 p:0053 s:0012 e:000011 METHOD /usr/local/bundle/gems/google-cloud-logging-1.2.2/lib/google/cloud/logging/async_writer.rb:334
c:0003 p:0016 s:0007 e:000006 METHOD /usr/local/bundle/gems/stackdriver-core-1.2.0/lib/stackdriver/core/async_actor.rb:291
c:0002 p:0008 s:0004 e:000003 BLOCK  /usr/local/bundle/gems/stackdriver-core-1.2.0/lib/stackdriver/core/async_actor.rb:315 [FINISH]
c:0001 p:---- s:0002 e:000001 (none) [FINISH]

And the top of the C backtrace:
-- C level backtrace information -------------------------------------------
/usr/local/lib/libruby.so.2.3(rb_vm_bugreport+0x4ea) [0x7faf0477ee5a] vm_dump.c:692
/usr/local/lib/libruby.so.2.3(rb_bug_context+0xd4) [0x7faf04606f54] error.c:435
/usr/local/lib/libruby.so.2.3(sigsegv+0x3e) [0x7faf046e71ee] signal.c:890
/lib/x86_64-linux-gnu/libpthread.so.0 [0x7faf0437a890]
/usr/local/bundle/gems/grpc-1.6.0-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so [0x7faef311c19c]
/usr/local/bundle/gems/grpc-1.6.0-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so [0x7faef30153e7]
/usr/local/bundle/gems/grpc-1.6.0-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so [0x7faef30281f7]
/usr/local/bundle/gems/grpc-1.6.0-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so(grpc_exec_ctx_flush+0x57) [0x7faef3005a57]
/usr/local/bundle/gems/grpc-1.6.0-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so(grpc_call_start_batch+0x7f) [0x7faef30115ef]
/usr/local/bundle/gems/grpc-1.6.0-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so [0x7faef2ffefc1]
/usr/local/lib/libruby.so.2.3(vm_call_cfunc+0xf7) [0x7faf04765f07] vm_insnhelper.c:1642
/usr/local/lib/libruby.so.2.3(vm_exec_core+0x12cf) [0x7faf0476f77f] insns.def:994

@dazuma

I see it in every puma process on GKE, but couldn't replicate it locally. Which is weird, since I'm using the same Docker containers running other Rails apps and I'm getting this error only on this one app. Maybe is somewhat related to puma configuration?

Gem version follows:

google-cloud-core (1.0.0)
google-cloud-debugger (0.28.2)
google-cloud-env (1.0.1)
google-cloud-error_reporting (0.27.0)
google-cloud-logging (1.2.3)
google-cloud-trace (0.27.2)
google-gax (0.8.10)
google-protobuf (<IP_ADDRESS> x86_64-linux)
googleapis-common-protos (1.3.6)
googleapis-common-protos-types (1.0.0)
googleauth (0.5.3)
grpc (1.6.2 x86_64-linux)

Hello - we've just had a similar issue.
  * google-api-client (0.17.4)
  * google-cloud-core (1.1.0)
  * google-cloud-debugger (0.30.0)
  * google-cloud-env (1.0.1)
  * google-cloud-error_reporting (0.29.0)
  * google-cloud-logging (1.4.0)
  * google-cloud-storage (1.9.0)
  * google-cloud-trace (0.30.0)
  * google-gax (1.0.1)
  * google-protobuf (<IP_ADDRESS>)
  * googleapis-common-protos (1.3.7)
  * googleapis-common-protos-types (1.0.1)
  * googleauth (0.6.2)
  * grpc (1.8.3)

I have full stack trace and core dump, but given comment above I'm not sure if this is the right place for it.
We're running a 'vanilla' GAE ruby (basically the tutorials) on a new R&D project, so no traffic or load to speak of. It was in a sidekiq worker. Faults at the same run_batch call to grpc as OP.
19:28:38 worker.1 | -- C level backtrace information -------------------------------------------
19:28:38 worker.1 | sidekiq 5.1.0 app [0 of 2 busy] [0x56360269e095]
19:28:38 worker.1 | sidekiq 5.1.0 app [0 of 2 busy] [0x56360269e2cc]
19:28:38 worker.1 | sidekiq 5.1.0 app [0 of 2 busy] [0x56360267d3f4]
19:28:38 worker.1 | sidekiq 5.1.0 app [0 of 2 busy] [0x5636025b6f1e]
19:28:38 worker.1 | /lib/x86_64-linux-gnu/libpthread.so.0 [0x7fd842895890]
19:28:38 worker.1 | /app/vendor/bundle/ruby/2.3.0/gems/grpc-1.8.3-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so [0x7fd838b9c830]
19:28:38 worker.1 | /app/vendor/bundle/ruby/2.3.0/gems/grpc-1.8.3-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so(grpc_connected_subchannel_ref+0x9) [0x7fd838b96599]
19:28:38 worker.1 | /app/vendor/bundle/ruby/2.3.0/gems/grpc-1.8.3-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so [0x7fd838c0acf9]
19:28:38 worker.1 | /app/vendor/bundle/ruby/2.3.0/gems/grpc-1.8.3-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so [0x7fd838b927d5]
19:28:38 worker.1 | /app/vendor/bundle/ruby/2.3.0/gems/grpc-1.8.3-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so [0x7fd838b936f2]
19:28:38 worker.1 | /app/vendor/bundle/ruby/2.3.0/gems/grpc-1.8.3-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so(grpc_combiner_continue_exec_ctx+0x7f) [0x7fd838bdabaf]
19:28:38 worker.1 | /app/vendor/bundle/ruby/2.3.0/gems/grpc-1.8.3-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so(grpc_exec_ctx_flush+0x72) [0x7fd838b70f22]
19:28:38 worker.1 | /app/vendor/bundle/ruby/2.3.0/gems/grpc-1.8.3-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so [0x7fd838c8a8d9]
19:28:38 worker.1 | /app/vendor/bundle/ruby/2.3.0/gems/grpc-1.8.3-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so [0x7fd838b7d85a]
19:28:38 worker.1 | /app/vendor/bundle/ruby/2.3.0/gems/grpc-1.8.3-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so(grpc_completion_queue_next+0xb) [0x7fd838b7de9b]
19:28:38 worker.1 | /app/vendor/bundle/ruby/2.3.0/gems/grpc-1.8.3-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so [0x7fd838b66a16]
19:28:38 worker.1 | sidekiq 5.1.0 app [0 of 2 busy] [0x563602632df8]
19:28:38 worker.1 | /app/vendor/bundle/ruby/2.3.0/gems/grpc-1.8.3-x86_64-linux/src/ruby/lib/grpc/2.3/grpc_c.so [0x7fd838b65be2]
19:28:38 worker.1 | sidekiq 5.1.0 app [0 of 2 busy] [0x563602634363]
19:28:38 worker.1 | sidekiq 5.1.0 app [0 of 2 busy] [0x563602634a65]
19:28:38 worker.1 | /lib/x86_64-linux-gnu/libpthread.so.0 [0x7fd84288e064]
19:28:38 worker.1 | /lib/x86_64-linux-gnu/libc.so.6(__clone+0x6d) [0x7fd841c0462d]

@dazuma Can this issue be closed here? (And perhaps re-opened elsewhere?)

Hello there!
I have similar issue on rails 5.2 + ruby 2.5.1. Is there any workaround?

@elja Can you open a new issue with the full backlog and full segmentation fault report?

HI all, I am going to close this issue. The google-cloud-logging gem has moved from AsyncActor to the concurrent gem. If you see a segfault using the recent gem please open a new issue with all the relevant information. Thanks!


Updated the code of conduct file

@daedalus I have updated code of conduct file and also changed its version from 2.0 to 2.1.
Kindly review my pull request and merge it.

Please send all your commits of the same topic in one PR.
This PR has conflicts with others...


Fix issue 1351 endpoints not being created due to invalid selectors

Fix service endpoint in issue https://github.com/kubernetes/heapster/issues/1351

This change is

I signed it!

LGTM, thanks


Change Payload data type in Pando to Any instead of Bytes

I believe KEN Labs has completed this work on Pando.

Fixed in https://github.com/filecoin-project/dealbot/pull/417


chore: fix datastore system tests

b/264530286
Seeking to fix the datastore system tests which fail for Kokoro test runs.

I have a small question,
The application default credentials thing, do we not do this in other products? Is the credentials loader the go to way for other products also?

@yash30201 not really needed, unless we need to specifically call another Google Cloud API from within the tests.


edited for clarity

All changed packages have been documented.

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/583/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/583/


Remove ReadMsgWithContext and WriteMsgWithContext utilities

After working on #3542 it became apparent that these utility functions have issues and that bee would be better off without them. This issue will document what are the problems and propose alternative solution.
Idea behind these utility methods
These methods create background goroutine in order to read/write data from/to supplied Reader/Writer. They do read/write operation in the background goroutine because they want to abandon this operation when the supplied context is cancelled.
Problem: goroutine leaks
In case when context is terminated the method will return error to the caller but goroutine will be left to perform operation until operation is finished. This clearly is causing goroutine leak as these functions should end all goroutines before returning result to the caller.
Problem: data race issues
In the same case, when context is terminated, these methods could cause data race issues. Let’s consider following scenario:
ctx1 := context.WithDeadile(ctx, time.Second)
data1, err := ReadMsgWithContext(ctx1, reader)

ctx2 := context.WithDeadile(ctx, time.Second)
data2, err := ReadMsgWithContext(ctx2, reader)

In case when ctx1 is closed goroutine will keep reading data from form reader, which will be a problem because a few lines below new goroutine will be started to read data from the same reader. At this point we have data race conditions because two goroutines are reading from the same reader.
Looking at both problems stated above it appears that these utilities don't effectively solve the problem they intend to solve. It’s worth mentioning that in a sealed environment these methods may not cause any issues as 1) goroutine will eventually close and 2) data race issues may never happen if there are no use cases which could reproduce it. However since they pose a danger to the system it worth considering better solution.
Potential solution
In PR #3542 it was attempted to solve all issues by fixing these methods (keeping this approach), but fixes were unnecessarily complicated and the idea that bee would be better off without them made more sense.
Another solution would be to avoid using these utilities; and instead close Reader/Writer (or entire Stream) in protocol handler logic when the deadline for processing handler request is reached. This would make more sense because 1) it would be possible to stop Read/Write operation as soon as possible and 2) also other side would not waste processing requests which got terminated

@notanatol, are libp2p upgrades touching this part of code? Have these utilities become obsolete by any chance?
I am guessing, but if these utilities are still used after libp2p is upgraded then bee could have issues if context is terminated and then the same stream is reused for another handler. This would be very similar to the data race issue explained above, except that this time it could happen in different protocol handlers.

@notanatol, are libp2p upgrades touching this part of code? Have these utilities become obsolete by any chance?
I am guessing, but if these utilities are still used after libp2p is upgraded then bee could have issues if context is terminated and then the same stream is reused for another handler. This would be very similar to the data race issue explained above, except that this time it could happen in different protocol handlers.

no, these methods have not been changed in the scope of the libp2p upgrade work.


[Swift 4] Update Quicksort

applied XCode fixes in Quicksort.swift and Quicsort playgrund
renamed "Tests" project to "Tests(quicksort)" and recreated scheme - to be easier pickable in schemes list
applied swift 4 settings

Checklist

[x] I've looked at the contribution guidelines.
[x] This pull request is complete and ready for review.

Description

Applied fixes to comply with Swift4 (recommended by the Xcode), changed Tests project name and scheme to be recognisable in scheme lists

Great work! Welcome to the sac.


Rand

I've seen that you're looking for a better random function to use in your shader. I can recommend this GDC talk for inspiration: Noise-Based RNG 🙂

Hey jan,
that's a really interesting talk, thank you for sharing! :)
In fact, I just noticed that I'd need a noise instead of random numbers.
I will definitely try optimizing the shader part today or tomorrow

There we go! :)
Do you care to take a look?
Anyways, thank you for opening the ticket :+1:

Looks great now 🥇


Fix/routing without Host header

Summary
Allows Kong to accept HTTP/1.0 requests that do not contain a Host header
Full changelog

If no Host header present, match against APIs defined by method or URI
Test that a request with a matching method or URI can be matched without Host

Issues resolved
Fix #3171

Yes, the goal of this patch is to support this behavior only for HTTP/1.0. There is probably nothing else to add in the router since NGINX should disallow HTTP/1.1 requests without the Host head already (hence why the ask for the test so we avoid a future regression). We could also add a check in the router but it seems unnecessary to me...

On Feb 12, 2018, at 8:06 PM, Robert<EMAIL_ADDRESS>wrote:
@p0pr0ck5 commented on this pull request.
In kong/core/router.lua:

@@ -831,7 +831,7 @@ function _M.new(apis)
end
end

local req_host = ngx.var.http_host

local req_host = ngx.var.http_host or ""

Should we allow this bevahior only when the request protocol is HTTP/1.0? The Host header is required for 1.1 requests; i would proffer that Kong should require 1.1 clients to follow the spec and not accept invalid requests.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks! Merged to master with some modifications (including asserting that the NGINX error is caught by Kong itself). Good job!


sink/mq(ticdc): Optimize 10k Kafka topic creation performance

What problem does this PR solve?

Issue Number: close #5694
What is changed and how it works?

Use DescribeTopics() instead of ListTopics() to mitigate the metadata fetching overhead.
As describe in Apache Kafka doc, the newly created topic may be invisible to users when users try to write to that topic immediately after creation. In TiCDC, we have encounter the following error when creating large amount of topics in a short period of time:

kafka server: Request was for a topic or partition that does not exist on this broker.

So we add a function WaitUntilTopicCreationDone() to make sure that the topic can be safely written to.
Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note
None

/run-verify

/run-verify

/cc @hi-rustin
/cc @3AceShowHand
/cc @CharlesCheung96
/cc @asddongmen

/run-kafka-integration-test
/run-integration-test
/run-dm-integration-test

Great work! It would be nice if we could add a new monitor for the number of new topics and latency! But that doesn't block this pr merge.

Great work! It would be nice if we could add a new monitor for the number of new topics and latency! But that doesn't block this pr merge.

I will put the monitoring stuff in another PR. The following metrics will be included:

The amount of Kafka topics.
Topic creation latency.
Topic describe latency.

/merge
👍

/run-kafka-integration-test

/run-dm-compatibility-test
/run-dm-integration-test
/run-integration-test
/run-kafka-integration-test

Flaking test:
[2022-06-08T14:46:20.007Z] [Wed Jun  8 22:46:19 CST 2022] <<<<<< START kafka consumer in multi_topics case >>>>>>

[2022-06-08T14:46:20.007Z] [Wed Jun  8 22:46:19 CST 2022] <<<<<< START kafka consumer in multi_topics case >>>>>>

[2022-06-08T14:46:20.007Z] [Wed Jun  8 22:46:19 CST 2022] <<<<<< START kafka consumer in multi_topics case >>>>>>

[2022-06-08T14:46:20.007Z] table test.finish not exists for 1-th check, retry later

[2022-06-08T14:46:21.378Z] table test.finish not exists for 2-th check, retry later

[2022-06-08T14:46:23.904Z] table test.finish not exists for 3-th check, retry later

[2022-06-08T14:46:25.800Z] table test.finish not exists for 4-th check, retry later

[2022-06-08T14:46:27.698Z] table test.finish not exists for 5-th check, retry later

[2022-06-08T14:46:29.596Z] table test.finish not exists for 6-th check, retry later

[2022-06-08T14:46:31.494Z] table test.finish not exists for 7-th check, retry later

[2022-06-08T14:46:34.019Z] table test.finish not exists for 8-th check, retry later

[2022-06-08T14:46:35.916Z] table test.finish not exists for 9-th check, retry later

[2022-06-08T14:46:37.813Z] table test.finish not exists for 10-th check, retry later

[2022-06-08T14:46:39.711Z] table test.finish not exists for 11-th check, retry later

[2022-06-08T14:46:41.607Z] table test.finish not exists for 12-th check, retry later

[2022-06-08T14:46:44.131Z] table test.finish not exists for 13-th check, retry later

[2022-06-08T14:46:46.026Z] table test.finish not exists for 14-th check, retry later

[2022-06-08T14:46:47.922Z] table test.finish not exists for 15-th check, retry later

[2022-06-08T14:46:49.819Z] table test.finish not exists for 16-th check, retry later

https://ci2.pingcap.net/blue/organizations/jenkins/cdc_ghpr_kafka_integration_test/detail/cdc_ghpr_kafka_integration_test/11947/pipeline

/hold

/run-all-tests

/run-kafka-integration-test

/merge

/run-dm-integration-test


Member Chain comments are eaten away

function f() {
  return observableFromSubscribeFunction()
    // Debounce manually rather than using editor.onDidStopChanging so that the debounce time is
    // configurable.
    .debounceTime(debounceInterval);
}

turns into
function f() {
  return observableFromSubscribeFunction()// Debounce manually rather than using editor.onDidStopChanging so that the debounce time is
  // configurable.
  .debounceTime(debounceInterval);
}

https://jlongster.github.io/prettier/#{"content"%3A"function f() {\n  return observableFromSubscribeFunction()\n    %2F%2F Debounce manually rather than using editor.onDidStopChanging so that the debounce time is\n    %2F%2F configurable.\n    .debounceTime(debounceInterval)%3B\n}\n"%2C"options"%3A{"printWidth"%3A80%2C"tabWidth"%3A2%2C"singleQuote"%3Afalse%2C"trailingComma"%3Afalse%2C"bracketSpacing"%3Atrue%2C"doc"%3Afalse}}
and then
function f() {
  return observableFromSubscribeFunction()// configurable.
  .debounceTime(debounceInterval);
}

https://jlongster.github.io/prettier/#{"content"%3A"function f() {\n  return observableFromSubscribeFunction()%2F%2F Debounce manually rather than using editor.onDidStopChanging so that the debounce time is\n  %2F%2F configurable.\n  .debounceTime(debounceInterval)%3B\n}\n"%2C"options"%3A{"printWidth"%3A80%2C"tabWidth"%3A2%2C"singleQuote"%3Afalse%2C"trailingComma"%3Afalse%2C"bracketSpacing"%3Atrue%2C"doc"%3Afalse}}
and finally
function f() {
  return observableFromSubscribeFunction().debounceTime(debounceInterval);
}

https://jlongster.github.io/prettier/#{"content"%3A"function f() {\n  return observableFromSubscribeFunction()%2F%2F configurable.\n  .debounceTime(debounceInterval)%3B\n}\n"%2C"options"%3A{"printWidth"%3A80%2C"tabWidth"%3A2%2C"singleQuote"%3Afalse%2C"trailingComma"%3Afalse%2C"bracketSpacing"%3Atrue%2C"doc"%3Afalse}}

This is no longer dropping comments on 0.16.0 but puts comments all in one line which is not expected:
function f() {
  return observableFromSubscribeFunction().debounceTime(debounceInterval); // configurable. // Debounce manually rather than using editor.onDidStopChanging so that the debounce time is
}


remove SVG icon title

remove SVG icon title
fix docs page build fail

Is there a particular reason why those should be removed?
If it is important, how can we ensure that other projects using these will remember to the correct webpack configuration?

In some SVG icon file, it provides some meaningless title. when user hover on SVG icon, it will show those title.
Maybe, we can provider webpack base config. But I think it is better to provide SVG file with correct info.

Perhaps it is better to just remove the title and description tag from those svg files?

@u9520107 yeah, I can remove them.


Jokes

Since I couldn't always read the end of very long jokes, I added some settings to control scroll speed, and to ask to scroll until the end. All settings are user configurable.
Lint did some reformatting for me as well. Thank you Lint.

I don't know if the show full animation needs to be a config. I think it should show regardless and should be set to true...
I don't really know why this isn't the default option now that this is a render.Root option. Either way, for this app I can see NO reason why a user wouldn't want to see the whole joke...

I think it's not default just  so it won't get abused accidentally by apps that happens to pull long texts, not sure. I like to make these things configurable, but I could take that out and just make it default. I do like the scroll speed option.. whatever you think.

Yeah I think show_full_animation=True always (no need for config) and then keep the scroll speed option. Is the default speed option the current speed on the app (just to keep consistent for current installations).

OK.  And yes it is the default of course :)


Update index.html

Because

This PR

Issue

Closes #XXXXX
Additional Information

Pull Request Requirements

[ ] I have thoroughly read and understand The Odin Project Contributing Guide
[ ] The title of this PR follows the location of change: brief description of change format, e.g. 01-flex-center: Update self check
[ ] The Because section summarizes the reason for this PR
[ ] The This PR section has a bullet point list describing the changes in this PR
[ ] If this PR addresses an open issue, it is linked in the Issue section
[ ] If applicable, I have ensured that the TOP solution files match the Desired Outcome image

@viiewss We don't take in user solutions to our exercise repos. They're only meant for you to work on locally, or optionally to keep in your own fork of the repo.