Mohit's edit to add light and dark mode, and music for user experience

Coding Style
You still need to go Checkstlyes and you need to make sure you make more classes right now because you aren't following clean arch

Correctness
The code looks great and the feature is running well. I think the music feature is sometimes buggy when you mute the music. I can call you later to talk about it.

Presence of Tests and Test Coverage
You still need test cases for your part.

SOLID and Clean Arch Compliance
You need to follow clean arch as stated in the lab and our group meetings.

Javadoc
You need to do the Javadocs for most of your stuff.

Clarity of Any Accompanying Information in the Pull Request
The pull request needs to be more clear and clarify what classes you made.

Good job Mohit but looks like you still need to touch up your classes.


Implement Client Authentication

The client must authenticate when calling the authorization server's token endpoint.
The OAuth2ClientAuthenticationFilter should be implemented as a Filter. The initial implementation should support HTTP Basic only.
Implementation Requirements

the Filter should process requests for the (default) path /oauth2/token and if HTTP Basic credentials are available in the request
the OAuth2ClientAuthenticationToken should be passed to the AuthenticationManager
the AuthenticationManager should be composed of OAuth2ClientAuthenticationProvider
the OAuth2ClientAuthenticationProvider should use the RegisteredClientRepository to look up and validate the client credentials
the RegisteredClient should be returned in a new OAuth2ClientAuthenticationToken if the authentication succeeds
the Filter should save the OAuth2ClientAuthenticationToken in the SecurityContext
javadoc class and public methods
Unit tests

Specification References
3.1.  Token Endpoint
4.1.  Authorization Code Grant
4.1.3.  Access Token Request

Can I work on this one?

Thank you @pkostrzewa. The issue is yours.

@jgrandja
Does this relates to #5 ? If that is the case I have added a PR for that. Its still in progress but the code / design pattern from that PR can be used.

@paurav-munshi Please see my comment

I have basic implementation. Should I still work on it or leave this in favor of #64?

@pkostrzewa

I have basic implementation. Should I still work on it or leave this in favor of #64?

Please continue. The goal of #64 was to flush out the design for the client_credentials flow sample. This issue will address the authorization_code flow, and eventually be used for the client_credentials when we get to that feature at a later point.


[SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

What changes were proposed in this pull request?
UnionRDD of PairRDDs causing a bug. The fix is to check for instance type before proceeding
Why are the changes needed?
Changes are needed to avoid users running into issues with union rdd operation with any other type other than JavaRDD.
Does this PR introduce any user-facing change?
Yes
Before:
SparkSession available as 'spark'.

rdd1 = sc.parallelize([1,2,3,4,5])
rdd2 = sc.parallelize([6,7,8,9,10])
pairRDD1 = rdd1.zip(rdd2)
unionRDD1 = sc.union([pairRDD1, pairRDD1])
Traceback (most recent call last): File "", line 1, in  File "/home/gs/spark/latest/python/pyspark/context.py", line 870,
in union jrdds[i] = rdds[i]._jrdd
File "/home/gs/spark/latest/python/lib/py4j-0.10.9-src.zip/py4j/java_collections.py", line 238, in setitem File "/home/gs/spark/latest/python/lib/py4j-0.10.9-src.zip/py4j/java_collections.py", line 221,
in __set_item File "/home/gs/spark/latest/python/lib/py4j-0.10.9-src.zip/py4j/protocol.py", line 332, in get_return_value py4j.protocol.Py4JError: An error occurred while calling None.None. Trace: py4j.Py4JException: Cannot convert org.apache.spark.api.java.JavaPairRDD to org.apache.spark.api.java.JavaRDD at py4j.commands.ArrayCommand.convertArgument(ArrayCommand.java:166) at py4j.commands.ArrayCommand.setArray(ArrayCommand.java:144) at py4j.commands.ArrayCommand.execute(ArrayCommand.java:97) at py4j.GatewayConnection.run(GatewayConnection.java:238) at java.lang.Thread.run(Thread.java:748)

After:

rdd2 = sc.parallelize([6,7,8,9,10])
pairRDD1 = rdd1.zip(rdd2)
unionRDD1 = sc.union([pairRDD1, pairRDD1])
unionRDD1.collect()
[(1, 6), (2, 7), (3, 8), (4, 9), (5, 10), (1, 6), (2, 7), (3, 8), (4, 9), (5, 10)]

How was this patch tested?
Tested with the reproduced piece of code above manually

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Shell as also add a unit test? Also, please describe before/after this fix in "Does this PR introduce any user-facing change?". Technically I think this IS a user-facing behaviour changes from error to working case.

ok

ok to test

Test build #123023 has started for PR 28603 at commit c65be0d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27666/
Test PASSed.

Test build #123023 has finished for PR 28603 at commit c65be0d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123023/
Test PASSed.

Merged to master and branch-3.0.

@redsanket @HyukjinKwon I pulled the latest branch-3.0 today (which includes this patch), but I'm now seeing the following weird behavior:
>>> rdd1 = sc.parallelize([1,2,3,4,5])
>>> rdd2 = sc.parallelize([6,7,8,9,10])
>>> pairRDD1 = rdd1.zip(rdd2)
>>> unionRDD1 = sc.union([pairRDD1, pairRDD1])
>>> unionRDD1.collect()
[((1, 6), (2, 7)), ((3, 8), (4, 9)), ((5, 10), (1, 6)), ((2, 7), (3, 8)), ((4, 9), (5, 10))]
>>> unionRDD1.count()
0

... where Spark 2.4.5 produces:
>>> unionRDD1.collect()
[(1, 6), (2, 7), (3, 8), (4, 9), (5, 10), (1, 6), (2, 7), (3, 8), (4, 9), (5, 10)]
>>> unionRDD1.count()
10

So, the output is incorrect/unexpected and the count is zero.

@leewyang you are right the review changes suggested caused the change in behavior https://github.com/apache/spark/pull/28603/commits/1d8d3082018288ed342743877728066789130aaa. It was working as expected prior to that. @HyukjinKwon are we sure the mapping of JavaPairRDD to JavaRDD is the right approach here?

Okay, I just noticed https://github.com/apache/spark/commit/f83fedc9f20869ab4c62bb07bac50113d921207f caused this problem, and this is a regression. I am going to revert this PR. The problem of your fix is it's going to make the code less maintainable. Let me make a fix by myself.

Yes, I think I rushed to read it. Let me make another PR to use your fix. I think we should fix streaming side together fixed in f83fedc


FreeRTOS_DNS : changes to make asynchronous lookup work, version 4

Description
This PR replaces #1195.
That PR had merging problems and it was hard to get it rebased.
My GIT client ( SmartGit ) has problems switching between old and new branches, since /freertos_kernel has become a link to a different repo.
Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

Oops, I automatically filled in two crosses [x]. The patch was tested within the earlier repo, not yet in the latest ( ever-changing ) release of software. I will test the change on both PC and an ST board.
Hein
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

There are CBMC changes included in this PR. Is that intended?

There are CBMC changes included in this PR. Is that intended?

Yes, that is intended. I took them from the earlier PR #1195. I hope that they're still in sync with the current sources.
Testing progress: I just tested it on an STM32F4x, which went all well. Now I'll test it with the WinSim project.

/bot run checks

In a meanwhile, I tested the changes on both an STM32F4 and in the "WinSim" project.
I tested both with and without ipconfigDNS_USE_CALLBACKS and ipconfigUSE_LLMNR.
I found one problem in the WinSim project, which is not related to this patch: SYSTEM_Init() crashed when called from vApplicationIPNetworkEventHook(). It was solved by calling SYSTEM_Init() before starting the scheduler. See also issue #1404

Build check on Windows - Build finished. 32 tests run, 0 skipped, 3 failed.
error LNK2019: unresolved external symbol _ulDNSHandlePacket

The testing module iot_test_freertos_tcp.c calls ulDNSHandlePacket() that was not compiled because of a different configuration ( FreeRTOSIPConfig.h ).
I have made a change, from now on ulDNSHandlePacket() will always be compiled.
Hein

About the commit "Let unsigned identifiers start with a 'u'":
In the original patch, BaseType_t was replaced by size_t or TickType_t wherever appropriate. In the latest commit I changed the identifiers accordingly, e.g.:
size_t uxBufferLength;
TickType_t uxTimeout;

Tested again, now on a Xilinx Zynq.

/bot run checks

/bot run checks

/bot run checks


Improve component message when IOU is deleted

Problem
When an IOU request is deleted, we use a fallback message ('Report not found') in the LHN. But the IOUPreview component still shows 'user owes: '.  And shows 'Hmm... it's not here' when clicked.

Solution
Use a better template message. Or hide the component when an IOU is deleted.
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0104db79f6fe94370c
Upwork Job ID:<PHONE_NUMBER>934041600
Last Price Increase: 2023-08-17

No longer reproducable


Automatic error report

import numpy as np
import random
a = np.random.randint(0, 10, size=(251))
print(a)
When creating more than 251 numpy array arrays like above in the spyder, the variable cannot be checked in the variable explorer when click.
But in an array size under 250 it looks normal.

This issue resolved by upgrading spyder 3.3.3.


Why depreciated?

Why is this project being depreciated?

Because there is a newer version that benefits from recent developments introduced in golang 1.8: https://github.com/eawsy/aws-lambda-go-shim

Hi @heri16,
From the beginning our commitment is to provide the most native Go experience on AWS Lambda while not sticking users with an idiomatic vision, so that if in the future AWS teams support officially Go then you can migrate seamlessly. It makes this project and its next version, ephemeral.
At the time we created this project, the only way to offer a native experience was to compile the shim along with the user code. Even if this approach works, one of its main disadvantage is that it constraints users to use this kind of initialization code:
func init() { runtime.HandleFunc(handle) }
func main() {}

But, you won't see this kind of initialization in any other officially supported AWS Lambda runtimes.
With the advent of Go 1.8 and its new plugin feature, we can now provide a nearly perfect Go support for AWS Lambda. Indeed, now the shim is apart from the user code. The consequences:

You won't need any initialization code
We bet, that you'll be able to run the exact same function on the hypothetical future official AWS Lambda Go runtime.

Try to spot the difference with other officially supported runtimes:
// Node.js
exports.Handler = function(evt, ctx) {
  ...
}

# Python
def Handler(evt, ctx):
  ...

// Java
Output Handler(Event evt, Context ctx) {
  ...
}

// C#
Output Handler(Event evt, ILambdaContext ctx) {
   ...
}

// Go
func Handle(evt *Event, ctx *runtime.Context) (interface{}, error) {
  ...
}

This is basically why this project is being depreciated, in favor of https://github.com/eawsy/aws-lambda-go-shim.


compileVirtual should not depend on File object to template

I think TwirlCompiler.compileVirtual should not depend on File object to template because internally it's used only to generate template name. This prevent clients from compiling twirl templates on the fly. In my case I'd like admins of web-service to be able to update templates via API which are stored in DB.

@unoexperto How about a pull request? :smile:


Can not install usbmuxd

Steps to Reproduce

Steves-MacBook-Pro:foolshion steve$ brew install --HEAD usbmuxd
==> Cloning https://git.sukimashita.com/libusbmuxd.git
Updating /Users/steve/Library/Caches/Homebrew/usbmuxd--git
==> Checking out branch master
Already on 'master'
Your branch is up to date with 'origin/master'.
HEAD is now at 873252d Fix Segmentation Fault when UDID parsing failed by bailing out in case of error
==> ./autogen.sh
Last 15 lines from /Users/steve/Library/Logs/Homebrew/usbmuxd/01.autogen.sh:
2019-04-24 13:17:17 +0900
./autogen.sh
READ THIS: https://docs.brew.sh/Troubleshooting
Logs

2019-04-24 13:17:17 +0900
./autogen.sh
HOMEBREW_VERSION: 2.1.1
ORIGIN: https://github.com/Homebrew/brew
HEAD: b4f73e61649fcfc5aaa779c311e2514619ce01e7
Last commit: 9 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 963a3c49ce6050b1ee6a891bfe50489f4af59005
Core tap last commit: 7 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CACHE: /Users/steve/Library/Caches/Homebrew
CPU: octa-core 64-bit kabylake
Homebrew Ruby: 2.3.7 => /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby
Clang: 10.0 build 1001
Git: 2.20.1 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 7.54.0 => /usr/bin/curl
Java: 10.0.2, 1.8.0_201
macOS: 10.14.4-x86_64
CLT: <IP_ADDRESS>.1.1554506761
Xcode: 10.2.1
CLT headers: <IP_ADDRESS>.1.1554506761
HOMEBREW_CC: clang
HOMEBREW_CXX: clang++
MAKEFLAGS: -j8
CMAKE_PREFIX_PATH: /usr/local
CMAKE_INCLUDE_PATH: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/libxml2:/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers
CMAKE_LIBRARY_PATH: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
PKG_CONFIG_PATH: /usr/local/opt/libplist/lib/pkgconfig:/usr/local/opt/libusb/lib/pkgconfig
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig/10.14
HOMEBREW_GIT: git
HOMEBREW_SDKROOT: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk
ACLOCAL_PATH: /usr/local/share/aclocal
PATH: /usr/local/Homebrew/Library/Homebrew/shims/mac/super:/usr/local/opt/autoconf/bin:/usr/local/opt/automake/bin:/usr/local/opt/libtool/bin:/usr/local/opt/pkg-config/bin:/usr/local/opt/libplist/bin:/usr/bin:/bin:/usr/sbin:/sbin

There's not really enough information here to help you - it looks like some logs got truncated.  Did you try visiting the troubleshooting link for homebrew?

I have the same problem,Have you solved it? @SinonHub


Autoloading session in current working directory

Suppose I have a directory X, where I previously saved a session.
It'd be nice if there were an option where if you typed vim within directory X, vim would automatically load the session saved in directory X. (IE: It'd be nice to circumvent the start screen.)
Thoughts?

:h g:startify_sesssion_autoload. Like this? :)

Hmm, I thought that was the option, but when I tried setting it to 1, it didn't work.
My .bashrc is here, and I'm setting it to 1 on line 115.
I verified using :let g: that startify_session_autoload's value was set to 1. I also created a session within my ~/.vim/colors folder, and it doesn't seem to be working.
Thoughts?

Oh, I forgot that it was working a bit differently. A Session.vim should be shown as entry [0] in the startify buffer:

So loading the session just takes another hit of Enter which, in my opinion, is a good compromise, since there might be use cases where you simply forgot that a Session.vim was present and didn't want $ vim to load it right away.
g:startify_session_autoload only takes effect when opening a bookmarked directory. I'll change that!

Thank you! I'll look forward to the commit.

Hopefully it works as expected now!

Yup, it works. Admittedly though, it took a tad to figure out, since I had to change the g:startify_session_autoload = ".", and save my session as Session.vim (instead of some other name).
I believe this is intentional though. Excellent work.

I changed the docs, so it's all explained in :h g:startify_session_autoload. Better just set it to 1 instead of `".", though. :-)
Thanks for pointing out this issue.

You're right; I meant to say that I made g:startify_session_dir = '.', my mistake.


Add rackIdSupplier and funnel into KafkaPartitionSplitReader

First pass at client.rack supplier for the KafkaPartitionSplitReader

A test case for the consumer props would be tricky as we don't have visibility into the consumer props once the reader is instantiated. We would have to expose the consumer props from the reader.


React & Redux group project: set up your Kanban board

https://github.com/kifle23/space-travelers-react-group-capstone/projects/1
We are a group of two

STATUS: REQUIRED CHANGES ♻

Hi @Team,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

[ ]... ✅ Tasks assigned
[ ]... ✅ Setup Kanban

Required Changes ♻
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me(@joskalenda) in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi team ,
Great job so far you can start working on your project!
May I highlight the following:

[x] Your Kanbam board is etup correctly👏  ✔
[x] You implemented all the requirements✔

STATUS: APPROVED :muscle::clap:
Congratulations! :tada:
Your project is complete!  It's time to merge it :shipit:

Optional suggestions

Please check the comment under the review.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding! :clap: :clap: :clap:
Feel free to leave any questions or comments in the PR thread and tag me @algerina if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

If anything seems to be unclear to you, reach out and ask anything by commenting on this Pull Request and mention me as Algerina, I will receive a notification and will respond.
GitHub | LinkedIn | Twitter
Reviewed by Amel Khiri


Can not install on ubuntu 17.10

When I install on ubuntu 17.10,the process stop at:
extract:fsevents: still pacote fsevents@https://registtry.

Could be a problem with the npm registry or with your npm or network configuration. It happens some times. It might work again in a few hours.
Did you already try one of the packaged releases? Does that work? You'll probably need vmd-1.31.1-linux-x64.tar.gz

Closing due to inactivity


Additional backup service

Overhead of offline backup is too high, but an additional copy would be ideal. Maybe wasabi in aus (1TB minimum though...) or cloudflare R2? could also use proton if restore times are reasonable

https://wasabi.com/locations/
https://wasabi.com/paygo-pricing-faq/


Document confirmed uplinks behaviour in The Things Stack

Summary
The Things Stack users are confused with the confirmed uplinks behaviour in The Things Stack. It should be very helpful for TTS users to have documentation on confirmed uplink behaviour similar to the confirmed downlink behaviour documentation in TTS.
Why do we need this ?
To clarify users on the confirmed and unconfirmed uplinks behaviour in TTS.
What is already there? What do you see now?
...
What is missing? What do you want to see?
Documentation on confirmed and unconfirmed uplinks behavior in TTS.
How do you propose to document this?
...
Can you do this yourself and submit a Pull Request?
No, @nejraselimovic

@adriansmares is there any place you can refer me to to where I can learn about how this works?

Hi @nejraselimovic,
I don't think that the flow is explicitly written down anywhere, even in the LoRaWAN specification. The flow for confirmed uplinks is as follows:

The end device sends an uplink which is confirmed. This is a distinct frame type (confirmed uplink).
If the Network Server receives the uplink:
2.1. The Network Server generates a downlink with the ACK flag set in the frame header. This downlink is a class A downlink - acknowledgements never come via class B or C.
2.2. If the end device actually receives the downlink, there is nothing more to do.
2.3. If the end device did not receive the downlink: Devices with a version lower than LoRaWAN 1.0.4 may retry this uplink multiple times, without any upper bound on the number of retries. Devices with versions greater or equal 1.0.4 will retry this uplink at most NbTrans times. The important part here is that the same frame counter will be used - the application will see this uplink at most once, but the Network Server may see it multiple times if the downlink did not reach the end device.
If the Network Server does not receive the uplink, the end device basically is in the same state as 2.3, and will retry.

Points which confuse users:

Since the Network Server is forced to generate a downlink in order to acknowledge the uplink, they will see a downlink after every confirmed uplink. There is no way around this.
Since in virtually every LoRaWAN deployment the gateways are an order of magnitude less than the actual end devices, if too many devices send confirmed uplinks very often, they may consume the duty cycle of the gateway due to the required acknowledgements. This in turn may cause them to try to transmit the same uplink again, which won't be acknowledged and so forth - using confirmed uplinks for large fleets of devices is not recommended.
The Network Server cannot force the end device to stop using confirmed uplinks. There is no MAC command that says 'stop using confirmed uplink messages'. However, some end devices have application layer commands which allow confirmed messages to be disabled.

You can look at an end device which sends confirmed uplinks contiguously here.


Switches from Oracle JDK to Open JDK

Pushing this through as an incremental fix to the overall CI issue that solves https://github.com/pivotal-legacy/LicenseFinder/pull/572#issuecomment-486753049 & https://norsk.cf-app.com/teams/main/pipelines/LicenseFinder/jobs/build-docker-image/builds/2


Visibility of changes

I as a offical want to see the difference between two versions, to be able to see if improvements resolved the current problem
AC:
It is possible to make the different tracks available to display

This is working so far with #53


Adding my_repo_hexagon_map to documentation index for distro

i'd like my_repo_hexagon_map to be indexed and documented on ros.org.

Replaces #18239
@DS921020 In general please modify your existing pull request instead of opening a new one. If you do open a new one make sure to reference the old one for consistency as well as close the redundant one so we don't spend time reviewing it.

Also I note looking at your repository you have not added any license information. This is important to add to things being publicly listed. We recommend the BSD or Apache2 by default for ROS projects. https://choosealicense.com/


Feature/areg-140: Sorting and Filtering in My Submissions table does not work + Other searchbar fixes

Closes
AREG-140
AREG-70
Implemented solution
AREG-70

Filter by "Citation" is not supported, and hence removed.

AREG-140

this changes the existing API - /api/antibodies/search - POST
Problem: In the tab - "My Submission" fts_and_filter_antibodies didn't work for isUserScoped. This returned only curated antibodies also for the "My submission" which was wrong.
Changed the logic to return all Antibodies when isUserScoped is information is passed. Else return only curated antibodies.

This PR also resolved the bugs as mentioned in the video - i.e. wrong API calls through search bar when in "My Submission" tab.

Adding API call logic instead of clearTab() in the search bar.

Video demo for new bugs and solutions demo:
https://github.com/MetaCell/scicrunch-antibody-registry/assets/59233227/cc8e7313-23b3-4a24-ba62-fe6a09c4ff94
...
How to test this PR

THE VIDEO is shown in the PR.

...
Sanity checks:

[x] The pull request is explicitly linked to the relevant issue(s)
[x] The issue is well described: clearly states the problem and the general proposed solution(s)
[x] In this PR it is explicitly stated how to test the current change
[x] The labels in the issue set the scope and the type of issue (bug, feature, etc.)
[x] The relevant components are indicated in the issue (if any)
[x] All the automated test checks are passing
[x] All the linked issues are included in one Sprint
[x] All the linked issues are in the Review state
[x] All the linked issues are assigned

Breaking changes (select one):

[ ] The present changes do not change the preexisting api in any way
[ ] This PR and the issue are tagged as a breaking-change and the migration procedure is well described above

Possible deployment updates issues (select one):

[x] There is no reason why deployments based on CloudHarness may break after the current update
[ ] This PR and the issue are tagged as alert:deployment

Test coverage (select one):

[ ] Tests for the relevant cases are included in this pr
[x] The changes included in this pr are out of the current test coverage scope
Checked that all the tests are still passing

Documentation (select one):

[ ] The documentation has been updated to match the current changes
[x] The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

[ ] Screenshots of the changes
[x] Explanatory video/animated gif

when search in my submission throw to All Antibodies. And when changing tab from all antibodies to my submission - don''t pass the search text in the body of the API call.
video demo
https://github.com/MetaCell/scicrunch-antibody-registry/assets/59233227/af8fa55d-86b5-4fd7-bf0b-4600f43f3eae
cc @filippomc


False positive on import * as S from './file'

Not sure if this is going to be in scope for Knip as it seems like an edge case, but the following pattern is causing a false positive.
// File with many exports
import styled from '@emotion/styled';

export const h1 = styled.h1`...`;

export const h2 = styled.h2`...`;

// ...

// File that imports all exports
import React from 'react';
import * as S from './styles';

const Heading = ({ as, ...props }) => {
    const Element = as ? S[as] || S.h1 : S.h1;
    return <Element {...props} />;
};
export default Heading;

I guess the false positive is h2?
Yeah I don't think there's a way for Knip to infer that. If the types are known Knip should be able to infer, but as in the example isn't typed at all? But even if it were I expect it won't help Knip enough.
Example of a pattern that Knip is able to work with: https://github.com/webpro/knip/blob/main/packages/knip/fixtures/re-exports-ns-type/index.ts

I would expect ‘as’ to be ‘keyof typeof S’ or maybe ‘string’ - in either case if we’re using a star import and accessing that via a computed key, would knip be able to mark everything under ‘* as S’ as a used key export?
For me, the false positive is h1, h2, and any other export in the file

I would expect as to be typeof S or maybe string

From your example there's no way to infer that.

in either case if we’re using a star import and accessing that via a computed key, would knip be able to mark everything under * as S as a used key export?

No. Also see https://knip.dev/blog/knip-v5

For me, the false positive is h1, h2, and any other export in the file

From your example, I would expect S.h1 to be referenced/used. So that might be a bug. Regardless, that won't help you much here I'm afraid.

in either case if we’re using a star import and accessing that via a computed key, would knip be able to mark everything under * as S as a used key export?

No. Also see https://knip.dev/blog/knip-v5

Hmm I think some people might want to "turn on" counting star imports as "everything is used". Consider something like this:
/// file assets.tsx
export { default as cat } from 'myproject/assets/pictures/at.png';
...
export { default as dog } from 'myproject/assets/pictures/dog.png';

/// file Picture.tsx
import * as pictures from '../assets.tsx';

export type PictureToken = keyof typeof pictures;

interface Props {
   pictureToken: PictureToken;
}

export const Picture = (props : Props) => {
  /// some code which abstracts getting actual asset from the dictionary, resizing, etc. etc.
}

counting star imports as "everything is used"

Not sure how the intermediate keyof typeof pictures makes Knip behave, but in general Knip tries to infer that. Also see fixtures for examples, e.g. https://github.com/webpro/knip/blob/main/packages/knip/fixtures/imports-namespace/index.ts where members of NS3, NS4, NS5, NS6 are marked as used (because no members are accessed individually).

And note that it might actually be impossible to detect in compile-time if e.g. a dog asset is unused, if one is getting their tokens from server (so it could be any value). So should we even try?

Knip does static analysis only, it does indeed not run code and check values dynamically.

And note that it might actually be impossible to detect in compile-time if e.g. a dog asset is unused, if one is getting their tokens from server (so it could be any value). So should we even try?

Knip does static analysis only, it does indeed not run code and check values dynamically.

I guess we misunderstood each other. What I wanted to say is that in an example above (one with Picture component) to me, all exports from assets.tsx should be considered used (given there is a code like below somewhere in the codebase)
...
const pictureToken = getPictureTokenFromServer(); // dynamic value
return (<Picture pictureToken={pictureToken} />);
...

Gotcha. That's "too dynamic" indeed. Knip v3 might deal with this better, but it got too slow.
TypeScript's language service findReferences function might deal with this fine, but I moved away from it, for the same reasons.

:rocket: This issue has been resolved in v5.3.0. See Release 5.3.0 for release notes.

For the examples in this thread: with proper types, Knip should find references. Played a bit with some scenarios and added to the fixtures: https://github.com/webpro/knip/blob/main/packages/knip/fixtures/re-exports-ns-type/index.tsx
Specific to the as property: if it's typed properly the exports are all referenced.
This functionality hasn't changed in the latest release, I've just added the fixture to confirm it's working as I would expect.


Drafting xpbd f64 support

Hello!
What
This is a little draft of support for xpbd f64 precision.
I would need some help to make sure its coherent as I am not very well versed in this kind of crates.
Resolves #46
How
To enable the feature one need to use

bevy-tnua = {version = "0.15.0", default-features = false,  features = ["f64"]}
bevy-tnua-xpbd2d = {version = "0.2.0", default-features = false,  features = ["f64"]}

Known issues
Testing with

cargo test --no-default-features --features f64

doesn't work as I can't figure out why the dev-dependencies is not taking in account the default-features = false and importing parry in both f32 and f64.
However the crate works as intended when imported in another project.
Notes
The math module is basically the same as the one in xpbd, but i thought that since xpbd isn't a dependency when using rapier, might not be great to rely on it directly? I am not sure.

Hello,
For the Ci Docs not passing, it seems --all-features doesn't work. As the feature  model is similar as the one used in bevy-xpbd the only way to be able to use it would be either using default feature or disabling default and using the f64 one: https://github.com/Jondolf/bevy_xpbd/blob/main/.github/workflows/ci.yml.
I am not sure whether its a good practice or not, I am very eager to have your feedback thank you!

We don't really need the --all-features because Tnua does not use features, so it should be fine.


Storybook implementation & configuration

Documentation

[X] Complete installation & configuration - Commit

[X] Complete installation & configuration - Commit


Allow blackhole to delay response

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Related issues
A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.
Additional Notes
Anything else we should know when reviewing?

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1012  👈
#1011
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blt and the rest of your teammates on  Graphite

Merge activity

Oct 2, 8:04 PM EDT: @blt merged this pull request with Graphite.


feat: Make the fields optionnal

I made mostly all fields optional, at least those checked by the added test case.

It also adds Default derive on some structs.


Hyundai S harness

Hyundai M harness with CAN bus pairs flipped.

which car? Genesis GV80 2021 (Middle East only)

https://github.com/commaai/openpilot/pull/30145

schematics - seems to be similar to EV6's harness schematic

https://github.com/commaai/neo/blob/master/car_harness/EV6_Harness.sch.pdf

2022 Genesis GV70 3.5T with HDA2 also requires this harness. This route is this car with Harness M installed:

d81673ef19d79a4e/00000004--b07f0522a0


Implement Location list/card in play page

Implement Location list/card in play page

doing

The current implementation is not responsive: on mobile the text overflows

Thank you for your information.👨💻

Fixed!

Works on my device. I think the issue can be closed.


problem converting strings with special characters

In the conversion process a number of files throw errors, such as: Could not apply python string formatting to 'http://data.socialhistory.org/resource/hisco/occupationalTitle/bokhandelsdr{ng'
The special character also appears in the original .csv file, so it doesn't appear to be related to #15 . Other files have similar issues, specifically with the /, which is used to separate multiple occupations.

Could you specify exactly which file throws the error?

sdh-public-datasets/se_CEDAR_HISCO.csv

@rlzijdemanit was actually a warning that was intentional. Sometimes URI's contain unmatched curly braces. This means that python string formatting (i.e. placing values for columns in the URI) does not work. Jinja2-style references to values do work in this case.
In other words: it was not a bug, but just a cryptic warning message. Fixed in 16a24bc.
Could you give an example of a file that contains the / issue?

It broke on a very large file. Created a sample of that file with all nasty characters, including quotes and slashes, but it worked perfectly. Closing issue: issue not replicable.


[Migration] Provide a way for users to select users, group and container for the hdi file

We should add a new section in the migration perspective in order to enable users to provide us with users (array of user names), group, and container for the hdi file. The hdi file currently sets the users array to a provided HANA_USERNAME configuration property or to DBADMIN if there is no config provided. The group and container are set to be the project name:
const hdi = {
     configuration: `/${projectName}/${hdiConfigPath}`,
     users: [defaultHanaUser],
     group: projectName,
     container: projectName,
     deploy: deployables,
     undeploy: []
};

An important limitation for the group and container properties is that they have the following requirement for their content: "A"-"Z", "0"-"9", and "_", and the first character cannot be "_" This should be validated on the frontend side.
Related to: https://github.com/SAP/xsk/issues/706

dependency for

#1059

This issue is closed as the project is no longer maintained


Azure listing tags fix

For now, it reads only 100 tags

Ok, I'm not going to reimplement this now as docker authorization refactoring is a completely different thing. To be able to query v2 registry of docker container registry, we need token per repository. That breaks the current flow and it is too big change to implement it now


Connect post creation page to API

Noticeable Changes

Replaces existing post-creation placeholder form with a proper one based on the API specs
Connects said form and actions to API, allowing post creation
Creates new Selector component

Note that it's currently not possible to create a post without a URL because of https://github.com/sublinks/sublinks-api/issues/385. Plus, image uploads are being giving an incorrect URL so they won't show up properly until https://github.com/sublinks/sublinks-api/issues/357 is resolved.

I think there should be an option to have it controlled with url query params. like
?community=someid&title=MyNeWTitle.....
But this can be done after this.

https://github.com/sublinks/sublinks-api/pull/386
This PR should fix the first issue you mentioned.

I think there should be an option to have it controlled with url query params. like ?community=someid&title=MyNeWTitle..... But this can be done after this.

@Pdzly Not a bad idea. Have you seen this implemented in any Lemmy instances/themes?
I've created an idea issue for this. And semi-related I also created a follow-up to prefill the community selector when navigating from a community page: https://github.com/sublinks/sublinks-frontend/issues/150


find a way to track if onClick spawns new services each time or it reuses the first one

Starting a service doc

The [startService()](https://developer.android.com/reference/android/content/Context#startService(android.content.Intent)) method returns immediately, and the Android system calls the service's [onStartCommand()](https://developer.android.com/reference/android/app/Service#onStartCommand(android.content.Intent,%20int,%20int)) method. If the service isn't already running, the system first calls [onCreate()](https://developer.android.com/reference/android/app/Service#onCreate()), and then it calls [onStartCommand()](https://developer.android.com/reference/android/app/Service#onStartCommand(android.content.Intent,%20int,%20int)).


i936 driver issue on bionic in a old 2013 pixel

crouton: version 1-20200428114634~master:67dc8d77
release: bionic
architecture: amd64
xmethod: xorg
targets: x11,extension,keyboard,xorg,kodi,xiwi,gnome,xfce,unity,touch
host: version 10895.56.0 (Official Build) beta-channel link
kernel: Linux localhost 3.8.11 #1 SMP Wed Sep 12 23:58:05 PDT 2018 x86_64 x86_64 x86_64 GNU/Linux
freon: yes

Please describe your issue:
the i936 driver doesnt work even tho the drivers are installed and the card can be detected, mpv only lets me use the x11 legacy driver and all programs that can use acceleration  just print me
libGL error: failed to create dri screen
libGL error: failed to load driver: i965
my Xorg.crouton.log http://s000.tinyupload.com/index.php?file_id=00663924309126429776
a relevant bit

[   544.540] (II) intel(0): [DRI2] Setup complete
[   544.540] (II) intel(0): [DRI2]   DRI driver: i965
[   544.540] (II) intel(0): [DRI2]   VDPAU driver: va_gl
[   544.540] (II) intel(0): direct rendering: DRI2 enabled
[   544.540] (II) intel(0): hardware support for Present enabled
[   544.540] (--) RandR disabled
[   544.546] (II) SELinux: Disabled on system
[   544.566] (EE) AIGLX error: Calling driver entry point failed
[   544.567] (EE) AIGLX: reverting to software rendering
[   544.610] (II) IGLX: enabled GLX_MESA_copy_sub_buffer

any help would be apreciated

I had the same issue, and could not get hardware acceleration to work in bionic. In xenial it still works fine, though.

hello!
you downgraded?

Yeah, I abandoned my bionic chroot and went back to using xenial.

damn i should have tested before updating my main chroot to bionic

if someone has a hack to make it work i would apreciate it a lot (downgrading?) that im kinda unable to make a new chroot and pass everything, nevertheless this should be added to the wiki that bionic doesnt work

oh and kodi doesnt acelerate

i recommend to put a disclaimer about how not to update to bionic with a pixel 2013 in the faq or some place

@k2arim99,
Since bionic is not a release supported in crouton and will never be, I don't think a warning is warranted.
Hope this helps,
-DennisLfromGA

@k2arim99,
Since bionic is not a release supported in crouton and will never be, I don't think a warning is warranted.
Hope this helps,
-DennisLfromGA

Oh im sorry didn't read that it would never be supported, I will close
Cheers

Good news @k2arim99 : on my chromebook pixel 2013 , hardware acceleration seems to work on Focal. (however, the i915 kernel driver seems to be quite buggy, so GPU-intensive workloads seem to qucikly cause GPU hangs.) (Also, watch out for #4338 if you try Focal right now.)

Thanks! I will have it into consideration when I once again migrate to a higher ubuntu version


Improve screenshot options

This PR aims to supersede #1623. It

merges some commits
uses Enum.name() instead of toString() in serialization/marshalling
replaces the (screenshot) image format enum with String
provides all image formats that are supported by ImageIO
simplifies the mapping of ScreenshotSize to the actual dimensions
aligns the two screenshot dropdown menus in the video settings menu

Thank you @unpause for the initial work on that. I did some testing and could not provoke any errors. Can you verify this please, @unpause ?

Well, it doesn't crash - but ... if I load up, it works, change settings in-game, it works, I exit out, restart the game, reload the world, and I have next to no keybindings (visibly lacking in config.cfg) - can't move, can't get the main menu, etc. Kill the game, start it again, reload, works fine. Can go again and break it again if I edit settings in-game.
Labels in Screenshot size are also still using the old names :-)
Also, should jpg be the default rather than higher quality png?

Good catch! Changing the enum serialization to use name() instead of toString() basically works, but needs more adjustments for the Input interfaces. I therefore reverted those changes.
I'm not entirely sure why it didn't work before, since the serialization through the display name works fine for other classes such as ViewDistance. Maybe it was not unique? In any case, it should work now.

Tested out well - merged! Thanks @msteiger and @unpause :-)


Getting stuck with cycle reference in the import statement

What version of CUE are you using (cue version)?

$ cue version
cue version 0.4.3 linux/amd64

Does this issue reproduce with the latest release?
Yes
What did you do?
When a cue file in a module has a import statement referring to its own package, the cue command get stuck and don't return a error. E. g.:
Content of the \<root dir\>/cue.mod/module.cue file:
module: "<url>/<path>"

Content of the \<root dir\>/test.cue file:
package <package>

import (
	"<url>/<path>/<package>"
)

What did you expect to see?
Return a error message informing a cycle reference in the import statement.
What did you see instead?
Cue command get stuck

Thanks for filing this bug! It appears to be a duplicate of https://github.com/cue-lang/cue/issues/849; closing for now.


Support for jekyll 4

Tests pass and it's working on my personal jekyll site.

Sweet, will check this out later. Thanks for taking a look at this.

This is released as version 2.2.0. Thanks again!


fix(remix-architect,remix-netlify): update binary data responses

x-ref #1780
Signed-off-by: Logan McAnsh<EMAIL_ADDRESS>

Looking forward to these adapters being in the hands of the platforms themselves 😅

Looking forward to these adapters being in the hands of the platforms themselves 😅

ditto!

experimental release passed for these https://github.com/remix-run/remix/runs/5189257970?check_suite_focus=true


Review Lightning architecture & API

Document: https://docs.google.com/document/d/1xHU7-iQSpp9KJTjI3As2EM0mfNHHr37WZYpDpwLkivA/edit#

@carmocca what is TODO?

Plan was to write a document with all these things, but many have been covered by @ananthsub 's API review.
Have been using this issue to link all the PR's I've opened testing the hook consistency

@carmocca do you mind if I hijack this issue for https://docs.google.com/document/d/1xHU7-iQSpp9KJTjI3As2EM0mfNHHr37WZYpDpwLkivA/edit#
The intention is to go through every component in Lightning and do an API review

Go for it!

@ananthsub Do you still want to keep this open?


Provide examples of usage in JSON-LD

unfortunately a large fraction of the bioinformatics community will be put off by RDF.
Luckily it's very easy to use JSON-LD as a trojan horse here. The bioinformatics community needs a JSON successor to GFF3 and it would be easy to place FALDO in this place

That makes sense, do you suggest doing this in the README.md? and also should we have a default context at biohackathon.org?

The fig9. in the paper is in JSON-LD

On 22 Aug 2017, at 23:25, JervenBolleman wrote:

That makes sense, do you suggest doing this in the README.md?

Ideally one example in the README and then some additional examples /
unit tests elsewhere... maybe even a readthedocs for FALDO. But assuming
not infinite time to work on this, yes just the README.md for now

and also should we have a default context at biohackathon.org?

Great idea.
How do things currently get published there? I don't see a gh-pages or
docs folder.

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/JervenBolleman/FALDO/issues/33#issuecomment-324233505

The fig9. in the paper is in JSON-LD

Ah yes great, we can just dupe that for now

Regarding a degault context at biohackathon.org, it currently checks out the codebase every hour if I recall @ktym is the maintainer. I think it something we should be able to do something in Japan. I will at least prepare some code to generate an context.
I was looking into having tabs with examples in the README. Otherwise we can do more regarding documentation.

Great start! As you say, we can use additional features of json-ld to make it more appealing to developers: we can have the @id field in the main body simply be id (it's possible to push all the @ stuff into the context header or linked document).
I note also this example creates blank nodes for the Positions. I think this is OK, and we can imagine skolemizing or UUIDing as part of a separate translation step if this is perceived to be an issue.

May want to coordinate the json-ld example with bioschemas, see:
https://github.com/BioSchemas/specifications/issues/210
@JervenBolleman your example above is probably too underspecified, we would need at least a reference

@cmungall yes, the example is completely underspecified as I was thinking of some of the existing public JSON for genomic/protein information.  Which are like
{
    "features": [ {"type": "SIGNAL",
        "category": "MOLECULE_PROCESSING",
        "begin": "1",
        "end": "17"}
    ]
}

Which are common but put 3 things into one object making it hard to separate them out with just the JSON-LD processing (Maybe framing can help but I am not an expert there).

I don't think JSON-LD processing is sufficient to transform the above into a FALDO-compliant RDF graph (in which each position is its own node).
One possibility is to make FALDO more lenient and allow flatter representations, and define some kind of rule-based transform to entail the deeper representation.


Homebrew formula doesn't upgrades helm diff plugin

Operating system
macOS 12.4
Helmfile Version
v0.145.2
Helm Version
v3.9.2
Bug description
helmfile now uses helm diff --color introduced in https://github.com/databus23/helm-diff/pull/343/files (helm diff v3.4.0). If one upgrades helmfile using Homebrew but doesn't manually upgrade the helm diff plugin helmfile will fail

@giuscri Hey! Thanks for reporting. Unfortunately, we assume it's user's responsibility to match helm-diff version to what's expected by helmfile and needed by your use-case.
Shall we just note about that in the documentation, or do you have any other suggestion?

@mumoshu I think we can add a subcommand to init and check plugins.

@yxxhero Sounds like a good idea 👍

Please let me track this issue

@yxxhero @mumoshu The following is my idea, can you help to review it?
Execute helmfile init:

Check whether helm is installed, if not, let the user choose whether to install it, run curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash to install.
Check the helm version, if the version is low, let the user choose whether to upgrade
Check the helm plugin (helm diff, helm secrets), if it is not installed or the version is low, let the user choose whether to install or upgrade.

Possible problems:

Support may be problematic on windows system

Future features:

Create a helmfile project directory
Generate a helmfile.yml template

I think the initial idea is good. It has improved the user experience. Let's have a look at it together. @mumoshu @xiaomudk

@xiaomudk Thanks for the proposal!
Actually, Helmfile has been putting its best effort to provide Windows support and the fact that Helmfile doesn't rely on external commands other than kustomize, helm, and helm plugins are effects of that.
That said, it would be great if we could implement helmfile init without making it dependent on curl and bash. We might be able to use Go's standard HTTP library instead of curl and instead curling the installation script, we'd embed a well-known helm download URL within the helmfile binary and use it as a download source.
Does that sound good to you?

@mumoshu
I'm not worried about the file download, I'm more worried about the installation process under Windows, such as the installation path, the addition of environment variables, and so on.
My opinion is that the windows platform is detected, the download address of helm is displayed, and the user can install it by himself.
what about your suggestion?

@xiaomudk just do it.


[BUG]: Copy buttons have no effect

How are you running AnythingLLM?
Docker (remote machine)
What happened?
In a normal chat setting there are two copy buttons one for the chat message itself and extra buttons for the code areas.
In both cases clicking the copy button leads to no effect.
Clicking the copy button for the chat message next to edit and refresh has no effect whatsoever also no console output.
Clicking the copy button for the code area leads to an error in the browsers console:
Firefox v127.0.2
"Uncaught TypeError: window.navigator.clipboard is undefined"
Chrome v126.0.6478.127
"Uncaught TypeError: Cannot read properties of undefined (reading 'writeText')
Are there known steps to reproduce?
No response

HTTP & browser permissions for non-SSL/TLS connections
See: https://github.com/Mintplex-Labs/anything-llm/issues/1631#issuecomment-2155170550


Update cats-effect, cats-effect-laws to 2.5.1

Updates

org.typelevel:cats-effect
org.typelevel:cats-effect-laws

from 2.2.0 to 2.5.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Applied Migrations

github:typelevel/cats-effect/v2_4_0?sha=v2.4.0

Documentation:

https://github.com/typelevel/cats-effect/blob/v2.4.0/scalafix/README.md

Files still referring to the old version number
The following files still refer to the old version number (2.2.0).
You might want to review and update them manually.
build.sbt
src/main/g8/build.sbt

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel" } ]

labels: test-library-update, semver-minor, scalafix-migrations, old-version-remains

Superseded by #221.


When using text format under sqltie, created_at cannot automatically create time

Go version
go1.22.1
GoFrame version
2.7.2
Can this bug be reproduced with the latest release?
Option Yes
What did you do?
When using text format under sqltie, created_at cannot automatically create time
What did you see happen?
created_at cannot automatically create time
What did you expect to see?
Ability to automatically create time

It currently does not support text type for created_at field in package gdb.


"Failed to upload texture" triggered by mpv --open-gl=yes

Running on Fedora 32 with:
wayfire-0.4.0-1.fc32.x86_64
sway-1.4-6.fc32.x86_64
wlroots-0.10.1-2.fc32.x86_64
mpv-0.32.0-3.fc32.x86_64
Graphics chipset is Intel gen3:
00:02.0 VGA compatible controller: Intel Corporation 82G33/G31 Express Integrated Graphics Controller (rev 10) (prog-if 00 [VGA controller])
Subsystem: Foxconn International, Inc. Device 0ded
Flags: bus master, fast devsel, latency 0, IRQ 16
Memory at fdf00000 (32-bit, non-prefetchable) [size=512K]
I/O ports at ff00 [size=8]
Memory at d0000000 (32-bit, prefetchable) [size=256M]
Memory at fda00000 (32-bit, non-prefetchable) [size=1M]
Expansion ROM at 000c0000 [virtual] [disabled] [size=128K]
Capabilities:
Kernel driver in use: i915
Kernel modules: i915
When running mpv under either sway or wayfire (both based on wlroots) in my system, and I force opengl-es with --opengl-es=yes, the mpv window fails to show up, and I get the following two messages spammed in my logs:
EE 09-06-20 13:16:55.769 - [types/wlr_buffer.c:98] Failed to upload texture
EE 09-06-20 13:16:55.769 - [types/wlr_surface.c:301] Failed to upload buffer
EE 09-06-20 13:16:55.785 - [types/wlr_buffer.c:98] Failed to upload texture
EE 09-06-20 13:16:55.785 - [types/wlr_surface.c:301] Failed to upload buffer
EE 09-06-20 13:16:55.806 - [types/wlr_buffer.c:98] Failed to upload texture
EE 09-06-20 13:16:55.806 - [types/wlr_surface.c:301] Failed to upload buffer
If I do not force opengl-es in mpv, it uses the wlshm video output, which is slower than the gpu output.
The gpu output works with --opengl-es=yes under both Gnome Shell/mutter and weston.

Log output from wayfire showing the log spam:
wayfire-output.txt

If the error was only in Wayfire, I can imagine this being because we mistakenly used to advertise linux-dmabuf unconditionally (https://github.com/WayfireWM/wayfire/blob/0.4.0/src/core/core.cpp#L183) which is no longer the case in wayfire master branch.
However I wonder why it doesn't work in Sway too. At least we can see that sharing dmabufs might not work on your system. Could you try to generate logs in Sway? Do you see the same errors there?

Here are the logs from "sway -V -d":
sway-output.txt
As far as I can see, the wlroots messages are the same.


block with inout parameter that returns a sending value crashes

Description
I think this has something to do with the inout + sending combination in the with function. Removing either allows the code to be processed succesfully.
Reproduction
public class Context {
	let value: Int

	init(value: Int) {
		self.value = value
	}
}

public struct Transaction {
	public static func with<T>(block: (inout Transaction) throws -> sending T) throws -> sending T {
		var txn = Transaction()

		return try block(&txn)
	}
}

actor MyActor {
	private var context = Context(value: 0)

	public func withContext<T>(_ block: sending (Context) throws -> T) async throws -> sending T {
		let value: T = try Transaction.with { txn in
			return try block(context)
		}

		// ERROR: returning 'self'-isolated 'value' as a 'sending' result risks causing data races
		return value
	}
}

Stack dump
1.	Apple Swift version 6.0-dev (LLVM 311c8b35213308e, Swift 488a207cc9d2994)
2.	Compiling with the current language version
3.	While evaluating request ExecuteSILPipelineRequest(Run pipelines { Mandatory Diagnostic Passes + Enabling Optimization Passes } on SIL for test)
4.	While running pass #225 SILFunctionTransform "TransferNonSendable" on SILFunction "@$s4test7MyActorC11withContextyxxAA0E0CKXEYaKlFxAA11TransactionVzKYTXEfU_".
 for expression at [test.swift:21:39 - line:23:3] RangeText="{ txn in
			return try block(context)
		"
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  swift-frontend           0x0000000105d4eab4 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 56
1  swift-frontend           0x0000000105d4d280 llvm::sys::RunSignalHandlers() + 112
2  swift-frontend           0x0000000105d4f0fc SignalHandler(int) + 304
3  libsystem_platform.dylib 0x00000001965eb584 _sigtramp + 56
4  libsystem_pthread.dylib  0x00000001965bac20 pthread_kill + 288
5  libsystem_c.dylib        0x00000001964c7a30 abort + 180
6  libsystem_c.dylib        0x00000001964c6d20 err + 0
7  swift-frontend           0x0000000105f34d24 void swift::Diagnostic::gatherArgs<swift::DeclBaseName, bool, llvm::StringRef>(swift::DeclBaseName, bool, llvm::StringRef) (.cold.1) + 0
8  swift-frontend           0x00000001011e7e18 swift::ApplyInstBase<swift::TryApplyInst, swift::TryApplyInstBase, true>::getSelfArgument() const + 112
9  swift-frontend           0x00000001012862d0 (anonymous namespace)::TransferNonSendableImpl::emitDiagnostics() + 5784
10 swift-frontend           0x0000000101284a68 (anonymous namespace)::TransferNonSendable::run() + 528
11 swift-frontend           0x00000001012a916c swift::SILPassManager::runPassOnFunction(unsigned int, swift::SILFunction*) + 1432
12 swift-frontend           0x00000001012a9fd8 swift::SILPassManager::runFunctionPasses(unsigned int, unsigned int) + 1060
13 swift-frontend           0x00000001012ac744 swift::SILPassManager::execute() + 596
14 swift-frontend           0x00000001012a714c swift::SILPassManager::executePassPipelinePlan(swift::SILPassPipelinePlan const&) + 72
15 swift-frontend           0x00000001012a70cc swift::ExecuteSILPipelineRequest::evaluate(swift::Evaluator&, swift::SILPipelineExecutionDescriptor) const + 68
16 swift-frontend           0x00000001012e24d4 swift::SimpleRequest<swift::ExecuteSILPipelineRequest, std::__1::tuple<> (swift::SILPipelineExecutionDescriptor), (swift::RequestFlags)1>::evaluateRequest(swift::ExecuteSILPipelineRequest const&, swift::Evaluator&) + 28
17 swift-frontend           0x00000001012c2a30 swift::ExecuteSILPipelineRequest::OutputType swift::Evaluator::getResultUncached<swift::ExecuteSILPipelineRequest, swift::ExecuteSILPipelineRequest::OutputType swift::evaluateOrFatal<swift::ExecuteSILPipelineRequest>(swift::Evaluator&, swift::ExecuteSILPipelineRequest)::'lambda'()>(swift::ExecuteSILPipelineRequest const&, swift::ExecuteSILPipelineRequest::OutputType swift::evaluateOrFatal<swift::ExecuteSILPipelineRequest>(swift::Evaluator&, swift::ExecuteSILPipelineRequest)::'lambda'()) + 204
18 swift-frontend           0x00000001012a7328 swift::executePassPipelinePlan(swift::SILModule*, swift::SILPassPipelinePlan const&, bool, swift::irgen::IRGenModule*) + 64
19 swift-frontend           0x00000001012c4ef8 swift::runSILDiagnosticPasses(swift::SILModule&) + 192
20 swift-frontend           0x0000000100ae3b94 swift::CompilerInstance::performSILProcessing(swift::SILModule*) + 80
21 swift-frontend           0x00000001008a2e70 performCompileStepsPostSILGen(swift::CompilerInstance&, std::__1::unique_ptr<swift::SILModule, std::__1::default_delete<swift::SILModule>>, llvm::PointerUnion<swift::ModuleDecl*, swift::SourceFile*>, swift::PrimarySpecificPaths const&, int&, swift::FrontendObserver*) + 796
22 swift-frontend           0x00000001008a276c swift::performCompileStepsPostSema(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 1216
23 swift-frontend           0x00000001008ae248 withSemanticAnalysis(swift::CompilerInstance&, swift::FrontendObserver*, llvm::function_ref<bool (swift::CompilerInstance&)>, bool) + 160
24 swift-frontend           0x00000001008a4414 performCompile(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 708
25 swift-frontend           0x00000001008a3ae8 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 2344
26 swift-frontend           0x00000001006b8e5c swift::mainEntry(int, char const**) + 3096
27 dyld                     0x00000001962320e0 start + 2360

Expected behavior
I think it's still a little unclear if this code should actually compile cleanly or produce an error due to:
https://github.com/swiftlang/swift/issues/75473
Environment
Apple Swift version 6.0-dev (LLVM 311c8b35213308e, Swift 488a207cc9d2994)
Target: arm64-apple-macosx14.0
Additional information
No response

This doesn't crash with my fix from https://github.com/swiftlang/swift/pull/76076.
Now I get:
test.swift:22:15: error: returning 'self'-isolated 'self.context' as a 'sending' result risks causing data races
20 | 	public func withContext(_ block: sending (Context) throws -> T) async throws -> sending T {
21 | 		let value: T = try Transaction.with { txn in
22 | 			return try block(context)
|               |- error: returning 'self'-isolated 'self.context' as a 'sending' result risks causing data races
|               `- note: returning 'self'-isolated 'self.context' risks causing data races since the caller assumes that 'self.context' can be safely sent to other isolation domains
23 | 		}
24 |
There is something funky going on here. I am going out of town, I'll look further when I get back.

I do think that there does need to be an error here, just the error is messed up in some way.
.with expects its closure parameter to have a sending result... so the closure has a sending result... but block does not have a sending result. So you are returning a non-sending thing into a sending thing. Since context is actor isolated and the result of body is not sending, I would expect its result to be actor isolated as well... and one cannot return an actor isolated value as a sending result.

Yes, I agree with your analysis here. I think (hope) that had I not run into other issues, I would have figured that out myself. I'll be satisified with the crash resolved, but if you want to use this issue to look more closely at the error I'm all for it.

Yes. While I am here, I want to fix this.

Crash definitely fixed in the 6.1 snapshot!


Install latest versions of dependencies with ng new

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request

Versions.

ng --version: 3.10.10
<EMAIL_ADDRESS>Repro steps.

Run ng new <...>
The log given by the failure.

(N/A)
Desired functionality.

I want to immediately install the latest versions of a newly generated project's package.json dependencies without having to install @angular/<everything>@latest after initializing the project. For instance, when I ran ng new, I got v 4.0.0 on all @angular dependencies, but installing @latest gives me 4.2.4.
Mention any other details that might be useful.

You can accomplish this by using npm i -g npm-check-updates and run ncu -u -q and it will update all of your dependencies to the latest.

@robertbaker Thank you for that tip. That does make it a lot easier. I still think there should be a CLI option or something to install latest from the start.

That really depends on your local npm cache, not the CLI. When I make a new project, I get the latest versions of Angular for instance.
You can use npm cache clean if you're using npm. You might also be behind a npm proxy. https://www.npmjs.com/ or https://github.com/npm/npm should have more information about how to keep your cache up to date.

I'm seeing this as well, yet there is no @angular/* in local npm cache
May be an nvm env quirk?
Additionally @robertbaker  I'd guess you'd meant ncu -u -a.

@filipesilva the package.json file is generated and npm would be installing the version that is in the package.json file. So I don't get how cleaning the cache will help.

@mitulgohil package.json has ranges for dependencies, like "@angular/core": "^4.0.0",. If your cache has a version that can satisfy the range, for instance 4.1.0, then it use that instead of the latest available version.

@filipesilva Thanks for the info, I have cleaned the cache using npm cache clean --force and have generated a new app using ng new but i still get the same package.json with angular 4.0 instead of 4.3

@filipesilva Hi, even I'm facing this issue. I have tested on 3 different macos:

Installed cli using npm install -g @angular/cli.
created a new angular project using ng new test-angular
output of the above command is as below:

installing ng
  create .editorconfig
  create README.md
  create src/app/app.component.css
  create src/app/app.component.html
  create src/app/app.component.spec.ts
  create src/app/app.component.ts
  create src/app/app.module.ts
  create src/assets/.gitkeep
  create src/environments/environment.prod.ts
  create src/environments/environment.ts
  create src/favicon.ico
  create src/index.html
  create src/main.ts
  create src/polyfills.ts
  create src/styles.css
  create src/test.ts
  create src/tsconfig.app.json
  create src/tsconfig.spec.json
  create src/typings.d.ts
  create .angular-cli.json
  create e2e/app.e2e-spec.ts
  create e2e/app.po.ts
  create e2e/tsconfig.e2e.json
  create .gitignore
  create karma.conf.js
  create package.json
  create protractor.conf.js
  create tsconfig.json
  create tslint.json
Installing packages for tooling via npm.
Successfully initialized git.
Project 'test-angular' successfully created.

The project creation takes a 1 sec.
This is the package.json that is generated -
{
  "name": "test-angular",
  "version": "0.0.0",
  "license": "MIT",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "^4.0.0",
    "@angular/common": "^4.0.0",
    "@angular/compiler": "^4.0.0",
    "@angular/core": "^4.0.0",
    "@angular/forms": "^4.0.0",
    "@angular/http": "^4.0.0",
    "@angular/platform-browser": "^4.0.0",
    "@angular/platform-browser-dynamic": "^4.0.0",
    "@angular/router": "^4.0.0",
    "core-js": "^2.4.1",
    "rxjs": "^5.1.0",
    "zone.js": "^0.8.4"
  },
  "devDependencies": {
    "@angular/cli": "1.2.1",
    "@angular/compiler-cli": "^4.0.0",
    "@angular/language-service": "^4.0.0",
    "@types/jasmine": "~2.5.53",
    "@types/jasminewd2": "~2.0.2",
    "@types/node": "~6.0.60",
    "codelyzer": "~3.0.1",
    "jasmine-core": "~2.6.2",
    "jasmine-spec-reporter": "~4.1.0",
    "karma": "~1.7.0",
    "karma-chrome-launcher": "~2.1.1",
    "karma-cli": "~1.0.1",
    "karma-coverage-istanbul-reporter": "^1.2.1",
    "karma-jasmine": "~1.1.0",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "~5.1.2",
    "ts-node": "~3.0.4",
    "tslint": "~5.3.2",
    "typescript": "~2.3.3"
  }
}

Also my npm version is 4.1.2

@filipesilva  And packages are not installed by default. I have to npm install the packages. After npm install i can see that angular version has been incremented to 4.3 but of-course package.json doesn't reflect that change. I think I can use Yarn to install and also create a lock file so that my dependencies are fixed.
Thanks for the help. Would have loved to have the feature of package.json reflecting what is installed in node_modules so it becomes easy to rationale about project dependencies but this will do for now.

HI! I'm checking how it works ng to retrieve the blueprings to generate a new project, and I realized that no depends on my local npm cache but on from @schematics/angular. You can check out here.


Added rudimetary POSvc support

Get will only return the Header record.
Will update to include more methods when needed.

Might be nit picky, but can you change the class name from PurchaseOrders to PurchaseOrder?


Use mem pressure callbacks to find minimum heap size to run a benchmark

Usage:
bash ./runs-with-heap-size.sh <julia> <heap-size> <benchmark>

Where heap-size has to be essentially bisected.

@kpamnany and @NHDaly can't add you as reviewers.
Tagging you in case in you want to take a look.

Bump.

The implementation looks fine. Did you run some tests to make sure the results make sense?

Yeah, it works fine. You just need to pass a --heap-size-hintgreater than 250MB, since we're subtracting that amount in https://github.com/JuliaLang/julia/blob/c239e9966a30797949d856c18b14e4e5421a90e9/src/gc.c#L3623 and reserving it for LLVM.


Plagiarism checks: Fix plagiarism case verdict message

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[x] I followed the coding and design guidelines.

Motivation and Context
Plagiarism case verdict email didn't have its title placeholder resolved.
Description
This PR adds missing if statement for resolving placeholder title of email sent when plagiarism case is resolved.
Surprisingly, there was a test case for that, which asserted that wrong value was returned by Artemis.
Steps for Testing
Prerequisites:

1 Instructor
2 Students (on of them needs to be your TUM account, so that email is delivered)

Create an exercise (text is easiest to test)
Submit two identical solution from two different student accounts.
From the instructor account go to the exercise management page -> check plagiarism.
Run checks and confirm displayed comparison.
Go to the plagiarism case created for you.
Send a default notification to the student (yourself)
Select and apply plagiarism case verdict.
Verify that you got an email with proper title (not placeholder, see screenshots below)

Testserver States

Review Progress
Performance Review

[ ] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Screenshots
Before:

After:
to be added here after ts1 database migration is fixed (I'm on it)

This PR is applied on the top of #7302 and should be merged to develop after it.

Tested on Legacy TS3
I followed your instructions, but when I click on "Check Plagiarism" I get the error that no valid submissions exist. (Text Exercise)
Do I need to test on a specifc server or did I miss anything to make the submissions valid?
Submissions of both students where graded by a course instructor. I also removed or played around with the settings in the plagiarism and exercise view with the hope to make the submissions valid, with no success.
Not sure if this is a bug, maybe you could update the instructions a bit? I'd be happy to test again then.

Tested on Legacy TS3
I followed your instructions, but when I click on "Check Plagiarism" I get the error that no valid submissions exist. (Text Exercise) Do I need to test on a specifc server or did I miss anything to make the submissions valid? Submissions of both students where graded by a course instructor. I also removed or played around with the settings in the plagiarism and exercise view with the hope to make the submissions valid, with no success.
Not sure if this is a bug, maybe you could update the instructions a bit? I'd be happy to test again then.

Most likely your submissions were not long enough. By default you need to have 50 words for text exercise or 50 diff lines for programming exercise. You change for each run

Tested on ts1, works as expected

I am trying to test the case on ts1 and after step 4. Run checks and confirm displayed comparison:

I cant find the Plagiarismcases as expected:

What am I doing wrong?
Branch: plagiarism-checks-fix-verdict-message •
Commit Hash: 54b4e39 •
Committer Date: Sat, 28 Oct 2023 08:11:39 GMT •
Last Committer: jakubriegel

@nata-81 You can find plagiarism cases under the Assessment menu
I've updated PR description to be more informative

Tested on ts1, works as expected.


Fluxcd controller for terragrunt

Hello,
I used some Terragrunt two times in a different projects amb I'm very happy due to DRY filoshophy.
For ther hand, we're working moving Terraform code inside FluxCD with this controller https://github.com/weaveworks/tf-controller
I think could be a good idea if there was the same at Terragrunt level, i mean a fluxcd controller for terragrunt codes.
Marc
PD: I should preferred comment via slack or some chat message service but I don't found , apologies for sharing ideas as a github issues...

In case @mcortinas or anyone else is interested there is prior art for the DRY pattern with TF-controller here - https://github.com/phoban01/flux-terragrunt-poc. It might be interesting to also consider something where terragrunt  and TF-controller OCI could work together to provide separation of concerns around configuration and instruction


All the documentation removed?

Hi,
What happened in https://github.com/foxdonut/meiosis/commit/a04e86d226531ab04d4cf29e92628c3a5fb96f76 ? Why was all the documentation removed?

Hi @yohcop
I updated the Meiosis Tutorial. The core pattern is the same, but the approach is simpler and makes more idiomatic use of view libraries.
Because of this simpler approach, some of the articles in the documentation are redundant; some are outdated; and some solve problems that are no longer problems at all.
Thus, I need to update the documentation, and this is in progress. In the meantime, I did not want to leave the old documentation because it would lead to confusion.
I hope that makes sense.


Agent.MachineName should be Agent.ComputerName

Hi
I have encountered a problem with this variable in one of our pipeline. I wanted to target a specific machine with demanding Agent.MachineName, however I got an error message that there is no eligible agents for this job.
When I checked the capabilities of the agent I noticed that it has Agent.ComputerName variable instead the Agent.MachineName.
When I use this in the demand, the job is populated to one of the agent on the machine.
We have an Azure DevOps Server
Version Dev17.M153.5
Thanks
Zoltan
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 11d3469c-83c2-c2f6-41d0-08f82c330bbc
Version Independent ID: a373c48d-6395-3002-d2d8-bbc1fea2e48e
Content: Predefined variables - Azure Pipelines
Content Source: docs/pipelines/build/variables.md
Product: devops
Technology: devops-cicd-build
GitHub Login: @juliakm
Microsoft Alias: jukullam

@djc5358 -- Zoltan, thank you for your feedback.  Agent.ComputerName is only used in 2017, and subsequent versions use Agent.MachineName.
I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


Remove broken tests and tidy up

Comment out broken tests
Move unit tests to src/
Rename tests to be developer-friendly

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@5f2f97a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage        ?   67.82%
=======================================
  Files           ?       12
  Lines           ?      289
  Branches        ?        0
=======================================
  Hits            ?      196
  Misses          ?       93
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[BUG] Chromium zombie processes when ran inside docker

Context:

Playwright Version: 1.20.1

Operating System:
NAME="Ubuntu"
VERSION="20.04.4 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.4 LTS"
VERSION_ID="20.04"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Browser: Chromium (at least)

Extra: Driver and browsers are preinstalled and cached inside the docker image

Code Snippet
There are two parts to this, first the docker image (the official one is really massive since it bundles all browsers, and also is on a JDK 11 baseline instead of JDK 17, hence this one which is a little slimmer).
 However I'd then expect whatever call gets a permission denied to be logged, which isn't the case.
import com.microsoft.playwright.*;

public class ExampleReproducible {

    private static final Logger LOGGER = LoggerFactory.getLogger(OpenGraph.class);

    public static void main(String[] args) throws InterruptedException {
        try (
            Playwright playwright = Playwright.create();
            Browser chromium = playwright.chromium().launch()
        ) {
            LOGGER.info("Loaded Chromium {}", chromium.version());
        } catch (Exception e) {
            throw new IllegalStateException("Failed initializing Chromium via Playwright!", e);
        }
        LOGGER.info("Sleeping...");
        Thread.sleep(60_000);
    }

}

Describe the bug
After this has ran, there are 2 zombie chrome processes left, despite running without errors and the close method of both Playwright and Browser being invoked.
$ docker run -it opengraph
Skipping browsers download because `PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD` env variable is set
08:09:09.720 [main] INFO OpenGraph - Loaded Chromium 101.0.4929.0
08:09:09.783 [main] INFO OpenGraph - Sleeping...

  PID TTY      STAT   TIME COMMAND
    1 pts/0    Ssl+   0:03 java -jar /opt/opengraph/opengraph.jar
  127 ?        Z      0:00 [chrome] <defunct>
  128 ?        Z      0:00 [chrome] <defunct>
  168 pts/1    Ss     0:00 bash
  176 pts/1    R+     0:00 ps ax

After a bit more experimentation, the following setup fixes the issue altogether:
try (
    Playwright playwright = Playwright.create();
    Browser chromium = playwright.chromium().launch(new BrowserType.LaunchOptions().setArgs(List.of(
        "--single-process",
        "--no-zygote"
    )));
) {
    LOGGER.info("Loaded Chromium {}", chromium.version());
} catch (Exception e) {
    throw new IllegalStateException("Failed initializing Chromium via Playwright!", e);
}

It's not optimal but it does the job. Not sure how that interracts with --no-sandbox however. Docs of chrome flags (here https://peter.sh/experiments/chromium-command-line-switches/ ) suggests on linux the no-sandbox is also necessary, while there's also a --no-zygote-sandbox flag which supposedly allows sandboxing without the zygote...

Well this has other issues, notably that single-process doesn't work well with how playwright's driver is implemented, which is fair.
I can't figure out the whole of it, but by making sure to not throw within the Playwright loop (well, thread more specifically), which I was doing through not handling the TimeoutError inside it, then things are fine. Oh well.

I had the same issue with the zombie processes. After a lot of research I found out that by default docker uses an isolated pid namespace. So the pid's of host are different from the pid's of docker container processes.
Example: the pid 1 was for the java process inside the docker container. And of course the pid 1 was systemd in the host.
I added pid: "host" in the docker container. This way the pid's that the container's processes allocate are sequential to the pid's of the host. When the process loses his parent process and becomes a zombie process, his parent will become the process with pid 1 (systemd). systemd which is the master process waits all his children. So he waits for all those zombie processes and eventually stops them.
My solution for this issue was a "workaround". Cause the zombie processes problem still exists but are killed by the operating system. I don't know why they are left behind. Maybe a problem from browser(chromium and firefox as I tested) or Playwright not closing properly all the browser's threads.


ORC-901: Remove junit-vintage-engine from mapreduce/tools module

What changes were proposed in this pull request?
This PR aims to remove old dependencies from mapreduce and tools modules by removing junit-vintage-engine.
Why are the changes needed?
This will complete the JUnit5 migration in these modules.
How was this patch tested?
Pass the CIs.

cc @williamhyun and @pgaref

Thank you, @williamhyun !


Move member documentation from constructor

We have some tech debt that needs to be addressed, I'm making this PR to have a conversation about what should be our style regarding docs and TypeScript. I also wanted to expose any Webdoc bugs before enlisting the help of others.
Goals

Make the constructor easier to read
Expose documentation in typings
Remove redundant information in docs such as access-modifiers and types

Style Rules

Add initial values and member docs to the class-level
Remove redundant access modifiers (public/private/protected)
Remove type declarations for all private
Make docs single line, if possible
Remove redundant types for members (known issue about this below)

Blocking Issues

~TypeScript types/defaults are not inferred https://github.com/webdoc-labs/webdoc/issues/66~
~Readonly is not supported or inferred https://github.com/webdoc-labs/webdoc/issues/67~
~Type inference for primitive properties: https://github.com/webdoc-labs/webdoc/issues/72~

Additional Follow-up

In AccessibilityManager, there are two instances of .bind(this) in the constructor. I'd suggest we use bind-decorator instead to indicate bound functions. Would make the source a little cleaner.

Codecov Report

Merging #7113 (8f42e78) into dev (fed4c5b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #7113   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           17        17
  Lines          699       699
=========================================
  Hits           699       699

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed4c5b...8f42e78. Read the comment docs.

I published @webdoc<EMAIL_ADDRESS>and added the upgrade to this branch. Hopefully, those blocking issues should not pop up again!

I published @webdoc<EMAIL_ADDRESS>and added the upgrade to this branch. Hopefully, those blocking issues should not pop up again!

Looks great, thanks @SukantPal
Verify this works:
http://pixijs.download/fix-member-docs-accessibility/docs/PIXI.AccessibilityManager.html

Looks great, thanks @SukantPal
Verify this works:
http://pixijs.download/fix-member-docs-accessibility/docs/PIXI.AccessibilityManager.html


Wrong temp range in homekit

Hello,
The plugin works very well, but when the AC Fujitsu General is exposed to homekit there is some mods - auto, heat, cool and etc. but in heat mode max temp is only 25C(range is from 10 to 25, my ac support from 18 to 30), in cool mode there is range from 10 to 30. How this can be adjusted to match my ranges? In the tuya app the ranges are correct - from 18 to 30.

Fixed in v1.0.7.


add support for non trivial objects

should use move mechanic or put another static assert

Can you elaborate on this? Looking through the code it's not obvious what or where a failure would occur.

As I understand, this should work fine if the author of the class has properly implemented the copy assignment operator. For example, if T is std::shared_ptr, the copy assign would first decrement the usage count of the pointer held in a and then increment the usage count of the pointer held in b.

copy assignment

ah, assignment, not constructor.
It will still leak until given slot is reused for new data, not to mention that the buffer array is uninitialized.
I'll add the assert until figuring out the std::move + rval refs and all of the related "what ifs".

I think the slot would hold onto memory until reuse, but that’s much better than a leak because the buffer size is bounded.
Anyway thanks for the library!

I think the slot would hold onto memory until reuse, but that’s much better than a leak because the buffer size is bounded.
Anyway thanks for the library!

The copy assignment a = b is ok if the copy assignment operator of type T is implemented.
It is responsibility of the maintainer of type T to ensure that current resources is freed before copy resources from others.
Is my understand correct?

Currently the buffer array is uninitialized, so that will be very undefined operation.
This would also make the copy constructors unusable for it's intended purpose.

Currently the buffer array is uninitialized, so that will be very undefined operation.
This would also make the copy constructors unusable for it's intended purpose.

I see. So, if the type can be default constructed, then it will be fine?

As long as all members are also trivially (default) constructible.


Syntax errors in html code

https://github.com/SeanHLam/metrolics_repo/blob/d2d3ad31d13360b291b4e56f9edd17791b79a732/index.html#L180
https://github.com/SeanHLam/metrolics_repo/blob/d2d3ad31d13360b291b4e56f9edd17791b79a732/index.html#L193
...and others. Please check.

Hey @WimTeuling Can I do this please?

Fix anything you want. Do communicate this with your team member(s).

Which team members @WimTeuling ?


RYB Support

I've been working on this off and on, the original issue is here: https://github.com/facelessuser/coloraide-extras/issues/12.
I've basically been evaluating different RYB approaches and trying to see which ones are better.

The easiest approach is something like what is described in Junichi Sugita's and Tokiichiro Takahashi's paper . This basically just takes the sRGB color space and compresses blue and such to align yellow as a primary color. It has the advantage that it encompasses the entire gamut of sRGB. While in their evaluation they claim decent RYB mixing for watercolors and such, the color space creates some odd discontinuities. This can be seen in the 3D model.

The other approach is the Gosset and Chen approach. They provide a single-direction algorithm. This approach uses trilinear interpolation which is easy to implement and actually creates a color space with pretty consistent smooth transitions in the space. It does have a smaller gamut (things like cyan are not present).
The round-trip translation is a problem, but I've actually been able to solve this. Digging around, I was able to find an inverse trilinear interpolation approach using the Gauss–Newton algorithm. This works well for colors within the gamut, especially if you tune the initial guesses for problematic cases. I assume the guesses could be tuned to better handle colors outside the gamut as well, but that is less of a concern. We also can reverse their "biasing" using Newton's method as well, tuning the guesses helps improve good round-tripping. Employing these methods, we are able to convert back and forth and generate the 3D model of the space.

Another approach they employ is using a cubic easing function to bias the colors towards the primaries to produce a non-linear interpolation of the colors. This is done to " limit the use of ambiguous colors in [their] implementation". More specifically they state:

Biasing in this manner will ensure that the viewer will encounter a more limited number of easily identiable colors, but still llows
for smooth transitions between colors.

I actually find this biasing to have downsides. If you are trying to generate monochromatic steps, you get too little variance as you get close to the primary and tertiary colors. The good news is that we do not have to bias if we do not want to. Unless you specifically require further limiting the colors in the space, I would not generally recommend this. Basically, the colors are more localized. The blue is more tightly bunched in its corner, etc.

They select a number of colors they claim are close-ish to those used by Itten. The thing is that there are various color sets by Itten. From different revisions of his book, the color wheel uses different variants of colors. The colors chosen in the paper have some pretty washed-out blues, etc. There are variants of Ittens' supposed colors that have more vibrant colors, and others that are less so. At least for the images here, we are using a pretty common, documented set of Itten colors, but which are the right or best, who knows. We actually, for testing purposes, implemented the Gosset and Chen colors and the Itten colors. Obviously, we'd pick a set to officially ship if we went this route.
The last thing to note with this approach is that you get a more pigment-like mixing. The absence of colors gives you white, which makes sense, and mixing all colors together will give you a muddy brown, which also makes sense. Which makes sense. You can't really mix achromatic colors as easily. And if you want to darken a color with pure black or white, that can be tricky as that is not how the space works.  I have experimented with an RYBK variant that actually allows you to mix colors in a normal pigment-like fashion, and then using K allows you to mix in pure black to darken.

Example of RYBK normal pigment mixing and mixing with pure black:

Moving forward, I think we will be using the Gosset and Chen algorithm.  I think we are just going to ship a traditional RYB space.  It will naturally have a more limited gamut because the primary colors cannot create all colors like CMY can. I think this is a more accurate approach than just squeezing the RGB gamut creating odd bands in the space.
The current hold up is related to some minor round trip values on the edge of the cube. In these few cases, the results are very close, but we'd like to be even closer.  We'd like to ship these with the best precision we can. These Newton algorithms perform best depending on how good your initial guess is. The inverse trilinear guess is generally pretty good for almost any color within the RYB gamut, but near some corners we fall just a bit shorter than we'd like. We are talking about 0.9876 vs 1.0, so not huge. I'd like to see closer if possible.
We are experimenting with 3 variants. The original Gosset and Chen values. Values by Itten (though we have to guess  a decent brown - all colors mixed together), and a vibrant variant using pure sRGB red, yellow, and blue. I don't know which one we'd ship, or if we'd ship multiple variants, but these are currently under evaluation.

I think we have something fairly reliable for all colors in the gamut. There is no guarantee that colors outside the RYB gamut will round trip though. As a matter of fact, I can probably guarantee there are colors that won't round trip at all.

I think we will ship the Gosset and Chen RYB model. We will provide it without the biasing, but for those who want to try it out as described in the paper, we will also provide the biased model just to be faithful to the paper.
It should be noted, that biasing doesn't give more accurate colors, on the contrary, it limits the colors to provide "less ambiguous" colors. This just means that the colors clump at the corners and you have less in between. They had a very specific use case they were targeting. Baising isn't helpful when representing this as a color space.
As for round tripping. Round tripping is quite good while inside the gamut. Outside, all bets are off, but this is fine. This isn't the only color space that has such behaviors.
Can any 8 colors be used to get different variants of RYB? Well, technically yes, but round tripping might now always be as good depending on the selected set. Different sets of colors can warp the interpolation cube more or less. Warp it too much, you may find the invert algorithm can't resolve some colors at the edge of the gamut. Let's take a look at the Gosset and Chen cube, first rendered in its own cube, and the sRGB color space rendered in the RYB gamut. Notice how warped the sRGB color space is within the RYB gamut.

Even though the sRGB space is so warped in the RYB gamut, it round trips perfectly.  But in our tests, we tried colors from Itten's color wheel (pictures on the internet), and it had occasional difficulties with resolving some corners of the cube at their maximum values.
The main reason I can see people wanting to tweak the cube is to have more vibrant colors. I am currently omitting such a variant, but I may include one if people requested it. If a more vibrant RYB is desired, the following values could be used which have great round tripping. Colors were sourced from here: https://www.w3schools.com/colors/colors_wheels.asp. We did not yet select a proper brown for the "black".
RYB_CUBE = [
    [1.0, 1.0, 1.0],                                                # White (c000)
    [0.996078431372549, 0.15294117647058825, 0.07058823529411765],  # Red (c100)
    [0.996078431372549, 0.996078431372549, 0.2],                    # Yellow (C010)
    [0.984313725490196, 0.6, 0.00784313725490196],                  # Orange (c110)
    [0.00784313725490196, 0.2784313725490196, 0.996078431372549],   # Blue (c001)
    [0.5254901960784314, 0.00392156862745098, 0.6862745098039216],  # Violet (c101)
    [0.4, 0.6901960784313725, 0.19607843137254902],                 # Green (c011)
    [0.0, 0.0, 0.0]                                                 # Black (c111)
]


Fix #1151: Improve file system watching mechanism

Fix #658: Assertion in File Watcher: The data area passed to a system call is too small
Fix #1269: Save As file into the project folder doesn't update SolutionExplorer

:+1:


tmt export to nitrate does not handle the manual attribute

Exporting test with the manual attribute set to true into nitrate creates an automated test case instead of the manual one.

@hegerj, will you have a look at this?

Will do, however it should be noted that creating manual cases in Nitrate through tmt is not supported.

Resolved by #433.


Add utility to remove unused modules

Issue
Required for removing non-clients like Credential Providers in https://github.com/aws/aws-sdk-js-codemod/pull/778
Description
Add utility to remove unused modules
Testing
CI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Currently blocked, because some identifiers are used even after replacement, but by new imports
Example:
+ import * as AccessAnalyzerClient from "aws-sdk/clients/accessanalyzer";
  import { AccessAnalyzer as AccessAnalyzerClient } from "@aws-sdk/client-accessanalyzer";
  import { ACM as ACMClient } from "@aws-sdk/client-acm";
  import { ApplicationDiscoveryService as DiscoveryClient } from "@aws-sdk/client-application-discovery-service";
+ import * as DiscoveryClient from "aws-sdk/clients/discovery";
+ import * as ACMClient from "aws-sdk/clients/acm";

  new AccessAnalyzerClient();
  new DiscoveryClient();
  new ACMClient();


docs(*): add "kuma.io/sidecar-drain-time" k8s annotation

Signed-off-by: Ilya Lobkov<EMAIL_ADDRESS>

Right, needs to be backported to Kuma 1.8

@lobkovilya please finish that up :)

I took the liberty of backporting this to 1.8 - if you want me not to do that let me know. I meant no ill intent - just wanted to move this PR forward since I know you're busy with other things.


Feature request: auto open file inner code IDE

when I type wr inner Rustover terminal, I want to open the exercise file automatically
and I have some ideas, I want to do this

Another way is to open the file in any terminal according to the env EDITOR.

Another way is to open the file in any terminal according to the env EDITOR.

Currently, when executed in zed, idea, rustover, or vscode's terminal, it will open using IDE or use EDITOR as the fallback.

Unfortunately, this is not something we want to add to wr at the moment—it's difficult to test for regression and likely to be used by a very small percentage of people.


400 Error editing AGOL hosted feature service

Good Afternoon,
I'm trying to track down a 400 error when I add new records to a feature service in AGOL. At the moment, I have the service unsecured in AGOL. However, I plan on securing it once I figure this out. I can confirm that I am able to upload features without the proxy service.
The other service returns the following error message "The remote server returned an error: (400) Bad Request."
This makes me think that the request isn't being formatted correctly by the proxy.
I'm making the following request through the proxy.
POST http://localhost:20318/proxy.ashx?https://services6.arcgis.com/{organizationAGOLKey}/arcgis/rest/services/demo_feature_service/FeatureServer/0/applyEdits&wab_dv=2.5
f=json&adds=%5B%7B%22geometry%22%3A%7B%22x%22%3A-10688064.34915602%2C%22y%22%3A6287712.483808069%2C%22spatialReference%22%3A%7B%22wkid%22%3A102100%7D%7D%2C%22attributes%22%3A%7B%22Date%22%3Anull%2C%22Location%22%3Anull%2C%22Category%22%3A5%2C%22Name%22%3Anull%2C%22Comments%22%3Anull%7D%7D%5D
The proxy config is configured the following:
`

<serverUrl url="https://{organization}.maps.arcgis.com"
           matchAll="true"
           clientId="{applicationClientID}"
           clientSecret="{applicationSecretKey}"
           oauth2Endpoint="https://{organization}.maps.arcgis.com/sharing/oauth2/"
           />

`

@bmoregeo
Error 400 is normally returned from the ArcGIS Server or ArcGIS Online feature layer on your case, related to bad parameters. Your proxy setting seems to be fine.