Fix describe pod PeerAuthentication info

Please provide a description of this PR:

/retest

@googlebot I signed it!

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-tests_istio

integ-distroless-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-tests_istio

integ-distroless-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-distroless-k8s-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-tests_istio

integ-distroless-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-distroless-k8s-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-tests_istio

integ-distroless-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-distroless-k8s-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-tests_istio

integ-distroless-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-distroless-k8s-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-cni-k8s-tests_istio

integ-security-istiodremote-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-security-istiodremote-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-tests_istio

integ-distroless-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-distroless-k8s-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-cni-k8s-tests_istio

integ-security-istiodremote-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-security-istiodremote-tests_istio

integ-security-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-tests_istio

integ-distroless-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-distroless-k8s-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-cni-k8s-tests_istio

integ-security-istiodremote-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-security-istiodremote-tests_istio

integ-security-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-security-k8s-tests_istio

integ-pilot-multicluster-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-tests_istio

integ-distroless-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-distroless-k8s-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-pilot-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-cni-k8s-tests_istio

integ-security-istiodremote-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-security-istiodremote-tests_istio

integ-security-k8s-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-security-k8s-tests_istio

integ-pilot-multicluster-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
7c6c7f097c08d240430ea80b58a6ef6518d5ae4b
link
true
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest-required

/retest


Fix SparseDenseCwiseMulOrDivGrad scalar case

Fixes #46008.

Thanks for suggestion! [N, 0] indices array looks weird to me because number of elements inside it is zero, which means that we are gathering nothing. In that case, what should we expect the output shape of gather_nd? Shape of (N,) or a scalar.

I agree that size-zero arrays are always a bit weird, but they're often a useful special case. I'd return shape (N,) if the requested indices were shape (N, 0); requested indices with shape (0,) would return a scalar (if that's supported). That matches the general case of (..., N) -> (...) for a full index, right?
We do something similar with slices in Python, and so does NumPy:
https://numpy.org/doc/stable/reference/arrays.indexing.html#detailed-notes

An empty (tuple) index is a full scalar index into a zero dimensional array. x[()] returns a scalar if x is zero dimensional and a view otherwise. On the other hand x[...] always returns a view.

It's just adding some leading dimensions, but seems like the same principle.

@WindQAQ  Can you please check @allenlavoie's comments and keep us posted ? Thanks!

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

@WindQAQ  Any update on this PR? Please. Thanks!

I'm going to go ahead and close this PR, because it seems to have stalled. If you're still interested in pursing this (and responding to my comments), please feel free to reopen!


VRT branch merging issue

Hi,
The ignore and compare areas for a screenshot in a branch when merged to Master branch is not captured.

@dikshithasuvarna thanks for request
could you provide some steps to reproduce the issue?

Hi,
Please find below the steps:

Navigate to VRT portal
Capture screenshot in "test" branch--> apply some ignore area and create a baseline
Select variation option
Select "from branch" as "test" and "To branch" as "master"--> click on merge
New build is created in unresolved state--> Approve Screenshot --> status changed to Approved
Now baseline is created in master branch --> ignore area is not applied in master branch
to check that..
Point to master branch and take a screenshot --> new build is created in unresolved state

Hi @pashidlos,
Is this bug fixed and available in any release?

@dikshithasuvarna it's not yet fixed
in fact manual merge is obsolete functionaliity
use automatic merge so no manual work is needed, just run tests agains main btanch and they would be merged from feature branch

@pashidlos Can you provide more info about "automatic merge" ?
I want to have some tests ran on branches and on master, multiple branches can be created in parallel, and devs can merge master in branches at anytime. The thing is, a dev can open a new branch from master, and only run tests on it much later. So how does VRT knows which master baseline to use for newly created branches?
My objective is that once a diff has been approved on a branch, if the branch is merged, we shouldn't have to approve it again in master. On the other side, if some new diffs have been approved in master, and that we merge master in the current branch, We shouldn't have to re-approve the diffs already approved in master.
Am I right? Or missing something ?
Thanks you very much for your work on this very useful project ;-)

@dikshithasuvarna it's not yet fixed in fact manual merge is obsolete functionaliity use automatic merge so no manual work is needed, just run tests agains main btanch and they would be merged from feature branch

@pashidlos The automatic merge does not work as expected. It created new baseline in the master branch again.

@pashidlos Any update on the above issue?

@dikshithasuvarna why do you want to use the manual merge? Did you try to enable Auto Approve option for your project? If you approve screenshot in feature branch and then merge it to master, screenshot in master should be auto-approved.

it sounds like auto merge issue
the ones from new test run should be carried over when with automerge
do you see the test is passing in feature branch and when code is merged test is failing on main branch?

Found a workaround on this hence closing this thread.


[FEATURE] AntiVoid

coming out of the void

open novoid from static and you can exit with packet fly or by putting a block under you
but i don't know if this is valid on every server


Build Failing - Encryption key not generated.

I am not sure how to handle this error
0.01s$ openssl aes-256-cbc -K $encrypted_7e1c958561a2_key -iv $encrypted_7e1c958561a2_iv -in github.properties.enc -out github.properties -d
iv undefined
The command "openssl aes-256-cbc -K $encrypted_7e1c958561a2_key -iv $encrypted_7e1c958561a2_iv -in github.properties.enc -out github.properties -d" failed and exited with 1 during .
there was a change added about 10 days ago and it seems to have taken the build out. If someone could put into the README how to handle this it would be really helpful. I think it has to do with this. http://docs.travis-ci.com/user/encrypting-files/

The keys needed to decrypt the github.properties.enc file are set as two environment variables ($encrypted_7e1c958561a2_key and $encrypted_7e1c958561a2_iv) in the repository settings of travis-ci.
On forks and pull requests those secure variables aren't available, so the openssl command fails

@Meisolsson and @larsgrefer are already making a fix about this, and it's under review.
Sorry for this.

Possibly silly questions:
Why not make the content of github.properties environment variables in travis? Then .travis.yml before_script can be changed to something like:
echo "GITHUB_CLIENT=$GITHUB_CLIENT" >> github.properties
echo "GITHUB_SECRET=$GITHUB_SECRET" >> github.properties
echo "GITHUB_CALLBACK=$GITHUB_CALLBACK" >> github.properties
Like this you can decouple the travis github.properties (github.properties.enc) from the code. It also makes it easier for people to set up their own travis ci.
Since the key and iv are secured in travis (I may be wrong here), securing the content of github.properties in travis would make the system negligibly less secure: in the event where travis is compromised, the underlying application client and secret can be easily had in either cases.
Please correct me if I'm not making sense. :)

Sorry been gone for a while, the problem with environment variables is that they can't be used on fork builds. So we just have to remove them.

@Meisolsson The encrypted github.properties.enc file can not be used on forks either, because the decryption keys are stored as environment variables. With #885 we will get multiple ways to set the 3 values (project gradle.properties, user gradle.properties, environment-variables, command-line options)

Ah I see. :)

@froyomuffin You are absolutley right.
We can use special environment variables which will be used directly by gradle:

If the environment variable name looks like ORG_GRADLE_PROJECT_prop=somevalue, then Gradle will set a prop property on your project object, with the value of somevalue.

Using this we don't need the github.properties(.enc) file at all

@larsgrefer @Meisolsson
If the github.properties(.enc) file is dropped in favor of environment variables for gradle, we would still have the issue that we're having today with travis environment variables not being available for pull requests (I understand this is for security reasons?).
I just tried building (gradle clean build) and running unit tests (gradle test) and both seem to do fine without having the github values populated. Could we configure gradle and .travis.yml to simply builld without the github info (as it would be the case in PRs)?

@froyomuffin My pull request intends to use the build-in property system of gradle. This allows multiple ways of setting properties:

gradle.properties file in the project directory
gradle.properties file in the users home directory (~/.gradle/gradle.properties)
Special named environment variables
Command line parameters
My pull request provides dummy values inside the project's gradle.properties in order to let the build proceed in every case. On your local machine these dummy values can be overridden from the gradle.properties in your home directory and on secure Travis builds (neither pull request nor forks) the values can be overridden by environment variables. (Unsecure Travis builds will use the dummy values instead)

Well the value are already set in none are found and form what I have read there is no way to use environment variables on fork build on Travis

@Meisolsson For security reasons environment variables are not available on pull requests and forks

http://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings

At the moment we have the issue that travis fails when the environment variables are not available. This will be solved by #885


Toy Project after study completed

Specification

Spring WebFlux (Reactor Netty)
Spring R2DBC
jasync-mysql

Prerequisites

Overview of each above

Boilerplate project created


Remove illegal characters on ingest

Prompted by this: https://github.com/NaturalHistoryMuseum/ckanext-versioned-datastore/issues/128.
Exactly which characters we should remove is tbd, need to do a bit more reading. Likely to be implemented in prepare before diffing.

This is done, will be released when vNext is released.


AnimatedCrossFade's hidden widget intercepts gestures

Steps to Reproduce
Make an animated cross fade with widgets that use gestures, e.g.
    import 'package:flutter/material.dart';

    void main() {
      runApp(new MyApp());
    }

    class MyApp extends StatelessWidget {
      @override
      Widget build(BuildContext context) {
        return new MaterialApp(
          title: 'Flutter Demo',
          home: new Scaffold(
            body: new Center(
              child: new AnimatedCrossFade(
                duration: const Duration(milliseconds: 700),
                crossFadeState: CrossFadeState.showFirst,
                firstChild: new Container(
                  width: 100.0,
                  height: 100.0,
                  decoration: new BoxDecoration(color: Colors.red[200]),
                  child: new RaisedButton(
                    child: new Text('ping'),
                    onPressed: () => print('ping'),
                  ),
                ),
                secondChild: new Container(
                  width: 100.0, height: 100.0,
                  child: new RaisedButton(
                    child: new Text('pong'),
                    onPressed: () => print('pong'),
                  ),
                ),
              ),
            ),
          ),
        );
      }
    }

It shows a button marked "ping". However when I click it, it prints "pong".
The hidden widget should not be able to intercept gestures.
Possible solutions:

AnimatedFadeTransition could only build the visible child when only one child is visible.
FadeTransition could build an empty container opacity is 0.0.
Opacity could build an empty container when opacity is 0.0.

Credit to ZeroProcess for raising it in this Stack Overflow question.
Flutter Doctor
[✓] Flutter (on Mac OS X 10.12.4 16E195, channel master)
• Flutter at /Users/jackson/git/flutter
• Framework revision 7154ac48db (2 days ago), 2017-05-16 09:32:27 -0700
• Engine revision 6fef702cfa
• Tools Dart version 1.23.0-dev.11.11
[✓] Android toolchain - develop for Android devices (Android SDK 25.0.3)
• Android SDK at /Users/jackson/Library/Android/sdk/
• Platform android-25, build-tools 25.0.3
• ANDROID_HOME = /Users/jackson/Library/Android/sdk/
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version: OpenJDK Runtime Environment (build 1.8.0_112-release-b06)
[✓] iOS toolchain - develop for iOS devices (Xcode 8.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 8.3.1, Build version 8E1000a
• ios-deploy 1.9.1
• CocoaPods version 1.0.1
[✓] Android Studio (version 2.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Gradle version 3.2
• Java version: OpenJDK Runtime Environment (build 1.8.0_112-release-b06)
[✓] IntelliJ IDEA Community Edition (version 2016.3.4)
• Dart plugin version 163.13137
• Flutter plugin version 12.1
[✓] Connected devices
• iPhone 7 Plus • 5F90A4C3-6F80-446A-88CB-5394635BF8EF • ios • iOS 10.3 (simulator)

Hi @collinjackson
I believe the issue might have been fixed dartpad sample
Should I close the issue?
Thank you

My team's been seeing this issue, with secondChild elements receiving clicks while firstChild is visible.
our workaround is to provide each child with a Stack-based "backstop" to capture click events.
`class RecipeAnimatedCrossFade extends StatelessWidget {
final Widget firstChild;
final Widget secondChild;
final CrossFadeState crossFadeState;
final Duration duration;
RecipeAnimatedCrossFade({
this.firstChild,
this.secondChild,
this.crossFadeState,
this.duration,
});
@override
Widget build(BuildContext context) {
return AnimatedCrossFade(
crossFadeState: crossFadeState,
firstChild: Stack(
children: [
Positioned.fill(
child: Container(child: AbsorbPointer()),
),
firstChild,
],
),
secondChild: Stack(
fit: StackFit.passthrough,
children: [
Positioned.fill(
child: Container(child: AbsorbPointer()),
),
secondChild,
],
),
duration: Duration(milliseconds: 100),
);
}
}
`

My team's been seeing this issue, with secondChild elements receiving clicks while firstChild is visible.
our workaround is to provide each child with a Stack-based "backstop" to capture click events.
  final Widget firstChild;
  final Widget secondChild;
  final CrossFadeState crossFadeState;
  final Duration duration;

  MyAnimatedCrossFade({
    this.firstChild,
    this.secondChild,
    this.crossFadeState,
    this.duration,
  });

  @override
  Widget build(BuildContext context) {
    return AnimatedCrossFade(
      crossFadeState: crossFadeState,
      firstChild: Stack(
        children: [
          Positioned.fill(
            child: AbsorbPointer(),
          ),
          firstChild,
        ],
      ),
      secondChild: Stack(
        fit: StackFit.passthrough,
        children: [
          Positioned.fill(
            child: AbsorbPointer(),
          ),
          secondChild,
        ],
      ),
      duration: Duration(milliseconds: 100),
    );
  }
}

Could everyone who still has this problem please file a new issue with the exact description of what happens, logs and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.

Potential example of a case on Dartpad:
https://dartpad.dev/f6c90b5ed18d17a58e2d5a8eedac1cc6.
If I click on the invisible area, it clicks on the button that is not being displayed.
I feel like it should not be possible to click on the second button if we are on CrossFadeFade.showFirst.

An easy fix is:
firstChild: IgnorePointer(ignoring: crossFade == CrossFadeState.showSecond, child: firstChild)

An easy fix is:
firstChild: IgnorePointer(ignoring: crossFade == CrossFadeState.showSecond, child: firstChild)

I put @Jimmybee 's fix in a gist for anyone wanting to simply copy/paste


Fix CNI URL for CoreOS/Flatcar

What this PR does / why we need it:
This PR fixes the CNI URL for CoreOS and Flatcar. Currently, it's impossible to provision/upgrade clusters on those platforms, as CNI URLs got changed after v0.7.5.
The approach used in this PR is that we now use CNI v0.8.6 for all Kubernetes versions on CoreOS/Flatcar. The same approach is used by machine-controller, although, it can be slightly risky because older versions (e.g. 1.15 and older releases of 1.16/1.17) are not verified by upstream with the latest CNI. Since we use this approach in MC anyways, I think it should be okay to proceed with this change.
Does this PR introduce a user-facing change?:
Fix CoreOS/Flatcar cluster provisioning/upgrading: use the correct URL for the CNI plugins

/assign @kron4eg

@kron4eg PTAL again

/retest

/retest

/retest

/retest


remove removal of dist/ folder during yarn pack

Thie PR ensures that the dist folder is included in the package that is uplaoded to npm.

LGTM


Provide support for using governance repos

Provide support for using governance repos instead of only having GOVERNANCE files.
For example; https://github.com/kedacore/governance is where KEDA's governance is at.

second that! For example Harbor and Contour we have separate repos for community and we keep GOVERNANCE there!

@tegioz is the same valid for code of conduct ?

I've opened PR for that will update you once I have it merged :)

Yes, that works too for code of conduct 👍

Hi @OrlinVasilev
I've seen the PR you referenced has been merged. At the moment the patterns we detect to pass certain checks must be in the headers of the markdown file. Something like this should work:
## Governance

Find GOVERNANCE in our [Community repo](https://github.com/projectcontour/community)

I'll close this issue for now as we are addressing it with the headers check. Please don't hesitate pinging me if you run into any issue.


[TA2256] Changing ISTGT logging from syslog to fprintf

Changes :

Changing ISTGT logging from syslog to fprintf (stderr)
Changing rebuild wait time for the newly added replica to 2 times of replica_timeout
Fixing deadlock in update_replica_entry

Signed-off-by: mayank<EMAIL_ADDRESS>

I am closing this PR since changes from this PR has been merged in PR #66.

Changes in this are taken care in another PR. Hence, closing this.


Test failed on CentOS

For the latest code, successfully built both on MacOS & CentOS but some tests(Test #29 ~ #32) failed on CentOS. With the first failure logs as following:
29/32 Testing: nodeos_run_test
29/32 Test: nodeos_run_test
Command: "/home/imt/eos/build/tests/nodeos_run_test.py" "-v" "--dump-error-detail"
Directory: /home/imt/eos/build
"nodeos_run_test" start time: May 28 13:34 CST
Output:
----------------------------------------------------------
terminate called after throwing an instance of 'fc::eof_exception'
launching bios
spawning child, programs/nodeos/nodeos --max-transaction-time 5000 --filter-on *  --config-dir etc/eosio/node_bios --data-dir var/lib/node_bios
launching testnet_00
spawning child, programs/nodeos/nodeos --max-transaction-time 5000 --filter-on *  --config-dir etc/eosio/node_00 --data-dir var/lib/node_00
**********************************************************************
run 'bash bios_boot.sh' to kick off delegated block production
**********************************************************************
"/home/imt/eos/build/programs/keosd/keosd" launched
Failed to connect to nodeos at http://localhost:8888; is nodeos running?
 Validate every cluster node has block 1.
         cmd: programs/cleos/cleos --url http://localhost:8888  --wallet-url http://localhost:8899 get info
          ERROR: Expected JSON response
          RAW >
Test failed.
  =================================================================
  Contents of etc/eosio/node_bios/config.ini:
genesis-json = ./genesis.json
blocks-dir = blocks
readonly = 0
send-whole-blocks = true
http-server-address = '
p2p-listen-endpoint = <IP_ADDRESS>:9776
p2p-server-address = localhost:9776
enable-stale-production = true
allowed-connection = any
required-participation = 33
private-key = ["EOS6MRyAjQq8ud7hVNYcfnVPJqcVpscN5So8BhtHuGYqET5GDW5CV","5KQwrPbwdL6PhXujxW37FSSQZ1JiwsST4cqQzDeyXtP79zkvFD3"]
producer-name = eosio
plugin = eosio::producer_plugin
plugin = eosio::net_plugin
plugin = eosio::chain_api_plugin
plugin = eosio::history_api_plugin

It seems that cleos cannot connect to http://localhost:8888 with http-server-address configured to <IP_ADDRESS>:8788. Maybe use <IP_ADDRESS>:8888 instead of <IP_ADDRESS>:8888 can fix this.

@pplam Im unable to reproduce this error (see below). It might be a good idea to remove your build directory and start over.
cd /path/to/eos
rm -rf build/
git pull
git submodule update --init --recursive
./eosio_build.sh
cd /path/to/eos/build
source /opt/rh/python33/enable
make test
result from running make test
32/32 Test #32: distributed-transactions-remote-test ...   Passed   67.42 sec
100% tests passed, 0 tests failed out of 32
Total Test time (real) = 1002.79 sec
Beginning build version: 1.2
Mon May 28 17:30:46 UTC 2018
User: bhamilton
git head id: 07a6798584d053ed6061bd892879c6c886ba104e
Current branch: master

ARCHITECTURE: Linux

OS name: CentOS Linux
OS Version: 7
CPU speed: 2399Mhz
CPU cores: 2
Physical Memory: 7821 Mgb
Disk install: /dev/xvda1
Disk space total: 511G
Disk space available: 506G

@pacificcode Thanks for your explanation! I've tried again and figured out that there is some problems with my /etc/hosts. After I point <IP_ADDRESS> to localhost, it works. But here comes another failure:
97% tests passed, 1 tests failed out of 32

Total Test time (real) = 614.86 sec

The following tests FAILED:
         27 - .(SEGFAULT)
Errors while running CTest
make: *** [test] Error 8

Could you please show me how can i just perform the test on the failed unit_test_wavm , by this way the maybe i can make the problem clear faster.

@pplam pull the latest code from master and you should be good to go.


Force x-number of digits for instance field

Is it possible, or could it be made so, to force double/triple digits for instance numbers?  For example I want 01, 001, vs. 1.

I placed this in wrong issues board.


feat: adds dynamic mask to cvc element

Description

feat: adds dynamic mask to cvc element
test: add jest config
feat: adds card field validation via card-validator

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.0.0-beta.9 :tada:
The release is available on:

npm package (@master dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Proposal to Draft a Privacy Policy and About Us page for Steembot

Greetings,
I am a copywriter, and have contributed to many App and Platforms using my writing skills.
A privacy policy is a document that states an App/site potential collection/use of visitors /users data.
About us normally found on the landing page gives a brief description of the App.
I am willing to contribute to the development and stability of your platform through documentation some of which will provide you with legal indemnity.
Your response is anticipated.
Thank you.
@pope1995 on steemit
@pope1995#6757 on discord

This is a JS package not a app or website. You better do more research about your potential customers if you want to stay in the business.


Search not respecting search.exclude

When I use global search it's not respecting my workspace settings.exclude. I have a notes folder in my workspace with a bunch of txt files. In my workspace I have "search.exclude": { "**/*.txt": true }. However, when I have an editor open with one of those text files it shows up in search results. It looks like search now considers all open editors but doesn't apply my explicit settings when doing so.
I think this behavior changed at some point, because I don't recall this being an issue before.

/duplicate of #31819 so apparently it's behaved this way for a long time.

I'm experiencing exactly the same issue. It happened after the latest VS Code for Mac update 1.44.0. Working fine in the previous version.


notify/pagerduty: fix images

Closes #1784
For clarity, I've chosen to rename the field text to href in the configuration though it could break people (but I suspect that it isn't widely used).
Unfortunately I don't have a way to validate it. Maybe @seanhoughton, @sbueringer, @mikebryant or @adamdecaf could help (I've looked at the Git history for people that contributed to the PagerDuty code).

I've verified this change using https://v2.developer.pagerduty.com/docs/send-an-event-events-api-v2, and successfully created an image link in a real alert using:
    "images": [
        {
            "src": "https://vignette.wikia.nocookie.net/reddwarf/images/5/54/Flibble.jpg/revision/latest?cb=20070516034130",
            "href": "https://google.com"
        }
    ],

Thanks a lot @mikebryant


Unable to view custom Json payload for webhook while creating webhook action for log alert rules

This is the custom json payload, which I am supplying
{"text":"Test Pagerduty message"
}

but this text is not visible anywhere in the pagerduty log entry.
Please suggest the proper way to view the custom json payload

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b1390bec-bae0-2fe7-a29c-a242584fd7b3
Version Independent ID: 27892ee4-2ec3-ea70-f747-80a9bc914fd7
Content: Webhook actions for log alerts in Azure alerts - Azure Monitor
Content Source: articles/azure-monitor/platform/alerts-log-webhook.md
Service: azure-monitor
Sub-service: alerts
GitHub Login: @yanivlavi
Microsoft Alias: yalavi

@ankur021188 Can you please open a support case for us to work with you on resolving this?
Without more details, I can say it maybe because you have enabled common schema that reverts any custom email subject/JSON.

@yanivlavi Thanks for your insights and suggestion!
@ankur021188 Please open a support case as suggested by @yanivlavi. I will be closing this issue for now but if there are further questions regarding this matter or feedback on the referred documentation, please do let us know and we will gladly continue the discussion.


korean localisation

Same comment as for #14685

Keep the existing Date format style
Move the added translation to before the line resetting 'cpo'
Change the commit author

Thanks!

@chrisbra


primitive type added a dot

Nice work.
I found a little error in you code.
You are missing a check for if prefix is not defined in line 21 like you do all the other places in the code. This error causes a dot to be added to the beginning of a property name of a primitive type when no prefix is supplied.
The line should look like this:
newobj[(p ? p + "." : "") + f] = o[f]; // primitive

thanks for pointing out.
Fixed with commit:
https://github.com/vardars/dotize/commit/43107d9ce0ee10c7c04861bad8170b112b33b2e2#diff-4334a19297191c33e13362a0aa124ee7


Can't access SkyBridge in Mammoth

After entering credentials to log in to SkyBridge using Mammoth, I get this error screen:

I have the same problem

same issue here

After ac47bf9 and e5eb7c0 Mammoth now renders bluesky feeds and profiles.


PROPOSAL / API change: proper node UUID's instead of using bindHttp as node identifier

As part of the cbft integration project with Couchbase Server (ns-server), I had a discussion with @aartamonau on node identities, and he strongly recommended and counseled that cbgt should instead use proper, opaque identifiers for node identity.
In contrast, today, cbgt overloads the the "bindHttp" command-line flag value for two uses: for node identity and for network addressing.
The current bindHttp approach has ugliness with node IP address changes (e.g., DHCP with worker moving from home to cafe to work).  And, there were plenty of battle stories from ns-server which uses non-UUID, non-unique identifiers, such as around upgrades; and battle stories around failover'ed or removed nodes that are re-added back into the cluster; and battle stories around nodes of the wrong version re-entering a cluster.  In those battle stories, the non-unique node identifiers (like<EMAIL_ADDRESS>wasn't strong enough for the system to detect issues on these edge cases.
cbgt nodes currently do have a Manager UUID, but that isn't used regularly throughout cbgt as a straight identity value all the time...

https://github.com/couchbaselabs/cbgt/blob/master/defs.go#L112
https://github.com/couchbaselabs/cbgt/blob/master/manager.go#L136

The proposal is to embrace the NodeDef / Manager UUID as the node's true identifier, and introduce some new mapping or lookup-table (in the Cfg) that allows one to find the network-address(es) of a node from its UUID.
Some other impact, changes, and non-changes...

Cfg contents would change, in an incompatible way, where the nodeDefs mapping would be changed to be keyed by UUID instead of bindHttp.

https://github.com/couchbaselabs/cbgt/blob/master/defs.go#L105

a new node UUID -> networkAddress(es) lookup mapping would be also stored in the Cfg

The cbft IndexAlias / RemoteClient codepaths would have to use this UUID -> networkAddress(es) lookup mapping as they scatter/gather queries across nodes.

https://github.com/couchbaselabs/cbft/blob/master/pindex_bleve.go#L831

the cbgt UI would change on its "Nodes" screen.

command-line parameters (-bindHttp) would not likely have to change.

cbgt's Manager API would likely also not have to change.
but, cbgt's CfgGetNodeDefs() API and NodeDefs json struct API's would change in an incompatible, breaking way.

When implementing the stats code, I have code that walks those node defs to extract node specific information.  It sounds like this change is going to make my life harder...

command-line parameters (-bindHttp) would not likely have to change.

Wouldn't that command line parameter be removed with this change?

Why would it be removed, shouldn't it still serve its original purpose, let you control what interface(s) the server binds to?

Oh, I forgot about that other purpose.  Per @steveyen's comment:

If you don't use the REST facilities (which actually listen on that bindHttp / see http://godoc.org/github.com/couchbaselabs/cbgt/rest#InitRESTRouter), then I guess bindHttp doesn't need to be actually "routable" and only needs to be unique for each node (so, it might work for bindHttp to be completely artificial).

We are not yet using the REST facilities in Sync Gateway, so we are just making sure bindHttp is unique per-node.  Eg, I've been using "sg1" and "sg2" in my testing.
If and when we do add the CBGT REST facilities, we'd probably just add a new endpoint to our existing router, and reuse the bind interface/port that is already specified in the Sync Gateway config -- that config defaults to <IP_ADDRESS>:4985, so it's probably not useful as a unique identifier for a node.

Oh good point.  Since cbgt is a library, should it even be doing HTTP itself?  Wouldn't it make more sense that it either provide(and or register) handlers, but let the application take responsibility for setting that up (if appropriate)?

Oh good point. Since cbgt is a library, should it even be doing HTTP itself?

Hi Marty,
Some quick notes on the two sides of HTTP, client & server, and cbgt...
On the client-side, currently, cbgt doesn't know how to be an HTTP/REST client.  For example, for cbft (couchbase full text server), all the HTTP/REST client stuff lives in cbft instead of cbgt.
In the future, though, I've been wondering if there might be future approaches to pull the HTTP/REST stuff down a level and make it reusable across different PIndex implementations.  No brilliant a-ha moments on that yet, though, except that it might be more worthwhile if we ever get around back to next-gen "greenstack" networking proposals

Wouldn't it make more sense that it either provide(and or register) handlers, but let the application take responsibility for setting that up (if appropriate)?

On the server-side, yeah, it's kinda like you're describing.  From the bottom's up...
cbgt - there's the core cbgt library that doesn't have any REST/HTTP stuff at all, but only has the generic Cfg stuff and generic manager/planner/janitor stuff.
cbgt/rest - then there's a higher-level library, cbgt/rest, that apps can optionally use to have some pre-built REST/HTTP handlers, or if app writers just want to pass in a gorilla.mux.Router that cbgt/rest can populate with all the handlers & routes, that's available too.  See...
http://godoc.org/github.com/couchbaselabs/cbgt/rest
http://godoc.org/github.com/couchbaselabs/cbgt/rest#InitRESTRouter
The cbgt/rest library also has web admin UI static resources that apps can optionally use.  That is, the framework of all the angularJS lives under cbgt/rest/static, where it's conveniently (?) bundled up for optional app usage via a bindata_assetfs.go approach.
Lastly...
cbgt/cmd - then there's another higher-level library, cbgt/cmd, that can apps can optionally use to get some help with with cmd-line flags parsing and initialization.
So, a little bit of a'la carte, where the carte is a bit underdocumented.

OK, I'm confused, so I'll just leave it to you two to figure out.

The changes on this have been pushed to cbgt...
commit 4bddecfd
And these are some related web admin UI changes to cbgt...
commit 09ee7707
commit b53b2c7
commit 430baef1
Interestingly, looks like there were no changes needed to cbft or to cbmirror.
Sync-gateway, however, might need changes if it accesses the NodeDefs data structure (e.g., if the app invokes the cbgt.CfgGetNodeDefs() API or similar).
In particular, the key of the NodeDefs map[string]*NodeDef has changed from a hostPort string to a UUID string.  The compiler, of course, thinks its just strings either way, so beware that the compiler doesn't save us on this kind of breaking change!

Hi Steve,
I'm reviewing the impact to the stats for ns_server and would like you to take a look as well.
We get the NodeDefs here: https://github.com/couchbaselabs/cbft/blob/master/ns_server.go#L307
pass them to a function call HostsForIndex here: https://github.com/couchbaselabs/cbft/blob/master/ns_server.go#L347
Then in this function we do the following: https://github.com/couchbaselabs/cbft/blob/master/ns_server.go#L266-L295

collect node UUIDs participating in the index (from planPIndexes not NodeDefs)
walk the nodeDefs, looking at values, ignoring keys, if the nodeUUID is one of the ones we collected in step 1, then remember its nodeExtras value, keyed by the UUID, but again thats just for uniqueness in the map, we don't care what that is.
flatten the map of nodeExtras we built into a slice of strings and sort it

It seems to me like all of this should still work, because the host/port info we share comes out of nodeExtras and not out of the nodes UUID or bind info.
So, based on that I think its worth me giving it a try...
BUT, I have a new concern.  The value I'm passing into nodeExtras at cbft startup is supposed to match the identifier for the node by ns_server.  So, I'm wondering, based on this talk about ns_server having some late binding, and changing the name, that this may in fact be broken.  Is there any documentation where I can read more about ns_server changing identification of a node?  I had to add this code once I ran a cluster because it seems like one node continues to identify itself as <IP_ADDRESS> and the other gets renamed to 192.x.x.x.

On docs on the ip address rename, the proposed design got simpler due to using proper node UUID's...
https://github.com/couchbaselabs/cbft/blob/master/DESIGN.md#handling-ip-address-changes
Of note, I don't think we've yet built what's proposed, where where ns-server restarts cbft with the proper bindHttp value.
On the ns-server side, there's some documentation on the node joining sequence (where IP address changes are a mention-in-passing part of that), so really this pointer is about pointers to further places in the code...
https://github.com/couchbase/ns_server/blob/master/doc/cluster-add-sequence.txt

Also, my reading of the nsstats code was the same as yours.  That is, I was pleasantly surprised with the takeaway that "Hmmm, I don't think this code needs changing at all for this node UUID code change to work"

Ah OK, let me try again.  My new concern is not with cbft's handling of the name change.  My concern is that I'm passing some data into CBFT on startup.  But what if ns_server decides to change the name after that point, and now the "name" I passed into cbft has become stale.

Interesting... Here's my takeaway notes after a look...

That extra name gets passed to cbft through the cmd-line, via the -extras JSON.

Then saved into the Cfg.

Then, later, the nssstats code reads the Cfg.

And, nsstats uses a uuid-based match to get the extras JSON.

So, my reading of the code makes me think it should just work (although I can see an optimization at step 4 on perhaps using a straight hash lookup instead of a loop).
I'm thinking that even if ns-server restarts cbft with a changed -extras cmd-line flag parameter (per the DESIGN.md proposal on ip-address changes) and goes through the 1-2-3-4 steps again, it'll be fine.
EXCEPT, at step 2.5, what pops to mind is if the Cfg doesn't get updated or loses its mind (or is eventually consistent instead of consistent), the the wrong extras will come out.
Well, I'd agree that can happen.  But, I'm also thinking that could have happened before in the previous "pre-node-UUID" world, and we just need to wait for metakv / Cfg to converge.

OK, I think where I'm not confident is that you say "even if ns-server restarts cbft with a changed -extras cmd-line flag parameter"...
What reason do we have to think it would do that?  My fear is that it changes the name, and doesn't restart cbft, and we wrongly operate with the old value.

Also, I agree this isn't a new problem introduced by this change.  It was always a problem, but new information about nodes changing names surfaced in the discussion.

》OK, I think where I'm not confident is that you say "even if ns-server restarts cbft with a changed -extras cmd-line flag parameter"...
》 What reason do we have to think it would do that?
No reason - afaik, ns-server doesn't restart cbft on node name changes... yet.  It's future, to-do engineering work...

Of note, I don't think we've yet built what's proposed, where where ns-server restarts cbft with the proper bindHttp value.

...which is why I'm often pleasantly surprised when I hear that clustering "works".  (Or, based on this morning's email threads, I hear it no longer works.)  The only way I figure it could have "worked" was under a cluster-run scenario where everything (including clients / browser) are running under <IP_ADDRESS>, same machine.  But, at this stage, if you tried to do this across multiple real machines, without handling the (now obsoleted) proposed, convoluted ipaddress renaming or (now implemented) node-UUID or (not yet implemented) cbft restarts, it'd be a "huh, no way that should work yet" mystery.

Hmmn, I guess I don't understand everything thats involved.  I would expect it to just work.  Right now neither cbft node even sees any other nodes registered in its config.


I have a request，thank you.

I am very interested in your excellent work. Can you give an introduction to the function of each file？thank you.
对您优秀的工作十分感兴趣，请问，可以给一个每个文件大概做了什么（也就是每个文件的作用）的介绍（说明）吗？十分感谢。

Hello. Thank you for being interested in our work. Our implementation is based on Detectron2. Thus you may need to read its code first.


Add sample code to documentation

The current documentation may need some sample code to get started. The sample code from the old documentation is nice, but unsurprisingly it's now broken.

Just a note: there are a couple of demos in the new repo as well: https://github.com/rhempel/ev3dev-lang-python/tree/master/demo

Just a note: there are a couple of demos in the new repo as well: https://github.com/rhempel/ev3dev-lang-python/tree/master/demo

Another note to @rhempel: the sample code from the old repo was copied from README. Same thing will happen if you update the README here. Fell free to reuse my old one.

Another note to @rhempel: the sample code from the old repo was copied from README. Same thing will happen if you update the README here. Fell free to reuse my old one.

This may be a duplicate of #47.

This may be a duplicate of #47.

It is a duplicate of #47. But I'd appreciate separate review anyways.
Please review a43897fe0d380a6449b4dcd1c691be551056b3dd to see if this fixes the issue. I have added links to "Demo Robot" and "Demo Code" in the docs - this will be part of ReadTheDocs as well after the next release.
The resulting GitHub README.rst page is here

I've noticed that the current documentation is the one generated from the docstrings. That's good, though a sweet introduction presenting the separate features of the API would probably be easier to digest. I'm thinking of maybe a thinking-aloud walk through of the demo modules I propose.
The wording could be generic enough so that those chapters of the docs will rarely have to be touched. As soon as the demos exist how to write those chapters may become more obvious. The indeed nice Example Code section of the README could then be replaced by a link to the documentation.

Well, this is a bit of a problem (or an opportunity if you're inclined that way) - I agree that a nice tutorial would be a good thing. We do, however, plan to add bindings for at least Lua and Ruby (and maybe Lisp) in the future.
Where I am going with this is that I'd hate to write an API tutorial for Python and have to do the same thing all over again for each language.
I think we are talking about is more of a "How to Program a Robot Using the ev3dev Device API in ANY Language" type of text ...

We do, however, plan to add bindings for at least Lua and Ruby (and maybe Lisp) in the future.

Don't forget the other ones that already exist but haven't been integrated -- we have PRs/issues open for C# and Java! And we had a conversation yesterday with someone working on Go.

That's cool, and I agree.
We just need to make sure that failure doesn't start with the very first import statement:
import ev3dev.ev3 as ev3

# or, alternatively
from ev3dev.ev3 import *

... is not totally obvious, and not the standard way of using a module. I've seen the need for it though, looking at the auto module. The "obvious way", I feel, would be that
from ev3dev import *

would do just the same as the alternative import example above. (Relates to #105)
Either this way, or if in all other languages importing does require the very same "non-standard" procedure an abstract tutorial for all languages will of course do it.

Believe me, we went around in circles for the best way to do this given all of the different hardware to support. The examples make it clear how to do the first import - let's stick with it for now and move on :-)

Would you accept a PR that moves the Example Code section of the README into a set of demo modules, and refactor the demo directory structure as described above?

Sure, I'm happy to review such a PR - I think what you are saying is that the DemoCode from the current README goes to a separate document.
Recall that the README gets used in two places - as the descriptive header in the REPO, and in the more complete docs in ReadTheDocs.
Ideally, I'd like to see the API set up with general text - as each language binding must provide the text and we can describe the operation of the file based attributes very well. Then autogen the code examples and language specific tips and tricks separately.
But let's see what you are proposing - either way the effort won't go to waste because we can pull out the text to be re-used if we ever refactor the docs.


Changed docs to reflect resolve / reject behaviour

Uh, you shouldn't have removed that "This method also supports predicate-based filters. …" paragraph - it is still essential to the catch documentation! If at all, the request example should've been exchanged for some other library, but still demonstrating the same feature of catch!

The PR should only change request to throw on non-successful statuses similar to what jQuery.ajax does. There is no need to change any actual documentation.

ping @chainlink

The PR should only change request to throw on non-successful statuses similar to what jQuery.ajax does. There is no need to change any actual documentation.
So, should I modify the library itself to reject the promise on non-successful statuses?

No, you changed both the example and the documentation but only the example needs to be changed

closing 2.0 pr, please retarget to 2.x branch if still applicable


File saves are not tracked/auto-recompile does not work on windows 10

setting program to run in compat mode does not help
running as admin does not help

Win10 build 9926

The same here, it only works if I move my files on C particion, any ideea?


fix ci process

Since https://github.com/ysugimoto/falco/pull/66 has been merged, CI process seems to break.
This PR fixes them to deploy properly.

I'll quickly merge this PR to release new version.


added my name to the names.txt file

I added my name to a list of names in the names.txt file located in this repository after forking it into mine like it was instructed.

Please I am sorry for all the trouble we have caused you but count it all joy. Your PR is about to be merged and you will be able to see your name on this url.
To enable me to do this, READ the README again carefully, update your code with the latest and push the update. I am here for you for the next 6 hours before I close the PR so you can initiate a fresh PR which will be easier to merge.

Please I am sorry for all the trouble we have caused you but count it all joy. Your PR is about to be merged and you will be able to see your name on this url.
To enable me to do this, READ the README again carefully, update your code with the latest and push the update. I am here for you for the next 6 hours before I close the PR so you can initiate a fresh PR which will be easier to merge.


Screens/details: authors, title, and series are not printed across multiple lines

Same issue as with #86. Space is dedicated, but only the first line is printed.

Opened in error, #86 had yet to be merged into local working branch.


[action] get_version_number: Supports when INFOPLIST_FILE is specified as an absolute path

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

When INFOPLIST_FILE is specified as an absolute path, get_version_number doesn't work.

Projects made with xcodegen are often set as absolute path.

Description

In resolved_build_setting, return plist_files using the resolve_against_xcconfig option.
plist_file can be Relative or Absolute path.
Make to Absolute path when plist_file is Relative path.

Testing Steps

Create iOS-Single-View-App on Xcode.
Replace INFOPLIST_FILE to an absolute path on Project.xcodeproj/project.pbxproj.
Run bundle exec fastlane get_version_number and make sure it's correct version.

@googlebot I signed it!

Wow, awesome that you added so many tests.


Restarting Kafka causes consumer offset errors

Environment

Node version: v8.11.1
Kafka-node version: 4.0.1
Kafka version: 2.11-<IP_ADDRESS>

For specific cases also provide

Number of Brokers: 1
Number partitions for topic: 1

The problem
If kafka restarts while the consumer is working, and the consumer doesn't fail, it has very a weird behavior that looks like a bug. This is the flow that I get:
before crash

several messages were sent. latest message received before crash has offset 17, highWaterOffset 18 (according to consumer)
kafka-consumer-groups --describe:
current offset = 5 (this was the offset when consumer started)
log-end-offset = 18
lag = 13

kafka closes

consumer prints errors, including

NestedError: refreshBrokerMetadata failed
NestedError: topic/partition change check failed

kafka starts

consumer reads all messages from the start (meaning, the 13 messages that were sent after it started)
this time, the offset of the first message is 22, highwateroffset is still 18.
consumer prints the following log every few milliseconds until stopped:
replacing ExampleTopic14-0 stale offset of 35 with 0 +113ms
later messages append the offset

Complete debug logs
the reason this is a problem for me, is that if I commit the offset (which in this example I didn't for simplicity) than the consumer tells Kafka that it's offset is > the log-end-offset, which means it has a negative lag and this is a whole mess. (details below)
consumer code
const topicsList = [consts.topicName];
const consumerOptions = {
  kafkaHost,
  groupId: consts.consumerGroupName,
  topicsList,
  sessionTimeout: 30000,
  protocol: ['roundrobin'],
  fromOffset: 'latest',
  autoCommit: false,
};

const consumer = new kafka.ConsumerGroup(consumerOptions, topicsList);

consumer.on('message', message => {
  console.log(`received ${JSON.stringify(message)}`);
});

consumer.on('error', e => {
  console.error('Got error in consumer!');
  console.error(e);
});

What happens when I do commit the offset
the difference in the code:
autoCommit: true

in a nutshell:
last message before crash:
kafka: current-offset: 10, log-end-offset: 10, lag: 0
consumer: offset: 9, highwater: 10
after crash:
consumer didn't re-read messages (as expected)
next message: offset: 20, highwater: 11
kafka: current: 21, log-end: 11, lag: -10
debug logs:
 kafka-node:ConsumerGroup replacing ExampleTopic19-0 stale offset of 21 with 0 +7s times infinity
when another message is received:
consumer reads both new message and previous one, kafka lag grows by 1.
full logs

Can you test with the latest 4.1.3? There have been fixes dealing with offsets and compressed topics/messages.

I have an issue with this too. When I pause and resume the consumer stream it goes out of sync.


Nested blockquotes are not rendered properly

Hi,
I recently switched to marked.js for one of my projects. There are a lot of nested quotes which unfortunately are not rendered properly by marked.js.
Input:
>> Nested 2nd level Quote with some text
>> in here over multiple lines.
> now following first-level quote which is
> a reply to the second level quote
> but is rendered as second level.

Output:

All Content regardless of their nesting described after line 1 appears in here.

Any chance you can fix this soon or does someone know how to achieve the correct result here?

See #956
Closing as stale


Upgrade to JHipster 7

[x] Upgrade to JHipster 7
[x] remove UAA
[x] remove setupXXVersion
[x] Add new lifecycle methods
[ ] update Vue health check https://github.com/jhipster/generator-jhipster-quarkus/issues/98
[x] Use composing function in the app generator instead of defining the composed subgen in the configuring() method https://github.com/jhipster/generator-jhipster/blob/main/generators/app/index.js#L387
[ ] Use composing function in the entity generator instead of defining the composed subgen in the configuring() method
[x] Fix the todo here https://github.com/jhipster/generator-jhipster-quarkus/blob/main/generators/entity-server/index.js#L68
[ ] The CI is green

Anything I can do to help with this? I'd like to create a screencast of this post. However, I think it'd be nice to update it for Quarkus 2.0 first. Are there plans to release a new version of this blueprint with Quarkus 2.0 support in the next week or two?

Hi Matt,
I'm working on it but I'm struggling a bit with the entity subgen. I think every other things are working.
The entity subgen is quite complexe to migrate due to several changes in JHipster. If you want you can contribute on this part.
There is also the vue part to modify but it's a minor change.
We plan to release a new version (a beta has been released with Quarkus 2 and SQL DB) including JHipster and the whole support of Quarkus 2 (redis, mongo...). Not sure it will be done in one or two weeks.

I added a bug bounty that might help. @mshima was a big help in migrating the Ionic module to JHipster 7. https://github.com/oktadev/generator-jhipster-ionic/pull/482

As far as I know the main problem could be resolved by checking how the context is loaded inside the BP and ensure the composing part is made as expected.

@avdev4j Can you fix the conflicts please?

fixed @mraible

Any chance you can help with this upgrade, @mshima? If not, I can take a look next week.

I will take a look.

I don't have permission to push to this branch, created https://github.com/jhipster/generator-jhipster-quarkus/pull/223.

@avdev4j can we split in half? $250 each?

I'm sorry @mshima I totally forgot to answer you, yes let's go for it! 250 each

Claimed here https://opencollective.com/generator-jhipster/expenses/55564

@avdev4j : approved
Waiting yours, @mshima

@pascalgrimaud half bounty claimed https://opencollective.com/generator-jhipster/expenses/59119.

@mshima : approved

Thanks @pascalgrimaud


Perspective transformation

Hi,
I wonder if you plan to add perspective transformation support (that is to support all 9 elements of the 3x3 matrix).
Some embedded GPUs support it, and it'd be amazing if we could use the same effects with software rendering too.

@kisvegabor Hi, theoretically, perspective transform is an application-level concept, not a GPU-driven. Could you please suggest the APIs (or prototypes) you expect to use? We can start the discussion from there.

@kisvegabor I guess that tool itself could export the data after applying the own perspective transformation. Otherwise we might want sort of spec to align the perspective transform & camera(view transform)

I guess that tool itself could export the data after applying the own perspective transformation.

I can't see such a button, but @w-mai know it better. :slightly_smiling_face:

Otherwise we might want sort of spec to align the perspective transform & camera(view transform)

I'll start working more with vectors soon, so I hopefully I can comment something useful on this too :slightly_smiling_face:


border related style not working

For Icon component, border related styles not working, e.g. borderRadius, borderColor, borderWidth

This is a limitation in the React Native core Text component. You need to either use Icon.Button or wrap your icon in a View.

What about correcting Styling section of readme then? It's containing wrong description about border abilities.

@farwayer & @fuxiocteract: They work on iOS but not android, I've updated the README with this.

Nice!


Add security bundle

Towards https://github.com/giantswarm/roadmap/issues/2970
Adds security bundle for 1.25 upgrades.

/run cluster-test-suites

/run cluster-test-suites


Suggestion: enable multi-choice filter

(Original issue 30 created by altmany on 2012-10-03T23:18:07+00:00)
At the moment (4.4.0), the filter choices use a simple ComboBox that enables selection
of only a single filter choice.

I would like to suggest implementing a multi-selection filter using checkboxes in the
combo's popup panel, that would enable users to select multiple choices for filtering
(like Excel 2010).

Perhaps it could be a sub-class of ChoiceRenderer, or perhaps even better - a settable
boolean property (default=false=single-selection behavior, just like the current implementation,
for full backward compatibility):

   public boolean isMultiSelectionAllowed()
   public void setMultiSelectionAllowed(boolean)

(please accept my apologies if this is already implemented somewhere and I failed to
notice)

Original issue reported on code.google.com by altmany on 2012-10-03 23:18:07

(Original comment by coderazzi on 2012-10-04T00:43:05+00:00)
Hey, that is a very good idea.

Implementation-wise, it does not fit very well with the current model, so I guess I
will need some long time to get through it...

Thanks for the suggestion!

Original issue reported on code.google.com by coderazzi on 2012-10-04 00:43:05

(Original comment by None on 2015-01-19T16:38:34+00:00)
I think this is old, but… are you still working on this project?

I would be really insterested in multi-choice filter, like in https://github.com/eugener/oxbow

However, your UI is much more refined and usable, especially the way it shows within
the table.

The mentionned project provides a CheckedList that could be used to draw checkboxes
within the list. However, the code needs to be adapted since it is displayed in a popup
that will be dismissed on each click.

I already worked on a JMultiComboBox, but the logic is directly plugged in as a JComboBox
inherited classes, so it would be a lot of work to adapt it to a single PopupMenu.

Original issue reported on code.google.com by ZeGlandos on 2015-01-19 16:38:34

(Original comment by coderazzi on 2015-01-19T22:25:51+00:00)
Hi, I'd like to consider this project as alive, but low demanding :-) I am covering
any bugs that impact the functionality, and I definitely use the tablefilter on my
projects, but I am quite reluctant to include new functionality.

The impact of this multiselection filter is rather large: it only affects the GUI,
indeed, but impacts all the core GUI components, including key navigation, basic user
interaction, etc. Honestly, I lack now the time to do it properly and cover all possible
regressions.

But if you feel like coding it yourself, I could definitely assist / support you.

 Lu/

Original issue reported on code.google.com by coderazzi on 2015-01-19 22:25:51

(Original comment by None on 2015-01-20T15:20:41+00:00)
Indeed.

I've started to hack it, and after successfully drawing a checkbox in the list. This
is kind of an easy part, except that I had to understand the whole code for that (in
FilterListCellRenderer).

But then, I realized that the logic of a single selected element is everywhere in PopupComponent.
The MouseHandler should be the entry point to the currently clicked element, but the
rest of the code assumes that there is only one selected element: the renderer (not
so bad), the choiceSelected method (we could create a Proxy object?), and some other.
But it implies to hack the logic. A better way should be to use multi-selection list
everywhere, even when there is only one…

Anyway, there is a lot of work, I don't know if I'll have time for this…

Original issue reported on code.google.com by ZeGlandos on 2015-01-20 15:20:41

(Original comment by coderazzi on 2015-01-21T00:05:43+00:00)
Well, indeed the PopupComponent assumes a single selection, but extending its interface
to support multiple choices shouldn't be the problem; the FilterListCellRenderer can
be extended to support checkboxes, and overall there is probably more work to ensure
than no bugs are included in the system than implementing the new functionality itself.

However, the whole interface (API and GUI) requires major thinking. For example:

-What is shown on the editor when multiple choices are selected? Currently, we just
show the selected one, so it is not a problem at all.

-API: we have currently a setContent method to define the choice. It is enough to just
pass a collection to this method?

The filtering itself already implements OR logic. In fact, in the very first versions
of tablefilter, the user could enter complex boolean expressions on the filters, such
as choice 1 OR choice 2 AND choice 3....

In any case, I would definitely not hack the solution. As you say, using multi-selection
as base model seems definitely the best approach.

Original issue reported on code.google.com by coderazzi on 2015-01-21 00:05:43


Feature request for tf.test.TestCase.assertNotAllClose: do not log the differences

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): MacOs
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 1.10
Python version: 3.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:
Exact command to reproduce:

Describe the problem
When running this test, it logs the failure of assertAllClose which is not necessary.
Source code / logs
import tensorflow as tf
test_case = tf.test.TestCase()
test_case.assertNotAllClose([1, 2, 3], [2, 3, 4])

The logs are (I would expect no log):
not close where =  (array([0, 1, 2]),)
not close lhs =  [1 2 3]
not close rhs =  [2 3 4]
not close dif =  [1 1 1]
not close tol =  [3.e-06 4.e-06 5.e-06]
dtype = int64, shape = (3,)

Hi, I create PR #22006 to fix the issue.

Thanks a lot @facaiy. Looks perfect ...
Will check it out once it has been merged (which seems to take a while).


Update openjdk-test.yml

Fix Jenkins container file paths. Reduce vars. Fix typos. Add more tests.

#9


.Net: [Feature Branch] Function Call Filters

Motivation and Context

Related: https://github.com/microsoft/semantic-kernel/issues/5470
This PR contains changes for new type of filter - function call filters. They work similarly to function filters, but they have more information in a context (specific to function calling, like iteration number), and more control:

The ability to cancel function call loop (inner loop) - when single request to LLM returns multiple function calls, and we want to stop further execution.
The ability to cancel request loop (outer loop) - when all function are called, the last step is always a request to LLM to generate final message. This feature allows to avoid last request to LLM and return result of last executed function instead.
The ability to skip function execution - in this case function call process will proceed to the next function in pipeline.

Usage:
public class FunctionCallFilter(ILogger logger) : IFunctionCallFilter
{
    private readonly ILogger _logger = logger;

    public async Task OnFunctionCallInvocationAsync(FunctionCallInvocationContext context, Func<FunctionCallInvocationContext, Task> next)
    {
        // Example: get function information
        var functionName = context.Function.Name;

        // Example: get function call iteration information
        this._logger.LogDebug($"Function call iteration: {context.FunctionCallIteration + 1} out of {context.FunctionCallCount}");

        // Example: get request iteration
        this._logger.LogDebug($"Request iteration: {context.RequestIteration + 1}");

        // Calling next filter in pipeline or function itself.
        // By skipping this call, next filters and function won't be invoked, and function call loop will proceed to the next function.
        await next(context);

        // Example: get function result
        var result = context.Result;

        // Example: override function result value
        context.Result = new FunctionResult(context.Result, "Result from function call filter");

        // Example: stop further function calling. but proceed with request iteration
        context.Action = FunctionCallAction.StopFunctionCallIteration;

        // Example: call remaining functions, but stop request iteration
        context.Action = FunctionCallAction.StopRequestIteration;

        // Example: stop function calling and request iterations, return immediately
        context.Action = FunctionCallAction.StopRequestIteration | FunctionCallAction.StopFunctionCallIteration;
    }
}

Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

It would be nice if you add also support for this in other connectors.

It would be nice if you add also support for this in other connectors.

@Krzysztof318 Thanks for feedback. The plan is to add this functionality to OpenAI connector first. In parallel, we are working on new function calling abstractions, and most probably all function calling logic will be extracted from connectors and moved to common place. Then, we will move filtering logic from OpenAI connector to this common place, which will be used by other connectors that support function calling. In this way, we will enable filtering for all connectors that support function calling feature.

@dmytrostruk oh okay, I totally forgot work on function calling abstraction is in progress 😶🌫


Release v0.9

Readies the master branch for the v0.9 release.

Updates the version number

Organize the changelog for release. See here for a rendered version.

@josh146 I made some further updates. You should have a final read-over before merging


Configure unit tests by using a .runsettings file - video data collector

Applies to: Configure unit tests by using a .runsettings file
Dear Docs team,
With the release of VS 2019, do we need to update the version number in VideoRecorder, Version=<IP_ADDRESS> or is that staying the same?
Example of sample .runsettings file:
      <DataCollector uri="datacollector://microsoft/VideoRecorder/1.0" assemblyQualifiedName="Microsoft.VisualStudio.TestTools.DataCollection.VideoRecorder.VideoRecorderDataCollector, Microsoft.VisualStudio.TestTools.DataCollection.VideoRecorder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" friendlyName="Screen and Voice Recorder">
        <!--Video data collector was introduced in Visual Studio 2017 version 15.5 -->
      </DataCollector>

Thanks,
--Neno

@PBoraMSFT Can you answer this one?

@NenoLoje you don't need to change the version.

OK, thanks for confirming @mayankbansal018 . Closing case.

@mayankbansal018 , is not working on VS2019 Enterprise 16.1.1.
@NenoLoje, does it work for you?
Regards.

@alvarou I haven't tried with VS 2019 yet, still running agents with VS 2017.
Did it work for you before (with VS 2017)?

@NenoLoje  , It was working on VS2017, both locally and cloud.
@mayankbansal018 have you tried the video data collector setting on VS2019 16.1.1?
Regards.

@alvarou , I don't remember if I tired on Vs2019 update 1 or not, but will look into this on Monday


Register DynamicNLPModels.jl as an official Julia Package

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/67796
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" fc359df544ec1978b23e5042ea56b424a9ee3223
git push origin v0.1.0


Document current recommendations for managing configuration in production

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2038
Originally created by @DouweM on 2020-05-15 16:32:17

@aroder asked on Slack:

I'm trying to think through devops and using meltano in production. Specifically, config values. The .env file and meltano.db are in .gitignore. Are there any recommendations or practices around deploying and around managing production config values?

I responded:

Right now, I would suggest using config objects on your plugins' definitions in meltano.yml for non-sensitive values, which I intend to make more accessible through meltano config soon: https://gitlab.com/meltano/meltano/-/issues/2013.
For sensitive values, environment variables are your best bet since many systems exist to manage them in production environments, some of which also support hiding the most sensitive ones in vaults.
I would love it if Meltano would develop into a more scalable, more mature direction on this front.

View 8 previous comments from the original issue on GitLab


Crash when unsing NavigationAgent2D with unconnected Tilemap

Godot version
4.0.beta2.official (f8745f2f7)
System information
Ubuntu 20.4
Issue description
Godot 4.0 Beta 2 crashes when using Tilemap plus NavigationAgent2D and setting a navigation target to a disconnected map region.
Steps to reproduce

Create a TileSet with a tile that has a navigation set.
Create a TileMap that has two unconnceted areas of said tile with  navigation.
Create a player with a NavigationAgent2D.
Set the navigation target (via set_target_location) to region that is not connected to the area the player is on.

Minimal reproduction project
godot_navigationagent2d_crash.zip

Fixed by #66784

@timothyqiu This is not fixed, the test project crashes for me even with recent master.

@smix8 I tested today on the current master (ca25c6e) and the MRP did not crash. I reverted #66784 locally and it crashed.
What's your crash log?

@timothyqiu
I just rebuild Godot again with master, NavMap::get_path()crashes at nav_map.cpo:168 with ERROR: Index p-Index = 5 is out of bounds (count = 1). with the test project for me.


Display Date on main entries table

"Today,  December 18th"
"Yesterday, December 17th"
"December 16th"

Check this out

Nice yeah :) and we can do details after "feed - details"

What do you mean? Explain pls.


ensure forward-compatibility with Symfony 6

This should fix tests for current dev (Symfony 5.3, where using getMasterRequest is deprecated)

@stof Can we get this update tagged? I'm working on deprecations for Symfony 5.3 and this is a big one.

@brianfreytag note that deprecations should never be a blocker. They only indicate that the current state of your application+dependencies is not able to run in Symfony 6 (which is fine, Symfony 6 will be released in November this year).

@brianfreytag note that deprecations should never be a blocker. They only indicate that the current state of your application+dependencies is not able to run in Symfony 6 (which is fine, Symfony 6 will be released in November this year).

I understand. This is just the last deprecated thing I have in my application, so it would be nice to know I'm ready to go for 6 right now lol

@brianfreytag here you are https://github.com/KnpLabs/KnpMenu/releases/tag/v3.2.0


ci(semver.yml): updated semantic-release to provide published flag and published_version

added exporting publish information to github actions output python-semantic-release

updated semver.yml using published flag and published_version

Signed-off-by: Tumay Tuzcu<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 33.636%

Files with Coverage Reduction
New Missed Lines
%

autoagora/main.py
1
0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
111

Relevant Lines:
330

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 33.333%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
111

Relevant Lines:
333

💛  - Coveralls


[IOTDB-1414]NPE occurred when call getStorageGroupNodeByPath() method using not exist path

Great catch, @neuyilan !


[Feature]: blobstore scheduler can't consume kafka msg at old kafka version V1.1.1

Contact Details
<EMAIL_ADDRESS>Is there an existing issue for this?

[X] I have searched all the existing issues

Is your feature request related to a problem? Please describe.
blobstore scheduler can't consume kafka msg at old kafka version V1.1.1
Describe the solution you'd like.
No response
Describe an alternate solution.
No response
Anything else? (Additional Context)
No response

done in #2660


Fatal error: Uncaught exception 'Sabre\Xml\LibXMLException' with message 'Extra content at the end of the document on line 42, column 1'

I tried you very basic example with my XML:
$xml = simplexml_load_file('myxml.xml');

$reader = new Sabre\Xml\Reader();
$reader->xml($xml);
print_r($reader->parse());

and got:
Fatal error: Uncaught exception 'Sabre\Xml\LibXMLException' with message 'Extra content at the end of the document on line 42, column 1'

I then tried the same very basic example using your XML and got the same error (I'm using PHP 5.4.21).

Solved by loading file like this:
$xml = file_get_contents('myxml.xml');

or better yet, use the open() method instead of xml() to load it from disk in a streaming fashing. Not sure where you got simplexml_load_file from though =)


Add build Github actions

Let's add Github actions that compile each package on PR to ensure that main is always in a pristine state.

I'll take this.

Sweeeeet @Saganic, thanks for taking this one on!! Adding some additional color:

Vercel covers us for web, and we don't actually super care about packages/core for now, so let's just start with one Github action for packages/mirrorful
It might be a little bit tricky, because packages/mirrorful has @mirrorful/core as a dependency, and ideally we read off the local @mirrorful/core instead of pulling from NPM. Might need to do try to build @mirrorful/core, yarn link, and then build packages/mirrorful if that makes sense


node image upgrade impact on running pods

This guidance explains process to upgrade the node images.
Will the node image upgrade also trigger the changes in pods that may be using old images?
for example, an AKS cluster may be running pods which are using a specific image version like mcr.microsoft.com/oss/kubernetes/metrics-scraper:vX or mcr.microsoft.com/oss/kubernetes/dashboard:vX
is there an automated way to update the image version for pods which are created as part of AKS cluster itself?
--

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8092825b-b867-d947-9842-f44eba91db00
Version Independent ID: 5b9b865c-0d51-9955-564c-1c898d3150a7
Content: Upgrade Azure Kubernetes Service (AKS) node images - Azure Kubernetes Service
Content Source: articles/aks/node-image-upgrade.md
Service: container-service
GitHub Login: @laurenhughes
Microsoft Alias: lahugh

Thanks for the question, we will take a look.

Hey @Mahesh-MSFT , when you update the AKS Deployment that would impact all the pods part of that deployment. This would cause a rolling restart as each pod comes back online. As for an automated way to update the pod images - you can use the Kubernetes API to send a new deployment to the cluster which would apply the new specifications. Here's a link to the API to give you an idea. Hope this helps!

thanks for responding @WinstonHoward-MSFT .
AFAIK, deployment manifests for system components such as  metricsserver, coredns , etc are created at the time of cluster creation.
when cluster is upgraded, these deployment manifests aren't upgraded.
even if one changes these deployment manifests manually, they are promptly rolled back to their previous version.
i am trying to understand how these system components are to be upgraded automatically?


Update Seti to support Notebook icons

Rerun update-icon-theme.js to get the latest Seti icons. Current one doesn't pick the notebook icon for ipynb (it shows as JSON) but once it's updated, it works as expected.

@aeschli can you please help take a look at this PR?

You need to first run npm run prepublishOnly in the seti repo to update the font and font character table (seti.less).
The run npm run update in the extensions/theme-seti directory.
I pushed the update.

Thanks @aeschli !


Gigantic Refactor

Fully decouples picking from both input and picking backend. Adds the ability to place event listeners on entities, and easy event-forwarding to entities on interaction.

Overall, from a system architecture perspective and as a next step I would try to remove the need for hardcoded key-codes and provide some configurable way for the user to override keybindings that does not require having to implement the same systems again. But I suspect most of the heavy lifting should be done on the bevy_input side of things to enable use cases like this.

Overall, from a system architecture perspective and as a next step I would try to remove the need for hardcoded key-codes and provide some configurable way for the user to override keybindings that does not require having to implement the same systems again. But I suspect most of the heavy lifting should be done on the bevy_input side of things to enable use cases like this.

I thought this separation was clear, but it sounds like that is not the case. I put all default inputs into separate systems so they could be easily replaced. Perhaps it would help to consolidate all inputs into a single place in the root crate?

@Weibye thank you for your feedback!

Are there plans to upstream all or parts of this to Bevy?

Yes, that is the goal!

Would it be relatively easy to extended this in the future support VR raycast interactions?

Can you expand on this? There's no reason you can't create arbitrary pointers with arbitrary backends.

What about gamepad support?

Yes, that is the intent for all inputs being removable, and one of the motivators for adding custom cursors not tied to any hardware, you can definitely control a pointer with a gamepad. I'll probably make a rebinding example that shows this.

Most if not all of crates/bevy_picking_core/src/pointer.rs seems like it make sense as a part of bevy's input-system (given that were to be improved accordingly)

Yup, that's what I'm hoping to do here. I need to make a picking backend for bevy_ui, before it's even possible though.

I thought this separation was clear, but it sounds like that is not the case. I put all default inputs into separate systems so they could be easily replaced. Perhaps it would help to consolidate all inputs into a single place in the root crate?

It could just be that my gut reaction is that "unless it is the system responsible for receiving input into the game / app, there should not be direct mentions of actual key codes", instead there should be something defining an action of what can be triggered then it is up to the input manager to bind buttons to actions.
My background here is Unity and for quite some time it was idiomatic to reference buttons directly in gameplay code. While easy it caused maintenance nightmare. Then a while a ago came the new input manager provided a separation between physical input and in-game actions which was heavenly and made everything much easier to maintain. (The actual system is poorly made and cumbersome to work with, but the concept is great)
Also, make sure the feedback makes sense to you before you act on it, I'm just a person on the internet 😃

Would it be relatively easy to extended this in the future support VR raycast interactions?

Can you expand on this? There's no reason you can't create arbitrary pointers with arbitrary backends.

I think this is the answer then :) A VR input ray, (to interact with UI panels from a distance, like a laser-pen) would simply be another pointer input

I tested out all of the examples on this branch. They behaved as expected. :tada:

I tested out all of the examples on this branch. They behaved as expected. tada

@bonsairobo any thoughts on what would make for some good examples? I'd like to add examples that demonstrate how you can make use of the high level pointer events to do complex things easily. Maybe a drag and drop example?

any thoughts on what would make for some good examples? I'd like to add examples that demonstrate how you can make use of the high level pointer events and listeners to do complex things easily. Maybe a drag and drop example?

@aevyrie Definitely drag and drop. I noticed that was missing.
Let me tell you about one time I built a UI with drag-and-drop (using Amethyst) :). I basically had a little table of square cells where each row held the timeline of actions for a character. Then you could create a plan by placing token entities (each representing a type of action) into the cells.
This was interesting as a UI because it involved drag/hover/drop events, and it also had to enforce limits on what could be placed in a cell, which required noticing a problem and then animating the token entity back into a valid spot. You could also notice when a token is being dragged over a cell, and change the highlight of the cell to indicate valid/invalid placement. I think this example would require use of the high-level pointer events, event forwarding, and listeners.

I guess I basically just described the feature set of pretty much any card game.


[DOC] change system config doc for thrift server

Why are the changes needed?
change system config doc for thrift server
Brief change log
change system config doc for thrift server
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before making a pull request

Documentation

Does this pull request introduces a new feature? (no)
If yes, how is the feature documented? (docs)

I have changed the description by https://github.com/NetEase/arctic/commit/0433ea16581a681e0385cc4f78e65b81084212ef


Custom marker tooltip

I am using mapbox in nativescript, how we can add a custom view (HTML or XML) to the marker tooltip.
Markers show only title and subtitle, I need to view my own layout instead

Please ask this in the Mapbox repo, I don't think that's possible atm.


Example tokio client hangs when HTTP Response code is in its own packet

Steps to reproduce:

Run nc -l -p 8081
Run hyper/examples/client.rs http://localhost:8081/
In the nc terminal, paste:

HTTP/1.1 200 OK

Hello World

Press ^C
This works fine.

Now repeat, but:

Run nc -l -p 8081
Run hyper/examples/client.rs http://localhost:8081/
In the nc terminal, paste:

HTTP/1.1 200 OK

Wait one second. Then paste

Hello World

Press ^C
The hyper example is hung

Expected result: the packet timing should not cause the example hyper client to hang (this works fine with curl).

Thanks for the steps to reproduce! It seems the issue was that during parsing, hyper didn't call read until the socket returned WouldBlock, which is required for tokio's socket implementation to know to register for more readable events.


Fix native docker file using wrong paths under Windows

Fixes #358

I have verified the fix works in a Windows VM.


Reduce duplication with #timestamps method

Fixes #132
Added a #timestamps method so that we get two attributes with default
values:

created_at
updated_at

Per issue #132, they are DateTime instances and their default value is
a proc returning DateTime.now.

My first attempt at an issue in ROM.
This is a pull-request for rom-rb#132

Perfect! Thank you :)

as a post-merge note: how about extending it so that you can pass-in arbitrary names of 'timestamp' attributes, like this:
timestamps # defaults to :created_at, :updated_at
timestamps(:updated_at) # we want only updated_at
timestamps(:published_at) # an alt name

This way we can easily set it up for various 'form objects' depending on the context. When persisting a new object you want both timestamps, when updating an existing object you only want updated_at etc.

Sure, that sounds like a good idea.  I'll work on it this weekend.

@kchien awesome :)
And yes, it should support more than just one attr name! If you could get it working just send a PR :) Oh and I invited you to the rom-rails group so you can just push your topic branch to rom-rb/rom-rails repo


SVN checkout fails because of duplicated credentials

Using version 2.0.1, running rocketeer deploy --verbose:
...
|-- Primer (Run local checks to ensure deploy can proceed)
|-- CreateRelease (Creates a new release on the server) [~0.2s]
|---- Deploy/Clone (Clones a fresh instance of the repository by SCM)
|===> Cloning repository in "/data/www/myapp/releases/20141027114737"
$ svn co<EMAIL_ADDRESS>/data/www/myapp/releases/20141027114737 --non-interactive --username="foo" --password="bar"
<EMAIL_ADDRESS>(production) svn: E170000<EMAIL_ADDRESS>isn't in the same repository as<EMAIL_ADDRESS>
When testing manually, it is fixed when I remove the credentials from the url:
svn co https://example.com/svn/myapp/trunk /data/www/myapp/releases/20141027114737 --non-interactive --username="foo" --password="bar"

This problem is happening again in 2.2.3

It appears that the issue is that the regex statement in rocketeer/src/Rocketeer/Binaries/Vcs/Svn.php:91 assumes an alphanumeric password. Some passwords contain symbols such as ! @ # $ etc and may be URL encoded.  There are existing PHP methods that parse URLs (mainly parse_url) that should be used instead of hacking together a regex.


BUG | Divider: "Vertical Divider" unable to produce desired result

Expected Behavior

When orientation="vertical" prop is passed to the Divider component, it is supposed to render a vertical divider.

Current Behavior

The component doesn't render a vertical divider. Applies to all vertical divider variations as mentioned in docs:

Vertical Divider
Vertical Divider with Label
Vertical Divider with Custom Label

Screenshot below:

Code Snippet:
import<EMAIL_ADDRESS>import { Divider } from "@hover-design/react";

export default function App() {
  return (

      Label 1
      <Divider orientation="vertical" style={{ margin: "0 10px" }} />
      Label 2
      <Divider orientation="vertical" style={{ margin: "0 10px" }} />
      Label 3

  );
}

Possible Solution

Steps to Reproduce (for bugs)

Copy the above sample code
Try it in CodeSandbox or your local project

Context

Your Environment

Version used: 0.1.8
Browser name and version: Safari 16.0
Operating System and version (desktop or mobile): macOS Monterey 12.6
Link to your project:

pl refer #109 for more context. Not actually bug with code but. issue with docs not specifying the constraints properly
cc- @hnprashanth


Filter out non-https URIs for testers

@tokle please review and merge.

This is not required, non-https should not be listed for any apps


csv-parse package is missing

for the https://github.com/Midburn/Spark/blob/master/bin/import_camps_data.js
a dependency required csv-parse package.
need to add it, as i'll provide a csv with updated camps,
and we will need to install on production as well.

seems to be working.


Add default projections for Views in CalendarPal

It's known that some devices cause problems when trying to get all columns of a calendar table by passing null as the projection. We need to provide defaults for regular apps and for sync-adapters.

Projections are no longer a property of Views, so this has become obsolete.


chore: package 이름 변경

🤔 해결하려는 문제가 무엇인가요?
🎉 변경 사항
🙏 여기는 꼭 봐주세요!
사용 방법
🌄 스크린샷
📚 참고

Codecov Report
Patch and project coverage have no change.

Comparison is base (2215c95) 95.65% compared to head (4b7475e) 95.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   95.65%   95.65%
=======================================
  Files           9        9
  Lines          46       46
  Branches        4        4
=======================================
  Hits           44       44
  Misses          2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Facility info on Prod not matching with info on Admin site

Overview
This is an example of a facility on our production site (OAR ID: TR2020191V0R2T4) which displays as being from a single contributor (BCI, over several years) and as having no alternative names or addresses.
The issue is that when viewing this same facility on the admin site, it appears as being contributed by another org as well and having an additional three names and addresses associated with it.
Expected Behavior
Expected behavior is that all information contributed and matched to a particular facility is displayed on prod. In this case, additional contributor information, alternative name and address data is not being displayed on prod; to be clear, this requirement applies to fields beyond contributor, name , and address and should include extended fields data contributed from multiple sources or other additional data points that may be added in the future.
Steps to Reproduce

View this facility on prod: OAR ID: TR2020191V0R2T4
View same facility on admin site
Note the differences (also captured in screen shots below)

Demo
Optional. Screenshots, gifs, curl examples, console errors, log files, etc.

It looks like the Higg match was rejected by Higg during the confirmation stage, which is why it doesn't appear under the facility sidebar.
Please let us know if there is any additional action required for this.

Thanks for the investigation @TaiWilkin!
cc: @hlennett

Vanessa and I were having a conversation about this yesterday. There are a few more opportunities for thinking through how to format the Adjust Facility Matches page to make moderation much easier.

Resolving the issue outlined above would be one piece - making it clear which matches were actually confirmed and which weren't (or not showing rejected matches at all here)
Thinking through how to handle situations where a user has re-uploaded their list multiple times and it makes the page quite long and requires repeats of the same action over and over to get all data split/transferred.

Maybe something to talk through and look at in conjunction with #1790
PS - I'm no longer able to tag Vanessa. Not sure why?