Idea: prepare predictions for edge DCT coefficients during decoding of previous blocks and of current 7x7 block

As for DC coef prediction, predictors for edge DCT coefficients can also be calculated during block IDCT (they are partial IDCT anyway), and stored inside NeighborSummary like edge_pixels_v/_h. These predictors are sums of dot products of dequantized coefs from above/left block with the same dot products from current block - dot products can be calculated for current block and used further in decoding of blocks below/to the right.

Cool idea... as long as all the rounding etc is identical so the format doesn't break

It works, but no performance improvement yet - I'll vectorize and see what happens.

Got the changes merged, so you can share your branch if you want

It is here https://github.com/Melirius/lepton_jpeg_rust/tree/fasterjpeg_simd_variation, but I had not enough time to polish it and get it faster

If you get a chance to merge with main... It's a hard to tell what changes are relevant. I tried it but it was a bit of a mess. Thanks!


When is the next Release Planned for this Project, may be 3.0.16

Describe your question
Would like to integrate some of the recent fixes made especially the one #1134(Disallow to call MqttClient.ConnectAsync while Disconnect is pending), would like to know when is next release planned.
Which project is your question related to?

Client
ManagedClient
MQTTnet.Server standalone
Server
Generic

Hi I will Release the next Version at the next Weekend.

Thank you Christian, will wait for the release


DBZ-2549 Move scripting code into a separate module

@jpechane, LGTM overall. Is there anything needed in terms of adjusting release scripts etc.? I'll push a commit for the docs update in a bit.

@gunnarmorling I am woring on Debezium image PR - it will work similar to apicurio. When ENABLE_DEBEZIUM_SCRIPTING will be set to true then the scripting jar will be copied to plugin dirs.
This will be enabled by default for 1.2 and disable by default starting from 1.3

@jpechane, I've pushed two commits for the doc update. I think we can move forward with this; if @TovaCohen has further doc updates in mind for that, we can take care of them separately.


Add failing test to demonstrate render order bug

Yesterday, we upgraded to @remote-ui/core 2.1.11 and @remote-ui/react 4.5.3 (we were on the versions immediately before those, 2.1.10 and 4.5.2). Within a few hours, we had several developers report rendering bugs involving strange ordering and missing elements. This PR includes a test demonstrating one of the bugs introduced by the new version.
There's a detailed writeup with screenshots in an issue on our repo here: https://github.com/stripe/stripe-apps/issues/648

Hi @ericfrank-stripe
Thanks for reporting this issue. The fix should be in the latest version of @remote-ui. Keep me updated if you still experience the bug.
Thanks


Add serailze methods to documents

This adds a serialize method to documents and fixes a few small issues that cropped up when testing those changes. Notably an is_null method was added since it became apparent that otherwise there's no way to tell. More importantly though, document members no longer resolve to their target shapes, but rather the proper member shapes. This necessitated some changes to setitem. Lastly, some improvements were added to shape type inference that leave the result as document only when the value is null.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hold up on reviewing this, I need to make changes


CPU detector ddint report Abnormality

https://applensv2.azurewebsites.net/sites/buggybakery/detectors/cpuanalysis?startTime=2016-10-26T12:00

the issue is understood. It happens when the downtime is the last point in the metric.


[ISSUE #1942] Fix push consumer doc error

fix #1942  push consumer doc error

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@d1b4e47). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1944   +/-   ##
==========================================
  Coverage           ?   47.58%
  Complexity         ?     3095
==========================================
  Files              ?      416
  Lines              ?    25954
  Branches           ?     3438
==========================================
  Hits               ?    12349
  Misses             ?    11990
  Partials           ?     1615

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b4e47...ecdb091. Read the comment docs.

Coverage decreased (-0.1%) to 50.806% when pulling ecdb091d24708d80691fa34fc9cb70e281f9c391 on coder-zzzz:apache_bugfix/#1942_PushConsumerDocError into 1706cecff0993efdb00a079068f972d2e9a3699f on apache:develop.

Only modify two md files~~ why Coverage decreased?

Only modify two md files~~ why Coverage decreased?

The CI is not reilable


Show max limit by default in consumption charts

@OliveGerste
1\ Max limit should be always visible for Admin by default
2\ The auto refresh deactivate the selected legend: when refresh occurs, the legend should stay active
3\ I reopened the issue that unselect the legend also when you switch Amps/Watts #1668


Added some feedback in case the test fails because of TCC agent not running.

Currently we show the AJ banner if the tests are passing, i.e. when TC is connected successfully to TCC.
However, if that's not the case, we don't show a single piece of information when the thing is run from the CLI.
After this change, people would see (after skipping some initial log lines):

I'd be happy to tune the wording and the banner.
This change also limits the number of log lines. I'm not sure if we need to have DEBUG level, where INFO might be enough already (if not too much).

That's great information. We need to be sure this experience is the same for other examples 👍


PLAT-615: skip sender check for future

Skip sender check for future
Add utils for future tests
Add test and improve conveyor tests

bors merge

bors retry


Fix virtctl expose

What this PR does / why we need it:
Change the virtctl expose target-port variable to be string an not interger
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1273
Special notes for your reviewer:
Also change:
VM -> VMI
OVM -> VM
VMRS -> VMIRS
Release note:

Change virtctl expose target-port from int to string

This change is

ok to test

@davidvossel I think the failing checks or not relevant to the PR can you take a look please?

retest this please

I understand that the actual translation of name to port is done inside the k8s service creation code?
what kind of error do we get when we pass an unknown string? will we get service creation failure in the virtctl call?

You don't get any error.
There is no unknown string.
This will create a service with the target-port name, if there is no match port name in the pod the target port on the service will be empty.
Also the service will auto update if you create a pod with the right port name.

Could you add a test for that?
If target-port is empty,  i think that it is assumed to be the same as the "port".  So, if "port" is set to something else than "80" the overall test should show no connectivity - but this will be tricky to debug :-(

It still looks good to me. There were no objections in the past 8 days, so I'll merge.
Thanks @SchSeba !


Make className extendable

Would be really nice to be able to pass in a custom className to extend the component's one.

You can already do this like so.

My mistake! Thanks!


Generics limitations

Concrete uniqueness
Contract call on interface implementation generates implementation of interface::Querier on contract::BoundQuerier.
This requires us to determine which generics should be forwarded to the interface::Querier. In case of generic values it's easy as we only have to determine which ones are used in the query methods. We are only interested in unique types and can use the same logic from interface macro.
Problem appears when we try to use concrete types.
If for below interface messages with four generic types [QueryT1, QueryT2, QueryT3, RetT]
    #[msg(query)]
    fn custom_generic_query_one(
        &self,
        ctx: QueryCtx<CustomQueryT>,
        msg1: Query1T,
        msg2: Query2T,
    ) -> Result<RetT, Self::Error>;

    #[msg(query)]
    fn custom_generic_query_two(
        &self,
        ctx: QueryCtx<CustomQueryT>,
        msg1: Query2T,
        msg2: Query3T,
    ) -> Result<RetT, Self::Error>;

we will use concrete types as below
    #[msg(query)]
    fn custom_generic_query_one(
        &self,
        _ctx: QueryCtx<SvCustomQuery>,
        _msg1: sylvia::types::SvCustomMsg,
        _msg2: sylvia::types::SvCustomMsg,
    ) -> StdResult<SvCustomMsg> {
        Ok(SvCustomMsg {})
    }

    #[msg(query)]
    fn custom_generic_query_two(
        &self,
        _ctx: QueryCtx<SvCustomQuery>,
        _msg1: sylvia::types::SvCustomMsg,
        _msg2: sylvia::types::SvCustomMsg,
    ) -> StdResult<SvCustomMsg> {
        Ok(SvCustomMsg {})
    }

Sylvia will think that there are only two generic types and will try to forward them to the Querier.
    impl<'a, C: sylvia::cw_std::CustomQuery>
        custom_and_generic::sv::Querier<sylvia::types::SvCustomMsg, SvCustomMsg>
        for crate::contract::sv::BoundQuerier<'a, C>
    {
        fn custom_generic_query_one(
            &self,
            _msg1: sylvia::types::SvCustomMsg,
            _msg2: sylvia::types::SvCustomMsg,
        ) -> Result<SvCustomMsg, sylvia::cw_std::StdError> {
            let query = custom_and_generic::sv::QueryMsg:: <sylvia::types::SvCustomMsg,SvCustomMsg, > ::custom_generic_query_one(_msg1,_msg2);
            self.querier().query_wasm_smart(self.contract(), &query)
        }
        fn custom_generic_query_two(
            &self,
            _msg1: sylvia::types::SvCustomMsg,
            _msg2: sylvia::types::SvCustomMsg,
        ) -> Result<SvCustomMsg, sylvia::cw_std::StdError> {
            let query = custom_and_generic::sv::QueryMsg:: <sylvia::types::SvCustomMsg,SvCustomMsg, > ::custom_generic_query_two(_msg1,_msg2);
            self.querier().query_wasm_smart(self.contract(), &query)
        }
    }

If we would use the same path here f.e. SvCustomMsg in place of sylvia::types::SvCustomMsg only a single type would be forwarded as generic.
This provides us an workaround allowing user to work with aliases/different versions of paths, but it's a bad solution and we should find a better one.
Solution here might be to drop unique filtering for generic arguments, but it will cause more troubles as in above example we would jump from two generics to six (while expecting four).
Another way would be to provide a new attribute here, but it would only serve as a way to provide generics defined for a trait and I don't see as a much better solution then using type aliases.
We also cant distribute proper generics to Querierin theInterfaceApi` as this is a trait.
At this moment I don't see a proper way to fix it and we most likely will have to fix it after the 1.0.0 release.

Found while implementing #263

Ok, I was thinking through that slowly.
The question here is - why the querier is not generic over all the generic types? The answer is - because some of the types are not used at all, which causes compilation error.
If the querier trait would always be generic over exactly the same types the contract is, there would not really be a problem. So what is the reason we dont use some generics?
The reason is - because querier is not actually using all the generics. It uses only those used by query functions, but if you have some generics used only by execs or sudos, you do not need those for queriers.
I was looking at the solutions, and then I got hit by one fact - how many implementations of this querier can exist on the single contract type (monomorphized one)? Obviously - exactly one. It is due to a fact, that we would have couple functions for the same query message. This is invalid.
We do that for traits for couple reasons, and none of the reasons are good I think. You can never have a contract properly implementing multiple interfaces. Contract can be generic, for extensibility purposes, but for interfaces we would always need to use associated types. Ill explain it more on call I think

Closed, generics not to be supported: #303


Add the ability to alias a reference

The ability to alias a referene
Sometimes if different assemblies use the same namespace, there will be conflict problems. And this problem will be wider and wider with .NET ecosystem growing up. We cannot guarantee that we can access code of all the references, for example some reference are packages so that we cannot modify their source code to resolve the problem. And also if some packages are no longer being maintained, the problem will always exist and cannot be resolved.
For example:
dotnet new classlib -f netstandard2.1
dotnet add package SixLabors.ImageSharp --version 1.0.0-beta0006

Then you cannot use Span<T> because:
error CS0433: The type 'Span<T>' exists in both 'System.Memory, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' and 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'

The same for .net core 3.0 project with language version 8.0 and reference to package Microsoft.EntityFrameCore: in this case you will lose the ability to use IAsyncEnumerable<T> for the same reason.
Another scenario:
Project A reference package X 1.0, while project B reference package X 1.1. But unfortunately package X 1.0 to 1.1 has breaking changes so that Project A must lock at 1.0 and the same for Project B.
In this case we will never be able to reference A and B in a single project because of incompatible references.
Solution
Introduce alias for reference, for example:
<PackageReference Include="xxxxxx" Alias="pkg1" Version="1.0" />
<ProjectReference Include="./MyProject.csproj" Alias="proj1" />

Then in code we can use in code:
pkg1::xxx.yyyy
proj1::abc.defg

which perfectly resolve all the problems above.

First, that error with SixLabors.ImageSharp looks like a bug somewhere to me and something that should be reported.
Second, you already can add an alias to an assembly that is part of a NuGet package: https://github.com/NuGet/Home/issues/4989#issuecomment-310565840. Though you could view that as a hack and so you might want to see a better supported solution.

@svick Thanks for your reply. This is a great solution: https://github.com/NuGet/Home/issues/4989#issuecomment-426666530
I think add the ability to alias reference is important.

In TypeScript we have
import * as [alias] from [file/package]

and also in python we have
import [package] as [alias]

This is necessary for project to avoid name conflicts, in addition, node.js has its method to avoid version conflicts through packages.lock.json.
Therefore, I think .NET Core project need a way to avoid name conflicts and version conflicts.
For example, use <XXXReference Include="xxx" Alias="xxx" /> to avoid name conflicts, and use <XXXReference Include="xxx" Private="true" /> to keep things referenced by xxx private so that its references won't affect its parent project.

@hez2010
Regarding the PackageReference aspect, the right issue is the one in the NuGet repo.
A few notes:
NuGet already has packages.lock.json support.
https://blog.nuget.org/20181217/Enable-repeatable-package-restores-using-a-lock-file.html
NuGet packages can have more than 1 assembly reference. Do you want alias all of those?
I believe the design is not as straightforward as adding an alias metadata at the PackageReference level.
<XXXReference Include="xxx" Private="true" />

For PackageReference, look into PrivateAssets https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#controlling-dependency-assets

Seems to be answered, closing.


Improve the root cause analysis message for a new shell

01:56:35::cbd-first ♨ >  DEBUG=1 cbd ps
[DEBUG] Use profile: Profile
[DEBUG] CloudBreak Deployer 0.5.0
[DEBUG] docker-compose -p cbreak ps
Couldn't connect to Docker daemon - you might need to run `boot2docker up`.

The boot2docker is up and running and what really has to be done is init the shell to point to the docker process in the vm, like below:
01:56:38::cbd-first ♨ >  eval $(boot2docker shellinit)

Good point, root cause analysis is important indeed! We created a special command: cbd doctor
Influenced by brew doctor
Could you please check if it would advise the correct solution?

To keep things in one place (here :) ). The cbd doctor does complain, but without prompting for any resolution:
♨ >  cbd doctor
===> Deployer doctor: Checks your environment, and reports a diagnose.
local version:0.5.1
latest release:0.5.1
boot2docker date settings: OK
boot2docker: OK
docker command: OK
docker client version: OK
[ERROR] docker version returned an error
Client version: 1.6.0
Client API version: 1.18
Go version (client): go1.4.2
Git commit (client): 4749651
OS/Arch (client): darwin/amd64
time="2015-05-18T15:35:57-04:00" level=fatal msg="Get http:///var/run/docker.sock/v1.18/version: dial unix /var/run/docker.sock: no such file or directory. Are you trying to connect to a TLS-enabled daemon without TLS?"

I'm trying to rely on boot2docker shellinit output to give a hint.
I remember that in previous versions were writing "Your environment variables are already set correctly." to stdout, and no "export DOCKER_XXX". So a simple
if [[ "$(boot2docker shelling 2>/dev/null)" == "" ]]; then
  # ok
else
  # give hint to run boot2docker shellinit
fi

Would make a perfect solution.
Unfortunately boot2docker shellinit always writes the export DOCKER_XXX instructions regardless, if they are already set.
Pull Request
I issued a pull request to fix it: https://github.com/boot2docker/boot2docker-cli/pull/366
Until it gets merged I'm fixing it by reimplementing the checkEnvironment() call sees original go function

Its automatically closed by the commit message.
Please check cbd doctor after cbd update master and reopen if it doesn't give you the correct hint.
After that please go back to latest released version with cbd update


Added cases to fail fast when an error can be detected

Signed-off-by: Janario Oliveira<EMAIL_ADDRESS>
What this PR does / why we need it:
Impl for some cases of https://github.com/helm/helm/issues/3875
Implemented some of the scenarios that are more common for me

invalid image (for invalid register or tag) ImagePullBackOff
pod crashing: CrashLoopBackOff
pod never created because RS failed (quota or some capacity problems): ReplicaFailure

There still other scenarios that can be implemented in a second phase, such as:

invalid image with helm hook
quota problem with helm hook

Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

Any updates here? this would be a nice case for our development environment with garden and helm where it is common to have such kind of error

What are the next steps here? Please let me know if I need to provide something else
Looking forward to having this in the next releases :-)

@janario looks like this can be merged, thank you for this very useful addition! :)

@dudicoco that's good news, looking forward to it :-)

@saisona can this PR be merged, please?

@bacongobbler can you please advise what needs to be done in order to merge this?

Any updates here? @saisona

Oh yes sorry 😇

@saisona how can we get this PR merged?

@saisona is not a helm maintainer... this PR needs approval from two maintainers to be merged.

@bacongobbler are the maintainers the ones in the root OWNERS file? https://github.com/helm/helm/blob/master/OWNERS

sorry, my mistake I didn't notice he was not the maintainer.
so back to this,  @bacongobbler  can you help us with this PR? review, suggestions...

@janario can you please assign the PR to two maintainers from https://github.com/helm/helm/blob/master/OWNERS

@dudicoco it doesn't show the option to assign
@mattfarina @bacongobbler @hickeyma please, any help here?

@mattfarina @bacongobbler @hickeyma can you please advise on what can be done in order to merge this PR?
@janario took the time to contribute an important feature, it would be appreciated if the PR could get the proper attention.
Thanks

may I resurrect this PR? this is something would be very helpful for my use case


Check/Switch Heroku plan

Heroku is abandoning its free plans starting November 28th 2022. There will be a not-for-profit offer in 2023.
Blogpost https://blog.heroku.com/next-chapter
FAQ: https://help.heroku.com/RSBRUH58/removal-of-heroku-free-product-plans-faq
Check our plans:

Production
Staging

-> Decide what to do.

Postgres DB will cost 5$/month now

we will check out the cheapest plan for staging and see if it is enough for us.


[Windows] UI never hides with mouse hovering the window

Whenever i hover the mouse in the window the UI refuses to disappear, TAB only helps for 1ms
holding tab just fast-switches the ui hide/show state
Fullscreen is unusable this way, i had to use screen extension to be able to get the mouse outside the window scope

did you move the mouse outside the player controls? (e.g. in the top center)

Yes
Just tested now that borders do not apply, only inside the rendering area (inner window) is where the bug happens
Windows 7 here

Note: This is partially fixed in 1.0.8 but has some bugs still, such as rarely not hiding when the cursor is on top of the window


Datepicker doesn't take date

The new datepicker-popup doesn't take the date after clicking on the date on the calendar or rather clicking on Done. I have to use the ~0.14 version.
Tried on chrome and firefox
   <input on-open-focus="false" datepicker-options="{\'starting-day\':1}" datepicker-append-to-body="true" uib-datepicker-popup="dd.MM.yyyy" type="text" ng-model="cell.value" close-on-date-selection="true" ng-model-options="{ updateOn:\'blur\' }" ng-change="detail.updateRow(rowIndex)" is-open="true">

@stefanhuber, this is working in the demo.  Please extend us the courtesy of reading our project documentation for how to enter what you think is a bug.  You may find these instructions here.
I will consider reopening if you are able to recreate the issue in a minimally working plunker and there is no issue with your code.  Thanks.


PS-1855 optional metadata + runId

I switched argument order to allow for default.

sorry for the re-ping, just wanted to confirm


Improve certificate manager

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement
What this PR does / why we need it:

improve YurtCertficateManager Interface for provides all certificates management.
add func NewCertManagerFactoryWithFnAndStore(), so yurthub can use CertManagerFactory util funcs to generate certs.
add func PickHealthyServer() for MultipleBackendsHealthChecker interface, so rest config manager can get healthy server directly.
add two parameters: --discovery-token-ca-cert-hash and --discovery-token-unsafe-skip-ca-verification for yurthub, so end user can use these parameters and increase security for joining nodes.

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@Congrool PTAL

@Congrool comments are fixed, PTAL

/lgtm


Ciphbit group

http://ciphbitqyg26jor7eeo6xieyq7reouctefrompp6ogvhqjba7uo4xdid.onion/

Thank you. it was already referenced but with a typo.  It's corrected :
https://ransomware.live/#/group/ciphbit


server/util-server.js: [Down] PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
Ping will fail if the system uses busybox version of  ping.
👟 Reproduction steps

Use a distro using busybox by default.
Or remove iputils
Add a ping monitor

👀 Expected behavior
It pings without root permission or iputils?
😓 Actual Behavior
[Down] PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
🐻 Uptime-Kuma Version
1.20.2
💻 Operating System and Arch
Alpine 3.17 armv7
🌐 Browser

🐋 Docker Version
No response
🟩 NodeJS Version
18.14.2
📝 Relevant log output
sudo -u uptime-kuma busybox ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
ping: permission denied (are you root?)

See https://serverfault.com/questions/1001174/cant-ping-permission-denied

Should we add some docs about this or expand the error message? I don't think it's easy to figure out what actually happens without more clues than [Down] PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes

Especially when ping: permission denied (are you root?) is not visible in logs or the web ui.


Make methods static where possible

Some minor gardening

@JamesNK friendly ping!

BinaryConverter.EnsureReflectionObject and its memoisation field, _reflectionObject can also be made static, and replacing value.GetType().AssignableToTypeName(BinaryTypeName) with value.GetType().FullName == BinaryTypeName makes it clearer that it can, as well as being slightly cheaper.

I'm not a huge fan of making things static just because you can but these mostly don't look too bad.
Could you double check there is nothing introduced with Async that doesn't also have static.


Make graphite whisper(data) directory configurable

This PR provides ability to specify/change the location to store graphite whisper data. Whisper files can take up huge amounts of space (in 100's of GBs) based on what metrics are configured to be collected and the number of data points to be collected. With this PR, one can set the data directory to be on a separate disk/partition so that whisper data does not fill up root disk.

Separated out the graphite attributes to their own file. Unit test on vbox vm cluster.

Thanks for splitting the attributes out and making this configurable!


[BUG] VM IP address displays incorrect

Describe the bug
VM IP address displays incorrect
To Reproduce
Steps to reproduce the behavior:

Create a VM
Go to the VM detail page
Check IP Address

Result
VM IP address displays incorrect

Environment:

Harvester ISO version: master-head
Installation Mode: ISO

Validated on v0.2.0-rc2
This issue has been fixed in v0.2.0-rc1, and the VM IP can be displayed correctly


Chrome CORS "SameSite" warning when using Config differ

This is caused by a recent change in Chrome. All cookies are now required to specify a SameSite attribute.
We can still have the same behavior as we have now by setting SameSite to None. This will still allow the ConfigDIffer to work.
Unfortunately, this may be difficult to fix in Grails. Grails tracks sessions using a JSESSIONID cookie. I have not been able to find an easy way to set SameSite on this cookie.

Thanks much for looking at this Peter, and for these additional details.
It appears as though we can do this at our nginx proxy layer via the proxy_cookie_path directive. I have it working locally, although we will want to proceed with care as if we somehow break cookies we'll obviously break auth as well in general.
I'm going to experiment a bit more, then should have an update to our xh-nginx base image to put this into place.

This appears to be resolved by https://github.com/xh/xh-nginx/commit/7db17f610d6b52f9bcfc72a94515a6b83ea062af.
Some notes:

I am a bit concerned that this cookie path adjusting directive could have some unintended consequences for apps with non-standard deployments - e.g. where their nginx config has been adjusted to listen on a particular sub-path (and not /). I don't really know that there would be an issue - I just want to proceed with care here.
Given that, I added this to our pre-existing xh-hardeners.conf include, which is opt-in in that apps must add an include line to their nginx config's location /api/ { ... } block.
I also pushed this to a new xh-nginx/develop branch and adjusted our autobuilds on hub.docker.com to build off of develop as xh-nginx:next so we have a chance to test this before it gets rolled out generally.

@haynesjm42 some of the client apps you have managed are probably the most likely to have a custom nginx setup. If that's the case, when you have a chance could you try updating one of their Dockerfiles to use xh-nginx:next as its base image and ensure that it's including xh-hardeners?
No rush really - I don't think this will break anything for apps that have yet to update (other than the config differ) if/when Chrome rolls out their new policy.

I'll leave this open for a bit to see if we have time to test in some client apps and - if successful - will merge into xh-nginx/master and close this ticket out.

Closing as we can revisit if we see any actual issues in practice when we promote xh-nginx:next to latest, which we're gonna need to do soon due to other changes in the base image for k8s support.


HTTP 500 when adding a VLAN Group with Site via API

Issue type: bug report

Python version: 2.7.5
NetBox version: 2.0.4

Adding a VLAN Group via the API works fine, so long as I don't specify a 'site':
curl -X POST -H "Authorization: Token $token" -H "Content-Type: application/json" -H "Accept: application/json; indent=4" http://$netbox_host/api/ipam/vlan-groups/ --data '{"name": "VG1", "slug": "vg1"}'
However, if I specify a site ID in the data payload, I get an HTTP 500 error back:
curl -X POST -H "Authorization: Token $token" -H "Content-Type: application/json" -H "Accept: application/json; indent=4" http://$netbox_host/api/ipam/vlan-groups/ --data '{"name": "VG1", "slug": "vg1", "site": "19"}'
The error message is:

<class 'django.core.exceptions.FieldError'>
 Cannot resolve keyword 'slug' into field. Choices are: created, custom_field_values, description, group, group_id, id, last_updated, name, prefixes, role, role_id, site, site_id, status, tenant, tenant_id, vid

You are passing the site ID as the site parameter which is expecting a slug. You need to pass your ID in the site_id parameter.

@lampwins You may be thinking of the filters, where site takes a slug and site_id takes a primary key. The API calls @MattBurgess posted are both correct.
There's a bug in the serializer validation that's preventing a VLANGroup from being created if a site is assigned.


"Connection closed by server: 1006" when using --host <IP_ADDRESS>

I did these steps on Raspberry Pi3:

git clone https://github.com/Lawouach/WebSocket-for-Python.git
cd WebSocket-for-Python/
sudo python setup.py install
python example/echo_cherrypy_server.py  --host <IP_ADDRESS>
Then open a browser on my PC and go to http://192.168.1.x:9000

Then the message box shows:
Connection closed by server: 1006 ""
I use cherrypy 3.5.0  in my RPi3. Please advise the way to solve the problem. Note that there is no problem if I specify the IP address of either Ethernet or Wifi.   I have to use <IP_ADDRESS> as Host because I connect to RPi via Ethernet or Wifi.
Thank you.

Hey @aruangra,
Try using <IP_ADDRESS> or localhost as the --host parameter.

I am having the same problem. I have a server that will need access from multiple addresses. Is there a way around this problem yet?


Add documentation for prepare_query callback

Simply added an example use case, to make it clearer.

Excellent!
José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

Thanks!


Full support for dbt deps on Windows

OSError: [WinError 17] The system cannot move the file to a different disk drive: 'C:\Users\UserName\AppData\Local\Temp\dbt-downloads\75cce4837e0fd73e2934f79b9a5238a9' -> 'dbt_modules\snowplow'
This can happen on Windows if the temp dir is on a different drive than the dbt project dir

I spoke with Drew and suggested a workaround being able to override the temp dir. Of course this is no fix or solution but general good idea of having it configurable

Combining issue https://github.com/fishtown-analytics/dbt/issues/766
dbt deps - symlink fails on windows (symbolic link privilege not held)
Via slack:
2018-05-09 15:52:04,681: Tracking: do not track
2018-05-09 15:52:04,692: Installing ../
2018-05-09 15:52:04,693:   Creating symlink to local dependency.
2018-05-09 15:52:04,693: Encountered an error:
2018-05-09 15:52:04,693: symbolic link privilege not held
2018-05-09 15:52:04,695: Traceback (most recent call last):
  File "c:\users\bene\appdata\local\programs\python\python36-32\lib\site-packages\dbt\main.py", line 41, in main
    results, succeeded = handle_and_check(args)
  File "c:\users\bene\appdata\local\programs\python\python36-32\lib\site-packages\dbt\main.py", line 85, in handle_and_check
    task, res = run_from_args(parsed)
  File "c:\users\bene\appdata\local\programs\python\python36-32\lib\site-packages\dbt\main.py", line 139, in run_from_args
    results = run_from_task(task, proj, parsed)
  File "c:\users\bene\appdata\local\programs\python\python36-32\lib\site-packages\dbt\main.py", line 147, in run_from_task
    result = task.run()
  File "c:\users\bene\appdata\local\programs\python\python36-32\lib\site-packages\dbt\task\deps.py", line 424, in run
    package.install(self.project)
  File "c:\users\bene\appdata\local\programs\python\python36-32\lib\site-packages\dbt\task\deps.py", line 272, in install
    dbt.clients.system.make_symlink(src_path, dest_path)
  File "c:\users\bene\appdata\local\programs\python\python36-32\lib\site-packages\dbt\clients\system.py", line 106, in make_symlink
    return os.symlink(source, link_path)
OSError: symbolic link privilege not held

Windows 10 Pro (developer mode enabled, can call mklink without elevated privileges)
Using powershell
dbt 10.0.0
It works in an admin shell

We should either fix this, or add an option to not create a symlink

Via Ben Edwards in Slack:

some other research that I have done, python's os.symlink will never work in windows unless run by an elevated user, even if the regular user can create symlinks (by enabling developer mode). The check in system.py only checks if the os supports symlink, which windows does, you just cant use it. A possible workaround I've seen is to detect windows, start a shell and call mklink from there.

Could just set the TMPDIR env var

Here are some investigation scenarios that show that if the TMP dir and dbt project dir are on the OS drive the dbt deps is successful but not if they are on different drives https://gist.github.com/atharvai/822ef904c29bbd304bac07bb37233dab

fixed in #1110

I think this is the reason dbt has trouble installing deps on WSL2... is there a way to skip using the symlinks? when you only have 1 or 2 dbt projects it causes much much more headaches than the few MBs it saves


Change loading on Modals/Dialog

Is your feature request related to a problem? Please describe.
Change modal loading to button instead of own component on the side. (See attached image)
Describe the solution you'd like

Button loading when saving/login etc...

Describe alternatives you've considered

Use Dots inside buttons from EDS
Circular Progress inside buttons from EDS
Remove login/save button on load and replace with progress Circular Progress or Dots

Additional context

Example of design


The keybinding of "Show SCM" is inconsistent。

"Show Explore"      -> "shift+cmd+e" -> good!
"Show Debug"        -> "shift+cmd+d" -> good!
"Show Extensions" -> "shift+cmd+x" -> good!
"Show Search"        -> "shift+cmd+f" -> good!
"Show SCM"            -> "ctrl+shift+g"  -> why?????!!!!!!
If the keybinding is like this, will be great!
[
{
        "key": "shift+cmd+g",
        "command": "workbench.view.scm"
    },
    {
        "key": "ctrl+shift+g",
        "command": "-workbench.view.scm"
    },
    {
        "key": "ctrl+shift+g",
        "command": "editor.action.previousMatchFindAction",
        "when": "editorFocus"
    },
    {
        "key": "shift+cmd+g",
        "command": "-editor.action.previousMatchFindAction",
        "when": "editorFocus"
    },
    {
        "key": "ctrl+g",
        "command": "editor.action.nextMatchFindAction",
        "when": "editorFocus"
    },
    {
        "key": "cmd+g",
        "command": "-editor.action.nextMatchFindAction",
        "when": "editorFocus"
    },
    {
        "key": "cmd+g",
        "command": "workbench.action.gotoLine"
    },
    {
        "key": "ctrl+g",
        "command": "-workbench.action.gotoLine"
    }
]

I mean if the default keybinding like above, will be great.
I keybinding I showed above. ctrl+g and ctrl+shift+g are related to Find Action. cmd+g is binded to goto line which will be good to. And shift+cmd+g  is binded to Show SCM  which will be consistent with other Show xxx actions.
What about my opinion?

But if you're focused on the editor then the shortcut will open the find widget.
We won't change the default. You're free to change your own keybindings.


bump versions 0.23.5

Description:
Bump version 0.23.5

Codecov Report
Patch and project coverage have no change.

Comparison is base (32ea15b) 74.54% compared to head (32ea15b) 74.54%.

:exclamation: Current head 32ea15b differs from pull request most recent head 2aaa39a. Consider uploading reports for the commit 2aaa39a to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           release/0.23    #1273   +/-   ##
=============================================
  Coverage         74.54%   74.54%
=============================================
  Files                31       31
  Lines              2251     2251
  Branches            452      452
=============================================
  Hits               1678     1678
  Misses              440      440
  Partials            133      133

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[7.0.0] testing_phase2 Please ignore.

Forked from #346

Cherry-picked in https://github.com/bazelbuild/bazel/pull/19395

Cherry-pick was attempted, but failed to push. Please check if the branch, cp346-7.0.0, already exists
cc: @bazelbuild/triage

create_pr() takes 8 positional arguments but 10 were given

Cherry-picked in https://github.com/bazelbuild/bazel/pull/19528

Cherry-picked in https://github.com/bazelbuild/bazel/pull/19565


a bit large

Adding this lib to my react app, it adds 12.4KB (uglified) to my built js file (3.6KB gzipped) which seems very large for what this does. Is there perhaps one of the dependencies being mostly responsible for this bloat, that could be replaced by something else?

Looks like loads.omit is responsible for most of the bloat (7KB uglified, 1.9KB gzipped). Can we replace that fatso?

I tried to fork but npm install fails for me. Anyways, how about replacing lodash.omit with:
function omit(object, keys) {
  let newObject = Object.assign({}, object);
  keys.forEach(key => delete newObject[key]);
  return newObject;
}

@pekeler If you want to send me a PR that strips any junk you find that would be appreciated.

Oh man, the dependencies are way out of date and you're using gulp which I wiped from my machine ages ago.

@pekeler You realize I'm the person who wrote gulp?

Ha, I didn't know that. Don't take it personally - I feel the same about grunt and other JS build automation tools. First PR is ready.

Second PR with the actual change is ready as well. Not sure I did it correctly since it depends on the first PR. Let me know if there's a problem.

@pekeler the omit function you've used to replace lodash.omit uses Object.assign which has very poor browser support

'object-assign' is already a dependency. I guess we should require and use it.
I wonder if there's a way to use https://github.com/facebook/react/blob/master/src/shared/stubs/Object.assign.js instead, so we could remove the 'object-assign' dependency.

@jbomeyer @colindresj #39


bcm4345-bt.bb: Use firmware from the A710_OS_2.0.0-sdfuse.img release (master branch)

Signed-off-by: Florin Sarbu<EMAIL_ADDRESS>

No changelog in the bsp layer


Uncaught TypeError: this.ink.Spinner is not a function

[Enter steps to reproduce below:]

Go to Packages
Search for julia-client
Hit update

Atom Version: 1.7.3
System: Ubuntu 14.04.4
Thrown From: julia-client package, v0.4.7
Stack Trace
Uncaught TypeError: this.ink.Spinner is not a function
At /home/ashley/.atom/packages/julia-client/lib/ui.coffee:19

TypeError: this.ink.Spinner is not a function
    at Object.module.exports.consumeInk (/home/ashley/.atom/packages/julia-client/lib/ui.coffee:19:20)
    at Object.module.exports.JuliaClient.consumeInk (/home/ashley/.atom/packages/julia-client/lib/julia-client.coffee:25:7)
    at Provider.module.exports.Provider.provide (/usr/share/atom/resources/app.asar/node_modules/service-hub/lib/provider.js:30:52)
    at /usr/share/atom/resources/app.asar/node_modules/service-hub/lib/service-hub.js:55:26
    at doNTCallback0 (node.js:443:9)
    at process._tickCallback (node.js:372:13)

Commands
 16x -1:28.4.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -1:23.2.0 core:confirm (atom-text-editor.editor.mini.is-focused)
 33x -1:14.1.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -1:10.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
  5x -0:58.5.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:53.6.0 core:confirm (atom-text-editor.editor.mini.is-focused)
 17x -0:46.2.0 core:backspace (atom-text-editor.editor.mini.is-focused)

Config
{
  "core": {
    "projectHome": "/home/ashley/GIT"
  }
}

Installed Packages
# User
autocomplete-julia, v0.1.0
autocomplete-python, v1.7.2
build, v0.59.0
build-tools, v4.4.0
ink, v0.4.4
instant-build, v0.4.0
julia-client, v0.4.7
language-julia, v0.6.0
vim-mode, v0.65.0

# Dev
No dev packages

This shouldn't come up again after you restart Atom.
So while this is a bug, it shouldn't actually matter much and only happens on that specific update, I think.

Alrighty


openobserve: init at 0.5.3

Description of changes
https://github.com/zinclabs/zincobserve
ZincObserve is a cloud native observability platform built specifically for logs, metrics, traces and analytics designed to work at petabyte scale.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

It has been renamed to openobserve. However I am getting the following error on the latest release -
cargo-vendor-dir> ln: failed to create symbolic link '/nix/store/r5d9y3pj7x0r416nsq43cv66gznp1arz-cargo-vendor-dir/vrl-0.4.0/mwlqgianlq2dxks73dm7h472v5m4vr6z-vrl-0.4.0': Permission denied
error: builder for '/nix/store/rpv8ihchbk1wcmf89wdh5a5b7dw0xzl4-cargo-vendor-dir.drv' failed with exit code 1;
last 1 log lines:
> ln: failed to create symbolic link '/nix/store/r5d9y3pj7x0r416nsq43cv66gznp1arz-cargo-vendor-dir/vrl-0.4.0/mwlqgianlq2dxks73dm7h472v5m4vr6z-vrl-0.4.0': Permission denied
For full logs, run 'nix log /nix/store/rpv8ihchbk1wcmf89wdh5a5b7dw0xzl4-cargo-vendor-dir.drv'.
error: 1 dependencies of derivation '/nix/store/jks4gv9gylivlk6fkpkrf4xhhxpmx47r-openobserve-0.4.7.drv' failed to build

They have 2 crates with the same version (vrl) one with a git dependency and one without.
The last release of that crate was in may. I would bet that when the versions finally converge we won't have that problem anymore.

@dit7ya the latest release has removed the custom vrl dependency that was a problem for the build
https://github.com/openobserve/openobserve/releases/tag/v0.5.3
(I had an issue opened about it and upstream notified me).
When you have a moment to update this, it should be good to go.
If for any reason you can't continue this, I'm happy to take over.

@happysalada Thanks. I have updated the derivation but yet haven't found time to check if the build succeeds or if the package works.

Result of nixpkgs-review pr 232891 run on x86_64-linux 1

1 package built:

openobserve

I just tested the --help, but it's looking good.
I would say it's good enough for us to test and make a module. (or for someone else to start hacking at a module).

Seems like upstream has releases 0.6.0 and deleted the 0.5.3 release from GitHub. Not cool :(
https://github.com/openobserve/openobserve/releases

Result of nixpkgs-review pr 232891 run on x86_64-linux 1

1 package built:

openobserve

@drupol I think your comments have been addressed, could you check when you have a moment ? (just to make sure ).

@dit7ya I think this is ready to merge (modulo removing the TODO), what do you think ?

0.6.1 has just been released, maybe we should just wait for a week to see if things calm down a little

ofborg is giving test failures, looks like some missing database setup step
https://logs.ofborg.org/?key=nixos/nixpkgs.232891&attempt_id=3a9ce057-2020-47af-a42f-0e0417de9763

Should we just update to 0.6.4 and call it a day ?

it looks like the version updates have stopped for now.
Would you mind updating to latest ? I think this is good to merge after.
Also I'm happy to be added as a maintainer if you are ok with that.

@dit7ya looking at ofborg it looks like we have some test failures though
service::db::compact::file_list::tests::test_file_list_offset
       >     service::db::compact::file_list::tests::test_file_list_process_offset
       >     service::db::compact::files::tests::test_files
       >     service::db::user::tests::test_user
       >     service::triggers::tests::test_triggers

closing in favor of https://github.com/NixOS/nixpkgs/pull/270730


[WIP] changes to allow the run_ogusa script to work

permits isolated and parallel execution of 'execute' module

@talumbau I think we are ok to close this PR with the merging of PR #178.  Please go ahead and close if you agree.


Font size problem in the  heading

Describe the bug
when the mode is changed from light to dark the font size of the text :
Find hospitality related icons, curated by creators from Bookingjini
changes

please assign me this issue
Expected behaviour
in both, the text should be of same font size

Screenshots
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Kaivanshah1 assigning this to you

Hello @Kaivanshah1, I am GSSoc contrbutor. I would like to work on the issue pls assign it to me

Closed issue no more valid.


Kore variable name encoding discussion

Right now encodeStringToAlphanumeric and decodeKoreString are not implemented properly.
let's discuss in the meeting what is the best approach here since we would like the kore encoding to be somewhat readable.
'Unds'V'Unds'9 -> _V_9
'QuesUnds'0 -> ?_0

https://github.com/kframework/llvm-backend/blob/master/lib/ast/AST.cpp#L10

This code path is not doing what we expect. Those dashes do appear in some cases.
We need to do integration test with llvm and haskell backends.


Errors in plugin when WP ran CI checks

Errors reported in the Coil plugin when WordPress ran their CI checks.

@wpcomvip-vipgoci-bot requested changes on this pull request.
phpcs scanning turned up:
🚫 5 errors
⚠ 46 warnings
This bot provides automated PHP Linting and PHPCS scanning.
Posting will continue in further review(s)
In plugins/coil-web-monetization/Gruntfile.js:

			'dist/blocks.editor.build.min.css': [ 'dist/blocks.editor.build.css' ],

  			'dist/blocks.style.build.min.css': [ 'dist/blocks.style.build.css' ]

  		}

  	}

  },

  // Minify JavaScript

  uglify: {

  	options: {

  		compress: {

  			global_defs: {

  				"EO_SCRIPT_DEBUG": false

  			},

  			dead_code: true

  		},

  		banner: '/*! <%= pkg.title %> v<%= pkg.version %> <%= grunt.template.today("dddd dS mmmm yyyy HH:MM:ss TT Z") %> */'

⚠ Warning: Found Underscore.js unescaped output notation: "<%=" (WordPressVIPMinimum.Security.Underscorejs.OutputNotation).
In plugins/coil-web-monetization/Gruntfile.js:

},

  // Check for Sass errors with "stylelint"

  stylelint: {

  	options: {

  		configFile: '.stylelintrc'

  	},

  	all: [

  		'assets/scss/**/*.scss',

  	]

  },

  // Check strings for localization issues

  checktextdomain: {

  	options:{

  		text_domain: '<%= pkg.name %>', // Project text domain.

⚠ Warning: Found Underscore.js unescaped output notation: "<%=" (WordPressVIPMinimum.Security.Underscorejs.OutputNotation).
In plugins/coil-web-monetization/Gruntfile.js:

		expand: true

  	},

  },

  // Bump version numbers (replace with version in package.json)

  replace: {

  	php: {

  		src: [

  			'includes/functions.php',

  			'plugin.php'

  		],

  		overwrite: true,

  		replacements: [

  			{

  				from: /Description:.*$/m,

  				to: "Description: <%= pkg.description %>"

⚠ Warning: Found Underscore.js unescaped output notation: "<%=" (WordPressVIPMinimum.Security.Underscorejs.OutputNotation).
In plugins/coil-web-monetization/Gruntfile.js:

// Bump version numbers (replace with version in package.json)

  replace: {

  	php: {

  		src: [

  			'includes/functions.php',

  			'plugin.php'

  		],

  		overwrite: true,

  		replacements: [

  			{

  				from: /Description:.*$/m,

  				to: "Description: <%= pkg.description %>"

  			},

  			{

  				from: /Version:.*$/m,

  				to: "Version: <%= pkg.version %>"

⚠ Warning: Found Underscore.js unescaped output notation: "<%=" (WordPressVIPMinimum.Security.Underscorejs.OutputNotation).
In plugins/coil-web-monetization/Gruntfile.js:

			'includes/functions.php',

  			'plugin.php'

  		],

  		overwrite: true,

  		replacements: [

  			{

  				from: /Description:.*$/m,

  				to: "Description: <%= pkg.description %>"

  			},

  			{

  				from: /Version:.*$/m,

  				to: "Version: <%= pkg.version %>"

  			},

  			{

  				from: /const PLUGIN_VERSION = \'.*.'/m,

  				to: "const PLUGIN_VERSION = '<%= pkg.version %>'"

⚠ Warning: Found Underscore.js unescaped output notation: "<%=" (WordPressVIPMinimum.Security.Underscorejs.OutputNotation).
In plugins/coil-web-monetization/Gruntfile.js:

			{

  				from: /const PLUGIN_VERSION = \'.*.'/m,

  				to: "const PLUGIN_VERSION = '<%= pkg.version %>'"

  			}

  		]

  	},

  	readme: {

  		src: [

  			'readme.txt',

  			'README.md'

  		],

  		overwrite: true,

  		replacements: [

  			{

  				from: /Requires at least:(\*\*|)(\s*?)[0-9.-]+(\s*?)$/mi,

  				to: 'Requires at least:$1$2<%= pkg.requires %>$3'

⚠ Warning: Found Underscore.js unescaped output notation: "<%=" (WordPressVIPMinimum.Security.Underscorejs.OutputNotation).
In plugins/coil-web-monetization/Gruntfile.js:

		]

  	},

  	readme: {

  		src: [

  			'readme.txt',

  			'README.md'

  		],

  		overwrite: true,

  		replacements: [

  			{

  				from: /Requires at least:(\*\*|)(\s*?)[0-9.-]+(\s*?)$/mi,

  				to: 'Requires at least:$1$2<%= pkg.requires %>$3'

  			},

  			{

  				from: /Requires PHP:(\*\*|)(\s*?)[0-9.-]+(\s*?)$/mi,

  				to: 'Requires PHP:$1$2<%= pkg.requires_php %>$3'

⚠ Warning: Found Underscore.js unescaped output notation: "<%=" (WordPressVIPMinimum.Security.Underscorejs.OutputNotation).
In plugins/coil-web-monetization/Gruntfile.js:

			'readme.txt',

  			'README.md'

  		],

  		overwrite: true,

  		replacements: [

  			{

  				from: /Requires at least:(\*\*|)(\s*?)[0-9.-]+(\s*?)$/mi,

  				to: 'Requires at least:$1$2<%= pkg.requires %>$3'

  			},

  			{

  				from: /Requires PHP:(\*\*|)(\s*?)[0-9.-]+(\s*?)$/mi,

  				to: 'Requires PHP:$1$2<%= pkg.requires_php %>$3'

  			},

  			{

  				from: /Stable tag:(\*\*|)(\s*?)[0-9.-]+(\s*?)$/mi,

  				to: 'Stable tag:$1$2<%= pkg.version %>$3'

⚠ Warning: Found Underscore.js unescaped output notation: "<%=" (WordPressVIPMinimum.Security.Underscorejs.OutputNotation).
In plugins/coil-web-monetization/Gruntfile.js:

		replacements: [

  			{

  				from: /Requires at least:(\*\*|)(\s*?)[0-9.-]+(\s*?)$/mi,

  				to: 'Requires at least:$1$2<%= pkg.requires %>$3'

  			},

  			{

  				from: /Requires PHP:(\*\*|)(\s*?)[0-9.-]+(\s*?)$/mi,

  				to: 'Requires PHP:$1$2<%= pkg.requires_php %>$3'

  			},

  			{

  				from: /Stable tag:(\*\*|)(\s*?)[0-9.-]+(\s*?)$/mi,

  				to: 'Stable tag:$1$2<%= pkg.version %>$3'

  			},

  			{

  				from: /Tested up to:(\*\*|)(\s*?)[0-9.-]+(\s*?)$/mi,

  				to: 'Tested up to:$1$2<%= pkg.tested_up_to %>$3'

⚠ Warning: Found Underscore.js unescaped output notation: "<%=" (WordPressVIPMinimum.Security.Underscorejs.OutputNotation).
In plugins/coil-web-monetization/Gruntfile.js:

	}

  },

  // Copies the plugin to create deployable plugin.

  copy: {

  	build: {

  		files: [

  			{

  				expand: true,

  				src: [

  					'**',

  					'!.*',

  					'!**/*.{gif,jpg,jpeg,json,log,md,sh,txt,xml,zip}',

  					'!.*/**',

  					'!.DS_Store',

  					'!<%= pkg.name %>-git/**',

⚠ Warning: Found Underscore.js unescaped output notation: "<%=" (WordPressVIPMinimum.Security.Underscorejs.OutputNotation).
In plugins/coil-web-monetization/Gruntfile.js:

},

  // Copies the plugin to create deployable plugin.

  copy: {

  	build: {

  		files: [

  			{

  				expand: true,

  				src: [

  					'**',

  					'!.*',

  					'!**/*.{gif,jpg,jpeg,json,log,md,sh,txt,xml,zip}',

  					'!.*/**',

  					'!.DS_Store',

  					'!<%= pkg.name %>-git/**',

  					'!<%= pkg.name %>-svn/**',

⚠ Warning: Found Underscore.js unescaped output notation: "<%=" (WordPressVIPMinimum.Security.Underscorejs.OutputNotation).
In plugins/coil-web-monetization/Gruntfile.js:

					'!tests/**',

  					'!bitbucket-pipelines.yml',

  					'readme.txt'

  				],

  				dest: 'build/',

  				dot: true

  			}

  		]

  	}

  },

  // Compresses the deployable plugin folder.

  compress: {

  	zip: {

  		options: {

  			archive: './releases/<%= pkg.name %>.zip',

⚠ Warning: Found Underscore.js unescaped output notation: "<%=" (WordPressVIPMinimum.Security.Underscorejs.OutputNotation).
In plugins/coil-web-monetization/Gruntfile.js:

	}

  },

  // Compresses the deployable plugin folder.

  compress: {

  	zip: {

  		options: {

  			archive: './releases/<%= pkg.name %>.zip',

  			mode: 'zip'

  		},

  		files: [

  			{

  				expand: true,

  				cwd: './build/',

  				src: '**',

  				dest: '<%= pkg.name %>'

⚠ Warning: Found Underscore.js unescaped output notation: "<%=" (WordPressVIPMinimum.Security.Underscorejs.OutputNotation).
In plugins/coil-web-monetization/assets/js/initialize-monetization.js:

return false;

}

/**

Output a monetization message when the state is changing.

@param string message The message to display inside the tag.

@param string customClass Any extra custom classes to add to this tag.

*/

function showMonetizationMessage( message, customClass ) {

  var elem = document.createElement( 'p' );

  elem.classList.add( 'monetize-msg' );

  if ( customClass ) {

  	elem.classList.add( customClass );

  }

  elem.innerHTML = message;

⚠ Warning: Any HTML passed to innerHTML gets executed. Consider using .textContent or make sure that used variables are properly escaped (WordPressVIPMinimum.JS.InnerHTML.Found).
In plugins/coil-web-monetization/assets/js/initialize-monetization.js:

*/

function showSubscriberOnlyMessage( message ) {

  var modalContainer = document.createElement( 'div' );

  modalContainer.classList.add( 'entry-content', 'coil-message-container' );

  var modalData = {

  	headerLogo: site_logo,

  	title: 'This content is for Coil members only',

  	content: message,

  	button: {

  		text: learn_more_button_text,

  		href: learn_more_button_link

  	}

  };

  $( modalContainer ).append( subscriberOnlyMessage( modalData ) );

⚠ Warning: Any HTML passed to append gets executed. Make sure it's properly escaped (WordPressVIPMinimum.JS.HTMLExecutingFunctions.append).
In plugins/coil-web-monetization/assets/js/initialize-monetization.js:

@param string Message from coil_params.

*/

function showBannerMessage( message ) {

  var modalContainer = document.createElement( 'div' );

  modalContainer.classList.add( 'coil-banner-message-container' );

  var modalData = {

  	content: message,

  	button: {

  		text: learn_more_button_text,

  		href: learn_more_button_link

  	},

  };

  $( modalContainer ).append( bannerMessage( modalData ) );

⚠ Warning: Any HTML passed to append gets executed. Make sure it's properly escaped (WordPressVIPMinimum.JS.HTMLExecutingFunctions.append).
In plugins/coil-web-monetization/assets/js/initialize-monetization.js:

if ( container ) {

  	container.style.display = 'none';

  }

}

/**

Get the post excerpt, if available.

*/

function getContentExcerpt() {

  if ( post_excerpt === "" ) {

  	return;

  }

  var excerptContainer = document.createElement( 'p' );

  excerptContainer.classList.add( 'coil-post-excerpt' );

  excerptContainer.innerHTML = post_excerpt;

⚠ Warning: Any HTML passed to innerHTML gets executed. Consider using .textContent or make sure that used variables are properly escaped (WordPressVIPMinimum.JS.InnerHTML.Found).
In plugins/coil-web-monetization/assets/js/initialize-monetization.js:

/**

Displays a message based on the body classes and verification outcome.

*/

function showVerificationFailureMessage() {

  if ( $( 'p.monetize-msg' ).length > 0 ) {

  	$( 'p.monetize-msg' ).remove();

  	if ( isSubscribersOnly() ) {

  		if ( isExcerptEnabled() && getContentExcerpt() ) {

  			document.body.classList.add( 'show-excerpt-message' );

  			$( content_container ).before( showSubscriberOnlyMessage( unable_to_verify ) );

⚠ Warning: Any HTML passed to before gets executed. Make sure it's properly escaped (WordPressVIPMinimum.JS.HTMLExecutingFunctions.before).

Additional info:
AFAIK it does not block installation. This was the note we got back:
The CI tool showed some errors relating to output that's not escaped. This is a third party plugin, so I can merge it anyway, as long as you all understand that you have unescaped output in the plugin. That might be okay with you; it looks like some of that output is pre-defined and already escaped manually. Or you can fix it/request that it be fixed by the plugin developer. It's your choice!

COIL-157


Mention F# as supported for Durable Functions

Mention F# as supported language for Durable Azure Functions.
See https://mikhail.io/2018/02/azure-durable-functions-in-fsharp/ for some usage examples.

@mikhailshilkov : Thanks for your contribution! The author, @cgillum, has been notified to review your proposed change.

While it is true that F# works with Durable Functions, I don't feel comfortable advertising it here without providing any end-to-end F# samples for developers to reference. If you're willing to open a PR somewhere under https://github.com/Azure/azure-functions-durable-extension/tree/master/samples and submit your F# samples, then I'd gladly take it and approve this doc update. :)

@cgillum PR is ready https://github.com/Azure/azure-functions-durable-extension/pull/268

Looks like this PR fell through the cracks. @mikhailshilkov would you mind updating your PR? We're good on the samples now so I think we can take your change to advertise F# in the docs.

@mikhailshilkov : Thanks for your contribution! The author, @cgillum, has been notified to review your proposed change.


[Feature request] Add custom sensors as PIR Sensor

I get a 3-gan WiFi switch with a build-in PIR sensor, detected as Coolkit CKA-DM4-GL.
The switch work perfectly, but the PIR sensor can not been added automatically.
After checking integration debug, the device provide additional device attributes “Alert” to describe motion detect state.
So I add custom sensors config
sonoff:
  devices:
    1000XXXXX3:
      device_class: [light, light, light]
  sensors: [alert]

The alert sensor is created, but state remains "1" permanently.
Checking debug log, I find the device only push notification “Alert: 1” when the PIR sensor is occupied, but don't push any notification to reset the status. (I think that's why rfbridge PIR sensor gets a config “timeout” to reset the state)
I use develop tool to manually set the alert sensor's state to "0" after timeout, the sensor works perfectly as expected.
So is there any way to add custom sensors as a PIR sensor, while the integration can reset the state automatically?
Or
Please consider adding this feature.

https://github.com/AlexxIT/SonoffLAN#issues


use MessageBusDocumentAccess

DocumentAccess.createDefault is deprecated
@jonmv or @aressem please merge - I tested the sample app after this fix

I'll update this to use a new injectable document access, when this is released open-soruce.


when save pai_cluster_jsonc ,show nvalid Format: : should match exactly one schema in oneOf

Invalid Format: : should match exactly one schema in oneOf

same error

remote token item soloved problem, I think the manual should said that exactly


Putting language= in querystring breaks CMS pages

Adding a ?edit&language= on any CMS page leads to a NoReverseMatch error. See here for an example.
My best guess why this happens without looking deeper: the toolbar admin language is set to the empty string which breaks language-based reversing of URLs. Solution: better sanitation of the toolbar language input.

Thanks for reporting @stefanw.
I know I've seen this one before.. think it got lost in time.


PLAT-1214: Forge Azure Container Registry

Create a registry for Forge
Create a managed user identity to push/pull to the Forge ACR
Allow the AKS system identities to pull from ACR

Since this is a module, test it like one.
Move the providers to the caller.

@steved Decided to remove all things unnecessary and simplify. Please verify.


roles vs tasks?

Not really a bug, but why do we have a tasks folder as well as a roles folder? The entries I checked in the tasks folder are the same as roles, but with their variables in group_vars.yml, which could also be made cleaner by moving the tasks to be roles with their own file for variables definition

Everything was tasks when ansible-nas started, but it became a merging
nightmare as the project grew. Over time the tasks have been moved to roles
with a few outstanding left to migrate.
On Tue, 26 Jul 2022, 15:40 Luca Simonetto, @.***> wrote:

Not really a bug, but why do we have a tasks folder as well as a roles
folder? The entries I checked in the tasks folder are the same as roles,
but with their variables in group_vars.yml, which could also be made
cleaner by moving the tasks to be roles with their own file for variables
definition
—
Reply to this email directly, view it on GitHub
https://github.com/davestephens/ansible-nas/issues/554, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFDGMFINYGX7WUXFISP7X3VV72E7ANCNFSM54WGKZDA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Fix: Typo in (wrds --> words)

wrds ---> words

Codecov Report

Merging #12175 (4523def) into main (2b78dd2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #12175   +/-   ##
=======================================
  Coverage   67.71%   67.71%
=======================================
  Files         328      328
  Lines       16991    16991
  Branches     4817     4817
=======================================
  Hits        11506    11506
  Misses       5452     5452
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b78dd2...4523def. Read the comment docs.


sched: adjust the scheduling strategy

Summary
1 Only the idle task can have the flag TCB_FLAG_CPU_LOCKED.
According to the code logic, btcb cannot be an idle task, so this check can be removed.
2 Optimized the preemption logic check and removed the call to nxsched_add_prioritized. 3 Speed up the scheduling time while avoiding the potential for
tasks to be moved multiple times between g_assignedtasks and g_readytorun.
Configuring NuttX and compile:
$ ./tools/configure.sh -l qemu-armv8a:nsh_smp
$ make
Running with qemu
$ qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic
-machine virt,virtualization=on,gic-version=3
-net none -chardev stdio,id=con,mux=on -serial chardev:con
-mon chardev=con,mode=readline -kernel ./nuttx
Impact
none
Testing
monkey test
ostest

TCB_FLAG_CPU_LOCKED means that the TCB cannot be changed by sched_setaffinity. This is not just for use in IDLE. Individual developers can use this option to lock the TCB to a certain CPU without changed by affinity.

@anchao please read the related code carefully before sending the comment. The affinity doesn't use TCB_FLAG_CPU_LOCKED, this flag is dedicated to the internal usage.


Prod IDIR login stalling/failing

When logging in with IDIR using Edge, on PROD, the authentication hangs on https://logon7.gov.bc.ca/clp-cgi-preLogon.cgi
or fails with a 400 - bad request.

Client users see the /forms page, but the forms list is empty despite having access to 1.10 and telework forms. If the user navigates to a different tab and back, the forms will show back up.

Might be related to IDIR login issues happening today: https://chat.developer.gov.bc.ca/channel/sso?msg=7zjFqoutZLmmMdBom

This occurs only when someone is inactive on the login page for more than 10 mins. They can refresh the page and login again. This issue is not a blocker, but good to keep it on our radar

We looked into the login timeout issue and discovered it happens after 3 minutes. But, we can't change that because it's set and enforced by the BC gov OIDC for IDIR, BCeID, and LDB.
Basically, if you're on the login page of IDIR, BCeID, or LDB for more than 3 minutes, you might see this error.

@Stella-Archer
If we want to make a change to that expiry time (3 minutes) or the error message we should contact the BC GOV OICD team. Please let us what you think.


Linted files and updated import ordering so linter passes again

Description
local make lint and the GitHub workflow linting do not pass due to a few files not being correctly formatted or having imports incorrectly sorted. This PR simply lints/resorts imports so these checks pass again.
Changelog description
Linted and ordered imports for a few runner.py files.
Status

[ x] Code base linted
[ ] Ready to go

@loriab just a quick fix so that linting passes again since it didn't pass on the other PRs due to certain files being poorly formatted.


Initialize Visualization after Planner to avoid segfault [ros2-master]

Starting things in the current order caused a race condition when using newer ros2 versions. This fixes https://github.com/rst-tu-dortmund/teb_local_planner/issues/196. There might be a cleaner way to fix this, but this works and should at least get the idea across. Unfortunately I can only invest limited amounts of time at the moment.

many thanks! merged!


We should move process.py to a standard CM script with dependency on this repository

I added dummy script - we can extend it later based on the feedback/requirements from users.


add covered_locs output to coverage

Hello 👋
I've been working with the @codecov team on the flow coverage report so I can upload my flow coverage report to http://codecov.io/ and use the service to analyze coverage over time.
One thing I was told was missing from the flow coverage report (in json format) was a covered_locs output.  There is uncovered_locs but no inverse for covered_locs, only the sum covered_count which makes it difficult for them to create the line-by-line report. Because the flow report only shows lines not covered Codecov never knows when lines are covered so it always results in 0% coverage. 🐼
This change simply adds covered_locs as an additional field to the json output.  I can't foresee that this could be a breaking change for anyone ingesting the json output. It does create slightly larger output files as all covered lines now need to be described as well.
I've only just given the latest coverage output to Codecov, when I hear back I'll update this if there are any additional issues but I wanted to get this conversation started in the mean time.

@clarkbw awesome job 👍

Hey I'm from the @codecov team and integrated Flow reports (given @clarkbw changes) into Codecov. I'm happy to be the point of contact if there are any questions/comments. Cheers!

Maybe @samwgoldman or @aackerman could a look?

@clarkbw I'm not on the flow team, I just happened to have touched this code last. It looks fine to me anyways. 👍

I just happened to have touched this code last. It looks fine to me anyways

Ok, thanks @aackerman!

Woo!

Anything I can do to help here?

What is the state of this?

Hi Flow Team! Was wondering if we could get an update on the state of this? We're trying to add flow coverage to our codecov reporting and so it'd be hugely helpful to have this merged.
Also, thanks @clarkbw for putting this together!
cc\ @mroch @int3

Any movement on this?

Any word on this PR? Seems like it was pulled into Phabricator, would be great if someone with access to that could respond or at least give an update if any further work needs to be done?

Rebased and updated this PR to resolve the conflict that was created when f6ae79145356dd8f0e1e1b1b985365721cd42426 was merged a couple weeks go.  😫 😢 😭

Thanks @clarkbw! This PR would be awesome to get in, appreciate you keeping it up to date so that its ready to go when Facebook gets around to it.

cc @__avik this would really help with improving flow line coverage reports. also see: https://github.com/rpl/flow-coverage-report/issues/67

Merging this, sorry for it falling off the radar.

Woo! Thanks, @avikchaudhuri


Security Vulnerability Issue<EMAIL_ADDRESS>CVE-2020-7789

🐛 Bug Report
Im using<EMAIL_ADDRESS>package that dependent on<EMAIL_ADDRESS>The one dependent on<EMAIL_ADDRESS>After a scan using Sonar dependency-check I'm getting Command Injection Vulnerability from node-notifier version 8.0.0 referenced here.
To Reproduce
Steps to reproduce the behavior:
Installing<EMAIL_ADDRESS>comes with<EMAIL_ADDRESS>that depends of<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>
After a depency check analysis by Sonar reports this vulnerability:

Expected behavior
No vulnerability should be issued
Link to repl or repo (highly encouraged)
This has already reported by Github advisory as below:

envinfo
  System:
    OS: macOS 10.15.7
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Binaries:
    Node: 14.15.0 - ~/.nvm/versions/node/v14.15.0/bin/node
    npm: 6.14.9 - ~/.nvm/versions/node/v14.15.0/bin/npm
  npmPackages:
    jest: ^26.4.2 => 26.6.3

Duplicate of #10952. You can update to 8.0.1 locally

Duplicate of #10952. You can update to 8.0.1 locally

It's a dependency of<EMAIL_ADDRESS>I can't update locally like updating package-lock.json because it is a generated file.

It's a dependency of<EMAIL_ADDRESS>I can't update locally like updating package-lock.json because it is a generated file.


error code=13 Invalid method signature supplied

Maybe something to do with the '&' in the name?
$ bash-scrobbler "Pokemon Scarlet & Violet" "Area Zero Theme"
<lfm status="failed">
  <error code="13">Invalid method signature supplied</error>
</lfm>

$ bash-scrobbler 'The Cult' 'Rain'
<lfm status="ok">
  <scrobbles ignored="0" accepted="1">
    <scrobble>
    ....

Works if I say "Pokemon Scarlet and Violet" as the artist name.  Something screwy with the '&' character?  According to the documentation there's nothing special about it.

Sign your authenticated calls by first ordering the parameters sent in your call alphabetically by parameter name and concatenating them into one string using a  scheme. You must not include the format and callback parameters. ...  Ensure your parameters are utf8 encoded. Now append your secret to this string. Finally, generate an md5 hash of the resulting string.

Found it.  Must preserve the '&' and other URI reserved chars when signing, but must encode them when doing the HTTP POST.


jsonProtocol: The select statement for type XXX needs at least one truthy value.

Bug description
Getting the error in the title on a _count query with the jsonProtocol preview feature.
When I'm not using the jsonProtocol feature, the error is not present.
How to reproduce
I've added the sample schema.prisma and code in later section.
Running the following query:
const res = await prisma.bar.findMany({
    select: {
      bar_id: true,
      foo: {
        select: {
          _count: true,
        },
      },
    },
  });

Yields the following error:
PrismaClientValidationError:
Invalid `prisma.bar.findMany()` invocation in
/...redacted_path/index.ts:7:32

  4
  5 async function main() {
  6   await prisma.$connect();
→ 7   const res = await prisma.bar.findMany({
        select: {
          bar_id: true,
          foo: {
            select: {
              _count: true
            }
          }
        }
      })

The `select` statement for type FooCountOutputType needs at least one truthy value.
    at throwValidationException (...redacted_path/node_modules/@prisma/client/runtime/library.js:167:1432)
    at fn.handleRequestError (/...redacted_path/node_modules/@prisma/client/runtime/library.js:174:6217)
    at fn.handleAndLogRequestError (/...redacted_path/node_modules/@prisma/client/runtime/library.js:174:5907)
    at fn.request (/...redacted_path/node_modules/@prisma/client/runtime/library.js:174:5786)
    at async t._request (/...redacted_path/node_modules/@prisma/client/runtime/library.js:177:10477)
    at async main (/...redacted_path/index.ts:12:15)

Expected behavior
The select: {_count: true} to return proper value.
Prisma information
generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["jsonProtocol"]
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

model Foo {
  foo_id Int @id @default(autoincrement())

  bar    Bar[] @relation("FooBars")
  bar_id Int[]
}

model Bar {
  bar_id Int @id @default(autoincrement())

  foo    Foo @relation("FooBars", fields: [bar_id], references: [foo_id])
  foo_id Int
}

import { PrismaClient } from '@prisma/client';

const prisma = new PrismaClient({ log: ['query', 'info', 'warn'] });

async function main() {
  await prisma.$connect();
  const res = await prisma.bar.findMany({
    select: {
      bar_id: true,
      foo: {
        select: {
          _count: true,
        },
      },
    },
  });
  console.log(JSON.stringify(res, null, 2));
}

main()
  .then(async () => {
    await prisma.$disconnect();
  })
  .catch(async (e) => {
    console.error(e);
    await prisma.$disconnect();
    process.exit(1);
  });

Environment & setup

OS: macOS
Database: PostgreSQL
Node.js version: v18.12.0

Prisma Version
prisma                  : 4.12.0
@prisma/client          : 4.12.0
Current platform        : darwin
Query Engine (Node-API) : libquery-engine 659ef412370fa3b41cd7bf6e94587c1dfb7f67e7 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 659ef412370fa3b41cd7bf6e94587c1dfb7f67e7 (at node_modules/@prisma/engines/migration-engine-darwin)
Format Wasm             : @prisma/prisma-fmt-wasm 4.12.0-67.659ef412370fa3b41cd7bf6e94587c1dfb7f67e7
Default Engines Hash    : 659ef412370fa3b41cd7bf6e94587c1dfb7f67e7
Studio                  : 0.483.0
Preview Features        : jsonProtocol

Thanks for the great report @dfilipidisz, can confirm the error on 4.12.0.
Internal note: protocol request issued is:
{
  "modelName": "Bar",
  "action": "findMany",
  "query": {
    "arguments": {},
    "selection": {
      "bar_id": true,
      "foo": {
        "arguments": {},
        "selection": {
          "_count": true
        }
      }
    }
  }
}

where GraphQL query for the same request is:
query {
  findManyBar {
    bar_id
    foo {
      _count {
        bar
      }
    }
  }
}

Not 100% sure GraphQL one is correct either - and if it is, not sure the transform could be done on the client side.

Workaround until fix is released: explicit sub-selection on _count. For example from this post, that would be:
const res = await prisma.bar.findMany({
    select: {
      bar_id: true,
      foo: {
        select: {
          _count: { bar: true },
        },
      },
    },
  });

@dfilipidisz  the fix will be released in 4.13.0 version next week.
If you want to try it out before that, you can install 4.13.0-dev.31 snapshot version. Let me know if it helps and thanks a lot for reproduction again.

excited for this!

@SevInf Thanks for letting me know! I've tried jsonProtocol with 4.13.0-dev.31 and indeed the issue is gone :) Thanks!


Modded blocks are recorded incorrectly

The biggest difference from the original version: Mishang Urban Construction installed
My server load log : log
My client log : log
Everything seems to be working fine when I connect to the server, but when I use the replay mod to load the mcpr file downloaded by the server, the block records are all wrong.
For example, my walls turned into water, and the sky was filled with blocks that shouldn't be there.
I didn't find any issues about the bug after adding a mod that can add blocks, so I posted this issue hoping to solve this problem.

My native language is Chinese, the above content uses Google Translate.  : )

Thanks for the report, I have released a more up to date version of ServerReplay for 1.20.1, which you can download here, see if this fixes your issue.
If not, can you re-produce this issue with the new version then can you able to send a copy of the replay file?
And are you able to reproduce this with just the Mishang Urban Construction mod and it's dependencies (without any of the other mods)? If so, could you also send a copy of that replay file.
You can upload them here (rename the .mcpr files to .zip) or you can upload them here: https://filebin.net/ and send the link

local pack without replay mod, I install it by myself(


DSA & Python basics

💥 Proposal
I will be adding assignments question that I had used as a bigger to master data structure also coding question and solutions of Python basics (Including linked list, pattern, tree).
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


flaky test testApplyingTwoDistinctSocketOptionsOfSameTypeWorks

01:03:41 - >>> Test Case '-[NIOTests.ChannelTests testApplyingTwoDistinctSocketOptionsOfSameTypeWorks]' started.
01:03:41 - >>> Fatal error: leaking promise created at (file: "/SRCROOT/Tests/NIOTests/ChannelTests.swift", line: 2585): file /SRCROOT/Tests/NIOTests/ChannelTests.swift, line 2585

in macOS CI

happened just once almost a year ago. Also there were a bunch of changes in this area, let's close.


Revive CocoaLumberjack

List of things to do

[x] admin permissions from Robbie to @rivera-ernesto @bpoplauschi
[x] set GitHub topics for the projects - help discoverability
[ ] 1.A - Add new collaborators:

[x] @sushichop
[ ] @jcbertin
[x] @nrbrook
[x] @diederich
[x] @ksuther
[ ] @nekrich
[ ] @acacio88
@ole - declined
[x] @hhanesand
[x] @ffried
@Coeur - declined
[ ] @an0
[ ] @0xced
[ ] @DD-P
[ ] @MelnykTaras
@pombredanne - declined
[x] @lolgear

[ ] 1.B - Automated generation of list of contributors (per release)
[x] 1.C - Create BetaTesters team @CocoaLumberjack/betatesters
[x] 1.D - Create and publish website: https://cocoalumberjack.github.io/
[x] 2 - triage the open issues - from 114 to 28 - thanks to the new team members and the Stale bot :)
[ ] 3 + 4 - Update CONTRIBUTING.md
5 - Automate tasks

[x] install Stale bot to check/close old issues
[ ] install behaviorbot request-info to check each issue has the required info
[ ] release pipeline with https://github.com/semantic-release/semantic-release - to be investigated
[x] configure Danger for coding style checks on each PR #962 #956
[ ] generation of CHANGELOG with github-changelog-generator

[ ] 6 - Need a decision for periodic releases

@CocoaLumberjack/collaborators
Current status of CocoaLumberjack
For a while, the people mentioned here and myself, we managed to keep this project running, releasing versions, responding to issues, fixing, ...
I think it's very clear we have reached a point where the project looks abandoned (well, not entirely, but issues are pilling up, we are not as proactive in adopting new releases of Xcode, Swift, ...).
I want to change that ...
Old approach
At least for myself, but for the rest of you as well, I think we just freed up time based on availability and just worked the way we thought was best, in bursts. No big plan, no roadmap, adding very few contributions. And then became distracted by something else in our lives, issues and pull requests pilled up here, then we had to free up another chunk of time and so on.
I don't think I can keep doing it this way.
Open Source Guide
At some point, I came across the Open Source Guide, a collection of guides for open source projects and I just think that information gathered there is super valuable, since it comes from people that had different roles in open source projects. I would like us to implement some of the ideas there.
Proposals
I have an initial list of proposals, but I do want you guys to contribute or at least tell me what you think
1 - Building a community
I think this is the most important item here, because we do need all the help we can get, but also we want people to interact more, share their ideas. Also, there might be people who are willing to contribute, but are not sure about how or if they could add value.
1.A - More maintainers
Open Source Guide - Growing your community mentions a strategy called The Pull Request Hack. Feel free to read about it, it basically favours giving commit access to any contributor, if they have a decent GitHub profile, show skill and their contribution is somehow useful. While I agree partially with this article, I think there is a good number of people who show interest in our project and that we can ask to become maintainers.
Just look at the contributors list from the past year, you will notice people like sushichop nrbrook ole and so on (I'm not using @github_username so I don't notify them ... yet).
The article does advocate how people become more responsible and more willing to do more when they get write access to a repo.
1.B - List of contributors
I think using some tools we can generate a list of contributors, generic one or per release and post it on GitHub. This should encourage people to contribute so they put their name out there. Small incentive.
1.C - Teams
Now we have https://github.com/orgs/CocoaLumberjack/teams/collaborators which we can use to notify all the collaborators (using @CocoaLumberjack/collaborators).
One idea is to have another team that has no write access, but contains a list of Beta testers, where we can notify people of publishing a beta release or any release at all.
1.D - Website and Newsletter
I think publishing a newsletter combined with periodical releases (like once every month) can bring even more engagement to the project.
Not sure about the way to implement this, but one idea is to use GitHub Pages and create a website for our project where we can put documentation, tutorials, publish releases, ...
Reaching through to the users of our project is something I would push for.
2 - Code and issues refresh
We need to triage through the 100+ issues, find and fix the most important ones, update with the latest Xcode and Swift changes, release.
We can extend the list of contributors, but we can't build the community until we start (not necesarily after we finish) refreshing the code and issues.
3 - Long term vision and Contributing guide
I think we can do a lot better in explaining what contributions we accept, what help we need, what the long term project vision is. All this should be better explained in the README.md and CONTRIBUTING.md files.
The existing CONTRIBUTING.md is more defensive, now that I have read it with new eyes, pushing people away rather than getting them closer.
We are lacking an explicit long term vision.
See the proposals I made for another project where I contribute: https://github.com/rs/SDWebImage/pull/2416/files
My idea is to encourage people to contribute, even if it's not code at first. We can mentor the ones just starting up. Every contribution is valuable. See Orta's contribution to CocoaPods, he mainly worked on documentation and tooling.
So from adding documentation, tutorials, helping triage the issues, respond to issues, respond to Stack Overflow to small coding contributions to big refactoring, I think they are all beneficial to the project.
4 - What is the long term vision
We must accept that this project belongs to a community and sometimes, we might not agree with the direction asked by that community.
5 - Automate tasks
I think we can use even more of the existing tools in automating work (we already using Travis for continuous integration or Codecov for code coverage)

I've seen some projects using a bot that can, for example, close issues that are not updated for a while (https://github.com/apps/stale)
we can automate the release pipeline (i.e. https://github.com/semantic-release/semantic-release)
we can use https://github.com/danger/danger to check and make it clear what the coding style should look like. This will run for each PR
we can use a tool like https://github.com/github-changelog-generator/github-changelog-generator to generate the CHANGELOG
...

6 - Periodic releases
Here I just want us to discuss if you think releasing a new version every (let's say month) sounds beneficial.
We would have a clear timeline and make sure the contributions are published without delays.
7 - Overall tone
I think we can do a lot better here as well, starting with myself. Making sure people have a great interaction with our team will make them more likely to come back.
We should appreciate the time they took to use our project, get back with issues and PRs and we should communicate this. Then make sure we are nice and explain what we expect or why we can't/won't accept their contribution.
Statistics also show it's important to respond in a decent amount of time (up to a week, but preferably in a few days).
8 - Getting things moving
Keeping the conversation going towards a resolution and action items is something we need to have in mind. We all have dealt with issues or PRs that deviate or remain in a state where we don't know how to move forward, people lose interest and just abandon their contribution.
Let's make that effort in making sure we do move.
Now when we will go through the list of existing issues, most of their authors will not respond nor remember what the issue was, so we will just close it with no resolution. This is not ideal.
9 - Encourage even contributions that don't match the vision
Even if we see contributions that are not a match for the project per se, we can still do something about it. We can tell people to just fork and maintain that fork. We can build some pluginable pieces.
Example: At SDWebImage, we build plugins for different image formats and created some projects under the same organisation that are dedicated plugins. People can contribute to those dedicated projects or just create their own without us having to modify the core project. Responsibility is shared.
THIS IS A DRAFT ISSUE - I WILL MODIFY IT AS WE DISCUSS

The project is far from abandoned. Thousands of people use it everyday and actively look for updates, we just need to hand the project to the most active users and they should do the same when new contributors show up.
I think it all starts by owning the project so we can freely add contributors.

@rivera-ernesto thanks for responding.

The project is far from abandoned.

I did not mean abandoned as in people do not use it. Actually, statistics show it is heavily used. https://libraries.io/cocoapods/CocoaLumberjack/usage
and https://libraries.io/carthage/CocoaLumberjack%2FCocoaLumberjack/usage
In reality, all our versions are used by at least a handful (but that is a different topic).
That is why I thought we are not doing a good job maintaining it, as the number of issues is already big (>100) and we are just reacting to trivial PR's.

I think it all starts by owning the project so we can freely add contributors.

I agree. But even if we need to ask Robbie to add them, that would still work.

@bpoplauschi
Do you really need it?
Well, I use CocoaLumberjack several years ( maybe from 2012 ).
Things have changed and even Apple released several good stuff that diminished necessity of open source.
Stories are different in Apple ecosystem.
Code smells:
In 2011-2012 they released their security framework to throw out OpenSSL.
In 2016 (?) they released their graphics framework Metal and in 2018 they throw out old hardware that doesn't support it. But it was an evolution cause OpenGL and OpenCL are the mess.
Too complex:
In iOS 7 they released URLSession to make our life simple. I was surprised how simple it is today to handle network requests when I rewrote network part in one of my projects. Really I do not need AFNetworking anymore.
In iOS 10 they released NSPersistentContainer and, well, I was so disappointed that I couldn't change my project deployment target to iOS 10. It is so simple. And MagicalRecord was gone.
And...
In iOS 10 they released os_log. Well, I assume that it is not used widely only by one reason - import statements are ambiguous.
Maybe it is time to leave it?
All these graphics show that people are lazy and they do not adopt modern approaches as fast as they could.
Me too, I still have CocoaPods Manager in project and several dependencies are abandoned one or two years ago.

@sushichop we noted your interest in this project and you helping out with PRs and responding to issues.
We would like to invite you to become a maintainer – no pressure to accept! At this point we are only a handful of people doing this in our spare time. I am working on writing down the expectations from contributors, but basically we want contributors to provide ideas, keep the ship shipping and to take some of the load from others. It is non-obligatory; we’re here to get things done in an enjoyable way.

@bpoplauschi
Wow, I am really excited and honored to be invited. I gladly accept it!
(Although I may be busy with other work for a while, however) I would like to contribute as possible!.
I think more documentations are needed and reduce a lot of issues.

@sushichop Cool.
@robbiehanson can you please add @sushichop to the project (organization)?

Sadly getting @robbiehanson attention is one of the major problems of this project...

I agree. We then need to ask him to grant us permissions for the organization.

Have not we received reply from @robbiehanson ?
If answer is no, I feel sad...😭 Actually, this situation is not good.
How can we improve this situation?

@sushichop no response from him. I will try to contact him via a different channel

@bpoplauschi I hope it will go well:)

I think we could deprecate this podspec and move to a new organization/repository where we can freely add contributors.

@rivera-ernesto I agree about this option. I have emailed Robbie and waiting for a response before. I have asked to make us owners as well so we can manage the project properly. If he doesn't, I agree we should just move to a new org.

I have added @bpoplauschi & @rivera-ernesto as owners.

Appreciate it @robbiehanson

@sushichop I have sent you the invite

@robbiehanson @bpoplauschi @rivera-ernesto
Thank you very much!

@bpoplauschi
I have joined CocoaLumberjack organization.
Thanks again😁

Great news!
I think now we can add as contributors active users who are actively using CocoaLumberjack.

Yes @rivera-ernesto, we can:

compile a list of people like @sushichop that were interested in the project in the past months (with PRs issues and in general contributing to the conversations) - we can start from https://github.com/CocoaLumberjack/CocoaLumberjack/graphs/contributors?from=2017-08-07&to=2018-08-08&type=c
also we can develop a habit of inviting people as contributors when they make a contribution (thus keep the momentum)

Now that we have more contributors we can start speeding up new releases for already merged changes. Just ping me with your email if you want access to publish new CocoaPod versions.

@nrbrook joined our team. Welcome.

Hi, looking forward to contributing what I can :)

@ffried joined the team. Welcome :)

Thanks for the invitation. Glad to be part of the future of CocoaLumberjack. 🙂

@diederich also joined the team. Welcome!

🎉 🎈 👋

We're still actively using lumberjack in our projects, I'm happy to help where possible.

Great @ksuther. I will send you an invite to our org in a few minutes.

Thank you, but I'm currently not interested in CocoaLumberjack. I've got so much to do already on the projects I'm already maintaining.

@Coeur no problem :) Good luck with your projects and feel free to contribute to CocoaLumberjack if and when you consider.

@bpoplauschi I think you can now edit your original post:

Current status of CocoaLumberjack = Abandoned

😉

Anybody ran CocoaLumberjack through the Swift 4.2 converter?

@adib As of 49d32e5910bb277e81491bd0d35726e91dd29514 it should work with Swift 4.2

Welcome @hhanesand to the team :)

I think we can close this issue, the project has more traction now. We implemented some of the proposals in the list.
@CocoaLumberjack/collaborators what do you think? Do we need to complete anything before considering this issue resolved?

Thanks for this issue(suggestion)!
There are no additional suggestions from me.
If aynthing, IMHO, more frequent release may be better about hot fix☺

@CocoaLumberjack/collaborators
I would like to suggest to refresh current status of Communication section in Readme.
Does anybody from Contributors answer questions on SO?
Is it better to open a gitter channel to catch feedback and continue discussions in messaging format?
Your thoughts?
oh, and also I would like to suggest releases on regular basis. No? One small release in 6 weeks or so and one big in a year? ( Like Apple do, heh, but not so rigid ).

@lolgear I agree about the idea of one small release every 6 weeks or so and one big per year.

@CocoaLumberjack/core
All right🙂 The latest CocoaLumberajck 3.5.2 was released on 15 Mar.
So we should release the next version(3.5.3) next week, shouldn't we?

@sushichop
Do you know a service or a bot which creates release notes each 4-6 weeks.
OR
It can be a great bot for github :)

@lolgear
Unfortunately I don't know it... But I think your idea is nice🙂

@lolgear Any reminders app can do that. 😉
The release notes should be up to date at any given time on master. All PRs are encouraged to update the change log (there's a Danger check for that).
This means that a release can be created at any given time by just using what's on master.
Some changes are not worth mentioning in the release notes and PR creators can decide for themselves if they want to mention them.
Btw. this is how the Swift repo works as well.

I see.

@ffried @lolgear
So should we use Danger for it?

AFAIK Danger can't do regular reminders. Danger just checks pull requests. It currently does emit a warning if the release notes were not updated in a PR (if it's not marked as trivial).

I see. Thanks! @ffried

@ffried hey, new avatar, really nice! so Celtic :)
But I want a robot hand which sends emails/create milestone/create release notes each 4-6 weeks. It only lives in Github and sends warning about stale releases. Like stale bot, yes, but with other activities

Look at release notes every day.
Measure time between last release and [NSDate date].
Create milestone (?) for next release if measured time interval is greater than 4 weeks?
4*. Send emails if time interval is greater than 6 weeks.

@lolgear Thanks 🙂

cat  CHANGELOG.md. Now what? 😉
...
What milestone should be created? E.g. we are at 3.5.3. Will the next release be 3.6.0? Or 4.0.0? Or just 3.5.4? While this is theoretically defined by SemVer, it's not that easy to classify the changes since the last release programmatically. In fact, this is currently easier for humans.
That's what your regular reminders app can do. Well not emails, but a reminder nevertheless.

I think what we do need is a person (or two) that is responsible for releases. This person then has these reminders and is responsible for deciding what the next version will be. The latter can also be a group discussion, but it's initiated by that person.
Last but not least, this person is doing the releases (Github, CocoaPods, ..., ...).

Also, services based on polling are bad services. 😉

Bot doesn't want to revive 😢

@hhanesand I've opened #1009 for that but He flushed it out :)


How to specify configuration when using Mobile Page Objects?

I applied the Mobile Page Object pattern for iOS and Android (with base, android and ios folders) which works great.
Now, to make things more portable I need to load a specific driver configuration (ios or android) at runtime.
For now, when running a test on the command line I just set a environment variable and evaluate that in the setUp function. If it's ios I tell config_files.set_config_properties_filenames to load iOS specific config files (we currently use the default unittest framework, no pytest or nose)
Is this the way to go or is there some built-in logic?

For the moment it's the way to do it using unittest, pytest or nose.
In behave there is a built-in way:
behave -D env=ios

ok, thanks. Actually I ported this pattern to my unittest files from the behave example in your docs ;-)

The system property Config_environment can be used to load specific config files. For example, if Config_environment value is android, Toolium configuration will be loaded from properties.cfg, android-properties.cfg and local-android-properties.cfg files:
$ Config_environment=android nosetests web/tests/test_web.py
$ behave -D Config_environment=android