Buttons does not works after the last update (except the heading button)

Hello, after the last update of the chrome extension (1.3), all the buttons does not works, except the heading button) on my site. You can try it there : http://ici.radio-canada.ca/
If someone have the same problem? Do you know what to do to fix this?
Also, when we have a image inside a link (with a explicit alternative text), the tool still put an error but is not.
If you have any question about my issues, please let me know!
Thanks,

Hey @Blagada,
The extension is maintained by someone else, but I imagine any errors are probably our fault. Do you have a screenshot of your browser console that I could see? Also, if you could point me to a URL to test (no worries if you can't!) that would be very helpful.
Thanks for reporting - sorry for the inconvenience :(

Hello ^_^!
This is the error I find on my browser console :  tota11y.min.js:40 Uncaught TypeError: Cannot read property 'properties' of undefined.
And you can try it by your self there : http://ici.radio-canada.ca/
Thanks for your response. Your chrome extension is really useful for us ^_^!

Hey @Blagada,
Looks like you're using requirejs - which unfortunately causes Accessibility Developer Tools (which powers tota11y) to break. This issue was reported in #85, but thank you for the extra data point.
I'm going to close this issue as a duplicate, but please follow along in #85 and we'll be sure to fix it soon.
Again, sorry for the trouble :(

Oki, thank you for your help!


Automagically assign issues to projects

backlog & bugs

(not actually a bug, just testing the project assignment)

COMPLETE


Q.enumerateTypes ignores type when any namespace part doesn't start with capital letter

Some types like rootname.namespacePart.Type are ignored by Q.enumerateTypes.
I've found that it's because condition
if (k.charAt(0) < 'A' || k.charAt(0) > 'Z')
 continue;

When full type name is rootname.NamespacePart.Type everything works properly.

This is by design. Every function in javascript can potentially be a type. Serenity has to enumerate all types in root namespaces. It limits this journey to members whose name starts with capital letter to skip ordinary functions. Always use Pascal case for types, both in C# and Javascript.

Also namespaces.

Thank you for explanation. Response time is impressive.  :)

There is workaround for such special case:
Add
Q.Config.rootNamespaces.push('rootname.namespacePart');
to
ScriptInitialization.ts

I wouldnt recommend that


Update packet-networking submodule

This will bring in support for Ubuntu 20.04

[ ] Changelog updated

The merge commit was due to me having GitHub automatically rebase the PR. :+1:


Improve select list functionality

Is your feature request related to a problem? Please describe.
In the old seleniumlibrary checking list items was pretty easy since you could get every list item in a @{list} like so:
 ${theList}    Get List Items    id:cars
    Length Should Be    ${theList}    4
    Should Contain    ${theList}    Volvo
    Should Contain    ${theList}    Saab
    Should Contain    ${theList}    Mercedes
    Should Contain    ${theList}    Audi

Example html:
<label for="cars">Choose a car:</label>
<select name="cars" id="cars">
  <option value="volvo">Volvo</option>
  <option value="saab">Saab</option>
  <option value="mercedes">Mercedes</option>
  <option value="audi">Audi</option>
</select>

This is hard to replicate in browser library since keyword Get Selected Options forces you to select an option.
Describe the solution you'd like
A solution like this should work, right now it just returns none
*** Settings ***
Library        Browser
*** Test Cases ***
List
    New Browser        headless=False
    New Page    file:///list.html
    ${list}    Get Selected Options    id=cars    text
    Log To Console    ${list}

Describe alternatives you've considered
Using Get Text will return all the items but they are not list-like, just a string separated by newlines. It might be an option to have that return a list if there are several items.

I do not quite see the problem, the Get Select Options returns a list selects. The Get Selected Options only selected options.


Charge Session Data

I also speak German
Is your feature request related to a problem? Please describe.
For tax reasons, we would like to count the energy charged into each of their vehicles.
Our KEBA EVSE logs the total energy and energy per charge session, and it's displayed on the evcc UI as well.
Describe the solution you'd like
As a developer, I would like to access the data on current and past charge sessions, including which charge point and vehicle was charged.
Another workable solution is to get reports on new charge sessions via MQTT so I can store the data away separately.
Describe alternatives you've considered
I understood there is an integration to write data to Influx DB. Does this include the charge session data?
The documentation (https://docs.evcc.io/docs/reference/configuration/influx/) on the scope of data loaded to Influx is very sparse currently.
I have considered pinging the KEBA station separately to pull the data with a custom script. Can evcc handle receiving the responses caused by a different program requesting data from the charge point? Based on https://github.com/evcc-io/evcc/blob/586803646172d1745096c6ef31beef6a3b2539e3/charger/keba.go#L135 and particularly the matching in https://github.com/evcc-io/evcc/blob/586803646172d1745096c6ef31beef6a3b2539e3/charger/keba.go#L109 this could also work.
I can contribute code in whichever direction will be good for both the project and my use-case.

Die Energy je Fzg ist doch im Sessionlog schon enthalten- was fehlt da noch?

Ah danke, ich find's wohl gerade nicht, in den API-Docs steht nur etwas von State - ist das dort dabei?

Yep 👍🏻


Recurring jobs are failing after 1 day

We are running recurring jobs continuously  for every 30s but it is working for one day on production after one if schedule the job its not working and not executing the job.
Please help me ASAP.

It sounds like this more likely an issue with Resque Scheduler... All this gem does is convert the standard schedule format into ActiveJob-ready ones
Try doing bundle exec rails runner "puts Resque.schedule.inspect" on your production server before and after it stops working, see if they're the same...
Also make sure that Resque::Scheduler.dynamic returns false; if it's not, you have something overwriting it..


Rebaseline performance tests

Because the failure blocks master.

The merge queue build has failed. Click here to see all failures.


Document the CAs that are excluded from certificate rotation

The Services, mysql, redis and rabbitmq CAs are excluded from maestro
cert rotation

[#171869449] Improve the Certificate Rotation Docs in 2.9
Signed-off-by: Ming Xiao<EMAIL_ADDRESS>

Thank you @mingxiao


New Cython pulse summary: rise time computation is wrong somehow

Original report by Joseph Fowler (Bitbucket: joe_fowler, ).

Many of my lower-energy pulses are failing to make my usual cuts. It turns out that the rise time calculation is coming out too low. A pulse with a clear 0.2 ms rise time is labeled as having 0.05 ms rise time, and so on. Since I cut for a minimum, as well as a maximum, rise time, this is a problem.
I'll investigate, but @jojo978 might know what the problem is.

Original comment by Dan Becker (Bitbucket: danbek, GitHub: danbek).

Bug fix in summarize_data: was computing rise times incorrectly.
Fixes #29.

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Bug fix in summarize_data: was computing rise times incorrectly.
Fixes #29.

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Issue #32 was marked as a duplicate of this issue.


collection submit fail

Sponsors SeaweedFS via Patreon https://www.patreon.com/seaweedfs
Report issues here. Ask questions here https://stackoverflow.com/questions/tagged/seaweedfs
Please ask questions in https://github.com/chrislusf/seaweedfs/discussions
Describe the bug
when assign fid with collection, error raise as follows ,the url is http://XXX.XXX.XXX.XXX:9333/dir/assign?collection=works
{
"error": "cannot grow volume group! Failed to assign 12: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp XXX.XXX.XXX.XXX:19335: connect: connection refused""
}
But if I access with no collection param, it's successful。 Such as the url:  http://XXX.XXX.XXX.XXX:9333/dir/assign. The response as follows:
{
"fid": "2,0152e6212c59",
"url": "XXX.XXX.XXX.0:9335",
"publicUrl": "XXX.XXX.XXX.0:9335",
"count": 1
}
System Setup

List the command line to start "weed master", "weed volume", "weed filer", "weed s3", "weed mount".

cd /usr/local/weedfs

nohup ./weed -v=2 master -mdir=/usr/local/weedfs_data/master -port=9333 -defaultReplication=001 -ip=XXX.XXX.XXX.XXX &>>/usr/local/weedfs_data/master/wdfsmaster.log &

sleep 1s

nohup ./weed -v=2 volume -dir=/usr/local/weedfs_data/vola -port=9334 -max=20 -mserver=XXX.XXX.XXX.XXX:9333 -ip=XXX.XXX.XXX.XXX   &>>/usr/local/weedfs_data/vola/wdfsvola.log &

nohup ./weed -v=2 volume -dir=/usr/local/weedfs_data/volb -port=9335 -max=20 -mserver=XXX.XXX.XXX.XXX:9333 -ip=XXX.XXX.XXX.XXX &>>/usr/local/weedfs_data/volb/wdfsvolb.log &

nohup ./weed -v=2 filer -port=9336  -master=XXX.XXX.XXX.XXX:9333 -defaultReplicaPlacement=001 -ip=XXX.XXX.XXX.XXX &>>/usr/local/weedfs_data/filer/wdfsfiler.log &

I install 1 master,2 volume server, 1 filer server in one PC.

OS version

weed version:  version 30GB 2.91 09cd00f356c69b12d4f3b7caa8e16255031cc330 linux amd64

if using filer, show the content of filer.toml

[leveldb2]
enabled = true
dir = "/usr/local/weedfs_data/filer/leveldb2"                    # directory to store level db files
Other configuration in "filer.toml" is default
Expected behavior
return fid and url , upload file to collection successfully.
Screenshots

Additional context
Even if I clear the data folder of master/volume, then reboot, it still not works.

this should be not related to filer.
Could you please make a docker compose file to reproduce this?

this should be not related to filer.
Could you please make a docker compose file to reproduce this?

I just use the binary  in "linux_amd64.tar.gz" downloaded from the page "https://github.com/chrislusf/seaweedfs/releases". Is there a problem?

This is fine

But it caused the above problems, can you help me solve them

This is fine

But it caused the above problems, can you help me solve them

I have fixed it, this not the problem of weedfs, thanks


Why is C++ infinitely better than GD script?

Sorry for asking question here.

Better simply in terms of performance. Generally I've heard it's about 60x faster than Godot script. The trade-off is that gdscript is much easier to use. Personally I like the happy middle ground of c#: it's about 10x than Godot script but not as hard to learn as C++

Thanks for the input.  Yikes 60x, I'll have to learn C++ then 😭
I wonder the performance of GD in 2D.

No worries. And it's only an issue sometimes, you can find ways to optimize GD script code to make it run smoothly. Especially for 2D which is naturally faster than 3D it's pretty good


Updates to checkout page

Removed all address / billing inputs
Reorganised order summary box
Added trigger abandoned cart email button

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

We're missing the "Back to shopping cart" link on the top left. You can use the previousPageLinkProps prop on Layout to achieve this.

While we're making updates, let's also use the LoadingFallback component instead of hand-rolled markup for the loading indicator.

Since there isn't a cart subtotal anymore, I'm getting a console error in the analytics handler file. Can you please remove the subtotal being passed to AnalyticsHandler.checkoutStarted from both the handler itself and the function call?

Seeing Error in created hook (Promise/async): "TypeError: Cannot read property 'email' of null when loading the page unauthenticated

Ok hopefully most of those should now be addressed - I'm not seeing the first_name error myself but I suspect that was only happening because of the previous email error which is now fixed

Look good now :)


Sort command permanently changes list

sort a -> works and sorts in ascending order
list -> does not list out the list in original order


Inject CSS into JS?

Should we get rid of standalone CSS file and inject styles dynamically in JS? If we do so, https://github.com/limonte/sweetalert2/issues/422 will be fixed for free and many users will get a better DX (developer experience).
There's probably some rollup plugin which will help up handle this, but I didn't perform any research on that.
I'd like to hear your opinions and technical suggestions how to implement this in a nice and efficient way.
cc @toverux @samturrell

Personally, I prefer separation of intent, and the flexibility for custom styling of separating CSS and JS (i.e. authors being able to easily restyle stuff without having to dive into the JS itself)

Agreed, I think it's better to keep these separate. This gives more flexibility for the developer implementing the plugin into their workflow.
However, that said it may be possible to generate an entirely separate bundle to add this functionality e.g. sweetalert2.all.js which includes the css-in-js.

However, that said it may be possible to generate an entirely separate bundle to add this functionality e.g. sweetalert2.all.js which includes the css-in-js.

Sounds like a perfect option :+1:

I agree with the arguments above. I've already mentioned the possibility of injecting Swal's style at runtime in a dynamically-created

Fixed with #644
KUDOS to drunk ninja master @samturrell :beers:

Just update the demo of using SweetAlert2 with Webpack, looks great! https://github.com/limonte/sweetalert2-webpack-demo/commit/d8b2631967654bc4a1af2dfb091e07f17138a645#diff-168726dbe96b3ce427e7fedce31bb0bc
@toverux sorry for probably stupid question, but could you please help me to understand

So : sweetalert2.all.js + docs seems to be a good solution as long as we don't set it as the default entry point (main).

why don't we want all.js as the default entry point?

why don't we want all.js as the default entry point?

Well, I guess I'm just used to have the control on vendor stylesheets "by default". But as the new solution seems to be easier for most people, and since it's still possible to get the style aside of the JS if needed, I'm not hostile to change that, at all :)
However, I think we should wait for the next major to change it then. Otherwise people will get Swal's styles downloaded and applied two times. Not a breaking change per se, but, erh.

Well, I guess I'm just used to have the control on vendor stylesheets "by default". But as the new solution seems to be easier for most people, and since it's still possible to get the style aside of the JS if needed, I'm not hostile to change that, at all :)

Thanks! :+1:

However, I think we should wait for the next major to change it then. Otherwise people will get Swal's styles downloaded and applied two times. Not a breaking change per se, but, erh.

Yeah, that's kinda a breaking change as I understand correctly. So next major it is :+1:

that's kinda a breaking change as I understand correctly

Not in the sense that it wil break or pop errors, but not much better, technically speaking.
(Tagging the issue with "next major" even if it's solved, so we can remember to change that)

Perfect, thanks!

The combined JS+CSS version is now default: https://github.com/limonte/sweetalert2/releases/tag/v7.0.0


Deploy 075 - Upgrade OETH AMO Strategy

Deployed contracts

Contract
Address

ConvexEthMetaStrategy
0x5c93E05783EA4D0D968c7A2C0cDfFCEfC711b213

Address

Deployer
0x3Ba227D87c2A7aB89EAaCEFbeD9bfa0D15Ad249A

Proposer
0x6a6D776120f7e4a8dba5F6bF49b85cb340Cfe241

Proposal
Id:<PHONE_NUMBER>0413220443859027907216814653548117220338896790750636626793224597926
INFO: Args: [
  [
    "0x1827F9eA98E0bf96550b2FC20F7233277FcD7E63"
  ],
  [
    {
      "type": "BigNumber",
      "hex": "0x00"
    }
  ],
  [
    "upgradeTo(address)"
  ],
  [
    "0x0000000000000000000000005c93e05783ea4d0d968c7a2c0cdffcefc711b213"
  ]
]
Gas price (gwei): Regular=13.45359381 Premium=20.180390715
INFO: Next step: go to Gnosis Safe Web -> New Transaction -> 👷 Contract Interaction
INFO:   - enable "Custom Data" toggle
INFO:   - set "Enter address or ENS name" to: '0x3cdD07c16614059e66344a7b579DAB4f9516C0b6'
INFO:   - set "ETH value" to: 0
INFO:   - set "Data (Hex encoded)" to:
INFO: 0xda95691a00000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000000e0000000000000000000000000000000000000000000000000000000000000012000000000000000000000000000000000000000000000000000000000000001a0000000000000000000000000000000000000000000000000000000000000022000000000000000000000000000000000000000000000000000000000000000010000000000000000000000001827f9ea98e0bf96550b2fc20f7233277fcd7e630000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000001275706772616465546f28616464726573732900000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000200000000000000000000000005c93e05783ea4d0d968c7a2c0cdffcefc711b21300000000000000000000000000000000000000000000000000000000000000395570677261646520746865204f45544820414d4f207374726174656779207769746820706567206b656570696e672066756e6374696f6e732e00000000000000

[x] All deployed contracts are listed in the deploy PR's description
[x] Deployed contract's verified code (and all dependencies) match the code in master
[x] The transactions that interacted with the newly deployed contract match the deploy script.
[x] Governance proposal matches the deploy script
[x] Smoke tests pass after fork test execution of the governance proposal


RBAC filter only applies to associations and not attributes

https://bugzilla.redhat.com/show_bug.cgi?id=1431822
The RBAC filter was being applied to regular attributes like name etc.
It only applies to associations which point to other VMDB objects.
Links

https://bugzilla.redhat.com/show_bug.cgi?id=1431822

Steps for Testing/QA
Described in BZ

Looks good to me.

Backported to Euwe via https://github.com/ManageIQ/manageiq/pull/14352


Creating datasets from within the emulator

For testing we create new datasets for each test suite. Would it be possible to add this to the emulator?

BigQuery API has an API for dataset deletion, so please use it from the client SDK.

Neat - didn't realize that this is implemented (I guess the required dataset command line parameter threw me of). Thanks!


Model 'ja_ginza' is not a linked spaCy model

I have linked ginza with "python -m spacy link ja_ginza ja"
but when i run "rasa train",it returns
"ERROR:rasax.community.api.blueprints.models:500, Internal Server Error, body='b'{"version":"1.9.2","status":"failure","message":"An unexpected error occurred during training. Error: Model 'ja_ginza' is not a linked spaCy model.  Please download and\/or link a spaCy model, e.g. by running:\npython -m spacy download en_core_web_md\npython -m spacy link en_core_web_md en","reason":"TrainingError","details":{},"help":null,"code":500}''
how did it happened?

solved


Meteor._wrapAsync has been renamed to Meteor.wrapAsync

Meteor._wrapAsync has been renamed to Meteor.wrapAsync
where find Meteor._wrapAsync ??

I don't know, I never using it. Maybe some of meteoris package did. :D


Infer return type from reflection if no phpdoc given

Up until now, to have the get…Attribute return a useful type information in the class phpdoc, it was necessary to specify the @return annotation; otherwise the result was always mixed.
This now adds the capability to derive the type from the reflection itself.

Example:function getFooAttribute(): string
{
}

before  * property-read mixed $foo
after  * property-read string $foo

Note that the docblock is still the authoritative source if provided. The reason is that phpdoc expressiveness / supporting tooling still exceeds PHPs type capabilities.
But this also means if the docblock is wrong, so will the type be and this PR won't fix that.
OTOH it removes the need for a docblock for the simple cases (e.g. no iterables of a type).
Tests with lots-o-variations included.
This is in fact already implemented for the elseif (!method_exists('Illuminate\Database\Eloquent\Model', $method) case, but this part in fact prefers the native type over the docblock; not sure why and didn't want to change that for now.

Not sure why travis doesn't show up integrated here anymore, PR tests are executed => https://travis-ci.org/github/barryvdh/laravel-ide-helper/builds/669882120

ping @barryvdh thanks for considering 🙇

I don't think that documentation should be the authoritative source of truth and we should always prioritize code itself and fallback to documentation if no return type provided

I don't think that documentation should be the authoritative source of truth and we should always prioritize code itself and fallback to documentation if no return type provided

Unfortunately this will not work in practice because PHPs type system is inferior in terms of what types and combinations you can express.
Thereof it's my opinion the only sensible thing to do it to make the phpdoc authoritative!

i guess your talking about something like this
/**
 * @return \App\Models\Post[]
 */
public function allPosts(): array
{
    // ...
}

didn't think of this, it makes sense in this example

Yes, exactly!

Wow, thanks @mfn, this is exactly what I was looking for.
@barryvdh Please check this out :pray:
These "mixed" are killing me, and if I manually fix them, I can't use "--reset" option anymore.

These "mixed" are killing me, and if I manually fix them, I can't use "--reset" option anymore.

You can add an explicit function phpdoc @return, then it works also with reset (with that I mean you don't / shouldn't edit it directly in the class phpdoc)
But yeah, having this PR merged would be great 😄

Friendly ping @barryvdh 🤗

thanks @mfn , this will be nice!

It is! Already deleted lots of now-redundant phpdocs in my projects


Unable to add a new Dimension

Nothing happens after clicking "Save" button.

Done

Doesn't work for me.

This does work.  However, the "Dimension ID" needs to be a number, and there should be better checking surrounding this.  Will close this ticket and open a new one.


speedup picker on android

Picker is very wonderful! But it scroll very slow on android devices, even Sumsung galaxy S5.
And I found these code cause the problem in updateItems function:
          col.wrapper.find('.picker-selected, .picker-after-selected, .picker-before-selected').removeClass('picker-selected picker-after-selected picker-before-selected');

          col.items.transition(transition);
          var selectedItem = col.items.eq(activeIndex).addClass('picker-selected').transform('');
          var prevItems = selectedItem.prevAll().addClass('picker-before-selected');
          var nextItems = selectedItem.nextAll().addClass('picker-after-selected');

I removed some of unused code, and it solved the problem(only when rotateEffect is false).

When there is many items in on col, those code will cause scroll very slow on most android devices.

Thanks, i will check it. But these lines:
var prevItems = selectedItem.prevAll().addClass('picker-before-selected');
var nextItems = selectedItem.nextAll().addClass('picker-after-selected');

can't be deleted. You just cropped functionality

I find these two classname is not used in css file, and it cause scroll to be very slow on most android devices. And I think you can use other css selectors, such as .picker-selected ~ .picker-item, instead of manipulate all items' classname.

If rotateEffect is set true,  android device nearly can't scroll the picker. Because you will change all item's transform attr when scroll move.

Thanks, i removed these next/prev classes manually. Should be better now


baremetal: Default to emptyDir for the baremetal platform.

The "baremetal" platform includes automated provisioning of bare metal
hosts.  emptyDir makes sense as the default, as we can't assume
anything else is available.  It's possible that for a given
deployment, some storage system may be available (such as rook / ceph)
and the cluster may be configured to use something else.

The "baremetal" platform includes automated provisioning of bare metal
hosts. emptyDir makes sense as the default, as we can't assume
anything else is available.

emptydir never makes sense as a default for any production deployment.  If the customer installs this way and pushes a single image to the registry before they fix the storage to something "real" they will make a mess of their cluster.
We need to discuss alternatives.

The "baremetal" platform includes automated provisioning of bare metal
hosts. emptyDir makes sense as the default, as we can't assume
anything else is available.

emptydir never makes sense as a default for any production deployment. If the customer installs this way and pushes a single image to the registry before they fix the storage to something "real" they will make a mess of their cluster.
We need to discuss alternatives.

any suggestions?  :-)
what do the docs for bare metal UPI clusters say to do?

The "baremetal" platform includes automated provisioning of bare metal
hosts. emptyDir makes sense as the default, as we can't assume
anything else is available.

emptydir never makes sense as a default for any production deployment. If the customer installs this way and pushes a single image to the registry before they fix the storage to something "real" they will make a mess of their cluster.
We need to discuss alternatives.

any suggestions? :-)
what do the docs for bare metal UPI clusters say to do?

Found the docs:  https://docs.openshift.com/container-platform/4.1/installing/installing_bare_metal/installing-bare-metal.html#installation-registry-storage-config_installing-bare-metal
basically, set up a PVC and use that, right?
Can we put this default in, just so the install completes cleanly, but then the install script for the KNI clusters will immediately reconfigure this to use a PVC using rook?  These KNI clusters with rook are the only place where the baremetal platform will be supported in 4.2.

The typical recommendation for baremetal is to use the PVC storage config, which implies separately provisioning a storage solution like ceph or NFS

I've filed this issue to ensure that the KNI install scripts immediately reconfigure the registry to use ceph once OCS has been deployed: https://github.com/openshift-kni/install-scripts/issues/5
so this PR would just be to ensure create cluster finishes cleanly, but we wouldn't actually use the registry in this config.
would a comment in the code about this help?

I've filed this issue to ensure that the KNI install scripts immediately reconfigure the registry to use ceph once OCS has been deployed: openshift-kni/install-scripts#5

Will that be in place in GA, or that's something that would be done in a future version?

so this PR would just be to ensure create cluster finishes cleanly, but we wouldn't actually use the registry in this config.

That's ok for RHHI installs, but i imagine other installs will also see the platform as "baremetal" and use emptydir and they won't have KNI install scripts to fix it up after the install completes, right?

would a comment in the code about this help?

definitely, but i still have the above concern about this approach impacting non-RHHI baremetal installs.

can we uniquely identify RHHI installs somehow?

Can we please just fix the registry to create a PVC and not block upgrade if the PVC is never satisfied? Fire an alert, but don't block upgrades.

I've filed this issue to ensure that the KNI install scripts immediately reconfigure the registry to use ceph once OCS has been deployed: openshift-kni/install-scripts#5

Will that be in place in GA, or that's something that would be done in a future version?

We can make it a GA blocker.  The baremetal platform will not be used in any GA environment until at least 4.3, and will have OCS available in all cases.

so this PR would just be to ensure create cluster finishes cleanly, but we wouldn't actually use the registry in this config.

That's ok for RHHI installs, but i imagine other installs will also see the platform as "baremetal" and use emptydir and they won't have KNI install scripts to fix it up after the install completes, right?

That's true.  RHHI is the only environment where we support this baremetal managed platform right now, though.  So for RHHI we can automate the switch away from emptydir post-install.  For any potential future use of this platform where OCS might not be available, we'd document in big bold letters that this must be reconfigured post-install to whatever is appropriate for their environment.

would a comment in the code about this help?

definitely, but i still have the above concern about this approach impacting non-RHHI baremetal installs.

Fair concern - hopefully my comment above helps, namely that there's no non-RHHI baremetal platform installs.  This issue would also block any future other usage of this platform.

@eparis

Can we please just fix the registry to create a PVC and not block upgrade if the PVC is never satisfied? Fire an alert, but don't block upgrades.

it is not "fixing" the registry.  The current behavior is not a bug.  It was extensively discussed and agreed upon.  So please don't call it "fixing" it.  If you'd like it to be changed, then ask for the behavior to be changed and we can (once again) discuss why that is problematic.

With what you propose the registry will be unavailable (no pods running).  We should never report "registry is available" when the registry is not available, or we will have started down a slippery slope of under what specific circumstances we lie to the administrator about the registry availability because we "think" it's ok that the registry is not available in this particular circumstance.  When an admin screws up their manual PV config and we report "hey your registry is totally fine, nothing to see here", that is a bad user experience and defeats the entire point of what we are trying to do w/ operator statuses+reporting.

@russellb

We can make it a GA blocker. The baremetal platform will not be used in any GA environment until at least 4.3, and will have OCS available in all cases.

Having OCS available isn't sufficient for this behavior, the point is that we need to not be using emptydir.  If you're saying that in all baremetal environments we will swap the storage to PVs post-install, then ok I guess.  It's still a bit scary since we're dependent on some external bit doing what  it's supposed to or else the admin ends up w/ an emptydir registry and doesn't realize it.

For any potential future use of this platform where OCS might not be available, we'd document in big bold letters that this must be reconfigured post-install to whatever is appropriate for their environment.

I guess we can cross that bridge when we come to it.  I'd still prefer something better, but it's something.

Fair concern - hopefully my comment above helps, namely that there's no non-RHHI baremetal platform installs. This issue would also block any future other usage of this platform.

It does help, thanks.  I'm ok w/ proceeding with this (using emptydir on "baremetal providers" for now given that).
Just to confirm, this "baremetal" provider is distinct from the install config the registry operator will see in a true baremetal (not managed) install, correct?  We definitely not want this logic to cause the registry to run emptydir in an unmanaged baremetal installation today.

Just to confirm, this "baremetal" provider is distinct from the install config the registry operator will see in a true baremetal (not managed) install, correct? We definitely not want this logic to cause the registry to run emptydir in an unmanaged baremetal installation today.

That's right.  This will not affect UPI bare metal installs.  This only applies to bare metal installs where we've enabled the extra automated provisioning and management of bare metal hosts, or the "baremetal" IPI platform for lack of a better way to refer to it.  The only place that's used right now is RHHI.
I would definitely like to figure out a way to make this use a rook/ceph PV automatically, instead of relying on a post-install script.  Maybe that's something we can figure out before GA.  For 4.2 this will just be a limited beta thing, so the post-install script seems OK.  Any suggestions for improvements post-4.2 definitely welcome!

/test e2e-aws

@russellb i'm not sure who the right set of people are, but i mentioned to @derekwaynecarr and @adambkaplan that it would be good to rename the "baremetal" provider to something more specific to RHHI, so that if a future baremetal provider wants to do something else, the registry operator can distinguish providers and do the right thing.  (alternatively if there is something else in the install config that the registry operator can look at to make the distinction, it would be good to key off that).
Do you know who we'd need to involve in such a rename discussion?

@russellb i'm not sure who the right set of people are, but i mentioned to @derekwaynecarr and @adambkaplan that it would be good to rename the "baremetal" provider to something more specific to RHHI, so that if a future baremetal provider wants to do something else, the registry operator can distinguish providers and do the right thing. (alternatively if there is something else in the install config that the registry operator can look at to make the distinction, it would be good to key off that).
Do you know who we'd need to involve in such a rename discussion?

I'm probably the best person to coordinate a rename if necessary.  Changing it in 4.3 is probably doable, but after that it's going to be less practical to change.
This isn't RHHI specific, though.  Architecturally, it's IPI for bare metal hosts.  RHHI is just one particular way it's productized, but there could be others in the future.  Anything we can do to extend and improve the baremetal platform so that it could default to something better out of the gate would be great, of course.

This isn't RHHI specific, though. Architecturally, it's IPI for bare metal hosts.

The case that I made to @derekwaynecarr (not sure if he agreed and perhaps i'm missing something about the baremetal IPI intent) is that you could have another baremetal IPI provider that wants, for example, to use noobaa, or some other s3 gateway instead of OCS for registry storage.
If we are assuming/requiring that every baremetal IPI installer will

install OCS
include install script logic to switch the registry from emptydir to PVC (via PV provided by OCS)

then it's fine.  But if we think there's any reason the storage behavior or install flow might be different for another IPI provider, we will need a way to distinguish.

This isn't RHHI specific, though. Architecturally, it's IPI for bare metal hosts.

The case that I made to @derekwaynecarr (not sure if he agreed and perhaps i'm missing something about the baremetal IPI intent) is that you could have another baremetal IPI provider that wants, for example, to use noobaa, or some other s3 gateway instead of OCS for registry storage.
If we are assuming/requiring that every baremetal IPI installer will
1. install OCS

2. include install script logic to switch the registry from emptydir to PVC (via PV provided by OCS)

then it's fine. But if we think there's any reason the storage behavior or install flow might be different for another IPI provider, we will need a way to distinguish.

We're not actually assuming anything, that's why the patch defaults to emptyDir, and expects that this must be dealt with post-install.  That leaves all of those options, depending on how the bare metal platform is used and combined with different storage options.

CC @eparis -- you may be interested in this discussion

We're not actually assuming anything, that's why the patch defaults to emptyDir, and expects that this must be dealt with post-install.

that is an assumption though, right?  you are assuming it will be dealt with post-install.
I guess i shouldn't have said "assumes OCS/PVC".  But what i should have said is:  this is ok if it is always safe to assume that for any baremetal IPI implementation, the post-install steps will always update the storage configuration.

@russellb would it make more sense for us to create a PVC, and require a baremetal "provider" have an automatic storage provisioner?

@russellb would it make more sense for us to create a PVC, and require a baremetal "provider" have an automatic storage provisioner?

the problem there is that the provisioner is OCS, but OCS won't be installed until after the basic install is complete, and the basic install can't complete until the registry comes up.

the problem there is that the provisioner is OCS, but OCS won't be installed until after the basic install is complete, and the basic install can't complete until the registry comes up.

Can the installer be enhanced so that for baremetal IPI it brings up the image registry operator (and perhaps the samples operator) in the Removed state? Then we shouldn't block install as we report Available=true in that state.
It would then be up to the post-install script to do the following:

Install OCS/other auto-provisioner for ReadWriteMany PVs
Set the image registry operator (and other potential operators) to Managed

Can the installer be enhanced so that for baremetal IPI it brings up the image registry operator (and perhaps the samples operator) in the Removed state?

i don't think that is a path that exists in the installer today and i think there would be significant pushback on adding it.  The installer lays down the manifests as provided, it's not going to customize specific manifests based on provider.

The installer lays down the manifests as provided, it's not going to customize specific manifests based on provider.

Instead of handling PV config post-install, can we feed the installer some manifests to set up PV during the IPI-ish install?  Users who went that route could configure the registry to use whatever storage they were configuring, and install would go smoothly and end up with a happy, functional, production registry.
Users who did not add additional manifests would have install hang and exit "the registry never got happy", and folks could investigate the registry, see that it was waiting on storage, and do whatever day-2 stuff they needed to fix it up then.
Or is that not feasible for some reason (maybe you need something more interactive to set up PV, and can't just drop in a bunch of manifests into the installer)?

Or is that not feasible for some reason (maybe you need something more interactive to set up PV, and can't just drop in a bunch of manifests into the installer)?

the PVs are provided by OCS which isn't installed until after the install completes.  So i don't know what PV configurations we could have the installer lay down that would be claimable/usable, before OCS was installed.

So i don't know what PV configurations we could have the installer lay down that would be claimable/usable, before OCS was installed.

The bootstrap machine just pounds away trying to add manifests until the cluster accepts them.  For example, we push MachineSets for the compute machines.  Right off the bat, when all we have is Kubernetes, those get rejected.  Later on, after the cluster API tooling us up, they are accepted, and the cluster API operator creates the requested machines.  Could something similar work for OCS and PV?  Or does the OCS install need manual interaction beyond "here are the manifests that install and configure OCS"?

Could something similar work for OCS and PV? Or does the OCS install need manual interaction beyond "here are the manifests that install and configure OCS"?

the problem is, the registry operator is still going to be "stuck" until OCS comes up.  Which means the install is going to fail/hang for 30 minutes until it gives up on the registry.  Then OCS would be installed, PVs would become available, and the registry would become available.

Right, the real problem is that the registry can't say 'I'm not working, but I don't want to block things.'  That's what we need to be able to say.

@smarterclayton @derekwaynecarr Can we please just agree to add such a state?

Right, the real problem is that the registry can't say 'I'm not working, but I don't want to block things.' That's what we need to be able to say.

Why do we need to be able to say that?  Sounds like OCS is maybe not quite there yet, but you can deploy Rook/Ceph by pushing three YAML files (which I skimmed through without noticing anything that needed to be filled in with information known only at day-2).  So you could do something like:
$ openshift-install --dir whatever create manifests
$ curl -s https://raw.githubusercontent.com/rook/rook/master/cluster/examples/kubernetes/ceph/common.yaml >whatever/openshift/999-rook-common.yaml
$ curl -s https://raw.githubusercontent.com/rook/rook/master/cluster/examples/kubernetes/ceph/operator.yaml >whatever/openshift/999-rook-operator.yaml
$ curl -s https://raw.githubusercontent.com/rook/rook/master/cluster/examples/kubernetes/ceph/cluster.yaml >whatever/openshift/999-rook-cluster.yaml
$ echo 'something to get the registry using PVs?' >whatever/openshift/9999-registry-pv-config.yaml
$ openshift-install --dir whatever create cluster

and have your cluster come up with Rook/Ceph working and the registry using it.

Right, the real problem is that the registry can't say 'I'm not working, but I don't want to block things.' That's what we need to be able to say.

for now i think we have a path forward which is the registry operator can bootstrap the registry as "removed" on platforms where it knows it cannot configure storage properly.  That means you have no registry running, and the registry operator will report "available" (because the operator is available and has done all it has been asked to do).  On day 2, RHHI or the Admin can change it back to "managed" while providing a valid storage configuration.
What @wking is proposing may also be a path forward at some point.

@bparees is this something that should already work today?  or something that requires more work?  Are there other relevant issues / PRs i should watch?

AFAIK we already declared baremetal support in 4.1. So even if this change is indented to fix the problem in 4.3 for RHHI, it can affect other baremetal (UPI) customers. How can we make sure that customers switch the registry to some kind of persistent storage before using it?

@sdodson yes, that confused me a bit, for RHHI.next we use BareMetal, and for baremetal installations we use None.

Hopefully we'll have capacity to improve it in 4.3.
/lgtm


Add "NullEnv" type.

It would be an environment with no fields, the DepT analogue of ReaderT's ().
Might be useful for examples.

Added in 507303cf8b822b383cfd9cf749d2f0b6886b6269 as NilEnv.

Added in 507303cf8b822b383cfd9cf749d2f0b6886b6269 as NilEnv.


torch_geometric support

First of all, thank you for the excellent nvitop.
I want to know if you have plans to add an integration with PyTorch Geometric (pyg)? It is a really great library for GNNs. I don't know if its helpful at all but it also has some profiling functions in the torch_geometric.profile module.
Since pytorch lightning doesn't give you granular control over your models (sometimes reqd in research) I haven't seen anyone use it. On the flipside, pytorch geometric is probably the most popular library for GNNs.
Hope you consider this!

I want to know if you have plans to add an integration with PyTorch Geometric (pyg)? It is a really great library for GNNs. I don't know if its helpful at all but it also has some profiling functions in the torch_geometric.profile module.

Hi @plutonium-239, thanks for the suggestion. I'll be investigating in these two weeks.

Since pytorch lightning doesn't give you granular control over your models (sometimes reqd in research)

nvitop.core provides low-level APIs that users can integrate it into their training/testing code. nvitop.callbacks offers framework high-level APIs.
I'm thinking of adding a more customizable mid-level API, e.g., a background daemon gathering the process status (both on host and GPUs). Let the users log the useful items into tensorboard.SummaryWriter, csv, or print to stdout.

Hi @plutonium-239, I have looked into the source code of PyTorch Geometric (pyg). It looks that pyg supports PyTorch Lightning and the callback in nvitop is also usable.
For flexibility, I implement a new metric collector in PR #21, which allows the user has full control of the code logic of DL training.
For example:
>>> import os
>>> os.environ['CUDA_VISIBLE_DEVICES'] = '3,2,1,0'

>>> from nvitop import ResourceMetricCollector, Device, CudaDevice

>>> collector = ResourceMetricCollector()                          # log all devices and children processes on the GPUs of the current process
>>> collector = ResourceMetricCollector(root_pids={1})             # log all devices and all GPU processes
>>> collector = ResourceMetricCollector(devices=CudaDevice.all())  # use the CUDA ordinal

>>> with collector(tag='<tag>'):
...     # do something
...     collector.collect()  # -> Dict[str, float]
{
    '<tag>/host/cpu_percent (%)': 8.967849777683456,
    '<tag>/host/memory_percent (%)': 21.5,
    '<tag>/host/swap_percent (%)': 0.3,
    '<tag>/host/memory_used (GiB)': 91.0136418208109,
    '<tag>/host/load_average (%) (1 min)': 10.251427386878328,
    '<tag>/host/load_average (%) (5 min)': 10.072539414569503,
    '<tag>/host/load_average (%) (15 min)': 11.91126970422139,
    '<tag>/cuda:0 (gpu:3)/memory_used (MiB)': 3.875,
    '<tag>/cuda:0 (gpu:3)/memory_free (MiB)': 11015.562499999998,
    '<tag>/cuda:0 (gpu:3)/memory_total (MiB)': 11019.437500000002,
    '<tag>/cuda:0 (gpu:3)/memory_percent (%)': 0.0,
    '<tag>/cuda:0 (gpu:3)/gpu_utilization (%)': 0.0,
    '<tag>/cuda:0 (gpu:3)/memory_utilization (%)': 0.0,
    '<tag>/cuda:0 (gpu:3)/fan_speed (%)': 22.0,
    '<tag>/cuda:0 (gpu:3)/temperature (℃)': 25.0,
    '<tag>/cuda:0 (gpu:3)/power_usage (W)': 19.11166264116916,
    '<tag>/cuda:1 (gpu:2)/memory_used (MiB)': 8878.875,
    ...,
    '<tag>/cuda:2 (gpu:1)/memory_used (MiB)': 8182.875,
    ...,
    '<tag>/cuda:3 (gpu:0)/memory_used (MiB)': 9286.875,
    ...,
    '<tag>/pid:12345/cuda:1 (gpu:4)/cpu_percent (%)':<PHONE_NUMBER>2112265,
    '<tag>/pid:12345/cuda:1 (gpu:4)/host_memory (MiB)': 44749.72373447514,
    '<tag>/pid:12345/cuda:1 (gpu:4)/host_memory_percent (%)': 8.675082352111717,
    '<tag>/pid:12345/cuda:1 (gpu:4)/running_time (min)':<PHONE_NUMBER>6741576,
    '<tag>/pid:12345/cuda:1 (gpu:4)/gpu_memory (MiB)': 8861.0,
    '<tag>/pid:12345/cuda:1 (gpu:4)/gpu_memory_percent (%)': 80.4,
    '<tag>/pid:12345/cuda:1 (gpu:4)/gpu_memory_utilization (%)': 6.711118172407917,
    '<tag>/pid:12345/cuda:1 (gpu:4)/gpu_sm_utilization (%)': 48.23283397736476,
    ...,
    '<tag>/duration (s)': 7.247399162035435
}

The results can be easily logged into TensorBoard or to CSV file.
import os

import torch
import torch.nn as nn
import torch.nn.functional as F
from torch.utils.tensorboard import SummaryWriter

from nvitop import CudaDevice, ResourceMetricCollector

# Build networks and prepare datasets
...

# Logger and status collector
writer = SummaryWriter()
collector = ResourceMetricCollector(devices=CudaDevice.all()
                                    root_pids={os.getpid()},
                                    interval=1.0)

# Start training
global_step = 0
for epoch in range(num_epoch):
    with collector(tag='train'):
        for batch in train_dataset:
            with collector.context(tag='batch'):
                metrics = train(net, batch)
                global_step += 1
                writer.add_scalars('train', metrics, global_step=global_step)
                writer.add_scalars('resources',          # tag='resources/train/batch/...'
                                   collector.collect(),
                                   global_step=global_step)

        writer.add_scalars('resources',                  # tag='resources/train/...'
                           collector.collect(),
                           global_step=epoch)

    with collector(tag='validate'):
        metrics = validate(net, validation_dataset)
        writer.add_scalars('validate', metrics, global_step=epoch)
        writer.add_scalars('resources',                  # tag='resources/validate/...'
                           collector.collect(),
                           global_step=epoch)

Since the new feature is built on top of branch mig-support, which has not been released yet. To install:
pip3 install git+https://github.com/XuehaiPan/nvitop.git@collector#egg=nvitop

Any feedback is welcome.

Close as resolved by PR #21.


Start section serialization lacks section size

This input:
(module
  (type (;0;) (func))
  (func (;0;) (type 0))
  (start 0))

converted to wasm via wabt produces this byte sequence (hexdump -C):
00000000  00 61 73 6d 01 00 00 00  01 04 01 60 00 00 03 02  |.asm.......`....|
00000010  01 00 08 01 00 0a 04 01  02 00 0b                 |...........|
0000001b

and round-tripped with the new roundtrip example program produces this output byte sequence:
00000000  00 61 73 6d 01 00 00 00  01 04 01 60 00 00 03 02  |.asm.......`....|
00000010  01 00 08 00 0a 04 01 02  00 0b                    |..........|
0000001a

The difference is that the start section is missing the section length. The start section is "08 01 00" in the input and "08 00" in the output.

yep, there is a bug here:
https://github.com/NikVolf/parity-wasm/blob/master/src/elements/section.rs#L159
i'll add fix in a moment

That was probably the only section we never used in our wasm mvp
since they are all compiled with #![no_main]
thanks for spotting it!


Structure is valid?

Hello, I hope you are well.
I wanted to show you how you see the use of this archetype using the Screenplay pattern. I have made an example of automation with this archetype, I wanted to know your opinion about this, since I did not find a topic about this anywhere.
With jasmine
spec
├── screenplay
│    ├── ui
│    ├── tasks
│    ├── interactions
│    └── questions
│
└── archive.ts <- where the tests are housed for execution

With Cucumber
feature
├── step_definitions
│   └── archive.steps.ts <- Contains the step definitions
├── screenplay
│    ├── ui
│    ├── tasks
│    ├── interactions
│    └── questions
│
└── archive.feature <- Contains the scenarios in gherkin

Hi @camillomurcia! Perfect timing, I've just released a new project template demonstrating Serenity/JS Screenplay Pattern implementation with WebdriverIO and Cucumber.
To answer your question about the archetype structure, I think it depends on a number of factors - are the tests in the same repo as the system under test, or are they an independent project? Is Cucumber the only test runner being used, or is Screenplay code shared with other test runners? Do you want to share test code across repositories? What slicing makes the most sense in the case of your system? By type (ui/tasks/interactions), by feature (product_seach/basket/checkout), by sub-system, etc.
I'd suggest this conversation I had with @AbhineetSharmax at #295 as a starting point.
In particular, note that with Serenity/JS you can organise .feature files into folders, which might affect where you want to place the integration code.
In the new project template I mentioned earlier, I've gone with a rather simple structure:
features                <- anything Cucumber-related
  step-definitions
    steps.ts
  authentication        <- feature files related to the "authentication" module of the test app
    form_authentication.feature
    narrative.md
  support               <- cucumber config, parameter types, etc.
test                    <- Serenity Screenplay code, sliced by module of "The Internet" test app
  authentication
    ui                  <- lean page objects, "package-private", never used in Cucumber scenarios
    Authenticate.ts     <- tasks related to the authentication module, used in Cucumber scenarios
    VerifyAuthentication.ts

Does it make sense?

ohh ok, it makes sense.
The project is separate from the system repository.
The reason why I thought of this archetype in this way is because of the reason to separate and have the tasks, interactions, etc. in each folder
I leave you the example of how I did it with Jasmine but it is something "similar" for cucumber of how I am handling it (I have a project in cucumber with Protractor and one that I am doing with the new integration but I have not uploaded it yet)
Project Example With Jasmine


Revision of Bootswatch themes

[x] cerulean
[x] cosmo
[x] cyborg
[x] darkly
[x] flatly
[x] journal
[x] lumen
[x] paper
[x] readable
[x] sandstone
[x] simplex
[x] slate
[x] spacelab
[x] superhero
[x] united
[x] yeti

Cerulean

Global

header and page font-family: from default Lato to Helvetica Neue

Elements

button: background and box-shadow effects modified
step, breadcrumb: background color

Collections

menu: active item's text color, from black to white
vertical and tabular menu: keep text color consistent with other menu

Cosmo

Global

global colors: redefine variable names

Elements

button: basic button's text visibility
step: background color
label: text color

Collections

breadcrumb: background color
form: warning, error form input's border, background color modified
menu: text color(hover, active)
message: header, description's text color
table: positive, negative, warning table row and cell's background color

Modules

accordion: make accordion menu appear right

Cyborg

Global

code color: improve visibility on black background
state colors: hovered, pressed, selected, disabled, unselected
placeholder color: from white to gray

Elements

code icon: from black to gray
divider: color of text inside the divider
block and attached header: background color
corner label: top and right border
list: background set to transparent to keep consistent
list description: text color
piled and stacked segment: decorative segments color, from white to dark
step: add a style, almost same as cosmo theme

Collections

breadcrumb: background set to transparent, and make text visible
form: warning, error form input's border, background color modified
vertical menu: background set to transparent
table: remove box-shadow of the empty header in definition table

Views

feed: color of meta, date, extra parts
statistic: big number's color, from gray to white

Modules

checkbox: toggle and slider checkbox's slider bar, from black to gray
rating icon: color when inactive

Darkly

Global

default and inverted color: exchange, and do some modification
code color: improve visibility on black background
state background colors: hovered, pressed, selected, disabled, unselected
border color: gray
placeholder color: from white to gray

Elements

code icon: gray, more visible
divider: color of text inside the divider
block and attached header: background color
input: border and height
list: background set to transparent to keep consistent
list description: text color
piled and stacked segment: decorative segments color, from white to dark
step: add a style, almost same as cosmo theme

Collections

breadcrumb: background set to transparent, and make text visible
form: warning, error form input's border, background color modified
menu:

sub menu's text color
vertical menu's background, from white to none
hovered color of dropdown menu's item
default and active background of secondary menu's item
active background of tabular menu's item

message: default background color
table background colors:

default
header
footer
definition table
active row or cell

Views

feed: color of meta data and label icon, increase visibility
statistic: value and label color, big contrast

Modules

checkbox: toggle and slider checkbox's slider bar, from transparent to gray
dropdown: header and divider's colors
progress bar: consistent height of 10px
rating icon: visible color when inactive

Flatly

Global

state background colors: selected, muted
placeholder color: increase visibility
solid definition: avoid references

Elements

input label: make the text vertically center aligned when height increased
corner label: icon's color
piled and stacked segment: decorative segments color, from white to light gray
step: add a style

Collections

breadcrumb: increase padding, but background not changed
form: warning, error form input's border, background color modified
menu:

active item text color in rail vertical menu
vertical menu's background
tabular menu's default text color

table background colors: remove color reference in global setting, then work

Modules

progress bar: consistent height of 10px, use variable to define

Journal

Global

font family: modify a few variables

google font must be open source

Elements

button: delete duplicate text color variable

Lumen

Global

global colors: remove reference, use direct definition
google fonts: use only available open source font

Elements

button:

font-size: smaller than page font size
text-transform: all uppercase
border: border-bottom is emphasized

input: height, border, label middle aligned
segment, step: add border style

Collections

form: remove inconsistent border
menu:

border-bottom: 4px
active item background color(darker)

message: add border style

Paper

Global

global colors: avoid variables references
headers: use relative font size
font family: remove superfluous fonts

Elements

button:

remove useless lines
effects when button is clicked
border
uppercase text

input: bigger line height, visible border
segment header: remove border
step: border

Collections

breadcrumb: increase padding, add border
form:

input and select border and height
error field input text color

menu: border of icon
message: default text color

Views

card: add border

Modules

progress: bar height

Readable

Global

global colors: remove variables references
global font: remove incorrect definition

Elements

button: remove @fontName
input: correct border definition
label: background color and corner label's border

Collections

menu: minor revision of border

Sandstone

Global

global colors: remove variables references
global font: remove incorrect definition

Elements

basic button: text color, uppercase
input: correct border definition
label: text and background color
segment: remove border and text-transform settings
step: add text-transform setting to title

Collections

breadcrumb:

exchange default and active section text color
increase padding

menu: vertical menu's label background, active text color
form: error field input placeholder color, more visible

Simplex

Global

global font: remove duplicate definition

Elements

button:

default hovered text color
basic button text color, set to black

input: make border visible
step: add border and background style

Slate

Global

default and inverted color: exchange, and do some modification
code color: improve visibility on black background
border color: gray
placeholder color: from white to gray

Elements

button:

basic button: background changed to gray
add gradient effects to button background
change hover background color

block and attached header: background color
code icon: gray, more visible
input: border, placeholder color
list:

description text color, more visible
make text color of links white in inverted list(page footer)
background set to transparent to keep consistent

piled and stacked segment: decorative segments color, from white to dark
step: add a style

Collections

breadcrumb:

increase padding
default and active text color

form:

make text of select visible
add gradient effects to label and button in inputs

menu:

remove inconsistent border style
hovered color of dropdown menu's item
sub menu's text color
vertical menu's background, label background
pointing border color of pointing secondary menu

message: default background color
table background colors:

default
header
footer
definition table border
active row or cell

Views

feed: color of meta data
statistic: value color

Modules

checkbox: toggle and slider checkbox's slider bar, bullet color of checked radio
rating icon: set to visible color when inactive

Spacelab

Global

font and color: minor revision of variables

Elements

button:

basic button text color
hovered background
background of button in input

step: add gradient background

Superhero

Global

default and inverted color: exchange, and do some modification
code color: improve visibility on black background
border color: gray
placeholder color: more visible and consistent

Elements

basic button: hover background color
block and attached header: consistent background color
code icon: gray, more visible
input: border width set to zero
label: background set to @primaryColor
list:

description text color, more visible
background set to transparent to keep consistent

piled and stacked segment: decorative segments color, from white to gray
step: add a style

Collections

breadcrumb: increase padding
form:

make text of select visible
input placeholder color modified

menu:

set text and background color of dropdown menu
active hovered item's text color
vertical menu's background and label background color
tabular and secondary active item background color

message: default text and background color
table background colors:

default
header
footer
striped
definition table border
active row or cell

Views

feed: meta data and icon color
statistic: value and label color

Modules

checkbox: toggle and slider checkbox's slider bar, bullet color of checked radio
rating icon: set to visible color when inactive

United

Global

font: set to Ubuntu
muted text color: set to light gray(for text menu item)

Elements

basic button: default text color
step: add a style

Collections

menu:

secondary menu default text color
tabular menu deafult text color
hover color of active item
vertical menu background, primary color
label background in menu

Yeti

Global

font: simplify definition

Elements

button: unify padding
step: add theme style, black

Collections

breadcrumb: increase padding
menu:

secondary menu's default text color
accordion vertical menu's background color, transparent
label background in menu
hover text and background color of active item
text and background color of dropdown
vertical menu's default background
tabular menu's default text color

Modules

dropdown: header text color
popup: remove previous background color

A little reflection of the second round of theme porting work
Typically, I check the themes one by one to find problems for each theme, and each theme may have different numbers of problems, something like this:

theme1
Problem1
Problem2
...
Uncertain

theme1
Problem1
Problem2
...
Uncertain

...
Problem1
Problem2
...
Uncertain

theme16
Problem1
Problem2
...
Uncertain

In fact, I repeat a lot of visually checking, definition locating, variables searching, and finally modifying for each theme, some of the work for many themes are exactly the same.
But until I nearly finish, I discover that I can actually make a list or set of all possible problems, [problem1, problem2, problem3,..., problem50], then check these problems one by one through 16 themes, something like this:

theme1
theme2
theme3
...
theme16

problem1

Modified

Modified

problem2
Modified

problem3
Modified

Modified

...

Modified

problem50

Modified
Modified

Modified

In this way, I check the same problem in every theme and modify the wrong one. So the big problem is to first find all possible problem, as your have said, the similar general problems for every theme. This seems better, and indeed sometimes, I have to go back and check the previous modified themes committed again for newly discovered problems. But, I did not write down every problems in the process, and waste some time.
I think this is a lesson for me, for problems that MAY appear repeatedly in the future, write down in a form, how it happens, where it comes from, how it can be solved. Why a problem will appear again? That's another question, actually I have not think it clearly enough at present.

Wonderful job! Just got time to give a shot to this amazing PR.
No time to dive into the details, only some minor thoughts:

Seems you use 4-spaces indentation, however, official semantic-ui uses 2-spaces indentation. As you said, we need some rules and lint tools to do code check here. The is a later issue.
I've seen that you add some extra warning, error class to some element, which, is not exists in official semantic-ui.

I will merge this PR right now, and maybe later we can start a third round with this solid foundational work, but this still need some extra discussion.
Anyway, thanks for your job!

And please help update this repo: https://github.com/semantic-ui-forest/themes.
Sorry I still didn't get time to write a automatic batch build script.

OK, I will update the built theme files.


Parsing export default ... peeks to not overconsume tokens

Fixes https://code.google.com/p/esprima/issues/detail?id=631
Paired with @mikesherov on this today.
Updates to the tests in harmonymoduletest to account for token generation is forthcoming (Will squash commits once those are in).

Please squash.

@michaelficarra yeah, we'll squash once tests land at the end. Thanks!

@michaelficarra Sure thing! Should have mentioned I'd do that at in the description.

Test changes are in. Since we modified code that touches the default branch of parseExportDeclaration, I added tokens to all export default tests.

@jeffmo or @ariya can someone please review this when you have some free time?

I'll take a look
-Jeff
On 2/6/15 9:48 AM, Mike Sherov wrote:

@jeffmo https://github.com/jeffmo or @ariya
https://github.com/ariya can someone please review this when you
have some free time?
—
Reply to this email directly or view it on GitHub
https://github.com/jquery/esprima/pull/310#issuecomment-73246993.

This looks great, thanks for the PR!

@jeffmo Ya the inconsistency in that file now is kind of a bummer, but I plan on adding tokens to the rest of the cases in harmonymoduletest later in another PR to make sure no other issues like this pop up.


[INFRA] Added error tests

We should also test whether the validation fails when it should fail. This PR does that, leveraging https://github.com/bids-standard/bids-error-examples

It is green and plenty of approvals and dealing with tests, so cannot break anything. I will just merge, please alert me if I shouldn't use such super-powers ;)


Dev/slicer

Description
Cleaning the tests in view of merge
Closes # .
Checklist
Mandatory:

[x] I have added tests to cover my changes
[x] All the tests are passing, including my new ones
[x] I described my changes in this PR description

Optional:

[x] The code I wrote follows good style practices (see PEP 8 and PEP 20).
[x] I have updated the docs in relation to my changes, if applicable
[ ] I have tested also GPU contexts

obsolete


ASP0020

Add ASP0020

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 657f3da7-ec96-7d56-f1b4-4787e0f0fd84
Version Independent ID: 657f3da7-ec96-7d56-f1b4-4787e0f0fd84
Content: Code analysis in ASP.NET Core apps
Content Source: aspnetcore/diagnostics/code-analysis.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@david-acker can you email me<EMAIL_ADDRESS>


init: ported To_Titlecase_{unicode,string} primitive function

Since a number of level-2 libraries are using string processing functions, we have to port its primitive functions into HestiaKERNEL library. Hence, let's do this.
This patch ports To_Titlecase_{unicode,string} primitive function in init/ directory.

skip review since this is a port and does not affect the current production system.


[BUG] repeated navigation bar in print view

Describe the bug 描述你遇到的错误

Is there an easy way to make the pages PRINT (on paper) well? Right now, I get the top navigation bar repeating itself and blocking page content (that should be printed) behind it. I find this is a problem on a LOT of Hugo-generated sites. I understand that it is not a Hugo-specific problem, but more a CSS issue.
You may see this yourself if you try to print out a page, such as the theme-documentation-extended-shortcodes/ page.
FR: (#60)

Expected behavior 期待的行为
Don't show navigation bar in print view anyway and optimize CSS.
(Because in the print view the focus is more on the content and there is no interaction.)
Screenshots 屏幕截图

Preview Environment 预览环境

OS: Windows 10, macOS
Browser: Chrome (Safari not repeating)

resolved

可在文章中使用 css class page-break-before 或 page-break-after 进行打印视图强制分页，例如：

Print Style Docs


Cant edit environment variable in ubuntu, saying readonly

Created  a ubuntu machine in AWS and installed java. while setting env variable it is showing readonly file , I can not insert the JAVA_HOME path and cant save.

use this command:
sudo nano /etc/environment
It will work.

If you want to edit file go with sudo it will give you permission to edit.

Thank you its working


Unable to execute a ZIP archive example

OS: Windows 10
Python version: 3.6
Pysciter: 0.4.29
When I was trying to run
python ./archive.zip
I got this error
(face2) D:\Ajinkya\RASA\pysciter-master\examples>python ./archive.zip
warning:dom: failed to load "//archive.zip" file, error=161
Traceback (most recent call last):
  File "D:\ai\envs\face2\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "D:\ai\envs\face2\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File ".\archive.zip\__main__.py", line 7, in <module>
  File "D:\ai\envs\face2\lib\site-packages\sciter\host.py", line 107, in load_file
    raise sciter.SciterError("Unable to load file " + uri)
sciter.error.SciterError: Unable to load file archive.zip#archived.htm

@c-smile Andrew, has something been changed in zip archive handling?

Nothing have changed in .ZIP handling respect.
Check if SciterLoadFile gets called with absolute path or absolute file URL.

@c-smile Well, it did work in past.
archive.zip contains "archived.htm".
It was referenced as "archive.zip#archived.htm" and it used to work.
Now, I get for "archive.zip#archived.htm" the following:

warning:dom: failed to load "pysciter/examples/archive.zip%archived.htm" file, error=2

And for "archive.zip/archived.htm":

"warning:dom: failed to load "d:/usr/lib/gui/htmlayout/pysciter/examples/archive.zip/archived.htm" file, error=3

The only thing that works is: "archive.zip" as URL with "index.htm" in it.
So, is it possible to load a specific HTML from a ZIP archive? If yes, how?

Is this relative URL:
"pysciter/examples/archive.zip%archived.htm"
?
I suspect that problem is on pysciter side - it does not provide absolute file:// .... URL or absolute path.
Again Sciter has no notion of CWD - that's completely on Python,Go,C,whatever side .

No, it's an absolute url.

Check if https://github.com/c-smile/sciter-sdk/blob/master/samples/zip/test-explicit-main.htm works in wsciter/usciter on your machine.

No, it's an absolute url in all cases.

URL "archive.zip#archived.htm" doesn't work anymore.
URL "d:/pysciter/examples/archive.zip#archived.htm" doesn't work either despite looking like an absolute URL.
URL "d:\pysciter\examples\archive.zip#archived.htm" doesn't work as well.
URL "file://d:\pysciter\examples\archive.zip#archived.htm" works. So, from some point in Sciter's history the file:// part is mandatory now.
But that leads us to a broken example with "archive.zip" - well, it was a trick anyway.


Error: [Swarm] RemBg not available

Your question
Hi,
I've been trying multiple reinstalls of SwarmUI on vast.ai machines, and I keep getting this warning:
20:47:40.495 [Init] Self-Start ComfyUI-0 on port 7821 started.
20:47:40.496 [Init] Initializing backend #0 - ComfyUI Self-Starting...
20:47:41.030 [Init] Self-Start ComfyUI-0 on port 7822 is loading...
20:47:44.651 [Warning] [ComfyUI-0/STDOUT] Error: [Swarm] RemBg not available
20:47:44.651 [Warning] [ComfyUI-0/STDERR] Traceback (most recent call last):
20:47:44.652 [Warning] [ComfyUI-0/STDERR]   File "/root/SwarmUI/src/BuiltinExtensions/ComfyUIBackend/ExtraNodes/SwarmComfyExtra/__init__.py", line 7, in <module>

I have seen a similar issue here but to be honest, I don't understand how it was solved. I've tried starting the ComfyUI installation manually, and it works. Also, the installs for rembg and other Python packages exit without issue during the SwarmUI installation process; if I enter Comfy's venv the packages seem to be installed ("Requirements already satisfied…")
Full log entry below.
Logs
https://paste.denizenscript.com/View/126097
Other
No response

Your main error in that log is ImportError: libGL.so.1: cannot open shared object file: No such file or directory
Which this stackoverflow post suggests a fix for: https://stackoverflow.com/questions/55313610/importerror-libgl-so-1-cannot-open-shared-object-file-no-such-file-or-directo
btw please do not run user software as root

Thanks for your input, really. I'm really no IT expert, but I thought as much about running as root; however, it seems the standard with cloud GPU Docker images, so I really wouldn't know how to do differently. I've yet to find an image that starts you in a normal user, and it's really too much work to systematically customize images for all the apps I use, at least for me.

Oh, for docker, use Swarm's docker scripts in the repo's root (there's a docker-compose and a sh script to your preference). The libgl error was fixed for that a few months ago https://github.com/Stability-AI/StableSwarmUI/pull/331

Hi!
I'm running into the same error when installing on a Vast.ai image. The machine instance is of course loading a Docker image, but I'm installing Swarm with my own shell script using git and dotnet as in Dr. Furkan's (SECourses) scripts. The image is the following:
pytorch/pytorch:2.4.0-cuda12.4-cudnn9-runtime
Comfy is using Python 3.11 in its venv:
20:25:13.609 [Warning] [ComfyUI-0/STDOUT] Error: [Swarm] RemBg not available
20:25:13.609 [Warning] [ComfyUI-0/STDERR] Traceback (most recent call last):
20:25:13.610 [Warning] [ComfyUI-0/STDERR]   File "/workspace/SwarmUI/src/BuiltinExtensions/ComfyUIBackend/ExtraNodes/SwarmComfyExtra/__init__.py", line 7, in <module>
20:25:13.610 [Warning] [ComfyUI-0/STDERR]     from . import SwarmRemBg
20:25:13.610 [Warning] [ComfyUI-0/STDERR]   File "/workspace/SwarmUI/src/BuiltinExtensions/ComfyUIBackend/ExtraNodes/SwarmComfyExtra/SwarmRemBg.py", line 4, in <module>
20:25:13.610 [Warning] [ComfyUI-0/STDERR]     from rembg import remove
20:25:13.611 [Warning] [ComfyUI-0/STDERR]   File "/workspace/SwarmUI/dlbackend/ComfyUI/venv/lib/python3.11/site-packages/rembg/__init__.py", line 5, in <module>
20:25:13.611 [Warning] [ComfyUI-0/STDERR]     from .bg import remove
20:25:13.611 [Warning] [ComfyUI-0/STDERR]   File "/workspace/SwarmUI/dlbackend/ComfyUI/venv/lib/python3.11/site-packages/rembg/bg.py", line 7, in <module>
20:25:13.611 [Warning] [ComfyUI-0/STDERR]     from cv2 import (
20:25:13.611 [Warning] [ComfyUI-0/STDERR]   File "/workspace/SwarmUI/dlbackend/ComfyUI/venv/lib/python3.11/site-packages/cv2/__init__.py", line 181, in <module>
20:25:13.612 [Warning] [ComfyUI-0/STDERR]     bootstrap()
20:25:13.612 [Warning] [ComfyUI-0/STDERR]   File "/workspace/SwarmUI/dlbackend/ComfyUI/venv/lib/python3.11/site-packages/cv2/__init__.py", line 153, in bootstrap
20:25:13.612 [Warning] [ComfyUI-0/STDERR]     native_module = importlib.import_module("cv2")
20:25:13.612 [Warning] [ComfyUI-0/STDERR]                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
20:25:13.612 [Warning] [ComfyUI-0/STDERR]   File "/opt/conda/lib/python3.11/importlib/__init__.py", line 126, in import_module
20:25:13.613 [Warning] [ComfyUI-0/STDERR]     return _bootstrap._gcd_import(name[level:], package, level)
20:25:13.613 [Warning] [ComfyUI-0/STDERR]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
20:25:13.613 [Warning] [ComfyUI-0/STDERR] ImportError: libGL.so.1: cannot open shared object file: No such file or directory
20:25:13.616 [Warning] [ComfyUI-0/STDERR]

Then you need to copy the docker commands https://github.com/mcmonkeyprojects/SwarmUI/blob/master/Dockerfile
note the 'apt install' commands specifically


Clear background notifications when user opens the app

Hi!
First of all, thank you for your package! :blush:
Is there a way to clear phone notifications received on the background when user opens the app? I cannot find this in the documentation.
I'm using multiple notifications on android.
Thank you in advance!

+1

it's in the event Push.on("message") - push notifications will not show when the app is open - the app should decide how to display eg. by using the local notifications or other custom way

directly发自我的手机-------- 原始邮件 --------发件人： Violeta @.>日期： 2022年4月20日周三 00:49收件人： raix/push @.>抄送： Subscribed @.***>主    题： Re: [raix/push] Clear background notifications when user opens the app (#102)
Closed #102.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>


Support Warning header

Iron currently seems to lack support for the Warning header. I haven't checked if there are any others missing.

It seems that this is due to the hyper version used in hyper is 0.10 which does not support Warning header yet. However, when you are dealing with a headers: &mut Headers , you can get/set the raw Warning headers like so:
let warnings = match headers.get_raw("Warning") {
        Some(warning) => std::str::from_utf8(&warning[0]).unwrap(),
        None => "No warning.".to_string(),
};

headers.set_raw("Warning", vec![b"Warning: 110".to_vec()]);

Should be fixed with new hyper version.


feat(markdown-menu): add optional fragmentIdLinks support

Quick updates after closing https://github.com/willviles/ember-cli-markdown-resolver/pull/7
By default the click handler will update the window.location.hash. Additionally, It also allows the user to pass in an onClick action handler as well so they can do something like this if they want to smooth-scroll.
{{! guides.hbs }}
{{markdown-menu tree=tree onClick=(action "onClick")}}

// controllers/guides.js
import Controller from '@ember/controller';
export default Controller.extend({
  actions: {
    onClick(fragmentIdLink) {
      document.querySelector(`#${fragmentIdLink}`).scrollIntoView({
        behavior: 'smooth'
      });
    }
  }
});

Let me know what you think of the solution or if you can think of something more elegant 🤷♂.
Unfortunately Ember doesn't solve this problem in a clean and easy way right now with {{link-to}}'s and hash fragment Id's.
Thanks for this addon, it's great!

Closes #6

@alexdiliberto - thanks, this works nicely! Published in 0.1.3 👍


sharding-sphere如何确保高可用性？

sharding-sphere如何确保高可用性？有什么方案没有？

Hello, we prefer use english to discuss issue.
For bug report, we can keep it, but for question, we will close directly.


Factor out SectionHeading as visual UI component

Who is this PR for?
developers and designers
What problem does this PR fix?
Factor out a visual style as a component that we can reuse and modify.  This came out of work on https://github.com/studentinsights/studentinsights/issues/1497 where we'll want to reuse this style.
What does this PR do?
Straight refactor.
Screenshot (if adding a client-side feature)

Checklists
Javascript QA

[x] Author checked latest in IE - Student Profile
[x] Author checked latest in IE - Restricted Notes
[x] Author included specs for new code

selfie


added new ES6  functions

added Map() , filter() , reduce() functions with both theory and examples.

it would be really helpful if u accept the PR.

@T-Rahul-prabhu-38 I will check your PR shortly 🙂.

@neerajrathore  can u please add the hacktoberfest tag aswell,
thank you!


Run arguments on project level are not pass to ./mvnw spring-boot:run only the ones that are coded to the project.json

Plugin Name
@nxrocks/nx-spring-boot
Nx Report
We want to run the spring-boot app with a different argument each time, Passing the argument on the project-level run dialog  (red circle) does not have any effect, only the hard-codded args in the project.json (green circle) are passed to the ./mvnw spring-boot:run

Expected Behaviour
both arguments should be pass
Actual Behaviour
only the hard-codded args are passed  to ./mvnw spring-boot:run
Steps to reproduce the behaviour

create a spring-boot application
right click on the project run executor on the Nx console
edit the run configuration
run

Hi @SchwarzAmihay
First of all, I apologised for the (very) late answer... somehow it got off my radar and I didn't noticed it until now.
Could you try wrapping your options into --args="<YOUR OPTIONS HERE>", which is the expected format to send additional args to the executor.

Hi @tinesoft, thank you for getting back.
I did as you suggested and still it didn't work

Humm 🤔
Can you try running the same task directly, via a command line:
npx nx run back-ends-insights:run --args="<Your Options Here>"

Also, I'm not familiar with  "Edit Run/Debug configuration" dialog you showcased in your first post...

Where is it coming from?
I suppose you are using Intellij IDEA? Which version ?
Are you using a custom Nx Console plugin too or the official one (from @nrwl)?

Thank you @tinesoft .
I am using the webstorm with the official plugin https://plugins.jetbrains.com/plugin/21060-nx-console.
It appears that adding --args="-Dspring-boot.run.jvmArguments='........'" solves the problem, there is another problem that commas , are not excepted inside but after replacing it with ; it all works.
You can go ahead and close this issue,
Thank you

I'm glad I could help!
Don't hesitate to ⭐ the project, it helps me too ;-)


Multiple json files has been generated while running feature files in parallel. Do we have a report merger to get one html file

Im using
src/main/resources/cucumber-extents-report-runner.java.vm
Once runners are generated using below code to execute

${surefire.fork.count}
false
-Duser.language=en
-Xmx1024m
-XX:MaxPermSize=256m
-Dfile.encoding=UTF-8
false

**/*IT.class

true

This plugin only generates the runners, it doesn't actually handle test execution or any buildphases that follow after it. You'll have to create a tool that merges the json files yourself. and possibly a maven plugin to go with it.
I find that the cucumber-reporting tools for fairly well with parallel files though:
https://github.com/damianszczepanik


The rendered HTML markup for the example is inconsistent with the source code

The source code is:
@inherits LayoutComponentBase
@layout ProductionsLayout

Doctor Who™ Episode Database

    Master Episode List
    Search
    Add Episode

@Body

    @TrademarkMessage

@code {
    public string TrademarkMessage { get; set; } =
        "Doctor Who is a registered trademark of the BBC. " +
        "https://www.doctorwho.tv/";
}

and
@inherits LayoutComponentBase

Productions

    Master Production List
    Search
    Add Production

@Body

    Footer of Productions Layout

But the rendered HTML markup is:

Productions

            Main Production List
            Search
            Add Production

Doctor Who™ Episode Database

            Main Episode List
            Search
            Add Episode

Episodes

...

...

...

            Doctor Who is a registered trademark of the BBC.
            https://www.doctorwho.tv/

            Footer of Productions Layout

The difference is that where the source code uses ' maser ', the rendered HTML markup is the word 'main' instead.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 251fbc5f-ce3e-4036-ba2b-f641d7de4e27
Version Independent ID: 58e0022a-ac6c-9bf8-380a-40b7d068a887
Content: ASP.NET Core Blazor layouts
Content Source: aspnetcore/blazor/components/layouts.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

Thanks, @wenhx ... I'll fix it.

I'm going to move this over to the blazor-samples repo, which is where the problem resides.

I'll leave this open. I'm going to update some NITs on the naming of some of the href values. They don't really matter, but I'd like to improve the consistency. This issue will close shortly after I make the updates.


Thanks for your outstanding work

Thanks for your outstanding work!
Is your idea borrowed from the idea of pix2pix-zero?But I don't think I saw you cite or mention about pix2pix-zero in your paper?

Hi,
Thanks for your issue. That is true, I got inspiration from pix2pix-zero and I do have a citation to this paper:


Negative assertion messages don't work in jasmine

  it('renders the name', () => {
    expect(wrapper).not.toIncludeText('lars van der hoover');
  });

Failure message: Expected <SuperCoolComponent> to contain "lars van der hoover" but it did not.
Looks like https://github.com/blainekasten/enzyme-matchers/commit/5d4b5505c0e8ce0532a50aab2a7d73cfde07ea87 removed negated messages for jasmine

@atomanyih yikes! That's not good.. I did change things around how those things work and I primarily focused my effort around jest.. Sorry about that.
Are you interested in trying to fix this?

@atomanyih this should be fixed now in 3.7.0! Give it a try and let me know


Added JEXL3 as a syntax alias for JSyntaxTextArea

Description
Added jexl3 as a language alias for text/java, for use with JSyntaxTextArea:
Add: jexl3=text/java to textarea.properties
Motivation and Context
The JSR223 and other similar components that use JSyntaxTextArea may set the language to JEXL3, which is a perfecly valid scripting language name, but the syntax highlighter won't recognize and and won't enable the highlighting. By adding this alias, the issue is resolved. Considering that an alias already existed for jexl2, it makes sense that jexl3 be added.
How Has This Been Tested?
The change was tested in a custom build. Because of the nature of the change (adding a property mapping) there is no risk of breakage. Furthermore, the value of the property mapping is verified to be good (same as is used in other mappings, i.e. for jexl2).
Screenshots (if appropriate):
Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

[X] My code follows the code style of this project.
[X] I have updated the documentation accordingly.

Thanks for contributing


docs: new module tools doc

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] I have updated changeset
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: 10Derozan:x: targeralYou have signed the CLA already but the status is still pending? Let us recheck it.


Breaks on latest Kord snapshots

Trying to use the bot function breaks with latest kord version
Exception in thread "main" java.lang.NoSuchMethodError: 'int dev.kord.core.ClientResources.getShardCount()'
    at today.howoldisjava8.discord_bot.LauncherKt.main(Launcher.kt:91)

The problem is this line
https://github.com/kordlib/kordx.commands/blob/49848297d2b87ad04081f905fc9fa9ca727f1bd6/kordx-commands-runtime-kord/src/main/kotlin/com/gitlab/kordlib/kordx/commands/kord/BotBuilder.kt#L115
Since the called functions is inline when compiling kxc it inlined this code
https://github.com/kordlib/kord/blob/aa46ddf6aa7257d710dc535b4f4c26c95a38763a/core/src/main/kotlin/Kord.kt#L114-L128
but the implementation has been updated to
https://github.com/kordlib/kord/blob/62ab68e41ef24e55d73802efa4f0ba7158c15ddd/core/src/main/kotlin/Kord.kt#L115-L129
this causes problems as ClientResources.shardCount no longer exists

Should be fixed now. Will wait for @Warrior__zZ to confirm

I used gradlew build --refresh-dependencies and it worked!


Unified Service Desk Team Blog link is broken.

Unified Service Desk Team Blog link is broken.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc2f3bb3-5b43-29c3-7954-5376486d0226
Version Independent ID: 8c799be3-f851-0663-bb28-0ef80c7fd496
Content: Unified Service Desk Guide
Content Source: ce/unified-service-desk/unified-service-desk.md
Service: dynamics-365-customerservice
GitHub Login: @v-sailab
Microsoft Alias: v-sailab

@ZohaibUddinKhan
Thanks for pointing this out. The broken link has been fixed and the updated content is published.
Thanks,
Jaya


Refetch bid increments

This is initial work that @sepans and I did for PURCHASE-168. It needs tests still, and will conflict a bit with @yuki24's work on consolidating the two confirm bid components, but basically we just pass along a callback to get executed whenever a bid has been processed (and, therefore, the increments need to get updated). We pass this function as a prop to the route pushed onto the navigator. Sepand and I will wrap this up tomorrow.

Fails

:no_entry_sign:

No CHANGELOG added.

:no_entry_sign:

[danger-plugin-jest] Could not read test results. Danger cannot pass or fail the build.

  Generated by :no_entry_sign: dangerJS

Okay, wrapped this up. I added some tests for the refetching and cleaned up a few tests in BidFlow-tests.tsx that were using the Relay component directly instead of the component that it wrapped. This caused a problem trying to inject in our own faked Relay environment, which now works.

CI is failing but it's due to a hang. Travis is having a current service outage, looks unrelated so I've restarted the builds. We'll see!

Adding --forceExit to the Jest invocation should fix things, but I'd prefer to know why this PR is making Jest hang. I'll take a look.

Re-marked the PR as a WIP to narrow down which tests are causing the hangs.


Fix incorrect result of max aggregation fun with collation ci

What problem does this PR solve?
Issue Number: close #6807
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/cc @windtalker @ywqzzy

/run-integration-test

Maybe you can add a ut.

It's a little bit troublesome.

/run-unit-test

/merge


Why can it be predicted whether the ego-vehicle will collide with other traffic participants?

Thanks for your work.
In your work,you use the bounding box as the node of the graph structure,but the ego-vehicle does not appear in the video frame.Why can it be predicted whether the ego-vehicle will collide with other traffic participants?
Looking forward to your reply.

@fdsaggaw This is a good question. In general, traffic accidents could happen on either the viewed objects or the ego-centric vehicle. For ego-centric accidents, they can be predicted by the temporal dynamics manifested in the visual scene, e.g., the frontal viewed vehicles/pedestrians becoming visually larger indicates high ego-centric accident risk in the near future.  Therefore, we assume that they viewed objects still can be used to model the scene dynamic for ego-centric accident anticipation.
Besides, we also notice that in some video samples, only the ego-centric vehicle involved in a traffic accident, e.g., the ego-vehicle runs out of its driving lane and finally rollover due to slippery road conditions. For this case, we admit that graph network may not help a lot and it could be a promising future research direction.

Thank you for your answer.
In addition，the frame-level and all object-level features are concatenated to represent  the node of the graph structur.What is the effect of merging the frame-level feature?

@fdsaggaw By incorporating the frame-level feature, extra information about the background of the traffic scene can be introduced into the model. In this work, we follow the same motivation as the baseline work (Chan et al, ACCV'16) where the full-frame feature also shows a bit of performance gain.


TS2304: cannot find name "xxx"——after update to rc.0

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Windows 10
Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

@angular/cli: 1.0.0-rc.0
node: 6.9.1
os: win32 x64
@angular/common: 2.4.8
@angular/compiler: 2.4.8
@angular/core: 2.4.8
@angular/forms: 2.4.8
@angular/http: 2.4.8
@angular/platform-browser: 2.4.8
@angular/platform-browser-dynamic: 2.4.8
@angular/router: 3.4.8
@angular/cli: 1.0.0-rc.0
@angular/compiler-cli: 2.4.8
Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

follow update instruction from beta.32 to rc.0
The log given by the failure.

Normally this include a stack trace and some more information.

webstrom failure:

Nothing change just cover the src/app folder.

remove global cli and clean cache.
install the rc.0
use ng new upgrade-project --skip-install to new a update project.
copy my src/app folder and paste it into update-project cover the old one.
run ng serve works well ,no errors output, but all my file with "confirm","document", etc, got a note.

Mention any other details that might be useful.
If I cancel the settings in webstorm, it works fine.

Webstorm version:
2016.3.3
Anyone the same?

Thanks! We'll be in touch soon.

Same here, seems that it's due to changes with tsconfig*.json files.

After getting some sweat, I found the workaround:
The new tsconfig.json at the root is the culpirit, as it is it cannot compile the app files properly.
Change it to this and it will work again:
{
  "compileOnSave": false,
  "compilerOptions": {
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "lib": [
      "es2016",
      "dom"
    ],
    "target": "es5"
  }
}

It was missing the dom lib and a target to properly compile files.

tsconfig now work by inheritance, so tsconfig.app.json is the one used to compile the app, and does include the dom library, that why the CLI compilation is fine.
On the other hand, IDEs are lost with so many files and use the one they find at the root, that's why you see warnings in your app when using the dom, or in your tests (there is now a dedicate tsconfig file for the tests).
This was introduced by https://github.com/angular/angular-cli/commit/69e6c717fd28a71ee771803ee8dfd14a01ed02ff
@filipesilva do you think that IDEs are ever gonna understand the separate tsconfig? Some IDEs don't allow to specify several ones, how will they get that the src files must be compiled with tsconfig.app.json and the tests with tsconfig.spec.json?

@sinedied comment is spot on. I forgot to leave the dom lib there at the root. @deebloo's PR will fix it.
@cexbrayat nope, don't think they'll even understand. IDEs will use the top-level one for everything so it will essentially but a mish-mash of all the common parts. It's unfortunate and I wish there was a better solution.
As long we need two tsconfigs in the same folder (app/specs) I don't see a better alternative.

@cexbrayat @filipesilva AFAIK, Webstorm (and other Jetbrains similar IDEs) use the most top-level tsconfig.json file it finds for a specified folder, so that's why it was working fine until the extra separation and renaming.
Maybe the e2e/app config could be renamed to just tsconfig.json, while keeping the one for the spec like it is (and maybe removing the root tsconfig.json?) would be better so the IDE could catch the correct config (except for unit tests)?

@sinedied in that case the IDE would still not catch the correct config for tests (like you said). You'd then have to fiddle with the app tsconfig until it covered both app and unit test files which would leave you were we were before.
So if you have to compromise, it's better to compromise in a central place while making it obvious what each tsconfig does, and making them independent.

@deebloo I'm afraid just adding the dom library does not fix the issue, you also need to add the target property with a value >= es5 to fix the errors in Webstorm (and other IDEs I think).