Improved SSAO2 for sample count <16

Summary
This fix massively improves SSAO2 when using low sample counts, like the default 8.
Background
It was discovered as part of PR #13621 but is submitted as a new PR since 13621 is now all about adding control over the SSAO2 denoiser without changing anything by default.
This small change however is so massively positive in all the tests I have done that it shouldn't be left out by default but be considered a bugfix.
How it works
The fix is rather simple. When calculating if sample X is occluded by sample Y in the SSAO2 calculations we considered everything with a depth difference of 0 (zero) to mean Y occludes X. However, this does not take any calculation or precision errors into account, which causes samples along a "flat" surface to occlude each other. Basically, the flat surface was occluding itself...
This fix adds an epsilon of sorts to the calculation. The value 0.02 was selected from testing and gave the best improvements on all tests I did and at the same time practically left the 16-sample case untouched.
That said, on hardware that doesn't have the same precision in the shaders. might benefit from a higher threshold, as would some scenes like the kitchen example. But going over 0.02 starts to affect samples >=16 which isn't great from a backward compatibility standpoint.
I did not make this into a tunable setting, since I don't expect that a user of Babylon.js would understand how it affects the shader calculations. This should just work.
Test results
In the screenshots below, the "8x" part denotes how many SSAO2 samples were used, old version is on the left and the new one is on the right.
Notice how the fixed version is pretty similar to the 16x reference when the sample count goes down. But the old version goes bananas with incorrect occlusions everywhere. Also note that the two versions at sample count 16 are basically identical.
The images were saved without the blur-stage of the SSAO2 filter active, to better show the SSAO2 calculations.
Terrain (#N96NXC#127)
16x

12x

8x

4x

Cat (#T3K2SA#1)
16x

12x

8x

4x

Room (#LCUPCU#14)
16x

12x

8x

4x

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@Popov72, could you please take a look at this one? It is fairly important IMHO.

Related issue: https://github.com/BabylonJS/Babylon.js/issues/12630

Snapshot stored with reference name:
refs/pull/13652/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13652/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13652/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/13652/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13652/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13652/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13652/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/13652/merge#BCU1XR#0

Just noticed @Popov72 comments and yup totally agree :-) making it configurable with default 0.02 would be great and lets merge it in the other PR ???
By the way, thanks a ton for all the improvments, it starts to look amazing !!!

The fix has now been moved to PR #13621 , closing this PR.


Add ReviewerSettings, related classes/methods and tests

This, and #65, #66, #67, #68 conflict with previous PRs in the series when merging to master. Is there anyway to rebase so they build on each other and merge in series, rather than having to resolve conflicts for each?

This stack of PRs should now be based on each other in increasing numeric order (e.g., #66 is based on #65, and so on).
(I'll stack related PRs better in future)


Fix the message displayed when no launcher is installed

"32blit flash launcher.blit" has never been a valid command. It would have once been "32blit flash save --file launcher.blit" but that is now deprecated in favour of "32blit install launcher.blit".

I think there was a hack in the tools to make that command work at some point... Anyway, install is definitely the right thing now.

Ooof, I've seen that screen so many times and never clicked :grimacing:  thanks!


[v2] Notifications Component

[ ] Implement custom in-app notifications (like in v1)
[ ] add wrapper around native https://github.com/phonegap/phonegap-plugin-push (@macdonst could probably help)

This should be high priority

Depends on #1610

It would be pretty cool to add the ability to swipe up to remove iOS notifications, similar to how you would natively.

It would be better if open with slide down and close with slide up animation.


SSM packager: Unify build-only and build&upload steps

Description
Unify generate_ssm_package_files.py and packager.py into single tool
Exemplary usage of build only phase:
$ python packager.py
{'CS_AMAZON.zip': {'checksums': {'sha256': '63636ec912aa27a96d4f308ba8165ea468a5f5dd4f7952991f18c8a992310d38'}}}
Skipping AWS upload: please provide --aws_region, --package_name, and --s3bucket command-line options for upload
Package has been built successfully.

Exemplary output of build and upload:
$ python packager.py --aws_region=eu-west-2 --package_name=slukasik-falcon-install --s3bucket=slukasik-distributor
{'CS_AMAZON.zip': {'checksums': {'sha256': '63636ec912aa27a96d4f308ba8165ea468a5f5dd4f7952991f18c8a992310d38'}}}
INFO:botocore.credentials:Found credentials in shared credentials file: ~/.aws/credentials
Bucket already exists:
Uploading file CS_AMAZON.zip:
Successfully finished uploading files to s3 bucket. Took 0.33642101287841797s
AWS SSM Package is already up to date with the latest version
Created ssm package slukasik-falcon-install:

Fixed. Thanks!

Fixed. Thanks!


feat: tsup experimental dts

Closes #37

Are you kidding me? Was it simply a matter of a custom tsconfig file????


MM-47064 Migrate "components/suggestion/suggestion.jsx" to Typescript

Summary
Migrate "components/suggestion/suggestion.jsx" to Typescript
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/21099
https://mattermost.atlassian.net/browse/MM-47064
Release note
Migrate "components/suggestion/suggestion.jsx" to Typescript

Hello @gitstart,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Hey there!, Thank you for your PR.
Webapp is now part of mattermost monorepo now at https://github.com/mattermost/mattermost-server/tree/master/webapp Would you be interested in opening the PR over there?


Drop support for Postgres 10 and MS SQL 2017

To be merged after both 9.20.0 and 9.6.15 are released (probably 9.6.15 will be released later than 9.20)

To be deprecated in RN for 9.20.0, 9.18.2, 9.12.9, 9.6.15


More OIDC events, better data flow

Add new OIDC events:
#340 RedirectToIdentityProvider -> RedirectForAuthentication & RedirectForSignOut
#358 UserInformationReceived
#327 AuthenticationCompleted
Also, #372 make sure any mutable event state flows after the event.
@HaoK @brentschmaltz @tushargupta51 @PinpointTownes @Eilon @muratg

For the new events, I wonder if RedirectToAuthorizationEndpoint and RedirectToLogoutEndpoint wouldn't be a bit more expressive.

@PinpointTownes It's actually called the EndSessionEndpoint. RedirectToEndSessionEndpoint? Seems ok.

Yeah, but this name sounds weird (that's why I never use it). That said, if you want to use the official name, I'm fine.

Le 10 sept. 2015 à 18:26, Chris R<EMAIL_ADDRESS>a écrit :
@PinpointTownes It's actually called the EndSessionEndpoint. RedirectToEndSessionEndpoint? Seems ok.
—
Reply to this email directly or view it on GitHub.

Updated.

Updated. @HaoK @PinpointTownes @brentschmaltz

I'll test it in a real world app. Some renamed notifications look weird.

There's a terrible bug with the authorization code flow. I'll investigate.

On a related note, you should consider cleaning this code path: https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNet.Authentication.OpenIdConnect/OpenIdConnectAuthenticationHandler.cs#L374-L392
Now that the OIDC middleware has appropriate anti-XSRF countermeasures (ValidateCorrelationId), the state parameter is mandatory and having a null value should be treated as an error before calling ValidateCorrelationId.

Updated.

I briefly chatted with a friend about these notifications and we agreed they were terribly confusing. I suggest a much more aggressive renaming to match the standard names:

MessageReceived => AuthorizationResponseReceived.

IdTokenReceived/AuthorizationCodeRedeemed: replace them by TokenResponseReceived. When invoked after an authorization response (for what you name "id_token flows"), IdTokenReceived is basically useless as you already have  MessageReceived.

IdTokenValidated => AuthorizationResponseValidated and TokenResponseValidated.

Hmm, there's something to that... lets see...
There's a catch with MessageReceived, you don't actually know if it's an OIDC message / Authorization Response yet, it could be any form post or get query. OIDC does not require a restricted callback path.
Your IdTokenReceived argument seems to apply to AuthorizationCodeReceived as well. I think these have some value over MessageReceived because you're now in a validated OIDC flow (error, state, correlation, etc.).
AuthorizationCodeRedeemed -> TokenResponseReceived makes sense.
IdTokenValidated -> AuthorizationResponseValidated vs  TokenResponseValidated: There is an authorization response in both flows, but you only validate it in the implicit flow. Really the event is the big "Everything" validated at the end of the flow, almost like AuthenticationCompleted but it still has the details. How about just AuthenticationValidated?
On a related note comparing the two flows, it looks a little odd that code flow runs GetUserInformationAsync before Validated, but the implicit flow runs AuthorizationCodeReceived after Validated. Of the two, I think I'd move GetUserInformationAsync later.

Or maybe you could merge IdTokenReceived and AuthorizationCodeReceived into a single  AuthorizationResponseReceived.

There's a catch with MessageReceived, you don't actually know if it's an OIDC message / Authorization Response yet, it could be any form post or get query. OIDC does not require a restricted callback path.

Well, in its current form, MessageReceived is never called if the handler is not able to extract the OIDC message from the query string or the request form, which obviously limits the ability to retrieve the message from elsewhere: https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNet.Authentication.OpenIdConnect/OpenIdConnectHandler.cs#L337-L340. I'm not sure that MessageReceived is really useful as-is. One evidence is that you were not able to support response_mode=query even with this hook.
At this point, yeah, we don't know yet if it's a "standard-compliant" authorization response, but on the other hand, you have no way to guarantee that. Not to mention that an OIDC message that contains an error or has no state parameter is still an authorization response, at least semantically speaking.

Your IdTokenReceived argument seems to apply to AuthorizationCodeReceived as well. I think these have some value over MessageReceived because you're now in a validated OIDC flow (error, state, correlation, etc.).

Do you have a concrete use case for these events?
IMHO, AuthorizationCodeReceived would be more useful if it was renamed to TokenRequestSending and invoked just before sending the token request (to allow modifying the token request before sending it on the wire).

Or maybe you could merge IdTokenReceived and AuthorizationCodeReceived into a single AuthorizationResponseReceived.

Yup :+1:

IdTokenValidated -> AuthorizationResponseValidated vs TokenResponseValidated: There is an authorization response in both flows, but you only validate it in the implicit flow. Really the event is the big "Everything" validated at the end of the flow, almost like AuthenticationCompleted but it still has the details. How about just AuthenticationValidated?

AuthenticationValidated doesn't look too bad, but when implementing the hybrid, we'll need to validate both the authorization response and the token response (http://openid.net/specs/openid-connect-core-1_0.html#HybridAuthResponseValidation and http://openid.net/specs/openid-connect-core-1_0.html#HybridTokenResponseValidation), so I'm not sure it's worth adding a too generic event if we need to distinguish both steps.

On a related note comparing the two flows, it looks a little odd that code flow runs GetUserInformationAsync before Validated, but the implicit flow runs AuthorizationCodeReceived after Validated. Of the two, I think I'd move GetUserInformationAsync later.

Yeah, good idea :+1:

The ODICMessage constructor doesn't do any message validation, it would work with almost any query or form post, so MessageReceived will fire for most requests. Listening to it is the only place developers can pre-process or filter incoming messages.
I realized that AuthorizationCodeReceived is called at different places in both flows. In code flow it's just before redeeming the code, but in implicit/hybrid it is your chance to redeem the code yourself. I'll have to think about how to rationalize that. They may need to be two different events.

Updated PR.

The ODICMessage constructor doesn't do any message validation, it would work with almost any query or form post, so MessageReceived will fire for most requests. Listening to it is the only place developers can pre-process or filter incoming messages.

I never said it did (luckily, or I wouldn't use it massively :smile:). I just said that an OIDC message posted at client's redirect_uri endpoint is semantically an authorization response, even if it doesn't have the parameters you expect.

OIDC does not require a restricted callback path.

Talking about that, I wonder if this feature is still useful. IIRC, your main argument to keep it was to support "unsolicited assertions". With state now being mandatory, it's not possible anymore, since responses lacking a valid state - that can only be produced by the client app - will be rejected.

https://github.com/aspnet/Security/issues/455

I think the hybrid flow needs more work, but I'll call this good for now. @HaoK @brentschmaltz Can you take a quick pass?
https://github.com/aspnet/Security/issues/456

:shipit:


Added 404 Not Found Middleware

Can you move this further down after the existing Error Handler?
Can you change Not Found to Page Not Found

Thanks

It would probably be helpful to state what page address was not found.


🌱 sync OWNER file with main

Cherry pick the commit https://github.com/metal3-io/cluster-api-provider-metal3/pull/710 on owner file to release-0.5 was failing because of conflicts this PR syncs the file after resolving the conflict

/test-ubuntu-integration-release-0-5

@adilGhaffarDev

/assign @furkatgofurov7


6.18.3: pytest is failing

I'm trying to package your module as an rpm package. So I'm using the typical build, install and test cycle used on building packages from non-root account.

"setup.py build"
"setup.py install --root </install/prefix>"
"pytest with PYTHONPATH pointing to sitearch and sitelib inside </install/prefix>

Looks like it is some issue with importing modules. May I ask for help because few units are failing:
+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-testfixtures-6.18.3-2.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-testfixtures-6.18.3-2.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.12, pytest-6.2.5, py-1.10.0, pluggy-0.13.1
benchmark: 3.4.1 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
Using --randomly-seed=1016307898
django: settings: testfixtures.tests.test_django.settings (from ini)
rootdir: /home/tkloczko/rpmbuild/BUILD/testfixtures-6.18.3, configfile: setup.cfg
plugins: shutil-1.7.0, virtualenv-1.7.0, mock-3.6.1, cov-2.12.1, anyio-3.3.4, forked-1.3.0, xdist-2.3.0, flaky-3.7.0, tornasync-0.6.0.post2, console-scripts-1.2.0, trio-0.7.0, timeout-2.0.1, asyncio-0.16.0, freezegun-0.4.2, flake8-1.0.7, pyfakefs-4.5.3, hypothesis-6.29.3, benchmark-3.4.1, profiling-1.7.0, datadir-1.3.1, regressions-2.2.0, randomly-3.8.0, rerunfailures-9.1.1, yagot-0.5.0, requests-mock-1.9.3, django-4.5.1
collected 0 items / 1 error

================================================================================== ERRORS ==================================================================================
______________________________________________________________________ ERROR collecting test session _______________________________________________________________________
/usr/lib/python3.8/site-packages/_pytest/config/__init__.py:570: in _importconftest
    mod = import_path(conftestpath, mode=importmode)
/usr/lib/python3.8/site-packages/_pytest/pathlib.py:544: in import_path
    raise ImportPathMismatchError(module_name, module_file, path)
E   _pytest.pathlib.ImportPathMismatchError: ('testfixtures.tests.conftest', '/home/tkloczko/rpmbuild/BUILDROOT/python-testfixtures-6.18.3-2.fc35.x86_64/usr/lib/python3.8/site-packages/testfixtures/tests/conftest.py', PosixPath('/home/tkloczko/rpmbuild/BUILD/testfixtures-6.18.3/build/lib/testfixtures/tests/conftest.py'))
========================================================================= short test summary info ==========================================================================
ERROR  - _pytest.pathlib.ImportPathMismatchError: ('testfixtures.tests.conftest', '/home/tkloczko/rpmbuild/BUILDROOT/python-testfixtures-6.18.3-2.fc35.x86_64/usr/lib/pyt...
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
============================================================================= 1 error in 0.51s =============================================================================

My recommendation would be not to build a system package such as an rpm or deb, why are you trying to?
pytest is telling you that it doesn't like the fact that testfixtures/tests/conftest.py was compiled under rpmbuild/BUILDROOT but you're trying to use it under rpmbuild/BUILD.

So what is the sense/target/goeal of such unit?

I suggest you reach out to the pytest folks or read their docs.
Also, for clarity, this isn't "few units are failing", it's "no unit tests are being run due to this failure during test run startup".

@kloczek, check the SPEC file we have for Fedora. It's for 6.18.2 but should work for 6.18.3 as well (perhaps with some modifications).

My recommendation would be not to build a system package such as an rpm or deb, why are you trying to?

The reason to have testfixtures is that other packages depend on it.


Storage: Rename StorageHandle to StorageFileHandle

https://apiview.azurewebsites.net/Assemblies/Review/47c9ebbff8c0458fa2e7904eae34656f#Azure.Storage.Files.Models.StorageHandle

Closed with https://github.com/Azure/azure-sdk-for-net/pull/8125


Squash commits in branch gh-pages

To reduce repo size, the branch gh-pages should be squashed to a single commit.  This should be done once to remove the current history, and also done every time the branch is updated with new docs.
Here's the current size of the branch:
$ git clone https://github.com/azure/azure-sdk-for-net --branch gh-pages --single-branch net-gh-pages
Cloning into 'net-gh-pages'...
remote: Enumerating objects: 11480, done.
remote: Counting objects: 100% (11480/11480), done.
remote: Compressing objects: 100% (390/390), done.
remote: Total 208111 (delta 11337), reused 11125 (delta 11090), pack-reused 196631
Receiving objects: 100% (208111/208111), 320.17 MiB | 21.29 MiB/s, done.
Resolving deltas: 100% (167506/167506), done.
Checking out files: 100% (7160/7160), done.

Here's the size after squashing to a single commit:
$ git clone https://github.com/mikeharder-org/azure-sdk-for-net --branch gh-pages --single-branch net-gh-pages-squash
Cloning into 'net-gh-pages-squash'...
remote: Enumerating objects: 7074, done.
remote: Counting objects: 100% (7074/7074), done.
remote: Compressing objects: 100% (1177/1177), done.
remote: Total 202434 (delta 6862), reused 6033 (delta 5897), pack-reused 195360
Receiving objects: 100% (202434/202434), 315.58 MiB | 19.30 MiB/s, done.
Resolving deltas: 100% (161819/161819), done.
Checking out files: 100% (7160/7160), done.

The savings for this repo are relatively small because gh-pages does not have much history yet, but based on other repos the branch will quickly grow if it is updated often.

gh-pages Squashed to 3 commits


fix(Landing Page): fixed event registration form validation

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Create tests to createFliptSDK and its methods

It's necessary to create tests to the function createFliptSDK and its methods to guarantee code quality and exemplify in more detail to new users.
Actually createFliptSDK has two methods (you can see more about here):

[ ] evaluate
[ ] batchEvaluate

Both methods use window.fetch to make requests, mock these functions using the Flipt API as a reference.

Thanks @mechamobau !

@mechamobau  Hi! Sorry for the (huge) delay, work and kids were consuming my whole time and I was struggling with the Typescript with this exciting issue, but I managed to find a workaround!!
I hope those tests cover what you guys were expecting. Otherwise, let me know how I can improve.
Thanks!

Solved on #15


Include logic to render 3MF files sliced by Bambu Studio or Orca Slicer

Hey! Love the app. I noticed that the app didn't display thumbnails for 3MF files for projects created with Bambu Slicer or Orca Slicer. Looking at the Metadata folder inside the 3MF, it appears that these apps generate thumbnails for different angles/sizes/plates, which makes sense since you can create multiple plates in a single project with these apps.

I added some logic to extract plate_1.png from the 3MF file if it exists. Here's what that looks like on my end.

@DavidPhillipOster  any idea when you'll release a new build ?

About 3 hours from now.

I'll release a new version with your code about 3 hours from now.
On Tue, Feb 13, 2024 at 6:52 PM John Dyer @.***> wrote:

@DavidPhillipOster https://github.com/DavidPhillipOster any idea when
you'll release a new build ?
—
Reply to this email directly, view it on GitHub
https://github.com/DavidPhillipOster/ThumbHost3mf/pull/7#issuecomment-1943007402,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHI5FDS45KJDIB2CHOSYNDYTQRF7AVCNFSM6AAAAABDHNMS56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBTGAYDONBQGI
.
You are receiving this because you were mentioned.Message ID:
@.***>


fix: reset expected values before each test

What

Introduced by #81
Isolated test passes, but not when run with other tests: https://github.com/ScaCap/action-surefire-report/actions/runs/3782888948/jobs/6431129189

How

Reset expected values before each test using beforeEach

superseded by #111


Feature request: Flatten navigation properties of the class

As an example, the Class Person have a navigation  property 	department of type Department, as given bellow:
           class Person
	{
		public int id       {get;set;}
		public string name  {get;set;}
		public Department department  {get;set;}
	}
	class Department
	{
		public int Id       {get;set;}
		public string name  {get;set;}
	}

Currently NJS support two alternative for the  schema generation (and that's fantastic):

Department as a reference and it's defined in the definitions section.

Or as a reference to external schema in filesystem or web which is done by the nice change in issue
https://github.com/NJsonSchema/NJsonSchema/issues/337

Is't possible for  NJS  to support of FlattenNavigationHierarchy  for the navigation properties to get the following schema:
	{
	  "title": "Person",
	  "type": "object",
	  "properties": {
		"id": {
		  "required": true,
		  "type": "integer"
		},
		"name": {
		  "required": true,
		  "type": [
			"string",
			"null"
		  ]
		},
		"department": {
		  "required": true,
		  "type": [
			"object",
			"null"
		  ],
		  "properties": {
			"Id": {
			  "required": true,
			  "type": "integer"
			},
			"name": {
			  "required": true,
			  "type": [
				"string",
				"null"
			  ]
			}
		  }
		}
	  }
	}

This  can be manged from within JsonSchemaGeneratorSettings class  by adding a property something like:
bool  FlattenNavigationHierarchy
Thanks

Interesting find. I hadn't come across this yet, however, you are able to achieve this by using custom TypeMappers. I'm doing this currently.

Good idea.
I tried using the built-in Type mappers , but the generated schema look like the default generation with definitions section.
Here is my code:
             var deapartmentSchema = await JsonSchema4.FromTypeAsync<Deapartment>(new JsonSchemaGeneratorSettings());

        var schema = await JsonSchema4.FromTypeAsync<Person>(new JsonSchemaGeneratorSettings
        {
            TypeMappers =
                        {
                            new ObjectTypeMapper(typeof(Deapartment),deapartmentSchema)
                        }
        });
        Console.WriteLine(schema.ToJson());

The generated schema has definitions section:
	{
	  "$schema": "http://json-schema.org/draft-04/schema#",
	  "type": "object",
	  "title": "Person",
	  "additionalProperties": false,
	  "properties": {
		"id": {
		  "type": "integer",
		  "format": "int32"
		},
		"name": {
		  "type": [
			"null",
			"string"
		  ]
		},
		"Deapartment": {
		  "oneOf": [
			{
			  "$ref": "#/definitions/Deapartment"
			},
			{
			  "type": "null"
			}
		  ]
		}
	  },
	  "definitions": {
		"Deapartment": {
		  "type": "object",
		  "title": "Deapartment",
		  "additionalProperties": false,
		  "properties": {
			"id": {
			  "type": "integer",
			  "format": "int32"
			},
			"name": {
			  "type": [
				"null",
				"string"
			  ]
			}
		  }
		}
	  }
	}

I'm interesting  waiting your  custom TypeMappers  :)
Thanks

@moh-hassan unfortunately you won't be able to use ObjectTypeMapper. ObjectTypeMapper uses references by design. See: TypeMapper.UseReference. What you're looking for is a complex object type mapper that uses inline schemas (UseReference=false).
I'm doing this as well because our product's API is quite complex. Simply pointing to object definitions won't produce accurate API documentation. Nor will relying on attributes or xml documentation.
I'm hoping to contribute my work on this soon but this week is quite busy. I definitely recommend digging into NJsonSchema's source to better understand the mechanics around it's design.

FYI: Added JsonSchemaFlattenAttribute: https://github.com/RSuter/NJsonSchema/commit/c1484a03e864fe086be5fb99a42450196bb1d4ee
See wiki: https://github.com/RSuter/NJsonSchema/wiki/Inheritance#flatten-inheritance-hierarchy

Thanks @RSuter,
Glad that JsonSchemaFlattenAttribute is implemented

I see that the OP is about something else. For the requested scenario we’d need something similar (opt-in) but then suppress creating a reference and instead inline it. What about other usages of the class?

Yes, OP is about something else.
The new feature is for Flatten inheritance hierarchy but OP is about replacing "$ref": "#/definitions/Department" with in place department schema.
I tested JsonSchemaFlattenAttribute  in fiddler and has no effect to flatten $ref.
I Think it's better if it's named 'JsonSchemaFlattenInheritanceAttribute'
I hope to have an implementation for Flatten navigation properties of the class

I’d call it “inline property schema”

Ok, that is better. :)


Fixed the instagram hover issue on footer

Related Issue
Fixes:  #2744
Description

Fixed the Instagram size issue of footer when hover.
Now, the Instagram icon will have the same size as other social media icons when hover.

Type of PR

[x] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
https://github.com/user-attachments/assets/733a3935-4927-492b-a480-e7726536c664
Checklist:

[x] I have made this change from my own.
[ ] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@RitiChandak can you please add 'level1' label in this pr. 🙏

Please add level1 label if you can 🙏

@RitiChandak @huamanraj @anuragverma108 can you please add that level1 label in this pr please 🙏


Swift 6 Compatibility

Swift 6 Compatibility
:recycle: Current situation & Problem
This PR enables strict concurrency and makes SpeziOnboarding compatible with Swift 6.
:gear: Release Notes

Swift 6 Compatibility.
Fixed an issue with onboarding identifiers not working with Xcode 16

:books: Documentation
--
:white_check_mark: Testing
Unit tests were adjusted to be more stable and run slightly faster.
:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

@PSchmiedmayer we currently skip the export consent form tests after opening the share sheet. With the current beta simulators the save button just stays disabled. Generally, the Files app is completely broken (you cannot create Folders etc).
Therefore, the test is skipped if we encounter a disabled "Save" button. Nonetheless, the test itself was improved to be more stable when running on 17.5 versions.
Looking at the current build output, it seems there are only iOS 18 simulators available, even when building with Xcode 15. Is there anyway to keep the iOS 17.5 simulators even though if we might need to manually tag the version in the destination for SpeziOnboarding. Otherwise, it seems like the PDF export has to remain untested till Apple fixes that issue (if they do 🙂).

@Supereg Unfortunately it seems like automatically using an iOS Simulator version higher than the Xcode version was bundled with is a regression in Xcode. Only saw this with iOS 18 simulators so far.
I agree that we should disable the tests for now; they mainly just test the files app anyways (which Apple doesn't seem to do 😄) and it is not our responsibility to add UI tests for their applications.
I did a similar thing in #51 and it seemed to have worked there.
Fine with merging this as is; thanks for all the work @Supereg!

I wrote the tests in a way, that they automatically run again if they detect that saving files is possible again.
In this case it's not about testing the Files App, but performing some validations for the generated PDF document. This is how we, e.g., detected that the signature field was never shown on visionOS.
But we are reworking the PDF export anyways. So it might be less fragile anyways and less platform-dependent anyway. And maybe there is a way to just unit test the export? This would also be much faster to execute.


[Internal] Query: Adds CosmosUndefined to represent undefined values

Description
Currently undefined values are sometimes represented by null in the query pipeline. At other times, undefined values are unhandled. In this change we use a more formal approach of representing undefined by a strong type called CosmosUndefined which is a CosmosElement.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Closing issues
To automatically close an issue: closes #IssueNumber

            {

we should either assert that we should never get an undefined, or we need to skip properties w/ undefined value
Samer for arrays

Refers to: Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Distinct/DistinctHash.cs:185 in 24feba8. [](commit_id = 24feba8aaa0a5785bc51936b92ad9a4897084201, deletion_comment = False)

/azp run

/azp run


Print warning in Executor if condor_chirp is not found.

Fixes #9674
Status
Ready
Description
Print warning in Executor if condor_chirp is not found. This will be seen in the JobCache of the JobCreator.
Is it backward compatible (if not, which system it affects?)
YES

@amaltaro
This will print something like this in the job stderr. I wasn't sure where else to put it, because chirp not being found should not fail the job, so we can't use WMExceptionFailure, and I wasn't sure how to propagate a warning like this to an agent component instead. This should at least spot the issue from the job logfiles in JobCache though.
INFO:root:Executing CMSSW. args: ['/bin/bash', '/srv/job/WMTaskSpace/cmsRun1/cmsRun1-main.sh', '', u'slc7_amd64_gcc700', 'scramv1', 'CMSSW', 'CMSSW_11_0_0_pre1', 'FrameworkJobReport.xml', 'cmsRun', 'PSet.py', '', '', '']
WARNING:root:condor_chirp was not found in the system.
WARNING:root:condor_chirp was not found in the system.
INFO:root:addOutputFile method called with outputModule: FEVTDEBUGoutput, aFile: None
INFO:root:addOutputFile method fileRef: , whole tree: {}
INFO:root:Steps.Executors.CMSSW.post called

@amaltaro Ok, I simply didn't didn't know how to communicate this at the condor level without chirp either, as we can't change the exit code for a failure and we can't inject classads without chirp. I think this is good enough now. The main issue (abscense of chirp) was at the GlideinWMS level. I have already been in touch with that team and they issued a hotfix here (I just put this in the github issue): https://cdcvs.fnal.gov/redmine/issues/24381

Thanks Kenyi.
And given that this fix would not change the outcome or condor_chirp, I assume there is no need to patch the production agents either, right?

Correct!


[Feature Request] - Add a nuxt module

Clear and concise description of the problem
I want to use this component library in Nuxt, with automatic importing and tree shaking. I didn't see any relevant configuration in the code repository and documentation, only unplugin related information.
Suggested solution
I think can be added to the component library. It can also be added to the Nuxt repository.
Describe alternatives you've considered
Here is my simple code:
import { addComponent, defineNuxtModule } from '@nuxt/kit'

const COMPONENT_LIST = [
  'OAffix',
  'OAlert',
  'OAvatar',
  'OAvatarGroup',
  'OBacktop',
  'OBadge',
  'OButton',
  'OButtonGroup',
  'OCard',
  'OCheckbox',
  'OCollapse',
  'OCollapseItem',
  'OConfigProvider',
  'OEmpty',
  'OIcon',
  'OLink',
  'OMessage',
  'OPopup',
  'OProgress',
  'ORadio',
  'ORadioGroup',
  'ORate',
  'OSwitch',
  'OTag',
  'OText',
  'OToolTip',
  'OTrigger',
]

export default defineNuxtModule({
  meta: {
    name: '@onu/nuxt',
    configKey: 'onu',
    compatibility: {
      nuxt: '^3.0.0',
    },
  },
  async setup() {
    COMPONENT_LIST.forEach((name) => {
      addComponent({
        name,
        export: name,
        filePath: 'onu-ui',
      })
    })
  },
})

Screenshots or Videos

For those who are impatient like me and want to utilize this now:

Make sure onu-ui package is installed.
Create a modules folder in your Nuxt project root, if you don't already have one.
Create a new file: modules/onu-ui.ts > copy and paste in the code given by FuBaooo above.

If you have debug enabled in nuxt.config.ts, you will see the module load up

Added on #177

There are still some problems with this package. I will release it after I fix it in my spare time. Thanks all guys.

I'm really happy so see Nuxt support - I am trying to get it to work , however, I want to draw your attention to the instructions on https://onu.zyob.top/guide/install.html#using-modules-in-nuxt
Right now it's not possible to install this package for the reasons mentioned on 177, but the instructions are still published.
It would be beneficial to edit them until such time that the package is ready to use, to reduce confusion  😃

Thanks for your focus, our package is not perfect enough, I will take some time to update it next.


Get rid of 'rash' gem.

Closes #1

missing_method call should not omit calling super. There missing_method always respond with some value (mostly nil), but it should not be like this:
Result.respond_to?(:foobar) # => false
Result.foobar # => nil

This is more logical behavior:
Result.respond_to?(:foobar) # => false
Result.foobar # => raise NoMethodError

It will introduce breaking changes, so if you agree to do so, you also need to update minor version number.

BTW Breaking changes call for major version number update, not minor.

closing in favor of #4. Thanks, this looks very clean!


Lazy masked fill_value retrieval for NC save

Enables lazy masked fill_value retrieval for NetCDF save.
Dask exposes no mechanism for retrieving the fill value of a lazy masked array (indeed, arguably this is currently not a soluble problem). This PR proposes a workaround for this problem, exposes the workaround as a function in iris._lazy_data and integrates the function into the NetCDF saver.
Specifically, the workaround realises the smallest possible slice of the lazy masked data array that, when realised, contains the required fill value. Turns out the smallest possible slice is actually an empty slice:
>>> m = np.ma.masked_array([0, 1, 2], mask=[1, 0, 1], fill_value=9999)
>>> dm = da.from_array(m, chunks=(3,), asarray=False)
>>> dm[:0].compute().fill_value
9999

Fixes #2703.

Note: no tests yet! I thought I'd push the changes so that people could get eyes on the proposed functionality.

Now with unit tests! Still got a bunch of existing test failures to deal with, though.

@dkillick Awesome thanks 👍
I'm going to bank this PR and follow-up with any/all rework in another PR, given your unavailability.


Fix class slides script

The dev/SDM-for-class-slides.R script needs to be terra-fied.

Bulk of work addressed in aeea47a.


Fix up ustack documentation

The ustack documentation was missing the stack mode argument. It was
also referencing nothing.

thanks!


Blazor String Parameters in event handlers in the new Preview 9, rc.

Is your feature request related to a problem? Please describe.
Hi I just updated from AspNetCore 3.0 Preview 7 to AspNetCore 3.0 RC1 and there the event handler syntax changed significantly.
The old version was this:
onclick=@(async ()=> SetPagerSize("forward"))
I havent found something yet, but is there a way to pass strings as parameters.
There passing string parameters was possible
How can I pass strings to functions in RC1?
<button class="btn pagebutton btn-secondary" @onclick="(async ()=> NavigateToPage("next"))">Next
since the content of @onclick= needs to be inside "", the string "next" will end this string. Is there already a syntax to fix this? When I use '' like in javascript
Describe the solution you'd like
Not shure what would be the best soltion, now I extract all my strings to constants. In javascript you can always use '' inside the "", but that would violate the C# syntax.

Enclose it with apostrophes:
@onclick='(async () => await Foo("bar"))'

Thanks for contacting us, @MichaelPeter .
The parser is smart enough to still parse ", even when it seems it's wrapped twice:
@OnClick="@(async ()=> NavigateToPage("next"))"

If this is not working for you, please let us know and we'll look into this further.

Thanks that solved my problem :)


Animate to Component by adding className via event

This is a practical question. I was going to ask the question on stackOverflow but my rep is to small to create a tag styled-component and due to the very recent nature of this project I am unsure I will receive an answer.
Similar to the Login-Flow of @mxstbr https://github.com/mxstbr/login-flow, I am trying to add a neat 'Tremble' effect via onClick. I am not sure how to do this.
Right now I have created a Tremble styled-component:
    const shake = keyframes`
       10%, 90% {
        transform: translate3d(-1px, 0, 0);
      }

      20%, 80% {
        transform: translate3d(2px, 0, 0);
      }

      30%, 50%, 70% {
        transform: translate3d(-4px, 0, 0);
      }

      40%, 60% {
        transform: translate3d(4px, 0, 0);
      }
    `;

    const Tremble = styled.div`
      display: inline-block;
      &:hover {
        animation: ${shake} 0.82s cubic-bezier(.36,.07,.19,.97) both;
        transform: translate3d(0, 0, 0);
        backface-visibility: hidden;
        perspective: 1000px;
      }
    `;

    export default Tremble;

I also have my Form:
    export class FormLoginTest extends React.Component { // eslint-disable-line react/prefer-stateless-function

      static propTypes = {
        isTrembling: React.PropTypes.bool
      };

      static defaultProps = {
        isTrembling: true
      };

      onMakeTremble = () => {
          alert('clickity');
      }

      render() {
        return (
          <Form isTrembling={this.props.isTrembling>
            <ContainerFluid>

Login

            </ContainerFluid>
            <ContainerFluid>
              Username
              <Input type="text" id="username" placeholder="bob" autoCorrect="off" autoCapitalize="off" spellCheck="false" />
            </ContainerFluid>
            <ContainerFluid>
              Password
              <Input id="password" type="password" placeholder="••••••••••" />
            </ContainerFluid>
            <ContainerFluid>
              <Button nature="success" onClick={this.onMakeTremble}>Hello</Button>
            </ContainerFluid>
          </Form>
        );
      }
    }

    export default FormLoginTest;

I know my code is messy, as stated in another issue, I am actually learning how to code with react -_-.
Is there a way to apply a new Css className to my FormLoginTest via onClick so that the Tremble effect is applied to the component.
This actually leads me to the next question: If i wanted to create utilities class, say "pull-right", how could this be done and applied without using an css style sheet?

I haven't worked with styled-components at all yet, in fact I just found this repository, however I think this is a React question first.
I don't think you want the button to be trembling continuously, do you? That would be annoying for users.  So you probably don't really want it passed as a prop without the ability to toggle it.  I think you would rather state here.
getInitialState() {
  return {
    isTrembling: false  // or this.props.isTrembling
  };
}

Then your onClick function would just set that to true for an interval (I'll leave the setTimeout as an exercise to the reader - use React Timer Mixin though!).
this.setState({isTrembling: true}); // or isTrembling: !this.state.isTrembling to toggle it

and lastly in your render do something like this
<Tremble isTrembling={this.state.isTrembling}>
   <Button etc.. />
</Temble>

I'm trying to do something similar. I'd say you need to setState via your event and use the pass props in approach to fire our animation.  See the docs for passed in props


Accept newlines \n in the terminal backend

Currently, the terminal backend is not happy with control characters (for good reasons), but maybe it is more user-friendly to turn \n into pp_force_newline especially for beginners.
@mmcqd Maybe we can have a raw option to turn off the conversion?

Closed by #59.


First image is only half height

I have a php loop loading images into slick slider, so I added slick-lightbox to that gallery and it all works perfectly, but for some reason the very first image I click on to open in a lightbox is displayed only half or even third of its height. When I click on arrows back and forth, all other images load correctly. And if I go back to the first one it also becomes correct height. Only the first lick display is wrong.
Also, if I click and drag on that image, kinda drag the cursor down, height changes to the full as needed. I don't know what kind of trickery is it.
What do you think it could be?

I have no idea :/ I'd be willing to help if you'd manage to put up a broken demo somewhere. Are you doing anything special with the plugin, or is it just a simple invocation?

Lack of response. Feel free to reopen.


Updated instructions for installation on Google Cloud Run

Updated instructions for installation on Google Cloud Run.
Fix #4177

@kesarwam is this still relevant? can close?


Create proxy objects

Add in proxy objects for partially known entities.

Proxy objects will take a lot more time to complete than is currently available. They will be moved to the next release, and agents will replace them for release 0.1.0


CI Use of actions-rs

Hi,
Thanks for all the work on this template, it is a great starting point.
I noticed that the action used to setup rust is no longer actively maintained and has been officially archived by the owner.

On my other projects I use the actions-rust-lang/setup-rust-toolchain action and plan to also try to update my copy of the workflow but wanted to know if a pull request for this would make sense. Don't have the bandwidth to do it right now but just checking in case there is a reason I shouldn't make a PR.

Closed by https://github.com/emilk/eframe_template/pull/139

@emilk that PR only removed a single use of actions-rs. It still used in a bunch of other places.
I'm currently testing a pipeline that also drops cross. It was my understanding that cross was required due to us targeting musl without running in a musl environment. Since that PR dropped musl, and assuming that no other issues are created by dropping it, this might massively simplify CI.


[AutoDiff] Fix cloned curry thunk verification error.

Differentiation has special support for canonicalizing differentiable_function
instructions of curry thunk applications: curry thunks are cloned to a version
returning a differentiable_function of the original return value.
In cloned curry thunks, the differentiable_function instruction is now
created right after the returned value's defining instruction, not at the end of
the function. This avoids stack_alloc/stack_dealloc ordering issues.
Resolves TF-1037.

@swift-ci Please test tensorflow

@swift-ci Please clean test tensorflow

@swift-ci Please clean test tensorflow


Add "fix all" code action

Suggested by ChenCMD

:tada: This issue has been resolved in version 2.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Create a wallet table in the database

The wallet table is going to contain all the tokens, addresses or IDs related to the payment information of the user.
We can add the following columns:

bitcoin_onchain_address
lnd_invoice_macaroon
btcps_api_key
alby_oauth_token
voltage_node_id
balance
balance_last_updated

Here, balance will be used to keep track of the money held by the Trinary Superadmin till the user decides to withdraw it from the platform.

I think we will need voltage_api_key as well so ProjectAdmins can enable/disable the federated wallet option and cover those costs themselves


[Rule Migration] migrate eslint-plugin-react rules

Migration Status
Correctness and best practices rules

[x] react/jsx-boolean-value ···················-> @eslint-react/jsx/prefer-shorthand-boolean
[x] react/jsx-fragments ·······················-> @eslint-react/jsx/prefer-shorthand-fragment
[x] react/jsx-key -----------|··················-> @eslint-react/jsx/no-missing-key
[x] react/no-array-index-key |··················-> @eslint-react/jsx/no-array-index-key
[x] ·························|··················-> @eslint-react/jsx/no-duplicate-key
[x] -------------------------|··················-> @eslint-react/jsx/no-spreading-key
[x] #102
[x] react/jsx-no-useless-fragment ·············-> @eslint-react/jsx/no-useless-fragment
[x] react/jsx-no-leaked-render ················-> @eslint-react/jsx/no-leaked-conditional-rendering
[x] #104
[x] react/jsx-no-comment-textnodes ············-> @eslint-react/jsx/no-comment-textnodes
[x] react/jsx-filename-extension ··············-> @eslint-react/naming-convention/filename-extension
[ ] react/boolean-prop-naming ·················-> @eslint-react/naming-convention/boolean-prop
[ ] react/jsx-handler-names ···················-> @eslint-react/naming-convention/handler-prop
[x] #205
[x] #107
[x] react/jsx-no-script-url ···················-> @eslint-react/react/no-script-url
[x] react/jsx-no-target-blank ·················-> @eslint-react/react/no-unsafe-target-blank
[x] react/button-has-type ·····················-> @eslint-react/react/no-missing-button-type
[x] react/iframe-missing-sandbox | ············-> @eslint-react/react/no-missing-iframe-sandbox
[x] -----------------------------|··············-> @eslint-react/react/no-unsafe-iframe-sandbox
[x] react/jsx-no-constructed-context-values ···-> @eslint-react/react/no-constructed-context-value
[x] react/no-danger ···························-> @eslint-react/react/no-dangerously-set-innerhtml
[x] react/no-danger-with-children ·············-> @eslint-react/react/no-dangerously-set-innerhtml-with-children
[x] react/no-namespace ························-> @eslint-react/react/no-namespace
[x] #186
[x] #173
[x] #183
[x] #185
[x] react/no-string-refs ········|··············-> @eslint-react/react/no-string-refs
[x] -----------------------------|··············-> @eslint-react/react/no-create-ref
[x] #101
[x] #202
[x] #190
[x] #191
[x] #192
[x] #197
[x] #198
[x] #199
[x] #187
[x] react/no-object-type-as-default-prop ······-> @eslint-react/react/no-unstable-default-props
[x] react/no-unstable-nested-components ·······-> @eslint-react/react/no-unstable-nested-components
[x] react/no-unused-state ·····················-> @eslint-react/react/no-unused-state
[x] #207
[x] react/void-dom-elements-no-children ·······-> @eslint-react/react/no-children-in-vold-dom-elements
[x] react/destructuring-assignment ············-> @eslint-react/react/prefer-destructuring-assignment
[x] react/prefer-read-only-props ··············-> @eslint-react/react/prefer-readonly-props
[x] #301
[x] #234

The following can be enforced by TypeScript, no need to implement them

react/jsx-no-duplicate-props
react/jsx-no-undef
react/jsx-uses-react
react/jsx-uses-vars
react/no-invalid-html-attribute
react/no-this-in-sfc
react/no-unescaped-entities -> No need when using @typescript-eslint/parser
react/no-unknown-property
react/style-prop-object
react/prop-types
react/react-in-jsx-scope
react/require-render-return

Customized rules
These rule will be added in the future.

react/forbid-elements -> @eslint-react/react/ban-components
react/forbid-component-props -> @eslint-react/react/ban-component-props
react/forbid-dom-props

-> @eslint-react/react/ban-html-props
-> @eslint-react/react/ban-svg-props

Stylistic rules
Stylistic rules are not supported by this plugin. Use dprint or @stylistic instead.

react/jsx-child-element-spacing
react/jsx-closing-bracket-location
react/jsx-closing-tag-location
react/jsx-curly-brace-presence
react/jsx-curly-newline
react/jsx-curly-spacing
react/jsx-equals-spacing
react/jsx-first-prop-new-line
react/jsx-indent-props
react/jsx-indent
react/jsx-max-props-per-line
react/jsx-newline
react/jsx-one-expression-per-line
react/jsx-pascal-case
react/jsx-props-no-multi-spaces
react/jsx-sort-default-props
react/jsx-sort-props
react/jsx-space-before-closing
react/jsx-tag-spacing
react/jsx-wrap-multilines

Outdated or obsolete rules
These rules are considered outdated or obsolete. They are not going to be supported by this plugin.

react/default-props-match-prop-types
react/forbid-foreign-prop-types
react/forbid-prop-types
react/no-unused-prop-types
react/prefer-exact-props
react/prefer-es6-class
react/prefer-stateless-function
react/require-default-props
react/require-optimization
react/sort-default-props
react/sort-prop-types
react/state-in-constructor
react/static-property-placement
react/jsx-no-bind

Work in progress rules
JSX rules

[x] jsx/max-depth

Naming convention rules

[ ] naming-convention/boolean-prop
[ ] naming-convention/handler-prop

React rules

[ ] react/prefer-readonly-props
[ ] react/ban-component-props
[ ] react/ban-components
[x] #294
[x] react/no-unused-class-component-members
[ ] react/no-unsorted-class-component-members

How to migrate react/self-closing-comp rule?

How to migrate react/self-closing-comp rule?

All stylistic rules including jsx-self-closing-comp have been migrated to @stylistic/eslint-plugin-jsx, which can be used in addition to this plugin.

How about rule:
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/function-component-definition.md

Hi @Rel1cx, thanks for this! Amazing as always 🚀
However, I ran into an issue today that eslint-plugin-mdx requires react/jsx-uses-vars
There is not yet full TypeScript support for MDX files, and it appears ESLint doesn't support multiple parsers for a set of files.
I tried to use eslint-plugin-react-x for this (looking for react-x/jsx-uses-vars) and found this part of the issue description:

The following can be enforced by TypeScript, no need to implement them

react/jsx-uses-vars

What do you think about implementing this for other languages like MDX? (and also just for completeness, for other situations where TypeScript cannot be used)

Hi @Rel1cx, thanks for this! Amazing as always 🚀
However, I ran into an issue today that eslint-plugin-mdx requires react/jsx-uses-vars
There is not yet full TypeScript support for MDX files, and it appears ESLint doesn't support multiple parsers for a set of files (eg. for trying to use typescript-eslint parser along with the MDX parser).
I tried to use eslint-plugin-react-x for this (looking for react-x/jsx-uses-vars) and found this part of the issue description:

The following can be enforced by TypeScript, no need to implement them

react/jsx-uses-vars

What do you think about implementing this for other languages like MDX? (and also just for completeness, for other situations where TypeScript cannot be used)
I can create a separate issue for this to track this request.

This is a good point, I agree with creating a separate issue to track this, please proceed.

Thanks for the response! New issue here:

https://github.com/Rel1cx/eslint-react/issues/834

Opened another similar one for react/no-unknown-property, since this is also a common rule:

https://github.com/Rel1cx/eslint-react/issues/846

This says that react/no-unused-prop-types is outdated/obsolete. I'm guessing because prop-types are deprecated?
But the rule also supported linting based on a declared typescript type, and ensured props that were declared were actually used. Is that not still relevant?
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-unused-prop-types.md

This says that react/no-unused-prop-types is outdated/obsolete. I'm guessing because prop-types are deprecated? But the rule also supported linting based on a declared typescript type, and ensured props that were declared were actually used. Is that not still relevant<EMAIL_ADDRESS>
Thank you for mentioning that the rule also supported linting based on a declared TypeScript type. This aspect was overlooked at the time, and I will reconsider whether to migrate this rule.


Should not beep on backspace with cursor at start of line

Beep on backspace with cursor at start of line should not be the default behavior for the default EditMode (-EditMode Windows), but it currently is that way in PowerShell 5.1 (Win10 1607 14393.51).
Right now people are forced to figure out that they must do things like put Set-PSReadlineOption -BellStyle None in their PowerShell profile, or run net stop beep + sc config beep start= disabled, to stop the beeping, as it does not honor the Sounds control panel "No Sounds" scheme, and beeps anyway.
If this change was only intended for -EditMode Vi, maybe as parity, then it should only be the behavior for that edit mode, but should not be the default behavior for -EditMode Windows.
See also http://superuser.com/questions/1113429/disable-powershell-beep-on-backspace

Beeps are annoying.  @srdubya - is this really expected in vi mode?

I just fired up Bash on Ubuntu on Windows with "set -o vi" and it beeps under this circumstance.  With that said, I have no objection to taking it out or making it an option which defaults to off.

I vote for making it an option... :+1: :smile:
I'm trying to keep the default behavior as close to bash, cygwin, etc.

I just noticed it beeps in emacs mode mode on bash - so it's consistent - it definitely shouldn't beep in Windows mode.
I'm not a fan of too many configuration options.  If the only justification is to keep behavior as close as possible to bash, then I'll probably just remove the beep.  If there is a better justification, I'll reconsider.

Any news on this? It's a (very annoying) bug that's been there for a rather long time now and no updates here...
I've been "forced" to disable the beep service in the office, as it was annoying everyone around me. I realize that I can disable it via Set-PSReadlineOption and a PS profile, but that's just another workaround, not a real fix.

I'm just busy with other things, hopefully I'll get a new release out with some important fixes soon

It is easy to turn off the beep if you know some basics of powershell,  but beginners who might need help can use this script:
https://www.powershellgallery.com/packages/NoBeep/2.2/DisplayScript
to use just run:
Save-Script -Name NoBeep -Path  -RequiredVersion 2.0
or
Install-Script -Name NoBeep -RequiredVersion 2.0
hope this helps

I put up a small script on the PSGallery in case new users need a temporary fix:
https://www.powershellgallery.com/packages/NoBeep/2.2/DisplayScript


Release new version to TF registry?

Hi,
Could you plz push a new version to the terraform registry with the latest fix included?
Thanks

vpc-peering v3.0.4 is created.


i3 shortcut not working but call betterlockscreen -l from bash do

$ betterlockscreen -l locks the screen successfully.
When I press $mod+l, nothing happens.
Here's my i3 config:
set $mod Mod4
# bindsym $mod+l exec i3lock -t -i ~/background/cropped-1920-1080-756030.png # this works
bindsym $mod+l exec betterlockscreen -l

lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.1 LTS
Release:	18.04
Codename:	bionic

uname -a
Linux xxx 4.15.0-39-generic #42-Ubuntu SMP Tue Oct 23 15:48:01 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

try bindsym $mod+l exec 'betterlockscreen -l'

I found it does not work by replacing the command with echo something into a test file, neither.
So there should be some problem with my i3wm.
Closing the issue.

I have spare time to address my problem finally.
For anyone have similar symptom, check that path of betterlockscreen are set in some place like ~/.profile. i3 won't load ~/.bashrc.


exports is not defined

trying to use this in a project, and when running in Storybook i get the following error.
The debugger points me to line 4.

i fixed the issue in node_module by changing the import lines to:
import { default as CircularProgress } from './src/CircularProgress';
import { default as AnimatedCircularProgress } from './src/CircularProgress';

any chance this library can be updated to reflect this change?

Moving to #152


Update README.md

Update README.md to include basic virtual environment setup and installing required modules

Perfect, thank you


CUDA out of memory. Tried to allocate 91.71 GiB. GPU

Is it not possible to transcribe long audio files, around ~3 hours? I am trying to transcribe the 3-hour audio to Hindi, but it uses huge memory.
import torch
import nemo.collections.asr as nemo_asr

device = torch.device("cuda" if torch.cuda.is_available() else "cpu")
nm_model = nemo_asr.models.EncDecCTCModel.from_pretrained('ai4bharat/indicconformer_stt_hi_hybrid_rnnt_large')
nm_model.freeze() # inference mode
nm_model = nm_model.to(device)

nm_model.cur_decoder = 'rnnt'
text = nm_model.transcribe(audio=str(processed_audio_file), batch_size=1, language_id='hi')[0]

The memory usage is huuuuge.

You can try two things:

In the model config, set the self_attention_model in NeMo to local, and set a smaller local_attention_window.
Chunk the audio into multiple segments using Silero VAD, run inference on the individual chunks, and finally merge the output transcripts.

The second option might give a better result since the model has been trained on 5 - 25 second audio chunks, so it would most accurate on audio files having a duration within that range.

Fantastic. I am going ahead with the audio chunk route. Besides, is it possible to turn off tqdm logging while transcribing? I have my own progress for chunks using tqdm.


Grouped Select not showing items.

I am trying to create a dmc.Select element with grouping, but only the group labels are showing, not the sub-items.
import dash_mantine_components as dmc
from dash import Output, Input, html, callback

app = Dash(__name__)

content = html.Div(
    [
        dmc.Select(
            id="framework-select",
            data=[
                {
                    "group": "Frontend",
                    "items": [
                        {"value": "React", "label": "React"},
                        {"value": "Angular", "label": "Angular"},
                    ],
                },
                {
                    "group": "Backend",
                    "items": [
                        {"value": "Svelte", "label": "Svelte"},
                        {"value": "Vue", "label": "Vue"},
                    ],
                },
            ],
            w=200,
        ),
        dmc.Text(id="selected-value"),
    ]
)

@callback(Output("selected-value", "children"), Input("framework-select", "value"))
def select_value(value):
    return value

app.layout = dmc.MantineProvider(content)

if __name__ == "__main__":
    app.run_server(port=8885, jupyter_mode="external", debug=True)

Results in:

I also saw this on version 0.12.1 but upgrading to 0.14.3 fixed it

Thank you @dgtester, I was on 0.12.1, but unfortunately 0.14.3 introduced more errors (related to changes outlined here). I guess I will wait for better documentation for 0.14.3+ and time on my part to address those.

Closing it as its not an issue in 0.14.3.


added context manager to disable found checks, updated docs a bit

Adds a context manager to temporarily disable the found flag exception generator for certain situations when that is needed. updated docs a bit to give some details

I might rename to suspend_found_check or no_found_check, interested in suggestions

Coverage remained the same at 100.0% when pulling 3789bf0dc7f9824a9fd137a527bf8e0830839ce3 on add_found_context into 361a8a8866d469c7b1176f063da71a220cc90963 on master.

https://github.com/conda/conda/issues/6251

Coverage remained the same at 100.0% when pulling 56a4ef5fae6fb6c3055bc7f5da7bcb1fdd26e355 on add_found_context into 361a8a8866d469c7b1176f063da71a220cc90963 on master.

Slicker'n snot on a doorknob!

Coverage remained the same at 100.0% when pulling 518472f90969bfa5f152333b6e93c5a11310ec65 on add_found_context into 361a8a8866d469c7b1176f063da71a220cc90963 on master.

Coverage remained the same at 100.0% when pulling 2d57e0409d995439d015071d7811716ab45e187e on add_found_context into 361a8a8866d469c7b1176f063da71a220cc90963 on master.

This is great, thanks for incorporating my ideas.
I thought about the local variable approach, but figured the list would be easier to comprehend, plus I am never trusting of the whole global/local thing.  But it is fine, of course, better even, as nesting context managers effectively makes a list of them in the yield state.
I'm not saying the on/off calls are context managers, just that returning the initial state from the on/off calls could be useful.  but I see you added get_found_catch_state(), so that is just as good, functionally; it just takes an extra step for the user.
Do we need a test of nesting the context managers, to ensure the local variables are indeed local (or do we just trust Python;-)?

I trust python ;)

Coverage remained the same at 100.0% when pulling eb52a5abf780af0701cedb7ef075e8c7ed1a1955 on add_found_context into 361a8a8866d469c7b1176f063da71a220cc90963 on master.

Coverage remained the same at 100.0% when pulling eb52a5abf780af0701cedb7ef075e8c7ed1a1955 on add_found_context into 361a8a8866d469c7b1176f063da71a220cc90963 on master.

Coverage remained the same at 100.0% when pulling eb52a5abf780af0701cedb7ef075e8c7ed1a1955 on add_found_context into 361a8a8866d469c7b1176f063da71a220cc90963 on master.

https://github.com/appveyor/ci/issues/1897

woo hoooooo!


Route does not match for the ODataRoute and returns 404

I have the following code model in the ODataController and WebApiConfig.cs where the webapi and OData controllers are registered and used.
[ApiAuthorize]
public class RolesController : BaseODataController
{
        [EnableQuery]
        [ODataRoute("Roles({RoleId})/UserRoles")]
        public IQueryable<UserRole> GetUserRoles([FromODataUri] long RoleId)
	{
	//implementation goes here...
	}
}

**WebApiConfig.cs**

var constraintResolver = new DefaultInlineConstraintResolver() { ConstraintMap = { ["apiVersion"] = typeof(ApiVersionRouteConstraint) } };
// Web API routes
config.MapHttpAttributeRoutes(constraintResolver);

config.AddApiVersioning((vo) =>
{
    vo.ReportApiVersions = true;
    vo.DefaultApiVersion = new ApiVersion(1, 0);
    vo.AssumeDefaultVersionWhenUnspecified = true;
});

var modelBuilder = new VersionedODataModelBuilder(config);
modelBuilder.ModelConfigurations.Add(new MyModelConfiguration());
var models = modelBuilder.GetEdmModels();

config.MapVersionedODataRoutes("odata-wo-prefix", "", models, odataBatchHandler);
config.MapVersionedODataRoutes("odata-only-version-path", "v{apiVersion}", models, odataBatchHandler);
config.MapVersionedODataRoutes("odata-by-path", "odata/v{apiVersion}", models, odataBatchHandler);
config.MapVersionedODataRoutes("odata", "odata", models, odataBatchHandler);

config.AddODataQueryFilter();

However, when I access the above api using postmane like

http://localhost:65314/odata/v1/Roles(47)/UserRoles

The response is a 404. I did try using /odata/v1/Roles, /Roles, /OData/Roles etc, but all in vain. I am not getting back the proper response [nothing but 404].
Kindly help me understand the routing to be happening in this case, Also if possible, can you please share some debugging techniques for version 2.0.1 like adding some overloads where the registered routes can be checked by leaving a breakpoint, or else dumping some data in the Output window for analysis. We kind of find it like a blackbox and couldn't figure out the exact way to resolve the issues. Some doumentation on how the routes are internally registered or matched will be of very great help to us.
Please do the needful.

Further, to reproduce this issue, please use the following code snippet at the end of the People2Controller  the AdvancedODataWebApiSample project.
[ODataRoute("({data})/somedata")]
public IHttpActionResult GetSampleData([FromODataUri]string data) => Ok(data);

In case you need more details, I can even share the code here for your reference

There's a lot going on here. Let's make sure we have the basics sorted out and then dive into the details. First, are you using regular Web API controllers in addition to OData? If not, then you don't need:
**WebApiConfig.cs**

var constraintResolver = new DefaultInlineConstraintResolver() { ConstraintMap = { ["apiVersion"] = typeof(ApiVersionRouteConstraint) } };
// Web API routes
config.MapHttpAttributeRoutes(constraintResolver);

In fact, you don't want it. OData uses convention-based routes despite the existence of OData routing attributes. Convention-based and attribute-based routes don't play well together in all cases. I always recommend choosing one or the other. Since your using OData, the decision is made for you. I recommend that you only use convention-based routes in your application.
It looks like you are trying to implement API versioning using a URL segment.  I recommend query string or media type, but it's your choice. You may be having an issue with routing because you have overlapping route templates. The router considers the registered routes in order. I show both in the examples purely for illustration purposes and so I don't have to create two separate projects. You should chose single API versioning strategy.
To register by URL segment, the following should be the only registration required:
config.MapVersionedODataRoutes("odata-by-path", "v{apiVersion}", models, odataBatchHandler);

You can add an additional prefix such as api/ or odata/ if you like. I suspect if comment out or remove the other route registrations, things may just start working.
Finally, do you have a navigation property defined for /UserRoles on the Roles entity? A 404 may be happening simply because OData doesn't know how to route the request. Keep in mind that API versioning is just letting you define a standard OData route multiple times and then disambiguating the implementation to select by API version. If you haven't already, you might want to validate the route works without API versioning enabled.
Let me know where that gets you and we'll investigate further.

Is this issue resolved now? This seems related to some other issues you've posted.

I have the impression you were able to resolve this issue. If you continue to encounter issues, feel free to come back or reopen the issue. Thanks.


Add support for actor reentrancy

Describe the feature
The dapr core runtime is planning on supporting actor reentrancy. The bulk of this logic will be handled in dapr's runtime but the SDK will be responsible for:

Preserving the header dapr-reentrant-id
Providing the new config fields required by dapr/config

For more context on actor reentrancy, the design proposal can be found here: actor reentrancy
Release Note
RELEASE NOTE: ADD Support for actor reentrancy

/assign

Are there any docs on this? I'm probably looking over it.

Nothing SDK specific yet, but there's info on the feature itself.
https://docs.dapr.io/developing-applications/building-blocks/actors/actor-reentrancy/

I have found those.
So if we want to use it, we just have to use the host options?

Just curious... If I'm understanding the PR correctly, this is configured in the host options at the runtime level. Does that mean that you cant configure reentrancy at the actor level? Either all actors are reentrant, or none of them are?

Yes, you have to use the host options which means all actor types registered with those options are reentrant. We do not have the fine-grained settings for individual actor reentrancy. @sregdorr - What is your use case for having an individual actor be reentrant instead of the entire type?

@sregdorr Gotcha, thanks for explaining your use case!
If identity/single-threaded isn't required, could you just give them a unique ID? Instead of Guid.Empty do a Guid.NewGuid?
I think the alternate of making it a simple gRPC service is also a good idea. It's also worth noting that Dapr supports gRPC proxying now and we're working to add support for that in the .NET SDK as well. #741

any idea when the reentrancy support will make it into this sdk?

@aktxyz

any idea when the reentrancy support will make it into this sdk?

It's been in the sdk since 1.3. It's currently a preview feature in the runtime, though we're looking into seeing when we can take it out of the preview features.

@aktxyz

any idea when the reentrancy support will make it into this sdk?

It's been in the sdk since 1.3. It's currently a preview feature in the runtime, though we're looking into seeing when we can take it out of the preview features.

I did not realize that !  thanks

in case anyone else is searching this, you need to setup in this way
serviceCollection.SetupActors(options =>
            {
                options.ReentrancyConfig = new ActorReentrancyConfig()
                {
                    Enabled = true,
                    MaxStackDepth = 5,
                };
                // Your actors registration......
            });

Is it still preview in 2023?


include macro should resolve recursively

if you include a page with another include, that inner include should be resolved, also filename should add .md if it doesn't end with one

Added at https://github.com/threebotserver/publishingtools/commit/4395e3556e398574a571ce249dbe38f52d6c4db7.

verified and deployed on production


Fix setup for evaluator

PR to fix a bug when assigning wall_restraints in setup.py that is used in OpenFF-Evaluator.
Change is the force constant for dummy atoms. The current value is 500 kcal/mol/A^2 but the value used in previous calculations with Amber is 50 kcal/mol/A^2. Although this should not change the final results it might be safer to use the same protocol as the Amber calculations.
Minor change: renaming in the comments from Property Estimator to OpenFF Evaluator following the name change in the repository. https://github.com/openforcefield/openff-evaluator/releases/tag/v0.1.0

Good catches. I think we increase the force constant on the dummy atoms using OpenMM at one point because we were trying to match some test results where I had turned the restraints into true constraints. Anyhow, I'll merge this once the tests pass.

Codecov Report

Merging #127 into master will increase coverage by 0.03%.
The diff coverage is n/a.


[Suggestion] For the advanced portal gun coordinate editing.

https://github.com/Direwolf20-MC/JustDireThings/issues/77#issuecomment-2198731266
Saw that you were trying find a balanced way to do it, I was thinking about adjusting the coordinates based on the current saved one and it consumes portal fluid depending on how far you are from it, this solution adds both a cap to how far you can go and a cost to it.
Ex :
Editing from -500 70 600 to -700 65 400 costs X amount of portal fluid.
While from -700 65 400 to -750 65 410 costs 0.2X portal fluid.

I’m considering a block that can create a portal that lets you specify the coordinates. So you need a block to dial up a position. And like you said consuming a lot of portal fluid.


Ruby Doc update needed?

Hello,
Why do you suggest using gem oj v2.12.14?
That version doesn't work with Ruby 2.4.x -- however oj v2.16.1 - does.
I'm also curious why you don't suggest oj v3.3.x.
I've been using that version with rollbar and haven't notice any problems.
Is there a reason you suggest using this older version of oj and why not the newest version or at least a version compatible with Ruby 2.4.x such as oj v2.16.1
If this is just out of date docs -- can they be updated?
Thanks,
Bill

That is just an old version recommendation, the docs just need to be updated. I will update to 2.16.1.


add mavlink odometry message handling

This pr adds odometry message handling to SITL.

@EliaTarasov thank you for your contribution but this is already an ongoing change in https://github.com/PX4/Firmware/pull/9301, in a bigger restructure to the odometry handling in PX4. Please feel free to test that branch (just needs some rebasing to fix the submodules. Will rebase it today or tomorrow). Will close this so the effort can be continued there. Please have some testings with it as the feedback is welcomed. Once again, thanks!

@TSC21 Thanks for the quick and clear explanation!


Stronger typing of attribute values in the XML Schema

Tested again and this validates the current matroska_xsd.xml. Thanks for making this more clear.


librealsense: unbreak on gcc13

Description of changes
Should fix these on latest eval:

https://hydra.nixos.org/build/246364388
https://hydra.nixos.org/build/246250010
https://hydra.nixos.org/build/246231146
https://hydra.nixos.org/build/246228016
https://hydra.nixos.org/build/246237871
https://hydra.nixos.org/build/246266555
https://hydra.nixos.org/build/246254341

but not

https://hydra.nixos.org/build/246454090

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 281030 run on x86_64-linux 1

14 packages built:

librealsense (librealsenseWithoutCuda)
librealsense-gui
librealsense-gui.dev
librealsense.dev (librealsenseWithoutCuda.dev)
librealsenseWithCuda
librealsenseWithCuda.dev
python311Packages.pyrealsense2 (python311Packages.pyrealsense2WithoutCuda)
python311Packages.pyrealsense2.dev (python311Packages.pyrealsense2WithoutCuda.dev)
python311Packages.pyrealsense2WithCuda
python311Packages.pyrealsense2WithCuda.dev
python312Packages.pyrealsense2 (python312Packages.pyrealsense2WithoutCuda)
python312Packages.pyrealsense2.dev (python312Packages.pyrealsense2WithoutCuda.dev)
python312Packages.pyrealsense2WithCuda
python312Packages.pyrealsense2WithCuda.dev


Integer validation not working if value has 2 or more leading minus/plus signs

I have a form with integer attributes. Form model has the following rules:
...
[['area', 'seatCount'], 'required'],
[['area', 'seatCount'], 'integer', 'min' => 0],
...

Here is a screenshot of validation result (english translation below): https://i.gyazo.com/61064d9d98da19aa011b5e852d39debc.png
The first field is 'Area', error message: "Area must be not less than 0" (it is integer validator)
The second field is 'Seat Count', error message: "Seat count cannot be blank" (it is 'required' validator).
The problem is the Seat Count is filled. It is not blank. It should be validated as number and shows error message: Seat Count must be integer. But integer validator number pattern does not recognize value as number due to sequence of leading minuses (leading pluses as well).
I guess it is bug.

Unable to reproduce. Number validator works correctly for the value containing multiple minus or pluses.
It must be something else breaking your form.


Build failed on android

Build fail when add react-native-compressor package in project build failed on android only. On iOS works well.
Platform

[X] Android

React Native Version
"react-native": "0.72.4"
React Native Compressor Version
"react-native-compressor": "^1.8.2",
Project build.gradle
buildscript {
    ext {
        buildToolsVersion = "33.0.0"
        minSdkVersion = 21
        compileSdkVersion = 33
        targetSdkVersion = 33
        kotlinVersion = "1.7.0"

        // We use NDK 23 which has both M1 support and is the side-by-side NDK version from AGP.
        ndkVersion = "23.1.7779620"
    }
    repositories {
        google()
        mavenCentral()
    }
    dependencies {
        classpath("com.android.tools.build:gradle")
        classpath("com.facebook.react:react-native-gradle-plugin")
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
    }
}

Build output
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-compressor:compileReleaseKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 2m 20s

i have same problem
Task :react-native-compressor:compileReleaseKotlin FAILED
e: D:\wamp64\www\react-native-projects\onlinelearning\node_modules\react-native-compressor\android\src\main\java\com\reactnativecompressor\CompressorModule.kt: (20, 1): Class 'CompressorModule' is not abstract and does not implement abstract base class member public abstract fun createVideoThumbnail(fileUrl: String?, options: ReadableMap?, promise: Promise): Unit defined in com.reactnativecompressor.CompressorSpec
e: D:\wamp64\www\react-native-projects\onlinelearning\node_modules\react-native-compressor\android\src\main\java\com\reactnativecompressor\CompressorModule.kt: (153, 3): 'createVideoThumbnail' overrides nothing
e: D:\wamp64\www\react-native-projects\onlinelearning\node_modules\react-native-compressor\android\src\main\java\com\reactnativecompressor\CompressorModule.kt: (158, 3): 'clearCache' overrides nothing

i have same problem
Task :react-native-compressor:compileReleaseKotlin FAILED
e: D:\wamp64\www\react-native-projects\onlinelearning\node_modules\react-native-compressor\android\src\main\java\com\reactnativecompressor\CompressorModule.kt: (20, 1): Class 'CompressorModule' is not abstract and does not implement abstract base class member public abstract fun createVideoThumbnail(fileUrl: String?, options: ReadableMap?, promise: Promise): Unit defined in com.reactnativecompressor.CompressorSpec
e: D:\wamp64\www\react-native-projects\onlinelearning\node_modules\react-native-compressor\android\src\main\java\com\reactnativecompressor\CompressorModule.kt: (153, 3): 'createVideoThumbnail' overrides nothing
e: D:\wamp64\www\react-native-projects\onlinelearning\node_modules\react-native-compressor\android\src\main\java\com\reactnativecompressor\CompressorModule.kt: (158, 3): 'clearCache' overrides nothing
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.

What went wrong:
Execution failed for task ':react-native-compressor:compileReleaseKotlin'.

A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
Compilation error. See log for more details

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.
==============================================================================

2: Task failed with an exception.

What went wrong:
java.lang.StackOverflowError (no error message)

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.
==============================================================================

Get more help at https://help.gradle.org

React Native Version
"react-native": "0.72.4"
React Native Compressor Version
"react-native-compressor": "^1.8.2",

@tannguyen05 @techgrih fixed this error into 1.8.3 version, can you try this version and let me know?

@tannguyen05 @techgrih fixed this error into 1.8.3 version, can you try this version and let me know?

@numandev1 Many thanks; that works. 🎉

@tannguyen05 @techgrih fixed this error into 1.8.3 version, can you try this version and let me know?

@numandev1 Thank you  ;

happening again in last update

@hamdij0maa which Kotlin version, you are using? can you check build.gradle for kotlin version

@numandev1  kotlin_version is 1.7.0
am getting this error :

What went wrong:
Execution failed for task ':react-native-compressor:compileDebugKotlin'.

A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
Compilation error. See log for more details

@hamdij0maa  can you share your build.gradle file and react native version?

build.gradle:
buildscript {
ext {
buildToolsVersion = "33.0.0"
minSdkVersion = 24
compileSdkVersion = 33
targetSdkVersion = 33
kotlin_version = '1.7.0'
// We use NDK 23 which has both M1 support and is the side-by-side NDK version from AGP.
ndkVersion = "23.1.7779620"
}
repositories {
google()
mavenCentral()
}
dependencies {
classpath("com.android.tools.build:gradle")
classpath("com.facebook.react:react-native-gradle-plugin")
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
}
"react-native": "0.72.5",
PS: the build was working fine before the version : 1.8.4

@hamdij0maa can you try 1.8.8

done thank you

@hamdij0maa is it working now?

yes fixed 😍 thnx man

I'm facing this issue again on version 1.10.3
react-native: 0.76.3
expo: 52.0.0
* What went wrong:
Execution failed for task ':react-native-compressor:compileReleaseKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

My build.gradle:
`buildscript {
ext {
buildToolsVersion = findProperty('android.buildToolsVersion') ?: '35.0.0'
minSdkVersion = Integer.parseInt(findProperty('android.minSdkVersion') ?: '26')
compileSdkVersion = Integer.parseInt(findProperty('android.compileSdkVersion') ?: '35')
targetSdkVersion = Integer.parseInt(findProperty('android.targetSdkVersion') ?: '34')
kotlinVersion = findProperty('android.kotlinVersion') ?: '1.9.24'
    ndkVersion = "26.1.10909125"
}
repositories {
    google()
    mavenCentral()
}
dependencies {
    classpath 'com.google.gms:google-services:4.3.3'
    classpath('com.android.tools.build:gradle')
    classpath('com.facebook.react:react-native-gradle-plugin')
    classpath('org.jetbrains.kotlin:kotlin-gradle-plugin')
}

}`


Revert "UHF-5473: Group ontology word details relationship results"

Reverts City-of-Helsinki/drupal-module-helfi-tpr#117

Codecov Report

Merging #119 (6a8c306) into main (1b1782e) will increase coverage by 0.20%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #119      +/-   ##
============================================
+ Coverage     73.02%   73.22%   +0.20%
+ Complexity      295      294       -1
============================================
  Files            41       40       -1
  Lines          1075     1072       -3
============================================
  Hits            785      785
+ Misses          290      287       -3

Impacted Files
Coverage Δ

modules/contrib/helfi_tpr/src/TprViewsData.php
100.00% <0.00%> (ø)

...c/Plugin/views/relationship/TagOwdRelationship.php

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b1782e...6a8c306. Read the comment docs.


typo in cURL build?

It seems there is an extra l after ${PREFIX} in LD_LIBRARY_PATH=${PREFIX}l/lib here:
https://github.com/rnixik/docker-openssl-gost/blob/master/Dockerfile#L72

Yes, it is! Thank you. I fixed it and pushed new version.


Add flake8-boolean-trap

Disclaimer: I have no rust experience whatsoever.

Looks great! I'll merge this later today.


How to get "the Japanese CCGBank (Uematsu et al. 2013)"

Hi, I will try to use your software for japanese ccg parsing.
I want to modify the ccg parser for an experiment.
How can I get "the Japanese CCGBank (Uematsu et al. 2013)"?
The background of this question:
I will experiment with the ccg parser to translate natural sentences to DSL scripts.

Sorry for inconvenience; though we had a plan to publish our CCGbank, we had not done it yet. I expect we can publish it soon, and let you know if we have any progress.

@hiroshinoji I am also interested in the Japanese CCG treebank :)


ADT: should there be an OR category or not

Do we want OR to be mapped to other or do we want there to be an OR category?  I wonder if we just make a Procedural/OR or just Procedural category and ask people to put ANY peri/intra/post-procedure or peri/intra/post-operative categories into this category and remove all confusion.  Just a thought.

Also... @kaveriC ... lets say we all agree to go with the plan above.  Is there a way that I can make the changes so it doesn't fall on you to do it?  Im assuming that means i create a branch or something and do a push or something, but if possible I would love to test it out and unburden you from small things like this!!

@ingra107 agree with a combination procedural location_category for all OR or procedure. That means there will not be many other locations in a typical CLIF database. Please fix this and then resolve this issue when the documentation has been updated. In general let's make that the workflow, keeping @kaveriC in the loop but the PI who "owns" the table can make changes like this.

this has been updated and pushed without issues! see ADT pull request


Rework text objects to try and cache the font details

This should reduce the size of the resultant PDF.
Also reduce the number of decimal places for various outputs

Never going to merge this, it's too error prone for a benefit that we don't really care about (file size).


Learning rate / epochs search for benchmark at the paper.

❓ Questions & Help
Hi, at first, I really appreciate this wonderful work!
This makes it easier for many researchers to conduct their experiments.
I just want to ask you about the benchmark performance for graph classification in your paper.
Is this reported after hyper parameter search such as learning rate, the number of epochs, learning rate decay, and the things that we can adjust with argparse in your code?
Thanks,

The argparse hyperparameters are fixed and there is no tuning performed on them. If you want to tune them, you should add them as lists to this line.

So, if I am doing a learning rate search, there's room for performance change?
Because I want to report baseline performance with this report for homogeneous training scenario.

I do not know what you mean with "room for performance change".
If you simply want to tune the learning rate, do something like this:
lrs = [0.1, 0.01, 0.001, ...]

and replace line 54 with:
for lr in lrs:

yes, and I also should change line 63 like this:
lr=lr

Thanks.
Your answer was helpful for me.
"room for performance change" means that
I should tune baselines again If I want to report my model with learning rate search.
Because baselines performance may be different with your paper.
(The reported performance may not be best performance)

Ah okay, I see what you mean. I guess you need to do that for a fair comparison :(

Thanks, I will do that!
Actually, this repo is great contribution for GNN research community!

Thank you :)


merge from template-arlac77-github

.github/workflows/ci.yml

chore(deps): add 20.12.0 remove 20.11.1 (jobs.test-node.strategy.matrix.node-version)
chore: add 20.12.0 (jobs.release.steps.with.node-version)

.github/workflows/codeql_analysis.yml

chore: add 20.12.0 (jobs.analyze.steps.with.node-version)

.github/workflows/update_package_lock.yml

chore(deps): add 20.12.0 (jobs.update_package_lock.strategy.matrix.node-version)

.github/workflows/update_readme_api.yml

chore: add 20.12.0 (jobs.update_readme_api.steps.with.node-version)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.573%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
35

Relevant Lines:
86

💛  - Coveralls


0-fee channel probing attack & mitigation

I've been using watchhtlcstream.py from lndpytools to monitor my node in the background, and noticed some strange activity.
I've been getting a lot of lines resembling
FORWARD 7 0 Tue Sep 14 00:26:11 2021 100000.0 for 0.0
I can't be sure weather this is an actual channel probing attack or someone's buggy software sending 0-fee routing attempts, but it seems that LND is leaking balance information regardless.
If the channel balance is sufficient for forwarding, it returns FEE_INSUFFICIENT, while if the balance is not sufficient for forwarding, it returns TEMPORARY_CHANNEL_FAILURE.
I propose checking the fee and returning the FEE_INSUFFICIENT error prior to checking the balance, in order to avoid leaking information.

@Roasbeef is this something that we still want done? If so, I can pick it up.

Closing as should be addressed with pr #7490


Increment version for devcenter releases

Increment package version after release of Azure.Developer.DevCenter

API change check
API changes are not detected in this pull request.


ship init should accept an idle-timeout parameter

ship init should support an idle-timeout parameter and exit with a non-zero status code if the duration passes without any interaction to report that it timed out.

I'm not sure there is a valid use case for this feature request. Closing for inactivity.


Add to API document for the return value of bindAll function.

For many versions lower than 1.9.0 bindAll function returned bound object.
Since the version 1.9.0 it has been changed not to return.
This change might break the codes that used return value of bindAll function.
Please add to API document for the return value of bindAll and hopefully other functions.
Thanks.

@jongwookyi Thanks for reporting and sorry for the slow response.
This was almost certainly an unintended breaking change caused by https://github.com/jashkenas/underscore/commit/3cd04870adff10304da1a5cbd19c9aa310f1ee2c.


update spatial map alpha

to close #282 i've updated plot_spatial_map to convert the data into rgba and apply the alpha layer there.

@leoscholl added some minor comments and will approve after you respond!

thanks for the comments. good catch on the docstring! one of those parameters didn't do anything.. should be fixed now


Add private-dns-name filter and fix regional DNS

This is a fix for https://github.com/spulec/moto/issues/1075

Added the 'network-interface.private-dns-name' and 'private-dns-name' ec2 filters
Fixed public/private DNS values. This should be set depending on the region (aws documentation; see Amazon DNS Server)
Added the region_name attribute to Instance class so that it is available to the dns setters.
Added/updated tests

Coverage increased (+0.003%) to 93.475% when pulling d75c2c95767e5a4ec1118732f3c2f03d5f9f4461 on dlutsch:private_dns_filter into 2ace59a60e997048e35a5f54704513a0c74ae8ef on spulec:master.

@dlutsch Great work! Thanks for adding these filters - this'll be really useful for folks. Welcome to Moto! :)


only JWT_KEY is undefined

why JWT_KEY is only undefined?

// code
console.log(process.env.MONGODB_URL);
console.log(process.env.JWTKEY);
console.log(process.env.PORT);

Could you provide the env-cmd command you are running also?
This lib does not care what environment variables you pass to it. It is possible its a parsing issue in the .env file, but I would like to see the command you are running first.

   "dev:server": "env-cmd -f ../config/dev.env nodemon Server.js",

Just ran a nearly identical setup locally and it worked fine for me.
I think the next step would be to setup a new barebones example in a public Github repo. We can use that repo to try and help us debug this issue further. My best guess at this point is perhaps you are unsetting JWTKEY by accident somewhere in your Server.js file before you console.log those values?
Results:

Server.js:

dev.env:

Closing due to inactivity.