problems with sudo vim

Great Extension, but I think this small issue is annoying but easy to be fixed.
Let's say I have 2 tmux panes divided to up and bottom. Consider the following being done on the upper pane:

If I run vim -O hello world I can switch between vim's windows - everything works fine.
If I run sudo vim -O hello world as myself, I can't switch with <C-l> and <C-h> between vim's windows
If I'm root (I ran sudo su before), and I run vim -O hello world, I can switch between vim's windows <C-l> and <C-h> but I can't switch to tmux's  pane at the bottom.
If I'm root because I ran sudo su or su root, I can run zsh --login and vim -O hello world and then everything works fine like I'm myself and not root.
If I ran su <myusername>, I don't have all my environment variables and aliases defined like always but if I run afterwards vim -O hello world, I can switch to tmux's pane at the bottom with <C-j>.

Note: All of my important dotfiles are linked from my $HOME to /root and it includes:

~/.vimrc
~/.vim/
~/.tmux.conf
~/.tmux/ # a directory where I keep plugins for tmux

Not sure if it's releavent but I keep these are linked as well:

~/.zshrc
~/.zshenv
~/.zprofile
~/.zlogin

Hey @Doron-Behar, thanks!
Regarding the issues you're seeing, I'm guessing they're related to the process listing, rather than anything to do with your user settings.
Can you try the first step outlined in the Troubleshooting section to help narrow down?

Interesting.
It also does not work with https://github.com/christoomey/vim-tmux-navigator/pull/117: the script detects that Vim is running, but the actual send-keys c-h is not handled by Vim?!
You can try it from tmux' command mode (<c-b> : by default): :send-keys c-h does nothing, but :send-keys c-w c-h works.
:send-keys :TmuxNavigateLeft c-m also works (that's what is mapped to from <c-h>).
And it's actually only a problem with Neovim (v0.1.3-384-g47d44e0), but not Vim (7.4.1689) for me.
@Doron-Behar
Are you using Neovim or Vim?  Which version?

The <c-h> gets interpreted as <bs> with sudo nvim..
You can check this after <c-v> in Neovim's insert/command-line mode: <c-v><c-h> prints <BS> for me.

The Neovim issue is https://github.com/neovim/neovim/issues/2048.

@Doron-Behar
See https://github.com/neovim/neovim/issues/2048#issuecomment-212135388.
Also with Vim, the terminfo might be relevant.

Duplicate of https://github.com/christoomey/vim-tmux-navigator/issues/71#issuecomment-202422963.

Per @blueyed's comment, this seems to be duplicate of #71, related to an issue with Neovim, and not this plugin directly. I'm going to close this now based on that, but please feel free to comment or reopen if I've missed something.

Sorry for not replying a long time, I use Vim - no Neovim

It might be a similar issue though: c-j does not get through to vim.
Please investigate using c-v, and also by executing the tmux-navigator commands manually.

Ok, Here is my Report: :send-keys c-[hjkl] from within tmux as well as :TmuxNavigate* from within vim brings me to the correct pane/window. It means vim handles this plugin better compared to neovim right?

Hey @Doron-Behar, sorry for the confusion. I'll reopen this now and hopefully we can sort it out.

Update:
I just installed neovim and tested the same issue with sudo nvim file. Surprisingly, in contrast of what you said about an opened issue with neovim, I didn't experience the same problem like with vim.
-- Perhaps it's another good reason to use neovim and not vim.

In vim, vim-tmux-navigator looks for the active tmux socket in the TMUX environment variable. When invoked using sudo, the environment is typically sanitized or reset (via env_reset in /etc/sudoers). Therefore, vim invoked via sudo doesn't know that it's in a tmux session, and CTRL+[hjkl] aren't passed onto tmux by vim.
To immediately work around this issue, the TMUX environment variable should be preserved when starting a root shell or invoking vim as root using sudo. You can preserve the entire environment with:
sudo -E vim

or just the TMUX environment variable with:
sudo TMUX="${TMUX}" vim

(assuming this is allowed by your machine's /etc/sudoers configuration).

@smkent
Good find.
I wonder why it works for @Doron-Behar with Neovim though.. do you have $TMUX set in that case?!
I don't think there is much we can do about it, apart from adding something to the README, is there?

I don't think there is much we can do about it, apart from adding something to the README, is there?

sudo sets the SUDO_USER and SUDO_UID environment variables. The vim-tmux-navigator vim plugin could be modified to look for the default tmux socket path at /tmp/tmux-${SUDO_UID}/default. Unfortunately this still isn't a reliable solution, because it assumes 1) the user's tmux socket is in the standard location (tmux allows a different socket path to be specified using -S) and 2) that the current SUDO_UID is the original user (invoking sudo within a shell started with sudo overwrites SUDO_USER and SUDO_UID).
I think the best solution would just be to mention the workarounds in the README. We could also recommend adding env_keep += "TMUX" to /etc/sudoers, but I don't know if that introduces security or compatibility issues.

I don't think there is much we can do about it, apart from adding something to the README, is there?

Still not in the README.  Spent quite a while tracking down what seemed to me like an intermittent problem, including adding debug code to the plugin, before it hit me that it was only the sudo vim windows malfunctioning, then ran across this issue.

Additionally, I would recommend another workaround to be mentioned in the README (which should be suitable for Neovim as well because of https://github.com/neovim/neovim/issues/1716) - Use a plugin such as https://github.com/tpope/vim-eunuch or https://github.com/lambdalisue/suda.vim which provide a :SudoWrite and :SudoRead like commands.

@doronbehar the issue being discussed breaks https://github.com/tpope/vim-eunuch that :SudoWrite is no longer working under neovim. https://github.com/lambdalisue/suda.vim is a work-around, yet user needs to input password each time when saving a file.

I make no argument if this is a good fix for everyone, or if it should be recommended.  I make a lot of /usr/local/bin/ "wrappers" for things, so I lean this way.  This builds off one of the comments by @smkent
/usr/local/bin/sudo
#!/usr/bin/bash

if [[ -v TMUX ]]; then
   /usr/bin/sudo TMUX="${TMUX}" "$@"
else
   /usr/bin/sudo "$@"
fi

It obviously requires /usr/local/bin/ be in $PATH, and before /usr/bin/.  Those with other shells would need to tweak as appropriate, or with older bash would need to use:
if [[ -z ${TMUX+x} ]]; then

@randomizedthinking I've had this discussion on https://github.com/lambdalisue/suda.vim/pull/3 about the seemingly lack of password cache which was supposed to be fixed in https://github.com/neovim/neovim/pull/8389 which wasn't yet merged.


Make JuliaFEM to work with Julia v1.0.0

Fix deprecation warnings
Cleanup of tests
Drop PkgTestSuite

Coverage increased (+11.4%) to 89.091% when pulling 5987519abbba234b26c1604f0e1d5418b331890e on release-0.5.0 into 1357e7e46dfeba4ac3a5e3ea632e48f0b48866fb on master.


content group cards

Related Ticket(s)
{{Provide url(s) to the related ticket(s) that this pull request addresses}}
Description
{{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}}
{{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}}
Changelog
New

{{new thing}}

Changed

{{changed thing}}

Removed

{{removed thing}}

@jacobottesen-dgc The Specification documentation needs updates.

Structure and spacing measurements for ~Button group~  Content group cards pattern can be viewed here.
And the "here" link should be linked to https://ibm.box.com/s/5sfef66ow9ruw47qye5snhnxey0ioi6t


Force spack-stack to utilize the built-in system iconv library on macos

This PR fixes the build issue (eg. undefined symbol _iconv) with the climbfuji:feature/merge_spack_stack_20230710 branch on macos platforms.
Fixes: https://github.com/JCSDA/spack-stack/issues/698

Commits in this PR have been pushed to Dom's feature branch so no need for this PR. I will close it now.


SIGTSTP can't be handled

What version of Go are you using (go version)?

$ go version
go version go1.15.2 darwin/amd64

Does this issue reproduce with the latest release?
It is the latest release
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/kimmo/Library/Caches/go-build"
GOENV="/Users/kimmo/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/kimmo/Projects/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/kimmo/Projects/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.15.2/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.15.2/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/kimmo/Projects/go/src/github.com/Mirantis/mcc/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/t5/k06n6kss3qz1z5sf0y8pqsw40000gn/T/go-build559599993=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I'm trying to write a remote terminal client that needs to relay Ctrl-Z to the remote host. Intercepting Ctrl-C works fine by using signal.Notify(c, os.Interrupt), but signal.Notify(c, syscall.SIGTSTP) works only half way.
package main

import (
	"os"
	"os/signal"
	"syscall"
	"time"
)

func main() {
	c := make(chan os.Signal)
	signal.Notify(c, syscall.SIGTSTP)

	go func() {
		for {
			<-c
			println("received ctrl-z")
		}
	}()

	for {
		println("Sleeping...")
		time.Sleep(time.Second * 10)
	}
}

What did you expect to see?
Pressing Ctrl-Z should be intercepted and the go process should not suspend.
$ go run main.go
Sleeping...
received ctrl-z
Sleeping...
Sleeping...

What did you see instead?
received ctrl-z is printed but the go process itself is also suspended.
$ go run main.go
Sleeping...
received ctrl-z
[1]+  Stopped                 go run main.go
$ _

go build and run the executable instead of using go run

use go build and run the executable instead of using go run

@kke I am closing this, as I believe @seankhliao's answer is correct. Please comment if I am mistaken.

@seankhliao is correct. Setting the local terminal to raw mode (for example via "golang.org/x/crypto/ssh/terminal"s MakeRaw()) makes it work even in go run mode.


use rtsp ip camera

hi
i want to use ip camera how can i do
thank u

Have a look at https://obsproject.com/
There you have a lot of plugins.
You would need to configure a video source, that would be your IP camera. Then add a plugin to display OBS out as a web cam in the system, and then in multiparty-meeting choose OBS as the webcam.

thank u


Liquid?

Has anyone been able to get the helpers working with liquid?
Many thanks

For followup, since this has google juice, no helpers are available in Liquid in Sinatra except for yield


fix helm install command in docs

Correct helm repo in helm install command.

/rebase

/rebase

/merge


I2S ADC channel order is unexpected/doubled up (IDFGH-1408)

Environment

Development Kit: Wemos Lolin D32
Module or chip used:  ESP32-WROOM-32
IDF version: v3.3-beta2 and master (58df1d93) but note modifications below
Build System: Cmake
Compiler version: 1.22.0-80-g6c4433a
Operating System: Linux (Ubuntu 18.04)
Power Supply: USB

Problem Description
I'm trying to use the I2S direct-from-ADC functionality in my firmware, with multiple channels.
Note: I have modified the IDF code with the following changes:

Exposed (removed static, added to header) adc_set_i2s_data_len() from components/driver/rtc_module.c via components/driver/include/driver/adc.h
Exposed adc_set_i2s_data_pattern() (same).
Removed the call to _i2s_adc_mode_recover() in i2s_adc_enable() in components/driver/i2s.c

These changes are necessary to allow connecting multiple ADCs to the I2S module (see #2980 , @montaguk's comment).
I have some example code that simply reads the I2S data as it is generated and extracts the channel it originated from. The Technical Manual says:

ESP32 supports up to a 12-bit SAR ADC resolution. The 16-bit data
in DMA is composed of the ADC result and some necessary information
related to the scanning mode:

For single mode, only 4-bit information on channel selection is
added.

So this is done with code like:
(data & 0xF0) >> 4

...applied to every second char, offset by one (to get the MSB).
But when I actually run my code (below), I do not see alternating channels eg 5, 6, 5, 6. I see channels doubled up and sometimes skipped eg. 5, 6, 6, 5, 5, 6, 6, 5, 6.
Expected Behavior
The Technical Manual says:

The pattern tables contain the measurement rules mentioned above. Each table has 16 items which store
information on channel selection, resolution and attenuation. When scanning starts, the controller reads
measurement rules one-by-one from a pattern table. For each controller the scanning sequence includes 16
different rules at most, before repeating itself.

So given the setup:
    adc_set_i2s_data_len(ADC_UNIT_1, 2);
    adc_set_i2s_data_pattern(ADC_UNIT_1, 0, ADC_CHANNEL_6, ADC_WIDTH_BIT_12, ADC_ATTEN_DB_11);
    adc_set_i2s_data_pattern(ADC_UNIT_1, 1, ADC_CHANNEL_5, ADC_WIDTH_BIT_12, ADC_ATTEN_DB_11);

I would expect the I2S-triggered scanning to simply go 6, 5, 6, 5, 6, 5, and the resulting I2S data to have that same pattern.
Actual Behavior
My code prints:
I (30673) i2s-test: CH: 6 5 5 6 6 5 5 6
I (30673) i2s-test: CH: 6 5 5 6 6 5 5 6
I (30673) i2s-test: CH: 6 5 5 6 6 5 5 6
I (30683) i2s-test: CH: 6 5 5 6 6 5 5 6
I (30683) i2s-test: CH: 6 5 5 6 6 5 5 6
I (30693) i2s-test: CH: 6 5 6 6 5 6 6 5
I (30693) i2s-test: CH: 6 6 5 6 5 5 6 5
I (30703) i2s-test: CH: 5 6 6 5 5 6 6 5

Note the repetition of each channel.
Steps to repropduce
Build and run the code I link to with idf.py build and idf.py flash monitor. Don't forget to make the modifications I mention above.
Code to reproduce this issue
I have put the entire example project on Gitlab here. But here is the essential setup code for the peripherals:
static void app_i2s_adc_init()
{
    int i2s_num = I2S_NUM_0;

    i2s_config_t i2s_config = {
        .mode = I2S_MODE_MASTER | I2S_MODE_RX | I2S_MODE_ADC_BUILT_IN,
        .sample_rate =  24000,
        .bits_per_sample = 16,
        .communication_format = I2S_COMM_FORMAT_I2S_MSB,
        .channel_format = I2S_CHANNEL_FMT_RIGHT_LEFT,
        .intr_alloc_flags = 0,
        .dma_buf_count = 2,
        .dma_buf_len = 1024,
        .use_apll = 1,
        .fixed_mclk = 0
    };

    i2s_driver_install(i2s_num, &i2s_config, 0, NULL);
    i2s_set_adc_mode(ADC_UNIT_1, ADC1_CHANNEL_6);

    adc_set_i2s_data_len(ADC_UNIT_1, 2);
    adc_set_i2s_data_pattern(ADC_UNIT_1, 0, ADC_CHANNEL_6, ADC_WIDTH_BIT_12, ADC_ATTEN_DB_11);
    adc_set_i2s_data_pattern(ADC_UNIT_1, 1, ADC_CHANNEL_5, ADC_WIDTH_BIT_12, ADC_ATTEN_DB_11);
}

I would also like to know what the proper communication_format is to use for direct-from-ADC operation, because it does seem to affect the result.
Debug Logs
Here's the log of the first set of reads:
I (0) cpu_start: App cpu up.
I (225) heap_init: Initializing. RAM available for dynamic allocation:
I (232) heap_init: At 3FFAE6E0 len 00001920 (6 KiB): DRAM
I (238) heap_init: At 3FFB2F10 len 0002D0F0 (180 KiB): DRAM
I (244) heap_init: At 3FFE0440 len 00003AE0 (14 KiB): D/IRAM
I (250) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (257) heap_init: At 400883B0 len 00017C50 (95 KiB): IRAM
I (263) cpu_start: Pro cpu start user code
I (281) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.
I (283) I2S: DMA Malloc info, datalen=blocksize=4092, dma_buf_count=2
I (283) I2S: APLL: Req RATE: 24000, real rate: 11999.990, BITS: 16, CLKM: 1, BCK_M: 8, MCLK: 3071997.500, SCLK:<PHONE_NUMBER>00, diva: 1, divb: 0
I (303) i2s-test: repeat #0
I (303) i2s-test: enabling I2S ADC
I (303) I2S: APLL: Req RATE: 24000, real rate: 11999.990, BITS: 16, CLKM: 1, BCK_M: 8, MCLK: 3071997.500, SCLK:<PHONE_NUMBER>00, diva: 1, divb: 0
I (323) i2s-test: CH: 5 6 6 5 5 6 6 5
I (323) i2s-test: CH: 5 6 6 5 5 6 6 5
I (323) i2s-test: CH: 5 6 6 5 5 6 6 5
I (333) i2s-test: CH: 6 6 5 6 6 5 5 6
I (333) i2s-test: CH: 6 5 5 6 6 5 5 6
I (343) i2s-test: CH: 6 5 5 6 6 5 5 6
I (343) i2s-test: CH: 6 5 5 6 6 5 5 6
I (353) i2s-test: CH: 6 5 5 6 6 5 5 6
I (353) i2s-test: disabling I2S ADC

Happy to provide more information if it helps.

I think you have a problem with your rate - the real rate is half your desired rate.
It may be just the recent bug around rate calculation but I would double check that first

@davydnorris I was confused by that too. Is it in this issue tracker?

See https://github.com/espressif/esp-idf/pull/3648, but I think maybe you have some other problem as the errors here are not half.
I may be completely off track here as I thought you were reading an external ADC sensor, but you're using the in-built one. However I would chase that rate problem down - it seems very weird

Verified that it's present in master.

@davydnorris I filed a separate bug for that, #3692 . But interestingly, the actual sample rate appears to be correct (a tone generator produces the right frequency of samples). So it might just be a reporting problem.

Running this on a commit where the sample rate problem is not present still shows the channel ordering issue.

So avoiding the APLL issue, I have verified with an oscilloscope that the WS signal is running at 24kHz as expected. The channel ordering is still doubled up.

Okay, the problem seems to be related to this part of the code:
    if (p_i2s_obj[i2s_num]->mode & (I2S_MODE_DAC_BUILT_IN | I2S_MODE_ADC_BUILT_IN)) {
        //DAC uses bclk as sample clock, not WS. WS can be something arbitrary.
        //Rate as given to this function is the intended sample rate;
        //According to the TRM, WS clk equals to the sample rate, and bclk is double the speed of WS

The code correctly uses the BCLK as the DAC clock, but treats the ADC the same way, which it shouldn't. According to the TRM, the ADC uses WS at the frequency required for switching. So the ADC is given a scanning frequency far higher than it should actually have.

Ah here it is, in 12.5:

In the LCD mode, the frequency of WS is half of f BCK. In the ADC/DAC mode, use PLL_D2_CLK as the clock source.

@davydnorris Turns out the weird sample rate being reported is simply a side effect of the fact that the clocks work a bit differently in ADC mode (WS is always half the frequency of the BCK). The debug print still calculates everything assuming WS = BCK/(bits*channels). But the WS signal is actually correct as long as the PLL D2 is used and not the APLL.

I think the reason I get a pattern with 1 channel then each pair of channels (eg. 5 6 6 5 5 6 6) is because of this:
    if (i2s_config->mode & (I2S_MODE_DAC_BUILT_IN | I2S_MODE_ADC_BUILT_IN)) {
        I2S[i2s_num]->conf2.lcd_en = 1;
        I2S[i2s_num]->conf.tx_right_first = 1;

Why is right_first set here? I don't think it's needed, and it just means the first ADC read is discarded.

thanks for digging into this - I have never used the built in ADC on the ESP32 so this is all news to me!

Have you seen #3170 ?
If you use apll, you need do also set a fixed mclk:
   .use_apll = 1,
   .fixed_mclk= 2000000,

@x-ryl669 yep, see #3692. Problem exists regardless of APLL.

@detly
I found that the adc channel is normal when using mono.
i2s_set_clk(i2s_num, SAMPLE_RATE, I2S_BITS_PER_SAMPLE_16BIT, I2S_CHANNEL_MONO);

2 channel:

8 channel:

When the I2S bus works in I2S_CHANNEL_FMT_RIGHT_LEFT mode, each data will be repeated once to cause the data rate to double, but the actual sampling rate is unchanged. However, when using SAR ADC1 to perform multi-channel scanning according to the specified pattern table, as in your test results, there will be random channel sequence changes, or some channels will be repeatedly scanned suddenly. This problem causes non-uniformity in the sampling interval, and it is clear that the chip does not work according to the characteristics given in TRM.
The biggest problem is that the scan channel order changes randomly.
To reproduce this problem, code attched to the link https://www.esp32.com/viewtopic.php?t=8335&start=10 can be used. Here is a part of the output of the example code when the problem occurs:
ch 6  0.160000v
ch 7  0.160000v
ch 0  0.160000v
ch 3  0.160000v
ch 3  0.160000v
ch 7  0.160000v
ch 7  0.208308v
ch 0  0.197573v
ch 3  0.160000v
ch 6  0.229011v
ch 7  0.202173v
ch 0  0.188371v
ch 3  0.160000v
ch 6  0.208308v
ch 7  0.196806v
ch 0  0.179170v

I've read in one of the issues (don't remember which) here that the HW sampler needs 2 clocks to restart sampling when it's done a batch (instead of restarting immediately), so it's always missing one sample, that's probably the reason for the repetition, in fact, it has missed one value.
If you had a non constant voltage source, you'd see the effect.

I've read in one of the issues (don't remember which) here that the HW sampler needs 2 clocks to restart sampling when it's done a batch (instead of restarting immediately), so it's always missing one sample, that's probably the reason for the repetition, in fact, it has missed one value.

I read this too, I think it was a PR, not an issue. If this is a case, it absolutely needs to be documented front and centre in the TRM and the API, because it is totally at odds with every other embedded system out there, and means that the ADC-to-I2S functionality — an advertised feature of this system — is more or less useless for a great many applications. On top of that, letting engineers waste this much time and effort trying to debug it, instead of simply being honest about the limitation, is unacceptable.

If you had a non constant voltage source, you'd see the effect.

I actually do, I see it quite clearly with a sine tone generator or audio calibration signal.

@X-Ryl669 was it this comment on PR #1991?

Yes, exactly. Thanks for digging this out again.

Hello,
I hope you are doing well.
I believe that what is being discussed in here is the underlying issue of what  I have posted:
https://github.com/espressif/arduino-esp32/issues/3939
Could you kindly please take a look at this issue and let me know what you think?
My knowledge on I2S and firmware are very limited, and so I`m not sure if this is the same issue and if there is a solution for it?
Thank you

Is this still possible?
I was looking into the current rtc_module.c file and it looks very different 👍

This actually helped a lot:

I've read in one of the issues (don't remember which) here that the HW sampler needs 2 clocks to restart sampling when it's done a batch (instead of restarting immediately), so it's always missing one sample, that's probably the reason for the repetition, in fact, it has missed one value.

But when I saw it I thought of tossing everything out the (closed) window since it seemed like a HW limitation. and hundreds of hours down the drain.
Now it's actually working here.

Thanks for explaining your engineering dissection. I'm eager to see the actual code to make it work flawlessly.


remove signature with new hmac check for token

It will remove the error of signature not found.
You are not redirected from the valid shopify URL as now the latest shopify uses the hmac in return url instead of the signature.

@ajrana000 feel free to give my version a try, it implements the latest recommendations from Shopify's docs: https://github.com/LukeTowers/php-shopify-api


[ISSUE #3896] fix log format error

Make sure set the target branch to develop
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.06%) to 51.581% when pulling 37ceb324b1dee6500badb6ee3b7ca59fe46b02e3 on panzhi33:fixlog into 799d4125bdcfcf223aa3c8e954866d657abf90c2 on apache:develop.

Coverage increased (+0.06%) to 51.581% when pulling 37ceb324b1dee6500badb6ee3b7ca59fe46b02e3 on panzhi33:fixlog into 799d4125bdcfcf223aa3c8e954866d657abf90c2 on apache:develop.

@panzhi33 ping~

@panzhi33 ping~

done

Codecov Report

Merging #3897 (1c7a3b5) into develop (799d412) will increase coverage by 0.12%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #3897      +/-   ##
=============================================
+ Coverage      47.45%   47.57%   +0.12%
- Complexity      4922     4945      +23
=============================================
  Files            633      633
  Lines          42498    42560      +62
  Branches        5579     5588       +9
=============================================
+ Hits           20166    20249      +83
+ Misses         19826    19808      -18
+ Partials        2506     2503       -3

Impacted Files
Coverage Δ

...g/apache/rocketmq/client/impl/MQClientAPIImpl.java
13.86% <ø> (ø)

...org/apache/rocketmq/common/stats/StatsItemSet.java
47.76% <0.00%> (-2.99%)
:arrow_down:

...che/rocketmq/acl/plain/PlainPermissionManager.java
71.72% <0.00%> (+0.03%)
:arrow_up:

...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java
39.83% <0.00%> (+0.12%)
:arrow_up:

...ain/java/org/apache/rocketmq/store/MappedFile.java
50.54% <0.00%> (+0.36%)
:arrow_up:

...mq/client/impl/producer/DefaultMQProducerImpl.java
45.22% <0.00%> (+0.37%)
:arrow_up:

...apache/rocketmq/tools/admin/DefaultMQAdminExt.java
41.40% <0.00%> (+0.46%)
:arrow_up:

...n/java/org/apache/rocketmq/store/ha/HAService.java
72.33% <0.00%> (+0.66%)
:arrow_up:

...mmand/connection/ConsumerConnectionSubCommand.java
74.41% <0.00%> (+0.73%)
:arrow_up:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799d412...1c7a3b5. Read the comment docs.


Altered Model's cacheKey to use a GUID.

This change list remedies the bug referenced in #6928. The system now uses a GUID in place of the URI as the model's cache key when no explicit cache key has been supplied. This technique alleviates memory use when a large data URI is input.

Thank you so much for the pull request @mksquires! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!
The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

:x: Missing CONTRIBUTORS.md entry.

Please add yourself to the contributors file!

:x: Missing CLA.

Please send in a Contributor License Agreement (CLA) and comment back here to let us know to check this!

:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

Thanks @hpinkos! I have updated the code.

Thanks @mksquires!  One more thing, can you add a line to CHANGES.md?  After that this will be ready to go

Thanks @mksquires!


Improved Instructions page

Completed this with commit: https://github.com/smite1921/enigma-machine/commit/b8ae4df559e7e90e5d42170f2e1bcbad43ec3d6d


Find libcxsparse and add it to link line

Fixes #184
cs_di_chol is defined within libcxsparse (part of SparseSuite).
$ nm /usr/local/lib/libcxsparse.so | grep cs_di_chol
0000000000008060 T cs_di_chol
0000000000008560 T cs_di_cholsol
All we need to do is include libcxsparse in the linking of csfm.so.

Anything I can do to help this get merged?

Thanks for the fix and for re-pinging, @bdholt1. I'm trying to understand the situation.
I had the wrong understanding that SuiteSparse and CXSparse were independent libraries. The Ceres doc recommends building Ceres with SuiteSparse rather than CXSparse but one could build with either or both of them.
So #184 seems to be caused by using a Ceres library that has been build with CXSparse.
Always linking CXSparse does fix the problem at the cost of requiring CXSparse to be installed. I think that is OK since the libsuitesparse-dev ubuntu package actually depends on CXSparse.
I'm not sure why I could never reproduce this problem, but I've tested your patch on mac and ubuntus and works as good as before. So merging and hoping it fixes it for the others.
Thanks so much for finding this.


No Compatible version found<EMAIL_ADDRESS>

I recently ran into a problem with xml2js which I think might be related to older versions of node.
I am patching a grunt repo for https://github.com/linusnorton/grunt-parallel-behat and was using
node 0.8.28
npm 1.2.30
nvm 0.30.2
When I received this message:
npm ERR! Error: No compatible version found<EMAIL_ADDRESS>npm ERR! Valid install targets:
npm ERR! ["0.0.1","0.0.2","0.0.3","0.0.4","0.0.5","0.0.6","0.1.0","0.1.1","0.1.2","0.1.3","0.1.4","0.1.5","0.1.6","0.1.7","0.1.8","0.2.0","0.2.1","0.2.2","0.3.0","0.3.1","0.3.2","0.3.3","0.3.4","0.3.5","0.3.6","0.3.7","0.3.8","0.3.9","0.3.10","0.3.11","0.4.0","0.4.1","0.4.2","0.4.3","1.0.0","1.0.1","1.0.2","1.1.0","1.1.1","1.1.2","2.0.0","2.0.1","2.1.0","2.2.1","2.3.0","2.4.0","2.4.1","2.4.2","2.4.3","2.4.4","2.4.5","2.4.6","2.5.0","2.5.1","2.5.2","2.6.0","2.6.1","2.6.2","2.6.3","2.6.4","2.6.5","3.0.0","3.1.0","4.0.0","4.1.0","4.2.0","4.2.1"]
npm ERR!     at installTargetsError (/Users/dannymacom/.nvm/v0.8.28/lib/node_modules/npm/lib/cache.js:719:10)
npm ERR!     at /Users/dannymacom/.nvm/v0.8.28/lib/node_modules/npm/lib/cache.js:641:10
npm ERR!     at saved (/Users/dannymacom/.nvm/v0.8.28/lib/node_modules/npm/node_modules/npm-registry-client/lib/get.js:138:7)
npm ERR!     at Object.oncomplete (fs.js:302:15)
npm ERR! If you need help, you may report this log at:
npm ERR!     <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR<EMAIL_ADDRESS>

Try using xml2js version 0.4.15, that uses xmlbuilder version 2.4.6

@tflanagan that seems to be solving my issue, thanks!


Path deserialization doesn't work

It tries to deserialize things as JSON for some reason. The relevant code is here. A PR that removes the JSON deserialization would be welcome, including a test similar to the following (this is what I used to find the bug):
#[test]
fn request_serde() -> Result<(), Box<dyn std::error::Error + 'static>> {
    use std::convert::TryFrom;

    let req = some_endpoint::Request {
        foo: "foo".to_owned(),
        content_type: "application/json".to_owned(),
        bar: "bar".to_owned(),
        baz: "baz".to_owned(),
    };

    let http_req = http::Request::<Vec<u8>>::try_from(req.clone())?;
    let req2 = some_endpoint::Request::try_from(http_req)?;

    assert_eq!(req, req2);

    Ok(())
}

The test should be in its own file in tests/. The endpoint being tested can be a real one from ruma-client-api or an artificial one, but it should contain path, query and body data.

Should be fixed by 9861aa20c8a0415b045682fda0a961f1ee192f35


[HOLD for payment 2023-09-20] [$1000] Workspace - Incorrect Behavior When Inviting Existing User with Capitalized Email

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to any workspace
Open the "Members" page within the workspace
Click the "Invite" button and invite a new user
Go back to the "Members" page
Attempt to invite the same user again, but this time, capitalize the first letter of the user's email address or write the email address entirely in capital letters
Observe the description that is displayed

Expected Result:
The description should clearly state that the user is already a member of the workspace
Actual Result:
Instead of the expected message, it displays "No results found" when inviting the same user with capitalized email letters
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: 1.3.56-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/d15a8865-ed2f-469b-89dc-49b5bfa0ab9d
https://github.com/Expensify/App/assets/78819774/87d52df5-797a-4172-a68e-cef92c179198
Expensify/Expensify Issue URL:
Issue reported by: @Habben101
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691797768663379
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010c78f3bb410f312f
Upwork Job ID:<PHONE_NUMBER>259813888
Last Price Increase: 2023-08-29
Automatic offers:

jjcoffee | Reviewer | 26416348
Habben101 | Reporter | 26416352

Proposal
Please re-state the problem
There is a difference of error messages between uppercase and lowercase emails.
What is the root cause of this problem?
We are not converting the searchTerm to lowercase while comparing it to the excluded participants.
https://github.com/Expensify/App/blob/ed2c287daf6a1d59f4f43a9bfc84128597575730/src/pages/workspace/WorkspaceInvitePage.js#L188
What changes should be made in order to solve this problem?
We should convert the searchTerm to lowercase before comparing which can be done like this:
const searchValue = searchTerm.trim().toLowerCase();

This is approach is being used in other places as well, so I think we will be consistent in that approach.
https://github.com/Expensify/App/blob/ed2c287daf6a1d59f4f43a9bfc84128597575730/src/libs/OptionsListUtils.js#L638
https://github.com/Expensify/App/blob/ed2c287daf6a1d59f4f43a9bfc84128597575730/src/components/EmojiPicker/EmojiPickerMenu/index.js#L420
What other alternative approach did you explore? (Optional)
None

Proposal
Please re-state the problem that we are trying to solve in this issue.
Incorrect Behavior When Inviting Existing User with Capitalized Email
What is the root cause of that problem?
https://github.com/Expensify/App/blob/c435734d8cf360e964e20eea1fb54c541f6fa7ea/src/pages/workspace/WorkspaceInvitePage.js#L187-L196
We don't lowercase the search value before validating it
What changes do you think we should make in order to solve the problem?
we should lowercase searchvalue before validating like this
const searchValue = searchTerm.trim().toLowerCase();

Result

Added external

So we've got three duplicate proposals here, all with the correct RCA and solution. @DylanDylann's proposal happens to be the first so we can go with that!
:ribbon::eyes::ribbon: C+ reviewed

@jjcoffee PR is ready for review

@muttmuure Are we eligible for a bonus timeline here? The C+ contributor (@jjcoffee ) approved PR from 2023-08-31 here But we freeze merged in 2 last weeks.

@DylanDylann I think so, as long as it was ready to merge within the usual 3 days (see this comment on Slack).

[x] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/23490
[x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23490#issuecomment-1723297235
[x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - checklist item already exists to ensure test steps cover all possible scenarios
[x] Determine if we should create a regression test for this bug. No - fairly edge case and so not high value enough
[x] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

@muttmuure Gentle bump for payment here. Also, I think this may be due the timeliness bonus as it was only delayed due to the merge freeze (see this comment).

Gentle bump @muttmuure ^

Gentle bump @muttmuure ^^

Getting to this now

Offers sent, including urgency bonus

@muttmuure Thanks, offer accepted!

@muttmuure are we done with the payment here? Can we close the issue now?

Handling

Just waiting on @DylanDylann to accept, then we can close out

@muttmuure I've accepted, thank you!

Paid!


[py2py3] More runtime errors for Py3 agent on rhel6 OS

Impact of the bug
Py3 WMAgent
Describe the bug
I'm going to try to report all the problems I happen to see while testing Py3 WMAgent during job runtime, on rhel6 setup (thus, using scramArch slc6_* and python 3.6.4).
First issue to be reported happens during the SCRAM scripts, as shown in this wmagentJob.log [1]
How to reproduce it
Py3 WMAgent 1.5.2.pre1 + #10726, then run any of the slc6_* test json templates workflow.
Expected behavior
This issue needs to address all the job runtime related errors seen while commissioning Py3 WMAgent and slc6_* workload.
Additional context and error message
[1]
2021-08-06 19:26:40,264:INFO:CMSSW:Runing SCRAM
2021-08-06 19:26:41,923:INFO:CMSSW:Running PRE scripts
2021-08-06 19:26:41,932:ERROR:ExecuteMaster:Exception occured when executing step
2021-08-06 19:26:41,933:ERROR:ExecuteMaster:Exception is a bytes-like object is required, not 'str'
2021-08-06 19:26:41,933:ERROR:ExecuteMaster:Traceback:
2021-08-06 19:26:41,934:ERROR:ExecuteMaster:Traceback (most recent call last):
  File "/srv/job/WMCore.zip/WMCore/WMSpec/Steps/ExecuteMaster.py", line 141, in doExecution
    executionObject.execute()
  File "/srv/job/WMCore.zip/WMCore/WMSpec/Steps/Executors/CMSSW.py", line 197, in execute
    scriptProcess.stdin.write("export LD_LIBRARY_PATH=$LD_LIBRARY_PATH\n")
TypeError: a bytes-like object is required, not 'str'

2021-08-06 19:26:41,935:CRITICAL:CMSSW:CMSDefaultHandler Diagnostic Handler invoked
2021-08-06 19:26:41,936:WARNING:Report:Exit code: 99109 has been already added to the job report
2021-08-06 19:26:41,936:INFO:CMSSW:Steps.Executors.CMSSW.post called

With the 1st commit provided in #10736, we managed to take only one small step. Next issue happens now with the actual execution of that command:
2021-08-07 08:09:27,717:INFO:CMSSW:Running PRE scripts
2021-08-07 08:09:27,720:INFO:CMSSW:    Invoking command:
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH
/cvmfs/cms.cern.ch/slc6_amd64_gcc700/external/python3/3.6.4/bin/python3 -m WMCore.WMRuntime.ScriptInvoke WMTaskSpace.cmsRun1 SetupCMSSWPset

2021-08-07 08:09:28,417:CRITICAL:CMSSW:Error running command
2021-08-07 08:09:28,417:CRITICAL:CMSSW:Error running command
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH
/cvmfs/cms.cern.ch/slc6_amd64_gcc700/external/python3/3.6.4/bin/python3 -m WMCore.WMRuntime.ScriptInvoke WMTaskSpace.cmsRun1 SetupCMSSWPset

1
 b"2021-08-07 08:09:28,382:INFO:ScriptInvoke:Invoking scripts in current directory: /srv/job/WMTaskSpace/cmsRun1\n2021-08-07 08:09:28,388:INFO:Bootstrap:Job Index = 1148\nJob Instance = {'input_files': [{'lfn': 'MCFakeFile-amaltaro_TC_LHE_PFN_Aug2021_Val_210807_084927_9071-DarkSUSY_14TeV_2023D17_GenSimHLBeamSpotFull14-0031b50ba950a6458506041ae7485674', 'size': 0, 'events': 10000, 'checksums': {}, 'runs': set(), 'merged': True, 'last_event': 0, 'first_event': 0, 'locations': set(), 'parents': set()}], 'id': 1148, 'jobgroup': 22, 'name': '45462b35-2ab9-400b-8348-03648e19e4f3-0', 'state': 'new', 'state_time':<PHONE_NUMBER>, 'outcome': 'failure', 'retry_count': 0, 'location': None, 'mask': {'inclusivemask': True, 'FirstEvent': 1, 'LastEvent': 500, 'FirstLumi': 1, 'LastLumi': 5, 'FirstRun': 1, 'LastRun': 1, 'runAndLumis': {}, 'jobID': 1148}, 'task': '/amaltaro_TC_LHE_PFN_Aug2021_Val_210807_084927_9071/DarkSUSY_14TeV_2023D17_GenSimHLBeamSpotFull14', 'fwjr': None, 'fwjr_path': None, 'workflow': 'amaltaro_TC_LHE_PFN_Aug2021_Val_210807_084927_9071', 'owner': 'amaltaro', 'estimatedJobTime': 21600, 'estimatedMemoryUsage': 2000.0, 'estimatedDiskUsage': 4000000, 'cache_dir': '/data/srv/wmagent/v1.5.2.pre1/install/wmagentpy3/JobCreator/JobCache/amaltaro_TC_LHE_PFN_Aug2021_Val_210807_084927_9071/DarkSUSY_14TeV_2023D17_GenSimHLBeamSpotFull14/JobCollection_22_0/job_1148', 'sandbox': '/data/srv/wmagent/v1.5.2.pre1/install/wmagentpy3/WorkQueueManager/cache/amaltaro_TC_LHE_PFN_Aug2021_Val_210807_084927_9071/amaltaro_TC_LHE_PFN_Aug2021_Val_210807_084927_9071-Sandbox.tar.bz2', 'jobType': 'Production', 'taskType': 'integration', 'spec': '/data/srv/wmagent/v1.5.2.pre1/install/wmagentpy3/WorkQueueManager/cache/amaltaro_TC_LHE_PFN_Aug2021_Val_210807_084927_9071/WMSandbox/WMWorkload.pkl', 'counter': 1, 'agentNumber': 0, 'agentName': 'vocms0192.cern.ch', 'ownerDN': '/DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=amaltaro/CN=718748/CN=Alan Malta Rodrigues', 'ownerGroup': 'unknown', 'ownerRole': 'unknown', 'numberOfCores': 8, 'allowOpportunistic': False}\n\n"
 b'Traceback (most recent call last):\n  File "/srv/job/WMCore.zip/WMCore/WMRuntime/ScriptInvoke.py", line 99, in <module>\n  File "/srv/job/WMCore.zip/WMCore/WMRuntime/ScriptInvoke.py", line 62, in boot\nValueError: level must be >= 0\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n  File "/cvmfs/cms.cern.ch/slc6_amd64_gcc700/external/python3/3.6.4/lib/python3.6/runpy.py", line 193, in _run_module_as_main\n    "__main__", mod_spec)\n  File "/cvmfs/cms.cern.ch/slc6_amd64_gcc700/external/python3/3.6.4/lib/python3.6/runpy.py", line 85, in _run_code\n    exec(code, run_globals)\n  File "/srv/job/WMCore.zip/WMCore/WMRuntime/ScriptInvoke.py", line 107, in <module>\nRuntimeError: Error booting script invoker for step WMTaskSpace.cmsRun1\nwithe Script module: SetupCMSSWPset\nlevel must be >= 0Details:\n  File "/srv/job/WMCore.zip/WMCore/WMRuntime/ScriptInvoke.py", line 99, in <module>\n  File "/srv/job/WMCore.zip/WMCore/WMRuntime/ScriptInvoke.py", line 62, in boot\n\n'

2021-08-07 08:09:28,450:WARNING:Report:Exit code: 50513 has been already added to the job report


chore(main): release 1.17.4

:robot: I have created a release beep boop
1.17.4 (2024-03-14)
Performance Improvements

♻ Options in the preference settings (dc711cb)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/viarotel-org/escrcpy/releases/tag/v1.17.4 :sunflower:


do not store configs as a global

https://github.com/charlesread/fastify-jwt-webapp/blob/master/lib/util.js#L21-L27 store some configuration in the module scope. You should do module.exports = function build (config) { return implementation } instead (and the other functions are defined in the build function).

fixed in 1b61582

Commit: 1b61582


Fix possible nil stack case in grid services API

There seems to be possibility in the API to request services of a non existing stack in which case the API will produce internal errors.
See: https://kontenacommunity.slack.com/archives/general/p1484031542001669
I'm not entirely sure what could cause the CLI to actually even request services of a missing stack, but it should not cause internal error anyway.
This PR fixes this by halting the request in controlled manner if the given stack is not found.

duplicate for #1613


GloblalKey ExtendedImageEditorState and then currentState is null

Hi guys,
I am using this library for croping in the image. I am using ExtendedImage from file in GridView. I am getting GlobalKey currentState variable NULL for some images. Can you please let me know what i am doing wrong?
Here is my code.
`
Container(
color: mListOfFiles[index].select! ? Colors.lightBlue : Colors.grey[300],
margin: EdgeInsets.all(5),
child: ExtendedImage.file(file,
fit: BoxFit.contain,
cacheRawData: true,
mode: ExtendedImageMode.editor,
extendedImageEditorKey: mListOfFiles[index].editorKey,
initEditorConfigHandler:(state){
                                    return EditorConfig(

                                      cropAspectRatio: state!.extendedImageInfo!.image.width > state.extendedImageInfo!.image.height ? ExCropAspectRatios.ratio5_4 :  ExCropAspectRatios.ratio4_5
                                    );
                                }
                            ),
                          ),

`
`
mListOfFiles.forEach((element) async {
                                        if (element.editorKey!.currentState != null) {
                                          Uint8List? listImageCropData = await  ExCropAspectRatios.cropImageDataWithDartLibrary(state: element.editorKey!.currentState!);
                                          if(listImageCropData != null)
                                          {
                                            String fileName = basename(element.imageFile!.path);
                                            File editFile = File(
                                                '${settings.selectedPresentationPath}/${cUserSittings.rowKey}_${appointment.phoneNumber}/${BLOBS.Cropped.toString()}/${fileName}');
                                            editFile.writeAsBytesSync(listImageCropData);

                                          }

                                        }
                                        else
                                        {
                                          print("Editkey current state is null.");
                                        }

`
Thank you.
Asif.

editor mode for every image in Gridview？？

@zmtzawqlp Yes the editor mode is for every image in GridView.

Any update on this?

I encountered the same problem, the image that can be loaded will not be empty currentState, and the image that cannot be loaded will be reported as empty currentState

Hi @jsonsuxing after facing this problem, we had not any solution to fix the crop in the gridview, so then we had removed the crop from GridView and instead we cropping the image in a separate screen to crop it.

Thanks for your reply, I didn't crop it in the GridView, but selected it from the Android album, using the.file constructor. Some images can be displayed, some can't be displayed, I'm eating out now, I need more detailed parameters I can take a look at when I get back
---- Replied Message ----
| From | Asif @.> |
| Date | 03/13/2024 17:15 |
| To | fluttercandies/extended_image @.> |
| Cc | jsonsuxing @.>,
Mention @.> |
| Subject | Re: [fluttercandies/extended_image] GloblalKey ExtendedImageEditorState and then currentState is null (Issue #497) |
Hi @jsonsuxing after facing this problem, we had not find any solution to fix the crop in the gridview, so then we had removed the crop from GridView and instead we cropping the image in a separate screen to crop it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Fixes - #93 Upgrade hyrax.

Fixes #93

Upgraded hyrax to the point: https://github.com/projecthydra-labs/hyrax/commit/562b8ffab8f1770a45a7b231c1e573dc0d2455cf
Fixed failed test.

@ucsdlib/developers - please review

@hweng Those minor changes could be the reason of some historical issues. As long as the rspec test suites pass, then I think it'll be safe to delete the controller.rb file.

@lsitu  The test would pass if delete controller.rb.
Just let you aware that there are some methods in local controller.rb but not in hyrax/controller.rb,
For example:
https://github.com/ucsdlib/horton/blob/develop/app/controllers/hyrax/controller.rb#L16
It would be fine to me to delete it if all of you agree.

@hweng I see that, which could be migrated from CC pilot version in the past. Please feel free to delete the whole file since the rspec test passed.

@lsitu The controller.rb is removed.

Coverage increased (+0.2%) to 91.846% when pulling d4fb119906083e006db5a23cdbaeb55671e1b3d4 on feature/upgrade_hyrax into eed6e861bd8d0a190a87c6c24151667e9d21bb55 on develop.

👍

👍


running on stream 0 and syncing stream 0 is faster than on other stream

I tried two approaches to run a program. In the first approach, I launch all the computation and rccl kernels on stream 0, and use hipStreamSynchronize to sync with stream 0 to ensure all the kernels are completed. In the second approach, I hipStreamCreate a new stream and launch all the kernels on it. Also, I use hipStreamSynchronize to sync with the created stream in the end. It's a bit surprising to me that approach 0 is 25% faster than approach 1. Is this an expected behavior?

My HW is rtx 7900 xtx, and my rocm version is 5.7.

Hi @jinhongyii, can you provide the code you used when encountering this issue, or if not, any other code which exhibits this behaviour? Thanks!

Closing this issue for now, feel free to reopen with more details if you are still experiencing this issue on current ROCm. Running all of your computation on a new stream is not expected to provide any performance benefits, as the advantage of using streams is being able to compute with multiple streams concurrently. Without source code, it is difficult to say whether there is actually an issue here.


[feature request] uv init command compatible with cookiecutter/copier templates

I have been using the package management uv features, albeit in preview. Amazing product, responsiveness and pace of development 🚀
PDM has a great feature: the pdm init command can take --cookiecutter or --copier optional argument to initialise a project (including scaffold) using a template ref. I don't know how to reproduce that in uv - I don't know what template engine there is in Rust, maybe Armin's minijinja? Would be a slick feature.

https://rye.astral.sh/guide/commands/init/#arguments ?

Agreed. Scaffolding from community templates would be a nice (but not critical) next step. No comment on cookiecutter vs. copier vs. other.

Some nice detailed context in https://github.com/astral-sh/uv/issues/9754


Anchor Bug in Edge and Safari

Hi I found a bug here:
https://codepen.io/FabianK/pen/zJLLrR
As you can see clicking on the buttons will move you somewhere but not to the image.
If you remove scroll-behavior="smooth" on <ul class="scroll" ... it will work again but without "smooth"

Hi there. Thanks for submitting this issue. I've confirmed this issue thanks to your repro.
I've fixed it in the latest release (v2.0.7).

Version 2.0.6 works in Safari (scrolls to correct location via anchor update), 2.0.7 causes the same/similar bug as was reported in Edge under 2.0.6.

Hi there. I'm reopening the issue. Do you a simple reproducible demo I can take a look and investigate? Also, which Safari version are you seeing this behavior in?

Seeing a similar thing in Safari 12.1.2. Seems to happen in two stages — scrolls first to what might be the correct location (it's too quick for me to be sure. it's close anyway) and then to somewhere else (close the starting point, possibly back at the starting point)

I dont own a device but maybe my demo might still help
https://codepen.io/FabianK/pen/zJLLrR

@Krutsch, Safari v12.1, v13, and v13.1, works great with your codepen demo.
@olets, it would be great if you could provide a repo that I can take a look at since I can't reproduce this behavior easily. I can test in Safari 12.1.

By the way, do you support IE11 too? 🙈 (https://zealous-tereshkova-e96a40.netlify.com)
I think it was working once - maybe I broke it with changes 💣

@Krutsch, there was a few IE-related issues with Element.prototype.scrollIntoView as well as anchor navigation. I've fixed these and published a new version: v2.0.13

Thank you for your time and effort!!
It is working like a charm ❤

Closing this issue since the original issue may have been fixed in v2.0.13. If that is not the case, feel free to comment again, and I'll reopen this issue.

@wessberg thanks for your work on this polyfill! It seems that .13 breaks Safari making it to scroll back to the first element:

https://codepen.io/FabianK/pen/zJLLrR
I can't see from the diff however how it would:
https://github.com/wessberg/scroll-behavior-polyfill/compare/v2.0.12...v2.0.13
maybe the dependencies updates?

@gpbl I believe I've found the solution: The polyfill sets the property scroll-snap-type: none in the element's style attribute to prevent troubles with snapping. But setting scroll-snap-type in safari causes a scrolling to 0 🤯. The workaround was for me to set scroll-snap-type: y mandatory !important. It's ugly, but it works. But could cause troubles in the future… 🙄


Cop idea: remove redundant &. operator for #find_by for classes and ActiveRecord relations

Describe the solution you'd like
# bad
User&.find_by(username: value)

# bad
User.joins(:profile).where(username: all_usernames)&.find_by(username: value)

# good
users&.find_by(username: value)

# good
User.find_by(username: value)

# good
User.joins(:profile).where(username: all_usernames).find_by(username: value)

Rubocop
ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.55.1 (using Parser <IP_ADDRESS>, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.18.0
  - rubocop-factory_bot 2.23.1
  - rubocop-performance 1.18.0
  - rubocop-rails 2.20.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.23.0
  - rubocop-thread_safety 0.5.1

Haven't ever seen (or imagine someone would write) something like examples from 'bad' cases.
Had you seen this?

I've found this in my current project, but didn't find any examples in the real-world-rails.

There are many classes/methods, so if this will be implemented, then it should be not only for find_by and bee configurable. For classes, it does not even make sense to write .&, imo, so we should not complicate checking that.

Ok, I see, thanks for sharing! 👍


[Docker Labs Debug Tools] Issues/Bugs

Tell us about your request
The Docker Labs Debug Tools extension is an experimental feature to improve debugging with docker. It currently features:

shell: Get a shell into any image or container, local or remote. An enhanced replacement of the docker exec with Nix based package manager.
rdb: Easy remote debug setup for containers running a Go/C/C++/Rust binary (gdb and delve support)
attach: Like the shell command but specialized for running containers.

For any issues or bugs, please report here.
Which service(s) is this request for?
Docker Labs Debug Tools extension
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
This is a placeholder to collect issues and bugs.
Are you currently working around the issue?
N/A
Additional context
N/A

bug - stops the new Docker Desktop sleep feature working as there is a persistent running container in the extension.

bug - initial working directory is not the default working directory of the container - I expect it to be like exec in this case, as in some containers used to ending up eg where the app is installed.

bug - On Windows, installation hints are wrong. The extension asks you to add C:\Users\<user>\AppData\Local\Docker Labs Debug Tools\bin to your path. That is an empty folder. Either there is a symlink/copy step missing to get dld.exe there or the correct folder C:\Users\<user>\AppData\Roaming\Docker\extensions\docker_labs-debug-tools-extension\host should be explained to add to your path.

@tminich thanks for reporting the issue! I could reproduce and just released 0.37 which should fix it. Could you update the extension and retry? (you might need to restart docker desktop before so the extension cache gets refreshed and you see the update)
With 0.37 installed, you should see a 'installed' label in the top right corner of the extension ui tab.

Worked, thanks!

@justincormack

bug - initial working directory is not the default working directory of the container - I expect it to be like exec in this case, as in some containers used to ending up eg where the app is installed.

This should be fixed in version 0.38 published yesterday. Would you mind re-testing if that solves the issue?

Unable to use the debug tool
Failed to install the CLI binary. Error: code: 1, stdout: exit status 1 , stdout: Error: exit status 1 Usage: install install [command] Available Commands: check Check if dld is installed and reachable from $PATH completion Generate the autocompletion script for the specified shell fix Fix the $PATH variable to include ~/.local/bin help Help about any command uninstall Remove ~/.local/bin/dld Flags: -h, --help help for install Use "install [command] --help" for more information about a command.
Status: not installed
0.0.41
ZSH has all the correct Paths
fpath=(~/.local/share/zsh/functions $fpath)
autoload -Uz compinit
compinit -u

export PATH="$PATH:/Users/alozoya/.local/bin" # Added by Docker Labs Debug Tools"

Nothing is added or installed to this location related to dld. Please advise...

Thanks @andrew-lozoya for reporting the issue! I need a bit more context to reproduce/understand the problem. Could you tell me the output of docker context ls and s -l /var/run/docker.sock (this file might not exist but then I need to know that instead)?

@justincormack

bug / feature request - PATH does not have the original container path, just the path to the installed tools, I really need both available (unsure about optimal ordering, probably installed tools first though).

This should be fixed in version 0.0.41. The original container/image $PATH is appended for now (maybe there needs to be a convenient way to dynamically change the order).

Install on Windows 11.
Verified path env variable is set correctly. Contents of that directory is solo file dld.exe
Running with no arguments shows usage info.  So, OK
Running with version argument produces:
Docker Labs Debug Tools Extension
Version:    0.0.42
Commit: 5fe3c6850763b83e33a5f81cd2c9135c4ad287d3  So OK
Running with any other arguments produces: message "Seems like the extension is not installed. Open Docker Desktop and install the 'Docker Labs Debug Tools' extension to continue."
Uninstall and Re-install of extension, restart of docker desktop.  No improvement.  Any help is appreciated.

@jamesaburger thanks for reporting the issue! I could reproduce it and already pushed a fix release. Could you update to version 0.0.43 an re-try? (you might need to restart Docker Desktop to see the update)

Thanks for the rapid turn.  Issue resolved.  Cheers

It seems like I cannot use dld with the container used by Dagger for it's engine. I get
Error: unexpected end of JSON input

when I try dld attach or dld shell

@tminich could you give more context? Which exact command were you running? I'm guessing you were using the --host flag. If so, what's the output of docker info on that machine? While it's possible to use--host against any socket, so far it's tested only with docker-ce+runc runtime.

@tminich could you give more context? Which exact command were you running? I'm guessing you were using the --host flag. If so, what's the output of docker info on that machine? While it's possible to use--host against any socket, so far it's tested only with docker-ce+runc runtime.

Sure. In this case I wasn't working remotely, this was local on my development machine running Docker Desktop. The 'target' service is the one automatically provisioned by the dagger command to run the ci pipeline. Basically I was only using dld attach dagger-engine-5097823f019aa092 (or dld shell ..., tried both)

Interesting, any chance you could give some commands/instructions to try reproduce that on my machine? (maybe that's obvious but I've never used dagger)

I've just started to use it yesterday myself =)
But in general, I think the basic introductory quickstart example should work. It provisions the engine service and leaves it running.
If you have nix in your environment, it provides the binary (using that myself in WSL) as a package.
As a side note, the regular shell is accessible in Docker Desktop.

I'll check! (might take a bit until I get to that) Thanks for reporting!

I'll check! (might take a bit until I get to that) Thanks for reporting!

Thanks, no rush. I'm mostly interested in what's going wrong there =)

Sorry to shove another issue on your plate. I'm having trouble with dld shell and containers I created via nix' buildLayeredImage. Not exactly sure what triggers it, maybe the amount of Layers?
The error message I'm getting is
Error: overlay mount to /tmp/279bff3e-76dd-4146-b6c4-b9642eaacf5b/lower: mount options is too long

Here is a (somewhat) minimal flake file to create an image with this issue:
{
    inputs = {
        nixpkgs.url = "github:nixos/nixpkgs";
        systems.url = "github:nix-systems/x86_64-linux";
        flake-utils = {
            url = "github:numtide/flake-utils";
            inputs.systems.follows = "systems";
        };
    };

    outputs = { self, nixpkgs, flake-utils, ... }:
        flake-utils.lib.eachDefaultSystem (system:
            let
                pkgs = nixpkgs.legacyPackages.${system};
                dt = pkgs.dockerTools;
            in {
                packages.default = pkgs.dockerTools.buildLayeredImage {
                    name = "hello";
                    tag = "latest";

                    contents = with pkgs; [
                        dt.usrBinEnv
                        dt.binSh
                        dt.caCertificates
                        dt.fakeNss
                        coreutils
                        nginx
                    ];

                    config.Cmd = [ "${pkgs.hello}/bin/hello" ];
                };
            }
        );
}

If you remove nginx from the contents, the issue goes away. Also if the image is running (in case of the one I'm building), dld attach works fine.

This is very interesting! It makes me wonder if some architectural changes might be needed to the way we currently create the shell for images. The thing is there are like 10 ways to build a feature like this, but they don't tell you which is the right one.. Let me dig into this and get back to you (might take me a bit). Thanks for the comprehensive example!

You're welcome =)
A minor thing I noticed, not sure if that is intentional or not. If I connect to a running nix-based container created in this way with dld attach, /bin is not in the path. Using the regular docker shell (e.g. in docker desktop) it is.

I'm always using my WSL terminal, never Powershell or other options in the windows file system. How ever, after installing the extension, when I type dld in my WSL Ubuntu I get Command 'dld' not found, did you mean: ... How can I fix that?

Hi. I have Docker Desktop 4.23.0 running on top of Windows 10 + WSL <IP_ADDRESS> + Ubuntu 22.04.2 LTS. I have installed and uninstalled the extension multiple times to try to get it to work, but when I run dld in my WSL/Ubuntu terminal, it just says "Command 'dld' not found, did you mean:" and a list of other binary names. The Troubleshooting tab says that "The dld binary has been successfully installed at ~/.local/bin/dld", but my user's home does not have a .local folder, and neither does root. docker images does show that docker/labs-debug-tools-extension   0.0.43 has been pulled. Any tips on where to look next?

Hi. I have Docker Desktop 4.23.0 running on top of Windows 10 + WSL <IP_ADDRESS> + Ubuntu 22.04.2 LTS. I have installed and uninstalled the extension multiple times to try to get it to work, but when I run dld in my WSL/Ubuntu terminal, it just says "Command 'dld' not found, did you mean:" and a list of other binary names. The Troubleshooting tab says that "The dld binary has been successfully installed at ~/.local/bin/dld", but my user's home does not have a .local folder, and neither does root. docker images does show that docker/labs-debug-tools-extension 0.0.43 has been pulled. Any tips on where to look next?

I'm always using my WSL terminal, never Powershell or other options in the windows file system. However, after installing the extension, when I type dld in my WSL Ubuntu I get Command 'dld' not found, did you mean: ... How can I fix that?

I reinstalled it on another computer and saw the command to add it to my path. Unfortunately, it's a command for the Windows path (using setx).
But I did add it to my path on WSL and it works well. Note that I added a dld alias in order to be able to use dld and not dld.exe in my linux terminal.
Also note that my Windows username is jbonn so adapt it for your user.
cat >> ~/.bashrc <<EOT
export PATH="/mnt/c/Users/jbonn/AppData/Local/Docker Labs Debug Tools/bin:$PATH"
alias dld='dld.exe'
EOT

bug — On macOS using Homebrew installed bash as my shell, I get
$ ~/.local/bin/dld shell reg/namespace/repo:tag
Failed to detect shell: reading exe path of PID 9064: missing txt data returned by lsof. Defaulting to zsh.
…

I'm not sure what happened, but dld stopped working for me today. It might be related to updating Docker Desktop.
Now, dld fails to run a shell or attach to a container, I only see a message like this:
$ dld shell c43a1e72ad25
Failed to detect shell: reading exe path of PID 84102: missing txt data returned by lsof. Defaulting to zsh.
Error: chown /tmp/845ca3d8-aa1e-4673-bf55-249ba9e7191f/tmp-home/nix/tmp/debug-tools/.nix-profile: no such file or directory

$ dld shell c43a1e72ad25 --shell bash
Error: chown /tmp/b79f6d80-8c34-4920-9615-a2a094bf850f/tmp-home/nix/tmp/debug-tools/.nix-profile: no such file or directory

I believe I have the latest version (also tried deleting / reinstalling as suggested in the troubleshooting page):
$ dld version
Docker Labs Debug Tools Extension
Version:    0.0.43
Commit: 556e9bb7051de6bd79be842265773cff487a0702

Docker Desktop version:
You're up to date
Docker Desktop 4.24.2 (124339) is currently the newest version available.

bug — dld does not work with Docker Desktop 4.25.0 when the containerd backend is enabled. It seems the location of the containerd sock has changed in the underlying DD VM.

I'm not sure if this is technically a bug, but since dld is always running a container, it effectively disables resource saving mode in Docker Desktop. Is there a way to only start the dld container when it is needed, or let DD know not to consider the dld container when determining whether to sleep or not?

I'm not sure what happened, but dld stopped working for me today. It might be related to updating Docker Desktop.

Update: I just realized that uninstalling/reinstalling the dld binary was not the same thing as uninstalling/reinstalling the extension itself. Just did that, via the Extensions tab, and now it's working again.
It would be helpful, if possible, for the "re-install the extension" text to link to the relevant Extensions page where that can be done.


Performance benchmarks for every possible heavy operations

Atmos processing, force movement processing, items processing, etc.

Separate tab for performance counters + reperesentation operations performance


Pre-Deploy Software to User's Primary Device

Can a section be added to describe what "Pre-Deploy Software to User's Primary Device" actually does?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58bf38ca-c7d6-50e3-9a88-32313f789d62
Version Independent ID: 393cd01c-1b5f-086a-33cc-28a86a26e303
Content: Deploy applications - Configuration Manager
Content Source: sccm/apps/deploy-use/deploy-applications.md
Service: configuration-manager
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Thanks @jpoling1 for filing this
Reference Twitter thread

Fixed this while making some updates to this article for 1806 content. It will publish soon with that release. I'm closing this issue for now.


Document setting Oracle Database single instance resource limits

This change adds documentation of setting ulimits for single instance docker run command.

Hi @marcinroman
Can you tell me why are these parameters needed? I think these are taken care by oracle's preinstalled rpm. Are you facing any issues without these parameters?

These  preinstalled container settings doesn't seem to affect limits.
If run docker-compose without ulimit arguments then:
[oracle@test ~]$ cat /etc/security/limits.d/oracle-rdbms-server-12cR1-preinstall.conf

# oracle-rdbms-server-12cR1-preinstall setting for nofile soft limit is 1024
oracle   soft   nofile    1024

# oracle-rdbms-server-12cR1-preinstall setting for nofile hard limit is 65536
oracle   hard   nofile    65536

# oracle-rdbms-server-12cR1-preinstall setting for nproc soft limit is 16384
# refer orabug15971421 for more info.
oracle   soft   nproc    16384

# oracle-rdbms-server-12cR1-preinstall setting for nproc hard limit is 16384
oracle   hard   nproc    16384

# oracle-rdbms-server-12cR1-preinstall setting for stack soft limit is 10240KB
oracle   soft   stack    10240

# oracle-rdbms-server-12cR1-preinstall setting for stack hard limit is 32768KB
oracle   hard   stack    32768

# oracle-rdbms-server-12cR1-preinstall setting for memlock hard limit is maximum of 128GB on x86_64 or 3GB on x86 OR 90 % of RAM
oracle   hard   memlock    134217728

# oracle-rdbms-server-12cR1-preinstall setting for memlock soft limit is maximum of 128GB on x86_64 or 3GB on x86 OR 90% of RAM
oracle   soft   memlock    134217728
[oracle@test ~]$ ulimit -a
core file size          (blocks, -c) unlimited
data seg size           (kbytes, -d) unlimited
scheduling priority             (-e) 0
file size               (blocks, -f) unlimited
pending signals                 (-i) 96216
max locked memory       (kbytes, -l) 64
max memory size         (kbytes, -m) unlimited
open files                      (-n) 1048576
pipe size            (512 bytes, -p) 8
POSIX message queues     (bytes, -q) 819200
real-time priority              (-r) 0
stack size              (kbytes, -s) 8192
cpu time               (seconds, -t) unlimited
max user processes              (-u) unlimited
virtual memory          (kbytes, -v) unlimited
file locks                      (-x) unlimited
[oracle@test ~]$ ulimit -aH
core file size          (blocks, -c) unlimited
data seg size           (kbytes, -d) unlimited
scheduling priority             (-e) 0
file size               (blocks, -f) unlimited
pending signals                 (-i) 96216
max locked memory       (kbytes, -l) 64
max memory size         (kbytes, -m) unlimited
open files                      (-n) 1048576
pipe size            (512 bytes, -p) 8
POSIX message queues     (bytes, -q) 819200
real-time priority              (-r) 0
stack size              (kbytes, -s) unlimited
cpu time               (seconds, -t) unlimited
max user processes              (-u) unlimited
virtual memory          (kbytes, -v) unlimited
file locks                      (-x) unlimited

See:
https://stackoverflow.com/questions/24318543/how-to-set-ulimit-file-descriptor-on-docker-container-the-image-tag-is-phusion

Hi @gvenzl
I tested this. Its correct. You can approve and merge.

Thanks a lot for your contribution, @marcinroman!
We really appreciate it!


Caching for GraphQL servers

While building GraphQL servers has become very easy, caching in GraphQL servers is still a fairly unexplored topic.
To start a conversation around this topic, I've listed a few ideas that came to mind. Ideally some of these ideas might eventually turn into actual libraries the GraphQL community can use:
Ideas:

Declarative caching system based on SDL directives (field/resolver or type level)
Caching layer built into GraphQL bindings
Caching based on persisted queries

Relevant links:

http://graphql.org/learn/caching/
https://philsturgeon.uk/api/2017/01/26/graphql-vs-rest-caching/
https://github.com/graphql/graphql-js/issues/819

RIght now, there's the Apollo Caching system. However, there isn't any open source projects that I know of that implement this. Only Apollo Engine, which is a black box.
Caching on the edge is also important. That is probably beyond the implementation of Yoga, but should be considered when building something out.

Caching built into the bindings makes more since for me than caching the queries themselves.

Would allow more control over when and how to clear the cache.
Other queries using the same binding could use the same cached resource

See https://github.com/FlacheQL/FlacheQL.

There is an official apollo server doc on using a Memcached/Redis cache backend. But looks like no further info on how to integrate with yoga...

Hey, @Urigo from The Guild here!
You might know us from projects such as graphql-code-generator, envelop or graphql-tools.
For a long time we thought that the Javascript ecosystem is still missing a lightweight cross-platform, but still highly customizable GraphQL Server.
In the past the awesome Prisma team took on that great challenge and now we are happy to announce that we are continuing them and just released GraphQL Yoga 2.0 - Build fast, extensible, and batteries-included (Subscriptions, Serverless, File uploads support) GraphQL APIs in Node.js 🚀
As for the issue here, Yoga uses Envelop's plugin system and marketplace of plugins, which includes the response cache plugin, here is a short video explaining it: https://graphql.wtf/episodes/34-response-cache-plugin-with-envelop
We have been working a long time on version 2.0 and have been using it in our clients projects for a few months now and shared a couple of alpha cycles here.
Thank you all for your feedback and suggestions, you made this release possible!
Please try Yoga out again, give us feedback and help us spread the word on the new release!

Announcement and blog post
https://github.com/dotansimha/graphql-yoga/issues/704
https://www.graphql-yoga.com/


"Preview.Builder() .setTargetRotation(rotation)" does not work

I cloned this project, and then compiled and run. I just modified one place.
            // Preview
            preview = Preview.Builder()
                    // We request aspect ratio but no resolution
                    .setTargetAspectRatio(screenAspectRatio)
                    // Set initial target rotation
//                    .setTargetRotation(rotation)//the original

//                    .setTargetRotation(Surface.ROTATION_0) //test does not work
//                    .setTargetRotation(Surface.ROTATION_90) //test does not work
//                    .setTargetRotation(Surface.ROTATION_180) //test does not work
                    .setTargetRotation(Surface.ROTATION_270) //test does not work
                    .build()

This repo is for issues with the samples. For questions about usage, please use the android-camerax tag on StackOverflow or start a thread in the developer forums.


Users and groups for ESR

Under "3. Select Users may sync settings and app data across devices." can it be clarified if members must be directly assigned users, or if assignment can be via security group?
Thanks,
David

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8c5cde55-2936-090a-cd04-84312a8c1974
Version Independent ID: 4700126d-12fe-9956-28d5-b3fbefa7fb45
Content: Enable Enterprise State Roaming in Azure Active Directory
Content Source: articles/active-directory/devices/enterprise-state-roaming-enable.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@davidkench
Thank you for your feedback . We will investigate and update the thread.

Yes, you can use groups.

#please-close

#reassign:@MicrosoftGuyJFlo


Duplicate module definitions upon opening JS file

Open a .js file, notice warnings in the console

this is not JavaScript

The files that bundle for example vs/base/common/actions up are:
C:\Program Files (x86)\Microsoft VS Code Alpha\resources\app\out\vs\languages\typescript.workbench\common\projectResolver.js
C:\Program Files (x86)\Microsoft VS Code Alpha\resources\app\out\vs\workbench\node\pluginHostProcess.js
C:\Program Files (x86)\Microsoft VS Code Alpha\resources\app\out\vs\workbench\parts\git\browser\gitViewlet.js
C:\Program Files (x86)\Microsoft VS Code Alpha\resources\app\out\vs\workbench\parts\search\browser\searchViewlet.js
C:\Program Files (x86)\Microsoft VS Code Alpha\resources\app\out\vs\workbench\workbench.main.js

Moving back to Joh since I thing \typescript.workbench\common\projectResolver.js is causing this when opening a JS file.

I do reproduce the issue. Could that be why my js highlighting is down ? I have no extensions installed whatsoever.

I don't see  this anymore, JS is gone


Fail to run MAKEFILE

make -C /lib/modules/4.19.97-v7+/build M=/home/pi/Dali/RPi3-DALI/RPi3-DALI-master modules
make[1]: *** /lib/modules/4.19.97-v7+/build: No such file or directory.  Stop.

Perhaps the lib modules are not installed or the version is different.

thanks for your instant reply.
May I have your advice on how to install the lib modules?

Well as I said there is some time passed and I can't remember a few things. I have to see where I have placed the files with the detailed procedures. Give me some time to have a look. In addition, please have a look at a relevant publication https://www.mdpi.com/2079-9292/8/9/1021 in case you find some useful information.

I have succesfully run the MAKEFILE after installing the kernel header in Pi3.
Thanks. But still , facing the error Value of fd is: -1 Cannot open device

Dear fellow,
I am glad that you manage to run the Makefile.
Now about the failure to open the device and the returned error value, although it seems something simple to tackle, I can't remember what we did to succeed. Our team is now engaged with other development platforms and this setup is widthdrawn in order to go ahead and check it.
Therefore I am not sure if I could find out any solution, but as I said I will try. In this case I will inform you. Meanwhile, have a look/search at the web. Perhaps similar problems were encountered, which we followed too to solve it.
Best regards.

Thanks for your comment.
I think the failure to open the device is caused by failing to find the kernel module driver "#define DALI_drv "/dev/RPi_DALI_drv"
do you know is there any hints that I could makesure "/dev/RPi_DALI_drv" is installed/loaded correctly? I am not able to find RPi_DALI_drv in /dev/ folder under root.
Hope these can bring you some memory :)

Well if “sudo insmod RPi_DALI_drv.ko” is successful (with no error messages) it should have been loaded correctly.
I can’t remember which one works, here follow a few thoughts for checking if it is loaded correctly:
lsmod
cat /proc/modules
cat /proc/devices
ls -l  /dev/RPi_DALI_drv
Perhaps the problem has to do with the permissions (probably only root has rw permissions).
Check your permissions (perhaps you have to use sudo or change permissions with chmod).
Sorry, but I can’t remember further at the moment.

Cool! we are now very close to solve the problem.
The make -f MAKEFILE cannot help to put RPi_DALI_drv.ko to lsmod
lsmod cannot find RPi_DALI_drv.ko
what we need is to get RPI_DALI_drv.ko into lsmod
if makefile didnt work, would it be other workaround?

insmod succesfully
lsmod , RPi_DALI_drv.ko is running
pi@raspberrypi:~ $ ls -l /dev/RPi_DALI_drv
crw------- 1 root root 240, 0 Apr  23 23:07 /dev/RPi_DALI_drv
but still, value of fd is -1, cannot open device..  That is pleasant.
As I said, at the moment I am not in position to provide any further help (the platofrm setup is withdrawn -which makes it more difficult for me to find out what is going on-, and I am also engaged on other intensive research work having strict deadlines), but I will try to look for it (in the meantime, in anycase, as I said previously, do a web search with this error message, you may get a quicker answer).

Understand :) Thanks for your great effort.

Finally, I can run the program!
however, it still cannot communicate with the DALI device.
May I know, which protocol that your driver is using? i2c? UART? or Serial?


<EMAIL_ADDRESS>failing npm install

Not sure if this is even something that node-tap has control over, but it seems that since issue of 14.10.2 I am getting npm install issue coming for same directory renaming step of npm install for each install attempt. This is being triggered by install of tap's babel dependency.
The error is as follows:
$ npm i -P<EMAIL_ADDRESS>npm ERR! code EPERM
npm ERR! syscall rename
npm ERR! path C:\Users\mbrant\git\devops\node_modules\tap\node_modules\@babel\.helper-builder-react-jsx.DELETE\node_modules\@babel
npm ERR! dest C:\Users\mbrant\git\devops\node_modules\tap\node_modules\@babel\helper-builder-react-jsx\node_modules\@babel
npm ERR! errno -4048
npm ERR! Error: EPERM: operation not permitted, rename 'C:\Users\mbrant\git\devops\node_modules\tap\node_modules\@babel\.helper-builder-react-jsx.DELETE\node_modules\@babel' -> 'C:\Users\mbrant\git\devops\node_modules\tap\node_modules\@babel\helper-builder-react-jsx\node_modules\@babel'
npm ERR!  [OperationalError: EPERM: operation not permitted, rename 'C:\Users\mbrant\git\devops\node_modules\tap\node_modules\@babel\.helper-builder-react-jsx.DELETE\node_modules\@babel' -> 'C:\Users\mbrant\git\devops\node_modules\tap\node_modules\@babel\helper-builder-react-jsx\node_modules\@babel'] {
npm ERR!   cause: [Error: EPERM: operation not permitted, rename 'C:\Users\mbrant\git\devops\node_modules\tap\node_modules\@babel\.helper-builder-react-jsx.DELETE\node_modules\@babel' -> 'C:\Users\mbrant\git\devops\node_modules\tap\node_modules\@babel\helper-builder-react-jsx\node_modules\@babel'] {
npm ERR!     errno: -4048,
npm ERR!     code: 'EPERM',
npm ERR!     syscall: 'rename',
npm ERR!     path: 'C:\\Users\\mbrant\\git\\devops\\node_modules\\tap\\node_modules\\@babel\\.helper-builder-react-jsx.DELETE\\node_modules\\@babel',
npm ERR!     dest: 'C:\\Users\\mbrant\\git\\devops\\node_modules\\tap\\node_modules\\@babel\\helper-builder-react-jsx\\node_modules\\@babel'
npm ERR!   },
npm ERR!   stack: "Error: EPERM: operation not permitted, rename 'C:\\Users\\mbrant\\git\\devops\\node_modules\\tap\\node_modules\\@babel\\.helper-builder-react-jsx.DELETE\\node_modules\\@babel' -> 'C:\\Users\\mbrant\\git\\devops\\node_modules\\tap\\node_modules\\@babel\\helper-builder-react-jsx\\node_modules\\@babel'",
npm ERR!   errno: -4048,
npm ERR!   code: 'EPERM',
npm ERR!   syscall: 'rename',
npm ERR!   path: 'C:\\Users\\mbrant\\git\\devops\\node_modules\\tap\\node_modules\\@babel\\.helper-builder-react-jsx.DELETE\\node_modules\\@babel',
npm ERR!   dest: 'C:\\Users\\mbrant\\git\\devops\\node_modules\\tap\\node_modules\\@babel\\helper-builder-react-jsx\\node_modules\\@babel',
npm ERR!   parent: 'tap'
npm ERR! }
npm ERR!
npm ERR! The operation was rejected by your operating system.
npm ERR! It's possible that the file was already in use (by a text editor or antivirus),
npm ERR! or that you lack permissions to access it.
npm ERR!
npm ERR! If you believe this might be a permissions issue, please double-check the
npm ERR! permissions of the file and its containing directories, or try running
npm ERR! the command again as root/Administrator.

npm ERR!      C:\Users\mbrant\AppData\Roaming\npm-cache\_logs\2019-11-26T19_51_06_256Z-debug.log

My environment is as follows:
OS: Windows 10 Pro Version 1903
node: 13.01
npm: 6.13.1
I have tried installs both in git bash and windows CMD shell, including with admin privileges.
I have also tried all the typical npm troubleshooting (npm cache clean --force, rm -rf node_modules, etc.). Regardless as to shell or npm install state, I am alwasy able to successfully install 14.10.1, but not 14.10.2.  14.10.2 always ends with same EPERM error on same directory renaming operation.

I believe this is scoped bundleDependencies triggering a weird edge case in the npm v6 CLI.
You can try npm i tap@unbundled to see if that lets you move forward. (Note: this will cause problems if tap is used alongside react of any version other than 16.)

So what are other implications are the in taking the unbundled distribution?  How does this distribution differ from latest?

Same issue here.

Same issue here.  Falling back to 14.10.1 for now.

I believe this is scoped bundleDependencies triggering a weird edge case in the npm v6 CLI.
You can try npm i tap@unbundled to see if that lets you move forward. (Note: this will cause problems if tap is used alongside react of any version other than 16.)

This actually did not resolve the issue for me. Version 14.10.1 installs just fine, however npm i tap@unbundled as well as the bundled version result in the EPERM issue.

This seems to be a Windows only issue. I don't see this happening on macOS or Linux. But every one of this project's Windows builds fails -- https://github.com/ldapjs/node-ldapjs/pull/585/checks?check_run_id=338082433#step:4:1

Ran into this today in GitHub Actions windows environment.

Adding npm i tap@unbundled in front of the previously failing npm i step allowed for the installation to proceed without error on windows in that GH windows-latest environment.

I'm closing this as it's been a couple months and nobody has spoken up to say it's still an issue.  If I'm wrong speak up and we will investigate further.

@coreyfarrell I'm experiencing this issue with tap@15. Installation for tap@unbundled works fine. Is there a reason it is kept on version 14? Thanks!


Avoid kafka thread leak - LOG4J2-2916

During reconfigure, LoggerContext will start new configuration and stop previous configuration. The firstime, prev is DefaultConfiguration, new configuration is eg: XmlConfiguration. Then the xml defined appender count in abstractmanager will be increased to 1. The nexttime reconfigure is called, xml defined appender count will be increased to 2. However the abstractmanager stop method will check if --count is <= 0. This cause the kafka producer thread never get stopped.
So each time loggercontext config start, the kafkamanager will create new kafka producer thread although it has one producer instance already. And the producer thread will never get closed.
The count is correct. It means the count of appenders using this manager. As we can see, the AbstarctManager will store a map of all static log4j2 managers. So during reconfigure, if managers is used by new config, the manager shouldn't be closed. Instead I just added a logic to check whether new kafka thread should be opended.

Testcase added. Is there anything else I can do?

@jvz  kindly help to advise

@wuqian0808 could you fix the filename of the test file? Without the .java extension, I'm pretty sure the compiler or Maven will complain.

@wuqian0808 could you fix the filename of the test file? Without the .java extension, I'm pretty sure the compiler or Maven will complain.

File name changed

@rgoers Could u help to advise? Or is there anything else should I do?

@vy  Could u help to advise if there is anything else should I do before merging?

Nevermind, applied your changes manually. Will backport it to 2.x too. Thanks so much!


pre-install: Fix service name for cri-o runtime

the cri-o runtime uses "crio.service" service name (tested on OCP 4.14)
Related to: #418

@fidencio makes sense to me (although personally I'd move it even directly to get_container_runtime). I tried addressing all the places (except one that uses the local container_runtime and which should contain the cri-o).


Setup APIs and ngrok but no pickup

Hi I setup the webhook in twilio to call ngrok/incoming-voice endpoint but it just rings forever when i call and when i make it ngrok.app/audio/incoming-voice I get a 405 error, Is there some missing setup required in the readme?

Hm worth checking if these environment variables are set:
account_sid = os.environ["TWILIO_ACCOUNT_SID"]
auth_token = os.environ["TWILIO_AUTH_TOKEN"]
from_phone = os.environ["TWILIO_PHONE_NUMBER"]

Other than that any other error messages / logging you are seeing when this happens?
As another sanity check, you could add tws.start_call("your phone #") like in the example script to see if it's able to interact with the twilio API.

Hi Thanks for your quick response
The twilio API interaction all seems to be correct since i get and can recieve calls
I got it working by removing the {{host}} param and just adding the websocket url directly here:
<Response>
    <Start>
        <Stream name="Audio Stream" url="wss://d0ef-104-173-33-232.ngrok-free.app/audiostream" />
    </Start>
    <Pause length="60"/>
</Response>
"""```

Only thing that isn't working is I don't hear any audio (the TTS part) over the phone or from my computer, but that might be due to my system settings and running the script from Windows WSL

Thanks this is an awesome project!

Great! To debug the TTS you could try to find the "tts.mp3" in your temp directory to see if that's being generated at all or correctly.

Great! To debug the TTS you could try to find the "tts.mp3" in your temp directory to see if that's being generated at all or correctly.

Maybe it does not generate for me. is the temp dir in the same folder? or in a system folder? Running debain.

It'll write to system temp folder os.path.join(tempfile.mkdtemp(), "tts.mp3")


updating to 32 bit tokens and keys

this should be done in a way that doesn't need a migration of outstanding tokens. we are using attempting to use Flask-User with simpleflake generated ids

@lingthio i will take a look at the test results and adjust.

found the undocumented way to use my own token manager, so i will close this for now. but it would be nice to have docs on that, or to not limit user ids to 16 bit

solved by #96


Miss $FRONTEND_NAME variable definition

The commands used in the Deploy front end application section are:
The $FRONTEND_NAME variable is undefined and causes an error.
Therefore, it must be further predefined in the Setup section.

https://docs.microsoft.com/en-us/azure/container-apps/communicate-between-microservices?tabs=bash&pivots=acr-remote

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e1779a5c-d2f0-d5c6-ef58-238db5a0ff4e
Version Independent ID: 077bc418-7885-5bd6-1304-03b48947ee07
Content: Tutorial: Communication between microservices in Azure Container Apps
Content Source: articles/container-apps/communicate-between-microservices.md
Service: container-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@zer0big Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.


One-dimensional Field

1D field will require a one gridcell boundary condition. How will this affect the
boundary condition axes?

Should handle #149 as well


[production] PDF rendering fails silently in Safari for S3 and OSF Storage

Steps

View the file detail page for a PDF stored in an S3 add-on in Safari (e.g. https://osf.io/neijc/)

Expected

The PDF is rendered

Actual

The PDF never renders, and no errors are thrown in the console.

This doesn't appear to be a cross-domain issue, since no errors are thrown. Other files that typically throw cross-domain errors, including images, work fine. This issue also affects PDF rendering in Safari in the new OSF Storage add-on. Thanks @GaryKriebel for originally reporting this.

This should be fixed on develop with the latest changes to MFR


Improve serialization and deserialization of MultiLabelBinarizer

Improve serialization and deserialization of MultiLabelBinarizer, and add more checks.
Run tests with python3 -m unittest test/test_preprocessing.py.

Thanks for reviewing!


Implement a redirecting page during the auth flow

Currently after logging in, we are not using any redirecting page. So after logging in, a page like this is shown:

Need to implement a new redirect page.

Fixed in 55b22641d6bb11548f6ad7fc559f5c3bd315871d


Icons accessibility

We can use a Macro to populate the icons in an excle sheet. For each folder, a new sheet is added and all the icons in that folder are added per cell in the sheet with the label of the icon derived from the icon file name.
Optionally, we can create an index sheet for all the sheets added.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6624d44c-f9f6-02f8-2c67-0f0637fed62e
Version Independent ID: 9346a8ff-bab5-be2c-9dc1-d546fda1efa9
Content: Azure icons - Azure Architecture Center
Content Source: docs/icons/index.md
Service: architecture-center
GitHub Login: @EdPrice-MSFT
Microsoft Alias: pnp

Thank you for your detailed feedback.  We are looking into the issue, and we will respond when we have more information.

@amitmait - Downloading the icons currently requires acceptance of the terms, which makes any automation problematic. If you want to provide more details on the scenario you are attempting to enable, feel free to open another feedback item with more details.
#please-close


Support full hardware identification for CPU threads

Background
Recently there has been an increased interest in understanding where a particular CPU thread of an application thread is running, and what other threads are occupying the same limited resource. While some of this information is available for GPUs (as exposed by the programming model), we currently support nothing for CPUs even though the relevant APIs are mature and readily available. On the other hand, querying the scheduler rapidly for every sample would cost a significant and unacceptable overhead.
A good middle ground seems to be thread affinity. Although this is unverified, I posit that applications will change affinities infrequently, and when they do it will be an indication that the thread is changing roles. Since affinity is in effect the application's requested scheduling, it holds much of the same meaning as the actual scheduling while also providing a source-level meaning suitable for users.
Proposed Design
There are two design points to consider, first is an extension to the identifier tuples to support larger IDs to store the entire affinity bitmask (which may be 1024 bits or even wider). The proposed design is to steal another high-order bit from the kind field, to mark the physical ID as a pointer into a separate section containing the affinity mask (or other very large IDs). Prof2 can then be extended to pass the identifier tuple through to the Viewer as usual. How this should interact with the other interpretation bits and whether other "kinds" should be added are up for debate.
The second point is the presentation in the Viewer. The proposed design is to present the affinity as an "LED strip" in the trace view, lighting up the enabled set of hardware threads. Threads are then groups into these affinity sets, making it easy to see which threads are sharing the same group of threads (for good or ill effect). If and how this could be indicated in the profile view (e.g. to show that a high cache miss rate might be because of affinity) is up for debate.

This repository has moved to GitLab, please continue this issue there.


[Enhancement] Add ability to set which item should get focus in Login.

Summary
My Login prompt has a value for login so I dont need the focus at the login field.
API Changes
LoginConfig - DefaultTitle - DefaultOkText - DefaultCancelText - DefaultLoginPlaceholder - DefaultPasswordPlaceholder
and DefaultFocus => "Login" or "Password"
Intended Use Case
I need the focus at the password field.
Or I have to build a new prompt without the Login field.
Is it possible to build such a prompt?
this.Dialogs.ActionSheet(new ActionSheetConfig()
  .SetTitle("Username Max")
  .Add("Password", () => this.PromptCommand(InputType.Password))
  .SetCancel())

Thanks for the cool stuff!

You can use prompt for this.  I don’t plan to implement this on the login control though


Use TensorShape for shapes in TFE

In the keras code base they use tf.TensorShape at different places, for example here.
We should consider using tf.TensorShape as well, so we can handle properly partially-known shapes and unknown shapes.

from @mortendahl in #494

one problem with partial shapes is the triple stuff, since they can't be generated offline if the shape is not complete. We could make that a special case though, as the online triple source should work with partial shapes (although we may have to add some control dependencies).

yeah, currently the online triples don't work either (factories try to generate tensors with partially known shapes, which gives a ValueError since tensors need to have well-defined shapes)