Add rnassqs

Insert URLs to the project here:
https://github.com/ropensci/rnassqs

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as 'Good First Issue' of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.

@potterzot


EkPlayButton: Don’t use nullish coalescing operator

My ChromeOS test machine has Android WebView 68, which doesn’t support this operator. That causes a syntax error when loading the kolibri-explore-plugin, and hence the app never loads.
Nowhere else in the code is the nullish coalescing operator used, so let’s get rid of this instance for now.
It’s apparently supported by WebView 80 onwards
(https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing#browser_compatibility). I don’t know if we want to depend on that yet.
Signed-off-by: Philip Withnall<EMAIL_ADDRESS>Helps: #156

One reason to merge this rather than saying I should update my WebView is that I did run all the system updates I could find before testing, and that still didn’t update the WebView. Specifically searching for WebView in the Play Store on the machine shows an ‘Update’ button, so I could potentially update it. I won’t do that for now, so that I can test the fix if this lands.
If doing all the system and app updates shown to me by Android didn’t update the WebView, I expect that can happen to other users, and hence we might want to be conservative about depending on newer WebView versions.

I'm okay with the quick fix, but also it's very strange that this is happening. This whole thing runs babel using a browserslist from here…
https://github.com/learningequality/kolibri/blob/develop/packages/browserslist-config-kolibri/index.js
… which should be telling the appropriate pieces to please support Android > 4.4.3 and ChromeAndroid >= 49. So Babel should be transforming the nullish coalescing operator to something else automatically. I wonder why it isn't?

Oh, but I see the template-ui packages do their own thing here: https://github.com/endlessm/kolibri-explore-plugin/tree/master/packages/template-ui. They don't appear to use browserslist-config-kolibri and instead have a more conventional > 1%, last 2 versions, not dead. Is it possible this issue is specifically with channel apps, or is it affecting the Discover page itself as well?

Is it possible this issue is specifically with channel apps, or is it affecting the Discover page itself as well?

I don't know: I could only reproduce it on the EK app on Android, and one of the symptoms was that it wouldn't successfully download a content pack, so I never got to test further into the app than initial download.

I tested the apk with this fix landed, and it hit another syntax error, so it looks like we need a more comprehensive fix.


libpath_ops.so does not exist in linux engine v2 builds

Invalid argument(s): Failed to load dynamic library 'libpath_ops.so': libpath_ops.so: cannot open shared object file: No such file or directory
#0      _open (dart:ffi-patch/ffi_dynamic_library_patch.dart:11:43)
#1      new DynamicLibrary.open (dart:ffi-patch/ffi_dynamic_library_patch.dart:22:12)
#2      _dylib.<anonymous closure> (package:path_ops/path_ops.dart:307:31)
#3      _dylib (package:path_ops/path_ops.dart:310:2)
#4      _dylib (package:path_ops/path_ops.dart)
#5      _createPathFn (package:path_ops/path_ops.dart:330:5)
#6      _createPathFn (package:path_ops/path_ops.dart)
#7      new Path (package:path_ops/path_ops.dart:135:17)
#8      main.<anonymous closure> (file:///b/s/w/ir/cache/builder/src/flutter/tools/path_ops/dart/test/path_ops_test.dart:10:23)
#9      Test.run.<anonymous closure>.<anonymous closure> (package:litetest/src/test.dart:69:21)
#10     new Future.<anonymous closure> (dart:async/future.dart:253:37)
#11     _rootRun (dart:async/zone.dart:1390:47)
#12     _CustomZone.run (dart:async/zone.dart:1300:19)
#13     _CustomZone.runGuarded (dart:async/zone.dart:1208:7)
#14     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1248:23)
#15     _rootRun (dart:async/zone.dart:1398:13)
#16     _CustomZone.run (dart:async/zone.dart:1300:19)
#17     _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:1232:23)
#18     Timer._createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:18:15)
#19     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:398:19)
#20     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:429:5)
#21     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:192:26)

Link to failure:
https://ci.chromium.org/p/flutter/builders/try/recipes-with-led/b8789151852609550529?

Fixed adding proper ninja targets: https://github.com/flutter/engine/pull/39635


[ACM-3748] Set max source resolution to auto in Grafana datasource

Sets max_source_resolution=auto in the Grafana datasource's customQueryParameters. This should force the underlying Thanos Query Frontend to perform additional queries for downsampled data in case of empty responses.

Tested this with a local cluster and it worked! 🎉


Add option to honor the order of expected actions

BREAKING CHANGE: convert timeout argument to an options object
Resolves #6

This implementation is much better!


What does the N/A role mean when add members?

See below, what does N/A mean, do users understand?

@wemeya please pull the latest codes, and rebuild it.

ok, I will close the issue.


Dying Light terrain corruption

I have several times encountered small patches of terrain which is randomly placed too high or too low. The problem should be clear by the following screenshots of a more extreme case:

Software information
Dying Light (latest GOG Version). The problem is present on both lowest and highest settings.
System information

GPU: AMD RX 580 8 GB
Driver: 19.0.0-devel (git-896c59d 2018-11-22 xenial-oibaf-ppa)
Wine version: wine-3.20 (Staging)
DXVK version: 0.93 (but also happens with version 0.91).

Apitrace file(s)

https://wetransfer.com/downloads/358d8ec23d92f7ac168a555bf049791a20181124171052/3540d3b8cf4e7e788de70d98bf6fa07f20181124171052/ab4eab

Log files

d3d11.log: DyingLightGame_d3d11.log
dxgi.log: DyingLightGame_dxgi.log

Are you sure that this isn't just a game bug? Same thing happens when replaying your trace with wined3d.

I do not currently have a Windows computer to test this on. However, I have found some videos on Youtube where people didn't have the same problem - as an example (I apologise for the blurriness; these were the best screenshots I could get):

Source
And for comparison (DXVK screenshot first):

Source
Furthermore I am fairly certain that this is a bug in DXVK, since I sometimes experience the same in other games run through DXVK (e.g. The Witcher 3 where the water sometimes has a wrong height offset) but I haven't seen this in a native game.

Same thing happens on Windows when replaying your trace.

I have now gotten access to a Windows computer and it appears, that the bug does indeed happen there as well, so I guess it is not a DXVK bug after all. Sorry for the inconvenience.

Alright, thanks for testing. I guess this can be closed then.


legacy: OAI Harvest admin fix

FIX Fixes an issue with outputting the post-process arguments
when adding or editing an OAI source.

Without this fix, the legacy OAI harvest interface returns 500 Internal Server Error.

@jalavik is it only for master or also for maint-2.0?

@jirikuncar Its only for master

Please update copyright year in invenio/legacy/oaiharvest/web/admin/oaiharvestadmin.py (2: L102 copyright year is outdated, expected 2015 but got 2014).


Swift 3 branch?

Is there a Swift 3 branch?

Hi Emanuel,
I'll do it the next week.
Thanks,
Matteo

On 7 Oct 2016, at 22:18, Emanuel Guerrero<EMAIL_ADDRESS>wrote:
Is there a Swift 3 branch?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@eman6576 I have converted the Main class and not the example. https://github.com/taglia3/TGLParallaxCarousel/pull/8

Hi Emanuel,
the carousel project now is in Swift 3.
Matteo


Option to select Target RPS value for locust test run

Is your feature request related to a problem? Please describe.

I have a use case in which I want to give user option to enter any value of target rps. And my load testing system should generate it. How can I achieve this ? Any idea ?
I am using locust as a library in my project and running it in distributed mode. I tried increasing workers, users but I am not able to generate load more than 200 rps. I also tried wait_time but I cannot find any value for it so that I can achieve rps whatever user provides in the input while running my project.
This is little urgent for my project. If someone can reply, or can give hints how to do it. It would be super helpful. Thanks !!
Describe the solution you'd like

Maybe locust have one flag called target-rps and as an example if while running locust we set it's value to 300. During the entire test run, locust should make 300 requests per second regardless of latency of backend APIs.
Describe alternatives you've considered

I tried setting different values of wait_time and changing no of workers and users but it does not seem to give me exact rps I needed. Also I am not able to achieve rps of higher values. After some point, even increasing no of workers and users will have no effect on rps.
Additional context

To achieve higher rps, check out https://github.com/locustio/locust/wiki/FAQ#increase-my-request-raterps
to constrain rps to a certain value, use wait time constant throughput https://docs.locust.io/en/stable/api.html#locust.wait_time.constant_throughput

locust-plugins offers something along those lines. If someone were to modify it to dynamically launch new users (up to some threshold, we dont want people to accidentally DDoS:ing their systems), I guess that would be ok. Otherwise just launch enough users.
https://github.com/SvenskaSpel/locust-plugins/blob/master/examples/constant_total_ips_ex.py


Enable WithEvent to send an event to the AWS EventBridge

Addresses https://github.com/grafana/redshift-datasource/discussions/131

@andresmgot Have addressed your feedback. Thanks for the detailed feedback though :-)

@andresmgot Have addressed your review comments.. Thanks for the detailed reviews :-)


Add possibility to configure own path to /api-docs/swagger.json

The /api-docs/swagger.json is hardcoded at https://github.com/inaka/cowboy_swagger/blob/2.7.0/priv/swagger/swagger-initializer.js#L6 and it lead to issues if few dependencies in the project are use this great library for creating Swagger. It will be nice if path to /swagger.json can be configured or at least depended by name of application where this library is used.

For reference, it's set here: https://github.com/inaka/cowboy_swagger/blob/24334d88d76770f32ee0eed2218c94e7e2eb8720/.github/workflows/up_swagger.sh#L25

Nice! It looks like I not only one person who want to have it! 😄


Automated cherry pick of #830: chore: helm chart release for driver v1.1.1

Cherry pick of #830 on release-1.1.
#830: chore: helm chart release for driver v1.1.1
For details on the cherry pick process, see the cherry pick requests page.

/azp run pr-e2e-azure


feat(styles): implement v2 styles for checkbox, radio-button & switch using tokens

Checkbox: https://preview-3965--swisspost-design-system-next.netlify.app/?path=/docs/e6ecc86f-d148-413b-b796-614a89da54be--docs
Radio button: https://preview-3965--swisspost-design-system-next.netlify.app/?path=/docs/151242aa-a074-4a55-a81c-db597c83cdad--docs

E2E test for the card-control currently fail. The issue is that some tests use a fixture file which needs to load the styles file and the fonts. The fonts however are not able to be loaded due to proxy problems. After discussing this with philipp we decided to postpone finding a solution for this so the PR can be reviewed and merged.
Some of the spacing styles of the radio-button and the checkbox within fieldsets is not looking like the design right now. This is due to some styling having to be done in the fieldset styles instead of the checkbox/radio styles. A ticket to do this has been created.

The switch alignment is not correct at the moment. A follow up ticket was created to fix this: #4039


Python crashes on retro.make

Issue summary
Typing import retro everything is fine but as soon as I write env = retro.make('Airstriker-Genesis'), I get "Python has stopped working", similarly on my Ubuntu VM (on the same computer) I get "Illegal instruction (core dumped)"
What the "Python has stopped working" gives as problem details
Problem Event Name:	APPCRASH
Application Name:	python.exe
Application Version:	<IP_ADDRESS>3
Application Timestamp:	5b331a30
Fault Module Name:	_retro.pyd
Fault Module Version:	<IP_ADDRESS>
Fault Module Timestamp:	5c8afa11
Exception Code:	c000001d
Exception Offset:<PHONE_NUMBER>018068
OS Version:	6.1.76<IP_ADDRESS>.256.48
Locale ID:	18441
Additional Information 1:	30e2
Additional Information 2:	30e29500d817cc1cb7f8fb2897b9e410
Additional Information 3:	4b56
Additional Information 4:	4b56ade362b64545b3685888f85375e1
System information

[Operating system] Windows 7 / Ubuntu 18.04
[Python version] 3.7.0 x64 / 3.6.8 x64
[Gym Retro version] 0.7.0 / 0.7.0 installed with python3 -m pip install gym-retro

What solved the issue was removing everything between and inclunding #ifdef __SSSE3 and #endif, for all such ifdefs in retro/src/imageops.cpp, and then doing python3 -m pip install -e . not sure if this is my computers fault for defining SSSE3 and not supporting ssse3 so I'll leave it open just in case if it's not my computers fault.

What CPU do you have? This should be fixable.

AMD A6-3600 supposedly it has both SSE3 and SSE4a but not SSSE3

@endrift do you think this should be fixed?  If we set the minimum supported processor to be one with SSE4.1, then users with very old processors can compile it with this line disabled: https://github.com/openai/retro/blob/master/CMakeLists.txt#L21 right?

It's possible to fix using gcc's __builtin_cpu_supports to conditionally call the SSSE3 code, but I'm not sure how worth it it is. We've only heard of one person so far who doesn't have SSSE3 support, and the list of CPUs that don't support it in this day and age is quite short.

I'm going to close this as an unsupported CPU and update the readme.


Code in a post

When adding some HTML/JavaScript to a post, the text disappears after clicking submit.
Case in point:  I tried to enter  as my first post, and nothing actually posted.

Good catch :+1: . I think this has something to do with sanitizing the input.

@pmuens found something?

The sanitizing of Meteor will prevent this. I think that #8 and #43 are related to this and an implementation of those two issues will resolve the issue.

Done.


Fix to read attributes only in some elements and not to write attributes and elements for null

This PR fixes the bug while reading attributes. If there are attributes only in some elements in an array, it fails to read attributes.
Also, this PR fixes this to write nothing for null.

Current coverage is 89.13%

Merging #64 into master will increase coverage by +1.00% as of 1ab1b0f

@@            master     #64   diff @@
======================================
  Files           12      12
  Stmts          615     626    +11
  Branches        82      86     +4
  Methods          0       0
======================================
+ Hit            542     558    +16
  Partial          0       0
+ Missed          73      68     -5

Review entire Coverage Diff as of 1ab1b0f

Powered by Codecov. Updated on successful CI builds.

Merged.


Add resin io support for am571x-evm

How to force AM57xx EVM to boot from eMMC after resin-image-flasher from SD card is finished? I can see that mmcblk1 device is populated, but the board is always booted form mmcblk0. Removing the SD card does not help.

Removing the SD card from the board would force your board to boot from the other available media, which should be the eMMC.
If you remove the SD card and press SW3 do you get something on the debug console?

No, the console is empty. The only way I can boot device is via SD card without pressing the button. After a few minutes, the systemctl-shutdown is called. Is that normal?

So you get no output on the console but only after a few minutes when you see systemctl-shutdown being called? You should see some boot logs too. But about the systemctl shutdown problem, I am aware of that and looking into it just now as a matter of fact.
This being said, this is still somewhat WIP.

Let me rephrase that. When you boot off the SD card, at some point systemctl shutdown is being called?
And after that, you remove the SD card and try to boot off the eMMC and nothing happens?

I can see console only if SD card with resin-image-flasher is inserted and the device is booted. I do note need to press SW3 when powering on in order to boot from SD card. This was usually the case with beaglebone. When mounting mmcblk1 device I can see all partitions already be made, but when removing the SD card, EVM is not booted (not even U-Boot). Maybe auto shutdown is a problem here?
In order to build the images I changed the Dockerfile in docker-disk (added tmp path before entry.sh), otherwise image build failed. Also host-update-resin.bbclass needs to be changed to find proper images for tar. I have used IMGDEPLOYDIR instead of DEPLOY_DIR_IMAGE. Are you aware of this problems?

Exactly @last message

Yes, these should be fixed now. When did you fetch the repository? Might try to pull it again. And sorry, as it is still WIP, I have rewritten the history to keep just the initial commit until I feel it is stable. Once we release the board in resin.io, then I will consider it stable and git history shall be also stable.
So when you boot off the SD card, that particular image is a flasher image (an installer) which writes the resin OS image to the eMMC and then shutsdown. After that, removing the SD card and pressing SW3 should boot off the eMMC.
In order to avoid the reboot, you could boot off the SD card again, mount the rootfs as read-write# mount -o remount,rw / , edit /usr/bin/resin-init-flasher and comment out the shutdown part at the end of this script and then restart the resin-init-flasher.service again. When it finishes you can inspect the eMMC and check if it has been partitioned etc.
And by the way, hat hardware revision are you using?

I have fetched the repository a few hours ago. My board version is A3. Would be possible to include the history in your commits in order to see what is changed. This way is easier for us to analyze the fixes.
What would be the best way to clean the images I have built but not to go through the whole building procedure again, because it takes too much time?

Right now I am working in meta-resin and adding changes there so we have this board using poky morty revision. So this means I had to do quite a few commits in meta-resin and then that would have meant a lot of meaningless meta-resin submodule updates in resin-am57xx-evm. Once it is stable, as I said, the git history would not be changed anymore.
A3? That is a bit strange. Are you sure you are using the AM571x Industrial EVM board? My board says Revision 1.3A on the PCB and it is not that old. Your A3 seems a bit strange to me.
Well, if you have pulled the repository successfully, you should be able to just run barys once more and the build process would re-build only the packages which have the yocto metadata changed

I am using http://www.ti.com/tool/TMDSEVM572X

Hm, this may be a problem.
Have you ever booted the board with something else other than resin? Do you know where the bootloader needs to be written when booting off the eMMC? I suspect that this is the difference between your board and the one that I am using. See this file about more details on this: https://github.com/resin-os/resin-am57xx-evm/blob/master/layers/meta-resin-am57xx-evm/recipes-support/resin-init/resin-init-flasher.bbappend

I have used the board with Ubuntu image succesfully. I think the processor is similar enough, but will check.
Thanks for support.

Manually copied MLO an uboot to mmcblk1p1 and the board boots from eMMC.
Still having problems with docker-disk Dockerfile and entry.sh. Also resinhup tar is not finding images from DEPLOY_DIR_IMAGE. Wonder why others don't see these problems?

What is the command you use to build? Can you paste it here please?

Hi,
command I am using is:
jernej@firmwaresvr3:~/resinos/resin-am571x$
./resin-yocto-scripts/build/barys
Regards,
Jernej
On Thu, Jan 26, 2017 at 10:57 AM, Florin Sarbu<EMAIL_ADDRESS>wrote:

What is the command you use to build? Can you paste it here please?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/resin-os/resinos/issues/164#issuecomment-275349399,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACts42Dhuu0YgvwhJtP0SjyAP1Tbno1qks5rWG4BgaJpZM4Ln698
.

Can you also post the git sha of your working tree please?
Be aware that now we specifically moved the repository to https://github.com/resin-os/resin-am571x-evm so that it's clear for which board it's supposed to work

For the meta-resin:
commit 5fee04b864ec31b8f70ec8c13def58c5357eedab
Merge: 00eb85c cb5f4d3
commit 5fee04b864ec31b8f70ec8c13def58c5357eedab
Merge: 00eb85c cb5f4d3
Author: Florin Sarbu<EMAIL_ADDRESS>Date:   Tue Jan 24 12:46:27 2017 +0200
Merge pull request #552 from resin-os/fix_unclosed_socket_warnings

docker-utils.inc: Fix unclosed socket warnings for the master branch

K, and what about the git sha of https://github.com/resin-os/resin-am571x-evm ? This repository should be stable from now on in terms of history

commit 53412a83050d4ccb929ba6d55a0b2eea0c6a60c7
Merge: d25c5c7 d15a670
Author: Florin Sarbu<EMAIL_ADDRESS>Date:   Fri Jan 27 09:11:09 2017 +0200
Merge pull request #4 from resin-os/move_from_am57xx_to_am571x_naming

As we renamed the repository resin-am571x-evm from

That is strange.
Can you try a "./resin-yocto-scripts/build/barys -d" and let me know if it works for you?

Nope, ot doesn't work. I am building on Ubuntu Server 16.04.

You get the same error as before?

ERROR: docker-resin-supervisor-disk-0.0.0-r0 do_compile: Function failed: do_compile (log file is located at /home/jernej/resinos/resin-am571x-evm/build/tmp/work/am57xx_evm-poky-linux-gnueabi/docker-resin-supervisor-disk/0.0.0-r0/temp/log.do_compile.12101)
ERROR: Logfile of failure stored in: /home/jernej/resinos/resin-am571x-evm/build/tmp/work/am57xx_evm-poky-linux-gnueabi/docker-resin-supervisor-disk/0.0.0-r0/temp/log.do_compile.12101
Log data follows:
| DEBUG: Executing shell function do_compile
| Sending build context to Docker daemon 146.4 kB
|
| Step 1 : FROM docker:1.10.3-dind
|  ---> 305c151749f4
| Step 2 : RUN apk add --update bash util-linux && rm -rf /var/cache/apk/*
|  ---> Using cache
|  ---> 178fc6d303e4
| Step 3 : ADD entry.sh /entry.sh
| stat /var/lib/docker/aufs/mnt/c381cb93e6bd245b90d0a92f1006c82e4002757eaad8fdd27de4c34859e63d33/entry.sh: no such file or directory
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_compile (log file is located at /home/jernej/resinos/resin-am571x-evm/build/tmp/work/am57xx_evm-poky-linux-gnueabi/docker-resin-supervisor-disk/0.0.0-r0/temp/log.do_compile.12101)
ERROR: Task (/home/jernej/resinos/resin-am571x-evm/build/../layers/meta-resin/meta-resin-common/recipes-containers/docker-disk/docker-resin-supervisor-disk.bb:do_compile) failed with exit code '1'
NOTE: Tasks Summary: Attempted 3201 tasks of which 2919 didn't need to be rerun and 1 failed.

Whatisi the docker version on your build machine?

Docker version 1.12.1, build 23cf638

What storage driver is docker using on your build machine?

Containers: 10
Running: 0
Paused: 0
Stopped: 10
Images: 14
Server Version: 1.12.1
Storage Driver: aufs
Root Dir: /var/lib/docker/aufs
Backing Filesystem: extfs
Dirs: 37
Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: null host overlay bridge
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: apparmor
Kernel Version: 4.4.0-47-generic
Operating System: Ubuntu 16.04.1 LTS
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 3.859 GiB
Name: firmwaresvr3
ID: 4BI2:QLHB:S2AX:LD5L:PLSC:FYT6:UHEK:LEIO:NUWJ:ZSVV:K5H3:TTGS
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Insecure Registries:
<IP_ADDRESS>/8

Okay, so that is a new error, right? I don't recall you saying that you had this issue before.
Wonder what has changed that made this new error pop out

No, it is not a new error. It always pop up when building from scratch. I have fixed it with adding tmp path in front every entry.sh in Dockerfile.
Other error has something to do with resinhup build race condition, which is now a separate issue. I have fixed with replacing DEPLOY_IMAGE_DIR with IMGDEPLOYDIR.

Yeah, apparently I need to do something similar like I did in https://github.com/resin-os/meta-resin/pull/523/commits/ab0949e4d076b90435470de05002aff6a5d10099 when also using resinHUP. I did not build with resinHUP support when I switched to morty

Hi @jturnsek, if you update manually meta-resin now you should not have the second error anymore.
This update will get merged in soon so you don't have to update meta-resin manually.
As for the first error, I haven't encountered that on my side so not sure what to make of it

Hi. Probably it is a problem with dash vs bash. On similar project we had problems with building Yocto when using default dash shell. Switched to bash and problems disappeared.

Hi @jturnsek it was not the case now. It was actually a bug in our core OS layer which was fixed in the meanwhile.

@agherzan , @jturnsek had 2 issues as he described above. One has been fixed by us, I've told him that the issue on our side has been fixed, and the other is apparently due to dash vs bash on Ubuntu

Were we able to reproduce, @floion ? Sounds like something we would like to fix.

No. I don't have an Ubuntu available to change dash to bash and try to reproduce this

@floion the problem is still there. I was mistaken when changing dash to bash worked for me, because I still had tmp path inside Dockerfile. It must be something with the Ubuntu distribution or docker version related.

@jturnsek can you paste the diff here?

diff --git a/meta-resin-common/recipes-containers/docker-disk/files/Dockerfile b/meta-resin-common/recipes-containers/docker-disk/files/Dockerfile
index b446dc7..bd47d13 100644
--- a/meta-resin-common/recipes-containers/docker-disk/files/Dockerfile
+++ b/meta-resin-common/recipes-containers/docker-disk/files/Dockerfile
@@ -2,8 +2,8 @@ FROM docker:1.10.3-dind
RUN apk add --update bash util-linux && rm -rf /var/cache/apk/*
-ADD entry.sh /entry.sh
+ADD entry.sh /tmp/entry.sh
-RUN chmod a+x /entry.sh
+RUN chmod a+x /tmp/entry.sh
-CMD /entry.sh
+CMD /tmp/entry.sh

Hi @jturnsek . Did you manage to figure out the issue? I know @floion tried to replicate and he could not.

No, I haven't had time to find it. I am on other projects now. My fix with the tmp dir is working and is good enough for me. Probably it is related with my build machine somehow.

Ok @jturnsek . I will close this issue for now but feel free to come back if you have any additional information that would help us to investigate further.


Feature: flag to allow randomly selecting which upstream to forward dns requests to

Please provide a description of this PR:

Introduce DNS_RANDOM_SELECT_UPSTREAM, which will randomly choose the first DNS server to proxy a request to
Fixes #53414

Hi @wtzhang23. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

I would think we can check what coredns does and align with it. No need to provide such flexibility

Not versed in coredns. But a brief scan of the docs suggests they by default randomly iterate by shuffling  the list of nameservers.
Are you suggesting we don't gate this with an environment variable?

There are kinds of policies supported, looks random has some benefits so i would suggest make it default.
The supported policy are:
policy specifies the policy to use for selecting upstream servers. The default is random.

random is a policy that implements random upstream selection.
round_robin is a policy that selects hosts based on round robin ordering.
sequential is a policy that selects hosts based on sequential ordering.

Pushed a commit earlier to make it the default serially. Didn't copy it over for the parallel implementation.

/ok-to-test

@wtzhang23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
cc742b9a7a198799a0f5cb708d61caa809589316
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wtzhang23: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
cc742b9a7a198799a0f5cb708d61caa809589316
link
true
/test lint

release-notes_istio
242ff60456d23bbc3f90407cd3d4e48b9aec493d
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wtzhang23: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
242ff60456d23bbc3f90407cd3d4e48b9aec493d
link
true
/test release-notes

lint_istio
242ff60456d23bbc3f90407cd3d4e48b9aec493d
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


In Memory Vector Store not working [BUG]

Seems like the new docker image is messing up the vector store.

I have noticed this too when you try to upsert from the Plain Text node.

I have seen this too.
I upserted a simple PDF and the In-Memory Vector store.  The error I am getting is:
Received tool input did not match expected schema

Error: Received tool input did not match expected schema
    at DynamicStructuredTool.call (/usr/local/lib/node_modules/flowise/node_modules/@langchain/core/dist/tools.cjs:70:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async /usr/local/lib/node_modules/flowise/node_modules/flowise-components/dist/src/agents.js:315:39
    at async Promise.all (index 0)
    at async AgentExecutor._call (/usr/local/lib/node_modules/flowise/node_modules/flowise-components/dist/src/agents.js:302:30)
    at async AgentExecutor.invoke (/usr/local/lib/node_modules/flowise/node_modules/langchain/dist/chains/base.cjs:58:28)
    at async ConversationalAgent_Agents.run (/usr/local/lib/node_modules/flowise/node_modules/flowise-components/dist/nodes/agents/ConversationalAgent/ConversationalAgent.js:119:19)
    at async utilBuildChatflow (/usr/local/lib/node_modules/flowise/dist/utils/buildChatflow.js:251:15)
    at async createInternalPrediction (/usr/local/lib/node_modules/flowise/dist/controllers/internal-predictions/index.js:7:29)

Actually... The AgentExecutor is not required.  This is working for me.
The problem was that I was using the ConversationalAgent but the ToolAgent works better.

Actually... The AgentExecutor is not required. This is working for me. The problem was that I was using the ConversationalAgent but the ToolAgent works better.

I forgot to mention... I had previously switched over to a Pinecone DB rather than the in-memory Vector Store and was still getting this error message until I switched out the ConversationalAgent for the ToolAgent.  I have not tested this with the In-Memory Vector Store.

I think the team, following the LangChain initiative, is trying to standardize the tools. Some of these tools may become obsolete since they were built just for OpenAI.
Now, in theory, the tools should work for Gemini, Mistral, Clause, and OpenAI, but this is not always the case.

Same issue here, seems like reverting to 1.7.2 helped

Same issue here.
I use: Tool Agent -> Retriever Tool -> In Memory Vector Store
In the chat window and in Langsmith I can see that output is returning empty.
The issue started before updating from 1.7.2 to 1.8.0

I have the same issue when using OpenAI Assistant. The chatbot cannot get the information from in-memory vector store at all. 1.8.0 is not working and I had to revert to 1.7.2

Hi @HenryHengZJ can you have this one (and https://github.com/FlowiseAI/Flowise/discussions/2494 which I think is the same) looked at? I think something broke in 1.8.0 with RAG.

Where can we find information on the RoadMap?
Would it be appropriate to include a Roadmap.md file?
Being new to Flowise, I’m not sure if this bug is something that should be
fixed or if there is a RoadMap direction that would mean that this should
never be fixed and that the preferred approach is X.
Do you have any documentation describing what should eventually be
consolidated based upon the direction of LaingChain?  I’m not even sure
what consolidation Langchain is working on anyway.  If someone wanted to
explain that would be great.  If someone does explain this might be a great
GitHub Discussion.
Thanks for your help!
Eric
On Tue, May 28, 2024 at 11:56 PM automaton82 @.***>
wrote:

Hi @HenryHengZJ https://github.com/HenryHengZJ can you have this one
(and #2494 https://github.com/FlowiseAI/Flowise/discussions/2494 which
I think is the same) looked at? I think something broke in 1.8.0 with RAG.
—
Reply to this email directly, view it on GitHub
https://github.com/FlowiseAI/Flowise/issues/2501#issuecomment-2136466776,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BIBCBWA32KN3NKQTCGNLORLZEVGYDAVCNFSM6AAAAABIMS45GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZWGQ3DMNZXGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

The In-Memory vector store is also not working for me!

I Have this workflow, I saved, upserted and then started a new chat. The model does not recognize any information I gave it in the pdf file.
What can I do to fix this?
Thank you very much!

Will be pushing a new release with this fix soon!

Pushed to 1.8.1!

Thanks!!


Support older versions of OME NGFF

We should be permissive and load versions older than 0.4. Older versions should have identity metadata.

Data is here:
https://github.com/ome/ome-ngff-prototypes
https://idr.github.io/ome-ngff-samples/
A forum question about how to best download it:
https://forum.image.sc/t/download-entire-image-aws-s3-sync-style/76907


Severe quality drop

Describe the bug
Been spending quite a lot of money, playing around with this for a few days and it WAS unbelievably awesome. But now I feel like the quality output dropped by almost 90%. Its nearly unusable. Not sure how you train your models, but something has definitely gone south in just like 2 days.
Link to the Bolt URL that caused the error
https://bolt.new/
Steps to reproduce
No steps other than create a new Next.js app.
Expected behavior
Expecting it to be worth the money
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 56575437,
  "usedJSHeapSize": 52208753,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = jacob-hedengren
Chat ID = 2feea959c18e

Additional context
No response

Refresh your Page after successfully making a few changes. THis helped me tremendously. When the chat window has too much prior information in it, it starts to lose focus.


[v1.14] doc: Migrate to .readthedocs.yaml v2 configuration and upgrade from Python 3.7 to 3.11

Migrate to .readthedocs.yaml configuration file v2 before it becomes necessary to render documentation and upgrade Python from 3.7 to 3.11.
Backport commits from cilium/cilium#27532
Fixes: #26299
doc: Migrate to .readthedocs.yaml configuration file v2

/test-backport-1.14

/test-backport-1.14

/test-backport-1.14


debug for decorator option

debug for decorator option in command "show_urls"

In the for loop of the original code, each iteration overrides the variable decorator, so the problem was that only one url with the specified decorator could be found. The issue is reported here: issues/1773 I changed the variable name so that the variable decorator was not affected, which solved the problem.

Maybe I am missing something but I do not see how this changes anything...
line 122 might scope bleed the "decorator" variable but it's reassigned anyways on line 140....
Otherwise add a test-case for this so we can demonstrate this fixes it.


Error after click Deploy on Azure

After click the Deploy on Azure, the Azure shown the error as below:
There was an error downloading the template from URI 'https://raw.githubusercontent.com/Azure/Cloud-Catana/main/azuredeploy.json'. Ensure that the template is publicly accessible and that the publisher has enabled CORS policy on the endpoint. To deploy this template, download the template manually and paste the contents in the 'Build your own template in the editor' option below.

Hello @cheahengsoon ! I am working on some of the scripts for the deployment and I will update that link. Thank you for letting me know.

Hello @cheahengsoon , it all should be working fine now :)
I fixed it in this commit: https://github.com/Azure/Cloud-Katana/commit/a482dc6a6f80a8585592899be6d2231ddcc84833
All the Deploy Buttons are working fine. Before deployment, please follow the Prepare and Deploy docs:

https://cloud-katana.com/prepare.html
https://cloud-katana.com/deploy/azure/arm.html

Thank you for testing the project :) Let me know if you have any questions.
Enjoy your weekend!


[EI-215] document the IPC known issue

Edge Integrations cannot be used with Internal Page Cache. This PR documents this known issue.

A separate PR exists to add this to the official Pantheon.io docs.


Windows Phone support

Support for windows Phone, maybe you need to re-mapper cordova.file.dataDirectory as described in http://stackoverflow.com/questions/26910891/cordova-file-is-undefined-for-windows-wp8 according file plugin documentation https://github.com/apache/cordova-plugin-file on Windows File System Layout section.

Hi Xinyu,
I'm who contact you recently by e-mail. Could you accept my pull request as soon as possible?
I need of this improvements for go ahead with my project, other hand, will be necessary to register another package on bower for me use.
Thanks for attention.
Regards
Vinciius Dutra

Thx a lot man! That's really helpful.

Somehow I am curious how you get ionic works on window phone :D


Update request: Bazel 6.4.0 → 7.0.0

Package name: Bazel
Latest released version: 7.0.0

Current version on the unstable channel: 6.4.0
Current version on the stable/release channel: 6.4.0

[x] Checked the nixpkgs pull requests

Add a :+1: reaction to issues you find important.

7.0.0rc2 is already in progress at https://github.com/NixOS/nixpkgs/pull/262152


Fix BEM class naming

Class names like 1/2, 50 and 1-of-2 pollute the global namespace.
These classes describe cell widths, so make them be modifiers of the
grid__cell element:

grid__cell--1/2
grid__cell--50
grid__cell--1-of-2

Modifiers should modify a block or an element. They should not be used
by themselves. Consider the markup:

Cell

Cell

Cell

Cell

The wide modifier is being used on a 1/4 block, but the block itself
is not referenced. Instead it's understood that the grid__cell is
1/2 until wide when it becomes 1/4. The classes used in the above
example are disassociative.
Improve this concept:

Cell

Cell

Cell

Cell

This example more accurately expresses the width + responsive logic,
using BEM-like naming.

This PR doesn't include a version of avalanche.min.css because it's unclear what you are using to minify your code. If you'd like I can add a gulpfile and include a minification task with this (or another) PR.

Hi @meowsus. Thanks for this thought-provoking input.
One of the primary motivating factors behind Avalanche was my dissatisfaction with the verbosity of the width class naming of other grids I'd used. Nesting col-8 inside col-9 and ending up with a 50% total width made no sense to me. So I set out to make something that was easily human readable and I think 1/2 grid__cell achieves that.
You are correct when you say width classes aren't blocks but bear in mind that the widths are a utility, not just a modifier. They can be used independently of the grid should the developer wish. There's probably an argument about the grid system not overstepping its boundaries but I've found it useful to have responsive width classes available in other situations outside the grid.
Your point about the global namespace is certainly valid. Avalanche provisions the $av-width-class-namespace variable which will prepend your chosen namespace to all width classes.
Were you to set this variable to #{$av-namespace}__cell--, your desired markup could be largely achieved, as the following example class would be produced:
.grid__cell--1/4--thumb
However, this introduces double modifier classes which aren't really desirable.
In summary, I don't wish to compromise the easily read nature of Avalanche just to more tightly adhere to the principles of BEM.
Thanks very much for your support of Avalanche. Please do let me know if you have any live projects out there using the library.
Ps. I do use Gulp myself for building Avalanche but I don't wish to prescribe a specific tool to people. If they're using Sass then they've likely already got a build process/app of some sort in place which Avalanche can be dropped into.

This all makes sense. Your approach is very well thought out.
The only reason I mentioned Gulp was for contributors, so that they could build and commit the updated, minified CSS file along with their work.
You have a great grid system here. I may end up hard forking this at some point. If I do, I'd love your input.

Here's the hard fork: http://github.com/meowsus/grip

Do let me know if you need any help with anything or if you implement any cool features you think should be included! Thanks for supporting the project.

Of course! And likewise, of course.


Using progress handler with ModernHttpClient

Usage of ModernHttpClient in Refit is straightforward, however I can't see a clean way to attach a progress handler. Could use a delegating message handler and set the progress handler in the SendAsync override (as HttpMessage is available). Any better suggestions?

Using ModernHttpClient isn't supported anymore due to its many known issues.


c7n_mailer - Readme test - Error

Hi!
I am trying to test the c7n-mailer using the example mailer.yml and test-policy.yml in the readme. The Lambda deploys but when it runs I see the following error in the cloud watch logs:
('Unknown resource type', u'sqs')
Followed by:
[ERROR]	2017-11-13T15:02:42.369Z	b27a74a0-c883-11e7-a5ad-53eada5f2f8b	Error starting mailer MailerSqsQueueProcessor().
Error: unicode argument expected, got 'str'
Traceback (most recent call last):
File "/var/task/c7n_mailer/handle.py", line 52, in start_c7n_mailer
mailer_sqs_queue_processor.run(parallel)
File "/var/task/c7n_mailer/sqs_queue_processor.py", line 122, in run
self.process_sqs_messsage(sqs_message)
File "/var/task/c7n_mailer/sqs_queue_processor.py", line 148, in process_sqs_messsage
to_addrs_to_email_messages_map = email_delivery.get_to_addrs_email_messages_map(sqs_message)
File "/var/task/c7n_mailer/email_delivery.py", line 144, in get_to_addrs_email_messages_map
list(to_addrs)
File "/var/task/c7n_mailer/email_delivery.py", line 170, in get_mimetext_message
body = get_rendered_jinja(to_addrs, sqs_message, resources, self.logger)
File "/var/task/c7n_mailer/utils.py", line 62, in get_rendered_jinja
region=sqs_message.get('region', ''))
File "/var/task/jinja2/environment.py", line 1008, in render
return self.environment.handle_exception(exc_info, True)
File "/var/task/jinja2/environment.py", line 780, in handle_exception
reraise(exc_type, exc_value, tb)
File "/var/task/msg-templates/default.j2", line 5, in top-level template code
{{ format_resource(resource, policy['resource']) }}
File "/var/task/c7n_mailer/utils.py", line 272, in resource_format
return "%s" % format_struct(resource)
File "/var/task/c7n_mailer/utils.py", line 115, in format_struct
json.dump(evt, buf, indent=2)
File "/usr/lib64/python2.7/json/init.py", line 190, in dump
fp.write(chunk)
TypeError: unicode argument expected, got 'str'
Please can you help? I've attached my YAML files.
files.zip

UPDATE: I now receive the email, SES was still in Sandbox. However, I still get the above error in cloudwatch

@whit537 is this a py3 related issue?

@kapilt Yes, confirmed broken on master and fixed in https://github.com/capitalone/cloud-custodian/pull/1417. 👍

P.S. I added 9a0aaae852d8b770cdb63832922ec1e28a199309 to #1417 to remove the "Unknown resource type" red herring.

Note that I noticed this error as well in version <IP_ADDRESS>.

Makes sense. <IP_ADDRESS> does not include #1417. Once we cut a new release this should go away, cf. https://github.com/capitalone/cloud-custodian/issues/1817#issuecomment-345963332.


Updating trustlines in testnet wallet results in "freeTFT's to appear as a supported currency.

Search first
No similar issue found
Description
When you go to a newly created test wallet in 3bot on testnet and you update the trustlines a former currency (but no longer supported) appears in the wallet.

Version information
3bot on testnet
Installation method
3bot deployer on testnet
Better to specify the installation method
Steps to reproduce
Create new wallet on testnet 3bot and pdate trustlines.
Traceback/Logs/Alerts
Just visual

What about TFTA?

Only TFT trustline is used now

verified on development branch , only TFT appears now .


Allow multiple joins on same table due to if else statements.

I got two if statements that require the same join table to function. Both can be used without the other. So in both if statements I added a join, to make sure the table is available. This won't result into an error until it's being executed.
My quick fix is making the table the key of the join in the QueryBuilderHandler. I aware that an option would be to add the join when either of the if statements are triggered but that requires an extra if statement. I think it adds extra complexity and would like that the solution lays within the query builder.

Sorry, the purpose is not clear and tests fail.


[sui move] Parity with Move CLI

The sui-move CLI tool is necessary for handling Sui specific aspects of Move

Located in sui/src/bin/sui-move.rs

However, most of the commands are attempting to replicate behavior already present in the move CLI

Located in the move repo language/tools/move-cli/src/lib.rs

In the short term, we should at least be using all of the package commands
In the longer term, it could be nice to handle the sandbox commands (outside of the resource viewing ones)

There are a few different ways of approaching this
A) Manually use the command structs from the move repo. Then call out to the functions as needed. (Custom entry point or driver helper functions might be needed)
B) Expose a bunch of custom entry logic via traits. This is how things are done in the transactional test framework (see language/testing-infra/transactional-test-runner/src/tasks.rs

Priority:

Package commands
Prover integration
Doc gen
code cov

dissassembler
bytecode viewer

remove requirement for --std


Implement tag view

Pull Request: Implement Tag Feature in IncomeExpense Page
Description
This branch implements a tagging feature for the IncomeExpense page with the following functionality:

Add/Delete Tags:

Users can add or delete tags on the IncomeExpense page without losing existing input data.
Data is temporarily stored in the session to preserve user inputs during the tagging process.

Database Integration:

Newly added tags are saved directly to the database.
Selected tags are stored in a Many-to-Many relationship between tags and the IncomeExpense model.

Changes Made

Implemented session-based storage for unsaved data while adding or deleting tags.
Added logic to save new tags to the database.
Established a Many-to-Many relationship to link tags with IncomeExpense records.
Updated the UI to allow users to manage tags.

Testing

Verified that users can add, delete, and save tags without losing other data.
Confirmed that new tags persist in the database.
Tested the Many-to-Many linkage to ensure selected tags are associated with the correct IncomeExpense records.

NOTE: you forgot to do an notify "when delete can't bring back the tag once again".


Use LinkedList instead of manual array re-sizing for better throughput. [LUCENE-9432]

I observed that using LinkedList instead of manually re-sizing and copying SegmentTermEnumFrames improves red-line QPS. Does it make sense to include this?

Migrated from LUCENE-9432 by Mohammad Sadiq (@mohammadsadiq), updated Aug 28 2020
Attachments: LUCENE-9432.patch

I took a quick look at this 3 years on.
I took @mohammadsadiq's patch and applied it to IDVersionSegmentTermsEnum and OrdsSegmentTermsEnum
I then changed the LinkedList to a ArrayDeque.
I ran 2 benchmarks, both with wikibigall and JDK19 on an m5.12xlarge EC2 host.
Test 1:
https://github.com/slow-J/lucene/commit/e2f5e745f6523688f8bdff09e901aa346ac14d57
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                          IntNRQ      411.92      (3.2%)      399.44      (4.1%)   -3.0% ( -10% -    4%) 0.009
                      HighPhrase       39.83      (8.4%)       38.94     (11.2%)   -2.2% ( -20% -   18%) 0.473
                      AndHighMed      123.34      (2.6%)      121.53      (2.1%)   -1.5% (  -6% -    3%) 0.051
                      OrHighHigh       53.33      (5.7%)       52.57      (1.7%)   -1.4% (  -8% -    6%) 0.282
                     AndHighHigh       42.16      (4.3%)       41.69      (1.1%)   -1.1% (  -6% -    4%) 0.260
                    OrNotHighMed      247.13      (3.0%)      244.44      (3.6%)   -1.1% (  -7% -    5%) 0.295
                 MedSloppyPhrase       11.55      (7.5%)       11.44      (6.8%)   -0.9% ( -14% -   14%) 0.681
                       MedPhrase       70.95      (3.5%)       70.35      (3.6%)   -0.8% (  -7% -    6%) 0.451
                HighSloppyPhrase       30.95      (4.9%)       30.75      (4.2%)   -0.6% (  -9% -    8%) 0.653
           BrowseMonthSSDVFacets       21.44     (11.2%)       21.34     (13.2%)   -0.5% ( -22% -   26%) 0.907
       BrowseDayOfYearSSDVFacets       21.19     (15.9%)       21.10     (15.0%)   -0.4% ( -27% -   36%) 0.927
                 LowSloppyPhrase       50.43      (4.3%)       50.21      (4.0%)   -0.4% (  -8% -    8%) 0.738
               HighTermTitleSort      105.90      (1.6%)      105.44      (2.1%)   -0.4% (  -4% -    3%) 0.453
                         Respell       29.29      (1.3%)       29.17      (1.4%)   -0.4% (  -3% -    2%) 0.339
                        PKLookup      173.09      (2.1%)      172.41      (1.8%)   -0.4% (  -4% -    3%) 0.527
                    OrNotHighLow      882.21      (2.7%)      879.44      (3.3%)   -0.3% (  -6% -    5%) 0.744
             MedIntervalsOrdered       28.81      (3.4%)       28.72      (3.4%)   -0.3% (  -6% -    6%) 0.779
                         Prefix3       60.35      (3.3%)       60.18      (3.4%)   -0.3% (  -6% -    6%) 0.800
           BrowseMonthTaxoFacets       13.18      (1.0%)       13.15      (1.5%)   -0.2% (  -2% -    2%) 0.578
                          Fuzzy2       52.06      (1.4%)       51.95      (1.3%)   -0.2% (  -2% -    2%) 0.630
                          Fuzzy1       72.08      (1.1%)       71.93      (1.3%)   -0.2% (  -2% -    2%) 0.595
                      AndHighLow      635.21      (1.9%)      633.97      (2.5%)   -0.2% (  -4% -    4%) 0.785
                        Wildcard       75.55      (2.3%)       75.42      (1.9%)   -0.2% (  -4% -    4%) 0.807
                   OrNotHighHigh      140.51      (4.8%)      140.33      (4.9%)   -0.1% (  -9% -   10%) 0.936
         AndHighMedDayTaxoFacets       44.82      (1.7%)       44.76      (2.3%)   -0.1% (  -4% -    3%) 0.847
           HighTermDayOfYearSort      345.49      (1.7%)      345.27      (1.5%)   -0.1% (  -3% -    3%) 0.898
     BrowseRandomLabelTaxoFacets       11.78      (0.7%)       11.77      (0.8%)   -0.0% (  -1% -    1%) 0.872
                     LowSpanNear       45.65      (1.0%)       45.64      (1.3%)   -0.0% (  -2% -    2%) 0.929
        AndHighHighDayTaxoFacets       15.07      (2.5%)       15.07      (2.8%)   -0.0% (  -5% -    5%) 0.971
            HighTermTitleBDVSort       15.95      (5.4%)       15.95      (5.9%)   -0.0% ( -10% -   11%) 0.987
                     MedSpanNear       10.13      (1.2%)       10.13      (1.2%)   -0.0% (  -2% -    2%) 0.959
            BrowseDateTaxoFacets       13.34      (0.6%)       13.34      (0.9%)   -0.0% (  -1% -    1%) 0.970
                       OrHighMed      220.09      (2.8%)      220.08      (2.2%)   -0.0% (  -4% -    5%) 0.999
            HighIntervalsOrdered        7.05      (2.5%)        7.05      (2.6%)    0.0% (  -4% -    5%) 1.000
               HighTermMonthSort     2701.34      (3.4%)     2701.37      (3.2%)    0.0% (  -6% -    6%) 0.999
             LowIntervalsOrdered       40.23      (2.2%)       40.24      (2.3%)    0.0% (  -4% -    4%) 0.979
            BrowseDateSSDVFacets        4.68      (4.2%)        4.68      (4.3%)    0.0% (  -8% -    8%) 0.984
                   OrHighNotHigh      152.28      (4.4%)      152.38      (4.6%)    0.1% (  -8% -    9%) 0.964
                       OrHighLow      449.79      (2.4%)      450.34      (2.0%)    0.1% (  -4% -    4%) 0.863
                    HighSpanNear        2.83      (1.1%)        2.83      (1.2%)    0.2% (  -2% -    2%) 0.615
                    OrHighNotMed      275.77      (4.2%)      276.49      (4.6%)    0.3% (  -8% -    9%) 0.850
                         LowTerm      489.45      (4.8%)      490.83      (5.5%)    0.3% (  -9% -   11%) 0.863
                    OrHighNotLow      233.89      (4.5%)      234.58      (5.0%)    0.3% (  -8% -   10%) 0.847
                       LowPhrase      272.48      (2.8%)      273.41      (2.4%)    0.3% (  -4% -    5%) 0.679
            MedTermDayTaxoFacets       23.70      (5.1%)       23.82      (5.6%)    0.5% (  -9% -   11%) 0.776
                        HighTerm      258.55      (4.7%)      260.45      (5.8%)    0.7% (  -9% -   11%) 0.661
                         MedTerm      292.19      (4.5%)      294.49      (5.5%)    0.8% (  -8% -   11%) 0.623
       BrowseDayOfYearTaxoFacets       14.07      (0.8%)       14.20      (3.0%)    0.9% (  -2% -    4%) 0.185
                      TermDTSort      119.84      (2.3%)      121.20      (5.8%)    1.1% (  -6% -    9%) 0.418
          OrHighMedDayTaxoFacets       10.59      (3.6%)       10.71      (4.4%)    1.2% (  -6% -    9%) 0.357
     BrowseRandomLabelSSDVFacets       15.07      (2.1%)       15.26      (7.4%)    1.3% (  -8% -   11%) 0.461

Test 2:
I initialised the ArrayDeque with size 256
https://github.com/apache/lucene/commit/9e3aa942ccfd37b06913cc0f63c8bcdb603ad866
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
            MedTermDayTaxoFacets       18.00      (7.4%)       17.41      (7.3%)   -3.3% ( -16% -   12%) 0.154
           BrowseMonthSSDVFacets       22.51     (18.7%)       21.84     (17.3%)   -2.9% ( -32% -   40%) 0.605
               HighTermMonthSort     2764.58      (5.3%)     2730.14      (4.0%)   -1.2% (  -9% -    8%) 0.400
       BrowseDayOfYearTaxoFacets       14.38      (5.1%)       14.22      (3.4%)   -1.2% (  -9% -    7%) 0.406
                   OrHighNotHigh      166.23      (4.9%)      164.37      (6.5%)   -1.1% ( -11% -   10%) 0.542
        AndHighHighDayTaxoFacets        8.90      (3.6%)        8.82      (4.8%)   -0.9% (  -9% -    7%) 0.506
                    OrHighNotLow      261.81      (4.5%)      259.71      (6.2%)   -0.8% ( -10% -   10%) 0.639
                   OrNotHighHigh      168.90      (4.1%)      167.61      (5.4%)   -0.8% (  -9% -    9%) 0.611
          OrHighMedDayTaxoFacets        6.78      (4.1%)        6.73      (6.2%)   -0.8% ( -10% -    9%) 0.648
                       OrHighMed      101.63      (3.7%)      100.94      (3.7%)   -0.7% (  -7% -    6%) 0.558
                      HighPhrase       15.37      (5.3%)       15.27      (4.8%)   -0.6% ( -10% -    9%) 0.690
                      AndHighMed      173.02      (2.1%)      171.94      (2.1%)   -0.6% (  -4% -    3%) 0.350
                    OrHighNotMed      200.49      (4.0%)      199.36      (5.5%)   -0.6% (  -9% -    9%) 0.714
            HighTermTitleBDVSort       14.62      (6.3%)       14.54      (5.6%)   -0.6% ( -11% -   12%) 0.767
                      OrHighHigh       24.46      (4.7%)       24.34      (4.8%)   -0.5% (  -9% -    9%) 0.743
                         Respell       37.98      (3.6%)       37.83      (2.9%)   -0.4% (  -6% -    6%) 0.694
                    OrNotHighMed      229.95      (3.9%)      229.03      (3.9%)   -0.4% (  -7% -    7%) 0.746
                    OrNotHighLow     1055.24      (3.6%)     1051.45      (2.8%)   -0.4% (  -6% -    6%) 0.723
                     AndHighHigh       66.77      (1.7%)       66.53      (1.7%)   -0.4% (  -3% -    3%) 0.509
                 LowSloppyPhrase       43.57      (4.0%)       43.42      (4.4%)   -0.3% (  -8% -    8%) 0.792
                      TermDTSort      244.36      (3.1%)      243.77      (3.8%)   -0.2% (  -6% -    6%) 0.824
                       OrHighLow      227.67      (1.9%)      227.13      (2.6%)   -0.2% (  -4% -    4%) 0.739
                        PKLookup      173.11      (1.6%)      172.74      (2.0%)   -0.2% (  -3% -    3%) 0.705
                         Prefix3       29.77      (3.2%)       29.71      (3.2%)   -0.2% (  -6% -    6%) 0.848
           BrowseMonthTaxoFacets       13.12      (1.1%)       13.10      (1.3%)   -0.2% (  -2% -    2%) 0.617
                     MedSpanNear        7.43      (4.3%)        7.42      (4.1%)   -0.2% (  -8% -    8%) 0.884
                     LowSpanNear        2.87      (0.8%)        2.87      (0.8%)   -0.1% (  -1% -    1%) 0.636
                 MedSloppyPhrase       16.85      (5.2%)       16.83      (6.2%)   -0.1% ( -10% -   11%) 0.947
             MedIntervalsOrdered       13.69      (1.8%)       13.67      (1.8%)   -0.1% (  -3% -    3%) 0.859
         AndHighMedDayTaxoFacets       40.33      (2.4%)       40.30      (2.7%)   -0.1% (  -5% -    5%) 0.912
            BrowseDateSSDVFacets        4.69      (4.8%)        4.69      (5.0%)   -0.1% (  -9% -   10%) 0.961
                          Fuzzy1       68.89      (3.7%)       68.85      (3.1%)   -0.1% (  -6% -    7%) 0.950
             LowIntervalsOrdered       59.74      (3.8%)       59.71      (3.6%)   -0.0% (  -7% -    7%) 0.968
            HighIntervalsOrdered        1.32      (2.1%)        1.32      (2.2%)   -0.0% (  -4% -    4%) 0.948
                          Fuzzy2       61.91      (3.4%)       61.88      (2.7%)   -0.0% (  -5% -    6%) 0.966
                       MedPhrase       36.61      (3.8%)       36.59      (3.6%)   -0.0% (  -7% -    7%) 0.978
                    HighSpanNear        0.92      (2.3%)        0.92      (1.9%)   -0.0% (  -4% -    4%) 0.965
               HighTermTitleSort      100.80      (2.7%)      100.80      (2.5%)   -0.0% (  -5% -    5%) 0.996
                HighSloppyPhrase        8.74      (3.9%)        8.75      (3.8%)    0.1% (  -7% -    8%) 0.943
           HighTermDayOfYearSort      325.58      (2.0%)      326.25      (2.0%)    0.2% (  -3% -    4%) 0.745
                      AndHighLow      571.89      (3.4%)      573.47      (2.8%)    0.3% (  -5% -    6%) 0.777
       BrowseDayOfYearSSDVFacets       20.39     (13.7%)       20.44     (13.9%)    0.3% ( -24% -   32%) 0.949
            BrowseDateTaxoFacets       13.29      (0.8%)       13.33      (0.7%)    0.3% (  -1% -    1%) 0.227
                          IntNRQ      153.91      (2.4%)      154.36      (2.4%)    0.3% (  -4% -    5%) 0.693
     BrowseRandomLabelTaxoFacets       11.77      (1.3%)       11.82      (0.8%)    0.4% (  -1% -    2%) 0.242
                         MedTerm      331.13      (4.8%)      332.84      (7.5%)    0.5% ( -11% -   13%) 0.794
                        Wildcard       98.63      (3.5%)       99.52      (2.5%)    0.9% (  -4% -    7%) 0.350
                       LowPhrase        8.23      (4.5%)        8.30      (3.8%)    0.9% (  -7% -    9%) 0.491
                        HighTerm      242.66      (4.8%)      245.43      (8.2%)    1.1% ( -11% -   14%) 0.592
     BrowseRandomLabelSSDVFacets       15.57      (8.9%)       15.78     (10.5%)    1.3% ( -16% -   22%) 0.664
                         LowTerm      574.42      (5.2%)      583.94      (6.4%)    1.7% (  -9% -   13%) 0.367

I don't think we're seeing a performance gain, but we do still have the performance impact of dealing with the .stream().skip( call to the queue.


Move rollup to peerDependencies and bump to 0.40.2

In latest<EMAIL_ADDRESS>it depends on<EMAIL_ADDRESS>But it seems<EMAIL_ADDRESS>got a bug that failed to compile React (error log attached). But the bug does not repro in<EMAIL_ADDRESS>or<EMAIL_ADDRESS>I would like to bump rollup version from 0.38.0 to 0.40.2. But since<EMAIL_ADDRESS>is depending on a specific version of<EMAIL_ADDRESS>This means rollup is being bundled in rollup-stream and makes bumping rollup version impossible.
I am suggesting to change rollup dependency type from direct into peer dependencies. This will help developers to choose a compatible version of rollup.
Moreover, the latest<EMAIL_ADDRESS>seems working fine with<EMAIL_ADDRESS>all Mocha tests are passed. So I also bumped rollup version from 0.38.0 to 0.40.2.
For your reference, the following is the error from<EMAIL_ADDRESS>TypeError: Cannot read property 'findDeclaration' of undefined
    at callHasEffects (C:\Users\Compulim\Source\Repos\cnr-modern-web-template.buddy\node_modules\rollup\dist\rollup.js:5887:27)
    at CallExpression.hasEffects (C:\Users\Compulim\Source\Repos\cnr-modern-web-template.buddy\node_modules\rollup\dist\rollup.js:5948:10)
    at CallExpression.isUsedByBundle (C:\Users\Compulim\Source\Repos\cnr-modern-web-template.buddy\node_modules\rollup\dist\rollup.js:5959:15)
    at C:\Users\Compulim\Source\Repos\cnr-modern-web-template.buddy\node_modules\rollup\dist\rollup.js:9021:30

@compulim Thanks, but moving Rollup to peerDependencies is an idea I've considered and discarded. The version problem is instead solved by dependency injection courtesy of this pull request to gulp-rollup, as explained in one of the later sections of the README. If you want to use a newer Rollup, there's your solution. In fact, it will work with anything implementing the Rollup API.
I'll bump the version, though.

Bumped. Sorry, I have no business taking so long to get around to these things.


Textual definition update: GO:0004856

GO term ID and label for which you request a definition update

id: GO:0004856
name: D-xylulokinase activity

New proposed definition (genus-differentia pattern, plus additional information if needed)

def: "Catalysis of the reaction: D-xylulose + ATP = D-xylulose 5-phosphate + ADP + H+." [EC:<IP_ADDRESS>, RHEA:10964]

Additional information

It's H+ instead of 2 H+

Thanks!


Live tests

Contains changes for Azure Key Vault Live Tests.

Can one of the admins verify this patch?


Problem with toHtmlSync()

When I call sequentially several times the method toHtmlSync(), sometimes I get unexpected results.
As a proof, the following script:
var output;
for (var i=0;i<1000;i++) {
  output = markdown.toHtmlSync('*sync!*').toString();

  if (output !== '
sync!
\n') {
    console.log('Fails!');
  }
}

Will print 'Fails' several times.
When I parse more complicated strings (for example full files), I got unexpected results almost always:
var output = {};
['README.md', 'History.md', 'Authors.md'].forEach(function(file) {
  output[file] = markdown.toHtmlSync(
    fs.readFileSync(path.join(options.currentPath, file), 'utf8')
  ).toString();
}

I'm currently using Node.js 0.6.4 and robotskirt 0.2.4 under OSX

Thanks for letting me know about this. I ran into this issue when I was initially worked on this project for node 0.4. I take a look at this as soon as possible.

Did you test this with toHtml out of curiosity?

Yes, I tested it and I couldn't reproduce the issue

Commit 6dfc986484ec1bc13f3cc3f15ce0221b571043c1 should fix this.

awesome! I can confirm that it works like a charm

Hi, can you make a new release of the package with this fix please?

I'll publish a package as soon as I can, thanks for letting me know.
On Sun, Jan 22, 2012 at 1:39 PM, Rafael de Oleza <
<EMAIL_ADDRESS>
wrote:

Hi, can you make a new release of the package with this fix please?

Reply to this email directly or view it on GitHub:
https://github.com/benmills/robotskirt/issues/9#issuecomment-3605380


fix: 🐛 remove the wrong concept of blocked_by_parent

the relation created by "requires" means that the step will be refreshed when the required step will be refreshed. (should we change the name?).

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

the relation created by "requires" means that the step will be refreshed when the required step will be refreshed. (should we change the name?).

Yes, I think it could be misunderstood that it has to be ran only when all their parents are finished but that is not true. Maybe triggered_by or something like that could be more explicit.


Prerequisite

What are the prerequisites required in order to run it successfully? Do I need sonar runner installed on my system?
I want to run it along with my gulp build to catch JS Sonar violations beforehand.

The way we use this is just for publishing to SonarQube inside our pipeline. You'll need a SonarQube server running.
https://docs.sonarqube.org/display/SONAR/Installing+the+Server
You can then target that server in the config you provide to gulp-sonar.


[Event Request] Table "Report Selections".OnAfterSetEmailBodyUsageFilters

Table "Report Selections":
procedure SetEmailBodyUsageFilters(ReportUsage: Enum "Report Selection Usage")
begin
Reset();
SetRange(Usage, ReportUsage);
SetRange("Use for Email Body", true);
//>>>>
OnAfterSetEmailBodyUsageFilters(Rec, ReportUsage);
//<<<<

end;
//>>>>
[IntegrationEvent(false, false)]
local procedure OnAfterSetEmailBodyUsageFilters(var ReportSelections: Record "Report Selections"; ReportUsage: Enum "Report Selection Usage")
begin
end;
//<<<<

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


update git submodules to latest version

update versions of gtest and fmt libs

@cieslarmichal Could you please assign this?

Yes, assigned

@cieslarmichal
Could you please check this?
https://github.com/cieslarmichal/faker-cxx/pull/961


no setLineDash method in Context2D?

It seems that this functionality is supported by the package but is not made available in Context2D, interfering with transparently rendering canvases to PDF.

That's true. Pull requests are welcome :)

Implemented in #3169.

@HackbrettXXX
Would you mind publishing a new release with the fix?  This is needed in order to convert canvas in our page.

Working on it ;)


Phonon workflow - generate displacements only in generate_structure()

Before they were generated during initialisation.

I don't have any objections to this change, but I also don't understand the benefit?

It is primarily to simplify debugging when analysing which step consumes how many resources. I was surprised to see how efficient the symmetry analysis is until I realised that it already happens during the initialisation.

I don't have any objections to this change, but I also don't understand the benefit?

It is primarily to simplify debugging when analysing which step consumes how many resources. I was surprised to see how efficient the symmetry analysis is until I realised that it already happens during the initialisation.

👍 sounds good.

With the big disclaimer that I'm probably just totally misunderstanding what's going on here, it seems to me that if it's worth moving self.phonopy.generate_displacements down into PhonopyWorkflow.generate_structures, maybe it's worth moving everything after self.structure = structure in PhonopyWorkflow.__init__ there too?

I would appreciate a response to this too. This is kind of a big problem IMO; Workflow objects return a class instance, and PhonopyWorkflow exposes the public, settable property structure, but if this property is updated there is no change to the downstream functionality:
from ase.build import bulk
from atomistics.workflows import PhonopyWorkflow

workflow = PhonopyWorkflow(structure=bulk("Al", cubic=True))
workflow.structure = bulk("Cu", cubic=True)
structure_dict = workflow.generate_structures()
print(structure_dict["calc_forces"][0].symbols[0])

?? !! ??

I would appreciate a response to this too. This is kind of a big problem IMO; Workflow objects return a class instance, and PhonopyWorkflow exposes the public.

I guess my recommendation would be to make structure a private variable rather than a public one, to follow the general scheme of atomistics to always (1) create the workflow, (2) generate the task_dict , (3) execute it with a calculator and (4) analyse the results. I worked on a first set of specs in https://github.com/pyiron/atomistics/pull/173 but this is still a draft.

I guess my recommendation would be to make structure a private variable rather than a public one,

Yes, that sounds reasonable. The catch is that you then need to be extremely rigorous about making sure that all the class properties are private/read-only, not just structure, and not just for this particular workflow.

to follow the general scheme of atomistics to always (1) create the workflow, (2) generate the task_dict , (3) execute it with a calculator and (4) analyse the results. I worked on a first set of specs in #173 but this is still a draft.

Perhaps I'm just mis-reading you, but it sounds like you are suggesting to impose user behaviour by fiat rather than encode it in the data structures. As long as workflows are class instances, I'm not convinced it's fair to demand that users just remember that they're not allowed to treat them as such. One needs to either adopt a truly functional framework or, as suggested above, be extremely careful to always make sure all the relevant class attributes are locked down hard.
I don't have any changes to request to this PR, but given the problems it highlights so strongly I'm also not comfortable approving it, so you'll need to ping someone else for review if you want more than "comment" status.

Yes, that sounds reasonable. The catch is that you then need to be extremely rigorous about making sure that all the class properties are private/read-only, not just structure, and not just for this particular workflow.

I leave this to a separate pull request - for now I opened an issue https://github.com/pyiron/atomistics/issues/227

Perhaps I'm just mis-reading you, but it sounds like you are suggesting to impose user behaviour by fiat rather than encode it in the data structures. As long as workflows are class instances, I'm not convinced it's fair to demand that users just remember that they're not allowed to treat them as such. One needs to either adopt a truly functional framework or, as suggested above, be extremely careful to always make sure all the relevant class attributes are locked down hard.

I feel we can expect our users to not modifying private variables of the classes in atomistics. Also covered in issues https://github.com/pyiron/atomistics/issues/227 .

I don't have any changes to request to this PR, but given the problems it highlights so strongly I'm also not comfortable approving it, so you'll need to ping someone else for review if you want more than "comment" status.

Comment is fine for me.


[WIP] Event Manager Refactor

Hi everyone,
This is a very quick prototype for #7143. It removes completely the shared event manager, and add the idea of having lazy listener. Actually, I've simplified a lot the interfaces, to remove completely the "laziness": it's now just a detail of implementation for the EventManager, but it's not in the interface anymore.
Basically, the default implementation of EventManager accepts a ListenerPluginManager. The ListenerAggregateInterface now has a simple "attachAggregate" that is static, where you can attach event using a class name:
class UserListenerAggregate implements ListenerAggregateInterface
{
    static public function attachAggregate(EventManagerInterface $eventManager)
    {
        $eventManager->attach('user.create', [static::class, 'sendRegistrationEmail'], 15);
        $eventManager->attach('user.delete', [static::class, 'removeFromNewsletter'], 100);
    }

    // Your methods
}

The listener can have any hard dependencies, but contrary to now, it will be created lazily. Actually, if the event maanger detect a string name, it will mark the listener as "lazy", to indicate that it must fetch it from the plugin manager.
Additionally, the event manager uses generators and listeners are created only when ask, so for instance, if propagation is stopped, any other listener that may need to be created won't be created at all from the plugin manager.
This is still rough and I suspect there are a lot of potential optimizations, but the implementation is simple, remove any reference ot the laziness and is way simpler to undesrtand than ZF2 one.

I've upgraded the implementation to my Service Manager refactor, and I have also implemented the detach method :).

What is the performance of this vs. the previous refactor?  Is there still going to be a far quicker and faster EM ?  :)

Yes it's even faster because it has removed the shared manager and introduced lazy listener. So I expect to to be even faster than faster.
Envoyé de mon iPhone

Le 2 févr. 2015 à 16:09, Mike Willbanks<EMAIL_ADDRESS>a écrit :
What is the performance of this vs. the previous refactor? Is there still going to be a far quicker and faster EM ? :)
—
Reply to this email directly or view it on GitHub.

@mwillbanks , I've done a small benchmark with old and new benchmark, on PHP 5.6 and PHP 7. The benchmark is attaching 20 listeners, detaching one listener, triggering 5 times different events. Please remind also that the main advantage of this refactor is to also have a lazy listeners, which will be HUGE in memory and costly object creation, and will allow to attach much more listeners without impacting performance.
For ZF2 EVM :
PHP 5.6
Bench\EventManagerBenchmark
Method Name         Iterations    Average Time      Ops/second
-----------------  ------------  --------------    -------------
attach20Listeners: [1,000     ] [0.0012481315136] [801.19762]

PHP 7
Bench\EventManagerBenchmark
Method Name         Iterations    Average Time      Ops/second
-----------------  ------------  --------------    -------------
attach20Listeners: [1,000     ] [0.0001788964272] [5,589.82656]

ZF3 Refactor :
PHP 5.6
Method Name         Iterations    Average Time      Ops/second
-----------------  ------------  --------------    -------------
attach20Listeners: [1,000     ] [0.0002542481422] [3,933.16542]

PHP 7
Method Name         Iterations    Average Time      Ops/second
-----------------  ------------  --------------    -------------
attach20Listeners: [1,000     ] [0.0000408854485] [24,458.57971]

@bakura10 bloody hell, that's a really nice performance boost :+1:

Being able to attach many listeners without having to have the cost on each request is even better, actually. In my app, I didn't do a proper benchmark, but it incurs at least 5-10 ms overhead on each request, while all the listeners are only executed like on 0,1% of each request :/. With this refactor, no issue :D.

@Ocramius wanted me to separate attach and trigger. Here are the results:
ZF2 EVM
PHP 5.6
Bench\EventManagerBenchmark
Method Name          Iterations    Average Time      Ops/second
------------------  ------------  --------------    -------------
attach20Listeners : [1,000     ] [0.0005693485737] [1,756.39326]
trigger20Listeners: [1,000     ] [0.0010452888012] [956.67341]

PHP 7
Bench\EventManagerBenchmark
Method Name          Iterations    Average Time      Ops/second
------------------  ------------  --------------    -------------
attach20Listeners : [1,000     ] [0.0000875046253] [11,427.96734]
trigger20Listeners: [1,000     ] [0.0001518340111] [6,586.13965]

ZF3 EVM
PHP 5.6
Bench\EventManagerBenchmark
Method Name          Iterations    Average Time      Ops/second
------------------  ------------  --------------    -------------
attach20Listeners : [1,000     ] [0.0001252155304] [7,986.22980]
trigger20Listeners: [1,000     ] [0.0002773256302] [3,605.86939]

PHP 7
Bench\EventManagerBenchmark
Method Name          Iterations    Average Time      Ops/second
------------------  ------------  --------------    -------------
attach20Listeners : [1,000     ] [0.0000128707886] [77,695.31713]
trigger20Listeners: [1,000     ] [0.0000429670811] [23,273.63123]

@Ocramius expressed the need on identifiers. I'm personally strongly against identifiers considering the hard life it caused to me debugging nasty things (as I said in the issue, attaching for a given service identifier, then moving the code that triggers into another service, and forgetting to change the identifier in the attach... identifiers are way to fragile).
However I could understand the need to scope even more which listeners are called, but I want this to be just optional (use it if you need it, but for most people they won't use it because it's overkill for most cases). The idea is to have an optional parameter when attaching and triggering:
$evm->attach('foo', $callable, $priority, ['identifier1', 'identifier2']);
$evm->trigger('foo', $event, ['identifier3']); // won't execute any listener

I'm just want to make sure that this does not add too much performance overhead because of having to check the listeners.
What do you think?

identifiers are way to fragile

Identifiers are routing: wrong routing is still wrong routing :-)

I could understand the need to scope even more which listeners are called

My problem is not to scope event listeners, but to still aggregate in the same way the SharedEventManager does it.
The typical use-case is:
$shippingProvider1 = new UpsShippingProvider($evm1);
$shippingProvider2 = new DhlShippingProvider($evm2);

// triggering shipping provider 1 payment logic and product inventory 1 availability update
$shippingProvider1->ship($order1);
// triggering shipping provider 2 payment logic and product inventory 1 availability update
$shippingProvider2->ship($order2);

As you can see, there is a shared listener involved, but the event triggering is context-specific, which means that $evm1 !== $evm2.
Nothing to do with identifiers.

@Ocramius
What if you have two or maybe three different events? It makes sense? It would be up to the provider to trigger the correct events.
// $evm1 has listeners attached to ship, ship.dhl and ship.ups
$shippingProvider1 = new UpsShippingProvider($evm1);
$shippingProvider2 = new DhlShippingProvider($evm1);

// triggers: ship and ship.ups events
$shippingProvider1->ship($order1);
// triggers: ship and ship.dhl events
$shippingProvider2->ship($order2);

What if you have two or maybe three different events?

The events are the same: that's where your decoupling/abstraction actually lives.

I see Ocramius, it makes sense.Thanks! :]

First, I personally find this is a wrong usage of event manager. Updating an availability is something critical. What if a listener stop propagation before it reaches the availability service? I really think that for that kind of use case, you should have a coordinator service that explicitly propagate the various steps (attaching to ship, updating stock...), only non critical things like sending confirmation emails should be handled using the EVM, as they are the consequence of the full process. I tend to remove having a lot of related logic using only events. So much can happen that I find it quite fragile.
I can see the use case though, but still, I don't think that the event manager should have so many complexity by default. This is a rather extreme use case. I REALLY REALLY want to have something that is intuitive for most cases. In my code, 100% of the time (and I know I'm not the only one), I'm only using the shared event manager because I don't have any other way, but what I'm only interesting is triggering an event and have all the listeners do something. Period. And from what I've read, it seems a lot of people are doing like me.
The Shared Event manager with identifiers is the most confusing stuff. Why can't we remove the shared event manager and offer a simpler pattern by default, if what I'm doing is ALWAYS retrieving the shared event manager?
To achieve your use case, we could add some kind of ComposableEventManager, where the event maanger would compose another (main) event manager, and have its own set of listeners, so you could achieve kind of the same result (but with the advantage of keeping the exact same interface as event manager, and don't introduce the shared event manager:
class ComposableEventManager extends EventManager
{
    private $eventManager;

    public function __construct(EventManager $eventManager)
    {
         $this->eventManager = $eventManager;
    }

    public function getListeners($eventName)
    {
        // would merge the local listeners and the one from the composed event manager
    }
}

But once again, I'm 100% sure that typical use case does not need all this complexity. What you want is typically: attach listeners, trigger, make sure all listeners execute.
Regarding the identifiers, I'm sorry, but this is not really "routing". Really, this IS REALLY FRAGILE. Let's take an example: a third-party module triggers an event in ServiceA. This service therefore adds the "ServiceA" identifier to its event manager. The ServiceA could even be final.
You listen to the service manager with ServiceA identifier. Then this module moves the trigger logic to ServiceB (it would not even be a BC break from the module point of view, it has only moved a part of the logic, that could even reside in a private method, to another service). No BC break in the module, and boom... your app break. Not only does it break, but it breaks completely silently: the listener will never be executed because of the identifier. If this is non critical piece like emails, it could even break silently for months without you noticing it. And no unit test could find this. And exactly what happen recently to me (except that it was in a code of mine instead of a module).
This is why identifiers MUST be removed. They caused bugs that are nearly impossible to track.

What you want can be achieved with the "identifiers" (or more exactly, "tagged"). For instance, Ups will trigger:
$this->eventManager->trigger('product.ship', $event, ['ups']);
$this->eventManager->trigger('inventory.update', $event);
$this->eventManager->trigger('product_sent.email', $event);

For inventory.update and product_sent.email, you will have listeners to it, for product.ship, you may have a listener like this:
$this->eventManager->attach('product.ship', $callable, $priority, ['ups']);

The difference in "those" identifiers is that they are part of the trigger and attaching signature. If properly unit-tested, changing the identifier here IS a BC break and can be spotted. Even if you move the trigger code from one service to another, it's still triggering for the given identifier in the parameter (this is not the case for identifiers tied to an event maanger.

probably a stupid question but, since the event name is namespaced, how is:
$this->eventManager->trigger('product.ship', $event, ['ups']);
[...]
$this->eventManager->attach('product.ship', $callable, $priority, ['ups']);

different from
$this->eventManager->trigger('ups.product.ship', $event);
[...]
$this->eventManager->attach('ups.product.ship', $callable, $priority);

?
Both the trigger the listener have to be aware of the context so, as far as I understand, the main difference with the current identifier system is that the identifiers are defined at EventManager instantiation, and then specified by the listeners; the trigger on the other hand has no such context awareness.
But then again, sometimes the Event::$target, which should represent the context of the trigger, is changed. Sometimes the whole event instance is instantiated from scratch for an event, while sometimes the same event instance is used throughout different triggers, and it's state is changed instead. What I would like is a stricter convention about all this.
Someone suggested immutable events in the other thread (#5693), should this option be just disregarded? FWIW, I think there is value in it.
Anyway, shouldn't at least Event::$target be immutable? Shouldn't it be the only entry point to the event context? isn't the event itself just a bag that carries a context throughout the cycle of a set of listeners?
Honourable example: using two different DISPATCH in Zend\Mvc, changing Event::$target from Application the the controller instance. Such context change drove me mental a number of times. These are basically two different event cycles, but using the same manager and event instances, and using the results in a different way (i.e. using both the results queue and Event::$result, with no clear clue for the listener on what is used first).
Furthermore, why should I be able to grab an event instance outside a trigger cycle and fiddle with it?
Am I missing some compelling point for this behaviour?
The way I see it is that a new event instance should created each time a trigger is invoked.
To instantiate and run listeners only in some contexts, an assertion callback could be run on the event target before even instantiating the listener, i.e.:
$userListener = function($event)
{
    // do something related to UserController only, referenced in $event->getTarget()
}

$targetAssertion = function($target) {
    return $target instanceof UserController;
}
$evm->attach('dispatch', $userListener, $targetAssertion);

does this make any sense?

@bakura10 The static ListenerAggregate::attachAggregate method still has performance impact. The listener aggregate needs to be autoloaded.
I use an event bus implementation (comparable with an application wide EM) which uses a configurable event routing map, something like:
//config/autoload/event_bus.config.php
return [
  'event_bus' => [
    'event_routing_map' => [
      My\Event::class => [
        My\Listener1::class,
        My\Listener2::class,
      ]
    ]
  ]
];

Would it make sense to support something similar with the refactored EM?

I honestly don't think that the auto loading will have many impact on performance, or so negligible you'll need hundreds of listeners to start having an impact.
I'm not against the idea but the event manager should stay simple. But that is an interesting idea (except that it is even more config arrays...).
I'm not sure how your thing would work with wildcard listeners though.
Envoyé de mon iPhone

Le 18 mai 2015 à 17:51, Alexander Miertsch<EMAIL_ADDRESS>a écrit :
@bakura10 The static ListenerAggregate::attachAggregate method still has performance impact. The listener aggregate needs to be autoloaded.
I use an event bus implementation (comparable with an application wide EM) which uses a configurable event routing map, something like:
//config/autoload/event_bus.config.php
return [
'event_bus' => [
'event_routing_map' => [
My\Event::class => [
My\Listener1::class,
My\Listener2::class,
]
]
]
];
Would it make sense to support something similar with the refactored EM?
—
Reply to this email directly or view it on GitHub.

In a CQRS + ES architecture  (the origin of the idea) you have a lot of event listeners :-), but that can not be directly mapped to the usage of the EM.

that it is even more config arrays...).
I consider this a good thing :-). That's the way to set up things in ZF2, so why not use it for listeners too?

I'm not sure how your thing would work with wildcard listeners though.
I have a special regex event router to handle wildcards, but normally I favour explicit event routing to keep things simple :-)

I'm definitely not against introducing some event bus/CQRS into it if it makes sense or if this is a better way to use event manager.
We just need to see how it could work internally in the framework.
Anyway I'll soon move this PR to the event manager component so things can be discussed.
Envoyé de mon iPhone

Le 18 mai 2015 à 18:37, Alexander Miertsch<EMAIL_ADDRESS>a écrit :
In a CQRS + ES architecture (the origin of the idea) you have a lot of event listeners :-), but that can not be directly mapped to the usage of the EM.
that it is even more config arrays...).
I consider this a good thing :-). That's the way to set up things in ZF2, so why not use it for listeners too?
I'm not sure how your thing would work with wildcard listeners though.
I have a special regex event router to handle wildcards, but normally I favour explicit event routing to keep things simple :-)
—
Reply to this email directly or view it on GitHub.

Please keep in mind that an event-sourced architecture is geared towards multiple disparate processes reacting to domain events, not necessarily on the same box or application.  Framework events, on the other hand, occur and are reacted to in the same process.  So, there must be flexibility for both implementations.  i.e. UserHasSubscribed is not the same as ModuleLoaded.

@texdc :+1: I totally agree and would never say something different. But I think configurable listeners based on a routing map can work for the EM too and align the set up with the rest of the framework.
Btw. support for immutable events (like mentioned by @stefanotorresi)  - maybe by use either EventInterface or ImmutableEventInterface (like with \DateTime and \DateTimeImmutable) - would allow to use the EM as a DomainEventDispatcher ... But I'm just thinking loud. Maybe it's better to keep both concepts separate.

Please discuss about this there now: https://github.com/zendframework/zend-eventmanager/pull/2
I'm closing :).


feature: CONTACT US

hi everyone ,i start to change design,but my internet i aufull,so if someone can his comment do,or change farther or partisipate it ll be hightly appreshiated)))

@TatsianaRud can you please send the EmailJS login details on Slack so I can edit the settings on the dashboard?

try using this code:
<script>
import emailjs from "@emailjs/browser";
export default {
  name: "ContactUs",
  data() {
    return {
      name: "",
      email: "",
      message: "",
    };
  },
  methods: {
    async sendEmail() {
      try {
        const emailParams = {
          name: this.name,
          email: this.email,
          message: this.message,
        };

        console.log(emailParams);
        emailjs.send(
          "service_0xqmyuc",
          "template_zxk95fi",
          emailParams,
          "user_bqOiafJ3RyGJLlBUxuy6A"
        );
        alert("Message sent successfully!");
      } catch (error) {
        console.log({ error });
      }
    },
  },
};
</script>

rewrote the code, please check

looks good, I received a message :)
I would also add notification like in login page,
and make the form a bit more compact :)
anyway this PR could be merged and the small amendments could be added later

ok I will add the notification too

@katsmamina done


Typescript definition for MultiPickerMaterialDialog is incorrect

The onOk method on MultiPickerMaterialDialog should really take { selectedItems: PickerItem[] }  as an argument. You can see it by looking at the code examples.

Fixed in v0.7.5


foreman start not working on windows

When starting foreman on windows I get this error:
09:57:04 web.1    | started with pid 5296
09:57:04 client.1 | started with pid 17184
09:57:06 client.1 | (in D:/project/src)
09:57:14 web.1    | => Booting Puma
09:57:14 web.1    | => Rails 5.0.2 application starting in development on http://localhost:3000
09:57:14 web.1    | => Run rails server -h for more startup options
09:57:14 web.1    | *** SIGUSR2 not implemented, signal based restart unavailable!
09:57:14 web.1    | *** SIGUSR1 not implemented, signal based restart unavailable!
09:57:14 web.1    | *** SIGHUP not implemented, signal based logs reopening unavailable!
09:57:14 web.1    | Puma starting in single mode...
09:57:14 web.1    | * Version 3.8.0 (ruby 2.3.3-p222), codename: Sassy Salamander
09:57:14 web.1    | * Min threads: 5, max threads: 5
09:57:14 web.1    | * Environment: development
09:57:14 web.1    | * Listening on tcp://localhost:3000
09:57:14 web.1    | Use Ctrl-C to stop
09:57:15 client.1 | stdout is not a tty
09:57:16 client.1 | exited with code 1
09:57:16 system   | sending SIGKILL to all processes
09:57:16 system   | sending SIGKILL to web.1 at pid 5296
09:57:16 web.1    | exited with code 0

If foreman doesn't work on Windows, please google around for an alternative. Manually, you can just run the individual commands in separate command shells.


PR Templet

its good to have an good PR templet
Look  EddieJaoudeCommunity/template fore more info.

Hey, i must add a PR template as soon as possible! Thanks for remenbering me!

Hey, i must add a PR template as soon as possible! Thanks for remenbering me!


added docker-compose setup for local development

added docker-compose setup for local development
updated readme

Thank you for your PR and sorry for my late reply.
I am just not sure if this is really necessary, as this docker-compose thing is related to Postgrest side. It is only useful if we use it in the testing pipeline.

I was trying to contribute to postgrest-py, Setting up local dev environment for development and testing was little bit hard. So I prepared this docker-compose setup as a first thing. It becomes so much easier to getstarted without fiddling around postgres and posgrest setup. I think we can also use this for running tests.

@sureshdsk Thank you for your contribution. I think it's OK to merge this now.