upload: always call Close() in early returns

Codecov Report

Merging #632 (dd3712f) into master (1bd0e32) will increase coverage by 0.16%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
+ Coverage   52.26%   52.42%   +0.16%
==========================================
  Files          95       95
  Lines        3293     3296       +3
==========================================
+ Hits         1721     1728       +7
+ Misses       1211     1210       -1
+ Partials      361      358       -3

Impacted Files
Coverage Δ

pkg/upload/sftp.go
67.56% <66.66%> (+2.73%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bd0e32...dd3712f. Read the comment docs.


Add Route library (Router #1838)

Rename URL Scheme section to App Routing
Add Router lib (#1838)
Move Marshroute lib to App Routing section
Move SwiftRouter to App Routing section

          2 Warnings

:warning:
Too many changes (when adding, please keep it to one project per Pull Request)

:warning:
Found 3 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

854
301
https://github.com/terflogag/FacebookImagePicker redirects tohttps://github.com/floriangbh/FacebookImagePicker

1355
301
https://github.com/SwiftOnEdge/Edge redirects tohttps://github.com/skylab-inc/Edge

2388
301
https://github.com/terflogag/OpenSourceController redirects tohttps://github.com/floriangbh/OpenSourceController

  Generated by :no_entry_sign: Danger

Thank you for these issue fixes. Please also add this to the contents section

Update contents section.

Moved App Routing section alphabetically.

Thank you!


Spurious "multiple rules generate" error

Hi,
Starting with #2358 building postgres with meson and ninja from git triggers:
build.ninja:5628: multiple rules generate src/backend

The line number looks spurious - it's an empty line and neither of the neighboring lines actually generate "src/backend".
Repro:
mkdir /tmp/repro
cd  /tmp/repro

git clone https://github.com/ninja-build/ninja.git
git clone https://github.com/mesonbuild/meson.git
git clone https://github.com/postgres/postgres.git

cd ninja
git co 4d38849501ca09c2dcd9e778b59f9a4ec32180dd
./configure.py --bootstrap

cd ../postgres
../meson/meson.py setup build

../ninja/ninja -C build/ -d stats
ninja: Entering directory `build/'
ninja: error: build.ninja:5628: multiple rules generate src/backend

CC: @digit-google
Greetings,
Andres

Thank you for the reproduction case! I could take a look at the generated build.ninja file.
Good news, this should be fixed once PR #2398 is submitted.
The error comes from the line above that defines a build statement for the following target: src/backend/postgres_lib.a.p/.._timezone_pgtz.c.o. Due to a bug introduced in #2358, and fixed in #2398, this incorrectly canonicalized the path to src/backend.

Thanks, can confirm that this fixed the issue for me!


long as parameter causes a ArrayIndexOutOfBoundsException

Describe the bug
On my M1 using graal 17 an ArrayIndexOutOfBoundsException is thrown when using a long as a parameter. It works if the long is in an array, and an int also works instead of the long.
From digging around in the debugger the failure seems to be caused the by Long.longValue() method being parsed for accesses instead of the 'test' method, which means the amount of access arguments is wrong.
Stacktrace is:
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
	at tornado.runtime@0.15/uk.ac.manchester.tornado.runtime.graph.TornadoGraphBuilder.buildGraph(TornadoGraphBuilder.java:131)
	at tornado.runtime@0.15/uk.ac.manchester.tornado.runtime.tasks.TornadoTaskGraph.compile(TornadoTaskGraph.java:628)
	at tornado.runtime@0.15/uk.ac.manchester.tornado.runtime.tasks.TornadoTaskGraph.compileToTornadoVMBytecode(TornadoTaskGraph.java:697)
	at tornado.runtime@0.15/uk.ac.manchester.tornado.runtime.tasks.TornadoTaskGraph.scheduleInner(TornadoTaskGraph.java:793)
	at tornado.runtime@0.15/uk.ac.manchester.tornado.runtime.tasks.TornadoTaskGraph.schedule(TornadoTaskGraph.java:1203)
	at tornado.api@0.15/uk.ac.manchester.tornado.api.TaskGraph.execute(TaskGraph.java:782)
	at tornado.api@0.15/uk.ac.manchester.tornado.api.ImmutableTaskGraph.execute(ImmutableTaskGraph.java:73)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at tornado.api@0.15/uk.ac.manchester.tornado.api.TornadoExecutionPlan$TornadoExecutor.execute(TornadoExecutionPlan.java:297)
	at tornado.api@0.15/uk.ac.manchester.tornado.api.TornadoExecutionPlan.execute(TornadoExecutionPlan.java:126)
	at games.Repro.main(Repro.java:47)

How To Reproduce

public class Repro {

    public static void test(
                            int size,
                            final long[] seeds,
                            //final long[] enh, //This works
                            long enh, //This fails
                            final int[] result1) {

        for (@Parallel int i = 0; i < size; i++) {
            //long seed = seeds[i%seeds.length] + enh[0];
            long seed = seeds[i%seeds.length] + enh;
            result1[i] = (int)seed%Integer.MAX_VALUE;
        }
    }

    public static void main(String[] args) {

        int[] r1 = new int[1];

        long[] seeds = new long[] {3};

        //long[] enh = new long[] {10};
        long enh = 10L;

        int size = 1;

        TaskGraph s0 = new TaskGraph("s0")
                .transferToDevice(DataTransferMode.FIRST_EXECUTION,size,seeds,enh)
                .task("t0", Repro::test,
                        size,
                        seeds,
                        enh,
                        r1)
                .transferToHost(DataTransferMode.EVERY_EXECUTION,r1);

        ImmutableTaskGraph immutableTaskGraph = s0.snapshot();
        TornadoExecutionPlan executorPlan = new TornadoExecutionPlan(immutableTaskGraph);
        executorPlan.execute();

        System.out.println("Res: "+r1[0]);
    }

}

Expected behavior
Expectation was that the program should work (output "Res: 13"), or a more descriptive error if a long can not be used like this.
Computing system setup (please complete the following information):

OS: macOs Ventura 13.1, M1 mac (FVFGK4B9Q05N)
OpenCL C 1.2,
TornadoVM commit id: 0.15 tag 94f2fca

Additional context

Thank you for the report. This is a bug. Tornado should be able to compile and run this code. We will look into it.

I am working on this issue, we will patch a fix soon.

A patch is implemented and a PR is created in the internal repository so that to test it on our Jenkins CI pipeline. The PR is under review. We will update soon.

The patch has been merged in the develop and master branches. I will close this issue. @IIlllII please try it, and feel free to re-open it if your example is still failing in your system.


[UIKit] Map tab: Bookmark icon is not changed colour when the user clicks to save the object to Favourites

Env:
iPhone 8 (15.5)
build: 1008
STR:
Run Radzima app > Select map tab > Select any object > Click 'Bookmark' icon
Actual result: The colour is not changed to green but object is added to Favourites
Expected result: The colour is changed to green

@vitali5070 It's most likely because of changed bookmark images. Can you take a look?
Here's the video for the map bottom sheet.
https://user-images.githubusercontent.com/7137128/180482895-a51ec935-5ba4-4071-9cd8-be7c832d7f0e.mov
Please change bookmark icon for collection view as well.

Verified on UIKit iOS (build 1049, iPhone X 15.5)


Add option to set cwd

The options are just passed into child_process.exec, so you can definitely set cwd.


Deprecate Format docs

This PR is to add note to format docs about the usage with new beta.2+

cc: @droot for awareness

This one changes docs. So we need @droot 's approval.


Add login functionality to Make analysis public pop up

Allow for user to click on and log into clinEpi from the 'Make analysis public" pop up warning

functionality has been tested and has passed QA


GetUserAvailability detailedMerged and freeBusyMerged results are same

Hi,
There are 2 users who have a meeting from 8-8.30 , 8.45-9.15, 10-11 in their calendar.
In Get User Availability call for this user with requestedView as DetailedMerged or FreeBusyMerged, results are same.
Could you please let me know what should be the behaviour.
Thanks and Regards,
Rama.

Please also post some code snippet that triggers the problem.

Detailed Merged Request
Message:
jake_pe@pihub.onmicrosoft.com0002:00:0013Sunday002:00:00110Sundayvictorsm@pihub.onmicrosoft.comRequiredfalsejoe_girard_sm@pihub.onmicrosoft.comOptionalfalse2015-09-30T00:00:002015-10-01T00:00:00150DetailedMerged

Message:
NoErrorFreeBusyMerged00000110002015-09-30T13:00:002015-09-30T13:30:00Tentative2015-09-30T13:45:002015-09-30T14:15:00Tentative2015-09-30T15:00:002015-09-30T16:00:00Tentative-330000:00:0000Sunday000:00:0000SundayMonday Tuesday Wednesday Thursday Friday4801020NoErrorFreeBusyMerged00000220002015-09-30T13:00:002015-09-30T13:30:00Busy2015-09-30T13:45:002015-09-30T14:15:00Busy2015-09-30T15:00:002015-09-30T16:00:00Busy360002:00:00111Sunday-6002:00:0023SundayMonday Tuesday Wednesday Thursday Friday4801020

FreeBusyMerged
Message:
jake_pe@pihub.onmicrosoft.com0002:00:0013Sunday002:00:00110Sundayvictorsm@pihub.onmicrosoft.comRequiredfalsejoe_girard_sm@pihub.onmicrosoft.comOptionalfalse2015-09-30T00:00:002015-10-01T00:00:00150FreeBusyMerged

Message:
NoErrorFreeBusyMerged00000110002015-09-30T13:00:002015-09-30T13:30:00Tentative2015-09-30T13:45:002015-09-30T14:15:00Tentative2015-09-30T15:00:002015-09-30T16:00:00Tentative-330000:00:0000Sunday000:00:0000SundayMonday Tuesday Wednesday Thursday Friday4801020NoErrorFreeBusyMerged00000220002015-09-30T13:00:002015-09-30T13:30:00Busy2015-09-30T13:45:002015-09-30T14:15:00Busy2015-09-30T15:00:002015-09-30T16:00:00Busy360002:00:00111Sunday-6002:00:0023SundayMonday Tuesday Wednesday Thursday Friday4801020


Record non-https URL in log

So that we know what url causes it.

Force-pushed to merge this commit into dev instead.


Add new (pun intented) New Relic plugin

There is already one under code analysis.  How does this one compare? Why would users choose it over the existing one?

I can not say for sure, but maybe the jippi/cakephp-newrelic plugin goal is to enable the whole New Relic on the application, which is commonly done by installing the New Relic agent, as defined in:
https://docs.newrelic.com/docs/agents/php-agent/installation/php-agent-installation-overview
My plugin goal is to enable two features: name transactions and browser timing, as defined in:
https://docs.newrelic.com/docs/agents/php-agent/frameworks-libraries/php-frameworks-integrating-support-new-relic
CakePHP 3 does not support these features by default (as defined in the link above) so I created this plugin to enable.
Moreover, in my opinion, New Relic is not a code analysis tool, but a Application Performance Monitor (APM). Code Analysis are tools for checking coding standards, security issues, etc. I would keep both plugins in the APM category.

I dont think we need a new category, it would very well fit into
https://github.com/FriendsOfCake/awesome-cakephp#code-analysis

Ok, I agree on adding new APM category (moving the other one under this) and I would like to see this plugin added to the awesome list but we need to figure a way to differentiate both on the list in order to help users find/use the right one and not waste time with both.
What do others think?

@jippi can you confirm if your jibbi/cakephp-newrelic plugin goal? I took a look in your code and looks like it's about enabling New Relic, including the application name, starting transactions, custom traces, and so on. I created another plugin that justs enable the name transaction and browser timing features, for a already running New Relic PHP agent, and we are trying to get clear the differences, to help people to choose the right one.
@jadb maybe something like this?
brunitto/cakephp-new-relic - Enables name transaction and browser timing for a CakePHP 3 application using the New Relic PHP agent.
jippi/cakephp-newrelic - Enables New Relic for a CakePHP application using the New Relic extension (without the New Relic PHP agent)
(I am not sure if jippi's plugin works without the New Relic PHP agent)

@brunitto yes. Let's wait for @jippi's reply first though.

@jadb @brunitto My plugin does naming and full integration with the NR SDK and Agent - it aims to (and does) use all facets of the NR SDK inside CakePHP - covering both CLI and WEB naming, exception sending, notices and (custom) timing etc
There seem to be a full overlap between the two plugins
That said, the Filter for NameTransaction is pretty neat, though a bit over-simple for big live apps that need to be more flexible that a pure /controller/action naming - something my plugin does not have issues with
Mine also cover CLI naming, and wrapping all NR SDK methods in a class, allowing less extension_loaded calls in user-land code (you can "use" the full SDK even without NR installed, for a more seamless integration)

Got it
I think that it's a good idea to keep both, as some people might just need to enable name transactions and browser timing, for smaller and simpler web applications - like I needed. I believe that my plugin has a small footprint, as the New Relic agent is already installed, and all you got to do is add the Dispatcher Filter and call 2 helper methods. In the other side, your plugin is more complete and needs a bit more configuration, and will work better for web applications that need complete New Relic integration.
We can go with something like:
brunitto/cakephp-new-relic - A simple plugin that enables name transaction and browser timing for a CakePHP 3 application using using the New Relic PHP agent.
jippi/cakephp-newrelic - A complete plugin that enables full New Relic integration for a CakePHP application, including CLI naming, exceptions sending, custom timings, etc. It does not depends on New Relic agent.

Am good with the proposed suggestions. /cc @jippi @dereuromark @ADmad @lorenzo

I do think code analysis and monitoring are two really different things. so :+1: for moving one/both of them.

The description part of each should clarify that IMO. So if that is fixed up this is good to go.

My plugin doesn't add any overhead unless you use a feature - so don't see the need for two, but in the end, i don't care
I fail to see any difference between the two in performance or usability.
Mine is more flexible, and fully fledged, and also directly use the NewRelic PHP SDK

Just updated the README file with the proposed updates and pushed.

NewRelic plugin - A complete plugin that enables full New Relic integration for a CakePHP application, including CLI naming, exceptions sending, custom timings, etc. It does not depends on New Relic agent.

Brunitto/NewRelic plugin - A simple plugin that enables just name transaction and browser timing for a CakePHP 3 application using the New Relic PHP agent.

Issues :-(

Links

http://forum.cakephp.ir/ getaddrinfo: Name or service not known

This looks almost exactly like mine O.o

This looks almost exactly like mine but for 3.x. @brunitto would you be interested in working together to merge in some of my features and I can deprecate mine in favor of yours? Or something? Don't want to pollute the space..

Sure, I will give your plugin a look an then we can merge. My e-mail is<EMAIL_ADDRESS>send me an e-mail and we start talking about it.

@jeremyharris @brunitto why not merge all of them? they all seem to have a huge overlap and feature set :)

@jippi I'm down with that


Add and use QuantumState class

Fixes #2904.

@viathor I've addressed your comments. I've also marked this PR ready for review (it's no longer a draft).

Sorry for letting this sit for so long @kevinsung  - I'll have a look tomorrow - can you update the branch?

@balopat no worries. I've updated the branch.

Automerge cancelled: A required status check is not present.
Missing statuses: ['cla/google']

cla cirqbot issue surfaces again: https://github.com/quantumlib/Cirq/issues/3736


Fix typos

Fixing some issues in the docs.
Thanks!
Bruno

Awesome, thanks! I guess we should get a spell checker plugin for the docs 😁


Has elastic abandoned this puppet module?

It seems to me that Elastic has abandoned this module. Logstash 1.5 has been out for months, but there has been zero movement in this puppet module.  The Elasticsearch puppet module was release a good while ago as well, so the idea that they are "waiting" to merge functionality seems more like, "doesn't really care about it."
I need to upgrade my Logstash cluster to the latest versions, but unfortunately, I made the mistake of investing time into using this module instead of rolling my own.  I keep waiting, assuming that an update is around the corner, but that update never comes.
Can the maintainers be honest with us? If you've abandoned this module, tell us so that I can give up on and and go implement my own.

Hi @dbeckham ,
I'm very sorry you have the feeling we abandoned the module.
I can ensure you this is not the case.
The ES puppet module is currently under heavy development and we recently released version 0.9.9
The current planning is to get the ES puppet module up to a certain level so we can use all the improvements made along the way and use that as a boilerplate for all the other modules to avoid doing duplicate development.
We are also focussing on adding a new module for one of the commercial plugins ( Shield ) of elasticsearch to make it easier for users to manage that part.
The current Logstash module works fine with LS 1.5 except or the plugin management.
We decided to wait with updating since the plugin parts would only be a few exec calls which can be easy implemented by the users.
I am planning to copy the elasticsearch code into a boilerplate in the next few weeks in such a way we can build on top of that and utilize all the improvements for the next Logstash module.
I hope this answers your question.
If you have any other concerns or questions, please let me know.

Verified:  I was able to test out 1.5 using the existing module just by updating the package_url param to be the latest rpm from the downloads site:  https://www.elastic.co/downloads/logstash

@electrical Any update? It's been a few months and with Logstash moving aggresively towards LS 2.x this module needs to catch up soon because it's becoming hard to use it to maintain configuration.
The elasticsearch instance template seems like it will fix the issue with instances being removed from this module so that is a really desired feature.
Hopefully the boiler plate template is ready to start testing with LS 1.5.x and 2.x, Puppet 4, etc.

@electrical I am in the same boat here. I decided to stay with Logstash 1.4 simply because this module isn't ready.  If you could give me a hand, however, I might be able help to build in some of the missing features.  I also plan to write a series of blog posts showing how I've built a scalable logstash cluster using these Puppet modules.

Alex I have successfully installed Logstash 2.x with this module.
I would however like to see this module update as planned to support all
the additons that were added to elasticsearch module.
Only thing majorly missing here is the plugin install which is in the ES
module and for time being I've written my own wrapper around his to get
that functionality to work.
On Fri, Jan 15, 2016 at 9:10 AM Alex Harvey<EMAIL_ADDRESS>wrote:

@electrical https://github.com/electrical I am in the same boat here. I
decided to stay with Logstash 1.4 simply because this module isn't ready.
If you could give me a hand, however, I might be able help to build in some
of the missing features. I also plan to write a series of blog posts
showing how I've built a scalable logstash cluster using these Puppet
modules.
—
Reply to this email directly or view it on GitHub
https://github.com/elastic/puppet-logstash/issues/240#issuecomment-171970267
.

Hello! After an epic journey, the module now has basic support for Logstash 2.x, and the new plugin system in particular.
This is now available as version 0.6.0 on the Puppet Forge, or fresh from right here on Github, naturally.
I am truly sorry for the amount of time that has ticked away here.


[FLINK-25790][flink-gs-fs-hadoop] Support authentication via core-site.xml in GCS FileSystem plugin

What is the purpose of the change
For the GCS FileSystem plugin, use the same authentication options for the RecoverableWriter portion as is done for the normal FileSystem portion. This means that it will use GOOGLE_APPLICATION_CREDENTIALS, if it exists, but will also use the google.cloud.auth.service.account.json.keyfile property from Hadoop config.
To have both portions of the plugin use the same rules, each of them will only consider using service credentials if the Hadoop property google.cloud.auth.service.account.enable is true or unspecified (i.e. the default value is true).
Brief change log

Update GSFileSystemFactory to read Hadoop config from the location specified in CoreOptions.FLINK_HADOOP_CONF_DIR or in the HADOOP_CONF_DIR environment variable and to combine it with Hadoop config values from the Flink config
Update GSFileSystem to look for credentials in either GOOGLE_APPLICATION_CREDENTIALS or google.cloud.auth.service.account.json.keyfile, if google.cloud.auth.service.account.enable is not false, when constructing the Storage instance for the RecoverableWriter

Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no) No
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) No
The serializers: (yes / no / don't know) No
The runtime per-record code paths (performance sensitive): (yes / no / don't know) No
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) No
The S3 file system connector: (yes / no / don't know) No

Documentation

Does this pull request introduce a new feature? (yes / no) Yes
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) Will be documented via https://github.com/apache/flink/pull/18430

Please let me know if there's anything else you would suggest I change in terms of the implementation, besides what you've already suggested, and then I'll look at unit tests as the last piece.

@xintongsong

It might be better to have some test cases guarding our changes. I can think of two things that need to be verified: the configuration fallback logics, and merging of hadoop config from flink config and core-site

I've added these in the latest commit, https://github.com/apache/flink/pull/18489/commits/6d137f72504470a6be9d971b7e1bba1d8614cffa.
I had to refactor things a bit to make them easily testable; now, all the interesting code is in ConfigUtils and GSFileSystemFactory and GSFileSystem are simplified.
I also consolidated things a bit. There was really no good reason for the configuration operations to be spread among GSFileSystemFactory and GSFileSystem before; now, all configuration is resolved in GSFileSystemFactory.
Please let me know if you have any other feedback, or let me know if it looks good and I'll squash. Thanks.

@xintongsong Sounds great! With this and the associated docs, we're all done right? I just want to make sure I'm not forgetting anything. Thanks again for all your help on this.


How to get status / result of FastStoreModelTransaction

Hey,
we need to insert many thousand rows and therefore we would like to use the
FastStoreModelTransaction.
Some parts of our application need to wait for the transaction to complete, but as there is no result we are unable to wait.
Is there a way to get the status or result of this transaction?
Or is there a way to bulk insert rows synchronously.
Thanks for this great library!
😊

By using the Success callback block on the Transaction executed from the DB.
database.beginTransationAsync(FastStoreModelTransaction....).success(...).execute().

to do it synchronous, use executeSync() method. but if its synchronous, then youll know it completed in line.

perfect this was to easy ;)
Thanks!


Problem:  python3: stable-abi by default may cause segfault on Unix

Problem:  python3: stable-abi by default may cause segfault on Unix
Solution: do not enable the stable Python ABI by default, only when used
with --with-python3-stable-abi argument is given
related: #15543
cc @k-takata

included as of 3f7024cf8

The result of --with-python3-stable-abi argument is not shown:
https://github.com/vim/vim/actions/runs/10515717808/job/29136395987?pr=15555#step:15:127
checking --with-python3-stable-abi argument... checking Python's abiflags...

It should be shown as follows:
checking --with-python3-stable-abi argument... no
checking Python's abiflags...

Hm, any idea how to fix this?

Restoring AC_MSG_RESULT(no) in the 4th parameter of AC_ARG_WITH() should fix it:
--- a/src/configure.ac
+++ b/src/configure.ac
@@ -1549,7 +1549,8 @@ if test "$enable_python3interp" = "yes" -o "$enable_python3interp" = "dynamic";
      else
        vi_cv_var_python3_stable_abi="$withval"
      fi
-     AC_MSG_RESULT($vi_cv_var_python3_stable_abi)])
+     AC_MSG_RESULT($vi_cv_var_python3_stable_abi)],
+     AC_MSG_RESULT(no))
       if test "X$vi_cv_var_python3_stable_abi" != "X"; then
         AC_CACHE_VAL(vi_cv_var_python3_stable_abi_hex,
         [

(not tested)
BTW, it looks like 9.1.0691 broke the indentation.

Thanks. the previous patch used tabs instead of spaces in configure.ac, so I changed it back to blanks with :set et

It seems we have a strange mix of spaces and tabs in configure.ac anyhow.


[WIP] use v2 names, use state file

This PR includes the set of changes necessary to use with with my wideq branch, opened as sampsyo/wideq#132
In particular, the following changes need to be addressed:

Support for loading the user number and OAuth root url, which are both necessary in the v2 API.

This is resolved by using the json state file instead of manually transferring just the token to the Home Assistant configuration.yaml file. In theory, we could support both manually inserting the entries, but referring to the JSON file seems to be more robust and user friendly.

Changing the name of hard coded values in climate.py to refer to their v2 api (airState) equivalents.

Instead of using these values, the wideq api should provide an api independent method to get the supported operation modes and wind directions
this is marked as a wip because dishwasher support is currently disabled. Hopefully, I can get that working next.
If you would like v2 support, you can try using this branch, and installing the wideq branch here: https://github.com/no2chem/wideq using pip install . in your home-assistant environment.
addresses #87

Hi there! Thanks for getting this started! I'm catching up on the PRs here, and although I know this is still WIP, I wanted to make a couple of notes:

I really think we should stick with using Home Assistant's own configuration system rather than including the JSON file that can be serialized from the wideq library. I think this is important for being a "good citizen" of the HA ecosystem here—it would be a bad scene if every integration invented its own configuration storage format! Hopefully, by abiding by the recommended way to store configuration, etc., in HA, we can take advantage of concomitant advantages that come with the HA ecosystem, such as their interactive configuration viewer stuff.
We'll need to be careful here about how we transition the integration so it continues to work across changes in the wideq library version. That means either keeping the wideq interface the same or making sure that this integration specifies which version of the library it's supposed to be using.

Thanks again for spearheading the effort!

Hello @no2chem,
i've tried to use your's PR branch and linked wideq version. No errors in logs, but there are no devices in HA.
I have 3 air conditioners.
Entries from my HA logs:
2020-12-08 22:44:03 WARNING (MainThread) [homeassistant.loader] You are using a custom integration for smartthinq which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant.

2020-12-08 22:44:13 INFO (MainThread) [homeassistant.setup] Setting up smartthinq

2020-12-08 22:44:21 INFO (MainThread) [homeassistant.setup] Setup of domain smartthinq took 8.1 seconds

2020-12-08 22:44:31 INFO (MainThread) [homeassistant.components.climate] Setting up climate.smartthinq

2020-12-08 22:44:42 INFO (MainThread) [homeassistant.components.sensor] Setting up sensor.smartthinq

What can i do to investigate this?

@jacekpaszkowski interesting. Are your devices v2? I suspect the issue is due to a TLS issue. Are you located in the US or another region?

@no2chem i'm quite sure my devices are v2. I have my devices for about 4 months. I'm located in Poland (PL).
I've tested different versions of wideq. Take a look at outputs for my account
https://github.com/sampsyo/wideq

https://github.com/no2chem/wideq

https://github.com/gladhorn/wideq

Any news on this pull request. Would be happy to help but I'm no programmer whatsoever...

I would love to help. I have a air conditioner v2 here. If there's any test i can do to test, just say so.

I am useless in coding, but sure want to contribute in whichever way possible. I can sure help testing the changes. It is however only possible to test the APIv2 as we do not have APIv1 devices.

I'm able to contribute to the code but realistically we need input from the repository owner before proceeding at this point

We'd love any help we can get!! Carefully figuring out what remains to be done based on the thread would be a great way to start…

I think a good first step to get this back on track would be to add tests for the existing implementation, since I imagine you'd expect both v1 and v2 support to persist?

That's actually the big question: nobody seems to be 100% sure whether we need both v1 and v2 support, or whether we can transition entirely to v2 without dropping support for existing devices. So I think the first thing would be to nail that down—things would certainly be way simpler if we could just support v2.

I was searching for a solution for a few months now and found few alternate forks. I was able to make my v2 devices work with one from marciogranzotto that supports only v2, not v1 devices and it's explicitly state as usable only for v2 things. It's a fork originating from this PR, so I think v1 devices won't work if you support only v2 API. I could be wrong though, so that fork could be in theory used to test it out. (https://github.com/marciogranzotto/hass-smartthinq)

to me, it sounds like people will be stuck with v1 still, so we should adopt a strategy that allows us to support both.
I think starting with some basic testing on the current implementation would go a long way, it sounds painful but this is the way
Once we have comprehensive or at least basic testing over v1, we can safely adopt v2 and pave the way for good support for v3 (if it ever gets done)


chore: remove more type verification at runtime, and narrow down argument/return types

continues #317

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

74 of 92 (80.43%)  changed or added relevant lines in 26 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 99.341%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Psl/Env/get_var.php
1
2
50.0%

src/Psl/Env/set_current_dir.php
1
2
50.0%

src/Psl/Filesystem/change_permissions.php
1
2
50.0%

src/Psl/Filesystem/copy.php
1
2
50.0%

src/Psl/Filesystem/create_symbolic_link.php
1
2
50.0%

src/Psl/Filesystem/file_size.php
1
2
50.0%

src/Psl/Filesystem/get_access_time.php
1
2
50.0%

src/Psl/Filesystem/get_change_time.php
1
2
50.0%

src/Psl/Filesystem/get_inode.php
1
2
50.0%

src/Psl/Filesystem/get_modification_time.php
1
2
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
3314

Relevant Lines:
3336

💛  - Coveralls


add issue template to resolve #61

Signed-off-by: Morgan Bauer<EMAIL_ADDRESS>

@MHBauer the logs are at the current directory and are named: crawler-*.log.

Current coverage is 71.59% (diff: 100%)

Merging #125 into master will not change coverage

@@             master       #125   diff @@
==========================================
  Files            22         22
  Lines          2982       2982
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           2135       2135
  Misses          847        847
  Partials          0          0

Powered by Codecov. Last update f29bb73...483cc85

updated. give it a read.

Cool, lgtm. Thanks!


Field type Json has no validator defined

Current behavior
Importing data to services with a Json field doesn't work. The error message

Field type Json has no validator defined

is returned.
Reproduction
Import data to a service that has a field of type Json or Json!.
Expected behavior?
It works.

any update on this one ? Is there an other way import data without validator ?

Same issue here...
I think you just have to add here:
https://github.com/graphcool/graphcool-framework/blob/0b80d3a8988fbaf6d9d4b2d55f2d586bc5e19e43/cli/packages/graphcool-cli-core/src/commands/import/Validator.ts#L41
Json: (str) => {
    try {
        JSON.parse(str);
    } catch (e) {
        return false;
    }
    return true;
}

or something like that... (can't test here...)


Install a local wheel file

Trying to install a local *.whl wheel file fails with pipenv.
This is related to https://github.com/kennethreitz/pipenv/issues/480
I have verified my wheel that it works when I install it using python -m http.server and using a HTTP URI for the wheel instead of a local file system path.
Describe your environment

OS Type: Linux pns-mac-003 4.13.12-1-ARCH #1 SMP PREEMPT Wed Nov 8 11:54:06 CET 2017 x86_64 GNU/Linux
Python version: Python 3.6.3
Pipenv version: pipenv, version 8.3.2

Expected result
Wheel installs correctly. In the same way I can install a wheel using pip install path/to/package.whl.
Actual result
$ pipenv install ../foolib/dist/foo-0.0.0.dev0-py3-none-any.whl
Installing ../foolib/dist/foo-0.0.0.dev0-py3-none-any.whl…
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/packaging/requirements.py", line 90, in __init__
    req = REQUIREMENT.parseString(requirement_string)
  File "/usr/lib/python3.6/site-packages/pyparsing.py", line 1632, in parseString
    raise exc
  File "/usr/lib/python3.6/site-packages/pyparsing.py", line 1622, in parseString
    loc, tokens = self._parse( instring, 0 )
  File "/usr/lib/python3.6/site-packages/pyparsing.py", line 1379, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "/usr/lib/python3.6/site-packages/pyparsing.py", line 3395, in parseImpl
    loc, exprtokens = e._parse( instring, loc, doActions )
  File "/usr/lib/python3.6/site-packages/pyparsing.py", line 1379, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "/usr/lib/python3.6/site-packages/pyparsing.py", line 3717, in parseImpl
    return self.expr._parse( instring, loc, doActions, callPreParse=False )
  File "/usr/lib/python3.6/site-packages/pyparsing.py", line 1379, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "/usr/lib/python3.6/site-packages/pyparsing.py", line 3378, in parseImpl
    loc, resultlist = self.exprs[0]._parse( instring, loc, doActions, callPreParse=False )
  File "/usr/lib/python3.6/site-packages/pyparsing.py", line 1383, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "/usr/lib/python3.6/site-packages/pyparsing.py", line 2689, in parseImpl
    raise ParseException(instring, loc, self.errmsg, self)
pyparsing.ParseException: Expected W:(abcd...) (at char 0), (line:1, col:1)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3015, in __init__
    super(Requirement, self).__init__(requirement_string)
  File "/usr/lib/python3.6/site-packages/packaging/requirements.py", line 94, in __init__
    requirement_string[e.loc:e.loc + 8]))
pkg_resources.extern.packaging.requirements.InvalidRequirement: Invalid requirement, parse error at "'../foolib/'"

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/jwa/.local/bin/pipenv", line 11, in <module>
    load_entry_point('pipenv==8.3.2', 'console_scripts', 'pipenv')()
  File "/home/jwa/.local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/home/jwa/.local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/home/jwa/.local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/jwa/.local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/jwa/.local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/jwa/.local/lib/python3.6/site-packages/pipenv/cli.py", line 1876, in install
    c = pip_install(package_name, ignore_hashes=True, allow_global=system, no_deps=False, verbose=verbose, pre=pre)
  File "/home/jwa/.local/lib/python3.6/site-packages/pipenv/cli.py", line 1355, in pip_install
    if [x for x in requirements.parse(package_name.split('--hash')[0].split('--trusted-host')[0])][0].vcs:
  File "/home/jwa/.local/lib/python3.6/site-packages/pipenv/cli.py", line 1355, in <listcomp>
    if [x for x in requirements.parse(package_name.split('--hash')[0].split('--trusted-host')[0])][0].vcs:
  File "/home/jwa/.local/lib/python3.6/site-packages/pipenv/vendor/requirements/parser.py", line 50, in parse
    yield Requirement.parse(line)
  File "/home/jwa/.local/lib/python3.6/site-packages/pipenv/vendor/requirements/requirement.py", line 220, in parse
    return cls.parse_line(line)
  File "/home/jwa/.local/lib/python3.6/site-packages/pipenv/vendor/requirements/requirement.py", line 198, in parse_line
    pkg_req = Req.parse(line)
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3061, in parse
    req, = parse_requirements(s)
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3008, in parse_requirements
    yield Requirement(line)
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3017, in __init__
    raise RequirementParseError(str(e))
pkg_resources.RequirementParseError: Invalid requirement, parse error at "'../foolib/'"

Trying to install the wheel with -e does not work, either. But that is expected as a wheel shouldn't be editable.
Steps to replicate

Download any .whl file to your local filesystem
Try to install it using pipenv install path/to/package.whl

Hey @julianwachholz thanks for the report — this one sucks to run into but is actually fixed in master and will be out in the next release. In the meantime you can work around this by using the file:// URI format instead of a relative path, but let me know if that doesn’t work

Thanks for the heads up! I confirmed this works with the latest master checked out.
Great work, keep it up!

Another way might be to run pipenv run pip install wheelname.whl.


[BEAM-8131] Provide Kubernetes setup for Prometheus

The beginning of implementation of the following proposal: https://s.apache.org/test-metrics-storage.
With this PR merged, we would be able to start sending metrics to the Prometheus.
Instructions for deployment on Kubernetes is going to be added to the wiki soon.
Note:
There is no integration with Grafana yet, since it's in the scope of the other task (https://issues.apache.org/jira/browse/BEAM-8134).

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @Ardagan @markflyhigh Please take a look.
cc: @pabloem

I have concerns with introducing new systems into our infra before understanding what else can be re-used. Commented on https://s.apache.org/test-metrics-storage
/cc @markflyhigh  @alanmyrvold

In doc I see that we decided to move from BQ to Prometheus.
Can you add some background on this decision compared to using Grafana BQ connector?
https://grafana.com/grafana/plugins/doitintl-bigquery-datasource/installation
(I added comment in doc as well)

Thanks @Ardagan and @aaltay. I left my comments in the doc (https://s.apache.org/test-metrics-storage)

Run CommunityMetrics PreCommit

@markflyhigh Just a kindly reminder :) Please take a look or let me know if you don't have enough time right now

@alanmyrvold could someone other than @markflyhigh can review this for infra changes? I am guessing @markflyhigh is busy with the release.

@pabloem Thanks for your review!
In answer to your question, there is no need to manually create the persistent volume. Kubernetes automatically provisions a persistent disk for you.

Run CommunityMetrics PreCommit

Thanks!


Changed order of resolution to get rid of warnings

@pkocandr I saw some warning in the build (nothing big), this change attempts to get rid of them

@pkocandr did not get rid of the warning, closing this PR


Fixup dropped line from PR #70

Hi @nojima, I'm just now getting around to removing the replace directive from my go.mod file and I realized that in the shuffle of the code review feedback on #70, I somehow dropped this critical line of code! Without this, the feature doesn't work at all :) Please merge. Apologies for the noise. Thank you!

Thanks!


Document barcode scanner intent for Tables

The com.google.zxing.client.android.SCAN intent to launch a barcode scanner should be documented with its odkCommon.doAction parameters and the expected callback contents.

Hi I'd like to work on this issue. Is commenting enough to claim it?

@shaliniiit I have assigned this issue to you.

Thank you.
On Mon, 12 Apr 2021 at 1:45 AM, wbrunette @.***> wrote:

Assigned #119 https://github.com/odk-x/tool-suite-X/issues/119 to
@shaliniiit https://github.com/shaliniiit.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/odk-x/tool-suite-X/issues/119#event-4578947765, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHYKFCU6Z7K4MYWWAQDURZ3TIH7MJANCNFSM4I6LVKYQ
.

@sheykerkup  I have assigned this issue to you.

Where can I currently find this feature? Can I have a little more details as to which ODK-X tools this belongs to and how to replicate the new feature on my android device?

Where can I currently find this feature? Can I have a little more details as to which ODK-X tools this belongs to and how to replicate the new feature on my android device?

You can launch from ODK-X Tables webkit by using the ODK-X java interface available in odkCommon
odkCommon.doAction(dispatchStruct, 'com.google.zxing.client.android.SCAN', null);
See documentation:
https://docs.odk-x.org/injected-interfaces/#doaction

Where can I currently find this feature? Can I have a little more details as to which ODK-X tools this belongs to and how to replicate the new feature on my android device?

You can launch from ODK-X Tables webkit by using the ODK-X java interface available in odkCommon odkCommon.doAction(dispatchStruct, 'com.google.zxing.client.android.SCAN', null);
See documentation: https://docs.odk-x.org/injected-interfaces/#doaction

Thank you very much. I will take on this immediately.

@wbrunette  @elmps2018  I have linked the complete documentation for this process with sample code I used to achieve this. Please checkit out. For some reason, I can not seem to tag you all on that repository. https://github.com/odk-x/docs/pull/183

@sheykerkup u can always tag them manually

@sheykerkup u can always tag them manually

Thanks. I will try that now.


fix: minor list issues

Fixes two minor issues with tk env list:

It appended main.jsonnet to CLI suggestions
Unstable ordering. Fixes #524

I found it useful that it appended the main.jsonnet, it let me easily replace tk diff with my editor and back.

Given (1) is already resolve and (2) appears to be useful to some, closing this ;)


⚠ Bofrost.lu has degraded performance

In f3710ac, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1770 ms

Resolved: Bofrost.lu performance has improved in 3ee872c after 1 hour, 6 minutes.


Recognized Words

First of all, I love this module you've created. It really makes speech recognition under python incredibly simple and I thank you for all your hard work.
However, I am having a hard time getting this library to understand words that it doesn't want to. For instance "Codsworth" is not a word but a name. This is not recognized by the speech API and is causing me a great deal of trouble. Any help? Thanks

Hi @TheAtomicNord,
The speech API cannot transcribe words that it doesn't recognize - there is no concept of "transcribing sounds". Instead, you can try another library such as SPHINX that supports phoneme recognition and transcription.

Here is an example of phoneme recognition: http://cmusphinx.sourceforge.net/wiki/phonemerecognition
To recognize words that aren't really "words", you would need to set up SPHINX such that unrecognized words are gone over with the phoneme recognizer. The resulting phonemes (like F or AO, R, W, ER, D) should then be concatenated to get FAORWERD (forward).
Note that this isn't very accurate - it doesn't take into account any linguistic rules, so you might not get very high quality results from it.

@Uberi , have you considered integrating Sphinx to your library? Would that be relevant?
I used your library as well as Sphinx and I feel like it would be great if we could easily switch from Wit.ai, IBM, AT&T or even Sphinx. What do you think? I could eventually do the porting myself, but I'm not a STT expert at all and I would like to have your advice to know if that would make sense.

@AndreMiras actually, I've been working on that previously! Sphinx integration will be a part of the next point release 3.2, which, fingers crossed, will be out in a few days.

Wonderful! Please let me know when it's ready so I can test it.


pyimport_conda doesn't recognise the Anaconda installation

This is a follow-up from Conda.jl Issue #1
cortner: thanks. so I could go the other way round, use
try
     pyimport_conda("<pip name>", "<conda name>")
catch
    run(`conda install some package`)
end

that way, if the package is already installed, I won't install it again?
stevengj: the pyimport_conda function does the conda install for you if needed. That's the whole point.
Note that this is documented in the PyCall README ... no need to read the PyCall source code
(Note that the first argument of pyimport_conda is the name of the module you want to import; it has nothing to do with pip.)
@stevengj I tried to usepyimport_conda, but without success:
julia> Pkg.build("PyCall")
INFO: Building PyCall
INFO: PyCall is using /Users/ortner/anaconda/bin/python (Python 2.7.11) at /Users/ortner/anaconda/bin/python, libpython = /Users/ortner/anaconda/lib/libpython2.7.dylib

julia> PyCall.pyimport_conda("pyamg", "pyamg")
ERROR: Failed to import required Python module pyamg.

For automated pyamg installation, try configuring PyCall to use the Conda Python distribution within Julia.  Relaunch Julia and run:
    ENV["PYTHON"]=""
    Pkg.build("PyCall")
before trying again.
#  and some more

But I specifically don't want to use the miniconda distribution. I also tried it with first setting
julia> ENV["PYTHON"] = "/Users/ortner/anaconda/bin/python"
"/Users/ortner/anaconda/bin/python"

Where is my mistake? Thank you.

pyimport_conda is currently for when PyCall is using the Conda.jl "private" miniconda distro, not any generic system-wide Anaconda installation.
I suppose I could extend it to the latter case.   But how do we reliably detect if Python comes from Anaconda, and find the corresponding conda program?

I I think I must have misunderstood your comment in the Conda.jl Issue #1.
In my case, when I build PyCall it automatically detects it. Is it not possible to check whether PyCall is already configured to use an existing Anaconda installation? In that case conda should be in the path anyhow? Sorry if this is naive.
I am perfectly happy to just tell the user to install it by hand. Can I then suggest though to change the error message as follows:
julia> PyCall.pyimport_conda("pyamg", "pyamg")
ERROR: Failed to import required Python module pyamg.

First install pyamg for your Python distribution (***can PyCall say here what it currently uses?***).

Alternatively, for automated pyamg installation, try configuring PyCall to use the Conda Python distribution within Julia. (***warning on what this entails?***) Relaunch Julia and run:
    ENV["PYTHON"]=""
    Pkg.build("PyCall")
before trying again.
#  and some more

This can probably be formulated better, but the gist is that a naive user (like me) might read the error message too quickly and accidentally switch her/his Python distribution to Conda.jl/miniconda.
Thanks.

PyCall.pyprogramname is the Python executable name that your PyCall was configured to use.  PyCall.conda == true if you are using Conda.jl's Python.
Whether conda is in the path is, in principle, independent of whether PyCall was configured to use Anaconda Python, because you can build PyCall with the full path of any Python via ENV["PYTHON"]="/path/to/python"; Pkg.build("PyCall").   For example, just a few minutes ago I was doing some testing and configured it to use /usr/bin/python on a system that also had a global Anaconda Python in the PATH and also had Conda.jl.   So you can't just check for conda in the path.

of for me, as I say above it is perfectly fine to expect a user who maintains their own Python distribution to do these installations by hand. But I did need to read the error message twice before I understood it, so this could maybe be improved. I'll close this.

Let me re-open this, because I think it is feasible to automate the installation for a global Anaconda install, and the prospect is worth considering.
In particular, it looks like we can detect Anaconda's Python from the Python version string, via contains(bytestring(ccall(@pysym(:Py_GetVersion), Ptr{UInt8}, ())), "Anaconda") (true for Anaconda).  Then we could get the conda path via joinpath(dirname(PyCall.pyprogramname), "conda")

Weird, I pushed a commit to fix this but it is not showing up in the Github history (although it shows up if I git clone a fresh copy).

Okay, the commit finally showed up.

@cortner, let me know if this fixes your concern.

(You will need to do Pkg.checkout("PyCall") to get this patch until a new version of PyCall is tagged.)

Done. Works beautifully. Thank you!


EmbedMolecule does not always respect atom index when performing embedding

Configuration:

RDKit Version: 2020.03.1
Operating system: Linux
Python version (if relevant): 3.7.4
Are you using conda? yes
If you are using conda, which channel did you install the rdkit from? The RDKit Channel

Description:
In attempting to use EmbedMolecule to get sane initial values for downstream geometry processing, I've run into an issue. Sometimes, it will swap the index of atoms that I don't think should be swapped? For example:
m1 = Chem.AddHs(Chem.MolFromSmiles('F/C=C'))
m2 = Chem.Mol(m1)
Chem.AllChem.EmbedMolecule(m2)

When we look at m1 we see:

and yet when we look at m2 we see:

that is, H4 is now closer to F than H5. Now I recognize that, under traditional cis/trans isomerism, this isn't an issue -- both are the same molecule. But, for my downstream analysis, where I'm asking questions about inter-atom distances, this is a real problem -- suddenly the distance between H5 and F have shifted by a very large amount due to this embedding!
I recognize this is an edge case, but everywhere else I've seen in RDKit seems to carefully preserve atom index after various manipulations, making me think this is likely a bug/error.
Workarounds
I've tried various workarounds (attempting to set stereochemistry values, setting distinct user properties for the H atoms so they are not identical, or trying template matching to recover the original ordering) without much success.

That molecule isn't stereo (the cis and trans are superimposable - just rotate the molecule )
>>> Chem.MolToSmiles(Chem.MolFromSmiles('F/C=C'))
'C=CF'

Adding something besides hydrogen at H5 ( or H4) or making one an isotope does make it stereo:
>>> Chem.MolToSmiles(Chem.MolFromSmiles('F/C=C/Cl'))
'F/C=C/Cl'

@bp-kelley Thank you for your response!  That is, there is no rotation of the molecule (that I can see) that will allow you to superimpose F0, H3, H4, and H5.
I 100% agree that chemically these are the same molecule, but the fact that EmbedMolecule is permuting the indices like this makes subsequent downstream processing challenging. Is there a workaround that would let me match up the indices after the embedding?

The problem you are going to face is that to RDKit both H4 and H5 are identical, so in either depictions or embedding, there is no constraint applied.
I think you best bet is to look for symmetry classes down stream and deal with them then:
>>> m1 = Chem.AddHs(Chem.MolFromSmiles('F/C=C'))
>>> list(Chem.CanonicalRankAtoms(m1, breakTies=False))
[3, 5, 4, 2, 0, 0]

This Indicates that the two Hs have the same symmetry and could swap with each other during the embedding process.
In fact, this process is regularly done with RMSD pruning.

This also solves your issue for rotations around a single bond like a biphenyl.


Infinite loop

Hello,
I have a small problem with component router for angular 1. When I'm trying to redirect/ navigate to another component from $routerOnActivate lifecyle hook, I'm getting into an infinite loop of redirects from current component to desired component. In the best case scenario is not infinite, but it will redirect between those two paths multiple times. What I am trying to do is that if something goes wrong, I want to go my home page. So basically I'm trying to do something like:
this.$routerOnActivate = () =>  {
this.$router.navigate(["abcd"]
}
If i'm wrapping the navigate action into a setTimeout with 100 delay for example,it works fine, but for my scenario this is not a good idea cause the app is really lazy on edge or IE and there 100 miliseconds will be not enough.
Can you help me please with an idea?

And one more thing. If i'm wrapping the navigate action into a setTimeout with 100 delay for example,it works fine, but for my scenario this is not a good idea cause the app is really lazy on edge or IE and there 100 miliseconds will be not enough.

I ran into a similar issue where if I clicked two route links in quick succession, they would start looping back and forward. I presume it was happening because my routerOnActivate promise hadn't resolved by the time another routerOnActivate had been called (I don't know what's happening internally).
I hacked around this by doing something like this:
$ctrl.$routerOnActivate = function(next) {
    $timeout().then(activate);

    function activate() {
        // your onActivate code, i.e. $ctrl.$router.navigate(['abcd'])
    }
}

I don't think you need more than a 0 second delay but definitely use $timeout.

Thanks a lot for your help. Sorry for late feedback. I fixed it few weeks ago using a watch on rootScope until navigating property on rootRouter is false and everything works fine without any timeout. I created a custom method, something like this:
 customNavigate($childRouter) {
    return (route) => {
        if (!this.$rootRouter.navigating) return $childRouter.navigate(route);
        var stopWatching = this.$rootScope.$watch(
            () => {
                return this.$rootRouter.navigating;
            },
            () => {
                if (!this.$rootRouter.navigating) {
                    stopWatching();
                    $childRouter.navigate(route);
                }
            });
    };
}


not downloading subtitle even with -f flag

Whenever I try to download a subtitle I have the following problem
/Volumes/MyShare/Movies/The perverts guide to cinema%=> subliminal -l it -f The_Perverted_Guide_to_Cinema.avi                                           16:37
INFO: Listing subtitles for <Movie [u'The Perverted Guide to Cinema']>
INFO: Found 1 subtitles total
INFO: Downloading subtitle <PodnapisiSubtitle [it]> with score 13
No subtitles downloaded

Is this a normal behaviour?

Subliminal 0.8.0

Probably not since you have the '-f' options enabled,
but you could try to add "-m 0" :
subliminal -m 0 -l it -f The_Perverted_Guide_to_Cinema.avi

There's a problem with the podnapisi provider.
You'll need to update to the latest version with my pull request (c1972ab26f60203b518545f4cdb2d6ab3b80480d) to get it working again.

@h3llrais3r
Updated. Still remain the problem
@romaincout
No difference.

Actually, when I test it I get 0 subtitles...
INFO: Listing subtitles for <Movie [u'The Perverted Guide to Cinema']>
INFO: Found 0 subtitles total
No subtitles downloaded

h3llrais3r<EMAIL_ADDRESS>writes:

Actually, when I test it I get 0 subtitles...
INFO: Listing subtitles for <Movie [u'The Perverted Guide to Cinema']>
INFO: Found 0 subtitles total
No subtitles downloaded
Yes. Problem is that all providers are giving the subtitle for the
movie.

Reply to this email directly or view it on GitHub:
https://github.com/Diaoul/subliminal/issues/440#issuecomment-103140087

--
Dr. Enrico Pirani
Medico Chirurgo
Specialista in Chirurgia Toracica
FMH Chirurgia Cardiaca
Via Matteotti 7
35042 Este (Padova)
Cell:392-6224668
Tel: 0429-17660135
Ai sensi del D.Lgs. 196/2003 si precisa che le informazioni contenute in
questo messaggio sono riservate ed a uso esclusivo del destinatario.
Qualora il messaggio Le fosse pervenuto per errore, La invitiamo ad
eliminarlo senza copiarlo e a non inoltrarlo a terzi, dandocene gentilmente
comunicazione. Grazie.
Pursuant to Legislative Decree No. 196/2003, you are hereby informed that
this message contains confidential information intended only for the use of
the addressee. If you are not the addressee, and have received this message
by mistake, please delete it and immediately notify us. You may not copy or


Add Preset for natural=hill

https://wiki.openstreetmap.org/wiki/Tag:natural%3Dhill
I would like to have a preset for this feature. The input boxes can be copied from natural=peak

Not so sure about this one. My first instinct was "isn't a hill just a classification of a peak?" and the wiki page also discusses the same lack of distinction. I think it makes more sense for peaks to be consistently tagged and folks can differentiate as they individually desire by the ele tag and/or a calculated prominence.

The difference between hill/mountain/peak is indeed subjective.
As far as I can tell, the main reason for this feature to exist is if the hill has a name and the style wants to render named natural things.
People can really add whatever they want into the natural= namespace, so this seems ok:

I agree that the difference is subjective however the difference is definitively there.
Additionally, the tag is used in OSM and is not deprecated by the OSM Wiki so I see no reason why this should not be implemented.

Additionally, the tag is used in OSM and is not deprecated by the OSM Wiki so I see no reason why this should not be implemented.

We don't just do everything the OSM Wiki says to.  A lot of it is wrong or just added by one person.

Yeah I think it's fine for people to use natural=peak for named hills instead of making iD mappers draw distinctions.


Feature Request : WebSocket for server events

Currently, the web-ui only fetches site status from the status endpoint when we start/stop sites via the ui. It would be nice to hook up a websocket to the ui so that we can get real-time status not only for log messages but site status changes,statistics and so on

This has been added in PR #37 - currently supporting site change notifications and tcp open / close. More to come in later iterations


Handle 500 Internal Server Error better?

First, credit to the coders: this is an amazing project, filled with detailed feedback for students to better understand what they are doing and what is going on. So, in a huge way, thank you for building this amazing product.
However, 500 Internal Server Errors might be more informative from a student's perspective. Here's an example that would be difficult for students (even TAs) to troubleshoot:

No specific request here, but maybe pointing to something in the student's code that might help them start to investigate the issue might be better.

Helpful raw data from the field! This aspect is definitely still "beta" level, and we can do a lot more to clean things up and present it more nicely.


build/publish manylinux wheels

@jswhit This is ready for merge.

How is the upload to rackspace triggered?

It should be triggered by tag commits.

OK, that should work.  Merging now...


Resource interval gets console errors when no resources defined

It would be an error to not have any resources in a scheduler environment

Fix is in UI component v1.02


Commit c91acbc breaks Model.save() interface

The merged commit c91acbc breaks the default behavior of Model.save().  The default behavior is for Model.save() to call Model.parse(response) with any data returned from the ajax call.  Any sub-models or collections that are produced by the Model.parse should be managed in the parse, I believe this patch was issued to deal with inadequate state management in Backbone-Relational.

I think this code has been removed so I'm going to close this issue.


ESXi Compatibility for Windows2016

We are building a Windows2016 stemcell using vCenter. The directions say to "Select compatibility, ensure that you choose ESXi 6.0 and later" for Windows2016; however, the choice for Windows2016 only appears when we select ESXi 6.5 and use “hardware version 11.” Instructions probably just need to be updated to reflect that.

@jimbasler-pivotal Hi! Thanks for reporting this. Could you describe this a little further?
This is what I see currently when I create a new VM.

@kartiklunkad26 same notice
Wiki page says that
For Windows Server version 1709: Use hardware version 10
For Windows Server 2012 R2: Use hardware version 9

Actually, it should be
For Windows Server version 1709: Use hardware version 11 (ESXi 6.0 and later)
For Windows Server 2012 R2: Use hardware version 10 (ESXi 5.5 and later)

Windows Server version 1709 appears only after compatibility level (ESXi 6.0 and later), hardware version 11.

@sumkincpp Thanks! Will incorporate the feedback into the instructions.


Supermium running pages with scripts causes system clock to race ahead

I am using XP SP3 with all updates. System time has never been an issue.
Running Supermium Version 122.0.6261.85 (Official Build) (32-bit)
When I open Supermium to it's home page, or a simple page like google.com or static HTML no issues.
However, when I go to a page that has running scripts/code on it such as Tradingview.com, Coinmarketcap.com, Yahoo Finance, etc suddenly my system clock races ahead about 33% (or so) faster than usual. When I close those pages or the browser, time returns to normal pace.
I reset the clock, monitor it for several hours, no drift. Open Supermium and leave it just on the home page, no issues.
Go to, for example, tradingview.com and just let it sit there on some random chart -- time races ahead.
(for comparison) Going to those same pages using MyPal causes no system timer issues.
Given that almost every page I visit has some kind of scripting this is a critical bug for me.
Thank you for your attention to this matter.

What CPU are you using? I am aware of some timer bugs in XP itself but they shouldn't affect older CPUs.

What CPU are you using? I am aware of some timer bugs in XP itself but they shouldn't affect older CPUs.

I am using a Core2 Duo E8600
I downloaded a little tool called Timerresolution.exe which checks the system timer resolution ( I guess gamers change it for performance hopes). When I opened it it showed 0.977 ms.
I then opened to type this reply and thought, let me check it again, it now it shows 15.625 (I'm lead to believe from a few google searches that this is the default/normal value).
Then I was typing here for a few moments and check it again and it jumped to .977 . This was while I had a couple tabs open (yahoo finance, tradingview - which shows the time and it's already 4 minutes ahead of normal time).
I closed those tabs and refreshed the system timer and it returned to 15.625 (default).
I'd also note. Sometimes I'll get system freezes. Long long pauses and then everything catches up. I just noticed. if it's at that .977 value the system freezes occur, as long as its' at the normal value of 15.625 I get no freezes.
So, this is a critical bug. Can we please not mess with the system timer? :) Or at the very least give me a configurable option to prevent this value from being changed?
Thank you

they shouldn't affect older CPUs

there is reports that it affects too
and maybe it's related to multicore kernel

I have an incredibly easy way to demonstrate this issue plainly for anyone to see:
Sync your PC clock to official time to make sure it is coordinated.
Visit this site: https://time.is/
At the top of the screen you'll be told how close you are to actual time.
Now, watch the seconds counter of the time display. This is being calcuated and displayed in real time, it is NOT pulling the real time from the server. Notice, the seconds are moving too fast. After 30 seconds or so the page will automatically refresh and check the time difference between your system time and real world time. You'll see this value increase.
(Note: on my system this will create about 25 chrome.exe processes and consume 100% CPU over time)
Superium definitely has some issue with the system clock and keeping track of time.
p.s., In the time it took me to type this message my system clock is now 58 seconds faster than it should be.

I'm happy to report that it appears this issue is corrected under 32-bit XP and Version 124.0.6367.245
I visited some sites that caused the speed up and system time doesn't appear to race ahead any more.
I didn't see it mentioned in the list of changes so I thought I'd comment here.


Add memoize

🚀 Feature request
Add helper for memoization:
const f = arg => {
    console.log("some costly computations")
    return result
}

const memoized = memoize(f)

// logs "Some costly computation"
memoized(1)

// logs "Some costly computation"
memoized(2)

// Cache hit, element returned without computation
memoized(1)

Desired Behavior
It would be nice if memoization was included in fp-ts. It's such a fundamental concept in functional programming I nearly regret it's not shipped with the language itself ;) I would also appreciate fp-ts being self-contained, battery included package for functional programming, without need to install Ramda/lodash or writing own helpers for such a basic feature.
Suggested Solution
If this is approved, I can open a PR on that
Who does this impact? Who is this for?
All users of pure but costly functions ;)
Your environment

Software
Version(s)

fp-ts
2.4

TypeScript
3.7.3

Again - what bounds do we define for fp-ts to include such helpers? IMO this is definitely smth for an external library.

@raveclassic I agree - a consistent guide/standard for placing new features/shaping API is very desirable.
On the other hand, I am pretty sure memoization should live in the very core of any functional library - as I said, I would welcome including it in the language itself ;) (yeah, it's not gonna happen, but imagine e.g. pure function f(n: number) { ... } - of course it has its own limitations, but still... ;))

When we introduce memoization we should always think of the following questions:

what is the size of our cache?
if cache is infinite, then how do we deal with non-primitive arguments? how do create the key? Do we have any way to clear the memory?
if cache is finite then what is its size?
what is the underlying implementation of the cache? Is it possible to reuse an existing library that's already in the project?

All these question are too specific for such an abstract library like fp-ts.

@raveclassic Fair point, let's see what @gcanti says.
Just for transparency, I usually implement cache as simple Map (which allows using any values as keys, including objects) with limited size (and invalidating oldest elements). I limit memoization to single-argument functions for simplicity.

Personally I see fp-ts as a lib that implements the theories (category, abstract algebra, etc).  with some common usage implementations.
Caching is a huge subject onto its own - notoriously difficult.
memoization is a practical consequence of functional purity.
Personally I see little reason why it should be tied into fp-ts itself.
Another example would be immutability.
It would be great if we can also get it baked in but it is not a FP concern.
So maybe an ecosystem lib that provides this functionality as a configurable opt-in (like @ngrx does re immutability) would be the best solution.

Ideally an (fp-ts) API should have a single, obvious implementation.
Otherwise, i.e. if we must make an opinionated choice, it would be better a dedicated library.


Fix CommandExecuted not invoked on failed parse

Waiting on @Cenngo's review

I think this problem was introduced with https://github.com/discord-net/Discord.Net/pull/1700, I don't actually know if this is the best fix possible to be honest. @Cenngo

actually i was going to suggest the same fix. Im will propably rewrite command parsin logic at some point to fix this Discord.Net#1635 but for the time being rhis should do.


Unpkg CDN not Working for 2.2.10

Not sure where else to put this...but we are using the unpkg CDN pointing to the latest minor version of this plugin for a client, using @2.2.  This morning it looks like the latest version number was updated to 2.2.10, but the CDN does not return code for that version number.  We had to point specifically to 2.2.9 for it to work again.
To be specific, the /dist folder is empty.
Just wanted to inform someone.

thanks for the report. we've had corrupt npm tarballs before too (v2.2.5, v2.2.7).
my hope is that the tweak in #202 will lead to more consistent behavior.
v2.2.11 will be up in a few minutes.


complete ignored_file_regexes for Emacs temporary files

Files are
.#foo.bar
flychech_foo.bar

and missed
#foo.bar#

e.g. with https://github.com/encode/uvicorn
WARNING:  Detected file change in '['...#start.py#']'. Reloading...

Thanks so much and sorry for the delay in dealing with this. I'll create a new release today.

Thanks so much and sorry for the delay in dealing with this. I'll create a new release today.


Fix issue: Cannot publish tweet if it is too long

Fixes #40
Changes in brief:-

Added a function to check for content to make sure it is within limit(truncates description, if required).
Added test for above function.

Note --> I am new to both open source and github community. So, I will be happy to receive feedbacks.

Hi, @ezeoleaf
Thank you for your feedback. I have fixed the issues as per your observations.

Hi, @ezeoleaf
Thank you for your feedback. I have fixed the issues as per your observations.
Please take a look at it.

Nice work @Shubhcoder


Having trouble with Reason/JS interop of type

I'm trying to create a theming system in my app. I have a file where the themes are defined, T.re:
[@genType]
type theme = [ | `Light | `Dark];

[@genType]
let themeLight = `Light;

[@genType]
let themeDark = `Dark;

The generated T.gen.js looks like:
import * as TBS from './T.bs';

export type theme = "Light" | "Dark";

export const themeLight: "Light" = "Light";

export const themeDark: "Dark" = "Dark";

When I use these values in JavaScript, the expected string representations are used.
TextInput.js:
import { themeDark } from T.gen

const TextInput = ({ theme = themeDark }) => {
  console.log(theme) // "Dark"
  ...
}

However, when I use the types defined in Reason and then pass them into JS, a number value is used (the one I see in T.bs.js):
Component.re:
  ...
  render: _self => {
    ...
    <TextInput theme=T.themeDark />
  }

TextInput.re: (this Reason component is a Reason wrapper for a JS text input)
  let make = (~theme, ...) => {
    Js.log(theme); // 758939798
    ReasonReact.wrapJsForReason(
      ...

TextInput.js: Was expecting Dark, not 758939798, so my logic to display certain things based on the theme passed in isn't working.
import { themeDark } from T.gen

const TextInput = ({ theme }) => {
  console.log(theme, themeDark) // 758939798, "Dark"
  ...
}

Does this make sense? If I didn't explain sufficiently, let me know and I can try to provide more detail.

@dhruska is the wrapper in TextInput.re, the one using wrapJsForReason written manually, or generated automatically as described in:
https://github.com/cristianoc/genType#export-and-import-react-components
The difference is that one automatically generated will also perform conversion.

It's written manually, along the lines of:
<EMAIL_ADDRESS>"./AntdInput"] external input: ReasonReact.reactClass = "TextInput";

<EMAIL_ADDRESS>abstract]
type jsProps = {
<EMAIL_ADDRESS>  theme: T.theme,
<EMAIL_ADDRESS>  id: string,
<EMAIL_ADDRESS>  name: string,
  ...
};

let make =
    (
      ~theme: T.theme=T.themeLight,
      ~id=?,
      ~name=?,
      ...,
      _children,
    ) => {
  ReasonReact.wrapJsForReason(
    ~reactClass=input,
    ~props=
      jsProps(
        ~theme,
        ~id?,
        ~name?,
        ...,
        (),
      ),
    _children,
  );
};

I'll try using genType.import and see what happens!

So, I've rewritten TextInput.re using genType.import, and now in other Reason files where I'm using TextInput, I'm getting the error Warning: Unimplemented primitive used. I rewrote the component from the above comment to look like the following - does anything look incorrect?
<EMAIL_ADDRESS>("./AntdInput", "TextInput")]
external make:
  (
    ~theme: option(T.theme)=?,
    ~id: option(string)=?,
    ~name: option(string)=?,
    'a
  ) =>
  ReasonReact.component(
    ReasonReact.stateless,
    ReasonReact.noRetainedProps,
    ReasonReact.actionless,
  ) =
  "";

Ok - I was able to adjust a few things with my file structure and now all is well! Moving to genType.import was the key - thanks for the help!


Printing problem

Hello, I am having a problem when I try printing. I have a 3 page pdf, when I print I have 4 pages in the preview, and they are blank pages, except for the date and pdf name in the top, and in the bottom I have the URL of the site where the code is implemented.
Best regards
ER

I am having this same issue....

Same for me here.
Firmas de documentos.pdf

Same for me here.


Clarify documentation of Camera3D.get_camera_transform()

Closes https://github.com/godotengine/godot-docs/issues/3407.

Thanks!


setting  a static port for type nodeport

I am having an issue setting a static port for the  ingress service when using  type nodeport on bare-metal.
Since i still want to have  a multitude of ports  options available to me I really don't want to change the range in the api server param --service-node-port-range.
I also do  not want to  update the service info manually after creation . Is there anyway of achieving this?
I know i might just be missing something in my configuration.

Hi,
We are working on a fix that will allow you to specify the NodePort in your Ingress. https://github.com/appscode/voyager/issues/128
Does that handle your use-case?

Hi  tamalsaha,
Thanks for the quick followup. Yes the fix will resolve my issue.
Thanks

Great! This is planned to be fixed in next release 3.2.0

Thanks for the update, I am looking for exactly this as well

This has been merged into master. This will be part of 3.2.0 release.

Dup #128


Update data_to_json.py

-Add doc for each function
-Verify that everything is functional
-Clean imports if needed

-Add doc for each function ✅
-Verify that everything is functional ✅
-Clean imports if needed ✅


Generated BUILD files are not formatted according to buildifier

See https://bazel-review.googlesource.com/c/continuous-integration/+/17250/2..3 for an example of result of buildifier running on 3rdparty files.

yeah, I'm not sure I really want to go all the way to making this work given buildifier exists and might even change style's later.
Our approach is to run build formatting after this tool.
I have made efforts for the output to be somewhat clean, but this is a somewhat low priority issue given very limited dev cycles.

That's fair. FTR I would be satisfied with just the shell wrapper trying to call buildifier after the generation or warning if buildifier does not exists in the path :)

that sounds good.


Update name and URL of "CAN_BUS_Shield"

This PR consists of two changes:

Change URL from https://github.com/Seeed-Studio/CAN_BUS_Shield.git to https://github.com/Seeed-Studio/Seeed_Arduino_CAN.git (companion to https://github.com/arduino/library-registry/pull/1297)
Change name from CAN-BUS Shield to CAN_BUS_Shield

Since the name change operation on the database is actually a removal followed by automated re-indexing on the next job run, the URL update will occur as a matter of course and so the only thing required from the backend maintainer is the name change procedure.
Resolves https://github.com/arduino/library-registry/issues/1295

Done:
2022/04/14 14:09:07 Loaded 4783 libraries from DB
Removing CAN-BUS Shield
Success!

Done:
2022/04/14 14:09:07 Loaded 4783 libraries from DB
Removing CAN-BUS Shield
Success!


fix(ssr): resolve with isRequire true

Description
As discussed in discord (here and here). Revert the specific change from #10371.
Additional context

cc @benmccann

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

/ecosystem-ci run

Hmm looks like this fixed vite-plugin-ssr, but Svelte (specifically SvelteKit) is still failing. Marko and Histoire is currently also failing in main.

Yeah I don't think the Svelte fail is caused by this given it failed in both cases. So something else likely caused the failure. Merging this 👍


Grafana-Dashboard mismatch

Describe the bug
Hi,
I have two Grafana instances, grafana-a in namespace-a and grafana-b in namespace-b
grafana-a is configured with the following dashboardLabelSelector:
dashboardLabelSelector:
  - matchExpressions:
      - { key: namespace, operator: In, values: [ a ] }

Similarly, grafana-b is configured with the following dashboardLabelSelector:
dashboardLabelSelector:
  - matchExpressions:
      - { key: namespace, operator: In, values: [ b ] }

Then I create two GrafanaDashboards, dashboard-a in namespace-a, with labels:
labels:
  namespace: a

and dashboard-b with labels:
labels:
  namespace: b

The operator is run in namespace-a with --scan-all flag and it has the relevant ClusterRole and ClusterRoleBinding
What I expect is to have dashboard-a loaded in grafana-a, in folder namespace-a, and dashboard-b loaded in grafana-b, in folder namespace-b.
What actually happens is I have both Grafanas loaded with both dashboard, each one in it's namespace-named folder.
Runtime (please complete the following information):

Grafana Operator Version v3.10.3
Environment: Openshift 4.6
Deployment type: deployed

@edenkoveshi This could be caused by both operators discovering both CRs. So they see both label selectors. This will be addressed by multi namespace support at some point.

We won't address this in v3 but as @pb82 it will be solved in mutli namespace https://github.com/grafana-operator/grafana-operator/pull/599.
Ping @HubertStefanski

Since this is a multi namespace support feature I will close this issue. This is something that we will add support for in 5.0
https://github.com/grafana-operator/grafana-operator/blob/master/documentation/roadmap/roadmap-v5.md


feat: add aggregations api

References CAR-XXXX
Motivation and context
New API to fetch aggregations

Is it possible to have a test?


:memo: docs: add Msty to the list of local apps

Hi, I'm adding Msty to the list of local apps. Msty is a local LLM app for Mac, Windows, and Linux - packed with many features in a simple and clean interface.
We just released a new version today with the support for Hugging Face models and deep linking. If you would like to check it out, please visit: https://msty.app.
Example deep link usage: msty://models/search/hf/TheBloke/Llama-2-7B-32K-Instruct-GGUF

Cheers,
Nikesh

Hey @nikeshparajuli, the Msty integration is now live on huggingface.co 🚀
Don't hesitate to share it with your community


Malfunctioning when entering Korean characters into an input component with required true.

⚠ IMPORTANT ⚠ Please check the following list before proceeding. If you ignore this issue template, your issue will be directly closed.

[x] Read the docs.
[X] Make sure the code is up to date. (Some bugs have been fixed in the latest code)
[X] This is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

Describe the bug
When I type '베이징', the letter '이' disappears after I type it, but reappears when I type the next letter.
It happen when Required is true. It work well when required is false.
Reproduction
Not work well.
    {
      field: 'field1',
      component: 'Input',
      label: 'Required == true',
      colProps: { span: 24 },
      rules: [{ required: true }],
      componentProps: {
        placeholder: 'placeholder',
        onChange: (e: any) => {
          requiredValue.value = e.target.value;
          console.log(e);
        },
      },
    },

Work well.
{
      field: 'field1_2',
      component: 'Input',
      label: 'Required == false',
      colProps: { span: 24 },
      componentProps: {
        placeholder: 'placeholder',
        onChange: (e: any) => {
          notRequiredValue.value = e.target.value;
          console.log(e);
        },
      },
    },

input-required-true.webm
System Info

Operating System: windows 11
Node version:  20.11.0
Package manager (npm/yarn/pnpm) and version: pnpm 8.15.2

I think it is happening due to ant design vue.

https://github.com/vueComponent/ant-design-vue/issues/7500

 option solved this issue


Manage cron jobs from different docker containers

Hi! This is a question related the the usage of the tool.
If I run crontab-ui as a docker container, could I manage (create, delete, schedule) cron jobs of different docker containers?
Tank you so much!

I believe that this was not implemented yet.


Skip already instrumented classes

The current suggestion of post-compile instrumentation in manual setup) is to instrument all class files after the Java compile task:
task instrument(type: JavaExec) {
	main = 'hu.advancedweb.scott.instrumentation.ScottClassFileTransformer'
	args = [sourceSets.main.java.outputDir.absolutePath]
	classpath = buildscript.configurations.classpath
	classpath += sourceSets.main.runtimeClasspath
}

compileJava.doLast {
	tasks.instrument.execute()
}

While it works well for full clean-build cycles, it does not plays nicely with incremental compilation. When a single source file is modified, the compileJava leaves the previous class files intact. This means that when the instrument task kicks in it'll perform instrumentation on already instrumented classes.

Ideas:

Modify the suggestion to pass only the compiled source files as arguments.
Add an option to skip the instrumentation for classes that are already modified by Scott.

Modify the suggestion to pass only the compiled source files as arguments.

Gradle does not seem to currently support this use-case: https://github.com/gradle/gradle/issues/2137

Add an option to skip the instrumentation for classes that are already modified by Scott.

There's no current use-case to allow multiple instrumentations on the same class, so I plan to add the detection to Scott without supporting an opt-in mechanism.


Surface spits out endless message in Juno

Running the surface example
N = 30
function xy_data(x, y)
    r = sqrt(x^2 + y^2)
    r == 0.0 ? 1f0 : (sin(r)/r)
end
lspace = range(-10, stop=10, length=N)
z = Float32[xy_data(x, y) for x in lspace, y in lspace]
x = y = range(0, stop=3, length=N)
surface(
    x, y, z,
    colormap = :Spectral )

works fine in the REPL, but in Juno I get a never ending error message:
...
1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0)RGB{N0f8}(1.0,1.0,1.0) RGB{N0f8}(1.0,1.0,1.0)]), 0x0000000000006200)
Fatal error:

Unfortunately the buffer is cut off so I don't know what it started out as.

I encountered something similar and the error was that ImageMagick was not found. I solved it by ]adding it. (It already was in the manifest file)

Adding ImageMagick fixed it for me too.

Great, wonder how I could make this more user friendly... I already have ImageMagick in the require, but I guess with Pkg3 it doesn't count as installed as long as you don't explicitly added it -.-. So this is likely an issue with FileIO & PKg3, where I don't immediately know how to proceed.

The other issue here is the super long printing. It took a few tens of seconds for the printing to finish in my Juno console. Maybe something needs a more concise show method?
If ImageMagick is being loaded from within FileIO, I wonder if the issue is that it's not in FileIO's REQUIRE. Though I can see how it's not sustainable to put all the packages that FileIO might load into its REQUIRE.

I wonder if you can wrap the load call (I'm assuming that's where this is happening) in a try...catch and print a more helpful error message?

I put a try catch around the offending lines like @ssfrr  recommended... That seems like a good enough workaround for now :)


Border radius in buttons group

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
Hi, small issue when i use .btn-group and the last element is dropdown with class .dropwdown not .dropdown-toggle border radius do not apply.
Screen :

Reduced test cases
Live demo : https://codepen.io/fab_wnklr/pen/OJjmozO
What operating system(s) are you seeing the problem on?
Windows, Android, iOS
What browser(s) are you seeing the problem on?
Chrome, Firefox
What version of Bootstrap are you using?
5.1.0

had no idea

You're supposed to use .dropdown-toggle here: why not using it? It works fine if you use our component as recommended.
BTW the role="group" seems inappropriate, here.

This arrow is needed for the dropdown to be discovered by users, so I'd recommend to keep it visible.
If you insist on dropping the arrow, the simplest way (without altering our codebase) is to use the border-radius utilities, in your case rounded-end. It works fine, too.
Does it seem like a reasonable solution to you?

Yes, i think it's a good solution ! But since the dropdown class exists I thought I should use it instead of override

Well, it didn't help you much, did it? 😄
Utilities are meant to apply any style easily. Using the .dropdown class this way, you may get conflicts with any further dropdown update we might make.
Using utility does exactly what you want, and only that.
So if you agree with this suggestion, may we close your PR?