[TS migration] Migrate 'IOU' page to TypeScript

Details

Fixed Issues

$https://github.com/Expensify/App/issues/25200
PROPOSAL: N/A
Tests

Split bill - Details (SplitBillDetailsPage.tsx & WithReportAndReportActionOrNotFound.tsx)

On home screen, click on the ( + ) floating action button and select Request money
Select manual, enter any valid amount and continue
Click on Split on any participant and click on Add to split
Click on Split {currency} {amount}
Click on the newly created split preview
Check that the page renders correctly and works as expected

Send money - Confirmation step (MoneyRequestConfirmationList.tsx)

On home screen, click on the ( + ) floating action button and select Send money
Enter any valid amount and continue
Select any participant and continue
Check that the confirmation page renders correctly and works as expected

NewDistanceRequestPage.tsx

Unable to test

NewRequestAmountPage.tsx

Unable to test

Offline tests

Same as tests
QA Steps

Same as tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

This PR is dependant on https://github.com/Expensify/App/pull/35253, https://github.com/Expensify/App/issues/24921 and https://github.com/Expensify/App/issues/32004

What's the status on this @pac-guerreiro ?

@fabioh8010
This is ready for re-review by our team!

Hey, looks like there's conflicts. I'll also ask if a C+ can help review this.

@pac-guerreiro Let's solve conflicts!

@srikarparsi @fabioh8010 conflicts resolved!

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Creating a split bill offline shows a continuous loading indicator on the group chat on this branch whereas on main it shows the optimistic report preview of the split request on the group chat correctly.
https://github.com/Expensify/App/assets/102477862/0c298782-b4bd-420a-9abe-5c384a337561

@pac-guerreiro bump

@fabioh8010 @c3024
All feedback addressed, thanks for your patience! 😄
The split bill bug should be resolved, as you can see below but give it a try once again just in case
https://github.com/Expensify/App/assets/48553277/164c502b-6cc5-476f-a18b-4fbb974b9b1f

Hi @c3024, can you take another look at this whenever you get a chance?

NewDistanceRequestPage.tsx

Unable to test

No changes are made to this file in this PR so I think this need not be tested. This is not being used anywhere and completely deprecated in #34610

NewRequestAmountPage.tsx

Unable to test

This is not used anywhere anymore and this will also be deprecated in #34614

@srikarparsi All yours!

@pac-guerreiro Let's merge the newest main here

@fabioh8010 @srikarparsi @blazejkustra I merged latest main to this branch

@srikarparsi kind bump 😄

Sorry about that, taking a look

No tests failed above, removing the emergency label
https://github.com/Expensify/App/assets/48188732/4ac1b282-901a-4037-80cc-6ef294efe9ef

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.59-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


nri-flex exits when named port is not found for a single container on a host

Description
nri-flex exits ungracefully when it encounters a non-zero number of containers which do not advertise a named port referenced in the flex configuration. This results in no events being published for that specific Flex config from any container on the host.
Expected Behavior
When Flex encounters an error when evaluating a container, it should skip that specific container and proceed with the remaining.
Troubleshooting or NR Diag results
Here is an excerpt of debug logs from the NewRelic infrastructure pod on which Flex was mis-behaving:
time="2020-11-30T19:14:42Z" level=debug msg="running task" component=integrations.Definition integration_name=nri-flex
time="2020-11-30T19:14:42Z" level=debug msg="running through all discovery matches" component=integrations.Definition integration_name=nri-flex
time="2020-11-30T19:14:42Z" level=debug msg="creating discovered file" component=integrations.Definition file=/tmp/discovered335663546
time="2020-11-30T19:14:42Z" level=debug msg="executing task" component=integrations.Definition integration_name=nri-flex
time="2020-11-30T19:14:42Z" level=debug msg="waiting while the integration instances run" component=integrations.runner.Group integration_name=nri-flex
time="2020-11-30T19:14:42Z" level=debug msg="running command" command=/var/db/newrelic-infra/newrelic-integrations/bin/nri-flex component=integrations.Executor env="[PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin HOSTNAME=<REDACTED> NRIA_LICENSE_KEY=<HIDDEN> CLUSTER_NAME=<REDACTED> ETCD_TLS_SECRET_NAMESPACE=<HIDDEN> NRIA_DISPLAY_NAME=<REDACTED> NRK8S_NODE_NAME=<REDACTED> NRIA_CUSTOM_ATTRIBUTES= NRIA_PASSTHROUGH_ENVIRONMENT=<HIDDEN> ROUTE53_PUBLIC_XXX_EXTERNAL_DNS_SERVICE_PORT_HTTP=7979 ROUTE53_PRIVATE_XXX_EXTERNAL_DNS_SERVICE_HOST=<IP_ADDRESS> ROUTE53_PRIVATE_XXX_EXTERNAL_DNS_SERVICE_PORT=7979 KUBE_STATE_METRICS_SERVICE_PORT=8080 ROUTE53_PUBLIC_XXX_EXTERNAL_DNS_PORT_7979_TCP_PROTO=tcp KUBE_STATE_METRICS_PORT=tcp://<IP_ADDRESS>:8080 KUBE_STATE_METRICS_PORT_8080_TCP_PORT=8080 KUBERNETES_SERVICE_HOST=<IP_ADDRESS> KUBERNETES_PORT_443_TCP_PROTO=tcp ROUTE53_PUBLIC_XXX_EXTERNAL_DNS_SERVICE_HOST=<IP_ADDRESS> ROUTE53_PRIVATE_XXX_EXTERNAL_DNS_PORT_7979_TCP=tcp://<IP_ADDRESS>:7979 KUBERNETES_SERVICE_PORT_HTTPS=443 ROUTE53_PUBLIC_XXX_EXTERNAL_DNS_PORT_7979_TCP=tcp://<IP_ADDRESS>:7979 KUBE_STATE_METRICS_PORT_8080_TCP_PROTO=tcp ROUTE53_PRIVATE_XXX_EXTERNAL_DNS_PORT=tcp://<IP_ADDRESS>:7979 KUBERNETES_PORT_443_TCP=tcp://<IP_ADDRESS>:443 KUBERNETES_PORT_443_TCP_ADDR=<IP_ADDRESS> ROUTE53_PUBLIC_XXX_EXTERNAL_DNS_PORT_7979_TCP_PORT=7979 ROUTE53_PRIVATE_XXX_EXTERNAL_DNS_SERVICE_PORT_HTTP=7979 ROUTE53_PRIVATE_XXX_EXTERNAL_DNS_PORT_7979_TCP_PROTO=tcp KUBE_STATE_METRICS_SERVICE_HOST=<IP_ADDRESS> KUBE_STATE_METRICS_SERVICE_PORT_HTTP=8080 KUBE_STATE_METRICS_PORT_8080_TCP_ADDR=<IP_ADDRESS> ROUTE53_PUBLIC_XXX_EXTERNAL_DNS_SERVICE_PORT=7979 ROUTE53_PUBLIC_XXX_EXTERNAL_DNS_PORT=tcp://<IP_ADDRESS>:7979 ROUTE53_PUBLIC_XXX_EXTERNAL_DNS_PORT_7979_TCP_ADDR=<IP_ADDRESS> ROUTE53_PRIVATE_XXX_EXTERNAL_DNS_PORT_7979_TCP_PORT=7979 KUBE_STATE_METRICS_PORT_8080_TCP=tcp://<IP_ADDRESS>:8080 KUBERNETES_SERVICE_PORT=443 KUBERNETES_PORT=tcp://<IP_ADDRESS>:443 KUBERNETES_PORT_443_TCP_PORT=443 ROUTE53_PRIVATE_XXX_EXTERNAL_DNS_PORT_7979_TCP_ADDR=<IP_ADDRESS> NRIA_IS_CONTAINERIZED=true NRIA_OVERRIDE_HOST_ROOT=/host HOME=/root HOST_PROC=/host/proc HOST_SYS=/host/sys HOST_ETC=/host/etc HOST_VAR=/host/var DBUS_SYSTEM_BUS_ADDRESS=unix:path=/host/var/run/dbus/system_bus_socket NRK8S_NODE_NAME=<REDACTED> ETCD_TLS_SECRET_NAMESPACE=<HIDDEN> KUBE_STATE_METRICS_PORT=tcp://<IP_ADDRESS>:8080 METRICS=1 CONFIG_PATH=/tmp/discovered335663546 KUBERNETES_SERVICE_HOST=<IP_ADDRESS> KUBERNETES_SERVICE_PORT=443 CLUSTER_NAME=<REDACTED> PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin]" path=/var/db/newrelic-infra/newrelic-integrations/bin/nri-flex
time="2020-11-30T19:14:42Z" level=debug msg="running task" component=integrations.Definition integration_name=nri-flex
time="2020-11-30T19:14:42Z" level=error msg="can't start integration" component=integrations.runner.Group error="value not found: discovery.ports.admin" integration_name=nri-flex
time="2020-11-30T19:14:42Z" level=debug msg="time=\"2020-11-30T19:14:42Z\" level=info msg=com.newrelic.nri-flex GOARCH=amd64 GOOS=linux version=1.3.1" component=integrations.runner.Group integration_name=nri-flex

Steps to Reproduce

Deploy two Kubernetes pods on a single worker node. One pod should have expose a port named admin, while the other should not.
Deploy a NewRelic Infrastructure pod with the following Flex configuration:

    discovery:
      command:
        exec: /var/db/newrelic-infra/nri-discovery-kubernetes --tls --port 10250
    integrations:
    - config:
        apis:
        - event_type: CustomMetricsSample
          url: http://${discovery.ip}:${discovery.ports.admin}/metrics
        global:
          headers:
            accept: application/json
        name: custom-metrics-flex
      env:
        METRICS: 1
      interval: 60s
      name: nri-flex

Flex will emit message similar to the following:

time="2020-11-30T06:58:33Z" level=error msg="can't start integration" component=integrations.runner.Group error="value not found: discovery.ports.admin" integration_name=nri-flex

Your Environment
NewRelic Infrastructure: 1.11.45
Flex: 1.3.1
Cloud Provider: AWS
Kubernetes: 1.17.9 (EKS)
Docker: 19.3.6

Oh wait, sorry, just realised what you meant. The error is expected behavior as the agent is attempting to connect to every pod that the nri-discovery-kubernetes has discovered. You need to have a match section to exclude the pods you are not interested (or a match to only match those you care about). The discovery part is not smart enough to realise that one of the matches is not a valid match as it has no admin port.


Trim ingress hostnames to 63 chars to make sure domain is valid

What does this PR do?
Trims ingress hostname dns parts if they are over 63 chars, to ensure that they are accessible. Commits:

Move all ingress metadata-provisioning code into one place, as it was previously in multiple places
Do the same as above but for services
Trim ingress hostname to max 63 chars.

What issues does this PR fix or reference?
Fixes https://github.com/eclipse/che/issues/15728
Is it tested? How?
Tested on minikube 1.7.2

I'm merging this PR as-is because the case I'm trying to address I encounter with the default namespace (che-workspace-controller) and this breaks che-machine-exec; the potential downsides are remote for current use-cases.
I agree that we should come up with a better scheme for defining workspace ingress hostnames, though, perhaps as a part of https://github.com/eclipse/che/issues/15990


New issue

Hey this is a new issue, take a look at this
(idk add some stuff if we need to)

Ok, I'll check it out.


ES "quit" event no loger working correctly after update to v38 of Batocera on Pi4

I have the following script:
#!/bin/bash

. /etc/profile.d/xdg.sh
. /etc/profile.d/dbus.sh

stop_audioconfig() {
	VOLUME=$(batocera-audio getSystemVolume)
        (sleep 25.5 && shutdown -h now) & /etc/init.d/S06audio reload && /usr/bin/batocera-audio setSystemVolume "${VOLUME}"
        sleep 0.5 && /usr/bin/mpv --player-operation-mode=pseudo-gui --keep-open=yes --stop-playback-on-init-failure=no --ontop --really-quiet --audio-exclusive=yes --no-config --fullscreen --no-osd-bar --cursor-autohide=always /userdata/shutdown/shutdown.mp4

     }

trap 'stop_audioconfig' EXIT

in the following location:
/userdata/system/configs/emulationstation/scripts/quit/shutdown.sh

The was working in v37 just fine, it would play my full video and then shut down. However, after updating Batocera to v38, now the script plays a short 1 to 1.5 seconds (of the 25s video) before the system just shuts down.
I have simplified this down to just:
#!/bin/bash

/usr/bin/mpv --fs /userdata/shutdown/shutdown.mp4

And it plays maybe 2 seconds of my video before shutting down.

It's still working... It's just that EmulationStation is not waiting anymore for the scripts to end...
It was changed because there were lags with many scripts.

So you're saying that, even if my shutdown script to rsync changes to /userdata to <IP_ADDRESS>:/mnt/Seagate_10TB/tier2/batocera_backups/backups/ hadn't stopped working with the v38 update, Batocera would force the issue and kill it mid-backup?

Fixed it making quit event waitable


Updated nlu based on review

@stevemar @RahulReddyRavipally Can one of you check and merge the pull request?
Added code to NLU sample:

Check for https:// in the incoming URL or append programmatically
Formatted the Python code for better readability


Issue obtaining all clients

There is a problem obtaining all OpenID Clients via CLI.
NOTE: Issue doesn't happen when we call Config REST API directly.
Calling Api with parameters: {'limit': 50}
Please wait while retreiving data ...

Getting access token for scope https://jans.io/oauth/config/openid/clients.readonly
Traceback (most recent call last):
  File "./jca-cli.py", line 1324, in <module>
    cliObject.runApp()
  File "./jca-cli.py", line 1317, in runApp
    self.display_menu(self.menu)
  File "./jca-cli.py", line 990, in display_menu
    self.display_menu(menu.get_child(int(selection) -1))
  File "./jca-cli.py", line 994, in display_menu
    getattr(self, 'process_' + m.method)(m)
  File "./jca-cli.py", line 622, in process_get
    self.display_menu(endpoint.parent)
  File "./jca-cli.py", line 994, in display_menu
    getattr(self, 'process_' + m.method)(m)
  File "./jca-cli.py", line 622, in process_get
    self.display_menu(endpoint.parent)
  File "./jca-cli.py", line 994, in display_menu
    getattr(self, 'process_' + m.method)(m)
  File "./jca-cli.py", line 622, in process_get
    self.display_menu(endpoint.parent)
  File "./jca-cli.py", line 988, in display_menu
    self.display_menu(menu.parent)
  File "./jca-cli.py", line 990, in display_menu
    self.display_menu(menu.get_child(int(selection) -1))
  File "./jca-cli.py", line 994, in display_menu
    getattr(self, 'process_' + m.method)(m)
  File "./jca-cli.py", line 593, in process_get
    api_response = api_caller(**parameters)
  File "/home/ec2-user/jans-cli/swagger_client/api/o_auth___open_id_connect___clients_api.py", line 150, in get_oauth_openid_clients
    (data) = self.get_oauth_openid_clients_with_http_info(**kwargs)  # noqa: E501
  File "/home/ec2-user/jans-cli/swagger_client/api/o_auth___open_id_connect___clients_api.py", line 223, in get_oauth_openid_clients_with_http_info
    collection_formats=collection_formats)
  File "/home/ec2-user/jans-cli/swagger_client/api_client.py", line 321, in call_api
    _preload_content, _request_timeout)
  File "/home/ec2-user/jans-cli/swagger_client/api_client.py", line 160, in __call_api
    return_data = self.deserialize(response_data, response_type)
  File "/home/ec2-user/jans-cli/swagger_client/api_client.py", line 232, in deserialize
    return self.__deserialize(data, response_type)
  File "/home/ec2-user/jans-cli/swagger_client/api_client.py", line 249, in __deserialize
    for sub_data in data]
  File "/home/ec2-user/jans-cli/swagger_client/api_client.py", line 249, in <listcomp>
    for sub_data in data]
  File "/home/ec2-user/jans-cli/swagger_client/api_client.py", line 271, in __deserialize
    return self.__deserialize_model(data, klass)
  File "/home/ec2-user/jans-cli/swagger_client/api_client.py", line 616, in __deserialize_model
    instance = klass(**kwargs)
  File "/home/ec2-user/jans-cli/swagger_client/models/client.py", line 269, in __init__
    self.client_name = client_name
  File "/home/ec2-user/jans-cli/swagger_client/models/client.py", line 731, in client_name
    raise ValueError("Invalid value for `client_name`, must not be `None`")  # noqa: E501
ValueError: Invalid value for `client_name`, must not be `None`

Fixed, by  commit https://github.com/JanssenProject/jans-setup/commit/228f0b6f79ab48c7f7f79577026c01bb1632c263

Fixed, by  commit https://github.com/JanssenProject/jans-setup/commit/228f0b6f79ab48c7f7f79577026c01bb1632c263

Thanks! Is this fix included in Cloud Native version of config-api?

Thanks! Is this fix included in Cloud Native version of config-api?

Since it is not intended to add a client via ldap query, and other methods (api,oxd) checks existence of displayName, this is not a problem.

Since it is not intended to add a client via ldap query, and other methods (api,oxd) checks existence of displayName, this is not a problem.

Since it is not intended to add a client via ldap query, and other methods (api,oxd) checks existence of displayName, this is not a problem.

I was not suggesting to put check on the query API. My suggestion was to put check in the CREATE / UPDATE operations to avoid such records to even get to LDAP in first place.

Since it is not intended to add a client via ldap query, and other methods (api,oxd) checks existence of displayName, this is not a problem.

I was not suggesting to put check on the query API. My suggestion was to put check in the CREATE / UPDATE operations to avoid such records to even get to LDAP in first place.


[GUIDE] How the priority system works, and what changes from v1.15.0 onwards

I should have put more emphasis on this when I changed the wording from "bookmark" to "priority", and I should have documented it better than in a screenshot on Reddit: the recipes you put into the priority list receive priority over recipes that are not when the tool makes suggestions, and this also affects all their sub-components. There is actually a bug/oversight which causes base mods to not be prioritized (this is fixed in v1.15 onwards). This means that it's enough to put the highest point of a chain into the prio-list -- you don't have to put the whole chain into it.
The idea behind the prio-list is to set up a set of four archnemesis mods that you want to run "fully juiced", i.e. those big wombo-combos that you see on Reddit and such. The tool would then suggest a fast route to finish these mods but also other ready recipes in case none of the prioritized ones are ready.
Beginning with v1.15, the tool will try to suggest the shortest path to completing this prio-set, i.e. it will not suggest completing a recipe if you have already reached the required number of that mod. As an example:

A set of Innocence-, Kitava-, and Shakari-touched requires 4 Gargantuans (2x emp. minions, 1x rejuvenating, 1x soul eater)
you already have one emp. minions, so you'll only need an additional three Gargantuans
if you drop one, the tool will put emp. minions (if you have the rest of the components ready) at the top of the ready-list and stop suggesting it once you complete it; from now on, all gargantuans will go to the other prio-recipes
these are two major differences to how it currently works:

no more suggestions beyond what is needed
prioritized bases will not be used for un-prioritized recipes anymore

Now this may lead to another problem, namely bottleneck-situations where there is a surplus in one branch and a dry-streak in another. I will try to implement various ways around surplus handling in the future -- people have suggested setting X sets as thresholds before stopping suggestions. Maybe I'll let the user choose if they want the quickest way to completing the set or just the most consistent recipe suggestions to burn through. As a workaround for the time being, I have added number indicators to the tree-view to show quantities of all the mods. This way you can monitor a possible surplus and plan around that. I'll also take a look at the possibility of a tree-view for the whole prio-list. If that's feasible and usable, I'll put that in.
What has not changed is the fact that there is actually a priority ranking within the priority list itself. The tool will allocate base mods to the recipe in the first slot and then work its way down. This is especially important when one recipe in the prio-list is finished (it's then highlighted in green). You should always at least re-add a finished recipe to the list so that it's in last place. It would be better to even remove it, but this would mean putting its components into the un-prio pool. It's a matter of what's more important -- completing the current set as fast as possible, or having a bit of surplus for the next set?

Thanks for your hard work!


[Feature] Port for safari

can you possibly port this for safari? it's soo good...

I use Linux and have no way to test on Safari. I would be more than happy if someone with a Mac can chime in and test it for Safari and/or make a PR for it :smiley:


SAP GTT implementation // package created for SAP GTT cannot be uninstalled

Hi everybody,
we downloaded SAP sample coding for SAP GTT and tried to install and fix the bugs.
However, we need to uninstall it and get the issue with the AVAS objects.
You can reproduce this issue by doing following steps.

TC: SE38 -> ZABAPGIT_STANDALONE
Execute
Select and click on GTT_Code
Select "Advanced”.
Click on "Uninstall”.
Error message will be displayed
"AVAS invalid data//Deletion of object .... failed"
best regards
Vitali

What's the url for the repo?

Do you mean this one?
https://github.com/SAP-samples/logistics-business-network-gtt-standardapps-samples

I can't test this since it requires full ERP or S4HANA which I don't have access to.
AVAS install and uninstall in general works fine. Please test with https://github.com/abapGit-tests/AVAS.
Try to reduce the issue to a minimal example repo (without ERP). Then I can help.

Hi mbtools,
I am also working with Vitali together on this problem. Could you explain me how I could reduce this example or what exactly I should do?
You could check the following PDF:
https://drive.google.com/file/d/1cEB3q7I1tI1en_8Q-6jJ6UATuqfanUvs/view?usp=sharing
After UNINSTALL there are 11 objects remaining. When I go to SE80 all packages are still there, but when I click to delete some object in the package the message is shown that it does not exist. Also I could not delete the package itself.
Is there a possibility to delete those 11 objects manually or in SE80 to delete the whole package?

Packages:
Transportable packages can't be deleted in one step. First all objects have to be deleted and the  corresponding transport has to be released. Then you can delete the empty packages (in abapGit or SE80).
AVAS:
This needs further investigation. Can you create a repo with just one of these tables and AVAS objects and try to reproduce the issue with this?

Do you need more help?

Hi,
thanks a lot for the valuable input. We solved that issue.
regards
Vitali


Display supported version if rule is disabled in particular RF version

Closes #507
Currently the logic is:

If the rule is enabled, always show (enabled) next to rule name (when using --list)
If the rule is disabled but not because of the RF version - show (disabled)
If the rule is disabled because it's not supported in used RF version - show (disabled - enabled for RF version x) (x = <4.0 etc)

Codecov Report

Merging #532 (012cb69) into master (f8a835d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #532   +/-   ##
=======================================
  Coverage   97.67%   97.68%
=======================================
  Files          23       23
  Lines        2539     2544    +5
=======================================
+ Hits         2480     2485    +5
  Misses         59       59

Impacted Files
Coverage Δ

robocop/rules.py
98.36% <100.00%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a835d...012cb69. Read the comment docs.


Update tutorial-kubernetes-deploy-application.md

It is line 57 which shows the below that you have to replace with your own Azure ACR name
" image: microsoft/azure-vote-front:v1"

@thomast1906 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Nickomang  can you look at as part of your review?

@Nickomang  can you look at as part of your review?

@thomast1906, thanks for the feedback. This update is being included as part of a larger PR encompassing numerous changes to the article. You can expect to see it live on the docs site by the end of the week.
#please-close

@thomast1906, thanks for the feedback. This update is being included as part of a larger PR encompassing numerous changes to the article. You can expect to see it live on the docs site by the end of the week.
#please-close


swaygrab: Add support for custom filetypes

Adds the option -t, --type <filetype> which can be used to select the
filetype of the produced image/video.
This will only take effect if you don't pass a filename to swaygrab e.g.
let swaygrab use the default date based filename.

Nah. If you want to specify the filetype, just specify the whole filename.


fix: The quiet and format options of the 'docker ps' command cannot b…

…e used simultaneously
with docker version=24.0.5, Using both the "quiet" and "format" options with the "docker ps" command will result in the following warning message being output:
docker ps --quiet --all --format {{.ID}}
WARNING: Ignoring custom format, because both --format and --quiet are set.
6c227a4634ed
13c9655df5ab
bc0e9b0cfeb2
750ea4be0ee1

This will lead to an error when executing the "curveadm client map" command, as the aforementioned warning output could be mistaken for the volume container already being installed. However, in reality, the "docker ps" command output list is empty.
Error-Code: 420000
Error-Description: volume already mapped
Error-Clue: volume: work:/abc

The problem has been fixed, but the code has not been merged yet.


Switch to use GitHub Actions from Travis

We've been having issues with Travis reporting. I think that this should be a drop in replacement.
To merge this we'll also have to update the required status checks on the protected branch master.

Yes, yes, yes!  Thanks @tfoote!  Will review.

Great minds think alike. I like splitting linting and other tests. One thing I noticed when experimenting with Windows builds in the matrix is that the default runners seem to abort all builds when the first one fails. I haven't looked for how to change that behavior yet so I don't know if we can.

When I went to update the protected branches I noticed the naming was all off so I cleaned that up too. We can give it a shot. it looks like with the required tests switched that outstanding PRs will need a manual review to make sure travis passed. But that count should drop away quickly.


Model property with decimal cast (numeric-string) does not accept float or int

Larastan Version: 2.9.2
--level used: 3

Description
Hello!
First off, I'm not sure if this is a Larastan issue or a PHPStan issue, but here goes:
On PHPStan level 3, types assigned to properties are checked. In my work codebase, we use the decimal model cast somewhat occasionally (mainly on prices and other things that need a guaranteed precision). However, I'm now running into an error where I cannot assign any numerical value to the property:

Property LineItem::$agreed_price (numeric-string|null) does not accept float.

Type int and literals (0, 0.) are not accepted either.
The only way to fix this that I've found is to cast it to a string but that's not really something I'd like to do all over.
Thoughts?
Laravel code where the issue was found
class LineItem extends Model
{
    protected $casts = ['agreed_price' => 'decimal:2'];
}
// ...

// error
$lineItem->agreed_price = $quantity * $discountPrice;
// works, but ugly
$lineItem->agreed_price = (string) $quantity * $discountPrice;
// works, but verbose and I'd rather not have to repeat the precision around the codebase
$lineItem->agreed_price = number_format($quantity * $discountPrice, 2);

P.S. I'm making the push to bring my work codebase up to PHPStan level 3...so there will likely be several issues as I run into things that aren't easily fixable.
CC: @ondrejmirtes
Thanks!

Hi,
The decimal cast in Laravel casts the value to a string. And in Larastan we represent that with numeric-string So it makes it does not accept float.
But if Laravel works in a way that, decimal casted fields accept float then we can adjust the writeable type for those properties in Larastan 👍🏽

So it looks like Laravel will auto cast values---not sure how far down the writable rabbit hole you want to go down.
/*
    protected $casts = [
        'agreed_price'      => 'decimal:2',
        'warehouse_pending' => 'boolean',
    ];
*/

$l = LineItem::factory()->create();

dump($l->agreed_price); //? "18.02"
dump($l->warehouse_pending); //? false
$l->agreed_price = 50;
$l->warehouse_pending = 1;
dump($l->agreed_price); //? " 50.00"
dump($l->warehouse_pending); //? true

Same thing for collections/arrays/json etc.


Outdated documentation to be revised

Below is a list of documentation ambiguities and issues i've ran across while reading through.
List of issues and whether they've been fixed:

[ ] Fibonacci Example
[ ] Hello World Example
[ ] Interest Calculator Example
[ ] Futurization Example

Fibonacci.html
under the hpx_main() code block here , the description looks outdated. Code segment:
int hpx_main(boost::program_options::variables_map& vm)
{
    // extract command line argument, i.e. fib(N)
    boost::uint64_t n = vm["n-value"].as<boost::uint64_t>();

    {
        // Keep track of the time required to execute.
        hpx::util::high_resolution_timer t;

        // Wait for fib() to return the value
        fibonacci_action fib;
        boost::uint64_t r = fib(hpx::find_here(), n);

        char const* fmt = "fibonacci(%1%) == %2%\nelapsed time: %3% [s]\n";
        std::cout << (boost::format(fmt) % n % r % t.elapsed());
    }

    return hpx::finalize(); // Handles HPX shutdown
}

Documentation explanation:

Upon a closer look we see that the hpx::future<> we created is assigned the return of
hpx::async<fibonacci_action>(hpx::find_here(), n). hpx::async<>(), and asynchronously kicks of the computation of the action (fibonacci_action), returning a future which represents the result of the computation. But wait, what is an action? And what is this fibonacci_action? For starters, an action is a wrapper for a function. By wrapping functions, HPX can send packets of work to different processing units. These vehicles allow users to calculate work now, later, or on certain nodes. The first argument to hpx::async<>() is the location where the action should be run. In this case, we just want to run the action on the machine that we are currently on, so we use hpx::find_here(). To further understand this we turn to the code to find where fibonacci_action was defined:

Looks like fibonacci.cpp was recently refactored, but the docs weren't updated to reflect these new changes. r is no longer of type hpx::future<> and the right hand side only calls the action fib, there are no longer async calls. Can someone explain what this new code segment is doing so the docs can be updated properly?
Hello_world.html
For the explanation of this line in hello_world.html, the description of the callback seems to be outdated:

hpx::lcos::wait_each() invokes a callback function provided by the user, supplying the callback function with the index of the future in the std::vector<> and the result of the future

from my understanding, hpx::lcos::wait_each() does not supply the callback with the index of the future, only the result of the future. This might have never been updated when the example was changed from using wait()?
Interest_calculator.html
Given the code segment:
double init_principal=vm["principal"].as<double>(); //Initial principal
double init_rate=vm["rate"].as<double>(); //Interest rate
int cp=vm["cp"].as<int>(); //Length of a compound period
int t=vm["time"].as<int>(); //Length of time money is invested

init_rate/=100; //Rate is a % and must be converted
t/=cp; //Determine how many times to iterate interest calculation:
       //How many full compund periods can fit in the time invested

shared_future<double> principal = make_ready_future(init_principal);
shared_future<double> rate = make_ready_future(init_rate);

for (int i = 0; i < t; ++i)
{
    shared_future<double> interest = dataflow(unwrapped(calc), principal, rate);
    principal = dataflow(unwrapped(add), principal, interest);
}

// wait for the dataflow execution graph to be finished calculating our
// overall interest
double result = principal.get();

std::cout << "Final amount: " << result << std::endl;
std::cout << "Amount made: " << result-init_principal << std::endl;

The description in the documentation reads:

Here we find our command line variables read in, the rate is converted from a percent to a decimal, the number of calculation iterations is determined, and then our dataflows are set up. Notice that we first place our principal and rate into a dataflow by passing the variables p and i_rate to an action called identity_action:

There is no identity_action, or p, or i_rate present in this example. Going back in history it looks likeFuturization

p is now init_principal
i_rate is now init_rate
The example uses shared futures now, there is no mention of this

Futurization Example
In example 2, under the first code section the paragraph reads

In example 2, we re-define our partition type as a shared_future and, in main, create the object "result" which is a future to a vector of partitions. We use result to represent the last vector in a string of vectors created for each timestep. In order to move to the next timestep, the values of a partition and its neighbors must be passed to heat once the futures that contain them are ready. In HPX, we have an LCO (Local Control Object) named Dataflow which assists the programmer in expressing this dependency. Dataflow allows us to pass the results of a set of futures to a specified function when the futures are ready. Dataflow takes three types of arguments, one which instructs the dataflow on how to perform the function call (async or sync), the function to call (in this case Op), and futures to the arguments that will be passed to the function. When called, dataflow immediately returns a future to the result of the specified function. This allows users to string dataflows together and construct an execution tree.

there are no objects named result inside of the example

Examples section is often the first place where people go. It would be nice to get it updated.

Issue was resolved by #1798


Fixing MRD Multi-echo swapping error

Fix Multi Echo Error as mentioned by Peter

Discovered during Peter's analysis of our first LCH subject
* Peter indicates we have mixed up our gas/dissolved contrast in MRD
* Contrast 1, Set 1 – Gas first echo
* Contrast 2, Set 1 – Gas second echo (should be dissolved first echo)
* Contrast 1, Set 2 – Dissolved first echo (should be gas second echo)
* Contrast 2, Set 2 – Dissolved second echo


Compiler does not recognize an uninitialized instance variable when a constructor from a superclass is involved

Considering the following two classes (crystal 0.21.0):
class Foo
  property other : String
  property size : Int32
  def initialize(other)
    initialize(other, other.size)
  end

  def initialize(@other, @size)
  end
end

class Bar < Foo
  property value : String

  def initialize(value)
    initialize("hi", 2)
  end

  def initialize(@value, other : String)
    super(other)
  end
end

Bar.new("break!")

The compiler should complain that the instance variable @value is not set in the first constructor of Bar, but it doesn't. Instead the code compiles and results in an invalid memory access at runtime.
I guess the compiler wrongly assumes the call to initialize("hi", 2) would invoke the second constructor of Bar and thus initialize the instance variable. It seems it does not realize the type restrictions result in the constructor of Foo being invoked instead and @value will not be initialized.
This might be related to #4147 which I filed earlier today. But I encountered both issues in different circumstances.

Here's a slightly shorter test case:
class Foo
  def initialize(x : String, y : Int32)
  end
end

class Bar < Foo
  getter value

  def initialize
    initialize("x", 1)
  end

  def initialize(@value : String, y : String)
  end
end

puts Bar.new.value

In Crystal 0.31.1 on MacOS
$ crystal --version
Crystal 0.31.1 (2019-10-02)

LLVM: 8.0.1
Default target: x86_64-apple-macosx

Johannes' original example is not producing invalid memory access at runtime anymore. The output is empty.
Ryan's example however still causes Invalid memory access.

Yeah it's the .value call. Adding that in my example produces invalid memory access as well.

Can you update your example please to avoid confusion?


[test] Add rom_e2e_flash_ctrl_init test.

Add the rom_e2e_flash_ctrl_init test (as described in the ROM e2e testplan). Resolves https://github.com/lowRISC/opentitan/issues/14500
Note: in the rom_e2e_testplan.hjson, the keymgr_init e2e test was actually already under the flash_ctrl testplan entry; I assumed this was a mistake and moved it to the keymgr_init entry just below.

one last thing, regarding a lot of tests for flash_init and keymgr, you guys are probably going to be impacted by this PR whenever it lands. See #15776
Maybe we should discuss a bit on how we should coordinate this change.

Note: in the rom_e2e_testplan.hjson, the keymgr_init e2e test was actually already under the flash_ctrl testplan entry; I assumed this was a mistake and moved it to the keymgr_init entry just below.

Thanks @jadephilipoom! Yes, looks like it was a mistake.

one last thing, regarding a lot of tests for flash_init and keymgr, you guys are probably going to be impacted by this PR whenever it lands. See #15776
Maybe we should discuss a bit on how we should coordinate this change.

What exactly is the scope of this change? If it's just changing the reset values then it shouldn't impact this test, at least -- the flash controller doesn't seem to rely on the reset values anywhere.

one last thing, regarding a lot of tests for flash_init and keymgr, you guys are probably going to be impacted by this PR whenever it lands. See #15776
Maybe we should discuss a bit on how we should coordinate this change.

What exactly is the scope of this change? If it's just changing the reset values then it shouldn't impact this test, at least -- the flash controller doesn't seem to rely on the reset values anywhere.

Please see @tjaychen's clarification here. I don't think this PR is affected since we are not working with concrete expected values for keymgr outputs.

Summarizing an offline conversation with @alphan -- I now removed all checks related to kFlashCtrlInfoPageCreatorSecret because as of #15147 the lockdown of creator-secret pages is in ROM_EXT, not ROM. I also removed that check from the list in the testplan HJSON file.


[Event Hubs] Fix for sequence number = 0 bug.

This PR is meant to fix this issue in which you can find all the details.

@azure/event-hubs
Falsy value of offset and sequence number (= 0) are causing the EventProcessor to set the wrong eventPosition that is falledback to the defaultEventPosition or EventPosition.earliest().
Checking for the != null, instead (which both cover undefined and null).
Version of library and changelog.md were not updated on purpose since the current version pushed in the code is 5.0.0-preview.7 but the published next version is next: 5.0.0-preview.6.

@azure/eventhubs-checkpointstore-blob
Falsy value of offset and sequence number were causing the checkpoint to be listed with -1 and to be claimed with empty string "", when calling the bobClient.setMetadata.
Version of library and changelog.md were not updated on purpose since the current version pushed in the code is 1.0.0-preview.5 but the published next version is next: 1.0.0-preview.4.

Thanks for logging the issue, root causing the problem and submitting the PR @marcodalessandro!
@chradek, @richardpark-msft Please review


doc: update badges

Fixes https://github.com/ExpediaDotCom/graphql-kotlin/issues/125

Add javadoc badge
Update maven central badge to the recommended one on the side bar here: https://search.maven.org/artifact/com.expedia/graphql-kotlin

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #126   +/-   ##
=========================================
  Coverage     90.49%   90.49%
  Complexity      157      157
=========================================
  Files            47       47
  Lines           505      505
  Branches        112      112
=========================================
  Hits            457      457
  Misses           10       10
  Partials         38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba32265...8913a05. Read the comment docs.


Provide an API to obtain the available connectors

Description
This PR introduces the following changes:

Added a getConnectors API to retrieve the available connectors.
Modified the getAvailableNodes function to consider the project path, ensuring that available nodes are generated based on the line position.

Closing this as the changes are introduced with https://github.com/ballerina-platform/ballerina-dev-tools/pull/386


T8530 Smart Lock w/ video, code, and fingerprint access - and base station (T8021)

I have a brand new T8530. Looks like it isn't supported. Can I help get support for this device added?
I've followed the instructions for setup. It is running the latest Firmware: <IP_ADDRESS> as of 9/17.
I would be happy to share my Eufy home with you (this, and the base for it, are the only Eufy devices I currently have) according to the instructions on the readme if you will acknowledge that this is something that is doable. I can probably also help with debug from this end if there is anything you would like me to do to help.
Again, I haven't yet share the device with you. I will. Just let me know if and when you would like me to do that.

Thanks for bringing this up. Can you check if eufy-security-client repository supports your device? If not, please work repository owner  @bropat and after he finishes it, let me know

Will do.

Since I have add this device, my integration is not loading properly anymore, I have this error when I start itStart Listening was not completed in timely manner
Here the log from HA
Logger: homeassistant.config_entries Source: config_entries.py:1105 First occurred: 13:03:24 (1 occurrences) Last logged: 13:03:24 Config entry 'localhost' for eufy_security integration not ready yet: Start Listening was not completed in timely manner; Retrying in background
2nd error, it will maybe help you to add the lock to your integration
Logger: custom_components.eufy_security Source: custom_components/eufy_security/websocket.py:59 Integration: Eufy Security (documentation, issues) First occurred: 13:01:28 (11 occurrences) Last logged: 13:09:57 eufy_security - Exception - process_messages: 55 is not a valid DEVICE_TYPE - traceback: Traceback (most recent call last): File "/config/custom_components/eufy_security/websocket.py", line 57, in process_messages await self.on_message(msg) File "/config/custom_components/eufy_security/websocket.py", line 68, in on_message await self.message_callback(message) File "/config/custom_components/eufy_security/coordinator.py", line 313, in on_message await self.process_get_device_properties_response( File "/config/custom_components/eufy_security/coordinator.py", line 260, in process_get_device_properties_response device.set_properties(properties) File "/config/custom_components/eufy_security/const.py", line 446, in set_properties type = DEVICE_TYPE(self.type_raw) File "/usr/local/lib/python3.10/enum.py", line 385, in __call__ return cls.__new__(cls, value) File "/usr/local/lib/python3.10/enum.py", line 710, in __new__ raise ve_exc ValueError: 55 is not a valid DEVICE_TYPE - message: WSMessage(type=<WSMsgType.TEXT: 1>, data='{"type":"result","success":true,"messageId":"get_device_properties","result":{"serialNumber":"T8530K1022290C64","properties":{"name":"Porte maison","model":"T8530","serialNumber":"T8530K1022290C64","type":55,"hardwareVersion":"P1","softwareVersion":"<IP_ADDRESS>","stationSerialNumber":"T8021P1122260DF9"}}}', extra='')

Hello
I have exactly the same issue with the video smart lock:
Logger: custom_components.eufy_security
Source: custom_components/eufy_security/websocket.py:59
Integration: Eufy Security (documentation, issues)
First occurred: 2:34:44 PM (28 occurrences)
Last logged: 3:13:26 PM
eufy_security - Exception - process_messages: 55 is not a valid DEVICE_TYPE - traceback: Traceback (most recent call last): File "/config/custom_components/eufy_security/websocket.py", line 57, in process_messages await self.on_message(msg) File "/config/custom_components/eufy_security/websocket.py", line 68, in on_message await self.message_callback(message) File "/config/custom_components/eufy_security/coordinator.py", line 313, in on_message await self.process_get_device_properties_response( File "/config/custom_components/eufy_security/coordinator.py", line 260, in process_get_device_properties_response device.set_properties(properties) File "/config/custom_components/eufy_security/const.py", line 446, in set_properties type = DEVICE_TYPE(self.type_raw) File "/usr/local/lib/python3.10/enum.py", line 385, in call return cls.new(cls, value) File "/usr/local/lib/python3.10/enum.py", line 710, in new raise ve_exc ValueError: 55 is not a valid DEVICE_TYPE - message: WSMessage(type=<WSMsgType.TEXT: 1>, data='{"type":"result","success":true,"messageId":"get_device_properties","result":{"serialNumber":"T8530K1022290622","properties":{"name":"Front Door","model":"T8530","serialNumber":"T8530K1022290623","type":55,"hardwareVersion":"P1","softwareVersion":"<IP_ADDRESS>","stationSerialNumber":"T8021P10213012AB"}}}', extra='')

#437

Can we bypass the devices that are not yet supported so the other devices will load? thanks

This is not my issu
On Sat, Oct 29, 2022, 23:14 Zelin Li @.***> wrote:

Can we bypass the devices that are not yet supported so the other devices
will load? thanks
—
Reply to this email directly, view it on GitHub
https://github.com/fuatakgun/eufy_security/issues/464#issuecomment-1296098663,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM3BLO3MXDTVDADHUBI6TV3WFXYZBANCNFSM6AAAAAAQPTCAMA
.
You are receiving this because you commented.Message ID:
@.***>

I just installed the lock today and noticed the same thing. As soon as I shared the lock with my HA account, it broke the Integration. @MXKLZL suggestion of just unsharing restores my other devices.
I already have the TRUSTED_DEVICE_NAME set as @KillaDreams suggested, but I am getting the "Retrying setup: Start Listening was not completed in timely manner" error.
I checked the eufy_security_client repo and found a request to add this lock here: https://github.com/bropat/eufy-security-client/issues/220
What is interesting is the Home Assistant Add-On loads just fine; it is just the integration that breaks.
Hopefully, we can get this added, as I already really like this lock.
Let me know what I can do to help!

Same issue here.
`This error originated from a custom integration.
Logger: custom_components.eufy_security
Source: custom_components/eufy_security/websocket.py:59
Integration: Eufy Security (documentation, issues)
First occurred: 12:35:58 AM (575 occurrences)
Last logged: 3:12:50 PM
eufy_security - Exception - process_messages: 55 is not a valid DEVICE_TYPE - traceback: Traceback (most recent call last): File "/config/custom_components/eufy_security/websocket.py", line 57, in process_messages await self.on_message(msg) File "/config/custom_components/eufy_security/websocket.py", line 68, in on_message await self.message_callback(message) File "/config/custom_components/eufy_security/coordinator.py", line 313, in on_message await self.process_get_device_properties_response( File "/config/custom_components/eufy_security/coordinator.py", line 258, in process_get_device_properties_response device.set_properties(properties) File "/config/custom_components/eufy_security/const.py", line 452, in set_properties type = DEVICE_TYPE(self.type_raw) File "/usr/local/lib/python3.10/enum.py", line 385, in call return cls.new(cls, value) File "/usr/local/lib/python3.10/enum.py", line 710, in new raise ve_exc ValueError: 55 is not a valid DEVICE_TYPE - message: WSMessage(type=<WSMsgType.TEXT: 1>, data='{"type":"result","success":true,"messageId":"get_device_properties","result":{"serialNumber":"T8530K1022290E64","properties":{"name":"Front Door","model":"T8530","serialNumber":"T8530K1022290E64","type":55,"hardwareVersion":"P1","softwareVersion":"<IP_ADDRESS>","stationSerialNumber":"T8021P11222621CE"}}}', extra='')`

please try with alpha release v5.x.x and let me know

https://github.com/fuatakgun/eufy_security/issues/591

I have just configured all of the necessary components for the HA add-on and despite it connecting to both the bridge and the lock, I'm not seeing anything useful in the lock section. Have I jumped the gun with support for the 8530?

Eufy Security Add-on, Current version: 1.3.0
Eufy Security v6.1.0 via HACS
P.S Had to change port on Eufy Security Add-on to 3030 as Z-Wave JS UI was already using 3000

Why did you assume so?
It was not captured on supported device list.
Check readme.

@fuatakgun:  Ok sounds good;  I think the confusion is because this issue was closed so we might have concluded the support was implemented.  I'll keep an eye out for that to appear on the supported device list.  Thanks so much for your hard work on this valuable project.  :)

No no, you have to work with @bropat over eufy-security-client repository, share your device with him so he can add the support.
Without access to new devices, he would not do it. That is because i am always referring to readme and links there because you would find this out.
When device support is added, he will release a new version and so do I

Thanks for the clarification. For me, my confusion came from the release notes that showed the 8530 mentioned in the code and it's tricky for us non-coders to understand all the components required to make this work. I'll keep an eye on the supported devices from now on for my main source of info. Many thanks for your great work.


D2 support

Please,
add "d2" support.

Thank you very much for the support.
V1.2.3 not yet released ?
Best regards
Tshitshi
Le ven. 9 févr. 2024 à 04:43, Kazuyoshi Matsumoto @.***>
a écrit :

Closed #8 https://github.com/kazumatu981/markdown-it-kroki/issues/8 as
completed via #9 https://github.com/kazumatu981/markdown-it-kroki/pull/9
.
—
Reply to this email directly, view it on GitHub
https://github.com/kazumatu981/markdown-it-kroki/issues/8#event-11753525560,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALX32WKIQC7F3EQRHYV4DT3YSWLMBAVCNFSM6AAAAABC32KPRGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG42TGNJSGU2TMMA
.
You are receiving this because you authored the thread.Message ID:
@.***>

?????
I have been released.
Please check it

https://github.com/kazumatu981/markdown-it-kroki
new version not yet documented.
Thanks.
Best regards
Tshitshi


 This does not fix the failing tests, but it does at least move the project closer to that state.

Looks like you made the fixes in commit fb18ebf2249fe0a0d8ff6ed688eaed149ecb4f70, so I'm closing this now.


Add generated nixpkgs.config doc to Nixpkgs manual

Description of changes
Document the nixpkgs.config options in the Nixpkgs manual using the module system docs tooling.
Things done

Built on platform(s)

[x] x86_64-linux]

NixOS options chapter is unchanged
Nixpkgs manual lgtm

[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

rendered

should probably be linked from https://nixos.org/manual/nixpkgs/stable/#chap-packageconfig if possible
i'll add allowUnfree to config.nix

Result of nixpkgs-review pr 171163 run on x86_64-linux 1

2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test


Support Apache HttpClient 5.0+

Support classic/async/h2async client
Compare to 4.x, 5.0 exposes ExecInterceptor. So we can avoid making a builder class and just add ExecInterceptor/RequestInterceptor/ResponseInterceptor to achieve the tracing.

Currently, 5.0.3 has issues which make H2Async & CachingH2Async not work(test will be failed), I think it should be fixed at their side.

https://issues.apache.org/jira/browse/HTTPCLIENT-2123
https://issues.apache.org/jira/browse/HTTPCLIENT-2126

--
Solve https://github.com/openzipkin/brave/issues/1228

do you mind to rebase this on latest master (note current version changed)
travis hasn't worked for almost 2 weeks. master now uses GitHub actions

Updated, but 5.0.4 is not released yet. So I think we can merge after its release.

fyi it seems both issues are marked fixed in 5.0.4, but I looked and there is no vote thread for that version. Hence, it might be until next year https://mail-archives.apache.org/mod_mbox/hc-dev/202012.mbox/browser

I am looking for a way to integrate Spring 5 Webclient and think it would be feasible with this "new" instrumentation. Any reason it did not yet get merged? Any alternative to instrument Spring 5 Webclient? Thank you.

Can this be merged, please? Is there anything still holding this back?

Ping @shakuzen
On Fri, 10 Feb 2023, 11:15 ParaSait, @.***> wrote:

Can this be merged, please? Is there anything still holding this back?
—
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/brave/pull/1274#issuecomment-1425566264,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXOYASV2K2ILQFTFAFI2M3WWYINBANCNFSM4TJ5BYCQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Has there been any progress towards merging this PR?

Updated, I think all the tests are passed. Maybe need to check more due to I made it long before.

@kojilin Any updates on this? We would love to integrate with HC 5 in one of our projects.

I'm not the maintainer of the project, so need the other people to check and merge.

I can add a review over the week.
If some lone can earlier, please go ahead.
Sorry this has take this long

Seems license headers are up again, please run: ./mvnw com.mycila:license-maven-plugin:format to fix it

Any feedback here @shakuzen ?

Beautiful, thanks @kojilin !! 🎉

Amazing work! 👏
This is the last blocker for an upgrade to Apache HTTP 5.x for me.
@jeqo I noticed that after the merge, the CI tests failed: https://github.com/openzipkin/brave/actions/runs/4724094424
Seems something related to the license header that's not up to spec, but I'm not familiar with how this is supposed to run.
(how) can I help fix these issues so we can get a new artifact with the added HttpClient 5.2+ support?


Too much logging is coming from processChunk

I believe this is coming from Chapter 1 document.

We should also see where the time is spent. I.e. only small portion is spent in oTel, likely we can make overall processing cheaper.
And we also need to look why we log that even, maybe it's ok to leave logging as is, but there is some other functional bug that needs to be fixed?

sounds good. pushing this to November, as i won't have time in the next week :)

Are we still using SnapshotV1?

yes

This bug has rather big impact on Chapter 1 document
Can we prioritize investigation here?

@ksbrar - can we port this to release/0.29 so we can take this as a hotfix downstream?


Velocity extensions

Description

Fixes #
Where has this been tested?

Platform(s): ...
Python version(s): ...
Unreal Engine version(s): ...
CARLA version: ...

Possible Drawbacks

This change is

All considered now :)


Are you still developing this library?

The code currently doesn't build and there are many coding errors. For example, this function is defined as void but is returning a boolean value:
https://github.com/dacap/vaca/blob/main/vaca/ConditionVariable.h#L54
Division by zero on https://github.com/dacap/vaca/blob/main/vaca/base.h#L99
__int64 is a MSVC thing that doesn't available on MinGW, has to change to int64_t for the code to compile: https://github.com/dacap/vaca/issues/6
And it seems the library is still an experimental work? https://github.com/dacap/vaca/issues/5
@dacap Please tell us if you are still developing this library. If you are no longer developing this library, please state it clearly on README.md so everyone could know. Thank you.

Hi @iahung, I'll take a look to the issues you named. This library was for long time abandoned (after some stable period), and then I took it again just to modernize some features (using std::function, etc.). For example the ConditionVariable should be replaced with std::condition_variable.
I'll state this clearly in the README soon: This library is not actively developed, but it's being maintained, you can send PRs and I'll ty to review them ASAP. The only problem with this library is that it looks like Microsoft has finally moving away from Win32 controls to a new modern look. If vaca should evolve to something else, that would be a library to handle those new modern controls.

The only problem with this library is that it looks like Microsoft has finally moving away from Win32 controls to a new modern look. If vaca should evolve to something else, that would be a library to handle those new modern controls.

This is not a problem. You should better try to make your library usable first. Currently it's not usable with modern compilers and I doubt it could compile out of the box on older compilers too. Do you know the FOX Toolkit? It's predate your library but still being developed and still has people using it, the developer doesn't try to modernize the look of it but he tries to make it usable instead. The FOX Toolkit still uses the old autotools. People wanted to use it then incorporated modern build systems into it on their own fork:
https://github.com/devinsmith/fox
https://github.com/franko/fox
The original FOX Toolkit is here (the site is not even have https): http://www.fox-toolkit.org/
This is the mailing list: https://sourceforge.net/p/foxgui/mailman/foxgui-users/
As you can see, the community is active.
I doubt that the FOX Toolkit's UI is any more modern than your library. The FOX Toolkit has the same Win95 style look and feel.
Last and not least, if a modern UI is so important, people should have abandoned FLTK already: https://www.fltk.org/


[Enhancement]  LineageIntegratorContext should have a getDataAssetByGUID API

Is there an existing issue for this?

[X] I have searched the existing issues

Please describe the new behavior that that will improve Egeria
LineageIntegratorContext has a method
List<DataAssetElement> getDataAssetsByName(String name,
                                                      int    startFrom,
                                                      int    pageSize,
                                                      Date   effectiveTime)

it should have a new method
DataAssetElement getDataAssetByGUID(String name,
                                                      Date   effectiveTime)

so it is possible to retrieve an asset if the caller has the guid.
Alternatives
Use getDataAssetsByName instead. This is less efficient
Any Further Information?
@mandy-chessell as code owner are you ok if I work on this - or do you want to?
Would you be prepared to be assigned this issue to work on?

[X] I can work on this

I found the method


Usage examples?

Hi,
I just came across TipTap and only starting with Leptos.
I looked for some Leptos specific TipTap examples everywhere (google, github search) but came up with nothing.
I plan to persist to figure things out, but it would be of great help if there would be a trivial example of how to set up  and actually be able to play around with it (editing text, etc).
The only example that Leptonic provides is this
<TiptapEditor disabled=disabled value=value set_value=move |content| match content {
    TiptapContent::Html(content) | TiptapContent::Json(content) => set_value.set(content),
}/>

but it only renders the menu with all the buttons, no area to edit text.
As I said, I'm only starting with all of this and I don't know yet how to use TipTap, so please bare with me. Some example (even a trivial contrived one) to get one started will be of big help.
Thank you.

looks like i was just missing:
        <script type="module" src="js/tiptap-bundle.min.js"></script>
        <script type="module" src="js/tiptap.js"></script>


Newsletters

Look, newsletters!

Maybe, but I honestly couldn't work out how to get it to work without merging the two, and it's kind of related because you need absolute urls to distribute the markdown 😛

The new behaviour isn't needed by the existing behaviour in the file though, right? So I'd guess it'd be fine to have as a separate file and import that? I'll look into it.

If there's no author

I'm not sure allowing any staff to edit old newsletters is a useful feature - if an old item absolutely must be changed, the webadmin can do it?

Looks ready to merge :shipit:


Add initial working example of Rust random walk

Description
Add a random walk in Rust
Pull request type

[ ] Algorithm Module

######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm

[ ] Core algorithm/module implementation
[ ] Query module implementation
[ ] Unit tests
[ ] End-to-end tests
[ ] Code documentation
[ ] README short description
[ ] Documentation on memgraph/docs

######################################

@gitbuda My idea is to include random walk in all available langs. This way the user would have a neat example of how to implement stuff in a preferred language. The requirement would be to update this PR and add a small test. No need to rush into it, just a not for not deleting this.

Awesome!

@gitbuda My idea is to include random walk in all available langs. This way the user would have a neat example of how to implement stuff in a preferred language. The requirement would be to update this PR and add a small test. No need to rush into it, just a not for not deleting this.

Awesome!


Check for not pushed submodule

When I was checking this workflow (in private repo) I did this:
#
# Test 1
#

# in submodule
release_tool git:(master) > git checkout -b another_branch
release_tool git:(another_branch) > git c --allow-empty -m "empty"
# FORGOT TO PUSH THIS COMMIT!

# in main repo
repo git:(integrate-check-submodule-workflow) > git cm "another branch but not pushed commit"  && git push

# GitHub Action: PASS! (should FAIL)

#
# Test 2
#

# in submodule
release_tool git:(another_branch) > git push

# in main repo (make separate commit for verbosity)
repo git:(integrate-check-submodule-workflow) > git c --allow-empty -m "now submodule commit is pushed"  && git push

# GitHub Action: FAIL (expected)

output:

Run for PR # 2320 of integrate-check-submodule-workflow into develop on TangleInc/TangleBack
Checkout Branch Histories
Full Brach Histories
From TangleInc/TangleBack
 * branch              integrate-check-submodule-workflow -> FETCH_HEAD
From TangleInc/TangleBack
 * branch              develop    -> FETCH_HEAD
submodule.submodules/release_tool.path
Switched to branch 'integrate-check-submodule-workflow'
M	submodules/release_tool
Your branch is up to date with 'origin/integrate-check-submodule-workflow'.
Submodule 'submodules/release_tool' (git@github.com:TangleInc/release-tool.git) registered for path 'submodules/release_tool'
fatal: remote error: upload-pack: not our ref 1ec918928494ac0c0f5bca1d1ec03dd71113d194
fatal: the remote end hung up unexpectedly
Fetched in submodule path 'submodules/release_tool', but it did not contain 1ec918928494ac0c0f5bca1d1ec03dd71113d194. Direct fetching of that commit failed.
Switch to submodule at: submodules/release_tool
Switched to branch 'develop'
Your branch is up to date with 'origin/develop'.
Submodule submodules/release_tool Changed from: 1be4e947292e53c8d1e8638e4a9baa75e482977b to 1be4e947292e53c8d1e8638e4a9baa75e482977b
Check if submodule has been changed on integrate-check-submodule-workflow
grep: ...
# other changed files (not related to submodule)
...
PASS: Submodule submodules/release_tool has not been changed on branch integrate-check-submodule-workflow

How I understand it:
If you want to add this check, then before you check current submodule branch against base branch you need to check that your local submodule branch is what it should be.
This command will always give commit sha recorded in git and not just a sha of local version (SO explanation)
git ls-tree HEAD {SubmodulePath}

# in my case
repo > cd submodules/release_tool

release_tool > git rev-parse HEAD
1be4e947292e53c8d1e8638e4a9baa75e482977b

# make changes in local version and `git rev-parse HEAD` will get new sha
release_tool > git checkout HEAD~1
release_tool > git rev-parse HEAD
9a5ffbcb037e9788559bf6d80b2f687435d107c5

# git ls-tree will still provide commited sha
release_tool > cd -
repo > git ls-tree HEAD submodules/release_tool
160000 commit 1be4e947292e53c8d1e8638e4a9baa75e482977b	submodules/release_tool

Thanks @aimestereo , good catch! This definitely needs to be handled differently - I will make a patch by the weekend.
I think I will set this as an automatic fail (if the submodule hash referenced has not been pushed). No reason to run the rest of the action in that case.


Multiple selected file Support?

The $PATH variable only support one selected file.
When I choose multiple files in Findler,the program seems has not passed it to shell script

What does your shell script look like?

bash,I want to use $@ in script  for  all selected files path,it seems no working.

This works
open $PATH

So does this:
echo $PATH | xargs open

This may be more what you want: loop through each item of $PATH (see here):
( IFS=:
  for p in $PATH; do
      open "$p"
  done
)

@gingerbeardman It's working,thanks.
I thought the $PATH is seperated by space,so I   debug echo $PATH > show_path.txt,It's seperated by wrap line so echo $PATH >> show_path.txt could show the result.


libyami should pull in gtest source into a sub-folder

As we've learned from libva-utils and intel-vaapi-driver, it is far easier to simply include the gtest source in the project itself for purposes of the actual testing.

Thanks for suggestion. I will check libva-utils and see how to do this

I will send pull request about decoder API for vc1 and hevc. This change will conflict with the patch. I will do this change after decoder unit test merged.

Hi, @uartie @seanvk
According to your suggestion, I have moved the unittest files(gtest source) from encoder directory to test directory. Please help review pull request #753. If it is OK, I will move all the other subdirs' unittest files of libyami to test directory.

#753 does nothing to address this issue.  This issue is about adding the third-party google test source code (https://github.com/google/googletest) into this project.  See https://github.com/01org/intel-vaapi-driver/commit/1746adbb9adabd9fbee417ae3db67da599cc84e9 for an example.

Hi, @uartie
Thank you for your kindness advice. I have added google test source code to this project.
Please help review pull request #774 .  Thanks.

close this since #774 merged, thanks U.Artie and Sean


vlfeat bug at compilation on Ubuntu 20.04

Hi Cars Team,
I open this issue to warn about a known bug when we try to compile vlfeat on Ubuntu 20.04. It has been highlighted here and reproduced by vlfeat team. I just asked them if there is any workaround.
Pierre L

Fixed by removing all default(None) in file vl/kmeans.c here

Thanks for the issue and the workaround with vlfeat team. With Latex installation (my case), the compilation is breaking also and works with :
make MEX=$MATLABROOT/bin/
See https://github.com/vlfeat/vlfeat/issues/76

Fixed here : https://github.com/CNES/cars/blob/master/Dockerfile#L93


Chore - Reupping test coverage

This PR simply gets our test coverage back up to 100%. Although I did end up finding a bug in the new code added in #335, which this PR also fixes.
😄

Boom! Back to 100% test coverage! Merging...


Project switching / task cursor broken in Firefox

Amazing add-on as always.
Am I wrong to see that project switching is not working in Firefox? Same with the task cursor (and the related functions of e.g. changing task priority).
I'm on version 192 in Firefox. (I see it all working fantastically on the latest version in Chrome.) Thank you!

I am also experiencing a lot of issues on Firefox. Completely broken for me.

Thanks for reporting y'all!  I think it's fixed in version 193


[Improvement](jdbc external table)Support jdbc external table for nereids.

Proposed changes
Issue Number: close #xxx

Nereids planner only support JDBC external catalog, this pr is to support JDBC external table for nereids.
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


WebP image compression

Expected behavior
Timber WebP lossless quality is lossless quality.
Actual behavior
Seems like the towebp filter with quality 100 don't make lossless quality, compared to ImageMagick command.
When I use Timber with an original image at 381ko, Timber generate a 66ko image, ImageMagick a 232ko image.
Original: https://www.dropbox.com/s/7evk7rrfqsbj6x9/original.png?dl=0
Timber WebP: https://www.dropbox.com/s/oj8gdqf6qnaqtjs/timber.webp?dl=0
ImageMagick WebP: https://www.dropbox.com/s/cgfgklf013xttg4/imagemagick.webp?dl=0
(Sorry for using Dropbox, Github doesn't support WebP upload)
Steps to reproduce behavior
Generate a WebP with Timber:
TimberImage(my_image).src('full')|towebp(100)
Generate a WebP with ImageMagick:
magick original.png -quality 100  generated.webp
The image is lossless with ImageMagick, not with Timber.
What version of WordPress, PHP and Timber are you using?
PHP 7.4 with Mamp Pro, Timber 1.19.1, WP 5.8.2.
Thanks!

The |towebp filter use the php 'imagewebp' function.
Timber
PHP
So I gues they just handle it different.
Your results should also be different with cwebp, gd, gmaick, ...

The difference of the size is very important, 66ko (Timber) versus 232ko (ImageMagick).
There is lossless parameter in the ImageMagick documentation, maybe PHP ignore this?

Ok, it's a new feature:

In PHP 8.1, the GD extension supports lossless encoding, and declares a new PHP constant IMG_WEBP_LOSSLESS which can be passed to imagewebp function to enable lossless encoding of a GdImage object.

TimberImage(my_image).src('full')|towebp(101) in the future?


Multiple jars with Main-Class Manifest entries in Micronaut Project after 6.4 upgrade

Expected Behavior
Running gradle assemble in Micronaut project produces 2 jars (helloworld-0.1-all.jar and helloworld-0.1.jar), but only helloworld-0.1-all.jar should have a Main-Class manifest entry
helloworld-0.1.jar MANIFEST.MF:
Manifest-Version: 1.0

helloworld-0.1-all.jar MANIFEST.MF:
Manifest-Version: 1.0
Main-Class: example.Application

Current Behavior
Starting with Gradle 6.4, both jars have Main-Class manifest entries
helloworld-0.1.jar MANIFEST.MF:
Manifest-Version: 1.0
Main-Class: example.Application

helloworld-0.1-all.jar MANIFEST.MF:
Manifest-Version: 1.0
Main-Class: example.Application

Running java -jar helloworld-0.1.jar returns
Exception in thread "main" java.lang.NoClassDefFoundError: io/micronaut/runtime/Micronaut
        at example.Application.main(Application.java:24)
Caused by: java.lang.ClassNotFoundException: io.micronaut.runtime.Micronaut

Context
This stopped working with version 6.4. I know it works with 6.3.
I am creating a general purpose build pipeline for gradle projects. The pipeline involves installing the latest gradle version onto a clean Ubuntu image and building a gradle application. This build pipeline is used for Google's open sourced buildpacks. In this buildpack, we run gradle assemble then search in build/libs for a single jar with a Main-Class manifest entry to determine which jar to run. When multiple jars have Main-Class manifest entries, we error.
Steps to Reproduce
Using this gradle sample: https://github.com/micronaut-projects/micronaut-examples/tree/master/hello-world-java

Run gradle assemble with Gradle version 6.4
Extract data in jars in build/libs (should be the two listed above)
Notice they both have Main-Class manifest entries in 6.4 (located at META-INF/MANIFEST.MF), but only one has the manifest entry when built with 6.3.

Your Environment
This is running inside a minimal Ubuntu 18.04 image with Java 11 JDK.
Build scan URL:
https://gradle.com/s/bkpeawim6ffns
(Have not received email to activate but will when I receive it)

Thanks for the report.
This is indeed a change that was done as part of the Java Module System support. And it probably should not have been done in a minor.
Looking at options to handle this, will update on this issue.

Note that a workaround is available by doing:
tasks.named("jar").configure {
    manifest.attributes.remove("Main-Class")
}

Thanks for looking into this. Does this mean it is an intended change?

No, it wasn't an intended change.

This will be reverted for 6.4.1 and become an intended change in Gradle 7.0 as per #13125

Is there any way to support JPMS while also ensuring that this regression does not happen in 7.0? This output is odd for anyone working with micronaut.


Event input

In essence a custom readline implementation and some adjustments to integrate it. Finally writing a letter wrong is fixable without deleting everything after it!

Main issues now are missing handling of raw-mode. Most important, errors don't print carriage return.
This shall be cleaned up with a fix-up of the application in general, which will also reduce the out.flush() calls to only where truly needed.


layers/meta-raspberrypi: Waveshare SIM7600 module for ModemManager

To use the Waveshare SIM7600 module, GPIO pins must be set in dtoverlay, so that module is active on boot.
see balena forums problems-with-custom-image-on-rasberry-pi for more info
Changelog-entry: add dtbo to layer.conf so that dtoverlay is possible
Signed-off-by: Martijn<EMAIL_ADDRESS>

Can one of the admins verify this patch?

@resin-jenkins test this please

@minusplusminus you would need to add one more commit. To exclude this overlay from being compiled for the revpi board since it fails to compile for it. You should only need to add it here https://github.com/balena-os/balena-raspberrypi/blob/master/layers/meta-balena-raspberrypi/conf/layer.conf#L14

Okay, so I need to add this  I think:
KERNEL_DEVICETREE_remove_revpi-core-3 = "overlays/waveshare-sim7600.dtbo"
Can you verify?

@minusplusminus correct. you can edit the file conf/layer.conf to add the "_remove" part, then
git diff conf/layer.conf and inspect your changes. If all good proceed to
git add conf/layer.conf
git commit --amend
git push origin layer-conf-3 --force

@resin-jenkins test this please
I suspect the build might fail due to this empty line here: https://github.com/balena-os/balena-raspberrypi/pull/481/commits/de39386c457b77fff14b4c952deaf5052cbb0a39#diff-f7b696f6b21bc4146c67e8b1084ff047R135

@resin-jenkins test this please

@balena-ci retest

@resin-jenkins ok to test

@balena-ci retest

@balena-ci retest

What does the report say? Can I assist?

Hi. There was a problem with the build system with this PR. So I cherry picked these commits and created https://github.com/balena-os/balena-raspberrypi/pull/484
This PR here can be closed


[github_search] rename and consolidate

fixes #177

I will review in the morning. Please do not merge yet.

Can I simply list issues/prs with search (understanding I need pagination in general)?

Can I simply list issues/prs with search (understanding I need pagination in general)?

yes, pagination is optional

github_view_pr shows the recent pull requests of a repository and github_find_pr shows PRs updated on a specific date. Since they provide different features it might be better to keep them.

This implementation of github_search also incorporates functionalities offered through  github_view_pr and github_find_pr. I added back the github_view_pr just in case someone is using it, but it's not part of the docs on purpose. We'll look at the usage metrics and remove it, if safe.


[Demo] Shared SSH access

Show the ability to share via ssh a working instance for any number of clients from any region.
Pay attention to

[x] individual size of the client terminal window
[x] individual client viewport
[x] independent client mouse cursor
[ ] independent client text cursor
[x] independent interaction of clients with any UI elements
[ ] list of connected clients

ip, region
viewport coor, size

[x] access within a region
access across regions (instance state replication)

Shared access should be for all published applications.

The main functionality for shared SSH access is implemented.
At the moment, it is possible to open two terminal windows in your system, and drag objects from one area to another in real time. Shared SSH access is only available in the current region.
The option "access across regions" is still under question - it is not very clear whether this is necessary or not.
Note: at the moment, objects deleted by users are not being restored, I can only restore them manually, I'm still working on it.

Now it is possible to create windows and controls yourself using the menu for selecting the type of object being created.

Added visualization of connected clients: ip + source port. At the moment, clients are listed among all objects in the general list, later there will be a separate list at the top right of the viewport. Each client's viewport rectangle will render as a shadow in the background. The navigation string to the client viewport is not functional yet.

All users connected to the session are absolutely independent of each other, they do not interfere with each other, since everyone has their own mouse and their own viewport, but they can see everything what's going on around.
For example, users can even resize the same object at the same time and get the expected behavior.


feat(rpc): creating scaffolding for JWT authentication

Based on #1283
Will have to be rebased on the next RPC PRs to make cleaner
TODO (in stacked PRs):

[ ] token generation <- cli tool?
[ ] token verification
[ ] fix reflection tests
[ ] create docs

Codecov Report

Merging #1325 (6615926) into main (b4a8145) will decrease coverage by 1.14%.
The diff coverage is 25.07%.

@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
- Coverage   55.28%   54.13%   -1.15%
==========================================
  Files         180      185       +5
  Lines       10904    11211     +307
==========================================
+ Hits         6028     6069      +41
- Misses       4276     4538     +262
- Partials      600      604       +4

Impacted Files
Coverage Δ

nodebuilder/das/service.go
0.00% <0.00%> (ø)

nodebuilder/fraud/fraud.go
0.00% <0.00%> (ø)

nodebuilder/header/service.go
40.00% <0.00%> (-17.15%)
:arrow_down:

nodebuilder/share/service.go
50.00% <0.00%> (-50.00%)
:arrow_down:

nodebuilder/p2p/mocks/api.go
2.66% <2.66%> (ø)

nodebuilder/state/service.go
7.14% <7.14%> (ø)

nodebuilder/p2p/p2p.go
51.11% <51.11%> (ø)

api/rpc/server.go
61.40% <58.33%> (-1.64%)
:arrow_down:

api/rpc/client/client.go
78.57% <100.00%> (+0.79%)
:arrow_up:

nodebuilder/das/daser.go
75.00% <100.00%> (ø)

... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix windows build

absolutePrefixLength doesn't compile under Windows.
The Windows terminal uses ASCII backspace.

No longer needed, the CLI repo should work as is now https://github.com/wren-lang/wren-cli/


Implement the join calculus

Implement the static when and instance and operators.

Maybe we should close #287 and use this issue to track the when implementation.

closing as inactive.


Adds tests to ensure default values work

Nice work!

@paulofaria Sorry - re-requesting review after we bumped to Swift 5.8


Revert "feat: LSDV-3104: Task navigation standardization"

Reverts heartexlabs/label-studio-frontend#1355

Codecov Report
Patch coverage: 26.66% and project coverage change: -0.01 :warning:

Comparison is base (24dab8c) 65.25% compared to head (c4efe5f) 65.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
- Coverage   65.25%   65.24%   -0.01%
==========================================
  Files         435      435
  Lines       27175    27171       -4
  Branches     7186     7182       -4
==========================================
- Hits        17732    17728       -4
- Misses       8117     8118       +1
+ Partials     1326     1325       -1

Impacted Files
Coverage Δ

src/components/BottomBar/CurrentTask.js
0.00% <0.00%> (ø)

src/stores/AppStore.js
55.14% <0.00%> (+0.36%)
:arrow_up:

src/components/TopBar/CurrentTask.js
57.50% <42.10%> (-2.03%)
:arrow_down:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Marshalling/Demarshalling APIs

@huyang1988 @Grace-Liu @akorzan
We need to finish the Marshalling/Demarshalling stuff.
Here is the summary that we did:
1st and 4th API: Done by Yang.
2nd API done by Pradeep
3rd API is being developed by Anthony
We need to finish this as per plan.
Division of the work:
Grace: Please make the code compilable. You can see there is a Makefile and main.c inside lib directory speicifically designed for marshalling/demarshalling. Write a small test function in main.c so that we are able to call any of the APIs for testing. You don't have to write in-depth testing framework except making it run. Then, write one testcases for each of 4 APIs at least. You can write more.
Yang, pradeep and Anthony will then test their apis writing more testing code in main.c or a new file mimicing your written code as per their wish.
I will be merging the repository to main repository by end of day today so that you can fork the main repository.

Thanks Pradeep, the plan sounds good to me.

For reference, see the test code in lib/linkedlist/test, lib/hashtable/test and server/test
This will show you how you can write tests that travis will run and what kind of output format to use.

@huyang1988 Are you done with 1st and 4th API? It seems your code is complete such as this valuable hasn't been defined yet.
https://github.com/gwAdvNet2015/gw-kv-store/blob/client-dev/lib/marshal/marshal.c#L43
Please let me know if this is not your final version, thanks.

@Grace-Liu Yes I think so. Actually we finished this in class. But we did not tested it together with other parts. Do we have a test plan?

I have wrote a simple test cast for gwkv_marshal_client()
https://github.com/Grace-Liu/gw-kv-store/blob/client-dev/lib/marshal/test/test-marshal.c
@pradeep-k gwkv_marshal_client() currently only converts the first two characters for set case (I think it is because of snprintf) and has segmentation fault for get case, please check. And please take a look at whether my set_cmd and get_cmd strings are right. Thanks.
@huyang1988 please try to finish your code since I am not sure how to handle your undefined variables and try to add status string conversion.

The code looks good. Thanks for the testing framework. I will start to debug to fix it.

I fixed the bug. I changed the testfile also little bit based on my understanding. If you find problem with this represention, then let me know.
fixed code can be found in here:
https://github.com/pradeep-k/gw-kv-store/tree/master/lib/marshal
changed files are marshal.c and test-marshal.c

@pradeep-k I've checked the bug has been fixed, thanks.
@huyang1988 there is a bug for SET operation in gwkv_marshal_client, and there is still a undefined variable in gwkv_demarshar_client function, please check. https://github.com/Grace-Liu/gw-kv-store/blob/client-dev/lib/marshal/marshal.c#L163

@akorzan @huyang1988 : What stage are you guys in? Let me or Grace know if you need any help.
We need to have a stable code before we go to class.

@pradeep-k @Grace-Liu @huyang1988 @akorzan -- please update this Issue or close it and create a new one listing exactly what is remaining and who will do what

Issue #51 has been created. Closing this.