Support "antialiased" splats

Hi!
First of all, thanks for the project and kudos for the code quality and the comments (e.g. in SplatMesh.js). I was checking your viewer after playing around with Nerfstudio. I enabled the new "antialiasing" version of their rasterizer (see motivation here and integration in Nerfstudio there), but the problem is that it requires explicit support in viewers down the line. To summarize, a compensation factor would need to be computed in the vertex shader and applied to the gaussian opacities.
Would that feature be in the scope of this project? If it is, I could provide a PR. Since rasterization is done differently in this viewer, I guess the compensation would need to be applied to vColor.a directly?

This seems like it would be a good feature to have, but I'm not sure how best to integrate it. Specifically I'd like to avoid having to specify a parameter when loading a file to indicate whether it is an "anti-aliased" or "classic" splat. Ideally that information would be encoded into the file itself -- Does the Nerfstudio code support  that?
As for updating my viewer, it looks like it would be super easy, in fact the authors of the mip-splatting work created a web viewer (based on mine) for that purpose, and it looks like they just made a small update to the vertex shader in SplatMesh.js:
  // compute the coef of alpha based on the detemintant
  float kernel_size = 0.1;
  float det_0 = max(1e-6, cov2Dm[0][0] * cov2Dm[1][1] - cov2Dm[0][1] * cov2Dm[0][1]);
  float det_1 = max(1e-6, (cov2Dm[0][0] + kernel_size) * (cov2Dm[1][1] + kernel_size) - cov2Dm[0][1] * cov2Dm[0][1]);
  float coef = sqrt(det_0 / (det_1+1e-6) + 1e-6);

  if (det_0 <= 1e-6 || det_1 <= 1e-6){
      coef = 0.0f;
  }

  cov2Dm[0][0] += kernel_size;
  cov2Dm[1][1] += kernel_size;
  vColor.a *= coef;

Hello, I want to fork this repo and add this code, but I don't know where to put the code:
  // compute the coef of alpha based on the detemintant
  float kernel_size = 0.1;
  float det_0 = max(1e-6, cov2Dm[0][0] * cov2Dm[1][1] - cov2Dm[0][1] * cov2Dm[0][1]);
  float det_1 = max(1e-6, (cov2Dm[0][0] + kernel_size) * (cov2Dm[1][1] + kernel_size) - cov2Dm[0][1] * cov2Dm[0][1]);
  float coef = sqrt(det_0 / (det_1+1e-6) + 1e-6);

  if (det_0 <= 1e-6 || det_1 <= 1e-6){
      coef = 0.0f;
  }

  cov2Dm[0][0] += kernel_size;
  cov2Dm[1][1] += kernel_size;
  vColor.a *= coef;

Anyway, If we apply antialiased method for all PLY. May it broken any PLY that created from other software? (Inria 3DGS, Luma, Polycam, OpenSplat, etc) ?

I am the author of antialiasing mode of splatfacto , the code change needed to support web viewer is small (but slightly different from mipsplatting).
https://github.com/nerfstudio-project/gsplat/blob/main/gsplat/_torch_impl.py#L188
Currently it is not possible to store any metadata in PLY format. Any suggestions for us to move forward?
For short term, it makes sense to have a keyboard hotkey to toggle between classic and antialiasing mode.

@jb-ye It would definitely be helpful if you could provide a demo file. Then I can take a stab at implementing the computation for the opacity compensation factor.

Will do so when I got time this week. @bchretien @mkkellogg

https://drive.google.com/file/d/19e0iAsoc9F26ilM4s6g0Y6n0n9-WRjV5/view?usp=drive_link
Please check out this link for a sample ply asset.
Left: classic mode rendering of antialiased asset; Right: antialiased mode

@jb-ye Thanks! I'll try to make the update in the next couple of days and let you know when it's ready.

@jb-ye Would you be able to share the cameras.json (or equivalent parameters) for the above scene?

@mkkellogg What do you mean by cameras.json. Are they training camera parameters?

Well I noticed that using the standard calculation for focal length using Three.js projection matrix is producing sub-optimal results in terms of render quality (subject for sure), so I thought I'd play around with them to see if I can get better results by matching the training camera parameters.

Just want to double check your formula implemented. Here is the reference implementation from splatfacto/gsplat lib, where blurring kernel is 0.3 pixel and compensation is clamped instead of adding a tiny round-off eps. This is different from the one used by mip-splatting.
    det_orig = cov2d[..., 0, 0] * cov2d[..., 1, 1] - cov2d[..., 0, 1] * cov2d[..., 0, 1]
    cov2d[..., 0, 0] = cov2d[..., 0, 0] + 0.3
    cov2d[..., 1, 1] = cov2d[..., 1, 1] + 0.3
    det_blur = cov2d[..., 0, 0] * cov2d[..., 1, 1] - cov2d[..., 0, 1] * cov2d[..., 0, 1]
    compensation = torch.sqrt(torch.clamp(det_orig / det_blur, min=0))

Yep that's that math I'm using. I got something working that I think looks pretty good:

I used this code in the shader:
  float detOrig = cov2Dm[0][0] * cov2Dm[1][1] - cov2Dm[0][1] * cov2Dm[0][1];
  cov2Dm[0][0] += 0.3;
  cov2Dm[1][1] += 0.3;
  float detBlur = cov2Dm[0][0] * cov2Dm[1][1] - cov2Dm[0][1] * cov2Dm[0][1];
  float compensation = sqrt(max(detOrig / detBlur, 0.0));
  vColor.a *= compensation;

Fantastic

Thank you for your help on this!

That is a great news ! Can't wait to test it !

My experiment with Truck dataset
Left = Splatfacto-big with classic mode
Right = Splatfacto-big with antialiased mode

@mkkellogg thanks if you want to use half precision to store covariance, you would notice some quality loss for antialiasing mode. The fix is instead of saving the covariance in half precision, saving its Cholesky decomposition in half precision, and multiple it back to get the full covariance of full precision at usage time.

I have fantastic results with AA splats but still some issues with highly contrasted models
from a "standard" pov, (close to the training images), the details are undoubtly better.
Left : No AA , right with AA

But when I get my camera further, I get some weird white artifacts on the AA model.
(the non AA model still looks bad but don't have those artifacts.

Any idea about this problem ?... I guess it has something to do with transparency, since whats is behind the fabric in my model is white.

@gonzalle did you observe similar issue in nerfstudio viewer?

@gonzalle did you observe similar issue in nerfstudio viewer? I think it might relate to spherical harmonics not used in the web viewer.

Indeed !
the nerfstudio viewer rendering was clean from any distance...
Is there any trick around ? beside having less textured material ?

@gonzalle did you observe similar issue in nerfstudio viewer? I think it might relate to spherical harmonics not used in the web viewer.

Indeed ! the nerfstudio viewer rendering was clean from any distance... Is there any trick around ? beside having less textured material ?

Maybe try to reduce directional lights during capture, use more ambient lighting

@gonzalle Would you be willing to share your model? Maybe I can do some troubleshooting on my end.

@gonzalle Would you be willing to share your model? Maybe I can do some troubleshooting on my end.

Certainly, I just have to train again my model...
I hope it'll be fast... gime a couple hours :))

aa_weird.zip
Mark,
Here is the file... As I had to re-train it and edit it, I noticed that nerfstudio (when at low res) and Supersplat, both show the same issue.
For me it's something that has to do with the big white splat behind the fabric texture and some kind of "mip mapping" issues...

So I have also noticed this issue, and I don't know exactly what is happening but it does seem like it's caused by splats that are much bigger than the other splats in the scene. I added a super hacky viewer parameter called focalAdjustment that I have discovered helps. Try something like this when you run the viewer:
const viewer = new GaussianSplats3D.Viewer({
  'focalAdjustment': 3.0
});

The default value for focalAdjustment is 1.0, increasing it seems to make these kinds of artifacts less noticeable. I want to reiterate this is a big ol' hack, and I don't know exactly why it helps :)

Great, I will try that. Thanks a lot !
Gaussian Splatting, as a global techniqu,e and as it stands today, still has some issues. In any case, I firmly believe that such a technique, combined with a good web viewer, is a fantastic step forward! Keep on the fantastic job !


⚠ HDBits has degraded performance

In bd06db0, HDBits ($HDB) experienced degraded performance:

HTTP code: 200
Response time: 2745 ms

Resolved: HDBits performance has improved in 3d5ce02 after 6 minutes.


Added support for PKCE with client_secret_basic

Details
Hello,
Today the PKCE authentication with a client_secret only works with the client_secret_post authenticator and not with the client_secret_basic authenticator.
This pull request adds support for PKCE with a client_secret submitted with the client_secret_basic authentication.
Let me know if you need any further information.
Regards,
Julien

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please add tests. Thank you!

Hi,
I fixed the existing tests and I'm working on new ones.
Regards,
Julien

Hi,
Just added the following tests :

PKCE without any secret
PKCE with a client_secret transmitted by client_secret_post
PKCE with a client_secret transmitted by client_secret basic

Regards,
Julien


Refine the Dockerfile in root folder

Hi all,
I just found there is another Dockerfile in the root path, I think it should be used by RedHat internally. (We use operator-sdk build command to build by using the build/Dockerfile` directly)
I forgot the rename this binary name and fix in this PR, please review.
BTW, are you still using this Dockerfile? And do we want to maintain two Dockerfiles in this repo? I think it is a little confusing.

/ok-to-test

The build/Dockerfile is used by the operator-sdk commands. It assumes an already-built binary is in place.
The /Dockerfile is a multi-stage Dockerfile is used for building and packaging the binary onto a lean runtime image.
On every merge to master,  a build on Quay.io is done https://quay.io/repository/redhat-developer/buildv2?tab=builds with /Dockerfile. You could potentially 'contain' even your tests in the first stage too.
I haven't found a way to unify this :-)

/lgtm
/approve


Allow one level of indirection so variables declared elsewhere do not fail

The current linter relies on locally declared variables.
Add the following accept case to https://github.com/lee-chase/carbon-use/blob/master/src/rules/theme-token-use/tests/parseOptions.test.js
    {
      code: "@import './test'; .foo { color: $a-carbon-token; }",
      description: "Carbon theme token when imported.",
    },

Create a file that looks like this
@import "@carbon/themes";
$a-non-carbon-token: #fefefe;
$a-carbon-token: $ui-01;

Make the test pass by updating the rule https://github.com/lee-chase/carbon-use/blob/master/src/rules/theme-token-use/index.js
NOTE: Do not fix by ignoring unknown variable declarations ;-)

OK. There are a number of issues in general when linting anything that is not a direct declaration of a carbon token e.g. $ui-01;
It could be referenced by

variable
function

These references could be in

another file
another package

Typically linters do not work cross file.

Thoughts to marking this as invalid

variables must be listed somewhere so we should assume external variables are listed where they are declared
functions can be whitelisted/ignored

White listing can happen through

stylelint disable rules https://stylelint.io/user-guide/ignore-code
or in package.json

If variables/functions are declared in other projects they should be from a trusted source which is linting.
It would be nice if we could report/warn for unknown variables in a project.

Work in branch https://github.com/lee-chase/carbon-use/tree/variableDeclarationsWorkInProgress suspended


Morning session pear to pear code review

Hello yodit93
Good Job so far 👏
There are some issues that you need to work on before moving forward.
Changes Required ♻

Kindly do not delete your branches after merging them to the main branch.
Please add your live demo in readme source code coming from the dist folder.

Cheers and Happy coding!👏👏👏

Thank you.


Implement IsIPv6 function push down

Feature Request
Describe the feature you'd like:

We'd like to support IsIPv6 function push down.
Teachability, Documentation, Adoption, Migration Strategy:

At least one integration test and several unit tests.

/assignme

/assign

/assign


Update password expiry time documentation

Document [1] points to document [2] for enforcing password expiry time feature. The wording of the document [2] needs to be updated. Also the latest connector for IS 5.11 and 5.12 is not in the connector store.
[1] - https://is.docs.wso2.com/en/5.12.0/learn/password-expiry/
[2] - https://github.com/wso2-extensions/identity-outbound-auth-passwordPolicy/blob/master/docs/config.md

Hi @somindatommy
Could you please elaborate on this issue as the required changes in document are not mentioned?

Our official documentation[1] points to [2] and some of the terms are not related to the latest IS.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Make turbo stream format subscriber opt-in and not enabled automatically

Q
A

Bug fix?
yes

New feature?
yes

Tickets
Fix #...

License
MIT

The subscriber should be opt-in. As it currently manipulates the requestFormat which is not expected by all applications (e.g. Sulu or any other application, working with $request->getRequestFormat() for getting its template). A controller handling the turbo can activate the listener with:
my_route:
    defaults:
       turbo: true

This indicates this routes  handles turbo route and so request format is set to turbo, for all other routes it behaves the symfony way and the request format is not manipulated in this case.

In my opinion, https://github.com/symfony/symfony/pull/44980 is a better fix. It should allow removing this listener entirely.

@dunglas when then:
$request->setFormat(TurboStreamResponse::STREAM_FORMAT, TurboStreamResponse::STREAM_MEDIA_TYPE);
$request->setRequestFormat(TurboStreamResponse::STREAM_FORMAT);

Can be removed from this listener I'm totally in for that change :)

Tested your changes with sulu (without symfony/ux):
$request->getPreferredFormat(); // turbo_stream
$request->getRequestFormat(); // html

This would match my expected behaviour 👍  and would so not longer crash sulu's website controller here for turbo requests.

Maybe should we merge #44980 as a bug fix in Symfony then, to not have to wait for 6.1 to be released.

@dunglas that would be great :)

Well, symfony/symfony#44980 really is a feature... I'm for merging both PRs. We can remove the listener once this package supports 6.1+ only, as usual.

Actually it's a bug fix for Turbo. The question is: do we merge fixes needed for Symfony UX in the maintenance branches of the monorepo. In my opinion, we should at least in this case as this patch is very very small and cannot break anything.

@alexander-schranz could you try this patch instead, please? https://github.com/symfony/ux/pull/217


Add zip_safe = false flag to address #270.

Sets the zip_safe = False because we use open() to fetch files from OTIO - which means OTIO can't be used with compressed eggs.

@bpeck does this address #270 for you?  This should prevent python from installing as a zip file.

Yeah thanks!


Latest merge missing in version 0.10.0

Current version missing fixes related to Initial fix for text insertion bugs in Android 5.1 #1033.
please update the version.

Hi @gauravksoni - if I'm understanding this issue correctly, it calls out the fact that the latest PRs landed have not been released yet. We will be releasing a patch version with the latest changes soon - thanks for your patience. Closing this for now since we are actively working on getting a stable branch prepared to release.

can you lemme know how long it will take to release latest version with all fixes?


Error: Table 'pvault.perfumeTypes' doesn't exist

When creating a new perfume type this error shows.
Error: Table 'pvault.perfumeTypes' doesn't exist

Re-submit by following the bug template - missing context

Yes, the error comes when I try and create a EdP 30% and no text or text in the note field...


[erc20-balance-of-quadratic-delegation] A new strategy for quadratic delegations

This is a variant of erc20-balance-of-delegation strategy that preserves voting power in the case of quadratic voting.
The problem with erc20-balance-of-delegation is that if used with quadratic voting, the total voting power that the delegate has is less than expected.
In other words, delegation causes voting power loss. To fix this, we created this strategy.
Say there are two persons, with 100 vote credits each, in a quadratic voting setting. Person A delegates to person B.
Using erc-20-balance-of-delegation:
Voting Credits of Person B = Voting Credits of Person A + Voting Credits of Person B = 200
Person A could cast 10 (10^2=100) votes individually, similarly, Person B could cast 10 (10^2=100) votes individually, so in total, they could cast 20 votes.
But now, delegate can't cast 20 votes (20^2=400) because it needs 400 credits.
Solution:
Voting Credits of Person B = (Sqrt(Voting Credits of Person A) + Sqrt(Voting Credits of Person B))^2 = 400
Now the delegate can represent the sum of individual voting powers.

Hi @ferittuncer
Make sure to add your strategy to https://github.com/snapshot-labs/snapshot.js/blob/master/src/strategies/index.ts#L106
and make sure to test your strategy with
npm run test --strategy=erc20-balance-of-quadratic-delegation

Please don't merge yet as I haven't tested it actually, but coded blindly. Because I'm unable to run the test suite.

@ferittuncer If you are still having issues in your local system, you can check logs in the github actions on this PR

which seems to be working fine to test your strategy

@ferittuncer If you are still having issues in your local system, you can check logs in the github actions on this PR

which seems to be working fine to test your strategy

The build is successful but does it yield correct values?

As we verified the problem is indeed in my environment, I started to work on a VM now.

As I suspected, it's not working correctly. Logs indicate a linear sum of voting scores, instead of quadratic.
I'm having hard time to print my debugging console logs, I guess this is an issue with Jest (https://stackoverflow.com/a/54190964/1079908). If you have a tip on this, I would appreciate.

As I suspected, it's not working correctly. Logs indicate a linear sum of voting scores, instead of quadratic.
I'm having a hard time printing my debugging console logs, I guess this is an issue with Jest (https://stackoverflow.com/a/54190964/1079908). If you have a tip on this, I would appreciate it.

Found the origin of this problem, and fixed it in the last commit.

@ferittuncer Just merged! It should be live in ~10mn


cache library version

so we don't need to read environment properties every call.
Fixes #2234.
This is not the approach proposed in the issue.
As implemented in this PR, we will read the property once
for every client instantiation, not once ever.
Still, this should be fast enough,
and we won't need to maintain double-check-locking mechanism.

Changes Unknown when pulling e56814f3b1b4d99d6c6f6e9b6d9c3b65409af6bf on pongad:cache-lib-ver into ** on GoogleCloudPlatform:master**.

LGTM


Add option to limit empty callable propagation to known types

This approach roughly matches the one used by std::function, explicitly
enumerating the types which are supported for empty propagation.
Fixes #48

I unfortunately didn't end up running tests locally (cmake got upset when I asked it to run tests), so I expect that this will fail them.

Ping @Naios, does this approach seem reasonable? I think the build failures are also present without these changes.

Sorry for the delay. I think your changes look good and solve the problem elegantly.
I dont think there is any possible solution otherwise (and if there is, it can be implemented in the future).
Thank you for your contribution.


Reconsider sum/prod/trace upcasting for floating-point dtypes

The requirement to upcast sum(x) to the default floating-point dtype with the default dtype=None currently says (from the sum spec):
If x has a real-valued floating-point data type, the returned array must have the default real-valued floating-point data type.
The rationale given is "keyword argument is intended to help prevent data type overflows.". This came up again in the review of NEP 56 (https://github.com/numpy/numpy/pull/25542), and is basically the only part of the standard that was flagged as problematic and explicitly rejected.
I agree that the standard's choice here is problematic, at least from a practical perspective: no array library does this, and none are planning to implement this. And the rationale is pretty weak, it just does not apply to floating-point dtypes to a similar extent as it does to integer dtypes (and for integers, array libraries do implement the upcasting). Examples:
>>> # NumPy:
>>> np.sum(np.ones(3, dtype=np.float32)).dtype
dtype('float32')
>>> np.sum(np.ones(3, dtype=np.int32)).dtype
dtype('int64')

>>> # PyTorch:
>>> torch.sum(torch.ones(2, dtype=torch.bfloat16)).dtype
torch.bfloat16
>>> torch.sum(torch.ones(2, dtype=torch.int16)).dtype
torch.int64

>>> # JAX:
>>> jnp.sum(jnp.ones(4, dtype=jnp.float16)).dtype
dtype('float16')
>>> jnp.sum(jnp.ones(4, dtype=jnp.int16)).dtype
dtype('int32')

>>> # CuPy:
>>> cp.sum(cp.ones(5, dtype=cp.float16)).dtype
dtype('float16')
>>> cp.sum(cp.ones(5, dtype=cp.int32)).dtype
dtype('int64')

>>> # Dask:
>>> da.sum(da.ones(6, dtype=np.float32)).dtype
dtype('float32')
>>> da.sum(da.ones(6, dtype=np.int32)).dtype
dtype('int64')
>>>

The most relevant conversation is https://github.com/data-apis/array-api/pull/238#issuecomment-922130293. There was some further minor tweaks (without much discussion) in gh-666.
Proposed resolution: align the standard with what all known array libraries implement today.

As I mentioned a few times before, I agree with not specifying this.  Partly, because I think it is just asking too much from NumPy (and apparently others).
But even from an Array API perspective I think it isn't helpful, because "default type" also is just "unspecified" effectively (if you sum a float32 array, you don't if you get a float32 or float64).

Partly, because I think it is just asking too much from NumPy (and apparently others).

Since all libraries appear to do exactly the same as of today, what's the problem with encoding that? Nothing is being asked from anyone at that point, it's basically just documenting the status quo.

I wouldn't have been surprised if someone upcast for float16, but if not then fine.  Mainly, I am not sure I mind the old proposal if it was coming from scratch, so I don't have an opinion about allowing it (i.e. not caring that the result may have higher precision).

My2¢ is that it is good to codify the current behaviour for the various float. It is really surprising if the dtype of a reduction depends on the operation.
p.s. Indeed, I think this is true even for integers. At least, to me, the following is neither logical nor expected:
In [17]: np.subtract.reduce(np.arange(4, dtype='i2')).dtype
Out[17]: dtype('int16')

In [18]: np.add.reduce(np.arange(4, dtype='i2')).dtype
Out[18]: dtype('int64')

Explicit is better than implicit and all that. And for reductions, it might be quite reasonable to do the operation at higher precision and check for overflow before downcasting.

And for reductions, it might be quite reasonable to do the operation at higher precision and check for overflow before downcasting.

If you're suggesting a value-based result type, that's even worse. That's the sort of thing we're trying to get away from with the standard.

The rationale given is "keyword argument is intended to help prevent data type overflows.". This came up again in the review of NEP 56 (https://github.com/numpy/numpy/pull/25542), and is basically the only part of the standard that was flagged as problematic and explicitly rejected.

That PR discussion is huge and you didn't point to a specific comment, so I don't know what was already said. But it makes sense to me to treat floats different from ints because floats give inf when they overflow, which is a very clear indication to the user that they need to manually upcast.

That PR discussion is huge and you didn't point to a specific comment, so I don't know what was already said

There's several comments on it. The main one is this comment. Then it got also mixed in with the comment on in-place operator behavior in this comment. And in this comment @seberg said "(I explicitly did not give a thumbs-up for the type promotion changes in that meeting)" (type promotion meaning the sum/prod ones).
I did write it down as one requirement among many (I didn't quite agree with what I wrote myself, but forgot to revisit), it didn't stand out in the text. It's telling that it was flagged quickly by both @seberg and @mhvk as too impactful to change.

And for reductions, it might be quite reasonable to do the operation at higher precision and check for overflow before downcasting.

If you're suggesting a value-based result type, that's even worse. That's the sort of thing we're trying to get away from with the standard.

Internal upcasting is regularly done, and perfectly fine. I assume the intent was "warn or raise on integer overflow", rather than value-based casting.

If you're suggesting a value-based result type, that's even worse. That's the sort of thing we're trying to get away from with the standard.

No, not a different type, that would be awful indeed! But an over/underflow error/warning, just like we can currently get for floating point operations. For regular ufuncs, that is too much of a performance hit, but for reductions, it should not be. And reductions are a bit special already since it definitely makes sense to do things at higher precision internally, before casting back to the original precision.

p.s. Indeed, I think this is true even for integers. At least, to me, the following is neither logical nor expected:

ufunc.reduce is not part of the standard, so it's not really relevant here, but FWIW, I agree with you that it's quite surprising for ufunc.reduce to not return the same dtype as the ufunc itself in some cases. I think of ufunc methods as being somewhat "low-level" things that shouldn't try to be overly smart, at least in terms of behavior (ufunc-specific performance optimizations are another thing).
OTOH sum is a distinct function from add and is a more of an end-user function, so I don't know if the argument applies there.

Proposed resolution: align the standard with what all known array libraries implement today.

@rgommers What would the new wording that you seek to change to?

The current wording that is problematic is:

if x has a real-valued floating-point data type, the returned array must have the default real-valued floating-point data type.
if x has a complex floating-point data type, the returned array must have the default complex floating-point data type.

I suggest a change like this:

if x has a real-valued or complex floating-point data type, the returned array should have either the same dtype as x (recommended) or a higher-precision dtype of the same kind as the dtype of x

This loosens the spec, recommends what the current behavior of all known libraries is, and still allows upcasting if an implementation desires to do so for (reasons).

the returned array should have either the same dtype as x (recommended) or a higher-precision dtype of the same kind as the dtype of x

Thanks, looks good to me.  Maybe it would be slightly clearer to replace the or ... with a new sentence:  If it is not the same dtype it must be a higher-precision...?
(because if you apply the should also to the "or ..." part, it would be a must)

I personally don't see value in hedging with "recommended" or "should" if no one actually does that now and we don't even have a concrete reason for anyone to do so. It feels like our only real rationale is some misunderstanding in the original discussion about int dtypes. Not being precise about dtypes has disadvantages. For instance, it makes it harder to reason about dtypes statically (https://github.com/data-apis/array-api/issues/728). Everywhere else in the standard uses "must" for output dtypes (correct me if I'm wrong on that).
And I also disagree that upcasting is not a big deal. When you're explicitly using a lower precision float silent or unexpected upcasting can have a very real performance impact.

I am fine with being strict here and saying it must be the same: it is the only version that I see giving any clarity to libraries supporting multiple implementations (which is my main emphasis here always, compared to thinking about the ideal end-user API).
But, there must have been some feeling of float16 and float32 having loss of precision quickly that users need protecting that this ended up written down, and I am happy to accept the opinion that it may be a reasonable choice for end-users.
Although, I can see the argument that this is really about intermediate precision of the reduction, an argument that could even be made for integers: So long as you detect the overflow (by aggregating at high/arbitrary precision), forcing users to upcast manually isn't that terrible.

treat floats different from ints because floats give inf when they overflow, which is a very clear indication to the user that they need to manually upcast.

N.B.: To clarify, for summation overflows are actuall not the main issue!  The issue is extreme loss of precision unless you have a high precision intermediate (at least float64).  If you sum float32(1.) naively the result just caps around 2**23 == 8388608 and you may see a decent amount of loss earlier.  A million elements are not that odd in many contexts.

Okay, seems like there is support for "must", and I agree that that is nicer. PR for that: gh-744.

N.B.: To clarify, for summation overflows are actuall not the main issue! The issue is extreme loss of precision unless you have a high precision intermediate (at least float64). If you sum float32(1.) naively the result just caps around 2**23 == 8388608 and you may see a decent amount of loss earlier. A million elements are not that odd in many contexts.

This can be solved by using a higher intermediate precision, or by using a smarter summation algorithm. My point is that the only reason you'd need a higher result precision is if there is an overflow.


[D3D11] Outward VRAM usage keep increasing every time loading new location

VRAM usage keep increasing every time loading new location. Eventually it leaks to RAM and degrade performance, usually loading a new location a single time is enough to make it leaks to normal RAM. Suspected objects not being unloaded properly.
Software information
Outward, medium preset with advanced shader turned on.
System information

GPU: GTX 1650 Max-Q
Driver: nvidia 460.56-7
Wine version: wine-staging v6.1
DXVK version: v1.7.3-37-g3f91cdbc

Apitrace file(s)

Outward.trace

Log files

d3d9.log:
d3d11.log: Outward_d3d11.log
dxgi.log: Outward_dxgi.log

Going out and in of a location increase VRAM usage and RAM usage.

DXVK does not free VRAM allocations by design, this is no memory leak. If there is one, it's almost certanily the game's fault.
Also, the apitrace doesn't really contain anything useful since it just ends after a handful of black frames.

If the resource evicted from VRAM is actually unused, why would that cause any performance problem? Also, does apitrace actually work with steam game? I have tried multiple times and apitrace doesn't behave as I expect.

I can't this reproduce this on AMD Polaris (though with DXVK 1.8.1-1c2edab), changed location about ten times and VRAM usage was still about the same, so this is probably Nvidia-specific. Does this applies to all locations or only the ones from the screenshots?

VRAM usage is via mangohud, and somehow, dxvk-hud doesn't report such increase. It applies to all locations but I do use nvidia.

Ok, tried now with MangoHud and can confirm that VRAM usage value is different in DXVK and MangoHud. According to MangoHud, VRAM usage is stuck at 3.7 GB and RAM usage increases a little with every loading of location, so it looks like memory leak indeed, if the values are not wrong.

Do you get fps degradation as well? I won't mind memory increase if they aren't actually used, meaning don't degrade performance. The thing that bothers me is the fps degradation every loading screen. The degradation is especially huge on a town. If I load the game when my character already in town, I can maintain 60 fps. But when going out and in of a town, the fps start to tank.

No, to my surprise, i don't get FPS degradation.

The worst degradation is between Abrassar Desert and Levant, or Abrassar Desert and Enmerkar Forest. For the latter, my FPS can tank to the 30s.

If the resource evicted from VRAM is actually unused, why would that cause any performance problem?

DXVK will create new resources in system memory when it runs out of VRAM. What doitsujin meant was that DXVK will never move resources around.
And yes, the MangoHUD metric is not relevant here. Focus on the DXVK HUD one.
There probably isn't much we can do here so just lower your texture resolution.
Either way, can't do anything without an apitrace.

apitrace (4.6 GB when extracted).

How to create apitrace, really? Tried to do the command apitrace-latest\bin\apitrace.exe trace -a dxgi Outward.exe on windows and it seems to not working

I used exactly the same command (on Wine), works for me.
wine apitrace-latest-win64/bin/apitrace.exe trace -a dxgi Outward.exe

New apitrace, this time it works properly
Outward.7z
Changing between thees 2 locations have a performance hit.

wined3d doesn't have issues with that because the OpenGL driver does all the black magic for it. DXVK on AMD cards should also be more or less fine since the driver itself has more dynamic memory management than Nvidia's does.
This kind of thing usually happens when the game decides to recreate its render targets and those then end up in system memory, but as mentioned, there's pretty much nothing we can do about that without rewriting a lot of stuff. Lowering texture quality in game might help mitigate the issue, or changing the amount of VRAM reported to the game via dxvk.conf.

Correct me if I'm wrong, but basically the only way to solve this issue is by writing garbage collection for gpu?

This issue seems to affect DCS world and squad, so I'd really appreciate a fix though I fully understand it being a massive amount of work.

DXVK on AMD cards should also be more or less fine since the driver itself has more dynamic memory management than Nvidia's does.

I'm seeing these issues in DCS world on both my old rx 580 and new rx 6800. (game runs fine, then suddenly drops down to sub 5 FPS, especially in texture-heavy environments. IIRC, this doesn't happen right after VRAM usage goes above 100%, I've seen 150% etc. without issue. Maybe that's the render target thing you talked about.

Correct me if I'm wrong, but basically the only way to solve this issue is by writing garbage collection for gpu?

As I understand it, because it's never moved out of the GPU. When new textures etc. have to be loaded, those have to go in system RAM instead of VRAM.

I don't really know what to do here since the only real solution is to rewrite half of DXVK which is obviously not really viable.

Yea, it's an unfortunate situation. In the DCS case, it seems like lowering texture quality a bit helps, and the problems are only happening on one map for me after my GPU upgrade.

Same issues in dx9 (all gamebryo games tes-4, f3\NV) vram overflow and slide show 1-5 fps.
Dxvk start using shared memory?
After loading new location vram not purge.
Is  there way to cap vram usage for dxvk?
d3d9.maxAvailableMemory not affect
@doitsujin
i'm use your buld 1.8-21-gd51562fc9 (fixed regression dx9)
(1.8.1 still crash game)

Is there way to cap vram usage for dxvk?
d3d9.maxAvailableMemory not affect

As I understand it, that just tells the game how much VRAM is available. But as far as the game is concerned, it has unloaded the textures from the previous level, it's just that dxvk does not do that in reality. So .maxAvailableMemory might fix the problem if the game does something like pre-caching a bunch of texture because the space is available.

So after test: max available memory - is a reason of issue. (in my case)
Without it all work fine.
Maybe will be useful to someone. (dx9)

I am sorry if this unrelated, but I noticed a similar issue with MudRunner running under Proton Experimtal: More detailed maps make the game being killed by the OOM killer after taking up more than 14 GB of memory. (This is on integrated graphics with shared memory, but since the memory is not attributed to the process, I guess that it is graphics memory.)
Using WineD3D, the game loads and runs those maps without issues. What is even more interesting, if I load the map using WineD3D and then resume it (instead of initializing a new game) using DXVK, things work as well. So it seems, the game's initialization routines interact in some really unfortunate way with DXVK's memory management.

@HenryJk Are you around to give this a fresh spin with dxvk master? Vram usage and management should be much improved now.

I can try again in a few days

I've given this a spin and there's definitely some heavy defragging going on between areas, as the game destroys some allocations and keeps others. I can see this being a problem before defragging was added for sure, but as of 2.5 there's no memory bump when going between areas.


vacuum_goto not working

Describe the bug
vacuum_goto not working (vacuum does not leave docking station)
vacuum platform is set to tasshack/dream-vacuum
To Reproduce
Trigger a goto-action
Expected behavior
vacuum should go to defined location
Screenshots
map card configuration

task

trace

Additional Information (please complete the following information)

Model Name: dreame.vacuum.r2251a
Firmware Version: 4.3.3_1505
Home Assistant Version: 2024.1.6
Configuration Type [With or without map support]: With Map (v2.0.0b11)
Errors or warnings shown in the HA logs (if applicable):

Not sure, if that object name is privacy related........

Dreamehome

r2251a (=L10 Prime) does not have a camera.

Thanks. Any idea about the expected release date?

Never mind if it is too tricky. Goto-function would have been nice to have, but I use a sequence with the step-move capability now to let the vacuum drive to my trash bin. (It's a short path without obstacles.)

Go To is part of the camera control feature that normally requires an access token to enable it first and then send the vacuum to single or multiple points.
I have discovered that sending the vacuum to a single point without enabling the camera stream works but multiple points does not and the vacuum does the exact thing you are experiencing right now if you try.

Are you saying the later (calling the "Follow Path" service) is not possible? I have an L20 and "Go To" works just fine but follow path doesn't. My robot just goes to a completely random location and aborts after a couple of seconds.

Hi, I have a L10Pro (p2029) using the Dreame app and I am having this same issue, however my logs are different.
2024-09-02 20:43:41.537 ERROR (MainThread) [custom_components.dreame_vacuum] Unable to call go_to: Coordinate is not inside the map
2024-09-02 20:43:41.538 ERROR (MainThread) [homeassistant.helpers.script.websocket_api_script] websocket_api script: Error executing script. Error for call_service at pos 1: Coordinate is not inside the map
2024-09-02 20:43:41.538 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [140545372424944] Error handling message: Coordinate is not inside the map (home_assistant_error) Jeffrey from <IP_ADDRESS> (Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:129.0) Gecko/20100101 Firefox/129.0)

I am using version v2.0.0b16 of the integration and getting the coordinates from the Xiaomi map card.

From the camera entity attributes I can see the coordinates of the charger.

But when I send it there, it still says that it is not inside the map.

I also set the vacuum to clean in the Dreame app and got the coordinates from the "vacuum_position" attribute and it gives the same error.


Made hostname hard requirement, removed default read of socket.gethostname

Added hostname as parameter for auto_assign. This resolves a bug where hosts which claim affinity under a different hostname than what socket.gethostname returns couldn't auto_assign.
Removed the default hostname to prevent libcalico users from encountering this bug.

After some discussion, it seems more appropriate to change libcalico to use a HOSTNAME environment variable instead of relying on orchestrators to pass the hostname variable around.


About

@batpad there should be a minimal about page (about modal) describing what this app is. Think of someone landing on the app without any context.

brief description
link to mapping wiki

So, I got the about modal working in React. I'm going to need a little help with the text. Below is very rough and really just place-holder while I worked on the implementation.

@lxbarth @mikelmaron @geohacker, could you post recommendations. I'll work on this as well and update here once I improve it.

How's this? Where XXXX is a link to docs or the blog post...

OSM Comments was developed to help Mapbox Data Team track conversations in OpenStreetMap. And it's built for anyone to search notes and changeset discussions involving any OpenStreetMap user.
Add "users:<user_names>" in the search bar to find other discussions. For example, "users:geohacker,Planemad" will find notes and changeset discussions only for these users.
Read more on XXXX.

Implemented. Closing.


fix #589 make config file works

Overriding config values by CLI parameters was the intention. But reading config still works (https://github.com/salsita/node-pg-migrate/blob/master/.circleci/config.yml#L189 tests are passing) so what is the specific problem you have?

node-pg-migrate -f migrations.json  not works, by add log in ./node_modules/.bin/node-pg-migrate I found after yargs setup, argv contains default value for most of configs

// $ node node_modules/.bin/node-pg-migrate  x
{
  _: [ 'x' ],
  d: 'DATABASE_URL',
  'database-url-var': 'DATABASE_URL',
  databaseUrlVar: 'DATABASE_URL',
  m: '/tmp/migrations',
  'migrations-dir': '/tmp/migrations',
  migrationsDir: '/tmp/migrations',
  t: 'pgmigrations',
  'migrations-table': 'pgmigrations',
  migrationsTable: 'pgmigrations',
  s: [ 'public' ],
  schema: [ 'public' ],
  'migrations-schema': undefined,
  migrationsSchema: undefined,
  'ignore-pattern': '\\..*',
  ignorePattern: '\\..*',
  'config-value': 'db',
  configValue: 'db',
  f: undefined,
  'config-file': undefined,
  configFile: undefined,
  tsconfig: undefined,
  'dry-run': false,
  dryRun: false,
  fake: false,
  'single-transaction': true,
  singleTransaction: true,
  lock: true,
  timestamp: false,
  i: false,
  version: false,
  '$0': 'node_modules/.bin/node-pg-migrate'
}

The later config read, use readJson, which apply undefined config key, if there is a default config, like migrations-dir can not be overrided.
You config works, because you override a not exists config keys.

Seeing this too - migrations-dir not being set but was working before

Problem is
let MIGRATIONS_DIR = argv[migrationsDirArg]

is set first and then config won't be set in readJson. So this PR should be fine.
However @wenerme I think this code, which reads default config, needs to move too:
try {
  // Load config (and suppress the no-config-warning)
  const oldSuppressWarning = process.env.SUPPRESS_NO_CONFIG_WARNING
  process.env.SUPPRESS_NO_CONFIG_WARNING = 1
  const config = require('config') // eslint-disable-line global-require,import/no-extraneous-dependencies
  if (config.has(argv[configValueArg])) {
    const db = config.get(argv[configValueArg])
    readJson(db)
  }
  process.env.SUPPRESS_NO_CONFIG_WARNING = oldSuppressWarning
} catch (err) {
  if (err.code !== 'MODULE_NOT_FOUND') {
    throw err
  }
}


upstream(ticdc):  init client go global cfg

What problem does this PR solve?

Issue Number: close #9523
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.

/retest

/retest-required


variables in modules

When call the module, I need feed some dynamic variables to that module
module xxx {
  source = "..."
  name = "${local.name_prefix}-xxx"
  file = "${data.template_file.setting.rendered}"
  ...
  vpc_id = "${data.terraform_remote_state.vpc.vpc_id}"
  account_id   = "${data.aws_caller_identity.current.account_id}"
  ...
}

Terraform does NOT process interpolations in .tfvars files. So how can I handle these in terraform.tfvars with terragrunt?

The code you have above is the module you'd deploy with Terragrunt. That is, you'd create, say, modules/my-module/main.tf, and in it, call module "xxx" { ... }, fill in variables, use interpolations, etc. Anything that varies between environments would be exposed as a variable in modules/my-module/vars.tf. You would then use Terragrunt to deploy modules/my-module and the variables you define in your terraform.tfvars would not use/need any interpolations.
See these example repos:
https://github.com/gruntwork-io/terragrunt-infrastructure-modules-example
https://github.com/gruntwork-io/terragrunt-infrastructure-live-example

I just answered that above. You put all the interpolations into modulexxxx. Not into terraform.tfvars. Please look at the examples.

That will be inconvenience. It changes the way we write Terraform.

I don't think it does. If you already have modulexxx, and you're using it in your Terraform code foo, then somewhere in foo, you are using interpolations. All I'm saying is point Terragrunt at foo.

Do you mean, if I need interpolations in a module, then I have to write a wrapper module to call that original module, this is weird.
Maybe I didn't fully understand your explanation, let me think again.

Yes, that's exactly what I mean. You write a wrapper module that configures things the way you need them for your deployment: i.e., it configures the provider, terraform settings (e.g., min version, backends), terraform_remote_state, variables, outputs, etc.

most my tf modules need use interpolation variables.
Seems this is the design. Looks nothing can do in current situation.
Thanks.


Why should I just use 23.2.1? To run correctly on Android 4.2.2

Sorry i did not understand
#Why should I just use 23.2.1? To run correctly on Android 4.2.2
When I update, the version of the libraries does not work the click event.
I need a higher version of appcompat.
compile 'com.android.support:appcompat-v7:23.2.1'
compile 'com.github.bumptech.glide:glide:3.7.0'
compile 'com.alexvasilkov:android-commons:1.2.4'
compile 'com.android.support:cardview-v7:23.2.1'
compile 'com.android.support:design:23.2.1'
Is there any way that libraries can be upgraded?
And your library will work properly on Android 4.2.2 . #57

Duplicate of #57


Feature: Option to publish using symlinks instead of hardlinks

Performance of the publish step of aptly was poor when using aptly with large repositories and a NFS-mounted NAS system. After some tests, I discovered that creating hardlinks on the NAS is much slower than using symlinks: For ~40000 links the difference is 18 minutes (hardlinks) vs 2 minutes (symlinks).
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
An option was introduced into the config-file as well as on the command-line (-use-symlinks) to instruct aptly on a per publish base whether to use symlinks or stay with hardlinks. The default option is to use hardlinks.
For the functional testing, I had to add two new check methods (check_file_is_regular and check_file_is_symlink). In addition, I had to modify the tests that compare json results. Apparently it depends on whether python2 or python3 is used, but travis always complained about different results as the json output contained unicode strings, whereas the provided map was UTF-8. By specifying the result directly as json and parsing it using the json.loads() function I was able to get identical results.
Checklist

[x] functional test added/updated (if change is functional)
[x] man page updated (if applicable)
[x] bash completion updated (if applicable)
[x] documentation updated
[x] author name in AUTHORS

First of all, thanks for taking time to implement feature, it's one of the most requested ones.
I was thinking of providing same feature on a bit different level - aptly supports multiple publish roots: one is default (filesystem with hardlinks), multiple S3, Swift endpoints. I thought that right way to support symlinks/hardlinks and multiple publish directories was to open ability to have multiple filesystem endpoints, each with its own root and options to use either hardlinks or softlinks or even simply doing file copy.
What do you think of that?

I like that approach. It would introduce a lot more flexibility and fit in nicely with the other endpoints.
So after a quick look, the main modification would be to extend the files published storage provider constructor to take an extra argument about what kind of link action it should use, and provide the infrastructure via the config. And of course the tests. :-)
I'll look into it and start on a new branch on my fork.

Closed as new pull request is there with discussed implementation: https://github.com/smira/aptly/pull/521 .


Add movie watched indicator

Add movie watched indicator. This could be a "tick" on the movie, indicating movie has been watched.

This will show the playback progress, so not watched state.


[Docs] Imagenet tutorial

Description
This PR adds a tutorial demonstrating how tensorclasses can be used to load and manage ImageNet data in a training pipeline.

This appears to build correctly in the CI: link to action run
See output here
Benchmarks look pretty compelling too

Cc @nicolas-dufour


Fix broken link to PhantomJS

apparently PhantomJS.org has some DNS issue with their www subdomain..

Thank you!


bug: hardcoded interpolation symbols

Type: bug
Platform: all
Hello,
currently I'am using meteor + angular + ionic. Meteor is using an own templating system called "Blaze+Handlbars" where they are using the same interpolation symbols "{{" "}}" as angular. To work together I need to change the interpolation symbols with the interpolation provider from angular (https://docs.angularjs.org/api/ng/provider/$interpolateProvider). Now the problem is that some ionic directives has hardcodes interpolation symbols "{{" "}}" which makes the directives impossible to use.
If there is a getter from angular's interpolation provider you should get it from there or it is configurable for the whole module.
Example: ion-item directive

Greetings, @ndevr!
We are now requiring all issues to be submitted through our custom issue form so that we have all of the information necessary to fix them as quickly as possible.
Your progress on this issue has been saved at the following url:
link to Ionic issue form
This issue will be closed if not resubmitted through the form. Please fill out the rest of the form so that we may assist you.
Thank you for allowing me to assist you.

Thanks, this has been brought up before and we removed a few of them, but it looks like a few slipped through.

BTW, Angular is normalizing directive templates (i.e. replacing {{/}} with the actual interpolation symbols), so directive templates do not need extra work.

If I'am looking into the sources there are the hardcoded symbols.  Could you show me that on the angular sources?

+1

Hello! Are you all still experiencing this issue in the latest version of ionic?

Hello! Thanks for opening this issue with us! As it has been a little while since there was any activity on this issue I will be closing it for now, please feel free to reply if you are still experiencing this issue though!


Fix Prompt.ask docstr spellings

Type of changes

[ ] Bug fix
[ ] New feature
[x] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[ ] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
Fix Prompt.ask docstr spellings
Promot -> Prompt
readding -> reading

Oops accidentally deleted the branch (it's why the checks failed)


Bridge-1660 - Change in task scheduling and reminders

Change activity reminders to be scheduled at a random time daily, just one reminder, not specific to any activity (For https://sagebionetworks.jira.com/browse/BRIDGE-1660):

Implement subclass of APCTasksReminder to schedule reminders as per above ticket
Override APCAppDelegate doGeneralInitialization to reinitialize .tasksReminder with our APHTasksReminder subclass
Override APCAppDelegate tabBarScenes to use new APHProfile.storyboard instead of APCProfile.storyboard when adding scenes to tab bar
Implement subclass of APCProfileVC to instantiate our APHSettingsVC instead of APCSettingsVC when user taps ‘Activity reminders’
Implement subclass of APCSettingsVC to show only the Enable reminders toggle switch

Ok, so leave as-is for now?

yep, need @syoung-smallwisdom or @Erin-Mounts to take a look to approve tho


[Bug] Vertical scope line color incomplete for wrapped lines

As you can see in this screenshot, as indicated by the yellow arrows, for wrapped lines the vertical scope line does not get full coloring, and the default gray line is exposed. The language here is TypeScript, if that matters.

+1

+1


Any kind of network support, fix #428

By submiting this PR, you agree with the associated license (Apache 2.0 or MIT) and with our Contributor License Agreement (CLA).
Before to begin
Thank you for contributing to the Luos project!
Before to begin, please follow these steps:

[ ] Ensure that this PR is not a duplicate.
[ ] Assign @Simonbdy to this PR
[ ] Add the PR to the Luos contribution project

Feel free to read the Luos contribution's guidelines and the documentation page to have more insight about how to contribute to Luos.
PR Description section
Description and dependencies
Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.
Changes
Please choose the relevant options:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Related issue(s)
Provide a list of the related issues that will be fixed by this PR.

WARNING: Do not edit the checklist below.

Developer section

[ ] [Documentation] is up to date with new feature
[ ] [Tests] are passed OK (non regression, new features & bug fixes)
[ ] [Code Quality] please check if:

Each function has a header (description, inputs, outputs)
Code is commented (particularly in hard to understand areas)
There are no new warnings that can be corrected
Commits policy is respected (constitancy commits, clear commits comments)

QA section

[ ] [Review] tests for new features have been reviewed
[ ] [Changelog] is up-to-date with expected tags
🆕 Feature: [Feature] Description...
🆕 Added: [Feature] Description...
🆕 Changed: [Feature] Description...
🛠 Fix: [Feature] Description...

Here is a representation of the current state of this development.
At this point Luos_engine is usable the same way Luos_engine 2.X.X is. There is no new features at this stage and no known regression.

Now I will work on adding new features.


#564 avoidance of exceptions for flow control to substantially reduce time to debug tests

Before:

After:


Updates to installer dependency toolchain

Use of build dir in toolchain dir instead to /tmp to avoid permissions issues #1429
Change install dir to /usr/bin instead of /usr/local/bin to pass checks in install.sh
Removed comments on commented code that will not run by default anyway
Add check to see if conda enviroment already exists
Improved formatting of installed application version check

close #1429


Proper fix for "[BUG] org-tree-slide mode does not show headings"

https://github.com/hlissner/doom-emacs/issues/2182 still exist and the cause was not that explained in https://github.com/hlissner/doom-emacs/issues/2182#issuecomment-564899286.
The cause is from the line I'm removing in this PR, which actually skips the heading.

Also, what's exactly the code inside defadvice! is doing? I didn't see any effect like starting the presentation from the subtree of my cursor as far as I can see.

As of 8bb54a9 I've turned it into an option (+org-present-hide-first-heading) which is disabled by default, which should resolve your issue.

Thanks for the proper fix!


Cannot spawn a Docker container running as unprivileged user

The advice of creating such an alias in the README is really good and works well:
alias textql='docker run --rm -it -v $(pwd):/tmp textql '

but the problem with it is that it runs textql as root and so the output files are created with that user.
Ideally, the solution would be to use this command instead:
alias textql='docker run --rm --user $(id -u):$(id -g) -it -v $(pwd):/tmp textql '

which works fine when called like this
textql
(...usage shown...)

but not when an actual SQL processing is requested:
textql -sql 'SELECT * FROM groups LIMIT 2' groups.csv
2019/02/12 07:26:44 user: unknown userid 1000

Is there a way to fix that?

@xi-ao Perhaps the change can be as simple as adding a new user in the dockerfile like
RUN useradd app   USER app
and then you can run docker run --rm -u app:app -it -v $(pwd):/tmp textql -header -sql "select count() from test" test.csv
Let me if this solution looks good to you. I can open a PR.


Scraper getting 404 Errors

Hi,
I've suddenly started getting the following error while running the scraper:
RequestResponse(status_code=404, text='{"errors":[{"message":"Sorry, that page does not exist","code":34}]}'), retrying in 15 seconds...
I am using stweet version 2.1.0
Here's what my code looks like:
    tweets_collector = st.CollectorRawOutput()
    users_collector = st.CollectorRawOutput()

    search_tweets_task = st.SearchTweetsTask(
        all_words=search_term,
        since=since_date,
        until=until_date
    )
    web_client = st.RequestsWebClient(
        proxy=st.RequestsWebClientProxyConfig(
            http_proxy=socks5://localhost:9050,
            https_proxy=socks5://localhost:9050
        ),
        interceptors=[TwitterAuthWebClientInterceptor()]
    )
    st.TweetSearchRunner(
        search_tweets_task=search_tweets_task,
        tweet_raw_data_outputs=[tweets_collector],
        user_raw_data_outputs=[users_collector],
        web_client=web_client
    ).run()

I am unable to figure out why my requests are failing. Can you please help? Thanks!

I had the same problem from yesterday.

Could you provide full code of example (not only a part)?

Sure! Here's a full example that demonstrates the problem:
import arrow
import argparse
import stweet as st

from stweet.twitter_api.twitter_auth_web_client_interceptor import TwitterAuthWebClientInterceptor

PROXY_URL = 'socks5://localhost:9050'

def collect_tweets(search_term, tweets_collectors, users_collectors, since_date, until_date=None):
    """
    Run tweet collection and put results into provided collectors.
    :param search_term: Term for which to find tweets.
    :param tweets_collectors: A list of collectors with parent type RawDataOutput for the storage of tweets.
    :param users_collectors: A list of collectors with parent type RawDataOutput for the storage of user information
                             of users who wrote the tweets provided in the other collector.
    :param since_date: Arrow time object representing date starting which tweets should be searched.
    :param until_date: Arrow time object representing date up till which tweets should be searched.
    """
    search_tweets_task = st.SearchTweetsTask(
        all_words=search_term,
        since=since_date,
        until=until_date
    )
    web_client = st.RequestsWebClient(
        proxy=st.RequestsWebClientProxyConfig(
            http_proxy=PROXY_URL,
            https_proxy=PROXY_URL
        ),
        interceptors=[TwitterAuthWebClientInterceptor()]
    )
    st.TweetSearchRunner(
        search_tweets_task=search_tweets_task,
        tweet_raw_data_outputs=tweets_collectors,
        user_raw_data_outputs=users_collectors,
        web_client=web_client
    ).run()

if __name__ == "__main__":
    parser = argparse.ArgumentParser()
    parser.add_argument('--term', type=str)
    parser.add_argument('--since', type=str)
    parser.add_argument('--until', type=str)
    args = parser.parse_args()

    arrow_since = arrow.get(args.since, "YYYY-MM-DD") if args.since else None
    arrow_until = arrow.get(args.until, "YYYY-MM-DD") if args.until else None

    collect_tweets(
        args.term,
        st.PrintRawOutput(),
        st.PrintRawOutput(),
        arrow_since,
        arrow_until
    )

Run with the following command:
python twitter_scraper.py --term musk --since 2023-01-10
Returns the error:
RequestResponse(status_code=404, text='{"errors":[{"message":"Sorry, that page does not exist","code":34}]}'), retrying in 15 seconds...

It looks that twitter have changed something in API – I will check this in few days. Example from readme does not work too.

Thank you @markowanga

I had the same problem from today.

@markowanga did you get a chance to take a look?
Just wanted to say - I really appreciate you creating and maintaining this project. It has been such a help and I can't wait to use it more and perhaps to contribute one day as well.
Again, thank you!

This seems to be related with TLS fingerprinting, many libraries also faced this problem about 2 weeks ago, maybe you could look into these issues: https://github.com/medialab/minet/issues/525, https://github.com/JustAnotherArchivist/snscrape/issues/647, https://github.com/mikf/gallery-dl/issues/3522, and these commits for fixing: https://github.com/medialab/minet/commit/4d80b1dd63537abb3078b8fd7ce8102887206853, https://github.com/JustAnotherArchivist/snscrape/commit/7de8d734e97acc2bc89c93d934b467d5596c6ca8

Thank you :) I will check this

I have released version 2.1.1 now it work correct

@markowanga Thank you so much for fixing.
@Ahacad Thank you very much for finding the solution!

Thank you so much for fixing!

no, 2.1.1  it can't work

我已经发布了 2.1.1 版，现在它可以正常工作

i'm also getting this error. is their any solutions for that ?


[AutoPR cdn/resource-manager] Generate cdn package

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4102

Closing PRs that have been open for more than 1 month.


⚠ Bofrost.at has degraded performance

In c876f13, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1051 ms

Resolved: Bofrost.at performance has improved in dc17ac3.


Manifests mark paster content as protected

If a customer pastes content into a sample manifest, and doesn't override Excel's default options, then the content is marked as protected by default. This is due to the content being pasted in with the 'Normal' style, which on a protected sheet is flagged as protected by default. The solution is to update the normal style to ensure it isn't protected.
More information:
https://superuser.com/questions/392528/why-does-pasting-into-an-unprotected-cell-in-excel-protect-it

Couldn't we remove password protected manifests all together? I think it would be preferable than having customers converting them to CSV for editing.

Its not the customers converting them to CSV, its the SSRs. The password protection was added because customers were renaming columns and then complaining that their upload hadn't worked.


issue90: using the right terminology for parameters and arguments

Address #90

@ftomassetti: I just reviewed the first commit on this branch (88db8b2) where you changed all the parameter names for solving a method declaration from "parameterTypes" to argumentTypes". When solveMethod is called it's probably the types of arguments that are passed to this method but inside the scope of this method they are treated as parameter types and compared to the parameter types of methods that are actually declared somewhere. So I don't know what's better: calling them parameterTypes or calling them argumentTypes. I think I tend towards calling them parameterTypes here, because they are treated as parameter types.
I just found a code snippet that made me ask for proper terminology: Take a look at the public SymbolReference<MethodDeclaration> solve(MethodCallExpr methodCallExpr, boolean solveLambdas) method of the JavaParserFacade here we iterate over the MethodCallExprs arguments and store them in a list called 'params'. That seemed odd.
But that are just my thoughts. I think you are the greater expert in naming parts of a programming language. So don't let me and my suggenstions lead you in the wrong direction ;)

This is not obvious indeed.
I started correcting the case in JavaParserFacacde: I renamed the local variable from params to argumentTypes.
About the different solveMethod definitions I would leave the name of the parameter to be "argumentsTypes". Then we compare the actual types of the arguments with the formal parameter definitions, so probably we should rename here and there some variables like in the case of JavaParserFacade but the idea I got is that:

when we are describing a method declaration we talk about parameters
when we are describing a method invocation we talk about arguments

To adopt this principle we have to fix names in many other places but at least we get started on a common understanding.
Thanks for your comments!

That's how I understand it, too. I'd suggest that we fix those name issues whenever we encounter them :)


Remove --compat=1.17 from dep-update.sh

What this PR does / why we need it:
dep-update.sh has the following comment:
remove compat=1.17 when we move to go 1.18

Since we're running go 1.19+, this argument can be removed.
Release note:

NONE

@awels @mhenriks you seem to know why we needed this. Can you have a look?

/retest-required


Pre-rendering HTML?

Is it possible to render to static html file, perhaps during compile? Similar to React's renderToString(), it would allow faster browser rendering before the JS has loaded (Isomorphic sites), and fallback if JS is disabled.
If the HTML files could be generated at compile time, Karax could be used as a static site generator. I have been using Gatsby and am looking at replacing JS entirely with Nim.
Looks like karun currently generates a blank html template. How much work would be required to implement pre-render and reconciliation with the virtual DOM?

Have a look at this example: https://github.com/pragmagic/karax/blob/master/tests/nativehtmlgen.nim
It's possible.

Seems that karun needs to compile the site to executable first and run to generate the .html files, before compiling to js?
I don't see how I'd run createDom() otherwise.

Update: I have static html generation working. Karax just replaces the root div when it loads. I'll need to figure out how to initialize vdom with the static html.

You don't need karun for this, compile with nim c ...

if you do get this working please consider documenting/including this functionality in Karax. It's something I've wanted for a while.

See/use nim c tests/nativehtmlgen.nim for an example, it exists.

I have added a document about this: #162


Subquery with fill(previous) unexpected behaviour

Bug report
System info:
InfluxDB v1.4.2
CentOS Linux release 7.4.1708
Steps to reproduce:

I have a Influxdb table where I store (among other data) the state of many VPSs, ir can be running, suspended or stopped, and the VPSs are identified by id as a tag, I want to know the total number of VPSs in each state.
The query:
SELECT last("status") AS "status" FROM "tbh_vps"."autogen"."general" WHERE time > now() - 5m AND ("id"='22' OR "id"='41') GROUP BY time(30s), "id" FILL(previous)
Returns the last 11 states of that 2 VPSs and I use fill(previous) because I gather data every 30 seconds and if I run te query after the node has sent the data the last state appears as null.

I'm seeing this as well on 1.2.2.

I can confirm this is also occurring on 1.4.2

This same problem occurs with nested aggregate functions eg:
SELECT non_negative_derivative(max("count")) FROM "messageCounts" WHERE ("env" =~ /^dev$/ AND "messageType" = 'ALL' AND "src"='client' and "dst"='server')  AND time >=<PHONE_NUMBER>362ms and time <=<PHONE_NUMBER>434ms GROUP BY time(10ms), "service" fill(previous)

returns:
1518856552830000000 0
1518856552840000000 9956
1518856552850000000 0
1518856552860000000 0
1518856552870000000 0
1518856552880000000 0
1518856552890000000 0
1518856552900000000 0
1518856552910000000 0
while:
SELECT max("count") FROM "messageCounts" WHERE ("env" =~ /^perfMarketData$/ AND "messageType" = 'ALL' AND "src"='client-gateway' and "dst"='client-library')  AND time >=<PHONE_NUMBER>362ms and time <=<PHONE_NUMBER>434ms GROUP BY time(10ms), "service" fill(previous)

returns:
1518856552830000000 12570354
1518856552840000000 12580310
1518856552850000000 12580310
1518856552860000000 12580310
1518856552870000000 12580310
1518856552880000000 12580310
1518856552890000000 12580310
1518856552900000000 12580310
1518856552910000000 12580310
1518856552920000000 12580310
1518856552930000000 12580310
1518856552940000000 12580310

No investigation for that problem? It seems to be a major issue and it removes a lot of advantages of the FILL function.

Won't fix?

Won't fix?

Any updates on possible fixes? This issue limits the use of subqueries a lot (e.g. merging series sampled at different intervals).

I think I'm hitting a similar problem, here are concrete steps to reproduce.  (Happy to file a new bug if you think this is not the same problem.)
test.txt used in STR below
$ influx -import -path test.txt -precision=s

$ influx
> use testdb
> SELECT MEAN(val2) FROM test GROUP BY id, time(15m) fill(linear)
> SELECT * FROM (SELECT MEAN(val2) FROM test GROUP BY id, time(15m) fill(linear))

I would expect these two queries to give the same result, but they very much do not.  Here's a snippet.
First query results
1582233300000000000<PHONE_NUMBER>857142
1582234200000000000<PHONE_NUMBER>7142856
1582235100000000000<PHONE_NUMBER>571429
1582236000000000000<PHONE_NUMBER>428571
1582236900000000000<PHONE_NUMBER>2857144
1582237800000000000<PHONE_NUMBER>1428567
1582238700000000000 213

Second query results
1582233300000000000 7
1582234200000000000 7
1582235100000000000 7
1582236000000000000 7
1582236900000000000 7
1582237800000000000 7
1582238700000000000 7

Are there plans that this issue will be fixed in version 1.x?

Are there any workarounds for this?

In my case I did some of the work, the InfluxDB should have done, afterwards. My problem was this: https://github.com/influxdata/influxdb/issues/16644
Out of the query that didn't work:
SELECT COUNT(value) AS "count" FROM (SELECT MEAN(value) AS "value" FROM measurement WHERE time >= now()-1h AND time <= now() GROUP BY time(1m), "valuename", "devicename", "someflag" fill(0))
I made this:
SELECT COUNT(*) FROM (SELECT MEAN(value) AS "value" FROM measurement WHERE time >= now()-1h AND time <= now() GROUP BY time(1m), "valuename", "devicename", "someflag" fill(0)) GROUP BY "valuename", "devicename", "someflag"
And iterated over the returned groups and summed up the counts myself in my Node.js application that runs the query.

This would be very useful to be fixed for queries that take a sum of a group because you can never perfectly synchronize the reporting nodes in the group so if you run a subquery without a fill before all of the nodes have added a value for the interval you'll get wrong results until they all do.

This would be very useful to be fixed for queries that take a sum of a group because you can never perfectly synchronize the reporting nodes in the group so if you run a subquery without a fill before all of the nodes have added a value for the interval you'll get wrong results until they all do.


Upgrade to newer dependencies and toolchain

@pmikolajczyk41 or @deuszx Would it be possible to merge this today and publish a new release? That would be great!

@deuszx Argh, I had run clippy locally, but apparently with different flags. I'll fix it.

@cmichi One more thing – I know that CHANGELOG.md became a bit outdated but I think this particular release is more important than other so please add the entry there.

@deuszx Done! Could you re-approve the CI run?

@cmichi new version has been just published

@pmikolajczyk41 @deuszx Great! And thanks for the super quick handling of this PR!


Automated cherry pick of #7581

Cherry pick of #7581 on release-5.33.
/cc  @Willyfrog

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 49edd28122c8151c5dfd8eef5e78efa9efb09ea3


add wishbone test

Add a new test that should currently fail with the narrow address range.
The full address range is meant to be 0x3000_0000 to 0x3fff_ffff
@suppamax
https://github.com/efabless/caravel_mgmt_soc_litex/blob/3fee299f8177cebf7919eb0e6da7f0f5ad7af31d/verilog/dv/tests-standalone/Makefile#L23

Matt to add a warning in the docs

See PR #27


Remove the use-isnan rule

The use-isnan rule in this project has been marked as depricated since version 2.0.3 on April 21 of 2016 - more than 1 year ago at this point.
The rule in the base TSLint rules uses the same rule name, and the documentation states "Core rules cannot be overwritten with a custom implementation." which means that if someone configured "use-isnan": true then it would use the base rule and not this custom rule anyway, so it should be safe to remove.

Haha, no problem.  I maintain a set of custom linting rule + some 3rd party ones (like these!) internally at my organization, and I have some unit tests to ensure that I include all the correct rules when I distribute them to our various apps.  This is one rule I've always had to manually whitelist/exclude from my tests since it's a duplicate of the base rule.


Provide installation instructions and fix a few errors

Added installation instructions
Removed duplicate links
Removed unused values in wrangler.toml
Added who.is link

are you sure I don't need the account id here

I'm not sure what you mean - the only thing I had to change account_id wise was setting account_id to mine in wrangler.toml

When the CI runs here, I think it uses the account_id to deploy it to my Cloudflare account as it isn't set as an environment variable

Yeah that's correct, in the guide I added it just gets the user to replace it with their own so it deploys to the user's cf account instead of trying to deploy to yours

I see right, but if I merge this it will remove the account ID I am currently using from the wrangler.toml which is used in the CI.

Does that better suit your needs? Fixes the bugs and provides a good readme on how to use it but keeps your account id so you can still use it without any reconfiguration

For sure, that's great. Thank so so much!


Blender 4.0 does not recognize ZLUDA

Hi, hoping I can get some insight on this or maybe I'm doing something wrong haha
I am using OpenSUSE Tumbleweed with an RX 7800XT GPU, using the standard Mesa kernel driver.
I extracted the ZLUDA release zip and I added it as an environment variable to Blender like so:
'LD_LIBRARY_PATH=/home/<user>/Documents/zluda/:$LD_LIBRARY_PATH'
I have also tried running it from the command line with LD_LIBRARY_PATH="/home/<user>/Documents/zluda/:$LD_LIBRARY_PATH" blender
And under Blender's Render Device settings there are no options available

Thanks!

Check here: https://github.com/vosen/ZLUDA/blob/master/TROUBLESHOOTING.md

Using ./zluda.exe -- <my_blender_path>/blender.exe gets me Render Device availablity, but even after switching to the right I will use my CPU. No errors anywhere, just uses CPU instead.

Using ./zluda.exe -- <my_blender_path>/blender.exe gets me Render Device availablity, but even after switching to the right I will use my CPU. No errors anywhere, just uses CPU instead.

Have you selected "GPU Compute" in the rendering options for your scene?

Have you selected "GPU Compute" in the rendering options for your scene?

Yeah I did. Even restarted the process and the machine itself too multiple times. Went as far as taking a long benchmark scene to see whether it uses CPU to render or it's just a ZLUDA compile. GPU never went above 4% but most CPU cores maxed out. Although GPU dedicated memory was occupied (around 10 gigs instead of the usual 3 gigs).

What happens if you render from the command line? I used this command (adjust for you blender and zluda paths)
c:\dev\zluda\target\debug\zluda_with.exe -- "C:\Program Files\Blender Foundation\Blender 3.4\blender.exe" -d --debug-cycles -noaudio --enable-autoexec -b "C:\dev\blender_benchmark\benchmark\bmw27\bmw27_gpu.blend" -x 1 -F PNG -f 1 -- --cycles-device CUDA

Nope, nothing. But I might have overlooked something.

Although I might have something.

It might only get the compute cores which are not displayed as usage for whatever reason. Does the same from command line, and using HIP, same speed too.

Tested the same scene render on 3080ti with native CUDA. ZLUDA 7900xtx finished faster. This seems to be a hardware resource monitoring issue.


stdenv-generic: add meta attributes checks

Motivation for this change
Add isFcitxEngine and isIbusEngine to the meta check to allow ibus and fcitx engines to build.
related to #25304
cc @copumpkin
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Thanks for merging!


SignalR CORS add/remove not atomic

https://github.com/Azure/azure-cli/blob/e015d5bcba0c2d21dc42189daa43dc1eb82d2485/src/azure-cli/azure/cli/command_modules/signalr/cors.py#L16-L35
While appreciating that the underlying API does not support atomic operations here, someone not knowing that and working on a system where CORS is programmatically enabled for new clients could potentially lose writes in a race condition. (I'm actually working on such a system now.
Suggestion: the non-atomicity should
(a) be clearly documented in docs, and/or
(b) the methods should be deprecated and replaced with a signalr cors set that operates on the whole list.

route to SignalR service team to help with.

@zackliu please help take a look.

@Arithmomaniac We will add a set operation and update the document to make it clear. As cors add/remove operation are common in cli, I think we can keep it.

this is also not an idempotent command, which results in needing to check the list of CORs before adding.


Show commit authors in different colors

As an enhancement, I think it could be nice to show every author in a different color so it's easier to recognise the different authors.

thanks @miguelcg i like this feature. I'd be happy to accept a pull request where this is an configurable option instead of the default commit color differentiation

I can work on this, feel free to assign it to me. Just a minor clarification, what do you mean by the default commit color differentiation? You mean the dark/light background of each row? Thanks

yes. right now the default logic is to make adjacent commits alternate dark / light. its very subtle.

Thanks @alexcorre, I'll give it a go and see how it looks 😄

Do you like how it looks?

Since it's just a subtle way to distinguish different authors quickly and not colouring the whole cell, do you still want it as a configurable option or do you want to make it the default view?

not in love with the colors, can we grab some colors from the theme? i think there is a way to use color vars that are set by the theme? don't have time to look it up this second but i think this will help it to match whatever style the person has set up on their particular instance of atom
lets make it an option, but can default it to true

also...does it conflict with linter or git status indicators on the lines? Can you show a screenshot alongside that?

The colours are generated "uniquely" for each author based on its name (same name would always generate the same colour). I don't know about the color vars, I would have to investigate about it.
I have to check if it conflicts with linter or git status indicators on the lines, I can't right now though.

This is how it looks with the default git status:

I haven't try with the linter but it shouldn't interfere since the indicators are  next to the line numbers instead of next to the commit authors.

great thanks for your help. go ahead and open a PR and i'll review the code


OSPP: add first version of i18n-tool

What type of PR is this?
feature

What this PR does / why we need it:
This is the auto i18n-tool
Which issue(s) this PR fixes:
Fixes #53
Special notes for your reviewer:
It's for ospp project.
Does this PR introduce a user-facing change?:
No, It's just for developer.

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chouchongYHMing You need to rebase the main branch before submit the PR

/retitle [Summer OSPP 2024] Karmada Dashboard Automation i18n Tool

and we should split the proposal and the implementation, one PR only for proposal, the next one only for implementation

/assign


Add retry to update NetworkPolicy status

To reslove the conflict problem in updating NetworkPolicy status
process, add a retry logic in updating NetworkPolicy status function.
Fixes: #3133
Signed-off-by: Wu zhengdong<EMAIL_ADDRESS>

/test-all

Codecov Report

Merging #3134 (0b295e7) into main (a5114e7) will increase coverage by 16.49%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #3134       +/-   ##
===========================================
+ Coverage   40.35%   56.85%   +16.49%
===========================================
  Files         167      295      +128
  Lines       20879    24927     +4048
===========================================
+ Hits         8426    14171     +5745
+ Misses      11632     9220     -2412
- Partials      821     1536      +715

Flag
Coverage Δ

kind-e2e-tests
39.89% <0.00%> (?)

unit-tests
40.30% <0.00%> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/controller/networkpolicy/status_controller.go
54.91% <0.00%> (+5.89%)
:arrow_up:

pkg/agent/cniserver/ipam/antrea_ipam_controller.go
61.53% <0.00%> (-3.85%)
:arrow_down:

pkg/controller/externalippool/controller.go
83.81% <0.00%> (-1.74%)
:arrow_down:

pkg/apiserver/handlers/webhook/convert_crd.go
2.56% <0.00%> (ø)

pkg/apiserver/handlers/webhook/mutation_crd.go
0.00% <0.00%> (ø)

pkg/apiserver/handlers/webhook/validation_crd.go
0.00% <0.00%> (ø)

pkg/apiserver/handlers/webhook/mutation_labels.go
24.71% <0.00%> (ø)

...et/versioned/typed/system/v1beta1/system_client.go
45.45% <0.00%> (ø)

...yped/clusterinformation/v1beta1/antreaagentinfo.go
15.06% <0.00%> (ø)

pkg/legacyapis/core/v1alpha2/webhook.go
0.00% <0.00%> (ø)

... and 226 more

/test-all

/test-integration

s/reslove/resolve/

s/reslove/resolve/

@tnqn Thanks for the review, updated.

/test-all

/skip-all

/skip-all

/skip-all


ImportError: DLL load failed while importing _wenet: 找不到指定的程序。

Traceback (most recent call last):
File "D:\PyCharm Projects\test\main.py", line 4, in
import wenetruntime as wenet
File "D:\PyCharm Projects\test\venv\lib\site-packages\wenetruntime_init_.py", line 1, in
from .decoder import Decoder  # noqa
File "D:\PyCharm Projects\test\venv\lib\site-packages\wenetruntime\decoder.py", line 23, in
import _wenet
ImportError: DLL load failed while importing _wenet: 找不到指定的程序。

can you show more info ：
windows version
python version
wenetruntime version

windows version：win10
python version:3.8
wenetruntime version:1.14.0

Dream
@.***

------------------ 原始邮件 ------------------
发件人: @.>;
发送时间: 2023年10月9日(星期一) 上午9:52
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [wenet-e2e/wenet] ImportError: DLL load failed while importing _wenet: 找不到指定的程序。 (Issue #2036)
can you show more info ：
windows version
python version
wenetruntime version
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

missing some lib？ WIll fix son。

Is it the problem with this package itself? Or am I using the wrong installation method？

Is it the problem with this package itself? Or am I using the wrong installation method？

package self。

Hi，i also meet this problem. Can this problem only be solved in wsl? Can it not be executed in windows?

Now I can't execute it in Windows. But in Lunix it can.
---原始邮件---
发件人: @.>
发送时间: 2023年10月19日(周四) 上午10:37
收件人: @.>;
抄送: "Zhang @.>;"State @.>;
主题: Re: [wenet-e2e/wenet] ImportError: DLL load failed while importing _wenet: 找不到指定的程序。 (Issue #2036)
Hi，i also meet this problem. Can this problem only be solved in wsl? Can it not be executed in windows?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: @.***>

Thanks for you reply. Now it works on windows. i just use git clone https://github.com/wenet-e2e/wenet.git, and then install wenet.

You mean that clone wenet from github firstly and then use pip to install wenet module?发自我的手机-------- 原始邮件 --------发件人： wlyua @.>日期： 2023年10月19日周四 13:10收件人： wenet-e2e/wenet @.>抄送： Zhang Tonghui @.>, State change @.>主    题： Re: [wenet-e2e/wenet] ImportError: DLL load failed while importing _wenet: 找不到指定的程序。 (Issue #2036)
Thanks for you reply. Now it works on windows. i just use git clone https://github.com/wenet-e2e/wenet.git, and then install wenet.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

yes. just run these three lines of code in the terminal：
git clone https://github.com/wenet-e2e/wenet.git
cd wenet
pip install .
Then I can work on windows, i think we lost wenet model, so cant run on windows, but i dont know why it can works in linux without wenet. BTW pip3 install wenetruntime also need.

Thank you, I will try it later.发自我的手机-------- 原始邮件 --------发件人： wlyua @.>日期： 2023年10月20日周五 09:41收件人： wenet-e2e/wenet @.>抄送： Zhang Tonghui @.>, State change @.>主    题： Re: [wenet-e2e/wenet] ImportError: DLL load failed while importing _wenet: 找不到指定的程序。 (Issue #2036)
yes. just run these three lines of code in the terminal：
git clone https://github.com/wenet-e2e/wenet.git
cd wenet
pip install .
Then I can work on windows, i think we lost wenet model, so cant run on windows, but i dont know why it can works in linux without wenet. BTW pip3 install wenetruntime also need.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>


thanks for all

Description
i dont have a problem i want to say that thanks for all this library is amazing what can i say i dont know only thanks for everything
Full steps to reproduce the issue
not problem
Issue Type
No response
Operating System
No response
Do you use Docker?
None

Totally agree, this library saves lives! :-)

ive been having fingerprinting issues..

ive been having fingerprinting issues..

https://github.com/ZFC-Digital/puppeteer-real-browser/issues/205

@Skorchekd
maybe that works but i didnt use it. him was use with puppeteer maybe it works with puppeteer-real-browser. u can try it
https://github.com/ZFC-Digital/puppeteer-afp

Hello, thank you for this nice problem. It makes me very happy that my open source software solves other people's problems.
@nwebson is the person to thank. I would like to thank him for open sourcing the rebrowser project and making a great contribution to the node.js ecosystem.

this's a good lib

the best


Remove fold1 from Foldable1

Neither Foldable nor Bifoldable have a fold or a bifold method, is there any reason for Foldable1 to have fold1?
The only use of foldMap1Default in core libraries occurs in the Foldable1 instance for NonEmptyArray but this is easy enough to fix with a JavaScript implementation (like we do for foldr1 and foldl1), which should also be more efficient since it wouldn’t have to iterate through the array twice.
Close https://github.com/purescript/purescript-foldable-traversable/issues/125, close https://github.com/purescript/purescript-foldable-traversable/issues/117.

I'm not particularly keen on this personally, see discussion in #125

To reduce the amount of breakage outside of core / to make it easier to upgrade, could we rewrite foldMap1Default so that it’s based on foldl1 rather than removing it entirely?

We cannot implement foldMap1 with foldl1 because the accumulator and the values have to be of the same type.

How about adding a Functor constraint and using \f -> foldl1 (<>) <<< map f?

Oh right. I don’t think we should promote an inefficient default implementation of foldMap1 that has to traverse twice though, especially since Foldable1 instance will have to be updated anyway and that the existing implementation of fold1 can easily be turned into an implementation of foldMap1.

I think in many contexts, an extra traversal adds a (more or less) negligible performance cost, and having the default implementation there will make upgrading slightly less of a pain so I think I'd still prefer to keep it - especially since, as I just spotted, my proposed implementation is basically the same as the existing one. Most of this library is pretty poor performance-wise; if you care about performance you should probably avoid it and use specialized folds instead anyway.

Should we also bother with foldMap1DefaultL and foldMap1DefaultR default implementations (where foldMap1DefaultR is implemented with foldr1 and we alias foldMap1DefaultL to foldMap1Default) for consistency with Data.Foldable?

That works for me. Are you imagining putting a deprecation warning on foldMap1Default saying to use foldMap1DefaultL instead?

To clarify, is this PR ready to be merged? I think all feedback has been addressed.

Looks like this PR broke these libraries:

tuples
lazy
free

I'll submit PRs removing the fold1 member from their Foldable1 instances.

PRs have been submitted:

Tuples - merged by the time I wrote this
Lazy - https://github.com/purescript/purescript-lazy/pull/32
Free - https://github.com/purescript/purescript-free/pull/110
Nonempty - https://github.com/purescript/purescript-nonempty/pull/44

I opened https://github.com/purescript/purescript-ordered-collections/pull/43 to fix the Foldable1 instance for NonEmptySet, it should be the last one in core!


Remove secrets from codebase

remove secrets from codebase
added a script that generates env secrets
updated docs

Not sure I see the need in this PR.
None of the secrets here are actual secrets - DB connection strings are trivial exactly because they run inside the same docker deployment and are not exposed to the outside world.
Centralized configuration is even less important as it's used only for local development.
Overall it seems like an unnecessary complication...

Not sure I see the need in this PR.

The PR is for first task in https://gitlab.com/datopian/tech/issues/62
If we don't really need it, then (sad) let's close it.
@pwalsh what do you think?


add roles only feature / requested by WPB

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks ok to me, but will let Avik approve, did you test updating an existing tenant release user role with the remove roles flag, and then updating the groups to see if it all worked as expected?

@srb3 tested this scenario, works as expected.

@bhatikuldeep can I suggest the following? Rename groups-and-roles.yaml with groups-and-roles_anchor.yaml/groups-and-roles_wpb.yaml. Rename old-groups-and-roles.yaml with groups-and-roles.yaml/groups-and-roles_wsit.yaml. Update readme with the new option, add example ( same as groups with workspace) and also worth mentioning to rename the groups-and-roles.yaml when running on the local.
If you have not already, suggest following manual tests.

Test applying roles with existing workspace.
Test applying roles with non-existing workspace(ignored)
Wipe Worksapce (since you have changed the index position of this command, just to be safe).

@avik-sengupta-kong all tested and file name corrected, can you approve PR?


Rearrange the order of files on curse to the following

Jar files should be uploaded last.
But first, compilation files, and installers should be uploaded first. That way, curse can pick up on only the jar file, and thus, allow users to update it via the launcher without issues, and if they want to use installers or compilation files, they would have to go to the site for that.
Also, I suggest allowing for manual installation as well. The installer is currently very buggy.

I don't find any bugs in the installer... We will upload a new version for our mod, so that the CurseVoice-bug gets fixed...


Godot 1.1 crashing on startup (Win7 32bit)

When I try to execute godot_win32-1.1.stable.exe, the application crash, showing the message: "godot_win32-1.1.stable.exe has stopped working"
In the console (which is opened when executing the .exe file), the next entries are displayed:
EXEC PATHP: C:\Workpace\godot_win32-1.1.stable.exe
EXEC PATHP: C:\Workpace\godot_win32-1.1.stable.exe
DETECTED MONITORS: 1

The PC specs are the following:
OS: Windows 7 Professional SP1
Processor: Pentium Dual-Core E5800 3.20GHz
Video Adapter: Intel(R) G41 Express Chipset

@jfmdev Just a blind suggestion: are your drivers up-to-date?
Also, are you able to run games/programs that require openGL?

@bojidar-bg Thanks for the suggestion, but:

Yes, my drivers are up-to-date.
Yes, I'm able to run programs that require OpenGL (I can run Blender, Unity and MakeHuman without problems).

@jfmdev I'm pretty sure I've seen this problem on a friend's machine. (though I don't remember the workaround). Maybe you can try to build from source yourself?
 If you aren't sure you can try the 64bit version too :smiley: .
@jfmdev ~ BTW, Unity uses DirectX on windows (except if you run it with the --force-opengl flag) :laughing:

@bojidar-bg Yes, I'm 100% sure that's a 32bit machine.
I tried to build godot from the source, but the error keeps occurring.
By adding some cout instructions to code, I have find out that the application crash when tries to execute the line 1203 of the file os_windows.cpp:  visual_server->init();. And if I go to the definition of that method, in the file visual_server_raster.cpp, the application crash on the line 7466: rasterizer->init();.

@jfmdev Where exactly in the rasterizer->init() does it crash :smiley: ?

I have also build the release 1.0, but the error occurs also in that version.

@jfmdev ~ What about downloading the 1.0 version? Does it work?

@bojidar-bg Thanks for your help, but it seems that I'm at a dead end: Godot do not works in some Intel GMA based GPUs (source Error while starting godot_win32.exe and Installer Crashes #995 ), so no godot for me...

@jfmdev Well, installing linux or playing around with virtualbox was always an option..... :wink:

I have the exact same issue, Windows 7 32 bits , this hardware specs: https://translate.google.com.mx/translate?sl=es&tl=en&js=y&prev=_t&hl=es-419&ie=UTF-8&u=https%3A%2F%2Fpcel.com%2FAcer-5736Z-4359-70825&edit-text=&act=url

Try to run Godot on compatibility mode and in administrator mode, I had the same problem and this solved it.
Right click on Godot > Properties > Compatibility > Select a Operating System that you think it will work properly > (at the end of the window) Check run as administrator > OK > Test! :laughing:
Or
Right click on Godot > Solve compatibility problems > Follow the instructions :wink:

Duplicate of #156, related to #1162.


Make git submodules with directory mapping searchable

Feature description
I have a solution with over 200 other repositories attached as submodules. Could you make the module selector searchable?

Hello 👋  I thinks it's doable! I must admit we never paid much attention to this particular feature since we never had any serious use cases for it 😅 but for your request we will try to deliver it soon! 🚀

And... out of curiosity, how did you learn about this plugin? 🤔

I started to use it after watching this. It is hard to say precisely how I stumbled upon that video (most likely after reading a blog from my morning-brew feed). I liked the idea behind easier branch management. I have used the plugin for over half a year (in Rider).
Regarding the 'missing search,' I would not notice it, but I'm in the process of consolidating our NuGet packages, and git submodules seem to be an approach to make the process less painful 😂

I started to use it after watching this. It is hard to say precisely how I stumbled upon that video (most likely after reading a blog from my morning-brew feed). I liked the idea behind easier branch management. I have used the plugin for over half a year (in Rider).
Regarding the 'missing search,' I would not notice it, but I'm in the process of consolidating our NuGet packages, and git submodules seem to be an approach to make the process less painful 😂

oh, ofc. we have asked you about it already 🤦♂  thanks for the detailed response ! 😄
The features you requested are on the way! 🚀

merged to develop. @PawelLipski, when can we release it? 🚀

Actually, lemme draft a release PR...