feat(accordion): 1:1

This is the pr for the pfe 1:1 between pfe4 and patternfly elements
Closes #2047
Example patternfly.org accordion component
<Accordion>
  <AccordionItem>
    <AccordionToggle onClick={() => { onToggle('def-list-toggle1'); }} isExpanded={expanded === 'def-list-toggle1'} id="def-list-toggle1">
        Item one
      </AccordionToggle>
      <AccordionContent id="def-list-expand1" isHidden={expanded !== 'def-list-toggle1'}>

          Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et
          dolore magna aliqua.

       </AccordionContent>
      </AccordionItem>
  </Accordion>

Example proposed patternfly-elements accordion component
<pfe-accordion>
  <pfe-accordion-header>

Accordion header 1

  </pfe-accordion-header>
  <pfe-accordion-panel>

Lorem, ipsum dolor sit amet consectetur adipisicing elit. Quos eius architecto sint sed provident. Fugiat quibusdam voluptas eveniet, facere repellendus aperiam aliquid voluptate est porro magni itaque laboriosam voluptatem modi?

    </pfe-accordion-panel>
</pfe-accordion>

make sure to add a changeset and keep it up to date with api changes

@marionnegp -

Updated the demos to match the pf demos
Added the bordered styles to the large variant

We don't need the demo showing the nested accordion though technically it's still possible with how it's set up on our and patternfly's side to have these nested accordions.  Maybe we just don't demo it & it remains an unsupported piece of pfe but rhds it'll be more front and center.  What do you think?

@brianferry, the large heading isn't loading in the bordered demo anymore. Any idea why?

Notes from Design Systems office hours:
User expands a collapsed panel in a single, nested accordion
EXPECTED: only the parent accordion closes it's open panels
ACTUAL: All accordions in the nested accordion's tree close open panels, i.e. the ancestors

have every accordion be a single context provider
have every header be a single context consumer
attach the header's single context provider to the change event
in accordion, when handling change events, only act if
event.provider === this, meaning that the accordion object handling the event
is truly the nearest ancestor

Potential gotchas:

can we use closest? tagName, shadow dom boundaries
test for late-upgrading intermediate child (see AB tests on RHDC)

@brianferry, let's keep the nested accordion demo. It's being used somewhere in Customer Portal's Case Management tool.

@brianferry, let's keep the nested accordion demo. It's being used somewhere in Customer Portal's Case Management tool.

Would they be switching over to the rhds accordion when that one is implemented?

@brianferry, I'm not sure if they'll be switching. I misread her message, and they're actually using PF for their nested accordion. I guess it does exist in PF.

@brianferry, I'm not sure if they'll be switching. I misread her message, and they're actually using PF for their nested accordion. I guess it does exist in PF.

@marionnegp - Font size should be fixed on the demo for large components now.

@brianferry thinking it over i'm not certain we need context.
In the change handler, you could do something like this:
const parent = event.composedPath().findLast(el => el instanceof PfeAccordion);
if (parent === this) {
  // collapse other panels
}

Looks good to me now, @brianferry!

@brianferry thinking it over i'm not certain we need context.
In the change handler, you could do something like this:
const parent = event.composedPath().findLast(el => el instanceof PfeAccordion);
if (parent === this) {
  // collapse other panels
}

@bennypowers building off of this I was able to fix the issue now on https://deploy-preview-2114--patternfly-elements.netlify.app/components/accordion/demo/
The nested accordion is the first example on the demo currently and shows the nested accordion also with the single flag turned on.  Only real difference was using find instead of findLast and sending the parent into the function where we collapse the panels.

will it work if you nest them 3 levels deep?

It does, I've updated the demo so the last example shows all the nested accordions & three levels deep

some notes from system fed discovery:

we'd prefer to remove all the url state code from this component, so that it becomes an app-level concern instead
similarly, expanded-index attr should be removed in favour of expanded attr on individual panels. the js property can stay though, and so could any sort of expandIndex(i: number): void method


[ADD] Test assertions.

Work in progress.
To compare test failing on Travis with those on Azure.

Technically they aren't unit tests, they're integration tests (unit tests evaluate the expected behaviour of a single function independently, whereas integration tests evaluate how several functions work with each other, i.e. a user experience or a pipeline). Just semantics though, they're all tests regardless 😅.

unit tests evaluate the expected behaviour of a single function independently

- script: octave --no-gui --eval "disp(pwd); ls; bootstrapTestAzure; cd('Test/MoxUnitCompatible'); res=moxunit_runtests('BatchExample_qmt_sirfse_test.m'); exit(~res);"

I don't see any UX or pipeline here 😄. It is just (like many other we already have on Travis) to check if a single unit (unless you call every sub-function a unit) works as expected. There is not any "integration" , e.g. to a service. As you said, semantics.
The glossary of all these cont integration, cont deployment, functional tests, unit tests etc. is  a long list...

Well, it reproduces on Azure as well 🤦♂

In that case, there is definitely an issue with the Octave libraries/packages/versions/something, that are leading to these differences. Can't blame it on Travis caches anymore :P

I don't see any UX or pipeline here 😄. It is just (like many other we already have on Travis) to check if a single unit (unless you call every sub-function a unit) works as expected. There is not any "integration" , e.g. to a service. As you said, semantics.

BatchExample_qmt_sirfse_test.m is a pipeline, it evaluates a ton of different functions, not a single one.

This is an example of a unit test, as it specifically only tests a single method of the model, a method which doesn't interact with any other piece of the code:
https://github.com/qMRLab/qMRLab/blob/3afab2f9f6226c3ce2cb50b5a10500985c7b4da8/Test/MoxUnitCompatible/quickMoxTests/inversion_recovery_Test.m#L25-L37

Read more about it here: https://stackoverflow.com/a/5357837/4411303

BatchExample_qmt_sirfse_test.m is a pipeline, it evaluates a ton of different functions, not a single one.

The static method analytical_solution@inversion_recovery calls Mz = ir_equations(params, seqFlag, approxFlag);. So, it interacts with other piece of code. Then it is not an example of a unit test?
Apparently, the definition of unit can easily become flexible. Would you still call it an integration but not a unit if all those functions were collated in a single script? Anyways, this discussion is not solving a problem, so there is no point in advancing it under a PR 😄
@mathieuboudreau now we have the advantage of running this qmt_sirfse on the exact same environment that tests it. If it still fails, then we will need to look under the hood. I don't have remote access to that machine, probably will do it later.

There is definitely a grey zone between unit and integration tests; but the batch examples are certainly not things that I'd consider unit tests. There's nothing wrong with it being an integration test, I was just trying to clarify because both have their benefits and drawbacks, and we should actually have both. Calling everything "unit tests" makes this distinction meaningless; we should simply write more unit tests.
Here are a couple of folders containing files with mostly unit tets that I wrote a while back that used the MATLAB testing suite that are currently unused in Travis:
https://github.com/qMRLab/qMRLab/tree/master/Test/Common/sim
https://github.com/qMRLab/qMRLab/tree/master/Test/Common/pulse

Anyways, this discussion is not solving a problem, so there is no point in advancing it under a PR 😄

I was mostly pointing this out because we established at the meeting yesterday that we should be writing better/clearer PR names, since you want to automate the CHANGELOG with Azure ;)

@mathieuboudreau thank you for the remarks, I will close this PR once WIP stuff is done and open a new one with the name [ADD] Test assertions.

No need to close & reopen; PR titles are editable. I just did so!

[ ] Run qmt_sirfse_batch on tristano and save output with --mat7-binary flag.

I am closing this PR to implement this feature in MATLAB CI.

I am closing this PR to implement this feature in MATLAB CI.


Remove favorites

Need a way to remove a favorited file from the cached files modal.

@James-Crean take a look at this Section #1, maybe we should be using IDs not classes to stop the any draggable being able to drop on any dropable
https://blog.kevinchisholm.com/html5-javascript/getting-started-with-html5-drag-and-drop-part-iv-multiple-draggables-and-multiple-droppables/


[REVIEW]

Resume link
https://drive.google.com/file/d/1CcZBPj0vcsJ06cZqWCH68VcKKY2Gy3Ma/view?usp=sharing

I understand what you've done with the search bar at the top, but I wonder if the sentiment comes across because the rest of the design does not continue in the 'google' style.
You used many colors which is disctracting. Choose just one or two as it makes it easier to know where to look.
Great that you place your internships near the top. I'm sure employers would love to have more details about what you did/learnt at each one.

Yeah sure I will look in to it. Thank you so much for your time Ma'am.


Top and left coordinates issue

If you don`t mind, I repeat the question, that I wrote you by email and add some material!
I am working on a personal project related with iOS "Storyboard" design.
As a core layout system, I chose your AutoLayout.js library, because it is claimed as the Apple's algorithm which they use in Xcode and iOS applications.
However, the lack of examples makes it difficult to understand how to use it.
In particular the problem is: my program loads ".storyboard" file which has some widgets and constraints tags defined in View. Then I add constraints directly from storyboard to autolayout library in that way:
from:
constraint firstItem="first_id" firstAttribute="left" secondItem="button_id" secondAttribute="left" constant="10" id="constraint_id"
to:
autolayoutView.addConstraint({
view1: "view_id",
attr1: "left",
relation: "equ",
view2: "button_id",
attr2: "left",
constant: 10,
multiplier: 1
});
and then set the size of subView and View:
autolayoutView.setSize(600, 600);
autolayoutView.subViews.button_id.intrinsicWidth = 100;
autolayoutView.subViews.button_id.intrinsicHeight = 100;
So, after that the solver gives me some strange values:
bottom: 0 centerX: 40 centerY: -50 height: 100 intrinsicHeight: 100 intrinsicWidth: 100 left: -10 name: "child1" right: 90 top: -100 type: undefined width: 100 zIndex: 0
That's not the information that is useful for me, since the solver don't know anything about current position of an element in order for me to reposition them.
And it is not suitable for me to use VFL implementation.
The main problem, that I faced, that I can not re-position my widgets due to the lack of initial coordinates (top and left are similar to x and y). For example, if I have left button constraint to the parent view left with 10 value (like in constraint tag), then the position of the element will be the same, only left part will change from the current position to the position which has 10 margin from the parent view. Could this somehow be resolved?
 Thank you!! Your help would be great!

So let me start by repeating the answer I also gave by email:
As for your question. In order for a view to calculate the the positions of the added sub-view, you need to set the width and height of the view:
autolayoutView.setSize(500, 200); //width, height
And as for how the constraints are evaluated. AutoLayout uses mathematical equations, so it can be best viewed from that perspective.
When you want to align the left part of a view 10px from the left-part of the superview, you have to use -10 instead of 10.
I know it can be a bit confusing though, but the equation looks like this:
view_id.left = button_id.left - 10
which, when you want to solve "button_id.left", becomes:
button_id.left = view_id.left + 10
The full equation looks like this:
view1.attr1 = (view2.attr2 * multiplier) + constant
In order to experimentally understand how it works, it's best to use the Visual Format Editor:
https://rawgit.com/IjzerenHein/visualformat-editor/master/dist/index.html
There you can input VFL, and see what kind constraints it produces.
Hope that helps.

Hi, to be honest (I read your question 5 times already), but I'm having a hard understanding what you are trying to convey. Could you try to explain again (perhaps with a more elaborate example) what it is that you are trying to achieve?

Ok, the problem is in defining new position of widget due to constraints.
if we have:  in storyboard widget.
and constraint: attr1: "left", view2: "button_id", attr2: "left", constant: 10.
The button should update it's position in that way (on screen there is 70 points shifting but actually it have to be 90):

So, that's the way I thought AutoLayout works, but the values, that It gives to me rather strange.

I still don't understand what you mean..
Could you perhaps just paste the storyboard file here so I can understand the subviews and constraints that you have?


Possible wrong position of waist IMU ergoCubSN001

Task description
Today, during experiments with ergoCubSN001, we wanted to check the position and orientation of the waist IMU. First of all we looked to the IMU in the real robot. Afterwards, we compared them with the ones of the URDF model (we use this version of ergocub-software e4b567e67e746340051e296b0d9ed74c164f454b).

As we can see in the image, the position of waist IMU in the real robot seems a bit different wrt the URDF one.
Definition of Done
Understand if position of waist IMU is correct
cc @LoreMoretti @GiulioRomualdi

cc @Nicogene and @traversaro

The imu in the waist has been added in the SN000 urdf as XML blob (since the simulation model cad is unmaintained):

https://github.com/icub-tech-iit/ergocub-software/pull/99

I didn't recall that is still exported as XML blob also in newer models:
https://github.com/icub-tech-iit/ergocub-software/blob/b030a601111490a1e0739d14ff45cee5d1181555/urdf/creo2urdf/data/ergocub1_1/base_1_1.yaml#L1142-L1150
Maybe @Mick3Lozzo recall why we didn't exported that frame, but we should do it from the cad (cc @fiorisi @Lawproto)

If I correctly understood the problem I think that the IMU was moved because of a possible collision with the torso covers: https://github.com/icub-tech-iit/project-ergocub/issues/107#issuecomment-1531510392.

If I correctly understood the problem I think that the IMU was moved because of a possible collision with the torso covers: icub-tech-iit/project-ergocub#107 (comment).

Good catch!

Today I checked the transform between the SCSYS_TORSO_1 and the waist IMU csys and here is the result

I used this snippet using the idyntree binding for getting xyzrpy:

rpy = idyntree.bindings.Rotation(0, 0, -1, -1, 0.000105208, 0, 0.000105208, 1, 0).asRPY()

And I got:
-<origin xyz="0.0354497 0.00639688 0.060600" rpy="1.5708 0 -1.5708"/>
+<origin xyz="0.0606 -0.00639428 0.01745" rpy="1.5708 -0.000105208 -1.5708"/>

The difference seems not only a displacement, I used the correct CSYS for computing the transform? Are those csys correct? I took them from ecub.asm (cc @fiorisi @Mick3Lozzo)

xref:

https://github.com/icub-tech-iit/ergocub-software/issues/215

xref:

ergoCub SN001/ ergoCubGazeboV1_1*: the waist imu is still added as xml blob to the urdf #215

@Nicogene what kind of IMU support is AMI using? I am going to check.
cc @fiorisi

xref:

ergoCub SN001/ ergoCubGazeboV1_1*: the waist imu is still added as xml blob to the urdf #215

@Nicogene what kind of IMU support is AMI using? I am going to check.
cc @fiorisi

The xsens mti that is mounted in the torso, I got that transform pulling the latest cad-mechanics

The difference seems not only a displacement, I used the correct CSYS for computing the transform. Are those csys correct? I took them from ecub.asm (cc @fiorisi @Mick3Lozzo)

These are the same values I found @Nicogene.

Thanks @Mick3Lozzo !
That very small rotation on pitch is strange ( we can also approximate it to zero ), but it this is the correct pose I will change the urdf accordingly

Something has to be fixed:

https://github.com/icub-tech-iit/ergocub-software/pull/267#issuecomment-2399838233

Probably on creo2urdf side

Hi @fils99, with:

#267

The position of waist_imu_0 is:

That seems coherent with

Thanks @Nicogene!


core: update committee every [committee length] blocks

Was changed in https://github.com/neo-project/neo/pull/1848. Affects
storage dumps.

Not sure, what should I do with the test. Voting in our SingleTestChain occurs every single block, because we have the only validator in committee.

@AnnaShaleva I think, we may extend the committee in config for a single node. Interesting to see if it breaks any other tests.

Voting in our SingleTestChain occurs every single block, because we have the only validator in committee.

And it's a perfect edge case that must be handled correctly. Extending the committee is OK for some particular test (like the one that want to vote two blocks before committee refresh, but this edge case must be tested too.
@fyrchik --- where is a PR for neo-project/neo#2062? I'm OK with merging this if you have an appropriate update, but otherwise we need to fix the test here.

@fyrchik --- is it possible to fix the test here without #1552?

@roman-khimov as I wrote, yes, but we need to extend the committee in unittest cfg. Or just make 2-nd test similar to the first and postpone config update.


[Bug]: ForYouScreen and InterestsScreen TopAppBar background color

Is there an existing issue for this?

[X] I have searched the existing issues

Is there a StackOverflow question about this issue?

[X] I have searched StackOverflow

What happened?
ForYouScreen and InterestsScreen are not using the same background color:

ForYouScreen
InterestsScreen
Diff

Relevant logcat output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I believe this is resolved with the current version of the app, closing!


draft: add openvoice backend

Part of https://github.com/mudler/LocalAI/issues/1126
Fixes: https://github.com/mudler/LocalAI/issues/1639

This needs more testing - but easier to do that with container images in master


Update README.md

Update for git clone command when pulling project.
Description of changes:
Fix for typo in pull command example
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for the contribution.


Add option for accepted_values or allowed_values ?

What do you think about having an option to validate against and set number of options?
For example:
definition = [
  status: [
    type: :atom,
    allowed_values: [:waiting, :started, :finished],
    default: :waiting
  ],
]

this is already supported via :one_of, e.g.:
batch_mode: [type: {:one_of, [:flush, :bulk]}]]


Config store CLI: make value required when updating

What changed?
Making CLI commands related to changing dynamic config more user friendly:

For update require --value
Print out what value was set

Additionally, removing hard-coded cassandra config name from config store client

Pull Request Test Coverage Report for Build 01863a71-27ed-4f2a-856f-24fcb5c5a60a

7 of 20 (35.0%)  changed or added relevant lines in 3 files are covered.
170 unchanged lines in 19 files lost coverage.
Overall coverage decreased (-0.09%) to 57.143%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tools/cli/adminConfigStoreCommands.go
0
2
0.0%

common/dynamicconfig/configstore/config_store_client.go
1
12
8.33%

Files with Coverage Reduction
New Missed Lines
%

common/task/weightedRoundRobinTaskScheduler.go
1
88.6%

service/history/queue/transfer_queue_processor_base.go
1
77.62%

client/history/client.go
2
38.1%

client/history/metricClient.go
2
45.3%

service/history/handler.go
2
47.15%

service/history/task/transfer_active_task_executor.go
2
72.22%

service/history/task/transfer_standby_task_executor.go
2
86.82%

common/persistence/serialization/parser.go
4
63.91%

common/persistence/serialization/thrift_decoder.go
4
57.14%

service/frontend/workflowHandler.go
4
59.98%

Totals

Change from base Build 018633a2-a361-434e-8276-54beb875145f:
-0.09%

Covered Lines:
84937

Relevant Lines:
148639

💛  - Coveralls


debug mode in DatabaseItemList broken

it seems like there's a missing method:
https://github.com/concrete5/concrete5-5.7.0/blob/develop/web/concrete/src/Legacy/DatabaseItemList.php#L141
Whoops \ Exception \ ErrorException (E_ERROR)
Class 'Concrete\Core\Legacy\Database' not found

Thoughts on just giving those couple calls the axe? they are the only places in all the core that they are being called and aside from simply having it log the queries I'm not sure Doctrine has any built in support for a debug method and I think we already have a way to log queries so this seems like an unnecessary functionality.

I'd assume that building a "get sql query" method shouldn't be a big deal as there's bult in support to log queries. On the other hand I agree that this feature is probably not the most important one and could easily be replaced by the query log.
Personally I'd be too lazy to write that function and simply remove the debug method, can't talk for others though..

Yeah, agreed – this is the legacy item list anyway, anyone doing new development ought to use the new object (which does have a debug mode)

personally I'd remove the debug method too to let people know that it's not working anymore. Might be annoying for those who want to use it...?


Update express-slow-down.js

Adding optional headers (as express-limit-rate does ).
I just set default to false : @nfriedly , i let you chose if it should be true or not

I can understand why did the CI failed :/

Oh, yea, good idea. I think defaulting to false is a good idea here.
I think I know why CI failed - I updated the dependencies the other day to resolve a vulnerability in one of the dev dependencies, but the newer version doesn't support Node.js < 10, so I need to bump the tests to target more recent versions of node.js

Should get published in v1.4.0 whenever Travis CI gets around to it (although it's been a little slow lately)...

Cool
I might add some contributions in the next weeks if you don't mind ;)


Platform Target

Out of curiosity, was wondering why you have specifically targeted x86 and x64. I have noticed that that AnyCPU is in the projects and seems to work for both x86 and x64. It would simplify the NuGet packages and make referencing it a lot simpler.

In some case 'AnyCPU' can't load x64 version of libvlc...


fix: handle missing verses

Error message:
Traceback (most recent call last):
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/uvicorn/protocols/http/h11_impl.py", line 407, in run_asgi
[1]     result = await app(  # type: ignore[func-returns-value]
[1]              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/uvicorn/middleware/proxy_headers.py", line 69, in __call__
[1]     return await self.app(scope, receive, send)
[1]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/fastapi/applications.py", line 1054, in __call__
[1]     await super().__call__(scope, receive, send)
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/starlette/applications.py", line 123, in __call__
[1]     await self.middleware_stack(scope, receive, send)
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/starlette/middleware/errors.py", line 186, in __call__
[1]     raise exc
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/starlette/middleware/errors.py", line 164, in __call__
[1]     await self.app(scope, receive, _send)
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/starlette/middleware/exceptions.py", line 62, in __call__
[1]     await wrap_app_handling_exceptions(self.app, conn)(scope, receive, send)
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
[1]     raise exc
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
[1]     await app(scope, receive, sender)
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/starlette/routing.py", line 758, in __call__
[1]     await self.middleware_stack(scope, receive, send)
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/starlette/routing.py", line 778, in app
[1]     await route.handle(scope, receive, send)
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/starlette/routing.py", line 299, in handle
[1]     await self.app(scope, receive, send)
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/starlette/routing.py", line 79, in app
[1]     await wrap_app_handling_exceptions(app, request)(scope, receive, send)
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
[1]     raise exc
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
[1]     await app(scope, receive, sender)
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/starlette/routing.py", line 74, in app
[1]     response = await func(request)
[1]                ^^^^^^^^^^^^^^^^^^^
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/fastapi/routing.py", line 278, in app
[1]     raw_response = await run_endpoint_function(
[1]                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/fastapi/routing.py", line 191, in run_endpoint_function
[1]     return await dependant.call(**values)
[1]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[1]   File "/home/briankim/Dev/big-league/holy-text/api/bible/router.py", line 61, in random_verse
[1]     full_verse, verse_text = get_random_verse(
[1]                              ^^^^^^^^^^^^^^^^^
[1]   File "/home/briankim/Dev/big-league/holy-text/api/bible/service.py", line 76, in get_random_verse
[1]     (_, _), verse_text = get_parsed_verse(full_verse, bible_version)
[1]                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[1]   File "/home/briankim/Dev/big-league/holy-text/api/bible/service.py", line 49, in get_parsed_verse
[1]     text = get_verse_text(verse, bible_version=bible_version)
[1]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[1]   File "/home/briankim/Dev/big-league/holy-text/api/bible/service.py", line 10, in get_verse_text
[1]     text = bible.format_scripture_text(
[1]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/pythonbible/formatter.py", line 389, in format_scripture_text
[1]     verse_text = bible.get_scripture(current_start_verse, current_end_verse)
[1]                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/pythonbible/bible/bible.py", line 62, in get_scripture
[1]     start_index, end_index = self._get_start_and_end_indices(
[1]                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[1]   File "/home/briankim/.cache/pypoetry/virtualenvs/holy-text-sR2s3zvh-py3.12/lib/python3.12/site-packages/pythonbible/bible/bible.py", line 77, in _get_start_and_end_indices
[1]     raise VersionMissingVerseError(self.version.value, start_verse_id)
[1] pythonbible.errors.VersionMissingVerseError: NIV is missing verse 69018020.

Missing verses should be noted when encountered and added if possible.
An error message should be sent to the client on first encounter informing them of the missing verse.

Getting books from not available in the given version caused the error


Module #3 - Data management planning

I am working on converting the Module 3 PPTX to an md file

@amandawhitmire is currently working on this lesson.

[ ]  Transfer all text content to the slides
[ ]  Compare text transferred to most recent ppt - ensure it's current
[ ]  Re-export images - rework images to ensure high quality graphics in the presentation
[ ]  Check notes - ensure all notes that aren't a duplicate of the slide content are transferred.

All content has been checked and updated, but I still having issues related to line spacing on the bullets. I suggest we go 1.15 or 1.5 spacing on those.

All slides have been reviewed / edited / cleaned.  There are a few minor items remaining but I will migrate into a single issues thread.


All X values in a single row in Timeline chart

Hi,
I have data like below.  (Time ranges of when my machine was up and down)
It is getting plotted like

I want it to be plotted like

Any solution?
series: [
          // George Washington
          {
            name: 'MachineState',
            data: [
              {
                x: 'Up',
                y: [
                  new Date(1789, 3, 30).getTime(),
                  new Date(1797, 2, 4).getTime()
                ]
              },{
                x: 'Down',
                y: [
                  new Date(1797, 2, 4).getTime(),
                  new Date(1801, 2, 4).getTime()
                ]
              },
			  {
                x: 'Up',
                y: [
                  new Date(1792, 3, 30).getTime(),
                  new Date(1795, 2, 4).getTime()
                ]
              },

            ]
          },

Hi,
I added support for this in 0.9.0-beta.
Please check https://apexcharts.github.io/Blazor-ApexCharts/rangebar-charts#grouped


redrawList() Drawing Too Many CPU Cycles

It seems the redrawList() function draws each post before checking if it's even needed. What a waste of CPU cycles. Let's kill this and only draw the HTML if it's absolutely necessary.

Done and done. This should make Nice much more usable on resource-constrained systems.


Prepare auto-annotation RQ jobs for migration to the general request API

Define an RQ ID format for auto-annotation jobs, and make use of it.

Add a function_id field to RequestSerializer, so that the general request API can expose the same information as the lambda request API. (In truth, the lambda request API also exposes the "threshold" field, but the UI doesn't use it, and I don't see the point in having it.)

Note that this doesn't actually enable the general request API for auto-annotation requests. This is because a similar patch needs to first be applied to the Enterprise version, otherwise requests for Roboflow/Hugging Face jobs will be invisible.

Motivation and context

We're trying to unify the API for managing long-running requests.
How has this been tested?

Manual testing.
Checklist

[x] I submit my changes into the develop branch
[ ] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

New Features

Introduced a new functionID property to enhance operation tracking.
Added AUTOANNOTATE action to expand request handling options.
New function_id field in serializers for better data representation.
Enhanced job handling logic to improve robustness and clarity.

Bug Fixes

Improved job management to delete outdated jobs based on naming conventions.

Documentation

Updated schema to include new autoannotate operation type and function_id property.

@Marishka17 Could you review?


Release/3.1

Summary of the changes (Less than 80 chars)

Detail 1
Detail 2
I'd like a summary explanation of what this does. Thank you.

Addresses #bugnumber (in this specific format)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: jpadielou sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Please open an issue if you have a question.


Bard custom provider CSS cuts off account switching bar

After logging into ChatGPT with my Google Workspace account, I found it was picked up by the services in the other tabs (i.e. they showed a "Continue as..." that allowed me to login which was nice!
However, my Bard account is associated with my personal Gmail, and it seems that GodMode has cut off the top navbar that would allow for me to switch my Google account as seen in these screenshots:
Screenshot inside GodMode:

Screenshot from Chrome:

@tayiorbeii ah that is due to some custom css we made to hide it to save vertical space. https://github.com/smol-ai/GodMode/blob/83bc6ddee70ede4c98a653c6920272ff394e0346/src/providers/bard.js#L49 welcome to make a PR to tweak the overall Bard css!

i addressed in commit 7514d52..072a81b


upgrade ceph version

I am interested in contributing to the development of Ceph or upgrading its version using Ceph ADM. Could you please guide me on how to get started with contributing?

This is a good starting point https://docs.ceph.com/en/latest/dev/cephadm/


[Bug]: Missing add currencies UI

Please see https://github.com/medusajs/medusa/issues/3215#issuecomment-1434322685

Will be fixed as part of https://github.com/medusajs/admin/pull/897


Multiple go declarations in a gradle build don't work anymore

With gogradle 0.6.5 it was possible to build multiple binaries like this:
build {

    targetPlatform = 'linux-amd64, darwin-amd64'

    outputLocation = 'build/${GOOS}/${GOARCH}/${PROJECT_NAME}${GOEXE}'

    doLast {
        go 'build -o build/${GOOS}/${GOARCH}/app1a${GOEXE}  gitrepo/apps/app1/app1a'
        go 'build -o build/${GOOS}/${GOARCH}/app1b${GOEXE}  gitrepo/apps/app1/app1b'
    }
}

Unfortunately this doesn't work anymore, because the go command needs to be configured outside the doLast block like this:
build {

    targetPlatform = 'linux-amd64, darwin-amd64'

    outputLocation = 'build/${GOOS}/${GOARCH}/${PROJECT_NAME}${GOEXE}'

    go 'build -o build/${GOOS}/${GOARCH}/app1a${GOEXE}  gitrepo/apps/app1/app1a'
    go 'build -o build/${GOOS}/${GOARCH}/app1b${GOEXE}  gitrepo/apps/app1/app1b'
}

But this does not work either. Only the last go declaration is used.
It seems that it is not possible to define multiple go builds.
My question is, is it the intended behavior or is it a bug?
If it's the intended behavior, then which alternatives do I have?
I already tried to define custom tasks, or the new muti-project configuration,
but it feels like it just complicates a former simple setup.

I think you need to organize your projects following Gradle's multi project build.
https://docs.gradle.org/current/userguide/multi_project_builds.html
There's a multi project build example that uses gogradle here
https://github.com/gogradle/examples/tree/master/multi-project

@blindpirate Since 0.9 seems to be around the corner I couldn't wait to give it a try. :)
It works great!
Thank you for your hard work on gogradle and also thank you for your hard work on the Gradle JUnit 5 integration!

Closed by 0.9.
@dawi Thank you, it's my pleasure.


Marketplace broken after logging in and out of another account

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

ℹ Environment / Computer Info
Spotify for Windows
<IP_ADDRESS>2.g1924b088
Spicetify v2.20.0
Theme: marketplace / Karimawi
Extensions: fullAppDisplayMod.js, goToSong.js, fullAlbumDate.js, power-bar.js, autoSkipWrapper.js, volumePercentageWrapper.js, volume-profiles.js, playNextWrapper.js, genre.js, showQueueDuration.js, copy-track-titles.js, playlistIntersection.js, startup-page.js, group-session.js, SleepTimer.js, skipOrPlayLikedSongs.js, spotifyBackup.js, savePlaylistsWrapper.js, QueueTime.js, sortByPlayCount.js, romaja_lyrics.js, quick-add-to-playlist.js, noTrackingLinks.js, romaji-convert.js, songwhip.js, playOnYouTube.js, who-added.js, webnowplaying-redux.js, imageToClipboard.js, playing-source.js, extended-copy.js, cacheCleaner.js, beautiful-lyrics.js, imageOpener.js, romaji_lyrics.js
Custom apps: marketplace

📝 Description
Extension are not loading at all, manually installed extensions do run, but Marketplace extensions and theme.js don't run, tried reinstalling Spotify, Spicetify and marketplace multiple times, the previously installed extensions are just stuck in the installed tab, idk where they're cached from, but they ain't working, I tried the reset button in the settings a lot of times but it doesn't uninstall or reset a thing.
📸 Screenshots
https://github.com/spicetify/spicetify-marketplace/assets/69881381/1c7b8ea3-6308-42f0-a297-e5f5a0e57143

also trying to install new extensions from the marketplace only puts them in the installed tab, they don't work either.

I also tried re-logging in to the other account to see if the extensions work or try to reset, neither of those worked

If I had to guess it might be due to the crazy amount of extensions you have. Could be trying to load them too quickly and getting ratelimted. Try uninstalling some that you don't use

Nope, I uninstalled all of them and just kept Volume Profiles and Sleep Timer, still did not work, there's clearly no theme (just the color profile) and there's no volume profiles or sleep timer down at the bottom.

Most likely a network issue with JSDelivr as this occurs with most users recently, try using a VPN.

Yeah, it is, wow, I would've never thought of that, do you think there might be an alternative to the VPN? Cause I can't use a VPN all the time.

You could look into proxies, DNS, etc. for your network configurations (e.g. Google's public DNS)

@CharlieS1103 @kyrie25
Thought this would help out a bunch of people and will probably save you guys a ton of time trying to suggest a solution,

This worked like a charm for me, and you just turn it on and forget about it
Cloudflare's WARP: https://<IP_ADDRESS>/


we put more docker in your docker so...you can test your network

Description
Scripts allowing to run aleph-node using the synthetic-network tool. It allows to simulate different network conditions on per connection basis. It also supports scripting. Used docker images includes also the stress tool allowing to simulate cpu and io occupancy.
Type of change
docker-compose definitions and shell scripts
How to run it
Execute scripts/run_consensus_synthetic-network.sh. Note that it requires aleph-node:latest docker image.

Can we get a README for this as well? I know you put the usage method in the script itself but if you don't know it's there you will never find it.


Use 'pop' instead of 'del' when removing from cache

Replace del statement with pop method, in order to avoid watcher
failures due to KeyError when deleting a pod.
There is at least one corner case where a pod is never processed
and therefore never stored in cache, and that would be when the
kube scheduler is down and does not come up before the pod is deleted.
It is worth noting however that the observed failure is not
critical as the watcher is restarted.
Fixes: 06a8017bac85 ("Do not assume pod is always in cache on delete")
Signed-off-by: Salvatore Orlando<EMAIL_ADDRESS>

LGTM


Unsupported platform Windows_NT arm64

🐛 Bug report
Describe the bug
Trying to install wrangler on a Surface Pro X. Installation fails with unsupported platform. If I remove the platform check things work fine.
Reproduce the bug
Get an arm device with a recent version of Windows (that supports emulation) and run npm i @cloudflare/wrangler -g
Expected behavior
Wrangler gets installed.
Environment and versions

operating system: Windows 10
output of wrangler -V:
output of node -v: 15.8 (arm)
content of wrangler.toml:

@StrawMonkey  - thanks for filing this. I may need to send you some code to help identify your system and add it to the architecture checks. Let me do some testing first and I'll get back to you asap!

@StrawMonkey - sorry for the delay here.. a bit backed up with some other work at the moment. In lieu of official support via pre-built binary for your system, can you try to build it from source using cargo: https://github.com/cloudflare/wrangler#install-with-cargo
I think that should at least unblock you. Thanks -- let me know if you have any issues with this.

I'm having the same error but for Windows_NT ia32
I tried this with both node v14.17.4 and v16.5.0.

We have much wider platform support with wrangler v2. You can try it today with npm install wrangler@beta. More info at https://github.com/cloudflare/wrangler2 (which we'll eventually merge back into this repo)


fix unsubscribe bug

Fixes #558
Master Issue: #558
Motivation
fix Non-persistent topic disconnect will trigger NPE
Modifications
if  cleanSubscription is true:
NonPersistentSubscription#delete method inner  will invoke Topic#unsubscribe again,  then trigger NPE
Verifying this change

[x] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change added tests and can be verified as follows:
SimpleIntegrationTest#testNonPersistentTopic
Documentation
Check the box below.
Need to update docs?

[x] no-need-doc
just bugfix

@Technoboy-  PTAL

Hi @JoeCqupt
I have updated the root cause of the issue, and now close this pr.

Thanks @JoeCqupt .


flutter web complie error

inits@inits-MS-7798:~/Desktop/flutter-project/echo4-dashboard$ flutter  run -d chrome
Launching lib/main.dart on Chrome in debug mode...
../../../.pub-cache/hosted/pub.dev/media_kit_video-1.1.3/lib/src/video/video_texture.dart:118:46: Error: A value of type 'Widget Function(VideoState/*1*/)' can't be assigned to a
variable of type 'Widget Function(VideoState/*2*/)?'.
 - 'Widget' is from 'package:flutter/src/widgets/framework.dart' ('../../../works/dataker/data/flutter/packages/flutter/lib/src/widgets/framework.dart').
 - 'VideoState/*1*/' is from 'package:media_kit_video/src/video/video_web.dart' ('../../../.pub-cache/hosted/pub.dev/media_kit_video-1.1.3/lib/src/video/video_web.dart').
 - 'VideoState/*2*/' is from 'package:media_kit_video/src/video/video_texture.dart' ('../../../.pub-cache/hosted/pub.dev/media_kit_video-1.1.3/lib/src/video/video_texture.dart').
    this.controls = media_kit_video_controls.AdaptiveVideoControls,
                                             ^
Waiting for connection from debug service on Chrome...             64.7s
Failed to compile application.
inits@inits-MS-7798:~/Desktop/flutter-project/echo4-dashboard$

Works for me. Import things correctly.

flutter doctor -v
inits@i:~/Desktop/aria2c$ flutter  doctor -v

[✓] Flutter (Channel stable, 3.10.6, on Ubuntu 22.04.2 LTS 5.19.0-46-generic, locale en_US.UTF-8)
    • Flutter version 3.10.6 on channel stable at /home/inits/works/dataker/data/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f468f3366c (4 weeks ago), 2023-07-12 15:19:05 -0700
    • Engine revision cdbeda788a
    • Dart version 3.0.6
    • DevTools version 2.23.1

detail error is:
--incremental --target=dartdevc --experimental-emit-debug-metadata -DFLUTTER_WEB_AUTO_DETECT=true
-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/cdbeda788a293fa29665dc3fa3d6e63bd221cb0d/ --output-dill /tmp/flutter_tools.QYBCDE/flutter_tool.OVHZMB/app.dill
--packages /home/inits/Desktop/flutter-project/echo4-dashboard/.dart_tool/package_config.json -Ddart.vm.profile=false -Ddart.vm.product=false --enable-asserts --track-widget-creation
--filesystem-root /tmp/flutter_tools.QYBCDE/flutter_tools.RDLODI --filesystem-scheme org-dartlang-app --initialize-from-dill build/062e00833251f4c34e967a1a95ff7bd3.cache.dill.track.dill
--platform file:///home/inits/works/dataker/data/flutter/bin/cache/flutter_web_sdk/kernel/ddc_outline_sound.dill --verbosity=error --sound-null-safety
[  +37 ms] <- compile org-dartlang-app:/web_entrypoint.dart
[+8587 ms] ../../../.pub-cache/hosted/pub.dev/media_kit_video-1.1.3/lib/src/video/video_texture.dart:118:46: Error: A value of type 'Widget Function(VideoState/*1*/)' can't be assigned
to a
                    variable of type 'Widget Function(VideoState/*2*/)?'.
[   +2 ms]  - 'Widget' is from 'package:flutter/src/widgets/framework.dart' ('../../../works/dataker/data/flutter/packages/flutter/lib/src/widgets/framework.dart').
[        ]  - 'VideoState/*1*/' is from 'package:media_kit_video/src/video/video_web.dart' ('../../../.pub-cache/hosted/pub.dev/media_kit_video-1.1.3/lib/src/video/video_web.dart').
[        ]  - 'VideoState/*2*/' is from 'package:media_kit_video/src/video/video_texture.dart'
('../../../.pub-cache/hosted/pub.dev/media_kit_video-1.1.3/lib/src/video/video_texture.dart').
[        ]     this.controls = media_kit_video_controls.AdaptiveVideoControls,
[        ]                                              ^
[+51670 ms] Waiting for connection from debug service on Chrome... (completed in 61.1s)
[        ] Synced 0.0MB.
[        ] Failed to compile application.
[   +4 ms] "flutter run" took 63,639ms.
[   +4 ms]
           #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
           #1      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:757:9)
           <asynchronous suspension>
           #2      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1336:27)
           <asynchronous suspension>
           #3      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #4      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
           <asynchronous suspension>
           #5      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:296:9)
           <asynchronous suspension>
           #6      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #7      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:244:5)
           <asynchronous suspension>
           #8      run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:91:9)
           <asynchronous suspension>
           #9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #10     main (package:flutter_tools/executable.dart:91:3)
           <asynchronous suspension>

[ +226 ms] ensureAnalyticsSent: 222ms
[        ] Running 1 shutdown hook
[  +47 ms] Shutdown hooks complete
[        ] exiting with code 1

You likely imported some implementation files. Please only import the root package in your project.
Our CI succeeds, there's no bug. It's your end.


Could not load file or assembly 'System.Net.Http or one of its dependencies while unit testing Azure Function Project

While unit testing Azure Functions Project i get this this exception running my test case:

Could not load file or assembly 'System.Net.Http, Version=4.1.10, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a’ or one of its dependencies.

Investigative information
I'm using Visual Studio 2017 15.3.4
Repro steps
Step 1:
Create Azure Functions Project for HttpTrigger using VS template (it's targetted at .net framework 4.6.1)
Step 2:
Then create a unit test project (4.6.1 framework). Add reference to the azure function projected created above.
Step 3:
Run the sample test case
You get the exception mentioned above.
Provide the steps required to reproduce the problem:
Expected behavior
Expected behavior is that the test cases runs successfully without complaining about this issue with System.Net.Http dll
Known workarounds
Please check the response from David on this stackoverflow issue that i created. this workaround worked for me.
https://stackoverflow.com/questions/46287628/could-not-load-file-or-assembly-system-net-http-version-4-1-1-0-in-unit-test-fo
In short, i had to create the unit test project using .net core template, edit the csproj file to change the target framework to  net461, then everything worked fine.
Related information
Here is the code for unit test that validates the response from azure function
public async Task TestMethod1()
        {
            //Arrange
            var configuration = new HttpConfiguration();
            var req = new HttpRequestMessage()
            {
                Content = new StringContent(string.Empty),
                RequestUri = new Uri("http://localhost?name=test"),
                Method = HttpMethod.Get,
            };

            req.Properties[System.Web.Http.Hosting.HttpPropertyKeys.HttpConfigurationKey] = configuration;
            TraceWriter log = new TraceMonitor();

            //Call azure function
            var result = await TestHttpFunction.Run(req, log).ConfigureAwait(false);
            var content = await result.Content.ReadAsStringAsync().ConfigureAwait(false);
            Assert.IsTrue(result.IsSuccessStatusCode);
            Assert.AreEqual(content, "\"Hello Test\"");
        }

We found a workaround, but still need to understand why the regular unit test project doesn't work. @vijayrkn was going to take a look.

Will provide an update as soon as I find why it doesn't work on regular unit test projects.

Sample function app with tests are available here - https://github.com/Azure/azure-functions-vs-build-sdk/tree/master/sample/FunctionApp
Replace the 1.0.3 version of Functions sdk with 1.0.2 version (which is the most recent version available on NuGet)


[wip] Expose needed API for coffeescript's self-coverage

TBD

@jwalton FYI, I'm currently working on coffee-coverage is officially supported by coffeescript: https://github.com/jashkenas/coffeescript/pull/4348


Bug-fix in release jenkinsfile

Description
Bug-fix in release jenkinsfile.
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List

[ ] New functionality includes testing

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Looks like there was an unused value and autoPublish was using its default value - is there a deployment failure?
Looking at opensearch-migrations-release [1] , there is a failure, but I'm not seeing how that exception is related to this change.
Also:   org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: a835b466-9eab-47fc-aec9-355e41dd6c17
groovy.lang.MissingPropertyException: No such property: arguments for class: groovy.lang.Binding
	at groovy.lang.Binding.getVariable(Binding.java:63)
	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onGetProperty(SandboxInterceptor.java:285)
...

[1] https://build.ci.opensearch.org/job/opensearch-migrations-release/4

The issue was with the arguments as there are no arguments passed to this pipeline script. I had missed to remove this in the initial PR.
The autoPublish flag is added to push maven artifacts to Maven central without manual intervention.


App

Describe the feature you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

You do realise you have to fill out the main text bit, so that the dev actually know what you want

This is spam, isn’t there a moderator to help ban these people and close these useless spam posts?

I have been spending some of my free time scrolling through the issues and trying to help people, telling them to go to reddit or discord, but they don't listen, and start arguing. There needs to be some  kind of moderator. I remember there used to be 9 issues before unc0ver 5.0.0. was released. but now there are 73.    These people don't deserve to ask for help here, its pure stupidity, and pisses me off cos I appreciate pwn20wnd's work, but these people take everything for granted, and expect everyone to spoonfeed them, and then when they have to face facts themselves, they start blaming others.

Well, I’ll continue to help others and not blame them, and see if I can calm them down. I have at least seen the owners of the thread delete some particularly offensive posts before as well as some spam


feature-wip Step1: Support create hudi external table

Proposed changes
Issue Number: close https://github.com/apache/incubator-doris/issues/9557
Support create hudi external table in Doris.
This is the first pr to support hudi external table.
Feature Summary:
The propose of the pr is:
support create hudi table
support show create table for hudi table
Design

create hudi table without schema(recommanded)

    CREATE [EXTERNAL] TABLE table_name
    ENGINE = HUDI
    [COMMENT "comment"]
    PROPERTIES (
    "hudi.database" = "hudi_db_in_hive_metastore",
    "hudi.table" = "hudi_table_in_hive_metastore",
    "hudi.hive.metastore.uris" = "thrift://<IP_ADDRESS>:9083"
    );

create hudi table with schema

    CREATE [EXTERNAL] TABLE table_name
    [(column_definition1[, column_definition2, ...])]
    ENGINE = HUDI
    [COMMENT "comment"]
    PROPERTIES (
    "hudi.database" = "hudi_db_in_hive_metastore",
    "hudi.table" = "hudi_table_in_hive_metastore",
    "hudi.hive.metastore.uris" = "thrift://<IP_ADDRESS>:9083"
    );

When create hudi table with schema, the columns must exist in corresponding table in hive metastore.

show create table

MySQL [db_demo]> show create table t_hudi;
+--------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Table  | Create Table                                                                                |
+--------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| t_hudi | CREATE TABLE `t_hudi` (

) ENGINE=HUDI
COMMENT "HUDI"
PROPERTIES (
"hudi.database" = "hudi_db",
"hudi.table" = "hudi_ctas_cow_pt_tbl",
"hudi.hive.metastore.uris"  =  "thrift://<IP_ADDRESS>:9083"
) |
+--------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.01 sec)

Checklist(Required)

Does it affect the original behavior: (No)
Has unit tests been added: (Yes)
Has document been added or modified: (Yes)
Does it need to update dependencies: (Yes)
Are there any changes that cannot be rolled back: (No)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

You if wrote close #9557, after this PR is merged, the issue will be automatically closed.
So in this pr, you can remove "close" keyword.

You if wrote close #9557, after this PR is merged, the issue will be automatically closed. So in this pr, you can remove "close" keyword.

done


zero1 changes for pytorch training

Zero stage1 changes for pytorch training script to better compare performance.

btw @chinthysl i'm sorry but i think i broke ZeRO recently on llm.c, not 100% sure which PR I didn't dig into it yet. I suspect possibly the AdamW PR from yesterday.  Will look into 😬

I'll also have a look at the train_gpt2cu. Just now I saw there's a lot changes and needs refactoring for python changes.
Will come up with a separate PR later.


Cannot send transactions in latest build

I get the following asset every time I try to send a transaction:
{code:1,message:10 assert_exception:Assert Exception
my->_key != empty_pub:
{}
th_a  elliptic_secp256k1.cpp:118 serialize
{"from":"metaexchangebtc","to":"usd-collateral-holder-453","amount":"12206.79294","asset_symbol":"BTS","memo":"mX: buy BTS_BTC","broadcast":true}
th_a  wallet.cpp:2002 transfer,data:{code:10,name:assert_exception,message:Assert Exception,stack:[{context:{level:error,file:elliptic_secp256k1.cpp,line:118,method:serialize,hostname:,thread_name:th_a,timestamp:2015-12-17T00:38:13},format:my->_key != empty_pub: ,data:{}},{context:{level:warn,file:wallet.cpp,line:2002,method:transfer,hostname:,thread_name:th_a,timestamp:2015-12-17T00:38:13},format:,data:{from:metaexchangebtc,to:usd-collateral-holder-453,amount:12206.79294,asset_symbol:BTS,memo:mX: buy BTS_BTC,broadcast:true}}]}}

This appears to be localised to this particular account. I suspect the object id shuffle is a candidate cause for this.
More info: https://bitsharestalk.org/index.php/topic,20683.0.html

The memo key for collateral holder accounts isn't being initialized in the genesis.  This should be fixed.

We can't register a memo key for collateral holder accounts because they only have an address, not a memo key.  The real problem is #377 -- the wallet gets confused trying to create a memo for an account without a memo key.  Try sending with an empty memo.
Closing as duplicate of #377


Publish main to live on 1/4 @ 10:30 am

Learn Build status updates of commit 027cc35:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Get-CASMailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-User.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-MailboxJunkEmailConfiguration.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


chore: add tracing to Connection API

Adds OpenTelemetry tracing to the Connection API. This again enables tracing in the JDBC driver and PGAdapter.
Adds traces for batchUpdate calls in the Java client library (these calls were not traced).
Adds traces for executeUpdate calls in the Java client library (these calls were not traced).
Adds an option to include the actual SQL statement that was executed with the trace. This option is disabled by default. The option is named enableExtendedTracing, and might include additional features in the future.
Adds the transaction tag and statement tag as attributes to the OpenTelemetry traces. This makes it easier to find traces for specific transactions and statements.

We should also update the Readme OpenTelemetry about the new Environment Variable and Option

We should also update the Readme OpenTelemetry about the new Environment Variable and Option

Done


I write directive ，I want to use a attribute in  update，this attribute is create bind

Version
2.5.20
Reproduction link
https://jsfiddle.net/9ag4xtvu/12/
Steps to reproduce
I want to get an initialized value for comparison。
Vue.directive('diff', {
inserted: function (el,bind,vnode) {
bind.initData = bind.value
console.log(vnode)
},
update:function(el,bind,vnode){
console.log(bind.initData)
}
})
What is expected?
in update, bind.initdata will have value
What is actually happening?
bind.initdata  is undefined

if you want to add data, add it to the element itself

Remember you can use the forum or the Discord chat to ask quick questions!

I want to get an initialized value for subsequent comparisons


GeoIP down?

					IN	A

;; ANSWER SECTION:
status.geojs.io.	3435	IN	A	<IP_ADDRESS>

It works for me.

It works for me.

it?

Hey @systemcrash, no outages I'm able to see here. From the looks of it your DNS isn't resolving domains correctly. The geojs.io domain has DNSSEC applied to it so perhaps your resolver is struggling to verify that correctly.
If the issues keep coming back feel free to open this issue again.

OK - thanks for looking into it. Evidently Adguard took to blocking DNS lookups for your domain - possible association of this lookup mechanism with some privacy invasion.
https://adguard.com/en/adguard-dns/overview.html


elixir-desktop vs live view native

how does this project differs from live view native?
i know live view native doesn't support desktop yet but i think maybe we can kinda put the effort on the same path?

awesome project though!

Hey @zoedsoupe thanks for your question!
This is a misunderstanding that is coming up quite commonly. Let me try to clarify and please raise any additional questions you have on this:
Elixir Desktop goal is to build Local-First applications using Elixir and specifically LiveView. A typical example of a local-first applications is a note taking that works offline.

"Thick client" Local-First app
Ships BEAM compiled for iOS and Android
Runs beam locally (no server)

Elixir Native goal is to use LiveView strength to build native look and feel apps for iOS + Android

"Thin client" uses http connection to a server
Ships translation layer that converts liveview generated xml to native swift ui or android ui components
Requires a central server


add greenplum virtual memory calculator

By default GPDB sets vm.overcommit.ratio = 50% causing users to oversubscribe memory to GUC gp_vmem_protect_limit leading to out of memory events.  This calculator uses a formula developed by https://github.com/pivotal-mike which is based off of data collected from from large GPDB deployments. Based on a few inputs the site produces the recommended virtual memory settings

Hi Ivan,
It is hidden in the tooltip (?) but i can make it more visible to eliminate confusion
thanks

recommended changes were submitted
http://randomtask1155.github.io/gpvmem-calculator/

The link to the GPDB documentation has a typo: s/documentaiton/documentation/

Rather than linking to this, can't we include it as a page under greenplum.org to make it more official?

thanks Dan,
I fixed the typo as you suggested.
yes i would prefer to have the repo under greenplum-db and link it there.
I don't have rights to spin up a new repo so i initiated the process via
this pull request.
On Wed, Mar 9, 2016 at 4:32 AM, Daniel Gustafsson<EMAIL_ADDRESS>wrote:

Rather than linking to this, can't we include it as a page under
greenplum.org to make it more official?
—
Reply to this email directly or view it on GitHub
https://github.com/greenplum-db/greenplum-db.github.io/pull/8#issuecomment-194231030
.

We can just include the code in this repo and make it available as http://greenplum.org/calc or something similar.

that sounds good
On Wed, Mar 9, 2016 at 6:03 AM, Daniel Gustafsson<EMAIL_ADDRESS>wrote:

We can just include the code in this repo and make it available as
http://greenplum.org/calc or something similar.
—
Reply to this email directly or view it on GitHub
https://github.com/greenplum-db/greenplum-db.github.io/pull/8#issuecomment-194308838
.

ok will do
On Wed, Mar 9, 2016 at 8:09 AM, Ivan Novick<EMAIL_ADDRESS>wrote:

that sounds good
On Wed, Mar 9, 2016 at 6:03 AM, Daniel Gustafsson <
<EMAIL_ADDRESS>wrote:

We can just include the code in this repo and make it available as
http://greenplum.org/calc or something similar.
—
Reply to this email directly or view it on GitHub
<
https://github.com/greenplum-db/greenplum-db.github.io/pull/8#issuecomment-194308838

.

—
Reply to this email directly or view it on GitHub
https://github.com/greenplum-db/greenplum-db.github.io/pull/8#issuecomment-194310662
.

moved under http://greenplum.org/calc

Is there anymore feedback for this pull request?

I get a 404 error at this URL:
http://greenplum.org/calc
Is that expected?  Otherwise the idea is a good one, and would like to see this live asap.

http://greenplum.org/calc will not work until the changes are merged

ok lets merge it buddy

Sorry for being slow, have been a bit too busy. It's not entirely clear from the documentation if including a directory in the repository is equal to having the code in a separate repository like how the sandbox tutorials are handled; do you know if there are differences?

the sandbox is using gh-pages but i did test if gh-pages will automatically look for index.html in the sub-directory and it does work there.  I assume the same will apply to the custom domain version but i have never tested it.

Sounds perfect to me, :+1: on committing this.

Thanks Dan,
I squashed the three commits into one.  Should i simply merge the changes or do you need to do that?

if you have access just go ahead and merge it


Fix building docker artifacts

For some strange reason, building docker artifacts was failing for me locally and this seems to fix the issue - not sure how though.

Actually I'll merge this to https://github.com/api3dao/airnode/pull/669


Manual Triggers Docs: Added docs before the first release

Docs include the following sections:
* Security
* Multi cluster support
* Min requirements

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[NTR/gene]

GYG1-related disorder of glycogen metabolism
Synonyms N/A
Parent term (use OLS, or your favorite ontology browser) disorder of glycogen metabolism (MONDO:0002412)
Definition Any disorder of glycogen metabolism in which the cause of disease is a mutation in the GYG1 gene.
Definition source (Please give PubMed ID, if applicable, in format PMID:#######) ClinGen Inborn Errors of Metabolism Gene Curation Expert Panel (https://clinicalgenome.org/affiliation/40097/)
Children terms (if applicable) glycogen storage disease XV (MONDO:0013291), polyglucosan body myopathy type 2 (MONDO:0014526)
Your nano-attribution (ORCID) or URL for a working group ClinGen Inborn Errors of Metabolism Gene Curation Expert Panel (https://clinicalgenome.org/affiliation/40097/)

Thank you for reviewing this request by the ClinGen Inborn Errors of Metabolism GCEP. The group has investigated GYG1-related cases and that found polyglucosan body myopathy 2 and glycogen storage disease XV are both caused by biallelic loss-of-function variants in GYG1 (sometimes the same variants), and share overlapping phenotypes consistent with a single spectrum of disease. The group proposes "GYG1-related disorder of glycogen metabolism" as a name that would be inclusive of both existing child terms. The group's findings are summarized in the attached file.
02_10_23_GYG1_precuration_presentation.pptx
Thanks for your time.


Improve analytics

Hey!
How do you think it's the best way to improve analytics?
Either you can use a tracking platform like google analytics or we can make our analytics maybe in a databse?

Hey @komen205!
Currently clicks are saved in a database field called visits. Increment mechanism triggers on each GET requests. Yeah I know very basic :) Maybe we can configure it to not incrementing a visitor's more than one clicks for 24hrs.
Making our analytics would be nice. Number of clicks by time period (like daily, weekly etc), devices, geolocations etc.
I would also like to know if you have any ideas.


Execute "git ls-remote" commands to avoid "Permission denied (publickey)" errors

The following command will succeed in a local development environment. However, they failed in CI.
git ls-remote<EMAIL_ADDRESS>
The reason for the failure is that the SSH public key is not registered.
However, the following commands may succed.
git ls-remote https://github.com/sounisi5011/readme-generator.git

The above command does not use SSH. For this reason, the CLI may be able to escape SSH errors.
However, this solution isn't perfect. Private repositories require GitHub password authentication. If the user has already set up an SSH key, then authentication is completely unnecessary.

I investigated the behavior of npm cli and found that the following commands are being executed.
git ls-remote -h -t git://github.com/sounisi5011/readme-generator.git

The Git protocol is standard in git. There is no authentication for it, but it's probably faster than the HTTPS protocol. For public repositories, it's a good idea to adopt the Git protocol.
However, drawbacks do exist. In the case of private repositories, the Git protocol generated the following error:
$ git ls-remote -h -t git://github.com/sounisi5011/example-repo-private.git
fatal: remote error:
  Repository not found.

If the CLI uses the Git protocol, it cannot distinguish between private and non-existent repositories. On the other hand, if the HTTPS protocol is used, the CLI is able to distinguish between private repositories because of the following error:
$ git ls-remote -h -t https://github.com/sounisi5011/example-repo-private.git
remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/sounisi5011/example-repo-private.git/'

On the other hand, if the HTTPS protocol is used, the CLI is able to distinguish between private repositories because of the following error:
$ git ls-remote -h -t https://github.com/sounisi5011/example-repo-private.git
remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/sounisi5011/example-repo-private.git/'

The HTTPS protocol, like the Git protocol, cannot distinguish between private and non-existent repositories. The same error occurs if the repository does not exist:
$ git ls-remote -h -t https://github.com/sounisi5011/non-exist-repo-fooooooooooooooooooooo.git
remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/sounisi5011/non-exist-repo-fooooooooooooooooooooo.git/'


Istructions/Docs not well explained

10minutes stuck here with my dork.txt file
Can you add option to search urls using .txt files containing urls

you mean searching dorks from a file?
Edit
@unfairDude So I will add a feature that will allow you to use queries from a text file, or just a string as query.  The program will detect what kind of input you pass as query, between file or string.
Example
Run it with queries from a file
oxdork queries.txt

Run it with a string query
oxdork query_string

Thanks for the suggestion! :)

yes exactly, queries inside a .txt file would be amazing.

@unfairDude I have pushed a release to pypi. If you're still running v3.0.0, update to the latest release and you should be able to pass a file containing queries to the program.
Enjoy!

@unfairDude I have pushed a release to pypi. If you're still running v3.0.0, update to the latest release and you should be able to pass a file containing queries to the program.
Enjoy!

just updsted it.
amazing.
I only have one issue but probably more related to google,
When i use tor, i get the error "429 too many requests"

@unfairDude I have pushed a release to pypi. If you're still running v3.0.0, update to the latest release and you should be able to pass a file containing queries to the program.
Enjoy!

just updsted it. amazing.
I only have one issue but probably more related to google, When i use tor, i get the error "429 too many requests"

Oh yeah, that happens even when you use a VPN.
Solution is probably not using any form of VPN or Tor😅

but then you will get timeoutted if when using normal ip after 50/60 results

but then you will get timeoutted if when using normal ip after 50/60 results

Here's a wild idea, buy a new pc everytime you get 50 results. It's guaranteed to work😂
But serious talk, try using google cloud or gitpod

thank you, on my way to the shop 😬

thank you, on my way to the shop 😬

Haha good luck mate


Consider changing id to key in the HTTP API

Using id is holdover from trying on JSON API. Now I worry it's confusing because:

An id softly implies "unique" when in fact it's only unique within a given node in the logical tree.
We use keys() in the Python API to match the Mapping interface, and so item.key would make sense.
There is now a separate, internal unique id in the catalog database, which is not the id in the HTTP API.

While we are going through this round of backward-incompatible changes leading up to the v0.1.0 release, this is one to consider.

I'm not sold that this is worth breaking clients for.

I think I agree. Of all the changes under consideration, this one is the most superficial. Unless someone chimes in to make the case, I will leave it alone.


Add States to the search bar

thank you yiming! merging the diff. that said, probably better to use the npm package for states short code to name mapping. there are examples in the code for that look for "states.get..."


2.11.8 support

It'd be nice to have a new build of 1.2.0 with macro support for 2.11.8. Thanks!

what would be the difference if the lib is compiled against 2.11.7 or 2.11.8?

related to macro's issue is following...?
https://issues.scala-lang.org/browse/SI-9616?jql=project %3D SI AND resolution %3D Fixed AND fixVersion %3D "Scala 2.11.8" AND text ~ "macro" ORDER BY component ASC%2C priority DESC
hmm..... I think that necessarily there is no need to release.
However, https://github.com/sbt/sbt/issues/2076 has been fixed in v2.11.8.
We can try to use -Ybackend:GenBCode option. :smile:

@aoiroaoino do you all the scalac options we need to benefit from java8? It would be nice to give it a try.

all the scalac options we need to benefit from java8

https://github.com/scalaz/scalaz/commit/e3f01cdfb399412b400b9b2250ad755516d7ab2f
https://github.com/scala/make-release-notes/blob/9cfbdc8c92f94/experimental-backend.md#emitting-java-8-style-lambdas
https://github.com/lrytz/experimental-backend-2.11/blob/76b7a45b73a08e5b17641d3fc179e9861bba2f80/build.sbt

Awesome, thanks @xuwei-k

can I close it? Or someone need a release?

I think that this issue has finished :+1:


Linebreak after await keyword leads to 'unexpected token'

From https://phabricator.babeljs.io/T7378
Example
async function a() {
 await
 1;
}

http://astexplorer.net/#/Wq8Hq7MjF0
or is that correct?

Actually looking at
https://github.com/tc39/ecmascript-asyncawait/blob/cdc8e3c567e47fb73ee2360be3faac636752b164/spec/syntax.html#L3-L12
looks like it's correct?

There's no line terminator allowed between async and function, but it doesn't look like there is a restriction between await and it's expression. I assume because the expression is required, whereas with yield it is required.

Ok lol how did I read that wrong..


Search result item

What

Type: Component

A new component is required for the search result items which have been evaluated as part of the on-site search project.
No existing component exists for the search items.
Why

Explain why you think this feature or content should be added to the ONS Design System.

What evidence do you have that your ONS service needs it?

The user need is to facilitate improved findability of the ONS site content.
The variants that exist are a refinement of existing historical patterns in use across the ONS website which have yet to be documented in the design system.
Multiple rounds of user testing (Figma prototypes) of the new search design have been conducted and the designs have been approved by users each time.

Supporting material

Include links to any examples, research, prototypes or code that support your proposal.

Documented in Figma here.

Contacts
@armstrongb - interaction design
Leon Rose - user research (DST)
Gracie Lewis / Ryan Flynn - product owner (DST)

@armstrongb Do you want to add a ticket for a full 'search' page pattern to come after this?


Use nchan instead

nchan seems to be providing all what we need.
The client might need some rewriting, though.

Well nchan is not an active project.


Fix the profile_name in ibm_catalog.json

Description
The profile_name is different for versions >=1.4.0 (It should be IBM Cloud Framework for Financial Services)
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This PR is included in version 2.4.2 :tada:
The release is available on:

GitHub release
v2.4.2

Your semantic-release bot :package::rocket:


Allow optional rule name when creating Azure SQL DB firewall rules

Is your feature request related to a problem? Please describe.
When tools like ADS and Visual Studio offer to create a firewall rule for Azure SQL DB for you automatically they add a completely not useful name. When I'm looking at a list of these firewall rules later they aren't helpful. In our environment we have a policy where we can remove any IP firewall rule that isn't named well enough that we can tell what it is for. By having the ability in the tooling our developers use to give it good names rather than forcing them to jump over the portal to do so would be helpful.
Giving people the ability to generate a name if they'd like to include one will help with this.
Describe the solution or feature you'd like
Have an optional textbox on the screen that creates the rules that can be the rule name.
Describe alternatives you've considered
Right now the only way to give them good names is in the portal, or when creating them manually via the API/CLI/PoSh.
Additional context
Add any other context or screenshots about the feature request here.

Duplicate of 3182.


git clean deletes ts client

git clean -xdf keeps deleting src\SignalR\clients\ts\signalr and src\SignalR\clients\ts\signalr-protocol-msgpack
Repro steps:

build /t:restore (runs npm install)
dir /al /s (shows those folders as hard junctions from \src\SignalR\clients\ts\FunctionalTests\node_modules\@aspnet)
git clean -xdf (those folders get deleted)
git status (git shows those folders as deleted)

This happens because we've configured a junction between src\SignalR\clients\ts\FunctionalTests\node_modules\@aspnet\signalr and src\SignalR\clients\ts\signalr (how?) and node_modules/ is in the .gitignore file. When git clean clears the node_modules dir it follows the junction and deletes the client as well.
Proposal: can we populate the node_modules\@aspnet\signalr folder via some other mechanism besides using a junction? E.g. manually copy the files?
Open question: Where is this junction configured? Is it this?
https://github.com/aspnet/AspNetCore/blob/89a7f3cf774d46eaaea26861744a224a6487f31c/src/SignalR/clients/ts/tsconfig.base.json#L21-L28
@davidfowl @BrennanConroy @anurse

Any chance our new usages of yarn make this simpler? It's always very annoying when I run into this.

Yarn does the same thing npm does— symlink a directory— so no. Problem still exists.

I just had a crazy idea. This occurs because git clean cleans the node_modules folder in SignalR, including things like node_modules/@aspnet/signalr, which is just a junction to the actual source directory. Git cleans through the link and that wipes everything out.
Given that, the solution is actually super simple. Add node_modules/@aspnet/signalr (and node_modules/@aspnet/signalr-protocol-msgpack to the .gitignore as unignored ;):
!node_modules/@aspnet/signalr
!node_modules/@aspnet/signalr-protocol-msgpack

We could do this just in the src/SignalR directory. That would mean that the node_modules directory in those folders hangs around after a clean but it only keeps the symlinks, which is fine.
@BrennanConroy could you see if this fixes the issue? If so, let's do it. (cc @Tratcher @aspnet/build)

We would need to commit the symlink folders otherwise they would probably appear in git status

either way, I likes it 😃

@BrennanConroy true, but the files themselves are already committed anyway so it might just work? There could be a recursion issue though since I think the node_modules folder is still under there... Beware when trying this out @BrennanConroy, you might hang git ;).

Tried various incantations of the above but couldn't get it working

Back to the drawing board I guess :(.

There is an issue tracking this in git for windows and it seems like there's a possibility it will be fixed https://github.com/git-for-windows/git/issues/607

Pushing this out since we still couldn't get it to work... Maybe we should just switch to Subversion :trollface:

@dougbu clean.cmd deleted the ts client again. Seems like the exclusion didn't work?

@Tratcher I don't understand what's happening here. Directly running the git command causes something similar and git reset --hard only restores exactly that node_modules folder. Worse, the behaviour isn't 💯% consistent.
My only thoughts are:

Try a more general exclusion e.g. -e node_modules/ and combine that with specific Remove-Item commands
Remove the exclusion entirely but add git reset --hard HEAD to the script

What think you?

The exclusion is relative to the current directory. Is the redirect to ps1 messing with that? Or does this repro running the ps1 directly?

The redirect to the .ps1 file doesn't make any difference. I've seen issues when running the script or the git command in the repo root. And, only users make any use of this script -- it's not part of any automation.

One thing we could consider doing is not using a link at all and actually directly packing a .tgz and installing it in the dependent projects. The junction point just creates all kind of problems it seems...

Found a reasonable way. See #12281

I wouldn't call that a fix, but it's a reasonable stop-gap. We shouldn't close this work item based on that, but I will be moving this out from preview 8.

@anurse what is your preference over what was in d641dffdc1? That may be a workaround but it's reliable.

My preference is that git clean not delete the TS files. Getting people to use a non-standard clean command (particularly external contributors) isn't really a suitable long-term solution IMO. I agree it's the best we've got right now though.

In other words, keep this open and move it to the backlog.

Thanks for your perspectives and for unassigning me 😺

Fixed !


course outline layout issue

Android - Assessment - Download Videos - Video download is appearing below the last access
https://openedx.atlassian.net/browse/MA-887
@aleffert  please review

:+1:


[GSSoC'21] Add an Universal Navigation bar with sidebar of the user.

I propose to add an Universal Navigation bar with Search + Home + messages +notifications with sidebar where the person who signs in can view his/her profile.
need your permission & kindly Add a label of GSSoC'21 so that i can work on this asap

Failed to compile.

./src/index.js 1:37
Module parse failed: Unexpected token (1:37)
File was processed with these loaders:
 *<EMAIL_ADDRESS> * ./node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
> $RefreshRuntime$ = require('F:/GSSoC'21/Recess/node_modules/react-refresh/runtime.js');
| $RefreshSetup$(module.id);
|

getting error when doing npm start

There's some issue with your npm..It works fine in my system

Yes now it is working, my node was not of the lastest version.


Auto import suggestions create invalid imports when re-exporting with aliases

VSCode Version: 1.21.1
OS Version: Windows 8.1 x64

Steps to Reproduce:
Given the following files:
module1.ts
export function myFunction() { };
export default myFunction;

index.ts
export { myFunction as func1 } from "./module1";

In another file, type "myFunction" and you'll see the following:

Select either option and the following invalid import will be added:

import { myFunction } from ".";

The quick fix list will have the correct suggestions and will create the correct import:

This behaviour also occurs if re-exporting the default export with an alias.

In the new file, type "func1" and no suggestions will be given. The quick fixes list will have the correct suggestions and will create the correct import:

Does this issue occur when all extensions are disabled?: Yes

This issue was moved to Microsoft/TypeScript#23186

Verified. But @gsteacy I guess your index.ts should probably be import instead of export, right?


Hammer Doesn't break ore into dust in world

I'm not sure this is possible to implement (sanely) from the item side. Will investigate.


[SHIRO-854] - Konfiguration includes/excludes maven-failsafe-plugin c…

Following this checklist to help us incorporate your contribution quickly and easily:

[X] Make sure there is a JIRA issue filed
for the change (usually before you start working on it).  Trivial changes like typos do not
require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[X] Each commit in the pull request should have a meaningful subject line and body.
[X] Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager,
where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
[X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[X] Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[X] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.
If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

[X] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
[X] In any other case, please file an Apache Individual Contributor License Agreement.

@khmarbaise we have a conflict on this one because of the merge of the other PR. Can you rebase please to fix it?


Text filter tests v2

Description
Edited the directions in the testing README
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)

Change Status

[ ] Complete, tested, ready to review and merge

How Has This Been Tested?

[ ] Test A

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

I think we should merge it for now. I also just want as many reps as I can get working with git and github (PRs, merges, pulls, etc...), so merge it even if we change it - and likely will.
@AndrewMaddocks

@AndrewMaddocks - if this doesn't have any merge conflicts, can you review & merge this?


Adding helm version test in release-1.0

@hklai: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-upgrade-tests-1.0.1.sh
c275149ca20a95a513925e3656f88c7dbaff93e1
link
/test daily-upgrade-tests-1.0.1

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-upgrade-tests-1.0.1.sh
c275149ca20a95a513925e3656f88c7dbaff93e1
link
/test daily-upgrade-tests-1.0.1

prow/daily-perf-tests.sh
c275149ca20a95a513925e3656f88c7dbaff93e1
link
/test daily-perf-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-upgrade-tests-1.0.1.sh
c275149ca20a95a513925e3656f88c7dbaff93e1
link
/test daily-upgrade-tests-1.0.1

prow/daily-perf-tests.sh
c275149ca20a95a513925e3656f88c7dbaff93e1
link
/test daily-perf-tests

prow/daily-upgrade-tests-1.0.2.sh
c275149ca20a95a513925e3656f88c7dbaff93e1
link
/test daily-upgrade-tests-1.0.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


spirv-val: Disallow stores according to VUID 06924

Ensure that the validator rejects stores to objects of types OpTypeImage, OpTypeSampler, OpTypeSampledImage, OpTypeAccelerationStructureKHR, and arrays of these types, according to VUID-StandaloneSpirv-OpTypeImage-06924.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/4796

If I understand the CI failures correctly, HLSL-to-SPIR-V translation by glslang and shaderc seems to result in some violations of this VUID, as HLSL allows the construct.  Any suggestions what to do here?

What does glslang do in the GLSL path when you have a local acceleration structure variable?

GLSL allows acceleration structures (and images/samplers) only as uniforms or function parameters, and glslang diagnoses incorrect uses:
ERROR: 0:10: 'accelerationStructureNV' : accelerationStructureNV can only be used in uniform variables or function parameters

Does this check cases where there is a OpImageWrite through an OpLoad or and Atomic instructions?

Does this check cases where there is a OpImageWrite through an OpLoad or and Atomic instructions?

OpImageWrite is checked elsewhere (in ValidateImageWrite) as far as I can tell.

To progress on this, I've excluded validation of stores to objects of types OpTypeImage and OpTypeSampler.

@s-perron Coming from a DXC perspective, should this check be gated by a pre legalization guard?

I'm not sure. The OpTypeImage and OpTypeSampler should be guarded. We do not currently generate OpTypeSampledImage in a way that would require it, but I think that could happen in the near future.
I would say yes it we should check the flag. In general, the compiler may add temporaries or the user may have local variables that are expect to get optimized away.
This would be to solution to the issue with OpTypeImage and OpTypeSampler mentioned above. The output from the glslang HLSL->SPIRV should be validated with the pre-legalization option. If the checks are guarded by that option, then they should pass.

This would be to solution to the issue with OpTypeImage and OpTypeSampler mentioned above. The output from the glslang HLSL->SPIRV should be validated with the pre-legalization option. If the checks are guarded by that option, then they should pass.

@s-perron thanks for the suggestion, I'd much rather land the complete validation including OpTypeImage and OpTypeSampler.  Is it options()->before_hlsl_legalization that you're referring to?

I've reinstated the full checks, including OpTypeImage and OpTypeSampler, now all guarded behind before_hlsl_legalization.


Fixed typos in README.md

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

Thanks for your contribution!


Fix intermittent sslapitest early data related failures (3.2 backport)

Early data is time sensitive. We have an approx 8 second allowance between writing the early data and reading it. If we exceed that time tests will fail. This can sometimes (rarely) occur in normal CI operation. We can try and detect this and just ignore the result of such test failures if the test has taken too long. We assume anything over 7 seconds is too long.
This is a backport of #23966 for the 3.2 branch

@nhorman since you approved #23966, could you take a look at this one too (also the other backport in #24320)

Merged to the 3.2 branch. Thank you.


Doesn't support arrow functions

Attempting to compress code using arrow functions gives the following error:
Unexpected token: punc ()) (line: 1, col: 9)

The code I am attempting to compress is this:
var e = () => {
	document.body.classList.add("no-scroll");
}

Please could you add support for arrow functions? I am going to have to use another compressor in the meantime.

That snippet should work if you enable the "ECMAScript 2019 (via babel-minify)" checkbox near the upper-right of the main field as seen here:


$defineI18nRoute won't match if localRoutes passed by variable

Describe the bug
$defineI18nRoute doesn't seem to accept anything else than string literals.
To Reproduce
In pages/product/[slug].vue
// This works as expected
$defineI18nRoute({
  localeRoutes: {
    de: '/produkt/:slug()',
    en: '/product/:slug()',
    es: '/producto/:slug()',
  }
});

// This won't work (404)
const locales = {
    de: '/produkt/:slug()',
    en: '/product/:slug()',
    es: '/producto/:slug()',
  };

$defineI18nRoute({
  localeRoutes: locales
});

// This won't work either (404)
const locales = { localeRoutes: {
    de: '/produkt/:slug()',
    en: '/product/:slug()',
    es: '/producto/:slug()',
}};

$defineI18nRoute(locales);

Expected behavior
Should work exactly the same way.

Not sure what's the issue, is it serialised and then transmitted to H3? I confess I didn't try to pinpoint the exact spot in the codebase where the issue would arise.
Unlike the other matter we're discussing, this one isn't blocking. But it leads to some boilerplate that could be nicely addressed by local helpers. At first I wanted to create a helper to declare my urls, kind of like so:
import mapSlug from mapSlug; // this just returns corresponding localised slug

export default function (slug) {
  const routes = {};
  $getLocales().forEach((locale) => {
    routes[locale.code] = `/${mapSlug(slug, locale.code)}/:slug()`;
  });

  return { localeRoutes: { routes }};
}

Maybe some help from the good old eval() could make it 🙈

The issue arises due to server-side rendering (SSR). During the build process, the project requires already generated links, and my module searches for defineI18nRoute using regex and simply returns a JSON structure. There are many other approaches that could partially help, such as executing JavaScript during the build. However, this would introduce another major problem: during the build, there is no Nuxt context, which means methods like getLocales in your example physically cannot work.
To implement a solution for this, we would either need to render a Nuxt page at build time to retrieve the necessary data or integrate defineI18nRoute into Nuxt’s core. The second option is something I’d love to explore myself, but I’m not sure yet how to make it work.

We can maybe strike a middle ground by just executing JS without the Nuxt context as it might be overkill. If needed, one can manually load the Nuxt config file if needed. IMHO, it's totally acceptable.

I looked into how others do it, for example, the Nuxt developers, and realized they don’t really handle it.
Link
They just parse the code, and if it's not a string, they throw an error. I did a few experiments and wrote some semi-functional code, but I don’t like it. I'll keep studying it further.

Just the fact you're taking the time to consider it is already super cool! No worries if can't be done in a clean way.
In that case it's not an issue, but by design.