Support "unsupported" widgets e.g. Painter, Charts, ...

Great package!
Unfortunately, I have to use quite some "unsupported" widgets like charts from fl_chart, diagrams painted via custom_painter, ... . I'm wondering, if it would be possible (and with normal effort realizable) to support these widgets via screenshot and image.
Have you ever spend a thought on this or do you have a better idea?
Thanks,
Vera

I gave it a try today.
I added a widget for "wrapping" unsupported flutter widgets, that I want to capture and printed:
`
import 'package:flutter/material.dart';
import 'package:flutter/widgets.dart';
class CaptureWrapper extends StatelessWidget {
final Widget child;
const CaptureWrapper({
super.key,
required this.child,
});
@override
Widget build(BuildContext context) {
return RepaintBoundary(
child: child,
);
}
}
`
I expanded export_instance.dart with this case:
`
case CaptureWrapper:
if (context != null) {
if (widget.key == null) {
throw Exception('Capture must have a key to be exported');
}
Element? contextElement =
findElement(context, (CaptureWrapper e) => e.key == widget.key);
      assert(contextElement != null);
      RenderRepaintBoundary? boundary;
      RenderObject? renderObject = contextElement!.renderObject;

      if (renderObject is RenderRepaintBoundary) {
        boundary = renderObject;
      } else {
        renderObject?.visitChildren((child) {
          if (child is RenderRepaintBoundary) {
            boundary = child;
          }
        });
      }

      assert(boundary != null);
      final ui.Image uiImage = await boundary!.toImage(pixelRatio: 2.0);
      final pngBytes =
          await uiImage.toByteData(format: ImageByteFormat.png);

      return [
        await Image.memory(Uint8List.view(pngBytes!.buffer)).toPdfWidget()
      ];
    }
    return [];

`
Up to now, it seems to work with fl_chart and CustomPainter widgets.
Unfortunately I'm not experienced enough in flutter to know if this is an elegant, efficient, ... solution. But I'm open to discussions. :-)

Hey, thanks for your detailed explanation :)
So I think supporting fl_charts boils down to supporting flutters CustomPainter.
The straight forward way to do this would be to create an extension on CustomPaint to access the paint(Canvas canvas, Size size) method. The problem with this approach is that having access to the paint method itself doesn't help much. One would need access to the actual Canvas methods used (e.g. canvas.drawColor(...), canvas.drawArc(...)), since these could be converted to their pdf equivalent.
But since this is not possible, the only way (I could think of) to support it would be your approach by converting said widgets to images. 👍
Feel free to open a pull request so I can take a closer look and actually run and test your solution. Also since your approach seems very suitable, a PR would be best for further discussion.
Thanks for your involvement! 🥇

I'll prepare a PR but it'll take me some days (lots of things on my plate atm). 🙈
I was wondering, if I could use PictureRecorder to use for CustomPaint stuff. Maybe I can give it a try ...

Hi,
thanks for incorporating the CaptureWrapper and sorry that I didn't make it in time to provide proper example, ... . Just a bit too much on my plate at the moment.
However, I'm working extensively with the CaptureWrapper and came now to problem, that I can't explain.
Following code is from your example:
class CaptureWrapperExample extends StatelessWidget {
  const CaptureWrapperExample({super.key});

  @override
  Widget build(BuildContext context) {
    return SingleChildScrollView(
      child: Column(
        children: [
          SizedBox(
            height: 400,
            width: 400,
            child: CaptureWrapper(
              key: GlobalKey(),
              child: buildChart(),
            ),
          ),
          CaptureWrapper(
            key: const Key('CustomPaint'),
            child: CustomPaint(
              key: GlobalKey(),    // <------- new key
              size: const Size(300, 300),
              painter: HousePainter(),
            ),
          ),
        ],
      ),
    );
  }

The only thing I changed in the code is that I added a GlobalKey() to CustomPaint. And it crashes ... 💥
When you replace GlobalKey by any other key it works. Unfortunately I rely on a GlobalKey as I need it for determining the size of a widget.
Do you have any idea what's going wrong and if there is a chance to fix this problem?
Thanks a lot!

Hi,
I have a very strange behaviour of the CaptureWrapper which occurs only in my code but not in your example and I can't find the point that causes the bug:
When I give a GlobalKey to a captured image, I get the following error during runtime:
════════ Exception caught by widgets library ═══════════════════════════════════
The following assertion was thrown building CaptureWrapper-[<'someFrame'>]:
'package:flutter/src/widgets/framework.dart': Failed assertion: line 2116 pos 12: '_elements.contains(element)': is not true.

Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=2_bug.yml

The relevant error-causing widget was:
    CaptureWrapper-[<'someFrame'>] CaptureWrapper:file:///Users/vsz/Development/projects/stuff/report_generator/lib/main.dart:31:15

followed by
════════ Exception caught by widgets library ═══════════════════════════════════
Duplicate GlobalKey detected in widget tree.
════════════════════════════════════════════════════════════════════════════════

Here is my minimal code example:
import 'package:fl_chart/fl_chart.dart';
import 'package:flutter/material.dart';
import 'package:flutter_to_pdf/flutter_to_pdf.dart';
import 'package:printing/printing.dart';

void main() {
  runApp(const MainApp());
}

class MainApp extends StatefulWidget {
  const MainApp({super.key});

  @override
  State<MainApp> createState() => _MainAppState();
}

class _MainAppState extends State<MainApp> {
  final ExportDelegate exportDelegate = ExportDelegate();
  GlobalKey scatterChartKey = GlobalKey();

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: ExportFrame(
          frameId: 'someFrameId',
          exportDelegate: exportDelegate,
          child: Column(
            children: [
              const SizedBox(height: 10),
              CaptureWrapper(
                key: const Key('someFrame'),
                child: SizedBox(
                  width: 400,
                  height: 200,
                  child: ScatterChart(
                    key: scatterChartKey,
                    ScatterChartData(
                      scatterSpots: [
                        ScatterSpot(1, 1),
                        ScatterSpot(1, 2),
                        ScatterSpot(2, 3),
                        ScatterSpot(3, 2),
                        ScatterSpot(4, 5),
                        ScatterSpot(5, 4),
                        ScatterSpot(6, 6),
                      ],
                      titlesData: const FlTitlesData(
                        topTitles: AxisTitles(
                          sideTitles: SideTitles(showTitles: false),
                        ),
                      ),
                    ),
                  ),
                ),
              ),
              ElevatedButton(
                onPressed: () async {
                  final ExportOptions overrideOptions = ExportOptions(
                    textFieldOptions: TextFieldOptions.uniform(
                      interactive: false,
                    ),
                    checkboxOptions: CheckboxOptions.uniform(
                      interactive: false,
                    ),
                  );
                  final pdf = await exportDelegate.exportToPdfDocument(
                    'someFrameId',
                    overrideOptions: overrideOptions,
                  );
                  Printing.layoutPdf(onLayout: (format) => pdf.save());
                },
                child: const Text('Export'),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

and my pubspec.yaml
name: report_generator
description: "A new Flutter project."
publish_to: "none"
version: 0.1.0

environment:
  sdk: ">=3.4.4 <4.0.0"

dependencies:
  fl_chart: ^0.68.0
  flutter:
    sdk: flutter
  flutter_to_pdf: ^0.2.1
  printing: ^5.13.1

dev_dependencies:
  flutter_test:
    sdk: flutter
  flutter_lints: ^3.0.0

flutter:
  uses-material-design: true

When I replace the chart from your example app with the following code:
return ScatterChart(
      key: GlobalKey(),
      chartRendererKey: rendererKey,
      ScatterChartData(
          scatterSpots: [
            ScatterSpot(1, 1),
            ScatterSpot(1, 2),
            ScatterSpot(2, 3),
            ScatterSpot(3, 2),
            ScatterSpot(4, 5),
            ScatterSpot(5, 4),
            ScatterSpot(6, 6),
          ],
          titlesData: const FlTitlesData(
              topTitles:
                  AxisTitles(sideTitles: SideTitles(showTitles: false)))),
    );

everything works still fine.
Do you have any idea? What's going on here? I think I already spent 2 days now on trying many things to make it work but besides isolating the problem to this minimal example, I didn't make any progress ... :-(
BTW: just tried the same with a Text widget and a GlobalKey and had the same problem, so it doesn't seem to be a problem of ScatterChart.

Does the error happen once you export a frame or already before exporting (when rendering the widget on screen) ?

It happens during export.
Gesendet von Outlook für iOShttps://aka.ms/o0ukef

Von: Joseph Grabinger @.>
Gesendet: Saturday, August 3, 2024 8:28:40 PM
An: joseph-grabinger/flutter_to_pdf @.>
Cc: Vera Spöttl-Zeisberg @.>; Author @.>
Betreff: Re: [joseph-grabinger/flutter_to_pdf] Support "unsupported" widgets e.g. Painter, Charts, ... (Issue #62)
Does the error happen once you export a frame or already before exporting (when rendering the widget on screen) ?
—
Reply to this email directly, view it on GitHubhttps://github.com/joseph-grabinger/flutter_to_pdf/issues/62#issuecomment-2267095151, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXW4SU6DOMRLUVXCKVACLXDZPUONRAVCNFSM6AAAAABFTC3WJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRXGA4TKMJVGE.
You are receiving this because you authored the thread.Message ID: @.***>

I was able to reproduce the issue!
It seems that the issue only occurs if a widget inside of a CaptureWrapper uses a  GlobalKey outside of the CaptureWrapper's scope.
This works:
 CaptureWrapper(
    key: const Key('CustomPaint'),
    child: CustomPaint(
      key: GlobalKey(),
      size: const Size(300, 300),
      painter: HousePainter(),
    ),
  ),

But this doesn't work:
final gKey = GlabalKey();

 CaptureWrapper(
    key: const Key('CustomPaint'),
    child: CustomPaint(
      key: gKey,
      size: const Size(300, 300),
      painter: HousePainter(),
    ),
  ),

Not completely sure why this is the case :/

Unfortunately, in my minimal example moving the GlobalKey into a child widget of CaptureWrapper makes no difference. In both cases, I get the error. And it makes no difference if it is a complex widget like the ScatterChart or a quite simple one like placeholder:

This seems to be the place where the problem appears:

API-Documentation of GlobalKey says:
"Widgets that have global keys reparent their subtrees when they are moved from one location in the tree to another location in the tree."
I guess this is somehow the problem. But I don't understand and can't explain it yet.

And it makes no difference if it is a complex widget like the ScatterChart or a quite simple one like placeholder

I agree that it doesn't depend on the widget itself but rather on a GlobalKey being present.
However, your example with the Placeholder(key: GlobalKey()) (or also a Text("someText", key: GlobalKey())) doesn't produce any errors for me and the entire widget is exported correctly.
Since there is seems to be some difference in the output.... What flutter version are you using?
For me the examples run just fine on Flutter (Channel stable, 3.22.0, on macOS 14.6 23G80 darwin-x64, locale de-DE)

Very strange behaviour!
That’s my flutter doctor
[✓] Flutter (Channel stable, 3.22.3, on macOS 14.5 23F79 darwin-arm64, locale de-DE)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.1)
[✓] VS Code (version 1.91.1)
[✓] Connected device (4 available)
[✓] Network resources
• No issues found!
Not much different. Guess the MacOS version shouldn’t cause the problem.
I’ll try to downgrade to Flutter 3.22 later this afternoon and let you know the result.
Von: Joseph Grabinger @.>
Datum: Sonntag, 4. August 2024 um 12:52
An: joseph-grabinger/flutter_to_pdf @.>
Cc: Vera Spöttl-Zeisberg @.>, Author @.>
Betreff: Re: [joseph-grabinger/flutter_to_pdf] Support "unsupported" widgets e.g. Painter, Charts, ... (Issue #62)
And it makes no difference if it is a complex widget like the ScatterChart or a quite simple one like placeholder
I agree that it doesn't depend on the widget itself but rather on a GlobalKey being present.
However, your example with the Placeholder(key: GlobalKey()) (or also a Text("someText", key: GlobalKey())) doesn't produce any errors for me and the entire widget is exported correctly.
Since there is seems to be some difference in the output.... What flutter version are you using?
For me the examples run just fine on Flutter (Channel stable, 3.22.0, on macOS 14.6 23G80 darwin-x64, locale de-DE)
—
Reply to this email directly, view it on GitHubhttps://github.com/joseph-grabinger/flutter_to_pdf/issues/62#issuecomment-2267498020, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXW4SUY4OM3MEOXQI5OAZULZPYBVXAVCNFSM6AAAAABFTC3WJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRXGQ4TQMBSGA.
You are receiving this because you authored the thread.Message ID: @.***>

Okay I just upgraded to Flutter 3.22.3 and now I have the same issue.
So it seems that there has been some kind of change to  the GlobalKey between Flutter 3.22.0 and 3.22.3.

What's the best way to handle this?
I can't find anything in the Flutter change logs related to GlobalKey. I could downgrade to 3.22 but I guess that just postpones the problem to the next update of Flutter.

What's the best way to handle this?

I created a separate Issue (#81) so we could move the discussion to there.
I'll create a branch with an example that runs on my machine, since I am now also running Flutter 3.22.3. You could then check-out the branch and we'll go from there.


FAR: Lone Sails

The game runs smoothly with no stuttering. I finished the game, and here are the shader caches for y'all :D
FarLoneSails.zip

1091 entries, thank you.


Review script for paper "2024ApJS..271...59L" made with predictor "DataLinkerCondenseDetailsWithTemplate"

Created by Paper Data Linking Bot
Please review the download script and instrument details for the paper.
bibcode: 2024ApJS..271...59L
predictor: DataLinkerCondenseDetailsWithTemplate

The main issue here is that the algorithm has not identified that the proximal data source used is CDAW-created running difference images of LASCO data. This is described under section 2 ("Data"). The time ranges and the identification of LASCO C2 and C3 are correct.

I believe the observation period for SECCHI CO2 is the year 1996 and the year 2007; it is not a time range. From article: "...using SECCHI CO2 observations from 1996 and 2007."


Create indexer for fetch transaction

FRO-29
Fetch a single TX should fetch all the fields available on the TX this is one example https://gist.github.com/luizstacio/44bda679b8805bbb835370f839855227

What is the difference between this and #12?
Ofc, this one has a lot more data, which at the moment is an issue, but we can expand the amount of data gathered in the linked issue later.


Autonav: replace 'sibling' with 'child' for subpages

The auto-nav block currently uses 'Sibling Pages'. While I can see where this comes from (i.e. the pages can be interpreted to be siblings to the current page, where the autonav is being placed), it is a source of confusion. The concept seems better captured by calling the pages 'Child Pages', as this option reveals more sub-pages in the menu.

I do not understand what happened here.. Why did you decide against merging this commit, but closed the pull request from a commit with identical content?

Because I was operating out of email, and didn't see this was a pull request – I assumed it was an issue without an accompanying pull request.

I reverted and merged to maintain history a9320fb


Do not show "Privacy Policy" link if privacy_pack = false

I installed your new (2.3) version of the academic framework. Thank you for all the effort and updates!!
I noticed that the new version produced a "Privacy Policy" link at the footer with an empty text. I had to remove the privacy.md in order to get rid of this link.
I am very happy that you prepared the academic framework with all the new EU requirements! But I haven't had time to look into it and there I haven't installed this new functionality. Wouldn't it be better to have the possibility to turn off/on this message instead to provide the (empty) link automatically?

This is not present in Academic Kickstart (the primary installation method). It's just for demonstration on the demo website.


Can't set webpack config of preload file

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
6.1.1
Electron version
17.4.11
Operating system
Window 10 (19045)
Last known working Electron Forge version
unkonw
Expected behavior
Preload js should wrap by webpack.
Actual behavior
Not do the expected behavior.
Steps to reproduce
      renderer: {
        config: rendererConfig,
        entryPoints: [
          {
            js: './src/main.ts',
            name: 'main',
            preload: {
              js: './electron/preload.js',
              config: {
                entry: "./electron/preload.js",
                output: {
                  path: path.resolve(__dirname, ".webpack/main"),
                  filename: '[name].js',
                },
                resolve: {
                  extensions: [".js"],
                }
              },
            },
          },
        ],
      },

I'm sure that main and renderer webpack output not clean up work directory.
Additional information
No response

Hello, is there any one who have the same problem?

Yes, I have the same problem.
I need to have separate webpack configs for renderer and preload scripts. Renderer webpack config include frontend framework plugins, that are not needed in preload script.


v2 Provisioning: RBAC - Support restricted-admin

Currently, RKE2 provisioning works for admin, but needs to extend support for restricted admin.
We should also test that cluster owners/members or project owners/members don't have any issues with provisioning or using clusters/projects and the resources inside.
This needs to be tested with the feature flag on/off for import and custom cluster use cases to confirm that the workflow is right depending on the RKE2 feature flag.

Blocked by https://github.com/rancher/rancher/issues/34185


Filter unauthorized datasources in INFORMATION_SCHEMA queries

This PR filters out datasources that the user is not authorized to read from the output of SQL INFORMATION_SCHEMA queries.
Prior to this patch, access to INFORMATION_SCHEMA was all-or-nothing based on whether the user had access to a datasource type resource named "INFORMATION_SCHEMA".

@jon-wei can you backport this please?


canvas_item shader setting alpha greater than one, caps alpha at 1 on GLES2

Godot version: 3.2.3
OS/device including version:

OS: Windows 10 (Home edition?)
Godot reports my GPU as OpenGL ES 3.0 Renderer: GeForce GTX 1650 Ti/PCIe/SSE2

Issue description:
One of my shaders makes sprites "highlight" by setting the alpha to a value between 1x and 3x the original (1-3). In GLES3, it looks correct (see below); in GLES2, there is no visible change (I think it's capping the alpha at 1.0).

Steps to reproduce:
Here's an approximation of my shader:
shader_type canvas_item;

uniform float highlight_amount : hint_range(1, 3) = 1.0;

void fragment() {
	vec4 final_colour = texture(TEXTURE, UV);
	float alpha = texture(TEXTURE, UV).a;
	COLOR = vec4(final_colour.r, final_colour.g, final_colour.b, alpha * highlight_amount);
}

Please advise. I was told that this is something I should open a bug-report about.
For what it's worth, this renders the same in Godot 3.1.2. In 3.0.6, which only supports GLES3, this renders correctly (with the glow).

GLES2 doesn't support high dynamic range (HDR) rendering. Which means all color values are limited to the range 0-1
See here for more info. https://docs.godotengine.org/en/stable/tutorials/misc/gles2_gles3_differences.html#hdr

Try multiplying the RGB colors instead of increasing alpha above 1.0.

Color(3, 3, 3) doesn't look the same, but I get your point: it's not going to work in GLES2. I'm not good with shaders, I don't know how to reproduce the effect, so I'll try and come up with something else that achieves the same goal.
Thanks for clarifying.


can not update to or install atom-typescript v10.1.10

% apm --version
apm  1.13.0
npm  2.15.9
node 4.6.0
python 2.7.12
git 2.7.4

% apm install atom-typescript
Installing atom-typescript to /home/$MYLOGINNAME/.atom/packages ✗

npm WARN peerDependencies The peer dependency typescript@* included from byots will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN optional dep failed, continuing<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm ERR! Linux 4.7.7-200.fc24.x86_64
npm ERR! argv "/usr/lib/node_modules/atom-package-manager/bin/node" "/usr/lib/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/home/$MYLOGINNAME/.atom/.apm/.apmrc" "--userconfig" "/home/$MYLOGINNAME/.atom/.apmrc" "install" "/tmp/d-116929-3503-1jawem1/package.tgz" "--runtime=electron" "--target=0.37.8" "--arch=x64" "--global-style" "--legacy-bundling"
npm ERR! node v4.6.0
npm ERR! npm  v2.15.9
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants typescript@*

npm ERR! Please include the following file with any support request:
npm ERR!     /tmp/apm-install-dir-116929-3503-1c1yv7o/npm-debug.log

there is no directory /tmp/apm-install-dir-116929-3503-1c1yv7o
maybe the problem is peerDependencies from byots
"typescript": "*"

* doesn't match pre-release versions
% semver -r '*' 2.0.0 2.0.1 2.1.0 2.1.1 2.1.0-dev.20161023 2.2.0 2.2.1-dev.20161023 2.3.0
2.0.0
2.0.1
2.1.0
2.1.1
2.2.0
2.3.0

documentation for node-semver says

If a version has a prerelease tag (for example, 1.2.3-alpha.3) then it will only be allowed to satisfy comparator sets if at least one comparator with the same [major, minor, patch] tuple also has a prerelease tag.

Yeah, this is a known issue with npm 2.x. The problem is that there's no way to specify a range that will match any prerelease version. byots would have to say 2.2.0-dev || 2.2.1-dev || 2.3.0-dev and so on.
I can update Typescript to 2.0.6 which is very close to the nightly we're using now, but there's a different issue with the byots declaration file containing initializers.
What's your Atom version?

Same problem as @stesachse reported :(

% atom --version
Atom    : 1.11.2
Electron: 0.37.8
Chrome  : 49.0.2623.75
Node    : 5.10.0

Should be fixed in v10.1.11

hi @guncha .
i tried to install it again . the package installed but can not load as below error :
__```
filename is not defined
Hide Stack Trace
ReferenceError: __filename is not defined
at isFileSystemCaseSensitive (evalmachine.:3410:36)
at getNodeSystem (evalmachine.:3413:45)
at evalmachine.:3695:19
at ts (evalmachine.:3709:7)
at evalmachine.:3715:3
at Object.exports.runInContext (vm.js:44:17)
at Object.makeTsGlobal (/home/fff/.atom/packages/atom-typescript/dist/typescript/makeTypeScriptGlobal.js:18:12)
at Object. (/home/fff/.atom/packages/atom-typescript/dist/main/atomts.js:4:24)
at Module._compile (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:103:30)
at Object.defineProperty.value [as .js] (/usr/share/atom/resources/app.asar/src/compile-cache.js:208:21)

Thanks

@guncha may be related to this issue as displayed in atom
#1071

v10.1.11 works for me! thanks @guncha

@saeedtabrizi please open a new issue. You're running a custom version of Typescript using the "Full path to typescriptServices.js" option in the settings so this is unrelated to the issue here.


Bump Dependencies #4125427681

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/4125427681

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Provide an API for safely transforming records in ProduceRequest and FetchResponse

Non blocking comment... the fact that the filter author has to get deep into MemoryRecordBuilders to achieve mutation of a record is bothersome.  I'm wondering if Kroxylicious could provide an API to ease the burden.  I don't have a thought through suggestion, but want to share.   Something that let you express a predicate (deciding if a record is to be mutated) and a function that did the actual transformation.  It would take care of the buffer management.
I guess dealing with aspects like compression, different formats could make it tricky.

Originally posted by @k-wall in https://github.com/kroxylicious/kroxylicious/issues/546#issuecomment-1677118430

One idea for a vague shape for the thing:
ProduceRequestData request = requestFromClient();
ProduceRecordTransformer t = ProduceRecordTransformer.builder(Serdes.String, Serdes.String)
                                                     .withValueFilter(value -> value.startWith("hello"))
                                                     .transformValue(value -> value + ", world!").build();
t.transform(request);

@SamBarker also suggested revisiting https://github.com/kroxylicious/kroxylicious/pull/152
By replacing ByteBufferOutputStream createByteBufferOutputStream(int initialCapacity); with something like MemoryRecordsBuilder mutableCopyOf(Records records);
This would solve the issue we have with MemoryRecordsBuilder construction and give us a higher level API on the Context, with less boilerplate required by authors to put the Builder together.


Cleanup README's formatting

Minor grammar changes
Each sentence is given its own line to make changes easier to see in Git
Format all filenames in monospace (i.e. surround them with backticks)

With the exception of a handful of grammar changes, this is completely a matter of personal preference. No hard feelings at all if you prefer the current formatting, @sirwart.

Thanks for the suggestion @lafrenierejm. I read through the PR and while I like that it simplifies diffs, it also adds a layer of abstraction between newlines in the code and in the generated HTML, which I don't like since you may not be reading the HTML version of the README. Because of this I do prefer the current formatting.


Fix copy aliasing bugs

This PR fixes some bugs with copying when the LHS and RHS involve the same variable.  There were two sources of bugs:

Lack of an Eigen .eval() being inserted in some cases.
Lack of an intermediate variable being inserted during size processing in some cases.

Examples of the bugs now fixed are in the aliasTests list added to test-coreR.R

@paciorek @danielturek The copying bugs I emailed you about were a bit bigger than I first realized.  This PR fixes them.

Ready to merge in?

I think so.


Test enviornment explicitely depends on CUDA

CUDA.jl should not be directly needed to run the tests.

Closed by #324.


database list query with multiple Subject parameters

Here's a plunker of what I'm trying to do, and it has the issues I'm seeing with needing to perform a search twice before getting results back
http://plnkr.co/edit/HaWIwkhPWz08qJT6mYuJ?p=preview
Basically I have composite keys so I can search multiple fields with a single query, and based on the search terms supplied I need to change which key I search on. So I'm setting query.orderByChild and query.equalTo to two different Subject variables and calling next() on them both during a search.
I dont know if there's a different way to accomplish this, but what I'm doing doesn't seem to work.
I also tried setting the whole query object to a Subject variable and calling next on it (example next({orderByChild: 'state', equalTo: 0}), but that didnt work either.

@nelsonad Looking at your plnkr code, it seems you're trying to do something similar as given in the example app in the guide here.
The below example works for me
`
import { Component } from '@angular/core';
import { AngularFire, FirebaseListObservable, FirebaseObjectObservable } from 'angularfire2';
import { Subject } from 'rxjs/Subject';
@Component({
selector: 'app-root',
template: `

      {{ item.text }}

Filter by size
Small
Medium
Large

  `,
})
export class AppComponent {
  items: FirebaseListObservable;
  sizeSubject: Subject;
  sizeSubjectName: Subject;
constructor(af: AngularFire) {
this.sizeSubject = new Subject();
this.sizeSubjectName = new Subject();
this.items = af.database.list('/items', {
query: {
orderByChild: this.sizeSubjectName,
equalTo: this.sizeSubject,
}
});
}
filterBy(sizeName: string, size: string) {
this.sizeSubject.next(size);
this.sizeSubjectName.next(sizeName);
}
}
`
If this doesn't helps you should also look at this stackoverflow article
and library Querybase from @davideast that allows you to order by multiple values.
Hope that helps.

@mukesh51 Thanks for your reply. My problem is similar to the example, but different because the example doesnt change the orderByValue, the search is always on the size property.
I've updated my plunker example to use the tshirt example and added a color property that is also searched and it still has the same issues.
I actually got the idea to use composite keys from the querybase project, but I'm not using it and I'm not sure it would solve the issue here.

I think the best option would be to add support on the query object so that it can be observable like it's child keys, this way multiple parameters can be changed during a single event.
But I'm not great with what the rxjs library offers, so I'm not sure if there's already a way to support what I'm trying to do.
Any feedback/workarounds would be appreciated

It's not possible to order by multiple criteria. This is a limitation of the database and outside the scope of AngularFire2 to tackle. QueryBase is indeed the most useful resource for this sort of problem.

I think you misunderstood me.
It is possible to filter by multiple criteria using composite keys, which querybase is doing, and I'm doing manually.
What's not possible is to change two parameters of the query object with observables.
https://github.com/angular/angularfire2/blob/master/docs/4-querying-lists.md#creating-a-query-with-observable-values
You can change orderByChild with an observable and equalTo with an observable independently. But you cant change both with an observable without issue.

That makes sense; thanks for clarifying. So the problem, as you've described it, is that you must use two observables and that's too annoying? Or it doesn't work with two?

@katowulf it doesn't work with two.
Looks like my plunker above stopped working, I'll try to get it updated so you can see the problem.

Should this still be closed?

Just chiming in to say I've noticed the same behaviour.
When using 2 (or 3) subjects to update a list query, it requires you to push the values twice to the subjects to perform the query.
    return this.angularFire.database.list(`/${CLIENT_FEED_PATH}/${clientId}`, {
      query: {
        orderByChild: this.orderByField$,
        equalTo: this.fieldEqualTo$,
        limitToFirst: this.itemLimit$
      }
    })

Whatever function I use to push new values to these subjects using .next() needs to be fired twice for the values emitted by the .list() to update to the correctly-filtered ones.

I have a similar problem caused with the same root cause. I have stored list of calendar events in the Firebase and using Fullcalendar to display them. Due to thousands of records from several years I can not have to loaded all events. I read only events for the period what the fullcalendar is currently showing. So I have to query the database with startAt and endAt parameters. Next period is loaded, for example, when the user click on the Next month button in the calendar. I've started to code like:
export class EventsCalendarComponent {
  private start$: Subject<string> = new Subject<string>();
  private end$: Subject<string> = new Subject<string>();

  constructor(private db: AngularFireDatabase) {
    db.list('/events', {
      query: {
        orderByChild: 'date',
        startAt: this.start$,
        endAt: this.end$
      }
    }).subscribe(events => {
      // update fullcalendar component with events
    });
  }

  filterByPeriod(start: Moment, end: Moment) {
    this.start$.next(start.getTime());
    this.end$.next(end.getTime());
  }
}

I think this is next very common use case. So the support of multiple Subject parameters in query would be a very useful feature. Or what about enabling to have all the query object observable, not only its values?... Usage could be like:
export class EventsCalendarComponent {
  private query$: Subject<Object> = new Subject<Object>();

  constructor(private db: AngularFireDatabase) {
    db.list('/events', {
      query: this.query$;
    }).subscribe(events => {
      // update fullcalendar component with events
    });
  }

  filterByPeriod(start: Moment, end: Moment) {
    this.query$.next({
      orderByChild: 'date',
      startAt: start.getTime(),
      endAt: end.getTime()
    });
  }
}

@tomasklima You might be better to submit a new issue as they closed this one and don't seem interested in discussing it. I've moved away from firebase because of this.

Did anything come of this?


Fix/sharing/updatebyid

This PR makes UpdateShare() lookup the storage relative path with the provided share key attributes or the shareid.

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #143   +/-   ##
=====================================
  Coverage      75%    75%
=====================================
  Files           2      2
  Lines          40     40
=====================================
  Hits           30     30
  Misses          5      5
  Partials        5      5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3851910...50825b2. Read the comment docs.

I merge for the time being, I want to remove the coupling between share providers and storage providers, therefore, all metadata needed is to be passed from upper layers when creating the share.


fix smarty flink function, if its a composer project

1. Why is this change necessary?
If you use shopware composer project, the smarty flink function generates the wrong file include paths. Some of the JS Libraries linked from vendor paths. Usually vendor paths not accessable from outside, so if you try to use tinymce in shopware backend, you get forbidden errors.
the main header of the shopware backend
themes/Backend/ExtJs/backend/base/header.tpl

without this fix, you get this kind of js library includes in html source code

but in a composer project the libraries symlinked into that folder
/engine/Library
so the real include path is
/engine/Library/ExtJs/ext-all.js
2. What does this change do, exactly?
It removes the vendor paths from the file paths.
3. Describe each step to reproduce the issue or behaviour.

create an shopware composer project
navigate to the shopware backend
look at the HTML source code
the javascript files (tiny_mce.js,ext-all.js,codemirror.js) will be include from vendor paths

4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x ] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-22592
Please use this issue to track the state of your pull request.

Hi,
thx for the PR. You need to sign the license/cla otherwise we cannot accept your PR.
Greetings,
Marcel

should signed now
Greetings Björn

Is that really an error of my commit?

No, its an error in the main branch. You can ignore it - shopware will fix it.

CLA already signed.

You can close this PR, is fixed with this commit https://github.com/shopware/shopware/commit/5def646105d36305da5159ac3935fc1f808f95e2

Hey @bragento,
thanks for the info!

Sorry, my mistake. This bug is allways there.
We fix it in currently in app/functions.sh with rsync instaed of symlinking.
    #ln -s ../../vendor/shopware/shopware/engine/Library/CodeMirror engine/Library/CodeMirror
    #ln -s ../../vendor/shopware/shopware/engine/Library/ExtJs engine/Library/ExtJs
    #ln -s ../../vendor/shopware/shopware/engine/Library/TinyMce engine/Library/TinyMce
    rsync -az --delete vendor/shopware/shopware/engine/Library/CodeMirror/ engine/Library/CodeMirror/
    rsync -az --delete vendor/shopware/shopware/engine/Library/ExtJs/ engine/Library/ExtJs/
    rsync -az --delete vendor/shopware/shopware/engine/Library/TinyMce/ engine/Library/TinyMce/

We notices the same Error in Shopware 5.5.4.
So the "bug" wasn't fixed

So the issue is fixed, with this PR https://github.com/shopware/composer-project/pull/28/commits/f2a20dc48ed151d73463e1fd7d50b668861f2a30


Use @types/vscode-webview package

This change makes use of the @types/vscode-webview package to remove the unsafe any vscode API declaration.
I was originally made aware of this, because the way this is currently implemented doesn't work correctly in Theia, see https://github.com/eclipse-theia/theia/issues/13374.

Thanks!


feat: introduce simple-action

Extracting all Action content to trait, can give us the opportunity to use simple actions (inside resource edit page)
note: needs to be documented too
PS: Thanks for this package. it is the best, I have cheked till now 😄

This weekend I can review and merge, thank you for the contribution

Just a reminder here 😉

hi @GeoSot I didn't forget, I just lack the time to look at everything calmly and document it.
I'm going to organize myself so I don't let this week go by

If you need any help, please ping me up


Perform evaluation of ring-buffer vs map

There are two approaches available in existing metric collectors.

Aggregating metrics in bpf using maps.
Sending metrics per packet to userspace using ringbuffer.

Need to analyze the performance overheads of both the approaches.

My initial analysis points to the following :
Type                       | Packets/sec (Mpps)  | CPU overhead (additional)
Native                                             | 4.25 |   N/A
eBPF(tc) with per-cpu HashMap | 2.74 | ~2-5%
eBPF(tc) with common HashMap| 1.42 | ~2-5%
eBPF(tc) with ringbuffer summits| 1.73 | ~100%
tcpdump                                         | 1.63 | ~40%
---------------------------------|         |

Comparison Done,


AndroidSigning@3 is returning failed with exit code 1

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: here
Enter Task Name: here
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Server - Azure Pipelines or TFS on-premises?

If using TFS on-premises, provide the version:

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:

Agent - Hosted or Private:

If using Hosted agent, provide agent queue name:

If using private agent, provide the OS of the machine running the agent and the agent version:

Issue Description

Task logs

Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
My key store password is starting with asteriks and AndroidSigning3 is not appending ""around it
e.g
C:\Windows\system32\cmd.exe /D /S /C "C:\Android\android-sdk\build-tools\33.0.0\apksigner.bat sign --ks D:\a\_temp\inhouse-keystore.jks --ks-pass pass:*ABC --ks-key-alias AAA --key-pass pass:ABC --verbose D:\a\1\s\app\build\outputs\apk\inhouse\app-inhouse-unsigned.apk"
So if you notice here --ks-pass pass:*ABC this is not like this --ks-pass *pass:*ABC*

Did you ever figure out this issue? I'm running into the same issue but with dx.jar instead of the apksigner.bat.

Mine was solved by removing some symlinks I had to /usr/shared/java. Not sure if your issue is related.


Production vendor code duplicated

Trying to implement canjs with v4.
This and other modules are duplicated in the production bundle;
'use strict';
var namespace = require('can-namespace');
var Globals = require('./can-globals-proto');
var globals = new Globals();
if (namespace.globals) {
throw new Error("You can't have two versions of can-globals, check your dependencies");
} else {
module.exports = namespace.globals = globals;
}
fuse-box bundle;
1:
// can-globals/can-globals-instance.js
$fsx.f[20] = (module, exports) => {
'use strict';
var namespace = $fsx.r(3);
var Globals = $fsx.r(19);
var globals = new Globals();
console.log("NAMESPACE*****************", namespace.globals, namespace);
if (namespace.globals) {
throw new Error("You can't have two versions of can-globals, check your dependencies");
}
else {
module.exports = namespace.globals = globals;
}
}
2:
// can-globals/can-globals-instance.js
$fsx.f[117] = (module, exports) => {
'use strict';
var namespace = $fsx.r(3);
var Globals = $fsx.r(19);
var globals = new Globals();
if (namespace.globals) {
throw new Error("You can't have two versions of can-globals, check your dependencies");
}
else {
module.exports = namespace.globals = globals;
}
}
App fails during second execution;  All other bundlers, webpack, browserify etc only have one copy in their bundles.

Thanks for reporting that. I am re-writing the production logic. Could you reproduce this issue? I will check it later once it's done.

@nchanged - Requires the complete app to reproduce - I can check once you publish the new version.

@DaveO-Home can you please confirm if the issue still occurs with<EMAIL_ADDRESS>Also see here for info on major changes

@charsleysa are there docs on custom plugins, in next.165 this worked fuse-box/core/Context. Can't test without the plugin.

@DaveO-Home which plugin are you using?

@nchanged my own custom plugin - its strips development code.

@nchanged
import { parsePluginOptions } from "fuse-box/plugins/pluginUtils";

export type IPluginStripProps = { [key: string]: any };
export function pluginStripCode(a?: IPluginStripProps | string | RegExp, b?: IPluginStripProps) {
  const [opts, matcher] = parsePluginOptions<IPluginStripProps>(a, b, {});

  return (ctx: Context) => {

    ctx.ict.on("assemble_fast_analysis", props => {
      if ((matcher && !matcher.test(props.module.props.absPath)) ||
        /node_modules/.test("can")) {
        return;
      }
      const { module } = props;

      ctx.log.info("pluginStripCode", "stripping code in $file \n", {
        file: module.props.fuseBoxPath,
      });

      const startComment =  opts.start || "develblock:start";
      const endComment =  opts.end || "develblock:end";
      const regexPattern = new RegExp("[\\t ]*(\\/\\* ?|\\/\\/[\\s]*\\![\\s]*)"
            + startComment + " ?[\\*\\/]?[\\s\\S]*?(\\/\\* ?|\\/\\/[\\s]*\\![\\s]*)"
            + endComment + " ?(\\*\\/)?[\\t ]*\\n?", "g");

      module.read();
      module.contents = module.contents.replace(regexPattern, "");
      return props;
    });
  };
}

@DaveO-Home
export function pluginStripCode(a?: IPluginStripProps | string | RegExp, b?: IPluginStripProps) {
  const [opts, matcher] = parsePluginOptions<IPluginStripProps>(a, b, {});

  return (ctx: Context) => {

    ctx.ict.on("module_init", props => {
    const { module } = props;
      if ((matcher && !matcher.test(module.absPath)) ||
        /node_modules/.test("can")) {
        return;
      }

      ctx.log.info("pluginStripCode", "stripping code in $file \n", {
        file: module.publicPath,
      });

      const startComment =  opts.start || "develblock:start";
      const endComment =  opts.end || "develblock:end";
      const regexPattern = new RegExp("[\\t ]*(\\/\\* ?|\\/\\/[\\s]*\\![\\s]*)"
            + startComment + " ?[\\*\\/]?[\\s\\S]*?(\\/\\* ?|\\/\\/[\\s]*\\![\\s]*)"
            + endComment + " ?(\\*\\/)?[\\t ]*\\n?", "g");

      module.read();
      module.contents = module.contents.replace(regexPattern, "");

    });
  };
}

@nchanged - the problem is here return (ctx: Context) => {  how does Context get resolved?  It seems that the new config doesn't recognize { plugins:[] }.  import { Context } from "fuse-box/core/Context"; is no longer getting resolved.

@DaveO-Home
 import { Context } from "fuse-box/core/context";

@nchanged  Production now works; just have to get font-awesome working....

@DaveO-Home you should try the following btw:
if( process.env.NODE_ENV === "development" ) {

} else {

}

It computes it during the runtime for dev and prod and unwraps the statements


Enable monetization on Insert (Youtube)

I would like to know if it is possible to enable monetization when uploading a video by using google.youtube.

@Agnostic I hope this link helps.
https://developers.google.com/youtube/partner/upload_claim_sample
This Stack Overflow link will help you understand the process better.
https://stackoverflow.com/questions/18800665/how-to-enable-monetization-for-videos-uploaded-with-youtube-data-api-v3


Not working on git bash terminal

I am using VsCode for my development. And my default terminal is git bash in VsCode. But when I run expect.exe on real git bash, it could not read the output or it could not send any command after spawn. Here is my screenshot and code. It waits forever. But however it runs perfectly when i run it on vscode teminal. Despite VsCode also uses the git bash. First screenshot is vscode terminal which is success.

FAILED SCREEN IN BELOW

HERE IS MY CODE
echo(true) if spawn([[c:\Program Files\Git\usr\bin\bash.exe]],"ssh-copy-id","-i",arg[1],arg[2],arg[3]) then     expect("?")     echo(false)     sendln("yes")     expect("password:")     sendln("toor") end

Thank you for reporting issue.
Is your terminal (not shell) compatible with Windows Command Prompt or are you using a terminal like mintty?
Tell me that the corner's icon of the terminal is like this or not ?

Thanks for your interest.
No I am not using windows command prompt. Here is my git-bash terminal icon.

I understood.
My expect.exe reads text by ReadConsoleOutputW API. But, NOT ON Windows Command Prompt, it can not work as we hope. I have to improve my expect.exe to read them like the UNIX version of expect. It seems to take a long time.
Would you like to wait ?
（or you can look for the MSYS version of expect. )

I have already working on windows, but for generate a linux tool , I am using bash terminal to use unix commands. For now I found a workaround. I am calling windows command prompt and running batch file that calling expect.exe in bash. It seems working now. There is no urgency for me. Thanks for your developing and interest.

I have to admit it is difficult to run expect.exe on terminals not compatible with the Windows-Command-Prompt.
Since the workaround is found, I would like to close this issue.
( You can reopen this issue if you need. )


github: support more badges

Support more github badges:

PRs
open PRs
closed PRs
merged PRs
commits
branches
releases
last commit
total downloads

Closes #101

Awesome! Thanks @jackmu95

Deployed https://badgen.net/#github


Team update - Oct 19, 2022

This is a @Quansight-Labs/czi-a11y-grant team sync 🎉🎉🎉! This is a way for the Team Members to provide status reports on what they've been up to this week and request help and attention for things they are working on. This issue will be closed at the end of the day.
Copy and paste the template below, and answer questions as you wish!

Response Template
**Thanks I'd like to give 🙌**
- So-and-so helped me out a lot with foo...

**Updates from last week :heavy_check_mark:**
- I worked towards deliverable: <link-to-deliverable>

**Challenges I faced and things I'd like assistance with 🙏**
- I had a hard time figuring out ...

**My availability for next week**
- I'll be off on foo day...

**Important items for discussion 💬**
- I have a question about goal <link-to-goal>
- Can @foo give a comment on issue #NN ?
- I opened #NN for discussion, please chime in
- I need to discuss foo

:mag: Needs Triage
The Needs Triage issues require an initial assessment and labeling.
No issues need triage! 🎉
:dart: Project boards
Please make sure the boards reflect the current status of the project.
Jupyter a11y grant project

Thanks I'd like to give 🙌

@isabela-pf for working hard in the blog post

Updates from last week :heavy_check_mark:

I worked in the blogpost, now it is almost ready, I still need to work in a gif with the themes to add it.
I added six new themes to the accessibility-pygments repo. I still have two themes to fully support vscode recommended themes - tracking issue

Challenges I faced and things I'd like assistance with 🙏

I'm ok

My availability for next week

I'll be here

Important items for discussion 💬

I don't have anything for today

Thanks I'd like to give 🙌

Thanks to @steff456 for being the accessibile-pygments expert in the draft blog post!

Updates from last week :heavy_check_mark:

#133 got feedback on mockups in JupyterLab #10004 in the JupyterLab and JupyterLab accessibility calls.
#132 the keyboard navigation event is being turned into an issue for jupyter/notebook I have a draft of it open literally as I type this update 😆. I will finish it after this call.
Worked on accessible-pygments blog post with Stephannie. I'll be turning it to a PR by the end of this week.

Challenges I faced and things I'd like assistance with 🙏

I'm surviving.

My availability for next week

I'll be here all next week.

Important items for discussion 💬

I don't think I have anything right now.

@isabela-pf

got some feedback from the accessibility call on the zoom proposal
do we need to have interviews with low-vision users? what do we want to get out of this? perhaps we need to look at what they'd expect rather than specific to JLab?
what apps would we look at to compare? - @isabela-pf  can work on a checklist, and we can "audit" different apps

@kulsoomzahra

working on the blog post for the internship

@gabalafou

showed a demo 🎉  on his testing work
will send a PR with what he has working on regression tests
then build on this to add more tests

@steff456

worked on the blog post 📝
added 6 more themes to the accessible-pygments
will move on to creating the extension with the accessible-pygments
thinking about how to calculate the contrast between two colours programmatically


Replace worker thread busy loop with condition_variable

This successfully reduces the CPU usage, but the last few runs of benchmark seems show a performance regression. Need to look into it and decide what to do.

The performance regression is due to overcommitting the number of threads without considering Docker's affinity setup. It has been fixed now.

We still have a busy wait here.
Furthermore, I'm not convinced this PR is actually solving the problem. In an ideal world, we should be notifying the CV exactly when a task completes. Currently we don't do that at all. Instead, we notify the CV when a task is removed from the queue, for some reason?
We can make use of the Task structure and have it notify us when it's complete. We can make use of two CVs so that scheduleTaskAndWaitOrError need not have a busy wait.
As is, my understanding of the PR is... we are doing busy waits less, but they are not removed entirely. I might be missing something, but there seems to be a lot of notify_all() calls, and I can't really figure out why.

Out of band: this PR doesn't fix all the busy waiting, but does fix the main ones. My comments on volatile still stand I believe.
As for the notify_all() calls, we currently make use of notify_all() whenever the task queue is modified, but we should only need to notify when something is pushed to the queue.


Fixed UPSERT in Oracle DBMS

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
IDK

Fixed issues
fixes #15708

I'm not sure whether this fix is correct. @sheillendra could you check how does the session work with this PR?

It's correct. But CUBRID and MSSQL upserts are also broken. As well as fixture SQL files for Oracle and MSSQL. I just finished PR and fixes are coming.

PR is live: #15764


[Bug]: Cart actions via traditional HTTP requests fail with 401: Unauthorized or assume Content-Type: application/json

Please confirm that you have:

[x] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[x] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Theme
Expected behavior

Clicking a link such as Remove should call /cart/change and redirect to the cart with the item removed.
Submitting a form such as <form action="{{ routes.cart_url }}" method="post"> using an <input type="submit" value="Update cart"> input should update cart quantities related to any <input type="text" name="updates[]" value="{{ item.quantity }}"> field.
Submitting same form with an <input type="submit" name="checkout" value="Checkout"> input should redirect to checkout.

Actual behavior

Clicking removal link indeed generates the request GET /cart/change?id=39899581939793:2faddffe8529a720f321d8925ac87b40&quantity=0 according to the CLI output, however it responds with 401: Unauthorized.
When submitting form using update input JSON is returned and an "application/json" Content-Type used.
When submitting form using checkout input a request to /checkout is made but fails with a 401 as well.

Verbose output
Request clicking remove link
GET /cart/change?id=39899581939793:2faddffe8529a720f321d8925ac87b40&quantity=0
2024-09-19T23:59:10.288Z: → Rendering https://mystore.myshopify.com/cart/change?_fd=0&pb=0&id=39899581939793%3A2faddffe8529a720f321d8925ac87b40&quantity=0 (with )...
2024-09-19T23:59:10.535Z: Request to https://mystore.myshopify.com/cart/change?_fd=0&pb=0&id=39899581939793%3A2faddffe8529a720f321d8925ac87b40&quantity=0 completed in 247 ms
With response headers:

content-type: text/html
server-timing: processing;dur=61, cfRequestDuration;dur=197.999954
x-request-id: f8b4ace1-d1e8-4e09-954d-1435b31424ea-1726790350

2024-09-19T23:59:10.536Z: ← 401 (request_id: f8b4ace1-d1e8-4e09-954d-1435b31424ea-1726790350)
Submit form with checkout button
GET /checkout?locale=en
2024-09-20T00:14:41.989Z: → Rendering https://mystore.myshopify.com/checkout?_fd=0&pb=0&locale=en (with )...
2024-09-20T00:14:42.215Z: Request to https://mystore.myshopify.com/checkout?_fd=0&pb=0&locale=en completed in 226 ms
With response headers:

content-type: text/html
server-timing: processing;dur=29, cfRequestDuration;dur=195.000172
x-request-id: 2ba13314-526a-4c69-9281-f08b162b18da-1726791282

2024-09-20T00:14:42.216Z: ← 401 (request_id: 2ba13314-526a-4c69-9281-f08b162b18da-1726791282)
Reproduction steps

Build a /cart page with simple HTML form, quantity inputs and removal links in accordance with the documentation at https://shopify.dev/docs/storefronts/themes/architecture/templates/cart
Try and use the cart interactions without any JS / AJAX
See that cart actions don't work as expected

Operating System
MacOS Sonoma 14.7
Shopify CLI version (check your project's package.json if you're not sure)
3.67.0
Shell
zsh
Node version (run node -v if you're not sure)
v22.7.0
What language and version are you using in your application?
Liquid, HTML, JS

I'm still having this issue on 3.67.2, is that expected?

Can we please get this reopened @frandiox? This is not fixed.

@karreiro Does this also fix calling /cart/clear as well and any other 401 errors? I'm curious because Shopify's docs still reference things like routes.cart_clear_url but clicking the link to use the cart clear API it only references /cart/clear.js with a POST. Did Shopify move to JS only endpoints and I should instead be updating our code?

@mrpunkin The fix should help with all the cart routes since it targets the /cart/... prefix.
But to be sure, can you test in your project with the nightly version that includes this patch? 0.0.0-nightly-20241003194158.

@frandiox Just installed the nightly and confirmed that my cart seems to be working as I'd expect, including actions such as /car/clear. Thank you and thanks @karreiro for your work on this.


Add RLBase dependency and use its API (as per #48)

Add RLBase dependency as per #48
Make AbstractGridWorld a subtype of AbstractEnv
Extend RLBase methods for CollectGems environment.
Modify the terminal rendering show method so that it does not get overriden by the default one given in RLBase

Could you also add methods like RLBase.get_state before merging this PR?
And adding a simple test case like run(RandomPolicy(env), env) would be much appreciated.

Sure.
For the RLBase.get_state method, should I add a trait that specifies the format of the state. For example, two of the common formats for gridworlds are:

agent grid view
flattened full grid view (with agent location and direction conatenated)

And adding a simple test case like run(RandomPolicy(env), env) would be much appreciated.

Will do.

Implementing the get_state(env) would be enough at present I think.

Codecov Report

Merging #54 into master will increase coverage by 33.02%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           master      #54       +/-   ##
===========================================
+ Coverage   30.88%   63.90%   +33.02%
===========================================
  Files          14       14
  Lines         395      399        +4
===========================================
+ Hits          122      255      +133
+ Misses        273      144      -129

Impacted Files
Coverage Δ

src/GridWorlds.jl
100.00% <ø> (ø)

src/render_in_terminal.jl
0.00% <0.00%> (ø)

src/abstract_grid_world.jl
85.00% <100.00%> (+5.00%)
:arrow_up:

src/envs/collectgems.jl
100.00% <100.00%> (+100.00%)
:arrow_up:

src/grid_world_base.jl
69.76% <0.00%> (+2.32%)
:arrow_up:

src/objects.jl
22.58% <0.00%> (+14.38%)
:arrow_up:

src/envs/doorkey.jl
94.44% <0.00%> (+94.44%)
:arrow_up:

src/envs/dynamicobstacles.jl
97.91% <0.00%> (+97.91%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46e78c...6f5d5ed. Read the comment docs.


chore(travis): add past and current NodeJS LTS

Relates to https://github.com/gulp-community/gulp-concat/pull/145

Thanks @Splaktar


Validate that a URN is set on all non-composite transforms.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java_GCP_IO_Direct PreCommit

Run Java PreCommit

The failure (e.g. NullPointerException in org.apache.beam.sdk.io.gcp.bigquery.BigQueryIOWriteTest.testWriteFileSchemaUpdateOptionAllowFieldRelaxation[3] ) look unrelated.

noting that this seems to break a bunch of Dataflow tests (they may or may not be mocking things out and that is why it happens)

When a user corrupts the graph by, say, capturing a PCollection via a closure then returning it as an output, this detects it as a non-composite. It would be nice to catch that error sooner with more context for the user.

And it instructs said users to register a URN (which does "fix" the issue... though with a corrupted graph I could see issues with the topological outward-in visitor having random problems)


Invalid character in attribute name is replaced with underscore since 1.18.1

Hello,
I wanted to update jsoup to the latest version in our service but I came across this issue. Unfortunately, for our service and use cases it means a breaking change. I don't want to go into details but we basically have some memory which returns similarity of stored strings with the new ones. With this change we will no longer get expected 100% matching when the same document is uploaded into our system again because attributes are normalized in a different way, i.e. replaced with underscore instead of stripping.
Would it be possible to make this customizable by a client to decide what should happen with illegal characters in an attribute name?
Thanks,
Tomáš

It's possible, but I don't feel it's the best approach. The HTML produced was invalid, and outside of niche applications that's not useful.
But further, jsoup will continue to evolve and the exact format of the output HTML definitely will change over time. And I don't want to go down the path of adding complicated configuration to unwind every different change. The complexity of managing and testing all of that is unfeasible.
As an alternate approach, my suggestion would be that you store both the original input HTML and the jsoup produced HTML. When jsoup updates, reprocess the backlog using the original and store the new output. (And / or compare using the original input directly.)


Refactor Subpaving to hold data in one memory space

Should the subpaving hold only tiles? Maybe the zones should be in a separate data structure?


Refactor testcase for config action

Add testcase to test config action in interactive
and stdout mode
Move integration test into it's own folder
Add fixtures folder

recheck

Slower integration test run issue tracked via https://github.com/ansible/ansible-navigator/issues/127


Pagination proposal - namespaces

we will add the aliasType filter and see how it performs since it is not indexed

minor: i'd rename the following to singular second arg:
/namespaces/account/names
/namespaces/mosaic/names

⚠  also on those endpoints, and not so minor, they don't have any params defined to input the list of accounts/mosaics
also just like in the mosaics proposal i don't like much how this endpoint is designed (requesting a bunch of resolutions at once and returning a mixed bag of results), but i won't get into the same spiral here plus in this case it is probably more generic (it is probably more common to request various name resolutions than various mosaic listings per different accounts)

same as in the mosaics proposal
/account/namespaces is being dropped in favour of nothing, will take whatever outcome from that proposal and apply it here (if in the end we add a new endpoint it will need adding)

e the following to singular second arg:

Updated

/account/namespaces is being dropped in favour of nothing, will take whatever outcome from that proposal and apply it here (if in the end we add a new endpoint it will need adding)

In favor of ownerAddress query param.

/account/namespaces is being dropped in favour of nothing, will take whatever outcome from that proposal and apply it here (if in the end we add a new endpoint it will need adding)

In favor of ownerAddress query param.

sorry i meant the POST version of this with multiple addresses, after all, the mosaics version was made after this one ^^

Updated branch to match latest master

@Vektrat well seen, added a new request body that only accepts addresses.


Is it possible to get name of the latest downloaded file?

Hi @gauravgandhi1315 I don't think so easily. Some ideas you can try is to see if you can get the name of the file before you download, from some web element. Or you can try to download at some location and use JavaScript code to find the latest file. For JavaScript code you can use js step - https://tagui.readthedocs.io/en/latest/reference.html#js


Resolve warnings on aarch64

The following warnings are generated in Clang when compiling with an aarch64 cross-file:
12:22:27 {pj/demo} libc$ make
[35/532] Compiling C object 'src/e88f707<EMAIL_ADDRESS>../printf/printf.c:493:28: warning: shift count >= width of type [-Wshift-count-overflow]
  int exp2 = (int)((conv.U >> 52U) & 0x07FFU) - 1023;           // effectively log2
                           ^  ~~~
../printf/printf.c:501:36: warning: shift count >= width of type [-Wshift-count-overflow]
  conv.U = (uint64_t)(exp2 + 1023) << 52U;
                                   ^  ~~~
2 warnings generated.
[100/532] Compiling C object 'src/e88f707<EMAIL_ADDRESS>../src/stdlib/strtol.c:158:44: warning: implicit conversion from 'long long' to 'unsigned long' changes value from<PHONE_NUMBER>854775807 to<PHONE_NUMBER> [-Wconstant-conversion]
        cutoff = neg ? -(unsigned long)LONG_MIN : LONG_MAX;
               ~                                  ^~~~~~~~
../arch/aarch64/include/_limits.h:5:18: note: expanded from macro 'LONG_MAX'
#define LONG_MAX 0x7fffffffffffffffL
                 ^~~~~~~~~~~~~~~~~~~
1 warning generated.
[102/532] Compiling C object 'src/e88f707<EMAIL_ADDRESS>../src/stdlib/strtoul.c:126:26: warning: overflow in expression; result is -2 with type 'long long' [-Winteger-overflow]
        cutoff = (unsigned long)ULONG_MAX / (unsigned long)base;
                                ^
../include/limits.h:61:24: note: expanded from macro 'ULONG_MAX'
#define ULONG_MAX (2UL * LONG_MAX + 1)
                       ^
../src/stdlib/strtoul.c:127:32: warning: overflow in expression; result is -2 with type 'long long' [-Winteger-overflow]
        cutlim = (int)((unsigned long)ULONG_MAX % (unsigned long)base);
                                      ^
../include/limits.h:61:24: note: expanded from macro 'ULONG_MAX'
#define ULONG_MAX (2UL * LONG_MAX + 1)
                       ^
../src/stdlib/strtoul.c:161:9: warning: overflow in expression; result is -2 with type 'long long' [-Winteger-overflow]
                acc = ULONG_MAX;
                      ^
../include/limits.h:61:24: note: expanded from macro 'ULONG_MAX'
#define ULONG_MAX (2UL * LONG_MAX + 1)
                       ^
3 warnings generated.
[127/532] Compiling C object 'src/e88f707<EMAIL_ADDRESS>../src/string/strlen.c:58:37: warning: implicit conversion from 'long long' to 'unsigned long' changes value from<PHONE_NUMBER>8076673 to 16843009 [-Wconstant-conversion]
static const unsigned long mask01 = 0x0101010101010101;
                           ~~~~~~   ^~~~~~~~~~~~~~~~~~
../src/string/strlen.c:59:37: warning: implicit conversion from 'unsigned long long' to 'unsigned long' changes value from<PHONE_NUMBER>273814144 to<PHONE_NUMBER> [-Wconstant-conversion]
static const unsigned long mask80 = 0x8080808080808080;
                           ~~~~~~   ^~~~~~~~~~~~~~~~~~
2 warnings generated.
[396/532] Compiling C object 'src/e88f707<EMAIL_ADDRESS>../src/stdlib/strtol.c:158:44: warning: implicit conversion from 'long long' to 'unsigned long' changes value from<PHONE_NUMBER>854775807 to<PHONE_NUMBER> [-Wconstant-conversion]
        cutoff = neg ? -(unsigned long)LONG_MIN : LONG_MAX;
               ~                                  ^~~~~~~~
../arch/aarch64/include/_limits.h:5:18: note: expanded from macro 'LONG_MAX'
#define LONG_MAX 0x7fffffffffffffffL
                 ^~~~~~~~~~~~~~~~~~~
1 warning generated.
[397/532] Compiling C object 'src/e88f707<EMAIL_ADDRESS>../src/stdlib/strtoul.c:126:26: warning: overflow in expression; result is -2 with type 'long long' [-Winteger-overflow]
        cutoff = (unsigned long)ULONG_MAX / (unsigned long)base;
                                ^
../include/limits.h:61:24: note: expanded from macro 'ULONG_MAX'
#define ULONG_MAX (2UL * LONG_MAX + 1)
                       ^
../src/stdlib/strtoul.c:127:32: warning: overflow in expression; result is -2 with type 'long long' [-Winteger-overflow]
        cutlim = (int)((unsigned long)ULONG_MAX % (unsigned long)base);
                                      ^
../include/limits.h:61:24: note: expanded from macro 'ULONG_MAX'
#define ULONG_MAX (2UL * LONG_MAX + 1)
                       ^
../src/stdlib/strtoul.c:161:9: warning: overflow in expression; result is -2 with type 'long long' [-Winteger-overflow]
                acc = ULONG_MAX;
                      ^
../include/limits.h:61:24: note: expanded from macro 'ULONG_MAX'
#define ULONG_MAX (2UL * LONG_MAX + 1)
                       ^
3 warnings generated.
[423/532] Compiling C object 'src/e88f707<EMAIL_ADDRESS>../src/string/strlen.c:58:37: warning: implicit conversion from 'long long' to 'unsigned long' changes value from<PHONE_NUMBER>8076673 to 16843009 [-Wconstant-conversion]
static const unsigned long mask01 = 0x0101010101010101;
                           ~~~~~~   ^~~~~~~~~~~~~~~~~~
../src/string/strlen.c:59:37: warning: implicit conversion from 'unsigned long long' to 'unsigned long' changes value from<PHONE_NUMBER>273814144 to<PHONE_NUMBER> [-Wconstant-conversion]
static const unsigned long mask80 = 0x8080808080808080;
                           ~~~~~~   ^~~~~~~~~~~~~~~~~~
2 warnings generated.

Well, this libc uses mpaland/printf; these warnings, along with many actual bugs and even a case of undefined behavior, are all resolved in the unified fork I've been working on. See also issue #159 where I suggested adopting it.

Just noting for my future self: the first warning is printf, but the rest are problems within libc for aarch64

BTW, I was mostly compiling against GCC; I used clang just now and there was another (different) warning which I've made go away.

Resolved all of these.


Version 1.4.0 not available on pypi

Is 1.4.0 planned to be released soon, Django 1.10 was released on August, 1st and the current version 1.3.0 is not compatible.

I'll push it out today.

hopefully 'today' is today :)

@emperorcezar can you do this push to pypi? All of my apps are on Django 1.10+ and I can't install without using pip+git.

@jordanambra @dodobas Today became later than I thought mostly because pypi giving my issues, but it's out as of now.

Thank you!


Request for correct terminal commands to reproduce similar text examples from paper.

Hello again.
Still have issue trying to generate similar output comparable to your interesting example.
Ubuntu 18.04 using default 'unilmv1-large-cased.bin' from github link with following commands:
python3 decode_seq2seq.py --bert_model bert-large-cased --model_recover_path storage/unilmv1-large-cased.bin --new_segment_ids --mode l2r --input_file test.txt --max_seq_length 256 --max_tgt_length 128 --batch_size 16 --forbid_duplicate_ngrams --temperature 1.0 --length_penalty 0 --min_len 500 --top_k 40 --output_file test_unilm_mode-l2r-topk-min_length500.txt
test.txt is single line from paper:
Winston sat back. A sense of complete helplessness had descended upon him.
Result:
“ We ’ re going to be in the world ! ” He began to recount what he had learned . “ The world is a wreck , but here you stand in it , there are so many people who will not know it .    “ I mean , I have never taught you to learn the hard way , but if I
I've followed your instructions but can't find an option to "... sample the distribution using the masked-LM way."
Also, cannot find option to increase length of output comparable to your sample. --min_len 500 has no effect.
I assume I'm missing options in the above terminal commands?
Would appreciate if you could provide the missing options.
Cheers

Would also be interested in Above


bug(Mat-vertical-Stepper + Mat-Tabs): Combination of Mat-tabs and Vertical stepper BUG

Reproduction
Steps to reproduce:

https://github.com/SK-Commit/angular-stepper-tabs-bug
Clone
NPM Install + NPM start
Go to localhost:4200
Go to next tab on page
Go back to first tab

Expected Behavior
What behavior were you expecting to see?
First tab, only ONE step in Mat-vertical-stepper is open. When navigating to new tab and back i expect, only that the ONE step i still open.
Actual Behavior
What behavior did you actually see?
https://github.com/angular/components/issues/10965
When navigating back to first tab with Mat-Vertical-Stepper, all steps are open, and behaviour is broken.
Note: The project is generated through the generator: "NGX-Rocket".
I still get the bug, after deleting node_modules, package-lock.json, and updating package.json to newest angular versions of all packages in a fresh project, then NPM install.
"@angular/animations": "9.1.11",
"@angular/common": "9.1.11",
"@angular/compiler": "9.1.11",
"@angular/core": "9.1.11",
"@angular/forms": "9.1.11",
"@angular/platform-browser": "9.1.11",
"@angular/platform-browser-dynamic": "9.1.11",
"@angular/router": "9.1.11",
"@angular/service-worker": "9.1.11",
"@angular/cdk": "9.2.4",
"@angular/material": "9.2.4",
"@angular/flex-layout": "^9.0.0-beta.31",
Environment

Angular: 9.1.11
CDK/Material: 9.2.4
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): WIndows

You can do two things to workaround this issue, which is unfortunately due to how Angular renders dynamic views.

Use lazy-loading tab content

<mat-tab-group>
  <mat-tab label="Planning">
    <ng-template matTabContent>
      <mat-vertical-stepper>
      ...
      </mat-vertical-stepper>
    </ng-template>
  </mat-tab>

That will keep the stepper from bugging out when it you transition back to it.

Store where the user is in their steps. The stepper will be re-initialized when you come back to it, so whatever data it should initialize with should be stored by the app. This includes any data the user has entered and the current step you are on


Add retries for get cluster credentials API call and remove unused variables

…riables
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I see that retries is always set to 10. Do we want to make the number of retries configurable to the end user? To me retries are super valuable when there is operational or connection error that can be solved by simply retrying, but sometimes we also want it to fail fast and fail early, such as when the user configuration is wrong.

@karle-nishi resolved the merge conflicts.
@jiezhen-chen - I was thinking that we could keep it at 10 for now and then pivot if there is a need for customization. i.e. I'm not completely sure this needs to even be exposed to the outside world.


fix: addmod

Pull Request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: Closes #83
What is the new behavior?

Fixes ADDMOD behavior

Does this introduce a breaking change?

[ ] Yes
[x] No

Added changes to CHANGELOG.md

[x] Yes
[ ] No

Other information

ADDMOD
I tried two different implementations for this ADDMOD opcode, leveraging the fact that (x + y) mod N <=> (x mod N) + (y mod N) mod N
The first try was using u256_wide_add, a function that I created that adds two u256s and returns a u512 to avoid overflowing on the a+b addition, and then dividing it by N and returning the remainder.

    fn exec_addmod(ref self: ExecutionContext) {
        let popped = self.stack.pop_n(3);

        let n: u256 = *popped[2];
        let mut result = 0;
        if n != 0 {
            let add_res = u256_wide_add(*popped[0], *popped[1]);
            let (_, r) = u512_safe_div_rem_by_u256(add_res, n.try_into().unwrap());
            result = r;
        }

        self.stack.push(result);
    }

fn u256_wide_add(a: u256, b: u256) -> u512 {
    let (sum, overflow) = u256_overflowing_add(a, b);

    let limb0 = sum.low;
    let limb1 = sum.high;

    let limb2 = if overflow {
        1
    } else {
        0
    };

    let limb3 = 0;

    u512 { limb0, limb1, limb2, limb3 }
}

Here is the test output
❯ scarb test -f test_exec_addmod_overflow
Running tests for package: kakarot
testing kakarot ...
running 1 tests
[DEBUG]	                               	(raw: 0x3b72c

test kakarot::tests::test_instructions::test_stop_and_arithmetic_operations::test_exec_addmod_overflow ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 78 filtered out;

The other implementation is
    fn exec_addmod(ref self: ExecutionContext) {
        let popped = self.stack.pop_n(3);

        let n: u256 = *popped[2];
        let mut result = 0;
        if n != 0 {
            // (x + y) mod N <=> (x mod N) + (y mod N) mod N
            result = (*popped[0] % n) + (*popped[1] % n) % n;
        }
        self.stack.push(result);
    }

Here is the test output
❯ scarb test -f test_exec_addmod_overflow
Running tests for package: kakarot
testing kakarot ...
running 1 tests
[DEBUG]	                               	(raw: 0x3d5b8

test kakarot::tests::test_instructions::test_stop_and_arithmetic_operations::test_exec_addmod_overflow ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 78 filtered out;

This second version is ~3% more costly. Therefore, we will keep the first one with u256_wide_add.

smol conflicts


[Docs]: Google page for howto components has no links to this repo

When searching "howto-components webcompnents" you will land here: https://developers.google.com/web/fundamentals/architecture/building-components/examples/
There are no links to this repo to see code, contribute, view issues etc.

That’s somewhat intentional – at least for now. The section on WebFundamentals is supposed to be a stand-alone documentation that can be read.
The elements the are in the examples section have their code embedded and explained in the corresponding article.

@surma I understand that. However, developers are quite used to seeing links to repos, and certain things like #112 can only be found by searching issues, for example.

UPD: I realised another reason to have a link to repo: to see the code as-is, not in "literate style", because it's quite confusing, see #118


Dagster

https://github.com/dagster-io/dagster

fixed by https://github.com/meirwah/awesome-workflow-engines/pull/70


Clashing Shortcuts

Godot 3.2.alpha1
Windows 10
Setting the "Toggle Comment" shortcut to "Control+B" does not allow using the key combination to toggle a comment.
Removing "Control+B" as the shortcut for "Go to Next Bookmark" fixes the issue.
The clash is not obvious.
Removing all the current matching shortcuts once a new one is entered in the same group with a warning that they were removed sounds like a needed patch.

Is this still relevant in master?

Can confirm in master, it doesn't show any warnings.


Extension | WebApp - Update email support

Describe the task
Update email support to<EMAIL_ADDRESS>when user use feature:

Contact support
Request a feature

Extension
Version test: http://<IP_ADDRESS>:8900/s/EDkF7xEHcto9iMp
Validation passed

WebApp
Version test: https://cd7dbe04.subwallet-webapp.pages.dev/
Validation passed


dom-repeat property bindings fall out of sync

Example markup:
<template id="my-template" is="dom-repeat" items="{{catalog.tabs}}" as="tab" index-as="tabIndex">
    {{tab.label}}
    {{tab.itemCount}}
</template>

Example JS:
this.catalog.tabs[0].tabCount = 123;
this.set('catalog.tabs', this.catalog.tabs); // Doesn't work
this.$['my-template'].render(); // Doesn't work

Inspecting the data on the template by using document.querySelector('* /deep/ #my-template")
The _instances[0].__data__ property reveals that the tabCount property is populated on the tab object, yet the tab.itemCount binding doesn't work. See the screenshot where the itemCount value is now out of sync.

After digging into the internals and trying everything, the only working solution is pretty messy:
var tabs = this.catalog.tabs;
this.set('catalog.tabs', null);
this.async(function() {
    this.set('catalog.tabs', tabs);
});

I would imagine this is a pretty critical bug. Note: This worked flawlessly in 0.5. The version I'm on now is 1.1.0.

This is currently by design.  You will need to use this.set('catalog.tabs.0.tabCount', 123); to properly notify the dom-repeat.
We have a task to improve this but as it's a breaking change it wouldn't land until the next major release of Polymer: https://github.com/Polymer/polymer/issues/3343

Thanks for the info! :+1:


Latest v16 failed to build

https://launchpad.net/~openjs/node-snap/+snap/node16
Launchpad container problems by the look of the logs. I've requested a rebuild and 🤞 but am heading off for the day. This issue is a reminder to follow up (someone else who has access could do so too, and if they get green builds then this issue can be closed).

Everything looks green so closing.


[INTEL MKL] scatter optimizations.

Parallelizing scatter update op.

@penpornk made all the changes requested except defaulting to Serial Execute for google internal runs. Will wait for your comments for that.

Hi @penpornk Thanks for the response. I have wrapped the code around ifdef

@penpornk gentle reminder to review the latest change

Hi @penpornk made the changes. Kindly review.

HI @penpornk Just checking on the status of this PR

Seems auto-merge is not happening but the changes are now committed so we can close this. Thank you for the PR.


Fix issue of assigning design to workspace

Notes for Reviewers
This PR fixes #10773
A new prop was added recently to evaluate permissions in transferlist. Since assigning design to workspace is not having any keys currently so by default transferlist here needed to be by default have the permissions as true which was not passed earlier.
Signed commits

[ ] Yes, I signed my commits.

@sudhanshutech I have approved the changes but I don't seem to have merging rights.


adding dragMove callback in order to scroll containers

Hey guys here is a change to expose a callback in order to scroll containers, let me know if you have some issue with it.

Hi,
I am still facing issues with the auto scroll when the container has fixed height.
Is there something i am missing here ?
Thanks,
Vamsi

LGTM.


Look into North Dakota Covid-19 values

This also looks suspicious...

May be unrelated though since its unknowns... i'll file its own bug: https://github.com/SatcherInstitute/health-equity-tracker/issues/606

Confirmed that the issue is that when we calculate the total population for a given geo in the SQL aggregation logic, we sum up the populations for all of the race/ethnicities within that geo. As North Dakota only reports case data for American Indian and Asian, the denominator in our per 100k calculation is the sum of the populations of only those two groups in North Dakota

For my own reference, listing out two options to fix this problem:

Compute and add the "Total" rows to the CDC restricted dataset before aggregation (i.e. while running the local script to process the raw data). The same would need to be done for the ACS population age/gender datasets, as they currently compute total rows on the FE rather than the BE. Then, when we join with ACS population in the aggregation SQL, the current join will set the correct population values for the total rows in the CDC data. This is the way to go longer term IMO, and would likely take a day or two to implement.
Fix the issue in the aggregation SQL step itself by joining with the ACS race datasets and pulling the total populations for each geo. This would be quick to implement but is a bit hacky, and adds to rather than simplifies the SQL step.

As I want to get the fix for this in before the data bug bash tomorrow, I will implement the second option listed in my previous comment, and do things the proper way after the bug bash.

Keeping open to fix this the proper way later this week

Aaron added new totals to ACS pop in this PR: https://github.com/SatcherInstitute/health-equity-tracker/pull/725


NIFI-5921: Added property to allow a user to define a timeout on the ConsumeJMS …

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Thanks @pvillard31 - Agreed the changes.

Changes LGTM, merged to master, thanks @rwhittington

@rwhittington - I realized, a bit late, that the default you initially set was the correct one (based on the code in AbstractJMSProcessor) - missed that during the initial review... Anyway... trying to fix my mistake in #3245 - could you have a look?


Drop duplicated dependencies from pom.xml

This PR addresses #362.
It pulls the latest config which contain a fix.
The library version is bumped to 2.0.0-SNAPSHOT.91 in order to match the version of base.

@armiol Please take a look.


Fix yaml of template copy_data_from_staging_to_aws.yaml.erb

We have edited the layout of the YAML file.

Pair: @schmie @suthagarht

We can see what you have done from the code, the commit message should explain why you have done this.


Shallow policy network

Data

What shape are the input tensors?
What features do the input tensors encode?

Architecture

How many hidden layers?
How big should each hidden layer be?

The architecture is hidden in the main text. It looks like  they simply have a linear weighting of the features evaluated at each position:

We also trained a faster but less accurate rollout policy pπ(a|s), using a linear softmax of small pattern features
(Silver et al. page 2)

The real difficulty here is in implementing the features.

This linear regression with softmax could be implemented as a single convolutional layer with 1x1 kernel size
To-be-benchmarked… but I worry that one-hot encodings of vectors of the order of 10000 dimensions will be a big efficiency bottleneck. Since these features will be dot-product’d with a vector of weights, the one-hot element is essentially acting a look-up into that weight vector. In other words,  dot([a b c d e],  [0 0 0 1 0]) is just d
So (if it turns out to be a big speedup) we should consider trying to implement this as a ‘lookup’ of the nth weight rather than as convolutional features

Redundant with #48


Add negation to Filters

The idea is that Pool Filters should be able to reject an Entity if it has a given Component.
I already have this working in a00ee08

Hi Pablo, I've been enjoying this feature. Can I ask why you haven't made a pull request into the main Concord repo with this?

This feature exists in the dev branch and also in the experimental branch.
Right now I want people to test and try to find bugs in the experimental branch so that I can confirm that the code is proof tested, and ready to be merged into dev. Once that's ready I would love to have up to date documentation, and once we have that, then it can move into master and 4.0 can be released.
Right now dev is usable, without major bugs or errors, just lacking up-to-date documentation. While experimental can have bugs or errors and lacks far more documentation.


[SPARK-12717][PYTHON][BRANCH-2.1] Adding thread-safe broadcast pickle registry

What changes were proposed in this pull request?
When using PySpark broadcast variables in a multi-threaded environment,  SparkContext._pickled_broadcast_vars becomes a shared resource.  A race condition can occur when broadcast variables that are pickled from one thread get added to the shared  _pickled_broadcast_vars and become part of the python command from another thread.  This PR introduces a thread-safe pickled registry using thread local storage so that when python command is pickled (causing the broadcast variable to be pickled and added to the registry) each thread will have their own view of the pickle registry to retrieve and clear the broadcast variables used.
How was this patch tested?
Added a unit test that causes this race condition using another thread.

backport for 2.1

LGTM if it passes the tests.

Since it seemed like some users in the JIRA might be using 2.1, I made this PR too.  I think this is pretty low risk also, and it went in without any conflicts.  But up to you if you're ok with this one also, as long as tests pass.

Test build #80181 has started for PR 18825 at commit cc239a4.

Test build #80181 has finished for PR 18825 at commit cc239a4.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class BroadcastPickleRegistry(threading.local):

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80181/
Test PASSed.

Merged build finished. Test PASSed.

Merged into branch-2.1.


test: baseweb integration

What kind of change does this PR introduce?
Bug fix: correctly render _app in server context when useDocument=true
What is the current behaviour?
You can also link to an open issue here.
What is the new behaviour?
...
Does this PR introduce a breaking change?
What changes might users need to make in their application due to this PR?
Other information:
Please check if the PR fulfills these requirements:

[ ] Tests for the changes have been added
[ ] Docs have been added / updated

@toomuchdesign I've prepared a test case where stuff seems to break internally. After short investigation it seems that client version of custom _app is not loaded correctly; resolves to {} and DefaultApp is used. I'm not entirely sure why this happens though, any ideas?
In some cases this might happen if there is a circular dependency on the imported module but I don't see that being the case here.

Coverage remained the same at 100.0% when pulling fbd783bd4005fa37106f274fcfad92d7fdafb5a8 on baseweb-integration-test into fbd072ae40618277cb09915c94cc5f5ff4a1a053 on master.

@toomuchdesign got this to work 🙂 Let me know what you think.

@toomuchdesign I'm not entirely convinced if we should merge this and insisting with the current "approach" or try to investigate the "hydration" alternative.

From the maintainer perspective, I'd be generally inclined to publish something which has (documented) limitations and does what it does as right as possible.
I'm afraid that introducing a deviation from the expected behaviour to support a specific user-scenario might make harder documenting this and further development.
I don't know f it's the case, but in general I'd prefer to ask users to mock 1 dependency on their side instead of introducing a possible layer of complexity and failure here. This even more vital considered the limited resources we have as maintainers.
Btw, I'll take some time to better focus the issue and land a hand if I'm able to. Maybe there are different approaches that could work. Let's see. 🚀  ☃

I'd like to give the SSR render + client side hydration approach a try. When I have time I'll try to open an explorative PR. I'd try to not focus on DX and keep tests as much untouched as possible. So that we can have an idea of the possible blockers.
In the meanwhile we could release what we have in master. How do you see it?

Agree, lets release 🚀


<EMAIL_ADDRESS>decompress error

Hi @contechcreatives,
This looks like a duplicate issue. Can you please try running this cmd in Powershell ran as an admin ?


Suggestion

i didnt know where i could put a suggestion.
could you add a feature to convert the combat xp drop to the amount of damage the hit is going to deal?

I'm not sure if that would be allowed by jagex and runelite, i don't think so. Another thing to consider is that quite a few npcs in osrs have xp multipliers making it hard to predict what the hit will be based off a xp drop. Then there's also the problem of xp being floatimg point number on the server but the client only receives floored integers leading to hit predictions off by 1 in some cases.

If your only concern is the legality of this feature then let me tell you that calculating damage from the xp drop and displaying it is extremely unlikely to be against the rules. It's not mentioned in the most up to date disallowed 3rd party features blog and RuneLite has merged this plugin into the hub which is the same as this feature request but standalone (and incompatible): https://runelite.net/plugin-hub/show/instant-damage-calculator
I think some inaccuracy is not that big of a deal personally as the feature is really quite useful.

I see. I don't have motivation to make this as of right now but I will keep this in mind.

https://github.com/runelite/plugin-hub/pull/2300 implemented in v1.3


Don't discard currently registered dbg_callback

Fixes https://github.com/elixir-lang/elixir/issues/12687#issuecomment-1820525658.

We have a test, so it needs to be changed too :)

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


Add Nupur Thakur in Contributors List

Signed-off-by: nupur-thakur<EMAIL_ADDRESS>

Thanks, @anandrkskd @jesuslerma 👍


Fix #266 - fix cell and column width computation

In #237, I changed a Map<Integer, Map<Integer, Integer>> with a SparseArray<SparseIntArray>, as suggested by Android Studio.
However, when retrieving an nonexistent value from a SparseIntArray, it returns 0 by default, instead of -1, as expected by CellLayoutManager#getCacheWidth(int, int).
I updated that so it now returns -1 when retrieving a missing value.

Did you have a chance to look at this @evrencoskun?

@MGaetan89 Yes, I've checked and It seems It works now as expected.


11.0 website multi company add rule for registered users

First commit is the same as https://github.com/it-projects-llc/website-addons/pull/433/commits/69c35ad4b16cc7742d9a67c849a0382f51fde34b from https://github.com/it-projects-llc/website-addons/pull/433/ but adds new entry in changelog, instead of editing existing one.
PR is draft, 'cos test_website_price_difference_is_accessible_for_demo_user fails, but it is copy of existing test from https://github.com/it-projects-llc/website-addons/pull/433/

I approve to merge it now


ORC-1174: Add Ubuntu 22.04 to GitHub Action

What changes were proposed in this pull request?
This PR aims to add Ubuntu 22.04 to GitHub Action.
Why are the changes needed?
This will help the verification on the latest release.
Since GitHub Action Virtual Environments don't support Ubuntu 22.04 officially yet, this PR uses a workaround.
runs-on: ubuntu-latest
container:
  image: ubuntu:22.04

How was this patch tested?
Pass the GitHub Action on this PR.

Oh, it seems that they started Public Beta.
This PR is superseded by #1121