Update jsoniter-scala-core, ... to 2.13.19

Updates

com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-core
com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-macros

from 2.13.10 to 2.13.19.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.plokhotnyuk.jsoniter-scala" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequest = { frequency = "@monthly" },
  dependency = { groupId = "com.github.plokhotnyuk.jsoniter-scala" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #417.


fix: primary_message typo in errors.rs

Benchmark results
Metrics with a significant change:

node_history_sync_time_in_ms (10): 32,489 (+25%)
note_history_trial_decrypting_time_in_ms (10): 210 (+131%)
note_trial_decrypting_time_in_ms (64): 83.4 (+137%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 633a711f and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
676
676
676

l1_rollup_calldata_gas
6,424
6,424
6,412

l1_rollup_execution_gas
585,757
585,757
585,745

l2_block_processing_time_in_ms
1,258 (-5%)
4,596 (-4%)
8,941 (-4%)

note_successful_decrypting_time_in_ms
229 (-9%)
619 (+1%)
967 (-5%)

note_trial_decrypting_time_in_ms
28.4 (-44%)
27.9 (+30%)
:warning: 83.4 (+137%)

l2_block_building_time_in_ms
11,365 (-3%)
41,354 (-3%)
81,110 (-4%)

l2_block_rollup_simulation_time_in_ms
11,333 (-3%)
41,240 (-3%)
80,900 (-4%)

l2_block_public_tx_process_time_in_ms
5,902 (-3%)
23,204 (-3%)
46,472 (-4%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
14,395 (-2%)
:warning: 32,489 (+25%)

note_history_successful_decrypting_time_in_ms
1,263 (-1%)
2,388 (+2%)

note_history_trial_decrypting_time_in_ms
98.3 (+61%)
:warning: 210 (+131%)

node_database_size_in_bytes
18,653,264
35,012,688

pxe_database_size_in_bytes
29,859
59,414

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
180 (+2%)
44,377
26,164

private-kernel-ordering
160 (+2%)
50,830
39,026

base-parity
3,896 (+1%)
128
311

root-parity
1,021 (-2%)
1,244
311

base-rollup
13,854 (-1%)
110,464
861

root-rollup
49.4 (+1%)
4,359
725

private-kernel-inner
218 (+3%)
71,744
26,164

public-kernel-app-logic
120 (+2%)
47,695
40,661

public-kernel-tail
163 (+1%)
53,372
7,125

merge-rollup
9.05 (-1%)
2,568
861

public-kernel-teardown
120 (+3%)
47,695
40,661

public-kernel-setup
119 (+3%)
47,695
40,661

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.2 (+3%)
16.2 (+3%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.6
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.594 (+3%)
0.501 (+3%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
45.5 (+1%)
71.1
222 (-4%)
490 (+14%)
840 (-3%)
1,670 (-3%)
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
96.0
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.467 (+1%)
0.439
0.405 (-4%)
0.459 (+14%)
0.400 (-3%)
0.400 (-3%)
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
54.2 (+2%)
104 (-1%)
324 (-3%)
727 (+14%)
1,266 (-3%)
2,527 (-3%)
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
105
207
691
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.480 (+2%)
0.471 (-1%)
0.441 (-3%)
0.501 (+14%)
0.439 (-3%)
0.440 (-3%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
64.2 (+8%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
109

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.561 (+7%)

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
40,372
496,534

Transaction size based on fee payment method

Metric
native fee payment method
fpc_public fee payment method
fpc_private fee payment method

tx_with_fee_size_in_bytes
905
1,161
1,377

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
1,686
1,075 (+2%)
5,431 (+1%)

Metric
1 public data writes
2 public data writes
3 public data writes
4 public data writes
5 public data writes
8 public data writes

tx_sequencer_processing_time_ms
572 (+2%)
402 (+2%)
1,082 (+2%)
525 (+1%)
1,759 (+1%)
589 (+1%)


Mention System.CommandLine somewhere

This page should mention the System.CommandLine library, as most people will need command-line argument parsing at some point (there's only so far you can go with a string array)
https://github.com/dotnet/command-line-api

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06ef4bd7-7012-8afd-721a-a4c31db20202
Version Independent ID: d942d65a-87e4-1525-bd94-b005f1b7cbac
Content: Main() and command-line arguments
Content Source: docs/csharp/fundamentals/program-structure/main-command-line.md
Product: dotnet-csharp
Technology: csharp-fundamentals
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

I like this idea @Daniel15
I've added it to the backlog.
/cc @jonsequitur @KathleenDollard


Ideas for arbitrary video testing of MOT/MOTS

Hi, I've looked at #8 and #12 as well as the codebase and I'm trying to come up with a script that can run the UNINEXT models on the MOT/MOTS task on any arbitrary video as input.
It looks like the main constraint is that I will have to make a custom evaluator and dataloader for something like this.
Any ideas on how to approach this or  any alternative approaches?
Mainly, it looks like the data loader currently uses the DatasetCatalog but we should use something else?

I see that there is a UNINEXTPredictor but it seems to work only for object level tasks. I am looking into extending it for video level tasks by looking at uninext_vid but any help in terms of approaches is appreciated!


Integrate Welcome and Greeting Bot

Hi @djm-1
I would like to contribute to this amazing project
I can add a config file and integrate the bot so that whenever a new user opens a issue or pr , the bot will comment and greet the user with a proper message
Let me know if you are interested
Kindly do assign me
Kindly do add the DWOC and Level label

this is how it will look like
Similarly this bot will comment when a user opens a pr and when a pr gets merged for the first time
Kindly let me know if you are interested , this is a feature update and it would be great thing
Kindly assign me and also I expect to get a bigger level label for this

this is how it will look like
Similarly this bot will comment when a user opens a pr and when a pr gets merged for the first time
Kindly let me know if you are interested , this is a feature update and it would be great thing
Kindly assign me and also I expect to get a bigger level label for this


add logging for instance and import completions

What
Add logs on successful completion of instance and job imports
How to review

Make sure logs are clear and contain the necessary information

Who can review
anyone

After the last message is processed, we still need to commit the message that we are handling, we have these scenarios:
For an intermediate message we do:

start Kafka message processing
post dimensions for the dimension
check if it's last dimension and instance (it's not)
commit message (end Kafka message processing)

For the last message we do:

start Kafka message processing
post dimensions for the dimension
check if it's last dimension and instance (it is)
set instance to edition-confirmed and send Kafka message to CSV service
set import job to complete
commit message (end Kafka message processing)


Cant execute

https://i.gyazo.com/fdbe2cf6d752967dc5ef537cb9424b24.png
This is the error that I get.

Hey @Arthurdw, you have to put the file on your desktop then do cd C:/Users/Gebruiker/Desktop. Then do node bot.js once you are there.


issue when runnig test_vit.sh

Hello , after preparing the JSON file for my own dataset according to the instructions, is that a need to modify the data_base.py（
img_size=(540, 960),
focal_length=1196.0,
）to my camera，and the resolution must over 616,1024?

Hello , after preparing the JSON file for my own dataset according to the instructions, is that a need to modify the data_base.py（ img_size=(540, 960), focal_length=1196.0, ）to my camera，and the resolution must over 616,1024?

Not necessarily. We usually rewrite data_basic in the training config files to override it:
https://github.com/YvanYin/Metric3D/blob/277c3a1311da2d69816600f8e09c7b292146843b/training/mono/configs/RAFTDecoder/vit.raft5.giant2.nyu.py#L41-L51


SageMath 8.4 returns, in notebook interface, "Error typesetting mathematics" when one attempts to plot with Matplotlib

Issue description
On NixOS 18.09, with SageMath 8.4, Matplotlib 2.2.3 (Python 2.7 version, in case you think I installed the wrong Matplotlib version) and Texlive 2018 (XeTex 3.0) I receive this error:

Why did I install Texlive and mention it? Because I thought given the error it might be needed, so I installed it and re-tried, receiving this same error. If you want the code (so you can test it yourself) and don't want to have to manually copy it from the shown screenshot here it is:
x,y,z=var('x,y,z')
# Next we define the parameters
sigma=10
rho=28
beta=8/3

# The Lorenz equations
lorenz=[sigma*(y-x),x*(rho-z)-y,x*y-beta*z]

# Time and initial conditions
N=250000
tmax=250
h=tmax/N
t=srange(0,tmax+h,h)
ics=[0,1,1]
sol=desolve_odeint(lorenz,ics,t,[x,y,z],rtol=1e-13,atol=1e-14)
X=sol[:,0]
Y=sol[:,1]
Z=sol[:,2]

# Plot the result
from mpl_toolkits.mplot3d import axes3d
from matplotlib import pyplot as plt

# Call the plot function if you want to plot the data
fig = plt.figure(num=None, figsize=(16, 12), dpi=120, facecolor='w', edgecolor='k')
ax = fig.gca(projection='3d')
ax.plot(X, Y, Z, lw=0.5)
ax.set_xlabel("X Axis")
ax.set_ylabel("Y Axis")
ax.set_zlabel("Z Axis")
ax.set_title("Lorenz Attractor")

plt.show()

Notebook was started by starting SageMath with sage and then at the sage> prompt I ran notebook().
All I saw at the sage> prompt, error-wise related to the fact xdg-open didn't seem to be working as it couldn't figure out how to open the notebook in my browser, I had to manually do it myself.
Steps to reproduce
Install NixOS 18.09, with this config file: https://github.com/fusion809/NixOS-configs/master/NixOS-18.09/configuration.nix. Then per the FAQ add the nixos-unstable channel with:
sudo nix-channel --add https://nixos.org/channels/nixos-unstable nixos-unstable
sudo nix-channel --update nixos-unstable

Then install SageMath with:
nix-env -f '<nixos-unstable>' -iA sage texlive
then, run:
nix-shell -p gobjectIntrospection gtk3 'python27.withPackages(ps : with ps; [ matplotlib sage ])'

to hopefully get SageMath and Matplotlib built to work with one another (IIRC) in a GTK+ 3 environment. If this works I should get a GTK+ 3 Matplotlib window to show when this runs correctly. If you get the error:
building '/nix/store/xd2s5kj59zv2bi6gj7wzajrf7gwk5fs0-python-2.7.15-env.drv'...
collision between `/nix/store/wvwj4x34gv5wqmgq65i3x1x725kclfwm-python2.7-backports.ssl_match_hostname-<IP_ADDRESS>/lib/python2.7/site-packages/backports/__init__.py' and `/nix/store/37i3dxmd48f0mr5hilfp9s9iah7yz777-python2.7-backports.functools_lru_cache-1.5/lib/python2.7/site-packages/backports/__init__.py'
builder for '/nix/store/xd2s5kj59zv2bi6gj7wzajrf7gwk5fs0-python-2.7.15-env.drv' failed with exit code 25

then run:
nix-shell -p gobjectIntrospection gtk3 'python2.withPackages (ps: with ps; [ pygobject3 ])' --run "python -c \"import pygtkcompat; pygtkcompat.enable_gtk(version='3.0')\"

(which I also run to help with getting a GTK+ 3 Matplotlib window, as it has worked before on non-NixOS distros), then finally you're on the right track to emulating my local set up.
Now run sage and at the sage> prompt run notebook() and in the Notebook run:
x,y,z=var('x,y,z')
# Next we define the parameters
sigma=10
rho=28
beta=8/3

# The Lorenz equations
lorenz=[sigma*(y-x),x*(rho-z)-y,x*y-beta*z]

# Time and initial conditions
N=250000
tmax=250
h=tmax/N
t=srange(0,tmax+h,h)
ics=[0,1,1]
sol=desolve_odeint(lorenz,ics,t,[x,y,z],rtol=1e-13,atol=1e-14)
X=sol[:,0]
Y=sol[:,1]
Z=sol[:,2]

# Plot the result
from mpl_toolkits.mplot3d import axes3d
from matplotlib import pyplot as plt

# Call the plot function if you want to plot the data
fig = plt.figure(num=None, figsize=(16, 12), dpi=120, facecolor='w', edgecolor='k')
ax = fig.gca(projection='3d')
ax.plot(X, Y, Z, lw=0.5)
ax.set_xlabel("X Axis")
ax.set_ylabel("Y Axis")
ax.set_zlabel("Z Axis")
ax.set_title("Lorenz Attractor")

plt.show()

Technical details
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 4.14.84, NixOS, 18.09.1446.db561c90ef3 (Jellyfish)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.1.3`
 - channels(fusion809): `""`
 - channels(root): `"nixos-18.09.1446.db561c90ef3, nixos-unstable-19.03pre159472.80738ed9dc0"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

@timokau Best ping the maintainer.

Fixed in https://github.com/NixOS/nixpkgs/pull/51337. The issue was that mathjax ("javascript latex") was symlinked to the wrong location and the old sage notebook couldn't find it.


DPU disabled - is it on purpose?

in the quantization tutorial the option
enable_dpu=True
is missing
I do not know if this is wanted or not, but in this way the quantized model will never be assigned to DPU
vai_q_onnx.quantize_static(
    input_model_path,
    output_model_path,
    data_reader,
    quant_format=QuantFormat.QDQ,
    calibrate_method=vai_q_onnx.PowerOfTwoMethod.MinMSE,
    activation_type=QuantType.QUInt8,
    **enable_dpu=True,**
    weight_type=QuantType.QInt8,
    extra_options={'ActivationSymmetric': True}
)

Hi @giovanniguasti ,
In the current version of the tutorial I do see the enable_dpu=True,
https://github.com/amd/RyzenAI-SW/blob/main/tutorial/RyzenAI_quant_tutorial/onnx_example/onnx_model_ptq/quantize_onnx_model_ipu.py#L125
Please review and close this ticket as this seems addressed now

closed


1.5.2 breaks plugin

Sorry to keep filing bugs.
After installing the latest update via Sketch's update system, the plugin disappears from the plugin menu, although the plugin file remains in the plugins folder.
After manually deleting the plugin and reinstalling it, the problem persists (not present in the plugin menu, but present in the plugin folder).

Are you running v47?

46.2 (have to hold off on the update for another day or so). FWIW, this was an issue in the previous release as well, but I was able to resolve it by manually deleting and reinstalling.

I can't reproduce on my end -- I uninstalled and reinstalled and it shows up. I'm not an expert on plugins tho, i'll dig around and see if I can figure it out.  If you have anything in your Console that might be helpful. It's also possible that somehow it's conflicting with another plugin (seems unlikely)? just out of curiousity if you remove all the other plugins except CleanUp SFUI does it appear?

actually I think I have an idea what's going on. the zip file  wasn't packaged properly

Yea I think you're right. When I downloaded the master and installed from there, it installed properly.

sorry!

No worries! Thank you for making this plugin and being so responsive to issues! 🙌

Updated the archive in the 1.5.2 release, plus version bumped to 1.5.3 to be safe https://github.com/schwa23/cleanupsfui/commit/eabb98021e27c1719089d82b306840e3e84a4efc


short name for acme_diags and AMWG

The experiment short name should be used for acme_diags and AMWG.

This appears to be working fine now.


Populate the CHHA course

We should now have all of the content for the CHHA course from Logan. We should replace the 'sample course' with this content.

Videos:

Q1
Q1_MC
Q1_Answer
Q2
Q2_MC
Q2_Answer
Q3
Q3_MC
Q3_Answer
Q4
Q4_Answer
Q5
Q5_MC
Q5_Answer
Q6
Q6_MC
Q6_Answer

We don't yet have the actual webinars - Doris is working on getting them.

Webinar Videos:

Build Environment

Built Environment
Built Environment FRE

Communication in the workplace

Communication in the workplace English ASL
Communication in the workplace French LSQ
Communication in the workplace snippet
Communication in the workplace snippet French
Workplace communication webinar
Workplace communication webinar French

Customer service

Customer service
Customer service French
Customer service snippet French

Overview of communication

Overview of communication
Overview of communication English ASL
Overview of communication French
Overview of communication snippet French LSQ

Additional non video resources:
May 2023 - Additional Non-Video CHHA Resources.zip

@chosww I've added links to the webinar videos above, and there are also some non video resources that they've shared with us too.

Text content for the course:
CHHA Resources for TAE 2.zip

Things that current course/training don't support but are required:

Multiple Introduction videos and text
Localize author (in particular for organization names)
Signed language videos for quizzes and other courses content
Different formats of questions/answers

In the content for the course it mentions the following:

For the first video introduction
Welcome to Disability Connect, linking communication to transportation. In this introduction video, you will learn and meet Canadians who share the importance of understanding the various communication needs of individuals with communication disabilities and accessing services in the transportation sector.

Second video description
Accessible communication is essential to ensure equitable access to people with diverse communication needs. This video provides an overview of the following areas, customer service, built environment, workplace and use of technology.

However we don't have videos for these. We only have videos for the 4 webinars and ASL videos related to the quiz.


Deployment

Deployment
User Story
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN a Prework Study Guide website,
WHEN I visit the website using the URL,
THEN I can access my website from any browser

FINISHED !!! :)


documentation missing

i cannot access documentation
https://demos.creative-tim.com/vue-argon-dashboard/documentation/#/tutorial

i tried to use the free component OrdersListCard
but this file is missing @/examples/Cards/OrdersListCard.vue
https://www.creative-tim.com/learning-lab/vue/orders-list/argon-dashboard/
please provide me this file for vue-argon-dashboard

Hi @unnimona,
The link to the documentation is: https://www.creative-tim.com/learning-lab/vue/overview/argon-dashboard/
and OrdersListCard is a PRO component.
Best regards,


Add Client Local Module for local inferencing

Before using the commit, make sure to do the following:

Get the latest executorch.aar: Unless if you already have one from the ExecuTorch builds, you can get a pre-built AAR library using the instructions in the ExecuTorch Github.
Unzip executorch.aar: unzip executorch.aar -d et_lib
Port aar contents client local module: Move all the files/folders from et_lib directory to llama-stack-client-kotlin-client-local
Sync Gradle files

currently there is a compile error with no return type in chatCompletion(). This is expected right now since this is a draft PR.

rebase


Forms always appear to have changed in Git

In the export process, Forms are exported as binary files (.frx). Since vbaDeveloper re-exports and overwrites and because of something in the file creation process(maybe a date stamp or some similar tag??), when putting the exported VBA form into version control it appears to have changed in every commit, regardless of whether the user actually made changes. This can lead to confusion in version control.
I see 3 choices:

Ignore, and adapt my Git workflow (i.e. just don't commit the unchanged files). This is slightly more manual, and also a slight training burden for my not-very-git-savy teammates.

Add a function to the vbaDeveloper to prompt whether to export forms and any other offending file types. Don't prompt if no offending file types would be exported.

Hunt down what the reason for the differing binary files and see if it is possible to exclude that component from the export.

Anyone else have opinions, or have a need for option 2 or 3 if I were to develop it? Anyone (particularly the project owner) opposed to option 2?

I noticed this as well, my thought was to put a date stamp comment in the code.  To elaborate, before it's exported, modify the first line in the code to have the timestamp of when it was last exported, kind of like .bas files.
With modules, when they are exported they have a line "Attribute VB_Name = "Module_Name"" which I know is actually removed once it's imported so it is never really seen by the developer but it could work.
Anyway, the flow would be...

Export function triggered
The program checks the date in the first line of the code (projectCodeDate)

If (projectCodeDate > fileLastModifiedDate) then

export continues

ElseIf (projectCodeDate < fileLastModifiedDate) then

*MsgBox("Woah... "merge" conflict...")
export skips file

Else

export skips file

In all honesty, I was thinking about doing this with all files, I'm afraid that I'm going to edit something in the exported file, forget, and then overwrite it by exporting from the add in.  There needs to be some sort of QA check here (in my opinion).
Thoughts?

Another option, while very involved, would be to modify the entire exporting function to, rather than use the official export function, use a file stream.  This would also resolve the issue with class files because, apparently class files cannot just be imported via macros.  I read a solution (that I also mentioned in the class files issue) in which the user stated that class files but be created via file input streams.  That is, creating a new class object and then reading in the text.
Obviously this would be a huge overhaul but, if it's the most error free and accurate way...  Just throwing it out there.

gberl001,
I'm not completely certain I understand where those two date stamps you're referring to are coming from. My assumption is:
-projectCodeDate is the whole VBA project (not tied to a specific Form)
-fileLastModifiedDate is the "date tag" you're adding to the first line of the file
If I understand correctly, I'm not sure these date stamps will get what we want. If projectCodeDate is scoped on the project level, a change in another part of the code (a module for instance) would trigger an export even if the individual Form wasn't updated. For your issue of editing something in the exported file, this also won't resolve that unless you remember to manually change that date stamp (which would be error prone). Lastly, the .frx files are binary (not the .frm files, which are the code attached to the form, .frx is the form itself), so I'm not sure how to put the date stamp in there to begin with.
I don't know enough about the file stream method to know if that's a viable option. Would that create identical FRX binary files regardless of when they are exported? It would be great to fix the class file import issue, although export will be far more common than import for my workflow at least.

Okay, I'll try to clarify
The add in would (when exporting any object) add a date (exported date) to each object's code (in the first line).  When running export again, the add in would check the date in the first line of the code to see if it matches the file's last modified date.

The date in the image above would be compared to the file's last modified date

In the above case, this would export fine because the form in the Excel file has a date newer than the file on the network.  However, I realize this is flawed now because the date in the Excel file would need to be changed every time that form module was changed and only when it was changed and there is no way (that I know of) to do that.  An alternative to the date in the first line of each module would be to keep a text file with the module names and dates so it can't be manually altered but the point is moot now since I realized the flaw that I think you were mentioning about needing to manually update.
This would solve my problem (not wanting to overwrite a newer exported file since the date in the code is only changed on export.  I'll start a new comment to discuss the other concern

Yeah, that's what I meant by project modified date being scoped to the
whole VBA project. Regardless, this still doesn't address the issue that is
with FRX files (not FRM files - which work fine, the same as .bas files):
This shows up in the commit (unless I manually exclude the file) even when
I have not modified the form itself:
[image: Inline image 1]
Since it's binary, you can't add a date stamp.
I didn't realize you were concerned with overwriting a newer export - I
don't think that situation would ever come up in my workflow. If you
manually updated the VBA outside of Excel that could happen, but again
you'd need to remember to manually change the date stamp.

Neal Humphrey
Founder, Flashband | www.flashband.org |<PHONE_NUMBER>
Are you on the Flashband mailing list http://eepurl.com/mslV5 yet?
https://flashband.org/events https://flashband.org/events
https://flashband.org/events
On Wed, Jan 28, 2015 at 10:58 AM, gberl001<EMAIL_ADDRESS>wrote:

Okay, I'll try to clarify
The add in would (when exporting any object) add a date (exported date) to
each object's code (in the first line). When running export again, the add
in would check the date in the first line of the code to see if it matches
the file's last modified date.
[image: image]
https://cloud.githubusercontent.com/assets/4296563/5940907/c0a952d0-a6db-11e4-8747-4898d77d3593.png
The date in the image above would be compared to the file's last modified
date
[image: image]
https://cloud.githubusercontent.com/assets/4296563/5940943/fd4f8e98-a6db-11e4-9ab3-365f738a26e0.png
In the above case, this would export fine because the form in the Excel
file has a date newer than the file on the network. However, I realize this
is flawed now because the date in the Excel file would need to be changed
every time that form module was changed and only when it was changed and
there is no way (that I know of) to do that. An alternative to the date in
the first line of each module would be to keep a text file with the module
names and dates so it can't be manually altered but the point is moot now
since I realized the flaw that I think you were mentioning about needing to
manually update.
This would solve my problem (not wanting to overwrite a newer exported
file since the date in the code is only changed on export. I'll start a new
comment to discuss the other concern
--
Reply to this email directly or view it on GitHub
https://github.com/hilkoc/vbaDeveloper/issues/5#issuecomment-71859094.

If you
manually updated the VBA outside of Excel that could happen, but again
you'd need to remember to manually change the date stamp.
NealHumphrey

Not necessarily, VBA is reading the "Last Modified" date of the file which changes as soon as you hit save after editing it externally from Excel.  It only looks at the date inside the code file when it's in the project (so it would still work for binary files).  See Example flow chart

However, this still has the issue of, if you don't manually update the date in the code (in Excel) then the add in is going to assume you didn't make any changes because it will match the file date.
Well, I'm out of ideas as far as FRX goes.  I think your number two option is the best one at this point.  I looked into the number three option but it doesn't seem anyone else has been ambitious enough to figure out what changes because most stuff I found online said, just deal with it.  Also, I am fairly certain it would be different by version at the very least.
I tested one form, exported it a few times, the same four hex segments changed every time.  I tried another form from the same workbook, ironically while it was a smaller form, it had quite a few more changes at ~20 segments changed.  There seemed to be a pattern 2200-->3b09 and 00-->09 but no way I want to try and figure out the pattern of all the changes.  I think this application could benefit from a few custom settings...

[x] Ask to overwrite .FRX
[ ] Always export on save
[ ] Always import upon opening
[X] Apply settings to this session only

Anyway, before I ramble on any further.  Again, I vote for option "2"

Okay, I think I'm going to go ahead and develop option 2; we're just
starting to use this app on an Excel tool that has dozens of forms and I've
got a couple very-new-to-version-control team members I'm trying to get
using it.
Note - I have a pull request out to Hilkoc that adds the 'always export on
save' setting (as well as an extra function to export the XML of the Excel
file, i.e. unzip the contents of the .xlsm file). He previously Ok'd it but
I needed to rebase it onto his current master; he made a note that he's a
bit busy to respond to stuff on the development so might not be in there
for a bit more, if you want it in the meantime you can fork off my branch.
I will add the 'ask to overwrite' as a custom setting; but I'll probably
take the quick and dirty route for now and just do it as a public variable
at the top rather than actually saving the user preference to the add in
and adding the necessary user forms.
Neal

Neal Humphrey
Founder, Flashband | www.flashband.org |<PHONE_NUMBER>
Are you on the Flashband mailing list http://eepurl.com/mslV5 yet?
https://flashband.org/events https://flashband.org/events
https://flashband.org/events
On Wed, Jan 28, 2015 at 3:18 PM, gberl001<EMAIL_ADDRESS>wrote:

If you
manually updated the VBA outside of Excel that could happen, but again
you'd need to remember to manually change the date stamp.
NealHumphrey
Not necessarily, VBA is reading the "Last Modified" date of the file
which changes as soon as you hit save after editing it externally from
Excel. It only looks at the date inside the code file when it's in the
project (so it would still work for binary files). See Example flow chart
[image: image]
https://cloud.githubusercontent.com/assets/4296563/5944463/1ffb6ae8-a6f5-11e4-92f7-a68899a32b7e.png
However, this still has the issue of, if you don't manually update the
date in the code (in Excel) then the add in is going to assume you didn't
make any changes because it will match the file date.
Well, I'm out of ideas as far as FRX goes. I think your number two option
is the best one at this point. I looked into the number three option but it
doesn't seem anyone else has been ambitious enough to figure out what
changes because most stuff I found online said, just deal with it. Also, I
am fairly certain it would be different by version at the very least.
I tested one form, exported it a few times, the same four hex segments
changed every time. I tried another form from the same workbook, ironically
while it was a smaller form, it had quite a few more changes at ~20
segments changed. There seemed to be a pattern 2200-->3b09 and 00-->09 but
no way I want to try and figure out the pattern of all the changes. I think
this application could benefit from a few custom settings...

Ask to overwrite .FRX
Always export on save
Always import upon opening
Apply settings to this session only

Anyway, before I ramble on any further. Again, I vote for option "2"
--
Reply to this email directly or view it on GitHub
https://github.com/hilkoc/vbaDeveloper/issues/5#issuecomment-71907967.

On a mildly related note, do you put your Excel files/tools (VBA +
spreadsheet components) into Git for version control? I've been trying to
figure out an appropriate workflow that deals with all the associated
issues (merging parallel development etc.) and this vbaDeveloper add-in has
made it actually a feasible possibility and I'm close to a decent set of
workflow conventions but would be great to hear someone else's methodology
if they're trying to do the same.

Personally, I follow the method described here, although I do not use release branches, I work on Dev to fix bugs and add in features planned for the next release, features not complete have their own branches.  I also have a fixed setting in my gitconfig to use --no-ff for all merges (to keep history).

Yes, I follow something very similar (actually based off that same post),
although I've also started rebasing every feature branch to squash the many
branch components down to just one commit (or a couple if it makes sense -
but get rid of all the 'halfway done' and 'fixing typo' commits).
For Excel files, I include the .xlsm file in the commit, but vbaDeveloper
lets me track all the VBA changes and see the diffs in the commit history.
Unless I'm merging though, I essentially just use this as backup and
consider the version in the Excel file itself to be the 'golden' version.
For spreadsheet changes, I make a log and then use a consistent formatting
(hot pink for instance) to highlight any sections changed in a specific
feature. Before merging this into Master, I make a clean version so you end
up with two commits, an 'annotated' that has the spreadsheet changes
marked, and a 'clean' that has them removed which is the one that goes back
into master.
The big issue I haven't quite resolved is when two people have edited the
Excel file (either just changing the VBA or both changing the spreadsheet).
Obviously you have to do actual merging of content manually (facilitated by
the annotations, or by the 'import' function of vbaDeveloper if VBA) but I
haven't figured out where to put the interim files that end up happening -
when you make the merges, you have to pick one file or the other, and I
haven't figured if it makes more sense to do the manual incorporation
before or after.
So much cleaner when you just work with code...

Thanks for all this useful input.I think it makes sense to add option 2 as a feature to the VbaDeveloper addin.

On a mildly related note, do you put your Excel files/tools (VBA + spreadsheet components) into Git for version control?

(Unfortunately) we do commit excel binary files to version control. Simply because some workbooks are more than just VBA code. For example you may have text, data and formatting in a worksheet. Although it is possible to build your entire workbook programmaticaly in VBA code, this is usually quite a lot of effort to do.
Other workbooks, usually xlam files, like the VbaDeveloper addin this consist of only VBA code and for you don't need to keep the binary file. However we commit all excel binaries, just to be consistent and keep things simple.
How do we deal with forms? We simply git ignore the .frx files. This way they don't show up as changed (although they may have) and we don't commit them. No information is lost, because the entire form is already part of the excel binary file, which we do commit. If you'd want to, you can simply export the .frx again from the original excel workbook.


GRPC Service Proxy and Encoding Interceptor

What was changed
Added a proxy which wires together a GRPC server and client for WorkflowService.
Why?
This allows users to build proxies for Temporal Frontend traffic and use GRPC interceptors to manipulate requests or responses. One use case for this is to centralise data encoding.
Checklist

How was this tested:

Any docs updates needed?

Headers are not touched as the SDK doesn't use a data converter on the headers, the header related APIs expect the user to convert to/from Payload themselves (through whichever data converter they prefer). I'll check on Failure. I think the SDK may touch the Payloads for Details, but not any Payload outside of a Payloads wrapper.

Headers are not touched as the SDK doesn't use a data converter on the headers, the header related APIs expect the user to convert to/from Payload themselves (through whichever data converter they prefer). I'll check on Failure. I think the SDK may touch the Payloads for Details, but not any Payload outside of a Payloads wrapper.

Yeah but the whole point of the proxy is so worker and client deployment doesn't get access to encryption secrets, I'm imagining users will use the default data converter here.

One of the issues with this PR's approach is that if there are any proto changes we'd miss some fields.
This is obviously fine for an initial PR and we don't have to solve it now but we should have either static analysis or comprehensive testing.

I've got an auto-generated version of the interceptor nearly working which would use an opt-out approach to exclude Payload(s) we don't want to be touched. Chad has suggested a test which will re-walk the API definitions and check if the list on which the interceptor is built has drifted from the current API version so that we can ensure decisions are made about new Payload(s) as they are introduced (or removed for that matter).

Which payloads do we not want to touch?

When https://github.com/temporalio/api/pull/153 lands, it'll be a good example of whether the test will fail when we upgrade the API dependency but don't re-gen code.

I've got an auto-generated version of the interceptor nearly working which would use an opt-out approach to exclude Payload(s) we don't want to be touched. Chad has suggested a test which will re-walk the API definitions and check if the list on which the interceptor is built has drifted from the current API version so that we can ensure decisions are made about new Payload(s) as they are introduced (or removed for that matter).

Nice! That's what I was going for

make check now verifies via make generatorcheck that files generated based on the API are not stale.

LGTM! Ignore the coveralls complaint (can squash/merge anyways once you get @bergundy's approval)


Fix issue #4342 - PowerShell cmdlet name collision with VMware PowerCLI

When VMware PowerCLI is installed alongside Hyper-V, there are multiple command collisions which prevent the hyperv machine driver from working as expected.  This issue is reported in #4342, and is fixed by prepending the hyper-v module name to ensure the correct module is used.

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "4342-powercli-collision" git@github.com:davemay99/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

LGTM

I've installed version 0.14.0-rc1, build e918c74, but I'm getting the error reported: "Error with pre-create check: "Hyper-V PowerShell Module is not available". Does anyone have advice one what I should be looking out for?


[WIP][java][mmlspark] speed up inference by ~20% in java layer

Speed up inference by returning java array from LGBM_BoosterPredictForMatSingle and LGBM_BoosterPredictForCSRSingle.  This reduces JNI calls when getting the values from the array and also removes one step to allocate the output array in the Java side, removing another JNI call.
Testing in mmlspark, time was reduced from<PHONE_NUMBER>3ns to<PHONE_NUMBER>3ns, ~20% improvement.
FYI @eisber

One question @imatiach-msft - why not reuse the array instead of allocating a new one each time?
I have another extremely fast  high-throughput low-latency implementation that used this functions and instead reuses the array *out_result for every call, meaning you only have to read the values, and no allocations are necessary. Isn't this new change going to make it slower than that solution?

@AlbertoEAF great point, I am investigating that as well, note this is still WIP.  Sorry haven't had more time to look into this lately.  I did discover an issue in how I was calculating the speedup, so this isn't quite ready yet.

Whenever you have time, can you please merge in master?  Some changes have been made to our CI jobs to fix failures there. I apologize for the inconvenience.

@imatiach-msft
What is the status of this PR?
do you have a plan for it?

@guolinke yes, I will work on it again, let me close it for now


U/jrbogart/abs path

Add routine to return absolute path for a dataset.

What about storing the root_dir in the schema provenance table? The user would then never have to think about the root dir, just the schema name. Also if we ever had to move the data we would just have to update the root dir in the provenance table. And to reconstruct the abs_path we would just need to pull the root dir out of the table metadata.

Storing root_dir in the database itself doesn't cover everything.

user can set root_dir to something non-standard when they register (and if they have, they better set it to the same thing when they query)
if we mirror the data (but not the Postgres database) at another site, the stored root_dir would be wrong for users at the alternate site.
I think the best we can do is keep track of a default root_dir per site, with NERSC currently being the only recognized site. And that information should be stored in the code or, probably better, in a configuration file within the package that the code reads.   Then, when we actually have multiple sites, we should also allow users to specify site, probably with an environment variable. This is the technique used in GCRCatalogs.

Storing root_dir in the database itself doesn't cover everything.

user can set root_dir to something non-standard when they register (and if they have, they better set it to the same thing when they query)
if we mirror the data (but not the Postgres database) at another site, the stored root_dir would be wrong for users at the alternate site.
I think the best we can do is keep track of a default root_dir per site, with NERSC currently being the only recognized site. And that information should be stored in the code or, probably better, in a configuration file within the package that the code reads.   Then, when we actually have multiple sites, we should also allow users to specify site, probably with an environment variable. This is the technique used in GCRCatalogs.

Ok, I will start a new PR with this suggestion. ^^^
I added a quick CI test to test the get_dataset_absolute_path function
Just one comment about crashing scenario if that dataset doesnt exist. Other than that approved to merge

Thanks for adding the CI test.


Minor language compatibility issues

Please ensure you have given all the following requested information in your report.
Please select the affected platforms

[ ] Android Studio

Please select the translator to use

[ ] Google
[ ] Google (API)
[ ] Microsoft
[ ] Baidu
[ ] Youdao
[ ] Ali

Version of Plugin and IDE

Plugin Version: 3.0.0
IDE Version:2022.3.1 Patch 2

Issue details

My request is support minor language localize, like Uyghur or others language.
I had switch to different translation engine, but theres no options can generate Uyghur.
I had try some translation platform such as Google, Microsoft at the website, they support translation English to Uyghur.
Is theres any intercept or filter between platform and plugin?

So I found the source code.
Theres pretty of preset support language had add to the XXXTranslator.java,
May be i can add Uyghur or some other minor languages to the preset list

Thanks


iframe on iOS is not rendering content

Bug description:
Our app is just a webview that displays our react website.   We have emails that are displayed to our users that are contained within an iframe, and it works as expected except on iOS.    On that platform the iframe is rendered, but the content is blank.   While I can switch to an Android device and see the content rendered as expected.
Expected behavior:
Content within the iframe should be rendered.   Here is a sample message body that We are using as the srcDoc:
`

yeah I have the same issue. In my case I embedded an YouTube video. The iframe url is immediy opened in the browser, which displays the video, while the iframe stays blank in the webview.

Was reported before in #1832

Facing the same issue. Any update or workaround for this?

Facing the same issue. Any update or workaround for this?

I got it to work, I believe it was this line.
originWhitelist={[*]}
Added to the WebView.


add a readme to packagestore to ensure its existence

Description
With the recent changes to nuget.config, I added a directory that can be used to easily test nuget packages locally without having to configure a feed.  That change did assume that the directory existed.  Now it does :)
Thanks for VinJa for pointing this out.
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)

Alternatively, we could also put a .gitignore in that directory so you also don't need to think about accidently checking in a NuGet package.


WIP: Add sample for dynamic rendering local read

Description
This PR adds a new sample that shows how to replace render passes + multiple sub passes with dynamic rendering and the new VK_KHR_dynamic_rendering_local_read extension. The sample contains code paths for both those setups which can be toggled via a pre-processor define.
The sample also comes with a small tutorial that explains some of the differences.
Note: This is a copy of the sample from the internal gitlab. With the extension now public, we can continue on this over here.
Note: Validation layers for the new extension aren't public yet. I've made sure that the sample doesn't show any validation errors with an internal version of the layers. Unless you have access to that, please disable validation for this sample.
Note: Requires assets from https://github.com/KhronosGroup/Vulkan-Samples-Assets/pull/23, so that PR needs to be merged before or right after this PR has been merged.
Tested on Windows 11 with an NVIDIA RTX 4070 and the latest public Vulkan developer driver.
General Checklist:
Please ensure the following points are checked:

[x] My code follows the coding style
[x] I have reviewed file licenses
[x] I have commented any added functions (in line with Doxygen)
[x] I have commented any code that could be hard to understand
[x] My changes do not add any new compiler warnings
[x] My changes do not add any new validation layer errors or warnings
[x] I have used existing framework/helper functions where possible
[x] My changes do not add any regressions
[x] I have tested every sample to ensure everything runs correctly
[x] This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

[x] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
[x] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

[x] I have tested the sample on at least one compliant Vulkan implementation
[x] If the sample is vendor-specific, I have tagged it appropriately
[x] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
[ ] Any dependent assets have been merged and published in downstream modules (see https://github.com/KhronosGroup/Vulkan-Samples-Assets/pull/23)
[x] For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme
[x] For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
[x] For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

I'm having trouble with getting the clang format right. I'm on VS 2022 (latest version) and I don't know why our clangformat does fail.
It fails on this:
	VkPipelineRenderingCreateInfoKHR pipeline_rendering_create_info{VK_STRUCTURE_TYPE_PIPELINE_RENDERING_CREATE_INFO_KHR};
	pipeline_create_info.pNext = &pipeline_rendering_create_info;

Which looks totally fine to me.
Any ideas @tomadamatkinson?

@tomadamatkinson : I'm struggling to get this to pass all checks. The pre-commit clang format step did something but it still fails, and I don't have a clue how to fix it. I also don't know why the doxgen checks are failing now :(
Also no idea why Android is failing all of a sudden :(

And it looks like I made the mistake of committing and pushing files with merge conflict info still present :/
Maybe I should refrain from adding new samples until we are done with the framework rework.

Still fails with clang format and I have no clue why. I guess it's because I'm making heavy use of compiler directives?

Copyright checks now also fail for a file that isn't even touched by this PR 😟

Hey @SaschaWillems i tried locally with pre-commit run clang-format --files $(git diff main --name-only)

Did you install pre-commit to validate your commits? It will pull and run the correct version of clang-format for you

Five of the six files in your screenshot aren't even touched by this PR :/

@tomadamatkinson : Stupid question, but is it possible to manually run pre-commit? I don't see any mention of this in our docs.

@tomadamatkinson: Okay, so I need to enable pre-commit explicitly for each folder. I work on branches in separate folders. Doing that and running your command I see it changes at least one of the files from the failure.
BUT, the changes make no sense to me, e.g. this. Sometimes it adds oddly looking spacing/tabs:

And in other places it completely removes the alignment:

It seems like it has troubles with code in defines.
That doesn't feel right :/

The main issue I have with pre-commit: It won't let me push my manual changes anymore with adding it's own changes. That's probably the reason I had to disable it for this branch :/

Have tried this on linux, but there is only support for this example on NVIDIA platforms at this moment. Will try to test on windows later this week.
When building I had to turn off the opencl interop example due to out of sync changes.

Sorry, totally forgot to merge main into this. I've merged and pushed the branch, so it should compile fine now.
And thanks for testing :)

Extension isn't supported by latest official AMD drivers. Also checked vulkaninfo and it isn't there.
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: AMD Radeon RX 5700 ATI Technologies Inc. 4.6.0 Core Profile Context <IP_ADDRESS>110
[info] Using dynamic rendering with local read
[info] Initializing Vulkan sample
[info] Vulkan debug utils enabled (VK_EXT_debug_utils)
[info] Extension VK_KHR_get_physical_device_properties2 found, enabling it
[info] Extension VK_KHR_win32_surface found, enabling it
[info] Extension VK_EXT_debug_utils found, enabling it
[info] Enabled Validation Layers:
[info] Found GPU: AMD Radeon RX 5700
[info] Selected GPU: AMD Radeon RX 5700
[info] Dedicated Allocation enabled
[info] Device supports the following requested extensions:
[info]          VK_KHR_get_memory_requirements2
[info]          VK_KHR_dedicated_allocation
[info]          VK_KHR_dynamic_rendering
[info]          VK_KHR_synchronization2
[info]          VK_KHR_swapchain
[error] Required device extension VK_KHR_dynamic_rendering_local_read not available, cannot run
[error] Error Message: Extensions not present : ERROR_EXTENSION_NOT_PRESENT
[error] Failed when running application dynamic_rendering_local_read

Looking at gpuinfo I see only a single driver (2.0.299) supporting this.
I will report on my findings of the Intel platform in the next post.

Silly question... where do I find the assets used with this sample (scenes/subpass_scene_opaque.gltf, scenes/subpass_scene_transparent.gltf, and textures/transparent_glass_rgba.ktx)?

@asuessenbach you can checkout the next PR https://github.com/KhronosGroup/Vulkan-Samples-Assets/pull/23

@jeroenbakker-atmind Thanks, now it runs fine here as well: Win10, NVIDIA RTX A3000 Laptop

The gui is only available when USE_DYNAMIC_RENDERING is not defined. Is that for a specific reason?
When I just prepare the gui even if USE_DYNAMIC_RENDERING is defined, I get a VL error:
Validation Error: [ VUID-VkGraphicsPipelineCreateInfo-renderPass-06055 ] | MessageID = 0xcfde2b97 | vkCreateGraphicsPipelines(): pCreateInfos[0].pColorBlendState->attachmentCount is 1, but VkPipelineRenderingCreateInfo::colorAttachmentCount is zero because the pNext chain was not included. The Vulkan spec states: If renderPass is VK_NULL_HANDLE, pColorBlendState is not dynamic, and the pipeline is being created with fragment output interface state, pColorBlendState->attachmentCount must be equal to VkPipelineRenderingCreateInfo::colorAttachmentCount (https://vulkan.lunarg.com/doc/view/1.3.283.0/windows/1.3-extensions/vkspec.html#VUID-VkGraphicsPipelineCreateInfo-renderPass-06055)
Will that be resolved and the GUI could be available with some newer validation layer?

Yes, that layer message is the reason the GUI is disabled by default. For the GUI to work with that sample I would have to do some extensive changes to the GUI framework class. I may do that once this sample has been merged in a separate PR.

I can still test on NVIDIA GTX 980 + 760 IIRC only the 980 will support this.

Thank you very much for testing. That validation message seems to have been introduced by a recent SDK. I added the readonly attribute to the buffer mentioned in that message.

Merging - 3 approvals


add a note about reflinks and how space is calculated in the tutorial

In our article https://dvc.org/doc/tutorial/define-ml-pipeline , we use du to show that space taken by the repo didn't double. That works with hardlinks, but du is not smart enough when it comes to reflinks, which it counts as separate full-blown filse and accounts for their size two times(for the cache file and for the reflink), which makes it confusing for the mac users https://github.com/iterative/dvc/issues/1442 . We should add a note about it.

Note: to prove that no duplication occurs, we could use df utility to see that free space on the drive indeed didn't decline by the file size that we are adding.

Can I work on this issue?

@kurianbenoy absolutely, feel free to start working on this! Join the dvc.org/chat and #dev-docs channel if you need any help.

Add docs in tutorials about various link types in this page as well when documentation is ready for this.

Someone got confused on Discord because the tutorial implies a cache type of hardlink / symlink / reflink
https://discordapp.com/channels/485586884165107732/485596304961962003


Errors around coast lines on SST plots with v1-HR model output

I ran e3sm_diags on output from v1-HR, regridded using map_ne120np4_to_cmip6_720x1440_nco.20190601.nc.
The SST plots show erroneous values near the coastlines, leading to a very large RMSE error:

Full E3SM Diags output: https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.golaz/E3SM/v1-HR/20210112.A_WCYCL1950S_CMIP6_HR.ne120_oRRS18v3_ICG.unc06/e3sm_diags/720x1440_nco/model_vs_obs_0137-0155/viewer/
Here is my configuration to reproduce on chrysalis using zppy:
[default]
input = /lcrc/group/e3sm/ac.ndkeen/scratch/chrys/E3SM_simulations/production-unc06
input_subdir = run
output = /lcrc/group/e3sm/ac.golaz/E3SM_analysis/20210112.A_WCYCL1950S_CMIP6_HR.ne120_oRRS18v3_ICG.unc06
case = 20210112.A_WCYCL1950S_CMIP6_HR.ne120_oRRS18v3_ICG.unc06
www = /lcrc/group/e3sm/public_html/diagnostic_output/ac.golaz/E3SM/v1-HR
partition = compute
e3sm_unified = latest

[climo]
active = True
years = "137-155",

  [[ atm_monthly_720x1440_nco ]]
  input_files = "cam.h0"
  mapping_file = /home/ac.zender/data/maps/map_ne120np4_to_cmip6_720x1440_nco.20190601.nc

[ts]
active = True
years = "137:155:1",

  [[ atm_monthly_720x1440_nco ]]
  input_files = "cam.h0"
  mapping_file = /home/ac.zender/data/maps/map_ne120np4_to_cmip6_720x1440_nco.20190601.nc
  vars = "FSNTOA,FLUT,FSNT,FLNT,FSNS,FLNS,SHFLX,QFLX,TAUX,TAUY,PRECC,PRECL,PRECSC,PRECSL,TS,TREFHT,CLDTOT,CLDHGH,CLDMED,CLDLOW"

  [[ atm_monthly_glb ]]
  input_files = "cam.h0"
  mapping_file = "glb"
  vars = "FSNTOA,FLUT,FSNT,FLNT,FSNS,FLNS,SHFLX,QFLX,TAUX,TAUY,PRECC,PRECL,PRECSC,PRECSL,TS,TREFHT,CLDTOT,CLDHGH,CLDMED,CLDLOW"

[glb]
active = False

[e3sm_diags]
active = True
years = "137-155",

  [[ atm_monthly_720x1440_nco ]]
  short_name = 'unc06'
  grid = '720x1440_nco'
  reference_data_path = '/lcrc/soft/climate/e3sm_diags_data/obs_for_e3sm_diags/climatology'
  output_format_subplot = "pdf",

[e3sm_diags_vs_model]
active = False

[amwg]
active = False

[mpas_analysis]
active = True
walltime = "24:00:00"
parallelTaskCount = 6
subdir_ocean = run
subdir_ice = run
ts_years = "137-155",
enso_years = "137-155",
climo_years ="137-155",
mesh = "oRRS18to6v3"

I can reproduce the problem with:
e3sm_diags lat_lon --no_viewer --case_id 'SST_CL_HadISST' --sets 'lat_lon' --run_type 'model_vs_obs' --variables 'SST' --seasons 'ANN' --regions 'global' --regrid_tool 'esmf' --regrid_method 'conservative' --main_title 'SST ANN global' --backend 'mpl' --output_format 'png' --output_format_subplot 'pdf' --canvas_size_w '1212' --canvas_size_h '1628' --figsize '8.5' '11.0' --dpi '150' --arrows --contour_levels '-1' '0' '1' '3' '6' '9' '12' '15' '18' '20' '22' '24' '26' '28' '29' --test_name '20210112.A_WCYCL1950S_CMIP6_HR.ne120_oRRS18v3_ICG.unc06' --short_test_name 'unc06' --test_colormap 'cet_rainbow.rgb' --ref_name 'HadISST_CL' --reference_name 'HadISST/OI.v2 (Climatology)' --reference_colormap 'cet_rainbow.rgb' --diff_title 'Model - Observations' --diff_colormap 'diverging_bwr.rgb' --diff_levels '-5' '-4' '-3' '-2' '-1' '-0.5' '-0.2' '0.2' '0.5' '1' '2' '3' '4' '5'  --granulate 'variables' 'seasons' 'plevs' 'regions' --selectors 'sets' 'seasons' --test_data_path '/lcrc/group/e3sm/ac.golaz/E3SM_analysis/20210112.A_WCYCL1950S_CMIP6_HR.ne120_oRRS18v3_ICG.unc06/post/atm/720x1440_nco/clim/19yr' --reference_data_path '/lcrc/soft/climate/e3sm_diags_data/obs_for_e3sm_diags/climatology' --results_dir '/lcrc/group/e3sm/public_html/diagnostic_output/zhang40' --save_netcdf

Could be an regridding issue when taking the difference between model and obs. I'm looking into it.

I tracked back to an old issue which is got being addressed: https://github.com/E3SM-Project/e3sm_diags/issues/175
This issue affects evaluating high resolution model data with a mask being applied, ig. SST, T at 850mb. The problem is with conservative regriding method in cdms. At the time being, CDMS issues are not being worked on, I would propose to use bilinear interpolation as a default regriding method.
Conservative for high res SST:

Bilinear for high res SST:

For SST plots, switching to bilinear interpolation doesn't seem to change the metrics for Low res:
Conservative for low res SST:

Bilinear for low res SST:

I'm going to run through all variables to see what fields will be affected.

I ran two cases: one uses bilinear interpolation the other uses conservative.
Checking the difference between ANN table: https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/zhang40/tests/full_bilinear_low-res/viewer/table/index.html
All radiation fluxes fields stay identical, many other fields see minor changes. TGCLDLWP_OCN has largest difference comparing two methods.

@chengzhuzhang : thanks for the nice detective work here! I think we can assume that the CDAT issue https://github.com/E3SM-Project/e3sm_diags/issues/175 is not going to get fixed anytime soon, likely ever.
Switching (temporarily) to bi-linear is probably the best option we have, even though it makes me a little uncomfortable.
This brings into question again the future of CDAT in E3SM Diags, and whether we should transition to something else.

Thank you, @golaz . I am exploring using xarray and xesmf for regridding instead. Again, the bi-linear method works okay. But conservative method fails due to errors with getting data bounds. I will try trouble shooting further. If it won't work, we may have to switch to bi-linear as a short-term solution.

@chengzhuzhang , we use nco for remapping in zppy. You may want to use nco or TempestRemap to fix this issue. The advantages are that these are tools supported by E3SM and easy to use. Just a thought.

Hi @tangq, thanks for the suggestion. A solution that uses a Python interface would be more straightforward to implement in this case.
@golaz, I experimented more with xarray and xesmf regridder and found that conservative regridding looks promising.  To do so, a cdms variable needs to be converted to an xarray variable,  with masks and bounds reformed. Example 3 for xarray here: https://github.com/lee1043/XCDAT/blob/master/compare_cdat_xarray/Regrid_ex1.ipynb
To implement, we will need to add additional dependencies, also a full test run is needed to find out the difference between the new regridding and the old cdms2 regridding method.

@chengzhuzhang , I made the suggestion of using nco or TempestRemap mainly echoing @golaz's comment "This brings into question again the future of CDAT in E3SM Diags". I was experiencing a similar dependency issue when I saw this discussion. Another frustrating case is the cdscan dependency when creating nudging files (You were in that conversation too).
If we have to add dependencies, why not depend on something E3SM supports when possible.
It should be straightforward to implement it. You call the following ncremap command with python before calculating the model-obs differences.
ncremap -a conserve -i input.nc -d dst.nc -m map.nc -o out.nc (if the input.nc and dst.nc are on lat-lon grids. Charlie can provide more instructions on the ncremap options for various input.nc and dst.nc file formats)
Then the python code uses regridded out.nc for the differencing.
Just a suggestion. Feel free to proceed either way. But I'd advocate E3SM supported tools.

@chengzhuzhang and @golaz
Large model/obs SST differences along coastlines (or land model/obs differences along coastlines) are an almost fool-proof indication that the regridding weights are being applied with a global mean-preserving, not a local mean-preserving, algorithm, as described here.
ncremap will, if invoked in MPAS mode with '-P mpas' as described here automatically use the appropriate algorithm (local mean-preserving renormalization) so that the coastline problem "disappears".
This is usually only an issue when using weights generated with a flux-preserving conservative method rather than bilinear interpolation. Let me know if I can be of any help.


No audio playback of MPEG2 files

Issue was reported here:
http://forums.sagetv.com/forums/showthread.php?p=579435&postcount=11
SageTV details the file as:
MPEG2-PS[MPEG2-Video/3.8Mbps 4:3 480i @ 29.97fps, MP2/384Kbps@48kHz Stereo
The problem follows certain vintages of MpegDeMux.ax.  The regression was introduced with the commit for  https://github.com/google/sagetv/commit/ae41796cfa9b70e2104ee6ea844ed5d268eedabc
The problem has been traced to:
native\ax\Native2.0\NativeCore\AVFormat\MpegAudioFormat.c
Making the following change resolves the reported problem:
int ReadMpegAudioHeader( MPEG_AUDIO *pMpegAudio, const uint8_t* pStart, int Size )
{
    int Layer,i,MPGVersion, CRC_protected, BiteRateIndex, SampleRateIndex;
-   int8_t LayerCode;
+   uint8_t LayerCode;
-   const int8_t *pData;
+   const uint8_t *pData;
    uint32_t Bitrate;

I'm unsure if this change will introduce other side effects, since it's unclear why Qian changed these two locals from unsigned to signed.

It should be unsigned. typo.

Are you going to submit a change for this Fred?

Given that it's Qian's regression, I was hoping he would do the submit :^)

Whatever is fine...I figured you found the bug, so you should get credit
for the commit fix. :-)
Jeff Kardatzke
Sent from my Android
On Nov 20, 2015 3:09 PM, "Keith Fischer"<EMAIL_ADDRESS>wrote:

Given that it's Qian's regression, I was hoping he would do the submit :^)
—
Reply to this email directly or view it on GitHub
https://github.com/google/sagetv/issues/55#issuecomment-158552781.

I come from a culture of "if you break it, you get to fix it".   I don't feel a big need to rack up brownie points and also didn't want to step on anybody's turf.   Will wait for a response from Qian.

@JustFred51  Thank you for finding the issue.  I've manually edited my cloned repo and recompiled with VS2015, and FWIW I can confirm this fixes the problem I was having with no audio on mpeg videos.
Thanks again,
Carey

@Hiltronix   Thanks for the feedback.
I'm pretty sure that the change between unsigned/signed introduced a problem with how sign-extension affects the comparisons.
Were you able to turn on any debug messages that gave a clue about the failure?  I didn't notice anything in Native.log.  Still learning what what tools are available to debug the native code. I didn't find Graphedt or GraphStudio to be particularly useful, but I'm not a multimedia guy.

@JustFred51 No, I'm in a similar boat to you, and to be honest I'm new to debugging video issues like this.  I initially figured out which filter file it was mainly through trial and error, swapping out the new for old and narrowing it down, checking playback.  Since then I've started on my learning curve on this topic, using GraphStudio, turning on Sage debug and watching the "DShowGraphFilters" values in "sagetv_0.txt" and "sagetvclient_0.txt", to see what filters Sage is using.
Learning more about this has helped me select codecs for improving how Sage plays back videos other than .ts and .mpg.  My biggest issue with SageTV has always been the playback of file formats other than it's own recordings.  It's been such a time waster over the years (for me at least) playing with codecs, splitters, etc. that are compatible with Sage, and having to learn the ins and outs of tweaking everything to have it be my main video player and not just the recorder and playback for it's own recordings.  My hope for SageTV OS is that some devs with knowledge on this topic will someday make the easy playback capability of all video types as idiot proof as Kodi/XBMC , MPC or VLC.  Sorry for the rant, it's not completely off topic, it's Sage video related, but probably not the correct forum. :)

I submitted the fix. Thanks @JustFred51 https://github.com/JustFred51
Qian
On Fri, Nov 20, 2015 at 3:08 PM, Keith Fischer<EMAIL_ADDRESS>wrote:

Given that it's Qian's regression, I was hoping he would do the submit :^)
—
Reply to this email directly or view it on GitHub
https://github.com/google/sagetv/issues/55#issuecomment-158552781.

Great!  Thanks.


Code Coverage enabled breaks reporting

Description

IMPORTANT: if the defect is reproduced only in a workflow from within the Visual Studio IDE then do not report the issue here - instead, please report it using Visual Studio's "Send Feedback" option that can be accessed from the Help menu OR using this link https://developercommunity.visualstudio.com.
For a defect reproducable from the vstest command line, describe the issue you've observed.

In TFS 2018.2 CI build, enabling code coverage breaks reporting of test results (and code coverage itself).
Steps to reproduce

What steps can reproduce the defect?
Please share the setup, commandline for vstest.console, sample project, target
framework etc.

TFS 2018.2, code coverage enabled. See details below.
Expected behavior

Share the expected output

Enabling code coverage shall show the code coverage, disabling it shall not compute it or hide the results.
Actual behavior

What is the behavior observed?

Enabling code coverage breaks test results.
Diagnostic logs

Please share test platform diagnostics logs. Instructions to collect logs are here.
The logs may contain test assembly paths, kindly review and mask those before sharing.

Code Coverage enabled, see screenshot below:

Code Coverage disabled, see screenshot below:

Logs, see attachment below:
13_Test Assemblies release.Tests.dll;-obj.txt
Environment

Please share additional details about the test environment.
Operating system, Build version of vstest.console

TFS 2018.2, see attached logs for more details. Let me know whether more information is needed.

@MoiMoiDG take a look at issue https://github.com/nunit/nunit3-vs-adapter/issues/519
Nunit does not support running tests with code coverage run while using the vstest platform tool installer.

@ShreyasRmsft: Thank you the reply. I had a look at the linked issue, but I could not find any information to solve my problem.

@MoiMoiDG as of now this hasn't been fixed. We have to go fix it in the Nunit adapter. Until then you may want to use VS instead of the vstestplatformtool installer for running Nunit tests with code coverage

@MoiMoiDG please follow the workaround for now. Will track the issue in the one filed on the NUnit Adapter side

@ShreyasRmsft: Thanks for the reply. I understand to keep the other issue open, but the workaround is not that easy for me, because I would need VS Enterprise on each machine running the tests. Is there any other solution but switching from NUnit to MS Test?


The framework needs to determine the nil structure implementation of actor.Actor

Problem Description:
The go interface structure involves two basic properties: (type, data). At run time, it may be (nil, nil), and mayby be  (actor.Actor, nil). Once the latter situation, it is likely that the system will keep sending *actor.Stopping message , even if we add SUPERVISION.
Code example:
type MessageCreate struct{}
type ChildActor struct {
	name string
}

func (da *ChildActor) Receive(ctx actor.Context) {
	fmt.Printf("childactor receive message [%T], [%+v]. \n", ctx.Message(), ctx.Message())

	//cause panic if childactor is nil
	//because it'will receive *actor.Stoping
	fmt.Printf("it's maby panic.because i want visit my field name=%v /n", da.name)
}
func NewChildActor(name string) *ChildActor {
	//return nil for test
	return nil
}

type FatherActor struct {
}

func NewFatherActor() actor.Actor {
	return &FatherActor{}
}
func (da *FatherActor) Receive(ctx actor.Context) {
	switch ctx.Message().(type) {
	case *actor.Started:
		fmt.Println("Starting, initialize actor here")
	case *actor.Stopping:
		fmt.Println("Stopping, actor is about to shut down")
	case *actor.Stopped:
		fmt.Println("Stopped, actor and its children are stopped")
	case *actor.Restarting:
		fmt.Println("Restarting, actor is about to restart")
	case *MessageCreate:
		fmt.Println("create child actor begin!")

		//In this scenario, the Supervisor's maxNrOfRetries can not take effect
		decider := func(reason interface{}) actor.Directive {
			fmt.Println("handling failure for child")
			return actor.StopDirective
		}
		supervisor := actor.NewOneForOneStrategy(3, time.Second, decider)
		porps := actor.FromInstance(NewChildActor("alex_023")).WithSupervisor(supervisor)
		//use actor.spawn,because want to use supervisor
		actor.Spawn(porps)

		fmt.Println("create child actor over!")
	}
}
func main() {
	props := actor.FromProducer(NewFatherActor)
	pid := actor.Spawn(props)
	time.Sleep(time.Second)
	pid.Tell(&MessageCreate{})

	console.ReadLine()
}

we will get output，and soon, the log data will become very large
2017/08/31 03:48:24 [MAILBOX] [ACTOR] Recovering actor="nonhost/$2" reason="runtime error: invalid memory address or nil pointer dereference" stacktrace="main.(*ChildActor).Receive:21"
2017/08/31 03:48:24 [ACTOR] [SUPERVISION] actor="nonhost/$2" directive="StopDirective" reason="runtime error: invalid memory address or nil pointer dereference"
2017/08/31 03:48:24 [MAILBOX] [ACTOR] Recovering actor="nonhost/$2" reason="runtime error: invalid memory address or nil pointer dereference" stacktrace="main.(*ChildActor).Receive:21"
2017/08/31 03:48:24 [ACTOR] [SUPERVISION] actor="nonhost/$2" directive="StopDirective" reason="runtime error: invalid memory address or nil pointer dereference"
2017/08/31 03:48:24 [MAILBOX] [ACTOR] Recovering actor="nonhost/$2" reason="runtime error: invalid memory address or nil pointer dereference" stacktrace="main.(*ChildActor).Receive:21"
2017/08/31 03:48:24 [ACTOR] [SUPERVISION] actor="nonhost/$2" directive="StopDirective" reason="runtime error: invalid memory address or nil pointer dereference"
2017/08/31 03:48:24 [MAILBOX] [ACTOR] Recovering actor="nonhost/$2" reason="runtime error: invalid memory address or nil pointer dereference" stacktrace="main.(*ChildActor).Receive:21"
2017/08/31 03:48:24 [ACTOR] [SUPERVISION] actor="nonhost/$2" directive="StopDirective" reason="runtime error: invalid memory address or nil pointer dereference"
......

Suggest:
In business development, it is difficult to avoid creating a null pointer actor object, which in turn causes the system to fail.(without kotlin's syntax).  Therefore, it is necessary to add judgment and improve robustness in the framework.
Perhaps, refactor  incarnateActor in the local_context.go  is a good choice:
func (ctx *localContext) incarnateActor() {
	pid := ctx.producer()
	//add actor interface not nil judgement
	if pid == nil || reflect.ValueOf(pid).IsNil() {
		panic("pid is nil")
	}
	ctx.restarting = false
	ctx.stopping = false
	ctx.actor = pid
	ctx.receive = pid.Receive
}

reflect.ValueOf(pid).IsNil()

How much overhead will this add?
I am all for such change, but we should be careful with how much this kind of changes affect spawning performance

There are several ways to create an object instance, like ** FromProducer **, ** FromInstance **, ** WithProducer **. At present, my proposal to intercept the occurrence of the error, but also does bring the performance overhead, which will make my MPB (CPU i5) performance overhead of about 7ns each time.
Look for a better solution!

I think this proposal is missing the point. incarnateActor shouldn't care whether what the actor is, whether it is nil, a pointer, a struct value, or a function. The problem described above can happen in any non-nil actor that insists on panicking. I think the real solution is to make the supervisor give up trying to stop the child.


Response Data Type

I think I found a bug in generate_data.py, line 37:

 add_response_data = int(arguments["response_data"])

This implementation attempts to convert its value to an integer, but the response_data flag is intended to be a boolean.

Thanks for reporting.

Should be fixed now.


Examine verb opens window "That entity doesn't exist"

If you examine a entity that's out of range (a wall behind some others walls).
The shortcut (Shift + Left click) just doesn't open any window.

Can't reproduce.


Design DB migrations and versioning

Right now we just launch all migrations when the APP starts to make sure the DB is up to date https://github.com/KoalaSat/nostros/blob/4d5b93dd2462f7d1ba6f9d68ff259d52f1ae6389/android/app/src/main/java/com/nostros/modules/DatabaseModule.java#L26
This clearly does not scale, and we need to prepare specific services for this which should check the DB version and apply the missing migrations. Also would be good to defined a good (file?) structure so each migration can be clearly spotted.

Is there any opposition to using Room for some built in migration table logic?

I'm not familiar with it @jeffchang5 , but the only limitation is to allow the business logic to continue communicating with the shared SQlite DB

app.py
from flask import Flask
from flask_sqlalchemy import SQLAlchemy
from flask_migrate import Migrate
app = Flask(name)
app.config['SQLALCHEMY_DATABASE_URI'] = 'sqlite:///example.db'
db = SQLAlchemy(app)
migrate = Migrate(app, db)
your app code goes here
???


Update to new fsf-api format with arrays of SPDX identifiers

Moved from SPDX Tools: https://github.com/spdx/tools/issues/141

Resolved in version 2.1.12


Registration listener API changes

Changes the registered() and unregistered() signature to have the information that a registration is replaced by a new one (new registration for the same endpoint).

👍

Integrated in master (commit af8b2fde37c4d5063f9a7fb140b51454d3696751)


FSOC-115 add option to specify the local auth properties

Add flags for appd-pid, appd-pty, and appd-tid.

Codecov Report

Merging #43 (f9e22ce) into main (04b8bdb) will increase coverage by 0.08%.
The diff coverage is 23.80%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   33.16%   33.25%   +0.08%
==========================================
  Files          23       23
  Lines        3048     3079      +31
==========================================
+ Hits         1011     1024      +13
- Misses       1957     1973      +16
- Partials       80       82       +2

Impacted Files
Coverage Δ

cmd/config/set.go
10.27% <0.00%> (-1.27%)
:arrow_down:

cmd/config/types.go
0.00% <0.00%> (ø)

platform/api/call.go
7.55% <0.00%> (-0.35%)
:arrow_down:

platform/api/login.go
16.86% <83.33%> (+16.86%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Loss not logged for 16bit precision and manual optimization

When training a GAN and thus using manual optimization, I include these lines:
self.log("loss_d", loss_d, prog_bar=True)
self.log("loss_g", loss_g, prog_bar=True)

The logging works as intended, both for my logger (W&B) and to the command line progress bar so long as I use 32 bit precision. However, when I use 16 bit precision, no logging occurs to either. I have tried printing the losses, and they appear to be reasonable values and on the correct devices.

I have also tried printing self._results and it appears to sometimes be missing entries when using 16 bit, whereas it always includes all entries in 32 bit. Also disable 16 bit via with torch.cuda.amp.autocast(enabled=False): out of necessity in a couple select parts of the algorithm in case that is relevant.

Hi @timothybrooks fo you have an example to reproduce this behavior?

Its entangled in a large project, but I've extracted a sketch of the training step which is the most relevant portion:

@property
def automatic_optimization(self) -> bool:
    return False

def training_step(...):

    # Discriminator.
    optimizer_idx = 0
    optimizer: optim.Adam = self.optimizers()[optimizer_idx]
    self.toggle_optimizer(optimizer, optimizer_idx)

    loss_d = self.compute_loss_d(...)
    self.log("loss_d", loss_d, prog_bar=True)

    optimizer.zero_grad()
    self.manual_backward(loss, optimizer)
    optimizer.step()
    self.untoggle_optimizer(optimizer_idx)

    # Generator.
    optimizer_idx = 1
    optimizer: optim.Adam = self.optimizers()[optimizer_idx]
    self.toggle_optimizer(optimizer, optimizer_idx)

    loss_g = self.compute_loss_g(...)
    self.log("loss_g", loss_g, prog_bar=True)

    optimizer.zero_grad()
    self.manual_backward(loss, optimizer)
    optimizer.step()
    self.untoggle_optimizer(optimizer_idx)

Portions of code inside compute_loss_d and compute_loss_g disable autocasting. I'm unsure how much of this is needed to reproduce the bug, and whether manual optimization is part of the issue or whether it is simply an issue with mixed precision.

I have this bug as well. I do not find why.

Hey @denadai2 @timothybrooks,
I confirm I can reproduce the bug.
def test_multiple_optimizers_logging(tmpdir):
    """
    Tests that only training_step can be used
    """

    class TestModel(BoringModel):

        def __init__(self):
            super().__init__()
            self.automatic_optimization = False

        def training_step(self, batch, batch_idx):
            # Discriminator.
            optimizer_idx = 0
            optimizer = self.optimizers()[optimizer_idx]
            self.toggle_optimizer(optimizer, optimizer_idx)

            loss_d = self.loss(batch, self.layer(batch))
            self.log("loss_d", loss_d, prog_bar=True)

            optimizer.zero_grad()
            self.manual_backward(loss_d, optimizer)
            optimizer.step()
            self.untoggle_optimizer(optimizer_idx)

            # Generator.
            optimizer_idx = 1
            optimizer = self.optimizers()[optimizer_idx]
            self.toggle_optimizer(optimizer, optimizer_idx)

            loss_g = self.loss(batch, self.layer(batch))
            self.log("loss_g", loss_g, prog_bar=True)

            optimizer.zero_grad()
            self.manual_backward(loss_g, optimizer)
            optimizer.step()
            self.untoggle_optimizer(optimizer_idx)

            import pdb; pdb.set_trace()

        def configure_optimizers(self):
            optimizer = torch.optim.SGD(self.layer.parameters(), lr=0.1)
            optimizer_2 = torch.optim.SGD(self.layer.parameters(), lr=0.1)
            return optimizer, optimizer_2

    model = TestModel()
    model.training_epoch_end = None
    model.val_dataloader = None

    limit_train_batches = 2
    trainer = Trainer(
        default_root_dir=tmpdir,
        limit_train_batches=limit_train_batches,
        limit_val_batches=2,
        max_epochs=1,
        log_every_n_steps=1,
        weights_summary=None,
        gpus=1,
        precision=16,
    )

    trainer.fit(model)

    expected = {'epoch', 'loss_d', 'loss_g'}
    logged = set(trainer.logged_metrics.keys())
    assert expected == logged
    expected = {'loss_d', 'loss_g'}
    logged = set(trainer.progress_bar_metrics.keys())
    assert expected == logged

Hey @timothybrooks,
Should work on master. Mind checking ?
Best,
T.C

my script works :) thx!


fix typo

@machv thanks for the fix. Already wondered why the exception when running the scripts.
Is it still planned to / considered useful to dashboard this telemetry data?


Improve handling of non-200 response codes

Adds a helpful message to the exception thrown in response to non-200 response codes. Additionally, prevents DiskStaticSiteRenderer from swallowing the exception when rendering paths in parallel.

Thanks!

Only noticed because I shot myself in the foot with it :)


[M] Resolve cache

Solves #20 .
Please merge these 2 pull requests together to see the effects.
The reason is, Cloudflare doesn't not cache json file.

Good job!


Module dropdowns should be oriented horizontally

Rather than the current module dropdowns, which display all of the modules in a single column, they should be displayed in a number of rows, with each module type on its own row.

I tested this and have mostly discarded the idea for now. It will be necessary for any dataset that adds more modules (e.g. Bob's), but I found that the wider dropdown window made the UI more awkward to use.


How to check if a given number is even/odd without using Arithmetic operator? in CPP

💥 Proposal
There are many ways to find if a number is even or odd in C++ but before moving into technical details on finding even and odd number in C++ let's what is even and odd number in terms of Mathematics. Any number which is completely divisible by 2 is called even number while number which is not completely divisible by 2 is called odd number.
Have you read the Contributing Guidelines on Pull Requests?
So the way of finding even and an odd number without using arithmetic operator is by using the bitwise operator in C++. In binary format, the even number has there LSB always zero while the odd number has there LSB as 1 by using this information and bitwise & operator we can find if a number is even or odd in C++.  i.e. we use bit manipulation
GSSOC21 ISSUE.

Can i work on this issue? (/assign)

can I solve this issue please assign me. under GSSOC

/assign

/assign


ReportStream Onboarding Documentation

Story
As a hospital or lab, to be able to utilize ReportStream for newborn screening, I need clear documentation to understand the necessary steps for onboarding to ReportStream.
Pre-conditions

[ ] Assumptions of prior or future work that's out of scope for this story

Acceptance Criteria

[ ] Required outcomes of the story

Tasks
Research

[ ] Research work needed to complete the story
[ ] Foundational: High-level research that will support this and future efforts

Engineering

[ ] Engineering work needed to complete the story
[ ] Foundational: Technical runway work to support this and future efforts

Definition of Done

[ ] Documentation tasks completed

[ ] Documentation and diagrams created or updated

[ ] Implementation guide (/ig folder)
[ ] ADRs (/adr folder)
[ ] Main README.md
[ ] Other READMEs in the repo
[ ] If applicable, update the ReportStream Setup section in README.md

[ ] Threat model updated
[ ] API documentation updated
[ ] Source code documentation created when the code is not self-documenting

[ ] Code quality tasks completed

[ ] Logging added where useful
[ ] Code refactored for clarity and no design/technical debt
[ ] Adhere to separation of concerns; code is not tightly coupled, especially to 3rd party dependencies
[ ] Code is reviewed or developed by pair; 1 approval is needed but consider requiring an outside-the-pair reviewer
[ ] Code quality checks passed

[ ] Security & Privacy tasks completed

[ ] Security & privacy gates passed

[ ] Testing tasks completed

[ ] Load tests passed
[ ] Unit test coverage of our code >= 90%

[ ] Build & Deploy tasks completed

[ ] Build process updated
[ ] API(s) are versioned
[ ] Feature toggles created and/or deleted.  Document the feature toggle
[ ] Source code is merged to the main branch

Research Questions

Optional: Any initial questions for research

Decisions

Optional: Any decisions we've made while working on this story

Notes

Optional: Any reference material or thoughts we may need for later reference

Re: Jan 2024 ETOR Strategy Retreat Action Items: Curate prerequisite technical readiness steps PHLs and HCOs can advance independently while they await onboarding availability (and any related dependencies in doing so) - _e.g., data gap analysis templates with sufficient written instruction such that an HCO can document themselves without TA; full connectivity guides with all technical pre-reqs documented so a PHL can determine best option for selected transport protocol; full articulation of the standard payloads supported by ReportStream with expectation that partners will adopt at least 1 standard for orders and 1 for results


Default data driven model - Predictor fails

When an Event.Start is received, the code is executed and the registered simulator fails because of 'theta'. The predictor state is reset, and in that function, where the dictionary is being updated, the code fails as shown below:

have you updated config_model.yml?


nematus and device=cuda versus device=gpu in theano 0.8.2 vs dev

Hi Nematus Team,
Apologies in advance if this is a known issue or if I am misunderstanding something.
For reference, our hardware is an Intel Xeon 1620v3 and a GeForce 1070.
We are able to use nematus quite easily under Debian 8.7, Theano 0.8.2, running:
THEANO_FLAGS=mode=FAST_RUN,floatX=float32,device=gpu ./test_train.sh
and
THEANO_FLAGS=mode=FAST_RUN,floatX=float32,device=gpu ./test_translate.sh
When moving to Theano 0.9.0dev5.dev, this command:
THEANO_FLAGS=mode=FAST_RUN,floatX=float32,device=gpu ./test_train.sh
works fine but results in a message about a deprecated device interface:
WARNING (theano.sandbox.cuda): The cuda backend is deprecated and will be removed in the next release.  Please switch to the gpuarray backend. You can get more information about how to switch at this URL:
 https://github.com/Theano/Theano/wiki/Converting-to-the-new-gpu-back-end%28gpuarray%29

So we use this instead:
THEANO_FLAGS=mode=FAST_RUN,floatX=float32,device=cuda ./test_train.sh
So far, so good.  We see speed improvement from 147 sentences/sec to 204 sentences/sec with device=cuda instead of device=gpu.
However, when we run:
THEANO_FLAGS=mode=FAST_RUN,floatX=float32,device=cuda ./test_translate.sh
we receive the following output:
Translating ../../en-de/in ...
Using cuDNN version 5105 on context None
Mapped name None to device cuda0: GeForce GTX 1070 (0000:02:00.0)
Building f_init... Done
Building f_next.. Done
Process Process-1:
Traceback (most recent call last):
  File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
    self.run()
  File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
    self._target(*self._args, **self._kwargs)
  File "/home/cmc/nmt/nematus/nematus/translate.py", line 72, in translate_model
    seq = _translate(x)
  File "/home/cmc/nmt/nematus/nematus/translate.py", line 52, in _translate
    suppress_unk=suppress_unk, return_hyp_graph=return_hyp_graph)
  File "/home/cmc/nmt/nematus/nematus/nmt.py", line 489, in gen_sample
    ret = f_init[i](x)
  File "/usr/local/lib/python2.7/dist-packages/theano/compile/function_module.py", line 886, in __call__
    storage_map=getattr(self.fn, 'storage_map', None))
  File "/usr/local/lib/python2.7/dist-packages/theano/gof/link.py", line 325, in raise_with_op
    reraise(exc_type, exc_value, exc_trace)
  File "/usr/local/lib/python2.7/dist-packages/theano/compile/function_module.py", line 873, in __call__
    self.fn() if output_subset is None else\
RuntimeError: Invalid value or operation
Apply node that caused the error: GpuAdvancedSubtensor1(Wemb, GpuReshape{1}.0)
Toposort index: 73
Inputs types: [GpuArrayType<None>(float32, (False, False)), GpuArrayType<None>(int64, (False,))]
Inputs shapes: [(85000, 500), (10,)]
Inputs strides: [(2000, 4), (-8,)]
Inputs values: ['not shown', 'not shown']
Outputs clients: [[GpuIncSubtensor{InplaceSet;::, int64:int64:}(GpuAlloc<None>{memset_0=True}.0, GpuAdvancedSubtensor1.0, Constant{0}, ScalarFromTensor.0)]]

But, it is still possible to run it with device=gpu (albeit with the deprecation warning message).
We appreciate any advice you can give us!

could this be the same issue reported here? https://github.com/Theano/libgpuarray/issues/277

It does sound similar.  We have the latest snapshot of libgpuarray (as of yesterday afternoon), but I will verify that.

I tested this with the newest version of Theano and libgpuarray, and the problem seems to be fixed.


lane_context[...] shorthand syntax adds unneeded step output

Not a big deal, but there's another bug introduced by the shorthand lane_context syntax.
Now whenever I use it, it outputs:
--------------------------
--- Step: lane_context ---
--------------------------

Ohhh, nice catch, thanks!

Thanks again, this is fixed now, I'll ship a new version today :+1:

Nice! Continue your awesome work!

Thanks @jeanregisser, it's live now :+1: fastlane] https://github.com/KrauseFx/fastlane/releases/tag/1.10.0


Force workspace removal

Is your feature request related to a problem? Please describe.
Workspaces that have an issue with their provider target might be left hanging on the Daytona Server.
Describe the solution you'd like
We should enable the user to "force" remove workspaces. Forced workspace removal would ignore provider errors and proceed to remove the workspace from the database. We should warn the user that provider resources might not be removed.
Additional context
Related to #423

/bounty $40

/attempt #576


Multi rig support

Hello,
it seems like multiple rigs aren't supported yet? During this year, I tried to export multiple objects that are rigged (two characters eg) into .glTF, but always stumbling into issues.
Trying out different settings, at the moment I'm in a status where only one action/rig works in the viewer/importer - the other rigs are ignored.
I'm testing my exported scenes in the donmccurdy viewer - so do you think it's something exporter related or is it more an issue of three.js?
Until now, I wasn't able to find a related issue yet, so thanks in advance and best regards.

This sounds like https://github.com/KhronosGroup/glTF-Blender-Exporter/issues/232 – the exporter can only handle one rig per scene currently. Multiple actions are supported though.

Could you check on https://github.com/KhronosGroup/glTF-Blender-IO in Blender 2.8 as well, and if the problem recurs, attach a .blend file to help us reproduce the issue?

The multiple action support works out phantastic for me.
So I hotfixed it by converting the rig animation into morph targets, but would be supper handy to have it in the future.
I also checked it on the 2.8 beta - exporting multiple rigs there causes weird mesh distortion when the animation is played as well as an offset in rotation as it seems. But I had no time investigate that further yet.
I'll attach the .blend as well as the .gltf files I exported from 2.79 and 2.8. Thank you for your support!
multiRig Files.zip

Confirmed this bug is occurring in latest version of Blender 2.8 and glTF-Blender-IO, so I'm transferring this issue to that repository.
tested on https://sandbox.babylonjs.com/
(this model exports with duplicate bone names, so testing in three.js is currently problematic)


#1020 Collection components for component composition

Type of Change

[x] Feature (non-breaking change that adds functionality)

Description
TBD
How the Changes Have Been Tested
TBD
Checklist

[x] I have performed a self-review of my own code
[ ] I have added tests that prove it is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Related issue number is linked in pull request title
[ ] I have added documentation that describes my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have rebased my branch on top of the latest develop branch

Related Issue
Closes #
Additional Notes

Note: b2b5221 introduces need for #999 to be completed. While we could work around this for now, I'd prefer to use #999 to immediately do this correctly.


TODO: Generalize the playbook file names

Set all environment names in below format:
bes-<cve-details>-<category-of-vulnerability>-<author>-playbook
Inputs -> cve details, category, author
optional: environment name

@jobyko I believe the env name should be required.

@asa1997
Expecting a model something like this
bes-----playbook

@jobyko should start with besman-**** instead of bes-****

@asa1997
besman-----playbook
Hope its fine now, eventhough initial discussion focused on 'bes-' prefix
@sumodgeorge  @panickervinod

The reason being besman-*** is that I am trying to use bes update command to pull down the playbook files as well and the update command recognises files only with besman- prefix.

Closing as outdated


initial fix for some issues

fix issued raised by CRW

fix issued raised by CRW
#94 #44 #43 #93 #92 #90 #84 #80 #69 #73

#82 #87 #77 #81 #70

#41 #93 #43 #45 #47 #49 #50 #48 #57 #59 #60 #69 #73 #80 #84 #90 #70 #77 #81 #82 #87


msbot blows away the bot file even if you say 'no' when asked to clone

Tool
Name: msbot
Version: 2.0.5-61
OS: Windows 10
Describe the bug
When doing clone services if you answer "no" it will blow away the .bot file being created.  It should wait to create it until you confirm your intention.
To Reproduce
Steps to reproduce the behavior:

...Create a foo.bot file and put stuff in it.
...msbot clone services  --name foo.bot
...Say 'n' when asked to proceed
...foo.bot file is changed.

Expected behavior
An existing .bot file should not be changed until you confirm the clone.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
[bug]

Addressed via #804


Voter nodes don't vote on ChainHeadEvent (New Block)

A node will only vote on a ChainHeadEvent if the node is synced with the chain. In the 7 node example the nodes do not set there sync status to true as they do not ever undertake a chain download.
The maker node has the --singleblockmaker flag set so its synced flag is set to true.
The chain progresses because the maker node votes twice and the voting nodes vote when their deadline timer expires and a CreateBlock event occurs.
Expected behaviour can be achieved by setting the --singleblockmaker flag to all nodes.

Is this still an issue? I know there were similar issues in the main Quorum repository.
If it is, do you mind re-submitting this as an issue in https://github.com/jpmorganchase/quorum/issues ?