Support XSS protection

Similarly to markdown-it, we should trim links which try to execute something on the system.
The implementation is actually pretty similar, using similar regexes for filtering links.
All kind of links and images should be filtered by default.

All implemented flavours have useSafeLinks = true constructor parameter now.
Custom link generating providers can be made safe with an LinkGeneratingProvider.makeXssSafe extension.


chore: Update README.md

What this PR does / why we need it:
Update README.md to include all modules of the collection and keep module descriptions in sync.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

None

/lgtm

/lgtm

/approve


None gradients when using tf gradient tape

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
binary
TensorFlow version
tf 2.17.0
Custom code
Yes
OS platform and distribution
Linux Ubuntu 24.04 LTS
Mobile device
No response
Python version
3.11.9
Bazel version
binary
GCC/compiler version
binary
CUDA/cuDNN version
12.3 (pip install tensorflow[and-cuda)==2.17)
GPU model and memory
RTX A4500 laptop, 16 gigs
Current behavior?
I tried to load a trained model using tensorflow and keras in order to compute some saliency maps. To do so, I need to compute the gradients with respect to the inputs. However, it returns None gradients whereas it worked fine before, e.g., with tf 2.10.
A reprex with the model weights, a datafile and a minimal version of the code can be find using the following google drive link:
Standalone code to reproduce the issue
https://drive.google.com/file/d/1fcind0XWxdghlKvN237y0L177JbEgOcV/view?usp=sharing

Relevant log output
No response

Hi @Senantq ,
I tried to run your code on Colab using TF v2.17, but it is asking for a directory. Could you please provide the path related to your issue?
Thank you!


Reference Altme in the walletconnect sdk as we cannot launch walletconnect from the smartphone

App submitted to wallet connect. Review should be done at the end of week 31


rawtherapee: 5.0-r1 -> 5.2

Motivation for this change
Update to the latest version of rawtherapee
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Also added some flags found in http://rawpedia.rawtherapee.com/Linux#Compile_RawTherapee

Fixed!

Works well for me. Rebased into master in 572361f3960758d77bc69c810c797e842d4af51b. Thanks for the contribution!


Branch update

@rultor release tag is 0.0.14

@rultor release tag is 0.0.14

@bugdea1er OK, I will release it now. Please check the progress here

@rultor release tag is 0.0.14

@bugdea1er Done! FYI, the full log is here (took me 9min)


BINARY TO DECIMAL CONVERSION IMPLEMENTED SUCCESSFULLY

Have you read the Contributing Guidelines on Pull Requests?
Yes !
Description
I have implemented the solution of issue DECIMAL TO BINARY CONVERSION
I would request @HarshCasper , @ankitaggarwal23 , @bhav09 to please review my PR.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
No :)
Fixes #4281

@ananddasani Don't do such type of things mentioning other PR in the same PR.

@ananddasani Don't do such type of things mentioning other PR in the same PR.

Don't push more than one code file in a single PR.

@ankitaggarwal23 but there is only one code file
i have deleted the second code file ......
(which was added due to issue was already present but in other directory , which was not suppose to be there :(     )

Okay

@ananddasani don't worry open a new one and don't link other pr in the same PR. We will review

@ananddasani don't worry open a new one and don't link other pr in the same PR. We will review

sure


Add Server Sent Event Feature

Create the new function in Context class for send event from server to front. Reference: #91

Thanks @7agustibm, but how would you send the second event?

Hello @tipsy, with this improvement it works better and you can send the second event more easily. But I believe it's necessary add uuid for EventSourceEmitter to detect different clients. Maybe, adding the path-paramether or cookie to the EventSourceEmitter, it can be identified different clients and send only one client message.

Thanks for the update @7agustibm. Where did you find this code? The implementation should be in Kotlin rather than Java, and the code style is very different from Javalin. Maybe Jetty has an example you can adapt?

https://github.com/jetty-project/jetty-eventsource-servlet/wiki

The code is an adaptation of the jetty project and another implementation that I have from NodeJS. In this improvement it works similar that websocket method. If you like this new improvement I will add tests, and I'll adapt the code to the javalin style. If you want, you can add the documentation.

Yes, please add tests. I like the improvement, but I think it will have to be merged after 2.0. This feature requires a bit of patience with the API design.

Here is the unit test. Only the integration tests are missing.
What do you think is missing in the API?

What do you think is missing in the API?

I don't really know. I've never worked with SSE, so I would like to set up a project/write a tutorial before merging, so I'm sure that the API is good.

Greetings, everyone
Any updates on this one?

@MelonCode I've been postponing this because I don't know that much about SSE. It would help if you could review the PR.

SSE would be huge for our use-case -- requirement to write a web service w/ Kotlin. I took a very quick peek at the PR's tests and they do seem legit. I will take a closer look post holidays.
@tipsy check out the MDN for SSE https://developer.mozilla.org/en-US/docs/Web/API/Server-sent_events/Using_server-sent_events - the PHP example is super simple and demos SSE perfectly (you do not need to know PHP to get it).
The key concepts are the Content-Type text/event-stream and no-cache headers, and keeping the connection open. A response can simply contain a line "event: SOME_EVENT_NAME". To include a data payload follow it with a line "data: {SOME_JSON}". Other fields include "retry:", an int value for the reconnection time in case of a disconnect, and "id:", a message ID value. The client simply establishes a connection and listens for events re EventSource API (https://developer.mozilla.org/en-US/docs/Web/API/EventSource).
Taking a look at javalin for the first time its very impressive how concise and clean it is, nice work. Sockets seem very elegant. SSE would be a cherry on top!

SSE would be huge for our use-case -- requirement to write a web service w/ Kotlin. I took a very quick peek at the PR's tests and they do seem legit. I will take a closer look post holidays.

Would be great if you could review the PR, @firxworx. I really want someone who will be actively using this to be involved in the implementation.

Taking a look at javalin for the first time its very impressive how concise and clean it is, nice work. Sockets seem very elegant. SSE would be a cherry on top!

Thanks! Some of that is probably due to the fact that I haven't merged much that I don't use myself. I don't use SSE, which is why I've been putting this off. I have some time now though, so I'll see if I can create a simple SSE service to get more familiar with it.

Good work @7agustibm, sorry this has taken so long to review. A few notes:
API
Current in PR
app.sse("/sse") { sse ->
    sse.onOpen { eventSource ->
        eventSource.sendEvent("connect", "Connected!")
        eventSources.add(eventSource)
    }
    sse.onClose { eventSource -> eventSources.remove(eventSource) }
}

My suggestion
Since we use onConnect and Session with WebSocket, I'm thinking we should use that here too:
app.sse("/sse") { sse ->
    sse.onConnect { session ->
        session.sendEvent("connect", "Connected!")
        eventSourceSessions.add(session)
    }
    sse.onClose { session -> eventSourceSessions.remove(session) }
}

There is something strange with the methods available to sse and eventSource. They're both the same interface, so you can do:
sse.onOpen { eventSource ->
    eventSource.sendEvent("connect", "Connected!") // send to connecting client?
    eventSource.onOpen {} // what does this do?
}
sse.sendEvent("connect", "Connected!") // send to who?

Sse and EventSource have to be two difference interfaces with only the appropriate methods.
Implementation

There is a pathParams() method. I would remove this and give access to the Context. The handler is implemented on a standard app.get endpoint, so Context could easily be available.
I would rename EmitterImpl and EventSourceImpl to Emitter and EventSource, and get rid of the interfaces. Javalin has no other interace/impl constructs. This would also mean getting rid of the mock-tests, and rely fully on integration tests.
Check if it's possible to use https://github.com/jetty-project/jetty-eventsource-servlet/wiki instead of writing all the custom code. The dependency can be found here: https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-servlets
There are several things named SSEThing. Javalin follow strict camelcasing, so it should be SseThing

Thank you @tipsy! In this holidays, I will be able to change.

@tipsy please, review all the changes I have made. I have not placed the library that you asked me to complicate the implementation and it was easier to leave the code as it was. I hope that functionality is clearer.

I'll have a look at the Jetty dependency I linked earlier before reviewing more.

@tipsy it looks like the jetty implementation doesn't support the id or retry params re SSE.
In particular I think they are worthy use-cases to support, especially as I think the id param would be key to writing production-worthy SSE handling with javalin.
I think support would be very easy to add to the current implementation created by @7agustibm
(with many thanks for taking on SSE!). They're simply optional fields to send along in a response with the appropriate prefix (e.g. id: ...), i.e. same concept as sending along the event field (e.g. event:...).
Example Use-Case of ID Param
Check out the section titled "Handling Connection Recovery on Server-Sent Events" on the following comprehensive Auth0 blog post:
https://auth0.com/blog/developing-real-time-web-applications-with-server-sent-events/ . Examples are in NodeJS+Express but should be familiar enough.

Another note re the jetty implementation + this PR, it looks like jetty handles a documented SSE case not covered by this javalin implementation and that there's a test for it as well testMultiLineData() in EventSourceServletTest.java.
Case: multiline (delimited w/ newlines) data string is sent by server without an accompanying event. Each line is sent back to the client prefixed with "data: ".
See "Introduction" section of https://www.w3.org/TR/eventsource/ which covers this case of sending "data:" lines back to the client without being grouped as part of an event.
Also see https://github.com/jetty-project/jetty-eventsource-servlet

@7agustibm agreed the id field isn't necessary for a basic SSE implementation. It should be optional to include an id along with an event. This can be an important feature for production-grade SSE and it is covered as part of the W3C spec. Thank-you for considering my comments and being open to adding support 👍 :)
Re the data: lines, yes.
Also from my understanding of the "Introduction" section of https://www.w3.org/TR/eventsource/ it looks like that should be possible to simply send "data:" lines back to the client without an event (I think the client's assumption is that standalone data lines are related to the most recently received event).
If that's correct, maybe even something like sse.sendData("hi\nhi").
I don't think this is as significant personally but I am bringing it up because the jetty example takes multiline data seriously enough that they have implemented it as a case and have a test-case for it; see EventSourceServletTest.java there's testMultiLineData() at:
https://github.com/jetty-project/jetty-eventsource-servlet/blob/master/src/test/java/org/eclipse/jetty/servlets/EventSourceServletTest.java

Note that SseHandler.kt sets response.addHeader("Connection", "close") which I believe is an error. Every example re SSE that I've read sets the Cache-Control header to no-cache.
I think that the implementation should pass the following test (e.g. add to TestSse.java):
import com.mashape.unirest.http.*;
//...
    @Test
    public void headers() {
        TestUtil.test( ((server, httpUtil) -> {

            server.sse( ssePath, sse -> sse.sendEvent( event, data ) );

            final Headers headers = httpUtil.sse(ssePath).get().getHeaders(); // Headers extends HashMap<String, List<String>>

            assertTrue(headers.containsKey("Connection"));
            assertTrue(headers.containsKey("Cache-Control"));
            assertTrue(headers.containsKey("Content-Type"));

            final String connection = headers.get("Connection").get(headers.get("Connection").size() - 1).toLowerCase();
            final String contentType = headers.get("Content-Type").get(headers.get("Content-Type").size() - 1).toLowerCase();
            final String cacheControl = headers.get("Cache-Control").get(headers.get("Cache-Control").size() - 1).toLowerCase();

            assertTrue(connection.contains("keep-alive"));          // should be "keep-alive" NOT "close"
            assertTrue(cacheControl.contains("no-cache"));          // should be sent
            assertTrue(contentType.contains("text/event-stream"));  // passes
            assertTrue(contentType.contains("charset=utf-8"));      // passes

        }) );
    }

Another test-case to check the HTTP response is 200:
import static org.hamcrest.Matchers.equalTo;
import static org.junit.Assert.assertThat;
//...
    @Test
    public void http_status() {
        TestUtil.test( ((server, httpUtil) -> {
            server.sse( ssePath, sse -> sse.sendEvent( event, data ) );
            final int status = httpUtil.sse(ssePath).get().getStatus();
            assertThat(status, equalTo(200));
        }) );
    }

Starting to look really good @7agustibm. I would add the tests and include @firxworx's suggestions too.

I have added the tests of @firxworx and when we have these details closed I will add the requested features.

@7agustibm I tried running the tests, and each request times out at 30 seconds on my machine. Do they behave the same on your machine?

Yes, it's. Because making the change in TestUtils increased the execution time.

@firxworx I had thought of putting the id by default, what do you think?

@7agustibm You need to close the connection manually, now each connection times out at 30s. The tests should take 1 second max.

The problem is Unirest. Looked at him.

We also have okhttp in the project for when Unirest isn't good enough, they probably have something for SSE.

I have changed to OkHttp, but the problem is in closing the server that takes 30 seconds even if the SSE connection has been closed. I think it could be an SSE handler bug.

@7agustibm re id by default.
I think it should be optional. I learned about SSE recently over the past year myself. Most of the tutorials I read (and many of the possible use-cases I can think of) do not necessarily require id's.
I think it would be "un javalin" to force a dev to make up some id if they weren't intending on actually implementing it.
Likewise, for devs that require the id feature for their API/SSE implementation (including checking for the Last-Event-Id HTTP header, re-issuing messages, etc) then it should be supported and easy to include along with a given event.
Since I'm not a kotlin guy, I can't suggest the best way to do this since I'm not sure of the most idiomatic approach.


Error: [$injector:itkn] Incorrect injection token! Expected service name as string, got function ()

Version v0.5.9 of ng-inspector that was released yesterday has a critical bug in the directive detection code with the potential to break AngularJS applications. This issue has been fixed in v0.5.10.
For the applications affected, this is what the console shows:
Error: [$injector:itkn] Incorrect injection token! Expected service name as string, got function ()
http://errors.angularjs.org/1.3.15/$injector/itkn?p0=function%20()
    at REGEX_STRING_REGEXP (angular.min.js?bust=undefined:63)
    at Object.invoke (angular.min.js?bust=undefined:4189)
    at angular.min.js?bust=undefined:6525
    at forEach (angular.min.js?bust=undefined:323)
    at Object.<anonymous> (angular.min.js?bust=undefined:6523)
    at Object.invoke (angular.min.js?bust=undefined:4204)
    at Object.enforcedReturnValue [as $get] (angular.min.js?bust=undefined:4056)
    at Object.invoke (angular.min.js?bust=undefined:4204)
    at angular.min.js?bust=undefined:4021
    at Object.getService [as get] (angular.min.js?bust=undefined:4162)

If you have auto-updates enabled (the default behaviour) Chrome will update the extension upon restart. You may also manually trigger the update by navigating to chrome://extensions/ and clicking "Update extensions now".
I'm leaving this issue open for a bit, in hopes that people affected will search for the error and find this message.
Related: http://stackoverflow.com/questions/29653779/angular-itkn-error-caused-by-directives-defined-with-function-outside-array/29666410?noredirect=1

I was running into this and wondering why my app had suddenly broken! Thanks for the update. :+1:

same problem for me also.can anybody resolve it


Can't install on Debian bookworm with python 3.

Any suggestions on how to install responder on Debian 12.5 / python 3.11.2? I have an old project, responder was working fine with py3.10.6

  error: subprocess-exited-with-error

  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> [36 lines of output]
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.linux-x86_64-cpython-311
      creating build/lib.linux-x86_64-cpython-311/httptools
      copying httptools/_version.py -> build/lib.linux-x86_64-cpython-311/httptools
      copying httptools/__init__.py -> build/lib.linux-x86_64-cpython-311/httptools
      creating build/lib.linux-x86_64-cpython-311/httptools/parser
      copying httptools/parser/errors.py -> build/lib.linux-x86_64-cpython-311/httptools/parser
      copying httptools/parser/__init__.py -> build/lib.linux-x86_64-cpython-311/httptools/parser
      running egg_info
      writing httptools.egg-info/PKG-INFO
      writing dependency_links to httptools.egg-info/dependency_links.txt
      writing requirements to httptools.egg-info/requires.txt
      writing top-level names to httptools.egg-info/top_level.txt
      reading manifest file 'httptools.egg-info/SOURCES.txt'
      reading manifest template 'MANIFEST.in'
      adding license file 'LICENSE'
      writing manifest file 'httptools.egg-info/SOURCES.txt'
      copying httptools/parser/parser.c -> build/lib.linux-x86_64-cpython-311/httptools/parser
      warning: build_py: byte-compiling is disabled, skipping.

      running build_ext
      building 'httptools.parser.parser' extension
      creating build/temp.linux-x86_64-cpython-311
      creating build/temp.linux-x86_64-cpython-311/httptools
      creating build/temp.linux-x86_64-cpython-311/httptools/parser
      creating build/temp.linux-x86_64-cpython-311/vendor
      creating build/temp.linux-x86_64-cpython-311/vendor/http-parser
      x86_64-linux-gnu-gcc -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g
-fwrapv -O2 -fPIC -I/home/princess/.local/share/virtualenvs/grapho-server-ZnSZrAOm/include -I/usr/include/python3.11
-I/tmp/pip-install-rztb6o0p/httptools_a44308e2f9824e2e942a95b1cf098c6c/vendor/http-parser -c httptools/parser/parser.c -o
build/temp.linux-x86_64-cpython-311/httptools/parser/parser.o -O2
      httptools/parser/parser.c:212:12: fatal error: longintrepr.h: No such file or directory
        212 |   #include "longintrepr.h"
            |            ^~~~~~~~~~~~~~~
      compilation terminated.
      error: command '/usr/bin/x86_64-linux-gnu-gcc' failed with exit code 1

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for httptools
  error: subprocess-exited-with-error

  × Running setup.py install for httptools did not run successfully.
  │ exit code: 1
  ╰─> [38 lines of output]
      running install
      /home/princess/.local/share/virtualenvs/grapho-server-ZnSZrAOm/lib/python3.11/site-packages/setuptools/command/install.py:34:
SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
        warnings.warn(
      running build
      running build_py
      creating build
      creating build/lib.linux-x86_64-cpython-311
      creating build/lib.linux-x86_64-cpython-311/httptools
      copying httptools/_version.py -> build/lib.linux-x86_64-cpython-311/httptools
      copying httptools/__init__.py -> build/lib.linux-x86_64-cpython-311/httptools
      creating build/lib.linux-x86_64-cpython-311/httptools/parser
      copying httptools/parser/errors.py -> build/lib.linux-x86_64-cpython-311/httptools/parser
      copying httptools/parser/__init__.py -> build/lib.linux-x86_64-cpython-311/httptools/parser
      running egg_info
      writing httptools.egg-info/PKG-INFO
      writing dependency_links to httptools.egg-info/dependency_links.txt
      writing requirements to httptools.egg-info/requires.txt
      writing top-level names to httptools.egg-info/top_level.txt
      reading manifest file 'httptools.egg-info/SOURCES.txt'
      reading manifest template 'MANIFEST.in'
      adding license file 'LICENSE'
      writing manifest file 'httptools.egg-info/SOURCES.txt'
      copying httptools/parser/parser.c -> build/lib.linux-x86_64-cpython-311/httptools/parser
      warning: build_py: byte-compiling is disabled, skipping.

      running build_ext
      building 'httptools.parser.parser' extension
      creating build/temp.linux-x86_64-cpython-311
      creating build/temp.linux-x86_64-cpython-311/httptools
      creating build/temp.linux-x86_64-cpython-311/httptools/parser
      creating build/temp.linux-x86_64-cpython-311/vendor
      creating build/temp.linux-x86_64-cpython-311/vendor/http-parser
      x86_64-linux-gnu-gcc -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g
-fwrapv -O2 -fPIC -I/home/princess/.local/share/virtualenvs/grapho-server-ZnSZrAOm/include -I/usr/include/python3.11
-I/tmp/pip-install-rztb6o0p/httptools_a44308e2f9824e2e942a95b1cf098c6c/vendor/http-parser -c httptools/parser/parser.c -o
build/temp.linux-x86_64-cpython-311/httptools/parser/parser.o -O2
      httptools/parser/parser.c:212:12: fatal error: longintrepr.h: No such file or directory
        212 |   #include "longintrepr.h"
            |            ^~~~~~~~~~~~~~~
      compilation terminated.
      error: command '/usr/bin/x86_64-linux-gnu-gcc' failed with exit code 1

I've been able to build with tihs workaround
cython = "==3.0.10"
httptools = "==0.6.1"
responder = {editable = true, ref = "e9613500daf2432af5efd4910168112675004d22", git = "git+https://github.com/taoufik07/responder.git"}


[Material 3] Introduce new large and medium AppBar variants

Use case
Allow developers that are using Material 3 to have a correctly styled large/medium AppBars
Proposal
Introduce new variants to AppBar that allow for a larger title text that then collapses into the standard size.
See Material 3 spec at https://m3.material.io/components/top-app-bar/overview
https://user-images.githubusercontent.com/48603081/137813089-3ef62fef-d0cf-49dd-b0b3-9c3ce354268e.mp4

Prompt! When will this be available?

@darrenaustin please create a Cherry-pick request using the issue template.  The process can be found in the wiki.  Will be removing the CP: Review label cc\ @CaseyHillers @godofredoc


GM's garbage collector doesn't quickly clean up orphaned lights

Need to add a proper .Destroy() method.

I solved this issue by adding a cleanup event and changing visibility:
light.visible = false;

https://github.com/JujuAdams/Bulb/commit/b4cb7f9be6e87e75f66b7e8a43256c270d6df8a8


About post processing

Thanks for your great work!
I notice EMU3 uses post  processing like video stabilization and super-resolution. I wonder the presented results and released model are post processed or not, and the ablations of the post processing. Thanks.

The video stabilization and super-resolution are separate models and we do not release these two models at this time. The presented video results are all processed with stabilization and super-resolution models.

Thanks for your reply. Can you show the ablation results that are not processed with stabilization or super resolution?


Support for animated GIFs

Wordpress still doesn't support resizing animated GIFs https://core.trac.wordpress.org/ticket/28474, but maybe Glide can?

Glide uses Intervention under the hood, and resizing animated GIFs is not supported. See https://github.com/Intervention/image/issues/42. This is a limitation of the GD library, not Glide or Intervention. It might be possible if you use the ImageMagick driver, but I've never tested it.


Support win32 with native call PR

37518be support win32 with native call / added webapp fixture with native DLL call
4b91e0d added more logs around loading dll
a85a999 added note to enable32bit flag

@rabadiw Thank you for this feature enhancement. We've accepted the PR but, like we've discussed, we found the following bit of functionality more suited for the hwc-buildpack itself. Moving it there would be more consistent with Cloud Foundry patterns and would improve testability. We'll move forward with communicating with the buildpack team to get that amended.
https://github.com/cloudfoundry/hwc/blob/a85a999/main.go#L41-L56


Docs: Added Google Cloud Function to External OAuth Clients List

Summary
Adding a link to a new Google Cloud Function with Python  External OAuth Client to the Documentation
I created a new External OAuth Client running on Google Cloud Functions with Python for use in a lightweight open-source, community-driven project and would like to add it to the list in the Netlify CMS Documentation. Another user found it useful, so figured others may as well!
Test plan
Updated Website markdown only. Confirmed via running local website only.

Looks like the build finished successfully on Netlify, but some status checks are still pending. Looking into it.

That's odd, tried to make just a surgical change and follow the contributing guidelines, but this is my first contribution, so let me know if there's something I need to change.

FYI, force push is due to a rebase with the master branch

That's odd, tried to make just a surgical change and follow the contributing guidelines, but this is my first contribution, so let me know if there's something I need to change.

No worries, this is our fault. Will get this merged soon


Executor exploration

Executor handles errors, and in cases of successful api return, transforms the response type.
Executor is injected as an instance into repositories.
Logger is injected as an instance into Executor. All api failures are now logged properly.
Logger is no longer directly injected into any repository.


Performance tests

Would be useful to have these in master if we want to test performance of different branches
Test classes are in #if UNITY_2019_2_OR_NEWER block so should not cause compile errors with 2018.
2019 projects will need to add "com.unity.test-framework.performance": "1.2.6-preview", to the package/manifest/json

Currently to view test results from multiple branches you need to copy the results entry in %AppData%\..\LocalLow\Mirror\Mirror\PerformanceTestResults.json and re-add it to the array after running the 2nd test and change the TestName

2019 projects will need to add "com.unity.test-framework.performance": "1.2.6-preview", to the package/manifest/json

then we should add those to the packagemanager manfiest too :)

manifest.json isnt in git, probably because of Packages line in the .gitignore

Split up PR, see https://github.com/vis2k/Mirror/pull/1645 https://github.com/vis2k/Mirror/pull/1646 https://github.com/vis2k/Mirror/pull/1647 https://github.com/vis2k/Mirror/pull/1648


[KYUUBI #979] Introduce AbstractFrontendService and KyuubiFrontendService

Why are the changes needed?

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #980 (e67e37a) into master (f1ae664) will decrease coverage by 0.03%.
The diff coverage is 76.19%.

@@             Coverage Diff              @@
##             master     #980      +/-   ##
============================================
- Coverage     80.77%   80.74%   -0.04%
  Complexity       11       11
============================================
  Files           146      148       +2
  Lines          5389     5406      +17
  Branches        636      638       +2
============================================
+ Hits           4353     4365      +12
- Misses          660      663       +3
- Partials        376      378       +2

Impacted Files
Coverage Δ

...n/scala/org/apache/kyuubi/service/Serverable.scala
50.00% <ø> (+5.55%)
:arrow_up:

...rg/apache/kyuubi/engine/spark/SparkSQLEngine.scala
70.58% <50.00%> (-0.63%)
:arrow_down:

...pache/kyuubi/service/AbstractFrontendService.scala
66.66% <66.66%> (ø)

...g/apache/kyuubi/server/KyuubiFrontendService.scala
76.92% <76.92%> (ø)

.../apache/kyuubi/service/ThriftFrontendService.scala
97.00% <100.00%> (ø)

.../scala/org/apache/kyuubi/server/KyuubiServer.scala
51.28% <100.00%> (+1.28%)
:arrow_up:

...ain/scala/org/apache/kyuubi/engine/EngineRef.scala
76.11% <0.00%> (-1.50%)
:arrow_down:

...org/apache/kyuubi/ha/client/ServiceDiscovery.scala
45.52% <0.00%> (-0.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ae664...e67e37a. Read the comment docs.

@yaooqinn


Re-Calculate free space after download/install game

i notice that free space is not updated after installing the game

by default the .pkg file is removed after installing, so the free space shouldn't change


Upgrade rack and rails to address security issues

upgrade to Rack 1.5.4 and Rails 4.1.11 to address:

CVE-2015-3225
CVE-2015-3226
CVE-2015-3227

For the record, this change stopped db:schema:load depending on the environment https://github.com/rails/rails/commit/5d6bb89f809766aeef99d05dfb86faf5a14af40b


Merge cells in a row

How can I merge two or more cells in a specific row with custom TableDataAdapter?

Hi @ansshkki,
unfortunately there is no way to merge cells.
Kind regards,
Ingo


implement abstract message sending retry

Overview / Motivation
ConnectionPool manages the open connection we have, we might Dial and get a new connection which will be closed later we'll have another connection with the same peer and we decide to keep his.
this causes one of the initiators to cancel his procedure because the connection is stale. we need to figure out the connection is stale as soon as possible and maybe abstract a retry that tries a new connection or tries to locate another existing connection before giving up on the procedure.
The Task
Implement retries on sending messages which consider connections closing meanwhile and retrying.
this aims to solves that a protocol that requests sending a message will not get a timeout if the connection is closed because of connections conflict. ( we will seamlessly retry sending on the other connection)
Implementation Notes
TODO: Add links to relevant resources, specs, related issues, etc...
One possible solution is to supply connections only from ConnectionPool and wrap them in a way that tries finding a new connection on a message failure (at least once for now) before returning an error.
Time Estimation
1.5 days (12 hours)
Contribution Guidelines
Important: Issue assignment to developers will be by the order of their application and proficiency level according to the tasks complexity. We will not assign tasks to developers who have'nt introduced themselves on our Gitter dev channel

Introduce yourself on go-spacemesh dev chat channel - ask our team any question you may have about this task
Fork branch develop to your own repo and work in your repo
You must document all methods, enums and types with godoc comments
You must write go unit tests for all types and methods when submitting a component, and integration tests if you submit a feature
When ready for code review, submit a PR from your repo back to branch develop
Attach relevant issue to PR

Still working on it

Hi,
I am really sorry that I was inactive for the last 10 days. I had an interview in London for which I was out of town for 3 days and I had my college mid semester exams following that. Hence, I did not have any time to commit to the project. I am starting work now. Currently understanding through the ConnectionPool module

@antonlerner I went through the ConnectionPool module and the structure stores pending connections. We also have the list of current connections. So we can set up an asynchronous function to periodically dial to every connection in the pool and if the connection is stale/broken, we can close that and start a new connection and add it to the pending questions.  Will this work?

@g-laz77 , Upon sending a message SendMessage we retrieve the connection form the ConnectionPool, though there is no promise that this connection will be still open when we finish our processing. connections might be swapped inside the ConnectionPool, we want SendMessage to succeed even if the connection was swapped during the method. This is about SendMessage dealing with the async changes that might happen in ConnectionPool.
right now if anything happens to the connection (swapped or removed). we just return a message that SendMessage was failed. but an active connection might be in ConnectionPool or easily created.
keep in mind that replacing the connection might result in restructuring the message since the session was probably changed as well.

@y0sher So, I went through the SendMessage which calls sendMessageImpl where swarm establishes a session and opens a connection with the peer having the destination public key by calling GetConnection(fetches or creates one if there don't exist a connection to the address which is associated with the remote public key). Even if the connections swap in the ConnectionPool, won't the peer public key to which the message is being sent to, not change? Thus(sorry if it's a repititive doubt), isn't GetConnection dealing with finding an active connection or creating one, or is it about dealing with it once GetConnection is called and the connection might be stopped before the rest of 'sendMessageImpl' is executed completely(success or fail)

We discovered that (mostly in test) connections could be established between two peers exactly at the same time resulting in 2 sessions and connections (with the same keys) ConnectionPool and handles that by closing one of them. the connection created at GetConnection that might the connection left in the ConnectionPool. this will result in a failure to get response even though there is a valid connection. we don't want protocols to implement that retry or backoff. we want swarm and ConnectionPool to check if there's another valid connection retransmit the message.

So if I write a method for ConnectionPool that checks the number of connections to the same address in the connections. This method can be called in SendMessageImpl once GetConnection has been called, so that we can check if 2 simultaneous connections have been established. Once we know there are more than one connections, we can use either based on which one is active by checking if the connection and session is active. If there is an error with one connection, the other can be used.

@y0sher Will that work?

Not really, the connection pool handles removing duplicate connections, but it might happen only after connection was achieved, also there may be other reasons our connection got disconnected. currently we have an async retry in swarm using GetConnection when a connection is closed.
this still won't help protocols that use SendMessage and get a stale connection, what we won't is that cpool/swarm will retry sending the message for them once before returning an error.
that way SendMessage will always send the message if it's possible. even if it was replaced or closed during SendMessage

@gitcoinbot I am still working on this. The PR is being reviewed


Add more user logs

Use LOGGER.info more often. These will appear at

Currently, I am waiting for the summary. How many hours should I wait?

I've added progress indication for this.
Should I add LOGGER.info too?

Do you have a screenshot? Here, it renders as follows:

LOGGER.info is nice. We can still turn it into LOGGER.debug if users start complaining.
Currently, it is hard to see what's happening.

No, I mean, I've added progress indication: https://github.com/InAnYan/jabref/issues/101
What kind of LOGGER.info should I add and where?

No, I mean, I've added progress indication: #101

That issue is about indexing. Here, I talk about "Processing".

What kind of LOGGER.info should I add and where?

I report from a user perspective.
At each time, a thing could last more than 10 seconds, there should be a LOGGER.info. (This is the poor man's solution for progress, but also offering some details to allow users to understand, what is going on)

Model download (This relates to https://github.com/InAnYan/jabref/issues/105)
Model download finished  (This relates to https://github.com/InAnYan/jabref/issues/105)
Sending a file for indexing to the AI provider: File {} is sent to {}. Show the URL. (This is this issue)
Sending a file for summarization to the AI provider: File {} is sent to {}. Show the URL. (This is this issue)
Sending a question to the AI provider: Request sent to {}. Show the URL. -- Maybe, this can be LOGGER.debug as this does not cause huge waiting issues.

More motivation: I am now waiting for a long time for "Downloading...", but there is nothing transferred:

`

How can I know what is going wrong?
With some more logging, I hope, it can be known.

What do you think about this: https://github.com/JabRef/jabref/commit/f79f87462b527a70cfa0db697ad1b16b88a0eb5f ?
(Hope this time I sent you the right commit :) )

If possible, add the citation key to the log message.
Two reasons:

As a user, I don't rember half an hour later what I did (I think, I wrote that somewhere else 😅)
As user, I work in parallel with multpile documents, it is not clear, which log message correlates to which action

INFO: Summary of the file was generated successfully
INFO: Sending request to AI provider to summarize a chunk
INFO: Summarizing chunks (1 pass)

Line 2 should also include the URL as written in my last comment above (https://github.com/InAnYan/jabref/issues/95#issuecomment-2269233231)
Good example:
INFO: Finished summarization task for entry Corti_2009

Should that URL be full API endpoint? I don't think there is a way to extract it. Moreover, it's a POST request, so nothing fancy in the URL.
What I can show is only the API base URL

Added more in: https://github.com/JabRef/jabref/pull/11430/commits/3b2887b389d96c2328a3d4c3021e1a69f1f38734

What I can show is only the API base URL

Base URL is good enough!
This contributes to transparency which data is sent to where.

Okay then, I'll close the issue. Base URL is shown


Glob api route is not prerendered when used by a useFetch

Environment
<EMAIL_ADDRESS>nuxt/content
Reproduction
https://stackblitz.com/edit/github-njygor?file=server%2Fapi%2Fpackages%2F[name].ts
Describe the bug
I could do something wrong And any resemblance with unjs/website is coincidental. :)
Imagine you have 2 pages:

/packages.vue, which list packages
/packages/[name].vue

Imagine you have 1 API in the server folder:

api/[name].ts which return a number

In your [name].vue page, you call the API using await useFetch('/api/' + name).
To build the application, you use npm run generate in order to render it statically.
Then, use npx serve .output/public and open the app.
Where is the bug?
 If you go to a package page from the packages list page, fetch will return a 404.
The API is not prerendered even when adding a route rules to /api/** and since we are statically generated our site, there is no more API.
I think it works fine when coming directly on the package page because Nuxt replace the API call by a function. But because of that, Nitro never received the call and do not save the API call.
If, in the config, you replace the glob by a URL like /api/hello, everything works fine but I'm having more than 40 pages and I don't want to do it manually for every package.
Additional context
No response
Logs
No response

Would you try enabling experimental.payloadExtraction manually? If that doesn't work, then could you check whether all the package pages are prerendered?
Nuxt shouldn't fetch the api route at all if payload extraction is enabled because a payload should be created for that page for client-side navigation.

Would you try enabling experimental.payloadExtraction manually? If that doesn't work, then could you check whether all the package pages are prerendered?
Nuxt shouldn't fetch the api route at all if payload extraction is enabled because a payload should be created for that page for client-side navigation.
If that doesn't work, can I reproduce this on unjs/website?

Here a reproduction, https://stackblitz.com/edit/github-4leygb?file=nuxt.config.ts but everything works fine. 😑 Will continue to investigate.

And I don't need to add the api route to prerender since I generate my project.

@danielroe I've got a reproduction. It happens with nuxt/content : https://stackblitz.com/edit/github-njygor?file=server%2Fapi%2Fpackages%2F[name].ts

But content is generated in _payload

index.html without nuxt/content

index.html with nuxt/content

In the second, there is no _payload.

@farnabaz I'm tagging you since it could be related to @nuxt/content!

The HTTP call is made even when application is generated.


NRF52840 dongle RCP via UART

I've successfully compiled and used RCP through USB on the NRF52840 PCA10059 dongle to connect to the border router.
Now I'm testing the same hardware but instead using an UART connection by selecting UART_trans instead of USB_trans:
script/build nrf52840 UART_trans -DOT_BOOTLOADER=USB -DOT_THREAD_VERSION=1.2
While it compiles and flashes fine I have no success in making it working. I've changed the transport_config.h file to disable hardware flow control and also defined my RX and TX pins, but using a serial converter to USB for testing the UART communications yields no response from the RCP.
`
#ifndef UART_HWFC_ENABLED
#define UART_HWFC_ENABLED 0
#endif
#ifndef UART_PIN_TX
#define UART_PIN_TX 31
#endif
#ifndef UART_PIN_RX
#define UART_PIN_RX 29
#endif
`
Using pyspinel with the dongle when flashed with the USB variant works (at least the version command: OPENTHREAD/thread-reference-20200818-1524-g7ec658e47; NRF52840; Feb 16 2022 11:57:20), but not with the combination UART+converter. No answer whatsoever.
The openthread commit used is 7ec658e47a39e1c3c55651e584e0748b259d2d4d
Any ideas? Thanks for the help!

I have tested UART transport using an nRF52840-DK and everything works as expected. If you have access to an nRF52840-DK, you could try that as well.
I would also suggest posting on Nordic DevZone to see if there are any other ideas.
Maybe @edmont has some ideas as well.

I've build the RCP from the Openthread coprocessor sample from the Zephyr main repo and from the Nordic Connect SDK (it is the same, but Zephyr version is different), and it works fine using the UART. But if this repo works with the DK it might be something related with mine configuration (UART pins?).


LinkedIn Ads Manager Auth Connector

Existing LinkedIn connector works fine for the Ads Manager module
Proxy server listening on :4444
##GET
Proxying request: GET api.linkedin.com/rest/adAccounts/513144939/adCampaignGroups

##POST
Proxying request: POST api.linkedin.com/rest/adAccounts/513144939/adCampaignGroups/691114844

Closes #284

Do you mind completing the integration testing for LinkedIn + LinkedIn Ads so that we can wrap it up in this PR? (since there are no new things being added here)

@RajatPawar hi, as requested, the integration testing is completed, please kindly advise if anything else is required.


Config is not applied when set  proxied = false

Steps to reproduce

Create cloudflare.Record (Typescript) with proxied = false
Run:  pulumi up -y --diff

Expected: Proxy status = DNS only
Actual: Proxy status = Proxied

I tested this today with
import * as pulumi from "@pulumi/pulumi";
import * as cloudflare from "@pulumi/cloudflare";

const example = new cloudflare.Zone("example", {
    accountId: "48364b099cc965f71761d67bc5314bd4",
    zone: "test-mikhail-example.com",
});

const example2 = new cloudflare.Record("example", {
  zoneId: example.id,
  name: "example",
  value: "<IP_ADDRESS>",
  type: "A",
  ttl: 3600,
  proxied: false,
});

but it seems to be working correctly. I'll assume the issue has been fixed since 2021.


feat: bump mapbox-gl version

Resolves https://github.com/WiredSolutions/react-azure-maps/issues/58


Update who-is-using.md

@tuyenhuynh Thanks for the PR and for using the operator! Please sign the CLA and I will merge it.


Incorrect QueueAdapter used in console

Hello :wave:
I have been using this gem and just found out that some surprising behaviour. So, I have been moving an application from using a different queue backend to SolidQueue. For now, only some jobs (and queues) are using SolidQueue and I added mission_control-jobs to start tracking that and added this line to application.rb: config.mission_control.jobs.adapters = [:solid_queue] (since the other queue backend doesn't have an integration and it is not worth adding it).
But because of the code in  https://github.com/rails/mission_control-jobs/blob/main/lib/mission_control/jobs/console/context.rb and in https://github.com/rails/mission_control-jobs/blob/fe9db51fb3b3c04c4cd97d79480546c64db278d7/lib/mission_control/jobs/engine.rb#L82-L85, it means that, when I run a rails console all jobs are run under the SolidQueue adapter (this could be problematic if, for example, I still only have workers for a given queue and not others).
I think a safer option could be to disable all this added logic to the console via a configuration like show_console_help or a check on https://github.com/rails/mission_control-jobs/blob/fe9db51fb3b3c04c4cd97d79480546c64db278d7/lib/mission_control/jobs/engine.rb#L82 like application.servers.first.name == ActiveJob::Base.queue_adapter_name (ensuring that the current queue adapter and the queue adapter in mission control is the same).

Oh yes! We hit this too, two weeks ago, and I didn't have time to fix it. I'll get a fix soon.

Got a PR ready to fix this. I've just removed that logic. It was added for #41, but now that I've looked at it again, it wasn't necessary. There's no need to connect to a server in the console because not setting one just works; it just uses the default queue adapter for each job, which is what you want unless you have multiple adapters and you want to explicitly connect to one of them, which you can always do via connect_to.

Thanks for handling it :bow:


Task.using(run_after=..) fails if value is an instance of datetime.timedelta

Hi,

Python 3.12
django==5.1.4
django-tasks==0.6.0

DEP-0014 says the run_after argument can be an instance of datetime or a timedelta. https://github.com/django/deps/blob/main/accepted/0014-background-workers.rst#deferring-tasks
But passing a timedelta fails with the error AttributeError: 'datetime.timedelta' object has no attribute 'utcoffset'.
The current code assumes run_after is a datetime.
https://github.com/RealOrangeOne/django-tasks/blob/dd1eb52b07c3af9a8e21f44cd7bb8e0c32e7faa6/django_tasks/backends/base.py#L78
My demo code is a Django view like:
import datetime

from django.http.response import HttpResponse
from django_tasks import task

@task
def calc(a, b):
    return a + b

def home(request):
    t = calc.using(run_after=datetime.timedelta(minutes=1)).enqueue(2, 2)

    return HttpResponse(repr(t), content_type="text/plain")

And here's the full traceback when a request is made:
Internal Server Error: /
Traceback (most recent call last):
  File "/layers/google.python.pip/pip/lib/python3.12/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/layers/google.python.pip/pip/lib/python3.12/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/tests/demo/demo/views.py", line 19, in home
    t = calc.using(
        ^^^^^^^^^^^
  File "/layers/google.python.pip/pip/lib/python3.12/site-packages/django_tasks/task.py", line 116, in using
    return replace(self, **changes)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/layers/google.python.runtime/python/lib/python3.12/dataclasses.py", line 1588, in replace
    return obj.__class__(**changes)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 9, in __init__
  File "/layers/google.python.pip/pip/lib/python3.12/site-packages/django_tasks/task.py", line 84, in __post_init__
    self.get_backend().validate_task(self)
  File "/layers/google.python.pip/pip/lib/python3.12/site-packages/django_tasks/backends/base.py", line 78, in validate_task
    if task.run_after is not None and not timezone.is_aware(task.run_after):
                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/layers/google.python.pip/pip/lib/python3.12/site-packages/django/utils/timezone.py", line 221, in is_aware
    return value.utcoffset() is not None
           ^^^^^^^^^^^^^^^
AttributeError: 'datetime.timedelta' object has no attribute 'utcoffset'

(This traceback is from code running on Google App Engine standard, but I am pretty sure that isn't a factor in this case.)
This is a cool project.
Thanks,
David

This functionality was removed in cf41181c978a7b87d8d77683fcd419be79596fc9.
In short, the issue is that it's not immediately obvious when the timedelta is evaluated, and in what timezone. If you need timedelta support, it'd be fairly simple to add a small wrapper yourself. I'm not opposed to adding it back, but it needs more thought and design for the side-effects.
As an aside, the DEP should not be considered the canonical reference documentation - take a look at the project's README.


python311Packages.boschshcpy: 0.2.67 -> 0.2.68

Diff: https://github.com/tschamm/boschshcpy/compare/0.2.67...0.2.68
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 257587 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.bosch_shc
python310Packages.boschshcpy
python310Packages.boschshcpy.dist
python311Packages.boschshcpy
python311Packages.boschshcpy.dist


ci: Upgrade semantic-release

Upgrade semantic-release

🎉 This change has been released in version 1.4.0


the pybullet has no texture

hey, I want to know, when I add the argument use_pb_gui = True，the scene is loaded very slow ,and there is no texture, just the bule、yellow and red color.

The pybullet viewer is extremely slow at loading large textures outside of iGibson. Due to an agreement with our asset provider, all of our textures are encrypted. We provide an encrypted texture renderer in iGibson, but pybullet does not have this ability.


Server based on protoactor with address <IP_ADDRESS> doesn't work

Describe the bug
I made server and client apps with help of protoactor library as the transport. When server has real address (e.g. <IP_ADDRESS>), then all work well. When server has <IP_ADDRESS> address, then interaction between server and client doesn't work.
To Reproduce
I have the following definition with messages for protobuf:
syntax = "proto3";
option go_package = "./messages";
package messages;

message RequestTypeA {
    string Data = 1;
}

message ResponseTypeA {
    string Data = 1;
}

I have the following definition of server app:
package main

import (
	"fmt"
	console "github.com/asynkron/goconsole"
	"github.com/asynkron/protoactor-go/actor"
	"github.com/asynkron/protoactor-go/remote"
	"os"
	"protoActorRemote/messages"
)

const host = "<IP_ADDRESS>"
//const host = "<IP_ADDRESS>"
const port = 23333
const name = "ProtoactorProblemExample"

func main() {
	system := actor.NewActorSystem()
	config := remote.Configure(host, port)
	remoter := remote.NewRemote(system, config)
	remoter.Start()
	props := actor.PropsFromFunc(func(context actor.Context) {
		switch msg := context.Message().(type) {
		case *actor.Started:
			fmt.Printf("Started server with address \"%v\"\n", context.Self().Address)
		case *actor.Stopping:
			fmt.Printf("Stopping server with address \"%v\"\n", context.Self().Address)
		case *actor.Stopped:
			fmt.Printf("Stopped server with address \"%v\"\n", context.Self().Address)
		case *actor.Restarting:
			fmt.Printf("Restarting server with address \"%v\"\n", context.Self().Address)
		case *messages.RequestTypeA:
			fmt.Printf("RequestTypeA with data \"%v\" from client with address \"%v\" (server address = \"%v\")\n", msg.Data, context.Sender().Address, context.Self().Address)
			context.Send(context.Sender(), &messages.ResponseTypeA{Data: msg.Data + ".resultA"})
		default:
			fmt.Printf("Other message %v\n", msg)
		}
	})
	_, spawnError := system.Root.SpawnNamed(props, name)
	if spawnError != nil {
		fmt.Printf("Spawn error \"%v\"\n", spawnError)
		os.Exit(-1)
	}
	fmt.Println("Server started")
	_, _ = console.ReadLine()
}

I have the following definition of client app:
package main

import (
	"fmt"
	console "github.com/asynkron/goconsole"
	"github.com/asynkron/protoactor-go/actor"
	"github.com/asynkron/protoactor-go/remote"
	"os"
	"protoActorRemote/messages"
	"time"
)

const host = "<IP_ADDRESS>"
const port = 34444
const serverAddress = "<IP_ADDRESS>:23333"
const serverName = "ProtoactorProblemExample"

func main() {
	system := actor.NewActorSystem()
	config := remote.Configure(host, port)
	remoter := remote.NewRemote(system, config)
	remoter.Start()
	serverPID := actor.NewPID(serverAddress, serverName)
	response, requestError := system.Root.RequestFuture(serverPID, &messages.RequestTypeA{Data: "IDDQD"}, 1*time.Second).Result()
	if requestError != nil {
		fmt.Printf("Request error \"%v\"\n", requestError)
		os.Exit(-1)
	}
	fmt.Printf("Response \"%v\"\n", response)
	_, _ = console.ReadLine()
}

Let's server has <IP_ADDRESS> address (defined in host const in the server app definition). When we start server first and after that - client, then we have the following output on server:
2023/03/22 19:44:56 INFO  [REMOTE]      Starting remote with address address="<IP_ADDRESS>:23333"
2023/03/22 19:44:56 INFO  [REMOTE]      Started Activator
2023/03/22 19:44:56 INFO  [REMOTE]      Started EndpointManager
2023/03/22 19:44:56 INFO  [REMOTE]      Starting Proto.Actor server address="<IP_ADDRESS>:23333"
Server started
Started server with address "<IP_ADDRESS>:23333"
2023/03/22 19:45:20 DEBUG [REMOTE]      EndpointReader received connect request message=server_connection:{SystemId:"CxAjoFiLPXHXCXp5yoUPJW"  Address:"<IP_ADDRESS>:34444"}
RequestTypeA with data "IDDQD" from client with address "<IP_ADDRESS>:34444" (server address = "<IP_ADDRESS>:23333")
2023/03/22 19:45:20 DEBUG [REMOTE]      EndpointSupervisor spawning EndpointWriter and EndpointWatcher address="<IP_ADDRESS>:34444"
2023/03/22 19:45:20 INFO  [REMOTE]      Started EndpointWriter. connecting address="<IP_ADDRESS>:34444"
2023/03/22 19:45:20 INFO  [REMOTE]      Started EndpointWatcher address="<IP_ADDRESS>:34444"
2023/03/22 19:45:20 DEBUG [REMOTE]      Received connect response fromAddress="<IP_ADDRESS>:34444"
2023/03/22 19:45:20 INFO  [REMOTE]      EndpointWriter connected address="<IP_ADDRESS>:34444" cost=3.5336ms
2023/03/22 19:45:23 INFO  [REMOTE]      EndpointReader failed to read error="rpc error: code = Canceled desc = context canceled"
2023/03/22 19:45:23 DEBUG [REMOTE]      EndpointReader removed active endpoint from endpointManager
2023/03/22 19:45:23 ERROR [REMOTE]      EndpointWriter lost connection address="<IP_ADDRESS>:34444" error="rpc error: code = Unavailable desc = error reading from server: read tcp <IP_ADDRESS>:58812-><IP_ADDRESS>:34444: wsarecv: An existi
ng connection was forcibly closed by the remote host."
2023/03/22 19:45:23 DEBUG [REMOTE]      EndpointManager received endpoint terminated event, removing endpoint message=&{<IP_ADDRESS>:34444}
2023/03/22 19:45:23 DEBUG [REMOTE]      Sending EndpointTerminatedEvent to EndpointWatcher ans EndpointWriter address="<IP_ADDRESS>:34444"
2023/03/22 19:45:23 DEBUG [REMOTE]      Handling array wrapped terminate event address="<IP_ADDRESS>:34444" msg=&{<IP_ADDRESS>:34444}
2023/03/22 19:45:23 INFO  [REMOTE]      EndpointWatcher handling terminated address="<IP_ADDRESS>:34444" watched=0
2023/03/22 19:45:23 DEBUG [REMOTE]      EndpointWriter stopped address="<IP_ADDRESS>:34444"
2023/03/22 19:45:23 INFO  [REMOTE]      EndpointWriter closing client connection address="<IP_ADDRESS>:34444"

and on client:
2023/03/22 19:50:57 INFO  [REMOTE]	Starting remote with address address="<IP_ADDRESS>:34444"
2023/03/22 19:50:57 INFO  [REMOTE]	Started Activator
2023/03/22 19:50:57 INFO  [REMOTE]	Started EndpointManager
2023/03/22 19:50:57 INFO  [REMOTE]	Starting Proto.Actor server address="<IP_ADDRESS>:34444"
2023/03/22 19:50:57 DEBUG [REMOTE]	EndpointSupervisor spawning EndpointWriter and EndpointWatcher address="<IP_ADDRESS>:23333"
2023/03/22 19:50:57 INFO  [REMOTE]	Started EndpointWriter. connecting address="<IP_ADDRESS>:23333"
2023/03/22 19:50:57 INFO  [REMOTE]	Started EndpointWatcher address="<IP_ADDRESS>:23333"
2023/03/22 19:50:57 DEBUG [REMOTE]	Received connect response fromAddress="<IP_ADDRESS>:23333"
2023/03/22 19:50:57 INFO  [REMOTE]	EndpointWriter connected address="<IP_ADDRESS>:23333" cost=2.8485ms
2023/03/22 19:50:57 DEBUG [REMOTE]	EndpointReader received connect request message=server_connection:{SystemId:"FabFGb96KT8i4gSdog9VX7"  Address:"<IP_ADDRESS>:23333"}
Response "Data:"IDDQD.resultA""

Let's server has <IP_ADDRESS> address (defined in host const in the server app definition). When we start server first and after that - client, then we have the following output on server:
2023/03/22 19:53:07 INFO  [REMOTE]      Starting remote with address address="[::]:23333"
2023/03/22 19:53:07 INFO  [REMOTE]      Started Activator
2023/03/22 19:53:07 INFO  [REMOTE]      Started EndpointManager
2023/03/22 19:53:07 INFO  [REMOTE]      Starting Proto.Actor server address="[::]:23333"
Server started
Started server with address "[::]:23333"
2023/03/22 19:53:18 DEBUG [REMOTE]      EndpointReader received connect request message=server_connection:{SystemId:"JgBn2wcP3TNW4HwP9Gm9vg"  Address:"<IP_ADDRESS>:34444"}
2023/03/22 19:53:18 DEBUG [REMOTE]      EndpointSupervisor spawning EndpointWriter and EndpointWatcher address="<IP_ADDRESS>:23333"
2023/03/22 19:53:18 INFO  [REMOTE]      Started EndpointWatcher address="<IP_ADDRESS>:23333"
2023/03/22 19:53:18 INFO  [REMOTE]      Started EndpointWriter. connecting address="<IP_ADDRESS>:23333"
2023/03/22 19:53:18 DEBUG [REMOTE]      EndpointReader received connect request message=server_connection:{SystemId:"5UKtdU7DkjnAovWJ65fsvQ"  Address:"[::]:23333"}
2023/03/22 19:53:18 DEBUG [REMOTE]      Received connect response fromAddress="<IP_ADDRESS>:23333"
2023/03/22 19:53:18 INFO  [REMOTE]      EndpointWriter connected address="<IP_ADDRESS>:23333" cost=3.2992ms
2023/03/22 19:53:19 INFO  [REMOTE]      EndpointReader failed to read error="rpc error: code = Canceled desc = context canceled"
2023/03/22 19:53:19 DEBUG [REMOTE]      EndpointReader removed active endpoint from endpointManager

and on client:
2023/03/22 19:54:09 INFO  [REMOTE]	Starting remote with address address="<IP_ADDRESS>:34444"
2023/03/22 19:54:09 INFO  [REMOTE]	Started Activator
2023/03/22 19:54:09 INFO  [REMOTE]	Started EndpointManager
2023/03/22 19:54:09 INFO  [REMOTE]	Starting Proto.Actor server address="<IP_ADDRESS>:34444"
2023/03/22 19:54:09 DEBUG [REMOTE]	EndpointSupervisor spawning EndpointWriter and EndpointWatcher address="<IP_ADDRESS>:23333"
2023/03/22 19:54:09 INFO  [REMOTE]	Started EndpointWatcher address="<IP_ADDRESS>:23333"
2023/03/22 19:54:09 INFO  [REMOTE]	Started EndpointWriter. connecting address="<IP_ADDRESS>:23333"
2023/03/22 19:54:09 DEBUG [REMOTE]	Received connect response fromAddress="<IP_ADDRESS>:23333"
2023/03/22 19:54:09 INFO  [REMOTE]	EndpointWriter connected address="<IP_ADDRESS>:23333" cost=4.1111ms
Request error "future: timeout"

Anyone can see the following:

When server has <IP_ADDRESS> address, interaction between server and client has place: client sends RequestTypeA message on server and receives ResponseTypeA message from server.
When server has <IP_ADDRESS> address, interaction between server and client doesn't have place: anyone can see the following error on client - Request error "future: timeout"
When server has <IP_ADDRESS> address, anyone can see only one connect request: 2023/03/22 19:45:20 DEBUG [REMOTE]      EndpointReader received connect request message=server_connection:{SystemId:"CxAjoFiLPXHXCXp5yoUPJW"  Address:"<IP_ADDRESS>:34444"}
When server has <IP_ADDRESS> address, anyone can see two connect requests: 2023/03/22 19:53:18 DEBUG [REMOTE]      EndpointReader received connect request message=server_connection:{SystemId:"JgBn2wcP3TNW4HwP9Gm9vg"  Address:"<IP_ADDRESS>:34444"}  and 2023/03/22 19:53:18 DEBUG [REMOTE]      EndpointReader received connect request message=server_connection:{SystemId:"5UKtdU7DkjnAovWJ65fsvQ"  Address:"[::]:23333"}

Expected behavior
Server must work correctly and equally for both case of addresses - real (e.g., <IP_ADDRESS>) and <IP_ADDRESS>. Moreover, I made the same example on .NET with help of protoactor.NET library and this example work correctly for both case of addresses - real (e.g., <IP_ADDRESS>) and <IP_ADDRESS>.
Screenshots
None
Additional context
None

For <IP_ADDRESS>, you need to also set an "AdvertisedHost", so that remote systems know what to connect to. as you cannot remotely connect to <IP_ADDRESS>.

I know about AdvertisedHost property, but i can't use it because my server is situated inside the Docker container (and server doesn't know anything about Docker container address). Moreover, the same example on .NET (whish used protoactor.NET library) works correctly (when server has <IP_ADDRESS> address) without usage of AdvertisedHost property.
If you look on server output (when server has <IP_ADDRESS> address), you can see, that server receives connect request from client (EndpointReader received connect request message=server_connection:{SystemId:"JgBn2wcP3TNW4HwP9Gm9vg"  Address:"<IP_ADDRESS>:34444"}). But after that server receives another connect request from itself (EndpointReader received connect request message=server_connection:{SystemId:"5UKtdU7DkjnAovWJ65fsvQ"  Address:"[::]:23333"}). It seems, that this is reason of this issue.

@rogeralsing
I made example with AdvertisedHost as you advised me:
I have the following definition of server app:
package main

import (
	"fmt"
	console "github.com/asynkron/goconsole"
	"github.com/asynkron/protoactor-go/actor"
	"github.com/asynkron/protoactor-go/remote"
	"os"
	"protoActorRemote/messages"
)

const host = "<IP_ADDRESS>"
const port = 23333
const name = "ProtoactorProblemExample"

func main() {
	system := actor.NewActorSystem()
	config := remote.Configure(host, port, remote.WithAdvertisedHost("localhost:23333"))
	remoter := remote.NewRemote(system, config)
	remoter.Start()
	props := actor.PropsFromFunc(func(context actor.Context) {
		switch msg := context.Message().(type) {
		case *actor.Started:
			fmt.Printf("Started server with address \"%v\"\n", context.Self().Address)
		case *actor.Stopping:
			fmt.Printf("Stopping server with address \"%v\"\n", context.Self().Address)
		case *actor.Stopped:
			fmt.Printf("Stopped server with address \"%v\"\n", context.Self().Address)
		case *actor.Restarting:
			fmt.Printf("Restarting server with address \"%v\"\n", context.Self().Address)
		case *messages.RequestTypeA:
			fmt.Printf("RequestTypeA with data \"%v\" from client with address \"%v\" (server address = \"%v\")\n", msg.Data, context.Sender().Address, context.Self().Address)
			context.Send(context.Sender(), &messages.ResponseTypeA{Data: msg.Data + ".resultA"})
		default:
			fmt.Printf("Other message %v\n", msg)
		}
	})
	_, spawnError := system.Root.SpawnNamed(props, name)
	if spawnError != nil {
		fmt.Printf("Spawn error \"%v\"\n", spawnError)
		os.Exit(-1)
	}
	fmt.Println("Server started")
	_, _ = console.ReadLine()
}

When I start server first and after that - client, then I have the following output on server:
2023/03/23 16:44:29 INFO  [REMOTE]      Starting remote with address address="localhost:22333"
2023/03/23 16:44:29 INFO  [REMOTE]      Started Activator
Server started
2023/03/23 16:44:29 INFO  [REMOTE]      Started EndpointManager
2023/03/23 16:44:29 INFO  [REMOTE]      Starting Proto.Actor server address="localhost:22333"
Started server with address "localhost:22333"
2023/03/23 16:44:34 DEBUG [REMOTE]      EndpointReader received connect request message=server_connection:{SystemId:"8Y7ty56Y37qEU5GgQLtUpn"  Address:"<IP_ADDRESS>:34443"}
2023/03/23 16:44:34 DEBUG [REMOTE]      EndpointSupervisor spawning EndpointWriter and EndpointWatcher address="<IP_ADDRESS>:22333"
2023/03/23 16:44:34 INFO  [REMOTE]      Started EndpointWriter. connecting address="<IP_ADDRESS>:22333"
2023/03/23 16:44:34 INFO  [REMOTE]      Started EndpointWatcher address="<IP_ADDRESS>:22333"
2023/03/23 16:44:34 DEBUG [REMOTE]      EndpointReader received connect request message=server_connection:{SystemId:"Q2eebY9vXBwFkhUzS4ddWz"  Address:"localhost:22333"}
2023/03/23 16:44:34 DEBUG [REMOTE]      Received connect response fromAddress="<IP_ADDRESS>:22333"
2023/03/23 16:44:34 INFO  [REMOTE]      EndpointWriter connected address="<IP_ADDRESS>:22333" cost=3.7093ms
2023/03/23 16:44:35 INFO  [REMOTE]      EndpointReader failed to read error="rpc error: code = Canceled desc = context canceled"
2023/03/23 16:44:35 DEBUG [REMOTE]      EndpointReader removed active endpoint from endpointManager

You can see, that i have the similar output with 2 connect requests:

from client: EndpointReader received connect request message=server_connection:{SystemId:"8Y7ty56Y37qEU5GgQLtUpn"  Address:"<IP_ADDRESS>:34443"}
from server itself: EndpointReader received connect request message=server_connection:{SystemId:"Q2eebY9vXBwFkhUzS4ddWz"  Address:"localhost:22333"}

As the result, interaction between client and server doesn't work. So, usage of AdvertisedHost property doesn't help me for this issue.

@rogeralsing
has comments?


VirtualBox appliance doesn't start graphic environment

Issue description
Importing the Virtualbox appliance from https://nixos.org/releases/nixos/latest-ova-x86_64-linux and importing it into Virtualbox doesn't work as expected. It should launch an X11 environment but the window manager fails to start.
It's important because probably this is one of the main ways people give NixOS a try.
Steps to reproduce
Follow the steps in https://nixos.org/nixos/download.html#virtualbox-appliances  start the VM. No graphic environment.

confirmed with nixos-16.03.941.af412f2-x86_64-linux.ova. there is no graphical login.

I also observed this.  Bizarrely. the third time I re-imported the ova into virtualbox, the KDE login manager appeared.
But sudo nix-channel --update && sudo nixos-rebuild switch kills the graphical enviroment!
The reason I was re-importing the ova was that after the above upgrade command, sudo stopped working.  I would get a message along the lines of Who are you?  Unknown user demo.  And I couldn't log back in.  This persisted across reboots.  But this failure stopped at the same time the KDE enviroment started working.

Confirmed that, I install nixos as guest os on windows7 virtualbox5.0.22.
When I upgrade to 16.03.931.2f1174b, X11 is failed.
but rollback to 16.03.902.a24903b, it's fine again, some package might break.
nix-channel information：
~ $ sudo nix-channel --list
nixos https://nixos.org/channels/nixos-16.03
nixpkgs http://nixos.org/channels/nixpkgs-unstable

@alxempirical there is a ticket for that demo user behavior  https://github.com/NixOS/nixpkgs/issues/14970

Fixed in 76f346d61d537f5bbe4f365f9f659df7024602b4 for 16.09, already fixed in master.


hugo server hang for windows_386 binary

Since the new hugo server serves the generated site from memmap files, using windows_386 version of hugo on windows_amd64 machine will hang on fs.Create().
Maybe add a reminder on the release note or documentation for this issue so people can avoid using windows_386 binary on windows_amd64 Windows machine.

https://github.com/spf13/afero/issues/23 should fix this issue.

:+1:

Hi @spf13,
As more people are hit by this bug, e.g. #1628, I have taken the liberty of adding a big note at the top of the v0.15 release note and renaming the windows_386 (32-bit) zip file.  When you have time, could you please rebuild and upload hugo_0.15_windows_386.zip, to replace the old hugo_0.15_windows_386_32-bit-only.zip?  Many thanks!

See also https://discuss.gohugo.io/t/hugo-server-returns-runtime-error-on-armhf/2293


"crash" with EthereumTransaction.fromRaw()

I try to get EthereumTransaction from transaction raw data :
 let transactionString = "0xa9059cbb00000000000000000000000083b0b52a887a4c05429ee6d4619afeb8007c1a330000000000000000000000000000000000000000000000000001c6bf52634000" let transactionData = Data.fromHex(transactionString)! let rawTransaction = EthereumTransaction.fromRaw(transactionData) // Crash
but at the last line, I've had something like a crash, but without errors, warnings, etc... An application just close and debugger detached from the process. After debugging I found that code stop working at RLP.decode(_ raw: Data), at line let (of, dl, t) = decodeLength(bytesToParse), it just stop working here and exit from app without any errors, also after this "crash" I can't run my app again, only after reopen simulator. Any idea about this?

I will check this one today

Thank you.

I fixed that. Now it returns nil

Thank's a lot!


Custom cellpose models support

I propose to add a clear method of importing your own trained cellpose models.

Hi dimethylglymaxim, you are right I never thought of custom cellpose models, good suggestion!
I will be on vacation for the next two weeks but I will definitely do it when I am back!

Woah, thanks) Looking forward to that. This whole project look SO PROMISING

Hi @dimethylglymaxim, I just released Cell-ACDC v1.2.4rc35 with custom cellpose models. In the models dialogue, you can now choose the model called cellpose_custom and you will get the same parameters as cellpose except for the model name where you will have to insert a path to your custom model.
Please, upgrade with the command pip install --upgrade cellacdc (after activating the env).
Since I don't have a custom cellpose model I could not test it, so let me know if it works, thanks!

Hello @ElpadoCan thank you for your work. I tried to test it, and it doesn't work, unfortunately. After selecting all the parameters for custom cellpose model, I get this in the console:
Initializing Segmentation module v1.2.4rc35...
Loading data...
Importing cellpose_custom...
Processing Y:/Data/VPs/Position_1/Images
Loading Position_1\Images\vp=1_s01_visible_aligned.npz...
Segmentation file vp=1_s01_segm_1.npz...
Traceback (most recent call last):
File "C:\Users\Username\Miniconda3\lib\site-packages\cellacdc\segm.py", line 249, in run
-----------------------------------------    lab = self.model.segment(img, **self.segment2D_kwargs)
Image shape = (10, 1862, 1455)
File "C:\Users\Username\Miniconda3\Lib\site-packages\cellacdc\models\cellpose_custom\acdcSegment.py", line 25, in segment
labels = self.cp.model.segment(Segmenting with cellpose_custom...
AttributeError: 'CellposeModel' object has no attribute 'segment'

Ok, thanks for reporting this. Since I don't have a custom model to test with I didn't get that far.
Could you please share the custom cellpose model that you are using? You can send it to my Google drive account<EMAIL_ADDRESS>or with any other method that you prefer, thanks!

Thank you very much for sending me the model, it was very helpful!
I released v1.2.4rc36 which should have the fix. Please update with pip install --upgrade cellacdc and let me know if it works, thanks!

Thank you, everything works as intended!


adding support for generic service discovery

idea
adding support for a generic SD (service discovery) interface like using the same format as file_sd_config but as SD over http.
usecase
you have a existing SD (service discovery) solution not supported and like to write a small service to bridge yours to still work with prometheus.
implementation
/targets GET  with a payload of json same as file_sd_config
[
  {
    "targets": [ "node:9104" ],
    "labels": {
      "env": "prod",
      "job": "service"
    }
  }
]

@krasi-georgiev of corse it can. be solved with file sd and a cron job. it would just have been nice use a http endpoint instead. i wouldn't mind to have spent the time to implement it either.

@mad01 did you see https://github.com/prometheus/prometheus/pull/3720
this is much nicer than the cronjob.
It should be just few lines to implement the http endpoint.
if you have time to implement the HTTP adapter can still reconsider http vs file sd again based on how popular the HTTP adapter gets.


Sign ack for v0.4

Ongoing work on signing attachment decorator content and integrating RFC#15 ack messages for issue-credential and present-proof protocols.

Codecov Report

Merging #233 into master will increase coverage by 0.01%.
The diff coverage is 63.97%.

@@            Coverage Diff            @@
##           master    #233      +/-   ##
=========================================
+ Coverage   72.98%     73%   +0.01%
=========================================
  Files         219     223       +4
  Lines       10174   10288     +114
=========================================
+ Hits         7426    7511      +85
- Misses       2748    2777      +29


Move resource version annotation to a different file

Moving resource version annotation to a new file. The newly added file can be used for storing all the metadata going forward. It is added and removed from the client side and will not be present in porch.
Please refer this for more info: https://github.com/GoogleContainerTools/kpt/issues/4017

The commit hash will change every run, so you probably need to tweak the test code to strip those out before doing deltas. Timestamp too. I had to do that with the prior version.
You may also want to not store all the annotations (in the actual code, not the test code), but I didn't mention it before because it's harmless that they are there; they are ignored by your push code, and the file is hidden.

The commit hash will change every run, so you probably need to tweak the test code to strip those out before doing deltas. Timestamp too. I had to do that with the prior version.
You may also want to not store all the annotations (in the actual code, not the test code), but I didn't mention it before because it's harmless that they are there; they are ignored by your push code, and the file is hidden.

Additional things I can find are creationTimestamp & uid Instead of removing specific annotations, I hope we can dump them only. As we have made it a hidden file it should not affect the user too.
Let me know if that is fine or we want to remove some of them.


144 the v0 series of google GitHub actionsauth is no longer maintained

See #144 for more details.

Decided to update google-github-actions/setup-gcloud@v2 too while I was at it.

And google-github-actions/auth@v2 as well.


% operator not found when including a script in predef.sc

I have an issue with including a script in predef.sc. I made a minimal case with comments.
Error is: "not found: value %"
I found your suggestion to import ammonite.ops._ elsewhere, which didn't help unfortunately.
~/.ammonite/predef.sc
interp.load.ivy(
  "com.lihaoyi" %
  s"ammonite-shell_${scala.util.Properties.versionNumberString}" %
  ammonite.Constants.version
)
@
val shellSession = ammonite.shell.ShellSession()
import shellSession._
import ammonite.ops._
import ammonite.shell._
ammonite.shell.Configure(interp, repl, wd)
repl.prompt.bind(wd.toString + "@ ")

// --- the above is included in predef by default
// the below normally resides in the commented-out .sc script file that is the last line

// if I write it like this, and do not choose to put it in an
// external .sc file (as seen below) it works:
def gammaNormal = 1.0
def gamma(value: Double = gammaNormal) {
  %xgamma("-gamma", value.toString)
}

// if I paste it into this referenced script file, and leave the line
// below as it is, it says "system.sc:5: not found: value %" when starting up amm

import $file.^.ammSc.system, system._

as you suggested, I put the ops import in the script file. It looks like this:
~/ammSc/system.sc
import ammonite.ops._

def gammaNormal = 1.0
def gamma(value: Double = gammaNormal) {
  %xgamma("-gamma", value.toString)
}

@simlei which version of ammonite do you use?
I've tested it with 1.0.2
My error was:
system.sc:5: could not find implicit value for parameter wd: ammonite.ops.Path
  %xgamma("-gamma", value.toString)

So I've modified ~/ammSc/system.sc
import ammonite.ops._
import ammonite.ops.ImplicitWd._

def gammaNormal = 1.0
def gamma(value: Double = gammaNormal) {
  %xgamma("-gamma", value.toString)
}

and it loads for me correctly:
○ → amm
Loading...
Compiling /home/piotr/ammSc/system.sc
Compiling /home/piotr/.ammonite/predef.sc #2
Welcome to the Ammonite Repl 1.0.2
(Scala 2.12.3 Java 1.8.0_74)
If you like Ammonite, please support our development at www.patreon.com/lihaoyi
/home/piotr@ exit

Hi,
I was using version 1.0.1
After updating to 1.0.2, it works now. Thanks for checking that, sorry for not having had the latest version...


Accessability

I noticed that the components are Not following accessability principles. Since we (in Europe) will have to follows the european accessibility act this would be a necessary thing to work with it. Except of the reason that a good accessability would be good anyway.

I noticed that the components are Not following accessability principles. Since we (in Europe) will have to follows the european accessibility act this would be a necessary thing to work with it. Except of the reason that a good accessability would be good anyway.

Fully agree here, the UI components looks and feels amazing but as long as they're not accessible I won't consider using this.
Radix UI/shadcn also looks and feels amazing, but the fact the components are also fully accessible is really the main reason for me why I use them and why they bring so much value to all kinds of projects.
Also, really want to take the time to say that the work you guys have done with PinesUI so far is terrific! 👏

+1.  Accessibility is really important.  Exhibit A: https://www.accessibility.com/digital-lawsuits

Even in the US, accessibility is a must, as someone who works on educational sites.

Any update on this topic?

Just stumbled on the same thing. Nav bar looks amazing but the drop down can't be accessed using a keyboard.


can customize reload interval for config.

What would you like to be added:
now the reload interval is 60s, which is two long for CI test
Why is this needed:
the reload interval can be customized when mount
the we can trigger the reload operation by API.

Now the reload interval is the same as heartbeat, which can be customized by the --heartbeat mount option.


o4 doesn't exit with an error code

context: our code uses o4 under the covers to handle syncing and it's important that we're able to get a non-0 return code from a child o4 process so that we can fail properly
the specific error I'm concerned with is here: https://github.com/salesforce/o4/blob/master/o4/o4.py#L1360
i see that the o4 code called sys.exit() and I would expect a returncode of 1 to indicate a failure
however, that is not what I'm seeing...
> o4  fstat ...@28140329  -f | manifold -- o4  seed-from /Users/v.dixit/blt/tools/oracle/etc/tnsnames.ora
*** INFO: (1/3) Retrieving HEAD changelist for /Volumes/Gimlet/blt/list-views/tools/oracle/etc/...
*** WARNING: Could not map result {'code': 'stat', 'change': '28132000', 'time': '1601524502', 'user': 'pargat.singh', 'client': 'pargat.singh_parsingh-ltm', 'status': 'submitted', 'changeType': 'public', 'path': '//tools/oracle/etc/*', 'desc': 'IST24 TNS update\nhttps://gus.li'}
*** ERROR: Could not get HEAD for /Volumes/Gimlet/blt/list-views/tools/oracle/etc/...

> echo $?
0

That produces a non-zero exit

~/blt(feature/fix-log-race*) » python3
Python 3.8.2 (default, Aug 25 2020, 09:23:57)
[Clang 12.0.0 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> help(sys.exit)

Help on built-in function exit in module sys:

exit(status=None, /)
    Exit the interpreter by raising SystemExit(status).

    If the status is omitted or None, it defaults to zero (i.e., success).
    If the status is an integer, it will be used as the system exit status.
    If it is another kind of object, it will be printed and the system
    exit status will be one (i.e., failure).

You probably need to set pipefail in your pipeline

This might help: https://gist.github.com/mohanpedala/1e2ff5661761d3abd0385e8223e16425

Example from o4: https://github.com/salesforce/o4/blob/master/o4/o4.py#L831-L834


Feature/seed phrase backup

Looks great so far!!
Feedback:

Grey out the "Backup to iCloud" and "Backup to Google Drive" and put "coming soon" or something to let users know that those buttons are not working yet.
On the double-check screen,  put "Yes, it's that important" on a separate line and in bold.
After it's complete, and I go back to the settings screen, let them click the button, and after authenticating with pin or biometrics again let them see the seed phrase.

Food for thought:

I'm thinking we add a "Backup to Flash" option, where we hold their keys and let them create a password to decrypt it. Let's consider this after MVP.

testing on the Samsung S23, there is no scroll to see the buttons below:

I probably shouldn't have posted the seed phrase on a public GitHub lol
Its an empty wallet on the sim, I'll wipe it now

Looks great so far!! Feedback:

Grey out the "Backup to iCloud" and "Backup to Google Drive" and put "coming soon" or something to let users know that those buttons are not working yet.
On the double-check screen,  put "Yes, it's that important" on a separate line and in bold.
After it's complete, and I go back to the settings screen, let them click the button, and after authenticating with pin or biometrics again let them see the seed phrase.

Food for thought:

I'm thinking we add a "Backup to Flash" option, where we hold their keys and let them create a password to decrypt it. Let's consider this after MVP.

Looks great so far!! Feedback:

Grey out the "Backup to iCloud" and "Backup to Google Drive" and put "coming soon" or something to let users know that those buttons are not working yet.
On the double-check screen,  put "Yes, it's that important" on a separate line and in bold.
After it's complete, and I go back to the settings screen, let them click the button, and after authenticating with pin or biometrics again let them see the seed phrase.

Food for thought:

I'm thinking we add a "Backup to Flash" option, where we hold their keys and let them create a password to decrypt it. Let's consider this after MVP.

Can't we just remove "Backup to iCloud" and "Backup to Google Drive" buttons for now?

Looks great so far!! Feedback:

Grey out the "Backup to iCloud" and "Backup to Google Drive" and put "coming soon" or something to let users know that those buttons are not working yet.
On the double-check screen,  put "Yes, it's that important" on a separate line and in bold.
After it's complete, and I go back to the settings screen, let them click the button, and after authenticating with pin or biometrics again let them see the seed phrase.

Food for thought:

I'm thinking we add a "Backup to Flash" option, where we hold their keys and let them create a password to decrypt it. Let's consider this after MVP.

Can't we just remove "Backup to iCloud" and "Backup to Google Drive" buttons for now?

yes.

@islandbitcoin implemented feedback changes. Please, test it out

Feedback:

I'm still not able to scroll down on the screen with the words, the Verify button is half hidden (using Samsung galaxy S23 API 33 device simulator)
Double check screen looks great!
the "show me again" button should say "Try again"
I cannot progress from the verify screen because I cannot see the button below the "Show me again" button and I cannot scroll (see screenshot)

tested it on the Pixel 7 Pro so I could get past the verify screen.
I like the "reveal recovery phrase" flow. does this ask the user to enter their pin/biometrics?

@islandbitcoin Yes, it will ask if it is turned on in the app security settings.

Looks great!


Deprecating long-lived credentials for modules - terraform-template-poc

Background

To improve the security of services running on the Cloud Platform, we are removing the ability to create and use long-lived credentials, such as IAM access keys, from our modules. These are being replaced by short-lived credentials.

Instructions
https://user-guide.cloud-platform.service.justice.gov.uk/documentation/other-topics/deprecating-long-lived-credentials.html#deprecating-long-lived-credentials-for-modules
Acceptance Criteria:
No longer using long lived creds.
Assumption
Some refactoring of apps may be required in support of this change.
Notes:
Cloud Platform Comms
Guidance/Instructions

what work is needed on this ticket? can it be closed as modifying the GH Action workflow files will be done in another ticket?

Closing due to no work needed - currently we are creating the user within the terraform-template-poc-state.tf and are not using any of the long lived credentials (defined in the CP modules) due for deprecation.


Added OWASP NodeGoat.

Added the OWASP newer web goat like app (NodeGoat).

@binarymist  Could you share your lab details ?
/tmp ->> git clone https://github.com/OWASP/NodeGoat
Cloning into 'NodeGoat'...
remote: Counting objects: 4718, done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 4718 (delta 0), reused 0 (delta 0), pack-reused 4713
Receiving objects: 100% (4718/4718), 7.64 MiB | 1009.00 KiB/s, done.
Resolving deltas: 100% (899/899), done.
Checking connectivity... done.

NodeGoat [master] ->> uname -a
Darwin seclab.local 16.3.0 Darwin Kernel Version 16.3.0: Thu Nov 17 20:23:58 PST 2016; root:xnu-3789.31.2~1/RELEASE_X86_64 x86_64
NodeGoat [master] ->> docker-compose build
mongo uses an image, skipping
Building web
ERROR: Couldn't connect to Docker daemon. You might need to start Docker for Mac.

It depends on whether the end user wants to run mongo outside of a container or within a container. People like to have the choice. Pushing to hub.docker, removes the flexibility I think. You can flick the branches here to see the difference.

We will probably see more multi-container applications based on Docker Compose in the future, but so far DockerHub does not support composed apps, and maybe never will: https://github.com/docker/compose/issues/1597
Maybe NodeGoat could register their application on https://composehub.com which would result in a "copy & pasteable" command like ch install nodegoat && cd nodegoat && docker-compose up?

Thanks @binarymist @bkimminich . Merge it.

👍  Thanks @binarymist @bkimminich @nixawk. The pentest-wiki is a very helpful resource and I am glad to see NodeGoat being part of it.
@bkimminich your comment peeked my interest. I like the idea of publishing NodeGoat on composeHub. I will explore that option further.


Less Than 100?

Before jumping into Pr first comment for assign.All Problem from Edabit. Link is mandatory to add
Problem statement:
Problem Link:

Before submitting a PR please Check some details.Check Edabit for problem task

[ ] fileName formet should be in camelcase
example- returnTheNextNumber.py
[ ]  Add label for Problem
[ ]  In file there should be problem statement and link to probelm
example -

'''
    Probem Task : Given two numbers, return True if the sum of both numbers is less than 100. Otherwise return False.
    Problem Link : https://edabit.com/challenge/pZ3HxBfvejsvkEDo4
'''
*/
def main():
    return a + b

This repository is vaild for HacktoberFest2020
Read before making PR - How to contribute on Github
Good Luck,

assign me

Could you please assign me. i would love to work on this.

I would like to work on this.

Can i take up on this? can you please assign me this.i would love to work on this

Please Assign me this. I would love to work on it :)

Can I please be assigned to this?

I would love to work on this. Please assign this task to me.

I didn't receive the PR yet. ANyone else want to create PR.


File system 'fs-12345678' does not exist

What this PR does / why we need it:
Fix issue related to default file system id:
W0109 08:06:08.407526 1 efs-provisioner.go:91] couldn't confirm that the EFS file system exists: FileSystemNotFound: File system 'fs-12345678' does not exist.

Checklist

[x] DCO signed
[x] Chart Version bumped

/ok-to-test

/lgtm

Hello,
I don't truly know why this version triggers this error 1 efs-provisioner.go:60] environment variable FILE_SYSTEM_ID is not set! Please set it.
when I install the helm chart with this
helm install aws-efs stable/efs-provisioner --version 0.10.1 \                                          --set efsProvisioner.provisionerName=efs-provisioner \                                          --set efsProvisioner.awsRegion=${} \                                          --set efsProvisioner.storageClass.name=efs \                                          --set efsProvisioner.storageClass.isDefault=true \                                          --set efsProvisioner.dnsName=${}
while executing helm install aws-efs stable/efs-provisioner --version 0.10.0 \                                          --set efsProvisioner.provisionerName=efs-provisioner \                                          --set efsProvisioner.awsRegion=${} \                                          --set efsProvisioner.storageClass.name=efs \                                          --set efsProvisioner.storageClass.isDefault=true \                                          --set efsProvisioner.dnsName=${}
triggers no issue at all,
what I understand is "it's either I pass the dnsName or the efsFileSystemId", correct?
thanks a lot

@hacktron95 thanks for pointing this out. It looks like it's required even if this is invalid value. For me it's should be fixed in https://github.com/kubernetes-incubator/external-storage but for now I propose to revert it back.
@srueg, @mariusv what do you propose? I can drop a PR to roll this back.

Agree, let's roll back until it's fixed upstream. Thanks :+1:

Please review: https://github.com/helm/charts/pull/19984


Implement library

Hello i have some problem with implementation of AssymetricGridView it still crashing but i dont know what is wrong how to implement it correctly with my adapter there is error Link to AssymetricGridView library. Thank you
Adapter must be an instance of AsymmetricGridViewAdapter
at com.felipecsl.asymmetricgridview.library.widget.AsymmetricGridView.setAdapter(AsymmetricGridView.java:71)
at com.gabriel.movies.fragment.MainFragment.render(MainFragment.java:140)
at com.gabriel.movies.fragment.MainFragment$MyTask.onPostExecute(MainFragment.java:228)
at com.gabriel.movies.fragment.MainFragment$MyTask.onPostExecute(MainFragment.java:161)
My code
<com.felipecsl.asymmetricgridview.library.widget.AsymmetricGridView xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/gridView1"
android:layout_width="match_parent"
android:layout_height="match_parent" />
AsymmetricGridView gridview;
List list;
AdapterCategory adapter;
gridview = (AsymmetricGridView) mRootView.findViewById(R.id.gridView1);
gridview.setRequestedColumnWidth(Utils.dpToPx(getActivity(), 120));

list = new ArrayList<ItemCategory>();

adapter = new AdapterCategory(getActivity(), R.layout.fragment_worcipe_main_item, list);
gridview.setAdapter(adapter);

and adapter code
public class AdapterCategory extends ArrayAdapter {
ItemCategory object;
private Activity activity;
private List item;
private int row;
 public AdapterCategory(Activity act, int resource, List<ItemCategory> arrayList) {
        super(act, resource, arrayList);
        this.activity = act;
        this.row = resource;
        this.item = arrayList;
    }

    @Override
    public View getView(final int position, View convertView, ViewGroup parent) {
        View view = convertView;
        ViewHolder holder;

        if (view == null) {
            LayoutInflater inflater = (LayoutInflater) activity.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
            view = inflater.inflate(row, null);
            holder = new ViewHolder();
            view.setTag(holder);
        } else {
            holder = (ViewHolder) view.getTag();
        }

        if ((item == null) || ((position + 1) > item.size()))
            return view;

        object = item.get(position);

        holder.title = (TextView) view.findViewById(R.id.category_title);
        holder.image = (ImageView) view.findViewById(R.id.category_image);

        holder.title.setText(object.getCategoryName());

        Picasso.with(getContext()).load(RecipeConfig.SERVER_URL + "/upload/" +
                object.getCategoryImageurl()).placeholder(R.drawable.ic_thumbnail).into(holder.image);

        return view;
    }

    public class ViewHolder {
        public TextView title;
        public ImageView image;

    }
}

I'm also still trying to get the gridview working but, as far as i can see you have to extend your AdapterCategory from AsymmetricGridViewAdapter
my GridAdapter looks like this at the moment:
public class GridAdapter extends AsymmetricGridViewAdapter<GridItem> {
    Context context;
    public GridAdapter(Context context, AsymmetricGridView listView, List<GridItem> items) {
        super(context, listView, items);
        this.context=context;
    }

    public View getActualView(int position, View convertView, ViewGroup parent) {
        TextView v;
        GridItem item = (GridItem) getItem(position);
        if (convertView == null) {
            v = new TextView(context);
            v.setGravity(17);
            v.setTextColor(Color.parseColor("#ffffff"));
            v.setTextSize((float) Utils.dpToPx(context, 18.0f));
            v.setId(item.getPosition());
        } else {
            v = (TextView) convertView;
        }
        v.setText(item.getText());
        return v;
    }
}

But this is also not working because in this line of code super(context, listView, items); items is a wrong argument. If you have any cloe on how to get this working please let me know

Your AdapterCategory needs to extend AsymmetricGridViewAdapter


Eliminate warnings about Logging extensions with 2.0

Currently getting the following warnings:
Startup.cs(88,13): warning CS0618: 'ConsoleLoggerExtensions.AddConsole(ILoggerFactory, IConfiguration)' is obsolete: 'This method is obsolete and will be removed in a future version. The recommended alternative is to call the Microsoft.Extensions.Logging.AddConsole() extension method on the Microsoft.Extensions.Logging.LoggerFactory instance.' [/Users/klmcw/src/github.com/klmcwhirter/puzzle-service/puzzles/puzzles.csproj]
Startup.cs(91,13): warning CS0618: 'DebugLoggerFactoryExtensions.AddDebug(ILoggerFactory)' is obsolete: 'This method is obsolete and will be removed in a future version. The recommended alternative is to call the Microsoft.Extensions.Logging.AddDebug() extension method on the Microsoft.Extensions.Logging.LoggerFactory instance.' [/Users/klmcw/src/github.com/klmcwhirter/puzzle-service/puzzles/puzzles.csproj]

Watch for this to appear in the next version. This is from the dev branch.
https://github.com/aspnet/SignalR/blob/dev/samples/ChatSample/Program.cs#L15


Flag --incompatible_disable_starlark_host_transitions will break rules_cc in Bazel 7.0

Incompatible flag --incompatible_disable_starlark_host_transitions will be enabled by default in the next major release (Bazel 7.0), thus breaking rules_cc. Please migrate to fix this and unblock the flip of this flag.
The flag is documented here: bazelbuild/bazel#17032.
Please check the following CI builds for build and test results:

MacOS OpenJDK 11
Ubuntu 16.04 OpenJDK 11
Ubuntu 18.04 OpenJDK 11
Windows OpenJDK 11

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

Closing this issue as we are not seeing any failure with the above flag. Thanks!