Inline-block spacing with minified html

Hello when you have buttons in a row and you are minifying your html then they end up with no spacing on the right and left sides. You can add a marigin left/right of 2px to mimic the spacing. But this doesn't fix all elements because it also affects input groups and probably several other things. This also inst perfect even if you applied it to all the right elements because it leave an extra 2px on your first element.
Here is an example

X-Ref: #16163


Hidden Route

Superseded by #256

No, not superseded, that's different. Branch routes are nice but not really related to this.


Error when using Yard to read doc

I put in my gemfile
gem 'axlsx'
gem 'yard'
Then I run :
yard server --gems
When I click on axlsx on :
http://<IP_ADDRESS>:8808
I got the following error
undefined method `new' for nil:NilClass
/home/douglas/.rvm/gems/ruby-2.1.0@rails3/gems/yard-<IP_ADDRESS>/lib/yard/templates/helpers/html_helper.rb:67:in html_markup_markdown' /home/douglas/.rvm/gems/ruby-2.1.0@rails3/gems/yard-<IP_ADDRESS>/lib/yard/templates/helpers/html_helper.rb:41:inhtmlify'

Please install the kramdown gem on your machine and restart the yard server. The yard documentation is dependent of this gem because it uses markdown.
gem install axlsx
gem install yard
gem install kramdown
yard server -g

Same error with kramdown installed
gem list | grep 'axlsx\|yard\|kramdown'
axlsx (2.0.1, 1.3.6)
kramdown (2.1.0)
yard (0.9.18, <IP_ADDRESS>)


send_confirmation_transactions drops transfer events to confirm when not (yet) a validator

There should be a better way to handle that situation. Maybe we should wait until we become a validator.

@schmir-at-bb is this equivalent to #276?

Suggested approach: On startup, run the event fetchers, but not the confirmation planner and sender. In addition, run a greenlet that periodically checks if we are a validator or not. Once the check succeeds, launch confirmation planner and sender.
Does this make sense?

This will work. If the confirmation planner is not running, the queues will be filled with events and no one is consuming events.
I would try to start everything like it is now and keep a flag in the TransferRecorder[1], if we're already allowed to confirmTransfers. The recorder would return an empty list in the pull_transfers_to_confirm() if we're not yet allowed to confirm transfers. Nevertheless the state in the recorder will be able to catch up with the current state of the chain. We should make sure that completed transfers don't stay in the recorder in order to not waste memory (even when we are not a validator yet).
Contrary to what I said in the meeting, I would not put this onto a queue, since I think it's special enough that we could also just call a method that does set this flag.
So, please start a greenlet that waits for the validator status to become true, sets this flag, and then still watches the validator status. If we stop being a validator, it's game over and we could probably abort the program.
[1] One could argue that we should use another name for the TransferRecorder then. But I'm fine with living with a bit badly named stuff.


Rewrite in TypeScript

Just putting this out as a long-term goal. Been using TypeScript, and despite the overhead of learning and writing in a more verbose language that tries to look like Java, the type safety and better auto-complete compensates for a lot of that overhead.
It's also not just about a rewrite. It's also:

Structured, type-safe code. Writing with discipline is a good habit, but not worrying about it is better.
Generatable documentation. A side-effect of code that is written in a predictable manner.
Probably better code optimization. With types and staticness comes better code analysis, linting, etc.
Better intellisense and integration with projects that use TypeScript.

To the consumer, the library will still be the same old Ractive. It's only the library's source that will change. Ractive is also already written in a very class-y manner, so I guess it's already half-way there. Still looking into what else TypeScript can offer, especially in terms of library development.
Lemme know your thoughts 😁

@avoto This one makes me curious. Have you already made some project with it by chance? What's your experience?


Can't load file from input file after updating from 3.5 to 3.7

Hi,
I updated exceljs from 3.5 to 3.7 and I can't load a file from an input type file (with reactjs)
Here is a sample of code wich works in 3.5 but not in 3.7
import React from 'react'
import {useState} from 'react'
import ExcelJS from 'exceljs'

function App() {

  const [file, setFile] = useState({})

  function handleFormSubmit(e){

    loadFile().then(workbook => {
        console.log(workbook)
    })

    e.preventDefault()
    e.stopPropagation()
  }

  function loadFile(){
    return new Promise(function(resolve, reject){
      file.arrayBuffer().then(b => {
        let workbook = new ExcelJS.Workbook()
        workbook.xlsx.load(b).then(() => {
          resolve(workbook)
        })
      })
      .catch(e => reject(e))
    })
  }

  return (

      <form onSubmit={e => handleFormSubmit(e)}>
        File : <input type="file" onChange={e => setFile(e.target.files[0])} />

        <input type="submit" value="Submit" />
      </form>

    );
  }

 export default App

I get this error :
Unhandled Rejection (Error): Chunk must be one of type String, Buffer or StringBuf.
On workbook.xlsx.load(b).then(() => {
Thx for helping

Having the same issue.
Works fine with Buffers produced by Node's fs.readFileSync, but not in the browser with Buffer.from(array_buffer) where ArrayBuffer is produced by something like:
export function readFileAsync(file: File) {
    return new Promise<ArrayBuffer>((resolve, reject) => {
        const reader = new FileReader()
        reader.onload = () => {
            if (reader.result instanceof ArrayBuffer) {
                resolve(reader.result)
            } else {
                reject(new Error('Result is not an ArrayBuffer'))
            }
        }
        reader.onerror = reject
        reader.onabort = reject
        reader.readAsArrayBuffer(file)
    })
}

Any chances to get it fixed? Maybe someone has a workaround?

thank you @TomaszG for an investigation it will be really useful.
In the nearest future, I predict that I will haven't time for coding open sources :(
I see that we have a great community, that's love to support us.
@TomaszG,  may want you to create a PR with a fix? I will be thankful and review it ASAP (just mark me as "requested review").

Looks like we just need to add another condition here:
https://github.com/exceljs/exceljs/commit/020cb99547f23cdf7593b58ba94ba6ca145c4bac#diff-147b472da81752bafc2b02627836b12eR236
Happy to merge a PR that adds this with a browser test


Generate models with extensible enum properties from Cadl

Input/Output/Round-trip models with enum and "string enum" type properties
This issue tracks the work to implement generation of models with Cadl "string enum" type properties in the DPG generator.  These correspond to "extensible enums" or "strongly typed strings" in .NET.
If we need to triage this work, generation of Round-trip models is P0, and generation of Input and Output models is P1.
Input Cadl file
Cadl testserver models/enum-properties
Expected output
String Enum Files:

[ ] TranslationLanguage.cs
[ ] No corresponding .Serialization.cs file.
[ ] Is in .Models namespace
[ ] "String enum" is generated as a strongly-typed string (see FDG3, Section 4.11
[ ] "String enum" is defined as a readonly partial struct
[ ] Public constructor takes string value
[ ] Constructor calls Argument.AssertNotNull on value [TODO: FDG says DO allow null inputs -- should we do this?]
[ ] Values are provided as public static properties of the strong-typed string type
[ ] Values are get-only
[ ] Overrides ToString()
[ ] ==, != and cast operators are provided
[ ] Provides Equals(StringEnum other)
[ ] Defines Equals(object) and GetHashCode(), but applies [EditorBrowsableState.Never] to them
[ ] Generator warning if @doc is not provided on enum
[ ]  @doc-decorated values use the Cadl-provided value in the docstrings
[ ] Values without @doc-decorated value have the name of the value in the docstrings (Undocumented does not have a @doc value)

Input Model Files:

[ ] InputModel.cs
[ ] InputModel.Serialization.cs
[ ] Input models have only one public constructor, and it takes required values
[ ] Required properties are not settable on input models
[ ] Write operation is defined in serialization partial class

Output Model Files:

[ ] OutputModel.cs
[ ] OutputModel.Serialization.cs
[ ] Output models have internal constructor taking required values
[ ] Required properties are not settable on output models
[ ] DeserializeOutputModel method is defined in serialization partial class

Round-Trip Model Files:

[ ] RoundTripModel.cs
[ ] RoundTripModel.Serialization.cs
[ ] Round-trip models have public constructor, and it takes required values
[ ] Required properties are both gettable and settable on round-trip models
[ ] Write method is defined in serialization partial class
[ ] DeserializeRoundTripModel method is defined in serialization partial class

Design notes
Design discussed in https://github.com/Azure/autorest.csharp/issues/2338
Corresponding issue tracking "fixed enum" properties is https://github.com/Azure/autorest.csharp/issues/2477

Related work item: https://github.com/Azure/autorest.csharp/issues/2535
Also the depending PR: https://github.com/Azure/autorest.csharp/pull/2536

Pending on input model and output model.

We only support string as the enum value


xWebsite will set bindings every time

So in xWebsite if you specify the bindings as follows:
BindingInfo     = MSFT_xWebBindingInformation
{
    IP                   = '*'
    Protocol             = 'HTTP'
    Port                 = 80
    Thumbprint           = ''
    CertificateStoreName = 'My'
}

DSC will continously try to "fix" your web server as it'll never be able to match the CertificateStoreName. I have a lead on where the bug is and will be submitting a PR as soon as I've had time to write the tests.

This was solved in some of my PRs that I've put out.


Documentation Update: Firebase-Counter Deletes Subcollection/Shards Once Aggregated

[READ] Step 1: Are you in the right place?
Issues filed here should be about bugs for a specific extension in this repository.
If you have a general question, need help debugging, or fall into some
other category use one of these other channels:

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
To file a bug against the Firebase Extensions platform, or for an issue affecting multiple extensions, please reach out to
Firebase support directly.

[REQUIRED] Step 2: Describe your configuration

Extension name: _ (storage-resize-images, firestore-send-email, etc)
Configuration values (redact info where appropriate):

_
_

[REQUIRED] Step 3: Describe the problem
The documentation would lead you to believe that you will have a persistent subcollection in your documents that have a counter containing count shards.  However, this isn't necessarily the case because once the shards are aggregated they get deleted.  I thought I was going crazy because I could not find any subcollection with shards but yet somehow the function was accurately counting.  It left me scratching my head wondering what was getting counted if they aren't in the DB.
Steps to reproduce:
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
Expected result
I think it would be helpful to make it more clear that if you are running a few simple tests, you will not see any of these subcollections.
Actual result

Hi @tommyc38 thanks for opening the issue. Although this intended, I do think it would be best to let users know about this, to ensure they are only using the "master" counter.
@rachelsaunders would this be best placed here or do you think it requires an explanation within the PREINSTALL doc?

For clarification - does the extension delete the subcollections each time the scheduled function runs?

@rachelsaunders, either I am experiencing a bug or it does indeed delete the sub collection if it has no more shards (docs) to count.  Assuming this is intended, having a line or two about this in the docs will be helpful to others who run tests and expect to see a sub collection but don't.

@Ehesp Friendly ping on my clarification question above?  Thx!

Hi @rachelsaunders - it deletes them once they have been aggregated yes. Users should sync with the 'master' doc created, as it's unreliable to sync with the aggregators (as they can be removed anytime).

closed w/ merge of PR #62


Using -o option in combination with -r asciidoctor-diagram causes failure in prawn

Not sure if this an issue with asciidoctor-pdf or prawn.
When I try to generate a document with embedded UML diagrams, this fails only if I use the -o option with an output path.
Omitting the -o option works.
$ asciidoctor-pdf --trace -r asciidoctor-diagram -a pdf-style=doc/adoc-pdf-theme.yml doc/specification/api-specification.adoc -o /home/ben/myproject/dist/doc/api-specification.pdf
/var/lib/gems/2.3.0/gems/prawn-2.2.2/lib/prawn/document.rb:386:in `initialize': Is a directory @ rb_sysopen - /home/ben/projects/mfusst-ui.git/dist/doc/api-specification.pdf (Errno::EISDIR)
	from /var/lib/gems/2.3.0/gems/prawn-2.2.2/lib/prawn/document.rb:386:in `open'
	from /var/lib/gems/2.3.0/gems/prawn-2.2.2/lib/prawn/document.rb:386:in `render_file'
	from /var/lib/gems/2.3.0/gems/asciidoctor-pdf-1.5.0.alpha.16/lib/asciidoctor-pdf/converter.rb:2828:in `write'
	from /var/lib/gems/2.3.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/document.rb:1083:in `write'
	from /var/lib/gems/2.3.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor.rb:1507:in `convert'
	from /var/lib/gems/2.3.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor.rb:1575:in `block in convert_file'
	from /var/lib/gems/2.3.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor.rb:1575:in `open'
	from /var/lib/gems/2.3.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor.rb:1575:in `convert_file'
	from /var/lib/gems/2.3.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/cli/invoker.rb:108:in `block in invoke!'
	from /var/lib/gems/2.3.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/cli/invoker.rb:102:in `each'
	from /var/lib/gems/2.3.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/cli/invoker.rb:102:in `invoke!'
	from /var/lib/gems/2.3.0/gems/asciidoctor-pdf-1.5.0.alpha.16/bin/asciidoctor-pdf:31:in `<top (required)>'
	from /usr/local/bin/asciidoctor-pdf:23:in `load'
	from /usr/local/bin/asciidoctor-pdf:23:in `<main>'

I can also see that inside the folder /home/ben/myproject/dist/doc/ there exists a subfolder api-specification.pdf with the following content:
.
└── doc
    └── api-specification.pdf
        ├── .asciidoctor
        │   └── diagram
        │       ├── .domain-model.png.cache
        │       └── domain-model.png.cache
        ├── domain-model
        │   └── domain-model.png
        ├── rest-api
        │   └── .domain-model.png
        └── websocket-api
            └── .domain-model.png

Using the output option specifies which file to write the artifact (pdf) to. Since this is a directory, it fails rightfully so.

Using the output option specifies which file to write the artifact (pdf) to.
I agree with that statement, @veeg

Since this is a directory, it fails rightfully so.
Yes. But this directory is not present prior to running the command. Nor does asciidoctor-pdf not fail if the document does not contain any embedded diagrams. So I do not see why it is rightfully to fail?

Aha. Since we take over the role of writing the file in the converter, we must also make sure any directories exist. It looks like that is not being done. I would have expected Prawn to do that, but we don't have to rely on Prawn.

Is a directory @ rb_sysopen

This is one of the oldest and most embarrassing typos in C. It reports a path in a non-existent directory as "is a directory". I have never understood why no seems to care to fix it. It should say "Is not a directory".

I'm still puzzled about what the problem is.
My original assumption was, that the generated, temporary api-specification.pdf-folder clashes with the final, identically named output file api-specification.pdf.
Now that I learned that the error message is just wrong, I'm even more wondering what's going on…

(Well, unless there really is a directory in the way. I haven't had a chance to test your scenario yet).

I just checked and I was incorrect. Asciidoctor PDF does create any intermediary directories that are needed. So that's not the issue.

This appears to be a bug in Asciidoctor Diagram (perhaps causes by a change to Asciidoctor core...but certainly a scenario that doesn't have a test). It actually has nothing to do with Asciidoctor PDF. Asciidoctor Diagram is not calculating the target directory correctly for some reason. So the issue needs to go into that project.
I'm seeing the same behavior with asciidoctor -a data-uri.
Btw, you can express your command using -D /home/ben/myproject/dist/doc instead of -o. But that doesn't seem to fix the problem.

I feel confident this will be solved by the fix for #1033 (which is essentially a duplicate of this issue). If that doesn't do it, we can revisit.


Using T_day and T_eq values for the reference systems

https://github.com/kevin218/exoMAST_Obs/blob/c45c9bc394a88cf475a5291cba9e15acda5dd694/exoMAST_TableSNR.py#L345-L349
Based on the paper, I had updated these lines in my copy as follows:
ref.Tp_eq = planetTeq(ref.Ts, ref.aRs, A=0, f=1)  # Planet Equilibrium temperature
ref.Tp_day = planetTeq(ref.Ts, ref.aRs, A, f)  # Planet Dayside temperature
ref.H = planetScaleHeight(ref.Tp_eq, ref.gp, mu=2.3)  # Planet scale height
ref.Bp15 = planck(1.5e-6, ref.Tp_day)  # Planet blackbody at 1.5 microns
ref.Bp50 = planck(5.0e-6, ref.Tp_day)  # Planet blackbody at 5.0 microns

For consistency, perhaps you want to adopt these changes as well?

Changes applied


Allow for data domain to be resized

Requested by Matthias Rempel (HAO):

I think it would be a useful feature to allow resizing of the white box  in a similar way
you can adjust the geometry in the renderer.
Thanks,
Matthias

Matthias is trying to highlight a subregion within his domain.  A reasonable fix might be to offer a bounding box in the annotation tab that is separate from our (usually white) domain box.


Add Py2/3 unicode / str compat for documentation tools.

Fixes #719

I looked at that, but docs/*.py doesn't use anything from src/


[DO NOT MERGE] DS-322 Teaser Replacement

Jira
https://pegadigitalit.atlassian.net/browse/DS-322
Summary
A new Teaser component to replace the text one.
Details
A new Teaser component to replace the text one and be used for best of content.
How to test
Read my code and check out my demos.
Release notes
Removes old text based Teaser, Replaces it with a new component.

@mikemai2awesome

Remove article from type. Only video, external-link, and PDF.

Should this even be a type if we’re not showing signifiers for others? Should it just be like an is_video boolean or something?

Update demo with fallback image. There are couple images provided by Yao that will be defaults for external-link and PDF if no image is passed. We need to demonstrate this. I’ll get you the images.

I’ll look out for the images, thank you.

Let’s have content and show_on_hover under description prop. Grouping the two together.

that makes sense, I’ll get on this.

Build out the like button because this needs to look exactly like the share button. No styles should be changed, we need to lock it down. The only thing they should do is add attributes.

I’m not sure what you mean by this, like it should be a part of the component instead of passed in on the template side? How would we handle that? The drupal guys will need to manipulate whether or not someting is “liked”

Remove eyebrow_text and create featured boolean instead. Done. Added featured prop and kept eyebrow_text for customization.

thank you

Group views, featured, and premium under status.

I’m not sure what you mean by this either? just group them in the schema? so it would be like status.views and status.featured ? I thought we wanted to keep the views section a little more open for the drupal guys?

Lastly, we need to clean up schema writings and doc pages.

yeah i just wanted to get the component out for review, i knew the docs werent ready.


Pushing via http returns "no DAV locking support"

[user@host /]# git push origin master
error: no DAV locking support on http://host:30080/repo1.git/
fatal: git-http-push failed

I only use ssh atm. I will fix this, when pushing via http is needed.

Works now, after implementing basic auth. I still don't know what the issue was.


Display single-character percentages on Windows

Most percentages single characters are available on Windows CP850. However, this library currently falls back to using ASCII such as 1/3.
Ubuntu 20.10 Gnome terminal:

Windows 10 cmd.exe (CP850):

However, 1/7, 1/9 and 1/10 are not supported on CP850.
Removing support for those three (arguably not-often-used) characters would allow switching to single characters percentages instead. This would also provide with a more consistent cross-platform experience.
What do you think?

Removing support for those three (arguably not-often-used) characters

I don't think we should remove them. Rather just let them keep using the ASCII output. Yes, it will be inconsistent, but as you said, they're not very often used, especially not together.

Sounds good!
Fixed in #45.


Upgrade jackson-databind to <IP_ADDRESS> to address CVEs

CVEs:
CVE-2022-42004
CVE-2022-42003
Changes:

Upgrade jackson-bom to <IP_ADDRESS>21013
Remove usage of methods deleted from latest version of jackson-databind

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[x] added or updated version, license, or notice information in licenses.yaml

FYI
There were two related PRs on this, we can close them once this is done.
https://github.com/apache/druid/pull/12411
https://github.com/apache/druid/pull/12373
And a PR before suppressed the CVE of jackson which I think we need to remove the suppression if this PR addresses the CVE:
https://github.com/apache/druid/pull/12535

Thanks for the tip, @FrankChen021 !
There are some backward incompatibility issues with this upgrade. I will try to get those resolved and close the older PRs.

Hey @kfaraz I am also interested in getting past these CVE's.
What are some of the backward incompatibility issues you're seeing?
Thanks for your work on this!

Hi, @CookieAroundTheBend !
The latest version of jackson-databind has removed the method AnnotateMember.getGenericType() which was being used in the Druid code in the GuiceIntrospector. I need to find a way to make the introspector work with getRawType(), or getType(). Haven't spent much time on it though.
Please let me know if you have any ideas.

@kfaraz  We had Druid 0.20.2 working with newer Jackson where we did have to change that GuiceAnnotationIntrospector to use getRawType().
Unfortunately we are trying to apply the same patch to 0.22.1 and are seeing issues most likely stemming from that change.
Does this patch work for the latest Druid? Or are you seeing issues with what's in this branch as well?

@kfaraz do you have any plans to push this over the finish line?

Not at the moment, @xvrl . I have been occupied with a few other tasks. I am okay if you would like to take it up.

@kfaraz should we close this PR?

Yes, @xvrl , we can close this for now.


ObjectAnimation as a Resource only loads XML

ObjectAnimation supports saving to/from XML and JSON. However, when loaded as a resource through BeginLoad (e.g. through the ResourceCache), it will only load it as XML, even if you pass a JSON file. It should instead check the filename extension to deduce whether it is xml or json (or maybe even the content).

see merged PR #72. If ok, you can close this.


Cannot install cifs-utils with tce

Output of docker version:
Client:
 Version:      1.11.1
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   5604cbe
 Built:        Wed Apr 27 00:34:20 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.11.1
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   5604cbe
 Built:        Wed Apr 27 00:34:20 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 4
 Running: 1
 Paused: 0
 Stopped: 3
Images: 371
Server Version: 1.11.1
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 392
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge null host
Kernel Version: 4.4.8-boot2docker
Operating System: Boot2Docker 1.11.1 (TCL 7.0); HEAD : 7954f54 - Wed Apr 27 16:36:45 UTC 2016
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.955 GiB
Name: default
ID: TL6S:OPEB:TUFP:L4PG:7CNK:HH4S:KCUI:CM3K:NAOI:WLB6:RL7L:RCEE
Docker Root Dir: /mnt/sda1/var/lib/docker
Debug mode (client): false
Debug mode (server): true
 File Descriptors: 16
 Goroutines: 36
 System Time: 2016-05-05T03:52:38.995357087Z
 EventsListeners: 0
Registry: https://index.docker.io/v1/
Labels:
 provider=virtualbox

Additional environment details (AWS, VirtualBox, physical, etc.):

Windows 7 64 bit
VirtualBox 5.0.20

Steps to reproduce the issue:

docker-machine ssh default
start tce and search for cifs-utils
Press Q, then I

Describe the results you received:
cifs-utils.tcz.dep OK
Downloading: filesystems-4.4.8-boot2docker.tcz
Connecting to repo.tinycorelinux.net (<IP_ADDRESS>:80)
wget: server returned error: HTTP/1.1 404 Not Found
md5sum: filesystems-4.4.8-boot2docker.tcz.md5.txt: No such file or directory
Error on filesystems-4.4.8-boot2docker.tcz

Describe the results you expected:
cifs-utils should be installed
Additional information you deem important (e.g. issue happens only occasionally):

At http://repo.tinycorelinux.net/7.x/x86_64/tcz/, I can only find filesystems-4.2.x, but the boot2docker is on 4.4.x...

sorry...wrong place.


Unexpected errors are thrown if image width and height is not specified

When you try to run model.classify(image), where image is of type HTMLImageElement; if the dimensions (width and height) of the image are not specified, the function throws unexpected errors, one of which is as follows:
DOMException: Failed to execute 'texImage2D' on 'WebGL2RenderingContext': Tainted canvases may not be loaded.

This is resolved if you make a new Image object with a width and height that you specify (200 in the following example), and you set newImg.crossOrigin to anonymous. A similar code snippet is also used in the chrome extension NSFW Filter, yet there is no mention of it on the README of this repo.
https://github.com/nsfw-filter/nsfw-filter/blob/2abc417c4a840ed53a7b0cf060c3867d54265779/src/background/Queue/LoadingQueue.ts#L42-L50
// `image` is the original `HTMLImageElement` that is supposed to be classified
// `newImage` is `image` but with width and height specified (to 200, 200 in this case)

const newImg = new Image(200, 200);
newImg.crossOrigin = 'anonymous';
newImg.src = image.src;
model.classify(newImg)

Without the above modification, the image classification is inconsistent, i.e, it fails sometimes and succeeds sometimes for the same exact image (I've tested this on Google Images). It might be because the images contain too many pixels, I was not able to figure out why the error occurred randomly; but adding the above snippet fixed it. There should probably be a mention of this on the README of the repo or a fix that resolves the issue entirely.

Interesting.  A couple thoughts come to mind.
The most likely issue is that there's a security issue where the src of the image is cross-origin.  By using the Image tag, you're effectively making a local copy and getting around tainted canvases issues.
That doesn't explain how it sometimes works and sometimes doesn't though.   That sounds more like a race-condition.   So maybe you're calling classify before the image is fully loaded?  I'd have to see the code to be sure.

@thebongy could you please post the code snippet in a comment?

I'll paste the relevant part of the code here.
We basically had a content script in a chrome extension which did the following:

let model: nsfwjs.NSFWJS;

nsfwjs.load('<redacted private url>').then((loaded) => {
  model = loaded;
});

window.onload = async () => {
   const images = [...document.querySelectorAll('img')];
    for (const image in images) {
      try {
        console.log(await filterImage(images[image], 0.5));
        await sleep(50);
      } catch (err) {
        console.log(err);
        // Blank
      }
    }
}

export default async function filterImage(
  image: HTMLImageElement, threshold: Number,
): Promise<FilterResult> {
  const width = image.clientWidth;
  if (width < 50) {
    return {
      filter: false,
      reason: 'The image is too small',
    };
  }
  const newImg = new Image(200, 200);
  newImg.crossOrigin = 'anonymous';
  newImg.src = image.src;
  const result = await scanImage(newImg);
  const highest = result[0];

  if (highest.className === 'Neutral' || highest.className === 'Drawing') {
    return {
      filter: false,
      reason: 'The image is neutral.',
    };
  }

  if (highest.probability < threshold) {
    return {
      filter: false,
      reason: 'The image is below the given threshold.',
    };
  }

  return {
    filter: true,
    reason: `The image has ${highest.className} content which is over the configured threshold.`,
  };
}

async function scanImage(element: HTMLImageElement) {
  while (!model) {
    // eslint-disable-next-line no-await-in-loop
    await sleep(1000);
  }
  return model.classify(element);
}

What we observed was that the same code, when the lines
const newImg = new Image(200, 200);
  newImg.crossOrigin = 'anonymous';
  newImg.src = image.src;

weren't present, and we just directly processed the input image, we would sometimes get the error posted originally on this issue (Tainted canvases may not be loaded.) . But constructing a new smaller intermediate image always made the library work.

This seems to be a bug with TFJS
https://github.com/tensorflow/tfjs/issues/322
It's also been identified here: https://stackoverflow.com/questions/57662313/requested-texture-size-0x0-is-invalid-error-when-i-am-loading-image-in-browse
This didn't used to be a bug.
However, the error you're getting seems to actually be a crossDomain error.   Because you're loading an image from a different website.  So you'll need to make a local copy.
You can test all 4 possible situations with this codesandbox I created here:

switch between img1 and img2 for local and remote.
switch line 14 and 15 for image resize on and off

https://codesandbox.io/s/nsfwjscrossoriginnsizecheck-epu3w?file=/src/index.js

I see, thank you for verifying!
For now the  intermediate image solution works for us, we'll update on this thread if we find out anything new about the issue :)

@thebongy glad that you were able to find a solution that works for you. Let us know if you have any more problems like this in the future, but for now we're going to close this issue.


Create install and build script for CircleCI

Reference: https://github.com/galaxypi/galaxy.ooo/issues/14#issuecomment-416643418

Create install and build script for CircleCI
Tasks

[x] Resolve current failing "Hello World" script
[ ] Design CircleCI Workflow architecture
[ ] Create CircleCI Simple script with these execution items

[ ] Create docker image for Linux
[ ] Installs gox
[ ] installs dependencies
[ ] Installs Galaxy
[ ] Runs a simple test

References

Galaxy build script -
Gox example - https://discuss.circleci.com/t/workflows-filtered-git-tag-not-works/20633

Resolved current failing "hello world" script...
version: 2
jobs:
  build:
    working_directory: /go/src/github.com/CircleCI-Public/circleci-demo-go
    docker:
      - image: circleci/golang:1.8
    steps:
      - checkout
      - run: echo "hello world"

Ok. So this is good enough for me at the moment @faddat. I was just cringing at seeing that red "Failed" badge... I tested the install. Worked great, blockchain is still syncing but looks like that will go through so I will hand this off to you. 😄


Add application/manifest+json ( .webmanifest) Static File MIME Type

The .webmanifest file extension should return the application/manifest+json MIME type. See sonarwhal documentation and W3C for reference.
I raised PR https://github.com/aspnet/StaticFiles/pull/221 for this but it was closed without a reason given.

Duplicate of https://github.com/aspnet/AspNetCore/issues/2442
But I'd give some point to this, seems to be a new common usage, and it's very simple to implement.
The workaround is to alter FileExtensionContentTypeProvider like this https://docs.microsoft.com/en-us/aspnet/core/fundamentals/static-files?view=aspnetcore-2.1&tabs=aspnetcore2x#fileextensioncontenttypeprovider

Ah, looks like my original issue got moved.


A few suggestions / questions from a first time user

Firstly I'd like to say thanks for putting together this "framework" - it's a great alternative to something like Buffalo or Bud. I plan on experimenting with it and adapting to my own base default template, trying a different template engine templ and adding an assets pipeline for js/css.
Here are a few observations / questions I noticed from using the template for the first time (some of which could become a PR based on feedback):

Pages are cached, but is it intended for Routes to be cached as well? For example, if you start the application and visit /about, change the /about route to /about-us (and rerun), then visit /about, the page renders. I would expect a change in the router would no longer route to any page, cached or not.
config.GetConfig() appears to be guessing where the config directory is based on what sub-package file is loading the config. I think a better approach would be something like:

	// Get the basepath / project root
	_, b, _, _ := runtime.Caller(0)
	basepath := filepath.Dir(b)
	...
	viper.AddConfigPath(basepath)

A make down command would be useful, e.g.: $(DCO_BIN) down

You're welcome. I'm glad to hear that you're finding it useful. Keep me posted on your experience with templ. I've been looking at it recently and it looks very promising. I'm waiting for the Goland plugin to be done so I can really dive in. While the std lib templates are quite powerful and flexible, they do leave a lot to be desired, and it was not easy to provide the solution that I did; and I'm not too thrilled with how some of the function and nested templates calls came out.

I'm a little confused with the example that you outlined. Those would be separate routes so one should not affect the other. Can you elaborate a little further? By default, nothing will be cached. If you set your Page's Cache.Enabled to true, the output will be cached. The cache middleware will currently only serve from the cache if it's a GET request and the user is not logged in. You can, of course, alter that behavior to fit your needs though. As I'm writing this I think I realize what you meant -  by change do you mean in the browser or the route definition? I guess you mean the latter (I assumed the former at first). Did we restart the application after making that change? I haven't tested this but I assume you would get a 404 if there is no /about route registered any more. I don't think the middleware would even get executed.
Yes, that would work. I used the same trick to get the templates directory. I was hoping by now there would be a better/standardized way of doing that, but it looks like there's not. I used the solution I have now because it's not too uncommon that your build process includes the config at the root when building an image, for example. So with the multiple paths, it allows there to be some flexibility and preference.
I agree. I can add that in quickly.

Regarding Number 2:
Steps to reproduce:

run make up
run make run
In a browser, visit localhost:8000/about
Kill the app
Change this line in the router to g.GET("/about-us", about.Get).Name = "about-us"
run make run
In a browser, visit localhost:8000/about

I would expect a 404, but the page renders 200

I would expect that too. Thanks for the detailed steps. I am able to reproduce. I'll have to look in to it. I don't understand why the middleware is being executed if there's no match for the route.

Looks like it has to do with how the Group() is being used:

https://github.com/labstack/echo/issues/1981
https://github.com/labstack/echo/pull/2411

Thinking about this some more, the middleware should definitely be executing even if there's no match found. I don't see anyway for the cache middleware to know that it's a 404 at that point. I don't think Echo exposes that in any way, unfortunately. I think you'll just have to clear the cache if you're making a change like this. I added a cache-clear command to the Makefile to make this easier. I also included stop and down.

Well that's unfortunate. It might be useful to put a warning about that in the README. Thanks for looking into that and adding those additional commands.

@mikestefanello I made an initial pass at trying templ and converting the codebase to use it. Check it out at this branch if you're interested. My initial impressions of templ are mostly positive, but there were some gotchas:

I was expecting to use "plain Go" in the template functions but that's not exactly how it works. For example, you can't build variables inside a templ function such as allNames := append(names, "John"), so you need to sometimes approach writing the template differently, or call plain Go functions from the templ function.
There is a question of which strategy to use for passing data into the template (see prop drilling). I opted for "Coupling" and passing in the Page struct
It's an advantage to have everything type safe in the template but that means operating on data passed as any requires casting in the templ function such as if form, ok := page.Form.(*types.LoginForm); ok {.

I think I would need to build a real app to see if there are any sharp edges with this implementation.

It looks like you made some really great progress. I like the approach that you took. My initial thought when I saw templ and considered using it with this project was dealing with potential import cycle problems between the templates package and either the controller or routes package, but it looks like you avoided that nicely (though as you pointed out in the 3rd point, maybe this will become an issue). I also think the coupling approach is superior to context for the templates. And your last point about using this in a real app was another concern of mine.. it may seem nice in a simple example but a real problem in a more complex one.

Funny you mention it, I did hit an import cycle problem but found a way around it. It was an issue in controller tests but I changed those tests to use package controller_test to avoid.
I think the coupling approach is the way to go. For number 3, you could get around type casting by passing additional structs to a template such as page.Component = pages.Contact(&page, &contactForm) and not set the page.Form. I was trying to stick to the original design choices and change less, but looking at it now I think setting less any types on Page is a better approach.

Thanks for your awesome work @mikestefanello, this is truly a fantastic starter for anyone wanting to use Go/HTMX. @saurori thanks for your work on templ integration too. I used your branch to start a few projects now and I must say I love the Pagoda setup even more now, templ truly makes the dev experience fantastic compared to the default html package. Not sure if it's useful, but my branch lives here. I meant to keep it clean but it's got a lot of extra changes I use by default in my projects...perhaps it will be useful.

@leomorpho Thank you! I'm very glad this project turned out to be useful for you. Please feel free to share any feedback about this and templ. Maybe at some point I'll bring templ in. I haven't yet given it a real try yet but I plan to.

For anyone interested, I have a heavily modified fork that uses Templ instead of gotemplates. I personally haven't looked back. I trust my code so much more than back when I had to pass maps to components. I love the static typing, and it's got some quite fantastic template composition syntax. It's OSS: https://github.com/leomorpho/GoShip
I'd be happy to merge some things back into Pagoda, but it's just gotten quite off-road from the initial pagoda fork...


New-GcbqDataset cmdlet implemented

Impemented the cmdlet and testing.  Word of warning, I haven't written remove-dataset, so the datasets must be removed manually from the testing project in between runs of the integration testing.
Specific request from this code review:  Look at the way I implemented the parameters for this cmdlet and let me know if I'm going in the wrong direction with this.

Just going to reply once to all of the formatting changes instead of replying individually. I went through and addressed all of them, either sticking exactly to the changes or rewording the surrounding language.   I'm going to have to push the changes in with the next set because of the git mishap.  It should be fixed as soon as I can get the next changeset patched in, and then I'll go back to small commits.


PR: Replace deprecated imp with importlib

Description of Changes
imp is deprecated and should be replaced by importlib. I have changed all but one of the places where it was used. Not sure what the code in get_parent_util exactly should do.

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: oscargus

Not sure what the code in get_parent_util exactly should do.

Where is the code for that? I can't find it in our sourcecode.

spyder/plugins/completion/fallback/utils.py
But I think I figured out how it works now, so that is also replaced in the new version.


refactor: add cs_mapSocketToNode and cs_sendable_receivable_nodes to …

…minimize cs_vNode contention (and document an undocumented lock requirement)
Please remove the italicized help prompts before submitting or merging
Provide a general summary of your changes in the Title above
Pull requests without a rationale and clear improvement may be closed
immediately.
Please provide clear motivation for your patch and explain how it improves
Dash Core user experience or Dash Core developer experience
significantly:

Any test improvements or new tests that improve coverage are always welcome.
All other changes should have accompanying unit tests (see src/test/) or
functional tests (see test/). Contributors should note which tests cover
modified code. If no tests exist for a region of modified code, new tests
should accompany the change.
Bug fixes are most welcome when they come with steps to reproduce or an
explanation of the potential issue as well as reasoning for the way the bug
was fixed.
Features are welcome, but might be rejected due to design or scope issues.
If a feature is based on a lot of dependencies, contributors should first
consider building the system outside of Dash Core, if possible.

Issue being fixed or feature implemented

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.

What was done?
Describe your changes in detail
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran
to see how your change affects other areas of the code, etc.
Breaking Changes
Please describe any breaking changes your code introduces
Checklist:
Go over all the following points, and put an x in all the boxes that apply.

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[ ] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Guix Automation has began to build this PR tagged as v21.0.0-devpr5956.ef2162a1. A new comment will be made when the image is pushed.

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v21.0.0-devpr5956.ef2162a1. The image should be on dockerhub soon.

Did a trivial force-push; prior CI was happy: https://gitlab.com/dashpay/dash/-/pipelines/1226758401


Implementation of  Docker Containerization for the  Application

Title: Docker Containerization Implementation
Objective:

Implement Docker containerization to streamline deployment, enhance scalability, and improve portability across different environments.

Benefits:

Streamlined Deployment: Consistent deployment across platforms reduces issues.

Improved Portability: Facilitates migration between environments.

Simplified Maintenance: Easier management and updates without system impact.

Hey @Dev-tanay I want to work on this!! Please assign this to me! Please add GSSoC'24 label in this issue.

@Dev-tanay kindly assign this issue to me

Kindly mark level as level 1,level 2or level 3 with GSSOC for issues.

@MrudulaTeegala already solved and raised pr for this issue!


rfc: control plane installation debugging

We've got an awesome tool with check, it would be great to do some extra integration with documentation to make it even better (and selfishly, make writing docs easier).
Integrate check into install
Instead of piping install into kubectl, we could take care of that ourselves, running some pre and post-flight checks on the install command. Something potentially like this:
==== Preflight checks ====
Cluster Config                              ✓
Cluster Connection                          ✓
Cluster Version                             ✓
Cluster Permissions                         ✓

==== Cluster Environment ====
Adding conduit to the cluster                 ✓
Waiting for control plane to be healthy              ✓

==== Postflight checks ====
Cluster Service                             ✓
Service Health                              ✓
Service Version                             ✓

==== Install Complete ====

Add possible solutions and/or links to documentation on error
Right now, we show that an error occurs (with a message), but the messages aren't particularly helpful:
kubernetes-api: can initialize the client..................................[ok]
kubernetes-api: can query the Kubernetes API...............................[ERROR] -- HTTP GET request to endpoint [https://localhost:6443/version] resulted in error: [Get https://localhost:6443/version: dial tcp [::1]:6443: connect: connection refused]
conduit-api: can query the Conduit API.....................................[ERROR] -- Post https://localhost:6443/api/v1/namespaces/conduit/services/http:api:http/proxy/api/v1/SelfCheck: dial tcp [::1]:6443: connect: connection refused
conduit-version: control plane is up-to-date...............................[ERROR] -- Post https://localhost:6443/api/v1/namespaces/conduit/services/http:api:http/proxy/api/v1/Version: dial tcp [::1]:6443: connect: connection refused

A possible enhancement:
kubernetes-api: can initialize the client..................................[ok]
kubernetes-api: can query the Kubernetes API...............................[ERROR]
    -- Unable to contact the Kubernetes API, can you run `kubectl cluster-info`?
    -- For more suggestions, see https://conduit.io/docs/troubleshooting#api-fail
    Error:
        HTTP GET request to endpoint [https://localhost:6443/version] resulted in error: [Get https://localhost:6443/version: dial tcp [::1]:6443: connect: connection refused]

Instead of piping install into kubectl

I like the idea of automatically running post-install checks. However, I also think there's value in having install just output yaml rather than actually changing the cluster. The current approach allows the install output to be manually inspected (and changed) before it's applied, or saved to a file so it can be applied multiple times (which I've found useful for testing). I think these advantages of the current approach are worth maintaining.
Perhaps there should be two commands, one that outputs yaml as we do currently, and one that does the entire install process plus checks?

@hawkw 100% agreed, I'd go for a flag on install conduit install -o yaml personally. Either that or a separate command is a requirement.

Instead of piping install into kubectl

Myself, I would never let conduit install modify my (production) cluster itself; i would always go through the conduit install > conduit-install.yml, manually review conduit-install.yml, kubectl apply -f conduit-install.yml process. One advantage of conduit install | kubectl apply -f - is that it hints that such a careful installation process is possible, succinctly.
In particular, we originally decided on the current approach because we wanted people to be able to see how we are changing the cluster by letting them inspect the yaml, because we thought that people wouldn't just trust conduit install to do something reasonable. Also at the time we thought people might version control the output of conduit install in order to keep a history of changes to the configurations.
We can change the approach so that the piping into kubectl is avoided, and provide a "output the yaml" option to let people inspect the configuration. However, this raises the question "Does the yaml completely describe everything that is done?;" i.e. it creates some confusion about what happens during install. Also, currently the conduit tool is always safe in the sense that it is read-only, i.e. it never changes anything (IIRC). Finally, you can save the conduit install output once and replay it to multiple clusters (e.g. in minikube on my laptop, and then in GKE after testing it) and you know that it is the same configuration. With conduit install doing the kubectl apply itself, it wouldn't be clear that it would install the same configuration each time it is given the same inputs.
Note that all of this applies to conduit inject too.
Anyway, don't interpret these comments as being -1 (or +1) to such changes. I just want to provide context regarding the original (current) design.

Regarding the overall idea, I think it's important that we have a very good pre-install check mechanism (that can be done separately from the install), and a very good post-install check mechanism (that can be run separately from the install). Increasing the thoroughness of those checks is the most important improvement we can make, IMO. Finding problems (e.g. RBAC isn't enabled) and automatically generating a script that can fix those problems is the second most important thing we can do.
Having a "one step" install that does everything is harder for me to see the value in, because I don't think a one-step install is what one would do in a production deployment, realistically. A one-step install does look good in a demo because it makes conduit look easy to install, but it seems like pure demo-ware. We'd have to document the careful approach in addition to the one-step approach so it won't actually simplify the documentation to have a one-step option (default or otherwise).

That's a great point, I had conflated everything a little bit too much (though I still like the one shot install). Maybe everything could be scoped to the check command?

conduit check --pre
conduit check --post

conduit check --pre

can init k8s client
can query API
minimum version
has permissions
isn't already installed

conduit check --post --wait

components are ready
can query api
up to date

LGTM. Maybe --post should be the default? I slightly prefer conduit pre-install and conduit check but if you don't love those names then no use bike-shedding.

I like conduit check running through everything by default, with --pre and --post just being filters (maybe conduit check --groups=pre,post?).
Having a separate command for running the pre-flight makes sense, especially for first users to find the functionality without docs, just feels like a little duplication maybe?

I dunno why not. I do like the idea of having groups in the future, something like:
# conduit check
==== Pre-Install ====

==== Post-Install ====

==== Ready for Upgrade ====

==== Upgrade Success ====

(Feels like we'd want some kind of pre/post-flight and upgrade automation as well)

Potential additions to conduit check --pre:

Host kernel version isn't among those affected by #982
Some kind of validation of the cluster's networking config?

#139 is something worth working on at the same time.

A potential check that might be helpful:
https://github.com/kubernetes/node-problem-detector

See #1421 for another thing to check (NetworkPolicy).

Sorry for chiming in late here. I really like the way that the spec for these checks has evolved. I just wanted to add:
Maybe we don't need to support a --post flag? We can certainly divide the checks up into pre-install and post-install (and only run the pre-install checks when the --pre flag is set), but I don't think it will ever make sense to run the post-install checks in isolation. The post-install checks will fail in weird ways if the pre-install checks fail, so we should validate that the pre-install checks pass as part of running the post-install checks
In other words:
linkerd check --pre
# runs only pre-install checks
# intended to be run before linkerd is installed

linkerd check
# runs both pre- and post-install checks
# intended to be run after linkerd is installed

That seems easier to grok from a user's perspective, too.

Note that there are also a few pre-flight checks described above that we should only run when the --pre flag is present, and we should skip when running pre- and post-flight checks together. Namely:

has permissions to install
isn't already installed
has resource requirements
can pull images

Maybe we don't need to support a --post flag?

Makes sense to me. Some part of me would like to have multiple sections of checks that you can run individually. I don't have a good use case for that though, so it is likely over-engineering at this point.

Ok, sounds good. And as part of #1417 we should consider at least grouping the check output into multiple sections. Down the road we could add support for running individual sections if that makes sense.

I think there may be another scenario that we may need to think about and correct me if we do not need to worry about it. Should we also consider having an optional flag for linkerd install to also run these pre and post-flight checks? It sounds like a possible use case for this feature would be: Run linkerd check --pre then run linkerd install then linkerd check. It feels like there is some value in having this feature baked in the install process as an option.

@dadjeibaah the original suggestion was to have linkerd install just take care of it all for you (and wait until everything was healthy). The more I think about it, having install do nothing more than output some YAML is best behavior we can have.
Since most folks will do an install by following the getting started documentation, we can have them use the pre/post checks as part of the process and still have the ability for folks to see exactly what is happening to their cluster and potentially change it for their specific use cases.

I'm going to close this, since pre- and post-install checks are now available via the linkerd check command, and fleshing out the set of checks that we run pre- and post-install is ticketed in separately (e.g. #1474, #1475, #1732, #1741).


Dependabot keeps opening PR:s when merging one, even though schedule is set to once a week.

As soon as a dependabot PR is merged in the repo dependabot starts checking for new updates and opens another one, even though the schedule is set to only check once a week.
is this expected behaviour? I could not find anything about that being the case in the documentation.
version: 2
updates:
  - package-ecosystem: 'npm'
    directory: '/'
    schedule:
      day: 'thursday'
      interval: 'weekly'
      time: '02:00'
      timezone: 'Europe/Stockholm'
    open-pull-requests-limit: 10
    ignore:
      - dependency-name: '@material-ui/core'
        versions:
          - '> 4.11.4, < 4.12'
      - dependency-name: '@material-ui/core'
        versions:
          - 4.11.4
      - dependency-name: styled-components
        versions:
          - 5.2.2
      - dependency-name: eslint-plugin-react
        versions:
          - 7.23.0
        # Broke linting jobs
      - dependency-name: eslint-plugin-import
        versions:
          - '2.23.x'

See https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/about-dependabot-version-updates#frequency-of-dependabot-pull-requests for some info on this.
It is expected that when you modify the manifest (e.g. by merging a PR), we'll re-check, so it's possible that if you're at the PR limit, we'll open new ones up to that limit.


avatar record doesn't work for domains with unicode characters

getResolver() is returning null for domains containing unicode here:
https://github.com/ensdomains/ens-metadata-service/blob/dd6a1b1608eac9219d6aa9fc6baba05b7e1a6694/src/avatar.ts#L258
This is resulting in domains with otherwise correctly set avatar text fields not working as intended.
e.g. https://metadata.ens.domains/mainnet/avatar/👑scott.eth

i've set the avatar for ✨ben✨.eth 4 times now lol

doing a NFT didnt work bc I tried to set videos so thats a separate problem nbd
Reached out to support for help and was told I can do an IPFS hash in addition to NFTs
doing an IPFS hash didnt work
this is the IPFS hash i used: ipfs://QmU2qw9pti3cA95dva7cGyMFBY6ra98cGzFjuaYsqwSeKt

Thank you for making emoji names work! <3

after ethers been updated, I am seeing all of the names listed here are working.
only ✨ben✨.eth  has an issue with the NFT, but it appears to be on the NFT contract side rather than metadata service.
I am getting call_exception when try to get metadata of the NFT from it's own contract;

using another NFT, or contacting with the team of current set NFT may help solving.


Add CICD pipeline to build/release app

Work Summary

Please don't merge it now, as there're some prerequisites needed
Add CICD pipeline to automate the process to build/release app

Closed as of implementing in a later stage for CD pipeline


withMPD raises IOException instead of returning Left (ConnectionError e)

*** Exception: Network.Socket.connect: <socket: 41>: does not exist (Connection refused)

I think it's supposed to return Left (ConnectionError e) instead of raising an IOException.
For now, I work around the issue with
import System.IO.Error (catchIOError)
import qualified Network.MPD as M

catchIOError (M.withMPD M.status) $ return . Left . M.ConnectionError

This happens to me as well.  On my machine "localhost" first resolves to ::1 but MPD isn't listening on the IPv6 interface so the connection fails.  Other tools (such as ncmpcpp) fall back to <IP_ADDRESS>.

Happy to accept MR's for the same.


Assert other response headers

Hi!
Would be cool if there was a way to access additional headers from a request besides status code.  Access to Content-Type would be amazing!

Thanks for the feedback, sounds like a great idea..leave it with me


[C++] Ensure sorting Table, RecordBatch can sort Struct and Dictionary cols

Reporter: Alessandro Molina / @amol-
Note: This issue was originally created as ARROW-18002. Please see the migration documentation for further details.

Some relevant discussion on the topic at https://github.com/apache/arrow/pull/14369#issuecomment-1292126171


how to use flow and bind function ?

📖 Documentation
I discover pipeline + bind example.
  optPlus(a: Option<number>, b: Option<number>): Option<number> {
    return F.flow(
      O.bind("_a", () => a),
      O.bind("_b", () => b),
      O.map(({ _a, _b }) => _a + _b)
    )(a);
  }

this code is rigth? or more better  way to write it?
I think there is a better way to use O.Do. ?_?

There are a few different ways to improve upon this.
Firstly, to attempt to unwrap/invert multiple values sequenceT is arguably preferable to do notation (which bind et al emulate).
Secondly, flow serves no benefit over pipe - if anything it hinders readability - if your code is not "point-free" / "tacit". Whilst it doesn't apply in this case, you'll want to try writing curried functions by default to aid in this endeavour.
Finally, this specific problem can be solved via O.getMonoid and Num.MonoidSum, whereby its concat function corresponds to addition over Option<number>.

In PureScript, you would do
optPlus fa fb = do -- this uses bind (>>=) from Monad
    a <- fa
    b <- fb
    pure $ a + b

Since a and b are independent from each other (e.g.: Promise.all), you also have ado
optPlus fa fb = ado -- this uses ap (<*>) from Applicative
    a <- fa
    b <- fb
  in
    a + b

Which the same as:
optPlus fa fb = plus <$> fa <*> fb
  where
    plus a b = a + b

indw

Links to documentation:
https://gcanti.github.io/fp-ts/guides/do-notation.html
https://gcanti.github.io/fp-ts/guides/purescript.html#wheres-my-f--fa--fb

Happy new year !
Sorry for the late reply.
This is exactly the thing I wanted. thx!
const optPlus = (fa: Option<number>, fb: Option<number>) => F.pipe(
    O.Do,
    O.apS('a', fa),
    O.apS('b', fb),
    O.map({ a, b } => a + b),
)

And I learned it

if anything it hinders readability - if your code is not "point-free" / "tacit".
unwrap/invert multiple values sequenceT is arguably preferable to do notation (which bind et al emulate).

in future use pipe + sequenceT.
We will also share a monoid implementation example for anyone searching for this issue.
import * as O from "fp-ts/lib/Option";
import * as Num from "fp-ts/lib/number";

optPlus(a: Option<number>, b: Option<number>): Option<number> {
  return O.getMonoid(Num.MonoidSum).concat(a, b)
}


Add-column-btton-CSS

This has been open/approved for a while @khashshafiei -  is this something we should merge? If not, let's close it out


flutter_rust_bridge_codegen broken

Somehow flutter_rust_bridge_codegen broke at some point today. My CI was failing because of it, so I decided to dig into it a bit more. It turns out to be broken for all new installs. Installing a fresh copy of it via cargo install flutter_rust_bridge_codegen fails with the following error message:
 Compiling flutter_rust_bridge_codegen v1.77.1
error[E0451]: field `config_path` of struct `Config` is private
  --> /Users/wouter/.cargo/registry/src/github.com-1ecc6299db9ec823/flutter_rust_bridge_codegen-1.77.1/src/commands.rs:99:11
   |
99 |         ..Default::default()
   |           ^^^^^^^^^^^^^^^^^^ field `config_path` is private

For more information about this error, try `rustc --explain E0451`.
error: could not compile `flutter_rust_bridge_codegen` due to previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `flutter_rust_bridge_codegen v1.77.1`, intermediate artifacts can be found at `/var/folders/65/nl89nzxs5jx73y5n5515tc1w0000gn/T/cargo-installp3vlnI`

Not only version 1.77.1 doesn't work, I also tried 1.76.0 with no luck...
Something really strange is happening here, since my build worked fine yesterday with the exact same version and with exactly the same code and environmet. The field config_path is also nowhere to be found in the first place.
Any guesses as to what is happening?

Weird indeed, same issue here with 1.76.0:
   Compiling flutter_rust_bridge_codegen v1.76.0
error[E0451]: field `config_path` of struct `Config` is private
  --> C:\Users\Sander\.cargo\registry\src\github.com-1ecc6299db9ec823\flutter_rust_bridge_codegen-1.76.0\src\commands.rs:99:11
   |
99 |         ..Default::default()
   |           ^^^^^^^^^^^^^^^^^^ field `config_path` is private

For more information about this error, try `rustc --explain E0451`.
error: could not compile `flutter_rust_bridge_codegen` due to previous error
error: failed to compile `flutter_rust_bridge_codegen v1.76.0`, intermediate artifacts can be found at `C:\Users\Sander\AppData\Local\Temp\cargo-installye7coq`

At first I thought maybe 1.76.0 and 1.77.1 are overwritten but I don't think crates.io support overwriting a already released version at all...

Looks like a fix might be available soon: https://github.com/fzyzcjy/flutter_rust_bridge/pull/1232

Let's hope so. It doesn't explain why it worked yesterday and broke today tho... 🤔

Seems related: https://github.com/fzyzcjy/flutter_rust_bridge/pull/1232

@h3x4d3c1m4l Oh yes, that PR

Mozilla fixed it. Build it working again.


[ci] resume unit test in ci

ignore flink failover ut temporarily to avoid blocking in ut.
deduplicate flink ut log

#35 had been merged, so you can merge the master branch and try again


New: chart-gauge directive

Added 'min' and 'max' attributes that control a gauge's minimum and maximum
range values.

Thanks, will create a sample before committing this change. Do my best to do this fast

Thanks for the code, added more config options and a sample.

Thanks, I'm very impressed at how fast you accepted the pull :)
On 18 Apr 2015, at 18:47, Jettro Coenradie<EMAIL_ADDRESS>wrote:

Thanks for the code, added more config options and a sample.
—
Reply to this email directly or view it on GitHub.


Implement DataTable on Web UI to be able to see many resources

What type of PR is this?
/kind feature

What this PR does / why we need it:

Reorganization of the directories of some current resources List components.
Implement DataTable on web UI. This tableview is switchable to the current resources list view.
simple searching.
sorting.
clickable to edit and delete.

Which issue(s) this PR fixes:

Fixes #96
Special notes for your reviewer:
Samples

clickable

/hold
/label tide/merge-method-squash

/ok-to-test

/assign

@196Ikuchil
Some feedbacks.
For Pod table,

Status is not needed. (Because it's always pending).

For Node table,

Namespace is not needed. Node is not namespaced resource.
Conditions  and Status is not needed.
Capacity should show each resource(CPU, memory, and pod)

For PV table,

Namespace is also not needed. not namespaced resource.
PVReclaimPolicy is not needed.

For PVC table,

Status is also not needed. same reason as Pod.

For SC table,

Namespace is not needed. same reason.
Parameters, Reclaim-Policy, and Volume-Binding-Mode are not needed.

For PC table,

Namespace is not needed. same reason.

And for all tables,

Update-Time is not needed. (Sorry I said that it was needed tho 🙏 )
The length of the Search box should be the same for all tables.
change not to use -. Use the exact name instead. (like CreationTime, GlobalDefault...)

Others

Move "List, Table" switch to top bar.

And, in current implementation, Node on Pod table is not updated.
I raise it as another issue because this is not a problem specific to this feature.
https://github.com/kubernetes-sigs/kube-scheduler-simulator/issues/120

Hi @sanposhiho
Thanks to the reviews. I generally understand.
I have two questions.

Status
On PVC, there are possibilities to take other values. Is status not needed?Ref:kubernetes.io/docs/reference/generated/kubernetes-api/v1.23/
(Note: On other resources, I have checked that the status parameter is Deprecated. For example, PodStatus. Therefore, I will remove it from the table.)

Move "List, Table" switch to top bar.
I think it shouldn't move. This is because the buttons should not be placed far from the table. Isn't it hard to tell what the switch is for?
And also the button's component file should be placed under the ResourceViews directory.

On PVC, there are possibilities to take other values. Is status not needed?

Yes. Not needed. This value is not much related to scheduling. (This is "scheduler" simulator, so columns that are not related to scheduling are not needed basically.)

This is because the buttons should not be placed far from the table. Isn't it hard to tell what the switch is for?

It's a fair point. But it is the same even in its current location. It is only when the user touches it that they realize it has something to do with how it is displayed.
How about removing the button and change the UI with env.
Like ALPHA__TABLE_VIEWS. If ALPHA__TABLE_VIEWS == true (or 1?), use the table to show resources.

I think one of the strengths of the current view is "It's easy to see where Pod is."
Conversely, if we can achieve this strength in table view, we can replace the current UI with table view completely.

/retitle Implement table view on Web UI

Conversely, if we can achieve this strength in this table view, I think we can replace the current UI with table view completely.

This does not mean that I want you to make changes that way in this PR. I think we can merge this PR first, and then make improvements for that. (Otherwise, this PR will become too big.)

How about removing the button and change the UI with env.
Like ALPHA__TABLE_VIEWS. If ALPHA__TABLE_VIEWS == true (or 1?), use the table to show resources.

Understood. In this PR, we use env value.
And we expect that the current view will replace this table view in nearly future.

@sanposhiho
Fixed it✋
I also updated the documentation and screenshots at the top of this PR.
https://github.com/kubernetes-sigs/kube-scheduler-simulator/pull/119#issue-1148249561

/unhold


Is Safari having issues with caniuse?

I got really confused looking for CSS Variables. Search for 'CSS Variables' found nothing. 'var' only "Variable Fonts" topic with no scroll then increasing items.
Fyrd got interested in my misplaced wailing. Alexis sent me a link and after that the issue went away.
Fresh macOS install here, 8-core 64 macPro Airport on Shaw Cable at 180mbps.
Thread is here (edited 1,000 times in an hour as things devolved).
https://github.com/Fyrd/caniuse/issues/4269#issuecomment-390862029

Works for me...what version of Safari are you using?


Easy to fix issues

Hey,
I want to contribute to this project. What are some easy issues I can work on?

I found that there a lots of features needed to be implemented. I guess you can start there.

But I don't which would easier to tackle and which ones are hard. My familiarity with scheme is very minimal so I am looking for a more elaborate description.


Event propagation in web components

We aligned all event names in our components package but we now have to check their propagation.
Take this example:
<post-accordion heading-level="1">
  <post-accordion-item>
    Titulum 1

      <button class="btn btn-secondary btn-large" data-popover-target="popover-one">
        Click here to see a popover
      </button>

    <post-popover class="hydrated bg-primary" id="popover-one" placement="top" arrow="">

Optional title

        A message that needs time to read. Links are also possible.

    </post-popover>
  </post-accordion-item>

  <post-accordion-item>
    Titulum 2

Contentus momentus vero siteos et accusam iretea et justo.

  </post-accordion-item>
</post-accordion>

THen, when listening to postToggle event on the post-accordion, you get notified both when a post-accordion-item is toggle AND when the popover is toggled:
document.querySelector('post-accordion').addEventListener('postToggle', (e) => {
  console.log('Emitted by post-accordion:', e);
});

This behavior should probably be prevented.
### Tasks
- [ ] Research how similar native events work and adapt the event to align with them

Currently, several components emit a postToggle event. When these components are nested, this can lead to event name collisions and unintended behavior when listening to the event at a parent level.
Possible solution:

[ ] Introducing a more specific naming convention for toggle events to avoid collisions.

For example:
post:accordion:toggle
post:popover:toggle

Investigate and propose a generic way of handling this https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Building_blocks/Event_bubbling


Feature Request : Add code snippet in Story

First of all, thank your for this project.
It is easy to use, and nice to see.
Here is a feature request we might like for upcoming updates : Add a possibility to add a code snippet on a component Story
It would be great to see a minimum code to use to implement the demonstrated widget.

I was thinking about something similar. We could provide these code snippets as md files. These could also be used with @example in the dartdoc (or we could reuse existing md files). We would then create a plugin for the storybook that uses flutter_highlight to display the code snippets.
I'm just unsure how to assign md file(s) to a story.
And this should probaly wait, until the rework of the plugin api is finished.

Yeah, makes sense to me. I was also thinking about some code generation for snippets etc – e.g. it can be taken from the docstrings.

Any update on this, or any instruction on how it can be added to the lib. I would gladly help on creating a PR. @ookami-kb


[BUG] - Active learning fails after deleting records

Describe the bug
Active learning fails after I deleted a record that was manually labeled
To Reproduce
@LakshmiPanguluri please correct me if I got this wrong :)
Steps to reproduce the behavior:

Create a project and label some data manually
Create and run an active learner
Delete a record which has a manual label
Run said active learner again

Expected behavior
The active learner should skip the record, i.e. work as normal
Screenshots

Desktop (please complete the following information):
-
Additional context
Mentioned by LakshmiPangukuri in the discussions thread #181

Im assuming this is due to a missing reupload of the embedding data after deletion

Hi,
Thanks for the response. I am able to run after rerunning through embedding
step after deleting record.
Best Regards,
Lakshmi
On Fri, Nov 18, 2022 at 5:53 PM JWittmeyer @.***> wrote:

Im assuming this is due to a missing reupload of the embedding data after
deletion
—
Reply to this email directly, view it on GitHub
https://github.com/code-kern-ai/refinery/issues/182#issuecomment-1319928921,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGBIQGXKSRVQJ4P3FLXLJUTWI5YL3ANCNFSM6AAAAAASEG6RVE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks, makes sense. It is in our backlog :)


feat: Stop using ts-node as a default loader for parsing TS configs

Summary
Breaking Change
Currently ts-node is set as a default loader for parsing TS configs, this PR changes that behavior because now there are other good alternatives like esbuild-register so it's better to stop doing anything by default and let users specify which module they wanna use (according to their use case) in a docblock comment  for loading their ts configs.

Test plan
Fixed e2e tests

would be great if we could remove the peer dependency on ts-node as well 👀


Feature request

Hi.
I see you are actively working these days on migrating to NimBLE . Thank you!
I have some feature requests for the next version. I hope you can include some of them.

To make public _sampleIntervalMs or publish a method to change it, so the application using the library can choose the logging interval on init (right now it starts hardcoded at 600000, 1 minute, and user must go into the App after each firmware restart to set again their preferred sample interval).

To be able to change SAMPLE_BUFFER_SIZE_BYTES dynamically via a method (at least on init) so it can be adapted to different use cases.

To make the _sampleBuffer public, or include some methods to read it, so this data can be used to, for example, make a chart with the logged data.  I would like to implement some charts on my CO2 meter project  but right now I must duplicate this data in my own buffer (a waste of memory).

Question: Is it possible to init the library (GadgetBle gadgetBle = GadgetBle(GadgetBle::DataType::T_RH_CO2_ALT)) in a mode that the App shows just CO2? It looks like the App is capable of it but can't find how to do it.
I need this option to "hide" temperature and humidity readings when the sensor is mounted in a very constrained space, so readings are affected by heat emitted by the surrounding components.

Thank you very much and, please, keep working on this great project!

Hi @melkati
Sorry for the late answer. We are currently refactoring the library to provide better interfaces and architecture. Thank you very much for your input. I will check if we can support your requests in a future version.
1.) Yes this is a good point. In the app we only support a specific set of logging interval. To not break the app we would also need to limit the selection on supported logging intervals.
2.) The buffer is allocated on the stack, so there is no easy way to dynamically change this size without changing the library code.
3.) The sample buffer is a ring buffer used as an internal data structure for the history download feature. I have to check if we can provide a reliable interface to get the data for local plotting.
Currently the library only supports a data type for CO2 which also includes relative humidity and temperature. The RH/T values are removed by the App based on the gadget type. Unfortunately to support this at the moment a couple of changes to the library are required in the header:
static const char* const GADGET_NAME = "MyCO2";
static const size_t MAX_SAMPLE_SIZE = 8;

I will see if we can support an additional data type that only reports CO2 values in a future version

Hi @melkati
Small update. BLE Gadget library 0.14.0 or later supports a new data type to only report CO2 values (without humidity and temperature)


Day D Tower Rush [PCSB00540]

App summary

App name: Day D Tower Rush
App serial: PCSB00540
App version: 1.00

Vita3K summary

Version: v0.1.8
Build number: 3271
Commit hash: https://github.com/vita3k/vita3k/commit/37e334b3
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary
Tested by: space1
OS: Windows 11
CPU: AMD Ryzen 5 3600
GPU: Nvidia 3070
RAM: 32 GB
Issues
Some elements blink ingame, and audio crash in second level.
Screenshots

Log
PCSB00540 - [Day D Tower Rush].log
Recommended labels
ingame+
audio quality

Vita3K summary

Version: v0.2.0
Build number: 3690
Commit hash: https://github.com/vita3k/vita3k/commit/f0285143
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary

Tested by: Slade
OS: Microsoft Windows 10 Professional (build 19045)
CPU: Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz
GPU: NVIDIA GeForce GTX 1060 6GB
RAM: 16 GB

Issues

Game no longer reaches menu and crashes shortly after running.
Subsequent attempts to start the game result in crashes at slightly different times, but usually at the splash screen.

Screenshots

Log
vita3k.log
Recommended labels

Intro
crash
regression


Hangovers from rename to bach

There are still a few references to this project prior to it being relocated to https://github.com/sonatype-nexus-community/bach and renamed bach.

README
composer.json

Also, unrelated:

PHAR archives can be committed accidentally
PHP Unit configuration using out of data schema
build-phar.php is sub-optimal

See https://github.com/sonatype-nexus-community/bach/pull/34


Support for cloning message in python client SDK

It would be nice to support message copy/clone so that it would be easy to copy content and properties for easily resubmitting new message.

Closed as stale.
The development of the Python client has been permanently moved to https://github.com/apache/pulsar-client-python. If it's still relevant, please open an issue there.


websocketd output miss

I didn't get I wanted output by websocketd.
I directly run bellow script, output is:
cmdline: /usr/local/bin/python3 -ubq ./show.py
this is backend!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
this is a file 0
this is a file 1
this is a file 2

But when i  run websocketd, missed some output.
cmdline: ./websocketd --port=8080 python3 -ubq ./show.py
Output in html:
this is a file 0
this is a file 1
this is a file 2

Why missed some output?

Oh I got it. But how can I know it's time to send msg?
When websocketd catch stdin, but didn't send msg to frontend?
Can websocketd can send a flag to frontend when catch stdin.

I wonder if you could share your HTML code. IMO things should not be missed. Could you share your HTML code perhaps?

Any news, @Dustyposa ?

@asergeyev Oh,sorry. I had forgot this thing. Now,it's greate for me. Thanks.


strange bug : the microphone is triggered in Google Chrome when press the RCtrl button

This is my reddit post: (After checking this problem, I found out that the problem is with MouseTooltipTranslator extension, whenever I disable it, this problem is solved)
https://www.reddit.com/r/chrome/comments/1cs4jr8/the_strangest_problem_in_history_the_microphone/
It is very very strange
When I press the RCtrl button on the keybooard ,A request to activate the microphone for that site will pop up (Image below)
https://i.imgur.com/IE0cAoP.png
LCtrl does not have this problem
This problem exists in every site
This problem does not exist in Microsoft Edge
I killed all the programs and tested again, but this problem still exists
OS : Windows 10
Google Chrome is always updated

I recently added speech recognition translate feature
You can change key from SPEECH - speech recogntion when

@ttop32
Thank you bro


docs(storybook): add theme addon

:tada: This PR is included in version 3.0.0-beta.20 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Pre hash columns before committing to wal

Closes #685

I think there's also a TODO we can delete in db.go. I don't see any prehashing in the recovery path though, am I missing something?

I think there's also a TODO we can delete in db.go. I don't see any prehashing in the recovery path though, am I missing something?

@asubiotto can you share the link to this so I can take a look?

https://github.com/polarsignals/frostdb/blob/67e37c6b4582b0a8b7f592d909aadca299b7b9c7/db.go#L913

thanks


Settings: integration

Problem
In the setting page, a user can decide to integrate another discord server. Selecting the button lets me decide a time frame and the channels, but not pick another discord server.
Solution
Remove the option to integrate another community (I thought this is what we decided in a call)

Sorry, we haven't this part in the last version (It's finished today and I'm waiting for Behzad and Mehrdad to push their side on master) So, after that, I think you can recheck it.


Enable flags to be context specific to the subcommand that is using them

make it so that flags are subcommand specific, example --private-key is boolean for solo account get whereas, string for solo account create.
Note:
I think this should already be do-able without any changes needing to be made.  All we have to do is create a second flag and make name of the variable different, we can still re-use the same alias and same CLI name, but have different descriptions and different meanings.  As long as the two overlapping flags are not used within the same subcommand.

closing:
I think this should already be do-able without any changes needing to be made. All we have to do is create a second flag and make name of the variable different, we can still re-use the same alias and same CLI name, but have different descriptions and different meanings. As long as the two overlapping flags are not used within the same subcommand.


Add files via upload

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] local build the book
[ ] review the artifacts from local build
[ ] local build the slides if appliable
[ ] Unit test if appliable

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have applied tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

add a folder named numpy which includes 4 files called numpy1~4.md

Nothing other than the folder is needed, so please do not upload it!


Add configurable dir to tempfilemunge vi TEMPFILEDIR

Allow configuring which directory TEMPFILEMUNGE creates it's temporary files in.
Added env['TEMPFILEDIR']
Contributor Checklist:

[x] I have created a new test or updated the unit tests to cover the new/changed functionality.
[x] I have updated CHANGES.txt (and read the README.rst)
[x] I have updated the appropriate documentation

@dmoody256  - this should remove the bit in the generate about controlling tempfile generated file locations?

@dmoody256 - this should remove the bit in the generate about controlling tempfile generated file locations?

Yeah that should fix the bit about where controlling where tempfiles are created.
Theres also a bit about controlling the deletion of the tempfile after the command is executed. I'm not sure if this is some obsolete comments left in or something, because ninja generator evaluates the nodes without actually executing anything, so not sure why it cares about the command list with 'rm' in it generated from TempFileMunge.
Anyways this looks like it would be used for that last bit about setting the mkstemp location.


Respect sidekiq_options overridden by .set

Sidekiq provides a Sidekiq::Job.set(…) API which can override sidekiq_options set at the class level, on a job-by-job instance basis. Sidekiq does the work of merging the options from set with those from the class-level sidekiq_options, into the "job" (really a normalized hash) that's handed to the middleware. So if we first look there for any debounce: options, rather than going to the klass.get_sidekiq_options, we can respect any overrides from the .set API.
In this commit I left the klass.get_sidekiq_options as a fallback, though I'm not sure that's actually necessary.
NOTE: This Sidekiq does not (currently?) deeply-merged nested options.
I've asked about this elsewhere: https://github.com/sidekiq/sidekiq/discussions/6366

Hello, we are currently testing v3 version of the gem with completely rewritten code, it should be released pretty soon. I'll make sure to include this fix in the release

Hi @kukicola. I saw the re-write underway, and this code should fit there as well since it's only to do with how the job's options are fetched, and not really anything to do with the debouncing machinery. If there's a stable branch for v3, I can open a PR targeting that branch too.

@stevenharman sorry for the very delayed response. v3 branch has been merged to the master, can you rebase?

@kukicola rebased, and included another commit to fix some deprecations in the tests.


Fix: type support for suspense and fallbackData(#2396)

close https://github.com/vercel/swr/issues/2396

Thanks for the PR, can you add some typing tests for it?

I understand, I'll try it!

This would be a huge fix for us! 🎉 Can we expect a swr release soon?


Introduce Snyk in CloudNativePG pipeline

Evaluate the introduction of Snyk in the pipeline to shorten the feedback for vulnerabilities and third party dependencies.

https://snyk.io/plans/

Have you considered Github Dependebot? It's built-into GitHub and free to use for opensource projects.

The project was submitted to the opensource campaign


R200 does not work anymore after last commits

| Required Info  |   |
| Camera Model | R200 |
| Firmware Version | <IP_ADDRESS>  |
| Operating System & Version | Ubuntu 14.04  |
| Kernel Version (Linux Only)  | 4.4.0-040400-generic  |
| Build System |  Makefile |
Hello,
after the last commits, our R200 does not work anymore... The log is attached. However, the camera still works with the older version of the code. Is it possible to fix it?
ba$ ./bin/cpp-capture
rs.warn: Camera head contents version != 12, data may be missing/incorrect
*** Error in `./bin/cpp-capture': corrupted double-linked list: 0x0000000002664e30 ***
Aborted (core dumped)

@dorodnic can your team look at this ASAP?

@mdhorn can the ROS team replicate this issue?

@ddiakopoulos This is makefile problem. The latest updates doesn't account for all file dependencies.
The problem reported can be reproduced by:

checkout previous working version (say the v0.9.2 tag)
make clean
make
sudo make install
checkout master
make
make install

If you do a 'make clean' after checking out the HEAD of master before the 'make' and 'sudo make install', the problem does not occur.
The latest change to the Makefile doesn't account for all dependencies so not all required files are rebuilt from sources.

There has been a lot of small changes to the makefile lately, we will localize and resolve shortly.
As Mark has mentioned, there is a simple work around. However, if necessary you can always fall back to 0.9.1.

The code works for SR300 but not for R200

Should be resolved now.
Please retry with latest sources and let us know.

Thank you! now it works again !


Use the safe write method to write to disk for all objects

Goal

Testing

Release Notes

WHAT:
WHY:
WHO:

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#583  👈
#582
#581
#579
#577
#576
#575
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on  Graphite

Merge activity

Mar 18, 11:27 AM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.


Tag a New Version?

0.1 was tagged in January 2014. There's a lot of new features in master. Can we get a new tag so users don't have to use dev-master in their composer.json?

+1

Done: https://github.com/dunglas/DunglasAngularCsrfBundle/releases/tag/v1.0.0


Remove duplicated function in example

Super small PR: I noticed this function was duplicated while reviewing this example.

Thanks @dylanjcastillo!


Fix: trace nested route with original uri

As described in title. @sunli829 thanks for you hard work! ❤

I nested router /index on /api, now it's tracing as expected as shown below:
2022-08-18T09:44:04.158639Z  INFO request{remote_addr=socket://<IP_ADDRESS>:5647 version=HTTP/1.0 method=GET path=/v1/index}: poem::middleware::tracing_mw: response status=200 OK duration=33.8µs

Thanks!