Use same naming convention for all returned values (errors) in all places

I'm not sure if this is correct place, so please excuse me if I'm posting this issue in wrong place.
I've found this issue building WebAPI 2.2 application, not sure if this is an issue, but probably is.
Inside my custom OAuthAuthorizationServerProvider inside GrantCustomExtension I'm setting errors using:
context.SetError("invalid_grant", "Account locked.");

this is returned as below JSON:
{
  "error": "invalid_grant",
  "error_description": "Account locked."
}

as You can see error and error_details are returned with snake_case.
When I return BadRequest inside ApiController I get this response:
{
  "message": "The request is invalid.",
  "modelState": {
    "client.Email": [
      "Email is not valid."
    ],
    "client.Password": [
      "Password is required."
    ]
  }
}

as You can see there is property modelState.
I'd like to ask if it is possible to unify naming so that OAuthAuthorizationServerProvider would use formatter set in HttpConfig, so that we would be able to define naming rules globally.

Hi @Misiu , the difference in casing/style here is due to different requirements of the data. The MVC BadRequest data uses a style that is more similar/compatible to what JavaScript frameworks use, whereas the Security data doesn't have that requirement. It would also be a breaking change to switch the style.
As such, there are no plans to change this behavior.

@Eilon thanks for reply. I wasn't proposing changing the style by default, but allowing us (developers) to specify style and (if possible) name of properties.
In my case, I'd like returned value to have same property names (not error and message). I'd like to unify that, bus as I wrote that's just my personal preference, but framework should allow that.


test: Update ostree.sh to cover bz#1896178

Update details:

For RHEL 8.5, user and ssh key are added in blueprint.
For Fedora 33, RHEL 8.3 and 8.4, user and ssh key have to be added in ks file due to bz#1896178.

bz#1896178 has been fixed already on RHEL 8.5 only, but still exists on Fedora 33, RHEL 8.3 and 8.4. This PR covers RHEL 8.5, Fedora 33, RHEL 8.4 and RHEL 8.3.

All ostree tests are green. Failed cases are not related with code change in this PR.

Rebased @achilleas-k's PR that removes the broken tests on 8.5. Everything works now.


Sending Message or Attachment to group chat isn't working

WA-JS Version
3.15.1
WhatsApp Version
2.3000.1018445780
Browser Version
Chrome 131.0.6778.86
Operation System
Windows 11
Steps to reproduce
Run WPP.chat.sendTextMessage(chat.id.user, "Hi") with any group chat id
What is expected?
It should send message by running WPP.chat.sendTextMessage(chat.id.user, "Hi")
What is actually happening?
On running WPP.chat.sendTextMessage(chat.id.user, "Hi") Showing following error:-

Any additional comments?
Although it's working perfectly, if we are using serialized id chat.id._serialized

First parameter should be in format<EMAIL_ADDRESS>or<EMAIL_ADDRESS>for group or you can use _serialized property.
WPP.chat.sendTextMessage(chat.id._serialized, "Hi")

Yeah, using the _serialized ID is working properly.
However, in the codebase, I was previously using chat.id.user, and it worked fine at that time. Do I need to update the implementation to use _serialized IDs now?


add signature for hosts IPs

This adds hostname and IP relation, to save some time when looking at issues

/lgtm

/approve

/retest


Update tfidf.py

Updated class TfIdfIndex to handle hash collisions that were possible with the _hash32 function.
added self._id_to_i dictionary to hold a reverse pairing of key/values used in self._i_to_id.
updated _hash32 to check for the hash value in the dictionary keys before adding and updating the hash if necessary.
updated the index function to assign values to both dictionaries.
updated unindex to pull the value for i from the _id_to_i dictionary to ensure it is getting a record_id that exists.
I reforked and added these changes. Let me know if you have any questions.

Coverage decreased (-0.01%) to 81.77% when pulling 449ba469feff56ac0b1b395fcb160e3b23ff0522 on Fideln8:master into a7ccddddadd3511e1de032c71c3d9f92d88dffe4 on datamade:master.

Coverage decreased (-0.01%) to 81.77% when pulling 394ec2e2bc46bb61d5f150c35b5ff63bda8c1b84 on Fideln8:master into a7ccddddadd3511e1de032c71c3d9f92d88dffe4 on datamade:master.


Need adequate reaction when user program asks for HW offloading and network port doesn't have capabilities for it

Currently NFF-Go doesn't correctly handle a situation when user program asks for HW offloading and in initialization it happens that network card (port) doesn't support HW offloading (for TX checksums). It is necessary to either return an error, disable offloading and send this information to the calling program that it should call SW checksum calculation functions for the packets.

Fixed


colResize does not work with ColReorder 1.1 using DataTables 1.10

I am trying to use this plugin alongside colReorder for DataTables but they do not integrate properly. After columns are reordered, resizing the reordered or neighboring columns causes issues. Are you doing any testing in conjunction with colReorder so that both features can be used with a single table?
-- Update --
After some investigation, I found the issue and fixed it:
In the fnMouseDown function, the code is finding the column index using the "column-index" property of the resizeCol and resizeColNeighbour data objects. This property does not get updated when the columns are reordered using the ColReorder plugin, even after saving the state and redrawing the table. These properties contain the old index from before reorder. However, the cellIndex property of the resizeCol and resizeColNeighbour objects do get updated when the columns of the table are reordered.
Changing this code in "_fnMouseDown":
 //Store the indexes of the columns the mouse is down on
var idx = that.dom.resizeCol.data("column-index");
var idxNeighbour = that.dom.resizeColNeighbour.data("column-index");

to this:
var idx = that.dom.resizeCol[0].cellIndex;
var idxNeighbour = that.dom.resizeColNeighbour[0].cellIndex;

Fixes the problem.
It doesn't seem to have any detrimental effects on any other part of the plugin functionality, and it now co-operates with colReorder.
I have forked the repo and will make the changes and make a pull request after doing some more testing.

I just came across the same issue(happens after you resize a column, than reorder the column with another column, and then try to resize the neighbour columns..), and your changes seems to be working for me as well.

I'm glad the change worked for you. I'm still trying to find the time to thoroughly test the change and commit it to the repository. Please let me know if you come across any adverse effects from making the change.

Thank you for looking into this. All help is appreciated. Submit a pull request whenever you're ready and I will test and accept it.

From the tests I have done, It seems to be working for me, did you have a pull request for me or should I apply the patch myself?

I have just applied the patch, and am closing this issue, please re-open this ticket if you find it hasn't solved the problem adequately.

dykstrad - the "fix" only seems to work if you don't have any non-visible columns between two visible columns. if i systematically hide columns starting from the end of the list, everything works fine. but, as soon as you hide, say, column 2 (leaving column 1 and column 3 visible), the resizing does not work any more. please help. i'm in desperate need of this plugin to work with visible/non-visible columns and ColReorder.

Hi Scott,
I will look into this asap, and test it a little more thoroughly, thank you for bringing this up.
David

On Jun 9, 2015, at 11:04 AM, Scott Erwin<EMAIL_ADDRESS>wrote:
dykstrad - the "fix" only seems to work if you don't have any non-visible columns between two visible columns. if i systematically hide columns starting from the end of the list, everything works fine. but, as soon as you hide, say, column 2 (leaving column 1 and column 3 visible), the resizing does not work any more. please help. i'm in desperate need of this plugin to work with visible/non-visible columns and ColReorder.
—
Reply to this email directly or view it on GitHub https://github.com/Silvacom/colResize/issues/8#issuecomment-110434883.

Forgot to reopen this bug, as some things were missed in testing the fix.

Any updates on this? My business partners are really wanting this fixed for a product release we have in August.

Sorry I haven't had much time to develop this plugin as our company has moved on to other solutions with angular grid since we operate with Angular. I will continue to maintain pull requests, but I won't have much time to develop it myself.

@StephaniesHusband Could you check to see if the latest version fixed it for you? I accepted a pull request from @1Jesper1 but it may undo the changes that @kylealonius made. I wonder if we have a weird collision of solutions here.

@dykstrad Unfortunately we are loading to production this weekend and had to come up with our own solution.  We are not using the visibility flag of the column to hide/show--we are just removing removing/adding the columns, respectively, and that fixed our issue.  At this time, I don't have the codebase or time to set things back up like we had them.  If I get around to testing it, I will certainly update you. Thanks.

no problem.
On Thu, Aug 27, 2015 at 10:27 AM, Scott Erwin<EMAIL_ADDRESS>wrote:

@dykstrad https://github.com/dykstrad Unfortunately we are loading to
production this weekend and had to come up with our own solution. We are
not using the visibility flag of the column to hide/show--we are just
removing removing/adding the columns, respectively, and that fixed our
issue. At this time, I don't have the codebase or time to set things back
up like we had them. If I get around to testing it, I will certainly update
you. Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/Silvacom/colResize/issues/8#issuecomment-135484886.

I also found the combination of ColReorder with ColResize to be not working properly. My quick fix was to add the following in _fnStateLoad():
if (that.s.dt.oLoadedState.ColReorder) {
    col = that.s.dt.aoColumns[that.s.dt.oLoadedState.ColReorder[index]];
} else {
    col = that.s.dt.aoColumns[index];
}


investigate line_descriptor openCV contrib module

we may be able to replace some of our line segment detection & duplicate removal with something from here:
https://github.com/opencv/opencv_contrib/tree/master/modules/line_descriptor

similarly this looks like it determines all connected pixels, might be a replacement for what we do:
https://docs.opencv.org/3.4/d3/dc0/group__imgproc__shape.html#gaedef8c7340499ca391d459122e51bef5

resolved by #402


Allow use and testing with Jekyll 4.x

This adds Jekyll 4.0 support to 2.5-stable branch by backporting #351 (and some additional minor changes to .travis.yml).
@DirtyF, @mattr-  IMO, a minima-2.5.1 should be deployed a.s.a.p before shipping Jekyll 4.0 so that
using jekyll new with Jekyll 4.0 allows using Minima 2.5 by default.

https://github.com/jekyll/minima/releases/tag/v2.5.1


Fancy slicing with lists

OK, so we do a dual approach to achieve fancy indexing.
Given an index, like
(5, slice(5, 10, 2), [1, 2, 3])

We first do the normal dask_slice solution on the array with the slice replaced with an empty list
(5, slice(5, 10, 2), slice(None, None, None))

We then follow with the final list list.  I suspect that we could repeat these for multiple lists and achieve Matlab style orthogonal indexing.
It mostly works
Example
In [1]: from blaze import Data, compute, into

In [2]: import dask.array as da

In [3]: import numpy as np

In [4]: x = np.arange(100).reshape((10, 10))

In [5]: d = Data(into(da.Array, x, blockshape=(3, 3)))

In [6]: np.array(d[5:9, 1:9:2])  # could do this before
Out[6]:
array([[51, 53, 55, 57],
       [61, 63, 65, 67],
       [71, 73, 75, 77],
       [81, 83, 85, 87]])

In [7]: np.array(d[0:3, [1, 3, 8, 3]])  # Now can do this
Out[7]:
array([[ 1,  3,  8,  3],
       [11, 13, 18, 13],
       [21, 23, 28, 23]])

The actual dask looks like the following
In [8]: y = compute(d[0:3, [1, 3, 8, 3]])

In [14]: cull(y.dask, y.keys())
Out[14]:
{'x_1': array([[ 0,  1,  2,  3,  4,  5,  6,  7,  8,  9],
        [10, 11, 12, 13, 14, 15, 16, 17, 18, 19],
        [20, 21, 22, 23, 24, 25, 26, 27, 28, 29],
        [30, 31, 32, 33, 34, 35, 36, 37, 38, 39],
        [40, 41, 42, 43, 44, 45, 46, 47, 48, 49],
        [50, 51, 52, 53, 54, 55, 56, 57, 58, 59],
        [60, 61, 62, 63, 64, 65, 66, 67, 68, 69],
        [70, 71, 72, 73, 74, 75, 76, 77, 78, 79],
        [80, 81, 82, 83, 84, 85, 86, 87, 88, 89],
        [90, 91, 92, 93, 94, 95, 96, 97, 98, 99]]),
 ('slice-2', 0, 0): (<function operator.getitem>,
  ('x_1', 0, 0),
  (slice(0, 3, 1), slice(0, 3, 1))),
 ('slice-2', 0, 1): (<function operator.getitem>,
  ('x_1', 0, 1),
  (slice(0, 3, 1), slice(0, 3, 1))),
 ('slice-2', 0, 2): (<function operator.getitem>,
  ('x_1', 0, 2),
  (slice(0, 3, 1), slice(0, 3, 1))),
 ('x_1', 0, 0): (<function operator.getitem>,
  'x_1',
  (slice(0, 3, None), slice(0, 3, None))),
 ('x_1', 0, 1): (<function operator.getitem>,
  'x_1',
  (slice(0, 3, None), slice(3, 6, None))),
 ('x_1', 0, 2): (<function operator.getitem>,
  'x_1',
  (slice(0, 3, None), slice(6, 9, None))),
 ('x_4', 0, 0): (<function operator.getitem>,
  (<function numpy.core.multiarray.concatenate>,
   (list,
    [(<function operator.getitem>,
      ('slice-2', 0, 0),
      (slice(None, None, None), [1])),
     (<function operator.getitem>,
      ('slice-2', 0, 1),
      (slice(None, None, None), [0, 0])),
     (<function operator.getitem>,
      ('slice-2', 0, 2),
      (slice(None, None, None), [2]))]),
   1),
  (slice(None, None, None), (0, 1, 3, 1)))}

Some known problems

[ ] d[0] fails
[ ] Multiple lists fail (though I think that this is probably easy to fix in the Matlab style)
[ ] edge cases may fail

cc @nevermindewe @shoyer

Fixes https://github.com/ContinuumIO/dask/issues/22

Also @shoyer, this brings us to the point where dask.array can successfully perform the following
In [19]: np.array(d[[5, 3, 0]].sum(axis=0))
Out[19]: array([ 80,  83,  86,  89,  92,  95,  98, 101, 104])

Which, I think, is likely sufficient for your common use cases.

Handling 1D boolean arrays is also pretty easy -- you can just convert them into integer arrays with np.nonzero.

I've handled the edge cases (I think).  Merging.
This doesn't yet handle multi-list nor things like slicing with arrays.


Selecting favorite language(s) after signup

As we briefly discussed on #701, poking inactive users taking into account their language(s) preferences is a better attempt for having them onboard 😄.
We should ask the users to fill them after they signup so we can poke them effectively.

Hey @schneems!
I've been trying to move this forward. However, I couldn't find how we redirect the user to the after signup steps. Already tried (in my local env) signing up with Github, subscribing to a repo, updating my settings. The server is configured using the steps as written in the Readme.
Could it be that these steps are not being used at all? If not, could you point me into the right direction?
Thanks!

I think this is implemented.
Can we close it?


Replacecos

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] local build the book
[ ] review the artifacts from local build
[ ] local build the slides if appliable
[ ] Unit test if appliable

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have applied tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Please do not upload files that are not relevant to this mission, remove them!

What changes did you make? The file still seems to be local.

I'll create a new branch


Use contextID in HL7802 Cellular_SetPdnConfig

Use contextID instead fixed id in HL7802 Cellular_SetPdnConfig

Some basic unit tests for these device-specific functions would be helpful for catching this kind of issue earlier.


Scaffolder: Hidden fields are not completely hidden

Expected Behavior
Fields hidden with ui:widget: hidden should be invisible.
Current Behavior
Hidden fields are hidden, but the wrapping grid is still displayed with its padding and margin taking up space.

Possible Solution
One solution is to hide the grid item if ui:widget: hidden is used. Afaik to there is no way in CSS to select the parent of an element to hide it, so we actually can't create a workaround and have to fix the issue.
I guess this is actually a problem in the upstream @rjsf/material-ui package.

Steps to Reproduce
Include a ui:widget: hidden in you template, the problem is even more visible if you add more than one.
properties:
  mode:
    type: string
    enum:
    - create_repo
    ui:widget: hidden

Context

Your Environment

NodeJS Version (v12): 12
Operating System and Version (e.g. Ubuntu 14.04): Mac OS
Browser Information: Chrome

This seems to be a known issue upstream https://github.com/rjsf-team/react-jsonschema-form/issues/1974

I created a PR upstream https://github.com/rjsf-team/react-jsonschema-form/pull/2405

Good news, my upstream PR is merged. I'm just not sure when it will arrive in a release.


Add proxy variables to oc-env

When a proxy is configured in crc, we should add http_proxy/https_proxy/no_proxy to the variables to set in oc-env
This pull request achieves that, though it starts by misc improvements to network.Proxy which are not strictly required for that change.

retest this please.

retest this please.


[hotfix] Update types for StoryblokStory

Issue
When using useStoryblokState, the hook expects story to have types of ISbStoryData which definition you can find in storyblok-js-client package in storyblok-js-client/dist/types/interfaces.d.ts. And StoryblokStory deviates in only 2 properties: parent_id and paths.
Quick Solution
We do what I did in this PR.
Better (?) Solution
We install storyblok-js-client and extends ISbStoryData interface. 🤷

@snikidev thanks for your hotfix - I rather don't grab external types - if the changes are this rare I rather keep the dependency tree as small as possible


This emoji needs to be fixed.

The man in manual wheelchair needs to be fixed, as well as the other skin tones. Because that is a woman, not a man. It's supposed to be a man, not a woman.

Fixed in 461809616e5aff0e1bf32aacd9552168b8a52d3f

Okay. Which version of the font did you fix it. Also did you publicly release it yet?

Okay. Which version of the font did you fix it. Also did you publicly release it yet?

The one on the emoji-13-1-branch

Emoji loudly


CNV-28334: Adding ability to user settings column managment - part 2

📝 Description
Part 2:
Connection all table that used useActiveColumn to our new KubevirtColumns hook, that will keep the user settings about columns management persistent.
🎥 Demo

Please add a video or an image of the behavior/changes

/lgtm


Changes to prefix projectNames with test_file_name and line number

What type of PR is this?
/kind bug
What does does this PR do / why we need it:
To assist in resolution of  we are prefixing projectNames with the test filename and line number of the test in progress, this way we can identify which tests are leaving projects behind (not getting cleaned up)
Which issue(s) this PR fixes:
Fixes #4215
PR acceptance criteria:

[x] Unit test

[ ] Integration test

[ ] Documentation

[x] I have read the test guidelines

How to test changes / Special notes to the reviewer:
make test-integration
during execution check that projects created in the target cluster are prefixed with the test filename and line number

@rnapoles-rh I think you need to shrink project name character as while creating route during odo push it exceeds 63 characters and hence failure.
✓  Waiting for component to start [32ms]
[odo] I0315 21:08:22.841776   46681 kclient.go:202] Checking if "routes" resource supported
[odo] I0315 21:08:22.856108   46681 events.go:36] Quitting collect events
[odo]
[odo] Applying URL changes
[odo] I0315 21:08:22.881108   46681 kubernetes.go:25] Listing ingresses with label selector: app.kubernetes.io/instance=nodejs-cmp-cmd-devfile-debug-test-lnum-112-zgkentwybm
[odo] I0315 21:08:22.910075   46681 routes.go:61] Listing routes with label selector: app.kubernetes.io/instance=nodejs-cmp-cmd-devfile-debug-test-lnum-112-zgkentwybm
[odo]  ✗  Failed To Update Config To Component Deployed.
[odo] Error: unable to create route: error creating route: Route.route.openshift.io "3000-tcp-nodejs-cmp-cmd-devfile-debug-test-lnum-112-zgkentwybm" is invalid: spec.host: Invalid value: "3000-tcp-nodejs-cmp-cmd-devfile-debug-test-lnum-112-zgkentwybm-cmd-devfile-debug-test-lnum-112-zgkentwybm.apps.ci-op-jt9lwmrf-ba78b.origin-ci-int-aws.dev.rhcloud.com": host must conform to DNS 1123 naming conventions: [**spec.host: Invalid value: "3000-tcp-nodejs-cmp-cmd-devfile-debug-test-lnum-112-zgkentwybm-cmd-devfile-debug-test-lnum-112-zgkentwybm": must be no more than 63 characters**]

Also there are some formatting error in helper file.
./scripts/check-gofmt.sh
gofmt ERROR - These files are not formated by gofmt:
./tests/helper/helper_kubectl.go
./tests/helper/helper_oc.go
make[1]: *** [gofmt] Error 1
make[1]: Leaving directory `/go/src/github.com/openshift/odo'
make: *** [openshiftci-presubmit-unittests] Error 2

Reducing project name is not helping it out. I can see the same failure during odo push
[odo]  ✗  Failed To Update Config To Component Deployed.
[odo] Error: unable to create route: error creating route:
Route.route.openshift.io "3000-tcp-nodejs-cmp-cmd-devfile-debug-test112lkv" is invalid:
spec.host: Invalid value: "3000-tcp-nodejs-cmp-cmd-devfile-debug-test112lkv-cmd-devfile-debug-test112lkv.apps.ci-op-cpk93277-ba78b.origin-ci-int-aws.dev.rhcloud.com":
host must conform to DNS 1123 naming conventions:
[spec.host: Invalid value: "3000-tcp-nodejs-cmp-cmd-devfile-debug-test112lkv-cmd-devfile-debug-test112lkv":
must be no more than 63 characters]
Deleting project: cmd-devfile-debug-te

Reducing project name is not helping it out. I can see the same failure during odo push
[odo]  ✗  Failed To Update Config To Component Deployed.
[odo] Error: unable to create route: error creating route:
Route.route.openshift.io "3000-tcp-nodejs-cmp-cmd-devfile-debug-test112lkv" is invalid:
spec.host: Invalid value: "3000-tcp-nodejs-cmp-cmd-devfile-debug-test112lkv-cmd-devfile-debug-test112lkv.apps.ci-op-cpk93277-ba78b.origin-ci-int-aws.dev.rhcloud.com":
host must conform to DNS 1123 naming conventions:
[spec.host: Invalid value: "3000-tcp-nodejs-cmp-cmd-devfile-debug-test112lkv-cmd-devfile-debug-test112lkv":
must be no more than 63 characters]
Deleting project: cmd-devfile-debug-te

I think the problem is something else.
> [spec.host: Invalid value: "3000-tcp-nodejs-cmp-cmd-devfile-debug-test112lkv-cmd-devfile-debug-test112lkv":
I see projectName is appended twice to the value, maybe we need to look into that.
It LGTM otherwise @rnapoles-rh

@prietyc123 @valaparthvi thanks, I will rerun that test to check out why it is using the project name twice

I found that odo_utils.go also sets projectName so I made the call to the new function in generic_helper.
Also resolving the must be no more than 63 characters, as pointed by @valaparthvi the new projectName was not the problem, the problem is that the component name was using the projectName twice and therefore the json filename got too long.

/lgtm

/test unit

psi test are optional at this time


Error running tmkms yubihsm keys import

It looks like it is trying to import a 64-byte Ed25519 keypair, rather than just a 32-byte seed (i.e. the first 32-bytes of the keypair), which a YubiHSM rejects:
[tmkms@kms01 ~]$ tmkms yubihsm keys import --path priv_validator.json 1
error: couldn't import key #1: protocol error: invalid key length for Ed25519: 64 (expected 32)

This should be pretty easy to fix by adding a [..32] to slice off the seed part of the key.

This should be pretty easy to fix by adding a [..32] to slice off the seed part of the key.

In #113 I used Seed::from_keypair in combination with seed.as_secret_slice() instead. Under the hood it does exactly the same (and additionally some sanity checks on the passed 64-byte key-pair).
Thanks for testing this!


TrainTutorial Error

Hi, found a error if I want to make a train tutorial I get the following message:

Huh, I didn't think to test the mini-tutorial. I'll take a look and see what's up.

Fixed in r126 -- thanks for the report!


Kernel:  add config fragment support

original pull request https://github.com/kata-containers/packaging/pull/314

/test

/test

/AzurePipelines run

/test

/test

/AzurePipelines run

@egernst @grahamwhaley @ganeshmaharaj CI is happy, can we merge this?

@devimc

any progress/update on SRIOV support?
@egernst - would we be happy merging without SRIOV - that would then become the default kernel config for Kata x86 releases...
obs packaging CI looks to have failed

/AzurePipelines run

/AzurePipelines run

/test

/AzurePipelines run

/test

All green - merged :) , kudos @devimc


if cange '$config['language']', display error using form-validation/pagination of library

change application/config/config.php
$config['language']	= 'japanese';

2.use form-validation/pagination of library
3.display error
Unable to load the requested language file: language/japanese/form_validation_lang.php
Unable to load the requested language file: language/japanese/pagination_lang.php
now, if other language i use, can't use form-validation/pagination of library.

Sorry, I don't understand what you're saying here ...
Did you mean that you have the translation files under application/language/japanese/ and CI can't load them or are you complaining that we don't have Japanese translations? Or is it something else?

@rdlabo you should copy language files from /system/language/english/ to application/language/japanese/
@narfbg I think if there is no form_validation_lang.php inside japanese (or any other language) the default one (from system folder) should be used. It's just my idea.

@dontforget @rdlabo  https://github.com/bcit-ci/codeigniter3-translations provides a translation of the language folder for Japanese. Its "japanese" folder would get copied to application/language.
@dontforget  Your other suggestion might be worthy. This could be done by having something like $this->load($value, 'english', $return,TRUE,''); as the first executable line inside the load method.
@narfbg Does this make sense?

It has been suggested before and it doesn't make any sense to me - it's a no-brainer to add the necessary lang files during the development process. I don't see a reason why defaulting to another language is appropriate.

This doesn't make much more sense now than it did when raise. It sounds more like a support issue than a bug!


Unhandled exception when is used with input type="email"

Uncaught InvalidStateError:
Failed to read the 'selectionStart' property from 'HTMLInputElement': The input element's type ('email') does not support selection.
ng-pattern-restrict.js:149
getCaretPositionng-pattern-restrict.js:133
updateCurrentValueng-pattern-restrict.js:111
genericEventHandlerjquery.js:4430
jQuery.event.dispatchjquery.js:4116

@sebaplaza Thanks! Did you find this in any particular browser? (I think I can start working on it anyway.)

Note: this may be related with #12. There's a pending branch there on which I need to perform some further testing.


Set aside pods that fail to pack to avoid continually retrying and failing to pack them.

Logs can get really noisy with Failed to compute packing for pod(s) ..., let's set pods aside if they fail to pack for some TTL.

This issue should be solved in v0.3 with our switch to watch events to trigger controller actions as detailed in this design.
Karpenter would watch events requiring pod scheduling and bin packing decisions, and then trigger the allocation controller to do some work. If there are pods that are unable to fit into a bin packing solution, we will execute the bin packing solution for the pods that fit, then exponentially backoff and retry for the pods that did not fit.


Issue: conversion adds watermark at bottom of converted text

When converting a gdoc to HTML GD2MD now adds a short "watermark" to the end of the code. If not deleted this breaks stylesheets. There does not appear to be an option to not include it, current workaround is to manually delete before use.
Ideally it would be great to remove this "feature" entirely, but if not a check box to turn it off would be appreciated.

indeed it's pretty annoying

Removed.


Add API for creating a Testcontainer with auto^termination

Proposal
It would be nice to encapsulate the following code to simplify the tests.
	// Create Container
	ctx := context.Background()
	container, err := RunContainer(ctx,
		WithMappingFile("hello", "hello-world.json"),
	)
	if err != nil {
		t.Fatal(err)
	}

	// Clean up the container after the test is complete
	t.Cleanup(func() {
		if err := container.Terminate(ctx); err != nil {
			t.Fatalf("failed to terminate container: %s", err)
		}
	})

Scope

[ ] Add a new API method
[ ] Update unit tests to use the new method
[ ] Update the documentation, especially QuickStart and examples

References

https://golang.testcontainers.org/features/garbage_collector/

Hi @oleg-nenashev I'm currently learning Go and would like to work on this issue can you assign me this issue and tell me about the project structure?

@Vayras sure, please feel free to go ahead! The project structure is really simple: just one file and the test file for it in the repository root. The rest are the documentation and the examples that can be updated as we go

@oleg-nenashev Thank you for letting me know , working on this issue now

I have created a pull request for this issue


SiteSafetyServicesEnabled

The display title for this policy, "Allow users to configure Site Safety services." is poorly worded.
If you 'Enable' this policy, the feature is enabled in Edge and is locked.

The only point at which this 'Allows' users to configure anything is if the policy is 'Not Configured".
The title should be something like just 'Allow Site safety services".

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 198c6f64-9e5c-f18e-8439-8d0d11d4228d
Version Independent ID: 83f32be1-063c-284c-dfdc-6b5976a5b7cc
Content: Microsoft Edge Browser Policy Documentation
Content Source: edgeenterprise/microsoft-edge-policies.md
Product: microsoft-edge
GitHub Login: @dan-wesley
Microsoft Alias: stmoody

@kyleross-deckers Are you configuring the policy as mandatory or recommended?  If it is set to recommended, I believe that will allow users to change the setting.

Information about mandatory/recommended here: https://learn.microsoft.com/en-us/deployedge/configure-microsoft-edge#introduction-to-policy-settings-on-windows

Closing issue as there has not been any recent replies.
If you are continuing to have issues, you can reach out to Support (https://developer.microsoft.com/en-us/microsoft-edge/support/) for further assistance. Thanks!


[MM-49700] Validate new imports in the AWAT

Depends on

[x] https://github.com/mattermost/mmctl/pull/632
[x] https://github.com/mattermost/mmetl/pull/29

Summary
Validate AWAT translations before uploading or applying them to installations.
Changes made:

Added a Type field to uploads to know the kind archive type the upload is.

If we're uploading a Mattermost backup, the archive get's validated before uploading.

Added an UploadID field to translations to link an upload with a translation.

When a translation is started, if it comes from a known upload (non-null UploadID) and it's a mattermost type archive we consider the archive as already valid. If not, we download the archive from S3 and validate it before starting the process (creating the translation row).

Create an upload row for translations that use an archive already uploaded, that way we already know the file is validated (if it's a Mattermost archive)
Slack translator now validates the conversion before sending the import job
Modified some CLI calls to show the API output (body) on errors.

Importing a ~20GB archive
$ ls -lah | grep  data
-rwxr-xr-x  1 fmartingr  93G Jan 27 10:17 data.jsonl
-rw-r--r--  1 fmartingr  19G Jan 27 11:43 data.zip

$ gtime --verbose mmctl import validate data.zip
The .jsonl file has 197994768 lines
[... validation errors ...]
Progress: 197994768/197994768 (100.00%)
Schemes         0
Teams           100
Channels        20000
Users           987
Emojis          0
Posts           197973666
Direct Channels 0
Direct Posts    0
Attachments     0
It took 29m45.074952375s to validate 197994768 lines in data.zip
Validation complete
        Command being timed: "mmctl import validate data.zip"
        User time (seconds): 1707.62
        System time (seconds): 47.78
        Percent of CPU this job got: 98%
        Elapsed (wall clock) time (h:mm:ss or m:ss): 29:46.45
        Average shared text size (kbytes): 0
        Average unshared data size (kbytes): 0
        Average stack size (kbytes): 0
        Average total size (kbytes): 0
        Maximum resident set size (kbytes): 61888
        Average resident set size (kbytes): 0
        Major (requiring I/O) page faults: 655
        Minor (reclaiming a frame) page faults: 6422
        Voluntary context switches: 115703
        Involuntary context switches: 2441631
        Swaps: 0
        File system inputs: 0
        File system outputs: 0
        Socket messages sent: 22
        Socket messages received: 26
        Signals delivered: 383695
        Page size (bytes): 16384
        Exit status: 0

Ticket Link
https://mattermost.atlassian.net/browse/MM-49700
Release Note
Validate Mattermost archive uploads before importing them

Failing E2E test make e2e-mattermost with following error
error storing upload in database              error="pq: duplicate key value violates unique constraint \"upload_pkey\"" path=/translate

Cloud you please verify the test accordingly.

Failing E2E test make e2e-mattermost with following error
Cloud you please verify the test accordingly.

I fixed the missing field for the tests but E2E is not passing for me on main. I will check what's going on next week.


Add package benchmarks

closes #8

Codecov Report

Merging #15 (9f50e88) into master (cea4d43) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   89.87%   89.87%
=======================================
  Files           8        8
  Lines         158      158
=======================================
  Hits          142      142
  Misses         16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea4d43...9f50e88. Read the comment docs.


renamed 'traci'->'sumo' for simulator

Pull request information

Status: ready to merge
Kind of changes: cleanup
Related PR or issue: None

Description
This choice of words was discussed at a meeting before and should reduce confusion

Pull Request Test Coverage Report for Build 4391

33 of 42 (78.57%)  changed or added relevant lines in 16 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.964%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

flow/multiagent_envs/multiagent_env.py
1
2
50.0%

flow/envs/bay_bridge/base.py
1
5
20.0%

flow/envs/bottleneck_env.py
3
7
42.86%

Totals

Change from base Build 4369:
0.0%

Covered Lines:
9178

Relevant Lines:
9980

💛  - Coveralls


Attachments and Previews are not working

bug _t
priority _t
https://sandip-mane.neetorecord.com/watch/80e750e0-715b-473a-98f1-de5be322db95

Attachments have invalid URLs
Previews should be supported for:

[ ] Excel
[ ] Docs
[ ] PDF
[ ] Images

@gaagul _a

Let us solve the issues with subdomain as the first part of this issue and take up changes related to adding previews for Excel and Docs in https://github.com/bigbinary/neeto-editor/issues/991.

I believe the host app is responsible for the subdomain part, In neetoKb i was able to find : https://github.com/bigbinary/neeto-kb-web/blob/70d1dfe251a1e6fbb36d54035233be96d645fdd4/app/views/api/v1/admin/articles/_attachment.json.jbuilder#L4
@AbhayVAshokan , @sandip-mane , Please let me know you thoughts on this.

However, should we standardize it so that this does not happen in future?

I couldn't locate any specific initializers for Active Storage. If there's an alternative method it would be great.

We can move the AttachmentCarrier to neetoCommons and then use that from all the apps.
Before that, we need to see how other neeto apps are using it.

Removing the priority label since the issue with urls are fixed and research is needed for adding previews to:

Excel
Docs
PDF
Images

@gaagul we can close this issue. We have another one for adding these features. Ref: https://github.com/bigbinary/neeto-editor/issues/991

Closing the issue.


Saving projects liked and  rated by user

Describe  feature .

saving projects liked by user and projects rated by user in user profile locally and in database
this can be used to show user whether he/she liked/rated a particular project before or not
also solving issue will help to give user some badges based on no. of liked / rated projects
so I want to work on this issue first before solving issue #230

@rockingrohit9639 @satyampgt4 I'd like to work on this issue

Okay :)


Pronunciation auto-tests failing

Also X-Goog-BatchExecute-Bgr related like https://github.com/AidanWelch/google-translate-api/issues/18


Wass contribution

HI @codeurzebs ! I've created .js file and write hello world.

Thank you @codeurzebs


ci add required checks

PR #35910 uses a new way to set required checks, but It does not work. Here use the old way to set.
Proposed changes
Issue Number: close #xxx

run buildall


Running worker locally

Can I use https://github.com/cloudflare/miniflare to run worker in an electron app locally, will it still work?

I think it would work, you can find the worker script here.


Move curator backend code to a dedicated dir, in preparation for creating a separate /ui/ dir.

Two decisions up for discussion, here:

Moving this to a new sub-dir of curator-service/, in lieu of leaving it and making a new verification/curator-ui/ dir.
Naming the sub-dirs api/ and ui/.

Chose to do (1) because the backend and UI logically constitute what we've been referring to as the "curator-service." Chose (2) because naming is hard and I wasn't feeling creative (I'd also considered backend and server -- no real preference).
Intentionally not renaming the docker service; if we decide to create a separate image/app for the frontend, we can name it curator-ui.

Would any of the config type files be worth keeping out of the api dir? I'm thinking: eslint, prettierrc, jest.config, tslint, etc. I thought those were doing linting, style fixes, etc that would be useful to have on the UI side, but maybe I'm wrong on what those do :)

This is a great idea -- though I'd have to do a bit of research on how to share these. I think there's some level of assumption that these are in the base Node app dir. Let's revisit as we're setting up the ui dir/app.


Fedora works!

With the updated conf-openblas recently merged to the opam-repository, Fedora can now be used with owl seamlessly. This PR properly re-enables Fedora tests.
Signed-off-by: Marcello Seri<EMAIL_ADDRESS>

LOL it had just succeeded on my branch and now complaints about -llapacke??

I'll reopen once I figure out why it has happened

I had forgotten the additional cflags commit :P

Yay! Merged.


az functionapp raises CryptographyDeprecationWarning due to outdated version of paramiko

Describe the bug
az uses outdated paramiko 3.4.0. Should use 3.4.1 or newer to avoid "CryptographyDeprecationWarning"
Related command
$ az functionapp list > /dev/null
Errors
/opt/az/lib/python3.12/site-packages/paramiko/pkey.py:100: CryptographyDeprecationWarning: TripleDES has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.TripleDES and will be removed from this module in 48.0.0.
"cipher": algorithms.TripleDES,
/opt/az/lib/python3.12/site-packages/paramiko/transport.py:259: CryptographyDeprecationWarning: TripleDES has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.TripleDES and will be removed from this module in 48.0.0.
"class": algorithms.TripleDES,
Issue script & Debug output
There is too much private data in the debug statement to post here.
Expected behavior
No "CryptographyDeprecationWarning"
Environment Summary
azure-cli                         2.66.0
core                              2.66.0
telemetry                          1.1.0
Dependencies:
msal                              1.31.0
azure-mgmt-resource               23.1.1
Python location '/opt/az/bin/python3'
Extensions directory '/home/supermads/.azure/cliextensions'
Python (Linux) 3.12.7 (main, Oct 30 2024, 03:55:58) [GCC 9.4.0]
Legal docs and information: aka.ms/AzureCliLegal
Your CLI is up-to-date.
Additional context
You can fix the issue locally by running sudo /opt/az/bin/python3 -m pip install --upgrade paramiko which is probably not a good idea.

Thank you for opening this issue, we will look into it.

Duplicate of https://github.com/Azure/azure-cli/issues/30147


chore(v2): use joi for  config validation

Motivation
More robust validation for config. Validating more fields and types. It fixes  #2978.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
I have added tests for validation and update old ones

pr failed due to weird "no internet connection".


⚠ ClamAV has degraded performance

In cad5dbc, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 201 ms

Resolved: ClamAV performance has improved in ebccd94.


Length Inaccurate on Multi-Channel Audio Files

🐛 Bug
When doing torchaudio.info() on a multi channel audio file, the length is multiplied by however many channels there are.
To Reproduce
Steps to reproduce the behavior:

torchaudio.load(dual_channel_path) Look at the shape
torchaudio.info(dual_channel_path) Look at the length
It will be length of a single channel * # of channels

Expected behavior
I would expect the length to be the length of one channel, not the length of all of them put together.
Environment

What commands did you used to install torchaudio (conda/pip/build from source)? Pip
If you are building from source, which commit is it?
What does torchaudio.__version__ print? (If applicable) 0.3.0

Please copy and paste the output from our
environment collection script
(or fill out the checklist below manually).
You can get the script and run it with:
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py

PyTorch Version (e.g., 1.0):
OS (e.g., Linux):
How you installed PyTorch (conda, pip, source):
Build command you used (if compiling from source):
Python version:
CUDA/cuDNN version:
GPU models and configuration:
Any other relevant information:

Additional context
I think the best way to fix this issue is just to take length and divide it by # of channels.

Left a comment on the PR 😄
https://github.com/pytorch/audio/pull/237#issuecomment-521653116

This has been resolved via #726.


Optimising build time

With the introduction of plv8, build times for new images have gone up to unfavourable timings. Biggest factor thus far is RAM allocated to the image upon building.
Digital Ocean

Increasing RAM at build time is not ideal as Digital Ocean plans are tagged to both RAM and disk space.
Going for a plan with high RAM equates to higher disk space as well.
We would be unable to scale down the image afterwards

Possible Solutions

[ ] Build locally then deploy. (Perhaps with something like Vagrant)
[ ] Build on top of an existing image with v8 already installed.
[ ] Build on top of previous version.

AWS

It is possible to increase RAM during build time and scale it accordingly in both directions for instances that would be produced from the resultant AMI.

Docker

Not that of a worry as building it is done locally first then eventually deployed on to Docker Hub.

tl;dr - We build on top of an existing version of Supabase Postgres (We take the one from the marketplace) instead of from scratch and use Ansible tags to run specific tasks instead of everything. A guide on how to build on top can be found here.

Will close this issue once I create the same configuration for AWS (now that we have Supabase Marketplace available in their marketplace).


[spinel] first draft of I-D.rquattle-spinel-basis

This has loads of editor's notes that need to be cleared before we can submit to the draft queue.

Please rebase to resolve conflicts.

How does this look, @jwhui ?

I assume this addresses #1472?

Yes. This is to address #1472.

The fact that this change duplicates lots of files makes it difficult to see if there were any significant changes, so I'll just ask: Did you make any significant changes to the files when you made the basis copies?

And why copy? Why not just leave them (or just rename them) and remove their references from the  "unified" document?
I'm concerned because now it isn't clear which file is authoritative. Should people making changes update both files now? That seems really easy to mess up.

p1. I made a lot of editorial changes, but the technical changes to the existing hierarchy of files was limited to removing the number reservations for things that seemed specific to Thread by my reading of the text. I'm in the middle of composing the files that will contain the definitions of those numbers in the unified draft that are missing from the basis.
p2. I copied the files rather than edit them in place out of a concern for keeping the unified draft from being changed by my introduction of the basis draft. I was planning to track any new changes to the unified draft as other contributors make them until the day arrives when we feel comfortable that the basis and the Thread specialization are a suitable replacement for it.
p3. I can see how that might lead to confusion with other contributors, so an alternative to consider is that perhaps I should push this change now into the separate spinel-documentation repository, and track the changes to the unified draft in the current openthread repository until it can be deleted from the openthread source tree. Let's talk about that.

@darconeous @jhwoodyatt, is there a plan to move this forward?

Now that I've got stuff I have been working on landed, this is my top next priority.

Reviewing now.

I'm going to go ahead and prepare this in a separate repository. Will update when I've got that all set up.

See latest changes to https://github.com/openthread/spinel-spec

Is something like encryption of the uart/spi traffic in the scope of this issue? I would love to see some proposals/comments about protecting spinel traffic from eavesdropping and/or other hacking behavior.

@Nopik: That is is out of this document's scope, but we could write up another document defining a security layer for Spinel.

Closing. See https://github.com/openthread/spinel-spec


Dangerous scope, does not support table prefixes

First of all, thank you for your awesome contributions.
My concern is that running this inside shared Homestead drops tables that belong to other projects.
There should be implementation of some safeguards that let's the developer know what tables are about to be dropped and a possibility to bail out before any destructive actions take place.
You are welcome to check out how I implemented it in our similar command. It's still in development and takes a bit different approach (and hasn't been tested yet).

Thanks for your suggestion.
I'd like to cater to the proverbial 80% that use a seperate db for each application. I'd accept a PR that makes the current behaviour more clear in the readme.


Memory Game

Is your feature request related to a problem? Please describe.
The problem is to create a Grid-based Memory Game using HTML, CSS, and JavaScript.
Game Features:

It has a 4 * 4 grid and clicking two tiles with the same images gives a score, else it hides again.
The game has a scoring formula so that after each move, the LIVE SCORE of the player will be displayed.
It also has music for correct, wrong match and also for game end.

@Ayush7614 Can I work on this as a part of HCSSoC'21


oras-py doesn't work with unauthenticated pull

Works
oras pull ghcr.io/ngcloudsec/vdb:v1 -o /tmp/vdb

Performing the same action via the python library results in an authentication error with get_manifest.
oras-py pull ghcr.io/ngcloudsec/vdb:v1 --output /tmp/vdb1
This endpoint requires a token. Please set oras.provider.Registry.set_basic_auth(username, password) first or use oras-py login to do the same.
authentication required
Issue with https://ghcr.io/v2/ngcloudsec/vdb/manifests/v1:
Unauthorized

I am running the command to reproduce your error - and trying with and without my token for GitHub packages in my $HOME/.docker/config.json meaning I just have an "auths" section with ghcr.io
{
	"auths": {
		"ghcr.io": {
			"auth": "xxxxxxxxx........xxxxxxxxxxxxxxxx"
		},

By default with my config in place, it looks like it's working for me:
$ ls /tmp/vdb1/
data.index.vdb  data.vdb

And the full command:
$ oras-py pull ghcr.io/ngcloudsec/vdb:v1 --output /tmp/vdb1
Successfully pulled /tmp/vdb1/data.vdb.
Successfully pulled /tmp/vdb1/data.index.vdb.

I think GitHub packages has had an issue in the past where if you are authenticated, it actually doesn't work when it doesn't need auth (I had this error just using a standard pull).
When I rename the config, I reproduce the same error as you:
$ oras-py pull ghcr.io/ngcloudsec/vdb:v1 --output /tmp/vdb1
This endpoint requires a token. Please set oras.provider.Registry.set_basic_auth(username, password) first or use oras-py login to do the same.
authentication required
Issue with https://ghcr.io/v2/ngcloudsec/vdb/manifests/v1:
Unauthorized

Let me a take a look at how oras in Go does it. The message that we are getting above is correct - the server is upset that we aren't providing something and telling us we are unathorized. I'm just not sure how it works without providing something.

Thanks, @vsoch, for looking into this. Another problem I faced is the use of logger.exit which kills the process, so I'm unable to use this as a library. Any chance you could replace all use of such exit with errors and warnings?

Sure could you please open a separate issue for that?

Okay pinged oras-go devs to get their feedback here - let's hope we hear back soon! As soon as we talk about the strategy they use I'm happy to implement it here.

@prabhu here is a first PR to test adding exceptions - give that a whirl and let me know what you think! https://github.com/oras-project/oras-py/pull/57 We will need to wait for the oras-go maintainers to chime in for this issue.
And don't worry about opening an issue - I just did the PR straight away so we wouldn't need to remember :P The luxury of the Thanksgiving holiday is that you can do that! :laughing:

Thank you so much! Will give this a try!

Hey @prabhu! We found the bug I think - oras-go will generate essentially an empty token for the registry when this happens: https://github.com/oras-project/oras-go/blob/f09c8577c526c2e13172d6321b2bbb57cd7152e6/registry/remote/auth/client.go#L292-L336 and we don't do that here. I will try to make time to work on this soon, likely in the evening after work.

hey @prabhu ! Thank you for your patience! The pull request at https://github.com/oras-project/oras-py/pull/57 now addresses both issues:

we replace system exits with raising exceptions you can catch
the un-authenticated pull should now work given that the registry supports giving out anonymous tokens.

Take it for a test run and let me know if it solves the issues for you.

What issues exactly? you should create a new environment, pull the branch directly, and install to it.

cd /tmp
git clone -b dont-sys-exit https://github.com/oras-project/oras-py
cd oras-py
python -m venv env
source env/bin/activate
pip install -e .

which oras-py

@vsoch Thank you. It is working, but the download is significantly slow. Will try later over the weekend.

okay gotcha! For the test case here, it was slow for me too. I'm not sure there is any way around that.

On the first test, the python version took 14min 20sec whereas go took 11min 7sec. I will repeat it several times, but this particular issue can be closed. Thank you for the quick fix!

Sure thing!
And I'm not surprised about the time difference - we can definitely discuss how to improve upon it, if that's possible.


Add Quiltctl

This series divides Quilt into a daemon and a client. The daemon is responsible for enforcing Stitches. The client sends Stitches to the daemon to be enforced. It is also capable of querying the state of the daemon, getting imports, etc.

YAY! This is going to be a huge usability win.

Closing until coverage increased


Logic_for_fetching_more_than_50k_results_without_code_review

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist
Please check if your PR fulfills the following requirements:

[ ] Testing of all the changes has been performed (for bug fixes / features)
[ ] The readme.html has been reviewed and added / updated if needed (for bug fixes / features)
[ ] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[ ] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[ ] Verify all checks are passing.
[ ] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[ ] Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type
Please check the type of change your PR introduces:

[ ] New App
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Release Notes (REQUIRED)

Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

This code will be useful in the future if we will get feature enhancement for paginator in Splunk App. The code is written under the below ticket:
https://splunk.atlassian.net/browse/PAPP-24353


Missing references!

From @dosumis on March 10, 2018 13:24
Reference section misses references.  Just has a link to FlyBase
e.g.

Should have:

Copied from original issue: VirtualFlyBrain/geppetto-vfb#142

@dosumis This is a general issue as references seem to not be added as before in the new pipeline

It's expecting the FB pub node to have a 'miniref'

Only 1 node in the KB has this anymore?
MATCH (n:pub) where exists(n.miniref) RETURN n LIMIT 25
{
  "iri": "https://doi.org/10.1101/198648",
  "miniref": "Tirian & Dickson 2017",
  "DOI": "10.1101/198648"
}

Spotted the issue in the pipeline:
python3 /opt/VFB/VFB_neo4j/src/uk/ac/ebi/vfb/neo4j/flybase2neo/import_pub_data.py http://<IP_ADDRESS>:7474 neo4j vfb
Traceback (most recent call last):
  File "/opt/VFB/VFB_neo4j/src/uk/ac/ebi/vfb/neo4j/flybase2neo/import_pub_data.py", line 2, in <module>
    from uk.ac.ebi.vfb.neo4j.flybase2neo.dbtools import dict_cursor, get_fb_conn
  File "/opt/VFB/VFB_neo4j/src/uk/ac/ebi/vfb/neo4j/flybase2neo/dbtools.py", line 25
    sgml_string = re.sub('<\\\up>', ']', sgml_string)
                        ^
SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes in position 3-4: truncated \uXXXX escape

From @dosumis on March 10, 2018 14:56
Moving to Review/QA pending testing on site.

From @dosumis on March 10, 2018 14:55
Well spotted. Fixed (actually fixed last week in a branch but git screw up meant old version of file was hanging around after rename).   https://github.com/VirtualFlyBrain/VFB_neo4j/commit/8e6d023a3eda9822d1ded446c3d55d5f30b21f30

References
FlyBase (FBbt:00110930)
Aso et al., 2014
Strausfeld et al., 2003
Tanaka et al., 2004


Initial work on marker selection

Just some suggestions for comments and/or formatting that might make it clearer for whoever implements this for force vector selection (tentatively Will). Feel free to disregard any changes, this is just what I moved into my dummy repo to help me understand what you added. (Note: I'm using the variable name markerMeshes in place of pointsRep in my dummy repo)
const handleRaycast = useCallback(({
    clientX, clientY, ctrlKey, shiftKey, currentTarget: {offsetLeft, offsetTop, offsetWidth, offsetHeight}
}: React.MouseEvent<HTMLDivElement,MouseEvent>) => {
    /* Raycaster requires coordinates to be transformed to range [-1,1], with positive y toward top of page (inverted from CSS) */
    const percentRight = (clientX-offsetLeft)/offsetWidth;
    const percentDown = (clientY-offsetTop)/offsetHeight;
    const percentUp = 1-percentDown;
    const coords = {
        x: 2*percentRight - 1,
        y: 2*percentUp - 1,
    };
    /* Perform raycast */
    raycaster.setFromCamera(coords, camera);
    const hitList = raycaster.intersectObjects(markerMeshes, true);
    /* Miss: remove all markers from selection array (only if not trying to multi-select)  */
    if (hitList.length===0) {
        if (!(ctrlKey||shiftKey))
            props.updateSelectedMarkers.call(undefined, []); //set selectedMarkers to empty array
    }
    /* Hit: add or remove marker from selection array */
    else {
        /* Get index (into markerMeshes array) of the intersected marker closest to the camera (hitList[0]) */
        const hit = hitList[0].object.userData.index as number;
        /* Multi-select: add or remove single marker from existing selection array */
        if (ctrlKey||shiftKey) {
            props.updateSelectedMarkers.call(undefined, current => { //current is the existing selection array
                if (!current.includes(hit)) return [...current, hit]; //new marker: add to list
                return current.filter(x => x!==hit); //already selected marker: remove from list
            });
        }
        /* Single-select: narrow selection array to the single selected marker */
        else {
            props.updateSelectedMarkers.call(undefined, [hit]); //replace selection array with singleton
        }
    }
}, [raycaster, markerMeshes, props.updateSelectedMarkers, camera]);


Play/stop on mouse hover ?

Could you please provide an example on how to play/stop a gif with mouse hover instead of click?
Ideally I would also like the hover play to (optionally) ignore the loops parameter so it keeps playing indefinitely when hovered.
Thanks a lot.

Complete answer to yout question here --> https://codepen.io/jeankassio/pen/yLGrJGe
$(".gifimage").JKGifPlayer({
      autopause:false
  });

$(document).on('mouseover mouseout', '.gifimage', function(e) {

  $(".gifimage").PlayStop_Gif();

});


Unable to add ACLs using kfk acls --add but with kfk users --alter --add-acl

Hi,
I am trying to add an ACL like following
kfk acls --add --allow-principal User:secure-writer --operation Write --topic secure-topic -c my-cluster -n secure-ns
Hitting return key I get a message
kafkauser.kafka.strimzi.io/secure-writer configured.
But when I describe the user  using kfk users --describe --user secure-writer -n secure-ns -c my-cluster I don't see anything for Authorization added in the Spec portion of the User.
Similarly if I list the acls using
kfk acls --list -n secure-ns -c my-cluster  I don't see any entry for the secure-topic or for secure-writer.
Now I am trying to add ACLs using the kfk users
kfk users --user secure-writer --alter --authorization-type simple --add-acl --operation Write --resource-type topic --resource-name secure-topic -c my-cluster -n secure-ns
This works.
I can see the ACLs got updated for the user. I can see it updated under kfk user --describe as well as in kfk acls --list also.
Am I missing any parameters while creating the ACLs using kfk acls? or it's a bug?
Versions
Strimzi CLI 0.1.0a57
Strimzi 0.20.1
Kubectl v1.16.15
Regards,
Arpan

I think this is because we dont set authorization type while running kfk acls --add --allow-principal User:secure-writer --operation Write --topic secure-topic -c my-cluster -n secure-ns.
That should do it automatically. The following is an already open issue for this: https://github.com/systemcraftsman/strimzi-kafka-cli/issues/33
Will be fixed in the next release!

Closing this one as well since I will fix this in #33.

Fix is released with the new version: https://github.com/systemcraftsman/strimzi-kafka-cli/releases/tag/0.1.0-alpha58
Run the following to upgrade your Strimzi CLI version:
sudo pip install strimzi-kafka-cli --upgrade


Upload docker imager do GitHub instead of Docker hub?

Addressed in https://github.com/petergtz/g2s3/commit/b7fcd02a2c61171456058874e8da90229d993ff1 and https://github.com/petergtz/g2s3/commit/52e6c5e6f411a5e031157cc263fe44d0a1e4f1ab.


Debug miner (using serial interface)

Is your feature request related to a problem? Please describe.
I have about 5 hotspots who show the "LoRa ready: False" error on the local diagnostics page. Some of these miners are fully synced to the blockchain and others aren't (this could however just be an issue with patience). I removed and installed the LoRa module several times and checked the entire inside of the miner for any clues. I found none.
Describe the solution you'd like
For people that are technical, it would be really nice to offer some tools to debug and potentially fix the issue themselves. Support is slow because many people are having issues and need help. For those who could do a big part themselves it would be really nice to have the documentation and tools to do so. I spotted several options for connecting external devices such as a Micro USB connector and a serial interface, but data seems to come from this.
Describe alternatives you've considered
I tried taking apart some parts from the miner and carefully putting everything back together, but nothing seemed to help.
Additional context

EDIT: perhaps the issue wasn't named correctly. It isn't specifically about the serial port. I would like to be able to debug the miner in any way possible. The diagnostics page just tells me something is wrong, I would like to know what.
Is it for example possible to access logs? Restart services manually? Or maybe just freshly pull the docker images? As far as I know, all miners run the software found here: https://github.com/NebraLtd/helium-miner-software/blob/master/docker-compose.yml

It shows lora operational false because you haven't asserted the location yet.
We will not be adding serial debug.
If you need any further assistance please email<EMAIL_ADDRESS>

@Underlyingglitch You are able to restart the services through our dashboard https://dashboard.nebra.com/

It shows lora operational false because you haven't asserted the location yet.
We will not be adding serial debug.
If you need any further assistance please email<EMAIL_ADDRESS>
I can't add a location yet since the miner is "not ready yet". I have added other miners that show "All okay" before adding a location.
This is clearly not the issue

@Underlyingglitch You are able to restart the services through our dashboard https://dashboard.nebra.com/

@KevinWassermann94 Thank you for the reply. The dashboard will unfortunately become a paid product, which means I'm trying to avoid it. Besides, that won't solve my issue since the miner isn't connected to Helium yet, which results in this error:

This is not a support channel.
Please email<EMAIL_ADDRESS>

And just to further clarify, you are incorrect. It will always show lora operational false if you haven't asserted the location yet.
Because the concentrator can't start up until it knows what region it's in.

And just to further clarify, you are incorrect. It will always show lora operational false if you haven't asserted the location yet.
Because the concentrator can't start up until it knows what region it's in.

@shawaj
I'm incredibly sorry! You are correct. After setting a location the error disappeared. I have no idea why other hotspots showed the green "All ok" even when no location was set but I'm glad this fixed it.
As for your other comment. On your website you listed this repo (and specifically the issues page) as an alternative way to reach you. https://helium.nebra.com/support
I thought it would be okay for me to use this. It usually takes really long before an email is replied to and often the contents of the reply aren't about the question that was asked. I really liked the fact that I got a fast and meaningful reply here on GitHub just as I loved this when Helium still allowed manufacturers to use their Discord server for that purpose. I have seen how you guys were treated there so I understand why they stopped it. I have however always tried to be nice to other people, especially people that try to help me.
I will stop using GitHub for questions, but I do advice you to remove it from the webpage listed above as that makes it really confusing!
Have a nice day!


Miscellaneous (Running on Android)

I ran it above termux ,It would be great if I could test it on my cell phone and take it anywhere.
If you want to run it like me you need to download python for termux, and pip packages, then you download the code file on the developer page, then extract it and launch:
Here is my example:
python /storage/emulated/0/Download/VoiceAI-Asuna-main/RUN_ME.py
You can develop it on your phone if you have python installed, Pydroid3 works really well for this out of the box (Editing and running). For me, I use (Acode to write python code ) As for running code, I use termux .
Note that your device must have enough capacity, more is better (1gb RAM should be enough up till now)

Thanks. Pinned (and edited sone stuffs) I actually developed most of the code using Pydroid3 and it doesn't even require termux and its a really good code editor.

I use both acode and pydroid3 , to write code. As for running code, I use termux , sometimes I use chatgpt to correct me when I write wrongly .


Declare compatibility with Jekyll 4.

To allow using Jekyll 4 (pre-release) with jekyll-data, the dependency declaration needs to be changed.
The combination of jekyll-data and Jekyll <IP_ADDRESS>.pre.alpha1 seems to work properly; at least I could not find any issues.

@ashmaroli:
As far as I can tell, the Travis CI failures have not been caused by my changes. It seems something in the build script is not compatible with the older Ruby versions.
However, I don't have enough experience with this to be completly sure what's going on.
Could you maybe have a quick look?

Thank you for submitting this PR @rschaeuble.
The Travis failures are indeed because of incompatible Ruby versions. I'll update the master branch separately.

Thank you @rschaeuble.


npm install error - typings install

Hi,
I'm encountering an issue when attempting to install the dependencies for this repo.
It happens during the postinstall script when attempting the typings install command
The output I see is:
> typings install

typings ERR! message Unable to read typings for "es6-shim". You should check the
 entry paths in "es6-shim.d.ts" are up to date
typings ERR! caused by Unable to connect to "https://raw.githubusercontent.com/D
efinitelyTyped/DefinitelyTyped/7de6c3dd94feaeb21f20054b9f30d5dabc5efabd/es6-shim
/es6-shim.d.ts"
typings ERR! caused by unable to get local issuer certificate

typings ERR! cwd C:\Users\rparker\Documents\GitHub\angular2-seed
typings ERR! system Windows_NT 6.1.7601
typings ERR! command "C:\\Program Files (x86)\\nodejs\\node.exe" "C:\\Users\\rpa
rker\\Documents\\GitHub\\angular2-seed\\node_modules\\typings\\dist\\bin.js" "in
stall"
typings ERR! node -v v4.4.1
typings ERR! typings -v 0.7.12

Now I am behind a proxy, so was thinking it must be an issue with the resource being blocked for some reason.
I can actually navigate to the url referenced in the error above in a browser and the github page opens up just fine.
Digging around the web I have come across posts with instructions on how to add proxy settings to the npm config file. I know the proxy details, so in mine I now have:
ca=
strict-ssl=false
registry=http://registry.npmjs.org/
proxy=http://myusername:mypassword@proxydomain:proxyport
https-proxy=http://myusername:mypassword@proxydomain:proxyport

This has made no difference for me, so I'm unsure what to do next.
Can anyone offer any advice?
Thanks

You are more likely to get an answer on stack overflow. This is NOT a support site.

Thanks for the informative and detailed advice


KNOX-1872 - Update Ranger service definitions to support trusted proxy

What changes were proposed in this pull request?
Make Ranger service definitions support trusted proxy by default
How was this patch tested?

mvn -T.5C clean verify -Ppackage,release
Tested proxying Ranger UI and API with updated service definitions on Kerberized cluster

Hmmm this is causing a test failure. Not sure why yet.
[ERROR] Failures:
[ERROR]   DeploymentFactoryFuncTest.testServiceAnonAuth:716
Expected: an XML document with XPath /gateway/resource[1]/filter[1]/role "authentication"
     but: was "federation"

Test was assuming that RANGER service definition was anonymous. Switched to Ambari which is anonymous and fixed some parsing of the gateway.xml


Check HostNameAndPort is defined before calling endsWith

Occasionally the HostNameAndPort is undefined which causes the page to crash. This change checks it is defined before trying to call endsWith.
Using:
    "@azure/msal-browser": "^2.32.2",
    "@azure/msal-react": "^1.5.2",

HostNameAndPort should never be undefined. There's something else going on here. Please upgrade to the latest (v3) and check if this has been resolved. If it's still occurring please open an issue so we can dig in deeper to understand why you're getting undefined here.


Matches predicate incorrectly uses case sensitive compares for object keys

Reported here: https://groups.google.com/forum/#!topic/mountebank-discuss/p-n4U-3dBuM
The following predicate does not match if the header is "authorization" instead of "Authorization", even though it should be case-insensitive by default:
{
    "matches": {
        "headers": {
            "Authorization": "Bearer [a-zA-Z0-9-_]{1,100}"
        }
    }

closed as of 5b96071

Many thanks for fixing this.  We have upgraded to 1.7.1 and it fixed out problem.  I work with the developer who reported this on Google groups and we discovered this after finding out our API gateway forces request headers to lower-case when calling downstream services.   Working like a charm very special thanks for addressing this so quickly we really appreciate it and love this software.

Happy to help, glad you guys were able to find the bug.


Add vampyteuth's file

So far I have:
created a branch
created a file
made a commit
opened a pull request

I am sorry to inform you but your application to become a GitGod has been declined.


broken encoding with python 3.4 (fix inside)

context:
.../site-packages/oauth2client/client.py", line 1515, in __init__
self.private_key = base64.b64encode(private_key)
File ".../venv/lib/python3.4/base64.py", line 62, in b64encode
encoded = binascii.b2a_base64(s)[:-1]
TypeError: 'str' does not support the buffer interface

Changing line 1515 in oauth2client/client.py from this:
self.private_key = base64.b64encode(private_key)

to this:
self.private_key = base64.b64encode(private_key.encode('ascii'))

fixed my issue.
reference:
http://stackoverflow.com/questions/27160352/when-convert-to-base-64-typeerror-str-does-not-support-the-buffer-interface

Can you do a pip3 show oauth2client to determine what version you have?
If this hasn't already been resolved in a release, it probably will be in 1.5.0 (#292)

---
Metadata-Version: 1.1
Name: oauth2client
Version: 1.4.11
Summary: OAuth 2.0 client library
Home-page: http://github.com/google/oauth2client/
Author: Google Inc.
Author-email: UNKNOWN
License: Apache 2.0
Location: /home/rich/Projects/github/payrollscripts/venv/lib/python3.4/site-packages
Requires: httplib2, pyasn1, pyasn1-modules, rsa, six

Thanks.
The latest version is 1.4.12: https://pypi.python.org/pypi/oauth2client/1.4.12
If you upgrade does the problem persist?

Found the line in the 1.4.11 release: https://github.com/google/oauth2client/blob/c61bdf4565782db82172b450284fb969150dd32b/oauth2client/client.py#L1515

Traced the line to the current head, still an "issue": https://github.com/google/oauth2client/blob/b66838e48da243a7fefa7275044f6b5833ec1476/oauth2client/client.py#L1632
@richiverse For now, use bytes, but your suggestion should make it into the codebase, so thanks!
Easiest way (if you're reading from a file) is opening in read binary ('rb') mode.


Merge branch 'feature/213_advanced_search' into v1

Diff is probably off, because we already merged it into v1. To see the real diff, check the changed in the feature branch.

Coverage remained the same at 82.496% when pulling 5f3b399e74b447e9b6bc63ff73f3c769cddb3b9d on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage remained the same at 82.496% when pulling 11a4b4893bfc0bb17942bc4285946d30fec14204 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage remained the same at 82.496% when pulling 3a093f8eee316a0936508f7452496b351c85e765 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage remained the same at 82.496% when pulling 97177ea54ae89a33fe6455a97a9281603fe32025 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage remained the same at 82.496% when pulling 4e11d1fbbed6442585dea9c00b46fe761241a4c0 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage remained the same at 82.496% when pulling 15d7277a2f8f68685bc7f6a9bad1555cd672312d on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-1.0%) to 81.533% when pulling 57d432d6964307a29fbfc1994b5cdadf3a108272 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-1.0%) to 81.533% when pulling 57d432d6964307a29fbfc1994b5cdadf3a108272 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-0.2%) to 82.317% when pulling e3cdd94987befe12ca589c5f7e57cb9b97068afd on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-1.004%) to 81.492% when pulling 094242d911022ad6290aa809141cb4c88514691f on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-1.01%) to 81.481% when pulling 094242d911022ad6290aa809141cb4c88514691f on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-1.01%) to 81.481% when pulling 35fcb92fd209320d9591c1163647f157a9e26085 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-1.01%) to 81.481% when pulling f75ecfe36e286ac83b5a2c56bd61d77df002ea4b on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-1.01%) to 81.481% when pulling 4240f958c7b2fcf90b3d34b0786f87851a1d2643 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-1.01%) to 81.481% when pulling d49ccd5c2c92895e8e7a91e1bb1798142385fdf7 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-0.3%) to 82.208% when pulling d49ccd5c2c92895e8e7a91e1bb1798142385fdf7 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-0.3%) to 82.208% when pulling d49ccd5c2c92895e8e7a91e1bb1798142385fdf7 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-0.3%) to 82.208% when pulling d49ccd5c2c92895e8e7a91e1bb1798142385fdf7 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-0.3%) to 82.208% when pulling e3f952c76cf750e7b0f06e5e1d5c8db11e31e741 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-0.3%) to 82.208% when pulling e3f952c76cf750e7b0f06e5e1d5c8db11e31e741 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-0.3%) to 82.208% when pulling 8b098a7428a951e253a572ba581c2ff7561832bf on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-0.3%) to 82.208% when pulling 65bab5eb7d4c2797c7fa30a9ddb173d28cd1995e on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-0.3%) to 82.208% when pulling 8eaf3a41959378ea6c7bd8886a48ccc1e75df56f on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-0.3%) to 82.208% when pulling 5f07d40585db1a8a570dd533b7165f782749adb8 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-0.3%) to 82.208% when pulling d780de28de5219e2d8e688290d1c0a53258ddb1f on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-0.3%) to 82.208% when pulling 1f49c854e6a69cec9bbbc752612043dc818990e1 on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.

Coverage decreased (-0.3%) to 82.208% when pulling 3b8a90dc54294d4ff571bbc8ca1ff9219517cb4a on v1 into 6e48243be277f413f0102d0284f77f968c6d6147 on feature/213_advanced_search.


How to address TypeError: 'NoneType' object is not callable?

I use below to print the error message
except ImportError as e:
print(f"ImportError: {e}")
causal_dot_product_cuda = causal_dot_backward_cuda = None
it tells me ImportError: No module named 'fast_transformers.causal_product.causal_product_cuda'
So I think the issue is that Python is unable to load the causal_product_cuda.cu file in the causal_product directory under the fast_transformers package.
How can I resolve this?

Hi, bro, have you figured out ? I came across the same problem. Could you please share the solution with me. Thanks a lot.

I use below to print the error message except ImportError as e: print(f"ImportError: {e}") causal_dot_product_cuda = causal_dot_backward_cuda = None it tells me ImportError: No module named 'fast_transformers.causal_product.causal_product_cuda' So I think the issue is that Python is unable to load the causal_product_cuda.cu file in the causal_product directory under the fast_transformers package. How can I resolve this?

Hi, bro, have you figured out ? I came across the same problem. Could you please share the solution with me. Thanks a lot.


Support volumes mounted multiple times as read-only

It'd be great to support the ability to mount a single volume into multiple Kubernetes pods as read-only.
Possible use-cases:

web root shared between a bunch of nginx instances
seed or cache some data for an application

+1

@rimusz Can you expand on what your use-case is for this?

there are many kind of statefull Apps which need to share the same files:
e.g. Wordpress setup with Management Pod to make updates and the rest of Pods just read the shared files as read only

I believe JIRA enterprise in cluster setup also requires this.

Yeah, let's do it. This turns the virtual Mutex in block/{metadata,etcd}.go into a RWMutex.

It seems this is not yet implemented even though v0.1.2 is out? Would be super important feature also in web applications like Drupal although the ultimate goal would be this https://github.com/coreos/torus/issues/235


Sort search results

Story: As a user I want to sort search resalts by price or posted time in order to get increasing or dekreasing list of ads according search criteria.
DoR:

[ ] The application works before the changes takes place
[ ] In the application are items (ad) stored in the database for testing purpose

Acceptance criteria:

[ ] AC1: Dropdown with following sort criteria is available on the page with search results:
EN: Highest price, Lowest price, Most recent, Oldest (most reduced). --> DGU: place is also a sort criteria for sort up/down direction
DE: Teuerste, Günstigste, Älteste, Neueste, Ort alphab aufsteigend, Ort albabeb absteigend

[ ] AC2: Default: most recent.  --> DGU changed at 2022.09.28: the default today is unknown. The default ist place ascending This is the default value for initial show results.
Example with data of 2022.09.28 on INT environment:
All ad in order
Geneve
Genf
Kreuzlingen
Solothurn
Thusis
Worblaufen

[ ] AC3: Sort by the highest price show the ad with highest price as a first one and futher decreasing to the ad with lowest price (for request "max rent" should be use,  no value = 0)

[ ] AC4: Sort by the lowest price show the ad with lowest price as a first one and futher increasing to the ad with highest price

[ ] AC5: Sort by the most recent show the last published (newest) ad as a first one and futher decreasing to the ad a latest publish date

[ ]  AC6: Sort by the oldest show at latest point of time published ad as a first one and futher increasing to the last published ad (newest)

DoD:

[ ] The new dropdown item is selectable
[ ] When the dropdown item gets changed, the resultset will be reloaded with the order selected in the dropdown list
[ ] The title of the ad is the default search parameter and is used at every initial run to show the results

Check how the fields for search and creation are added to the forms - subcategory_field, field and field_options tables in the database(maybe add a sortable column and sortable_options?).

Data on INT at 2022.09.28:

If the user return from the detail view of an ad the last sort criteria should be used att refresh or when the last sort page was showing up results.
This is a new request documented by Daniel and Asida in the meeting at 11th oct 2022.

Sereno, 23.12.2022: Testing done, test document done, Test passed / ok


edit: remove filter plan node in pipeline

Rationale
close #341
Detailed Changes
I  just change supports_filter_pushdown in TableProvider to return TableProviderFilterPushDown::Exact to fix this
Test Plan
pass

This issue seems to have been fixed in other pr🤔

Don't worry, the original issue isn't fixed, I will look into why we can't change to Exact directly.

I have found the cause why those case failed, in https://github.com/CeresDB/ceresdb/issues/605 we only allow pushdown primary key filters, so we cannot directly change this to Exact here.

ok, I'll check other places to fix the problem

If when want to return Exact here, we need to ensure following cases are met:

The table is in overwrite mode, and the filter only contains primary key
The table is in append mode

For case 2, you need to update check_and_build_predicate_from_filters to pushdown all filters.
https://github.com/CeresDB/ceresdb/blob/ae17b1f6322fbf3abcc23386d685128b28c1a532/table_engine/src/provider.rs#L186

@dust1 Your implementation is fine, I will fix CI failed based on your code, please don't push again.

Well, I was gonna fix it later😂

You can retry other issue first, I want to verify this in one of my deployment first.


Error in install

Using /home/casper/.rvm/gems/ruby-2.4.1
$ sudo gem install idb
Building native extensions.  This could take a while...
ERROR:  Error installing idb:
	ERROR: Failed to build gem native extension.

    current directory: /var/lib/gems/2.4.0/gems/libxml-ruby-3.0.0/ext/libxml
/usr/bin/ruby2.4 -r ./siteconf20170915-2692-m548iq.rb extconf.rb
/usr/bin/ruby2.4: warning: shebang line ends with \r may cause a problem
mkmf.rb can't find header files for ruby at /usr/lib/ruby/include/ruby.h

extconf failed, exit code 1

Gem files will remain installed in /var/lib/gems/2.4.0/gems/libxml-ruby-3.0.0 for inspection.
Results logged to /var/lib/gems/2.4.0/extensions/x86_64-linux/2.4.0/libxml-ruby-3.0.0/gem_make.out
$ ruby -v
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]

so i fix  that when install  libxml...


add code for chapter 1 to 6

Place code in /book directory, for each chapter N-start and N-end codebases.

d80eb69a30b07ebebec29b481365ec9bd24ebcf0


Networking speeds are slow, is this expected?

Firstly, kudos to this project, it has saved me hours of fiddling with networking myself. I couldn't get the tap and bridge stuff working using older guides and found this when Limactl hit the top of HN.
This isn't a complaint more a expectations check.
I've a 400mbit internet connection and generally see downloads of 10+MB/s. I followed the guide to get networking on qemu on MacOSX working and buil the tool using the latest master branch (current top commit 14e1c9e06f4dbdddc6fe4e85fc72a1d583b049ad) and am seeing downloads of this:
72.2 kB/s 19min 46s while doing an apt-get of various libraries.
So the question is, is there anything that can be done to speed this up? or is this expected behaivor?
Below is the qemu script I use to start my VM:
qemu-system-x86_64 \
  -m 8G \
  -vga virtio \
  -display default,show-cursor=on \
  -usb \
  -device usb-tablet \
  -machine type=q35,accel=hvf \
  -smp 4 \
  -device virtio-net-pci,netdev=net0 -netdev vde,id=net0,sock=/var/run/vde.ctl \
  -drive file=./disks/ubuntu.qcow2,if=virtio \
  -cpu Nehalem

I should note that iperf3 showed speeds of 41mbits from the MacOS host and this VM.
output of configure:
Configure results:

 - VDE CryptCab............ disabled
 + VDE Router.............. enabled
 - TAP support............. disabled
 + pcap support............ enabled
 - Experimental features... disabled
 - Profiling options....... disabled

PTP mode might be faster https://github.com/lima-vm/vde_vmnet/tree/v0.5.0#ptp-mode-switchless-mode

Or you might be hitting this https://gitlab.com/qemu-project/qemu/-/issues/334 (“macOS App Nap feature gradually freezes QEMU process”)

Or you might be hitting this https://gitlab.com/qemu-project/qemu/-/issues/334 (“macOS App Nap feature gradually freezes QEMU process”)

I saw something that I think might have been related to this in the QEMU output saying that one of the cores was stalled... I will look into that.
Thanks for the suggestion about ptp I will try that.

PTP mode might be faster https://github.com/lima-vm/vde_vmnet/tree/v0.5.0#ptp-mode-switchless-mode

Where can I learn more about PTP mode? Would this allow the host to still talk to the guest over some ports? i.e ssh and 8080 (for web stuff)?

Would this allow the host to still talk to the guest over some ports? i.e ssh and 8080 (for web stuff)?

Yes

Wow, disabled AppNap globally and got this getting the Linux kernel:
linux-5.14.tar.xz                   55%[==================================>                             ]  63.71M  1.52MB/s    eta 36s

but apt installing zsh for example only nets me 68KB/s... I guess it could be a combination of issues.

PTP works fast enough for this to be useful to me, thank you so much for the suggestion!


Entrypoint Problems.

There is a problem with entrypoint.sh creating the correct config file for MariaDB in the /files directory.  This will be worked on later.    All configs will eventually be moved to the files/config directory in order to keep persistent data organized.

Files have been moved to files/config as of the latest build.  Please test functionality.


Implement returning Result from test functions.

Fixes #5.
I also tried to fix #9, but I don't think its properly possible without a proc macro.

@AltSysrq: thanks for all your work on this crate, it's really excellent. If it could be extended to support async functions, it would be even more excellent. Could this pull request and #11 be merged into a new release?


Git LFS fails to checkout when Git repo is used via symlink

I think this one is related to https://github.com/github/git-lfs/issues/591
The basic failure test-case is the following:

Clone fresh repo, with git-lfs configured
Create a symlink to this repo somewehere
cd into repo by symlink
git lfs fetch; git lfs checkout - fetch succedes, checkout fails with error: git-lfs died of signal 13

Doing absolutely the same thing without symlink works just fine.
Here's the output of git lfs env, when accessing repo by symlink, the top arrow is the real path, the bottom one is symlink path.

More on that, git lfs logs last are empty in this case:

Probably related to
https://github.com/github/git-lfs/issues/811
https://github.com/github/git-lfs/pull/818

Tried with merged https://github.com/github/git-lfs/pull/816 patch. No luck.

Cool, thanks for the report. Can you try running GIT_TRACE=1 git lfs checkout instead? I wonder what it's doing before it dies of signal 13.

If I am reading this issue correctly, I believe that it is a duplicate of https://github.com/git-lfs/git-lfs/issues/811, which was fixed in #818.


Fix empty commits

Codecov Report
Base: 87.88% // Head: 93.23% // Increases project coverage by +5.34% :tada:

Coverage data is based on head (f408dde) compared to base (bd6aae3).
Patch coverage: 90.90% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   87.88%   93.23%   +5.34%
==========================================
  Files          35       20      -15
  Lines        1775     1301     -474
==========================================
- Hits         1560     1213     -347
+ Misses        215       88     -127

Flag
Coverage Δ

libs_libcommon
?

services_admin
?

workers_datasets_based
93.23% <90.90%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...tasets_based/src/datasets_based/workers/parquet.py
91.66% <90.90%> (ø)

services/admin/src/admin/app.py

services/admin/src/admin/routes/cancel_jobs.py

services/admin/src/admin/config.py

services/admin/src/admin/routes/cache_reports.py

libs/libcommon/tests/test_storage.py

libs/libcommon/tests/test_processing_steps.py

services/admin/src/admin/routes/force_refresh.py

libs/libcommon/src/libcommon/log.py

services/admin/src/admin/utils.py

... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Changable light level in machines

Hi,
it seems the light level in the machines is fixed (I guess it's tied to the dimension where the boxes are). Would it be possible to change that individually? Even if I pad the walls with stone the light level doesn't change which unfortunately makes the use of spawners in boxes impossible right now.

This is planned. CM will get upgrade slots at some point in the future, one of them will be "Sunlight". Details are still unclear.

Currently working on a 1.10.2 version, the 1.7.10 version is not being maintained anymore, sorry.
Closing all issues not relevant for the new version.


Checkbox documentation needs two alignment options

Detailed description

Describe in detail the issue you're having.
The Carbon Design System checkbox page mentions vertical stacking and horizontal alignment.
The documentation for carbon components angular does not mention anything relating to the alignment of checkbox groups, even though it is a pretty common use case to have it aligned in either of the two ways.

Is this a feature request (new component, new icon), a bug, or a general issue?
General issue

Is this issue related to a specific component?
Checkbox

To be clear, is this a documentation issue or a functionality issue? I.e. do we support both alignments but it's not documented, or do we need to support and document both alignments?

The link specified in the OP suggests this is something supported in Carbon Components vanilla.
And from what I understand, carbon components angular is a wrapper on top of that.
So it would seem we need documentation of how to achieve this.


"Change introspection" button missing on npm version.

Hey, probably a lame question. I've installed raphql-voyager via npm, but I don't see the "Change introspection" button. I see only graph for Query, but can't switch to Mutation view, which is what I thought the button is for. I could probably change it using displayOptions.rootType, but that would mean exposing two instances of voyager to see both Query and Mutation, right..?

@kub1x Yes you right. We added "Change introspection" to showcase different APIs in Voyager and just added other settings there because it was easier.
As a proper solution, we want to add the floating menu with all settings on the main screen. Don't have any estimates but we still plan to work on it.
I'm closing this issue since it's duplication of #15


dev -> main-beta

:tada: This PR is included in version 2.0.0-beta.17 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Change default scaling option for Scatter plot and other operators/plots

This is similar to #3274 except for Scatter plot. We should probably also audit rest of plots and operators for any other instances of this. In each case, having the Always, Auto, Never options for which mode the scaling is in and having the default be Auto mode based on aspect ratio is probably a decent choice.  But, we should also take a look at the interface used for the similar feature in views for fullframe mode in 2D view mode and for Curve view mode. The 2D fullframe mode is a similar AAN setting based on aspect ratio whereas the Curve view allows user to specify min/max of the axes. Not sure which of these two modalities is best or if some hybrid of them is best.
In the case of scatter plot, it appears to default to mapping things to the unit square or the unit cube and there is a check-box to disable that. And, again, this leads to incorrect use of the plot for certain common cases. So, it would be better for Scatter plot to default to an auto mode based on aspect ratio.
Impact
(Please click check boxes AFTER submitting ticket)

[ ] High - User productivity significantly improved
[x] Medium - User productivity partially improved
[ ] Low - User productivity trivially improved

This is related to #3727


Update go to go1.17.8 which was released 2022-03-03

Tool name
go
Tool license
MIT
Add or update?

[ ] Add
[X] Update

Desired version
go1.17.8
Approximate size
No response
Brief description of tool
No response
URL for tool's homepage
No response
Provide a basic test case to validate the tool's functionality.
No response
Virtual environments affected

[X] Ubuntu 18.04
[X] Ubuntu 20.04
[X] macOS 10.15
[X] macOS 11
[X] Windows Server 2016
[X] Windows Server 2019
[X] Windows Server 2022

Can this tool be installed during the build?
No response
Tool installation time in runtime
No response
Are you willing to submit a PR?
No response

I made this issue here because go1.17.8 is missing from https://github.com/actions/go-versions and the README there said make the issue here!

@ncw would just installing 1.18 resolve your issue?

Hello @ncw ,
Go 1.17.8 and 1.18.0 were added to go-versions. Sorry for delay and thank you for your patience:
https://github.com/actions/go-versions/blob/main/versions-manifest.json#L28


Apply syntax highlighting and line numbers to code blocks

Apply syntax highlighting and line numbers for code blocks that do not have those.

This will not be done. It's very hard to implement and maintain.