The presence of some zero coefficients might cause robyn_allocator to report all coefficients are zero

Project Robyn
Describe issue
Hey Team
1st iteration:
I am running Robyn 3.6.1 and failing to produce meaningful allocation.
When I extract the coefficients of a Robyn model named 1_237_4 from Robyn::robyn_outputs output, then I see that only cinema_spend and print_spend are zero (see attached table).

When I run Robyn::robyn_allocator employing model 1_237_4, then I get the following message, saying that all of my coefficients are zero.
>>> Running budget allocator for model ID 1_237_4 ...
cinema, cpcv, cpm, native, ooh, print, radio, sem, tv are excluded in optimiser because their coeffients are 0

Why does Robyn::robyn_allocator claim that all coefficients of the selected model are zero while the returning object from Robyn::robyn_outputs shows otherwise?
2nd iteration:
In this iteration, I hypothesise that the presents of zero coefficients lead to the above discrptency.
To test that I:

Exclude  cinema_spend and print_spend from paid_media_vars (the variable with zero coefficient in the first iteration);
Rerun the model; and
Call Robyn::robyn_allocator

This time, Robyn::robyn_allocator produces meaningful allocation with the following message
>>> Running budget allocator for model ID 1_248_4 ...

Therefore, it seems the presence of some zero chaffinches led Robyn::robyn_allocator to report all coefficients are zero.
Provide dummy data & model configuration
See the above experiment
Environment & Robyn version

Robyn v3.6.1
R version 4.1.1 (2021-08-10)

Hi @harell thanks for reporting this issue. Before I start helping you and Kyle debug this issue, can you please check this, follow the steps to check if this issue was solved already in that branch and if not, let us know?

Feel free to re-open if this particular error or issue persists when updating to 3.6.2 @harell

This is still an issue. The allocator works when all the channel boundaries are between 0.5 and 2 (on all the channels). But once the boundaries are between 0.9 and 1.1, the allocator prompts the '0' coefficients message.

@harell could you run remotes::install_github("facebookexperimental/Robyn/R") and try this again? and if you don't mind then sharing what the actual coeffs are that it is saying are 0? Thanks again for your patience.

What commit to master do you think will resolve it?
I tried running the code with tag v3.6.2. The problem presists.

@kyletgoldberg I still have this issue. Three channels with 0-coefficients are included in the allocator, and three channels with non zero coefficients (our most contributing channel as well as smaller channels) are excluded.

Hi @johnscherrer there was def an error in the message displayed. I fixed it earlier today. Now, let me see if I understand what's happening in your case for the last part: it's filtering non 0-coef and leaving some 0-coef variables in mediaSpendSortedFiltered result?

@laresbernardo correct

The allocator message reports the zero coefficients now
Before: Using Robyn 3.6.2 I get

Now: Using commit 990aa8f768976b598e473ffdf9304e3242f76b7b I get

@harell thanks for confirming. Is it fixed for your case then?
@johnscherrer if the error persists, can you help me debug what's wrong with your case? Can you check the sortings? The selection should be fixed now and I think you shouldn't have problems anymore but you say you do. Do you have a reproducible example? I suggest you try running robyn_allocator() line by line to check where and why you get this unexpected behavior.

@laresbernardo The error persists for me, but think I found the error source for my case. Will try to explain what goes on when debugging lines 160-178:

Lines 160 to 166 seems to work correctly. Can confirm that coefSelectorSorted sets the correct 0-coeff boolean labels on the variables correctly.
chn_coef0 <- setdiff(names(coefSelectorSorted), mediaSpendSorted[coefSelectorSorted]) does not return correct values.
mediaSpendSorted[coefSelectorSorted] returns the correct amount of variables, but some of the wrong variables (with 0-coefficients), so the output here is wrong. What happens when I run mediaSpendSorted[coefSelectorSorted] is that it applies the true/false-labels in coefSelectorSorted according to their sequential order, on mediaSpendSorted in which the media channel names is sorted differently (alphabetically?). Hence it's picking out some of the wrong channels due to the difference in sorting.

Example of what happens - if:
mediaSpendSorted = "channel_1", "channel_2", "channel_3", "channel_4", and
coefSelectorSorted = channel_2: TRUE, channel_3: TRUE, channel_1: FALSE, channel_4: FALSE
Then mediaSpendSorted[coefSelectorSorted] returns channel_1, channel_2, when I suppose it should return: mediaSpendSorted[coefSelectorSorted] = channel_2, channel_3.
The same method is used at line 173:  mediaSpendSortedFiltered <- mediaSpendSorted[coefSelectorSorted]. That's probably the reason for using wrong variables in the budget allocator.
Please let me know if this makes sense from your end. Thanks

The sorting part should happen here so the order of the variables is always the same (alphabetically), or at least that's what's expected to happen. Can you try adapting the code until it behaves as it should for your variables please?

You're right. It was the mediaSpendSorted that wasn't sorted alphabetically in my case, because media_order <- order(paid_media_vars) and not media_order <- order(paid_media_spends). I had names the paid_media_vars and paid_media_spends inconsistently, causing different alphabetical orders.
Now the issue is resolved. Thanks!

That's great!! So (in short) changing line 128 to get_rn_order <- media_order should work then?

I changed line 128 from media_order <- order(paid_media_vars) to media_order <- order(paid_media_spends)

Please, can you run robyn_update(ref = "6f0e467"), restart your session and test if it works OK for your case? Thanks again @johnscherrer

Got the error msg Error in robyn_update(ref = "6f0e467"): could not find function "robyn_update" Traceback:. so I haven't been able to check. I changed one variable name in my paid_media_spends to fix the issue.

Ah sorry, this should work then: install_github(repo = "facebookexperimental/Robyn/R", ref = "6f0e467").. robyn_update it's a new function you might not have yet. Can you please try without changing the variable name just to be sure this worked? Thanks a lot

Getting this error now:
Error in glued("\nModel ID: {x$dt_optimOut$solID[1]}\nScenario: {scenario}\nMedia Skipped (coef = 0): {paste0(x$skipped, collapse = ',')}\nRelative Spend Increase: {spend_increase_p}% ({spend_increase}{scenario_plus})\nTotal Response Increase (Optimized): {signif(100 * x$dt_optimOut$optmResponseUnitTotalLift[1], 3)}%\nWindow: {x$dt_optimOut$date_min[1]}:{x$dt_optimOut$date_max[1]} ({x$dt_optimOut$periods[1]})\nAllocation Summary:\n  {summary}\n",  :    could not find function "glued" Called from: print(glued("\nModel ID: {x$dt_optimOut$solID[1]}\nScenario: {scenario}\nMedia Skipped (coef = 0): {paste0(x$skipped, collapse = ',')}\nRelative Spend Increase: {spend_increase_p}% ({spend_increase}{scenario_plus})\nTotal Response Increase (Optimized): {signif(100 * x$dt_optimOut$optmResponseUnitTotalLift[1], 3)}%\nWindow: {x$dt_optimOut$date_min[1]}:{x$dt_optimOut$date_max[1]} ({x$dt_optimOut$periods[1]})\nAllocation Summary:\n  {summary}\n",      scenario = ifelse(x$scenario == "max_historical_response",          "Maximum Historical Response", "Maximum Response with Expected Spend"),      spend_increase_p = signif(100 * x$dt_optimOut$expSpendUnitDelta[1],          3), spend_increase = formatNum(sum(x$dt_optimOut$optmSpendUnitTotal) -          sum(x$dt_optimOut$initSpendUnitTotal), abbr = TRUE, sign = TRUE),      scenario_plus = ifelse(x$scenario == "max_response_expected_spend",          sprintf(" in %s days", x$expected_spend_days), ""), summary = paste(sprintf("\n- %s:\n  Optimizable Range (bounds): [%s%%, %s%%]\n  Mean Spend Share (avg): %s%% -> Optimized = %s%%\n  Mean Response: %s -> Optimized = %s\n  Mean Spend (per time unit): %s -> Optimized = %s [Delta = %s%%]",          x$dt_optimOut$channels, 100 * x$dt_optimOut$constr_low -              100, 100 * x$dt_optimOut$constr_up - 100, signif(100 *              x$dt_optimOut$initSpendShare, 3), signif(100 * x$dt_optimOut$optmSpendShareUnit,              3), formatNum(x$dt_optimOut$initResponseUnit, 0),          formatNum(x$dt_optimOut$optmResponseUnit, 0), formatNum(x$dt_optimOut$initSpendUnit,              3, abbr = TRUE), formatNum(x$dt_optimOut$optmSpendUnit,              3, abbr = TRUE), formatNum(100 * x$dt_optimOut$optmSpendUnitDelta,              signif = 2)), collapse = "\n  ")))

That's an error in the print method (i.e. printing AllocatorCollect results). Were you actually able to run robyn_allocator() successfully first?

Yes, now the budget allocator picked out the correct channels, without changing variable name!!

Ok, that's good news! So the allocator is fixed but you seem to have problems printing the results when running print(allocator_results) right? This is what we are running to print results in a nice format. Would you be able to check these values and see why you get an error? It's not quite informative given it's literally printing the whole code without saying "you are missing X value".

print(allocator_results) works for me now too, did a mistake in the code on my end


Care Icon in Footer not rendered properly

URL:
https://contributors.ohc.network/leaderboard/last-week
Browser Name:
Chrome
Browser Version:
131.0.6778.205
Operating System:
Windows 11
How to reproduce the issue:
Care icon in the footer is not being rendered properly.

@rithviknishad I would like to fix this.

@rajku-dev i have already addressed this in #588


Support for named benchmarks

Related to #481

Coverage increased (+0.3%) to 58.522% when pulling baff01dfba4b24e3608f45f442f8f14bbe26f971 on philpep:benchmark-name into a14d8dc70442faef6e8b4eacb60ffc9c3d488fa6 on spacetelescope:master.

Coverage increased (+0.3%) to 58.522% when pulling baff01dfba4b24e3608f45f442f8f14bbe26f971 on philpep:benchmark-name into a14d8dc70442faef6e8b4eacb60ffc9c3d488fa6 on spacetelescope:master.

Coverage increased (+0.3%) to 58.522% when pulling f1fe09bbf7705fd479c620d7c8bdda15fc5a4212 on philpep:benchmark-name into a14d8dc70442faef6e8b4eacb60ffc9c3d488fa6 on spacetelescope:master.

Coverage increased (+0.2%) to 58.49% when pulling 81c06ebab2d7ce5a8e1ca6ddd76cd4004b2af2c3 on philpep:benchmark-name into a14d8dc70442faef6e8b4eacb60ffc9c3d488fa6 on spacetelescope:master.

I guess this is mostly OK. Comments:

I think the attribute name should be the more specific benchmark_name instead of name
The benchmark selection now needs to import the whole benchmark suite for each benchmark run, which may be expensive. Would it make sense in get_benchmark_from_name to first try importing the benchmark function based on its name, and only if that fails fall back to scrounging with disc_benchmarks?

Coverage decreased (-0.09%) to 72.241% when pulling 56c3e2c94381eddc118e39218fc57176965fc4a8 on philpep:benchmark-name into cfe3d3e41cdc9ad44973ce0012e3ac021bb40369 on spacetelescope:master.

Coverage decreased (-0.09%) to 72.241% when pulling 3f14e671a1395696b1bf80813b7bd75b4e5d88ee on philpep:benchmark-name into cfe3d3e41cdc9ad44973ce0012e3ac021bb40369 on spacetelescope:master.

Coverage decreased (-0.09%) to 72.241% when pulling 3f14e671a1395696b1bf80813b7bd75b4e5d88ee on philpep:benchmark-name into cfe3d3e41cdc9ad44973ce0012e3ac021bb40369 on spacetelescope:master.

Sorry for the delay.
Pushed new commits with benchmark_name attribute instead of name.
The current implementation of benchmark discovery by name use a generator, so it doesn't always import the whole suite. Nevertheless I re-implemented direct import of benchmark in https://github.com/spacetelescope/asv/pull/484/commits/9fb848ed0796a2cccd0924e4dff2f2e8ff85f40a
I'd prefer to write it shorter but didn't find a way. My opinion is that this is not worth to have this complexity since import of the benchmark suite should be insignificant comparing to the benchmark run. Let me know if you prefer to drop it and I'll update the PR.
Thanks !

The benchmark suite import time can be similar to the benchmark runtime.
For example, for the scipy benchmark suite, it's 0.5 sec vs. ~0.1 sec
per-file. For pandas, it's ~ 1.0 sec total vs. 0.3 sec per-file (both
with hot disk cache here).

Coverage decreased (-0.05%) to 72.283% when pulling 9fb848ed0796a2cccd0924e4dff2f2e8ff85f40a on philpep:benchmark-name into cfe3d3e41cdc9ad44973ce0012e3ac021bb40369 on spacetelescope:master.

Note that the 'benchmarks' package name should be replaced by dirname(root).

Good catch ! I updated the commit.

Coverage decreased (-0.05%) to 72.283% when pulling fe0e2d3d99078fb4bd53b805d7581685d0cab5fc on philpep:benchmark-name into cfe3d3e41cdc9ad44973ce0012e3ac021bb40369 on spacetelescope:master.


Create accessory component

Depends on https://github.com/ncihtan/data-models/pull/348
Closes #345

Confirming that this now passes all checks having merged #347.

LGTM


add pre/post hook to Themis validate

Allow external hooks into Validate for things like request metrics.

LGTM but instead of custom hooks implementation can we use GRPC interceptors for the same purpose as hooks are intended?


Show "lead in item/page" (type "display") prior to each Questionnaire

Add a “lead in page” to each questionnaire with the contents of Questionnaire.description, and perhaps some text around it eg:
"The next set of questions is the PHQ-9, a depression screener".
That might be populated by "The next set of questions is the " + Questionnaire.description.
If the Questionnaire doesn't have the "description" field populated, then don't show this.
For now, have a config in the screener that dictates whether to show it for all questionnaires. We may want to make this more conditional later, eg only include it if the user is a clinician.

@sierramatice  per our convo w/ Emily today

@achen2401  I can start to populating some Questionnaire.description fields.

@achen2401  please aim to have a first version of this implemented in a couple weeks (Nov 1)

@mcjustin will it be okay to just have an introduction page containing the description in each questionnaire, like, for instance, here? That is easier, without any added logic to present needed.

@achen2401  That's probably a fine approach, just one I wasn't aware of. I see that they're using Questionnaire.item with type "display" https://www.hl7.org/fhir/valueset-item-type.html#expansion . I just had a look at the Structured Data Capture IG's section on rendering, but it doesn't really have anything to say about this (the closest thing is perhaps "supportLink" https://hl7.org/fhir/uv/sdc/rendering.html#additional-display-content ).

@sierramatice Will you be able to provide introduction description for each questionnaire?  It is not clear to me from looking at the documentation, https://uwnetid.sharepoint.com/:w:/s/og_sadakresearch/EdDB0d-MUyBKtAVzaFGj5REB4LahDiwsKA65soXUJBK55Q?e=nvEMff,  what that should be for each?

@achen2401  if @sierramatice  wanted to include some simple html tags, is that okay? Can you please add a sample item/page to a new PR using a pattern that she can follow?

@achen2401 I believe I have added intros to all of the assessments!

@sierramatice I added some comments in the PR  Just some minor issues that I think would be good to address.


Prices, end with a € stamp, but should PLN.

PHP Version: 8.3   | Shopware Version: <IP_ADDRESS>  | Affected area / extension: Platform(Default)

Expected behaviour:
When creating a dynamic group of products in the Polish Sales Channel prices that end with a € stamp, and these are prices in PLN.
Actual behaviour:
Creating a dynamic group of products The preview of the group that we save shows for the Tennis Zone store prices that end with a € stamp, while they are in PLN. This is misleading to the user. Please correct it.

How to reproduce:
Just creat a dynamic product group

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-38288
[created from NEXT-38288, comment 495029]


Add explorer enableSwitchToEditorDragAndDrop setting

I often create a copy of a file by drag and drop in explorer to preserve some code that I do not want to lose, but also do not want to commit. When the drag and drop is complete, the copied file is enabled in editor. The enabled file should not switch to the copied version. I am proposing an additional setting to Drag And Drop, as described below.
Explorer: Enable Drag And Drop
Controls whether the explorer should allow to move files and folders via drag and drop.

"explorer.enableDragAndDrop": true

Additional setting for Drag And Drop

Explorer: Enable Drag And Drop Switch To Editor
Controls whether the drag and drop operation should allow to switch to file in editor.
"explorer.enableSwitchToEditorDragAndDrop": true

This is a fair feature request, however we do not have it on our immediate plan. Thus assigning to backlog and we might add this in the future. Thanks


chore: Move all remaining actions into links

The chain+link framework is now used for all the steps in the backup command.
Automation
/test sanity
:mag: Cypress test results

[!WARNING]
Tests have not run on the HEAD fcc016fd1fa0bbe9b4cae2478bf4f7750ee5459d yet
Fri, 29 Nov 2024 06:14:46 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

/build-deploy-preview skip-tests=true


Two persistence.xml in two EJB projects within one EAR don't work

We're in the progress of migrating to Wildfly but it doesn't seem to support our current setup.
I created a repro at https://github.com/Hades32/wildfly-issues
Wildfly doesn't seem to be able to resolve dependencies between modules as soon as there are two persistence.xml's. Despite the (repro) project doesn't even use it (yet). If you remove the persistence.xml's the project works fine.
This was tested with Wildfly 9.0 Final

Hello. Please ask questions like this on forums, https://developer.jboss.org/en/wildfly. For issues we file them in JIRA at https://issues.jboss.org/browse/WFLY/. Thanks!

done https://developer.jboss.org/thread/261445


Fix error in downlevel text

On a down-level system such as Windows 7, GetLastError returns ERROR_INVALID_PARAMETER (87) rather than STATUS_INVALID_PARAMETER (0xC000000D).  STATUS_INVALID_PARAMETER is a kernel error constant.
Fixing this to save others wasting the hour I just wasted :)

Docs Build status updates of commit 23a6220:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/console-virtual-terminal-sequences.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

I haven't approved this yet because I need to find the time to go trace the source code backward in time and find where this changed and probably list both errors.


Address Translation & Memory Model

The address translation is known to be the bottleneck of most workloads in the BPF VM at the moment.
Ideas to improve the situation:

Hoist address translation from loop bodies outside, so that they happen less frequently. This would require the static analyzer to be reliable and secure in order to detect loops. Also an efficient way to bypass the translated results into the body and check if they are still in bounds during the execution would be needed. Finally, a fallback in case the boundcheck fails is required too.
Manually optimize the address translation on x86 instruction level to reduce redundant boundchecks and the need for register spilling. This will probably not yield much, maybe a few percent improvement.
Change the memory model to something simpler, e.g. what WASM is doing. This would be the most radical change, but also the one which might help the most.

Has there been any profiling done on what fraction of time RBPF spends in address translation for some benchmark?  (not the percentage of memory access instructions in a specific program, but actual wall-clock time spend in address translation code of the RBPF relative to the whole program execution time)
What would be the maximum theoretical improvement if address translation overhead were 0?

bench_jit_vs_interpreter_address_translation: 1016299 ns per loop block
bench_jit_vs_interpreter_empty_for_loop: 96902 ns per loop block
Each loop block is 65536 iterations.
So we are speaking about 10x possible improvement.
Timing according to this recent CI benchmark run.

I think this is not exactly correct a comparison, because the first loop does a load from memory and address translation, but the second loop doesn't do address translation, neither does it do a load from memory. It would be good to measure the time it takes to do the address translation and then get the percentage of the whole execution time spent in address translation, that would show how much running time would improve if address translation overhead were 0. As shown, your 10x improvement includes time not performing a load operation on every loop iteration.

It does not matter that much if you subtract the rest of the loop:
1016299 / 96902 ~ 10.5
(1016299 - 96902) / 96902 ~ 9.5
I disabled the emission of x86 load instructions in the JIT, so that only the address translation happens.
I tested it a few times with and without load instructions and the result remains the same (within the variance of the benchmark). Probably because it stays in the cache.

This comparison is not very useful.  If you compare a program that does only load instructions in this way, your speedup will be infinite, because without address translation the program's running time will approach 0.  This is why I think it is important to take characteristic benchmarks representable of on-chain programs and estimate the expected speedup on such benchmarks.

except maybe it can be used as a baseline for time it takes to execute a single address translation, roughly 1 ms / 65536 or less than 16 ns.

This is why I think it is important to take characteristic benchmarks representable of on-chain programs

Sure, but how do you measure the time spent in address translation and nothing else, and without changing the timing of what you measure? These benchmarks here are far from perfect but still allow a rough estimate of the ball park we are talking about.

This is why I think it is important to take characteristic benchmarks representable of on-chain programs

Sure, but how do you measure the time spent in address translation and nothing else, and without changing the timing of what you measure?

You instrument the address translation code and measure the time it takes. You measure the overhead it takes to measure time and subtract that, if you want to be utterly precise, although in this case instrumentation overhead may be negligible.

These benchmarks here are far from perfect but still allow a rough estimate of the ball park we are talking about.

Rough estimate of what exactly? Of one load on 4 arithmetic instructions? Yes, like I said it may be taken as a baseline for the time it takes to do a single address translation.  If for example 90% of your address translations happen for addresses that were previously translated, then simple software caching of translated addresses could speed up the address translation dramatically. It's important to know what you're optimizing and what the potential benefits are...

My worry is that the measured addr translation overhead of 10-16ns (I've measured this locally too) doesn't explain the measured median CU/us of Serum on mainnet, corresponding to about 150ns/opcode.
The median across programs of 20ns per opcode (50CU/us), which probably are not dominated by loads and stores/addr translation...

@jon-chuang Keep in mind that this was measuring a tight loop with all loads always staying in cache. This is why I am working on a better benchmark solution here: https://github.com/solana-labs/rbpf/pull/197
Actually, you could also run some of your own by checking out that branch and adding:
emit_stopwatch(jit, true)?; here
and
?; emit_stopwatch(jit, false) here

@Lichtso
To follow up on the results produced here: https://github.com/solana-labs/solana/pull/17393#issuecomment-875262123
Here is the result of tracing and counting the opcodes in trace.out from bpf-ristretto with the following inputs:
../../solana/target/release/rbpf-cli --use jit  --input input.json target/deploy/ec_math.so --trace
Program input:
accounts []
insndata [1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 236, 255, 255, 255, 255, 255, 7, 0, 255, 255, 255, 255, 255, 255, 7, 0, 255, 255, 255, 255, 255, 255, 7, 0, 255, 255, 255, 255, 255, 255, 7, 0, 255, 255, 255, 255, 255, 255, 7, 0]

where the insndata corresponds to instruction::field_mul(two, minus_one), performing the multiplication 1000 times.

trace:
and 6016
call 26039
stx 97494
ldx 116495
lsh 130027
mul 155007
rsh 231033
add 249108
mov 361187
Total: 1340351
Total isn: 1455581

The time taken is 2839670ns (2839 ns/op). This is a slowdown over native (20ns/op) of approximately 140x.
Assuming a 21ns ldx/stx time and a 4.0GHz CPU, we obtain the following slowdown over zero-overhead ldx/stx, assuming IPC = 2:

(97494 + 116495) * 21 * 4 * 2 / 1455581 = 24.

The slowdown from a lightweight ldx/stx of 8 cycles is

(97494 + 116495) * 8 * 2 / 1455581 = 2.35.

This suggests a 10x performance boost is possible.

Btw, this is the CU/us, which is unbelievably high compared to mainnet's 50CU/us median:
546.389264264
This leads me to believe that somehow, the VM running on mainnet is not particularly optimised...

What does the time measurement of mainnet include? Just VM execution or account serialization & deserialization as well?
Because the copying of accounts is also known to be a huge time sink.

The data is obtained from: https://github.com/solana-labs/solana/pull/16984/files
Here is what is stated:

These numbers only include program execution (message processor, vm
setup/takedown, parameter ser/de) but do not include account loading/storing

So it may not be an accurate reflection.

If you want to compare the standalone with the one deployed on mainnet then you should only use the execution time and explicitly exclude parameter ser/de. That might also explain where the "missing" performance gap comes from.

Here is the result of using the flattened, non-rust-call version of address translation, alongside turning off stack frame gaps, immediate sanitisation:
865838ns, or 865ns per field mul
That's a 3.28x improvement just by removing immediate sanitisation.


[FEATURE] Deploy Visualization EC2 Instance

Is your feature request related to a problem? Please describe.
We've added an module for visualization ROS data on EC2 using NiceDCV. Add this to the ros-image-demo manifest to showcase how to configure and deploy the module
Describe the solution you'd like

Add manifest to deploy the modules/visualization/dev-instance module

https://github.com/awslabs/autonomous-driving-data-framework/pull/143


Release v0.8.0

This issue is intended to track the release of version 0.8.0 of the python-control toolbox.  All of the changes that go along with this release are now done, so I am planning to use this issue to track the steps in actually getting the release out the door (since the last time we did one was a couple of years back!).
I've put an outline of what I think the steps are for generating a release on the wiki under release instructions.  Will start working through those and post progress here.  (I'm going to be doing this off and on in the coming week or so => might take a while to get things out the door.  If anyone wants to help, just let me know!).

Question (for those in the know): should the tag for this release be 0.8.0 or v0.8.0?  It seems like the latter is what I see for other packages, but not sure if that will mess up the make_version.py script and/or other infrastructure.

Another question: how does it work to use the github releases mechanism.  If I create a new release on github, does it automatically create an annotated tag?  Or should I create the tag by hand (once I figure out what to call it) and then create the release using the tag?  The github documentation on releases is pretty sparse.

I typically create a tag locally for a release, push the tag to github, and then make the Github "release".

As for whether to name the tags 0.8.0 or v0.8.0, I don't think it makes much difference, though of course it would be good to pick something and be consistent.  For instance, it looks like scikit-learn uses 0.8.0, while scikit-image and pytorch use v0.8.0.  I would probably suggest sticking with 0.8.0, since that's what the last release used (long ago), and that's what make_version.py assumes, but it is not a strong preference.

Anything still blocking 0.8.0?  Are we going to do a Slycot release first?

A couple of things I think we should do:

Release slycot 0.3.2, containing the updated Travis CI build + updated README.  This just requires doing a couple of the merges and then rebuilding via conda-forge.
Review PR #196 and PR #198. It would be useful to have someone do a quick check on these just to make sure I didn't miss anything.
Create the 0.8.0 tag on python-control
Once that is done, we can start rolling out the changes on conda-forge, readthedocs, etc using the (proposed) release instructions.

OK, I just checked some things locally.
For the new slycot version, PR Slycot/#24 and Slycot/#25 seem to be compatible, Slycot tests with Slycot/#25 are OK with openblas. I propose using the openblas 0.3.0 from conda-forge, since that is available across the board for Mac OSX, Windows and Linux.
Slycot/#22 probably needs a small update, we need to add a remark that for anaconda installs people should use the conda-supplied compiler, instead of installing/using external compilers.
With that, these three PR's can be merged,
As for python control, we have the combined Slycot/control issue with the Travis build failures. I think the combination of Slycot/#25 and #206 fixes that. That takes a leap of faith, since the checks are failing, but I think it is better to forge ahead and fix things, than to spend our time on finding a path that leads to clean Tavis builds and checks.
What do you think?

Slycot v0.3.3 is now completed, so moving on to next steps:

Review open issues and tag any that should be resolved in v0.8.0 release
Review open pull requests and tag any that should be integrated into v0.8.0 release
Create the 0.8.0 tag on python-control.  Once that is done, we can start rolling out the changes on conda-forge, readthedocs, etc using the (proposed) release instructions.

I've merged all of the PR's that I think belong in version 0.8.0, so I think this version is pretty much ready for release.  The last remaining item (I think) is to have slycot 0.3.3 created on conda-forge.

Issue #217 resolved in PR #220. Starting to work on final release.


[fixes #1444] Model.findOrCreate() should send back an object without {fetch: true} meta

Waterline version: 0.13.0-3
Node version: v7.5.0
NPM version: 4.1.2
Operating system: macOS 10.12.3 (16D32)

Hello,
I'm trying to use latest version of waterline with SailsJS 1.0.0-22, and found a problem with Model.findOrCreate(). It behaves the same as Model.create() rather than Model.find(), i.e it requires {fetch: true} meta to return a created/found object.
Model.findOrCreate({ type: 'dog' }, { name: 'Pretend pet type', type: 'dog' }).then(console.log);
// undefined

Model.findOrCreate({ type: 'dog' }, { name: 'Pretend pet type', type: 'dog' }).meta({fetch: true}).then(console.log);
// { id: 1, name: 'Pretend pet type', type: 'dog' }

ok, fixed!

That's weird, because tests pass on my local env.

That is because the Object.assign isn't available in the older version of Node.js

Oh right, I'll change it to something else. Thanks!

I think that is time to drop some version, but is just my opinion :)

New node for new sails ;)

@mrded good catch. We changed the behavior of create mid-stream and I forgot about the findOrCreate method.

Looks like you have changed it already.

@mrded crap sorry about that, bad timing-- I just saw this.  For the purposes of tracking this for the future, we could still get this merged if you'd like

It's ok. I would like to get it merged, let me solve conflicts first :)

@mrded and thanks for bringing it to our attention!!  Only way I even knew about this was because @particlebanana said it out loud- I just didn't realize there was already a PR

@mikermcneil can you please check, what's a problem with tests?

Will it be possible to merge it now? Otherwise it will never be merged :(
Thanks

@mrded totally-- I'm in there right now plugging in the optimized Deferred (parley) and I was actually just thinking about this and potential conflicts.  Thanks for the reminder!

Awesome! Thanks

Thank you for merging. Unfortunately you can see none of my changes in here https://github.com/balderdashy/waterline/commits/master/lib/waterline/methods/find-or-create.js
Looks like you merged my changes as empty commit. Anyway, problem is solved, and it's too late to complain.
Thanks!

@mrded hmm weird... I definitely merged this branch locally, fixed the conflict and then committed-- so maybe the commits aren't included in the commit history of the master branch because there was a merge conflict?  Git is a source of endless mysteries.  But regardless, it's in place now.
Thanks again for your help!


Polymorphic memory resource

This branch will add the ability to have polymorphic memory allocation using the warden. This should allow for some very fast allocators to be used for the coroutine frames (and possibly other data).
A couple of benchmarks are included that should help show the performance of various allocation strategies and warden implementations.

There's only a single benchmark HTTP server, but it turns out we don't yet have the allocator implementations needed to see that it runs faster with them -- this work will follow, but for now it's enough that we have support for the PMR allocators.


[5.2] \Log::info() and info() triggered to many times

Hello,
I have an almost fresh install of lararavel 5.2.
When I add a \Log::info() or an info() method at routes.php it logs 5 times in every request.
We have discussed it in Larachat but nobody seems to find an answer to this problem.
Thank you.

Sorry, but this is an application bug rather than a framework bug, and thus we cannot process it here.

@GrahamCampbell in what repo should I open it? Thank you!

I can't verify this as a bug in our code, sorry. I'd suggest you seek advice on the forums on how to fix your app code.


ERROR: No database is allowed for your csv upload

I'm running Superset within a Docker container (tylerfowler version) and on startup I get the message in the subject line, and as per the message I cannot upload a CSV. Here are the container logs. Any thoughts?
Checking for existing Superset config...
No Superset config found, creating from environment
Checking for docker-entrypoint
Running first time setup for Superset
Creating admin user admin
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
Loaded your LOCAL configuration at [/superset/superset_config.py]
Recognized Database Authentications.
Admin User admin created.
/usr/local/lib/python3.8/site-packages/flask_caching/__init__.py:188: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
  warnings.warn(
Initializing database
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
/usr/local/lib/python3.8/site-packages/flask_caching/__init__.py:188: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
  warnings.warn(
INFO  [alembic.runtime.migration] Context impl SQLiteImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade  -> 4e6a06bad7a8, Init
INFO  [alembic.runtime.migration] Running upgrade 4e6a06bad7a8 -> 5a7bad26f2a7, empty message
INFO  [alembic.runtime.migration] Running upgrade 5a7bad26f2a7 -> 1e2841a4128, empty message
INFO  [alembic.runtime.migration] Running upgrade 1e2841a4128 -> 2929af7925ed, TZ offsets in data sources
INFO  [alembic.runtime.migration] Running upgrade 2929af7925ed -> 289ce07647b, Add encrypted password field
INFO  [alembic.runtime.migration] Running upgrade 289ce07647b -> 1a48a5411020, adding slug to dash
INFO  [alembic.runtime.migration] Running upgrade 1a48a5411020 -> 315b3f4da9b0, adding log model
INFO  [alembic.runtime.migration] Running upgrade 315b3f4da9b0 -> 55179c7f25c7, sqla_descr
INFO  [alembic.runtime.migration] Running upgrade 55179c7f25c7 -> 12d55656cbca, is_featured
/usr/local/lib/python3.8/site-packages/alembic/ddl/sqlite.py:40: UserWarning: Skipping unsupported ALTER for creation of implicit constraintPlease refer to the batch mode feature which allows for SQLite migrations using a copy-and-move strategy.
  util.warn(
INFO  [alembic.runtime.migration] Running upgrade 12d55656cbca -> 2591d77e9831, user_id
INFO  [alembic.runtime.migration] Running upgrade 2591d77e9831 -> 8e80a26a31db, empty message
INFO  [alembic.runtime.migration] Running upgrade 8e80a26a31db -> 7dbf98566af7, empty message
INFO  [alembic.runtime.migration] Running upgrade 7dbf98566af7 -> 43df8de3a5f4, empty message
INFO  [alembic.runtime.migration] Running upgrade 43df8de3a5f4 -> d827694c7555, css templates
INFO  [alembic.runtime.migration] Running upgrade d827694c7555 -><PHONE_NUMBER>35, log more
INFO  [alembic.runtime.migration] Running upgrade<PHONE_NUMBER>35 -> 18e88e1cc004, making audit nullable
INFO  [alembic.runtime.migration] Running upgrade 18e88e1cc004 -> 836c0bf75904, cache_timeouts
INFO  [alembic.runtime.migration] Running upgrade 18e88e1cc004 -> a2d606a761d9, adding favstar model
INFO  [alembic.runtime.migration] Running upgrade a2d606a761d9, 836c0bf75904 -> d2424a248d63, empty message
INFO  [alembic.runtime.migration] Running upgrade d2424a248d63 -> 763d4b211ec9, fixing audit fk
INFO  [alembic.runtime.migration] Running upgrade d2424a248d63 -> 1d2ddd543133, log dt
INFO  [alembic.runtime.migration] Running upgrade 1d2ddd543133, 763d4b211ec9 -> fee7b758c130, empty message
INFO  [alembic.runtime.migration] Running upgrade fee7b758c130 -> 867bf4f117f9, Adding extra field to Database model
INFO  [alembic.runtime.migration] Running upgrade 867bf4f117f9 -> bb51420eaf83, add schema to table model
INFO  [alembic.runtime.migration] Running upgrade bb51420eaf83 -> b4456560d4f3, change_table_unique_constraint
INFO  [alembic.runtime.migration] Running upgrade b4456560d4f3 -> 4fa88fe24e94, owners_many_to_many
INFO  [alembic.runtime.migration] Running upgrade 4fa88fe24e94 -> c3a8f8611885, Materializing permission
INFO  [alembic.runtime.migration] Running upgrade c3a8f8611885 -> f0fbf6129e13, Adding verbose_name to tablecolumn
INFO  [alembic.runtime.migration] Running upgrade f0fbf6129e13 -> 956a063c52b3, adjusting key length
INFO  [alembic.runtime.migration] Running upgrade 956a063c52b3 -> 1226819ee0e3, Fix wrong constraint on table columns
INFO  [alembic.runtime.migration] Running upgrade 1226819ee0e3 -> d8bc074f7aad, Add new field 'is_restricted' to SqlMetric and DruidMetric
INFO  [alembic.runtime.migration] Running upgrade d8bc074f7aad -> 27ae655e4247, Make creator owners
INFO  [alembic.runtime.migration] Running upgrade 27ae655e4247 -> 960c69cb1f5b, add dttm_format related fields in table_columns
INFO  [alembic.runtime.migration] Running upgrade 960c69cb1f5b -> f162a1dea4c4, d3format_by_metric
INFO  [alembic.runtime.migration] Running upgrade f162a1dea4c4 -> ad82a75afd82, Update models to support storing the queries.
INFO  [alembic.runtime.migration] Running upgrade ad82a75afd82 -> 3c3ffe173e4f, add_sql_string_to_table
INFO  [alembic.runtime.migration] Running upgrade 3c3ffe173e4f -> 41f6a59a61f2, database options for sql lab
INFO  [alembic.runtime.migration] Running upgrade 41f6a59a61f2 -> 4500485bde7d, allow_run_sync_async
INFO  [alembic.runtime.migration] Running upgrade 4500485bde7d -> 65903709c321, allow_dml
INFO  [alembic.runtime.migration] Running upgrade 41f6a59a61f2 -> 33d996bcc382, update slice model
INFO  [alembic.runtime.migration] Running upgrade 33d996bcc382, 65903709c321 -> b347b202819b, empty message
INFO  [alembic.runtime.migration] Running upgrade b347b202819b -> 5e4a03ef0bf0, Add access_request table to manage requests to access datastores.
INFO  [alembic.runtime.migration] Running upgrade 5e4a03ef0bf0 -> eca4694defa7, sqllab_setting_defaults
INFO  [alembic.runtime.migration] Running upgrade eca4694defa7 -> ab3d66c4246e, add_cache_timeout_to_druid_cluster
INFO  [alembic.runtime.migration] Running upgrade eca4694defa7 -> 3b626e2a6783, Sync DB with the models.py.
WARNI [root] Constraint must have a name
INFO  [alembic.runtime.migration] Running upgrade 3b626e2a6783, ab3d66c4246e -> ef8843b41dac, empty message
INFO  [alembic.runtime.migration] Running upgrade ef8843b41dac -> b46fa1b0b39e, Add json_metadata to the tables table.
INFO  [alembic.runtime.migration] Running upgrade b46fa1b0b39e -> 7e3ddad2a00b, results_key to query
INFO  [alembic.runtime.migration] Running upgrade 7e3ddad2a00b -> ad4d656d92bc, Add avg() to default metrics
INFO  [alembic.runtime.migration] Running upgrade ad4d656d92bc -> c611f2b591b8, dim_spec
INFO  [alembic.runtime.migration] Running upgrade c611f2b591b8 -> e46f2d27a08e, materialize perms
INFO  [alembic.runtime.migration] Running upgrade e46f2d27a08e -> f1f2d4af5b90, Enable Filter Select
INFO  [alembic.runtime.migration] Running upgrade e46f2d27a08e -> 525c854f0005, log_this_plus
INFO  [alembic.runtime.migration] Running upgrade 525c854f0005, f1f2d4af5b90 -> 6414e83d82b7, empty message
INFO  [alembic.runtime.migration] Running upgrade 6414e83d82b7 -> 1296d28ec131, Adds params to the datasource (druid) table
INFO  [alembic.runtime.migration] Running upgrade 1296d28ec131 -> f18570e03440, Add index on the result key to the query table.
INFO  [alembic.runtime.migration] Running upgrade f18570e03440 -> bcf3126872fc, Add keyvalue table
INFO  [alembic.runtime.migration] Running upgrade f18570e03440 -> db0c65b146bd, update_slice_model_json
INFO  [alembic.runtime.migration] Running upgrade db0c65b146bd -> a99f2f7c195a, rewriting url from shortner with new format
INFO  [alembic.runtime.migration] Running upgrade a99f2f7c195a, bcf3126872fc -> d6db5a5cdb5d, empty message
INFO  [alembic.runtime.migration] Running upgrade d6db5a5cdb5d -> b318dfe5fb6c, adding verbose_name to druid column
INFO  [alembic.runtime.migration] Running upgrade d6db5a5cdb5d -> 732f1c06bcbf, add fetch values predicate
INFO  [alembic.runtime.migration] Running upgrade 732f1c06bcbf, b318dfe5fb6c -> ea033256294a, empty message
INFO  [alembic.runtime.migration] Running upgrade b318dfe5fb6c -> db527d8c4c78, Add verbose name to DruidCluster and Database
INFO  [alembic.runtime.migration] Running upgrade db527d8c4c78, ea033256294a -> 979c03af3341, empty message
INFO  [alembic.runtime.migration] Running upgrade 979c03af3341 -> a6c18f869a4e, query.start_running_time
INFO  [alembic.runtime.migration] Running upgrade a6c18f869a4e -> 2fcdcb35e487, saved_queries
INFO  [alembic.runtime.migration] Running upgrade 2fcdcb35e487 -> a65458420354, add_result_backend_time_logging
INFO  [alembic.runtime.migration] Running upgrade a65458420354 -> ca69c70ec99b, tracking_url
INFO  [alembic.runtime.migration] Running upgrade ca69c70ec99b -> a9c47e2c1547, add impersonate_user to dbs
INFO  [alembic.runtime.migration] Running upgrade ca69c70ec99b -> ddd6ebdd853b, annotations
INFO  [alembic.runtime.migration] Running upgrade a9c47e2c1547, ddd6ebdd853b -> d39b1e37131d, empty message
INFO  [alembic.runtime.migration] Running upgrade ca69c70ec99b -> 19a814813610, Adding metric warning_text
INFO  [alembic.runtime.migration] Running upgrade 19a814813610, a9c47e2c1547 -> 472d2f73dfd4, empty message
INFO  [alembic.runtime.migration] Running upgrade 472d2f73dfd4, d39b1e37131d -> f959a6652acd, empty message
INFO  [alembic.runtime.migration] Running upgrade f959a6652acd -> 4736ec66ce19, empty message
/usr/local/lib/python3.8/site-packages/sqlalchemy/dialects/sqlite/base.py:1920: SAWarning: WARNING: SQL-parsed foreign key constraint '('datasource_name', 'datasources', 'datasource_name')' could not be located in PRAGMA foreign_keys for table metrics
  util.warn(
INFO  [alembic.runtime.migration] Running upgrade 4736ec66ce19 -> 67a6ac9b727b, update_spatial_params
INFO  [alembic.runtime.migration] Running upgrade 67a6ac9b727b -> 21e88bc06c02
INFO  [alembic.runtime.migration] Running upgrade 21e88bc06c02 -> e866bd2d4976, smaller_grid
Revision ID: e866bd2d4976
Revises: 21e88bc06c02
Create Date: 2018-02-13 08:07:40.766277
INFO  [alembic.runtime.migration] Running upgrade e866bd2d4976 -> e68c4473c581, allow_multi_schema_metadata_fetch
INFO  [alembic.runtime.migration] Running upgrade e68c4473c581 -> f231d82b9b26, empty message
INFO  [alembic.runtime.migration] Running upgrade f231d82b9b26 -> bf706ae5eb46, cal_heatmap_metric_to_metrics
INFO  [alembic.runtime.migration] Running upgrade f231d82b9b26 -> 30bb17c0dc76, empty message
INFO  [alembic.runtime.migration] Running upgrade 30bb17c0dc76, bf706ae5eb46 -> c9495751e314, empty message
INFO  [alembic.runtime.migration] Running upgrade f231d82b9b26 -><PHONE_NUMBER>29, is_sqllab_view
INFO  [alembic.runtime.migration] Running upgrade<PHONE_NUMBER>29, c9495751e314 -> 5ccf602336a0, empty message
INFO  [alembic.runtime.migration] Running upgrade 5ccf602336a0 -> e502db2af7be, add template_params to tables
INFO  [alembic.runtime.migration] Running upgrade e502db2af7be -> c5756bec8b47, Time grain SQLA
INFO  [alembic.runtime.migration] Running upgrade c5756bec8b47 -> afb7730f6a9c, remove empty filters
INFO  [alembic.runtime.migration] Running upgrade afb7730f6a9c -> 80a67c5192fa, single pie chart metric
INFO  [alembic.runtime.migration] Running upgrade 80a67c5192fa -> bddc498dd179, adhoc filters
INFO  [alembic.runtime.migration] Running upgrade bddc498dd179 -> 3dda56f1c4c6, Migrate num_period_compare and period_ratio_type
INFO  [alembic.runtime.migration] Running upgrade 3dda56f1c4c6 -> 1d9e835a84f9, empty message
INFO  [alembic.runtime.migration] Running upgrade bddc498dd179 -> 4451805bbaa1, remove double percents
INFO  [alembic.runtime.migration] Running upgrade 4451805bbaa1, 1d9e835a84f9 -> 705732c70154, empty message
INFO  [alembic.runtime.migration] Running upgrade 4451805bbaa1, 1d9e835a84f9 -> fc480c87706c, empty message
INFO  [alembic.runtime.migration] Running upgrade fc480c87706c -> bebcf3fed1fe, Migrate dashboard position_json data from V1 to V2
INFO  [alembic.runtime.migration] Running upgrade bebcf3fed1fe, 705732c70154 -> ec1f88a35cc6, empty message
INFO  [alembic.runtime.migration] Running upgrade 4451805bbaa1, 1d9e835a84f9 -> e3970889f38e, empty message
INFO  [alembic.runtime.migration] Running upgrade 705732c70154, e3970889f38e -> 46ba6aaaac97, empty message
INFO  [alembic.runtime.migration] Running upgrade 46ba6aaaac97, ec1f88a35cc6 -> c18bd4186f15, empty message
INFO  [alembic.runtime.migration] Running upgrade c18bd4186f15 -> 7fcdcde0761c, Reduce position_json size by remove extra space and component id prefix
INFO  [alembic.runtime.migration] Running upgrade 7fcdcde0761c -> 0c5070e96b57, add user attributes table
INFO  [alembic.runtime.migration] Running upgrade 0c5070e96b57 -> 1a1d627ebd8e, position_json
INFO  [alembic.runtime.migration] Running upgrade 1a1d627ebd8e -> 55e910a74826, add_metadata_column_to_annotation_model.py
INFO  [alembic.runtime.migration] Running upgrade 55e910a74826 -> 4ce8df208545, empty message
INFO  [alembic.runtime.migration] Running upgrade 4ce8df208545 -> 46f444d8b9b7, remove_coordinator_from_druid_cluster_model.py
INFO  [alembic.runtime.migration] Running upgrade 46f444d8b9b7 -> a61b40f9f57f, remove allow_run_sync
INFO  [alembic.runtime.migration] Running upgrade a61b40f9f57f -> 6c7537a6004a, models for email reports
INFO  [alembic.runtime.migration] Running upgrade 6c7537a6004a -> 3e1b21cd94a4, change_owner_to_m2m_relation_on_datasources.py
INFO  [alembic.runtime.migration] Running upgrade 6c7537a6004a -> cefabc8f7d38, Increase size of name column in ab_view_menu
INFO  [alembic.runtime.migration] Running upgrade 55e910a74826 -> 0b1f1ab473c0, Add extra column to Query
INFO  [alembic.runtime.migration] Running upgrade 0b1f1ab473c0, cefabc8f7d38, 3e1b21cd94a4 -> de021a1ca60d, empty message
INFO  [alembic.runtime.migration] Running upgrade de021a1ca60d -> fb13d49b72f9, better_filters
INFO  [alembic.runtime.migration] Running upgrade fb13d49b72f9 -> a33a03f16c4a, Add extra column to SavedQuery
INFO  [alembic.runtime.migration] Running upgrade 4451805bbaa1, 1d9e835a84f9 -> c829ff0b37d0, empty message
INFO  [alembic.runtime.migration] Running upgrade c829ff0b37d0 -> 7467e77870e4, remove_aggs
INFO  [alembic.runtime.migration] Running upgrade 7467e77870e4, de021a1ca60d -> fbd55e0f83eb, empty message
INFO  [alembic.runtime.migration] Running upgrade fbd55e0f83eb, fb13d49b72f9 -> 8b70aa3d0f87, empty message
INFO  [alembic.runtime.migration] Running upgrade 8b70aa3d0f87, a33a03f16c4a -> 18dc26817ad2, empty message
INFO  [alembic.runtime.migration] Running upgrade 18dc26817ad2 -> c617da68de7d, form nullable
INFO  [alembic.runtime.migration] Running upgrade c617da68de7d -> c82ee8a39623, Add implicit tags
INFO  [alembic.runtime.migration] Running upgrade 18dc26817ad2 -> e553e78e90c5, add_druid_auth_py.py
INFO  [alembic.runtime.migration] Running upgrade e553e78e90c5, c82ee8a39623 -> 45e7da7cfeba, empty message
INFO  [alembic.runtime.migration] Running upgrade 45e7da7cfeba -> 80aa3f04bc82, Add Parent ids in dashboard layout metadata
INFO  [alembic.runtime.migration] Running upgrade 80aa3f04bc82 -> d94d33dbe938, form strip
INFO  [alembic.runtime.migration] Running upgrade d94d33dbe938 -> 937d04c16b64, update datasources
INFO  [alembic.runtime.migration] Running upgrade 937d04c16b64 -> 7f2635b51f5d, update base columns
INFO  [alembic.runtime.migration] Running upgrade 7f2635b51f5d -> e9df189e5c7e, update base metrics
INFO  [alembic.runtime.migration] Running upgrade e9df189e5c7e -> afc69274c25a, update the sql, select_sql, and executed_sql columns in the
   query table in mysql dbs to be long text columns
INFO  [alembic.runtime.migration] Running upgrade afc69274c25a -> d7c1a0d6f2da, Remove limit used from query model
INFO  [alembic.runtime.migration] Running upgrade d7c1a0d6f2da -> ab8c66efdd01, resample
INFO  [alembic.runtime.migration] Running upgrade ab8c66efdd01 -> b4a38aa87893, deprecate database expression
INFO  [alembic.runtime.migration] Running upgrade b4a38aa87893 -> d6ffdf31bdd4, Add published column to dashboards
INFO  [alembic.runtime.migration] Running upgrade d6ffdf31bdd4 -><PHONE_NUMBER>82, Remove duplicated entries in dashboard_slices table and add unique constraint
INFO  [alembic.runtime.migration] Running upgrade<PHONE_NUMBER>82 -> def97f26fdfb, Add index to tagged_object
INFO  [alembic.runtime.migration] Running upgrade def97f26fdfb -> 11c737c17cc6, deprecate_restricted_metrics
INFO  [alembic.runtime.migration] Running upgrade 11c737c17cc6 -> 258b5280a45e, form strip leading and trailing whitespace
INFO  [alembic.runtime.migration] Running upgrade 258b5280a45e -> 1495eb914ad3, time range
INFO  [alembic.runtime.migration] Running upgrade 1495eb914ad3 -> b6fa807eac07, make_names_non_nullable
INFO  [alembic.runtime.migration] Running upgrade b6fa807eac07 -> cca2f5d568c8, add encrypted_extra to dbs
INFO  [alembic.runtime.migration] Running upgrade cca2f5d568c8 -> c2acd2cf3df2, alter type of dbs encrypted_extra
INFO  [alembic.runtime.migration] Running upgrade c2acd2cf3df2 -> 78ee127d0d1d, reconvert legacy filters into adhoc
INFO  [alembic.runtime.migration] Running upgrade 78ee127d0d1d -> db4b49eb0782, Add tables for SQL Lab state
INFO  [alembic.runtime.migration] Running upgrade db4b49eb0782 -> 5afa9079866a, serialize_schema_permissions.py
INFO  [alembic.runtime.migration] Running upgrade 5afa9079866a -> 89115a40e8ea, Change table schema description to long text
INFO  [alembic.runtime.migration] Running upgrade 89115a40e8ea -> 817e1c9b09d0, add_not_null_to_dbs_sqlalchemy_url
INFO  [alembic.runtime.migration] Running upgrade 817e1c9b09d0 -> e96dbf2cfef0, datasource_cluster_fk
INFO  [alembic.runtime.migration] Running upgrade e96dbf2cfef0 -> 3325d4caccc8, empty message
INFO  [alembic.runtime.migration] Running upgrade 3325d4caccc8 -> 0a6f12f60c73, add_role_level_security
INFO  [alembic.runtime.migration] Running upgrade 0a6f12f60c73 -> 72428d1ea401, Add tmp_schema_name to the query object.
INFO  [alembic.runtime.migration] Running upgrade 72428d1ea401 -> b5998378c225, add certificate to dbs
INFO  [alembic.runtime.migration] Running upgrade b5998378c225 -> f9a30386bd74, cleanup_time_grainularity
Loaded your LOCAL configuration at [/superset/superset_config.py]
Creating default roles and permissions
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
/usr/local/lib/python3.8/site-packages/flask_caching/__init__.py:188: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
  warnings.warn(
Creating database reference for examples
INFO:superset.utils.core:Creating database reference for examples
Syncing role definition
INFO:superset.security.manager:Syncing role definition
Syncing Admin perms
INFO:superset.security.manager:Syncing Admin perms
Syncing Alpha perms
INFO:superset.security.manager:Syncing Alpha perms
Syncing Gamma perms
INFO:superset.security.manager:Syncing Gamma perms
Syncing granter perms
INFO:superset.security.manager:Syncing granter perms
Syncing sql_lab perms
INFO:superset.security.manager:Syncing sql_lab perms
Fetching a set of all perms to lookup which ones are missing
INFO:superset.security.manager:Fetching a set of all perms to lookup which ones are missing
Creating missing datasource permissions.
INFO:superset.security.manager:Creating missing datasource permissions.
Creating missing database permissions.
INFO:superset.security.manager:Creating missing database permissions.
Creating missing metrics permissions
INFO:superset.security.manager:Creating missing metrics permissions
Cleaning faulty perms
INFO:superset.security.manager:Cleaning faulty perms
Loaded your LOCAL configuration at [/superset/superset_config.py]
Starting up Superset gunicorn server
[2020-07-13 18:17:54 +0000] [21] [INFO] Starting gunicorn 20.0.4
[2020-07-13 18:17:54 +0000] [21] [INFO] Listening at: http://<IP_ADDRESS>:8088 (21)
[2020-07-13 18:17:54 +0000] [21] [INFO] Using worker: gevent
[2020-07-13 18:17:54 +0000] [23] [INFO] Booting worker with pid: 23
[2020-07-13 18:17:54 +0000] [24] [INFO] Booting worker with pid: 24
[2020-07-13 18:17:55 +0000] [25] [INFO] Booting worker with pid: 25
[2020-07-13 18:17:55 +0000] [26] [INFO] Booting worker with pid: 26
[2020-07-13 18:17:55 +0000] [27] [INFO] Booting worker with pid: 27
[2020-07-13 18:17:55 +0000] [28] [INFO] Booting worker with pid: 28
[2020-07-13 18:17:55 +0000] [29] [INFO] Booting worker with pid: 29
[2020-07-13 18:17:55 +0000] [30] [INFO] Booting worker with pid: 30
[2020-07-13 18:17:55 +0000] [31] [INFO] Booting worker with pid: 31
[2020-07-13 18:17:55 +0000] [32] [INFO] Booting worker with pid: 32
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
(base) PS H:\>

Does the databse have "Allow CSV Upload" checked?

Does the databse have "Allow CSV Upload" checked?

Hi, if I try to edit database settings to allow for csv uploads I get this message:
ERROR: SQLite database cannot be used as a data source for security reasons.

Hello, have you tried what was suggested in #9748 ?

Superset is going to drop support for SQLLite, for now you can override this by setting PREVENT_UNSAFE_DB_CONNECTIONS = False on the config

For those who comes here thru Google and is starting with Apache Superset (like myself), checkout "Data -> Databases -> YOUR_DB" then "Edit".
Verify if Allow Data Upload is set in Extra tab, along with properly permissions in "SQL Lab Settings".

Hi, I've the same problem and I made the process sugest by Ifernandes but I've an other error which appears : An error occurred when searching for databases: "sqlalchemy_uri":["The SQLite database cannot be used as a data source for security reasons."]
Do you have any idea ? (Sorry for my english)


IBM.com style model for conversational experiences

This story is to capture the conversational model updates coming from the UMX team.

Met with Sara Korba, will schedule a meeting to transfer the knowledge and artifacts to the new UMX team members.

The updated docuemtation is in this folder: https://ibm.box.com/s/5fr1pfqh9pzuxhqsapgpvijl9ltnyet8

Meeting scheduled for next Monday.

Met, shared, got a high level agreement on trying this out. Details will have to follow, but for now we can close this story.


bug: I swapped the colon and comma keys because it makes more sense to me, but using Flash will reset my keymaps.

Did you check docs and existing issues?

[X] I have read all the flash.nvim docs
[X] I have searched the existing issues of flash.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.2
Operating system/version
MacOS 13.4
Describe the bug
I swapped : and ,  but using flash will reset my keymaps
my flash opts is here:
    opts = {
      char = {
        keys = { "f", "F", "t", "T", ";", ":" },
      },
    },

Steps To Reproduce

using lazyvim
import flash
3.swap , and : in your keymaps file

Expected Behavior
swap , and : can work when using flash
Repro
-- using lazyvim and import "lazyvim.extras.editor.flash" then add following config
return {
    "folke/flash.nvim",
    optional = true,
    opts = {
      char = {
        keys = { "f", "F", "t", "T", ";", ":" },
      },
    },
}

Check the flash docs config section for how to remap.
you probably want:
keys = { "f", "F", "t", "T", ";", [","]:":" },


ERROR: Could not build wheels for scikit-learn, which is required to install pyproject.toml-based projects

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for scikit-learn
Failed to build scikit-learn
ERROR: Could not build wheels for scikit-learn, which is required to install pyproject.toml-based projects
anyone kind enough tell me what should i do

Hi, you need to install the right sckikit image.
https://stackoverflow.com/questions/74356504/installation-error-of-scikit-image-in-python-3-11-0
This links might help

Hi @826148133 sorry for the late response
I have made a major refactor of the code, fixing many issues and moving from flask to fastapi, if you are still interested please consider running git fetch to update your code to the latest version and try following the steps in the README to run the app.
Also consider using the web app www.dara.chat, it has some features and optimizations that are not open source yet. Thanks for trying it!


Add "About Us" Page to the Cab Rental Website

Description
We need to create an "About Us" page for our cab rental website. This page should provide visitors with essential information about our company, including our overview, mission and vision, and values and principles.
Content Requirements
Company Overview
Brief history and founding details.
Overview of services offered.
Any relevant milestones or achievements.
Mission and Vision
Clear statement of the company’s mission.
Vision for the future.
Values and Principles
List of core values.
Description of guiding principles.
before

after

pls assign this to me in vsoc

@shreya-2410  Go ahead and work on it. Since this design will depend on your creativity the points will be assigned accordingly. Additionally, do not forget to include the navbar on the page.


Polices needed

Hi
it would be nice to have a list of all needed Policies before deploying the CloudFormation Stack.
I went through the process interactively with my admin (deployed stack-> run into an policy error -> Had Admin add the policy (repeat until works)).
Thanks
Stefan

Hello @StefanA1309, does this document help? https://docs.aws.amazon.com/parallelcluster/latest/ug/iam-roles-in-parallelcluster-v3.html

Hi @mtfranchetto
maybe we did something wrong, but we started with a user which could create a PC successfully ("standard" one, no batch or image making tested so far).
Using this same user to deploy pcluster-manager run into several policy problems.
Comparing the policies we added with the one in your link (for example, one was iam:PutRolePolicy, where we added the resource '*')  I do see them listed in web page, so either:

The user deploying pcluster-manager needs more privileges than simply create PC (like image builder feature, which we didn't used so far)
The deployment of  pcluster-manager uses resources not covered by the 'standard' setup, like
"arn:aws:iam:::instance-profile/parallelcluster/",
"arn:aws:iam:::instance-profile/ParallelClusterImage",
"arn:aws:iam:::role/parallelcluster/*"

To be clear : We got it to work (*) and really like it, only something is missing in the docu to make the deployment easier.
Thanks
(*) The the SSM part needed for the slurm queue doesn't work, don't really understand that one yet as SSM is running on the head node. Guess I need more policies for SSM :(

Regarding SSM - all you need is to set SSMManagedInstanceCore in the additional policies section. This is automatically added when you enable "Virtual Console" in the UI. Let me know if you can't get this to work. Happy to help - also apologize for the confusion on policies, we'll work to put together a canonical list.


Adds shebang to "gush.phar" file

The gush.phar file, that installer downloads needs to be rebuilt for this change to take effect.
Closes #373

A new inspection was created.

The inspection completed: 2 new issues

The build failure is unrelated I think.

I will comply, i hope this solves your problem, really sorry I have been just busy and i was a bit confused by this because I had intentionally left this out https://github.com/gushphp/gush/commit/944d9fed419383c57265d12d7ee8918569b4b992 as you can see in the commit history. I did it purposefully but i forgot now. In any case i think let's try.

@sstok i guess there is an option to merge and rebasing right? I forgot about the rebasing. But in any case this PR was small. So anyway. Please let me know so i can rebase automatically next time. It worked beautifully my friend :+1: :baby: You have a fine place in the Gush core team.

thanks so much for your PR @aik099 you too are a great contributor and appreciated promotor.
Thank you! and let's hope we can take Gush to the next level in this 2015


fix(@angular/cli): fix completion lookup

Fix #4664

Closed in favor of https://github.com/angular/angular-cli/pull/4972


CLI preview note is incorrect?

"When you install the aks-preview extension, every AKS cluster you create uses the scale set preview deployment model. To opt out and create regular, fully supported clusters, remove the extension using az extension remove --name aks-preview."
Is this right? The cluster creation with VMSS includes an explicit --enable-vmss flag, meaning I would assume the type is opt-in and not changing the default if the preview ext is installed?
@sauryadas @iainfoulds

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 077f1bb5-2ba9-490c-2c6e-0de292266539
Version Independent ID: 0fd87b4f-88a4-c2eb-3ebc-f2b113ac203c
Content: Use the cluster autoscaler in Azure Kubernetes Service (AKS)
Content Source: articles/aks/cluster-autoscaler.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

Thanks @jluk will take a look and confirm on this

@jluk I did confirm that enabling this preview feature does make all your AKS clusters use VMSS. Even without the --enable-vmss flag
I just used
az aks create \
    --resource-group myResourceGroup \
    --name myAKSCluster \
    --node-count 3 \
    --generate-ssh-keys

And I get a note that

The behavior of this command has been altered by the following extension: aks-preview and it does in fact create a AKS cluster using VMSS.

So not sure if the --enable-vmss is actually needed or if it just relates to using auto-scaler
@iainfoulds @sauryadas can either of you confirm?

Thanks @MicahMcKittrick-MSFT for smoke testing this I'll follow up with AKS about this

@MicahMcKittrick-MSFT we've got some conflicting internal testing that shows default is still VMAS with extension installed. Can you show the output of az extension list so we can see what version you have?

@jluk I am not seeing a version
az feature list shows

{
"id": "/subscriptions/XXXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXX/providers/Microsoft.Features/providers/Microsoft.ContainerService/features/VMSSPreview",
"name": "Microsoft.ContainerService/VMSSPreview",
"properties": {
"state": "Registered"
},
"type": "Microsoft.Features/providers/features"
}
]

And every cluster I create shows

Although I tried to create an AKS cluster via the portal and it looks like it doesn't use VMSS if I do it that route.... Not sure if that is expected. Would have to have AKS look further into it

@jluk I am going to close this and let's continue offline. Please add me to any threads you have going on so we can continue.


is there a way to use this with grunt-protractor-runner

I'm not sure if this is the culprit but we use grunt-protractor-runner and when I followed your steps it seems that every single specfile overwrites the .xml file so there is only ever 1 suite (the last one that ran. I tried using the consolidateAll option for jasmine reporters to false and it created individual .xml files for each spec file but that doesn't work either since we need a single file. I was wondering if you had ever used grunt-protractor-runner or if there was a way I could maybe create an HTMLReport from a folder of .xml files rather than just one file?

Hi. No, I had never used grunt-protractor-runner. Currently protractor-html-reporter relies only on one xml file but I think it's worth to change it in order to use a folder of xml files. I will put this to my todo list.

Thank you for your response. That feature would definitely benefit me and my team.
From: etxebe<EMAIL_ADDRESS>Reply-To: etxebe/protractor-html-reporter<EMAIL_ADDRESS>Date: Tuesday, May 16, 2017 at 5:57 AM
To: etxebe/protractor-html-reporter<EMAIL_ADDRESS>Cc: Barret Vasilchik<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [etxebe/protractor-html-reporter] is there a way to use this with grunt-protractor-runner (#4)
Hi. No, I had never used grunt-protractor-runner. Currently protractor-html-reporter relies only on one xml file but I think it's worth to change it in order to use a folder of xml files. I will put this to my todo list.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/etxebe/protractor-html-reporter/issues/4#issuecomment-301734131, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKRNgb4k1s6ZRHwAGq7HL1zTBw7fwyJnks5r6XMegaJpZM4NIItZ.


Contact force devel

Add 3d-quantity coordinate transformation from the local frame to the world frame.
Add Jacobian transformation.

This is for #88


Bug: .. admonition:: directive is not layered properly

Compared to all other builtin admonitions, .. admonition:: seems to be rendering weirdly

This is caused by your accent colors definition. Please check https://shibuya.lepture.com/writing/admonition/#generic-admonition
If you want to keep your accent colors, you can customize your css:
.admonition {
    --icon-url: var(--i-bell-url);
    --color-1: var(--color-surface-accent);
    --color-2: var(--accent-a3);
    --color-3: var(--accent-9);
    --color-4: var(--accent-a11);
}

By replacing those accent colors.


Add new layoutFlag to hideNavigation - use this for embedded iFrame view.

@tibetsprague this is complete, yes?


Null value crash

Simplelog is sporadically having a null value on a table in lib\packethandlers.lua at line 363.  It's causing the addon to unload randomly.

To add to this, there's another null value crash happening when attempting to concat the output strings.
When an player or mob hasn't rendered on the client, actor.owner_name and/or target.owner_name could have null values even though the table, itself isn't nil.
Proposed solution would be to init the tables prior to processing the packets so that you would have empty variables of appropriate types rather than null variables.
On the comedic side of suggestions, before concatenating the strings, you could test if the values of those are nil, and if so, set them to be "The Invisible Man".

Will lock this one up, keep #12 for discussion, same issue.


Is it possible to make the vstest@2 task use the new version (or the old version)?

    I have this same issue in my Azure Pipelines, using vstest@2, no direct mstest reference. It's coming from MSTestAdapter:

MSTestAdapter failed to discover tests in class
I'm able to make the error stop by using the runsettings disablement of AppDomain, but the tests need the AppDomain, so we need another option.
Is it possible to make the vstest@2 task use the new version (or the old version)?
This is the task I'm referring to:
https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/vstest-v2?view=azure-pipelines
Originally posted by @GaTechThomas in https://github.com/microsoft/testfx/issues/1493#issuecomment-1381310699

Hi @GaTechThomas! Thanks for the bug report. Sadly this repository is not linked in anyway to vstest task. @dogirala Can you please let me know where users can report AzDo task issues?

Hi @Evangelink, if the bug is realted to AzDo tasks, then I believe the right team would be Pipelines team, and<EMAIL_ADDRESS>could help you I believe. If that didn't help, one other way I can suggest is to drop an email to create a customer query with Devops<EMAIL_ADDRESS>who could help you with the issue reporting or maybe even triage it to the right team.

The repository for Azure DevOps pipeline tasks is here: https://github.com/microsoft/azure-pipelines-tasks
You could try filing an issue there.

@GaTechThomas I have just reviewed a little more your issue and I think I am a bit confused. VSTest task is not bringing any dependency to MSTest so I think it's a configuration of your solution/projects.

Thank you @Evangelink. The project that I've been seeing this on is massive and has a very large number of resources that it acquires from nuget, from binaries in the repo, and from tools installed on the pipeline agent machine. It's pretty difficult to sort out what bits are coming from where. As a result, I've shifted from working on this to working on a focused alternative that uses .NET 6 and proper package management.
In short, I'm on a path that likely will abandon the need associated with this ticket. I'll know more in the coming days. It's probably safe to go ahead and close this ticket.

Ok closing this ticket. If you decide to continue, I'd recommend you to create a ticket on https://developercommunity.visualstudio.com/AzureDevOps as it seems (with elements at hand) there is nothing to do in MSTest.


[Bug]: Generated path is not deleted from CDN

Summary
Seems like already generated paths are kept on CDN indefinitely. I'm using one catch-all route /[[...paths]] to handle all of the paths on the site. Paths are obtained from the CMS through getStaticPaths with fallback set to blocking:
export const getStaticPaths = async () => {
  const paths = await getPaths()

  return {
    paths,
    fallback: 'blocking',
  }
}

Next those are validated in getStaticProps. If no data is present for the path getStaticProps returns:
return {
  notFound: true
}

if there is a data getStaticProps returns:
return {
    props: {
       // some props
    },
    revalidate: 10,
}

Whenever path is deleted (ie user removed a site in CMS) it is still available and Netlify returns 304 status for this path corresponding props json file when accessed directly and 200 status if navigated to.
There are no errors in functions logs.
Same is happening if I return an empty paths array from getStaticPaths:
export const getStaticPaths() => {
  return {
    paths: [ ],
    fallback: 'blocking',
  }
}

Redeploying the site fix the issue (I assume, because it flushes the CDN?)
Steps to reproduce

Create a path with some data and make sure it was actually generated (in case of empty paths array)
Remove that path
Site should be still served from Netlify

A link to a reproduction repository
No response
Plugin version
4.7.0
More information about your build

[ ] I am building using the CLI
[X] I am building using file-based configuration (netlify.toml)

What OS are you using?
Mac OS
Your netlify.toml file

`netlify.toml`
# Paste content of your `netlify.toml` file here

Your public/_redirects file

`_redirects`
# Paste content of your `_redirects` file here

Your next.config.js file

`next.config.js`
# Paste content of your `next.config.js` file here. Check there is no private info in there.

Builds logs (or link to your logs)

Build logs
# Paste logs here

Function logs

Function logs
# Paste logs here

.next JSON files

generated .next JSON files
# Paste file contents here. Please check there isn't any private info in them
# You can either build locally, or download the deploy from Netlify by clicking the arrow next to the deploy time.

Thanks for reporting this issue. It should now be fixed following a recent change to our on-demand builder functions.


unitest doesn't find any tests

python3.9 -m unittest  -v

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

PyPI tarball doesn't have tests, but GitHub one does.


build: add file dependencies for gyb

Add dependencies on the files for gyb to ensure that updates gyb are
treated as triggers to regenerate the files.  This is suspected to have
caused issues for incremental builds.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

rdar://problem/62945780

CC: @rintaro @drexin

@swift-ci please test

@swift-ci Please test Linux

@compnerd this seems that is still not working correctly. If I touch a python file from utils/gyb_syntax_support I can see the libSyntax headers getting re-generated (like SyntaxKind.h) but not the C++ files, e.g. all the files listed here:
_swift_gyb_target_sources(swiftSyntax PRIVATE
    SyntaxNodes.cpp.gyb
    SyntaxBuilders.cpp.gyb
    SyntaxKind.cpp.gyb
    SyntaxFactory.cpp.gyb
    SyntaxVisitor.cpp.gyb
    Trivia.cpp.gyb
    SyntaxSerialization.cpp.gyb)

@rintaro says that he sees the C++ files re-generating so there may be something wrong with my setup, I'll look into it more.


yukinessa.html

confirm pls...

Your pull request seems good, but must be checked by a human maintainer for the following reason(s):

This file modifies a pre-existing file.

Please be patient until a maintainer has time to look over your contribution.
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

746ad289e1b6e1dbbc1b9cf43b3e3a88ee0330a8

Please don't modify other people's files, especially when using them as templates.

This PR has been idle for more than 24 hours, and will now be closed. Feel free to re-open.
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

746ad289e1b6e1dbbc1b9cf43b3e3a88ee0330a8


Garbage info printed to the log whenever accessing save/load pages

When a user accesses load/save page, the log generates garbage data in a loop data savegame exists (from 0 to 15)
whenever a user saves to slot 9 it will still generate info but omitting slot 9

Fixed in 9e7f8799bcfca3011e8377973a00ba6cd6e1c58e


Add Serde::Serialize for generated message types

Since we already depend on serde anyway, adding serialize allows for easy dumping of messages as JSON for quick debugging, which should be nicer than staring at raw tag integers.
While at it, I made FieldTag::from_tag_num public, which is also quite useful for looking up tag IDs when debugging without looking it up in XML.

@PolyMeilex Merged. But it will have impact for build time which was quite long already.
Consider making this optional by adding serde feature to Cargo.toml


Esri services srs must be read from latestWkid and not from wkid

I believe this is done, but need confirmation.

Esri service srs is still read from wkid. It seems that there is no lastestWkid available in 'arcrest==10.3'.


.Net Passing Kernel instance to FunctionResult

Motivation and Context
Currently, the 'FunctionResult' class requires access to the culture configured on a kernel instance to properly perform complex type to string conversion. Since we are already passing the Kernel everywhere - including kernel functions and connectors - passing an instance of the kernel to the 'FunctionResult' class seems like a natural thing to do.

@RogerBarreto I've changed it to the draft to collect more feedback on the change. @stephentoub @markwallace-microsoft do you think we should proceed with this change?

@RogerBarreto I've changed it to the draft to collect more feedback on the change. @stephentoub @markwallace-microsoft do you think we should proceed with this change?

I don't feel strongly about it. It just seems like a) if we're passing the kernel "everywhere" and it's part of a function's evaluation and some of its information is necessary in the FunctionResult then it makes sense to pass it into the FunctionResult, b) from a public API perspective it's a bit weird to expect a CultureInfo into it, and b) it's more future-proof if FunctionResult ever needs something further from the Kernel.  The downside would be if we ever need to create a FunctionResult and don't have a Kernel but still need the information it contained, and in terms of future-proofing, we can always add more constructors (including one for Kernel in the future if that's desired). So, I'm fine either way.
Does FunctionResult actually need CultureInfo, or would an IFormatProvider (which CultureInfo implements) be sufficient?

@RogerBarreto I've changed it to the draft to collect more feedback on the change. @stephentoub @markwallace-microsoft do you think we should proceed with this change?

I don't feel strongly about it. It just seems like a) if we're passing the kernel "everywhere" and it's part of a function's evaluation and some of its information is necessary in the FunctionResult then it makes sense to pass it into the FunctionResult, b) from a public API perspective it's a bit weird to expect a CultureInfo into it, and b) it's more future-proof if FunctionResult ever needs something further from the Kernel. The downside would be if we ever need to create a FunctionResult and don't have a Kernel but still need the information it contained, and in terms of future-proofing, we can always add more constructors (including one for Kernel in the future if that's desired). So, I'm fine either way.
Does FunctionResult actually need CultureInfo, or would an IFormatProvider (which CultureInfo implements) be sufficient?

No, the 'TypeConverter.ConvertToString(ITypeDescriptorContext context, CultureInfo culture, object value)' method needs CultureInfo and there's no overload that would accept 'IFormatProvider' instead.
I'm 50/50 as well, so I'll keep things as they are and close this draft later, unless @markwallace-microsoft has a different opinion.

We agreed, offline, to keep things as they are today and align default culture in FunctionResult and Kernel classes to be InvariantCulture to have deterministic behavior of type conversion functionality.


[Model Update]: RecyclingStrategyCertificate 3.0.0

Description
add attributes: revocation Date
change UUid from version 1to version 2
change BPN from version 1 to version 2
Issue : https://github.com/eclipse-tractusx/sldt-semantic-models/issues/624
-->
Closes #624

MS2 Criteria
(to be filled out by PR reviewer)

[x] the model validates with the SAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check  (e.g., 'java -jar samm-cli.jar aspect <path-to-aspect-model> validate ). The  SAMM CLI is available here and in GitHub
[x] use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
[x] the identifiers for all model elements start with a capital letter except for properties
[x] the identifier for properties starts with a small letter
[x] all model elements at least contain the fields "preferred name" and "description" in English language. The description must be comprehensible. It is not required to write full sentences but style should be consistent over the whole model
[x] Property and the referenced Characteristic should not have the same name
[x] the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
[x] use abbreviations only when necessary and if these are sufficiently common
[x] avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
[x] fields preferredName and description are not the same
[x] preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
[x] name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
[x] units are referenced from the SAMM unit catalog whenever possible
[x] use constraints to make known constraints from the use case explicit in the aspect model
[x] when relying on external standards, they are referenced through a "see" element
[x] all properties with an simple type have an example value
[x] metadata.json exists with status "release"
[x] generated json schema validates against example json payload
[x] file RELEASE_NOTES.md exists and contains entries for proposed model changes
[x] all contributors to this model are mentioned in copyright header of model file

MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)

[ ] All required reviewers have approved this PR (see reviewers section)
[ ] The new aspect (version) will be implemented by at least one data provider
[ ] The new aspect (version) will be consumed by at least one data consumer
[ ] There exists valid test data
[ ] In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
[ ] The model has at least version '1.0.0'
[ ] If a previous model exists, model deprecation has been checked for previous model
[ ] The release date in the Release Note is set to the date of the MS3 approval

@agg3fe Can you please check the PR.

Discussion required for open points.
date charactersristic
vin and oe number mandatory?
@jacewski-bosch

@tanweersalah further discussion required for vin, oe number

Changed OE Number to manufacturerPartId from aspect "part_type_information"
Changed VIN to localIdentifiers from aspect "serial_part"

@catroest  please review the last commit, is this what you meant?

@tanweersalah further discussion required for vin, oe number

@jacewski-bosch Could you please check if this is what intended from your point of view.

I would propose something like in the picture. The serial number you want to link here is NOT the serial number of the connected twin/part of the certificate, but the vehicle. I would propose to define the property yourself, in order to state exactly this.
The OE-number I am not sure. This is the oeNumber of the part.

I would propose something like in the picture. The serial number you want to link here is NOT the serial number of the connected twin/part of the certificate, but the vehicle. I would propose to define the property yourself, in order to state exactly this. The OE-number I am not sure...

but the local identifier is a list of Keyvalue pair, but if i do as you proposed it will limit it to have only VIN.
the other certificates which uses this shared aspect i.e reuse, remanufacturing , refurbishing certificate etc we need to have partInstanceId for them , If we keep it without the parent property VIN we can use this localindentifier without defining again in other certificates for capturing partInstanceId.

Yes but how does the data provider know what to provide here? If you just directly link to "localIdentifiers" the closest which can be interpreted, would be the serial id of the certificate itself. Thats why I propose to link on the level of the characteristic, then you can describe the property as a vin.

@tanweersalah @catroest @agg3fe we have a meeting in the afternoon where we hope to clarify this.
We'll summarize the reasoning here.


Assignment 06 -- 20 Mar 2024

Update your presence status on SIX.
Fork this repository so I can mention you in each issues.
Update your GitHub repository with some directions as follow.

ID
20922006
20922303
20923003

Repository
YT-comment-scraper
20922303_Nita-Dwi-Fitriani
sk6093

README.md
✔
✔
✔

LICENSE
❌
❌
✔

Author / contributor name(s)
:x:
:x:
:x:

Contact (e.g. on X)
:x:
:x:
:x:

Usage
:x:
:x:
:x:

Files description
:x:
:x:
:x:

Timeline and stages *
:x:
:x:
:x:

Current bugs / progress
:x:
:x:
:x:

History of progress / bugs fixed
:x:
:x:
:x:

* copy and paste from previous assignment (it can be in README.md of in other file, but the link to this file is available in README.md).

I have completed this assignment in the repository in the README.md file

I have completed the given task. Thank you, Pak Dudung.

I have completed this assignment in the repository in the README.md file

I updated today's progress on README.md
https://github.com/NitaDwiFitriani/20922303_Nita-Dwi-Fitriani/blob/main/README.md


Wrong extension - extname ignored (jpeg instead of jpg)

This is my config:
return gulp.src('static-full/team/*.{jpg,png}')
      .pipe(responsive({

          '*': [
              {
                  width: 480,
                  rename: {
                      extname: '.jpg',
                  },
                  quality: 80,
                  format: 'jpeg'
              },
              {
                  width: 480,
                  rename: {
                      extname: '.webp',
                  },
                  format: 'webp'
              }
          ],
      }

Extname is '.jpg' but when I execute it files are name .jpeg not .jpg
It seems that extreme is ignored.

Since this project seems to be inactive (https://github.com/mahnunchik/gulp-responsive/issues/111), I've gone ahead and created a new plugin for the purpose of resizing your images: https://github.com/robinloeffel/gulp-rezzy.
You can use gulp-rezzy together with gulp-webp (and gulp-imagemin) to achieve your goal. Pipe your assets to gulp-rezzy, then gulp-imagemin, then write the stream (your jpg images) to the disk, pipe them to gulp-webp and at the end write stream (your webp images) to the disk again.

I "fixed" this by locking my package version to 2.7.0 which still keeps the correct file extensions.


keep namespace/package name consistency

keep namespace/package name consistency - "xml_models2", then we can use from xml_models2 import Model instead of from xml_models import Model since the package named xml_models2

Can you separate this into two pull request? - one for the missing module fix and one for the module rename.
I'm not sure about renaming the module just yet...

Had separated the rest_client sub-module lost part into a new pull request #12  , please have a check :)


Adapters observed to send excess CTS responses

Selected adaptors have been observed to send excess CTS messages.
This results in data not being received within the observation.
Private data was provided to J1939-84@So…net for review.
The review findings and corrective actions are discussed by the provider below.

[We] have a PEAK adapter and have started the evaluation.  [We observe] duplicate CTS from the PEAK.  This works with [one] ECM that [we have] been testing with and fails with another.  [We] suspect that PEAK is using it's own J1939TP even though we have configured it to not be used.  It may be because we sent the command to CMD_PROTECT_J1939_ADDRESS (handle the address claim in the adapter), so it assumes adapter TP support.
[We will] investigate putting address claiming functionality in the tool instead of using RP1210 adapter support.  If that doesn't work, then instead of using J1939 mode, we will need to switch to raw CAN mode which will take quite a bit of effort, but I've done it before.

The provider also reported:
Removing the CMD_PROTOECT_J1939_ADDRESS allows PEAK to work.
We will move the address claim logic to the application from the adapter.

Address claim added to application layer. Not observed in 3.1.5


Android white OS footer

Description
Adds 2 style lines to main/styles.xml, to make the OS footer white with dark buttons. Some devices already have this as default, so it won't change anything there, but devices which would normally display a black OS footer will now show a white one.
 Every target will just use the main/styles.xml file.
Related issues

Fixes #365

🎉

@jmrossy
Before:
After:


The documentation for the test functions is not complete. - quality -2

add detailed test documentation for freefall


Decode bytes to unicode if reader receives bytes instead of string

This pull request adds support for decoding bytes sent to the asynchronous parser.
This is useful in cases where you have no control over the type of data provided by the async reader object.
For example when reading a csv from network using aiohttp the content arrives as type bytes which needs to be decoded to Unicode:
async def test_network_read():
    async with aiohttp.ClientSession() as session:
        async with session.get(REMOTE_FILENAME) as response:
            read_rows = [i async for i in AsyncReader(response.content)]
            assert read_rows == VALUES

Currently, this will result in the following TypeError being raised:
TypeError: Expected unicode, got bytes
But this pull request will decode the bytes as they're being read from the stream, allowing for more performance as data is parsed while the stream is being read.

Currently, this will result in the following TypeError being raised: TypeError: Expected unicode, got bytes

Yes, that's intentional, and that's how the built-in csv module works.
See issue #2.
I'm sorry, but that's just not a place to do the decoding.
In synchronous Python one can use io.TextIOWrapper to wrap a binary stream into a text stream with any hassle.
Writing such a wrapper for async is also a matter of a few lines. That's the reason I'm also closing the PR without merging.

Also, I have some feedback on the PR itself.

It doesn't allow to specify the encoding and encoding error handling.
The feature set for reading and writing should be symmetric, and this PR only adds support for reading from a binary stream.
It's unsafe to call decode on arbitrarily sliced chunks. The parser in your PR reads in 1024-byte chunks, and there's no guarantee that it won't stop reading in the middle of a code point.

# Let's pretend that that's our stream, that will be read in chunks of 7.
a = "いろはにほへとちりぬるをわかよたれそつねならむうゐのおくやまけふこえてあさきゆめみしゑひもせす"

# As a string, there are no issues with chunk reading
for i in range(0, len(a), 7):
    a[i:i+7]

# Let's now try to read this as a binary stream in 7-byte chunks
b = a.encode("utf-8")
for i in range(0, len(b), 7):
    a[i:i+7].decode("utf-8")
# A UnicodeDecodeError is thrown

Why, oh why, is internet needed to test those changes? This looks super odd and suspicious. aiocsv doesn't do anything that's got to do with internet communication, so why would it need aiohttp to test these changes?
Hardcoding a path to GitHub in the tests will force everyone to change the tests when forking.
The tests will fail when GitHub is down, or if I decide to move this repository.

Alright, I noted the issues with my PR & thanks for your feedback.


Yubikey table JDBC updates are not commited to NDB

This line returns 1 which means one row is affected in the Yubikey table but no changes are made in the table.
https://github.com/biobankcloud/CauthRealm/blob/master/src/main/java/se/kth/bbc/crealm/CustomAuthRealm.java#L502

I rebuilt Cauth and redeployed it. Did this fix the problem?


Migrate travis to GitHub actions

Types of changes

[ ] Bugfix
[ ] New feature
[ ] Refactoring
[ ] Breaking change (any change that would cause existing functionality to not work as expected)
[ ] Documentation Update
[x] Other : Migrate travis to GitHub actions

Description
Migrate travis ci to github actions, and fix flake8 errors and proposal test case at the same time

Codecov Report
Patch coverage has no change and project coverage change: -0.07 :warning:

Comparison is base (6fa966d) 69.56% compared to head (ad429c8) 69.49%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
- Coverage   69.56%   69.49%   -0.07%
==========================================
  Files          82       82
  Lines        3364     3357       -7
==========================================
- Hits         2340     2333       -7
  Misses       1024     1024

Impacted Files
Coverage Δ

src/core/models.py

src/proposals/forms/mixins.py

src/proposals/forms/proposals.py

src/events/resources.py

src/attendee/models.py

src/reviews/models.py

src/attendee/api/urls.py

src/proposals/management/commands/slack.py

src/core/widgets.py

src/attendee/apps.py

... and 154 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I have tested the codecov from GitHub action but it did not work. I reset it and used TODO here.
Minor issues fixed
Thanks

Thanks @iknowright for finishing the job!


ENH: momentum v0.1.12

Hi! This is the friendly automated conda-forge-webservice.
I've started a version update as instructed in #58.
I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!
Fixes #58

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11206643958.


[BEAM-8450] Allow empty bundles in ParDoLifecycleTest

Fixes [BEAM-8450].

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.


Enabled maxHttpHeaderSize customization

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Remember to set idealista:develop as base branch;

Description of the Change
Add maxHttpHeaderSize option to be able to customize the value as nedeed
Benefits
To be able to customize maxHttpHeaderSize value
Possible Drawbacks
No drawbacks if i wrote it well. A default value is included in case you don't set any
Applicable Issues

Thanks for taking the time to contribute @jiglesias-ntt.
Could you please update the changelog with the changes?.

Hi @jiglesias-ntt
Thanks for your contribution and sorry for the delay. in my opinion LGTM, can you update the changelog so we are good to go?

Hi @sorobon,
Could you tell me the section of the changelog where I should add the new entry?
Many thanks

Hi @jiglesias-ntt, it should be under the "Unreleased" section.