Unify arm64 and x86 64 image tags

Related to https://github.com/fluent/fluentd-kubernetes-daemonset/pull/491#issuecomment-686159433.

Umm..., DockerHub build should overwrite tag when using same tag on different architecture....

Pushing same tag with different architectures may be needed to build with docker buildx which is not supported on DockerHub....


error while download vendor from composer

error facing while composer require sparkpost/sparkpost

Can you provide more detailed error message during Composer installation that you got?


Allow game authors to direct voters feedback efforts

A few suggestions have come up on the LD39 results thread asking for effectively some way to get something more specific out of their voters. Such as a "Looking for feedback on: (user defined text)" (suggested by seconddimension), or as a game-author-defined poll to get feedback on something the author feels is important (Initially suggested by zelos)
I think this kind of thing is a low hanging fruit that could be beneficial to LD and let game authors get more out of the experience, so we should investigate adding some kind of mechanism along these lines.

Interesting. So effectively changing the voting stage to a sort of Q&A. Your ratings, plus any additional questions the author has for the player.

This would really be intriguing. A user may add their own voting category for only their game, or a question that the raters can choose to vote and comment on. I see some issues with how the database is structured but as a feature this would make much sense and be fun. It would be important that the question can't be changed after first answer on it.

We could add simple voting-like Q&A I think by adding some "custom" grades that don't get aggregated across all games, and using game node meta to store what the questions should be, possibly with UI similar to the existing link UI. That would be a pretty compelling start I think

Since the custom results aren't going to be directly comparable though, it doesn't necessarily need to be in the grade table. Might as well have a mega response type (number and/or string) for polls.

We could easily implement custom grading (could suggest from previous customs of other ppl), and collect that in a table similar to the grade table. Then we could also implement custom Q&A, with different table. They don't really depend on each other. This would also be good if we ever decide to drop one of the current categories, then those who want to keep a voting category can just custom it.

Better question: what are some things people would actually ask? I'm not
seeing much need for "custom grades" when you can't actually compare them
to anything.
On Sep 13, 2017 11:02, "Martin Zackrisson"<EMAIL_ADDRESS>wrote:

We could easily implement custom grading (could suggest from previous
customs of other ppl), and collect that in a table similar to the grade
table. Then we could also implement custom Q&A, with different table. They
don't really depend on each other. This would also be good if we ever
decide to drop one of the current categories, then those who want to keep a
voting category can just custom it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ludumdare/ludumdare/issues/1196#issuecomment-329196495,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABf2CZAqhZnKNBop0N432pvAPnCWufYzks5sh-6EgaJpZM4PDU58
.

Sorry, perhaps I need to elaborate. If I wanted a category like difficulty or intuitiveness or other, these could at the end of the event be tallied down to a score just like the standard voting categories. Reason to have them as voting category and not as comment would be that more people tend to give grades than comment and that you would get an average result in the end. If we also let these categories be globally known (kind of like a tag) then many users could use the same category. For example maybe I decided I want a snowman-unicode category for this winter LD and I promote it so that a lot of people pick it up. Then it could be treated like all other categories. So that at the end of the event, you would get a rank in the bonus category you joined. Even if there were just 3 other games in the same category, it could still be fun to look at those and see why they had the same category and how they did. The site don't need to award any trophies nor promote any of the winners. But if people found bonus categories  to be a fun thing, the winners of the most commonly used bonus-categories could also be promoted in their own section. Just like ordinary winners.
So tldr: It could encourage playfulness and could be a nice way to get focused statistics about something you care extra about.

Okay, so you do want to be able to compare them.
I kinda feel like this is a separate item. I like the term "Bonus Categories".
I don't want to dwell too much on this at the moment, but I know there are a bunch of issues that would have to be addressed here (minimum votes vs regluar judging, performance to calculate said scores, etc). Anyway, this should be its own issue.

Agree!


nginx-ingress-controller does not support default backend

At the moment it is not possible to specify a default backend in nginx-ingress-controller-app.
It would be desirable to be able to specify a default backend similarly to the way this is possible in upstream.
https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/values.yaml#L806

Release v2.23.0 of nginx-ingress-controller-app introduced the ability to specify a default backend through user values. This is aligned to upstream chart ingress-nginx


Possible issue on session get_bind

This may be a problem on SQLAlchemy itself, simple example:
from flask import Flask
from flask_sqlalchemy import SQLAlchemy

app = Flask(__name__)
app.config["SQLALCHEMY_DATABASE_URI"] = "sqlite:///example.sqlite"
db = SQLAlchemy(app)

db.session.get_bind()

The output from the execution above:
Traceback (most recent call last):
  File "exp.py", line 8, in <module>
    db.session.get_bind()
  File "<string>", line 2, in get_bind
TypeError: get_bind() takes from 1 to 3 positional arguments but 6 were given

Should return a SQLAlchemy engine
Environment:

Python version: 3.7
Flask-SQLAlchemy version: 2.5.1
SQLAlchemy version: 1.4.7

I have absolutely no idea what's going on there, it seems that the frame isn't even available to debug. If you have time, I'd appreciate if you could dig into it, because I won't have time soon.

Sure @davidism I'll dig into it. At first it seemed like something was obviously wrong with what I was doing

I looked at the code briefly and didn't see anything. Check the sqlalchemy version, might be a compatibility issue?

Just a couple of notes:
when using SQLAlchemy < 1.4.0
return getattr(self.registry(), name)(*args, **kwargs)
using SQLAlchemy > 1.4.0
    @property
    def _proxied(self):
        return self.registry()

https://github.com/sqlalchemy/sqlalchemy/blob/master/lib/sqlalchemy/orm/session.py#L4026
Seems that get_bind() is called with the session parameters that are 6

Leaving an update here:
re-checked this issue with latest SQLAlchemy=1.4.18 and Flask-SQLAlchemy 2.5.1, still an issue different error:
    db.session.get_bind()
  File "<string>", line 2, in get_bind
TypeError: get_bind() got an unexpected keyword argument 'bind'

hi, was just wondering what the next steps are for this? do we need something like 2.5.2 with #955 included in the release?

Hello,
I understand that this is fixed in master in #943; any update on getting a formal release (whether 2.5.2 or 3.0.0) containing the fix?

Hello, I understand that this is fixed in master in #943; any update on getting a formal release (whether 2.5.2 or 3.0.0) containing the fix?

Please see this comment.

I've been getting a related error with code such as
entries = db.session.execute(s,  bind=db.get_engine(bind="name")).all()

which works with sqlalchemy 1.3.24 but fails with sqlalchemy 1.4.31 with
TypeError: get_bind() got an unexpected keyword argument 'bind'

Unfortunately we rely heavily on pandas and pandas 1.4 raises an error unless sqlalchemy is >=1.4, so simply holding sqlalchemy back is more broadly problematic. However, while waiting for the update to flask-sqlalchemy I was able to work around it by substituting the code above with
engine = db.get_engine(bind="name")
session = db.create_scoped_session(options={'bind': engine})
entries = session.execute(s).all()

fixed in #1087


Updated survey charts for Nov 2019

Coverage increased (+0.03%) to 73.63% when pulling cd06721b6ee53a2714066f261edf39274dfc0e70 on yitam:survey11 into b77bfa82f44134a0f610178492146ab3707a2998 on microsoft:dev.


branchMap and fnMap line properties are not corrected

I was wondering why my coverage reports that get uploaded to codecov are missing branch (and function) coverage stats.
I’m uploading the lcov.info file. But looking at the .json file, I noticed that the line member for branchMap and fnMap items is not corrected, while the locations (start and end) are correct.
The lcov file generated from the json also gets the wrong locations, thats why codecov ignores them.
I will look into this tomorrow when I got the time…

Hm, apparently codecov not showing the branch coverage is a separate issue: https://github.com/codecov/support/issues/22
But with the provided patch, lcov genhtml lcov.info --rc lcov_branch_coverage=1 generates the correct annotations with the correct branch line numbers


[FEAT] New Architecture Migration

Summary
In this PR, we migrated the library to the New Architecture.
TestPlan
We tried to test it by:

Creating a new React Native app: npx react-native init NewArch
installing the library: cd NewArch && yarn add ../react-native-blob-util
enabling the New Architecture:

on iOS: cd ios && bundle install && RCT_NEW_ARCH_ENABLED=1 bundle exec pod install
on Android: open the gradle.properties file and set the newArchEnabled flag to true.

Running the app: npx react-native run-ios and npx react-native run-android
Replacing the default App.js with the one we found in the examples/ReactNativeBlobUtils

Next Steps
We will be happy to help you test the library further.
If you have any other way to test the library, let us know how to do it and we will schedule some time to do that! :D

cc @cortinico who helped with the Android development

Currently the oldarch doesn't work.
Testcase:
New project on RN 063 as suggested in the example app
Result: "TypeError: null is not an object (evaluating '_NativeBlobUtils.default.getConstants')"
It seems that the default export  in codegenSpecs/NativeBlobUtils.js)is null

New project on RN 063 as suggested in the example app

Is this happening on Android or iOS?
Also does it reproduce on RN 070?

New project on RN 063 as suggested in the example app

Is this happening on Android or iOS? Also does it reproduce on RN 070?

It's happening on Android (iOS not tested yet).
I'll test it later today on RN 070 and give you feedback about that

@cortinico in RN 07 with newArchEnabled=false it works fine

@cortinico in RN 07 with newArchEnabled=false it works fine

That's great to hear. We'll have to bisect the RN versions to understand where it failed :(

@cortinico in RN 07 with newArchEnabled=false it works fine

That's great to hear. We'll have to bisect the RN versions to understand where it failed :(

I'm checking in parallel...
RN 0.65.2 works as expected
RN 0.64.1 has the issue on the other hand
Upgrading to Gradle 6.9 doesn't do the trick - kinda had the hope for a bug here

I'll have to look into this next week

Sorry I haven't got the time to look into this yet @RonRadtke
I'm also wondering if you would be fine just releasing a new version of react-native-blob-util mentioning that you support RN 0.64+ and point users to the latest stable version for 0.63 as 63 is quite of an old version.

I'll have to look into this next week

Sorry I haven't got the time to look into this yet @RonRadtke I'm also wondering if you would be fine just releasing a new version of react-native-blob-util mentioning that you support RN 0.64+ and point users to the latest stable version for 0.63 as 63 is quite of an old version.

Hi - that's okay, thanks for answering regardless.
Yes, as I said on discord, I would be perfectly fine bumping the minimum version of RN to 0.64.+
Or even higher if you think there is a benefit in.  (I think one version increased the OkHTTP to v4, might be worth taking this one with directly too then)

newarch on RN 0.70 on iOS is working fine
Oldarch on an older RN I'm still testing or better fighting with xcode

Hi @RonRadtke, if you need help with your battle, I may help you. I had my fair shares of Xcode's fight!

Hi @RonRadtke, if you need help with your battle, I may help you. I had my fair shares of Xcode's fight!

Thank you - yeah Xcode is pain.
But I got it to work with RN0.64.1 and since we are planning to drop 0.63 that's fine.
So we are fine on iOS too. :)
I'll create a pull-request on your branch later on to fix some issues and outdated definitions

Hi @RonRadtke, is there anything I can do to help you with the PR? Is it about solving the conflicts of:
android/src/main/java/com/ReactNativeBlobUtil/ReactNativeBlobUtil.java
android/src/main/java/com/ReactNativeBlobUtil/ReactNativeBlobUtilReq.java

Or there is something more to do?

Thanks. This pull request has been integrated manually.

You are very welcome! :D
Let us know how the testing goes and when it is released. If you also have an ETA, that would really helpful for our planning. 🙏
Thank you so much!

You are very welcome! :D
Let us know how the testing goes and when it is released. If you also have an ETA, that would really helpful for our planning. 🙏
Thank you so much!

My plan is to get some documentation and readme etc done today. So my goal is to release it till tomorrow midnight (11.11 12am CET)

@cipolleschi it's released :)

hello @RonRadtke
still not working  on
android
RN 0.64.1
react-native-blob-util: 0.17.0

@feraswfares I know - we had to drop the 0.64 support. It is fairly old and it's more important to get the new arch supported than supporting an old react-native version.
But I obviously wrote the wrong version in the readme - sorry for that.


panic reading ansible inventory

$ terraform plan
Refreshing Terraform state in-memory prior to plan...
The refreshed state will be used to calculate this plan, but will not be
persisted to local or remote state storage.

data.yaml_map_of_strings.normal: Refreshing state...

 TERRAFORM CRASH !!!!!!!!!!!!!!!!!!!!!!!!!!!!

Terraform crashed! This is always indicative of a bug within Terraform.
A crash log has been placed at "crash.log" relative to your current
working directory. It would be immensely helpful if you could please
report the crash with Terraform[1] so that we can fix this.

When reporting bugs, please include your terraform version. That
information is available on the first line of crash.log. You can also
get it by running 'terraform --version' on the command line.

[1]: https://github.com/hashicorp/terraform/issues

!!!!!!!!!!!!!!!!!!!!!!!!!!! TERRAFORM CRASH !!!!!!!!!!!!!!!!!!!!!!!!!!!!

Could you check what version of the plugin do you use? It sounds similar to the issue that twas addressed in https://github.com/ashald/terraform-provider-yaml/pull/3 so I'm wondering if it will work for you if you try 2.0.1 or above.
If that wouldn't help - would you be able to share the file you're trying to parse or at least a fragment of it that makes it fail?
I guess some better error logging wouldn't hurt the provider.

I just tried 2.0.2 and the problem is fixed. I only found that version from following the link on the closed issue, so it would help to update the link on the main page. Thanks!

Do you mean the link in this section https://github.com/ashald/terraform-provider-yaml#download ? Or some other link? If it's confusing I indeed should update it.
In general you check latest versions in the releases page https://github.com/ashald/terraform-provider-yaml/releases


Fix for ci image generation and some updates

This PR fixes the image generation for the ci and updates the base-devel meta package with bc and cmake now that those are available. Furthermore, a new meta package called gui is added, which depends on base, weston and some X based utility programs.

LGTM, thank you for the PR.


neovim: add wrapRc option

Motivation for this change
Pass the wrapRc option through so it's usable from the neovim package exposed by pkgs/top-level/all-packages.nix. I needed this to maintain some degree of backward compatibility for my setup, so I thought it'd be better pushed upstream. IIRC, there are a few more options that could easily be exposed but aren't, and I could fish these out if we want a more complete PR.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

could you expand how this helped with ackwards compatiblitiy and what options you are thinking of ?

Backward compatibility: previously, the neovim installed from nixpkgs would look in ~/.config/nvim/ for config files. In a recent change, wrapRc = true essentially became the default, so neovim would no longer look for config files. To get the old behaviour, I install the package neovim.override { wrapRc = false; }.
Other options: I'm referring to the difference between the parameters of wrapper and the parameters of legacyWrapper. As well as wrapRc, there are wrapperArgs, manifestRc, rubyEnv, and neovimRcContent that I don't see an equivalent of in legacyWrapper. I don't understand most of these options, which is part of the reason why I didn't want to include them initially.

a bit lower we have wrapRc = (configure != {}); maybe keep that as default for now.
Also for more context https://github.com/NixOS/nixpkgs/issues/177375 .

ping, there was another person needing this. Could you rebase and address my comment https://github.com/NixOS/nixpkgs/pull/128827#issuecomment-1230762809 please ?


Goodbye, bad whitespace

This commit will remove hard tabs and trailing whitespace from lines throughout the codebase.
In order to reveal offending lines, I used a version of bundler's quality_spec.  The spec breaks with more recent versions of rspec, which is the only reason I haven't included the spec itself with this PR.

rebase?

Wooo, this is an old one. I'll give it a go :)

@mathieujobin, rebase finished. Cheers!


AnyResources is defined multiple times.

When using the typegen with multiple --from-bundles, you end up with multiple definitions for AnyResource.
The reason for this is that the build_ast function is executed for each bundle. See cli.py#L32.
I think it would be better to chain all StructureDefinitions first and then call build_ast only a single time.

Thanks for catching the problem!


Do not show unrelated items when Action keyword isn't used

Practically, it's the same issue as here: https://github.com/Garulf/Obsidian-Notes/issues/31, therefore the copy-paste:

Currently, the plugin shows all the notes even if you don't type anything – it assumes I will use Action Keyword, and with this assumption it's kinda useful feature: lets you see some notes even if you haven't typed anything yet.
But if I don't use Action Keyword (*), then these files are just unrelated clutter.
So please, show only relevant files if Action Keyword isn't used.
If Action Keyword is used, it's ok to show all the files with relevant first.

This is adjustable via settings to show results in empty query.
Unfortunately settings are in a semi broken state. A new release of this plugin is 99% done and should have the settings issue fixed.


Add HTMX Demos

To do, infinite scroll, etc.

Pull over and fix from https://github.com/wiverson/htmx-demo
Add persistence to the todos


I should not have to wait for the product to upload (esp. when I have no or little network)

It should save the product immediately, attempt to upload it in the background, and notify me if there are any conflicts to solve

@teolemon in this issue shouldn't we detect if there is no network and display a dialog "no network detected. Try re-connecting your network" ?

No. It's annoying. We should save to the local database, display a success in the UI, and then try to upload.

will be fixed by @philippeauriach in #3072


[WIP] Experimenting with constructor improvements

WIP: trying out some things on constructors to make them faster/more reliable
Findings

materialization before ingesting the input avoids the huge allocation numbers that scale with input length

# pre change
julia> @time DTable(CSV.File("test.csv"), 12000)

  0.141167 seconds (4.92 M allocations: 123.415 MiB)
DTable with 84 partitions
Tabletype: NamedTuple

# post change

julia> @time DTable(CSV.File("test.csv"), 12000)

  0.021110 seconds (8.09 k allocations: 48.421 MiB)
DTable with 84 partitions
Tabletype: NamedTuple

Codecov Report
Base: 90.44% // Head: 90.26% // Decreases project coverage by -0.18% :warning:

Coverage data is based on head (e537309) compared to base (ea175d9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   90.44%   90.26%   -0.19%
==========================================
  Files          10       10
  Lines         827      791      -36
==========================================
- Hits          748      714      -34
+ Misses         79       77       -2

Impacted Files
Coverage Δ

src/table/dtable.jl
85.88% <100.00%> (+1.43%)
:arrow_up:

src/table/dataframes_interface.jl
63.46% <0.00%> (-1.36%)
:arrow_down:

src/table/gdtable.jl
78.84% <0.00%> (-0.79%)
:arrow_down:

src/table/tables.jl
87.64% <0.00%> (-0.28%)
:arrow_down:

src/table/dataframes_interface_utils.jl
92.45% <0.00%> (-0.14%)
:arrow_down:

src/table/join.jl
100.00% <0.00%> (ø)

src/table/groupby.jl
100.00% <0.00%> (ø)

src/table/dtable_column.jl
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update office-365-worldwide-endpoints.md

Added *.s-msedge.net  to the teams section

@JoeDavies-MSFT - PR is ready for final review. Thank you.

@msbemba Updates to the endpoint lists must be done through a Microsoft-internal vetting process. I cannot approve this PR.


Possible new issue with Laravel 10 and latest symfony updates

So as not to duplicate the issue I'll just link it here
https://github.com/pionl/laravel-chunk-upload/issues/161
For now I've had to remove this package.. this is a weird one

Looks like an upstream issue, or a server misconfiguration. Following up on the aforementioned issue.


Undo Fixed

The undo of marcdown symbols are fixed.

Hey @iamabs2001,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: d389cd70-a41a-11ea-946e-418bdaa55b61


Refactor jtreg_prep script (and dependent scripts)

The functionality added by https://github.com/AdoptOpenJDK/openjdk-build/pull/43 is useful and fulfills its purpose. On the back of the discussions that took place on the PR, we should consider the below:

make script similar in format as the sbin/build.sh
maintain consistency between the use of ${} and "${}"
any other tech debt that was left for resolution at this stage (refer to discussions on the PR)
adding missing documentation

#58 helps this issue partially

Closing issue as related PRs are merged


Filter external functions in ExportFunctionInfoScript

I am currently using the ExportFunctionInfoScript in order to export a list of function and address pairs, but I have noticed that the list includes external functions (e.g. functions in libc) and I was wondering if there is a way to filter out the external functions so that only functions directly in the binary are being exported to the list?

You can add a check in the script to skip external functions:
if (f.isExternal()) {
       continue;
}

Thank you! It turns out, my problem wasn't actually that it was printing external functions it was printing out all the thunk functions, so I just used the check for that instead.  Do you know why the compiler creates thunk functions for all of the external functions?

Typically the thunk functions are created so that the library can be dynamically linked, often lazily as needed.  Sometimes thunks are created to serve as trampolines, such as allowing a function call to perform an intermediate jump(s) to get to a function at an address is too large for an instruction to jump to directly.
https://en.wikipedia.org/wiki/Thunk


Faulty implementation of interval_time in keyword "Wait Until Keyword Succeeds"

The keyword wait_until_keyword_succeeds simply adds the interval time after the keyword has failed. This causes unexpected behaviour, if the desired interval time is short in comparison to the keyword runtime.
Therefore, I modified the keyword to measure the time between keyword execution and failure. The difference is then subtracted from the wait time to achieve the desired interval time (keyword runtime + wait time = interval time).
Furthermore, a warning will be logged whenever the desired interval time is shorter than the actual keyword runtime.
Signed-off-by: Oliver Schwaneberg<EMAIL_ADDRESS>

As I commented #3209, this would be a backwards incompatible change and it wouldn't even match the documentation of the keyword:

retry_interval is the time to wait before trying to run the keyword again after the previous run has failed.

How to interpret the timeout could be made configurable, though.
The change would also need tests and documentation changes.

As I commented #3209, this would be a backwards incompatible change and it wouldn't even match the documentation of the keyword:

retry_interval is the time to wait before trying to run the keyword again after the previous run has failed.

How to interpret the timeout could be made configurable, though.
The change would also need tests and documentation changes.

As I commented #3209, this would be a backwards incompatible change and it wouldn't even match the documentation of the keyword:

retry_interval is the time to wait before trying to run the keyword again after the previous run has failed.

How to interpret the timeout could be made configurable, though.
The change would also need tests and documentation changes.

Don't have time to look at the changes in detail, but on a very quick look I saw two issues that need to be fixed:

Tests. This functionality definitely needs them. See atest/README.rst for details how to create them.
A note somewhere that this feature is new in RF 3.2.

I added two acceptance tests in wait_until_keyword_succeeds.robot and created a basic release note file for RF 3.2a1 to document the new feature. Please let me know if you want it at another place or with a longer description.

I'm not sure why this PR wasn't re-reviewed two years ago. May have been summer holiday season and then the PR and the related issue #3209 just got buried under other PRs/issues in this tracker. Anyway, the PR looks pretty good but there are few things to change in the code and also the conflicts above need to be sorted out. If you @Schwaneberg are still interested in this PR and the issue, I can do a more thorough review. We can either get this into RF 4.1 in July or to RF 5.0 planned for late 2021 or early 2022. If there's no interest anymore, I assume both the issue and the PR can be closed.

Thank you for your review and all suggestions. I just pushed a new commit that addresses all topics you mentioned.

Thanks for the fixes and the PR in general! There are still few things to fix/enhance but I can handle them myself. This PR has been open for too long time already...


Orakl CLI Reporter watchman documentation

https://orakl-network.gitbook.io/docs/orakl-network-cli/reporter#ephemeral-state


[resharper chocolatey powershellgallery nuget myget] Standard name in nuget v2 downloads badge

Downloads badges based on NuGet v2 have its service name as a badge name.

Other downloads badges (like Nuget, MyGet) uses "downloads" as a badge name. This PR changes name of NuGet v2 based downloads badge to "downloads".

Warnings

:warning:

This PR modified helper functions in lib/ but not accompanying tests. That's okay so long as it's refactoring existing code.

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @platan!

  Generated by :no_entry_sign: dangerJS


Write a Haskell program to find perimeter of a square

Description
Write a Haskell program to find perimeter of a square
Perimeter of square = 4 × Side
Side : 2

Perimeter : 8

How to contribute

Save the solution in program/find_perimeter_of_a_square.hs file
Add find_perimeter_of_a_square.hs file in find-perimeter-of-a-square folder

!assign


PPO episode ends before num_steps

I just wanted to understand what happens when the episode ends sooner than num_steps.
I was going through the code and the env (for which done=True) doesn't appear to be reset.
Shouldn't that be happening? For example when you have just 1 process and the episode ends.

Thanks.


Added the 'x5t' claim to the JwtHeader when the Security Key used is an X509SecurityKey.

Fixes #908.

@leastprivilege thanks for the heads up. Will think about this.

I would rather prefer you fix your old libraries to use kid. And we can get rid of x5t altogether.

@leastprivilege are you asking for a new version of 4x?

@leastprivilege i agree that x5t is a carryover from legacy.
So if I understand, if 4.x would use the 'kid' you would be fine.
You may want to think about
header["x5t"] = Base64Url.Encode(cert.GetCertHash()));
rather than
header.Add("x5t", Base64Url.Encode(cert.GetCertHash()));

@leastprivilege thanks again for point this out. This would have been a runtime breaking change for users.
We have decided against taking this change.

@leastprivilege this is causing problems with users that are expecting the x5t, some IdentityProviders are expecting the x5t in the ClientCredentials flow.
We will need to add it back.

Some?
Then why not add it manually in this case like we do - instead of adding it by default?

@leastprivilege well to be honest, anyone calling into AAD using OAuth ClientCredential flow. AAD doesn't consider the kid, only the x5t.
I am thinking of reintroducing X509SigningCredentials, ctor(X509Certificate2). The JwtHeader will recognize that and add the x5t in this case.
Would that work for you.
I you have a chance, would love your opinion on our new model for JSonWebToken in Microsoft.IdentityModel.Tokens.Jwt. We are moving towards simplifying on consuming and returning JObject. It's early, we want to start small and build up the correct API's.

We re-introduced X509SigningCredentials that adds x5t


Try a little harder to find a title for a stream

When streaming from a Tune In Radio station, anyway,
there might be nothing in the streamcontent but
still a title element.

Coverage decreased (-0.24%) to 53.73% when pulling 38117fcda3219902f6ce85924263c6cad4910e75 on poirier:stream_title into 6b0979cf957c2870a980b55bcb463bd7352597dd on SoCo:master.

Seems reasonable. There are a few lines that are too long, which triggers a pylint error. Can you please fix those up?

Lines shortened. (Sorry, used to 100 char lines.)

Coverage decreased (-0.05%) to 53.92% when pulling 1e50fd7f22c7b2dfee72f93ff14d00552df15480 on poirier:stream_title into 6b0979cf957c2870a980b55bcb463bd7352597dd on SoCo:master.

I think this looks good - worth getting in before 0.11 is released https://github.com/SoCo/SoCo/issues/278
+1


PHP7

It seems the generation of extensions from PHP5 changes dramatically in PHP7 due to the modifications to internal structures.
As I see it will require:

A separate kernel specifically focused on PHP7
A new memory manager designed to address the reference counting changes in PHP7
A new approach on generating method/function calls
A new approach on reusing zval variables
It would be hard to have a common generated code for both PHP5 and PHP7

Also, It seems that the amount of changes is larger than I expected previously and I think these changes will take many hours and it's something we have to address as soon as possible before move forward.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/14956774-php7?utm_campaign=plugin&utm_content=tracker%2F280146&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F280146&utm_medium=issues&utm_source=github).

Old issue https://github.com/phalcon/zephir/issues/756

@andresgutierrez

A separate kernel specifically focused on PHP7
A new memory manager designed to address the reference counting changes in PHP7
A new approach on reusing zval variables
It would be hard to have a common generated code for both PHP5 and PHP7

Totally agree on this points, as that matches the result of experiments I conducted.

A new approach on generating method/function calls

This actually has not changed very much, what problem do you see here?
I think another issue will be that currently we have localOnly and "global" (heap) zval's,
which result in different handling on the compiler side (PHP).
Any idea how to implement the different code generation for PHP7?
It seems like it will require huge amounts of changes (and removing some duplicated code)
to achieve that. (And therefore could easily result in a mess with very much if's)
Another interesting example for that is basically the StringsManager, which creates C code for concatenation, which also has to be changed for PHP7 (zend_string, no ``zval **`).
Some examples of kernel functions can be taken from my first/second experiment,
while it should only be used as reference, since some implementations are kept
too simple to not consume all my time by porting that complexity
(e.g. array multi update in first experiment).
I still think the most important part will be to find a good way to implement the code generation
for PHP5/PHP7 in the compiler, which will require a smart way to solve it, since you basically
can not leave many places untouched...

:+1:

In my opinion you can abandon support to old php version and make more efforts to support PHP 7. Everyone who will use Zephir, probably can install new php version to.

@andresgutierrez
What do you think about the approach in 12bbcba4a014f90c664498c6ce57a25fe5500c2d
Basically it's a separate bare kernel, which is used when compiling using PHP7,
with a basic "skeleton" needed to compile an empty extension,
which should allow porting feature by feature.
On the compiler side we can use Utils::isNG() to check for PHP7.

@steffengy I like your approach, however I think now is the right moment to refactor the compiler to allow more than one output backend so we can generate extensions for php5, php7 and probably generate plain php in the future

@andresgutierrez First Alpha is announced for Jun 11 2015
https://wiki.php.net/todo/php70#timetable
so what's the further course of action?
Also is there already a plan of what's to be done to support multiple backends?

The main idea is, create a directory called: Library/Backends
Library/Backends
     ZendEngine2/
       Expressions/
         Operators/
         Statements/
         Backend.php
     ZendEngine3
       Expressions/
         Operators/
         Statements/
         Backend.php
     PHP
       Expressions/
        Operators/
        Statements/
        Backend.php
     ...

For the kernel:
    kernels/
      ZendEngine2/
            memory.c
            ...
      ZendEngine3/
            memory.c
            ...

So, instead of generating the code, we ask a "backend instance to do it":
//Before
$codePrinter->out('ZEPHIR_CPY_WRT(' . $variable1->getName() . ', ' . $variable2->getName() . ');');

//Now
$this->backend->genCopyOnWrite($variable1, $variable2);

Is the goal there then to completly abstract code generation to method calls
or will backend code
(for example ZendEngine2/Statements/LetStatement) still output code directly
(except for stuff that's needed as abstraction like genCopyOnWrite)
I guess the plan is to abstract it completly leading to probably more readable code?
(Easier changes than replacing a string everywhere)
Won't total abstracting of operators/statements generate much "common" (->code duplication) code between the backends?
Or is the plan to have a "root" level of Statements/Operators which only delegate output specifc tasks to the backend, which probably makes more sense (keep the main execution logic, which should be equal for each interface, at a root level)
Also what's the schedule on this?
It seems like a very extensive refactoring operation, which will probably need very much time.
Is this operation already in progress or is this only a plan (or to be planned to be exact) for now?

Generating plain php from Zephir has been discussed since the early days of Zephir development. I agree with Andres that a refactoring of the compiler will provide tremendous functionality.
One output will be php5, one 7, one C and who knows what else. ;)

@niden +1
According to different output types, choose different generation engine, it can meet the demand of the current and future development.

I also agree that refactoring the compiler generally is very much needed.
(not only in that regard)
With the first alpha of PHP 7 released, this is still something that should
be started as soon as possible, requiring a clear plan for implementation.
Currently it seems like this is in a kind of "postponed" state, which
also delays the actual PHP7 support in a near future.

@andresgutierrez
What do you think of 6eb1503e5b6f460a33b44eee75a2fdbcb82d0709 ?
Changes include:

Template/Kernel files dependant on backend
Active backend detection (PHP5->ZE2,PHP7->ZE3),
if no backend is specified via --backend ZendEngine2 for example
Bare kernel for ZE3 and basic templates

Will zephir generate generates separate ext folders for both PHP5 and PHP7?

@hylent
In that draft it will generate the ext folder according to the active backend.
So if you decide to compile for PHP7 you would logically get that kernel as output.
Anything else also does not make very much sense since the generated
code will anyways not be very compatible with other kernels.

@steffengy Yes, this is the idea I have, would you mind submit a PR?

:+1:

I used zephir to build phalcon with php7, zend_uint and zval_object_value are not supported now, please change they to zend_ulong and zval_object.

@finchcn
What are you talking about?
zend_uint is bc'ed ages ago due to 2750ecb3bcc090f13373e0d1965af88b9fd438dd (main.h)
zval_object_value is not even used anywhere.
The issues you mention have nothing to do with this PR and probably
are due to phalcon's C components, which also have to be updated,
to compile it for PHP7.

@steffengy
zen_uint is used in zephir/kernels/ZendEngine3/globals.h line 61.
zend_object_value is used in zephir/Library/ClassDefinition.php

@finchcn
Sorry to say that but you have no clue what you are talking about.
You are looking at regular zephir sources and mentioning old issues
here and frankly wasting my time.
zend_uint is defined by zephir, so it's no problem, as mentioned above.
zend_object_value is not used in ClassDefinition, where you probably
ignorantly have not checked my PR but the current zephir sources.
( https://github.com/steffengy/zephir/blob/ng-refactor2/Library/ClassDefinition.php )
Please refrain from commenting here, while using the wrong sources as reference.

Hello, is there any progress for PHP7 support in zephir?
Any beta or stuff that can be tested?

There is initial support available. Might work fine for your project or not at all

Which branch is the initial support in?

It's available in master.

Great. How would one compile the extension when using 7? Are there any options to set?

If you're using PHP7 to run zephir, it should work as with PHP5.
If not you have to specify the backend manually, as described in the related PR.

After running generate and build under Zephir, the compilation fails. Where do I specify a backend?

zephir generate --backend ZendEngine3 or zephir build --backend ZendEngine3
It's just another argument.
Be aware that zephir has to find PHP7 for build to work (since installing/building against PHP5 with a PHP7 extension can't work)

zephir build --backend ZendEngine3

gives me
Exception: Unrecognized action "ZendEngine3"

zephir build --backend ZendEngine3 works fine for me.
zephir build --backend=ZendEngine3 might solve the issue, but shouldn't be necessary.

=

makes a difference. I wanted to check if phalcon will build, but unfortunatly it does not.
I install my PHPs seperatly, but i can easily hack php and phpize to point to php7 directory.
Or at least this is what i saw in zephir/Compiler.php.
But anyways, enough spam, I hope you can make phalcon run on php7 soon ( seems to me its out of my league to help you out.. :( )

It's impossible that phalcon will build without modifications, since it uses C-code.

Andres seems very busy lately, hopefully he is on it.
I see a lot of packages across the web, almost ready with it. Waiting for salary to donate again to phalcon :D ( if it makes any difference )

I am very sorry for the spam, but because i am super exited, and constantly checking Phalcon repository  for commits about php 7, do you think you can say a very rough date, @andresgutierrez ?

@Izopi4a  I think the progress of Phalcon + PHP7 must be followed in the Phalcon repository. There are couple of C sections that must be migrated to PHP7.

yes, i have this [https://github.com/phalcon/cphalcon/branches] on bookmark and i am checking it like 20 times per day :-). I was just curious if you can just say a very rough estimation. Unfortunately i suck with C, but maybe you can tell if you need any help with some parts, and I will do my best to help you out.

Well PHP7 finally realased, i hope you will work now more on Zephir and phalcon to be avilable on php7 too :).

zephir atleast works for some cases with PHP7.
closing this now, since this is anyways not used anymore to track any issues.
If you experience anything which doesn't work for PHP7, please open a separate issue.

Wow i was so close to PHP7.0.3 support got it compiling just fine it installed the module but when i restarted php7.0-fpm it just hung with the module enabled and chewed up 100% cpu but it didnt log anything in any of my logs even the syslogs so i had no idea what was going on it only took 3 file edits :) but i suppose i can update at a later date :( i would love to hear from anyone who has managed to get it working i could get the error log if anyone needs it


Tech Reborn crash with Advanced Reborn in 1.20

Describe the bug
When only using Tech Reborn and Advanced Reborn the game crashed with reason "The game crashed whilst initializing game
Error: java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'advanced_reborn'!"
Steps to Reproduce
Steps to reproduce the behavior:
1.Make a new 1.20 Fabric 0.14.21 modpack in Curse Forge Launcher
2. Add Tech Reborn, Advanced Reborn and Reborn Core
3. Start and see
Environment:
Minecraft: 1.20
Mod Loader: Fabric 0.14.21
Logs
https://pastebin.com/bhuuavsi | Latest Log
https://pastebin.com/yzsgpUJx | Crash Report

Oops, CC: Restitched became CC: Tweaked. thank you

Fixed


[DRAFT] wgpu v0.20.0

I originally wanted to try and play with webgpu, so I decided to try and bump wgpu to v0.20.0 which requires a winit bump too. Draft PR to bump wgpu and egui stuff to v0.20.0 however there are some issues I haven't reconciled yet.
I actually sadly ran out of time and hope to be able to pick this back up, however when I will be able to do so, I don't know, so I've made a draft PR instead for now as a starting point.

[ ] i have yet to do the jgenesis-gui and jgenesis-cli parts
[ ] can no longer do send + sync when atomics are enabled with wgpu with the webui
[ ] only web has been tested
[ ] when building without atomics, Im getting an issue at surface.configure(&device, &surface_config); in renderer.rs not sure if this is related

Error in Surface::configure: Validation Error

Caused by:
    Both `Surface` width and height must be non-zero. Wait to recreate the `Surface` until the window has non-zero area.

As an FYI, the reason I'm currently on older versions of wgpu/winit/egui is because of an annoying dependency issue related to raw-window-handle and sdl2. wgpu and winit have moved on to raw-window-handle 0.6 while sdl2 is still on the incompatible 0.5. The web frontend doesn't use sdl2, but the native frontend does and the rendering code is shared. wgpu makes enough breaking changes between minor versions that it would be pretty unpleasant to support multiple versions simultaneously in the renderer.
It should be possible to upgrade everything across the entire project once this sdl2 PR is merged: https://github.com/Rust-SDL2/rust-sdl2/pull/1385
In the long term I'd eventually like to migrate the native frontend to use winit for windowing instead of sdl2. This is not a straightforward change unfortunately, but it would remove the dependency on sdl2's raw-window-handle implementation and make it much easier to keep wgpu/winit/egui up to date. (I do still want to use SDL2 for audio and joystick/controller inputs, and thankfully those parts of SDL2 are usable without an SDL2 window.)

yeah I initially wanted to touch on this since I was running into issue since no matter what I did with wgpu v0.18 I can't manage to get webgpu to init, I was able to get it to initialize with v0.20 but ran into the bugs I described above. I don't see any other obvious way to get webgpu to somewhat work without bumping wgpu

The linked sdl thing has been merged, but I have yet to find a simple way around the atomics issue

Thanks for pointing out the sdl2 0.37 publish!
From some local testing with these changes:
The project as a whole won't currently build with wgpu 0.20 because egui-wgpu and glyphon both still require wgpu 0.19 on their latest releases. Do you need 0.20 specifically or would 0.19.4 work for the time being? Looking at wgpu's release notes, it looks like the major improvements for WebGPU usability were made in 0.19.0 and 0.19.3:
https://github.com/gfx-rs/wgpu/releases/tag/v0.19.0
https://github.com/gfx-rs/wgpu/releases/tag/v0.19.3
The atomics feature is needed for audio to work correctly (it's required by the ring buffer for sending samples from the main thread to the audio worklet thread), so disabling it isn't really an option unless there's another way to make audio work. wgpu failing to build with atomics now is only because of wgpu::RequestDeviceError. I think it would be reasonable to change that RendererError variant to just stringify the error, maybe gated behind conditional compilation since this isn't an issue on native.
The width/height 0 issue seems to be caused a change in winit behavior from 0.28 to 0.29. I haven't yet figured out a good way to fix it though - with_inner_size/with_min_inner_size/with_max_inner_size don't seem to have any effect in 0.29, at least on web.
I might take a look at finishing up some of these upgrades myself later today because I'd like to get the native frontend on wgpu 0.19+ to pick up some bugfixes, and I'd prefer to upgrade the whole project at once so that the web build isn't broken.

I just pushed a change to master that upgrades wgpu to 0.19 and winit to 0.29 along with the other libraries that were held back by sdl2 / raw-window-handle.
It looks like the API changes between wgpu 0.19 and 0.20 are minor - the only change that affects this project is the addition of the pipeline_options field in the render pipeline descriptors. I would be fine with supporting both versions via a feature or something if you do need wgpu 0.20.
The width/height 0 issue was indeed caused by a breaking change in winit 0.29, specifically this one I think:

Breaking: On Web, the canvas size is not controlled by Winit anymore and external changes to the canvas size will be reported through WindowEvent::Resized.

With winit 0.29, the canvas is initialized with a size of 0, and then it automatically adjusts its size based on what wgpu requests. Applications control the size through the wgpu::SurfaceConfiguration.
Attempting to set the size through winit has no effect, and as such having the renderer set the surface size based on the window size no longer works on web. I changed the API a bit so that the frontend passes through the window size (which is now constant on web) instead of the renderer fetching the size from the window handle.
I also had to make some small changes to the event loop handler to fix some really poor frame pacing and occasional freezing after upgrading to winit 0.29. The handler now sets the control flow to ControlFlow::WaitUntil(now() + 1ms) instead of ControlFlow::Poll whenever it's too soon to generate the next frame. It now seems to work better than it did before though.

I don't think there was anything in specific that needed v0.20.0, so i'll go ahead and close this! thanks a bunch!


variable 'producer' is not used in java 8 version code of "Getting started"

In the java 8 version of class LongEventMain of the "Getting started" page, the variable "producer" is not used. Is it redundant?

Yes it is redundent, fixed.


Missing "assembly/{refgenome}_full.fa"

Thank you for sharing your code!
I am taking the snakemake pipeline for a spin, and it is not obvious what the "assembly/{refgenome}_full.fa" supposed to be. From scanning the code briefly, I thought this would be something created by the "sv" subworkflow, however, the mash sketch command fails in the dry run because it can't find the "assembly/{refgenome}_full.fa" file.
Thanks again!

Hi this file is used later for transcriptome and WGS mapping that I appended the SV into these full reference genome. You can just create this file with touch assembly/UCD.fa if you work with cattle and the SV part will run

Thank you for the quick reply, but that didn't help the case:
$ snakemake -j 8 -s ../tools_and_scripts/bovine-graphs/snake_graph.py
localrules directive specifies rules that are not present in the Snakefile:
	analyze_gene_model
	create_extended_ref
	merge_expression

Building DAG of jobs...
MissingInputException in line 171 of /localscratch/ysouilmi/dog_genome_graph/tools_and_scripts/bovine-graphs/subworkflows/sv_analysis.py:
Missing input files for rule create_full_ref:
assembly/canFam3_full.fa

$ tree workdir/assembly/
workdir/assembly/
├── basenji1.fa
├── basenji2.fa
├── canFam3.fa
├── canFam4.fa
├── canFam5.fa
├── canFam6.fa
├── dhole.fa
├── dingo_cooinda.fa
├── dingo_sandy.fa
├── wolf1.fa
└── wolf2.fa

0 directories, 11 files

And here's the content of the config file:
$ cat config/config.yaml
workdir: /localscratch/ysouilmi/dog_genome_graph/minigraph_pipeline/workdir

# Setting for SV analysis
# gff always relative to the workdir

gffinput: refs/canFam3.ensGene.gff

# Setting for rna-seq analysis
rna_seq: False
reference: canFam3

# diamond protein db for blast
refprot:  /localscratch/ysouilmi/dog_genome_graph/minigraph_pipeline/workdir/refs/diamond.db
rna_basedir: /localscratch/ysouilmi/dog_genome_graph/minigraph_pipeline/workdir/rnaseq_data
rna_anims:
  - SRR7334235_RNASeq_of_dingo_adult_female_ovary
  - SRR7334236_RNASeq_of_dingo_adult_female_blood
  - SRR7334234_RNASeq_of_dingo_adult_female_muscle

# setting for wgs analysis
dna_seq: False

I tried running that with rna_seq set to False and True.

Hi based on the log file, it is caused by
Missing input files for rule create_full_ref:
assembly/canFam3_full.fa

So you should provide it, as I mentioned you can have the dummy one if you do not yet want to have the RNA analysis with touch assembly/canFam3_full.fa and provide full reference genome of canFam3_full.fa (including unplaced contig) in the assembly folder with the name of canFam3_full.fa.
Hope this helps.

So if I understand correctly, assembly/{refgenome}.fa is the primary assembly with only the main contigs (chromosomes), and assembly/{refgenome}_full.fa is the full assembly with the unplaced contigs and any additional alt/decoy contigs?

Hi
Yes that's correct, in our pipeline we only construct graphs from autosomes, but we combined the non-ref sequences with the full genome for the transcriptomic and variant analysis. I suggest to read our paper for further details

thanks a lot!


Printing documentation broken

The printing of documentation pages (http://v4-alpha.getbootstrap.com/layout/grid/ for example) is broken. I tried printing it on paper, and it cuts the page off. I then tried it with a PDF printing, and same issue (see attached). It seems to negative margin the pages, so they get cut right down the middle, so are unusable.
grid.pdf

As there are also issues in IE11 relating to printing, closing this issue in favor of https://github.com/twbs/bootstrap/issues/21092


Update for Bevy 0.14

Hi! Just passing to update this not-very-much in time  for the Bevy Jam #5.
All but the fishy examples work, but that has to do with the RON file.
Also, no updates for the bevy compatibility table.
I'll try to finish the work, but to be honest, I'll switch my focus to the jam, so maybe after the submitting the project.
Hope this is a good first PR!

Didn't see your PR, and actually did it as well :( but anyway,I updated the .ron file and it works for me(Changed the extension to load it here).
fishy_layer_data.txt

Thanks for the update! Been moving this past month


Allow custom file types for source media files

Hello rprieto, thank you for developing this module. It is neat and handy! For my personal purpose, I had to add options to it so that the gallery can include custom file types such as webm and ogg. I guess other users will also find these options useful.

Thanks a lot for the PR, ogg and webm support is a great idea. Ideally thumbsup should support all media formats, so I'll add them in by default (and ogv too). The rule should be "if it's supported by exiftool and ffmpeg then it should work out of the box".
Where you're not lucky is that I just extracted a big part of thumbsup to https://github.com/thumbsup/node-thumbsup-collection, where all the globbing/extension logic lives.
Are you happy if I add these in manually for now? It will be part of the v2.0.0 release.

My suggestion (as can be seen in the commit) is to avoid hardcoding all supported file types. In my case, I don't care about exif and my target visitors use Chrome, so it's ok for me to include mkv files in my gallery even though they are not standard HTML5 videos. I will be happy if you can add more flexibility to the design of node-thumbsup-collection in this respect ;-)

Thanks. Let me try to understand the exact use case. Currently thumbsup puts every file through ffmpeg or graphicsmagick to generate thumbnails and web-friendly sizes. This means it really only supports photos and videos, for example if you specify --photo-extensions=jpg,txt it would generate an error when picking up a txt file.

Would it be enough if it always processed all known formats? For example:

const PHOTO_EXT = ['bmp','gif','jpg','jpeg','png','tif','tiff','webp']
const VIDEO_EXT = ['3gp','flv','m2ts','mkv','mp4','mov','mts','ogg','ogv','webm']

If you want to be able to specific other extensions, what would they be?
Is your requirement that you want certain files to go through unprocessed, e.g. the mkv file displayed as-is (not resized, not converted to mp4). Currently all files are processed/resized and converted to JPEG, unless the user clicks "Download original" which obviously downloads the original :smile:

Sorry it's my mistake. I was thinking that videos are displayed as-is, but the fact is thumbsup converts everything to mp4/jpg. So it is ok to hardcode all file types supported by ffmpeg/graphicsmagick. Thank you for your response!

No problem. Apart from generating the 100x100 thumbnails for both photos and videos, the main reason it processes them is to create the "large" size which is more web-friendly, e.g. ~200kb instead of 3Mb for a photo, or 10Mb instead of 100Mb for a video.
If your use case is that

you only care about local browsing, or your users always have fast internet
you know they will be on Chrome which supports many formats like mkv, and you know you won't have any non-supported files (e.g. bmp)

Then we could look at another feature which is to skip the "large" generation altogether, and always use the originals. This would make building the gallery faster. It would depend on #54 happening, to make that much easier to implement.


Burnt Stew does not count towards "Burnt" counter in Cooking plugin

Describe the bug
Burning a stew does not count as burning food in the Cooking overlay.
To Reproduce
Steps to reproduce the behavior:

Enable Cooking plugin
Burn a stew
Note that the Burnt counter has not incremented

Expected behavior
Burning a stew should increase the burnt items counter.
Environment (please complete the following information):

OS: Debian
RuneLite version: 1.5.27
Launcher version: 1.6.2

Looking into this, but my cooking is too high to burn stews and I don't have an alt.
What message in the chat window do you get when the stew is burnt?


chore: bump go version to 1.16 in ci build

Signed-off-by: Lance Ball<EMAIL_ADDRESS>
Changes

/kind chore

Fixes #

Release Note

Docs

/approve
/lgtm


Microsoft.Cache/redis/linkedServers: Redis cache with geo-replication enabled is not idempotent.

Resource Type
Microsoft.Cache/redis/linkedServers
Api Version
2022-06-01
Issue Type
Resource fails to deploy
Other Notes
When deploying a linked server to a Redis cache it successfully sets up geo-replication.
When re-running the bicep template without changing the template however, the response returns with an error message instead of a successful deploy: BadRequest: Cannot create geo-replication link, since this cache is already linked to another cache.
Bicep Repro
`@description('Optional: The location for the Azure resource.')
param location string = resourceGroup().location
@description('Optional: A value indicating whether case geo-replication needs to be setup.')
param EnableGeoReplication bool = false
@description('Optional: The primary location for the Redis cache (in case geo-replication needs to be setup).')
param PrimaryLocation string = 'westeurope'
var _location = toLower(replace(location, ' ', ''))
var _primaryLocation = !empty(PrimaryLocation) ? toLower(PrimaryLocation) : 'westeurope'
var _isPrimaryRedisCache = _location == _primaryLocation
var _primaryCacheName = toLower('redis-test')
var _locationSuffixes = {
westeurope: 'weu'
northeurope: 'neu'
}
var _deployToSecondaryLocation = _location != _primaryLocation
var _cacheName = _deployToSecondaryLocation ? '${_primaryCacheName}-${_locationSuffixes[_location]}' : _primaryCacheName
resource RedisCache 'Microsoft.Cache/redis@2022-06-01' = {
name: _cacheName
location: _location
properties: {
enableNonSslPort: false
minimumTlsVersion: '1.2'
redisVersion: '6'
sku: {
capacity: 1
family: 'P'
name: 'Premium'
}
}
}
resource PrimaryRedisCache 'Microsoft.Cache/redis@2022-06-01' existing = if (_enableGeoReplication && !_isPrimaryRedisCache) {
name: _primaryCacheName
}
resource LinkedServer 'Microsoft.Cache/redis/linkedServers@2022-06-01' = if (_enableGeoReplication && !_isPrimaryRedisCache) {
name: _primaryCacheName
parent: RedisCache
properties: {
linkedRedisCacheId: PrimaryRedisCache.id
linkedRedisCacheLocation: _primaryLocation
serverRole: 'Primary'
}
}
output redisName string = RedisCache.name`
Confirm

[X] I have read the troubleshooting guide and looked for duplicates.

Linking this issue to https://github.com/Azure/bicep-types-az/issues/1760, https://github.com/Azure/bicep-types-az/issues/1710 and https://github.com/Azure/bicep-types-az/issues/1458 as these issues seem similar.

Additionally I've noticed that if you add other deployments, e.g. a role assignment for an existing managed identity or a private endpoint or diagnostic settings that you need to make sure that the linkedServer deployment is dependent upon these so it comes in last, as otherwise you get the error message described in https://github.com/Azure/bicep-types-az/issues/1760


How to add export to PDF and Excel

Hey,
I cant find an example of how to enable the export to PDF/Excel options as demoed in Northwind.
Thanks!
Andrew

See source and there is a topic wiki


CodedOutputStream: No unbuffered option

I'm developing a network application that uses protobuf to serialize and de-serialize messages that mostly consist of proto3 bytes fields. Since my application serves as a middle-layer to other applications, I would like to use as few copy operations during (de-)serialization of the messages with special focus on the large bytes-type payloads.
I already use the carllerche_bytes feature to achieve performant deserialization, but for serialization, there is no support for zero-copy serialization in the CodedOutputStream, since it always creates a copy in the internal buffer before flushing.
More explicitly, the CodedOutputStream::write_raw_bytes() function copies bytes to the internal buffer and CodedOutputStream::flush() calls CodedOutputStream::refresh_buffer to flush the internal buffer. When I provide some Message, that mostly consists of a large bytes field, with a Write-trait-object to serialize to, a buffer will always be created to copy this possibly very large (multiple kB) into the buffer before sending the data to the provided writer. This design prohibits me to implement network buffering myself after the serialization without creating a second copy of the transmitted bytes.
Would it be possible to provide some unbuffered CodedOutputStream implementation? I would also contribute it myself, if you would be interested in having such a feature in this crate.

Fully unbuffered CodedOutputStream will be very slow, because writing one byte without buffering would be slow.
And CodedOutputStream already skips buffering if bytes to write are larger than buffer size.
It is possible to do following optimizations though:

use Write::write_vectored to combine refresh_buffer and write in single operations for large bytes
add an option to control buffer size
(and if the buffer size is zero, it will be unbuffered, but it will be slow)


circuit.draw() with setting set to mpl does not draw first time it is called.

Information

Qiskit Terra version: 0.9
Python version: 3.6
Operating system:

What is the current behavior?
circuit.draw() with setting set to mpl does not draw first time it is called.
Steps to reproduce the problem
If I follow and set it to mpl

the following code

does this the first time

and I have to rerun it to get the figure.
What is the expected behavior?
make it draw the first time
Suggested solutions
I think the figure is not saved or something.

If this is in a notebook, are you doing
%matplotlib inline
Or
%matplotlib notebook
At the top?

let me try. I always forget that :-)

thanks @nonhermitian


Error getting Storage Account from ID value stored in a Variable

Description
Outline the issue here:
When i try to pass the id variable of the value: "premiumDataDiskStorageAccount" from a devtest Lab, to my storage account show --id it returns:
az storage account show: error: argument --ids: invalid ResourceId value: '"/subscriptions/XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX/resourceGroups/iXXXXXXXXXXXXXX/providers/Microsoft.Storage/storageAccounts/XXXXXXXXXXX"'
this is the script part:
declare labstorage=$(az lab get --resource-group XXXXXXXX --name XXXXXXXXXXX --query "premiumDataDiskStorageAccount")

az storage account show --id $labstorage

when i enter the same storage ID directly into the line, it returns the expected values:
az storage account show --id "/subscriptions/XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX/resourceGroups/iXXXXXXXXXXXXXX/providers/Microsoft.Storage/storageAccounts/XXXXXXXXXXX"
Am I doing something wrong with the value declaration part?
Or when i try to re use it?
Environment summary
Install Method: How did you install the CLI? (e.g. pip, interactive script, apt-get, Docker, MSI, nightly)
Answer here: Interactive Script
CLI Version: What version of the CLI and modules are installed? (Use az --version)
Answer here:
azure-cli (2.0.17)
acr (2.0.11)
acs (2.0.15)
appservice (0.1.16)
batch (3.1.3)
billing (0.1.4)
cdn (0.0.8)
cloud (2.0.7)
cognitiveservices (0.1.7)
command-modules-nspkg (2.0.1)
component (2.0.7)
configure (2.0.10)
consumption (0.1.4)
container (0.1.10)
core (2.0.16)
cosmosdb (0.1.12)
dla (0.0.11)
dls (0.0.13)
eventgrid (0.1.3)
extension (0.0.2)
feedback (2.0.6)
find (0.2.6)
interactive (0.3.9)
iot (0.1.11)
keyvault (2.0.10)
lab (0.0.10)
monitor (0.0.9)
network (2.0.14)
nspkg (3.0.1)
profile (2.0.12)
rdbms (0.0.6)
redis (0.2.8)
resource (2.0.14)
role (2.0.11)
servicefabric (0.0.3)
sf (1.0.8)
sql (2.0.11)
storage (2.0.15)
vm (2.0.14)
OS Version: What OS and version are you using?
Answer here: MacOS Sierra 10.12.6
Shell Type: What shell are you using? (e.g. bash, cmd.exe, Bash on Windows)
Answer here: Bash

When running az lab get include --output tsv.
Then you should be able to pass that id value to the next command.
json output wraps the id in quotations.

Thanks @derekbekoe  , i used sed to take the quotations out and it worked, i'll try it with the output as tsv! thanks!


Add -wait parameter to debounce watched events

Addresses the following issues: #42, #43, #57, #103, #136
This is a rewrite of generateFromEvents that makes the following changes:

Only configs that have watch = true will be generated upon container events.
All configs will be regenerated when the events channel is reattached, rather than upon docker client re-initialization. (avoids missing out on events in between)
Each config with -watch now has its own separate channel. This is to enable individual debouncing parameters, specified with the -wait parameter. Syntax is min:max, e.g. 500ms:2s. This feature is referenced from hashicorp/envconsul

I've also added an integration test for generator.go that verifies all the new changes :)

A few more changes:

I made generateAtInterval and generateFromEvents aware of termination signals as well. (Replaced an apparently unused quit channel in generateAtInterval in the process)
Made the docker daemon reconnection logic more robust, so now it will survive a docker restart
Also added an internal retry flag for the generator which determines if it will attempt to reconnect if the events channel is closed, mainly for testing purposes.

this is awesome! This solves all my issues and would let me safely run docker-gen in prod and give me nearly zero-downtime deployments

Nice @gigablah! Thanks!


Throw exceptions for disallowed operations during flush

I've been playing around with the events system a bit more recently and found that the combination of the documentation being a little light and the UnitOfWork silently failing makes for some fairly challenging debug sessions.
I'd like to propose that the UnitOfWork throws exceptions when disallowed operations take place.  For example, you cannot persist a new document during a postUpdate as it will be simply lost - so rather than just losing it, it would be nice to get an exception telling the developer what they are doing wrong.

@araines thanks for bringing this up here after our conversion in IRC earlier today. I agree with you, the events are a bit complicated in this regard, which is why I'd go as far as saying that you shouldn't use them unless you know what you are doing. That being said, you can't know what you're doing unless we provide some good documentation.
I've tagged this issue as a documentation issue and will try to come up with some documentation about the events, especially:

What does the flush process look like: changeset computation, order of operation
At what stage are events triggered and what actions are permissible
Ideally, add some common use cases of what events are used for and indicate what should and should not be done.

Now, these are just some ideas, obviously we can use all the input we can get here. All of those caveats of the event system make a lot of sense when you've dealt with them for years, but for the average developer it may be quite confusing and overwhelming.

I'd like to propose that the UnitOfWork throws exceptions when disallowed operations take place.

Having previously experimented with functionality like that to prevent nested flushes (which caused issues due to excessive event handling involved) I'd caution against that, at least for now. There are just too many variables involved, and generally speaking, a single exception within the flush process or event handling process will cause all kinds of issues.

No problem - more than happy with documentation as the solution to this problem.  Whilst I don't mind diving through code of libraries to learn how they work, it's much nicer to be able to get going quickly based on the docs!
Also happy to contribute if I can be of service.

#1647 starts this process by throwing deprecation notices when calling flush from an event subscriber/event listener/lifecycle callback. These calls will definitely be removed in 2.0. I'll have to think whether it's feasible to apply the very same logic to persist and other calls 🤔

I'll have to think whether it's feasible to apply the very same logic to persist and other calls 🤔

I'm not sure whether it's needed, other events are quite safe to be called from one another and removing other documents while removing one is quite handy (or am I misunderstanding the direction?)

Nvm, just saw https://github.com/doctrine/mongodb-odm/pull/1647#issuecomment-333353171


[1.15 HOTFIX] creator/contributor identifier data encoding in metadata xml file is not correct

The current encoding of identifiers data can prevent resource creation or bag download

@pkdash can you please close this if it is fixed.

This has been fixed. Closing.


Kap is extremely slow to show capture selection (10 seconds)

macOS version: 10.12.1
Kap version: Version 3.5.4 (<IP_ADDRESS>0)
Steps to reproduce
Pressing Kap button in the menubar
Current behaviour
Takes 8-10 seconds before i can select an area to record. Also right click "About Kap" doesn't give any information or feedback.
Expected behaviour
In the earlier versions, this was extrememly fast, like less than 1 second, but it has been slower in later versions, like 3-4 seconds. It was still acceptable.
Workaround
No workaround, just have to wait.
It might have been worse since upgrading to Monterey but I'm not sure.

Same behavior on macOS Monterey 12.4 with Kap version 3.5.4 (<IP_ADDRESS>0).

Noticing this for a time now. It have made it almost unusable for me :/

Having the same issue in an Intel Macbook Pro with macOS Monterey 12.1.
I've tried going back to each version from the releases pages until one of them worked well. In this case I had to go back to v3.4.1.
v3.4.2 didn't work (likely the signing issues indicated in the release notes) and v3.5.0 already shows this problem. Looking at the diff, is fairly small, so maybe we can try manually reverting these changes to see if it makes a difference: https://github.com/wulkano/Kap/compare/v3.4.1...v3.5.0

Same issues here, macOS 12.4 w/ multiple monitors.
Downgrading to 3.4.1 as @carlosperate suggested has worked for me.

Can confirm 3.4.1 resolved the issue for me as well.

@carlosperate this contribution stands out to me in that diff, https://github.com/wulkano/Kap/pull/1051 -- upgrading electron & supporting different build target architectures
@codetheweb @sindresorhus can you see that impacting this behavior?

Cross referencing similar thread https://github.com/wulkano/Kap/issues/1088

Hmm, something must have changed in the new Electron version.
Might be related: https://github.com/desktop/desktop/issues/12978

Any idea if going to a newer version of electron would fix this? The latest is v19.0, and Kap is on 12.x. Going to new electron would also move this from Node 14.x to 16.x.

Possibly, but upgrading versions would require quite a few changes.

Yeah 3.4.1 seems to have worked. But how do I prevent it from autoupdating? I don't see any option like that, but I assume it did cause I never updated it manually.

I keep getting this error, which I guess is a good sign that it can't update :P

Unhandled Promise Rejection
Error: Could not get code signature for running application
at Server. (/Applications/Kap.app/Contents/Resources/app.asar/node_modules/electron-updater/out/MacUpdater.js:105:44)

To author: Please have auto updates as an option as well, to prevent future issues like this. Thanks :)

Same here. 10 seconds after clicking kap icon.

same 3.5.5, hard to use

Same here after upgrading from Catalina to Monterey (12.5.1). Probably also upgraded Kap currently on <IP_ADDRESS>5
Kap 3.4.1 is ineed much faster.

For anyone looking to download older versions, I went ahead and did this:

Go to https://github.com/wulkano/Kap/releases
Find the release you want
Click Assets and find your corresponding download file.
Download the file.
Run the download file.

All of the downloads <3.5.5 had a pop-up warning on my Mac. Proceed at your own risk by clicking the app while holding control. Follow the prompt and choose to open or not.

macOS version:    Monterey 12.6.1 (21G217)
Kap version:      3.6.0
MacBook Pro (Intel) + external monitor.
I've just updated from 2.2.0 to 3.6.0 and at first I didn't even realise what's going on: after clicking the menubar icon nothing happens, then there's a rainbow ball, then the whole screen becomes dark (I already get that it's a feature), the laptop starts to take off, according to the fans sound.
Version 2.2.0 was also not very responsive, but it was definitely more user-friendly.
I'll go try the 3.4.1 now.

macOS version: Monterey 12.6.1 (21G217)
Kap version: 3.6.0
MacBook Pro (Apple M1 Pro) + external monitor.
For me, v3.6.0 is not slow anymore. Everything looks good again 🙌

Kap 3.6.0 is better, but still takes 7-10 seconds from initializing a session to seeing the GUI appear

Trying to remedy this by updating Electron, by the way. It's extremely difficult, unfortunately.

Some for me, it has been extremely slow in the past months. Trying to downgrade as others suggest.

Same for me, unusable current version. Beachball of death.

Installed the latest version from the get kap homepage and am having this issue too.
Also tried downgrading as suggested with no luck.

v3.4.1 works for me!

Is there any progress on this issue? I'm still experiencing the same problem in the latest version 3.6.0. Every time I start recording, it's very slow, and it's causing a lot of inconvenience for me.

@timothyis This branch is working great for me on an M1 Macbook Pro, and Kap's back to being speedy again. I built it following the directions from contributing.md. Unfortunately, it doesn't look like the link to the dev builds is working anymore: https://kap-artifacts.vercel.app/main

3.6.0 extremely slow on MacBook Pro 16-inch, 2019 2,6 GHz 6-Core Intel Core i7 macbook. Ventura 13.5.2 (22G91)

@timothyis This branch is working great for me on an M1 Macbook Pro, and Kap's back to being speedy again. I built it following the directions from contributing.md. Unfortunately, it doesn't look like the link to the dev builds is working anymore: https://kap-artifacts.vercel.app/main

I have yet to pull/build locally, but if this addresses the issue, can it be PR'd, merged in?

I've fixed this, it's working nice and quick for me now, it was a few changes around not auto-closing windows all the time, and not triggering full rebuilds of context menus on every click.
If someone wants to clean it up to try to merge it, feel free! Kap is fast again now.
https://github.com/wulkano/Kap/pull/1208


[Bug]: There are some css inconsistencies with the rebranded OptionButton

Contact Details
No response
What happened?
Some workleap icons are not the good ones.
The workleap checked and hover background-color are too dark.
Link to the Figma designs : https://www.figma.com/file/KXrVZlFqD8mmlxJJhL5Jhn/❄-Igloo-Design-System?type=design&node-id=5250-1241&mode=design&t=dk8jA0VwkShVWd4O-0
Component
OptionButton
Component Version
0.2.0
Which browsers are you seeing the problem on?
No response
Mobile Device
No response
Relevant log output
No response

Thanks!


move diagnostic edmf to a separate file

Purpose

To-do

Content

[ ] I have read and checked the items on the review checklist.

bors r+


Package background image

Fixes #673
@mananwason @mariobehling Please merge

@mananwason Please merge this
The failing travis build is an issue of travis as this PR changes nothing in the android source code.

@the-dagger This is failing due to install exception. I have restarted it. Let it pass and then we can merge

Travis build failing because of no events on the server.


Add extra cerevisiae genes (deal with cerevisiae orthologs absent from sequenced strain)

There are a few curated orthologs to cerevisiae genes that aren't in the sequenced strain.  We don't get the identifiers for them from Ensembl/BioMart so we'll need to load them separately.
Original comment by: kimrutherford

duplicate of
https://github.com/pombase/pombase-chado/issues/823