New features (stateful browser, setitem, ...) from chamilotools

This PR is the result of moving code from https://gitlab.com/chamilotools/chamilotools to MechanicalSoup.
The two main features are:

StatefulBrowser, which keeps track of the current URL, page and form for you.

The ability to write form["name"] = value instead of form.{check,input,textarea}.

Because the StatefulBrowser keeps track of the current form, we can even write browser["name"] = value instead of form["name"] = value.

See what it allows in the new example.py. The main part is
browser.open("https://github.com")
browser.follow_link("login")
browser.select_form('#login form')
browser["login"] = args.username
browser["password"] = args.password
resp = browser.submit_selected()

It could get better testing and documentation, but I find the current state acceptable to be merged. It can be polished in-tree later.
I'll merge this soon if I don't get any comments/objection. Don't hesitate if you think anything's wrong or if you think something could be improved.
This is a resubmission of #53 which I closed by mistake and doesn't seem to be re-openable.

Nice. The original mechanize library was stateful http://wwwsearch.sourceforge.net/mechanize/

The original mechanize library was stateful http://wwwsearch.sourceforge.net/mechanize/

That's where I come from ;-). And that's what I missed when I moved to MechanicalSoup seeing that mechanize was unmaintained and Python2-only.


Time picker adjusts time based on timezone

Description
time_picker field would adjust the value displayed in the field based on OS/browser timezone ie. will not display the value stored in the DB, but treats that value as if it was UTC and the displayed value was local. Value in store is correct so it should be something related to frontend/flatpickr.js.
Steps to reproduce
Set your OS timezone to something other than UTC and compare DB stored value and the field.
Expected result
No timezone adjustment
Actual result
Value in field offset by timezone
Versions
Twill version:  2.3.0
Laravel version: 10

It's probably because in DatePicker.vue on line 152 date-fns.parse is called with date + 'Z' and format + 'X' so the parsed value would be offset. Removing the Z (and since it's not needed anymore, also the X from format) seems to resolve the issue.

The offset is intended to improve the user experience. Dates should always be stored in UTC in the database, but you don't want your users to have to do mental gymnastics with timezones when using date and time pickers in the CMS.
Are you reporting a bug with this implementation, or is it more that you were looking to disable that behavior?

To be honest, at the point when I opened this issue I was completely oblivious to the fact that it was good practice to store UTC dates in the DB - answering your question - it's not a bug if you followed best practices, so we might as well close this. But still it would be nice to be able to store and display datetime values independently from timezones. Do you have an idea if it would be possible currently?


PATCH?

So I notice that in the document of HTTP methods available, PATCH is not among them.  Is that still the case in the latest code?

PATCH is definitely implemented. I've been using it for quite some time.


upgraded to 1.1.1(Venus) lost my 2 SIT Coins.[BUG]

Describe the bug
Upgraded client from 1.0.2 to 1.1.1(Venus) as instructed re sink from scratch and now my 2 SIT coins are gone.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
Do an upgrade and not loose the coin in your wallet.
Screenshots

Desktop

OS: windows
OS Version/Flavor: 10
CPU: intel core i7

Additional context

Not a bug - there was a restart of the full network (snapshot was taken at the height of 16800).
Read the blog on Sitnetwork.org.


This site can’t be reached

I provisioned Elasticsearch. I got URL outputs of "domain_endpoint", "domain_hostname", "kibana_endpoint" and "kibana_hostname". But, I cannot hit any of these URLS. I got, "This site can’t be reached". Below is the code:
main.tf:

module "elasticsearch" {
  source                  = "git::https://github.com/cloudposse/terraform-aws-elasticsearch.git?ref=tags/0.24.1"
  security_groups                = [data.terraform_remote_state.vpc.outputs.default_security_group_id]
  vpc_id                         = data.terraform_remote_state.vpc.outputs.vpc_id
  zone_awareness_enabled         = var.zone_awareness_enabled
  subnet_ids                     = slice(data.terraform_remote_state.vpc.outputs.private_subnets, 0, 2)
  elasticsearch_version          = var.elasticsearch_version
  instance_type                  = var.instance_type
  instance_count                 = var.instance_count
  encrypt_at_rest_enabled        = var.encrypt_at_rest_enabled
  dedicated_master_enabled       = var.dedicated_master_enabled
  create_iam_service_linked_role = var.create_iam_service_linked_role
  kibana_subdomain_name          = var.kibana_subdomain_name
  ebs_volume_size                = var.ebs_volume_size
  dns_zone_id                    = var.dns_zone_id
  kibana_hostname_enabled        = var.kibana_hostname_enabled
  domain_hostname_enabled        = var.domain_hostname_enabled
  allowed_cidr_blocks            = ["<IP_ADDRESS>/0"]
  advanced_options = {
    "rest.action.multi.allow_explicit_index" = "true"
  }
  context = module.this.context
}

terraform.tfvars:
enabled = true
region = "us-west-2"
namespace = "dev"
stage = "abcd"
name = "abcd"
instance_type = "m5.xlarge.elasticsearch"
elasticsearch_version = "7.7"
instance_count = 2
zone_awareness_enabled = true
encrypt_at_rest_enabled = false
dedicated_master_enabled = false
elasticsearch_subdomain_name = "abcd"
kibana_subdomain_name = "abcd"
ebs_volume_size = 250
create_iam_service_linked_role = false
dns_zone_id = "Z08006012JKHYUEROIPAD"
kibana_hostname_enabled = true
domain_hostname_enabled = true

Hey @melissajenner22, got your email about this. This is likely due to your launching your ES cluster into a VPC, which makes it not available to the public. You must be inside the network to access the cluster and it can be frustrating.
I suggest checking out this documentation to get a better understanding of what you're running into: https://docs.aws.amazon.com/elasticsearch-service/latest/developerguide/es-vpc.html
Few ways you can solve this type of issue:

Port forward that address through a bastion host.
Use a VPN to access your internal resources like your ES cluster.
Use something like https://github.com/abutaha/aws-es-proxy to proxy connections into the cluster.

It's a real PITA 😉  Please let me know if you have any further questions here, otherwise feel free to close this issue out!

Hi @Gowiem, Thanks for your response. I did the following. And have a question.

Removed the line, allowed_cidr_blocks = ["<IP_ADDRESS>/0"] from the code.
Provisioned AWS Client VPN.
Login to AWS Client VPN.
Try to hit the page of kibana_endpoint. But, I got permission denied.
I logon to AWS console, navigate to ElasticSearch dashboard. For the Domain access policy, I chose Allow open access to the domain. See the policy below:

{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Principal": {
        "AWS": "*"
      },
      "Action": "es:*",
      "Resource": "arn:aws:es:us-west-2:123456789098:domain/abcd-domain/*"
    }
  ]
}

I am able to hit the kibana_endpoint. My question is, how to add the above policy via Terraform code?

@melissajenner22 you're looking for var.iam_role_arns + var.iam_actions. Try using iam_role_arns: * and iam_actions: es:* and you should be able to accomplish what you were able to do via the console.

@Gowiem , It works. Thank you very much!


add version accessors to c++ API

The OPAE C API has accessor functions to query the version information (see #191).
Similar functions need to be added to the C++ API.

This was implemented in #342


Write a Python program to find roots of quadratic equation

Description
Write a Python program to find roots of quadratic equation
Use the quadratic formula to find the roots of the quadratic equation
x = $(-b &plusmn \sqrt(b^2 - 4ac))/2a$
The input will be the coefficients of $x^2$, $x$, and the constant $c$.
Input  : 1 2 1
Output : -1 -1

Contributed by - @PavanKumarCB

How to contribute

Save the solution in find-roots-of-quadratic-equation.py file
Add find-roots-of-quadratic-equation.py file in program/find-roots-of-quadratic-equation folder

!assign


DCOS-54493 - Update DC/OS 1.13 reference to 1.13.2

High-level description

DCOS-54493 - Update DC/OS 1.13 reference to 1.13.2

@mesosphere-mergebot label ready for review

Uppsie just seeing that I duplicated the effort with dcos/dcos#5615.
However, in my downstream PR I have also updates CHANGES.md which seems to be missing here.

Closing in favor of  #5615 hope that's ok @orsenthil -- thanks!

Thanks, @jgehrcke !


Don't convert double hyphens to em-dash in a code block

Please don't convert
    ```
    --foo--
    ```

to:
<pre>
    --foo—<wbr>
</pre>

Syntax inside a code block is significant and should not be treated like text!

Indeed, I shouldn't.


Multitab dashboard throws access denied error in IE - 2018.3.3

Tableau Extensions team,
This is further dialog to issue initially reported under
Multi tab dashboard throw access denied error in IE #186
(Opening as fresh issue as updates to original thread hasn't yielded any response)
In response to above mentioned issue, it was mentioned that the fix for this IE issue is available in 2019.1 and also 2018.2.5 and 2018.3.2.
Our server environment got upgraded to 2018.3.3 last week.
[Tableau Server Version: 2018.3.3 (20183.19.0123.2221) 64-bit Windows]
However, we continue to hit the 'Access is denied' console error along with 'An Unexpected error occurred...' dialog box while switching tabs in multi tab dashboards with extensions.
(I assume 2018.3.3 should have this fix too if 2018.3.2 did)
I see that the page is not becoming unresponsive now (which is definitely good). I can continue working with the report once I close the error dialog. However, this is preventing us from rolling out the dashboard to user base since majority of end users consume via IE and it wouldn't be great for end user experience to have the errors popping up in between.
Could you please check into this and let me know if any additional setting/configuration is needed at server end for the fix to be fully functional.
Thanks.
Regards,
Arun Santhosh

Hey Arun,
I'm sorry for all of the difficulty you've been facing with this issue. There is no additional setting/configuration you need to adjust. I'm investigating this and it seems that although the original bug has been fixed, the same error is being thrown for different reasons - particularly in workbooks with multiple extensions. Can you tell me more about your workbook? How many extensions does it contain and are they on the same or separate worksheets? Hopefully I can get this solved for you soon.
Thanks!
Xavier

Xavier,
Thanks for getting back to me.
Requested details are given below.
1)Can you tell me more about your workbook?
It is a multi tab/dashboard work book running on top of tableau extract.
Extension is being used to identify the state of various filters and to set display level parameters based on it. I'm also using it to facilitate some dashboard wide drill up/down capabilities.
2)How many extensions does it contain and are they on the same or separate worksheets?
The workbook is using only one extension. This same extension is used in 6 dashboards of the workbook.
Also, I just now tried publishing a simple workbook using filtering extension supplied with tableau extension bundle.
Used this extension on three dashboards; each dashboard having a single worksheet each.
This simple setup gives me the reported 'Unexpected Error' dialog while switching between tabs on 2018.3.3 server env.
Hope this helps you recreate the issue at your end for troubleshooting.
Regards,
Arun Santhosh

Thanks for the extra details! I am able to consistently reproduce the issue in workbooks containing 1 or more extensions across multiple dashboards. I am working to fix it now, and I will update here with details on the release of the fix.

Xavier,
Thanks. It will be really helpful if you can address the fix for 2018.2.5 and higher versions.
We are on 2018.3.3. So, my priority is for getting it addressed for 2018.3.3.
However, there could be others out there who went by the 2018.2.5 fix reference in prior issue report.
Regards,
Arun Santhosh

Xavier,
Were you able to make progress on this? Please let me know.
Regards,
Arun Santhosh

We experience the same issue in our Tableau Server deployment with IE11, when using the Tableau provided Parameter Action Extension from the Gallery. Interestingly the error also occurs in Microsoft Edge.

Hey Arun, Carl,
Sorry for the delay. I've fixed the bug and am now working on verifying the fix in tableau server versions 2018.2, 2018.3 and 2019.1. The fix should be in the next maintenance release for these versions (and 2019.2), but I cannot confirm until I verify the fix has been effective.
Thanks for shining some light on this issue!
Xavier

I've verified the fix and can confirm that it will be in the next maintenance release for Tableau Server versions 2018.2.8, 2018.3.5, and 2019.1.2, as well as 2019.2. If you continue to see this issue after upgrading please do not hesitate to reach out.
Thanks!

Not fixed in 2019.2. I am still facing this issue.

@kartheekchk86 Hrmm, that's no good that our fix didn't seem to work. We will investigate. Is it possible to send us the workbook you were using to test? That would accelerate our investigation.

Hi Michel,
Sorry for the late reply. Please find the attached workbook. It is
happening for all the workbooks which has extension. And our IE version is
11.
And Tableau server version is 2018.3.0
Thank you,
Karteek
On Wed, Aug 7, 2019 at 9:29 PM Michael Kovner<EMAIL_ADDRESS>wrote:

@kartheekchk86 https://github.com/kartheekchk86 Hrmm, that's no good
that our fix didn't seem to work. We will investigate. Is it possible to
send us the workbook you were using to test? That would accelerate our
investigation.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tableau/extensions-api/issues/198?email_source=notifications&email_token=AMTWIO6F3VTQ6PJNGKOYOG3QDMPCNA5CNFSM4GY2LWEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZO6SQ#issuecomment-519237450,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMTWIOYVJ5M2WX75P5Y6LVTQDMPCNANCNFSM4GY2LWEA
.

--
Thanks & Regards,
Karteek Chalagondla,
+91 98 8521 8521.

Hi @Kovner Is it fixed only for 2018.2.8, 2018.3.5, and 2019.1.2 versions? or later than 2018.2.8?
Because I am using 2019.2 Desktop but the server is 2018.3.0.
Thanks,
Karteek

Hi @Kovner, I recently joined the group to post my comment.
We have the same case, where the Tableau report having Tableau provided Data Driven Parameter Extension in our Tableau Server (2018.3.3) deployment with IE11 erroring out with 'Permission Denied'
Once I close the error dialog is closed, the page is not becoming responsive. However, this restrict rolling out the dashboard to user base since ALL of our end users consume via IE and it wouldn't be great for end user experience to have the errors popping up in between.
Could you please check into this and let me know if any additional setting/configuration is needed at server end for the fix to be fully functional with current versions of Tableau (2018.3.3) and IE (11).

Hi @nashguy9, I guess this is not fixed in 2018.3.3. We upgraded our server to the version 2019.3 and now no issues.

Hi @kartheekchk86, thanks for the information.

Hi @kartheekchk86, thanks for the information.

Closing out based on age. If this is still an issue, please reopen with a comment on the latest status and we can revisit.
Also, in 2020 Tableau officially stopped supporting IE11, so these types of issues would probably not be fixed


Support disabling docker management

Moved to https://github.com/ritual-net/infernet-node-internal/pull/2


docs: Update comments for PyCon

Updating the 'Comments' section for the PyCon Conference to be a bit more descriptive.
In this pull request

I am providing an edit

Providing an Edit

The edit I am providing is to update the comments for PyCon to be more descriptive.

Perfect, thanks @smtaylorslc


Bugfix for DropdownField->validate (can't validate null)

Blog 2.0 errored when I tried to add a blog item without tag or category (on SilverStripe 3.2). Perhaps that's a bug in the blog module, but why not make this validator be able to handle null values.

hold on ... working on a better fix

Well, never mind... the issue was with installing a version of TagField (through Blog) that did not yet overwrite DropdownField's validate method... I guess the bug then is with Blog still requiring TagField 1.0.x instead of 1.1.x.


Matrix Chain Multiplication

We have many options because matrix multiplication is an associative operation, meaning that the order in which we multiply does not matter. The optimal order depends only on the dimensions of the matrices.
The brute-force algorithm is to consider all possible orders and take the minimum. This is a very inefficient method.
Implement the minimum multiplication algorithm using dynamic programming.

Input Format
The input file must contain the dimensions of the matrices each on a separate line.
Constraints
Input should consist of positive integers.
Output Format
The output file must contain the minimum number of multiplications needed to multiply the matrices as an integer.
Sample Input
20
2
30
12
8

Sample Output
1232

Explanation
The above input and output samples correspond to the multiplication of these four matrices:
A1 (20x2) * A2 (2x30) * A3 (30x12) * A4 (12x8)
note : read readme.md carefully

your code should pass HackerRank test case

please assign this issue to me

@almas33 read readme carefully

go ahead


Fix #14235

Fixes #14235
Cherry-pick of https://github.com/istio/istio/pull/14256
/assign @douglas-reid

@kyessenov: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
mixer/OWNERS [kyessenov]
pilot/OWNERS
pkg/OWNERS
security/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-framework-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-framework-local-presubmit-tests-master

prow/istio-unit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-framework-local-presubmit-tests-master

prow/istio-unit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test istio-unit-tests-master

prow/integ-mixer-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-mixer-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-framework-local-presubmit-tests-master

prow/istio-unit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test istio-unit-tests-master

prow/integ-mixer-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-mixer-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-pilot-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-framework-local-presubmit-tests-master

prow/istio-unit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test istio-unit-tests-master

prow/integ-mixer-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-mixer-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-pilot-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-security-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-framework-local-presubmit-tests-master

prow/istio-unit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test istio-unit-tests-master

prow/integ-mixer-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-mixer-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-pilot-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-security-local-presubmit-tests-master

prow/istio-presubmit.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test istio-presubmit-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-framework-local-presubmit-tests-master

prow/istio-unit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test istio-unit-tests-master

prow/integ-mixer-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-mixer-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-pilot-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-security-local-presubmit-tests-master

prow/istio-presubmit.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test istio-presubmit-master

prow/integ-galley-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-galley-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-framework-local-presubmit-tests-master

prow/integ-mixer-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-mixer-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-pilot-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-security-local-presubmit-tests-master

prow/integ-galley-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-galley-local-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
f85fb7d434d62f4f286b9b5de975549056b4c8b8
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-framework-local-presubmit-tests-master

prow/integ-mixer-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-mixer-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-pilot-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-security-local-presubmit-tests-master

prow/integ-galley-local-presubmit-tests.sh
570c26085efd8979dd3c59664b049781ef107461
link
/test integ-galley-local-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
f85fb7d434d62f4f286b9b5de975549056b4c8b8
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
f85fb7d434d62f4f286b9b5de975549056b4c8b8
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov We can run this in our test-cluster to verify it's fixed, if you want.

Thanks! That would be great if you can confirm this fix works.
The image is gcr.io/istio-testing/mixer:f85fb7d434d62f4f286b9b5de975549056b4c8b8
The test failure here is known and due to problems with helm install for redis.

gcr.io/istio-testing/mixer:f85fb7d434d62f4f286b9b5de975549056b4c8b8

Can confirm that istio-policy and istio-telemetry is no longer crashing when using the above image.

Thanks @Multiply !
@duderino can you please merge this backport into 1.1? The test flake is known and due to helm install redis/stable failing for unknown reasons.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: douglas-reid, kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [douglas-reid,kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Change Event.value from string to double

Minor fix to change the type of event.value. Also corrected some syntax in Profile model

Oof, accidentally deleted this before merging


feature request: Implement IntoExcelData for serde_json::Value

Feature Request
It would be pretty nice to be able to do sheet.write(serde_json::Value), pretty what needs to be done is just implement for all types of serde_json::Value. Should perhaps be put behind a feature flag.
Or even better, maybe IntoExcelData could even be implemented for anything that derives Serialize, or maybe a macro

Thanks. That is a good suggestion. I'll look into it.

Closing in favour of #61


Add ability to close/uninstall when installed

Description
How does one close a PWA when it's installed?  Is there a programmatic way to click on a button in the app to uninstall it?
Although full-screen is great for a PWA that's installed on a mobile device, it can be a pain to swipe to get the controls to close it, then to find the app itself and uninstall.  I was hoping there was an easier way.
Example
No response

Closing the application is very simple. As it is a browser window (or tab), window.close(); just works fine.
For uninstall process, it is a bit different. There is nothing to do on the browser side. It is all about the system host. I described the process on a dedicated documentation section: https://pwa.spomky-labs.com/how-to-install-remove-a-pwa#removing-a-pwa

window.close() works when it's in a browser, but isn't working for me when it's as a stand-alone PWA, installed.
I can check in a project that shows the problem.

Indeed, these are the instructions I was hoping to replace with an uninstall button.
Users will come to a gallery / museum, download the audio-tour, but after they leave they probably don't want it on their device.
--
Android
On an Android device, locate the PWA icon in your app drawer or home screen. Long-press the icon, then select the 'Uninstall' option. Confirm your choice if prompted. This will remove the PWA from your Android device.

Indeed, this is not possible anymore. On the page I linked above we can read "This method can only be called on windows that were opened by a script using the Window.open()".

Users will come to a gallery / museum, download the audio-tour, but after they leave they probably don't want it on their device.

I agree. Since users are not expected to come and use the app again and again, the option to install it becomes useless.

Yeah, maybe that should be my approach.
I like the full-screen option, but there's probably a way to do that in plain javascript.  As long as it pre-fetches the  images and audios (since the gallery doesn't have wifi throughout), it should work as expected.
The images and audios are all on s3, but they're from a database, so I think I need to use a feature you added for exactly that.  It's a twig tag, right?  I can't use the prefetch using the option in the pwa.yaml (since they come from a database), but I can use Symfony's weblink to create

And then create a resource cache rule to match https://voxitour.s3, right?

Yeah, maybe that should be my approach.

Yes! The fullscreen API (almost always available)

And then create a resource cache rule to match https://voxitour.s3/, right?

It should work (it does for other resource types such as the ones served by a CDN) but I never experimented it.
<link rel="prefetch" href="...."> is really simple. No headache.
The @pwa/prefetch-on-demand stimulus controller is another way to acheive that on a button click or any other action. I prefer this way as the user explicitly asks for the data to be downloaded when the link tag is silent.
Instead of an uninstall button, may a "I am done, clear the data" button could be fine. This button would remove the large assets (audios) and keep the core files (CSS, JS, pages...).

Closing as no activity.
Feel free to reopen if necessary


Changed mostrecent to MostRecent to fix loading

Looks like it's different for some installs. We need to check for both.


[ICD] Figure out dynamic ICD detection.

based upon chat with @bzbarsky-apple  We cannot browse text record..
Follow-up proposal:

Introduce the new attribute for LIT/SIT in ICDManagementCluster so that we can get the attribute change to know dynamic ICD via report.
To add some sort of subtype thing, similar to how we have _CM, because that can be browsed for, for example,  "BrowseNodes(DiscoveryType::kICD, filter);"
not yet figure out the scenario "if we need to detect switches in both directions and distinguish them from the device just going off the network"

@bhaskar-apple  what do you mean switch in both directions? It is SIT->LIT and LIT->SIT, yes, we need to detect both direction.
If ICD device is going off the network, we cannot find the SIT/LIT change from DNSSD, why do we need distinguish them?

https://github.com/jmartinez-silabs/connectedhomeip/blob/e2421597b23272f10e481392acb99ae38889d477/src/lib/dnssd/Discovery_ImplPlatform.cpp#L240
@mkardous-silabs the change here for text record cannot be dynamic ICD detection..

@bhaskar-apple  We need distinguish SIT->LIT from ICD device offline(for exmaple, power off), report in subscription in proposal 1 would guarantee that controller detect the change from SIT->LIT from proposed new attribute(type), if device is dead, controller cannot receive the report. In contrast, if applying proposal 2, when controller browsers the network, and ICD device already goes offline, controller cannot distinguish whether it is offline or SIT->LIT.
So it seems it is better to go with new type attribute in ICDManagement Cluster?

@yunhanw-google I think the best solution would be having both the DNS record and the attrbute value.
We the combination, we cover all the possible entry points.
1- Controller resolves ICD, it knows the operating mode
2- If the ICD changes operating mode, subs are updated and DNS record is update

@mkardous-silabs I guess what you mean here is to combine DNS subtype and new attribute in ICD Management cluster, right

@yunhanw-google exactly

WG: subscription events should smooth over the need to detect dynamic changes to ICD state (SIT -> LIT or LIT -> SIT).

@doru91 please prioritize this effort when you have time, thanks


Added typewriter animation along with button

It solves #27.
The implementation is the same as shown in the video of the issue

looks good enough implementation.
Closing the issue now.


add dirname and basename methods to EntityAbstract

Coverage decreased (-0.2%) to 99.51% when pulling 97e6bf3bce849f46b1ba6c71c949dead558c159c on dirname-basename into d62134ee7bf2b2081539341dfad115f80cba6fad on master.

Coverage increased (+0.003%) to 99.755% when pulling 43ddfdea3ba36423836f321d6964297fd81d31dd on dirname-basename into d62134ee7bf2b2081539341dfad115f80cba6fad on master.

Coverage increased (+0.001%) to 99.753% when pulling 6454b9b7b8725d915bb72eb9e4e7936c9c8116a4 on dirname-basename into d62134ee7bf2b2081539341dfad115f80cba6fad on master.


The purpose of generating training data and why it's so slow?

Hi, thanks for opening this great work!
I wonder why the command to generate training data in step 1 is almost the same as the Evaluation process? And why the step for generating training data is so slow, and it will evaluate the metrics like the below for the nuScenes dataset?

Are there any ideas to accelerate the training data generation step?

Hi @zhanghm1995, thank you for your interest in our work.
Generating the data takes so long because we use a larger covisibility graph than the one used during inference to achieve slightly better pose estimates. This is specified through the --r3d3_graph_type=droid_slam parameter. Furthermore, the pre-computed cost volumes of the larger graph do not fit into (our) gpu-memory, thus we use the "memory efficient" approach (--r3d3_corr_impl=lowmem) as proposed by the authors of RAFT, which is a bit slower. To speed up the process you could also remove the two parameters and resort to the same covisibility graph used during inference.
The metrics are generated because Lidar information is available for NuScenes. We do not make use of those metrics during dataset generation. You could easily turn it off in the config files and use it for other datasets where you might not have Lidar available.

Hi, @AronDiSc , thanks for your patient reply. It helps me a lot.
Since I'm not familiar with this framework, I want to know more details about this repo.

If I remove the --r3d3_corr_impl=lowmem parameter and I have enough GPU memory to generate the data, could it cause performance degradation?

If I don't want to train all training sets in the nuScenes dataset, I just try to overfit R3D3 in one scene, would it be reasonable to reproduce your results? I have already done this experiment in scene-1094, I got the Loss and metric like below, I'm not sure it's ok or not.

How to visualize the inference results like yours in your paper?

How to resume the checkpoint in the training stage.

Thanks in advance.


question about partial wakelock

Hi,
thanks for the useful plugin, and also for the enhancement by Boltex.
My Android app fetches data periodically from a server. In order to keep the app running at all times I'm using Katzer's background plugin along with your powermanagemen plugin.
This works very well, however there is still one problem: the screen remain on all the time (unless I manually switch it off with the power button). Even when I switch to another app the screen remains on all the time.
I would like to have the screen go off automatically after some time of inactivity, just like any other app.
When I use window.powerManagement.acquire, the screen remains on with full brightness.
When I use window.powerManagement.dim, the screen will go dim after a while, but it will never go off completely.
How can I have the screen go completely off automatically as usual (while still keeping the app running)?

Some extra comments:
As far as I understand there are 4 wakelock levels available in Android
(see http://developer.android.com/reference/android/os/PowerManager.html)

I believe that in your plugin, window.powerManagement.acquire uses FULL_WAKE_LOCK
and window.powerManagement.dim uses SCREEN_DIM_WAKE_LOCK
However, for my app I think  I would need PARTIAL_WAKE_LOCK to have the screen go off while still keeping the app running.
How can I accomplish this with your plugin?

isn't that already managed by @Boltex solution?

indeed

right now i am using @boltex partial plugin, wake lock gets acquired but while releasing or dimming it it throws error console! any help?

@boltex after acquiring  wakelock the screen stays Active after implementing release function the screen is still  in active state.it stays active until we terminate the app.


add repeatSlice

Current coverage is 93.55% (diff: 100%)

Merging #4782 into master will increase coverage by 4.68%

@@             master      #4782   diff @@
==========================================
  Files           121         61      -60
  Lines         74221      35938   -38283
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits          65960      33621   -32339
+ Misses         8261       2317    -5944
  Partials          0          0

Powered by Codecov. Last update c28f927...89dbc35

Thanks!


Remove "idaas" references from application

@dixonwhitmire commented on Wed Jul 15 2020
Please review the current NATS integration and logging statements to rename "idaas" or "idaas-connect" terms to "lfh".

changed NATS topic to lfh-events from idaas-data in PR #99


updated the latest release number of Harness-CLI

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65aad684865d580094fce853--harness-developer.netlify.app


Response timeout for block transfer

Hey, thanks for your work!
I am running this code (taken from blockwise_put.js) to send a chunk of data:
const coap = require('../')

const bufferSize = 250000
const testBuffer = Buffer.alloc(bufferSize)
const containedData = 'This is a test buffer with a lot of nothing and a bit of something'
testBuffer.fill('X', 'utf-8')
testBuffer.write(containedData, 'utf-8')
testBuffer.write(containedData, testBuffer.length - containedData.length, containedData.length, 'utf-8')

const request = coap.request({
    hostname: 'fdd2:3ab9:44ef:78c5:3b48:3e87:df48:678e',
    port: 5683,
    pathname: '/test',
    method: 'PUT'
})
request.setOption('Block1', Buffer.from([6]))

request.on('response', (res) => {
    console.log('Client Received Response: ' + res.payload.toString('utf-8'))
    console.log('Client Received Response: ' + res.code)
    process.exit(0)
})
console.log('Sending large data from client...')
request.end(testBuffer)
console.log('Sent to server')

And this code (same source) to receive:
const coap = require('coap')

coap.createServer({ type: 'udp6' }, (req, res) => {
    setTimeout(() => {
        console.log('Server Received ' + req.payload.length + ' bytes')
        console.log('Sending back pleasantries')
        res.statusCode = '2.04'
        res.end('Congratulations!')
        console.log('Sent back')
    }, 500)
}).listen(() => {
    console.log('listening...')
})

Now, I am observing this behavior in wireshark:

And this error on the receiving side:
RetrySendError: No reply in 247 seconds.
at Timeout._onTimeout (/home/admin/coap/node_modules/coap/dist/lib/retry_send.js:56:25)
at listOnTimeout (node:internal/timers:581:17)
at process.processTimers (node:internal/timers:519:7)
Emitted 'error' event on OutMessage instance at:
RetrySend.emit (node:events:518:28)
at Timeout._onTimeout (/home/admin/coap/node_modules/coap/dist/lib/retry_send.js:58:22)
at listOnTimeout (node:internal/timers:581:17)
at process.processTimers (node:internal/timers:519:7) {
retransmitTimeout: 247
        inet6 fdd2:3ab9:44ef:78c5:0:ff:fe00:9c00  prefixlen 64  scopeid 0x0<global>                                                                                │}

While this is the stdout of the client:
Sending large data from client...
Sent to server
Client Received Response: Congratulations!
Client Received Response: 2.04

So, the reponse from the server seems to be parsed.
Do you have an idea why the packet is being retransmitted?

I think I found the culprit.
The callback
request.on('response', (res) => {
    console.log('Client Received Response: ' + res.payload.toString('utf-8'))
    console.log('Client Received Response: ' + res.code)
    process.exit(0)
})

gets called when the confirmable server response arrives.
Since the client then exits, the coap stack does not get the chance to confirm the server response.
Changing the callback to this fixes the issue:
request.on('response', (res) => {
    console.log('Client Received Response: ' + res.payload.toString('utf-8'))
    console.log('Client Received Response: ' + res.code)
    setTimeout(process.exit, 10)
})


fix[event.schema.json]: remove click_through

This is a minor change. I think we should remove the enum value click_through as that indicates a subset of click and has specific connotations in advertising.

I agree - a click through is just a click.

Agreed - I'd consider adding "impression" to the enum to make it a bit more clear on how clickthrough rate could be calculated.

@miike That might be the purpose of view. Perhaps impression is a better term than view.

I think depending on the vertical they might mean distinct things (e.g., for ecommerce a page view of the PDP page would be a view versus a tile impression in search results). It's probably not particularly important but just depends on how opinionated you want the enum to be.

Sure thing - I've done that in #22


[BSE-4385] Add locally runnable benchmarks

Changes included in this PR
Adds locally running benchmarks and README to benchmark folder.
Testing strategy
Ran all scripts locally.

User facing changes
None

Checklist

[ ] Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
[x] I am familiar with the Contributing Guide
[x] I have installed + ran pre-commit hooks.

@marquisdepolis if you have the chance can you follow the instructions to make sure the scripts run for you?

I'd add:

say to Pixi install
pip install bodo
go to benchmark folder before running the python part

@scott-routledge2 let's sync on this tomorrow morning.


Action to Add Issues/PRs to Project

Automatically add any new issue or PR created in this repo to the tracking project using GitHub Actions.

@gpucibot merge


add workflow

Note :- Please follow the below points while attaching test cases document link below:
- If label Tested is added then test cases document URL is mandatory.
- Link added should be a valid URL and accessible throughout the org.
- If the branch name contains hotfix / revert by default the BVT workflow check will pass.

Test Case Document URL

Please paste test case document link here....

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7e85dff). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #94   +/-   ##
=========================================
  Coverage          ?   86.73%
=========================================
  Files             ?       17
  Lines             ?      309
  Branches          ?        0
=========================================
  Hits              ?      268
  Misses            ?       41
  Partials          ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Bootstrapping filter-horizontal and file-upload widgets

Some CSS edits to pull the filter-horizontal and file-upload widgets kicking and screaming into the world of bootstrap. Still far from perfect, but I think they're better than they were.
Before:

After:

Thoughts? Happy to make further edits.

Thanks for the patches! personally i'd reintroduce the header background (flat though) and its borders. Also patches should be squashed in two commits: one for the file upload and one for filter-horizontal. I can do the squashing before merging.
Regarding crappy icons and add new icon positioning it is something that should be fixed upstream. Some widgets have the add new link before them others after, quite messy.

I really wasn't a fan of the header background - it didn't seem to match any of the bootstrap-ish design directions, but maybe I was just reacting to the gradient. I'll play around with a few options.

How about this version?

Looks good! I had to tweaks a couple of things before merging:

i've reduced font-size in the filter because 14px while looked great reduced quite a lot the length of displayable text
i've used #777 as color for filters since it's already used in the interface

We can of course revise this later.


Revert "Merge pull request #38341 from verdog/camera-bounds-fix"

This reverts commit 08bbb3f161bfb4860d7574fa77b947872d344e7e.
This breaks export templates on windows.

Thanks!


Research Raft

Situation: We want to build a fully distributed system
Task: We need to have a shared understanding of consensus algorithms using raft
Action:

Research https://thesecretlivesofdata.com/raft/

Result:

Everyone contributing has an idea about shared system and consensus algorithms
Task is open for everyone

[ ] martin


Fixing link

Link on tutorial index was broken

Ack!  The link was fine; it was the tutorial name that was incorrect!


The game loads pretty slowly. Add a loading screen and/or fix it.

We're pulling in 66 .png images and 6 scripts for each page load. This is pretty bad - not even Chrome's cache can save us from the massive load times.

Switched to asynchronous image loading. This is probably as good as it's going to get without an actual build system


DREF Application: Label and description updates

Task Description
Change the label and description of fields in DREF Application when the type of DREF is Imminent
Expected Behavior

[x] Event Details >  Provide any updates in the situation since the field report and explain what is expected to happen. should be rename to What is expected to happen and when?

[x] What is expected to happen and when? should have guidance text Provide sufficient information to prove that the foreseen hazard is expected to have significant humanitarian impact, beyond seasonal scale. If possible, compare this expected event with previous ones that have caused humanitarian impact. Include clear data showing the probability of the event happening, the expected date of impact and the anticipated magnitude. Refer to imminent DREF guidelines for more information on eligible triggers.

[x] Event Details >  Explain why your National Society is acting now and what criteria is used to launch this operation. Should be renamed to Why is your National Society acting now and what criteria (forecast or expert judgement) is used to launch this operation?

[x] Guidance text should be change to  Explain the rationale of this request: how will the proposed plan intends to mitigate the impact of the foreseen hazard? How does the proposed plan complement other humanitarian efforts if any.

[x] Event Details >  Upload any supporting documentation if relevant (Optional) should be renamed to Forecast and source of expert judgement
[x] Event Details >  Source of Information is moved to Forecast and source of expert judgement.
[x] Actions/Needs > Remove Guidance text from Current National Society Actions field
[x] Actions/Needs > Government has requested international assistance is moved below Are there major coordination mechanisms in place?
[x] Operation > Add guidance text to Overall objective of the operation field. Guidance Text Explain what types of expected impacts are prioritized for the mitigation activities and what type of immediate needs will be addressed by the immediate response activities. If the National Society has a contingency plan for this hazard, the operational objective should be aligned with its objectives.
[x] Operation > Operation strategy rationale renamed to Mitigation and Immediate Response Strategy Rationale

[x] Add Guidance text The National Society should explain how the proposed early actions are expected to mitigate or prevent the impact of the disaster on the most at-risk population and to what extent the immediate response activities will address the most pressing needs and constitute a gap not covered by other humanitarian actors.

[x] Operation > Add Guidance text to Planned Intervention field Guidance Text:  Three types of activities are eligible under this DREF modality: Readiness activities: activities which are essential for the National Society to have the capacity to implement the early actions.  Early actions: activities which will prevent or mitigate the expected impact of the hazard on the most vulnerable population, not yet impacted by the disaster, but at risk of being exposed and highly impacted. Immediate response: activities to be implemented only if the disaster occurred and within the first two weeks from the date of occurrence of the disaster. This block aims at reducing the gap of activities and funding in the first hours and days after the disaster happens.  The focus of this operation should be the early action activities, which aim to save lives and protect homes and livelihoods for at risk communities in advance of a hazard. The time to implement the readiness + the early actions should be equal or below the lead time. The time to implement the immediate response should be equal or less than 15 days.
[x] Operation > Add Guidance text to How many staff and volunteers will be involved in this operation. Briefly describe their role. Guidance text:  Provide sufficient information to demonstrate that the National Society has the capacity to implement the readiness and early actions within the lead time.
[ ] Operation > Persons Targeted renamed to Total people targeted with the logic of sum of two new fields: People targeted by early actions and  People targeted by immediate response

Acceptance Criteria

[ ] All the necessary changes should reflect on the Application filed when DREF Type is Imminent

[ ] Actions/Needs - Reduce the gap below Current National Society Actions
[ ] Actions/Needs - 'Are there major coordination mechanisms in place?' should display a description section right below it after clicking on 'Yes'
[ ] Operation - The guidance text of Planned Intervention is not complete

cc @shreeyash07


README.md:127: close the issue after work is done.

The puzzle 5-ce439f4f from #5 has to be resolved:
https://github.com/Stanislau/behavior-tree-for-testing/blob/2a1fca2f1f1480b34475235bb03bb24e4d5e47dd/README.md#L127-L127
The puzzle was created by stanislau_kanaplianik on 03-Jun-24.
Estimate: 30 minutes,  role: D.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 5-ce439f4f has disappeared from the source code, that's why I closed this issue.


Lind Environment Variables/Execve

We have done very little inspection of how environment variables work in the Lind platform, especially in conjunction with the Execve system call, where they are specifically given. We should do some research here so we know what's going on.

Going through this issue  with @jesings has cleared up a lot of this for us.


[issue-2239] - Update core publish to push

Describe your changes :

This PR fixes https://github.com/open-metadata/OpenMetadata/issues/2239.
We are trying to publish a new version of openmetadata-core during the PR phase when it should actually happen during a push to main after the changes have been approved.
Happy to discuss this further. If we agree, I am going to test it by merging https://github.com/open-metadata/OpenMetadata/pull/2134, where we updated the MlModel schema.
Thanks!

Type of change :

[x] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have performed a self-review of my own.
[ ] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

<@harshach @ayush-shah

Thanks @mithmatt for the discussion on this!

@pmbrull - Thanks for looking into this.
This will break our commit and push step in CI as we are locked down on security for main branch.
This was the sole reason I had to use pull_request as the trigger. So that the CI will automatically bump version, build the wheels and upload dev versions to PyPi. Once done, make a commit and push new version to the current PR that Triggered it.
Let me know if I'm missing anything here.

@pmbrull - Thanks for looking into this.
This will break our commit and push step in CI as we are locked down on security for main branch.
This was the sole reason I had to use pull_request as the trigger. So that the CI will automatically bump version, build the wheels and upload dev versions to PyPi. Once done, make a commit and push new version to the current PR that Triggered it.
Let me know if I'm missing anything here.

That's a good point @akash-jain-10 🤔  How would you feel about breaking this down into two steps?

PR event increments the version and commits to the PR branch (we'd need to test this both with a fork and an internal branch.
Push event just runs themake publish. As that will run internally in the repo we won't have any issues with accessing the secrets.

With this approach, we get a bit more control and just publish changes that have been approved.
WDYT?

@pmbrull - Thanks for looking into this.
This will break our commit and push step in CI as we are locked down on security for main branch.
This was the sole reason I had to use pull_request as the trigger. So that the CI will automatically bump version, build the wheels and upload dev versions to PyPi. Once done, make a commit and push new version to the current PR that Triggered it.
Let me know if I'm missing anything here.

That's a good point @akash-jain-10 🤔 How would you feel about breaking this down into two steps?

PR event increments the version and commits to the PR branch (we'd need to test this both with a fork and an internal branch)
Push event just runs themake publish. As that will run internally in the repo we won't have any issues with accessing the secrets.

With this approach, we get a bit more control and just publish changes that have been approved.
WDYT?

Yes. That is the plan to trigger builds and pushes from forked repositories as well.
Plus to add on, we will use Test PyPi for publishing our dev packages via automation and have it available. cc @harshach @shahsank3t @ayush-shah
User Creates PR -> Bumps Version (Manual/automate) -> Merges PR to Main -> CI Publishes dev package to Test PyPi
User Creates Forked PR -> Bumps Version (Manual) -> Merges PR to Main -> CI Publishes dev package to Test PyPi
Production Release is still manual which we plan to automate on new Release creations.
Let me know what you guys think of this plan ?

@pmbrull - Thanks for looking into this.
This will break our commit and push step in CI as we are locked down on security for main branch.
This was the sole reason I had to use pull_request as the trigger. So that the CI will automatically bump version, build the wheels and upload dev versions to PyPi. Once done, make a commit and push new version to the current PR that Triggered it.
Let me know if I'm missing anything here.

That's a good point @akash-jain-10 🤔 How would you feel about breaking this down into two steps?

PR event increments the version and commits to the PR branch (we'd need to test this both with a fork and an internal branch)
Push event just runs themake publish. As that will run internally in the repo we won't have any issues with accessing the secrets.

With this approach, we get a bit more control and just publish changes that have been approved.
WDYT?

Yes. That is the plan to trigger builds and pushes from forked repositories as well. Plus to add on, we will use Test PyPi for publishing our dev packages via automation and have it available. cc @harshach @shahsank3t @ayush-shah
User Creates PR -> Bumps Version (Manual/automate) -> Merges PR to Main -> CI Publishes dev package to Test PyPi
User Creates Forked PR -> Bumps Version (Manual) -> Merges PR to Main -> CI Publishes dev package to Test PyPi
Production Release is still manual which we plan to automate on new Release creations.
Let me know what you guys think of this plan ?

Hi, mostly LGTM. I like the approach of starting with Test PyPi before jumping to the prod release cycle, a good point in there.
Maybe one comment would be that mainly contributors are working with forks (as they don't have enough permissions to the repo). It might be worth it to not rely on manual intervention to make sure that the process is as easy as possible and we are always following the same convention (in this case the increment package).
Hopefully opening a PR internally and externally should have the same effect so that we can also avoid bumping into random issues. Would it make sense to try to unify the bump version behavior by updating the CI to a pull_request_target? We should then bear in mind issues like https://github.com/open-metadata/OpenMetadata/issues/2185
Thanks!

Thanks @pmbrull .
Will keep this PR opened and this will be part - 2 of pypi publish for ingestion-core.
A couple of updates will need to take care of here -

Remove step to bump dev version
Update makefile to publish onto test.pypi.org

Part 1 PR will contain a workflow which will comment on the PR to bump up version when it detects schema changes (very similar to java checkstyle). I will raise a PR soon for this.

Thanks @pmbrull .
Will keep this PR opened and this will be part - 2 of pypi publish for ingestion-core. A couple of updates will need to take care of here -

Remove step to bump dev version
Update makefile to publish onto test.pypi.org

Part 1 PR will contain a workflow which will comment on the PR to bump up version when it detects schema changes (very similar to java checkstyle). I will raise a PR soon for this.

Great thanks @akash-jain-10. Are the secrets TWINE_* already pointing to the test index? Or should we change them as well

Thanks @pmbrull .
Will keep this PR opened and this will be part - 2 of pypi publish for ingestion-core. A couple of updates will need to take care of here -

Remove step to bump dev version
Update makefile to publish onto test.pypi.org

Part 1 PR will contain a workflow which will comment on the PR to bump up version when it detects schema changes (very similar to java checkstyle). I will raise a PR soon for this.

Great thanks @akash-jain-10. Are the secrets TWINE_* already pointing to the test index? Or should we change them as well

We need to change those. I will update those once we have this PR ready for merge :)

Hi @akash-jain-10 let me know if that was what you were thinking.
I changed the names of the secrets with _TEST to avoid confusion and make the change clear when we move to the prod release.
Thanks

LGTM. I have added secrets as per the names here - TWINE_USERNAME_TEST and TWINE_PASSWORD_TEST.


support for nerves use cases

allow different compilation targets, consider labeling .so files with architecture parameters.
Thanks to @elcritch for the idea and discussions.

completed by 1cb169e


Update strings.po

added few translations
Check if this PR fulfills these requirements:

[x] My changes respect the Kodi add-on development rules
[x] I have read the CONTRIBUTING document.
[x] I made sure there wasn't another Pull Request opened for the same update/change
[x] I have successfully tested my changes locally

Types of changes

[ ] New feature (non-breaking change which adds functionality)
[ ] Feature change (non-breaking change which changes behaviour of an existing functionality)
[x] Improvement (non-breaking change which improves functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Refactor (non-breaking performance or readability improvements)

Description

In case of Feature change / Breaking change:
Describe the current behavior

Describe the new behavior

Screenshots (if appropriate):

CI notify not translated ids
resources/language/resource.language.el_gr/strings.po:1084: this message is untranslated
resources/language/resource.language.el_gr/strings.po:1088: this message is untranslated
resources/language/resource.language.el_gr/strings.po:1093: this message is untranslated
resources/language/resource.language.el_gr/strings.po:1119: this message is untranslated
resources/language/resource.language.el_gr/strings.po:1127: this message is untranslated
resources/language/resource.language.el_gr/strings.po:1143: this message is untranslated
can you finish the update?

thank you, for the next time remember to add appropriate title to the PR


Move to knife-windows 1.0.0.rc.1 (for nightlies and the next RC)

@jaym, @ksubrama, @tyler-ball
The "nightlies" that we're producing still have knife-windows 0.8.5 in them because the commit for knife-windows=1.0.0.rc.0 was in the tball/070rc branch. We released knife-windows=1.0.0.rc.1 today and need to test https://github.com/chef/chef-dk/issues/411.

:shipit:

might want to try a build in CI first

build is slow. http://manhattan.ci.chef.co/job/chefdk-build/480/

:+1:


Improper error response if unsupported format is requested

The following request
https://htsget.demo.umccr.org/reads/org.umccr.demo.htsget-rs-data/cram/mt.sorted_cram?class=header&format=bam

results in the following response
{
  "htsget": {
    "error": "NotFound",
    "message": "aws error: unhandled error, with key: `cram/mt.sorted_cram.bam`"
  }
}

According to the spec
The server SHOULD reply with an UnsupportedFormat error if the requested format is not supported.
I realize it says SHOULD so this behavior isn't technically out of spec,  but it can result in confusing error messages to client programs and their users.    It doesn't appear that htsjdk supports decoding CRAM from htsget responses, so I was testing to see what happens if BAM is requested.  I think some servers could handle  either BAM or CRAM output for the same dataset ID, but other cannot (such as this particular test server).   So its difficult to present an informative error message to end users without the specific error called for in the spec.

Just a comment since I know some of you participate in spec meetings,  there doesn't seem to be any way to ask a server what output formats it supports for a given ID.   I realize there are only 2 possible for reads,  but that is more than 1 and clients should be able to know before requesting a particular format.

I think some servers could handle either BAM or CRAM output for the same dataset ID, but other cannot (such as this particular test server).

I think that this issue stems from the following S3 path confusion, so I just went and created a mixed S3 subkey where you have BAM and CRAM together with the same ID:
(base) rvalls@m1 ~ % aws s3 ls s3://org.umccr.demo.htsget-rs-data/
                           PRE bam/
                           PRE bcf/
                           PRE cram/
                           PRE crypt4gh/
                           PRE events/
                           PRE vcf/

(base) rvalls@m1 ~ % aws s3 ls s3://org.umccr.demo.htsget-rs-data/cram/
2023-09-25 16:26:51    1627794 htsnexus_test_NA12878.cram
2023-09-25 16:26:51        129 htsnexus_test_NA12878.cram.crai
2023-09-28 15:32:18     693771 mt.sorted_cram.cram
2023-09-28 15:32:26        320 mt.sorted_cram.cram.crai

(base) rvalls@m1 ~ % aws s3 ls s3://org.umccr.demo.htsget-rs-data/bam/
2023-09-25 16:26:51    2596799 htsnexus_test_NA12878.bam
2023-09-25 16:26:51       6728 htsnexus_test_NA12878.bam.bai
2023-09-25 16:26:51       2034 htsnexus_test_NA12878.bam.blocks.yaml
2023-09-25 16:26:51       2616 htsnexus_test_NA12878.bam.gzi
2023-09-28 15:02:23     876871 mt.sorted.bam
2023-09-28 15:02:29     747632 mt.sorted.bam.bai

(base) rvalls@m1 ~ % aws s3 cp s3://org.umccr.demo.htsget-rs-data/bam/mt.sorted.bam s3://org.umccr.demo.htsget-rs-data/mixed/mt.sorted.bam
copy: s3://org.umccr.demo.htsget-rs-data/bam/mt.sorted.bam to s3://org.umccr.demo.htsget-rs-data/mixed/mt.sorted.bam
(base) rvalls@m1 ~ % aws s3 cp s3://org.umccr.demo.htsget-rs-data/bam/mt.sorted.bam.bai s3://org.umccr.demo.htsget-rs-data/mixed/mt.sorted.bam.bai
copy: s3://org.umccr.demo.htsget-rs-data/bam/mt.sorted.bam.bai to s3://org.umccr.demo.htsget-rs-data/mixed/mt.sorted.bam.bai
(base) rvalls@m1 ~ % aws s3 cp s3://org.umccr.demo.htsget-rs-data/cram/mt.sorted_cram.cram s3://org.umccr.demo.htsget-rs-data/mixed/mt.sorted.cram
copy: s3://org.umccr.demo.htsget-rs-data/cram/mt.sorted_cram.cram to s3://org.umccr.demo.htsget-rs-data/mixed/mt.sorted.cram
(base) rvalls@m1 ~ % aws s3 cp s3://org.umccr.demo.htsget-rs-data/cram/mt.sorted_cram.cram.crai s3://org.umccr.demo.htsget-rs-data/mixed/mt.sorted.cram.crai
copy: s3://org.umccr.demo.htsget-rs-data/cram/mt.sorted_cram.cram.crai to s3://org.umccr.demo.htsget-rs-data/mixed/mt.sorted.cram.crai

(base) rvalls@m1 ~ % aws s3 ls s3://org.umccr.demo.htsget-rs-data/mixed/
2023-10-02 14:01:15     876871 mt.sorted.bam
2023-10-02 14:01:28     747632 mt.sorted.bam.bai
2023-10-02 14:02:25     693771 mt.sorted.cram
2023-10-02 14:02:36        320 mt.sorted.cram.crai

You'll see that our server behaves as expected with this situation:
curl 'https://htsget.demo.umccr.org/reads/org.umccr.demo.htsget-rs-data/mixed/mt.sorted?class=header' <--- Gets the BAM format by default, as per spec
curl 'https://htsget.demo.umccr.org/reads/org.umccr.demo.htsget-rs-data/mixed/mt.sorted?class=header&format=CRAM'

And to your point:

there doesn't seem to be any way to ask a server what output formats it supports for a given ID

From my point of view, the UnsupportedFormat is reserved to formats that the (htsget) server does not support, as it only supports the subset {VCF,BCF,BAM,CRAM} at the time of this writing , i.e, BED is not supported at the moment:
% curl 'https://htsget.demo.umccr.org/reads/org.umccr.demo.htsget-rs-data/mixed/mt.sorted?class=header&format=BED'
{
  "htsget": {
    "error": "UnsupportedFormat",
    "message": "bed isn't a supported format for this endpoint"
  }
}

If I understand correctly, you'd want a hint for clients when an ID with multiple formats is found? As in:
curl 'https://htsget.demo.umccr.org/reads/org.umccr.demo.htsget-rs-data/mixed/mt.sorted?class=header

{
  "htsget": {
    "message": "Multiple formats detected, returning BAM",
    "formats": "BAM, CRAM"
  }
}

Then have a 302 code to redirect to BAM automatically as it does now by default? That way clients would have that hint and not break backwards compat?

I agree with @brainstorm here. I'm not sure that UnsupportedFormat is the correct error response because my interpretation of "The server SHOULD reply with an UnsupportedFormat error if the requested format is not supported" was for the server as a whole, rather than for a specific id. Although it could be interpreted both ways, I think NotFound probably makes more literal sense because that key, e.g. cram/mt.sorted_cram.bam, could not be found.
Either way, I can see the utility of having a hint for the formats that are available for a particular id. This doesn't necessarily need a spec change either, and it could just be present in the error response (whether that is UnsupportedFormat or NotFound), e.g.:
{
  "htsget": {
      "error": "NotFound",
      "message": "id with key: `cram/mt.sorted_cram.bam` not found. The following formats are available for this id: ["BAM"]"
  }
}

Somewhat related to this (although not directly) is https://github.com/umccr/htsget-rs/issues/127.

This doesn't necessarily need a spec change either, and it could just be present in the error response (whether that is UnsupportedFormat or NotFound)

Well, I slightly disagree here... I'm not sure that message is the best place to embed operational hints that clients might use and rely upon :-S

Yeah that's a completely valid point. A hint would probably be best as an additional JSON field, which would require a spec change.

OK I will defer to you guys, I misinterpreted the spec.  For my part I've updated the igv.js doc to be clear that CRAM and BCF are not supported for htsget.   This is also true of IGV desktop as the htsjdk does not support them.


Cannot read properties of null (reading 'offsetWidth')

I'm implementing a data table with Active Table in my Next.js project, and I've started getting an error whenever trying to resize the width of my page.
Unhandled Runtime Error
TypeError: Cannot read properties of null (reading 'offsetWidth')

Call Stack
ParentResize.shouldRerenderTable
node_modules/active-table/dist/utils/render/parentResize.js (19:0)
ActiveTable.resizeCallback
node_modules/active-table/dist/utils/render/parentResize.js (25:0)

I've never used Lit before, but it seems like parentElement might not be defined on at.

Hi @YodaLightsabr, is there any chance you can share what configuration you are using for the Active Table component implementation. Thanks!

I am attempting to replicate the problem on my end, but it seems to work ok.
Would there be any chance that you could FORK the live example and attempt to recreate the issue there, just so I can immediately analyze it and implement the fix. Thanks

Hi, it's been a week with no response from OP. I will close this issue but feel free to reopen it if you can provide more details. Thankyou!

Hi! Sorry I've missed your comments; I'll take a look at what you've sent and try to reproduce it from that.

Same thing here, trying to use activetable in a lit-element component
https://codepen.io/franck34/pen/jOjzRmW
This is critical

Show stopper spotted, please fix this


fatal error

Fata error "name='csrftoken', domain=None, path=None"
This error appeared.

fatal error:: Connection to host failed , check your connec
tion and tor configuration :: SOCKSHTTPConnectionPool(host-
'httpbin.org', port=80): Max retries exceeded with url: /ip
(Caused by NewConnectionError("<urllib3.contrib.socks.SOCK
SConnection object at 0x7935785650>: Failed to establish a
new connection: Ox06: TTL expired'))


Validation for EU companies not working

See https://github.com/DragonBe/vies/issues/148

Temporary fixed by #14


v2.x - Spectron now deprecated, use WebdriverIO for desktop tests

Describe what problem your feature request solves
Spectron is deprecated from February 2022: https://www.npmjs.com/package/spectron
Testing of electron desktop applications is now done using ChromeDriver and WebdriverIO.
Describe the solution you'd like
Test desktop Threat Dragon application and pull down menus
Additional context

Using WebdriverIO Electron Service service for testing the Electron desktop application

Workingthrough this tutorial, spectron no longer supports the chrome browser used by electron - so spectron is definitely not to be used. This explains the erros when running the existing test (which is skipped for now)


SPARK-12639 SQL Mark Filters Fully Handled By Sources with *

In order to make it clear which filters are fully handled by the
underlying datasource we will mark them with a *. This will give a
clear visual queue to users that the filter is being treated differently
by catalyst than filters which are just presented to the underlying
DataSource.

Can one of the admins verify this patch?

test this please

@RussellSpitzer Thank you for the PR! This looks good! It will be great if you have time to add before/after comparison in the description and change the title to [SPARK-12639] [SQL] Mark Filters Fully Handled By Sources with *.

Test build #50197 has started for PR 10929 at commit 40a75a4.

Test build #50197 has finished for PR 10929 at commit 40a75a4.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50197/
Test FAILed.

Merged build finished. Test FAILed.

test this please

Test build #50206 has started for PR 10929 at commit 40a75a4.

Test build #50206 has finished for PR 10929 at commit 40a75a4.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50206/
Test FAILed.

Merged build finished. Test FAILed.

@RussellSpitzer I just realized that this is against branch 1.6. Can you create a PR for master?


Fixed #4978 change caption upload algorithm

Description (required)
Fixes https://github.com/commons-app/apps-android-commons/issues/4978 :App crashed after edit multiple caption several time
At removeDescription()method at UploadMediaDetailAdapter.java. This method will remove the caption at position. This method will use
notifyItemRemoved(position);

However, after using this method, the item will not be refreshed, that is, the data will not be rebound, .and the position corresponding to each item is the same as the original one, there will be problems. For example, there are only three items left. When we click to delete the last item, its position is the original position4, so it is actually called notifyItemRemoved (4), the boundary is exceeded.
Tests performed (required)
Tested ProdDebug on Pixel 4 with API level 28.

Ok, I check again, but find the things is all right, I see the code
at fr.free.nrw.commons.upload.UploadMediaDetailAdapter$ViewHolder.lambda$bind$4$UploadMediaDetailAdapter$ViewHolder(UploadMediaDetailAdapter.java:187)

The error occurs in line 187 in  UploadMediaDetailAdapter.java, in my branch, this line is empty lines, maybe the version is different between you and me. Could you tell which version you run? Thanks.

Oops I must have messed up something, I will try again tomorrow, thanks!


T03.01-Exercise-RecyclerViewLayout - conflicting name between Main activity and xml rescources

I'm having problems to see the resolution of this exercice.
        int layoutIdForListItem = R.layout.number_list_item;
                                          ^
  symbol:   variable number_list_item

I'm getting this error and I have no Idea how to solve it. It looks like a file called number_list_item is missing inside the floder layout.

unsubscribe
On Wed, Apr 15, 2020 at 5:02 PM Iago Henrique Pires Moreira e Morais <
<EMAIL_ADDRESS>wrote:

The name of the Recicler view rescource on the MainActivity.java is
"number_list_item", but the name of this on the xml file is rv_numbers.
It's happenning on the exercice (The todo tells you to set the rrong name)
and on the solution is with the rrong names to.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/udacity/ud851-Exercises/issues/468, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHGFQBZNHQ27WNNDRZ5IBALRMW47ZANCNFSM4MITGEYA
.

It happens because "number_list_item.xml" file doesn't exist yet.  Just make the changes and move on to the next task (exercise) where you will create it.
(I assume you already figured it out.)

<view class="android.support.v7.app.AlertController$RecycleListView"         android:id="@+id/rv_numbers"         android:layout_width="match_parent"         android:layout_height="match_parent"/>


Is it still working?

Hi, just wanted to ask if it was still on?

Hey !
Unfortunately, a friend warned me about the legality of this API and I had to close it some time after opening it to prevent any problems.
Howerver if you can code in Javascript (NodeJS) just take a look at the /localModules/ztParser.js file, its the core of the project and API, and only this file is really important. (All other files are needed to make an API around that file in fact)
You can import it to your project to use it by your own.
I will edit the repository to talk about that.

I updated README.md file, go take a look ^^

Huge Thanks, ill look on it 😁


Add client API to retrieve all processes of an Assembly

Currently we can only retrieve a process by ID (https://github.com/IBM/lmctl/blob/master/lmctl/client/api/processes.py).
We have disabled the list API as it's not possible to get all processes, however it should be possible to get all processes associated to a given Assembly (by name or ID).

Closed by PR #77


Initial Commit

Created read-me.txt

Closed the pull request without any responses

Try this @Harikrishnan001


Alternate output formats? (HTML?)

This is an exciting piece of technology. Are there any plans to implement alternate backends for the generator? It would be fantastic to have an alternative to e.g. KaTeX for maths typesetting on the web.

Ah, I found the relevant line in ARCHITECTURE.md:

HTML export does not exist yet, but will in the future. However, this requires some complex compiler work because the export will start with Content instead of Frames (layout is the browser's job).


AL Rest Client

Provides functionality to easily call REST web services
The module contains methods to support

Calling web services with just one line of code
Creating request content from Text, JSON, XML or binary data
Read the response as Text, JSON, XML or binary data
Authenticate using basic authentication

Some examples:
// Getting text
ResponseText := ALRestClient.Get(Url).Content().AsText();

// Getting binary data
TempBlob := ALRestClient.Get(Url).Content().AsBlob();

// Posting binary data and returning binary data
ALHttpContent.Create(TempBlob)
TempBlob := ALRestClient.Post(Url, ALHttpContent).Content().AsBlob();

// Getting a JsonObject
JsonObject := ALRestClient.GetAsJson(Url).AsObject();

// Posting a JsonObject and returning the result as JsonObject
JsonObject := ALRestClient.PostAsJson(Url, JsonObject).AsObject();

// Using Basic Authentication
HttpAuthenticationBasic.Initialize('user01', 'Password123');
ALRestClient.Initialize(HttpAuthenticationBasic);
ALHttpResponseMessage := ALRestClient.Get('https://httpbin.org/basic-auth/user01/Password123');

Remarks:

Support for OAuth can be added later. A module is already available, but it requires some internal discussion.
Telemetry signal RT0019 (Outgoing Web Service Request) will be lost for the ISV because the platform only sends it to the app that uses HttpClient directly. This needs to be addressed somehow.
Documentation (like a readme.md file) can be generated from the XML comments, but maybe it's better to write a more extensive document how to use this new module.

Looks like a logo is missing. I'll add it. Would love to make the compilation succeed to start with :-)

Replaced the usage of enum "Http Request Type" from the OAuth module with a new enum "Http Method". I figured it was more appropriate for the module to have its own enum instead of taking a dependency on the OAuth module.
Also added a dependency on Base64 Convert to solve a compiler error.

Thank you all for the comments so far. Much appreciated and great feedback!
I'm going to work through all of it this week and will provide a number of updates. Including an update to solve the issue with telemetry signal  RT0019 and the popup question in sandboxes for allowing or blocking outgoing web requests (which was now only once for the system app instead of per app that actually started the request).

Just create a fairly large commit to resolve almost all comments.
But most importantly, I've introduced an interface "Http Client Handler". A codeunit "Default Client Handler" is also provided, that can also serve as boilerplate code for apps. The main purpose of this handler codeunit is to let the original app send the actual http request. As a result, telemetry signal RT0019 will be sent to the ISV's AppInsight and the feature to block outgoing web requests is applied to the original app.
The Http Client Handler must be specified when initializing the Rest Client. In case no handler codeunit is specified, it will take the default one provided in the module.
This pattern can also be used for tests to create fake responses or a mocking codeunit to handle the request differently.

@JesperSchulz It seems the pipeline is not ready for platform 12.0 at the moment.

@JesperSchulz Just wanted to inform you that I've increased the object range to 2360 in order to include the extra codeunits that were needed for implementing the facade pattern.

@JesperSchulz I was thinking, would it make sense to uptake namespaces? The base app seems to do that already, but I've not seen it in the system app. Would it make sense to put this module in a namespace like System.Http or something like that?

The system application is fully namespaced in 23.0, and as a matter of fact, this module will have to be namespaced in order to be able to get checked in. And yes, it needs to start with "system." 😉 I can add the namespaces, when we start processing this one. Right now I've requested a few more code reviews from our platform teams, to ensure that they're fine with this wrapper. Once they've given the "go ahead", it gets interesting. I am cautiously hoping to add the "processing-PR" tag next week!

@JesperSchulz It seems the pipeline is not ready for platform 12.0 at the moment.

It is not, no. But don't sweat it. As long as it compiles on 2023 Wave 2 / 12.0, it's all good. Hopefully I'll soon be able to give this a spin in our internal build system!

@JesperSchulz It seems the pipeline is not ready for platform 12.0 at the moment.

It is not, no. But don't sweat it. As long as it compiles on 2023 Wave 2 / 12.0, it's all good. Hopefully I'll soon be able to give this a spin in our internal build system!

I've tested with a 23.0 preview build, and all tests succeed. It's great to have the SecretText implemented from the beginning, that's why I needed v23.

One small issue is missing, which was reported to @KennieNP a while ago: the HttpRequest object in the AL platform doesn't support relative URLs, while the underlying .Net object does. I've worked around it, but I'd be more happy if it would be supported in the platform object.

@KennieNP also suggested we add some retry-logic to this wrapper, while at it (I could not spot it when rushing through the code today). It would greatly improve the HttpClient call stability in the app if we did. He even provided some sample code to illustrate his intend ;-)
`
// RetryStrategy can be any of these strings (should be an enumeration)
// RegularIntervalRetry
// ExponentialBackoff
// Randomization

local procedure SendRequest(
    Client: HttpClient;
    RequestMessage: HttpRequestMessage;
    UserErrorMessage: Text[200];
    IsCollectable: boolean;
    MaxNumberOfRetries: Integer;
    RetryStrategy: Text;
    RetrySleeptimeInMilliseconds: Integer
) ResponseMessage: HttpResponseMessage
var
    IsSuccessful: Boolean;
    ErrorInfoObject: ErrorInfo;
    ErrorCustomDimensions: Dictionary of [Text, Text];
    vResponseMessage: HttpResponseMessage;
    HttpStatusCode: integer;
begin
    IsSuccessful := Client.Send(RequestMessage, vResponseMessage);

    if not IsSuccessful then begin
        ErrorInfoObject.DetailedMessage := 'The HttpClient.Send could not be sent, this is likely an error in the AL code.';
        ErrorInfoObject.Title := 'Could not call external service';
        ErrorInfoObject.Message := UserErrorMessage;
        ErrorInfoObject.Collectible := IsCollectable;
        ErrorCustomDimensions.Add('HTTPMethod', RequestMessage.Method);
        ErrorInfoObject.CustomDimensions := ErrorCustomDimensions;
        Error(ErrorInfoObject);
    end;

    if not vResponseMessage.IsSuccessStatusCode() then begin
        HttpStatusCode := vResponseMessage.HttpStatusCode();

        // Handling status codes 429 and 503 requires the client to adopt a retry logic while providing a cool off period.
        case HttpStatusCode of
            419:
                vResponseMessage := SendRequestRetry(Client, RequestMessage, MaxNumberOfRetries, RetryStrategy, RetrySleeptimeInMilliseconds);
            503:
                vResponseMessage := SendRequestRetry(Client, RequestMessage, MaxNumberOfRetries, RetryStrategy, RetrySleeptimeInMilliseconds);
        end;

        if not vResponseMessage.IsSuccessStatusCode() then begin
            HttpStatusCode := vResponseMessage.HttpStatusCode();
            // final error handling after possible retries
            if ((HttpStatusCode = 429) or (HttpStatusCode = 503)) then begin
                ErrorInfoObject.DetailedMessage := 'The HttpClient.Send call was successful, but the external service responded with a ' + Format(HttpStatusCode) + ' HTTP status code even after retrying.';
                ErrorCustomDimensions.Add('RetryAttempts', Format(MaxNumberOfRetries));
            end;
            if (HttpStatusCode = 504) then begin
                ErrorInfoObject.DetailedMessage := 'The HttpClient.Send call was successful, but the external service timed out (responded with a ' + Format(HttpStatusCode) + ' HTTP status code). You probably need to refactor your AL code.';
            end;
            if (HttpStatusCode > 500) then begin
                ErrorInfoObject.DetailedMessage := 'The HttpClient.Send call was successful, but the external service responded with a 5xx error. This call will not be retried.';
            end;

            ErrorInfoObject.Title := 'Could not call external service';
            ErrorInfoObject.Message := UserErrorMessage;
            ErrorInfoObject.Collectible := IsCollectable;
            ErrorCustomDimensions.Add('HttpStatusCode', Format(HttpStatusCode));
            ErrorCustomDimensions.Add('HTTPMethod', RequestMessage.Method);
            ErrorInfoObject.CustomDimensions := ErrorCustomDimensions;
            Error(ErrorInfoObject);
        end
        else // retry worked! :)
            ;

    end;

    ResponseMessage := vResponseMessage
end;

// Asserts that Client.Send(RequestMessage, vResponseMessage) is successfull (that the AL code is sound)
local procedure SendRequestRetry(
    Client: HttpClient;
    RequestMessage: HttpRequestMessage;
    MaxAttempts: Integer;
    RetryStrategy: Text;
    SleeptimeInMilliseconds: Integer
) ResponseMessage: HttpResponseMessage
var
    vResponseMessage: HttpResponseMessage;
    Attempt: Integer;
    IsSuccessful: Boolean;
begin
    Attempt := 1;
    while Attempt <= MaxAttempts do begin
        IsSuccessful := Client.Send(RequestMessage, vResponseMessage);
        if (IsSuccessful) then
            break
        else begin
            case RetryStrategy of
                'RegularIntervalRetry':
                    RegularIntervalRetry(SleeptimeInMilliseconds);
                'ExponentialBackoff':
                    ExponentialBackOff(SleeptimeInMilliseconds, Attempt);
                'Randomization':
                    Random(SleeptimeInMilliseconds);
                else
                    RegularIntervalRetry(SleeptimeInMilliseconds);
            end;
            // if RetryStrategy = 'RegularIntervalRetry' then
            // else if ;
        end;
        ;
        Attempt := Attempt + 1;
    end;
    ResponseMessage := vResponseMessage
end;

local procedure RegularIntervalRetry(SleeptimeInMilliseconds: Integer)
begin
    Sleep(SleeptimeInMilliseconds);
end;

local procedure ExponentialBackOff(SleeptimeInMilliseconds: Integer; Attempt: Integer)
begin
    Sleep(SleeptimeInMilliseconds * Power(2, Attempt));
end;

local procedure Random(SleeptimeInMilliseconds: Integer)
begin
    Sleep(System.Random(SleeptimeInMilliseconds));
end;

}
`
This doesn't have to be part of the initial PR, but we'll probably add it eventually, as it's a great suggestion.

That's a great suggestion! I agree it can be added later. If time permits I may add it to the current PR.
For the retry strategy: if that's an enum, we could consider adding an interface to it. Then it can easily be extended by others with alternative strategies.
You may want to already increase the number range so we have enough objects reserved! 😄

Feel free to extend the number range 😊 There should be plenty of available numbers...
Love the idea of making the retry strategy extensible. I guess retying can be done in many different ways.
Adding a retry strategy to the module will further boost the value proposition of this module. We are indeed seeing a lot of failures in telemetry due to the lack of this capability.
This module is coming along nicely 🥳 I'd love to get it on the road with 23.1 (November release) - let's see if we can make that happen!

over all this PR looks very promising.
Personally I'd like to have an Generi POST method on the rest client, that accepts an InStream, but as a starter the current Generic Send is okay, too.

Short update: Tomorrow we are internally opening up for PRs through the new BCApps repository. I will make this PR the first official AL PR to be processed in the new repository 🥳 From November 1st, the BCApps repository will open to the public too. By then, I hope this PR has successfully been processed though.

The PR went into the main branch (24.0) 🥳 As soon as we release the 23 bits, we can merge this PR. Further improvements can then be done to the added module.


Coral Dev Board Micro USB is not recognized

Description
I was developing with the Coral Micro and encountered a SDP mode connection problem. Neither /dev/ttyACM0 nor Google or NXP devices appear in lsusb. Just in case, I'm attaching the udevadm monitor log.

The program uploaded to the current device outputs the following log through the uart pin connection.

How can I flash other program?
any Idea to solve this issue?
Thank you
Click to expand!
Issue Type
Support
Operating System
Linux
Coral Device
Dev Board Micro
Other Devices
No response
Programming Language
C++
Relevant Log Output
No response

It was my fault that I didn't press the user button
I'm sorry


Is there a image with virtualgl and turbovnc?

I want to connect the container via vnc.  And application in the container both use Opengl and GPU.

tightvnc enable GPU but disable Opengl.
tigervnc enable Opengl but disable GPU.

Google said virtualgl and turbovnc can solve the problem.
Up to now, I can't find a built image in dockerhub.

Hello,
This is an issue tracker for the docker project.
If you would like to engage with the Docker community please see forums.docker.com or the community slack.
Thanks!


Consider the default port when checking address overlap

Signed-off-by: Free Ekanayaka<EMAIL_ADDRESS>

Testsuite passed


Images crop, cut and make changes

Description of the new feature / enhancement
Hi, I use an application called Lighshot, that allows to cut, crop an image or take screenshot and edit to put some comments, rectangles, etc.
Scenario when this would be used?
When someone want to take an screenshot or crop, cut an image and in this image wants to add comments, squares, arrows, like image below

Supporting information
You can see the Lightshot website https://app.prntscr.com/en/index.html

You can use Snipping Tool in Windows 11 to take screenshots of the whole screen or a specific area and directly edit them. For more options you can then directly edit it in Paint.


Creating a Default Photo Editor

Describe the bug
I can't find the section in settings to change the default photo #editor.
To Reproduce
When I edit a photo, there's an "I" icon there that says I can change in the apps section of Settings. The problem is that I have no apps section in Settings.
Expected behavior
Just want to create a default editor.
Screenshots
If applicable,
aves-logs-20230818_120616.txt

email](mailto:gallery.aves@gmail.com).
System information and logs:
Package: deckers.thibault.aves
Installer: com.android.vending
Aves version: 1.8.9-play, build 100
Flutter: stable 3.10.3
Android version: 13, API 33
Android build: TP1A.220624.014.G988NKSU3IWE1
Device: samsung SM-G988N
Geocoder: ready
Mobile services: ready
System locales: en_GB
Storage volumes: /storage/emulated/0/, /storage/EAD4-A932/
Storage grants:
Error reporting: false
Additional context
Add any other context about the problem here.

When I edit a photo, there's an "I" icon there that says I can change in the apps section of Settings. The problem is that I have no apps section in Settings.

This is an Android system dialog. They're referring to the Android settings, not Aves settings.

I wondered if that might be the case but I don't have this option under
phone settings either.
Anyway, thanks for the clarification.
On Fri, 18 Aug 2023, 12:32 pm Thibault Deckers, @.***>
wrote:

When I edit a photo, there's an "I" icon there that says I can change in
the apps section of Settings. The problem is that I have no apps section in
Settings.
This is an Android system dialog. They're referring to the Android
settings, not Aves settings.
—
Reply to this email directly, view it on GitHub
https://github.com/deckerst/aves/issues/714#issuecomment-1683560502, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANLKF3WDI6OTRFG3UUHQYSDXV4SCHANCNFSM6AAAAAA3VFK5W4
.
You are receiving this because you authored the thread.Message ID:
@.***>


modify query for total amount donated and invoices after refund

profiles still show total amount donated without taking refunds into account
invoices should also ignore refunds

yeah, I think this is problem is going to show up everywhere we show the ledger of a collective (of any type). One other place I can think of is the invoices. @xdamman!
I'm thinking about creating a small function to get the ledger for each collective so we'll be able to centralize the logic in one place. The two things this function could initially do is to:

get the balance of a given collective taking into account all transactions including refunds (would be used in the :collectiveslug/ page to show how much a backer has contributed & how much a collective actually has)
List transactions of that collective (would replace the logic in :collectiveslug/transactions/)


V8: Remove index.php from URLs

Autonav doesn't seem to remove index.php form urls.

v8b2: only partial fixed.
on "/" all links do still have index.php in the URI. On the subpages it's correct.


Update playground.md

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

🚀 Preview for commit 05f7d7fff3245ff07727cc59800d5373cdd413fe at: https://66c74b8e37ef60395a56a67f--meshery-docs-preview.netlify.app

🚀 Preview for commit 0410108fe825ba5c91bba8e57eb23ce7fd70036d at: https://66c75400bd739443c9e20c97--meshery-docs-preview.netlify.app


chore: bump version to 1.15.0

Allure Report
allure-report-publisher generated test report!

processReports: ✅ test report for 29d53b0f

passed
failed
skipped
flaky
total
result

Total
32
0
0
0
32
✅