Grammar fixes

Hi - foam is one of the dozen or so grammars that suffer from issues such as memory leaks, infinite loop hangs (case for this one), segfaults, etc. In an attempt to fix that - I reworked the logic to not use a copied haskell scanner and instead directly and simply run the logic. It works well and fuzzing reports nothing bad. I also tweaked identifier and boolean as they seemed somewhat wrong and updated the queries accordingly.
Thanks,
Amaan

Hi, Looks solid to me; I have actually started a similar effort but got distracted by other stuff!
I did my best to review in 30mins, nothing really comes off as risky so I'm willing to go with this as is.
I vaguely remember that I did booleans with "string literals" for a reason (probably LSP-related); but cannot remember why 😭
Anyway, we're rolling with it for now
Thanks for the nice contribution

Also, a million thanks for adding a License 👍🏻. I have forgotten to do so a few times

Thanks for merging! Though I forgot to update the windows tests as well, do you mind me PRing just changing that as well :sweat_smile:

Already done, no need :)


Create helper functions for temporary directories which supports new concurrency features

Motivation is to slowly adapt and new concurrency features which can be used in swiftpm

thanks for the PR @Overcot. we are looking to deprecate this library over time. as such, would you mind moving this to SwiftPM's Basics module?

thanks for the PR @Overcot. we are looking to deprecate this library over time. as such, would you mind moving this to SwiftPM's Basics module?

Yeah, i did in PR https://github.com/apple/swift-package-manager/pull/5532

I guess i will close PR then


Problem

I activated plot chia and mining does not work. What is the problem?

help me pls. what a problem?

The mining process looks good. Most of the errors are from peer-to-peer network.


Fix multivalue fields deduplication

Ref: https://github.com/cortezaproject/corteza/issues/1434
The following PR introduces  records multifield de-duplication check when multi-field values equal configuration is set.

Tested and pointed out a couple of issues in dms

One more thing to be addressed and we should be good to go


Chore: replace addDisposableTo method from RxSwift

Replacing the method addDisposableTo for disposed(by:) since the former as been deprecated as of RxSwift 4.0.

Thanks a lot for contributing to Moya! I've invited you to join the Moya GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions.


Cleanup ci script

Recently I saw a CI job that the linter failed but that still ran all the tests.  I realized that travis runs script entries in parallel, which isn't the behavior we want, and also that instructions included in .travis.yml aren't easy for developers to reuse.  That prompted me to make the following changes to ensure our ci job fails fast on low-cost tests and is easier to reproduce locally:

moved the download and execution of golangci-lint to the pre-commit.sh script
moved the execution of the boilerplate check to pre-commit.sh

I also updated the version of helm to the latest and removed some unnecessary log output.

/lgtm


Negative numbers are shown as expression in DMN

Looks like this is fixed in recent versions of our toolkits.
Please checkout the Camunda Modeler nightly builds to verify this and provide more context the issue still exists.


Multiple Layouts in Browser

As a front end engineer,
I would like to be able to use different layouts for different routes in the browser,
So that I can separate responsibilities between layouts

On the server side, multiple layouts works as expected. On the client side, if you have 2 routes that each use a different Layout, when you navigate to the second route, the page is completely cleared. This happens because the second layout sets element to the html tag and then cannot figure out how to render into it.

i don't think its possible to solve this problem with Layouts as they are (i.e. including the html tag). a layout template can include its own script and css tags. here's a scenario that presents a lot of challenges:

Layout A includes a script tag that creates some state in memory. Layout B replaces Layout A. Who cleans up the state created by the script tag included in Layout A?
Layout A includes a script tag that creates some state in memory. Layout B includes the same script tag as Layout A. If including a script tag is NOT idempotent, what happens?
Layout A includes css. Layout B includes a different css file. Is Layout A's css still needed?
Layout A includes metatags that are used by third party tracking. Layout B does NOT include these metatags. Tracking doesn't work when you switch to Layout B.

There should always be a way to serve different html documents, however, I don't think it's feasible to transition from 1 to another in a browser - there's way too much complexity.
If there were 1 html file (in the browser) and you can change visual layout (i.e. something like replacing a Marionette region) that would be much simpler to implement. You change visual regions but not be allowed to change html documents on the client.
Due to complexity of this problem, and since it's possible to work well around the problem, I think this issue should be left out of 1.0.0 release. @bkpavan @leochen1216 @davydog187 @ericherdzik @ggentzke @sylnp0201 thoughts/concerns about dropping this from 1.0.0?

a new plan of attack here - layout is a regular view AND optional for a route. Probably still won't be able to have multiple layouts on a page but simplicity could lead to a better solution

closing because layout as View is not the right strategy


Did various improvements to CONTRIBUTING.md

Fixes

Fixes #973 by @Yash-Pratapwar
Description

This PR does various imrpovements to CONTRIBUTING.md file.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Yes, will change that.
On Thu, Nov 17, 2022, 09:51 Dhruv Bhanushali @.***>
wrote:

@.**** commented on this pull request.
In CONTRIBUTING.md
https://github.com/WordPress/openverse-api/pull/1009#discussion_r1024738863
:

-### Proposing changes or new features
+### Questions or Thoughts?

-If you have an idea of a new feature or change to how the Openverse API works, please start a discussion so we can discuss the possibility of that change or new feature being implemented and released in the future. This lets us come to an agreement about the proposed idea before any work is done.
+Feel free to join us on Slack and discuss the project with the engineers and community members on #openverse.
The "Questions or Thoughts?" section is already present at the bottom of
the file. This section should be changed to suggestion opening an issue
because we now use issues for discussion as well.
—
Reply to this email directly, view it on GitHub
https://github.com/WordPress/openverse-api/pull/1009#pullrequestreview-1183652491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APWNCAQHVYYCQUCZXQSDBKDWIWXFVANCNFSM6AAAAAASC56SOU
.
You are receiving this because you were mentioned.Message ID:
@.***>


Reporting answer from Seer interface is broken on mainnet

I couldn't reproduce this error (I tested and it worked on a forked mainnet). Maybe the issue was the wallet connected to another network? that was fixed on 7daaa1e


New release?

The last release was 2016 and there have been lots of commits since then.
Perhaps I am the only person in the world using melpa-stable.

I just updated from elpa and have v0.4.0 which appears to be the same as master now 👍
$ diff rust-mode-20181008.1628/rust-mode.el rust-mode-github-master/rust-mode.el
4d3
< ;; Package-Version: 20181008.1628

Based on what went on in issues #87 and #179 ... well, I'm trying to figure out what the right steps here are?
Is it just a matter of updating the version number in the .el file (as PR #178 did) and then tagging that commit as a release?
If so, I guess all I ask is that someone who uses melpa-stable to actually go ahead and make a commit with a version bump and submit a PR for that. And then I'll see about making a new tag for that release.

(I was tempted to assign myself, but I think that would give the wrong impression as if I were actually going to be the one to do the steps above. Since I do not use melpa-stable myself, I'm going to let someone else actually be the one who asserts "yes I tested this version out locally and it works in my melpa-stable environment."

Oh I see, someone already did the step of bumping the version number in #267

Okay I took the follow-on step of actually tagging the commit that bumped the version number (with that bumped version number) and then making a release off of that tag.
I'm going to assume that this is all that was needed to satisfy melpa-stable, and thus closing this issue. Do let us know if there are any remaining issues.

Thank you.  I've packaged the new version for Debian.


go get suddenly failing with 404s

The errors are somewhat inconsistent upon retries.

Thank you for any help! This is on go version go1.19.4 and also tried it on 1.18.10 with similar errors

@kari-malachi is it still the case?... we cannot reproduce it...

This hasn't come up again. Closing the issue.


feat(pdk) add error response function

This change allows plugins to set custom responses on >= 400 statuses.
Closes #5055

@locao, I don't quite follow here. response.exit has always allowed custom errors. But the problem the user reported is that you cannot easily make is consistent. As /kong_error_handler only handles some errors and some are done by response.exit. The /kong_error_handler has that Accept / Content-Type header logic that we don't have on exit. Is there a sister PR or is this missing some files?


Create installing_gekko_on_raspberry_pi_2_or_3.md

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Cause there have been some questions concerning installation on Raspberry Pi,
I have made a small manual, because you don't need to build anything from source.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Other information:

You can use git move like so:
cd gekko/docs
git mv installing_gekko_on_raspberry_pi_2_or_3.md installation/installing_gekko_on_raspberry_pi_2_or_3.md
git commit -m 'move rasp docs'
git push

After that it will automatically show up in this PR.

Hi Dalekxy, thanks you for your help.
I have found my problem. In /home/pi/gekko/web/vue/UIconfig.js I have put headless to true,

thanks!


How to create a custom TabCoordinatable

Is there any way to create a custom TabCoordinatable?
What I want is basically the function of menu changing, but I don't want the coordinator's view to be a tab view, but a custom menu instead.
I had a look at the source and tried to create my own protocol, but I'm getting several error messages stating that the children.dismissalAction is unaccessible due to internal protection level.
Any way to implement this?

Hi! At the moment it's a bit involved but it can absolutely be done. For instance, this is the code I use to create a "hamburger menu":

public class HamburgerChild: ObservableObject {
    @Published var childCoordinators: [AnyCoordinatable]
    var dismissalAction: DismissalAction
    @Published public var showMenu: Bool = false

    public init(detail: AnyCoordinatable, master: AnyCoordinatable?) {
        self.childCoordinators = [detail, master].compactMap { $0 }
        self.dismissalAction = {}
    }
}

public protocol HamburgerCoordinatable: Coordinatable {
    associatedtype Route
    associatedtype Start: View
    func resolveRoute(route: Route) -> AnyCoordinatable
    @ViewBuilder func start() -> Start
    var children: HamburgerChild { get }
}

public extension HamburgerCoordinatable {
    var childCoordinators: [AnyCoordinatable] {
        return children.childCoordinators
    }

    var dismissalAction: DismissalAction {
        get {
            children.dismissalAction
        } set {
            children.dismissalAction = newValue
        }
    }

    func coordinatorView() -> AnyView {
        return AnyView(
            HamburgerCoordinatableView(coordinator: self)
        )
    }

    func dismissChildCoordinator(_ childCoordinator: AnyCoordinatable, _ completion: (() -> Void)?) {
        fatalError("not implemented")
    }
}

struct HamburgerCoordinatableView<T: HamburgerCoordinatable>: View {
    var coordinator: T
    let router: HamburgerRouter<T.Route>
    @ObservedObject var children: HamburgerChild

    init(coordinator: T) {
        self.router = HamburgerRouter(coordinator)
        self.coordinator = coordinator
        self.children = coordinator.children
    }

    public var overlay: some View {
        ZStack {
            Color.black.opacity(!router.showMenu ? 0 : 0.6).edgesIgnoringSafeArea(.all)
            if router.showMenu {
                Color.black.opacity(!router.showMenu ? 0 : 0.0006).edgesIgnoringSafeArea(.all).onTapGesture {
                    router.showMenu = false
                }
            }
        }
        .animation(.easeOut(duration: 0.25))
    }

    var body: some View {
        return GeometryReader { geometry in
            ZStack(alignment: .topLeading) {
                if coordinator.childCoordinators.dropFirst().first != nil {
                    coordinator.childCoordinators[1].coordinatorView()
                        .overlay(overlay)
                } else {
                    coordinator.start()
                        .overlay(overlay)
                }
                coordinator
                    .childCoordinators[0]
                    .coordinatorView()
                    .frame(width: 290)
                    .offset(x: !router.showMenu ? -290 : 0, y: 0)
                    .animation(.easeOut(duration: 0.25))
            }
        }
        .environmentObject(router)
    }
}

class HamburgerRoutable {
    var _anyRoute: (Any) -> Void

    func anyRoute(to route: Any) {
        _anyRoute(route)
    }

    init<T: HamburgerCoordinatable>(coordinator: T) {
        _anyRoute = { viewRoute in
            let resolved = coordinator.resolveRoute(route: viewRoute as! T.Route)

            if coordinator.children.childCoordinators.dropFirst().first == nil {
                coordinator.children.childCoordinators.append(resolved)
            } else {
                coordinator.children.childCoordinators[1] = resolved
            }
        }
    }
}

public class HamburgerRouter<T>: ObservableObject {
    private let routable: HamburgerRoutable
    private let child: HamburgerChild

    public func route(to route: T) {
        routable.anyRoute(to: route)
    }

    public var showMenu: Bool {
        get {
            return child.showMenu
        } set {
            child.showMenu = newValue
        }
    }

    init<U: HamburgerCoordinatable>(_ coordinator: U) {
        self.routable = HamburgerRoutable(coordinator: coordinator)
        self.child = coordinator.children
    }
}

but yes, this process could and should be simplified...

I've tried implementing the code above, as I'm trying to code a menu similar to a hamburger menu. How would I handle the routing, let's say for example if the user clicks an option in the master view, how would I be able to change it in the detail?
`final class IPadCoordinator: PadCoordinatable {
var children = PadChild(detail: NavigationViewCoordinator(HomeCoordinator()).eraseToAnyCoordinatable(), master: NavigationViewCoordinator(ProductsCoordinator()).eraseToAnyCoordinatable())
enum Route {
    case customers
    case products
}

func resolveRoute(route: Route) -> AnyCoordinatable {
    switch route {
    case .customers:
        return NavigationViewCoordinator(CustomersCoordinator()).eraseToAnyCoordinatable()
    case .products:
       return NavigationViewCoordinator(ProductsCoordinator()).eraseToAnyCoordinatable()
    }
}

func start() -> some View {
    SplashView()
}

}`
I understand the route is used when changing to a different coordinator, routing to either .customers or .products would replace my current coordinator with a new one. Is this the correct way of implementing this?

As per the documentation:
You can also fetch routers referencing coordinators that appeared earlier in the tree. For instance, you may want to switch the tab from a view that is inside the TabView.

So using @EnvironmentObject var masterRouter: PadRouter<IpadCoordinator.Route> you can change the master.
If you want the detail, well, the code I pasted above doesn't support that. You'd need to add another function:
public class HamburgerRouter<T, V>: ObservableObject {     public func routeDetail(to route: V) {     ...
in the router and the routable something like:
`
class HamburgerRoutable {
var _anyRoute: (Any) -> Void
var _anyDetailRoute: (Any) -> Void
func anyRoute(to route: Any) {
    _anyRoute(route)
}

func anyDetailRoute(to route: Any) {
    _anyDetailRoute(route)
}

init<T: HamburgerCoordinatable>(coordinator: T) {
    _anyRoute = { viewRoute in
        let resolved = coordinator.resolveRoute(route: viewRoute as! T.Route)

        if coordinator.children.childCoordinators.dropFirst().first == nil {
            coordinator.children.childCoordinators.append(resolved)
        } else {
            coordinator.children.childCoordinators[1] = resolved
        }
    }

    _anyDetailRoute = { viewRoute in
        let resolved = coordinator.resolveRoute(route: viewRoute as! V.Route)
        coordinator.children.childCoordinators[0] = resolved
    }
}

}
`
and probably also change some other details.
Also note that the code posted is quite old, so it doesn't support the newest features such as RouterStore.

Thank you, I was able to use this to get it to work the way I wanted.
I just have another question.
Is it possible, for example, to route the detail to another coordinator but change the start of said coordinator? 🤔  Or would i have to create a new one for that?
What's the best current approach for this?

I'm not 100% sure I understand what you're going for here, but I guess if you're for example using a NavigationCoordinatable you can probably do something like
class MyCoordinator: NavigationCoordinatable {

    init(startA: Bool) {
        self.startA = startA
    }

    @ViewBuilder func start() -> some View {
        if startA {
            StartA()
        } else {
            StartB()
        }
[...]

Thank you so much for your help!
This project and your assistance have been really helpful for me. Love Stinsen 🎉


fix: test adding now.json config for static deploys

Closing this out - no longer needed with solution just merged down to master


added a virtual environment for mac users

This is not something that should be part of the library.
If you're testing out pull requests, please use your own repository to do so.


Rails 3.1 Support

I tried this out, there were originally 4 errors but 1 is easy to fix.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index 5f6030e..1ea78f9 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -1,6 +1,12 @@
require 'rspec'
module Rails

class << self

3.0 defaults this, 3.1 does not

def application

 "application"

end
end
end

require 'resort'
This patch takes care of an error in the migration test.
Still have 3 more errors, but I don't really see a logic issue here.  Anyway if I figure it all out I'll send a pull request.

Resort::Sortable InstanceMethods#append_to appending 2 after 3 appends the element after another element
Failure/Error: article1.next.name.should == '3'
NoMethodError:
undefined method `name' for nil:NilClass
./spec/resort_spec.rb:361:in `block (5 levels) in module:Resort'

Resort::Sortable InstanceMethods#append_to appending 2 after 4 appends the element after another element
Failure/Error: article1.next.name.should == '3'
NoMethodError:
undefined method `name' for nil:NilClass
./spec/resort_spec.rb:380:in `block (5 levels) in module:Resort'

Resort::Sortable InstanceMethods#append_to appending 3 after 1 appends the element after another element
Failure/Error: article2.next.name.should == '4'
NoMethodError:
undefined method `name' for nil:NilClass
./spec/resort_spec.rb:413:in `block (5 levels) in module:Resort'

Finished in 2.53 seconds
34 examples, 3 failures

Found the actual issue, still researching a fix.
In delete_from_list() when setting self.previous = nil, Rails is actually writing that nil all the way through the relation to previous.next_id.
45        def define_writers
46          name = self.name
47
48          model.redefine_method("#{name}=") do |value|
=> 49            association(name).writer(value)
50          end
51        end
52    end
53  end
(rdb:1) v l
p => #<Article id: 61, name: "1", price: nil, first: true, next_id: 63, created_at: "2011-12-08 21:18:34", updated_at: "2011-12-08 21:18:52">
(rdb:1) p name
:previous
(rdb:1) p value
nil

Closing this, I've sent the pull request.


Development

Fixes two bugs reported here: https://github.com/lstein/stable-diffusion/issues/619#issue-1376284608

Reproducer: python backend/server.py

Traceback (most recent call last):
  File "C:\Users\quaestor\Source\stable-diffusion-stable\backend\server.py", line 22, in <module>
    from ldm.dream.pngwriter import PngWriter, PromptFormatter
ImportError: cannot import name 'PromptFormatter' from 'ldm.dream.pngwriter' (c:\users\quaestor\source\stable-diffusion-stable\ldm\dream\pngwriter.py)

Fix: PromptFormatter is an extraneous dependency, removed.

Reproducer: attempt to generate an image

Traceback (most recent call last):
  File "C:\Users\quaestor\Source\stable-diffusion-stable\backend\server.py", line 375, in generate_images
    model.prompt2image(
  File "c:\users\quaestor\source\stable-diffusion-stable\ldm\generate.py", line 344, in prompt2image
    results = generator.generate(
  File "c:\users\quaestor\source\stable-diffusion-stable\ldm\dream\generator\base.py", line 73, in generate
    image_callback(image, seed)
  File "C:\Users\quaestor\Source\stable-diffusion-stable\backend\server.py", line 364, in image_done
    path = save_image(image, all_parameters, result_path, postprocessing=postprocessing)
  File "C:\Users\quaestor\Source\stable-diffusion-stable\backend\server.py", line 310, in save_image
    path = pngwriter.save_image_and_prompt_to_png(image, command, filename)
TypeError: PngWriter.save_image_and_prompt_to_png() missing 1 required positional argument: 'name'

Fix: Corrects function call - function had changed in recent work on metadata.

Fixed metadata reading. Modified ldm.dream.pngwriter.retrieve_metadata to also grab the old Dream REPL command. Updated references to retrieve_metadata so they are not affected. This is necessary for the new UI to fall back to reconstructing metadata from the REPL command if the new sd-metadata field is unpopulated.

We're playing "I'll fix this one way and you'll fix that in another way". I have found and fixed the conflict, doing final testing...


Correction for raw affiliation Sorbonne Universite, LIP6

Correction needed for raw affiliation Sorbonne Universite, LIP6
raw_affiliation_name: Sorbonne Universite, LIP6
new_rors: 02en5vm52;05krcen59
previous_rors: 02en5vm52
works_examples: W4393505523;W4387075356
contact: 8dead1baaff503e615c42e6fca282390:3f820d1307fbe6ffb0e6b7b95d @ sorbonne-universite.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-01. The new affiliations should be visible within the next 7 days.


Handle null item times and adjust cost thresholds in getHeroItemPopularity

getHeroItemPopularity can error if item.time is null. #2663
Also adjust cost thresholds used in defining early, mid, and late game items. See review comments

Here is the existing logic:
    const startGameItems = countItemPopularity(
      items.filter((item) => item.time <= 0)
    );
    const earlyGameItems = countItemPopularity(
      items.filter(
        (item) => item.time > 0 && item.time < 60 * 10 && item.cost > 700
      )
    );
    const midGameItems = countItemPopularity(
      items.filter(
        (item) =>
          item.time >= 60 * 10 && item.time < 60 * 25 && item.cost > 2000
      )
    );
    const lateGameItems = countItemPopularity(
      items.filter((item) => item.time >= 60 * 25 && item.cost > 4000)
    );

My first proposition is that start game items is redefined:
    const startGameItems = countItemPopularity(
      items.filter((item) => item.time <= 0 && item.cost <= 600)
    );

because, apparently null <= 0 will return true in js. So, in case a null time is recorded for a lategame item, we can add item.cost <= 600 to filter any of those potential edge cases. 600 is the starting gold.
My other proposition is to adjust the item.cost filters used in mid and late game items. Because, 2000 and 4000 feel like really high thresholds, so will discard a lot of other items. My recommendation would be:
    const midGameItems = countItemPopularity(
      items.filter(
        (item) =>
          item.time >= 60 * 10 && item.time < 60 * 25 && item.cost > 1200
      )
    );
    const lateGameItems = countItemPopularity(
      items.filter((item) => item.time >= 60 * 25 && item.cost > 1800)
    );

@howardchung what do you think?

I feel like if we want to check for null, we should explicitly do that check rather than relying on the 600 gold filter (since that could change)

The LIKE query is going to be slow because there isn't a text index on that column.

@howardchung thoughts on these changes?

My only blocking concern is changing the filter condition to:
.filter((item) => item && item.key)

My only blocking concern is changing the filter condition to: .filter((item) => item && item.key)

How do you mean? I've added: .filter((item) => item !== null && item.key !== null)
Do you want to add item.time !== null?

That depends on the behavior we want if time is null/undefined. If we want to default it to 0, then we shouldn't add it.
But the change I'm asking for is either to just check for item && item.key or item != null && item.key != null to handle undefined (which may not be possible, but I figure it's safer)

@howardchung thanks 👍


Test phrases

Added a convenience method for tokenizing a phrase, plus tests and test fixtures against that method.
Fixes #143.
/cc @mcwhittemore @lyzidiamond

It's not related to this PR directly but is it possible also to change arguments order of new tokenize(instruction, replaceTokens, language) function to move language argument first as in all other index.js's methods?

@yuryleb, thanks for the suggestion. I opened #149 with that change.

I understand your hesitation around the additional compilePhrase() method. I ended up adding it mainly because it was necessary for unit testing phrase generation. I’d be fine with considering it a private method and not documenting it for clients (although it still needs to be exported for the tests).

Can't the tests just call compile and then tokenize?

Can't the tests just call compile and then tokenize?

Good point. Done.


[FR] Update OpenSSL to latest version

Right now the latest version of OpenSSL on https://maven.google.com is 1.1.1.d while https://www.openssl.org/ published 1.1.1e and 1.1.1f in the meantime.
Do you plan on updating OpenSSL and other libraries regularly once you're out of the alpha stage?
I'm also curious what your thoughts are around responding to security issues in libraries.

There's a big item on my to-do list to take some auto-updating tools that @hhb wrote for handling these sorts of things in AOSP and putting them to use here. Not having had the time to do that is a lot of the reason for the alpha labels.
I can get an update out for this fairly trivially though, so thanks for the nudge!

Uploaded https://android-review.googlesource.com/c/platform/tools/ndkports/+/1282033 to update each of them (json-cpp has no updates). Still need to check the NDK sample to make sure it's not horribly broken though :)

Basically ready to ship, but our maven tooling was recently migrated so I'm waiting on some approvals before I can actually click the publish button. Should be up tomorrow.

Done now. Sorry for the delay!

Thank you!

@DanAlbert OpenSSL just published 1.1.1g which includes a "Severity: High" security fix for https://www.openssl.org/news/secadv/20200421.txt.

Thanks for the heads up. Starting an update.

Live now. Will get the NDK sample updated to match shortly.


Crash Android

Hello everyone.
I have a problem about these. When upgrade compileSdkVersion in android, app is crash. Crash looks like these.

@machour this is closable - it will be something user-specific, the module installs and runs fine on a clean react-native app right now


change Arduino Extension by Microsoft

I have tried and feel better than other. support directly.

You're right, first one stopped development :(
Great, thanks for the PR 👍


Python error when trying to run label-studio after installing via pip

Describe the bug
I installed Label Studio via pip, as described on the main GitHub page. However, when I try to run it a Python exception is being thrown:
$ label-studio
=> Database and media directory: /home/mfb/.local/share/label-studio
=> Static URL is set to: /static/
Starting new HTTPS connection (1): pypi.org:443
https://pypi.org:443 "GET /pypi/label-studio/json HTTP/1.1" 200 46133
Traceback (most recent call last):
  File "/home/mfb/.local/bin/label-studio", line 8, in <module>
    sys.exit(main())
  File "/home/mfb/.local/lib/python3.8/site-packages/label_studio/server.py", line 282, in main
    _setup_env()
  File "/home/mfb/.local/lib/python3.8/site-packages/label_studio/server.py", line 40, in _setup_env
    application = get_wsgi_application()
  File "/home/mfb/.local/lib/python3.8/site-packages/django/core/wsgi.py", line 12, in get_wsgi_application
    django.setup(set_prefix=False)
  File "/home/mfb/.local/lib/python3.8/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/home/mfb/.local/lib/python3.8/site-packages/django/apps/registry.py", line 114, in populate
    app_config.import_models()
  File "/home/mfb/.local/lib/python3.8/site-packages/django/apps/config.py", line 211, in import_models
    self.models_module = import_module(models_module_name)
  File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 848, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/mfb/.local/lib/python3.8/site-packages/label_studio/users/models.py", line 18, in <module>
    from projects.models import Project
  File "/home/mfb/.local/lib/python3.8/site-packages/label_studio/projects/models.py", line 16, in <module>
    from tasks.models import Task, Prediction, Annotation, Q_task_finished_annotations, bulk_update_stats_project_tasks
  File "/home/mfb/.local/lib/python3.8/site-packages/label_studio/tasks/models.py", line 29, in <module>
    from core.label_config import SINGLE_VALUED_TAGS
  File "/home/mfb/.local/lib/python3.8/site-packages/label_studio/core/label_config.py", line 9, in <module>
    import jsonschema
  File "/usr/lib/python3/dist-packages/jsonschema/__init__.py", line 11, in <module>
    from jsonschema.exceptions import (
  File "/usr/lib/python3/dist-packages/jsonschema/exceptions.py", line 152, in <module>
    @attr.s(hash=True)
AttributeError: module 'attr' has no attribute 's'

To Reproduce
Steps to reproduce the behavior:

run pip install label-studio
run label-studio

Environment (please complete the following information):

OS: Ubuntu 20.04
Label Studio Version: latest version from PyPi

python3 -m venv env
source env/bin/activate
pip install label-studio
label-studio

This fixed it for me without virtual environment:

pip uninstall attr
pip install attrs

Reference: stackoverflow

uninstalling attr and installing attrs didn't solve the issue for me.
I got it working with
pip uninstall attr pip install jsonschema==4.9.1 attrs==22.1.0


Usage guidelines

There isn't much in the documentation in terms of usage guidelines. More specifically, should Producer and/or Topic instances be re-used or should singleton instances be used? What is the cost of creating new instances of each? What happens when they are disposed?

They're relatively heavy-weight as they create threads to communicate with the different brokers. I'd recommend creating only few instances.
When you dispose them they're shut down and they need to do quite a bit of work again on construction.

I suspected as much, but good to have verified :) Would be nice to have that info in the examples.


Possible dataset

https://github.com/lponisio/hedgerow_assembly/tree/master/data

https://onlinelibrary.wiley.com/doi/abs/10.1111/ele.12821

Done, Mangal dataset ID #76, location still missing, see issue #30


Task<byte[]> method using puppeteer-sharp not always ready on time

Description
Link to stackoverflow question
Method which I return Task<byte[]> with puppeteer-sharp does not always returns the full data. Actually it returns the full data only in debug or first time when i make request to the API. In the other cases i get PDF with only some of the data i expect.
I first tought I may have missed something in the API controller implementation, but now it seems like problem could be in the puppeteer library instead.
Versions

Which version of PuppeteerSharp are you using?
1.11.2

Which .NET runtime and version are you targeting? E.g. .NET framework 4.6.1 or .NET Core 2.0.
.NET framework 4.7.2

Do you have something for me to test?
An isolated piece of code would be useful.

Is there a prbolem with the code sample in Stackoverflow? That is the exact recreation of the problem, without the real HTML content

@cap7ainjack are you getting that issue with any content you pass to GetAsync?
If I send, just "hello world", it will break?

I have not tried with "Hello world" kind of html. I load a couple of css`s and a bit more complex but not enourmous HTML. Do you want to send you the HTML content (without css) or the two output pdf files where can be seen the difference?

Hello! Any new on the topic? Do you need something additional?

@cap7ainjack when you say "it returns some partial result." It's a valid PDF with missing content or a broken byte array?

It's a valid PDF with missing content.

If you get a valid PDF file there is no "missing PDF data".
Did you try waiting a little bit more before generating the PDF?

Yes, when I`m doing this in Debug mode it works fine. Otherwise not, in the most cases.

Can't you wait for a CSS selector to be ready?

`
using (var page = await browser.NewPageAsync().ConfigureAwait(false))
{
await page.SetCacheEnabledAsync(false).ConfigureAwait(false);
            await page.SetContentAsync(html).ConfigureAwait(false);
            await page.AddStyleTagAsync("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700").ConfigureAwait(false);
            await page.AddStyleTagAsync("http://localhost:55448//client-cli/output/css/bootstrap.min.css").ConfigureAwait(false);
            await page.AddStyleTagAsync("https://cdnjs.cloudflare.com/ajax/libs/MaterialDesign-Webfont/3.4.93/css/materialdesignicons.css").ConfigureAwait(false);
            await page.AddStyleTagAsync("http://localhost:55448//client-cli/output/css/kendo.css").ConfigureAwait(false);
            await page.AddStyleTagAsync("http://localhost:55448/client-cli/output/css/themes/default/styles.css").ConfigureAwait(false);
            await page.AddStyleTagAsync("http://localhost:55448/client-cli/output/css/styles-pdf.css").ConfigureAwait(false);

            var result = await page.GetContentAsync().ConfigureAwait(false);

            PdfOptions pdfOptions = new PdfOptions()
            {
                PrintBackground = true,
                MarginOptions = new PuppeteerSharp.Media.MarginOptions { Right = "15mm", Left = "15mm", Top = "20mm", Bottom = "20mm" },
            };

            await page.EmulateMediaAsync(PuppeteerSharp.Media.MediaType.Screen);
            streamResult = await page.PdfDataAsync(pdfOptions).ConfigureAwait(false);

            await page.CloseAsync().ConfigureAwait(false);
        }`

This is example how i add the css, there is a few more CSS that i load in the same manner. I think this is how I should wait for them. Am I doing it wrong somehow?

Hello! Do you find some mistakes with the implementation?

You could add an element at the bottom of the page and then use WaitForSelector to wait for that element. There is no rule of thumb to know when the page is loaded. You need to evaluate the page and see what you should check to know when your page is ready to evaluate.

Closed due to inactivity. Feel free to reopen it if needed.


ts-guard-decorator

Hi,
after upgrading to latest version of ng-sidebar, application stopped work with error:
Failed to load resource: the server responded with a status of 404 (Not Found) :8000/ts-guard-decorator
Error: Fetch error: 404 Not Found
  Instantiating http://localhost:8000/ts-guard-decorator
  Loading http://localhost:8000/lib/ng-sidebar/lib/sidebar.component.js
  Loading http://localhost:8000/lib/ng-sidebar/lib/index.js

Any idea?

@Olmer1st Yeah, @siovene found a solution. I'll be pushing out an update soon to "fix" this.

I've published v4.2.1 without ts-guard-decorator.
@Olmer1st Were you also using SystemJS?

Great! Thanks.
Yes. I use systemjs. I don't like webpack


feat: allow merge on extra env vars

In fact, only list does not support merge. We agree that all list is rewritten as map， (list in k8s generally has a key called name, and this name can be used as the key of the map)
value.yaml before
# value.yaml

env:
  - name: NODE_ENV
    value: production
  - name: PORT
    value: "3333"
  - name: SOME_SECRET
    valueFrom:
      secretKeyRef:
        key: SOME_SECRET
        name: some-secret

value.yaml after
# value.yaml

env:
  NODE_ENV:
    - name: NODE_ENV
      value: production
  PORT:
    - name: PORT
      value: "3333"
  SOME_SECRET:
    - name: SOME_SECRET
      valueFrom:
        secretKeyRef:
          key: SOME_SECRET
          name: some-secret

deployment.yaml
{{- with .Values.env }}
    env:
    {{- range $key, $value := . }}
    {{- toYaml $value | nindent 8 }}
    {{- end }}
{{- end }}

This will support the merge of list.

I don't like the duplication of  NODE_ENV in the following sample:
env:
  NODE_ENV:
    - name: NODE_ENV
      value: production

Also, if we wanna go that path, we'd need to update documentation, and since it's possible to merge env: also we could get rid of extraEnvVars.
But I'm still not convinced. :thinking:

I don't like the duplication of NODE_ENV in the following sample:

Me either. but the good news is it works in this way.

I don't like the duplication of NODE_ENV in the following sample:
env:
  NODE_ENV:
    - name: NODE_ENV
      value: production

Also, if we wanna go that path, we'd need to update documentation, and since it's possible to merge env: also we could get rid of extraEnvVars.
But I'm still not convinced. 🤔

@endersonmaia
Helm treats lists as replacing the previous list, not merging them. In Kubernetes Helm charts, lists often represent an array of items, and Helm's default behavior is to replace the entire list with the new one from the values file.

This should be solved with #79


Reenable PingPerf on zlinux, alinux and plinux

switch PingPerf to use main branch (from instanton branch)

related: https://github.com/adoptium/aqa-tests/issues/4632 and https://github.com/OpenLiberty/ci.docker/pull/412

Grinder


Lab14shoppingcart

https://github.com/harguss/Shopping-Cart/pull/1
We didn't get a lot figured out but I still enjoyed my time with Misti.


investigate failing master on Travis

Reticketed from #3988.

This is still an issue:

Doesn't seem to be a single issue, though they appear to generally be network-related:
https://travis-ci.org/gratipay/gratipay.com/builds/144060555#L1031-L1032
There's a bunch of:

assert <ErrorResult 'Transaction can only be voided if status is authorized or submitted_for_settlement.' at 2b11c259a810>.is_success

https://travis-ci.org/gratipay/gratipay.com/builds/138327150#L1050
https://travis-ci.org/gratipay/gratipay.com/builds/138247355#L1028
https://travis-ci.org/gratipay/gratipay.com/builds/138246002#L1022
https://travis-ci.org/gratipay/gratipay.com/builds/138243055#L1025
https://travis-ci.org/gratipay/gratipay.com/builds/138242378#L1020

Is this a dupe of #3266?

No. They're two different errors.

Please reopen if this still happens.

I'm not finding a good history view in Travis for the master branch. I think the past few have been okay? 😕


Tooltip should be placed slightly further from its target

🐛 Bug Report

There should be more space between target and tooltip as seen here https://spectrum.adobe.com/page/tooltip/
🤔 Expected Behavior

😯 Current Behavior

💁 Possible Solution

🔦 Context

💻 Code Sample

🌍 Your Environment

Software
Version(s)

react-spectrum

Browser

Operating System

🧢 Your Company/Team

🕷 Tracking Issue (optional)

Working on it.

Had an "offline" chat with @snowystinger - it doesn't seem to be always the case, like on the help icon:

An alternative suggested approach is to:

find a good default and a way to modify it.


Non-Programming Question - OwnYourSwarm without Micropub?

I'd love to use OwnYourSwarm, but I don't have a Micropub site to publish to.  As a result, I cannot figure out how to configure credentials.json with the appropriate information.

I'm not sure what credentials.json file you're referring to. The payload that OwnYourSwarm sends is documented on the website here: https://ownyourswarm.p3k.io/docs It happens to be a Micropub request, but really it's just a JSON payload.


[CARBONDATA-1863][PARTITION]Supported clean files for partition table

It clean all invalid data after drop partition from all the segments through clean command
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[X] Any interfaces changed? NO

[X] Any backward compatibility impacted? NO

[X] Document update required? YES

[X] Testing done
Tests added

[X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2480/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2481/

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/1004/

LGTM

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2227/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2487/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2488/


Add Semantic Kernel for Java

@brunoborges can you give me context on this PR?

@brunoborges can you give me context on this PR?

I need to include the Semantic Kernel for Java SDK to the Java API browser

Adding this library here would put the library under the Azure SDK for Java section of the Java API browser. Since this library is not for a specific azure service and not a part of the Azure SDK for Java namespace or in the Azure SDK for Java repo, this is probably not the right section of the Java API Browser for this library.


Remove global variable

Generally bad practice to use global variables and easily fixable in this case

I suspect that this will make the code run slower, because of the extra indirections. Is there a stronger argument than "generally bad practice"?

I don't think you'll be able to detect any difference in performance here. CPUs are crazy good at these kinds of patterns.
My context is that I was working on turning this CLI into a library and needed to call it potentially many times from the same process, so having global variables was undesirable. There is one more place with static variable in disk reads that would still be a blocker for that though.
I saw the opportunity to improve code a bit and decided to contribute back, but if it is not a welcome change that is fine too.

we have measured performance degradation with smaller changes in the past. If you can demonstrate that there's no slow-down, I think this is a fine change.
I think your use case is a pretty strong argument and might be worth a small slow-down. But I think it would have to be quantified (and not assumed or guessed)

on the other hand, given bladebit, perhaps we don't care so much about a performance degradation in chiapos.

I ran ProofOfSpace with tmpfs a few times on 13900k and took the best result out of a few runs.
Before:
k22 7.786
k25 65.272

After:
k22 7.752
k25 63.996

I'm not sure it became faster, but shouldn't be significantly slower either. My test was not super scientific, I have a bunch of things running in background on my machine.

We're short on time to review this, but if you fork chiapos and it works well for you, we'll consider up-streaming it.


Standard Mythos events

How can I overwrite the standard 'no immediate effect' Mythos events?

I think I just figured it out. Is the solution to not make EventStart set $mythosFlavor to 1?

Yep. You can set different types of mythos as shown here:
https://github.com/NPBruce/valkyrie/wiki/ValkyrieVars
Or just write your own using Mythos as a trigger.


Loop over all .chained when adding a new formset

When adding a new formset with multiple chainedM2M any work because we only iterate
in all $('.chained-fk') and not in $('.chained')

Coverage remained the same at 88.696% when pulling 3ee58675dd1324d8553251df07addf5c8bdb656e on erozqba:multiple-selects into 7a5327ed4e1c4981f1e1be2d5452b427e5e09724 on digi604:master.

Thanks!


Removing test redundant for org.apache.commons.lang3.builder.DefaultToStringStyleTest.testObjectArray

We are researchers working on identifying redundant tests in a test suite. Our analysis of finding redundant tests involve each test's dynamic code coverage and their potential fault-detection capability.
Through our analysis, we found that the tests org.apache.commons.lang3.builder.DefaultToStringStyleTest.testObjectArray, org.apache.commons.lang3.builder.RecursiveToStringStyleTest.testObjectArray are redundant with respect to one another. In this pull request, we are proposing to keep only the test org.apache.commons.lang3.builder.DefaultToStringStyleTest.testObjectArray while adding @Ignore annotations to the remaining test. However, as we believe these tests are identical, any one of them can be kept while skipping the remaining test.
If you do not believe any of these tests should be ignored, we would greatly appreciate it if you could follow up on this pull request and let us know your reasons.

Coverage increased (+0.02%) to 93.465% when pulling 5de23610c9d99b9a67e1e5226bcf088e90f1bc57 on TestSuiteReductionResearch:redundant3 into bd9adbb637a8a4aa5eb61c6fde2c576d0ab3c4fa on apache:master.


Remove vmservice from Flutter apps in release mode

As @rmacnak-google noticed, snapshots of Flutter applications compiled in release mode still contain vmservice code. This happens due to entry points

{"dart:_vmservice", "::", "boot"} in precompiler.cc
"dart:vmservice_io,::,main" in dart_vm_entry_points.txt

We should be able to remove those entry points and exclude vmservice code and its dependencies in Flutter release mode.
/cc @rmacnak-google @mraleph

As per our discussion, we should be able to exclude vmservice entry points once we support specifying mode-specific (!product) entry points with @pragma annotations.

@sjindel-google is taking over this
My prototype CL that added support for @pragma('vm.extern', ...) is here: https://dart-review.googlesource.com/c/sdk/+/55400

@sjindel-google's work has reached Flutter framework:


onChange and onBlur validation errors should prevent submission of form

Currently, when using a field with:
<Field onChange={z.string().min(1)}>

When the user submits the form, it does not show a form error on submit. This causes headaches currently as it makes things harder to workflow properly.

Hey @crutchcorn
Can you assign this to me please

Can you aasign this issue to me?

hey @I-MirzaBaig
I am working on this. Could you pick any other open issue.

@vikaskumar89 Alright!

Hey @crutchcorn
The root cause of this error is because we have defined undefined for the submit cause that leads to validateSync returning early and not executing any onBlur/onChange validation.
One solution that comes to my mind is in case of submit cause, we can execute either onChange or onBlur validation(whichever is defined in the field) but this would lead to incorrect errorMap detail as the errorMapKey would be submit but the error would correspond to onChange/onBlur.
Do you have any alternate suggestion to fix this ?

Due to this errorMap array, we are facing this issue in https://github.com/TanStack/form/issues/486, as the errorMap is not clear after a valid value is entered.

Is there currently a workaround to this?

I'm not sure when the maintainer will merge this, but is there any other way we can work around these issues temporarily?


Support to python3

Are there plans to support python3?

+1

Need python3 support or is python3 is supported? If supported then there is a bug in strings.py file. "unicode" and "basestring" keywords are not supported in python3. Please have a look.


reg:squarederror

Hi and thanks for your work.
Py's XGB now uses reg:squarederror as default objective. Is this not supported here (it's not in the list of supported objs)?

Hi George, thanks for asking. But we're not working on this recently. If possible, could you please implement it and create a PR? We'll merge and create a release. Thanks!


Updates OCI SDK

Signed-off-by: Laird Nelson<EMAIL_ADDRESS>

Closing and will re-spin to work around build issues.

Closing and will re-spin to work around build issues.


Backport 18750, 20470

Backporting these are important for CI in https://github.com/dashpay/dash/pull/4473
kuddos to @kittywhiskers for 20470

Changed my mind, going to package this into 4473 since CI is being annoying w/ it on it's own (likely due to mac depends cache)


Zoom Connection

How do i send Interactive avatar to my zoom meeting?
I have and knowledge base, which I can provide access to interactive avatar so that interactive avatar can generate reponses based upon that, but I want that in zoom meeting

+1


Update FAQ.md

Add list of shortcuts to FAQ (hitting F1 requires shifting the focus).

In markdown that looks worse, but ok :) (at least searchable)

at least searchable

Yep!
Can you also resolve the conflicts


feat: support test macro for contract functions

Feature Request
Describe the Feature Request
It is useful at times to have contract functions that are only exposed for testing, and are not compiled outside of tests.
Describe Preferred Solution
Extend the test macro to functions
#[contract]
mod Foo {

    #[external]
    fn foo() -> u128 {
        ...
    }

    #[external]
    #[cfg(test)]
    fn bar() -> u128 {
        ...
    }
}

Describe Alternatives
We could dynamically inject the additional code into the contract with some scripts before running a test command, but it would be nice to have it work natively with Cairo test runner.
If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

[ ] Yes
[ ] No

this should already work - although i won't recommend using it - as the order of the run of plugins is not ensured.
(the config plugin would run before the starknet plugin as far as i know, but trusting the ordering seems like bad practice)


Add FAQ link to README.md

@KamilSzostak,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Error when installing for Linux

Hello. When you install the linux installer in a shell, under a non-root user but using sudo, the app gets installed but raises the following warning message:
Problem running post-install step. Installation may not complete correctly. Error reading INI file /root/Desktop/Agama Desktop.desktop

Please execute below command to remove ini file, This will resolve your issue and then launch Agama App again.
sudo rm /etc/SuperNETOrg-AgamaApp.ini

Ok. Thanks.


Work items for 4.6.2

Below are the works items that need to be addressed for the 4.6.2 release

[x] manually apply change from PR #2259 into master, cherry pick to 4.6 branch (Steve)
[x] cherry pick PR #2926 to 4.6 branch (Colonel)
[x] publish 4.6.2 bits (Colonel)
[ ] back out CoreBot.tests changes from dotnet samples repo (Scott)
[ ] back out CoreBot.tests changes to .NET Template (Scott)
[ ] back out CoreBot.tests changes to VSIX (Scott)
[ ] bump .NET Core Template version numbers to 4.6.2, update csproj files to use 4.6.2 assemblies (Scott)
[ ] bump VSIX version number to 4.6.2, update csproj files to use 4.6.2 assemblies (Scott)
[ ] bump csharp_dotnet samples to use 4.6.2 Bot Fx (Johnny)
[ ] publish .NET Templates (EchoBot, CoreBot, EmptyBot) (Colonel)
[ ] publish 4.6.2 version of VSIX (Colonel)

PR to revert cancel is submitted. #2929

4.6.2 packages are on MyGet.
https://botbuilder.myget.org/feed/botbuilder-v4-dotnet-daily/package/nuget/Microsoft.Bot.Builder/4.6.2

VSIX, .NET Templates, and C# CoreBot.tests test changes have been merged in PR #1960

VSIX, .Net Templates and packages are all on MyGet.


Mention Maven coordinates in README

First of all, thanks a lot for forking the JavaPoet project and implementing some of its missing functionality!
In case this fork is intended to be used by the public (and its main purpose is not for Palantir only), it would be useful to mention the Maven coordinates (I assume com.palantir.javapoet:javapoet) in the README. For example with code snippets for Gradle and Maven, and maybe a link to Maven Central and javadoc.io.
Currently it is not obvious that artifacts have already been published, and what their coordinates are.

Good idea! Our goal is to maintain this library, since we use poet pretty heavily, but not to make it in any way Palantir-specific. Would you be interested in making that docs PR? Otherwise someone on my end can take a crack at it in the next couple weeks

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

Have created #56, I hope it is ok like this.
I wasn't aware though that this requires a CLA...; I won't sign it for this, sorry.

Our goal is to maintain this library, since we use poet pretty heavily

In that case might be worth commenting on https://github.com/square/javapoet/discussions/866. What do you think?

In that case might be worth commenting on https://github.com/square/javapoet/discussions/866. What do you think?

Great idea, done!

square/javapoet has been archived and its README now points to the Palantir repository, just in case you are wondering about increased traffic in the future.


fix viewbox for evolution-arrow

Browsers seem to correct only the first evolution-arrow. If more than one svg gets rendered, their viewbox is messed up. You can see on every detailview with more than evolution that only the first arrow is centered correctly.

Nice, thank you!


Animlock updates and several fixes

This PR improves the animation lock calculation function.

refactored code for improved readability and organization
improved mode 3, notably latency estimation and delay calculation (fixes #374, #324, #315)
fixed min/max functions from statistics utility (fixes #415)
prefer using TCP latency, falling back to ICMP and then estimation. (fixes #341)
implement mode 4 (no UI entries, but can be set in config manually) as another mitigation mode
simplify logging output

@Soreepeong please consider this PR with reasonable priority, as there are several reports of Mode 3 causing 0.53s primarily due to the bolded issue fixed noted above. My own further updates for Mode 3 improve upon consistency/safety issues.
Compiled drop-in version with these PR changes is available on my fork, tracking upstream.

min(pingLatency, socketLatency) was done rather than prioritizing one over another, because socket latency tended to higher than what it actually is. It reports 160ms from socket latency where the ping actually is 140ms. Worse is that a connection made between a VM and host PC had socket latency of 40ms while its actual ping is <1ms, and when a such proxy is used, it would overmitigate in those cases, so this one should be kept to using ping result when available. To be honest, I changed my mind to think that socket latency shouldn't even be there.
How did you come out with latencyEstimateUs = ((rttMinUs + rttMeanUs) / 2) - ((rttDeviationUs + 30000) / 2)?
Can you give some example situations (action rotations) for StandardGcdDivision?

min(pingLatency, socketLatency) was done rather than prioritizing one over another, because socket latency tended to higher than what it actually is. It reports 160ms from socket latency where the ping actually is 140ms. Worse is that a connection made between a VM and host PC had socket latency of 40ms while its actual ping is <1ms, and when a such proxy is used, it would overmitigate in those cases, so this one should be kept to using ping result when available. To be honest, I changed my mind to think that socket latency shouldn't even be there.

So my thought about this is that because the game itself uses TCP for game communication, it makes sense to measure at the TCP level. From a networking standpoint, this will of course differ from ICMP due to factors such as routing, prioritization, and packet processing. This, to me, makes the ICMP measurement slightly inaccurate when considering game communication. IMO, ICMP is likely to be more of a stable measurement of distance (disregarding network load).
Both are valid measurements, but here's the more important question: In your example, has it been tested whether the extra 40ms from socket latency was accounted for in RTT? Has it resulted in several cases where RTT ended up higher than socket latency itself?
Assuming the player is using the default mode (Mode 3), the impact this measurement has will likely be lesser as it prefers estimated latency anyways.

How did you come out with latencyEstimateUs = ((rttMinUs + rttMeanUs) / 2) - ((rttDeviationUs + 30000) / 2)?

I wanted to improve the previous calculation by making it simpler rather than complex. Since latency should be relatively stable around a certain point, it doesn't make sense to factor the realtime RTT (or even normalize the RTT values for that matter) so I took that out. Ultimately, this makes the calculation much easier to understand as I couldn't even fully explain the original one.
Some rules I followed while thinking about this calculation were:

RTT should factor into at least latency and some delay value.
There should be a minimum delay/processing time
The deviation statistic in RTT can be considered as a measurement of how accurate our estimation is. It is also a measurement of how stable the connection is to the game server. More deviation will result in a lower latency estimation result, which should mitigate less (safety purpose).
In normal circumstances (up to 100-150ms ping), the estimation should be relatively accurate to the real latency measurement.

With this in mind, here are each of the variables explanations:

rttMinUs: calculations should be close to this value, as it indicates that our real latency is less than this value.
rttMeanUs: there should be some sort of fluctuation in latency (network load for example), so this is considered as well.

We take the value between these two variables, and then subtract a value derived from a deviation and constant:

rttDeviationUs: measures the "range" (or radius in other words) of our latency values.
30000: triple weaving 600ms actions is possible at 2.5 GCD with at approx this amount of delay, maximum. This can also be considered as a minimum delay/processing time value.

The result is an estimation that very closely resembles my real latency (in my experience) while also not fluctuating too much by the realtime RTT.

Can you give some example situations (action rotations) for StandardGcdDivision?

So to break down how this works, it is primarily client-side focused where it will add enough delay to just allow a certain amount of weaves. The calculation is only active if the amount of weaves is at least 2, otherwise it will fallback to something similar to Mode 1. The amount of weaves is calculated mathematically, by division based on 2.5 GCD and the action's animation lock time.
For example, let's do break down with 600ms actions.

Constants are 2.5 GCD and 600ms GCD lock time. This leaves you with 1.9s of weave window.
1.9 / 0.6 = ~3.16, round down to 3. This represents maximum amount of weaves possible. gcdsplit = 3
If we take the remainder of 1.9 and 0.6, we are left with 0.1. Divide this by the amount of weaves possible for the delay value to add on every action. Result is about ~33.3ms.

This results in something like:

GCD (600ms / 600ms)
oGCD (600ms / 1200ms) + delay (33.3ms / 1233.3ms)
oGCD (600ms / 1833.3ms) + delay (33.3ms / 1866.6ms)
oGCD (600ms / 2466.3ms) + delay (33.3ms / 2499.9ms)

So, pretty good and legal at the client since it is mathematically possible, but packets have a mind of their own.
For another example, say we don't want to allow triple weaving (force gcdsplit = 2). Mathematically, this increases the delay value to 350ms ((1.9 - 1.2 ) / 2). This can be disadvantageous for situations where disengaging from the boss is required and forced to lose GCD uptime, since your oGCD gap closer will introduce such a high delay value before your GCD. DRG will mainly have this disadvantage, as their jump actions are now 800ms lock times. Delay value with this lock time will end up at 150ms. So, while the main advantage to this mode is timing consistency and enforced mathematically legal inputs, it only considers full uptime situations.
In the code comments, I consider Mode 3 to be more server-focused and Mode 4 to be more client-focused styles of animation lock mitigation.

I've searched a bit, and it seems that the 40ms socket latency I saw stems from Nagle's algorithm on Linux (ref). While setting TCP_NODELAY disables it on client side, the server will stay unaffected, so the measured socket latency can be anywhere between the real latency and the real latency + server's ack coalescing duration. It might be a good idea to measure the average extra latency stemming from ack coalescing? For my case, socket latency stays around 168ms, when ping results in 143ms, regardless of the locations that I connect from, so this makes sense to me.

How is this different from pinning server delay to 25ms (mode 2 with 25ms fixed delay) but penalizing jobs with occasional above-600ms animation locks?

How is this different from pinning server delay to 25ms (mode 2 with 25ms fixed delay) but penalizing jobs with occasional above-600ms animation locks?

By that description it really isn't different. But the point with the mode is that it works dynamically with no configuration needed, pretty much just depending on the server's animation lock response. Some players may argue that this mode can be considered "legal" because it doesn't allow "impossible" things to happen, at least at the client side.
On the other hand players would consider Mode 1 or 3 to be "legal" because of server-side delay in consideration.
An alternative implementation of this mode is to have it as a minimum/required delay value regardless of mode, but unsure if that is a good idea.

I'll get rid of "Standard GCD Division" mode for now, since activating it will require editing config text file directly too anyway, so the effort taken from the end user is probably the same.


Broad research on seven-segment display libs

Look into these links (and perhaps others) for clues on what's out there for 7-segment-display capture systems:

https://github.com/SachaIZADI/Seven-Segment-OCR
https://github.com/alexcohn/tess-two
https://www.youtube.com/watch?v=J0jg1Hj2GhU
https://code.google.com/archive/p/serak-tesseract-trainer/downloads
https://stackoverflow.com/questions/17672705/text-detection-on-seven-segment-display-via-tesseract-ocr
https://play.google.com/store/apps/details?id=jp.gr.java_conf.coskx.ddreader2.trial&hl=en_US&gl=US
https://github.com/arundil/OCR7Segments/tree/master/OCR7SegmentsApp
https://github.com/arturaugusto/display_ocr (recommended by UW)
https://github.com/jiweibo/SSOCR/blob/master/ssocr.py (a single script)

@shoaibmushtaq25 could you indicate which of these you'll be picking up?

Currently, I am working on this one https://github.com/arundil/OCR7Segments/tree/master/OCR7SegmentsApp
Converted old project to androidx and now trying to run it on mobile.

MLKit work is documented here https://github.com/OpenSRP/fhircore/issues/69.

After that, I will be testing number 6 - https://play.google.com/store/apps/details?id=jp.gr.java_conf.coskx.ddreader2.trial&hl=en_US&gl=US

I'll try 1

Here is a link to all the images to related lighting conditions while reading the G6PD device https://drive.google.com/drive/folders/1TcdC46RpUBtaAygfDclFSUrLon2QYI8m?usp=sharing

thanks @f-odhiambo something to note here is at some point we need to label the images with the actual readings on them if we go the route of training our own model.

something to keep in mind when installing keras/tensorflow https://stackoverflow.com/a/63243282/9782187

https://stackoverflow.com/a/53422836/9782187

https://stackoverflow.com/a/56994817/9782187 related to tf session config.

So far, no luck for source code or open source library of Yomzo (number 6)

@shoaibmushtaq25 is there information on how 6 can be launched from another app and to get its results after capture?

6 seems to perform well on the readings https://github.com/OpenSRP/fhircore/issues/82#issuecomment-821078171. It's however not opensource and there's no clear information on how we can launch it from another app and get the extracted readings. Next steps here would be:

Find out if we can get a library (APIs) from the developer (preferred)
Alternatively, find out if we can get information about launching the app and getting a reading from it

8 has a lot of issues building (is outdated and doesn't have a requirements.txt). I could not get it to successfully run and so couldn't evaluate it. Next steps here would be:

Try see if we can contact the developers for some guidance
Dedicate time to try and upgrade the outdated parts, test and evaluate

1 takes quite a while to train (been running for over 3 hrs) but for their dataset, it seems that each epoch provides
better results. Next steps here would be:

train the model
crop out G6PD readings and add them to a test folder to see how it performs
If above is good OK, otherwise we'd need to train it with labelled images and see if the results are better
It also doesn't seem to be trained on capturing the entire floating point number (from the README images)

I haven't gone through 2 and 4 but it looks like we'd need to know how to work with Tessaract to train a model with the data? In that case, next steps are:

We'd need to invest time to understand how this works and then evaluate performance.

9 has an interesting approach to encoding the 7-segment display as bits and is a single script which looks simpler. It however only works for that particular display but from skimming it looks as though it's because you have to tell it where to look for the digits (might be a small tweak but not sure). Next steps:

see if we can tweak where it looks for digits and evaluate performance

In most if not all of these, we want to be able to successfully run and subsequently evaluate whether the out-of-box solution works or not. I'm not sure we're a position to know exactly what to tweak right now or after the evaluation but at the least we can try out the solution as is.

results for 1 after running it.

results of running Model_Single() from 1 on their training set.

Cool, let's spend Monday to finish looking into (7), which I think is based on (2).
For (2) yes we'd either need to train of find a model, there should be a model for (2) in https://github.com/arundil/OCR7Segments (ie 7)

For number 6, I tried to find out source code or open source libraries used in it but no luck and what I did this morning is that I sent out an email to the email-id mentioned on the Google Play store link of this app "Yomzo" but still there is no reply from them.

For number 7, I invested a reasonable time to convert the old eclipse project to android studio project and also converted it to androidx imports and was able to install this app successfully in the mobile. When I run this app, this asks for openCV manager package to install in the mobile. I tried many different ways (Direct from the app or separate installation through terminal) to install the OpenCV manager package and finally I was able to install it few times before.
After installing OpenCV manager package, I run the app but the app is not detecting anything and only showing a rectangle/square of ROI(region of interest). The app also crashes off and on.
here is the screenshot of number 7 app.

Let's continue looking 7 for another day, don't worry about the crashing, let's see if we can get any of the text rec to work

As I mentioned in the comment here that I sent out an email to developer of "Yomzo" numeral 7-Segment app to ask about the source code or open source library or any way to launch "Yomzo" app from external app. I just received a reply from them. See image below for the details..I will paste it in the github issue as well for the record.

@tanvirshanto what was the result of additional research into 7?

@pld I invested yesterday on number 7 and tried to make it work after resolving some outdated code but the app still not working correctly and also crashes off and on while scanning readings through camera.
I configured NDK and some other required things to make it work but unfortunately no luck.

Yes of course, K that's helpful thank you, do you see any value in spending more time working on this?

I spent time today as well but still there are some errors coming out due to which app is not working as expected.
I am not sure what would be the next steps now onwards.

After hours of effort, finally I managed to add the native C/C++ code in the final apk of number 7 and then tried to scan the G6PD device readings with it but unfortunately the app doesn't work as expected and crashes too frequently. Looks like the code is too old and not working as expected. I don't think to invest more time on it would be beneficial or give any good results.
cc: @pld @f-odhiambo @vincent-karuri

k thanks @shoaibmushtaq25 for your efforts, looks like we've definitely hit the end of road wrt options we listed here

https://github.com/arturaugusto/display_ocr @shoaibmushtaq25 for this, do you have the script with your changes made  but which was failing?

Yeah, I have its requirement.txt file which I get it prepared from my friend having expertise in python.

a few others that may be interesting:

https://github.com/kk5190/Reader-Of-Appliance-Display (Android)
https://github.com/NatholBMX/ScaleDigitizer looks easy to set up (python)
https://github.com/arturaugusto/display_ocr have not been able to run this (python)
https://www.unix-ag.uni-kl.de/~auerswal/ssocr/ (terminal)
https://github.com/auerswal/ssocr github code for above
https://github.com/FANMixco/7-segment-ocr-reader (C# inspired by above)
https://github.com/DevashishPrasad/LCD-OCR single script (python)
https://github.com/suyashkumar/seven-segment-ocr (python)
https://github.com/tvwerkhoven/heat_meter_reader looks specific to heat meters? (python)

Here are the steps and requirements.txt file to run  https://github.com/arturaugusto/display_ocr

Install Python 3.8 if not installed yet
Add Input Image path that you want to process on line 64 of file py3_raspberry_pi.py
Create a venev using following command   python3 -m venv venv_ocr
The activate the venv using command  source venv_ocr/bin/activate
Then install requirements.txt  file given below
Then enter command python py3_raspberry_pi.py  and see the results

requirements.txt

I tried number 10 from the list above (https://github.com/kk5190/Reader-Of-Appliance-Display (Android))
And got some reasonable results out of it. I have attached videos of the results. Have a look at the drive link here to check the accuracy of results with this android project.
cc: @pld @vincent-karuri @f-odhiambo

I tried number 10 from the list above (https://github.com/kk5190/Reader-Of-Appliance-Display (Android))
And got some reasonable results out of it. I have attached videos of the results. Have a look at the drive link here to check the accuracy of results with this android project.
cc: @pld @vincent-karuri @f-odhiambo

is there a reading that's displayed somewhere, the docs say that it will voice out the reading once it gets it?

Also @shoaibmushtaq25 could you try it out on a mobile phone?

Okay, I will give it a try on mobile phone as well.

is there a reading that's displayed somewhere, the docs say that it will voice out the reading once it gets it?

No, the reading shows only in the ROI(Region of Interest) shown above the reading. Also there is no voice as i observed the app.

Also @shoaibmushtaq25 could you try it out on a mobile phone?

I am done with the research. I mostly tried it on tablet yesterday and made the video from my mobile phone. and as @vincent-karuri said to test it out on mobile phone as well. so today, I also tried it out on my mobile phone and results are the same as on tablet.
But still looks like this app is also crashing sometime specially on tapping of a Button given on the screen. I didn't dig into the code yet to see the reason of crashing anyways.
By the way, looks like this can also help us understand to build our solution in the right direction at-least.

so I just reproduced the crash on the number 10 while tapping on a button given on the screen and came to know that this is also throwing the same error java.lang.UnsatisfiedLinkError and its obvious reason is not including the native C/C++ code in the final apk. Let me try quickly if I can make it work in this way.

Anyways, I manged to resolve the error around native C/C++ code to add into the apk.
I was running the app on my mobile phone (android version 11) and openCV package manager was not installing successfully. Then I tried it on my tablet (android version 9) and I manged to install openCV package manager in it successfully.
App was giving the same results as I shared in the videos attached here .
This app is also crashing off and on. So just like number 7, this number 10 does need to invest some more time to resolve all the old code issues.

I also found a stable apk of number 7 somewhere on the internet and tried it on my device but their results accuracy were not so good. Here is the link of stable apk of number 7 found on the internet.

Thanks for the updates, please add related code here for now, https://github.com/opensrp/diagnostics/tree/main/g6pd

@pld , Related code of number 10 is uploaded to the above url https://github.com/opensrp/diagnostics/tree/main/g6pd

Research summary

Reviewed APK/Code
Paid version  ($2) version of Yomzo app plus the documentation  - No improvement

Optical Character Recognition of Seven Segment Display (Python based) - link
link
Seven segment libs  - links
optical-character-recognition - link
tesseract-ocr link
Review Google AutoML framework link . Also contacted Fred, who referred us to Thye Yeow Bok, ML Kit expert to try to help us with the research

Compiled list of literature read

Automated method for detecting and reading seven-segment digits from images of blood glucose metres and blood pressure monitors - link  - Fred has some leads already connected with him and will be sharing contacts soon
Real-Time Detection and Reading of LED/LCD Displays for Visually Impaired Persons link
Seven Segment Optical Character Recognition link
Utilizing Smartphone-Based Machine Learning in Medical Monitor Data Collection: Seven Segment Digit Recognition  - link - closest research work to G6PD
How to recognize Seven Segment Displays content with ssocr (Seven Segment Optical Character Recognition) in Ubuntu 16.04 - link can be server-based
Text detection and recognition in raw image dataset of seven-segment digital energy meter display - link
Measurement Data Recognition from SevenSegment Indicator by Mobile Device - link This is good research on current problems we are facing

Here is the link to more demo videos link of results with

Google ML Kit
Number 7 (https://github.com/arundil/OCR7Segments/tree/master/OCR7SegmentsApp)
Number 10 (https://github.com/kk5190/Reader-Of-Appliance-Display)

Installed and run desktop version of Tesseract OCR and tested it with different Input Images , i.e, English Text, Numeric Text, G6PD device reading Image, Cropped out seven segment digits and results are documented here

SSOCR initial findings: https://docs.google.com/document/d/1RAPfoZhV5koVR-HUrftMoe-Zs7YcfPfqljc35HJfUJA/edit

Tried already available seven segment display trained data sets with desktop based Tesseract OCR at different resolutions . Results are here


Show system prompt in Dev UI

Did you purposefully leave gpt3.5turbo untouched?

Complete oversight on my part. Updated!

Thanks so much @MichaelDoyle !! Will add this to the rest of our plugins too

Awesome! If you want to support a system prompt for a multi-turn model that doesn't natively support system messages, we also have a middleware you can load for this.
e.g.) https://github.com/firebase/genkit/blob/main/js/plugins/googleai/src/gemini.ts#L390


bugfix(docs_links): open external URL in browser window, remove depre…

…cated method in electron, refactor to index.tsx
Description
Open external links in browser window instead of inside Bruno, referencing issue  #1156
https://github.com/usebruno/bruno/assets/64689165/50c1d58e-188a-4dac-b96a-cda034761913
Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[x] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines.
[x] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.

@bpoulaindev Changes look good!
I would like you to 1 change.
Can you revert the .tsx back to .js ?
Still haven't finalised on typescript migration
There is also a discussion on jsdocs
Main things stopping from making a decision

I am worried changing some files to .tsx might affect some of our existing PR's (75 of them as of this writing)
My typescript proficiency is "beginner". At the current stage of Bruno, It would not be wise to for me (as Bruno's lead maintainer) to move to typescript, specially when I am still a beginner.

This is not to say that we will never consider typescript, Its just that I would like to take more time to make a decision.
Thank you for understanding :)

Can i at least keep it in .jsx format instead of .js ?

Can i at least keep it in .jsx format instead of .js ?

Sure @bpoulaindev !

Done 👌

Hi there ! When will this PR be committed for production, please ?

Hi there ! When will this PR be committed for production, please ?

Good question @helloanoop @Its-treason

Merged! Thank you @bpoulaindev and @Its-treason !


introduce year's flag

One thing that could be interesting is to get an overview per year of statistics..
Along years, it could be cool to compare evolution of attendees' behavior.
To achieve that, Floxx need to add in its model a new field that contains year.  This information should be linked with the 'slot'.
For run part, we have to define in configuration file, new property with current year. It will be used to select only slots the current edition.
For statistic part, we can play with all data, and provide graphs that compare data by year.

closed by PR #73


Add a single API Key deprecation block with more information about the affected TPP versons

This builds on @maelvls 's content from #1094 and hopefully makes it clearer that this incompatibility is only related to the way that cert-manager Venafi Issuer does username / password auth and also makes it clearer that the API Key feature is permanently removed in TPP 22.3.
/cc @maelvls

/lgtm
Thanks for doing this!


Add Kap to apps list

Hi there!
I'd like to add Kap to your apps list!
I'm part of the team at Wulkano building it at https://github.com/wulkano/kap
Thanks!

Cool. Thanks for submitting it! :sparkles:

Just tried it out. It works! I've been waiting for this app to exist. :)

It's just the beginning @zeke! 😄


Made changes to navbar

Issue Number
fixes #
Issue #335
Describe the changes you've made
Added hover and changed color of the toggle icon in the nav bar and added icons to the menubar list.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA

@JahnaviKashyap19 it is fine in mobile view but you have ruined the desktop view.

Change the desktop view navbar back to normal.
Also, for the mobile view you have not done the changes in action, comedy, horror, etc. other pages do changes in them also.
Also, the hover effect is faded red, change it to red color similar to the website.

Should I make the necessary changes anymore as the issue is now closed?


Add Long Island University

Add new Long Island University student emails<EMAIL_ADDRESS>

@BrandonKaim Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


Pings not being returned after a certain number of IP addresses

I'm building a utility to keep track of network nodes with this library, but after a certain number of IP addresses tested, pings stop being returned. My application is containerised using docker, and it works for about 20 IP addresses in sequence, but after around that number, pings stop being returned for further IP addresses. The strange thing is that IP addresses which are reported as not responding, can be pinged from outside the container on my development machine, but not from inside the container.
My latency testing function (called sequentially for different ips) looks like this:
func getLatency(ipAddress string, msLatencyTrigger int) (*time.Duration, error) {
	pinger, err := ping.NewPinger(ipAddress)
	pinger.SetPrivileged(true)
	if err != nil {
		return nil, err
	}
	pinger.Count = 10
	pinger.Timeout = time.Second * 5
	var averagePing *time.Duration
	pinger.OnFinish = func(stats *ping.Statistics) {
		if stats.PacketsRecv == 0 {
			averagePing = nil
		} else {
			averagePing = &stats.AvgRtt
		}
	}

	err = pinger.Run()
	return averagePing, err
}

Am I missing something critical here about the library? Or is this not a library problem?

Look at the issue I just posted as it might be related: https://github.com/go-ping/ping/issues/209.
First you're asking ping to do 10 pings (count = 10) but the timeout is 5 seconds with default interval of 1 second which means you'll only get 5 pings at the most and probably get the 5th one truncated. The timeout kills the entire ping operation. So I'd say you want the timeout to be at least one second larger than the count * interval.
As to why the ping doesn't return the correct results - make sure you can ping the hosts inside the container using the regular Linux command. The way docker default networking is set can prevent the containers from reaching out to your outside network. You might need play with your host and docker firewalls.


Rollup type definitions

Current Behavior
TypeScript compiler outputs all type definitions into the dist folder regardless of whether they are relevant to the components exported from the library. Even dead code that doesn't make its way into the final .js rollup still produces type definitions in the dist folder. Unless you take some extra steps, all those .d.ts files end up in your npm package.
Let's assume the following project structure:
src
  foo
    foo.tsx
  bar
    bar.tsx
  ComponentA.tsx
  ComponentB.tsx
  index.tsx

dts-cli build produces the following dist output:
dist
  foo
    foo.d.ts
  bar
    bar.d.ts
  ComponentA.d.ts
  ComponentB.d.ts
  foo-bar.cjs.development.js
  foo-bar.cjs.production.min.js
  foo-bar.esm.js
  index.d.ts
  index.js

Desired Behavior

Produce only one .d.ts file - index.d.ts
Tree-shake all unused type definitions.

so that the final output looks like the one below:
dist
  foo-bar.cjs.development.js
  foo-bar.cjs.production.min.js
  foo-bar.esm.js
  index.d.ts
  index.js

Suggested Solution
I achieved the desired goal with rollup-plugin-dts, but I didn't find an elegant way to plug into the build pipeline to execute a separate rollup build after all rollups are done. I ended up with the following patch package:
diff --git a/node_modules/dts-cli/dist/index.js b/node_modules/dts-cli/dist/index.js
index d5d2644..6285cd8 100755
--- a/node_modules/dts-cli/dist/index.js
+++ b/node_modules/dts-cli/dist/index.js
@@ -34,6 +34,8 @@ const utils_2 = require("./templates/utils");
 const deprecated = (0, tslib_1.__importStar)(require("./deprecated"));
 const sort_package_json_1 = (0, tslib_1.__importDefault)(require("sort-package-json"));
 const pkg = require('../package.json');
+const dts = require('rollup-plugin-dts').default;
+const del = require('rollup-plugin-delete');
 const prog = (0, sade_1.default)('dts');
 let appPackageJson;
 try {
@@ -60,6 +62,18 @@ async function jsOrTs(filename) {
                 : '.js';
     return (0, utils_1.resolveApp)(`${filename}${extension}`);
 }
+const rollupTypesConfig = {
+        input: "dist/types/index.d.ts",
+        output: { file: "dist/index.d.ts", format: "es" },
+        plugins: [
+            dts(),
+            del({ hook: "buildEnd", targets: "dist/types" })
+        ]
+    };
+async function rollupTypes() {
+    const bundle = await (0, rollup_1.rollup)(rollupTypesConfig);
+    await bundle.write(rollupTypesConfig.output);
+}
 async function getInputs(entries, source) {
     return (0, jpjs_1.concatAllArray)([]
         .concat(entries && entries.length
@@ -261,6 +275,7 @@ prog
 `);
             try {
                 await deprecated.moveTypes();
+                await rollupTypes();
                 if (firstTime && opts.onFirstSuccess) {
                     firstTime = false;
                     run(opts.onFirstSuccess);
@@ -314,6 +329,9 @@ prog
         })
             .then(async () => {
             await deprecated.moveTypes();
+        })
+            .then(async () => {
+            await rollupTypes();
         });
         logger(promise, 'Building modules');
         await promise;

I'm curious if there is a more straightforward approach that I simply overlooked. If not, would you be interested in adding this as a feature to dts-cli behind a feature flag? I'll be happy to contribute a more generic solution.
Who does this impact? Who is this for?
I'm assuming this can be useful for most developers working on TypeScript libraries that roll up all their code into a single file without preserving the directory structure.
Describe alternatives you've considered
There are some alternative options (i.e. api-extractor) that I haven't explored closely since rollup-plugin-dts option appears to fit more naturally into dts-api pipeline.

interesting idea! 👍
it seems a good enhancement - I don't think it needs to be behind a flag. PRs are welcome! 😄

I meant command line option so that this feature could be an opt-in. Or do you think it's okay to enable it by default?

yes, I'm not see why devs don't want it. And, we can add an option to opt-out (if someone asks).

yes, I'm not see why devs don't want it. And, we can add an option to opt-out (if someone asks).

PR is ready.
Types rollup won't run if any of the following is true:

tsconfig.json compilerOptions.declaration is explicitly set to false
tsconfig.json compilerOptions.declarationDir is not defined or pointing to a folder outside of dist

Added "declarationDir": "dist/types" to dts-cli create templates so types rollup will be enabled by default for new projects. Existing projects will need to add declarationDir to their tsconfig.json manually. Please let me know if you think it will be better to enable this feature for all existing projects automatically, and I'll make the corresponding change.

a big thanks! :)
is the config in tsconfig.json really needed? what do you think reading pkg.typings?
an example: {"typings": "dist/index.d.ts"}, it can be enabled even if not configured in tsconfig.json.

is the config in tsconfig.json really needed?

No, not really. It was a way of making this feature an opt-in for existing projects. But if you approve enabling this feature for existing projects (see my previous comment), then tsconfig.json change will not be needed at all. And I'm assuming it should be handled via breaking change release?

I would like it to be the default. the on/off config is just pkg.typings.
not sure it should be a breaking change; it seems does not break anything. a minor release also makes sense?

PR is updated.
Types rollup won't run if any of the following is true:

there are no typings or types entries in package.json
tsconfig.json compilerOptions.declaration is explicitly set to false
tsconfig.json compilerOptions.declarationDir is pointing to a folder outside of dist

Works with both custom compilerOptions.declarationDir or none at all (dist/types is used as compilation output and is deleted when rollup is done)


rollbar_flutter version doesn't match

I am trying to flutter pub get of rollbar_flutter but facing the issues given  below.

@akterridealike, could it be you have some other dependency package interfering with rollbar_flutter  or there is an issue with your Flutter package management environment?
I just upgraded my machine to Flutter 2.10.3:

and was able to successfully add rollbar_flutter to a new Flutter test app:

@akterridealike the only version released on pub.dev is 0.1.0-beta. It should work if you change it from 0.1.0 to 0.1.0-beta but 0.1.0-beta still doesn't appear to have sound null safety support :frowning_face:
https://pub.dev/packages/rollbar_flutter/versions

@akterridealike , please, try latest published v0.2.0-beta...


Collect count not working with sparse index

My Environment

ArangoDB Version:        Community Edition 3.11.1
Deployment Mode:       Single Server
Deployment Strategy:   ArangoDB Starter
Infrastructure:               own
Operating System:        Windows 10
Total RAM in your machine:        32Gb
Disks in use:        SSD

Hy,
I run this Query to get records (@path is an array of number)
FOR rec IN k_ref
    FILTER
        rec.__localScope IN  @path AND
        rec.__p_13 == 73
    RETURN rec

It works as expected : i have all my records (11)
Now adding collect to get the count (no changes to the query filters )
FOR rec IN k_ref
    FILTER
        rec.__localScope IN  @path AND
        rec.__p_13 == 73
    COLLECT WITH COUNT INTO countVariable
    return countVariable

Result : 0, 11 expected
This query uses an index (sparse) and all the fields are in the index.
Query String (166 chars, cacheable: true):
     FOR rec IN k_ref
     FILTER
         rec.__localScope IN  @path AND
         rec.__p_13 == 73
     COLLECT WITH COUNT INTO countVariable
     return countVariable

Execution plan:
 Id   NodeType        Est.   Comment
  1   SingletonNode      1   * ROOT
  7   IndexNode         51     - FOR rec IN k_ref   /* persistent index scan, scan only */
  5   CollectNode        1       - COLLECT AGGREGATE countVariable = LENGTH()   /* count */
  6   ReturnNode         1       - RETURN countVariable

Indexes used:
 By   Name          Type         Collection   Unique   Sparse   Cache   Selectivity   Fields                         Stored values   Ranges
  7   referencial   persistent   k_ref        false    true     false        5.79 %   [ `__p_13`, `__localScope` ]   [  ]            ((rec.`__p_13` == 73) && (rec.`__localScope` IN [ 0, 1, 1007504, 1009247 ]))

Optimization rules applied:
 Id   RuleName
  1   use-indexes
  2   remove-filter-covered-by-index
  3   remove-unnecessary-calculations-2

43 rule(s) executed, 1 plan(s) created, peak mem [b]: 0, exec time [s]: 0.00026

If i remove the filter applied to the array (@path),  it now doesn't use the index and the collect works, and i get the right count (11).
Query String (127 chars, cacheable: true):
     FOR rec IN k_ref
     FILTER
         rec.__p_13 == 73
     COLLECT WITH COUNT INTO countVariable
     return countVariable

Execution plan:
 Id   NodeType                  Est.   Comment
  1   SingletonNode                1   * ROOT
  2   EnumerateCollectionNode    968     - FOR rec IN k_ref   /* full collection scan (projections: `__p_13`)  */   FILTER (rec.`__p_13` == 73)   /* early pruning */
  5   CollectNode                  1       - COLLECT AGGREGATE countVariable = LENGTH()   /* count */
  6   ReturnNode                   1       - RETURN countVariable

Indexes used:
 none

Optimization rules applied:
 Id   RuleName
  1   move-filters-into-enumerate
  2   reduce-extraction-to-projection

43 rule(s) executed, 1 plan(s) created, peak mem [b]: 0, exec time [s]: 0.00037

This query worked in the previous version 3.10.
Tks

We are seeing the same issue with persistent unique index.

Hello!
Thank you very much for this bug report. This is a problem which was introduced in 3.11 as part of some additional query optimizations. In the meantime, it has been fixed. The PR is here: https://github.com/arangodb/arangodb/pull/19571 There is also a 3.11 backport here: https://github.com/arangodb/arangodb/pull/19569
So this will be fixed in 3.11.3 when it comes out.
Best regards,
Max.