on("notification") not called when iOS app in foreground

When I receive a push notification on iOS while the app is in the foreground, the on("notification") function should be triggered.
When the app is in the foreground, the push notification is received and displayed as a normal notification in the notification centre and does not trigger the on("notification") function.
When I select the notification however, it does trigger the on("notification") function with the push notification payload.
The behaviour works as expected on Android.
When I run my app using cli-6.5.0 on the plugin version 1.11.1 then it works as expected, but not when using cli-7.5.0 with plugin version 1.11.1 or 2.1.2.
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
cli-7.1.0 (iOS 4.5.4 / Android 6.3.0)
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Testing on iPhone 6s with iOS 11.1
Plugin version
plugin versions tested 1.11.1 & 2.1.2 with the same issue.

Sample Code that illustrates the problem
    try {
        push = PushNotification.init({
            "android": {
                "senderID": "XXX",
                "forceShow": false,
                "sound": true,
                "vibrate": true
            },
            "ios": {
                alert: true,
                badge: true,
                sound: true
            },
            "windows": {}

        });
    } catch (exc) {
        mobile.alert('Error Initializing Push Notifications: ' + exc.message);
        push = false;
    }
        if (push) {
            push.on("registration", function (data) {
                // registration info here
            });

            push.on("error", function (e) {
                mobile.alert("Push Notification Error: " + e.message);
            });

            push.on("notification", function (data) {
                mobile.alert('NOTIFICATION [' + JSON.stringify(data) + '] processing...');
                // logic goes here
            });

        }

With some more tests, I actually notice that when the app is open in the foreground, and a push notification is received and I select the message, the data being passed to the on("notification") function indicates "foreground":false while the app is most definitely open.

rudiminty
Do you have katzer's local notification plugin also included in your project?

@rudiminty you shouldn't see the notification in the shade when the app is in the foreground. As @umeshiyer asked are you using the local notification plugin?

Thanks for the responses.
@umeshiyer , no not using local notification plugin.
I have however by means of elimination noticed that the plugin cordova-plugin-mauron85-background-geolocation is most probably the cause with this specific issue perhaps contributing: https://github.com/mauron85/react-native-background-geolocation/pull/268#issuecomment-421388413


Allow hiding plot legend

Added default sorting for string | number | date types.
Fixed minor deprecation warning for small_series_stat.
Added unit tests.

Closes #336

I got confused by the title of this PR.
Is there a corresponding example that demonstrates that the sorting works as expected? If not, it would be good to add one.

I got confused by the title of this PR.

This was leftover from other PR by accident. Fixed.

Is there a corresponding example that demonstrates that the sorting works as expected? If not, it would be good to add one.

This sorting is just for initial groups creation meaning if you select group by column, the groups will be shown automatically sorted. Not sure what examples you mean.


test  submit issue

cookiecutter_learn version:
Python version:
Operating System:

Description
Describe what you were trying to get done.
Tell us what happened, what went wrong, and what you expected to happen.
What I Did
Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

test reply


Named routes?

Over the last year I've been using Laravel which has the ability to name routes when declaring them, then using those named routes in the view files as links rather than hard-coding the link into the view file for example Link.
I know this framework is used in a Udemy course so it would mean updating the videos in the course too I guess, but is this something that you think you would add or could easily be added?

Hi Joe,
thank you for your interest in my framework! That's a good idea. I'm actually working on an updated version of the course at the moment, so if it fits in with what I'm teaching on the course, I'll certainly add it.
It shouldn't be too complicated to add something like this - I suppose it would be adding the name to the array of routes in the router, then making this available in a helper in the view templates. I'll look into it when I get to the section on Twig and let you know.
Thank you for the suggestion!
Best wishes,
Dave


HTTPX update

Check if this PR fulfills these requirements:

[Y] My changes respect the Kodi add-on development rules
[Y] I have read the CONTRIBUTING document.
[Y] I made sure there wasn't another Pull Request opened for the same update/change
[Y] I have successfully tested my changes locally

Types of changes

[ ] New feature (non-breaking change which adds functionality)
[ ] Feature change (non-breaking change which changes behaviour of an existing functionality)
[ ] Improvement (non-breaking change which improves functionality)
[Y] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Refactor (non-breaking performance or readability improvements)

Description

https://github.com/CastagnaIT/plugin.video.netflix/issues/1611
fix for issue #1611
In case of Feature change / Breaking change:
Describe the current behavior

Describe the new behavior

Screenshots (if appropriate):

its a partial update, not all dependencies has been updated
no sources github release / tag specified
also has not be taken in consideration api changes etc...
as is this pr cannot be considered


Use the translation capacity to translate a few tags

would it not be possible to use the translation capacity

to add the translation of a few tags and make these translation show up automatically in the pop-up rather than the raw OSM value?

yes, it's in the next version :), for example, https://test.mapcontrib.xyz/t/101705-Points_dEau_dIncendie_PEI_Balansun

@vinber Can you validate that feature? I can release it?

I make only only two tests but they seem ok !!
Ok

@severinmenard It's fixed in the 1.7.10 version :)

How can we find these tags to be translated? Eg in https://carteinnov.francophonelibre.org/t/ca1a3e-CarteInnov#admin/locale/fr/preset :

Your instance is still in 1.7.9. I will update it si soon!

@severinmenard It's done!


Support theme

WHAT

Support theme as https://mertjf.github.io/tailblocks/

WHY

Easy to migrate or integrate with different color

HOW

TBD

Hello @jellydn, I really think about this feature but the problem I have to change dark components to a light version like footers and about me components then I can add this feature If you have any suggestion for this tell me you an idea and how we can add dark/light components :smile:

@khatabwedaa Have you checked out the tailwind v2? https://blog.tailwindcss.com/tailwindcss-v2 You could use dark: prefix to apply the theme.

Didn't check it yet but I will


Bugs: hide-and-seek

:black_circle: Leaving commented pieces of code in your codebase. It makes your codebase unclean.
:black_circle: Having two unused functions that were supposed to be called

Thanks, @berylcl
I did your suggestion.


Adding unit/acceptance test for map changing

Hello @juaxix,
Thanks for the very useful feature of map changing on client side !
First of all, I added on carla/settings.py the possibility of changing the map name
on the carla settings code. Quite trivial.
Now about the tests.
At first it seemed to be working correctly. I was able to start CARLA on Town01 and execute
tests on Town02. However I decided to make a test to stress this map change since it is a very
important functionality.
For that, I created the acceptance_test called " test_map_changing.py"
Basically, what it does is changing maps from Town01 to Town02 and then Town02 to Town01 ...
repeating this process 8 times. At each time it asserts if the map name received is the same
as the map loaded by the client.
What happens is the following:
It starts on town 01 , receives town01  --- Correct
It starts on town 02 , receives town02  --- Correct
Then something weird happens:
It starts on town 01 , receives town02 and the connection crashes!
Please accept the pull request and try to reproduce the problem by running the test_map_changing.py
script with nosetests3.
Thanks again.

This change is

Review status: all files reviewed at latest revision, all discussions resolved.

PythonClient/carla/settings.py, line 42 at r1 (raw file):

        self.QualityLevel = 'Epic'
        # [CARLA/LevelSettings]
        self.MapName = 'Town02'

With this change we should also change the default map in the unreal project settings in Map & Modes section, so you are not loading the Town01 in the first place. But in the future the first level should be the transition level, so...i think it will be ok for the long term

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

PythonClient/carla/settings.py, line 42 at r1 (raw file):
Previously, juaxix (juaxix) wrote…
With this change we should also change the default map in the unreal project settings in Map & Modes section, so you are not loading the Town01 in the first place. But in the future the first level should be the transition level, so...i think it will be ok for the long term

Done.

Comments from Reviewable


fix(TDI-38563) : Some UI issues for tMarketoInput

What is the current behavior? (You can also link to an open issue here)
https://jira.talendforge.org/browse/TDI-38563
What is the new behavior?
Fixed UI problems.
Please check if the PR fulfills these requirements

[X] The commit message follows Talend standard
[X] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[x] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:

Pull request test result: success :star:


Make Session an interface for easy decoration

I have ran into a situation when I need to do two things:

Log all queries - for debug;
Make queries frequency report - for throughput monitoring, queries per second.

The most straightforward way to implement his would be to wrap the Session object into a decorator. In order to use Kotlin decoration syntax, both the original Session class and the decorator need to implement the same interface.

@root-talis, good idea.

Fix: factor out Session and Transaction functions into interfaces. Implementation renamed
to SessionImpl and TransactionImpl

I will be making a release 0.4.2 with these changes.

Thanks for the update! Works like a charm :)


Can't find site to enable API

I'm having a bit trouble to get started using the Perspective API. I got the mail that my email adress got whitelisted yesterday but now, when I click the link in the quick start guide to the Perspective API's overview page to enable it for my app, it won't load at all. I can't even find it in the API library. Is there a new site for the API or another way to generate a key? Thanks!

Hi there! Sorry you are having trouble.  First you need to create a new cloud project and then, once that is created you can visit the Perspective API overview page in Google Cloud console to enable and create an API key.  Full address for the overview page is: (https://console.developers.google.com/apis/api/commentanalyzer.googleapis.com/overview)

Hi! Thanks for your answer. Unfortunately, I still can't access the page, even after creating multiple new projects. Here's what I get:

Do you know if I need to do something else to get permission to the API?

There was an error with our latest access approvals. Can you try again now?

Perfect! Now it works. Thanks for the fast help, it is very appreciated.

kasavin, can you email<EMAIL_ADDRESS>with the email address you applied with? Thanks!
If anyone else is seeing this, please email as well.

Hi Im getting an error saying "There was an error while loading. Please try again." Is there any way to fix this?


Doc: List is not formatted correctly in swarm/scheduler/filter/

Problem
See

Looks like this should be a list but it is not formatted as a list. May be a generic issue across all lists - would need to be confirmed.
Reproduce
See https://docs.docker.com/swarm/scheduler/filter/

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

@alvinr hi Alvin, thanks for reporting this. This part of the documentation is actually in the Swarm repository; https://github.com/docker/swarm/blob/master/docs/scheduler/filter.md
I had a quick look at the source of that document, and I think the problem here is that there's no blank line before the list; there are actually a number of lists in that document that miss a blank line and are not rendered properly.
I copied your issue to the Swarm repository https://github.com/docker/swarm/issues/1021 so will close this one.


theme new is creating en.default.json even if there's already a default language

Describe the bug
So like I was saying in the last issue, we are starting to implement some automations to our workflow. I built something that will setup a project for us which will first do theme download, then theme new --name="QA Theme" --env=qa and then theme new --name="Dev - Developer name" --env="development". This will work in most cases but I stumbled upon a theme that had a fr.default.json in the locales folder. In this case "theme new" will also create an en.default.json file which will create an error when uploading the files to the "QA Theme" because there can only be one default language.
To Reproduce
Steps to reproduce the behavior:

in the locales folder have a fr.default.json
run theme new

Expected behavior
Skip the creation of en.default.json if there's already another default language file.
Environment (please complete the following information):

OS [e.g. iOS]: windows 10
Themekit version (run theme version to check): 1.1.4
Editor [e.g. atom, sublime]: vs code

Hi, I had the same problem and I resolved renaming my 'en.default.json' to 'en.default.schema.json' and that avoided the duplication of locales.
If you have more languages only create 'en-GB.schema.json' names to add.
Resources: https://shopify.dev/themes/architecture/locales


Radiobuttongroup with feedback only shows feedback when answer is correct

Currently the user has to select a correct option for the Radiobuttongroup when the feedback options is enabled.
If the user selects an options that is defined as false, the 'See Answers' button makes the Radiobuttongroup blink orange, as if one hasnt selected any options.

Code the reproduce the bug
tests/Testcase_radiobutton.py

I think this is related to MustAnswerCorrectly=True in the definition for this component:
https://github.com/elicit-experiment/client-api/blob/3063be65a3cf34a5fde159c42d4e74723fa1421d/tests/Testcase_radiobutton.py#L207

Yes you are totally right, forgot about that options. We need to document all these settings >)


Cannot find module 'jest-cli'

Describe the bug
When creating a new angular 8 project and adding
"@angular-builders/jest": "^8.0.1"
"jest": "^24.8.0
and trying to run a test I get the following error
Cannot find module 'jest-cli'
Error: Cannot find module 'jest-cli'

To Reproduce
Steps to reproduce the behavior:

create a new angular 8 project
Add the jest  builder/dependency
update angular.json to the following

 "test": {
          "builder": "@angular-builders/jest:run",
          "options": {

          }
        },

run ng test
See error

Expected behavior
I expect it to work as it did in Angular 7.
Screenshots
If applicable, add screenshots to help explain your problem.
Builder:

The name of the builder
The version of the builder

Libraries
    "@angular-devkit/build-angular": "~0.800.0",
Additional context
if I  npm install jest-cli as a package independently it works.  Do we need to install both jest and jest-cli as dev dependencies?

Actually jest-cli should be installed as part of jest. Please check:

What happens if you use Angular 7 and the exact same version of Jest
When using Angular 8 what's in node_modules? Is there a module jest-cli? Is it in node_modules/jest/node_modules? Is there a binary of Jest in node_modules/.bin?

I have the same problem. There is no jest-cli in node_modules. And there is a jest binary in .bin folder

I have no issues with my project when it was on angular 7 using the latest version of jest 24
There is a jest binary in .bin, and there is a jest-cli folder inside of  node_modules/jest/node_modules
Below is the full error if that helps.  I am on Node v10.15.3. and this occurs on both my project and a fresh angular 8 project where i just added the jest builder

OK, I'll look into it. Just to be clear, it's not a blocker, right? Installing jest-cli explicitly is a viable workaround?

Correct, explicitly adding jest-cli as a workaround did the trick for me (at least in my initial testing).
Thanks for all your work on this project!

Yep having the same issue now, +1 !
Will install jest-cli explicitly for now, watching for updates here.

Please confirm the issue is fixed in 8.0.2

Fixed for me. Thanks for the quick fix.


[FR] Update date in on stock allocation

Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find a similar feature request

Problem statement
Not sure if this is a FR or a bug - feels like a FR.
I have a script that syncs stock between Inventree and WooCommerce using an API.
So I call for example the below API to get the "quantity" and "updated" fields and if updated within the last day then I know the quantity has changed so I sync to WooCommerce.  I need to use the "updated" field as only want to sync part stock values that have changed in the last day (Otherwise I will be syncing thousands of parts)
https://demo.inventree.org/api/stock/?format=json&part=69
"updated":"2023-09-28 10:28"
This has been working well but I've found a issue when I have a build order and allocate stock (I use the auto allocate)  the stock quantity updates correctly but the "updated" date doesn't change.
The date is only changed when the build is completed.
I need to update the stock quantity before the build is complete as the build could take sometimes days.
Suggested solution
Update the "updated" field as soon as the stock is allocated, or introduce a new stock_updated field.
Describe alternatives you've considered
The work around for this is to view the part and redo the count part stock - after this the date on the "updated" field is updated.
Examples of other systems
No response
Do you want to develop this?

[ ] I want to develop this.

Not sure why this came through twice. Dup of #5630


feat(meta): expose hummock pinned versions and snapshots via rw_catalog

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
part of #8612
dev=> select * from rw_hummock_pinned_versions;
 worker_node_id | min_pinned_version_id
----------------+-----------------------
              1 |                     5
(1 row)

dev=> select * from rw_hummock_pinned_snapshots;
 worker_node_id | min_pinned_snapshot_id
----------------+------------------------
              2 |<PHONE_NUMBER>195904
(1 row)

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Let's add document after finishing #8612 completely.


seekbar progressing even if you play live videos

Hi, what do you mean exactly? the progress bar should always be at the end. It isn't?

Observe Default Youtube player or Youtube API playerview, if you play a live video there's no seekbar exists. For live videos there should be no seekbar on the view.


DatePicker allows dates to be entered that subsequently trigger a RangeError

Describe the bug
The component allows dates to be entered with years greater than 9999 (both by manually typing and by navigating using the calendar). However, passing a saved value this large to the selected prop causes the component to blow up with a RangeError.
To Reproduce
Steps to reproduce the behavior:

Add a simple date picker:

<ReactDatePicker
    minDate={new Date()}
    selected={date}
  />

Select a date after 31 Dec 9999, e.g. 01/01/10000. The ReactDatePicker accepts this value.
Do something that causes that same value to be passed to a new ReactDatePicker as its selected prop (in our case, it's saved to the DB so we can achieve this by just refreshing the page).
The ReactDatePicker blows up with the following (minified) exception:

RangeError: Invalid time value
    at format (index.js:371)
    at Me (react-datepicker.min.js:1)
    at r.renderDateInput (react-datepicker.min.js:1)
    at r.value (react-datepicker.min.js:1)

Expected behavior
The picker should not allow values to be entered which won't be accepted as valid later. Entering a date that's too large should not update the value, in the same way that typing nonsense does.
Relevant versions:

OS: Linux (Ubuntu 18)
Browser Chrome 80
react-datepicker version 2.13.0

Additional context
It's possible to work around the issue by setting the maxDate prop, e.g. maxDate={new Date('December 31, 9999 00:00:00')}

@alexburlton-sonocent what type is date variable in selected ? should be type date eg. selected={new Date()}

Yep, the type is Date

Possibly related: setting dateFormat to something like 'eee PP' (trying to get short days - why, oh why, isn't that one of date-fns 'P' format styles?), and then typing 'Wed Jan' in to the picker field results in this:
'Exception has occurred: RangeError: The format string mustn't contain eee and MMM at the same time
This appears to be an error thrown in the parse function date-fns, but it appears not be caught by DatePicker.

This issue shouldn't go stale... It is a significant bug and easy to reproduce!


cannot find symbol class VideoRenderer

Any one can help me.

I am also facing this issue. Any help is much helpful.
webrtc-android-codelab/Step-3/app/src/main/java/xyz/vivekc/webrtccodelab/MainActivity.java:32: error: cannot find symbol
import org.webrtc.VideoRenderer;
^
symbol:   class VideoRenderer
location: package org.webrtc

Hi @ skumarm, did you solve this issue, Please help me i too getting the same error.

Use implementation 'org.webrtc:google-webrtc:1.0.22672'


chore: consistent focus states

Consistent focus rings and colours for all interactive elements
Creates helper class focus-ring to contain multiple focus styles
Abstract label and input to simple styled tw components
Increases color contrasts for WCAG AA

:tada: This PR is included in version 1.9.9 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Minor improvements: host flag, make example

Getting a feel for the tool, some minor improvements:

make example target
optional -h ip flag for when I'd prefer to not worry about the service being publicly exposed

Ok, good to review.


Use a comment to tag all OM-related queries

We should be able to run all our queries with an added comment, something like:
select
/* Query generated from OpenMetadata */
...

The idea will then be filtering out all these data from the usage to not try to compute noise and give a way to users to track what we are doing and how

dbt uses a header like the one below to inject metadata on all its queries, could be used as inspiration:
/* {"app": "dbt", "dbt_version": "1.1.1", "profile_name": "<profile>", "target_name": "<target>", "node_id": "<node.fqn>"} */

that's a pretty great suggestion, thanks for the info!

really like the idea of the version TBH

Let's also add also the filtering in the usage to exclude OM queries

closed by https://github.com/open-metadata/OpenMetadata/pull/6293


Skill publishing procedure suggests incorrect Github repository

Skill publishing documentation found at:  https://mycroft.ai/documentation/skills/skill-submission/#submit-a-pr-pull-request-in-github-to-have-your-skill-listed
Is describing how to ultimately make edits to the Mycroft project public skills repository. It looks like there is an error here. Instructions say ", go to the GitHub repo for your Skill. Click the 'New Pull Request' button as shown in the image below" . But in this case, don't we actually want to create a pull request between our fork of the mycroft-skills repository (instead of our skill)? Isn't that where we would be making publishing details changes?
Note that the screenshot of a sample skill repo also (consistent with the instructions) is not correct.

Outdated due to new submission process:
https://mycroft-ai.gitbook.io/docs/skill-development/marketplace-submission/skills-acceptance-process
Closing.


Secure our notification email.

Checklist

[x] CLA is signed

Description of change

Forks will have to define their own

Done.  Thanks.


TypeError: this is undefined

hey guys,
I want to get data from Server and set the response data to state
but I got an error
here is the code block :
  getData() {     const url = "https://jsonplaceholder.typicode.com/todos";     axios       .get(url)       .then(function (response) {         this.setState({todos:response});         console.log(JSON.stringify(response));       })       .catch(function (error) {         console.log(error);       });   }
Thank You so much !!

You have problem with context. try this:
getData() {
const url = "https://jsonplaceholder.typicode.com/todos";
axios.get(url).then(response => {
this.setState({ todos: response });
console.log(JSON.stringify(response));
}).catch(function(error) { console.log(error); });
}
See arrow funcion? This keeps you current context (like var _this = this; in old style)

Here is an article that explains how this works in JavaScript: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/this
Hope this helps!


etcdserver: move 'EtcdServer.send' to raft.go

Clear 'TODO'
/cc @xiang90 @heyitsanthony @fanminshi

defer to @heyitsanthony

lgtm


Add Ian to Authors file

Add Ian to Authors file
No ticket

Before getting review, please check the following:

[x] Does frontend functionality render and work correctly in IE?
[x] Have we load-tested any new pages or internal API endpoints that will receive significant traffic?
[x] Are interactive elements accessible to screen readers?
[x] Have you checked for tech debt you can address in the area you're working in?
[x] If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?
[x] Are the changes organized into self-contained commits with descriptive and well-formatted commit messages?

@ianwestcott I used your MBTA email address because that’s what I know. Let me know if you’d prefer to use a personal email (or if you’d prefer not to be listed at all).


fix: version missing in api calls

Use the following template to create your pull request
Description
Fix missing VERSION in api call for all requests
For details refer to issue #451
Type of Change

[ ] New feature
[X] Bug fix
[ ] API reference/documentation update
[ ] Other

Testing information
See issue #451

:tada: This PR is included in version 1.13.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


How can I get the event after field edit is finished? (OnEditingComplete)

Hello,
Is there a way to get the event after the field is finished edited? I was using onChanged, but that triggers every time the user types.
I want an event that triggers when the user stops editing that certain field. Is it possible?
Thanks!

A TextField has an onEditingComplete attribute which fires when editing is done but only if the TextInputtAction is tapped.
A better alternative is to use a FocusNode have a focus handler that fires when the input loses focus


I have a simple Application with a tableView that is filled with coreData.
Just one entity called "Person", no relationships, 4 attributes: name, age, recordData, recordID.
I have pulled the CoreData functions in a separate class called persistenceService.
In my AppDelegate I enabled CloudCore like this:
    CloudCore.enable(persistentContainer: persistenceService.persistentContainer)

In my viewcontroller I have two functions I use for this:
#1: Fetch CoreData and reload Tableview
    func getCoreData() {
        //      get data from coredata
        let fetchRequest: NSFetchRequest<Person> = Person.fetchRequest()
        let sortDescriptor = NSSortDescriptor(key: "recordID", ascending: true)
        fetchRequest.sortDescriptors = [sortDescriptor]

        do {
            self.people = try persistenceService.context.fetch(fetchRequest)
        } catch {}
        self.tableView.reloadData()
    }

#2 Fetch Cloud Data
    func fetchCloudData() {
        print("fetchAndSave and Reloading Tableview")
        CloudCore.fetchAndSave(to: persistenceService.persistentContainer, error: { (error) in
            print("FetchAndSave error: \(error)")
        }) {
            DispatchQueue.main.async {
                persistenceService.context.reset()
                self.getCoreData()
            }
        }
    }

What works:
I create a new entry, it gets synced to iCloud.
I delete a record in iCloud, call fetchCloudData() and its gone.
I edit a record, call fetchCloudData() and its edited in local storage.
BUT all this only works when I call persistenceService.context.reset() in the fetchCloudData()
function.
Lets say I start the app, CloudCore syncs, and then I try to edit/delete an entry I always get
an error like this:
["conflictList": <__NSArrayM 0x600000648df0>(
NSMergeConflict (0x60000086fd80) for NSManagedObject (0x604000294a00) with objectID '0xd000000000580000 <x-coredata://BB8BBB3E-0F70-4ED2-BDCD-D15AB86480B0/Person/p22>' with oldVersion = 7 and newVersion = 8 and old object snapshot

When I start the app and once call the fetchCloudData() function, it works, when I
uncomment the persistenceService.context.reset() part it gets the same error as above.
can someone please hint me what I'm doing wrong?

I get the record from the tableview and delete like this:
the error occurs while saving.
 func tableView(_ tableView: UITableView, commit editingStyle: UITableViewCellEditingStyle, forRowAt indexPath: IndexPath) {

        **let itemToDelete = people[indexPath.row]**
        print(itemToDelete)

        if (editingStyle == UITableViewCellEditingStyle.delete) {

            **persistenceService.context.delete(itemToDelete)**
            self.people.remove(at: indexPath.row)

            do {
                try persistenceService.context.save()
            } catch let error as NSError {
                print("Error While Deleting: \(error.userInfo)")
            }
        }
        getCoreData()
    }

Here the output as example:
the print(itemToDelete):
<Person: 0x600000291c60> (entity: Person; id: 0xd000000000580000 <x-coredata://BB8BBB3E-0F70-4ED2-BDCD-D15AB86480B0/Person/p22> ; data: {
    age = 2222;
    name = blub44;
    recordData = <62706c69 73743030 d4010203 04050640 41582476 65727369 6f6e5824 6f626a65 63747359 24617263 68697665 72542474 6f70>;
    recordID = "815B15CF-E203-4BFA-B827-0BA8BB0CBA9F|__defaultOwner__";
})

And here the error:
Error While Deleting: ["conflictList": <__NSArrayM 0x60000044f150>(
NSMergeConflict (0x600000678380) for NSManagedObject (0x600000291c60) with objectID '0xd000000000580000 <x-coredata://BB8BBB3E-0F70-4ED2-BDCD-D15AB86480B0/Person/p22>' with oldVersion = 8 and newVersion = 9 and old object snapshot = {
    age = 2222;
    name = blub44;
    recordData = ...
    recordID = "815B15CF-E203-4BFA-B827-0BA8BB0CBA9F|__defaultOwner__";
} and new cached row = {
    age = 2222;
    name = blub44;
    recordData = ...
    recordID = "815B15CF-E203-4BFA-B827-0BA8BB0CBA9F|__defaultOwner__";
}
)
]

I removed the recordData to make it better readable

Could you give your example application, so I won't need to create new one for that ticket?

sure, thank you very much, I uploaded the project here:
https://github.com/theslash/test_cloudCore
I deactivated my team, and the iCloud switch before saving

I've commented persistenceService.context.reset()

I've create a new record.
I deleted it.

I see no errors. I missed something in reproduction?

Yes. Ist Happens when you:
Create a record, kill The App, Start it again.
Then Just try to delete/edit a record.
Then it should fail.
Von meinem iPhone gesendet

Am 06.04.2018 um 13:02 schrieb Vasily Ulianov<EMAIL_ADDRESS>I've commented persistenceService.context.reset()
I've create a new record.
I deleted it.
I see no errors. I missed something in reproduction?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Does anyone have an idea what I can do?

I think I understand the problem:
When I start the app, the fetchAndSave Func runs.
But it runs just after the viewDidLoad where the coreDataObject is fetched.
I tested it with a new project, I have a list of objects, start the app, the fetchRequest runs, then the fetchAndSave function runs.
When I then try to delete or edit a coreData object I get the merge error.
can someone point me out what I'm doing wrong?


Do you plan to not blocking mode support?

I'm not actively working on it, but I'm not against it either. At this moment I do not have a project on which I can thoroughly test the implementation. So it would have to be limited to a small test-application.
I have a rough idea for an implementation, although it wouldn't be optimal.


from uix.custom_button import AnimatedButton  ModuleNotFoundError: No module named 'uix'

i tried an example py file from ur source code actually dont remember file name
here is my code https://nekobin.com/paqiyubeba

okie tqs


Submodels instantiated as XmlEntityInfo instead of XmlModelMeta

Hi
I'm migrating a library from pydantic_xml 0.6 to the most recent version. I see that the subclasses are instantiated with different logic compared to the older version. Indeed running this script with different pydantic_xml version return different results.
here the code:
from typing import List, Optional
from pydantic_xml import BaseXmlModel, element, attr
import pkg_resources
ver = pkg_resources.get_distribution("pydantic-xml").version

class Product(BaseXmlModel):
    launched: Optional[int] = attr(default=None)

class Company(BaseXmlModel):

    products: List[Product] = element(tag='products')
    company_name: str = element(tag='company_name')

print(type(Company))
print(type(Product))
if ver == '0.6.0': #adaptation according to new api
    print(type(getattr(Company.__fields__['products'], 'type_')))
    print(type(getattr(Company.__fields__['company_name'], 'type_')))
else:
    print(type(Company.model_fields['products']))
    print(type(Company.model_fields['company_name']))

output with version 0.6.0
<class 'pydantic_xml.model.XmlModelMeta'>
<class 'pydantic_xml.model.XmlModelMeta'>
<class 'pydantic_xml.model.XmlModelMeta'># the subclass for products is an XmlModelMeta, therefore is not a standard subfield
<class 'type'>

output with version 2.10.0
<class 'pydantic_xml.model.XmlModelMeta'>
<class 'pydantic_xml.model.XmlModelMeta'>
<class 'pydantic_xml.model.XmlEntityInfo'># the submodel is not navigable anymore because is instantiated as XmlEntityInfo
<class 'pydantic_xml.model.XmlEntityInfo'>

Could this issue be a bug? How can I distinguish between a basic type that has no inner fields and a submodel that includes fields?

@RiccardoNizzolo Hi,
That is breaking change in pydantic itself, not pydantic-xml. Starting from pydantic 2.0 it is not possible to get the field type from __fields__ map anymore.
If you want to analyze fields by yourself, you should analyze pydantic core schema:
>>> pprint(Company.__pydantic_core_schema__)
{'cls': <class '__main__.Company'>,
 'config': {'title': 'Company'},
 'custom_init': False,
 'metadata': {...},
 'ref': '__main__.Company:140461506687856',
 'root_model': False,
 'schema': {'computed_fields': [],
            'fields': {'company_name': {'metadata': ...,
                                        'schema': {'type': 'str'},
                                        'type': 'model-field'},
                       'products': {'metadata': ...,
                                    'schema': {'items_schema': {'cls': <class '__main__.Product'>,
                                                                'config': {'title': 'Product'},
                                                                'custom_init': False,
                                                                'metadata': ...,
                                                                'ref': '__main__.Product:140461504455808',
                                                                'root_model': False,
                                                                'schema': ...,
                                                                'type': 'model'},
                                               'type': 'list'},
                                    'type': 'model-field'}},
            'model_name': 'Company',
            'type': 'model-fields'},
 'type': 'model'}

as you can see schema->fields->company_name->schema->type is str, schema->fields->products->schema->items_schema->type is model.
You can find more information here.


GetHistoryForKey added to the chaincode-typescript

Added a chaincode transaction to retrieve the complete history of an asset using its asset ID.

@ajiths10 Thank you for submitting the PR.
Since asset-transfer-basic is the most fundamental sample, it should provide only the minimal necessary functions. Adding your proposed GetHistoryForKey to this sample might be too advanced.
If you believe that a sample TypeScript implementation of GetHistoryForKey is necessary, it would be more appropriate to implement the TypeScript version of the asset-transfer-ledger-queries sample, as it already includes the GetHistoryForKey functionality. What do you think about this approach?

Makes sense to me. Note that there is a chaincode-javascript reference with GetHistoryForKey() that can be used as reference. Ideally the various languages would have the same support in the asset-transfer-ledger-queries.

Hi @satota2 ,
I believe GetHistoryForKey is a fundamental function available in many other languages, including JavaScript. Adding this functionality to TypeScript would be highly beneficial and valuable to the TypeScript community. Since I found it challenging to locate this code in community spaces, I decided to include it in a TypeScript sample myself.
What are your thoughts?

@ajiths10
Thank you for your response.
While GetHistoryForKey is indeed a fundamental function as you mentioned, compared to the basic asset CRUD and transfer operations handled in asset-transfer-basic, its general usage frequency are relatively lower. Therefore, as I previously mentioned, I believe adding it to this simple scenario sample might be too much.
On the other hand, I agree that having a TypeScript sample for GetHistoryForKey would be very beneficial. So, as I previously suggested, I propose implementing a TypeScript version of the asset-transfer-ledger-queries sample. This sample includes other ledger query functionalities in addition to GetHistoryForKey, making it more valuable for TypeScript users.
Regarding the difficulty in finding the GetHistoryForKey functionality, I agree that it needs improvement. As a potential solution, including a note in the asset-transfer-ledger-queries description that mentions it contains GetHistoryForKey might help navigate users better.
What do you think?

@ajiths10
Thank you for your response.
While GetHistoryForKey is indeed a fundamental function as you mentioned, compared to the basic asset CRUD and transfer operations handled in asset-transfer-basic, its general usage frequency are relatively lower. Therefore, as I previously mentioned, I believe adding it to this simple scenario sample might be too much.
On the other hand, I agree that having a TypeScript sample for GetHistoryForKey would be very beneficial. So, as I previously suggested, I propose implementing a TypeScript version of the asset-transfer-ledger-queries sample. This sample includes other ledger query functionalities in addition to GetHistoryForKey, making it more valuable for TypeScript users.
Regarding the difficulty in finding the GetHistoryForKey functionality, I agree that it needs improvement. As a potential solution, including a note in the asset-transfer-ledger-queries description that mentions it contains GetHistoryForKey might help navigate users better.
What do you think?

@satota2  ,
Yes, that sounds good!

@ajiths10 Thank you for agreeing.
I have created two issues based on the above discussion, so I would like to close this PR.

https://github.com/hyperledger/fabric-samples/issues/1232
https://github.com/hyperledger/fabric-samples/issues/1233

If you are interested in helping resolve these issues, I would greatly appreciate your collaboration.
Would you be willing to help?

@ajiths10 Thank you for agreeing. I have created two issues based on the above discussion, so I would like to close this PR.

Add TypeScript version of asset-transfer-ledger-queries chaincode #1232
Improve documentation to highlight GetHistoryForKey support in asset-transfer-ledger-queries #1233

If you are interested in helping resolve these issues, I would greatly appreciate your collaboration. Would you be willing to help? Of course, even if you can assist with just one of the issues, it would be very welcome.

@satota2 Thanks for addressing this. I look forward to it.

@ajiths10 OK. I close this PR.
If you are interested in taking on any of these issues, please leave a comment on the respective issue. I will then assign the issue to you. This will help avoid duplicate work by other comunity members (including possibly myself) on the same issue.


Remove iron ore from recurrent complex structures

The way I see it, we can do this using several methods.

A universal transformer that turns all vanilla iron ore into something else (goethite or limonite?). This is by far the easiest solution, I think.
Disable structures that might spawn with iron ore in them. Since recurrent complex has a ton of structures, this might be a little time consuming.
Disable all Recurrent Complex structures and just use structures we make. I admit I'm somewhat fond of this idea, but I recognize that this'll likely require more work than the idea above.

Didn't you make a transformer that does this?

I did. Do we know if it works?

We can gen some RC meteros and check

Alright, this clearly works.


Bump operand image versions to 4.14

This PR bumps operand's(run-once-duration-override) version to 4.14
from 4.13 as well as trivial changes like more clear log messages and
increasing log verbosity to 5.

/close

/reopen
I'll lower verbosity to 2 back again

/hold

bootstrap failure;
/test e2e-aws-operator

/test e2e-aws-operator

Due to the bootstrap failures, there seems to be no point of retesting for now

/retest-required

/test e2e-aws-operator

/hold cancel

/lgtm


Linter for Q# files

Is your feature request related to a problem? Please describe.
It would be really nice to have a linter that can manage whitespace and formatting in Q# files to avoid spurious whitespace changes and consistent code.
Describe the solution you'd like
A tool like Black for python but for Q#?
Describe alternatives you've considered
Adding to the style guide suggestions for how to handle whitespace/line break sort of formatting.
Additional context
Thanks!💖

We could also look into setting up an editorconfig file. That'd work for many different editors.

We have a hackathon project that is working on a linter and formatter for Q# files! Our feature branch is over here: https://github.com/microsoft/qsharp-compiler/tree/feature/qslint-hackathon. This should give us the foundation to start fleshing out full-featured auto formatting, but it's starting small :). We'd be happy to get any feedback, and will share more on this and other related issues once we have the results of our hackathon efforts!


Cargo Crate

May this be released as a Cargo Crate, so we can install it via cargo install dqy?
I could also make a Pull Request for this, if welcome.

Hello, that's a good idea for the future. Still working on it for some additional bug fixes.


filter dropdowns

The drop down is not working properly when I change the page-size  5 to 10 its not showing  10 rows of data  and you can check your self with your example also  http://plnkr.co/edit/50vJrs?p=preview specifically look at the drop down from 5 to 10 there would be no effect from that.
I hope you will help early as early  as

I would look at upgrading to ui-grid.  The pagination works and is supported.


Generics Aliasing and Partial Specialization

Suggestion

🔍 Search Terms

List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily and help provide feedback.
generics specialization
✅ Viability Checklist

My suggestion meets these guidelines:

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

Add Generics aliasing and partial Specialization
📃 Aliasing Example
// In external library

export type Monoid<T> = {
  concat: (x: T, y: T) => T;
  empty: T;
};
export type MonoidFn<T> = (concat: (x: T, y: T) => T, empty: T) => Monoid<T>;

// in user code
const monoid: MonoidFn<~T> = (concat, empty) => ({ concat, empty }); // impossible today, T is undefined

Here we want the monoid function to still be generic and still using the original library generic definition. Using ~T tells the compiler  we know that T is undefined, just make an alias.
📃 Partial Specialization Example
// In external library

export type AggregateFn<T, U> =  (map: (item: T) => U) => (array: T[]) => U;

// in user code
const sum: AggregateFn<~T, number> = mapReduceSum<T,number>(); // impossible today, T is undefined

Here we want to specialize AggregateFn and make sum an AggregateFn<T, number>, that is still generic but specialized for numbers. Using ~T tells the compiler  we know that T is undefined, so make a partial specialization.

💻 Use Cases
This is almost madatory for decent functional programming without having to redeclare functions of an external library.
Examples should be sufficient to explain a basic use case

Hello Ryan,
In your first example, i don't have the option to change the external library declaration. They declared a generic type, i just want to alias it.
And in AggregateFn2 you just redeclared the external library. Meaning duplicate code, meaning loosing track of original declaration and causing error in code evolution. I can't use these kind of workarounds.
To follow your comment what i'm asking is not to just to conflate generic functions and generic aliases. It's much more genral than that.  i'm asking for generics aliases like C++ have. Maybe i don't have the same vocabulary as you do, coming from a C++ background (see here. Sorry about any miss interpretations.
So to clarify things, when i wrote :
const monoid: MonoidFn<~T> = (concat, empty) => ({ concat, empty });

I meaned something like this (equivalent of c++ exemple i gave) :
alias <T>MonoidFn2 = MonoidFn<T>
const monoid: MonoidFn2 = (concat, empty) => ({ concat, empty });

And when i wrote :
const sum: AggregateFn<~T, number> = mapReduceSum<T,number>();

I meaned this :
alias <T>AggregateFn2 = AggregateFn<T, number>;
const sum: AggregateFn2 = mapReduceSum<T,number>();

To answer your second question, in :
declare const m: Monoid<~T>; // this is wrong, `~` should only be allowed for aliasing generics. You can't declare a Monoid<~T>.
const x = m.empty;  // this is invalid.

@RyanCavanaugh  do you steel need more info?

I think I am looking for something similar - generic specialization;
I would like to have something of the sort:
function encoder<T>(obj : T) : void {/* impl1 */}
function encoder<number>(obj : number) : void { /* impl2 */ }

There is a lookup that needs to be done when we call encoder in order to find which method should be called; once this method is found it can be replaced with an uniquely identified method. It would be a code generation tool in the end.
Without this we either have to resort to type checking, which is inefficient(execution time) because of conditional branches, either we have to write one method for each type that we want to call encoder with, which again is inefficient(coding time).


TypeError: r.table(...).get_all is not a function

Someone understands what's going on? I will add that I have created a secondary index on the table.

Second problem:

If i execute this code in nodejs i have the same issue.

Hi @jarekkowol, it's getAll in JavaScript: https://www.rethinkdb.com/api/javascript/get_all/

I was on a python.. thanks.


Action box UI

A new component for confirmation boxes and similar patterns, based
on what needs to be done here:
https://github.com/18F/cg-deck/issues/307.

I'm going to merge this into Dan's work on the action box UI.


Works in Unity editor but doesn't work in build, DLL not found.

I follow the build instructions for the whole solution and then copied the DLLs into the include unity project. Everything open and ran correctly in the editor, however when I make a non-UWP windows x64 build I get a DllNotFoundException saying that it can't find the Microsoft.MixedReality.WebRTC.Native.dll. I tried this with the mono and IL2CPP scripting backends and tried a UWP build too and still got this exception. Do you have any idea why this might be happening?

Hi @james-carroll-bencin,

...and then copied the DLLs into the include unity project.

You don't need to do that, this is done automatically as part of the solution build.
Did you open Unity before compiling the solution? Do you have all variants of the plugins in the Plugins/ directory? My guess is that you opened Unity, which deleted the .meta files, then you copied the DLLs, but only one variant (x64 Desktop), and Unity regenerated some default .meta files for them for the Editor. But when deploying to something else, the native DLL is not configured anymore to deploy, so is not deployed and not found. You can check the .meta files have been changed with git status; there should be no pending changes.
See about the .meta files configuration in the docs.

Yes, I was careful to revert modified dll .meta files so that export settings were preserved.
The player I referred to above is the PC/x64 standalone build with Mono scripting backend. This build doesn't export a project, it just builds an executable. The DLL is present in the output directory (in the Microsoft.MixedReality.WebRTC.Unity_Data\Plugins subfolder).
Oh I just tried something: When I copy the DLL to the root of the output folder (next to the executable), it works! So it's a path issue. I can live with this workaround.

Hello. I found a workaround for what might be the same issue. See https://github.com/microsoft/MixedReality-WebRTC/issues/82

I tried in UWP, no issue.
I tried in PC Standalone x86_64, and I can't even generate a correct solution; the _Data folder is created with the wrong name and in the wrong location. I reported the issue to Unity, and until that's solved I cannot try to repro the native DLL loading unfortunately.

Update (or lack thereof) : there is still a pending issue logged with Unity. They reproduced the _Data folder bug but I can't get any other feedback so far.

Yeah, my solution to fixing all the DLL errors was to go into the solution folder that was generated form unity and find the 64-bit folder with the DLLs, then copy the ones that were missing from the 86 folder and it fixed the missing DLL issues.

Yeah, my solution to fixing all the DLL errors was to go into the solution folder that was generated form unity and find the 64-bit folder with the DLLs, then copy the ones that were missing from the 86 folder and it fixed the missing DLL issues. Although, this was in August, so things may have been fixed since then.

It seems that there is (another) Unity bug related to standalone deployment on PC. Indeed the DLL is copied to the wrong location. See https://forum.unity.com/threads/dll-not-found-with-standalone-app-but-works-fine-in-editor.389392/ for details. Not sure what's the plan for fixing. As a workaround you can copy the DLL manually from the *_Data\Plugins folder and paste it next to the executable.


"check-separator" Stop checking whitespace after last separated item's semicolon

Bug Report

TSLint version: 4.4.2
TypeScript version: 2.1.5
Running TSLint via: Webpack tslint-loader

TypeScript code being linted
<div onClick={() => {this.setState({showModal: true});}}/>

with tslint.json configuration:
"whitespace": [true,
        "check-branch",
        "check-decl",
        "check-module",
        "check-operator",
        "check-separator",
        "check-type",
        "check-typecast",
        "check-preblock"
    ],

Actual behavior
missing whitespace
Expected behavior
clean :)

I guess this is a bug that can be fixed in the rule... though it feels odd having a semicolon at that point. Why bother including it at all?

Per #4534, closing this as a whitespace/formatting rule. See typescript-eslint.io for the new, shiny way to lint your TypeScript code with ESLint. ✨
It was a pleasure open sourcing with you all!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


Question: GPU Support for transcoding (NVEnc) #2711

Do you have plans to add Nvidia GPU transcoding in the transcoder profiles? Gstreamer has nvenc and nvdec support. GPU cards can handle more transcoding per watt and more efficient.
Thank you in advance.

we do not have any plans to support GPU encoding. we'd be open to PRs if you are interested in building this feature.


Fixed narrow.elv and readline-binding.elv builtins to the new funcref syntax.

Thanks! I also fixed it at roughly the same time though :)


Decreasing Points Total

My challenges total reset from 80 to 54! When I clicked on take me to my next challenge (all of which I've completed) it showed me the git challenge. I figured it was a glitch so hit "completed" and my number reset/recalculated and it took me to node, which I've also completed. It looks like the total is now only counting the challenges, but not the adding points from teh bonfires. It does correctly take me to my next bonfire. I just wanted to pass that along in case the total count is a bug, or if it's doing what it's supposed to do. I liked seeing the nubmer go up with each bonfire I completed.

I also experienced this issue. Upon completing the last bonfire, my score dropped from 50 or so to 16.

Probably related- after the slack switch, the challenges menu was sending me back to that challenge. So I signed up for slack, marked the challenge complete and it appears that bonfires points were reset to 0.

This has been fixed on our ux-improvements branch that we're working to merge in. Your points will be automatically restored once this is merged in. Thanks for your patience.

I'm going to move this to done because it's fixed on the branch that will soon be merged into master and pushed to production.


Add product image placeholder

Current coverage is 46.58%

Merging #308 into master will not affect coverage as of 737f777

@@            master    #308   diff @@
======================================
  Files           89      89
  Stmts         3330    3330
  Branches       319     301    -18
  Methods          0       0
======================================
  Hit           1551    1551
  Partial         27      27
  Missed        1752    1752

Review entire Coverage Diff

Powered by Codecov


Baldur's Gate 3 theme issues

Text in .action-content class is too dark.

That's Cautious Game Master applying a text color and centering.


BUG report: update text of shape changes the font size

In my PPT I have a shape with text in font size 15.
After I do:
Debug.WriteLine(shape.TextFrame.Paragraphs.First().Portions.First().Font.Size);
shape.TextFrame.Text = "A new shape text";
Debug.WriteLine(shape.TextFrame.Paragraphs.First().Portions.First().Font.Size);

The shape's text then becomes font size 11.
Console output:
15
11
When doing this the problem desapear:
var myfontsize = shape.TextFrame.Paragraphs.First().Portions.First().Font.Size;
shape.TextFrame.Text = "A new shape text";
shape.TextFrame.Paragraphs.First().Portions.First().Font.Size = myfontsize;

Yeah, this is troublesome. It also changes the font family name as well for me. The workaround I have found is to not change the textframe text, but rather change only the paragraph text. Then I just make sure there are as many paragraphs already in the source presentation that I'll need.

There is some suspicious stuff going on in FontService.GetAdjustedFontSize.
At the top of the method:
        paint.TextSize = fontSize;

And then at the bottom:
        const int dpi = 96;
        var points = Math.Round(paint.TextSize * 72 / dpi, 0);
        return (int)points;

Ergo, text size is guaranteed to get a 25% cut, even if the wordWidth never hits the rect.Right.

I now think the problem is that FontService.GetAdjustedFontSize sets the SKPaint.TextSize (in pixels) directly to the font size )in points), without making a points-to-pixels conversion. Once the previous PR gets through, I'll submit this for review.

@sergedc, it works correctly for me. Could you please check the latest library version.


I need Object-C Library.

Hello.
We sell device using nrf52832 chip in Korea.
Unfortunately, We don't use cocoapods in App. So, I'm had change this library to Framework.
And that framework use in my application building Object-C. This is perfect! All function is nomal.
but, that framework have big size. iOSDFULibrary.framework have 25MB.
I am wondering if I should create a new library with Object-C.
please help me. Thank.

Good morning @YoonYoungDoo !
How do you generate the iOSDFULibrary.framework ? can you attach the said framework file so we can analyze it ? my guess is that the size is due to the swift standard library and having multiple build targets, what you should test is your final project size when downloaded from the app store.
but still you can send us the actual framework and we can take it from there. thanks

I build this library with release. that have armv7, armv7s, arm64.
And this size is nomal. Maybe 2.5MB?
But if build my app using this framework, app size is big.
I guess that auto add libSwift.
This is size.
iOSDFULibrary.framework  1.6MB
libswiftCore.dylib                 14.7MB
libswiftCoreGraphics.dylib  545KB
libswiftCoreImage.dylib       208KB
libswiftDarwin.dylib              297KB
libswiftDispatch.dylib          1.1MB
libswiftFoundation.dylib      5.7MB
libswiftObjectiveC.dylib      259KB
libswiftQuartzCore.dylib     213KB
libswiftUIKit.dylib                354KB

http://ehisoft.co.kr/public/ios_dfu_framework.zip
This is Framework. Please check.

Nothing seems wrong to me, you are assuming that this size is the one that your users will be downloading from the app store, which is not the case, app store distributions will be much smaller in size depending on the device that downloads them, you might want to read a bit about bitcode and app thinning
I would say just ignore the big files on export and check the actual download sizes on your production releases. so this is not really an issue with our library or the way you build it


minor improvement in Regex.init

Hi, thanks for your interest in Yamale. Can you describe what improvement this makes? If it's a performance improvement, can you provide some numbers to go along with this? Thanks!

This PR doesn't add any obvious improvements.


bug: VirtualNetwork module not dependent on ResourceProvider module.

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

terraform_version: 1.6.6
    azurerm = {
      source  = "hashicorp/azurerm"
      version = "3.81"
    }
    azuread = {
      source  = "hashicorp/azuread"
      version = "2.46.0"
    }
    azapi = {
      source  = "azure/azapi"
      version = "1.9.0"

Azure/lz-vending/azurerm version v3.4.1
Description
The Virtual Network module should be dependent on the Resource Provider module as it needs the Microsoft.Network resource provider to be able to provision network infra. As of now terraform apply will sometimes fail if the resource providers isn't applied before the Vnet resources gets created (dependent on the order things gets applied due to parallelism).
Steps to Reproduce

step 1:
Configure the Landing zone module with the following

  subscription_register_resource_providers_enabled           = true
  subscription_register_resource_providers_and_features  = { "Microsoft.Network": [] }

step 2
terraform init -> plan -> apply
Terraform failes if the resource providers isn't applied before the virtual network module

Screenshots
Error: creating/updating "Resource: (ResourceId \"/subscriptions/xxx/resourceGroups/xxx/providers/Microsoft.Network/virtualNetworks/xxx\" / Api Version \"2021-08-01\")": PUT https://management.azure.com/subscriptions/xxx/resourceGroups/xxx/providers/Microsoft.Network/virtualNetworks/xxx
--------------------------------------------------------------------------------
RESPONSE 409: 409 Conflict
ERROR CODE: MissingSubscriptionRegistration
--------------------------------------------------------------------------------
{
  "error": {
    "code": "MissingSubscriptionRegistration",
    "message": "The subscription is not registered to use namespace 'Microsoft.Network'. See https://aka.ms/rps-not-found for how to register subscriptions.",
    "details": [
      {
        "code": "MissingSubscriptionRegistration",
        "target": "Microsoft.Network",
        "message": "The subscription is not registered to use namespace 'Microsoft.Network'. See https://aka.ms/rps-not-found for how to register subscriptions."
      }
    ]
  }
}
--------------------------------------------------------------------------------

Additional context

Hi, as per #304 this is not correct. The AzAPI provider will register RPs as it needs them via the Go SDK.
Please can you run provider trace to understand why this isn't happening.

I belive this is due to that the azurerm provider is configured with the skip_provider_registration: true flag (which is desirable since the azurerm will otherwise registre all resource providers, going against the least privilege principle). By configuring this flag I belive the ARM_SKIP_PROVIDER_REGISTRATION: true environment variable is set, which then will affect the azapi provider as well. I can verify from the logs from my runner that the environment variable was set upon runtime of terraform apply.

@kristeey
Were you setting this env var in your configuration?
You are right that AzAPI also uses the same env var as AzureRM:
https://github.com/Azure/terraform-provider-azapi/blob/f4d4045f609cdd2053139b24eac57f6c9dbd5736/internal/provider/provider.go#L147-L152
This is then passed into the client options here:
https://github.com/Azure/terraform-provider-azapi/blob/f4d4045f609cdd2053139b24eac57f6c9dbd5736/internal/provider/provider.go#L366
Which is then passed into the Go SDK for Azure here:
https://github.com/Azure/terraform-provider-azapi/blob/f4d4045f609cdd2053139b24eac57f6c9dbd5736/internal/clients/client.go#L104
You can try explicitly setting skip_provider_registration=false like this:
provider "azapi" {
  skip_provider_registration = false
}

This should override the env var

Looks like this env var is already set in the runner before running the terraform commands. I will try to explicitly set
provider "azapi" {
  skip_provider_registration = false
}

the next time I run the script.

Just to clarify. This azapi flag do not registre all resource providers the way azurerm does, only the ones it needs to provision the azapi resources in the configuration files?

Just to clarify. This azapi flag do not registre all resource providers the way azurerm does, only the ones it needs to provision the azapi resources in the configuration files?

Correct, it only does the ones that it needs to make an API call :)

I can confirm that after doing the changes it works without problems for me. Just for the record:
In addition having
provider "azapi" {
  skip_provider_registration = false
}
provider "azurerm" {
  tenant_id                  = var.tenant_id
  subscription_id            = var.subscription_id
  skip_provider_registration = true
  features {}
}

to the provider configuration, I removed the ARM_SKIP_PROVIDER_REGISTRATION: true environment variable from my running environment.

Thank you for this
Indeed I did have skip_provider_registration = true
Changed it to false and all worked like a charm
Please close this :)


UC8179 instead of the UC8151

Good morning Antirez,
I have been trying to get your code to work with another driver (the UC8179 instead of the UC8151) It’s a similar chip but slightley different because my display has a higher resolution (800x600)
I’m just getting started and the IC’s seem similar enough. Do you have any thoughts about the feasibility of this plan?
Link to datasheets:
https://cursedhardware.github.io/epd-driver-ic/UC8151c.pdf
https://www.buydisplay.com/download/ic/UC8179.pdf

Hi @Rendier-veel, I can't see any reason why you should not be able to port this driver to your chip. The LUTs look identical, and in general the chip is very similar. I bet it will work. Perhaps you will require to adapt the time-to-black and a few things, but seems definitely possible. Please ping me if you will have success :)

Good luck. Registers appear to be very similar. Resolution is set in the larger chip with a different register, resolution setting. There are a few more differences in the other registers configuration, but overall the chip appears to work in a very similar fashion.

Hello Antirez,
A couple of frustrating days later… It became a bit of a long story I’ve send you an email. I hope that’s ok? Thank you in advance.
Kind regards

I've managed to make it work on UC8176 chip (4.2inch 400x300), with a ESP32-C3 based board running MicroPython.
Almost everyting works without modification, except the @micropython.viper which is not supported on ESP32-C3 yet.


[enhancement]: Extensions with Powershell Core execution handler

Describe your feature request here
Hi,
it would be great if a powershell core (pwsh) execution handler for extensions would be available.
If you have currently a powershell extension it's not easy to make it platform independant because you have to rewrite the extension completly in Typescript. Going from powershell 5 to powershell core is relativly easy.
Maintenance on Typescript extensions is much higher. There is a huge dependancy tree that has to be updated for security reasons regularly and there are much more breaking changes in the Node world then in the Powershell world.
greetings
Carsten

Hi @ckrueger1979, thanks for reporting! We are working on more prioritized issues at the moment but will get back to this one soon.

@ckrueger1979 thanks for the suggestion. We are considering various options for new execution handlers, and this is one of them.

@geekzter browsing through the code, it doesn't look hard to add this feature on the agent. Should be like 2 files to implement, possibly a bit more if we were to add proper linux support.
On top of that the VstsTaskSdk would need to be ported. Most of the tasklib would be simple, the bits that do Authentication and load the object model would be more work.
What are the reasons for not adding it? Last time I asked, years ago, it was to not have to add to the maintenance burden. But looking at the code the PowerShell and PowerShell3 handler have been stable and haven't had any major work done on them since forever. The VstsTaskSdk has been very stable as well.

@geekzter @kirill-ivlev is there any update on this?
I think that this is a much needed feature.
Updating all my tasks to use PowerShell7 is a pain.
It's more complex to rewrite everything in TypeScript just to call pwsh.exe.
Having a PowerShell7 Handler would make things more easier and faster. 😊

Still hoping

I'm also hoping too @jessehouwing. between typescript and powershellcore, i'd much rather use powershellcore. it's easier to write and debug.

Still looking forward to get this feature.
Would make a lot of things easier.


Add option to pass parameters in contract deployment

The visual tracker allows to deploy contracts via the GUI. Though, contracts that expect a data parameter in their _deploy method can't be handled correctly, since it is not possible to pass a parameter via the visual tracker's GUI. Thus, this issue asks for the option of passing parameters in the process of deploying a contract with the visual tracker.

I'm assuming this issue still hasn't been addressed, correct? I tried getting it to work on my own setup but was unsuccessful...? @devhawk

This has not been addressed to my knowledge

This would be a really convenient feature imo. When developing a contract with deployment data, developers currently are forced to use an SDK to deploy the contract. I rewrote the example in neow3j's boilerplate, hardcoding an address instead of passing it in the deployment, so that developers can more easily get started with the boilerplate and the visual devtracker together. It would be awesome if this option was provided to showcase new developers in a more convenient way that something like this does not need to be hardcoded in the contract, but can just be passed when deploying.
It's been a while since this issue was opened, @devhawk do you think this could get some priority in the near future?


Integrates sentry to catch the flask errors

Will need to add env variable SENTRY_DSN on heroku.

Heroku created the SENTRY_DSN env variable automatically when I added the Sentry addon.

got it, I just checked and tested this branch on my test heroku and seemed to work fine with the auto set env var. @joshfraser


Return value after executing command request

Hello,
We have discussed about this issue here:
https://github.com/Microsoft/language-server-protocol/issues/329
With this change, I am able to fetch values returned from server.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@danixeee this is a very good catch. Thanks for providing the PR.


[test, otbn] Rework otbn_mem_scramble_test

This PR reworks the otbn_mem_scramble_test to:

Not check the entire IMEM and DMEM as this can be very slow. Instead a set of random addresses for both IMEM and DMEM are chosen.
Allow for a certain number of valid integrity bits even after re-scrambling. There is a non-zero chance that this happens. Some basic testing showed that roughly 1 out of 100 checked addresses has still valid integrity bits after re-scrambling.

This resolves lowRISC/OpenTitan#13974.

This works on Verilator. Some more testing is needed as in some cases we get unexpected mismatches. Also testing on FPGA and in VCS is needed.

This is now ready for review. The test is now working as expected on Verilator and DV. Would you mind reviewing this @engdoreis ?


Populate companyname and other properties for PSResourceInfo

When installing a package, save companyname, copyright and other metadata information to metadata xml file. Also change setters access levels for these properties of the PSResourceInfo class. Get-PSResource will now return consistent information for packages installed with Install-PSResource cmdlet after this fix.
When finding a package, companyname and other related information is not easily accessibly via the json metadata (IPackageSearchMetadata object returned via NuGet GetSearchAsync() and GetMetadataAsync() search APIs and currently is more operational cost than is worth to get this field. Here is a link listing the package information accessible via the package nuspec (note company name is not listed):
https://docs.microsoft.com/en-us/nuget/reference/nuspec

PR Summary

PR Context
Resolves #267
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Documentation needed

[ ] Issue filed:

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

@anamnavi, @alerickson  please look at authenticode check test failures.


thinned out project.toml

Codecov Report

Merging #53 (e10334d) into master (346734d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   73.87%   73.87%
=======================================
  Files          16       16
  Lines         869      869
=======================================
  Hits          642      642
  Misses        227      227

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346734d...e10334d. Read the comment docs.


odd behavior with backup/restore and Copy-SqlDatabase

Is this a feature OR bug:
Bug

Powershell Version: 5.0.10586.117
OS Version: Windows 7

Steps to Reproduce
Run Copy-SqlDatabase from SQL 2012 box to a SQL 2016 box with BaclupRestore option
I have a database that causes the issue I can upload somewhere. (65MB)
Action Results
After database is backed up then restored SQL 2016 as the destination engine stops
Expected Results
Restore works after restore
Additional comments
I have a backup that crashes taken by DBATools and I have a backup taken via TSQL that does not crash.  Initially thought it was because of compat level 90 to SQL 2016, but I change source to 110 and still does not work.  I then thought it was due to the db owner not being a login on the destination server so I migrated logins and still same result, then changed to sa on source and after backup restore it still fails.  I can backup with TSQL and restore with TSQL and no issues occur.

Please do provide the database when you can. As well if you can edit your issue and include the exact command you used.
I just migrated the pubs sample database from 2012 to 2016 on my local instance and had no issues.

Hey @gbargsley can you please provide the dbatools exception file? 2016 to 2016 works well. I've done it 100 times and can't replicate your issue.
We use copy-only backups. Can you try backing up and restoring with that? Also, try specifying -NoBackupCleanup then restoring the backup it created.

@gbargsley are you able to provide any more detail on this issue (e.g. database or requested info above)?


[pe-parse] Add new port

Adds a port for pe-parse, a principled, lightweight parser for the PE executable format.

What does your PR fix?

None.

Which triplets are supported/not supported? Have you updated the CI baseline?

All default triplets should work.

Does your PR follow the maintainer guide?

I believe so!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: woodruffw sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

LGTM, thanks for this PR!

LGTM, thanks for this PR!

Thanks for the fast review!

LGTM, thanks for the PR!


Support for the new /api/embed endpoint [DRAFT]

Hi added the functionality but not tests yet. I can take a look later this weekend or feel free to add the tests.

@lebrunel  sorry just saw the issue that you already discussing this, I can close it.

Thanks for the PR @nyo16 I didn't merge this one because your formatter changed a gazillion lines of code. 😅
But the /embed endpoint is supported here: d38f791
New release imminent.


Fixing batch_dim_name attribute

ModelParallel(batch_dim_name='batch') is currently dysfunctional and will work only if batch_dim_name corresponds to the first dimension of the mesh, which is the default anyway. There is also a problem for meshes with 3 and more dimensions.
Minimal repro 1 (showing error):
https://colab.research.google.com/drive/1jzmCZ2WNlKtD4j2heSaq-mxBoG-9WeeS?usp=sharing
Minimal repro 2 with a 3D mesh (showing error):
https://colab.research.google.com/drive/1AGku4hjwhTN_2h5yiU7Q-a6vvSrc8nRH
Real-world repro 1 (showing successful run with fix):
https://colab.research.google.com/drive/1cyn_XUFwdLUJE4pRNWPgZ2H5wzKzto-T?usp=sharing
Real-world repro 2 (showing a run without errors - but unfortunately no convergence):
https://colab.research.google.com/drive/1kY9qq27YxpowqYDT3gL98U5RuN6CYQ7b?usp=sharing
The use case is not just hypothetical.
With DeviceMesh((4,2), ("model", "batch")), fine-tuning proceeds at 147ms/step.
With DeviceMesh((2,4), ("batch", "model")), fine-tuning proceeds at 205ms/step.
The fix makes the first, faster use case work, as tested with the real-world repro 1 notebook on TPU v5e.
Remaining issues:

Real-world repro 2 does not show convergence. Maybe there is another bug in loss aggregation??
The fixes should work for combined data and model parallelism where the data is sharded along one axis and the model along a different set of axes. That is the assumption in backend/jax/distribution_lb.py:
** num_model_replicas_total = layout.mesh.shape[batch_dim_name] i.e. the number of model replicas is the nb of devices along the "batch" axis of the mesh
** mesh_model_dim_size computation:  data is replicated as many times as there are unique model shards.
However, the default layout map for Gemma shards the model also along the "batch" dimension. This will work as long as the "batch" dimension is 1 but is useless in that case. When the "batch" dimension is >=2, I don't know what it means, i.e. how many model model replicas there are and therefore how input data should be split. The Keras team should chime in on this.

Codecov Report
Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 29.94%. Comparing base (7c491bd) to head (830eed2).

Files with missing lines
Patch %
Lines

keras/src/backend/jax/distribution_lib.py
16.66%
5 Missing :warning:

keras/src/backend/jax/trainer.py
0.00%
2 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (7c491bd) and HEAD (830eed2). Click for more details.
HEAD has 8 uploads less than BASE

Flag
BASE (7c491bd)
HEAD (830eed2)

keras
5
1

keras-numpy
1
0

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20674       +/-   ##
===========================================
- Coverage   81.95%   29.94%   -52.02%
===========================================
  Files         543      543
  Lines       50664    50670        +6
  Branches     7828     7830        +2
===========================================
- Hits        41524    15175    -26349
- Misses       7246    34937    +27691
+ Partials     1894      558     -1336

Flag
Coverage Δ

keras
29.94% <12.50%> (-51.85%)
:arrow_down:

keras-jax
?

keras-numpy
?

keras-openvino
29.94% <12.50%> (-0.01%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Real-world repro 2 does not show convergence. Maybe there is another bug in loss aggregation?
@martin-gorner Could you clarify what you meant by 'no coverage' in this context?

Real-world repro 2 does not show convergence. Maybe there is another bug in loss aggregation?

@martin-gorner Could you clarify what you meant by 'no coverage' in this context?

Typo. I meant "convergence", i.e. the loss is not decreasing. I fixed the typo

@SamanehSaadat is this LGTM?

@SamanehSaadat is this LGTM?

Not yet! I'll tag you when it's ready.


Improved automatic closing brace insertion rules & settings interface.

Users are able to set multiple rules per set of braces, with a better interface.

I see the picture and I don't understand what are the fields in that grid ^^U.

Yeah, that configuration has always been so hard to make it fully customisable and also user friendly at the same time.
Basically, you read everything from the column headers. For example from the picture above:
After (no character matches) Or After { Type } And Not Before { '<' } And Not Before { Identifier, Type }
or
After { '.' } And After { Operator } And Not Before { '<' } And Not Before { Identifier, Type }
Basically the 1st rule matches for Type<| not followed by '<', identifier or type. Result is Type<|>. | is the cursor.
2nd rule matches for Type.<| not followed by '<', identifier or type. Note that since "After '.' AND After Operator", it doesnt match for 100.<.

Needs to wait for #1519 and after resolve merge conflicts.

With ae28d74 I've added a green plus image to Images.png and Images32.png (drew myself):
16x16

32x32

@Meychi

We should write some wiki entry explaining how to setup this stuff.


Set unified response dto wrapper for clarity.

Currently response is mapped as below (plain page object to JSON serialize)
{
    "totalPages": 1672742,
    "totalElements": 8363706,
    "number": 0,
    "sort": {
        "sorted": false,
        "empty": true,
        "unsorted": true
    },
    "size": 5,
    "content": [
        {
            "id": 3,
            "name": "Josh Wink",
            "realName": "Joshua Winkelman",
            "profile": "Electronic music DJ, label owner, producer, and remixer, born April 20, 1970 in Philadelphia, Pennsylvania, USA. Formed [l=Ovum Recordings] as an independent label in October 1994 with former partner [a=King Britt].",
            "dataQuality": "Needs Vote"
        },
        {
            "id": 4,
            "name": "Johannes Heil",
            "realName": "Johannes Heil",
            "profile": "Electronic music producer, musician and live performer, born 3 February 1978 near the town of Bad Nauheim, Germany. Founder of [l=JH] and [l=Metatron Recordings], releasing loads of Techno records. Been active until 2019 when he suddenly decided to delete himself from almost all the social media platforms.",
            "dataQuality": "Needs Vote"
        },
        {
            "id": 5,
            "name": "Heiko Laux",
            "realName": "Heiko Laux",
            "profile": "German DJ and producer based in Berlin. He is the founder of [l=Kanzleramt].",
            "dataQuality": "Needs Vote"
        },
        {
            "id": 6,
            "name": "K.A.B.",
            "realName": "Karl Axel Bissler",
            "profile": "",
            "dataQuality": "Needs Major Changes"
        },
        {
            "id": 7,
            "name": "Sylk 130",
            "realName": "King James Britt",
            "profile": "",
            "dataQuality": "Needs Vote"
        }
    ],
    "pageable": {
        "sort": {
            "sorted": false,
            "empty": true,
            "unsorted": true
        },
        "offset": 0,
        "pageNumber": 0,
        "pageSize": 5,
        "paged": true,
        "unpaged": false
    },
    "numberOfElements": 5,
    "last": false,
    "first": true,
    "empty": false
}

Since we have an agreement from meetup, I think it is time to map the result as below, which requires validation.
source
{
// internal structure is up to each dto, but will always be in an array, whether empty or not.
	"data": [
			{
					"id":32,
					"title":"something...",
			},
	],
// 500s will not have rejected, param field.
// this error structure must be the same as what will be logged (!important)
  "error": [
			{
					"reason":"invalid type. expected: integer", // reason for error
					"rejected":"hello world",  // invalid value
					"param":"id",  // param where validation failed
					"resource_uri","/api/v1/artist", // resource uri where request failed
			},
	],
	// total elements from table
	"totalElements": 300,
	// i.e. totalElements / pageSize
        "totalPages": 71,
	// begin from 1
	"number": 1,
	// is this page the last page
	"last": false,
        // current page size
	"pageSize": 50,
	// length of the data array
	"dataSize": 1,
  // sorted or not.
  "sorted": false,
}

Since we got several suggestions on how DTO to be wrapped, it is now clear that we must not include errors on valid responses; bringing separation will bring more instant insight on what is what.
Will have to update the schema so I will keep things posted.


Create transcription request results in a No JSON content found error

Describe the bug
Create transcription request is not working on il2cpp, I am getting this error message when a request is sent, seems like a Newtonsoft json issue, was wondering if anyone had encountered it

"Newtonsoft.Json.JsonSerializationException: No JSON content found and type \'OpenAI.CreateAudioResponse\' is not nullable. Path \'\', line 0, position 0.\n  at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize (Newtonsoft.Json.JsonReader reader, System.Type objectType, System.Boolean checkAdditionalContent) [0x00057] in C:\\Users\\Adrien\\Workspace\\Newtonsoft\\Newtonsoft.Json-for-Unity-Pedro\\Src\\Newtonsoft.Json\\Serialization\\JsonSerializerInternalReader.cs:159 \n  at Newtonsoft.Json.JsonSerializer.DeserializeInternal (Newtonsoft.Json.JsonReader reader, System.Type objectType) [0x00054] in C:\\Users\\Adrien\\Workspace\\Newtonsoft\\Newtonsoft.Json-for-Unity-Pedro\\Src\\Newtonsoft.Json\\JsonSerializer.cs:904 \n  at Newtonsoft.Json.JsonSerializer.Deserialize (Newtonsoft.Json.JsonReader reader, System.Type objectType) [0x00003] in C:\\Users\\Adrien\\Workspace\\Newtonsoft\\Newtonsoft.Json-for-Unity-Pedro\\Src\\Newtonsoft.Json\\JsonSerializer.cs:883 \n  at Newtonsoft.Json.JsonConvert.DeserializeObject (System.String value, System.Type type, Newtonsoft.Json.JsonSerializerSettings settings) [0x00030] in C:\\Users\\Adrien\\Workspace\\Newtonsoft\\Newtonsoft.Json-for-Unity-Pedro\\Src\\Newtonsoft.Json\\JsonConvert.cs:831 \n  at Newtonsoft.Json.JsonConvert.DeserializeObject[T] (System.String value, Newtonsoft.Json.JsonSerializerSettings settings) [0x0000c] in C:\\Users\\Adrien\\Workspace\\Newtonsoft\\Newtonsoft.Json-for-Unity-Pedro\\Src\\Newtonsoft.Json\\JsonConvert.cs:787 \n  at OpenAI.OpenAIApi.DispatchRequest[T] (System.String path, System.Collections.Generic.List`1[T] form) [0x00166] in C:\\Users\\kenpc\\Unity\\TheSafeOne\\Library\\PackageCache\\com.srcnalt.openai-unity@d2a258ab0c\\Runtime\\OpenAIApi.cs:177

To Reproduce
Steps to reproduce the behavior:

Run the transcription sample, add a try catch on the createTranscriptionRequest line first
Run the debugger, or check if it gets stuck
See error

Expected behavior
It should not throw an error
Environment (please complete the following information):

OS: Android built with il2cpp
Unity Version 2021.3.25f1
Plugin Version 0.1.15

My bad, I'm just an idiot, didn't realize I was connected to a broken internet connection

No worries, maybe wrapping requests to an internet connection check makes sense.


Allow envoy's access log file location to be configurable

Description
As Ambassador currently configures it, Envoy will log all requests to STDOUT. This PR introduces a envoy_log_path configuration option that allows the user to specify any filepath that Envoy will use for this logging.
Potential use cases:

Logging to a mounted volume
Logging to /dev/null to suppress all output

Related Issues
https://github.com/datawire/ambassador/issues/1819
Testing
Not sure the best testing that needs to be done here. We use this in production and any issues would ultimately be issues with Envoy rather than Ambassador itself. Let me know if there is something specific that we need to test.
Todos

[ ] Tests
[x] Documentation

A good way to test this is probably to have a test that sets it to /tmp/ambassador/ambassador.log, then use kubectl exec $pod cat /tmp/ambassador/ambassador.log at the end of the test to check its contents. The check method of a kat test could do this.

I have added a test like you mentioned here. Feel free to make any suggestions to the test. I contemplated adding a Query to a specific endpoint and then check the access logs for that unique endpoint, but settled on checking for the ambassador healthchecks. Let me know if you prefer otherwise.


netron: Update homepage

Closes #7247

/verify

You will need to update the checkver property too, since it no longer knows where the repo is

Autoupdate is correct. I assume the bot stops on the first error.

/verify

Great, thanks for the fix!


Add note about baseurl in Images guide

Currently the Images contains this example:
<!-- Local image stored at public/assets/stars.png -->
<img src="/assets/stars.png" alt="A starry night sky.">

This could be confusing for users making use of the "base" config option, as the url will from the example will be invalid in combination with this config option. The correct src attribute path would be "/myBaseUrl/assets/stars.png".

Thanks for this - our approach is to document this in the base reference!
We'll be planning a recipe on working with base.


Is ipam.mode=kubernetes required for local kind clusters?

Documentation uses ipam.mode=kubernetes option but doesn't explain why. Is this option required on kind clusters? Default cilium install command seems to be working fine. I don't know what I'd be missing if this option is not set.

There are various options for IPAM documented here: https://docs.cilium.io/en/stable/network/concepts/ipam/#address-management . Kubernetes is a simple general purpose option, but you can choose an alternative if you like.

Ah okay. Good to know that it wasn't something specific to kind.


Fix readme issue#34

Added Width to Covalent Table. Fixed Copy and Paste Issue

[x] I have added the tests to cover my changes.
[x] I have updated the documentation, VERSION, and CHANGELOG accordingly.
[x] I have read the CONTRIBUTING document.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @scarycool11, what’s the status of this issue? :)

@scarycool11 Hey just wanted to check the status of this issue. Really appreciate the contribution. I think you're close to getting this done. :D


adding grumphp, php-cs-fixer, fixing styles, narrowing namespace, removing circular dependency issue

Codecov Report

Merging #1 into master will decrease coverage by 1.09%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master       #1     +/-   ##
===========================================
- Coverage     94.18%   93.09%   -1.1%
  Complexity      118      118
===========================================
  Files             3        3
  Lines           275      275
===========================================
- Hits            259      256      -3
- Misses           16       19      +3

Impacted Files
Coverage Δ
Complexity Δ

...rc/Zend/Layout/Controller/Action/Helper/Layout.php
91.66% <100%> (-5.56%)
16 <0> (ø)

src/Zend/Layout/Controller/Plugin/Layout.php
80.95% <100%> (ø)
17 <0> (ø)
:arrow_down:

src/Zend/Layout.php
95.93% <100%> (-0.51%)
85 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f2465...02d1ed9. Read the comment docs.


Hydration bug with browser extensions

Describe the bug
https://limey.io is using SvelteKit, and many users are reporting that the site isn't loading properly. It seems that hydration isn't happening. In some very rare occurrences, it does hydrate.
The issue only happens with certain browser extensions, for example the BeaNote extension.
I've reproduced it on Netlify and CloudFlare Pages, but not locally.
Reproduction
Repo: https://github.com/probablykasper/sveltekit-hydration-bug

Deploy to Netlify or CloudFlare Pages
Install the BeaNote
Visit the deployed site

Logs
No response
System Info
System:
    OS: macOS 10.15.7
    CPU: (8) x64 Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
    Memory: 396.21 MB / 32.00 GB
    Shell: 3.2.2 - /usr/local/bin/fish
  Binaries:
    Node: 16.13.1 - /var/folders/gs/3qcm1mc918s08sxvkj6zj2rr0000gp/T/fnm_multishells/39265_1649091675026/bin/node
    Yarn: 1.22.17 - /var/folders/gs/3qcm1mc918s08sxvkj6zj2rr0000gp/T/fnm_multishells/39265_1649091675026/bin/yarn
    npm: 8.1.2 - /var/folders/gs/3qcm1mc918s08sxvkj6zj2rr0000gp/T/fnm_multishells/39265_1649091675026/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 99.0.4844.84
    Firefox: 98.0
    Safari: 15.4
  npmPackages:
    @sveltejs/adapter-static: ^1.0.0-next.29 => 1.0.0-next.29
    @sveltejs/kit: ^1.0.0-next.303 => 1.0.0-next.304
    svelte: ^3.46.6 => 3.46.6

Severity
blocking all usage of SvelteKit
Additional Information
No response

It seems like having app.html body like this causes it:

    %svelte.body%

Switching to this fixes it:

%svelte.body%

I couldn't find any documentation stating that you should wrap %svelte.body% in a tag though. In fact, the Sapper migration guide specifically states "The
 is no longer necessary".

Yeah, the default app.html files in the project templates are wrapped for this reason. The best we can do is figure out how to document it so that people don't run into this issue

@probablykasper kinda related, you should also probably disable Rocket Loader (in the Cloudflare dashboard) for your page since it delays loading of the JS(at least until they rocket loader library loads) and since you are using SPA, you need JS for the page to be able to load, so it's needless, and could actually break the page

@PH4NTOMiki Thanks for the recommendation!

Closed by #6245