Fail to build OCIS with docker

Describe the bug
Fail to build OCIS using docker.
Steps to reproduce
Steps to reproduce the behavior:

Clone or download the repository
Open terminal and digit: docker build -t ocis .

Expected behavior
No erros on building the application using docker.
Actual behavior
A message of error on building web and graph-explorer, missing the assets directory.
#16 236.3 git clean -xfd assets
#16 236.4 Removing assets/
#16 236.4 curl --fail -slL -o- https://github.com/owncloud/web/releases/download/v5.7.0-rc.8/web.tar.gz | tar xzf - -C assets/
#16 237.7 tar: assets: Cannot open: No such file or directory
#16 237.7 tar: Error is not recoverable: exiting now
#16 237.7 make[2]: *** [Makefile:36: pull-assets] Error 2
#16 237.7 make[1]: *** [Makefile:158: ci-node-generate] Error 1
#16 237.7 make: *** [Makefile:42: ci-node-generate] Error 2
Additional context
Correction:
Insert "mkdir assets", before the curl command, in
\ocis\services\graph-explorer\Makefile, and
\ocis\services\web\Makefile

I updated the  golang image to 1.18
The assets folder needs to be generated during the node and go generate steps. Maybe there were some build issues in your case.
Using the code from #4377 works for me.
docker build -t ocis .
[+] Building 431.1s (18/18) FINISHED
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 1.24kB                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 34B                                                                                0.0s
 => [internal] load metadata for docker.io/library/alpine:3.15                                                                                1.2s
 => [internal] load metadata for docker.io/owncloudci/nodejs:14                                                                                0.6s
 => [internal] load metadata for docker.io/owncloudci/golang:1.18                                                                                2.1s
 => [internal] load build context                                                                                0.1s
 => => transferring context: 152.35kB                                                                                0.1s
 => [stage-2 1/3] FROM docker.io/library/alpine:3.15@sha256:69463fdff1f025c908939e86d4714b4d5518776954ca627cbeff4c74bcea5b22                                                                                3.2s
 => => resolve docker.io/library/alpine:3.15@sha256:69463fdff1f025c908939e86d4714b4d5518776954ca627cbeff4c74bcea5b22                                                                                0.0s
 => => sha256:69463fdff1f025c908939e86d4714b4d5518776954ca627cbeff4c74bcea5b22 1.64kB / 1.64kB                                                                                0.0s
 => => sha256:7a38a4540724813e4190d086e955a8e757a7302551cc7555012fa63b57f1cf87 528B / 528B                                                                                0.0s
 => => sha256:c4fc938168588a0ba6178945c3d9047f27101eb3a420d9b758295e9ef8df3dc0 1.47kB / 1.47kB                                                                                0.0s
 => => sha256:9621f1afde84053b2f9b6ff34fc7f7460712247c01cbab483c5fa7132cf782ca 2.82MB / 2.82MB                                                                                3.0s
 => => extracting sha256:9621f1afde84053b2f9b6ff34fc7f7460712247c01cbab483c5fa7132cf782ca                                                                                0.2s
 => CACHED [generate 1/4] FROM docker.io/owncloudci/nodejs:14@sha256:471ade88fc5a73189e56997661c772bb1c6abf348555c7f36e441a9711cb386d                                                                                0.0s
 => [build 1/4] FROM docker.io/owncloudci/golang:1.18@sha256:9cd11b3146a101a46d27ac7c4cf1028ca25300ee003b5c7469e79fdb9d30573b                                                                                55.5s
 => => resolve docker.io/owncloudci/golang:1.18@sha256:9cd11b3146a101a46d27ac7c4cf1028ca25300ee003b5c7469e79fdb9d30573b                                                                                0.0s
 => => sha256:9cd11b3146a101a46d27ac7c4cf1028ca25300ee003b5c7469e79fdb9d30573b 1.11kB / 1.11kB                                                                                0.0s
 => => sha256:5ed2db52ff3ef243e33ad641b6a7d844b43e25f0756322028f41cc34d2d17585 1.58kB / 1.58kB                                                                                0.0s
 => => sha256:6c9156526933ec20627065a67a5c9aa60b80fc8099d8f0cfea852dcf5a1f5bdb 8.52kB / 8.52kB                                                                                0.0s
 => => sha256:213ec9aee27d8be045c6a92b7eac22c9a64b44558193775a1a7f626352392b49 2.81MB / 2.81MB                                                                                1.8s
 => => sha256:5299e6f7860564fd4df7e9a224f3d05dc26d0e855fb26ac7e9d9e156cf1422b2 284.73kB / 284.73kB                                                                                0.2s
 => => sha256:1cab0e43db0af1d30e55de347bd78df438344691f8fb379f631a07e2c8a80f0a 155B / 155B                                                                                0.3s
 => => sha256:af72e8bb74dba7b7a51456e414ac4999ff55a6a68e532a7cd1b6f32707be625f 115.31MB / 115.31MB                                                                                43.5s
 => => sha256:3a421caacf35538ce671745cb9396eea38bf42cd3093eaf78dbcbe8bf5f83f82 156B / 156B                                                                                0.8s
 => => sha256:1e9520d370f2b6b5948aca2dad6fc570b7feaf223970002047abda22b948cf91 55.62MB / 55.62MB                                                                                35.5s
 => => extracting sha256:213ec9aee27d8be045c6a92b7eac22c9a64b44558193775a1a7f626352392b49                                                                                0.2s
 => => extracting sha256:5299e6f7860564fd4df7e9a224f3d05dc26d0e855fb26ac7e9d9e156cf1422b2                                                                                0.1s
 => => extracting sha256:1cab0e43db0af1d30e55de347bd78df438344691f8fb379f631a07e2c8a80f0a                                                                                0.0s
 => => extracting sha256:af72e8bb74dba7b7a51456e414ac4999ff55a6a68e532a7cd1b6f32707be625f                                                                                8.3s
 => => extracting sha256:3a421caacf35538ce671745cb9396eea38bf42cd3093eaf78dbcbe8bf5f83f82                                                                                0.1s
 => => extracting sha256:1e9520d370f2b6b5948aca2dad6fc570b7feaf223970002047abda22b948cf91                                                                                2.7s
 => [generate 2/4] COPY ./ /ocis/                                                                                1.7s
 => [generate 3/4] WORKDIR /ocis/ocis                                                                                0.0s
 => [generate 4/4] RUN make ci-node-generate                                                                                184.2s
 => [stage-2 2/3] RUN apk update &&  apk upgrade &&  apk add ca-certificates mailcap &&  rm -rf /var/cache/apk/* &&  echo 'hosts: files dns' >| /etc/nsswitch.conf                                                       3.0s
 => [build 2/4] COPY --from=generate /ocis /ocis                                                                                36.4s
 => [build 3/4] WORKDIR /ocis/ocis                                                                                0.0s
 => [build 4/4] RUN make ci-go-generate build                                                                                172.1s
 => [stage-2 3/3] COPY --from=build /ocis/ocis/bin/ocis /usr/bin/ocis                                                                                0.3s
 => exporting to image                                                                                0.4s
 => => exporting layers                                                                                0.4s
 => => writing image sha256:a481b843d9319880b7571fc54d9580278419dc719aaabf1414a95176db336d17                                                                                0.0s
 => => naming to docker.io/library/ocis                                                                                0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them


[ETFE-3796] - Added shipping marks choice page and removed more than one product type page

Needs a rebase btw


No markdown generated for entity version of the FLA

Following https://contributoragreements.org/ca-cla-chooser/?beneficiary-name=KDE+e.V.&project-name=KDE&project-website=ev.kde.org&project-email=kde-ev-board%40kde.org&process-url=https%3A%2F%2Fev.kde.org%2Frules%2Ffla%2F&project-jurisdiction=Germany&agreement-exclusivity=exclusive&fsfe-compliance=&fsfe-fla=&outbound-option=fsfe&outboundlist=&outboundlist-custom=&medialist=\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_&patent-option=Traditional&your-date=&your-name=&your-title=&your-address=&your-patents=&pos=apply&action=](https://contributoragreements.org/ca-cla-chooser/?beneficiary-name=KDE+e.V.&project-name=KDE&project-website=ev.kde.org&project-email=kde-ev-board%40kde.org&process-url=https%3A%2F%2Fev.kde.org%2Frules%2Ffla%2F&project-jurisdiction=Germany&agreement-exclusivity=exclusive&fsfe-compliance=&fsfe-fla=&outbound-option=fsfe&outboundlist=&outboundlist-custom=&medialist=____________________&patent-option=Traditional&your-date=&your-name=&your-title=&your-address=&your-patents=&pos=apply&action= which comes out of the chooser, you end up on the final page where the "entity" agreement's MKDN button pops up an empty window.
The "entity" HTML and PDF buttons do produce output. The "individual" buttons all three produce output.

This isn't related, I don't think (at least, not to the latest stages of that issue, where it's more about the text than not having an Entity-FLA at all):

follow that link; you end up on the "you are done" page
next to "Fiduciary Contributor License Agreement", click the HTML button. Notice a new window / pop-up thingy appears, containing HTML code. Close it. Click the MKDN button. Notice a new window appears, containing Markdown code. Close it.
next to "Entity Fiduciary Contributor License Agreement", click the HTML button. Notice a new window appears, containing HTML code. Close it. Click the MKDN button. The new window appears, but is totally blank. There is no text to select or copy.

Should be fixed in #59. Sorry that it took a while.


fix regresion from https://github.com/apache/nuttx/pull/14881

Summary
fix regresion from https://github.com/apache/nuttx/pull/14881
reason:
svc call may trigger hardfalt
Background
The origin of this issue is our desire to eliminate the function of storing
"regs" in g_current_regs and instead utilize (*running_task)->xcp.regs for storage.
The benefits of this approach include faster storage speed and
avoiding multiple accesses to g_current_regs during context switching,
thus ensuring that whether returning from an interrupt or an exception,
we consistently use this_task()->xcp.regs
Issue Encountered
However, when storing registers, we must ensure that (running_task)->xcp.regs is invalid
so that it can be safely overwritten.
According to the existing logic, the only scenario where (running_task)->xcp.regs
is valid is during restore_context. We must accurately identify this scenario.
Initially, we used the condition (running_task)==NULL for this purpose, but we deemed
this approach unsatisfactory as it did not align well with the actual logic.
(running_task) should not be NULL. Consequently, we adopted other arch-specific methods for judgment,
but due to special logic in some arch, the judgment was not accurate, leading to this issue.
Solution:
For armv6-m, we haven't found a more suitable solution, so we are sticking with (*running_task)==NULL.
For armv7-m/armv8-m, by removing support for primask, we can achieve accurate judgment.
PRIMASK is a bad design in armv6-m, that's why arm introduce BASEPRI from armv7-m. It's wrong to provide this option for armv7-m/armv8-m arch.
Impact
armv6-m
armv7-m
armv8-m
Testing
ci

[Experimental Bot, please feedback here]
No, this PR does not fully meet the NuttX requirements.  While it provides a link to the related PR and identifies affected architectures, it lacks crucial details.  Here's a breakdown:

Insufficient Summary:  It states what is fixed (a regression), but not how.  It briefly mentions a hard fault possibility, but doesn't explain the root cause of the regression or the solution implemented. The functional part of the code being changed isn't specified.
Incomplete Impact: While it lists architectures, it doesn't use the YES/NO format and lacks descriptions.  All other impact categories are missing.  Does this change require documentation updates?  Are there compatibility concerns?
Inadequate Testing:  Stating "ci" isn't sufficient.  The requirements ask for specific build host details and target details.  Critically, it's missing "before" and "after" testing logs, which are essential to demonstrate the fix's effectiveness.

The PR needs substantial improvement in all three sections (Summary, Impact, and Testing) before it can be considered complete.

also influence this issue #14514

I confirm that this PR fixes this issue on nrf52 https://github.com/apache/nuttx/issues/14514

What are the consequences of this change?

syscall doesn't go through hardfault.

Does it have any disadvantages compared to PRIMASK?

I don't see any bad side effect.

This is not a trivial change, so it's worth discuss it more as we basically force users to use BASEPRI here.

PRIMASK is a bad design in armv6-m, that's why arm introduce BASEPRI from armv7-m. It's wrong to provide this option for armv7-m/armv8-m arch.

@hujun260 what about armv6-m ? this arch doesn't support BASEPRI, so this architecture is still broken.

PRIMASK is a bad design in armv6-m, that's why arm introduce BASEPRI from armv7-m. It's wrong to provide this option for armv7-m/armv8-m arch.

I think the timeline is different. armv7-m was introduced before armv6-m. The second one is a cut version of the first one and if ARM decided to get rid of BASEPRI they must have had a reason for this (but of course they could have made a design mistake here)

I don't see any bad side effect.

I don't see any flaws in this solution either and it can simplify a lot of things. But people use NuttX in different ways. A change like this should be more widely communicated in the community, maybe someone sees drawbacks.

@hujun260 what about armv6-m ? this arch doesn't support BASEPRI, so this architecture is still broken.

It has been restored to the old implementation.

@hujun260 Please include a complete explanation in the commit log message. I saw @xiaoxiang781216 try to explain a little bit about it, but it is important to explain what was modified initially that caused the issue (and why it was modified) and then how the new modification fixes the issue. It could help us understand it better and help other people in the future when looking this commit.

was not accurate, leading to this issue.
Solution: For armv6-m, we haven't found a more suitable solution, so we are sticking with (*running_task)==NULL. For armv7-m/armv8-m, by remo

done

@hujun260 please extend the explanation from @xiaoxiang781216 and include it in the commit log message

@hujun260 please extend the explanation from @xiaoxiang781216 and include it in the commit log message

aleady add to the second commit

@hujun260 @xiaoxiang781216 Could we remove the word "bad" from the commit message? I don't think this is a bad design, right? These are two interrupt masking mechanisms provided by the CPU. Similar to cortex-a/r, the CPU also provides cpsr and gic mechanisms, but the application scenarios are different.

@hujun260 @xiaoxiang781216 Could we remove the word "bad" from the commit message? I don't think this is a bad design, right? These are two interrupt masking mechanisms provided by the CPU. Similar to cortex-a/r, the CPU also provides cpsr and gic mechanisms, but the application scenarios are different.

ok

armv6-m is still broken (tested with stm32g0 and timer example)

Sorry, I missed this PR before it was merged, but this PR breaks High Priority, Zero Latency Interrupts!
See the help text for ARMV7M_USEBASEPRI, which was removed in this PR:
config ARMV7M_USEBASEPRI
	bool "Use BASEPRI Register"
	default ARCH_HIPRI_INTERRUPT
	depends on ARCH_CORTEXM3 || ARCH_CORTEXM4 || ARCH_CORTEXM7
	---help---
		Use the BASEPRI register to enable and disable interrupts. By
		default, the PRIMASK register is used for this purpose. This
		usually results in hardfaults when supervisor calls are made.
		Though, these hardfaults are properly handled by the RTOS, the
		hardfaults can confuse some debuggers. With the BASEPRI
		register, these hardfaults, will be avoided. For more details see
		https://cwiki.apache.org/confluence/display/NUTTX/ARMv7-M+Hardfaults%2C+SVCALL%2C+and+Debuggers
		WARNING:  If CONFIG_ARCH_HIPRI_INTERRUPT is selected, then you
		MUST select CONFIG_ARMV7M_USEBASEPRI.  The Kconfig dependencies
		here will permit to select an invalid configuration because it
		cannot enforce that requirement.  If you create this invalid
		configuration, you will encounter some problems that may be
		very difficult to debug.

Also see https://nuttx.apache.org/docs/latest/guides/zerolatencyinterrupts.html
Important note: If this feature is removed from NuttX, then NuttX is completely useless to me and my employer! We depend on the Zero Latency Interrupts for critical parts of our firmware!

Please see Issue #15100

What are the consequences of this change? Does it have any disadvantages compared to PRIMASK? This is not a trivial change, so it's worth discuss it more as we basically force users to use BASEPRI here.

@raiden00pl the consequences of removing CONFIG_ARMV7M_USEBASEPRI is that high priority zero latency interrupts cannot work anymore. Unfortunately I think several PRs will need to be reverted. It seems the issue starts with PR-14881 which attempts to optimize storing
"regs" in g_current_regs and instead utilize (*running_task)->xcp.regs for storage, but unfortunately it seems this leads to hardfault regression; unfortunately, if the Zero Latency Interrupts are broken, I cannot use NuttX anymore. It is a complete showstopper. I recommend to revert the PRs that led to this issue. I have filed a bug #15100 to track this issue.

Important note: If this feature is removed from NuttX, then NuttX is completely useless to me and my employer! We depend on the Zero Latency Interrupts for critical parts of our firmware!

We haven't removed this feature; we've just set it to be enabled by default.

Important note: If this feature is removed from NuttX, then NuttX is completely useless to me and my employer! We depend on the Zero Latency Interrupts for critical parts of our firmware!

We haven't removed this feature; we've just set it to be enabled by default.

Thank you for clarifying. I misunderstood the changes earlier.


Step 44 NRWD Building Registration Form accepts CSS with a missing semi-colon

Describe the Issue
the NRWD Building Registration Form curriculum step 44 accepts a solution that is missing a semi-colon.
The solution given to it is:
fieldset{border:0;padding-left:0; padding-right:0; padding-top:2rem; padding-bottom:2rem}

When I put this code in to try it, i was expecting it to fail as it had a missing semi-colon at the end of the last style however, it passed the test and I was allowed to proceed to the next step.
Link to forum question for ref: https://forum.freecodecamp.org/t/new-responsive-web-design-building-registration-form-step-44/557880
Affected Page
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-html-forms-by-building-a-registration-form/step-44
Your code
fieldset{
  border:0;
  padding-left:0;
  padding-right:0;
  padding-top:2rem;
  padding-bottom:2rem
}

Expected behavior
I think the step should prevent submission if the answer is missing a semi-colon. (And give an appropriate hint of course)
Screenshots

System

Device: Laptop
OS: Windows 11
Browser: Chrome
Version: N/A

Additional context
No response

This is valid CSS. The final CSS declaration in a rule does not need the semi-colon: https://developer.mozilla.org/en-US/docs/Web/CSS/Syntax#css_declaration_blocks


Revert "feat: support iterables in file#save (#2202)"

Reverts googleapis/nodejs-storage#2203
BEGIN_COMMIT_OVERRIDE
feat: support iterables in file@save
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: support iterables in file@save
END_COMMIT_OVERRIDE


Autoform & check patterns

What would be a good pattern to use with Autoform and check inside my methods (with the method and method-update form types)?
I'm currently using:
check(modifier, {$set: Comments.simpleSchema(), $unset: Object})

Does that seem ok? If so, maybe we could add this to the docs to make it easier for people to check their methods (they're open to a lot of subtle exploits otherwise).

Actually, it needs to accept cases where $set or $unset are empty. So more like:
check(modifier, Match.OneOf({$set: Posts.simpleSchema()}, {$unset: Object}, {$set: Posts.simpleSchema(), $unset: Object}))


Quick Pull Request: Profile.jsp was not updated in last Pull request

I was running the development server as a precaution before updating the chat app and I noticed that the profile.jsp was not updated to reflect the new Admin set from the previous pull request.
This is a small request meant to finalize the changes Gauri brought forth in the last request.

Hey, thanks for doing that. Did you not want the link for admin on the about page? I figured we did want it there.


KeyError in set_power

With regards to the set_power function: This actually results in an error for me:

And then the Error Message (KeyError)

Am I doing something wrong here? Thanks again for your help!
Originally posted by @frederikbeekman in https://github.com/kodebach/hacs-idm-heatpump/discussions/144#discussioncomment-10793851

I have no solution, but that is what is working for me. The snippet is from my automatisation.
data:   acknowledge_risk: true   target: sensor.idm_ipump_a3_11_aktueller_pv_uberschuss   value: >-     {{ -1 * ((states('sensor.kaco_power_now') | float) -     states('sensor.haus_leistung') | float) / 1000 | round(3) }} enabled: true alias: Überschuss action: idm_heatpump.set_power


Fix check claim isNull.

If claim contains JSON object, isNull validation return false.

Let me rephrase the issue: When a Claim is constructed from a JSON Object, isNull is returning true when it should return false.


Clicking on accordion to open/close it is clunky

When clicking on an accordion here, there is a small delay between click and the opening/closing of it. https://react-science.pages.dev/stories/?path=/story/components-accordion--fixed
The problem doesn't happen when clicking on delegated toggle buttons like https://react-science.pages.dev/stories/?path=/story/components-accordion--with-toggle

Yeah, this is a known limitation. If you know a way to handle double click actions without triggering the click action twice, then we can fix this. Currently, we have this delay to wait for the second click. If it doesn't happen, then the click handler is called.

The same happens for example in the Windows explorer.

Thanks for the explanation.
Well, I'd say that having a double-click action that doesn't also trigger the single-click action at least once is an UX anti-pattern.
To be more precise, I mean in case you have to support double click, the single click action MUST be triggered before the double click action. Assuming this, if the consideration is triggering twice the click action : just listen onClick and differentiate the action to run using MouseClickEvent.detail.
To take Windows explorer as an example :

Click : select the folder
Double click : open the folder
But even when you double click on a folder, you can see that the folder style changed and was selected during the short time between the two clicks.

To be honest, I can't find any real life example of double click action that's not directly subsequent to single click action.
Have you a concrete example to not break if I PR something?

I checked a bit this component with stories and code.
click => open / close item.
double click => open item, close all others (+ side effect of selecting a word in title)
If we keep this approach but without delay to differentiate simple vs double click, the only "weird" behavior will be :
On an opened item, double click will close it and reopen it (and close all others).
In this case, one possibility is to keep the item close (ie: double click on an opened item will close all items).
But in this context click may move element (it's another UX anti-pattern, click on an item should not move item away from cursor).

Other things to note :
May this component was done before details html element implemented in all browser, I suggest rework it to use this native implementation and avoid dynamic height on items, so closing an item don't make it move below the cursor.

That said, we shouldn't worry too much about the design of the accordion component, because it's kind of a temporary solution for the panels.

I agree with @tpoisseau about the <details> thing but it's for another time (modal and dropdown could also be concerned)
Map example is legit yet maps are so clunky and loading at every moment that it doesn't feel so weird.
Accordion are just supposed to open so it currently does feel weird :/
I'm not really sure that making every single accordions clunky just for a feature that minor and could be worked around is a good solution.  Would it be a problem for you if I either :

remove it completetly
remove it and add a collapse all button on top of item
ctrl+click or alt+click to collapse all and expand the clicked on

When you say "temporary", how much temporary is it?` I need it in Pixelium so if a change is soon to be made it could be useful to make me aware of it.

Let's remove the useDoubleClick hook and use shift + click to collapse all but the clicked on.


Github Action to run pudl_archiver regularly

Expect this to fail without credentials, but at least it should run on push.
TODO:

[ ] give it real credentials - will need some sort of secret management - gcloud secrets manager? github?
[ ] change the triggers from "on push to this branch" to "on schedule" in addition to manual deploy

The reason we're doing this janky "push to this branch" thing is that manual triggers only work for actions in main.

@zschira this is ready for review, too - I think we're still seeing some funky zenodo issues but the actual GH action stuff is sorted.
Once we fix zenodo / get tests sorted / whatever, we can add tweaks here in terms of how we want to parallelize the builds.


Update C++ base image to SDK v0.2.2 dependencies

lgtm - (for completeness there is actually no release in cpp sdk, only a tag)

We will create a release as far as this version v0.2.2 contains Security Patches


chore: Limit parallelism on our GitHub action for version compatibility

Fixes #N/A
Description

Limit the number of suites that are run as part of our version compatibility testing. Prior to this change, the version compatibility workflow would create 3 suite (using 2 suites from our matrix job and upgrade suite). This PR will do two things: first reduce the number tests that are running at any given time from 18 suites at a given time to 12 suites, and reorder the test suites to reduce churn from similar operation correlating in one action.
Reducing the test suites from 18 -> 12: Reducing the test runs to have at most 12 test suite running at a time. This will be to reduce the amount of translate errors due to throttling or issues caused by high request volume inside the testing account.
Re-order test suites: As both the upgrade and integration suite run the same set of tests(also happen to be the most aggressive), re-ordering the matrix will result the test suites to run in a staggered from each other to reduce the churn impact to the account. (should have no impact to the normal integration testing)

How was this change tested?

As these changes are to the workflow, we will need to merge in the PR to test

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 79.281%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
91.67%

Totals

Change from base Build<PHONE_NUMBER>7:
-0.01%

Covered Lines:
5996

Relevant Lines:
7563

💛  - Coveralls


stuffs

cleanup
correct base call on constant properties

🤖 AutoRest automatic publish job 🤖
> will publish once PR gets merged

🤖 AutoRest automatic feature coverage report 🤖
feature set version 2.3.25
❌ General: 97%
15 out of 535 features are not covered by tests
additionalPropertiesInProperties, additionalPropertiesInPropertiesWithAPTypeString, additionalPropertiesTrue, additionalPropertiesTypeObject, additionalPropertiesTypeString, animalNotFoundError, expectedNoErrors, expectedPetHungryError, expectedPetSadError, getComplexPolymorphismComplicated, intError, linkNotFoundError, putComplexPolymorphismComplicated, putComplexPolymorphismNoDiscriminator, stringError
✔ Azure: 100%

🤖 AutoRest automatic feature coverage report 🤖
feature set version 2.3.25
❌ General: 97%
15 out of 535 features are not covered by tests
additionalPropertiesInProperties, additionalPropertiesInPropertiesWithAPTypeString, additionalPropertiesTrue, additionalPropertiesTypeObject, additionalPropertiesTypeString, animalNotFoundError, expectedNoErrors, expectedPetHungryError, expectedPetSadError, getComplexPolymorphismComplicated, intError, linkNotFoundError, putComplexPolymorphismComplicated, putComplexPolymorphismNoDiscriminator, stringError
✔ Azure: 100%


Mux test refactoring and two minor changes

Mostly changes to the test code.
Two real changes, in preparation for more significant mux changes.
Eliminate maximumMessageSize limit
It is not enforced on the receiving side because the mux does not preserve message boundaries. Enforcing it on the outbound side is pointless.
It is unnecessary since we can enforce size limits during message decoding, and the overall limit is the ingress queue limit.
Second change dropped, to be included in a later PR.
~Change mechanism for flushing on protocol termination~
~The mux ensures that when a protocol thread terminates normally (rather than via an exception) that it waits for outbound messages to be sent.~
~This allows for a clean shutdown for the remote peer and this is required in various tests.~
~The previous mechanism used a counter that was shared across all the mini-protocols in the mux bundle, and had to be incremented and decremented in vairious places.~
~The new mechanism is much simpler because it is not shared across all the mini-protocols. It is per-protocol. It simply waits for the outbound queue for that protocol to become empty. It should also be slightly faster since there are fewer STM transactions and allocations in the outbound data path.~

@karknu dropped the last patch.

bors r+


Remove superfluous updates from BasicDataSource when moving items

This PR removes superfluous updates on BasicDataSource's update handler when moving items. The cause of the extra update was in-place mutation of sections resulting in an update being sent for both the removal and insertion.

Good catch! 👍


Migrate to AndroidX

Will be interesting if we upgrade the lib to the new AndroidX due the dependencies.
Avoiding using the deprecated support libs.

#170


seek for results

Hi, It's nice to read your insightful work. When repeating your code, the MSE is a bit higher than your results in the thesis. For AIDS, the result is about 2.2(1.622 in your thesis). I wonder whether it's the problem caused by parameters. Could you please show me the best parameters in your model? Thank you very much!
What's more, I wonder your repeating results of SimGNN , which is 1.367 in the thesis. However, I can only repeat the results of around 2.5 and it's similar with the other coder's results. Thank you very much!

Thanks for your comments!
For the first question, I apologize for missing the correct hyper-parameter to reproduce the results. Cuz it's really long time ago and I can't recall that (I graduated and lost access to the server which I run the experiments with). To the best of my knowledge, hidden size for AIDS should be larger due to its heterogeneousness and multi-lable. You may try a larger hidden size and attn heads.
I FAILED to reproduce the results of SimGNN (it seems that few people did that according to the original repo's issues). I used the reproduction of H2MN to fair comparison, so some of the code in this repo comes from H2MN's.

Thanks for your quick reply and great guidance!


support URL?

This is irrelevant to the proposal about 4600 itself, but it's an idea related to the syntax from @fonsp originally, in ES6 style I think you can not only use a path but also a URL, this feature is available in quite a few languages. Since we have created this package, this is a good place to experiment with this feature at some point.

It does seems like a natural extension. I'm in favour of this.


Use shim.h in IBM-DTeam/swift-for-db2

It seems these flags are still needed, for example for packages that work with DB2 Driver, see - TodoList-DB2 compilation instructions. If these flags do not cause any problems when they are not needed, we can just add them to make build, for all the projects.
@rfdickerson @rolivieri @shmuelk your comments are welcome.

@vadimeisenbergibm Have you tried building the DB2 driver without those flags? Perhaps the DB2 instructions haven't been kept up to date?

@shmuelk Yes, I tried.
Linking ./.build/debug/Deploy
ld: library not found for -libmdb for architecture x86_64
<unknown>:0: error: link command failed with exit code 1 (use -v to see invocation)
<unknown>:0: error: build had 1 command failures

BTW, make test has the same problem and should be updated with the same flags as make build.

@shmuelk I have learned why CLibpq works with swift build without additional flags. It works thanks to pkgConfig argument in Package.swift:
pkgConfig: "libpq"

Using pkgConfig value, SPM uses pkg-config command to know how to compile and link the module:
$  pkg-config --cflags libpq
-I/usr/local/Cellar/postgresql/9.4.0/include
$ pkg-config --libs libpq
-L/usr/local/Cellar/postgresql/9.4.0/lib -lpq

pkg-config knows this information since during the installation of postgresql, the installation script probably writes file /usr/local/lib/pkgconfig/libpq.pc in /usr/local/lib/pkgconfig directory for pkg-config to read. No such entry is created during installation of db2 cli drivers.
So, we either have to change the installation of db2 cli driver to write a .pc entry in  /usr/local/lib/pkgconfig/, and expect the users of Makefile to use only system modules that create pkg-config entries, or to add -Xcc -I/usr/local/include -Xlinker -L/usr/local/lib to make build/test to relax this requirement.

Closing as irrelevant to Kitura. swift db2 team should write a pkg-config .pc entry in /usr/local/lib/pkgconfig/ and use pkgConfig parameter in Package.swift.


SPARK-LLAP-246: Updating README for branch-2.3-3.0

What changes were proposed in this pull request?
doc change

I understand the test failures are expected as Hive 3.1.0 has not yet been released.

@HyukjinKwon
Thanks for the feedback. Made those changes.


Get session data from EJS

Hi, maybe this is a stupid question but... what is the best way or the right to spend the session to the "layout" or something like that.
eg: User logs in, and I pass the data from it by session to show his name somewhere in the layout page, but on every page without getting getting it in all actions of controllers
thanks a lot

The req object is automatically injected into to the template. You just need to use req.session
Please note GitHub is for bugs and feature requests. You should use stack overflow or google groups for questions like this.
Thanks


You may want to add this to the README

To build for Swift 3.0
for the time being you need to add this to your Podfile
`pod 'QRCode', :git => "git@github.com:aschuch/QRCode.git", :branch => "swift3.0"`

I've just pushed the new version for Swift 3 to Cocoapods trunk.


libswiftXCTest.dylib   Reason: image not found

I am getting this wierd crash right after installing this as a pod and running the application
dyld: Library not loaded: @rpath/XCTest.framework/XCTest
Referenced from: /Users/colworx/Library/Developer/CoreSimulator/Devices/8F5D5AC5-3A58-4577-AAC1-BA1A170D728C/data/Containers/Bundle/Application/E1DE38E0-B483-4CD5-A6E8-2665EF17EEAB/squad.app/Frameworks/libswiftXCTest.dylib
Reason: image not found

Seems like you're installing this to the wrong (testing) target and don't have the XCTest framework linked properly in your project.
If you look at the podspec, you'll see it just adds one file to the project, which doesn't import XCTest


building docs instability

🐛 Bug
building docs is randomly failing
To Reproduce
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/matplotlib/sphinxext/plot_directive.py", line 552, in _run_code
looking for now-outdated files... none found
    exec(code, ns)
  File "<string>", line 7, in <module>
  File "/home/runner/work/torchmetrics/torchmetrics/src/torchmetrics/classification/group_fairness.py", line 325, in plot
    return self._plot(val, ax)
  File "/home/runner/work/torchmetrics/torchmetrics/src/torchmetrics/metric.py", line 681, in _plot
    fig, ax = plot_single_or_multi_val(
  File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/home/runner/work/torchmetrics/torchmetrics/src/torchmetrics/utilities/plot.py", line 117, in plot_single_or_multi_val
    val = {k: torch.stack([val[i][k] for i in range(n_steps)]) for k in val[0]}  # type: ignore
  File "/home/runner/work/torchmetrics/torchmetrics/src/torchmetrics/utilities/plot.py", line 117, in <dictcomp>
    val = {k: torch.stack([val[i][k] for i in range(n_steps)]) for k in val[0]}  # type: ignore
  File "/home/runner/work/torchmetrics/torchmetrics/src/torchmetrics/utilities/plot.py", line 117, in <listcomp>
    val = {k: torch.stack([val[i][k] for i in range(n_steps)]) for k in val[0]}  # type: ignore
KeyError: 'EO_1_0'
/home/runner/work/torchmetrics/torchmetrics/src/torchmetrics/clustering/dunn_index.py:docstring of torchmetrics.clustering.dunn_index.DunnIndex.plot:19: WARNING: Exception occurred in plotting dunn_index-2
 from /home/runner/work/torchmetrics/torchmetrics/docs/source/clustering/dunn_index.rst:
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/matplotlib/sphinxext/plot_directive.py", line 552, in _run_code
    exec(code, ns)
  File "<string>", line 6, in <module>
  File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/runner/work/torchmetrics/torchmetrics/src/torchmetrics/metric.py", line 310, in forward
    self._forward_cache = self._forward_full_state_update(*args, **kwargs)
  File "/home/runner/work/torchmetrics/torchmetrics/src/torchmetrics/metric.py", line 342, in _forward_full_state_update
    batch_val = self.compute()
  File "/home/runner/work/torchmetrics/torchmetrics/src/torchmetrics/metric.py", line 633, in wrapped_func
    value = _squeeze_if_scalar(compute(*args, **kwargs))
  File "/home/runner/work/torchmetrics/torchmetrics/src/torchmetrics/clustering/dunn_index.py", line 86, in compute
    return dunn_index(dim_zero_cat(self.data), dim_zero_cat(self.labels), self.p)
  File "/home/runner/work/torchmetrics/torchmetrics/src/torchmetrics/functional/clustering/dunn_index.py", line 82, in dunn_index
    pairwise_distance, max_distance = _dunn_index_update(data, labels, p)
  File "/home/runner/work/torchmetrics/torchmetrics/src/torchmetrics/functional/clustering/dunn_index.py", line 39, in _dunn_index_update
    torch.stack([a - b for a, b in combinations(centroids, 2)], dim=0), ord=p, dim=1

Expected behavior

Environment

https://github.com/Lightning-AI/torchmetrics/actions/runs/11269271231/attempts/1

Additional context

@Borda is it one or two failures?

@Borda is it one or two failures?

seem to be two different:

plot with group_fairness
dunn_index

@Borda fix for the group_fairness is now included in PR #2775, still need to figure out why the dunn index is failing

still need to figure out why the dunn index is failing

I guess it is due to randomness and the cardinality of the example?

still need to figure out why the dunn index is failing

I guess it is due to randomness and the cardinality of the example?

But the problem is that there is no randomness in that test, both preds and target are deterministic tensors. So it is very weird to me that it fails randomly


Can I transfer the conversation started by directline to a web chat channel ?

I am trying to initiate a bot conversation through directline channel, but I need to follow rest of the conversation through webchat channel. Is there any possible way that I can resume my conversation in web chat using the conversation Id generated ?

Hi @kanwal019, this is possible although it requires you to host the web chat control on your own. To transfer the conversation:

Generate a random ID within your Direct Line conversation. Associate this ID with the current conversation.
Generate a link to the page hosting your Web Chat control, and pass that ID into the page
Inside the page, pass the ID into the Web Chat control
Inside the bot, look up the Direct Line conversation, and use this to restore your conversation state
You should delete the association between the ID and the conversation state to prevent replay attacks.

We're looking at automating this in the future but we don't yet have concrete plans or a timeline for doing this.

Closing as we've answered the question. Please at-mention or file a new issue if you'd like to discuss further.


Make editor inspector follow focus

No idea if this could have any negative implications. :thinking:
Fixes #78954 (EditorSettingsDialog uses SectionedInspector which uses EditorInspector).

Thanks!


Add cleanup-on-success option to repackager

Adds a --clean-inputs option which removes the original input dataset after successful recompress. (needed to avoid doubling the disk usage)
Improves logging. Switched it to structlog.
Add a -f option to read a list of inputs from a file (one per line)
Various test improvements for edge cases

Coverage decreased (-0.02%) to 89.591% when pulling d1b5504636bd1f851952bcea11c9359ed1b3993e on jeremyh:develop into 791677d9237c2be2ca9a27099f3eda801bb59e07 on GeoscienceAustralia:develop.


Update main.rs

TLDR: Jhataro haneko, I don't even know r in Rust language :D
Honestly, this was my first time seeing a rust code. Just googled stuff and copy pasted code. I don't even know if works or not.
hehe

oops build failed
am closing this


SOLR-15591 / Avoid needless catch by checking condition

https://issues.apache.org/jira/browse/SOLR-15591

Description
Remove unnecessary catch in ExternalPaths.
Solution
Instead of catching the exception and setting the next possible path, instead we check for the condition that triggers the NPE and act accordingly.
Tests
Per the issue description, the issue was that when setting the test to hit a breakpoint on exceptions. Sometimes the debugger would stop on ExternalPaths, in order to test the change. The debugger shouldn't stop on this class.
Checklist
Please review the following and check all that apply:

[X] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[ ] I have created a Jira issue and added the issue ID to my pull request title.
[X] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[ ] I have developed this patch against the main branch.
[X] I have run ./gradlew check.
[ ] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

@charlygrappa wiuld you be interested in updating this and responding to comments and then I would love to merge it.

@charlygrappa thanks for this.   I put your github id into the CHANGES.txt, however happy to update it to however you would like to be credited!


initialization of variable

if in_uri is called and response_mode is not initialized an exception is raised (happen if used with e.g. Flask_OAuthlib)

Thanks. Feel free to add yourself to the AUTHORS file.

Thanks @MitterdorferMathias :+1: