HDFS-17152. Fix the documentation of count command in FileSystemShell.md.

Description of PR
Please see HDFS-17152.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

-1 :x:
mvninstall
44m 28s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
mvnsite
1m 33s

trunk passed

+1 :green_heart:
shadedclient
84m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 57s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
1m 19s

the patch passed

+1 :green_heart:
shadedclient
39m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

130m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5939/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5939

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint

uname
Linux 94c4904c66c7 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 04b9774b79fb3d53269521e08d78ef4f82baccae

Max. process+thread count
586 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5939/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 54s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
shadedclient
87m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
1m 18s

the patch passed

+1 :green_heart:
shadedclient
38m 41s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

132m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5939/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5939

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint

uname
Linux db137d81e4ef 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 18922ee71c9accbe6ee294fb78df7b5391a12888

Max. process+thread count
533 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5939/2/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

LGTM.

@slfan1989 Hi, sir. Could we push this simple modification forward when you have free time? Thanks a lot~


dashboard: temp fix for RMF api breakage

Signed-off-by: Teo Koon Peng<EMAIL_ADDRESS>What's new

Self-checks

[ ] I'm familiar with and follow this Typescript guideline
[ ] I added unit-tests for new components
[ ] I tried testing edge cases
[ ] I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

e2e tests broke because of recent change in building map msgs, referencing https://github.com/open-rmf/rmf/issues/11


Aruba - CX8100 - Results

Ensure you are utilizing the latest version of the tool from the release page
Please fill in the following:

Organization (As you want it to appear on the website): Aruba

Device series: CX 8100

Speeds supported (GbE): 10 GbE

Minimum firmware version requirement: AOS CX version 10.12.0006 or later

Link to device datasheet:  https://www.arubanetworks.com/resource/cx-8100-series-switch-data-sheet/

After the tool execution successfully, there will be five files:
PDF File
JSON File
YAML File
Log File
PACP file
Please attach these here and submit for review!
8100_10_12_0006.zip

@bkablawi any update on this issue?

@bkablawi any update on this issue?

Hi Luis, we reviewed these results this week and I will be sending out an approval email to the Aruba team first thing on Monday. Thanks and have a great weekend!


bad clipping on IE8

We're experiencing some bad clipping on IE8.

Marked abandoned as we don't plan to support IE8 going forward.


Allow CSVLocalDataSet and CSVDataSet to accept file-like object

Description
I got UnicodeDecodeError when I was trying to parse a CSV file (from an external data source) where there are columns uses inconsistent character encodings.  I tried various encodings (see below) and got UnicodeDecodeError no matter what encoding I passed in.
Rather than trying to get the data provider to use a consistent encoding (It's an external data source), I would just like to read that column and discard (swallow) the bad chars.
Context
The CSV file I was trying is showed as "Windows-1258" as I open it in Notepad++, the text is mostly plain ASCII, except a few the "bad chars".
I tried with "ascii", "utf-8", "utf-8-sig", "latin1", "windows-1258", "ISO-8859-1", etc. (basically whatever encoding I can get from SO answers for similar questions), but none of them works for me. I don't think any single encoding works here. I got UnicodeDecodeError no matter what encoding I passed in.
It seems it was edited with a non-UTF8 editor (probably in Excel) and contains some character that's not in UTF8.
As I debuged, a bad line that cause the error is something looks like this:
40|Malaysia|"Clorox\xe2\x80\x9d (home cleaning products)|NA
I believe the \xe2\x80\x9d is the "bad char" that cause the error. It seems like it's a special double quote, which I guess is supposed to match the leading ASCII double quote but however the person edit it might be using a special input method.
I believe this kind of mixed-encoding-text-file situation is quite common in real world. Similar "bad character" examples (and possible solutions) are dicussed here and here.
Possible Implementation
The problem is, although Pandas allows to specify encoding, it does not allow to ignore errors not to automatically replace the offending bytes. However, even if Pandas has no provision for a special error processing, but Python open function has (assuming Python3), and Pandas.read_csv does accept a file like object.
For example, this will help me ignore the bad chars:
with open(filepath, encoding='utf8', errors='ignore') as fd:
    pd.read_csv(fd, ...)

However, the current CSVLocalDataSet calls pandas.read_csv BUT assume the filepath is only a path string (even pandas.read_csv does accept file-like object).
A possible implementation might be allow the filepath parameter be a file-like object.
Possible Alternatives
(Optional) Describe any alternative solutions or features you've considered.

Hey @yxw! Thanks for raising this.
I think this is actually fixed with the new style datasets. If you use pandas.CSVDataSet we actually pass the file description from fsspec into pandas.read_csv and you can specify the encoding used in the fsspec.open call (which, on local file systems is forwarded to the default open`` in the fs_args` argument.
So you would do something like:
my_dataset:
  type: pandas.CSVDataSet
  fs_args:
    fs_open_args:
      encoding: 'utf-8'

which would do something like:
with self._fs.open("filepath", encoding='utf-8') as f:
  pandas.read_csv(f)

These new kedro.extras.datasets were made available in kedro 0.15.6 I believe, and are now the only option in Kedro 0.16 onwards. Let me know if this is a suitable fix!

Hi @yxw , any luck follow @mzjp2 's suggestion above? Extra args like encoding, mode could fix the issue you're facing.

Thanks @mzjp2 for the suggestion.  I did tried and the UnicodeDecodeError still exists.
Here is my test case to reproduce it:
import os
import tempfile
import pytest
from kedro.io import (
    DataCatalog,
)

from kedro.extras.datasets.pandas import CSVDataSet

def test_load_ds_with_pandas_csvdataset():
    encoding = 'utf8'
    temp = tempfile.NamedTemporaryFile(mode="w", encoding=encoding, delete=False)

    try:
        buffer = """ID|Name|Products
C00001232DA|Clorox (M) Sdn Bhd|"Clorox” (home cleaning products)

        """
        temp.write(buffer)
        temp.close()

        io = DataCatalog(
            {
                "test_ds": CSVDataSet(temp.name,
                            load_args=dict(
                                sep='|',
                                encoding=encoding,
                                skip_blank_lines=True,
                                error_bad_lines=False,
                                warn_bad_lines=True,
                                quotechar=None,
                                quoting=3)),
            }
        )

        bs_data = io.load("test_ds")
        assert len(bs_data.index) == 1
    finally:
        os.remove(temp.name)

Do notice the different double quote char around Clorox: the ending double quote is a "special" double quote (\xe2\x80\x9d) which break the decoding I think. The error I got is still
UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 58: character maps to <undefined>.
I believe the real problem is about mixed encoding (e.g. in a multiple language organization, people may (accidentally) switch to a special input method of their language when typing), which I think pandas.read_csv itself doesn't have a way to process (or swallow) encoding errors. There is similar discussion about this here
What I do to workaround it is something like this:
    def _load(self) -> pd.DataFrame:
        load_path = Path(self._get_load_path())
        encoding = self._load_args.get("encoding", "utf8")
        self._load_args["encoding"] = None
        with load_path.open(encoding=encoding, errors="ignore") as buffer:
            return pd.read_csv(buffer, **self._load_args)

Basically in my case I need the errors='ignore' to "swallow" the unexpected "bad" char.
Do you know if there is a way to pass in the "errors" parameter in catalog.yml to CSVDataSet ?

Hi @yxw, thank you so much for that snippet -- it makes it so much easier!
That said, I don't seem to get the error on my MacOS laptop (on Kedro 0.16.1 or 0.15.9) - so it might be a windows specific thing? In any case, as long as you're on Kedro 0.16.1, this should (theoretically) work:
import os
import tempfile
from kedro.io import DataCatalog

from kedro.extras.datasets.pandas import CSVDataSet

def test_load_ds_with_pandas_csvdataset():
    encoding = "utf8"
    temp = tempfile.NamedTemporaryFile(mode="w", encoding=encoding, delete=False)

    try:
        buffer = """ID|Name|Products
C00001232DA|Clorox (M) Sdn Bhd|"Clorox” (home cleaning products)

        """
        temp.write(buffer)
        temp.close()

        io = DataCatalog(
            {
                "test_ds": CSVDataSet(
                    temp.name,
                    load_args=dict(
                        sep="|",
                        skip_blank_lines=True,
                        error_bad_lines=False,
                        warn_bad_lines=True,
                        quotechar=None,
                        quoting=3,
                    ),
                    fs_args=dict(
                        open_args_load=dict(encoding=encoding, errors="ignore")
                    ),
                )
            }
        )

        bs_data = io.load("test_ds")
        assert len(bs_data.index) == 1
    finally:
        os.remove(temp.name)

Does that help?

Hi @mzjp2 , thanks the tips on the fs_args. I didn't realize that, this is my first Kedro project :).
However, I still have the same UnicodeDecodeError. After my kedro version is 0.15.9 and I'm running on Windows 10. Since you don't have the same error, it might be a Windows specific thing.

Hi @mzjp2 , thanks the tips on the fs_args. I didn't realize that, this is my first Kedro project :).
However, I still have the same UnicodeDecodeError. After my kedro version is 0.15.9 and I'm running on Windows 10. Since you don't have the same error, it might be a Windows specific thing.

The fs_args will only work on 0.16 onwards :(

Oh, I just realized there is two releases just about a weeks ago!  I verified releases two weeks ago I thought I have the latest version.
And yes, that's probably the reason. I'll upgrade the version and verify again.

Oh, I just realized there is two releases just about a weeks ago! I verified releases two weeks ago I thought I have the latest version..
And yes, that's probably the reason. I'll upgrade the version and verify again.

Awesome. Let me know how you get on :)

Hi @mzjp2 , after migrating my project from 0.15.9 to 0.16.1 (it took some effort), I manage to pass my tests with the new "fs_args.open_args_load" parameters as shown in your example code above.
Thank you so much!
This issue can be closed.

Perfect. Glad to hear. We're trying to improve our release process so that bugfixes aren't packaged with breaking changes and you can benefit from bug fixes/new features without migrating your project. I'll go ahead and close this now :)


Update general.md

It should be clearly stated that Contributor role allows you to create a new Entra tenant.

@rolyon
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @azarboon
Thanks for your contribution. Whether a non-admin can create a tenant depends on the Restrict non-admin users from creating tenants setting in User settings. If this setting is set to Yes, I think you must be assigned the Tenant Creator or Global Administrator role to create a tenant.
thanks

Hi @azarboon
Thanks for contributing to the docs. We are going to close this pull request since creating a tenant depends on your user settings.
Let us know if you have additional feedback.
thanks

#please-close


fix: hide idle metric and max to auto for cpu_domain_busy

Fixing in this panel:

Changes max from 100 to auto as this panel can go beyond 100%.
metric idle show as hidden(grayed) as default.

Looks good. As we discussed, Let's check cpu percentage used in other dashboards and see if we need to make any changes there.

Checked the other dashboards and usage of cpu_domain_busy and cpu_busy metrics, So far wherever we are using them, we are showing within 100% as expected.


Hexadecimal (tryhexadecimal.com)

Domain: tryhexadecimal.com
GTMetrix (performed on Dec 28th): https://gtmetrix.com/reports/tryhexadecimal.com/G7aTgkOQ/

Nice service!

Nice service!


feature form to collect ratings

closes #63

Codecov Report
Base: 73.25% // Head: 72.89% // Decreases project coverage by -0.36% :warning:

Coverage data is based on head (52fbcaa) compared to base (9dc2caf).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   73.25%   72.89%   -0.37%
==========================================
  Files          12       12
  Lines         602      605       +3
==========================================
  Hits          441      441
- Misses        161      164       +3

Flag
Coverage Δ

unittests
72.89% <0.00%> (-0.37%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/main.py
0.00% <0.00%> (ø)

utils/api/twitter.py
81.63% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Mention preferred package name in READ.md

My proposal is to mention a preferred package name for the code.
I now used the package name /CC4A/MAIN.

What benefit would such a preferred name have? Personally I use /CC4A/CODE_PAL but what difference does that make to your /CC4A/MAIN or whatever anyone else might pick?

I think it helps people to choose a package name.
It is also helps for consistency reasons so that on every system the package name is the same.
And it helps that people choose an name starting with /CC4A/ and not with Z or Y.

Agree. Of course, abapGit lets you pick any package, but it's nice if a project has a consistent home.
I use "Recommended SAP package: ..." in my READMEs. Example


wip: new: runtime tracepoints management

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap-engine-bpf
/area libscap-engine-kmod
/area libscap-engine-modern-bpf
/area libscap
/area libsinsp

Does this PR require a change in the driver versions?
/version driver-API-version-major
new ioctl introduced in kmod.
What this PR does / why we need it:
This PR completes part of #521  allowing even tracepoints to be runtime modified, just like we allow it for ppm_sc.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

This PR was branched from #521.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/reopen

@FedeDP: Failed to re-open PR: state cannot be changed. The cleanup/unify_simpleconsumer_simpledriver branch has been deleted.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Corruption issue when performing neu create or neu update with Node 19.8.1

The unzipper library causes extracted files to get corrupt in the latest Node.js v19.8.1 on Windows 10 (worked with Node v18, have not tested other versions)
Also created an issue in unzipper, although library appears to be abandoned
May wish to switch to decompress library as that appears to be working

put issue in wrong repository


Fix dropdown icon misalignement when using fomantic icon

There are still many dropdowns using fomantic icon. For example: new issue with issue template.
Avoid polluting the fomantic styles.
Before:

After:

How many remaining cases of fomantic dropdown arrow are there? We could also just replace them with SVG, which will eventually allow the removal of FontAwesome.

How many remaining cases of fomantic dropdown arrow are there? We could also just replace them with SVG, which will eventually allow the removal of FontAwesome.

I guess not only a few (but not too many). And I see new code still uses that fomantic icon.

And one more thing, the dynamically generated "labels" for multiple selection, are constructed by Fomantic UI template, they all still uses "`
See #23346 for example.

I think new code should not use <i> icons anymore, only SVG. Fomatic CSS usually matches for .icon so if you add that class to the SVG, the styling should work.
I will check what's left to get rid of FontAwesome.

There are still new PRs like #23522, because people just like to copy the Fomantic UI examples, and following the examples is the best practice, to avoid misusing Fomantic UI.
Before get rid of <i delete icon>, at least, the dynamically generated dropdown selection labels should have a clear solution first.

Codecov Report

Merging #23558 (3326209) into main (f521e88) will increase coverage by 0.00%.
The diff coverage is 44.34%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff            @@
##             main   #23558    +/-   ##
========================================
  Coverage   47.14%   47.15%
========================================
  Files        1149     1154     +5
  Lines      151446   152264   +818
========================================
+ Hits        71397    71796   +399
- Misses      71611    72000   +389
- Partials     8438     8468    +30

Impacted Files
Coverage Δ

cmd/dump.go
0.67% <0.00%> (ø)

cmd/web.go
0.00% <0.00%> (ø)

models/actions/run.go
1.64% <0.00%> (-0.08%)
:arrow_down:

models/packages/package.go
45.45% <0.00%> (-1.13%)
:arrow_down:

models/user/search.go
77.50% <0.00%> (-6.29%)
:arrow_down:

modules/actions/github.go
0.00% <0.00%> (ø)

modules/actions/workflows.go
0.00% <0.00%> (ø)

modules/doctor/storage.go
31.93% <0.00%> (ø)

modules/setting/git.go
45.45% <ø> (ø)

modules/storage/minio.go
1.51% <0.00%> (-0.06%)
:arrow_down:

... and 50 more

... and 16 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wxiaoguang backport this?


Weeb Central "no pages found" when trying to view or download any manga

Source information
Weeb Central
Source language
English
Steps to reproduce

Search for any manga in weeb central extension
Enter any manga to view all available chapters
Tap on any chapter or download button to start reading manga

Expected behavior
The chapter should open or download
Actual behavior
No pages found error appear after brief loading animation
Mihon/Tachiyomi version
0.17.0
Android version
Android 14
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Add a :+1: reaction to issues you find important.

Are you using Weeb Central 1.4.3? It was recently updated to address this exact issue.
Since I can't reproduce this issue with 'any manga' I'll be closing the issue. Leave a comment with a more specific example that can be tested against if you're still facing issues after updating.

Yes, i am using Weeb Central 1.4.3
I tested with multiple titles, but you can try specifically with Beelzebub
https://weebcentral.com/series/01J76XY7EEHWD3S0TQ5T4KE8Y1/Beelzebub
I am unable to view or download chapters inapp

I can also confirm that Weeb Central 1.4.3 does not work as the issue still persists @vetleledaal

I still can't reproduce the issue. Tested with Beelzebub chapter 0, 1, and 240, where all the pages load.
Please try:

Refreshing the manga entry
Migrating the manga entry from Weeb Central to Weeb Central
Force close the app and re-refresh the manga entry

If it is still broken I would suggest continuing troubleshooting on #repo-support in Discord. GitHub is not well suited for back-and-forth issues like this.

@vetleledaal
Have tried the above and no manga entrys work. All produce same issue. Tried the current 1.4.3 apk.


Block until automate ruby method teardown finishes timer thread, add test

For #8399
See commit 2 for the actual test, commit 1 is whitespace only so I can add a new context.
Note:  commit 2 changes the behavior so that the teardown_drb_for_ruby_method doesn't exit until the timer thread is killed/dead/stopped.  Without this change, testing this method was difficult since the thread could still be alive/sleeping.  The nice side effect is that we now guarantee that the timer thread is dead when exiting this method.
@mkanoor What do you think of this test?

👍

@mkanoor it failed 😭
Timing is so hard... note, in the time it takes to print the test failure and showing the expected vs. actual differences, the same thread went from sleep to dead.  I'll have to do something to make sure it's a reliable test.  I don't want to do a sleep unless we have to.
  1) MiqAeEngine::MiqAeMethod setup/teardown drb_for_ruby_method clears DRb threads
     Failure/Error: expect(Thread.list.select(&:alive?)).to eq threads_before

       expected: [#<Thread:0x0000000069b310 run>]
            got: [#<Thread:0x0000000069b310 run>, #<Thread:0x00000048142d30@/home/travis/.rvm/rubies/ruby-2.2.4/lib/ruby/2.2.0/drb/timeridconv.rb:74 sleep>]

       (compared using ==)

       Diff:
       @@ -1,2 +1,3 @@
       -[#<Thread:0x0000000069b310 run>]
       +[#<Thread:0x0000000069b310 run>,
       + #<Thread:0x00000048142d30@/home/travis/.rvm/rubies/ruby-2.2.4/lib/ruby/2.2.0/drb/timeridconv.rb:74 dead>]

@mkanoor I fixed the tests by ensuring we block until the thread exits before leaving the teardown_drb_for_ruby_method.  What do you think?  See updated description and commit 2.

@jrafanie
Can't we just check the threads before a method starts and after a method ends. Instead of using the timer logic.

@jrafanie
Can't we just check the threads before a method starts and after a method ends. Instead of using the timer logic.

@mkanoor I think that's what the test is currently doing.  The problem was the thread was not always dead after teardown_drb_for_ruby_method ends.  What timer logic do you mean?

@jrafanie
I meant waiting till the thread is killed.

@jrafanie
I meant waiting till the thread is killed.

I don't know what you mean... Can you write some pseudocode?
I don't like blocking until the thread is dead but I'm not sure how else to guarantee the thread is gone before the method ends.

@mkanoor Can you explain what you mean?  What would you suggest?

@jrafanie
I was confused. I am ok with the changes

@mkanoor can you review this commit?  https://github.com/ruby/ruby/commit/a9e8f9fae95ee9907119d2112a93453a6b90a51e
I'll open a PR to ruby to see if they'll accept it.

@mkanoor Sorry, this one:  https://github.com/ruby/ruby/commit/0a8e0416fb28a94aa004e6828e9eae5c9a9cd901

LGTM, so merging on the +1 from @mkanoor

@jrafanie Should this be darga yes or no?

@jrafanie Should this be darga yes or no?

Yes, thanks.  I just set it.  The prior version didn't wait for the thread to exit before it moved on so this version should be correct.


Fix ubo declaration creation and IBAN BankAccountDeserializer

Added similar functionality as in mangopay-php-sdk.

Hi.
Is this Pull Request ever gonna get merged ?

Hello @CornelZ, let us check we will come back to you ASAP


Send dynamically requested loa to SFO

This issue is imported from pivotal - Originaly created at Feb 16, 2021 by Thijs Kinkhorst
When an SP has dynamically requested a loa and this request is recognised as a stepup request and deemed valid (see earlier stories), the requested loa is sent to the SFO endpoint in the same way as loa's configured in manage, to ask the user to prove this loa.

note to self SFO = second factor only (Koen Cornelis - Mar 24, 2021)


Pivot Grid

Summary
Pivot grid which will show data in grid by specific key
Use case
I have relations  one to many on my database. Department has many work positions.
I want avoid table like this
Department  WorkPositionName       Position Salary
IT                   System Enginner           1000
IT                   System Administrator    500
IT                   System Arhitect             2500
I want avoid duplicate Department in this case IT.
https://js.devexpress.com/Demos/WidgetsGallery/Demo/PivotGrid/SimpleArray/Angular/Light/

@markofranjic you can achieve 1st column behavior with expandable rows. Sadly, no stacked columns yet, but as far as I understand, you need this just for rows, right?

We recommend against this pattern due to the lack of control over the whitespace and how it affects cell traversal, screen readers, and the usability of the pane as rows/columns are expanded and nested.


Move actions to notification

As title.

Codecov Report

Merging #8785 into master will increase coverage by <.01%.
The diff coverage is 40.24%.

@@            Coverage Diff             @@
##           master    #8785      +/-   ##
==========================================
+ Coverage   41.34%   41.34%   +<.01%
==========================================
  Files         541      542       +1
  Lines       69503    69554      +51
==========================================
+ Hits        28738    28760      +22
- Misses      37083    37102      +19
- Partials     3682     3692      +10

Impacted Files
Coverage Δ

services/issue/issue.go
23.68% <ø> (-6.21%)
:arrow_down:

services/pull/pull.go
33.75% <100%> (-6.05%)
:arrow_down:

modules/notification/notification.go
74.73% <100%> (+0.26%)
:arrow_up:

modules/notification/webhook/webhook.go
39.14% <25.8%> (-1.07%)
:arrow_down:

modules/notification/action/action.go
45.83% <45.83%> (ø)

modules/notification/base/null.go
63.63% <0%> (ø)
:arrow_up:

routers/repo/view.go
38.59% <0%> (+0.87%)
:arrow_up:

models/repo_list.go
74.27% <0%> (+0.97%)
:arrow_up:

models/unit.go
67.56% <0%> (+5.4%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232340f...1037573. Read the comment docs.


Catalog app will be removed immediately after I create a catalog app

Rancher versions:
rancher/server or rancher/rancher: master-8/28
rancher/agent or rancher/rancher-agent: master
Steps to Reproduce:

Create a Catalog app. I am using my charts repo https://github.com/orangedeng/charts and deploying prometheus-operator designed by myself.
I saw the following logs in rancher

get in create prometheus-operator ## This is the log I print to debug for myself. print it when get in create func of app life cycle handler
[main] 2018/08/28 01:12:34 Starting Tiller v2.9.1-rancher1 (tls=false)
[main] 2018/08/28 01:12:34 GRPC listening on :42228
[main] 2018/08/28 01:12:34 Probes listening on :35697
[main] 2018/08/28 01:12:34 Storage driver is ConfigMap
[main] 2018/08/28 01:12:34 Max history per release is 0
[tiller] 2018/08/28 01:12:34 preparing install for prometheus-operator
[storage] 2018/08/28 01:12:34 getting release history for "prometheus-operator"
[tiller] 2018/08/28 01:12:34 rendering prometheus-operator chart using values
2018/08/28 01:12:34 info: manifest "prometheus-operator/charts/prometheus/templates/rules.yaml" is empty. Skipping.
2018/08/28 01:12:34 info: manifest "prometheus-operator/charts/exporter-kubernetes/templates/kubernetes.rules.yaml" is empty. Skipping.
2018/08/28 01:12:34 info: manifest "prometheus-operator/charts/prometheus/templates/prometheus.rules.yaml" is empty. Skipping.
2018/08/28 01:12:34 info: manifest "prometheus-operator/charts/alertmanager/templates/alertmanager.rules.yaml" is empty. Skipping.
2018/08/28 01:12:34 info: manifest "prometheus-operator/charts/exporter-node/templates/node.rules.yaml" is empty. Skipping.
2018/08/28 01:12:34 info: manifest "prometheus-operator/charts/exporter-kubelets/templates/kubelet.rules.yaml" is empty. Skipping.
2018/08/28 01:12:34 info: manifest "prometheus-operator/charts/alertmanager/templates/ingress.yaml" is empty. Skipping.
2018/08/28 01:12:34 info: manifest "prometheus-operator/charts/prometheus/templates/ingress.yaml" is empty. Skipping.
2018/08/28 01:12:34 info: manifest "prometheus-operator/charts/grafana/templates/ingress.yaml" is empty. Skipping.
2018/08/28 01:12:34 info: manifest "prometheus-operator/charts/grafana/templates/pvc.yaml" is empty. Skipping.
2018/08/28 01:12:34 info: manifest "prometheus-operator/charts/exporter-kube-state/templates/kube-state-metrics.rules.yaml" is empty. Skipping.
2018/08/28 01:12:34 info: manifest "prometheus-operator/charts/prometheus/templates/servicemonitors.yaml" is empty. Skipping.
[tiller] 2018/08/28 01:12:34 performing install for prometheus-operator
[tiller] 2018/08/28 01:12:34 executing 2 pre-install hooks for prometheus-operator
[tiller] 2018/08/28 01:12:34 hooks complete for pre-install prometheus-operator
[storage] 2018/08/28 01:12:34 getting release history for "prometheus-operator"
[storage] 2018/08/28 01:12:34 creating release "prometheus-operator.v1"
[kube] 2018/08/28 01:12:34 building resources from manifest
[kube] 2018/08/28 01:12:34 creating 60 resource(s)
2018/08/28 01:12:35 [INFO] Updating service [prometheus-operator-alertmanager] with public endpoints [[{"addresses":["<IP_ADDRESS>"],"port":30903,"protocol":"TCP","serviceName":"cattle-prometheus:prometheus-operator-alertmanager","allNodes":true}]]
2018/08/28 01:12:35 [INFO] Updating service [prometheus-operator-grafana] with public endpoints [[{"addresses":["<IP_ADDRESS>"],"port":32233,"protocol":"TCP","serviceName":"cattle-prometheus:prometheus-operator-grafana","allNodes":true}]]
2018/08/28 01:12:35 [INFO] Updating service [prometheus-operator-prometheus] with public endpoints [[{"addresses":["<IP_ADDRESS>"],"port":31645,"protocol":"TCP","serviceName":"cattle-prometheus:prometheus-operator-prometheus","allNodes":true}]]
2018/08/28 01:12:35 [INFO] Updating workload [cattle-prometheus/prometheus-operator-grafana] with public endpoints [[{"addresses":["<IP_ADDRESS>"],"port":32233,"protocol":"TCP","serviceName":"cattle-prometheus:prometheus-operator-grafana","allNodes":true}]]
2018/08/28 01:12:35 [INFO] Updating pod [cattle-prometheus/prometheus-operator-grafana-577bc574bb-9df7s] with public endpoints [[{"addresses":["<IP_ADDRESS>"],"port":32233,"protocol":"TCP","serviceName":"cattle-prometheus:prometheus-operator-grafana","allNodes":true}]]
[tiller] 2018/08/28 01:12:36 executing 2 post-install hooks for prometheus-operator

...

 Check its status by running:
  kubectl --namespace cattle-prometheus get pods -l "app=prometheus-operator,release=prometheus-operator"

Visit https://github.com/coreos/prometheus-operator for instructions on how
to create & configure Alertmanager and Prometheus instances using the Operator.

get in create prometheus-operator

...

[tiller] 2018/08/28 01:12:45 preparing install for prometheus-operator
[storage] 2018/08/28 01:12:45 getting release history for "prometheus-operator"
[tiller] 2018/08/28 01:12:45 failed install prepare step: a release named prometheus-operator already exists.
Run: helm ls --all prometheus-operator; to check the status of the release
Or run: helm del --purge prometheus-operator; to delete it

...

2018/08/28 01:13:00 [ERROR] AppController p-2gtwg/prometheus-operator [helm-controller] failed with : failed to install app prometheus-operator. error: Error: a release named prometheus-operator already exists.
Run: helm ls --all prometheus-operator; to check the status of the release
Or run: helm del --purge prometheus-operator; to delete it
: exit status 1
get in update prometheus-operator
get in update prometheus-operator

Results:
All items in app have beed removed.

There are some backend issues, i will fix that. @loganhz can you take a look at why targetnamespace is not sent?

@loganhz currently the front-end will make two API calls for the first time launching an app, includes both create and upgrade, can eliminate the upgrade one to avoid duplicate calls, in result the back-end will deploy the app twice and have 2 version for a new app.

PR is not merged. It will be fixed after that

@StrongMonkey @guangbochen front end has been merged and built for this

@guangbochen that is going to change, i already put a pr to fix that.

it is available to test on master now.

verified fixed on master 08/31, close it.


⚠ Carbubu has degraded performance

In edac23b, Carbubu (https://carbubu.fr) experienced degraded performance:

HTTP code: 200
Response time: 15019 ms

Resolved: Carbubu performance has improved in 2bea1bc after 23 minutes.


There are several XML/XSD errors reported on dubbo-config-spring project.

[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: master branch, latest code as of 9/8/2018.
Operating System version: not os specific
Java version: 1.8

Step to reproduce this issue

Checkout the latest code, using git clone.
import all projects as maven projects in eclipse.
Do a full build

Pls. provide [GitHub address] to reproduce this issue.
Expected Result
There should be no validation error
Actual Result
There are several xml/xsd validation errors reported on “dubbo-config-spring” project:
Description	Resource	Path	Location	Type
cvc-complex-type.2.2: Element 'name' must have no element [children], and the value must be valid.	web-fragment.xml	/dubbo-config-spring/src/main/resources/META-INF	line 5	XML Problem
cvc-elt.1: Cannot find the declaration of element 'beans'.	provider-nested-service.xml	/dubbo-config-spring/src/test/resources/org/apache/dubbo/config/spring	line 22	XML Problem
cvc-pattern-valid: Value 'dubbo-fragment' is not facet-valid with respect to pattern '($||\p{L})(\p{L}|\p{Nd}||$)*' for type 'null'.	web-fragment.xml	/dubbo-config-spring/src/main/resources/META-INF	line 5	XML Problem
Referenced file contains errors (http://dubbo.apache.org/schema/dubbo).  For more information, right click on the message in the Problems View and select "Show Details..."	annotation-consumer.xml	/dubbo-config-spring/src/test/resources/org/apache/dubbo/config/spring	line 1	XML Problem
src-resolve: Cannot resolve the name 'beans:property' to a(n) 'element declaration' component.	dubbo.xsd	/dubbo-config-spring/src/main/resources/META-INF	line 1106	XML Schema Problem
src-resolve: Cannot resolve the name 'beans:property' to a(n) 'element declaration' component.	dubbo.xsd	/dubbo-config-spring/src/main/resources/META-INF/compat	line 1112	XML Schema Problem

What is actually happen?
If there is an exception, please attach the exception trace:
Just put your stack trace here!

PS: there is a grammar error in the issue template. "What is actually happen?" should have been: what is actually happening?

I am using intellij idea, without any errors or warnings， Which eclipse version are you using?

Eclipse Java EE IDE for Web Developers.
Version: Oxygen.2 Release (4.7.2)
Build id: 20171218-0600

I also using intellij idea,without any errors,maybe it is eclipse's bug

@sevencd I seriously doubt that whether did you ever try to validate the xml/xsd.
Did you try to right click the file and choose "Validate"?

@elmar-chen, good catch.
I tried to validate these files in Intellij Idea. I agree we should fix issue in web-fragment.xml since the value in <name> element is invalid.
But for other files: dubbo.xsd, provider-nested-service.xml, annotation-consumer.xml, Intellij idea doesn't report any warning or error.
Intellij idea is smart enough to validate these files against the local schema, instead of requiring one explicit schema location specified.
I think we can simply ignore other files, but fix web-fragment.xml only. What do you think?

@beiwei30, well, that's up to you. I'll modify the pr.

@elmar-chen I am fine with specify schema location in the target xml. It's no harm and should help eclipse users. Do you mind to initial a discussion on<EMAIL_ADDRESS>

@beiwei30 - I'll do that. For the mean while, I will modify the current pr to include just web-fragment.xml and raise another one if the discussion ends with a yes about adding the schemaLocation.

@elmar-chen Sure, pls. do it, though I am now lean to add schema location after I realize it's necessary since it will help on dev experience for eclipse user. Let's see what other people say.

@elmar-chen Sure, pls. do it, though I am now lean to add schema location after I realize it's necessary since it will help on dev experience for eclipse user. Let's see what other people say.

not valid bug any longer, since we remove the web-fragment.xml completely.


Handle small errors better

Proposed Changes
One error catches a whole function. Even that admin rights could be the issue most of the time, in my case it wasnt the issue and the error message was misleading. This should make the error now better to handle.
Also due to the same issue, no version.txt has been created and therefore I got an unhandled issue.
This PR fixes both.
Related Issues

(Github link to related issues or pull requests)

Thanks ;)


Highlight group?

What highlight group does goto-preview use? It seems different.

I don't want to use this italic font.

I don't actually set any highlight groups. Maybe your config sets specific things for floating windows?

Oh, I have found it. :hi NormalFloat
Thanks for your directions!


Update external_rules.rst

Update examples to use RuleSeverity instead of MessageSeverity.
Update second example to make it work.

Codecov Report

Merging #210 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   98.69%   98.69%
=======================================
  Files          31       31
  Lines        1991     1996    +5
=======================================
+ Hits         1965     1970    +5
  Misses         26       26

Impacted Files
Coverage Δ

robocop/rules.py
100.00% <0.00%> (ø)

tests/e2e/test_e2e.py
100.00% <0.00%> (ø)

robocop/run.py
97.57% <0.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4de807...e68c05c. Read the comment docs.

Thanks @szabolcstoth for your contribution! 🥇


【BUG】Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/Markdown.php on line 1799

Just like the title. There are many errors like this, I just change it one by one.
These errors are located in Wikitten/renderers/Markdown/Markdown.php and Wikitten/renderers/Markdown/MarkdownExtra.php.
The way I alter is changing {} to [].  That's all the mistakes.
This is my server configuration:
BTpanel:It is a  simple Installation Panel.
Through it I install

Nginx 1.16.1
MySQL 5.5.62
PHP-7.4
Pure-Ftpd 1.0.49

Mononuclear CPU;2G memory ;40 G system disks
There are no other configurations
Other errors I recorded below:
Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/Markdown.php on line 1799$token{0}

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/Markdown.php on line 1801$token{1}

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 215$element{0}

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 217$element{0}

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 511$tag{0}

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 511$tag{0}

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 518

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 552

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 552

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 567

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 568

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 667

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 677

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 677

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 686

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 687

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 1074

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 1469

The above list is not complete, you need to find your own.
Finally, thanks for the software.

Just like the title. There are many errors like this, I just change it one by one.
These errors are located in Wikitten/renderers/Markdown/Markdown.php and Wikitten/renderers/Markdown/MarkdownExtra.php.
The way I alter is changing {} to []. That's all the mistakes.
This is my server configuration:
BTpanel:It is a simple Installation Panel.
Through it I install

Nginx 1.16.1
MySQL 5.5.62
PHP-7.4
Pure-Ftpd 1.0.49

Mononuclear CPU;2G memory ;40 G system disks
There are no other configurations
Other errors I recorded below:
Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/Markdown.php on line 1799$token{0}

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/Markdown.php on line 1801$token{1}

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 215$element{0}

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 217$element{0}

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 511$tag{0}

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 511$tag{0}

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 518

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 552

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 552

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 567

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 568

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 667

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 677

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 677

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 686

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 687

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 1074

Deprecated: Array and string offset access syntax with curly braces is deprecated in /www/wwwroot/Wikitten/renderers/Markdown/MarkdownExtra.php on line 1469

The above list is not complete, you need to find your own.
Finally, thanks for the software.


[AI Clock] Minor fixes

Minor fixes (angle of white hand background) and design improvements

Thanks!


[flow typing] custom .toString

Does anyone know how to type this properly - https://github.com/pauldijou/redux-act/blob/8322d80da2ba7a6e5a7324240d93ecfc971c6d87/src/createAction.js#L86 ?
I've tried with various methods, but couldn't figure out how to type return value of createAction, maybe somebody here got better luck.

What's the problem compared to other functions? This one takes no arguments and returns a string.

I meant that there is a problem with typing return value of createAction and not actionCreator.toString.
It even is not be a problem when writing library definitions (like for flow-typed) as it can be typed as callable, but I have no idea how to type such thing in the source code itself when using flow

The issue im talking about can be observed here

It's nearly impossible to type it. Check the TypeScript definitions, there are several tricks to support to the best we can, having the same functions with dozen of possible types (with or without payload, with or without metadatas, no payload reducer, payload reducer with one, two, three, four, five or six arguments).
This lib wasn't designed to be typed at all. I would rather consider thinking of a better typed API on top of it.
I don't know Flow at all right now unfortunately...


Eliah Kagan: Watch drnirenrao.com

Eliah Kagan requests the watch of the watch_keyword drnirenrao\.com. See the MS search here and the Stack Exchange search here.

drnirenrao\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Eliah Kagan in Charcoal HQ

Approved by Eliah Kagan in Charcoal HQ


Support React DevTools

Ref: #36

Do you that supporting React DevTools would be difficult? I can help with this.

Closed by https://github.com/raphamorim/react-tv/pull/123


Feat: Adding Description about Flipkart

Describe the feature
The description about Flipkart is missing, that talks about

What is Flipkart plus?
How to buy and what are the options on mode of payment?
What you can  buy from Flipkart actually.

Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@arghadipmanna101 Please assign this task to me.

i can make it more attractive than original flipkart website.Kindly assigned this task to me .

I had already done this kind of task so please try to give me one chance and i will not surely disappoint you


HTTP/2 end of stream event missing

It is not possible to execute some code when an http/2 stream ends. (it http 1 it's connection closed, but in http/2 the connection do not close at end of request)
Notice: @trowski is already aware of this issue but we spoke about it several days ago. So to keep track of it I open an issue.

You must have missed my replies in chat. I tried to replicate the issue with and without compression, but was unable to. Using the event-stream.php example modified to enable encrypt for HTTP/2, Response::onDispose() is invoked immediately after the RST_STREAM frame is received from the browser.
I wonder if you're somehow holding onto the reference to the Response object in your app?
Rather than relying on the destructor of Response, we should be explicitly invoking a method when the response is sent to help avoid an issue in case an app creates a circular reference?

Hum I see, the error may be related to how PHP is removing the item from memory. But no, I don't have any reference to this object. I'll take a look deeper to see if I can trigger the garbage collector manually in a good place.

I'm not 100% sure what may be going on in a more complex app. Perhaps the server is holding onto the reference? I looked at setting up your app but was missing some components so I tried a simpler setup. Would you be able to simplify the setup so I don't have to have another service running to trigger events?

Could you please push a branch of your project with the version where you're setting an onDispose callback on the Request?

Would you be able to simplify the setup so I don't have to have another service running to trigger events?

Once running (you need a custom certificate, the makefile helps you) you can use the app itself to trigger event by going to https://localhost . I'll add a new branch with the onDispose implementation this evening. 👍

The following code works great on the latest beta:
$response->onDispose(function () { /* do something on end of stream */ });

This was fixed in https://github.com/amphp/http-server/commit/d579d5bd521ab74989e61259b3ded48b48baf094, but I forgot to close the issue at the time. Thanks for confirming @Nek-!


Add PaymentRequest is behind flag in FF

We have a partial implementation that people can enable. More parts are currently landing, but there is enough there to play.

Thanks!


Problem with Caliberation

I am using two kinects with one marker it is not being calibrated and the result is two distinct point clouds. I have tried everything the docs said and can see that it is tracking the marker in the depth window but is showing caliberation=false for both markers.
I have added the marker in the settings. Please help me out here as I don't really understand the concept of marker even when i have read all the explanations you have given in other issues.
Also please tell me if i want to use two markers then how to adjust the translation and rotation i mean you said that point cloud is made when markers are set correctly, i want to ask how do we translate the value on the basis of real time measurement or what? Didn't really understand.
Thanks

Hey Sethi!
Which marker have you printed out? And can you upload a screenshot of the marker settings in your program?
If Livescan recognizes your marker, you should see a green or red outline on the marker in the Client preview window.
It would also help if you can show us a picture of your printed marker, sometimes the ink is too reflective/glossy or is too low in contrast.
For using multiple markers:
Imagine you have a world center in your scene, at 0,0,0 (XYZ). Livescan always centers the viewport around this center, and the marker places the content in relation to this center, so it's a good idea to have the marker always close to it,
The marker offset is always in relation to this world center, If you don't set the transform or rotation of the marker (all values are 0) the marker will be located at the world center.
Now imagine you want to use four markers, arranged like a cube. For the best placement, the world center should be in the middle of the cube. So the offset should be calculated based on the distance of the marker from the center, as well as the rotation offset. I've drawn a small sketch to illustrate this
So let's say this is our coordinate system, XYZ, with the forward axis being on the Z axis. Therefore in the default rotation (0,0,0), our marker faces into the Z direction.

If we want to now use a cube configuration, and we say our marker width is 20cms, we arrange our markers like this:

Livescan uses centimeters for translation and euler angles for rotation. Our cube arrangement gives us the following values:

preview of settings

I have used marker=0
It is not recognizing the marker as I could not see any green or red line also calibrated is showing false too. Can you please send me pictures of how you set up the cameras and marker which I can take as a reference to make mine?

Printed marker image that i am using

Hm, everything looks fine to me in your settings and the printed marker seems to be good aswell!
Just to be sure, you did press on the "Calibrate" button inside the server windows after you made sure that both color and depth view of the client can see the marker fully?
You might have to experiement with lighting a bit, try to avoid direct sunlight, but also make sure to have some bright artifical lights in your room. The marker should be well-lit.
If you want to, you can also send some screenshots of your client depth and color preview showing the marker (block out the rest of the room with MS Paint or something for privacy), so I can take a look if everythings looking good there!

These are the images well i haven't stick it to the wall because it was not tracking even when i have stick it to the wall

Try gluing the marker onto a very flat piece of cardboard, wood, or something else, which does not bend.

One marker worked!

Is ther problem is with translation, dont know?

Please help me with this too

So several things:
-You should glue your markers to a flat piece of cardboard. If the marker is bended like in your picture, the chances of being recognized are very low and the precision as well

All markers should have the same size

Orientation = Rotation, Translation = Position. If you enter 180 into your translation, it means the marker will be 180 meters away from the center.

If you do this kind of setup with two kinects facing each other, I'd recommend glueing both markers onto the opposite sides of a piece of cardboard and holding in the middle of the two kinects. This way, you only need to set the Y Rotation/Orientation for one marker to 180 and leave all other values at 0.

Thank you for all the responses, i am now able to track two markers,
One last thing i want to ask is how are you setting up your environment for 4 kinects in demo video? I mean how many markers are you using and how are you arranging it?

Hi, Are you done writing the blog as i was waiting for it to execute with 4 kinect devices?

Hey! Sorry I got sick until yesterday ago and could not finish it yet. I'll have it done in the middle of the week I think!

Hi, Are you done writing the blog?

I've just finished writing the documentation on the Calibration process, you can view it here: https://github.com/Elite-Volumetric-Capture-Sqad/LiveScan3D/blob/development/docs/User Guide/Calibration.md

Thanks for the clear docs, I have a question, Well I want to ask if my setup is like I want to capture a person sitting on the chair and using a 4-cube marker setup then how will I place the cube to get all the sides of the person sitting on the chair and marker are readily captured by Kinect.

I'd place the cube on the chair, but elevate it a bit with some boxes so that the backrest doesn't cover anything on the cube. Otherwise I'd arrange the kinects like in the graphic: https://github.com/Elite-Volumetric-Capture-Sqad/LiveScan3D/raw/development/docs/User Guide/images/Calibration/4_Marker_Setup.png

Hello
Thank you for all your support i am able to track 4 kinects, but i want to ask you one thing, i have 4 kinect dks and i am trying to connect all the four with daisy configuration but it wont work until i attach all the kinects to separate laptops and connect livescan client, So wont it work if i connect all the kinects with one computer or two?

Hi! What specifially doesn't work? Do you get an error message? It should be able to run all kinects on one PC, that is in fact what I've been doing most of the time.

Basically whrn i connect one kinect to the laptop and other to power source and that kinect and coonect to the server i can only see one kinect connected but when i connect other to other laptops and then server then only i can see other kinects and master subordinate relationship.

Basically whrn i connect one kinect to the laptop and other to power source and that kinect and coonect to the server i can only see one kinect connected but when i connect other to other laptops and then server then only i can see other kinects and master subordinate relationship.

Apologies that sentence was a bit hard to understand for me. Can you describe the process again but each step after the other, like this?

Connect first Kinect to Laptop
Connect second Kinect to Laptop
Open two Livescan Clients on Laptop
...
and so on?

Sure

I connect first kinect i.e. master to server laptop
I connect other kinects to the master kinect as daisy configuration and didn't connect subordinate kinects to any laptop but only power and to each other
I only connect one client with master kinect to server
And enabled the temporary sync but can only see one kinect
I experimented by connecting other subordinate kinects to connect with laptops and open livescan client for all and connect to server then only i can see other subordinated kinects.
So i just wanted to ask if it is possible to use only one kinect for all the 4 kinects?

Hello, thank you for your reply, I have read the document you thanked, but the calibration is still successful. I have two Kinectv2 cameras, and put them face to face, the marks are placed in the middle, and the marks 0 and 1 are used, and the mark Y of 1 is turned to fill in 180°, and the other marks are 0, and the correction also appears green box, but it is still false

This means the color camera can see the marker, but the depth camera can not. This is usually caused by the marker being too far away or too close to the sensor. Try moving the marker around. Sometimes this issue can also be caused by too much IR-light in the enviroment.

你好，感谢你的回复，请问也是通过；移动来让深度相机中队标记图案显示绿色轮廓吗？

Hello, thank you for your reply. Do you mean that I should also display the marked green outline in the depth image?

As shown in the image above, shadows can only be roughly shown

The above picture is the image I clicked show live with two KinectV2s to view. I have a question: Why is the Marks displayed by kinectv2 at each end the Marks at the back of the display board? Is it because my board is too thin, I pasted marks of 0 and 1 on the front and back of a cardboard

According to your requirements, I pasted Post-it notes on the ground to prevent the ground from being light resistant, but the result of Calibrate still shows false。

I placed the two kinect positions opposite each other, the LiveScanServer connected Kinect face is tag 0, and the second Kinect V2 is shot tag 1

In the last post it looks like your setup is correctly calibrated? So you managed to fix the problem?

The point cloud data I photographed was Calibrated, but the LiveScanServer window showed Calibrated = false

That's a bit odd for sure, but if the pointcloud is correctly calibrated, the calibration is successful!
I'm not too sure why this state isn't reflected in the server window, but you can assume that this is just a bug for now.

Hello, thank you for your reply. May I ask why my camera is at the same height, but the position of the green coordinate (Kinect V2 camera) in the show live screen is not at the same height, and the reconstructed data is slightly inclined。

Could be mutiple reasons:

Are you sure that both kinects do have the exact same height and angle in the real world?
Are the two markers precisely aligned?
Are the markers tightly attached to the cardboard, and is the cardboard and marker flat and not bend?
Did you make sure that the kinects haven't moved since calibrating?
Two kinects facing each other like this can introduce interferences, because the lasers of both kinects shoot each other in the camera

Hello, can you send the document about correction? It seems that the link is invalid

Ah yes, I'm currently restructuring to put all the documentation on a website, so the file has moved here: https://github.com/BuildingVolumes/LiveScan3D/blob/development/docs/Website/content/docs/user-guide/calibration.md

Hello, can I add your wechat or other contact information? I would like to ask you some questions

You can join our discord if you'd like to!
https://discord.gg/7sgwg5Eq
But also feel free to ask question here in the issues/open new issues, in this way other people can search for them if they have the same problem!

OK, I'm in. Thank you

Hello, I would like to ask you about my Calibrate problem,The two Kinectv2 cameras were placed symmetrically, with the mark placed in the center. In the software environment visio stdio 2019, I calibrated that the mark was always shown to be false. The mark was printed in A4 paper size, should it be changed to A3?

It looks like your markers were mirrored on the horizontal axis before printing.
Try mirroring them, after printing they should look like this https://github.com/MarekKowalski/LiveScan3D/blob/master/docs/calibration markers/0b.gif, with the single square showing to the left.

Thanks for your patient reply, but I just reprinted it and re-calibrate it, but it still shows false

Hello, I have looked up the relevant documentation on corrections and found that the depth map does not match the individual corrections in your documentation, and the interface for setting markers is different from your documentation

Sorry, yes the documentation is for a new version of LiveScan, which unfortunately doesn't support Kinect V2 anymore. But altough the UI looks different, the functionality should be similar, with the biggest difference being that you manually need to add the markers and marker IDs in your version. Your settings look fine though!
To be honest, I'm really not sure what the problem might be anymore. Your settings look good, the markers are getting correctly detected, (As shown by the green outline) and the depth image also looks good.
You could try to experiement with the light settings a bit (switch the light on/off, or dimm it), and rotate/move the marker around a bit, that sometimes helps.
As a last resort, can you maybe upload a video where you go through the whole process of calibration, from Opening the app to trying calibration a few times?

Hello, I would like to ask how many versions of vs are used for this project?

How many? I'm just using one version, 2022.


GH2267: Fix more 'occured' and 'occuring' typos

Continues on from https://github.com/cake-build/cake/pull/1835 and fixed #2267

@flcdrg your changes have been merged, thanks for your contribution 👍


Configurator fails to load without internet access

The Configurator add-on does not load if there is no internet access on the machine loading the web interface. My browser's inspector reports failed requests to cdnjs.cloudflare.com, code.jquery.com, drive.google.com, *.githubusercontent.com, and *.googleusercontent.com. I think the issue is caused by resources and scripts being loaded from various CDNs. Is it possible to embed the scripts and dependencies in the add-on so it can be used without the need to be online?

Please report here: https://github.com/danielperna84/hass-configurator
We deliver only the software


An extra space is added in the descriptions on ADLS Gen2 blob upload dialog

Storage Explorer Version: 1.9.0
Build: master_20190821.3
Platform/OS: Windows 10/ Linux Ubuntu 18.04
Architecture: ia32/x64
Language: Chinese (zh-CN)
Regression From: Not a regression
Steps to reproduce:

Run the command 'StorageExplorer.exe --lang=zh-CN' to launch storage explorer.
Expand one ADLS Gen2 account -> Blob Containers.
Create a new blob container -> Click '上载' to open upload dialog.
Check the upload dialog.

Expect Experience:
No extra space is added in the descriptions on the upload dialog.
Actual Experience:
An extra space is added in the descriptions on the upload dialog.

Concatenation of below strings
Resource ID: 0;"String Table"\0;"Strings"\0;"SelectFileMsg"
Relative File Path: drop\loc\en\src\components\se-az-copy-extension\resources\UploadBlobsDlg.json.lcg
Project: StorageExplorer
Subtenant: StorageExplorer
ENU: Select the files you want to upload
CHS: 选择要上传的文件
Resource ID: 0;"String Table"\0;"Strings"\0;"DestinationDir"
Relative File Path: drop\loc\en\src\components\se-az-copy-extension\resources\UploadBlobsDlg.json.lcg
Project: StorageExplorer
Subtenant: StorageExplorer
ENU: and the destination directory.
CHS: 和目标目录。

Hello @craxal, would you please suggest where to locate the concatenation so as to remove the extra space?

Just checked the dialog code, and we are indeed splitting the string, but we shouldn't be doing that.

Need to update extension package version.


Eduard/DPROD-3234/Combine fonts

Changes:

Combine fonts

Type of change

[ ] Bug fix
[ ] New feature
[ ] Update feature
[ ] Refactor code
[ ] Translation to code
[ ] Translation to crowdin
[ ] Script configuration
[ ] Improve performance
[ ] Style only
[ ] Dependency update
[ ] Documentation update
[ ] Release

Closing in favor of https://github.com/binary-com/deriv-com/pull/6966/


cutorch automatic GC

This is the cutorch version of https://github.com/torch/torch7/pull/280
Since there's no _msize for cutorch, we're going to only keep track of heap usage by THCStorages, which take up most of the space.

There's actually a bigger problem which is that heapSize must not be thread-local at all, see https://github.com/torch/torch7/pull/324. The rest of it can be in THCState.
I'm having a bit of trouble testing threads with cutorch, when I run the example from https://github.com/torch/torch7/pull/324 with CudaTensors on master, I get weird errors, either
FATAL THREAD PANIC: (read) ...al/git/torch-distro/install/share/lua/5.1/torch/File.lua:266: read error: read 10 blocks instead of 542886064 at /data/users/alerer/git/torch7/lib/TH/THMemoryFile.c:323

or
FATAL THREAD PANIC: (read) ...al/git/torch-distro/install/share/lua/5.1/torch/File.lua:266: $ Torch: invalid memory size -- maybe an overflow? at /data/users/alerer/git/torch7/lib/TH/THGeneral.c:197

Tracking that down, then I'll update this.

I don't understand why the heap size is now global but the the heap softmax is part of the THCState. Shouldn't they either both be global or both part of the THCState? Considering that the garbage collection function is part of the THCState, it seems consistent to have everything in the THCState.

I saw your comment in the Torch PR. Didn't think about the case where a tensor is moved between states/threads. So it makes sense to keep the heap size global.

In the torch7 gc discussion you said
"I agree that this should be disabled by default for now. In cutorch we have a good solution to push these counters into the Lua state with the THCState. I don't know how feasible it is to do something similar for torch."
so I assumed you didn't have the same reservations about cutorch. But if you prefer, I can disable it by default for a while until we get some more experience with it.

Good point. I'd forgotten about that :)
Looks like there are merge conflicts. Can you rebase please?

rebased and squashed commits

Thanks!


Loot Tracker: Track runes crafted at the ZMI/Ourania Altar

An overview in the loot tracker plugin to see how many of a certain rune you've crafted.

I don't think we want to add skilling resources to the loot tracker.

Maybe one for the runecrafting plugin. MLM plugin tracks ores, fishing plugin counts fish, same for WC, so it seems like the natural place to put it.

We already have issue open for this

#4126


Provide an easier way to manage extensions in the extensions panel

I would like to group and collapse extensions by language (for instance, all Microsoft Python team extensions) in the extensions panel to enable/disable them at the same time.

/duplicate


weechatScripts.weechat-matrix: unstable-2019-11-10 -> unstable-2020-01-21

Motivation for this change
Updated the sources and dependencies for matrix-nio and its dependent weechat-matrix. Not tested extensively, but "it builds".
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build weechatScripts.weechat-matrix

@GrahamcOfBorg build weechatScripts.weechat-matrix

@GrahamcOfBorg build weechatScripts.weechat-matrix

Updated to include the new matrix_{decrypt,sso_helper} scripts.
@GrahamcOfBorg build weechatScripts.weechat-matrix

Missed a dependency for the SSO helper that wasn't actually affecting anything because it was coming in indirectly via requests... Python packaging is a mess.
@GrahamcOfBorg build weechatScripts.weechat-matrix
cc @tilpner

pushed with requested tweaks ^^

when I tested this I ran into #79646

As far as I'm aware that's just due to the nature of the nixpkgs WeeChat configuration; you need to ensure WeeChat's Python picks up the necessary package dependencies:
  environment.systemPackages = [
    ...
    (weechat.override {
      configure = {availablePlugins, ...}: with weechatScripts; {
        plugins = with availablePlugins; [
          (python.withPackages (_: weechat-matrix.propagatedBuildInputs))
        ];
        scripts = [ weechat-matrix ];
      };
    })
    weechatScripts.weechat-matrix
  ];

It would be nicer if this happened automatically, but unless I'm mistaken I think it's orthogonal to this update.

python.withPackages (_: [ weechat-matrix ]) should be sufficient there, no need to explicitly pass propagatedBuildInputs around

@emilazy Is there a reason this is marked as unsupported on macOS? Seems to build fine.

probably a previous issue that blocked mac support. Pretty common

@mjlbach not to my knowledge; feel free to submit a PR that changes it to platforms.unix or platforms.all, or I'll try to remember to get around to it if I bump the package again.


Add list-assets code sample for IoT SiteWise

Issue #, if available:
Description of changes:
A List-Assets code sample for IoT SiteWise using https://docs.rs/aws-sdk-iotsitewise/latest/aws_sdk_iotsitewise/client/struct.Client.html#method.list_assets
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thank you for this contribution! The examples in this repo are actually copied over automatically from the official AWS SDK examples repository. The Rust examples are in the rust_dev_preview sub-directory. Please open a PR on that repository to get the example added, or let me know if you would like me to move it for you.


Add Sort to table columns

@ashu8912 , Please check the changes I propose in the fix up commit which simplify the patch by not having two sort effects and rely solely on the sortColIndex for setting up the sort.
I have also changed the 2 buttons into a "swap" button when the column is not being used for the sorting, as having two buttons was taking too much space and didn't look great. And the buttons are smaller now.
Please verify the code and test it if you can.