:sparkles: [open-zaak/open-notificaties#207] Update existing with register_kanalen

Closes open-zaak/open-notificaties#207
This does require Open Notificaties to allow PUT to Kanalen (which the spec doesn't allow right now), see https://github.com/open-zaak/open-notificaties/pull/208

Codecov Report
Attention: Patch coverage is 93.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.01%. Comparing base (aa73035) to head (4067515).
Report is 30 commits behind head on main.

Files with missing lines
Patch %
Lines

...api_common/management/commands/register_kanalen.py
88.88%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   90.19%   93.01%   +2.81%
==========================================
  Files          29       38       +9
  Lines         602      988     +386
==========================================
+ Hits          543      919     +376
- Misses         59       69      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


JS Client - WIP

Client skeleton finished. Most query methods and few entrypoints calling functions implemented.
TODO:
[ ] - Add support for all entrypoints
[ ] - Add support for session code
[ ] - Add client instance bootstraping - it will query config options and validate params when calling methods (depending on the config)
[ ] - Add more tests (checking if everything works as expected for certain configs)
[ ] - Add NPM publishing scripts

Hi @hoffmannjan , Could you please let me know when CEP78 js client is available?
And I saw that you used tslint for linting. In my opinion, tslint is deprecated and need to consider using eslint for js client.
Thank you


Issue 5940

Which issue does this PR close?

Closes #5940.
Rationale for this change

After applying patches based on #5866 and #5904, based on the flame graph for q17 generated by
sudo CARGO_PROFILE_RELEASE_DEBUG=true cargo flamegraph --freq 500 --bin tpch -- benchmark datafusion --path ./data-parquet/ --format parquet --partitions 1 -q 17 --iterations 10

we found the bottleneck happens at ### physical_plan::joins::hash_join::update_hash.
What changes are included in this PR?

Remove unnecessary equality check for JoinHashMap.
Change back SmallVec to Vec for JoinHashMap.

After applying the patch proposed from this PR, the flame graph becomes

We can see the samples for the vector capacity changing significantly decreased. It's expected especially when doing joining with one big table and the other is relatively small.
To end to end query performance for q17 is improved from 700ms to 650ms.
Are these changes tested?

Are there any user-facing changes?

Hi @Dandandan and @alamb, could you help review this PR?

There is a CI check https://github.com/apache/arrow-datafusion/actions/runs/4657156069/jobs/8241558786?pr=5941 appears to be failing
Given that we have a benchmark that improves (q17) I think we should merge this PR, assuming we can resolve the CI failure satisfactorily.
Thank you for this @yahoNanJing

It would be nice to show whether we are not getting regressions for other queries.

We have improved the datastructure of join in other ways already, so closing the PR in order to clean it up


Added Go client library links to navigation bar

Motivation
Added Go links on navigation bar with other client libraries

retest this please


Implement Body::sized

This is necessary for APIs such as BigML's, where we may need to send extremely large request bodies, but chunked transfer encoding is not supported.
This is a partial fix for seanmonstar/reqwest#49.

Thanks!


Unify order of output

Currently, there are many different ways the json output is ordered in different tools (csaf-validator-lib, csaf-validator-service, csaf_validator).

The preferred output should use the order:
   {
      "errors": [],
      "warnings": [],
      "infos": [],
      "isValid": true,
      "name": "informativeTest_6_3_9"
    }

Also, it must be checked that the documentation is up-to-date / whether changes in the documentation must be made.


[#Wave-Control: Add NetSuite] Added auto focus for all NetSuite forms

Details

Pre-requisite

Collect workspace with accounting enabled.
NetSuite beta enabled for the user.
Setup NetSuite in a Workspace.

Fixed Issues

$ https://github.com/Expensify/App/issues/45192
PROPOSAL:
Tests

While the issue was reported for Custom Form ID, none of the NetSuite forms had auto focus.

Open the app with the pre-setup workspace.
Go to Accounting
Tap on the Advanced button.
Tap on Non-reimbursable expense option (Enable Custom form ID to access this field)
Tap on Reimbursable expense option
Verify that the text input is focused.
Similarly test the forms for adding new Custom segments/records and Custom lists.
Test the auto focus on editing the Custom segments/records and Custom lists.

[ ] Verify that no errors appear in the JS console

Offline tests

Same as Tests.
QA Steps

Same as Tests.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/700433d1-4109-4540-9715-0f9d403bb17c

Android: mWeb Chrome
https://github.com/user-attachments/assets/f0281403-eaf1-4647-ad9e-303979b181c1

iOS: Native
https://github.com/user-attachments/assets/d1b96ebe-34db-48c1-b1a6-7c5f821521a4

iOS: mWeb Safari
https://github.com/user-attachments/assets/5917096a-7dbb-4a96-b409-a0f080008a2f

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/3c16bc18-b0c7-473f-b429-c6ed29d5b0e2
https://github.com/user-attachments/assets/ab4d9a98-5825-4b3e-8068-bcbf1d5e1d59

MacOS: Desktop
https://github.com/user-attachments/assets/1973cdec-fed1-4c7f-99a2-dfc6fe2ab901

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.11-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.0.11-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


After effects animation

I have created logo animation in aftereffects it works fine in aftereffects but when i convert it in bodymovin and use in html page its not showing ani animation pls tell me what is the problem why animation is not working in html page pls  give me any solution

one more issue i hav i have created one page which display products and i hav done with my seard coding also but i stuck with currency we want that when i click on any currency all products price should converted to that paricular currency but its not working

hi, can you share the .aep so I can check it out?


Add analytic event: BACK_TO_SEARCH

Fixes
Fixes #1087 by @dhruvkb
Description

Adds BACK_TO_SEARCH event to the Events type.
Fires the event from VBackToSearchResultsLink.vue using the useAnalytics composable.

Will make the changes and test it locally @sarayourfriend
I have never written unit tests before. Is there something that can get me started on this?

Sure. Openverse uses jest, a popular JavaScript testing library: https://jestjs.io/
Their documentation is fairly comprehensive, and we have lots of examples in our repository for other tests. A good basic example for Openverse specifically is the test suite for VLicense: https://github.com/wordpress/openverse/blob/7c92ba5bdff84b2771dc25a946bb371600906e0e/frontend/test/unit/specs/components/v-license.spec.js#L1
We also use testing-library which you would need to use in the case of the tests for this change by causing a click event on the rendered component. The basic example for Vue testing includes an example for how to fire click events on a rendered component.
You'll need to "spy" on the sendCustomEvent function that is returned by useAnalytics. To do that, it will be necessary to mock useAnalytics, similar to this useI18n mock from our own test suite: https://github.com/wordpress/openverse/blob/7c92ba5bdff84b2771dc25a946bb371600906e0e/frontend/test/unit/specs/components/AudioTrack/v-audio-track.spec.js#L38-L43
Something like:
jest.mock("~/composables/use-analytics", () => ({
  useAnalytics: jest.fn(() => ({
    sendCustomEvent: jest.fn()
  })
})

Then you can import the mocked useAnalytics function to retrieve the mocked sendCustomEvent and follow jest's documentation for asserting the calls work as expected: https://jestjs.io/docs/mock-functions
The mock for useI18n is an instructive example.

Hey @sarayourfriend .. I tried testing the changes locally. I set the BACK_TO_SEARCH event as a goal, but it does not show up in the Goal Conversions section :/

I tried testing the changes locally. I set the BACK_TO_SEARCH event as a goal, but it does not show up in the Goal Conversions section :/

Have you confirmed that the sendCustomEvent function is being called as expected? I won't be able to take a closer look at this PR until next Tuesday, but maybe @dhruvkb can help debug if there's a deeper issue.

Have you confirmed that the sendCustomEvent function is being called as expected?
Nope, the function is not invoked on click.. I'm trying to figure it out

I've tried debugging the issue locally. The link's click event is fired after the page transition is complete and the button is already unmounted. That's why the analytics event is not fired.

Awesome, that's good to know. How did you find out that the event is fired only after the page transition?

I found a (somewhat hacky) solution: we can add a mousedown.native event to the VLink component, and use that for firing the analytics event.

Yea this one works, thank you!
@dhruvkb Should i commit the changes?

@obulat how does this work in VHomeGallery.vue?

I've tried debugging the issue locally. The link's click event is fired after the page transition is complete and the button is already unmounted. That's why the analytics event is not fired.

Awesome, that's good to know. How did you find out that the event is fired only after the page transition?

In the VLink component, I added a route watcher that logged when the route changed, and an onUnmounted that logged when the link was unmounted, with its href. Not the most optimal way of debugging, but it worked :)

In the VLink component, I added a route watcher that logged when the route changed, and an onUnmounted that logged when the link was unmounted, with its href. Not the most optimal way of debugging, but it worked :)

Wow, that's great! But as @dhruvkb said, how does the analytics event work as is in VHomeGallery.vue because there is also a page transition happening on click

@obulat how does this work in VHomeGallery.vue?

I think I found the answer to this. When you click on a link on the home page, you navigate to a different page that has a different layout. The same is true when you click on a page link from a search page. However, here, we stay in the same layout. This is the only difference between the events.

@obulat Does that mean that when navigating between base layouts, Vue is, for some reason, keeping the previous layout mounted behind the scenes until it finishes triggering the event? It's interesting that that is the only difference, but I'm super curious why having different layouts between the navigated pages causes the difference in behaviour... :thinking:

@obulat Does that mean that when navigating between base layouts, Vue is, for some reason, keeping the previous layout mounted behind the scenes until it finishes triggering the event? It's interesting that that is the only difference, but I'm super curious why having different layouts between the navigated pages causes the difference in behaviour... 🤔

Apparently, this is a regression that happened in Vue 2.7.x: https://github.com/nuxt/nuxt/issues/10593 and https://github.com/vuejs/vue/issues/12781. I think with a mousedown we have a good enough workaround and don't need to investigate further.

Hey @obulat ! I'm swamped right now and won't be able to write the unit tests for this PR. Thanks for offering to help out, though - please go ahead and take care of it.

Hey @obulat ! I'm swamped right now and won't be able to write the unit tests for this PR. Thanks for offering to help out, though - please go ahead and take care of it.

Thank you for quick response, @masif2002! I'll add tests, then. You are always welcome to contribute when you have more time 😃


HTI-1 US Core v6.1.0 giving terminology error on 2.20.08

We are receiving an error indicating incorrect SNOMED codes on Observation Pregnancy Intent Tests 2.20.08
Inferno Run
From our examination, it does appear we are sending a valid SNOMED code of<PHONE_NUMBER>24105.

Hello @jj027509 This is a know error on tx.fhir.org (see this zulip thread: https://chat.fhir.org/#narrow/stream/179202-terminology/topic/pregnancy-intent.20validation.20failure/near/394649688)
Inferno US Core Test Kit relies on tx.fhir.org (which is maintained by HL7) for terminology validation. Please see this FAQ about terminology validation errors (https://github.com/onc-healthit/onc-certification-g10-test-kit/wiki/FAQ#q-why-do-some-resources-fail-in-us-core-test-kit-with-terminology-validation-errors)
Inferno g10 Certification Test Kit uses its own terminology service which removes this dependency.

Yes. tx.fhir.org returns the same error on<PHONE_NUMBER>24108
https://tx.fhir.org/r4/ValueSet/us-core-pregnancy-intent/$validate-code?code=454411000124108&system=http://snomed.info/sct
You can reply to the zulip thread to let Grahame know the issue still exists.
While waiting for tx server to fix, you can just ignore the error if you are certain the code provided is correct (as in this case)

Will do, thank you!


Open current tab in N temporary containers

Container Opener only open current tab in all Already existing containers, however, I'd like to open current tab in 10 temporary containers.

Absolutely doable, but i don't have a clear picture how a good user workflow for this could look like. Suggestions?

Possiblities include:

Shortcuts + for N duplication (with N configurable on the option page)
Context Menu on the Tab (with sub entries for different duplication, configurable on the option page)
Shortcut or content enty that opens a new tab where the user can select from a set of duplication options (configurable on the option page)

Enough!

I take it, you'd be fine with either of the options. I'll see which one i can add in a timely manner.

https://github.com/igorlogius/open-in-temp-container/assets/67047467/9ec9fab6-d509-4e0d-a5b3-2936dc230c6c

Done


[Proposal] New Release Management Process

In v2.6.1 we pulled in a new copy of urllib3. Typically this doesn't negatively affect us but in this case we've seen a bunch of new issues from the chunked encoding refactor in urllib3. Because that kind of stuff should not break in a .x release I'm proposing we follow this process when preparing releases (and that we document it for the future):
For an v*.*.x release, e.g., v2.6.1, v2.6.2, v2.6.3, etc. we only include changes to requests itself. This means anything that does not live in requests/packages/{urllib3,chardet}/*.
For a v*.x.0 release, e.g., v2.6.0, v2.7.0, etc. we include changes to requests and update the vendored libraries. The same goes for a vx.0.0 release, but of course those have other implications as well.

+1. Write it down in the docs, let's make it so.

:cake: Will do tonight or tomorrow morning


npm run build:demo

Hi,
I forked the repo to make a few changes. But I am not able to run npm run build:demo. It throws this error: error Command failed with exit code<PHONE_NUMBER>.
Is there a way I could fix this? Or can I run it a different way?
Thank you.

Hi @blackpintz,
It looks like there was an issue with webpack, I've upgraded webpack on master and the issue should be resolved.
Let me know if this has resolved the issue for you.

Hi @JorgenEvens. The issue is resolved. Thank you.


Update ModLinks.xml

I want to add my floor is lava mod to the installer.

What can I do now?

the action says that the modlinks entry has the wrong SHA256


missing free ressource in set property

add 2 missing free on set property
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

last comit is a wrong push i will repush the first good commit


handle undefined routes (404)

Currently we just display a blank page (probably some javascript exceptioning somewhere).
We should either create a 404 page or redirect users to root.

wrong repo, recreated https://github.com/odota/ui/issues/167


(PDB-4315) ignore duplicates in resource_events

Adds more columns to the resource_events hash: timestamp, status,
old_value, new_value, message, file, line
Replaces the existing migration with a new migration that will rehash
the resource_events table again
Adds an ON CONFLICT DO NOTHING to do the resource_events insert-multi to
ignore any duplicate hashes found

Test PASSed

Test FAILed

CLA signed by all contributors.

Test PASSed

Test PASSed

Test PASSed

Test PASSed

Test PASSed

Test PASSed


Initial support for federated builder status

--jenkins-jobs can now include a name=src entry.
name is the name of the job.
src specifies the source for the output of builders
Limitations of initial implementation:

only gs:// URLs are supported as src (Google Cloud Storage).
all name=src entries are treated as non-gating, and
will not contribute to the overall build status.

For example:
--jenkins-jobs=kubernetes-e2e-aws=gs://kubernetes-buildlogs-aws/logs/kubernetes-e2e-aws

More for discussion at the moment, I believe.  But should work!
cc @ihmccreery

cc @kubernetes/goog-testing @kubernetes/sig-testing

Reworked this so that it is much cleaner: it now uses a set of JSON files in config/ which determine the builder jobs & GCS buckets to crawl.  Also in #520 I then parse the JUnit output, so we can see exactly which tests fail, amongst all sort of other goodies.
How can we get this actually running?  It would be great to be able to display AWS test results also...

submit-queue_test.go doesn't build. To get it live? Get it committed and ask me, @lavalamp, @mikedanese to kick off a new submit queue. I'm out until tuesday, but if CI is clean I can turn it up then.

Will fix e2e.  I have an idea though... what would it take to bring up "submit-queue-alpha.k8s.io" or "submit-queue-preview.k8s.io" in dry-run mode?

Will fix tests - sorry. I have a though though... what would it take to bring up "submit-queue-alpha.k8s.io" or "submit-queue-preview.k8s.io" in dry-run mode?
This PR is really just a UI change (well, the status that the mergebot uses for decision making is also reflected in the UI I believe, so we can test it in dry-run mode). And we likely have some other UI changes to come, because it isn't clear exactly how to display federated builds. Or the names of the failing tests.
What I'm thinking is that we could have a preview environment that automatically deploys from master. We can then experiment with UI changes, speed-ups etc, without risking breaking the merge queue.
I am happy to work on this... would it be a Jenkins job? (Do we have a jenkins job that does the deploy?)

It's not hard at all.
On Mon, Feb 29, 2016 at 7:46 AM, Justin Santa Barbara <
<EMAIL_ADDRESS>wrote:

Will fix e2e. I have an idea though... what would it take to bring up "
submit-queue-alpha.k8s.io" or "submit-queue-preview.k8s.io" in dry-run
mode?
—
Reply to this email directly or view it on GitHub
https://github.com/kubernetes/contrib/pull/467#issuecomment-190263198.

Sorry @lavalamp - I hit "Close and comment" in the middle of writing my comment by mistake.  Not sure if you saw the more complete idea of auto-deploying the dry-run version from master?  Do you think that's a good idea, and what work can I do to make it happen (should I write a batch file we can call from Jenkins?)

Oh, auto deploying in --dry-run might be interesting, but we might have concerns about running random code. @ixdy do you have any thoughts on that?

Only merged random code :-)  I do think it would be exciting if we could figure this out... would set us down an interesting road of dogfooding!

It needs to use a different secret/github-oauth token...

@eparis what if it didn't have a token at all...?

It needs a token even just for dry-run. @eparis wants it separate so it
doesn't count against our ratelimit (I assume).
On Tue, Mar 1, 2016 at 5:17 PM, Justin Santa Barbara <
<EMAIL_ADDRESS>wrote:

@eparis https://github.com/eparis what if it didn't have a token at
all...?
—
Reply to this email directly or view it on GitHub
https://github.com/kubernetes/contrib/pull/467#issuecomment-191005024.

It only gets 60 API calls per hour without a token. I don't think the code really runs at all without a valid token....

And yes, I would want a second token for the dry-run version as even at steady state I doubt the 5000 API calls per hour is adequate...

/cc @kubernetes/sig-testing

@eparis - do we have any estimated time for this PR to get in (and others from this set)? If it's not soon I'll need to hack something temporary around

What do we plan on doing with this PR? ping @justinsb @eparis

recomputing cla status...

closing as I don't think these are coming back in this form.


Notice: Undefined property: Symplify\EasyCodingStandard\SniffRunner\Fixer\Fixer::$enabled

Notice: Undefined property: Symplify\EasyCodingStandard\SniffRunner\Fixer\Fixer::$enabled in /home/gadelat/.composer/vendor-bin/ecs/vendor/squizlabs/php_codesniffer/src/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php on line 539

Call Stack:
    0.0002     374424   1. {main}() /home/gadelat/.composer/vendor-bin/ecs/vendor/symplify/easy-coding-standard/bin/ecs:0
    0.2875    8512168   2. Symplify\EasyCodingStandard\Console\Application->run() /home/gadelat/.composer/vendor-bin/ecs/vendor/symplify/easy-coding-standard/bin/ecs:52
    0.2877    8522120   3. Symplify\EasyCodingStandard\Console\Application->doRun() /home/gadelat/.composer/vendor-bin/ecs/vendor/symfony/console/Application.php:143
    0.2879    8522120   4. Symplify\EasyCodingStandard\Console\Application->doRunCommand() /home/gadelat/.composer/vendor-bin/ecs/vendor/symfony/console/Application.php:233
    0.2879    8522120   5. Symplify\EasyCodingStandard\Console\Command\CheckCommand->run() /home/gadelat/.composer/vendor-bin/ecs/vendor/symfony/console/Application.php:857
    0.2883    8593464   6. Symplify\EasyCodingStandard\Console\Command\CheckCommand->execute() /home/gadelat/.composer/vendor-bin/ecs/vendor/symfony/console/Command/Command.php:252
    0.2884    8593840   7. Symplify\EasyCodingStandard\Application\Application->run() /home/gadelat/.composer/vendor-bin/ecs/vendor/symplify/easy-coding-standard/src/Console/Command/CheckCommand.php:97
    0.4310   14478928   8. Symplify\EasyCodingStandard\Application\Application->processFoundFiles() /home/gadelat/.composer/vendor-bin/ecs/vendor/symplify/easy-coding-standard/src/Application/Application.php:96
    2.2958   28679184   9. Symplify\EasyCodingStandard\SniffRunner\Application\SniffFileProcessor->processFile() /home/gadelat/.composer/vendor-bin/ecs/vendor/symplify/easy-coding-standard/src/Application/Application.php:126
    2.3900   31730736  10. Symplify\EasyCodingStandard\SniffRunner\Application\SniffFileProcessor->processTokens() /home/gadelat/.composer/vendor-bin/ecs/vendor/symplify/easy-coding-standard/packages/SniffRunner/src/Application/SniffFileProcessor.php:146
    2.3941   31734912  11. PHP_CodeSniffer\Standards\Generic\Sniffs\WhiteSpace\ScopeIndentSniff->process() /home/gadelat/.composer/vendor-bin/ecs/vendor/symplify/easy-coding-standard/packages/SniffRunner/src/Application/SniffFileProcessor.php:190

I am encountering this error as well, on one particular file among other ~140 files. I tried to isolate and reproduce the issue with one file only, but failed. This looks like some more complex issue to debug, where a reference/property inside the Fixer object is lost somehow over time.
In my particular case, disabling PhpCsFixer\Fixer\Basic\BracesFixer causes to throw these notices (I wanted to let the CodeSniffer to do the thing)
My config:
imports:
    - { resource: 'vendor/symplify/easy-coding-standard/config/psr2.yml' }

parameters:
    exclude_checkers:
        - 'PhpCsFixer\Fixer\Basic\BracesFixer'

Problematic file (which kicks in at 55% progress):
<?php
	$maxPerColumn = 12;
	$hasVisibleChildren = $this->item->hasVisibleChildren($this->inheritAliased);
	$className = array();
	if ($this->first) $className[] = 'first';
	if ($this->last) $className[] = 'last';
	if ($this->item->isSelected()) $className[] = 'active';
	if ($this->item->class) $className[] = $this->item->class;
	if ($hasVisibleChildren) $className[] = 'has-children';
?>
<li<?= !empty($className) ? ' class="'.implode(' ', $className).'"' : '' ?>><a href="<?= $this->item->getUrl() ?>"<?= $this->item->isExternal() ? ' target="_blank"' : '' ?><?= $this->item->robots_noindex ? ' rel="nofollow"' : '' ?>><?= $this->item->name ?>
	<?php if($hasVisibleChildren): ?>
		<?php
			$children = $this->item->getVisibleChildren($this->inheritAliased);
			$categoriesCount = count($children);
			$columns = 1;
			if($categoriesCount > $maxPerColumn)
			{
				$columns = ceil($categoriesCount / $maxPerColumn);
			}
		?>
		<div class="main-nav-dropdown main-nav-dropdown-<?= $columns ?>">
			<?php for($i = 0; $i < $columns; $i++): ?>

					<?php $iterator = 0; ?>
					<?php $items = array(); ?>
					<?php foreach($children as $key => $child): ?>
						<?php $items[$key] = $child; ?>
					<?php endforeach; ?>
					<?php $items = array_slice($items, $i * $maxPerColumn, $maxPerColumn); ?>
					<?php $itemsCount = count($items); ?>
					<?php foreach($items as $item): ?>
						<?= $this->partial('menu/index/level-2.phtml', array(
							'item' => $item,
							'first' => !$iterator,
							'last' => $iterator == ($itemsCount - 1),
						)); ?>
						<?php $iterator++ ?>
					<?php endforeach; ?>

			<?php endfor; ?>

	<?php endif ?>

Error (shows 3 times for this one file):
λ ecs check application --config=easy-coding-standard-phtml.yml --show-performance
  55/109 [==============>-------------]  50%
Notice: Undefined property: Symplify\EasyCodingStandard\SniffRunner\Fixer\Fixer::$enabled in [...]\vendor\squizlabs\php_codesniffer\src\Standards\Generic\Sniffs\WhiteSpace\ScopeIndentSniff.php on line 539

Call Stack:
    0.0006     353176   1. {main}() [...]\vendor\symplify\easy-coding-standard\bin\ecs:0
    1.3161   10092024   2. Symplify\EasyCodingStandard\Console\Application->run() [...]\vendor\symplify\easy-coding-standard\bin\ecs:18
    1.3161   10092024   3. Symplify\EasyCodingStandard\Console\Application->run() [...]\vendor\symplify\easy-coding-standard\src\Console\Application.php:34
    1.3165   10097368   4. Symplify\EasyCodingStandard\Console\Application->doRun() [...]\vendor\symfony\console\Application.php:143
    1.3167   10097368   5. Symplify\EasyCodingStandard\Console\Application->doRunCommand() [...]\vendor\symfony\console\Application.php:241
    1.3168   10097368   6. Symplify\EasyCodingStandard\Console\Command\CheckCommand->run() [...]\vendor\symfony\console\Application.php:865
    1.3175   10102944   7. Symplify\EasyCodingStandard\Console\Command\CheckCommand->execute() [...]\vendor\symfony\console\Command\Command.php:252
    1.3181   10103168   8. Symplify\EasyCodingStandard\Application\Application->run() [...]\vendor\symplify\easy-coding-standard\src\Console\Command\CheckCommand.php:97
    1.4601   10505784   9. Symplify\EasyCodingStandard\Application\Application->processFoundFiles() [...]\vendor\symplify\easy-coding-standard\src\Application\Application.php:96
   10.0281   13463200  10. Symplify\EasyCodingStandard\Application\SingleFileProcessor->processFileInfo() [...]\vendor\symplify\easy-coding-standard\src\Application\Application.php:119
   10.0492   13463152  11. Symplify\EasyCodingStandard\SniffRunner\Application\SniffFileProcessor->processFile() [...]\vendor\symplify\easy-coding-standard\src\Application\SingleFileProcessor.php:83
   10.1129   13995176  12. Symplify\EasyCodingStandard\SniffRunner\Application\SniffFileProcessor->processTokens() [...]\vendor\symplify\easy-coding-standard\packages\SniffRunner\src\Application\SniffFileProcessor.php:147
   10.1137   13995256  13. PHP_CodeSniffer\Standards\Generic\Sniffs\WhiteSpace\ScopeIndentSniff->process() [...]\vendor\symplify\easy-coding-standard\packages\SniffRunner\src\Application\SniffFileProcessor.php:191

Hey, could you create new issue and try to isolate the sniff from psr2.yml that is causing this?
I have idea how to fix this, but the sniff is needed

Why don't you reopen this issue instead? Original issue was never solved anyway.

The issue is the same, without responsible sniff nothing can be done.

@TomasVotruba i thought about opening a new issue, but it seems that it is exactly the same issue as OP reported, so I tried to add more feedback to it.
The responsible sniff seems to be PHP_CodeSniffer\Standards\PEAR\Sniffs\WhiteSpace\ScopeIndentSniff and in my case the error is thrown under the following circumstances:

PhpCsFixer\Fixer\Basic\BracesFixer checker disabled
~140 files to check with this problematic file to be in the middle of the progress
I am sorry but I could not reproduce an isolated case with just this problematic file to be checked. So it seems to be more complex issue.


Support interpolation in CSS-based imports

$googlefonts:"Corben:bold|Ubuntu|Droid+Serif";
@import url("http://fonts.googleapis.com/css?family=#{$googlefonts}&subset=latin");

Should work.

I'm scaling back this feature in Sass 3.2 due to parsing concerns. The original implementation only worked when the interpolated string or url() was a valid string/url; this means that you couldn't include e.g. quotes or closing parentheses within the string/url (e.g. @import "#{"foo.css"}"). This is contrary to how interpolation worked everywhere else in Sass.
It needs to be easy for the user and the parser to tell whether a given @import is going to be static (compiling to a CSS @import) and when it's going to be dynamic (actually loading Sass from another file). Currently, there are three conditions that cause an import to be treated as static in Sass:

It uses url().
It begins with "http://".
It specifies a media query (e.g. @import "screen.css" screen).

If any of these are true for an @import, it will be static. As we only want to allow interpolation of static imports, we should only parse interpolation for these cases, and no others. However, it's not possible to know whether an @import has a media query until after the import string has been parsed, which will require parsing the interpolation, if there is any.
Thus, I'm restricting interpolation to @imports using url(). This will be done via the usual deprecation in the stable releases, with appropriate warnings and upgrade instructions. @imports with interpolation in strings will no longer work in the next release, Sass 3.2.

Any status on this? Why was this closed?

It was closed because the feature landed.

Oh in what version is this available?

3.1.0 and forward.

+1


Disjunction deduplication only keeps left-most attributes

What version of CUE are you using (cue version)?
in the playground, versions v0.5.1-0.20230413144408-f681271a38ec and v0.6.0-alpha.1.0.20230428121230-80d6ea032057
What did you do?
a: { @foo(1) }
b: { @bar(2) }

r: a | b

What did you expect to see?
Disjunction merges similar values, as per the a | a = a rule. However, when values differ, they are kept as a disjunction in the output. Here, a and b are different due to having different attributes, so i am expecting to still see a disjunction in the output.
a: { @foo(1) }
b: { @bar(2) }

r: { @foo(1) } | { @bar(2) }

What did you see instead?
The structs are deduplicated, and only the attributes of the left-most value in the disjunction are kept.
a: { @foo(1) }
b: { @bar(2) }

r: { @foo(1) }

My understanding is that attributes are not considered part of the value, therefore not considered when evaluating subsumption. However, this behaviour is undocumented in the language specification. I also wonder whether it would make sense to keep both sets of attributes when deduplicating values in a disjunction, since both values were a "match"?

@nicuveo - this is very good point, thank you for raising. Marking as "thinking" :)

One principle of attributes is that they may not influence CUE evaluation in any way (pre or post processing does not count as evaluation). For the expected behavior that would be the case, though.
That said, it is of course very unsatisfying that the set of attributes may differ depending on which disjunct wins.
I'm not sure what the correct solution is. Perhaps the most sensible thing to do is to merge the resulting attributes. So the result here would be:
r: { @foo(1) @bar(2) }

This would leave the disambiguation of the attribute to whoever interprets them. Note that it is allowed to have multiple attributes with the same "name", but different values.
I can imagine, however, that this will result in some useless combinations of attributes. cue vet could help here. As a general rule, disjunctions should have discriminator fields (like a kind field) or at the very least a default value. I suspect that would greatly mitigate such issues. cue vet could help users to verify that such disjunctions are structured properly.


feat: allow overriding AdministrationRole

Allow overriding AdministrationRole

remove @final
use AdministrationRoleFactory instead of new AdministrationRole();  in AdministratorAccessGranter

Merged! Thanks!


Callkit native UI for incoming call gets disappear once I click on answer button.

I am implementing Twilio call in an app developed in react native.
The incoming call is occuring properly and disconnect also happening if we lock the iphone.
When the device is unlocked the Incoming UI is coming but the UI disappears when I click on answer button.
I have opened a custom UI but the call is not getting disconnected when I click on the custom disconnect button.
How to disconnect the call properly?

Incoming push is received occassionally but when I call from other device the call is getting connected but the UI is not opening occassionally.

Hi @shreyapitangent

The incoming call is occuring properly and disconnect also happening if we lock the iphone.
This sounds like the known issue of using PushKit and React Native.

When the device is unlocked the Incoming UI is coming but the UI disappears when I click on answer button.
This is the design by Apple. It only stays in the native Call UI when the call is answered and the device is locked.

I have opened a custom UI but the call is not getting disconnected when I click on the custom disconnect button.
Please provide SDK log if the call is not properly disconnected when [TVOCall disconnect] is called.

Incoming push is received occassionally but when I call from other device the call is getting connected but the UI is not opening occassionally.
Can you describe more details about the steps (how the call is made) and the environment (is the app in the foreground or background or device locked). Please provide Twilio Call SIDs if you think the incoming push is not received.

Thanks,
-bobie

Hi,
During the outgoing call when I press the disconnect button on custom UI
the call is not getting disconnected.
The error showing the log is attached with screenshot with this mail.
Thanks
shreyapitangent
On Fri, 20 Mar 2020 at 21:48, bobiechen-twilio<EMAIL_ADDRESS>wrote:

Hi @shreyapitangent https://github.com/shreyapitangent
The incoming call is occuring properly and disconnect also happening if we
lock the iphone.
This sounds like the known issue of using PushKit and React Native.
When the device is unlocked the Incoming UI is coming but the UI
disappears when I click on answer button.
This is the design by Apple. It only stays in the native Call UI when the
call is answered and the device is locked.
I have opened a custom UI but the call is not getting disconnected when I
click on the custom disconnect button.
Please provide SDK log if the call is not properly disconnected when [TVOCall
disconnect] is called.
Incoming push is received occassionally but when I call from other device
the call is getting connected but the UI is not opening occassionally.
Can you describe more details about the steps (how the call is made) and
the environment (is the app in the foreground or background or device
locked). Please provide Twilio Call SIDs if you think the incoming push is
not received.
Thanks,
-bobie
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twilio/voice-quickstart-ios/issues/325#issuecomment-601786874,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO4JAAXHL7L7I3WCMQOLOUDRIOJOZANCNFSM4LQJIYIQ
.

Hi,
During the outgoing call when I press the disconnect button on custom UI the call is not getting disconnected.
The error showing the log is attached with screenshot with this mail.
Thanks
shreyapitangent

In outgoing call access token is generated still while placing call access token required error occurring.

Hi,
In outgoing call access token is generated still while placing call access
token required error occurring.
Thanks
shreyapitangent
On Fri, 20 Mar 2020 at 21:48, bobiechen-twilio<EMAIL_ADDRESS>wrote:

Hi @shreyapitangent https://github.com/shreyapitangent
The incoming call is occuring properly and disconnect also happening if we
lock the iphone.
This sounds like the known issue of using PushKit and React Native.
When the device is unlocked the Incoming UI is coming but the UI
disappears when I click on answer button.
This is the design by Apple. It only stays in the native Call UI when the
call is answered and the device is locked.
I have opened a custom UI but the call is not getting disconnected when I
click on the custom disconnect button.
Please provide SDK log if the call is not properly disconnected when [TVOCall
disconnect] is called.
Incoming push is received occassionally but when I call from other device
the call is getting connected but the UI is not opening occassionally.
Can you describe more details about the steps (how the call is made) and
the environment (is the app in the foreground or background or device
locked). Please provide Twilio Call SIDs if you think the incoming push is
not received.
Thanks,
-bobie
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twilio/voice-quickstart-ios/issues/325#issuecomment-601786874,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO4JAAXHL7L7I3WCMQOLOUDRIOJOZANCNFSM4LQJIYIQ
.

Hi @shreyapitangent
Based on the screenshot you will need to use a valid UUID to initialize a CallKit action. You should be able to find the value in the TVOCall object.
-bobie

Hi,
Call is getting established properly but disconnection is not
occurring properly when I am using a custom button.
The code I have used is stated below.
-(void)disconnect:(TVOCall *)call
{
_calluuid = [[NSUserDefaults standardUserDefaults]
      stringForKey:@"calluuid"];

NSLog(@"%@", _calluuid);
NSLog(@"%@", call);
// [call disconnect];
if (!self.userInitiatedDisconnect) {
     CXCallEndedReason reason = CXCallEndedReasonDeclinedElsewhere;

[*self*.callKitProvider reportCallWithUUID:call.uuid endedAtDate:[NSDate

date] reason:reason];
 [*self* callDisconnected:call];

 [*self* performEndCallActionWithUUID:_calluuid];

}
else
{
CXCallEndedReason reason = CXCallEndedReasonDeclinedElsewhere;

  [*self*.callKitProvider reportCallWithUUID:call.uuid endedAtDate:[

NSDate date] reason:reason];
 [*self* callDisconnected:call];

 [*self* performEndCallActionWithUUID:_calluuid];

}
}
Please suggest what I am doing wrong.
The call is getting disconnected properly when I am using native UI or the
lock button is pressed.
[TVOCall disconnect] method is not disconnecting the call.
Please suggest necessary steps.
Thanks and Regards
Shreya Sinha Roy
On Mon, 23 Mar 2020 at 22:46, bobiechen-twilio<EMAIL_ADDRESS>wrote:

Hi @shreyapitangent https://github.com/shreyapitangent
Based on the screenshot you will need to use a valid UUID to initialize a
CallKit action. You should be able to find the value in the TVOCall object.
-bobie
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twilio/voice-quickstart-ios/issues/325#issuecomment-602737684,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO4JAAXXTQJP32HQIWKOWNTRI6KNDANCNFSM4LQJIYIQ
.

Hi @shreyapitangen
For disconnecting the active call from the app UI, please follow this call flow in the quickstart: https://github.com/twilio/voice-quickstart-ios/blob/master/ObjcVoiceQuickstart/ViewController.m#L119

Hi,
While disconnecting the call with custom button it is not getting any uuid.
Response showing its nil and its not getting disconnected.
Thanks & Regards
shreyapitangent
On Tue, 24 Mar 2020 at 21:54, bobiechen-twilio<EMAIL_ADDRESS>wrote:

Hi @shreyapitangen
For disconnecting the active call from the app UI, please follow this call
flow in the quickstart:
https://github.com/twilio/voice-quickstart-ios/blob/master/ObjcVoiceQuickstart/ViewController.m#L119
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twilio/voice-quickstart-ios/issues/325#issuecomment-603345035,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO4JAAWENG7BK6OPARDDRW3RJDNFHANCNFSM4LQJIYIQ
.

Hi,
Sometimes
StartCallAction transaction request failed
error is happening occasionally while placing calls.
Thanks And Regards
Shreya Sinha Roy
On Tue, 24 Mar 2020 at 21:54, bobiechen-twilio<EMAIL_ADDRESS>wrote:

Hi @shreyapitangen
For disconnecting the active call from the app UI, please follow this call
flow in the quickstart:
https://github.com/twilio/voice-quickstart-ios/blob/master/ObjcVoiceQuickstart/ViewController.m#L119
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twilio/voice-quickstart-ios/issues/325#issuecomment-603345035,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO4JAAWENG7BK6OPARDDRW3RJDNFHANCNFSM4LQJIYIQ
.

Hi @shreyapitangent
Does the issue happen when using the quickstart with the same steps?
Can you provide more details about the error you saw when submitting the start call transaction?
-bobie

Hi,
Yes the issue is happening occasionally.
The function performStartCallActionWithUUID
is getting called and sometimes the StartCallAction transaction request
failed
error is coming.
Sometimes after successful transaction the disconnect method is not getting
called.

shreyapitangent https://github.com/shreyapitangent

On Thu, 26 Mar 2020 at 21:30, bobiechen-twilio<EMAIL_ADDRESS>wrote:

Hi @shreyapitangent https://github.com/shreyapitangent
Does the issue happen when using the quickstart with the same steps?
Can you provide more details about the error you saw when submitting the
start call transaction?
-bobie
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twilio/voice-quickstart-ios/issues/325#issuecomment-604514909,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO4JAAQLXKHRLWCXBJCY7WDRJN32TANCNFSM4LQJIYIQ
.

Hi,
Yes the issue is happening occasionally.
The function performStartCallActionWithUUID
is getting called and sometimes the StartCallAction transaction request
failed
error is coming.
Sometimes after successful transaction the didconnect method is not getting
called.
After 3-4 times sometimes the call is getting connected.
And the disconnection of call is not happening properly.

shreyapitangent https://github.com/shreyapitangent

On Fri, 27 Mar 2020 at 11:08, Shreya Sinha<EMAIL_ADDRESS>wrote:

Hi,
Yes the issue is happening occasionally.
The function performStartCallActionWithUUID
is getting called and sometimes the StartCallAction transaction request
failed
error is coming.
Sometimes after successful transaction the disconnect method is not
getting called.

shreyapitangent https://github.com/shreyapitangent

On Thu, 26 Mar 2020 at 21:30, bobiechen-twilio<EMAIL_ADDRESS>wrote:

Hi @shreyapitangent https://github.com/shreyapitangent
Does the issue happen when using the quickstart with the same steps?
Can you provide more details about the error you saw when submitting the
start call transaction?
-bobie
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twilio/voice-quickstart-ios/issues/325#issuecomment-604514909,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO4JAAQLXKHRLWCXBJCY7WDRJN32TANCNFSM4LQJIYIQ
.

Hi @shreyapitangent
Please provide the details (error code, SDK/app log) when the error happens.
Can you also try with the quickstart? I've used the quickstart to do the same steps but I was not able to reproduce the issue you are describing.

Hi,
I have implemented the steps stated in quickstart .
While placing a call I am directing the page to a custom UI.
Place call action is occurring from a button created through react native.
The function performStartCallActionWithUUID
is getting called and sometimes the StartCallAction transaction request
failed
error is coming.
Sometimes after successful transaction the didconnect method is not getting
called.
After 3-4 times sometimes the call is getting connected.
And the disconnection of call is not happening properly.
-shreyapitangent
On Fri, 27 Mar 2020 at 11:48, bobiechen-twilio<EMAIL_ADDRESS>wrote:

Hi @shreyapitangent https://github.com/shreyapitangent
Please provide the details (error code, SDK/app log) when the error
happens.
Can you also try with the quickstart? I've used the quickstart to do the
same steps but I was not able to reproduce the issue you are describing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twilio/voice-quickstart-ios/issues/325#issuecomment-604834711,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO4JAAQAEU2FH73MV52EGZDRJRAJZANCNFSM4LQJIYIQ
.

Hi @shreyapitangent
Please check the error in the completion block when you submit the start-call transaction in the performStartCallActionWithUUID method. You should find the reason why the transaction failed and we can use the information to help you debug.
For disconnecting the call:

Follow this call flow if you are disconnecting from your app UI
Follow this call flow if the call is disconnected from the system Call UI or disconnected by the remote party.

Hi
Please send code link in Objective C.
-shreyapitangent
On Fri, 27 Mar 2020, 9:53 pm bobiechen-twilio<EMAIL_ADDRESS>wrote:

Hi @shreyapitangent https://github.com/shreyapitangent
Please check the error in the completion block when you submit the
start-call transaction in the performStartCallActionWithUUID method. You
should find the reason why the transaction failed and we can use the
information to help you debug.
For disconnecting the call:

Follow this call flow
https://github.com/twilio/voice-quickstart-ios/blob/master/SwiftVoiceQuickstart/ViewController.swift#L142
if you are disconnecting from your app UI
Follow this call flow
https://github.com/twilio/voice-quickstart-ios/blob/master/SwiftVoiceQuickstart/ViewController.swift#L548
if the call is disconnected from the system Call UI or disconnected by the
remote party.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twilio/voice-quickstart-ios/issues/325#issuecomment-605092245,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO4JAATKQOLOCT4VIZVXXOTRJTHGJANCNFSM4LQJIYIQ
.

Hi @shreyapitangent
You should be able to find the Obj C equivalent in the repo: https://github.com/twilio/voice-quickstart-ios/tree/master/ObjcVoiceQuickstart


UnimplementedError:  Fused conv implementation does not support grouped convolutions for now.

I got the same error on OS X 12.1 as well as on Google CoLab Pro.
OS X
tf.version
'2.5.0'
CoLab
tf.version
2.6.0
---------------------------------------------------------------------------
UnimplementedError                        Traceback (most recent call last)
<ipython-input-9-03c7f065910f> in <module>
----> 1 history = model_train.train(dataset, initial_epoch=0)

~/Efficient-CapsNet/models/model.py in train(self, dataset, initial_epoch)
    178         print('-'*30 + f'{self.model_name} train' + '-'*30)
    179
--> 180         history = self.model.fit(dataset_train,
    181           epochs=self.config[f'epochs'], steps_per_epoch=steps,
    182           validation_data=(dataset_val), batch_size=self.config['batch_size'], initial_epoch=initial_epoch,

~/anaconda3/envs/ai/lib/python3.8/site-packages/tensorflow/python/keras/engine/training.py in fit(self, x, y, batch_size, epochs, verbose, callbacks, validation_split, validation_data, shuffle, class_weight, sample_weight, initial_epoch, steps_per_epoch, validation_steps, validation_batch_size, validation_freq, max_queue_size, workers, use_multiprocessing)
   1181                 _r=1):
   1182               callbacks.on_train_batch_begin(step)
-> 1183               tmp_logs = self.train_function(iterator)
   1184               if data_handler.should_sync:
   1185                 context.async_wait()

~/anaconda3/envs/ai/lib/python3.8/site-packages/tensorflow/python/eager/def_function.py in __call__(self, *args, **kwds)
    887
    888       with OptionalXlaContext(self._jit_compile):
--> 889         result = self._call(*args, **kwds)
    890
    891       new_tracing_count = self.experimental_get_tracing_count()

~/anaconda3/envs/ai/lib/python3.8/site-packages/tensorflow/python/eager/def_function.py in _call(self, *args, **kwds)
    948         # Lifting succeeded, so variables are initialized and we can run the
    949         # stateless function.
--> 950         return self._stateless_fn(*args, **kwds)
    951     else:
    952       _, _, _, filtered_flat_args = \

~/anaconda3/envs/ai/lib/python3.8/site-packages/tensorflow/python/eager/function.py in __call__(self, *args, **kwargs)
   3021       (graph_function,
   3022        filtered_flat_args) = self._maybe_define_function(args, kwargs)
-> 3023     return graph_function._call_flat(
   3024         filtered_flat_args, captured_inputs=graph_function.captured_inputs)  # pylint: disable=protected-access
   3025

~/anaconda3/envs/ai/lib/python3.8/site-packages/tensorflow/python/eager/function.py in _call_flat(self, args, captured_inputs, cancellation_manager)
   1958         and executing_eagerly):
   1959       # No tape is watching; skip to running the function.
-> 1960       return self._build_call_outputs(self._inference_function.call(
   1961           ctx, args, cancellation_manager=cancellation_manager))
   1962     forward_backward = self._select_forward_and_backward_functions(

~/anaconda3/envs/ai/lib/python3.8/site-packages/tensorflow/python/eager/function.py in call(self, ctx, args, cancellation_manager)
    589       with _InterpolateFunctionError(self):
    590         if cancellation_manager is None:
--> 591           outputs = execute.execute(
    592               str(self.signature.name),
    593               num_outputs=self._num_outputs,

~/anaconda3/envs/ai/lib/python3.8/site-packages/tensorflow/python/eager/execute.py in quick_execute(op_name, num_outputs, inputs, attrs, ctx, name)
     57   try:
     58     ctx.ensure_initialized()
---> 59     tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name,
     60                                         inputs, attrs, num_outputs)
     61   except core._NotOkStatusException as e:

UnimplementedError:  Fused conv implementation does not support grouped convolutions for now.
	 [[node Efficinet_CapsNet_Generator/Efficient_CapsNet/primary_caps/conv2d/BiasAdd (defined at /Users/davidlaxer/Efficient-CapsNet/utils/layers.py:129) ]] [Op:__inference_train_function_3601]

Function call stack:
train_function

I also tried running on tensorflow-metal w/GPU ... machine unresponsive ... had to reboot.

Already covered in previous issues ----> #1 #8

It's currently running on CoLab with the GPU.
The code didn't recognize the CoLab TPU.


Keep logon account for snclient Windows service

On version 0.03 I configured the snclient Windows service to run with a different user. (Services > snclient Properties > Log On)
After upgrading to version 0.04 this configuration was lost and reverted back to default "Local system account".
Is it possible to keep this setting on version upgrades?

How did you upgrade? Installing via MSI?

First I installed version 0.03 from msi package. Then configured the LogOn Account. Restarted the snClient service. Then installed version 0.04 from msi package. The LogOn account was then reset to default System account.

the service is tied to the msi installer, if you install the msi, the default service will be installed. Always. I didn't find a workaround.
The service definition is here:
https://github.com/ConSol-Monitoring/snclient/blob/main/packaging/windows/snclient.wxs#L35-L53
For now i give up, but i open to suggestions and pull requests which improve the service installation.

You could have public properties for the service account that can be set on calling the .msi file like here:
https://stackoverflow.com/questions/51787967/wix-serviceinstall-specify-account
I am not really familiar with wix - but maybe this works.

I found two more StackOverflow links regarding this:
https://stackoverflow.com/a/57517308/1595345
https://stackoverflow.com/q/2228855/1595345
I can verify that adding the  tag works to prevent overwriting the service definition on upgrade. I just don't know enough about wix to tell if everything from the first link is needed.

Thanks for that one, i gonna have a look. Sounds promising.

the problem with that approach is, that the installer does not handle the service anymore but needs to stop the service in order to replace the snclient.exe
This leads to this ugly dialog during the update:

Then i tried to move the creation and removal of the service completely from the msi into pre/post hooks. But i wasn't able to start any hook before the dialog above pops up.
The order of steps is listed here:
https://learn.microsoft.com/en-us/windows/win32/msi/suggested-installexecutesequence
Hooks can be run between InstallInitialize and InstallFinalize.
But it seems like this dialog can be suppressed by setting MSIRESTARTMANAGERCONTROL=Disable.

implemented in cc5501ff9f0f7e1f6796077e9be8cb9ac172c8d4


Roadmap styling & allcontributors

Related: #38

Styled the README roadmap with table, emojis, and Nuget badges
Added the contributors with the "All Contributors Specification"

Additional contributors badge 🚀

@LPeter1997 Make sure to install all-contributors bot

@all-contributors please add @FP5i  for doc, infra

@all-contributors please remove @lucyelle


Vacation Air A20N LIVERY REQUEST

🔗 Upload or paste a link to the CSL file(s) that you want me to add.
https://modsfire.com/C48O6g1rfglb51G
⚠ I need you to provide the files, as I do not make them myself. I will only add files that are repaints of models that are already in the package.
🛑 You grant me a license to redistribute the files, and you affirm that you have the legal right to grant that license under copyright law.
✈ Write here the corresponding aircraft and airline ICAO codes.
Aircraft: A20N
Airline: Vacation Air
Airline ICAO: VAE

You are not lucky with the windows.
In the .zip there is all your fleet.

BB_VACATIONAIR_VA.zip


no ChamferDistance function

Description
I am trying to use the ChamferDistance function from the cellshape_cloud.vendor.chamfer_distance module, but it appears that the chamfer_distance directory is empty or the function is not present.
The cellshape_cloud.vendor.chamfer_distance is empty, leading to an ImportError when attempting to import ChamferDistance.
Can I use this onechamfer_distance?

Hi @xu-ziwei,
Yes, you can use that. Or, alternatively, use the ChamferLoss here


Core || Quantization || Develop the routines to perform scalar quantization

Description
Acceptance criteria
Context

Checkpoint 28-Aug-2024
We have built the core primitives for 2 bit (Quaternary) and 3 bit (Octal) quantization. The integration with the ingestion of vector embedding and building of the HNSW index is pending. We do not have a projection for the completion as we do not have assigned resources for this issue.


[Tracker] Bug Catalog

This is just a place to track bugs which we think are interesting/juicy in frontends and the calyx ecosystem more broadly.
Dahlia

The frontend currently generates parallel conflicts when unrolling
Dahlia (or Relay) is generating non-unrolled code which has par conflicts (softmax, conv2d)

TVM code
Currently investigating issues with interpreting some of the TVM generated code (lenet and maxpool2d are specific examples). Probably warrants separate issues for both, but it's currently unclear whether this an interpreter error or something else entirely.

Out-of-bounds memory access
exp overflow (#505)

TCAM

Combination uses of sub-components

Interpreter (??)

~Softmax produces incorrect values~. Resolved: an error in the interpreter's fp_div implementation.

~Further investigation suggests that this might in fact be an error with the verilog implementation of fixed point division~

Great; thanks for getting this started! To elaborate on the TVM bug example, the concrete symptom is an out-of-bounds memory access, right? (Or are there other issues?)
Other bugs I can recall discussing being part of this catalog (I cannot guarantee I have remembered every time I have said "that's a bug! please add it to the catalog"):

The Dahlia frontend's conflicting memory accesses
The complicated problem with combinational uses of components in the TCAM implementation

Just want to pop in and say I still think #505 will play a role in the (incorrect) output of lenet (and any program that tries to softmax some large numbers).

@EclecticGriffin should we close this for now?

Yeah I think closing this for the moment is fine


couldn't find a valid model for Hoardable::RichText association

Thanks for this gem! It's the first versioning gem I find which covers tracking changes to Action Text 👍
I followed the README instructions but encounter these errors, what might I be doing wrong? Using Rails 7.0.8 and Hoardable 0.14.2.
NameError: Rails couldn't find a valid model for Hoardable::RichText association. Please provide the :class_name option on the association declaration. If :class_name is already provided, make sure it's an ActiveRecord::Base subclass.
from /opt/homebrew/lib/ruby/gems/3.3.0/gems/activerecord-7.0.8/lib/active_record/reflection.rb:441:in `rescue in compute_class'
Caused by NameError: uninitialized constant Page::Hoardable::RichText
from /opt/homebrew/lib/ruby/gems/3.3.0/gems/activerecord-7.0.8/lib/active_record/inheritance.rb:259:in `compute_type'

Also the IDE (IntelliJ) complains that hoardable isn't recognized.

Thanks for the report! I just merged a couple commits related to this.
You are getting that "couldn't find a valid model" because of a chicken or the egg scenario, where we need to wait until ActionText is loaded before we can load the Hoardable subclass versions, but nothing in your code is autoloading ActionText prior to the first hoardable has_rich_text call.
Regarding your IDE - I don't know if there's a good cross-LSP-server-compatible way for me to merge in another known option for has_rich_text. If that irks you enough, I just introduced has_hoardable_rich_text that you could use instead.
I haven't released a new version for the updates in the last month, so for now you can update your Gemfile to:
gem "hoardable", "~> 0.15", github: "waymondo/hoardable"

Let me know if you still run into issues related to this.

closing as this should be fixed now, and 0.15 has been released to rubygems. feel free to re-open if you are still having trouble with this


Class based views addition to advanced testing topics

Small addendum to show how to test CBV with request from request
factory

^

merged in a17216646adaaa909fe52a4e974b56b4f094fc72, thanks.


No Profits chart

The profits chart showing how the agent is learning/improving isn't displayed.

Actually is this a @walkah or @pabloboerr issue? Feel free to reassign!


[Catalog] Overview page should show all types of catalog items

Desired State of the Meshery.io site

The meshery.io/catalog landing page should show all types of catalog items.
The total number displayed should be paginated and limited to 50 per page.

Contributor Resources
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

@lee 1. is done after this PR gets merged

Is pagination still a to-do item?

@asubedy make a call for help?

Yes I'll make an issue for the pagination. I can't seem to figure it out.

Closing this issue, 1 is complete 2 is being tracked in https://github.com/meshery/meshery.io/issues/732


Add bundle to bag serializer

➤ David Steinberg commented:
Although not a part of the DOS spec, we might demonstrate how bdbags can be serialized from DOS bundles dynamically in this lambda.


Separating JSON Schema into multiple schemas

Many thanks for submitting your Pull Request :heart:!
Please specify parts this PR updates:

[x] Specification
[ ] Examples
[x] Schema
[ ] Roadmap
[ ] Use Cases
[ ] Community
[ ] Website
[ ] SDK
[ ] TCK
[ ] Other

What this PR does / why we need it:
Currently we have one big schema for the entire workflow definition.
At times users might want to validate against just the reusable function/events definitions.
This just separates the schema into multiple files (workflow.json, events.json, functions.json, and common.json) which makes this possible.
Special notes for reviewers:
Additional information (if needed):

This should be merged after https://github.com/cncf/wg-serverless-workflow/pull/30 and https://github.com/cncf/wg-serverless-workflow/pull/34


Need YAML support for test TC-ACL-2.10

Feature description
Need YAML support/syntax for testcase TC-ACL-2.10
Step 14: If DUT is an app on host, examine persistent storage in /tmp/chip_kvs text file

Platform
all
Platform Version(s)
No response
Anything else?

This is not a reasonable test step; storage details are subject to change and are not something test plans can mandate.  @manjunath-grl


Huawei Doc Title Updates

Removing Huawei Cloud prefix for each component to reduce the long component naming. Huawei Cloud will only be shown in the title of the parent documentation page.

You can maybe consider Huawei instead of Huawei Cloud to make it a little bit shorter

Sorry we cannot do this as the titles are too generic, eg Simple Notification System. You must have Huawei as prefix, eg we have Google, AWS, Azure for the other cloud providers.

Yes, I think you are right. Will update the PR

merged


Simulate each pixel with a rigid body?

How is the collision between pixel particles and rigid bodies achieved?

My implementation is based off of the ideas that Petri Purho (one of the Noita devs) explained in their talk "Exploring the Tech and Design of Noita" (5:42 to 9:17).
If you don't get something I explain here, there's a chance that their talk will clear it up for you.
Basically there's three different simulations:
- The pixel-based sand/liquid/solid simulation ("falling sand")
- The particle simulation (not covered deeply here)
- The RigidBody simulation
RigidBody simulation
Let's say you have a bunch of pixels you want to be a rigidbody:

The game has to generate a mesh for the rigidbody, which takes a few steps:
First, the image is run through an algorithm called "Marching Squares"-
This algorithm basically takes in an image and spits out one or more outlines depending on if there are holes in the shape.
In the end, the physics engine (in this case Box2D) wants the mesh to be a bunch of triangles, so you need to use a triangulation algorithm to turn the outline into triangles. In this case, I'm using the PolyPartition library.
Consider the result you get by directly plugging the result of Marching Squares into PolyPartition:

Notice how the result has a very unnecessarily large amount of triangles (284!).
This is because the output of Marching Squares is generally pixel-perfect, so you get a lot of 90 degree angles.
Having this many tris is bad for performance, so before converting the mesh into triangles, we need to simplify the mesh.
I am using something called the Douglas-Peucker algorithm, which takes a mesh and "smooths it out".
Here's the result of doing Marching Squares -> Douglas-Peucker -> PolyPartition:

Notice that there's way fewer triangles (only 85)!
The final mesh doesn't perfectly match the input image, but it's not super important as long as it's very close.
These triangles can now be used to create a RigidBody in Box2D.
Interaction with pixel simulation
Obviously, having one RigidBody is useless unless it can collide and interact with the world.
In order to combine the Box2D simulation with the falling sand simulation, there's a few steps:
For solid pixels, a mesh is generated in the same way as for a RigidBody (Marching Squares -> Douglas-Peucker -> PolyPartition).
These "world meshes" are added to the Box2D simulation (result shown in red here):

Whenever something in the world changes, the world meshes need to be regenerated.
In my case the world meshes are generated and stored per-chunk (black grid in the picture above) so that it only has to regenerate the chunk that changed.
Another trick is that you only need to generate & regenerate world meshes when they're within a range of a rigidbody, since the world mesh is not used for player collision (in Noita and in my game player collision is pixel-perfect and is a completely separate system).
Up to here, the RigidBody will collide with solid pixels, but will completely ignore sand/liquid.
In order for sand/liquid to land on the RigidBody, at the beginning of each tick, every pixel of each RigidBody gets put into the "falling sand" simulation as a solid pixel.
The "falling sand" simulation is then ticked, and each RigidBody gets their pixels taken out of the "falling sand" simulation.
In order for a RigidBody to displace sand/liquid, at the end of each tick, each RigidBody calculates the position of every one of its pixels in the world.
If the pixel at that position is sand or liquid, it takes it out of the "falling sand" simulation and moves it into the "particle" simulation, and in my case, it dampens the RigidBody's velocity so it slows down.

So that's more or less everything.
The only (major) thing I left out was how to get the individual RigidBody pixels to interact with/act like the "falling sand" pixels (eg. have a RigidBody that catches fire), since I'm still only like halfway done implementing this myself.
Hopefully the rest was somewhat coherent.
Feel free to ask any more questions.
This repo/project should become open source soon so you'll be able to look at my (not very clean) code and maybe get more out of it.
Once it goes open source, I also want to make a bunch of GitHub Pages to document the algorithms I'm using more completely so it might be useful for people.

Thank you for giving such a detailed answer.At first I wanted to use Java to restore this project, but now I think there is some trouble.

How did you get PolyPartition to work fine with geometry that has holes? My results are quite unfortunate :(

Oh nevermind. I was using ear clipping and that had horrible results :) For anyone else wondering, Triangulate_MONO is quite good at handling holes, even though it creates a bunch of unnecessary triangles.

You can use Triangulate_EC with holes, you just need to call RemoveHoles first.
Something like this:
std::list<TPPLPoly> src;
// fill out src with polys

TPPLPartition part;
std::list<TPPLPoly> dst1;
std::list<TPPLPoly> dst2;

part.RemoveHoles(&src, &dst1);
part.Triangulate_EC(&dst1, &dst2);

The issue is that rigid bodies can also reside within a hole, so the only option for me is to use Triangulate_MONO. The issue now is that I seem to have found a bug within the PolyPartition library ...

Sorry I seem to have misunderstood your answer. Are you able to get the result you posted above (the star with the holes), by using Remove holes then ear clipping?

I'll just add for reference in case anyone else find this, polypartition doesn't automatically detect holes (except for Triangulate_MONO).
When you're making the TPPLPolys you have to call SetHole to mark them as such in order for RemoveHoles to work.
I should have included this in my example from before, but to continue it, when you're filling out src you could do something like this:
for(int i = 0; i < myNumberOfPolys; i++){
  TPPLPoly poly;

  // make the poly

  if(poly.GetOrientation() == TPPL_CW) {
      poly.SetHole(true);
  }

  src.push_back(poly);
}

Thanks for your help

np, glad I could help!


add caching for SWIG on Travis/appveyor

Given that the swig download seems to fail periodically, particularly when we are trying to get a release out.  SWIG should be cached so we are not dependent on the download site for all tests.

@nightlark  is this completed?

I think so. I'm waiting until the next commit to develop and tomorrow's cron job run to make sure the caches are updated. Also not sure that Appveyor's caching works -- we might need to host our own copy of the file.

Caching is also working on Appveyor.


adding a reastart policy to the container

this is more a suggestion not an issue
add a restart policy to the docker-compose.yml
i tried to add a restart: unless-stopped at the end of the file but it throws error when i docker-compose up -d
ERROR: yaml.scanner.ScannerError: while scanning for the next token
found character '\t' that cannot start any token
  in "./docker-compose.yml", line 20, column 21

actually i think it throws error whenever i try to add anything in to the file and "break" its structure?
i added a restart policy by  sudo docker update  --restart unless-stopped container_name
and
sudo docker inspect container_name tells me
 "RestartPolicy": {
                "Name": "unless-stopped",
                "MaximumRetryCount": 0
            },

so i'm guessing its applied
keep up

Hi, can you check for SPACES vs. TABS consistency in your docker-compose.yml file?

Hi, can you check for SPACES vs. TABS consistency in your docker-compose.yml file?

That was it
I had used tabs
Added restart policy using spaces and it recreated fine without errors
Thanks again


custom bg

can u make a video on explain how correctly change bg

Please, it can be SOOOO apreciate 😁

can u make a video on explain how correctly change bg

simple you just need to put   background-image: url();   background-position: center;   background-size: cover;   background-attachment: fixed; }


feat: added custom tailwind config  and values component updated

Core values

Create core values section of homepage
Open dev Tools -> Ctrl + Shit + M  -> To view on smaller devices
demo

@amanuela97 please make sure visually it looks same as on Figma: fonts, position of text, etc.

@amanuela97 please resolve the conflict

@amanuela97 check demo on desktop. Does it look OK to you? Please use some of TailwindUI components, that are responsive. Make it look good on desktop.

should position of text be same on dekstop as in mobile ?


Shadow service manager

This PR introduces the ShadowServiceManager type, which decouple shadow service management from the controller.
closes #426
Co-authored By: Harold Ozouf<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closed/Reopened to retrigger failed checks/CI


[core-rest-pipeline] Fix issue with afterPhase policies getting run later than expected

Packages impacted by this PR
@azure/core-rest-pipeline
Describe the problem that is addressed by this PR
Policies using 'afterPhase' would get executed later than expected due to noPhase not getting run again until the full phase walk finished.
Are there test cases added in this PR?
Yes

API change check
API changes are not detected in this pull request.


[dask] Distributed training is VERY slow

Description
I have many Linux machines, every machine has A100 GPU *8, 128 threads per machine.
I found a problem thesedays in DaskLGB:

Fastest plan is using 1 machine 1*GPU (single mode), 8 threads. Running time=2.5min. Use 1300m GPU memory.
Slow plan is using 1 machine 2*GPU (local distribution mode), 8 threads per machine, the more GPUs, the slower the speed. Running time=4min. Use 1100m+700m memory in 2 GPUs.
VERY SLOW plan is 2*machine, every machine only 1 GPU, 8 threads per machine. It is too slow to use. Running time=30min. Use 1100m+700m memory in 2 GPUs.

I used the Dask command line to build a distributed system, doc: https://docs.dask.org/en/latest/how-to/deploy-dask/cli.html
So I'm very confuse that what is the significance of the existence of distributed DaskLGB??
Faster? NO
Saving GPU memory? NO
So have you encountered this problem when using multi-machine distributed LGB?
Environment info
LightGBM version or commit hash: 3.2.1(gpu)

`client = Client(address='xxx.xxx.xxx.xxx:12345')  # this is the scheduler ip
params = {
        'n_estimators'       : 1500,
        'objective'          : 'rmse',
        'reg_lambda'         : 0.3731450715226679,
        'reg_alpha'          : 0.30424044277458473,
        'subsample'          : 0.6413363492779808,
        'learning_rate'      : 0.013556055988623302,
        'min_child_weight'   : 91,
        'max_bin'            : 63,
        'random_state'       : 1111,
        'device_type'        : 'gpu',
        'colsample_bytree'   : 0.4237786478391063,
        'gpu_use_dp'         : False,
        'metric'             : 'None',
        'min_data_in_leaf'   : 880,
        'first_metric_only'  : True,
        'num_leaves'         : 248,
        'max_depth'          : 9,
        'verbosity'          : -1,
        }
model = lgb.DaskLGBMRegressor(client=client, **params)
print(f'X_train.shape={X_train.shape}   y_train.shape={y_train.shape}')

print(f'Process X to dask.array')
X_train = dask.array.from_array(X_train, chunks=(100000,3095)); X_train.compute() ; print(f'type(X_train)={type(X_train)}  X_train.shape={X_train.shape}')
y_train = dask.array.from_array(y_train, chunks=(100000,)); y_train.compute() ; print(f'type(y_train)={type(y_train)}  y_train.shape={y_train.shape}')

st = datetime.datetime.now()
print(f'Training start time:{st}')
model.fit(X_train, y_train)
et = datetime.datetime.now()
print(f'Training end time: {et}')
print(f'Running cost: {et-st}')`

@chixujohnny thanks for using LightGBM!
Right now the dask interface doesn't directly support distributed training using GPU, you can subscribe to #3776 if you're interested in that. Are you getting any warnings about this? I think it probably isn't using the GPU at all.
Furthermore, if your data fits in a single machine then it's probably best not using distributed training at all. The dask interface is there to help you train a model on data that doesn't fit on a single machine by having partitions of the data on different machines which communicate with each other, which adds some overhead compared to single-node training.

@jmoralez Thanks for your reply.
I find the problem now.
The GPU is really working, not CPU mode.
Using command to watch:  watch -n 1 nvidia-smi
To sovle this promblem, just using dask-cuda package.
Please see this doc to deploy your worker: https://docs.rapids.ai/api/dask-cuda/nightly/api.html
Just using command: dask-cuda-worker xxx.xxx.xxx.xxx:9876
Instead of: dask-worker xxx.xxx.xxx.xxx:9876
But, compare with dask-cude XGB, it is more usable than LGB. But it won't be particularly obvious.

Thanks for the follow up @chixujohnny. Were you able to train faster using dask-cuda workers?

Thanks for the follow up @chixujohnny. Were you able to train faster using dask-cuda workers?

Faster, but slower than 1 GPU mode.
I use 1 machine + 2 GPUs + LocalCUDACluster mode.

Thanks for the follow up @chixujohnny. Were you able to train faster using dask-cuda workers?

By the way, in a normal situation, when I training a regression job on only 1GPU. What is the useage rate of GPU?  On nvidia-A100 or nvidia-V100 GPU, the useage just 35%. It’s not like XGB has 100% usage. Is this normal?

On nvidia-A100 or nvidia-V100 GPU, the useage just 35%. Is this normal?

LightGBM's existing CUDA-based implementation does some work on the GPU and some on CPU (https://github.com/microsoft/LightGBM/issues/4082#issuecomment-948233113), which is why you might not see high GPU utilization.
This is a known issue, and @shiyu1994 and others are working on it. I recommend subscribing to updates on the following PRs to track the progress on a new implementation that should better-utilize the GPU:

#4528
#4630

The reviews on those pull requests are going to get quite large, so if you have questions about the plans please open new issues here that reference them, instead of commenting on the PRs directly.

On nvidia-A100 or nvidia-V100 GPU, the useage just 35%. Is this normal?

LightGBM's existing CUDA-based implementation does some work on the GPU and some on CPU (#4082 (comment)), which is why you might not see high GPU utilization.
This is a known issue, and @shiyu1994 and others are working on it. I recommend subscribing to updates on the following PRs to track the progress on a new implementation that should better-utilize the GPU:

WIP: [CUDA] New CUDA version #4528
[CUDA] New CUDA version Part 1 #4630

The reviews on those pull requests are going to get quite large, so if you have questions about the plans please open new issues here that reference them, instead of commenting on the PRs directly.

Thank you very much~