Kirkstone: Build fails at secure-core-minimal-image.bb:do_rootfs

I am trying to build the secure-core-minimal-image with only UEFI_SB and UEFI_SELOADER enabled.
The build fails at do-rootfs with this error:
Error: Transaction test error:
  file /boot/efi/EFI/BOOT/bootx64.efi conflicts between attempted installs of seloader-0.4.6+git0+8b90f76a8d-r0.corei7_64 and shim-12+git0+5202f80c32-r0.corei7_64

If I add MOK_SB, the build succeeds.
This is my configuration:
INIT_MANAGER = "systemd"
DISTRO_FEATURES_NATIVE:append = " systemd tpm tpm2 efi-secure-boot"
DISTRO_FEATURES:append = " systemd tpm tpm2 efi-secure-boot modsign"

EFI_PROVIDER = "grub-efi"

SIGNING_MODEL := "user"
require conf/distro/secure-boot/user-keys/keys.conf

DEBUG_FLAGS:forcevariable = ""
IMAGE_INSTALL:append = " kernel-image-bzimage"
GRUB_SIGN_VERIFY = "0"
UEFI_SB = "1"
UEFI_SELOADER = "1"
MOK_SB = "0"

Is this a supported combination? The README mentions running SELoader without MOK secure boot, and, looking at the shim and seloader .bb files, i see that SELoader only installs it's .efi file as bootx64.efi if UEFI_SB is active and MOK_SB is not, which supports that assumption.
shim on the other hand only checks UEFI_SB to see whether it should install signed or unsigned binaries, but always assumes it will be the bootx64.efi.

This looks like bug to me, but I'm not entirely certain as to what things should look like.
I'm guessing that either:

SELoader is missing a condition for installing itself as bootx64.efi,
or shim should not be built in the first place.

In the latter cased, I think the fix would look something like this:
meta-efi-secure-boot/recipes-base/packagegroups/packagegroup-efi-secure-boot.bb:
SELOADER_PKG = "${@'seloader' if d.getVar('UEFI_SELOADER') == '1' else ''}"
SHIM_PKG = "${@'' if d.getVar('UEFI_SELOADER') == '1' and d.getVar('MOK_SB') != '1' else 'shim'}"
ALLOW_EMPTY:${PN} = "1"

pkgs = "\
    grub-efi \
    efitools \
    efibootmgr \
    mokutil \
    ${SELOADER_PKG} \
    ${SHIM_PKG} \
"

I patched my packagegroup-efi-secure-boot.bb like this and got a bootable image out of it.
I can't currently test this on scarthgap (our board vendor is being difficult), but the relevant code looks unchanged, so I'm guessing that branch is in the same boat.

Hi, Can you try the above patch ? Thanks.

I did, and it seems to fix the issue (as in, the error went away).
However, right now I am having a possibly unrelated issue, where only grubx64.efi and grub.conf are deployed to EFI/BOOT,
all other files are built and show up next to the image, but not in the boot partition.
Until I get that resolved, I can't be sure whether there are  any side effects from my suggested patch.
I will open a PR with it, I'm sure you have a quick test build you can run on it to see if it's safe

Nvm, I'm blind. I thought you meant my suggestion, I did not see that you linked a PR. I will test that now!


Repair IMC functionality

Do we have a better method to get the layer operand name of weight?
https://github.com/KULeuven-MICAS/zigzag/blob/460fdefd206d3ab4439cd78875a53a6fca955cd1/zigzag/hardware/architecture/imc_unit.py#L150

Do we have a better method to get the layer operand name of weight?
https://github.com/KULeuven-MICAS/zigzag/blob/460fdefd206d3ab4439cd78875a53a6fca955cd1/zigzag/hardware/architecture/imc_unit.py#L150

Assuming there is only one constant operand, we usually do next(layer.constant_operands). I find this approach a bit clearer than taking the last element.


Remove info about swift storage

Swift storage is not supported after Mendix 7

Hi @emirmx
Should I also be removing references to swift from:

https://docs.mendix.com/developerportal/deploy/run-mendix-docker-image/#3-compatibility (section 3)
https://docs.mendix.com/refguide/logging/#mendix-nodes (lognode StorageSwift)

And the Mx 8 versions of these document?
(I see that there was a release note in https://docs.mendix.com/releasenotes/studio-pro/8.0/#deprecations)

Hi @emirmx Should I also be removing references to swift from:
* https://docs.mendix.com/developerportal/deploy/run-mendix-docker-image/#3-compatibility (section 3)

* https://docs.mendix.com/refguide/logging/#mendix-nodes (lognode StorageSwift)

And the Mx 8 versions of these document?
(I see that there was a release note in https://docs.mendix.com/releasenotes/studio-pro/8.0/#deprecations)

Yes, they can also be removed.

Removed additional references in https://github.com/mendix/docs/commit/27f3821ea173f29273c5f4bfaec597d456a0b9a5


Rctnetworking  is not defined in react native 0.72

Description
i am using RCTNetworking.clearcookies to clear cookies. it was working till react native 0.71 but due to dependecy issue i have updated to 72 and in error it was mentioned that its undefined.
React Native Version
react native 49
Output of npx react-native info
System:
OS: macOS 13.2.1
CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
Memory: 175.28 MB / 16.00 GB
Shell:
version: 3.2.57
path: /bin/bash
Binaries:
Node:
version: 20.6.0
path: /usr/local/bin/node
Yarn:
version: 1.22.19
path: /usr/local/bin/yarn
npm:
version: 2.15.12
path: ~/ReactNative/backup/ParrotProjectv2/node_modules/.bin/npm
Watchman:
version: 2<IP_ADDRESS>
path: /usr/local/bin/watchman
Managers:
CocoaPods:
version: 1.12.1
path: /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 22.4
- iOS 16.4
- macOS 13.3
- tvOS 16.4
- watchOS 9.4
Android SDK:
Android NDK: 21.0.6113669
IDEs:
Android Studio: 4.1 AI-201.87<IP_ADDRESS>42882
Xcode:
version: 14.3.1/14E300c
path: /usr/bin/xcodebuild
Languages:
Java:
version: 13.0.2
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react: Not Found
react-native: Not Found
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: Not found
newArchEnabled: false
Steps to reproduce
const RCTNetworking = require('react-native/Libraries/Network/RCTNetworking');
RCTNetworking.clearCookies((result) => {
console.log(result); //true if successfully cleared
});
Snack, screenshot, or link to a repository
ERROR  TypeError: RCTNetworking.clearCookies is not a function (it is undefined)
my main idea of using Rctnetworking is to clear http cookies from axios and fetch  before every authentification process starts. Otherwise it takes old authentication username and password values and never accepted new value. Some how with update of reactnative 49.. Rctnetworking looks undefined and i cannot clear cookies

Could you provide a repro?

I see that there were a change in the RCTNetworking to use ESM exports instead of CJS exports. So as a quick fix, you can add a .default at the end of your require statement const RCTNetworking = require('reactnative/Libraries/Network/RCTNetworking').default;


32 character limit for names should probably be 32 codepoints

General Troubleshooting

[x] I have checked for similar issues.
[x] I have updated to the latest JDA version.
[x] I have checked the branches or the maintainers' PRs for upcoming bug fixes.

Bug Report

Im able to configure my name on dicord like this: 𝐸𝐿𝐼𝒮𝐸𝐸𝐿𝐸𝐿𝐼𝒮𝐸𝐸𝐿𝐼𝒮𝐸𝐸𝐿𝐼𝒮𝐸𝐸𝐿𝐼𝒮𝐸𝐸𝐿𝐼𝒮𝐸
Which looks like 32 characters but with utf-8 this is actually 64 chars in length.
It still is 32 codepoints but jda checks the character count in some functions instead.
JDA#getUserByTag(String username, String discriminator) for example
Expected Behavior
JDA should not throw an error when trying to supply usernames that fit into discord.
I doubt discord will change this behaviour so we should support it perhaps.

You could count codepoints on the string with String#codePoints().count()
But I'm unsure if this would allow inputs that would be too big for discord.
Code Example or Reproduction Steps
shardManager.getUserByTag("𝐸𝐿𝐼𝒮𝐸𝐸𝐿𝐸𝐿𝐼𝒮𝐸𝐸𝐿𝐼𝒮𝐸𝐸𝐿𝐼𝒮𝐸𝐸𝐿𝐼𝒮𝐸𝐸𝐿𝐼𝒮𝐸#5602")

Code for JDABuilder or DefaultShardManagerBuilder Used
N/A
Exception or Error
java.lang.IllegalArgumentException: Username must be between 2 and 32 characters in length!
	at net.dv8tion.jda.internal.utils.Checks.check(Checks.java:43)
	at net.dv8tion.jda.api.JDA.getUserByTag(JDA.java:666)
	at net.dv8tion.jda.api.JDA.getUserByTag(JDA.java:635)
	at net.dv8tion.jda.api.sharding.ShardManager.lambda$getUserByTag$12(ShardManager.java:612)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
	at java.base/java.util.Spliterators$IteratorSpliterator.tryAdvance(Spliterators.java:1812)
	at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:127)
	at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:502)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:488)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
	at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:543)
	at net.dv8tion.jda.api.sharding.ShardManager.lambda$getUserByTag$13(ShardManager.java:614)
	at net.dv8tion.jda.api.utils.cache.CacheView.applyStream(CacheView.java:151)
	at net.dv8tion.jda.api.sharding.ShardManager.getUserByTag(ShardManager.java:611)
	at me.melijn.melijnbot.internals.utils.JDAUtilsKt.getUserByArgsN(JDAUtils.kt:137)
	at me.melijn.melijnbot.internals.utils.JDAUtilsKt.getUserByArgsN(JDAUtils.kt:124)
	at me.melijn.melijnbot.internals.utils.JDAUtilsKt.retrieveUserByArgsN(JDAUtils.kt:154)
	at me.melijn.melijnbot.internals.utils.JDAUtilsKt.retrieveUserByArgsNMessage(JDAUtils.kt:198)
	at me.melijn.melijnbot.commands.utility.UserInfoCommand.execute(UserInfoCommand.kt:29)
	at me.melijn.melijnbot.internals.command.AbstractCommand.run(AbstractCommand.kt:156)
	at me.melijn.melijnbot.internals.command.AbstractCommand$run$1.invokeSuspend(AbstractCommand.kt)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1429)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1016)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1665)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1598)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)```

JDA should not throw an error when trying to supply usernames that fit into discord.
I doubt discord will change this behaviour so we should support it perhaps.

Discord in fact supports this. The button to change your name will turn into a face if you use those unicode text symbols.
Just an FYI.

this issue was fixed by #1579


PAD - Ability to exclude a list of functions

PAD team might want to exclude some default Fx function names which are not relevant for them
ETA Sept 23

What functions are they thinking of?  It's a better maker experience if core Power Fx is the same everywhere.


GO:NEW  DNA-binding transcription repressor activity, RNA polymerase III-specific

GO:NEW  DNA-binding transcription repressor activity, RNA polymerase III-specific
Def
A protein or a member of a complex that interacts selectively and non-covalently with a specific DNA sequence (sometimes referred to as a motif) within the regulatory region of a RNA polymerase III-transcribed gene to repress or decrease transcription.
descendant of
GO:0001217   DNA-binding transcription repressor activity
GO:0001227    DNA-binding transcription repressor activity, RNA polymerase II-specific
References PMID:31833215, PMID:15590667

Why a descendant of GO:0001227?

I agree can't be pol III specific and a child of GO:0001227

That line was just  'hanging around', it was the 'template' for my term name.

+id: GO:0106250
+name: DNA-binding transcription repressor activity, RNA polymerase III-specific
done


docs(README): add edit

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@45e3daf). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master        #1   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?         5
  Lines             ?        92
  Branches          ?         0
==========================================
  Hits              ?        92
  Misses            ?         0
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e3daf...2823e11. Read the comment docs.


Question: Rule to automatically switch space when specific app is started and placed on that space?

Hello,
I have the following question.
I have 8 spaces on 1 display.
My yabairc contains:
yabai -m space 8 --label mail
yabai -m rule --add app="^Mail$" space=mail

When I start Mail while I'm on a space other than 8 then the Mail window get's moved automatically to space 8 while the focus remains on whatever space I'm at.
Is there a possibility to add to the rule above also the command to change focus to space 8 when the Mail app starts?
Thanks a lot.
Best
Tim

After trying around I found it. Sorry for being a bit too hasty in posting this question.
I added an event handler like so:
yabai -m signal --add event=application_launched action="yabai -m space --focus mail &> /dev/null" app="^Mail$"


magit-status does not load magit mode

magit in elpa version 1.1.0 emacs 23.3.1, cygwin 1.7
and I got Symbol's function definition is void: magit-key-mode-add-group error even I (require 'magit-autoloads) instead.
See https://github.com/redguardtoo/emacs.d/commit/d0464403feeb24afbd3340e576916fac00f5096b for my fix.

Removing the "autoload" from init-git.el is sufficient; magit-autoloads is automatically evaluated by package.el; note that I'm now using the Melpa package of magit, not a submodule under site-lisp.
But I couldn't reproduce the error in any case. I don't think it's necessary to explicitly load magit-key-mode.
-Steve

BTW, Melpa's pretty cool: http://melpa.milkbox.net/

Yes, I merged from your branch yesterday.


[CSL-443] Make sure that that Tx processing works fine

@iperesadin

@iperesadin
Txp works fine with wallet, but something strange happens with smart-generator: nodes process blocks and tx fine, but smart-generator doesn't work, I guess. It spams nodes by one tx.
Probably we need issue for checking smart-generator.


Update bundle golden files

Update bundle golden files.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick release-0.10

/lgtm

/approve

/override eks-anywhere-attribution-files-presubmit
/override eks-anywhere-e2e-presubmit
/override eks-anywhere-presubmit
/override eks-anywhere-release-tooling-presubmit
/override eks-anywhere-release-tooling-test-presubmit

/override eks-anywhere-mocks-presubmits


Support new React Native new architecture

With Fabric/Turbomodules now being available for please add add support for it
See https://reactnative.dev/docs/new-architecture-library-intro
https://reactnative.dev/blog/2022/06/16/resources-migrating-your-react-native-library-to-the-new-architecture

Any update?

I'm curious about this as well. Mixpanel and RN AppsFlyer are my current blockers for moving to the new arch.

Hey there! @zihejia 👋🏻
Would it be possible to get some update on that topic?

Is it being worked on internally?
Are you waiting for external contributors?

The new arch is here, and close to being enabled by default and if Mixpanel becomes a blocker to update it might push away users.

+1 on Mixpanel starting to be a major blocker for us, not allowing is to move to the new arch.

@zihejia @jaredmixpanel - hi there! I work on expo and closely with the react-native team at meta on assisting in the roll out of the new architecture for react-native. we're moving towards enabling the new architecture by default in react-native later this year, and so we're proactively reaching out for maintainers of popular libraries to get the ball rolling in some third party libraries (more info).
here's a guide with more info on how you can proceed: "Enable the New Architecture for Libraries"
if you need any assistance, let us know! just a heads up that i've heard that at least one customer is considering moving away from mixpanel due to this blocking their migration to the new architecture, so it may be worth addressing sooner than later.

For those having trouble with this, we found a workaround using JS-only mode:
Follow instructions for Expo/Web set up: https://docs.mixpanel.com/docs/tracking-methods/sdks/react-native#expo-and-web-support
Then disable auto-linking the dependency with the react-native.config.js file:
module.exports = {
  dependencies: {
    'mixpanel-react-native': {
      platforms: {
        android: null,
        ios: null,
      },
    },
  },
};

So far, this has given us the functionality that we need, but YMMV.

Update here: The folks at Meta have just merged this React Native PR to add support for com.facebook.react.bridge.Dynamic to the New Architecture: https://github.com/facebook/react-native/pull/45944
Once that is released this issue should be resolved.

We're planning to ship this hotfix to 0.75.x and 0.74.x
You can follow the status of those 2 picks here:

https://github.com/reactwg/react-native-releases/issues/439
https://github.com/reactwg/react-native-releases/issues/440

Hello @jaredmixpanel is the support of com.facebook.react.bridge.Dynamic starting from 0.75 is enough or are you waiting to also get it merged into 0.74?

Oh awesome, thanks Jared 🔥

Closing this issue as https://github.com/reactwg/react-native-releases/issues/440 is now also closed/merged

reactnative.directory is still showing this library as not supporting the New Architecture, is that just incorrect?
If it is, might be worth getting corrected, given that directory is what the official expo-doctor uses to report library support.

@Serdnad Thanks for the heads up, I've opened a PR here: https://github.com/react-native-community/directory/pull/1336


Remove usage of pkg/config::Datadog from the flare comp

What does this PR do?
Remove usage of pkg/config::Datadog from the flare comp.
Describe how to test/QA your changes
Test sending a flare from the Agent (both from the CLI, the Windows GUI and the Windows systray)

/merge

/merge


@JuliaRegistrator register

ok @kdpsingh I'm gonna need your help, apparently JuliaRegistrator doesn't have access to this repo and I cannot add it

Thanks, I'll take a look at it.

Not sure why it wasn't working for you. I checked, and all repositories in TidierOrg are registered to work with JuliaRegistrator.
I just tagged the latest commit and it looks like it worked. Some of the checks are still pending but the package is otherwise in the process of being registered.
Here's the link: https://github.com/JuliaRegistries/General/pull/90250
If the package passes all the checks, we can close this issue.

It's possible that only "owners" if the organization can tag it. Once it's registered, will have you try again with a future update. If that's a problem, happy to list you as an owner.

It passed all the checks so I'll close this issue. It should auto-merge in a couple of days.


hook into widget state

get displayToken from widgetState callback & add to userConfig. Update TVL card when toggled.

We need to add the translations as well


Updated of-watchdog to 0.5.4

Updated the docker images to use the new of-watchdog.
Tested each new docker image by creating a function using that template and deploying them locally.

Squashed commits and ensured signed off :)


Add 'Idempotency-Key' header as per rule 230

Adding Idempotency-Key header as per: MAY consider to support Idempotency-Key header [230], following the example of the Prefer header (see MAY consider to support Prefer header to handle processing preferences [181]).
Neither Idempotency-Key or Prefer are standard headers as per the list linked in rule 133, but are explicitly allowed by their respective rules, so they might belong in a new config variable separate to standard_request_headers.
Fixes: #1104

Codecov Report

Merging #1103 into master will decrease coverage by 1.37%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1103      +/-   ##
============================================
- Coverage     85.15%   83.78%   -1.38%
  Complexity     1103     1103
============================================
  Files           175      126      -49
  Lines          2783     1992     -791
  Branches        462      407      -55
============================================
- Hits           2370     1669     -701
+ Misses          201      138      -63
+ Partials        212      185      -27

Impacted Files
Coverage Δ
Complexity Δ

web-ui/src/client/app/services/rest.js

cli/zally/utils/result_printer.go

web-ui/src/client/app/components/rules.jsx

web-ui/src/client/app/services/debug.js

web-ui/src/client/app/services/oauth-util.js

...src/server/dev/webpack-dev-server-proxy-handler.js

cli/zally/app.go

web-ui/src/client/app/containers/rules.jsx

cli/zally/domain/error.go

web-ui/src/client/app/components/msg.jsx

... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8dabd...04c3458. Read the comment docs.

:+1:

:+1:

👍


allow serializers to strip keys

If a serializer returns undefined, the key/value shouldn't be added to the JSON
This will allow a serlializer to strip both a key and a value (by returning undefined)
Also, if an object has an undefined value, it gets excluded from stringification, so we should follow the same behaviour
cc @mcollina @emilyrose

LGTM. Does this affect perf anyhow?


Failed to execute goal com.spotify:docker-maven-plugin:1.0.0:build (default-cli) on project

When I execute this command line: mvn clean package docker:build.
I will get the error info:Failed to execute goal com.spotify:docker-maven-plugin:1.0.0:build (default-cli) on project test: Execution default-cli of goal com.spotify:docker-maven-plugin:1.0.0:build failed: A required class was missing while executing com.spotify:docker-maven-plugin:1.0.0:build: org/apache/commons/logging/LogFactory
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>com.spotify:docker-maven-plugin:1.0.0
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/D:/MavenRepository/com/spotify/docker-maven-plugin/1.0.0/docker-maven-plugin-1.0.0.jar
[ERROR] urls[1] = file:/D:/MavenRepository/com/spotify/docker-client/8.7.1/docker-client-8.7.1-shaded.jar
[ERROR] urls[2] = file:/D:/MavenRepository/com/google/guava/guava/18.0/guava-18.0.jar
[ERROR] urls[3] = file:/D:/MavenRepository/com/fasterxml/jackson/jaxrs/jackson-jaxrs-json-provider/2.8.8/jackson-jaxrs-json-provider-2.8.8.jar
[ERROR] urls[4] = file:/D:/MavenRepository/com/fasterxml/jackson/jaxrs/jackson-jaxrs-base/2.8.8/jackson-jaxrs-base-2.8.8.jar
[ERROR] urls[5] = file:/D:/MavenRepository/com/fasterxml/jackson/module/jackson-module-jaxb-annotations/2.8.8/jackson-module-jaxb-annotations-2.8.8.jar
[ERROR] urls[6] = file:/D:/MavenRepository/com/fasterxml/jackson/datatype/jackson-datatype-guava/2.8.8/jackson-datatype-guava-2.8.8.jar
[ERROR] urls[7] = file:/D:/MavenRepository/org/glassfish/jersey/core/jersey-client/2.22.2/jersey-client-2.22.2.jar
[ERROR] urls[8] = file:/D:/MavenRepository/javax/ws/rs/javax.ws.rs-api/2.0.1/javax.ws.rs-api-2.0.1.jar
[ERROR] urls[9] = file:/D:/MavenRepository/org/glassfish/jersey/core/jersey-common/2.22.2/jersey-common-2.22.2.jar
[ERROR] urls[10] = file:/D:/MavenRepository/javax/annotation/javax.annotation-api/1.2/javax.annotation-api-1.2.jar
[ERROR] urls[11] = file:/D:/MavenRepository/org/glassfish/jersey/bundles/repackaged/jersey-guava/2.22.2/jersey-guava-2.22.2.jar
[ERROR] urls[12] = file:/D:/MavenRepository/org/glassfish/hk2/osgi-resource-locator/1.0.1/osgi-resource-locator-1.0.1.jar
[ERROR] urls[13] = file:/D:/MavenRepository/org/glassfish/hk2/hk2-api/2.4.0-b34/hk2-api-2.4.0-b34.jar
[ERROR] urls[14] = file:/D:/MavenRepository/org/glassfish/hk2/hk2-utils/2.4.0-b34/hk2-utils-2.4.0-b34.jar
[ERROR] urls[15] = file:/D:/MavenRepository/org/glassfish/hk2/external/aopalliance-repackaged/2.4.0-b34/aopalliance-repackaged-2.4.0-b34.jar
[ERROR] urls[16] = file:/D:/MavenRepository/org/glassfish/hk2/external/javax.inject/2.4.0-b34/javax.inject-2.4.0-b34.jar
[ERROR] urls[17] = file:/D:/MavenRepository/org/glassfish/hk2/hk2-locator/2.4.0-b34/hk2-locator-2.4.0-b34.jar
[ERROR] urls[18] = file:/D:/MavenRepository/org/javassist/javassist/3.18.1-GA/javassist-3.18.1-GA.jar
[ERROR] urls[19] = file:/D:/MavenRepository/org/glassfish/jersey/connectors/jersey-apache-connector/2.22.2/jersey-apache-connector-2.22.2.jar
[ERROR] urls[20] = file:/D:/MavenRepository/org/glassfish/jersey/media/jersey-media-json-jackson/2.22.2/jersey-media-json-jackson-2.22.2.jar
[ERROR] urls[21] = file:/D:/MavenRepository/org/glassfish/jersey/ext/jersey-entity-filtering/2.22.2/jersey-entity-filtering-2.22.2.jar
[ERROR] urls[22] = file:/D:/MavenRepository/org/apache/commons/commons-compress/1.9/commons-compress-1.9.jar
[ERROR] urls[23] = file:/D:/MavenRepository/commons-io/commons-io/2.5/commons-io-2.5.jar
[ERROR] urls[24] = file:/D:/MavenRepository/org/apache/httpcomponents/httpclient/4.5/httpclient-4.5.jar
[ERROR] urls[25] = file:/D:/MavenRepository/org/apache/httpcomponents/httpcore/4.4.5/httpcore-4.4.5.jar
[ERROR] urls[26] = file:/D:/MavenRepository/com/github/jnr/jnr-unixsocket/0.8/jnr-unixsocket-0.8.jar
[ERROR] urls[27] = file:/D:/MavenRepository/com/github/jnr/jnr-ffi/2.0.3/jnr-ffi-2.0.3.jar
[ERROR] urls[28] = file:/D:/MavenRepository/com/github/jnr/jffi/1.2.9/jffi-1.2.9.jar
[ERROR] urls[29] = file:/D:/MavenRepository/com/github/jnr/jffi/1.2.9/jffi-1.2.9-native.jar
[ERROR] urls[30] = file:/D:/MavenRepository/org/ow2/asm/asm/5.0.3/asm-5.0.3.jar
[ERROR] urls[31] = file:/D:/MavenRepository/org/ow2/asm/asm-commons/5.0.3/asm-commons-5.0.3.jar
[ERROR] urls[32] = file:/D:/MavenRepository/org/ow2/asm/asm-analysis/5.0.3/asm-analysis-5.0.3.jar
[ERROR] urls[33] = file:/D:/MavenRepository/org/ow2/asm/asm-tree/5.0.3/asm-tree-5.0.3.jar
[ERROR] urls[34] = file:/D:/MavenRepository/org/ow2/asm/asm-util/5.0.3/asm-util-5.0.3.jar
[ERROR] urls[35] = file:/D:/MavenRepository/com/github/jnr/jnr-x86asm/1.0.2/jnr-x86asm-1.0.2.jar
[ERROR] urls[36] = file:/D:/MavenRepository/com/github/jnr/jnr-constants/0.8.7/jnr-constants-0.8.7.jar
[ERROR] urls[37] = file:/D:/MavenRepository/com/github/jnr/jnr-enxio/0.9/jnr-enxio-0.9.jar
[ERROR] urls[38] = file:/D:/MavenRepository/com/github/jnr/jnr-posix/3.0.12/jnr-posix-3.0.12.jar
[ERROR] urls[39] = file:/D:/MavenRepository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar
[ERROR] urls[40] = file:/D:/MavenRepository/org/bouncycastle/bcpkix-jdk15on/1.52/bcpkix-jdk15on-1.52.jar
[ERROR] urls[41] = file:/D:/MavenRepository/org/bouncycastle/bcprov-jdk15on/1.52/bcprov-jdk15on-1.52.jar
[ERROR] urls[42] = file:/D:/MavenRepository/ch/qos/logback/logback-classic/1.2.1/logback-classic-1.2.1.jar
[ERROR] urls[43] = file:/D:/MavenRepository/ch/qos/logback/logback-core/1.2.1/logback-core-1.2.1.jar
[ERROR] urls[44] = file:/D:/MavenRepository/com/google/auth/google-auth-library-oauth2-http/0.6.0/google-auth-library-oauth2-http-0.6.0.jar
[ERROR] urls[45] = file:/D:/MavenRepository/com/google/auth/google-auth-library-credentials/0.6.0/google-auth-library-credentials-0.6.0.jar
[ERROR] urls[46] = file:/D:/MavenRepository/com/google/http-client/google-http-client/1.19.0/google-http-client-1.19.0.jar
[ERROR] urls[47] = file:/D:/MavenRepository/com/google/code/findbugs/jsr305/1.3.9/jsr305-1.3.9.jar
[ERROR] urls[48] = file:/D:/MavenRepository/com/google/http-client/google-http-client-jackson2/1.19.0/google-http-client-jackson2-1.19.0.jar
[ERROR] urls[49] = file:/D:/MavenRepository/com/typesafe/config/1.2.0/config-1.2.0.jar
[ERROR] urls[50] = file:/D:/MavenRepository/org/apache/maven/maven-builder-support/3.3.3/maven-builder-support-3.3.3.jar
[ERROR] urls[51] = file:/D:/MavenRepository/org/eclipse/aether/aether-util/1.0.2.v20150114/aether-util-1.0.2.v20150114.jar
[ERROR] urls[52] = file:/D:/MavenRepository/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar
[ERROR] urls[53] = file:/D:/MavenRepository/javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar
[ERROR] urls[54] = file:/D:/MavenRepository/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.0/org.eclipse.sisu.inject-0.3.0.jar
[ERROR] urls[55] = file:/D:/MavenRepository/org/sonatype/sisu/sisu-guice/3.2.5/sisu-guice-3.2.5-no_aop.jar
[ERROR] urls[56] = file:/D:/MavenRepository/aopalliance/aopalliance/1.0/aopalliance-1.0.jar
[ERROR] urls[57] = file:/D:/MavenRepository/org/codehaus/plexus/plexus-interpolation/1.21/plexus-interpolation-1.21.jar
[ERROR] urls[58] = file:/D:/MavenRepository/org/codehaus/plexus/plexus-utils/3.0.20/plexus-utils-3.0.20.jar
[ERROR] urls[59] = file:/D:/MavenRepository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
[ERROR] urls[60] = file:/D:/MavenRepository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
[ERROR] urls[61] = file:/D:/MavenRepository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
[ERROR] urls[62] = file:/D:/MavenRepository/org/eclipse/jgit/org.eclipse.jgit/<IP_ADDRESS>312181205-r/org.eclipse.jgit-<IP_ADDRESS>312181205-r.jar
[ERROR] urls[63] = file:/D:/MavenRepository/com/jcraft/jsch/0.1.46/jsch-0.1.46.jar
[ERROR] urls[64] = file:/D:/MavenRepository/com/googlecode/javaewah/JavaEWAH/0.5.6/JavaEWAH-0.5.6.jar
[ERROR] urls[65] = file:/D:/MavenRepository/com/fasterxml/jackson/core/jackson-databind/2.2.3/jackson-databind-2.2.3.jar
[ERROR] urls[66] = file:/D:/MavenRepository/com/fasterxml/jackson/core/jackson-annotations/2.2.3/jackson-annotations-2.2.3.jar
[ERROR] urls[67] = file:/D:/MavenRepository/com/fasterxml/jackson/core/jackson-core/2.2.3/jackson-core-2.2.3.jar
[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import  from realm ClassRealm[maven.api, parent: null]]
[ERROR]
[ERROR] -----------------------------------------------------: org.apache.commons.logging.LogFactory
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginContainerException.

@kitkatlc  I am facing the same issue. Since you have closed this issue I am assuming it got resolved. How did you resolve it?

I try to unload the maven and reload it. It can execute the plugin only one time. so I close the issue,But after that it can not execute the plugin successfully.As far as i known the plugin has the issue on the win10 operating system.

在 2021年7月17日，04:27，chandinikhetawat @.***> 写道：

@kitkatlc I am facing the same issue. Since you have closed this issue I am assuming it got resolved. How did you resolve it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks for response @kitkatlc . For me it works on local machine (mac) but fails on jenkins


Fix snippet on android

@keybase/react-hackers Fixes snippet cutoff problem on android

But why is this cut off? Isn't the emoji within the line height?

The text was cutoff not just emojis. I think it was a combination of two things:

lineHeight behaves differently on ios/android (https://github.com/facebook/react-native/issues/10712)

Text can go outside it's container on ios, but gets cutoff on android. This is why the {min,max}Height had to be changed.

i wonder if we should set overflow: hidden on ios so we can see this type of problem there also (can be off for prod build) just thinking out load


update license info in README

Hello, I think multi-select is under the WTFPL license.
README.md needs a update.

@amomo, I updated the license to be under MIT.
Feel free to tell if it's an issue for you.

Oh, just want to confirm it with you.
Maybe you can also update the license info in bower.json, multi-select.jquery.json and the website.

You are right


fix PySide2 dependency

This fixes following error during pip install:
ERROR: Could not find a version that satisfies the requirement PySide2==5.15.2 (from webui) (from versions: 0.0.0a1, 5.11.0, 5.11.1, 5.11.2, 5.12.0, 5.12.1, 5.12.2, 5.12.3, 5.12.4, 5.12.5, 5.12.6, 5.13.0, 5.13.1, 5.13.2, <IP_ADDRESS>)
ERROR: No matching distribution found for PySide2==5.15.2

This fixed the issue for me. However I had to change a line in
flask.sessions line 14 fromfrom collections import MutableMapping
to:
if sys.version_info[:2] >= (3, 8):     from collections.abc import MutableMapping else:     from collections import MutableMapping
so that it would build
the newest flask module seems to be updated with that change on the github page


[2.6] Deployment create, missing Volume Type "emptyDir"

Rancher Server Setup

Rancher version: 2.6
Installation option (Helm Chart):

RKE1, kubernetes 1.21

Describe the bug
If you create a deployment and want to add an emptyDir volume, you cannot select that from volume type dropdown
      volumes:
      - emptyDir: {}
        name: somename

To Reproduce

Create a deployment
Storage -> Add Volume
emptyDir not existent

update issue:

Import a deployment with an empty dir
update the deployment
storage, you are unable to change the name of the emptyDir mount, no field available

Result
Expected Result

EmptyDir is available in dropdown
EmptyDir name can be changed on update of an deployment

Screenshots

https://github.com/rancher/rancher/issues/25131

This issue is still present in Rancher 2.6.2.

This issue is still present in Rancher 2.6.3.

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.

Issue still valid....

This issue is still present in Rancher 2.6.5

This issue is still present in Rancher 2.6.8

Successor: #36760

Same problem.
Rancher Version: v2.6.8
K8S Version: 23.10


romTool segfaults on older ROM files

I ran your romTool against the collection of ROM files here: https://github.com/sentient06/MacROMan/tree/master/TestImages/New World ROM
It segfaults while examining the parcels for any versions older than 9.0.1.  I've never spent much time examining any of the parcels other than the "Mac OS ROM parcel" file, so I'm not quite sure where to start looking next.  Let me know what I can do to help.
Thanks.

Sorry about that. I'm not really surprised honestly.
There was no effort made to work with those older versions.
Based on the intent of the project this is used with, I don't expect this code to ever be fixed for those older ROM's.
I did update the romTools for you with the most current version/source.
But I can't guarantee they will work in OS X

I was using it under Linux and it worked fine, except for the segfault part. :)  Is there a reason you switched them to MPW based projects?
Is there any particular area you're stuck on with your project?  I've been following it a little but I haven't paid particularly close attention.

What you see here is part of a larger project and this project is basic tools for the larger project.
MPW is used because it runs on OS 9.2.2
Not stuck on anything at this point.
Have you been following on github only?

I'm also a little confused as to why you'd merge the MPW version of romTools on top of (relatively well) functioning Unix source.  Wouldn't it be better hosted in a separate directory?
Regardless, thank you for all your work.  It is all very interesting to me.

The merge was how I wrote it or should say updated/rewrote it. I will look into moving as that makes sense.
I had not seen that specific link. Pretty nice chunk of info.  There is a bunch of other info on that list as well that i have gone through.
Have you tested this against MPW and received the same segfault.
This is starting to become a more general conversation (though I am enjoying it).  If you would like to continue it you can message me at macos9lives. I go by nanopico on that forum.


As a statistician I need to produce a list of all the countries in the world organised by largest population to smallest. This will allow me to collate data and draw correlations from the information.

starting this to make a release


New command: teams conversationmember list

Usage
teams conversationmember list [options]
Description
Lists all conversationalmembers of a private channel.
Options

Option
Description

--teamId <teamId>
The Team's ID

--teamName <teamName>
The DisplayName of the Team

--channelId <channelId>
The private channel's ID

--channelName <channelName>
The private's Channel name

--owner
Assign the user the owner role. Defaults to member permissions

Additional Information
https://docs.microsoft.com/en-us/graph/api/team-list-members?view=graph-rest-1.0&tabs=http
I can pick this up.

Looking at the spec, let's allow referring to team and channel by their name as well to make it easier to use.
You've got 4 issues assigned to you. Shall we let others help? If you're done with the other 4 and no one has picked up this one, you can still do it 🙂

Actually this one is really interesting! If you are already @plamber on other things, I'm willing to take on this one!

@sebastienlevert:  you can take this up. Let us define the specifications before.
#1879 #1878 are somewhat related and should follow the same logic as here.
I worked with this endpoint in the last weeks a lot and there are some important aspects to consider.

It works for private channels only, in all other situations this command is going to fail
It is Teams only (merging it with the https://pnp.github.io/cli-microsoft365/cmd/aad/o365group/o365group-user-list/ feels messy to me).
Adding and updating is performed with one command #1878. This command accepts the AAD id of the user. Removing the command #1879 was accepting only the conversationmemberid, which you get if you retrieve all conversationmembers before

@waldekmastykarz suggested to use the channelname as additional parameter together with the channelid. Since channelnames are unique, this is indeed a good point. It will however cost additional calls to graph to get all channels and perform the filtering.
On the other hand, I would not provide a filtering by Teamname (Displayname). This is not unique and might provide some undesired behavior. If we want to provide an additional option we could think of having the mailnickname option as filter. This would be unique but I do not believe this will be the standard case of handling things in scripts.
With all these points it feels right to me to have it separated. @sebastienlevert and @waldekmastykarz: what do you think about this?

I've updated the command name to teams conversationmember list (singular) to match our naming convention.
Good points @plamber 👍

Since channelnames are unique, this is indeed a good point. It will however cost additional calls to graph to get all channels and perform the filtering.

This is true and a tradeoff for the bit of convenience. Otherwise, you'd have the same hit when having to lookup the ID yourself, not to mention having to run two commands and copy-paste the ID

On the other hand, I would not provide a filtering by Teamname (Displayname). This is not unique and might provide some undesired behavior.

We have this implemented in other teams commands, where if we find multiple results, we prompt the user to disambiguate them using an ID. Not sure how common it is, but again, it's a convenience that we should consider offering for non-automated scenarios.

@sebastienlevert and @waldekmastykarz: what about the updated command definition? Is this fine for you?

What is the --owner parameter? I would not expect a list command to alter any of the data and here it seems like it. Copy / Paste issue?

@sebastienlevert good catch. Cleared it up

Makes sense to me! Let me know if there is any "guidance" you want to provide to utilize the endpoint or if I can start with it!

You can start with it from my point of view. I am doing the review afterwards

@waldekmastykarz I'm realizing that we will need a new scope in the AAD app, especially for listing members. The following permissions are documented on the Graph : Chat.ReadBasic, Chat.Read, Chat.ReadWrite (https://docs.microsoft.com/en-us/graph/api/conversationmember-list?view=graph-rest-beta&tabs=http). Interestingly enough, this won't be required for the add / remove as it relies on the Group.ReadWrite.All (https://docs.microsoft.com/en-us/graph/api/conversationmember-add?view=graph-rest-beta&tabs=http).
I believe Chat.Read should be enough, in our case. For now, I would be "stuck" behind this before I move on with any further development. I'm already done with a majority of the implementation, but I want to make sure it works with the PnP Management Shell app and not only with a personal AAD app.

Hi,
we already have Group.ReadWrite.All. This should suffice. I already have an issue open to ask why the documentation is messed up. I tried the endpoints already in productions. No problems with Group.ReadWrite.All for now.
Here the issue reference.
br,

The list endpoint is referencing very different scopes. I get a 403 with the currently consented scopes, so I feel this is a required scope. https://docs.microsoft.com/en-us/graph/api/conversationmember-list?view=graph-rest-1.0&tabs=http#permissions
Especially the list seems to only allow GET on the /beta endpoint. In the Graph Explorer, you can see the Permissions tab and see it really required those Chat.* scopes...
V1.0
https://developer.microsoft.com/en-us/graph/graph-explorer?request=chats%2F19%3A586a8b9e36c4479bbbd378e439a96df2%40thread.skype%2Fmembers&method=GET&version=v1.0&GraphUrl=https://graph.microsoft.com
Beta
https://developer.microsoft.com/en-us/graph/graph-explorer?request=chats%2F19%3A586a8b9e36c4479bbbd378e439a96df2%40thread.skype%2Fmembers&method=GET&version=beta&GraphUrl=https://graph.microsoft.com

The way we handled that in the past, is that during dev we used a custom AAD app and when we had a PR open, we extended the scopes on the PnP Management Shell app so that when the PR is merged all is up & running.

@sebastienlevert: this is the reason why I opened the issue on their end. They are investigating. For now let us work with the scopes you are suggesting. I could imagine that these are no more required in a couple of weeks.

I was wondering, and this might be a way bigger topic than it is... But...
Let's say, in this command, that we want to validate the teamId + channelId. Not only that they are valid GUIDs, but that they are actual team IDs and/or channel IDs... Should this be part of the command of we should expect "valid" and "existing" ids? It would make the command a lot more robust, but with a ton more code...
So far, in the CLI, it seems like a lot of that validity is "assumed" and it's definitely OK. Just wondering if we should, or not ;)

@plamber : Been poking around and indeeed, this endpoint is having some interesting behaviors! I'm actually looking at this one and feel it would be the right one to hit : https://docs.microsoft.com/en-us/graph/api/conversationmember-add?view=graph-rest-beta&tabs=http.
From a list perspective, running it on the same end point with a GET gets me the members of the private channel, but only in beta. Are we on the same page with the endpoint to leverage?
 GET /teams/{id}/channels/{id}/members

The enpoint works only for private channels. In v1.0 it requires different permissions as in beta.
The engineers in ms stated they are investigating. Not sure how long it will take.
My suggestion is to work with the v1.0 enpoint and updated permissions. Consider only the private channel usecase. All other channels in theory throw an exception

Let's say, in this command, that we want to validate the teamId + channelId. Not only that they are valid GUIDs, but that they are actual team IDs and/or channel IDs... Should this be part of the command of we should expect "valid" and "existing" ids? It would make the command a lot more robust, but with a ton more code...

They way the CLI is built at the moment is that we have a separate place to validate arguments, but at that stage, we don't have authentication initialized yet, so we can't execute any requests towards M365. So how we're handling it instead is, that we validate the input's structure but let M365 handle the validity of the actual resources.

So more findings today with this interesting endpoint!
@plamber I don't know if you've been through this already, but it's definitely interesting...
It works great with Private Channels and I can get all of the conversation members (well... The API does not support paging for now. So this will be definitely documented as we might be missing "some" users). All of this is based on the following call :
<EMAIL_ADDRESS>The interesting thing, is that if we pass a "somewhat" valid ID that would not exist, it returns the members of the team instead :
<EMAIL_ADDRESS>Should we "catch" these (we already have a better validation on the channelId but if you change a simple character, it would still return the team members, and not the non-existing channel members) or should we simply let it be, like it is right now? It would add a validation call on the existence of the provided channelId and not only "assume" that the ID is valid.

HI @sebastienlevert,
I think we shouldn't fix the API if it does not behave as it should but provide the feedback directly to the Graph team. Lets work on the minimum viable solution and then list down the issues we identified.
Afterwards, I am getting in touch with some colleagues and will report the problem. I could imagine that they are happy to get the feedback.
br,
Patrick

Alright, makes a lot of sense. PR incoming tomorrow as it's ready!

@sebastienlevert @plamber I think there is something to say for the somewhat odd API behavior and us trying to help users work with it more reliably. I'd suggest we follow both of your suggestions: let's absolutely report it back to the Graph team, but also, let's check if the specified ID is valid. There is nothing worse than thinking you have the right data while it's not the case.

Totally agree and I just implemented a validation based on the id. If /channels?$filter=id eq<EMAIL_ADDRESS>returns nothing, we consider it invalid or not existing.

Awesome @sebastienlevert 👍


Import not added when duplicate imports present

    @Test
    fun importNotAddedWithDups(jp: JavaParser) = assertChanged(
        jp,
        recipe = addImports(AddImport("org.springframework.http.MediaType", null, false)),
        before = """
			import javax.ws.rs.Path;
			import javax.ws.rs.Path;

            class A {}
        """,
        after = """
            import org.springframework.http.MediaType;

			import javax.ws.rs.Path;
			import javax.ws.rs.Path;

            class A {}
        """
    )

Not a high priority. Took a while to figure out why some tests fail. Tuyned out we had duplicate imports in the initial source

Thanks for reporting. If no one else gets to it before then, I'll try to take a look tomorrow morning.


Fixed 30360 -- Support rotation of secret keys.

First stab at fixing #11198

Hey @terrameijar — super! Well done. We're up! 🚀
I've marked this draft. We'll have a look at tests and lint and docs. I'll take a proper look tomorrow and come up with some actual points.
If you wanted, the Patch review checklist will give some ideas of what's missing. (But docs, and tests 😄)
👍

Once we've got a grip on the tests we'll push forwards with the rest of the patch. 👍

I've rebased this again from @pelme's original patch. It wasn't at all clean! 😅 (Andreas, if you have half a cycle, can you just review to make sure if looks ≈right to your eye? — Thanks)

It looks good to me! Thanks @terrameijar for picking up this PR. It will be a really nice thing to have in Django.

@carltongibson Thanks, I'll have a look later after work. @pelme You did all the hard work, so kudos to you!

@carltongibson We are down to one failure, please review and let me know what the best way to address this is.

 (It's difficult.) I've done that in #13850.
I'll close this here now.
We still need docs and that. If you're up for it, happy to take input on my branch! If not — I'm trying to hit the deadline for Django 3.2 feature freeze next week — no stress, happy to work with you on another ticket!
Happy New Year! 🥳

Hey @terrameijar — I needed to make some adjustments to get it all passing. (It's difficult.) I've done that in #13850.
I'll close this here now.
We still need docs and that. If you're up for it, happy to take input on my branch! If not — I'm trying to hit the deadline for Django 3.2 feature freeze next week — no stress, happy to work with you on another ticket!
Happy New Year! 🥳


Comment traversal module

Use CTRL+Up and Down arrow keys to traverse top level comments in threads, and CTRL+Left and Right to back/forward one comment respectively.
A slight blink animation on the active comment as well!

Could you please run stylus -c -w lib/extras/hn_theme.styl, emphasis on the -c for compression. That should minimize the change to the CSS output.


fix typo in example content

Hello Emmanuel,
a front matter using TOML syntax is delimitted by a pair of +++. The variables tags, categories, series and aliases are still part of the front matter but would be ignored if the front matter ends before their definition.

I'm sorry. I think I confused myself by working on something too late for myself last night.
I appreciate you taking a look and have really enjoyed Hugo. Cheers!

No problem @meinenec


Tooltips in input fields

Another feature idea: Placement of tooltips IN fields. Example:

Several solutions would be possible.

with CSS, by placing the icon above the input (some markup changes would be necessary)
with CSS+JS. Icon is placed in input via css background property. JS opens tooltip on focus.
https://github.com/chinchang/hint.css/issues/79

Background, why this will be useful:
With placeholders GF introduced a new option to hide labels

https://www.gravityhelp.com/gravity-forms-v1-9-placeholders/

+1! This could be very useful. For other type of fields an info button next to the field would be required though. For example with checkboxes and radio buttons as in: https://github.com/norcross/gravity-tooltips/issues/34


Typo in Javadoc for TimeoutBuilder.withInterrupt()

Please change unkown to unknown

Thanks for pointing this out.


Update external/ to SPIR-V 1.5

Rolled the hashes used for glslang, SPIRV-Tools, and SPIRV-Headers to
HEAD, which includes the update to 1.5.
Added passing '--amb' to glslang, so I didn't have to explicitly set
bindings in a large number of test shaders that currently don't, and
now glslang considers them invalid.
Ran update_test_shaders.sh to update all of the reference files.
Marked all shaders that no longer pass spirv-val as .invalid.

PTAL, this is my naive attempt up updating spirv-cross's dependencies.
The last update to glslang's hash in external/ is to a version from June, so now there is difficulties integrating newer versions of spirv-tools & glslang into projects that also depend on spirv-cross.

Seems reasonable, that's the right approach. I'll need to verify tomorrow that the codegen changes make sense, some are a little suspect.

This change exposed a SPIRV-Cross bug which caused the test failure, I'll fix that locally and push the fix.


We should add it to go-web-framework-benchmark even just for advertising

We should add it to go-web-framework-benchmark even just for advertising.

Sounds good. Do you want to give it a try?

Yeah I will in the next few hours.

Added here: https://github.com/smallnest/go-web-framework-benchmark/pull/112.
We can close this if you find it correct, @vmihailenco or maybe we can wait for it to be merged.


feat: Add a CLI interface to the flutter repo

This allows us to have version-specific functionality for Flutter.
In this case what we're adding is the ability to change our patch format on a
flutter-version specific basis.
This is modeled after aot_tools in the dart-sdk, and we should probably move more
of shorebird_cli down into this over time.

Sorry, wrong repo.


Support parsing block IDs into \labels

If block IDs were translated, so that:
# Introduction
^introduction

became
\section{Introduction}
\label{introduction}

Then crossreferencing would work nicely

Works, so long as there is a blank line after the label


[StyleCop] Fix all the warnings on ApplicationInsights.Tests

Rename variable to avoid hungarian notation
Fix spacing
Fix parameters

Promoted to MS# 1458


Nullpointer on Android

I got a null-pointer on Android when scanning devices, I have fixed it the following way:
https://github.com/RichardLindhout/react-native-esp-idf/commit/721d64de55bfa7da45f07c2193553f629d7dcd6c

I got a null-pointer on Android when scanning devices, I have fixed it the following way: RichardLindhout@721d64d

This fix not help for me but got same error.


Jo 501 finalize url encoding

— Fixes color coding not loading on URL decode
— Encodes/decodes navBar.right = buildings status
— Encodes/decodes previewBuilding
Third item got complicated and led to other things:
— checks that project layers have in fact been rendered before initializing the url decoding. That was the source of the timing issues
— marks the previewBuilding dot with a red ring
— changes legend to match that and to remove last-filter designations
— Zooms to selected previewBuilding and disables zoom-to-fit-filter-results functionality when there is a previewBuilding selected. It felt like unwanted behavior to have the map zoom away from a selected project. (TO DO: add a way to unselect the previewBuilding)
— scrolls the matching projects list to show the previewBuilding list item (if it matches filters). That reinforces the connection between the list and the map. Also adds up-triangle icon to indicate that that item is shown in the preview pane.
— scroll happens whether by clicking on the map or by url decode.
I did some pretty good stress testing, selecting lots of filters and a previewBuilding. Seems to be working well. For example: http://<IP_ADDRESS>:4000/tool/#/HI/sb=bdng&pb=8d6ec119-9534-4426-9b28-ce6d5e73101c&pa=1-28&pu=4-290&cv=82-430&pov=0.09-0.18&l=Ward_3

re #501

@ostermanj this is great. I agree w/ the choices you made re: highlighting selected building, swapping out the meaning of an outline of the building dots, etc. Approving and merging.
Note there is one small problem I found that this messed up with the page CSS a bit. On initial page load there is a page scroll bar with a tiny bit of play in it. If you then click to the project page and back, the scroll adds an extra full page of empty space at the bottom of the page.
There were only a couple CSS changes - were those needed for having the autoscroll work? Or was there any other reason?


Issue 54: rename name -> clientName so we can use sentinel

resolves #54

@skunight could we get a review on this when you get the chance?

@skunight 有时间麻烦尽快看一下 谢谢啦


Fix IPv6 format for DNS address received from android

Describe your changes
this adds the address in the expected format in Go [ipv6]:port
Issue ticket number and link
Checklist

[x] Is it a bug fix
[ ] Is a typo/documentation fix
[ ] Is a feature enhancement
[ ] It is a refactor
[ ] Created tests that fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

this adds the address in the expected format in Go [ipv6]:port

I think this would also have to be adapted for the Linux client.
Every ipv6 DNS address that I enter via the Management Gui results in this error message on a debian server client:
dial udp: address 2001:4860:4860::8888:53: too many colons in address


Add razor SDK to list of project SDKs

Adds Microsoft.NET.Sdk.Razor to the list of project SDKs.

Thanks @dasMulli. Changes look good to me but wanted @Rick-Anderson to confirm the terminology.


Missing space between log level and message when using ULOG_HIDE_FILE_STRING flag

I m not sure if its intended, but I noticed that when using the ULOG_HIDE_FILE_STRING flag, there is no space between the log level and the actual log message, so it is printed like this:
DEBUGinit_rdma_resources.

That's a bug. Will fix, thanks!

@hmars-t seems to be fixed. Feel free to reopen if I missed something


🐛 Fixed host limit error when resending a pending invite

refs https://github.com/TryGhost/Team/issues/587

It was not possible to invite a new Contributor to a site that has reached its limit
This fix divides the resend invite action into two separate steps: 1. Deleting existing invite 2. Creating a new one for the same data
It was hitting the limit because the permissions were correctly checking for "add" action being executed when the limit of invites/staff users was already used up. By removing existing invite we mimic the behavior the server would do for us anyway (https://github.com/TryGhost/Ghost/blob/2111992dd42cd9d9400eebea52006d023b4b19b3/core/server/services/invites/invites.js#L18-L22)

@rishabhgrg I struggled to figure out why the test for the invites was failing and not picking up the second request. I'm assuming the "run" block in which the invite.resend is placed doesn't wait till the second request to complete :thinking: Can you help with this? You have a lot more experience with Ember and it's test, so thought I'd reach out!

@naz Sorry missed this on Friday, will take a look here today on why tests are misbehaving :)

Thaaanks!


iOS PhoneGap Build error for undeclared type

Don't know if related to #10 but I can't get it built with Phonegap Build, also trying with cordova-plugin-add-swift-support added to plugin list.
Error is:
tmp/gimlet/2078210/project/build/JarvisDev.build/Release-iphoneos/JarvisDev.build/Objects-normal/arm64/ZeroConf.swiftdeps -o /tmp/gimlet/2078210/project/build/JarvisDev.build/Release-iphoneos/JarvisDev.build/Objects-normal/arm64/ZeroConf.o
/tmp/gimlet/2078210/project/JarvisDev/Plugins/cordova-plugin-zeroconf/ZeroConf.swift:10:34: error: use of undeclared type 'CDVPlugin'
@objc(ZeroConf) class ZeroConf : CDVPlugin  {
                                 ^~~~~~~~~
/tmp/gimlet/2078210/project/JarvisDev/Plugins/cordova-plugin-zeroconf/ZeroConf.swift:10:2: error: only classes that inherit from NSObject can be declared @objc
@objc(ZeroConf) class ZeroConf : CDVPlugin  {
~^~~~
/tmp/gimlet/2078210/project/JarvisDev/Plugins/cordova-plugin-zeroconf/ZeroConf.swift:15:19: error: method does not override any method from its superclass
    override func pluginInitialize() {
    ~~~~~~~~      ^

Hi @VittorioMobimentum
Looks like the Swift config isn't right. Bridging-Header file missing maybe.
I'd be happy if you or someone else could have a look at it as I'm not using PhoneGap and I won't be able to help right now.
Thanks


To add FederatedJob

@marun @font @onyiny-ang @pmorie.
To add FederatedJob with a pretty basic override (only spec.parallelism currently)
Thanks for having a look

@sdminonne Please make sure to commit generated code for placement and overrides separate from manual changes.

Please run sed -e s+marun/fnord+kubernetes-sigs/federation-v2+ on your changes.

@marun PTAL


Capitalize metadata to GET checksum

The standard formatting of the custom meta data seems to be capitalized.
Ensure that the look up works in that case. Also fix some complaints from
flake8.

The better way to solve this issue is to lower both the arguments given to the script and the keys returned by boto. Closing ...