Implement bootstrap methods for telegraf

DC/OS Telegraf needs the /var/lib/dcos/cluster-id file in order to start. Without this, if no other service is creating the cluster-id file, the service will just continuously restart.
Usually one does not see any issues if they have dcos-metrics enabled. Since dcos-metrics service is not mandatory we need the following fix so dcos-telegraf service can be able to start.
High-level description
Fix bug for DC/OS Telegraf.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-3947 DC/OS Telegraf missing bootstrap action.

Checklist for the PR

[x] Implement bootstrap methods for dcos-telegraf-master and dcos-telegraf-agent
[x] Add condition for /var/lib/dcos/cluster-id file existence to the Telegraf systemd service file

/LGTM

@mesosphere-mergebot bump-ee

Sorry for the delay on this PR @ionutbalutoiu, I'm still trying to track down a review from our security team. I estimate that'll happen early next week.

DC/OS Telegraf needs the /var/lib/dcos/cluster-id file in order to start. Without this, if no other service is creating the cluster-id file, the service will just continuously restart.

Individual DC/OS systemd units are expected to crash-loop until their dependencies are there. That is, while the cluster is bootstrapping, I consider this to be an expected error message and behavior.
I am not against this change, I can imagine various scenarios where it can be either useful or a strict requirement. But I didn't really understand the problem you ran into, and which you (and we) are trying to solve here. What was the state that you observed that you considered to be erroneous?
Maybe the best way to answer this question is: How would a test look like that fails deterministically without this change, and that passes deterministically with the change?

Usually one does not see any issues if they have dcos-metrics enabled. Since dcos-metrics service is not mandatory we need the following fix so dcos-telegraf service can be able to start.

I do not think this is a valid argument. The cluster ID is created by, for example, the Admin Router bootstrapper: https://github.com/dcos/dcos/blob/4961d8182917d102284f7a0ccc29e4c422913565/packages/bootstrap/extra/dcos_internal_utils/cli.py#L28. Admin Router is a core component of DC/OS, and it is up and running in each healthy DC/OS cluster.
I hope that I could make clear that I would like us to be more explicit and precise about the problem to be solved here. One problem explanation that I would consider valid is, for example: "Telegraf needs tom be fully operational before Admin Router".

I do not think this is a valid argument. The cluster ID is created by, for example, the Admin Router bootstrapper:

What I said before here is not valid for agent nodes. On agent nodes, Agent Admin Router does not have a bootstrapper:
https://github.com/dcos/dcos/blob/4961d8182917d102284f7a0ccc29e4c422913565/packages/adminrouter/extra/systemd/dcos-adminrouter-agent.service

Indeed, on agent nodes, dcos_metrics_agent is the only bootstrapper so far to create the cluster ID file.

Hello @jgehrcke!
Sorry for any of the confusions that I might have produced during my issue description.
Indeed, we were able to encounter this consistently on the open DC/OS deployments with dcos-metrics disabled for the agents. Therefore, the changes proposed in this pull request.
Let me know if there's anything that I help with this pull request.
Best regards,
Ionut

with dcos-metrics disabled for the agents.

@branden @philipnrmn @adamtheturtle how easy is it to test this via e.g. e2e here or in downstream integration tests?

Indeed, we were able to encounter this consistently on the open DC/OS deployments with dcos-metrics disabled for the agents.

@branden @philipnrmn @adamtheturtle how easy is it to test this via e.g. e2e here or in downstream integration tests?

E2E tests do not currently exist on the DC/OS OSS repository.
I imagine that this would be a few hours of work for the Tools Infra team.
To set up a cluster and run commands on it is easy. How easy this is equivalent to how easy it is to disable dcos-metrics on any cluster (I think). I will look now into how that is done.

@adamtheturtle Disabling metrics is just as simple as:
systemctl stop dcos-metrics-agent.socket
systemctl disable dcos-metrics-agent.socket
systemctl stop dcos-metrics-agent.service
systemctl disable dcos-metrics-agent.service

This is how we do it. However, we run this as a post-install script, so we end up with metrics disabled without even getting to create the /var/lib/dcos/cluster-id file.
You might need to do rm /var/lib/dcos/cluster-id after disabling metrics. After that, you can try and restart dcos-telegraf. See the consistent failures in journald, and then validate the changes from here.
Regards,
Ionut

Disabling metrics is just as simple as

Is this something DC/OS officially supports @philipnrmn @branden?

@jgehrcke We could make a test for this. However, my understanding is that we do not plan to do a release with both metrics and telegraf - is that right @branden ?
If so, I imagine that our integration test suite will catch this issue once dcos-metrics is removed.
Right now I don't think we have any tests which show what happens when a service is disabled.

@jgehrcke We could make a test for this. However, my understanding is that we do not plan to do a release with both metrics and telegraf - is that right @branden ?

That's correct. Telegraf and dcos-metrics are both in 1.12-dev so we can transition between them smoothly, but we intend to remove dcos-metrics before 1.12 is released.

If so, I imagine that our integration test suite will catch this issue once dcos-metrics is removed.

I think tests would still pass since dcos-signal runs everywhere and creates /var/lib/dcos/cluster-id, but get rid of that as well and then dcos-telegraf.service would indeed fail to start. The value I see in this PR is that it removes the potential for that confusion, by making the dcos-telegraf bootstrappers explicitly create the cluster-id file it requires, removing the implicit dependency between dcos-telegraf.service and unrelated bootstrappers that coincidentally also create that file. I'm not sure how to craft a useful test around that change given that the external behavior is the same, and we don't support the piecemeal disabling of individual components.

Nobody has done the modification in downstream yet. Let me look into this again.

I have pushed a relevant commit now.

How will we catch similar issues in the future?

@mesosphere-mergebot label shipit

@mhrabovcin I have addressed your comment and rebased against current master.

@mesosphere-mergebot bump-ee

Please run:
@mesosphere-mergebot override-status teamcity/dcos/test/aws/onprem/static https://jira.mesosphere.com/browse/DCOS_OSS-2115

@mesosphere-mergebot override-status teamcity/dcos/test/aws/onprem/static https://jira.mesosphere.com/browse/DCOS_OSS-2115

Looks like the Windows tox tests fail due to Python not being installed on the targeted TeamCity Windows slave. Can somebody take a look at that ?

All the checks are successful now. :)

All the checks are successful now. :)

Right, and the PR is on an integration train and will show as 'merged' in the moment that very train lands.


LPS-64993

Hey @thiago-rocha,
Attached is an update for http://issues.liferay.com/browse/LPS-64993.
Please let me know if you have any questions. Thanks!

/cc @kienD

Need to update commit message!

New Pull Request: https://github.com/thiago-rocha/alloy-ui/pull/85


chore: Create getTimestampAndDispatchMetadata_function in MediaSourceEngine

In conjunction with https://github.com/shaka-project/shaka-player/pull/5315 will allow create a new PR to simplify MSE operations when using sequence mode


arqv/ini no longer exists

When running zigmod fetch in the Zigmod source directory it attempts to download a number of dependencies. One of these (https://github.com/arqv/ini) is now a 404.

good catch. I have the code locally so if I can't find the place it might've moved to I will upload fork and change url
code is MIT Copyright (c) 2020 9hkke

user seems to be deleted from github and discord profile of author is now Deleted User#0000 I will be indeed forking it


Update uk_ua.json

Updated to en_us.json strings.

I changed the description of UPnP.

Added missing strings.

@Gaming32 does your mod ported on Bedrock Edition? I could help translate a file in specific branch.


Remove LOOP opcode and make jump offsets signed

Removing the LOOP opcode and using a signed offset in the jump opcode makes the list of opcodes cleaner. I made the offset in all jump opcodes signed to have them uniform.
If the range is too short I would extend the argument.

no need to extend the argument, if longer jump become necessary, another opcode could be used. The JVM has jsr_w and goto_w opcodes and the wide opcode for some others.

I like the idea behind this, but I ran into two problems:

It regresses performance a bit. I'm not sure why, but the benchmarks get about 5% slower on my machine with this.

It relies on undefined behavior. As far as I know, the C standard doesn't guarantee the results of casting a negative value to an unsigned type. This is a big part of the reason Wren has a separate opcode for LOOP: it ensures all of the numbers stored in the bytecode are unsigned.

Any ideas on if these can be addressed? Have you tried running the benchmarks on your machine?

As far as I know, the C standard doesn't guarantee the results of casting a negative value to an unsigned type.

Actually in this direction it seems to be well-defined. It's the unsigned to signed case that's left up the implementation:

<IP_ADDRESS> Signed and unsigned integers

When a value with integer type is converted to another integer type other than _Bool, if the value can be represented by the new type, it is unchanged.
Otherwise, if the new type is unsigned, the value is converted by repeatedly adding or subtracting one more than the maximum value that can be represented in the new type until the value is in the range of the new type.
Otherwise, the new type is signed and the value cannot be represented in it; either the result is implementation-defined or an implementation-defined signal is raised.

Found this on StackOverflow.

Ah, right. In either case, this patch goes in both directions. In the compiler, it goes signed -> unsigned, and in the VM it goes back from unsigned -> signed.

Sorry, I've been a bad open source maintainer. :(
I'm going to close this out since I don't think we'll be able to move forward with it.


Re-opening #3987: Ignoring cancel characters with playwright on string locators

Reopened https://github.com/codeceptjs/CodeceptJS/issues/3987
What are you trying to achieve?
To wait for a text containing a single quote '
What do you get instead?
An error
locator.isVisible: Unexpected token "s" while parsing selector ":has-text('Were you able to resolve the resident's issue?') >> nth=0"
      at Playwright.waitForText (node_modules\codeceptjs\lib\helper\Playwright.js:2584:79)

Provide console output if related. Use --verbose mode for more details.

On pageVendorWorkOrder: confirm no materials have been purchased
      I wait for text "Did you purchase any materials for this work order?", 20
      I click "No", ".m-modal-dialog-container"
    I wait for text "Were you able to resolve the resident's issue?", 1
  × FAILED in 55351ms

-- FAILURES:

  1) Working with work order as Mynd Tech @rtm-team @vendor-portal @severity-critical
       Completing work order when resident was not home:
     locator.isVisible: Unexpected token "s" while parsing selector ":has-text('Were you able to resolve the resident's issue?') >> nth=0"
      at Playwright.waitForText (node_modules\codeceptjs\lib\helper\Playwright.js:2584:79)

Provide test source code if related

// tried in different ways
I.waitForText("Were you able to resolve the resident's issue?", 10);
I.waitForText(`Were you able to resolve the resident's issue?`, 10);
I.waitForText('Were you able to resolve the resident\'s issue?', 10);

Details

CodeceptJS version: v3.5.9-beta.1
NodeJS Version: v18.16.0
Operating System: Windows & MacOS
Playwright

Also experiencing the same issue in v3.5.8


Class, record, and struct accessibility & Class, record, and struct member accessibility – improper differentiation

Since C# there can be distinguished between:
• class
• struct
• record (class)
• record struct
Also there are no extra accessibility rules that would make difference between record and corresponding classic type that is based upon so there is no reason to make difference or there should be exact enumeration. Like in table or similar.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8121f526-cfe4-091d-d031-2cdc274cd8ee
Version Independent ID: 76a389f6-b568-3568-6483-6df440f96f0c
Content: Access Modifiers - C# Programming Guide
Content Source: docs/csharp/programming-guide/classes-and-structs/access-modifiers.md
Product: dotnet-csharp
Technology: csharp-fundamentals
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

@Uzivatel919
I think what you're driving at is that a record, or record class is a class, and a record struct is a struct. Therefore the accessibility rules for class and struct apply. Yes, that can be clarified.
If you mean something different, let me know,.

@BillWagner, no, no you’re right.


Remove Google Analytics classic

Do not merge. To be deployed 2 June.
Following on from https://github.com/alphagov/govuk_frontend_toolkit/pull/194
On 2 June we plan to deprecate Google Analytics classic on GOV.UK, from then on we will only use Universal analytics. Google Analytics classic data collection techniques are being deprecated by Google. We should no longer support classic and new tracking should use only Universal.

Bump govuk_frontend_toolkit to pull in latest analytics
Remove references to classic tracker
Remove classic specific arguments (eg custom variable name and scope)
Update references of GOVUK.Tracker to GOVUK.Analytics
Rename StaticTracker to StaticAnalytics to match upstream refactor

Because the StaticTracker and StaticTrackerSpec files have been renamed, when reviewing I suggest looking at the individual commits.

:+1: LGTM

I've rebased this against master to pick up @edds’s latest change.


Feat(eos_designs): Dot1x needs to be redistributed in a EVPN fabric when enabled on an interface

When dot1x is "turned on", MACs go from being DYNAMIC learned to STATIC via dot1x learned.
Without the "redistribution dot1x" under the mac-vrf, these MACs don't get shared with remote VTEPs.
The proposed solution would be to automatically configure redistribution dot1x when configured on an endpoint.

I would suggest picking up on some global construct instead of having to parse all connected endpoints and detect the relevant vlans. Especially since this would give configuration changes under router bgp just because someone added a VLAN to a trunk or moved a server.

dot1x can also be configured as an interface profile for consistency across ports.

I have a customer facing the same issue. Current work-around: redistribute dot1x_ is set up with raw cli in AVD.
@ClausHolbechArista: I agree to you. A global knob to enable redistribution of static (dot1x) MAC into EVPN on the fabric would be sufficient. Having this configured on leafs/vlans without dot1x would not harm the dynamic redistribution.

There is interest in having the ability to define this as a node type level or even as a default for tenant SVIs.  And/Or the option to define at the tenant SVI layer, although that could potentially cause more touchpoints for config on a deployment that is all(or even most) dot1x enabled.


Submitting CoreOS v668.3.0 (beta) 2015-05-12 to app-catalog

Submitted on behalf of CoreOS, Inc (https://github.com/coreos)
url: http://beta.release.core-os.net/amd64-usr/668.3.0/coreos_production_openstack_image.img.bz2
hash: 2209106e9243559f9da5707586ffae567ccf5b806420cfeb0673870a91a068115ca924b77f2e9a88240a03dbf3e790a0190d0a8730cf6172034e5033e7622e05

Thank you for contributing to stackforge/apps-catalog!
stackforge/apps-catalog uses Gerrit for code review.
Please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


Deprecated DLP reporting cmdlets

November 2022 MC455898
You should update the page to indicate that Microsoft has removed this cmdlet from Microsoft 365.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 54810913-01ba-f2ed-76dd-3d810e4beeda
Version Independent ID: 1fd3a291-d8bd-13b9-785f-8fa88170c1f7
Content: Get-DlpDetailReport (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Get-DlpDetailReport.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

Checking

@JB-1, I believe you and the MC post; however, the affected cmdlets are still available to me in my plan ol' Microsoft 365 E5 tenant.
I added the following note to the top of the affected topics:

Note: This cmdlet will be retired. Use the Export-ActivityExplorerData cmdlet to view DLP information. Data from Export-ActivityExplorerData is the same as the retired Get-DlpIncidentDetailReport cmdlet.

And in Get-DlpIncidentDetailReport itself, I added:

Note: This cmdlet will be retired. Use the Export-ActivityExplorerData instead.

Having those warnings in those topics for a few days/weeks prior to removing the topics is valuable. MC455898 updated 2/7/23 talks about retiring the Reports landing page from the Microsoft Purview compliance portal by the end of March 2023. It's possible that these two things are related? In particular, MC495880 talks about retirement of the cmdlets in 'early February', which clearly isn't done yet.
I'll keep this issue open so we can monitor.
OK?

Thank you.  Some misc. information for you.  I've checked 2 tenants and they are both missing the Get-DlpDetailReport cmdlets, but they both have the Get-DlpIncidentDetailReport cmdlets.  The Get-DlpIncidentDetailReport cmdlet is returning data, but nothing newer than 2/27/2023, so I think that cmdlet is effectively retired.  The other cmdlets mentioned in the MC are also gone (Get-DlpDetectionsReport and Get-DlpSiDetectionsReport).

@chrisda

Cmdlets still visible to me in the two tenants I checked, so let's keep this issue open.

Cmdlets still available to me.

Cmdlets still available to me.


[WIP]Optimize anp document

Signed-off-by: lonelyCZ<EMAIL_ADDRESS>What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:

Does this mean to fix https://github.com/karmada-io/karmada/issues/2628?

Does this mean to fix karmada-io/karmada#2628?

No, only to fix spell error.
And karmada-host-control-plane is not easy to understand, because we usually use karmada-control-plane and karmada-host, but I neet to investigate why using this in the document, whether it is associated to Kind cluster name.

OK. Please assign it to @XiShanYongYe-Chang once it's ready.

PTAL~
/assign @XiShanYongYe-Chang


feature Convert release script to github [ch45701]

User pushes a tag, a prerelease/release is created with a changelog (if they want the changelog!)

Example of a prerelease triggered by pushing a tag:

@kuritz -- relevant:

Also :laughing:

@dillonjason oops! You were right haha

@kuritz I don't think there's any refactoring to do. Just waiting on yall!


Mention Web API (Core) error handling recommended practises

This article is focused on ASP.NET Core applications with views, so when developing Web APIs it doesn't really make clear what should be done and how.
I would suggest to add a section that explains recommended practises when handling errors in Web API ASP.NET Core projects.
You usually want responses from a Web API to be consistent (for example, to always be JSON with a common structure), so it would be nice to have an example of an error controller which returns a common response, and then an example code that shows how to "link" errors to the controller, like this:
app.UseExceptionHandler("/errors/500");
app.UseStatusCodePagesWithReExecute("/errors/{0}");

It's basically the information that you can find in this error handling article in the "Handling global errors" section, but I think it would be better to have some parts of it in the official documentation.
Thanks!

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e03fdf4-b19b-17c3-04f4-336ab6d2ee06
Version Independent ID: 38515dfb-91a5-b395-db9d-084bbaf095c8
Content: Handle errors in ASP.NET Core
Content Source: aspnetcore/fundamentals/error-handling.md
Product: aspnet-core
GitHub Login: @ardalis
Microsoft Alias: tdykstra

Thanks @matteocontrini ... great idea.
I'll take it on, but it's going to be a little while before I can get to it. 🏃🏃🏃🏃😅 If you or a member of the community would like to address it before I'm free, please let us know.

app.UseStatusCodePages(async context =>
{
    context.HttpContext.Response.ContentType = "text/plain";

    await context.HttpContext.Response.WriteAsync(
        "Status code page, status code: " +
        context.HttpContext.Response.StatusCode);
});

Copy pasted, does not build.

wow this is confusing! I was not referencing Diagnostics. Both UseStatusCodePages from Diagnostic and builder use the same middleware under the hood?

The IApplicationBuilder namespace (Microsoft.AspNetCore.Builder) exposes the extension method after the package is referenced by the app. All of the middlewares in the framework work the same way (the ones provided by Microsoft; 3rd party may require one to reach the middleware using a different namespace). You add the package, then you only need to have the namespace for Microsoft.AspNetCore.Builder to get the middlewares configured and added to the pipeline in your Startup code.
There's a brief ...... very brief .... remark about it in this section of the Middleware topic ...
https://docs.microsoft.com/aspnet/core/fundamentals/middleware#write-middleware
... where it says ...

The following extension method exposes the middleware through IApplicationBuilder:

... and then there's an example.
I do think it could be stated in a more general context earlier in that topic. Unfortunately, this one didn't hit the radar for recent updates to the Middleware topic on #8209. I'll open a new issue to address it. Sorry you hit this ... I think we can take this opportunity to make that point clear in the topic.

I am sorry actually my problem was not about the extension method not being found, but this.

But the strange thing is that my intellisense show HttpContext when I type context.. But the compiler is not resolving the same type.

Then I specify the type explicitely, seems to work, though no WriteAsync.

Add ...
using Microsoft.AspNetCore.Http;

... and see if that does the trick.

... and don't specify the type explicitly. Go back the original code from the topic.

Ok it worked, so in summary.
+ using Microsoft.AspNetCore.Http;
- app.UseStatusCodePages(async context =>
+ app.UseStatusCodePages(async (StatusCodeContext context) =>

This is very curious that my intellisense correctly infer context to be from type StatusCodeContext , but not the compiler (C# 7.3)

OK sorry I tried again,  with
+ app.UseStatusCodePages(async context =>

It pass correctly.
without  using Microsoft.AspNetCore.Http;, the error message was about context being infered HttpContext by the compiler, but not if I include Microsoft.AspNetCore.Http. Very strange.

Yes, Microsoft.AspNetCore.Http exposes the property Microsoft.AspNetCore.Diagnostics.StatusCodeContext.HttpContext ...
https://docs.microsoft.com/dotnet/api/microsoft.aspnetcore.diagnostics.statuscodecontext.httpcontext
In order to clarify how to make the code sample work, I'll add comments to the topic for both the Diagnostics package and the Microsoft.AspNetCore.Http namespace.
I'll ping u on the PR, and you can let me know how the revised text looks.

The first round of that is just the package .... I'll add the namespace language on the next commit.

In WebApi it was possible to write a global exception handler and replace the default exception handler with 1 line of code:
config.Services.Replace(typeof(IExceptionHandler), new MyGlobalExceptionHandler());
This allowed me to throw exceptions in my code regardless of the client code (restful service or otherwise), then it was my global exception handler that would test exception type and generate proper response in web api. For example in MyGlobalExceptionHandler:
if (exception is RootObjectNotFoundException)
{
context.Result = new SimpleErrorResult(context.Request, HttpStatusCode.NotFound, exception.Message);
return;
}
This would remove all the ugly try/catch clutter from all controllers and decouple domain logic code from the client code (in this case web api) and centralize response generation in exception cases (higher cohesion).
I was expecting to see instructions for such a pattern here.

Sorry, this is the rest of the above message:
To achieve the same goal, I had to do this:
in Startup.Configure:
        app.UseExceptionHandler(errorApp => {
            errorApp.Run(async context => {
                var error = context.Features.Get<IExceptionHandlerFeature>();
                if (error != null) {
                    var ex = error.Error;
                    await _exceptionHandler.Handle(ex, context.Response);
                }
            });
        });

where _exceptionHandler is an instance of MyGlobalExceptionHandler class:
public class GlobalExceptionHandler {
    internal async Task Handle(Exception exception, HttpResponse response) {
        if (exception is CallerNotFoundException) {
            response.StatusCode = 404;
            response.ContentType = "text/plain";
            await response.WriteAsync(exception.ToString(), Encoding.UTF8);
            return;
        }

        response.StatusCode = 500;
        response.ContentType = "text/plain";
        await response.WriteAsync(exception.ToString(), Encoding.UTF8);
    }

Obviously, sending exception details to client is not a good idea. So, the above code should not be used in production.

Hi guardrex, it's been a while since your last comment - i know you said you guys were rammed but i was wondering if you had any estimate for when the recommended practices for web api would be added to the help docs?

I don't at this time. I'm just getting past my portion of the 2.2 RTM work, and I have some high priority IIS/Azure Apps work to do by year's end.

This seems to be a very popular Stackoverflow answer on the topic of exception handling middleware.
https://stackoverflow.com/a/38935583/16940
Some official guidance would still be very welcome. The Core documentation on the whole is excellent, but sometimes there are notable holes like this for seasoned developers looking for 'the new way' to do something.

@danroth27 	please review and assign someone to provide guidance on Web API exception handling.

There are updates headed to the topic now on https://github.com/aspnet/Docs/pull/11242. It's in review.
The middleware scenario described in the SO post can easily be handled by the framework's Exception Handling Middleware that takes the lambda. I also added content on getting some :heart: out of IExceptionHandlerFeature in a controller or page. The OOB Exception Handling Middleware is fairly powerful stuff 💪.

@glennc is the right person to handle this.

You usually want responses from a Web API to be consistent (for example, to always be JSON with a common structure)

I agree that the Web API exception handling documentation should be improved and this is the most important part.
Right now, there are a few pitfalls with exception handling for Web APIs:

The project templates already contain code that returns HTTP from API calls. No REST client would want that.
For the plain Web API template it's only the UseDeveloperExceptionPage in development environment, but I'd say even that is questionable.
For the MVC template the UseExceptionHandler call for production environments gets problematic as soon as you add API controllers.
If you want to have both view and API controllers in one project, you have to configure the exception handlers correctly for each part (view controllers should return an error page, but API controllers should either return no body or return an error object as JSON).
One way to do this is shown here: https://github.com/christianacca/ProblemDetailsDemo/blob/master/src/ProblemDetailsDemo.Api/Startup.cs#L60

Maybe the documentation should mention the package Hellang.Middleware.ProblemDetails. It is very useful for API exception handling.

I'm new to dotnet core, currently I found 3 ways to do exception handler in asp dotnet core web api.

Config UseExceptionHandler as the document says
Use an exception handler middleware as stackoverflow question says
Use controller helper functions like BadRequest()

I prefer to use controller helper function but these functions don't throw an exception. Would be help to built in some basic http exceptions and let these helper functions throw exception.

I generally prefer to use IExceptionFilter than UseExceptionHandler when using MVC. If you use content negotiation(MVC feature) then exception filters are better because they respect it. With UseExceptionHandler you set your Content-Type explicitly which completely ignores content negotiation. The docs don't mention that.

Hello,
I'm Prince. I would like to share alittle priece of code concerning error handling with or without the /api path.
app.UseWhen(
context => !context.Request.Path.StartsWithSegments("/api"),
a =>
{
a.UseStatusCodePagesWithReExecute("/Home/Error{0}");
a.UseExceptionHandler("/Home/Error");
}
);
            app.UseWhen(
                context => context.Request.Path.StartsWithSegments("/api"),
                a =>
                {
                    a.UseStatusCodePagesWithReExecute("/Home/Error{0}");
                    app.UseExceptionHandler(errorApp =>
                    {
                        errorApp.Run(async context =>
                        {
                            var feature = context.Features.Get<IExceptionHandlerPathFeature>();
                            var exception = feature.Error;

                            var result = JsonConvert.SerializeObject(new { error = "Internal Server Error" });
                            context.Response.ContentType = "application/json";
                            await context.Response.WriteAsync(result);
                        });
                    });
                }

Is there any built-in method for global error logging?

The problem I've seen with all implementations of exception handlers so far is that they completely ignore content negotiation.
If the client has stated that they only accept XML, and the rest of your API can provide XML responses, then the exception result returned should be no different.

The easiest robust and portable (with respect to content negotiation and such) method to handle errors in WEB API apps is the one mentioned by @matteocontrini in the very first comment. ASP.NET Core team, please add a section to the documentation which advises the readers to use it!

This was fixed in #14366 and will go live today. cc @pranavkm @scottaddie


Resolve Xcode build warnings

Adds explicit references to self in ivars
Resolves SwiftLint warnings

Also:

Removes unused #import statements (using AppCode)
Removes needless parentheses (using AppCode)
Applies dot notation where available (using Xcode's migrator)

@Eitot : I still have warnings like :
OverlayStatusBar.swift:221:17: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)

and
FilterView.swift:24:28: warning: Implicitly Unwrapped Optional Violation: Implicitly unwrapped optionals should be avoided when possible. (implicitly_unwrapped_optional)

Is it the same for yours ?

Nope, no warnings here. Travis doesn’t have them either. Which version of Swiftlint are you using? Are you applying the config file as well?

You're right, warnings do not appear after upgrading to latest version of Swiftlint


Support PlotlyBase

Hi, that's a fantastic package, thank you! Would it make sense to support the PlotlyBase interface? We have lots of Plotly code + Interact, which would be much nicer as a unified dash application, but porting it would take time. Supporting PlotlyBase would make it easier.

Hi
I think it’s possible, but I need to take a closer look at PlotlyBase

Look at this example
Is that what you need?

I think so! I won't have time to look at it over the week-end, but maybe on Monday.

@cstjean I added support of the PlotlyBase interface to master. Look at Plot usage in layout, Plot usage in callback


Domains as aliases

Script is working flawlessly with DSM7.1 however I would prefer to use a single certificate with multiple domains as aliases (in my case the root + wildcard domain). Any chance of this getting implemented?

Yep, this should be pretty straightforward. However, for your specific case (wildcard + non-wildcard) I have to check with the ACME standard is it possible.

Same request here, I would like to use a single certificate with 2 wildcard domains like *.internal.domain, *.domain. I manually created such certificates with acme before. It could be as simple as changing the DOMAINS environment variable to accept ";" as the delimiter instead of the ","

@Jaco1960 I am not sure that ACME (Let's Encrypt protocol) will let us issue multiple wildcard domains under one CN. I have to double-check :sweat_smile:


kafka(ticdc): sarama admin client used cached topic and partitions

What problem does this PR solve?

Issue Number: ref #8225
What is changed and how it works?

admin client use cached client's topics and partitions

Check List
Tests

Unit test
Manual test (add detailed scripts or steps below)

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`

/run-all-tests

/merge

/run-kafka-integration-test


PR proposition : SDK admin mode + impersonation

Is your feature request related to a problem? Please describe.
I have two use cases which required me to extend the Apollo Client:

In my serverless functions, I sometimes send queries / mutations as an admin (so x-hasura-admin secret set in the headers), or as the user by using impersonation (x-hasura-admin-secret + x-hasura-user-id + x-hasura-role set in headers).
I implemented an impersonation feature for my app. As a support team member, I can impersonate a user when I receive a support request

Describe the solution you'd like
I would like the Nhost SDK to expose those methods

setAdminSecret(string): void
impersonateUser(impersonateOptions: {userId: string, role?: string, [key:string]:string})
isAdmin(): boolean
isImpersonatingUser(): boolean

I would like those methods to be part of Nhost SDK and also the getHeaders method to take into account the impersonation / admin mode to return x-hasura-admin-secret + x-hasura-user-id + x-hasura-role set in headers.
Describe alternatives you've considered
Currently, I wrapped Nhost client and apollo client in a custom extended apollo client which has those methods:

While I agree the functionality is interesting and useful I personally think we could implement this in a more generic way. Instead of adding more methods to the SDK targeting a this specific workflow what I'd propose is simply to allow attaching arbitrary headers to each method/request, that way you can send any combination of headers you want to implement whichever workflow you need/want to implement.


Support Dotnet core without the need of referencing Microsoft.NETCore.Portable.Compatibility

Hi there,
I'm using your nice library in a dotnet core 1.1 project. Unfortunately I'm seeing errors like
The type 'ValueType' is defined in an assembly that is not referenced. You must add a reference to assembly 'mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e, Retargetable=Yes'. [netcoreapp1.1]
I can somehow work around this by referencing Microsoft.NETCore.Portable.Compatibility but it would be nice if your library would support dotnet core directly.
Kind regards

Hey @jp7677,
Are you able to update the package to version 1.1.1? That version should correctly support .NET Core. You can see the changes since then here https://github.com/omar/ByteSize/releases.
Let me know if that works.

Hi,
Thanks for your response, I'm using the latest version from nuget, 1.2.4.
Should I downgrade?
On do 19 jan. 2017 at 18:27, Omar Khudeira<EMAIL_ADDRESS>wrote:

Hey @jp7677 https://github.com/jp7677,
Are you able to update the package to version 1.1.1? That version should
correctly support .NET Core. You can see the changes since then here
https://github.com/omar/ByteSize/releases.
Let me know if that works.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/omar/ByteSize/issues/27#issuecomment-273841558, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQa-3fFfJ8SXTYgfKY6qdc52fgdpL8G8ks5rT50bgaJpZM4LoOeh
.

Oh, I misread your original comment. Let me take a look at this later tonight and I'll get back to you. I thought the library supported .NET Core just fine, but I guess I missed something.

Can you see if v1.2.5-alpha works for you? I ended including NETStandard.Library as a dependency for netstandard, but I'm not 100% sure that's what I'm supposed to do.

Unfortunately using 1.2.5-aplha didn't work. Looking at you code I guess some more work is needed for proper net core support. I gave it a try, see https://github.com/omar/ByteSize/pull/28.

I just published alpha2. Can you see if that works for you?

Hi @omar, yes, that one works perfectly for me. Thanks for continuing my work!

PS: Please do not use the complete netstandard library as dependency in the project.json (https://github.com/omar/ByteSize/blob/netstandard/src/ByteSizeLib/project.json), it's advisable to refer only that packages that you really need for libraries like yours.
See also https://docs.microsoft.com/en-us/dotnet/articles/core/deploying/reducing-dependencies.

Thanks for pointing that out, but it seems to contradict this answer. Looks like to future proof this it's best we depending on the full library. Let me know your thoughts.

To stay inline with older versions of the package, I went ahead and only referenced the specific packages we need. I'll kick the can down the road for when to depend on the netstandard library.

I just published v1.2.5 with the proper support for .NET Standard 1.0. Thanks for your help.

Thanks for the link, I wasn't aware that ideas are shifting towards referencing the complete package. I guess it's a wise move to do so with netstandard2.

PS: You still have a reference to the no longer existing ByteSize.Dotnet.csproj in your readme. Furthermore since I guess you are running the unit tests in netcore only you can remove the last #if NETCOREAPP1_1 as well.

Thanks for pointing that out. I just fixed both issues.

Cheers! ;)


Improve output structure of a PR Repository for developer and admin

We need to improve the existing the naming structure of  the repo folder name . It will be better that the below two links are used  for  developers ("Field") and administrator("Last modified") as following:

:octocat: cibot: Thank you for posting issue #410. The person in charge will reply soon.

@ohsewon proposed the  output structure of "Name" field.
s/date_pr/pr_date


macOS PKG Installer Not Installing Docker

macOS installer only works if Docker pre-installed on host. Needs to install for user.
For 0.0.9 I just left out the DMG from the PKG to minimize download time as DMG is not being used by PKG.

once this is resolved I will do #56

addressed in #59


debug_spi.py build broken

Thanks for all the hard work on Luna.
I would like to inform you of an issue which was introduced in commit https://github.com/greatscottgadgets/luna/commit/db754379448e606c4e80bb499ef052abcaec4183
If I build debug_spi.py with code after this date it does not build correctly and the hierarchy is flattened.
starmans@starmans-virtualbox:~/Downloads/luna/examples/hw_features$ python3 debug_spi.py --dry-run
WARNING | __init__    | Couldn't auto-detect connected platform. Assuming LUNA r0.2.
INFO    | __init__    | Building for LUNA r0.2...
/home/starmans/Downloads/luna/luna/gateware/utils/cdc.py:45: DriverConflict: Signal '(sig output__sdo__o)' is driven from multiple fragments: top, top.<unnamed #3>; hierarchy will be flattened
  output = Record.like(signal)
Warning: Wire top.$flatten\interface.$sample$s$serial_clock$sync$1 has an unprocessed 'init' attribute.
INFO    | __init__    | Build complete.

If I do a git checkout
git checkout f54de01c9dc13aeca5d20734a9c103227cb9603f

Subsequently a build
starmans@starmans-virtualbox:~/Downloads/luna/examples/hw_features$ python3 debug_spi.py --dry-run
WARNING | __init__    | Couldn't auto-detect connected platform. Assuming LUNA r0.2.
INFO    | __init__    | Building for LUNA r0.2...
INFO    | __init__    | Build complete.

The flattening error disappears.
It should be relatively straightforward to test.
Regards,
Rik

in cdc.py on line 64 (currently), I read
if isinstance(signal[name], (Record, Pin)):

Before commit commit https://github.com/greatscottgadgets/luna/commit/db754379448e606c4e80bb499ef052abcaec4183 this was ,
if isinstance(signal[name], Record) and (len(layout.fields) > 1):

If I go back to the old change. The code again works and I do not get complaints about missing clocks etc.

Update 2-06-2024, bug is still there

okay gonna close this if there is a pull request which is gonna fix this


Removed myself

Docs Build status updates of commit 0ca48dd:
:warning: Validation status: warnings

File
Status
Preview URL
Details

advocates/index.html.yml
:warning:Warning
View
Details

advocates/index.yml
:warning:Warning
View
Details

advocates/james-turnbull.yml
:white_check_mark:Succeeded

advocates/map.yml
:white_check_mark:Succeeded
View

advocates/media/profiles/james-turnbull.png
:white_check_mark:Succeeded

advocates/toc.yml
:white_check_mark:Succeeded
View

advocates/index.html.yml

Line 0: [Warning] Invalid file link:(~/tweets).
Line 0: [Warning] Invalid file link:(~/map).

advocates/index.yml

[Warning] Unable to find uid "advocates.brian-holt".
[Warning] Unable to find uid "advocates.brian-peek".
[Warning] Unable to find uid "advocates.bridget-kromhout".
[Warning] Unable to find uid "advocates.jessica-frazelle".
[Warning] Unable to find uid "advocates.jonathan-giles".
[Warning] Unable to find uid "advocates.marcelo-bellinaso".
[Warning] Unable to find uid "advocates.sarah-drasner".
[Warning] Unable to find uid "advocates.tim-heuer".
Line 0: [Warning] Invalid file link:(~/media/profiles/marcelo-bellinaso.png).
Line 0: [Warning] Invalid file link:(~/media/profiles/bridget-kromhout.png).
Line 0: [Warning] Invalid file link:(~/media/profiles/jonathan-giles.png).
Line 0: [Warning] Invalid file link:(~/tweets).
Line 0: [Warning] Invalid file link:(~/media/profiles/jessica-frazelle.png).
Line 0: [Warning] Invalid file link:(~/media/profiles/brian-holt.png).
Line 0: [Warning] Invalid file link:(~/media/profiles/brian-peek.png).
Line 0: [Warning] Invalid file link:(~/map).
Line 0: [Warning] Invalid file link:(~/media/profiles/tim-heuer.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


add support for WAX630

add support for WAX630

Huh, I see two failures...  I have no idea... did I fail to include something in my changes?  I'm an old Subversion user (for decades), but not very familiar with GitHub and forked development with pull requests.


Version bump

I created this PR because I was trying to generate a new PyPI release for Sorl thumbnail, but I just noticed this:
https://github.com/jazzband/roadies/issues/69
So I guess we have to wait until the password is added, right?

I'll close this in favor of #507


Cannot find module 'node:util'

Environment
Cannot find module 'node:util'
Reproduction
Cannot find module 'node:util'
Describe the bug
Cannot find module 'node:util'
Additional context
Cannot find module 'node:util'
Logs
Cannot find module 'node:util'

Try importing from unenv/node/util instead. unenv will likely already be in your node_modules

got the same issue

in my case, this is solved using newest node (14.21) when running nuxt 2


v2/Documents/Download Returns DocumentListItem instead of filename if unauthorized

On a document download request, if it's unauthorized, instead of returning an error, the API library returns the Solr results (abstract, etc.) and the server tries to return that in the filename field.
When authorized to download, the return is correct.
The server should return a 401 error instead in this case.
(reported by @lhorne-gavant )

@nrshapiro I did not realize you were no longer relying on cookies to authenticate these download requests (in discussions w/ @adistasio in the past, he mentioned you still intended to have cookies set on the api/pads domains). Since we are not initiating these download requests in-javascript via ajax/fetch (to circumvent issues with handling files in-memory), we cannot set the session ID header like we can for normal API requests.
Do you have an alternate means of authenticating these downloads? Usually in this case you either have to do it via cookies, or by adding a param to the url that takes the user's session ID, e.g. GET /v2/Documents/Downloads/PDF/IJP.077.0217A/?SessionID={string}

@billdami - ok, the 9/28 release on stage supports client-session and client-id from

the header , but if not found:

the query parameters, but if not found,

a cookie, named client-session and client-id respectively.

Thanks @nrshapiro. So just to confirm the format, the query param based method would be:
GET /v2/Documents/Downloads/PDF/IJP.077.0217A/?client-id=2&client-session=ABC-123

yes. it should work like that!

@billdami
I tested that in Postman and I had a prerequest script sticking the client-session in the header, so my test was invalid.  There was a naming issue with the variables...fixed in a version I will upload to stage shortly (if it passes the general tests...working on a few things as you'll see in the Changelog https://github.com/Psychoanalytic-Electronic-Publishing/OpenPubArchive-Content-Server/wiki/OpenPubArchive-Content-Server-CHANGELOG.md

Should work in the latest 2020.0929.1 build on stage.  Close when confirmed.
Original document return in filename is fixed as well.  I can't seem to get the PaDS authorization in Postman to work to confirm right now though, so leaving it open.

@nrshapiro This has been updated on stage however the download still doesn't work with an error of
{"detail":"No permission for document The requested document None could not be returned."}
https://stage-api.pep-web.rocks/v2/Documents/Downloads/EPUB/IJP.077.0217A/?client-id=2&client-session=REDACTED

@nrshapiro  This has been updated on stage however the download still doesn't work with an error of
{"detail":"No permission for document The requested document None could not be returned."}
/v2/Documents/Downloads/EPUB/IJP.077.0217A/?client-id=2&client-session=REDACTED

@adistasio
Well the error was only when you weren't authorized, so that had nothing to do with it.  It's always been working, BUT perhaps you weren't sending over client-id=2 (which was required to check with PaDS in that code before...but I removed that anyway in the last rebuild, since today I completely switched the API over to PaDS authentication and thus all my tests had to be converted to using PaDS and logging in via PaDS.  And I just tested it on your client (since I loaded that version to Stage) and it works fine for downloads.
However, I actually had to put it on stage without testing with the Stage data because apparently after the last database/solr/schema load, the IPs changed, and I must be blacklisted again...I can get to stage-solr interactively, but if I set my local copy of the server to try to connect there (which is how I test with the remote data), it can't connect to Solr anymore.  (So I just went ahead an pushed the version without testing with that data (which I like to do first).
Perhaps you can look into whitelisting me again.  but that's another topic, as far as I can tell, this issue is closed...


Provide ansible playbook for kafka deployment

Provide an ansible playbook that deploys kafka.
Purpose of this playbook is to replace the ant target
startKafka
in services/kafka/build.xml

PR #119 merged. closing.


[Bug]: The openai deployment model takes twice as long to deploy as fastapi's approach to offline inference.

Your current environment
vllm=0.4.2

🐛 Describe the bug
Same input and output, openai is slow

openai:  python -m vllm.entrypoints.openai.api_server

fastapi:
from vllm import LLM, SamplingParams

# Sample prompts.
prompts = [
    "Hello, my name is",
    "The president of the United States is",
    "The capital of France is",
    "The future of AI is",
]
# Create a sampling params object.
sampling_params = SamplingParams(temperature=0.8, top_p=0.95)

# Create an LLM.
llm = LLM(model="facebook/opt-125m")
# Generate texts from the prompts. The output is a list of RequestOutput objects
# that contain the prompt, generated text, and other information.
outputs = llm.generate(prompts, sampling_params)
# Print the outputs.
for output in outputs:
    prompt = output.prompt
    generated_text = output.outputs[0].text
    print(f"Prompt: {prompt!r}, Generated text: {generated_text!r}")

To better understand the issue, please show how you timed the code. You might have included the startup time of the offline inference LLM.

I made the wrong comparison


List the PackageIdentifier of the package to be added to automation
Giorgiotani.Peazip
Details about the application
GitHub release
Look for exe and msi

Already there: https://github.com/vedantmgoyal2009/vedantmgoyal2009/blob/main/winget-pkgs-automation/packages/g/giorgiotani.peazip.json


Replace dependency for faker

Faker takes up 5Mb while only contributing to random user agents.
Using another library would be better, for example https://www.npmjs.com/package/rand-user-agent.

I searched for random user agent packages for a while, but all of them, besides Faker, rely on an external source and a preset list to generate their user agents. The one you just suggested wouldn’t work because it fetches from a MySQL database that has to be run by the user to retrieve a list of user agents, then updates a JSON file to pick a random user agent. Ignoring the fact that this library wouldn’t work at all, I also refuse to have DUB fetch from an external database to get user agents or pick from an existing list, which could easily lead to DUB users being profiled. I suggest you review the source code of the libraries you recommend before suggesting them.


How to use it?

How to use it?I have to Compile it batch file and then ?

You simply import the project into Visual Studio and run it, then run the AssaultCube game at the same time.
If you don't want to compile and just want to use it, I have added a release build you can simply download and run: https://github.com/0XDE57/AssaultCubeHack/releases


Custom component themes are broken

Current Behavior
Custom component subthemes don't work.
Expected Behavior
If I have a theme called custom and a component called Link then the Link component should use the custom_Link theme.
https://tamagui.dev/docs/intro/themes#component-themes
Tamagui Version
Broken in 1.76.0-1.79.7
Last working version 1.75.9

Platform (Web, iOS, Android)
Web
Didn't test ios/android

Reproduction
https://codesandbox.io/p/devbox/focused-hill-j6vty4?file=%2Fpackages%2Fapp%2Ffeatures%2Fhome%2Fscreen.tsx%3A40%2C14

System Info
  System:
    OS: Linux 6.1 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
    CPU: (2) x64 AMD EPYC
    Memory: 104.06 MB / 2.01 GB
    Container: Yes
    Shell: 5.1.4 - /bin/bash
  Binaries:
    Node: 16.17.0 - /usr/local/bin/node
    Yarn: 3.6.3 - /usr/local/bin/yarn
    npm: 8.15.0 - /usr/local/bin/npm
    Watchman: 20220528.183901.0 - /usr/local/bin/watchman
  npmPackages:
    @babel/runtime: ^7.18.9 => 7.21.0
    @manypkg/cli: ^0.19.1 => 0.19.2
    check-dependency-version-consistency: ^3.0.3 => 3.0.3
    eslint: ^8.21.0 => 8.39.0
    node-gyp: ^9.3.1 => 9.3.1
    prettier: ^2.7.1 => 2.8.8
    turbo: ^1.10.3 => 1.10.3
    typescript: ^4.9.4 => 4.9.5

Likely due to not having light_custom and light_custom_Link I assume its under the root light so it doesn't find it. Still a bug but at least easy to fix in the interim.

I updated the reproduction sandbox, but my defaultTheme is set to custom so I would expect that I don't need to prefix with light if I'm not using that theme anywhere in my app.
I tested again, 1.75.9 is the last working version, 1.76.0 is the first version this broke and component themes are still broken in 1.79.7

It's hard to tell from the codesandbox what the correct pattern for custom themes should be.
From reading the docs, it seems like this is the correct pattern?
import { Button, styled } from 'tamagui'

export const CustomButton = styled(Button, {
  name: 'CustomButton',
  backgroundColor: '$green10',
  color: '$green10',
})

export const dark_CustomButton = {
  backgroundColor: '$red10',
  color: '$red10',
}

export const light_CustomButton = {
  backgroundColor: '$blue10',
  color: '$blue10',
}

In either case, it doesn't set the component theme based on the prefix theme objects like I'd expect.
Coming from a starter-free base w/ Tamagui v.1.75.9

New version fixes a few component theme things, lmk if still an issue


Support for Client ID Documents

As per  https://github.com/solid/solid-oidc/blob/a5a966c7342da01a57bfb316e5533ea7d82fd245/index.bs#L163-L166

This also implies that clientId is an IRI which means it doesn't easily fit into routes like https://github.com/pdsinterop/solid-nextcloud/blob/7162a2c30be90aeb9c1d636eae19f60bcfc751d7/solid/appinfo/routes.php#L13-L15


Added the sponsors logos & devangi photo.

Added the sponsors logos & devangi photo.

all looks good


Changed page[after] to page[cursor]

Fixed page[after] as it should be page[cursor].

Closing as page[after] is correct for /pub/result endpoint.  Will create new ticket to fix existing endpoint doc.


Detect IT_PASSPORT

Italian citizens are issued a unique passport number for international travel. This sequence contains personally identifiable information such as their full name, address, race, gender, etc. Government entities utilize this sequence to monitor the movement of their citizens. Unauthorized access to this information can result in identity theft, leaving individuals susceptible to financial loss and legal concerns. Additionally, unauthorized individuals could enter and exit the country posing a national security threat. Compliance with international data protection guidelines and general safeguarding is paramount to prevent the misuse of people's personal information.
For more information about IT_PASSPORT
Will detect in the format CC0000000, with two letters followed by seven digits.
Will use XX0000000 as a test example

Looks good

This is a good explanation of IT_passports. I see how following international data protection guidelines to protect personally identifiable information is necessary.


menu not cleared after selecting "mute topic"

I often scan down my messages using the keyboard, and then hit i down down down enter to mute topics I'm not interested in. I think that it used to clear the i menu when I hit enter, but it no longer does (maybe as of the last few weeks or so?).
I guess it's just an extra escape to clear the menu, but it seems like normally once you've selected something from the menu you don't need to select another thing (especially because the message you had selected isn't displayed any more).

I would like to work on this issue. Any guidelines or pointers on where to get started?

This is a duplicate of #2366 and was fixed in 4935f0c693d489fbaae44a4f60fb76d19e6f6ba1.

(Thanks for reporting @ssfrr and offering to help @Katy310!)


Rename OriginSSLProtocols to OriginSslProtocols for distributions

Description of your changes
Original ticket of issue here https://github.com/crossplane/provider-aws/issues/894
Creating a distribution with a custom origin was stuck infinitely reconciling every second. After looking into this, it was due to a naming difference between provider-aws and the aws sdk where for provider-aws the variable was OriginSSLProtocols and for aws-sdk it was OriginSslProtocols.
Thus, while copying unset values in the responseObject to the crObject (https://github.com/crossplane/provider-aws/blob/master/pkg/controller/cloudfront/lateinit.go#L173) it would skip over the OriginSSLProtocols since the FieldByName function used here (https://github.com/crossplane/provider-aws/blob/master/pkg/controller/cloudfront/lateinit.go#L217) is case-sensitive. I updated the variables to match case.
Rename OriginSSLProtocols to OriginSslProtocols to match AWS SDK

Fixes #894
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
I built the image with the changes. The image is available here (gstramandinoli/provider-aws:debugv35). I deployed the provider-aws. I deployed a distribution with a custom origin. I monitored the logs and saw that it was not reconciling infinitely anymore. In AWS console I saw that the distribution was successfully deployed. I modified the distribution and changed a parameter. I checked teh provider logs again and saw that it successfully updated the distribution. I checked in AWS console that it also updated there. I then disabled the distribution and cross checked again that the changes were reflected. I then deleted and cross checked that the changes were reflected.

@gstramandinoli can you add DCO ?

Hi @gstramandinoli ! Thanks for the PR! The files prefixed with zz_ are generated by the ACK code generator, so if you made changes to those files manually then they won't survive a make reviewable. I wonder why our tests in GH actions didn't run to catch it.
@ulucinar would you mind taking a look at this issue since it's related to reflect-based late-initializer behavior?

@ulucinar I have an attempted fix in #922.

@gstramandinoli  thanks for your work - it is now fixed and merged via #922


Maybe libxcb-dri3.so.0 needs to be blacklisted

/usr/lib/x86_64-linux-gnu/libGLX_mesa.so.0: undefined symbol: xcb_dri3_get_supported_modifiers

Not bundling libxcb-dri3.so.0 solves this.
Maybe libxcb-dri3.so.0 needs to be blacklisted.

Happens now with OpenSCAD AppImages built on OBS.
Another pointer where an application is affected, pointing out the xcb-dri3 lib: https://github.com/GoldenCheetah/GoldenCheetah/issues/2915

Also affected: https://github.com/SuperTux/supertux/issues/928

How can that be communicated to OBS builds? Those are still broken with this error message.

Still getting the same error (on Debian/Testing) from the build just now (25-Nov-2018 15:56).


Add Azure Support (in lieu of a PR)

This is an updated version of #9  targeting v3.4.0, but due to https://github.com/privacysandbox/data-plane-shared-libraries/issues/6, we can't create a PR in the data plane targeting the exact revision used there, so instead we are raising issues for both linking PRs in our fork:
https://github.com/KenGordon/bidding-auction-servers/pull/19

We made another PR targeting v3.10.0 since v3.4.0 is outdated. Please see https://github.com/privacysandbox/bidding-auction-servers/issues/19.


Request for an application health check

Hey mixu,
We've been running npm_lazy 1.7.0 for a few months, and it's working great. However once in a while the application needs to be restarted due to errors. Would a healthcheck endpoint be feasible to implement? Or is there an easy way, besides trying to hit it with http requests?
Thanks,
Cris

@crisbratu nice, glad to hear that! You could simply check whether some random package index is fetchable, e.g. curl -vvv localhost:8080/starwars. I'm also open to adding a health check endpoint, as long as it doesn't conflict with existing npm urls, e.g. https://github.com/npm/npm-registry-couchapp/blob/master/registry/rewrites.js

This would be a nice feature.
I imagine a good place to start would be a simple call and response.
 localhost:8080/health returning {"status":"ok"}
not necessarily making a call to npm but just to make sure the process is alive. In Kubernetes, if a container doesn't respond within a given timeout its restarted. we wouldn't want a health check making an external call every 15 seconds and the container could be unnecessarily restarted if npm take longer than a second or so to respond.
@mixu thoughts?


Crash when "zapi post -f" is used and the Space already exists

A community user stumbled into this while working with zapi to prepare for some remote zqd use cases. I've since reproduced the symptom using current zqd and zapi at commit f5d679d.
Start a listening zqd in an empty directory:
$ zqd -version
Version: v0.22.0-27-gf5d679d

$ zqd listen
{"level":"info","ts":1602180429.026339,"msg":"Starting","datadir":".","open_files_limit":24576,"pprof_routes":false,"suricata_supported":false,"zeek_supported":false}
{"level":"info","ts":1602180429.026829,"logger":"httpd","msg":"Listening","addr":"[::]:9867"}
...

Post a log while forcing Space creation (using the zq-sample-data Zeek weird log in this case).
$ zapi -s My_Test post -f weird.log.gz
100.0% 316.2KB/316.2KB
posted 316.2KB in 129.815797ms

If I repeat the exact same command line, there's a crash:
$ zapi -s My_Test post -f weird.log.gz
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x1741c6a]

goroutine 1 [running]:
github.com/brimsec/zq/cmd/zapi/cmd/post.(*LogCommand).Run(0xc000332080, 0xc000032290, 0x1, 0x1, 0xc000032290, 0x1)
	/Users/phil/work/zq/cmd/zapi/cmd/post/post.go:60 +0x89a
github.com/mccanne/charm.(*instance).run(0xc00000eec0, 0xc000032280, 0x2, 0x2, 0x0, 0x0)
	/Users/phil/.go/pkg/mod/github.com/mccanne/charm@v0.0.3-0.20191224190439-b05e1b7b1be3/instance.go:53 +0x28c
github.com/mccanne/charm.(*Spec).Exec(0x210ac60, 0x1b46be0, 0xc000326400, 0xc000032280, 0x2, 0x2, 0x3, 0x0)
	/Users/phil/.go/pkg/mod/github.com/mccanne/charm@v0.0.3-0.20191224190439-b05e1b7b1be3/charm.go:67 +0x92
github.com/mccanne/charm.(*instance).run(0xc00000eea0, 0xc000032250, 0x5, 0x5, 0x0, 0x0)
	/Users/phil/.go/pkg/mod/github.com/mccanne/charm@v0.0.3-0.20191224190439-b05e1b7b1be3/instance.go:61 +0x41d
github.com/mccanne/charm.(*Spec).ExecRoot(0x210a620, 0xc000032250, 0x5, 0x5, 0xc000317f78, 0x100763f, 0xc00010a058, 0x0)
	/Users/phil/.go/pkg/mod/github.com/mccanne/charm@v0.0.3-0.20191224190439-b05e1b7b1be3/charm.go:77 +0x96
main.main()
	/Users/phil/work/zq/cmd/zapi/main.go:21 +0x78

Without the -f, it works fine, replacing the contents of the Space. I know this is all due to change since we're going to need to support adding data to an existing Space. But since it's a crash, reporting it anyway.

Will be fixed when https://github.com/brimsec/zq/pull/1336 merges

Thanks @mattnibs. I'll put this one in your name for now, then, and will verify when it gets closed.

Verified in zq commit 9bcc81b.
The repeated log post with -f no longer triggers a crash.
$ zqd -version
Version: v0.23.0-15-g9bcc81b

$ zqd listen
{"level":"info","ts":1605285214.196723,"msg":"Starting","datadir":".","open_files_limit":24576,"pprof_routes":false,"suricata_supported":false,"zeek_supported":false}
{"level":"info","ts":1605285214.1974888,"logger":"httpd","msg":"Listening","addr":"[::]:9867"}
...

$ zapi -s My_Test post -f weird.log.gz
posted 316.2KB in 103.514812ms

$ zapi -s My_Test post -f weird.log.gz
posted 316.2KB in 113.207703ms

Thanks @mattnibs!


win64 builds with tracing enabled are broken

Original issue: https://charm.cs.illinois.edu/redmine/issues/1282

The autobuild tests are run with --with-production so tracing is not built.
PICS doesn't compile on MSVC. There seems to be multiple issues:
picsautoperfAPI.C(24): error C2131: expression did not evaluate to a constant
picsautoperfAPI.C(24): note: failure was caused by non-constant arguments or reference to a non-constant symbol
picsautoperfAPI.C(24): note: see usage of 'num'

picsdecisiontree.C(78): error C3861: 'getline': identifier not found

Not sure if critical for the 6.8.0-beta or not...

Original date: 2016-11-06 22:00:15

Not release critical - we're treating Windows as a deployment platform for NAMD, not a development platform. In that respect, --with-production is pretty much all that matters at the moment.
That said, this should get fixed, so that it doesn't get in the way of debugging other issues that may crop up there.

Original date: 2016-12-13 03:29:49

The picsautoperfAPI.C issue was fixed here: ~~https://charm.cs.illinois.edu/gerrit/#/c/2021/~~ https://github.com/UIUC-PPL/charm/commit/c42386617734e28f146a1250ceb23e2f42ed7aa8

Original date: 2016-12-21 19:48:17

The other part got addressed here:
~~https://charm.cs.illinois.edu/gerrit/#/c/2049/~~ https://github.com/UIUC-PPL/charm/commit/9f5fc2715663979106bad225ec7f250ac8faeee8
Testing now (slowly), and will close if this builds cleanly now.

Original date: 2016-12-21 20:09:28

Taken together, the above commits fix the build there.


chore(mysql2): remove unused test.js file

Short description of the changes

mysql2: Removed test.js unused file

If there is usage for this file, please close this PR without merging.

I think this file was there as a local test so the instrumentation author could step through an uninstrumented execution with the debugger while developing the instr


feat: Adding healthcheck module with api and server status

Adding default healt check module
By executing the command:
checkhealth codeium
Right after starting Neovim, you will get something like:

After a couple of seconds, when the server is started:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Cool!

Could you undo the formatting changes?

@gmatheu any update on this?

Could you undo the formatting changes?

Sure, my bad...  I'll push changes later

@gmatheu any update on this?

As it is, is useful for the purpose.
Ther is a couple of improvements that can be applied later (such as showing the log file location, currently is encapsulated in the log module)

Could you undo the formatting changes?

Done. For some reason I had to add a stylua.toml file for proper format to applied


Issue debugging Symfony Command

I am not quite sure where to turn for this, but I am trying you as you have created this plugin.
PHP version:
XDebug version:
HP 7.2.7 (cli) (built: Jun 23 2018 11:20:05) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
with Xdebug v2.6.1, Copyright (c) 2002-2018, by Derick Rethans
with Zend OPcache v7.2.7, Copyright (c) 1999-2018, by Zend Technologies
Adapter version:
Latest
Your launch.json:
        {
            "name": "Listen for XDebug",
            "type": "php",
            "request": "launch",
            "port": 9000
        },

I have also tried (If I leave out the second parameter in args, the command responds correctly in that it tells me the name (second parameter) is missing
       {
            "name": "Launch laravel-craftsman",
            "type": "php",
            "request": "launch",
            "program": "/Users/mikee/Documents/code/oss/laravel/laravel-craftsman/laravel-craftsman",
            "args": ["craft:class", "TestClass"],
            "runtimeArgs": [],
            "cwd": "${workspaceFolder}",
            "port": 9000
        }

XDebug php.ini config:
XDebug logfile (from setting xdebug.remote_log in php.ini):
Adapter logfile (from setting "log": true in launch.json):
laravel-craftsman craft:class TestClassName

Hi,
I'm not familiar with laravel-craftsman, but must you specify program and args in the settings? I have managed to debug all sorts of PHP code/frameworks without the need to specify them.
Further, it looks as though your vscode-php-debugger already works (i.e. able to receive debug info from your PHP server) and is actually reporting a PHP/Symfony/craftsman code logic issue.
If I'm correct, it makes more sense to

Look into the stack trace to figure out which line of code was the culprit.

Direct the question to laravel-craftsman

I will reply w/ more Info tomorrow when I can get back to computer.  In short, Laravel craftsman is a CLI tool written in php.  The normal call in terminal is
laravel-craftsman craft:class TestService —overwrite

I always manually start my PHP code from browser or CLI, e.g. php artisan db:seed
I'm not sure what program and args are for, but it just seems very cumbersome to have to change settings for every script that you are trying to debug.
When my server's xdebug.so is enabled in php.ini, any PHP script that is executed from CLI or browser will cause, xdebug to kick in where it tries to talk my vscode-php-debugger. Maybe you can try "args": ["craft:class TestClass"]?

so, if you create your own artisan command, how would you setup launch.json?  It is basically the same thing.  I have tried the method of setting breakpoint in my command, leaving the program and args keys empty and the issue remains
I guess I am going to have to use PHPStorm to do debugging, all works as expected there.

This is all there is in my settings
"configurations": [
	{
		"name": "XDebug on port 9000",
		"type": "php",
		"request": "launch",
		"port": 9000,
		"xdebugSettings": {
			"max_children": 512,
			"max_data": 512,
			"max_depth": 5
		},
		"pathMappings": {
			"<remote_path>": "<local_path>"
		}
	}
]

Your screenshot already shows the xdebug and vscode-php-debug communicating and halting the script, halt point is denoted by the yellow arrow. The exception was not due to vscode-php-debug.
What happens when you remove program and args?

I have another command craft:developer which takes no arguments / options on the CLI and if I execute that command, the debugger kicks in as expected.
So, this issue likely revolves around how the args are processed?

I am going to try your config now...

OK, your config has the same issue as mine :-(
I have a slimmed down version as well (which is basically what you have done)
        {
            "name": "Listen for XDebug",
            "type": "php",
            "request": "launch",
            "log": true,
            "port": 9000
        },

With my config,

Are you starting your command manually?
What is the issue you are seeing? Runtime exception: Too many arguments

yes
yes

Additionally, I created a simple artisan command to see if it was specifically related to laravel-craftsman and it has the same problem.  If the command requires arguments / options, it fails
Artisan command signature:
protected $signature = 'get:name {name}';

Just for your etification, when debugging with PHPStorm, I setup testing a PHP Script as follows, when I start the debugging process, it properly stops at my desired breakpoint

If you are seeing line 183 exception when manually starting the command, what happens when you turn off all debuggers and just start the command? Does it end with no exception?

In case you need this, here is the information in the debugger pane for VSCode

Yes, without debugger all works as expected.  The command simply echo's whatever the user entered

Can check through all 3 and make sure they don't have program and args?

Where is this section located?

Settings, press ctrl + ,

OK, that is what I thought you were referring to... all clean

Are you familiar with creating Laravel commands?  not sure if you work with Laravel, thus I didnt want to assume anything :-)

Yes, I write my own custom Laravel commands.
Place a breakpoint on line 75 of vendor/symfony/console/Input/ArgvInput.php
The line should be $this->parsed = $this->tokens;
Use the watch under vscode-php-debug to check if $this->tokens matches what you executed
If it matches, I have no idea what the issue is anymore.

if you create a simple command (use attached) are you able to debug? I have removed docBlocks to simplify class.

<?php

namespace App\Console\Commands;

use Illuminate\Console\Command;

class TestOptional extends Command
{
    protected $signature = 'get:name {name} {--l|lname=erickson : User Last Name}';

    protected $description = 'Test Command';

    public function __construct()
    {
        parent::__construct();
    }

    public function handle()
    {
        $command = $this->argument('name');

        $fname = $this->option('fname');

        echo "fname: {$fname}";
    }
}

Yes, it is what I expect

If you use the sample command above, set a breakpoint at the first line of the handle method.  In my case, it never gets there, I receive the runtime exception

That is when I call as
php artisan get:name

If I call as
php artisan get:name mike

Then I receive

Yes, I'm able to reach $command = $this->argument('name'); but $this->option('fname'); throws a does not exists error/exception

What does the $missingArguments on line 75 evaluate to?

Long story short, while I can understand your logic that if PHPstorm works, so should vscode-php-debug, this really does not look like anything to do with vscode-php-debug's setup etc.
I will suggest tracing through from line 75 of vendor/symfony/console/Input/ArgvInput.php til line 76 where your exception is thrown. (Strangely, why isn't it line 183 anymore?)

I would also evaluate line 182's $all to have a clue.

I have to go now, do update your findings, I will help again when I can.

I am heading to family Easter plans so won’t be able to get back to this until later this evening. I am going to create a brand new empty app and try and debug. I am surprised it works for you, the command I sent is bare but doesn’t work for me

@bilogic OK, I am back at my computer. I am going to create a brand new Laravel app command (using the example from above) and see how it goes.  I am curious what is different between our configurations (why does your work, mine not).
I doubt it is an OS related issue since my debugger kicks in, just at the error.

@bilogic OK, I have created a clean Laravel app, created a new command (which works without debugger) and I have used your configuration in the launch.json file.
Still produces the error from above.
So, I am really puzzled why it works on your end?
I am going to debug the Symfony code now to see where it is getting hung up.

@bilogic Well, after all this time, I think it DOES work, I just needed to continue after the initial error occurs.  Going back to the original project, I started the debug session, issued the command in the terminal, the debugger stops on the symfony error (not sure why)
So, I then clicked the | > button to continue with the debug session and then it hits my breakpoint and I am able to debug as normal.
In conclusion (and for those who may stumble upon this thread) you will likely hit the symfony error below (around line 183), but just hit the | > button to continue debugging and it should next hit your breakpoint.

Ok, I think the issue might be in your xdebug.ini, here's mine.
[xdebug]
xdebug.remote_enable=1
xdebug.remote_host=<IP_ADDRESS>
xdebug.remote_port=9000
xdebug.remote_handler=dbgp
xdebug.remote_mode=req
xdebug.remote_autostart=0
xdebug.remote_connect_back=0
xdebug.remote_log=/var/log/xdebug.log

Inside php.ini/xdebug.ini, check the value of show_exception_trace, it should be 0.
https://xdebug.org/docs/all_settings

I dont have this in my php.ini file (I really should move this to its own xdebug.ini not quite sure why I don't have it this way, I do it in Docker all the time (that is a totally unrelated conversation, just thinking out loud).
So where do you have this configured?

OK, I found it... You are indeed correct, it was not in my php.ini file for xdebug configuration


Matches returned not always the most optimal combination

I have found some cases where there is a better way the matches could have been combined to give a lower score.
It would happen when building the match list and there is a match added first which is thought to have the lowest average entropy, but adding that instead of another with a slightly higher average but shorter length would stop the next one in line which was significantly lower entropy from being added.

I fixed this in dbe4ecb6a5d04e240538577ea320409756829de5
It was fixed by implementing a recursive match list building algorithm which ensures we test all possible combinations.  This is slower, but provides better results.


windows-terminal 1.7.1033.0 flashback

Windows Terminal version (or Windows build number)
1.7.1033.0
Other Software
No response
Steps to reproduce
Use scoop update windows-terminal to 1.7.1033.0, Open application flashback. The previous version 1.6.10571.0 of the program worked properly
Expected Behavior

Actual Behavior
Please fix

/dup #9821
Scoop installs terminal in an unsupported way. We're working on fixing it, but we have never supported the wya that they installed us.


XInitThreads from patch to wex

See also https://github.com/wxWidgets/wxWidgets/issues/17187

It turned out that it's my code calling XInitThreads too late that causes the segfault. I've tried to put the invocation in module (inheriting from wxModule). Neither calling the function from the ctor of the module nor in module's OnInit would work. Needless to say, the case in the attached .cpp file won't work too, because wxApp::OnInit is called even after modules' OnInit. So, as the last resort, I tried calling XInitThreads in a function that is to return a dummy value to a global object. That kind of functions are supposed to run before main. Now, it works.


Not being to install on OSX

> node-gyp rebuild

  CC(target) Release/obj.target/libopus/deps/opus/src/opus.o
  CC(target) Release/obj.target/libopus/deps/opus/src/opus_decoder.o
In file included from ../deps/opus/src/opus_decoder.c:50:
In file included from ../deps/opus/silk/structs.h:32:
In file included from ../deps/opus/silk/SigProc_FIX.h:43:
../deps/opus/silk/macros.h:52:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
#if OPUS_FAST_INT64
    ^
../deps/opus/silk/macros.h:47:26: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                         ^
../deps/opus/silk/macros.h:52:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:49: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                ^
../deps/opus/silk/macros.h:52:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:70: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                                     ^
../deps/opus/silk/macros.h:59:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
#if OPUS_FAST_INT64
    ^
../deps/opus/silk/macros.h:47:26: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                         ^
../deps/opus/silk/macros.h:59:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:49: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                ^
../deps/opus/silk/macros.h:59:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:70: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                                     ^
../deps/opus/silk/macros.h:69:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
#if OPUS_FAST_INT64
    ^
../deps/opus/silk/macros.h:47:26: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                         ^
../deps/opus/silk/macros.h:69:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:49: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                ^
../deps/opus/silk/macros.h:69:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:70: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                                     ^
../deps/opus/silk/macros.h:91:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
#if OPUS_FAST_INT64
    ^
../deps/opus/silk/macros.h:47:26: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                         ^
../deps/opus/silk/macros.h:91:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:49: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                ^
../deps/opus/silk/macros.h:91:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:70: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                                     ^
../deps/opus/silk/macros.h:98:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
#if OPUS_FAST_INT64
    ^
../deps/opus/silk/macros.h:47:26: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                         ^
../deps/opus/silk/macros.h:98:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:49: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                ^
../deps/opus/silk/macros.h:98:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:70: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                                     ^
15 warnings generated.
  CC(target) Release/obj.target/libopus/deps/opus/src/opus_encoder.o
In file included from ../deps/opus/src/opus_encoder.c:51:
In file included from ../deps/opus/silk/float/structs_FLP.h:32:
In file included from ../deps/opus/silk/main.h:31:
In file included from ../deps/opus/silk/SigProc_FIX.h:43:
../deps/opus/silk/macros.h:52:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
#if OPUS_FAST_INT64
    ^
../deps/opus/silk/macros.h:47:26: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                         ^
../deps/opus/silk/macros.h:52:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:49: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                ^
../deps/opus/silk/macros.h:52:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:70: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                                     ^
../deps/opus/silk/macros.h:59:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
#if OPUS_FAST_INT64
    ^
../deps/opus/silk/macros.h:47:26: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                         ^
../deps/opus/silk/macros.h:59:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:49: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                ^
../deps/opus/silk/macros.h:59:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:70: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                                     ^
../deps/opus/silk/macros.h:69:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
#if OPUS_FAST_INT64
    ^
../deps/opus/silk/macros.h:47:26: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                         ^
../deps/opus/silk/macros.h:69:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:49: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                ^
../deps/opus/silk/macros.h:69:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:70: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                                     ^
../deps/opus/silk/macros.h:91:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
#if OPUS_FAST_INT64
    ^
../deps/opus/silk/macros.h:47:26: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                         ^
../deps/opus/silk/macros.h:91:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:49: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                ^
../deps/opus/silk/macros.h:91:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:70: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                                     ^
../deps/opus/silk/macros.h:98:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
#if OPUS_FAST_INT64
    ^
../deps/opus/silk/macros.h:47:26: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                         ^
../deps/opus/silk/macros.h:98:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:49: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                ^
../deps/opus/silk/macros.h:98:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
../deps/opus/silk/macros.h:47:70: note: expanded from macro 'OPUS_FAST_INT64'
#define OPUS_FAST_INT64 (defined(__x86_64__) || defined(__LP64__) || defined(_WIN64))
                                                                     ^
15 warnings generated.
  CC(target) Release/obj.target/libopus/deps/opus/src/opus_multistream.o
  CC(target) Release/obj.target/libopus/deps/opus/src/opus_multistream_encoder.o
  CC(target) Release/obj.target/libopus/deps/opus/src/opus_multistream_decoder.o
^Cmake: *** [Release/obj.target/libopus/deps/opus/src/opus_multistream_decoder.o] Interrupt: 2```

Having the same issue on Catalina 10.15.1

Am on mojave

I'm archiving the repository for lack of interest in maintaining it. Sorry I never got to deal with this issue. Please see @discordjs/opus for an alternative implementation that is based this project but uses more stable Node.js module technology that should break less between Node.js versions.


Segmentation Fault: neuralcoref==0.4.0 & spacy==2.1.4

Hello, first of all, I wanted to mention that this is an awesome library. I am building a library around both this repository and your BERT implementations for extractive text summarization.
I recently noticed that I am getting a segmentation fault with spacy==2.1.4 and neuralcoref==0.4.0. I have tried this on ubuntu 18.04 and macOS. Spacy==2.1.3 seems to be working fine. The code below reproduces the issue.
import neuralcoref
from spacy.lang.en import English

nlp = English()
nlp.add_pipe(self.nlp.create_pipe('sentencizer'))
neuralcoref.add_to_pipe(nlp, greedyness=0.4)

I was going to take a look at this issue myself, but I wanted to make sure that you hadn't ran across something like this beforehand.

Is this issue reproduced in spacy 2.13?

As an update, spacy 2.1.3 does not have an issue and works fine. I have only seen the issue in spacy==2.1.4

its not even working with spacy==2.1.3. Segmentation fault :(

I think this is a duplicate of: https://github.com/huggingface/neuralcoref/issues/167
Neuralcoref (4.0 - from pip) works with 2.1.3 here.

Yeah, I created a new venv and then installed it with spacy==2.1.3. working fine!

I also was able to get it working using spacy==2.1.3

Yeah, this is a recurring problem.
I would like to be able to understand how we could keep the library in sync with SpaCy more easily.
I'll see if Matthew and Inès have some insights.

Recompilation from source after installing spacy was able to solve this problem for me, even on 2.1.6.

Merging with Issue #197


fix(ci): correct RTD builds

This hopefully fixes the RTD builds

The failing builds are related to numpy2, and apparently simple_jpeg.
Will merge as-is, since the cannot be related to this pr.

Thanks!
We always squash-merge pr's :)


[Feature] Toggable Hidden Recharge Rolls

A way to toggle the recharge roll so it is always hidden from players.

Greatly appreciate it. Now my players will stop cheering whenever my BBEGs fail a charge roll.


Update JWTVerify.mjs

Enable verification of RSASHA256 and 512 tokens

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Stop double scrubbing json payloads

What does this PR do?

Stop double scrubbing the input in the ScrubJSON Scrubber method.
Motivation

It uses CPU and memory, and shouldn't bring anything.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge

/merge -c

/merge

Merge queue failed due to codecov timeout, retrying

/merge


Return array of vulnerability scores

The whole array of vulnerability scores is returned.
Use numPy.

Will be tackeled in one of previous issues.