serializers customization

Please add an example of changing json:api url serializers. In particular, I want to change the model name in the url where the letter 's' is appended to the end. 🙏

You can provide custom serialization behavior by overriding the default serializer class or specifying additional serializer settings. You can read more about it in the docs.
In your case, you can add the serializerSettingsFor option to the remote source, which will let you pluralize/singularize model names. Here is an example from the docs:
const source = new JSONAPISource({
  schema,
  serializerSettingsFor: buildSerializerSettingsFor({
    sharedSettings: {
      // Optional: Custom `pluralize` / `singularize` inflectors that know about
      // your app's unique data.
      inflectors: {
        pluralize: buildInflector(
          { person: 'people' }, // custom mappings
          (input) => `${input}s` // naive pluralizer, specified as a fallback
        ),
        singularize: buildInflector(
          { people: 'person' }, // custom mappings
          (arg) => arg.substring(0, arg.length - 1) // naive singularizer, specified as a fallback
        )
      }
    },
...

Hope it helps


Delay dirty form check’s snapshot to avoid race conditions. Fix #4978

Fixes #4978. This adds a 10-sec delay to the initialisation of the "dirty form check" displaying a "Are you sure you want to leave this page?" message in the page editing UI.
This was broken because of a race condition – the dirty form check runs "when the page is done loading" rather than after the fields’ initialisation. The delay reduces the risk of race condition issues, and it also seems like a sensible behavior from an end user’s perspective not to aggressively prompt people who have only spent a few seconds on the page, even if they did change some content.
This race condition wasn’t a problem for most fields, but anything that stores JSON data structures (like the new rich text editor) is prone to differences in serialisation between server and client code – in that case whitespace, and perhaps keys ordering.
This change doesn’t alter the behavior of the dirty form check when it is initialised in "always prompt for confirmation" mode.

[x] Do the tests still pass? (http://docs.wagtail.io/en/latest/contributing/developing.html#testing)
[x] Does the code comply with the style guide? (Run make lint from the Wagtail root)
~For Python changes: Have you added tests to cover the new/fixed behaviour?~
[ ] For front-end changes: Did you test on all of Wagtail’s supported browsers?
~For new features: Has the documentation been updated accordingly?~

Tested in latest Chrome, Firefox, Safari on macOS by:

Opening an edit page then moving elsewhere right away – no confirmation
Opening an edit page then moving elsewhere after the 10s delay – no confirmation
Opening an edit page, editing content in less than 10s, moving elsewhere  – no confirmation
Opening an edit page, editing content over more than 10s, moving elsewhere - confirmation

@tomdyson @briaguya could either of you review this? I’d be keen to further increase the delay from 10s to 30-60ish, but that would only be to improve the UX (further reduce the frequency of useless prompts) rather than fix the current bug.

It's great to have a fix for this!
I've updated the Squash instance at https://thibaudcolasbug4978-dirty-form-fa58b.squash.io/admin/pages/3/edit/ (admin/changeme) to include a rich text field, and tested it on Firefox and Safari on OS X, where the fix is working as expected.
Note that changes which are added in the first 10 seconds will not be identified by the "dirty form check", even if you wait more than 10 seconds before leaving the page. I think this is OK.

Merged in db9b582912808f0ef4ab16f3254c7ff57e769f3d (master) / 1108eb4c6e40b77f4a265514aff62dbe68da302a (stable/2.6.x) - will also merge into stable/2.5.x shortly to prepare a 2.5.2 release.

Thanks @thibaudcolas and @gasman! It's a relief to have this fixed.


[GHSA-m44j-cfrm-g8qc] Bouncy Castle crafted signature and public key can be used to trigger an infinite loop

Updates

Affected products
CVSS v3

Comments
Vulnerable code was introduced only in version 1.73 via https://github.com/bcgit/bc-java/commit/1b9fd9b545e691bfb3941a9f6a797660c8860f02, which was later fixed by https://github.com/bcgit/bc-java/commit/9c165791b68a204678b48ec11e4e579754c2ea49 and https://github.com/bcgit/bc-java/commit/ebe1c75579170072dc59b8dee2b55ce31663178f.
org.bouncycastle:bcprov-jdk15on does not have version 1.73 as per https://mvnrepository.com/artifact/org.bouncycastle/bcprov-jdk15on, so this vulnerability is not relevant to it at all.

Hi @amita-seal, thanks for the heads up about CVE-2024-30172 having been introduced in version 1.73, specifically in https://github.com/bcgit/bc-java/commit/1b9fd9b545e691bfb3941a9f6a797660c8860f02. In addition to removing org.bouncycastle:bcprov-jdk15on as an affected product, I've added 1.73 as the lowest vulnerable version in the remaining Maven products that do have a version 1.73 and changed the description to indicate the vulnerable code was added in version 1.73.


No explanation on how to change the default logging location??

This article mentions the default logging locations for both Windows and Linux, but nowhere does it explain where to change this.  What if I want to change the logging location to ~/home/mylogs/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7184a308-a254-9350-a5cd-5bced1f369ae
Version Independent ID: 726e3bf1-f367-d733-8933-bccc04da0e16
Content: Logging in .NET Core and ASP.NET Core
Content Source: aspnetcore/fundamentals/logging/index.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

See this SO
cc @serpent5

There's no default file logging in ASP.NET Core. You need to plug in a provider like serilog or nlog etc

I think the coverage here is OK as-is. Built-in logging providers doesn't show a "file" provider, because there isn't one, as David Fowler says. The only reference to a path seems to be under the Debug provider, which is a different provider entirely. The Log during host construction section shows using Serilog and its file sink, but not as the main focus.
Another option is to add something to the "Built-in logging providers" section, highlighting that a third-party provider, e.g. Serilog, has its own built-in log-to-file functionality.

"Built-in logging providers" section, highlighting that a third-party provider, e.g. Serilog, has its own built-in log-to-file functionality.

Yes. and also add There's no default file logging in ASP.NET Core


NPTv6: add dynamic source addresses via track interface

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
The problem hear is small site multihoming. It's very nicely described here: https://blog.ipspace.net/2010/12/small-site-multihoming-in-ipv6-mission.html and can pretty much only be done with local ULA addresses and some sort of address translation toward the WAN interfaces. Right now it can only be done via NA(P)T66, which is the very same as NA(P)T44, and I don't think we want that anymore.
Now the implementation problem with it is that with NAT you can do the following:
nat on WAN inet6 from SOME_IP_RANGE to any -> (WAN:0) port 1024:65535
while with NPT (binat) you have to specify a source and a destination network, so some sort of integration into interface newwanipv6 will be necessary.
Describe the solution you like
I would like a "Track Interface" External IPv6 Prefix Option in addition to static External IPv6 Prefix in NPTv6, pretty much just like it is in the interface configuration dialog.
Specified would be:

IPv6 Interface
IPv6 Prefix ID

Describe alternatives you considered
Oh so many ones, but none of them work. The best one in clean IPv6 terms so far is to use two independent routers each with their own GUA prefixes which the independently advertise into LAN, only that works only if RFC3484bis is implemented or asymmetric routing is achieved.
The one that works is to just do it like in IPv4, with local addresses for LAN, and NA(P)T on the outside interface, but that's hardly the right solution.
Additional context
There's even a very nice RFC for that, namely https://datatracker.ietf.org/doc/html/rfc7157 "IPv6 Multihoming without Network Address Translation" but even they concede that NPTv6 is probably needed for now.
For static prefixes this should work nicely with static NPTv6, but if the prefixes are dynamic, it falls down.

we use pf(4) (https://www.freebsd.org/cgi/man.cgi?pf(4)), sounds similar to https://github.com/opnsense/core/issues/4923, waiting for someone to properly document the feature (https://github.com/opnsense/docs/pull/330#issuecomment-839531339) before any code will be merged.

@bimbar - dhcp6c puts the GUA address on the interface, so you can get the prefix from the GUA address. The trick I think, if I understand NPTv6 correctly - Only looked at this 30 minutes ago - is to assign a ULA address to the interface ( alias is there for that already ) and to use dhcpdv6 and radvd to hand out ULA addresses on the LAN(s). Once you have that done, then would it possible to just NPTv6 the LAN ULA addresses to the GUA prefix for that interface?

The prefix for the WAN interface is different from the prefix we need. Also, this prefix is not going to be set on any interface. It's not that simple.

You misunderstood me I think. I am talking about the LAN(s) not the WAN. dhcp6c assigns the addresses to the interfaces, the GUAs that is.  I quote you
But I'm not sure if that's even possible, it depends on the dhcpcv6 daemon telling someone which prefixess it was assigned.
That information is already available, In /tmp there is also another file, my wan is igb0, therefore the file is called  igb0_pdinfo, that will give you the prefix size. If it's any use I also have a versiion of dhcp6c that will give you the prefix that is assigned to the LANs, but as I said, that info is aleady available.

Ok, so I have a hypothetical LAN interface with Track Interface WAN and offset 4. Now I want NPTv6 to translate the source prefix to the prefix this hypothetical interface would have been assigned (but it has been given a ULA prefix).

It will also have been given a GUA address, you cannot stop dhcp6c doing that - unles we have some sort of virtual interface, but that's a different story. You can add an Alias to give a ULA address, BUT, dhcp6d and Radvd will give out the GUA addresses. If that was altered so that they gave out the ULA addresses then packets coming back to the LAN interface would have ULA addresses and, in theory, would hit the NPTv6 rule.

Why can I not stop dhcp6c giving out GUAs? I can configure the interface with static IPv6 ULA.
Giving out GUAs makes the whole feature redundant.

Just messing around to prove a point..
So I am using Track Interface, my test router has  GUA prefixes on its LANs.. All OK
I added a VIP to the LAN of the test router using a ULA address. dhcpdv6 on that interface is disabled, I have also commented out the relevent parts of dhcpd.inc so that no GUA addresses are given out, but ULA ones are, this is what radvd.conf looks like:
interface igb1 {
AdvSendAdvert on;
MinRtrAdvInterval 200;
MaxRtrAdvInterval 600;
AdvLinkMTU 1500;
AdvDefaultPreference medium;
prefix fc01:1::/64 {
DeprecatePrefix off;
AdvOnLink on;
AdvAutonomous on;
};
RDNSS 2a02:6b67:605d:3200:4262:31ff:fe00:c1b0 {
};
DNSSL localdomain {
};
};
It's still using the RDNSS but that doesn't matter in this case.
Then I added an NPTv6 entry, using the GUA /64 prefix from the test router LAN. WAN interface selected.
So it works, perfectly possible to use the GUA Prefix on the LAN. And If instead of using an address as the external prefix it could use an alias, in the same way as the firewall rules we were working on earlier this year, then that would solve a few problems.

Let's take this a step further. I see the need for the following:

Ability to only enable ULA address handouts in dhcpdv6 and radvd.
Ability to select the LAN GUA prefix ( as an alias ) in NPTv6
Abillity to select the LAN ULA prefix in NPTv6

@fichtner & @AdSchellevis - Does this fit the bill?

Now I'm confused, as far as I can see in your example, you have no GUA prefix on LAN, but only an ULA prefix, yet you write in you conclusion that a GUA prefix on LAN works perfectly.
Anyway, what you tested is pretty much what I was thinking of, only you want to sort of virtually assign the GUA prefix to LAN while not advertising it, which would also be a way to implement it, I guess.

That LAN is my PC's LAN, not the LAN of the router. That looks like this. Note I've change the ULA address to fc00 since yesterday.
igb1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
options=802028<VLAN_MTU,JUMBO_MTU,WOL_MAGIC>
ether 40:62:31:00:c1:b0
inet6 fe80::4262:31ff:fe00:c1b0%igb1 prefixlen 64 scopeid 0x2
inet6 fc00:1::1 prefixlen 64
inet6 xxxx:xxxx:3200:4262:31ff:fe00:c1b0 prefixlen 64
inet <IP_ADDRESS> netmask 0xffffff00 broadcast <IP_ADDRESS>
media: Ethernet autoselect (1000baseT )
status: active
nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
It's the way I'd prefer to do it. It makes life much simpler IMHO.

@bimbar - dhcp6c puts the GUA address on the interface, so you can get the prefix from the GUA address. The trick I think, if I understand NPTv6 correctly - Only looked at this 30 minutes ago - is to assign a ULA address to the interface ( alias is there for that already ) and to use dhcpdv6 and radvd to hand out ULA addresses on the LAN(s). Once you have that done, then would it possible to just NPTv6 the LAN ULA addresses to the GUA prefix for that interface?

Going back to your initial statement, I get what you want to do there, but, if you have a GUA and an ULA on the LAN, but advertise only the ULA, and translate that over to the GUA, what use is it to configure said GUA on LAN if it's not used.
It's only used as a NAT pool and as such should not be configured on any real interface.

 What if you want multiple LANs etc? The fact is yes you can get the prefix and size from a file that dhcp6c already creates, but the ability to NPTv6 to the GUA on the same LAN makes it simpler in other ways too. There are many ways to skin a cat.

You don't understand, instead of configuring some interface as "Track Interface WAN offset 1", you would configure the NPTv6 Destination Prefix as "Track Interface WAN offset 1".

I DO understand I just see benefits of using the real interface. I am well aware that if you know the prefix that's been obtained you could just use that.Sent from my Galaxy

-------- Original message --------From: Markus Peter<EMAIL_ADDRESS>Date: 12/11/2021  09:31  (GMT+00:00) To: opnsense/core<EMAIL_ADDRESS>Cc: Martin Wasley<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [opnsense/core] NPTv6: add dynamic source addresses via track interface (#5284)
>
>
> What about ISPs that don't give a GUA on the WAN? What if you want multiple LANs etc? The fact is yes you can get the prefix and size from a file that dhcp6c already creates, but the ability to NPTv6 to the GUA on the same LAN makes it simpler in other ways too. There are many ways to skin a cat.
You don't understand, instead of configuring some interface as "Track Interface WAN offset 1", you would configure the NPTv6 Destination Prefix as "Track Interface WAN offset 1".
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/opnsense/core/issues/5284#issuecomment-966954526

Let's take this a step further. I see the need for the following:

Ability to only enable ULA address handouts in dhcpdv6 and radvd.
Ability to select the LAN GUA prefix ( as an alias ) in NPTv6
Abillity to select the LAN ULA prefix in NPTv6

@fichtner & @AdSchellevis - Does this fit the bill?

This really sounds nice and what I am looking forward to have.
Any chance to see it in next few releases? Finger crossed.
Thanks
Ivan.

(from https://github.com/opnsense/core/issues/5284#issuecomment-947566519) we use pf(4) (https://www.freebsd.org/cgi/man.cgi?pf(4)), sounds similar to https://github.com/opnsense/core/issues/4923, waiting for someone to properly document the feature (https://github.com/opnsense/docs/pull/330#issuecomment-839531339) before any code will be merged.

As long as any change in this area fits the boundaries given earlier, I don't mind that much, I just would advise to keep it simple.
We all seem to get lost in this region quickly, which is only solvable if anything we do add will be explained unambiguously.
Speaking for myself (and likely @fichtner as well), I'm not planning to spend time on this before it's absolutely clear, already spend quite some time preparing everything in https://github.com/opnsense/core/tree/FR_4923, after which everything kept circling back.

I'd propose merging some implementation of something soon, rather than wait for something perfect which may never come.
All with the understanding it may change completely as soon as its shortcomings are understood.
But if nothing is merged, there is no base which can be argued in a wider audience.

Not if the fundamentals are unclear, it's rather simple, someone should write it down (design) before starting to build anything, to prevent future issues impossible to fix further down the road.  We spend years refactoring a lot of madness and believe me, trouble starts with vague objectives.

Well, there's enough ideas, someone ultimately has to decide what to actually do.

Is it possible to first develop Martin's implementation into a plugin, as a means to discover what is lacking (if any)?
For my use-case, it's primarily to deploy opnsense and IPv6 reliably with upstream ISPs changing IPv6 PD assignment frequently, in that Insulating LAN side address ranges from those ISPs by NPT and ULA.
So Martin's implementation that

enables dhcp6d/radvd to advertise ULA
allows user to specify NPT by mapping between ULA prefix and IPv6 PD (tracking WAN)
refreshes NPT translation rules automatically when tracked IPv6 PDs are changed.
fits the bill.
If anything not explicitly stated, is that assigning ULA directly to LAN side physical interfaces without the need to create a virtual one.

Thanks
Ivan.

Is it possible to first develop Martin's implementation into a plugin, as a mean to discover what is lacking (if any) down the road?

I assume you mean the work me and Martin did which is waiting in https://github.com/opnsense/core/tree/FR_4923, but no, you can't easily move that to a plugin as you don't have anything to plug it into. (yes, you can develop a plugin offering this functionality, but I don't expect anyone would like to spend the amount of time needed to convert this to a stand-alone feature).
As soon as the concerns in the doc's PR are cleared (https://github.com/opnsense/docs/pull/330), we can start moving code in, as I've mentioned earlier as well.

@AdSchellevis - No, he means the ability to select an address range to use within dhcpdv6. At present you can only create one range within dhcpdv6 / radvd, thus is you use tracking you can overide and make your own range but if you have a ULA alias on that inferface you cannot use that, as the existing code picks the GUA. What it would need is the ability to force the range entered so that the sanity check is overridden. I do not see the need to be able to have both ULA and GUA ranges handed out by dhcpdv6, but where both exist on an interface, then the ability to select or specify the range would be useful.

@marjohn56 ok, clear, sounds like a no as well when it comes to building a plugin.

Yes agreed, but I'm working on a simpler solution... Really, it's just a case of being able to override the auto prefix addition that happens when using override on the tracked interface. So that's the path I am taking, I'm playing with it later this afternoon as it happens.

OK, this is starting to look possible. I'm going to show some snapshots  of how I have it looking. It all works but I'll try and explain it too, I think @fichtner would probably want to tidy it up, but the principle seems to work fine. Firstly, this is purely for tracking interfaces, there is no point in this for any other type. So let me explain what needs to happen first. You need to assign a VIP to the LAN interface involved, so it's a tracking interface with a VIP added, that VIP should be a ULA address.
That being done, when you open the dhcpdv6 settings for that interface you would see this:

You'll see there is now some extra info and an extra checkbox. The checkbox tells the system to use the VIP settings rather than the track settings. If there was no VIP on the interface, those extra items would not be visible. There are no other interface changes. The code behind handles the writing of the dhcpdv6.conf and radvd.conf

I think you're talking about exactly that feature that many people in Germany need, because many providers change IPv4 addresses and IPv6 prefixes once a day. So my problem seems to be discussed here, but I also found some (annoyance) on my provider router:
WAN 1: GUA/56 static
WAN2: GUA/62 dynamic (yes, only 62!)
LAN: ULA/64
The static NPT rules for LAN <-> WAN1 is already working perfectly, but the problem is the dynamic one for WAN2. I currently have to create a static NPT rule and change the GUA prefix once a day. Another problem here is that I get the first GUA/64 prefix ("GUA/64 prefix #1") as IPv6 address/prefix on the WAN2 interface, but have to provide an unused one for the NPT rule, so let's say I have to choose "GUA/64 prefix #2". If you implement a dynamic NPT rule the OPNsense needs to pick prefix #2 itself.
Now my provider router comes into play. Have in mind that I get a GUA/62, so can use 4x /64 in total:
"GUA/64 prefix #1": Will be used by WAN2
"GUA/64 prefix #2": Is already in use by the provider router internally! Can't be used by OPNsense
"GUA/64 prefix #3": Needs to be used for the dynamic NPT rule
"GUA/64 prefix #4": free
So I have to use "GUA/64 prefix #3" on the OPNsense NPT gui. Please keep that in mind, because there needs to be a way to pick the 2nd, 3rd, 4th... prefix from the GUA prefix.
(...or is it that the 'offset' you already talked about?)
+1 for this feature, thanks! :)

@fichtner  - I'll PR this then we can play with it.

@marjohn56 I thought this was done... that's why I tagged it?

(...or is it that the 'offset' you already talked about?)

It isn't and it means I'll need to add a drop down selector for the ULA's. I have to say though that because we have completed the tracking dynamic fw rule , this may no longer be needed, but we'll play on. @fichtner - no, not issued a PR yet as I was waiting for feedback on the image I shared above - Is it the way to go?

@marjohn56 ok I'm moving it to community milestone. Did not want to force a solution for 22.1 as I know you are typically busy. Take your time.

No, we don't need a dropdown, it pulls the ULA from what is assigned to the interface, so it's good.  I'll PR it for play and discussion.

@fichtner - #5408

Any update on this?

@TheRealBecks Can you be more specific on "any" that's not clear from this issue history?

@fichtner I don't know. I just need support for dynamic IPv6 GUA addresses that can be used with NPT, because my provider changes the /62 prefix every 24 h. And from that /64 I have to use the third of fourth /64 prefix for NPT as I wrote here. That's a must-have-killer-feature for all German users and FritzBox users that have more than one internet connection (e.g. dual-home-setup).

Just wanted to add some support to this feature.. As others have correctly summarized, the status of IPv6 is a bit hit-and-miss, and being able to use NAT66/NPTv6 would push IPv6 adoption on the desktop, while allowing the intelligent firewall to buffer for carrier changes, route changes, address assignment changes etc.
My primary gives IPv6 via DHCPv6, but it randomly stops working for weeks at a time.
My secondary gives IPv6 via 6RD, which is incompatible with track, so can't be used (at this time) for NPTv6.
HE tunnels work like a charm, have static assignments, can be mapped with NPTv6, and just work.. .would be nice to be able to use the V6 provided by either my primary or my secondary.
+1 - to @ivwang 's suggestion above.. we need both #2 and #3. Right now I have to go hand update the NPT rules every time "primary" changes their IP range. (would for secondary if that worked)

allows user to specify NPT by mapping between ULA prefix and IPv6 PD (tracking WAN)
refreshes NPT translation rules automatically when tracked IPv6 PDs are changed.

Checking in after a while, it looks like pfSense implements a similar recently https://redmine.pfsense.org/issues/4881
Although its implementation allows mapping multiple internal ipv6 subnet to a single global prefix, which I personally do not prefer, as non-standard ipv6 subnetting may complicate things.

Yes definitely waiting for this as well. Consumer ISPs here in Germany have the habit of dealing out dynamic prefixes which is a mess to manage internally.

Please also check out issue #6015 , if that were also possible, IPv6 for dynamic prefixes on opnsense would be pretty much feature complete.

The objective is to be able to hand out static prefixes on the inside and nat to dynamically learned prefix on the wan.
Without forcing the dynamic prefix on the WAN interface to the LAN interfaces.

So for dynamic prefixes is there even any sense to use something other than /64 for the translation? I know the prefix may be bigger but the thing is we'd start natting outside of the scope of the wan interface and it might be possible to coerce pf(4) to accept the automatic :network address

Ok so perhaps someone wants to try:
# opnsense-patch 32c783ca b7a9d0b4 f7e64baa5 17ec3264a

Leave external address empty...

This is indeed a great addition.
So I take it out for a spin, however, I am not quite sure I configure it right. The NPTv6 prefix "sort-of" works in my setup.
Here is the thing, my ISP assigns an IPv6 /64 GUA to opnsense's wan and delegates a dynamic /64 prefix, this is typical and the prefix my lan interface uses by "tracking interface wan"
After patching, I changed my lan to static IPv6 ULA then under Firewall > NAT > NPTv6 added a rule on wan interface with lan's /64 ULA prefix as internal prefix and left external prefix empty.
Then checking test-ipv6.com from one of the lan hosts indeed gets through since the lower 64-bit of ipv6 address shown by test-ipv6.com matches that of lan host's ULA, however, the prefix is the prefix from the /64 GUA on wan instead of the supposedly delegated /64 prefix.
it looks like I missed something, any thoughts?
Thanks a lot

@ivwang thanks for testing! this is correct if you use /64, but you can actually match the delegated prefix size on the WAN side, which would make the prefix ID "visible" if you use NPT on the full prefix size.

(the ULA might have to match the prefix ID part of the address in order for this to work, I'm not entirely sure)

@fichtner Oh. thanks for the reminder. I think this patch works and I am happy now :)
BTW, for people using fc00::/7 ULA prefixes don't forget to allow bogus networks on the internal interface or the auto-generated rule will block those.
Thanks again.

Nice, thank you. Let’s ship this on 22.7.8 then :)

Are we clear that this does not have to be ULA.  We could have any valid prefixes on the LAN from which to nat.

use ula on the lan and nat to wan prefix
use PA/PI prefixes from another connection and nat to prefix of other ISP
use PA/PI prefixes from somewhere else because you have those in a VPN and nat to prefix of ISP when going to the internet.

The source can be anything. It does not have to be ULA.

Yes, if you have two prefixes this can make sense. But the internal one needs to be static in one way or another, which is the case for 99% of the users waiting for this. 😊

Yes the internal prrefixes are static which is exactly my use case.  Just wanted to know that nobody hard coded any other assumptions like them having to be ULA.
My use case is having stable internal prefixes for various vpn tunnels.

Sure, makes sense. There is a possibility to also auto-detect the internal prefix (using an interface selection most likely), but we want to see how auto-detect works I practice first.

I have been testing this in a Multi-WAN environment, with mixed results.
Two WAN interfaces, both dynamic (one FTTH on ix0, one DSL on pppoe0). Both are getting /56 prefixes assigned, both get GUA interface addresses assigned that are outside the assigned prefix ranges. There are files ix0_prefixv6 and pppoe0_prefixv6 in /tmp with the correct /56 prefixes.
The internal networks are using /64 ULAs now.
When I use /64 in the NPTv6 rule, the DSL provider routes the packets OK, and I can see the prefix from the interface’s GUA combined with the lower 64 bits of the ULA in test-ipv6.com, just like ivwang describes above. Using /56 in the NPTv6 rule, test-ipv6.com says that I don’t have an IPv6 address, and traceroute6 does not reply anything. Using packet capture, I can see that the prefix ID is indeed used, the translated address now consists of the first 56 bits of the interface’s GUA, followed by the lower 72 bits of the ULA.
The FTTH provider does not route anything in both cases (both /64 and /56 on the NPTv6 rule create addresses like described above, but that provider seems to only route the /128 GUA). Both fail in test-ipv6.com.
I suppose the problem could be solved by using the delegated prefix that can be seen in the /tmp/ix0_prefixv6 and /tmp/pppoe0_prefixv6 files instead of the interface’s GUA prefix when doing the translation. Would that be possible to change, or add as an option?

Using the delegated prefix instead of the wan interfaces GUA is definetely the right thing to do.
That is what the delegated prefix is intended for.

I’m unwilling to embed a fixed prefix into the rules for obvious reasons at this stage. Depending on the ISP and network gear you get the PD net on WAN or not and contributors to this issue have proven to be nonexistent 🤷♂

But the prefix is not fixed, it's dynamic?

Fixed as in literal as in explicit as per edit. -.-

Sorry, misread your comment (fixed vs explicit), so I deleted a comment. What contribution would be needed?

Some sort of sensible progression of gradual improvement and ideas. ;) I suppose we can pick up the prefix from a LAN tracking it. I don’t want to reach for the file or ifconfig as that will be stale after a reload and cause wonkiness or the rule to disappear because the address is not available.

The whole idea of prefix delegation is to give the consumer address space to use.  The broadband consumer will generally not be able to use anything but the /128 of the prefix on the WAN interface.   It is the dynamic delegated prefix that should be used for any kinds of prefix nat.
This is of course also the difficulty as the delegated prefix does not sit on any interface from where it could be picked easily.
There needs to be a trigger that updates the rules when the delegated prefix changes.
I know too little of how opnsense sets these things up to be able to recommend a solution.  Trying to help though.

Fully agree about the file, I mentioned it just to point out that the information exists somewhere. And indeed, it's not a good source.
The trigger mentioned in the previous post does seem to exist already? Local interfaces using WAN tracking are already being updated when the WAN changes (not sure what exactly triggers the update, is it newwanip?). Anyway, that could be a starting point to update the rules also.
I also don't know enough about the architecture, but I would like to help as well. For now, that'll be testing...

@christiankratzer not sure what you mean. The prefix is effectively on each tracking LAN, but with a /64. however, we do have the prefix size hint from the WAN configuration. I don’t see an issue here.
@RehaagJ the filter might not reload for varying reasons and also PPPoE can be a factor of further difficulty wedged in between. So we can’t rely on the ruleset to be reloaded at all times/at the perfect times. We spent a lot of effort to remove such problems from the generated pf.conf rules over the years actually.

@fichtner There are several prefixes involved in this context
The prefix of the WAN interface which is not relevant for this exercise.  Generally the only usable address out of the lan prefix is the single /128 on the interface.
The various statically configured prefixes of the LAN interfaces which are always /64.
The dynamic prefix (IA_PD) that is delegated from the ISP through DHCPv6 or PPPoE ( typically a /56 or /48 ).
The task would be to NAT the LAN various LAN prefixes to a subnet of the delegated prefix.
LAN1::  nat to IA_PD:1::
LAN2::  nat to IA_PD:2::
LAN3::  nat to IA_PD:3::

@fichtner
on this:

@christiankratzer not sure what you mean. The prefix is effectively on each tracking LAN, but with a /64. however, we do have the prefix size hint from the WAN configuration. I don’t see an issue here.

The whole idea of this use case is to not allow the dynamic delegated prefixes to propage to the LAN interfaces so that one can statically configure them to ULA or other prefixes.
This is why we need prefix NAT to be dynamic to the assigned prefix.
I get the challenge in keeping this in sync. I remember somebody writing that pfsense had a similar feature. We should investigate what they have and how they implemented it.

I still understand the issue but not the challenge after getting a milestone done here. I don’t see a problem improving this as required by certain PD deployments. And you don’t want to look what pfSense did ;)

The question I have is does the curent milestone nat to the prefix of the WAN interface or to the assigned prefix ?
What I am trying to say is that natting to the WAN prefix instead of the delegated prefix would not serve any purpose as only the /128 would be usable.  That would require ipv4 style hide nats instead of a prefix nat.
I am not aware of any residential deployments where the user could use any iP other than the assigned IP on the WAN prefix.
My current setup is fully static so I am unable to test immediately.
I need to build a lab setup for this with some VM to fully test.


Remove typescript dep

Should this also close https://github.com/angular/angular-cli/issues/5053? Original report is the same problem. There are lots of discussions on unrelated topics, so maybe it's better to suggest users to open new issues with clear description instead.

Hello, is it normal that I'm still getting this error message then:
→ npm install
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><2.5 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

Using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

@picosam what version of TS are you using?

@filipesilva So I now after updating I'm getting this:
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><2.6 but none is installed. You must install peer dependencies yourself.
In my packages.json file I have this: "typescript": "^2.6.2"


Update and complete README

Pull Request Checklist
Is this in reference to an existing issue?
No
General

[ ] Update Changelog following the conventions laid out here

[x] Update README with any necessary configuration snippets

[ ] Binstubs are created if needed

[ ] RuboCop passes

[ ] Existing tests pass

Purpose
Standardize readme according to https://github.com/sensu-plugins/community/pull/134
Known Compatibility Issues
None

Need to add usage examples. I could not get this plugin to install to retrieve them myself.
hillaryfraley@Hillarys-Sensu-MacBook-Pro ~ % sudo sensu-install -p rabbitmq --verbose
[SENSU-INSTALL] installing Sensu plugins ...
[SENSU-INSTALL] provided Sensu plugins: ["rabbitmq"]
[SENSU-INSTALL] compiled Sensu plugin gems: ["sensu-plugins-rabbitmq"]
[SENSU-INSTALL] determining if Sensu gem 'sensu-plugins-rabbitmq' is already installed ...
 This could take a while...
current directory: /opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/unf_ext-<IP_ADDRESS>/ext/unf_ext
/opt/sensu/embedded/bin/ruby -r ./siteconf20191206-14319-wfn10h.rb extconf.rb
checking for -lstdc++... no
creating Makefile
current directory: /opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/unf_ext-<IP_ADDRESS>/ext/unf_ext
make "DESTDIR=" clean
current directory: /opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/unf_ext-<IP_ADDRESS>/ext/unf_ext
make "DESTDIR="
compiling unf.cc
linking shared-object unf_ext.bundle
clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9 [-Wdeprecated]
ld: library not found for -lstdc++
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [unf_ext.bundle] Error 1
ERROR:  Error installing sensu-plugins-rabbitmq:
	ERROR: Failed to build gem native extension.

    Building has failed. See above output for more information on the failure.
make failed, exit code 2

Gem files will remain installed in /opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/unf_ext-<IP_ADDRESS> for inspection.
Results logged to /opt/sensu/embedded/lib/ruby/gems/2.4.0/extensions/x86_64-darwin-16/2.4.0/unf_ext-<IP_ADDRESS>/gem_make.out
[SENSU-INSTALL] failed to install Sensu gem 'sensu-plugins-rabbitmq'
[SENSU-INSTALL] please take note of any failure messages above
[SENSU-INSTALL] make sure you have build tools installed (e.g. gcc)
[SENSU-INSTALL] trying to determine the Sensu plugin homepage for sensu-plugins-rabbitmq ...
homepage: https://github.com/sensu-plugins/sensu-plugins-rabbitmq

hey!
Was this ready for merge or is this still a work in progress?
Do you need help getting a working build?

Hi @jspaleta ! WIP right now. Aaron put something together that should help me get a working build, but if I can't get it working, I'll follow up with you. Thank you.

@jspaleta this one should be ready for review now!
The error I had was because I didn't have a library installed on my mac. Aaron got me going in a vagrant box so I could get the usage examples. He mentioned this probably isn't something that needs to be in the readme. wdyt?


Add to ansible-galaxy

Hi guys,
I've been playing around with this project a bit and am impressed with it. It works well in isolation, but because of the structure of this repository, to get the roles integrated into an existing ansible repo I had to manually copy the roles/ out and paste them into our repo.
I would like to open some discussion around restructuring the repo so that it can be easily imported into ansible-galaxy, for easier integration into customers existing infrastructure repositories.
Would something like that be possible? Hope what I'm asking for makes sense, would be happy to clarify.

This has floated around some and I think the approach so far has been to have a separate repository that extracts the roles from this repository and gets combined with other roles such as the OS STIG/RKE2 prep roles being developed to make them more galaxy friendly. This might have already been done, in fact. I'll see if we can gather some info around this.

Hey @mddamato, do you have any updates on your above comment?
Cheers

That was my original goal with this repo example. It was meant to be a single play, but other decisions were made and this was turned into a full playbook.
Perhaps we can see about turning this back into a single role and see if the community agrees with us, @bsecker .

Looking over the code base again, this would be a herculean effort to return the code base to a single role. I really like the idea, but not sure how feasible it is now.

rather than reverse back a single role, what about using this repo for a galaxy collection?  possibly even consider bringing in the rke2_nvidia role from the enable-gpu-rke2 repo.  I have done some offline work along these lines and this would be very straight-forward to do.  I would be glad to help make this happen.

https://github.com/lablabs/ansible-role-rke2
that repository does provide a role, was there any communication between the maintainers of this repo and theirs?

How about https://github.com/jdloft/rke2-ansible/tree/galaxy? That would be the bare minimum for being able to import playbooks:
- import_playbook: rancherfederal.rke2.site


upgrade process generates a file named config.toml but default used by 2.x is config.yaml

according to the influxd 2.0 help:
	A config file can be provided via the INFLUXD_CONFIG_PATH env var. If a file is
	not provided via an env var, influxd will look in the current directory for a
	config.yaml file. If one does not exist, then it will continue unchanged.

yet the upgrade process generates a file named config.toml and i don't see a reason why (there's no explicit toml syntax)

@russorat it looks like the config-parser will handle either config.yaml or config.toml. Do we want to modify the upgrade command to produce YAML, or just update the help text to match the current behavior?

The name of the file generated should match the default name we look for when starting 2.0. Specifically: influxd will look in the current directory for a config.yaml file
you are saying it will find either a config.toml or a config.yaml by default? if that's the case, we can simply update the text in the help message,


Add MF_TOPOLOGY_ENABLE_XVP_FOR_PLAYBACK attr

Please add the attribute (MF_TOPOLOGY_ENABLE_XVP_FOR_PLAYBACK) which is 'hidden'.
Note, (MF_TOPOLOGY_ENABLE_XVP_FOR_PLAYBACK) does not have a page on MSDN or much less here on the repo (https://github.com/MicrosoftDocs/win32/tree/docs/desktop-src/medfound).

@VictorSantosReis : Thanks for your contribution! The author(s) have been notified to review your proposed change.

A page has been added for this attribute: https://docs.microsoft.com/en-us/windows/win32/medfound/mf-topology-enable-xvp-for-playback
Since the attribute has been documented, I'm going to close this PR. Thanks!


<EMAIL_ADDRESS><EMAIL_ADDRESS>as defaults

Summary
Update ESMF and MAPL defaults per Oct 19 spack-stack meeting.
Testing
UFS WM cpld_control_p8/intel successful on Orion; cpld_control_gfsv17 successful on Hera
Applications affected
all
Systems affected
all
Dependencies
https://github.com/JCSDA/spack/pull/352
Issue(s) addressed
Fixes #753
Checklist

[x] This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
[ ] These changes have been tested on the affected systems and applications.
[ ] All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji this should be ready to go very shortly. Oddly, in just the ubuntu CI it was failing because of duplicate py-pandas (mix of 1.5.2 and 1.5.3). Do you have any concerns about setting the default to 1.5.2? I know you had some issues once upon a time with that setting.

@climbfuji this should be ready to go very shortly. Oddly, in just the ubuntu CI it was failing because of duplicate py-pandas (mix of 1.5.2 and 1.5.3). Do you have any concerns about setting the default to 1.5.2? I know you had some issues once upon a time with that setting.

We need to verify that the excel dependencies are getting installed correctly. Do we know why it insists on 1.5.2?

No. For some reason, only ufs-weather-model-env>ufs-pyenv>py-pandas was using 1.5.2, everything else was using 1.5.3. And it's only in the ubuntu CI (not macOS and not on Hera).

No. For some reason, only ufs-weather-model-env>ufs-pyenv>py-pandas was using 1.5.2, everything else was using 1.5.3. And it's only in the ubuntu CI (not macOS and not on Hera).

Can we force it to use 1.5.3 since that's the version used everywhere else?

Yep, looks like that works okay.

Yep, looks like that works okay.

Great, thanks!

Done, thanks!

@AlexanderRichert-NOAA Why did you close this PR instead of merging it? Can I restore your branch and reopen the PR?

Actually, I am going to merge it since I already approved it and it passed CI.

@climbfuji thanks for taking care of this, I must have absentmindedly hit the close button :upside_down_face:


CSS Stylings possibly break when used with Bootstrap/AdminLTE

Needs verification on other machines and/or in additional projects.

I'd have to check it out myself. I don't see how. The dump screen does not extend from any other templates. This means that the CSS and JS that are loaded should only be what is needed for dumping. Nothing else. So, I don't see how it could conflict.
Unless you are using the template tag. In which case the documentation has a warning that it will collide with the CSS of your site and lead to really weird formatting. It also mentions that the majority of dumping should be done via python code and not the template. The template tag is a "use at your own risk" type of tag.

Have we been able to (or even attempted to) reproduce this since it was last comment? To my knowledge, we have not tried. But probably should, particularly now that both packages are presumably stable, since they're public at this point.


Refactor AnonymousCheck

AnonymousCheck is currently using string search to determine if Anonymous structure is used and this should be refactored.

fixed in dev branch


Precedence for Item vs Expr

I'm trying to parse a macro call (along the lines of foo! { }) inside an ItemFn. When looking at Stmt, I initially guessed this would be an expression, and I found the Macro expression type. However, it turned out to be an Item of type Macro instead. As far as I can tell, macros can be used either way. How does syn decide which to use? Should the documentation (for Stmt, for example) talk about this a little bit?

In syn 2, macro invocations get parsed as Stmt::Macro; the documentation indicates it's ambiguous whether such a macro would expand to a local, item, or expr. https://docs.rs/syn/2/syn/enum.Stmt.html#variant.Macro


PREVIEW celo8 rebase (without fees fix)

superseded by https://github.com/celo-org/optimism/pull/223


Feature request: mark new posts on the listing page

Listing page does not distinguish between old and new posts, making it difficult to spot whether new posts were published recently. Provide some visual clue that a post is new: newer than some time threshold, not read, or added after the last visit of a viewing user, or some other criteria.

I'll just leave some ideas on how to implement it for now.

newer than some time threshold

Use some JS and check the timestamps to set some class on the new ones.

not read

Style the visited link differently, so those styled normally are not read.

added after the last visit of a viewing user

Store the timestamp on visit and if there's anything set already, do something to the posts newer than the previous time. The previous one might be enough, though.

I'll just leave some ideas on how to implement it for now.

newer than some time threshold

Use some JS and check the timestamps to set some class on the new ones.

not read

Style the visited link differently, so those styled normally are not read.

added after the last visit of a viewing user

Store the timestamp on visit and if there's anything set already, do something to the posts newer than the previous time. The previous one might be enough, though.


Roll Engine from 79e076dc9280 to 87250f771346 (1 revision)

https://github.com/flutter/engine/compare/79e076dc9280...87250f771346
2022-01-02<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from 2hRzIJtfq... to Fh2Uh8N-v... (flutter/engine#30633)
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 2hRzIJtfq2Hw to Fh2Uh8N-vwka
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add newly computed metrics to expandable metrics viewer

Detailed Description
In the wireframe for #115 , there are two metrics included that we do not have currently computed or displayed anywhere else in the application currently:

Competitive

Majority non-white

It seems that we still need to define how these are computed, so I left these out of #827 - we likely need a bit more context from @tgilcrest  / @jfrankl here to clarify how these fields should be computed.

We discussed and we want to just remove the "Competitive" column from the expanded viewer.
For the "majority nonwhite", rename to "Majority race".

Show either:

The majority race, or
"Coalition" if the sum of minority race shares is a majority

It probably makes sense to tack this on to #839, since it relies on the computation that I implemented there. However, we need to get #827 merged first to actually add in additional metrics to the metrics viewer


feat: Add used_in_production arg in subaccount creation and update

Purpose

Closes #273
With this PR users can now set used_for_production = UNSET | USED_FOR_PRODUCTION | NOT_USED_FOR_PRODUCTION when creating subaccounts

...

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Test the code

resource "btp_subaccount" "subaccount" {
  name = var.display_name
  subdomain = var.subdomain
  region = var.region
  parent_id = var.parent_guid
  used_for_procduction = "NOT_USED_FOR_PRODUCTION"
}

What to Check
Verify that the following are valid

Verify that the subaccount created has the attribute correctly set

Other Information

Thanks for your contribution! Can you execute a make generate and commit the updated documentation to this PR?

@Thanhphan1147 : No worries about the failed tests. I will check what is missing an eventually add new test recordings to this PR

@Thanhphan1147 there is one issue to fix: you need to adjust the facade_accounts_subaccount_test.go. Due to the addition of the usage the expected result now deviates (see e.g. https://github.com/SAP/terraform-provider-btp/actions/runs/5532790691/jobs/10095867971?pr=288#step:6:214)
The other error in the test must be fixed by us by re-recording the test fixtures for the subaccount

I updated the test file

I merged it into a temporary branch to re-record the tests and then merge it into main.


Hubject OICP connection *copy from ev-server

Hello,
I copied the thread from ev-server, maybe I can get some answers here!
anybody did this?
There are the endpoints in the code but don't know how to connect to them!
Is it possible to connect only through the CPO Identification? which it requires only the:
Country Code
Party ID (I guess this is the provider/evse operator ID)
Private key (do we copy here the code from the file that was generated?)
Certificate (do we copy the PEM signed code that we got from them?)

I'm writing here because I think the problem is with the dashboard!
I found that the actual create button is hidden for the admin role! I have no idea why.
Which means I was able finally to add the connection and test it, but I thought that I would be able to send chargers individualy as it seems all the chargers are going to the roaming!
Maybe somebody can shed some light on this.

Update:
The problem was with the SAP e-mobility simulator not wanting to do remote start!
I changed to EVerest one and I managed to make the remote start and authorize start.
But now I cant remote stop and authorize stop :(
For the remote stop it says:
OicpAuthorizeRemoteStop OICP Transaction ID '3893d3f4-a964-4089-a7bc-1ee4ec1c7bd7' does not exists
For authorize stop it says:
unable to get local issuer certificate
Any ideas?


📖 Update install and development help

See #995 and Discord conversations.

Oh boy, thanks for actually testing them @choldgraf I have added the command! @agoose77 this should be npm run link not npm link (which only will link the monorepo, which isn't what we want). Previously this was part of the dev command, but that also watches. I have made a new script that runs that over the various repos we need (mystmd and jtex).

I think that worked! I did the following:

Checked out this PR

Ran pip uninstall mystmd

Ran the commands in the README

It now worked

Version from another folder:
❯ myst -v
v1.1.47

If that looks correct to you, I think we should merge this

Thank you for testing, wrote this on the way to a meeting and didn't test myself. Glad you are up and running!

@agoose77 this should be npm run link not npm link (which only will link the monorepo, which isn't what we want).

Thanks! I misread this as running in the mystmd package, which is semantically different to the root!


World-writable executable in MultiBit.app (Mac OS X)

Just installed latest version for OS X (from https://multibit.org/releases/multibit-0.5.18/multibit-0.5.18.dmg).  Permissions on the executable in the .app bundle include world and group write permissions.  Seems this could provide an injection point for malware.
-rwxrwxrwx@ 1 sysadmin  admin    72K Apr 28  2014 MultiBit.app/Contents/MacOS/JavaApplicationStub*

Seems to me -rwxr-xr-x would be a more secure choice.  Can/should this be changed?

This is a good idea. I don't think there is any need at all for world and group write access to the exe itself.

Also raised in the MultiBit HD issue database here:
https://github.com/bitcoin-solutions/multibit-hd/issues/572

Changing over to the Install4j installer now means that the multibit-hd.jar is now read only to world and group.
-rw-r--r--  1 jim  admin  8121539 21 Jul 16:15 multibit-exe.jar
Awaiting review and closing

Install4j handles the permissions correctly by default. Closing.


Enabling GPU on Sagemaker for TextPredictor (multimodal)

Hi,
I'm using ml.g4dn.2xlarge instance on SageMaker, with conda_mxnet_p36 kernel, and would like to run :
predictor = TabularPredictor(label="detect_label").fit(train_data=df_train, time_limit=14400, hyperparameters="multimodal")
But I keep on getting the TextPredictor error that  "No GPU is detected in the machine".
How do I enable the GPU usage?
(I can use another instance if this is the problem?)
My code:
! pip install -U pip==21.3.1
! pip install -U setuptools wheel
! pip install -U "mxnet<2.0.0"
! pip install -U autogluon

import pandas as pd

import warnings
warnings.filterwarnings("ignore")

train_data = pd.read_csv('training.csv')
test_data = pd.read_csv('testing.csv')

from autogluon.tabular import TabularDataset, TabularPredictor

train_data = TabularDataset('training.csv')
set_path = 'model_path'

predictor = TabularPredictor(label="detect_label").fit(train_data=df_train, time_limit=14400, hyperparameters="multimodal")

Thanks

This should be fixed in v0.4 release (released on March 9th 2022). Please let us know if you still are facing issues!

Do note that v0.4 is only available on Python 3.7 - 3.9, so the conda_mxnet_p36 kernel will not work. You can instead use a p37 kernel. AutoGluon v0.4 does not depend on MXNet anymore, so no need to select a mxnet kernel.


AtomTypeEState indices empty instead zero

Some of the AtomTypeEState indices for elements are empty. I believe they should be zero.
for example in mordred the index 938 |   | MAXsLi | AtomTypeEState (‘max’, ‘sLi’)
This is an E-state index for the element Lithium. In mordred it is empty for a number of values.

When calculating the same data set with Dragon, the E-state indices for missing elements in the compound (Li, Be etc) are correctly zero. I am not sure if they relate exactly to the same E-state index. However if the element such as Li is absent, its zero.

Installed via anaconda environment
conda install -c rdkit -c mordred-descriptor mordred

python -m mordred --version
mordred-1.1.1

Example files: ftp://ftp.ncbi.nlm.nih.gov/pubchem/Compound/CURRENT-Full/SDF/

I know that max/min of EState of mordred are missing value and dragon's one are zero. And it is library design.
In mathematics, max/min of empty set are undefined.
In mordred, missing value are returned instead of default value in such case, because it is easy imputing missing value, but it is hard distinguishing missing value from imputed values.

I am actually not a descriptor guy and I agree with the NA vs zero vs empty argument.
I would check what the mathematical equation says,
E-state indices were published first in Kier and Hall see
http://www.vcclab.org/lab/indexhlp/etstate.html
(just an external ref with original references)
and then I would check what other descriptor software tools calculate.
For the E-state index software I think the original reference is Molconn-Z
http://www.edusoft-lc.com/molconn/manuals/400/chaptwo.html
Then its Dragon, Padel, Molgen-QSPR, MOLD,
basically if every tools says zero (0) then its community voted or approved,
otherwise mordred is  different to all other tools.
I did not do any investigation of empty values vs zero values,
but for deep learning it may not matter because its invariant and zero,
I (personally) do not like empty values, because the may be replaced by
min, mean, max values, but then again for chemical elements that are missing
I think a zero value is just fine (no proof given).

I'm sorry for my late reply. And thank you for your detailed survey.
We can decide easily if it is mentioned by original paper or implementation.
But, I cannot access Molconn-Z. Thus I cannot decide easily to adopt broken change.
However, for example, we can add like 'descriptor flavor' feature to chose such behavior.
calc = Calculator(descriptors, flator={AtomTypeEState: {"fill": 0}})

of course, this pseudo code is not best, and we should decide API carefully (I opened new issue #66 for discus about it).

This comment is for those suggesting generation of numerical values when none were actually determined. The program authors clearly know what they are doing and are thus far entirely correct in their approach.
Not determined = undefined.
Please do not generate values (0 or any other number) for undefined states!
For example, if there are no lithium atoms, why would they be assigned any value?
Even worse would be to assign zero to a descriptor that may take positive & negative values! Take some hypothetical descriptor that reflects partial charge on atoms. A zero value indicates that an atom has a charge between that of the tertiary carbon (~ +0.3) and the methyl groups (~ -0.5) in 2,2-dimethylpropane, for example. If charge calculation was not accomplished, then its value is undefined. Either omit the compound(s) without that descriptor value or omit that descriptor from further study. Meaningful regression is not possible otherwise.
Blank, NAN, or something comparable is the correct approach.
Regards,
plkx

This comment is for those suggesting generation of numerical values when none were actually determined. The program authors clearly know what they are doing and are thus far entirely correct in their approach.
Not determined = undefined.
Please do not generate values (0 or any other number) for undefined states!
For example, if there are no lithium atoms, why would they be assigned any value?
Even worse would be to assign zero to a descriptor that may take positive & negative values! Take some hypothetical descriptor that reflects partial charge on atoms. A zero value indicates that an atom has a charge between that of the tertiary carbon (~ +0.3) and the methyl groups (~ -0.5) in 2,2-dimethylpropane, for example. If charge calculation was not accomplished, then its value is undefined. Either omit the compound(s) without that descriptor value or omit that descriptor from further study. Meaningful regression is not possible otherwise.
Blank, NAN, or something comparable is the correct approach.
Regards,
plkx

@plkx
I think NAN or NA is better than blank. With a blank one always wonders if something is wrong with the algorithm.

@plkx
I think NAN or NA is better than blank. With a blank one always wonders if something is wrong with the algorithm.


fitting module

Hi,
I noticed that the inputs to fitting.py are images, and I wonder if the code supports having an image for src input and a video for the driving input. Thanks in advance!

We'll add a video demo when we have time.

Does current released codes support video sequence as input to fitting.py?

Do current released codes support video sequence as input to fitting.py?

Yes, you need to manually extract each video frame and use fitting.py for each frame.


feature(argus): REST HTTP Client

This PR adds a REST API client for Argus, as both a generic base
client and an SCT client.
Trello

I think Argus client methods shouldn't return requests.Response objects. As client methods are rather commands, they should return nothing or raise exception when something goes wrong.

Yes, that's a good idea. Currently REST methods themselves pretty much return nothing - they either echo the data sent, or reply with simple strings that indicate action completion, so we could instead return nothing and just handle requests.Response objects internally.

LGTM. Required may document with example of usage. am i right, that we should have appropriate backend logic (Plugin?) which will response to the client requests?

Yes, backend logic is already implemented, basic test submission stuff is argus/backend/controller/client_api.py, while sct-specific one is argus/backend/plugin/sct/controller.py

@k0machi you requested review after accepting my comments, but I don't see any commits since my review - did you forget to push?

Apologies, I accidentally re-requested it when I was looking and replying to some of your comments

I think Argus client methods shouldn't return requests.Response objects. As client methods are rather commands, they should return nothing or raise exception when something goes wrong.

I'm thinking about this meanwhile, and I'm currently not sure how I want to handle this - should the base client have a generic handler for API and HTTP errors and raise an exception during one of the Verb methods (get/post)? Or should each client just handle errors itself? The latter one would lead to a lot of code duplication checking status code and json response, the former might reduce flexibility wrt to how API can respond.

I think Argus client methods shouldn't return requests.Response objects. As client methods are rather commands, they should return nothing or raise exception when something goes wrong.

I'm thinking about this meanwhile, and I'm currently not sure how I want to handle this - should the base client have a generic handler for API and HTTP errors and raise an exception during one of the Verb methods (get/post)? Or should each client just handle errors itself? The latter one would lead to a lot of code duplication checking status code and json response, the former might reduce flexibility wrt to how API can respond.

To avoid code duplication you could enhance generic post/get methods with argument of expected response code which would raise exception on mismatch. Another option would be adding function that would take response and expected response code and do validation. Not always the same code blocks are considered as code duplication - sometimes it is just a coincidence.

I think Argus client methods shouldn't return requests.Response objects. As client methods are rather commands, they should return nothing or raise exception when something goes wrong.

I'm thinking about this meanwhile, and I'm currently not sure how I want to handle this - should the base client have a generic handler for API and HTTP errors and raise an exception during one of the Verb methods (get/post)? Or should each client just handle errors itself? The latter one would lead to a lot of code duplication checking status code and json response, the former might reduce flexibility wrt to how API can respond.

To avoid code duplication you could enhance generic post/get methods with argument of expected response code which would raise exception on mismatch. Another option would be adding function that would take response and expected response code and do validation. Not always the same code blocks are considered as code duplication - sometimes it is just a coincidence.

Alright, done.

Still methods return str|None while it is not clear why it is needed for. Also would be nice to have some docs lines for methods - especially when one method requires execution of other one (e.g. does subimt_nemesis requires later finalize_nemesis?)

So all methods in theory should return a result string - Maybe introducing a Result enum would be a good idea here; As for docstrings - good idea, will push them today.

Still methods return str|None while it is not clear why it is needed for. Also would be nice to have some docs lines for methods - especially when one method requires execution of other one (e.g. does subimt_nemesis requires later finalize_nemesis?)

So all methods in theory should return a result string - Maybe introducing a Result enum would be a good idea here; As for docstrings - good idea, will push them today.

What is this result string used for? When we send command like heartbeat or update_product_version do we need any response to process further?

Still methods return str|None while it is not clear why it is needed for. Also would be nice to have some docs lines for methods - especially when one method requires execution of other one (e.g. does subimt_nemesis requires later finalize_nemesis?)

So all methods in theory should return a result string - Maybe introducing a Result enum would be a good idea here; As for docstrings - good idea, will push them today.

What is this result string used for? When we send command like heartbeat or update_product_version do we need any response to process further?

Just an informational result, we could either use a boolean or string or nothing to indicate success and an exception to indicate failure. Considering the exception indicates failure, I'm thinking about returning nothing as a success and logging the received message string, but we could alternatively return False on failure and True on success, or use enum values there if we want to have control flow based on API responses.

Still methods return str|None while it is not clear why it is needed for. Also would be nice to have some docs lines for methods - especially when one method requires execution of other one (e.g. does subimt_nemesis requires later finalize_nemesis?)

So all methods in theory should return a result string - Maybe introducing a Result enum would be a good idea here; As for docstrings - good idea, will push them today.

What is this result string used for? When we send command like heartbeat or update_product_version do we need any response to process further?

Just an informational result, we could either use a boolean or string or nothing to indicate success and an exception to indicate failure. Considering the exception indicates failure, I'm thinking about returning nothing as a success and logging the received message string, but we could alternatively return False on failure and True on success, or use enum values there if we want to have control flow based on API responses.

If not needed, better to return nothing. Let's add later to these methods where needed. Returning nothing on success and exception on failure is quite common solution.

@soyacz / @aleksbykov let's get it reviewed so we can merge it.


Update passport.md

Information
Update Passport protocols's componentScan related to the new version.

[ ] Tests
[ ] Coverage
[ ] Example
[ x] Documentation

:tada: This PR is included in version 7.0.2 :tada:
The release is available on:

v7.0.2
GitHub release

Your semantic-release bot :package::rocket:


Create aka.ms link for Identity troubleshooting.

          I wonder if this is the best link to put in logs. Maybe we should put an `aka.ms` link so we can redirect it if needed without having to ship updates. I can easily imagine GitHub doc headings and tree structure changing without realizing it is breaking links that we point folks to in the logs.

Originally posted by @ahsonkhan in https://github.com/Azure/azure-sdk-for-cpp/pull/4428#discussion_r1134524628

Add azsdknative and Rick to owners.


1.0.6 can't connect to keyboard

Bluetooth connection status at bottom left is "Not Connected" despite the keyboard being connected to the computer and functioning properly. Unable to make any changes. I've tried wired and wireless, and I've also tried repairing the keyboard to the computer to no avail. I may have gotten a faulty KB, because I've been having issues with the BT, but FWIW, 1.0.5 was able to connect and make changes to the KB.

Can you try connecting the keyboard to your phone? Download the official obins app and check if you can control the keyboard from there.

I am able to connect and control the keyboard from my Android phone.

I would suggest you try to connect to Windows and check if you can type with it  wirelessly (as in,  connect over Bluetooth, ensure that the USB cable is not connected).
Then try using the app.

The "sync profile" option is not grayed-out, though. But when I try to sync, a message flashes briefly saying that it failed to sync and that the exception was handled.

Can you open up Bluetooth settings and take a screenshot?
The settings should like so http://thewindowsclub.thewindowsclubco.netdna-cdn.com/wp-content/uploads/2016/08/bluetooth-in-windows-10.png

https://i.imgur.com/3kaWCHr.png

So I figured out the problem. Somehow, my computer had assigned vscode as the default application to .ps1 files, which was preventing the app from working. Changed it back to notepad, and "run in powershell" reappeared in the .ps1's context menu. App works fine now. I'm not sure what caused this to happen, but glad to know it wasn't an issue with the app.


fix: Fix for locator for AddWidgetTableAndBind_spec test case

Description
Found minor locator failure
Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test tags="<EMAIL_ADDRESS>:mag: Cypress test results

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12465389478
Commit: 9cf2fbe2bbda6abdb9547bbb8f38d578fe343f04
Workflow: PR Automation test suite
Tags<EMAIL_ADDRESS>Spec: ``
Mon, 23 Dec 2024 10:34:30 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

/ci-test-limit-count run_count=3 update_snapshot=true specs_to_run=cypress/e2e/Regression/ServerSide/QueryPane/AddWidgetTableAndBind_spec.js


causal_conv1d_cuda import error

 File "/home/sx/anaconda3/envs/sam/lib/python3.11/site-packages/mamba_ssm/__init__.py", line 3, in <module>
    from mamba_ssm.ops.selective_scan_interface import selective_scan_fn, mamba_inner_fn
  File "/home/sx/anaconda3/envs/sam/lib/python3.11/site-packages/mamba_ssm/ops/selective_scan_interface.py", line 9, in <module>
    from causal_conv1d import causal_conv1d_fn
  File "/home/sx/anaconda3/envs/sam/lib/python3.11/site-packages/causal_conv1d/__init__.py", line 3, in <module>
    from causal_conv1d.causal_conv1d_interface import causal_conv1d_fn, causal_conv1d_update
  File "/home/sx/anaconda3/envs/sam/lib/python3.11/site-packages/causal_conv1d/causal_conv1d_interface.py", line 7, in <module>
    import causal_conv1d_cuda
ImportError: libcudart.so.12: cannot open shared object file: No such file or directory

How to download the following wheel file?
pip install causal_conv1d==1.0.0  # causal_conv1d-1.0.0+cu118torch1.13cxx11abiFALSE-cp310-cp310-linux_x86_64.whl
pip install mamba_ssm==1.0.1  # mamba_ssm-1.0.1+cu118torch1.13cxx11abiFALSE-cp310-cp310-linux_x86_64.whl

we downloaded causalconv1d package and mamba ssm package from their github repos. And we may provide those packages ourselves in the future.

You do not need to install from the wheel file.
You can install from pip becasue they uploaded package already.
Or download the source code( git clone ~~) and run pip install -e . in each subdirectory.

Update here,
I just solved this problem by git clone the repo from GitHub and use pip install -e .
Thanks
Shawn

You do not need to install from the wheel file. You can install from pip becasue they uploaded package already. Or download the source code( git clone ~~) and run pip install -e . in each subdirectory.


Don't set target in swift projects

Steps:

Create new swift project
Set up generamba and templates
Generamba gen

ER: Files created and included in project's target
AR: Files created and included in project but didn't include in target

@mogol has already reported this issue. Herman, did you take any steps to fix it?

@igrekde ,
I fixed this in develop branch.

@mogol thanks for taking this issue and adding unit tests! 🎉


App crashes with 5.2.0 and ".AllowViewModels 5.2.1-beta"

I get a crash if I flip views very fast (hammer a "Next" button) with the below NSInternalInconsistencyException.
I tried downloading the source code however and ...

I can no longer repro
There are differences made to the code (the property IsSwipeEnabled has been renamed to IsSwipingEnabled) so you guys have obviously been busy and I suspect there's a new version coming up, right?

For now we're moving ahead with the source code and hope there's a new package coming up soon.
Cheers!
Objective-C exception thrown.  Name: NSInternalInconsistencyException Reason: No view controller managing visible view <Xamarin_Forms_Platform_iOS_Platform_DefaultRenderer: 0x7ff63466f5e0; frame = (0 0; 375 650); autoresize = LM+W+RM+TM+H+BM; layer = <CALayer: 0x600002d538a0>>
Native stack trace:
	0   CoreFoundation                      0x000000010e67a1bb __exceptionPreprocess + 331
	1   libobjc.A.dylib                     0x000000010f801735 objc_exception_throw + 48
	2   CoreFoundation                      0x000000010e679f42 +[NSException raise:format:arguments:] + 98
	3   Foundation                          0x000000010c38e877 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 194
	4   UIKitCore                           0x000000011541aafb -[UIPageViewController queuingScrollView:didEndManualScroll:toRevealView:direction:animated:didFinish:didComplete:] + 1155
	5   UIKitCore                           0x00000001154265b9 -[_UIQueuingScrollView _notifyDelegateDidEndManualScroll:toRevealView:direction:animated:didFinish:didComplete:] + 141
	6   UIKitCore                           0x0000000115426243 __78-[_UIQueuingScrollView _enqueueAnimatedScrollInDirection:withView:completion:]_block_invoke.299 + 59
	7   UIKitCore                           0x0000000115428a8a -[_UITransitionState cleanupWithFinishedState:completedState:] + 35
	8   UIKitCore                           0x0000000115424f97 -[_UIQueuingScrollView _cleanUpCompletionState:didFinish:didComplete:] + 96
	9   UIKitCore                           0x0000000115427677 -[_UIQueuingScrollView _didScrollWithAnimation:force:] + 563
	10  UIKitCore                           0x0000000115422f7a -[_UIQueuingScrollView layoutSubviews] + 179
	11  UIKitCore                           0x0000000115f9d795 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 1441
	12  QuartzCore                          0x000000010a2dbb19 -[CALayer layoutSublayers] + 175
	13  QuartzCore                          0x000000010a2e09d3 _ZN2CA5Layer16layout_if_neededEPNS_11TransactionE + 395
	14  QuartzCore                          0x000000010a2597ca _ZN2CA7Context18commit_transactionEPNS_11TransactionE + 342
	15  QuartzCore                          0x000000010a29097e _ZN2CA11Transaction6commitEv + 576
	16  QuartzCore                          0x000000010a1c7e80 _ZN2CA7Display11DisplayLink14dispatch_itemsEyyy + 272
	17  QuartzCore                          0x000000010a294bb9 _ZL22display_timer_callbackP12__CFMachPortPvlS1_ + 297
	18  CoreFoundation                      0x000000010e5b35a6 __CFMachPortPerform + 150
	19  CoreFoundation                      0x000000010e5dff69 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ + 41
	20  CoreFoundation                      0x000000010e5df5bb __CFRunLoopDoSource1 + 459
	21  CoreFoundation                      0x000000010e5d9b2e __CFRunLoopRun + 2526
	22  CoreFoundation                      0x000000010e5d8e11 CFRunLoopRunSpecific + 625
	23  GraphicsServices                    0x0000000113ac41dd GSEventRunModal + 62
	24  UIKitCore                           0x0000000115ab381d UIApplicationMain + 140
	25  ???                                 0x0000000133d7831e 0x0 +<PHONE_NUMBER>
	26  ???                                 0x0000000133d780b3 0x0 +<PHONE_NUMBER>

Indeed i am but i want it to be a real new version with performance fixes and new functionality. It seems the fix of that branch is not correct.

IsSwipingEnabled name was changed while back :)

Speaking of which: Can we wish for separate "IsSwipeRightEnabled/IsSwipeLeftEnabled"? I can see a lot of situations where validation would allow one but not the other. :)

I think i can do that.

Awsome!


Prepare video demo for demonstrate VCP that can be uploaded on VMware youtube channel

Prepare video demo for demonstrate VCP that can be uploaded on VMware youtube channel
cc @pdhamdhere

@stegeler has already created a cool demo that will be uploaded to VMware Cloud-Native youtube channel.
Once it's available, I will close this issue.

@stegeler's video is now live! Check it out at https://www.youtube.com/watch?v=mZxQyHwAefY&t=18s


[Bug]:  Overlapping issue

Give a brief about the bug ✍
There is overlapping issue as shown in the ss below-

What is the expected behavior? 🤔
Everything should be separate and readable.
Provide step by step information reproduce the bug 📄
Please assign me this under gssoc'24.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Please assign me this issue to work upon.

its already fixed please mention some other improvements so that i can assign it to you


Validation configuration changes do not save after an upload

Pluto ver 1.0.10
Steps to reproduce:

Open a validation
Click "Upload" (doesn't matter if it fails or succeeds)
Change a validation rule property
Click "Save"
-> A popup will appear denoting the changes were saved and the UI will reload
-> Review the property changed in step 3 and it shows the old value.

I can't reproduce this and believe it was fixed with the fix to #549.


SpineInterface parameter to wait for shared memory

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.656%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1619

Relevant Lines:
1847

💛  - Coveralls


Get Intent result

I need start external app, get parameters and rea that.
My code returns only "Ok"
`      var sApp = startApp.set({
"intent": "ru.toucan.GET_PARAMETERS",
"package": "ru.toucan.merchant",
"intentstart": "startActivityForResult",
});
  sApp.start(function (response) {
    console.log(response);
  }, function (error) {
    console.log(error);
  });`

Also external app can retrieve only xml data.
Api for external app
Anyone can help me?

@slowkazak
Were you able to create the callback listener for startActivityForResult?

Hi,
Anyone find the solution for the above issue?? I am also the facing the same issue.
And I am getting error "invalid intent" as a toast message while opening the app

Hi, view: https://github.com/lampaa/com.lampa.startapp/issues/107


Dl upgrade

In response to https://github.com/aria-tools/ARIA-tools/issues/197. this pull adds increased functionality for ASF credential handing in ariaDownload.py.
If a user/password combination is explicitly given via -u and -p, it will use them.
Next, it will try and read credentials from ~/.netrc.
Otherwise, it reverts to ASF's built in functionality - it will prompt for user/pass at command line if the cookie jar, ~/.bulk_download_cookiejar.txt does not exist.

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 3

See the complete overview on Codacy


Two days into trying to install this, I'm still getting this:

Can someone, please, explain to me what I have to do to get passed this? I've tried EVERYTHING, updating from El Capitan to High Sierra, updating Homebrew, reinstalling all thinkable node versions, all thinkable versions of node via nvm, the list is endless. What is it that I'm obviously totally missing?
build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Applications/MAMP/htdocs/wp-content/themes/mytheme/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
gyp ERR! System Darwin 17.7.0
gyp ERR! command "/Users/sam/.nvm/versions/node/v10.13.0/bin/node" "/Applications/MAMP/htdocs/wp-content/themes/mytheme/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd /Applications/MAMP/htdocs/wp-content/themes/mytheme/node_modules/node-sass
gyp ERR! node -v v10.13.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
Build failed with error code: 1
npm WARN<EMAIL_ADDRESS>No repository field.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: `node scripts/build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/sam/.npm/_logs/2018-11-01T12_16_41_637Z-debug.log

And no, the log doesn't make it any clearer.

The release notes state that<EMAIL_ADDRESS>does not support Node 10 - https://github.com/sass/node-sass/releases/v3.13.1

And no, the log doesn't make it any clearer

The issue template clearly outlines the information we need in order to help. By ignoring the template, and not uploading the log there is nothing we can do besides direct you at the troubleshooting guide.
Try the steps outline here to rule out weird environment issues: https://github.com/sass/node-sass/blob/master/TROUBLESHOOTING.md#linuxosx
If none of the helps open a new issue and follow the issue template.


Incorrect comment in code.

The comment on the referred line specifies that the order of supportedAuthDomains matters. But the outer loop is the authorized domains from the web request, so actually the first match in the authorized domains list 'wins'.
The inner and outer loops should be switched for the comment to be correct.
https://github.com/firebase/firebase-ios-sdk/blob/31307cdf7e2e7f0cf931ccf30f54fb409cad037d/FirebaseAuth/Sources/Utilities/FIRAuthWebUtils.m#L107

Just to make my initial comment a bit clearer:
Currently, the supportedAuthDomains order does not matter (as opposed to what's stated in the comment) - the returned domain will be determined by the order of response.authorizedDomains.
If response.authorizedDomains contains ["my.web.app", "my.firebaseapp.com"], then we would first look to see if my.web.app matched any of ["firebaseapp.com", "web.app"], which it does and then "my.web.app" will be used.
If the response order was different: ["my.firebaseapp.com", "my.web.app"], then the first match would be for my.firebaseapp.com.
And thus, contrary to the comment, it's not the order of supportedAuthDomains that matters, but the order of response.authorizedDomains that matters. And the latter is not controlled by the library, so that seems like an error - if indeed the order of supportedAuthDomains matters.

@rosalyntan Should the comment be fixed or the code updated to match the comment?
cc: @renkelvin

The code is updated in the release-11.0 branch: https://github.com/firebase/firebase-ios-sdk/blob/release-11.0/FirebaseAuth/Sources/Swift/Utilities/AuthWebUtils.swift#L117

Well, on line 130 and 131 the iteration of supportedAuthDomains is still nested in the iteration of the response domains, so the order or supportedAuthDomains still doesn't matter, does it?

Oops. Good catch, Morten! I'll reopen the issue and send a PR.


NTRs - units needed in agronomic experiments

Could you please add the following units:?

Square meter per second : unit of kinematic viscosity, specific relative angular momentum and thermal diffusivity. synonym: m2/s, m2·s−1, m2s−1.
centimole charge per kilogram (synonym: cmolc/kg): Unit of the cation-exchange capacity. equivalent units me/100g or meq/100g
decisiemens per metre (synonym:dS/m): https://www.naturalresources.sa.gov.au/samurraydarlingbasin/publications/measuring-salinity
microgram per gram: A mass unit density which is equal to mass of an object in micrograms divided by the mass in grams.
gram per kilogram: A mass unit density which is equal to mass of an object in grams divided by the mass in kilograms. g/kg
Feet per second: A speed/velocity unit which is equal to the speed of an object traveling 1-foot distance in one second. synonym: ft/s
Miles per hour: A speed/velocity unit which is equal to the speed of an object traveling 1-mile distance in one hour. synonym: mi/h
gram per square meter: An area density unit which is equal to the mass of an object in grams divided by the surface area in hectares. synonym: g/m2
Pound per hectare: An area density unit which is equal to the mass of an object in pounds divided by the surface area in hectares. synonym: lb/ha
Bushel: A unit volume equivalent to 8 US dry gallons https://en.wikipedia.org/wiki/Bushel . synonym: bsh
Quintal: A mass unit equivalent to 100 kilograms - synonym: q
Square foot: An area unit which is equal to an area enclosed by a square with sides each 1 foot . synonym: ft2, sq. ft, sf.
gram per square meter: An area density unit which is equal to the mass of an object in grams divided by the surface area in meters squared. synonym: g/m2
gram per square foot: An area density unit which is equal to the mass of an object in grams divided by the surface area in feet squared. synonym: g/ft2
pound per acre: An area density unit which is equal to the mass of an object in pounds divided by the surface area in acres. synonym lb/ac
milliliter per square meter: A volume density unit? which is equal to the volume of an object in milliliters divided by the surface area in meters squared. synonym: mm/m2
liter per hectare: A volume density unit? unit which is equal to the volume of an object in liters divided by the surface area in hectares. synonym: l/ha
liter per acre: A volume density unit? unit which is equal to the volume of an object in liters divided by the surface area in acres. synonym: l/ac
liter per square meter: A volume density unit? unit which is equal to the volume of an object in liters divided by the surface area in meters squared. synonym: l/m2
liter per square foot: A volume density unit? unit which is equal to the volume of an object in liters divided by the surface area in feet squared. l/ft2
ton per acre: An area density unit which is equal to the mass of an object in tons divided by the surface area in acres. synonym: t/ac
pound per square foot: An area density unit which is equal to the mass of an object in pounds divided by the surface area in feet squared. synonym: lb/ft2
bushel per acre: An area density unit which is equal to the mass of an object in bushels divided by the surface area in acres. synonym: bsh/ac
quintal per acre: An area density unit which is equal to the mass of an object in quintals divided by the surface area in acres. synonym: q/ac
quintal per hectare: An area density unit which is equal to the mass of an object in quintals divided by the surface area in hectares. synonym: q/ha
ton per acre: An area density unit which is equal to the mass of an object in tons divided by the surface area in acres. t/ac
m3/ha

@marieALaporte

Hello,
We would need to have the terms above in our ontology soon. Do you think you will be able to add then in UO within two weeks? If it is not possible on your side, we will add them in AgrO and deprecate them once you add then in UO.
Thanks!

@krishnaTO can you make a PR for those? Thanks

Added PR for terms with following notes:
Terms already exist:

gram per square meter
ton per hectares

Terms are classes which define the conversion between prefixes, are they required as distinct classes?

gram per kilogram
microgram per gram


Phone Nova Field

For the packages that have Nova Resources for models that will now have a relationship with Phone (#58), I do not want to use the typical "BelongsTo" nova field (https://nova.laravel.com/docs/3.0/resources/relationships.html#belongsto) and instead would like to use a new Custom Nova Field that is similar to the Phone field I've been using:

https://github.com/dniccum/nova-phone-number

Let's call the field PhoneNumber and it should display the formatted phone number from the Phone model and be clickable using the Tel: HTML link. There should be a button next to it for "Change" if the User has edit Permissions and it will accept a new phone number and run a findOrCreate() on the model. There will also be a "View" button that takes you to the Nova Resource for the Phone.

Instead of other nova resources displaying just the relationship to Phone (#58), I would like for the data for the Phone model to be displayed similar to the Nova Field I've been using in all the other resources that have a phone string:
https://github.com/dniccum/nova-phone-number
The number should be callable by the Nova user and it should be formatted with the Country (#15) flag of the International Calling Code (#67) similar to the way we are creating the frontend field display in issue #73 and #75

This is done


Black Screen with Unnatural Hunger

I noticed that when I have Unnatural Hunger, the screen turns black. I can still hear things in the background (like Astral Sorcery stuff and mobs) but I can’t see anything. When I pause the game, the black screen stays.
I am using Optifine, though, so that could be an issue.
When I edited my player’s NBT data and removed the potion effect, the black screen went away. I also loaded a new world and had no issues.
This was using B26 hotfix and Forge <IP_ADDRESS>72. (And Optifine HD_U_E2, if that helps at all.)
I’m also using a whole bunch of other mods, but I don’t think any of them change any visual stuff.
I’m not 100% sure that Unnatural Hunger is the problem, but that’s what I got from my testing.

Optifine is almost 100% the issue.
I would recommend going into 'Performance' and deactivating 'Fast Render'

It is absolutely Optifine. As @VadersFist0501 said, deactivate "Fast Render" in Optifine's config or disable Thaumcraft's shaders.

Hmm, may be related to #1469
It looks like this with only TC and Baubles (no Optifine or other mods) installed if the render distance is set to 2...


Upgrade servant to >= 0.19

This PR upgrades servant to >= 0.19.
Reason: servant <= 0.18 is not compatible with aeson >= 2.0.

Hi @sorki, can you please help to review and merge this simple PR?
Thanks!

Hi, thanks! I'll adjust this to >= 0.18 && < 0.20 and possibly add few more bounds. I think we need to allow 0.18 as not all of the servant ecosystem updated to allow 0.19.

Hi, thanks! I'll adjust this to >= 0.18 && < 0.20 and possibly add few more bounds. I think we need to allow 0.18 as not all of the servant ecosystem updated to allow 0.19.

That makes sense. Thank you.


Fix disabled state for debug toolbar icons

This PR fixes ##149075

I initially tried that but noted that it was practically invisible on many themes. Bumping it up a bit seemed like a good compromise for the moment.


[cosmos] mypy: function has duplicate type signatures

There are duplicate type signatures present in these 2 functions which prevents mypy from continuing to run checks:
https://github.com/Azure/azure-sdk-for-python/blob/c247151acbb19591444144ca723c723cabfd45a6/sdk/cosmos/azure-cosmos/azure/cosmos/aio/container.py#L659-L665
and
https://github.com/Azure/azure-sdk-for-python/blob/c247151acbb19591444144ca723c723cabfd45a6/sdk/cosmos/azure-cosmos/azure/cosmos/aio/container.py#L688-L694
This prevents customers from getting typing information from the package.
This is reproducible by running mypy==0.931 at the package level directory:
azure-sdk-for-python\sdk\cosmos\azure-cosmos>python -m mypy ./azure
azure\cosmos\aio\container.py:659: error: Function has duplicate type signatures
azure\cosmos\aio\container.py:688: error: Function has duplicate type signatures
Found 2 errors in 1 file (errors prevented further checking)

Closing issue with PR above, thanks for pointing this out :)


Total count for confirmerd case in tabe is same as total active cases -observation on 26 march 7.45 am

total active cases -observation on 26 march 7.45 am..which is 602 while confimed cases should be 657..thanks

Leave issue on https://github.com/covid19india/covid19india-react


Keep cursor position after text updates when possible.

Before this, when inserting text in between existing characters, the cursor would jump back to the end, making it hard to type in text in the middle.

PS: Maybe as well have a new release after this fix? Running off a production app with dependencies directly from my own fork is not elegant 😢.

Strange. That didn't happen for me. Thanks for your contribution!

https://github.com/kenmueller/TextView/releases/tag/v1.4.5

This caused a bit of a regression which I've fixed here https://github.com/kenmueller/TextView/pull/22

Hm, @laosb I think there might be more cases where it's not safe to reset the text. For instance after I enter a single character, the cursor jumps to before the character:

Whereas that doesn't happen if I comment out this code.
I'm curious when this fix works for you and how else we might try to work toward that. Perhaps in the meantime too we should roll back this fix?

@wearhere I've done a before-after test, and this change does done something for me. I see this bug you described, and I should do more research on this in following days. For now I agree to roll back since this seems causing more problems.

Cool, I leave the call up to @kenmueller since I'm not yet using this library in production and this sort of bug is fine for testing. Also I personally don't mind using a fork if I have to.
As far as a new fix for this, I haven't tested https://gist.github.com/benjaminsnorris/710d22ef066ae249156f7f959be7debe but that looks intriguing.


ParticleProcessMaterial ignores the value set for 'particle_flag_damping_as_friction'

Godot version
v4.2.beta3.official [e8d57afae]
System information
Godot v4.2.beta3 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 960 (NVIDIA; <IP_ADDRESS>23) - Intel(R) Core(TM) i5-4690 CPU @ 3.50GHz (4 Threads)
Issue description
ParticleProcessMaterial will always generate a shader that uses the realistic friction formula for damping, wheter 'particle_flag_damping_as_friction' has been enabled or not.
It's pretty safe to assume that the bug got introduced with #79527.
Additionally, the check for that very flag seems to be inverted: https://github.com/godotengine/godot/blob/09946f79bd8215b2c6332de8821737580909a91c/scene/resources/particle_process_material.cpp#L961
Steps to reproduce

Create a GPUParticles3D node.
Assign a new ParticleProcessMaterial to 'process_material'.
Convert the ParticleProcessMaterial to a ShaderMaterial
Open the shader and go to line 300 to see the "realistic friction" code, which shouldn't have been generated, as 'particle_flag_damping_as_friction' is disabled by default.

Minimal reproduction project
N/A

CC @QbieShay

Regression from https://github.com/godotengine/godot/pull/83831/files

I don't think #84028 closes this issue.
Sorry, I probably wasn't very clear in my report, but the else-branch never gets taken, resulting in the same shader being generated, no matter the value set for 'particle_flag_damping_as_friction'.
I think I should have opened 2 separate issues.
particle_flag_damping_as_friction = false

particle_flag_damping_as_friction = true

I also opened https://github.com/godotengine/godot/pull/84029
Could you verify if it changes by reloading the scene?

Reloading the scene and then converting the it into a ShaderMaterial will still result in identical code, albeit the opposite branch:

Then the two PR i created yesterday should address this issue :+1:


[MM 11504] Refactor scroll logic

Summary
Refactor scroll logic. Remove few deprecated methods
Ticket Link
MM-11504
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Has UI changes

this PR needs to be rebased when https://github.com/mattermost/mattermost-webapp/pull/1464 goes in

I could clean up scroll emits logic because of postmeta data webapp PR, lets keep this PR on hold for review till we can review that PR

Closing this. We can revisit this based on changes for infinite scrolling

@sudheerDev is this PR still valid?

@enahum Yes we would need this as the post_list is refactored. let me close this as we have a ticket we can reopen when we get to here.