Add PR auto-merging ability

This allow specifying to the client that the pull request created can be merged if CI builds succeed.
When supported, this have two advantages:

Reduce complexity and load with webhook events;
The client may provide an interface to cancel auto-merging to the user.

Currently only supported by GitLab.
Let me know what do you think about this, thanks!

@connorshea No, I didn't test this for the case where the user dependabot is running as doesn’t have merge permissions.
The whole script/tool admit the permissions provided by the user are sufficient when enabling such option (disabled by default).

I’m wondering if the merge request still gets created

Of course, the "auto-merge" request is a separate one, submitted to GitLab after the MR creation.

Thanks for this @LeoColomb, but for now I don't think it's right for dependabot-core. Would you be happy to put it in dependabot-script, instead, conditional on an environment variable?
(I'm not sure how Dependabot will handle automerging when we add GitLab support to the main backend, and it might be using GitLab's automerge feature or might be something else (so we can allow other conditions).)

but for now I don't think it's right for dependabot-core

Sure, I understand, no problem. 🙂

Would you be happy to put it in dependabot-script

Yes, I can, but the only thing that bothers me is the explicit requirement of gitlab lib into the script (it's ok for me but can be annoying for others?).


implement fallbacks

If no publisher is connected it should be possible to loop a file to the same HSL channel.
Is there already a way to do this?

👍  this is exactly what I need right now. Any ideas?
The way I'd solve it without support, is by setting up my own listeners to always stream the same video on a loop if there's nothing being pushed. So I'd fake publish myself. I'd obviously prefer a method to supply it as described by @sebseb7

@RWOverdijk : And how exactly do you do this?

@jhedtmann It's part of the encoder used. If there's no input, it produces it's own input.

Would love to see this added — or if someone can suggest an alternative RTMP server that can do this.
Thanks.

so..... how is it going?

This has been a while. Is there any progress on this or another clever way to have fallbacks? I would think that this must be a common requirement for anybody streaming 24/7/365, unless you've got the cash to have people working shifts...


Fix fix prepared statement with partial arguments prepared

What problem does this PR solve?
We should record the placehold id map to both real Expr and the slot of conjuncts.Otherwise the info is lost, and lead to the conjuncts updated in wrong order(updateScanNodeConjuncts)
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall


Discard cluster events from the queue on cluster delete

If we delete a cluster we can discard all the events preceding to the deletion of the cluster

Coverage decreased (-0.05%) to 8.986% when pulling 83760ebbef5c1954a11155cf62c56588dd872d1a on clean-cluster-queue into c557027e12136cd70f9e825cacaa1170521db2cf on master.

👍

👍


Error RPM Install: Failed dependencies.

Centos 6.4:
rpm -U mod-pagespeed-*.rpm
warning: mod-pagespeed-stable_current_x86_64.rpm: Header V4 DSA/SHA1 Signature, key ID 7fac5991: NOKEY
error: Failed dependencies:
at is needed by mod-pagespeed-stable-<IP_ADDRESS>-7251.x86_64
Version Apache:
httpd -v
Server version: Apache/2.2.15 (Unix)
Server built:   Oct 16 2014 14:48:21

Hi!
I have the same problem...
:/
J.

you're missing at http://linux.die.net/man/1/at
you need to install it with yum install at

I have CentOs server,
https://developers.google.com/speed/pagespeed/module/download?hl=es
sudo yum install at  # if you do not already have 'at' installed
sudo rpm -U mod-pagespeed-*.rpm
But, only can see an error,
<EMAIL_ADDRESS>[~]# rpm -U mod-pagespeed-*.rpm
warning:mod-pagespeed-stable_current_x86_64.rpm: Header V4 DSA/SHA1 Signature, ID password 7fac5991: NOKEY
error: Failed dependencies:
httpd >= 2.2 It is needed to mod-pagespeed-stable-<IP_ADDRESS>-7251.x86_64
<EMAIL_ADDRESS>[~]#

@JoshuaProvoste do you have apache installed? it looks like you're missing apache.
What version of centos are you running?

@crowell
=> CentOS release 6.7 (Final)
=> Server version: Apache/2.2.27 (Unix)
=> Server built:   May 16 2014 05:05:30
=> Cpanel::Easy::Apache v3.24.18 rev9999

@JoshuaProvoste
How did you install Apache?  PageSpeed is asking rpm what version is installed and is not seeing httpd >= 2.2.
What does rpm -qa | grep httpd give you?


Update React Native library version constant to v6.0.0

in gatsby-config.js:
REACT_NATIVE_VERSION: 'v6.0.0',

This notification probably isn't needed.

removed zap 👍


Failing to commit

Sometimes, the script is giving "nothing to commit" but I can't track down the Issue.. E.g. revisions 160 and 179 are having this behaviour

First thing I'll note: the {{ }} syntax is called 'transclusion' in the wikitext vernacular, and the pages they refer to are generally pages in the template namespace (you can also transclude other pages with the same syntax, but I won't get into that).
Without further details, it's difficult to tell definitively whether all the revisions where git refused to add were the template transclusion commits. I might have a try at running the script and seeing if it has problems on those specific revisions, but it's somewhat inconvenient that it does git operations for each revision.
What I've noticed with pandoc is that it will insert something like the following when a template is missing (with backtick triplets before and after the section, which I can't really show in a Github comment):
{=mediawiki}

{{Pandocs|spriterambug}}

This might just be an artifact of me running the script multiple times or possibly something else different with my environment.
Here's a list of revision I found adding the templates just from browsing wiki edits of one contributor who was adding the template transclusions: 166, 167, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184
When I run the script and just look at the file differences, I'm also getting some other odd things with those specific revision ids, so I'll probably need to look into that further too.


sota-client-cpp: GENIVI SOTA project in C++

Add Yocto/OE recipe for building GENIVI SOTA
project written in C++ with Boost C++ libraries.
Signed-off-by: Leon Anavi<EMAIL_ADDRESS>

Hi @cajun-rat,
The first commit adds Yocto/OE recipe for building SOTA Client ++ and the second commit ensures that bitbake builds the binary in Release mode.
Best regards,
Leon

Hi @leon-anavi
I built this yesterday but got pulled away before I managed to test it. We've got a product launch tomorrow, so I will hold off merging this until Friday :)

Hi @cajun-rat,
OK, take your time. In the mean time I will continue working on:

systemd service
building SOTA client C++ with -DBUILD_WITH_DBUS_GATEWAY=ON

Best regards,
Leon

Merged as dd5686ad0dfa28ef4c391addf184b2a0f99eda54
Review Score: 11/11


Remote memory disclosure

The code sends uninitialized stack memory dummy to remote hosts:
https://github.com/mixer/ftl-sdk/blob/d0c8469f66806b5ea738d607f7d2b000af8b1129/libftl/ingest.c#L56
Issue discovered through PVS Studio static analysis while building OBS Studio.

Closing as Mixer / FTL are now dead.


Enhance METdatadb to load the new SSIDX STAT line type from Stat-Analysis.

Describe the Enhancement
The pull request dtcenter/MET#1892 for issue dtcenter/MET#1788 adds a new STAT line type that is created by Stat-Analysis. The SSIDX line type is documented in the Stat-Analysis MET User's Guide chapter on the feature branch. After that PR is approved/merged, please see the develop branch instead.
Please ask @JohnHalleyGotway any questions about how to handle the data.
A sample data file is provided here:
ssidx_sample.tar.gz
One file with FCST_VAR = OBS_VAR = GO_INDEX.
One file with FCST_VAR = OBS_VAR = SS_INDEX.
Another option is CBS_INDEX but no example is provided here.
Note that strings in the header columns can get long. For example, MODEL = fcst model name, reference model name. By default, when multiple strings are encountered in the input, their unique values are written to the output as a comma-separated list.
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the enhancement down into sub-issues.
No sub-issues needed.
Relevant Deadlines
To be included in the coordinated METplus version 4.1.0 release.
Funding Source
Funded via the DTC AF project (2712221). See @michelleharrold.
Define the Metadata
Assignee

[x] Select engineer(s) or no engineer required: Venita
[x] Select scientist(s) or no scientist required: no scientist needed

Labels

[x] Select component(s)
[x] Select priority
[x] Select requestor(s)

Projects and Milestone

[x] Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
[x] Select Milestone as the next official version or Future Versions

Define Related Issue(s)
Consider the impact to the other METplus components.

[x] METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy
[x] Source issue in MET: dtcenter/MET#1788
[x] Related issue in METviewer to plot this data: dtcenter/METviewer#327

Enhancement Checklist
See the METplus Workflow for details.

[ ] Complete the issue definition above, including the Time Estimate and Funding Source.
[ ] Fork this repository or create a branch of develop.
Branch name: feature_<Issue Number>_<Description>
[ ] Complete the development and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into develop.
Pull request: feature <Issue Number> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

@michelleharrold and/or @hertneky can provide additional SSIDX test data after running it for the AF LIS project.

@JohnHalleyGotway @venitahagerty I have some sample CBS Index data on Kiowa:/d1/projects/AF/lis/metprd/stat_analysis
These were run by initialization, month (Dec, Jan, Feb), season (only winter)

Here are the files:
cbs_index_winter.stat.txt
cbs_index_january.stat.txt
I also added a new line type to the schema:
https://github.com/dtcenter/METviewer/blob/issue/327-SSIDX/sql/mv_mysql.sql
Venita, please keep in mind that we are discussing to increase the size  limit of the model column in stat_header table from 40 to 60 or 80 because of this line type. I will let you know.

The size of the 'model' column is increased to 80 chars


Helm chart installation times out and starts to consume huge amount of CPU

Bug description
After trying to install Superset on my local minikube k8s cluster I get the following:

chart installation times out or hangs up
a gunicorn process is spawned that along with the dockerd consumes huge amounts of CPU (16-core Ryzen 7950X)

How to reproduce the bug

helm upgrade --install superset superset/superset --namespace=mynamespace

Screenshots/recordings

Superset version
3.1.2
Python version
I don't know
Node version
I don't know
Browser
Not applicable
Additional context
No other Helm installation on the cluster causes such issues
Checklist

[X] I have searched Superset docs and Slack and didn't find a solution to my problem.
[X] I have searched the GitHub issue tracker and didn't find a similar bug report.
[X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

@margorczynski please add which version of the Helm chart you're running.

It should be the latest considering the command: @villebro

Update: Now the install fails as follows:

Update: After a repo update the Chart.yaml error dissapeared but still getting the timout:

From what I see in Kubernetes the  superset-init-db job constantly spawns failing pods that fail with the following:

I didn't see any config value to set the secret in the Helm chart. And if it would be required shouldn't the install fail because of a missing parameter?

After running the install with values that override SECRET_KEY it install correctly. So it looks like I misunderstood the guide. But still it says: Default security settings and passwords are included but you SHOULD override those with your own, in particular: but it seems SHOULD should be replace by MUST for it to work.
Maybe an explicit mention before the helm install command? Or is it possible to generate it automatically and put it into Kubernetes secrets?
Still, after it install and 10 minutes pass I still see a sharp increase in resource usage and Kubernetes becomes unresponsive:

I will try to play around with the settings of minikube and Docker as there might be some issue there on my side but other charts like MinIO or Grafana didn't cause such problems


process multiple files in parallel

something similar to the way jscodeshift works (create multiple child processes and run transforms in parallel).
this should speed things up drastically when processing large codebases.
PS: this is a very good candidate for a dedicated project, maybe there is something on npm that we can reuse.

Fyi, you can use xargs -n 50 -p 8 to run the command on 8 cores using 50 files at a time.
find src -name '*.js' | xargs -n 50 -p 8 esformatter

see also: https://www.npmjs.com/package/worker-farm

@vjeux I'm probably wrong as it's not my best field but I've read "find -exec" is safer than "find + xargs". Feel free to search or just ignore me :P

@nmaxcom yeahh, if you have files with quotes or spaces, then you are going to be screwed. But if someone is able to create arbitrary named files on your file system, you are dead anyway, they can just change any js file and run arbitrary code.


fix: Allow ArgoCD CR to override keycloak resource request/limit defaults

What type of PR is this?

/kind bug

What does this PR do / why we need it:
Allow ArgoCD CR to override keycloak resource request/limit defaults
How to test changes / Special notes to the reviewer:

Run/Install the operator
Create ArgoCD instance with Keycloak (.spec.sso.provider = keycloak)
Update the SSO resource request/limit
Verify the changes

@iam-veeramalla please look at the failed tests.

@iam-veeramalla please look at the failed tests.

@wtam2018 on it. I have to refactor the code slightly fix the failing test. I will verify the new changes and raise a new PR


how and when is the raft log cleared?

how and when is the raft log cleared?

how can i use Tan raft log feature now?
can u update the ondisk example to use Tan?

i think tan is a great idea but not sure how to clear raft log or set expiry etc.

Please read the docs. it is clearly explained in the docs.


Fix issue 19823 - std.range.dropOne doesn't drop the element when cal…

…led after std.algorithm.iteration.filter

dropOne should error if there's no element. If this is not wanted, you can use .drop(1)

@wilzbach, Thanks.
If used drop(1), the issue still exists. This issue can be solved by using popFrontN(1), which I tested is normal when there are no elements.

@wilzbach

dropOne should error if there's no element.

That's not quite true. If there are no elements, dropOne should never be called on the range in the first place, because that means calling front on an empty range. Many ranges do assert in front that the range is not empty, but it's not required, and that goes away with -release. The behavior of calling front on an empty range is unspecified. Rather, it's up to the caller to never do that, and it's a bug in the caller if they do. It might then be caught by an assertion, but it might not. Either way, the bug is in the caller.
In any case, this change is clearly wrong. The documentation is quite clear that calling dropOne) is equivalent to calling popFront() and returning the range, not calling popFrontN(1), which checks empty and then only calls popFront() if there's an element to pop. If dropOne is being called on an empty range, then the bug is definitely in the caller. If it's not being called on an empty range, and calling dropOne and drop(1) aren't equivalent, then something else is going wrong.
@shove70 Using drop(1) in your example makes the code work.
import std.range: drop;
import std.stdio: writefln;
import std.algorithm.iteration: filter;
import std.array: array;

void main()
{
    auto a = [1,2,3,4];
    writefln("%s", a.filter!(a => a != 1).drop(1));
    writefln("%s", a.filter!(a => a != 2).drop(1));
    writefln("%s", a.filter!(a => a != 3).drop(1));
    writefln("%s", a.filter!(a => a != 4).drop(1));
    writefln("%s", a.filter!(a => a == 1).drop(1));
    writefln("%s", a.filter!(a => a == 2).drop(1));
    writefln("%s", a.filter!(a => a == 3).drop(1));
    writefln("%s", a.filter!(a => a == 4).drop(1));
    writefln("%s", a.filter!(a => a != 1).array.drop(1));
}

prints the correct thing.  So, there is no problem with drop, and if you used drop in your code, you'd be fine. However, there clearly is a problem with dropOne. If I reduce the tests down to
void main()
{
    import std.algorithm.comparison : equal;
    import std.algorithm.iteration : filter;
    import std.range : drop;

    auto arr = [1, 2, 3, 4];
    auto a = [1,2,3,4];

    auto result = a.filter!(a => a != 1)();
    assert(result.save.equal([2, 3, 4]));
    assert(result.drop(1).equal([3, 4]));
}

that passes, because it uses drop(1). If I then change it to use dropOne instead
void main()
{
    import std.algorithm.comparison : equal;
    import std.algorithm.iteration : filter;
    import std.range : dropOne;

    auto arr = [1, 2, 3, 4];
    auto a = [1,2,3,4];

    auto result = a.filter!(a => a != 1)();
    assert(result.save.equal([2, 3, 4]));
    assert(result.dropOne().equal([3, 4]));
}

then the second assertion fails, still indicating a problem with dropOne. However, if I then factor out dropOne entirely, and just use popFront directly
void main()
{
    import std.algorithm.comparison : equal;
    import std.algorithm.iteration : filter;

    auto arr = [1, 2, 3, 4];
    auto a = [1,2,3,4];

    auto result = a.filter!(a => a != 1)();
    assert(result.save.equal([2, 3, 4]));
    result.popFront();
    assert(result.equal([3, 4]));
}

the second assertion still fails. This indicates that dropOne isn't the problem at all. Rather, it looks like the problem is either with Filter's popFront, or the compiler is generating wrong code. I don't have time to dig into this any further at the moment, but if you want to fix this bug, then you'll need to make this reduced example work. Once that's fixed, dropOne should then work just fine.
As an aside, even if your fix here were correct, the tests shouldn't be generating strings, because it's not necessary to reproduce the bug. Printing out the results like you did in the bug report is useful for seeing what's happening, but unless converting the ranges to strings is required for reproducing the bug, there's no reason to do all of that string formatting in the tests.

@jmdavis, Thank you very much!
The essence of the problem is indeed filter() and struct FilterResult. Simply fixing the dropOne() to solve the issue is indeed too sloppy, sorry.
I will carefully analyze the problem of struct FilterResult and fix it.
Also, for your last suggestion, I also feel very helpful to me, thank you.
My intention is to completely cover the usage scenarios in the bug report in tests. The writefln("%s"... of the bug report is converted to a string by calling format(). Of course this is just my original Thought, I very much agree with your suggestion, I will not perform string conversion operation in the resubmitted PR.

@jmdavis, Due to my mistake, I closed this PR by mistake. The new PR is:
https://github.com/dlang/phobos/pull/7072


OptiFine changing color and textures of leaves

This image shows an issue with certain resource packs using OptiFine (A Little Taste of Jerm V2.5 on picture).
OptiFine can render leaves with different textures depending on the biome.
The actual block color (from getBlockColors()) or texture (from getSprite()) does not seem change.
This probably means the only way to fix this is by reproducing how OptiFine remaps textures.
Maybe looking at Colormatic can help

Colormatic supports loading resource packs with Optifine custom colors files as-is.
Features include: Biome colormaps for water, foliage, underwater, underlava, sky, and fog (...)

though it does not say anything about textures and the colors might not be an issue at all.

Got it to work specifically for the birch leaves from A Little Taste of Jerm V2.5.
Still needs a way to list all custom texture mappings and texture caching also needs to change.

Got it to work specifically for the birch leaves from A Little Taste of Jerm V2.5.
Still needs a way to list all custom texture mappings and texture caching also needs to change.

Looking at the documentation, this is ridiculously complex.
There are multiple matching rules: matchTiles, matchBlocks and matching through the filename as a fallback.

Multiple .properties file can refer to the same block/tile and they will be processed in alphabetical order by filename.

There are "shortcuts", e.g. writing oak_leaves instead of minecraft:oak_leaves, writing 1-4 for tiles 1 2 3 4.
matchBlocks can have attached properties (e.g. minecraft:oak_stairs:facing=east,west:half=bottom).
tiles, which specifies the replacement tiles, has 7 different formats just because.
Of course we only need to support a subset of this (full block texture replacements), but it also needs to not fail on all other cases.

Looking at the documentation, this is ridiculously complex.
There are multiple matching rules: matchTiles, matchBlocks and matching through the filename as a fallback.

Multiple .properties file can refer to the same block/tile and they will be processed in alphabetical order by filename.

There are "shortcuts", e.g. writing oak_leaves instead of minecraft:oak_leaves, writing 1-4 for tiles 1 2 3 4.
matchBlocks can have attached properties (e.g. minecraft:oak_stairs:facing=east,west:half=bottom).
tiles, which specifies the replacement tiles, has 7 different formats just because.
Of course we only need to support a subset of this (full block texture replacements), but it also needs to not fail on all other cases.

The ctm branch is feeling pretty mature now.
It can detect when OptiFine's Connected Textures are enabled/disabled and it correctly maps biome+block id to the remapped texture - at least for A Little Taste of Jerm V2.5 where I tested Birch Leaves in Jungle biome.
There's still a lot of open questions and it needs more testing on different resource packs.

The ctm branch is feeling pretty mature now.
It can detect when OptiFine's Connected Textures are enabled/disabled and it correctly maps biome+block id to the remapped texture - at least for A Little Taste of Jerm V2.5 where I tested Birch Leaves in Jungle biome.
There's still a lot of open questions and it needs more testing on different resource packs.

It's not just Connected Textures, Custom Colors affect leaf colors as well.
The Swamp Colors option also changes the given color if turned off - though that seems to only be an optimization, so no need to support it.

It's not just Connected Textures, Custom Colors affect leaf colors as well.
The Swamp Colors option also changes the given color if turned off - though that seems to only be an optimization, so no need to support it.

The ConnectedTexturesMod for Fabric has a very helpful description.
Apparently there are two different formats for Connected Textures:

The OptiFine/MCPatcher format (where "CTM" stands for Connected Texture Map/Mapping)
The ConnectedTexturesMod format

ConnectedTexturesMod for Fabric is obviously for the latter; for the first, there's Connected Block Textures.
As mentioned previously, there's also Colormatic for OptiFine/MCPatcher's Custom Colors.
I'm not sure if any of those 3 mods are compatible with the way we detect colors (TODO: test), but if they are and it's just OptiFine that's incompatible, it's probably not worth supporting it, seeing all the effort that's being done to replace every aspect of OptiFine.
The mods are all GPL licensed, so it's not as easy as getting inspired by their code, but maybe there is/will be an API we could use.

Ported the old code with some adjustments onto the ctm2 branch and made a test release.
BetterVanillaBuilding seems like a good pack to test on.
Maybe shipping the code and fixing the errors that pop up will turn it into something usable.
Though probably not over the holidays.


RabbitMQ host secret password cannot contain '#' character

Report
RabbitMQ password cannot contain # character.
Expected Behavior
Password should be able to contain all characters supported by RabbitMQ
Actual Behavior
The Keda scaledobject fails connecting to RabbitMQ
Steps to Reproduce the Problem

Create a RabbitMQ user: monitor:password#20
Create a ScaledObject using an TriggerAuthentication and Secret
Trigger the autoscaling

# Source: forwarder/templates/scaler-object.yml
apiVersion: v1
kind: Secret
metadata:
  name: keda-rabbitmq-secret
data:
  host: YW1xcDovL21vbml0b3I6cGFzc3dvcmQjMjBAcmFiYml0bXEucmFiYml0bXEuc3ZjLmNsdXN0ZXIubG9jYWw6NTY3Mi8= # amqp://monitor:password#20@rabbitmq.rabbitmq.svc.cluster.local:5672/
---
# Source: forwarder/templates/scaler-object.yml
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: rabbitmq-scaledobject-parser
  namespace: biot
spec:
  scaleTargetRef:
    name: consumer-service
  pollingInterval:  30   # Optional. Default: 30 seconds
  cooldownPeriod:   10   # Optional. Default: 300 seconds
  idleReplicaCount: 0    # Optional. Must be less than minReplicaCount
  minReplicaCount:  0    # Optional. Default: 0
  maxReplicaCount:  10   # Optional. Default: 100
  fallback:              # Optional. Section to specify fallback options
    failureThreshold: 3  # Mandatory if fallback section is included
    replicas: 3          # Mandatory if fallback section is included
  triggers:
  - type: rabbitmq
    metadata:
      protocol: amqp
      queueName: gateway
      mode: QueueLength
      value: "1"
    authenticationRef:
      name: keda-trigger-auth-rabbitmq-conn
---
# Source: forwarder/templates/scaler-object.yml
apiVersion: keda.sh/v1alpha1
kind: TriggerAuthentication
metadata:
  name: keda-trigger-auth-rabbitmq-conn
  namespace: biot
spec:
  secretTargetRef:
    - parameter: host
      name: keda-rabbitmq-secret
      key: host

Logs from KEDA operator
2021-11-15T14:57:19.579Z ERROR scalehandler Error getting scalers
{
	"object": {
		"apiVersion": "keda.sh/v1alpha1",
		"kind": "ScaledObject",
		"namespace": "biot",
		"name": "rabbitmq-scaledobject-parser"
	},
	"error": "error getting scaler for trigger #0: error establishing rabbitmq connection: parse \"amqp://monitor:password\": invalid port \":password\" after host"
}

KEDA Version
2.4.0
Kubernetes Version
1.22
Platform
Microsoft Azure
Scaler Details
RabbitMQ
Anything else?
No response

I think that's coming directly from the underlying RabbitMQ library so this may need to be raised upstream.

Hi @mbendtsen ,
@coderanger is right, the error comes directly from streadway/amqp library. More in depth, the error probably is raised here https://github.com/streadway/amqp/blob/master/uri.go#L62.
The problem is that url.Parse(uri) doesn't support special characters, and that's why the error is raised. Maybe we could parse the connection string in "our side" using a regex or something like that, then escape the values and generate the connection string but IMHO that is totally overkill.
Saying the truth, we have the same issue in http protocol for the same reason, but using a password without a special character seems the best option.
WDYT @coderanger, @zroubalik  ?

I think we just need to accept this as a limitation of Go URL parsing and call it a known issue. Trying to work around it is probably going to do more harm than good given how deep this is in Go's stdlib.

Agree, I don't think this is something we should cover in KEDA.

I think the best outcome is that we document this on https://keda.sh/docs/latest/faq/ as a known limitation.
Are you willing to contribute this @mbendtsen ?

I can try :)
Is this a general issue for all connection strings or only RabbitMQ amqp? If it is only applicable for RabbitMQ scaler, should it then be documented here: https://keda.sh/docs/2.4/scalers/rabbitmq-queue/

At least, it happens in RabbitMQ Scaler because I tried with http protocol and the problem is there too

Sorry,
using one of these functions https://www.callicoder.com/golang-url-encoding-decoding/
before passing URI to streadway could resolve the problem?


README updates and another smirff99Frosst move

I updated the main repository README to reflect the change to merge smarty and elemental_smarty.
I also copied the current version of smirff99Frosst into the smarty/data/forcefield/ directory I'm going to make myself a checklist of everywhere a new smirff99Frosst needs to go when changes are approved.

@davidlmobley updated

This pull request doesn't change anything being tested.


Fix: Require and run friendsofphp/php-cs-fixer on Travis

This PR

[x] requires and runs friendsofphp/php-cs-fixer on Travis

Hey. I completely get your point but I removed php-cs-fixer as a dependency because travis failed on PHP nightly several times. So I went same way as using composer. I installed it globally.
https://github.com/FriendsOfPHP/PHP-CS-Fixer#globally-manual
In this case the lib will not break in travis because php-cs-fixer is not required anymore

@DjThossi
How about 0a2b7b01ae4b141c8942b6872599290ef38112e5, then?

I really like your way of thinking. I'd love to see travis running it again. So would you be so kind and solve the conflict please?
But my guess is that it would not solve the problem of php-cs-fixer breaking because usual issue is that php-cs-fixer has some wired setup of required php version inside comopser.json which can't be resolved properly for php nightly. Do you see a way in travis.yml to just run something like compser require friendsofphp/php-cs-fixer only in case of php version 5.6? In this way we could keep php-cs-fixer completely out of the composer.json

@DjThossi
Resolved!

This solution looks perfect. Thank you.

Thank you, @DjThossi!


fix(versions): update Activiti/example-runtime-bundle versions into master

UpdateBot pushed maven dependency: org.activiti.cloud.rb:activiti-cloud-runtime-bundle-dependencies to: 7.1.150

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.rb:activiti-cloud-runtime-bundle-dependencies 7.1.150


the error remains

the error remains

Thank you for reporting the bug.
I need more information.
Please tell me the language setting of your computer, the version of Windows, and the latest exception log output.  (The folder with the exception log is in the directory where the exe file exists.)


Traefik dashboard returns 404 for rules that contain / character in their names

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?

Load the following config

http:
  routers:
    "GET /dump/request":
      entryPoints:
        - internet
      service: httpbingo
      rule: >-
        Method(`GET`) &&
        Host(`localhost`) &&
        Path(`/dump/request`)
    get-headers:
      entryPoints:
        - internet
      service: httpbingo
      rule: >-
        Method(`GET`) &&
        Host(`localhost`) &&
        Path(`/headers`)
  services:
    httpbingo:
      loadBalancer:
        servers:
          - url: https://httpbingo.org
        passHostHeader: false

Go to http://localhost:8080/dashboard/#/http/routers

Click on the rule named GET /dump/request@file (browser URL: http://localhost:8080/dashboard/#/http/routers/GET /dump/request@file) -> 404

Go back and select get-headers@file rule (browser URL: http://localhost:8080/dashboard/#/http/routers/get-headers@file) -> 200

What did you see instead?
404 from the dashboard
What version of Traefik are you using?
$ docker run traefik version
Version:      2.10.5
Codename:     saintmarcelin
Go version:   go1.21.3
Built:        2023-10-11T13:54:02Z
OS/Arch:      linux/arm64

What is your environment & configuration?
Configuration files:

traefik.yml

global:
  checkNewVersion: true
  sendAnonymousUsage: false
entryPoints:
  internet:
    address: :80
log:
  level: DEBUG
accessLog:
  format: common
api:
  insecure: true
  dashboard: true
ping:
  entryPoint: traefik
providers:
  file:
    filename: /etc/traefik/dynamic/dev.yml
    watch: true

dev.yaml

http:
  routers:
    "GET /dump/request":
      entryPoints:
        - internet
      service: httpbingo
      rule: >-
        Method(`GET`) &&
        Host(`localhost`) &&
        Path(`/dump/request`)
    get-headers:
      entryPoints:
        - internet
      service: httpbingo
      rule: >-
        Method(`GET`) &&
        Host(`localhost`) &&
        Path(`/headers`)
  services:
    httpbingo:
      loadBalancer:
        servers:
          - url: https://httpbingo.org
        passHostHeader: false

Start Treafik using the following command:
$ docker run -p 8080:8080 -p 80:80 -v "${PWD}/traefik.yml:/etc/traefik/traefik.yml" -v "${PWD}/dev.yml:/etc/traefik/dynamic/dev.yml" traefik:v2.10.5

Both routes work correctly, it's just a dashboard glitch:
$ curl http://localhost/dump/request -SsD -
HTTP/1.1 200 OK
Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: *
Content-Type: text/plain; charset=utf-8
Date: Wed, 18 Oct 2023 16:19:37 GMT
Fly-Request-Id: 01HD1SBQHMC2PTQ5MCXJEC9F1E-waw
Server: Fly/55f8eaa0 (2023-10-09)
Via: 2 fly.io
Transfer-Encoding: chunked

GET /dump/request HTTP/1.1
Host: httpbingo.org
Accept: */*
Accept-Encoding: gzip
Fly-Client-Ip: <IP_ADDRESS>
Fly-Forwarded-Port: 443
Fly-Forwarded-Proto: https
Fly-Forwarded-Ssl: on
Fly-Region: waw
Fly-Request-Id: 01HD1SBQHMC2PTQ5MCXJEC9F1E-waw
Fly-Traceparent: 00-a7cfe0633bf7f20cba25035e47572c92-2e8804282daae6e2-00
Fly-Tracestate:
User-Agent: curl/8.4.0
Via: 2 fly.io
X-Forwarded-For: <IP_ADDRESS>, <IP_ADDRESS>
X-Forwarded-Host: localhost
X-Forwarded-Port: 80
X-Forwarded-Proto: http
X-Forwarded-Server: c03f3f6cfe87
X-Forwarded-Ssl: on
X-Real-Ip: <IP_ADDRESS>
X-Request-Start: t=1697645977140856

$ curl http://localhost/headers -SsD -
HTTP/1.1 200 OK
Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: *
Content-Type: application/json; charset=utf-8
Date: Wed, 18 Oct 2023 16:19:41 GMT
Fly-Request-Id: 01HD1SBVSQDSN7WA7FAAMAN282-waw
Server: Fly/55f8eaa0 (2023-10-09)
Via: 2 fly.io
Transfer-Encoding: chunked

{
  "headers": {
    "Accept": [
      "*/*"
    ],
    "Accept-Encoding": [
      "gzip"
    ],
    "Host": [
      "httpbingo.org"
    ],
    "User-Agent": [
      "curl/8.4.0"
    ],
    "Via": [
      "2 fly.io"
    ],
    "X-Forwarded-For": [
      "<IP_ADDRESS>, <IP_ADDRESS>"
    ],
    "X-Forwarded-Host": [
      "localhost"
    ],
    "X-Forwarded-Port": [
      "80"
    ],
    "X-Forwarded-Proto": [
      "http"
    ],
    "X-Forwarded-Server": [
      "c03f3f6cfe87"
    ],
    "X-Forwarded-Ssl": [
      "on"
    ],
    "X-Real-Ip": [
      "<IP_ADDRESS>"
    ],
    "X-Request-Start": [
      "t=1697645981495814"
    ]
  }
}

If applicable, please paste the log output in DEBUG level
N/A

Are you serious about naming your router "GET /dump/request"? All examples show only standard A-Za-z0-9 and - (Doc). No space or other characters. Next you want unicode smiley support in router names? 🤔

Yes, I'm dead serious here :) "GET /dump/request": is a perfectly valid YAML key and Treafik did load aforementioned dev.yaml file without any issues (at least from HTTP routing perspective everything works fine).
If certain characters are not allowed I'd expect at least a log message.

Hey @jwadolowski,
Thanks for the bug report.
We would love community support to address it.
If you or another community member would like to build it, let us know and we will work with you to make sure you have all the information needed so that it can be merged.

@andsarr Thanks for your inputs.
The first approach has the benefit of fixing the root cause of the issue. But to be consistent and making things easy to understand this rule should also be enforced on other resources (services, middlewares, ...). Unfortunately, this would be a breaking change.
The second option, as you noticed, wouldn't work since each time the dynamic config is reloaded, you would end up with new IDs for your routers. Which would lead to 404 on already opened pages of the dashboard.
I would like to propose a third option, which is simpler and backward compatible. URL encode in the UI, URL decode in the API.

Hi @nmengin!
I think that this be closed.

Hey @andsarr,
Thank you for the feedback, I close it accordingly.


Mutation tests

I ran humbug and fixed what I can ;)

Closing due to lack of activity. If somebody wants to pick this up, please submit a new PR.

@weierophinney if this merge applied cleanly, it can be merged as-is.


Adding postal code/zip code representation

This is requested by the OBIB community.
Adding classes.
Add "identifier" from PNO (http://purl.obolibrary.org/obo/IAO_0020000)
Create "Postal code"
Superclass: identifier
Definition: "An identifier that denotes some postal delivery route, some aggregate of postal delivery routes or a geographical region and was created for the purpose of sorting and delivering mail."
Create "Postal delivery route"
Superclass: plan specification
Definition: "A plan specification that if realized, is realized by the delivery of mail to some facility or mailbox within some geographical region"
Create "zone improvement plan code"
alternative term "ZIP code"
Superclass: "postal code"
Definition: "A postal code that is used in the United States for the purpose of sorting and delivering mail, and that denotes some postal delivery route or some aggregate of postal delivery routes."

The terms look good to me.
If no objection in 2 weeks, I'd like to add the terms in IAO.

@mbrochhausen The label of PNO (http://purl.obolibrary.org/obo/IAO_0020000) is 'proper name'. Do you want to relabel the term in PNO or do you want to relabel it as 'identifier' in IAO?

If I open PNO from the PURL the label is 'identifier' and 'proper name' is an alternative term. Which version of PNO are you pulling? Thanks

Added in release 2020-06-09


fix missing reads when transforming fastq to adam

To fix #1393, don't double count the length of the readname line. In addition, to prevent the length of a line is longer than MAX_LINE_LENGTH in https://github.com/bigdatagenomics/adam/blob/master/adam-core/src/main/java/org/bdgenomics/adam/io/FastqRecordReader.java#L330

Can one of the admins verify this patch?

@A-Tsai thank you for the help on this issue!

Jenkins, test this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1805/
Test PASSed.

Thank you, @A-Tsai!


getInitialProps in children components

I have a use case when I have a page concerning some object, say a "Book". I use getInitialProps to load the book. On the book page I also have tabs to display some hasMany relationships like "Authors". The "Authors" tab is a child component of the "Book" page component and ideally I would like to only load authors once the tab is clicked and this child component is mounted.
Are there any plans to allow getInitialProps in child components? Is there a workaround to this issue I am not seeing?

Are there any plans to allow getInitialProps in child components? Is there a workaround to this issue I am not seeing?
TLDR is no. the long answer is described here: https://github.com/zeit/next.js/issues/192

In your case you can actually just use componentDidMount to do the fetching when the Authors component is loaded.

@timneutkens Thanks for the reference


Update pubsubhubbub.md

Fix code example of creating a \Zend\Feed\PubSubHubbub\Publisher - add a new keyword.
Provide a narrative description of what you are trying to accomplish:

[ ] Are you fixing a bug?

[ ] Detail how the bug is invoked currently.
[ ] Detail the original, incorrect behavior.
[ ] Detail the new, expected behavior.
[ ] Base your feature on the master branch, and submit against that branch.
[ ] Add a regression test that demonstrates the bug, and proves the fix.
[ ] Add a CHANGELOG.md entry for the fix.

[ ] Are you creating a new feature?

[ ] Why is the new feature needed? What purpose does it serve?
[ ] How will users use the new feature?
[ ] Base your feature on the develop branch, and submit against that branch.
[ ] Add only one feature per pull request; split multiple features over multiple pull requests
[ ] Add tests for the new feature.
[ ] Add documentation for the new feature.
[ ] Add a CHANGELOG.md entry for the new feature.

[ ] Is this related to quality assurance?

[x] Is this related to documentation?
Fix a typo when creating an instance of a \Zend\Feed\PubSubHubbub\Publisher class.

Thanks, @vansanblch!

Thanks, @vansanblch!

Thanks, @vansanblch!


Search does not handle collapse

When you collapse the parent of a hit from the search (marked with red border), the marked hit of the search is moved to another node which does not match the search.
Example:

Open the Demo https://fritz-c.github.io/react-sortable-tree/
Expand All
Search for the text: "Nested", and you get a hit on second child of "title"
Collapse the first node "title" and the hit is moved to "Chicken"

Indeed it does. Thank you for pointing this out, and I'll be working on it when I have some free time.

I looked into this this morning, and recalled a compromise I made that I should note here so I don't forget it again.
After searching, the matches array will provide paths and treeIndexes for each match.
Using the treeIndex to highlight matches:
In mid-drag, search is not performed on each update for (assumed) performance reasons. The result is that outlines "linger" on their old positions until the drop is performed.
Hidden nodes (such as the one in your report) have a null treeIndex, and are not highlighted.
Using the last key in the path to highlight matches (the existing method):
The outlines follow around the nodes in mid-drag (assuming you use some unique key other than treeIndex in getNodeKey)
When using the treeIndex in getNodeKey, hidden matches will result in broken highlighting.

Even without using drag and drop at all, just collapsing the parent node of a search match will cause the bug, another unrelated node being highlighted.


Validation ErrorTemplate Samples

Are there any samples of how to do validation and display validation errors?

First Im not related to this project. Now Im working in a little project and I have the same question some weeks ago.
For my app Im using ReactiveUI, my class inherit from ReactiveValidationObject because it set all the plumbing needed for validations. Properties are decorated with [Reactive] from ReactiveUI.Fody package, this ensure that every property notify on every value change. And the validations are set using this.ValidationRule( for each validation case.
    public sealed class SkaterProxy : ReactiveValidationObject // This implements INotifyDataErrorInfo and INotifyPropertyChanged
    {
        public SkaterProxy(Skater skater, TeamsViewModel teamsViewModel)
        {
            Entity = skater ?? throw new ArgumentNullException(nameof(skater));

            Teams = teamsViewModel.ProxyItems;

            InitializeProperties(skater);

            InitializeValidations();
        }

        public Skater Entity { get; }

        [Reactive] public int Number { get; set; }

        [Reactive] public string Name { get; set; } = null!;

        [Reactive] public string LastNames { get; set; } = null!;

        [Reactive] public string IdentificationNumber { get; set; } = null!;

        [Reactive] public Sex? Sex { get; set; }

        [Reactive] public Team Team { get; set; } = null!;

        [ObservableAsProperty] public DateTime BirthDate { get; }

        [ObservableAsProperty] public int Age { get; }

        public ReadOnlyObservableCollection<TeamProxy> Teams { get; }

        private void InitializeProperties(Skater skater)
        {
            Number = skater.Number;
            Name = skater.Name;
            LastNames = skater.LastNames;
            IdentificationNumber = skater.IdentificationNumber;
            Sex = skater.Sex;
            Team = skater.Team;
        }

        // Validations
        private void InitializeValidations()
        {
            // Name
            this.ValidationRule(viewModel => viewModel.Name,
                name => !string.IsNullOrWhiteSpace(name),
                "You must specify a valid name");

            // Lastname
            this.ValidationRule(viewModel => viewModel.LastNames,
                name => !string.IsNullOrWhiteSpace(name),
                "You must specify a valid lastname");

            this.ValidationRule(viewModel => viewModel.LastNames,
                name => name != null && name.Contains(" ", StringComparison.InvariantCulture),
                "You must specify both lastname");

            // Identification Number
            this.ValidationRule(viewModel => viewModel.IdentificationNumber,
                identificationNumber => identificationNumber is { Length: 11 },
                "Identification number must contain 11 positions");

            this.ValidationRule(viewModel => viewModel.IdentificationNumber,
                identificationNumber => identificationNumber.OnlyDigits(),
                "Identification number must contain only numbers");

            // Sex
            this.ValidationRule(viewModel => viewModel.Sex,
                sex => sex.HasValue,
                "You must provide a value for Sex");

            // Number
            this.ValidationRule(viewModel => viewModel.Number,
                number => number > 0,
                "The number must be higher than zero");

            // Team
            this.ValidationRule(viewmodel => viewmodel.Team,
                team => team != null,
                "Team is required");
        }
    }

This how validations look in the app...

Hope this help...

Does FluentAvalonia have any improvement in these regards compared to standard Avalonia?

DataValidationErrors is an Avalonia thing, with no WinUI counterpart so no I haven't touched anything with that other than making sure the red borderbrush has a correct resource for Fluent v2.
There is a built-in template for having it display as a ToolTip though, take a look at the template (the same exists here in FluentAvalonia). Just update the Template and ErrorTemplate properties to use the ToolTip templates. This can be used a reference if you want to further modify how it looks (say remove the icon and just use the red border, for example):
<Window.Styles>
      <Style Selector="DataValidationErrors">
          <Setter Property="Template" Value="{StaticResource TooltipDataValidationContentTemplate}" />
          <Setter Property="ErrorTemplate" Value="{StaticResource TooltipDataValidationErrorTemplate}" />
      </Style>
  </Window.Styles>

  <TextBox Text="Sample"
           HorizontalAlignment="Center"
           VerticalAlignment="Center">
      <DataValidationErrors.Error>
          <sys:Exception/>
      </DataValidationErrors.Error>
  </TextBox>

Which looks like:

OK so it's just standard Avalonia stuff; which remains undocumented so far. That will get looked into from the Avalonia side with the thread linked above.
Can close this thread unless FluentAvalonia plans to add anything to it.


error: unexpected character '\n' after patch version number

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
# deny.toml
[licenses]
allow-osi-fsf-free = "both"
copyleft = "deny"
allow = [
	"0BSD",
	"BSD-2-Clause",
	"CC0-1.0",
	"ISC",
	"LGPL-2.0",
	"MPL-2.0",
	"OpenSSL",
	"Unicode-DFS-2016",
]

% cargo-deny --log-level debug check
2023-08-01 20:58:50 [INFO] using config from /REDACTED/deny.toml
2023-08-01 20:58:50 [INFO] fetching crates for /REDACTED/Cargo.toml
2023-08-01 20:58:50 [DEBUG] loading license store...
2023-08-01 20:58:50 [INFO] No advisory database configured, falling back to default 'https://github.com/RustSec/advisory-db'
2023-08-01 20:58:50 [DEBUG] Fetching advisory database from 'https://github.com/RustSec/advisory-db'
2023-08-01 20:58:50 [DEBUG] starting new connection: https://github.com/
2023-08-01 20:58:50 [DEBUG] No cached session for DnsName("github.com")
2023-08-01 20:58:50 [DEBUG] Not resuming any session
2023-08-01 20:58:50 [DEBUG] Using ciphersuite TLS13_AES_128_GCM_SHA256
2023-08-01 20:58:50 [DEBUG] Not resuming
2023-08-01 20:58:50 [DEBUG] TLS1.3 encrypted extensions: [ServerNameAck, Protocols([ProtocolName(6832)])]
2023-08-01 20:58:50 [DEBUG] ALPN protocol is Some(b"h2")
2023-08-01 20:58:50 [INFO] fetched crates in 165.549082ms
2023-08-01 20:58:50 [INFO] gathering crates for /REDACTED/Cargo.toml
2023-08-01 20:58:50 [DEBUG] gathering crate metadata
2023-08-01 20:58:50 [DEBUG] loading advisory database from /home/REDACTED/.cargo/advisory-dbs/github.com-a946fc29ac602819
2023-08-01 20:58:50 [DEBUG] finished loading advisory database from /home/REDACTED/.cargo/advisory-dbs/github.com-a946fc29ac602819
2023-08-01 20:58:50 [DEBUG] gathered crate metadata in 207ms
2023-08-01 20:58:50 [ERROR] unexpected character '\n' after patch version number

Expected behavior
The check works.
Screenshots
If applicable, add screenshots to help explain your problem.
Device:

OS: Linux, NixOS

Ah, great job tracking that down. I am using cargo from NixOS. As a test I pulled the ubuntu:23.10  docker image and it seems to hit the same issue.
It also has the short version string so it seems likely that this is the common factor.
# cargo -V
cargo 1.70.0

The official Rust docker images don't seem to have this problem but they have the expanded version string:
% podman run -it rust:1.70.0-bullseye
root@6263ea194e2d:/# cargo -V
cargo 1.70.0 (ec8a8a0ca 2023-04-25)


Update README.md

Thanks again for your continued support to this project @bbortt! Merged and published the doc change as v4.0.2.


output nodes

Hi, I am trying the convert the model into frozen graph. But i could not found the output node names on the internet or the paper. Can you help me to find it?

@klnsz You can check the code for details

Found it. thank you

Are the input and output nodes the following?
input nodes = 'input_tensor', 'net_phase'
output nodes = 'lanenet_model/inference/decode/score_final/score_final', 'lanenet_model/pix_embedding_relu'

Found it. thank you

can you share your found results about the output nodes about lanenet for tensorflowslite's tflite

Found it. thank you

can you share your found results about the output nodes about lanenet for tensorflowslite's tflite

Load checkpoints into test_lanenet.py and inside the session, convert it into a frozen graph.
Save the graph as a .pb file.
Then you can try the following and see if it works:
input nodes = 'input_tensor'
output nodes = 'lanenet_model/pix_embedding_relu' (binary branch output);
'lanenet_model/ArgMax' (instance branch output to be used for clustering)

@klnsz I want to convert it to freeze_graph as well so I can change it to uff. Could you please let me know how you run freeze_graph?


Button should not be clicked when I'm selecting color of a button

Microsoft PowerToys version
0.68.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
ColorPicker
Steps to reproduce
Open color picker and try to get color of a button
✔ Expected Behavior
The events should not be trigger if I'm getting color of a button or a input element
I don't wanna click the element I just wan't to get the color. I don't care if the element is listening for a event or not
❌ Actual Behavior
The elements event is triggering
Other Software
No response

Note
To select the color of the non-hover state of a element:
Move the mouse pointer close, but not over the element
Zoom in by scrolling the mouse wheel up (image will be frozen)
In the enlarged area, you can pick the color of the element

https://learn.microsoft.com/windows/powertoys/color-picker#select-color

But that's not an ideal solution, Isn't it ?

I'll give you that. Looks like this was an issue that should've been fixed a while ago: #5195 CC: @martinchrzan

/dup #11924


DRAFT: Translate SystemClock.GetCurrentInstant() for NodaTime

Not ready for review.
TODO

Split xml docs and general refactorings into a separate PR.
Update test suite for SystemClock.GetCurentInstant()

Related
#502

Why is it a draft? I think it would be better to split the change to two commits:

Refactor the current API
Translate NodaTime SystemClock.GetCurrentInstant

@YohDeadfall That's the plan...but I needed the test suite to build against the CI servers.
Once everything is stable on my end, I'll open another PR for the aesthetics and force push over this one for the feature itself.

Ah, so. Then you can alter commits using soft reset and continue with the current request (:


RSC-[ABC]: Ensure data is encrypted at rest in GovCloud deployment

In order to comply with NIST 800-53 SC-*, the cloud.gov team should ensure that all data is encrypted at rest.
Acceptance Criteria

[ ] Make sure that all S3 buckets are encrypted
[ ] Make sure that all RDS instances are encrypted
[ ] Make sure that all EBS volumes are encrypted

Implementation Sketch

Check on what Diego wrote last weekend... How does it work?
Adapt existing script?
BOSH and Concourse RDS instances need to be encrypted...and recreated in the process. :(
Figure out why EBS volumes aren't being encrypted; they should be. Diego has an issue open with BOSH
Josh says BOSH is accepting a PR to encrypt log files as they're uploaded to S3 without shenanigans

@sharms says break this one up; will do shortly.

@dlapiduz is wrestling with this via cloudfoundry-incubator/bosh-aws-cpi-release#34

I split S3 and RDS out into their own issues.

@jmcarp and I are tackling these in tandem, and editing the comment above with links to the PR ☝.
When these changes are merged in, we can start ticking off boxes. So if you're merging in a PR, please tick off the box that it covers.


Add backend info to the settings page

In https://github.com/idpass/mimoto/issues/30 we are adding API endpoints to show us:

The version string of Mimoto
The URL/URI of the MOSIP server Mimoto is connected to

This issue is about making calls to these API:s from the "profile" page of Inji to add this information below the current version string like this:
newlogic-0.3.0-rc1 (current string – Inji APK version)
Mimoto: 1.2.0-SNAPSHOT
MOSIP: https://qa3.mosip.net

@kneckinator is this under developer settings?

@danicaerediano no, this is not the backend URL configuration; this is to add more info to the text at the bottom of the profile screen. I believe this requires something from the backend first right @uocnb? An endpoint we can query to check the version of MOSIP it's running.

@pmigueld yes, it's required a new backend API for this information.


Fixing Issue in IE mobile

When you call webStorage.setItem it fires off the 'storage' event handler.  This causes the _last$storage variable to be set during the forEach loop.  When the item is finally removed from webStorage the _last$storage variable will be incorrect.

@jlkalberer Thanks for your contribution, but this repo is not maintained by the owner anymore. Please find an alternative.


Fix bug https://github.com/geekan/MetaGPT/issues/1430 and also make some field in design api optional.

Features

fix https://github.com/geekan/MetaGPT/issues/1430
make some key in design_api_an.py optional,because from a few test run with non py projects. it seems to not have it. Could be reverted as MUST, if we can guarantee to make sure all relevant projects generate those design api.
same pr feature as https://github.com/geekan/MetaGPT/pull/1431 but implemented using latest git.(please merge this quick for low git conflict)

Feature Docs
Influence*
Let a lot of hard error become non error and continue to cook project.
Result
Other

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.29%. Comparing base (5446c7e) to head (a3eaa02).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1435      +/-   ##
==========================================
- Coverage   62.34%   62.29%   -0.06%
==========================================
  Files         283      283
  Lines       17371    17371
==========================================
- Hits        10830    10821       -9
- Misses       6541     6550       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LGTM


[vote] vote for 1.0.0 release

Signed-off-by: slievrly<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
[vote] vote for 1.0.0 release
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

@all please vote whether to release 1.0.0 based on the regression test results of 1.0.0-snapshot.

Codecov Report

Merging #2064 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2064      +/-   ##
=============================================
- Coverage      55.26%   55.26%   -0.01%
  Complexity      2524     2524
=============================================
  Files            446      446
  Lines          14927    14927
  Branches        1770     1770
=============================================
- Hits            8250     8249       -1
- Misses          5910     5911       +1
  Partials         767      767

Impacted Files
Coverage Δ
Complexity Δ

.../src/main/java/io/seata/core/protocol/Version.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...server/store/file/FileTransactionStoreManager.java
56.5% <0%> (-0.32%)
29% <0%> (-1%)

I vote for release GA.
Tested using develop branch code and springboot-mybatis sample.

I vote for release GA.

I vote for release GA.

I vote for release GA.

I support to  release the GA

I vote for release GA.


Pull changes from main

Codecov Report

Merging #10 (b003b4d) into fdb-0.2.x (cfe97b9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           fdb-0.2.x      #10   +/-   ##
==========================================
  Coverage      89.43%   89.43%
==========================================
  Files             17       17
  Lines           7655     7655
==========================================
  Hits            6846     6846
  Misses           809      809

Impacted Files
Coverage Δ

fdb/src/lib.rs
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfe97b9...b003b4d. Read the comment docs.


Migrate through API gives ``

Gitea Version
latest Docker image
Git Version
latest Docker image
Operating System
latest Docker image
How are you running Gitea?
latest Docker image
Database
PostgreSQL
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Description
When migrating a repository from Github with "pull_request": true. I get an error saying: MigrateRepository: 'PullRequests' not supported. When running the migration throug the UI everything goes as expected.
Data:
{
  "auth_password": "*********************",
  "auth_username": "username",
  "clone_addr": "https://github.com/my-org/my-repo",
  "private": true,
  "pull_requests": true,
  "releases": true,
  "repo_name": "my-repo",
  "repo_owner": "richard",
  "service": "git",
  "wiki": true
}

Logs:
2021/11/02 17:27:01 Started POST /api/v1/repos/migrate?token=******** for <IP_ADDRESS>:37090
2021/11/02 17:27:18 ...i/v1/repo/migrate.go:242:handleMigrateError() [E] MigrateRepository: 'PullRequests' not supported
2021/11/02 17:27:18 ...i/v1/repo/migrate.go:197:func1() [E] DeleteRepository: repository does not exist [id: 190, uid: 14, owner_name: , name: ]
2021/11/02 17:27:18 Completed POST /api/v1/repos/migrate?token=********  500 Internal Server Error in 17.6840749s

What is going wrong?
Screenshots
No response

{
"service": "github"
}

That made do 1 step forward. Thanks.
But it now gives the error:
{"message":"GET https://api.github.com/repos/my-org/my-reop: 404 Not Found []","url":"http://localhost:3000/api/swagger"}
Its a private repo but my PAT has access to it.
Any advise?

No difference if I change from auth_password to auth_token. The 404 error remains

Thanks. That fixed it.


test: use static functions rather than static data for std::string constants for config fragments

Signed-off-by: Joshua Marantz<EMAIL_ADDRESS>For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

/azp run envoy-linux

OK it's ready now. There is a lot of test flakage unfortunately but I do not believe it is due to this PR.

The clang-tidy issue look legit. Can you fix them? We need to burn through pre-existing issues on master. Thank you!
/wait

OK this is ready for another look.


Improve article 2105.06755

Exact location of issue
End of article at https://ar5iv.labs.arxiv.org/html/2105.06755
Problem details
Despite the log reporting the article is free of errors, it appears that the HTML is malformed - and the rendering of the page gets prematurely truncated.
Would be worth detecting which part of the conversion process is fragile here, since these kinds of issues are rather hard to detect automatically. I spotted the issue randomly, by drawing an article from ar5iv's "feeling lucky" feature.

The truncation in question was transient - the disk holding the ar5iv web service is still quite small, and running out of swap space appears to lead to truncation.
The article mentioned is properly viewable today.


Share on android >= 8.0 crash

crash only appear with android device run android OS >= 8.0 and i'm using React-native-navigation
fileuriexposedexception through ClipData.Item.getUri()

@windydang26 have u completed all the integration steps mentioned in the docs. Also which version of react-native-share are u using?
This issue was solved in #181
This happens when the FileProvider is not implemented on android. file uri cannot be exposed directly on android, so we need to convert file uri into content uri using FileProvider.

sorry! i'm using RN 0.55.4 and RN-share 1.0.23. thank u. i will try newest version and feedbacku later

@kkbhav thank u for response. I've updated RNShare to newest version (1.0.27) but i see other issue.
same #270 . But i'm using React-native-navigation so i don't know way to integrated RNShare with RNNavigation. Can u any idea to resolve my issue? thank.

@windydang26 In your MainApplication.java or MyApplication.java file, you should implement ShareApplication as mentioned in the installation instructions. After that add getFileProviderAuthority method in this class which returns the fileprovider authority.

Yes @kkbhav, i have seen installation doc. But i'm using React-native-navigation.  My code in MainApplication.java:
public class MainApplication extends NavigationApplication {

so i can't integrated this lib with RNnavigation as guide.

@windydang26 we also have an app with react-navigation + react-native-share and we aren't experiencing this behaviour.

I have the same issue here. i'm using wix/react-native-navigation. I don't know to how to implements ShareApplication  because in my MainApplication.java file see like below. May you help me with this?

// public class MainApplication extends Application implements ReactApplication {
public class MainApplication extends NavigationApplication {

  // private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {

    @Override
    public String getJSBundleFile() {
      return CodePush.getJSBundleFile();
    }

    // @Override
    public String getFileProviderAuthority() {
      return "com.quantedge.equixnext.provider";
    }

  //   @Override
  //   protected boolean getUseDeveloperSupport() {
  //     return BuildConfig.DEBUG;
  //   }
  //
  //   @Override
  //   protected List<ReactPackage> getPackages() {
  //     return Arrays.<ReactPackage>asList(
  //         new MainReactPackage(),
            // new FingerprintPackage(),
            // new RNDeviceInfo(),

  //     );
  //   }
  // };
  //
  // @Override
  // public ReactNativeHost getReactNativeHost() {
  //     return mReactNativeHost;
  // }

  @Override
  public boolean isDebug() {
    return BuildConfig.DEBUG;
  }

  @NonNull
  @Override
  public List<ReactPackage> createAdditionalReactPackages() {
    // Add the packages you require here.
    // No need to add RnnPackage and MainReactPackage
    return Arrays.<ReactPackage>asList(
      new VectorIconsPackage(),
      new LinearGradientPackage(),
      new ReactNativeConfigPackage(),
      new SplashScreenReactPackage(),
      new RNFetchBlobPackage(),
      new PDFView(),
      new RNSoundPackage(),
      new CodePush(BuildConfig.CODEPUSH_KEY, MainApplication.this, BuildConfig.DEBUG), // Add/change this line.
      // new NavigationReactPackage(),
      new RNFirebasePackage(),
        // add these optional packages as appropriate
      new RNFirebaseAdMobPackage(),
      new RNEventSourcePackage(),
      new RNFirebaseAnalyticsPackage(),
      new RNFirebaseAuthPackage(),
      new RNFirebaseRemoteConfigPackage(),
      new RNFirebaseCrashPackage(),
      new RNFirebaseDatabasePackage(),
      // new RNFirebaseMessagingPackage(),
      new RNFirebasePerformancePackage(),
      new RNFirebaseStoragePackage(),
      new BlurViewPackage(),
      new ReactNativeRestartPackage(),
      new LocalAuthPackage(),
      new FIRMessagingPackage(),
      new MPAndroidChartPackage(),
      new ReactMaterialKitPackage(),
      new ReactNativeI18n(),
      new RNSharePackage(),
      new PickerViewPackage(),
      new RNDeviceInfo(),
      new ExtraDimensionsPackage(),
      new RNVersionCheckPackage(),
      new RNDetectNavbarAndroidPackage(),
      new FingerprintPackage(),
      new ReactNativeExceptionHandlerPackage(),
      new OpenSettingsPackage()
    );
  }

  @Override
  public void onCreate() {
    super.onCreate();
    Reprint.initialize(this);
    SoLoader.init(this, /* native exopackage */ false);
  }
}

@jgcmarins to resolve this bug have to set:
class MyApplication extends Application implements ShareApplication, ReactApplication {

however currently my code:
public class MainApplication extends NavigationApplication {

how way to integrate react-native-share with react-native-navigation?

can't you use NavigationApplication along side ShareApplication and ReactApplication?

You should write it like this:
public class MainApplication extends NavigationApplication implements ShareApplication {
  @Override
  public void onCreate() {
    // Your code
  }

 // Other methods.....

  @Override
  public String getFileProviderAuthority() {
    return "me.houm.fileprovider";
  }
}

i have done by instructions but get error:

Have you ever seen it?

i think you forgot the import the ShareApplication.
You should insert the following line along with the other imports in the MainApplication file:
import cl.json.ShareApplication;

@kkbhav no, i'm sure that i already import ShareApplication in my MainApplication.java file

@kkbhav , @jgcmarins i'm so sorry! my fault. i haven't update lib to newest version. i'm using<EMAIL_ADDRESS>after i update to newest version (1.0.27) everything working fine!
this bug can close now.

Thats great!


Implement EnumerateAudioDevices for FMOD

Next step would be to use FMOD callbacks to update device list (currently it is updating devices every update).
https://fmod.com/resources/documentation-api?version=2.0&page=core-api-system.html#system_setcallback
There is a specific callback for device list changes named FMOD_SYSTEM_CALLBACK_DEVICELISTCHANGED
Are you ok with this?

That sounds good to me. Do you plan to add that to this PR or do you want me to go ahead and merge it?

I can't get the callback working on my linux right now, seems it's an OS issue because even the getNumDrivers() remain the same while I plug/unplug different audio devices to my PC.
From what I've read from the FMOD forums, they are checking difference using getNumDrivers() to fire the callback so it's pretty much the same as what you've done in your C# implementation.
I will give it a try on a Windows machine and maybe contact the FMOD support to know a bit more about that.
I think you can keep the PR open for now, I'll let you know if I have any news.

I've implemented callback interop, that part is working fine.
I still get the problem about linux not detecting device changes but it doesn't break anything.
The PR is almost ready, I'll do some more tests on Windows tomorrow before merging.
I've removed all the sealed keywords in the two implementation classes since they are already sealed.
Out of subject question: is there any reason you are using the "capital named" primitive types? (Like String vs string or Boolean vs bool)

I've fixed the last bug I had about the GC collecting the callback.
PR is ready!

Out of subject question: is there any reason you are using the "capital named" primitive types? (Like String vs string or Boolean vs bool)

I have Visual Studio configured to show reference types and value types in different colors, which helps me see potential issues with garbage collection. This doesn't work if you use the type keywords, because all keywords have the same color.

This PR looks good to me with the exception noted above; if you can fix that, I'll merge it.


feat: add distribution API

Issue #, if available:
Description of changes

Adds the Distribution API, as documented here https://docs.docker.com/reference/api/engine/version/v1.43/#tag/Distribution
Refactored some code out of the Image service as it was useful for the new Distribution service as well
Regenerating mocks caused minor diffs in 2 existing files (reordering/adding whitespace)

Testing done

Unit tests for new API handler (76%) and service (85%)
Manual testing using docker-py, and comparison to other implementations

Contribution agreement

[x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nit: Requesting change heading to Image Distribution API (Distribution API in itself is a thing)

LGTM: Should we contribute it to nerdctl long term?


HB-5890: namespace BannerSize to be more specific

VungleAdsSDK.BannerSize vs ChartboostMediation.BannerSize

Can we just merge this to main?

Can we just merge this to main?

Sure we could. It's updated now. Thanks!


Remove CreateMeABus and JustSayingFluently

Resolves #471
The git commit history of this PR perhaps tells a good story of how this refactoring was made. Here's an outline of the steps:

Pushed the naming convention application out to extension methods, and removed those methods from JustSayingFluently
Removed public members that weren't called by JustSaying internals (i.e. the old fluent interface)
Where the public members called private members, inlined the private ones
Removed methods that passed-through to JustSayingBus, and call the bus directly.
Move the code for creating subscriptions/publications up to the ISubscriptionBuilder/IPublicationBuilder types.
Removed JustSayingFluently and friends

I've created this PR to move the async blocking code further up, this has been bugging me for a long time. Now we only block during the DI registrations.
https://github.com/gkinsman/JustSaying/pull/51

Looks like we'll need to add some new tests to the fluent API to bump the coverage back up.

Yeah it looks that way - going to port those tests to the new API now 🙂


add overloads with ttl parameter to Insert functions on ICqlWriteClient and…

For https://datastax-oss.atlassian.net/browse/CSHARP-395 (Mapper: Support TTL and timestamp)
When trying to implement this, I was looking at what CqlQueryOptions is used for.  These properties are typically used to decorate an IStatement.  In this case I believe the ttl is only put into the actual query, rather than serializing it into query_parameters.
Also considering that:

CqlQueryOptions is mainly write-only
Currently the only way to read from it is to call CopyOptionsToStatement(IStatement)
Ttl does not belong on the statement

I would need to break this quasi-write-only idiom in order to read from Mapper and CqlBatch.
If you still feel ttl should be on CqlQueryOptions, let me know and I'll file a new PR.

This might be a dupe of #90, however the comments there by @jorgebay indicate that this is undesired on IMapper/CqlQueryOptions and we should use the linq component instead.  This contradicts CSHARP-395.
I will review how to do this using the linq component.  Perhaps this is not necessary.

Good call for making this only available for the insert methods, as those relies on query generation. Update methods can include it within the query.
Apart from the methods overload comment, looks good to me.
I will create a separate ticket for timestamp support in the mapper, that do belong at CqlQueryOptions level.

Updated PR with new overloads.  If I overload and add it as optional I get a R# warning that

Method with optional parameter is hidden by overload

Not exactly a fatal warning, but thought I'd take the hint and not overload with optionals.  I'll defer to your judgement if these signatures are correct.  I'm fine reworking them if you'd like.

Good call for making this only available for the insert methods, as those relies on query generation. Update methods can include it within the query.

@jorgebay I only excluded it because currently we do not have a requirement to set TTL on update.
Thinking about it more closely I'm actually not sure I agree that it should be excluded :) (although maybe I'll do another PR to keep this one simpler)
Those that are using the mapper for the poco->Cql generation may wish to set TTL on update.  This is my reasoning for wanting TTL on insert.

Thinking about it more closely I'm actually not sure I agree that it should be excluded :)

Remember that users can specify the query in the Update() method of the mapper.
mapper.Update("UPDATE tbl SET x = ? WHERE id = ? TTL ?", x, id, ttl);

Pushed new commits to address the issues raised by @jorgebay.

Added a few tests (58b448e40a8e18e4445b94066bb4662c761e71ce) and landed in 43c5a8e59d041e278749fd685dc4ae2bfefbb617.
Thanks!


interactive window and jupyter notebook not starting

Hello, I seem to be having an issue with getting interactive windows and jupyter notebooks to work.
VS code is telling me to open the Developer: toggle developer tools and inside there it says.
extension activation failed Error: Unable to write into user settings. Please open the user settings to correct errors/warnings in it and try again.
If you could assist it would be appreciated.
Environment data

VS Code version: 1.58
Jupyter Extension version v2021.8.1013163132
Python Extension version : v2021.6.944021595
OS: Running WSL (Ubuntu 18.04) on Windows 10
Python and/or Anaconda version: 3.7.5
Type of virtual environment used N/A
Jupyter server running: Local

Expected behaviour
opens interactive window and runs code
and
opens jupyter notebooks and runs code
Actual behaviour
interactive window opens but code is never run. It just sits there loading.
and
jupyter notebook only opens in raw text format.
let me know if I can provide anything else

Error: Unable to write into user settings. Please open the user settings to correct errors/warnings in it and try again.

That message suggests that your user settings file has invalid content. If you open your user settings.json, do you see any squiggles flagging errors in the contents, and if you fix them does the extension start working?

yes, there was an issue there.  It all seems to be working now. thankyou


Add file_type to DataFile to support deletion file

This is for https://github.com/apache/incubator-iceberg/issues/359.

Linking this PR to https://github.com/apache/incubator-iceberg/issues/824 just so this is easy to find from the issue :-)

@rdblue , Could you please help to take a look at this?

Close this due to duplicated with https://github.com/apache/incubator-iceberg/pull/1030


[Grid] Demo page renders improperly in IE11

When visiting https://material-ui.com/layout/grid/ and comparing the resulting page in IE11 with what appears in chrome there are clear layout issues visible which undermine confidence in this library's ability to support IE11.
Particular issues occur in the top-right "page contents" area, the CSS Grid Layout example, and the white-space: nowrap; example.

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
Page should render correctly. See Chrome for example.
Current Behavior
Page renders improperly.
Steps to Reproduce
Compare https://material-ui.com/layout/grid/ in IE11 vs Chrome (latest)
Context
Our team is trying to use Material UI for a complex application that requires IE11 support and noticed that performance, in particular with the layout and the menu, was also unacceptably slow. We also noted that the Material UI team states they are supporting unit tests in the following browsers but IE11 is omitted:
Material-UI has 1200+ unit tests running on Chrome 49, Firefox 45, Safari 10 and Edge 14.
Can we expect these issues to be addressed in the future or does the Material UI team anticipate dropping support for IE11 entirely? This would help us plan for the future.
Your Environment

Tech
Version

Material-UI
v3.5.1

Browser
IE11

There are 3 things that we need to address separately:

run unit tests in IE11
run visual regression tests on different browsers/render engines
improve performance

The first point is held back by some incompatibility issues with the testing libraries we use. We should be able to make it work though.
Visual regression tests are fairly expensive and even if we would pass on the lowest supported versions we would still have no guarantee that something didn't break between e.g. chrome 50 and 51. So for something like testing if the demos render properly we would need visual regression test not only unit tests which might require using another testing library. Would like to know how and if other bigger component libraries do that.
The third point needs proper benchmarks. I guess @oliviertassinari started this effort with the @material-ui/benchmark package but as far as I know we don't automatically track the status via e.g. CI (or github actions) yet.

@eps1lon Thanks for your reply. Can I infer then from your statement on #1 that the Material UI team intends to continue supporting IE11 for the foreseeable future?
As for the IE11 specific performance issues / rendering problems would the Material UI team benefit from additional examples of these or is resolution simply a WIP and consumers just need to be patient?

When visiting https://material-ui.com/layout/grid/ and comparing the resulting page in IE11 with what appears in chrome there are clear layout issues visible which undermine confidence in this library's ability to support IE11.

@doncarron We are using Material-UI in production at https://www.onepixel.com/. IE 11 has as almost as much traffic as Firefox on our product, it's something we care about. IE 11 support of our core component has been handled a long time ago. In this case, I believe it's only impacting demos of our documentation, not the core components. IE 11 support of our documentation is a different story. We have made some progress recently. It used to be a blank page.

the CSS Grid Layout example

We explicitly warn about it, it's just a demo no using our core components. I guess we can add a ⚠. As for the other demos, we should be able to sort that out.

run unit tests in IE11

@eps1lon 💯 with that. I wish we could run the tests with Chrome 41 too, it's even more important from an SEO point of view.

run visual regression tests on different browsers/render engines

IMHO it's overkill (cost/value), we "rarely" have visual issue between browsers, most of them are quickly reported by our users and fixed.

improve performance

How can we reproduce the issue? Material-UI performance is relatively good. Hook migration will help, emotion backend can help, benchmarking we should start with.

As for the IE11 specific performance issues / rendering problems would the Material UI team benefit from additional examples of these or is resolution simply a WIP and consumers just need to be patient?

We don't have a setup for benchmarks in IE11 but you can always file an issue with a repro and we can take a look. But we need to evaluate each of those individually. For example we are currently not using PureComponent anywhere (or React.memo) so if you rerender critical parts of your component tree just with the basic mui components then you would probably gain the most by wrapping them in a memoized component and making sure that the props are correctly memoized. But again all of this is pure speculation without a benchmark.

run visual regression tests on different browsers/render engines

IMHO it's overkill (cost/value), we "rarely" have visual issue between browsers, most of them are quickly reported by our users and fixed.

Completely agree. Adding this would add quite a bit of extra time to our CI tasks. This would probably be a candidate for some long running background task that doesn't block merges but warns once it detects a regression.

7d2070fb388295d38806ecc49717006f34393e74 solves the visual issue, you can verify on https://material-ui.netlify.com/layout/grid/. @eps1lon Is working on the IE 11 test suite.

Thanks for your attentiveness. That said there are still issues remaining that I mentioned earlier.
The "page contents" area:

The "Material UI grid" (I get that the CSS Grid Layout won't work...)

Our organization would definitely like to leverage Material UI in a larger manner so we will work on producing examples that demonstrate the performance issues.
Thanks!

@doncarron We investigated running unit tests in IE 11 and this is currently not viable. See https://github.com/mui-org/material-ui/pull/13642#issuecomment-440303752 for an in-depth explanation. TL;DR: facebook components and react itself isn't unit tested in IE 11 either. But running unit tests in the supported browsers is only part of supporting a specific browser anyway.

@eps1lon Thanks for looking into it. I raised the unit testing concern only to reinforce my question as to whether or not a commitment was being made to IE11 - not because I personally felt it would make a difference identifying the kinds of issues that could occur. Based on your own statements as well as @oliviertassinari it is clear IE11 support is still a focus for the Material UI team.

The "Material UI grid" (I get that the CSS Grid Layout won't work...)

It's expected, it's not supposed to work.

The "page contents" area:

Let's fix that.

@doncarron The table of contents issue should be fixed with 52e82047403df9019d773b69d7fae26a43804611.

@doncarron Every detail counts!


Misleading exception while failing to deserialize an argument is passed in Navigation Service

When I pass in a Model that has a property of type Windows.UI.Xaml.Media.Brush it leads to a StackOverflowException rather I think it should throw a DeserializationException or a Runtime Exception with a message or such sorts.

That is misleading. Do you have a call stack you can share?


Add Mend(Whitesource) GitHub Action and other security scans applicable

Refer to other Modus repositories for how to use trimble-oss/gh-actions/mend-scanner
Check if we need Rapid7, Tenant, Crowdstrike scans too.

@enowak1031
Configured Mend(White Source) GitHub action and submitted a form for Rapid7, submitted a mail to the cybersecurity team for Tenable scan and Crowdstrike isn't applicable as we are using serverless hosting service.


[Question] Is there a reason for not longer using lsp?

Some parts of the codebase still reference the use of lsp (not the Neovim lsp api like for text edits, but doing requests to external language servers using the neovim client) and checking out really old commits I found that this plugin used to make requests to external language servers. Is there a reason why this is no longer the case?

@TheLeo If I'm remembering correctly, we found that we could do most of the desired refactors just via treesitter, which was much more lightweight than doing the same operations than using an LSP (at least that's what I remember, things could have changed by now). The other issue was adding multiple lsp's do the CI was a giant headache that also extended the runtime by a lot. So I would be hesitant to add back using lsp unless there was a good use case for using one. Where you thinking of using one for a specific use case?

@teddylear Thanks for the answer. I was just confused with some parts of the code (particularly the lsp.lua file). Diggin a bit in older commits I fond that this was once used, but it no longer is. So, since the plugin isn't using LSP right now, is safe to remove this parts of the codebase?

Hmm I never even noticed that. I think if we aren't using it we could probably get rid of it. Later on if we manage the task of actually integrating LSP into this plugin, we can pull related files out of the commit history.


angular-cli 19.0.4 starts throw error while vite dev server processing seedrandom when using require('crypto')

Is this a regression?
No
Description
after landing commit to 19.0.4 angular-cli we got errors in ng serve mode.
Dependency seedrandom trying to require('crypto') and that cause problems when processed by vite.
seedrandom not updated 5 years, looks like logic should patched in falso or implemented from scratch.
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
➜  Local:   http://localhost:4200/ibc
  ➜  press h + enter to show help
✘ [ERROR] The package "crypto" wasn't found on the file system but is built into node. [plugin angular-browser-node-built-in]

    node_modules/seedrandom/seedrandom.js:265:27:
      265 │       nodecrypto = require('crypto');
          ╵                            ~~~~~~~~

Please provide the environment you discovered this bug in
No response
Anything else?
No response
Do you want to create a pull request?
No

I also encountered this error. A simple update to angular-cli version 19.1.0-next.0 fixed it.


How can I set the theme for the compiler?

I get hundreds of errors like this:
The style 'backgroundColor' is only supported by type 'VBox' with the theme(s) 'halo,spark'.
This error only appears on the editor. The build works fine. I saw on your sourcecode that you disable themes when on editor. Perhaps this is the cause?
https://github.com/BowlerHatLLC/vscode-nextgenas/blob/af2fad91632f54c6f0aa643f5e33f27882c462a5/language-server/src/main/java/com/nextgenactionscript/vscode/ActionScriptTextDocumentService.java#L4818

Just to be sure that I fully understand the situation, are you using a custom theme? Or are you seeing these errors even when you use the default Flex theme?

Not sure in this exact spot since I'm only doing a form out of a huge project. I believe it's the default Flex theme.
      <theme>          <filename>themes/Spark/spark.css</filename>       </theme>

Is that XML from a custom config file that you include with the -load-config compiler option?

It's the output xml from --dump-config from Flex Builder

Understood. Yes, that's probably the default theme from the SDK. Thanks! I'll take a look.

Attaching some code that reproduces this issue.
<?xml version="1.0" encoding="utf-8"?>
<s:Application xmlns:fx="http://ns.adobe.com/mxml/2009"
	xmlns:s="library://ns.adobe.com/flex/spark"
	xmlns:mx="library://ns.adobe.com/flex/mx">
	<mx:VBox backgroundColor="0xff00ff"/>
</s:Application>


Run command with local flavor and configurable IP addr

A simple way to run the app on the phone but connect to a local (any) coordinator via IP.

This command makes it easy to quickly change to another machine that runs the setup, assuming the default ports and the checked in coordinator seed.
I am not sure if we want to do anything with this, but it made me think about our configuration in general.
At least for the (local) regtest setup the only thing that usually changes is the host machine's IP, maybe we can simplify the configuration to extract the IP and only set that instead of all the other parameters.

Note: I only configured the local flavor for Android - if we want to keep this command we could consider adding a flavor iOS as well.

@da-kami I'll carry this over the finish line - thank you the PR ❤


Pull Request for LinkHeader support

We would like to extend traverson to consume an API that returns the links using the LinkHeader specification [1].
Our first approach is to create a new LinkHeaderAdapter adapter. This adapter makes use of the "parse-link-header" library [2] to parse the links contained in the header of the HTTP response.
Once the LinkHeaderAdapter is registered, we are able to traverse the relation of the links, from an angular client, in the same way as for HAL.
When using HAL, getResource callback is invoked by passing a parsed Resource. This Resource contains a collection of links in _links property of the object, as it is defined in HAL specification.
However that is not the case for LinkHeaders, as the collection of links is not contained in the object of the response.
After our analysis we identified that a good approach could be to upgrade findNextStep method in LinkHeaderAdapter so that appart from the URL it could return the collection of links to be stored in the actual step. The remaining decision is how should we pass the collection to the final callback.
One option could be to define a new method in the adapter called onParsedBody. Traverson should invoke it after the parser sets the doc in the step. In this way, the adapter will be able to include additional properties in the returned doc, in our case the collection of links:
function parseBody(t) {
  log.debug('parsing response body');
  if (t.requestOptions && t.requestOptions.jsonReviver) {
      t.step.doc = t.step.response.body;
  } else {
      t.step.doc = t.jsonParser(t.step.response.body);
  }
  if (t.adapter.onParsedBody) {
      t.adapter.onParsedBody(t);
  }
}

This design is obviously our initial proposal, we are open to do any change you may think it is interesting in other to properly adapt it to the library.
Would you be interested in letting us make a PR to include this changes inside traverson? :)
[1] https://www.w3.org/wiki/LinkHeader
[2] https://github.com/thlorenz/parse-link-header

I like the idea of supporting the link header very much!
Some things to consider:

If I understand your proposal, you would provide LinkHeader as a separate Adapter. Adapters are intended to support different media types, like HAL, Mason, etc - kind of like a plug-in system. (Though I never got around to implement another adapter besides the basic JSON adapter and the HAL adapter). I am not 100% sure if the Link header can be considered a different media type, or if users should be able to use Link headers in combination with another media type? Then implementing it as an Adapter would be the wrong way, instead it would have to be a feature of Traverson's core functionality.
Traverson already provides support for the Location header, see https://github.com/basti1302/traverson/blob/master/api.markdown#configuration-methods (look for followLocationHeader(). However, using the location header can be inserted as a single step in the middle of following "normal" links that are contained in the response body. Thus, you can mix normal link traversal and Location header usage freely. Using the Link header the way you suggest it would have a very different API and a different feel from using the Location header. Maybe this is okay, because the two headers are used differently anyway, I'm not sure yet.
An implementation detail: thlorenz/parse-link-header uses the url module from Node. Be aware that Traverson's package.json defines a shim for this Node core module to reduce the browserified file size, see here. Depending on which features of the url module parse-link-header needs, this might be an issue.
You already identified the findNextStep method of the adapter as a potential place that needs to be changed. If you have a look at JsonAdapter's findNextStep method you can see that it already deals with headers (currently only with the Location header, see above). Could this be used to also support the Link header? I'm really not sure, it is just an open question.

Kind regards
Bastian

Hi Bastian!

I like the idea of supporting the link header very much!

Nice!

As you say can not be considered as a different media type and the adapters are linked to the media type, but we believe that it will not be used in combination with other adapters. However we have no preference whether if it is an adapter or is supported by the core.

Could be done in the same way as for Location but, if possible, we would like that in the expression of the follow() we would not have to specify the type each time :)

Upss, it is a detail that we had not taken into account. We'll have to look at it.

Yes, it can be used.  In the case of Link Header, findNextStep() must parse the headers to return the next step.
But in addition to returning the step we want that in the last step, when traverson is asked for a getResource(), in the resource comes a property _links including the extracted links of the header.

Hi Bastian!, Is there anything in which we can help you to integrate the PR? or any modification you would like to be done before including it?
Do not hesitate to ask us any change :)

Let's continue the discussion in the PR, not here.
Closing in favor of #85.


Shows password in console

$ emerald transaction <....>
Enter passphrase:
testtest

Password shouldn't be visible

Same for creation:
$ emerald new --chain testnet --name test
! Warning: passphrase can't be restored. Don't forget it !
Enter passphrase:
test

Created new account: 0x406af411b366c393ae6baf3a2511e6503a3449e8


LeetCode 75 Solutions

Add your solutions for the LeetCode 75 🎯 plan.
🧑💻Create seperate folders for different languages and upload your best solution with explanation.
LeetCode75

C++
Java

Link🔗 : https://leetcode.com/studyplan/leetcode-75/

Hi @DHEERAJHARODE, I would like to work on this issue. Can you please assign this task to me.

Hello sir can you please assign this to me

Pls assign this task to me

Please assing the task to me too. I have much knowledge of c++ and have good problem solving skills

I wish to contribute. Kindly assign me this issue.


Fill out the java docs

Our documentation on the Java side is somewhat anemic.
https://docs.flutter.io/javadoc/
For example, FlutterView has many members with no documentation at all.

Supposedly http://checkstyle.sourceforge.net/ can tell us javadoc coverage infos.

Closing this ticket in favor of numerous granular Javadoc tickets that can be found in the Platform Embedding project:
https://github.com/flutter/flutter/projects/27


cache nix store

Cache Nix dependencies and binary for faster CI runtime

I was a bit surprised that there was not a single command to copy all nix-related directories at once but otherwise this looks good to me.

We have the Nix copy command https://nixos.org/manual/nix/stable/command-ref/new-cli/nix3-copy.html which copies the Nix store and allows us to restore for every consecutive workflow run, I tried using nix copy but fail to cache due to some unsigned nix denpendencies and also fails to copy dependencies that we build, e.g. rust-overlay which builds Rust and its tools, so I decided to just copy the Nix state and cache as-is.

I was a bit surprised that there was not a single command to copy all nix-related directories at once but otherwise this looks good to me.

We have the Nix copy command https://nixos.org/manual/nix/stable/command-ref/new-cli/nix3-copy.html which copies the Nix store and allows us to restore for every consecutive workflow run, I tried using nix copy but fail to cache due to some unsigned nix denpendencies and also fails to copy dependencies that we build, e.g. rust-overlay which builds Rust and its tools, so I decided to just copy the Nix state and cache as-is.


Updating p455w0rdslib causes Refined Storage to crash

Updating p455w0rdslib-1.12.2-2.3.161 causes Refined Storage to crash
What happens: Launcher crashes
crash log: https://pastebin.com/Y2pEhmwV
What you expected to happen:
finish launching
Steps to reproduce:

Roll back p455w0rdslib
No crash
Reinstall p455w0rdslib-1.12.2-2.3.161 and immediate crash
...

Version (make sure you are on the latest version before reporting):

Minecraft:
Forge:
Refined Storage:

Does this issue occur on a server? [yes/no]
If a (crash)log is relevant for this issue, link it here:
[https://pastebin.com/Y2pEhmwV]

https://github.com/p455w0rd/p455w0rds-Library/issues/61

I'm assuming this is fixed?